Not able to deploy K8s Cluster with ACS-Engine 14.6 version on azure

Is this a request for help?:

Is this an ISSUE or FEATURE REQUEST? (choose one):
ISSUE
What version of acs-engine?:
acs-engine v0.14.6

Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
kubernetes 1.9.0
What happened:
I have deployed K8S cluster using acs-engine v0.14.6 . After cluster deployes I am not able to see any nodes listed. I have checkd docker images and docker container where any containers are not created.
Docker Images:
root@k8s-master-63864159-0:/var/lib/waagent/Microsoft.Azure.Extensions.CustomScript-2.0.6/status# docker images
REPOSITORY                                TAG                 IMAGE ID            CREATED             SIZE
k8s-gcrio.azureedge.net/hyperkube-amd64   v1.9.0              0e4e0ed658bb        3 months ago        618 MB
Docker PS:
root@k8s-master-63864159-0:/var/lib/waagent/Microsoft.Azure.Extensions.CustomScript-2.0.6/status# docker ps
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
root@k8s-master-63864159-0:/var/lib/waagent/Microsoft.Azure.Extensions.CustomScript-2.0.6/status#
What you expected to happen:
Kubernetes cluster should get deployed with Kubeernetes V 1.9.0 using acs-engine v0.14.6
How to reproduce it (as minimally and precisely as possible):
acs-engine generate
Anything else we need to know:
Extension Status:
root@k8s-master-63864159-0:/var/lib/waagent/Microsoft.Azure.Extensions.CustomScript-2.0.6/status# cat 0.status
[
{
"version": 1,
"timestampUTC": "2018-04-04T15:15:45Z",
"status": {
"operation": "Enable",
"status": "error",
"formattedMessage": {
"lang": "en",
"message": "Enable failed: failed to execute command: command terminated with exit status=3\n[stdout]\n\n[stderr]\n"
}
}
}
I have tried many version from acs-engine v 0.12.0 to 0.14.6 andy of the version is not deploying kubernetes cluster

@rakeshkulkarni6 please remove all secrets/keys from the apimodel you shared

@rakeshkulkarni6 can you please try deploying with k8s 1.9.6? There are known upstream bugs in 1.9.0

Hi @CecileRobertMichon ,
Again its sowing same error, Please find the below error details.
it seeme the extension is not able to provision script to deploy Kubernetes cluster.
New-AzureRmResourceGroupDeployment : 1:24:27 PM - Resource Microsoft.Compute/virtualMachines/extensions
'k8s-master-63864159-0/cse0' failed with message '{
"status": "Failed",
"error": {
"code": "ResourceDeploymentFailure",
"message": "The resource operation completed with terminal provisioning state 'Failed'.",
"details": [
{
"code": "VMExtensionProvisioningError",
"message": "VM has reported a failure when processing extension 'cse0'. Error message: "Enable failed: failed to execute
command: command terminated with exit status=3\n[stdout]\n\n[stderr]\n"."
}
]
}
}'
At line:1 char:1

New-AzureRmResourceGroupDeployment -Name smatestpoc -ResourceGroupNam ...

  + CategoryInfo          : NotSpecified: (:) [New-AzureRmResourceGroupDeployment], Exception
  + FullyQualifiedErrorId : Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.NewAzureResourceGroupDeploymentCmdlet

New-AzureRmResourceGroupDeployment : 1:24:27 PM - VM has reported a failure when processing extension 'cse0'. Error message:
"Enable failed: failed to execute command: command terminated with exit status=3
[stdout]
[stderr]
".
At line:1 char:1

New-AzureRmResourceGroupDeployment -Name smatestpoc -ResourceGroupNam ...

  + CategoryInfo          : NotSpecified: (:) [New-AzureRmResourceGroupDeployment], Exception
  + FullyQualifiedErrorId : Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.NewAzureResourceGroupDeploymentCmdlet

New-AzureRmResourceGroupDeployment : 1:24:27 PM - Template output evaluation skipped: at least one resource deployment operation
failed. Please list deployment operations for details. Please see https://aka.ms/arm-debug for usage details.
At line:1 char:1

New-AzureRmResourceGroupDeployment -Name smatestpoc -ResourceGroupNam ...

  + CategoryInfo          : NotSpecified: (:) [New-AzureRmResourceGroupDeployment], Exception
  + FullyQualifiedErrorId : Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.NewAzureResourceGroupDeploymentCmdlet

New-AzureRmResourceGroupDeployment : 1:24:27 PM - Template output evaluation skipped: at least one resource deployment operation
failed. Please list deployment operations for details. Please see https://aka.ms/arm-debug for usage details.
At line:1 char:1

New-AzureRmResourceGroupDeployment -Name smatestpoc -ResourceGroupNam ...

  + CategoryInfo          : NotSpecified: (:) [New-AzureRmResourceGroupDeployment], Exception
  + FullyQualifiedErrorId : Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.NewAzureResourceGroupDeploymentCmdlet

I have used vlabs in apiversion and kept dnd prefix empty in agentpoolprofile.still I am getting above error while deploying can you please help I need to setup production cluster using ACS-ENGINE

I got similar error when deploying cluster using 14.6 acs-engine version.
"error": {
"code": "ResourceDeploymentFailure",
"message": "The resource operation completed with terminal provisioning state 'Failed'.",
"details": [
{
"code": "VMExtensionProvisioningError",
"message": "VM has reported a failure when processing extension 'cse0'. Error message: "Enable failed: failed to execute
I deleted the deployment and redeployed the cluster in to a new resource group with kubernetes version 1.9.5
it got deployed successfully and working fine with out any errors.

@rakeshkulkarni6 @rakidu I am trying to repro this error. It looks like 14.6 might have introduced a regression causing transient deployment errors (possibly a race condition). In the meantime, if you retry you might get lucky and get a working cluster @rakeshkulkarni6. If you still have a cluster that failed with this error can you please share the content of /var/log/azure/cluster-provision.log on your first master please?

I am seeing a similar issue with version 15.1 of acs-engine and version 1.8.9 of kubernetes.  I am trying to deploy an cluster into an existing vNet.  The vNet has multiple subnets, but I am getting the same error when deploying master & agents to the same subnet or splitting the master & agents into different subnets.

Same here with 15.2 and 3 masters, 3 agents.
In azure portal I get the already documented error message for all 3 masters (cse0, cs1, cse2).
The last lines from /var/log/azure/cluster-provision.log:
++ /usr/local/bin/kubectl get nodes
++ grep Ready
++ wc -l
+ nodes=5
+ '[' 5 -eq 6 ']'
+ sleep 1
+ '[' 1 -ne 0 ']'
+ echo 'still waiting for active nodes after 1800 seconds'
still waiting for active nodes after 1800 seconds
+ exit 3
@CecileRobertMichon I tried now many times hoping to get the cluster deployed once, but had no luck...

I also got this, acs-engine 0.15.2, kubernetes 1.9.6 and 1 master, 4 agents.
cluster-provision.log
Kubernetes master is running at http://localhost:8080

To further debug and diagnose cluster problems, use 'kubectl cluster-info dump'.
+ '[' 1 = 0 ']'
+ sleep 1
+ for i in '{1..600}'
+ /usr/local/bin/kubectl cluster-info
Kubernetes master is running at http://localhost:8080

To further debug and diagnose cluster problems, use 'kubectl cluster-info dump'.
+ '[' 1 = 0 ']'
+ sleep 1
+ '[' 1 -ne 0 ']'
+ echo 'k8s cluster is not healthy after 600 seconds'
k8s cluster is not healthy after 600 seconds
+ exit 3

Interestingly, if I run kubectl cluster-info manually, it hangs after posting the master status (which is shown with FQDN, contrary to the log above which has localhost).
With kubectl cluster-info dump I only get:
Unable to connect to the server: dial tcp <master public IP>:443: i/o timeout

Is there any configuration of which it is possible to generate Kubernetes cluster at the moment. I have tried quite a many orchestratorRelease & orchestratorVersion combinations and getting the same error with all of the trials: "VM has reported a failure when processing extension 'cse0'."
Here is my latest trial:
{
"apiVersion": "vlabs",
"properties": {
"orchestratorProfile": {
"orchestratorType": "Kubernetes",
"orchestratorRelease": "1.10",
"orchestratorVersion": "1.10.0",
"kubernetesConfig": {
"privateCluster": {
"enabled": true
}
}
},
"masterProfile": {
"count": 1,
"dnsPrefix": "acsengine01",
"vmSize": "Standard_D2_v2",
"vnetSubnetId": "",
"firstConsecutiveStaticIP": "",
"vnetCidr": ""
},
"agentPoolProfiles": [
{
"name": "agentpool1",
"count": 3,
"vmSize": "Standard_D2_v2",
"availabilityProfile": "AvailabilitySet",
"vnetSubnetId": ""
}
],
"linuxProfile": {
"adminUsername": "",
"ssh": {
"publicKeys": [
{
"keyData": ""
}
]
}
},
"servicePrincipalProfile": {
"clientId": "",
"secret": ""
}
}
}

@CecileRobertMichon thanks for your help. I managed finally getting rid of the issue by changing something in the configs (I guess). I have tried so many times with so many different configurations that cannot keep book any more of those. However, I still faced a couple of issues that I commented to another issue https://github.com/Azure/acs-engine/issues/2476 in case you would have any hints how to work on those. I also shared my configurations there.

@CecileRobertMichon I am trying to create cluster using acs-engine v0.16.0 in China East2 which is a new region but there are lot of errors while running the custom execution script in the master VM. Have changed lot of configurations and the registry Url, able to fetch the images in the master VM but still the provisioning fails with an exit code 30.

echo 'k8s cluster is not healthy after 600 seconds'
k8s cluster is not healthy after 600 seconds
exit 30

Please help

@ankitsingh11 please refer to https://github.com/Azure/acs-engine/blob/master/docs/kubernetes/troubleshooting.md#vmextensionprovisioningerror-or-vmextensionprovisioningtimeout for a guide on troubleshooting these issues and open a new issue if you still need help. I will close this one for now as it is outdated.


fix: Allow macros to change types on each iteration of a comptime loop

Description
Problem*
Resolves https://github.com/noir-lang/noir/pull/6086#issuecomment-2361085425
Summary*
Allows macros to have differing result types on different loop iterations again after it was banned by the unification in #6086.
This is a difficult feature to use since users will still have to work around the type system only type checking loops once. The recommended technique found for this PR is to delay type checks by quoting the relevant function calls that need to be re-typechecked so that when they are unquoted by the interpreter they are forced to be typechecked every loop iteration.
The downside of this is that it requires some knowledge of when to do this. If we go back to the naive approach of comptime_change_type_each_loop_iteration before the quoting:
fn main() {
    comptime {
        for i in 9..11 {
            // Lengths are different on each iteration: "foo9", "foo10"
            let name = f"foo{i}".as_ctstring().as_quoted_str!();
            let hash = from_signature(name);
            assert(hash > 3);
        }
    }
}

fn from_signature<let N: u32>(_signature: str<N>) -> u32 {
    N
}

We get a confusing error now that the unification is gone: "Non-integer array length _" pointing to the body of from_signature. The fix for this is to quote & unquote the from_signature call:
let hash = unquote!(quote { from_signature($name) });

But there's nothing telling users this. Ideally we could warn users when a type changes like this and perhaps have them opt-in to it with a "I know what I'm doing" of some kind.
Additional Context
Documentation*
Check one:

[ ] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

As another consequence of this, the macro_result_type test added in the previous PR has also been moved to compile_failure


revisit service access strategy

May depend on issue #5. We probably want to have NodePort vs. LoadBalancer settable as a site default... and I'm not sure it's even useful to allow overriding it at deploy time.
Also we need to think about supporting Ingress. If that turns into a real project we can split it into a separate issue.

Split Ingress support to issue #113.


How can i install multiple servers?

First of all, Thank you for making docker image to easily install.
I am trying to install mongo shard multiple servers with your docker image.
But,
mongos cannot find shard nodes in another machines. (separated mongos & shard nodes)
mongos:
    image: khezen/mongo:3.4
    container_name: mongos
    environment:
      CONFIG_SERVERS: configsvr/configsvr1:27017
      SHARDS: shard1/192.168.0.x:port shard2/192.168.0.x:port
      STORAGE_ENGINE: wiredTiger

in another machine
shard1_replica1:
    image: khezen/mongo:3.4
    container_name: s1-n1
    environment:
      RS_NAME: shard1
      SHARD_SVR: 'y'
      MASTER: shard1_replica1
      STORAGE_ENGINE: wiredTiger
    volumes:
      - ./data/mongo/shard1/replica1:/data/db
    ports:
      - "27011:27017"
    restart: always

Please let me know solution.
Thank you.

If you want to run mongo on our cluster you need to use tools suchas  docker stack kubernetes  or Cattle. Cheers


TMDL spurious diffs

This version of ALM Toolkit reports differences due to mis alignment of Source to Target comparison.  For columns, it will show a difference but in reality its just in a different location within the BIM.  It will be the same for partitions, showing a difference but in reality its comparing 2 different partitions instead of comparing itself to the same partition.
For the partitions, this started for me after install 5.1.3 and then adding additional partitions & renaming some existing partitions.
I have deployed the source to the target, and the differences are still reported.  Additionally, I used TE3 to deploy BIM files from source to target.  I re ran ALM toolkit and it still reports a difference.  I am not sure why it would show a difference when the BIM files are identical.

A peer with ALM version 5.0.41 found no differences between source and target as expected.  We confirmed we are using the same options when comparing

Hi and thanks for reporting.
This is a known issue - internally referred to as "spurious diffs". It is an issue with TMDL serialization and affects more than just ALM Toolkit. It is documented as a known issue at the bottom of the ALM Toolkit doc.
https://github.com/microsoft/Analysis-Services/blob/master/AlmToolkit/Semantic Model Comparison and Merging with ALM Toolkit.pdf
We have a design to fix it, and the AS team is committed to doing it, but we don't have a timeline yet. In the meantime, if this is a big enough issue, you can switch back to TMSL based diffs by changing the Options setting as described in the doc - and that should result in equivalent diffs to the previous version.

(Another issue that reported this is here for reference: https://github.com/microsoft/Analysis-Services/issues/307)


Flow throws in package's source, but doesn't throw in installed version of package

I faced weird case w/ one of my libs.
Here is the repo: https://github.com/shakacode/react-validation-layer
I ship typedefs within a package (I copy source files w/ .flow suffix).
You can clone it and run flow to make sure that everything's fine (or just look at the CI job).
However, when I add this package to the app and run flow, it throws:

Here is an empty repo to reproduce: https://github.com/alexfedoseev/flow-lib-typedefs-error
Just flow and lib are installed.
If I remove this suppress comment in the package source, it throws there. But if this comment exists in the installed version of the package, flow throws Unused suppression.
Flow versions are identical (0.42.0).

This error exists on<EMAIL_ADDRESS>but not<EMAIL_ADDRESS>any idea why?

This error exists on<EMAIL_ADDRESS>but not<EMAIL_ADDRESS>any idea why?

@aackerman I temporarily removed typedefs from published version of the package, b/c of this issue.

What error do you get when you remove the suppression comment? I'm not seeing an error when I remove it.

Here they are:
yarn run v0.21.3
$ flow --show-all-errors
src/modules/validations/index.js:410
410:             [stateId]: asyncValidator(value).then(results => ({
                            ^^^^^^^^^^^^^^^^^^^^^ function call. Function cannot be called on possibly undefined value
410:             [stateId]: asyncValidator(value).then(results => ({
                            ^^^^^^^^^^^^^^ undefined

src/modules/validations/index.js:410
410:             [stateId]: asyncValidator(value).then(results => ({
                            ^^^^^^^^^^^^^^^^^^^^^ function call
410:             [stateId]: asyncValidator(value).then(results => ({
                            ^^^^^^^^^^^^^^^^^^^^^ undefined (too few arguments, expected default/rest parameters). This type is incompatible with
203:   stateContainer: StateContainer,
                       ^^^^^^^^^^^^^^ ValidationLayer. See: src/types/index.js:203

src/modules/validations/index.js:410
410:             [stateId]: asyncValidator(value).then(results => ({
                                           ^^^^^ boolean. This type is incompatible with the expected param type of
201:   fieldId: FieldId,
                ^^^^^^^ string. See: src/types/index.js:201

src/modules/validations/index.js:410
410:             [stateId]: asyncValidator(value).then(results => ({
                                           ^^^^^ null. This type is incompatible with the expected param type of
201:   fieldId: FieldId,
                ^^^^^^^ string. See: src/types/index.js:201

src/modules/validations/index.js:410
410:             [stateId]: asyncValidator(value).then(results => ({
                                           ^^^^^ number. This type is incompatible with the expected param type of
201:   fieldId: FieldId,
                ^^^^^^^ string. See: src/types/index.js:201

src/modules/validations/index.js:410
410:             [stateId]: asyncValidator(value).then(results => ({
                                           ^^^^^ undefined. This type is incompatible with the expected param type of
201:   fieldId: FieldId,
                ^^^^^^^ string. See: src/types/index.js:201

src/modules/validations/index.js:410
410:             [stateId]: asyncValidator(value).then(results => ({
                                                  ^^^^ property `then`. Property not found in
333: export type DebounceStatusReport = {| status: DebounceStatus |};
                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ object type. See: src/types/index.js:333

Found 7 errors
error Command failed with exit code 2.

Just a quick intro. I have 2 types of async validators:

Common, triggered on blur event and returns a Promise. Nothing special.
Debounced, triggered on change event and debounce wrapper returns an object w/ debounce status (validator itself will be executed later).

A user defines validation strategy and passes simple functions. Under the hood on normalization async validators w/ ON_CHANGE strategy are wrapped in debouncer.
On the problematic line (when validation is triggered), I use only non-debounced validators, but since I determine it by strategy and fields config has nested structure, flow can't infer the type of the validator.


Added some features

Fully implemented go to line control with removing closing on losing focus, added limit to only allow number input and number should be less than number of lines.
Added option to highlight current line.
Added feature to do web search also provided option to change search engine.
Added date/time input to context menu for better discoverability.
Added new item to statusbar to show percentage zoom in editor.
Modified text zooming to increase/decrease by 10%.
Added flyout to line indicator for quick access to word wrap, highlight current line and go to line control.

Superb! I will review and provide feedback. Thanks for the big contribution here.

Superb! I will review and provide feedback. Thanks for the big contribution here.

Glad to contribute, thanks for starting this project.

All the changes suggested are done, and it's ready to be merged.

All the changes suggested are done, and it's ready to be merged.

One more bug I found:

When "Word Wrap" is enabled and :

First, click on second line.
Then click on last character or end of the line of first line.
The highlighter will not change it's postion. Instead it should highlight first line.

When "Word Wrap" is enabled and :

First, click on second line.
Then click on last character or end of the line of first line.
The highlighter will not change it's postion. Instead it should highlight first line.

This seems to be a bug in Richeditbox control, in the above case clicking far from the end of the first part of the line returns the properties for the leftmost position of the next part of the line(you can see that in line column indicator). This only happens when selection is changed by click only ,there is no way to go to that position with arrow keys.

I can't seem to find a way to resolve this.

There is no upper limit of doing "Ctrl+mouse wheel up" or "Ctrl+'+'":
Notice, it shows 630% instead of 500%. Maybe we should cap it to 500% and the IncreaseFontSize method should only increase font size when it is under 500% zooming.

I wanted users to be able to change font size without fondling into settings too much and in case of shadow windows the only way to do so is by "Ctrl+mouse wheel up" or "Ctrl+'+'". In my opinion instead of restricting increase limit showing showing >500% or the actual zooming %  would be a good idea. Let me know your opinion.

When "Word Wrap" is enabled and :

First, click on second line.
Then click on last character or end of the line of first line.
The highlighter will not change it's postion. Instead it should highlight first line.

This seems to be a bug in Richeditbox control, in the above case clicking far from the end of the first part of the line returns the properties for the leftmost position of the next part of the line(you can see that in line column indicator). This only happens when selection is changed by click only ,there is no way to go to that position with arrow keys.

I can't seem to find a way to resolve this.

There is no upper limit of doing "Ctrl+mouse wheel up" or "Ctrl+'+'":
Notice, it shows 630% instead of 500%. Maybe we should cap it to 500% and the IncreaseFontSize method should only increase font size when it is under 500% zooming.

I wanted users to be able to change font size without fondling into settings too much and in case of shadow windows the only way to do so is by "Ctrl+mouse wheel up" or "Ctrl+'+'". In my opinion instead of restricting increase limit showing showing >500% or the actual zooming % would be a good idea. Let me know your opinion.

Ok, sounds good to me. Let's keep what it is. The built-in UWP RichEdit is really annoying...

Also, feel free to add your name here in your PR:

When "Word Wrap" is enabled and :

First, click on second line.
Then click on last character or end of the line of first line.
The highlighter will not change it's postion. Instead it should highlight first line.

I have reported the bug in WinUI repo here.
Also I found a new bug which is related to RichEditBox and reported it here.

Left few more comments. Please take a look. Thanks!

LGTM, ready for merge?

LGTM, ready for merge?

Yes, go right ahead.

LGTM, ready for merge?

Yes, go right ahead.

It's merged but there are some bugs and issues with your changes. I am going to fix it in the next commit.

Selection calculation is wrong comparing to Visual Studio Code. I will revert my previous calculation code.
Set indicator gray out feature will not work properly in some scenarios like window resizing.
I am not sure if DuplicateText() method you touched works as before, can you verify?
GoTo bar LostFocus="GoToBar_LostFocus" is missing.

It's merged but there are some bugs and issues with your changes. I am going to fix it in the next commit.

Selection calculation is wrong comparing to Visual Studio Code. I will revert my previous calculation code.
Set indicator gray out feature will not work properly in some scenarios like window resizing.
I am not sure if DuplicateText() method you touched works as before, can you verify?
GoTo bar LostFocus="GoToBar_LostFocus" is missing.

The selection calculation I implemented rejects line ending characters but vs code calculates it. I can modify the method to show like vs code.
I have  fixed the grey out issue.
DuplicateText works flawlessly in all test cases I tried.
I provided dismiss button for gotobar so the lost focus method not needed.

It's merged but there are some bugs and issues with your changes. I am going to fix it in the next commit.

Selection calculation is wrong comparing to Visual Studio Code. I will revert my previous calculation code.
Set indicator gray out feature will not work properly in some scenarios like window resizing.
I am not sure if DuplicateText() method you touched works as before, can you verify?
GoTo bar LostFocus="GoToBar_LostFocus" is missing.

The selection calculation I implemented rejects line ending characters but vs code calculates it. I can modify the method to show like vs code.
I have  fixed the grey out issue.
DuplicateText works flawlessly in all test cases I tried.
I provided dismiss button for gotobar so the lost focus method not needed.

I think my previous method is more efficient and do not require recalculation if not needed and no string manipulation is needed. So we should keep it.
If you have GoTo bar opened and add or delete lines. The GoTo bar will not update its current line and max, which will cause problem.  LostFocus is good here.

I think my previous method is more efficient and do not require recalculation if not needed and no string manipulation is needed. So we should keep it.
If you have GoTo bar opened and add or delete lines. The GoTo bar will not update its current line and max, which will cause problem.  LostFocus is good here.

For large number of lines for loop might not be efficient, Also storing all the split lines might cause overhead. I have modified the method to act exactly like VS Code. You can choose to keep either one.
The problem with lost focus was when clicked on the hamburger menu the flyout disappears along with the gotocontrol. I have modified the method to dismiss gotocontol when text changed.

@soumyamahunt I am receiving unhandled exception from some of the users:
Exception
Windows.UI.Xaml.Markup.XamlParseException: XAML parsing failed.
Cannot find a Resource with the Name/Key AppBarButtonContentHeight"
OSVersion
10.0.17763.914
Can you help take a look?
It is related to CustomAppBarButtonLabelToRightStyle:

@soumyamahunt I am receiving unhandled exception from some of the users:
Exception
Windows.UI.Xaml.Markup.XamlParseException: XAML parsing failed.
Cannot find a Resource with the Name/Key AppBarButtonContentHeight"
OSVersion
10.0.17763.914
Can you help take a look?
It is related to CustomAppBarButtonLabelToRightStyle:

I used this article to create the custom appbar button. I couldn't reproduce the issue however I am removing the key since it isn't affecting the design in any way. Will submit a pull request soon.

@soumyamahunt I am receiving unhandled exception from some of the users:
Exception
Windows.UI.Xaml.Markup.XamlParseException: XAML parsing failed.
Cannot find a Resource with the Name/Key AppBarButtonContentHeight"
OSVersion
10.0.17763.914
Can you help take a look?
It is related to CustomAppBarButtonLabelToRightStyle:

I used this article to create the custom appbar button. I couldn't reproduce the issue however I am removing the key since it isn't affecting the design in any way. Will submit a pull request soon.

It is happening to Windows 10 1809 only. I am guessing this value is not available there.


Error occurred: RangeError: Array buffer allocation failed

Hi! I upload a file with a size of 170 MB, the viewer gives an error "Error occurred: RangeError: Array buffer allocation failed".
What do you recommend to do?

Maybe it has hit the limit for single string allocation size, due to current parser design which reads the entire file into a single string. An alternative parser implementation is currently is work in progress in 1.x branch (development is a bit stuck currently). Maybe it is something else. Is it possible to get your sample file?

unfortunately, I can't transfer the file, it belongs to another organization


[bug] Group manager not visible from Gamemaster view.

When launching foundry as a Gamemaster there is no group manager visible anywhere on the screen.
Player view still shows group manager and allows to drag, drop, and click to interact:

I am not seeing this issue when I run. I tried it with the Mandar theme as well and still not replicating the issue. If you disable all modules, is it still happening?

I also can't replicate it. @higgindasz can you also include your foundry and star wars versions.

Haven't heard anything on this so this is probably no longer an issue.


[Question] How to build a simple Flask backend for plugins?

🧐 问题描述 | Proposed Solution
How to build a simple Flask backend for plugins? I am not very familiar with js and node, so I am wondering if I can build a Flask backend in Python, but I don't know how to port createLobeChatPluginGateway.
📝 补充信息 | Additional Information
No response

We will add a Python plugin template

When https://github.com/lobehub/lobe-chat/issues/815 get resolved, I think you can just use my template with no changes. Otherwise, the authorization needs to be disabled. Feel free to use my code there.

@arvinxx https://github.com/lobehub/lobe-chat/issues/815 this gets resolved, so my code works fine now. But now the problem is how to use the plugin sdk in non-js code or port it in other languages. I'd like to port this sdk in Rust. Can you give me some guide on how this plugin sdk works in principle.


epgstation: 1.7.4 -> 1.7.5

Motivation for this change

bump version
change existing scripts to make use of passthru.updateScript
change name from node_EPGStation to EPGStation.

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

/marvin needs_merger

Thanks! JFYI the command for changing statuses is /status.
/status needs_merger

Oh.

/status needs_merger

Thanks! JFYI the command for changing statuses is /status.
/status needs_merger

I always mix this up. -.-

Since there are no conflicts I'd just merge this right now

Okay, thanks! Also thank you for the review @wamserma.


Support Swift 5.0 and RxSwift 5.0

Deprecated

RxExpect.input(Variable) is deprecated because Variable is deprecated on RxSwift

Noti
I didn't test Carthage and CocoaPods installation. You should test it...
I also set the version of RxExpect to 1.3.0. Please check and fix or comment, if you want

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #12   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           4      5    +1
  Lines          78     78
=====================================
  Hits           78     78

Impacted Files
Coverage Δ

Sources/RxExpect/AnyTestTime.swift
100% <100%> (ø)
:arrow_up:

Sources/RxExpect/Assertion.swift
100% <100%> (ø)
:arrow_up:

Sources/RxExpect/Deprecated.swift
100% <100%> (ø)

Sources/RxExpect/RxExpect.swift
100% <100%> (ø)
:arrow_up:

Sources/RxExpect/Utility.swift
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa82dc5...cb0da8a. Read the comment docs.

@devxoul can you check this?


[SPARK-35863][BUILD] Update Ivy to 2.5.0

What changes were proposed in this pull request?

Update Ivy from 2.4.0 to 2.5.0.
Why are the changes needed?

This brings various improvements and bug fixes. Most notably, the adding of ivy.maven.lookup.sources and ivy.maven.lookup.javadoc configs can significantly speed up module resolution time if these are turned off, especially behind a proxy. These could arguably be turned off by default, because when submitting jobs you probably don't care about the sources or javadoc jars. I didn't include that here but happy to look into if it's desired.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Existing UT and build passes

Can one of the admins verify this patch?


Crashing - Out of memory error

I thought I saw something about this issue previously but I didn't pay attention because I wasn't having the same problem. Now, all of a sudden, whenever I try to open the CP application (192.168.1.xx:5800)  I'm getting an out of memory error. However, I'm fairly certain CP is still backing up successfully. I have since searched the issues and am more confused than ever how to fix this. Any help would be greatly appreciated.

Look at the first item in the Troubleshooting section...

Correct, see https://github.com/jlesage/docker-crashplan-pro#crashes--maximum-amount-of-allocated-memory

Got it. Thanks. Worked fine.


Bug fix: allow white space in function decl

First, great library, very useful.  Saved me a TON of work building the same :)
When trying to use it on our existing codebase I found a "bug" where if you use whitespace in your function decl's it throws things off due to the pattern you used (line 143/4 depending on your start preference):
/^(function )?([a-zA-Z0-9_:-]+)(\(\))? \{/ && docblock != "" {

Changing that to the following allows whitespace:
/^(function([ \t])+)?([a-zA-Z0-9_:-]+)([ \t]*)(\(([ \t]*)\))?([ \t]*)\{/ && docblock != "" {

@jdarling can you please create a pull-request for it?

Done in PR #5

I have also run into a similar issue where it doesn't pick up the following:
function fname
{


Add SchildiChat

SchildiChat (https://schildi.chat/) is an Element mod with user-friendly features. It is available on Android (both F-droid and Google Play), desktop and as a web app.

+1 for adding SchildiChat (https://schildi.chat/)


Question: Sprache to CSLY

Currently I have set up Sprache to follow a simple set of rules:
Query             = QueryFilter ;

QueryFilter       = StringValue Operator StringValue ;

Operator          = EqualOperator
				  | ":!="
				  | ":<"
				  | ":<="
				  | ":>"
				  | ":>="
				  ;

EqualOperator     = ":=" ;

StringValue       = """ String """ ;

So in C# I have the following query:
string query = "StartTime:>=\"2015-01-01T06:00:00Z\" EndTime:<=\"2015-03-25T11:59:00Z\" SamplingMode:=\"Raw\"";

My question is how would I set up CSLY to follow these rules?
At the end of the day I need to perform query validation and inform users of where the error is and so on...

@AlucardLO ,
I rechekd your query example and my proposition may not be exactly what you want as you seems have some keywork like startTime or endTime that do not match my lexer and then the parser is then falsy.
here is a new try . For this I cant directly evaluate to a boolean as I dont know what is a StartTime or EndTime in your context. So I return a object model representing the query. Up to you to use it for evaluation.

using sly.lexer;

namespace alucard
{

    public enum alucardLexer
    {

        /*
           string recog assuming " as delimiter and \ as escape char
         */

        [Lexeme(GenericToken.String, "'", "\\")]
        STRING = 1,

        // :!= NOT EQUAL operator ?
        [Lexeme(GenericToken.SugarToken, ":!=")]
        NOTEQ = 2,

        // :< lesser operator ?
        [Lexeme(GenericToken.SugarToken, ":<")]
        LESSER = 3,

        //  lesser or equal
        [Lexeme(GenericToken.SugarToken, ":<=")]
        LSSOREQ = 4,

        // greater
        [Lexeme(GenericToken.SugarToken, ":>")]
        GREATER = 5,

        // greater or equal
        [Lexeme(GenericToken.SugarToken, ":>=")]
        GREAtOREQ = 6,

        // equals
        [Lexeme(GenericToken.SugarToken, ":=")]
        EQUALS = 7,

        /*
           keywords
         */

        [Lexeme(GenericToken.KeyWord,"StartTime")]
         StartTime = 10,

        [Lexeme(GenericToken.KeyWord,"EndTime")]
         EndTime = 11,

        [Lexeme(GenericToken.KeyWord,"SamplingMode")]
         SamplingMode = 10
    }
}

the parser and object model

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using sly.lexer;
using sly.parser.generator;

namespace alucard
{

    public interface IQuery {

    }

    public class Filter : IQuery {

        public  string Key {get; set;}

        public  string Value {get; set;}

        public alucardLexer Operator {get;set;}

        public Filter(string key, alucardLexer oper, string value) {
            Key = key;
            Operator = oper;
            Value = value;
        }

    }

    public class Query : IQuery {

          public List<Filter> Filters;

          public Query(List<Filter> filters)   {
              Filters = filters;
          }

    }

    public class alucardParser
    {

        [Operation((int)alucardLexer.EQUALS, 2, Associativity.Right, 10)]
        [Operation((int)alucardLexer.LESSER, 2, Associativity.Right, 10)]
        [Operation((int)alucardLexer.LSSOREQ, 2, Associativity.Right, 10)]
        [Operation((int)alucardLexer.GREATER, 2, Associativity.Right, 10)]
        [Operation((int)alucardLexer.GREAtOREQ, 2, Associativity.Right, 10)]
        [Operation((int)alucardLexer.NOTEQ, 2, Associativity.Right, 10)]
        public IQuery filter(Token<alucardLexer> keyword, Token<alucardLexer> operation, Token<alucardLexer> stringValue)
        {
            return new Filter(keyword.Value, operation.TokenID, stringValue.Value);

        }

        [Production("many : filter+ ")]
        public IQuery manyFilter(List<bool> filterResults) {
            return new Query(filterResults.Cast<Filter>().ToList());
        }

    }

}

@b3b00 Thanks for the detailed answers.
I'll put them into a test app. Really appreciate the effort.

@AlucardLO , glad to hear that you appreciate my answers. Could you elaborate on what you re trying to do with CSLY ? have you some open source ? I am interrested on what people can do with my project. thanks,
olivier

@b3b00 , Im building a historical data retrieval framework. The idea is to allow a common framework to be used to query historical data from various databases. Each database uses a different syntax to query data, so i wanted to provide a common syntax that can be used to query various database types while allowing the ability to send custom operators through for specific databases to allow fine-grained queries. So I've been playing around with the available options out there. Sprache was my first experiment, CSLY seemed interesting and I'm keen to give it a go once time allows.


[SPARK-8745] [SQL] remove GenerateProjection

cc @rxin

Test build #47756 has started for PR 10316 at commit ddca7e2.

Test build #47758 has started for PR 10316 at commit 8304251.

Test build #47758 has finished for PR 10316 at commit 8304251.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47758/
Test FAILed.

Test build #47759 has started for PR 10316 at commit 2cca3a1.

Test build #47759 has finished for PR 10316 at commit 2cca3a1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47759/
Test PASSed.


I've had the same issue, but its on a server, and it only crashes for a single person despite everyone having the exact same mods and mod versions. Open the K menu, and the game hard crashes.

Same situation, please share your game log.

Huh, the server likely saved some invalid data somehow that cant be read safely anymore. I'll see if I can implement a fix soon.

game crashed when opened the config via the mod menu


Create checklist for PRs and Changelog / Readme per product

Description
Add readme and changelog for each library, test framework, and tools
Cost: 4

PR checklist has been merged in PR https://github.com/Azure/azure-sdk-for-net/pull/2648

I think this is now the norm.  Is this required to be open any more?  (Closing in 30 days unless there is something more articulated)

Closing as fixed.


Table Formating, page formating, broken link fixed

@v-hearya,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

patterns-practices/reference/bindablebase-members-mspp-mvvm.md
:white_check_mark:Succeeded

patterns-practices/reference/clearchildviewsregionbehavior-constructor-mspp-regions-behaviors.md
:white_check_mark:Succeeded

patterns-practices/reference/clearchildviewsregionbehavior-properties-mspp-regions-behaviors.md
:white_check_mark:Succeeded

patterns-practices/reference/commandbehaviorbase-t-methods-mspp-interactivity.md
:white_check_mark:Succeeded

patterns-practices/reference/compositecommand-canexecute-method-mspp-commands.md
:white_check_mark:Succeeded

patterns-practices/reference/cyclicdependencyfoundexception-constructor-serializationinfo-streamingcontext-mspp-modularity.md
:white_check_mark:Succeeded

patterns-practices/reference/dataeventargs-tdata-properties-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/defaultconfirmationwindow-members-mspp-interactivity-defaultpopupwindows.md
:white_check_mark:Succeeded

patterns-practices/reference/defaultnotificationwindow-constructor-mspp-interactivity-defaultpopupwindows.md
:white_check_mark:Succeeded

patterns-practices/reference/defaultnotificationwindow-events-mspp-interactivity-defaultpopupwindows.md
:white_check_mark:Succeeded

patterns-practices/reference/defaultnotificationwindow-methods-mspp-interactivity-defaultpopupwindows.md
:white_check_mark:Succeeded

patterns-practices/reference/delegatecommand-fields-mspp-commands.md
:white_check_mark:Succeeded

patterns-practices/reference/delegatecommand-fromasynchandler-method-mspp-commands.md
:white_check_mark:Succeeded

patterns-practices/reference/delegatecommandbase-constructor-mspp-commands.md
:white_check_mark:Succeeded

patterns-practices/reference/delegatecommandbase-fields-mspp-commands.md
:white_check_mark:Succeeded

patterns-practices/reference/delegatereference-class-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/directorymodulecatalog-constructor-mspp-modularity.md
:white_check_mark:Succeeded

patterns-practices/reference/dispatchereventsubscription-tpayload-class-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/dispatchereventsubscription-tpayload-methods-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/dispatchereventsubscription-tpayload-properties-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/duplicatemoduleexception-events-mspp-modularity.md
:white_check_mark:Succeeded

patterns-practices/reference/eventbase-methods-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/eventbase-subscriptions-property-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/eventbase-unsubscribe-method-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/filemoduletypeloader-ctor.md
:white_check_mark:Succeeded

patterns-practices/reference/iassemblyresolver-members-mspp-modularity.md
:white_check_mark:Succeeded

patterns-practices/reference/iconfigurationstore-members-mspp-modularity.md
:white_check_mark:Succeeded

patterns-practices/reference/iconfirmation-confirmed-property-mspp-interactivity-interactionrequest.md
:white_check_mark:Succeeded

patterns-practices/reference/idelegatereference-interface-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/idelegatereference-target-property-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/ieventaggregator-interface-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/imodule-members-mspp-modularity.md
:white_check_mark:Succeeded

patterns-practices/reference/imodulecatalog-members-mspp-modularity.md
:white_check_mark:Succeeded

patterns-practices/reference/imoduleinitializer-members-mspp-modularity.md
:white_check_mark:Succeeded

patterns-practices/reference/imodulemanager-members-mspp-modularity.md
:white_check_mark:Succeeded

patterns-practices/reference/imoduletypeloader-members-mspp-modularity.md
:white_check_mark:Succeeded

patterns-practices/reference/inavigateasync-requestnavigate-method-mspp-regions.md
:white_check_mark:Succeeded

patterns-practices/reference/inavigateasync-requestnavigate-method-uri-action-navigationresult-navigationparameters-mspp-regions.md
:white_check_mark:Succeeded

patterns-practices/reference/inotification-title-property-mspp-interactivity-interactionrequest.md
:white_check_mark:Succeeded

patterns-practices/reference/invokecommandaction-members-mspp-interactivity.md
:white_check_mark:Succeeded

patterns-practices/reference/invokecommandaction-triggerparameterpath-property-mspp-interactivity.md
:white_check_mark:Succeeded

patterns-practices/reference/iregionbehaviorcollection-members-mspp-regions.md
:white_check_mark:Succeeded

patterns-practices/reference/iregionbehaviorfactory-members-mspp-regions.md
:white_check_mark:Succeeded

patterns-practices/reference/iregioncollection-members-mspp-regions.md
:white_check_mark:Succeeded

patterns-practices/reference/iregionnavigationjournalentry-parameters-property-mspp-regions.md
:white_check_mark:Succeeded

patterns-practices/reference/iregionviewregistry-members-mspp-regions.md
:white_check_mark:Succeeded

patterns-practices/reference/itemmetadata-members-mspp-regions.md
:white_check_mark:Succeeded

patterns-practices/reference/itemscontrolregionadapter-members-mspp-regions.md
:white_check_mark:Succeeded

patterns-practices/reference/iview-datacontext-property-mspp-mvvm.md
:white_check_mark:Succeeded

patterns-practices/reference/iviewscollection-members-mspp-regions.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Change Shape.geom_type() to use GeomType values

GeomType should be changed to a StrEnum and use the same values as generated by Shape.geom_type() so that edge.geom_type() == GeomType.CIRCLE works.
Should Shape.geom_type be a property instead of a method?

Isn't it possible to make geom_type return the enum directly? But otherwise making it a str enum would be better !
+1 for the property


Added roles actions and reducers.

Coverage increased (+0.2%) to 57.181% when pulling 15e228d5ee13efb7661c0d50699d5ac31f3002e0 on roles into f07dcc6eeb7b70731c614b2d02023a9f196b8272 on master.


Fix incorrect new lines in tracing and stdout messages

Fix incorrect new lines in tracing and stdout messages

From comment https://github.com/openwhisk/openwhisk/pull/604#issuecomment-224987914

@dubeejw - Should be a quick review.
/cc @csantanapr

@mdeuser please next time assigned a reviewer using github when it's ready for review.

@dubeejw re-assign to me when it's ready for merge if you want to delegate merger.

@csantanapr, :+1: :+1:

rebase and merged 62779e4e587b1876aa27ac8ba0d0a19b484079cd


No output | Custom dataset | TensorRT

Hi @haotian-liu,
I'm working on a custom instance segmentation task with three classes. While I get output segmentations on my Jetson Xavier by using tag --disable_tensorrt, there's no output when I run the model on TensorRT.
I'm training a ResNet50 model on my PC and transferring the learned model to Jetson for inference.
Initially, I suspected the error is similar to issue:27 as I got IndexError Warnings when enabling TensorRT. But while debugging I found that except blocks do no harm.
My commented detection.py file:
# This try-except block aims to fix the IndexError that we might encounter when we train on custom datasets and evaluate with TensorRT enabled. See https://github.com/haotian-liu/yolact_edge/issues/27.
       try:
           classes = classes[keep]
           boxes = boxes[keep]
           masks = masks[keep]
           scores = scores[keep]

           print("Passed first Try/Except")

       except IndexError:
           from utils.logging_helper import log_once
           log_once(self, "issue_27_flatten", name="yolact.layers.detect",
           message="Encountered IndexError as mentioned in https://github.com/haotian-liu/yolact_edge/issues/27. Flattening predictions to avoid error, please verify the outputs. If there are any problems you met related to this, please report an issue.")

           classes = torch.flatten(classes, end_dim=1)
           boxes = torch.flatten(boxes, end_dim=1)
           masks = torch.flatten(masks, end_dim=1)
           scores = torch.flatten(scores, end_dim=1)
           keep = torch.flatten(keep, end_dim=1)

           idx = torch.nonzero(keep, as_tuple=True)[0]
           print(f"\nIdx: {idx}")
           print(f"Idx_min: {idx.min()} and Idx_max: {idx.max()}")

           classes = torch.index_select(classes, 0, idx)
           boxes = torch.index_select(boxes, 0, idx)
           masks = torch.index_select(masks, 0, idx)
           scores = torch.index_select(scores, 0, idx)

       # Only keep the top cfg.max_num_detections highest scores across all classes
       scores, idx = scores.sort(0, descending=True)
       idx = idx[:cfg.max_num_detections]
       scores = scores[:cfg.max_num_detections]

       print(f"\nIdx: {idx}")
       print(f"Idx_min: {idx.min()} and Idx_max: {idx.max()}")

       try:
           print(f"\nInside second Try")

           print(f"Classes: {classes}")
           print(f"Boxes: {boxes}")

           classes = classes[idx]
           print(f"Classes updated: {classes}")

           boxes= boxes[idx]
           print(f"Boxes updated: {boxes}")

           masks = masks[idx]

           print(f"Scores: {scores}")
       except IndexError:
           from utils.logging_helper import log_once
           log_once(self, "issue_27_index_select", name="yolact.layers.detect", message="Encountered IndexError as mentioned in https://github.com/haotian-liu/yolact_edge/issues/27. Using `torch.index_select` to avoid error, please verify the outputs. If there are any problems you met related to this, please report an issue.")

           print(f"\nSecond Try/Except")

           classes = torch.index_select(classes, 0, idx)
           boxes = torch.index_select(boxes, 0, idx)
           masks = torch.index_select(masks, 0, idx)

           print(f"Classes updated: {classes}")
           print(f"Boxes updated: {boxes}")
           print(f"Scores: {scores}")

       return boxes, masks, classes, scores

Command that I use to run evaluation:
~/Projects/yolact_edge$ python3 eval.py --config=yolact_edge_config --trained_model=weights/yolact_edge_2115_110000.pth --score_threshold=0.3 --top_k=20 --image=./test_input/020801_2020_11_25_11_54_18.png
[01/27 15:04:38 yolact.eval]: Loading model...
[01/27 15:04:42 yolact.eval]: Model loaded.
[01/27 15:04:42 yolact.eval]: Converting to TensorRT...
[01/27 15:04:42 yolact.eval]: Converting backbone to TensorRT...
[01/27 15:04:44 yolact.eval]: Converting protonet to TensorRT...
[01/27 15:04:44 yolact.eval]: Converting FPN to TensorRT...
[01/27 15:04:44 yolact.eval]: Converting PredictionModule to TensorRT...
[01/27 15:04:55 yolact.eval]: Converted to TensorRT.
WARNING [01/27 15:04:56 yolact.layers.detect]: Encountered IndexError as mentioned in https://github.com/haotian-liu/yolact_edge/issues/27. Flattening predictions to avoid error, please verify the outputs. If there are any problems you met related to this, please report an issue.

Idx: tensor([ 0,  1,  2,  9, 11, 13, 15, 16, 18, 24, 26, 27, 30, 31, 34])
Idx_min: 0 and Idx_max: 34

Idx: tensor([ 0, 10,  1,  2, 11, 12,  5, 13,  6, 14,  7,  3,  8,  9,  4])
Idx_min: 0 and Idx_max: 14

Inside second Try
Classes: tensor([0, 0, 0, 0, 0, 1, 1, 1, 1, 1, 2, 2, 2, 2, 2])
Boxes: tensor([[ 0.7628,  0.4625,  0.7711,  0.5278],
        [ 0.9843,  0.7867,  0.9961,  0.8066],
        [ 0.8758,  0.4074,  0.9116,  0.5297],
        [ 0.7709, -0.0089,  0.9846,  0.9502],
        [ 0.7592,  0.1906,  0.7628,  0.2080],
        [ 0.9848,  0.7869,  0.9971,  0.8092],
        [ 0.7709, -0.0089,  0.9846,  0.9502],
        [ 0.7628,  0.4625,  0.7711,  0.5278],
        [ 0.8758,  0.4074,  0.9116,  0.5297],
        [ 0.7592,  0.1906,  0.7628,  0.2080],
        [ 0.7592,  0.1906,  0.7633,  0.2087],
        [ 0.7709, -0.0089,  0.9846,  0.9502],
        [ 0.8753,  0.4015,  0.9084,  0.5413],
        [ 0.9848,  0.7869,  0.9971,  0.8092],
        [ 0.7628,  0.4625,  0.7711,  0.5278]])
WARNING [01/27 15:04:56 yolact.layers.detect]: Encountered IndexError as mentioned in https://github.com/haotian-liu/yolact_edge/issues/27. Using `torch.index_select` to avoid error, please verify the outputs. If there are any problems you met related to this, please report an issue.

Second Try/Except
Classes updated: tensor([0, 2, 0, 0, 2, 2, 1, 2, 1, 2, 1, 0, 1, 1, 0])
Boxes updated: tensor([[ 0.7628,  0.4625,  0.7711,  0.5278],
        [ 0.7592,  0.1906,  0.7633,  0.2087],
        [ 0.9843,  0.7867,  0.9961,  0.8066],
        [ 0.8758,  0.4074,  0.9116,  0.5297],
        [ 0.7709, -0.0089,  0.9846,  0.9502],
        [ 0.8753,  0.4015,  0.9084,  0.5413],
        [ 0.9848,  0.7869,  0.9971,  0.8092],
        [ 0.9848,  0.7869,  0.9971,  0.8092],
        [ 0.7709, -0.0089,  0.9846,  0.9502],
        [ 0.7628,  0.4625,  0.7711,  0.5278],
        [ 0.7628,  0.4625,  0.7711,  0.5278],
        [ 0.7709, -0.0089,  0.9846,  0.9502],
        [ 0.8758,  0.4074,  0.9116,  0.5297],
        [ 0.7592,  0.1906,  0.7628,  0.2080],
        [ 0.7592,  0.1906,  0.7628,  0.2080]])
Scores: tensor([9.8882e-01, 9.0431e-01, 8.8910e-01, 7.1460e-01, 5.0766e-01, 1.0031e-03,
        4.2995e-04, 3.9997e-04, 2.7969e-04, 1.7686e-04, 1.9921e-05, 1.6216e-05,
        5.4856e-06, 1.4189e-06, 1.8612e-07])

Please note: If I add --disable_tensorrt tag, I get results as the code executes in try blocks.
I also ensure to remove the cached '.trt' files in ./weights folder.
Can you help me here ? Thank you!

Hi, can you try --use_fp16_tensorrt to see if the issue persists?

Hi, can you try --use_fp16_tensorrt to see if the issue persists?

Hi,
No, the issue is not resolved yet.

Hi,
No, the issue is not resolved yet.

I suspect it is related to #38 and we are currently investigating on this issue (seems TensorRT related). Will let you know about the progress, and we might also need some information from you, thanks.

I suspect it is related to #38 and we are currently investigating on this issue (seems TensorRT related). Will let you know about the progress, and we might also need some information from you, thanks.

Okay, thank you! I'll continue to debug in the meantime and will update here in case I see any progress.

Okay, thank you! I'll continue to debug in the meantime and will update here in case I see any progress.

Thanks!

Thanks!

Hi, Just an update! I figured that I get outputs for few of my test samples, provided that it passes the second try block. Why is that ? But for most of my test images, I get two exceptions and hence no outputs for them.
You can replicate the issue by changing the cfg.max_num_detections to a lower value.

Hi, Just an update! I figured that I get outputs for few of my test samples, provided that it passes the second try block. Why is that ? But for most of my test images, I get two exceptions and hence no outputs for them.
You can replicate the issue by changing the cfg.max_num_detections to a lower value.

Hi @haotian-liu, after much debugging I figured out that there's no issue with TensorRT!
While using TRT, when I specify score_threshold, I'm not getting any results. I just removed it and was able to get detections. Maybe this is because naturally the confidence scores are lower when using TRT and you can make it clearer in README if you agree.
Now, I'm facing another issue where I get duplicate detections (both with TensorRT and --disable_tensorrt) i.e., if I have 2 classes, I get 2 boxes around all objects.
I believe the issue is in this line below,
https://github.com/haotian-liu/yolact_edge/blob/545bc33d162a5d3cabf992186001ca63bfa7eda2/layers/functions/detection.py#L94
After selecting the conf_scores higher than my threshold at
https://github.com/haotian-liu/yolact_edge/blob/545bc33d162a5d3cabf992186001ca63bfa7eda2/layers/functions/detection.py#L93
keep has n non-zero values indicating that I have n objects higher than my threshold.
While, the shapes of boxes and masks are [n, 4] and [n, 32] correspondingly before passing to self.fast_nms(), the shape of keep is not [n, 1]?
Is my understanding and finding correct? I think if we fix this issue, we can permanently fix Issue https://github.com/haotian-liu/yolact_edge/issues/27 as well.
Thanks!

Hi @smahesh2694, with TensorRT, the score might be different from the ones predicted by the pure PyTorch model, but it does not necessarily to be lower. All of our demo code and benchmarks are evaluated and generated with same hyperparameters for TensorRT (FP16/INT8) and PyTorch code. But for some reason, one some of the models trained on custom dataset, the TensorRT predictions will cause some issues (and there are quite weird and complicated phenomenon related to CUDA/TensorRT engine).
For your second issue (for both TRT and PyTorch), I currently don't get as they should have same shape in the first dimension of N as they are filtered with same keep as here. Can you elaborate more?

Thanks @haotian-liu! Yes, I agree with your first answer regarding TensorRT.
For the second issue, the shape of my scores is [num_classes, n] which is very weird although we use the same keep as you mentioned. Note that I'm working on custom dataset to be clear!
In my detect() function,
Shape of conf_score is [X]
Shape of keep is [X]
Shape of cur_scores is [num_classes, X]
Shape of scores is [num_classes, n] where n = count_nonzero(keep)
Shape of boxes is [n, 4]
Shape of masks is [n, 32]

Because of a mismatch in scores's shape, the final shape of boxes, scores, masks and classes have num_classes x n in its first dimension instead of just n, which leads to multiple detections.
I also wanted to let you know that, I have currently found a quick fix for my case as I replace the line
https://github.com/haotian-liu/yolact_edge/blob/545bc33d162a5d3cabf992186001ca63bfa7eda2/layers/functions/detection.py#L109
with
return {'box': boxes[:torch.count_nonzero(scores > self.conf_thresh)], 'mask': masks[:torch.count_nonzero(scores > self.conf_thresh)], 'class': classes[:torch.count_nonzero(scores > self.conf_thresh)], 'score': scores[:torch.count_nonzero(scores > self.conf_thresh)]}

But, I would appreciate your comments here as I don't want this ugly fix forever!

Hi @smahesh2694, I still don't see what is wrong with the shape you printed. why is the shape [num_classes, n] improper for scores.

For your second issue (for both TRT and PyTorch), I currently don't get as they should have same shape in the first dimension of N as they are filtered with same keep as here. Can you elaborate more?

As per your previous comment, I thought the shape of scores should be [n, 1], isn't it ?

@smahesh2694 scores before NMS should be [X, N] as it is required for computing NMS.

Thanks for the help @haotian-liu! I'm closing the issue now!

Hi I am currently closing this issue, and merge the discussion related to TensorRT conversion issue after training on a custom dataset to this issue #47 as it is quite hard for me to track so many open issues. Hope you understand, thanks.

And I have posted a follow-up about the possible cause in #47, could you take a look and see if you could provide a bit more information for me to investigate, thanks.

Hi, can you provide me with your training setting, thanks.
(1) number of GPUs used to train the model
(2) batch size per GPU
(3) learning rate
(4) number of iterations trained
(5) number of categories in the dataset
(6) number of samples in the dataset.

I somehow figured out that this is related to multiple training instability, and it also exists in original YOLACT https://github.com/dbolya/yolact/issues/586, https://github.com/dbolya/yolact/issues/222, https://github.com/dbolya/yolact/issues/340.
I have applied Daniel's fix towards this issue with some modifications, and have pushed to the haotian-dev branch.
You could try one of the two followings to see if your issue has been resolved:
(1) train using a single GPU
(2) train with the latest code in haotian-dev branch with multiple GPUs.
If the issue persists, please reply directly to #47 (this will be the main thread to deal with related issues for now) with the following information, thanks.
(1) number of GPUs used to train the model
(2) batch size per GPU
(3) learning rate
(4) number of iterations trained
(5) dataset-related information (# of classes, # of training images).


Zenodo DOI for grlc

It is possible to add a DOI for each release of grlc, via zenodo. This guide shows how to do it. I think this would be a good way to add visibility to grlc (I know for me it would be useful).
I can take care of adding a DOI, but I would need approval from someone with administrator rights at the CLARIAH github organization level.
@albertmeronyo , @RinkeHoekstra -- what do you think?

That would be great! We need to sync that with the version and release policy in terms of version tags -- also to make it consistent with the version we have in pypi (which I think is pretty old).
Thanks for the idea!

Good -- I'll request approval and then when we make a new release, we can also update pypi (and maybe check docker image too?)

Will start the process...


x/net/http2: h2spec violation generic 2/2 & 2/3

Generic tests for HTTP/2 server
  2. Streams and Multiplexing
    × 2: Sends a WINDOW_UPDATE frame on half-closed (remote) stream
      -> The endpoint MUST accept WINDOW_UPDATE frame.
         Expected: DATA frame
           Actual: HEADERS Frame (length:28, flags:0x05, stream_id:1)
    × 3: Sends a PRIORITY frame on half-closed (remote) stream
      -> The endpoint MUST accept PRIORITY frame.
         Expected: DATA frame
           Actual: HEADERS Frame (length:28, flags:0x05, stream_id:1)

Can we get repro details on these bugs too? What command did you run and against which code?

The command is $ ./h2spec -S -k -t -h <IP_ADDRESS> -p 8080 generic/2
I think its related to the "server" change I made in my set up which no longer sends any data back.
It expects a Data frame which assumes the server would send something back on a GET /.
If I change the server back to send back data, we pass. Which I assume is what this test assumes but the h2spec suite does not define how the Server should behave.

I would lean toward closing this since its working properly with a response.

Confirmed that the server is expected to send back some response therefore the test case does pass.


Add github action for running tests against lowest matching depedencies

Add a check to run the tests against the lowest matching dependencies. This can be done with our current test suite, but by providing --prefer-lowest to the command to run composer install. This will ensure that if we have an older dependency which needs to have the minimum version updated to the latest, we'll see that highlighted in our test suite.
Rationale: There have been a few occasions where a required dependency was not declared as such, and resulted in an error for a customer.

We just had an error related to this happen again. See https://github.com/googleapis/google-auth-library-php/issues/504 and the resulting fix in https://github.com/googleapis/google-cloud-php/pull/6896

This functionality was added a while ago, but this issue was not closed.


VITAlbum crashes when I start it.

I keep getting an error message whenever I launch the app. I tried uninstalling and reinstalling multiple times, but it doesn't want to work.

There was a derp when allocating memory for opening folders + some debugging traces left behind which was trying to create a file in a folder which may not exist on your device hence causing the crash. Can you please try the latest hotfix release v1.01? https://github.com/joel16/VITAlbum/releases/tag/v1.01

okay, this version actually works. Thanks :)


Question: tfstateazurerm not finding tfstate blob in subdirectories

I'm trying to look for the terragrunt.tfstate file which located in subdirectories.
Lets assume I want to look for terragrunt.tfstate file under this key: terraform-state/base/cloud-resources/terragrunt.tfstate
echo "output: ref+tfstateazurerm://rg-test/storage_account/terraform-state/base/cloud-resources/terragrunt.tfstate" | vals eval -f -
vals ignore folders after base and the exception below appear:
Code: BlobNotFound
GET https://storage_account.blob.core.windows.net/terraform-state/base?timeout=61
Authorization: REDACTED

Is this a bug or designed to look for tfstate file only in root container folder ?

Hi @mumoshu ,
The issue solved in terraform-tfsate project in latest current version.
Can we bump the version of tfstate-lookup from 0.4.2 to 0.4.4 ?
Right now we can't use tfstateazurerm and lookup to subdir in vals which also affect on helmfile project


Use MsgPack instead of Json to move data back and forth between host and Wasm

Currently the data exchanged between the policy-server and the wasm "world" is encoded using json. The waPC upstream project instead decided to use MsgPack as an encoding format. Their choice doesn't force us to change our approach, however it guarantees that all the languages supported by waPC have also libraries to deal with MsgPack.
Why should we move to MsgPack?

MsgPack is an optimized (in terms of size) version of JSON encoding. That would reduce the amount of information sent back and forth between policy-server and Wasm policies. That will hopefully lead to faster evaluation times.

Support more languages. TinyGO for example, only has limited json support.

I think we can close that, I don't see us having the time to work on that on the short time.
Moreover, instead of just using MsgPack, we should investigate the use of widl, which is something specific to waPC.

WIDL & the waPC CLI
Use the WebAssembly Interface Definition Language (WIDL) to define your WebAssembly’s schema and the wapc CLI to generate all the code except your business logic.

This would allow us to define the communication protocol between policy-evaluator and the Wasm modules in a single place, and then have client libraries automatically generated by widl.
Right now we don't plan to change the communication protocol we already have in place -> I don't see a real benefit of moving to widl

@flavio I haven't looked into the details, but is https://github.com/bytecodealliance/witx-bindgen also another possibility?

Yes, that could replace waPC in the future


check-ttf.py: ERROR:root:No family found in GWF in http://fonts.googleapis.com/css?family=

This error should be a warning instead, otherwise all new fonts won't pass this test.

@felipesanches this should be very quick :)

@felipesanches is this done in the rewrite?

Done!


Documentation link update

each time I have to fix it in url manually :)

Thanks for the PR, but we're moving docs over to https://ui-router.github.io/docs/latest/
I updated the README.md


add test

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8c62a88) 23.80% compared to head (86eb3eb) 24.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   23.80%   24.70%   +0.89%
==========================================
  Files           1        1
  Lines         336      336
==========================================
+ Hits           80       83       +3
+ Misses        252      250       -2
+ Partials        4        3       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Repo error

hello, getting this error up update, can you help? ignoring repo security isn't working
https://imgur.com/XYvGWCv.png

edit  /etc/apt/sources.list.d/pipewire-upstream.list and replace bullseye with hirsute and the do a sudo apt-get update

thanks, it's close, but I did not manually hold back pipewire, I DID hold wine-staging, I did global unhold, did not work
https://imgur.com/TMZgGFI.png

does it solve with sudo apt-get full-upgrade ?  I did not realise bullseye in the same timeline as ubuntu's focal (20.04) not hirsute.
https://github.com/pipewire-debian/pipewire-debian/issues/30#issuecomment-907616290  look at the comment, It would be focal in place of hirsute. and then do a sudo apt update && sudo apt upgrade. After this definitely all problems are sorted out.

did you solve the problem ? @jabbermacy

Closing since OP didn't reply back for a long time.


code-gen: only dump api structure

External users don't need to know internal types and the relation schema

Note that this is a breaking change


Route longer than 64 chars not correctly created

Describe the bug
Due to an hard limit of Openshift, routes longer than 64 chars are not accepted.
Lagoon automatically create safe branch variable that's a branch name shorter than 64 chars.
Accordly to this safe branch, Lagoon should create a route shorter than 64 chars but it doesn't happen.
Here the piece of code that creates SAFE_BRANCH https://github.com/amazeeio/lagoon/blob/master/services/openshiftbuilddeploy/src/index.js#L51-L57
To Reproduce
Steps to reproduce the behavior:

Create a project with a branch name longer than 64 chars

Expected behavior
An Openshift route compliant with 64 chars limits.

the problem is that the name of the service is prefixed to the route name, so for nginx the route name ends up being: nginx-$SAFE_BRANCH which is then longer than 63 chars, as SAFE_BRANCH is already 63 chars.
so maybe SAFE_BRANCH should be created with max 53 characters, so there is 10 characters left for the servicename? (this is though a guessing game, as people could call their services with something longer than 10 characters again)

Just spotted this in the wild
router_controller.go:250] host name validation errors: spec.host: Invalid value: "nginx-royalbanana-feature-config-remove-shield-creds-from-dev.cluster.amazee.io": must be no more than 63 characters

Perhaps something like the DBaaS operator does, psedo code:
if route > 63 characters
  truncate route to 57 characters and append a '-' followed by a 5 char hash of route

e.g.
80 characters
nginx-royalbanana-feature-config-remove-shield-creds-from-dev.cluster.amazee.io

After the logic
nginx-royalbanana-feature-config-remov-15399.cluster.amazee.io


ReduxForm handleSubmit refreshes page with fields assigned

Environment
ReduxForm: v6.5.0
Node: v8.1.2
Browser: Google Chrome
I've gone through all the existing issues on handleSubmit page refreshing, but none of them seems to solve my problem.
LoginForm
import React, { Component } from 'react'
import { reduxForm, Field, propTypes } from 'redux-form'
import classNames from 'classnames'

import loginValidation from './validation'

@reduxForm({
  form: 'loginForm',
  validate: loginValidation
})
export default class LoginForm extends Component {

  static propTypes = {
    ...propTypes
  }

  inputField = ({ input, label, type, meta: { touched, error } }) => (
    <fieldset className="form__fieldset login-form__fieldset">

        <input {...input}
          type={type}
          placeholder={touched && error ? error : label}
          className={classNames('form__input login-form__input',
            touched && error ? 'ng-invalid' : ''
          )}
        /> {/* .ng-invalid */}

      {type === 'password' &&

            I've forgotten my password

      }
    </fieldset>
  )

  render() {
    const { inputField, props } = this
    const { handleSubmit, onSubmit, submitting } = props

    return (

          <form className="login-form__form" onSubmit={handleSubmit(onSubmit)}>
            <Field name="username" type="text" component={inputField} label="Username" />
            <Field name="password" type="password" component={inputField} label="Password" />
            <button className="login-form__button" type="submit" disabled={submitting}>Let's go!</button>
          </form>

              <button className="facebook-connect">Login with Facebook</button>

              <button className="facebook-connect"></button>

    )
  }

}

And the HOC LoginHeader:
import React, { Component } from 'react'
import PropTypes from 'prop-types'
import { connect } from 'react-redux'
import classNames from 'classnames'

import LoginForm from './LoginForm'
import { authActions } from '../redux/modules/auth'

@connect(
  state => ({
    user: state.auth.user,
    ...state.form.loginForm
  }),
  { ...authActions }
)
export default class LoginHeader extends Component {

  static propTypes = {
    user: PropTypes.object,
    login: PropTypes.func.isRequired,
    logout: PropTypes.func.isRequired
  }

  static contextTypes = {
    router: PropTypes.object
  }

  onSubmit = (data) => this.props.login(data).then(console.log)

  render() {
    const { submitFailed } = this.props

    const headerLoginForm = classNames(
      'header__login-form',
      submitFailed ? 'animated shake' : ''
    )

    return (

              <LoginForm onSubmit={this.onSubmit} />

    )
  }

}

Even when I try to replace <form onSubmit={handleSubmit(onSubmit)}> with <form onSubmit={(e) => e.preventDefault()}> my page still refreshes.
I'm unsure whether or not this is a problem with my coding, browser, version, or whatever else because practically yesterday it worked without any problem.

Try not to use a button with type=submit

I fixed it. It was a problem with Webpack and everything is working correctly, I just forgot that I created this issue.

What was the issue/fix ?

@marcus-sa How did you fixed that issue?


feat: managed prometheus addon release for 07-22

What type of PR is this?
/kind feature
What this PR does / why we need it:
Removing older images and adding in newer ones for managed prometheus release
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.005%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
2564

Relevant Lines:
3611

💛  - Coveralls


memory allocation bugs

What was wrong?
Similar to https://github.com/ethereum/fe/pull/684.
I should look over all uses of avail and alloc.
To-Do

[ ] OPTIONAL: Update Spec if applicable

[ ] Add entry to the release notes (may forgo for trivial changes)

[ ] Clean up commit history

I've been considering this and now think that it'd be better to resolve this problem in #724.
When we switch to sonatina, this problem would arise again because it'll reuse allocated memory again and again.
We could resolve this by always zeroing memory when a variable is declared but this will cause performance degradation.

But we should fix dynamic type encoding functions, where I wrongly assumed that allocated space for encoding is always zeroed. e.g., padding bytes should be explicitly zeroed here. https://github.com/ethereum/fe/blob/7621ff9ab197cc35e5e363475de6c45f7ac1870a/crates/codegen/src/yul/runtime/abi.rs#L139-L147

see #747


Updated raw toolchain source for 3.0 PR check ADO builds.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[X] The toolchain has been rebuilt successfully (or no changes were made to it)
[X] The toolchain/worker package manifests are up-to-date
[X] Any updated packages successfully build (or no packages were changed)
[X] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[X] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[X] All package sources are available
[X] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[X] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[X] All source files have up-to-date hashes in the *.signatures.json files
[X] sudo make go-tidy-all and sudo make go-test-coverage pass
[X] Documentation has been updated to match any changes to the build system
[X] Ready to merge

Summary

Updating raw toolchain source for 3.0 PR checks.
Does this affect the toolchain?

No.
Test Methodology

PR check.

Auto cherry-pick results:

3.0-dev :white_check_mark: -> https://github.com/microsoft/azurelinux/pull/10308

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=631662&view=results


Fix build issue with Lua >= 5.3

Hi,
Please find this PR to build mod_security with Lua 5.3 (the default in Fedora rawhide).

Hi @athmane,
Thank you for the patch. This is related to the issues: #814 and #762
Looking at your patch it seems that this very change could also work with Lua 5.2 right?
Not placing on buildbots right now because I have to upgrade the buildslaves to use Lua 5.3 :)

Hi @zimmerle
Yes, the change does not affect older Lua versions, I tested the patch with Lua 5.2.2  (default in Fedora 21) and Lua 5.3.0  (default in Fedora Rawhide / devel).

The build seems fine, however there are some crashes on runtime. I am investigating.
We have two new build slaves for Lua 5.2 and 5.3:

http://www.modsecurity.org/developers/buildbot/buildslaves/Linux64-lua52
http://www.modsecurity.org/developers/buildbot/buildslaves/Linux64-lua53

Hi @athmane,
Thanks for the patch. Partially merged and fixed into our mainline. It will be released as part of ModSecurity v2.9.1


vendor/bundle/ruby: cleanup unneeded files

Remove gems that don't need to be vendored (e.g. rubocop-*).
Slim down ActiveSupport even further now that we use less of it.
Commit license files of gems we do vendor, where available.

Draft because this requires #15953.

Remove gems that don't need to be vendored (e.g. rubocop-*).

These do need to be vendored for VSCode editor support.

Slim down ActiveSupport even further now that we use less of it.

🎉

Commit license files of gems we do vendor, where available.

https://github.com/github/licensed may be an alternate option here and we could commit a single NOTICES file.

Remove gems that don't need to be vendored (e.g. rubocop-*).

These do need to be vendored for VSCode editor support.

How does this work in practice? I use VSCode but whenever I want to lint things I just run brew style.

How does this work in practice? I use VSCode but whenever I want to lint things I just run brew style.

Most VSCode RuboCop plugins will just run rubocop and show up results in the editor.

How it works in practice is we configure the path: https://github.com/Homebrew/brew/blob/b2cf50bbe10ab996a1e3365545fadabf36df777a/.vscode/settings.json#L10
and we have this shim: https://github.com/Homebrew/brew/blob/master/Library/Homebrew/shims/gems/rubocop
which calls: https://github.com/Homebrew/brew/blob/master/Library/Homebrew/dev-cmd/rubocop.sh
which invokes brew install-bundler-gems internally (so no need for vendoring)
and then it invokes a special RuboCop startup script (we don't use RuboCop's own binary): https://github.com/Homebrew/brew/blob/master/Library/Homebrew/utils/rubocop.rb.

Hmm it seems brew install-bundler-gems doesn't install these again once removed. I'll need to look into that but I'll fix that in a separate PR (that will be merged first) so consider this PR ready for review otherwise.

Hmm it seems brew install-bundler-gems doesn't install these again once removed. I'll need to look into that but I'll maybe fix that in a separate PR (that will of course be merged first) so consider this PR ready for review otherwise.

I guess we could look at e.g. once file for each gem we need and run bundle install in that case.

Worst case scenario is we just do the gitignore change and gradually these will be removed over time with gem updates.

Sounds good!

Worst case scenario is we just do the gitignore change and gradually these will be removed over time with gem updates.

This wouldn't work because it'll cause uncommitted changes if bundle removes those gems.

I guess we could look at e.g. once file for each gem we need and run bundle install in that case.

I did come up with something like this:
diff --git a/Library/Homebrew/utils/gems.rb b/Library/Homebrew/utils/gems.rb
index 25c10b29f..aed4621d3 100644
--- a/Library/Homebrew/utils/gems.rb
+++ b/Library/Homebrew/utils/gems.rb
@@ -22,6 +22,11 @@ module Homebrew
     File.join(ENV.fetch("HOMEBREW_LIBRARY"), "Homebrew", "Gemfile")
   end

+  # @api private
+  def bundler_definition
+    @bundler_definition ||= Bundler::Definition.build(Bundler.default_gemfile, Bundler.default_lockfile, false)
+  end
+
   # @api private
   def valid_gem_groups
     install_bundler!
@@ -29,7 +34,7 @@ module Homebrew

     Bundler.with_unbundled_env do
       ENV["BUNDLE_GEMFILE"] = gemfile
-      groups = Bundler::Definition.build(Bundler.default_gemfile, Bundler.default_lockfile, false).groups
+      groups = bundler_definition.groups
       groups.delete(:default)
       groups.map(&:to_s)
     end
@@ -229,7 +234,35 @@ module Homebrew
       bundle_check_failed = !$CHILD_STATUS.success?

       # for some reason sometimes the exit code lies so check the output too.
-      bundle_installed = if bundle_check_failed || bundle_check_output.include?("Install missing gems")
+      bundle_install_required = bundle_check_failed || bundle_check_output.include?("Install missing gems")
+
+      # Check if the install is intact. This is useful if any gems are added to gitignore.
+      # We intentionally map over everything and then call `any?` so that we remove the spec of each bad gem.
+      bundle_install_required ||= bundler_definition.specs.map do |spec|
+        spec_file = "#{Gem.dir}/specifications/#{spec.full_name}.gemspec"
+        next false unless File.exist?(spec_file)
+
+        cache_file = "#{Gem.dir}/cache/#{spec.full_name}.gem"
+        if File.exist?(cache_file)
+          require "rubygems/package"
+          package = Gem::Package.new(cache_file)
+          def package.verify # disable verification
+            true
+          end
+          contents = package.contents
+
+          package_install_intact = contents && contents.all? do |gem_file|
+            File.exist?("#{Gem.dir}/gems/#{spec.full_name}/#{gem_file}")
+          end
+          next false if package_install_intact
+        end
+
+        # Mark gem for reinstallation
+        File.unlink(spec_file)
+        true
+      end.any?
+
+      bundle_installed = if bundle_install_required
         if system bundle, "install"
           true
         else

Which is effective at doing a full verification. It does add half a second to no-op brew install-bundler-gems though, which may be noticeable.
So a couple paths forward we could do:

Have some sort of global "vendored gem version" that we bump everytime we remove a committed vendored gem, since we have done something like this before: https://github.com/Homebrew/brew/commit/e16f4ef1c2fe4568f8870b6ffb23a3174054561c. It'll do the full check of everything once and never again until the next bump.
Have a hack specific to this PR that picks one file removed from each gem here and checks those. This is a hardcoded list that we would manually remove from when no longer necessary.

Thanks @Bo98, great work as usual!

It does add half a second to no-op brew install-bundler-gems though, which may be noticeable, as it is reading a few .tar.gz archives nested in .gem files.

This seems pretty reasonable to me given it makes things considerably more reliable. If that can get slimmed down at all: great, otherwise I think it's not a big deal.

Have some sort of global "vendored gem version" that we bump everytime we remove a committed vendored gem, since we have done something like this before: e16f4ef. It'll do the full check of everything once and never again until the next bump.

This seems also reasonable but would want to ensure it's enforced by CI i.e. if you forget to bump (or bump unnecessarily): something in CI fails. This would be a blocker on doing this.
Suggestion: do the above for now and someone can improve performance once it's working.

This seems also reasonable but would want to ensure it's enforced by CI i.e. if you forget to bump (or bump unnecessarily): something in CI fails. This would be a blocker on doing this.

I took a stab at it.


Estimate probability for current patterns based on last week's pattern

It'd be nice if you could optionally input the pattern you knew you had last week, and display and sort the probabilities for the next pattern based on these lines.

I'm actually working on this :)

So this is a thing?  I always assumed (apparently incorrectly) that each week was a new "random" event.

Nope, the probability changes depending on the previous week's pattern choice
I'm closing this in favour of #13 though - same topic :)

Oops, looks like that was posted at the same time, so I didn't see it, my bad.


Step validation will not work in some locales

follow up (non-blocking): This will not work depending on the localisation of the platform (ie. if commas are used instead of peroids. Will need to add logic for this.
Originally posted by @dexturr in https://github.com/vegaprotocol/frontend-monorepo/pull/486#discussion_r889936201

https://github.com/vegaprotocol/frontend-monorepo/commit/780da89c74ed459f5c4b50a7ce12828a46067fd3#diff-deb3f2b58a99a0659165cc5c0f39471658bb9de6828bd2138dd9e2411905dbc9

It seems input[type=number] returns value of an input normalized in a way that . is a decimal separator (regardless of locale).
In a case someone types , but its locale is set to e.g. en-GB then input[type=number] ignores the value returning "" - resulting in validation error of empty value (Firefox; Chrome seems to not care).
Maybe it'd be better to just in case normalize incoming value to .?

@asiaznik Great point, sound like we don't need this in that case. Great spot.


[backport] Support cusparsecsrgeam2 and cusparsecsrgemm2

Backport of #3220

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 5c203d28528ba22517234ea0fe71032df0a763e0, target branch v7) failed with status FAILURE.

This is a part of CUDA 11.0 support. #3405 will follow after this get merged.

pfnCI, test this please.

Jenkins CI test (for commit 5c203d28528ba22517234ea0fe71032df0a763e0, target branch v7) failed with status FAILURE.

pfnCI, test this please.

Jenkins CI test (for commit 3d62fac797480707e2dd888cc910fbb5bf71fbec, target branch v7) succeeded!


Create ConvertMinutesintoSeconds.py

python code for converting minutes to equivalent seconds
Description
Write here what you have changed
Issue No.- #

Type issue number after hash(#)

Checklist

[ ] Yes, this task assigned to me.
[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] My Filename is in camelCase format
[x] I have added Problem statement, Problem link in file.

Missing and wrong issue number, Marking it as spam

Why spam , what's wrong in my code ..
On Thu, 15 Oct, 2020, 2:06 pm Aayushi Sharma<EMAIL_ADDRESS>wrote:

Missing and wrong issue number, Marking it as spam
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/codeDroid1/Python-Thunder/pull/252#issuecomment-708993759,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM5MQUKDJSJN6KEJJ3B3S3TSK2YBJANCNFSM4SGFOIJQ
.

I have put the working code and made a PR , I can justify that. .
On Thu, 15 Oct, 2020, 2:46 pm chidambar joshi<EMAIL_ADDRESS>wrote:

Why spam , what's wrong in my code ..
On Thu, 15 Oct, 2020, 2:06 pm Aayushi Sharma<EMAIL_ADDRESS>wrote:

Missing and wrong issue number, Marking it as spam
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/codeDroid1/Python-Thunder/pull/252#issuecomment-708993759,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM5MQUKDJSJN6KEJJ3B3S3TSK2YBJANCNFSM4SGFOIJQ
.


Move adminRoles to config.js and delete now unnecessary file

Because

We've recently moved all config information to config.js, except the adminRoles constant. Instead a field in config.js was created, but was just set to the value of the constant

This PR

Sets the value directly in config.js
Updates existing references
Deletes now unnecessary and obsolete constants/admin-roles.const.js (and the parent folder constants/

Pull Request Requirements

[x] I have thoroughly read and understand The Odin Project Contributing Guide
[x] The title of this PR follows the location of change: brief description of change format, e.g. Callbacks command: Update verbiage
[x] The Because section summarizes the reason for this PR
[x] The This PR section has a bullet point list describing the changes in this PR
[x] If this PR adds new features or functionality, I have added new tests
[x] If applicable, I have ensured all tests related to any command files included in this PR pass, and/or all snapshots are up to date

@01zulfi
Can you take another look at this please


Port request: sparsesuite

GitHub repository is avialable at: https://github.com/jlblancoc/suitesparse-metis-for-windows.

Sorry, already provided.


Agenda item: bans

At the moment all projects have coc violation bans established using the dnfadmin account
Topics of discussion include

Is the CoC being followers with temporary bans only
are member projects able to opt in or out
Related to #55 should a GitHub action be used and not a admin account
how can the process have been better communicated and similar processes be communicated since many member projects maintainers were unaware it happens
Are there potential privacy issues since the ban list is effective public to maintainers with it happening across projects since they can go to their projects ban page

Worth noting there was a email sent out to a maintainers email list on the 21 August 2021 mentioning a universal ban process. It didn't go into any mechanisms around it though.


Update packages

Hello, @andyone , Go 1.6.3 and vips 8.3.1 is out now, it would be awesome if you update the rpm specs.
Thank you.

Hi @simukti sorry for delay. Latest versions of golang and vips was added to testing repository and can be installed through yum --enablerepo=kaos-testing install command.
Packages will be available in release repository after tests for production ready state in PR #85.


Execute on windows fails with \r\n problem

10:22:31 AM - info: Compiling Ergo logic
Promise finished and result is
undefined
10:22:31 AM - error: invalid syntax at line 1 col 43:

  Name of the person to greet: "Fred Blogs".
                                            ^
Unexpected "\r"

I am using the Javascript API on the hello world example and have the above error.
const Commands = require('@accordproject/cicero-cli/lib/commands');
Commands.execute(templatePath, samplePath, requestsPath, statePath);
Windows newlines are \r\n, Linux are \n.
A simple fix (simple does not mean a good idea) is to in executeTemplate
https://www.npmjs.com/package/file-normalize
    var sampleText = fs.readFileSync(samplePath, 'utf8');
    sampleText = file.normalizeNL(sampleText);

This sounds like a good idea. We should ensure that we are consistent everywhere we use fs.readFileSync that newlines are normalised. Want to work on a PR for this?

Duplicate  of #197

Sons-MacBook-Pro:cicero sonlam$ cat sample.txt
Name of the person to greet: "Fred Blogs".
Thank you!
Sons-MacBook-Pro:cicero sonlam$ cicero --version
0.13.5
Sons-MacBook-Pro:cicero sonlam$ cicero parse --template<EMAIL_ADDRESS>--sample sample.txt
4:53:46 PM - error: invalid syntax at line 3 col 0:
^
Unexpected "\n"
Sons-MacBook-Pro:cicero sonlam$

Sons-MacBook-Pro:cicero sonlam$ cat sample.txt
Name of the person to greet: "Fred Blogs".
Thank you!
Sons-MacBook-Pro:cicero sonlam$ cicero --version
0.13.5
Sons-MacBook-Pro:cicero sonlam$ cicero parse --template<EMAIL_ADDRESS>--sample sample.txt
4:53:46 PM - error: invalid syntax at line 3 col 0:
^
Unexpected "\n"
Sons-MacBook-Pro:cicero sonlam$

@lamqson This looks like a different issue to me? I'm suspecting you may have an extraneous new line in your sample? This issue was specific to \r which is carriage return and used as part of the new line on Windows platforms.

Sons-MacBook-Pro:cicero sonlam$ cat sample.txt
Name of the person to greet: "Fred Blogs".
Thank you!
Sons-MacBook-Pro:cicero sonlam$ cicero --version
0.13.5
Sons-MacBook-Pro:cicero sonlam$ cicero parse --template<EMAIL_ADDRESS>--sample sample.txt
4:53:46 PM - error: invalid syntax at line 3 col 0:
^
Unexpected "\n"
Sons-MacBook-Pro:cicero sonlam$

@lamqson This looks like a different issue to me? I'm suspecting you may have an extraneous new line in your sample? This issue was specific to \r which is carriage return and used as part of the new line on Windows platforms.

@jeromesimeon: Thanks a lot for looking into it. I just use 'vi' to create the file. I don't see any extra \n ( I attach the file here). But I wonder the parser should be able to strip the characters? It is very hard for users to hunt for the invisible characters. Would you be able to add this request?
Best Regards,
sample.txt

Sons-MacBook-Pro:cicero sonlam$ cat sample.txt
Name of the person to greet: "Fred Blogs".
Thank you!
Sons-MacBook-Pro:cicero sonlam$ cicero --version
0.13.5
Sons-MacBook-Pro:cicero sonlam$ cicero parse --template<EMAIL_ADDRESS>--sample sample.txt
4:53:46 PM - error: invalid syntax at line 3 col 0:
^
Unexpected "\n"
Sons-MacBook-Pro:cicero sonlam$

@lamqson This looks like a different issue to me? I'm suspecting you may have an extraneous new line in your sample? This issue was specific to \r which is carriage return and used as part of the new line on Windows platforms.

@jeromesimeon: Thanks a lot for looking into it. I just use 'vi' to create the file. I don't see any extra \n ( I attach the file here). But I wonder the parser should be able to strip the characters? It is very hard for users to hunt for the invisible characters. Would you be able to add this request?
Best Regards,
sample.txt

This file ends with a new line \n character. The one I used ~above~ in the other issue(!) ends with a ! character.


Add individual building block owners to the repository

Problem
Code reviews often done as 'consensus review' without clear assignment for technical review.
Not clear who can be asked about specific functionality - why is it there, how to use, how to refactor if needed
General structure of the code is often unclear (same source directory containing multiple functionality)
Change overview
Update code owners with a more complete list of what seem to be "large building blocks of the SDK". This will give us:

automated addition of reviewers
a list of who knows parts of the code
highlights odd code locations (same blocks sharing the same location in source code)

Testing
Code owners file - do not know if this can be tested.

We tried this before, and @reviewers-foo were not added after making the change. Basically GitHub would just use the last line that matches the path. Is it still a problem?

Very much so, and it did work - the problem is that GitHub has a limit of 15 reviewers per PR, and it started fighting with itself adding reviewers.
Note, I also think we should do this label based, not path based, since we're duplicating groups. Example here:
https://github.com/project-chip/connectedhomeip/blob/master/.pullapprove.yml
Let's just make groups for these areas, add people to the groups, and request reviews based on that (like we're doing today).

Labels here:
https://github.com/project-chip/connectedhomeip/blob/master/.github/labeler.yml
Review requests here:
https://github.com/project-chip/connectedhomeip/blob/master/.pullapprove.yml

We tried this before, and @reviewers-foo were not added after making the change. Basically GitHub would just use the last line that matches the path. Is it still a problem?

I was trying to figure out where to place this. I like the idea of 'add owners for technical review automaticallly' however if this causes issues I am all for alternate approaches.
Opinions on:

as is (assuming it does work ... I now have my doubts)
create an "OWNERS" file in every relevant directory that contains names and description about what is owned (however I think no tool will parse this ... although we can create our own bots during fixit time)
create a OWNERS or "FUNCTIONAL_AREAS" in the top of the source tree that contains the same info but is not used by github in any way

I personally like (2) a bit because it keeps owners with the source.

Closing for now: latest standup decided that code ownership areas are not a large area of concern currently and asking over slack may be sufficient.