FIX LFS track fix for Hub Mixin

Addresing this forum post. git_add() wasn't tracking for Hub Mixin so I fixed it.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

This solution doesn't work for some reason. (see below)
I create repo on remote and clone it, save big file, then push the model (and save the model in the same directory meanwhile). While I try to push and fail, I checked what's inside my repository (what's added with auto_lfs_track=True) to see if the large file is there. Everything seems ok.
(Pdb) os.listdir(f"{tmpdirname}/{WORKING_REPO_DIR}/{REPO_NAME}")
['config.json', 'large_file.txt', '.gitattributes', 'pytorch_model.bin', '.git']

The error message:
Upload file pytorch_model.bin: 100%|███████████████| 1.04k/1.04k [00:02<?, ?B/s]
OSError: git: 'credential-get' is not a git command. See 'git --help'.
git: 'credential-get' is not a git command. See 'git --help'.
remote: Enforcing permissions...
remote: Allowed refs: all
remote: -------------------------------------------------------------------------
remote: Your push was rejected because it contains files larger than 10M.
remote: Please use https://git-lfs.github.com/ to store large files.
remote: See also: https://hf.co/docs/hub/adding-a-model#uploading-your-files
remote: -------------------------------------------------------------------------
remote: Offending files:
remote:  - large_file.txt (ref: refs/heads/main)

Below is my test:
def test_auto_lfs(self):
    REPO_NAME = repo_name("PUSH_TO_HUB_LFS")
    with tempfile.TemporaryDirectory() as tmpdirname:
        os.makedirs(f"{tmpdirname}/{WORKING_REPO_DIR}/{REPO_NAME}")
        self._repo_url = self._api.create_repo(
        repo_id=REPO_NAME, token=self._token
        )
        repo = Repository(local_dir = f"{tmpdirname}/{WORKING_REPO_DIR}/{REPO_NAME}",
        clone_from=self._repo_url)

        model = DummyModel()
        large_file = [100] * int(4e6)
        with open(f"{tmpdirname}/{WORKING_REPO_DIR}/{REPO_NAME}/large_file.txt", "w+") as f:
            f.write(json.dumps(large_file))

        model.push_to_hub(
            f"{tmpdirname}/{WORKING_REPO_DIR}/{REPO_NAME}",
            api_endpoint=ENDPOINT_STAGING,
            use_auth_token=self._token,
            git_user="ci",
<EMAIL_ADDRESS>            config={"num": 7, "act": "gelu_fast"},
        )
        model_info = self._api.model_info(f"{USER}/{REPO_NAME}", token=self._token)

        self.assertTrue("large_file.txt" in [f.rfilename for f in model_info.siblings])
        self._api.delete_repo(repo_id=f"{REPO_NAME}", token=self._token)

I'll check again tomorrow but it's quite strange 😅

Feel free to update the PR with the test as it's easier to see the code directly with the related failing test

@osanseviero I'll take a look again but I can't see what's wrong still.

The corresponding test is passing in GitHub Actions from what I can see at https://github.com/huggingface/huggingface_hub/runs/7370045472?check_suite_focus=true#step:5:38 .
There are some other, unrelated failing tests

@osanseviero I can check the rest 🙂 IDK why it wasn't passing on my local (though I didn't have the debugger on)

It's fine to merge if the tests are unrelated, this PR should focus in the lfs track issues. There are still some quality issues though :)


Unable to insert/edit image

When I click the browse icon, the media box will pop up behind it, but I'm unable to select it without closing the insert/edit image box in front of it.  However, if you close the insert/edit image box in front of it, the picture can't be inserted.
Is this a bug other people are experiencing as well? Any work around for this?

Should be fixed. Duplicate of #147
What version of camaleon are you running?

I'm using 1.0.3 - I believe that is the latest one.

:+1: No problem


[Bug]:  ((The Great Cities of JK's North - Patch)) This mode has been updated to the latest version

Group
The Great Cities of JK's North
Describe your issue. Please provide your load order using Load Order Library if applicable.
https://arca.live/b/tullius/69561514?p=1
Please look at this picture.
((The Great Cities of JK's North - Patch)) This mode has been updated to the latest version. If you use this mode with the latest version, the terrain will be ruined as shown in the picture. Please modify it to be compatible. I beg you.
Crash report/logs
https://arca.live/b/tullius/69561514?p=1

i dont touch landscape records at all lol


ci: add dev branch to release-update-file

:tada: This PR is included in version 1.6.0-dev.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.7.0-dev.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Makefile: Drop vndr whitelist

Since autocompletions moved to contrib/ in https://github.com/containerd/containerd/pull/3766 we can remove this from the Makefile as well.

Can you sign your commit with the proper DCO please?
Ref:
https://github.com/containerd/project/blob/master/CONTRIBUTING.md#sign-your-work

@crosbymichael sorry, missed that. Added it.

@mrueg no worries. Thanks!

LGTM


Differential loading bundle file names are not suffixed with ES2015 or ES5 causing only one file to output

🐞 Bug report
Command (mark with an x)

[ ] new
[x] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
No. Upgrade from Angular 8 to 9.
Description
I am trying to utilize differential loading feature. I have set my app target to ES2015. ng build --prod shows in the console it is generating ES5 bundles. But in the final output I have only one file for each main, runtime, polyfills without suffix es2015, es5. Please see below screenshot.

🔬 Minimal Reproduction
It is consistently happening on a app upgraded from Angular 8 to 9. On a app directly created for Angular 9 no issues.

🔥 Exception or Error
Nothing

🌍 Your Environment

Anything else relevant?
No

Hi @jyothi530, Are you using custom builders? I am unable to reproduce this with a standard CLI project?

@alan-agius4 I use ngx-build-plus to define global variables. I figured out. Thanks for responding. In the build architect when my builder property value is "@angular-devkit/build-angular:build" it was producing files as mentioned above. I compared it with the standard cli project of angular 9. There the value was "@angular-devkit/build-angular:browser". It worked as expected after changing from build to browser. You can close the issue if you think it is working as expected.
I have one question. A separate bundle is not generated for each lazy loaded modules. Everything is in main.js file. Can you please let know if I am missing something or with Ivy separate file will not be generated for each lazy loaded module.
Thanks

Duplicate of #16098


Integration tests

This PR includes the integration tests and many fixed and features needed to make the test to pass:

salty test
randy test
witness test
delegate test
multisig test (not fully working yet)
addRole method
delpre
rply msg
fix interact

Ran the tests successfully


replace react-stripe-elements with stripe-react-js

This PR addresses the issue mentioned in AnomalyInnovations/serverless-stack-com#511

Thanks! This will be going into our upcoming update!


How to pass Hocuspocus errors to front end?

Description
I am using TipTap with Hocuspocus for collaborative editing, with Database extension, Transformer to convert initial content html from an API to ydoc onLoadDocument (once) then ydoc is synced to RethinkDB for persistent storage. I am using ReactJS as frontend of the editor. Everything working fine with your excellent support and help. But I couldn't find a way to pass if some error occurs on server.js, like API fetching errors, invalid format so on. I would like to send the error to the front end React. How is this possible so that I can show something like 'Failed to fetch template html' for example.
Expected behavior
Pass the errors to front end
Environment?

operating system: MAC OS 12.1, Ubuntu
browser: Firefox, Chrome
mobile/desktop: Desktop
Hocuspocus version: 1.0.0-beta.2

@AnnieTJohn please check out Discord for question on how to do something, Github is just for tracking bugs :) The community is much bigger in Discord.
Anyway, you can potentially solve this using connection.sendStateless.

Thank you so much for the suggestion.


SpaceExploration + AAI Programmable Vehicle break Vehicle Depot selection priotrity

The changes in collision masks when SE is also installed break the Selection priority for the Vehicle Depot from AAI, to fix this a patch has to be added that changes the selection priority of the different vehicle depot entitles when both mods are installed to ensure the right entity (the container and maybe the signal) can be selected.
Can't think of a generic way to fix this so I guess a fix would have to be added for every multi entity that breaks due to collision mask/selection priority problems.

True, just run into this problem. Can't open the depot inventory nor deconstruct it with ghosts on water mod installed

Since this mod is going to be obsolete I'm not going update it anymore unless something affects me personally or someone makes a pull request. I think this is better to be fixed on the AAI side, all AAI would have to do is change the selection priority of their entity to ensure that the inventory of the depot is always on top. It's better if the mod itself set's the selection priority of it's own entities instead of relying on the collision mask as a tie breaker (which causes it to break with ghost on water becosue ghost on water changes collision on everything to ensure you can't place the water ghosts on top of existing buildings.


Fix bugs found in nezuo's review

https://gist.github.com/nezuo/daa05b68ed8329f0364059e6317ca2d3

The most urgent fix is to implement a check of whether documents are open in CloseAllDocuments

More comments from nezuo:

Documents that are opened after BindToClose starts are not closed
CloseAllDocuments doesn't yield until all documents are closed, so the server could close early


ISPN-4816 Hot Rod decoder checks remote IllegalLifecycleStateException

https://issues.jboss.org/browse/ISPN-4816

Pushed, thanks


Modify the serial number for design document

Modify the serial number which begins from 1 instead of from 0.
Signed-off-by: yuexiao-wang<EMAIL_ADDRESS>

@aboch @sanimej   PTAL

LGTM


How to re-generate example client?

Is the swagger file missing to regenerate the example code (example dir in project)? Additionally it seems like this target is not functional in the package.json:
    "gen": "ts-node ./src/main.ts",

I guess it should be ...main.ts -s the-missing-swagger-file.json -o example.

We will add tests for the generator in near future. The biggest priority is to generate module with support for namespaced (micro)services.

This is no longer relevant.


Upload performance is less impressive than download

I deployed one chat server and opened one chat client in different countries. I used this single client to profile download and upload performance. The download speed could reach about 15Mbps, which is OK. But the upload speed never reached 1Mbps. The server continued processing messages for some time after client finished sending all the messages. No message was lost on the server side. It seems there is some throttling for upload.
If there is throttling, where can I find out the code for throttling? If there is not, how can I improve the upload speed?
Thank you.

There are a lot of factors that could cause this. Does your server do any significant work in onMessage? If yes, try offloading the work to another thread using a blocking queue or an executor service (or just comment it out for sake of testing).
If that doesn't fix the issue, you should create a minimal example that demonstrates the issue and post it here so we can investigate it.
There shouldn't be any throttling done in this library.

Here is the example. I made minimal changes to ChatServer and ChatClient. If the server and client are in different countries, you will see the upload speed is less than 1Mbps. The sending call runs very quickly, but the messages are kept in memory on Client side and processed slowly.
I used WireShark to compare this example with some online speed test. It seems ChatClient get ACK packets from ChatServer much more frequently than online speed test.

If my measurements are correct, the example sends 60 Mbps of websocket data, which is... a lot. Keep in mind that each message on console represents 120000 bytes sent.
The only way to see if the bottleneck is in this library is to check the TCP upload speed between both machines using something like iperf and compare it with websocket throughput.
For me, the TCP upload speed between my laptop and server is 14 Mbps while the websocket server can keep up with 6 Mbps.

Yes, console prints out one line per 100 send() calls, which send 120000 bytes. In my testing, the client console printed out the lines very quickly, which gave me the impression that the upload was very fast. But in fact, most messages were kept in memory by the client and the memory usage kept going up. The server received about 100 messages per second and the server console printed out the lines at a much slower speed - about one line per second.  You can check out the screenshot of my testing.
Timestamp is printed out in console now after I made minor code change: example

The send call on client side doesn't block. It creates the frame and pushes it to a linked blocking queue.

So the blocking queue is not processed in a timely manner, is it? How can I improve the throughput?

Have you checked the actual TCP throughput? Are you sure you aren't simply limited by internet speed between the two machines?

If I remove line 817 (ostream.write(buffer.array(), 0, buffer.limit());) in WebSocketClient.java, everything seems fine.
But the upload speed of my internet connection is 500Mbps, and the download speed of the other machine is also hundreds of Mbps.

I deployed a netty server, then used the same ChatClient, the upload speed was 30Mbps.
Everything is the same except the websocket server.

Okay, that sounds pretty bad. I'll try to profile the library and see what I can find.

It turns out for the client -> server message, the data needs to be masked (XOR), so the upload performance is not as good as download performance.

Has the problem been solved now

Any news about this?

I have reproduced the issue. Still investigating the root cause.
Some observations:
sending kilobyte-sized messages results in exactly one write(2) syscall with slightly more than 1000 bytes.
When the server receives the upload, read(2) returns relatively small chunks - about 1400 bytes.
However when the client receives the download, read(2) returns much more data - 16kb per read.
This should not be enough to cause the huge difference in speed but I'm still not sure yet.
Neither server nor client are cpu bound.
It also happens on localhost, although the effect is less extreme.

@PhilipRoman  you are looking for something like https://github.com/TooTallNate/Java-WebSocket/blob/bdf928b487b8c643868f410300e66de3df9c51d2/src/main/java/org/java_websocket/server/WebSocketServer.java#L565 ?

@PhilipRoman could you check if https://github.com/marci4/Java-WebSocket-Dev/tree/Issue1117 helps?

Hello, has there been any update on this problem?

Hello, I have also encountered this performance bottleneck now. Has anyone solved this problem? Or is there an alternative solution.
And I use 1.5.7 Version


Fix/2fa

Description

Verify email/phone on "personal info" page
Add api for "personal info" page, mappers/unmappers
No more inputs on "2fa" page
Changed a bit styles

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected) (probably :P)

How Has This Been Tested?
tested locally
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules


fail to install caravel

Hi,
I cannot acheive installing caravel on centos 7 using pip
Building wheels for collected packages: cryptography, pandas   Running setup.py bdist_wheel for cryptography ... error   Complete output from command /usr/bin/python -u -c "import setuptools, tokenize;__file__='/tmp/pip-build-7nCltq/cryptography/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" bdist_wheel -d /tmp/tmpApEwg7pip-wheel- --python-tag cp27:   Traceback (most recent call last):     File "<string>", line 1, in <module>     File "/tmp/pip-build-7nCltq/cryptography/setup.py", line 335, in <module>       **keywords_with_side_effects(sys.argv)     File "/usr/lib64/python2.7/distutils/core.py", line 112, in setup       _setup_distribution = dist = klass(attrs)     File "/usr/lib/python2.7/site-packages/setuptools/dist.py", line 272, in __init__       _Distribution.__init__(self,attrs)     File "/usr/lib64/python2.7/distutils/dist.py", line 287, in __init__       self.finalize_options()     File "/usr/lib/python2.7/site-packages/setuptools/dist.py", line 327, in finalize_options       ep.load()(self, ep.name, value)     File "/usr/lib/python2.7/site-packages/cffi/setuptools_ext.py", line 161, in cffi_modules       add_cffi_module(dist, cffi_module)     File "/usr/lib/python2.7/site-packages/cffi/setuptools_ext.py", line 48, in add_cffi_module       execfile(build_file_name, mod_vars)     File "/usr/lib/python2.7/site-packages/cffi/setuptools_ext.py", line 24, in execfile       exec(code, glob, glob)     File "src/_cffi_src/build_openssl.py", line 93, in <module>       extra_link_args=extra_link_args(compiler_type()),     File "/tmp/pip-build-7nCltq/cryptography/src/_cffi_src/utils.py", line 64, in build_ffi_for_binding       extra_link_args=extra_link_args,     File "/tmp/pip-build-7nCltq/cryptography/src/_cffi_src/utils.py", line 72, in build_ffi       ffi = FFI()     File "/usr/lib/python2.7/site-packages/cffi/api.py", line 59, in __init__       "version mismatch, %s != %s" % (backend.__version__, __version__)   AssertionError: version mismatch, 0.8.6 != 1.6.0
As I understand it's a problem with the version of cffi package but I don't know how to upgrade or downgrade it ?

maybe we can close the issue as I should have posted it on google group


Update to bitflags 0.3.

I'm not sure I understand why the build failed like this, looks like there is some nasty thing going on...
I'll look a little into this, however be aware that this library is going to be radically changed in the near future, to follow the complete changes of wayland-client-0.3. I'll probably see to update the dependencies then.
Unless there is a really urgent need to update this dependency ?

Not really; I just noticed that Servo depends on two versions of bitflags, which is annoying but not problematic.

Well, if servo depends on wayland-kdb through glutin, it'll eventually get fixed.
I'm in the middle of a big overhaul of my wayland-* crates in conjunction with some changes from the wayland devs, in order to make the whole thing more rusty. But it takes some time to get all things updated.

Alright, these were just some issues with the dev_dependencies, fixed now!
Thanks!


Introduce GenericArg like in Chalk

Plus some more adaptations to Substitution.
Lots of assert_ty_ref that we should revisit when introducing lifetime/const parameters.

bors r+
changelog internal


Path lifting (Graph to Hypergraph)

Motivation
We propose a new lifting based on paths stemming from or between nodes. This lifting might be interesting for studying pairwise conversion mecanisms that defines membership to a community or a group, for example proselytism.
Method
Our method starts by defining source nodes. These nodes will be the origin of paths. Each source node can have an associated target node and must have an associated length. The hyperedges are defined to be all paths of the specified length starting from the source nodes. When a target node is also specified, only the paths ending at the target are kept.
We use by default ProjectionSum() to lift the features, but we might propose another natural feature lifting method more specific to the path lifting. In particular a feature lifting that depends on the order in which the nodes are visited would distinguish different paths on the sames nodes.
Parameters
Required parameters:

source_nodes (list[int]): a list of nodes from which the paths start.
target_nodes (list[int]): a list of nodes in 1 to 1 correspondence with source_nodes that defines a target for each source. If the target is None, then all path stemming from the source are kept.
lengths (list[int]): a list of lengths in 1 to 1 correspondence with source_nodes that defines the length of each path.

Optional parameters:

include_shorter_paths (Boolean): whether or not to include paths of shorter length between source and target nodes. Defaults to True.

Hello @PierrickLeroy! Thank you for your submission. As we near the end of the challenge, I am collecting participant info for the purpose of selecting and announcing winners. Please email me (or have one member of your team email me) at<EMAIL_ADDRESS>so I can share access to the voting form. In your email, please include:

your first and last name (as well as any other team members)
the title of the method you implemented
the input domain of the method you implemented
the output domain of the method you implemented
your pull request number (#52)

Before July 12, make sure that your submission respects all Submission Requirements laid out on the challenge page. Any submission that fails to meet this criteria will be automatically disqualified.


Feature: Python bytearray support on low-level API

Describe what you are looking for
Is there any plan to support bytearrays on low-level Python API methods?
They behave a lot like bytes but they are mutable (which allow using them as buffers on IO operations, etc), hence, they solve a lot of use-cases where you can't use bytes.
Can you contribute to the implementation?

[X] I can contribute

Is your feature request specific to a certain interface?
Python bindings
Contact Details
No response
Is there an existing issue for this?

[X] I have searched the existing issues

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I was under impression that we already support them. Probably a good idea to add a test case. Extending should be very easy. Thanks for reporting, @marcoffee 🤗

Wow, that was really fast!
Thanks!! 🚀 🚀 🚀


PR: QWebChannel implementation and tests

Fixes #102

I'm in PyQt-5.9.0 / Windows , so I should not upgrade for now ?

The problem was only related to our tests.


Distro-specific testing

Investigate a system of testing each distro-specific installer.

This has been complete for all distros except Windows MSI which still needs to be manually tested.


Panic on none regular disk environments

Describe the bug
Looks like the djherbis times lib doesn't like getting the "birthtime" of things on readonly/exfat/overlayfs/squashfs/live media. On my distro's live ISOs walker crashes out on startup with the following error:

it is fine once on a regular running system
Version
0.10.4
Minimal Config
Default config
To Reproduce
Try to use walker on a squashfs based live usb/cd
Expected behavior
Should just open and not panic
Desktop

OS PikaOS
DE Hyprland

should be fixed in 0.10.20.

...can this be closed?

Will check this evening, sry was not at home.

Can't get .20, .21 or .22 to build.
https://git.pika-os.com/wm-packages/walker/actions/runs/19 log for reference. It runs in a fresh docker container.
Have there been any dep/mod changes since .13 that might need the build deps altering in my packaging?

The last change to deps was in 0.10.11 when starting to use vips.
That log doesn't tell me the error either, i must be blind.

Yeah I don't understand it, it's like it just gives up. There have been no changes to our build scripts or the build container/packages though since .13 that worked fine.

It was libvips-dev missing, removing -x from the build flags made it easier to see the real error.
.22 no longer crashes on ISOs so closing. Thanks for the prompt fix!


Server versions

Should this page note more recent versions of Windows server as it currently only lists 2016 but does not say if newer are also supported.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0eaa668f-880c-8415-17bb-8169fe23fd26
Version Independent ID: fe5d3e99-46fc-6daf-a8af-5b0653d500f7
Content: AD FS prompt=login
Content Source: WindowsServerDocs/identity/ad-fs/operations/AD-FS-Prompt-Login.md
Product: windows-server
Technology: ad-fs
GitHub Login: @billmath
Microsoft Alias: billmath

Thank you for submitting this issue.  Unfortunately, due to high volumes I was unable to respond to this in a timely manner.  At this point, I am going to close this due to it's age and the possibility that it may have been addressed.  If this is still a problem, please consider submitting a new issue.  Thank you.
#please-close


refactor: resolve eslint warnings (max-statements, complexity)

Description
Refactor to eliminate eslint warnings: max-statements, complexity in src/lib/controller/index.ts.
Related Issue
Relates to #1248
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Other (security config, docs update, etc)

Checklist before merging

[x] Unit, Journey, E2E Tests, docs, adr added or updated as needed
[x] Contributor Guide Steps followed

The controller index file didn't have direct unit test coverage before I started refactoring it, but I did what I could: I added tests around the lines I had to move to cut the complexity rating, but tried not to touch anything else.
The file's still failing short of the 78.xx% codecov goal but I got it from 0% to 40-something% and I think this is probably the best place to stop (for now).  Doing more is going to require some non-trivial rework and  that feels a bit out of scope for the thread I'm currently pulling.


Unable to map certain claim resolvers

Hello,
According to OAuth2 key-value parameters it indicates

"Any parameter name included as part of an OIDC or OAuth2 request can be mapped to a claim in the user journey"

However, I am unable to map the following OIDC/OAauth2 claims:

state
response_type
id_token_hint

These are standard OIDC claims and per the documentation it should be supported by using the following values:

{OAUTH-KV:state}
{OAUTH-KV:response_type}
{OAUTH-KV:id_token_hint}

I have several clients who are deploying Magic Links and the lack of these mappings is making it extremely difficult to handle these scenarios.
Please advise.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4fc94d79-52c2-d03a-9821-32c048ffa020
Version Independent ID: e4303183-d476-6104-fcaf-00e3beb23787
Content: Claim resolvers in custom policies - Azure AD B2C
Content Source: articles/active-directory-b2c/claim-resolver-overview.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

@Norrch2
Thanks for your feedback! We will investigate and update as appropriate.

Hi @Norrch2 , here is a sample user journey that can extract an id_token_hint:
https://github.com/azure-ad-b2c/samples/blob/master/policies/invite/policy/SignUpInvitation.xml#L161
Can you clarify what issues you are facing with the other claim resolvers?

Hi @MarileeTurscak-MSFT
That is the policy we tried. The problem we are facing is that the source code for this is assuming the response_type=id_token but in some scenarios may need to be code.

Thanks for clarifying. Yes, I believe you are correct and I don't think the Claim Resolvers you want to use are supported.
These are the Claim Types per the ClaimsSchema document. Additionally, in the OAuth 2 Technical Profile doc it doesn't mention claims for  state, response_type, or id_token_hint.
When the document says "Any parameter included as part of the OIDC or OAuth2 request can be mapped", the example is describing any custom query string (ClaimsTransformation) where you can transform a given claim to another one. Not creating a claim for the Authorization (state, response_type, etc.) that's being sent.
Jas Suri also says:

Claims resolvers only work in specific Technical Profiles, those being REST API and SelfAsserted (combined sign up and sign in content definition at the orchestrations step). It explicitly only works in the examples provided in the document.

You can use the OAuth2 Token endpoint metadata as part of the Technical Profile to retrieve claims though. For more info.
I don't believe what you are trying to do is supported since the request parameters (state, response_type, etc.) are different from the Claims (Name, IDP, Email, etc.).
There is a feature request open for this here that you can upvote:
Claim resolvers for ALL OIDC/OAuth2/SAML URL query parameters
I have created an internal feature request for your ask as well.
I'm closing this out since this is being tracked internally, but have added @JasSuri for any additional comments and in case I missed anything.


Please invite me to the community

Invite me to the Surpath Hub Community.

Name: Vincent Villafuerte

Country: Philippines

Discord Username(if exists): vinzvinci#5227

Additional Context:

I meet SurPath Hub in YouTube

I'm excited to learn more about open source and add value to the community

Invite me to the Surpath Hub Community.
Name: Christine Mae Calumbiran
Country: Philippines
Discord Username(if exists): cwistin#1464
Additional Context:
Saw SurPath Hub on Facebook
Willing to learn, and help 😄

Invite me to the Surpath Hub Community.
Name: Ronald Laz
Country: Philippines
Discord Username(if exists): lexus654#6207
Additional Context:
I saw that sir vins is a campus expert on github and have a community, I feel that this place place will help me grow and learn a lot more  to expand my knowledge about web developing.


Error while uploading the file

JSON.parse: unexpected character at line 1 column 1 of the JSON data
I am uploading .mp4 file which is 158MB and i got this error.

Can you send the logs here?

May i know how can i get the log? Console don't have any error message

There should be, are you using Docker?

Nope.  I use yarn. And host in pterodactyl panel.

It's hard to do anything without logs. Try finding the logs.

Sorry but there is NO any log. I can only provide you video info.
Size: 165.5MB
Kind: MPEG-4 Movie

Try a file under 100MB?

Can you use plain Node to run Void?

File under 100MB will work

btw one more suggestion is support drag and drop image   as well as paste image like imgur

Sure, it will be included in the next major update, along with upload estimation and cancellation.

If you are using nginx with the config in the README, try increasing the max body size.


Binding cluster does not enforce "min 1" constraint on the Group field of TargetStruct

Reproduction steps
The value definition for the parameter min is missing in the Binding cluster.

the min of group_id should be 1
./chip-tool binding write binding '[{ "group":0, "cluster":6}]' 0x654325 0

This command could work incorrectly due to the missing constraints.
Bug prevalence
each time
GitHub hash of the SDK that was being used
5bb5c9e23d532cea40476fc0bd1d3008522792ba
Platform
other
Platform Version(s)
1.3
Type
Common Cluster Logic, Spec Compliance Issue, Core SDK Performance Improvement, Core SDK Interopability Issue
Anything else?
No response

This XML format does not have a way to express constraints on struct fields.
That said, the actual implementation in the Binding cluster needs to be enforcing the constraint, and it does not seem to do that.

If you check the other XML files, for example, application-basic-cluster.xml, they all have a clear definition of min.

And one follow-up question: if the code needs to add the limitation, why does the XML provide the detailed limitation? Does it only affect the .matter file when using ZAP?

For writable attributes the min value is enforced automatically, at least if the value lives in the Ember datastore.
For struct fields there is no enforcement, because nothing uses those XML values for anything; they are not available from the ZAP database, as far as I know.


T265 Camera Pose data in Unreal Engine

Hi,
The Unreal Engine plugin recognises the T265 camera,
and I see that 6dof data is listed as a format in the plugin code.
Is there currently a way to access the 6dof pose data within a Blueprint using the plugin?
Thanks,

Hi @martinthelwell - T265 is not fully supported in Unreal at this time.  You may get the pose data and the device recognized but full support is not available at this time.
We will keep this in mind for future.
Thanks

Hi, what do you mean by "You may get the pose data"? Is it just a matter of exposing the c++ code to the blueprint or it requires writing the reader?

Full support for all the data streams is not essential, just pose data would be great.  My C++ skills are not developed enough to get this without some clues.  Could someone help?

T265 support now in Unreal

intel realsense tracking camera t265 output value  save and live update in CSV file?

how can i get pose from T265 and send to UE4???

@YaoDaDi666 you can create a python application for T265 Pose data and send it to unreal with the help of socket programming.

Of course it's possible. Can you show an example. Woul be helpfull


Refactor .pl` source to src/

All the Java and C code has been refactored into Maven-style structure within /src/, but the Prolog code  .pl remains in the root dir.
Would be good to move jpl.pl, and even jpl_config.pl to /src/main/prolog/
We should not move test_jpl.pl because the whole SWIPL is set-up to find the unit testing in the root of every package. That should stay there

I'm not really against, but not much in favor either.   All packages have very little organization in terms of directories.  Prolog doesn't need it, it is one (and a little helper) file that gets copied to the library.   Moving it mainly means regressing risks.

OK, I take your point. Indeed that is why I did not do it before when I restructured the Java and C code. I am now confident I can handle the copying with CMAKE.
But you are right, maybe there is not much to win and something to lose here, and in any case I am not moving the test_jpl.pl to adhere to the structure on the other packages.
So, point taken, I will drop this. Thanks for commenting your thoughts.


APIs and GUI

Hi!
Thank you for your project, it is the best checkers RL repo I've seen so far. You've done truly great work!
I've got several questions regarding APIs and maybe future development:

Have you tried to make some kind of API for playing with your models on the checkers' websites or software like the ones you stated in the External Benchmarks section? Maybe with Selenium or something?
Do you familiar "Checker Board" PC software? They have a very interesting checkers engine inside.
Do you have an interactive GUI to play checkers by clicking on it? AFAIC see, the current version of GUI only supports displaying the current game state, is it right?

Thank you in advance.

Thank you for the kind words!
This particular project took an enormous amount of my time, and since its last commit I moved on to other projects.  I don't pay much attention to my e-mail or notifications and so did not realize that you had submitted this comment until tonight.

I didn't try to make an API, as I decided it would be faster to just be the man-in-the-middle.  Also, each website would require a different API.
No, I haven't heard of it.  I was mainly focused on replicating DeepMind's AlphaZero rather than creating a Checkers engine.
You're correct, the GUI is for display only.

Sorry for the (very late) response!


porffor@latest on NPM crashing

$ bun x porffor@latest native hello.ts hello
243 |     outFile ??= Prefs.native ? './porffor_tmp' : file.split('/').at(-1).split('.')[0
          ^
error: This assignment will throw because "outFile" is a constant
    at /tmp/bunx-1000-porffor@latest/node_modules/porffor/compiler/index.js:243:5

70 |   const outFile = Prefs.o;
             ^
note: The symbol "outFile" was declared a constant here:
   at /tmp/bunx-1000-porffor@latest/node_modules/porffor/compiler/index.js:70:9

Bun v1.1.39-canary.112+1fa0dee5e (Linux x64 baseline)

It also happens with Node and pnpx. The error message is differently phrased, but it's the same error (assignment to a constant).
The program file content doesn't affect the error.

Whoops, thanks for the report, fixed!


Fix #9089 don't log mundane stuff at info level

This is a quick fix to reduce the noise of some logging that's really
only useful for troubleshooting/debugging.

I’ll merge this for you.


Unify rand crate version

Currently code is mix of rand=0.7 and rand=0.6.5
This contributes to some compilation issues when rand object created in one crate is passed to another.
Since 0.6.5 is dominant in our codebase, this commit changes few crates that were using 0.7 to 0.6.5

@bors-libra r+

:pushpin: Commit d506ad3 has been approved by aching

:hourglass: Testing commit d506ad33cbced15626c5733669db9698a7af319f with merge f3bc75ccc09247a0832dd26ecca4bc4c284f9c64...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: aching
Pushing f3bc75ccc09247a0832dd26ecca4bc4c284f9c64 to master...

While its probably good to unify on the versions we're using across our codebase, I just want to point out that this didn't actually change any of our dependencies, we still rely on rand 0.7 transitively


bump fix

fix for https://github.com/ZOSOpenTools/gitport/pull/102

A suggestion: could the titles be something like "add/update patch(es) for 2.43.0".
With the rate at which bump is pulling in updates, we'll have too many commits/PRs with the same name otherwise :sweat_smile:

cacert issue

/run tests

@IgorTodorovskiIBM @HarithaIBM Just wondering... for neatness or housekeeping, is it possible to work on the branch that bump creates and push the fixes/updates through that branch itself?


Keithley 2600 driver, Handle invalid commands better

#1301 Fixes a number of commands that were passed incorrectly to the instrument, but it does also highlight a different problem with the driver. If a parameter is set to an out of bounds value an error message is displayed but this is not reflected as a return code.
This could be resolved by reading the error count before and after a write and then reading any error message back. E.g replace write with something along the lines of.

def write_with_errorhandling(cmd):
    n_error_before = self.ask('errorqueue.count')
    self.write('{cmd}')
    n_error_after = self.ask('errorqueue.count')

    if n_error_after > n_error_before:
        for i in range(n_error_after):
            error = self.ask('errorqueue.next()')
            log.warning(error)
        raise RuntimeError(error)

But that would probably be significantly slower.
One would need to benchmark this to see if that is an issue. It might be possible to combine the multiple write commands in one for better performance

this sounds like a bad API from the manufacturer. Do they discuss this situation in their manual/SDK? :)
is it not easier to define the parameter bounds in the driver? and also just implement a method that returns the last errors from the queue (probably something like that is already in the driver)?
Regarding combining commands, if you combine multiple commands, you might not know which command resulted in an error and which one went successfully, right? how useful/verbose is errorqueue command?

Regarding combining commands, if you combine multiple commands, you might not know which command resulted in an error and which one went successfully, right?

I think the suggestion was to concatenate one potentially-failing command with known and understood commands to query the error queue about the success of the unknown command,.

is it not easier to define the parameter bounds in the driver?

This is always the preferred way, fail fast and fail in software. But this is only possible to the extend that the driver author understands the internal workings of the instrument. I think @jenshnielsen is bringing this up because of undocumented and unexpected inter-connections between parameters that make him question the validity of his mental model of the instrument and thus seek a safe fallback solution.

is it not easier to define the parameter bounds in the driver? and also just implement a method that returns the last errors from the queue (probably something like that is already in the driver)?

Yes as @WilliamHPNielsen suggested we already try to do this as much as possible but how would you proof that you protect against all combinations of all parameters including the ones that have not been added yet. It would be much more safe to also error out on any invalid command.

Regarding combining commands, if you combine multiple commands, you might not know which command resulted in an error and which one went successfully, right?

Obviously you need to know if a command returns any thing and then count to do this correctly but Visa is intended for use this way. In this case the errorqueue.count will return a string + termination char and the set command will return nothing. But a command like print(errorqueue.count) should not fail "silently". This happens when you set something out of bounds but not if the command is invalid or gives a time out. That will result in a real visa error as normally. I would expect something like?
visahandle.write("print(errorqueue.count)\nsmua.source.limiti=1\nprint(errorqueue.count))
n_errors_before = int(visahandle.read())
n_errors_after = int(visahandle.read())

To work with suitable error handling added.

how useful/verbose is errorqueue command?

errorqueue.count returns the number of errors in the query and errorqueue.next() will contain the error code, message and so on.

ok, thanks for clearing this up.
i agree, but i dislike this for two reasons:

its ugly
it may slow things down

well, ugliness is inevitable; and to avoid things being slowed down, the error handling mechanism can be made optional, right?

well, ugliness is inevitable; and to avoid things being slowed down, the error handling mechanism can be made optional, right?

Yes that was the point I tried to get across originally and why i raised the issue and not a pr, any fix for this needs to be benchmarked for the impact

Actually VISA gives the possibility to add a listener callback function that gets called if the status register of the instrument indicates an error.
I played with that some time ago. If its of interest I can try to find my example code.


Customization Request

Looking to add the two items as posted in a photo by longo on issue #210 . In the pic where it says "your basket" I would like to add an image there instead of text and I would also like a terms of service checkbox on the cart pop-up as pictured there also. Any help would be appreciated. Love the minicart, thanks!

Here is an implementation of PayPal Minicart were shipping costs are based on item weight. Shipping calculation happens instantly and is shown as an item in the main Cart. Several customizations have been made without touching the main minicart library. Many customizations are also possible.
Any feedback is welcome.
http://htmlpreview.github.io/?https://github.com/fabriziotappero/minicart-plus/blob/master/minicart.html


WM5 | LAURA SANTIAGO | HTML-CSS-CAKES | WEEK 2

Learners, PR Template
Self checklist

[ ] I have committed my files one by one, on purpose, and for a reason
[ ] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[ ] I have tested my changes
[ ] My changes follow the style guide
[ ] My changes meet the requirements of this task

Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.

https://65244aee7b689623735b0cda--gleaming-crostata-79b113.netlify.app/


Bug: an Entity cannot have a reference to an AggregateRoot

I'm confused about this error and the documentation seems wrong
 Field c.x.m.s.IdentityProviderUser.user refers to an aggregate root (c.x.m.s.User). Rather use an identifier reference or Association!

IdentityProviderUser is an Entity and implements that interface, its AggregateRoot is User this is not an external relationship with another aggregate. DDD allows for this design and in fact aggregate roots are expected to composed of many entities and value objects in many circumstances.
Association/Ids are for aggregate to aggregate relationships.

update:
actually I think this is some kind of false positive
@jakarta.persistence.Entity
@org.jmolecules.ddd.annotation.Entity
@Table(name = "identity_provider_users")
public class IdentityProviderUser implements Entity<User, IdentityProviderUser.@NonNull IdentityProviderUserId> {

  private @NonNull IdentityProviderUserId id;
  private @Nullable User user;

  /**
   * For JPA.
   */
  protected IdentityProviderUser() {}

  /**
   * Create a new instance.
   *
   * @param id
   *   the primary key
   */
  IdentityProviderUser(@NonNull IdentityProviderUserId id) {
    this.id = id;
  }

  boolean hasUser() {
    return this.user != null;
  }

  @Identity
  @EmbeddedId
  @NotNull
  @Override
  public @NonNull IdentityProviderUserId getId() {
    return this.id;
  }

  @Initializer
  void setId(@NonNull IdentityProviderUserId id) {
    this.id = id;
  }

  /**
   * Get the user.
   *
   * @return the user
   * @implNote this method can throw {@link NullPointerException} if this object is not properly initialized. Please
   *   look along initialization paths for the real issue.
   */
  @MapsId("userId")
  @NotNull
  @ManyToOne(
    optional = false,
    fetch = FetchType.LAZY,
    cascade = { CascadeType.DETACH, CascadeType.MERGE, CascadeType.PERSIST, CascadeType.REFRESH }
  )
  @JoinColumn(
    nullable = false,
    updatable = false,
    name = "user_id",
    foreignKey = @ForeignKey(ConstraintMode.CONSTRAINT)
  )
  public @NonNull User getUser() {
    return Objects.requireNonNull(this.user);
  }

  @Initializer
  void setUser(@NonNull User user) {
    this.user = user;
  }

but according to your source it shouldn't be doing this because IdentityProviderUser is not an AggregateRoot
	 * An {@link ArchRule} that ensures that one {@link AggregateRoot} does not reference another via the remote
	 * AggregateRoot type but rather via their identifier type or an explicit {@link Association} type.
	 * <p />
	 *

it doesn't look like this code is checking that both sides are aggregate roots
https://github.com/xmolecules/jmolecules-integrations/blob/main/jmolecules-archunit/src/main/java/org/jmolecules/archunit/JMoleculesDddRules.java#L150-L158

IdentityProviderUser is an Entity and implements that interface, its AggregateRoot is User this is not an external relationship with another aggregate. DDD allows for this design and in fact aggregate roots are expected to composed of many entities and value objects in many circumstances.
Association/Ids are for aggregate to aggregate relationships.

I disagree. Every entity is part of an aggregate (you declare User as the owning artifact here). This means that your reference to User is and aggregate to aggregate relationship, rightfully rejected as invalid. It does not make sense to reject the relationship from User to User, but not from an entity owned by User towards User. If that was allowed, one could work around the rule, by moving aggregate relationships into nested entities.

How is a parent relationship an aggregate to aggregate?
class Node implements Entity<Root> {
   Root parent;
}
class Root implementats AggregateRoot {
   Node child;
}

you're saying this create an aggregate to aggregate relationship by virtue of having a parent where we've identified that it is the parent type?

Also, I think I have to have it due to some nonsense without the Embeddable compound id works in hibernate. Don't quote me 100%, but I recall an issue, I'd have to try removing it and I don't have time right this second. Something to do with needing @MapsId("userId") but maybe the side effect went the other direction. I just recall it being weird and annoying to get the opaque compound id working and it has a few gotchas.
https://github.com/xenoterracide/spring-app-commons/blob/main/security-model/src/main/java/com/xenoterracide/model/security/IdentityProviderUser.java

How is Node not part of the Root aggregate? How is the parent property not a reference to the Root aggregate?
It looks like you conflate aggregate with aggregate root. The former is the entire arrangement including all nested entities and values. References from those towards those must not be full aggregate references as described here.
I guess what you argue is that because the reference targets the same aggregate root, the property should be somehow treated differently. But why? Sich an arrangement would still be subject to the same problems that are valid for aggregate references of other types as well.

How is Node not part of the Root aggregate? How is the parent property not a reference to the Root aggregate?

it is, that's kind of my point, and aggregate, can reference itself internally, it is treated externally as 1 thing. So 2 different aggregates should not hold references to each other, but within a single aggregate it shouldn't matter. You aren't checking that an Entity can hold a reference to another Entity, right? that doesn't make sense.
The ONLY time this should be allowed is when an entity references it's OWN aggregate.
OtherRoot and any entities within it should not have a reference to Root or any entities within it.
A Root with  Id 1 should not have a reference to a Root with Id 2, and Node with parent Id 1 should not have a reference to a Root with Id 2. Problem with this scenario you can only validate it at runtime. I think this is the problem you're trying to enforce not having.

But why? Such an arrangement would still be subject to the same problems that are valid for aggregate references of other types as well.

what problems do you think those are exactly? do you not think objects
I'll read the link later, I have to leave shortly for an operation (no it's not serious). I think somewhere you're not understanding me. I'm looking through the blue/red books for an example.

I have skimmed the link, but even the title says it all

Rule: Reference Other Aggregates by Identity

Since Aggregates don’t use direct references to other Aggregates but reference by identity, their persistent state can be moved around to reach large scale.

The keyword here is Other, this all happens within the same aggregate, there is no other aggregate here. The entity is part of the same aggregate and is maintaining a reference to its own aggregate root, there's nothing wrong with that.
Root and Node can belong to the same aggregate. IdentityProviderUser is part of the User aggregate.
I see no disagreement with what the intent here is, but the assertion doesn't match the description; nor as per your reference what the DDD restriction or suggestion, is.
Also consider, what happens if the backend uses something like Neo4j where a graph database being chosen for storage probably means considering nodal traversal and probably frequently bidirectional relationships.

I still think you're trying to make an exception for your special case (a nested entity trying to keep a reference to its owning aggregate instance). That said, the type system cannot reasonably understand whether the reference to Root refers to the same instance or a different root (employee-manager-relationship, that would still be a considered a parent-child-one).
The problem is special in a second aspect, as the back-reference is not really needed. State transitions are triggered on the aggregate root anyway, which could then pass the owning instance to the nested entity should any of the operations on that need access to it.

I don't agree because any entity within the aggregate should be able to hold reference to any other entity within the aggregate to do its work. the root is not special in this. I think you're trying to make up rules that no one has ever stated. Your own evidence did not provide such a statement.

BTW Vaughn himself says it's ok to have entities maintain references to their aggregate root. https://x.com/VaughnVernon/status/1838222241341083840

“…, but why?”

you can read the whole thread... stop being selective about things you choose to read.
where I explain the same thing I did here in less words, and some suggested approach's. The why comes around to the other issue I reported elsewhere which is to have the Opaque UserId instead of passing around things like UUID... it's possible there's another way of doing this. This entire "Entity" is basically to represent a foreign aggregate, and so is essentially an association itself. That doesn't really remove hibernate gotcha's.
anyways, I'm still think that the solution should be association if it refers to an external aggregate. I won't argue past this though, I just wanted you to know I reached out and it seems my suspicions are verified. Have a good one!


Honor guest checkout config

Do not allow guest authenticated to proceed to checkout when
guest checkout is not allowed.

Hey Brian,
Looking good! Just a couple small notes, but otherwise I think this is good to go.

Don't know what's going on with CI here, tests pass locally.

We just switched this repo over to Travis CI; can you rebase to trigger a re-build, please?

Passed in Travis!

:+1: - thanks for fixing this!


Overflow in pool reward calculation

There's a panic due to an overflow when calculating rewards.
The offending line is scaledPoolReward, err := safemath.SafeMul(result, performanceFactor) but judging by the error message, the result that's being passed in is already greater than it should be. So the problem most likely lies somewhere earlier in that code path.
panic: integer under- or overflow:<PHONE_NUMBER>3626084440 * 7: failed to calculate pool reward without fixed costs due to overflow for slot 64: failed to calculate pool rewards for account 0x6aee704f25558e8aa7630fed0121da53074188abc423b3c5810f80be4936eb6e

goroutine 209 [running]:
github.com/iotaledger/iota-core/pkg/protocol/sybilprotection/sybilprotectionv1/performance.(*Tracker).ApplyEpoch.func1({0x6a, 0xee, 0x70, 0x4f, 0x25, 0x55, 0x8e, 0x8a, 0xa7, 0x63, ...}, ...)
	/scratch/iota-core/pkg/protocol/sybilprotection/sybilprotectionv1/performance/performance.go:253 +0x3f3
github.com/iotaledger/hive.go/ds/shrinkingmap.(*ShrinkingMap[...]).ForEach(0x2d38160, 0xc0019e7618)
	/go/pkg/mod/github.com/iotaledger/hive.go/ds@v0.0.0-20231127134220-90b88e35bdb2/shrinkingmap/shrinkingmap.go:165 +0x278
github.com/iotaledger/iota-core/pkg/core/account.(*Accounts).ForEach(...)
	/scratch/iota-core/pkg/core/account/accounts.go:125
github.com/iotaledger/iota-core/pkg/protocol/sybilprotection/sybilprotectionv1/performance.(*Tracker).ApplyEpoch(0xc000266680, 0x0, 0xc00171db40)
	/scratch/iota-core/pkg/protocol/sybilprotection/sybilprotectionv1/performance/performance.go:214 +0x369
github.com/iotaledger/iota-core/pkg/protocol/sybilprotection/sybilprotectionv1.(*SybilProtection).CommitSlot(0xc0007d1760, 0x40)
	/scratch/iota-core/pkg/protocol/sybilprotection/sybilprotectionv1/sybilprotection.go:190 +0x2d2
github.com/iotaledger/iota-core/pkg/protocol/engine/notarization/slotnotarization.(*Manager).createCommitment(0xc00001c000, 0x40)
	/scratch/iota-core/pkg/protocol/engine/notarization/slotnotarization/manager.go:215 +0x559
github.com/iotaledger/iota-core/pkg/protocol/engine/notarization/slotnotarization.(*Manager).tryCommitSlotUntil(0xc00001c000, 0x47)
	/scratch/iota-core/pkg/protocol/engine/notarization/slotnotarization/manager.go:179 +0x92
github.com/iotaledger/iota-core/pkg/protocol/engine/notarization/slotnotarization.(*Manager).tryCommitUntil(0xc00001c000, 0x47)
	/scratch/iota-core/pkg/protocol/engine/notarization/slotnotarization/manager.go:108 +0x45
github.com/iotaledger/iota-core/components/protocol.provide.func1.NewProvider.func14.1.1(0xc0019e7ed8?)
	/scratch/iota-core/pkg/protocol/engine/notarization/slotnotarization/manager.go:72 +0x131
github.com/iotaledger/hive.go/runtime/event.(*Event1[...]).Trigger.func1.1()
	/go/pkg/mod/github.com/iotaledger/hive.go/runtime@v0.0.0-20231128121006-331a9e522dfe/event/events.go:86 +0x1f
github.com/iotaledger/hive.go/runtime/workerpool.(*Task).run(0xc001b20f00)
	/go/pkg/mod/github.com/iotaledger/hive.go/runtime@v0.0.0-20231128121006-331a9e522dfe/workerpool/task.go:48 +0x72
github.com/iotaledger/hive.go/runtime/workerpool.(*WorkerPool).workerReadLoop(0xc0002a4b60)
	/go/pkg/mod/github.com/iotaledger/hive.go/runtime@v0.0.0-20231128121006-331a9e522dfe/workerpool/workerpool.go:190 +0x25
github.com/iotaledger/hive.go/runtime/workerpool.(*WorkerPool).worker(0xc0002a4b60)
	/go/pkg/mod/github.com/iotaledger/hive.go/runtime@v0.0.0-20231128121006-331a9e522dfe/workerpool/workerpool.go:170 +0x50
created by github.com/iotaledger/hive.go/runtime/workerpool.(*WorkerPool).startWorkers in goroutine 1
	/go/pkg/mod/github.com/iotaledger/hive.go/runtime@v0.0.0-20231128121006-331a9e522dfe/workerpool/workerpool.go:162 +0x25

The PoolCoefficientExponent in the RewardParameters should be at most 11 in size and we should add this as a sanity check. Currently it is set to 31 for some unknown reason which caused the overflow.


Wishlist: easier way to handle conditions and other items where special instructions are needed how to fill them in

In the experimental design section, and possibly in some others, if user is filling in information about conditions (e.g., number of trials per condition), they are expected to input values for each condition separated by semicolon and a space and given in the same order as the names of the conditions are listed. If there are multiple groups of participants, they list trial counts for all conditions for one group, and then for the next one - following the ordering of groups as you specified them earlier.
While it works for now, as @Remi-Gau has pointed out, it is complicated and a more user-friendly way could be found in the future.

Other examples of similar issues: lists with semicolon and a space, subdivided time windows where there are both colons and semicolons


Another Print Edit

Hide all(?) huge jsons.
Recommended some prints.

Im going to wait until I can work on this again.
I will also be re-writing the styling for it - so each little log will look different! :)

Ok :smile:


Fix ALTER TABLE ... RENAME syntax

Index Issue: pingcap/tidb#11486
These are bad (incompatible) SQL cases:
ALTER TABLE t_n RENAME = t_n
ALTER TABLE t_n RENAME TO t_n
ALTER TABLE t_n RENAME AS t_n

Claim this subtask based on the comments below this issue.

Let me fix it


Example project does not compile (v2.3.0 vs v2.6.1 reference mixup)

The linked example project linked in section #clone-the-sample-app does not compile because nuget downloads MongoDB.* 2.6.1, but csproj is out of sync and searches the dlls from v2.3.0 nuget folder, which does not exist.
See: https://stackoverflow.com/a/55393180/331325

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 898d5139-909f-dcd9-8f25-4d8b2aafd708
Version Independent ID: 50e12e3d-de5d-0ad2-be8f-4c28a3f4ae2e
Content: Build a web app using Azure Cosmos DB's API for MongoDB and .NET SDK
Content Source: articles/cosmos-db/create-mongodb-dotnet.md
Service: cosmos-db
GitHub Login: @rimman
Microsoft Alias: rimman

@ImrePyhvel Thanks for your feedback. This is an issue in the csproj file. For which pull request has already been raised.
You can refer the pull request to check the ETA for this fix.
https://github.com/Azure-Samples/azure-cosmos-db-mongodb-dotnet-getting-started/pull/8

@ImrePyhvel I hope your concern has been resolved.
We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


No permission to migrate volume, only root admin can migrate a volume

ISSUE TYPE

Bug Report

COMPONENT NAME

ALL

CLOUDSTACK VERSION

<IP_ADDRESS>

CONFIGURATION

N/A
OS / ENVIRONMENT

CentOS 7
SUMMARY

When a non-root user try to change the compute offering on a VM he faces the error: " No permission to migrate volume, only root admin can migrate a volume ".
STEPS TO REPRODUCE

Change the compute offering of a powered-off VM

EXPECTED RESULTS

The compute offering is changed.

ACTUAL RESULTS

Non-root user faces error " No permission to migrate volume, only root admin can migrate a volume "

@cdfgallo Thanks for reporting the issue.
The behaviour here needs to be discussed. My view, https://github.com/apache/cloudstack/pull/6704#issuecomment-1238056686
cc @harikrishna-patnala @NuxRo @alexandremattioli

I agree with your comment @shwstppr, usually migrate operations are not given to users, if at all user hits these kind of issues, they may need to contact admin. Others please chime in.

I agree on the migration part, but a normal user should be allowed to change the compute offering on a VM if this doesn't lead to a volume migration.

Hi my name is Aarushi Soni . I want to contribute to this issue . Is this issue still open ? I am first time contributor . Please guide me through this process.

@cdfgallo does it work for you if you try changing the offering of the VM but untick the automatic migration option that says "Auto migrate volume to another storage pool if required":

@rohityadavcloud nope, unfortunately this does not work too. Still receive same error from the UI.

This is a major bug for our company and is preventing us from upgrading to 4.17.1. If we were to upgrade from 4.16.1, we would be inundated with customer support requests to do what should be a basic operation- increase or decrease CPU/RAM.
@rohityadavcloud, I can also confirm that unticking 'auto migrate' does not help. Logging in as a root admin is the only way to scale successfully in our lab environment.

Thanks @mik-allen for reporting, I'm able to consistently reproduce this as normal user account in a KVM env (I think this is hypervisor agnostic):

Deploy a VM using a small offering and stop it.

Scale the VM with the option to auto-migrate:

The operation fails with permission to migrate issue:

This happens even when the auto-migration option in ScaleVM is selected.

The auto-migrate feature was introduced in case there's a service offering that has storage tags and offers something specific to the offering.

@rohityadavcloud @weizhouapache @shwstppr @harikrishna-patnala
Any update on this? Is it in progress?
I'm willing to contribute if you need help.

@soreana are you working on this?

@DaanHoogland Not yet. I was waiting for the @shwstppr @harikrishna-patnala reply.

I know @harikrishna-patnala is busy on https://github.com/apache/cloudstack/pull/6704 so I think he is in the lead right now.

@DaanHoogland Cool 👍
I will keep an eye on the https://github.com/apache/cloudstack/pull/6704 then :)

any update on this @shwstppr @harikrishna-patnala @DaanHoogland ?

LGTM based on manual testing.

Fixed in https://github.com/apache/cloudstack/pull/6704


How can I update historical build artifacts (artifactlocation, downloadUrl) following a server move?

My build artifacts are being moved from one fileshare \ULYSSES\DevOps to a new fileshare \archives\DevOps.
While I was able to update the build definition to make subsequent builds go to this new location, my already completed builds are still holding on to the old drop location.
Is there a way I can update these through Rest API?
Agent version and platform
Version of your agent? 1.104.0
OS of the machine running the agent? Windows
VSTS type and version
On-Prem TFS
If On-Prem TFS, which release, 2017 Update 1 RTM?
What's not working?
Rest API call to get build artifacts still shows old location.
{"count":2,"value":[{"id":177,"name":"ManageAccountingService_20170622.1","resource":{"type":"filepath","data":"\\ulysses\DevOps\ManageAccountingService","properties":{"artifactlocation":"\\ULYSSES\DevOps\ManageAccountingService"},"url":"http://tfs-prod-01:8080/tfs/TCDRS/da3aa702-f996-40c1-987a-4ff44bbe01b0/_apis/build/builds/2174/artifacts?artifactName=ManageAccountingService_20170622.1","downloadUrl":"file://ulysses/DevOps/ManageAccountingService"}},{"id":179,"name":"build.SourceLabel","resource":{"type":"TfvcLabel","data":"ManageAccountingService_20170622.1","url":"http://tfs-prod-01:8080/tfs/TCDRS/da3aa702-f996-40c1-987a-4ff44bbe01b0/_apis/build/builds/2174/artifacts?artifactName=build.SourceLabel","downloadUrl":"http://tfs-prod-01:8080/tfs/TCDRS/_apis/tfvc/items/ManageAccountingService_20170622.1?api-version=1.0&$format=zip&fileName=build.SourceLabel"}}]}
There are 2 of them because I have a "Debug" and a "Release" configuration built.

@mayeager22 I don't think we have that REST Api at this point. You can use https://visualstudio.uservoice.com/forums/330519-team-services to provide feedback for the service. I am going to close this issue, since it's not scope to a 2.x vsts-agent issue.


[SPARK-45479][INFRA] Uses the default Python versions in the scheduled builds in other branches

What changes were proposed in this pull request?
This PR explicitly sets PYTHON_TO_TEST to an empty string for other branches so they use their default Python versions.
https://github.com/apache/spark/pull/43209 added a new option to the testing script but that option does not exist in other branches so it fails.
Why are the changes needed?
To recover the build (see https://github.com/apache/spark/actions/workflows/build_branch33.yml, https://github.com/apache/spark/actions/workflows/build_branch34.yml and https://github.com/apache/spark/actions/workflows/build_branch35.yml)
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
After merging this, I will monitor the build. I locally tested the changes too.
Was this patch authored or co-authored using generative AI tooling?
No.

Merged to master.


Class signedness

On a class-datatype (struct/enum) port, does the signedness come from the struct/enum definition?
Does it make sense to add a new member to SvPort like pub class_identifier: Option<String>? Then some future work can analyse struct/enum/class definitions, so a reader could lookup the class definition by the identifier to find all the port info.

Up to know once datatype = class since no signedness was found in Ansiportdeclaration, it was set by default to unsigned which I believe does not apply in our case.
Yes on the upcoming plans I have also included adding an SvClass? struct that will contain any struct/enum found overall from the parsing and prior  to returning the SvData if any match that exists between a class_identifier in SvPort and the identifier found in SvClass will lead to the data of SvClass being transferred in SvPort.

that will lead to the data of SvClass being transferred in SvPort

I reckon that transferring all of the class information to SvPort will be a bit too complex, especially when namespaces are used. Probably simpler to just add the identifier to SvPort, and have a list of enums in something like SvModuleDeclaration.enums (similar for classes/structs).

Of course, I'm merging this branch with the latest version of upstream/master and then I will add any necessary implementation and update the PR.

Fixed.

Fixing the conflict.


Update artemis-jms-client-all to 2.31.1

About this PR
📦 Updates org.apache.activemq:artemis-jms-client-all from 2.19.1 to 2.31.1
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.apache.activemq", artifactId = "artemis-jms-client-all" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.apache.activemq", artifactId = "artemis-jms-client-all" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #420.

Superseded by #432.


Allow all configurations to be effective in workspace settings.json.

Main issue: Some settings in the user settings.json won't work if placed in the workspace settings.json. Some of these are:
update.mode
extensions.autoUpdate
extensions.autoCheckUpdates
telemetry.telemetryLevel

Problems with this:

In a completely sandboxed environment, or in a strictly proxied environment, extranet actions should be completely suppressed. (Current issue I am trying to solve.)
Although it makes sense to handle these as user settings, it does not make sense to disallow specifying/overwriting them in the workspace settings.json.
--user-data-dir, in its current form, is not readily versionable. There are a mixture of various content aside of configuration JSON files there.

Ideal setup:

The project is self-contained, including user settings.
The project can be versioned in Git without scripts to back up/change settings external to the project folder.
A git clone should restore everything that is required for a successful build.

Suggestions:

Either allow specifying/overwriting the user settings in the workspace settings.json file or
Support a userSettings.json file in the workspace so that user settings could be stored there (maybe also overwriting some global user settings.json values.

Either allow specifying/overwriting the user settings in the workspace settings.json file

This cannot be supported

Support a userSettings.json file in the workspace so that user settings could be stored there (maybe also overwriting some global user settings.json values.

You can use symlinks - symlink the settings.json file from your user settings to point to the one from workspace settings.


Timeline: Loading Indicator

Tasks

[ ] A loading inicator should be shown when date is changed and data is loaded
[ ] Use loading indictor in e2e tests to know when loading is finished

Use case
Timeline Single Date Selection
Related Pull request
#1042

Thank you for creating the issue! How should the indication look like? Is it easy to change the cursor? A waiting-cursor would be nice.
As long a date is not selected, it should not be white font with black background.


DbaServer Rename

The name never sat right with me. I'd like to change a few of these

ServerAudit -> Audit and then make a DbAudit <-- for sure
ServerAuditSpecificiation -> Audit and then make a DbAuditSpecificiation <-- for sure
ServerTrigger -> Trigger. DbTrigger already exists <-- questionable
ServerRole -> Role, then make a DbRole
ServerRoleMember -> RoleMember. DbRoleMember already exists

The Names reflects pretty good with what the same feature is called on the Sql Server

i'd still like to go forward but it turns out there are breaking changes so going to put this on hold till closer to 1.0

Isn't there an inherent difference between ServerTrigger & ServerRole and DbTrigger & DbRole i.e. the former being server based and the latter being database based?
To distinguish the difference, you'd need something like Server in there, or maybe Srv for brevity.
I was going to suggest adding a switch parameter -Server if you want to do something server based but I'd say that's too hidden away so wouldn't be discover-able enough for PowerShell.

yeah, they are there for legit reasons. i guess im just iffy on the word Server? Should it be Instance? But they are called Server in SMO i think

and thank you!

I believe that whatever you pick will be the right choice. So I can live with either Server or Instance

I prefer Instance but can live with either :)

thank you all, i think im leaning instance since server never sat right ❤

To ship is to choose :}

k going instance, doing this now


count drop down doesnt open

Say a user clicks on the count drop down a menu pops up and then user clicks else where on the page the menu disappears. When a user re clicks on the count drop down the drop down doesnt show up. Clicking another time brings up the menu. I see that this issue exists even on the examples page.

@meghnaraok yes,  it's a known issue currently.

Duplicate issues like this should be closed in favor of one which is most verbal and with most details. like #1570

Fixed on v4.1.1, now the sizePerPage dropdown work well. Thanks


OAuth2 token revocation

This is a list of missing functionality to conform to https://tools.ietf.org/html/rfc6749

(must but irrelevant for Membrane until refresh tokens are implemented) support for revocation of refresh tokens
(done) (must) error response when request is bad, e.g. missing token -> see https://tools.ietf.org/html/rfc7009#section-2.2.1 and https://tools.ietf.org/html/rfc6749#section-5.2
(optional) cross-origin resource support
(optional) JSONP support
(done) (must) (client)add client_id to revocation request and (server) also check if token was given to client_id

Will do the "must" points anytime soon

After testing: all (must) entries, except for the first one, should be done. The first one is only relevant if we implement the (optional) refresh token.


[DO NOT MERGE] Bh images release

Guidance updates for release of inline images feature - only release when new features are live.
https://trello.com/c/Ub7JHdhg/637-feature-release-master-card

@benhazell is it worth hinting that users can do this via a new 'widget' on the markdown toolbar? It might be confusing to some if they are trying to relate with the existing flow for lead images.

Not here - this is just an update to say it is now available.
We're aiming to make it intuitive to do it without guidance. I need to review the build, but if it isn't it'll be more useful to see people get stuck and improve the design than to provide lots of notes.

This has gone out with the release


Added Docker file and script for generating aarch64 sysroots

Status
DEVELOPMENT
Description
This PR includes a script to generate an aarch64 sysroot (that includes all the Autoware dependencies for Kinetic) that can be used for crosscompiling Autoware.
Todos

[ ] Tests
[ ] Documentation

Steps to Test or Reproduce
cd docker/generic
./build_sysroot.sh

This should generate tarball named autoware-kinetic-sysroot-aarch64.tar in the current directory, which contains all the Autoware dependencies for aarch64

I didn't add the qemu-aarch64-static executable, but I can do that if necessary. I used the one that comes with https://packages.ubuntu.com/bionic/qemu-user-static

I've changed the Docker file so that qemu-aarch64-static is copied from another Docker image instead of embedding it in the source tree. This makes the process of building a sysroot totally self-contained.

Closing in favor of #1375


Getting python calfun with fvec

This branch is a very slight modification of the files in https://github.com/scipy/scipy/tree/main/benchmarks/benchmarks/cutest.
The (nonformatting) changes is the introduction of the vecout argument to calfun to allow fvec to be returned to the optimization algorithm. (The default has vecout=False). This was in the commit: https://github.com/POptUS/BenDFO/commit/8bb09f8aa7248046da3451f9af9dac30aa6a600e
@sarafridov, do you have any opinions about such a modification?

This modification looks fine to me. It looks like the test just makes sure that all the problems run properly, but doesn't check any properties of the returned fvecs; presumably this is by design? I also don't see the file dfo.txt anywhere, but maybe that is in a separate commit?

Thank you @sarafridov.
For now, I was just making sure that the fvec was set up in an acceptable way. The dfo.dat file is in the BenDFO repo here: https://github.com/POptUS/BenDFO/blob/main/data/dfo.dat

Actually one other comment is that right now it looks like the fvec is returned before the probtype is considered; ie it's always noiseless. For some of the probtypes there isn't an obvious way to apply it to fvec, but for some there is. If you always want a noiseless vector then this is fine, but maybe in the documentation it's good to mention that if fvec is returned it will be the same regardless of probtype.

Thank you for pointing this out. I have added a note in calfun

@wildsm Any additional edits needed?

@wildsm The translation to python is complete. Details for a verification test are in the top of compare_matlab_and_python.m

When I run locally, I get these outputs:
[jlarson@x1carbon BenDFO] matlab

                                                                                < M A T L A B (R) >
                                                                          Copyright 1984-2021 The MathWorks, Inc.
                                                                     R2021b Update 2 (<IP_ADDRESS>7725) 64-bit (glnxa64)
                                                                                December 14, 2021

For online documentation, see https://www.mathworks.com/support
For product information, visit www.mathworks.com.

>> compare_matlab_and_python
   4.3063e-16   1.8769e-16   1.8758e-16

   8.8818e-16   8.8818e-16   8.8818e-16

   3.8286e-17   3.8286e-17   3.8286e-17

   8.9738e-16   5.7538e-16   5.7538e-16

Those are small enough values, right?

   4.3063e-16   1.8769e-16   1.8758e-16
   1.1369e-13   1.1369e-13   1.1369e-13
   5.0176e-17   5.0176e-17   5.0176e-17
   7.9372e-16   5.7538e-16   5.7538e-16

Well out2 is absolute error, so it's not surprising that it's a possibly larger error. Can you make it a relative error?

@jmlarson1 Please review the recent changes closely.
Among other things there were missing absolute values... meaning if P was smaller than M it would naturally satisfy the asserts even for a 0.0 tolerance.
On my machine, I obtain the following:
(:,:,1) =

   3.9475e-16   2.1965e-16   3.4805e-14

(:,:,2) =

   4.8446e-16   3.6767e-16   3.6772e-16

(:,:,3) =

   4.3063e-16   7.0374e-16   7.0385e-16

(:,:,1) =

   6.8715e-15   6.8715e-15   6.8715e-15

(:,:,2) =

   1.5781e-15   1.5781e-15   1.5781e-15

(:,:,3) =

   2.1208e-15   2.1208e-15   2.1208e-15

(:,:,1) =

   1.6342e-16   1.6342e-16   1.6342e-16

(:,:,2) =

   6.3292e-17   6.3292e-17   6.3292e-17

(:,:,3) =

   5.0176e-17   5.0176e-17   5.0176e-17

(:,:,1) =

   7.9372e-16   9.1351e-16   9.1351e-16

(:,:,2) =

   7.9372e-16   1.1187e-15   1.1187e-15

(:,:,3) =

   7.9372e-16   5.7538e-16   5.7538e-16

You are right that two of the cases were missing abs mappings.
On my machine, I needed to increase one of the tolerances for one of the cases. With those changes, I get the attached output:
output_10_31_23.txt

@jmlarson1 see the constants.py question above

@jmlarson1 see the constants.py question above

@wildsm I'm sorry, I'm not seeing that question. Can you requote it?

@jmlarson1 Is there a reason why constants.py is split out as a separate file?
In reviewing differences between m/ and py/ this one stands out given that g_dfovec_1d is standalone in each case.

I thought it improved readability but I can include it in the file so it's is standalone in both .m and .py versions. I've made that change in 0114161 so dfovec.py is now standalone

Will not delete branch until dependencies elsewhere updated.


[New architecture] There was a missing chat in chats with empty space, not sure how to reproduce it was random and gone after reopening the app

If you haven't already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

This issue is related to the ongoing new architecture adoption. It was reported on the build with new architecture enabled on the relevant PR.

Version Number: 1.4.42-1
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777 here
Slack conversation:
Action Performed:
Break down in numbered steps
Expected Result:
All chats are visible
Actual Result:
Some chats are missing with blank space
Workaround:
Known issue.
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Available in the linked comment.

View all open jobs on GitHub

Will be tested once the PR is deployed.


tighten firewall on nat server

During the bug-fixing in #19, we created an iptables setup that is more focused on enabling things than on protecting. We should audit this and change it where required.

As this is no production setup, we can leave it like that for now.
Once T2 or its templates advance to being a production-ready setup, we'll have to audit its security anyway.


Latch init raises error when using the R template

Describe the bug
When using latch init and specifying --template r the command executes but raises an error: Unable to initialize test-r: [Errno 2] No such file or directory: '/home/jvfe/dev/latchbio/.venv/lib/python3.10/site-packages/latch_cli/services/init/example_r/imports.R'. This doesn't seem to affect the template itself, since the directory is created and the file imports.R doesn't seem necessary to registering the workflow, but the error can still mislead users into thinking something is wrong.
To Reproduce
Steps to reproduce the behavior:

Run latch init --template r test-r
Error is raised: Unable to initialize test-r: [Errno 2] No such file or directory: '.../latch_cli/services/init/example_r/imports.R'
Directory is still created:

$ tree test-r
test-r
├── Dockerfile
├── version
└── wf
    └── __init__.py

1 directory, 3 files

Expected behavior
I expect no errors to be raised when running latch init --template r
Desktop (please complete the following information):

OS: Manjaro Linux
Latch SDK Version: v2.1.2

I believe this was fixed by 240e0bc2. In Latch version 2.5.1 the error is no longer raised.


fix: Fixing unit tests to work in Python 3

Issue #, if available:
No issue in this repo but related to https://github.com/awslabs/aws-sam-cli/issues/387
Description of changes:
This change is complimentary to the earlier PR (#428) to make unit tests run in Python 3. There is a lot of interesting nuances in this PR that might not be obvious at start.

Translator computes a SHA hash of Swagger dictionary for API Gateway resources. This hash is appended to API Gateway Deployment resource's LogicalID to trigger a new APIGW deployment when Swagger changes. This hash is computed by stringifying swagger dictionary using str(swagger_dict). The string value changes between Python2 and Python3 because of difference between the underlying dictionary implementation in the two versions. Hence the computed hash also changes. In this PR, we update the test expectation by re-computing the SHA within the test for Python3 only.

The test used deepsort to sort the output CFN template dictionary and compare against the expectation. In Python2, this worked because you could sort a list with complex values just based on the data type of the value. This behavior is not there in Python3. Because the lists get sorted, they are by definition compared as an unordered list. This is wrong because lists like Fn::Sub: [] are ordered. To keep the PR focused on py3, we choose to ignore this problem. Instead, we used a custom comparator to mimic Py2's list sorting behavior for Py3.

Updated Tox and Travis to run tests against both Python versions. All subsequent PRs must support both versions of Python before they can be merged.

Tox was setting PYTHONHASHSEED to random value. In Py2, this caused the order of elements within a dictionary to change resulting in APIGW Deployment Hash to change between every test run. Changed this to a fixed value in .tox.ini file

NOTE (only if you run Translator locally)
SAM Translator will work without any issues in Python 3. But if you already had a CloudFormation stack created using SAM Translator Py2, then updating your stack using Py3 translator will re-deploy your API Gateway endpoints. This is due to the first issue described above. If you never ran SAM Translator locally and always relied on CloudFormation, you don't have to worry about this problem.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pushed a change that addresses Eric's feedback

This is a blocker to enable "good" SAM template linting: https://github.com/awslabs/cfn-python-lint/issues/81


#34, #110 - suppress Intellisense in strings and comments

Basic tokenizer based on RTVS (comments and strings), can be extended as needed
Supporting classes
Tests

Tough to review in the phone, however I failed to notice any test for this feature. I.e. disable intellisense when inside a string. I think we'll need that.
Over all 👍

Yes Will do

Do we have an issue(s) tracking this change?

#34, #110

And with that, @MikhailArkhipov is now the 19th most prolific contributor to the extension! 😄


RouteValueDictionary support

Your methods like RedirectToActionPermanent, Url.Action, etc. all take an optional object for route values.
This works most of the time.
However, if you pass in an actual ``RouteValueDictonary' to the methods they do not work.  The standard MVC library code that takes this kind of value does work.
Url.Action<SomeController>(c=>c.SomeMethod(), someRouteValueDictionary) should work.
You could create overloads that accept the RouteValueDictionary and act appropriately:
        public static string Action<TController>(this UrlHelper url, Expression<Action<TController>> action, RouteValueDictionary routeValues) where TController : Controller
        {
            RouteInformation routeInformation = FromExpression<TController>(action, routeValues);
            return url.Action(routeInformation.ActionName, routeInformation.ControllerName, routeInformation.RouteValueDictionary);
        }

        public static string Action<TController>(this UrlHelper url, Expression<Func<TController, Task>> action, RouteValueDictionary routeValues) where TController : Controller
        {
            RouteInformation routeInformation = FromExpression<TController>(action, routeValues);
            return url.Action(routeInformation.ActionName, routeInformation.ControllerName, routeInformation.RouteValueDictionary);
        }

        public static RouteInformation FromExpression<TController>(LambdaExpression action, RouteValueDictionary routeValueDictionary)
                   where TController : Controller
        {
            string actionName = action.GetActionName();

            var controllerType = typeof(TController);
            string controllerName = controllerType.GetControllerName();

            routeValueDictionary.ProcessParameters(action);
            routeValueDictionary.ProcessArea(controllerType);
            var routeInformation = new RouteInformation(actionName, controllerName, routeValueDictionary);
            return routeInformation;
        }

That would be a lot of overloads.
Or you could create a shared routine that creates the initial route value dictionary correctly, something like
private RouteValueDictionary GetDictionaryFromObject( object routeValues){
   if (routeValues is RouteValueDictionary)
     return (RouteValueDictionary)routeValues;
  return new RouteValueDictionary(routeValues);

Optionally, Microsoft evidently uses TypeHelper.ObjectToDictionary() so potentially you could use that too?

@ivaylokenov Any thoughts on the above?
Also, there are no tests in this project.  Would you object to adding Xunit or something with a few tests?

@waynebrantley The above methods can be added to the library. I will have some spare time this weekend and will take a look. As for tests - I believe there are necessary, will add them too. If you are willing to help, I accept all kinds of PR. 👍

Well, I created tests based on Nunit3 to validate my performance pull request.  However, I did not submit a pull request of that, because was not sure you would accept it.  And didn't know if Nunit was what you would use, etc.   (This is why my PR had some compile issues, I copied and pasted the code into github, due to all the other project changes I made)

@waynebrantley NUnit is fine. You can add it, if you decide. I am using it @ MyTested.WebApi 👍


Does Skywalking support print spanid and parent Id in log4j2

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

Does skywalking which version is 8.4 support getting spanid and parentid in log?
Thanks a lot.

Bug

Which version of SkyWalking, OS, and JRE?

skywalking version 8.4

Which company or project?

What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.

Requirement or improvement

Please describe your requirements or improvement suggestions.

No, it's tagged in milestone 8.6.0 #6795


Support GQL querying for new ZkApp Transactions

Add an new GQL endpoint to for querying for zkapp transactions

Is blocked by: https://github.com/Granola-Team/mina-indexer/issues/1255


feat: add collapsible animation

fixed #437 according to registry strategy

@valentinpolitov This is intended. The idea is to make it behave differently from accordion.
See also https://www.radix-ui.com/primitives/docs/components/collapsible


[WINDOWS 7][AMD][D3D9] Tom Clancy's Rainbow Six: Lockdown; Graphical Artifacts + Shadow Issues

Software information

Name: Tom Clancy's Rainbow Six: Lockdown
Settings: All Max (i can provide a Screenshot, but it's in German. i haven't found a way to change the menu language)

System information

GPU: AMD Radeon RX 570
Driver: 2.0.179
OS: Windows 7

Apitrace file(s)

https://mega.nz/file/jMkwTZrb#JQwazE_ebyetlcR-M7nS1tc-iiiufFHU0tZfj0T7JRs

Log files

d3d9.log: windows_7_lockdown_d3d9.log

Note
Happens on Linux with Proton too. See: https://github.com/ValveSoftware/Proton/issues/2862
Screenshots

Probably needs feedback loop ext

This also affects Linux with amdgpu and mesa, but the glitched line in the middle of the screen was fixed in recent versions, so only the shadows issue remains

This also affects Linux with amdgpu and mesa, but the glitched line in the middle of the screen was fixed in recent versions, so only the shadows issue remains

please be a bit more specific about the mesa version you use.

please be a bit more specific about the mesa version you use.

Mesa 21.0.2
Sorry, I should've been more specific, it's working with more recent wine / dxvk (not sure) using the GE fork
There're more details in my Proton Issue that you linked

Just noting that i also reproduce this on my R9 380 and mesa.
Both the line down the middle and shadow issue

Seems fixed in 2.3


wasmparser reporting illegal opcode

I have a recently compiled (rustc/cargo) wasm file, that when parsing it using wasmparser crate ("0.107.0" from crates.io) reports:
illegal opcode: 0xa (at offset 0xd8)

I think I saw this error previously in one of the non-maintained C++ wasm optimization tools, and when I searched it turned out it was a newer opcode that was not in the original spec and the tool hadn't been updated to support it.
wasm-objdump and other tools can process it without problems.
But, I expected wasmparser to be up to date.
Am I misunderstanding something?
Do I need a feature or flag or some other change in order to process such a file correctly?
(I could attach the file but its > 100K) and not sure that would be appreciated.

Thanks for the report! If you could upload the wasm file that'd be appreciated, or gist the wasm-tools dump foo.wasm report would probably work too

compare_switch_wasm.txt
GH doesn't accept .wasm files, so I renamed to .txt and uploaded.
here is the cargo projection  I use to compile this (nothing of interest IMO):
[package]
name = "compare_switch"
version.workspace = true
authors.workspace = true
edition.workspace = true (is 2021)

[lib]
name = "compare_switch"
crate-type = ["cdylib"]
path = "compare_switch.rs"

[dependencies]
flowcore = { workspace = true }
flowmacro = { workspace = true }
serde_json = { workspace = true, default-features = false }

I think it was compiled with:
cargo 1.72.0-nightly (f7b95e316 2023-05-30) and
rustc 1.72.0-nightly (d59363ad0 2023-06-01)

Hm can you share the code that's processing this wasm file? The wasm file passes wasm-tools validate locally for me which means wasmparser is parsing and validating the file correctly. This file looks normal like it shouldn't require any extra flags or anything like that.
One odd thing is that the offset in your error message, 0xd8, is an offset into the function section which shouldn't produce the error illegal opcode since that only comes about from reading the code section. That may mean that the code using wasmparser may have a bug in it.

Ah yes that's not how a wasm file is parsed, the BinaryReader gives really low-level access so what's happening here is you're interpreting the entire wasm file as a list of bytecode, which isn't correct since it has much more structure than that. You'll want to start at the top-level with a wasmparser::Parser

Aha. So I guess you need to parse down and find function bodies and then use the BinaryReader on that, and not the whole module.
If you know of any good readable code or examples or parsing modules, that would be much appreciated - I will continue to try anyway.
Thanks.
I'll close the issue.


Android app crash on launch for OS 8 and above after Google Update

After Google update release and updated react-native-device-info. The app is running on mobile os 7 and below.
Mobile OS 8 crashes on launch after react-native run-android,
error message:
A/libc: Fatal signal 7 (SIGBUS), code 1, fault addr 0x37bf3a90253f5 in tid 6474 (mqt_js)
Mobile OS 9 unable to load script,
error message:
E/unknown:ReactNative: Exception in native call
java.lang.RuntimeException: Unable to load script. Make sure you're either running a Metro server (run 'react-native start') or that your bundle 'index.android.bundle' is packaged correctly for release.
"react": "^16.8.3",
"react-native": "^0.59.9",
"react-native-device-info": "^2.1.2",

Steps To Reproduce

Describe what you expected to happen:
Snack, code example, or link to a repository:

I got the same error and resolved it by setting:
targetSdkVersion = 27
in project level build.gradle. Then perform a gradle clean and try to run again.

I'm getting same error


Ticket purchase summary does not list ticket numbers

The page says to take note of ticket numbers, but doesn't include any in the listing:

For 2020, we also need to remove the line about the registration desk.

Even worse, the tickets don't even show up in the user account panel:

Turns out, the orders are not marked as "complete":

Tested cart again with the change on the live site: works fine now.


⚠ Turnos 24x7 has degraded performance

In 0ff1021, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 937 ms

Resolved: Turnos 24x7 performance has improved in f04e898.


files not found "graph.pb.h" and "image_ops.h"

The 2 files below are included in main.cc of label image example, but i can't find these 2 .h files in the relevant ops and framework folders. So we can remove them out directly?
include "tensorflow/cc/ops/image_ops.h"
include "tensorflow/core/framework/graph.pb.h"
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/examples/label_image/main.cc#L38
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/examples/label_image/main.cc#L40

These files are generated when you use bazel build to build the example.  The files are placed in bazel-genfiles.
Hope that helps.

Hi
I am compiling a C++ file using the following command:
g++ -std=c++11 validation.cpp -L./ -ltensorflow_cc -o validation -I/home/hadoop/git/tensorflow-r1.8/  -I/home/hadoop/git/eigen3/ -I/home/hadoop/git/tensorflow-r1.8/bazel-genfiles/
To come to this step:

First I built the libtensorflow_cc.so using bazel build //tensorflow:libtensorflow_cc.so
Then I copied the .so file to the project directory:
cp bazel-bin/tensorflow/libtensorflow_cc.so ~/projects/tf-vad-validation/.
Included the cloned folder of branch r1.8 and the bazel-genfiles for including some missing header files like const_op.h
Cloned and included the eigen3 folder because the compiler went into deep nested loop while importing unsupported/Eigen/CXX11/Tensor

After this I got the error:
bazel-genfiles/tensorflow/core/lib/core/error_codes.pb.h:9:42: fatal error: google/protobuf/stubs/common.h: No such file or directory
How to deal with this error?


reverse-string: Implement Benchmark Test

The current version of the tests for the reverse-string exercise don't include benchmark tests.
Given the numerous different ways a solution to this exercise could be implemented, I felt like a benchmark test would be appropriate here.
Link to tests: reverse_string_test.go

I'd be happy to implement this and raise a pull request if this is worthwhile.
Before I do so, I'm off to re-read the contributing guidelines.

@billglover that would be awesome.

On it!


Adding theme/material

Connected to vaadin/vaadin-material-styles#49

This change is

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable