Memory leak

tree.delete_node has memory leak when it has children...
When I delete a tree node, I get delete event by connecting to delete_node.jstree.
However, when this node has children, the children doesn't got deleted even though those children disappear from the tree (because the parent got deleted).
I need those delete events, because I have plot associated with each node, when a node is deleted, I delete the plot. At this moment, only the parent emit the delete event.
I add following code to work around the problem, but the code should be in jstree.
Great work! Thank you!

function deleteNodeList( tree, nodeList )
{
  while( nodeList && nodeList.length > 0 ) {
    deleteNodeTree( tree, nodeList.shift() );
  }

}

function deleteNodeTree( tree, nodeId )
{
  var node = tree.get_node( nodeId );

  // traverse to delete the children all the way to leaf
  deleteNodeList( tree, node.children );

  tree.delete_node( node );
}

I do not agree about the event - the event simply means that a node was deleted - if you need to do some processing on the node's children - that should be in your own code. I do not believe there should be a separate event for each child. If you do need that - you can easily create a plugin that will trigger such events, but I will not add this to the core.


Add C implementation for @stdlib/math/base/special/sqrt1pm1

Resolves #773.
Checklist

[x] update readme.md
[x] include.gypi
[x] binding.gyp
[x] include/stdlib/math/base/special/
[x] src
[x] manifest.json
[x] lib
[x] examples
[x] benchmark
[x] test

@kgryte

All tests and benchmarks cleared, this PR can have a review.

Thanks, done :)

@Pranavchiku Looks like a temporary file was added to this PR.

Ahh yes, so sorry for that! I am removing it.


Yungez issue86

fix issue #86, #88

@yungez,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@ZhijunZhao @aovechki  @zhzy0077

Codecov Report

Merging #94 into master will decrease coverage by 6.46%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #94      +/-   ##
=========================================
- Coverage   52.06%   45.6%   -6.47%
=========================================
  Files          35      35
  Lines         557     557
  Branches       47      47
=========================================
- Hits          290     254      -36
- Misses        244     281      +37
+ Partials       23      22       -1

Impacted Files
Coverage Δ

.../DocumentDbRepositoriesAutoConfigureRegistrar.java
80% <ø> (ø)

...entdb/DocumentDbRepositoriesAutoConfiguration.java
100% <ø> (ø)

...repository/support/SimpleDocumentDbRepository.java
30.76% <ø> (-15.39%)
:arrow_down:

...sitory/config/DocumentDbRepositoriesRegistrar.java
0% <0%> (-100%)
:arrow_down:

...epository/support/DocumentDbRepositoryFactory.java
0% <0%> (-100%)
:arrow_down:

...ig/DocumentDbRepositoryConfigurationExtension.java
15.38% <0%> (-69.24%)
:arrow_down:

...itory/support/DocumentDbRepositoryFactoryBean.java
0% <0%> (-66.67%)
:arrow_down:

...epository/support/DocumentDbEntityInformation.java
0% <0%> (-50%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86aa124...84f17b3. Read the comment docs.

I think you should put a more descriptive PR title.


the page does not show anything just a blank page

when I load the page it just give an empty page

I have the same problem just a blank page!!! in my console.log I see the following error:
app.js:1 ReferenceError: messages is not defined
at mn.eval (eval at Ea (app.js:1), :3:396)
at mn.dn._render (app.js:1)
at mn. (app.js:1)
at Ie.get (app.js:1)
at new Ie (app.js:1)
at mn.$mount (app.js:1)
at mn.$mount (app.js:1)
at mn._init (app.js:1)
at new mn (app.js:1)
at Object. (app.js:1)

Hi in the layout/ app.blade.php, replace the CSS and JS link

and

Hello, I encountered the same problem as @rextech03. There's nothing on the page.
I tried this whole tutorial in Laravel 5.8. There are no errors anywhere.
Where could I find any clues about this problem?

I think it is not compatible with your php version
Sent from my iPhone

On Apr 1, 2019, at 10:16, Jiwon<EMAIL_ADDRESS>wrote:
Hello, I encountered the same problem as @rextech03. There's nothing on the page.
I tried this whole tutorial in Laravel 5.8. There are no errors anywhere.
Where could I find any clues about this problem?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

PHP version?? Do you mean this project needs a lower version of PHP?

you need to try different aspects, I couldn't use the package myself😊
Sent from my iPhone

On Apr 1, 2019, at 13:04, Jiwon<EMAIL_ADDRESS>wrote:
PHP version?? Do you mean this project needs a lower version of PHP?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


[WIP] The Blend Service Pack

Added [CategoryAttribute("MahApps.Metro")] for each AttachedProperty.

@xxMUROxx can you resolve the conflicts?

@punker76 done


Different font size than the default table columns

Hi,
It seems like the popover columns have larger text than the table default in filament v3. Any way to change that?

you can publish the view to customize it or submit a PR to use the same classes as filament default text


The test suite fails:

Describe the bug
The test suite fails as shown below.
To Reproduce
run guix build emacs-org-journal; you should see in the build log:
starting phase `check'
Running 10 tests (2024-01-19 11:30:53+0000, selector ‘t’)
   passed   1/10  org-journal-calendar-date-from-file-test (0.001255 sec)
Test org-journal-carryover-delete-empty-journal-test backtrace:
  signal(error ("Calling ‘org-fold-core-region’ with missing SPEC"))
  error("Calling `org-fold-core-region' with missing SPEC")
  org-fold-region(35 41 t drawer)
  org-insert-property-drawer()
  org-get-property-block(1 force)
  org-entry-put(nil "CREATED" "20190101")
  org-set-property("CREATED" "20190101")
  (progn (insert "* Wednesday, 01/01/19\n") (org-set-property "CREATED
  (unwind-protect (progn (insert "* Wednesday, 01/01/19\n") (org-set-p
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
  (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
  (let ((buffer "20181231") (org-journal-carryover-delete-empty-journa
  (let* ((org-journal-dir (concat org-journal-dir-test "-link")) (comm
  (closure (t) nil (let* ((org-journal-dir (concat org-journal-dir-tes
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name org-journal-carryover-delete-empty-jo
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-L" "." "-l" "tests/org-journal-test" "-f" "ert-run
  command-line()
  normal-top-level()
Test org-journal-carryover-delete-empty-journal-test condition:
    (error "Calling ‘org-fold-core-region’ with missing SPEC")
   FAILED   2/10  org-journal-carryover-delete-empty-journal-test (0.388196 sec) at tests/org-journal-test.el:195
Test org-journal-carryover-items-test backtrace:
  signal(error ("Calling ‘org-fold-core-region’ with missing SPEC"))
  error("Calling `org-fold-core-region' with missing SPEC")
  org-fold-region(33 39 t drawer)
  org-insert-property-drawer()
  org-get-property-block(1 force)
  org-entry-put(nil "CREATED" "20190101")
  org-set-property("CREATED" "20190101")
  (progn (insert "* Tuesday, 01/01/19\n") (org-set-property "CREATED"
  (unwind-protect (progn (insert "* Tuesday, 01/01/19\n") (org-set-pro
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
  (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
  (let ((org-journal-file-type 'weekly) (system-time-locale "C") (buff
  (let* ((org-journal-dir (concat org-journal-dir-test "-link")) (comm
  (closure (t) nil (let* ((org-journal-dir (concat org-journal-dir-tes
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name org-journal-carryover-items-test :doc
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-L" "." "-l" "tests/org-journal-test" "-f" "ert-run
  command-line()
  normal-top-level()
Test org-journal-carryover-items-test condition:
    (error "Calling ‘org-fold-core-region’ with missing SPEC")
   FAILED   3/10  org-journal-carryover-items-test (0.000815 sec) at tests/org-journal-test.el:120
   passed   4/10  org-journal-carryover-keep-parents-test (0.030513 sec)
   passed   5/10  org-journal-convert-time-to-file-type-time-test (0.000678 sec)
   passed   6/10  org-journal-insert-header-test (0.011575 sec)
   passed   7/10  org-journal-scheduled-carryover-daily-test (0.024854 sec)
   passed   8/10  org-journal-scheduled-carryover-yearly-test (0.026444 sec)
Test org-journal-scheduled-weekly-test backtrace:
  signal(ert-test-failed (((should (equal (buffer-substring-no-propert
  ert-fail(((should (equal (buffer-substring-no-properties (point-min)
  (if (unwind-protect (setq value-104 (apply fn-102 args-103)) (setq f
  (let (form-description-106) (if (unwind-protect (setq value-104 (app
  (let ((value-104 'ert-form-evaluation-aborted-105)) (let (form-descr
  (let* ((fn-102 #'equal) (args-103 (condition-case err (let ((signal-
  (let* ((scheduled-entry-date (calendar-current-date day-offset)) (sc
  (let ((org-journal-file-type 'weekly) (org-journal-start-on-weekday
  (let* ((org-journal-dir (concat org-journal-dir-test "-link")) (comm
  (closure (t) nil (let* ((org-journal-dir (concat org-journal-dir-tes
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name org-journal-scheduled-weekly-test :do
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-L" "." "-l" "tests/org-journal-test" "-f" "ert-run
  command-line()
  normal-top-level()
Test org-journal-scheduled-weekly-test condition:
    (ert-test-failed
     ((should
       (equal
	(buffer-substring-no-properties ... ...)
	(with-temp-buffer ... ...)))
      :form
      (equal "* Test header\n:PROPERTIES:\n:CREATED:  20240119\n:END:\n* Test header\n:PROPERTIES:\n:CREATED:  20240120\n:END:\n** TODO Task 1\n<2024-01-20 Sat 00:00>\n** TODO Task 2\n<2024-01-20 Sat 00:00>" "* Test header\n:PROPERTIES:\n:CREATED:  20240119\n:END:\n* Test header\n:PROPERTIES:\n:CREATED:  20240120\n:END:\n** TODO Task 1\n2024-01-20 Sat 00:00\n** TODO Task 2\n2024-01-20 Sat 00:00")
      :value nil :explanation
      (arrays-of-different-length 181 177 "* Test header\n:PROPERTIES:\n:CREATED:  20240119\n:END:\n* Test header\n:PROPERTIES:\n:CREATED:  20240120\n:END:\n** TODO Task 1\n<2024-01-20 Sat 00:00>\n** TODO Task 2\n<2024-01-20 Sat 00:00>" "* Test header\n:PROPERTIES:\n:CREATED:  20240119\n:END:\n* Test header\n:PROPERTIES:\n:CREATED:  20240120\n:END:\n** TODO Task 1\n2024-01-20 Sat 00:00\n** TODO Task 2\n2024-01-20 Sat 00:00" first-mismatch-at 121)))
   FAILED   9/10  org-journal-scheduled-weekly-test (0.017773 sec) at tests/org-journal-test.el:319
   passed  10/10  org-journal-search-build-file-list-test (0.082308 sec)

Ran 10 tests, 7 results as expected, 3 unexpected (2024-01-19 11:30:53+0000, 0.931735 sec)

3 unexpected results:
   FAILED  org-journal-carryover-delete-empty-journal-test
   FAILED  org-journal-carryover-items-test
   FAILED  org-journal-scheduled-weekly-test

Expected behavior
The test suite should pass.
Desktop (please complete the following information):

OS: GNU Guix
Emacs Version: 29.1

Thanks for the report. Hmm, never seen that before (error "Calling ‘org-fold-core-region’ with missing SPEC")

@Apteryks Can you please test for me if some of the 3 tests don't fail anymore when you run make on the master branch on your pc and report back? Thank you!

It appears to be resolved:
~/src/guix [env] git diff
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0fb3857847..dc66e61edd 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -36168,26 +36168,27 @@ (define-public emacs-org-journal
                              "-L" "."
                              "-l" "tests/org-journal-test"
                              "-f" "ert-run-tests-batch-and-exit")
-      #:phases
-      #~(modify-phases %standard-phases
-          (add-before 'check 'disable-failing-tests
-            (lambda _
-              (let-syntax
-                  ((disable-tests
-                    (syntax-rules ()
-                      ((_ file ())
-                       (syntax-error "test names list must not be empty"))
-                      ((_ file (test-name ...))
-                       (substitute* file
-                         (((string-append "^\\(ert-deftest " test-name ".*") all)
-                          (string-append all "(skip-unless nil)\n")) ...)))))
-                ;; These tests fail for unknown reasons (see:
-                ;; https://github.com/bastibe/org-journal/issues/427).
-                (disable-tests
-                 "tests/org-journal-test.el"
-                 ("org-journal-carryover-delete-empty-journal-test"
-                  "org-journal-carryover-items-test"
-                  "org-journal-scheduled-weekly-test"))))))))
+      ;; #:phases
+      ;; #~(modify-phases %standard-phases
+      ;;     (add-before 'check 'disable-failing-tests
+      ;;       (lambda _
+      ;;         (let-syntax
+      ;;             ((disable-tests
+      ;;               (syntax-rules ()
+      ;;                 ((_ file ())
+      ;;                  (syntax-error "test names list must not be empty"))
+      ;;                 ((_ file (test-name ...))
+      ;;                  (substitute* file
+      ;;                    (((string-append "^\\(ert-deftest " test-name ".*") all)
+      ;;                     (string-append all "(skip-unless nil)\n")) ...)))))
+      ;;           ;; These tests fail for unknown reasons (see:
+      ;;           ;; https://github.com/bastibe/org-journal/issues/427).
+      ;;           (disable-tests
+      ;;            "tests/org-journal-test.el"
+      ;;            ("org-journal-carryover-delete-empty-journal-test"
+      ;;             "org-journal-carryover-items-test"
+      ;;             "org-journal-scheduled-weekly-test"))))))
+      ))
     (home-page "https://github.com/bastibe/org-journal")
     (synopsis "Simple Org mode journaling mode")
     (description

~/src/guix [env]$ ./pre-inst-env guix build emacs-org-journal --with-git-url=emacs-org-journal=https://github.com/bastibe/org-journal
updating checkout of 'https://github.com/bastibe/org-journal'...
retrieved commit 745ae15ff1a63d732f633ff282c19c206055f031
substitute: mise à jour des substituts depuis « https://ci.guix.gnu.org »... 100.0 %
substitute: mise à jour des substituts depuis « https://bordeaux.guix.gnu.org »... 100.0 %
The following derivation will be built:
  /gnu/store/pc9kikh3qyixn1dc92ij2qsfqcx47kir-emacs-org-journal-2.2.0.drv
building /gnu/store/pc9kikh3qyixn1dc92ij2qsfqcx47kir-emacs-org-journal-2.2.0.drv...
starting phase `set-SOURCE-DATE-EPOCH'
phase `set-SOURCE-DATE-EPOCH' succeeded after 0.0 seconds
starting phase `set-paths'
environment variable `PATH' set to `/gnu/store/3ki76bxalfm5vpkk9jbddnw4gk420svv-emacs-minimal-29.1/bin:/gnu/store/sxx22f98vfbavcqmdksm6as8fvskpxiw-tar-1.34/bin:/gnu/store/x24bm49ag5dvki72mjdz195bfb89nrnb-gzip-1.12/bin:/gnu/store/j8wlfmlmfvpbza6is9wv9xsd8psrxn00-bzip2-1.0.8/bin:/gnu/store/gr0sy0m1mv36qv54idm6cn10l3mngshq-file-5.44/bin:/gnu/store/zmcf5kpqiighkbh7wslf91qdjwj06yr1-diffutils-3.8/bin:/gnu/store/210yfax18r2g2inxrml9435ikhfcca6m-patch-2.7.6/bin:/gnu/store/c8jyph2lxw0m9na34fg8h70n4nnnz7is-findutils-4.9.0/bin:/gnu/store/hc05d76f1j3iz3v2bs5jz4fpljl1r4dj-gawk-5.2.1/bin:/gnu/store/xxcfsimvxz7z4dj593gnqbkzc6picwzq-sed-4.8/bin:/gnu/store/yrv5f70mn83a876b78i5s79dd2hsh0zf-grep-3.8/bin:/gnu/store/6k1yys9wqrfn4y41ic1win8gpnimncwj-xz-5.2.8/bin:/gnu/store/a5i8avx826brw5grn3n4qv40g514505c-coreutils-9.1/bin:/gnu/store/wj7casda7rb55rvqjnpm0bm7a2zm6618-make-4.3/bin:/gnu/store/rib9g2ig1xf3kclyl076w28parmncg4k-bash-minimal-5.1.16/bin:/gnu/store/na1dpbbcxjaa3n8wkwrfpch476f90hlf-ld-wrapper-0/bin:/gnu/store/zh4x65snfis7svs6906gj1z8i7dx2j3m-binutils-2.38/bin:/gnu/store/5lqhcv91ijy82p92ac6g5xw48l0lwwz4-gcc-11.3.0/bin:/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35/bin:/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35/sbin'
environment variable `EMACSLOADPATH' set to `/gnu/store/3ki76bxalfm5vpkk9jbddnw4gk420svv-emacs-minimal-29.1/share/emacs/site-lisp'
environment variable `EMACSNATIVELOADPATH' unset
environment variable `INFOPATH' set to `/gnu/store/3ki76bxalfm5vpkk9jbddnw4gk420svv-emacs-minimal-29.1/share/info:/gnu/store/sxx22f98vfbavcqmdksm6as8fvskpxiw-tar-1.34/share/info:/gnu/store/x24bm49ag5dvki72mjdz195bfb89nrnb-gzip-1.12/share/info:/gnu/store/zmcf5kpqiighkbh7wslf91qdjwj06yr1-diffutils-3.8/share/info:/gnu/store/c8jyph2lxw0m9na34fg8h70n4nnnz7is-findutils-4.9.0/share/info:/gnu/store/hc05d76f1j3iz3v2bs5jz4fpljl1r4dj-gawk-5.2.1/share/info:/gnu/store/xxcfsimvxz7z4dj593gnqbkzc6picwzq-sed-4.8/share/info:/gnu/store/yrv5f70mn83a876b78i5s79dd2hsh0zf-grep-3.8/share/info:/gnu/store/a5i8avx826brw5grn3n4qv40g514505c-coreutils-9.1/share/info:/gnu/store/wj7casda7rb55rvqjnpm0bm7a2zm6618-make-4.3/share/info:/gnu/store/rib9g2ig1xf3kclyl076w28parmncg4k-bash-minimal-5.1.16/share/info:/gnu/store/zh4x65snfis7svs6906gj1z8i7dx2j3m-binutils-2.38/share/info:/gnu/store/5lqhcv91ijy82p92ac6g5xw48l0lwwz4-gcc-11.3.0/share/info:/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35/share/info'
environment variable `TREE_SITTER_GRAMMAR_PATH' unset
environment variable `BASH_LOADABLES_PATH' unset
environment variable `C_INCLUDE_PATH' set to `/gnu/store/3ki76bxalfm5vpkk9jbddnw4gk420svv-emacs-minimal-29.1/include:/gnu/store/j8wlfmlmfvpbza6is9wv9xsd8psrxn00-bzip2-1.0.8/include:/gnu/store/gr0sy0m1mv36qv54idm6cn10l3mngshq-file-5.44/include:/gnu/store/hc05d76f1j3iz3v2bs5jz4fpljl1r4dj-gawk-5.2.1/include:/gnu/store/6k1yys9wqrfn4y41ic1win8gpnimncwj-xz-5.2.8/include:/gnu/store/wj7casda7rb55rvqjnpm0bm7a2zm6618-make-4.3/include:/gnu/store/zh4x65snfis7svs6906gj1z8i7dx2j3m-binutils-2.38/include:/gnu/store/5lqhcv91ijy82p92ac6g5xw48l0lwwz4-gcc-11.3.0/include:/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35/include:/gnu/store/5iklcps70c0sfkxvlrhg8jhf3q4h18bj-linux-libre-headers-5.15.49/include'
environment variable `CPLUS_INCLUDE_PATH' set to `/gnu/store/3ki76bxalfm5vpkk9jbddnw4gk420svv-emacs-minimal-29.1/include:/gnu/store/j8wlfmlmfvpbza6is9wv9xsd8psrxn00-bzip2-1.0.8/include:/gnu/store/gr0sy0m1mv36qv54idm6cn10l3mngshq-file-5.44/include:/gnu/store/hc05d76f1j3iz3v2bs5jz4fpljl1r4dj-gawk-5.2.1/include:/gnu/store/6k1yys9wqrfn4y41ic1win8gpnimncwj-xz-5.2.8/include:/gnu/store/wj7casda7rb55rvqjnpm0bm7a2zm6618-make-4.3/include:/gnu/store/zh4x65snfis7svs6906gj1z8i7dx2j3m-binutils-2.38/include:/gnu/store/5lqhcv91ijy82p92ac6g5xw48l0lwwz4-gcc-11.3.0/include/c++:/gnu/store/5lqhcv91ijy82p92ac6g5xw48l0lwwz4-gcc-11.3.0/include:/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35/include:/gnu/store/5iklcps70c0sfkxvlrhg8jhf3q4h18bj-linux-libre-headers-5.15.49/include'
environment variable `LIBRARY_PATH' set to `/gnu/store/3ki76bxalfm5vpkk9jbddnw4gk420svv-emacs-minimal-29.1/lib:/gnu/store/j8wlfmlmfvpbza6is9wv9xsd8psrxn00-bzip2-1.0.8/lib:/gnu/store/gr0sy0m1mv36qv54idm6cn10l3mngshq-file-5.44/lib:/gnu/store/hc05d76f1j3iz3v2bs5jz4fpljl1r4dj-gawk-5.2.1/lib:/gnu/store/6k1yys9wqrfn4y41ic1win8gpnimncwj-xz-5.2.8/lib:/gnu/store/zh4x65snfis7svs6906gj1z8i7dx2j3m-binutils-2.38/lib:/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35/lib:/gnu/store/l0yryi5jsa1grnvw01c9nkz9c81cv224-glibc-2.35-static/lib:/gnu/store/visfdda934gvivwihwhlm63fdqhhcc8a-glibc-utf8-locales-2.35/lib'
environment variable `GUIX_LOCPATH' set to `/gnu/store/visfdda934gvivwihwhlm63fdqhhcc8a-glibc-utf8-locales-2.35/lib/locale'
phase `set-paths' succeeded after 0.0 seconds
starting phase `install-locale'
using 'en_US.utf8' locale for category "LC_ALL"
phase `install-locale' succeeded after 0.0 seconds
starting phase `unpack'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/.gitignore' -> `./.gitignore'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/CHANGELOG' -> `./CHANGELOG'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/CONTRIBUTORS' -> `./CONTRIBUTORS'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/LICENSE' -> `./LICENSE'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/MAINTAINERS' -> `./MAINTAINERS'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/Makefile' -> `./Makefile'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/README.org' -> `./README.org'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/org-journal.el' -> `./org-journal.el'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/org-journal.svg' -> `./org-journal.svg'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/tests/org-journal-test.el' -> `./tests/org-journal-test.el'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/tests/journals/yearly/carryover1/20190101' -> `./tests/journals/yearly/carryover1/20190101'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/tests/journals/yearly/carryover1/20200101' -> `./tests/journals/yearly/carryover1/20200101'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/tests/journals/daily/carryover1/2020-10-21.org' -> `./tests/journals/daily/carryover1/2020-10-21.org'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/tests/journals/daily/carryover1/2020-10-22.org' -> `./tests/journals/daily/carryover1/2020-10-22.org'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/.github/workflows/test.yml' -> `./.github/workflows/test.yml'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/.github/ISSUE_TEMPLATE/bug_report.md' -> `./.github/ISSUE_TEMPLATE/bug_report.md'
`/gnu/store/iyf9p4vbs65rv42xfb6vyfjrcya19a8i-org-journal-745ae15/.github/ISSUE_TEMPLATE/feature_request.md' -> `./.github/ISSUE_TEMPLATE/feature_request.md'
phase `unpack' succeeded after 0.0 seconds
starting phase `expand-load-path'
source directory "/tmp/guix-build-emacs-org-journal-2.2.0.drv-0/source" prepended to the `EMACSLOADPATH' environment variable
phase `expand-load-path' succeeded after 0.0 seconds
starting phase `add-install-to-native-load-path'
phase `add-install-to-native-load-path' succeeded after 0.0 seconds
starting phase `patch-usr-bin-file'
phase `patch-usr-bin-file' succeeded after 0.0 seconds
starting phase `patch-source-shebangs'
phase `patch-source-shebangs' succeeded after 0.0 seconds
starting phase `patch-generated-file-shebangs'
phase `patch-generated-file-shebangs' succeeded after 0.0 seconds
starting phase `check'
Running 10 tests (2024-02-19 03:46:48+0000, selector ‘t’)
   passed   1/10  org-journal-calendar-date-from-file-test (0.001452 sec)
   passed   2/10  org-journal-carryover-delete-empty-journal-test (0.859395 sec)
   passed   3/10  org-journal-carryover-items-test (0.153362 sec)
   passed   4/10  org-journal-carryover-keep-parents-test (0.048188 sec)
   passed   5/10  org-journal-convert-time-to-file-type-time-test (0.000921 sec)
   passed   6/10  org-journal-insert-header-test (0.018902 sec)
   passed   7/10  org-journal-scheduled-carryover-daily-test (0.035104 sec)
   passed   8/10  org-journal-scheduled-carryover-yearly-test (0.042284 sec)
   passed   9/10  org-journal-scheduled-weekly-test (0.029215 sec)
   passed  10/10  org-journal-search-build-file-list-test (0.135819 sec)

Ran 10 tests, 10 results as expected, 0 unexpected (2024-02-19 03:46:49+0000, 1.325841 sec)

phase `check' succeeded after 2.1 seconds
starting phase `install'
`/tmp/guix-build-emacs-org-journal-2.2.0.drv-0/source/org-journal.el' -> `/gnu/store/4z2l7k8qhwis9lsiyliy76v2kja73903-emacs-org-journal-2.2.0/share/emacs/site-lisp/org-journal-2.2.0/org-journal.el'
phase `install' succeeded after 0.0 seconds
starting phase `make-autoloads'
  INFO     Scraping files for loaddefs...
  INFO     Scraping files for loaddefs...done
  GEN      org-journal-autoloads.el
phase `make-autoloads' succeeded after 0.1 seconds
starting phase `enable-autoloads-compilation'
phase `enable-autoloads-compilation' succeeded after 0.0 seconds
starting phase `patch-el-files'
phase `patch-el-files' succeeded after 0.0 seconds
starting phase `ensure-package-description'
org-journal-pkg.el file generated.
phase `ensure-package-description' succeeded after 0.2 seconds
starting phase `build'

In org-journal--insert-entry-header:
org-journal.el:751:37: Warning: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.

In org-journal-carryover-items:
org-journal.el:952:33: Warning: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.
org-journal.el:953:74: Warning: ‘point-at-eol’ is an obsolete function (as of 29.1); use ‘line-end-position’ or ‘pos-eol’ instead.

In org-journal--carryover-item-with-parents:
org-journal.el:1035:18: Warning: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.

In org-journal-reschedule-scheduled-entry:
org-journal.el:1199:68: Warning: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.

In org-journal--deserialize:
org-journal.el:1341:61: Warning: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.
org-journal.el:1341:76: Warning: ‘point-at-eol’ is an obsolete function (as of 29.1); use ‘line-end-position’ or ‘pos-eol’ instead.
phase `build' succeeded after 0.6 seconds
starting phase `validate-compiled-autoloads'
Loading /gnu/store/4z2l7k8qhwis9lsiyliy76v2kja73903-emacs-org-journal-2.2.0/share/emacs/site-lisp/org-journal-2.2.0/org-journal-autoloads.elc...
phase `validate-compiled-autoloads' succeeded after 0.0 seconds
starting phase `move-doc'
phase `move-doc' succeeded after 0.0 seconds
starting phase `patch-shebangs'
phase `patch-shebangs' succeeded after 0.0 seconds
starting phase `strip'
phase `strip' succeeded after 0.0 seconds
starting phase `validate-runpath'
phase `validate-runpath' succeeded after 0.0 seconds
starting phase `validate-documentation-location'
phase `validate-documentation-location' succeeded after 0.0 seconds
starting phase `delete-info-dir-file'
phase `delete-info-dir-file' succeeded after 0.0 seconds
starting phase `patch-dot-desktop-files'
phase `patch-dot-desktop-files' succeeded after 0.0 seconds
starting phase `make-dynamic-linker-cache'
phase `make-dynamic-linker-cache' succeeded after 0.0 seconds
starting phase `install-license-files'
installing 1 license files from '.'
phase `install-license-files' succeeded after 0.0 seconds
starting phase `reset-gzip-timestamps'
phase `reset-gzip-timestamps' succeeded after 0.0 seconds
starting phase `compress-documentation'
phase `compress-documentation' succeeded after 0.0 seconds
successfully built /gnu/store/pc9kikh3qyixn1dc92ij2qsfqcx47kir-emacs-org-journal-2.2.0.drv
/gnu/store/4z2l7k8qhwis9lsiyliy76v2kja73903-emacs-org-journal-2.2.0

Awesome, thank you!


Question: port ros1 functionality to ros2

Hi,
We are in the process of migrating our ros1 system to ros2. We are currently using the ros1 driver that holds some additional diagnostics features compared to this ros2 driver. We would like to port these features to the ros2 repo, e.g.:

https://github.com/SICKAG/sick_safetyscanners/pull/128
https://github.com/SICKAG/sick_safetyscanners/pull/126
https://github.com/SICKAG/sick_safetyscanners/pull/125
https://github.com/SICKAG/sick_safetyscanners/pull/50
https://github.com/SICKAG/sick_safetyscanners/pull/30
etc.

What would be the best way for us to address this? I also see that this repo contains quite some duplicated code:

https://github.com/SICKAG/sick_safetyscanners2/blob/master/src/SickSafetyscannersLifeCycle.cpp
and https://github.com/SICKAG/sick_safetyscanners2/blob/master/src/SickSafetyscannersRos2.cpp

Should we target both implementations or maybe do a refactor first?
What do you think?
Thanks!

Hi,
if you are willing to do a refactor first, i would be happy to have a look at that PR.
And yes i know that are currently two implementations with a lot of similar code.
Afterwards, feel free to port your needed feature, I am happy to integrate them once again in the ROS2 version

https://github.com/SICKAG/sick_safetyscanners2/pull/26 this PR might be relevant for this

Great; we will look into it!

Due to holidays we did not have that much develop cycles this month. Just wanted to let you know that we will start working on this in the coming weeks.

Hi @puck-fzi ; when thinking about this a bit more. We think it would be an easier process to create ros2 branch in the https://github.com/SICKAG/sick_safetyscanners repository and do the ros2 migration based on the current main branch. Of course we could additionally implement the lifecycle node afterwards. What do you think?

Dear Reinzor, long term, it is planned to have the node separation of the CPP core lib and the driver on top of it. So, I would instead integrate the functionality into this lib here rather than in the ROS1 lib as a separate branch. Long-term all features of the ROS1 node should be included in the ROS2 driver.
The CPP Lib already contains additional features, which are not in the ROS1 driver included anymore.

OK, clear. Then we will take this repository as a base and start with a refactor that eliminates the duplicated code. After that, we can start porting ROS1 features to ROS2.

Hi @puck-fzi ; I am somewhat stuck in the refactor of combining the lifecycle and normal node since rclcpp::Node and rclcpp_lifecycle::LifecycleNode have different implementations. Also see https://github.com/ros2/rclcpp/issues/898
The problem is that I cannot properly combine two implementations when I am going to add diagnostics, declare parameters, diagnostics etc. We would like to add a diagnostic updater and a diagnosed publisher.
What do you think what is the best plan here? We internally have no need for the lifecycle nodes and adding the ros1 features to the normal node would be sufficient. However, this results in both node implemenations going out of sync. Any ideas, suggestions appreciated.

@puck-fzi any thoughts?

Just off the top of my head, it might be worth refactoring the functionality into a separate helper class, which is then used by both the lifecycle and the normal nodes. Therefore, the code duplication is reduced.
Then maybe both nodes can have their separate interface and just use the same helper classes, then you could add to the normal node your desired diagnostics. Then the code would not be that out of sync and just slightly different functionality in each node.
I think there are cases where either node might be beneficial.


Model binding issue

Hi, after i clear model ther is still value in input.
Example:
<ion-autocomplete
	ng-model="data.auto.registrationPlace"
	items-method="registrationPlaceQuery(query)"
	placeholder=""
	cancel-label="back"
	item-view-value-key="nameFull"
	name="registrationPlace"
	required/>

How can i clear the inpur field when programmatically clear model ?

Hi,
yes I had a similar issue in the last days. I will have a look on it next week and hopefully fix it.
Thanks for pointing it out.
Regards,
Guy

Hi,
I just checked in a fix such that if you set the model to undefined (or the model is already undefined) the view value is set to an empty string. I hope this fixes your issue. Could you please shortly test it and then tell me if it worked?
After that I am able to release a new version.
Thanks and regards,
Guy

It works :D
Thanks!


media keys unbinding almost every day

OS: MacOS 10.13.4
GPMDP Version: 4.5
Issue Descriptions: I am having to restart the app every day now it seems to restore keyboard support, it used to stay bound for weeks at a time...
Steps to Reproduce: Lately it seems Youtube has been hijacking the keys maybe? I routinely pause music to watch some YT videos, but historically this has never been a problem.

@ktiedt This seems to be an issue for me too, except only in order of app startup. So if Chromium starts first, and then Google Play Music Desktop Player, only chromium will bind to media keys, rather than both apps responding to the event.

Hmmm @rojr I never considered a chrome update (causing a restart) to be the update... that very well could be what I was dealing with too and I just never connected the 2 things.

I had this problem with media keys too until I removed "Google Play Music" extension from Chrome.
There is more info about the similar bug
https://community.spotify.com/t5/Desktop-Windows/Media-keys-no-longer-work/td-p/807591

This is a general "feature" in macOS High Sierra. Someone created this app: http://milgra.com/high-sierra-media-key-enabler.html to force the media keys to always control iTunes or Spotify. But us Google Music people are left dealing with it working sometimes and not others.
Please add an option to bind the media keys to Google Music desktop, always!


Version Typo

I have checked the following:

[X] I use the newest version of bruno.
[X] I've searched existing issues and found nothing related to my issue.

Describe the bug
There's a typo maybe on the version showing on the Bruno app it should be 1.26.2
.bru file to reproduce the bug
No response
Screenshots/Live demo link

It seems to be fixed with v1.27.0


Release 0.1.3

Hey, I see that 0.1.3 got updated in cargo.toml a few weeks back. Would you mind publishing it up to crates.io please.

Released apologies for the delay.


Add classes for "Task" fields

Deadline and Description class has been implemented. Deadline has date and no time.

Codecov Report

Merging #126 (e06a101) into master (ad509d8) will decrease coverage by 3.08%.
The diff coverage is 0.00%.

 Learn more

Task class now supports isSameTask method, criteria - same description (case-insensitive)
TaskContainsKeywordsPredicate now performs case-insensitive matching for description
Description class now supports equalIgnoreCase method

LGTM


I am having problem with events

Events are added like this:
$scope.events = [
{
title: 'My event title', // The title of the event
type: 'important',
startsAt: new Date(2015,10,26),
endsAt: new Date(2015,10,26),
editable: false,
deletable: false,
incrementsBadgeTotal: true
}
];
however its supposed to be on October right? well it's not it displays on November and every date I assign in the events are always 1 month difference like if it's 2015,9,26 it gets on October and etc,
one more thing, how can I change the color of the weekends because here in my country we are having weekends on Fridays and Saturdays
can you please solve this issues .. thank you in advance.

Javascript date objects have 0 based months so what you're doing is the correct behaviour.
As for changing the weekend on the calendar, see the i18n guide here.


Mediation for Edge Agents in Aries Framework JavaScript

Current thoughts on implementing mediation for Edge Agents into Aries Framework JavaScript. I think in the beginning especially the Edge Agent role would be nice to implement, but eventually implementing the Mediator role would also be nice. This approach allows for interoperable mediaton with other agents that support the protocols mentioned in this document. Still some unresolved questions at the end. Would appreciate some other thoughts on this.
Creating A Connection with the Mediator
The Mediator creates a Connection Invitation and sends it to the Edge Agent. If the Edge Agent wishes to connect to the Mediator it should respond with a Connection Request. Because the Edge Agent has no endpoint to include in the Connection Request, an endpoint URI of didcomm:transport/queue will indicate to the Mediator that the Edge Agent does not have a direct endpoint and messages should be queued.
The Connection Request sent by the Edge Agent should include the Transport Return Route Decorator to allow the Mediator to directly respond with a Connection Response message.
The Edge Agent and Mediator now have a connection. The Mediator will queue all messages it wants to send to the Edge Agent due to the didcomm:transport/queue endpoint.
Requesting Mediation
The Mediator and Edge Agent now have a connection, but it is not clear yet whether the Mediator would like to mediate for the Edge Agent.
Using the Mediator Coordination Protocol the Edge Agent can send a Mediation Request to the Mediator. If the Mediator wishes to accept it will respond with a Mediation Grant message. The Mediation Grant will include the endpoint and routing_keys properties. The Edge Agent should store these values as they will be used when creating new connections with other agents.
Creating A Connection with Other Agents
Now that the Edge Agent made an agreement with the Mediator to act as an endpoint to receive messages, the Edge Agent can create connections with other agents using this endpoint.
It is not important whether the Edge Agent takes the role of Inviter or Invitee in the connection process. It is however important that before sending a message to the other agent the key used for this message is known by the Mediator. The Edge Agent should send a Keylist Update message to the Mediator containing the key that will be used. The Mediator now knows that whenever a Forward message is received for this key, it is intended for the Edge Agent.
After the key is registered the connection flow can continue like normal. The Edge Agent can use the endpoint and routing_keys from the Requesting Mediation step when exchanging DID Docs.
Receiving Messages
As the Edge Agent has no endpoint the Mediator can't directly forward the messages to the Edge Agent when it receives them. The Creating A Connection with the Mediator step allowed the Mediator to send a message to the Edge Agent using return routing. This is the implicit way for the Edge Agent to retrieve Messages. The explicit way is by using the Pickup Protocol
Implicit
Messages can be retrieved by the Edge Agent implicitly by connecting using the Return Routing Protocol. It is recommended that a WebSocket transport be used between the Edge Agent and the Mediator for efficient message passing, and responsive message delivery when the Edge Agent app is open.
Explicit
When WebSocket transport is not available and HTTP is used, return routing can only include one message in the HTTP response for each message the Edge Agent sends to the Mediator. This is where the Pickup Protocol can be used. Return routing will still be used, but by sending a Batch Pickup message as Edge Agent the Mediator can respond with a single Batch message containing multiple messages.
References

Aries RFC 0211: Mediator Coordination Protocol
How Edge Agents can Gain an Endpoint
Aries RFC 0092: Transports Return Route
Aries RFC 0212: Pickup Protocol
Aries RFC 0094: Cross-Domain Messaging
Connections / DID Exchange / DID Document URI-less endpoints - hyperledger/aries-rfcs#405
Add Queue as a Transport option - decentralized-identity/didcomm-messaging#49

Questions

I'm not sure whether it is required for the Edge Agent to send a message to the Mediator when opening a WebSocket connection with the Transport Return Routing decorator. I think this is necessary, because you can't just send an object with the ~transport decorator without including a message @type. If this is the case we could maybe use Noop message from the Pickup Protocol
As mentioned in the notes below, Aries Framework .NET supports an add-device-info message especially useful for push notifications. This is not possible with this approach. Is this desired?
As also mentioned in the notes below, Aries Framework .NET uses a custom protocol, this means this approach won't be interoperable with Aries Framework .NET. Is this desired?

Notes

Aries Framework .NET created and implemented a custom basic-routing protocol that achieves approximately the same. Main differences are:

The protocol allows to create an inbox. Messages will be stored inside the inbox. To delete messages from the inbox a separate delete message type is used. With the pickup protocol messages are only kept until delivered.
The protocol has a message type to add device information.

Aries Framework Go implemented the approach described in this document. I think the only thing missing is the didcomm:transport/queue endpoint. The Route Coordination Protocol got renamed to Mediator Coordination Protocol and got some small updates. With some adjustments Aries Framework Go could be used as a Mediator for Aries Framework JavaScript Edge Agents

Hi @TimoGlastra, thanks for the write-up, I went through it briefly and it was really helpful.  I'll look into it more over the weekend and we'll see how far I'll get :)

I've prepared partial implementation here https://github.com/jakubkoci/aries-framework-javascript/tree/feature/connection-with-mediator.
It contains:

Creating A Connection with the Mediator
Receiving Messages - Explicit with pickup protocol

I'll create PR after merging #41  because I continued from that branch.

Great stuff!
I have some extra thoughts on this and other topics. Let's discuss during the call friday and keep this issue open to track progress.

FYI: Updates were applied to aries-framework-go.

https://github.com/hyperledger/aries-framework-go/pull/1827
https://github.com/hyperledger/aries-framework-go/pull/1825

@TimoGlastra

Awesome. I think everything is in place then to use framework-go as a mediator for framework-javascript.
@troyronda Some questions on the go implementation:

Is it correct the pickup protocol is not implemented?
What does the edge agent send to the mediator when opening a websocket connection? As it needs the ~transport decorator (see the first question in the original issue).
When I looked trough the code it seemed like forward messages are not stored at the moment if the mediator can't directly send them to the receiver edge agent. Is this correct?

@TimoGlastra

Awesome. I think everything is in place then to use framework-go as a mediator for framework-javascript.
@troyronda Some questions on the go implementation:

Is it correct the pickup protocol is not implemented?

Yes, the protocol is not implemented yet

What does the edge agent send to the mediator when opening a websocket connection? As it needs the ~transport decorator (see the first question in the original issue).

That's correct.Currently, only all return route option in ~transport is supported in aries-framework-go.

When I looked trough the code it seemed like forward messages are not stored at the moment if the mediator can't directly send them to the receiver edge agent. Is this correct?

Yes. At the moment, the edge agent needs to be online(active socket connection to the router) when router receives message for that particular agent.

Requesting Mediation part will be solved in #63


Custom llm

Hey guys,
I have been trying to create an interface for my custom llm, is there a way to do this through the CustomComponent? Or what is the best approach to do so?
Thanks!

@joelr45 Yes, custom component is a good option, you can follow https://docs.langflow.org/guidelines/custom-component to build your own component.
Check https://docs.langflow.org/components/custom#the-customcomponent-class for the return values for build_config and build. Basically build_config will help you build the drag-and-drop box and build will return the value as you want, like langchain.schema.Document or langchain.llms.base.BaseLLM.
For your case, the build return value will be langchain.llms.base.BaseLLM.
A sample code for your reference, hope it helps.
from langflow import CustomComponent
from langchain.chains import LLMChain
from langchain import PromptTemplate
import requests

from langchain.llms.base import BaseLLM

from typing import Any, Callable, List, Mapping, Optional

from langchain.callbacks.manager import CallbackManagerForLLMRun
from langchain.llms.base import LLM
from langchain.llms.utils import enforce_stop_tokens
from langchain.pydantic_v1 import Field

class PromptLLM(CustomComponent):
    display_name = "PromptLLM"
    description = "This component leverage huggingface space service to generator a prompt"

    def build_config(self) -> dict:
        return { "Space URL": { "multiline": True, "required": True } }

    def build(self, url: str) -> BaseLLM:
        return yourLLM

This may help you https://github.com/gyliu513/langflow101/blob/main/new-components/custom_components/prompt_llm.py

@gyliu513 This is very helpful, thanks so much!


Add comfortable utility methods to Tabs component

Add getTabIndex, getTabHash, getActiveTab and getActiveTabIndex methods to Tabs component.

Some utility methods to make the tab management easier.

Add activeTabIndex to Tabs

Do you intend to merge my modifications into the project? May I get feedback from you?

+1 @spatie-bot

Thanks!


kpt live init, preview, apply should install resource group

In kpt 1.0, installing resource group can be a pre step for live commands. Users should not be prompted to install resource group explicitly.

We have gone back and forth on this. There should be a flag that specifies this behavior (whether to automatically install or not), so the question is what is the default value of this flag. There was a concern that a "preview" command was installing the CRD. I think with the recent change to using --dry-run instead of preview, having the default be automatically install is the more reasonable behavior now.

cc @mortent @seans3

I still don't think we should install anything in the cluster when users provide the --dry-run flag. I don't see how changing from a separate preview command to a --dry-run flag changes this.

Previously, preview was a prominent part of the user flow. Because of the limitation in how dry-run works, we made it a flag. This is a trade-off, and we should favor streamlining the UX for apply.
Related: The Quickstart guide actually glosses over this implication: https://kpt.dev/book/01-getting-started/02-quickstart?id=apply-the-package. Having to run init and install-crd before apply is too cumbersome if you're coming from a tool like kubectl.
One possible way to ask permission for installing the CRD for dry-run:

If --dry-run is specified, then require --install-crd flag if the resource is missing from the cluster. Otherwise, error out.
If --dry-run is not specified, then install automatically.

However, having flags that depend on each other is additional complexity.

I agree with @mortent: we should not be mutating during a dry-run

What's the interaction of --dry-run and --install-resource-group: https://kpt.dev/reference/live/apply/
I think at least for sake of scriptability, you want to allow the user to explicitly allow installing the CRD if they want.

For scriptability, we have the command kpt live install-resource-group if users want to install the CRD, then do an apply --dry-run. So I don't think we should allow the flags --dry-run with install-resource-group; this should be an error.

So we have had discussions around this. I think we all agree that mutating the cluster by default during dry-run would be surprising behavior, but we also want to reduce the friction for people adopting kpt. I think the compromise here is that we let the --install-resource-group flag default to false when the --dry-run flag is provided, but default to true otherwise. Having different default values isn't ideal, but I think it is the best tradeoff here.
The result will be:

kpt does not install the resource-group CRD by default during dry-run.
Users can override this by adding the install-resource-group flag. So kpt live apply --dry-run --install-resource-group will install the resource-group CRD.
kpt live apply (without dry-run) will install the resource-group CRD by default.

The only change required here is to have the --install-resource-group flag default to true if it is not a dry-run. The behavior for the --install-resource-group flag currently works the correct way.

/assign @mortent


can not access 11001 port

OpenIM Server Version
3.8.0
Operating System and CPU Architecture
Linux (AMD)
Deployment Method
Docker Deployment
Bug Description and Steps to Reproduce
can not access 11001 port

Screenshots Link
No response

Could you confirm if the firewall is blocking access to this port?

Could you confirm if the firewall is blocking access to this port?

but inside container, the server is not listening on port 11001


graphql dependency

Correct me, but should not graphql module be a dependency of feathers-hooks-common instead of devDependency?!
Because we now get build errors in our typescript project. It tells us the following:
node_modules/feathers-hooks-common/types/index.d.ts(5,60): error TS2307: Cannot find module 'graphql'

I know of no feathers-hooks-common hook that calls feathers-graphql nor graphql/graphql. They are only used in testing.
So if there's a TS issue I would think its with the typings rather than the dependencies.
@j2L4e ^^^

I know of no feathers-hooks-common hook that calls feathers-graphql nor graphql/graphql. They are only used in testing.
So if there's a TS issue I would think its with the typings rather than the dependencies.
@j2L4e ^^^

Please fix it, otherwise we can not use it in our TS projects.

Making it a depebdency is the correct fix. @powermogli, would you please submit a PR?

In the master branch, graphql is no longer a dev dependency but a dependency (see commit from @PowerMogli on Dec 19).
I believe we just need to bump the version to 4.19.7 so that we can take advantage of the fix.

@j2L4e no where in the repo that I know of is feathers-graphql or graphql called directly. That makes graphql a devDependency not a dependency.
What is the issue regarding this in the typings?

@eddyystop The issue is related to TypeScript. Both @PowerMogli and I have this build error:
node_modules/feathers-hooks-common/types/index.d.ts:5:60 - error TS2307: Cannot find module 'graphql'.

5 import { GraphQLSchema, parse, GraphQLFieldResolver } from 'graphql';

Indeed, line 5 of feathers-hooks-common/types/index.d.ts is trying to import graphql

A better solution is probably to add the graphql types:
npm install --save-dev @types/graphql
and then I had to tweak my tsconfig by adding a compiler option:
"compilerOptions": {
  "lib": ["esnext"]
}

Otherwise I had TS complaining it could not find 'AsyncIterator'.

I don't handle TS.
Let's see if @j2L4e can fix this today. Otherwise could you perhaps submit a PR later in the day?

@cawel could you create a PR please?

Resolved via https://github.com/feathers-plus/feathers-hooks-common/pull/496 .


Even though requesting credential with VID still we see UIN detials in the app

Describe the bug
Even though requesting credential with VID still we see UIN detials in the app
Steps to Reproduce

unlock the app
click on Add ID
Enter VID number and click on Generate ID
VC card will be downloaded
View the downloaded card.

Current behavior
Even though requesting credential with VID still we see UIN detials in the app
Expected behavior
As VC is requested using VID number the details should be of VID and should not disclose UIN number.
Screenshots

Smartphone (please complete the following information):
Device: android
MOSIP Version: 121
MOSIP server: qa-121.mosip.net
APK link : https://github.com/mosip/inji/actions/runs/3287270987

@Anushree09-N @santhoshsunder after https://mosip.atlassian.net/browse/MOSIP-23388, it is possible to support a VID attribute in policy as well.
Also, refer to https://github.com/mosip/inji/issues/94
Now the label in the app UI is determined by the ID attribute returned in the VC based on the policy and not by what the user enters as input.

Verified the issue and now VID can be seen in downloaded VC . Hence closing.

Device details:
Device: Redmi K20 pro
OS: Android 11
BLE version: 5.0
MOSIP Version: <IP_ADDRESS>
MOSIP server: qa-1201-b2.net
app link: https://github.com/mosip/inji/actions/runs/4376897206
CommitId:


Show default ports in WorkGraph visualizer

Currently, the work graph visualizer only shows required inputs/outputs. Good to have a flag allowing all inputs/outputs to be included in the graph. Something like
wg = WorkGraph(show_default_ports=True)

or maybe include_default_ports.

Hi @edan-bainglass , thanks for the suggestions. It's indeed a good feature to have. There are several options come to my mind:

show required ports (default)
show all ports
show all ports within level n, for example, if level=1, we only show metadata, but hide all metadata.label etc. #119
show all data node port, #117

Great suggestions. I like the n option. Useful!


add:Ali t.nazari

Description
add:Ali t.nazari

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[x] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

@Silent-Watcher Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further!


Uses PYTHONPYCACHEPREFIX to control where __pycache__ goes

Summary

Python 3.x will precompile bytecode artifacts (*.pyc files) when these libraries are loaded. These files appear within __pycache__ directories alongside their source code. For libraries provided by the stdlib, these directories will be created or updated within the cpython layer since the source is located there. Ultimately, this means that loading Python code will result in the interpreter modifying the cpython layer after it has been created, thus creating non-reproducible builds.
There are a couple of options to prevent this layer modification from happening:

Set PYTHONDONTWRITEBYTECODE which will ensure these artifacts are never generated.
Set PYTHONPYCACHEPREFIX which will control where these artifacts appear on the filesystem.

I've chosen to set PYTHONPYCACHEPREFIX as it still allows any benefit these files may provide while ensuring we aren't inadvertently modifying the cpython layer.
Additionally, I've changed the level at which we apply the PYTHONPATH environment variable to Default to align with RFC0019.
Use Cases

Resolves https://github.com/paketo-buildpacks/cpython/issues/317
Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Thanks for the detailed explanation @ryanmoran! I agree that ideally we would be able to mark the layers as read-only and expose the underlying issue via a build failure. Thanks for linking to that RFC.


Provide a Service that Loads Icons on App Initialization

It would be nice to be able to have a list of icons loaded from a JSON file when the app initializes using the APP_INITIALIZER token.
I made this for a project I'm working on and it's really convenient to have a list of icons loaded automatically. You may not want to have too big of a list loaded when the app initializes, but it is a nice feature. It would be nice for it to be native to the package as well.
This gist contains what I did to load the icons automatically. https://gist.github.com/pjlamb12/b265ce3cf741d0237c084a27ea553dda
The package could provide several options of default icon sets to load as well as user defined sets.
Let me know if you have any suggestions or would like some help on implementing this.

I decided to publish the library externally from this one:
npmjs.com/package/angular-svg-icon-preloader


list.found object

Let's implement it, according to this paper.
e.g.
[] > test
  list > lst
    * 1 2 3
  assert-that > @
    lst.found 2
    $.equal-to 1

@Graur, I implemented it in pr #25, please close issue.

@levBagryansky Thanks!


Unroller basis should be explicit

Informations

Qiskit Terra version: master
Python version:
Operating system:

What is the current behavior?
Currently there is an assumption in the transpiler's unroller pass that if the circuit cannot be unrolled to the given basis, it will just unroll down to U and CX, which are universal.
However this is a bit magic, and we should move towards requiring the basis to be explicit.
Steps to reproduce the problem
from qiskit import QuantumRegister, ClassicalRegister, QuantumCircuit, BasicAer
from qiskit.transpiler import PassManager, transpile
from qiskit.transpiler.passes import Unroller

qr = QuantumRegister(4, 'q')
circuit = QuantumCircuit(qr)
circuit.h(qr[3])
circuit.cx(qr[0], qr[3])
circuit.cx(qr[3], qr[0])

simulator = BasicAer.get_backend('qasm_simulator')
pass_manager = PassManager(Unroller(basis=[]))
new_circ = transpile(circuit, simulator, pass_manager=pass_manager)

print(new_circ)

This should throw an error because the circuit cannot be unrolled to the empty basis, instead it gives this circuit:
q_0: |0>────────────────────────■──┤ X ├
                                │  └─┬─┘
q_1: |0>────────────────────────┼────┼──
                                │    │
q_2: |0>────────────────────────┼────┼──
        ┌────────────────────┐┌─┴─┐  │
q_3: |0>┤ U(1.5708,0,3.1416) ├┤ X ├──■──
        └────────────────────┘└───┘

Valid choices for the basis can be:
Unroller(basis=['h', 'cx'])
Unroller(basis=['u2', 'cx'])
Unroller(basis=['U', 'CX'])
Unroller(basis=['u2', 'CX'])
...

@Max-Reuter any update on this?

I won't be able to work on this until next Monday. If someone wants to pick it up between now and then that'd be great.

@ajavadia could you outline a case where a RecursionError would be expected so I can set up a test for it please?

@Max-Reuter Nothing I know of at the moment can trigger a RecursionError. I was just saying in principle we should catch the error where the unroller does not terminate (unroller will be changed and expanded in the future). So no test needed at the moment.

done in #1802


AutoThreadsEnabled

How do i set miner.setAutoThreadsEnabled(true) to run from the beginning?

Dirty hack: change line 38 in index.html to
<input type="checkbox" value="None" id="autoThreads" name="check" checked/>

That would be the best solution to your problem


Send Data API Format

Hi there
Is someone is able to show a example of sending data to the hub with a more "generic" way; IE not using mono or any other layer.
For example posting data to the hub just using curl or a browser URL ?
Thanks for your help

Hello @hallard
Send Event method of REST API is described there : https://msdn.microsoft.com/en-us/library/azure/dn790664.aspx . Regarding the documentation this command should work :
curl -H 'Authorization: SharedAccessSignature sr={Service Bus Namespace}.servicebus.windows.net&sig={Url Encoded Shared Access Key}&se={Time Stamp with Shared Access Key expration}&skn={Shared Access Policy name}' -H 'Content-Type:application/atom+xml;type=entry;charset=utf-8' --data '{Event Data}' https://{Service Bus Namespace}.servicebus.windows.net/{Event Hub Name}/messages

https://gist.github.com/ivanignatiev/d8fca4ff8b3f729f7337

Working on a JS sample running on node that uses the REST API. coming real soon


Touch events stop working after double click out of the carousel

Touch events stop working after double click out of the carousel. That bug can be easily reproduced in your demo.
There are reproducing steps:

You need to make double click out of the carousel component, for example it can be "Tile" label. Interval between clicks should be as short as possible.
After you had made double click, try to move carousel items, they wouldn't move.
If you click once again somewhere out of carousel component, it will work again correctly

@nilmnemonic @iamlothian checked this. This issue is only happening in chrome. Will try to fix it


[WIP] Optimize timeout statusCode

What this PR does:
timeout test bug：https://dubbogoproxy.yuque.com/dubbogoproxy/vld1hq/rfr2mf#gIX74
optimize timeout statusCode
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
dubbo 超时返回内容，我还在确定
Does this PR introduce a user-facing change?:

Codecov Report

Merging #521 (a56adee) into develop (84affca) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #521      +/-   ##
===========================================
+ Coverage    54.68%   54.69%   +0.01%
===========================================
  Files          666      666
  Lines        77865    77868       +3
===========================================
+ Hits         42577    42590      +13
+ Misses       31653    31644       -9
+ Partials      3635     3634       -1

Impacted Files
Coverage Δ

pixiu/pkg/client/dubbo/dubbo.go
21.60% <ø> (ø)

pixiu/pkg/client/http/http.go
40.69% <0.00%> (-1.48%)
:arrow_down:

...try/kube/controller/autoserviceexportcontroller.go
61.11% <0.00%> (-4.17%)
:arrow_down:

pkg/istio-agent/xds_proxy.go
60.52% <0.00%> (-1.52%)
:arrow_down:

pilot/pkg/xds/deltaadstest.go
58.51% <0.00%> (-1.49%)
:arrow_down:

...g/serviceregistry/kube/controller/endpointslice.go
73.44% <0.00%> (-0.69%)
:arrow_down:

pilot/pkg/bootstrap/server.go
53.56% <0.00%> (-0.16%)
:arrow_down:

security/pkg/nodeagent/cache/secretcache.go
85.71% <0.00%> (+0.76%)
:arrow_up:

pkg/istio-agent/agent.go
56.73% <0.00%> (+1.68%)
:arrow_up:

pilot/pkg/networking/grpcgen/lds.go
92.24% <0.00%> (+1.72%)
:arrow_up:

... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Added poetry for setup and workflow

Hey it looks like the PR was removed for some reason. But sounds good, I made it solely poetry based and also added that to the workflow as well so it would be compatible. I also bumped the version to 0.0.4. Let me know if you need me to do anything else. Thanks for taking the time to review as well!


Add exact type

As shown in: https://fettblog.eu/typescript-match-the-exact-object-shape/

This is quite similar to the type check in my implementation of DeepOmit. If this type is added, maybe it can be leveraged to simplify DeepOmit.

Released as<EMAIL_ADDRESS>


Using array of tuples instead of Dictionary for errors and validators.

For example in my project I need to get correctly ordered errors. if my first textField failed, I can scroll to that text field easily by getting first element from array or I can show onscreen error easily.
Also possible solution is to use custom struct (Ordered dictionary): http://timekl.com/blog/2014/06/02/learning-swift-ordered-dictionaries/
What do you think?

any updates?


Pub tests failing on the VM

In a full checkout the pub tests are failing on the VM.
I will work with Rico on making sure that the full set of tests are run on the buildbot.
./tools/test.py -mall pub
FAILED: none-vm debug_ia32 pub/pub_test
Expected: pass
Actual: fail
stderr:
Unhandled exception:
Expect.fail('Output line 2 was: cherry
expected:       banana')
 0. Function: 'FutureImpl._complete@924b4b8' url: 'bootstrap_impl' line:3090 col:9
 1. Function: 'FutureImpl._setException@924b4b8' url: 'bootstrap_impl' line:3112 col:14
 2. Function: 'CompleterImpl.completeException' url: 'bootstrap_impl' line:3173 col:30
 3. Function: 'FutureImpl.function' url: 'bootstrap_impl' line:3145 col:36
 4. Function: 'FutureImpl._complete@924b4b8' url: 'bootstrap_impl' line:3086 col:17
 5. Function: 'FutureImpl._setValue@924b4b8' url: 'bootstrap_impl' line:3100 col:14
 6. Function: 'CompleterImpl.complete' url: 'bootstrap_impl' line:3169 col:26
 7. Function: 'FutureImpl.function' url: 'bootstrap_impl' line:3152 col:44
 8. Function: 'FutureImpl._complete@924b4b8' url: 'bootstrap_impl' line:3086 col:17
 9. Function: 'FutureImpl._setValue@924b4b8' url: 'bootstrap_impl' line:3100 col:14
 10. Function: 'CompleterImpl.complete' url: 'bootstrap_impl' line:3169 col:26
 11. Function: '::checkComplete' url: 'file:///home/ager/dart/dart/utils/pub/io.dart' line:275 col:23
 12. Function: '_StringInputStream@14117cc4._onClosed@14117cc4' url: 'dart:io' line:6302 col:26
 13. Function: '_SocketInputStream@14117cc4._onClosed@14117cc4' url: 'dart:io' line:7940 col:26
 14. Function: '_SocketBase@14117cc4._multiplex@14117cc4' url: 'dart:io' line:7310 col:25
 15. Function<EMAIL_ADDRESS>url: 'dart:io' line:7423 col:59
 16. Function: '_ReceivePortImpl@6be832b._handleMessage@6be832b' url: 'dart:isolate' line:288 col:22

This issue has been moved to dart-lang/pub#37.


Abort due to deadlock encountered when running gpu-random-test-wbL2 [GPU Daily Test Failure]

Describe the bug
The Daily testlib-long-tests (gpu) tests have been failing: https://github.com/gem5/gem5/actions/runs/6912511984/job/18808339821
The tests that fail are ruby-gpu-random-test-wbL2-nightly-VEGA_X86-x86_64-opt and ruby-gpu-random-test-wbL2-perCheckin-VEGA_X86-x86_64-opt.
They both fail with exactly the same panic:
src/mem/ruby/system/GPUCoalescer.cc:314: panic: Aborting due to deadlock!

Revisions affected and candidate breaking commits
This was seen on the develop branch. The earliest known commit to have this bug is db6a8697864564aab1a11081edc05152c0478f83, found in this failing Daily Test: https://github.com/gem5/gem5/actions/runs/6901014917/job/18783093263.
The last commit known to not to contain this bug is ceabe86b311e3bdd7603b4e4631d2ed18365a5bd.
Based on a basic git rev-log of this information (git rev-list --oneline ceabe86..db6a869) the candidate breaking commits are:

db6a869786 mem-cache: Prefetchers Improvements (#564)
4ca2efac16 mem-ruby: AtomicNoReturn should check comp_anr instead of comp_wu (#545)
4965367724 mem-ruby, gpu-compute: fix SQC/TCP requests to same line (#540)
bfe899e48e stdlib, resources: Update JSON data in workload (#532)
047a494c2b mem-cache: Optimize strided prefetcher address generation
2abd65c270 mem: added distance parameter to stride prefetcher
c3326c78e6 mem-ruby, gpu-compute: fix SQC/TCP requests to same line
065ddf759f mem-ruby, gpu-compute: fix bug with GPU bypassing loads
38045d7a25 mem-cache: Added clean eviction check for prefetchers.
6416304e07 mem-cache: Update default prefetch options.
8598764a03 mem-cache: Squash prefetch queue entries by block address.
50c9cbf613 stdlib, resources: Fixed deprecation warning

To Reproduce
scons build/VEGA_X86/gem5.opt -j`nproc`
./build/VEGA_X86/gem5.opt configs/example/ruby_gpu_random_test.py --WB_L2 --test-length 50000 --num-dmas 0

Terminal Output
Here is a copy of the stderr (note: stdout not shown):
warn: system.ruby.network adopting orphan SimObject param 'ext_links'
warn: system.ruby.network adopting orphan SimObject param 'int_links'
warn: rounding error > tolerance
    1.250000 rounded to 1
warn: rounding error > tolerance
    1.250000 rounded to 1
warn: rounding error > tolerance
    1.250000 rounded to 1
warn: rounding error > tolerance
    1.250000 rounded to 1
warn: rounding error > tolerance
    1.250000 rounded to 1
warn: rounding error > tolerance
    1.250000 rounded to 1
warn: rounding error > tolerance
    1.250000 rounded to 1
warn: rounding error > tolerance
    1.250000 rounded to 1
src/mem/dram_interface.cc:690: warn: DRAM device capacity (8192 Mbytes) does not match the address range assigned (1024 Mbytes)
src/cpu/testers/gpu_ruby_test/protocol_tester.cc:140: warn: Data race check is not enabled
src/cpu/testers/gpu_ruby_test/protocol_tester.cc:150: warn: If `random_seed == 0` (or `random_seed` is unset) ProtocolTester does not seed the RNG. This will NOT result in the RNG generating different results each run. In this case the RNG is seeded by a default value. This differs from behavior in previous versions of gem5. Setting `random_seed` to a non-zero value is strongly recommended.
src/base/statistics.hh:279: warn: One of the stats is a legacy stat. Legacy stat is a stat that does not belong to any statistics::Group. Legacy stat is deprecated.
src/sim/simulate.cc:194: info: Entering event queue @ 0.  Starting simulation...
src/mem/ruby/system/GPUCoalescer.cc:312: warn: GPUCoalescer 0 Possible deadlock detected!
Printing out 1 outstanding requests in the coalesced table
	Addr: [0x4fc80, line 0x4fc80]
	Instruction sequence number: 12
		Type: ATOMIC_RETURN
		Number of associated packets: 1
		Issue time: 1367
		Difference from current tick: 998634
Listing pending packets from 0 instructions
src/mem/ruby/system/GPUCoalescer.cc:314: panic: Aborting due to deadlock!
Memory Usage: 1376440 KBytes
Program aborted at tick 1000001
--- BEGIN LIBC BACKTRACE ---
/__w/gem5/gem5/build/VEGA_X86/gem5.opt(_ZN4gem515print_backtraceEv+0x30)[0x56362f91b440]
/__w/gem5/gem5/build/VEGA_X86/gem5.opt(_ZN4gem512abortHandlerEi+0x4c)[0x56362f94762c]
/lib/x86_64-linux-gnu/libc.so.6(+0x42520)[0x7f1fd6231520]
/lib/x86_64-linux-gnu/libc.so.6(pthread_kill+0x12c)[0x7f1fd6285a7c]
/lib/x86_64-linux-gnu/libc.so.6(raise+0x16)[0x7f1fd6231476]
/lib/x86_64-linux-gnu/libc.so.6(abort+0xd3)[0x7f1fd62177f3]
/__w/gem5/gem5/build/VEGA_X86/gem5.opt(+0xd8b4c5)[0x56362f89c4c5]
/__w/gem5/gem5/build/VEGA_X86/gem5.opt(_ZN4gem54ruby12GPUCoalescer6wakeupEv+0x27f)[0x5636304e59cf]
/__w/gem5/gem5/build/VEGA_X86/gem5.opt(_ZN4gem510EventQueue10serviceOneEv+0xc2)[0x56362f933412]
/__w/gem5/gem5/build/VEGA_X86/gem5.opt(_ZN4gem59doSimLoopEPNS_10EventQueueE+0x68)[0x56362f96d728]
/__w/gem5/gem5/build/VEGA_X86/gem5.opt(_ZN4gem58simulateEm+0x27b)[0x56362f96dd1b]
/__w/gem5/gem5/build/VEGA_X86/gem5.opt(+0x257ff90)[0x563631090f90]
/__w/gem5/gem5/build/VEGA_X86/gem5.opt(+0xd69634)[0x56362f87a634]
/lib/x86_64-linux-gnu/libpython3.10.so.1.0(+0x12b6d3)[0x7f1fd71776d3]
/lib/x86_64-linux-gnu/libpython3.10.so.1.0(_PyObject_Call+0x5c)[0x7f1fd713322c]
/lib/x86_64-linux-gnu/libpython3.10.so.1.0(_PyEval_EvalFrameDefault+0x4b26)[0x7f1fd70c2766]
/lib/x86_64-linux-gnu/libpython3.10.so.1.0(+0x1c681f)[0x7f1fd721281f]
/lib/x86_64-linux-gnu/libpython3.10.so.1.0(_PyEval_EvalFrameDefault+0x9d78)[0x7f1fd70c79b8]
/lib/x86_64-linux-gnu/libpython3.10.so.1.0(+0x1c681f)[0x7f1fd721281f]
/lib/x86_64-linux-gnu/libpython3.10.so.1.0(PyEval_EvalCode+0xbe)[0x7f1fd720d94e]
/lib/x86_64-linux-gnu/libpython3.10.so.1.0(+0x1c1edd)[0x7f1fd720dedd]
/lib/x86_64-linux-gnu/libpython3.10.so.1.0(+0x12eb13)[0x7f1fd717ab13]
/lib/x86_64-linux-gnu/libpython3.10.so.1.0(_PyEval_EvalFrameDefault+0x69ee)[0x7f1fd70c462e]
/lib/x86_64-linux-gnu/libpython3.10.so.1.0(+0x1c681f)[0x7f1fd721281f]
/__w/gem5/gem5/build/VEGA_X86/gem5.opt(+0xe38677)[0x56362f949677]
/__w/gem5/gem5/build/VEGA_X86/gem5.opt(main+0x213)[0x56362f7ebf93]
/lib/x86_64-linux-gnu/libc.so.6(+0x29d90)[0x7f1fd6218d90]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x80)[0x7f1fd6218e40]
/__w/gem5/gem5/build/VEGA_X86/gem5.opt(_start+0x25)[0x56362f86abb5]
--- END LIBC BACKTRACE ---
For more info on how to address this issue, please visit https://www.gem5.org/documentation/general_docs/common-errors/

Host Operating System
This was run in a docker image (ghcr.io/gem5/ubuntu-22.04_all-dependencies:latest) on top of an Ubuntu 22.04 OS.
Host ISA
X86

@mattsinc @abmerop : Bringing this to your attention.

Thanks for taking the lead on this @abmerop

The test appears to be passing now thanks to #585. Closing.


Evp documentation pass

Contributes documentation to the EVP module, mainly in the form of man page updates to the private key params control operations.
The actual function description is a summary of my understanding of the pkey_<alg>_ctrl implementations and specific algorithm parameter documentation in genpkey(1) and pkeyutl(1).
This brings the missing EVP functions docs down to 82 compared to #5193.
Checklist

[x] documentation is added or updated

I intentionally did not document the get functions since it seems like all the relevant information is already contained in the set function description and it would only generate noise to repeat that information a second time. What do you think?
Regarding the doc-nits errors, what do I need to do exactly? Should all these macros just be added to private.num or is there something else to do?

I intentionally did not document the get functions since it seems like all the relevant information is already contained in the set function description and it would only generate noise to repeat that information a second time. What do you think?

I think we generally do document both the getter and the setter. I'd rather be complete.

Regarding the doc-nits errors, what do I need to do exactly? Should all these macros just be added to private.num or is there something else to do?

Yes, for each macro that its complaining about you need to add a line in private.num

Pushed updates addressing most of Matt's comments, except the OID parameter usage (needs more clarification).

Do you have a link to the latest ANSI X9.63 working draft? I haven't been able to find anything other than the 1998 version.

Added the suggested OID description and rebased the branch on current master.
As Matt suggested, I added a EVP_PKEY_ECDH_KDF_X9_63 alias in the ec.h header. Is this considered an API change? I guess it is not too important since the next version is planned to be a major release.

As Matt suggested, I added a EVP_PKEY_ECDH_KDF_X9_63 alias in the ec.h header. Is this considered an API change?

We're always allowed to add symbols from one release to the next, so this is fine.

I can squash all commits once the initial round of feedback has been addressed.
Also is worth adding an entry in CHANGES about the doc cleanup and the new KDF define?

Also is worth adding an entry in CHANGES about the doc cleanup and the new KDF define?

I would suggest one about depreciating *62 and renaming to private *63 methods.
Not sure about writing a CHANGES entry regarding updated documentation

What is the procedure to deprecate functionality?
In general for internal macros and functions is the guideline to write documentation at the declaration or the implementation? Looking at some examples in the code, it seems like the standard procedure is to keep it in the headers.

I think we should squash all the commits, and add the deprecation macros in a separate commit. Then we backport the documentation fixes to 1.1.1, and keep the deprecation macro commit in master only.

I think we should squash all the commits, and add the deprecation macros in a separate commit. Then we backport the documentation fixes to 1.1.1, and keep the deprecation macro commit in master only.

In light of this I would say that we need 2 CHANGES entries: one about renaming *62 to *63 that is going to be back ported to 1.1.1, and a second one in the "deprecation commit" saying that the old 62 was deprecated.
I would still like to have the comment about the rationale for *62 being a abi compatibility wrapper around *63 added also where the implementation is: it will make things easier when reviewing that code in the future until we can actually remove the function.

I forgot to rename the function to the lowercase variant, let me just do that.

Everything should be good now, thanks for your help.

I can take care of merging it if you want.

Great - thanks.

Regarding merge to 1.1.1 for the first commit: it will definitely require massaging for the CHANGES entry: I could easily do it manually during merge, but I just want to make sure that would be ok, or if that change would warrant a separate PR with separate approval.

Assuming the changes are trivial, then no need for a separate PR.
BTW, kudos to @evqna for this PR. This is a significant contribution to the documentation!!

Merged:

master:

ffd8912
9453b19

1.1.1-stable

8710396

Thanks again @evqna for your contribution, I cannot say it with better words than @mattcaswell's :

kudos to @evqna for this PR. This is a significant contribution to the documentation!!

As the creator of issue #5193, I'd like to join in to the laudation of Matt and Nicola :-)

Thanks everyone!


The Python version plays an important role!

The Python version plays an important role!
Now, we dosn't need this step anymore, because every Linux distribution uses a newer Python version now and so I think it's also important to check also a newer Python version with Autodesk Fusion 360 here on Linux. :-)

Hi, is this necessary?  Installer run its own version of python (3.7).

Yes this is necessary as it will force the installer to run even if it does not detect a Windows OS. This has nothing to do with the Python version it just downloaded a unfuckedup version of platform.py from pythons so it does not have to use the one from autodesk wich will not let us run the installer in linux or mac. then it makes sure to run the installer.

I'm referring to issue #12 as newest installers does not contain broken 'platform.py'. I reinstalled fusion a week ago and it worked without this.


Adds jemalloc 5.2.1, allow --disable-shared to be specified

Updates the jemalloc submodule to version 5.2.1

Updates the pre-generated configure script based on jemalloc 5.2.1

Adds a JEMALLOC_SYS_DISABLE_SHARED which prevents a build error with using musl-gcc:

  --- stderr
  configure: WARNING: using cross tools not prefixed with host triplet
  ar: `u' modifier ignored since `D' is the default (see `U')
  /usr/bin/ld: src/jemalloc.pic.o: relocation R_X86_64_32 against `.rodata.malloc_conf_error.str1.1' can not be used when making a shared object; recompile with -fPIC
  /usr/bin/ld: src/arena.pic.o: relocation R_X86_64_32S against hidden symbol `_rjem_je_h_steps' can not be used when making a shared object
  /usr/bin/ld: src/background_thread.pic.o: relocation R_X86_64_32S against hidden symbol `_rjem_je_h_steps' can not be used when making a shared object
  /usr/bin/ld: src/base.pic.o: relocation R_X86_64_32S against undefined hidden symbol `_rjem_je_sz_size2index_tab' can not be used when making a shared object
  /usr/bin/ld: src/bin.pic.o: relocation R_X86_64_32 against undefined hidden symbol `_rjem_je_bin_infos' can not be used when making a shared object
  /usr/bin/ld: src/ckh.pic.o: relocation R_X86_64_32S against undefined hidden symbol `_rjem_je_sz_size2index_tab' can not be used when making a shared object
  /usr/bin/ld: src/ctl.pic.o: relocation R_X86_64_32 against `.rodata.super_arenas_bin_i_node' can not be used when making a shared object; recompile with -fPIC
  /usr/bin/ld: src/extent.pic.o: relocation R_X86_64_32 against undefined hidden symbol `_rjem_je_extents_rtree' can not be used when making a shared object
  /usr/bin/ld: src/hook.pic.o: relocation R_X86_64_32 against `.rodata._rjem_je_hook_boot.str1.1' can not be used when making a shared object; recompile with -fPIC
  /usr/bin/ld: src/large.pic.o: relocation R_X86_64_32S against undefined hidden symbol `_rjem_je_arenas' can not be used when making a shared object
  /usr/bin/ld: src/log.pic.o: relocation R_X86_64_32 against undefined hidden symbol `_rjem_je_log_var_names' can not be used when making a shared object
  /usr/bin/ld: src/malloc_io.pic.o: relocation R_X86_64_32S against `.rodata._rjem_je_malloc_strtoumax' can not be used when making a shared object; recompile with -fPIC
  /usr/bin/ld: src/mutex.pic.o: relocation R_X86_64_32 against `.rodata._rjem_je_malloc_mutex_postfork_child.str1.8' can not be used when making a shared object; recompile with -fPIC
  /usr/bin/ld: src/pages.pic.o: relocation R_X86_64_32 against `.rodata._rjem_je_pages_map.str1.8' can not be used when making a shared object; recompile with -fPIC
  /usr/bin/ld: src/prof.pic.o: relocation R_X86_64_32 against undefined hidden symbol `_rjem_je_extents_rtree' can not be used when making a shared object
  /usr/bin/ld: src/rtree.pic.o: relocation R_X86_64_32 against `.rodata._rjem_je_rtree_new.str1.1' can not be used when making a shared object; recompile with -fPIC
  /usr/bin/ld: src/stats.pic.o: relocation R_X86_64_32S against `.rodata.mutex_stats_init_cols.str1.1' can not be used when making a shared object; recompile with -fPIC
  /usr/bin/ld: src/sz.pic.o: relocation R_X86_64_32S against undefined hidden symbol `_rjem_je_sz_pind2sz_tab' can not be used when making a shared object
  /usr/bin/ld: src/tcache.pic.o: relocation R_X86_64_32S against undefined hidden symbol `_rjem_je_arenas' can not be used when making a shared object
  /usr/bin/ld: src/tsd.pic.o: relocation R_X86_64_32 against `.bss.tsd_nominal_tsds_lock' can not be used when making a shared object; recompile with -fPIC
  /usr/bin/ld: src/witness.pic.o: relocation R_X86_64_32 against `.rodata.witness_lock_error_impl.str1.8' can not be used when making a shared object; recompile with -fPIC

When will this Pull Request be integrated?

@silence-coding this crate/repo appears to be unmaintained, the owner @gnzlbg doesn't seem to be responding to pull requests or issues

@silverjam So sad, is there any other more active crate

A great open source who hasn't been active for so long.

@king6cong @davidMcneil @slightlyoutofphase @imp @brson @athre0z @alexcrichton anyone know how to contact @gnzlbg?  Maybe it's time to move this project to an org. or just add some more people as maintainers?  Maybe some recent contributors would be interested in helping to maintain the project @rocallahan, @kamulos, @abbccdda, or @BusyJay. I see that @BusyJay has already forked the project to https://crates.io/crates/tikv-jemallocator and reduced the number of platforms that the project supports.

seems like rustc switched to tikv-jemallocator: rust-lang/rust/commit/3965773ae7743e051070b4eed3c6e02e9df3b25c

seems like rustc switched to tikv-jemallocator: rust-lang/rust@3965773

Ah, ok, that seems like a fairly good endorsement

It's a little worrying that rust switched over to tikv-jemalloc seemingly without consulting the maintainers. PingCAP is pretty sloppy about maintaining libraries for any purpose other than their own (I say this as a member of PingCAP). I'd be cautious.

Somebody might want to talk to @BusyJay about the tikv-jemallocator and what kind of support pingcap wants to provide for it.

tikv-jemallocator only supports desktop/server usage as stated in README. I will support the crate for bug fixes concurrently, and upgrading to newer jemalloc when the upsteam gets a stable release. Features development is under low priority until rust allocator APIs are stable.

@brson there appeared to be some discussion on the pr where I add sized dealloc for rust, but you are right that the maintainers of jemallocator itself were not consulted. If we feel that the maintenance contract that @BusyJay laid out above is not sufficient, it should be very easy to switch rust to these crates over the tikv ones, with no regressions as long as we have 5.2.1+


Fix various pieces of undefined behavior

I caught these running the gperftools tests with ubsan and maybe msan (don't remember if ubsan or msan caught uninitialized values first).

Thanks. Not sure about last commit, yet, since it introduces dependency on C++11 feature I think.

Are you talking about the variadic macro? I didn't think about it before, but looking around it appears that isn't even standard C++11; it's a GCC extension... This Stack Overflow question basically says there isn't a standard way of doing it. How about just declaring the IncrementCallsTo##hook_type functions separately?

Yes. Feel free to fix it. I'll take all commits before last.

Actually C99 variadic macros are support by msvc 2013 and older gccs.
So that's workable approach I think.

Leaving it up to you anyways.

Sounds good to me. I was ignoring that because C99 variadic macros have no good way to handle "no arguments", but then I realized none of those functions actually have that problem... Done

Thanks a lot. All applied.


Fix API doc for Field component

It's frustrating that the docs for the fundamental <Field> component is so messed up.

The docs in general, are quite chaotic.
Formik:  https://jaredpalmer.com/formik/docs/api/formik
There are two kind of props here: the ones for <Formik> , and the ones that are passed by Formik to the render function.
It's hard to distinguish them

More in https://jaredpalmer.com/formik/docs/api/field
field: An object containing onChange, onBlur, name, and value of the field (see FieldInputProps)
form: The Formik bag
meta: An object containing metadata (i.e. value, touched, error, and initialValue) about the field (see FieldMetaProps)

The two "see..." parentheses, have broken links.
And "Formik bag" should have some (preferably non broken) link that explains what a Formik bag is.

You are free to open a PR with these revisions!

@johnrom  I'll try to summit some fixes - but the problem is that to fix the docs we need to understand the API, and to understand the API we need ... to read the docs (unless we are Formik developers).
I cannot correct the inconsistencies because I don't know which of the contradicting informations are right. In particular, I'd love to know if "component" is actually deprecated for Field,...but I don't know.

@leonbloy I think I found the answer to this question in an old issue -- component was briefly deprecated, but then intentionally un-deprecated for reasons cited below. The issue also has a great explanation of the difference between as and component, which could really use some clarification in the documentation. See: https://github.com/formium/formik/issues/1371#issuecomment-497957324

Why shouldn't components gets metas ? In the code there is this comment before creating component in Field :
// We don't pass meta for backwards compat
Why would that be an issue ?
I would really like to use components on Field as it's way cleaner. I just moved from redux-form and all my Fields are components.