Exploratory - Do Not Merge!

Exploring whether the build for this still seemingly works, at a base level. Profile targets won't do anything, but does it still build and run a bit?

XBuild has some problems:

ToolsVersion 14 doesn't exist in mono
ToolsVersion 4.0 doesn't support .NET 4.5.2

Looks like AppVeyor is also unhappy.

Yes, that was the kind of exploration that interested me :) I'm not sure how you're even supposed to do xplat portable at the moment. I don't know whether it's even a thing, and trying to work out the story and portable in general is like punching smoke. Still, interesting to see how it gets more or less fixed over time...

Right, so AppVeyor is now happy (and after a switch to xunit, which I'm having better results with these days, and is now used in Aether, Chiron, etc. with much better support for FsCheck, etc.)
I've got no clue what you're supposed to do about travis though at the moment, may just park that aspect until I've got proper time to look at it! For 3.0 maybe...

So, the latest version is now portable (profile259) as well as net40. The packages produced now contain two sets of assemblies, etc. I've also updated the naming in here to be more F# like, in that static members on types (which are effectively similar to module level functions) are named like module level functions (camelCase rather than PascalCase), to feel more native. This applies to the common format, parse and tryParse functions, as well as any type level optics.
I'm not sure what to do about travis, as i'd like to get this merged in, and a first pre-release out to start playing with Freya 3.0-bXXX. I don't know how long it's going to be before some kind of xbuild can support the kinds of solution/projects required to do xplat portable libs.
Temporarily, I'm going to ignore/disable the travis builds and merge this anyway. It's not great and i'm not pleased, but i'm not sure what more can be done today.

@kolektiv probably best to not build the PCL on Travis.

I'll send a PR to disable PCL builds if I can sort it out.


How can I distinguish several different DICOM series which in a same directory?

Thanks for your work and share.
Here I have several different DICOM series, they are all in a same directory. I want to use these code to identify different DICOM image:
imageReader = sitk.ImageSeriesReader()
dicom_names = imageReader.GetGDCMSeriesFileNames(path)
print(dicom_names )

Then I found I can only get the first image.
I wonder how can I identify them, and get the right image I want?
Thank you !

You will first need to get the list of series ids in the directory:
series_ids = imageReader.GetGDCMSeriesIDs(path)
Then you select the relevant series (somehow), and get the specific file names associated with it:
i=3
imageReader.GetGDCMSeriesFileNames(path, series_ids[i])

For an example with a dropbox see this Jupyter notebook.
You may be interested in the examples shown in the notebooks in general, see the main notebook repository.

Thanks a lot! It works!
BTW, here is a new question. After I read a DICOM series, I want get the meta data with it:
imageReader= sitk.ImageSeriesReader()
imageReader.LoadPrivateTagsOn()
series_ids = imageReader.GetGDCMSeriesIDs(path)
series_file_names = imageReader.GetGDCMSeriesFileNames(path, series_ids [0])
imageReader.SetFileNames(series_file_names)
image = imageReader.Execute()  # type: sitk.Image
print(image.GetMetaDataKeys())

But it returns an empty list, what should I do?
Thank you !

Three points:

In SimpleITK, the returned image will not have a meta data dictionary - rationale: this is most often a 3D image where each of the 2D images from which it was created had a separate meta-data dictionary. We can't know how to combine them together (there is slice specific information in each).

To access the meta-data keys and information on a per-slice basis you have three functions, as illustrated below:

slice_number = 0
slice_keys = imageReader.GetMetaDataKeys (slice_number)
imageReader.HasMetaDataKey(slice_number, '0010|0010')
imageReader.GetMetaData(slice_number, '0010|0010')

You are missing a line before "LoadPrivateTagsOn" which tells the reader to actually load the tags:
imageReader.MetaDataDictionaryArrayUpdateOn()

Thank you for your time. It helps a lot!
I've solved my problem.


StandardKafkaProducer will fail with an XML payload

If the header/value or message/value is XML data then the sax parser will fire startElement and endElement events for the payload rather than just characters() as it would for json/text.
It may need to use something like AbstractSamplingFilter to transform the payload xml into a byte stream or similar. The ReferenceDataFilter does a similar thing as it has to deal with string or xml payload.

Anticipated behaviour has been confirmed.  Believe its possible to fix with more sophisticated state processing logic in StandardKafkaProducer.

You shouldn't need to manually craft XML with chevrons.  Just pass any sax events over to an AbstractSamplingFilter to handle while you are inside the value elements. Then at the end of the value element get the output stream from the ASF.


Add cyclic loading abstraction to ResourceLoader

This creates an abstraction for ResourceLoader and ResourceFormatLoader to load cyclic resources, ie. ressources currently loading that normally returns a null Resource when queried.
Supersedes #71004
Fixes #70985
Fixes #71610

@akien-mga @vnen The code now tests if the file can be loaded. If so, the error is changed to be a cyclic load error.
It will not affect other loaders and there's no presumption to be done about ERR_FILE_CANT_OPEN.
https://github.com/godotengine/godot/blob/b288a60e51b95dfc433cc705ba9ba519d14d2d9f/modules/gdscript/gdscript.cpp#L2651-L2670

My PR fixes #71610 too.

I am still not convinced in the approach or whether this a problem, if you cyclic preloads() with scenes, then you will not be able to easily free them eventually. I think its correct that it fails and should not be fixed.

@reduz If I would happen to create a global scope function to free cyclic references, like you wanted to implement, would this PR legitimacy be impacted positively?
The usage of the issue #70985 seems to be legitimate. a.gd is loaded, refers to b.gd that preloads a.tscn scene that a.gd happens to be the script. It causes that the a.tscn scene will lose it's script.
I'll suggest the creation of the Squirrel-like function tomorrow at our GDScript meeting.

@adamscott Circular reference for scripts should be valid to some extent, because you can have a reference to the parser code (at least how it was meant to be implemented when we discussed about this with @vnen) however cyclic reference for resources is not because its way too difficult to fix and extremely error prone. As such the use case described in the linked issue should always be considered a bug.

Creating code that checks scripts and see if they contain cyclical references and eventually break them is not very difficult, because all you have to do is eliminate the script from the objects that contain it (hence the cyclical link breaks).
Extending this to the whole resource system is extremely inefficient and would force users to have to do this check for cyclical inclusion errors constantly when instead you can just prevent them on load.

Closing this PR. The GDScript team will have to discuss how to fix this issue otherwise, taking @reduz comments into account.


Feature / Project Request

Hello - Big ask, feel free to say no, but seeing as you may have some expertise in this area, do you think you could make a highlight.js plugin for MELFA-Basic?
https://highlightjs.readthedocs.io/en/latest/language-guide.html
At the moment, im usingbasic as a stand-in, which is fine, but obviously full melfa would be great.

Just out of curiosity, why do you use highlight.js? Maybe it has a useful feature that VSCode misses?

I have a technical documentation website for teaching robotics pneumatics etc.
We have some tutorials that cover programming mitsubishi robots, and want to include code snippets
Highlight.js is not an editor, it's a way of highlighting code snippets

Good news, I started working on your request. You can find it on zserub/MELFA-highlight.js, hopefully it won't take much time to finish.


Add parallax effect to the AnimatedFastImage

I'm in need to create a horizontal parallax effect to the animated fast images. Need some help with it the react-native-reanimated-v2and the Fast Image is within the react-native-swiper component. Below is the code example -
`  const postImageParallax = useSharedValue(0);
const { width, height, item, index, postImageParallax } = props;
const AnimatedFastImage = Animated.createAnimatedComponent(FastImage);

const verticalSpeed = Math.abs(height * 0.5 - height)

const postImageParallax_translate_y = useDerivedValue(() => {
    return interpolate(postImageParallax.value, [(index - 1) * height, index * height, (index + 1) * height],
        [-verticalSpeed, 0, verticalSpeed], Extrapolate.CLAMP)
});

const postTransformParallax = useAnimatedStyle(() => ({ transform: [{ translateY: postImageParallax_translate_y.value }] }));

return (
    <Animated.View key={`${index}_${item.categoryId}`}>
        <AnimatedFastImage style={[{ width: width, height: height }, postTransformParallax]} source={{
            uri: item.postImage,
            priority: FastImage.priority.normal,
            resizeMode: FastImage.resizeMode.cover,
            cache: FastImage.cacheControl.immutable
        }} />
    </Animated.View>)`

Please help in getting the right image positioning for the fast image to get the parallax between the images.

Seems like AnimatedFastImage approach doesn't work, so you need to wrap it inside an Animated.View.


scripts/install: make exporting easier for users

This PR shows users the explicit command to add $PORTER_HOME to their path.

Thanks @anubhavmishra!!


Potential fix for segfault on macOS in homebrew-provided Python

Since we moved to installing gfpgan and transformers from PyPi (as opposed to compiling them from source), we no longer need to provide a path to CPython headers. brew seems to be finicky when trying to use headers from an unexpected location:
https://docs.brew.sh/Homebrew-and-Python#homebrew-provided-python-bindings

Warning! Python may crash (see Common Issues) when you import  from a brewed Python if you ran brew install <formula_with_python_bindings> against the system Python. If you decide to switch to the brewed Python, then reinstall all formulae with Python bindings (e.g. pyside, wxwidgets, pyqt, pygobject3, opencv, vtk and boost-python).

Notably, this list includes opencv as well. No idea if that's significant.
I tested this change on an M1 (Ventura) system, and was able to both install, and generate images without segfault, with both homebrew python (3.10) and system Python (3.9).
I did not test with conda, given that we no longer support it as an install method. but it's likely going to work fine because we never needed to provide header paths in conda envs anyway.
(Hopefully) Fixes #1941

I tested this on virgin MacOS, where it did not work without adding the CPP Headers. But I will again create a virgin system and try to do it again.

Not sure I was not choosen to verify this while being a mac owner and having the tools to set up a virgin Mac VM, but I just tested it on a freshly installed VM and it was working!

Probably just didn't cross his mind when he made the PR. He did a quick fix and the went to bed. All good. Thanks for the verification.

Not sure I was not choosen to verify this while being a mac owner and having the tools to set up a virgin Mac VM, but I just tested it on a freshly installed VM and it was working!

It's not always clear who to choose as a reviewer. I often choose reviewers based on who I think will be awake at the time. If you see a PR that you can help with, just self-assign, as you did in this case. If you are asked to review and it isn't your area of expertise, leave a comment to let the PR owner know that you decline. Eventually everyone will get to know each others' strengths.

I'll merge when the checks are through.

wouldn't be necesarry with "auto-merge" ;P

Until we're fully isolated from Main touching users systems without a git pull, I'm against merge automatically.

Note that after this merges, @lstein has to create a new macintosh .zip file.

@mauwii I chose @lstein and @blessedcoolant for review because they were involved in troubleshooting the issue as well as subsequent conversation in Discord about it. Also, as per Github suggestion.
I'll make sure to add you as a reviewer for future PRs that require manual testing on macOS.

Until we're fully isolated from Main touching users systems without a git pull, I'm against merge automatically.

I agree with @hipsterusername that auto-merging is dangerous and we shouldn't enable it lightly. Makes is way too easy to inadvertently merge a breaking change into main. I'd recommend to err on the side of safety vs velocity in this case.

how would it merge a breaking change when test validation fails?


Fix var overrides

Temporary fix USWDS default variables

This temporarily changes the USWDS dependency to my own branch so
that variables can be override. More information on the problem here:
https://github.com/18F/web-design-standards/issues/952

Can be reverted back when this is complete:
https://github.com/18F/web-design-standards/pull/953.

:shipit:
Not merging because I wasn't sure if you meant for this pull request to be done against master...?

Yea @afeld you're correct, I wanted it done against staging, will redo


Fix too many auth code requests error

Fixes #186
Changes

Now shows toast error message to user when too many requests error is received for userRequestAuthCode call is made

The block duration is currently different depending on whether the user has hit the IP block or the phone number block.  You can see the current durations here.  They both seem pretty extreme to me - especially the IP based one as I've seen this trigger before on mobile networks where users sometimes share IP addresses.

Also I've yet to test this change on android because I couldn't get the emulator running on my local computer (complaining about missing adb).  Still working on it.

I finally got the Android emulator running locally.  I had to update the compileSdkVersion to 31 to get it to work.

I finally got the Android emulator running locally. I had to update the compileSdkVersion to 31 to get it to work.

does it have any drawback? like no longer being compatible with old android version?

does it have any drawback? like no longer being compatible with old android version?

It should be okay since the minSDKVersion is still the same (21). I made the same change in my pr.


fix: Fix Checkbox toggling twice on space bar key on Firefox

Closes #368

Codecov Report

Merging #369 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
- Coverage   93.36%   93.35%   -0.01%
==========================================
  Files         125      125
  Lines        1672     1671       -1
  Branches      527      525       -2
==========================================
- Hits         1561     1560       -1
  Misses        110      110
  Partials        1        1

Impacted Files
Coverage Δ

packages/reakit/src/Tabbable/Tabbable.ts
87.93% <100%> (-0.21%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc5ae58...23e0d81. Read the comment docs.


Please invite me to the GitHub Community Organization

Name
Priyanshu Verma
Checklist ✅

[X] I have followed the organisation.
[X] I will abide by all the global rules stated here.
[X] NOTE: Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. Do this by finding your name in the GitHub organisation list and change the dropdown to public.

@rahulaarora @tamalCodes @Anmol-Baranwal @HimanshuNarware

Hi @priyanshuverma-dev
I don't have the access. Only Tamal can do that :)

The bot should have automatically invited you, and closed this issue- looks like it aint' working no more lol


[KYUUBI #1369] Remove _config.yml

Why are the changes needed?

Close #1369.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #1375 (0300707) into master (1554032) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1375   +/-   ##
=========================================
  Coverage     79.14%   79.14%
  Complexity      110      110
=========================================
  Files           182      182
  Lines          7671     7671
  Branches        936      936
=========================================
  Hits           6071     6071
  Misses         1093     1093
  Partials        507      507

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1554032...0300707. Read the comment docs.

Thanks, merging to master


Implement Reactive Streams for JDK Streams and jOOλ Seq

FutureStreamSubscriber can already produce JDK 8 Streams from a Reactive Streams subscription, it just needs to be exposed.

The FutureStreamPublishers can be adapted to convert JDK 8 Streams /  jOOλ Seq's into FutureStreams before publication.

Released in v0.98


[HOLD] Merchant required is missing translation

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jmills
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706197140618429
Action Performed:

Choose Request money
Enter any amount
Choose any workspace
Try to request without entering a merchant

Expected Result:
No missing translation is shown
Actual Result:
Missing translation shown
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub

I can repro with my @expensify.com email. If surfacing Missing Translation is the issue, I think it's being worked on here. We could probably put this on hold until that PR gets deployed @JmillsExpensify - thoughts?

Missing Translation PR looks to be merged soon

Missing Translation PR has been deployed to production and this issue looks to be solved!


Add filters filters for new buttons to filter out the internships on the basis of role and industry

Issue Fixes #478
Added the new filter for sorting out the internships based on Role and Industry
-Made changes in the DataBase.json file according to the filters
-Updated the CSS portion to make filters according to the layout and style of the website
-Updated according to the earlier reviewed changes
Features:
-The filter shows default internships even without selecting any filter
-It filters out the internships when any role/ industry is selected
-the style of the filter matches with the page
Here is the attached image below :

Hello @HimanshuNarware can you review it now

Can you improve the ui of select tag, like spacing of options in drop down, colour and size of select tag, also show not found or something like that if no results available for selected option @nikki-05

Can you improve the ui of select tag, like spacing of options in drop down, colour and size of select tag, also show not found or something like that if no results available for selected option @nikki-05

Sure sir

is it okay now?
or if any more changes are needed please do guide.

Fixes #418


Tests fail when using .client components

I have some components that include "client" components (i.e. ClientComponent.client.vue).  When I run tests for components that include client components, they always seem to fail with messages like this:
[Vue warn]: Component <Anonymous>: setup function returned a promise, but no <Suspense> boundary was found in the parent component tree. A component with async setup() must be nested in a <Suspense> in order to be rendered.
  at <ClientComponent.client>
  at <TestA ref="VTU_COMPONENT" >
  at <VTUROOT>

A simple component that I'm testing looks like this:
// TestA.vue
<template>

    <ClientComponent />

</template>

and the test file looks like this:
// TestA.spec.ts
import { describe, it, expect } from 'vitest';
import { mount } from '@vue/test-utils';
import TestA from './TestA.vue';

describe('Competition TestA', () => {
  it('renders component', async () => {
    const wrapper = mount(TestA);
    expect(wrapper.text()).toContain('Client component here...');
  });
});

Finally, the client component:
// ClientComponent.client.vue
<template>

Client component here...

</template>

If I remove the ".client" from the component file name (to make it just ClientComponent.vue), then the tests will run and pass normally.  However, there are some cases where I want to use ".client" to make sure it's only rendered client-side.
Reproduction
https://stackblitz.com/edit/github-ndby6m?file=components/TestA.spec.ts
Failures can be seen there by running pnpm run test

For this, you need to use the mountSuspended utility provided by the library - see README for details.


cute cute

Signed-off-by: Zou Rui<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6f72589). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   39.79%
=========================================
  Files             ?      172
  Lines             ?    13857
  Branches          ?        0
=========================================
  Hits              ?     5514
  Misses            ?     7471
  Partials          ?      872

Impacted Files
Coverage Δ

main.go
62.5% <ø> (ø)

ping @ZouRui89
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

ping @ZouRui89
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

ping @ZouRui89
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

ping @ZouRui89
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

ping @ZouRui89
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

ping @ZouRui89
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

ping @ZouRui89
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.


Anchors not being properly distributed across feature maps?

*Edit: based on the rpn.py documentation, it sounds like this may be intended behavior for RPN - in which case this is really more of an issue in faster_rcnn, in the way that its default anchor sizes are specified. RPN docs note that "sizes[i] and aspect_ratios[i] can have an arbitrary number of elements," but this doesn't seem to be totally true - it looks like sizes[i] must have the same number of elements for all feature maps.
https://github.com/pytorch/vision/blob/d6ee8757eca7b74b98e5f0d434a565eb7b1c410b/torchvision/models/detection/rpn.py#L122
This zip statement will result in anchors being split up across each feature map, as opposed to computing all anchors at each feature map. For example, if anchor sizes are defined as ((8,), (16,), (32,), (64,), (128,)), the first feature map will only be processed using anchors size 8, the second feature map size 16, etc. Specifying a number of anchor sizes that is different from the number of feature maps will result in a crash, since the number of anchors and output predictions will not match.

Are you suggesting to rephrase the documentation? Do you want to open a pull request to clarify this?

@csmonnier I propose we improve the documentation.
The current assumption is that we provide the same number of base anchors for each feature map.

@fmassa  Are you'll looking for someone to help here?
I am currently working on anchor boxes and would like to help if that is the case


Latest update not added to flatpak after more than 24 hours

Not sure if this is intended, however after checking the GitHub page it seems it isn't.
On the start screen you get the notification "A newer release of osu! has been found (2022.1101.0 → 2022.1117.0).". The update has been added yesterday IIRC and normally it enters the flatpak version in a couple of hours. Now over 24 hours later, still no sign of the update being added.
I went into the flathub page to check for any news and to the GitHub page to check if there was any change, but for some reason the flatpak integrator bot hasn't made any commits like usual. What I want to know is if this is a bug or an intentional delay and how long it will be until it is resolved.

See https://github.com/flathub/sh.ppy.osu/pull/81

Oh I see.
TL;DR Is flathub still hasn't added support for desktop entries version 1.5 so the bot fails to build the package. It's not an issue on the osu! end so I'll be closing the issue.


[Env: cli] Environment support for apps deploy

Metadata

Implementation plan

Depends on

[x] https://github.com/meroxa/turbine-core/issues/80

Context
In order to allow for application deployment in an environment, we need to modify 'apps deploy' command in our CLI to accept a new flag '--env'. When no value is passed to an environments flag, we need to assume a common env.
Acceptance

[ ] Add a new flag '--env' to meroxa apps deploy command, to change flags
[ ] The flag's information should be passed with Application info to API
[ ] When there is no '—env' value, assume 'common'

For the record, on:
 When there is no '—env' value, assume 'common' I'll leave the API to figure that out. In other words, when no environment information is sent out, Platform API should assume is common environment.


Fix All Open Header Issues

Fix #159
Fix #160
Fix #162
Fix #305
Fix #308
This also fixes issues with keyboard navigation and interactions.
This does not have support for the quote links to open the wizard. That will be tracked in a new issue.
Test URLs:

https://bug-header-issues--shredit--stericycle.aem.page/drafts/stopp/en-us (Default Nav)
https://bug-header-issues--shredit--stericycle.aem.page/en-us/marketing/25purge (Alt Nav 0)
https://bug-header-issues--shredit--stericycle.aem.page/en-us/marketing/23purge (Alt Nav 1)
https://bug-header-issues--shredit--stericycle.aem.page/drafts/stopp/shred-it-pricing (Nav 2 with initially hidden)
https://bug-header-issues--shredit--stericycle.aem.page/drafts/stopp/bulk-paper-shredding (Nav 2 not hidden)

This PR has an issue @bstopp idk why but the header isn't loading on the en-us page?
https://bug-header-issues--shredit--stericycle.aem.page/en-us

I have not updated the actual nav for the entire site yet. Only the pages listed in the PR will work for this branch at the moment. @MarquiseRosier


Rebase with upstream: v0.5.1 changes

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Release note:
none

Please do update the description with steps followed for rebase, It may help in future.

Please do update the description with steps followed for rebase, It may help in future.

Added.

/lgtm

@jaypoulz are you able to add acknowledge-critical-fixes-only lable?

/label acknowledge-critical-fixes-only


Dock hiding turned on when using yabai -m space --focus next

I use
ctrl - right : yabai -m space --focus next
ctrl - left : yabai -m space --focus prev

to prevent macOS from doing its sloooow workspace switching animation.
When I use those keyboard shortcuts from a workspace that has a fullscreen app, yabai will turn on Dock hiding: When I switch back to a non-fullscreen workspace, the Dock will be hidden and I need to disable Dock hiding by using "Turn Hiding off" in the Dock context menu.
Interestingly, the "Automatically hide and show the Dock" option in System Settings is not enabled, so the Dock context menu and System Settings disagree.
Is this a bug in yabai or an inevitable constraint to how workspace switching works in yabai?

I have exactly same issue, I have to keep the dock hidden because of it

So this is yabai turning dock hiding on, it is actually macOS that turns it on when entering a native-fullscreen space. If anything, the problem is that yabai does not disable it when it is forcing macOS to leave the native-fullscreen space using the space focus commands.


Identify second topic

Identify second topic for the ThinkWeek.
Make sure this is a topic which inspires you and which you have access to sources that assist your reflection

Future of Work


Sticky Navigation Incorrect Link

Read Issue #2 for context.
The link should be: https://50projects50days.com/projects/sticky-navigation/
However the link is: https://50projects50days.com/projects/sticky-navbar

Thank you :) lots of links to keep track of lol


Update generator templates to produce classes rather than DSL incantations

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

I'll pick this one up.
Adjusting the Mapper and Relation generators to:

Produce the class version
use autoload-safe file names
accept an optional adapter argument

And add a generator for Forms

optional adapter argument to generator
generate an integration spec/test for the form

Sounds like a good plan :)

Anything left on this?  Between rom-rails#30 and rom-rails#25  I think it's been covered?

True! Closing, thanks :heart:


Samples: Basic battery measurement with NRF ADC

This simple sample shows how to configure SAADC on NRF52 chip to
perform VDD voltage measurement without any other HW wiring.
Signed-off-by: Bartłomiej Żarnowski<EMAIL_ADDRESS>

See also #21606.
I'm not sure how you measure battery without any external hardware like a voltage divider.  What this sample does is measure Vdd, which is the voltage supplied to the MCU.  Normally the external supplied voltage goes through some sort of converter that can increase or decrease voltage to meet the needs of the MCU.

Hi,
Thanks for comment.

See also #21606
I've seen it. It is more advanced and show how to calc voltage with greater precision when you have proper wiring. However currently I've on desk small board which uses battery as a power supply without any other power regulator, just 2 capacitors on power pins. I got request to measure voltage on MCU (as you pointed) and since there is no other circuits between MCU and battery, measured voltage is same as battery voltage. Precision of such measurement is not to great but there are use cases where it is sufficient. Since I spent some time to discover how to configure it with zephyr I thought it might be useful for someone, since there is not much docs about ADC on zephyr doc page.
Hope I answered your question.

I think having an example of this is worthwhile, but I would like to see it integrated into the sample proposed by #21606.  This variant could be selected by BOARD_ENABLE_DCDC or by a sample-specific Kconfig option.  Then all the battery-measurement stuff would be in one place.
That would depend on #21606 being merged.

I think having an example of this is worthwhile, but I would like to see it integrated into the sample proposed by #21606. This variant could be selected by BOARD_ENABLE_DCDC or by a sample-specific Kconfig option. Then all the battery-measurement stuff would be in one place.
That would depend on #21606 being merged.

#21606 is merged, perhaps you can consider integrating this sample into the one introduced by that PR @zarnobarintive?

I think having an example of this is worthwhile, but I would like to see it integrated into the sample proposed by #21606. This variant could be selected by BOARD_ENABLE_DCDC or by a sample-specific Kconfig option. Then all the battery-measurement stuff would be in one place.
That would depend on #21606 being merged.

#21606 is merged, perhaps you can consider integrating this sample into the one introduced by that PR @zarnobarintive?

Sure, just need to dig in into delivered code.

@carlescufi @pabigot
Please check if this is what was expected. I tried to keep style of previous code.
I don't have idea how to proper choose ADC device for that example, that's why I hardcoded ADC_0. If some different approach is preferred please give me some hints.
I also not sure about result of method adc_raw_to_millivolts, looks like raw values are more accurate to voltage set on power supply in my lab. But I'm not an expert in this area.

I was envisioning a solution that shared a little more code, as in #22497.
Does that approach work for you?  If so it'd be great if you could grab that commit and update this to incorporate it along with the README that explains it all (which I somehow managed to miss in the original solution).

@pabigot I checked your solution and it looks like it's nothing to do from my side. Please deliver your code, I'll drop this PR.
I'm not having nrf52_pca20020 to test and I'm not familiar with this board so I would rather not write Readme file since I'm not sure how this voltage divider is controlled on it.
While reading your code it looks like curve to convert from mv is different for direct MCU voltage measurement, I wonder why? Usage of divider doesn't change shape of curve rather just scale it. Is there any other reason why it's changed to linear?

OK; thanks, I'll clean up my commit, add a README, and submit it sometime relatively soon.
The existing curve is for a LiPo battery which supplies voltages that are too high to be used for a direct connection to Vdd: you'd burn out the chip.  I don't have a battery discharge curve for lower voltages so just picked a two point range from minimum to maximum.
That's the sort of information that will have to go into the README.


Feature/create game

PR for #283 #93  .
PR Status
READY
Ready for PR?

[x] I have updated the CHANGELOG with an entry including a description, a link to my profile, and a link to the issue ticket. This change is filed under an Enhancement or Bug Fix, is shown under the relevant release tag name, and is included in my PR branch.
[x] I have run lein run-lint to check for linting errors.

Changes Proposed:

Create Game Modal + inline errors
Datepicker Input
Radio Input

Breaking changes?

None

Screenshot of feature:

@oconn @dehli rereview plz!


ios not working in real devices

I tride to implement this lib
and it is work fine with custom view in simulater buto not in real device it showing blank page only
in simulater:

but in real device :

Can you use the "Relase" Scheme to run in simulator and check XCode for any error-messages ??

Facing similar issue.
When links are shared from another app, nothing happens. In my case, not even the custom share component doesn't even open.

@ikmrgrv i've this issue "/Products/Release-iphoneos/ShareExtension.appex/main.jsbundle does not exist. This must be a bug with", Do I have to generate a bundle of index.share.js and add it to its corresponding target?

Facing same issue anyone solve this pls reply.
++ @meedan

Facing similar issue.
When links are shared from another app, nothing happens. In my case, not even the custom share component doesn't even open.
Flipper shows an app crash with following issue :
Terminating app due to uncaught exception 'RCTFatalException: Unhandled JS Exception: Invariant Violation: Module AppRegistry is not a registered callable module (calling runApplication).

Any solution or hint to resolve this ??
@meedan

I figured out the problem and the solution for this.
The problem was, in the build phase with Release scheme, it was not pointing to index.share.js properly. Hence, though it was working for me in the simulator, it wasn't working properly in real device. Fortunately, it's working for me now!
I would suggest you use flipper and look for any notification regarding crash. You might get some hint there @anasalsaadi14

Can you pls describe your steps what you have followed, I'm facing same issue.

@NTJ3 I have same problem. Were you able to solve it?

@ikmrgrv i've this issue "/Products/Release-iphoneos/ShareExtension.appex/main.jsbundle does not exist. This must be a bug with", Do I have to generate a bundle of index.share.js and add it to its corresponding target?

any update ?

In case it is still needed
-      .jsBundleURL(forBundleRoot: "index.share", fallbackResource: nil)
+      .jsBundleURL(forBundleRoot: "index.share")

This change in ReactShareViewController.swift should resolve it


Incompatible with valkyrienskies

Describe the Bug
Most of the content in the create fabric (such as the creation motor, transmission rod, etc.) cannot work in the physical structure of the valkyrienskies ,which work in create forge
Reproduction Steps
1.install the fabric edition of valkyrienskies
2.install the fabric edition of eureka ship(the addon of valkyrienskies)
3.enter game.create a physics structure of valkyrienskies
4.place some create fabric stuff,see whats going on
...
Expected Result
Many contents in the create fabric (such as creating motors, transmission rods, etc.) can work normally in the physical structure of the valkyrienskies
Screenshots and Videos

Crash Report or Log
No response
Operating System
Windows 11
Mod Version
0.5.0g
Minecraft Version
1.18.2
Other Mods
valkyrienskies-118-2.1.0-beta7.jar
eureka-1.1.0-beta2+59792d77ff.jar
Additional Context
No response

VS needs to implement their Flywheel compat on fabric. cannot be fixed by us.


util.ts references Zone['symbol'] which is not present on ZoneType

This breaks closure compilation of an app using zone.js, at
node_modules$zone_js$v0_6_17$lib$common$utils$zoneSymbol("eventTasks")
app_bundle.js:49 Uncaught TypeError: node_modules$zone_js$v0_6_17$lib$common$utils$zoneSymbol is not a function(anonymous function) @ app_bundle.js:49

this is fixed in https://github.com/angular/angular/pull/31350


[nrf temphack] soc: use PM when configuring MPU regions

Temporary solution for using partition manager defines when configuring
the MPU regions.
This fixes assert seen when configuring dynamic regions.
Signed-off-by: Håkon Øye Amundsen<EMAIL_ADDRESS>

Commit title should be:
[nrf temphack] soc: use PM when configuring MPU regions

and is this really a temphack ?
What will be the cprrect solution.

I never remember if its with or without the hyphen, fixed now.
This feels like a hack to me. Firstly since its a diff from upstream, secondly since it should be possible to solve this in a generic way where we can "hook in" without having downstream patches. Thirdly since the use of these kconfig symbols for SRAM values other places would still be incorrect.
I was thinking in the lines of adding an overlay kconfig file setting the Kconfig symbols for SRAM_START and SRAM_SIZE if PM is used for RAM partitioning. This way we don't need an upstream patch, and the change will be traceable by the user.

This looks really "hacky".
@hakonfam is there a link to the observed issue, this PR attempts to solve?

I added link to the NCSDK ticket describing the issue in the commit message. NCSDK-6718

@ioannisg @tejlmand an alternative approach would be to include a headerfile which does #undef of CONFIG_SRAM_BASE_ADDRESS and CONFIG_SRAM_SIZE before it redefines them based on the values of PM_SRAM_SIZE / 1024 and PM_SRAM_ADDRESS. What I really dislike about this solution is that it is not visible for the user, and I actually prefer the more hacky, but visible way it is currently done in this PR.
To clean up the hack I could do the #undef pattern inside this file as well, but then AFAIK values for CONFIG_SRAM_* would be changed for the rest of the preprocessor run (not 100% sure about this though).

For future reference:
I have verified that there are no other uses of CONFIG_SRAM_BASE_ADDRESS which could be affected by this issue.
There is one use in nrf_qspi_nor.c, but that should be changed to use the symbol for the base of RAM from DT instead.

I think we need to solve this problem in a nice way:
config SRAM_BASE_ADDRESS and config SRAM_SIZE determine the image SRAM start address and size; I think this is very problematic if this is not the case. Application users may rely on SRAM_SIZE and SRAM_BASE_ADDRESS reflecting the image ram.

Yes they may, but I don't think this is something which is done a lot. When do you need to operate on the borders of RAM? Its not even the physical RAM, which could be used for checking if a pointer is in RAM or FLASH.. The SRAM_*  does also not represent the RAM the application has available, since that is found in linker symbols.
IMO it is OK for us to change this value here, but of course not optimal.

The partition manager can overwrite the SRAM_BASE_ADDRESS and SRAM_SIZE, so their values are consistent with the build.
In this case you can avoiding editing this core zephyr ARCH source file.

I agree that the best solution would be to override the kconfig values for SRAM_*, but this ends in a dependency loop; PM depends on Kconfig, and should if PM sets kconfig values, then Kconfig needs to re-evaluted and so on.

I have verified that there are no other uses of CONFIG_SRAM_BASE_ADDRESS which could be affected by this issue.

This is a very risky assumption, considering how generic these Kconfig symbols are. They may well be used in upstream samples, which we are supposed to build successfully in NCS.

They are not used in upstream samples, this is what I have verified.

@shantha-14 this needs your approval

Replaced by https://github.com/nrfconnect/sdk-zephyr/pull/384


SecurityInsights: Old Workspace ID Persisted for a period in backend after recreation of workspace with same name

API Specification is 2021-10-01-preview, also present in previous preview versions
An issue occurs when deleting and recreating a workspace under the same name, where creation of new alert rules from Sentinel onto a workspace presumably does a workspace ID lookup and comes back with an ID of the previously deleted workspace
Example POST:
id: "/subscriptions/xxxx/resourceGroups/xxxx/providers/Microsoft.OperationalInsights/workspaces/workspacename/providers/Microsoft.SecurityInsights/alertRules/alertId"
kind: "Scheduled"
... snipped
type: "Microsoft.SecurityInsights/alertRules"
Example response:
{"error":{"code":"BadRequest","message":"Failed to run the analytics rule query. Log Analytics workspace '{old workspace id}' could not be found."}}

In my example, I have just  deleted a previous workspace titled "workspacename" and created a new one, with the same name. The previous workspace had a workspace id of {old workspace id}, the new workspace has a different workspace id.
For some reason the backend does not refresh or caches the old workspace id's for lookup purposes and does not refresh them until after a while, even when using the permanent deletion feature of a workspace. This is generally annoying when rebuilding workspace in CI/CD testing capacity.
In addition other odd behaviour occurs, some alerts, incidents and automation rules still persist onto the new workspace. Rules that are not scheduled/NRT or are created in a disable state appear to work fine implying its happens during the lookup of the workspace when a rule is enabled to trigger its first run or along those lines.
I haven't tested the exact time period (its likely a few hours?) but definitely by a few days workspace and rules show back blank again

Removing CXP attention label since Service as been involved already.
@amirkeren Could you please look into this once you get a chance ?

The workspaces are indeed cached (if I'm not mistaken, for a period of 24 hours). I'll reach out to the owning team for more information after the weekend.


Question: Ignite Affinity Colocation queries

Hi
We currently have a Ignite cluster enabled with Persistence and have multiple tables which have parent child relationship.
we are performing some joins to get parent - child data and have below questions with respect to affinity key.

Can we have multiple affinity keys defined for a table/Cache. if so are there any examples on how to achieve this?
Is there any way to set the affinity key when we have any hierarchy such as Parent -> Child -> Child2 relation. Couldn't find any example on how to achieve this.
when an Affinity key is defined using DDL statement, Is it possible to update it later using Alter statements or any other approach?
How to enable non-colocated joins or distributed joins?
Is it required to have affinity key defined on data Insert as we might have different schemas and affinity keys can vary?

Any suggestions will be appreciated.

Can we have multiple affinity keys defined for a table/Cache

Simple answer: no, don't do that.
Details: affinity key is defined per type. Multiple types can be stored in one cache. Multiple SQL tables can be defined in one cache. I would not recommend any of that, keep it 1 cache = 1 table = 1 type.

Is there any way to set the affinity key when we have any hierarchy such as Parent -> Child -> Child2

All children (direct and indirect) should use the same affinity key as the parent, so that the entire family is colocated. Example: https://ignite.apache.org/docs/latest/data-modeling/affinity-collocation#configuring-affinity-key


Blur sensitive search results

Fixes

Fixes #2369 by @dhruvkb
Description

This PR adds logic to the image and audio result components to blur their content if their media item has been flagged as sensitive. It also replaces title and creator strings from the DOM with placeholders to prevent any sensitive information from leaking through assistive technology that bypasses CSS and interacts with the DOM.
Testing Instructions

Check out the PR and run the dev server.
Enable the fake_sensitive toggle in the /preferences page.
Search for something like 'cat'.
Observe blurring of fake-sensitive results in all three views:

mixed media
only images
only audio

Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

I messed up, I forgot to look up the blur values in Figma. Sorry for the double reviews, it should be fixed now.


Ensure Resources are closed in order

At present it may happen that a resource is closed before its derived resources are closed. In most cases this is not an issue, but there may be cases when this could become an issue.

implementation idea: change the interface to something like this
public interface Resource<T>
{
    T value(User user);

    void close(User user) throws Exception;
}

where User is a type that identifies an Assertion decorator (WithResource) or another Resource that uses the given resource. A Resource would be closed when all Users have closed it. This would prevent eager usage (because you can't provide a reasonable User) and enable test class instantiation without creating test resources at the same time.


Segment fault while using gold linker on aarch64, but no-pie works.

Hi,
I notice that the executable crashes due to a segment fault when it's used with Nuitka (the latest release version: 2.4.8) . Such as:
test@111:~/test_nuitka$ python3 -m nuitka --debug main.py
Nuitka-Options: Used command line options: --debug main.py
Nuitka-Options:WARNING: You did not specify to follow or include anything but main program.
Nuitka-Options:WARNING: Check options and make sure that is intended.
Nuitka: Starting Python compilation with Nuitka '2.4.8' on Python '3.8' commercial grade 'not
Nuitka: installed'.
Nuitka: Completed Python level compilation and optimization.
Nuitka: Generating source code for C backend compiler.
Nuitka: Running data composer tool for optimal constant value handling.
Nuitka: Running C compilation via Scons.
Nuitka-Scons: Backend C compiler: gcc (gcc 9).
Nuitka-Scons: Backend linking program with 6 files (no progress information available for this
Nuitka-Scons: stage).
Nuitka-Scons:WARNING: You are not using ccache, re-compilation of identical code will be slower
Nuitka-Scons:WARNING: than necessary. Use your OS package manager to install it.
Nuitka: Keeping build directory 'main.build'.
Nuitka: Successfully created 'main.bin'.
test@111:~/test_nuitka$ ./main.bin
Nuitka: A segmentation fault has occurred. This is highly unusual and can
have multiple reasons. Please check https://nuitka.net/info/segfault.html
for solutions.
Segmentation fault (core dumped)

main.py is a simple example, just like:
#!/usr/bin/env python
# -*- coding: utf-8 -*-

def main():
    print("Hello, World!")

if __name__ == "__main__":
    main()

environment

OS: ubuntu20.04 LTS aarch64
GCC: 9.3.0
LD: gold (Binutils for Ubuntu 2.34) 1.16
Python: 3.8.2

workaround
I use gdb to debug this issue and find it's caused by illegal access memory address.
Core was generated by `./main.bin'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00000055602c8528 in unpackValueUint32 (data=0x55607983d0 <constant_bin>)
    at /usr/include/aarch64-linux-gnu/bits/string_fortified.h:34
34	  return __builtin___memcpy_chk (__dest, __src, __len, __bos0 (__dest));
(gdb) bt
#0  0x00000055602c8528 in unpackValueUint32 (data=0x55607983d0 <constant_bin>)
    at /usr/include/aarch64-linux-gnu/bits/string_fortified.h:34
#1  0x00000055602d107c in loadConstantsBlob (tstate=0x556080df30,
    output=0x55607df628 <global_constants>, name=0x556053a0d8 "")
    at /home/linaro/.local/lib/python3.8/site-packages/nuitka/build/static_src/HelpersConstantsBlob.c:1254
#2  0x00000055603055d8 in _createGlobalConstants (tstate=0x556080df30) at __constants.c:66
#3  0x0000005560305a28 in createGlobalConstants (tstate=0x556080df30) at __constants.c:266
#4  0x0000005560307008 in main (argc=1, argv=0x556080df30) at static_src/MainProgram.c:1411
(gdb) up
#1  0x00000055602d107c in loadConstantsBlob (tstate=0x556080df30,
    output=0x55607df628 <global_constants>, name=0x556053a0d8 "")
    at /home/linaro/.local/lib/python3.8/site-packages/nuitka/build/static_src/HelpersConstantsBlob.c:1254
1254	        uint32_t hash = unpackValueUint32(&constant_bin); <==== illegal  memory access
(gdb) p constant_bin
$1 = (const unsigned char *) 0x550010 <error: Cannot access memory at address 0x550010>
(gdb)
 0x550010 looks like a absolutely address.

Then I check compile procedure, and maybe variable constant_bin is generated by linker -Wl,binary -Wl,./__constants.bin, such as:
gcc -o /home/linaro/test_nuitka/main.bin -flto=8 -fuse-linker-plugin -fpartial-inlining -freorder-functions -Og -g -z noexecstack -Xlinker -export-dynamic -rdynamic -Wl,-R,'/usr/lib' -Wl,--disable-new-dtags -Wl,-b -Wl,binary -Wl,./__constants.bin -Wl,-b -Wl,elf64-littleaarch64 -Wl,-defsym -Wl,constant_bin_data=_binary_____constants_bin_start<EMAIL_ADDRESS>-L/usr/lib -ldl -lm /usr/lib/python3.8/config-3.8-aarch64-linux-gnu/libpython3.8-pic.a -lz -lm -lutil -lpthread -lexpat

I'm not familiar with ld or gold linker, but when I use ld as default linker, it works and constant_bin's address will be base_address + absolutely address, and I think it's something about code position. So I modify /usr/local/lib/python3.8/dist-packages/nuitka/build/SconsCompilerSettings.py
173     if env.gcc_mode and lto_mode:
174         env.Append(CCFLAGS=["-flto"])
175
176         if env.clang_mode:
177             env.Append(LINKFLAGS=["-flto"])
178         else:
179             env.Append(CCFLAGS=["-fuse-linker-plugin", "-fno-fat-lto-objects"])
180             env.Append(LINKFLAGS=["-fuse-linker-plugin"])
181             env.Append(LINKFLAGS=["-no-pie"])   <----- add
182

After compiled with -no-pie, it works as well (at least not crash).
I'm not sure it's available or I miss something?
Thanks!

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."

This would have to be a gold upstream bug. The LTO of it is probably one which mishandles the constants blob, which has been seen before. For now I would say, that old gold is probably unsupported. How do I get things to use gold on my Linux system anyway?

Closing for lack of feedback


break-before

break-before
https://developer.mozilla.org/de/docs/Web/CSS/break-before

This issue was imported from Google Moderator
Moderator votes: +6
Issue added by ____ on 2014-10-14
To vote this issue up or down, simply include +1 or -1 in your comment.

Already part of http://caniuse.com/#feat=css-page-break


Compile issues with Elixir 1.15

When compiling with Elixir 1.15 we currently get the following error:
==> eredis
Compiling 6 files (.erl)
src/eredis_parser.erl:25:14: can't find include lib "eunit/include/eunit.hrl"
%   25| -include_lib("eunit/include/eunit.hrl").
%     |              ^

When setting :prune_code_paths to false in mix.exs it fixes the issue but according to the release notes for Elixir 1.15.0 doing this may cause runtime bugs that only occur inside a mix release.
We are using Elixir 1.15.2 and Erlang 26.0.2.

Interesting. I can't see that eunit is used in this file so maybe we can just delete that line.
But what would we need to do otherwise? List eunit as a dependency in the app file?

I'm not super familiar with Erlang and rebar3 so I'm not sure what would need to happen to fix it. I did remove the reference to eunit in eredis_parser.erl and I was able to get it to compile without warnings in my project.
I opened #80 to fix this issue.


MPPT-2420-LC support status

Hi, I tried to upgrade my MPPT2420 controller software to the latest commit from master branch (it runs with firmware from Oct 18 w/o problems). The new commit builds and uploads okay. However, nothing happens. No leds, no nothing.
The code seems not to reach main() since I successfully enabled the OLED (could see the splash screen, so the upload works) but my attempt to put anything on the screen failed by calling the oled functions right in the first line of main.
Before I get out the gdb , I'd like to know, if there is any known issue with this device and this branch?

Hey, I recently used mainly the 1210-HUS for development and didn't always cross-check with the 2420-LC. But I'll do that right now and come back to you.
I had an issue with the 1210-HUS that it got stuck before the main if the solar panel was connected before the battery. Just found out an hour ago that putting a wait(0.1); after control_timer_start(CONTROL_FREQUENCY); in the main solves the issue, but I'm not entirely sure why... Maybe this solves your issue aswell?

Unfortunately I can confirm that the 2420-LC doesn't start up. I'll try to figure out why... That wait function was not the reason.

The OLED seems to cause trouble. If I take it out, it starts up and everything works fine.
There were some other small issues which I corrected in the latest commit ead6f2bffb75c09b2d95a972af47e87194daa39c. But I didn't figure out why the OLED stopped working with this hardware... it works fine with the other charge controller.

Hi,
thanks. Good to hear. Will give it a go tonight and see what happens.

Check the I2C lines of the OLED, sometimes that maybe where the error could be present, my hardware isn't completely done yet, I should have tried to help in finding the error . Meanwhile EAdog  (st7565 / st7567) LCD is still my favorite display, since the support has been abandoned, I will add the support to my hardware, OLED is kinda expensive for me to use .😎

Where do you get cheap ST7565 based LCD from? OLEDs from China are much cheaper than EAdog displays, at least from all suppliers I know.
The strange thing is that the whole program crashes. If the I2C lines were broken, it should just not display anything.

I know of $2 st7567 display I plan on using, 2.1 inches but $8 for OLED of the same size , unlike the OLED which is normally 0.9 inches. Am not building one Mppt or two, I have many sites I need to install as many units of Mppt , so am considering cost .. that's why I choose EAdog .

Maybe I will search more for 2.1 inches OLED under $4

Here is my result:
It works if OLED is disabled. It does not work if UART_SERIAL_ENABLED is not set. Which is strange, since it doesn't contribute to running the main activities.
Got CAN to work again. However, it is an very ugly hack at the moment. It is just sufficient to run my internal logging via CAN as I have done with the "old" firmware from last year.
It is not clear to me how to align this with the serial ThingSet code, as it works very differently (we cannot just pass a buffer to be filled...).
Anyways, I think, I'll switch to the new firmware and see how to get this done with your help.

@atochukwu0 : There is no problem with the OLED electrical connection on my end, the splash logo is being displayed just fine when the firmware starts up (which is done before main starts when the OLED object constructor is executed). Unfortunately the normal operation of the controller does not work, so there must be something going wrong).

Actually, if the logo shows up, there's something wrong somewhere ..

@hogthrob Thanks for the feedback.
I'll check regarding the interference with the UART serial, also on the other hardware. It's really a bit strange.
Regarding CAN: I was not aware that anyone else is actually using CAN at the moment, so improvements on that interface was at low priority on my ToDo list. Now I realize that the code is probably completely broken, as some names in the ThingSet library changed. I should have included the CAN option into Travis CI to make sure it will at least keep working... ;)
Please find the suggested specification of ThingSet via CAN here: https://thingset.github.io/spec/can
The code in the charge controller repo is currently only a first preliminary hack to allow monitoring (i.e. publication messages), but I didn't yet include any device configuration functions. With the ThingSet library now working quite well, it should not be too hard to implement. I'd be happy to work on that together.
Did you already fix the broken names? If yes, can you send a PR so that I don't have to do the work twice? I also suggest to rename the file interface_can.cpp to thingset_can.cpp.

By the way, if you didn't find out yet: The ThingSet library now allows to easily user-define all battery settings (as we disussed some time ago) via the serial. It also does plausibility-checks before accepting it. Just send e.g. !conf {"LoadDisconnect_V": 11.2} to change the setting and store it in the EEPROM. This works for any setting defined in data_objects.cpp. Other useful commands:

!output {} to see live measurement data
!rec {} to see recorded data like accumulated energy, SOC, etc.
!input {"LoadEn":false} to switch off the load
!input {"DCDCEn":false} to switch off the DC/DC (useful during testing)

Hi,
by the light of the day I had to find out that the actual charging does not work for unknown reasons. So it displays all the values, enables the load etc but even though the panel voltage is high enough, it does not start charging, I also noticed that the green led is on all the time (like the red one).
Not able to look into this more, had to reflash the old binary for the moment.
Use of CAN: Well, this is with the MPPT-2420 HW unfortunately required if the logger is to be powered by the load output. Otherwise the load power is measured incorrectly and cannot be switched off at all.
CAN ThingSet: Yes, interface_can should become "thingset_can".
However, this has not the highest priority now. First of all I would like to get it properly charging.

Sad to hear it's not even charging. I tested charging in the lab yesterday and it worked. If I find the time today, I'll also have a look again.

Use of CAN: Well, this is with the MPPT-2420 HW unfortunately required if the logger is to be powered by the load output. Otherwise the load power is measured incorrectly and cannot be switched off at all.

Can you explain your use case a bit more? You want to include the logger power consumption in the load output measurement or not? For the charge controllers with MPPT the USB output power is included in the load measurement, which makes sense in my opinion. And USB can be switched off independently, i.e. get different priority than the load output.

What could be the actual cause of not charging ?

Hi,
it might be a settings issue. Since I know now that the software is actually charging with @martinjaeger hardware, I would suspect something like this. I am not able to control or read out the settings via CAN (yet), just the publishing works.
@logger: No, I don't care too much if the logger consumption is actually logged or not. The problem is, that my logger (a raspberry PI) consumes about 40Wh of energy a day. And if the battery is low and the sun is not shining for a couple of days, I want the logger to be turned off instead of depleting the battery. Which it does if connected to the 5V internal voltage. I must admit, I have no BMS in place which does cut off everything if the voltage goes too low. The chinese ones switch off very late anyways (around 2.4V per cell). BTW, if I shutdown the RPi by itself to save energy, it will not "wakeup" if energy is restored...

Ah, interesting. Do you also use this RPi hat? https://github.com/LibreSolar/CAN_RPi-ZeroW
We faced the same problem with the RPi, but used the bus power supply provided by above shield. It's not "nice" to just cut its power when the battery is low. So ideally the charge controller would send a message to tell it to shut down first and wait one minute before it cuts the power.

Well, I have the PCBs unpopulated laying around after seeing the prices for a ready-made simple CAN module on eBay. Cutting the power is never "nice" but worked so far. BTW, the reason why there is the RPi in the first place was that my previous charge had no monitoring at all so I used an RPi with some ADCs to measure the currents and voltages and then switched to use the MPPT2420. Today I probably would go for the ESP32...

I totally agree, the ESP32 doesn't care if its power is cut and also consumes much less power. That's why I'm already working on a data monitoring PCB based on the ESP32 that supports both the LS.bus and LS.one interfaces. It's working well using Sparkfun ESPthing on a breadboard.

by the light of the day I had to find out that the actual charging does not work for unknown reasons. So it displays all the values, enables the load etc but even though the panel voltage is high enough, it does not start charging, I also noticed that the green led is on all the time (like the red one).

Just realized that the behavior of the green LED is correct. I changed it some time ago. The green LED indicates the load state (on = on). The red one is the "power" LED. It's continuously on in stand-by and starts blinking as soon as solar power is coming in, i.e. the DC/DC power stage is on.

I guess, for whatever reason, some of the range checks are "failing" and as a consequence charging is not enabled. I have a 3s LiIO (NMC) battery connected and configured.

Hi, my MPPT-2420-LC has been running the "newest" firmware today. In fact, I ran the CAN code on top of this. The code is here: https://github.com/hogthrob/MPPT-Charger_Software/tree/working_can_after_rebase One can clearly see, it is a hack, not more. It would be nice to go ahead with it, but I'll only be able to make slow progress. In any case, it works for now for me.

Wow @hogthrob, that's impressive .. let me take a look .

Did you fix the OLED error you once experienced ? And the uart related issues too .. @hogthrob

src\interface_can.cpp:182:47: error: no 'int ThingSet::pub_msg_can(unsigned int)' member function declared in class 'ThingSet'
int ThingSet::pub_msg_can(unsigned int channel)
threw this error , upon enabling CAN @hogthrob

Hi, I said it is a hack. I add the method declaration to the ThingSet library. Eventually, most if not all of thingset can will end up in the ThingSet library. As a quick fix, you may add
int ThingSet::pub_msg_can(unsigned int)
to the ThingSet class in the .piodeplibs/ThingSet/src/thingset.h file. No other change required, should compile.

Did you fix the OLED error you once experienced ? And the uart related issues too .. @hogthrob
Nope, did not look into this. Want to figure out how to run  the debugger from VS Code, but not the Platformio Plus one.

Did you know that pio plus is now free and open source? Don't need an account anymore.

No, did not. At least my VSCode still says:

You are not logged in. Please log in to PIO Account using PlatformIO IDE > PIO Home > Account or pio account login command and try again.

pio update seems to be the solution. I had 2.5.0 now 2.5.2 and it does something, have to connect to the ST-LINK now.

So far CAN, Serial, OLED is working. What is not working is USBSerial. I can get it to compile, the device is recognized by the PC, but it does not send out any character.
Did the USB code ever work (i.e. does it make sense to figure out what goes wrong)?

This issue not yet fixed ? 🤕 .

Well, yes and no.
I got everything working on the 2420-LC except USB. It compiles, it registers even the device with Windows / Linux but I don't get any data through it...
Maybe we should close this and open an USB issue.

I agree, USB is a separate topic. It's a bit annoying that the USB stack included in mbed seems to require the RTOS enabled and thus it's hard to use it for the tiny F0/L0 micros... maybe it works with the memory optimizations by hogthrob.


HRRR Map Testing

Adding skeleton framework for testing 12-hour accumulated maps.

Created YAML file with a limited number of image variables for testing
Created YAML file for maps testing workflow
Created Python script for basic tests on maps

Great. Thank you for these suggestions. I found a solution for the linting issue: arguments with a leading underscore are not subject to the "unused argument" warning. Let me know if this causes an issue I didn't anticipate.

Excellent. Thanks, everyone.


Global body planner package running into failures (Building has no errors)

Thanks for the continuous support!
After solving the local planner issues, running catkin run_tests results in failed tests for global planner
Total 8 tests failed:-

Expected: (avg_duration) <= (5e-6), actual: 3.06846e-05 vs 5e-06
[  FAILED  ] GlobalBodyPlannerTestFixture.testIsValidStateTime (357 ms)
[ RUN      ] GlobalBodyPlannerTestFixture.testGetRandomLeapActionTime

Expected: (avg_duration) <= (1e-4), actual: 0.00160519 vs 0.0001
[  FAILED  ] GlobalBodyPlannerTestFixture.testIsValidStateActionPairTime (2808 ms)

Actual: false
Expected: true
[  FAILED  ] GlobalBodyPlannerTestFixture.testValidStateActionPairRate (2772 ms)

4-8)
[  FAILED  ] 4 tests, listed below:
[  FAILED  ] GlobalBodyPlannerTestFixture.testIsValidStateTime
[  FAILED  ] GlobalBodyPlannerTestFixture.testGetRandomLeapActionTime
[  FAILED  ] GlobalBodyPlannerTestFixture.testIsValidStateActionPairTime
[  FAILED  ] GlobalBodyPlannerTestFixture.testValidStateActionPairRate
Any help will be beneficial,
Thanks,
Prakhar Goel

I was using debug before, so building it in release mode doesn't give any failures.
But running the global planner using : - roslaunch quad_utils quad_plan.launch reference:=gbpl logging:=true gives an error
[robot_1/global_body_planner-1] process has died [pid 27520, exit code -6, cmd /home/prakhargoel/Desktop/Mitacs/QuadSdk/catkin_ws/devel/lib/global_body_planner/global_body_planner_node start_state:=state/ground_truth goal_state:=clicked_point __name:=global_body_planner __log:=/home/prakhargoel/.ros/log/add1c446-eb37-11ec-b33c-3cf01140c1cb/robot_1-global_body_planner-1.log].
log file: /home/prakhargoel/.ros/log/add1c446-eb37-11ec-b33c-3cf01140c1cb/robot_1-global_body_planner-1*.log

I'm able to move the robot using teleop without any errors.

Solve time: 0.00321668 s
Vertices generated: 6
Path length: 5.02697 m
Path duration: 10.053 s
[ INFO] [1655138528.430044797, 14.168000000]: In reset mode
[ INFO] [1655138528.432825660, 14.169000000]: Switching to refinement mode
free(): double free detected in tcache 2
After this it fails

Running teleop does not require using global planner so it wouldn't give you related errors. From the error it seems the global planner has already figured out the valid solution but has the problem publishing it.

I can shed some light on the test failures - we have some unit tests which require a certain level of computation efficiency of the underlying function calls. Those will fail if in Debug mode or on a particularly slow platform, but you can ignore them.
That said, debug mode should help you determine where the actual error is coming from, although if global planner node is crashing then it is likely somewhere internal to that library. Any information on what file or line is causing the failure would be useful (you can get this either with a debugger or with well-placed print statements).

Oh okay, Thanks a lot! I will definitely try to locate the Ros error.

After it switches to refinement mode, it shows that message. Does it mean it's something to do with memory?
"
[ INFO] [1655220178.130017436, 74.472000000]: Switching to refinement mode
free(): double free detected in tcache 2"

That is certainly the symptom that throws the error but unlikely to be the root cause, it looks more like a segfault (which is why a debugger would be the best course of action).

Okay, the error code is -4. The SIGILL signal is raised when an attempt is made to execute an invalid, privileged, or ill-formed instruction. SIGILL is usually caused by a program error that overlays code with data or by a call to a function that is not linked to the program load module.

Yeah it looks like a memory linking issue. Can you use print statement or debugger to locate which line of code causes the issue?

Can you suggest which file I should start debugging? I find no problems in the global_body_panner node.

RUnning it in debug,
After few solutions it ended up with this message:-
[ WARN] [1655308419.384749504, 7.286000000]: Planner was unable to make any progress, start state likely trapped
[ INFO] [1655308420.722279044, 7.741000000]: Switching to refinement mode

The Goal pose can be changed in rviz or there is a fixed parameter to update in some launch file?

Running it in debug, After a few solutions, it ended up with this message:- [ WARN] [1655308419.384749504, 7.286000000]: Planner was unable to make any progress, start state likely trapped [ INFO] [1655308420.722279044, 7.741000000]: Switching to refinement mode

This was for the default goal state (5,0). Does that mean a global planner isn't able to find a solution?

Yes as informed earlier, with twist commands the robot is walking on many terrains. The robot stands sucessfully. When running the global planner with a default goal (5,0) on flat terrain :-
ROS_MASTER_URI=http://localhost:11311
process[robot_1/global_body_planner-1]: started with pid [22992]
process[robot_1/local_planner-2]: started with pid [22993]
process[robot_1/rosbag_record-3]: started with pid [22994]
process[robot_1/rosbag_record_archive-4]: started with pid [22995]
process[robot_1/plan_publisher-5]: started with pid [22996]
[ INFO] [1655314392.520151306, 46.379000000]: GBP has state and map information
[ INFO] [1655314392.539085729, 46.383000000]: In reset mode
complexity_schedule = 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
[ INFO] [1655314392.738179091, 46.427000000]: valid and shorter or previous plan not valid
Solve time: 0.186177 s
Vertices generated: 6
Path length: 3.7654 m
Path duration: 7.52545 s
[ WARN] [1655314397.225284166, 47.537000000]: Planner was unable to make any progress, start state likely trapped
[ INFO] [1655314400.812556352, 48.412000000]: Switching to refinement mode
[robot_1/global_body_planner-1] process has died [pid 22992, exit code -4, cmd /home/prakhargoel/Desktop/Mitacs/QuadSdk/catkin_ws/devel/lib/global_body_planner/global_body_planner_node start_state:=state/ground_truth goal_state:=clicked_point __name:=global_body_planner __log:=/home/prakhargoel/.ros/log/c9456daa-ecd0-11ec-bbd4-3cf01140c1cb/robot_1-global_body_planner-1.log].
log file: /home/prakhargoel/.ros/log/c9456daa-ecd0-11ec-bbd4-3cf01140c1cb/robot_1-global_body_planner-1*.log

Ok, from the output, it seems like the first time running global planner succeeds. Could you check the param num_calls value in global_boduy_planner.yaml? If it is one, then it means something triggers the global planner runs again where at this time the global planner cannot get a valid result. Global planner is triggered again usually means the robot significantly deviates from the original plan. Another way to check this is to rostopic echo /robot_1/topics/global_plan and see whether it has the first plan published.

I'm out for the next week or so but can briefly chime in with a debugging tip - if running the planner in debug mode, increase the max_planning_time parameter so something like a few seconds (you could also increase the startup delay to the same value). This allows the planner to take more time to find a feasible solution - usually the default value is fine but if compiling in debug mode the default is likely too fast.

Ok, from the output, it seems like the first time running global planner succeeds. Could you check the param num_calls value in global_boduy_planner.yaml? If it is one, then it means something triggers the global planner runs again where at this time the global planner cannot get a valid result. Global planner is triggered again usually because the robot significantly deviates from the original plan. Another way to check this is to rostopic echo /robot_1/topics/global_plan to see whether it has the first global plan published.

Okay, thanks. Looks like the plan is not getting published for some reason. Any possible reason you can think of ?
WARNING: topic [/robot_1/topics/global_plan] does not appear to be published yet

One more way is to uncomment line 26-27 inside planning_utils.h
// #define DEBUG_REFINE_STATE
// #define DEBUG_INVALID_STATE
By doing this, it can gives you a bunch of more detailed information on what is going wrong.

Ok, it seems like the global planner doesn't have time to figure out a feasible plan, try increase max_planning_time in global_body_planner.yaml from 0.20 to 1.0.

I tried increasing startup time and max_planning_time. No major change is observed.

Keep the max_planning_time to be few seconds while commenting out the debug output in planning_utils.h and try again?

Yeah did that, it still doesn't seem to converge.
Solve time: 0.160707 s
Vertices generated: 6
Path length: 5.02893 m
Path duration: 10.0096 s
complexity_schedule = 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
[ INFO] [1655394829.175067703, 9.029000000]: In reset mode
[ INFO] [1655394836.269547945, 11.082000000]: In reset mode
[ INFO] [1655394840.302016716, 12.223000000]: Switching to refinement mode
and then process died

Hello, Is there anything else to try or can you suggest any method cause when I'm using the deprecated version of the global planner, I'm able to get solutions really quick. :- https://github.com/jcnorby/global_body_planner. I feel its something to do with the overall integration in general and my setup.

You are correct - those printouts indicate that the planner found a valid plan, but something crashed between that and publishing the plan (so you can leave those debugging lines commented out).
I doubt this will solve it but from the printouts it looks like you are using a slightly old version of the code (there have been a few changes in the last few days), I'd recommend updating to the newest main.
We still need to figure out where in the code this is occurring for you. In lieu of using a debugger, add print statements to the spin function of the global_body_planner class to determine which subfunction is failing, then repeat that process in the subfunction until you determine which line is causing it to crash.

I've been working off both main and devel with their most recent versions. Both have this same issue with global_body_planner for me.

Okay, Thanks a lot.
I was with the latest changes on main. I will try debugging further and keep this thread updated as some other people are also facing similar issues I believe.

I've been working off both main and devel with their most recent versions. Both have this same issue with global_body_planner for me.

Hi! Let me know if anything solves the issue

I've been working off both main and devel with their most recent versions. Both have this same issue with global_body_planner for me.

When you are in debug mode, are you getting failed tests after running the catkin_tests?

Hi!
I am unable to figure out what causes the issue, is there any other thing that I can try?
Thanks!

Hi, Its something to do with this function :- void GlobalBodyPlanner::publishCurrentPlan()
There are 3 conditions that are checked, and for some reason, the message to publish is never created and it is stuck in these conditions, even if the path is valid.

I have commented out the line :- current_plan.setPublishedTimestamp(ros::Time::now());_
It finds a path, I can visualize the red path in rviz as well, but the NMPC fails for some reason:-
found valid plan
[ WARN] [1655923323.488762071, 33.328000000]: NMPC solving fail
found valid plan
[ WARN] [1655923323.615151404, 33.361000000]: NMPC solving fail
[ WARN] [1655923323.739059278, 33.391000000]: NMPC solving fail
found valid plan
[ WARN] [1655923323.778932163, 33.401000000]: Start is sufficiently close to goal, exiting
[ WARN] [1655923323.867511179, 33.423000000]: NMPC solving fail
found valid plan
[ WARN] [1655923323.993851230, 33.456000000]: NMPC solving fail
[ WARN] [1655923324.116495899, 33.487000000]: NMPC solving fail
found valid plan
[ WARN] [1655923324.245972782, 33.526000000]: NMPC solving fail
found valid plan
[ WARN] [1655923324.378389956, 33.562000000]: NMPC solving fail
[ WARN] [1655923324.504381709, 33.594000000]: NMPC solving fail
Note: Found valid plan is a print statement I added for debugging purposes.

Hey!
It solves the issue! Thanks a lot for the continuous support, I can now visualize the plan and the robot follows it with the NMPC controller also. There are some issues with leap tracking and it stops tracking the plan after some time(the plan publisher fails),  which I will tune parameters/try fixing further, but I can close this issue now:)
Hope it helps everyone!

That's a nice catch Prakhar, we will fix this bug in devel and main branch.


tweepy errror filtering by coordinates

Traceback (most recent call last):
File "analisis3.py", line 50, in
twitterStream.filter(locations=bogota)
File "/usr/local/lib/python3.6/site-packages/tweepy-3.6.0-py3.6.egg/tweepy/streaming.py", line 450, in filter
File "/usr/local/lib/python3.6/site-packages/tweepy-3.6.0-py3.6.egg/tweepy/streaming.py", line 364, in _start
File "/usr/local/lib/python3.6/site-packages/tweepy-3.6.0-py3.6.egg/tweepy/streaming.py", line 297, in _run
File "/usr/local/lib/python3.6/site-packages/six-1.10.0-py3.6.egg/six.py", line 686, in reraise
raise value
File "/usr/local/lib/python3.6/site-packages/tweepy-3.6.0-py3.6.egg/tweepy/streaming.py", line 266, in _run
File "/usr/local/lib/python3.6/site-packages/tweepy-3.6.0-py3.6.egg/tweepy/streaming.py", line 323, in _read_loop
tweepy.error.TweepError: Expecting length, unexpected value found
ANY SUGGESTION?

Paste your code?

Closing in favor of #892
For code block usage, see https://help.github.com/articles/creating-and-highlighting-code-blocks/.


Application pdf new

The functionality added is the ability to upload a form as a nonprofit worker, fill out the form as a client and sign it, and then the ability to see the completed forms of all clients in an organization as a nonprofit worker (go to the admin panel to see these options).
The file ApplicationForm.tsx is the main change, and this file allows a form to be completed.
Applications.tsx also works now and shows the relevant forms
DeveloperLanding.tsx is the landing for a developer account so that when a developer logs in, they can see all the unannotated forms, download them, and reupload the annotated forms.
Thank you to team Sand Benders for your work on this project!
Acknowledgement to Sophia Ye for styling/writing html/css for ApplicationForm.tsx
This a big feature! Hope you all enjoy using it!

@steffen12 please re merge master into this branch. This will help deal with the 100k deletes


Vagrant 2.1.2 error

Good morning
I (The Gunslinger) posted initially on the swgemu forums regarding "loop" I was experiencing that was attributed to Vagrant 2.1.2
I attempted the normal bootstrap command which resulted in the following plug in errors.  Will go utilize 2.0.4 if necessary but happy to help get 2.1.2 working:
$ curl -Lk http://downloads.zonamaserver.org/zonamadev/bootstrap.sh | bash
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 12701  100 12701    0     0  18066      0 --:--:-- --:--:-- --:--:-- 18066
######################################
Using branch release-1.5
######################################
** Checking for Git Bash **
main: line 205: : command not found
** BASH_VERSION: 4.4.19(2)-release **
** Checking for VirtualBox **
** Virtualbox version 5.2.14r123301 **
** Checking for Vagrant **
** Vagrant version 2.1.2 **
** ZDHOME=/c/Users/wadem **
Using https://github.com/Zonama/ZonamaDev branch release-1.5
fatal: destination path 'ZonamaDev' already exists and is not an empty directory.
No local changes to save
Fetching origin
Fetching origin
Already up to date.
Already on 'release-1.5'
Your branch is up to date with 'origin/release-1.5'.
** Running in /c/Users/wadem/ZonamaDev/fasttrack **
The plugin 'vagrant-triggers' is not installed. Please install it first.
** Removing any cached copies of base box **
vagrant up
The system cannot find the path specified.
The system cannot find the path specified.
Some plugins had to be installed, please re-run your command
real    0m0.777s
user    0m0.000s
sys     0m0.000s
** Running vagrant up again after plugin install **
** Vagrant failed, trying to repair plugins **
The system cannot find the path specified.
The system cannot find the path specified.
Some plugins had to be installed, please re-run your command
vagrant up
The system cannot find the path specified.
The system cannot find the path specified.
Some plugins had to be installed, please re-run your command
real    0m0.802s
user    0m0.000s
sys     0m0.015s
** Running vagrant up again after plugin install **
** Vagrant failed, trying to repair plugins **
The system cannot find the path specified.
The system cannot find the path specified.
Some plugins had to be installed, please re-run your command
** Vagrant failed to bring the VM image up, look at errors above for clues, RET=101 **
** If this continues get help here: https://github.com/Zonama/ZonamaDev/issues **
real    0m4.826s
user    0m0.015s
sys     0m0.106s
wadem@DESKTOP-1IKU3UL MINGW64 ~
$

As an update, I 'downgraded' to Vagrant 2.0.4 and still receiving the same error:
$ curl -Lk http://downloads.zonamaserver.org/zonamadev/bootstrap.sh | bash
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 12701  100 12701    0     0  19361      0 --:--:-- --:--:-- --:--:-- 19361
######################################
Using branch release-1.5
######################################
** Checking for Git Bash **
main: line 205: : command not found
** BASH_VERSION: 4.4.19(2)-release **
** Checking for VirtualBox **
** Virtualbox version 5.2.14r123301 **
** Checking for Vagrant **
** Vagrant version 2.0.4 **
** ZDHOME=/c/Users/wadem **
Using https://github.com/Zonama/ZonamaDev branch release-1.5
fatal: destination path 'ZonamaDev' already exists and is not an empty directory.
No local changes to save
Fetching origin
Fetching origin
Already up to date.
Already on 'release-1.5'
Your branch is up to date with 'origin/release-1.5'.
** Running in /c/Users/wadem/ZonamaDev/fasttrack **
The plugin 'vagrant-triggers' is not installed. Please install it first.
** Removing any cached copies of base box **
vagrant up
The system cannot find the path specified.
The system cannot find the path specified.
Some plugins had to be installed, please re-run your command
real    0m0.890s
user    0m0.000s
sys     0m0.000s
** Running vagrant up again after plugin install **
** Vagrant failed, trying to repair plugins **
Repairing currently installed plugins. This may take a few minutes...
Installed plugins successfully repaired!
vagrant up
The system cannot find the path specified.
The system cannot find the path specified.
Some plugins had to be installed, please re-run your command
real    0m0.865s
user    0m0.000s
sys     0m0.015s
** Running vagrant up again after plugin install **
** Vagrant failed, trying to repair plugins **
Repairing currently installed plugins. This may take a few minutes...
Installed plugins successfully repaired!
** Vagrant failed to bring the VM image up, look at errors above for clues, RET=101 **
** If this continues get help here: https://github.com/Zonama/ZonamaDev/issues **
real    0m7.266s
user    0m0.015s
sys     0m0.092s
wadem@DESKTOP-1IKU3UL MINGW64 ~
$

please start again, I pushed new code that will fix this, see:
https://github.com/Zonama/ZonamaDev#destroy-and-start-fresh

I feel like I am getting the same error. I had an instance running but wanted to start fresh. I did a destroy and then it told me I need to update Vagrant and Virtual Box. I did that and tried a destroy with no luck. I then tried regular install after deleting the folder and got this.
Trigues@Trigues MINGW64 /d/Users/Trigues
$ curl -Lk http://downloads.zonamaserver.org/zonamadev/bootstrap.sh | bash
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 12701  100 12701    0     0  14003      0 --:--:-- --:--:-- --:--:-- 28037
######################################
Using branch release-1.5
######################################
** Checking for Git Bash **
bash: line 205: : command not found
** BASH_VERSION: 4.3.42(5)-release **
** Checking for VirtualBox **
** Virtualbox version 5.2.18r124319 **
** Checking for Vagrant **
** Vagrant version 2.1.4 **
** ZDHOME=/d/Users/Trigues **
Using https://github.com/Zonama/ZonamaDev branch release-1.5
Cloning into 'ZonamaDev'...
remote: Counting objects: 6120, done.
remote: Total 6120 (delta 0), reused 0 (delta 0), pack-reused 6120
Receiving objects: 100% (6120/6120), 29.98 MiB | 11.31 MiB/s, done.
Resolving deltas: 100% (3908/3908), done.
Checking connectivity... done.
** Running in /d/Users/Trigues/ZonamaDev/fasttrack **
** Setting config.yml to use 8 cores for guest and 6144m of ram. **
** Removing any cached copies of base box **
vagrant up

cd ../..
vagrant plugin install vagrant-vbguest
Installing the 'vagrant-vbguest' plugin. This can take a few minutes...
Installed the plugin 'vagrant-vbguest (0.16.0)'!
cd ../..
vagrant plugin install vagrant-reload
Installing the 'vagrant-reload' plugin. This can take a few minutes...
Installed the plugin 'vagrant-reload (0.0.1)'!
Some plugins had to be installed, please re-run your command

real    0m17.690s
user    0m0.015s
sys     0m0.015s
** Running vagrant up again after plugin install **
** Vagrant failed, trying to repair plugins **
Repairing currently installed global plugins. This may take a few minutes...
Installed plugins successfully repaired!
vagrant up

cd ../..
vagrant plugin install vagrant-vbguest
Installing the 'vagrant-vbguest' plugin. This can take a few minutes...
Installed the plugin 'vagrant-vbguest (0.16.0)'!
cd ../..
vagrant plugin install vagrant-reload
Installing the 'vagrant-reload' plugin. This can take a few minutes...
Installed the plugin 'vagrant-reload (0.0.1)'!
Some plugins had to be installed, please re-run your command

real    0m15.388s
user    0m0.000s
sys     0m0.015s
** Running vagrant up again after plugin install **
** Vagrant failed, trying to repair plugins **
Repairing currently installed global plugins. This may take a few minutes...
Installed plugins successfully repaired!
** Vagrant failed to bring the VM image up, look at errors above for clues, RET=101 **
** If this continues get help here: https://github.com/Zonama/ZonamaDev/issues **

This a different issue, please start again:
https://github.com/Zonama/ZonamaDev#destroy-and-start-fresh
And open a NEW issue with the details.. Also try #emuyoda in IRC


PyTest unit test is failing on 2.7

Must be a recent change. PR submission is failing with this:
/bin/bash --noprofile --norc /home/vsts/work/_temp/d43be088-93fc-4310-9654-664009cbc0b1.sh
Traceback (most recent call last):
  File "pythonFiles/tests/run_all.py", line 10, in <module>
    from tests.__main__ import main, parse_args
  File "/home/vsts/work/1/s/pythonFiles/tests/__main__.py", line 7, in <module>
    import pytest
ImportError: No module named pytest

On the linux 2.7 test.
Here's an example:
https://dev.azure.com/ms/vscode-python/_build/results?buildId=91737&view=logs&j=30f64338-44c7-582e-d4a3-4a0ac701ffd4&t=c5e0ac23-b03e-5cd8-26d6-240704007aac&l=95

Closing as dupe #12705


typo: seperate -> separate

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/hosting/webview.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks again @nschonni !


Page out of date

Content does not correspond to the new modern App Store.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1b12ead9-dcc9-19af-e7b1-d846f8116300
Version Independent ID: 45ad5ca0-5c6f-c058-90e7-27f7824e937e
Content: Configure settings for the SharePoint Store - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/configure-sharepoint-store-settings.md
Service: sharepoint-online
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

Hello @angoo-atea Andrew, hoy are you?
I could follow the instructions currently in the SharePoint Admin Center that this article specifies, can you please specify what you see is outdated?
Thanks

Hello @angoo-atea could you see my last comment here?

@scanum


Fix grammar

Codecov Report

Merging #238 (d0f16bc) into master (1e6e9d3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #238   +/-   ##
=========================================
  Coverage     67.77%   67.77%
  Complexity      707      707
=========================================
  Files           107      107
  Lines          2430     2430
  Branches        332      332
=========================================
  Hits           1647     1647
  Misses          653      653
  Partials        130      130

Impacted Files
Coverage Δ

...seedu/address/model/schedule/EventDescription.java
80.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e6e9d3...d0f16bc. Read the comment docs.


Shared tests should be not be mututally exclusive with dedicated tests

Issue Type

Feature request

Molecule and Ansible details
ansible 2.7.0
  config file = None
  configured module search path = ['/Users/vogl/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/vogl/Development/ansible-roles/ansible-role-docker/.direnv/python-3.7.0/lib/python3.7/site-packages/ansible
  executable location = /Users/vogl/Development/ansible-roles/ansible-role-docker/.direnv/python-3.7.0/bin/ansible
  python version = 3.7.0 (default, Jun 29 2018, 20:13:13) [Clang 9.1.0 (clang-9<IP_ADDRESS>)]

molecule, version 2.18.1

Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Desired Behavior
It's pretty easy to include tests from another scenario by using the directory option. It'd be great if this could be treated like a base directory so that you can not only include those shared tests but also execute your local ones also.

verifier:
  name: testinfra
  directory: ../default/tests/

I think that current behavior is good enough and based on lack of activity I think is the time to close it.

Maybe I find some time to implement this. Would you accept a PR in that case?

Sure! More than welcomed.


Problem: launch kernel error not displayed to user

Solution: Log the error itself
We need to think on what streams our errors end up in. Is this a userland popup? How does it get represented? At the very least, I just didn't want to see the error get squashed.

Thanks, I was seeing "err" in my console which made me go "sigh...".  I think you're right though, make errors display as user land popups will save a lot of frustration in the future.  The same kind of frustration we have in the live notebook.


deleting a comment should also toggle its notification to 'unlinkable'

See genome/civic-client#432

Server has been updated to implement this feature, but the events listed on the home page and the activity page have improper styling and provide invalid links.


When multiple hive resources are created concurrently, the meta-information of the hive resource is inconsistent.

Steps to reproduce the behavior (Required)
5000 concurrent creation of hive resources
Expected behavior (Required)
Real behavior (Required)
can not drop resource;
mysql> show resources;
+-------------------+--------------+---------------------+-----------------------------+
| Name              | ResourceType | Key                 | Value                       |
+-------------------+--------------+---------------------+-----------------------------+
| hive2             | hive         | hive.metastore.uris | thrift://<IP_ADDRESS>:9083 |
| hive_resource_248 | hive         | hive.metastore.uris | thrift://<IP_ADDRESS>:9083   |
+-------------------+--------------+---------------------+-----------------------------+
2 rows in set (0.00 sec)

mysql> drop resource hive_resource_248;
ERROR 1064 (HY000): Resource(hive_resource_248) does not exist

StarRocks version (Required)

1.19

i will resolve this issue

after we restart fe each time, it will show the correct data.really weird

this issue can be closed


Bugfix/black 19.3b0 compat

When having installed the latest black version (19.3b0), one runs into the following error:
TypeError: format_str() got an unexpected keyword argument 'line_length'
because the line_length argument has been removed from the format_str method:
https://github.com/ambv/black/blob/a2f6706a1ea026cbe0e7d83caffa6c13c463bfe1/black.py#L664
This fixes the issue.

Great! Looks good now 👌🏼

@lamourj Thanks a ton for providing a fix for the issue.
@TPVasconcelos Amazing work with the review.
Extremely sorry for being so late in accepting the fix. :(


Patch for using Oracle Instantclient v. 12

Simply adding the new name for the OCCI library:
diff -u "e:/user/soci-3.2.2/cmake/modules/FindOracle.cmake~" "e:/user/soci-3.2.2/cmake/modules/FindOracle.cmake"
--- e:/user/soci-3.2.2/cmake/modules/FindOracle.cmake~	Wed Sep 11 00:44:06 2013
+++ e:/user/soci-3.2.2/cmake/modules/FindOracle.cmake	Wed Aug 27 08:42:46 2014
@@ -37,7 +37,7 @@
     ${ORACLE_HOME}/OCI/include) # Oracle XE on Windows

   set(ORACLE_OCI_NAMES clntsh libclntsh oci) # Dirty trick might help on OSX, see issues/89
-  set(ORACLE_OCCI_NAMES libocci occi oraocci10 oraocci11)
+  set(ORACLE_OCCI_NAMES libocci occi oraocci10 oraocci11 oraocci12)
   set(ORACLE_NNZ_NAMES nnz10 libnnz10 nnz11 libnnz11 nnz12 libnnz12 ociw32)

   set(ORACLE_LIB_DIR

I can't test this, but this looks so unlikely to break anything, that I'm applying it blindly, thanks.