Letter case in instance data skos:prefLabels

"area" or "Area"?

also found this:

gistd:_UnitOfMeasure_btu-it-per-lb
*
gistd:_UnitOfMeasure_milli-inch
*
gistd:_UnitOfMeasure_t-m
*
gistd:_UnitOfMeasure_v-m
*
gistd:_UnitOfMeasure_v_stat-centim
*
gistd:_UnitOfMeasure_w-m2
*
gistd:_UnitOfMeasure_w_m2-per-sr
should probably be

gistd:_UnitOfMeasure_btu_it_per_lb
*
gistd:_UnitOfMeasure_milli_inch
*
gistd:_UnitOfMeasure_t_m
*
gistd:_UnitOfMeasure_v_m
*
gistd:_UnitOfMeasure_w_m2
*
gistd:_UnitOfMeasure_w_m2_per_sr
also this doesn't look right:

gistd:UnitOfMeasure_hundred_weight-_short

From: Rebecca Younes @.>
Sent: Friday, August 2, 2024 1:04 PM
To: semanticarts/gist @.>
Cc: Subscribed @.***>
Subject: [External] : [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
"area" or "Area"?
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/semanticarts/gist/issues/1141__;!!ACWV5N9M2RV99hQ!KblFmVMW4nwDB9wN5E8R8NajXKJ73oMVobN_FTl3fqxECa7f0bDf0rfOunpz7dlCrn3N6ZILSYo8MNOSCEoIZloc-uN1xp0$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOMYTH3SSIJ5VMKTIAW6QCLZPO3TJAVCNFSM6AAAAABL44TENWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2DKNBSGAYTSNQ__;!!ACWV5N9M2RV99hQ!KblFmVMW4nwDB9wN5E8R8NajXKJ73oMVobN_FTl3fqxECa7f0bDf0rfOunpz7dlCrn3N6ZILSYo8MNOSCEoIZlocA8vNEs8$.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

also this one:

gistd:_UnitOfMeasure_astronomical-unit

From: Michael J. Sullivan @.>
Sent: Monday, August 5, 2024 11:03 AM
To: semanticarts/gist @.>; semanticarts/gist @.>
Cc: Subscribed @.>
Subject: Re: [External] : [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
also found this:

gistd:_UnitOfMeasure_btu-it-per-lb
*
gistd:_UnitOfMeasure_milli-inch
*
gistd:_UnitOfMeasure_t-m
*
gistd:_UnitOfMeasure_v-m
*
gistd:_UnitOfMeasure_v_stat-centim
*
gistd:_UnitOfMeasure_w-m2
*
gistd:_UnitOfMeasure_w_m2-per-sr
should probably be

gistd:_UnitOfMeasure_btu_it_per_lb
*
gistd:_UnitOfMeasure_milli_inch
*
gistd:_UnitOfMeasure_t_m
*
gistd:_UnitOfMeasure_v_m
*
gistd:_UnitOfMeasure_w_m2
*
gistd:_UnitOfMeasure_w_m2_per_sr
also this doesn't look right:

gistd:UnitOfMeasure_hundred_weight-_short

From: Rebecca Younes @.>
Sent: Friday, August 2, 2024 1:04 PM
To: semanticarts/gist @.>
Cc: Subscribed @.***>
Subject: [External] : [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
"area" or "Area"?
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/semanticarts/gist/issues/1141__;!!ACWV5N9M2RV99hQ!KblFmVMW4nwDB9wN5E8R8NajXKJ73oMVobN_FTl3fqxECa7f0bDf0rfOunpz7dlCrn3N6ZILSYo8MNOSCEoIZloc-uN1xp0$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOMYTH3SSIJ5VMKTIAW6QCLZPO3TJAVCNFSM6AAAAABL44TENWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2DKNBSGAYTSNQ__;!!ACWV5N9M2RV99hQ!KblFmVMW4nwDB9wN5E8R8NajXKJ73oMVobN_FTl3fqxECa7f0bDf0rfOunpz7dlCrn3N6ZILSYo8MNOSCEoIZlocA8vNEs8$.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Agreed, we should use underscores rather than hyphens.

some more examples of hyphens used in gistd:
gistd:_Aspect_angular_cross-section rdf:type owl:NamedIndividual ;

gistd:_Aspect_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_cross-sectional_area rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_debye-waller_factor rdf:type owl:NamedIndividual .
*
gistd:_Aspect_g-factor_of_nucleus rdf:type owl:NamedIndividual .
*
gistd:_Aspect_gross_lift-off_weight rdf:type owl:NamedIndividual .
*
gistd:_Aspect_half-life rdf:type owl:NamedIndividual .
*
gistd:_Aspect_half-value_thickness rdf:type owl:NamedIndividual .
*
gistd:_Aspect_landau-ginzburg_number rdf:type owl:NamedIndividual .
*
gistd:_Aspect_lande_g-factor rdf:type owl:NamedIndividual .
*
gistd:_Aspect_long-range_order_parameter rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_macroscopic_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_macroscopic_total_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_non-leakage_probability rdf:type owl:NamedIndividual .
*
gistd:_Aspect_nozzle_throat_cross-sectional_area rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_over-range_distance rdf:type owl:NamedIndividual .
*
gistd:_Aspect_rf-power_level rdf:type owl:NamedIndividual .
*
gistd:_Aspect_short-range_order_parameter rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_area rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_density rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_distance rdf:type owl:NamedIndividual .
*
gistd:_Aspect_spectral_angular_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_spectral_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_stress-optic_coefficient rdf:type owl:NamedIndividual .
*
gistd:_Aspect_total_cross-section rdf:type owl:NamedIndividual ;

From: Rebecca Younes @.>
Sent: Monday, August 5, 2024 2:17 PM
To: semanticarts/gist @.>
Cc: Michael J. Sullivan @.>; Comment @.>
Subject: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
Agreed, we should use underscores rather than hyphens.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/semanticarts/gist/issues/1141*issuecomment-2269640216__;Iw!!ACWV5N9M2RV99hQ!P0SiZQGjXXRsh7__t62TI-nuE_LLww-GMUbUnTArX1IIwjSpaa41uNd8TSrTVAB03Nb8rjmP5pUqZ2tnlE3hJZOAEz-dX8E$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOMYTH7T5F3KGF2O3DNESX3ZP66VNAVCNFSM6AAAAABL44TENWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRZGY2DAMRRGY__;!!ACWV5N9M2RV99hQ!P0SiZQGjXXRsh7__t62TI-nuE_LLww-GMUbUnTArX1IIwjSpaa41uNd8TSrTVAB03Nb8rjmP5pUqZ2tnlE3hJZOAYcC8Z4M$.
You are receiving this because you commented.Message ID: @.***>

Also this: Why is there no gallon_us? (there is us_gallon and uk_gallon and gallon_uk and imperial_gallon. Are the latter three the same thing? Very confusing...)
e.g.
gistd:_UnitOfMeasure_gallon_uk                      rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_day              rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_hour             rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_minute           rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_second           rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_us_liquid_per_second    rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_us_per_hour             rdf:type owl:NamedIndividual .

From: Michael J. Sullivan @.>
Sent: Tuesday, August 6, 2024 9:22 AM
To: semanticarts/gist @.>; semanticarts/gist @.>
Cc: Comment @.>
Subject: Re: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
some more examples of hyphens used in gistd:
gistd:_Aspect_angular_cross-section rdf:type owl:NamedIndividual ;

gistd:_Aspect_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_cross-sectional_area rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_debye-waller_factor rdf:type owl:NamedIndividual .
*
gistd:_Aspect_g-factor_of_nucleus rdf:type owl:NamedIndividual .
*
gistd:_Aspect_gross_lift-off_weight rdf:type owl:NamedIndividual .
*
gistd:_Aspect_half-life rdf:type owl:NamedIndividual .
*
gistd:_Aspect_half-value_thickness rdf:type owl:NamedIndividual .
*
gistd:_Aspect_landau-ginzburg_number rdf:type owl:NamedIndividual .
*
gistd:_Aspect_lande_g-factor rdf:type owl:NamedIndividual .
*
gistd:_Aspect_long-range_order_parameter rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_macroscopic_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_macroscopic_total_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_non-leakage_probability rdf:type owl:NamedIndividual .
*
gistd:_Aspect_nozzle_throat_cross-sectional_area rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_over-range_distance rdf:type owl:NamedIndividual .
*
gistd:_Aspect_rf-power_level rdf:type owl:NamedIndividual .
*
gistd:_Aspect_short-range_order_parameter rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_area rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_density rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_distance rdf:type owl:NamedIndividual .
*
gistd:_Aspect_spectral_angular_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_spectral_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_stress-optic_coefficient rdf:type owl:NamedIndividual .
*
gistd:_Aspect_total_cross-section rdf:type owl:NamedIndividual ;

From: Rebecca Younes @.>
Sent: Monday, August 5, 2024 2:17 PM
To: semanticarts/gist @.>
Cc: Michael J. Sullivan @.>; Comment @.>
Subject: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
Agreed, we should use underscores rather than hyphens.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/semanticarts/gist/issues/1141*issuecomment-2269640216__;Iw!!ACWV5N9M2RV99hQ!P0SiZQGjXXRsh7__t62TI-nuE_LLww-GMUbUnTArX1IIwjSpaa41uNd8TSrTVAB03Nb8rjmP5pUqZ2tnlE3hJZOAEz-dX8E$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOMYTH7T5F3KGF2O3DNESX3ZP66VNAVCNFSM6AAAAABL44TENWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRZGY2DAMRRGY__;!!ACWV5N9M2RV99hQ!P0SiZQGjXXRsh7__t62TI-nuE_LLww-GMUbUnTArX1IIwjSpaa41uNd8TSrTVAB03Nb8rjmP5pUqZ2tnlE3hJZOAYcC8Z4M$.
You are receiving this because you commented.Message ID: @.***>

another typo (I assume)

gistd:_Aspect_vision_threshods
I assume should be

gistd:_Aspect_vision_thresholds

From: Michael J. Sullivan @.>
Sent: Tuesday, August 6, 2024 9:43 AM
To: semanticarts/gist @.>; semanticarts/gist @.>
Cc: Comment @.>
Subject: Re: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
Also this: Why is there no gallon_us? (there is us_gallon and uk_gallon and gallon_uk and imperial_gallon. Are the latter three the same thing? Very confusing...)
e.g.
gistd:_UnitOfMeasure_gallon_uk                      rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_day              rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_hour             rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_minute           rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_second           rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_us_liquid_per_second    rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_us_per_hour             rdf:type owl:NamedIndividual .

From: Michael J. Sullivan @.>
Sent: Tuesday, August 6, 2024 9:22 AM
To: semanticarts/gist @.>; semanticarts/gist @.>
Cc: Comment @.>
Subject: Re: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
some more examples of hyphens used in gistd:
gistd:_Aspect_angular_cross-section rdf:type owl:NamedIndividual ;

gistd:_Aspect_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_cross-sectional_area rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_debye-waller_factor rdf:type owl:NamedIndividual .
*
gistd:_Aspect_g-factor_of_nucleus rdf:type owl:NamedIndividual .
*
gistd:_Aspect_gross_lift-off_weight rdf:type owl:NamedIndividual .
*
gistd:_Aspect_half-life rdf:type owl:NamedIndividual .
*
gistd:_Aspect_half-value_thickness rdf:type owl:NamedIndividual .
*
gistd:_Aspect_landau-ginzburg_number rdf:type owl:NamedIndividual .
*
gistd:_Aspect_lande_g-factor rdf:type owl:NamedIndividual .
*
gistd:_Aspect_long-range_order_parameter rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_macroscopic_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_macroscopic_total_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_non-leakage_probability rdf:type owl:NamedIndividual .
*
gistd:_Aspect_nozzle_throat_cross-sectional_area rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_over-range_distance rdf:type owl:NamedIndividual .
*
gistd:_Aspect_rf-power_level rdf:type owl:NamedIndividual .
*
gistd:_Aspect_short-range_order_parameter rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_area rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_density rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_distance rdf:type owl:NamedIndividual .
*
gistd:_Aspect_spectral_angular_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_spectral_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_stress-optic_coefficient rdf:type owl:NamedIndividual .
*
gistd:_Aspect_total_cross-section rdf:type owl:NamedIndividual ;

From: Rebecca Younes @.>
Sent: Monday, August 5, 2024 2:17 PM
To: semanticarts/gist @.>
Cc: Michael J. Sullivan @.>; Comment @.>
Subject: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
Agreed, we should use underscores rather than hyphens.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/semanticarts/gist/issues/1141*issuecomment-2269640216__;Iw!!ACWV5N9M2RV99hQ!P0SiZQGjXXRsh7__t62TI-nuE_LLww-GMUbUnTArX1IIwjSpaa41uNd8TSrTVAB03Nb8rjmP5pUqZ2tnlE3hJZOAEz-dX8E$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOMYTH7T5F3KGF2O3DNESX3ZP66VNAVCNFSM6AAAAABL44TENWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRZGY2DAMRRGY__;!!ACWV5N9M2RV99hQ!P0SiZQGjXXRsh7__t62TI-nuE_LLww-GMUbUnTArX1IIwjSpaa41uNd8TSrTVAB03Nb8rjmP5pUqZ2tnlE3hJZOAYcC8Z4M$.
You are receiving this because you commented.Message ID: @.***>

this naming seems odd:

gistd:_UnitGroup_electrical_energy
versus

gistd:_UnitGroup_electric_charge
*
gistd:_UnitGroup_electric_current
*
gistd:_UnitGroup_electric_power

From: Michael J. Sullivan @.>
Sent: Tuesday, August 6, 2024 11:29 AM
To: semanticarts/gist @.>; semanticarts/gist @.>
Cc: Comment @.>
Subject: Re: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
another typo (I assume)

gistd:_Aspect_vision_threshods
I assume should be

gistd:_Aspect_vision_thresholds

From: Michael J. Sullivan @.>
Sent: Tuesday, August 6, 2024 9:43 AM
To: semanticarts/gist @.>; semanticarts/gist @.>
Cc: Comment @.>
Subject: Re: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
Also this: Why is there no gallon_us? (there is us_gallon and uk_gallon and gallon_uk and imperial_gallon. Are the latter three the same thing? Very confusing...)
e.g.
gistd:_UnitOfMeasure_gallon_uk                      rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_day              rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_hour             rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_minute           rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_second           rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_us_liquid_per_second    rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_us_per_hour             rdf:type owl:NamedIndividual .

From: Michael J. Sullivan @.>
Sent: Tuesday, August 6, 2024 9:22 AM
To: semanticarts/gist @.>; semanticarts/gist @.>
Cc: Comment @.>
Subject: Re: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
some more examples of hyphens used in gistd:
gistd:_Aspect_angular_cross-section rdf:type owl:NamedIndividual ;

gistd:_Aspect_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_cross-sectional_area rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_debye-waller_factor rdf:type owl:NamedIndividual .
*
gistd:_Aspect_g-factor_of_nucleus rdf:type owl:NamedIndividual .
*
gistd:_Aspect_gross_lift-off_weight rdf:type owl:NamedIndividual .
*
gistd:_Aspect_half-life rdf:type owl:NamedIndividual .
*
gistd:_Aspect_half-value_thickness rdf:type owl:NamedIndividual .
*
gistd:_Aspect_landau-ginzburg_number rdf:type owl:NamedIndividual .
*
gistd:_Aspect_lande_g-factor rdf:type owl:NamedIndividual .
*
gistd:_Aspect_long-range_order_parameter rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_macroscopic_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_macroscopic_total_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_non-leakage_probability rdf:type owl:NamedIndividual .
*
gistd:_Aspect_nozzle_throat_cross-sectional_area rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_over-range_distance rdf:type owl:NamedIndividual .
*
gistd:_Aspect_rf-power_level rdf:type owl:NamedIndividual .
*
gistd:_Aspect_short-range_order_parameter rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_area rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_density rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_distance rdf:type owl:NamedIndividual .
*
gistd:_Aspect_spectral_angular_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_spectral_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_stress-optic_coefficient rdf:type owl:NamedIndividual .
*
gistd:_Aspect_total_cross-section rdf:type owl:NamedIndividual ;

From: Rebecca Younes @.>
Sent: Monday, August 5, 2024 2:17 PM
To: semanticarts/gist @.>
Cc: Michael J. Sullivan @.>; Comment @.>
Subject: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
Agreed, we should use underscores rather than hyphens.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/semanticarts/gist/issues/1141*issuecomment-2269640216__;Iw!!ACWV5N9M2RV99hQ!P0SiZQGjXXRsh7__t62TI-nuE_LLww-GMUbUnTArX1IIwjSpaa41uNd8TSrTVAB03Nb8rjmP5pUqZ2tnlE3hJZOAEz-dX8E$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOMYTH7T5F3KGF2O3DNESX3ZP66VNAVCNFSM6AAAAABL44TENWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRZGY2DAMRRGY__;!!ACWV5N9M2RV99hQ!P0SiZQGjXXRsh7__t62TI-nuE_LLww-GMUbUnTArX1IIwjSpaa41uNd8TSrTVAB03Nb8rjmP5pUqZ2tnlE3hJZOAYcC8Z4M$.
You are receiving this because you commented.Message ID: @.***>

a minor link change for gistd:Aspect_voltage:

rdfs:seeAlso "http://www.iso.org/iso/home/store/catalogue_tc/catalogue_detail.htm?csnumber=31891"^^xsd:anyURI
should be

rdfs:seeAlso "https://www.iso.org/standard/77846.html"^^xsd:anyURI

From: Michael J. Sullivan @.>
Sent: Tuesday, August 6, 2024 11:29 AM
To: semanticarts/gist @.>; semanticarts/gist @.>
Cc: Comment @.>
Subject: Re: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
another typo (I assume)

gistd:_Aspect_vision_threshods
I assume should be

gistd:_Aspect_vision_thresholds

From: Michael J. Sullivan @.>
Sent: Tuesday, August 6, 2024 9:43 AM
To: semanticarts/gist @.>; semanticarts/gist @.>
Cc: Comment @.>
Subject: Re: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
Also this: Why is there no gallon_us? (there is us_gallon and uk_gallon and gallon_uk and imperial_gallon. Are the latter three the same thing? Very confusing...)
e.g.
gistd:_UnitOfMeasure_gallon_uk                      rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_day              rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_hour             rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_minute           rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_second           rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_us_liquid_per_second    rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_us_per_hour             rdf:type owl:NamedIndividual .

From: Michael J. Sullivan @.>
Sent: Tuesday, August 6, 2024 9:22 AM
To: semanticarts/gist @.>; semanticarts/gist @.>
Cc: Comment @.>
Subject: Re: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
some more examples of hyphens used in gistd:
gistd:_Aspect_angular_cross-section rdf:type owl:NamedIndividual ;

gistd:_Aspect_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_cross-sectional_area rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_debye-waller_factor rdf:type owl:NamedIndividual .
*
gistd:_Aspect_g-factor_of_nucleus rdf:type owl:NamedIndividual .
*
gistd:_Aspect_gross_lift-off_weight rdf:type owl:NamedIndividual .
*
gistd:_Aspect_half-life rdf:type owl:NamedIndividual .
*
gistd:_Aspect_half-value_thickness rdf:type owl:NamedIndividual .
*
gistd:_Aspect_landau-ginzburg_number rdf:type owl:NamedIndividual .
*
gistd:_Aspect_lande_g-factor rdf:type owl:NamedIndividual .
*
gistd:_Aspect_long-range_order_parameter rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_macroscopic_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_macroscopic_total_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_non-leakage_probability rdf:type owl:NamedIndividual .
*
gistd:_Aspect_nozzle_throat_cross-sectional_area rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_over-range_distance rdf:type owl:NamedIndividual .
*
gistd:_Aspect_rf-power_level rdf:type owl:NamedIndividual .
*
gistd:_Aspect_short-range_order_parameter rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_area rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_density rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_distance rdf:type owl:NamedIndividual .
*
gistd:_Aspect_spectral_angular_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_spectral_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_stress-optic_coefficient rdf:type owl:NamedIndividual .
*
gistd:_Aspect_total_cross-section rdf:type owl:NamedIndividual ;

From: Rebecca Younes @.>
Sent: Monday, August 5, 2024 2:17 PM
To: semanticarts/gist @.>
Cc: Michael J. Sullivan @.>; Comment @.>
Subject: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
Agreed, we should use underscores rather than hyphens.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/semanticarts/gist/issues/1141*issuecomment-2269640216__;Iw!!ACWV5N9M2RV99hQ!P0SiZQGjXXRsh7__t62TI-nuE_LLww-GMUbUnTArX1IIwjSpaa41uNd8TSrTVAB03Nb8rjmP5pUqZ2tnlE3hJZOAEz-dX8E$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOMYTH7T5F3KGF2O3DNESX3ZP66VNAVCNFSM6AAAAABL44TENWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRZGY2DAMRRGY__;!!ACWV5N9M2RV99hQ!P0SiZQGjXXRsh7__t62TI-nuE_LLww-GMUbUnTArX1IIwjSpaa41uNd8TSrTVAB03Nb8rjmP5pUqZ2tnlE3hJZOAYcC8Z4M$.
You are receiving this because you commented.Message ID: @.***>

Agreed, we should use underscores rather than hyphens.

In a current client engagement we gave this a lot of thought - we went with the convention that the ONLY underscores immediately surround the midfix class name. This avoids what we found to be annoying ambiguity about what exactly the midfix is. Its worth thinking about this.

In order to avoid the problem of being clear about the name-parts, I tend to mint URIs with the prefix, class, and local name separated with '/'.

FWIW, the project we are working on at Oracle has its own naming conventions, so whatever you end up doing here is fine with us. We use a pattern something along the lines of:

core:value_ISOLanguage-2letter a owl:DatatypeProperty .
core:value_ISOLanguage-3letter a owl:DatatypeProperty .

In order to avoid the problem of being clear about the name-parts, I tend to mint URIs with the prefix, class, and local name separated with '/'.

Having multiple /'s in the IRI has caused problems in the past with finding the fragment, so I have tended to avoid this.   It is especially problematic if  the no of /'s varies from IRI to IRI. We created a SPARQL query to find them all and changed them. However, the circumstances may be different and it worth reconsidering.

some more inconsistencies:

gistd:_UnitOfMeasure_electron_volt
*
gistd:_UnitOfMeasure_electron_volt_per_kelvin
*
gistd:_UnitOfMeasure_electron_volt_per_tesla
*
gistd:_UnitOfMeasure_electron_volt_second
*
gistd:_UnitOfMeasure_electronvolt_per_angstrom
*
gistd:_UnitOfMeasure_electronvolt_per_meter

From: Michael J. Sullivan @.>
Sent: Tuesday, August 6, 2024 2:04 PM
To: semanticarts/gist @.>; semanticarts/gist @.>
Cc: Comment @.>
Subject: Re: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
a minor link change for gistd:Aspect_voltage:

rdfs:seeAlso "http://www.iso.org/iso/home/store/catalogue_tc/catalogue_detail.htm?csnumber=31891"^^xsd:anyURI
should be

rdfs:seeAlso "https://www.iso.org/standard/77846.html"^^xsd:anyURI

From: Michael J. Sullivan @.>
Sent: Tuesday, August 6, 2024 11:29 AM
To: semanticarts/gist @.>; semanticarts/gist @.>
Cc: Comment @.>
Subject: Re: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
another typo (I assume)

gistd:_Aspect_vision_threshods
I assume should be

gistd:_Aspect_vision_thresholds

From: Michael J. Sullivan @.>
Sent: Tuesday, August 6, 2024 9:43 AM
To: semanticarts/gist @.>; semanticarts/gist @.>
Cc: Comment @.>
Subject: Re: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
Also this: Why is there no gallon_us? (there is us_gallon and uk_gallon and gallon_uk and imperial_gallon. Are the latter three the same thing? Very confusing...)
e.g.
gistd:_UnitOfMeasure_gallon_uk                      rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_day              rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_hour             rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_minute           rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_uk_per_second           rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_us_liquid_per_second    rdf:type owl:NamedIndividual .
gistd:_UnitOfMeasure_gallon_us_per_hour             rdf:type owl:NamedIndividual .

From: Michael J. Sullivan @.>
Sent: Tuesday, August 6, 2024 9:22 AM
To: semanticarts/gist @.>; semanticarts/gist @.>
Cc: Comment @.>
Subject: Re: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
some more examples of hyphens used in gistd:
gistd:_Aspect_angular_cross-section rdf:type owl:NamedIndividual ;

gistd:_Aspect_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_cross-sectional_area rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_debye-waller_factor rdf:type owl:NamedIndividual .
*
gistd:_Aspect_g-factor_of_nucleus rdf:type owl:NamedIndividual .
*
gistd:_Aspect_gross_lift-off_weight rdf:type owl:NamedIndividual .
*
gistd:_Aspect_half-life rdf:type owl:NamedIndividual .
*
gistd:_Aspect_half-value_thickness rdf:type owl:NamedIndividual .
*
gistd:_Aspect_landau-ginzburg_number rdf:type owl:NamedIndividual .
*
gistd:_Aspect_lande_g-factor rdf:type owl:NamedIndividual .
*
gistd:_Aspect_long-range_order_parameter rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_macroscopic_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_macroscopic_total_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_non-leakage_probability rdf:type owl:NamedIndividual .
*
gistd:_Aspect_nozzle_throat_cross-sectional_area rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_over-range_distance rdf:type owl:NamedIndividual .
*
gistd:_Aspect_rf-power_level rdf:type owl:NamedIndividual .
*
gistd:_Aspect_short-range_order_parameter rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_area rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_density rdf:type owl:NamedIndividual .
*
gistd:_Aspect_slowing-down_distance rdf:type owl:NamedIndividual .
*
gistd:_Aspect_spectral_angular_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_spectral_cross-section rdf:type owl:NamedIndividual ;
*
gistd:_Aspect_stress-optic_coefficient rdf:type owl:NamedIndividual .
*
gistd:_Aspect_total_cross-section rdf:type owl:NamedIndividual ;

From: Rebecca Younes @.>
Sent: Monday, August 5, 2024 2:17 PM
To: semanticarts/gist @.>
Cc: Michael J. Sullivan @.>; Comment @.>
Subject: [External] : Re: [semanticarts/gist] Letter case in instance data skos:prefLabels (Issue #1141)
Agreed, we should use underscores rather than hyphens.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/semanticarts/gist/issues/1141*issuecomment-2269640216__;Iw!!ACWV5N9M2RV99hQ!P0SiZQGjXXRsh7__t62TI-nuE_LLww-GMUbUnTArX1IIwjSpaa41uNd8TSrTVAB03Nb8rjmP5pUqZ2tnlE3hJZOAEz-dX8E$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOMYTH7T5F3KGF2O3DNESX3ZP66VNAVCNFSM6AAAAABL44TENWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRZGY2DAMRRGY__;!!ACWV5N9M2RV99hQ!P0SiZQGjXXRsh7__t62TI-nuE_LLww-GMUbUnTArX1IIwjSpaa41uNd8TSrTVAB03Nb8rjmP5pUqZ2tnlE3hJZOAYcC8Z4M$.
You are receiving this because you commented.Message ID: @.***>

In order to avoid the problem of being clear about the name-parts, I tend to mint URIs with the prefix, class, and local name separated with '/'.

Having multiple /'s in the IRI has caused problems in the past with finding the fragment, so I have tended to avoid this. It is especially problematic if the no of /'s varies from IRI to IRI. We created a SPARQL query to find them all and changed them. However, the circumstances may be different and it worth reconsidering.

^this. Please don't put multiple slashes in the IRI fragment's!!

Having multiple /'s in the IRI has caused problems in the past with finding the fragment, so I have tended to avoid this. It is especially problematic if the no of /'s varies from IRI to IRI. We created a SPARQL query to find them all and changed them. However, the circumstances may be different and it worth reconsidering.

I don't see the problem. Generally you shouldn't be trying to interpret meaning from an IRI's content. We tend to do that as humans and so we  like to embed human useful information into the URI. If you do that, I don't see the problem of putting the prefix and class between slashes before the local name, you can ignore an arbitrary number before the last 2. It is easy for a human or a machine to parse that if necessary if that is your goal.

^this. Please don't put multiple slashes in the IRI fragment's!!

I was not talking about URI/IRI fragments. We don't use the '#' in our namespaces.

In a current client engagement we gave this a lot of thought - we went with the convention that the ONLY underscores immediately surround the midfix class name. This avoids what we found to be annoying ambiguity about what exactly the midfix is. Its worth thinking about this.

@uscholdm There is no ambiguity: the first '.+' is the infix. Sometimes we have found it necessary to add additional infixes if the class name is not sufficient to guarantee uniqueness. For example, if a biography resource has multiple instances of HTML attached, you need something like :_FormattedContent_Summary_Biography_534 and :_FormattedContent_SourceStatement_Biography_534.
@Jamie-SA Your approach is fine in principle but it means upending everything we've done in gist and client projects for years. I'm not sure we want to shift gears at this point unless there's a compelling reason to prefer slashes over underscores.

I suggest that we settle this issue and standardize IRIs and preflabels before we merge develop to main in the reference data repo.

@rjyounes I am not suggesting a change to using slashes, I know that they are not generally used like this in gist, just mentioning that there is another opinion on the issue.

I was not talking about URI/IRI fragments. We don't use the '#' in our namespaces (or IRIs in general).
I thought you were talking about fragments. Can you give example(s) of what you are talking about?

I was not talking about URI/IRI fragments. We don't use the '#' in our namespaces (or IRIs in general).
I thought you were talking about fragments. Can you give example(s) of what you are talking about?

I was not talking about fragments, that was Michael Sullivan. To be clear, a URI fragment is what is after a '#' in the URI.
Example of auto generated URI: https://core.semanticarts.app/id/dcao/User/_nGmcxEnhV3cRj7T

I was not talking about fragments, that was Michael Sullivan. To be clear, a URI fragment is what is after a '#' in the URI.
Example of auto generated URI: https://core.semanticarts.app/id/dcao/User/_nGmcxEnhV3cRj7T

In your example, there is no '#'. but everything after one of the slashes is the fragment. The problem is there is no way to tell which one, so I can't tell where the fragment is.

@uscholdm There is no ambiguity: the first '.+' is the infix. Sometimes we have found it necessary to add additional infixes if the class name is not sufficient to guarantee uniqueness. For example, if a biography resource has multiple instances of HTML attached, you need something like :_FormattedContent_Summary_Biography_534 and :_FormattedContent_SourceStatement_Biography_534.

Are you thinking infix=midfix? Otherwise, want do you mean by infix? If you speak of 'the' infix being the first '.+', it makes no sense to speak of additional infixes. There can only be one first one. AT my current engament, we speak of

namespace prefix
midfix: the class name surrounded by underscores.
suffix: everything after the midfix

On rare occasions there is a reason to have the midfix not be a class name.
I guess it is not a big deal to avoid having additional underscores in the suffix, thank you for clarifying that.

In your example, there is no '#'. but everything after one of the slashes is the fragment. The problem is there is no way to tell which one, so I can't tell where the fragment is.

What definition of "fragment" are you using? So, everything after the hostname and first slash, is a fragment? Your last sentence does not make sense to me because I don't understand your definition of fragment.

@uscholdm I prefer the term "infix" to "midfix" because it's an existing word.
The first infix is the one indicating class, I am merely pointing out that I use others to avoid IRI collisions. I probably shouldn't have mentioned it. You may certainly have more than one infix, just not more than one first one.
This discussion is not terribly productive since we have an established convention for infixes which Phil has followed:
gistd:_UnitOfMeasure_X' and gistd:_Aspect_X`.
The questions that were initially raised are about what comes after the infix. I would like to establish conventions so that IRIs are predictable and uniform. I propose:

namespace_infix_remaining_in_all_lower_case_with_underscore_separators
Multiple underscores collapsed into one

E.g.,
gistd:_Aspect_total_cross_section
It should not be hard to normalize these according to this simple rule.

This sounds good ... (as proposed by Rebecca)

namespace_infix_remaining_in_all_lower_case_with_underscore_separators
Multiple underscores collapsed into one

The inconsistencies were "inherited" from QUDT, but it's probably good to standardize even though in principle we should not rely on the format of the IRI for any queries.


OSL plugin

Hi @dictoon ,
This is what I've implemented so far for OSL shader support.
I've rebased changes into several commits. Let me know if it needs to be fewer commits. I forgot to name the folder properly so there's one commit that renames the folder, hope that's alright, but I can rebase whole thing again.
I also changed number of bounces by default to 3.
Short description of how plugin works:

Global registry object in plugin.cpp holds vector of parsed OSLShaderInfo objects and vector of dynamically generated ClassDescriptor objects.
plugin.cpp was modified to include those ClassDescriptor-s.
Registry object also creates ParamBlockDescriptor-s based on shader parameters.
ClassDescriptor objects create actual material and texture plugin and pass them their class_id and parameter list.
Based on the list of parameters dynamic UI-s are generated when plugin creates dialog box in material editor.

Thanks for review.

Amazing! Thanks a lot. I'll review over the coming days.

I forgot to name the folder properly so there's one commit that renames the folder, hope that's alright.

Not a problem at all.

Thanks @dictoon ,
I've fixed the comments, squashed pr fixes into one commit and I'm merging this into master..


Not getting an option to mount volume for an azure container job at the time of start

Bug Report

import path of package in question:  `	aca "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers/v2"

SDK version: github.com/Azure/azure-sdk-for-go/sdk/azcore v1.9.0

Specify the exact commit if possible; one way to get this is the REVISION
column output by go list -m <module>, for example go list -m github.com/Azure/azure-sdk-for-go/sdk/azcore.

output of go version: go version go1.21.5 linux/amd64

What happened?
I have defined an azure container job using portal(not that it matters). The main container has the environment variables, volume mount defined. Now I am starting that job using the go sdk. I want to pass the arguments to my app running in side the container. To do that, I need to define the template for the container(I had already defined in when created the job).

Below is how i am defining the template.
	args := getContainerArgs(processId, debug, redisUri, meta, timeout)
	envId := fmt.Sprintf("/subscriptions/%s/resourceGroups/%s/providers/Microsoft.App/managedEnvironments/%s", subscriptionId, resourceGroupName, containerEnvName)
	container := aca.JobExecutionContainer{
		Name:  &containerExecutionName,
		Image: &containerImage,
		Args:  args,
	}
	jobTemplate := &aca.JobExecutionTemplate{
		Containers: []*aca.JobExecutionContainer{&container},
	}

The behavior i am seeing doing this is that, my volume mount and my environment variables that i defined at the time of job creation are not present when the job is running.
Now what i believe is happening here, is basically its overriding the configuration that i created at the time of the job creation. I could have done that, but I am seeing no way to attach volumes to the container. Although i can define environment variables.
The struct JobExecutionTemplate, allows me to defined the Containers and Init Containers but not volumes. This is a deal breaker for me to use jobs.

What did you expect or want to happen?
Either i wanted to be able  to just pass the arguements to the container in the job or able to also attach volume to the container job.

How can we reproduce it?
Basically create a container job with volume and environment variables defined and try passing just the arguments to the container.

Anything we should know about your environment.
I am running the job on dedicated workload profiles

I believe this is a root cause of an issue I've been debugging as well: volume mounts don't show up (e.g. the directories don't exist in the container) when I programmatically start a Container Apps Jobs execution, but they do when I start them from the UI (Run now) or via the az CLI.
Here's an example az CLI invocation:
az containerapp job start \
    --name ... \
    --env-vars '...' \
    --command '...' \
    --image ... \
    --resource-group ... \
    --verbose

# And the output:

Request URL: 'https://management.azure.com/subscriptions/.../resourceGroups/.../providers/Microsoft.App/jobs/.../start?api-version=2024-03-01'
Request method: 'POST'
Request headers:
    ... removing irrelevant headers ...
    'Content-Type': 'application/json'
    'CommandName': 'containerapp job start'
    'ParameterSetName': '--name --env-vars --command --image --resource-group --verbose'
Request body:
{
  "containers": [
    {
      "image": "...",
      "name": "...",
      "command": [
        "..."
      ],
      "args": null,
      "env": [
        ...
      ],
      "resources": null,
      "volumeMounts": null
    }
  ],
  "initContainers": null
}

The "volumeMounts": null is the main difference versus what the Azure Go SDK would generate, and my guess is that the API backend interprets null as "use the default volume mounts for the Container Apps Job", whereas it interprets the absence of the "volumeMounts" key as "don't add any mounts". I don't know if those semantics necessarily make sense, but they're my best guess as to what is actually happening.
I'm running github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers/v3, but even the latest v3.1.0-beta doesn't contain a volumeMounts option


Migration to React v19

According to https://react.dev/blog/2024/12/05/react-19 , on 5 of december, React v19 has been released, when do you mind to migrate to react v19?

Puck should be React 19 compatible already, and I'm updating the peer dependencies in #735. Internal use is more complicated, due to issues with related dependencies (#738).


disable prefer-symlinked-executables

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[x] Bugfix
[ ] Feature
[ ] Refactoring

What's new?

[x] fix https://github.com/kodadot/nft-gallery/pull/3530#issuecomment-1192661314
[x] fix https://github.com/kodadot/nft-gallery/issues/3539

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged the recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[ ] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

pay 30 usd

😍 Perfect, I’ve sent the payout
💵 $30 @ 65.57 USD/KSM ~ 0.458 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x584f1867b60f9aab5b906e7958b6c252206cbfb5918d4ef49f0a3d3cf74d0df4
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


When a rule implements the rule-with-message interface, the same instance should be used to provide the message

When generating validation messages, when using a rule that has the combined rule and message interface, the message provider should not construct/resolve a new instance of the class in order to get the message, it should use the same instance as the rule.
This will allow rule configuration data to be re-used.

It will also fix a crash error that would occur if the rule class were generic.


Regression in restart time benchmarks

SkiaPerf has identified a regression in restart time metrics:
https://flutter-flutter-perf.skia.org/e/?begin=1632536886&end=1633382183&keys=X9da79a237b5af9f0d5f350d84cee3803&requestType=0&xbaroffset=26039
The implicated change is https://github.com/flutter/flutter/pull/87991. Please consider reverting since we are trying to cut the beta branch this week.
/cc @blasten

/cc @christopherfujino

See also https://github.com/flutter/flutter/issues/81575 and https://github.com/flutter/flutter/pull/81586; I changed that logic, but not in a way that I expected to impact web. I'll look ASAP at why web isn't being filtered, but in the worst case I should be able put some of that logic back as a simple fix.
If we can wait until early tomorrow on a revert that would be good, as that change should fix some unfortunate regressions like https://github.com/flutter/flutter/issues/90920


Cache last commit to accelerate the repository directory page visit

Will replace #6045, resolve #491
On my local test (macOS ) with default cache setting(memory):
aports (home directory): 4010ms -> 225ms
vdsm (home directory): 1510ms -> 112ms
BTW: aports /main has many files, so I haven't tested it. We need a limitation on files listed. That will be another PR.

@lafriks need your approval.


Axlsx.sanitize() uses delete() vs. delete!() for frozen strings

Whenever a frozen string is passed as an input to any sanitized value, we are modifying it in place which raised a RuntimeError if that string is frozen (as you might expect constants like header or workbook names to be).  Use the safer delete() method which creates a new, modified copy of the string.

Hi @wpeterson please add specs to cover the forks for frozen/non-frozen and this will get merged and pulled into the 3.0.0 release branch.

@randym Thanks for taking a look!  I just pushed a commit with unit tests in b34286f6975679e9e5eb390241eb05f95759461b


remove parquet vector data cache related code

What changes were proposed in this pull request?
remove parquet vector data cache related code
How was this patch tested?
existing uts.

@ivoson @LuciferYang
After #1143 merged, I will propose ORC PRs, and merge ORC first.
Thanks.

@zhixingheyi-tian I suggest that we merge ORC PRs first, then consider how to refactor  BinaryFiberId and I think The implementation of #1143 is not satisfactory.

@LuciferYang
It's also fine.

@zhixingheyi-tian ok ~

@ivoson
Now  you can clean up  all vector cache.
Thanks

@ivoson
Now you can clean up all vector cache.
Thanks

@zhixingheyi-tian I have open a new pr https://github.com/Intel-bigdata/OAP/pull/1149 for this.  Please give a review.
And closing this pr.


udp_tunneling: allow HTTP/3 upstream to be used

Additional Description: HTTP/3 was explicitly disabled in the code, but it seems to work fine after testing.
Risk Level: low
Testing: Manual end-to-end test against Envoy as a CONNECT-UDP terminating proxy and the MASQUE server (from Google/QUICHE).
Docs Changes: none
Release Notes: none

/assign @ohadvano
As the original author, did I overlook anything to enable HTTP/3 support?
I included an example config file that uses a QUIC transport socket upstream. I tested it against Envoy as a CONNECT-UDP terminating proxy and the MASQUE server (from Google's QUICHE).
Thank you!

cc @ericorth

I exlicitly disabled it as I didn't want to account for that feature without trying it with a real server and having tests for it in Envoy, there shouldn't be a real issue adding it.
Thanks for trying it out and adding an example. I think that it's best to add tests with this PR. Please ask some maintainer to review as I'm out for a while.

/assign @alexiondev

/unassign @ohadvano

/wait-for integration test update to include HTTP3

/wait-any

/wait for integration test :)

/nostalebot

Seems that @kyessenov's comment to add an integration test hasn't been addressed yet.
/wait


Fix incorrect link to az webapp update in documentation

In the following paragraph Make updates and redeploy there is a link to the az webapp update command. The link however is set to az-acr-create command page documentation. The link may be fixed to point to https://learn.microsoft.com/en-US/cli/azure/webapp?view=azure-cli-latest#az-webapp-update.
Current text:
After you make code changes, you can redeploy to App Service with the [az acr build](https://learn.microsoft.com/en-us/cli/azure/group#az-group-create) and [az webapp update](https://learn.microsoft.com/en-us/cli/azure/acr#az-acr-create) commands.
Potential fix:
After you make code changes, you can redeploy to App Service with the [az acr build](https://learn.microsoft.com/en-us/cli/azure/group#az-group-create) and [az webapp update](https://learn.microsoft.com/en-US/cli/azure/webapp?view=azure-cli-latest#az-webapp-update) commands.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 34782954-131e-7e8f-5a8d-1b2f59de078d
Version Independent ID: 34782954-131e-7e8f-5a8d-1b2f59de078d
Content: Deploy a Flask or FastAPI web app as a container in Azure App Service - Python on Azure
Content Source: articles/python/tutorial-containerize-simple-web-app-for-app-service.md
Service: azure-python
GitHub Login: @bobtabor-msft
Microsoft Alias: rotabor

Actually the same goes for the first link: [az acr build](https://learn.microsoft.com/en-us/cli/azure/group#az-group-create. It should also be fixed to `https://learn.microsoft.com/en-us/cli/azure/acr#az-acr-build'


Why is India not listed on this page?

Even though there is Indian local functionality provided (see https://docs.microsoft.com/en-us/dynamics365/business-central/localfunctionality/india/india-local-functionality it is not listed on this page. Strange. Shouldn't it be added?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 203baec6-0fa8-b294-a7ee-5b5a4c153fde
Version Independent ID: 8f2c2fc3-f5e5-7c15-56c6-9a5fbc1a577a
Content: Local functionality in Business Central - Business Central
Content Source: business-central/about-localization.md
Service: dynamics365-business-central
GitHub Login: @edupont04
Microsoft Alias: edupont

Hi Luc,
Thank you for your feedback! You're right that we forgot to update the table. This will be fixed in the next doc update.

Now live.


Looking for a maintainer to help with the test suite here / maintain?

Hey @hozn please say the word if this is not something you want. I am now leading pyopensci. i wondered if i can help you find a new maintainer(s) through that effort - at a minimum i think we need a test suite that works on CI. i'm willing to help but don't feel confident with api based test suites as mocking / monkey patching is kind of an art and one that I dont want to abuse.

that would be awesome. @hozn i think i know the answer to this but are you ok with some help on refactoring the test suite so we can setup CI for it?

i might also be able to find a few others on twitter through my organization, pyopensci.

Part of the current test suite depends on an existing Strava account/API key. Mocking that part may require quite some (re-)work - many tests assume particular data to be there in Strava.
Maybe the first step for CI inclusion would be to start with only the unit tests since these are independent of the environment. After that, we can gradually add the existing functional/integration tests by mocking the Strava API.
Before proceeding, maybe we should think first about what exactly we want to test (based on coverage and priorities).

@lwasser , I appreciate the help you've provided on this project@  Finding a new maintainer would be great.  @yihong0618 if you're interested, I'm happy to set you up with perms (or @lwasser can do same, I believe).
@jsamoocha , agree that the functional tests aren't going to be easy to get running in CI.  I really wish strava would provide a key that could be used with test data for these sorts of purposes.  The biggest source of issues in the library is strava's continually changing API.  Usually that is just adding (and removing) attributes.  Hard to test without actual API access, though.

@hozn Thanks my pleasure.
I have made some repos based on strvalib like https://github.com/yihong0618/running_page and https://github.com/yihong0618/GitHubPoster
Kind of having a little stravalib source code.
I can do some code review, merge and  refactor jobs. @lwasser what do you think.

@yihong0618 this all sounds great.  I don't think I can add @yihong0618 as a maintainer @hozn so if you can do that - it would be great. And i really love the idea of starting with unit tests and slowly adding tests to hit the API as it makes sense.
One with with a mock is it would / could atleast detect a change in what strava returns but i get that testing the API is really hard as well. so @hozn please give permissions and @yihong0618 i am happy to provide input on test updates and refactoring but would look to you to do the actual implementation :)
i'm also happy to update docs as they need to be updated.
thank you!!

Is it necessary to test against the real/mocked Strava API? I can see (but please correct me if I'm wrong) the following approach working for this package:
Strava API additions: Someone will want to use a new endpoint or attribute and will eventually submit an issue/PR. We'll need to make sure (through code review or even automated) it is properly documented and added to the Sphinx autodoc magic.
Strava API updates: These will eventually lead to issues/PR's as above.
Strava endpoint removal: These will show up in CI as failed link checks in the documentation build (which happened to me today).
All changes in the Strava API that don't lead to issues/PR's seem to have no impact on users of this package. Proactive testing, in this case, may even only lead to delayed merging of unrelated PR's because of failed CI.

@lwasser , will do!  (And, yes, welcome any refactoring!)

To proactively check for changes in the Strava API (which I doubt should be part of CI), we could use the swagger API reference and some automated inspection of our own domain model and endpoints. It even has example responses we could use for testing happy paths (without having to write all te tests by hand).

@hozn @lwasser I think we also need to add one GitHub Actions workflow to upload the package to PyPI

I have some time to help with the following on a short term:

Add a Github Action workflow for the unit tests
Review the existing functional/integration tests and move all tests that are independent from the Strava API to the unit test package

@yihong0618 @lwasser please let me know if you agree with this approach and it doesn't overlap with your efforts

@jsamoocha cool.
But I think we can not add secret @hozn for this repo as Collaborators
if we use current way for unit tests we need add some secrets IMO

I don't think the unit tests require any secrets. I can run them locally without problems. Some tests in the functional test package depend on a (personal) Strava account; these could be left out of CI for the time being?

that will be nice, I think unit tests is enough for now, personal things we could test locally

Ok y'all - this is awesome. what do you think about opening up several issues here to track all of the work.
i will do that and assign each of us tasks. that way we can discuss each separately!
Here is a list of things that I think we need to work on

Upload to pypi. - a release workflow. I"m happy to work on this. Are you comfortable with my adding something like bump version to update versions in docs and throughout the package. Then we can really focus on semantic versioning We can then add an action to push to pypi on release. I would open an issue seeing if @hozn is comfortable with sharing pypi credentials with me and adding me as a full admin or giving me super powers to this repo to add secrets and such as people need to make those types of changes. i'm happy to oversee that!  @lwasser can work on this . I will also have a look at how change log is being handled as i do this and try to really clean up and document the release workflow!
Update test suite:

Create a new test suit that runs on CI. it sounds like for now we will focus on unit tests only and will keep tests on the API local. @yihong0618 it sounds like you'd like to work on this?
Add a CI build for that test suite - sounds like @jsamoocha can work on this

I think doing the above things will make is REALLY much easier for others to contribute too.
Colleagues - i do think we should consider some CI based tests for the api in the FUTURE or something that tests API functionality. i've seen things done with casettes for instance where we could record responses that could build on CI and update those periodically locally. but let's focus on what we can do now first to make it easier for others to contribute :) that can be a separate discussion in another issue! super psyched that y'all are willing to help here!!
Does this all sound good? if so i'll open a few issues and will request more permissions from @hozn to oversee this new dev work!

sounds great. Thank you.

hey @yihong0618 @jsamoocha i wanted to check back in here! @hozn setup stravalib here in a new org! this will make it easier to give teams permissions to work on stravalib. I also can help wtih that!
I think Hans also added me to pypi - i need to check that. Once i have a bit of time I can work on the build upon release workflow via a github action.
In the meantime, what type of permissions do y'all need to get started here?
I have the following on my list:

Setup pypi release /github action
Update readme with badges for this and probably update doc workflow on read the docs given the migration to this org!
Create issues that clarify who is doing what based upon this issue!!

Let me know if you need different permissions or if you need anything to get started!  🎆

Hi @lwasser ,
If @yihong0618 and I could have write permissions (or something more fine-grained just to allow us to merge PRs), we would be less dependent on your and @hozn 's time availability for merges.
I'm making some progress in modernizing the test suite (see #245), so that doesn't need a separate issue anymore.
What remains is IMO thinking about if and how we're going to test our "compliance" to the Strava API (e.g., by checking if all declared endpoints have an implementation in stravalib). This could be a scheduled job that acts à la dependabot. We could have this discussion in a separate issue if you want to.

@lwasser , I'll defer to you to grant write perms, as you're the one actively maintaining this, but certainly support more folks having write perms to the repo!

ok awesome @hozn i'll go ahead and get everyone maintainer level permissions to be able to handle pr's !! :)thanks for chiming in here Hans so I know this is ok!!

Ok @yihong0618 @jsamoocha i've provided both with write access vis a maintainer team that i created. I could bump you to maintainers if you need that level of access - please let me know.! You should be able to merge pr's. i'm going to lock down the main branch to avoid direct pushes to main without a PR.
it think it's nice to have issues for things just to track things that have been completed in pr's with issues that describe the goal of that item, etc. especially if we implement a change log update for releases and patches and such!

Ok, I made an issue describing the test/CI refactoring work; see #246


Can't exit full screen on MacOS

Testing #202857
Not sure if this bug is related to this issue, but i can't exit full screen on MacOs. The button seems to be disabled. This error only happens on Insiders.

Tracked in https://github.com/microsoft/vscode/issues/203116


JupyterLab cannot save files

When using JupyterLab (and now Jupyter Notebook) the autosave process raise the following error :

As I am currently using the file I always click on overwrite but then it raises another error :

Note that you get the same one when you click on the save button.

If I click on dismiss, close the file and reopen it, my file has been saved normally and i can continue working.

The problem started a month ago, but this behavior was not systematic. sometimes it wasn't working, sometime it was all right. From this week, every time I'm using JupyterLab or Jupyter Notebook I get these popups.
Am I the only one ?
Is there a solution ?

It seems that the problem is linked to the instability of my internet connection when the Time capsule of my macbook start to sync.
I'll close it at the moment because it's too specific but it means that Jupyter is not able to link back to the kernel/instance once it looses the connection.


Support mobile User-Agents and the ability to switch between desktop/mobile

Hello,
Expected Behavior
Generally, when scraping one would want to use the mobile version of a website since it is smaller and and thus saves on both speed and network traffic. However, sometimes you have information that is only available on desktop (or mobile) and so you want to switch. Therefore it would be nice if Scrapoxy allowed the user to specify what type of UA to use (via a header or something).
Actual Behavior
Scrapoxy just gets a random UA from a list.

Version of Scrapoxy: 3.1.1

I checked the code and this seems fairly trivial to implement. Since I need this feature, I'm going to fork and implement it, so I can make a PR later as well :)
Thanks,
Stealthmate

Good idea for the next version


tools/syz-declextract: don't analyze host files

I've got this error when trying to run the tool:
arch/x86/tools/relocs_64.c: In file included from arch/x86/tools/relocs_64.c:2:
In file included from arch/x86/tools/relocs.h:5:
/usr/include/stdio.h:33:10: fatal error: 'stddef.h' file not found
The arch/x86/tools/relocs_64.c is part of some host tool
that was compiled with gcc. And probably my clang installation
is somehow broken and can't compile normal user-space C programs.
Skip files that were not compiled with clang.
We don't need to analyze them (host tools),
and it also solves my clang problem.

@pimyn-girgis please review

LGTM.


Add motion blur pass

Recently I've hacked the motion blur pass from gkjohnson/threejs-sandbox and this PR to work with the postprocessing library.
It would be great if this was supported as a first class pass and included in postprocessing, with @gkjohnson approval of course.
I could make a PR but I'd need the help of @vanruesc to adapt the code to the repo standard and maybe tweak the render workflow.

Hey @marcofugaro! I've toyed with the idea of maintaining a package of some of the effects in my sandbox repo but I'm finding I don't have the time with everything else. If adding it to this package enables some nicer looking WebGL projects then that sounds great to me! A small attribution at the top of the file saying where the effect was adapted from would be nice but not necessarily required.
I'm not sure which version of the effect you've used but I recently updated the effect to include a couple different "smear" sampling approaches which can greatly improve the quality and can let you get by with far fewer passes. Specifically using blue noise sampling seems to look the best to me but perhaps the random sampling used elsewhere in this project is good enough.
A couple other things that might improve the effect if there's an easy way to add them here:

Transparent objects could be drawn last after motion blur has been been performed otherwise they will just blur the objects behind them depending on their opacity. Of course this means that transparent objects would not get motion blur applied. This might be something the end user has to do, though.

Blur samples could be optionally discarded (or weighted) based on how far in front of the estimated previous position the depth buffer is otherwise objects in the foreground can "bleed" into the motion blur.

The improvement from the above two changes might be minimal but I've had them in mind. If it turns out there's interest in adding this I'm happy to help out with whatever questions you have. I'd like to learn a bit more about extending this project, as well.

Specifically using blue noise sampling seems to look the best to me but perhaps the random sampling used elsewhere in this project is good enough.

I tried the new version with smearing, and I found out that the random smearing is kinda noticeable with the naked eye, but maybe is good for some other use cases. I resorted to the bluenoise or just plain high samples.

Blur samples could be optionally discarded (or weighted) based on how far in front of the estimated previous position the depth buffer is otherwise objects in the foreground can "bleed" into the motion blur.

Nice!

If it turns out there's interest in adding this I'm happy to help out with whatever questions you have. I'd like to learn a bit more about extending this project, as well.

By all means, you can make the PR as well if you want, I just want to be able to use the MotionBlur pass with this easy-to-use library.
It just needs some direction from @vanruesc since he is the main maintainer of the project and he will be maintaining the pass. Hope he is interested in including this pass as well.
For example, I wanted to ask, what is the corresponding method of doing new Pass.FullScreenQuad() in postprocessing?
https://github.com/gkjohnson/threejs-sandbox/blob/2590e4978f0cac023b65e01086ccef0b8d8bb2a4/motionBlurPass/src/MotionBlurPass.js#L129

Specifically using blue noise sampling seems to look the best to me but perhaps the random sampling used elsewhere in this project is good enough.

I tried the new version with smearing, and I found out that the random smearing is kinda noticeable with the naked eye, but maybe is good for some other use cases. I resorted to the bluenoise or just plain high samples.

Blur samples could be optionally discarded (or weighted) based on how far in front of the estimated previous position the depth buffer is otherwise objects in the foreground can "bleed" into the motion blur.

Nice!

If it turns out there's interest in adding this I'm happy to help out with whatever questions you have. I'd like to learn a bit more about extending this project, as well.

By all means, you can make the PR as well if you want, I just want to be able to use the MotionBlur pass with this easy-to-use library.
It just needs some direction from @vanruesc since he is the main maintainer of the project and he will be maintaining the pass. Hope he is interested in including this pass as well.
For example, I wanted to ask, what is the corresponding method of doing new Pass.FullScreenQuad() in postprocessing?
https://github.com/gkjohnson/threejs-sandbox/blob/2590e4978f0cac023b65e01086ccef0b8d8bb2a4/motionBlurPass/src/MotionBlurPass.js#L129

My current plan is to add a central buffer management system to postprocessing in the near future if time permits. I'd also like to convert the project to TypeScript. Passes and effects will receive a new input/output system for render targets and uniforms and I want to remove all deprecated methods, classes and fields before finally releasing a new major version.
These are big changes, so I think it would be better to wait until that's done before adding more complex effects. The goal of these changes is to make it easier for people to contribute.
Although I personally don't like motion blur, I'm not opposed to adding it to the library. I saw that the implementation uses some of three's built-in shader chunks which could complicate things later on. We might want to wait for NodeMaterials before adding this effect.

what is the corresponding method of doing new Pass.FullScreenQuad() in postprocessing?

You'd just set a fullscreen material with Pass.setFullscreenMaterial(material) and the pass would then use the shared internal fullscreen triangle. However, the composite shader should actually be implemented as an effect since its a fullscreen effect.

My current plan is to add a central buffer management system to postprocessing in the near future if time permits. I'd also like to convert the project to TypeScript. Passes and effects will receive a new input/output system for render targets and uniforms and I want to remove all deprecated methods, classes and fields before finally releasing a new major version.
These are big changes, so I think it would be better to wait until that's done before adding more complex effects. The goal of these changes is to make it easier for people to contribute.
Although I personally don't like motion blur, I'm not opposed to adding it to the library. I saw that the implementation uses some of three's built-in shader chunks which could complicate things later on. We might want to wait for NodeMaterials before adding this effect.

what is the corresponding method of doing new Pass.FullScreenQuad() in postprocessing?

You'd just set a fullscreen material with Pass.setFullscreenMaterial(material) and the pass would then use the shared internal fullscreen triangle. However, the composite shader should actually be implemented as an effect since its a fullscreen effect.

These are big changes, so I think it would be better to wait until that's done before adding more complex effects.

Alright, thanks for maintaining this repo.

I saw that the implementation uses some of three's built-in shader chunks which could complicate things later on. We might want to wait for NodeMaterials before adding this effect.

We could just include the chunks code in the shader in the meantime, and add a comment to which chunk the code is copied from, for future improvements.

These are big changes, so I think it would be better to wait until that's done before adding more complex effects.

Alright, thanks for maintaining this repo.

I saw that the implementation uses some of three's built-in shader chunks which could complicate things later on. We might want to wait for NodeMaterials before adding this effect.

We could just include the chunks code in the shader in the meantime, and add a comment to which chunk the code is copied from, for future improvements.

@marcofugaro

By all means, you can make the PR as well if you want, I just want to be able to use the MotionBlur pass with this easy-to-use library.

I don't think I'll have the bandwidth to do it myself but I'm happy to follow along when the PR is made and answer any questions!

I saw that the implementation uses some of three's built-in shader chunks which could complicate things later on.

I believe all of the used shader chunks are just required for skinned meshes to compute the pixel movement from the previous frame. A first pass could not include support for skinned animation velocity.

@marcofugaro

By all means, you can make the PR as well if you want, I just want to be able to use the MotionBlur pass with this easy-to-use library.

I don't think I'll have the bandwidth to do it myself but I'm happy to follow along when the PR is made and answer any questions!

I saw that the implementation uses some of three's built-in shader chunks which could complicate things later on.

I believe all of the used shader chunks are just required for skinned meshes to compute the pixel movement from the previous frame. A first pass could not include support for skinned animation velocity.

I'm interested in helping with the process of integrating motion blur to this library! Motion blur has a special place in my heart as I cut my teeth on advanced shader effects with it when I added rigid motion blur to my homegrown box2d engine over 10 years ago. This is probably my proudest achievement from my teenage years.

Fragment_shader_dynamic_blur.pdf
While motion blur gets a bad rap because it's often abused in games, functionally detracting from clarity and adding control latency, especially when implemented poorly, I believe that tastefully/subtly applying motion blur goes a long way toward making a 3d scene look realistic (short of 144hz+ display and corresponding framerate). It's impossible to make up that ground in terms of latency on a 60hz display, but in terms of perceived fluidity, motion blur can add a lot.
@gkjohnson I hadn't seen your demo until now but I am blown away, as that is a very high quality implementation of motion blur in 3D and in my opinion it looks every bit as good as the best AAA game implementations I've seen out there. We probably pay a bit of a tax implementing it on top of three.js, as this sort of advanced technique is best done with an engine built around it! But at least it runs like a dream on my RTX3080! Haha. I'm just so impressed by how far three.js has come.
The thing that I realized 12 years ago was that motion blur disproportionately benefits the clarity of perception of small objects that are moving fast. I don't think I particularly chose the domino tower dynamics for highlighting this, but it does it well. It's even more apparent when you use the box2d mousejoint (click on an object and drag it around) and fling around the little dominoes. With 50 samples of motion blur it creates an effective framerate of 60 * 50 = 3000 fps, and even higher on modern high refreshrate displays. This is capable of showing tiny nuances in motion in the same way that they are perceived in real life.

Recently I've hacked the motion blur pass from gkjohnson/threejs-sandbox and this PR to work with the postprocessing library.

Could you please the code? because i was using @gkjohnson 's motion blur shader, but i just moved to this project's library, i didnt know how i'd be able to get it to work with this lib

Hey all, is this going to get added anytime soon or is it dead?

@kitaedesigns This hasn't been added yet because v6 doesn't provide the tools to implement it efficiently. With v7 mostly ready, we can now start working on this.
Closing in favor of #577 and #582.


new: add a new drop category n_drops_scratch_map

Signed-off-by: Andrea Terzolo<EMAIL_ADDRESS>What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This PR allows computing the delta also for scratch_map drops.
The scratch_map drops are a new drop category introduced here.
These drops are related only to the bpf probe: a scratch_map drop happens when an event is too large and cannot be saved into the frame_scratch_map before being sent to userspace. The idea here is to clearly separate drops due to a full buffer from those caused by events that are too large. For more information take a look at this PR :point_down:
https://github.com/falcosecurity/libs/pull/224
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
new: add a new drop category `n_drops_scratch_map`

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Andreagit97
To complete the pull request process, please assign fntlnz after the PR has been reviewed.
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/retest

LGTM label has been added.  Git tree hash: f7ab0a6bdcc260f590bd4c7cee9b64a195643b14

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.32.0


Add check for duplicate operation ids

Fixes #68

James, what is your plan with the 4.x branch? Shall I create another PR for this to get back-ported?

@BigstickCarpet any feedback yet?

@marcelstoer - I somehow completely missed this PR, so thank you for pinging me on it.  It looks great!  Thanks for adding a test too 👍

whoops!  The browser tests failed because Array.includes() isn't supported on older browsers.  I'll fix that and retry the tests

No worries, how about that question about the 4.x branch above?

The browser tests (SauceLabs) don't run for PRs because Travis CI doesn't set environment variables (e.g. my SauceLabs credentials) for PR builds.   So browser tests only run once the PR is merged into Master.
As for the 4.x branch... It's no longer actively supported/maintained.  It's mostly just there for archival purposes, and maybe hotfixes.  Is there a particular reason you're using 4.x instead of 5.x?

Is there a particular reason you're using 4.x instead of 5.x?

I'm not, was just asking out of curiosity. Every project has a different policy.

ah, ok.  Well let's just leave this on 5.x then.  I don't think anybody's even using the 4.x branch anymore.

This change broke our builds. I wonder if this could have been released as a major version, or if not a minor version, but not a patch. I seems to me that adding validation logic should be considered as adding a feature. Wdyt?

I would want this change to break my builds. It means that my Swagger files haven apparently been invalid so far but it went unnoticed. Or did your builds break for different reasons?

I am part of a large organisation who has thousands of builds that depend on libraries like this. When backward incompatible changes like this are released under a patch version and builds are unexpectedly broken it creates significant disruption. I completely agree we want to know when our Swagger files are invalid, however I don't believe the right way to achieve this is to without warning suddenly force everyone to deal with this, despite what other priorities they have.

@BenSayers - I apologize for the disruption.  I didn't think this would be a breaking change, since it was just adding a check for something that's already part of the Swagger 2.0 spec.  But you're right, I should have been more careful and released it as a major or minor version bump, not a patch.
For future reference, you can disable the Swagger spec validation in Swagger Parser by setting the validate.spec option to false.  It will still validate your API against the Swagger schema.  It just won't run the additional spec-compliancy checks.
var options = {
    validate: {
        spec: false
    },
};

SwaggerParser.validate("my-api.yaml", options, callback);


Bitcode bundle could not be generated error because AGConnectAppLinking was built without full bitcode

Description
Cannot build archive in XCode.
Bitcode bundle could not be generated error because AGConnectAppLinking was built without full bitcode.
Exact error:
bitcode bundle could not be generated because '/app/ios/Pods/AGConnectAppLinking/AGConnectAppLinking.framework/AGConnectAppLinking(Pods-AGConnectAppLinking-dummy.o)' was built without full bitcode. All object files and libraries for bitcode must be generated from Xcode Archive or Install build file '/app/ios/Pods/AGConnectAppLinking/AGConnectAppLinking.framework/AGConnectAppLinking' for architecture armv7
Expected behavior
To be able to archive
Current behavior
Error in archiving
Environment

Platform: ReactNative
Kit: App Linking
OS: iOS

Hello, I tried to archive a react native project with AGC AppLinking plugin and got the same issue.
I found a way to fix it.
Select your target > Build Settings and search for Enable Bitcode and set to No

Hello, I tried to archive a react native project with AGC AppLinking plugin and got the same issue.
I found a way to fix it. You need to disable bitcode otherwise you need to wait for plugin to support full bitcode.
Select your target > Build Settings and search for Enable Bitcode and set to No


Handle page compiling within the page models

The page models are used to hold data for how pages are compiled. So why not define the compile rules there as well? This will also make it much easier to add a dynamic framework for registering new page types, without having to hard-code them in the static page builder.
Internally, this refactor is done by adding a new CompilableContract interface that the page models now implement. For Markdown pages, a new static property has been added to hold the view name (making it easy to swap out).
The results for the end user does not change. However, it will make the framework more modular, and reduce complexity.

Tagging this for the release after the next one, so holding off with updating the release notes.


Cannot update field.

I'm trying to update the "AccountSource" field on the Account object in Salesforce via the following code:
Dim a As Object = New ExpandoObject()
a.AccountSource = "Test"
Await client.UpsertExternalAsync("Account", "External_Id__c", 12345, a)

It gives me the following error: "No such column 'AccountSource' on sobject of type Account"
I know the field should exist. I can see it in Salesforce. I believe I have the name correct according to the documentation and what I see in the Salesforce setup.
I have also done a very similar operation using the "LeadSource" field on the Lead (which is a very similar field using the same picklist) and it worked properly.
Perhaps I am just doing something wrong, but if so, I can't see where. I don't know that it's a bug in the toolkit, but I don't know what else it could be.
Any assistance would be greatly appreciated.
Thanks

It's been awhile since I've used VB, so apologies for switching to C#.
The first time I run this I get the error Salesforce.Common.ForceException : Required fields are missing: [Name] given that the record doesn't exist already. So, I've modified the code slightly to include a Name in the ExpandoObject:
[Test]
public async void UpdateExternalAsync_AccountSource()
{
    dynamic a = new ExpandoObject();
    a.AccountSource = "TestAccountSource";
    a.Name = "TestAccountName";

    const string objectName = "Account";
    const string fieldName = "External_Id__c";

    await CreateExternalIdField(objectName, fieldName);

    var externalId = Convert.ToString(DateTime.Now.Ticks);

    var success = await _client.UpsertExternalAsync(objectName, fieldName, externalId, a);
    Assert.IsNotNull(success);

    a.AccountSource = "TestAccountSource2";

    success = await _client.UpsertExternalAsync(objectName, fieldName, externalId, a);
    Assert.IsNotNull(success);
}

This runs as expected.
Here's the first response ...
HTTP/1.1 201 Created
Date: Mon, 26 Jan 2015 20:07:55 GMT
Set-Cookie: BrowserId=zOSemo7PQrS9nVqlN0H2RQ;Path=/;Domain=.salesforce.com;Expires=Fri, 27-Mar-2015 20:07:55 GMT
Expires: Thu, 01 Jan 1970 00:00:00 GMT
Sforce-Limit-Info: api-usage=176/15000
Location: /services/data/v32.0/sobjects/Account/001F000001N05ypIAB
Content-Type: application/json;charset=UTF-8
Transfer-Encoding: chunked

35
{"id":"001F000001N05ypIAB","success":true,"errors":[]
1
}
0

... and the second response ...
HTTP/1.1 204 No Content
Date: Mon, 26 Jan 2015 20:07:56 GMT
Sforce-Limit-Info: api-usage=176/15000

Am I missing something?
Sorry for your trouble!

I have packaged and pushed the update to DeveloperForce 0.6.5 - https://www.nuget.org/packages/DeveloperForce.Force/

Ya, I don't get it. It should work. It just doesn't.

Ya, I don't get it. It should work. It just doesn't.

Do the exact same thing without the AccountSource field and it works fine.

Please use Fiddler and see what the response is that comes back. Confirm the data is in the response.
I'll close this for now but please open it if you still have the issue.

Turned out the field was marked as not accessible even by system administrators. That was just not something I realized could have been a problem. I do now.
Thanks for all your patience and help.


Story #1 - Submit location

As an end user, I want the ability to submit a location and pictures to the app to help other users find a new bathroom.

I am reading this as "Create a bathroom"


Install Error - Error opening flogo app project: Invalid project, source directory doesn't exists

I'm submitting a ...  (check one with "x")
[] bug report => search github for a similar issue or PR before submitting
[] enhancement request
[] feature request
[x] support request
[] general question

Current behavior (how does the issue manifest):
Follow up the install guide, run with command:
flogo install github.com/TIBCOSoftware/flogo-contrib/activity/log

But finally an error has occurred,
Error opening flogo app project: Invalid project, source directory doesn't exists

I had search the question in Issues, there was a issue like this, but it's solution is upgrade the cli version since he is used 0.5.6 before. This can not solved my issue.
Expected behavior:
Expected it can install the component what i need.
Minimal steps to reproduce the problem (not required if feature enhancement):
What is the motivation / use case for changing the behavior?
Please tell us about your environment (Operating system, docker version, browser & verison if webui, etc):
Win 10 * 64, docker 2.0.0, chrome.
Flogo version (CLI & contrib/lib. If unknown, leave empty or state unknown): 0.X.X
flogo cli version [v0.5.7]
Additional information you deem important (e.g. issue happens only occasionally):

Hi! Just to check, did you run the command “flogo install” after running “flogo create”? The latter command will create the outline of an application for you and the former command will allow you to install new activities into an existing app.

@josenspire yes, first you need to create the project structure, as @retgits had said. Then you'll cd into that dir and run the flogo install command. If you create an application using the -f switch and specify an existing application that you created via the Web UI, then the CLI will install all the dependencies for you.


Add plugin that will delete highlighted content

Hi. This will add a plugin that will delete highlighted content on the page.

Also added a small addition to popup.js to determine if today is april fools day and if not will not allow any functionality and tell them to come back on april fools day.


Bump dependencies

Description
Bump dependencies

Codecov Report
Patch and project coverage have no change.

Comparison is base (f1153fb) 100.00% compared to head (960916c) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff            @@
##            master       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            8         8
  Lines          569       569
=========================================
  Hits           569       569

Flag
Coverage Δ

unittests-Linux
?

unittests-macOS
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


use container inside callback function

Hi, I have a problem when using container inside callback function. I can't have this code work,  I get "PHP Notice:  Trying to get property of non-object in... " when doing ...$dbObj->get_db()....
I am doing something wrong?
// database handler
$container['db_handler'] = function ($container) {
$db = new DB();
return $db;
};
$app->add(new \Slim\Middleware\JwtAuthentication([
"secret"       => "supersecretkeyyoushouldnotcommittogithub"
,"path"         => "/"
,"algorithm"    => ["HS256", "HS512"]
,"attribute"    => "jwt"
,"secure"       => true
,"callback" => function ($request, $response, $arguments) use ($container) {
$dbObj = $container['db_handler']; // or  $container->get('db_handler')
if(!$db=$dbObj->get_db()) {
.....
}
}
]));

Do a print_r($container['db_handler']);in the callback to see what is in the container.

Hi, thanks doing so let me find the problem!!
One more question, Is there a way to send error message generated inside callback function to the error function? Thanks!

In the callback you should be able set the internal "last error message" property with something like:
$this->message = "Something bad happened.";


Firebase Authentication + Firestore setup

Firebase Authentication setup (dummy users added for now)

Basic login screen that allows users to login - see .../frontend/README for dummy credentials you can use for logging in (we may make it more fancy later once we have a logo etc.)

Basic logout functionality under "Settings" screen for verifying Firebase Auth (issue #38 handles this screen)

Firestore database setup

Data models for User and Field added (more models and fields can be added on basis of necessity in the future)

Very simple list of fields displayed under "My Fields" screen to verify database interaction (issue #16 will handle this)

The setup looks good, and the structure as well. Could you link the resource you used to do the authentication?


[WIP] Feature/CheXpert and CheXbert labelers

I ran into some issues when trying to adjust the Z matrix & was not able to resolve them until now, therefore the code is unfinished. (This will definitely be resolved by the end of the holidays)
Missing: pattern transformation, adjusting Z matrix depending on neg/unc patterns; improving code & file architecture
The build fails at the moment, but if I understand it correctly, this happens, because I use a file where all constants are defined and always just use import * from constants at the beginning of each file.

Added the pattern transformation, so now...
Missing: adjusting Z matrix depending on neg/unc patterns; improving code & file architecture

Still missing: file structure, deletion of unnecessary code parts, jupyter notebook

I am currently fixing errors in the code, but doing this in a separate pycharm project, since I was not able to quickly fix the negbio library issue in my knodle project. I will push the code when everything works.

The code should be working now, the jupyter notebook example is still missing.

Like I mentioned in my Issue, the file/class/fct names are not adjusted yet, since I'm still thinking about the right choice.


Add skip to content link

This PR adds a skip to content link to improve accessibility as described in: https://www.w3.org/TR/WCAG20-TECHS/G1.html (Requirement in WCAG 2.0).

Benefits
Improve accessibility for keyboard-only users.
Verification Process

The Skip to content link should be invisible until it gets focused.
Press Tab and the link should now be visible.
Pressing enter or clicking that button should change the focus to the main content area (#39

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my change.
[ ] All new and existing tests passed.

Changelog Entry
ADDED: Skip to content link

This is pending https://github.com/10up/wp-scaffold/pull/43 as the values might change depending on the base font size

Hey @AlejandroPerezMartin @joesnellpdx let me propose a few changes to this PR:

I was never a fan of the class name screen-reader-text as it is a bit misleading. Technically all text on the screen that's not hidden from screen readers is a screen reader text. What we are doing with screen-reader-text is kind of the opposite, we are visually hiding an element but making it accessible to screen readers. With that said, I think we should call it visually-hidden.

I also think we should introduce two utility classes instead of one: visually-hidden and visually-hidden-focusable. First one does not require a focused state and is useful for things like:

Learn more about {{articleTitlte}}

... and the second for things like the skip to content link.

Speaking of the skip to content link. I think it should be a separate component in CSS. screen-reader-text (or visually-hidden-focusable) class is meant to be used as a utility class, so applying styles meant only for skip to content link to its focused state isn't correct. Most likely other elements with this class will need different position, font size, background and padding. We'll have to override those every time we use this class, which isn't productive.

For reference, I made proposed changes in this branch: https://github.com/10up/wp-scaffold/tree/feature/skip-to-content-link-updates
Feel free to compare these branches and let me know if you have any questions. Thanks!

All your points makes sense to me @dmtrmrv ! Could you please open a new PR? Then I'll close this one! Thanks a lot! 😄
cc @joesnellpdx

@AlejandroPerezMartin the new PR is here #47 We can close this one.

thanks @dmtrmrv!


Build UI direct in action, simplify UI Dockerfile, fix API release args

Also correct reference to environments repo

@riccardo-forina please take a look. This should get the build performance back to what it was prior to the multi-arch images being added. We can do another release once this is merged.


Migration to null-safety

cf. https://dart.dev/null-safety/migration-guide

I am currently about to check the packages. We are a bit restricted by outdated packages in openfoodfacts-dart. I'll update them really quick.

I guess openfoodfacts-dart is the priority, migration-wise.

Okay, since now we have the app working again lets focus on openfoodfacts-dart and smooth-app can follow

@monsieurtanuki @M123-dev I see we now use openfoodfacts: ^1.0.1-beta
is it solved ? now it's null safety within the app itself ?

@teolemon currently we are in a transition mode, alle dependencies including off-dart and smooth_ui_library use/support null-safety but the app itself not yet.

Done by #416.