HDFS-16816 RBF: auto-create user home dir for trash paths by router

Description of PR
In RBF, trash files are moved to trash root under user's home dir at the corresponding namespace/namenode where the files reside. This was added in HDFS-16024. When the user home dir is not created before-hand at a namenode, we run into permission denied exceptions when trying to create the parent dir for the trash file before moving the file into it. We propose to enhance Router, to auto-create a user home's dir at the namenode for trash paths, using router's identity (which is assumed to be a super-user).
How was this patch tested?
Add a new unit test (testMoveToTrashAutoCreateUserHome) to TestRouterTrash.
mvn test -Dtest="TestRouterTrash"
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hdfs.server.federation.router.TestRouterTrash
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.326 s - in org.apache.hadoop.hdfs.server.federation.router.TestRouterTrash
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0

For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 28s

trunk passed

+1 :green_heart:
compile
0m 50s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 50s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 44s

trunk passed

+1 :green_heart:
mvnsite
0m 53s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 38s

trunk passed

+1 :green_heart:
shadedclient
21m 22s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

-1 :x:
javac
0m 40s
/results-compile-javac-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 1 new + 55 unchanged - 0 fixed = 56 total (was 55)

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

-1 :x:
javac
0m 34s
/results-compile-javac-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 generated 1 new + 55 unchanged - 0 fixed = 56 total (was 55)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 23s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 7 new + 4 unchanged - 0 fixed = 11 total (was 4)

+1 :green_heart:
mvnsite
0m 39s

the patch passed

+1 :green_heart:
javadoc
0m 37s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 28s

the patch passed

+1 :green_heart:
shadedclient
21m  3s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
38m 34s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

136m 49s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5071

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux f91dcc080b25 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ec0ab34a520a2ca9e1e7fb76fc565eb4cfb6f75d

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/1/testReport/

Max. process+thread count
3429 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

yetus may come back with unit test failure of TestRouterRPCMultipleDestinationMountTableResolver. I have tested that this class is failing on trunk non-deterministically as well. Created another ticket (HDFS-16818) to handle this unit test failure.
TestRouterRPCMultipleDestinationMountTableResolver mainly tests with the following paths, which shouldn't be impacted with the change in this PR.
    Path mountDir = new Path("/mount/dir/dir");
    Path nameSpaceFile = new Path("/tmp/dir/file");
    Path mountFile = new Path("/mount/dir/file");
    Path mountEntry = new Path("/mount");
    Path mountDest = new Path("/tmp");
    Path nameSpaceDir = new Path("/tmp/dir/dir");

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 22s

trunk passed

+1 :green_heart:
compile
0m 50s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 38s

trunk passed

+1 :green_heart:
mvnsite
0m 51s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 38s

trunk passed

+1 :green_heart:
shadedclient
23m 59s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 36s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

-1 :x:
javac
0m 40s
/results-compile-javac-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 1 new + 55 unchanged - 0 fixed = 56 total (was 55)

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

-1 :x:
javac
0m 34s
/results-compile-javac-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 generated 1 new + 55 unchanged - 0 fixed = 56 total (was 55)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 20s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 2 new + 4 unchanged - 0 fixed = 6 total (was 4)

+1 :green_heart:
mvnsite
0m 39s

the patch passed

+1 :green_heart:
javadoc
0m 37s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 27s

the patch passed

+1 :green_heart:
shadedclient
24m  5s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
35m 32s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

157m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5071

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 071cfe371624 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1dae24f486414359c7cf280c59f21c8b2133196b

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/2/testReport/

Max. process+thread count
3177 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
docker
4m 23s

Docker failed to build run-specific yetus/hadoop:tp-29905}.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/5071

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/3/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 35s

trunk passed

+1 :green_heart:
compile
0m 51s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 38s

trunk passed

+1 :green_heart:
mvnsite
0m 51s

trunk passed

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 37s

trunk passed

+1 :green_heart:
shadedclient
24m 32s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 38s

the patch passed

+1 :green_heart:
compile
0m 39s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 39s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 19s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)

+1 :green_heart:
mvnsite
0m 39s

the patch passed

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 25s

the patch passed

+1 :green_heart:
shadedclient
24m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
35m 43s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

142m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5071

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c063aa131c1b 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8563b455f6c32f53fa683f43638fdda20e169846

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/4/testReport/

Max. process+thread count
3174 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m 17s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 23s

trunk passed

+1 :green_heart:
compile
0m 51s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 48s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 41s

trunk passed

+1 :green_heart:
mvnsite
0m 59s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 56s

trunk passed

+1 :green_heart:
shadedclient
21m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 41s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 29s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)

+1 :green_heart:
mvnsite
0m 42s

the patch passed

+1 :green_heart:
javadoc
0m 38s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 58s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 27s

the patch passed

+1 :green_heart:
shadedclient
20m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
38m  8s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

153m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5071

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux dae824abd7c5 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2503f7bb54236e0ac37db93d942c27d5261b396e

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/5/testReport/

Max. process+thread count
3407 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 16s

trunk passed

+1 :green_heart:
compile
0m 50s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 38s

trunk passed

+1 :green_heart:
mvnsite
0m 53s

trunk passed

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  4s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 39s

trunk passed

+1 :green_heart:
shadedclient
24m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 36s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
compile
0m 35s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 35s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 39s

the patch passed

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 27s

the patch passed

+1 :green_heart:
shadedclient
23m 47s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
35m 23s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

141m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5071

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 174626bea195 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1de60c62ba7199d53f603eb10f7e33cb4fb72cf7

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/6/testReport/

Max. process+thread count
3175 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 34s

trunk passed

+1 :green_heart:
compile
0m 51s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 38s

trunk passed

+1 :green_heart:
mvnsite
0m 50s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  4s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 38s

trunk passed

+1 :green_heart:
shadedclient
24m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
0m 39s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 39s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 38s

the patch passed

+1 :green_heart:
javadoc
0m 35s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 27s

the patch passed

+1 :green_heart:
shadedclient
23m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
35m 56s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

144m 25s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5071

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 66e7ee1dc096 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d73bf1396667f4b0b48274165ff5a6933a8d7981

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/7/testReport/

Max. process+thread count
3217 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m  4s

trunk passed

+1 :green_heart:
compile
0m 49s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 38s

trunk passed

+1 :green_heart:
mvnsite
0m 50s

trunk passed

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 39s

trunk passed

+1 :green_heart:
shadedclient
24m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
0m 39s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 39s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 37s

the patch passed

+1 :green_heart:
javadoc
0m 35s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 27s

the patch passed

+1 :green_heart:
shadedclient
23m 46s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
35m 27s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

141m 16s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRBFConfigFields

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5071

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c1fd5e2000d4 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 84c4504e51f5e4885700efd5b53c31a05550ecc2

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/8/testReport/

Max. process+thread count
3189 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 56s

trunk passed

+1 :green_heart:
compile
0m 50s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 37s

trunk passed

+1 :green_heart:
mvnsite
0m 50s

trunk passed

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 37s

trunk passed

+1 :green_heart:
shadedclient
24m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 36s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 19s

the patch passed

+1 :green_heart:
mvnsite
0m 37s

the patch passed

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 26s

the patch passed

+1 :green_heart:
shadedclient
24m  5s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
35m 20s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

139m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5071

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 679fe1c37824 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 74624770b0e1d2a8c69087a09d52671ebf975da8

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/10/testReport/

Max. process+thread count
3110 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m  7s

trunk passed

+1 :green_heart:
compile
0m 53s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 52s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 49s

trunk passed

+1 :green_heart:
mvnsite
0m 52s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 48s

trunk passed

+1 :green_heart:
shadedclient
21m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 22s

the patch passed

+1 :green_heart:
mvnsite
0m 41s

the patch passed

+1 :green_heart:
javadoc
0m 35s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 26s

the patch passed

+1 :green_heart:
shadedclient
20m 41s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
25m 22s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

124m 14s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5071

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 675d4c814a6d 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d8adefffaf7b57d9135109561b1673376bdd536d

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/11/testReport/

Max. process+thread count
3823 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m  5s

trunk passed

+1 :green_heart:
compile
0m 52s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 46s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 38s

trunk passed

+1 :green_heart:
mvnsite
0m 50s

trunk passed

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 39s

trunk passed

+1 :green_heart:
shadedclient
24m 12s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 21s

the patch passed

+1 :green_heart:
mvnsite
0m 39s

the patch passed

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 26s

the patch passed

+1 :green_heart:
shadedclient
25m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
36m 21s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

144m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5071

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux b556edd6e5e5 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a3c07dac9b460459a0edfc0803b976b652a7317e

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/12/testReport/

Max. process+thread count
3465 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5071/12/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

this PR is no longer pursued.


Make iree-flow-trace-dispatch-tensors print more values controllable

Current work around is to modify the length of the buffer manually.
https://github.com/google/iree/blob/6bd3b1dc13236566d1f8ee651cd3ab9b03dd8a1d/iree/modules/hal/hal_module.cc#L432-L444
Eg, replace 4096 with 4096*1024, and 1024 with 1024*1024.

https://github.com/google/iree/pull/3508 makes the default element count to be maximal.

At some point before the HAL module was converted to C the trace output got a compiler-controlled string key.


Implement Invoicing

We need to implement fixed price and T&M invoicing.
T&M is the priority.
The billing model is selected at the Job but can be overridden on individual Tasks to allow mixed billing.
Invoice Layout
The invoice should be grouped by Task using the Invoice Line Group table.
Within each group we have the Task Name then a line item per day that work was done for that task.
The we have any chargeable materials associated with the task.
When an invoice is generated time_entry entities and checklist items are associated with the invoice line item they are billed against.
Progressive billing of T&M
With progressive billing we collect all time entries and checklist that are marked as complete.
We need to give the user a chance to exclude some tasks and some materials before generating the invoice.
Final billing of T&M.
This should gather up all tasks and checklist items into the final invoice.
Again the user should be able to select tasks/items not to bill.
Perhaps its easier if we let them edit the invoice after it is generated - as we need that edit screen anyway.
We would need the ability to delete a invoiceline group if the last invoice line for the group was removed.
We need some way of indicating to a user that a Job has not been fully billed - may be a dollar icon on the Job card?

Under way.
We can now create a local and xero invoice as well as deleting both.
Currently working on requesting that xero send the invoice to the customer as an email.


Add support for showSystemUi preview annotation param

#169  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rbro112 and the rest of your teammates on  Graphite


Documentation URLs all changed

A recent update to the documentation setup changed the URLs. It seems all the old links mention the repo name twice, whereas now it's only just once:

Old: .../angular-oauth2-oidc/angular-oauth2-oidc/docs/...
New: .../angular-oauth2-oidc/docs/...

The new URLs seem subjectively better to me, but this does mean that all the links out there are now broken. For example a quick Google search turns up links like {1, 2, 3, ...}, and similar for Stack Overflow posts and so forth.
I don't know if there's a proper/easy fix (or workaround with "stuff has moved" page) for this, if not feel free to close the issue as wontfix.

Oh, yes, you're right. I didn't think about this when migrating to the new CLI-based monorepo-structure. How can we solve this?

Oh wee sorry no real clue to be honest, I don't know any of the systems and hosting involved.
Can you inject javascript in the docs pages? The "Old" situation should be decently easy to detect and make a client-side redirect for, I think?
If you'd go that route, I'd suggest pinging Google Search engine before hand, ask it to re-index the docs to update search results so they go to the right one immediately. (The redirect is then just for links on forums and bookmarks and such.)

On a side note, I noticed the README.md file in the root of the repo also contains links "Old" style (e.e.g the link on "documentation" near the bottom).

I would say, we have to wait until google has reindexed the docs.


termdebug: clean start

without "server" the new-ui command is pushed to the GDB history stack

Can you point to the "server new-ui" documentation?  I find it difficult to see what the "server" word does in there.

Short form: every command that is not executed via the mi protocol - which is the case for the ui creation - goes to the GDB history and otherwise adjusts gdb state.
docs: https://www.sourceware.org/gdb/onlinedocs/gdb/Command-History.html#index-server_002c-command-prefix

To issue a command to GDB without affecting certain aspects of the state which is seen by users, prefix it with server (see Server Prefix). This means that this command will not affect the command history, nor will it affect GDB’s notion of which command to repeat if RET is pressed on a line by itself.

Thanks, I'll add the "server" prefix. Not the other change to the CR character.


Unable to push views (segue or programatically)

Hi,
1st thing - loving this controller!
I am trying to push a segue when a collectionviewcell is pressed, however I am getting the below error:

Terminating app due to uncaught exception 'NSGenericException', reason: 'Could not find a navigation controller for segue 'ViewController'. Push segues can only be used when the source controller is managed by an instance of UINavigationController.'

I am assuming this is due to the nav actually being a subview? Do you know of anyways around this? I have tried embedding my viewcontroller in a uinavigationcontroller but to no avail.
Thanks!

In order to push anything from a tap on a cell you will have to pass the navigation controller of the parent view controller that contains the page menu and then push onto the parent view controller navigation controller from the table view controller or collection view controller. The next release will have one of the demos updated to show this behavior. If I don't release anything today you can check the develop branch as it will probably have a commit for this

Awesome, i'll watch out for it! :)

Awesomw controller!!!! I havent been able to push a segue either. I am trying with demo 3 following the sameway in your demo 5 in the last branch. Is it possible to find a tutorial or explanation on this subject?
Thanks!

are you trying to have multiple page menu's in one view like demo3? Demo 3 has some bugs right now and should probably not be used. I will probably have to redo that demo from scratch. Either way, currently in order to push you need to push from the navigation controller that contains the parent view controller of page menu, so the view controller containing page menu. Then when setting up the view controller array any view controller that needs to push needs to have a property for the parent navigation controller and have it be set when creating the view controller instances for the array. After that you can push onto that navigation controller from any of the view controllers that you have set up the parent navigation controller property in. Hope that helps

Thanks for your answer. I was trying to push segue with a didSelectRowAtIndexPath into a new viewcontroller in the storyboard. I haven't been able to setup.

if you set it up following my instructions and the demo you should be able to get it working as that is the only way to make it work as of right now

To help everyone on how to do it:
On the View Controller you want to push set a property:
var navController = UINavigationController()
Then, on the View Controller that has the PageMenu (thanks, again fahlout!), on viewDidLoad, when you instantiate the view controllers do as such:
var controller3 = mainStoryboard.instantiateViewControllerWithIdentifier("identifier") as controller3
controller3.navController = self.navigationController!
then add your controller to your controllers array as you would normally do.

but instead of calling nibs, how do i directly call a view controller from the MainStoryBoard by calling its class name? (as you can see at the pic), i outlet a tableview with cells on the view controller and won't show anything, just show the background of the uiview

My example is based on the storyboard demo... Look at the demos and you will see.

@wizmeister whats your email? so i can send you the project

@Bautistax you can instantiate your view controllers using storyboard like this:
first, you set storyboard identifier on your view controller (from the inspector)
then this is how you instantiate the view controller (although there is an example made by @fahlout, I write again):
let mainStoryboard: UIStoryboard = UIStoryboard(name: "Main",bundle: nil)
var controller : UIViewController = mainStoryboard.instantiateViewControllerWithIdentifier("vcIdentifier") as UIViewController

thank you so much @wizmeister
😃

So, I am pushing the views programmatically as stated above, but on iOS 8.x I have a problem:
https://dl.dropboxusercontent.com/u/17257636/Sharing/tableProb2.mov
on iOS 7 the static tableview shows well

Addressing your first issue as shown in your video: This issue has is not a PageMenu or static table view issue. Your navigation bar is set to translucent it seems like which causes the offset issue.
Second issue: Yes, viewWillAppear is currently not called on the actual controller in page menu after coming back from a pushed view controller. I haven't found a simple way to implement that yet unfortunately. So for now you will need to pass your data in a different way unfortunately until a nice clean way to call view will appear on the underlying controller is worked out.

Thank you for the useful information @fahlout !!!

I know it's not quite what you were looking for but I'm working on making the experience when pushing something better so that eventually viewWillAppear will be called automatically

I get it! Again, thank you for the wonderful controller and the continuous updates and  support!

@fahlout  @wizmeister
I have added  ‘var parentNavigationController : UINavigationController?’ to the collectionViewController step by step as you described. but when i click a cell in the collectionviewcontroller，the function " collectionView(collectionView: UICollectionView, didSelectItemAtIndexPath indexPath: NSIndexPath)" was not called.

In didSelectItemAtIndexPath
make sure your calling parentNavigation
Example :
parentNavigationController?.pushViewController(viewController, animated: true)

@Bautistax  thanks, there‘s some thing wrong in my collectionview layout.

easier way is to do the switch method to call every collection cell

hi, how can I from pushed view controller back to parent view controller?
self.navigationController?.popViewControllerAnimated(true) got warning :
popViewControllerAnimated: called on <UINavigationController 0x7febc8640bf0> while an existing transition or presentation is occurring; the navigation stack will not be updated.

This should be well documented about doing a push segue for all those beginners. Include it in the README that using a segue on the storyboard is not necessary.

Beginning in PageMenu 2.0.0, we have added an initializer that obfuscates away storyboard boilerplate. If there are any new problems, please feel free to open a new issue!


Evaluate removing double types

We had double data type because of the protocol. Maybe we don't need them anymore.

Covered on #641


Clean up type definitions in common

Requires #468

backend module cannot be built, because common module does not export everything that's necessary (check out failed gh action)


Try xpra / xpra-html as Guacamole alternative

We should try out https://github.com/Xpra-org/xpra/ & https://github.com/Xpra-org/xpra-html5 as Guacamole alternative.
The idea comes from https://medium.com/omi-uulm/an-initial-approach-to-deliver-an-x11-application-as-a-web-service-79cc0f70bbed. Thanks @vik378 for sharing the link.

So far, I tried the following:
wget -O "/usr/share/keyrings/xpra.asc" https://xpra.org/xpra.asc
cd /etc/apt/sources.list.d
wget https://raw.githubusercontent.com/Xpra-org/xpra/master/packaging/repos/bookworm/xpra.sources
apt update
apt install xpra

Start the server with:
XPRA_PASSWORD=mysecret xpra start --start=autostart --bind-tcp=<IP_ADDRESS>:10000,auth=env

The server runs without root permissions.
The password can be passed to the url via the password query parameter, but it's not removed from the URL and therefore is vulnerable to session hijacking (for example, another user can gain access if the token is exposed during screen share or when the URL is shared with another user).
Also, I want to play a bit with the "Share server" option.


added deviations to explicit enable BGP for Arista

Pull Request Functional Test Report for #2999 / 0ebf6caad584e02dad272d458f500b544554a2a3
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

MGT-1: Management HA solution test
79fc5661
Log

Cisco 8000E

MGT-1: Management HA solution test
4ec784bb
Log

Cisco XRd

MGT-1: Management HA solution test
8991cd05
Log

Juniper ncPTX

MGT-1: Management HA solution test
51fa3547
Log

Nokia SR Linux

MGT-1: Management HA solution test
7e6dde8a
Log

Openconfig Lemming

MGT-1: Management HA solution test
6799a0ed
Log

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

MGT-1: Management HA solution test

Cisco 8808

MGT-1: Management HA solution test

Juniper PTX10008

MGT-1: Management HA solution test

Nokia 7250 IXR-10e

MGT-1: Management HA solution test

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.859%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3550

💛  - Coveralls


Improve performance of "Display all"

When pressing display all, the queries seem to take alot of time. Can this be improved with better caching? My SQL database is not on the same machine as the website, however both of them should run with enough resources. If there is something configuration wise I can do to improve query times, that would be good, too.

Totally agree with you! This is the next bigger thing I want to finish and scratch off my todo list.
I have to close/merge this into #46, since its a duplicate of the issue. Thanks for reporting!

Oh sorry, I was actually looking through the issues, I guess my eyes passed that one. facepalm

No worries, I adjusted the title a bit so its more obvious :)


[BEAM-11860] Fix preview links for capability matrix detail views

index.html hack only works for links that start with /: https://github.com/apache/beam/blob/fb91f91a374f866dd299c88060ffae90818de420/website/append_index_html_to_internal_links.py#L45-L47
This PR updates the capability matrix detail links to be absolute links, so they trigger this regex.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Yeah it seems odd. My guess is it's just a simple way to detect a non-external link. I considered changing the logic to instead detect external links, something like https?:\/\/.* but I figured this was safer


Add Gateway data source

Towards #495
Description
to start writing a state sync loop
Changes:

implements GetStateUpdate only, rest of the functions will panic at runtime.

Types of changes

New feature (non-breaking change which adds functionality)

Testing
Requires testing: Yes
Did you write tests??: Yes

Can we please rename the DataSource interface to StarkNetData? Also, Go's convention on getters and setter. Can we please remove the Get for the function names.

I would not panic on the unimplemented functions

Let's return Error("not implemented")?

Let's return Error("not implemented")?

Sounds good!

@IronGauntlets , done.
added another quick fix as well.

Rebased


[Bug]: Navigation Menu component missing file NavigationMenuDemoItem.vue

Environment
Developement/Production OS: Windows 10 19043.1110
Node version: 16.0.0
Package manager<EMAIL_ADDRESS>Radix Vue version: 1.0.0
Shadcn Vue version: 1.0.0
Vue version: 3.0.0
Nuxt version: 3.0.0
Nuxt mode: universal
Nuxt target: server
CSS framework<EMAIL_ADDRESS>Client OS: Windows 10 19043.1110
Browser: Chrome 90.0.4430.212

Link to minimal reproduction
https://codesandbox.io/p/devbox/shadcn-vue-navigationmenudemo-mkd9rr?file=%2Fsrc%2FApp.vue%3A2%2C25-2%2C51
Steps to reproduce

Describe the bug
Missing file
Expected behavior
No response
Conext & Screenshots (if applicable)
No response

Same issue https://github.com/radix-vue/shadcn-vue/issues/232

+1

excuse me?


feat(auth): Added multi-tenancy support

Merging the tenant-mgt branch into main.
RELEASE NOTE: Added TenantManager class, which provides APIs for creating, updating, retrieving and deleting tenants in GCIP-enabled Firebase projects.
RELEASE NOTE: Added TenantAwareFirebaseAuth class, which provides APIs for tenant-scoped user management, token verification and IdP configuration management.
RELEASE NOTE: Added TenantNotFound and TenantIdMismatch error codes to the AuthErrorCode enum.
Resolves #149

@kevinthecheung requesting API reference review for following classes:

Tenant
TenantArgs
TenantManager
TenantAwareFirebaseAuth
TenantsPage
ListTenantsOptions
AuthErrorCode


Dns

Alternative: https://github.com/jderusse/docker-dns-gen

@romqin How does it compare to dnsdock ?

@romqin I'll have a look at it this week-end

dnsdock looks more configurable than dns-gen (--http, --ttl).
but dns-gen is more flexible in naming (it does not impose the format <anything>.<container-name>.<image-name>.<environment>.<domain>, you can use app.docker if you want)
and dns-gen does not reinvent the weel. It rely on dnsmasq to serve queries which's really stable and robust.
NB: Don't read the last part of the dns-gen's README (aka bonus thing) it's outdated and uggly...

Thanks for the explanation. If dnsdock turns out to be unstable, we'll know where to look.

but dns-gen is more flexible in naming

Not sure that bit is really true : you can alias containers with the DNSDOCK_ALIAS environment variable.


[Packaging Issue] Tests folder is packaged with pytest-archon

Seems like tests directory is packaged with library, you probably should limit published directories to pytest_archon, I discovered a similar issue with my library: https://gitlab.com/ThirVondukr/aioinject/-/blob/96d5c288b8cf6de07a12b1ab4aa2a22800997b54/pyproject.toml#L45

*Clarification: It's not a problem that it's packaged with the library but it's considered a source directory and is importable

I think I'll leave it like this. The tests/ folder is added by setuptools by default and my approach is: leave it at default if there is no strong indication that it needs to be changed. Most packages include tests in their source distributions.

The issue is it's importable with just import tests 👀

Then I need more details:

how do you download it
how do you install it
example script where you can import it as "tests", is your script in the same directory as the source?

Create a venv
Activate it
Install pytest-archon with pip install pytest_archon

(.venv)
doctor@main MINGW64 /c/dev/pytest-archon-test
$ python
Python 3.11.5 (tags/v3.11.5:cce6ba9, Aug 24 2023, 14:38:34) [MSC v.1936 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import pytest_archon
>>> import tests
>>> dir(tests)
['__doc__', '__file__', '__loader__', '__name__', '__package__', '__path__', '__spec__']
>>> from tests import test_collect
>>> print(test_collect)
<module 'tests.test_collect' from 'C:\\dev\\pytest-archon-test\\.venv\\Lib\\site-packages\\tests\\test_collect.py'>

confirmed, nice find!


Client does not work in Chrome

Dear strangerlabs-team,
first of all, thanks for all the effort with this project!
I've tried to use the client within chrome (with static delivery via express.static), but it does not work, because the imports does not work because they require a .js at the end.
Error:
GET https://localhost:3001/js/webauthn/client/Client net::ERR_ABORTED 404 (Not Found)
As far as I know, NodeJS does not care about the ".js" at the end of import, and with the .js Chrome would understand it, so I think that would be a nice addition to the project.
This commit would show the changes, if the idea will get accepted: https://github.com/Mik13/webauthn/commit/6cdbd756c2765b5552fd4e7a39e0f7f9c033f8bb
Best regards

Hi @Mik13! Thanks for creating these issues. Our entire team is a bit distracted at the moment, but we're listening and we'll circle back at the first opportunity. We appreciate your patience :)


Bootstrap animation bug v1.0.6

I'm submitting a bug report.
These seems to be an problem with the animation in the bootstrap plugin:
Example: cannot open a modal on http://shlomiassaf.github.io/angular2-modal#/bootstrap-demo
I get the error EXCEPTION: Error in ./BSModalContainer class BSModalContainer - inline template:3:10 ORIGINAL EXCEPTION: TypeError: Failed to execute 'animate' on 'Element': 'null' is not a valid value for easing

I'm not able to reproduce, please supply a plunker.

Strange,
I get the error also on the demo site. And I've check and it should not be a cache problem on my end.
In any case, here's a plunker. Clicking on open Modal will cause the error.
Sorry for not adding it from the start. I've also done some tests and the bug happens on Chrome 52 and Firefox 48b1, but not on Edge or IE ( :open_mouth: )

Confirmed this bug occurred in Chrome v 53.0.2767.4 dev (64-bit). In FF it work. I've tested with the demo page.
I've try to remove 'void => in' keyframe animation and it work. I guess it related to angular animation.
When I close modal, '* => out' did not work to.

This is probably a bug in the animation module in angular 2, we need to pin point it before we can open an issue there.

It seems that the problem solved itself. I no longer have it...
@shlomiassaf Do you plan to add an option to disable the animations?

Actually still on the demo site, but no longer on the plunker.
Maybe angular rc3 solved it?

@CaselIT maybe, i'll upgrade and see.
About animations, I don't know, maybe.
It should be easy, just play with the states..
I have some issues with the animations, there's a workaround to make the 'close' animations work since I remove the container and this doesn't trigger child animations.
If this is by design from angular I need to change my design to notify children to close and report back when done... this will be a burden on plugins... I want to wait a bit to see the next versions of animation

I think I've found the bug, and the reason why on some browser it is working and in some it is not.
The problem is caused by the comma here in 150ms, linear and here in 100ms, linear which causes angular to not recognise the easing.
The reason some browser are not affected is that they use the mock NoOpAnimationPlayer animation player defined here
The pull request #131 fixes the issue

@CaselIT
I don't think the , is the issue (if it is, it's a bug in angular animation's parser allowing it or not handling it)
The issue in the demo site is that I didn't include the web animation pollyfil which result in a non working animation on browsers that does not support web animation.
For example, this plunker
I have 2 identical animations one with 150ms, linear and one with 150ms linear.
Both work on Chrome in my mac.
Both doesn't work on FF in my mac.
Now adding
<script src="https://web-animations.github.io/web-animations-demos/components/web-animations-js/web-animations-next.min.js"></script>

To the index.html will add the polyfill.
Checking on FF again, both work.... so a comma is valid.

I'll fix it but it's a bug in the demo site, not in the module since a user must opt in the polyfil.

I checked the plunker. On win10, the one with the , do not work on ff or chrome, the other does.
Adding the polyfill does not change anything for me..

This may be an angular problem.
The regexp used by angular to parse the animation does not support the comma. Without comma it correctly parses, but not with a comma

I was able to reproduce the bug - win 10, chrome 52.0.2743.82 m (64-bit)
CaselIT solution worked for me.
Also reproducible on demo page.

Since I needed to install the fix via npm I've created an installable branch with it here https://github.com/CaselIT/angular2-modal/tree/forked-npm. It also contains the fix for https://github.com/shlomiassaf/angular2-modal/issues/132
It can be installed by using "angular2-modal": "github:caselit/angular2-modal#forked-npm" in the package.json

When are the changes going to merge in package?

Only @shlomiassaf  can answer..


[html] resolve links against the disk root folder

Given this HTML:
<script src='/Users/bpasero/Desktop/large/testing'></script>

Ctrl-click on it seems to open workspace path + /Users/bpasero/Desktop/large/testing and not /Users/bpasero/Desktop/large/testing.

Yeah good point, I am ok to close out of scope.

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


Map conflated components to an existing component

And some minor fixes.

Coverage remained the same at 29.989% when pulling 4be84d9c5db8d74226695ec68abf9a73ea2e92d8 on marco-c:fix_mapping into f2a52fd9e106c9fd806faf9d48f2d1630afa2b9a on mozilla:master.


Suggestion to update list of tools for Office and PDFs

Hi,
Just want to advise about some tools listed that no longer exist and some that can be added.
In Malicious File Analysis > Hosted Automated Analysis > PDFs:
No longer exist:
Wepawet
New one to add:
PDF Examiner (https://www.malwaretracker.com/pdf.php)
In Malicious File Analysis > Hosted Automated Analysis > Office :
No longer exist:
XecScan
New one to add:
Quicksand (http://quicksand.io/)
Cryptam (https://www.cryptam.com/)

Removed / Added. Thanks.


Fix issue with cursor position checking logic

Purpose
This PR fixes an issue with the logic for checking whether a given cursor position falls within a particular node. This bug led to an issue where looking up a symbol within a multi-line construct returned empty.
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Closing and reopening this since the checks seem to be frozen.

Closing and reopening this since the checks seem to be frozen.


Add docs for beta3

There is still a bit of diff with the beta2 docs (see this branch which overwrites the beta2 dir) but I think what's left is appropriately replacing some references to a local doxygen tag file.

This isn't convenient to review. I pushed the beta3 directory to master so that it can be inspected visually at http://docs.ros2.org/beta3. Merging this PR will update the page to make it the default.

Based on the branch that overwrites the beta2 folder, I think that (at least) the links to rmw from rcl are not working. I see cases where hyperlinks are being replaced with plain rmw_* text. I'll try to verify that by looking at the result in a browser.

Yeah, for instance compare the rmw_node_t in these two pages:

http://docs.ros2.org/beta3/api/rcl/node_8h.html#aeb0178170356c99b3991b09dde56c290
http://docs.ros2.org/beta2/api/rcl/node_8h.html#aeb0178170356c99b3991b09dde56c290

In the beta2 version there is a link to the rmw doxygen.
This is probably due to the order in which you ran doxygen or because you didn't uncomment the lines that cause the tag files to be generated.

It looks like references to cppreference.com are also broken, though that appears to be the case with beta2 as well. Compare the reference to std::string in these pages (beta1, beta2, beta3):

http://docs.ros2.org/beta1/api/rclcpp/classrclcpp_1_1node_1_1_node.html#af151071627b7f595c96f6d779d6a6240
http://docs.ros2.org/beta2/api/rclcpp/classrclcpp_1_1node_1_1Node.html#a9b416dc2e2220438a28a39485dfc355a
http://docs.ros2.org/beta3/api/rclcpp/classrclcpp_1_1node_1_1Node.html#a9b416dc2e2220438a28a39485dfc355a

The first one links std::string to cppreference.com, but the others do not. Again this is likely because the tag file for cppreference.com was not downloaded before running doxygen, or it was in the wrong place.

ok, thanks to your pointers I've fixed the cross referencing and add added the cppreference tag file too. this branch has the diff not including the cppreference changes and it's mostly just updating the tags to match my machine name.
I'll go forward with this since everything at http://docs.ros2.org/beta3/api/rclcpp/classrclcpp_1_1node_1_1Node.html is cross-referencing fine now

as a followup https://github.com/ros2/docs.ros2.org/commit/c9101ce2a2c2b0d25a08d07d6ca19772e1a54dd6 includes references to generated rcutils files


side option to define minute bounds / test suite overhaul

@gerrymanoim, Hi Gerry, I feel the time's right for a review of the side option PR before I plough on any further!
This draft PR includes the side implementation in full and a proposal for an overhaul of ExchangeCalendarTestBase.
Of the three commits:

Add side parameter to ExchangeCalendar offers the implementation in full.

With this implementation all methods that concern minutes (minute_to_session_label, previous_minute, minutes_for_session etc) will work off trading minutes as determined by the side passed to the constructor.

Update 24 hour calendars to true 24 hours.

Times changed (on calendars and corresponding answers csv files) so that open and close times are the same and offset defined as applicble. Valid side options for these calendars is limited to "left" or "right" in order that every trading minute belongs to one session only.

New ExchangeCalendarTestBaseProposal offers the proposed overhaul of ExchangeCalendarTestBase...

(you'll notice I've pushed these commits to a 'side' branch and set up this draft PR from there).
Rather than replace the existing ExchangeCalendarTestBase, at this stage I've simply added a new ExchangeCalendarTestBaseProposal to the end of test_exchange_calendar.py and implemented it only to the test modules of the following selected calendars:

'XLON' (no breaks)
'XHKG' (breaks)
'24/7' (24h continuous)
'24/5' (24h but not continuous)
'CMES' (24h with sessions crossing UTC midnight)

ExchangeCalendarTestBaseProposal includes only the following methods for now (enough I hope to give you an appreciation of the proposed implementation):

test_all_minutes - new test to test trading mintues at sessions' bounds.
test_minute_to_session_label - replacement for existing test.
test_minute_index_to_session_labels - replacement for existing test.
test_is_open_on_minute - replacement for existing test.
test_invalid_input - new test to test that constructor raises expected errors on invalid inputs.

Main features of the proposed approach:

Creates an Answers class that, from interrogation of the corresponding csv file,  provides inputs and expected return values for methods under test. Importantly, it is not intended that this class does more than minimial evaluations. It should not in any way 'repeat the code' of the methods being tested. It does the same kind of work currently done ad-hoc within test methods.

Answers class can take a side parameter that provides for its properties to reflect a specific side option.

ExchangeCalendarTestBaseProposal provides a parameterised pytest fixture all_calendars_and_answers. Any test that inherits this fixture will be exectuted with a calendar / answers combo for each side option.
Moves fully to native pytest framework.

If you were to be happy with the general approach then my intenion would be to:

Tidy and speed up what's there
Extend ExchangeCalendarTestBaseProposal to cover all tests of ExchangeCalendarTestBase and eventually replace it.
Review/revise all calendar-specific test modules to implement new test base.

I look forward to hearing your thoughts!
NB with the exception of the 24 hour calendars the default side is "both" which fully replicates the existing behaviour. Accordingly all tests for non-24hour calendars continue to pass. I've skipped the standard ExchangeCalendar tests for the 24h calendars - some of these tests will fail given that these calendars are, intentionally, not acting as if side were "both" (i.e. the behaviour that the tests were designed for).

TODO
Tests need speeding up.

[ ] Make sure existing caches working as expected.
[ ] Make sure ExchangeCalendarTestBaseProposal fixtures being created once-per-class as expected and required (rather than being created anew for every test).
[ ] Investigate swapping Answer's minute generators (trading_minutes, non_trading_minutes, break_minutes) for pre-defined lists created once and cached.
[ ] Consider further limiting number of sessions covered when creating minute generators.
[ ] Consider stripped down versions of the minute generators to offer only the minutes without the ancillary objects that offer related sessions.
[ ] The ExchangeCalendarTestBaseProposal tests for '24/5' calendar seem to be running disproportionately quick relative to those for 'XLON' (even after accounting for fewer sessions on the 24/5 answers). Investigate.
[ ] Alongside Answers.get_next_sessions offer a simpler, faster, Answers.get_next_session that can be used when require only next session.

Then:

[ ] Move forwards with incorporating all existing tests of ExchangeCalendarTestBase to ExchangeCalendarTestBaseProposal.
[ ] Replace ExchangeCalendarTestBase with ExchangeCalendarTestBaseProposal.
[ ] Review/Revise all calendar-specific test modules to implement new test base.

Hey @maread99 - thanks for putting this up and documenting this really well.
I think my high level comments would be:

We should definitely be using an enum rather than strings as input for side. This should eliminate some of the validation code we have in a few places.
I'm possibly a bit worried about doing full array copies in one_minute_* functions, even if that only happens when we break the cache.
There's some functions like *_minute_nanos where I'm unclear why they take a side arg, vs automatically using the side on the class.
Probably need some text in the readme about this (though revamping all the docs is on my todo list)
Happy to do your followup todos over time.
I wonder if there's a better name than side?
I think the new test calendar class is great. Definitely some messy logic inside the test class itself, but it cleans up the user facing side a lot.

@gerrymanoim, thanks for looking through this and for your comments.
The *_minute_nanos currently take a ‘side’ arg as I anticipate adding a side option to some methods to allow for overriding the default ‘side’ for that call only. Also, there is a method (minute_index_to_session_labels IIRC) which requires being able to treat side as ‘both’ for its own purposes.
I’m not able to reply fully at the moment although will do towards the end of the month when I expect to move this forward and incorporate your suggestions. Cheers.

@gerrymanoim, thanks again for your comments from which I'm assuming you're happy, subject to the following, for me to progress with the proposed side implementation and the supporting testing overhaul(?).

We should definitely be using an enum rather than strings as input for side. This should eliminate some of the validation code we have in a few places.

:+1: Will do.

I'm possibly a bit worried about doing full array copies in one_minute_* functions, even if that only happens when we break the cache.

I'm assuming the concern here is memory? The arrays received are always limited in size (to the number of the calendar's days) and the copy is then worked on directly to create the return, i.e. there's no intermediary object taking up memory.

There's some functions like *_minute_nanos where I'm unclear why they take a side arg, vs automatically using the side on the class.

I anticipate adding a side option to some methods to allow for overriding the default side for that call only. minute_index_to_session_labels already includes this option which facilitates the evalution of _late_opens and _early_closes by the constructor (which calls minute_index_to_session_labels with side as 'both' in order to map open / close times to session labels).

Probably need some text in the readme about this (though revamping all the docs is on my todo list).

:+1: I'll update the What times are considered open and closed? section of FAQs.

Happy to do your followup todos over time.

I hope to get through all of this over the next couple of weeks. To aid reviews I'll work on the side branch with sequential commits. To avoid conflicts with recent and any future merged PRs, I might request an intermediary merge before moving the calendar test modules to the new test base.

I wonder if there's a better name than side?

:smile:. I did give it some thought before settling on 'side'. I originally had it as the arguably worse 'closed'. I guess that, with usage, parameter names take on the significance of the functionality they provide. Of course, more than open to suggestions for an alternative name that might better indicate what the option does.

I think the new test calendar class is great. Definitely some messy logic inside the test class itself, but it cleans up the user facing side a lot.

My intenion is to keep all the critical evaluations (test inputs / expected outputs) within Answers rather than scattered around the TestBase.

@gerrymanoim, thanks again for your comments from which I'm assuming you're happy, subject to the following, for me to progress with the proposed side implementation and the supporting testing overhaul(?).

Yep - I think there's a lot here, but overall everything is reasonable.

We should definitely be using an enum rather than strings as input for side. This should eliminate some of the validation code we have in a few places.

~👍 Will do.~(?) I'm probably missing something, although having looked at what this would involve any net benfit isn't immediately apparent to me(?). Given that the 24 hour calendars can only take a subset of possible side values, I don't think there would be any reduction in validation code. However, wouldn't using enums make usage more complicated by requiring the user to first import the enum rather than simply passing through a string?

That's a fair point, I think my instinct is to just use an enum where string constants are needed and do isinstance checks for those constants. If we needed to use side outside the core class or were more strictly type checking things, I think I'd be more insistent on using enums.

I'm possibly a bit worried about doing full array copies in one_minute_* functions, even if that only happens when we break the cache.

I'm assuming the concern here is memory? The arrays received are always limited in size (to the number of the calendar's days) and the copy is then worked on directly to create the return, i.e. there's no intermediary object taking up memory.

Mostly performance actually, but I agree with your point that these are generally of a limited size so it should be fine.

There's some functions like *_minute_nanos where I'm unclear why they take a side arg, vs automatically using the side on the class.

I anticipate adding a side option to some methods to allow for overriding the default side for that call only. minute_index_to_session_labels already includes this option which facilitates the evalution of _late_opens and _early_closes by the constructor (which calls minute_index_to_session_labels with side as 'both' in order to map open / close times to session labels).

What would be the benefit for these other methods?

Probably need some text in the readme about this (though revamping all the docs is on my todo list).

👍 I'll update the What times are considered open and closed? section of FAQs.

Happy to do your followup todos over time.

I hope to get through all of this over the next couple of weeks. To aid reviews I'll work on the side branch with sequential commits. To avoid conflicts with recent and any future merged PRs, I might request an intermediary merge before moving the calendar test modules to the new test base.

Yep - that's fine - don't want you to have to keep having issues with other PRs coming in.

I wonder if there's a better name than side?

😄. I did give it some thought before settling on 'side'. I originally had it as the arguably worse 'closed'. I guess that, with usage, parameter names take on the significance of the functionality they provide. Of course, more than open to suggestions for an alternative name that might better indicate what the option does.

Yep I also can't think of anything particularly better here.

I think the new test calendar class is great. Definitely some messy logic inside the test class itself, but it cleans up the user facing side a lot.

My intenion is to keep all the critical evaluations (test inputs / expected outputs) within Answers rather than scattered around the TestBase.

@gerrymanoim, thanks for your further comments.

There's some functions like *_minute_nanos where I'm unclear why they take a side arg, vs automatically using the side on the class.

I anticipate adding a side option to some methods to allow for overriding the default side for that call only. minute_index_to_session_labels already includes this option which facilitates the evalution of _late_opens and _early_closes by the constructor (which calls minute_index_to_session_labels with side as 'both' in order to map open / close times to session labels).

What would be the benefit for these other methods?

My own usage of exchange calendars led me to accommodate this functionality - very occassionally I found a need to treat 'side' differently from the default for a specific purpose (similar to how minute_index_to_session_labels does). However, I've yet to convince myself of the need for this. I also don't like the *_minute_nanos being defined as functions rather than properties. After this PR is resolved (together with subsquent PRs moving calendars to the new test base) I have a few new methods to propose, all based on the concept of trading minutes. I would like to leave the *_minute_nanos methods as they are until then. I'll then reassess whether their accommodating a 'side' argument can be justified (added to the todo above). If it can't, I'll make them properties and revise minute_index_to_session_labels. Does this sound reasonable?

Yep - that's fine - don't want you to have to keep having issues with other PRs coming in.

:thumbsup: I anticipate having the new test base proposal completed this week, at which point this will be good for reviewing / merging. I'll offer a summary of changes made and what will be left to do over subsequent PRs.

Yep - sounds good to me.

@gerrymanoim, I think I'm there, with this initial PR ready to merge pending your review.
It's ended up as quite a bit more than implementing side. As a result of working through the test base I ended up undertaking a general review of both ExchangeCalendar and the tests (excluding calendar-defintion methods). All changes are hopefully documented to the corresponding commit messages. In summary:

Added tests for ExchangeCalendar methods/properties that were not previously tested for (including minutes_count_for_sessions_in_range, is_session, minutes_window, late_opens, early_closes...)
Added (where missing) parsing, annotations and standardised documentation for all ExchangeCalendar methods and properties (except those primarily concerned with calendar definition/construction).
Added out-of-bounds handling to some ExchangeCalendar methods (including sessions_window, minutes_window)
Reordered methods of ExchangeCalendar (to labelled sections) - new test base class follows the same order.
Proposed renaming some methods and parameters for reasons for consistency. The whys and whats are covered between #85 (method names) and #61 (param names).

Testing
Continuing from my earlier notes...
Generally tests have been made more comprehensive as a result of:

including out-of-bounds inputs.
including edge cases around start/end of breaks.
considering 'gaps' around sessions on a per-session basis as opposed to the previous binary treatment at a class level. For example, the Monday/Friday sessions of the 24hr calendars '24/5' and 'CMES' are now treated as having gaps before/after rather than being assumed as gapless. Accordingly these calendars are subjected to tests that they weren't previously.
including non-session date inputs to methods that evaluate or interrogate a range of sessions where the range bounds can be defined by a session or non-session date (for example, sessions_in_range, session_distance). Previously such methods were tested only with sessions as inputs.
definition of Answers.session_blocks where a block is a contiguous run of sessions that represents a unique circumstance, for example "next_close_later", "next_break_end_earlier", "with_break_to_without_break", "without_gap_to_with_gap", "follows_non_session" etc. The existing test base seems a bit feast or famine - either blanket testing or limiting testing to a single unusual session block. The new base aims for somewhere in between, subjecting all methods a wide variety of circumstances without testing beyond what might be considered reasonably necessary. The focus is very much on edge cases / just within edge cases.

Speed
I anticipate that the new test suite will run somewhat slower than the existing, possibly around 1.7x, maybe less. This is partly due to the more comprehensive testing and partly due to methods that are dependent on the evaluation of minutes now being tested against four versions of each calendar (one for each side).
Other points of note

The new test class does away with the notable majority of the class attributes that contributors were requried to define (for example HAVE_EARLY_CLOSES, TEST_START_END_*, GAP_BETWEEN_SESSIONS etc). The need for these has been obviated by evaluating properties directy from the answers csv. Where these attributes are still required they are defined as fixtures. Only two are mandatory (calendar_cls, max_session_hours) and only two others may be requried if the calendar strays from the default (start_bound and end_bound).

an internal _parse argument provides for internal calls and testing to skip parsing.

test_exchange_calendar.py will clean up somewhat with:

removing the existing ExchangeCalendarTestBase when all the calendar test modules have been moved over to the new base (should also allow for losing unittest and some other imports).
cleaner caching (@functools.cached_property) when min supported python version moves to 3.8.

Moving On
I've laid out in #86 the path to moving calendars over to the new test base. I envisage this ideally being followed by some method renaming (#85 - what do you reckon?), a revised README and culminating with cutting 3.4(?).

I've added one small commit to cover something that became apparent to me when working on documentation.
@gerrymanoim, you might want to check out the proposed doc - it ties together the side option covered by this PR and the proposed renaming (#85). It's on the 'readme' branch (I've overhauled the README and added a couple of .ipynb tutorials).

@gerrymanoim, although I've added another small commit this is no longer a WIP (at least as far as this PR is concerned) and is good to review / merge as and when you're in a position to look at it...

Awesome! Will take a look in the next few days.

Great! Be sure to check out the proposed doc on the 'readme' branch - README overhaul and 4 ipynb tutorials. It's intended to be published alongside release 3.4 (assumes this PR is merged and that the renaming covered in #85 happens).

Some minor questions/comments, but LGTM. Feel free to merge when you're ready.
The new notebooks are great! As an FYI github will render the notebooks directly, but I don't have view on linking directly vs nbviewer.

Great. I'm going to add a commit or two to cover the issues / points you've raised and then I'll merge and move forwards with moving the test modules over to the new suite.

The new notebooks are great! As an FYI github will render the notebooks directly, but I don't have view on linking directly vs nbviewer.

Glad you like them. I just prefer the nbviewer rendering. The only issue is that (I believe) it'll be necessary to update the nbviewer links on the README every time the notebooks are updated (I might yet end up linking to the GitHub pages).

The only issue is that (I believe) it'll be necessary to update the nbviewer links on the README every time the notebooks are updated (I might yet end up linking to the GitHub pages).

We can always transition to sphinx in the future


Error from server: Invalid JSON Patch

After running:
$ kubectl patch offlinevirtualmachine testvm --type merge -p '{"spec":{"running":true}}'
I get the $SUBJECT error.
C:\minikube> kubectl get --all-namespaces pods
NAMESPACE     NAME                                    READY     STATUS    RESTARTS   AGE
kube-system   kube-addon-manager-minikube             1/1       Running   0          24m
kube-system   kube-dns-54cccfbdf8-grdkr               3/3       Running   0          24m
kube-system   kubernetes-dashboard-77d8b98585-66pxb   1/1       Running   0          24m
kube-system   storage-provisioner                     1/1       Running   0          24m
kube-system   virt-controller-5c74754ddd-5p4cx        1/1       Running   0          15m
kube-system   virt-controller-5c74754ddd-tbhkf        0/1       Running   0          15m
kube-system   virt-handler-c887w                      1/1       Running   0          15m

Shouldn't also the virt-controller-5c74754ddd-tbhkf  running? I am following this guide

kubectl get ovm testvm
C:\minikube>kubectl get ovm testvm
NAME      AGE
testvm    1d

Nothing fancy here :/

Argh - kubectl get ovm testvm -o yaml I mean to say - to get all the details.

You are testing on Windows!? Crazy :)

Shit! I know why it's failing... or at least this my lucky guess:
virtual-box is unable of running KVM inside of it. It's not supported. Minikube in windows is using Virtual-box, so ... I will try this on my Linux box also to make sure if it's a bug or not, and then update the status here.

Cool.
Are you sure it is not supported by today? KVM inside VB? ...

Yes. Check this: https://www.virtualbox.org/ticket/4032
9 years ...

Oh - But never the less - We noticed that currently all VMs are run in emualtion mode. So this should not be the issue.

In Linux it works perfectly OK. So, the issue is triggered only in Windows environment.

Can you provide the output of kubectl get ovm testvm -o yaml ?

ping?

Ah I forgot about this. Let me resurrect my Windows machine. I will report soon-ish. Thank for the reminder ;)

apiVersion: kubevirt.io/v1alpha1
kind: OfflineVirtualMachine
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"kubevirt.io/v1alpha1","kind":"OfflineVirtualMachine","metadata":{"annotations":{},"name":"testvm","namespace":"default"},"spec":{"running":false,"selector":{"matchLabels":{"guest":"testvm"}},"template":{"metadata":{"labels":{"guest":"testvm","kubevirt.io/size":"small"}},"spec":{"domain":{"devices":{"disks":[{"disk":{"bus":"virtio"},"name":"registrydisk","volumeName":"registryvolume"},{"disk":{"bus":"virtio"},"name":"cloudinitdisk","volumeName":"cloudinitvolume"}]}},"volumes":[{"name":"registryvolume","registryDisk":{"image":"kubevirt/cirros-registry-disk-demo"}},{"cloudInitNoCloud":{"userDataBase64":"SGkuXG4="},"name":"cloudinitvolume"}]}}}}
  clusterName: ""
  creationTimestamp: 2018-03-11T01:18:34Z
  generation: 0
  name: testvm
  namespace: default
  resourceVersion: "3371"
  selfLink: /apis/kubevirt.io/v1alpha1/namespaces/default/offlinevirtualmachines/testvm
  uid: 1e7a9b22-24ca-11e8-be68-080027a81666
spec:
  running: false
  selector:
    matchLabels:
      guest: testvm
  template:
    metadata:
      labels:
        guest: testvm
        kubevirt.io/size: small
    spec:
      domain:
        devices:
          disks:
          - disk:
              bus: virtio
            name: registrydisk
            volumeName: registryvolume
          - disk:
              bus: virtio
            name: cloudinitdisk
            volumeName: cloudinitvolume
      volumes:
      - name: registryvolume
        registryDisk:
          image: kubevirt/cirros-registry-disk-demo
      - cloudInitNoCloud:
          userDataBase64: SGkuXG4=
        name: cloudinitvolume

Here it is.

Closing this issue as the entities were renamed.

Please reopen or file new if you still see this. Please provide:
Exact kubectl/oc cmdline
Exact VM/VMI definitnion.

Hey, I stumbled on this issue today. Seems a kubernetes issue:
https://github.com/kubernetes/kubernetes/issues/63247
(also relevant: https://github.com/kubernetes/kubernetes/issues/56980)
I workarounded this issue using a YAML patch. No luck with JSON patch
platform: kubevirt 0.8.0 on kubernetes 1.11

@fromanirh there shouldn't be any issues parsing valid JSON, as it is a subset of YAML.
You likely had an error in your JSON which was not present in your YAML version of the patch.
The linked issues are mainly about UX of the jsonpatch feature. (it's confusing)
The parsing works correctly.

I'm sharing this having gone through the same battle yesterday with the kubectl run command. If you're running this on Windows using Powershell you'll need to create a system variable and assign the JSON (using the ConvertTo-Json routine) first. Then use that variable in your kubectl commands.
From the OP's code:
$ kubectl patch offlinevirtualmachine testvm --type merge -p '{"spec":{"running":true}}'
Becomes:
$myjson = '{"spec":{"running":true}}'
$ kubectl patch offlinevirtualmachine testvm --type merge -p $myjson

Hope that helps! :)


[pipeline] feat: decompose intersect node to pipeline

IntersectNode is decomposed to IntersectBuildSinkOperator, IntersectProbeSinkOperator, and IntersectOutputSourceOperator.

IntersectBuildSinkOperator builds a hast set from the IntersectNode's first child.
Each IntersectProbeSinkOperator probes the hash set built by IntersectBuildSinkOperator. The hash set records the ordinal of IntersectProbeSinkOperator per key if the key is hit.
IntersectOutputSourceOperator traverses the hast set and picks up entries hit by all IntersectProbeSinkOperators after probe phase is finished.

IntersectBuildSinkOperator, IntersectProbeSinkOperator, and IntersectOutputSourceOperator belong to different pipelines. There is dependency between them:

The first IntersectProbeSinkOperator depends on IntersectBuildSinkOperator.
The rest IntersectProbeSinkOperator depends on the prev IntersectProbeSinkOperator.
IntersectOutputSourceOperator depends on the last IntersectProbeSinkOperator.

The execution sequence is as follows:  IntersectBuildSinkOperator -> IntersectProbeSinkOperator 0 -> IntersectProbeSinkOperator 1 -> ... -> IntersectProbeSinkOperator N -> IntersectOutputSourceOperator.
The rows are shuffled to degree of parallelism (DOP) partitions by local shuffle exchange. For each partition, there are a IntersectBuildSinkOperator driver, a IntersectProbeSinkOperator driver for each child, and a IntersectOutputSourceOperator.
In addition, make multiple ExceptProbeSinkOperators label the key in the hash set sequentially instead of concurrently.
The reason is that ExceptHashSet<HashSet>::erase_duplicate_row() use some object share member variables, such as _slice_sizes, _max_one_row_size, and _buffer.

run starrocks_clang-format

run starrocks_fe_unittest


Add ability to configure json-file output location

Cookbook version
current
Chef-client version
any
Scenario:
Using the audit cookbook with file base output, we cannot choose the location and name of the file

Thank you for the feedback, right now filenames are auto-generated, as we see here: https://github.com/chef-cookbooks/audit/blob/master/files/default/handler/audit_report.rb#L260-L262
It would be nice to have the same feature-set as in test-kitchen:
verifier:
  name: inspec
  format: junit
  output: path/to/results/%{platform}_%{suite}_inspec.xml

see https://github.com/chef/kitchen-inspec#usage

Thank you Eric for the feedback. Version 7.3.0 has an attribute that you can use the specify the location of the file based reporter.


why cesium can not display globe?

There was a problem loading the terrain in cesium. The cesium globe displays normally after removing the terrain.
In cesium1.96, chrome displays the following error:
Cesium.js:85 An error occurred in "Py": Failed to obtain terrain tile X: 0 Y: 0 Level: 0. Error message: "RangeError: Invalid typed array length:<PHONE_NUMBER>"
Cesium.js:85 An error occurred in "Py": Failed to obtain terrain tile X: 1 Y: 0 Level: 0. Error message: "RangeError: Invalid typed array length:<PHONE_NUMBER>"
cesium code like this:
var terrainProvider1=new Cesium.CesiumTerrainProvider({
url:"http://localhost:9000/"
});
const viewer = new Cesium.Viewer("cesiumContainer", {
baseLayerPicker: false,
imageryProvider: imageryProvider,
terrainProvider:terrainProvider1
});
viewer.scene.globe.enableLighting=true;
However, in the latest cesium, chrome does not output any errors and just does not display the globe.
How can I solve this problem? @BWibo @Son-HNguyen @TatjanaKutzner @thomashkolbe

Hey there, this is the repo of the terrain builder docker image. I cannot provide support for general cesium questions.
Closing. Feel free to re-open if you have a question specific to this project.