Docker Device Agent failed to pull snapshot after restart

Current Behavior
After a nightly restart of the Device Agent running on Docker, the process of getting the snapshot timed out.

Expected Behavior
The Device agent should keep retrying the snapshot download if the prior attempt timed out.
Steps To Reproduce
The network this device is running on is believed to have restarted at the same time as the device agent.
Environment

FlowForge version: FF Cloud 1.10.2
Node.js version: 16.20.2
npm version:
Platform/OS:
Browser:

I've done some testing on this issue. I've used a slow network simulator (https://www.sitespeed.io/documentation/throttle/)to test what happens if the device agent can't get the snapshot within the 10000ms limit.
It seems that if it fails to get the snapshot in time the following error is shown:
[AGENT] 8/24/2023 8:24:59 PM [warn] Problem getting snapshot: TimeoutError: Timeout awaiting 'request' for 10000ms
It seems that the device agent then just hangs.
In my testing I created a 3MB snapshot (it contains 3 inject nodes which each have a 1MB string in them) and slowed my network down to 50kb up, 50kb down.
Video shows the test - https://d.pr/v/vGRjJR

OK, but 50kps is very slow by modern network standards.
What timeout should be use? We could double the current 10 second would that be enough?

Thanks @hardillb, this is a great fix for now. As discussed, I think there is something off with the retry logic for this particular timeout. It seems that once the snapshot download fails once the system doesn't retry, where as various other scenarios I tested seem to periodically repeat the failed action.

Snapshots are 280KB (well slighting more as that number is for the flow not the full snapshot), ~20 device agents running on the same machine so ~5.6MB of data to pull.
Anything under a ~1.5Mb connection would result in a timeout.

So they are effectively DoSing themselves by mass restarting them all at the same time.
The "right" solution may be that they stagger the restart....

I think the fact they are restarting them all at the same time is part of the issue, but something we ought to be able to handle.
The proper fix on our side here is to add some retry logic here so if it does timeout (which could happen for all sorts of reasons) then it tries again without blocking progress.

I think that's the best tactic, agreed. I also would like to understand if it was the intention that the snapshot download would retry. From my limited testing it seems that the agent does retry if the network is totally down but doesn't retry if the network was up but too slow, that seems like either a bug or oversight.

I may have worked out where to insert the fix to get it to retry. If rob can test I can give you a 3 line change to a single file.

I've suggest a staggering of the restarts. Also suggest the user does the restarts in series. Finally I've asked if they can use a tool to measure the internet speed on the device in question at the restart time.
I can do testing @hardillb, I've still got the setup I used to recreate the issue.

A customer pushed an update (new target snapshot) yesterday and one device in the fleet didn’t take it. DA Version 1.10.1.


PUSH_ACK where PULL_ACK expected

I might be wrong here but to me it seems the TTN gateway server is responding wrong to my PULL_DATA requests sent by my Kerlink, causing:
INFO: [down] the last 3 PULL_DATA were not ACKed, exiting application
In the screenshots you can see the PULL_DATA being sent and answered with a PUSH_ACK (0x01) where 0x04 is expected.

I see you are now answering 0x02 with 0x03, according to the Semtech documentation this is PULL_RESP, not PULL_ACK. Imho this is invalid too. The PULL_REQ (0x02) should (imho) be answered with a PULL_ACK (0x04).

Hmm wrong iotas. Thanks for prompt response, will fix.
On Mon, Nov 30, 2015 at 12:41 PM -0800, "Arjan van der Oest" <notifications<EMAIL_ADDRESS>wrote:
I see you are now answering 0x02 with 0x03, according to the Semtech documentation this is PULL_RESP, not PULL_ACK. Imho this is invalid too. The PULL_REQ (0x02) should (imho) be answered with a PULL_ACK (0x04).

Reply to this email directly or view it on GitHubhttps://github.com/TheThingsNetwork/croft/issues/11#issuecomment-160755489.

OK fixed now, thanks


UserWarning: resource_tracker: There appear to be 2 leaked semaphore objects to clean up at shutdown 3

Describe the bug
The instance is killed with the reason OOMKilled.
Seems there is a memory leakage.
Steps To Reproduce
When run dbt build with multiple threads enabled, in a memory constrained environment (i.e. k8s, with limited memory)
The instance will be killed with the reason OOMKilled
Expected behavior
dbt build should not require too much memory
Screenshots and log output

System information
The output of dbt --version:

The operating system you're using:
The output of python --version:

Additional context
Add any other context about the problem here.

@xg1990 is this still happening?

@bilalaslamseattle Thanks for the follow up. it works more stable recently. I'll close this ticket and let you know if it happens again

the problem happens frequently again recently
environment:

python=3.9
dbt-core =1.4.1
dbt-databricks=1.4.1


dont update doc images if not necessary

not sure how this would be possible but it would be good to check to see:

is there a component image? If so,
has the component changed since the last image was rendered?

this is because i keep accidentally committing re-rendered images which aren't necessary (no visual diff). I guess this is mostly a user error, because it could be avoided if i (1. wasn't lazy and did git add ., 2. used a visual git application like git Tower which i have installed), but it would be catch if not too hard to do.
🐎

if we generate images using docker then the binaries are unlikely to change

this would be done using https://github.com/skalfyfan/dockerized-puppeteer as also mentioned in #65

another option may be https://github.com/jxnblk/repng

We don't generate images anymore \o/


Global variables

A concept to set variables globally that result in triggers or other flows similar to a state system.

New actions for getting and setting global var has been added to the core system functions


Inverted srgb flag in parser/qoi.c

According to the spec, 0 means srgb and 1 means linear. But in the code, it seems to be doing the opposite:
    p[13] = 0;  // srgb
    // ...
    case 's': p[13] = 1; break;

You're right, thanks! (Obviously I've never actually put this flag to use
in a program.)


Ops: healtcheck and actuator profile

It seems like docker health-check not working without  actuator profile

Fixed


Verify Mailhog

Mailhog should work out of the box and the base box should be configured to send mail by default via SMTP over port 1025 without any user credentials.
Applications should be able to specify STMP mail settings on port 1025 and see mail show up in mailhog's UI.

Verified in pending https://github.com/svpernova09/EnterpriseSettler/releases


PHP 8.1 throws these errors on backoffice config page

Expected behavior
No errors
Actual behavior
Red pop-up shown with these errors:
Unknown error on line 162 in file .../modules/mollie/vendor/vlucas/phpdotenv/src/Environment/AbstractVariables.php
[8192] Return type of Dotenv\Environment\AbstractVariables::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
Unknown error on line 170 in file .../modules/mollie/vendor/vlucas/phpdotenv/src/Environment/AbstractVariables.php
[8192] Return type of Dotenv\Environment\AbstractVariables::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
Unknown error on line 178 in file .../modules/mollie/vendor/vlucas/phpdotenv/src/Environment/AbstractVariables.php
[8192] Return type of Dotenv\Environment\AbstractVariables::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
Unknown error on line 186 in file .../modules/mollie/vendor/vlucas/phpdotenv/src/Environment/AbstractVariables.php
[8192] Return type of Dotenv\Environment\AbstractVariables::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
Unknown error on line 114 in file .../vendor/smarty/smarty/libs/sysplugins/smarty_internal_compile_private_modifier.php
[16384] Using php-function "intval" as a modifier is deprecated and will be removed in a future release. Use Smarty::registerPlugin to explicitly register a custom modifier.
Errors seem related to this issue: https://github.com/vlucas/phpdotenv/issues/504, which are solved in a newer version.
Steps to reproduce the behavior
Install in 8.0 store with PHP 8.1 & click config
Environment

PrestaShop version: 8.0.1
Mollie module version: 5.3.1
PHP version: 8.1

Hey there,
We will be glad to help you with this! Our team will check your case, and get back to you as soon as possible with an update.
--
Best Regards,
Invertus Support team.

@justelis22 is the plugin compatable with prestashop 8.0.1 with PHP 8 ?

Hi @tajriba,
Yes, the Mollie module is compatible with PS8 and PHP 8. The compatibility was implemented in the 5.3.0 release - https://github.com/mollie/PrestaShop1.7/releases/tag/5.3.0 you can check the changelog there.
It seems like other modules are using older libraries, and when Mollie tries to use the newer ones a conflict appears. In this case, we need to check the specific shop and change some settings to see what is exactly causing the issue.
--
Best Regards,
Invertus Support team.

I'm getting the same errors with a fresh install of Prestashop 8.0.1, PHP 8.1 and Mollie V5.3.1. This is probably related to the debug mode in Prestashop. If it's turned on you will get the errors in the back office (and in the dev.log). If Prestashop debug mode is disabled there are no errors. Also no errors in the Prestashop dev.log

Hi there,
Yes, these messages are only notices, so if you turn off the debug mode everything should work fine, and no errors should be visible.
--
Best Regards,
Invertus Support team.

Hi there @Ken-vdE,
We have not received any updates from your side, so we are going to close the ticket.
If you decide to come back to this case, please do let us know, and we will continue the investigation!
--
Best Regards,
Invertus Support team.

Also getting the notices. Composer file for phpdotenv:
"require": {
    "php": "^5.4 || ^7.0"

PHP 8 is not supported, so you have to update the phpdotenv libary.
I'm aware that it is a notice, but if the mollie plugin supports PHP 8, notices should not appear!

Hi @sharkooon,
We have another issue open with the same topic - https://github.com/mollie/PrestaShop1.7/issues/670
So let's continue the communication there.
--
Best Regards,
Invertus Support team.


base32.decode returns exactly same bytes from two different strings.

Hello, I am currently using your ULID as the primary key (PK) for the database.
The reason I am reaching out is because while retrieving the database’s PK string using ULID.from_str, I encountered a PK collision. While debugging this issue, I discovered that base32.decode is converting different strings into the same binary value.
I suspect this may be due to a malfunction in the decode_randomness function.
Here is my test code.
from ulid import base32

def test_ulid_decode() -> None:
    first_sample = base32.decode("01J5PP33KAV586VA6296VXF0HU")
    second_sample = base32.decode("01J5PP33KAV586VA6296VXF0QZ")
    assert first_sample == second_sample # this must be failed but it actually passed.

I can't reproduce  this test case.
The ULID Spec in https://github.com/ulid/spec?tab=readme-ov-file#encoding says:

Crockford's Base32 is used as shown. This alphabet excludes the letters I, L, O, and U to avoid confusion and abuse.
0123456789ABCDEFGHJKMNPQRSTVWXYZ

@E5presso the first string, "01J5PP33KAV586VA6296VXF0HU", is not valid because it contains the letter "U".

@E5presso If I'm trying to decode the value in first_sample I get a ValueError for the reasons pointed out by @migonzalvar
>>> from ulid import base32
>>> base32.decode("01J5PP33KAV586VA6296VXF0HU")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/martin.domke/Source/private/ulid/ulid/base32.py", line 198, in decode
    raise ValueError(f"Encoded ULID can only consist of letters in {ENCODE}.")
ValueError: Encoded ULID can only consist of letters in<PHONE_NUMBER>ABCDEFGHJKMNPQRSTVWXYZ.

Is there maybe something else going on in your code? Did you solve the issue by now?

@E5presso I will close this issue for now. If there is any further evidence for a bug in the code, feel free to reopen it.


fix (build): make devenv work on older debian

Relates to | Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] ./test.bash passes locally
[ ] Appropriate changes to documentation are included in the PR

@lbovet do you have access to (can you see?) the build failure log? shellcheck doesn't like the script... do you want to fix that?
I suspect that if you fix that, then the CI build will pass... which is very wrong - because we know that this doesn't actually work (as-is), just.
#458 to me seems to be a pre-requisite to merge this - we need to FIRST test the DevEnv as-is on CI, to then improve it with this PR.

I admit I am a bit lost with all these PR open...


Fix Privacy Manifest generator when it does not contain a NSPrivacyAccessedAPITypes key

Summary:

XCode privacy files might not contain a NSPrivacyAccessedAPITypes key, which causes the following error:
[!] An error occurred while processing the post-install hook of the Podfile.

undefined method `each' for nil

node_modules/react-native/scripts/cocoapods/privacy_manifest_utils.rb:111:in `block (4 levels) in get_used_required_reason_apis'
node_modules/react-native/scripts/cocoapods/privacy_manifest_utils.rb:106:in `each'
node_modules/react-native/scripts/cocoapods/privacy_manifest_utils.rb:106:in `block (3 levels) in get_used_required_reason_apis'

Changelog:

[IOS] [FIXED] - Privacy Manifest aggregation failing due to no NSPrivacyAccessedAPITypes key
Test Plan:

I tested this patch on our own app and it solved the issue.

Uhm... I'm a bit confused. How are you hitting this?
The template has that key and it is empty to start with, so you should not hit this error.

I am not sure what package causes it, but I have been hitting this after my last set of dependency updates.
I can provide my Podfile.lock if you ping me on the contrib Discord :)


Error: Invalid address

Can anyone help me fix this error. Checked everything was filled out correctly.
Error: Invalid address

+1


unaryOp: adjustIntConst

Codecov Report

Merging #59 (424d240) into main (ecbd3c2) will decrease coverage by 0.59%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   85.80%   85.20%   -0.60%
==========================================
  Files          10       10
  Lines        3120     3122       +2
==========================================
- Hits         2677     2660      -17
- Misses        353      368      +15
- Partials       90       94       +4

Impacted Files
Coverage Δ

cl/codebuild.go
84.29% <100.00%> (+0.06%)
:arrow_up:

cl/pkginfo.go
81.25% <0.00%> (-7.04%)
:arrow_down:

cl/compile.go
90.68% <0.00%> (-3.45%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecbd3c2...424d240. Read the comment docs.


feat: support using proxy for downloading file

Hello, @hegedustibor . I think maybe we can support set proxy for dowloading file in some case if user couldn't visit google.com.
Have a nice day😀

Thank you for submitting the Pull Request. I made some modifications to the code, added some tests, and expanded the Readme file. Once again, thank you very much for your solution, it's really great. ❤
Have a nice day.


Question about 'Connect your own data'

Within 'Connect your own data' section, a workflow of hacker_news has been generated and needed to be running. My questions are:

where to put the workflow file? save the following code somewhere?

path: /tmp/hn
embeddings:
  path: sentence-transformers/all-MiniLM-L6-v2
  content: true
tabular:
  idcolumn: url
  textcolumns:
  - title
workflow:
  index:
    tasks:
    - batch: false
      extract:
      - hits
      method: get
      params:
        tags: null
      task: service
      url: https://hn.algolia.com/api/v1/search?hitsPerPage=50
    - action: tabular
    - action: index
writable: true

how to run the workflow? save the following code somewhere then run it with python?

from txtai.app import Application

app = Application("index.yml")
list(app.workflow("index", ["front_page"]))

Thanks,

This project is in need of some updates. Once that happens, details about how to do this will be added to the README.


Update README to reflect package

Given that the package is called "gearman-node" and that virtually no other packages use "gearman-coffee", update the README to properly reflect the package import
gearman-coffee-> gearman-node

lgtm


Date picker doesn't work well with data grid custom filter

Description
Date picker doesn't work well with data grid custom filter.
Trying to implement date range custom filter in data grid column.

Date picker has less z-index than custom filter panel - so it gets hidden behind custom filter panel
On select of date custom filter panel gets closed.
There is some position issue in this sequence, open clr-dg-column-toggle panel -> close it -> open custom filter panel, now custom filter panel is displaying in top left corner of the page.
on click of custom filter column filter icon, sort action is getting triggered.
and also custom filter show up in clr-dg-column-toggle panel, is this expected behavior ?

How to reproduce
https://stackblitz.com/edit/clarity-v3-light-theme-4qytsw
example of custom date range filter in data grid.
Expected behavior

Date picker should have more z-index than custom filter panel - so it should show on top of custom filter panel
Custom filter panel should not close on date select, it should stay on until user close.
custom filter panel should not loose it position on open and close of clr-dg-column-toggle panel.
on click of filter icon in custom filter column should not trigger sort action.
Is there a way to hide custom filter in clr-dg-column-toggle ?

Versions
App

Angular: 9
Clarity: 3

@gnomeontherun thanks for looking into this, Do you have any workaround for "On select of date custom filter panel gets closed." ?

Are there any plans to fix this issue? It is a pretty common scenario to use a DatePick to filter a Date column.

There is some known workaround for this?


Added support for custom hostnames.

Had some issues with remote access to the server. The server was listen on localhost. Now it is possible to change the hostname in the brunch-config file with config.server.hostname.

Probably a CLI param would work better for that, instead of config? The same as port

With pushserve alone i know its possible to pass a host param. But i want to use brunch watch along with the auto-reload-brunch plugin.

Thanks Pascal. This is really useful!


[ZEPPELIN-5614] A JDBC interpreter property for disable setting tag for application of hive engines

What is this PR for?
This PR introduce a JDBC interpreter property for disable setting tag for application of hive engines.
Some users disabled tez.* property in hive  and hence unable to use hive in zeppelin. The reason is Zeppelin jdbc interpreter always set both tez and MR tags property when connect to hive.   This PR provide a property to disable setting tag for tez and MR application in hive.
What type of PR is it?
Improvement
Todos

[ ] - Task

What is the Jira issue?

Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-5614

How should this be tested?

CI passed

Screenshots (if appropriate)
Questions:

Does the licenses files need to update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Will merge if no more comment


Refactor and generalize the User Arg concept, add global

Since the discussion went sideways for a bit, I forgot to do the docs. Will update.

@mlibbey @bryancall  Docs updated.

Cherry-picked to v9.0.x branch.

@SolidWallOfCode This is where you want to comment so that I can now that you already added this documentation to the release notes (and probably upgrading to 9 as well).


Upgrade sequel gem to version 4.32

What this PR does:
This PR updates the sequel gem  from the version 4.3 to the latest version: 4.32
Notes
I had 2 main issues when upgrading the sequel gem.

In the version 4.15 the reciprocal option with non cached associations will require the reciprocal_type to be defined.

The only fallout from this change is that reciprocal_type for
many_to_one associations now needs access to the associated class
if not cached, so when caching is disabled, if there isn't a
single associated class (such as when using manually creating a
custom polymorphic association), you should manually set the
:reciprocal_type option.

More information in this commit: https://github.com/jeremyevans/sequel/commit/ae283c45550b999ad5cefa2dfff

In the version 4.10 the associations are now cached to improve the performance but we rely on the TimeMachine for certain associations, so we need to disable this caching when calling this associations.

More info: https://github.com/jeremyevans/sequel/commit/3d712213b4ac13ab69ddde0eae4ce84a0178a048
This last issue was very tricky to debug, but I hope with the new version of sequel we can take advantage from these new performance improvements.

 Tariff: Update Sequel to 4.32.0 (2016-03-02)


exit with status 1 if port already in use

@pranjal-verma Thanks for the contribution.
The code base has moved forward  lot. Please rebase and re-submit if you are still keen to fix this. We will be cleaning up old PR's if they are inactive.


i have no idea what im doing

i mean it be nice to have a video tutorial or like an easier read because im clueless now

Please read the wiki, there is also a link to a video tutorial in it.

Please read the wiki, there is also a link to a video tutorial in it.

i found the issue the tutorial isnt the issue tis the Command Prompt termination behaivor i suggest adding a mini tutorial on how to turn that off so stuff doesnt turn off automatically

now for the new problem
the damn text-generation-webui how does one turn this on?

It is explained in the tutorials and in the video. If you have a specific error, please detail it correctly or else it will be difficult to help.


<mysql/mysql.h> not found

#include <mysql/mysql.h>
I think this is an upstream issue but on Linux this just works.. on Windows <mysql.h> works but the difference is kinda annoying.
Could <mysql/mysql.h> be provided?

If you mysql/mysql.h is expected for everyone, I can make a PR to switch to create a mysql folder.
And libmariadb may not conflicted with mysql.

I think that mysql/mysql.h is the desirable path for both packages [1]. We should change this, thanks for bringing it up!
[1] https://www.archlinux.org/packages/extra/i686/libmariadbclient/


Add About Us section on index.html

You have to add About Us section.

You can use assets already present.
Use Lorem Ipsum for contents

Please assign this to my name, will work on it


Source Control: Diff does not update after "Stage/Unstage Selected Ranges" ...

... when "files.watcherExclude": {...} is configured in your settings.
!!! The file in question is NOT included in the exclude setting. !!!
This annoys me some time now, so this isn't new.
I have my workspace configured as such:

I've copied the exclude settings from my project where I discovered this.
As you can see test.c shouldn't match any of those rules.
This is my test file in the diff view with some unstaged and uncommited changes:

If I now select some changes and stage them the diff view does not update (most of the time, sometimes it does, but way more often it doesn't). I now have to change tabs or click out of the window and back in to update the diff view.
Made a GIF for you:

The really annoying part is that if you do select-stage multiple sections in sequence without the view updating in between only the last staged change is preserved. GIF again:

Here's the workspace I used for testing:
vsbug.zip

No Extensions Enabled
VS Code Version: 1.67.1
OS Version: W10 21H2

#149535 might be related, at least the outcome is the same.

Closing this as duplicate of https://github.com/microsoft/vscode/issues/147373.


Normalize line endings to lf

@timowest @johnktims @robertandrewbain Could someone comment on this? :sweat_smile:

Looks good

True true.


fix #2214

Sample:

Prep:

Codecov Report

Merging #2327 into dev will decrease coverage by 0.01%.
The diff coverage is 73.33%.

@@            Coverage Diff            @@
##             dev    #2327      +/-   ##
=========================================
- Coverage   93.8%   93.79%   -0.02%
=========================================
  Files        163      163
  Lines      18582    18589       +7
=========================================
+ Hits       17431    17435       +4
- Misses      1151     1154       +3

Impacted Files
Coverage Δ

...pet/handlers/api_proxy/tests/test_prep_template.py
98.68% <ø> (ø)
:arrow_up:

qiita_pet/handlers/api_proxy/prep_template.py
90.04% <100%> (+0.12%)
:arrow_up:

...ita_pet/handlers/study_handlers/sample_template.py
54.54% <20%> (-1.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10286b5...0d16b99. Read the comment docs.


Fix for GetResourceString ignoring cache clearing

fix for text changes not appearing until app pool restarts

Hey... even with this fix the String is loading the previous value after the edit on the admin... any hint of what could be? A restart of the app reloads correctly the labels and strings.

#257 I've ended up adding that code to force the reload.


Support cross-validation for selecting the best weight decay / L2 penalty

When @FabienRoger started playing around with the LBFGS optimizer he had to manually tune the L2 penalty to prevent overfitting on small datasets, which is not ideal. There is a simple well-understood way of setting regularization terms like this: cross-validation. Scikit-learn implements this for logistic regression as LogisticRegressionCV— which, by the way, we arguably should be using instead of the vanilla LogisticRegression class to get a better supervised baseline.
We'd use a logarithmic grid of, say, 10 L2 penalties and use the one which achieves the best out-of-sample unsupervised loss on the held out folds of the training data. After selecting the best penalty you'd do one last fit on the whole training dataset with that penalty.
This is primarily useful for smallish datasets where the number of datapoints is roughly equal to, or even smaller than, the hidden state dimensionality. It turns out, though, that a lot of the datasets we're looking at are of this size, so this does matter. The main downside of doing this is that it slows down the fitting process, but LBFGS is already quite a bit faster than Adam so it may not be much of a slowdown relative to the original code.
I'd say this isn't quite as pressing as some of the other issues right now but it would definitely improve the usability and robustness of the method. Since I've implemented cross validation methods before I'd be happy to do this myself when I have time but if someone else wants to take it on that'd be great.

One problem which might make this tricky is that the loss functions we're using are not convex, which means performance depends on the initialization. We may have to take the max performance over N random seeds for each penalty, or something.
We can potentially speed this up substantially by sequentially iterating over the grid of L2 penalties and warm-starting the optimization process for each penalty value with the parameters found for the previous penalty value, as scikit-learn does when warm_start=True.

Fixed by #135


http: move HTTP Datagram support check to constructor.

Commit Message:
Moved the runtime flag check for HTTP Datagram support to QUIC session constructors. This will eliminate the repeated runtime flag check, saving some CPU cycles.
Additional Description:
Risk Level: Low, the change is protected with the runtime flag.
Testing: Existing unit tests and integration tests cover this change.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

/assign @danzh2010
Hi Dan, can you review this PR? Thank you!

Please merge main & fix CI. Thanks!
/wait

/retest

Assigning Greg as !Google and senior-maintainer reviewer.
/assign @ggreenway


Test result XML does not work well with some tools when tests are repeated

Please see https://github.com/gradle/test-retry-gradle-plugin/issues/30
Particularly in the case of retrying failed tests and treating subsequent success as test success, the XML file that Gradle produces doesn't produce the desired feedback for some tools (e.g. Jenkins).
Note that Maven does handle this differently to Gradle, and its format seems to support the desired behaviour here.

Addressed by https://github.com/gradle/gradle/pull/15130


Add matching pattern for msbuild publish profile.

Matching files ending in ".pubxml" or ".pubxml.user".
These files often contain connection strings with passwords in plaintext, among other sensitive infos.

Thanks for contributing this! :+1:
Just googled the .pubxml.user file and found out  that the file can also contain an encrypted password. Do you know of any tools that is able to recover the cleartext?

Offhand, no. But that doesn't mean much, I only dabble!

Sorry for the long wait, there seems to be an error in your Regex, if you change it to:
\\A*\\.pubxml(\\.user)?\\z

I will merge it in!

You bet

:+1:


Migrate to utilize GitHub Actions

Summary

Update to utilize GitHub Actions rather than Travis CI

Looks like there are some "no newline" errors.


Search() in datalist & idList fails for empty struct

https://github.com/AssetMantle/modules/blob/ed62da973c6f414265ccff0662a378e4d3feb484/schema/lists/base/dataList_test.go#L133
https://github.com/AssetMantle/modules/blob/ed62da973c6f414265ccff0662a378e4d3feb484/schema/lists/base/idList_test.go#L114

resolved


ls: ignore value of POSIXLY_CORRECT

This PR ignores the value of POSIXLY_CORRECT to match the behavior of GNU ls. It also renames some vars related to block sizes for better readability and consistency.

Could you please add a test for this ? thanks


Python from the Windows store alias paths

Not sure if this a bug in platformdirs, but users will hit this issue so I'll share my observations
Platform dirs will return the environment variable path for things like data dir, log dir for the Python from the Windows Store.
Python in the Windows store uses app execution aliases, so the actual path is something else.
For example:
>>> import platformdirs, os
>>> d = platformdirs.user_data_dir(appname="foo", appauthor="bar")
>>> os.makedirs(d)
>>> d
'C:\\Users\\anthonyshaw\\AppData\\Local\\bar\\foo\\'
>>> test_file = os.path.join(d, 'test.txt')
>>> test_file
'C:\\Users\\anthonyshaw\\AppData\\Local\\bar\\foo\\test.txt'
>>> os.path.realpath(test_file)
'C:\\Users\\anthonyshaw\\AppData\\Local\\Packages\\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\\LocalCache\\Local\\bar\\foo\\test.txt'

This causes issues when you launch a process and use that path for something (e.g. where you created a file), but the process will resolve to a different path.
This can be disabled in apps > advanced app settings > app execution aliases in Windows.
NB: os.path.realpath only resolves this redirection  in Python 3.8+  and it only works for files, not directories.

Thanks for raising -- just to confirm, the same issue exists/existed on appdirs on windows, correct?

yes, this would apply to other appdirs

Prior art: https://github.com/python-poetry/poetry/pull/5931

PR welcome :+1:

Also found an interesting comment here

workaround:
>>> import os
>>> p1 = os.path.expandvars("%APPDATA%\\test.txt")
>>> p1
'C:\\Users\\steve\\AppData\\Roaming\\test.txt'
>>> open(p1, "w").close()
>>> os.system(f'copy "{os.path.realpath(p1)}" "{p1}"')
        1 file(s) copied.
0
>>>


onSelectionEnd does not trigger with ctrl-click mode

Describe the Bug
every time I select nodes with the ctrl button pressed and click on each node for selection the onSelectionEnd hook never triggers, just when I select dragging the mouse over the nodes.
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

add some function on onSelectionEnd on flowProps
select the nodes by clicking on each holding the ctrl button.
nothing happens
4

Expected behavior
onEndSelection triggers on the end of the process or everyTime the selection changesat
Screenshots or Videos
No response
Platform

Ubuntu 22.04 lts
11.8.3

Additional context
No response

The onSelectionStart and onSelectionEnd event handlers are meant for the selection box. If you want to track a multiselection you need to use onSelectionChange https://reactflow.dev/docs/api/react-flow-props/#onselectionchange


Crashes on VueJS implementation

Has anyone had success with VueJS and Capacitor?
I get:
⚡  [error] - {"line":1,"column":5502,"sourceURL":"capacitor://localhost/js/app.63a4a7d6.js"}
in my iOS Console.

Hello! I found my problem. I'm sorry, I needed to run npx cap update after installing the plugin.
Could you add this step in the README.md?
Thanks again!

README.md has since been updated to include instructions to run npx cap sync after installing plugin, closing.


Update the Gaudi trainer with transformers 4.45.2

What does this PR do?
Update the Gaudi trainer with transformers 4.45.2

Add the description
remove _is_peft_model function and import it from transformers
remove the unnecessary import datasets and keep the first one
Update the _get_train_sampler, by replacing computed var num_samples
Update the _inner_training_loop

num_update_steps_per_epoch used when possible
unused line was removed
add a new _should_compute_grad_norm var to remove extra conditional check

Update the _load_best_model, enabled the if self.is_deepspeed_enabled
Update _maybe_log_save_evaluate, _grad_norm.item() -> _grad_norm.detach.item()
Remove the _save_checkpoint, exactly the same as transformers
Update autocast_smart_context_manager, updateing the old interface
Update save_model, add accelerate version check
Update evaluation_loop

introduce a new var _should_update_inputs  for llama, qwen2, starcoder2 and gemma, to avoid double if condition in the loop
set the logits_dtype to float32 before the loop
re-order the conditionals for losses, logits, labels and match with
transformers

Update _inner_training_loop

introduce a new var _should_update_inputs for llama, qwen2, starcoder2 and gemma, to avoid double if condition in the loop

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The env for all tests,
export RUN_SLOW=true
export GAUDI2_CI=1

Some tests which are finished
- slow_tests_fsdp -> 2 passed in 689.82s (0:11:29) | the same accuracy and loss on both tests with main

- test_trainer_distributed -> 2 passed, 6 warnings in 21.19s | the same as main

- test_trainer -> 75 passed, 8 skipped, 37 warnings in 55.23s | the same as main

- test_trainer_seq2seq > 2 passed, 6 warnings in 21.19s | the same as main

Other tests are in progress and will be updated here

The env for all tests,
export RUN_SLOW=true
export GAUDI2_CI=1

test_examples  finished
- test_examples -> 11 failed, 50 passed, 2 warnings in 21761.68s (6:02:41) | 13 failed, 48 passed, 2 warnings in 23254.39s (6:27:34) on main

main branch

=========================== short test summary info ============================
FAILED tests/test_examples.py::MultiCardQuestionAnsweringExampleTester::test_run_qa_albert-large-v2_multi_card
FAILED tests/test_examples.py::MultiCardQuestionAnsweringExampleTester::test_run_qa_roberta-large_multi_card
FAILED tests/test_examples.py::MultiCardCausalLanguageModelingExampleTester::test_run_clm_gpt2_multi_card
FAILED tests/test_examples.py::DeepspeedCausalLanguageModelingExampleTester::test_run_clm_CodeLlama-13b-Instruct-hf_deepspeed
FAILED tests/test_examples.py::MultiCardSpeechRecognitionExampleTester::test_run_speech_recognition_ctc_wav2vec2-large-lv60_multi_card
FAILED tests/test_examples.py::MultiCardSummarizationExampleTester::test_run_summarization_t5-small_multi_card
FAILED tests/test_examples.py::DeepspeedSummarizationExampleTester::test_run_summarization_flan-t5-xxl_deepspeed
FAILED tests/test_examples.py::MultiCardCausalLanguageModelingLORAExampleTester2::test_run_lora_clm_falcon-40b_multi_card
FAILED tests/test_examples.py::MultiCardSeq2SeqSpeechRecognitionExampleTester::test_run_speech_recognition_seq2seq_whisper-small_multi_card
FAILED tests/test_examples.py::DeepspeedSFTExampleTester::test_sft_Qwen2-72B_deepspeed
FAILED tests/test_examples.py::MultiCardCausalLanguageModelingPrefixTuningExampleTester::test_run_prompt_tuning_clm_llama-7b_multi_card
FAILED tests/test_examples.py::MultiCardMultiTastPromptPeftExampleTester::test_run_multitask_prompt_tuning_t5-small_multi_card
FAILED tests/test_examples.py::MultiCardCausalLanguageModelingVeraExampleTester::test_run_lora_clm_llama-7b_multi_card
=========== 13 failed, 48 passed, 2 warnings in 23254.39s (6:27:34) ============

Current PR
=========================== short test summary info ============================
FAILED tests/test_examples.py::MultiCardQuestionAnsweringExampleTester::test_run_qa_roberta-large_multi_card
FAILED tests/test_examples.py::MultiCardCausalLanguageModelingExampleTester::test_run_clm_gpt2_multi_card
FAILED tests/test_examples.py::DeepspeedCausalLanguageModelingExampleTester::test_run_clm_CodeLlama-13b-Instruct-hf_deepspeed
FAILED tests/test_examples.py::MultiCardSummarizationExampleTester::test_run_summarization_t5-small_multi_card
FAILED tests/test_examples.py::DeepspeedSummarizationExampleTester::test_run_summarization_flan-t5-xxl_deepspeed
FAILED tests/test_examples.py::MultiCardCausalLanguageModelingLORAExampleTester2::test_run_lora_clm_falcon-40b_multi_card
FAILED tests/test_examples.py::MultiCardSeq2SeqSpeechRecognitionExampleTester::test_run_speech_recognition_seq2seq_whisper-small_multi_card
FAILED tests/test_examples.py::DeepspeedSFTExampleTester::test_sft_Qwen2-72B_deepspeed
FAILED tests/test_examples.py::MultiCardCausalLanguageModelingPrefixTuningExampleTester::test_run_prompt_tuning_clm_llama-7b_multi_card
FAILED tests/test_examples.py::MultiCardMultiTastPromptPeftExampleTester::test_run_multitask_prompt_tuning_t5-small_multi_card
FAILED tests/test_examples.py::MultiCardCausalLanguageModelingVeraExampleTester::test_run_lora_clm_llama-7b_multi_card
=========== 11 failed, 50 passed, 2 warnings in 21761.68s (6:02:41) ============

@regisss would you please check this PR, if we want to move towards v4.46.0, this PR will help.

Please make the title more descriptive to say what PR is doing.

@yafshar , Please redo make style, and a test run if you haven't already done so and confirm that no new test failures are seen. Thanks.

This PR,
>>>python -m pytest tests/test_gaudi_configuration.py tests/test_trainer_distributed.py tests/test_trainer.py tests/test_trainer_seq2seq.py -v -s
81 passed, 8 skipped, 140 warnings in 139.73s (0:02:19)

>>> python -m pytest tests/test_examples.py -v -s -k single_card
12 passed, 50 deselected in 2917.12s (0:48:37)

>>> python -m pytest tests/test_fsdp_examples.py -v -s
2 passed in 799.36s (0:13:19)

>>>  python -m pytest tests/test_examples.py -v -s -k multi_card
10 failed, 34 passed, 18 deselected, 2 warnings in 17206.15s (4:46:46)

>>> python -m pytest tests/test_examples.py -v -s -k deepspeed
3 failed, 3 passed, 56 deselected in 5636.71s (1:33:56)

main
>>>python -m pytest tests/test_gaudi_configuration.py tests/test_trainer_distributed.py tests/test_trainer.py tests/test_trainer_seq2seq.py -v -s
81 passed, 8 skipped, 140 warnings in 181.19s (0:03:01)

>>> python -m pytest tests/test_examples.py -v -s -k single_card
12 passed, 50 deselected in 2805.12s (0:46:45)

>>> python -m pytest tests/test_fsdp_examples.py -v -s
2 passed in 804.29s (0:13:24)

>>>  python -m pytest tests/test_examples.py -v -s -k multi_card
10 failed, 34 passed, 18 deselected, 2 warnings in 16397.55s (4:33:17)

>>> python -m pytest tests/test_examples.py -v -s -k deepspeed
3 failed, 3 passed, 56 deselected in 4832.87s (1:20:32)

@libinta , Please add run-test and other labels to allow this to merge into OH.
@regiss, This is ready for review and merge.

@yafshar , The test_examples.py times are longer than the previous version. Worth investigating?

Sure, these runs are on different machines, but sure, I will check and report back here

Nice! I'll run the nightly CI to see if there is no regression. Also, not sure the _load_best_model method works with DeepSpeed and FSDP.

@regisss , Do you have results from CI to share, was there any performance regression?

with the latest changes
main branch
>>>  RUN_SLOW=true GAUDI2_CI=1 python -m pytest tests/test_examples.py -v -s --token=$HUGGING_FACE_HUB_TOKEN -k MultiCardCausalLanguageModelingLORAExampleTester

2 passed, 51 deselected in 2873.00s (0:47:52)

The current PR
>>>  RUN_SLOW=true GAUDI2_CI=1 python -m pytest tests/test_examples.py -v -s --token=$HUGGING_FACE_HUB_TOKEN -k MultiCardCausalLanguageModelingLORAExampleTester

2 passed, 51 deselected in 2301.59s (0:38:21)


SQL Injection attacks

Hi has anyone looked at SQL Injection attacks against v2 of roadkill?
From my (very) short time playing with a default MSSQL install (latest v2), it seemed to me to offer little protection. If that's right I guess it's not suitable for exposure on the Internet.
Thanks
s

Roadkill v2 uses Dapper and Lightspeed ORM for SQL (Server, mySQL), for its installation and CRUD repositories
Perhaps you would like to raise a ticket with Mindscape or https://github.com/DapperLib/Dapper :)


Cannot use application when deleted broker with device

After deleting broker devices are not removed and this currently causes application error.

@dredziasty Can we currently after delete broker delete all connected resources ? It will make app easier and we will add it to feature for future. Thanks to that we will be able to deploy app faster.

What kind of issue does it cause? You list devices per broker so unassigned ones should not be pulled by the App

There is also screen to list all devices.

Is it so much effort to filter out devices with brokerId == null?

I guess it will not be, ok so nvm i will  compare brokerId == null. (when first I was writin i was thinking about database space but it doestn matter actually)

Got it, it's not big deal to get rid of data on production's db if we'll get overloaded with unnecessary data


Create home page for open source guide

This task includes to make a home page using the already available display component. You can take the images from here - https://opensource.guide/?ref=lapaninja
We are not going to make a clone of the same thing. Do not worry about the content. I will add it when you are ready with this page.

Hey I'm interested please assign


Documentation is unclear on units/format of output for pressure/humidity readings

When calling bme280_get_sensor_data() and looking at the data returned in the bme280_data struct, it's unclear what the units/format of the returned data are. For instance, temp is returned as degrees C * 100.
Can you clarify for me?

Hi @mhord,
Depending on whether the C flag, -DBME280_FLOAT_ENABLE is passed, or if the related line is  not commented in the header file,
In case of the flag enabled,
The outputs are in double and the units are

°C for temperature
% relative humidity
Pascals for pressure

In case of the flag not enabled, then it is

int32_t for temperature with the units 100*°C
uint32_t for humidity with the units 1000*% relative humidity
uint32_t for pressure

with the units 100 * Pascals if this define is enabled, which it is by default
or if that line is commented in the header, it is in Pascals.

Hope this clarifies it and doesn't confuse you further. :)

Thank you for the clarification and the prompt response!

@mhord,
There was a mistake regarding the units for humidity as another use pointed out. Refer the readme's chapter for the units.
https://github.com/BoschSensortec/BME280_driver/tree/bme280_v3.3.4#sensor-data-units


LMS365 (Certified connector): Added session title for CreateCourseSession

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[x] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[x] I attest that the connector works and I verified by deploying and testing all the operations.
[x] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[x] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[x] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[x] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[ ] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[ ] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[ ] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[ ] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@microsoft-github-policy-service agree [company=" ELEARNINGFORCE International"]

@microsoft-github-policy-service agree company="ELEARNINGFORCE International"

@microsoft-github-policy-service agree

The connector action (Create Course Session) is already broken as LMS API requires all new "Session" objects to contain "Title" field.
Please approve the PR as such request already fail due to required field missing.
Thanks

Hello @elearningforce-db,
I hope you are doing well.
Congratulations, your pull request is approved and merged. Please submit the files to ISV Studio or update your submission using your latest commit ID, please allow us up to 1-2 weeks to review your submission, and our Engineers will notify you in the “Activity Control” area in ISV Studio. Please make sure that the icon meets all the requirements, that it’s size is 230x230, icon background is not white or transparent and it matches the iconBrandColor property in apiProperties.json file.
After making the submission in ISV Studio, please attach an intro.md file in the activity control section. This file is required and it's different from readme.md. You can find an example of intro.md file on this page at step 6.
Please Create an environment in the Preview region. You will use this environment later to test your connector after Microsoft is done with the functional verification for your connector.
We expect all tests to be completed within 1-2 weeks.
If your connector passes all tests, the deployment process begins, and it typically takes up to 3 to 4 weeks to deploy your connector to all of our regions.
Please let me know if you have any questions or run into any problems while creating or updating your submission.
Thank you very much for working with us.


[FEATURE]Responsiveness of homepage

Detailed description
Homepage is not responsive. I would like to work on that.
Pls assign this issue to me under gssoc23
Context
Responsive is must now a days
Possible implementation
No response
Additional information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello :wave:
Duplicate of #331 #333 #350

Yea just raised it as it's still not completed

Yea just raised it as it's still not completed

Yes, issues are assigned in waiting for their PR. The live website still isn't responsive yet 😄

So how long will you wait before unassigning 😂

So how long will you wait before unassigning 😂

If a contributor doesn't provide an update on an issue within 2-3 days, we can unassigned. Please wait for now ^^

Okk

I am closing this issue since this is tagged as duplicate, you can reopen if you feel otherwise.

One should provide clear descriptions in the issue on what you can contribute in the responsiveness.


=this.field only pulls last value from a properties list type frontmatter

What happened?
Recently, when using =this.field it only pulls last value from a properties list type in frontmatter. This must have broken within the last update or two because it was working fine 7-10 days ago.
DQL
---
test:
  - Test 1
  - Test 2
  - Test 3
---

Which test? =this.test
(The field 'test' is a LIST type and result would produce "Test 3" instead of "Test 1, Test 2, Test 3")
JS
No response
Dataview Version
0.5.63
Obsidian Version
1.4.16
OS
MacOS

I was able to encounter/reproduce this issue with a user in the discord on Windows

I also noted the above change today. For what it's worth...
`$=dv.current().Skills`

...also renders only the last item.
`=this`

Used to display all the properties/fields and their values, compact and comprehensive. Again, it now only renders the singular "last" value.
The best part was a quasi-completion effect that made finding the correct reference enormously more simple when not viewing the frontmatter.

Same issue!

PR #2134 will fix this issue, and it's already merged into master. So it will be resolved in the next release.

I believe this fix is in the new release. Closing as done.


Resolve Bug on strange char in context var as in github

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.571%

Totals

Change from base Build<PHONE_NUMBER>4:
0.0%

Covered Lines:
138

Relevant Lines:
140

💛  - Coveralls


auto-format doesn't respect whitespace in lines

When you auto-format, any whitespace in your line is eliminated, This is annoying if you write comments like this, and like them to be lined up nicely:
  serial = new p5.SerialPort(); // make a new instance of the serialport library
  serial.open(portName);        // open a serial port

Thanks - I'll look into this.


validUntil to clear ephemeral documents from network

Perhaps as part of the performance focus, we should consider implementing "validUntil" to VCs and perhaps other documents that are not meant to remain useful beyond an expected period of time.  This would help clear Challenge/Response documents as well.

Resolved in #168? I took a slightly different approach.


Rendering unused css

Hello. I have a simple app.
import AppBar from '@material-ui/core/AppBar'

export default () => (
  <AppBar position="static">app bar</AppBar>
)

After rendering I see all unused styles of AppBar component.
<style data-jss="" data-meta="MuiAppBar">
.MuiAppBar-root-2 {
  width: 100%;
  display: flex;
  z-index: 1100;
  box-sizing: border-box;
  flex-shrink: 0;
  flex-direction: column;
}
.MuiAppBar-positionFixed-3 {
  top: 0;
  left: auto;
  right: 0;
  position: fixed;
}
.MuiAppBar-positionAbsolute-4 {
  top: 0;
  left: auto;
  right: 0;
  position: absolute;
}
.MuiAppBar-positionSticky-5 {
  top: 0;
  left: auto;
  right: 0;
  position: sticky;
}
.MuiAppBar-positionStatic-6 {
  position: static;
}
.MuiAppBar-positionRelative-7 {
  position: relative;
}
.MuiAppBar-colorDefault-8 {
  color: rgba(0, 0, 0, 0.87);
  background-color: #f5f5f5;
}
.MuiAppBar-colorPrimary-9 {
  color: #fff;
  background-color: #3f51b5;
}
.MuiAppBar-colorSecondary-10 {
  color: #fff;
  background-color: #f50057;
}
</style>

Why ?

@vetalstar It's a tradeoff for performance. Generating all the class names allow us to simply cache the style sheet without having to take the prop values into account in the cache key. Now, we are considering using the prop style interpolation going forward to allow more dynamic values: https://next.material-ui.com/css-in-js/basics/#adapting-based-on-props

I think we should include this in the documentation of the styling solution. One of the big selling points of CSS-in-JS solutions is dead-code elimination for unused CSS. This is not applied here consistently. It only applies to app level but not component level.

Closing, there are fewer CSS generated with the emotion way @mnajdova has pushed. For instance: https://github.com/mui-org/material-ui/blob/9ac8843cfc7a275908bc02b87f9d82618e529fd0/packages/material-ui-lab/src/SliderStyled/SliderStyled.js#L96
We didn't improve performance by doing such (it's slower: https://github.com/mui-org/material-ui/issues/22342#issuecomment-698547480) but at least the initial payload is smaller.


Updates

Hi there!
Is this repo alive? I can see last commit has happened about 2 years ago and at least ISO 4217 has changed since that time (i. e. belarusian ruble is BYN since July 2016).
So, are you going to support it?
If yes, I'd propose to replace hard-coded values to some code generation in assembly time from official XML files. I can help with it if you need.

Would make sense imho.


Update program-ideas.md

Made grammatical corrections and improved sentence structure throughout the README file.

cloud native and open source shouldn't have a -
https://github.com/cncf/foundation/blob/main/style-guide.md#1-cloud-native-and-open-source


Plugins that contain controllers don't compile yet

Given the following plugin with the module path plugin.com
bud-admin/
  controller/
    admin/
      admin.go
plugin.go
go.mod

And an application with the following module path app.com, if you run bud build, you'll get the following:
error: mod: unable to resolve directory for package path "app.com/controller/admin": stat
controller/admin: no such file or directory

While bud has successfully bundled the admin controller into the application, it's messed up the import paths:

Actual: app.com/controller/admin
Expected: plugin.com/controller/admin

@matthewmueller I would like to work on this issue.

Go for it! Let me know if you get stuck anywhere and I can try to help.
It's going to be a bit tricky because the virtual filesystem is at a lower-level than the generators, but the generators will somehow need to be able to resolve that import. I'd probably either trying to fix resolution in the gomod package.


failing early by checking registration

nit: can we remove to unchanged files from review?

Refers to: src/appliance-onboarding-script/appliance_setup/avs/avsarconboarder/creator/arcaddon/arc_addon_creator.py:36 in 3e4071d. [](commit_id = 3e4071d3bf1c212d5ae9494a01e2d8128a436616, deletion_comment = True)

nit: can we remove to unchanged files from review?
Refers to: src/appliance-onboarding-script/appliance_setup/avs/avsarconboarder/creator/arcaddon/arc_addon_creator.py:36 in 3e4071d. [](commit_id = 3e4071d, deletion_comment = True)

removed the unchanged files from review

Approved with nit comments


cache the service

Complete TODO: cache the Service.
https://github.com/istio/istio/blob/4d341b96cbfb51418a9264ff61fc04d08f0cac73/istioctl/pkg/auth/upgrade.go#L279

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: JieJhih
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @JieJhih. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@JieJhih: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-trustdomain-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-multicluster-e2e-master

prow/istio-presubmit.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-presubmit-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-multicluster-e2e-master

prow/istio-presubmit.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-presubmit-master

prow/istio-unit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible This PR has import github.com/patrickmn/go-cache, should I run something under bin or tools?

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-multicluster-e2e-master

prow/istio-presubmit.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-presubmit-master

prow/istio-unit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-unit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-galley-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-multicluster-e2e-master

prow/istio-presubmit.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-presubmit-master

prow/istio-unit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-unit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-framework-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-multicluster-e2e-master

prow/istio-presubmit.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-presubmit-master

prow/istio-unit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-unit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-multicluster-e2e-master

prow/istio-unit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-unit-tests-master

prow/integ-galley-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-presubmit.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-presubmit-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-multicluster-e2e-master

prow/integ-galley-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-presubmit.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-presubmit-master

prow/istio-unit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-multicluster-e2e-master

prow/integ-galley-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-presubmit.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-presubmit-master

prow/istio-unit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-unit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-multicluster-e2e-master

prow/integ-galley-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-presubmit.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-presubmit-master

prow/istio-unit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-unit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JieJhih Thank you for looking at this TODO.
Istio now uses Go modules.  See https://github.com/golang/go/wiki/Modules .  Look at those docs and the file go.mod to answer your question.
We don't want to add a new dependency to improve istioctl performance unless there is no other way.  Is there a performance problem with istioctl experimental auth upgrade?  If there is no problem we probably should not include this in Istio 1.2.  If there is a problem we should try to solve it without adding a new 3rd party dependency.

/retest

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-multicluster-e2e-master

prow/integ-galley-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-presubmit.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-presubmit-master

prow/istio-unit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-unit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-mixer-local-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-mixer-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-multicluster-e2e-master

prow/integ-galley-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-presubmit.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-presubmit-master

prow/istio-unit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-unit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-mixer-local-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-mixer-local-presubmit-tests-master

prow/integ-security-local-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-security-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-multicluster-e2e-master

prow/integ-galley-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/istio-unit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-unit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-mixer-local-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-mixer-local-presubmit-tests-master

prow/integ-security-local-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-security-local-presubmit-tests-master

prow/istio-presubmit.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-presubmit-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JieJhih: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test release-test-master

prow/e2e_pilotv2_auth_sds.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio_auth_sds_e2e-master

prow/e2e-mixer-no_auth.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-mixer-no_auth-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test e2e-simpleTests-master

prow/istio-pilot-multicluster-e2e.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-pilot-multicluster-e2e-master

prow/integ-galley-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-galley-k8s-presubmit-tests-master

prow/integ-framework-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-framework-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-mixer-local-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-mixer-local-presubmit-tests-master

prow/integ-security-local-presubmit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test integ-security-local-presubmit-tests-master

prow/istio-presubmit.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-presubmit-master

prow/istio-unit-tests.sh
2fae21448a349906a4453ce08461989a3399836b
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


declare should not show values

It's not only about showing values, but definitions of forward declarations are actually evaluated before their dependents, making e.g this namespace showable in clerk, but not loadable by plain clojure
(ns scratch.debug
  (:require [nextjournal.clerk :as clerk]))

(declare delayed-def)

(inc delayed-def)

(def delayed-def 123)

This has been reported by @sheluchin on clojurians slack before.

definitions of forward declarations are actually evaluated before their dependents

this is actually related to the displayed values because we actually eval (def delayed-def 123) instead of (declare delayed-def):
https://github.com/nextjournal/clerk/blob/cc5cf40f45afb50c7df51a81247920c64e798452/src/nextjournal/clerk/eval.clj#L168


Remove old media from plugin?

I have a plugin in Dotfyle where there is an image that no longer exists on the main branch but persists on the plugin page.
It would be good (as an author) to have an option to clean up old media. Or even if there was some additional logic in the media indexer to remove legacy images etc.

Makes sense, I know of the issue but haven't gotten to it!
There will be some issues with previously published TWiN issues containing stale image urls -> but I'm not sure how to solve that without storing the images myself, which I will not do at this time.
I'd likely go with deleting stale images that are no longer available in the readme, this would be the relevant code if anyone wants to pick this up
https://github.com/codicocodes/dotfyle/blob/637f333b9acd9b5add0f95a5c2b316f98c276d98/src/lib/server/sync/plugins/sync.ts#L91-L104

I tried making a patch for this issue in PR #140, but I ran a few more testes and realized I still need to do some more work on it, because my delete query is crashing the seeder.
I'll try and work on it more tomorrow.


About Bootstrap CarouselSlider

Hello,
The slider is working well.But when clicked on Next Slide,the first slide also slides with it and also happening with other sliders
So the first slide slides with every other slides in bootstrap carousel slider
i did some custom modifications to slider

You voided the warranty :)
Sounds like you modified either the html or css and didn't account for that change in the other.


feat: port Data.Real.GoldenRatio

todo:

[x] gold_sq goldConj_sq simpNF linter wants to simplify lhs using div_pow, but the result looks uglier

bors r+


Add activity feed API

Description

Testing Instructions

Closes TURBO-2481

Current dependencies on/for this PR:

#7554  👈
nicholasyang/package-watching

This stack of pull requests is managed by Graphite.


Authentication information in each log event

Current Implementation
Before processes like diagnosis key upload/download or callback registration begin, a client should be authenticated by EFGS. After the successful authentication, dnString and thumbprint of its certificate are logged. These two are important to the operations/security team as they can track the source countries with them. However, these two attributes are not included in the later logs, but can only be tracked with traceID.
Suggested Enhancement
MDC logger is not 'clear()'ed every time. If one API call, including authentication and the following actions, takes place with the same process (the same process ID) and it can be ensured that there are no other tasks done in parallel in that process, then I guess it's good to go.
Expected Benefits
It will reduce the efforts to track the source countries.

No cleaning MDC is clearly a bug. changing label

After a re-test, upload & download, wait until the batch job is finished as well as intentionally created error situations, every assignment of the dnString and thumbprint was fine. Together with Chun-Te we checked the logs, compared the thumbprints with the certs from the DB and found no discrepancies. For now, no additional clean call in the MDC (EfgsMdc) is necessary. Together we decided to close the issue.