Restrict the object names allowed characters to a smaller, more common set.

PR Checklist

[X] A description of the changes is added to the description of this PR.
[X] If there is a related issue, make sure it is linked to this PR.
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added or modified a feature, documentation in docs is updated

Description of changes
This change restricts object names to a smaller, more common character-set - a-z, A-Z, 0-9, _(underscore), @(at sign) and -(hyphen).
Resolves Issue https://github.com/unitycatalog/unitycatalog/issues/185

@haogang

lgtm. please resolve conflicts.

done.

Can we please add some more test cases for the changes in this PR : https://github.com/unitycatalog/unitycatalog/blob/main/server/src/test/java/io/unitycatalog/server/utils/SqlNameValidationTest.java


Fixed MiqExpression evaluation on tagged Services

Before MiqExpression evaluating expression, it is trying to resolve referenced associations (if any).
It is done by compare passed reference to a run-time object.
If passed object's class not the same as passed reference than MiqExpression consider that passed reference is an association and  trying to obtain associated object.
ISSUE: If  reference passed to MiqExpression is "service" and run-time object when evaluating expression is class descendant from Service,( like ServiceContainerTemplate) than MiqExpression will try to substitute passed object by invoking  service on passed object, which will return nil
FIX: Do not attempt to substitute original (runtime) object passed to MiqExpression if that object descendant from Service and reference passed to MiqExpression is "service"
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1628727
@miq-bot add-label bug, blocker, gaprindashvili/yes
\cc @gtanzillo

@miq-bot add-label hammer/yes

Hammer backport details:
$ git log -1
commit 5d30389b1fbda1627073b466f344eb3059d3dd1c
Author: Gregg Tanzillo<EMAIL_ADDRESS>Date:   Mon Oct 1 09:17:44 2018 -0400

    Merge pull request #18020 from yrudman/fixed-expression-with-tag-on-service

    Fixed MiqExpression evaluation on tagged Services

    (cherry picked from commit d670fe8fa67f1cd6acb1c3405016062592fbeb6d)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1628727

Gaprindashvili backport details:
$ git log -1
commit<PHONE_NUMBER>1a3e0000841a2994612f94ff43ba0b
Author: Gregg Tanzillo<EMAIL_ADDRESS>Date:   Mon Oct 1 09:17:44 2018 -0400

    Merge pull request #18020 from yrudman/fixed-expression-with-tag-on-service

    Fixed MiqExpression evaluation on tagged Services

    (cherry picked from commit d670fe8fa67f1cd6acb1c3405016062592fbeb6d)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1634809


NITC NTIP and NDPN, also corrected a small bug at the end of the json…

… file

Thank you for your contributions @ankurgajurel  :partying_face:
Join our Discord to claim your contributors role (if you haven't already) and stay connected with us.
Cheers!


The memory cost when train on my own dataset

@HYPJUDY Thanks for your nice work.
I have tested decouple-ssad without any problem. But when I try to run train mode, it will get OOM error. I saw you sad we need 'one or more GPU with 12G memory', I wonder decouple-ssad will take use all of the 12G? My GPU only have 8G, can I change some setting in config.py to let the training run normally?

Please try to reduce batch_size in
https://github.com/HYPJUDY/Decouple-SSAD/blob/8af4bfd5840c6403f7cc4b6cea2ea328db30498e/config.py#L28
I think it will reduce the memory cost. But maybe you need to tune learning_rate and training_epochs as well to achieve the best performance.
https://github.com/HYPJUDY/Decouple-SSAD/blob/8af4bfd5840c6403f7cc4b6cea2ea328db30498e/config.py#L41-L42
I've tried batch size of 32 before, the performance is still comparable but maybe not as good as 48. I didn't carefully tune other parameters at that time.
If you find such parameters for small memory GPU, please share with us.
Thanks and good luck!


fix: missing og video type

Description
This PR will add the missing og:type for videos.
OG Docs Reference

Now the commit has been signed @TacticalTechJay, thanks for the help.


Fix exception manager tests which are slow and flakey

Motivation and Context
The ATs which check the exception manager are working, are adding loads of time to the AT test run, and are not at all reliable.

[x] Context Index has been kept up to date

What has changed
Used a retry instead of arbitrary sleep. Also, reduced sleeps for quarantining messages.
How to test?
Run ATs... but this is mainly to improve things in CI, so we should try this and fail forwards.
Links
Trello: https://trello.com/c/1MyWuNyW

 ATs are flakey


Updated safari-pinned icon to fit bounds. Updated color to be black

Updated masked icon for Census 2021.
Light and dark mode image below (Safari)
Closes #1357

 Update safari masked icon


Gekko delay in backtest mode

I'm submitting a bug report
Action taken (what you did)
We tested a simple strategy with 4 EMA's
2 EMA's for trend detection and 2 EMA's for long/short orders
Expected result (what you hoped would happen)
Gekko must long/short when 2 EMA's cross in backtest mode
Actual result (unexpected outcome)
Gekko long/short with delay by 1 candle in backtest mode
The same for any time frame
We plotted EMA's on backtest chart to check it
We plotted candle impulses to double check it
Gekko detects EMA crossing and make actions only on the next candle
Probably Gekko waits until candle is closed and after that detects EMA crossing
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)
The question is how to make Gekko act faster, without delay?
How to make Gekko detect EMA crossing inside the candle and long/short in actual candle?

I'm submitting a bug report
Action taken (what you did)
We tested a simple strategy with 4 EMA's
2 EMA's for trend detection and 2 EMA's for long/short orders
Expected result (what you hoped would happen)
Gekko must long/short when 2 EMA's cross in backtest mode
Actual result (unexpected outcome)
Gekko long/short with delay by 1 candle in backtest mode
The same for any time frame
We plotted EMA's on backtest chart to check it
We plotted candle impulses to double check it
Gekko detects EMA crossing and make actions only on the next candle
Probably Gekko waits until candle is closed and after that detects EMA crossing
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)
The question is how to make Gekko act faster, without delay?
How to make Gekko detect EMA crossing inside the candle and long/short in actual candle?

Hi mate, did you figure out the 1 candle delay issue in the backtest mode?


Aeson 0.11

Seems that ghc-8.0.1 fails. Hopefully someone is looking into those issues!

I went ahead and made an revision on Hackage: https://hackage.haskell.org/package/haxl-<IP_ADDRESS>

This to unlock aeson-0.11 issue on Stackage: https://github.com/fpco/stackage/issues/1211
Also queued the matrix.h.h.o build: http://matrix.hackage.haskell.org/package/haxl

Hopefully this will be merged soon.


Connect reason code

Note that the first commit on this PR is https://github.com/redboltz/mqtt_cpp/pull/388
When https://github.com/redboltz/mqtt_cpp/pull/388 is merged, i will rebase this PR.

#388 has been merged.

@redboltz
I have no internet for the next 2 days.
If you want to resolve the problems with this PR, that would be fine with me.
Otherwise, I will fix in 2-3 days.

See also these branches:

https://github.com/jonesmz/mqtt_cpp/tree/disconnect-reason-code
https://github.com/jonesmz/mqtt_cpp/tree/suback-reason-code

Codecov Report

Merging #390 into master will decrease coverage by 14.81%.
The diff coverage is 39.68%.

@@             Coverage Diff             @@
##           master     #390       +/-   ##
===========================================
- Coverage   86.03%   71.22%   -14.82%
===========================================
  Files          39       40        +1
  Lines        6245     5160     -1085
===========================================
- Hits         5373     3675     -1698
- Misses        872     1485      +613


fix: Change firewall rule name to avoid naming collisions & use AlloyDB Zonal instance by default.

Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[X] Follow the CONTRIBUTING Guide.
[X] You are listed as the author in your notebook or README file.

[X] Your account is listed in CODEOWNERS for the file(s).

[X] Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
[X] Ensure the tests and linter pass (Run nox -s format from the repository root to format).
[X] Appropriate docs were updated (if necessary)

Fixes #629 🦕

@holtskinner - Merging is blocked on based on the linter complaining about indentation. Is this expected behavior?

@holtskinner - Merging is blocked based on the linter complaining about indentation. Is this expected behavior?

@paulramsey The Linter was updated recently, it's likely the standards for Shell scripts have changed. I'll run the shfmt tool on your .sh files to resolve the issue.


terraform plan fails after upgrading from 2.3.1 to 3.0.0

I have issues
I'm submitting a...

[x] bug report
[ ] feature request
[ ] support request
[ ] kudos, thank you, warm fuzzy

What is the current behavior?
terraform plan fails with this error: Error: module.eks.aws_eks_cluster.this: : invalid or unknown key: enabled_cluster_log_types
If this is a bug, how to reproduce? Please include a code sample if relevant.
Update version from 2.3.1 to 3.0.0, run terraform plan
module "eks" {
  source          = "terraform-aws-modules/eks/aws"
  version         = "3.0.0"
  cluster_name    = "${local.cluster_name}"
  kubeconfig_name = "${local.cluster_name}"
  subnets         = "${local.subnets}"
  tags            = "${local.tags}"
  vpc_id          = "${local.vpc_id}"

  cluster_endpoint_private_access = "${var.cluster_endpoint_private_access}"
  cluster_enabled_log_types = []

  worker_groups      = "${local.worker_groups}"
  worker_group_count = "${length(local.worker_groups)}"

  map_users = "${local.map_users}"
  map_roles = "${local.map_roles}"

  map_users_count = "${length(local.map_users)}"
  map_roles_count = "${length(local.map_roles)}"

  write_aws_auth_config = "${var.write_aws_auth_config}"
  write_kubeconfig      = "${var.write_kubeconfig}"

  # Set up the aws profile for aws-iam-authenticator:
  kubeconfig_aws_authenticator_env_variables = {
    AWS_PROFILE = "${var.aws_profile}"
  }
}

What's the expected behavior?
terraform plan should succeed.
Are you able to fix this problem and submit a PR? Link here if you have already.
Yes
Environment details

Affected module version: 3.0.0
OS: MacOS 10.13.4
Terraform version: v0.11.13
provider.aws v2.6.0

Any other relevant info

Looks like running a terraform init -upgrade=true updated the AWS provider form 2.4.0 to 2.6.0 and that fixed the issue.

@cwiggs Isn't the latest AWS provider version 2.13.0?
https://github.com/terraform-providers/terraform-provider-aws/blob/master/CHANGELOG.md
I'm also experiencing the same issue as you, after upgrading from 2.31 to 4.0.2.


Capture all logs during tests

Codecov Report

Merging #56 (9281c20) into master (859cf9f) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   92.67%   92.72%   +0.05%
==========================================
  Files           3        3
  Lines         382      385       +3
  Branches       44       47       +3
==========================================
+ Hits          354      357       +3
  Misses         17       17
  Partials       11       11

Impacted Files
Coverage Δ

src/fscacher/tests/test_cache.py
93.20% <100.00%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 859cf9f...9281c20. Read the comment docs.

` (macos-latest, 3.7, py) (pull_request)` failed with test_memoize_path
```
______________________________ test_memoize_path _______________________________
cache = <fscacher.cache.PersistentCache object at 0x10ae2c1d0>
tmp_path = PosixPath('/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_memoize_path0')
def test_memoize_path(cache, tmp_path):
    calls = []

    @cache.memoize_path
    def memoread(path, arg, kwarg=None):
        calls.append([path, arg, kwarg])
        with open(path) as f:
            return f.read()

    def check_new_memoread(arg, content, expect_new=False):
        ncalls = len(calls)
        assert memoread(path, arg) == content
        assert len(calls) == ncalls + 1
        assert memoread(path, arg) == content
        assert len(calls) == ncalls + 1 + int(expect_new)

    fname = "file.dat"
    path = str(tmp_path / fname)

    with pytest.raises(IOError):
        memoread(path, 0)
    # and again
    with pytest.raises(IOError):
        memoread(path, 0)
    assert len(calls) == 2

    with open(path, "w") as f:
        f.write("content")

    t0 = time.time()
    try:
        # unless this computer is too slow -- there should be less than
        # cache._min_dtime between our creating the file and testing,
        # so we would force a direct read:

      check_new_memoread(0, "content", True)

.tox/py/lib/python3.7/site-packages/fscacher/tests/test_cache.py:128:

arg = 0, content = 'content', expect_new = True
def check_new_memoread(arg, content, expect_new=False):
    ncalls = len(calls)
    assert memoread(path, arg) == content
    assert len(calls) == ncalls + 1
    assert memoread(path, arg) == content

  assert len(calls) == ncalls + 1 + int(expect_new)

E       AssertionError: assert 3 == ((2 + 1) + 1)
E        +  where 3 = len([['/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_memoize_path0/file.dat', 0,...ivate/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_memoize_path0/file.dat', 0, None]])
E        +  and   1 = int(True)
.tox/py/lib/python3.7/site-packages/fscacher/tests/test_cache.py:108: AssertionError
------------------------------ Captured log call -------------------------------
DEBUG    fscacher.cache:cache.py:147 Cannot fingerprint /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_memoize_path0/file.dat: [Errno 2] No such file or directory: '/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_memoize_path0/file.dat'
DEBUG    fscacher.cache:cache.py:111 Calling <function test_memoize_path..memoread at 0x10ab8e440> directly since no fingerprint for '/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_memoize_path0/file.dat'
DEBUG    fscacher.cache:cache.py:147 Cannot fingerprint /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_memoize_path0/file.dat: [Errno 2] No such file or directory: '/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_memoize_path0/file.dat'
DEBUG    fscacher.cache:cache.py:111 Calling <function test_memoize_path..memoread at 0x10ab8e440> directly since no fingerprint for '/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_memoize_path0/file.dat'
Level 5  fscacher.cache:cache.py:144 Fingerprint for /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_memoize_path0/file.dat: FileFingerprint(mtime_ns=1638895363472791239, ctime_ns=1638895363472791239, size=7, inode=12892993449)
DEBUG    fscacher.cache:cache.py:122 Calling memoized version of <function test_memoize_path..memoread at 0x10ab8e440> for /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_memoize_path0/file.dat
DEBUG    fscacher.cache:cache.py:83 Running original <function test_memoize_path..memoread at 0x10ab8e440> on '/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_memoize_path0/file.dat'
Level 1  fscacher.cache:cache.py:129 Returning value 'content'
Level 5  fscacher.cache:cache.py:144 Fingerprint for /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_memoize_path0/file.dat: FileFingerprint(mtime_ns=1638895363472791239, ctime_ns=1638895363472791239, size=7, inode=12892993449)
DEBUG    fscacher.cache:cache.py:122 Calling memoized version of <function test_memoize_path..memoread at 0x10ab8e440> for /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pytest-of-runner/pytest-0/test_memoize_path0/file.dat
Level 1  fscacher.cache:cache.py:129 Returning value 'content'
</details>
restarted that run - green upon rerun... so this time it was a different test (echoing https://github.com/con/fscacher/issues/55#issuecomment-988118716) failing than `test_memoize_path_dir ` of #55.

I will merge this PR and will propose a crude tentative workaround for #55 via `os.sync()` - let's see how that one goes


VS thinks we are using C# 2.0

Cannot use var.
Error	CS8023	Feature 'implicitly typed local variable' is not available in C# 2.  Please use language version 3 or greater.	Test Console Application.csproj	c:\users\basoundr\documents\visual studio 15\Projects\Test Console Application\Test Console Application\Program.cs	13	Active
I remember this issue being discussed but I am not sure if an issue had already been opened.

This is related to @davkean's language service work. No arguments are getting passed to the language service right now, so it thinks we're using old C#.

Yes, even bunch of diagnostic related things should get addressed with new LS:

Diagnostic suppressions via nowarm don't work
No analyzer intellisense diagnostics. Even the build diagnostics for analyzers have no squiggles.
Project code analysis ruleset is not respected by intellisense

This is fixed with #369

This is happening again in Microsoft Visual Studio Professional 2022 (64-bit) Version 17.0.3 as at 21/12/2022.

This is happening again in Microsoft Visual Studio Professional 2022 (64-bit) Version 17.0.3 as at 21/12/2022.

Please file a feedback ticket (via the Help menu) and include as much detail as you can.


Workaround for Jline regression

Fixes #2480
Workaround jline/jline2#205
/review @Duhemm, @dwijnand, @xuwei-k

LGTM but could you drop a comment in code with a short description and/or link for the regression? I think it's food practice to for workarounds.

I just confirmed on my local PC 👍
(use https://github.com/tototoshi/sbt-build-files-watcher )

this pull request

0.13.11

Regression fixed upstream in jline2 2.14.3 (see https://github.com/scala/scala/pull/5635)


Starting application is broken

As described here in How to use? section I run:
$> java -jar ../Downloads/jpeek-0.5-jar-with-dependencies.jar --sources takes --target ./jpeek-takes
Exception in thread "main" java.lang.IllegalArgumentException: Exactly two arguments required: source and output directory
        at org.jpeek.Main.main(Main.java:54)

Directory takes is present and contains takes project.
I expect the application to start or describe what I do wrong.

@yegor256/z please, pay attention to this issue

@piotrkot you need a fresh version of the app. 0.5 is a very old one. Try the latest one: https://github.com/yegor256/jpeek/releases

The job is not in WBS, can't close

@yegor256 I see. Thanks. That means it is a mistake to keep link to version 0.5 in the How to use section. Can you fix this?

@piotrkot yep, fixed in 0cb7e82 thanks!

@yegor256 And yet another detail. The first sentence in How to use - "Load this JAR file" - is linked with the version 0.5. Can you fix this too?

@piotrkot how about now? 8c40bd2

@yegor256 perfect, thanks!


Stabilize Custom Meta Boxes Support

Feature Description
Follow-up to #3134 to:

[x] Turn on feature by default
[ ] Remove feature flag
[ ] Stabilize UI
[x] Refactor code where needed
[x] Fix bugs where needed
[ ] More testing with other plugins

Some plugins to test with:

AiO SEO Pack
Yoast SEO (needs upstream PR first)
Polylang
WPML

Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Hi @samitron7, for landing this feature I'd like your eyes on the design.
Here's a quick explainer.
We've integrated the "meta boxes" feature from WordPress so the editor better supports existing publishing editing workflows, for example so users can customize their SEO configuration for stories just like they can for posts.
These meta boxes are essentially third-party content from other WordPress plugins that we have no control over, which we sort of embed into our editor.
For comparison, here's how such a custom meta box looks like in Gutenberg:
Collapsed:

Open:

And here's how we've currently implemented this in the editor:
Collapsed:

Open:

As you can see, it is very similar. And I think it works very well this way, but perhaps there are some tweaks we can make.
A few clarifying notes:

If you don't use any other plugins, there are no UI changes to the editor. Seeing this really requires installing & configuring another plugin.

The meta boxes only take up as much space as they need. Here's an example with 3 meta boxes, with only the middle one collapse:

We have no control over the meta box content or styling. That means we cannot paint them in the way we like, except maybe for the title area. Rest needs to be white. Example:

Collapsed:

Open:

@swissspidy I'm a little concern over the vertical height this has taken. If there a way we can hide everything inside an icon/cta and only expose the accordion menu when you click on the icon/cta? This looks problematic on small screens as it takes up a lot of real estate.

@swissspidy I'm a little concern over the vertical height this has taken. If there a way we can hide everything inside an icon/cta and only expose the accordion menu when you click on the icon/cta? This looks problematic on small screens as it takes up a lot of real estate.

@swissspidy Would be great if we can do this. Let know and I can help get you a reasonable cta treatment if it works. Also, if we have no control over the metabox styling, it would be better to have the whole thing be one color versus the gray and white.

I actually think the gray header blends in much nicer with the rest of the editor than a white header; but I'll see how a CTA affects this.

I actually think the gray header blends in much nicer with the rest of the editor than a white header; but I'll see how a CTA affects this.

@samitron7 I put something together here:
https://user-images.githubusercontent.com/841956/104297181-d80c3780-54c2-11eb-8bd5-825d37f0aaf4.mp4
Again, when a user/site doesn't have any third-party integrations, the editor will look the same as today:

Please let me know what you think.

@samitron7 I put something together here:
https://user-images.githubusercontent.com/841956/104297181-d80c3780-54c2-11eb-8bd5-825d37f0aaf4.mp4
Again, when a user/site doesn't have any third-party integrations, the editor will look the same as today:

Please let me know what you think.

@swissspidy Yes, much much better!

@swissspidy Yes, much much better!

Added the following and saved draft. Reopened and entered input remained:

However, on page reload the fields cleared:

Added the following and saved draft. Reopened and entered input remained:

However, on page reload the fields cleared:

@csossi I think you found the two fields that won't easily work 😅

The "translations" field is not a type-whatever-you-want field. You'd have to click on the plus to connect a post
The focus keyphrase field seems buggy in AiO SEO. Try the meta description field or a field in the "social" tab

@csossi I think you found the two fields that won't easily work 😅

The "translations" field is not a type-whatever-you-want field. You'd have to click on the plus to connect a post
The focus keyphrase field seems buggy in AiO SEO. Try the meta description field or a field in the "social" tab

Verified in QA

Verified in QA


Sort by crate lexicographical order

Fixes #511.
First time contributing to an open-source project, so please let me know if I've done anything wrong or how I can improve. Also should I squash my commits before submitting the PR?
And running cargo fmt completely changes the way the imports are structured, so I ended up saving without formatting, but I'm not sure if that's what's intended

Thanks for the PR!
For coherence, I think we should use the same value for Eq and Ord (even though for well-formed keys it shouldn't matter for the current PR):
* either the cleaned key (`String`)

* or the dot-separated cleaned key (`Vec<String>`)

The whole issue being that we need to compare the Split instead of the String itself, I believe the only option is then to use the Split for Eq as well.

The whole issue being that we need to compare the Split instead of the String itself, I believe the only option is then to use the Split for Eq as well.

Yes, we should use the same value for all comparisons: Eq and Ord. The choice between "foo.bar" and ["foo", "bar"] doesn't make a big difference to me. It's true the second is a bit cleaner, but the first is also simpler. I'm fine with both.

The whole issue being that we need to compare the Split instead of the String itself, I believe the only option is then to use the Split for Eq as well.

Yes, we should use the same value for all comparisons: Eq and Ord. The choice between "foo.bar" and ["foo", "bar"] doesn't make a big difference to me. It's true the second is a bit cleaner, but the first is also simpler. I'm fine with both.

I'm not sure I understand. If we use "foo.bar" for Ord, don't we have exactly the same problem as before?

I'm not sure I understand. If we use "foo.bar" for Ord, don't we have exactly the same problem as before?

Sorry, what I meant was "foo.bar." like I initially suggested in https://github.com/tamasfe/taplo/issues/511#issuecomment-1846912854.

Sorry, what I meant was "foo.bar." like I initially suggested in #511 (comment).

I apologize, I still must have misunderstood something. From what I had gathered, the problem comes from the fact that the '-' comes before the '.', which leads to "foo-.bar" to come before "foo.bar", even though "foo" comes before "foo-" (and we wanted those two ordering to be consistent). If that is correct, the "foo.bar." will still come after "foo-.bar.", no? On the other hand, ["foo", "bar"] would correctly come before ["foo-", "bar"].

Ok, got it now, thanks. Then I think I don't have new modifications to write. I'm not sure what's the correct process now: should I re-ask for a review or is that implied by this conversation?

I apologize, I realize my previous message was far from clear :smiling_face_with_tear:  Thanks to your explanations, I now see how your solution provides consistency, but I would prefer the solution where that ordering is also consistent with the "classical" alphabetical order (foo before foo-bar). Since it's comparing iterator, I don't think there is a downside in performance, and believe it's probably closer to what most people would expect. Would that be okay with you?

Yes, both were fine with me. So let's modify the cleaned_key to be Vec<String>.

No problem, thanks, I'll push the Vec modification in a min. For my curiosity (still learning :) ): wouldn't that require one more allocation than just splitting in place every time? Do you prefer it because it's easier to read at the (arguably very low) cost of just one additional allocation?

Yes, there's one more allocation, but this is not high performance code (as you might have seen by the previous code allocating strings on every comparison) so it's not a concern. However readability and correctness by construction is more important here. In particular the fact that the comparison key exists in only one place is the key factor. Even without the comparison key being cached I would have been fine (i.e. fn cmp_key(&self) -> Vec<String> being called at each comparison for both sides).

Thanks for the explanations, very clear and makes a lot of sense!

Out of curiosity, how does the release process work ? I've seen that the commit has been released as part of release-taplo-0.13.0, and I was wondering how it translates in terms of the vscode extension. Thanks for your insights


Error listing Service Fabric clusters: 'ClusterListResult' is not iterable

Describe the bug
Attempting to list the Service Fabric clusters in a resource group while using Azure CLI produces an error.
To Reproduce
Ensure resource group test-rg exists. Then:
az sf cluster list -g test-rg
Expected behavior
A list of 0 or more Service Fabric clusters is displayed.
Environment summary
Azure Cloud Shell
Additional context
dan@Azure:~$ az sf cluster list -g gamefabric-rg
'ClusterListResult' object is not iterable
Traceback (most recent call last):
File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 197, in invoke
cmd_result = self.invocation.execute(args)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 345, in execute
six.reraise(*sys.exc_info())
File "/opt/az/lib/python3.6/site-packages/six.py", line 693, in reraise
raise value
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 319, in execute
result = cmd(params)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 169, in call
return self.handler(*args, **kwargs)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/init.py", line 440, in default_command_handler
result = op(**command_args)
File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/servicefabric/custom.py", line 106, in list_cluster
return list(cluster_list)
TypeError: 'ClusterListResult' object is not iterable

I was able to reproduce.

Met the same problem
'ClusterListResult' object is not iterable
Traceback (most recent call last):
  File "/usr/local/Cellar/azure-cli/2.0.57/libexec/lib/python3.7/site-packages/knack/cli.py", line 206, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/local/Cellar/azure-cli/2.0.57/libexec/lib/python3.7/site-packages/azure/cli/core/commands/__init__.py", line 328, in execute
    raise ex
  File "/usr/local/Cellar/azure-cli/2.0.57/libexec/lib/python3.7/site-packages/azure/cli/core/commands/__init__.py", line 386, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/usr/local/Cellar/azure-cli/2.0.57/libexec/lib/python3.7/site-packages/azure/cli/core/commands/__init__.py", line 379, in _run_job
    six.reraise(*sys.exc_info())
  File "/usr/local/Cellar/azure-cli/2.0.57/libexec/lib/python3.7/site-packages/six.py", line 693, in reraise
    raise value
  File "/usr/local/Cellar/azure-cli/2.0.57/libexec/lib/python3.7/site-packages/azure/cli/core/commands/__init__.py", line 356, in _run_job
    result = cmd_copy(params)
  File "/usr/local/Cellar/azure-cli/2.0.57/libexec/lib/python3.7/site-packages/azure/cli/core/commands/__init__.py", line 171, in __call__
    return self.handler(*args, **kwargs)
  File "/usr/local/Cellar/azure-cli/2.0.57/libexec/lib/python3.7/site-packages/azure/cli/core/__init__.py", line 441, in default_command_handler
    return op(**command_args)
  File "/usr/local/Cellar/azure-cli/2.0.57/libexec/lib/python3.7/site-packages/azure/cli/command_modules/servicefabric/custom.py", line 106, in list_cluster
    return list(cluster_list)
TypeError: 'ClusterListResult' object is not iterable


Add language select on onboarding screen

Would require adding a setting for this. Explore best practices on this though, it may be preferable to just use the system language.

I have determined that Trail Sense will just use the system default language, as that seems like the more common practice among apps.


Add onErrorRestart operator to Eval

When an Error occurs the eval chain is restarted until it completes successfully or the specified number of retries is run down.
Eval<T> onErrorRestart(long retries)

Eval.now(10)
    .map(i -> {
                count++;
                if(count<1000)
                     throw new RuntimeException();
                return count;
        })
    .onErrorRestart(1000000)
    .get(); //1000

Part of #986

Released in 10.1.1


HR-122 Set up automated provisioning

Resolved conflicts with main and had to force push to fix commit messages without proper formatting


 I suppose low disk space was an attendant circumstance.
console log.zip

I dont see any exception related with extension.
Is this happening every time ?


Module name doesn't match the repo name.

The module name is manager which is a) different to the repo name and b) already taken on PyPI. Possibly a good time to come up with a name for this project going forward? Off the top of my head - datashuttle? Open to suggestions.

I like datashuttle its snappy and nicely sums up the purpose. I've been thinking off and on about the name and didn't get very far. I'm happy to go with that, I agree now is a good time for the name change.

I like the datashuttle name. Can't think of anything catchier. Also requires no dashes/underscores, which is nice


Show that guestIP should be specified to ignore ports for forwarding

Alternative for #2906

We also need to think about this message:
INFO[0012] [hostagent] TCP (except for SSH) and UDP port forwarding is disabled

And the special behavior not to log about "Not forwarding port". Maybe both should be used only if guestIP is "<IP_ADDRESS>"?

You can link this to #2901


Exploring how to track upstream work

In discussing with @damianavila we've concluded that we want to explore how to provide insights on open-source contributions made. Understanding that it will be hard to capture all kinds of contributions, we've opted to explore trying to capture something specific: merged PRs in the jupyterhub github organization.
Initial action points

[ ] @damianavila creates a GitHub project in https://github.com/orgs/2i2c-org/projects
[ ] @consideRatio defines columns: url, org, proj, author, merged at
[ ] @consideRatio trials populating the project with self-authored PRs using a script that both acquires relevant info and adds entries to the project

Notes on how the gh CLI was used to acquire a list of self-authored and merged PRs in a github org/project between a set of dates can be found in https://hackmd.io/cLDYNuu5TTm1r3PZ7dfWyg.

[ ] Discuss with @damianavila and consider further action points

Wow! That is a great overview and system @choldgraf!
@damianavila seeing that makes me think we should re-evaluate adding another github project as planned. What so you think?

I do think that simply tracking our activity is mostly accomplished by that upstream/ page. Though if we wished, we could improve it to break things down by author for example.
 If I did that, I wouldn't want a list of PRs or numbers of comments. I'd want something like 3 things that were obviously impactful that our team intentionally spent their time on improving. How can we build practices to consistently highlight these 3 things?

Closing as stale and likely obsolete work thanks to the upstream page at https://2i2c.org/kpis/upstream/


Image count not always displayed correctly when there is only one page

What steps will reproduce the problem?
Search for example 'endless_dungeon' with the sources chan.sankakucomplex.com and yande.re enabled. You will see that chan.sankakucomplex.com doesn't know how many images / pages there are and that yande.re couldn't count the images correctly (There are 2 images and it says 2 of 1). Here are some screenshots:
https://i.imgur.com/eP6SWh9.png
https://i.imgur.com/sinupZm.png
What is the expected behavior? What do you get instead?
Displaying the correct count of images.
How often does this problem occur? On which sources?
Everytime with sankaku complex and yande.re (Possible also others)
What version of the program are you using? On what operating system?
Version 6.0.2 with windows 10
Please provide any additional information below

chan.sankakucomplex.com
I just pushed a few fixes to improve page/image count parsing.
However, note that there are some cases where the page/image count is impossible to determinate:

No search: Sankaku doesn't give the information of the total number of images on the site.
More than one tag, and not on the last page: Sankaku only gives the individual tag count, not the number of results returned by a given search. Grabber only knows when it arrived at the last page and the >> link isn't a link anymore.

yande.re
For yande.re image count, it seems to actually be a bug in Moebooru.
Either that or some weird behavior.
There are indeed two posts there, but one (link NSFW) is "held from the index by the poster" and doesn't appear in normal search results, but does appear in the API results (with a is_held flag set to true). However, even with that being the case, it is still not taken into account in the count for the API (see link): even though there are obviously two results (<post>), the count is still set to 1 (<posts count="1">).
Grabber always trusts the API, but it this case it's behaving strangely.
I see three options:

Get the maximum between the image count from the API and the number of results returned by the search. In this case, max(1, 2) will give the correct result of 2.
Hide posts where is_held is set to true. While it seems to be a nice way to handle it, given the nature of this program I'm not sure about voluntarily hiding results from the user.
Do nothing and file a bug report in Moebooru issue tracker.

I think that it is than the best to do nothing about the strange result by yande.re. Since the cause is now not by grabber but by their API.


Run Installing script - additional text required

[Enter feedback here]
Dear Team,
As you mentioned the below text cautioning the reader about the Python version, it would be great if you could also write some additional comments that python3 should be used instead of python in the Run the "Installation" Script section of the CEF & Syslog via AMA article. This will avoid customer frustration, unnecessary calls to the support team, inquires with the Microsoft CSU - CSA. Please refer to the attached picture for more details.
"The Linux log forwarder VM must have Python 2.7 or 3 installed. Use the python --version or python3 --version command to check. If using Python 3 make sure it's set as the default command on the machine, or run the scripts below with the 'python3' command instead of 'python'."
Regards,
Ram
<EMAIL_ADDRESS>

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 90b9ff2e-1b6f-c083-6b23-91d5dcf88276
Version Independent ID: 9d6e3712-9fe0-2083-46d1-94d8626548d5
Content: Ingest Syslog and CEF messages to Microsoft Sentinel with the Azure Monitor Agent
Content Source: articles/sentinel/connect-cef-syslog-ama.md
Service: microsoft-sentinel
GitHub Login: @yelevin
Microsoft Alias: yelevin

@ramachander36
I'm going to assign this to the document author so they can take a look at it accordingly.

Thank you for your comment! We'll investigate and get back to you.
#label:"backlog-item-created

@ramachander36 Thanks for reaching out!
I added a clarification as requested. It should be published in the next 24 hours.
#please-close
cc: @SaibabaBalapur-MSFT @batamig


Dedupe code to get config

Description
Adds a new function get_sae_config() which takes a release and sae_id and returns the config for an SAE. To get the config for an SAE, one shouldn't have to know the conversion function or download the weights, and one is more likely to know the release and sae_id than repo_id and folder_name. We also currently duplicate a lot of code across pretrained_sae_loaders.py and generate_sae_table.py.
Fixes #305, fixes #315
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have not rewritten tests relating to key interfaces which would affect backward compatibility

You have tested formatting, typing and unit tests (acceptance tests not currently in use)

[x] I have run make check-ci to check format and linting. (you can run make format to format code if needed.)

Performance Check.
If you have implemented a training change, please indicate precisely how performance changes with respect to the following metrics:

[ ] L0
[ ] CE Loss
[ ] MSE Loss
[ ] Feature Dashboard Interpretability

Please links to wandb dashboards with a control and test group.

Overall this looks great! Just could use some unit tests on the new get config function and should be good to go!

Thanks!

@anthonyduong9 just wanted to say i used this today and it worked great! thank you.


d3admin — Revision number doesn't reset with new Version number

When a new Version of a package is introduced, the Revision number keeps it's inherited value rather than resetting. For instance, if a given package was previously at Version 2, Revision 5 and it's Version number was changed from 2 to 3, it's Revision number would remain at 5 instead of resetting to 1.

Fixed in 3.0.10


Added the 'spo contenttype get' command solving #532

Added the 'spo contenttype get' command solving #532

Coverage remained the same at 100.0% when pulling 59c72a8adcddd1d246dbde0e5b8f09583d6446e7 on waldekmastykarz:spo-contenttype-get into 43900ece0f9f23426c6b71ee7e6a620579e3d6ce on pnp:dev.

Merged manually


GUVNOR-2738: Guided Decision Table Editor: Highlight rows in table when V&V report item selected

See https://issues.jboss.org/browse/GUVNOR-2738
This PR adds highlighting of rows in a Decision Table based on the Analysis Report selection.

@Rikkola as discussed on IRC...


added box-shadow property

I have added a standard property of box-shadow where -moz-box-shadow and -webkit-box-shadow already exist, just for the fallback in case both of them don't work.

Issue: There are some browsers that may not recognize -moz-box-shadow and -webkit-box-shadow. So, it is always safe to have a fallback.
Hope you like it.
Thanks,
Anshu Jindal

Hi @Anshu-jindal , thank you for contributing and this is a great idea. However, changes should not be made in sbuttons.css or sbuttons.min.css.
Please make changes in the necessary files under src then run npm run compile. You can read more in the contributing guidelines


added idscodes to python path for pytest, removed unneeded init.p…

…y - the build tool paths and pyproject.toml handle it - and modifed test**.py files so they are runnable from python3

I think this one should merge fine once PR#6 is merged. Apologies.


Replace __resource.lua with fxmanifest.lua

What exactly is the advantage of using fxmanifest over an __resource.lua? Does it improve performance? Load times?

No, it doesnt improve anything. FiveM just said that __resource.lua will be deprecated with RedM release.

if it doesnt introduce any benefits then i doubt there is a reason to change it, the last thing RDR needs is a speedometer resource.

U dont get the point. __resource.lua will be deprecated for gta too after RedM release. But do whatever u want. I dont really care. I have everything with fxmanifest

this resource is the definition of "deprecated", its nearing 3 years of age now, the only reason i recently worked on it was due to a user making a skin for it and having some issues. its fine as-is


expo build fail for android

Description
build fails after running expo run:android
Execution failed for task ':react-native-unistyles:buildCMakeDebug[armeabi-v7a]'.
FAILED: ../../../../build/intermediates/cxx/Debug/4m2n6q6n/obj/armeabi-v7a/libunistyles.so
C++ build system [build] failed while executing:
/Users/keshav/Library/Android/sdk/cmake/3.22.1/bin/ninja
-C
/Users/keshav/Desktop/TGC_APP/TheGoldClass/node_modules/react-native-unistyles/android/.cxx/Debug/4m2n6q6n/armeabi-v7a
unistyles
from /Users/keshav/Desktop/TGC_APP/TheGoldClass/node_modules/react-native-unistyles/android
"dependencies": {
"expo": "~52.0.15",
"expo-status-bar": "~2.0.0",
"react": "18.3.1",
"react-native": "0.76.3",
"react-native-edge-to-edge": "^1.1.3",
"react-native-nitro-modules": "^0.18.1",
"react-native-unistyles": "^3.0.0-beta.1"
},
Steps to Reproduce

Create new expo blank app
Xcode Version: Version 16.1 (16B40)
Run yarn add react-native-unistyles@beta
yarn add react-native-nitro-modules react-native-edge-to-edge
Add to babel plugin
yarn expo prebuild --clean

Snack or Repository Link (Optional)
No response
Unistyles Version
3.0.0
React Native Version
0.76.3
Platforms
Android
Expo
Yes

Duplication of #373


bugfix(client):serverRequest always return no vailed master if http s…

…tatus code is not 403 or 200
What this PR does / why we need it:
function serverRequest of master client sdk always return no vailed master if http status code is not 403 or 200

LGTM


Remove attributes from components that use it

Description
Once #604 is complete, all Rails components that use attributes can be refactored to remove this property.
Related
Blocked by #604

Moved to Jira https://kajabi.atlassian.net/browse/UXD-68


reportsDir property omission in Detekt task for android and jvm configurations

Expected Behavior

The reportDir property in the Gradle task Detekt is equivalent to that set in the DetektExtension.
The reportDir property in the Gradle task Detekt is annotated with the @OutputDirectory annotation.

Observed Behavior

The reportDir property from DetektExtension is only used in DetektPlain configuration and is omitted in DetektAndroid and DetektJvm. Instead it is directly used to set the outputLocation for DetektReport.
Currently, the reportDir property in the Gradle task is marked with the @Internal annotation, preventing its use for task linking through inputs/outputs.

Steps to Reproduce
//build.gradle.kts

abstract class CollectDetektReportsTask : DefaultTask() {

    @get:InputFiles
    abstract val reports: ConfigurableFileCollection
}

val collectReportTask = tasks.register("collectDetektReports", CollectDetektReportsTask::class)
subprojects {
    plugins.withType(DetektPlugin::class.java) {
        val detektTasks = tasks.withType(Detekt::class.java)
        collectReportTask.configure {
            reports.from(detektTasks.map { it.reportsDir })
        }
    }
}

//app/build.gradle.kts

plugins {
    ....
    id("io.gitlab.arturbosch.detekt")
}

detekt {
    reportsDir = project.layout.buildDirectory.dir("detektReport").get().asFile
}

Run:
./gradlew :collectDetektReports

Output:
Cannot query the value of task ':app:detektDebugUnitTest' property 'reportsDir' because it has no value available.

Context
I want to collect all reports from Detekt tasks using the root collect task as ReportMergeTask does, but I need to use a custom report format (csv) and use task configuration avoidance and link tasks to each other by inputs/outputs as Gradle recommends.
Currently this is not possible for Detekt, as the task outputs are not directly linked to the task itself as described at https://github.com/detekt/detekt/issues/4856.
I noticed that the task also has a reportDir property, which is an output for the task and could be a solution to the problem, but it is marked as @Internal. I also noticed that the task property has no convention value from DetektExtension because it is omitted in the DetektAndroid and DetektKotlin classes, but is only set for DetektPlain .
Solution
To solve the problem with the reportDir property in Detekt tasks, I suggest setting a convention for the reportDir property within the task based on the value from the DetektExtension, as was done for DetektPlain.
Inquiry
Is there a specific reason for marking the reportDir as @Internal? Could it be annotated with @OutputDirectory to resolve issue and improve Detekt's integration with Gradle's task configuration avoidance and output linking?
Your Environment

Version of detekt used: 1.23.5
Version of Gradle used (if applicable): 8.6
Gradle scan link (add --scan option when running the gradle task):
Operating System and version:
Link to your project (if it's a public repository):

Please review #6964 which should fix this. I haven't made the update you suggested, but the PR updates the report output locations so they're correctly annotated and linked to the task.


[5.4] Check for api token in request headers

Look for the api token in request headers. If you want to use header token without framing it to look like OAuth's Bearer token.

This is probably fine to go to 5.3. Ping @taylorotwell.

Use the Authorization header. No need for a non-standard header.


electron-builder: icons should be at the root of the buildResources folder

Issue originally spawned from:
https://github.com/readium/readium-desktop/pull/391#issuecomment-508860097
electron-builder automatically picks-up icon files inside the buildResources folder (typically: icon.icns and icon.ico which contain multiple resolutions).
https://github.com/readium/readium-desktop/blob/4155769dae1684e136371d2c786816156adda2cc/package.json#L96-L97
...but right now this special folder contains the following subfolder icons:
https://github.com/readium/readium-desktop/tree/4155769dae1684e136371d2c786816156adda2cc/resources
This is why the icon reference must be explicit, as per this PR: https://github.com/readium/readium-desktop/pull/391
See documentation:
https://www.electron.build/icons

Also see: https://github.com/readium/readium-desktop/pull/408


Typoscript Parser Error

I get a parser error in this line:
https://github.com/million12/M12.Foundation/blob/master/Resources/Private/TypoScript/Neos/Image.ts2#L38
with Neos: "typo3/neos": "~2.0.0"

Yeah multiline eel is only in 2.1. Bump requirements?

well, the composer.json does't say anything about a dependency to EEL 2.1. Therefor I would expect it also runs in 2.0.

Yeah, that's what I meant, we should update package requirements

@simonschaufi sorry about that, I missed that completely when making this change.
I tagged v1.0.0 somewhere before that change, as that was pretty stable release.
And then tagged the latest commit with v1.1.0. See https://github.com/million12/M12.Foundation/releases
Hope it helps.


Shared Validation Errors missing in newest release

Hi!
I'm wondering why the shared validation errors from the 0.2.x release (see https://github.com/inertiajs/inertia-laravel/blob/v0.2.15/src/ServiceProvider.php#L27) isn't anymore in the 0.3.x release? I don't find any informations about this breaking change? Am I missing something out?
Thanks in advance!
Greets!

This commit broke the whole thing, see https://github.com/inertiajs/inertia-laravel/commit/b7e0c5f1ef1f67ea4f6446f901a2a0aad25aec45#diff-0dcb363b46434ce2fc8f2969d3e4a183bab1157c17425fb826da41427cff01e6

v0.3.0 introduced a new middleware, see the release notes here https://github.com/inertiajs/inertia-laravel/releases/tag/v0.3.0
As you can see in the commit you linked, the validation errors have been moved to the middleware

Thanks @RobertBoes, make sense. It was not clear for me at the beginning ;) All fine, issue can be closed.


docs(readme): updating to reflect focus areas

Updating README.md.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Mod doesn't work on 1.14.4 Forge

Hey,
Your mod doesn't want to load on 1.14.4 Forge

Ok my bad,  I forgot to download the Forge Cloth dependency ^^ Thanks for this mod ^^


Uncaught TypeError: (intermediate value)(intermediate value)(...) is not a function

Tried updating from 1.1.0 to 1.2.0 but it only works in development. It breaks the app in the minified version with the following error:
Uncaught TypeError: (intermediate value)(intermediate value)(...) is not a function

Strange, since 1.2.0 is intended to fix the issue you describe. Which minifyer are you using?

Ooops, sorry, thinking about the wrong directive. One minute...

It's an application generated with Yeoman's generator-angular.
This issue may be related to the fact that the bower snippet mentioned in the README doesn't works as there's no src/js directory.  Am I doing something wrong?
I had to change it to:
  "overrides": {
    "angular-date-time-input": {
      "main": [
        "src/dateTimeInput.js",
      ],
      "dependencies": {
        "angular": "^1.x",
        "moment": "^2.x"
      }
    }
  }

That looks okay - thanks for letting me know about the error in the readme. What other libraries are you including?

Here's my package.json and bower.json: https://gist.github.com/nicolasgarnil/7ce0282ba14e74b7dfe32571a3d8f050
Why does suddenly dateTimeInput.js doesn't contain semicolons? How is this resolved?

semicolon are not needed in JavaScript except in a few cases - minification parsers will inject semicolons where needed to safely minify this directive - except in one case -  when you concatenate two IIFE's from two separate files into one file before minifying. This code tries to handles that case by starting its IIFE with ;( rather than just (.
I suspect you have another IIFE coming after this directive that starts only with ( - in this case you can fix the problem you are having by injecting a ; between files when concatenating. Including this file last during concatenation would also likely fix the issue.
Just guessing here since I don't have access to your minification pipeline.  If you need further assistance please give me access to the code or create a minimal working example that recreates the problem.

That's unfortunate as the error is being thrown in the vendor.js file where I don't have control over how the IIFEs start and I'm seeing there are a couple of them which doesn't start with ;, as for example daterangerpicker.js in bootstrap-daterangepicker.
I followed your advice and place dateTimeInput.js at the end and it worked. But I believe this directive should work right out of the box without needing to inject semicolons or re-arranging the files.
Thanks for your help.

I can see you might think this problem has something to do with this directive. However, It has nothing to do with this directive.
You have proven it is not this directive because everything works in development, it only fails when the files are concatenated and minified in a way that causes a JavaScript syntax error.
The concatenate / minify build chain that you are using does not properly handle the language. Specifically, it does not inject semicolons in the JavaScript code. Fix the build chain and you will never see this problem.
You don't have to reorder the files. You can also minify then concatenate (leaving a newline between separate files, or you can add a semicolon when concatenating and then minify. You could also use libraries where the author correctly deals with JavaScript ASI by starting IIFE's with ;( - either way the minified code is the same size.
I could also terminate the IIFE in this directive with a ;, but  will not allow it.

BTW, you always have control over how the IIFEs start by injecting a ; between files when you concatenate - this is a one line change for most concatenations.


VSTest v. 15.0.26929.2 could not work with MSTest V2 unittests

Description

Unittest project using MSTest.TestAdapter and MSTest.TestFramework (both v. 1.1.18) (MSTest V2) couldn't be run via VSTest v. 15.0.26929.2
This version of VSTest is distributed via "Agents for Visual Studio 2017" (v. 15.4.3)

Steps to reproduce

Create a new unittest project in VS2017 with one simple unittest aka Assert.IsTrue(true);
Run command:
C:\Program Files (x86)\Microsoft Visual Studio\2017\TestAgent\Common7\IDE\CommonExtensions\Microsoft\TestWindow>vstest.console.exe u:\VSTestCheck\Debug\VSTestCheck.dll /testadapterpath:"u:\VSTestCheck\Debug" /listtests

Expected behavior

All tests in assembly listed in console

Actual behavior

No test listed

Environment

Windows Server 2012 R2 Standard
Agents for Visual Studio 2017 (v. 15.4.3)
VSTest.Console v. 15.0.26929.2

Diagnostics log from VSTest:
diag.txt

Trying to use adapter from MSTest.TestAdapter NuGet package content.

We have different version of Agents for Visual Studio 2017 - I have 15.4.3, you 15.4.4.
Version of VSTest.Console 15.0.26929.2 is same, but some dependencies could be in different version.
Please, do you have a chance to test it on v. 15.4.3.? I'm in corporate environment and upgrade of software is very difficult and long term "mission". :(

I don't think it is an issue with different version of Agents for Visual Studio.
@petrciml : Can you also drop "Microsoft.VisualStudio.TestPlatform.TestFramework.Extensions.dll" in your testadapter path and try?

Unfortunately did not help too :(

Can you enable vstest.executionengine*.exe.config logging. Here is how you can enable that. And share the logs with us.
Can you use below command to run the tests to make sure vstest.executionengine*.exe is indeed launched :
"C:\Program Files (x86)\Microsoft Visual Studio\2017\TestAgent\Common7\IDE\CommonExtensions\Microsoft\TestWindow\vstest.console.exe"  /testadapterpath: /inisolation

Great, problem solved. Many thanks!
In vstest.console.TpTrace.log I'm found following error:

System.NotSupportedException: An attempt was made to load an assembly from a network location which would have caused the assembly to be sandboxed in previous versions of the .NET Framework. This release of the .NET Framework does not enable CAS policy by default, so this load may be dangerous. If this load is not intended to sandbox the assembly, please enable the loadFromRemoteSources switch. See http://go.microsoft.com/fwlink/?LinkId=155569 for more information.

After moving folder from U:\VSTestCheck into C:\VSTestCheck problem is solved


Flaky test Debug a cell from a python file:1 | Invalid number of code lenses returned

Debug a cell from a python file:1 | Invalid number of code lenses returned
https://github.com/microsoft/vscode-jupyter/runs/5029542406?check_suite_focus=true

fixed in https://github.com/microsoft/vscode-jupyter/pull/10899


Issue validating url

Hi,
I'm trying to validate an optional URL field with regEx: SimpleSchema.RegEx.Url. The problem is that when I use check(doc, mySchema) server side, match fails if URL is empty, even though i'm using optional: true.
How can I make check() work and allow an empty URL?
Thanks.

How and where should I call simpleSchema.clean? I have the same issue. Getting a provide valid url on a empty string.


flutter-prod-builder can not create swarming task

This is causing the staging builds to fail when invoked through led. Full error log.
The build link: LINK
cc: @godofredoc

This is a dupe of #87958 .

@iskakaushik a potential PR landed to address this. Could you verify if it allows you to invoke the build via led?

Still having the same error:
https://logs.chromium.org/logs/flutter/led/kaushikiska_google.com/bba4b2fb433cd61900811342ce40abae3b94606994f18218d240d30bbd4a21bb/+/u/launch_builds/led_launch/stderr

https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/kaushikiska_google.com/bba4b2fb433cd61900811342ce40abae3b94606994f18218d240d30bbd4a21bb/+/build.proto failure link.

@iskakaushik assigning this to you to retry a new build today. Please rebase before running the test. If it still fails, reassign this bug to @godofredoc .

Adjusted a few parameters and led executions are now working properly:
https://chromium-swarm.appspot.com/task?id=556a7a21d05c5810
Recipe changes to adjust led priorities:
https://flutter-review.googlesource.com/c/recipes/+/16982


Reset root group cache when elected as leader

Summary:
GroupRepository are holding in memory caches of the root group. The cache is loaded when it is accessed the first time.
Therefore the root group state is loaded from zk when the marathon instance is started.
When the marathon instance is elected as leader, this cache is still in the same state as the time marathon started.
Therefore we need to re-load the root group from zk again from zookeeper when becoming leader.
The same is true after doing the migration. A migration or a restore also affects the state of zookeeper, but does not update the internal hold caches. Therefore we need to refresh the internally loaded caches after the migration.
Actually we need to do the fresh twice, before the migration, to perform the migration on the current zk state and after the migration to have marathon loaded the current valid state to the internal caches.
Test Plan:
sbt integration:test
Reviewers:
jeschkies, timcharper, zen-dog, jenkins
Reviewed By:
jeschkies, zen-dog, jenkins
Subscribers:
jdef, marathon-dev, marathon-team
JIRA Issues:
MARATHON-7565, MARATHON-7458, MARATHON-7401
Differential Revision:
https://phabricator.mesosphere.com/D847
https://phabricator.mesosphere.com/D895

This is not quite a backport since GroupManager is still an actor in 1.4. We ended up calling invalidateGroupCache in the Migration class itself. Otherwise it wouldn't work.

Thanks for the feedback! Going to land this now.


Is there a bug in FasterRCNN's data augmentation?

Bug Reports/Usage Questions Only:

What you did:
I noticed that data augmentation  in examples/FasterRCNN https://github.com/ppwwyyxx/tensorpack/blob/0.8.1/examples/FasterRCNN/data.py#L214 will cause boxes' coords as negative numbers, is there a need to clip the coords?

If you're using examples:

What's the command you run:
   python data.py
Have you made and changes to code? Post them if any:

`
    boxes_original = boxes
    # augmentation:
    im, params = aug.augment_return_params(im)
    points = box_to_point8(boxes)
    points = aug.augment_coords(points, params)
    boxes = point8_to_box(points)

    if  np.any(boxes<0):
        print("bboxes:",boxes)
        print("before bboxes:",boxes_original)

`

Any of those values < 0 seem to be caused by floating point rounding.
And since boxes are used for regression, I don't think it will be an issue.


allow whitespace to be a _terminator where possible?

I've been fiddling with the (H)EEx queries lately trying to find something that works really well. There are some tough cases that I think might be solveable with changes to this grammar.
The main issue is combined injections. Consider some EEx like so:
<%= Enum.map(@charges, fn charge -> %>
  <%= humanize_money(charge) %>
<% end) %>

Here lines 1 and 3 need injection.combined (like with tree-sitter-iex) so that the end is parsed as part of the same document as the fn .. ->. Line 2 can be parsed regularly (no combined injections). For the combined parts, this looks like so to tree-sitter-elixir:
Enum.map(@charges, fn charge ->  end)

That case works pretty well with the current grammar and queries in tree-sitter-eex, but injection.combined introduces some problems. Consider this EEx:
<%= Enum.map(@charges, fn charge -> %><% end) %>
<%= Enum.map(@charges, fn charge -> %><% end) %>

With the current grammar and queries, this produces an (ERROR) on the second Enum. This happens because the EEx grammar is consuming the newline. To tree-sitter-elixir, this example looks like:
Enum.map(@charges, fn charge -> end)  Enum.map(@charges, fn charge -> end)

How does tree-sitter-embedded-template fix this?
In this example of an ejs template from the expressjs repo,
  <% posts.forEach(function(post) { %>

<%= post.title %>

<%= post.body %>

  <% }) %>

All of the inner JavaScript contents are injection.combined, so this comes out like so for tree-sitter-javascript
posts.forEach(function(post) { post.title post.body })

Which tree-sitter-javascript parses as if it were valid JavaScript (which, to my knowledge, it is not). This happens in tree-sitter-ruby as well with erb templates: the grammars are intentionally more permissive around newlines and whitespace than the language actually allows.
Possible solutions
I see a few ways around this to make the EEx injections work as well as ejs/erb.
The first is to try to allow spaces to be $._terminators whenever it doesn't introduce abiguity. I tried some minor edits to the grammar and it seems like this approach is easier said than done because of things like function calls without parens. This would also sacrifice the current parity between this parser and the parser in the Elixir compiler, which seems a bit distasteful to me.
The second would be to propose a change to injections upstream in tree-sitter to try to introduce a way to limit the scope of a combined injection. Currently all injections which are marked as combined globally in a document are parsed together in one "combined" sub-document. If the EEx grammar were rewritten as in this branch to group EEx tags based on start/middle-expressions and end-expressions, and then if we could combine only the tags within each group, then we wouldn't need to care about $._terminators at all. In the example above, tags one and two would be grouped and three and four grouped, but only tags one and two woud be combined with one another, and tags three and four with one another. This is nice because it mimics the EEx.Tokenizer, but it's unclear if a change like this would be accepted upstream in tree-sitter since no other language has needed anything like it.
Thirdly there's a way to fix this particular case by parsing newlines in the eex grammar and handing them over to the elixir grammar when injecting (see here) but it's not general enough to handle some odd cases, like if the example above had all four tags on the same line.
The last resort as I see it would be to rewrite the EEx grammar to depend on the Elixir grammar, so it can have fine-grained control over how expressions within EEx tags are terminated. This seems potentially brittle and certainly more of a maintenance burden, though, so I think this should be avoided if possible.
What do you think @jonatanklosko?
see also https://github.com/connorlay/tree-sitter-eex/issues/1
connects #2

This would also sacrifice the current parity between this parser and the parser in the Elixir compiler, which seems a bit distasteful to me.

There is some precedence for this in the "offlcial grammars" though:
https://github.com/tree-sitter/tree-sitter-rust/pull/70

This does permit things like raw loop labels, which are technically not allowed, but I think that's ok. In general, I prefer to err on the side of performance/simplicity rather than making sure to disallow things that the spec disallows.

@the-mikedavis thanks a lot for investigating this!
Keeping newlines for the injection conceptually sounds like a good idea, but we should focus on the most problematic cases first. I'm gonna list a few to make sure I got this right.
Case 1.
<%= foo %><%= bar %>

the Elixir code that we parse is:
foo bar

Case 2.
<%=format(x)%>: <%=format(y)%>

becomes
format(x)format(y)

Case 3.
And similarly
<%=100%><%=variable%>

becomes
100variable

Realistically speaking case 1. is the most concerning, because it's very likely to appear. And by gluing the expressions together, we would always highlight one as function and the other as the argument, which is inconsistent.
It's also possible that someone doesn't use whitespace inside EEx interpolation (cases 2. and 3.), so then it doesn't matter how strict/loose we are about whitespace/terminators, we're gonna get invalid syntax.

The idea of parsing injections in groups sounds like a good direction (assuming it would be possible upstream), however then there is a question if we can group the expressions in a robust way. I'm not sure if we can cover everything with simple checks like do/->/fn, but this may be our best shot.

This seems to be a very general topic with respect to injections, so cc-ing @maxbrunsfeld for any high-level thoughts and to validate if grouping injections seem viable.


How to expose variables inside the vendor.js?

I'm working on a program that has depended on some old code, which is rely on jQuery.
Having benefits from webpack, I was going to manage my code with that.
But, I need to expose jquery lib to global environment for making sure that old code works fun.
After seaching, also tried many times, I failed.
Plz give me some advice, Thanks

Do something like this in your entry point (pretty standard):
window.jQuery = window.$ = require 'jquery'	# expose jQuery so dependencies to window.jQuery works

@Chrazy 's solution is straight-forward.
If you don't want to include that into your entry point (because you don't want to include jQuery in your entry bundle), you can also consider using the legacy-loader with the publish-option.

Thx!


added helpHtml option for custom help icon

I've got the change to just be about the help icon.  And used the "helpHtml" option name you suggested.  Let me know how it looks.
Thanks,
--Gary

Thank you!


Example code does not execute on windows10/python38

the example copy-pasted from the doc does not compile on windows 10/python 3.8.5 via associated IDLE

@laundmo can you verify that?

would be good to know which example this is.

i was also hit with #202 since im at work right now where i didn't have lona installed.
after installing from git as recommended in #202 i can confirm this issue is happening with the basic README example lona script.

 Error, matches original report
MainThread                     ERROR    12:36:02.730760 lona.client_pre_compiler exception raised while pre compiling js client
  Traceback (most recent call last):
    File "C:\Users\laurin\AppData\Roaming\Python\Python39\site-packages\lona\client_pre_compiler.py", line 57, in compile
      template = self.jinja2_env.get_template('lona.js')
    File "C:\Users\laurin\AppData\Roaming\Python\Python39\site-packages\jinja2\environment.py", line 997, in get_template
      return self._load_template(name, globals)
    File "C:\Users\laurin\AppData\Roaming\Python\Python39\site-packages\jinja2\environment.py", line 958, in _load_template
      template = self.loader.load(self, name, self.make_globals(globals))
    File "C:\Users\laurin\AppData\Roaming\Python\Python39\site-packages\jinja2\loaders.py", line 125, in load
      source, filename, uptodate = self.get_source(environment, name)
    File "C:\Users\laurin\AppData\Roaming\Python\Python39\site-packages\jinja2\loaders.py", line 214, in get_source
      raise TemplateNotFound(template)
  jinja2.exceptions.TemplateNotFound: lona.js
Traceback (most recent call last):
  File "g:\user\laurin\restructured-imports\t.py", line 30, in <module>
    app.run(port=8080)
  File "C:\Users\laurin\AppData\Roaming\Python\Python39\site-packages\lona\app.py", line 455, in run
    self.setup_server(
  File "C:\Users\laurin\AppData\Roaming\Python\Python39\site-packages\lona\app.py", line 405, in setup_server
    self.server = LonaServer(
  File "C:\Users\laurin\AppData\Roaming\Python\Python39\site-packages\lona\server.py", line 172, in __init__
    self._static_file_loader = StaticFileLoader(self)
  File "C:\Users\laurin\AppData\Roaming\Python\Python39\site-packages\lona\static_file_loader.py", line 49, in __init__
    self.style_tags_html: str = self.server.render_template(
  File "C:\Users\laurin\AppData\Roaming\Python\Python39\site-packages\lona\server.py", line 737, in render_template
    self._templating_engine.render_template(
  File "C:\Users\laurin\AppData\Roaming\Python\Python39\site-packages\lona\templating.py", line 134, in render_template
    template = self.get_template(template_name)
  File "C:\Users\laurin\AppData\Roaming\Python\Python39\site-packages\lona\templating.py", line 104, in get_template
    template = self.jinja2_env.get_template(template_name)
  File "C:\Users\laurin\AppData\Roaming\Python\Python39\site-packages\jinja2\environment.py", line 997, in get_template
    return self._load_template(name, globals)
  File "C:\Users\laurin\AppData\Roaming\Python\Python39\site-packages\jinja2\environment.py", line 958, in _load_template
    template = self.loader.load(self, name, self.make_globals(globals))
  File "C:\Users\laurin\AppData\Roaming\Python\Python39\site-packages\jinja2\loaders.py", line 125, in load
    source, filename, uptodate = self.get_source(environment, name)
  File "C:\Users\laurin\AppData\Roaming\Python\Python39\site-packages\jinja2\loaders.py", line 214, in get_source
    raise TemplateNotFound(template)
jinja2.exceptions.TemplateNotFound: lona/style_tags.html

Hm. Sounds like another packaging problem. @laundmo could you try to find out which commit breaks the installation?

@laundmo: I am not completely sure why this happens. It looks like a packaging problem to me. I would bet on MANIFEST.in but that wasn't touched in a while. Is this maybe an artifact from the ImportError in the __init__.py i had to fix twice?

good news: this appears to be solved on 1.9 which was just released.

\o/ Then my hypothesis was right. @simcup can you verify that? In this case we can close this issue

works fine in version 1.9


chore: generalize MulEquiv.prime_iff

Also put the simpler form on the RHS and simplify the proofs that use it.

maintainer merge


tube_id should allow for a stripped leading zero

Matrix tubes use "0363147001" which may get stripped by excel. Qiita needs to account for this, and allow testing of mapping of "0363147001" first, and "363147001 as a fallback.

This is now deprecated as we removed the tube_id/specimen_id idea from Qiita: https://github.com/qiita-spots/qiita/pull/3191; and we added in the sequencing processing pipeline (the KL internal pipeline). Note that the new code also strips for leading zeros.


Add practice problems to Chapter 1 and typo fixes

Chapter 1 should be finalized now! All references/images have been updated to Quarto. Added styling for practice problems and changed prior learning check styling to NU colors. Practice problems are first draft and we can edit/change throughout the next quarter as need be.


Running JS from component file

Trying to run some JS (either using the Craft {% js %} tags or {% do view.registerJsFile ... %} and cannot get the Javascript to fire.
The Javascript code, currently, is just console.log('hi'); which doesn't appear in the console.

You cannot execute Javascript in AJAX responses as web browsers block this for security reasons. You should put any JS you need in the main template and listen for htmx events.

Thanks - I will get the hang of this soon.
I don't think the JS can go in the main template as its counting elements when the compoenent has loaded (can take a few seconds sometimes).
Will look at the htmx events - thanks 👍

If you listen for the htmx:afterSettle event, then the elements should already have been loaded into the DOM at that stage:
https://htmx.org/events/#htmx:afterSettle

Thanks! I was just looking at afterRequest with the thought that the component is checking if not sprig.request


Exclude nominated media

Description
Not showing media that have been nominated for deletion in Explore's Uploaded via mobile tab.
Fixes #2658 In "Uploaded via mobile", hide media nominated for deletion
What changes did you make and why?
Getting wikitext of media using API:Parse and filtering that have been nominated for deletion.
Tests performed
Tested betaDebug on Realme 2 pro (Android Version 8.1.0) with API level 27.

Thanks a lot for this PR @silkypriya . This Pr is requested some changes by reviewers, but seems inactive for long time.Can you inform us will you be able to do them?

Closing stale PR for now, reopen if more work happening on it.


ID Court type choice:
User feedback: bug
(court_type_selection)

Question ID
Court type choice

Details
dhg

Variable being sought
court_type_selection

Package version
playground

Filename
docassemble.playground5FeeWaiverRequest:fee_waiver_request.yml

TEST issue for testing feedback form


Improve Nix flake

See commit messages for details of the changes.
I'm running this with my config (https://github.com/malob/nixpkgs/commit/74156dd55cddb148883050598eaa7a19c370ce63) and it's working well.

I don't pretend to understand any of the nix stuff, but besides that LGTM :) Thanks for the PR!


authentication with @clerk and storing the user data into the @postgresdb using the clerk webhooks

Currently the authentication is setup with the @clerk but there is no way to persist the user data into the database

The user data should be stored into the @postgresdb using any one ORM - @Prisma or @Drizzle
For storing the notes and canvas, we can use any documentdb or nosql database like @mongodb or @cassandradb

@AnkitSeal2023 let me know your thoughts on this

Lets plan to make the whole backend by our own


Make use of webpack-cli in webpack

@sokra this is ready for a final review now. @shellscape needs to verify it doesn’t break the dev-server

Facebook aren't willing to upgrade jscodeshift to get rid of the warning ( see: https://github.com/facebook/jscodeshift/pull/198#issuecomment-304329657 )

@ev1stensberg i'll prob have a chance to check this out on 10/22 EDT. the one big thing we'll have to look for is the options validation stuff, which WDS piggybacks on.

If you've hardcoded some logic in the dev-server, the CLI has a lot of the same logic where it used to be @shellscape

@sokra any idea why the tests are failing? Might be https://github.com/webpack/webpack-cli/blob/master/bin/webpack.js#L28-L32

 weird..

@sokra Tests should run fine now, added a .nsprc to avoid breaking the build every time.

https://github.com/nodesecurity/nsp#exceptions

https://nodesecurity.io/advisories/118

@shellscape https://github.com/webpack/webpack-dev-server/pull/1163
Anything else that needs attention?

@sokra what do you wanna do about the security issue? Adding a nsprc will make the CI pass

https://twitter.com/wSokra/status/928885927803580416

https://github.com/facebook/jscodeshift/issues/229

test failure because of #5359

I'll take a look at it tomorrow and get this PR updated

@sokra  CLI re-synced with upstream branch ( next ), rebased this PR against the next branch as well. What should we do with the facebook issue?

@ev1stensberg facebook issue is in progress.
Could you update this to the next branch again?
I changed a few things in the CLI on this branch:

added a --mode argument -> mode configuration option
-p sets --mode to production
-d sets --mode to development
-p no longer defines NODE_ENV (this is now done by the mode option)
-d no longer sets the devtool (this is now done by the mode option)

fyi @sokra Got an exam period right now, so earliest would be on Wednesday

No hurry...

@sokra Could you point me to the PR this was implemented in?

https://github.com/webpack/webpack/pull/5994

@sokra CLI is resynced against the next branch again. Before merging, any potential changes to binTestCases or the /bin folder, could you also redirect them to the CLI repo, or chill them until the CLI gets merged? Avoids extra refactoring work

Before merging, any potential changes to binTestCases or the /bin folder, could you also redirect them to the CLI repo, or chill them until the CLI gets merged? Avoids extra refactoring work

I try to.

After a long fight js-codeshift was updated...
So we can merge this PR once dependencies are updated in webpack-cli resp. lockfiles in this PR.

CI build failed on yarn/cache, but I think this is ready now @sokra

Awesome ❤


Icon Component: Add width and height

Add width and height to Icon Component
Description
Use theme spaces instead of CSS for the width and height props.
Demo
Example on: https://design-system-62k3huq46-strapijs.vercel.app/?path=/docs/design-system-technical-components-icon--base
API
<Icon width={6} height={6} color="danger500" as={Trash} />

Discussion

Should these new props also allow responsive properties just like the padding props in the Box component?

Hi @MattieBelt, thank you for your addition, nice one!
I think it's a good idea too, though I would find a way to still allow custom sizing in case theme.spaces[width/height] don't exist. We have some components in Strapi using Icon with ${160 / 16}rem or ${88 / 16}rem for example.
Maybe we could check if theme.spaces[width/height] exists, if not, just passing the value as it is? @gu-stav @HichamELBSI

@ronronscelestes

Hi @MattieBelt, thank you for your addition, nice one! I think it's a good idea too, though I would find a way to still allow custom sizing in case theme.spaces[width/height] don't exist. We have some components in Strapi using Icon with ${160 / 16}rem or ${88 / 16}rem for example. Maybe we could check if theme.spaces[width/height] exists, if not, just passing the value as it is? @gu-stav @HichamELBSI

Yes I think that backwards compatibility could work out in such a way 👍🏼

What should be the default value for these fields? Would this maybe also affect components using Icon without any height or width?
@gu-stav @ronronscelestes

mmh good question! the utility of handleResponsiveValues is to allow responsive values depending on media queries we chose - is it something we want to include here thinking

Well, as the spaces in the default theme are absolute, it might be good to allow for responsive values, e.g. mobile or desktop.
But let me know WDYT?
@ronronscelestes

@HichamELBSI I think you are right, except that Box's width and height props don't allow custom and as I said previously some Icon component inside Strapi uses ${160 / 16}rem or ${88 / 16}rem for width - height props. That wouldn't mean we couldn't override it using styled components though but I don't know if it's preferable?
@MattieBelt really good question about handling responsive values for Icon, tbh I don't know if it's something that we'll need or want, I don't have a strong opinion about that. @HichamELBSI @gu-stav WDYT?

except that Box's width and height props don't allow custom

Not sure to understand, sorry. What do you mean by "custom"?

except that Box's width and height props don't allow custom

Not sure to understand, sorry. What do you mean by "custom"? @ronronscelestes You can do width={'${160 / 16}rem'} with the box. Did I miss something?

I absolutely forgot that fact, my bad! 🤦🏻♀

https://github.com/strapi/design-system/pull/582#discussion_r833112363
@MattieBelt Since it can be done with the current implementation, do you think we still need that PR?

#582 (comment)
@MattieBelt Since it can be done with the current implementation, do you think we still need that PR?

@HichamELBSI I think we need to open a PR to display the props for the components that inherit from Flex and Box it would solve the issue.


Color Codes & CodeQL/Safety

Updated _remove_color_codes method to strip "§g" ("Minecoin Gold", Bedrock Edition only), added optional flavor argument, defaulting to value "java" to match present behavior.

Hey @DJStompZone ,
thanks for the contribution, i really appreciate it.
The implementation of a regex was long over due, thanks for your help 😁
I think it would be better to move your new worflows into a different PR.
I'm just going to comment a view parts of your code, i hope you are ok with that.
Best regards,
Till

@DJStompZone Would you mind adding the new Bedrock functionallity to the 'BedrockResponse' class?

Hey @DJStompZone , thanks for the contribution, i really appreciate it. The implementation of a regex was long over due, thanks for your help 😁

You betcha!

I think it would be better to move your new worflows into a different PR.

So I'm not exceedingly fluent with the more advanced git stuff, but I think I got the workflow stuff moved out of this PR into a seperate branch, so this one should be good to go.

I'm just going to comment a view parts of your code, i hope you are ok with that.

Go for it

@DJStompZone Would you mind adding the new Bedrock functionallity to the 'BedrockResponse' class?

Sure, can we do that on a new PR though? Just to be completely honest I don't want to confuse myself with all the different commits, git isn't exactly my strongest skill 😅

@DJStompZone The PR is really messed up right now because i made some changes to files that you missed to fetch (my bad, i'm sorry). I think the best fix would be  for you to open up a new PR containing only the changes to response.py

I'm also not that good at git 😅.
Are you using github desktop?
That really helped me in the beginning

@DJStompZone The PR is really messed up right now because i made some changes to files that you missed to fetch (my bad, i'm sorry). I think the best fix would be for you to open up a new PR containing only the changes to response.py

I rebased and squashed in your changes, so I think it's good to go. It's showing no conflict, but definitely have a look and make sure your latest changes are there

Are you using github desktop?

Combination of desktop, website, and CLI depending on what I'm doing at the time. GH Desktop is definitely the most intuitive though, for sure

implemented in #17


How do I use select in  function with()

I'm sorry for the last question.
now, I have 2 model.
schedulingModel, schedulingVenueModel
             `class schedulingModel extends Model {

                    public function getSchedulingVenue() {
                         return $this->hasMany(SchedulingVenueModel::className(), ['sid' => 'id']);
                    }
             }

The following is my data acquisition methods
     function getRow () {

            $model = new SchedulingModel;
            $row     = $model->find()->with( [ 'scheduling' => function($query) { $query->select();}  ])->asArray()-all();

       }

but  the $row  is empty.
I  can't use $query->select(), i don't know why, please help me.  thanks!

Go to http://www.yiiframework.com/forum/ or https://www.facebook.com/groups/yiitalk/ for asking.


Task3

Issue: #3
bash command added

Your Task 3 output is incorrect. We require the list of files of each of the folders in the PATH environment variable.


conditional usage of q2galaxy to support build with tiny distribution

Currently trying to build the docs in a tiny distribution environmental fails because q2galaxy isn't available:
Extension error:
Could not import extension q2doc.usage (exception: No module named 'q2galaxy')
make: *** [Makefile:48: preview] Error 2

We should update this so that building usage examples for galaxy is conditional on q2galaxy being available, as this would enable faster development on the docs (no plugin pages will be built for the tiny distro, and this takes a lot of time right now).

Closing this as it doesn't make sense to solve this for the current doc builds given the impending changes to user doc building/etc.


$set missing

I noticed in version Version 0.6.0 there was a $set that returned a promise but it was removed in 1.0.0.
I am trying to write data to a specific location but the $add function also creates a key value and stores the object under that instead at the root.

profiles

uid

keyValue

email
phone

what I want to store the data is like

profiles

uid

email
phone

Why was $set removed?

See release notes and linked migration guide. https://github.com/firebase/angularfire/releases/tag/v1.0.0

You can also read through https://github.com/firebase/angularfire/issues/593 for some related discussion.

Thanks


Updated error message on AddContact.razor

The previous error message was about updating the Contact however this page was only used for adding new ones so now the message reflects that.
Follow the guidelines here as this seems more like a documentation change than a code change.

Thanks for this @ItDidntCatchFire ... Do you want to add the same update on this PR for ...

https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/3.1/blazor/samples/BlazorServerEFCoreSample/BlazorServerDbContextExample/Pages/AddContact.razor
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/6.0/blazor/samples/BlazorServerEFCoreSample/BlazorServerDbContextExample/Pages/AddContact.razor

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ItDidntCatchFire sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Oh ... the CLA ... please sign that if you agree with it's terms :point_up:.


fix: utilize EventStream.Instance for DI example

I wish EventStream was injected and not static @rogeralsing :)

Injected into what?

Well, I just mean that EventStream objects could be created and used.  The global one isn't required.
I'm probably just misusing/misunderstanding the purpose of EventStream which is why I wrote my DI example that way.

Relates to this too https://github.com/AsynkronIT/protoactor-dotnet/issues/141


Item customization

Allow the player to edit the name and description of his favorite items with dedicated tools and resource.

Item names are not modifiable, there could be a "craft rune" to show the name of author of the craft


Upload Fails : "cannot read property filename of null"

🐛 Describe the bug
Can't sync settings.  When picking "Sync Update/Upload Settings", I get a toast notification saying "Sync : Error Logged In Console (Help menu > Toggle Developer Tools)."
Looking at dev tools, I see the screenshot shown below
🌴 Visual Studio Code Version : Version 1.26.1 (1.26.1)
🌴 Code Settings Sync Version : 3.1.0
🌴 Operating System : OSX Sierra (10.12.6 (16G1510))
🌴 Occurs On: Upload
🌴 Proxy Enabled: ???
📰 To Reproduce
Steps to reproduce the behavior:

Open command pallette
Pick "Sync Update/Upload Settings"

💪 Expected behavior
It should upload successfully.
📺 Console Error Log
If applicable, add screenshots or paste the console log from developer console of VSCode.

📺  Additional context
Add any other context about the problem here.
This previously was working fine, I've been using this extension for some time now.

Same issue here

v3.1.1 released.
Please report.

Yup, seems to be fixed for me as well.  TYVM!

Just installed, getting this error. Maybe a regression?

@beck This issue was fixed.
Please open new issue with the reproducing steps with the folder file image and structure.


Add polyfill explanation with compatibility

Compatibility docs
These following components require a polyfill to be able to use on IE11, it should be added to compatibility docs: https://github.com/zeit-ui/react/issues/226, https://github.com/zeit-ui/react/pull/228
Polyfill's used:
parseInt: core-js/fn/number/parse-int
scroll: smoothscroll-polyfill
Components requiring polyfill's
https://github.com/zeit-ui/react/blob/dc68d6a77cd3b30f84aa7a182c044f82a94569bb/components/utils/color.ts#L9-L11
https://github.com/zeit-ui/react/blob/dc68d6a77cd3b30f84aa7a182c044f82a94569bb/components/shared/dropdown.tsx#L33-L34
https://github.com/zeit-ui/react/blob/dc68d6a77cd3b30f84aa7a182c044f82a94569bb/components/tooltip/tooltip-content.tsx#L48-L51

I added a new page in wiki.
All compatibility related information can now be found in the wike page. If anyone has a new point of view, please edit the wiki page.
And, huge thanks to @PaulPCIO 👍

Thanks. @unix , sorry I could not get around to do it myself, head under heals with my current project.


A/V setup options after entering scene

Just popup the av modal and re-connect to jitsi afterwards

Oops wrong issue


Can pymc be used to do bayesian Maximum Entropy (BME) research?

There is a bayesian Maximum Entropy (BME) toolbox written in matlab:
http://www.unc.edu/depts/case/BMEGUI/,
but it is hard to use,
is it difficult to do BME by pymc?
Any advice or suggestion is appreciated.

Hello @frenet, did you got an answer to your question? Not related to pymc but aare you aware of this http://bmelibpy.sourceforge.net ?


search capability added; it's in the footer and looks nice now. The styling I changed to make it look nice doesn't seem to mess with anything else on your site

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

A better option is to add a class to the form or form element (input) and then put the overriding change in the css file for that class.
For example, class could be "googletextbox":
.googletextbox {
   padding: 0.1em;
  font-size: 1em;
}

Then add the class to the HTML elements:
<input type="text" name="q" alt="search" class="googletextbox" />
    <input type="submit" value="Search my Site with Google" class="googlesearchbutton" />

You can use the same class for both or one for each as it makes sense.


[Refactor] Remove duplicate test class SimpleRowIngestionMeters

Changes:

Rename MutableRowIngestionMeters to SimpleRowIngestionMeters. This is a better name since all impls of this interface are expected to be mutable.
Remove duplicate test class SimpleRowIngestionMeters

This PR has:

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.

Including these changes in #13520 itself.


Deprecated API?

Note: C:\flutter\.pub-cache\hosted\pub.dartlang.org\move_to_background-1.0.0+1\android\src\main\java\com\sayegh\move_to_background\MoveToBackgroundPlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

Will there be an update to fix this? awesome plugin btw, I much needed this for my apps.

Thank you :D Deprecation warning should be removed in version 1.0.1


More Flexible (Better) Prompt Engineering Support

Description
Right now if you don't want to use @prompt_template you have to use the provider-specific message parameters or BaseMessageParam.
We need to make writing messages in this way (rather than as templates) more of a first-class citizen. Here are a few ideas:
Messages Return Type
I'm imagining the ability to return a more direct type rather than {"messages": ...} so that the new user does not necessarily have to learn about "dynamic configuration" in order to access custom messages.
For all of the below form factors, you could add @prompt_template so that the function returns list[BaseMessageParam]
str return type
from mirascope.core import Messages

def recommend_book(genre: str) -> Messages:
    return f"recommend a {genre} book"

print(recommend_book("fantasy"))
# > [BaseMessageParam(role='user', content='recommend a fantasy book')]

list[str] return type
from mirascope.core import Messages

def recommend_book(genre: str) -> Messages:
    return ["hello!", f"recommend a {genre} book"]

print(recommend_book("fantasy")
# > [BaseMessageParam(role='user', content=[TextPart(type='text', text='hello!'), TextPart(type='text', text='recommend a fantasy book')]

list[Message.{ROLE}] return type
from mirascope.core import Messages

def recommend_book(genre: str) -> Messages:
    return [Messages.System("You are a librarian"), Messages.User(f"recommend a {genre} book")]

type coersion in BaseMessageParam
from mirascope.core import Messages

def recommend_book(genre: str) -> Messages:
   # could wrap in list or not? both valid?
    return BaseMessageParam(role='user', content=["hello!", f"recommend a {genre} book"])

multi-modal type coercion
from mirascope.core import Messages
from PIL import Image

def recommend_book(previous_book: Image.Image) -> Messages:
    return ["I just read this book:", previous_book, "What should I read next?"]
    # return BaseMessageParam(role='user', content=["I just read this book:", previous_book, "What should I read next?"])

We should allow as much mixing/matching across all the various described conveniences as possible.

Some additional clarification.
Typing
In order to put everything under Messages, we'll need to make a minor change to the design and return Messages.Type instead:
from mirascope.core import Messages

def recommend_book(genre: str) -> Messages.Type:
    return f"recommend a {genre} book"

Possible Return Types Contained In Messages.Type
The goal is simply shorthand. Returning content of type str or Sequence[str | Image.Image | TextPart | ImagePart | AudioPart] is equivalent to writing Messages.User(content=content).
Otherwise, the user should be returning list[BaseMessageParam] where all of the role specific messages (like Messages.User are BaseMessageParam instances.
The goal of Messages.{Role} is to provide shorthand for writing BaseMessageParam where the object has content automatically converted to the correct type on construction.
You should then be able to use any call decorator with a function that returns Messages.Type or is decorated with @prompt_template (which returns list[BaseMessageParam] and is contained in Messages.Type anyway)


v1 is out of date

According to https://github.com/actions/toolkit/blob/main/docs/action-versioning.md#recommendations (point 3) it would be recommended to make v1 point to the most recent v1.x.x version. I believe the v1 in this repo is not outdated though.
For example, in https://github.com/nschloe/action-cached-lfs-checkout/blob/v1/action.yml I'm still seeing the deprecated ::set-output.
Thanks for offering this action BTW!

I believe the v1 in this repo is not outdated though.

I believe it is outdated!  As you said, [v1](https://github.com/nschloe/action-cached-lfs-checkout/releases/tag/v1) doesn't point to the same code as the latest [v1.2.1](https://github.com/nschloe/action-cached-lfs-checkout/releases/tag/v1.2.1).

Fixed.


Favor Observable.defer and AsyncSubject over Observable.create

Address #137

You're right. Sorry about that. By the way, the build is failing:

The android gradle plugin version 2.3.0-beta3 is too old, please update to the latest version.

Do you want me to bump the gradle version?

I have opened #139 to fix this! Could you please rebase this PR again master as soon as #139 get merged?

Sure!

Done!

Thanks!!!!!


Prepare for 3.6.2 release

Pull Request Test Coverage Report for Build 201

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.49%

Totals

Change from base Build 199:
0.0%

Covered Lines:
390

Relevant Lines:
392

💛  - Coveralls