Service CIDR Cannot be Changed in Auto-Scale Preview

It seems you cannot change the service cidr range in the preview. The following command:
az aks create --resource-group AKS --name aks-prod-useast2 --kubernetes-version 1.12.6 --node-vm-size Standard_B1ms --node-count 1 --service-cidr <IP_ADDRESS>/20 --dns-service-ip <IP_ADDRESS> --enable-vmss --enable-cluster-autoscaler --min-count 1 --max-count 3 --vnet-subnet-id 'myvnetid'
Always throws this error: overlaps Service Cidr <IP_ADDRESS>/16. Please choose a new Service Cidr

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 077f1bb5-2ba9-490c-2c6e-0de292266539
Version Independent ID: 0fd87b4f-88a4-c2eb-3ebc-f2b113ac203c
Content: Use the cluster autoscaler in Azure Kubernetes Service (AKS)
Content Source: articles/aks/cluster-autoscaler.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

Thanks for the feedback! We are currently investigating and will update you shortly.

@edm-ms I ran through the steps using your commands and I did not get an error
mimckitt@Azure:~$ az aks create \
   --resource-group myResourceGroup \
   --name myAKSCluster \
   --kubernetes-version 1.12.6 \
   --node-count 1 \
   --service-cidr <IP_ADDRESS>/20 \
   --dns-service-ip <IP_ADDRESS> \
   --enable-vmss \
   --enable-cluster-autoscaler \
   --min-count 1 \
   --max-count 3
The behavior of this command has been altered by the following extension: aks-preview
 - Running ..
{
  "aadProfile": null,
  "addonProfiles": null,
  "agentPoolProfiles": [
    {
      "availabilityZones": null,
      "count": 1,
      "enableAutoScaling": true,
      "maxCount": 3,
      "maxPods": 110,
      "minCount": 1,
      "name": "nodepool1",
      "orchestratorVersion": "1.12.6",
      "osDiskSizeGb": 100,
      "osType": "Linux",
      "provisioningState": "Succeeded",
      "type": "VirtualMachineScaleSets",
      "vmSize": "Standard_DS2_v2",
      "vnetSubnetId": null
    }
  ],
  "apiServerAuthorizedIpRanges": null,
  "dnsPrefix": "myAKSClust-myResourceGroup-f919aa",
  "enablePodSecurityPolicy": null,
  "enableRbac": true,
  "fqdn": "myaksclust-myresourcegroup-f919aa-a0aa80af.hcp.eastus.azmk8s.io",
  "id": "/subscriptions/XXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX/resourcegroups/myResourceGroup/providers/Microsoft.ContainerService/managedClusters/myAKSCluster",
  "kubernetesVersion": "1.12.6",
  "linuxProfile": {
    "adminUsername": "azureuser",
    "ssh": {
      "publicKeys": [
        {
          "keyData": "ssh-rsa XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"
        }
      ]
    }
  },
  "location": "eastus",
  "name": "myAKSCluster",
  "networkProfile": {
    "dnsServiceIp": "<IP_ADDRESS>",
    "dockerBridgeCidr": "<IP_ADDRESS>/16",
    "networkPlugin": "kubenet",
    "networkPolicy": null,
    "podCidr": "<IP_ADDRESS>/16",
    "serviceCidr": "<IP_ADDRESS>/16"
  },
  "nodeResourceGroup": "MC_myResourceGroup_myAKSCluster_eastus",
  "provisioningState": "Succeeded",
  "resourceGroup": "myResourceGroup",
  "servicePrincipalProfile": {
    "clientId": "XXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXX",
    "secret": null
  },
  "tags": null,
  "type": "Microsoft.ContainerService/ManagedClusters"
}

That being said, it doesn't look like it took the manual address ranges I applied. So likely a limitation of the preview like you said.
@iainfoulds @seanmck either of you know if this is supported in preview?

Thanks, so it seems like it is ignoring the commands. As a note you didn't receive the error because you didn't deploy into an existing VNET that overlaps with the default <IP_ADDRESS>/16 CIDR as it did in my VNET. It exhibited the same behavior of only creating the service CIDR as the default.

@edm-ms yeah good point. Regardless you can't have overlapping address spaces in a single Vnet so the error you got does make sense. But overall it does seem to ignore the commands regardless.

Right. It's the service CIDR that overlaps which is why I tried to change it :/

possibly related to https://github.com/Azure/azure-cli/issues/7755
Looking into it

@edm-ms I have been working offline with the AKS team on this issue. Here is what we found
As per below (working as expected). Make sure you have the latest CLI version and extension version. (Also note that the preview extension is for testing only not prod)
INPUT
az aks create -n kubenet2 -g kubenettest -k 1.12.7 --node-count 1 --network-plugin kubenet --service-cidr <IP_ADDRESS>/20 --dns-service-ip <IP_ADDRESS> --enable-vmss --enable-cluster-autoscaler --min-count 1 --max-count 3
The behavior of this command has been altered by the following extension: aks-preview
- Running ..

OUTPUT
{
  "aadProfile": null,
  "addonProfiles": null,
  "agentPoolProfiles": [
    {
      "availabilityZones": null,
      "count": 1,
      "enableAutoScaling": true,
      "maxCount": 3,
      "maxPods": 110,
      "minCount": 1,
      "name": "nodepool1",
      "orchestratorVersion": "1.12.7",
      "osDiskSizeGb": 100,
      "osType": "Linux",
      "provisioningState": "Succeeded",
      "type": "VirtualMachineScaleSets",
      "vmSize": "Standard_DS2_v2",
      "vnetSubnetId": null
    }
  ],
  "apiServerAuthorizedIpRanges": null,
  "dnsPrefix": "kubenet2-kubenettest-df4aff",
  "enablePodSecurityPolicy": false,
  "enableRbac": true,
  "fqdn": "kubenet2-kubenettest-df4aff-41a80be2.hcp.westus2.azmk8s.io",
  "id": "/subscriptions/df4aff33-3507-48d9-a24c-3439ab6b3079/resourcegroups/kubenettest/providers/Microsoft.ContainerService/managedClusters/kubenet2",
  "kubernetesVersion": "1.12.7",
  "linuxProfile": {
    "adminUsername": "azureuser",
    "ssh": {
      "publicKeys": [
        {
          "keyData": "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDSNu2Av4E43zNdWGYS/y32kWjgU3M+a/h8h9I/dYTMJ5zGBlGFnErWP59B65owXFJ7O4H+IrCT8kkCrXBC4mZCqEmZTfaxDR3521qcOzNz+RMlmCF4teJ+koffHEgFaj4+iyCLLP/acP7ifFjjkZWyh17svCEz1Au7uddGnWF2ohTnLvysi5b+thnwBVMFWOGcYZyN6fMzVGjZN21dym/1B0lJ/KS8QZSN0DA3nTZhp4niHNgXKlUtf7K0bwlbHDqYfbUzEYciP5zPVXMS0gdleDWqGgqivvX0C7lCqsdT9DVpZYIBCEwhx+9wzsWuHca3+gVipZKirSjeOFhyYU6j jpalma@aeolus\n"
        }
      ]
    }
  },
  "location": "westus2",
  "maxAgentPools": 8,
  "name": "kubenet2",
  "networkProfile": {
    "dnsServiceIp": "<IP_ADDRESS>",
    "dockerBridgeCidr": "<IP_ADDRESS>/16",
    "networkPlugin": "kubenet",
    "networkPolicy": null,
    "podCidr": "<IP_ADDRESS>/16",
    "serviceCidr": "<IP_ADDRESS>/20"
  },
  "nodeResourceGroup": "MC_kubenettest_kubenet2_westus2",
  "provisioningState": "Succeeded",
  "resourceGroup": "kubenettest",
  "servicePrincipalProfile": {
    "clientId": "ed4e262e-a639-43cb-aef6-281e8d7be6e7",
    "secret": null
  },
  "tags": null,
  "type": "Microsoft.ContainerService/ManagedClusters",
  "windowsProfile": null
}

Eg. The command
az aks create -n kubenet3 -g kubenettest -k 1.12.7 --node-count 1 --service-cidr <IP_ADDRESS>/20 --dns-service-ip <IP_ADDRESS> --enable-vmss --enable-cluster-autoscaler --min-count 1 --max-count 3
Should fail with:
Please explicitly specify the network plugin type
So it seems that modifying the CIDR does work. We just were not doing it correctly. Please review the above commands and let me know if it works for you.

Thanks, appreciate the work here. Do note that the command I used prior works without the autoscale preview so if the expected behavior is to force the network type "-n" that should be modified.
az aks create --resource-group AKS --name aks-prod-useast2 --kubernetes-version 1.12.6 --node-vm-size Standard_B2s --node-count 3 --service-cidr <IP_ADDRESS>/20 --dns-service-ip <IP_ADDRESS>  --vnet-subnet-id "/subscriptions/mysubID/resourceGroups/Networks/providers/Microsoft.Network/virtualNetworks/vnet-prod-useast2-spoke01/subnets/sub-prod-useast2-spoke01-aks" --disable-rbac

@edm-ms fair enough. At this point we have confirmed it to be working but it might be worth expanding the doc a bit to cover this specific scenario. So I will assign to the author for final review to see if it makes sense to add any info to this doc or another.

Thanks for driving the troubleshooting, @MicahMcKittrick-MSFT
While this feature is in preview, we're trying to keep the doc as straight forward as possible, so using kubenet with default ranges for the virtual network resources provided and managed by the AKS cluster. This issue will be associated with the doc at the bottom of the page for others that are trying to specify more of these parameters themselves, and can view this approach. For now, I'll leave the doc as-is.
Also, best practice would be to leave RBAC enabled in the cluster, so take care with using the --disable-rbac parameter.
#please-close

Thanks @iainfoulds that makes sense.
@edm-ms thanks for bringing this up. Having this issue opened on this doc should help people if they want to do this while the feature is still in preview.


Working set target search includes manual&no-ide targets

When "Expand Sync to Working Set" is enabled, syncing may include building targets marked as manual and no-ide. Generally syncing seems to be good at avoiding them - project directory targets are filtered out using the manual tag.
I don't think the IDE should be responsible for syncing working set targets that are only built by manual targets. This is for example used in j2cl to exclude some work-in-progress rules that are added but not used right now, causing failures when syncing targets using it.
Perhaphs the same filter for manual targets should be added to https://github.com/bazelbuild/intellij/blob/fe6d97de761903327095545d3bd4a24220800bb8/base/src/com/google/idea/blaze/base/dependencies/BlazeQuerySourceToTargetProvider.java#L101 ?

Hello @jsannemo, Could you please respond if you are still looking support on the above issue and It would be great if you can send us PR i can arrange it for review. Thanks!

Hi there! Thank you for raising this issue. We're doing a clean up of old issues and will be closing this one since it seems to have stalled. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.


Alarm control panel code dialog

Breaking changes

Minimum HA version to use Mushroom is now 2024.3
show_keypad option is no longer available for alarm control panel card

Description
Use dialog to ask code when arming and disarming. The code is only asked when needed.
Icons have been also updated to match the HA ones.

Related Issue

This PR fixes or closes issue: fixes #1291, fixes #1290, fixes #1100, fixes #1085, fixes #787
Motivation and Context

How Has This Been Tested

Types of changes

[ ] 🐛 Bug fix (non-breaking change which fixes an issue)
[x] 🚀 New feature (non-breaking change which adds functionality)
[ ] 🌎 Translation (addition or update a translation)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have tested the change locally.
[ ] I followed the steps if I add a new language .

"The code is only asked when needed."
Can you please explain what you mean with this statement? I used to be able to arm my alarm without entering a code. Now I have to enter the code and I don't see a way to disable this behaviour.

@JDSymington Which integration are you using?

@piitaya I'm using ParadoxAlarmInterface (https://github.com/ParadoxAlarmInterface/pai)

The default code behavior before was no code required but since 2024.6 it's code required. There is a dev blog article about it (https://developers.home-assistant.io/blog/2024/05/22/alarm_control_panel_validation). The custom integration needs to be updated by settings code_arm_required to False on the entity.

Thank you for pointing me in the right direction.
The solution was to enter a code in "Default code" field under HA alarm settings:

Yes it's a workaround as the integration ask for code but doesn't verify it.


Release GIL while resampling

Fixes #13.

builds and works in parallel on windows 11 cpython 3.11 👍 I only use src_simple so that's about all I can tell you. 🤷
If you push a github release when this lands, I'll be notified 🍰


Next port 2: electric boogaloo

Issues from the last port:

[x] Layout classname shuffling -- resolved by not returning different divs (#96) and a slight change to always rendering Sidebar and BottomNav
[ ] No emulators -- still present.
[ ] No firebase/analytics -- still present, see https://github.com/FirebaseExtended/reactfire/issues/530.

At the very least, the first issue was resolved and that means the app won't look like a horrible mess. This PR is somewhat mergeable even without the other two issues being fixed, and probably mergeable if the only issue left is broken emulators.

Another thing that needs to be considered before merging is hydration errors, which are full-fledged popup generating errors on dev now instead of being relegated to the console. Things like the current time context (schedule, settings/appearance) trigger this because of DateTime.now(), and we could consider not prerendering anything that relies on the current time by returning null.
The bigger issue in my opinion is the layout, which generates hydration errors when BottomNav unmounts and Sidebar mounts on client due to the screen type query. This is harder to fix, because if we prerender neither sidebar nor bottom nav, there's a flash of missing layout on reload where the sidebar or bottom nav renders in after hydration. Will need to think more about this.

Closed due to staleness. Next 13 is stable(ish) now, so a Next port should probably use app directory in the future. Also could watch for developments regarding https://firebase.google.com/docs/hosting/frameworks/nextjs


Put or Patch none of them working

Hi
I tried to update details of already subscribed user but none of them working, I tried everything using put | patch but it seems it not updating anything.

I can assure you this is due to an issue with the data itself, I use this method all the time and it works like a charm.
Show an example of the request and response and I'd be able to help more...but I don't think this is an issue with this repo.

 $api = new MCAPI($config['apiKey']); $MailChimp = new MailChimp($apikey); if($json['title'] == "Member Exists"){ 	// Already subscribed updating current info 	$subscriber_hash = $MailChimp->subscriberHash($_POST['COMPANYEMAIL']); 	$list_id = $config['listId']; 	$result = $MailChimp->patch("lists/$list_id/members/$subscriber_hash", [ 				'merge_fields' => $postData,				 			]); }

@tspesh did u checked? bec i really need help with this i was doing everything i couldn't couldn't figured it out


Convenience constructor for structural materials

Closes https://github.com/ONSAS/ONSAS.jl/issues/316

cc @jorgepz you might be interested in this type of change since it goes in the direction of making stuff under examples more user-friendly.
to conclude removal of Dictionaries on the examples, this needs https://github.com/ONSAS/ONSAS.jl/issues/367

Codecov Report

Merging #370 (666357a) into main (6c1ae71) will increase coverage by 0.01%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
+ Coverage   86.76%   86.78%   +0.01%
==========================================
  Files          43       43
  Lines        1549     1551       +2
==========================================
+ Hits         1344     1346       +2
  Misses        205      205

Impacted Files
Coverage Δ

src/StructuralModel/StructuralMaterials.jl
100.00% <100.00%> (ø)

src/StructuralModel/Structures.jl
87.27% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


How to resize bars in linePlusBarChart

Hello, I was just wondering if there is a way to resize the bars width in the graph. When there is only only one or two bars showing they can get quite wide.
Thanks in advance

Any solution for this? I'm looking for the same.


Angular-CLI-Based-Template: Appropriate way to return HTTP Status Code

@SteveSandersonMS with new Angular CLI based template what is the most appropriate way to return proper HTTP Response Code for example 404 for page not found?
For Angular part we can do something like this https://stackoverflow.com/a/46790709/2755616 but how would we grab and handle the status code passed from Angular in .Net with this new template.

@SteveSandersonMS I tried adding the below controller but it doesn't seem to work:
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Http.Features;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.NodeServices;
using Microsoft.AspNetCore.SpaServices.Prerendering;
using System.Net;
using System.Threading.Tasks;

namespace Mustakbil.Controllers
{
    public class HomeController : Controller
    {
        public async Task<IActionResult> Index([FromServices] INodeServices nodeServices, [FromServices] IHostingEnvironment hostEnv)
        {
            var applicationBasePath = hostEnv.ContentRootPath;
            var requestFeature = Request.HttpContext.Features.Get<IHttpRequestFeature>();
            var unencodedPathAndQuery = requestFeature.RawTarget;
            var unencodedAbsoluteUrl = $"{Request.Scheme}://{Request.Host}{unencodedPathAndQuery}";

            System.Threading.CancellationTokenSource cancelSource = new System.Threading.CancellationTokenSource();
            System.Threading.CancellationToken cancelToken = cancelSource.Token;

            var prerenderResult = await Prerenderer.RenderToString(
                      "/",
                      nodeServices,
                      cancelToken,
                      new JavaScriptModuleExport(applicationBasePath + "/ClientApp/dist-server/main.bundle.js"),
                      unencodedAbsoluteUrl,
                      unencodedPathAndQuery,
                      null,
                      30000,
                      Request.PathBase.ToString()
                  );

            ViewData["html"] = prerenderResult.Html;
            int statusCode = (int)prerenderResult.Globals["statusCode"];

            Response.StatusCode = statusCode > 0 ? statusCode : (int)HttpStatusCode.OK;

            return View();
        }
    }
}

@naveedahmed1
I also needed to render the html via a Controller for converting it into a pdf for a specific endpoint. I got it working by using ngAspnetCoreEngine in main.server:
ngAspnetCoreEngine requires a request object to be passed in, so need to add it to the customDataParameter:
HomeController.cs
var prerenderResult = await Prerenderer.RenderToString(
  "/",
  nodeServices,
  cancelToken,
  new JavaScriptModuleExport(applicationBasePath + "/ClientApp/dist-server/main.bundle.js"),
  unencodedAbsoluteUrl,
  unencodedPathAndQuery,
  new Dictionary<string, object>{ { "request", Request.AbstractRequestInfo()} },
  0,
  Request.PathBase.ToString());

main.server.ts
export default createServerRenderer(params => {
  const { AppServerModule, AppServerModuleNgFactory, LAZY_MODULE_MAP } = (module as any).exports;

  // Platform-server provider configuration
  const setupOptions: IEngineOptions = {
    appSelector: '<app-root></app-root>',
    ngModule: AppServerModuleNgFactory ? AppServerModuleNgFactory : AppServerModule,
    request: params,
    providers: [
      provideModuleMap(LAZY_MODULE_MAP),
      { provide: APP_BASE_HREF, useValue: params.baseUrl },
      { provide: 'BASE_URL', useValue: params.origin + params.baseUrl },
    ]
  };

  return ngAspnetCoreEngine(setupOptions).then(response => {
    return ({
      html: response.html,
      globals: response.globals
    });
  });
});

This was based off @MarkPieszak template. I don't know of any other way to fetch the prerendered html on the server. I also had to add a [Route("")] to the HomeController to bypass the spa routing.

This was a missing feature in the new SpaServices.Extensions package. Now implemented in 8ded472fe93123079ab97c9332f24460340876d2 and will be included in the next preview release and/or the final release.

Very quick, You're awesome @SteveSandersonMS . Can you please also guide what changes would be needed in main.server? Especially if the status code is coming from a service.
Would appreciate if you could please answer this over here https://stackoverflow.com/questions/47760100/angular-5-using-value-from-a-service-in-createserverrenderer

@SteveSandersonMS can you please update documentation about this feature?
Please also share the status of the template, when do you plan to release it?

Can anyone please review this approach to return status code, and share feedback:
https://stackoverflow.com/a/50937983/2755616


"Check failed" after decoding + shortest_path

I've been playing around with the recipe to get to know k2 better. I trained the model for 10 epochs and then tried to perform decoding with the following code (running everything on the CPU):

def create_G_decoding_graph(G, L):
    G = k2.arc_sort(G)
    decoding_graph = k2.intersect(G, L).invert_()
    decoding_graph = k2.add_epsilon_self_loops(decoding_graph)
    return decoding_graph

LG = create_G_decoding_graph(G, L)
LG.scores.requires_grad_(False)

acoustic_fsa = k2.DenseFsaVec(nnet_output, supervision_segments)

lattices = k2.intersect_dense_pruned(LG, acoustic_fsa, search_beam=5.0, output_beam=5.0, min_active_states=10, max_active_states=200)

best_paths = k2.fsa_algo.shortest_path(lattices, True)

# Trying to get the recognized words as strings for the first supervision segment in the batch
hyp_words = [symbol_table._id2sym[x.item()] for x in best_paths[0].aux_labels if x > 0]

This crashes with the following message + stack trace:
[F] /home/pzelasko/k2-repo/k2/csrc/array.h:Range:107 Check failed: size <= Dim() - start (32525 vs. 0)

[ Stack-Trace: ]
/home/pzelasko/k2-repo/build/lib/libk2_log.so(k2::internal::GetStackTrace()+0x38) [0x7f0cdcef8508]
/home/pzelasko/k2-repo/build/lib/libk2context.so(+0x6de0a) [0x7f0cdd437e0a]
/home/pzelasko/k2-repo/build/lib/libk2context.so(k2::Array1<int>::Range(int, int) const+0x2c7) [0x7f0cdd44ac27]
/home/pzelasko/k2-repo/build/lib/libk2context.so(k2::RaggedShape::Index(int, int, int*)+0x322) [0x7f0cdd50c5f2]
/home/pzelasko/miniconda3/envs/k2env/lib/python3.7/site-packages/_k2.cpython-37m-x86_64-linux-gnu.so(+0x673fc) [0x7f0ce24fc3fc]
/home/pzelasko/miniconda3/envs/k2env/lib/python3.7/site-packages/_k2.cpython-37m-x86_64-linux-gnu.so(+0x17c76) [0x7f0ce24acc76]
/home/pzelasko/miniconda3/envs/k2env/bin/python(_PyMethodDef_RawFastCallKeywords+0x274) [0x56379f2da914]

Some questions:

Did the decoding fail somehow, or did I construct the LG incorrectly? I was using the G.fsa.txt created by run.sh.
The decoding on the CPU consumes a lot of memory (9GB with the settings I put in here, if search_beam = 20 or even 10 it's going >20GB). Is this because all the utterances in the batch (N = 42) are being decoded simultaneously? I believe I'm using a release build.

As G contains disambiguation symbols bug L does not, we should use L_disambig.fst.txt in data/lang_nosp for L. We also need to determinize the intersection result on phones and then remove disambiguation symbols. I just wrap determinize and rm-epsilon to python this week early, will write decoding example script next week after I finish work at hand.
RE memory usage, I never call intersect_dense_pruned on CPU before, has no idea for now, maybe @danpovey can give some insights.

Wait, does G really contain disambiguation symbols? I thought they only exist in the L alphabet (as "phones") and not in the G alphabet (as "words").

You can check the end of words.txt, it should contain #0 etc.

@pzelasko here is the reason why we need #0 in G http://kaldi-asr.org/doc/graph.html#graph_disambig. @qindazhu thanks for your update, looking forward to your decoding example!

Thanks for your comment!
I don't think we committed the fix yet (@qindazhu please do!) but we
discovered, I think, a problem in the script that creates G.fst in
snowfall, that it was including the end of sentence marker </s>.
On Fri, Dec 4, 2020 at 12:42 PM Xiaohui Zhang<EMAIL_ADDRESS>wrote:

@pzelasko https://github.com/pzelasko here is the reason why we need #0
in G http://kaldi-asr.org/doc/graph.html#graph_disambig. @qindazhu
https://github.com/qindazhu thanks for your update, looking forward to
your decoding example!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/k2-fsa/snowfall/issues/31#issuecomment-738560845, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZFLOZG6HI6FJDIIL5KJBLSTBSDDANCNFSM4UFEQKZA
.

Yeah, I have removed </s> in G and I can now get determinized result of LG, but the problem I have now is:  I need to get aux_labels (i.e. word) from the determinized LG (on labels, i.e.  phones), we (@danpovey and I) suppose for arcs in Det(LG), those corresponding arcs in LG should have at most one non-epsilon aux_labels. However, I found that there may be multiple non-epsilon aux_labels for an arc in Det(L*G) (even if I have removed disambig symbols in Det(L*G) before selecting aux_labels). There must be something wrong, I need to step into it to see what happend.
Anyway, will make a PR with my lastest updates which removing </s> in G.

Fixed </s> stuff in https://github.com/k2-fsa/snowfall/pull/33/files

Thanks! Never too late to learn.


Backport "HBASE-27814 Add support for dump and process metrics servlet in REST InfoServer" to branch-2.6

Other changes:

Ensure info server stops during stop()
Extract header and footer. This would fix the log level page layout for rest web UI (See HBASE-20693)
Add hostname in the landing page instead of just port similar to other web UIs

Backports https://github.com/apache/hbase/pull/5215. Sorry for the mess-up in previous PR.
FYI @ndimiduk @bbeaudreault

Built code locally, extracted assembly, started a local cluster and started HBase REST server.

Verified the landing page has the right page title, all the tabs are visible, hostname is displayed instead of portnumber and no error in page rendering.
Verified /logLevel page is fixed with appropriate tabs, as expected and shown in HBASE-20693
Verified newly added http://localhost:9093/processRest.jsp works as expected
Verified newly added http://localhost:9093/dump page works as expected
Verified all other pages like /logs, /jmx, /conf works as before
Ran postman collection for basic CRUD test for REST at https://gist.github.com/NihalJain/7db91823bd140e41953a88eb3df56eae: All tests PASS

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.6 Compile Tests _

+1 :green_heart:
mvninstall
3m  2s
branch-2.6 passed

+1 :green_heart:
compile
0m 17s
branch-2.6 passed

+1 :green_heart:
shadedjars
5m 44s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 16s
branch-2.6 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 48s
the patch passed

+1 :green_heart:
compile
0m 17s
the patch passed

+1 :green_heart:
javac
0m 17s
the patch passed

+1 :green_heart:
shadedjars
5m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 14s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
3m 39s
hbase-rest in the patch passed.

24m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5729/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5729

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 39aad6a109f9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.6 / c8eb1843e8

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5729/1/testReport/

Max. process+thread count
1871 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5729/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  1s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.6 Compile Tests _

+1 :green_heart:
mvninstall
2m 50s
branch-2.6 passed

+1 :green_heart:
compile
0m 20s
branch-2.6 passed

+1 :green_heart:
shadedjars
5m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 19s
branch-2.6 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 25s
the patch passed

+1 :green_heart:
compile
0m 22s
the patch passed

+1 :green_heart:
javac
0m 22s
the patch passed

+1 :green_heart:
shadedjars
6m  7s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
5m  1s
hbase-rest in the patch passed.

26m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5729/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5729

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c010f1fccae8 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.6 / c8eb1843e8

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5729/1/testReport/

Max. process+thread count
1838 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5729/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.6 Compile Tests _

+1 :green_heart:
mvninstall
3m 52s
branch-2.6 passed

+1 :green_heart:
compile
0m 33s
branch-2.6 passed

+1 :green_heart:
checkstyle
0m 12s
branch-2.6 passed

+1 :green_heart:
spotless
0m 55s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 39s
branch-2.6 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 39s
the patch passed

+1 :green_heart:
compile
0m 35s
the patch passed

-0 :warning:
javac
0m 35s
hbase-rest generated 2 new + 164 unchanged - 2 fixed = 166 total (was 166)

+1 :green_heart:
checkstyle
0m 12s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 31s
Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6.

+1 :green_heart:
spotless
0m 51s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

27m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5729/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5729

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 39a6bf738fb0 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.6 / c8eb1843e8

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5729/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-rest.txt

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5729/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Hey @ndimiduk would you have some cycles to review this? Similar refactoring was also part of #5215

Ran postman collection for basic CRUD test for REST at https://gist.github.com/NihalJain/7db91823bd140e41953a88eb3df56eae: All tests PASS

Do we not have this kind of basic functional test in the suite?

Do we not have this kind of basic functional test in the suite?

I suppose we do but that must run inside minicluster. I run this by pointing to a node (local/distributed).

FYI, I don't usually request review of backport PRs, unless there's something particularly tricky/different between the master and backport changes.

Ah seems I am being extra cautious. Let me follow this approach going forward.

the diffs look basically identical

They are exactly same here.
Thanks for you review. I will merge this then.


Feature request: Test focusing decoration

Description

Hi! Thanks for making doctest. :)
I'd like to request a feature to allow developers to focus on specific tests. In doctest, the way that would work is probably using a decorator such as doctest::focus(bool = true). The purpose of focusing on tests is to have doctest only run focused tests if any of them are focused. Otherwise, run all tests as normal.
With my setup, I use doctest with entr to automatically re-compile and run the test suite whenever I save changes. This is a great setup, but often times I'm adding logging to figure out what's wrong with a specific test case and I need to deal with all the extra logs from the other test cases, too. I could comment them out, but they're split between dozens of files. With this proposed feature, I can just decorate the test(s) I want to focus on and then none of the others will run!
I know that doctest has test selectors as command-line arguments, but I'm in the code, running the tests; the tests run automatically. If I can focus on tests from the code, there's no need to switch back and forth between the editor and a terminal to restart the test runner. Not to mention having to type out the selector for the tests to run on the cmd line, especially if I want to focus on multiple, can be cumbersome.
In other languages, this is a common and excellent feature. For example, in Clojure: https://github.com/jakemcc/test-refresh#built-in-test-narrowing-test-selector
I'm really hoping you're open to this. Thanks so much for your time.

@jeaye I think this is a good feature. If you can implement that decorator and make a PR I'm sure it will be appreciated by others using your workflow as well.


For WINDOWS build!

Now extension can be compiled and loaded dynamic(shared) or static (tests 005.phpt and 006.phpt skiped because windows use backslash "" also the rest tests XFAIL-ed because error is writed in error_log)

Thanks for your contribution, @wantedxnn

tests 005.phpt and 006.phpt skiped because windows use backslash \

Are you referring to the /'s in the EXPECTF output? If that's the only problem, I think you could swap /'s for %c according to https://qa.php.net/phpt_details.php#expectf_section
Otherwise, I'd be happy to accept this as-is, although I'd like to see windows added to the build matrix in the future.

Thanks for your contribution, @wantedxnn

tests 005.phpt and 006.phpt skiped because windows use backslash \

Are you referring to the /'s in the EXPECTF output? If that's the only problem, I think you could swap /'s for %c according to https://qa.php.net/phpt_details.php#expectf_section
Otherwise, I'd be happy to accept this as-is, although I'd like to see windows added to the build matrix in the future.

Thanks for your contribution, @wantedxnn

tests 005.phpt and 006.phpt skiped because windows use backslash \

Are you referring to the /'s in the EXPECTF output? If that's the only problem, I think you could swap /'s for %c according to https://qa.php.net/phpt_details.php#expectf_section
Otherwise, I'd be happy to accept this as-is, although I'd like to see windows added to the build matrix in the future.

Fixed! used %e instead %c this will use accordingly OS the corerct separator.

@wantedxnn are you able to provide some basic instructions/docs on how to build on Windows?

Sorry for late response ...
Yes of course!
What do you want more precise to know ?

Need more details than this?
https://wiki.php.net/internals/windows/stepbystepbuild_sdk_2

If these instructions work for you, then I'm happy to just link to them. Specifically, was it this section? https://wiki.php.net/internals/windows/stepbystepbuild_sdk_2#building_pecl_extensions_with_phpize

Maby can add also github action to build extension for windows

I'd love to have this, otherwise we will accidentally break windows build in the future. I will check it out.

@wantedxnn I added windows build (it's still in my fork only). I see that it fails on 8.0 with Windows. Do you have any ideas about why? https://github.com/brettmc/opentelemetry-php-instrumentation/actions/runs/6386763764/job/17333981115
Otherwise, maybe we can just say "it works on 8.1+"

@brettmc I don't used phpize .... I have a very custom php-sdk environment because i compile almost 200 extensions (ported from Linux to windows or upgraded from php5 to php8, all deps are updated to last version also instead compiling in vs16(aka Visual studio 2019) i compile everything  in vs17( aka Visual studio 2022) I have splinted number of extension per build ( 1st build it's only php source as is building snapshot and pgo optimized with avx2 enabled 2nd build all extensions depending by other extension and 3rd build for all non dependending extensions)
But i will try in this evening to build/compile with phpize (i will need to use my artifact development pack from my top described build )

@brettmc I see already did PR for windows build action :)
Yes indeed can folow the instruction from wiki.php.net.... will compile the extension flawless :)


Vines to T&S Portal in Japes don't refresh if vines are acquired

Same applies for the Simian Spring pad in the block tower room in factory. Obtained Simian Spring from Diddy's other bonus barrel in factory and I couldn't use the pad (not just a visual glitch). Worked fine after a level reload.


On websocket close, catch private status code

Sir, Madam,
I'm using boost library, and beast library for websockets.
I need to catch private status code when the connexion is closed.
I read again and again the headers, but I don't find a way to do it.
Did I miss something?
Yours sincerely,
Julien

Call websocket::stream::reason after receiving error::closed to get the custom code:
https://www.boost.org/doc/libs/1_79_0/libs/beast/doc/html/beast/ref/boost__beast__websocket__stream/reason.html


generate node: cga occlusion: add support for inter-shape occlusion

currently, batched generation leads to artifacts when using the cga occlusion statements (touches, inside, ..) between different shapes because not all potential occlusion "sources" are in a generation batch

implemented inter-shape occlusion in the straight forward way for the moment, don't want to do any premature optimization for the moment.


Add built on monero page WIP

Could this page be too ambiguous? e.g. crypto forks of monero etc
closes #1641
Community > Built On Monero
work in progress
are the placeholders in the yml files helpful? useless? (will squash commits / remove after review)
Logo / sizes / quality are not final, just a mock up for sizing at the moment

the "pay to use" rpc seems to be getting deprecated so adding this without https://repo.getmonero.org/selene/primo for now seems OK. moneromooo has also recently stated that his focus will be on townforge (so its in active developent)
i will resolve conflicts

do i need to add the "haveno:" placeholder to the translation files? (i noticed i forgot to add it)
during rebase i noticed i had to remove:
from de.yml merchants:
intro3: (wähle die Vorlage "Händler" und fülle alle Abschnitte aus).
fr.yml
  onion: Adresse Onion (nécessite Tor)
pt-br.yml
  onion: Endereço onion (requer Tor)
sr.yml
  onion: Onion adresa (potreban Tor pretraživač)

Please remove all placeholders in the language files. Only the english file (en.yml) should be edited

ACK - i also see a "<<<<HEAD" left over in the a Chinese file


Type Specific Validation

I'm submitting a ...
[ ] bug report => search github for a similar issue or PR before submitting
[X] feature request
[ ] support request

Current behavior
In order to put in custom validation, one needs to put in a validation object in the FormlyFieldConfig, as in this example which references validators declared in the for root. It would be nice if we could put in custom validation based on options in the templateOptions and the type. I'll explain further...
Expected behavior
[N.B. part of this is motivated by the fact that we're trying to migrate over from formly for angular.js and changing the structure of how we store our forms in our database could be dangerous or require a prohibitive amount of manual work and care for our clients]
Let's say I've defined a textArea custom formly type. It might have some wrappers associated with the type and it has its own custom way it's displayed. We'd like to be able to store a number in the template options called "maxWordCount" and enforce that all textArea fields with maxWordCount of n (say n=10) are validated so that they have at most 10 words. If they have more than that, we may even want to show a message like "This field may have no more than 10 words" that depends on what's stored in the template options as well.
Minimal reproduction of the problem with instructions
I don't believe this is applicable to feature requests.
What is the motivation / use case for changing the behavior?
Part of the motivation is to have this work for our existing form JSON so that our forms stay the same for our clients who have spent a good deal of time customizing them. I also think this could be a cleaner way of storing this kind of functionality. Not having to attach all of the validators when they could be mostly inferred from the type.
Please tell us about your environment:
We develop all on Macs. Our app has historically been Angular.JS but we're updating part of it to use Angular8 and ngx-formly. We use MongoDB. I can provide more details as relevant.

Angular version: 2.0.X
I think we're on the most recent version. 8.0.3 maybe?

We support chrome, firefox, IE11. We try to support all major browsers.

I don't know that this applies as I believe this feature does not yet exist.

use custom extension which allows adjusting fields during the build step, here is an example https://stackblitz.com/edit/angular-mnkm2t


feat: remove address object and move to plain string

This is a draft PR open for comments;
Motivation;

Remove the need to create Address objects, and make the APIs that require addresses more simple, without the complexity of creating objects and dealing with them on comparisons.
Enforce the bech32 address as input by failing when the address is not in the correct format.
Looking forward fuel-core will also work with bech32 address removing the need for transformations when sending and receiving addresses.

@luizstacio Clean and smooth, but what led you to rename the Address package to Bech32? I think Address was more descriptive since bech32 is just a format that could [semantically] live under the Address nomenclature/domain.
Thanks for putting this together; it accurately illustrates the idea.

@camsjams Do your concerns still persist when considering the approach from this draft?
I'm afraid I can still be missing something from your previous comment, hence why I was looking to get some extra code snippets to help clarify any possible misunderstanding.


Roll engine b4a50d7ab192..e0b9a2bb23e4 (2 commits)

git@github.com:flutter/engine.git/compare/b4a50d7ab192...e0b9a2bb23e4
git log b4a50d7ab192..e0b9a2bb23e4 --no-merges --oneline
2019-11-09<EMAIL_ADDRESS>Change wordBoundary to take dynamic temporarily (flutter/engine#13765)
2019-11-09<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from KRali... to eq_Rz... (flutter/engine#13766)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Auto-roller completed checks. About to merge.


When request svg file without format; content-type got wrong

when we request svg image directly
what will be executed with sharp are:
const getOriginalImageCommand = new GetObjectCommand({ Bucket: S3_ORIGINAL_IMAGE_BUCKET, Key: originalImagePath });
const getOriginalImageCommandOutput = await s3Client.send(getOriginalImageCommand);

originalImageBody = getOriginalImageCommandOutput.Body.transformToByteArray();
contentType = getOriginalImageCommandOutput.ContentType;

let transformedImage = Sharp(await originalImageBody, { failOn: 'none', animated: true });
transformedImage = await transformedImage.toBuffer();

const putImageCommand = new PutObjectCommand({
    Body: transformedImage,
    Bucket: S3_TRANSFORMED_IMAGE_BUCKET,
    Key: originalImagePath + '/' + operationsPrefix,
    ContentType: contentType,
    Metadata: {
        'cache-control': TRANSFORMED_IMAGE_CACHE_TTL,
    },
})

content-type keep as "image/svg+xml" which differs from the docs

If no explicit format is set, the output format will match the input image, except SVG input which becomes PNG output.

which result a wrong image render from browser

@achrafsouk
Thank you achrafsouk.
Already used in my work; works ok

thank you, will update the code


Keyword cipher in C

💥 Proposal
Implementing keyword cipher in C. It is a form of monoalphabetic substitution. A keyword is used as the key, and it determines the letter matchings of the cipher alphabet to the plain alphabet.
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign


Added Animated Gradient border Button idea

added animated button name

Issue:

Great thank you!
@all-contributors please add @mukesh2309 for idea


Pop from empty list, crash in /webscrape

I got it by scraping this: https://ncsa-delta-doc.readthedocs-hosted.com/en/latest/index.html
Heads up a new bug:
File "/app/ai_ta_backend/web_scrape.py", line 450, in breadth_crawler
url = self.queue[depth].pop(0)
IndexError: pop from empty list
Full error:
2023-10-09 22:29:57,249:ERROR - Exception on /web-scrape [GET]

Traceback (most recent call last):

File "/opt/venv/lib/python3.8/site-packages/[flask](https://railway.app/project/214c0077-af58-4a32-a88d-64ede781eee9/logs?filter=%40service%3A14b25553-ea73-47f6-97a6-efa0fa9aa170&range=12h)/app.py", line 2190, in wsgi_app

response = self.full_dispatch_request()

File "/opt/venv/lib/python3.8/site-packages/[flask](https://railway.app/project/214c0077-af58-4a32-a88d-64ede781eee9/logs?filter=%40service%3A14b25553-ea73-47f6-97a6-efa0fa9aa170&range=12h)/app.py", line 1486, in full_dispatch_request

rv = self.handle_user_exception(e)

File "/opt/venv/lib/python3.8/site-packages/[flask](https://railway.app/project/214c0077-af58-4a32-a88d-64ede781eee9/logs?filter=%40service%3A14b25553-ea73-47f6-97a6-efa0fa9aa170&range=12h)_cors/extension.py", line 176, in wrapped_function

return cors_after_request(app.make_response(f(*args, **kwargs)))

File "/opt/venv/lib/python3.8/site-packages/[flask](https://railway.app/project/214c0077-af58-4a32-a88d-64ede781eee9/logs?filter=%40service%3A14b25553-ea73-47f6-97a6-efa0fa9aa170&range=12h)/app.py", line 1484, in full_dispatch_request

rv = self.dispatch_request()

File "/opt/venv/lib/python3.8/site-packages/[flask](https://railway.app/project/214c0077-af58-4a32-a88d-64ede781eee9/logs?filter=%40service%3A14b25553-ea73-47f6-97a6-efa0fa9aa170&range=12h)/app.py", line 1469, in dispatch_request

return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)

File "/app/ai_ta_backend/main.py", line 349, in scrape

success_fail_dict = scraper.main_crawler(url, course_name, max_urls, max_depth, timeout, stay_on_baseurl, depth_or_breadth)

File "/app/ai_ta_backend/web_scrape.py", line 532, in main_crawler

self.breadth_crawler(url=url, course_name=course_name, timeout=timeout, base_url_on=base_url_str, max_depth=max_depth)

File "/app/ai_ta_backend/web_scrape.py", line 450, in breadth_crawler

url = self.queue[depth].pop(0)

IndexError: pop from empty list

Ahh I see, I have a catch for this error now, but should we maybe create a base url input for cases like this? For example, this site might want to input this https://ncsa as the base url.

Interesting, I'm not sure I follow.
I thought this error occurred when the BaseURL didn't have any links on the page. So the input page has 0 additional links. Is that right?


net/http: CVE-2023-45289 affected versions

Go version
n/a
Output of go env in your module/workspace:
n/a

What did you do?
I have been reading the report detailing CVE-2023-45289 at https://mattermost.com/blog/patching-gos-leaky-http-clients/.
This issue has been fixed already in 1.22.1 and 1.21.8
Reading the article, this vulnerability was introduced in https://go-review.googlesource.com/c/go/+/424935 which dates JAN 23 2023.
Prior to this CL, CVE-2023-45289 would not occur because IPv6 addresses would have had square brackets around them.
What did you see happen?
When reading the CVE details at https://www.cve.org/CVERecord?id=CVE-2023-45289, it says all versions up to 1.21.8 are affected.
What did you expect to see?
I would have expected to see that versions released that do not have CL424935 merged would not be affected.
Of course I can understand that earlier versions are supported anymore so maybe it is not relevant but I would like to understand the policy that is maintained for documenting CVE affected versions.

Hi, thanks for your comment.
In the general case, it is difficult to determine exactly when a particular vulnerability is introduced, so we err on the side of caution and mark all versions before the fix as vulnerable.
In this particular case, as the article you linked mentions, part of the vulnerability affects versions before https://go-review.googlesource.com/c/go/+/424935 was committed. In addition, that commit was part of Go releases that are old enough to no longer be in our support window.
In cases where the introduced version is known to us, and is recent enough to be within the support window, we would include that in the versions list.
Hope that helps. FYI, if you ever have a further question or suggestion regarding this or another vulnerability report, you can use this issue tracker: https://github.com/golang/vulndb/issues/new/choose (select "Suggest an edit to an existing report").


Export Exponential Histogram to Managed Prometheus doesn't work due to unimplemented naming convertion

The Google Managed Prometheus naming doesn't support the pmetric.MetricTypeExponentialHistogram; this makes the export of Exponential Histograms fail.
https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/21602689459a185ee389b4ea871b392de5a010ef/exporter/collector/googlemanagedprometheus/naming.go#L54
I think adding the following will fix the issue. But I don't know what the correct Suffix would be.
	case pmetric.MetricTypeExponentialHistogram:
		return compliantName + "/???", nil

Thanks @alexvanboxel.  We are aware of this, and are coordinating with the Google Managed Prometheus team on adding support for exponential histograms.

I got it working locally; I've added the above code with /distribution and it works... at least for so far as I see (I can see something in Metrics Explorer. Need more exploration.

It should work just fine with the regular metrics viewer.  I don't believe it will work with promQL yet.

the GMP team has said that they plan to use the /histogram suffix we already use for regular histograms


Cut v2.22.1

This cherry-picks #8061 and #8104, and cuts the v2.22.1 release.
@roidelapluie @brian-brazil @juliusv @gouthamve @codesome @bwplotka @beorn7 @simonpasquier

Do you want #8139? Since 2.19 size based retention is not working.

I'm not in a hurry. If you think it'll get in soon, I'm happy to wait.

I'm not in a hurry. If you think it'll get in soon, I'm happy to wait.

It should be in today. Thanks!

#8139 is now merged

I opened #8147 with the cherry-pick as it is not straightforward

@brian-brazil @roidelapluie @codesome you all still ok with moving forward with this? I added the new changelog item from https://github.com/prometheus/prometheus/pull/8147.

The code looks okay, my changelog comment above hasn't been fully responded to.

@brian-brazil thanks for pointing that out, I missed your reply to the comment.

:+1:


Patch Issue on group update, ComplexValue is not JSON serializable

Description
Getting error message
TypeError: Object of type ComplexValue is not JSON serializable
am on 0.12 version of the sdk
Reproduction
relevant code for patch op as below . iterates over items to be patched and submits patch in chunks of 20
def dbx_patch_groups(client: AccountClient|WorkspaceClient,
group:Group,
attr:str,
op:str,
items: Optional[List[ComplexValue]] = None,
chunk:int=20
):
if items :
for i in range(0,len(items),chunk):
client.groups.patch(group.id,
operations=[iam.Patch(op=op,path=attr,value=items[i:chunk])],
schemas=[iam.PatchSchema.URN_IETF_PARAMS_SCIM_API_MESSAGES_2_0_PATCH_OP]
)
Expected behavior
update operation works with exactly same operation, but patch gives error above.
Is it a regression?
0.12
Debug Logs
    client.groups.patch(group.id,   File "/Users/iph270/work/saas-terraform-config/dbx/lib/python3.10/site-packages/databricks/sdk/service/iam.py", line 1939, in patch     self._api.do('PATCH', f'/api/2.0/preview/scim/v2/Groups/{id}', body=body, headers=headers)   File "/Users/iph270/work/saas-terraform-config/dbx/lib/python3.10/site-packages/databricks/sdk/core.py", line 1110, in do     return retryable(self._perform)(method,   File "/Users/iph270/work/saas-terraform-config/dbx/lib/python3.10/site-packages/databricks/sdk/retries.py", line 47, in wrapper     raise err   File "/Users/iph270/work/saas-terraform-config/dbx/lib/python3.10/site-packages/databricks/sdk/retries.py", line 29, in wrapper     return func(*args, **kwargs)   File "/Users/iph270/work/saas-terraform-config/dbx/lib/python3.10/site-packages/databricks/sdk/core.py", line 1188, in _perform     response = self._session.request(method,   File "/Users/iph270/work/saas-terraform-config/dbx/lib/python3.10/site-packages/requests/sessions.py", line 575, in request     prep = self.prepare_request(req)   File "/Users/iph270/work/saas-terraform-config/dbx/lib/python3.10/site-packages/requests/sessions.py", line 486, in prepare_request     p.prepare(   File "/Users/iph270/work/saas-terraform-config/dbx/lib/python3.10/site-packages/requests/models.py", line 371, in prepare     self.prepare_body(data, files, json)   File "/Users/iph270/work/saas-terraform-config/dbx/lib/python3.10/site-packages/requests/models.py", line 511, in prepare_body     body = complexjson.dumps(json, allow_nan=False)   File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/json/__init__.py", line 238, in dumps     **kw).encode(obj)   File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/json/encoder.py", line 199, in encode     chunks = self.iterencode(o, _one_shot=True)   File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/json/encoder.py", line 257, in iterencode     return _iterencode(o, 0)   File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/json/encoder.py", line 179, in default     raise TypeError(f'Object of type {o.__class__.__name__} ' TypeError: Object of type ComplexValue is not JSON serializable
Other Information

OS: macOS

Additional context
Add any other context about the problem here.

@bajju31 thank you for reporting this! To workaround this issue, can you try changing items[i:chunk] to [x.as_dict() for x in items[i:chunk]]`?


Use physical keys for numpad emulation in the 3D editor

3.x version of https://github.com/godotengine/godot/pull/58024.
This makes numpad emulation work on non-QWERTY keyboard layouts more reliably. Tested on Linux with an AZERTY keyboard layout (fr-oss).

Thanks!


websockets.exceptions.ConnectionClosed: WebSocket connection is closed: code = 1006 (connection closed abnormally [internal]), no reason

16:15:23 24-02-2019, CRITICAL [bittrex.py:bittrex:run_blocking:135] Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/websockets/protocol.py", line 674, in transfer_data
message = yield from self.read_message()
File "/usr/local/lib/python3.7/site-packages/websockets/protocol.py", line 742, in read_message
frame = yield from self.read_data_frame(max_size=self.max_size)
File "/usr/local/lib/python3.7/site-packages/websockets/protocol.py", line 815, in read_data_frame
frame = yield from self.read_frame(max_size)
File "/usr/local/lib/python3.7/site-packages/websockets/protocol.py", line 884, in read_frame
extensions=self.extensions,
File "/usr/local/lib/python3.7/site-packages/websockets/framing.py", line 99, in read
data = yield from reader(2)
File "/usr/local/lib/python3.7/asyncio/streams.py", line 679, in readexactly
await self._wait_for_data('readexactly')
File "/usr/local/lib/python3.7/asyncio/streams.py", line 473, in _wait_for_data
await self._waiter
concurrent.futures._base.CancelledError
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/code/data_api/bittrex.py", line 133, in run_blocking
self.run()
File "/code/data_api/bittrex.py", line 128, in run
connection.start()
File "/usr/local/lib/python3.7/site-packages/signalr_aio/_connection.py", line 36, in start
self.__transport.start()
File "/usr/local/lib/python3.7/site-packages/signalr_aio/transports/_transport.py", line 47, in start
self.ws_loop.run_until_complete(self.socket(self.ws_loop))
File "/usr/local/lib/python3.7/asyncio/base_events.py", line 584, in run_until_complete
return future.result()
File "/usr/local/lib/python3.7/site-packages/signalr_aio/transports/_transport.py", line 61, in socket
await self.handler(self.ws)
File "/usr/local/lib/python3.7/site-packages/signalr_aio/transports/_transport.py", line 70, in handler
loop=self.ws_loop, return_exceptions=False)
File "/usr/local/lib/python3.7/site-packages/signalr_aio/transports/_transport.py", line 77, in consumer_handler
message = await ws.recv()
File "/usr/local/lib/python3.7/site-packages/websockets/protocol.py", line 434, in recv
yield from self.ensure_open()
File "/usr/local/lib/python3.7/site-packages/websockets/protocol.py", line 658, in ensure_open
) from self.transfer_data_exc
websockets.exceptions.ConnectionClosed: WebSocket connection is closed: code = 1006 (connection closed abnormally [internal]), no reason

Seems to throw that out of the blue. Not sure why.

This seems to be fixed by downgrading to websockets 6.0 from 7.0


parsing string with NumberFormatter results in nil on Linux

Describe the bug
NumberFormatter.number(from:) is nil on Linux, but works fine on macOS.
Steps To Reproduce
Steps to reproduce the behavior:

create a string with a number value (e.g. "1,500.50")
create NumberFormatter with style set to currency and currency number set to empty.
use NumberFormatter.number(from:) and try to use the unwrapped value

Expected behavior
I expect to be able to get a string parsed to value, like I can on macOS, that can be obtained via the doubleValue property.
Environment (please fill out the following information)
Fedora 36 and Devuan Beowulf (equivalent to Ubuntu 18.04)
Swift 5.6 toolchain.
Locale: en_US.UTF-8

CC: @parkera


Unable to integrate it with react native

tried to integrate the face api in react native but tfjs-image-recognition is in fs format. is there any way to resolve issue. Really need help as this is a school project . Thanks

What is a fs format? Can describe the issue more precisely?

when i did a npm i face-api.js and did an import * as faceapi from 'face-api.js', it throw me an error

when i did an npm i face-api.js and import * as faceapi from 'face-api.js' into my page , it threw me an error fs module does not exist in module haste map
Did a check online and found the tjfs image recognition which is in fs format can only be work in web browser.
So im wondering is that anyway I can solve this error and make it run on mobile? I really need help on these issues . thanks.

Did a check online and found the tjfs image recognition which is in fs format can only be work in web browser.

I am maintaing tfjs-image-recognition base, but I still don't know what "fs format" should be. A more detailed error message would be helpful.

Just a quick ask is it possible for faceapi to be used on react native currently?

I suspect this maybe where the error come from since react native cannot read 'fs' file format

I too am facing the same problem in React-Native
I have installed face-api.js and then imported it as import * as faceapi from 'face-api.js';
Then I get the following errors
 bundling failed: Error: Unable to resolve module `fs` from `node_modules/tfjs-image-recognition-base/build/commonjs/env/createFileSystem.js`: fs could not be found within the project.

If you are sure the module exists, try these steps:
 1. Clear watchman watches: watchman watch-del-all
 2. Delete node_modules: rm -rf node_modules and run yarn install
 3. Reset Metro's cache: yarn start --reset-cache
 4. Remove the cache: rm -rf /tmp/metro-*
    at ModuleResolver.resolveDependency (/root/React-native/faceapi/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:186:15)
    at ResolutionRequest.resolveDependency (/root/React-native/faceapi/node_modules/metro/src/node-haste/DependencyGraph/ResolutionRequest.js:52:18)
    at DependencyGraph.resolveDependency (/root/React-native/faceapi/node_modules/metro/src/node-haste/DependencyGraph.js:282:16)
    at Object.resolve (/root/React-native/faceapi/node_modules/metro/src/lib/transformHelpers.js:267:42)
    at /root/React-native/faceapi/node_modules/metro/src/DeltaBundler/traverseDependencies.js:426:31
    at Array.map (<anonymous>)
    at resolveDependencies (/root/React-native/faceapi/node_modules/metro/src/DeltaBundler/traverseDependencies.js:423:18)
    at /root/React-native/faceapi/node_modules/metro/src/DeltaBundler/traverseDependencies.js:275:33
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/root/React-native/faceapi/node_modules/metro/src/DeltaBundler/traverseDependencies.js:87:24)

Hi @sedaplaksa @wulforr,
It could very much be possible that tfjs-image-recognition-base is currently incompatible with React Native...
Node is only used by the packager to serve/compile your app bundle; in other words, React Native apps don't run in the node environment.
"fs" stands for file system, and in order to access it in React Native, you would have to use something like react-native-fs or rn-nodeify in order to bridge and talk to each platform's native APIs (the iOS/Android platforms, in this case). If you could find a way to integrate these into tfjs-image-recognition-base for your specific app use-case, then it should work.
@justadudewhohacks please correct me if I'm wrong in anything that I've stated above.

I think its posible fix, you add 'fs empty' in webpack and create custom fetch in faceapi.env.monkeyPatch, but i dont know if this working in react-native

Hi @sedaplaksa @wulforr,
It could very much be possible that tfjs-image-recognition-base is currently incompatible with React Native...
Node is only used by the packager to serve/compile your app bundle; in other words, React Native apps don't run in the node environment.
"fs" stands for file system, and in order to access it in React Native, you would have to use something like react-native-fs or rn-nodeify in order to bridge and talk to each platform's native APIs (the iOS/Android platforms, in this case). If you could find a way to integrate these into tfjs-image-recognition-base for your specific app use-case, then it should work.
@justadudewhohacks please correct me if I'm wrong in anything that I've stated above.

i tried this method but it still did not work sadly  :(

Hi does anyone have any other different solutions? Or is it just not compatible at the moment ?

Well i removed face-api from react native and used it in node and sent my request from react native to node.

Do u mind sharing with me how u did it? Is there any latency during detection ?

Hi guys, @wulforr can you give more details of you solution, im  with the same problem, but i can turn it to server-side, i have to solve this issue on mobile app.

Did anyone try integrate face api with this adapterhttps://github.com/tensorflow/tfjs/tree/master/tfjs-react-native?

Did anyone try integrate face api with this adapter?https://github.com/tensorflow/tfjs/tree/master/tfjs-react-native

@artem-kushal may be one way to do this work, i didn't konw tfjs-react-native, i will try use it, please comment bellow if you got success...

Hi guys, @wulforr can you give more details of you solution, im with the same problem, but i can turn it to server-side, i have to solve this issue on mobile app.

Sure @deividsoncs,
I used face-api.js to find similarities between two images. I had images stored in the database and sent my image from mobile app to server.
In server this image is compared to all the images in the database.
If you wanna know more or anything in specific do let me know.

Hi guys, @wulforr can you give more details of you solution, im with the same problem, but i can turn it to server-side, i have to solve this issue on mobile app.

Sure @deividsoncs,
I used face-api.js to find similarities between two images. I had images stored in the database and sent my image from mobile app to server.
In server this image is compared to all the images in the database.
If you wanna know more or anything in specific do let me know.

Thanks @wulforr , but my problem is that a have to solve in a mobile app to send only the features extracted from the image captured in a mobile camera, because the image is taking so long time to uploado to the servers, im live at Brazil and the mobile internet connection is so slow in many places here. So, i wish do this at app, could you help on this?

Hi guys, @wulforr can you give more details of you solution, im with the same problem, but i can turn it to server-side, i have to solve this issue on mobile app.

Sure @deividsoncs,
I used face-api.js to find similarities between two images. I had images stored in the database and sent my image from mobile app to server.
In server this image is compared to all the images in the database.
If you wanna know more or anything in specific do let me know.

Hi @wulforr, by any chance is your repo of this project public, if yes can you please tell me the name to check it out, I have been looking for examples of how to use face-api.js and I'm a little confused, thank you

I assume the library can be implemented in a react native webview

If anyone manage to make face-api work with react-native, please share your solution.
I'm trying to figure out as well.

use https://www.npmjs.com/package/react-native-fs instead of fs

@yasahmed have you got face-api.js to work with react native ? can you post an example ?

as said before, you can use https://www.npmjs.com/package/react-native-fs instead of fs, but it's not enough.
you'll need to install https://www.npmjs.com/package/@tensorflow/tfjs-react-native.
use faceapi.setEnv to initialize, face-api is excpecting an Environment interface
{
  Canvas: typeof HTMLCanvasElement
  CanvasRenderingContext2D: typeof CanvasRenderingContext2D
  Image: typeof HTMLImageElement
  ImageData: typeof ImageData
  Video: typeof HTMLVideoElement
  createCanvasElement: () => HTMLCanvasElement
  createImageElement: () => HTMLImageElement
  fetch: (url: string, init?: RequestInit) => Promise<Response>
}

I was using react-native-canvas for the canvas elements
here is a partial implementation
var RNFS = require('react-native-fs');
import Canvas, {
  Image,
  ImageData,
  CanvasRenderingContext2D,
} from 'react-native-canvas';
import * as faceapi from 'face-api';
import { cameraWithTensors } from '@tensorflow/tfjs-react-native';
import { Camera } from 'expo-camera';
const TensorCamera = cameraWithTensors(Camera);

const createCanvasElement = function () {
  if (Canvas) {
    return new Canvas();
  }
  throw new Error(
    'createCanvasElement - missing Canvas implementation for RN environment',
  );
};

const createImageElement = function () {
  if (Image) {
    return new Image();
  }
  throw new Error(
    'createImageElement - missing Image implementation for RN environment',
  );
};

const readFile = function (filePath: string) {
  try {
    return RNFS.readFile(filePath);
  } catch (e) {
    console.error('error reading file', e);
  }
};

const fileSystem = {
  readFile,
};

const _fetch =
  fetch ||
  function () {
    throw new Error(
      'fetch - missing fetch implementation for browser environment',
    );
  };

 let env = {
    Canvas: Canvas,
    CanvasRenderingContext2D: CanvasRenderingContext2D,
    Image: Image,
    ImageData: ImageData,
    Video: TensorCamera,
    createCanvasElement,
    createImageElement,
    fetch: _fetch,
    ...fileSystem,
  };

  faceapi.env.setEnv(env);

for loading the models i uploaded them to external storage (AWS S3)
and used  await faceapi.nets.tinyFaceDetector.loadFromUri('https://your-bucket-urls3.amazonaws.com/models');
and I used this example to get a proper input that I can pass to the faceDetector: https://github.com/tensorflow/tfjs/blob/master/tfjs-react-native/integration_rn59/components/webcam/realtime_demo.tsx
Everything haw worked without any errors but I couldn't get any results, also the detection process was very slow compared to web browser.
Good Luck, and please let us know if you have any breakthrough

@0xori im trying to do step that you mention, but im still getting error, did u manage to finish that code ?

I am facing the same issue. But somehow I managed to run the application without any errors up to the detection process following @0xori instruction except for the "expo-camera" I used "react-native-camera". But when I pass the camera ref  as a parameter to the faceapi.detectSingleFace() function, I'm getting the following error; media.addEventListener("load", "onLoad") is not a function!

Is there anybody having the solution for using face-api.js in RN ? I am trying to  use some solutions above but it seems not to work TT

Has anyone by chance managed to integrate face-api.js with RN? Any help will be welcome. Thanks in advance

Hello, I've also been facing difficulties to use face-api.js with React Native (RN).
Here's my question:
Is it possible to use POST and GET with face-api.js and React Native? For example: taking two photos with 'expo-camera' (RN) and making posts to face-api.js for the 'Face Recognition' model to determine if there is the same person in both images or not. Thanks for any help

@GuihMatos that would be handy as well, I just don't think they have a REST api set up at the moment :(.
I would need to use this API for video chat detection, so I think making my own node.js server is not an acceptable solution because of latency.
Please if anyone solves this could you please create a fork and share it? I will do the same if I find the solution first
Cheers :)

So, I managed to get this library running with react-native, using react native tensorflow. This was a major, major pain to set up and get running. And, when run in debug mode, everything works fine: faces are detected, features are extracted in such a way that they can be compared to each other to find matching faces.
However, when switching to release mode, the model breaks, that is to say: everything appears to run ok, but the face-detection module always comes back that it can't find any faces. upon further investigation, I found that the tensor values start to diverge during the calculations in the function mobileNetV1(x: tf.Tensor4D, params: MobileNetV1.Params) when this loop is executed: convPairParams.forEach((param, i). When i=3, calculations start to differ between debug and release mode. I don't yet know why exactly this is. I am currently thinking that it might have something to do with how the weights are loaded:
       const modelJson = require('../models/ssd_mobilenetv1/ssd_mobilenetv1_model-weights_manifest.json');
        let modelWeights1 = require('../models/ssd_mobilenetv1/ssd_mobilenetv1_model-shard1.bin');
        let modelWeights2 = require('../models/ssd_mobilenetv1/ssd_mobilenetv1_model-shard2.bin');

        let assetPath = Image.resolveAssetSource(modelWeights1);
        let response = await fetch(assetPath.uri, {}, { isBinary: true });
        const weights1 = await response.arrayBuffer();

        assetPath = Image.resolveAssetSource(modelWeights2);
        let response2 = await fetch(assetPath.uri, {}, { isBinary: true });
        const weights2 = await response2.arrayBuffer();

        const fetchWeightsFromDisk = (filePaths) => {
            console.log(filePaths);
            //console.log([...new Uint8Array(weights2.slice(0, 100))]);
            return Promise.resolve([weights1, weights2])
        }
        const loadWeights = tf.io.weightsLoaderFactory(fetchWeightsFromDisk);
        const weightMap = await loadWeights(modelJson, "");

maybe some byte mis-alignment?  Does anybody have any idea?
So, I tried to make a fresh conversion from the old pb file, which worked almost, except for the 'NonMaxSuppression' operator.
Does anybody here know how to modify the operators 'on the fly' after loading the model?

Hi @jan-bogaerts
I tried to integrate Face-api using react native tensorflow without success. Do you mind to share your implementation? Any help will be useful. Thanks

@vagnerpene https://github.com/jan-bogaerts/face-api.js
not much of a point though, it doesn't work in production mode, but does in debug mode. When the model gets executed on the device itself, there appears to be something going different.

I will use this library for face similarity and after reading the comments I decided to use webview. I wonder if the library works smoothly in webview?


Character-counter spans being added to Checkboxes / Radio Buttons?

Expected Behavior

character-counter spans should only be added to text fields with a length attribute.
Current Behavior

character-counter spans are being added to checkboxes/radio buttons.
Possible Solution

Steps to Reproduce (for bugs)
I have this HTML:

			Gender

			<input type="radio" name="Gender" value="Male" id="Male">
			Male (44)

			<input type="radio" name="Gender" value="Female" id="Female">
			Female (23)

			<input type="radio" name="Gender" value="All" checked="checked" id="allMaleAndFemale">
			All

When I run materialize via:
	<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/materialize/1.0.0/css/materialize.min.css"/>

...it adds character-counter spans as seen here:

			Gender

			<input type="radio" name="Gender" value="Male" id="Male">
			Male (44)
			4

			<input type="radio" name="Gender" value="Female" id="Female">
			Female (23)

			<input type="radio" name="Gender" value="All" checked="checked" id="allMaleAndFemale">
			All

Context

Character count fields are being inserted where they are not needed.
Your Environment

Version used: 1.0.0
Browser Name and version: Chrome Version 92.0.4515.159 (Official Build) (x86_64)
Operating System and version (desktop or mobile): Mac OS X 11.5.2

I noticed that it's better to use data-length as a selector for initialization:
var inputsWithCount = document.querySelectorAll('input[data-length]')
M.CharacterCounter.init(inputsWithCount)

Then the counter is applied only to the needed fields.


passes even if instructions not followed

Challenge http://freecodecamp.com/challenges/waypoint-nest-an-anchor-element-within-a-paragraph has an issue. Please describe how to reproduce it, and include links to screenshots if possible.
instruction mentions rest of paragraph text to be plain
correct  :
click here for cat photos

However,this works as well:

click here for cat photos

Hey @smarshy thanks for posting this!
Confirmed!


menu view is black in latest iOS

hit any menu button and the menu view shows just black.
Issue seen in iOS 14.3, iPhone X.
Works fine in iOS 13, iPhone 8.

Did you ever find a fix for this?


Add a persistent state option

It could be handy for state to persist in local storage. This is especially true for small, PWAs.
Todos

[ ] Add constructor parameter
[ ] Feature detect that storage is available
[ ] Hydrate from local storage on instantiation if enabled
[ ] Self-subscribe to changes and automatically update storage
[ ] Add clear method if the local storage needs clearing for some reason

This would be a nice feature

Hi, thanks for the great library. Has this persistent state enhancement been considered ?
I am working on a similar feature. The only piece I am missing is to identify which property of the state triggered the change to avoid having to save the whole state object at every update. Any ideas ?


Carousel design broken

Bug Description
There's no spacing anymore between pages in the bottom carousel, and the active state also seems broken.
This does not match the design on Figma.
Related: #234
Screenshots
Actual:

Expected:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

Carousel navigation (and design, see arrow and grid view icon clash) is also not aligned with the spec, should we include this work here?

@merapi Navigation behavior is handled by #311 . This issue here is for fixing the design of the carousel—that includes the navigation design.

Regarding the active state:
From my research, it's best not to use outline for this (as we currently use), by utilizing border we can skip all issues listed below.
Current code (const Page = styled.button) is not working on Chrome, Firefox/Safari is fine with that.
If we change it to const Page = styled.div it's working everywhere, but we lose some a11y.
If we try to bring back some a11y with const Page = styled.div.attrs({ role: 'button', tabIndex: 0 }) it breaks in Chrome.
As per Figma, we should also remove :hover.

I also saw https://github.com/google/web-stories-wp/issues/10 and I'm not sure if we have that functionality described somewhere? probably we will need some state indicating the page being moved. If we use border to indicate active state then we can utilize outline for that.
That's how it works with border and native outline:
https://share.getcloudapp.com/WnuNEPO2

Current code (const Page = styled.button) is not working on Chrome, Firefox/Safari is fine with that.
If we try to bring back some a11y with const Page = styled.div.attrs({ role: 'button', tabIndex: 0 }) it breaks in Chrome.

How does either approach break in Chrome? Can you push a branch with this?
I think a <li/> with a role="option" (and the parent then an <ul/> with role="listbox") or tab (and tabpanel) seems semantically sound.

How does either approach break in Chrome? Can you push a branch with this?

.button (current code on master) and .div.attrs will result in such result in Chrome (only):
(issue occurs when you click on Page thumbnail - it doesn't stay selected, the first part with arrows navigation is ok)
https://share.getcloudapp.com/ApurrK8g
Does it work for you otherwise?

How does either approach break in Chrome? Can you push a branch with this?

.button (current code on master) and .div.attrs will result in such result in Chrome (only):
(issue occurs when you click on Page thumbnail - it doesn't stay selected, the first part with arrows navigation is ok)

Ah, because an unfocused button has outline: none in Chrome always somehow, which overrides the CSS for it. Yes, convert to a border as suggested - don't sacrifice semantics for styling.

Just wanted to point out that, at least visibly, Figma specifies outline for the selected page thumbnails - it's clearly outside the boundary of the thumbnail. Performance-wise, if we set/unset the border, we will also force relayout each time. Alternative to this would be to always set border and only manipulate it's transparency. This is somewhat of a dangerous path. I usually prefer outlines where outlines are called for.

@dvoytenko but when this clashes with semantics, I say we go for border. And button's (or button-like elements) clearly can't use outline in Chrome due to conflicting uses.
We can just toggle the border color between the bg.v1 used by the canvas background and the active color. That will have very limited performance impact. Would that be an acceptable solution?

@barklund @merapi if we see border semantically more appropriate here - then certainly. And, yes, we should proceed with the transparent/selection border color in that case. However, if it's an issue with the keyboard-only-outlines - I'd rather we disabled it for now. We do use pointer-events:none heavily and it'd probably be only more so. So if there's some inherent incompatibility, we'll run into it again somewhere.

Sounds like we'd want to keep an eye on @moxystudio/js-keyboard-only-outlines. I'll create an issue to track this so it's not forgotten.
For now, let's go with the border and listbox option.


Installs failing due to EEXIST error

I'm having several users reporting errors like this:
npm ERR! System Linux 3.13.0-43-generic
npm ERR! command "/home/forge/.nvm/v0.10.36/bin/node" "/home/forge/.nvm/v0.10.36/bin/npm" "install"
npm ERR! cwd /home/forge/xxxxx.com/web/app/themes/xxxxx
npm ERR! node -v v0.10.36
npm ERR! npm -v 1.4.28
npm ERR! path /home/forge/.npm/e55268eb-pm-source-map-0-1-43-package-tgz.lock
npm ERR! code EEXIST
npm ERR! errno 47
npm ERR! not ok code 0

In addition:
http://discourse.roots.io/t/npm-issues-with-gulp-branch/2848
I get this error occasionally on travis as well. Perhaps there is some sort of race condition here?

Shoot. Looks like this might be related: https://github.com/npm/npm/issues/6309

Do npm update -g npm.

Yeah race conditions with npm 1.2.28. Too bad we won't get npm 2.0.0 until 0.11. Till then just recommending users npm install -g npm@latest


Document routing syntax

I took a first stab at #18.
Some items for discussion:

I suggest we consistently use one of the terms "component" or "segment" for the "/"-separated parts of a URL path; currently both are used in lib.rs and other places; Akka HTTP uses "segment" which I also prefer
~The doc fist test (around line 33) fails: "help: add #![feature(async_await)] to the crate attributes to enable"; but these are enabled, what to do?~
How can I refer from one at method (in "app.rs") to another one (in "router.rs")? Is the way I did it correct?

This looks great, thank you so much!

Thanks for the quick merge, @aturon. Actually I had some questions I wrote in a comment above. I'll open an new PR for renaming component to segment.


make parser trace more readable to humans

Make this output more useful:

--- Parsing  /surveys/kitchen_sink_survey.rb  ---

survey survey_section question question_1 answer answer answer answer answer question_2 answer_1 answer_2 answer_3 answer_4 answer question_2a answer_1 dependency dependency_condition_A dependency_condition_B dependency_condition_C dependency_condition_D question_2b answer_1 dependency dependency_condition_Z question_montypython3 answer_1 question_montypython4 answer_1 dependency dependency_condition_A question_montypython5 answer_1 dependency dependency_condition_A question dependency dependency_condition_A question answer answer answer question answer validation validation_condition_A question answer validation validation_condition_A question answer question_time_lunch answer_1 question answer question answer answer answer answer answer answer answer answer answer answer question answer answer answer answer answer question answer question_group question answer question answer answer answer question answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer answer question answer answer answer answer answer answer question answer answer answer answer survey_section question_group answer answer answer question question question question_group answer answer answer answer answer question question question question_group answer answer answer answer answer question question question question question question question question question answer answer answer answer answer question answer answer answer answer question_car answer_y answer_n question_group dependency dependency_condition_A question answer answer answer answer answer answer answer question answer question answer question_group question answer answer
found question:2 found answer:1 found question:2 found answer:2 found question:2 found answer:3 found question:2 found answer:4 found question:2 lost! answer: found question:montypython3 found answer:1 found question:montypython4 found answer:1 found question:montypython5 found answer:1 found question:car found answer:y saved.
--- Done /surveys/kitchen_sink_survey.rb ---

How about something like:
--- Parsing  /surveys/kitchen_sink_survey.rb  ---
Survey (name)
  section (name)
    question
      answer
    question
      answer
      answer
      answer
   section
     question
     answer
Parser has died...

--- Error ---
etc...

I agree with @normalocity's indentation suggestion for overall structure. I'd also dump name or abbreviated text for each node (not just for survey and section), reference identifier (where available), and line number. See aker's deprecation module for an example of how to extract the line number from which a method was called.
I'd also suggest providing all that information (current node type, name if applicable, line number) when there's an unexpected exception in the parser, even if trace is off.


Android build failed

Gradle sync error ...\android\keystore.properties (The system cannot find the file specified)
If the file contains any secret making it unsuitable to share, then pls document what's in the file and how to generate a local one.

I can share it internally (bcgov) but not externally. It does not contain anything particularly sensitive besides our Fabric API key; Fabric is now deprecated and this package should be removed from the Android app next time it's being worked on. I've also implemented an automated Android build based on GitHub Actions. Contact me via email for the file.


Support for the Microsoft Edge browser

Currently OSCM supports the Microsoft Internet Explorer browser version 9 to 11. The Microsoft Edge browser has been released in 2015. Especially in business environments using Windows systems this browser is expected to become more and more popular.
Therefore it is essential that OSCM supports the Microsoft Edge browser.

We have done some quick tests with OSCM on Microsoft Edge browser. No problem’s have been discovered and we don’t expect bigger issues here.
@SuessI
Please add the information of edge browser support in the user documentation for 16.0.5.

Added Microsoft Edge to the supported browers in Installation Guide (Section 2.6) as well as a corresponding section in the Release Notes. Will be available with release 16.0.5.


Fluctuating Billing Dashboard

Description
I do not know where to put this issue
Observed Behavior: I created a new IAM user and I can see the billing dashboard fluctuating
Expected Behavior: The screen should be steady and show me billings
Please refer to this video  -
https://photos.app.goo.gl/VtAav6zpH8Ng3Q9y8

@JaynouOliver You're best option will be to contact AWS support. If you are seeing any karpenter related issue, please feel free to open a new issue.

Thank you


Update to ruby 2.1.5 with a bundle update

Busy time of year for open source projects!

Coverage remained the same when pulling 29636942b718d656c131e6dd37850e18e861c495 on mo-nathan:master into df93db78ecc3c3d04109a98dba6ee654d96ebf2b on MushroomObserver:master.


TP: Persist hidden (by default) column filters on reload

What does this PR (Pull Request) do?

[x] This PR fixes #5294

The issue was that the column filters (on hidden by default columns) are loaded from local storage before the onColumnVisible method was called, resulting in the loaded filters being wiped out.
Which Traffic Control components are affected by this PR?

Traffic Portal

What is the best way to verify this PR?
Run TP and add a filter to a column that is not visible by default. Refresh the page and confirm that the column is still visible.

If this is a bug fix, what versions of Traffic Control are affected?

master
5.0.x (RC1)

The following criteria are ALL met by this PR

[x] This PR includes tests OR I have explained why tests are unnecessary
[x] This PR includes documentation OR I have explained why documentation is unnecessary
[x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@shamrickus - sorry, one more table was converted to ag-grid between now and the time this PR was submitted - TableChangeLogsController. Want to update that too?

Sure

also, @shamrickus want to fix #5295 while you're at it in this PR or create another PR? your choice. super easy one.

dang, conflict

Conflicts are resolved


Deploy Checklist: New Expensify 2023-11-14

Release Version: 1.3.99-0
Compare Changes: https://github.com/Expensify/App/compare/production...staging
This release contains changes from the following pull requests:

[ ] https://github.com/Expensify/App/pull/26498
[x] https://github.com/Expensify/App/pull/27414
[x] https://github.com/Expensify/App/pull/27482
[x] https://github.com/Expensify/App/pull/27532
[x] https://github.com/Expensify/App/pull/27709
[x] https://github.com/Expensify/App/pull/28363
[x] https://github.com/Expensify/App/pull/28866
[x] https://github.com/Expensify/App/pull/28896
[ ] https://github.com/Expensify/App/pull/29180
[x] https://github.com/Expensify/App/pull/29661
[x] https://github.com/Expensify/App/pull/29674
[x] https://github.com/Expensify/App/pull/29745
[x] https://github.com/Expensify/App/pull/29898
[x] https://github.com/Expensify/App/pull/29939
[x] https://github.com/Expensify/App/pull/29953
[ ] https://github.com/Expensify/App/pull/29975
[x] https://github.com/Expensify/App/pull/30052
[x] https://github.com/Expensify/App/pull/30053
[x] https://github.com/Expensify/App/pull/30159
[x] https://github.com/Expensify/App/pull/30233
[x] https://github.com/Expensify/App/pull/30337
[ ] https://github.com/Expensify/App/pull/30339
[x] https://github.com/Expensify/App/pull/30416
[x] https://github.com/Expensify/App/pull/30420
[x] https://github.com/Expensify/App/pull/30424
[x] https://github.com/Expensify/App/pull/30441
[ ] https://github.com/Expensify/App/pull/30493
[x] https://github.com/Expensify/App/pull/30579
[x] https://github.com/Expensify/App/pull/30620
[x] https://github.com/Expensify/App/pull/30625
[ ] https://github.com/Expensify/App/pull/30704
[x] https://github.com/Expensify/App/pull/30728
[ ] https://github.com/Expensify/App/pull/30747
[x] https://github.com/Expensify/App/pull/30774
[x] https://github.com/Expensify/App/pull/30780
[x] https://github.com/Expensify/App/pull/30791
[x] https://github.com/Expensify/App/pull/30793
[x] https://github.com/Expensify/App/pull/30802
[x] https://github.com/Expensify/App/pull/30811
[ ] https://github.com/Expensify/App/pull/30819
[x] https://github.com/Expensify/App/pull/30832
[x] https://github.com/Expensify/App/pull/30833
[x] https://github.com/Expensify/App/pull/30836
[ ] https://github.com/Expensify/App/pull/30843
[x] https://github.com/Expensify/App/pull/30864
[x] https://github.com/Expensify/App/pull/30866
[x] https://github.com/Expensify/App/pull/30878
[x] https://github.com/Expensify/App/pull/30901
[x] https://github.com/Expensify/App/pull/30913
[x] https://github.com/Expensify/App/pull/30914
[x] https://github.com/Expensify/App/pull/30917
[x] https://github.com/Expensify/App/pull/30920
[x] https://github.com/Expensify/App/pull/30925
[ ] https://github.com/Expensify/App/pull/30930
[x] https://github.com/Expensify/App/pull/30946
[x] https://github.com/Expensify/App/pull/30958
[x] https://github.com/Expensify/App/pull/30960
[x] https://github.com/Expensify/App/pull/30964
[x] https://github.com/Expensify/App/pull/30967
[x] https://github.com/Expensify/App/pull/30972
[x] https://github.com/Expensify/App/pull/30974
[x] https://github.com/Expensify/App/pull/30993
[x] https://github.com/Expensify/App/pull/30997
[x] https://github.com/Expensify/App/pull/31013
[x] https://github.com/Expensify/App/pull/31016
[x] https://github.com/Expensify/App/pull/31017
[x] https://github.com/Expensify/App/pull/31021
[x] https://github.com/Expensify/App/pull/31022
[x] https://github.com/Expensify/App/pull/31035
[x] https://github.com/Expensify/App/pull/31039
[x] https://github.com/Expensify/App/pull/31040
[x] https://github.com/Expensify/App/pull/31041
[ ] https://github.com/Expensify/App/pull/31067
[x] https://github.com/Expensify/App/pull/31071
[x] https://github.com/Expensify/App/pull/31079
[x] https://github.com/Expensify/App/pull/31082
[x] https://github.com/Expensify/App/pull/31096
[x] https://github.com/Expensify/App/pull/31111
[x] https://github.com/Expensify/App/pull/31113
[x] https://github.com/Expensify/App/pull/31118
[x] https://github.com/Expensify/App/pull/31122
[x] https://github.com/Expensify/App/pull/31127
[x] https://github.com/Expensify/App/pull/31130
[x] https://github.com/Expensify/App/pull/31131
[x] https://github.com/Expensify/App/pull/31153
[x] https://github.com/Expensify/App/pull/31158
[x] https://github.com/Expensify/App/pull/31160
[x] https://github.com/Expensify/App/pull/31161
[x] https://github.com/Expensify/App/pull/31167
[x] https://github.com/Expensify/App/pull/31175
[x] https://github.com/Expensify/App/pull/31177
[x] https://github.com/Expensify/App/pull/31184
[x] https://github.com/Expensify/App/pull/31185
[x] https://github.com/Expensify/App/pull/31198
[x] https://github.com/Expensify/App/pull/31201
[x] https://github.com/Expensify/App/pull/31206
[x] https://github.com/Expensify/App/pull/31223
[x] https://github.com/Expensify/App/pull/31233
[ ] https://github.com/Expensify/App/pull/31244
[x] https://github.com/Expensify/App/pull/31254
[x] https://github.com/Expensify/App/pull/31255
[x] https://github.com/Expensify/App/pull/31258
[ ] https://github.com/Expensify/App/pull/31259
[x] https://github.com/Expensify/App/pull/31260
[x] https://github.com/Expensify/App/pull/31266
[x] https://github.com/Expensify/App/pull/31267
[x] https://github.com/Expensify/App/pull/31268
[x] https://github.com/Expensify/App/pull/31288
[x] https://github.com/Expensify/App/pull/31290
[x] https://github.com/Expensify/App/pull/31306
[ ] https://github.com/Expensify/App/pull/31313

Deploy Blockers:

[ ] https://github.com/Expensify/App/issues/31350

Deployer verifications:

[ ] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
[ ] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
[ ] I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Checking off the PRs from the past builds:
#27414
#27482
#27709
#28866
#29939
#29975
#30420
#30441
#30774
#30791
#30802
#30811
#30832
#30836
#30901
#30913
#30914
#30920
#30946
#30972
#30993
#30997
#31035
#31041
#31079
#31082
#31096
#31118
#31122
#31127
#31130
#31153
#31158
#31167
#31184
#31201

:rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.99-0 :rocket:

Regression is 90% progress.
#26498 failing with #26569
#30704 failing with #31329
#31067 failing with #30390

Regression completed.
https://github.com/Expensify/App/pull/31259#issuecomment-1812556181 we were not able test this step
Unchecked PRs:
#26498 failing with #26569
#30704 failing with #31329
#31067 failing with #30390
#30930 failing with #31383
#31259 failing with #31386
Open Blockers:
#31350

https://github.com/Expensify/App/issues/31350 is not a NewDot concern, checking it off. We should only re-route new user signups to NewDot. Existing accounts should still get OldDot unless they opted to try NewDot. Anyways, that bug should have been fixed by https://github.com/Expensify/Web-Expensify/pull/39701

:shipit:


publish 0.3.7 to docker hub

Can you publish 0.3.7 to the docker hub?  Thanks

Done.  It's building now.

Thanks for the quick turnaround


add euqality check

Coverage increased (+0.9%) to 75.661% when pulling 87f392a719a82ca80e630dcdf8ba4b7650781427 on equality into 3eb3273210525df945d55454ce6ac66fc6f557b2 on master.