[Ubuntu] homebrew will be removed from PATH variable

Breaking changes
homebrew will be removed from $PATH on Ubuntu images.
Target date
Image deployment will start September 22nd, and will be finished on Monday, September 27th.
The motivation for the changes
Starting with homebrew 3.6.0, gcc and its toolchain (binutils and glibc) became mandatory dependencies for any installed package. We are going to remove homebrew from the $PATH variable so it does not conflict with the canonical-provided software and toolchain.
See more:

linuxbrew overrides some basic toolchain commands #110877
homebrew executables are superseded by system ones #1136
Latest update to Ubuntu 20.04 image breaks gcc compiler #6280
gfortran in Ubuntu images broken because of added -gdwarf-5 flag #6274

Possible impact
If your project depends on homebrew your build will be broken.
Platforms affected

[X] Azure DevOps
[X] GitHub Actions

Runner images affected

[X] Ubuntu 18.04
[X] Ubuntu 20.04
[x] Ubuntu 22.04
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[ ] Windows Server 2022

Mitigation Path
Please use Homebrew/actions/setup-homebrew action to make brew available during running session.

Enormous breakage, enormous number of repositories.

Strange approach... lets brake image that used probably by 95% of github actions. Where there an announcement made about these changes? If not - it makes github images completely unreliable.

Could've been handled with prior announcement! Reactive approach.

This change breaks the commitment made in https://github.com/actions/runner-images/tree/releases/ubuntu20/20220922#default-version-update-policy
Moreover, this suggestion just does not work echo "/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin" >> $GITHUB_PATH
eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)" does work, but for the life of me, i cannot get tfenv to run after brew install tfenv succeeds.
The biggest problem is that there is no way for me to change runs-on to just use the previous version of the runner!

This change breaks the commitment made in https://github.com/actions/runner-images/tree/main#default-version-update-policy that promises to announce breaking change 1 month in advance.
This suggestion just does not work echo "/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin" >> $GITHUB_PATH
eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)" does work, but for the life of me, i cannot get tfenv to run after brew install tfenv succeeds.
The biggest problem is that there is no way for me to change runs-on to just use the previous version of the runner!

After multiple hours, I found a workaround that works, run the following commands in a single action step:

eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)"
brew install tfenv
tfenv install terraform

Hope this is helps someone.

Is it possible for GitHub to provide an official GitHub Action that enables Homebrew in Ubuntu images (e.g. actions/homebrew?)
Copying the eval line in every workflow in every repository is not robust against future changes to Homebrew's implementation details. For example, IIRC, Homebrew introduced the global /home/linuxbrew directory just a few years ago.

I use Astronomer Cloud for Apache Airflow.  The YAML file they provide to their clients uses brew to install their CLI, which then manages the push from GitHub to their repo.  This is detail that I thought had been abstracted away from my workflow.
The GitHub admins could have easily mapped the brew command onto something that provided useful useful information. Also, what was the rationale for removing brew from the path in older ubuntu images that were deprecated?  We all understand that things change, and that "latest" may break.  But to break things that were working and eliminate the possibility of rolling back?  That was not very customer-friendly.

echo "/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin" >> $GITHUB_PATH

This change breaks the commitment made in https://github.com/actions/runner-images/tree/main#default-version-update-policy that promises to announce breaking change 1 month in advance.
This suggestion just does not work echo "/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin" >> $GITHUB_PATH
eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)" does work, but for the life of me, i cannot get tfenv to run after brew install tfenv succeeds.
The biggest problem is that there is no way for me to change runs-on to just use the previous version of the runner!

After multiple hours, I found a workaround that works, run the following commands in a single action step:

eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)"
brew install tfenv
tfenv install terraform

Hope this is helps someone.

Im using tgenv  and that wont find terragrunt commands anymore. Anyone knows how to fix this?

          eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)"
          brew install tfsec

/home/linuxbrew/.linuxbrew/bin/tfsec

works with above path on different steps

Hello! We see that lots of customers are corcerned about this specific change,
so we deem necessery to give more context on what has happened.
Starting from version 6.0, homebrew has a dependency on gcc@11 and this dependency is installed automatically together with brew.
Installing these dependencies cause overriding the Ubuntu tools installed from apt and some preinstalled Ubuntu tools.
By default, the Homebrew package manager installs itself to have the highest priority in the system
(i.e. it comes first in the $PATH variable). Previosuly we had already tried to move brew to
the end of $PATH, but had no luck.
Currently, as homebrew is the first choice, it will automatically override some very basic
linux commands, utilities, and libraries such as:

locale
ldd
ar
ranlib

and some others.
Given the nature and importance of the entire linux toolchain ecosystem we decided to drop homebrew from $PATH
for all the Ubuntu versions (including Ubuntu 22.04, due to consistency),
following the principle of least surprise and to make the environemnts as predictable
as possible.
While we were working with the homebrew project on figuring out ways of fixing some issues we still consider
that not having homebrew in the $PATH variable is the safest way to prevent more issues in the future.
We would also like to give more context on the mitigation ways presented in the original announcement, literally:
the eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)" will only affect your current workflow's step
as this command is only affecting the currently running session and does not affect any further steps.
Adding homebrew to the $GITHUB_PATH variable considered as more robust solution as it makes brew available in the scope of the currently running job.

i tried to use echo "/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin" >> $GITHUB_PATH but it just didnt work.

For me it worked when I setup the command as its own step. Subsequent steps were then able to find brew.

Could you please use the blog for such a big breaking change? With the new UI, it shows some blog posts in the upper right corner and media uses announcements of the company blog too, but not a random issue in some repo.

I never saw an announcement regarding this change, and filed a support ticket regarding 'brew: command not found'. You responded that you were receiving a large number of support requests and a response (which I never got) would take a while. No wonder. Perhaps better notification would have reduced the number of support requests?

Just saying that @teaxyz would never choose an action that would compel the maintainers of a CI system used by millions to withdraw use of our tooling.

Why not just stick to homebrew 5.0 and avoid breaking everyone??

I didn't know this happened until a critical piece of our infrastructure stopped working in CI/CD.

Removed a month ago

https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md still says ubuntu-22 includes homebrew.

Using suggested mitigation does not work and fails with
| [command]/usr/bin/bash<EMAIL_ADDRESS>true false
| Could not find 'brew' command in PATH or standard locations.

The amount of breaking changes in GHA runner images is staggering. For the last 30 days we see randomly failing workflows because GitHub released incompatible images without any communication.


gcc-10 won't compile with rvalue string_view as range

The following code doesn't compile in gcc-10:
#include <string_view>
#include <scn/scn.h>

int main() {
    int i = 0;
    scn::scan_default(std::string_view("42"), i);
}

Errors mention an overload resolution failure due to priority_tag. Interestingly, passing a string_view as an lvalue (even const) works fine.
errors.txt

Gah, the overload resolution rules are a source of pain sometimes. Fixed in latest master, thank you for reporting!


Update dependecies

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-8.3%) to 87.903%

Totals

Change from base Build<PHONE_NUMBER>:
-8.3%

Covered Lines:
981

Relevant Lines:
1116

💛  - Coveralls


firebase_auth build warnings in xcode

Personally, I'm a fan of a clean build. Broken window theory and all.
firebase_auth v0.14.0

Surprisingly I don't see a duplicate for this.

Surprisingly I don't see a build failure from CI. ;-)

@lookfirst
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/1087. Any further collaboration will be done there.


Rebinding failed

Good afternoon
I'm setting up Singularity to play around, but somehow none of the payloads work, I'm wondering if I'm missing something.
Here's my Namecheap setup:

This is the failed rebinding error with any of the payloads:

Server log:

Any tips are greatly appreciated! Thank you.
Cheers

Are you trying to exploit a service that has a DNS rebinding vulnerability? Can you please provide more details on the service you are trying to exploit? All attack payloads require a service that is vulnerable to DNS rebinding attacks.

Hi thank you for the quick response! You're right it was due to the service I was trying to exploit. Tried it with the test service as mentioned in the wiki and it worked. Thank you for guiding in the right direction, and for the great tool!


PIN system to delete a Free Basics account

Expected behavior
A Free Basics user should get a PIN when he wants to delete his vutuv account.
Actual behavior
He gets a magic link which is no good for him.

I just tested this. When I have the header X-IORG-FBS = true I receive a pin. Are free basics users reporting differently?

hmmmm... maybe the de translation is wrong. I'll check it tomorrow.


Installer broken

I went to http://www.telerik.com/justassembly, clicked the Download button, and ran the installer: JustAssembly_2017_2_713_1_Free.exe.
It gave me a "old installer version" error:

That link for the new version downloads the same version.

Had the same issue please fix this tool looks great.

Should be fixed now.

Fixed for me. Thanks!


Enhance error message when user runs from a non-component directory

What type of PR is this:
/kind bug

What does this PR do / why we need it:
Enhance error message when user runs from a non-component directory
Which issue(s) this PR fixes:

Fixes #5987
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:

Run odo delete component or any other command from an empty directory.

The error message is long and could use an improvement, so I am looking for suggestions.

/lgtm

/override OpenShift Integration tests/OpenShift Integration tests
Reason: prow job passed.

/override ci/prow/v4.10-integration-e2e


Fix penguins dataset

I'd like to modify penguins dataset for the following aspects:

Reorder species to follow seaborn's penguins dataset
Add cleansing process for "sex" field (there is "." in this field)

@kou Could you please have a look at this?

Thanks!


release模式下报错 react-native run-android --variant release

Abort message: 'art/runtime/thread.cc:1672] No pending exception expected: java.lang.ClassNotFoundException: Didn't find class "com.baidu.mapapi.model.ParcelItem" on path: DexPathList[[zip file "/data/app/com.XXXXX-1/base.apk"],nativeLibraryDirectories=[/data/app/com.XXXXX-1/lib/arm64, /data/app/com.XXXXX-1/base.apk!/lib/arm64-v8a, /system/lib64, /vendor/lib64]]'

change code in ' app/build.gradle '
def enableProguardInReleaseBuilds = false
it is works

change code in ' app/build.gradle '
def enableProguardInReleaseBuilds = false
it is works

it works for me


Examples for predicted molecular consequences

Example list:

[x]  1:230710048:rs699 (bi-allelic snp)
[x]  13:32379902:rs202155613 (multi-allelic snp)
[x]  13:57932508:rs71197234 (insertion with upstream/downstream variants)
[x]  21:45988447:rs1312342906(insertion with intron variant)
[ ] deletion
[ ] indel
[ ] substitution

Could you also include variant types other than SNV and insertion?
Deletion and substitution?

Could you also include variant types other than SNV and insertion?
Deletion and substitution?

Hi @azangru, I have added an example for insertion, deletion, indel and substitution.


[BEAM-5110] Explicitly count the references for BatchFlinkExecutableStageContext …

…and clean them after TTL
We relied on weak reference and finalize to keep track of active BatchFlinkExecutableStageContext for each job. This is error prone and sub optimal and has been on our radar for cleanup.
Introducing explicit reference counting and cleanup of BatchFlinkExecutableStageContext for each job.
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---
---

R: @bsidhom
CC: @tweise @lukecwik

Why do we share the context between different ExecutableStage executions?
I think we can also simplify this by removing FlinkExecutableStageContext.Factory contextFactory.  Instead FlinkExecutableStageFunction can refer in open to a static factory method to obtain the context.

We need to share the context mostly to keep track of SDKHarness process.
Also the ExecutableStage starts control, logging, data, state services.

@tweise We also need the factory to be pluggable for testing.

@bsidhom I meanwhile realized that also while working on streaming side inputs. But it isn't clear to me why the context needs to be shared. Is that intended to be an optimization for batch (to reduce the initialization time)? If so, then please document this?

See comment on https://jira.apache.org/jira/browse/BEAM-5110

I agree. We should provide control SDKHarness container instances especially when python container can only utilize a single core at a time.
We can break down the whole container management in 2 parts based on the discussion.

How to start and manage SDKHarness. (using kubernetes, process based, singleton factory etc)
Configuration for managing SDKHarenss. ( Number of containers. type of containers etc)

This bug tries to address the 1st part using a singleton factory which apparently is not behaving as expected in the current code base. We want to explore a more robust way of managing containers like kubernetes but that will take some time to add and also impose more infrastructure requirements so singleton container seems useful.
Shall we track the 2nd part as "Multiple SDKHarness with singleton container manager" separately?
Also added here https://jira.apache.org/jira/browse/BEAM-5110?focusedCommentId=16578840&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16578840

This PR only addresses bug in the current implementation of environment management.
@tweise Shall we wait for the discussion on environment management before pursuing this PR.

Please see checkstyle/findbugs errors.


how to code a svg 2D floor plan as shown in the dashboard demo?

I'm submitting a ...  (check one with "x")

[ x] question about the decisions made in the repository

Issue description
Current behavior:
The picture below shows a 2D room demo

The code is made of svg.  I want to change the svg to make another similar 2D floor plan. So my question is how to make such svg ?

May be coding with patience....

Also interested on this, @KostyaDanovsky did it on https://github.com/akveo/ngx-admin/commit/a77a1c3c70ba9dfd1375003b60412147f1179ec6, maybe is just patience.

I also would like to know how it has been drawn. Probably Inkscape but would be nice to hear something official.

Any new tools to develop 2D SVG plans for this?

You guys should at least give us a methodology to develop svg's like this.

would also like to know how this was done by the dev @KostyaDanovsky

Is anyone find some library to make this floor plan style?


Update README.md

Adding the Sandbox project designation in the readme file per the onboarding requirements. I added it at the very bottom of the file.
Signed-off-by: Jeff ErnstFriedman<EMAIL_ADDRESS>

Codecov Report

Merging #525 (57e2aee) into main (b86aa47) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
+ Coverage   38.04%   38.07%   +0.02%
==========================================
  Files          22       22
  Lines        9141     9141
==========================================
+ Hits         3478     3480       +2
+ Misses       5274     5273       -1
+ Partials      389      388       -1

Impacted Files
Coverage Δ

KubeArmor/feeder/policyMatcher.go
40.65% <0.00%> (+0.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b86aa47...57e2aee. Read the comment docs.


(#216) Fix general info link

The earlier 'General info' link in contributing.md redirects to search results. This commit sets that to the right url.

:+1:


Hope the Loading control supports custom Background and Foreground

Loading itself is working fine by setting Background and Foreground. Do you mean Loading Container?


[tool_crash] StateError: Bad state: No context with the running Dart application.

Command
flutter --no-color run --machine --track-widget-creation --device-id=chrome --start-paused --dart-define=flutter.inspector.structuredErrors=true lib\main.dart

Steps to Reproduce

...
...
...

Logs
StateError: Bad state: No context with the running Dart application.
#0      RemoteDebuggerExecutionContext.id (package:dwds/src/debugging/execution_context.dart:55:7)
<asynchronous suspension>
#1      AppInspector._getExtensionRpcs (package:dwds/src/debugging/inspector.dart:501:20)
<asynchronous suspension>
#2      AppInspector._initialize (package:dwds/src/debugging/inspector.dart:93:34)
<asynchronous suspension>
#3      AppInspector.initialize (package:dwds/src/debugging/inspector.dart:156:5)
<asynchronous suspension>
#4      ChromeProxyService.createIsolate (package:dwds/src/services/chrome_proxy_service.dart:222:18)
<asynchronous suspension>

[✓] Flutter (Channel stable, 2.2.3, on Microsoft Windows [Version 10.0.19041.508], locale en-IN)
    • Flutter version 2.2.3 at C:\src\flutter
    • Framework revision f4abaa0735 (3 months ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\admin\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] IntelliJ IDEA Community Edition (version 2021.2)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.2
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.60.1)
    • VS Code at C:\Users\admin\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.26.0

[✓] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 93.0.4577.82
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 93.0.961.52

• No issues found!

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: stable
Creation framework version: f4abaa0735eba4dfd8f33f73363911d63931fe03

Hi @Nav21000,
You appear to be on an older version of flutter stable.
Can you please upgrade to the latest version of stable and see if you still experience this issue?
If you do, please provide your verbose logs and if the verbose logs are to huge, put them in a log.txt file and share them here.
Thank you


Voice & SMS classes for modular architecture

Test config and tests were adapted for the new voice & sms classes
A first step to a more modular architecture

Coverage decreased (-1.2%) to 96.183% when pulling 58a6d6da497c6651a3744010e0921d6d5d5350f4 on voice-module into 727b01afe8ea42dcf3db2c08c6072b022090c5f7 on master.

test_voice_deprecated.py can actually be removed. That's an older Voice API that just did text-to-speech, which is rolled into the current VAPI product.

@superdiana it looks like your adding 2.7 support back - was that intended?

Oh no no! Thanks for pointing it out!

Added the SMS class + Tests and corrected the 2.7 support drop.


Generator-based dependency functions fail with Propan

Description
When trying to use a FastAPI dependency function with a yield statement in Propan, I found that the function is not awaited. The assert error is raised in this case, but using a function with a return statement instead of yield works fine.
Steps to reproduce

Define a FastAPI dependency function with a yield statement:
async def get_db() -> str:
    yield "connected"

Use it as a dependency in a Propan event function:
@router.event("test")
async def hello(m: Incoming, db: str = Depends(get_db)) -> dict:
    print(m.model_dump_json())
    print(db)
    return {"response": "Hello, Rabbit!"}

Run the app and make a GET request. An AssertionError is raised.

Expected behavior
The dependency function get_db should be awaited, just as when we use FastAPI's dependency injection system for HTTP requests.
Actual behavior
The AssertionError is raised when trying to use a dependency function with a yield.
Environment:

Linux (amd64)
Python 3.10.11
The following relevant libraries are installed:

FastAPI
Propan

Additional information
I believe the issue happens because in Propan, the cleanup part of a dependency function that yields (the part that comes after the yield statement) never gets run. FastAPI's dependencies are designed with HTTP request lifespans in mind, and as such dependency functions using yield are treated as context managers that perform cleanup after each request. The issue could be due to Propan not fully supporting this model, especially when it comes to context manager behavior of dependencies.
Any assistance would be greatly appreciated!

It's a pretty strange cuz Propan as a FastAPI router uses a FastAPI DI system. Anyway, will check and fix it tomorrow, thanks for the Issue.

@pythrick the job is done! Just update Propan to <IP_ADDRESS> and FastAPI yield Depends works fine.

@Lancetnik thank you for the quick fix! It was fast! I'm really enjoying this framework, thank you for your great work building it.

@Lancetnik thank you for the quick fix! It was fast! I'm really enjoying this framework, thank you for your great work building it.

Thank you for the Issue and for the FastDepends contribution too! I am always trying to fix any bugs issues in the same day (or a few days later), so be free to report of any bugs or features you wish to see in the Propan.
Also, if you are so enjoied by Propan, please tell others about it (by tweet, article, smth). The bigger community we have - the better project will be!


ks-jenkins often restart for an unknown reason

ks-jenkins经常莫名其妙重启，健康检查失败导致，但为何检测失败不知道，是否是有什么兼容性问题，ks版本：3.1.0，ks-jenkins镜像：kubespheredev/ks-jenkins:3.2.0-rc0-2.249.1，ks-j enkins日志如附件
ks-jenkins.log

Thanks for reaching out to us. But we encourage everyone to communicate with each other in GitHub in English. Please visit the Chinese forum if you prefer to use Chinese.
In most cases, Jenkins might restart itself for the following reasons:

out the of the memory/cpu

in this case, please try to get the monitor data during the Jenkins restart time

with some incompatible plugins

please check if you have installed other plugins which do not come from ks-jenkins

/kind support

How much memory and CPU are appropriate? There are about 50 concurrent tasks

How to determine whether the plug-in has compatibility problems? We use the image source provided by you. We have not installed any plug-ins, except for loading some shared pipelines libraries

ks-jenkins does not have plugin ssh-server

How much memory and CPU are appropriate? There are about 50 concurrent tasks

You could monitor ks-jenkins deployment like this:

Please feel to open this issue if you have more clues on this issue. But I'm going to close this issue due to no response for a long time.

/close


$guildCount[userId]

Featuring Type
Function
So, what is it about?
It will tell you the number of servers where the given user is located
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@Leref this can be closed.


bug: cache always missed

Provide environment information
System:
OS: macOS 13.2.1
CPU: (8) arm64 Apple M1 Pro
Memory: 86.66 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 19.8.1 - /opt/homebrew/bin/node
npm: 9.5.1 - /opt/homebrew/bin/npm
Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
Describe the bug
I already linked turbo and the vercel project but the cache is always missed on production deployments and local
pnpm run build - I need to run this twice for the log to say cache hit, but whenever there's any change it misses right away again
@zwei/db:db:generate: const prisma = new PrismaClient()
@zwei/db:db:generate: ```
@zwei/www:build: cache hit, replaying output 57cf1f63d1d07df3
@zwei/www:build:
@zwei/www:build: ><EMAIL_ADDRESS>build /Users/a3tech/Developer/personal_projects/id-like-turbo/apps/www
@zwei/www:build: > next build
@zwei/www:build:
@zwei/www:build: info  - Linting and checking validity of types...
@zwei/www:build: info  - Creating an optimized production build...
@zwei/www:build: info  - Compiled successfully
@zwei/www:build: info  - Collecting page data...
@zwei/www:build: info  - Generating static pages (0/3)
@zwei/www:build: info  - Generating static pages (3/3)
@zwei/www:build: info  - Finalizing page optimization...
@zwei/www:build:
@zwei/www:build: Route (pages)                              Size     First Load JS
@zwei/www:build: ┌ ○ /                                      3.48 kB         111 kB
@zwei/www:build: ├   /_app                                  0 B             107 kB
@zwei/www:build: ├ ○ /404                                   181 B           107 kB
@zwei/www:build: ├ λ /api/auth/[...nextauth]                0 B             107 kB
@zwei/www:build: └ λ /api/trpc/[trpc]                       0 B             107 kB
@zwei/www:build: + First Load JS shared by all              109 kB
@zwei/www:build:   ├ chunks/framework-19f3649580393c10.js   45.2 kB
@zwei/www:build:   ├ chunks/main-c72d876ee674f970.js        26.9 kB
@zwei/www:build:   ├ chunks/pages/_app-45fd38b829a0f5ad.js  34.2 kB
@zwei/www:build:   ├ chunks/webpack-8fa1640cc84ba8fe.js     750 B
@zwei/www:build:   └ css/a4b4cc2ab19dfa8d.css               2.27 kB
@zwei/www:build:
@zwei/www:build: λ  (Server)  server-side renders at runtime (uses getInitialProps or getServerSideProps)
@zwei/www:build: ○  (Static)  automatically rendered as static HTML (uses no initial props)
@zwei/www:build:

Link to reproduction
https://codesandbox.io/p/github/AlvaroAquijeDiaz/turbo-cache-bug/main?workspaceId=fc6d1353-f6d0-46c5-9481-b401aeb46f0e&file=/README.md
To reproduce

clone
link turbo to vercel project
turbo run build

shows cache miss
Additional information
I've followed all the steps on the guide about how to setup the project and yet, it doesn't seem to work

pnpm run build - I need to run this twice for the log to say cache hit, but whenever there's any change it misses right away again

I don't quite understand - what are you changing? Are you not expecting that this change to bust the cache?

what I meant by that was that after changing any file inside the next app, like adding pages or updating a page; the cache is always missed, maybe I'm wrong and this is expected in turborepo?

So for example, are you expecting a cache hit for pageA and pageB if you change pageC or add a new pageD?

Currently, the only app/package that has a build script is the nextjs app, but if you add more packages, perhaps a UI pacakge and build that, you should see the benefits of the turbo cache in that changing nextjs wouldn't cause the ui to cache miss. But the cache is not as granular down to individual pages

ah I get it now thanks a lot!


Simplify instrumentation confirmations in RazorPageExecutionInstrumentationTest

test class can now use the MvcTestFixture

#3139 part 3 of 3

dump instrumentation data at end of _Layout.cshtml

include FilePath in display
compare against new .html resource

nits:

normalize line endings to CRLF for consistency with other tests
add InstrumentionData to avoid Tuple
make TestPageExecutionContext class private
remove newly-unused actions and associated .cshtml files

/cc @pranavkm @rynowak

:shipit:

a69a7a6


Could not introduce golang.org/x/time@master, as its subpackage golang.org/x/time does not contain usable Go code

C:\Users\rc452\go\src\github.com\rc452860\vnet>dep ensure -v
Warning: the following project(s) have [[constraint]] stanzas in Gopkg.toml:
✗  github.com/aead/chacha20
✗  github.com/shadowsocks/vnet
✗  github.com/valyala/fasthttp
However, these projects are not direct dependencies of the current project:
they are not imported in any .go files, nor are they in the 'required' list in
Gopkg.toml. Dep only applies [[constraint]] rules to direct dependencies, so
these rules will have no effect.
Either import/require packages from these projects so that they become direct
dependencies, or convert each [[constraint]] to an [[override]] to enforce rules
on these projects, if they happen to be transitive dependencies.
Gopkg.lock is out of sync with Gopkg.toml and project imports:
golang.org/x/time: imported or required, but missing from Gopkg.lock's input-imports
Root project is "github.com/rc452860/vnet"
22 transitively valid internal packages
20 external packages imported from 11 projects
(0)   ✓ select (root)
(1)     ? attempt github.com/Yawning/chacha20 with 1 pkgs; at least 1 versions to try
(1)         try github.com/Yawning/chacha20@master
(1)     ✓ select github.com/Yawning/chacha20@master w/1 pkgs
(2)     ? attempt github.com/jinzhu/gorm with 1 pkgs; at least 1 versions to try
(2)         try<EMAIL_ADDRESS>(2)     ✓ select<EMAIL_ADDRESS>w/1 pkgs
(3)     ? attempt github.com/go-sql-driver/mysql with 1 pkgs; at least 1 versions to try
(3)         try<EMAIL_ADDRESS>(3)     ✓ select<EMAIL_ADDRESS>w/1 pkgs
(4)     ? attempt github.com/jinzhu/inflection with 1 pkgs; at least 1 versions to try
(4)         try github.com/jinzhu/inflection@master
(4)     ✓ select github.com/jinzhu/inflection@master w/1 pkgs
(5)     ? attempt github.com/tjfoc/gmsm with 1 pkgs; at least 1 versions to try
(5)         try<EMAIL_ADDRESS>(5)     ✓ select<EMAIL_ADDRESS>w/1 pkgs
(6)     ? attempt golang.org/x/crypto with 10 pkgs; at least 1 versions to try
(6)         try golang.org/x/crypto@master
(6)     ✓ select golang.org/x/crypto@master w/13 pkgs
(7)     ? attempt github.com/klauspost/reedsolomon with 1 pkgs; at least 1 versions to try
(7)         try<EMAIL_ADDRESS>(7)     ✓ select<EMAIL_ADDRESS>w/1 pkgs
(8)     ? attempt github.com/klauspost/cpuid with 1 pkgs; at least 1 versions to try
(8)         try<EMAIL_ADDRESS>(8)     ✓ select<EMAIL_ADDRESS>w/1 pkgs
(9)     ? attempt github.com/pkg/errors with 1 pkgs; at least 1 versions to try
(9)         try<EMAIL_ADDRESS>(9)     ✓ select<EMAIL_ADDRESS>w/1 pkgs
(10)  ? attempt golang.org/x/net with 1 pkgs; at least 1 versions to try
(10)      try golang.org/x/net@master
(10)  ✓ select golang.org/x/net@master w/4 pkgs
(11)  ? attempt github.com/templexxx/xor with 1 pkgs; at least 1 versions to try
(11)      try<EMAIL_ADDRESS>(11)  ✓ select<EMAIL_ADDRESS>w/1 pkgs
(12)  ? attempt github.com/labstack/echo with 1 pkgs; at least 1 versions to try
(12)      try<EMAIL_ADDRESS>(12)  ✓ select<EMAIL_ADDRESS>w/1 pkgs
(13)  ? revisit golang.org/x/crypto to add 1 pkgs
(13)    ✓ include 2 more pkgs from golang.org/x/crypto@master
(13)  ? attempt github.com/templexxx/cpufeat with 1 pkgs; at least 1 versions to try
(14)      try github.com/templexxx/cpufeat@master
(14)  ✓ select github.com/templexxx/cpufeat@master w/1 pkgs
(14)  ? attempt github.com/labstack/gommon with 2 pkgs; at least 1 versions to try
(15)      try<EMAIL_ADDRESS>(15)  ✓ select<EMAIL_ADDRESS>w/2 pkgs
(15)  ? attempt github.com/mattn/go-colorable with 1 pkgs; at least 1 versions to try
(16)      try<EMAIL_ADDRESS>(16)  ✓ select<EMAIL_ADDRESS>w/1 pkgs
(16)  ? attempt github.com/mattn/go-isatty with 1 pkgs; at least 1 versions to try
(17)      try<EMAIL_ADDRESS>(17)  ✓ select<EMAIL_ADDRESS>w/1 pkgs
(17)  ? attempt github.com/valyala/fasttemplate with 1 pkgs; at least 1 versions to try
(18)      try github.com/valyala/fasttemplate@master
(18)  ✓ select github.com/valyala/fasttemplate@master w/1 pkgs
(18)  ? attempt github.com/valyala/bytebufferpool with 1 pkgs; at least 1 versions to try
(19)      try<EMAIL_ADDRESS>(19)  ✓ select<EMAIL_ADDRESS>w/1 pkgs
(19)  ? attempt golang.org/x/sys with 1 pkgs; at least 1 versions to try
(20)      try golang.org/x/sys@master
(20)  ✓ select golang.org/x/sys@master w/1 pkgs
(20)  ? attempt golang.org/x/time with 1 pkgs; 1 versions to try
(21)      try golang.org/x/time@master
(22)  ✗   golang.org/x/time at master has problem subpkg(s):
(22)            golang.org/x/time has err (*build.NoGoError); required by (root).
(21)    ← no more versions of golang.org/x/time to try; begin backtrack
(20)  ← backtrack: no more versions of golang.org/x/sys to try
(19)  ← backtrack: no more versions of github.com/valyala/bytebufferpool to try
(18)  ← backtrack: no more versions of github.com/valyala/fasttemplate to try
(17)  ← backtrack: no more versions of github.com/mattn/go-isatty to try
(16)  ← backtrack: no more versions of github.com/mattn/go-colorable to try
(15)  ← backtrack: no more versions of github.com/labstack/gommon to try
(14)  ← backtrack: no more versions of github.com/templexxx/cpufeat to try
(13)  ← backtrack: popped 2 pkgs from golang.org/x/crypto
(12)  ← backtrack: no more versions of github.com/labstack/echo to try
(11)  ← backtrack: no more versions of github.com/templexxx/xor to try
(10)  ← backtrack: no more versions of golang.org/x/net to try
(9)     ← backtrack: no more versions of github.com/pkg/errors to try
(8)     ← backtrack: no more versions of github.com/klauspost/cpuid to try
(7)     ← backtrack: no more versions of github.com/klauspost/reedsolomon to try
(6)     ← backtrack: no more versions of golang.org/x/crypto to try
(5)     ← backtrack: no more versions of github.com/tjfoc/gmsm to try
(4)     ← backtrack: no more versions of github.com/jinzhu/inflection to try
(3)     ← backtrack: no more versions of github.com/go-sql-driver/mysql to try
(2)     ← backtrack: no more versions of github.com/jinzhu/gorm to try
(1)     ← backtrack: no more versions of github.com/Yawning/chacha20 to try
✗ solving failed
Solver wall times by segment:
b-list-pkgs: 1m34.8907602s
b-gmal: 1m30.0154977s
b-source-exists:    8.4510404s
b-deduce-proj-root:    2.2651507s
new-atom:     15.9173ms
select-atom:     11.0875ms
backtrack:      3.9897ms
satisfy:       2.552ms
add-atom:       999.5µs
other:       997.5µs
unselect:       996.8µs
b-list-versions:            0s
select-root:            0s
TOTAL: 3m15.6589893s
Solving failure: No versions of golang.org/x/time met constraints:
master: Could not introduce golang.org/x/time@master, as its subpackage golang.org/x/time does not contain usable Go code (*build.NoGoError).. (Package is required by (root).)

@rc452860 it may be a good idea to resolve the problem.

Hi, are you still running into this issue? I tried downloading rc452860/vnet@13fa719 and I could not reproduce the error you are seeing. Can you describe how I can reproduce it?
Running dep ensure generated a Git diff in Gopkg.lock though:
diff --git a/Gopkg.lock b/Gopkg.lock
index 07485c4..fdb8cbc 100644
--- a/Gopkg.lock
+++ b/Gopkg.lock
@@ -1,6 +1,14 @@
 # This file is autogenerated, do not edit; changes may be undone by the next 'dep ensure'.

+[[projects]]
+  digest = "1:e92f5581902c345eb4ceffdcd4a854fb8f73cf436d47d837d1ec98ef1fe0a214"
+  name = "github.com/StackExchange/wmi"
+  packages = ["."]
+  pruneopts = "UT"
+  revision = "5d049714c4a64225c3c79a7cf7d02f7fb5b96338"
+  version = "1.0.0"
+
 [[projects]]
   branch = "master"
   digest = "1:e05c7b72aeba7570b1d2f9c6dc9f0373d224b16b70fa886c504de867bffe1c2e"
@@ -33,6 +41,17 @@
   revision = "b869fe1415e4b9eb52f247441830d502aece2d4d"
   version = "v1.3.0"

+[[projects]]
+  digest = "1:c96d16a4451e48e2c44b2c3531fd8ec9248d822637f1911a88959ca0bcae4a64"
+  name = "github.com/go-ole/go-ole"
+  packages = [
+    ".",
+    "oleutil",
+  ]
+  pruneopts = "UT"
+  revision = "39dc8486bd0952279431257138bc428275b86797"
+  version = "v1.2.2"
+
 [[projects]]
   digest = "1:ec6f9bf5e274c833c911923c9193867f3f18788c461f76f05f62bb1510e0ae65"
   name = "github.com/go-sql-driver/mysql"
@@ -42,7 +61,7 @@
   version = "v1.4.1"

 [[projects]]
-  digest = "1:fc0a04eb0e588ad280e11e11b63e5ea84da30ae01d2aa7feb661a777d18b32f3"
+  digest = "1:97df918963298c287643883209a2c3f642e6593379f97ab400c2a2e219ab647d"
   name = "github.com/golang/protobuf"
   packages = ["proto"]
   pruneopts = "UT"
@@ -122,9 +141,15 @@
   version = "v0.8.1"

 [[projects]]
-  digest = "1:0dc41f232ad16c241c1ab36d51eaffef124e3550ef490dfd1ea3ebdf11ca1d21"
+  digest = "1:1649d52be27b8eb3ae62e1ffc83d0738efb699d3ae476e7a3e31befe8290ed87"
   name = "github.com/shirou/gopsutil"
-  packages = ["."]
+  packages = [
+    "cpu",
+    "disk",
+    "internal/common",
+    "mem",
+    "net",
+  ]
   pruneopts = "UT"
   revision = "ccc1c1016bc5d10e803189ee43417c50cdde7f1b"
   version = "v2.18.12"
@@ -198,11 +223,12 @@

 [[projects]]
   branch = "master"
-  digest = "1:6c854c3734cdaba6b8d4e6795e234213418a6e963260065adadee24665ca56a3"
+  digest = "1:396d4228b57507f3320229d47bb2d3d0f0a0a0ae27e193c2f36cb5c152d3dcab"
   name = "golang.org/x/sys"
   packages = [
     "cpu",
     "unix",
+    "windows",
   ]
   pruneopts = "UT"
   revision = "82a175fd1598e8a172e58ebdf5ed262bb29129e5"
@@ -249,7 +275,10 @@
     "github.com/jinzhu/gorm",
     "github.com/klauspost/reedsolomon",
     "github.com/pkg/errors",
-    "github.com/shirou/gopsutil",
+    "github.com/shirou/gopsutil/cpu",
+    "github.com/shirou/gopsutil/disk",
+    "github.com/shirou/gopsutil/mem",
+    "github.com/shirou/gopsutil/net",
     "github.com/templexxx/xor",
     "github.com/tjfoc/gmsm/sm4",
     "golang.org/x/crypto/blowfish",

Hi guys, I'm having the same issue installing Gin with dep.
System Details
Golang Version: go version go1.14.6 linux/amd64
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04 LTS
Release:	20.04
Codename:	focal

Steps to reproduce

Create a new directory for a Golang/Gin project

mkdir server

Initialize dep in the directory as follows:

dep init

Create main.go file with the following content:

package main

import "github.com/gin-gonic/gin"

func main() {
	r := gin.Default()
	r.GET("/ping", func(c *gin.Context) {
		c.JSON(200, gin.H{
			"message": "pong",
		})
	})
	r.Run() // listen and serve on <IP_ADDRESS>:8080 (for windows "localhost:8080")
}

Resolve dependencies with dep ensure

Received the following output

dep output
Solving failure: No versions of github.com/go-playground/validator met constraints:
	v10.3.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v10.2.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v10.1.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v10.0.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v10.0.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.31.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.30.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.30.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.30.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.29.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.29.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.28.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.27.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.26.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.25.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.24.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.23.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.22.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.21.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.21.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.20.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.20.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.20.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.19.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.18: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.17.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.17.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.16.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.16.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.15.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.14.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.13.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.12.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.11.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.10.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.9.4: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.9.3: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.9.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.9.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.9.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.8.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.7.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.6.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.5.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.4.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.3.6: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.3.5: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.3.4: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.3.3: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.3.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.3.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.3.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.2.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.2.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.2.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.1.3: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.1.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.1.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.1.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9: Could not introduce github.com/go-playground/validator@v9, as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.0.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.18.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.18.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.18.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.17.3: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.17.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.17.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.17: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.16: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.15.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.15: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.14: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.13: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.12: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.11: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.10: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.9: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.8.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.8: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.7: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.6: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.5: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.4: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.3: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8.0.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8: Could not introduce github.com/go-playground/validator@v8, as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v7.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v7.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v7: Could not introduce github.com/go-playground/validator@v7, as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v6.8: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v6.7: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v6.6: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v6.5.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v6.5: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v6.4: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v6.3: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v6.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v6.1.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v6.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v6.0.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v6.0.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v6.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.12: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.11: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.10.3: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.10.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.10.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.10: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.9.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.9.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.9: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.8.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.8: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.7.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.7: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.6.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.6: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.5.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.5: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.4: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.0.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5.0.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5: Could not introduce github.com/go-playground/validator@v5, as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v4.0.4: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v4.0.3: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v4.0.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v4.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v3.0.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v3.0.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v3.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v2.3: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v2.2: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v2.1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v2.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v1.0: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	master: Could not introduce github.com/go-playground/validator@master, as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	updates-and-fixes: Could not introduce github.com/go-playground/validator@updates-and-fixes, as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v4: Could not introduce github.com/go-playground/validator@v4, as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v5: Could not introduce github.com/go-playground/validator@v5, as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v6: Could not introduce github.com/go-playground/validator@v6, as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v7: Could not introduce github.com/go-playground/validator@v7, as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8: Could not introduce github.com/go-playground/validator@v8, as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9: Could not introduce github.com/go-playground/validator@v9, as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v8,8: Could not introduce github.com/go-playground/validator@v8,8, as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>	v9.0.0RC1: Could not introduce<EMAIL_ADDRESS>as its subpackage github.com/go-playground/validator/v10 is missing. (Package is required by<EMAIL_ADDRESS>

Hope this helps, regards!


Add boot profile task/job

The primary use of this is to be able to serve down a custom diskboot ipxe profile, in lieu of a way for us to intentionally ignore DHCP/PXE for a node while there is an active workflow against it.
Unfortunately, due to the way that we concatenate ALL ipxe profiles with boilerplate.ipxe, this task will not work effectively if it is the final task in a workflow, because the boilerplate ipxe script tries to DHCP again, and if we ignore those requests because there is no longer an active workflow, then it will never reach the custom script that was specified.
I think there could be more work done in that area ^^, but I'm not sure whether it's worth it, and think that this should be sufficiently simple to address the desired use case.
@RackHD/corecommitters @ytjohn @jlmcknight
This was prompted by the following Slack discussion:

jlmcknight [2:05 PM]
to expand on johnÕs question, we have a workflow that looks like this end to end:
pxe boot -> rackhd discovery -> reboot -> pxe boot into our overlayfs and do our custom catalog plus other comands (mem/cpu tests, cable validation, disk validation/partition wipe etc.) -> reboot -> pxe into ubuntu install -> reboot -> boot from disk -> ansible post install -> final reboot
That works for us on our current focus of dell c6320, but in trying to do that in vagrant, the reboot after ubuntu install is doing a pxe boot, getting error.ipxe downloaded, but when error.ipxe runs exit it will fail to boot from hard disk.  If we change exit to sanboot Ñno-describe Ñdrive 0x80 in error.ipxe it works, but we donÕt want to make that change for vagrant when we donÕt have this problem in our bare metal installs.
Is there a way in the workflow (a task of some sort) we can shoehorn into the process after the ubuntu install that says "donÕt respond to ipxe for this hostÓ so we can control it at the workflow layer and not by editing profile files like error.ipxe?

+1

Coverage increased (+0.05%) to 88.297% when pulling bd7066fc504521bcfd9b408e4ea791f7300b9d4c on benbp:boot-profile into 3590e6d7d35bd6a99abdf45965cdef8eafeaf69f on RackHD:master.

+1

+1


Xray blocking release jfrog client

Hello,
I have build an internal jfrogcli running on rhel7 and xray is blocking jfrog cli because it was built in a old version of GO.
Dockerfile used
FROM bar.jfrog.company.com/ubi7:89a082b4
ENV VERSION=1.33.2
USER root
RUN curl -o /usr/local/bin/jfrog "https://bar.jfrog.company.com/artifactory/generic-jfrogbintraycomjfrogcligo-remote/${VERSION}/jfrog-cli-linux-amd64/jfrog"
RUN chmod +x /usr/local/bin/jfrog
USER 1001
Xray errors
Summary | Severity | Type | Watch-Name | Violated Resources | Component | Created | policy |   |
-- | -- | -- | -- | -- | -- | -- | -- | -- | --
net/url in Go before 1.11.13 and 1.12.x   before 1.12.8 mishandles malformed hosts in URLs, leading to an authorization   bypass in some applications. This is related to a Host field with a suffix   appearing in neither Hostname() nor Port(), and is related to a non-numeric   port number. For example, an attacker can compose a crafted javascript:// URL   that results in a hostname of google.com. | High | security | HIGH-WATCH-LOCAL | repository:company-docker-temp:company-PCL-ARTIFACTORY | github.com/golang/go | 2020-01-30T10:38:38-05:00 | 1 | HIGH-SECURITY-POLICY
Go through 1.12.5 on Windows mishandles   process creation with a nil environment in conjunction with a non-nil token,   which allows attackers to obtain sensitive information or gain privileges. | High | security | HIGH-WATCH-LOCAL | repository:company-docker-temp:company-PCL-ARTIFACTORY | github.com/golang/go | 2020-01-30T10:38:38-05:00 | 1 | HIGH-SECURITY-POLICY

@gfvirga,
The Dockerfile has been updated to use go 1.14. The latest release of the docker image used this Dockerfile.
Please let us know if the issue is resolved for you.

This is great. I am able to pull it from jfrog artifactory scanned by xray.


Build tor service

Need a container image that reads it's torrc file from a volume. Console can write config to a volume and launch this container with the volume mounted.

Done.


Remove multiline from task title

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/23025
PROPOSAL:   https://github.com/Expensify/App/issues/23025#issuecomment-1638662196
Tests

Test - 1

Click the + icon and select Assign a task
Focus On the title field
Notice on pressing enter on title field should not add a new line to the title field

Test - 2

Click + icon and select assign a task
Enter the title and assign it to a user
Click Confirm Task
On task view page -> Press the title option -> It will open the edit title page
On the edit title page focus on the title field and press enter notice it should not add new line to the field

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Test - 1

Click the + icon and select Assign a task
Focus On the title field
Notice on pressing enter on title field should not add a new line to the title field

Test - 2

Click + icon and select assign a task
Enter the title and assign it to a user
Click Confirm Task
On task view page -> Press the title option -> It will open the edit title page
On the edit title page focus on the title field and press enter notice it should not add new line to the field

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/47522946/e5a9b5e1-2243-46bb-acd4-764f232c47c3
https://github.com/Expensify/App/assets/47522946/fb1594b3-700d-47ee-bdee-24469791beef

Mobile Web - Chrome

https://github.com/Expensify/App/assets/47522946/4f76bf4b-86f5-40f2-83a3-db221c008044
https://github.com/Expensify/App/assets/47522946/3deef9a4-5950-4e9a-8d3a-04a126640faf

Mobile Web - Safari
https://github.com/Expensify/App/assets/47522946/ee48bbd1-a0bf-4cc6-9a8e-0211b9fdb1be
https://github.com/Expensify/App/assets/47522946/dc2d1a9c-95cc-49e3-a320-288601ea7b09

Desktop
https://github.com/Expensify/App/assets/47522946/b587800e-2a5d-4b8f-ab8e-a342ca3bcf76
https://github.com/Expensify/App/assets/47522946/d50f4405-0508-4b0f-99aa-9c3a5c9150cd

iOS
https://github.com/Expensify/App/assets/47522946/28ce23b9-33a0-4628-83c3-c7d16e0fe0b3
https://github.com/Expensify/App/assets/47522946/e5a71789-5699-4f14-a637-7a51516c6ed7

Android

https://github.com/Expensify/App/assets/47522946/66dd5888-fc2b-4d32-aafb-9b42b5b3f9f4
https://github.com/Expensify/App/assets/47522946/57de8247-24ad-4750-be35-4fdcdace5632

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop
https://github.com/Expensify/App/assets/85645967/ac4ce675-6621-48f8-a478-597d2c228c64

Mobile Web - Chrome & Mobile Web - Safari
https://github.com/Expensify/App/assets/85645967/5f144ec0-d78a-46fd-bfac-b872506ef4f7

iOS & Android
https://github.com/Expensify/App/assets/85645967/cec997c3-93b6-482b-95f0-5c97d43fbe17

@dhairyasenjaliya Please make sure you link issue correctly other wise it breaks the automation.
Please link issue like this
$ https://github.com/Expensify/App/issues/23025 ✅
not like this
$ #23025 ❌
Both would look this but make sure you link correctly thanks!
$ https://github.com/Expensify/App/issues/23025

@thienlnam Please update issue linking so other automation don't fail thanks!

I updated the link, should be good now. It was correct before but there was an extra space, not sure if that was why the linking failed

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.46-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.47-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.46-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.47-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


How to pass workspace path in config.json as a runtime parameter.

Describe the problem
1.) While exporting jira issues, we've to update the workspace path every time for a new run, do we have the provision of passing the path as a runtime paramter. KIndly please suggest.

Can we increase the batch size to 50 , will that work while exporting the issues.

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Tool version
jira-azuredevops-migrator tool 2.3.117
Attachments

Please attach the following files:

config.json
jira-export-log.txt
wi-import-log.txt

Screenshots
If applicable, add screenshots to help explain your problem.

Not possible to pass the workspace path as an argument. You will have to script a solution yourself.

I suppose so. Don't see why not


Ollama with ROCm support

Describe the bug
First off, thanks for your support and for the work done with bazzite.
I've been looking through various posts on the Discourse which seem to indicate that:

There was a ujust install script included in Bazzite to install ollama.
This script was later removed as it was to be upstreamed to bluefin.

This should mean that the ujust ollama  mentioned in eg. this post should work, but for some reason it is not present on my system:
username@bazzite:/usr/share/ublue-os/just$ grep ollama ./*
username@bazzite:/usr/share/ublue-os/just$

Not sure if this is expected behavior, if there is some other way of installing ollama (using the script in the ollama site does not support ROCm), or if this is some bug in my setup.
Thanks for any support you can give and if I've made any mistakes.
What did you expect to happen?
Ollama to be installed with ROCm support.
Output of rpm-ostree status
[username]:/usr/share/ublue-os$ rpm-ostree status
State: idle
Deployments:
● ostree-image-signed:docker://ghcr.io/ublue-os/bazzite:stable
                   Digest: sha256:21573bb1aea958466ad2f0065d8a898a2c29485aa57a68324aa39e4dc847bb89
                  Version: v3.6-40.20240809.0 (2024-08-09T21:13:31Z)
          LayeredPackages: sunshine
            LocalPackages: lact-0.5.5-0.x86_64

  ostree-image-signed:docker://ghcr.io/ublue-os/bazzite:stable
                   Digest: sha256:21573bb1aea958466ad2f0065d8a898a2c29485aa57a68324aa39e4dc847bb89
                  Version: v3.6-40.20240809.0 (2024-08-09T21:13:31Z)
          LayeredPackages: sunshine
            LocalPackages: lact-0.5.5-0.x86_64

Hardware
AMD 5600X
32GB RAM
AMD 6700XT
Extra information or context
No response

I'm just a random internet stranger, but i've recently done a PR to update the ollama and open-webui ujust commands in bluefin, and once that's in, i'm planning a PR to bring the just file over to bazzite too. https://github.com/ublue-os/bluefin/pull/1588
But FYI for now, if you just use the just file from the bluefin/just/bluefin-tools.just file on bazzite (just --justfile bluefin-tools.just ollama" it will work if you want to get it up and running right now on your machine.

When we're done in bluefin let's just move it to the config repo, that way it's in both and centralized.

@Gutifarra would you be willing to do a little testing on this PR? https://github.com/ublue-os/bluefin/pull/1588
maybe just try out rhe recipes from the justfile as you have an AMD GPU?

I was able to run it with docker container, using podman. Ill share scripts that I used in a bit.

Looks like it was SELinux,
sudo setsebool -P container_use_devices=true
running this allows podman to access the GPU devices without root.

I tried to get rocm & various tools to run with rocm without success in Bazzite and through Distrobox instances. Namely krita's new LLM implementation, and koboldcpp which itself I could get to run via Distrobox, but I could not compile it with rocm support to enable Vulkan text generation.
rocm is already a huge pain to get running in regular distros, but this seems like a complete roadblock for me, leaving me stuck with pure cpu gen, which is incredibly slow. Would be great to see some ujust script or something to get this going for AMD users.


chore(package): update rollup to version 0.45.0

Closes #49

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff          @@
##           master   #50   +/-   ##
====================================
  Coverage      92%   92%
====================================
  Files           1     1
  Lines          25    25
====================================
  Hits           23    23
  Misses          2     2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 241d046...4ed88ad. Read the comment docs.


[CELEBORN-1455] Remove improper configs from config template

What changes were proposed in this pull request?
To remove improper default configs.
Why are the changes needed?
Many users won't change default configs in the template causing bad performance in test scenarios.
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
GA.

@FMX, could the configs celeborn.master.ha.ratis.raft.server.snapshot.auto.trigger.enabled and celeborn.master.ha.ratis.raft.server.snapshot.auto.trigger.threshold be removed from template, which value use the default value in template?


Add clean-dark-theme to Theme page

I didn't have time to create a new icon, but I have copied the image because I would like to update it in the near feature!

I'd prefer not having a duplicate icon. What about this one:

It uses the same black/blue in your theme and has a free icon I found on iconfinder

Nice, I have added that image

Thank you!


Text chnages on levels if previous levels are not completed.

-‘First complete Level 2, before proceeding with Level 3’ Same for Level 2, when Level 1 is not set up.

@cakesoft-nikhita  Instead of "Setup/upgrade your backup" It should say: ‘First complete Level 2, before proceeding with Level 3’
Similarly for leve 1 incomplete it will say: ‘First complete Level 1, before proceeding with Level 2’

-Verified this issue on dev app v1.6.0(265)


The proptest_derive crate & #[derive(Arbitrary)]

This PR adds the crate proptest_derive to this repo.
The advantage of not having this in a separate repo is that I expect both crates will be easier to maintain and test if they are in a single place. Another crate that does this is serde which sports its serde_derive crate here.
The PR is pretty massive in size (sorry about that) but it is 100% consisting of additions and no code is touched outside of the proptest-derive directory. I recommend checking out my branch and starting from the tests directory to see what is supported and what is explicitly rejected.
I'm sure there are places where the code can be refactored and improved, but I'd like to avoid making too many changes to this PR. We can of course make design changes and code improvements later.
Some things TODO after merging this PR (to a separate branch, not master):

Setup a workspace. Ideally, all the code for the proptest crate should go in its own directory in the root and proptest-derive should also be in the root.

Make sure proptest-derive is tested with Travis CI and AppVeyor CI.  For now, I have not made any changes to .travis.yml but there are plenty of tests (+50% of the code). These should all be run with a nightly compiler (because compiletest_rs wants it for pretty tests and because attr_literals is unstable). Until we've ensured that tests are run, it would be inadvisable to make breaking changes to proptest itself.

I have to give you perms on crates.io so you can publish updates to proptest-derive at the same time as proptest.

Release a 0.1 of proptest-derive.

Here are some TODOs into the future:

We should figure out what to do with self-recursive and mutually-recursive types. These are not supported at all and will blow the stack if attempted.

Write extensive documentation (ideally in the form of an mdbook (see #36)). I haven't had the time to do that yet but I'll start on it ASAP.

Improve error messages with correct spans and such things.

Eventually use the custom error message API in https://internals.rust-lang.org/t/custom-error-diagnostics-with-procedural-macros-on-almost-stable-rust/8113 to segregate errors by warnings and so on...

Sorry for my delayed response here. I'll see if I can work through this this weekend.

Some things TODO after merging this PR

All sound like a good plan to me.

No problem ❤  Take your time! :)

These [tests] should all be run with a nightly compiler

Does the plugin itself work with stable?
I've made a pass through the code and it initially looks pretty good, though there's a lot I don't understand since this stuff is extremely new to me. I'll try to work through it in more detail this week.

Does the plugin itself work with stable?

It should; I think I have tested it on stable a few times, but I don't remember exactly when the last time was, so it is possible I let some mistake slip through.
To make sure everything beside attr_literal (which is getting stabilized soon, https://github.com/rust-lang/rust/pull/53044) tests work on stable, I think it would be a good idea to follow this PR up with one that gates the nightly-only tests behind an unstable cargo feature. We can then use the same testing mechanism we use for stable/unstable in proptest proper.

Did you get a chance to review any more of this?

I haven't. Sorry about that and how unresponsive I've been in general lately. I should have some time soon.

Hey :)
I'd love to make improvements to the proptest_derive crate (for example upgrade the syn version and other changes) but I'd also like to avoid making too many changes to allow you to review the crate more easily.
Any chance you could review this? If you think it's unlikely that you'll get to it in the foreseeable future, I can publish this out of tree, but that will of course make dealing with breaking chances more difficult.

I'm going to set myself a hard commitment this time so I stop letting this slide: I will review and likely merge this on Saturday.

Merging this into the proptest-derive branch. I'll get the workspace and CI set up after that, and if you don't already have docs written somewhere, I'll start on that too.

Is there a reason some of the .rs files have the execute bit set?
...
 create mode 100644 proptest-derive/tests/compile-fail/E0026-strategy-malformed.rs
 create mode 100755 proptest-derive/tests/compile-fail/E0027-filter-malformed-expr.rs
 create mode 100755 proptest-derive/tests/compile-fail/E0027-filter-malformed.rs
 create mode 100755 proptest-derive/tests/compile-fail/E0028-skipped-variant-has-filter.rs
 create mode 100644 proptest-derive/tests/compile-fail/E0028-skipped-variant-has-param.rs
 create mode 100644 proptest-derive/tests/compile-fail/E0028-skipped-variant-has-strat.rs
...

@AltSysrq probably just my editor being silly (using Windows can be painful...). Try running the tests without them and change to 644 or something if the tests all pass... :)

if you don't already have docs written somewhere, I'll start on that too.

No sorry, never got around to writing more docs but I'd like to help out; we can take some inspiration from serde.rs; an mdbook might be fitting here...

Never mind, figured it out

@AltSysrq Hmm... this happened to me sometimes when I was using the wrong path when building locally; so my guess would be one of: a) that the target/ directory ends up in a wrong place, b) compile_test looks in the wrong directory, c) the stuff needed are not in the right directory (configured in https://github.com/AltSysrq/proptest/blob/proptest-derive/proptest-derive/tests/compiletest.rs). It's like a) or b)...
Does this build locally with the branch tested or do you also get errors with that?
I'm about to sleep now, so I'll check it out in the morning if you didn't solve it before :)
...lol :D

@AltSysrq so... what was the problem? =P

https://github.com/AltSysrq/proptest/commit/353b52f8b70e953f6814eb39406605789b5b3162
target is shared by the whole workspace so the directory got moved when I set that up.

Aaah; that makes a lot of sense. :)