Bump agent to 3.9.1

This is particularly because I'm interested in https://github.com/buildkite/agent/pull/931

This would be great because currently skip-checkout: true in the latest docker-compose plugin causes agents prior to 3.9.0 to break (fixed in https://github.com/buildkite/agent/pull/909)

Thanks folks!


ARTEMIS-4467 Core client code visibility change required.

Since the constructors in RemotingConnectionImpl can be used from the server and the client. If the server calling code is in a different classloader then the constructor can't be called.
same for the 'active' boolean property of ActiveMQChannelHandler

Issue: https://issues.apache.org/jira/browse/ARTEMIS-4467

This part of the commit message is not clear to me:

If the server calling code is in a different classloader then the constructor can't be called.

Do you mean that "any code calling the RemotingConnectionImpl constructor in a different classloader will fail"?

@jbertram yes because the constructor is package protected but the package is different because the classloader is different.


Typing greek letters (conveniently)

As discussed in #806, #3315, and #3677 it would be great to be able to type greek letters in notebooks.
Since all such bug reports have been closed without solving the issue, I'd like to suggest to other users looking for help in the issues I'd like to point out the hint in #9362.

I do understand that you don't want to bloat the Jupyter package, but I think it's confusing that in a Python file and in a Jupyter notebook (in vscode) the completion works so differently.

That would be a bug. They should be the same for python code. Or are you referring to Jupyter specific tasks, like LaTeX?

That would be a bug. They should be the same for python code. Or are you referring to Jupyter specific tasks, like LaTeX?

Not sure to get what you mean.
If you open a Python file (with vscode), type \alpha and press TAB, the editor substitutes \alpha with , but the same does not happen if you open a Jupyter notebook (with vscode) and type in a code cell.
What I did not realize is that the completion works in a Python file thanks to yellpika.latex-input extension that seems not to work in Jupyter notebook code cells thoug.
On the other hand, the web interface of Jupyter notebooks supports LaTeX completion.

It's likely yellpika.latex-input extension doesn't support jupyter notebooks.
It is strange that the web jupyter supports LaTeX and we don't though. We use the same underlying service to get completions in notebooks.
Unless you have some extra extensions installed in jupyter too. Oh maybe this one? (https://github.com/latex-lsp/texlab). That wouldn't work in VS code.

Looking at the source for yellpika (https://github.com/YellPika/vscode-latex-input) you might be able to get it to work in a jupyter notebook. The scheme for the selector is wrong is all. It might work if you changed/added the 'scheme' value to 'vscode-notebook-cell'

It is strange that the web jupyter supports LaTeX and we don't though. We use the same underlying service to get completions in notebooks.

Tested now, in a freshly minted virtual environment with just pip install jupyter. If you enter \alpha and TAB in a code cell it is replaced by the unicode letter; that strangely does not happen for markdown cells!

It might work if you changed/added the 'scheme' value to 'vscode-notebook-cell'

It works! That's a very good hint, thank you. I read the extension doc, but was unable to figure out the scheme myself.

Watch out that the order seems to be relevant. This
  "latex-input.selector": [
    {
      "scheme": "vscode-notebook-cell"
    },
    {
      "scheme": "file"
    }
  ]

works, but swapping the two "scheme" dicts does not.

waitwat..?

Tested now, in a freshly minted virtual environment with just pip install jupyter. If you enter \alpha and TAB in a code cell it is replaced by the unicode letter; that strangely does not happen for markdown cells!

I just tried creating a x.ipynb in VSCode FileExplorer, opening it, running a cell (which force-installs ipykernel) and \alpha<TAB> 100% does NOT autocomplete.
This is something I sorely miss. It's super-useful to be able to use greek variables when transcribing from ArXiv ML papers.
Please can team VSCode consider getting this working? Really it's a biggie.

If you read carefully the thread, you see that it works (both in code and Markdown cells) if you just install https://github.com/YellPika/vscode-latex-input and then add https://github.com/microsoft/vscode-jupyter/issues/9363#issuecomment-1272241667 in your settings.json.
Hope this helps.

Does this work also for, say y\tilde + <Tab>?
Jupyter Notebook and Lab both replace y with ỹ.

Thanks for the issue. What more would you want besides what the Greek Alphabet Snippets provides?
I doubt we'd be implementing specific support for the greek alphabet in the jupyter extension, but maybe this request is about more than typing.
Is this more about LaTeX auto complete?

I installed Greek Alphabet Snippets. But don't know how to use it, I am a newbie, Any help please.


fix: bitcoin sends respects account types

Description
after i refactored everything i ignored using account types for bitcoin. the send modal was looking at the portfolio balance for bitcoin - aggregated across all account types. this would try and create sends from the selected account type where a user may not have a balance, causing txs to fail.
Notice
Before submitting a pull request, please make sure you have answered the following:

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[?] Do all new and existing tests pass? Does the linter pass?

Pull Request Type

[x] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
If applicable, please link to the github issue and put closes #XXXX in your comment to auto-close the issue that your PR fixes.
Testing

go to the bitcoin asset page with a wallet with bitcoin
click the send button
ensure the that balance displayed in the send modal is the same as the balance that you have for that account type

Screenshots (if applicable)
n/a

merged with screen share/verbal approval from @natven and @majorhayes


[SPFx-Heft-Plugins][SPFx 1.13.1] elementManifests path resolving differently on Windows and Linux when referencing external file path

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
No response
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[ ] 💥 Microsoft Edge
[ ] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[X] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details
No response
Describe the bug / error
We are working on a solution consisting of multiple SPFx projects, exposed as separate NPM packages. For our customers, we gather these NPM packages into a single SPFx package, joined together in a yarn workspaces project.
This results in a project structure like this:
<root>
├───apps
│   └───demoapp
│       ├───config
│       │   ├───package-solution.json
│       │   └───...
│       ├───gulpfile.js
│       └───...
├───node_modules
│   └───@mycompany
│       └───appcustomizer
│           └───...
├───packages
│   └───appcustomizer
│       ├───config
│       ├───sharepoint
│       │   └───assets
│       │       └───elements.xml
│       └───src
└───package.json

In the example above, in the demoapp SPFx package, one of the packages we are referencing contains an Application Customizer.
For this Application Customizer, we reference the elements.xml from the source NPM package, located in its node_modules directory<EMAIL_ADDRESS>...
"features": [
  {
    "title": "Feature title",
    "description": "...",
    "id": "...",
    "version": "<IP_ADDRESS>",
    "assets": {
      "elementManifests"<EMAIL_ADDRESS>    }
  }
],
...

The issue is however, than when calling gulp package-solution, depending on the environment this path should be different to work:

on Windows this path should be ../../../../../node_modules/... (5x ../)
on Linux this path should be ../../../../node_modules/... (4x ../)

Debugging results
The issue seems to originate in the @microsoft/spfx-heft-plugins package, more specifically in lib/plugins/packageSolutionPlugin/packageSolution/utils/normalizeSolutionDefinition.js.
In this file, the function appendBasePathToFeatureFiles uses path.posix.join(basePath, filename).
It seems that, this function doesn't work correctly when referencing such relative paths.
I checked the basePath and fileName parameters, which return the following:
On Windows:
basePath: C:\...\apps\connect-demo/sharepoint/assets
filename<EMAIL_ADDRESS>
On Linux:
basePath: /mnt/c/.../apps/connect-demo/sharepoint/assets
filename<EMAIL_ADDRESS>
When running path.posix.join on those parameters, depending on the environment, these yield a different result.
Running path.join, however, would return the correct result on both Windows and Linux, for the same parameters.

Hi @NickSevens - sorry, I'm not so good with Linux. But why does the relative path differ? posix namespace is initially created to work with Linux systems.
Is the difference in how yarn workspaces generate the structure?

Hi @AJIXuMuK, the path itself is not the issue. The generated structure is exactly the same on linux and windows.
However, it's the path.posix.join function which returns a different relative structure on either system.
Changing it to path.join (so not the posix version) does work though.
I'm not good with Linux either, but we run our builds on an azure devops linux agent. That's where the issue surfaced. I can also reproduce the same on the Ubuntu WSL prompt.
I'm not sure why the posix part is needed at your end in the plugin? Is it an option to simply change this in a future release? :)
We'd love to see a fix so we can upgrade our projects to the newest SPFx versions - as I assume the future versions will use this build system as well.
PS: I'll try to create a reproduction repo for you guys, if it helps?

@NickSevens - we will make the changes on how the resolution works. You will be able to use the standard node_modules resolution for your scenario.
But it will be included in 1.15 (early beta) only.
For now I'd just play around to find out if some workarounds help (maybe adding ./ at the beginning of the elements file path)

This has been fixed and released in the latest 1.15 beta


Fix synchronization bug in repo indexer (#3455)

Backport of #3455.

Somehow tests fail for backport :(

@ethantkoenig can you check out why tests fail?

@lafriks I was unable to figure out why the test failed, but a rerun passed


To mitigate github degraded perf [databricks]

Github performance degradation (they do not always post incidents at the status page) is becoming increasingly frequent.
We've added a default three-time retry to the Jenkins checkout function for internal pipelines, but this doesn't always resolve the issue if the service remains unstable for a long period.
some content may also be broken in a some CDN in the previous github incidents. And people should wait some hours until cache gets refreshed.
Lets try add some retry and longer clone timeout to mitigate the issue

build

build

Close this one as it won't be very helpful in this case


[Feature Request] Support video calls "Huddles" within zulip

Use Case:
As teams across the world are working remotely, the ability to have spontaneous audio conversations is becoming increasingly important. Adding the Huddles feature would allow Zulip users to quickly address questions, discuss ideas, or have an informal catch-up without leaving the platform.
Proposed Implementation:

Ability to initiate an audio call with one or multiple team members through Zulip.
Ability to join and leave the Huddle seamlessly.
Notification for users when a Huddle is initiated.
Minimal UI to avoid clutter and maintain the user-friendly nature of Zulip.

Benefits:

Improves real-time communication capabilities within Zulip.
Reduces the need for external tools for quick discussions.
Increases collaboration and team productivity.

Soution proposal
Use https://github.com/security-union/zoom-rs as the backend to route media and maintain huddle rooms.
Thank you for considering this feature request. I believe that this feature would be a fantastic addition to Zulip and benefit many users.
Warm regards,
Dario

@zulipbot add "new feature"


Projections don't work when changing JSON Settings

I have not verified this using Newtonsoft.Json but it's a bug that affects System.Text.Json.
Given the following:
            x.Serializer(new SystemTextJsonSerializer
            {
                EnumStorage = EnumStorage.AsString,
                Casing = Casing.Default
            });

If you have a document such as:
public class Player
{
    [JsonInclude]
    public int Id { get; private set; }

    public string Name { get; set; }

    public decimal Level { get; set; }

    public PlayerStatus Status { get; set; }
}

And you want to project this to say:
public class PlayerResponse
{
    public string Name { get; set; }

    public decimal Level { get; set; }
}

Querying like:
var skills = await conn.Query<Player>()
                       .Where(x => x.Status == PlayerStatus.Banned)
                       .Select(x => new PlayerResponse
                       {
                           Name = x.Name,
                           Skill = x.Skill
                       })
                       .ToListAsync();

This works... HOWEVER, if you (wipe the database, and start fresh) change the configuration:
            x.Serializer(new SystemTextJsonSerializer
            {
                EnumStorage = EnumStorage.AsString,
                Casing = Casing.CamelCase
            });

Everything works perfectly until you get to the project.
It issues a query like so:
select jsonb_build_object('Name', d.data ->> 'name', 'Level', CAST(d.data ->> 'level' as decimal)) as data
from game.mt_doc_player as d
where d.data ->> 'Status' = :p0;

This results in a collection of empty objects. Name is null and Level is 0.
I believe this is due to PropertyNameCaseInsensitive not being set to true in the serializer.
So there's 2 ways we can fix this I believe...

Change the serializer to be case insensitive. (This is my preferred approach)

Change the querying to use the same casing as the properties of the JSON. i.e

jsonb_build_object('name', d.data ->> 'name')
Name -> name since the data property is name.

@phillip-haydon
"

Change the serializer to be case insensitive. (This is my preferred approach)

Change the querying to use the same casing as the properties of the JSON. i.e
"

Number 1 isn't feasible. Number 2 is already the behavior, so I'm not sure what you want to happen here. The default casing means that the Json is assumed to exactly match the property or field name.
If you're changing how the JSON is serialized, yeah, you're gonna break things and I don't know there's anything we can do about that. You can use the patching to migrate the data.
I'm converting this to a discussion for now.


feat(clerk-js,types): Restructure localization object

Description

Checklist

[ ] npm test runs as expected.
[ ] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/backend
[ ] @clerk/chrome-extension
[ ] @clerk/clerk-js
[ ] @clerk/clerk-expo
[ ] @clerk/fastify
[ ] gatsby-plugin-clerk
[ ] @clerk/localizations
[ ] @clerk/nextjs
[ ] @clerk/clerk-react
[ ] @clerk/remix
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/themes
[ ] @clerk/types
[ ] build/tooling/chore

Closing this in favor of https://github.com/clerk/javascript/pull/2537


Network timed out while trying to connect to any package

While trying install ANY package next error appeaser:
Network timed out while trying to connect to https://index.docker.io/v1/repositories/library/celery/images. You may want to check your internet connection or if you are behind a proxy.

My network is fine and it worked okay before weekend.
Kitematic running directly on OS X
UP. Looks like hub is okay https://status.docker.com/
UPUP:
If I restart kitematic old package (which frilled with "Network timed" before) will download perfectly okay. But new containers will fail with same error.

Seems like an issue with your VM - I would simply issue a restart of it via:
docker-machine restart default


Made cape parented to character and massless

Fixed some issues with capes on R15 and made it Massless.
https://user-images.githubusercontent.com/54174182/177046556-cddea334-e160-4991-a7ad-6b58a010323c.mp4

Forgot CanQuery to false and idk how to fix it so yes

doesn't this break the disable capes setting in the client?

well does it?

might have issues; needs testing

(idk if its related)

The .Massles and the .CanQuery additions make sense, but I don't see why it should be parented to the character, it could cause potential issues too.

so its hidden when in first person it can be annoying at times

btw some stuff broke with this trying to figure out atm

The .Massles and the .CanQuery additions make sense, but I don't see why it should be parented to the character, it could cause potential issues too.

This issue could be mediated with a setting for it but I imagine adding a new setting is hard to do, due to older clients

it being parented to the character makes it so you cant see it in first-person

so its hidden when in first person it can be annoying at times

HELLO!
You can write custom code into the client to handle cape hiding in first person.
This custom code can also be used to hide capes on the client with the hide capes setting, if you so cared. Alternatively use real Instance.Transparency like a non-degenerate would.

@DaEnder  Did you forget about this lol?

no im lazy

@Expertcoderz Merge when.

@Expertcoderz Merge when.

I'll do a bit of testing and get it merged by the next 24 hours from now.

Ok


Add caching to BuildKit engine

Is your feature request related to a problem?
Partly. BuildKit can use cache for building and can build an image faster.
Which solution do you suggest?
Integrate to DevSpace support of caching for BuildKit engine (see buildx's cache-from, cache-to and BuildKit's --export-cache, --import-cache for details).
Which alternative solutions exist?
Using custom command build engine or Args field of BuildKit builder engine.

/kind feature

@saruman9 thanks for creating the issue! Whats wrong with using images.build.buildKit.args?

After properly testing args, I can say that I can use it in this form (without additional fields for parameters of caching). Excuse for troubling.

@saruman9 can you explain what you did here?

@danielloader,
It was 2 years ago, at the moment I don't have an up-to-date version of the code. Then I did this:
[...]
    images:
      IMAGE:
        build:
          buildKit:
            args:
            - --cache-to=type=registry,ref=${IMAGE_CACHE_PATH}/${PROJECT}/${PROJECT}-cache:${IMAGE_CACHE_TO_TAG},mode=max
            - --cache-from=type=registry,ref=${IMAGE_CACHE_PATH}/${PROJECT}/${PROJECT}-cache:${IMAGE_CACHE_FROM_TAG}
            inCluster: {}

[...]


odata.nextLink containing filter doesn't work

Describe the bug
If an API request was created containing a $filter parameter, the<EMAIL_ADDRESS>value will not work in a subsequent request.
To Reproduce
Perform a GET request with a filter: https://graph.microsoft.com/v1.0/users?$filter=accountEnabled eq true
Should have a response like:
{
<EMAIL_ADDRESS>"https://graph.microsoft.com/v1.0/$metadata#users",
<EMAIL_ADDRESS>"https://graph.microsoft.com/v1.0/users?$filter=accountEnabled+eq+true&$skiptoken=RFNwdAoAAQAAAAAAAAAAFAAAAJtOSvz52nxApH5XfVRmVjwBAAAAAAAAAAAAAAAAAAAXMS4yLjg0MC4xMTM1NTYuMS40LjIzMzEGAAAAAAABMJZSI_m8aECg6iZQykCENAEbAAAAAQAAAAA",
  …
}

Note the spaces in the original filter are switched to a +

If you attempt to use the full odata.nextLink, you will receive an HTTP 400.
{
  "error": {
    "code": "BadRequest",
    "message": "Invalid filter clause",
    "innerError": {
      "date": "2021-08-25T16:51:41",
      "request-id": "6a1bd9e8-07a5-4439-b171-c8295ee79e41",
      "client-request-id": "6a1bd9e8-07a5-4439-b171-c8295ee79e41"
    }
  }
}

Manually changing the + characters to spaces fixes the issue.
Expected behavior
Should be able to use the nextLink without modification.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Mac OS 10.15.4
Browser: Insomnia REST Client (similar to Postman)

Additional context
This ticket was originally submitted to Microsoft Support and was directed here.
AB#10886

@thewahome any update here?


Improve CLI for gitzap

[!NOTE]
@mohammadzainabbas: add the following options for gitzap CLI

[ ] Add same CLI options as update_git python program
[ ] Add additional iteractive option.

[!TIP]
Use crates like cliclack or dialoguer for iteractive option.

[!WARNING]
Execute update_git python script from anywhere.

python ~/.scripts/python/update_git.py -h

[!IMPORTANT]
Below mentioned is the current help for update_git python script.

usage: python update_git.py [-h] [-p [Path]] [-t int] [-dr] [-q]

Add, commit and push code from a git repo to GitHub.com

This script automates the process of adding, committing, and pushing changes to a GitHub repository. It's a convenient tool for regular updates to your codebase. Ensure that you are in the root directory of your Git repository before running this script.

options:
  -h, --help            show this help message and exit
  -p [Path], --path [Path]
                        Path for git repo. (default: ~)
  -t int, --time int    Push code after this many seconds (default: 20)
  -dr, --dry-run        Dry run! Just show the config, but do not actually do anything. (default: False)
  -q, --quite           Quite mode. Don't show any logs. (default: False)

Getting started

1. Run the program directly like: (RECOMMENDED)

python ~/.scripts/python/update_git.py

2. Copy the script from ~/.scripts/python into current directory and run it like: (NOT RECOMMENDED)

cp ~/.scripts/python/update_git.py . && python update_git.py

How it works ?

a) First, script performs sanity checks to make sure that current directory or the directory being passed is a valid git repo with .git/config file.

b) It add, commit and push changes from local branch to remote branch if there are any changes detected via 'git status --porcelain'. If there is no change detected and/or after pushing to Github.com, it will sleep for <t> seconds

Usage examples:

1.  python ~/.scripts/python/update_git.py or python ~/.scripts/python/update_git.py -p .

Run script in current directory.

2.  python ~/.scripts/python/update_git.py -p ~

Run script in ~ directory.

3.  python ~/.scripts/python/update_git.py -p ../mohammadzainabbas.github.io/

Run script in ../mohammadzainabbas.github.io/ directory. Relative path

4.  python ~/.scripts/python/update_git.py -t 60

Add, commit & push changes after 60 secs.

5.  python ~/.scripts/python/update_git.py -q

Quite mode. Run script with no logs. However, error messages will still be shown.

6.  python ~/.scripts/python/update_git.py -dr or python ~/.scripts/python/update_git.py --dry-run

Just show the config, but do not actually do anything.

7.  python ~/.scripts/python/update_git.py -h

Show help message and exit.


using new github features

removed the normal template because this doesn't really fit that.
Github recently announced two new features.  I think we should discuss enabling them (or not).

commit squashing on PR merge.

https://github.com/blog/2141-squash-your-commits
https://help.github.com/articles/about-pull-request-merge-squashing/
I'm not quite sure how it would handle the commit messages.  We've also been pretty good about not letting though multiple commits in a single PR without good reason.  So I personally don't see the need to enable this.

better protected branch settings

https://github.com/blog/2137-protected-branches-improvements

we can allow merging out of date PRs now, this was the main reason we turned it off I think.
we can also limit who the 'core' reviewers are, or who can hit the button, could be useful for permission limiting.

I'd like to see us re-enabling protected branches, possibly using/defining a specific team as 'core' reviewers.

I don't think we should squash commits, although generally there should be only one commit per pull request sometimes it's useful to have the option.
I agree with enabling 'Require status checks to pass before merging' but not 'Require branches to be up to date before merging'. While it would be preferable to have testing done on the rebased commit this gives us a better guarantee than we currently have without creating a manual overhead.

Branch protection has been enabled with particular status check set as required.


Add addFormat support for number formats

Fixes #90. format is now also supported by numeric types.

Coverage decreased (-0.9%) to 90.862% when pulling b8f73e3c3ee36e43e0a87a13ae432b44e23298d7 on edgarmueller:master into ed028e0dbc366dc623ace8335e5437284f16ff18 on eclipsesource:master.


test(environment): add environment playground

Description
I added a minimal ssr environment example including my normal e2e testing setup.
Probably it's not ideal to have react specific playground (even though it doesn't use react plugin) and also playwright based testing, but I thought it might help to have this while iterating on environment PR.
This also includes a build fix from PR https://github.com/vitejs/vite/pull/16298.

This is great! I think we should merge it as it will be really helpful. But first, I think it is worth refactoring the test to use our regular e2e test infra.
And we can merge https://github.com/vitejs/vite/pull/16301 with the fix only, removing the playground.

Thanks for the review! Yeah, I'll replace playwright with vitest e2e.
For the other PR https://github.com/vitejs/vite/pull/16301/, I just removed the playground part.

I rewrote it in vitest e2e, but maybe this might be a little unusual setup. A few ideas I have is:

use expect assertions from @playwright/test
custom serve.ts with execa to directly invoke pnpm dev/build/preview

To me, this approach feels right as e2e, but probably this is a bit opinionated. Please let me know if it should be further aligned with existing e2e tests.

Also it looks like typecheck is failing on CI, but not sure what's wrong. When I run pnpm run typecheck locally, it's working:
$ pnpm run typecheck

> @vitejs/vite-monorepo@ typecheck /home/hiroshi/code/others/vite
> tsc -p scripts --noEmit && pnpm -r --parallel run typecheck

Scope: 212 of 213 workspace projects
packages/create-vite typecheck$ tsc --noEmit
playground typecheck$ tsc --noEmit
packages/vite typecheck$ tsc --noEmit
packages/create-vite typecheck: Done
playground typecheck: Done
packages/vite typecheck: Done

The setup looks good to me, but I think we should align with the rest. And we can discuss later about why you think this is better and maybe move all the playgrounds to implement some of these ideas. Except if there is a very good reason that prevents you to aligning.

Except if there is a very good reason that prevents you to aligning.

Actually test-serve just worked as is, but for test-build to work, it needs to change vitestSetup.ts since it uses programmatic way of running vite build and vite preview.
The reason why I like this setup is it tests the same layer as what users would use from cli. But, non-programmatic usage cannot directly assert things only accessible programmatically like viteServer etc... exported fom vitestSetup.ts, so it has less flexibility.
Should I try programmatic usage of vite builder?

Yes, I think programatic usage of vite builder would be good here. That is a good test too.
We have a CLI playground where we could test later the CLI side of things, but it is a very thin layer, we don't miss that much coverage by using ViteBuilder directly.

OK, actually it was simpler than how I struggled with custom serve.ts. I exported createViteBuilder and just used it like build --all CLI.

Awesome! Thanks for adapting the test 🙏🏼
The fails are the same as we have right now in feat/environment-api. @sheremet-va should we skip this test for now there?

This is great!


Communication method for new topologies

Is there any preferred method of communication between processes? In particular using the underlying Erlang Node connections vs implementing something using gen_tcp or equivalent.

In general, from what I've heard in "battle stories" it might be advantageous to use the erlang distribution as a control plane and have separate tcp connections for actually sending data.
Right now big messages may clog the pipe and stall the heartbeat messages leading to a disconnection. At Lambda Days Peer (from GRISP) said, though, that they are looking into fixing this one.
Another consideration is that things like partisan don't use the default message sending and implement a completely separate layer for sending messages across processes (there might be even multiple "channels" between nodes). If we want to leverage this, I think we should do some sort of interface for delivering a message instead of using the built-in send.

The topology handles the remote pid communication. So our default disterl topology will use send, but others can implement their own mechanisms.

@callback send(t, node, name, message :: term) :: :ok | {:error, term}
But in the case of using something akin to gen_tcp, wouldn't the node have to be an IP? At most, we can assume the topology can internally map nodes to IP addresses or sockets.

The topology by definition would be responsible for translating the node name to something meaningful for it's transport. The most trivial example could be using DNS A records to get an IP in the case of using :gen_tcp - in fact I think that's more or less how disterl does things today when you get down to the meat of it.


As a starting point loading pretained paliGemma weights into PiZero model

You need to have access to the gated PaliGemma model weights from the hugging-face to try this example code.

to address https://github.com/lucidrains/pi-zero-pytorch/issues/1

@ramkumarkoppu hey Ram, this looks like a start, but you didn't actually map the parameters of each layer to the ones here

it should be doing here:
Map weights from PaliGemma to π₀ model. This example assumes a direct mapping
for simplicity. You may need to customize this based on layer compatibility.
for name, param in paligemma_state_dict.items():
if name in pi_zero_state_dict:
pi_zero_state_dict[name].data.copy_(param.data)

I see, no worries, I'll take care of it

is this the (https://github.com/lucidrains/pi-zero-pytorch/blob/main/pi_zero_pytorch/pi_zero.py#L592)  existing method to load weights?

Hi Phil, Check the updated code in the PR, hopefully this will address the issue, let me know your thoughts.

hey Ram, that doesn't look right, as my modules aren't named one-to-one to the hf implementation
you need to identify the key weights and biases of attention, feedforward, embedding, and unembedding layers here and from hf and match them up and load them. then you need to test it by running an input and asserting that the logits are equal
that's ok if it is too difficult, i can take care of it before end of month.

Hi Phil, understood, I may make further changes and test it in my forked branch and will create a PR if it works. do you want this PR to be open or shall I close it? or do you want it to be opened while we both working in separate branches?

@ramkumarkoppu i would say close it for now, thank you for the effort Ram!

I will try to make further changes and test it in my forked branch and will create a PR if it works


Unclear if local cache actually excludes any directories.

The documentation indicates that "As part of the step that copies the storage content, any folder that is named repository is excluded". Having deployed an app with local cache enabled to an S2 App Service plan in US West, I've observed that a folder named "Repository" was still copied to the local drive. The observed behavior is by far preferable to automatic exclusion of content based on name.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3875bb58-b3bb-d12c-9e8f-6a60ac7fb49b
Version Independent ID: 9bb25e56-90de-4a2f-389d-40e983a1e5c1
Content: Azure App Service Local Cache overview
Content Source: articles/app-service/app-service-local-cache-overview.md
Service: app-service
GitHub Login: @SyntaxC4
Microsoft Alias: cfowler

@obviousSailfish Have you checked the spelling. The doc references lower case but you mentioned that you used an upper case for your folder name. Have you verified that the setting is not case sensitive? Also, how are you measuring that the folder is actually copied over? Using the CMD feature of KUDU is not rigid because it shows the log folders, which are not copied over as part of local cache. So if you see the folder in KUDU's CMD feature, it doesn't necessarily mean the content is actually stored in local cache.
Your files are technically stored in two places when using local cache. Both on the file server (traditional location when not using local cache) and locally on the VM itself.


Adding support for 32-bit binaries on Windows.

An alternative implementation (and possibly a better one) would be to allow arch as an optional argument to nox.session. For example:
@nox.session(python=["2.7", "3.7"], arch=["32", "64"])
def tests(session):
    session.install("pytest")
    session.install("-r", "requirements-dev.txt")
    session.install("-e", ".")
    session.run("py.test")

This would also give a "solution" to #60.
The real silly thing: I'm not sure anyone cares about 32-bit support. I used to test my OS X binaries for bezier in 32-bit, but then NumPy discontinued 32-bit support on OS X. Maybe that's a different beast since Apple controls the hardware?

PS Sorry for sending a PR without a corresponding issue. Consider this PR a point for discussion as much as anything. I.e. let's close it if it seems like a bad idea.

I feel like Nox should still support testing against these interpreters.
How well does Tox deal with this issue?

I don't see any mention of it in tox docs, so it's unclear. (I am a bit scared to boot to Windows on my local machine, I could spin up AppVeyor to find out what `tox does?)

If you don't mind doing the research.

So AFAICT, the recommendation is to use tox -e py, which just defaults to the Python version where tox is installed. From the packaging guide:

In order to run tests using tox, therefore, projects should probably
use the default py environment in tox, which uses the Python
interpreter that was used to run tox. This will ensure that when
AppVeyor runs the tests, they will be run with the configured interpreter.

I ran a simple config and confirmed this works. From the tox source it seems clear there is no support for declaring 32-bit or 64-bit.

Okay, looking at this implementation I'm not sure how I feel about the environment variable functioning as an extra argument here.
Could we do something like:
@nox.session(python=['3.6', '3.6-32'])

I also don't feel great about using an environment variable. I used PYTHON_ARCH because those before us have done this for AppVeyor scripts.
There are only two architectures, but you'd still end up with a doubling of options (versus just adding a two-element list). For example:
@nox.session(python=["2.7", "2.7-32", "3.5", "3.5-32", "3.6", "3.6-32", "3.7", "3.7-32"])
def foo(session):
    ...

@nox.session(python=["2.7", "3.5", "3.6", "3.7"], arch=["32", "64"])
def foo(session):
    ...

Hrm, the section option doesn't let folks do things like "only test 32 bit python 3.7".
@lukesneeringer and I discussed a syntax like this previously:
@nox.session(python=['3.6', nox.python('3.6', arch='32')])
def tests(s):
    pass

WDYT?

My initial reaction was that I liked it. Then I thought about the implications a bit and liked it less, mostly because it makes the implementation more complex since it has to support "strings, AND ..." as the expected type. I think your suggestion of 3.6-32 is better and it has precedence: py -3.6-32 is the preferred way with the Python Windows Launcher.
As for your

the section second option doesn't let folks do things like "only test 32 bit python 3.7".

I don't think it's actually a reason not to do it. arch is largely irrelevant on Linux and probably on OS X for most users. So the "extra" environments containing arch would only ever need to be run on Windows (or a Windows CI). (I realize this breaks the bare nox.)

Hrm, so which direction are you leaning closer to now?

Okay, so what would be the behavior for those things on Linux/Mac?

I think on Linux it'd just be a skip? Or some text UI version of a NotImplementedError?
On Mac it's possible, but there are a few sharp corners, but I'm happy to write code / give advice.

Cool, I'm happy with that as long as we have well defined cases for that.
On Thu, Aug 23, 2018 at 1:31 PM Danny Hermes<EMAIL_ADDRESS>wrote:

I think on Linux it'd just be a skip? Or some text UI version of a
NotImplementedError?
On Mac it's possible, but there are a few sharp corners, but I'm happy to
write code / give advice.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/theacodes/nox/pull/100#issuecomment-415561368, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAPUc6gtYi5GL2nP35nTCbqq_4ucd5zbks5uTxEtgaJpZM4WIaPK
.

@dhermes is this ready? It seems to still be failing on Travis.


Add support for providing CI_JOB_TOKEN

Using the current options lib users can only provide personal access token. I want to use the Gitlab's CI_JOB_TOKEN in my comment stage as it is much safer.
According to gitbeaker docs the job token should be provided in another config.
Can we add an option to provide a job token? Are you open to a PR on this?

How to reference CI_JOB_TOKEN as GITLAB_TOKEN in variables?

Like this:
variables:
   GITLAB_TOKEN: "${CI_JOB_TOKEN}"

Like this:
variables:
   GITLAB_TOKEN: "${CI_JOB_TOKEN}"

If you confirm it works, it can be added into README.

I'm actually using my PR code in a real-world project. (by using Github protocol)
I'm using CI_JOB_TOKEN as NPM_TOKEN actually. As I mentioned in #23 JobToken access is still limited to Gitlab package registry so I cannot use it in the comment stage until a Gitlab Epic that adds fine-grained JobToken access gets resolved.

OK, then it should be mentioned that the functionality is not ready for now in changeset.

Done


Update Readme- Travis CI Build and Code coverage

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #138   +/-   ##
========================================
  Coverage      35.5%   35.5%
  Complexity      233     233
========================================
  Files            62      62
  Lines          1656    1656
  Branches        183     183
========================================
  Hits            588     588
  Misses         1027    1027
  Partials         41      41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 763ac17...38eb546. Read the comment docs.


Think about to fix the issues found by adapter checker

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:
https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/iobroker-community-adapters/ioBroker.upnp

[x] [E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: "npm owner add bluefox iobroker.upnp"
[ ] [E405] Icon must be in the following path: https://raw.githubusercontent.com/iobroker-community-adapters/ioBroker.upnp/master/
[ ] [E407] Meta URL(latest) must be equal to https://raw.githubusercontent.com/iobroker-community-adapters/ioBroker.upnp/master/io-package.json
[ ] [E426] Icon(stable) must be in the following path: https://raw.githubusercontent.com/iobroker-community-adapters/ioBroker.upnp/master/
[ ] [E428] Meta URL(stable)  must be equal to https://raw.githubusercontent.com/iobroker-community-adapters/ioBroker.upnp/master/io-package.json
[x] [E802] No topics found in the repository. Please go to "https://github.com/iobroker-community-adapters/ioBroker.upnp" and press "Manage topics"

I have also found warnings that may be fixed if possible.

[ ] [W113] Adapter should support compact mode

Thanks,
your automatic adapter checker.

Thanks, that all bugs have been fixed.


Your Warp script gives Errors during installation.

Hi and thanks for the nice work.
fscarmen's Warp repo has been disabled by github.
https://github.com/fscarmen/warp
Since your script pulls data from that repository, it chokes in the middle of the installation.  Although fscarmen claims to be back in two days, (I'm assuming he/she is trying to remove some codes to comply with github policies) I hope you have a fork or clone of that repository somewhere in case the main Repo never comes back.
I also hope there's no automatic update set up anywhere in your script or in 3x-ui because that will most likely break everyone's installation.
Cheers.

same problem .
'  [ERROR] Sorry, the installation of WARP socks5 proxy (WireProxy) failed! Please try again later.'
as the OP says its due to a problem resulting in the og repo getting suspended

They've moved their Repository from github to gitlab. You may want to update your scripts.
https://gitlab.com/fscarmen/warp

Thank u for informing me.


Needs the functions in Data.Text.Lazy.Builder.RealFloat

Perhaps it would be possible to reuse the Haskell code in those modules?  It looks like it might work just fine without being rewritten in JS.

Fixed by #6


Some cleanup

This gets rid of trailing spaces in both source and generated files, formats docstrings as multiline python strings, and, most importantly, cleans up helper motor functions.
There is no need to create _properties dict and _helper() function.  setarg(self, key, kwargs[key]) will access the correct property and deal with property type (string, int, etc) automatically.

Thanks @ddemidov - I like the changes. I'm going to remove the helper section that I added as a test to spec.json next


Create Crystal.gitignore

Taken from the Crystal compiler's project init feature. Gitignore created by @flaviut.
What is it?
Crystal is a language derived from Ruby, compiled for the LLVM. Because it's only syntactically similar to Ruby there are some differences which should be taken into account.
What is being ignored?
Files created by the compiler in a normal session are being ignored here. .deps is where the compiler pulls in dependencies declared in a project's Projectfile. libs is similar is that it is external code downloaded later. .crystal is contains the LLVM bytecode created by the compiler at compilation. doc is well documentation. And .deps.lock is comparable to a Gemfile.lock.
Why?
Crystal is a fairly new language which has been recently gathering a following. Thought it would be nice for new Crystal projects on GitHub projects to be created with a proper gitignore.

/cc @asterite @bcardiff @waj @jhass

:+1: LGTM for the time being.
Things might change a little when dependency system get more mature towards 1.0.
Thanks @k2b6s9j
NB: The submitted .gitignore is consistent with the built in crystal init command which uses https://github.com/manastech/crystal/blob/master/src/compiler/crystal/tools/init/template/gitignore.ecr

Since 0.8.0 release Crystal use shards to resolve dependencies and .gitignore need to be refreshed:
.deps -> .shards
.deps.lock -> shard.lock

This PR has gone outdated and superseded by #2309. However, considering that this is my oldest sitting Pull Request at 2 years and 5 days it seems unlikely that GitHub will take in new language gitignores. 😒  That being said I've been using @joeblau's gitignore.io personally and it works great.


fetch upstream + aof-PR

Note:
The experimental feature flag is enabled.

This PR is obsolete, dropping it.


Select Product Area

User story

As a consultant
I want to select a product area
So that I can work on products sorted in this field

Acceptance criteria

Criterion 1
Criterion 2
...

Definition of done

Added only after week 5
The same for all features

Issues was aborted


Salesforce release "Check for Null Record Variables or Null Values of Lookup Relationship Fields in Process and Flow Formulas" black calculation of DLRS

Hi community,
I had a big challenge today with a roll up with DLRS for one specific client. Since yesterday their daily rollups did not calculate anymore.

I did what i normally do, check if there is still a job that blcoks calculating. There were none.
Checked the remote site setting, that was disconnected so i made a new one via the welcome page of DLRS.
Still if I try to manually calculate them I keep getting the error that there is possibly a job still there. There really arent's I even hard deleted the old jobs in the recycle bin but it didn't change anything.
I tried redeploying the chill trigger but it didnt change.
We had Salesforce release update we tested yesterday that was still in test mode (Check for Null Record Variables or Null Values of Lookup Relationship Fields in Process and Flow Formulas).

I do not see the link between DLRS and this update and why it would touch each other. But after the 10th of january that update is required and we can not turn it off again. So from then on we expect DLRS not to work anymore.
The weird thing is I tested this with another client and there the roll ups keep working even if i put that test mode on. So it's seems to be very client specific. Because most of our clients use DLRS I am a bit afraid this is going to be a big issue after the 10th.
So my concrete questions are:

What is the link between DLRS and Release update: Check for Null Record Variables or Null Values of Lookup Relationship Fields in Process and Flow Formulas?
Are more people experiencing this?
Is there a known workaround/solution for this?

Kind regards
Frederic Jacobs
Bluedesk CRM

Salesforce update documentation: https://help.salesforce.com/articleView?id=release-notes.rn_forcecom_flow_release_update_formula.htm&release=228&type=5

I have not tested this yet, but I am definitely concerned as the enforcement date is approaching.  @afawcett can you provide some info?

I have not tested this yet, but I am definitely concerned as the enforcement date is approaching.  @afawcett can you provide some info?

Hmmm yes this is a very odd association indeed - the tool does not use process builder at all internally and it looks like your not using the feature to call  rollup from process builder - so.... yeah very odd. If you clear all records in "Lookup Rollup Calculate Jobs" object you should not get the error you are talking about. The latest version of the tool has some changes to this area, please take a look and also read the README file and install notes as there is some post install steps to consider. Sorry I cannot be of more use on this - i honestly cannot see a connection - hope this helps some. Andy.


Support for windows IOCP (input/output completion ports) another completion-based async API

We are only planning to support io_uring for this crate, and not IOCP or IoRing (another Windows API).


[Bug]: top-level await does not work with libraries when enabled (and is not supported out of the box)

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
Use npm create solid to make a basic app, then put a top-level await something in a module, and you'll get an error during npm run build like so:
 ERROR  Transform failed with 1 error:                                                                               10:24:53 AM
/Users/trusktr/src/showcase/.vinxi/build/ssr/ssr.js:1:17460: ERROR: Top-level await is not available in the configured target environment ("es2019")

Expected behavior 🤔
It should just work out of the box. It works in all JS runtimes and browsers out of the box.
Steps to reproduce 🕹
Problem 1:
Steps:

npm create solid
put an await something() at the top level of a module
run npm run build
see error in terminal after loading the app in browser

The error will look something like this:
 ERROR  Transform failed with 1 error:                                                                               10:24:53 AM
/Users/trusktr/src/showcase/.vinxi/build/ssr/ssr.js:1:17460: ERROR: Top-level await is not available in the configured target environment ("es2019")

To fix the problem, the following will not work:
export default defineConfig({
	vite: {
		build: { target: 'esnext' },
	},
})

but one would think that it would, because this is what we see when we look at intellisense:

In the screenshot we can see that the auto-completion in VS Code will give us a strong hint that setting this option will work. But that's not the case (when it comes to application code).
Instead, we must set a different option of the same name at another location, which is not so obvious considering that Vite uses esbuild and one may very well assume the vite esbuild config will do the trick:
export default defineConfig({
	server: {
		esbuild: { options: { target: 'esnext' } },
	},
})

Problem 2:
If you import a library from npm that has top-level await, there's no way to make it work. Setting either of the two options above will not work!
Steps:

npm create solid
npm install yoga-layout
npm run dev
see error in terminal after loading the app in browser

The error will look something like this,
✘ [ERROR] Top-level await is not available in the configured target environment ("chrome87", "edge88", "es2020", "firefox78", "safari14" + 2 overrides)

    node_modules/yoga-layout/dist/src/index.js:13:26:
      13 │ const Yoga = wrapAssembly(await loadYoga());
         ╵                           ~~~~~

8:19:44 PM [vite] error while updating dependencies:
Error: Build failed with 1 error:
node_modules/yoga-layout/dist/src/index.js:13:26: ERROR: Top-level await is not available in the configured target environment ("chrome87", "edge88", "es2020", "firefox78", "safari14" + 2 overrides)
    at failureErrorWithLog (/Users/trusktr/src/showcase/node_modules/vite/node_modules/esbuild/lib/main.js:1472:15)
    at /Users/trusktr/src/showcase/node_modules/vite/node_modules/esbuild/lib/main.js:945:25
    at /Users/trusktr/src/showcase/node_modules/vite/node_modules/esbuild/lib/main.js:1353:9
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

which as you can imagine is frustrating because yoga-layout is a 3rd-party library, and the neither of the two target configs is helping.
The error says my target environment is chrome87. Why is that, if I've specified esnext, when is comes to the node_modules dependency?
Context 🔦
All JS runtimes support top-level await natively for a long time now. Solid Start should too!
Your environment 🌎
npmPackages:
❯ npm ls
showcase@ /Users/trusktr/src/showcase
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

Reproduction: https://github.com/lume/showcase/tree/solid-start-issue-1614
git clone git@github.com:lume/showcase.git
cd showcase
git checkout solid-start-issue-1614
npm ci
npm run dev # see error

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

^ spam?

Workaround:
A workaround is to do a native import() inside eval() (to avoid the compiler handling it):
// If using typescript, type-only `import` will be fine
import type {Node} from 'yoga-layout'

function getYoga() {
	const [yoga, setYoga] = createSignal<typeof import('yoga-layout')>()
	const promise = eval("import('https://unpkg.com/yoga-layout@3.1.0/dist/src/index.js')")
	promise.then(setYoga)
	return yoga
}

// ...

			const yoga = getYoga()

			createEffect(() => {
				const yogaModule = yoga()
				if (!yogaModule) return
				const {default: Yoga, Direction, FlexDirection, Gutter} = yogaModule

				// ... use yoga as before ...
			})

This seems somehow related to the issue of effects not running. https://discord.com/channels/722131463138705510/1275456175462420614
In the above case, I was able to cause effects not to run due to the presence of await import() inside of components, and was able to workaround by setting ssr:false in app.config (only for dev mode, prod mode is not working at all), although maybe this is just a secondary effect of the real issue.

Looks like server.esbuild.options.target is in fact passed to Nitro. So Nitro needs an update so that it will handle node_modules?

I took Nitro for a spin, looks like it supports top-level await out of the box.

I forced nitropack version 2.9.7 in the Solid Start app, but I still get the same top-level await error for yoga-layout when running npm run dev.

The fix in

......................

got rid of the need to use await import() for the lume package, cleaning up imports in several modules.
However the issue of node_modules not being handled by the dev/build tooling still persists with yoga-layout, so now I'm down to a single file that has an await import(), currently looking like this:
// This is not working yet (https://github.com/solidjs/solid-start/issues/1614), so we with conditional await import()
// import Yoga, {Direction, FlexDirection, Gutter, Wrap, Edge, Justify, Align} from 'yoga-layout'

let Yoga: typeof import('yoga-layout').default
let Direction: typeof import('yoga-layout').Direction
let FlexDirection: typeof import('yoga-layout').FlexDirection
let Gutter: typeof import('yoga-layout').Gutter
let Wrap: typeof import('yoga-layout').Wrap
let Edge: typeof import('yoga-layout').Edge
let Justify: typeof import('yoga-layout').Justify
let Align: typeof import('yoga-layout').Align

if (globalThis.window?.document) {
	;({
		default: Yoga,
		Direction,
		FlexDirection,
		Gutter,
		Wrap,
		Edge,
		Justify,
		Align,
	} = (await import('https://unpkg.com/yoga-layout@3.1.0/dist/src/index.js')) as typeof import('yoga-layout'))
}

// ...

The await<EMAIL_ADDRESS>causes the build to igore it, so it'll import from unpkg.com in the browser.

Ultimately this is a Nitro defaults issue. I'm hoping upgrading Nitro to v2 when it comes out will fix this soon.

Is it confirmed this is fixed in v2? Or do we need to make an issue?


[Narwhal] proptest design iteration

This PR changes snarkos-narwhal's proptesting approach towards more composable way. Instead of writing a new struct that mimics the input data of test target, only to be able to #[derive(Arbitrary)] - we now use more context-specific approach:

compose module-internal strategy-fns for failure cases and specify them in proptest arguments e.g.  #[strategy(too_small_committee())]
compose public strategy-fns for success cases, so that other strategies depending on valid structs can be composed as well; if there's a single type of valid struct that makes sense, or if too much flexibility hurts the shrinking performance, then implement Arbitrary as a canonical strategy for the type.

The biggest benefits are the improved composability and not having to use #[filter(TestInput::is_valid())] everywhere. This PR also adds few more proptests to validate this.
Few limitations and workarounds I ran into:

as we cannot implement Arbitrary for foreign types (e.g. the ones in snarkvm-narwhal) we then need to fallback to strategy-fns or wrap them into local types. Both have their use cases.
Strategy requires that the generated value implements Debug, this isn't the case in all our test targets so a custom test implementation may be needed.
In some cases, we want to make sure that generated values share some input value (e.g. use the same Storage) - the natural way would be using any_with(input_value) strategy, but that requires that input value implements Default.

Note to reviewers:

@niklaslong @ljedrz your review comments were addressed in commit https://github.com/AleoHQ/snarkOS/pull/2537/commits/8fa5f2fdd406c4cc95e7a6cebbfcdaa5d1353229
resolving the merge to narwhal wasn't straight-forward due to #2543 and the removal of Batch struct in snarkVM - @joske can you check the merge commit https://github.com/AleoHQ/snarkOS/pull/2537/commits/8fa5f2fdd406c4cc95e7a6cebbfcdaa5d1353229 if it's done along your ideas
As there were weird, unfixable clippy warnings, I decided to upgrade the test-strategy crate to a freshly released version which included fixes (also got rid of the git-dep :partying_face: ) - however, then clippy started warning about dead_code when using #[strategy(fn)] on function parameter, but only in node/narwhal/committee/src/prop_tests.rs for some reason.

Ok merging this finally, thanks everybody :pray:


Add an option to initiate the front end

Sometime the front end project is not necessary (no need for the API).
	initiateFrontApi = flag.Bool("initiateFrontApi", false, "generate <pkgname> project in the ng workspace, and then generate at each compilation, unless  <pkgname> project directory is suppressed

Alternative:

A: "Magic Code" : Magic code somewhere to tell to generate the front or not generate the front
B:  "Compiler option: initiateFrontApi" to generate the front code and then generate unless the project directory is suppressed.
C: "Compiler option: noModelFrontCode" to generate the front code but with no generation of the API related to the model.

A:

minus: magic code is a departure from "pure go code" approach, maintenance is complex.
minus: no obvious place to put the magic code. Within the docs.go file ? It is a generated file. Maybe in .frontignore file that provides a pattern for parsing go files similar to the gitingore syntax "*"

package main

import (
	"fmt"
	"log"
	"os"

	gitignore "github.com/sabhiram/go-gitignore"
)

func main() {
	ignorePatterns, err := gitignore.CompileIgnoreFile(".gitignore")
	if err != nil {
		log.Fatalf("Failed to compile .gitignore: %v", err)
	}

	// Sample file paths to test
	paths := []string{
		"test.txt",
		"bin/output",
		"src/ignored_file.go",
	}

	for _, path := range paths {
		if ignorePatterns.MatchesPath(path) {
			fmt.Printf("%s is ignored\n", path)
		} else {
			fmt.Printf("%s is NOT ignored\n", path)
		}
	}
}


Enable default user to use secret

Signed-off-by: Suzy Wang<EMAIL_ADDRESS>Thanks for taking the time to contribute to clickhouse-operator!
Please, read carefully instructions on how to make a Pull Request.
This will help a lot for maintainers to adopt your Pull Request.
Important items to consider before making a Pull Request
Please check items PR complies to:

[x] All commits in the PR are squashed. More info
[x] The PR is made into dedicated next-release branch, not into master branch1. More info
[x] The PR is signed. More info

--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.

@SuzyWangIBMer , I do not think it is a good idea to use a global secret for default user in all installations.
Do you know, that you can specify secret for any user in CHI already? The syntax is the following:
  configuration:
    users:
      user1/k8s_secret_password: test/test-011-secret/pwduser1
      user2/k8s_secret_password_sha256_hex: test/test-011-secret/pwduser2
      user3/k8s_secret_password_double_sha1_hex: test/test-011-secret/pwduser3

However, for default it is not going to work properly if you are using sharded cluster, since inter-cluster configuration needs to be updated as well. We are working on a proper support in 0.20.0

Hi @alex-zaitsev , the purpose of this pr is to support default user to use secret the same way that any customized users are already supported in operator. It is our initial question that why default user is different.
Are you going to keep default user in a different section for the future?

Not needed anymore, since secrets are supported for all users now.


before_check and before_transition Integration

This branch integrates the work of @TheMysteriousX into transitions. Discussion can be found here: #40 and integration progress here: #80.
@tyarkoni, @wtgee: since that is a major change of how transitions works (especially under the hood) I wait for your okay before I pull the trigger.

rework of #80 makes this obsolete


Rename internal Iterator::Slice type to not conflict with ::Slice

Ref: https://forum.crystal-lang.org/t/compilation-error-iterator-bug/5276

I think we should do the same for all iterators defined in Iterator. Other iterators defined outside of Iterator have an iterator "Iterator" suffix which should go a great way to make random name collisions unlikely.

Failing specs need attention

Ogh well that's lovely. There is Iterator::Step and Steppable::StepIterator of which Steppable includes Iterator so now we have two StepIterators...

Okay so apparently Step::StepIterator is a public type so can't really rename that one. Imma just give the other internal one a diff name and call it a day.


Installation instructions does install mpc-* commands in PATH

The pip install . does work after all the dependencies have been installed.


Tiny optimization and cleanups

I found a project where we were spending more than 2% of total compile time in getTypeOfMember(). Most callers only passed in a VarDecl or EnumElementDecl, so now it only supports those and applies getContextSubstitutionMap(), which is cached.
Also clean up some older code that used TypeSubstitutionMap, which I'd like to get rid of because it's a DenseMap which is wasteful for just a handful of generic parameter keys.
Finally, remove substRootParam() and substBaseType() methods on DependentMemberType, which were only used in a few places. There are better ways of doing the same thing with existing primitives.

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please test source compatibility

@swift-ci Please test source compatibility

@swift-ci Please smoke test

@swift-ci Please test source compatibility


Error in New User Register Logic

Every time I try to register as a new user it keeps giving me an ERROR :'wrong details'.
The error can be resolved with enhancing the user registration logic.

@inkerton i would like to contribute to this. Assign me under GSSOC 2024 ext and hacktoberfest.


Write a Rust program to find largest and smallest numbers in an array

Description
Write a Rust program to find largest and smallest numbers in an array
Input  : [1, 2, 3, 4, 5]
Output : 5, 1

How to contribute

Save the solution in program/find_largest_and_smallest_numbers_in_an_array.rs file
Add find_largest_and_smallest_numbers_in_an_array.rs file in find-largest-and-smallest-numbers-in-an-array folder

!assign


Path for bin files

Hi,
First of all, I absolutely love your app!
I had some issues with showing the process list and the CPU temp.
Those two lines in electron/main.js seems to be wrong:
process.execPath.replace("MacOS/Smotrite", "") + "bin/" + "process-list",
process.execPath.replace("MacOS/Smotrite", "") + "bin/" + "cpu-temp",

I fixed it using this instead:
app.getAppPath() + "/bin/process-list",
app.getAppPath() + "/bin/cpu-temp",

Hello, Christian! Thanks for your support😄
Gonna take some time to work on this project next week and check your issue.


CoffeeScript parser error with forward slash

VSCode Version: 1.7.2
OS Version: OS X

Steps to Reproduce:

Create a .coffee file
Use a forward slash without a trailing space makes the rest of the file turn red.

Possibly assumes it is a  reg exp?

I see the issue below is exactly the same as this, but closed in April?
https://github.com/Microsoft/vscode/issues/499

Yes, that's the same issue. It has been moved to textmate/coffee-script.tmbundle#8 and is still open


Illegal Instruction:4 Spleeter install mac os10.14.6

-I'm a newbie here but i did successfully install spleeter on mac os 10.13.6 without any problems.  Now i'm on different machine and I've done the following:

Installed python 3.7
Used conda install conda=4.6.14 to install conda.
I used conda install spleeter to install spleeter and it downloaded and the installation was successful.

EDIT: I'm also working from a fresh install of Mojave.  I downloaded xcode for Mojave thinking that could help
Now when i run the separate command I get Illegal instruction: 4
I googled the error and found a similar issue but it was for windows issue #376 and I'm also not getting any additional information of where the problem could be in my error message besides "Illegal Instruction: 4"
It's possible i installed this wrong (again i'm a newbie) or maybe someone has had a similar experience and they can share with me a fix for illegal instruciton: 4
I performed a reinstall of python and anaconda and spleeter as well using the same method above and get the same results.

OS
MacOS 10.14.6

Installation type
Conda

RAM available
32gb

Hardware spec
radeon 580 /xeon /

Additional context

Same issues. I tried over and over to install. The command to install works but whether choosing this explicit version or just conda, it finishes and spleeter can't be found upon calling it

Got all installed and followed all instructions and despite the spleeter folder being in Documents exactly as proscribed,  python -m spleeter separate -i bad.flac -p spleeter:4stems -o output
/System/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python: No module named spleeter

Any update?

yes, i got it to finally work by uninstalling and deleting everything i
previously did.  and then download miniconda from here
https://docs.conda.io/en/latest/miniconda.html
the miniconda seems to be the key.  I was user the full version called
anaconda and apparently there are differences.  once i used miniconda and
followed the directions from the site original install directions i was all
set.
On Sat, Jun 27, 2020 at 10:07 AM ovrdrvn<EMAIL_ADDRESS>wrote:

Any update?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/deezer/spleeter/issues/397#issuecomment-650565497,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APWVGJTBWW4K76YFIYD4ILLRYX4I3ANCNFSM4NJH7ATQ
.

How do I delete everything then?
Trying to make it work on 10.14.6

yes, i got it to finally work by uninstalling and deleting everything i previously did. and then download miniconda from here https://docs.conda.io/en/latest/miniconda.html the miniconda seems to be the key. I was user the full version called anaconda and apparently there are differences. once i used miniconda and followed the directions from the site original install directions i was all set.
…
On Sat, Jun 27, 2020 at 10:07 AM ovrdrvn @.***> wrote: Any update? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#397 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/APWVGJTBWW4K76YFIYD4ILLRYX4I3ANCNFSM4NJH7ATQ .

how did you uninstall and delete eveything?
I'm having trouble uninstalling and finding where the files have been downloaded to


Support require and reporter-options in mocharc

Is your feature request related to a problem or a nice-to-have?? Please describe.
I am not able to get reporter-options (or reporterOptions) working with either _mocha or mocha when the config is within mocha on package.json or in .mochrarc.js
require is also not working either as an array or set of strings.
But other properties are working.
Describe the solution you'd like
I'd like it to be possible to add reporterOptions and require within mocharc.js.
Describe alternatives you've considered
It seems unnecessarily clunky to add as flags to the CLI, especially when I've already added an RC file.
Additional context

These should be working.  Can you provide a sample repo or configuration?

On master of https://github.com/brettz9/intl-dom, I'm not using it currently, but on this branch it is failing: https://github.com/brettz9/intl-dom/tree/mocha-failing .
The reporter options in master point mocha-multi-reporters to the right configFile, i.e., to mocha-multi-reporters.json which triggers mocha-badge-generator to run producing output at badges/test-badges.svg. But in the branch, the reporter-options are not passed on.
If this could be an issue with mocha-multi-reporters I seem to remember replicating with another config without it, and can look to reproduce as needed.

This is also happening to me. https://github.com/CrowdStrike/faltest/blob/58ef39600c/packages/mocha/src/index.js#L55
My junit is printing to console instead of taking reporter options "output=dist/test_output.xml".
The repro is to check out that repo, use commit 7857ec083be2867eec901d737954c3cc7d56201c (right before mocha 7). Then yarn install and run yarn start examples/runner-only/tests/* --reporter xunit --reporter-options output=dist/test_output.xml. Notice the dist file.
Then checkout d03d8fdd7e5467466f35c23f2f3936320e3f3f3e (mocha 7 commit), (remove old dist file), yarn install and run the command again. Notice it printing to console instead of file.

After reverting mocha 7 and adding a regression test, this is now the failing PR if it helps. https://github.com/CrowdStrike/faltest/pull/219

@kellyselden This has been a bug in v6. The Mocha constructor was expecting opts.reporterOption, but processed reporterOptions. see API docs.

Thank you @juergba. I fixed it by changing to reporterOption. I missed that in the changelog. Sorry @brettz9 for unintentionally hijacking your issue.

@brettz9 reporter-option in .mocharc.js is an array. Please try:
`reporter-option`: [
    'configFile=mocha-multi-reporters.json'
]

Excellent, thank you, @juergba, I see this is working now. However, for require, it still does not work:
  require: [
    'esm', 'chai/register-expect', 'test/bootstrap/node.js'
  ]

Hmmm... Ok, I was left with:
_mocha --require esm --require chai/register-expect --require test/bootstrap/node.js

which after removing the requires, I just had:
_mocha

...which was complaining, but it is ok with "mocha".

So I guess this is resolved as far as I am concerned (though I'd be interesting in knowing why _mocha is different).

mocha checks for Node flags and spawns a child-process if found any. --require esm is handled as Node flag, the rest of the require's are passed to Mocha.
_mocha is for backwards compability only and does not care for Node flags. It was used also for debugging, in times when debugging a child-process was difficult.
I would like to close this PR.

@brettz9 reporter-option in .mocharc.js is an array. Please try:
`reporter-option`: [
    'configFile=mocha-multi-reporters.json'
]

THis worked for me
Thanks


Allow changing the shape of the FAB

Added the ability to change the ShapeBorder of the FAB for the collapsed and expanded states with the collapsedFabShape and expandedFabShape attributes.
This allows the button to have a circular shape for example (just like the one used in Material Design v2).

Thank you for your contribution, this looks nice!

Hey @zuvola, thank you for merging the pull request! It's great to see the changes getting incorporated into the code. I was wondering if there is any update on when these changes will be released in the pub.dev? I'm really looking forward to utilizing them in my project. Your assistance would be greatly appreciated. Thank you!

Sorry for the delay. Please check for the update.


YouTube Muisc volume is too loud

OS: MacOS, Windows, Linux
GPMDP Version: 4.6.0
Issue Descriptions: All audio volume with YTM is too loud. The slider appears to only bring volume down to ~50% before it mutes completely (verified via pavucontrol on linux) i.e., 1% on volume slider is actually ~50% application volume when it should be 1% application volume.
Steps to Reproduce: play any song in YTM. All songs are only mildly reduced in volume when slider is close to mute.

Can't reproduce on Windows 10.

The slider and volume control is all done by YTM not by us

The slider and volume control is all done by YTM not by us

Does this mean that manipulating the slider in GPMDP isn't possible? I believe the real issue here is that YTM is using a linear volume slider, when it should be exponential due to how human ears perceive volume. See here for a robust explanation on that topic: https://www.dr-lex.be/info-stuff/volumecontrols.html
GPM had proper volume control with perceivable differences at each step on the slider, but YTM (as well as YouTube itself) does not. As the OP mentioned, you only really notice the differences in volume when you get the slider almost all the way to the left. I'm going to appeal to YTM to see if this can be changed, but it seems unlikely as YTM is intrinsically tied to YouTube and they can't change YouTube's slider at this point without breaking everything that relies on it. Would be nice if we could at least have an option for an exponential slider wrapped/mapped over the existing YouTube one in GPMDP.


App testing via Github Actions

This Action creates an Alertmanager instance in docker and runs pytest against the instance.
The AlertGroup test fails, however this test also fails locally for me.

I'm relatively new to Github actions. I like this and thank you for putting in the effort! It is a big help!
Curious, is it possible to also run actions on pull requests instead of just push?

I'm new to this as well! :)
I just edited the action to run on PRs and push. There are more possibilites listed here: https://help.github.com/en/actions/reference/events-that-trigger-workflows#about-workflow-events


Fix NPE and add a test case for older history files

If we fail to read the stats history file for any reason, we would end up getting an NPE because _statsHistory
went uninitialized. Fixed to create an instance with a new file.
Also added a v1 serialized file to the repository so that we can ensure that future changes to the class
can still read v1 files.

Codecov Report

Merging #1827 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #1827     +/-   ##
=========================================
- Coverage   66.13%   66.03%   -0.1%
=========================================
  Files         885      885
  Lines       42708    42712      +4
  Branches     5611     5611
=========================================
- Hits        28243    28206     -37
- Misses      12593    12640     +47
+ Partials     1872     1866      -6

Impacted Files
Coverage Δ

...ata/manager/realtime/RealtimeTableDataManager.java
47.86% <0%> (-1.7%)
:arrow_down:

...om/linkedin/pinot/client/PinotClientException.java
33.33% <0%> (-33.34%)
:arrow_down:

...in/pinot/core/query/pruner/ValidSegmentPruner.java
57.14% <0%> (-28.58%)
:arrow_down:

...e/operator/dociditerators/MVScanDocIdIterator.java
49.25% <0%> (-14.93%)
:arrow_down:

...inot/broker/servlet/PinotClientRequestServlet.java
48.78% <0%> (-14.64%)
:arrow_down:

...mpl/dictionary/DoubleOffHeapMutableDictionary.java
58.18% <0%> (-14.55%)
:arrow_down:

...pinot/core/operator/docidsets/OrBlockDocIdSet.java
84.93% <0%> (-13.7%)
:arrow_down:

...inot/client/JsonAsyncHttpPinotClientTransport.java
60% <0%> (-11.43%)
:arrow_down:

...kedin/pinot/core/util/SortedRangeIntersection.java
83.82% <0%> (-7.36%)
:arrow_down:

.../impl/dictionary/FloatOnHeapMutableDictionary.java
88.88% <0%> (-6.67%)
:arrow_down:

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0508866...db4d084. Read the comment docs.


Suggestion for Spreadsheet Bookmarklet

Add functionality to jump cursor to the next row after pressing Enter. Right now, nothing happens, to go to new row, I have manually clicked in the next row and start editing.

I second this

Hello, i have added that functionality take a look at my version.

In my attempt [ENTER] -> jump to next row, pressing [TAB] brings you to the next column, similar to excel. Live demo
Additional functionality:

Save&load to localstorage
Infinite rows (try press [ENTER] at the end)
Less than 1KB

In my attempt [ENTER] -> jump to next row, pressing [TAB] brings you to the next column, similar to excel. Live demo
Additional functionality:

Save&load to localstorage
Infinite rows (try press [ENTER] at the end)
Less than 1KB

Hello i only have one suggestion, rewrite "eval(v.substring(1))" as "eval(v.toUpperCase().slice(1))", that way you prevent it to run harmful code

Great idea! Taking this route localstorage should also be renamed to something other than capital L, so that it wont be accessible. I managed to free up even more bytes, therefore unicode emoji for save&load can be put back in place. Live demo


Workflow - Disable Tasks warning shows an incorrect 'task is in progress on X pages' value

Issue Summary
When disabling a Workflow Task, there is a warning that says This task is in progress on # pages., however the number of pages is incorrect and appears to reflect the tasks in progress across ALL pages.
Steps to Reproduce

In an existing Wagtail project (does not have to have custom Workflow Tasks)
Sign in as an admin user
Check you have at least one Workflow in progress (you can check this by viewing the home page), if not, start at least one.
On the sidebar click 'Settings' and then 'Workflow tasks'
Create a new workflow task (button at the top right)
Name this anything (e.g. 'Disable Me')
Do not use this Task in any Workflow but instead go straight to editing it
Now attempt to Disable this task
Expected: This page should not have a warning about any Task in progress
Actual: This page will show that the task is in progress on some pages

Option Maybe the warning message should not show at all when there are zero in progress, but the disable page itself should probably show to confirm the action.
Technical details

Python version: 3.6.9
Django version: 3.2.6
Wagtail version: 2.15 (alpha)
Browser version: Firefox 91

Potential root cause
The code below is what is used for Disabling a Task (view)
wagtail/admin/views/workflows.py
states_in_progress = TaskState.objects.filter(status=TaskState.STATUS_IN_PROGRESS).count()
Replacing that line with
states_in_progress = TaskState.objects.filter(status=TaskState.STATUS_IN_PROGRESS, task=self.get_object().pk).count()
Seems to fix it.

Branch with a fix, no unit tests done yet though.
https://github.com/lb-/wagtail/tree/fix/7492-disabled-workflow-task-message


Added Internal Angles of Polygon!

Issue Id you have worked upon -
Internal Angles of a Polygon #607
Briefly explain your program logic -

Take input
Multiply 180(input-2)
Return ans

Screenshots(Attach 2 screenshots of your own input and output) -

By raising this PR I affirm that -

[x] My code follows the guidelines of this project.

[x] I have performed a self-review of my own code.

[x] I have commented my code.

[x] My code gives the correct output.

[x] I affirm that I strictly follow contributing guidelines and code of conduct.

Hey there @SarthakKeshari !!
Here's the PR for the #607 issue.
Thanks!!

Congratulations 🎉 @VincentPaulV on your contribution.
Thanks for adding value to this repository. 😊
Let's celebrate this fest 😃 by providing more developers 👨💻👩💻 an opportunity to contribute. Help us make this repository reach far and more by sharing this to your friends and colleagues.
Your efforts can make difference.


Clean up scripts for cmake tests

Clean up the cmake scripts for the better readability.

Thank you for the review!


Add a way to identify the end of file or last row containing data

There are some really great functionalities included in this package.
One thing I noticed while importing a spreadsheet with about 150 rows is that the reader pulls in 900+ lines, including rows that are completely empty.
I thought it would be useful to have a way to identify when the reader has reached the end of the file or the last row that contains data instead of always reading every single row in the document.
Thoughts?

This package is only a wrapper for PHPExcel, so it's not really possible to add a way to identify it inside this package.


[apiv2] failed to create a new image from a running container

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description

Steps to reproduce the issue:

./bin/podman system service --timeout 0 tcp:<IP_ADDRESS>:8080

./bin/podman run --name myalpine -td docker.io/library/alpine:latest /bin/sh

curl -v -s -H 'Content-type: application/json' -d '{"container":"myalpine","repo":"newalpine","tag":"v1","comment":"test", "author":"ajia"}' http://localhost:8080/v1.40/libpod/containers/commit

Describe the results you received:
[fedora@fedora32 libpod]$ curl -v -s http://localhost:8080/v1.40/libpod/containers/json|jq
*   Trying ::1:8080...
* connect to ::1 port 8080 failed: Connection refused
*   Trying <IP_ADDRESS>:8080...
* Connected to localhost (<IP_ADDRESS>) port 8080 (#0)
> GET /v1.40/libpod/containers/json HTTP/1.1
> Host: localhost:8080
> User-Agent: curl/7.69.1
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Content-Type: application/json
< Date: Fri, 15 May 2020 10:28:25 GMT
< Content-Length: 465
<
{ [465 bytes data]
* Connection #0 to host localhost left intact
[
  {
    "Command": [
      "/bin/sh"
    ],
    "Created":<PHONE_NUMBER>,
    "Exited": false,
    "ExitedAt": -62135596800,
    "ExitCode": 0,
    "Id": "88bec8231d7035f23d51380d16b3f5cf181e0d00ecbe931ab9cb7ef1716efdb7",
    "Image": "docker.io/library/alpine:latest",
    "ImageID": "f70734b6a266dcb5f44c383274821207885b549b75c8e119404917a61335981a",
    "IsInfra": false,
    "Labels": null,
    "Mounts": [],
    "Names": [
      "myalpine"
    ],
    "Namespaces": {},
    "Pid": 0,
    "Pod": "",
    "PodName": "",
    "Ports": null,
    "Size": null,
    "StartedAt":<PHONE_NUMBER>,
    "State": "running"
  }
]

[fedora@fedora32 libpod]$ curl -v -s -H 'Content-type: application/json' -d '{"container":"myalpine","repo":"newalpine","tag":"v1","comment":"test", "author":"ajia"}' http://localhost:8080/v1.40/li
bpod/containers/commit
*   Trying ::1:8080...
* connect to ::1 port 8080 failed: Connection refused
*   Trying <IP_ADDRESS>:8080...
* Connected to localhost (<IP_ADDRESS>) port 8080 (#0)
> POST /v1.40/libpod/containers/commit HTTP/1.1
> Host: localhost:8080
> User-Agent: curl/7.69.1
> Accept: */*
> Content-type: application/json
> Content-Length: 88
>
* upload completely sent off: 88 out of 88 bytes
* Mark bundle as not supporting multiuse
< HTTP/1.1 405 Method Not Allowed
< Date: Fri, 15 May 2020 10:25:58 GMT
< Content-Length: 0
<
* Connection #0 to host localhost left intact

Describe the results you expected:
can successfully  create a new image from a running container
Additional information you deem important (e.g. issue happens only occasionally):
Output of podman version:
Version:            2.0.0-dev
RemoteAPI Version:  1
Go Version:         go1.14.2
Git Commit:         4611ff5ce4ff67a142363ab66e10944bfc40f860
Built:              Fri May 15 03:26:27 2020
OS/Arch:            linux/amd64

Output of podman info --debug:
host:
  arch: amd64
  buildahVersion: 1.15.0-dev
  cgroupVersion: v2
  conmon:
    package: conmon-2.0.15-1.fc32.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.0.15, commit: 33da5ef83bf2abc7965fc37980a49d02fdb71826'
  cpus: 4
  distribution:
    distribution: fedora
    version: "32"
  eventLogger: file
  hostname: fedora32
  idMappings:
    gidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
    uidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
  kernel: 5.6.10-300.fc32.x86_64
  linkmode: dynamic
  memFree:<PHONE_NUMBER>
  memTotal:<PHONE_NUMBER>
  ociRuntime:
    name: crun
    package: crun-0.13-2.fc32.x86_64
    path: /usr/bin/crun
    version: |-
      crun version 0.13
      commit: e79e4de4ac16da0ce48777afb72c6241de870525
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +YAJL
  os: linux
  rootless: true
  slirp4netns:
    executable: /usr/bin/slirp4netns
    package: slirp4netns-1.0.0-1.fc32.x86_64
    version: |-
      slirp4netns version 1.0.0
      commit: a3be729152a33e692cd28b52f664defbf2e7810a
      libslirp: 4.2.0
  swapFree: 0
  swapTotal: 0
  uptime: 97h 59m 13.98s (Approximately 4.04 days)
registries:
  search:
  - registry.fedoraproject.org
  - registry.access.redhat.com
  - registry.centos.org
  - docker.io
store:
  configFile: /home/fedora/.config/containers/storage.conf
  containerStore:
    number: 2
    paused: 0
    running: 2
    stopped: 0
  graphDriverName: overlay
  graphOptions:
    overlay.mount_program:
      Executable: /usr/bin/fuse-overlayfs
      Package: fuse-overlayfs-1.0.0-1.fc32.x86_64
      Version: |-
        fusermount3 version: 3.9.1
        fuse-overlayfs: version 1.0.0
        FUSE library version 3.9.1
        using FUSE kernel interface version 7.31
  graphRoot: /home/fedora/.local/share/containers/storage
  graphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "false"
  imageStore:
    number: 2
  runRoot: /run/user/1000/containers
  volumePath: /home/fedora/.local/share/containers/storage/volumes
version:
  Built:<PHONE_NUMBER>
  GitCommit: 4611ff5ce4ff67a142363ab66e10944bfc40f860
  GoVersion: go1.14.2
  OsArch: linux/amd64
  RemoteAPIVersion: 1
  Version: 2.0.0-dev

Package info (e.g. output of rpm -q podman or apt list podman):
[fedora@fedora32 libpod]$ git rev-parse HEAD
4611ff5ce4ff67a142363ab66e10944bfc40f860

Additional environment details (AWS, VirtualBox, physical, etc.):
Openstack VM

This is not a bug.  You need to pass those parameters as query parameters.  The proper syntax would be:
'http://d/v1.40/libpod/commit?container=baude&repo=newalpine&tag=v1&comment=test&author=ajia'
This too will then fail with an error because only comment can be used with the docker format.
Also, make sure your query parameters are http encoded as they get more complex.  if you need us to help you with that, feel free to reach out.

This too will then fail with an error because only comment can be used with the docker format.

Thanks for your comment!
It will be better if there is a comment about this in query parameters 'comment' in documentation - http://docs.podman.io/en/latest/_static/api.html#operation/libpodCommitContainer

Also, make sure your query parameters are http encoded as they get more complex. if you need us to help you with that, feel free to reach out.

It will be friendly for users to give request samples in documentation - http://docs.podman.io/en/latest/_static/api.html#operation/libpodCommitContainer

Any chance you could make a PR to make these doc changes?

It seems we were missing these documentation updates


Add some log messages to NetworkStatusNotifier main loop

Description
We've been having quite a bit of flaky tests related to afterglow, adding some log messages to the main loop of NetworkStatusNotifier might help pin point where the flake lives.
In order to make it easy to add the log messages, the RunSingle and RunSingleAfterglow methods have been unified, since their difference was minimal.
Unrelated to this, the HandleAfterglowEnvVars method has been slightly rewritten to make its workflow more streamlined and easier to follow.
Checklist

[ ] Investigated and inspected CI test results
[ ] Updated documentation accordingly

Automated testing

[ ] Added unit tests
[ ] Added integration tests
[ ] Added regression tests

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.

After retriggering the tests a bunch of times, I managed to get the flake to show up and determine the event we are missing is the first of the 3 thanks to the added logs in the network status notifier. I believe a connection error at the start of the test is causing it to not complete the first curl correctly and so we miss the event, the script goes on and we do capture the other 2, setting the script to fail on a failed curl and adding all container logs to the uploaded logs (see #1869) should help us confirm the theory or narrow down the flake even further.


Saving/Loading

Is your feature request related to a problem? Please describe.
Missing feature from the original VNDS software. The current implementation of saving and loading in VNDS-LOVE consists of saving to a single slot with X and automatic loading whenever a Visual Novel is close or launched.
Describe the solution you'd like
In the original VNDS software, automatic loading isn't present and it instead has to be done manually. I believe autoloads shouldn't be there in case someone wants to restart a visual novel with fresh data.
VNDS has eighteen save slots, or three pages with six slots each. Each save file is accompanied with a low res screenshot of the top screen, which equates to a screenshot of VNDS-LOVE without the text box. Having more slots than just eighteen would also be a welcome improvement.

VNDS-LOVE has auto load, but not autosave (you have to hit X to save). Other than that, I agree/understand what you are suggesting. For now, I think I'll implement manual load/save with slots.
Notes for myself/whoever implements it: The save preview can be done by looking at the loaded background and the images inside of the save. Draw those super scaled down inside of a box with the same aspect ratio as the background. Needs to gracefully handle both of those not existing though, just drawing a blank box if no preview could be found.
Each save should be named save0.json - saveX.json
This is a higher priority issue as breaking changes to save files should be done earlier rather than after people have existing saves that they can't port over without losing data.

VNDS-LOVE has auto load, but not autosave (you have to hit X to save). Other than that, I agree/understand what you are suggesting. For now, I think I'll implement manual load/save with slots.
Notes for myself/whoever implements it: The save preview can be done by looking at the loaded background and the images inside of the save. Draw those super scaled down inside of a box with the same aspect ratio as the background. Needs to gracefully handle both of those not existing though, just drawing a blank box if no preview could be found.
Each save should be named save0.json - saveX.json
This is a higher priority issue as breaking changes to save files should be done earlier rather than after people have existing saves that they can't port over without losing data.

This is the save file UI in VNDSx. It's entirely touch controller. I'm thinking it'd probably be good to have something like this but mouse controlled. Enter would probably be the best key to use. In VNDSx, it's a button on the touch screen. I believe there was also a button combo, but I forgot what it was.

This is the save file UI in VNDSx. It's entirely touch controller. I'm thinking it'd probably be good to have something like this but mouse controlled. Enter would probably be the best key to use. In VNDSx, it's a button on the touch screen. I believe there was also a button combo, but I forgot what it was.

Forget what I said about entirely touch controlled, just remembered you could also use buttons to navigate. IIRC the D-Pad is used to select the save file, A is used to save and B is used to exit the menu.

Forget what I said about entirely touch controlled, just remembered you could also use buttons to navigate. IIRC the D-Pad is used to select the save file, A is used to save and B is used to exit the menu.

This should be finished with https://github.com/ajusa/VNDS-LOVE/commit/9119496132103715bce12386b8b949341958bf85!
Main deviations from VNDS:

The preview doesn't include the foreground images. This would be a bit of a pain to implement, so I'm skipping it for now. My guess is that most people will be able to get by with just the background image (as it is super small anyway, so there wouldn't be detail). If someone in the future wants me to add this, feel free to make a separate issue.
Save slots are currently restricted to 10, but can easily be increased with a minor code change.
There is no delete slot button. Not sure if the original VNDS had this (didn't see a delete button under the UI). To delete a save slot you basically just need to find the novel, find save[slot number].json, and delete it. Note that you can override save slots without any problems, but you can't clear them as of now.
Missing some of the keybindings that were mentioned. To save, you have to open the menu click save. I'm planning on redoing some of the input handling in the future, as it doesn't really support key combinations that well right now.

This should be finished with https://github.com/ajusa/VNDS-LOVE/commit/9119496132103715bce12386b8b949341958bf85!
Main deviations from VNDS:

The preview doesn't include the foreground images. This would be a bit of a pain to implement, so I'm skipping it for now. My guess is that most people will be able to get by with just the background image (as it is super small anyway, so there wouldn't be detail). If someone in the future wants me to add this, feel free to make a separate issue.
Save slots are currently restricted to 10, but can easily be increased with a minor code change.
There is no delete slot button. Not sure if the original VNDS had this (didn't see a delete button under the UI). To delete a save slot you basically just need to find the novel, find save[slot number].json, and delete it. Note that you can override save slots without any problems, but you can't clear them as of now.
Missing some of the keybindings that were mentioned. To save, you have to open the menu click save. I'm planning on redoing some of the input handling in the future, as it doesn't really support key combinations that well right now.


I run unsuccessfully during initialization

I cloned the project to my local.
cd iD
npm install (an error occurred)

Error message：

Hmm, it looks like this is outside our control.. The error says that the name-suggestion-index dependency isn't found in the taobao mirror of npm.

right! In taobao mirror the lastest version of the name-suggestion-index is still 0.1.5.

@zhouLion thanks.


Display Observation notes by default in the ResourceTimeline component

Coverage: 93.758%. Remained the same when pulling d7204c0013e260ad51dd4b9a1a49293c2d01fc84 on rahul-make-notes-default-2 into 222532af38619d4d003c9175a3c8ab2a50df349c on main.


Capture termination log as error message during pyfunc image build failure

What this PR does / why we need it:
Currently, user has no visibility on what went wrong when deploying model endpoint. Ideally, the SDK itself should give information on what went wrong with the deployment.
One of the possible error that a user might encounter is failure to build the pyfunc image. To capture the error, we can use the logs prior to pod termination as termination message, and propagate the information back to the users.

Which issue(s) this PR fixes:

Fixes #
Does this PR introduce a user-facing change?:

Model endpoint deployment will provide more descriptive log in the event of pyfunc image build failure.

Checklist

[ ] Added unit test, integration, and/or e2e tests
[x] Tested locally
[ ] Updated documentation
[ ] Update Swagger spec if the PR introduce API changes
[ ] Regenerated Golang and Python client if the PR introduce API changes

LGTM! Thanks @khorshuheng !


nodejs bundle

Nodejs fails to apply an sdp answer if it has a bundle attribute without any mids.

Pull Request Test Coverage Report for Build 588

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.007%) to 38.419%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

rtcpeerconnection.go
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

rtcpeerconnection.go
1
39.0%

Totals

Change from base Build 575:
-0.007%

Covered Lines:
2143

Relevant Lines:
5578

💛  - Coveralls


About depth map of SGD dataset

Hi! @wenquanlu
I‘ve noticed that the  accuracy of the depth map in Static Gesture Dataset (SGD) is meter level. During training, should we use the ground truth of the depth map or the depth map converted from the normal map? Thanks! 🙏

Hi! we used the ground truth of depth map provided in the SGD.
There is one preprocessing step though, We apply normalization to the depth map of each hand in both training sets and the HandRefiner pipeline. On a scale of 0 (black) to 1 (white), the closest surface is given the value of 1.0, and the furthest surface is given the value of 0.2.

Hi! we used the ground truth of depth map provided in the SGD.
There is one preprocessing step though, We first segment out the hand depth map and apply normalization to the depth map. On a scale of 0 (black) to 1 (white), the closest surface is given the value of 1.0, and the furthest surface is given the value of 0.2.
Hope this helps.

OK, thank you so much!

This is the procedure to process training set for RHD. SGD is very similar to this