build:prod:deploy command failed

I'm submitting a...
Bug report
In package
ng-toolkit/serverless
Current behavior
ran ng add @ng-toolkit/serverless --provider firebase --firebaseProject cmacapp-b7482
ran yarn build:prod:deploy
saw:
Error: An unexpected error has occurred.
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>deploy: `cp-cli dist/ functions/dist/ && cd functions && npm install && firebase deploy`
npm ERR! Exit status 2
npm ERR!
npm ERR<EMAIL_ADDRESS>deploy: `cp-cli dist/ functions/dist/ && cd functions && npm install && firebase deploy`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>deploy script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\Nella\AppData\Roaming\npm-cache\_logs\2018-05-27T17_50_19_964Z-debug.log
error Command failed with exit code 2.info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Expected behavior
I would expect the deploy to be successful

Could you provide the full log output?
Can you provide some repo link, so I could try to reproduce this issue on my end?

Full log:
0 info it worked if it ends with ok
1 verbose cli [ 'C:\\Program Files\\nodejs\\node.exe',
1 verbose cli   'C:\\Users\\Nella\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js',
1 verbose cli   'run',
1 verbose cli   'deploy' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'predeploy', 'deploy', 'postdeploy' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>7 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
8 verbose lifecycle<EMAIL_ADDRESS>PATH: C:\Users\Nella\AppData\Roaming\npm\node_modules\npm\node_modules\npm-lifecycle\node-gyp-bin;C:\Users\Nella\Documents\GitHub\myApp\node_modules\.bin;C:\Users\Nella\Documents\GitHub\myApp\node_modules\.bin;C:\Users\Nella\AppData\Local\Yarn\Data\link\node_modules\.bin;C:\Users\Nella\Documents\GitHub\myApp\node_modules\.bin;C:\Users\Nella\AppData\Local\Yarn\Data\link\node_modules\.bin;C:\Program Files\libexec\lib\node_modules\npm\bin\node-gyp-bin;C:\Program Files\lib\node_modules\npm\bin\node-gyp-bin;C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin;C:\Program Files\nodejs;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Users\Nella\bin;C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\ImageMagick-7.0.7-Q16;C:\Python27;C:\Python27\Scripts;C:\ProgramData\Oracle\Java\javapath;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\Program Files (x86)\PuTTY;C:\Program Files (x86)\Windows Kits\8.1\Windows Performance Toolkit;C:\WINDOWS\System32\OpenSSH;C:\Program Files\nodejs;C:\Program Files (x86)\Yarn\bin;C:\Ruby23\bin;C:\Users\Nella\AppData\Local\Microsoft\WindowsApps;C:\Users\Nella\AppData\Local\GitHubDesktop\bin;C:\Program Files\Microsoft VS Code Insiders\bin;C:\Users\Nella\AppData\Local\Microsoft\WindowsApps;C:\Program Files\Microsoft VS Code\bin;C:\Users\Nella\AppData\Roaming\npm;C:\Users\Nella\AppData\Local\Yarn\bin
9 verbose lifecycle<EMAIL_ADDRESS>CWD: C:\Users\Nella\Documents\GitHub\myApp
10 silly lifecycle<EMAIL_ADDRESS>Args: [ '/d /s /c',
10 silly lifecycle   'cp-cli dist/ functions/dist/ && cd functions && npm install && firebase deploy' ]
11 silly lifecycle<EMAIL_ADDRESS>Returned: code: 2  signal: null
12 info lifecycle<EMAIL_ADDRESS>Failed to exec deploy script
13 verbose stack Error<EMAIL_ADDRESS>deploy: `cp-cli dist/ functions/dist/ && cd functions && npm install && firebase deploy`
13 verbose stack Exit status 2
13 verbose stack     at EventEmitter.<anonymous> (C:\Users\Nella\AppData\Roaming\npm\node_modules\npm\node_modules\npm-lifecycle\index.js:304:16)
13 verbose stack     at emitTwo (events.js:126:13)
13 verbose stack     at EventEmitter.emit (events.js:214:7)
13 verbose stack     at ChildProcess.<anonymous> (C:\Users\Nella\AppData\Roaming\npm\node_modules\npm\node_modules\npm-lifecycle\lib\spawn.js:55:14)
13 verbose stack     at emitTwo (events.js:126:13)
13 verbose stack     at ChildProcess.emit (events.js:214:7)
13 verbose stack     at maybeClose (internal/child_process.js:925:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)
14 verbose pkgid<EMAIL_ADDRESS>15 verbose cwd C:\Users\Nella\Documents\GitHub\myApp
16 verbose Windows_NT 10.0.17134
17 verbose argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\Nella\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js" "run" "deploy"
18 verbose node v8.11.1
19 verbose npm  v6.1.0
20 error code ELIFECYCLE
21 error errno 2
22 error<EMAIL_ADDRESS>deploy: `cp-cli dist/ functions/dist/ && cd functions && npm install && firebase deploy`
22 error Exit status 2
23 error Failed at the<EMAIL_ADDRESS>deploy script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 2, true ]

@markgoho I think it's more than enough. Especially repository. Unfortunately, I didn't have time during recent days to take a look at this issue. I will try my best to do this today :)

@markgoho this bug should no longer occur with the newest version.
Could you retry? Reset your repo to the initial commit and execute ng add @ng-toolkit/serverless --provider firebase again.

Hey @maciejtreder I'm sorry I haven't gotten back around to testing this. I'll make sure to do it this evening. Thank you for your excellent work on bringing this functionality to us! 🥂

@markgoho Looking forward for your message! If something is still not working reopen this issue/create new.
Thanks!

Finally got back around to testing this. Everything deployed without a hitch, however I don't see this rendering as static HTML. I see the Angular application coming back. Is there any way to confirm that this is truly rendering on the server?
https://cmacapp-b7482.firebaseapp.com/


[Marketplace]: listing API is triggered upon navigation to the Marketplace page

EPAM AI DIAL chat version
0.18.0-rc
What happened?
Steps:
1 Open Dial app
2 Create new conversation
3 Click on 'Search on My applications' link
Actual result: all listing requests are triggered
Expected result: need to trigger only necessary API calls

Confidential information

[X] I confirm that do not share any confidential information

I reproduced the ticket on UAT  (0.18 version): there are extra double requests for conversation created today, also extra listing requests (for chats, prompts, files).
Verified on staging (0.19 version): now there are only necessary requests:


sometimes can export Blob data but cannot import them

problem
I using Blob/TinyBlob/MediumBlob in MySql8. Sometimes i can export data from database but i cannot import them when read Blod data from file, java.sql will throw exception because MysqlExportService.java_Line:258 will convert binary data to string and some strange characters in the string which will cause the subscripts to cross the bounds.
I think we need to add judgment sentence when the type is LONGVARBINARY and save data like 0x00001abc maybe can solve this problem

Please provide code example of how you normally insert the blob data into the database and how you use them once they're pulled out of the database.
Given that Blob data are hexadecimally encoded before saving into the database, the getString function should work seamlessly. Please provide more info to help with this

Issue fixed in version 1.3.0


Update BL602-hal to embedded-1.0.0-Alpha5 commit

When I first tried to compile, I ran into errors with the try_set_*() functions, so I updated a couple things so that this will work using the latest commit from the bl602-hal repo that has the embedded-hal-1.0.0-Alpha5 integrated into it. It now compiles right out of the box with these changes, at least for me.
This is my first time working officially with embedded rust and this code base, so please let me know if any of my changes would make more sense if done differently.

FYI: There's nothing in this commit that I would have done differently - that's why there's no comments about changes


Deprecate 'roses_test' repository

|    by<EMAIL_ADDRESS>
Is there a need to have two rose repositories? Perhaps we should add a pre-commit hook to the roses_test repo telling users to move their jobs over to the main repository now that accessdev is in production.

Issue migrated from trac:127 at 2024-01-31 17:36:37 +1100

<EMAIL_ADDRESS>commented

Milestone Future deleted

<EMAIL_ADDRESS>removed milestone (was Future)


docs: Updates read me

What's the purpose of this pull request?
Updates packages readme content.

Can't review this PR currently, but can we merge this without upgrading the version of our packages?


feat: transfer tx fees to treasury

i would suggest to keep the original implementation where the native is withdrawn and refunds are deposited.
and introduce new one with fees transferred to selected one.
in this way - it will be easily to swap back if needed.

@apopiak Could you have a look at this ?
the reason is that it seems that this PR introduces something similar to what you'd need for xcm trader ( see the TransactioPaymentDataProvider).
So perhaps, we can/should consolidate this into one thing.
Also, review of the PR by you would be appreciated too.

you'll also want https://github.com/galacticcouncil/warehouse/pull/48/commits/1de7570a2ae17ff088e28bd4d18144f37747a9e3

and to add the feature "use_alloc"

As you remove the MultiCurrencyAdapter this will need a companion PR for Basilisk, no?

Yes. We will also need another PR for hydra-parachain.

As you remove the MultiCurrencyAdapter this will need a companion PR for Basilisk, no?

Yes. We will also need another PR for hydra-parachain.

Is this ready for merge?

Is this ready for merge?

I would like to resolve first this question
It just looks to me bit unnecessary. i would simplify it.  Let's wait for Richard to give his opinion.
Other than that - it is ready for merge.

He removed the iterator


Subsembly - Support for GRANDPA

Project Abstract
This grant is a continuation of the original Subsembly - Framework for building AssemblyScript Runtimes. Developers can already checkout/install the Subsembly CLI and implement Substrate Runtimes using the framework.
Other Grants:

https://github.com/w3f/Grants-Program/blob/master/applications/assemblyscript-scale-codec.md
https://github.com/w3f/General-Grants-Program/blob/master/grants/rfp-responses/assemblyscript-runtime.md

Application Checklist

[x] The application template has been copied, renamed ( project_name.md) and updated.
[X] The total funding amount of the project is below USD $30k for first-time grant applications and $100k for follow-up ones.
[X] A BTC or Ethereum (DAI/USDT) address for the payment of the milestones is provided inside the application.
[X] I have read and acknowledged the terms and conditions.
[X] The software delivered for this grant will be released under an open-source license specified in the application.
[X] The initial PR contains only one commit (squash and force-push if needed).
[X] The grant will only be announced once the first milestone has been accepted.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @Daniel-K-Ivanov, I just noticed that the grant application suggested delivery of the first milestone in September.  Are there technical issues preventing you from completing it?

Hey @Daniel-K-Ivanov, I just noticed that the grant application suggested delivery of the first milestone in September.  Are there technical issues preventing you from completing it?

Hi @semuelle
We've communicated with the Web3 Foundation a couple of months ago about the difficulties of implementing this grant. Our contact person then was @Noc2 and later after that Marcin. Since the email thread was a long one, can you sync with them? We've concluded that the grant should be suspended.

Sorry for the confusion. I'll get back to you.

@Daniel-K-Ivanov what's the future of Subsembly, do you intend to pick this up again at some point?

@Daniel-K-Ivanov I think we can terminate this agreement at this stage. I will open a PR to update the contract. If you ever want to continue to work on this, just let us know or feel free to apply for a new grant.


TPC-C Verification tests

Atomicity and consistency tests done. The isolation and durability tests are not very useful for us.


Add react preview timestamp and fix maxFileSize to be dynamic

Since react preview has some issues with cache (so sometimes clients see old versions of our previews) as discussed this week it would be a good addition to add a timestamp on the preview page.
Also, as investigated, maxFileSize is working well on the build, while on the preview page, it uses a static value of 150 ignoring any dynamic config.

Maybe better to separate the issues since they are not relevant to eachother?


Maki application - Amendment

As mentionned in the original PR, this is an amendment to modify the timeline.
I'm not able to deliver on time, so I just changed the delivery milestones duration and overall project duration.
I hope this is ok.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Develop

Codecov Report

Merging #30 (3a3f66b) into main (206d1b6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   68.36%   68.36%
=======================================
  Files          28       28
  Lines         610      610
=======================================
  Hits          417      417
  Misses        181      181
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 206d1b6...3a3f66b. Read the comment docs.


Handle disjoint fields requested across union types

An incomplete fix for the issue described at:
https://github.com/join-monster/join-monster/issues/512
It is incomplete because this solution does not handle sqlBatch.
Resulting in the same non-deterministic behaviour as non-batching.
PR against upstream raised here: https://github.com/join-monster/join-monster/pull/513

https://github.com/join-monster/join-monster/pull/519 was merged to master with a complete fix for not only join but also batch mode


setting org-fontify-done-headline to nil doesn't take effect

I want to revert this setting made by doom-themes but there seems to be some changes in doom-org-custom-fontification that doesn't respect this setting.

I believe this issue is back.
With the latest changes, setting org-fontify-done-headline to nil does not work. The call to  doom-org-custom-fontification somehow still fontifies the entire headline.


Notfound

herokuapp.com
not found. any update regarding this project to let us get $ rate like into a php file ?

I'm not sure about what are you saying, but you can get yesterday USD price by fetching https://bonbast-api.herokuapp.com/archive/. This is php code as you want:
$json = file_get_contents('https://bonbast-api.herokuapp.com/archive/');
$obj = json_decode($json);
echo $obj->usd->sell;
echo PHP_EOL;
echo $obj->usd->buy;

I will implement the latest price in the next few days.

New API has been implemented. Now you can fetch http://bonbast-api.herokuapp.com/latest for latest currency price (30 minutes cache)


[BUG][DOCS] AWS Firewall

The FAQ says we don't have to use Fortinet and can can use an AWS service. The documentation doesn't seem to cover this ideal use case. Is this actually supported at the present moment, and how do we do it? (Go without Fortinet, but still have a Firewall).

This will be in the coming v1.5.x release, which we are doing everything to get out the door, ASAP (unfortunately, this release has taken us longer than expected to complete).  Per the project board, we are just finishing up the Control Tower integration and an upgrade script and have already started working through the internal release process.

Thanks for the update.
Control Tower, AWS Firewall, and a UI sounds great.
I wanted to comment that we may not always be able to install into the client root account, or we may need to gain the client's trust first by installing elsewhere, but without doing a full-blown migration to a new root account. It's also not clear how your idempotent stack will actually not interfere with whatever the client has going on if we do clobber their existing setup.
Thanks,
Brian

Unfortunately, we rely heavily on AWS Organizations, which requires we leverage a root / Organization Management account.  In these situations where you cannot leverage the root account, you will need to take a different approach/this solution is not a fit.  AWS has a strong focus on AWS organizations as a general best practice - so suggest working with your customers to move in this direction.
FYI - we want to get the release out, so I am not sure what state the gui will be in - it will be alpha or beta and we will use it to get input as to the direction the UI will take in a future release from customers.
For existing/brownfield customers, we actually recommend you NOT do a big-bang install - install with all the customers existing ou's listed in the "ignored-ous": ["UnManaged", "ignoreou-2", ignore-ou-3"] parameter.  These top level ou's will be unmanaged by the accelerator (except for items auto-activated by orgs like Guardduty and Macie).  Install only the mandatory asea accounts and the core ou (updating to 'Security' and 'Infrastructure' ou per latest aws multi-account guidance).  Once that looks good, add one top level ou at a time into governance to test the impact, starting with the customers lowest risk environments like sandbox, testing and working up through test, dev and prod.  (or start with a new organization and slowly migrate accounts and workloads over ass appropriate)
Some typical impacts

the only object we delete that is pre-existing is the default VPC's as it is AWS Best practice - we do not delete customer objects and we do not delete this VPC if it contains objects (we fail).  If a customer is using the default VPC, a flag can be specified to bypass this step on a per account or per region basis to allow for an install in this situation.
SCP's - these will prevent AWS API's, but won't destroy objects.  Should an SCP be negatively impactful to a workload, they can be fully customer modified (and set per ou).  the majority of our SCP's are scoped to Accelerator created objects plus additional security controls.  The v1.5 release will better separate  ASEA created protections from security SCP's like mandatory encryption, as modifying the ASEA protection SCP's could result in a broken ASEA.
we deploy new/additional prefixed objects - naming should be unique and not collide or clobber anything
the proposed architecture and security settings of many of the examples have some of the biggest impacts - centralized ingress/egress (lack of public subnets), the inability for the workload user to create VPCs and subnets and mandatory encryption at rest, but if that's not appropriate for your customer, can be easily adjusted to allow instead for unmanaged or mandaged spoke vpc's with IGW's.
we also have 3 config rules that include OOB remediation encrypting unencrypted s3 buckets and adding/updating instance profiles not configured for SSM - easily disabled if not appropriate
best for you to test, but these are items that come to mind...


Automate creation of non-admin Guacamole account

Update the Guacamole cloud-init scripts so that they do the following:

Create the guacuser (non-admin) Guacamole account.
Allow guacuser to access every configured Guacamole connection.

This was taken care of by @jsf9k with https://github.com/cisagov/guacscanner/pull/1.


No Support For Lock Screen Controls

No Support For Lock Screen Controls. Would love if it had lock screen controls - android

See #542 I think it tries to solve this


Use cases

Use Case 1 - record level validation:
Say I have 2 fields. "Amount" and "Calculation Type". Amount is always a float, however when calculation type is "Percent", Amount must be bounded from 0 to 100.
Use Case 2 - table level validation:
Say I have multiple records and after grouping certain fields, no duplication can be present.
Use case 3 - Multiple coercion functions:
I need to convert a value to string, and perform a couple of other functions before validation. Any tips here?
Appreciate your help! This is probably one of the coolest python projects I've seen in a while.

+1

http://docs.python-cerberus.org/en/latest/customize.html
i don't understand the scenario
#102

@manugarri, can you please elaborate?

@funkyfuture
For (2):
Say I had a column with 1000 rows and I want to say that all 1000 values in this column are in a table of 25000 rows, how would I do that in cerberus?
Or
How would I determine 1 or more columns in aggregate are unique?

Cerberus is only meant to validate one row against a set of rules. Not really designed for such an use case (which seems more suited for a relational database)

ok thx


c++ replay: send YUV/RGB for all cameras

send YUV/RGB for all cameras
resolve #20991 :

[x]  fallback to qcams
~- [ ] occasional OpenCL error on VisionIPC init~
[x] send YUV/RGB for all cameras ( FrameReader need to be refactored)

this PR should be refactored and merged after #22203

clGetPlatformIDs returns (-1001 CL_PLATFORM_NOT_FOUND_KHR) sometimes.

re-open for reivew


prom2json: 1.3.0 to 1.3.2

This also builds successfully on Mac (Darwin) now, whereas previously it was failing during go compilation due to an old version of transitive dependency golang.org/x/sys.
Description of changes
https://github.com/prometheus/prom2json/releases/tag/v1.3.1:

There are no code changes in this release. It merely comes with updated
dependencies, and the pre-built binaries are using Go1.18.1., both to avoid potential security issues. (Note that this is just precaution. We do not know of any relevant vulnerabilities in v1.3.0.)

https://github.com/prometheus/prom2json/releases/tag/v1.3.2:

There are no code changes in this release. It merely comes with updated
dependencies, and the pre-built binaries are using Go1.19.2., both to avoid potential security issues. (Note that this is just precaution. We do not know of any relevant vulnerabilities in v1.3.1.)

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[X] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

nixpkgs-review output:
> nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
this path will be fetched (0.04 MiB download, 0.13 MiB unpacked):
  /nix/store/rwycdglbh7hcw72ywb63407nxr2wh6z7-nixpkgs-review-2.7.0
copying path '/nix/store/rwycdglbh7hcw72ywb63407nxr2wh6z7-nixpkgs-review-2.7.0' from 'https://cache.nixos.org'...
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
From https://github.com/NixOS/nixpkgs
   9d0f7e2a819..07912c408a2  master     -> refs/nixpkgs-review/0
$ git worktree add /home/caleb/.cache/nixpkgs-review/rev-d2cb74254c9f27ff3d597bdd89a0071a6af6a915/nixpkgs 07912c408a223a18475e767dcf04fea8f5f1e140
Preparing worktree (detached HEAD 07912c408a2)
Updating files: 100% (32529/32529), done.
HEAD is now at 07912c408a2 lutris: set unshareIpc and unsharePid to false
$ nix-env --option system x86_64-linux -f /home/caleb/.cache/nixpkgs-review/rev-d2cb74254c9f27ff3d597bdd89a0071a6af6a915/nixpkgs -qaP --xml --out-path --show
trace
$ git merge --no-commit --no-ff d2cb74254c9f27ff3d597bdd89a0071a6af6a915
Automatic merge went well; stopped before committing as requested
$ nix-env --option system x86_64-linux -f /home/caleb/.cache/nixpkgs-review/rev-d2cb74254c9f27ff3d597bdd89a0071a6af6a915/nixpkgs -qaP --xml --out-path --show
trace --meta
1 package updated:
prom2json (1.3.0 → 1.3.2)

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/caleb/.cache/nixpkgs-review/rev-d2cb74254c9f27ff3d597bdd89a0071a6af6a915/build.nix
1 package built:
prom2json

$ /nix/store/3qilwj844f5wz18mh0lc6ffzj4gcca02-nix-2.11.0/bin/nix-shell /home/caleb/.cache/nixpkgs-review/rev-d2cb74254c9f27ff3d597bdd89a0071a6af6a915/shell.nix
[nix-shell:~/.cache/nixpkgs-review/rev-d2cb74254c9f27ff3d597bdd89a0071a6af6a915]$ cat report.json
{
    "blacklisted": [],
    "broken": [],
    "built": [
        "prom2json"
    ],
    "failed": [],
    "non-existant": [],
    "pr": null,
    "system": "x86_64-linux",
    "tests": []
}

@benley That's the fastest I've ever had a PR merged into nixpkgs (by a long shot). Thank you! :tada:

haha you are welcome!  It was just lucky timing - I happened to look at github notifications right after you opened your PR and it was right on top.


Artificer Minor/Major Elemental Infusions

I don't normally use either infusion, so it may just be the descriptive text, but the Minor Elemental Infusion adds an additional 1d6 of the chosen element type, and the Major only adds 1d4 of the chosen element type?  Shouldn't that be the other way around?  You can't stack Infusions on a weapon, so it's not like the 2 lots of extra damage can stack.
I don't have a save file, as I was just creating characters for a Custom campaign and noticed the text seems to be backwards.

Minor is once per turn. Major has no restrictions reason why.


Remove sessions from external cache, even if internal cache is not used

Section 7.2 of RFC5246 requires sessions to be invalidated after a fatal
alert.  OpenSSL calls SSL_CTX_remove_session() after a fatal alert to
invalidate the session.  SSL_CTX_remove_session() calls
remove_session_lock().
Prior to this commit, remove_session_lock() would only remove a session
from the external session cache if the session was found in the internal
session cache.  Therefore, when using an external session cache with the
SSL_SESS_CACHE_NO_INTERNAL_STORE cache modifier, sessions would not be
invalidated after fatal alerts.
This commit ensures that sessions are removed from the external cache
even if they are not present in the internal cache.

Also see this code:
https://github.com/openssl/openssl/blob/master/ssl/statem/statem_clnt.c#L1843
Looks like that might need to change too.

Closing this in favour of #1208

Yup, I believe all of your above points are correct.  Thanks!


evolution-ews: 3.36.5 -> 3.38.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for evolution-ews is: "Evolution connector for Microsoft Exchange Server protocols"
meta.homepage for evolution-ews is: "https://gitlab.gnome.org/GNOME/evolution-ews"
meta.changelog for evolution-ews is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.38.1 with grep in /nix/store/qz3ah31c0271rab24wvm5np3cp7ppa4n-evolution-ews-3.38.1

directory tree listing: https://gist.github.com/b7c00d15950c01b2891b848a5c344b14

du listing: https://gist.github.com/09687904abd335c37a22929c7db11050

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
evolution-ews

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qz3ah31c0271rab24wvm5np3cp7ppa4n-evolution-ews-3.38.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A evolution-ews https://github.com/r-ryantm/nixpkgs/archive/147bb7bd9c137a409d715b33e8e00769e4cffbf9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qz3ah31c0271rab24wvm5np3cp7ppa4n-evolution-ews-3.38.1
ls -la /nix/store/qz3ah31c0271rab24wvm5np3cp7ppa4n-evolution-ews-3.38.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package failed to build:

evolution-ews

Maintainer pings
cc @dasj19 for testing.

Full changelog:

Evolution-EWS 3.37.1 2020-04-24
Bug Fixes:

I#45 - Event time shifted by an hour after edit for some time zones (Milan Crha)

Evolution-EWS 3.37.2 2020-05-29
Bug Fixes:

I#99 - All-day events date shown by one day off (Milan Crha)
I#102 - Hidden folders are displayed normally in the UI (Milan Crha)
I#103 - Can't subscribe to a folder of a user whom is not in GAL (Milan Crha)

Miscellaneous:

SetupBuildFlags.cmake: Use -Werror=implicit-function-declaration only for C code compilation (Milan Crha)
EEwsNotification: Change how subscription to server change notifications work (Milan Crha)
Add parameter check into ews_get_error_code() (Milan Crha)

Evolution-EWS 3.37.3 2020-07-03
Bug Fixes:

evo-I#982 - 'Message contains'-search broken in 3.36.3 (Milan Crha)

Miscellaneous:

PrintableOptions.cmake: Sync the file with Evolution changes (Milan Crha)
camel_ews_folder_new: Remove useless reference on the CamelSettings (Milan Crha)

Translations:

Daniel Șerbănescu (ro)

Evolution-EWS 3.37.90 2020-08-07
Bug Fixes:

I#66 - Adapt the timezones test (Milan Crha)
I#66 - Correct how tests use uhttpmock (Milan Crha)
I#111 - Correct license comments in the source files (Milan Crha)

Miscellaneous:

Provided SoupAuth might not be always used by libsoup (Milan Crha)
Add (disabled by default) Microsoft 365 (Graph API) connector (Milan Crha)

Evolution-EWS 3.37.92 2020-09-04
Bug Fixes:

I#117 - Task completion date shifted by user's zone UTC offset (Milan Crha)
I#118 - Camel: Claim required credentials when authentication fails (Milan Crha)
eds-I#208 - Avoid race condition when refreshing collection backend (Milan Crha)

Translations:

Yuri Chornoivan (uk)
Zander Brown (en_GB)
Piotr Drąg (pl)
Daniel Mustieles (es)
Rafael Fontenelle (pt_BR)

Evolution-EWS 3.38.0 2020-09-11
Translations:

Mario Blättermann (de)
Aurimas Černius (lt)

Evolution-EWS 3.38.1 2020-10-02
Bug Fixes:

I#120 - Created public folder not visible after restart (Milan Crha)
I#123 - Show HTML Description in calendar entries, when available (Milan Crha)
evo-I#1097 - Provide HTML invitation description, when available (Milan Crha)

Miscellaneous:

Allow OAuth2 for any server, not only for outlook.office365.com (Milan Crha)

Translations:

Marek Černocký (cs)

Full changelog:

Evolution-EWS 3.37.1 2020-04-24
Bug Fixes:

I#45 - Event time shifted by an hour after edit for some time zones (Milan Crha)

Evolution-EWS 3.37.2 2020-05-29
Bug Fixes:

I#99 - All-day events date shown by one day off (Milan Crha)
I#102 - Hidden folders are displayed normally in the UI (Milan Crha)
I#103 - Can't subscribe to a folder of a user whom is not in GAL (Milan Crha)

Miscellaneous:

SetupBuildFlags.cmake: Use -Werror=implicit-function-declaration only for C code compilation (Milan Crha)
EEwsNotification: Change how subscription to server change notifications work (Milan Crha)
Add parameter check into ews_get_error_code() (Milan Crha)

Evolution-EWS 3.37.3 2020-07-03
Bug Fixes:

evo-I#982 - 'Message contains'-search broken in 3.36.3 (Milan Crha)

Miscellaneous:

PrintableOptions.cmake: Sync the file with Evolution changes (Milan Crha)
camel_ews_folder_new: Remove useless reference on the CamelSettings (Milan Crha)

Translations:

Daniel Șerbănescu (ro)

Evolution-EWS 3.37.90 2020-08-07
Bug Fixes:

I#66 - Adapt the timezones test (Milan Crha)
I#66 - Correct how tests use uhttpmock (Milan Crha)
I#111 - Correct license comments in the source files (Milan Crha)

Miscellaneous:

Provided SoupAuth might not be always used by libsoup (Milan Crha)
Add (disabled by default) Microsoft 365 (Graph API) connector (Milan Crha)

Evolution-EWS 3.37.92 2020-09-04
Bug Fixes:

I#117 - Task completion date shifted by user's zone UTC offset (Milan Crha)
I#118 - Camel: Claim required credentials when authentication fails (Milan Crha)
eds-I#208 - Avoid race condition when refreshing collection backend (Milan Crha)

Translations:

Yuri Chornoivan (uk)
Zander Brown (en_GB)
Piotr Drąg (pl)
Daniel Mustieles (es)
Rafael Fontenelle (pt_BR)

Evolution-EWS 3.38.0 2020-09-11
Translations:

Mario Blättermann (de)
Aurimas Černius (lt)

Evolution-EWS 3.38.1 2020-10-02
Bug Fixes:

I#120 - Created public folder not visible after restart (Milan Crha)
I#123 - Show HTML Description in calendar entries, when available (Milan Crha)
evo-I#1097 - Provide HTML invitation description, when available (Milan Crha)

Miscellaneous:

Allow OAuth2 for any server, not only for outlook.office365.com (Milan Crha)

Translations:

Marek Černocký (cs)

Resolved the merge conflict and bumped it further.

Resolved the merge conflict and bumped it further.

@jtojnar It works with evolution 3.38.3, apparently we need to upgrade the whole chain of packages ( evolution, evolution-ews and evolution-data-server)

@jtojnar It works with evolution 3.38.3, apparently we need to upgrade the whole chain of packages ( evolution, evolution-ews and evolution-data-server)

Evo and e-d-s changes look fine too so merging as you confirmed it works:

Evolution 3.38.3 2021-01-08
Bug Fixes:

I#1242 - Tasks: "Uncompleted Tasks" filter does not work as expected (Milan Crha)
I#1243 - tnef-attachment: Fails to decode some TNEF event attachments (Milan Crha)
I#1259 - Composer: Body from mailto: URI not enclosed in paragraphs (Milan Crha)
I#1262 - Composer: Forward -> Redirect includes account signature (Milan Crha)
I#1266 - Alternative Reply: Do not ellipsize template names (Milan Crha)
I#1286 - WebView: Change how scheme handlers are registered (Milan Crha)
I#1309 - templates: Remove signature in $ORIG[quoted-body] (Milan Crha)
I#1312 - templates: Reply-To field is not copied to the new message (Milan Crha)

Miscellaneous:

Add Kabyle translation into the e_supported_locales array (Milan Crha)
Composer: UL/OL not wrapped properly in Plain Text mode (Milan Crha)
EABContactFormatter: Remove obsolete WebKitGTK code (Milan Crha)

Translations:

Carmen Bianca BAKKER (eo)
Kjartan Maraas (nb)
Onno Giesmann (de)
Andika Triwidada (id)
Jordi Mas (ca)

Evolution-Data-Server 3.38.3 2021-01-08
Bug Fixes:

I#277 - Reminders: Preselect a reminder in the notification window (Milan Crha)
I#286 - Skip collection account refresh when parts disabled (Milan Crha)

Miscellaneous:

e-categories: Show migration runtime warning only if the file exists (Milan Crha)
DataCalView: Created objects could be notified twice (Milan Crha)
EReminderWatcher: Add detailed debug prints about the scheduled reminders (Milan Crha)
EReminderWatcher: Catch a race condition when creating a calendar view (Milan Crha)
alarm-notify: Provide application reference in canberra calls (Milan Crha)
CamelMimeFilterToHTML: Change how empty  is recognized (Milan Crha)
Addressbook:file backend: Prevent percent letter in photo filename (Milan Crha)

Translations:

Juliano de Souza Camargo (pt)
Hugo Carvalho (pt)
Jordi Mas (ca)


navbar_alert: Fix navbar alert inaccessibility.

Fixes #16079
Testing Plan:
GIFs or Screenshots:
Enable desktop notification

Ask me later

Never ask on this computer

Closing

@Gittenburg Please review these changes. 542acbc a2f0467

@shanukun Did you accidentally delete the branch?

@Gittenburg yes

If you repush the branch you might be able to reopen this PR.

Okay, I didn't know that. Thanks. but now I've already opened a new PR.


Does not run on Metro M7

The open command does not show up on the Metro M7. I tried this on a KB2040 and seems to work as expected.

Can you show what you're doing in more detail? I installed adafruit_wave with circup, then copied the simpletest files over, and imported the simpletest. It gave the results I expected, so we need to figure out what's different in our two setups.
$ circup install adafruit_wave
Version 1.1.2 of circup is outdated. Version 1.2.2 was released Thursday April 27, 2023.
Found device at /media/jepler/CIRCUITPY, running CircuitPython 8.2.0-beta.0-3-g0aaf5a4a98.
Downloading latest version for adafruit/Adafruit_CircuitPython_Bundle.

  [####################################]  100%
  [####################################]  100%
  [####################################]  100%

OK

Downloading latest version for adafruit/CircuitPython_Community_Bundle.

  [####################################]  100%
  [####################################]  100%
  [####################################]  100%

OK

Searching for dependencies for: ['adafruit_wave']
Ready to install: ['adafruit_wave']

Installed 'adafruit_wave'.

Adafruit CircuitPython 8.2.0-beta.0-3-g0aaf5a4a98 on 2023-05-28; Metro MIMXRT1011 with IMXRT1011DAE5A
>>> import wave_simpletest
2
1
[576, 1148, 1670, 2212, 2742, 3268, 3794, 4340, 4862, 5382, 5916, 6430, 6942, 7466, 7968, 8468, 8982, 9472, 9956, 10440, 10936, 11408, 11876, 12354, 12810, 13262, 13722, 14160, 14594, 15040, 15462, 15876, 16286, 16707, 17105, 17497, 17895, 18273, 18645, 19025, 19387, 19741, 20103, 20443, 20775, 21103, 21439, 21761, 22077, 22363, 22593, 22817, 23049, 23267, 23479, 23695, 23895, 24091, 24281, 24471, 24651, 24827, 25005, 25169, 25329, 25491, 25641, 25785, 25929, 26067, 26201, 26331, 26459, 26577, 26693, 26811, 26919, 27021, 27125, 27225, 27319, 27407, 27499, 27585, 27665, 27745, 27819, 27891, 27961, 28027, 28093, 28159, 28213, 28269, 28329, 28385, 28431, 28479, 28531, 28573]

I also double-checked that it was the copy in /lib that I imported and used:
>>> import adafruit_wave
>>> adafruit_wave.__file__
'/lib/adafruit_wave.mpy'

I downloaded straight from the bundle and it works now. Before I had just copied the .py from the repo. No idea why that made the difference. But it works! Thanks for looking at it.

I tested with the .py version on metro m7 and I got this:
Adafruit CircuitPython 8.2.0-beta.0-3-g0aaf5a4a98 on 2023-05-28; Metro MIMXRT1011 with IMXRT1011DAE5A
>>> import adafruit_wave
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
MemoryError: memory allocation failed, allocating 225 byte

I guess this may just be inevitable on the small-memory device. This module was adapted from standard python and was not written with memory economy in mind.

I did find that importing the garbage collector and running gc.collect() did allow me to load it. But I didn't even think that .py vs .mpy may have been the reason.


Is this related to https://code.google.com/p/gittorrent/ in any way?

Once more, with a clickable link: https://code.google.com/p/gittorrent/

@tv42 No, not meaningfully related -- I asked the developers of that project if I could reuse their name and they said sure.  Their design doesn't use a Distributed Hash Table at all (I think their project maybe predates BitTorrent's DHT!), whereas one is central to this project's design, so there's little in common other than the general idea of combining Git and BitTorrent.

That's what it looked like, thanks. Take this as a FAQ suggestion.

Close?

Sure.

I added this as the first question in a wiki FAQ.

@waldyrious Nice, thanks very much! Feel free to keep adding more.  :)


No page to direct into the game

The game directly loads in and there is no page to allow the user to choose when  to start playing

I will try to make good starting page


Library : frontend projects

to make UI more attractive and user friendly
to add navbar items
to add different sections like about, contact, and books

@MohitGupta121 @TusharKesarwani kindly assign the issue under GSSOC23


Lanczos for jax

Can we change this PR so that it doesn't change 15 files?

sure, I can do one backend at a time

Uhh, actually the problem is the linter. I had to adapt the signature of all eigsh_lanczos functions to the jax version to make the API consistent.

Aw ok. didn't realize we were chaning the function signature. This is fine then.

Thanks for the suggestion above, it's much better that way!

The tests I added should actually catch any issue with the numerics

Right, that's also I didn't check the code by hand. :)


Frame has not responded within 5 seconds. Check iFrameResizer.contentWindow.js has been loaded in iFrame.

Describe the bug
iFrameResizer was working perfectly fine from last couple of months but suddenly it stops resizing the iframe. When i checked the console a following error message comes up:
Frame has not responded within 5 seconds. Check iFrameResizer.contentWindow.js has been loaded in iFrame.
I tried setting it to 10 Seconds but it still not working but message changes from 5 Seconds to 10 Seconds. Not sure what has happened because this is happening 90% in Safari & Firefox but working on Chrome.
To Reproduce
Steps to reproduce the behavior:

Go to http://td.axtrics.com/ml-knightsbridge-gu10-ip65-aluminium-powder-coated-black-adjustable-wall-light-35w
Scroll down to Customer Questions & Answers tab and click the tab.
The tab will open but the content is hidden because iFrame is not resizing.
Check the console and you will find the above error in warning.

Expected behavior
It was working from last couple of months and we didn't changed anything on the code. It should be resized to fit the content.

Sounds like the contentWindow script is no longer being loaded in the iframe, or something is blocking postMessage in the browser

Thanks for the quick response David, I am using VueJS for the application and included the contentwindow script within the app.
I now tried adding the contentwindow script directly within the index.html of the build but it is still not working.
You can check here as well
https://www.gepetto.co.nz/squidgy-teething-square
Is there a way to identify what is blocking it if there is any?
Many Thanks

Would it be possible that Cloudflare is blocking it?

Maybe, but not heard of that being an issue before. Does it work if you run
everything locally?
On Thu, 28 May 2020 at 20:19, Rohan Sharma<EMAIL_ADDRESS>wrote:

Would it be possible that Cloudflare is blocking it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/davidjbradshaw/iframe-resizer/issues/818#issuecomment-635545494,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEQOEVB5IDE73NLBJKZU33RT22NNANCNFSM4NNJMWEA
.

--
Sent from my iPhone.

Well i didn't tested locally but yeah i found this important thing here about postMessage
https://community.cloudflare.com/t/window-postmessage-doesnt-reach-my-page-from-extension-anymore/167927
It seems the rocketloader is stopping it. I will try to disable that extension from Cloudflare network and see if it works.
Thanks Again

I disabled that rocketloader extension from cloudflare and it seems that not responding error is not anymore.
But in case of FireFox the iframe is not resized on page load but as soon as you click anywhere within the iframe if just resized perfectly. What could be the reason?
It is correct in chrome though.
Thanks Again

That is good to know, would be great if you could add that the troubleshooting page.
Not sure about the FireFox thing, that browser has had issue in the past with not detecting resizes if it does not have focus, or the iframe is in a hidden tab

Yes, It is not working because it is in hidden tab. See the links below:
https://sandbox.aframark.com/demo/frame.html
https://sandbox.aframark.com/demo/frame_hidden.html
The one which is not hidden is working everytime but the one which is hidden is not in case of Mozilla and sometime in safari.

This is how i am making it work but again it is not the best solution. So if an iframe is in hidden tab then our script will continue to check the iframe container is there is any offset width, Once it is greater than 0 then it will again call the iframe resize method.
function akLoadQA() {
var theScheduler;
var theSchedulerSecond;
var containerID = 'aframark-container';
var merchantDomain = document.domain;
var merchantCode = document.getElementById(containerID).getAttribute('data-ak-merchant-code');
var token = document.getElementById(containerID).getAttribute('data-ak-api-token');
var sku = document.getElementById(containerID).getAttribute('data-ak-sku');
var iframe = '';
var container = document.getElementById(containerID);
    /console.log(container.offsetWidth + '=' + container.offsetHeight);
    if (container.offsetWidth > 0) {
        clearTimeout(theScheduler);
        document.getElementById(containerID).innerHTML = iframe;
        document.getElementById(id).onload = function () {
            iFrameResize({
                    log: false, // Enable console logging
                    inPageLinks: true,
                    onResized: function (messageData) { // Callback fn when resize is received
                        if (messageData.height == 0 || messageData.height == 'NaN') {
                            theSchedulerSecond = setTimeout(akLoadQA, 1000);
                        } else {
                            clearTimeout(theSchedulerSecond);
                        }
                    }
                },
                '#ak-qa-box');
        }
    } else {
        theScheduler = setTimeout(akLoadQA, 1000);
    }
}

This will be fixed in V5 #1212


NPY201 rules seem to miss imports for NAN

Using the following test file should show multiple deprecation warnings - but only shows one while using ruff 0.5.0 (the latest afaik).
from numpy import nan, NaN, NAN

import numpy as np

np.NaN
np.NAN
np.nan

ruff check test_npy.py --preview --select NPY2
test_npy.py:5:1: NPY201 [*] `np.NaN` will be removed in NumPy 2.0. Use `numpy.nan` instead.
  |
3 | import numpy as np
4 |
5 | np.NaN
  | ^^^^^^ NPY201
6 | np.NAN
7 | np.nan
  |
  = help: Replace with `numpy.nan`

Found 1 error.
[*] 1 fixable with the `--fix` option

In reality, np.NAN is also not valid, so should raise an error, too.
Also, explicit imports (not used through np.xxx) seem to be completely ignored ...
Neither is from numpy import NaN, NAN (only from numpy import nan is still valid for numpy2.0).

Thanks for reporting this. I just checked the numpy release notes and they only mention the deprecation of NaN in favor of  nan.
Do you have a link to documentation saying that NAN has been deprecated well?
In case you're interested to PR a fix. PR is a good example on how to add new NUMPY deprecations.

not official documentation as much - but https://github.com/numpy/numpy/pull/26741 - and the pr actually removing both the NaN, as well as the NAN alias (https://github.com/numpy/numpy/pull/24376/files - search for NAN: Final[float] in numpy/__init__.pyi).
It's not in the release notes - but from actually trying it out - it's clear that it's been removed.

Closed by https://github.com/astral-sh/ruff/pull/12292.

@charliermarsh i tend to disagree.
As mentioned in the PR, the case of from numpy import nan, NaN, NAN (NAN and NaN shouldn't import as they've been removed) isn't covered in that PR.
Let me know if you'd prefer me to open a new issue for that, though its very closely related to this issue, as i reported both problems together.

@xmatthias -- You're saying that we should also catch from imports for those symbols, rather than just usages? I think that would be a separate issue since it applies to all of the cases in that rule and isn't specific to NAN (unless I'm misunderstanding).

yeah essentially exactly that
it's deprecated / removed from numpy just as NaN ... just ruff isn't warning it.
You're absolutely correct in that it'd apply to essentially all other entries, too.

I think that would be a separate issue

Works for me - will open one :+1:

Thanks!

mmmh, i realize now that while the import doesn't warn - usage does - so never mind :+1:


change HLL public API from CamelCase to lower_with_underscore

I think I got the public portions of hll.hpp changed. This can be extended to that whole file if we think it's warranted.

Actually, let's hold off on this a bit longer. I think I can do more fairly quickly.

Now I think this is ready for review. Renaming HllSketchImpl will take more work with less obvious short-term benefit.

looks good to me


DCOS-10987: [1/2] Separate JSON Flow

This is the first PR for the separate JSON flow that cleans-up the NewCreateServiceModalServicePicker, keeping only the 3 acceptable options for now, and adding a placeholder for the JSON-only view.
@jfurrow I tried to center the buttons for making them look like the design, but I didn't want to mess-up the CSS. Can you have a look? https://mesosphere.invisionapp.com/d/main#/console/9042004/193660846/preview

@wavesoft I pushed a commit, I hope you don't mind!
It should now look like this:

Perfect, thank you!

@wavesoft there's few nits from Michael, please consider them and merge 👍


Query - Is there any way to generate console log statements from a .Net Standard 2.0 library?

My Blazor project implements and consumes several .Net Standard 2.0 assets. From one of these is there any clever way to access the console logging supplied by the extension?

@galvesribeiro
Thanks; The issue went back to the same problem with the 'inject' in #15 leading me to believe that it couldn't work.

@galvesribeiro
I modified the 'inject' in my netstandard2.0 library and received an error message. I then created a Blazor dll  and received the same error when I try to log a message.
ORManagerView OnInitAsync() entry
blazor.webassembly.js:1 WASM: [System.ArgumentNullException] Value cannot be null.
blazor.webassembly.js:1 WASM: Parameter name: logger
blazor.webassembly.js:1 WASM:   at Optimiser.DataTier.RestServices.RestBaseService.GetAsync[TResult] (System.String controller) [0x0013c] in C:\Solutions\OHI\Optimiser\NG-Blazor\DataTier.Rest\RestServices\RestBaseService.cs:61

The first message 'ORMAnagerView OnInitAsync() entry' is logging output from the logging extension.
The error that follows results from using the injected property in an attempt to create a log message.
In a previous reply you stated "Assuming that your netstandard2.0 library rely on logging from Microsoft.Extensions.Logging and it is injected on the same DI context as blazor, you should be able to use this logger with the library without problems. "
I am not certain by the meaning of "and it is injected on the same DI context as blazor,"

Hey,
As I mentioned on other question, if you look at Blazor docs here https://blazor.net/docs/dependency-injection.html you will that you need to register your component on Blazor's service collection (DI container) like this:
public void ConfigureServices(IServiceCollection services)
{
    services.AddSingleton<IDataAccess, DataAccess>();
}

That is on your Startup.cs class.
Once you do that, your component can receive injected types from the DI container like in this case, ILoggerFactory , ILogger<T> or ILogger.
The error is clear. It is not able to inject the logger because (1) you are not adding the logger to the DI container or (2) you are not added your component to the container.
Note that Blazor components always leverage the container so it doesn't need to be injected there.
I would suggest a good read on Blazor docs. They are not extensive and give you a good feel on where things glue together.

Thanks, I had read that page about 3 times and I really didn't 'get it'. Once I realized I had to convert everything all the way up the chain to the actual Blazor page it finally made sense. I have things working but am not fully convinced that the DI pattern improved my code. I am used to explicitly managing object lifetimes. I may try an experiment and do dependencies the 'old fashioned' way by creating the truly needed services (HttpClient & ConsoleLog  so far) at the Blazor level and passing them as parameters down the chain of classes.
In any case, thanks for sticking with me over the many questions and lack of understanding.

No problem.
There are many advantages of using DI. I'm not advocating it but, if you look at all the current Microsoft ecosystem of libraries, they all somehow are tied to Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.Options.Abstractions and (soon) Microsoft.Extensions.Hosting.Abstractions. Those things cover all basic crosscutting concerns you would find on any kind of app.
You can still manage the lifecycle of the classes. Look at this article https://docs.microsoft.com/en-us/aspnet/core/fundamentals/dependency-injection?view=aspnetcore-2.1#service-lifetimes
It is focused on Asp.Net but use that DI abstractions and can give a overview on how to define lifetime of classes.
I hope it help.
Thanks


AntiAim will not disable with config load

anti aim config will remains on after changing to a legit config

So reset the antiaim config.

There is a "Reset" button in config window, use it before loading new config.


Integrate husky & lint-staged

This PR makes sure that every time we commit, prettier will run on the staged files and format them.
It also add recomendation for the prettier extension for vscode which includes the correct configuration.
Running yarn format will run prettier.

Approved @ranyitz .
@guytepper please review as well


Question: action space

Hello, Could you please tell me why the action space size is 2187, if the robot has 7 motors?

I used PPO with discrete action space, so a 7 degree of freedom system with the coarsest discretization a_i ∈ {−k, 0, k} for each joint and thus action space with dimensionality: 3^7 = 2187.
However, I think it is better to do this experiment with continuous action space. :sweat_smile:.


week title being weird + afterimage broken

Describe your bug here.

and after you change a character with character trails on, you get this

Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
no

1.3.0 will fix it.

thx
On Tue, May 17, 2022 at 3:19 PM notweuz @.***> wrote:

1.3.0 will fix it.
—
Reply to this email directly, view it on GitHub
https://github.com/weuz-github/FNF-OSEngine/issues/17#issuecomment-1129230684,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWZ2PVFATTVXPFCOZ6CRIRLVKPWNXANCNFSM5WDGNZ6A
.
You are receiving this because you authored the thread.Message ID:
@.***>


Reintroduce error message in "Connect Bank Account" flow when wrong bank account number is entered

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/16669
Tests

Main case this PR fixes

Log into an account without a Workspace VBA set up (create a new workspace if needed)
Go to Workspace settings > Connect bank account
Select the Connect online with Plaid method to add a bank account
On the bank account list select "Chase"
Enter the credentials "user_good / pass_good"
If a verification is prompted - select Mobile and enter "credentials_good" as the verification mode
Select the "Plaid Checking" and "Plaid Saving" accounts
Complete the flow (Check the 2 boxes under "additional information you want to share" > tap on Continue; check the T&C and click "Connect account information"; Tap on the last confirmation on the Plaid modal)
Once redirected back to NewDot, select the bank account ending in 1111. You'll be redirected to the enter back account details manually (this is a special case for the Chase bank account selection)
Enter routing number 011401533
Enter an incorrect bank account number (e.g<PHONE_NUMBER>334444)
Verify there's an error for entering the wrong bank account number

Regression test (Manual bank account setup with 2 devices)
Since https://github.com/Expensify/App/issues/16669 is a regression from https://github.com/Expensify/App/pull/15772, let's verify we don't break the case https://github.com/Expensify/App/pull/15772 intended to fix

Log into an account without a Workspace VBA set up (create a new workspace if needed)
Go to Workspace settings > Connect bank account
Select the Connect manually method to add a bank account
Type in incorrect routing and account numbers
In a second device, log in to the same account and navigate again to Workspace settings > Connect bank account
Enter routing and account numbers that satisfy the requirements (ex 041215032 and 123456), then continue on and complete Step 2 in the flow
Refresh the page in first device and verify that the Routing number and Account number are now updated to match that from your other device, and the inputs are disabled

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/7277067/233494633-8e06b0b3-2bd6-4d2b-8848-02385d751c71.mov
Regression test:

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@mananjadhav @deetergp One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@amyevans @deetergp Took some more time to complete testing both workflows and checklist. I had two questions:

The form continues if I put any random account ending 1111, I am guessing that is expected right?

I was getting the following error every time I clicked Start over (unrelated to the PR). did you folks come across this?

As I mentioned point 2 is unrelated to the PR as it happens for specific workspace on my account and goes when I logout and login again.

Ah sorry for jumping the gun on merging @mananjadhav, I had been under the impression you wouldn't be able to test this PR (basically the reason this bug was assigned as Internal in the first place 🙃). Is there a process documented somewhere for how you tested? I'd like to increase the visibility on that, since perhaps we could have had a contributor work on this PR after all.
To answer your questions,

The form continues if I put any random account ending 1111, I am guessing that is expected right?

Yeah that's expected, we only have the last 4 digits available to check against, so that has to be "good enough" here. (Plaid returns substitute numbers for Chase).

I was getting the following error every time I clicked Start over (unrelated to the PR). did you folks come across this?

Hmm, I did not come across that, but I didn't click Start over while I was testing. If you have reproducible steps feel free to report in the bugs Slack channel!

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.5-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@amyevans Looks like the regression test you provided in the testing steps wasn't able to pass on staging. Here's a screen recording provided by the QAers. Since this creates a regression and it's pretty late I'm going to revert this so we don't block deploy.
I think in the screen recording below the mobile device is the "second device" you're referring to in step 5 that enters the correct bank account info, and the desktop client is the "first device" that's supposed to get updated with the correct information entered in the second device.
https://user-images.githubusercontent.com/31285285/234474009-90928e50-a98f-45f3-b8b1-cfa5081e4144.mov

^ Sorry, QAers said PR caused a regression but just retested myself and it doesn't happen. Don't think they followed the test steps correctly

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.5-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Unable to setup: "No mowers found in this Bosch Indego account"

After completing the OAuth flow I am redirected to Home Assistant and get the dialog "No mowers found in this Bosch Indego account".

Model: S+ 500
Home Assistant: Only reachable locally via HTTP
Bosch Login: AppleID

Home Assistant logs after failed integration setup:

Thanks for your support!

Ah never mind, just saw https://github.com/jm-73/Indego/issues/186.
Setup with v5.2.1 works, but was not the latest stable in HACS.


quetzal-list-box and quetzal-list-combo-box don't expose value and selectedIndex

I am just playing around with Quetzal. It is great and very promising!
I would like to use <quetzal-list-box> and  <quetzal-list-combo-box> in some prototype app I am playing with. I have noticed that I have no way to read value of those boxes.
I think they should expose properties value and selectedIndex just like an HTML <select> element does.
In my app I just need selectedIndex (2 way bindable like selectedIndex="{{ currentSelection }}"). I am willing to experiment with writing a pull request about it.

Archiving this issue and switching to watch https://github.com/elix/elix 🍿
@JanMiksovsky, I appreciate your commitment to Web Components a lot!

@warpech Thanks for your kind words. Sorry this bug sat idle for so long!
In an odd bit of timing, I'm just now drafting the second Elix RFC, which specifically proposes how the project should handle single selection. Among other things, the proposal suggests a means by which we'll ensure that all Elix components that support single-selection expose a selectedIndex property. :) (We'll tackle how to do value later.) You can follow along by watching the Elix RFC repository; the proposal should appear as a pull request in the next week or so. I'll look forward to any comments you can offer.

Great, I will watch the RFC repo as well!


Toml comments

Our library for generating toml files doesn't support comments.
Options:

create PR to add comment support to toml library

this is define as planned improvment in repo so it would be nice to get in contact

use some other toml library that supports comments
create some hack around library (interfere while streaming to file or something)

@GregTheGreek Stalebot is closing all out on ice issues

unstale


Support for Protocol 13's Leaderboard

This closes https://github.com/Megabyte918/MultiOgar-Edited/issues/704, and closes https://github.com/Megabyte918/MultiOgar-Edited/issues/703
I wonder if Github will auto-close these issues when this is merged xD
->https://help.github.com/articles/closing-issues-via-commit-messages/

Thanks to @NuclearC for decoding the protocol

Kudos, it actually works! @Megabyte918 Merge this

you can remove protocol v11, its not used anymore by any client

@Tyler3D It's best to remove protocol 11, it existed for a very short time frame that obviously wasn't enough for anyone to make a client for it. And even if someone did make a client for it... Just remove it anyway, we don't endorse clients that aren't made by Moneyclip.

@Tyler3D i made client since protocol v9 :D

Guessing there is still some work to do, holding back before merging. Let me know once you're done.

@MastaCoder No, I'm done. I just wanted to remove protocol 11 and add the friend list thingy

🎉


Filter update with type ahead

@sanbornsen did you fix something and needed update on it ?

@maxandersen @dlabrecq I think currently what we have, can be merged to get things going. Since the branch for filter with URLs in planner is waiting for these changes to get on master. Fixing the examples and other beautification can come in the sequential versions. This doesn't break any current implementation, so all the existing places where this is used should be fine.

@sanbornsen if the only thing missing is updating examples - is that not a quick fix to do and then we can continue knowing the examples work and and not needing to create more technical debt than necessary ?
I agree we should get it in ASAP and hope @dlabrecq is okey to do so knowing you will do a follow up PR, but seems like fixing examples are a simple fix?

@maxandersen The example is not the only issue which has not been addressed.

@maxandersen @dlabrecq I have added couple of examples for queries with image and icon.

@dlabrecq You have seen the UX, and I hope you understood what I am trying to do here. Can you give me a list of tasks that takes to get this PR approved?

@joshuawilson I believe this is ready to merge now.


Drawing strings on Node2D in various sizes makes the text glitching

It's my first issue here, and I haven't found any similiar here, I hope I did it correctly :)
Godot version:
3.0.2 32-bit
OS/device including version:
Tested on two computers:

Linux Mint, ATI Radeon HD 5650
Windows 10, Intel HD Graphics
Same problem on both.

Issue description:
I want to draw two strings on the screen, in various sizes. When I launch the application, only the last drawn string seems to look properly, others are glitched.
How's it looking:

Additionally, these errors are appearing in the console.

Steps to reproduce:
It's a bit complex, so I'm leaving a reproduction project. It should be clear since I haven't added anything but this yet :)
Minimal reproduction project:
RailTycoon.zip
Open it and you'll see the problem immediately.

I see this on linux 64-bit git master too.

This bug comes from the DynamicFontData resource purging its cache too early, since there is no font using the small text's size between the draw_string call and the time it is drawn by the rasterizer.
A script proving my point:
extends Node2D

var font = load("res://fnt/font.tres")
var font2

func _ready():
	font2 = font.duplicate()
	set_process(true)

func _process(delta):
	update()

func _draw():
	# Swap those 2 lines:
	font.size = 16
	draw_string(font, Vector2(20, 20), "Small text - you can't read it, it's glitched!", Color(1.0, 1.0, 0.0))
	# With those 2 lines:
	font.size = 32
	draw_string(font, Vector2(20, 60), "Big text - you can read it without any problems!", Color(1.0, 1.0, 1.0))
	# And it would break, since no font refers to size 32 until it gets in the rasterizer

Note that creating the duplicate in a local variable in _draw() does not work either:
func _draw():
	var font2 = font.duplicate()
	#! With var, it frees the font by the end of _draw, which is too early
	# When using a var declared in the script (a member instead of local), it works
	font2.size = 32
	draw_string(font, Vector2(20, 20), "Small text - you can't read it, it's glitched!", Color(1.0, 1.0, 0.0))
	draw_string(font2, Vector2(20, 60), "Big text - you can read it without any problems!", Color(1.0, 1.0, 1.0))

May be a duplicate or at least related to
#15023
#9024

Thank for the references, I had forgotten it has happened in the past.
Given that the other cases were closed as non-bugs, I would retag this as documentation, since a mention of such behaviour can't hurt.

It's not clear to me what the documentation will say. It does seem broken. Or I am missing some important point. This does not solve the problem but I thought it would. I am running git master
var myfnt

func mkfont(fsize):
    myfnt = DynamicFont.new()
    myfnt.size = fsize
    myfnt.set_font_data(load("res://fnt/font.tres"))

func _ready():
    pass

func _draw():
    mkfont(16)
    draw_string(myfnt, Vector2(20, 20), "Small- can't read it, it's glitched!", Color(1.0, 1.0, 0.0))
    mkfont(26)
    draw_string(myfnt, Vector2(20, 60), "Big - you can read it!", Color(1.0, 1.0, 0.0))

Could not figure out how to make a font.tres file either, may be gone in 3.1

try to load .ttf or .otf instead of font.tres

@volzhs that doesn't change behavior here.

This example works for me
var myfnt1
var myfnt2

func mkfont(fsize):
	var fnt = DynamicFont.new()
	fnt.size = fsize
	fnt.set_font_data(load("res://NanumBarunGothic.ttf"))
	return fnt

func _draw():
	myfnt1 = mkfont(16)
	draw_string(myfnt1, Vector2(20, 20), "Small- can't read it, it's glitched!", Color(1.0, 1.0, 0.0))
	myfnt2 = mkfont(26)
	draw_string(myfnt2, Vector2(20, 60), "Big - you can read it!", Color(1.0, 1.0, 0.0))

it's because the first font resource is freed after _draw function ends, not referenced anywhere, in your code example.

Ok, it's a feature. That doesn't scale very well. If you have 25 different sizes you want to print then you need to declare 25 variables. I guess you could create a list of fonts. Kind of cumbersome. And then you may never use the font again. Does that cause memory growth as the different fonts are added?

I'm not sure how much memory is taken by DynamicFont.
but AFAIK, the texture for rendering font is created on the fly, only when displaying it.

Can anyone still reproduce this on 3.2 or the master branch?

Still glitching


Can't use container exec on container groups with multiple containers

If you attempt to use az container exec in 2.0.30 on a container group with multiple containers, you get an error saying --container-name is required even if you supply it:
az container exec -g $resourceGroup -n $containerGroupName --container-name "front-end" `
    --exec-command "/bin/bash"
--container-name required when container group has more than one container.

Looks like the logic in this if statement doesn't account for the situation when there are multiple containers and the container name has been supplied:
https://github.com/Azure/azure-cli/blob/5f1a9c621bfc8b15b17f53399e37e43a8c55aa4c/src/command_modules/azure-cli-container/azure/cli/command_modules/container/custom.py#L261

This was fixed in PR #5927 and will be in the next release.


3.1 Update causes crashing on startup

Update 3.0.5 to 3.1 and a crash occurs on launch of aqm2
https://gist.github.com/itsdinkd/d2607533abacb143fb9cf8e355509283

I made a mistake tagging the 3.1 versions for <= 1.19.2 because it's usually backwards compatible.  Untagged it on CurseForge.  Use 3.0.5/3.0.6 for <= 1.19.2


unpin the starknet version

https://github.com/apibara/starknet-react/blob/a725fa891960f95a0dbf8994a420ff23f2738e34/package.json#L43
this should be ^5.12.0
why is it locked to 5.12? it forces me to have 2 versions of starknet in my app

That's true. Let me fix this now.

I see it sneaked it somehow. I saw it in peerDependencies and didn't check dependencies. Will fix now.

Feel free to reopen if the fix actually didn't fix it 😅


common: Remove use of TeardownSocketTcti.

This function has been removed from the socket TCTI upstream. All finalization
should be done through the finalize function pointer in the TCTI
structure. tss2_tcti_finalize is the right helper macro for this. We must
deallocate the TCTI context structure ourselves now too. Finally this patch
also removes the return value from the TeardownTctiResMgrContext function.
None of the finalization functions return any data and we were never checking
this value anyways.
Signed-off-by: Philip Tricca<EMAIL_ADDRESS>

This resoves #97


virtcontainers: qemu: Don't shutdown QMP from hotplug

The QMP shutdown is taken care of by the sandbox release, through a
call to hypervisor.disconnect(). By shutting down the QMP at the qemu
level directly, we are creating some unrecoverable errors by trying to
close an already closed channel.
This patch simply removes the faulty code, following the same design
other hotplug functions are designed.
Fixes #627
Signed-off-by: Sebastien Boeuf<EMAIL_ADDRESS>

Split from initial PR #623

LGTM

lgtm

Ignoring zuul...

No need to backport since the network hotplug feature introducing this bug is not part of stable-1.1 or stable-1.2.


4.0.0-beta.237

feat: Domains, resources, teams, deployments API endpoints.
feat: On self-hosted instances, if not notifications are set, show a popup.
feat: Pre/Post deployment commands!
feat: Caddy integration (experimental).
feat: Show resources for each Git Source.
fix: Moved notifications on a separate view.
fix: Make initial file/dir creation an async job.

Issues

fix #1813
fix #1728
fix #1827
fix #1826
fix #1838
fix #1830

Sugestion use this package composer require tightenco/parental and create a base WebHook model.

id string; Generate a string with 32 chars or more
type string; parental type
auth_type string; none, basic, bearer, ...
credentials json; encrypted
model; a morph type field to any model
extra_attributes?

After this you can just create many dependecy of this model and have like DeployApplicationWebhook
with a common function to execute custom action inside the model

Sugestion use this package composer require tightenco/parental and create a base WebHook model.

id string; Generate a string with 32 chars or more
type string; parental type
auth_type string; none, basic, bearer, ...
credentials json; encrypted
model; a morph type field to any model
extra_attributes?

After this you can just create many dependecy of this model and have like DeployApplicationWebhook with a common function to execute custom action inside the model

Thanks for the suggestion, but at the moment, I won't use this method.


Differences in free nats clipping between Dreamer, early and final PlaNet implementation

In PlaNet you changed the calculation of the free nats between the latest two commits from (5bb34f9)
loss = tf.maximum(tf.cast(free_nats, tf.float32), loss)

to (cbe77fc)
loss = tf.maximum(0.0, loss - float(free_nats))

Now in Dreamer you seem to have reverted back to the first version, again
https://github.com/danijar/dreamer/blob/2d58db947b05ef1fba57dbc18cd7c2b774136ee5/dreamer.py#L175
As I see it, the two versions should be equivalent to

loss = tf.clip_by_value(loss, clip_value_min=free_nats)
loss = tf.clip_by_value(loss, clip_value_min=free_nats) - free_nats

if I'm not mistaken. So one will always clip the KL-loss to at least the value of the free nats, while the other will always reduce the loss by the value of the free nats (without making the loss negative)?
Which one is the preferred approach to free nats clipping?

The two have versions have the same gradient, so the choice does not influence the model training. The only difference is what number is logged as the loss so it's up to personal preference.

Sure, that explains it! My bad. Thanks!


Document breaking changes

Could you update the github release page with a list of breaking changes from v2.x to v3.x. There seem to be quite a few that I've found so far:

Must use nsp.sanitizeParameters({}) to get nsp to provide same default baseUrl in v2.x, or define baseUrl in your args
nsp.sanitizeParameters should not throw away your args like pkg, packagelock, shrinkwrap, but it does so add them after sanitize
Must not define package.json with pkg parameter, wasn't a requirement in v2.x
nsp.check moved from a callback to a promise
Formatters are removed. They are replaced by reporters.

--reporter has been moved to --output / -o