Add CI

To Do:

[ ] Add Git to actual docker image
[ ] figure out why submodules aren't auto-installing? @jtcohen6 halp plz
[ ] add a local version of SQL server for testing as well

Looks like the CI failures have to do with the dbt seed step. These are tricky:

Cannot find data type 'timestamp'.
Cannot insert an explicit value into a timestamp column. Use INSERT with a column list to exclude the timestamp column, or insert a DEFAULT into the timestamp column.
A table can only have one timestamp column. Because table 'data_dateadd' already has one, the column 'result' cannot be added.

It's possible that we'll need to:

Disable the seed coming from dbt_utils_integration_tests
Recreate the seed (different name) + staging view (same name) to replicate the test setup

Cannot find data type 'timestamp'.

Cannot insert an explicit value into a timestamp column. Use INSERT with a column list to exclude the timestamp column, or insert a DEFAULT into the timestamp column.

A table can only have one timestamp column. Because table 'data_dateadd' already has one, the column 'result' cannot be added.

yeah these definitely seem T-SQL specific. I'll ask @NandanHegde15 to take a look at those errors. I agree we might have to make different versions of the csvs if we can't fix it adapter-side.
meanwhile, is there a way to disable that set of seeds so we can get some feedback on which macros work and which don't?

meanwhile, is there a way to disable that set of seeds so we can get some feedback on which macros work and which don't?

I think you can update what's here to be:
seeds:
  dbt_utils_integration_tests:
    cross_db:
      data_date_trunc:
        +enabled: false
      data_dateadd:
        +enabled: false
      data_datediff:
        +enabled: false
      data_last_day:
        +enabled: false
    etc:
      data_people:
        +enabled: false
    sql:
      data_get_query_results_as_dict
        +enabled: false
      data_safe_add
        +enabled: false
    schema_tests:
      data_test_mutually_exclusive_ranges_with_gaps:
        +enabled: false
      data_test_not_null_where:
        +enabled: false

models:
  dbt_utils_integration_tests:
    cross_db_utils:
      +enabled: true
      test_date_trunc:
        +enabled: false
      test_dateadd:
        +enabled: false
      test_datediff:
        +enabled: false
      test_last_day:
        +enabled: false
    datetime:
      +enabled: true
    materializations:
      +enabled: false
    schema_tests:
      +enabled: false
    sql:
      +enabled: true
      test_safe_add:
        +enabled: false
    web:
      +enabled: false

The issue I'm seeing now is that in T-SQL, the type timestamp is really datetime (timestamp is a special thing in T-SQL that's mostly deprecated now). So if I want to change the column types in dbt-utils's 'integration_tests/dbt_project.yml` how might one do that?
seeds:

  +quote_columns: false
  dbt_utils_integration_tests:

    cross_db:
      data_date_trunc:
        +column_types:
          updated_at: timestamp
          day: date
          month: date

      data_dateadd:
        +column_types:
          from_time: timestamp
          result: timestamp

      data_datediff:
        +column_types:
          first_date: timestamp
          second_date: timestamp

the way you just did it is what I was going to recommend :)

ok now we're getting juicy, actionable information! thanks @jtcohen6!
Database Error in model test_current_timestamp (models/cross_db_utils/test_current_timestamp.sql)
  ('42000', "[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near '::'. (102) (SQLExecDirectW)")
  compiled SQL at target/run/dbt_utils_integration_tests/models/cross_db_utils/test_current_timestamp.sql

Database Error in model test_current_timestamp_in_utc (models/cross_db_utils/test_current_timestamp_in_utc.sql)
  ('42000', "[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near '::'. (102) (SQLExecDirectW)")
  compiled SQL at target/run/dbt_utils_integration_tests/models/cross_db_utils/test_current_timestamp_in_utc.sql

Database Error in model test_date_spine (models/datetime/test_date_spine.sql)
  ('42000', "[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near the keyword 'with'. (156) (SQLExecDirectW)")
  compiled SQL at target/run/dbt_utils_integration_tests/models/datetime/test_date_spine.sql

Database Error in model test_date_trunc (models/cross_db_utils/test_date_trunc.sql)
  ('42000', "[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]'date_trunc' is not a recognized built-in function name. (195) (SQLExecDirectW)")
  compiled SQL at target/run/dbt_utils_integration_tests/models/cross_db_utils/test_date_trunc.sql

Database Error in model test_generate_series (models/sql/test_generate_series.sql)
  ('42000', "[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near the keyword 'with'. (156) (SQLExecDirectW)")
  compiled SQL at target/run/dbt_utils_integration_tests/models/sql/test_generate_series.sql

Database Error in model test_get_column_values (models/sql/test_get_column_values.sql)
  ('42000', '[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Each GROUP BY expression must contain at least one column that is not an outer reference. (164) (SQLExecDirectW)')

Database Error in model test_get_relations_by_pattern (models/sql/test_get_relations_by_pattern.sql)
  ('42000', "[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near '-'. (102) (SQLExecDirectW)")

Database Error in model test_get_relations_by_prefix_and_union (models/sql/test_get_relations_by_prefix_and_union.sql)
  ('42000', "[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near '-'. (102) (SQLExecDirectW)")

Database Error in model test_groupby (models/sql/test_groupby.sql)
  ('42000', '[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Each GROUP BY expression must contain at least one column that is not an outer reference. (164) (SQLExecDirectW)')
  compiled SQL at target/run/dbt_utils_integration_tests/models/sql/test_groupby.sql

Database Error in model test_hash (models/cross_db_utils/test_hash.sql)
  ('42S22', "[42S22] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Invalid column name 'field'. (207) (SQLExecDirectW)")
  compiled SQL at target/run/dbt_utils_integration_tests/models/cross_db_utils/test_hash.sql

Database Error in model test_last_day (models/cross_db_utils/test_last_day.sql)
  ('42000', "[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]'date_trunc' is not a recognized built-in function name. (195) (SQLExecDirectW)")
  compiled SQL at target/run/dbt_utils_integration_tests/models/cross_db_utils/test_last_day.sql

Database Error in model test_length (models/cross_db_utils/test_length.sql)
  ('42000', "[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]'length' is not a recognized built-in function name. (195) (SQLExecDirectW)")
  compiled SQL at target/run/dbt_utils_integration_tests/models/cross_db_utils/test_length.sql

Database Error in model test_position (models/cross_db_utils/test_position.sql)
  ('42000', "[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near 'string_text'. (102) (SQLExecDirectW)")
  compiled SQL at target/run/dbt_utils_integration_tests/models/cross_db_utils/test_position.sql

Database Error in model test_split_part (models/cross_db_utils/test_split_part.sql)
  ('42000', "[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]'split_part' is not a recognized built-in function name. (195) (SQLExecDirectW)")
  compiled SQL at target/run/dbt_utils_integration_tests/models/cross_db_utils/test_split_part.sql

Database Error in model test_surrogate_key (models/sql/test_surrogate_key.sql)
  ('42S22', "[42S22] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Invalid column name 'field'. (207) (SQLExecDirectW)")
  compiled SQL at target/run/dbt_utils_integration_tests/models/sql/test_surrogate_key.sql

Database Error in model test_width_bucket (models/cross_db_utils/test_width_bucket.sql)
  ('42000', "[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]'mod' is not a recognized built-in function name. (195) (SQLExecDirectW)")
  compiled SQL at target/run/dbt_utils_integration_tests/models/cross_db_utils/test_width_bucket.sql

Done. PASS=14 WARN=0 ERROR=16 SKIP=0 TOTAL=30


Question: Are you planning to release the latest version in maven ?

Maven has version 1.0.0 which does not contain latest commits of JCB card types.
Are you planning to release any new version based out of latest commits ?

Sorry for the late reply @madhu314, I will be publishing 1.0.1 in the near future. Stay tuned!

@madhu314 https://github.com/prolificinteractive/HouseOfCards/releases/tag/v1.0.1


Semkiv/chat remake

Added endpoint to get or create chatRoom by applicationId, also added validation by application to sendMessage method

@ita-social-projects/oos-frontend#2113


Add the Brazilian language to the plugin

Please add the language of Brazil in the factions plugin.

stop creating new issues, we don't have Brazilian translators.

Duplicate of #47.


Disable redirect calls to app itself via envoy

It makes calls from the app by the pod ip to itself bypasses the envoy proxy.
This can fix headless service instances accessing themselves when mtls enabled.

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
7f6ba9ff128b7f3c8bbac5c070ea5c11e8a4fa4a
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
7f6ba9ff128b7f3c8bbac5c070ea5c11e8a4fa4a
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-new-install-k8s-tests_istio
7f6ba9ff128b7f3c8bbac5c070ea5c11e8a4fa4a
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
7f6ba9ff128b7f3c8bbac5c070ea5c11e8a4fa4a
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-new-install-k8s-tests_istio
7f6ba9ff128b7f3c8bbac5c070ea5c11e8a4fa4a
link
/test integ-new-install-k8s-tests_istio

integ-pilot-k8s-tests_istio
7f6ba9ff128b7f3c8bbac5c070ea5c11e8a4fa4a
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
7f6ba9ff128b7f3c8bbac5c070ea5c11e8a4fa4a
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-new-install-k8s-tests_istio
7f6ba9ff128b7f3c8bbac5c070ea5c11e8a4fa4a
link
/test integ-new-install-k8s-tests_istio

integ-pilot-k8s-tests_istio
7f6ba9ff128b7f3c8bbac5c070ea5c11e8a4fa4a
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
7f6ba9ff128b7f3c8bbac5c070ea5c11e8a4fa4a
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
7f6ba9ff128b7f3c8bbac5c070ea5c11e8a4fa4a
link
/test integ-new-install-k8s-tests_istio

integ-pilot-k8s-tests_istio
7f6ba9ff128b7f3c8bbac5c070ea5c11e8a4fa4a
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
7f6ba9ff128b7f3c8bbac5c070ea5c11e8a4fa4a
link
/test integ-security-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
99fa4877481350bbba5940d75dcf2399600a7a71
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
7f6ba9ff128b7f3c8bbac5c070ea5c11e8a4fa4a
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
7f6ba9ff128b7f3c8bbac5c070ea5c11e8a4fa4a
link
/test integ-security-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
99fa4877481350bbba5940d75dcf2399600a7a71
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-new-install-k8s-tests_istio
99fa4877481350bbba5940d75dcf2399600a7a71
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
7f6ba9ff128b7f3c8bbac5c070ea5c11e8a4fa4a
link
/test integ-security-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
99fa4877481350bbba5940d75dcf2399600a7a71
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-new-install-k8s-tests_istio
99fa4877481350bbba5940d75dcf2399600a7a71
link
/test integ-new-install-k8s-tests_istio

integ-pilot-k8s-tests_istio
99fa4877481350bbba5940d75dcf2399600a7a71
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
99fa4877481350bbba5940d75dcf2399600a7a71
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-new-install-k8s-tests_istio
99fa4877481350bbba5940d75dcf2399600a7a71
link
/test integ-new-install-k8s-tests_istio

integ-pilot-k8s-tests_istio
99fa4877481350bbba5940d75dcf2399600a7a71
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
99fa4877481350bbba5940d75dcf2399600a7a71
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
99fa4877481350bbba5940d75dcf2399600a7a71
link
/test integ-new-install-k8s-tests_istio

integ-pilot-k8s-tests_istio
99fa4877481350bbba5940d75dcf2399600a7a71
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
99fa4877481350bbba5940d75dcf2399600a7a71
link
/test integ-security-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
bb38aeaf770684f12cfdb344af79d517045ff8ef
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
99fa4877481350bbba5940d75dcf2399600a7a71
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
99fa4877481350bbba5940d75dcf2399600a7a71
link
/test integ-security-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
bb38aeaf770684f12cfdb344af79d517045ff8ef
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-new-install-k8s-tests_istio
bb38aeaf770684f12cfdb344af79d517045ff8ef
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
99fa4877481350bbba5940d75dcf2399600a7a71
link
/test integ-security-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
bb38aeaf770684f12cfdb344af79d517045ff8ef
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-new-install-k8s-tests_istio
bb38aeaf770684f12cfdb344af79d517045ff8ef
link
/test integ-new-install-k8s-tests_istio

integ-pilot-k8s-tests_istio
bb38aeaf770684f12cfdb344af79d517045ff8ef
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
bb38aeaf770684f12cfdb344af79d517045ff8ef
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-new-install-k8s-tests_istio
bb38aeaf770684f12cfdb344af79d517045ff8ef
link
/test integ-new-install-k8s-tests_istio

integ-pilot-k8s-tests_istio
bb38aeaf770684f12cfdb344af79d517045ff8ef
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
bb38aeaf770684f12cfdb344af79d517045ff8ef
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
bb38aeaf770684f12cfdb344af79d517045ff8ef
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-new-install-k8s-tests_istio
bb38aeaf770684f12cfdb344af79d517045ff8ef
link
/test integ-new-install-k8s-tests_istio

integ-pilot-k8s-tests_istio
bb38aeaf770684f12cfdb344af79d517045ff8ef
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
bb38aeaf770684f12cfdb344af79d517045ff8ef
link
/test integ-security-k8s-tests_istio

lint_istio
7c7dbe84e2d009936b6705b8da90ca6924f08aa9
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
bb38aeaf770684f12cfdb344af79d517045ff8ef
link
/test integ-security-k8s-tests_istio

lint_istio
7c7dbe84e2d009936b6705b8da90ca6924f08aa9
link
/test lint_istio

integ-new-install-k8s-tests_istio
7c7dbe84e2d009936b6705b8da90ca6924f08aa9
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
7c7dbe84e2d009936b6705b8da90ca6924f08aa9
link
/test lint_istio

integ-new-install-k8s-tests_istio
7c7dbe84e2d009936b6705b8da90ca6924f08aa9
link
/test integ-new-install-k8s-tests_istio

integ-security-k8s-tests_istio
7c7dbe84e2d009936b6705b8da90ca6924f08aa9
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
7c7dbe84e2d009936b6705b8da90ca6924f08aa9
link
/test lint_istio

integ-new-install-k8s-tests_istio
7c7dbe84e2d009936b6705b8da90ca6924f08aa9
link
/test integ-new-install-k8s-tests_istio

integ-security-k8s-tests_istio
7c7dbe84e2d009936b6705b8da90ca6924f08aa9
link
/test integ-security-k8s-tests_istio

unit-tests_istio
189c26bc3cce3ca535ffb5822687def7a43aea5f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
189c26bc3cce3ca535ffb5822687def7a43aea5f
link
/test unit-tests_istio

integ-security-k8s-tests_istio
189c26bc3cce3ca535ffb5822687def7a43aea5f
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/test all
@rshriram ptal

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
189c26bc3cce3ca535ffb5822687def7a43aea5f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Not related TestStreamSecretsForWorkloadSds  flakes
/retest

@lambdai ptal

@abhide This is the iptables part change, added ut as you required.

ping @rshriram For approval

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-cni_istio
830a2dc404f48771f195276b5b3ce06d130010f9
link
/test e2e-simpleTests-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-cni_istio
830a2dc404f48771f195276b5b3ce06d130010f9
link
/test e2e-simpleTests-cni_istio

unit-tests_istio
830a2dc404f48771f195276b5b3ce06d130010f9
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Naive question: Looks like this PR is workaround. What is missing to enable mtls + headless as plain k8s service?
I have the impression that @yangminzhu made authn V2.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-cni_istio
830a2dc404f48771f195276b5b3ce06d130010f9
link
/test e2e-simpleTests-cni_istio

unit-tests_istio
3c4b44d75c583d9828bab43ba0f14547cf65e94c
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@hzxuzhonghu The description of this PR gives me the indication that mtls+headless when appA calls another appB is passing.
But @incfly told me not.
If so, we don't really need to make app calling itself pass. WDYT?

@hzxuzhonghu The description of this PR gives me the indication that mtls+headless when appA calls another appB is passing.

It can pass if it is not auto mtls, for auto mtls it can not pass.  As in the client side, when TransportSocketMatches set, the TlsContext is set to nil, but as the cluster type is not eds type, so the TransportSocketMatches actually does not take effect. But i think this kind of fix is not complicated.

If so, we don't really need to make app calling itself pass. WDYT?

Actually we need, we should keep it accessible no matter by which way. Because we can never imagine how users contact with their service.

cc @howardjohn

cc @nrjpoddar @andrewjjenkins will this break you? I remember something related to this before

This will not break any connection, it is a bug fix under mtls.

@hzxuzhonghu I believe they had a use case specifically that calls to the same pod ARE directed through envoy
context https://github.com/istio/istio/issues/12551

@hzxuzhonghu @howardjohn I think we wanted the calls made by Pod to itself to go through the sdiecar so that there's a uniform way of thinking about Policy and Telemetry irrespective of the destination.
This change would prevent us from gathering telemetry for this use case which might be useful. One way to solve this would have been to route the traffic via Envoy and call all the filters but don't do mTLS when Pod is talking to itself.

This change would prevent us from gathering telemetry for this use case which might be useful. One way to solve this would have been to route the traffic via Envoy and call all the filters but don't do mTLS when Pod is talking to itself.

This is not viable at the moment. I would like to make it accessible first before considering telemetry and policy.  Users can accept feature lost but can not tolerate traffic blocked, which may break down the system.

@hzxuzhonghu let me give it another quick attempt to by enable sidecar envoy on calling self pod ip : https://github.com/istio/istio/pull/19715

@lambdai Do you remember what https://github.com/istio/istio/pull/15710 does? Is it a bug fix?

@incfly @howardjohn Would you approve? The one in CNI repo is in.

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
3c4b44d75c583d9828bab43ba0f14547cf65e94c
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
3c4b44d75c583d9828bab43ba0f14547cf65e94c
link
/test integ-pilot-k8s-tests_istio

pilot-multicluster-e2e_istio
3c4b44d75c583d9828bab43ba0f14547cf65e94c
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
3c4b44d75c583d9828bab43ba0f14547cf65e94c
link
/test integ-pilot-k8s-tests_istio

pilot-multicluster-e2e_istio
3c4b44d75c583d9828bab43ba0f14547cf65e94c
link
/test pilot-multicluster-e2e_istio

lint_istio
a32f92653ad3cad7ea53b896fd10686aa84ddf5e
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
a32f92653ad3cad7ea53b896fd10686aa84ddf5e
link
/test lint_istio

unit-tests_istio
e2b93ef74ca0d28f1023175a973149b0c6a7a94f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
e2b93ef74ca0d28f1023175a973149b0c6a7a94f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio


[ZEPPELIN-1654] Fix csv/tsv download

What is this PR for?
Downloaded csv, tsv file contains only header of table after https://github.com/apache/zeppelin/pull/1529 is merged
What type of PR is it?
Hot Fix
Todos

[x] - Fix csv/tsv download

What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1654
How should this be tested?
Screenshots (if appropriate)
Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

Merge to master as a Hotfix.


[SC-762] Update copyright

Codecov Report
Patch and project coverage have no change.

Comparison is base (b3f6f9e) 81.51% compared to head (b9005dd) 81.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   81.51%   81.51%
=======================================
  Files          23       23
  Lines         606      606
  Branches      142      142
=======================================
  Hits          494      494
  Misses        112      112

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Support typebox 0.27.8

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal
Support Typebox 0.27.8, currently we use "@sinclair/typebox": "^0.26.4" in package.json.
Motivation
The versions in the meantime have some nifty features :)
Example
This example from Typebox docs does not work with the current version 0.26.4:
type PointOptions = { }                              // The Type Options

type PointType = { x: number, y: number }            // The Static<T> Type

const Point = TypeSystem.Type<PointType, PointOptions>('Point', (options, value) => {
  return (
    typeof value === 'object' && value !== null &&
    typeof value.x === 'number' &&
    typeof value.y === 'number'
  )
})

const T = Point()

type T = Static<typeof T>                            // <-- throws type error

const R = Value.Check(T, { x: 1, y: 2 })              // const R = true

nothing, I just shipped it.


add Dash blocks, transactions

used in Dash ipld resolver

@samli88 was this discussed anywhere?  If so a link to the discussion would be helpful.

Hi @kevina , no, I have not discussed this with anyone.
Is there some one I should discuss this with before making a PR?


Return a authentication token

Not an issue with the gem but I just need some help with returning token.
I am using devise_auth_token gem in my rails-api app.
I have a route in my api app that will response
{ "url": google-oauth-login-url }
The frontend app use that route to put it in the login with google btn.
After a user click in the btn they will be redirected to google oauth page and after filling in the details they will be then redirected to the frontend home page with the google code in the url.
The frontend app will send a req to the api server with the code and the server will req to the google server again to exchange that google code for access-token, refresh token and all that.
After the server receives those token, the server again makes another req to the google server to fetch user profile.
The user is then saved to db with the access token as well.
password = Devise.friendly_token[0,10]
			@resource = Employee.new({
				name: user_info["displayName"],
				admin: true,
				first_name: CustomRegex.japanese?(user_info["name"]["givenName"]) ? '' : user_info["name"]["givenName"],
				last_name: CustomRegex.japanese?(user_info["name"]["familyName"]) ? '' : user_info["name"]["familyName"],
				email: user_info["emails"][0]["value"],
				password: password,
				password_confirmation: password
				})

			@client_id = SecureRandom.urlsafe_base64(nil, false)
      @token     = SecureRandom.urlsafe_base64(nil, false)
      # @resource = Employee.find user.id
      @resource.tokens[@client_id] = {
              token: BCrypt::Password.create(@token),
              expiry: (Time.now + DeviseTokenAuth.token_lifespan).to_i
      }
      @resource.skip_confirmation!
			@resource.save!
      # @resource.save!(validate: false)
      # sign_in @resource
			return render json: {client_id: @client_id, expiry: @resource.tokens[@client_id][:"expiry"],
													 token: @token, uid: @resource.uid
													}

I used the returned cliend_id expiry, token and uid in the header to make a req to my api and it gave me not authorized error. Can you tell me what I am doing wrong?

@sushant12 you haven't posted any code here - what have you tried so far?
If you need more basic/architectural help you also may want to try Stack Overflow too?

@zachfeldman I have updated the issue. Please do take a look

the above code is wokring fine. It is just that I had the same value in the uid field in one of the records and that is why the auth code were not working.


Vertical line should appear between collapsed steps as well

In my opinion, it is a waste of space. Mobile devices have small screens, so it is more useful not to show these lines when steps are collapsed. Thus, I am afraid that I will not change how these lines look. Anyway, feel free to copy and modify my code as you wish :)

By the way, to avoid any confusion, it is important to point out that my library doesn't follow Material Design guidelines completely, because it was never my intention to implement the vertical stepper forms looking exactly like the examples created by Google, but just really similar. I apologize for the misunderstanding (I will clarify this point in the readme file).

Uh, i already opened several issues regarding material design doc. 😕

I am really sorry, I should have clarified this before. Anyway, I am very grateful for your help and I will consider some of your suggestions. Thanks!

Anyway, i think you should implement the material design look, because that is what most people will look for. If you do not like the sizes of the material design, you can make those things configurable (not necessary via the builder, you can also achieve it with resources like you do with the translation).
I think creating a library which almost looks like the material guidelines are very confusing and a missed opportunity whether you add this to the readme or not.
BTW, thanks for creating this library, it is great already!

That is a good point as well as a great suggestion. I will try to do so in the future, but I don't really know if I will have time to work on this library as much as I would like (right now I am very busy). Thanks again!

@ernestoyaquello to be clear: i would gladly open pull requests for all the issues i opened during the next few days as i intend to include this library on a project i am working on.

Feel free to do it! I cannot guarantee that I will include them all, but any help will be appreciated, that's for sure.


add truncate tag to Founding AE Team Blog Post

Just noticed this as well, thanks for grabbing this @jasnonaz!


Add a link to Insights Data Schemas repo into documentation

Add a link to Insights Data Schemas repo into documentation

Added into https://github.com/RedHatInsights/insights-results-smart-proxy/blob/master/docs/references.md


repro(types): components with required props

This is a repro to illustrate a compilation error with components using required props.

Hmm, this is not failing the tsd tests, weird...
It does fail in my project, and you can reproduce in the e2e test of the modal (but the test still succeeds even if it does not compile). I pushed another commit


Part Selection

Question about the part selection.
Where the through holes chosen due to ease of assembly? I.e. there would be no issue swapping them out for SMD parts would there? (I don't think there would be an issue but I thought it worth just asking)

Absolutely! SMD parts, 0805 in particular, work really well on top of the 2.5 mm through-hole footprints. (I've used sometimes 100 nF 0805 if you look closely in the pictures)
The preferred bills of material - as featured with order codes from 4 major suppliers on kitspace.org - focuses on through-hole parts to make it easier for beginners:
https://kitspace.org/boards/github.com/ozel/diy_particle_detector/alpha-spectrometer/
https://kitspace.org/boards/github.com/ozel/diy_particle_detector/electron-detector/
In case of 40 mega Ohm/R3 for the alpha-spectrometer, I've selected an SMD part since it is slightly better noise-wise and through-hole resistors with such high values seem harder to get.
I'll leave this open for others to ask part related questions.


[FIX] interface-name-prefix failing on interface with number in name

Fixes #139

@bradzacher I am very sorry for the long delay in coming back to this, we are going to work out a better maintenance plan for this project

@JamesHenry happy to help out if you need it.


Simplify RelationshipType and its type/string mapping

@goneall My contributions are done under the terms of the Apache License, version 2.0.

Merged and pushed to git.spdx.org - should be mirrored soon.
@sschuberth  Thanks for the improvements!


Support test certificates and SSL name override

Fixes #2429.
(A few of the changes in the diff are from PR #2753.)
By importing GRPCCall+Tests.h one can register SSL config to be used for a specific host.
GRPCHost is used to store channel config, and to create channels on demand with that config. GRPCChannels and configs are composed and cached together.
GRPCSecureChannel is now initialized with (nullable) path to a certificates file and (nullable) name override.
The same mechanism will later be used for creating insecure channels, removing the ability to do it by specifying the HTTP scheme in the address (which was deemed too subtle for its implications).

Diff now that #2753 is merged: https://github.com/grpc/grpc/compare/master...jcanizales:support-test-certificates?expand=1

@DavidPhillipOster : This is the first change I've got pending. My teammate Michael did a pass right before going on vacation.
It's made of the following commits. Going commit by commit is slower, but more manageable. The first 3 are just refactoring preparing for the 4th one, which is the interesting one. Clicking on their link will show each's diff:

Move _channel from GRPCCall into GRPCWrappedCall: Refactoring. There's a 1:1 relationship between GRPCCall objects and GRPCWrappedCall objects; so this just encapsulates the _channel ivar.

Encapsulate grpc_call creation inside GRPCChannel: (Suggest to start with this file.) We want the host passed to grpc_channel_create_call to be overriden on a per-channel basis (so that I can connect to a test server in localhost and have the Host header of my RPC be "mytestserver" instead of "localhost"). So this moves the grpc_channel_create_call into GRPCChannel, wherein that argument can be later overriden (the GRPCSecureChannel subclass will).

Remove GRPCChannel-initWithHost to simplify implementation: Refactoring. GRPCChannel is a class cluster. It has a convenience constructor that returns an object from a subclass (basically, secure or insecure channel). The constructor was doing that by allocating the base class and calling an initializer that then created and returned another object. This removes that unnecessary complexity.

Let register SSL config per-host: This is the meat of this change. The commit has a detailed description, but the purpose is to let the user do something like this on their initialization:

#import <GRPCClient/GRPCCall+Tests.h>
...
NSBundle *bundle = [NSBundle bundleForClass:self.class];
NSString *certsPath = [bundle<EMAIL_ADDRESS>                                       ofType:@"pem"];
[GRPCCall useTestCertsPath:certsPath<EMAIL_ADDRESS>forHost:kLocalSSLHost];

And from then on, all RPCs to that host will use SSL with the provided test parameters.
Finally, there's these 4 trivial fixes: https://github.com/grpc/grpc/commit/000fa388b8d7c99601092976b5b1d93a9705e34d, https://github.com/grpc/grpc/commit/e21b467dc59b8d0ddc6f64bde65df07e121a0132, https://github.com/grpc/grpc/commit/56c6574652ce261370582fec7decd4a8e6ce1cb3, https://github.com/grpc/grpc/commit/7d261ee5b6bf69378787600971de0361d2c76081.

Also note that only GRPCCall and GRPCCall+Tests are part of the public interface of the library, all other classes are internal.

Thanks for the guide. I expect to get to it in about one hour.
On Tue, Aug 4, 2015 at 12:27 PM, Jorge Canizales<EMAIL_ADDRESS>wrote:

Also note that only GRPCCall and GRPCCall+Tests are part of the public
interface of the library, all other classes are internal.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/2754#issuecomment-127728631.


Default deployment name for images changed to "dall-e-3"

Module: 05
Lab/Demo: 05
Description of issue
Labfiles/05-image-generation/Python/generate-image.py
The url (line 19) is hard coded with deployment name:
url = "{}openai/deployments//images/generations?api-version={}".format(api_base, api_version)
The default name is now "dall-e-3".
Recommended to configure as variable as in other labs or to replace in the code from "dalle3" to "dall-e-3".
Repro steps:

go to Labfiles/05-image-generation/Python/generate-image.py
modify line 19

Suggested fix with variable:

In the .env add "AZURE_OAI_DEPLOYMENT="
In the generate-image.py, under

def main():
        try:
        # Get Azure OpenAI Service settings
        load_dotenv()
        api_base = os.getenv("AZURE_OAI_ENDPOINT")
        api_version = '2024-02-15-preview'"

add "azure_oai_deployment = os.getenv("AZURE_OAI_DEPLOYMENT")"
Update the url to call the DALL-E model:
url = "{}openai/deployments/{}/images/generations?api-version={}".format(api_base, azure_oai_deployment, api_version)

While the default name is dall-e-3, we specify during deployment to name it dalle3, which would make the code work as written. You can see the specified name here:
https://github.com/MicrosoftLearning/mslearn-openai/blob/64e0192c9629f59e3b80a84e5cdf78cc03b2a583/Instructions/Exercises/05-generate-images.md?plain=1#L31
Since code works as written, closing the issue. I'll consider adding it as a variable or changing the code to use the default name.


[SPARK-32586][SQL] Fix NumberFormatException error message when ansi is enabled

What changes were proposed in this pull request?
This pr fixes the error message of NumberFormatException when casting invalid input to FractionalType and enabling ansi:
spark-sql> set spark.sql.ansi.enabled=true;
spark.sql.ansi.enabled	true
spark-sql> create table SPARK_32586 using parquet as select 's' s;
spark-sql> select * from SPARK_32586 where s > 1.13D;
20/08/10 23:38:31 ERROR Executor: Exception in task 0.0 in stage 10.0 (TID 10)
java.lang.NumberFormatException: invalid input syntax for type numeric: columnartorow_value_0

After this pr:
spark-sql> select * from SPARK_32586 where s > 1.13D;
20/08/10 23:38:31 ERROR Executor: Exception in task 0.0 in stage 10.0 (TID 10)
java.lang.NumberFormatException: invalid input syntax for type numeric: s

Why are the changes needed?
Improve error message.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.

Test build #127310 has started for PR 29405 at commit 40af8d4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31929/
Test PASSed.

Test build #127310 has finished for PR 29405 at commit 40af8d4.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127310/
Test FAILed.

retest this please

Test build #127315 has started for PR 29405 at commit 40af8d4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31934/
Test PASSed.

Test build #127315 has finished for PR 29405 at commit 40af8d4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127315/
Test PASSed.

Merged to master and branch-3.0.


fzf-history-widget doesn't work properly.

[ ] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[ ] Linux
[x] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

Problem / Steps to reproduce

Pressing Ctrl + r to show widget and pressing ENTER to select any item.
Pressing Ctrl + u (Delete whole line)  to clear the command.
Pressing Ctrl + r to show widget and pressing ENTER to select any item again.
Now terminal will not show the selected item (not show anything).

Cannot reproduce the problem.


Corrdiff generation bug fixes & Update README

Modulus Pull Request
Description

Updating README, changing some configurations, and fixing small bugs
Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The CHANGELOG.md is up to date with these changes.
[x] An issue is linked to this pull request.

Dependencies

/blossom-ci

/blossom-ci


Viewing the brand in the treatment log

Displaying the brand would allow user to confirm that it's correct.

If you hover over/click on the volume, it should display the brand:


Jenkins pipeline for non-docker project to do a release

At
https://github.com/fabric8io/fabric8-jenkinsfile-library/tree/master/maven
We would like to have a Jenkinsfile for doing a regular maven project that is NOT docker based.
It should do a

maven release
maven deploy

So it deploys to the nexus repository a released version of the project (the current Deploy is doing a SNAPSHOT deploy).
The name of the pipleline could maybe be JavaRelease or something. As the current pipelines have a mix of docker vs non-docker.
However there are users of fabric8 that need a plain pipeline for non docker stuff. For example we need this at iPaaS.

@rawlingsj dont we have a plain pipeline for when we do releases of fabric8 which has no docker images?
However it should not push to maven central, but to the built-in nexus repository from fabric8


Add contributor-milestone-persona.md and Update contributor-domain-persona.md

Minor comments

done


.NET Core November Update - 2.1.14, 2.2.8, and 3.0.1

Included fixes address issues detailed in the release notes.
.NET Core

.NET Core 2.1.14 and .NET Core SDK 2.1.510
Release Notes
Download 2.1

.NET Core 2.2.8 and .NET Core SDK 2.2.110
Release Notes
Download 2.2

.NET Core 3.0.1 and .NET Core SDK 3.0.101
Release Notes
Download 3.0

Please report any issues you find with these releases, either responding to this issue, creating a new issue here or creating a new issue in one of the following repos:

aspnet/Home - for ASP.NET Core questions
aspnet/EntityFrameworkCore - for Entity Framework Core questions
dotnet/coreclr - for runtime issues
dotnet/corefx - for API issues and questions
dotnet/core-setup - for installer issues
dotnet/cli - for CLI tools and questions
dotnet/winforms - for Winforms issues
dotnet/wpf - for WPF issues
nuget/home - for NuGet questions and issues

.NET Support Policies
Microsoft support policies are defined in the following documents:

Microsoft .NET Support Policy
.NET Core OS Lifecycle Policy

according to Vs release notes, I can not see Visual Studio 16.3.11. So is it included in VS or I have to manually download it?

Sorry, that is a mistake, it is being fixed now. the change will be live in a few mins.
Since, this (non-sec) Core release is out of sync with VS releases, it will go out with the next set of VS releases in future.

2.2.7 contained SDK 2.2.402 for VS 2019 v16.2, but this release has no SDK for 16.2 only for 16.0. Does that mean SDK 2.2.402 is the latest and that if we already have it, we don't need SDK 2.2.207 from 2.2.8?

2.2.7 contained SDK 2.2.402 for VS 2019 v16.2, but this release has no SDK for 16.2 only for 16.0. Does that mean SDK 2.2.402 is the latest and that if we already have it, we don't need SDK 2.2.207 from 2.2.8?

Wondering this as well. The same goes for 2.1.14 which contains SDK 2.1.607 whereas 2.1.13 contains SDK 2.1.802.

cc @KathleenDollard ; @livarcocc

This now supports F# 4.6 instead of F# 4.7 like the 3.0.100 SDK? May I ask why this is rolled back a minor version?

@AngelosP, F# version issue should be fixed now, thanks for reporting.
https://dotnet.microsoft.com/download/dotnet-core/3.0

@vivmishra what about all the messed up 2,2 SDK versions

@jamshedd what about all the messed up 2,2 SDK versions

2.2.7 contained SDK 2.2.402 for VS 2019 v16.2, but this release has no SDK for 16.2 only for 16.0. Does that mean SDK 2.2.402 is the latest and that if we already have it, we don't need SDK 2.2.207 from 2.2.8?

Wondering this as well. The same goes for 2.1.14 which contains SDK 2.1.607 whereas 2.1.13 contains SDK 2.1.802.

This is expected - .NET Core SDK versions are supported based on the Visual Studio lifecycle. The Visual Studio version (16.2) that includes the 2.1.802 SDK went out of support when VS 16.3 shipped, so we did not ship the corresponding Core SDK.
@vivmishra, can you please confirm the version numbers I quoted are right?

Yes, the versions are right. 2.1.802/2.2.402 shipped with VS 16.2 that went out of support when VS 16.3 went live. We understand that is confusing for people - we are working on a response for this.

2.2.7 contained SDK 2.2.402 for VS 2019 v16.2, but this release has no SDK for 16.2 only for 16.0. Does that mean SDK 2.2.402 is the latest and that if we already have it, we don't need SDK 2.2.207 from 2.2.8?

Wondering this as well. The same goes for 2.1.14 which contains SDK 2.1.607 whereas 2.1.13 contains SDK 2.1.802.

This is expected - .NET Core SDK versions are supported based on the Visual Studio lifecycle. The Visual Studio version (16.2) that includes the 2.1.802 SDK went out of support when VS 16.3 shipped, so we did not ship the corresponding Core SDK.
@vivmishra, can you please confirm the version numbers I quoted are right?

@jamshedd & @vivmishra so based on that which is what is the correct sdk to install for VS 2019 v16.3 or v16.4 ? as you dont really answer that question.

@madhon , there is no update for v16.3 as this out of band (non-sec) .NET Core release did not align with any planned v16.3 release. v16.3 is now currently out of support as v16.4 went live  on 12/3.  Of course, you can still install any of the 2.X or 3.0 package (as per your need) from this release on v16.3, but, you should ideally upgrade to v16.4 as that is the officially supported version.
v16.4 already includes what we have to offer from this release (2.1.14, 2.2.8, 3.0.1) plus 3.1 SDK.

@vivmishra,
Still can't get what I should install if I need .NET Core SDK v.2.2.x in Visual Studio 2019 16.4.x.
Currently I can find the following available downloads (latest, with VS 2019 support):

2.2.402 (VS v16.2) - released with 2.2.7 - this one supports higher minor VS version, but is older.
2.2.207 (VS v16.0) - released with 2.2.8 - this one is newer, but seems like doesn't support VS 16.4.

And which one I should use with VS Build Tools on my build server.
Could you please advise?

@zhaparoff, .NET Core SDK 2.2.X is not supported on v16.4. v16.4 already ships with .NET Core SDK 3.1 that is capable of building 2.X apps.

Just for infor, v16.2 is no longer in support and due to that it did not get an update for 2.2.

Cc @KathleenDollard ; @livarcocc

What @hempels cited above is true of Docker, too. Pulling latest for the SDK 2.2-alpine3.9 tag "upgraded" it from 2.2.402 to 2.2.207. I figured the tags on Dockerhub would give options or clear things up, but for some reason no 2.2 tags are listed on https://hub.docker.com/_/microsoft-dotnet-core-sdk... but I'm still able to pull it from MCR. (Does someone need to fix that, btw?)
From the above, I understand MS's perspective: there were multiple release branches (e.g. 2.2.2xx and 2.2.4xx) meant for compatibility w/ different VS versions (16.0 and 16.2, respectively). Each got bumped with each new runtime release: v2.2.6 had 2.2.205 and 2.2.401, v2.2.7 had 2.2.206 and 2.2.402. But when a VS release drops out of support, its SDK branch halts; so we never saw a 2.2.403, making 2.2.207 the single newest SDK version with runtime 2.2.8.
For regular users, though - especially those who don't even use VS (and the download page takes pains to say you can use the SDK with CLI or ANY editor) - this is highly confusing and hinges on SKU and support information most users are oblivious about. And other questions arise: if 16.2 isn't supported anymore in favor of 16.4, why is the older 16.0 still getting a 2.2.207 release... because it's the VS 2019 base version?
Either way, it's got to be confusing on sight to most users. It would be great if this kind of thing would be acknowledged on the downloads page, the release notes, and here, along with clear advice.

Exactly right. This is an extremely important point, all MS employees should be required to cite this mantra each morning before work three times: "dotnet is not Visual Studio. Visual Studio is not dotnet".
Visual Studio is of course free to take dependencies on dotnet SDK versions, but the opposite is not true. There can be no expectation that an SDK user (or package manager, or Docker maintainer, etc) knows anything about Visual Studio or its versions, and certainly we should not be seeing EOL for SDK versions on the basis that a VS version that depended on it is no longer supported. That would be like saying Windows Server 2012 will stop receiving updates because IE 10 is no longer supported.

Yep, it's the codependency between the two that's most surprising. I use the SDK across multiple platforms in VS Mac, VS Code, Rider, and CLI as well as VS proper, and none of the others seem to be lacking vital features despite the SDK knowing nothing about them. I'm confused as to the benefit of the VS dependency, and I'd be interested to know the rationale.

Closing older announcement issues.

If you are struggling to get the SameSite writing patch working when using ASP.NET Core 2.1 on .NET Framework, then go have a read of https://stackoverflow.com/a/65834637/34092 .


DeepL 413 Error

With large translations, we are receiving a 413 error from DeepL, meaning the request size did exceed the allowed 128KiB
https://www.deepl.com/de/docs-api/accessing-the-api/limits/
Is there a way to split up translations into smaller requests? Maybe we can add a translate button to every single field, or have a selection dialog which fields should be translated?

Selecting some fields to not be translated might be a cool feature, but I think for now the easiest solution would be to split the requests not just by number of fields but also by size.
See https://github.com/Fekide/strapi-plugin-deepl/blob/2c9b8aa8f6610bdbcd4ed6e2b58c077ff308bb67/server/utils/deepl-api.js#L33
This might however include a lot of tinkering since if one field itself is too big, it will need to be split as well.

Hm I am actually not sure what part of my request causes the error, as it does not seem that big after all.
Is there a way to turn on logging of the requests? Maybe I can help with more details on the request

@tomh4
Not with some settings right now, but you can manually edit files in the node_modules folder. Just put this code into the file node_modules/strapi-plugin-deepl/server/utils/deepl-api.js after line 39
strapi.log.debug("Request: " + requestParams.toString())
strapi.log.debug("Length: " + requestParams.toString().length)

Is there a way to config the plugin to prevent certain keywords from being translated? @sargreal

Hey @jpizzati-uvl
Currently the only option is using the i18n plugin settings in the content-type builder  to set the field as “not translated” (See Advanced Settings for each field type in the documentation on configuring fields

@tomh4 Is the issue now actually connected to the amount of text or some other problem?
Error logs or using the approach in https://github.com/Fekide/strapi-plugin-deepl/issues/8#issuecomment-1086604410 would be very helpful

Hello @sargreal , yes it is the length, here is the output:
{"expected":1235469,"length":1235469,"level":"error","limit":1048576,"message":"request entity too large","type":"entity.too.large"}
Maybe translating each field by itself would be an option?

{"expected":1235469,"length":1235469,"level":"error","limit":1048576,"message":"request entity too large","type":"entity.too.large"}

The numbers here are bits right?

Hey @jpizzati-uvl Currently the only option is using the i18n plugin settings in the content-type builder to set the field as “not translated” (See Advanced Settings for each field type in the documentation on configuring fields )

Thanks for the quick response!

{"expected":1235469,"length":1235469,"level":"error","limit":1048576,"message":"request entity too large","type":"entity.too.large"}

The numbers here are bits right?

Yes I'd say so, this translates to the 128kb limit of deepl

@tomh4 I have now finished on a fix in #11. Can you confirm that this works for you?

@sargreal have you made a release yet? how can I test ?

@tomh4

clone this repository to your [strapi]/src/plugins folder
checkout branch 8-deepl-413-error
add this line to your deepl plugin configuration

  deepl: {
    // ...
    resolve: "./src/plugins/strapi-plugin-deepl", // path to plugin folder
    // ...
  },

(re)start strapi

@tomh4 if you prefer a release, i can also make a beta release

Alright i will do that, and get back to you soon!

Hmm I did as you told, but I am still getting entity too large :(

@tomh4 I have added some debug logging to the merge request. Can you confirm that these are happening and send the logs?

Hmm i am not getting any logs, where should these show up?

@tomh4 They should show up in the strapi server logs
So probably the plugin isn't resolved correctly

I have removed the plugin from the package.json, then deleted the node_modules folder, and rebuild everything after adding it to the specified folder

@tomh4 That's weird.. You are on the correct branch and pulled it right?

yes..:/

@tomh4 The log output should look something like this for your reference:
[2022-05-09 22:16:18.739] debug: DEEPL: Current chunk full with approx. 49197 bytes
[2022-05-09 22:16:18.740] debug: DEEPL: Current chunk full with approx. 50043 bytes
[2022-05-09 22:16:18.740] debug: DEEPL: Current chunk full with approx. 49197 bytes
[2022-05-09 22:16:18.740] debug: DEEPL: Last chunk size approx. 30195 bytes
[2022-05-09 22:16:18.741] debug: DEEPL: Last chunk size approx. 0 bytes
[2022-05-09 22:16:18.741] debug: DEEPL: Sending chunk of size 77 bytes
[2022-05-09 22:16:18.743] debug: DEEPL: Sending chunk of size 38271 bytes
[2022-05-09 22:16:18.745] debug: DEEPL: Sending chunk of size 38923 bytes
[2022-05-09 22:16:18.748] debug: DEEPL: Sending chunk of size 38271 bytes
[2022-05-09 22:16:18.751] debug: DEEPL: Sending chunk of size 23505 bytes

Can you do this and try once again?
git checkout 429e408d812149b9938cd64d32dff1438ed5815e


webimage_extra_packages for Puppeteer Headless Chrome support

Npm packages like codeceptjs or critical-css-webpack-plugin which depend on Puppeteer will not be able to run from within the web container because of some missing Linux libraries.
This Dockerfile add all required dependencies in order to run the Headless Chrome provided by Puppeteer.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Alban Jubert seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @rfay
I have moved the files to recipes section and removed the Debian packages already part to the Ddev web image.

Thanks for requesting review; sorry I haven't gotten to this, have been getting v1.14 out, hope you can try it out, https://github.com/drud/ddev/releases/tag/v1.14.0-rc2

Please add info to this PR on how to manually test it. You can add it to the PR or add more to the README.

Hi @rfay
I added a demo project in order to demonstrate the purpose of the PR.
You can test it by following the added instructions in the README.md file.
You can also comment out the webimage_extra_packages configuration in the config.yaml file in order to experience the missing libraires. In that case, you will get the following errors while running the ddev yarn build command:
Error: Failed to launch chrome!
error while loading shared libraries: libX11-xcb.so.1: cannot open shared object file: No such file or directory

Let me know if you feel that something is missing or not clear.
Thanks.
PS. I have tested ddev 1.14.0-rc2 and everything is running smoothly on my side. Good work, once again :)

Thanks so much!

Hi @rfay,
The changes looks good to me, thank you for your review.
About the warning, it's a yarn related message and doesn't really matter.
May I ask what resulting page did you get?
If everything works fine (I just did a test from scratch and redoing the README steps), you should get something like the attached screen shot. Is that what you get?

If you feel any clarification should be added, please let me know.

Here's what I see @juban , it's hard to show in screenshots, but here are the first two full screens as I scroll. Not sure how important this is.

There's something wrong and what you see is the page when the related assets are missing (no CSS or JS files loaded).
Are you sure you ran the last ddev yarn build command?
If so, did you get any error message related to that command and are you seeing any files beside the .gitignore file in demo/web/webpack-assets folder?

Silly me, I did a ddev yarn install instead of ddev yarn build. It looks great now, thanks.

Glad to hear you managed to make it work.
Thanks again for you reviews, your patience and kindness :)


See it in action!

Hello!
In order to implement a filepicker with onedrive, I cross this github project which seems to be perfect for me. The link "See it in action!" in the readme of this project seems to no longer work. Is this behaviour expected?
It leads to https://developer.microsoft.com/en-us/onedrive instead, I beleive, to something else (eg: a real example of the filepicker)

yes

They must have shutdown https://developer.microsoft.com/en-us/onedrive. The repository does not seem to receive any updates.


Pass RedactHeadersWith from RequestLogger

Correct Branch this time

Suggestion for 0.21, what if we removed the default from Logger.logMessage that way we are passing something whenever we call this method.


Make py2ju handle lists

Fixes #25
An alternate version with regex for this PR can be:
    # removes trailing comma from a list
    rx = r",[ \n\r\t]*\]"
    dictstr_cpy = replace(dictstr_cpy, rx => "]")

I have tested both versions. Both work perfectly.
I'm open to criticisms and more ideas :blush:
Side Note: There are dozens of cases in which py2ju can fail, but if we are specific to CDAPI then py2ju will work fine.

cc @juliohm
(Kindly review this PR so that I can implement other test cases) :smile_cat:

Thank you @LakshyaKhatri for addressing these issues. I think in this case the regex is easier to maintain. Could you please consider using it instead of the while loop?

Thanks! Now we can add more tests to stress the function.


Feature/has vowels

What does this pull request do?
Adds a method to check if the string contains vowels
How do i test this?
Test by running
    npm test

Additional Comments / Context

Changes Unknown when pulling 5bf969bec6e1ea29c6277aa8dd72310c59ef9685 on feature/has-vowels into ** on master**.


GDK not working properly despite following the installation step by step.

PS C:\SGDK> %GDK%\bin\make -f %GDK%\makefile.gen clean
%GDK%\bin\make : The module '%GDK%' could not be loaded. For more information, run 'Import-Module %GDK%'.
At line:1 char:1

%GDK%\bin\make -f %GDK%\makefile.gen clean

  + CategoryInfo          : ObjectNotFound: (%GDK%\bin\make:String) [], CommandNotFoundException
  + FullyQualifiedErrorId : CouldNotAutoLoadModule

PS C:\SGDK> Import-Module %GDK%
Import-Module : The specified module '%GDK%' was not loaded because no valid module file was found in any module directory.
At line:1 char:1

Import-Module %GDK%

  + CategoryInfo          : ResourceUnavailable: (%GDK%:String) [Import-Module], FileNotFoundException
  + FullyQualifiedErrorId : Modules_ModuleNotFound,Microsoft.PowerShell.Commands.ImportModuleCommand

SGDK is meant to be used from 'cmd' command line tool, not powershell.


[PR][CLOSED] Update structure of configuration file

 Issue by geunsik-lim
Tuesday Jun 12, 2018 at 02:38 GMT
Originally opened as https://github.sec.samsung.net/STAR/TAOS-CI/pull/15

Updated the existing configuration file.
Signed-off-by: Geunsik Lim<EMAIL_ADDRESS>
geunsik-lim included the following code: https://github.sec.samsung.net/STAR/TAOS-CI/pull/15/commits

:octocat: cibot: Thank you for posting issue #32. The person in charge will reply soon.


Use forked zap

It's intentionally split into 2 commits, so we can revert the first one (and also update upstream zap to newer version) once the patch is accepted by upstream.

Close as we have https://github.com/reddit/baseplate.go/pull/314 instead.


Pythonnet 303

What does this implement/fix? Explain your changes.
Update to python.Net 3.0.3 (latest release)
Does this close any currently open issues?
No
Any other comments?
I reduced the modifications needed and changed pyRevit source code to only use public classes and methods.
We could even drop this and directly use the nuget package, since a single compiled assembly can be used for multiple python version by setting the python dll path.
Checklist
Check all those that are applicable and complete.

[ ] Make sure to include one or more tests for your change
[ ] If an enhancement PR, please create docs and at best an example
[ ] Add yourself to AUTHORS
[ ] Updated the CHANGELOG

Let me know when you feel it is ready to go.

@sanzoghenzo
I think it’s better to pull not the latest version, but the latest version by tag.

@sanzoghenzo I think it’s better to pull not the latest version, but the latest version by tag.

I did exactly that, I forked pythonnet from the 3.0.3 release commit and added the namespace editing on top of that

@sanzoghenzo but in PR latest commit is not Release 3.0.3

@sanzoghenzo but in PR latest commit is not Release 3.0.3
your last commit: pythonnet@1a4ada7 version 3.0.3 commit: pythonnet@0a5a63c

The commit history is in increasing order, check the last two elements 😉  (I made the same mistake while checking things after your first message)

@sanzoghenzo oh okay :)


[Ubuntu 20.04 and Ubuntu 22.04  Oses] Go  1.22.x  will be set as default on September, 20

Breaking changes
Go 1.22.x version will be set as default for Ubuntu 20.04 and Ubuntu 22.04 .
Target date
Image deployment is starting on September 16 and will take 3-4 days.
The motivation for the changes
As of the software support policy only 3 latest versions of Go are supported.
Possible impact
Go 1.22.x version will be set as default for Ubuntu 20.04 and Ubuntu 22.04 .
Platforms affected

[X] Azure DevOps
[X] GitHub Actions

Runner images affected

[X] Ubuntu 20.04
[X] Ubuntu 22.04
[ ] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Mitigation ways
https://github.com/actions/setup-go action for GH actions
https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/tool/go-tool?view=azure-devops task for AzDO

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

this will solve #10436


how to integrate with vue.js

I have html page with AOS animation.
Then I tried to integrated to vue.js to dynamically change some text and html components.
But when add vue,js app then AOS stopped working.
Are there anyone who already figured out how to integrate AOS and VUE together?

Hi, I've created a little directive for Vue 2, I'm still working on this but the following code should work:
directives/aos.js:
`
import AOS from 'aos';
export default {
bind(el, binding, vnode) {
// add listener
AOS.init({
duration: 1200
});
},
// // When the bound element is inserted into the DOM...
// inserted(el, binding) {
// },
update(el, binding) {
AOS.refresh();
},
unbind(el, binding) {
// window.stroll.unbind(el);
}
};
`
to use it, add these line in main.js:
import aos from  './directives/aos'; Vue.directive('aos', aos);

forgot, to use the directive apply it on the element container of the ones to be animated:
<div class="container" v-aos>

I've added this code, but error shows up:
Vue.js error

Error: Module build failed: SyntaxError: Unexpected token, expected , (16:2)

  14 |   }
  15 |
> 16 |   bind(el, binding, vnode) {
     |   ^
  17 |   // add listener
  18 |   AOS.init({
  19 |   duration: 1200

    at Object.<anonymous> (__vue_ssr_bundle__:2077:7)
    at __webpack_require__ (__vue_ssr_bundle__:21:30)
    at Object.module.exports.module.exports.render._vm (__vue_ssr_bundle__:3817:3)
    at __webpack_require__ (__vue_ssr_bundle__:21:30)
    at Object.module.exports.Object.defineProperty.value (__vue_ssr_bundle__:1616:5)
    at __webpack_require__ (__vue_ssr_bundle__:21:30)
    at Object.<anonymous> (__vue_ssr_bundle__:1117:69)
    at __webpack_require__ (__vue_ssr_bundle__:21:30)
    at Object.<anonymous> (__vue_ssr_bundle__:4230:65)
    at __webpack_require__ (__vue_ssr_bundle__:21:30)

Using .vue components. So I install AOS from npm then added that code in script tag of .vue:
  bind(el, binding, vnode) {
  // add listener
  AOS.init({
  duration: 1200
  });
  },

  // // When the bound element is inserted into the DOM...
  // inserted(el, binding) {
  // },

  update(el, binding) {
  AOS.refresh();
  },

  unbind(el, binding) {
  // window.stroll.unbind(el);
  }

Doesn't work.

That code doesn't work. Using .vue components.
Vue.js error

ReferenceError: window is not defined
    at Object.defineProperty.value (/home/zman/pkr-crdrz/node_modules/aos/dist/aos.js:1:5429)
    at t (/home/zman/pkr-crdrz/node_modules/aos/dist/aos.js:1:378)
    at Object.n (/home/zman/pkr-crdrz/node_modules/aos/dist/aos.js:1:771)
    at t (/home/zman/pkr-crdrz/node_modules/aos/dist/aos.js:1:378)
    at e.__esModule.default (/home/zman/pkr-crdrz/node_modules/aos/dist/aos.js:1:470)
    at /home/zman/pkr-crdrz/node_modules/aos/dist/aos.js:1:475
    at o (/home/zman/pkr-crdrz/node_modules/aos/dist/aos.js:1:143)
    at Object.<anonymous> (/home/zman/pkr-crdrz/node_modules/aos/dist/aos.js:1:249)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)

Installed from npm, then add the code above to script tag in .vue

Doesn't work

This works for me:
// main.js
import AOS from 'aos'
import 'aos/dist/aos.css'

new Vue({
  el: '#app',
  created () {
    AOS.init()
  },
  render: h => h(App)
})

oh, It works when I import css. Thank you!

Any advice on how to use this with nuxt.js as a plugin?  I can't seem to get it to work.

@pvenableh I had to import AOS after mounting so it had access to the window. Did this using lazy loading.
async mounted() {
  const AOS = await import('aos');
  AOS.init();
}

or without async/await
mounted() {
  import('aos').then(AOS => AOS.init());
}

Sorry, I don't know what you can do for your problem...    On Saturday, May 26, 2018, 10:33:19 PM GMT+4:30, Sam Rose<EMAIL_ADDRESS>wrote:
@pvenableh I had to import AOS after mounting so it had access to the window. Did this using lazy loading.
async mounted() {
const AOS = await import('aos');
AOS.init();
}
or without async/await
mounted() {
import('aos').then(AOS => AOS.init());
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@samrose3  Thanks. You safe my day :+1:

@samrose3 I am also trying to use with nuxt.js. Tried importing AOS in the mounted method of my component, just like you, but the items with data-aos="fade" are not visible.
My code in the myComponent.vue:
import 'aos/dist/aos.css'
...
 mounted() {
    import('aos').then(AOS => AOS.init())
  }

Any idea?

What if I want disable AOS in some conditions? Currently using 'disable: true' will cause items stay hidden, 'cause the css is imported before, I dont't want control the 'data-aos' attribute or append a new class in global.

I'd like to recommend is that you also add
AOS.refresh();

within the destroyed life-cycle hook.

Any advice on how to use this with nuxt.js as a plugin? I can't seem to get it to work.

Making it work with Nuxt:

make a js file in your plugins directory with the following content:

// aos.js
import Vue from 'vue';
import AOS from 'aos';
import 'aos/dist/aos.css';

Vue.use(
  AOS.init({
      // add your settings here
  })
);

include the file from step 1 in nuxt.config.jsin the pluginssection:

  plugins: [
    '~/plugins/aos.js',
  ],

@dekadentno  Thanks for sharing! That's working !!

@dekadentno's code is a good start, but it can break vue if you use anything other than false for the disable option. This is because when AOS is disabled, the AOS.init function returns undefined, and a vue plugin can't be undefined.
I also found I needed to use if (process.client) to prevent AOS from trying to do document queries on the node side.
Here's my modified version:
// aos.js
import Vue from 'vue';
import AOS from 'aos';
import 'aos/dist/aos.css';

const aosPlugin = {
  install: () => {
    AOS.init({
      // add your settings here
    })
  },
}

if (process.client) {
  Vue.use(aosPlugin);
}

For nuxt.config.js, it should be the same. If that doesn't work, you may want to try this instead:
  plugins: [
    {
      src: '~/plugins/aos.js',
      mode: 'client',
    },
  ],

Hope this helps future lurkers!

@fliprubin

Hope this helps future lurkers!

It absolutely did. Thanks

The animation can be reset on an element which is animated when vue component updated. This caused deffect the element hide. I solved it with init Vue plugin (in Nuxt) in this way:
// ~/plugins/aos.js
import Vue from 'vue'
import AOS from 'aos'

class AosPlugin {
  config = {
    // Global settings:
    disable: false, // accepts following values: 'phone', 'tablet', 'mobile', boolean, expression or function
    startEvent: 'DOMContentLoaded', // name of the event dispatched on the document, that AOS should initialize on
    initClassName: 'aos-init', // class applied after initialization
    animatedClassName: 'aos-animate', // class applied on animation
    useClassNames: false, // if true, will add content of `data-aos` as classes on scroll
    disableMutationObserver: false, // disables automatic mutations' detections (advanced)
    debounceDelay: 50, // the delay on debounce used while resizing window (advanced)
    throttleDelay: 99, // the delay on throttle used while scrolling the page (advanced)

    // Settings that can be overridden on per-element basis, by `data-aos-*` attributes:
    offset: 120, // offset (in px) from the original trigger point
    delay: 0, // values from 0 to 3000, with step 50ms
    duration: 400, // values from 0 to 3000, with step 50ms
    easing: 'ease', // default easing for AOS animations
    once: true, // whether animation should happen only once - while scrolling down
    mirror: false, // whether elements should animate out while scrolling past them
    anchorPlacement: 'top-bottom', // defines which position of the element regarding to window should trigger the animation
  }

  install(Vue) {
    AOS.init(this.config)

    Vue.mixin({
      updated() {
        this.$nextTick(function () {
          AOS.refreshHard() // This is needed to avoid the un-animate aos effect
        })
      }
    })
  }
}

Vue.use(new AosPlugin())

You can probably use it in vanilla vue project, just register this plugin with Vue.use().

@purrplingcat would you have a solution for this problem in Nuxt by any chance as you seem to have been using aos with nuxt?
see this and all replies that follow.
I haven't been able to get it working till now. I tried the code snippet in your reply above, but i'm getting the same result. i.e when the site is generated, aos stops working.
will appreciate any hint. thanks !

//index.html

I  integrated AOS in Gridsome by adding the script and CDN above in my index.html. It worked for me

I am having an issue where the AOS event is triggered twice. Once on the page init and then again on the page load.

any solution for vue3???

any solution for vue3???

You could just do it the same way. This is what I'm using:
//main.js
import AOS from "aos";
import "aos/dist/aos.css";

const app = createApp(App);

app.use({
  install: () => {
    AOS.init({ duration: 500, anchorPlacement: "top-center" });
  },
});

app.mount("#app");

The animation can be reset on an element which is animated when vue component updated. This caused deffect the element hide. I solved it with init Vue plugin (in Nuxt) in this way:
// ~/plugins/aos.js
import Vue from 'vue'
import AOS from 'aos'
import 'aos/dist/aos.css' // If you need load compiled AOS css here in plugin

class AosPlugin {
  config = {
    // Your AOS config here
  }

  install(Vue) {
    AOS.init(this.config)

    Vue.mixin({
      updated() {
        this.$nextTick(function () {
          AOS.refreshHard() // This is needed to avoid the un-animate aos effect
        })
      }
    })
  }
}

Vue.use(new AosPlugin())

You can probably use it in vanilla vue project, just register this plugin with Vue.use().

thanks a lot, this worked in my case.


Include inner exception when throwing

WHAT
Include the inner exception when throwing exception.
WHY
I ran into an issue running this on in AWS Lambda. It had to do with libgdiplus not being installed, but all I was getting was:

Error on zpl element "12345678": The type initializer for 'Gdip' threw an exception.

After this change, the exception will contain the inner exception, which was:

Unable to load shared library 'libgdiplus' or one of its dependencies. In order to help diagnose loading problems, consider setting the LD_DEBUG environment variable: liblibgdiplus: cannot open shared object file: No such file or directory

This is very helpful when troubleshooting.

Seems like an oversight.


What kind of testing should be implemented on this plugin and related ones?

Description
Should we have unit testing or rendering testing or not having like most of the tutor plugins?
Rendering testing: https://github.com/openedx/tutor-contrib-coursegraph/blob/master/tests/test-install.sh

I'd like for there to be some small amount of testing, but most of the official plugins don't have tests that I can see (ecommerce, discovery, forums, etc). I'll ask around and see what people think is most useful.

For python files stored in templates that are rendered we can establish a similar workflow like this one: https://github.com/openedx/tutor-contrib-coursegraph/blob/master/tests/test-install.sh and run all tests (black, codestyle, etc) for that

Sure we could give that a try here and see how it works


feat(ivc): impl ext::synthesize_step_non_base_case

Enhancements to IVC and ECC in Incrementally Verifiable Computation
This PR introduces significant improvements to the IVC algorithm, focusing on the implementation of conditional selection between base and non-base cases, and refining the ECC component.
Here's a breakdown of the changes:
What has been done?
Implementation of Selection Between Base and Non-Base Cases (IVC):
A new feature is introduced to handle the selection between base and non-base cases in the IVC process. At step zero our task is simply to generate a relaxed plonk instance, and at any other step to commit folding. But we are running on-circuit, so we perform both of these actions each time, and then choose one of the options depending on the step.
Implement synthesize_step_base_case for step circuit module
Implemented a method to synthesize steps specifically for the base case of IVC. That is, make a call to the key folding-chip inside the StepCircutiExt abstraction. This is a preparation for synthesizing the step circuit itself
New Method for On-Circuit Conditional Selection (IVC and ECC)

Developed a new method, AssignedRelaxed::conditional_select, for on-circuit conditional selection between the base and non-base cases. This method plays a key role in choosing the correct assigned relaxed Plonk instance based on the step in IVC

Enhanced the ECC component with the implementation of conditional_select. This auxiliary function is simplify on-circuit conditional selection of curve point.

Part of #32

Can you elaborate more on significant improvement? Especially, I am curious on what is the baseline to compare here and how much (estimate) we improve?

It's only about the code & API, not about any internal characteristics of the code
You can see a short version of PR description in commit (there are classic feat, refactor and short description)
Just trying to find a style of PR description that will allow @Gigatron & @drouyang to understand what's going on, but seems to be overdoing it


Fix misaligned loader in MudTable

Description
Fixes misaligned loader in MudTable as described in #7573
How Has This Been Tested?
unit, visually
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

https://github.com/MudBlazor/MudBlazor/assets/57046415/beedca59-3ec7-46b1-8eb2-8671f10521a3
Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

Does such replacement of MudTHeadRow to tr class="mud-table-row" really doesn't not have any impact? As I understand MudTHeadRow has some expansion and selection logic

This additional functionality of MudTHeadRow is causing issues with the loader row in this case. MudTHeadRow handles conditional column rendering based on whether a row is editable, checkable, expandable, etc. However, in this instance, such functionality is undesirable because we want the loading row to always consist of a single cell, with a loader spanning the entire width of the table, hence I think a simple  is more suitable.

What do we do with MudTHeadRow now? Is it still in use somewhere else or is it now dead code? If the latter, the safe way to deal with it is to attach an [Obsolete("Will be removed in v7")] attribute

What do we do with MudTHeadRow now? Is it still in use somewhere else or is it now dead code? If the latter, the safe way to deal with it is to attach an [Obsolete("Will be removed in v7")] attribute

Doesn't look like a dead code? https://github.com/search?q=repo%3AMudBlazor%2FMudBlazor MudTHeadRow &type=code

OK. That repo search function sure is handy, gonna use that more in the future :)

What do we do with MudTHeadRow now? Is it still in use somewhere else or is it now dead code? If the latter, the safe way to deal with it is to attach an [Obsolete("Will be removed in v7")] attribute

Doesn't look like a dead code? https://github.com/search?q=repo%3AMudBlazor%2FMudBlazor MudTHeadRow &type=code

Actually I think it's not a dead code. It stills in use for Column Headers and it's used for Column's behaviors, like sorting, checking, etc.
@BieleckiLtd just removed it on Loading section of the header.

Good job @BieleckiLtd !


I can see my department added to "departments" when I create a record

Story
I can see my department added to "departments" when I create a record.
Context
As reported; this is very convenient for librarians. Even if when they add a record their own department is automatically added – it outweighs having to add it for researchers and secretary staff if they forget it. If we would leave it out we would need to add validation for departments as well, which is tedious for researchers and staff alike.
Success criteria

[x] When I create a record, my current department is automatically added to the record.
[x] I can always remove my department if it is not relevant afterwards

New interface
No automatic retrieval of department upon creation of record

Old interface
Automatic retrieval of department upon creation of record

So where should the department be fetched from?

from the logged in user?
from the contributor list (so a unique list)?

I guess the second one, as departments are about the publication/dataset itself (and not the one doing the task)? In that case, the departments can only be filled during creation, when that creation also imports contributors. Afterwards, indeed it should be left alone..

@nicolasfranck what do you mean by contributor list?
Right now we're going for feature parity, and that means option one. If it takes the same amount of time to implement I can inquire whether option two would be desired for the reviewers and curators.

@mietcls none of them is difficult. So option one, i.e. the departments from the logged in user? So that assumes that the researcher is entering his/her own publications, right?

Discussed with the reviewers; 90% of the cases this is convenient as secretarial staff are usually from the same department, and it is only and issue for reviewers themselves. They find this far more convenient that this goes automatically.

Yes, as described in this comment, it covered 90% of the cases. They'd prefer to get it automatically instead of no department.
However, I can't assess the value of the contributor list yet – can you describe to me how the contributor list would work?

Implemented this.
When creating one / multiple new dataset(s) / publication(s), the "department" field will be automatically populated with the department assigned to the logged-in user who is creating the record.

If the logged-in user is assigned to multiple departments, the first department in their list will be picked.
If a librarian impersonates another user, the department from that user is used instead of the department of the librarian.
If a user isn't a assigned to any departments, the field will be left blank.

Librarians and researchers alike can see this and are able to remove the suggested department from the record(s).

@mietcls Can you test this and close this if this works for you?

Works!


fix a npe in lastLogcatTimestamp

Fix an issue where lastLogcatTimestamp could NPE if there where no adb logcat entries.
@abarth @stevemessick

LGTM

LGTM


Faster ObjectGraph => JSON

Run main ObjectGraph => JSON transformations in parallel. The new limiting factor is indexing records output by the transformation so they can be sorted before being stored.

Codecov Report

Merging #225 into master will decrease coverage by 0.9%.
The diff coverage is 10%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   64.18%   63.28%   -0.91%
==========================================
  Files          34       35       +1
  Lines        2150     2187      +37
  Branches      146      147       +1
==========================================
+ Hits         1380     1384       +4
- Misses        770      803      +33

Impacted Files
Coverage Δ

lib/web_catalog/api_extractor_service.es6.js
21.42% <21.42%> (ø)

lib/web_catalog/object_graph_importer.es6.js
20.4% <3.84%> (-14.21%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79174d5...7844986. Read the comment docs.

Comments addressed (and/or responded inline). @arobins PTAL.


Using multiple backslashes results in only a single one

Describe The Bug
Using multiple backslashes results in only a single one
This is really annoying when trying to access files in a WSL as the path to it is:
\\wsl$\Ubuntu\
To Reproduce
echo \\\\

Result:

\

Expected result:

\\

@Blightbuster thanks a lot for find that. pretty critical bug. I just pushed a fix for it on the development branch so you won't see it in cargo-make just yet, but soon.

this is now released. if you reinstall cargo-make you should have the fix.

I just noticed, that this issue was also discovered earlier but not properly recognized as such in this comment.

i added more tests to ensure this won't happen, but its always tricky to find all of the problems ahead of time. so tha ks a lot for reporting it. it was pretty critical


Falls short as documentation if not using Windows.

Hi team :)
Is it possible at least considering to include a link to this MSFT hosted  related-doc for Linux (Ubuntu) users?
https://techcommunity.microsoft.com/t5/azure-paas-blog/connect-to-azure-cache-for-redis-using-ssl-port-6380-from-linux/ba-p/1186109
Thanks!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 17de8ad0-ac40-26a5-7718-1738f63f0700
Version Independent ID: 797d8d3f-132d-d71f-2df4-caade2b1240b
Content: Use redis-cli with Azure Cache for Redis
Content Source: articles/azure-cache-for-redis/cache-how-to-redis-cli-tool.md
Service: cache
GitHub Login: @flang-msft
Microsoft Alias: franlanglois

@luisgizirian
Thanks for your feedback! We will investigate and update as appropriate.

Hi @flang-msft, @sihegde,
Could you please look into this document request, thanks.

Thanks for the doc suggestion! I've noted it for a future update of this article where we might be able to include it. According to our usual policy, I'll now proceed to close this issue. If you have further information or would like to continue the discussion, please tag me and or reopen the issue. Thank you!
#please-close


suggest support a NoArgsConstructor for ChatFunction

com.theokanning.openai.completion.chat.ChatFunction has no NoArgsConstructor, Causes deserialization to fail。when I use spring find this problem, report an error as follows:
reason is: JSON parse error: Cannot construct instance of com.theokanning.openai.completion.chat.ChatFunction (although at least one Creator exists): cannot deserialize from Object value (no delegate- or property-based Creator); nested exception is com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot construct instance of com.theokanning.openai.completion.chat.ChatFunction (although at least one Creator exists): cannot deserialize from Object value (no delegate- or property-based Creator)\n at [Source: (PushbackInputStream); line: 10, column: 10] (through reference chain: com.jy.business.common.bo.ChatRequest["functions"]->java.util.ArrayList[0])
so suggest support  a NoArgsConstructor for ChatFunction like ChatMessage

Fixed in the latest release :+1:


Fixed an error in the example script

Added the endpointlocation parameter that is required when adding external endpoints to a profile with performance routing type

@dilukose,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@dilukose : Thanks for your contribution to the Azure documentation! The author, @kumudd, has been notified to review your proposed change.

#please-close


POST /template/adl1.4 Required request body is missing

Configuration information

0.19.0
1.17.0
1.0.4
Oracle Corporation 11.0.14+9
Linux amd64 4.18.0-193.65.2.el8_2.x86_64
PostgreSQL 13.4 on x86_64-pc-linux-musl, compiled by gcc (Alpine 10.3.1_git20210424) 10.3.1 20210424, 64-bit

Steps to reproduce
curl --location --request POST '${{SERVER}}/ehrbase/rest/openehr/v1/definition/template/adl1.4'
--header 'Content-Type: application/xml'
--data-raw '
'
Actual result
400 Bad Request
{
"error": "Bad Request",
"message": "Required request body is missing: public org.springframework.http.ResponseEntity org.ehrbase.rest.openehr.OpenehrTemplateController.createTemplateClassic(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String)"
}
Expected result (Acceptance Criteria)
200 OK
Definition of Done

[ ] The defect is checked by an unit or an integration test (Robot)
[ ] Merge Request approved
[ ] Unit tests passed
[ ] Build without errors
[ ] Release notes prepared
[ ] No additional runtime warnings

There is an error in the body of the request. I copy it again
Request body:

The body of request has been copied with errors, the real one is attached in a new fil
HighMed_JugularPulse.txt

Issue closed. The API Gateway was filtering request's body


Clarify TripDescriptor and EntitySelector docs

TripDescriptor refers to a single trip instances, or all trips for a route - it cannot be used to identify sets of trips
ScheduleRelationship field is ignored by consumers if set within an EntitySelector.TripDescriptor
Populate other EntitySelector fields with basic definitions

@tleboulenge I haven't addressed the ADDED scenario here because IMHO that should be addressed when we fully specify ADDED trips, which is a separate task.
@tleboulenge @anatolip-rt PTAL

I've opened a PR on the google/transit repo with these changes (squashed and with better description) here - https://github.com/google/transit/pull/163.


fix(calling): disable options to use voice and video calling

What this PR does 📖

calling isn't supported for the first release. Hide the incomplete/broken feature from the users.

Which issue(s) this PR fixes 🔨

Resolve #

Special notes for reviewers 🗒
Additional comments 🎤

Hey Stu! One small thing on all os's, the button does appear disabled but the user is still able to click and open it. This other thing is totally unimportant and maybe more of a opinion but should we add something to the tooltip that says like "feature not available yet" that way the user doesn't think its like a connection issue or something?

that's a good idea