v7.1.1 segfaults on macOS

Hello 👋 . I'm a maintainer for the Homebrew project. While packaging v7.1.1 of multitail, we ran into an issue where the resulting binary segfaults. To build we run make -f makefile.macosx multitail DESTDIR=#{HOMEBREW_PREFIX}.
Relates to https://github.com/Homebrew/homebrew-core/pull/152509

Can you generate a stacktrace? In a debug build preferably
Op do 26 okt. 2023 23:07 schreef Patrick Linnane @.***>:

Hello 👋 . I'm a maintainer for the Homebrew https://brew.sh project.
While packaging v7.1.1 of multitail, we ran into an issue where the
resulting binary segfaults. To build we run make -f makefile.macosx
multitail DESTDIR=#{HOMEBREW_PREFIX}.
Relates to Homebrew/homebrew-core#152509
https://github.com/Homebrew/homebrew-core/pull/152509
—
Reply to this email directly, view it on GitHub
https://github.com/folkertvanheusden/multitail/issues/21, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUN5IW7OR3RBOMUGTBQ7NNTYBLGIXAVCNFSM6AAAAAA6R2WTEWVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3DIMZXGAZTMMI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x40)
    frame #0: 0x000000018d247600 libsystem_pthread.dylib`pthread_mutex_lock + 12
libsystem_pthread.dylib`pthread_mutex_lock:
->  0x18d247600 <+12>: ldr    x8, [x0]
    0x18d247604 <+16>: mov    w9, #0x545a
    0x18d247608 <+20>: movk   w9, #0x4d55, lsl #16
    0x18d24760c <+24>: cmp    x8, x9

This can't be right: multitail does not use pthreads.
On Thu, Oct 26, 2023 at 11:24 PM Patrick Linnane @.***>
wrote:

thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x40)
frame #0: 0x000000018d247600 libsystem_pthread.dylibpthread_mutex_lock + 12 libsystem_pthread.dylibpthread_mutex_lock:
->  0x18d247600 <+12>: ldr    x8, [x0]
0x18d247604 <+16>: mov    w9, #0x545a
0x18d247608 <+20>: movk   w9, #0x4d55, lsl #16
0x18d24760c <+24>: cmp    x8, x9

—
Reply to this email directly, view it on GitHub
https://github.com/folkertvanheusden/multitail/issues/21#issuecomment-1781915490,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUN5IW237HZNLUZTWGUKAWDYBLIIVAVCNFSM6AAAAAA6R2WTEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBRHEYTKNBZGA
.
You are receiving this because you commented.Message ID:
@.***>

I'm not sure. This is using lldb.
╰─ lldb multitail
(lldb) target create "multitail"
Current executable set to '/opt/homebrew/bin/multitail' (arm64).
(lldb) run
Process 85593 launched: '/opt/homebrew/bin/multitail' (arm64)
Process 85593 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x40)
    frame #0: 0x000000018d247600 libsystem_pthread.dylib`pthread_mutex_lock + 12
libsystem_pthread.dylib`pthread_mutex_lock:
->  0x18d247600 <+12>: ldr    x8, [x0]
    0x18d247604 <+16>: mov    w9, #0x545a
    0x18d247608 <+20>: movk   w9, #0x4d55, lsl #16
    0x18d24760c <+24>: cmp    x8, x9
Target 0: (multitail) stopped.

Can't reproduce it under Linux. I'll see if I can borrow a mac.
On Fri, Oct 27, 2023 at 5:08 PM Patrick Linnane @.***>
wrote:

I'm not sure. This is using lldb.
╰─ lldb multitail
(lldb) target create "multitail"
Current executable set to '/opt/homebrew/bin/multitail' (arm64).
(lldb) run
Process 85593 launched: '/opt/homebrew/bin/multitail' (arm64)
Process 85593 stopped

thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x40)
frame #0: 0x000000018d247600 libsystem_pthread.dylibpthread_mutex_lock + 12 libsystem_pthread.dylibpthread_mutex_lock:
->  0x18d247600 <+12>: ldr    x8, [x0]
0x18d247604 <+16>: mov    w9, #0x545a
0x18d247608 <+20>: movk   w9, #0x4d55, lsl #16
0x18d24760c <+24>: cmp    x8, x9
Target 0: (multitail) stopped.

—
Reply to this email directly, view it on GitHub
https://github.com/folkertvanheusden/multitail/issues/21#issuecomment-1783076809,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUN5IW2NU2KKJ34WCVCL66DYBPE5HAVCNFSM6AAAAAA6R2WTEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTGA3TMOBQHE
.
You are receiving this because you commented.Message ID:
@.***>

you can try this workflow https://github.com/chenrui333/github-action-test/blob/main/.github/workflows/brew-debug.yml and tmate to use macos github action runner to do the debugging (running brew installation in the runner)

Thanks for the suggestion but I don't want to learn a tool only for
debugging multitail on a Mac.
This weekend I fetched the mac at my parent's house. Now installing brew on
it. Takes a bit because the mac is from 2009 and has no SSD :-)
On Mon, Oct 30, 2023 at 3:00 AM Rui Chen @.***> wrote:

you can try this workflow
https://github.com/chenrui333/github-action-test/blob/main/.github/workflows/brew-debug.yml
and tmate to use macos github action runner to do the debugging (running
brew installation in the runner)
—
Reply to this email directly, view it on GitHub
https://github.com/folkertvanheusden/multitail/issues/21#issuecomment-1784360172,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUN5IW4GCOOB4ZO5N3JHLTLYB4C3TAVCNFSM6AAAAAA6R2WTEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGM3DAMJXGI
.
You are receiving this because you commented.Message ID:
@.***>

The segfault is confirmed: I can reproduce it here. Multitail does not
start at all on this mac.
On Mon, Oct 30, 2023 at 4:42 PM Folkert van Heusden @.***>
wrote:

Thanks for the suggestion but I don't want to learn a tool only for
debugging multitail on a Mac.
This weekend I fetched the mac at my parent's house. Now installing brew
on it. Takes a bit because the mac is from 2009 and has no SSD :-)
On Mon, Oct 30, 2023 at 3:00 AM Rui Chen @.***> wrote:

you can try this workflow
https://github.com/chenrui333/github-action-test/blob/main/.github/workflows/brew-debug.yml
and tmate to use macos github action runner to do the debugging (running
brew installation in the runner)
—
Reply to this email directly, view it on GitHub
https://github.com/folkertvanheusden/multitail/issues/21#issuecomment-1784360172,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUN5IW4GCOOB4ZO5N3JHLTLYB4C3TAVCNFSM6AAAAAA6R2WTEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGM3DAMJXGI
.
You are receiving this because you commented.Message ID:
@.***>

solved in 7.1.2
I did a closedir on a nullptr
On Mon, Oct 30, 2023 at 4:54 PM Folkert van Heusden @.***>
wrote:

The segfault is confirmed: I can reproduce it here. Multitail does not
start at all on this mac.
On Mon, Oct 30, 2023 at 4:42 PM Folkert van Heusden @.***>
wrote:

Thanks for the suggestion but I don't want to learn a tool only for
debugging multitail on a Mac.
This weekend I fetched the mac at my parent's house. Now installing brew
on it. Takes a bit because the mac is from 2009 and has no SSD :-)
On Mon, Oct 30, 2023 at 3:00 AM Rui Chen @.***>
wrote:

you can try this workflow
https://github.com/chenrui333/github-action-test/blob/main/.github/workflows/brew-debug.yml
and tmate to use macos github action runner to do the debugging (running
brew installation in the runner)
—
Reply to this email directly, view it on GitHub
https://github.com/folkertvanheusden/multitail/issues/21#issuecomment-1784360172,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUN5IW4GCOOB4ZO5N3JHLTLYB4C3TAVCNFSM6AAAAAA6R2WTEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGM3DAMJXGI
.
You are receiving this because you commented.Message ID:
@.***>

Thank you. I will run it through our CI once you tag it.

done
On Mon, Oct 30, 2023 at 6:29 PM Patrick Linnane @.***>
wrote:

Thank you. I will run it through our CI once you tag it.
—
Reply to this email directly, view it on GitHub
https://github.com/folkertvanheusden/multitail/issues/21#issuecomment-1785716919,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUN5IW75O37LRNKNRZMUWOLYB7PUVAVCNFSM6AAAAAA6R2WTEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBVG4YTMOJRHE
.
You are receiving this because you commented.Message ID:
@.***>

Thank you very much for the help!


Write a C# program for linear search

Description
Write a C# program for linear search
Linear search is a very simple search algorithm. In this type of search, a sequential search is made over all items one by one. Every item is checked and if a match is found then that particular item is returned, otherwise the search continues till the end of the data collection.
Input  : [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
Target : 5

Output : 4

How to contribute

Save the solution in LinearSearch.cs file
Add LinearSearch.cs file in dsa/linear-search folder

!assign


Discord link is invalid O_o

your current discord server link seems to be outdated. I was interessted in joining but i cant for some reason lol.

@Shpendicus Tested here and both links (on the README.md, and on raylib.com), forwarded correctly to https://discord.com/invite/raylib for me.

@Shpendicus Tested here and both links (on the README.md L22, and on raylib.com L39), forwarded discord.gg/raylib correctly to discord.com/invite/raylib for me.
Edit: editing; added line marks.

somehow my connection broke, it works now, sry.. lol


[DEV-1278] Add cosmovisor support for tests and debian packages

Task linked: DEV-1278 Add script into the Debian package to include CosmosVisor


NAS-126925 / 24.10 / Do not retrieve app's history in debug

This commit adds changes to not retrieve app's history in debug as it's not really useful and can be asked for later explicitly if required which would be quite rare. Secondly app's history has config of user which can contain sensitive information - it cannot be managed in the schema of app's but can be managed here, however seeing that retrieving history has little to no utility, let's remove it from debug.

Jira URL: https://ixsystems.atlassian.net/browse/NAS-126925

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.


Parse environment markers when auto installing.

The following change in Mbed OS added an environment marker to
the python requirements file:
https://github.com/ARMmbed/mbed-os/pull/10096/files#diff-b4ef698db8ca845e5845c4618278f29aR24
Mbed CLI did not know how to parse this, so a warning was always
generated. This change now parses the "platform_system" marker, and
adds a mechanism to add more if needed in the future.
This fixes #888.
@teetak01 Jimmy is unavailable for the month April, can you review please?

code caters for the cases I can know of, welcome improvement.


Maven version

Hi,
I would like to know how I can find out which version of Flutter is currently in use on the Maven repo (https://mvnrepository.com/artifact/io.flutter).
Actually, the version name is 1.0.0-b09f014e9658da6647361e7e416d1a159d34192d. Which Flutter version does this correspond to, and how can I find this information in the future ?
Many thanks,

Hi @Cedricoh
Please join Discord for asking questions like these, a team member might be able to answer your question
Closing


dns_searchs expected to be an array

see tasks/main.yml

Thanks @sumkincpp
Sorry for the late review, just come back from traveling


[BUG] PHP Fatal error:  Cannot declare class, because the name is already in use

Linux 6.1.0-18-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.76-1 (2024-02-01) x86_64 GNU/Linux
PHP 8.2.18 (cli) (built: Apr 11 2024 22:07:45) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.18, Copyright (c) Zend Technologies
    with Zend OPcache v8.2.18, Copyright (c), by Zend Technologies
hyperf/cache                       v3.1.27 A cache component for hyperf.
hyperf/code-parser                 v3.1.27 A code parser component for Hyperf.
hyperf/codec                       v3.1.27 A codec component for Hyperf.
hyperf/collection                  v3.1.27 Hyperf Collection package which come from illuminate/collections
hyperf/command                     v3.1.27 Command for hyperf
hyperf/conditionable               v3.1.27 Hyperf Macroable package which come from illuminate/conditionable
hyperf/config                      v3.1.27 An independent component that provides configuration container.
hyperf/context                     v3.1.27 A coroutine/application context library.
hyperf/contract                    v3.1.27 The contracts of Hyperf.
hyperf/coordinator                 v3.1.27 Hyperf Coordinator
hyperf/coroutine                   v3.1.27 Hyperf Coroutine
hyperf/database                    v3.1.27 A flexible database library.
hyperf/db-connection               v3.1.27 A hyperf db connection handler for hyperf/database.
hyperf/devtool                     v3.1.27 A Devtool for Hyperf.
hyperf/di                          v3.1.27 A DI for Hyperf.
hyperf/dispatcher                  v3.1.27 A HTTP Server for Hyperf.
hyperf/engine                      v2.11.0 Coroutine engine provided by swoole.
hyperf/engine-contract             v1.10.1 Contract for Coroutine Engine
hyperf/event                       v3.1.27 an event manager that implements PSR-14.
hyperf/exception-handler           v3.1.27 Exception handler for hyperf
hyperf/framework                   v3.1.27 A coroutine framework that focuses on hyperspeed and flexible, specifically use for build microservices and middlewares.
hyperf/guzzle                      v3.1.27 Swoole coroutine handler for guzzle
hyperf/http-message                v3.1.27 microservice framework base on swoole
hyperf/http-server                 v3.1.27 A HTTP Server for Hyperf.
hyperf/logger                      v3.1.27 A logger component for hyperf.
hyperf/macroable                   v3.1.27 Hyperf Macroable package which come from illuminate/macroable
hyperf/memory                      v3.1.27 An independent component that use to operate and manage memory.
hyperf/model-listener              v3.1.27 A model listener for Hyperf.
hyperf/pipeline                    v3.1.27 Hyperf Macroable package which come from illuminate/pipeline
hyperf/pool                        v3.1.27 An independent universal connection pool component.
hyperf/process                     v3.1.27 A process component for hyperf.
hyperf/redis                       v3.1.27 A redis component for hyperf.
hyperf/serializer                  v3.1.27 A serializer component for Hyperf.
hyperf/server                      v3.1.27 A base server library for Hyperf.
hyperf/stdlib                      v3.1.27 A stdlib component for Hyperf.
hyperf/stringable                  v3.1.27 Hyperf Stringable package which come from illuminate/support
hyperf/support                     v3.1.27 A support component for Hyperf.
hyperf/tappable                    v3.1.27 Hyperf Macroable package which come from illuminate/tappable
hyperf/testing                     v3.1.27 Testing for hyperf
hyperf/translation                 v3.1.27 An independent translation component, forked by illuminate/translation.
hyperf/utils                       v3.1.27 A tools package that could help developer solved the problem quickly.
hyperf/validation                  v3.1.27 hyperf validation

swoole

Swoole => enabled
Author => Swoole Team<EMAIL_ADDRESS>Version => 5.1.1
Built => Apr  2 2024 09:03:56
coroutine => enabled with boost asm context
epoll => enabled
eventfd => enabled
signalfd => enabled
cpu_affinity => enabled
spinlock => enabled
rwlock => enabled
sockets => enabled
openssl => OpenSSL 3.0.11 19 Sep 2023
dtls => enabled
http2 => enabled
json => enabled
mutex_timedlock => enabled
pthread_barrier => enabled
futex => enabled
mysqlnd => enabled
async_redis => enabled

Directive => Local Value => Master Value
swoole.enable_coroutine => On => On
swoole.enable_library => On => On
swoole.enable_fiber_mock => Off => Off
swoole.enable_preemptive_scheduler => Off => Off
swoole.display_errors => On => On
swoole.use_shortname => Off => Off
swoole.unixsock_buffer_size => 8388608 => 8388608

Description:
The ApartmentArea class is loaded as an Apartment class.
PHP Fatal error:  Cannot declare class App\System\Lib\Api\Request\Apartment, because the name is already in use in /var/app/System/Lib/Api/Request/Apartment.php on line 7
The error only appears with exactly these two class names.
If I rename ApartmentArea, everything works.
Works:

ApartmentsArea
ApartmentAreas
ApartmentAre

Two classes like this also work

Foo
FooArea

The folder App/System/Lib/Api/Request/ contains only these 2 classes for testing. The file name is also irrelevant. Foo.php contains ApartmentArea class and the problem occurs when starting the application.
The Runtime folder has also been emptied.
Steps To Reproduce:
App/System/Lib/Api/Request/Apartment.php
        declare(strict_types=1);
	namespace App\System\Lib\Api\Request;

	use App\System\Lib\Api\BaseRequest;

	abstract class Apartment extends BaseRequest{}

App/System/Lib/Api/Request/ApartmentArea.php
        declare(strict_types=1);
	namespace App\System\Lib\Api\Request;

	use App\System\Lib\Api\BaseRequest;

	abstract class ApartmentArea extends BaseRequest{}

If Foo.php contains class ApartmentArea, And the file ApartmentArea.php contains class ApartmentArea too,
It will cause error, it is a normal phenomenon.

Once is Apartment and the othe rone is ApartmentArea.
But I found out that it was a problem in the composer cache. I refreshed it once and everything worked again.

sure


Todo List 2020-11-27

Todo list

[ ] readme reinforce

[ ] explain on each cmd
[ ] usage on each cmd at README.md

[ ] fmt, fmtV management - more clear, minimal print, add color
[ ] latest option

[ ] gvm install latest
[ ] gvm use latest

[ ] bugfix

[ ] install not working at once. check sync - may fixed
[ ] gvm install should be atomic - so prepare all and if failed rollback

install process

check the current go.exe file location and rename-to-be
check the next go.exe file name and location
rename current go.exe - but prepare for rollback
copy and rename next go.exe file

if any failure, then rollback to original

summarize the source code of the dl
alreay analysis, so need to summarize
https://go.googlesource.com/dl


[Bug] Duplicated deposit entries in General Ledger transformation

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the issue
When transforming from the deposit and deposit line table to the QUICKBOOKS__GENERAL_LEDGER table, we see duplication of deposit lines for a subset of accounts.
Relevant error log or model output
Between these two select statements, the deposit lines selected are doubling:
select * from quickbooks.deposit_line dl left join quickbooks.deposit d on dl.deposit_id = d.id

where deposit_account_id in (432, 435);

select

*

-- case when REGEXP_LIKE(gl.ACCOUNT_NUMBER::numeric, '^[0-9]+$') then floor(gl.ACCOUNT_NUMBER::numeric / 10) * 10
--     else 65700 -- or some default value indicating an error
-- end as INT_ACCOUNT_NUMBER

from <schema>.QUICKBOOKS_QUICKBOOKS.QUICKBOOKS__GENERAL_LEDGER as gl
where date_trunc('month', transaction_date) = '2024-01-01'
and account_name like '%Deposit%';

Expected behavior
For each transaction id and account number pair, we'd expect to only see one record hitting the general ledger.
dbt Project configurations
We utilize the Fivetran Quickstart models out of the box.
Package versions
We utilize the Fivetran Quickstart models out of the box.
What database are you using dbt with?
snowflake
dbt Version
We aren't hosting our own, we're using the Fivetran UI.
Additional Context
2024-02-15 1_19pm (1).csv
2024-02-15 1_19pm.csv
Are you willing to open a PR to help address this issue?

[ ] Yes.
[ ] Yes, but I will need assistance and will schedule time during our office hours for guidance
[X] No.

Hi @kelsey-fecho ! Thanks for bringing this to our attention.
I'm wondering, might you happen to have has multiple undeposited funds accounts? In the intermediate model, we essentially do a cross join on the undeposited fund accounts. If there are multiple accounts that fit this criteria, we could get duplicates originating from this model.
This is also the reason we included the quickbooks__undeposited_funds_reference variable to allow folks to adjust this if there were multiple accounts in their environment. But that variable is not configurable in Quickstart so that filter is probably not working as intended for your purpose.
If that's not the case, would you be willing to email the solutions team at<EMAIL_ADDRESS>with details about your account? We might need to request data access to look into your int_quickbooks__deposit_double_entry model to see what might be causing issues.

@fivetran-avinash ahh, we do have multiple undeposited fund accounts in that table! That would do the trick. Since it's not we don't have that filter available, are there any other workarounds we could?

There are 2 accounts, so is there a way we could just ignore 1?

Hi @kelsey-fecho , glad to hear that we've identified the potential root issue!
It's a good question about what to do here. When you examine the undeposited fund account data, is there any particular filter or condition that you think could be applied to these accounts that would exclude the one account you don't want? Is there some field or property to that one account that identifies it as something you wouldn't want to join in?
Also, usually when we apply a fix to a transformations model, we want to make sure that this fix will work for all customers. If you can find a particular filter, do you think this fix would also work for other customers with multiple undeposited fund accounts?
Or do you think the quickbooks__undeposited_funds_reference variable is the only path forward for filtering down that account?
If you get a chance, please explore and let us know what you find! We'll also brainstorm on our end whether there are potential workaround solutions that we could use.

Hi @kelsey-fecho following up to @fivetran-avinash's comment above, we have confirmed that the issue is the lack of the mentioned variable in quickstart. In the meantime, we recommend using this package via dbt-core so you can take advantage of setting the quickbooks__undeposited_funds_reference var. If you have any additional comments or questions, you can continue to reach us via this thread!


nondeterminism: remove *.toLocaleString ?

If this changes behavior according to something outside the process, we need to remove it, or remap it to e.g. Object.prototype.toString.
There is an Object.prototype.toLocaleString, but according to the spec it exists purely as a fallback for other objects that don't override it (and it just delegates to the plain .toString() method on this).
But for other primordial objects, we need to check that their individual toLocaleString method doesn't cause nondeterminism. This includes Number, Array, and Date, at the very least.

@erights has released changes that redirect the locale methods of strings to the corresponding non-locale-oriented method.


Incorrect --show-source for Jupyter Notebooks with continuous import blocks

Take the test case as an example where there are two cells with unsorted imports.
When run using the following command:
cargo run --bin ruff -- check --select=I001 --no-cache --isolated crates/ruff/resources/test/fixtures/jupyter/isort.ipynb --show-source

The output is a single diagnostic:
crates/ruff/resources/test/fixtures/jupyter/isort.ipynb:cell 1:1:1: I001 [*] Import block is un-sorted or un-formatted
  |
1 | / from pathlib import Path
2 | | import random
3 | | import math
4 | | from typing import Any
5 | | import collections
6 | | # Newline should be added here
  | |_^ I001
7 |   def foo():
8 |       pass
  |
  = help: Organize imports

Found 1 error.
[*] 1 potentially fixable with the --fix option.

While there are 2 import blocks (separated by a cell boundary). The fix produces the correct number which is 2:
$ cargo run --bin ruff -- check --select=I001 --no-cache --isolated crates/ruff/resources/test/fixtures/jupyter/isort.ipynb --fix
    Finished dev [unoptimized + debuginfo] target(s) in 0.38s
     Running `target/debug/ruff check --select=I001 --no-cache --isolated crates/ruff/resources/test/fixtures/jupyter/isort.ipynb --fix`
Found 2 errors (2 fixed, 0 remaining).

Oh, I think I found the problem. Should be an easy fix actually :)


Peer to peer code review October 13th

Review Feedback
Generally, you have a good code without errors and a well-arranged layout. JavaScript is organized in modules with no linters error(s). We like the way that you implement User experience in your project.
However, below are some places we think you can improve on 👍 ;

Kindly you should deploy your project so that anyone can interact with it.
You should show a message when the user tries to send a form that doesn't have the right patterns or it's empty.
Also, you should improve your README file, specifically Getting Started and Install.

Happy  Coding 💯

Thanks my friends, for your valuable feedback.


[Question] track current selected viewController

Hello @rechsteiner !
Is there a way to track the index of currently selected viewController, when using FixedPagingViewController ?

Hi! It's currently not possible, but I will add this to the next release. I'm planning on adding a delegate that looks like this:
public protocol FixedPagingViewControllerDelegate : class   {
  func fixedPagingViewController(
    fixedPagingViewController: FixedPagingViewController,
    willScrollToItem: ViewControllerItem,
    atIndex index: Int)

  func fixedPagingViewController(
    fixedPagingViewController: FixedPagingViewController,
    didScrollToItem: ViewControllerItem,
    atIndex index: Int)
}

Added in #46. This lets you set a FixedPagingViewControllerDelegate on the itemDelegate property, which gives you a ViewControllerItem struct that contains the selected view controller ✌


Accidental zooming when dragging selection box on macOS

Very similar to an issue I opened previously: https://github.com/jgraph/drawio/issues/267
When using cmd + click + drag to select many items at once it's very easy to accidentally zoom in and out. I do this multiple times a day and it's pretty annoying. Again it's because the magic mouse is a little too magical. I'm going to switch to a mouse with a normal scrollwheel. But still, it would be nice if the magic mouse worked well.

Try using Shift+Click+Drag instead.

Ok yeah that works.  Thanks.


All kind of measure (Recall, NDCG_binary_at_k_batch) alway return NaN

Hi all, when training the Recall measure always returns the NaN value, which means the model could not learn anything? right? that means the model could not describe a latent vector similar input vector? Even though I tried to compute the recall measure on training data, it's still NaN :) .  it's similar to training accuracy = 0?
And finally, this model is useless??
Thank you

Try running it python2. That worked for me.

Try running it python2. That worked for me.

I will try, Thank you so much

Try running it python2. That worked for me.

Thank your for your answer but I tried and it's still NaN value :(((((((((((((


⚠ Bofrost.nl has degraded performance

In 885fa96, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1531 ms

Resolved: Bofrost.nl performance has improved in 326453b.


gst launch set property problem and some problem...

Hi
I'm using dmm72buc02-ml sensor in raspberry Pi.
I'm using sensor with shell script.
gst-launch v4l2 ...
How can i set property value?
For example, brightness, contrast,gain, exposure, auto reference, auto max value, sharpness, gamma, denoise..
And, other problem...
I can't get data with 2592x1944
I can get data with 1280x720 or 1920x1080 but can't 2592x1944
How Can i get that data???
I want to example about these problem or shell script document about gst-launch...

Hi
If you do not get images in the highest resolution, you should lower the frame rates:
gst-launch-0.10 v4l2src ! video/x-raw-gray,width=2592,height=1944,framerate=3/1 ! (...)
If you want to set the camera properties, you can use v4l2-ctl:
v4l2-ctl -c gain=4
This belongs to the v4l-utils package.
Stefan


add wlsnarf clipboard tool

DESCRIPTION
wlsnarf
wlsnarf is a highly extensible clipboard tool
snarfsrv (in the same repo) is an example filesystem-based clipboard manager
CHECKLIST
I have:

[X] 🤳 made sure that what I am adding is targeted for Wayland.
[X] 🔗 checked that the link I am using refers to the source repository.
[X] 📝 checked that the projects and/or the sections are alphabetically sorted.

Thank you!


Automated cherry pick of #9502: fix(keystone): always upload&refresh service config whenever service …

Cherry pick of #9502 on release/3.5.
#9502: fix(keystone): always upload&refresh service config whenever service …

Codecov Report

Merging #9504 (5dbf470) into release/3.5 (6a15e02) will decrease coverage by 1.82%.
The diff coverage is 0.50%.

@@               Coverage Diff               @@
##           release/3.5   #9504       +/-   ##
===============================================
- Coverage         5.98%   4.16%    -1.83%
===============================================
  Files              796     164      -632
  Lines           125693   25192   -100501
===============================================
- Hits              7522    1048     -6474
+ Misses          117504   24052    -93452
+ Partials           667      92      -575

Flag
Coverage Δ

aFlag
4.16% <0.50%> (-1.83%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cloudcommon/db/jointbase.go
0.00% <ø> (ø)

pkg/cloudcommon/db/sharablebase.go
6.01% <0.00%> (-0.06%)
:arrow_down:

pkg/cloudprovider/objectstore.go
2.06% <0.00%> (-0.51%)
:arrow_down:

pkg/cloudprovider/route_table.go
0.00% <0.00%> (ø)

pkg/compute/regiondrivers/aliyun.go
0.33% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/regiondrivers/aws.go
1.05% <0.00%> (-0.05%)
:arrow_down:

pkg/compute/regiondrivers/azure.go
44.44% <0.00%> (-22.23%)
:arrow_down:

pkg/compute/regiondrivers/base.go
1.02% <ø> (ø)

pkg/compute/regiondrivers/ctyun.go
50.00% <0.00%> (-25.00%)
:arrow_down:

pkg/compute/regiondrivers/google.go
2.41% <0.00%> (-0.13%)
:arrow_down:

... and 565 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b39a45f...5dbf470. Read the comment docs.


Scrolling with your mouse doesn't select all items

When you scroll with your mouse to pick an item from the hot bar, your mouse will get stuck and only go to the second hotbar slot. I'm trying to select stone from my hotbar, but scrolling to select the item doesn't work. Also pressing numbers 1-8 on your keyboard moves your hotbar selection back to slot 1 in your hotbar.

I'm currently only testing on mobile (iOS and Android). Windows 10 Edition is another can of worms I do not wish to handle at the moment.

@minecrafter This is happening for iOS and Android too, not just Windows 10 Edition.

Regardless, this is a low priority.

Thank you


peerconnection should expose oniceconnection state changes

Right now there's no way for clients to catch events such as transient disconnection events, forcing peerconnection.ts itself to log warnings.

No plans to fix this in the forseeable future.


Assorted convenience functions

This is some assorted stuff I've had in my publishing toolkit(s) for a while that I find myself using a lot and re-inventing any time I don't have those libraries handy. It seems like they should just be part of SILE core but in anybody has better ideas  on how they should be implemented I'm listening...

Very lovely! Thank you!


Change value format for ingress.appscode.com/service-monitor-labels

This should be a string instead of map

This should be also done for node-selector.
Basically, we want to move them to Ingress.Spec at next iteration.

These are used as labels. So, service-monitor-labels will always be a map. NodeSelector is a map in Kube for now. So, no need to change that either.


Token Cleanup constraint violation

Constraint violation error comes up when running the token cleanup stored procedure after running the session cleanup procedure.
Reason:
CHNK_IDN_OATH_ACCS_TOK_PRI and BATCH_IDN_OATH_ACCS_TOK_PRI is used in both session cleanup and token clean scripts.
https://github.com/wso2/carbon-identity-framework/blob/master/features/identity-core/org.wso2.carbon.identity.core.server.feature/resources/dbscripts/stored-procedures/oracle-11.x/oracle-tokencleanup.sql#L251

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Create test_MB_dist.py

Added an outline for testing a function inside MB_dist.py

Also created a test/ folder


New version: torProject.Tor.Browser version 13.0

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Ok so here is the issue:
Before this new version the install URL used to follow a different scheme: https://archive.torproject.org/tor-package-archive/torbrowser/${VERSION}/torbrowser-install-${VERSION}_ALL.exe
With this new version they changed it and so I couldn't find an install that looked exactly like the old one https://archive.torproject.org/tor-package-archive/torbrowser/13.0/
So I ended up using the "portable" install
I'll see if there's something I can do by changing the
InstallerType: nullsoft

Sorry!
It is a nullsoft installer and both the interactive and silent install seem fine?
I'll add a commit to remove the x86 one


Binance added staking endpoint, it's not too difficult to add it in binance-connector

Issue subject
I've tried to enhance Binance-connector with a Spot method :
    """
    https://binance-docs.github.io/apidocs/spot/en/#get-staking-product-position-user_data
    GET /sapi/v1/staking/position (HMAC SHA256)

    Name         Type    Mandatory    Description
    ========================================
    product      ENUM    YES        "STAKING" for Locked Staking,
                                    "F_DEFI" for flexible DeFi Staking,
                                    "L_DEFI" for locked DeFi Staking
    productId    STRING  NO
    asset        STRING  NO
    current      LONG    NO    Currently querying the page. Start from 1.

Expected behaviour
display my account staking position.
Actual behaviour
my account staking position is displayed, all is right.
Un fortunatly, i have no time, just now, to implement it in binance-connector.
If someone is in a hurry to have it, just do it.
Environment
Provide any relevant information about your setup, such as:

Version of binance-connector-python : 1.11.0
Python version : 3.9
Operating system : macOS 12.3.1

The Binance Python Connector will soon support the new Staking endpoints.

It's supported in the latest release.


mjml with grapesjs

How to update MJML latest version in grapesJS?

At the moment of writing, the plugin uses already the latest stable version (v3.3.5).
If you want to use some alpha version update it via package.json


for loop continue never increase index

for loop continue statement have bug,it will never increase index and turn into infinite loop.
for(let i=0;i<10;i++){
    continue;
}
print('done');
printFlush();

compiler output:
set i:1:8 0
op lessThan &t0 i:1:8 10
jump 6 equal &t0 0
jump 1 always
op add i:1:8 i:1:8 1
jump 1 always
print "done"
printflush message1
end

mlogjs version: 0.4.2

The fix is now available in version 0.4.3

nice :)

the loop bug still existing in 0.4.3.
compile output is exactly same.
set i:1:8 0
op lessThan &t0 i:1:8 10
jump 6 equal &t0 0
jump 1 always
op add i:1:8 i:1:8 1
jump 1 always
print "done"
printflush message1
end

Huh, seems like the version was released with an outdated build. I should deal with this and #73

Ok, now it's actually present in the version 0.4.4


How to lazy load profile pictures not yet in the store

I can get the profile picture URL using
const url = await WPP.contact.getProfilePicture('[number]@c.us');

(as per the doc getProfilePictureUrl)
But if my WhatsApp web has not downloaded the profile picture then using the fuction will return undefined.
How do I ask WhatsApp to load the profile picture (and save it to the store) for a chat?

I did a lot of tests and this is a bug on WhatsApp servers, that send the wrong picture URL.
Currently, the methods always return the latest URL


Step implementation not found in a multi-module project when try to use concepts

Expected behavior
All steps should be marked as implemented
Actual behavior
Step implementation not found
Steps to reproduce

Create a multi-module project in IDEA
Add concept in one module
Second module contains a dependency on the first one
Try to use the concept in the second module

Gauge version
0.7.10

same with https://github.com/getgauge/gauge/issues/1078#event-3952274943


Report that an action has been aborted on configuration failures

Description
This PR adds support for reporting with status: aborted if a configuration failure has occurred.
Dependencies
We shouldn't merge this PR until the /repositories/{repository_id}/code-scanning/analysis/status schema has been updated to allow for the new status.
Merge / deployment checklist

Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!

[x] CodeQL using init/analyze actions
[x] 3rd party tool using upload action

[x] Confirm this change is backwards compatible with existing workflows.
[ ] Confirm the readme has been updated if necessary.

Could you run a test?

Looking good in Splunk: https://git.io/JfpSM


Remove the table outer border to improve the rendering

I've removed the outer border on the table (defined in the default Asciidoctor stylesheet):
before

after

ping @oncletom 😄
//cc @mojavelinux Maybe we should update the default stylesheet ? I didn't notice any visual difference in the browser (Chrome and Firefox)

I could be wrong, but I think it's used once you start getting into various combinations of frame and grid. The border is configured to collapse, so it should just fuse with the borders from the cells.

Yes but I think we should use cell borders (configured to collapse) instead of an outer border defined on the table. The rendering looks the same but the main advantage is that if the table is spread on multiple pages then the border will not be visible when the row ends at the end of a page (see the bottom of the page) and the repeated table header will have a top border (see the top of the page).
Does it make sense ?

I see what you're saying. Yes, that makes perfect sense. Let's address this in the default stylesheet.

I've created an issue upstream.
In the meantime I'm merging this fix.

Yes but I think we should use cell borders (configured to collapse) instead of an outer border defined on the table.

The problem with this approach is that it's not possible to achieve all the permutations of frame and grid that are supported today (in the way they are supported). We'd have to abandon the current behavior and define a new behavior based on cell collapsing. So there are tradeoffs. You fix some things, but then you break others.


dotnet build doesn't capture warnings

Environment

Server - VSTS or TFS on-premises?
VSTS

Agent - Hosted or Private:
Private

Issue Description
We have a .NET Core task which is running a build command. The build is showing warnings in Visual Studio when built locally and also in the logs when being built by VSTS. These are not captured by VSTS and so are not displayed in the build UI.
2018-07-11T14:03:44.2237927Z C:\Program Files\dotnet\sdk\2.1.301\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "Microsoft.AspNetCore.Hosting" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [D:\VSTS Agent\_work\23\s\YorkshireWater.LeakageAPI\YorkshireWater.LeakageAPI.Tests\YorkshireWater.LeakageAPI.Tests.csproj]

I believe this is because the command is not using the ##[warning] syntax used by the equivalent Visual Studio build tasks (see example below). Since this is a task for the dotnet command, it should be able to capture the warning messages which it uses.
2018-07-17T08:53:19.6614622Z ##[warning]CSC(0,0): Warning CS8032: An instance of analyzer Microsoft.EntityFrameworkCore.RawSqlStringInjectionDiagnosticAnalyzer cannot be created from C:\Users\svcbuildservervsts\.nuget\packages\microsoft.entityframeworkcore.analyzers\2.1.1\analyzers\dotnet\cs\Microsoft.EntityFrameworkCore.Analyzers.dll : Could not load file or assembly 'Microsoft.CodeAnalysis, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the file specified..

Yes, it's a big problem for us too. We have a zero-warning policy on checked in code and we need to visualize that on VSTS, just as you could with old VS builds.

We will pick this up as an enhancement to the task in the next sprint planning. Thanks for the feedback!!
Atul

the easiest workaround to temporary fix the issue I found out is to use MSBuild task MSBuild@1 instead of of dotnet task DotNetCoreCLI@2 to build an ASP.Net Core solution. So the step would be
- task: MSBuild@1   displayName: Build   inputs:     configuration : $(buildConfiguration)
instead of
- task: DotNetCoreCLI@2   displayName: Build   inputs:     command: build     configuration : $(buildConfiguration)
So the warnings will be visible in Build Pipeline

You can also work around this by using the "Warning Filters" regular expression.
e.g.
/\s(\d+)\s+warning/i

You can also work around this by using the "Warning Filters" regular expression.
e.g.
/\s(\d+)\s+warning/i

This also matches "0 Warning(s)". I think this should do the trick:
\s([1-9]\d*\.?[0]*)\s+Warning\(s\)|\s([1-9]\d*\.?[0]*)\s+Error\(s\)

I created a (ugly) workaround which can be used to show the build warnings in the Log and Summary tab in Azure Devops. I only tested this azure-pipelines.yml for .NET Core 2.2.102. But feel free to try it out: https://gist.github.com/melisco/ee851a6dccd5fc1d936f769bcf8e0fd2

This is still an issue in Azure DevOps over a year later. IMO there really needs to be a custom msbuild logger used in "dotnet build" which reports errors in the required format.

In a similar note, a forward logger would be nice because using just "dotnet build" along with the GitVersionTask package reference doesn't update the build number since there is no logging. Running the same project with MSBuild task work because of the logging output to the console.

Note also that many of these workarounds don't work on Linux - as far as I recall, the msbuild task doesn't work correctly on Linux (eg Ubuntu 16.04), b/c the msbuild version resolution is different, and invoking it is different. This is part of the reason why we need an MSBuild logger that writes pipelines output out of the box.
Also, a design suggestion: I think it would be super useful to have a separate nuget package for a dotnet core compatible Azure pipelines msbuild logger. There are a lot of other situations where it could be used (eg when running a cake build in pipelines, and cake calls dotnet build, so would have to pass in the right arguments to use the pipelines logger).
I've thought about writing and sharing my own, but this seems like something Microsoft would/should own...

@bishal-pdMSFT Any updates on this one?

I'm running into this as well, trying to build using DotNetCoreCLI@2 on Ubuntu. This seems like a significant bug. Reporting 0 warnings when there are > 0 warnings means bugs can sneak into my code. Going to try that massive powershell blob linked above. 😢

Thanks for feedback folks. We will plan to start this work in 2-3 weeks time.

It looks like this behavior was recently addressed with the release of #12358 in version 2.166.1 of the .NET Core Azure DevOps build task. That task now additionally logs warnings in a line with a ##[warning] prefix. This caught us by surprise because several of our builds have warnings that had gone undetected. After v2.166.1 of the DotNetCoreCLIV2 task was released to our Azure DevOps pipelines, our Check build warnings task (Build Quality Checks) started failing for those builds.

In case it's useful to anyone who is not using the DotNetCoreCLI@2 task, but is using another way to run dotnet builds and wants build warnings to propagate to their Azure Pipelines build, you can download and unzip the msbuild logger (from https://vstsagenttools.blob.core.windows.net/tools/msbuildlogger/3/msbuildlogger.zip), and add it to your build as a build argument.
For example, I am using the following to return an msbuild argument that is used when running in Azure Pipelines:
        /// <summary>
        /// When running on an Azure Pipelines build agent, downloads (if necessary) an Azure build logger, and returns an msbuild argument
        /// referencing the build logger.
        /// </summary>
        /// <returns>An msbuild argument referencing the Azure build logger, when running on a build agent. When not running on a build agent, <c>null</c> is returned.</returns>
        private async Task<string?> CreateBuildAgentMsBuildLoggerArgument()
        {
            const string buildLoggerPackageUrl = "https://vstsagenttools.blob.core.windows.net/tools/msbuildlogger/3/msbuildlogger.zip";
            const string buildLoggerFileName = "Microsoft.TeamFoundation.DistributedTask.MSBuild.Logger.dll";

            // Detect if we're running on a build agent
            var workFolderEnvVar = Environment.GetEnvironmentVariable("AGENT_WORKFOLDER");
            if (string.IsNullOrWhiteSpace(workFolderEnvVar))
            {
                return null;
            }
            var workFolder = new DirectoryInfo(workFolderEnvVar);
            if (! workFolder.Exists)
            {
                return null;
            }

            // Check if build logger assembly has been downloaded
            var buildLoggerFolder = workFolder.Subdir("dotnet-build-logger");
            var buildLoggerDll = new FileInfo(Path.Join(buildLoggerFolder.FullName, buildLoggerFileName));
            if (! buildLoggerDll.Exists)
            {   // Download build logger
                var opKey = "download-dotnet-msbuild-logger";
                _logger.LogStartOperation(opKey, $"Downloading Azure msbuild logger...");
                buildLoggerFolder.Create();
                using (var http = new HttpClient())
                {
                    var response = await http.GetAsync(new Uri(buildLoggerPackageUrl));
                    if (! response.IsSuccessStatusCode)
                    {
                        _logger.LogEndOperation(opKey, false, $"Error downloading msbuild logger from {buildLoggerPackageUrl}: {response.StatusCode}");
                        return null;
                    }
                    await using var responseStream = await response.Content.ReadAsStreamAsync();
                    using var archive = new ZipArchive(responseStream);
                    foreach (var entry in archive.Entries)
                    {
                        var entryFile = Path.GetFullPath(Path.Combine(buildLoggerFolder.FullName, entry.FullName));
                        entry.ExtractToFile(entryFile);
                    }
                }

                buildLoggerDll.Refresh();
                if (buildLoggerDll.Exists)
                {
                    _logger.LogEndOperation(opKey, true, "Azure msbuild logger successfully downloaded.");
                }
                else
                {
                    _logger.LogEndOperation(opKey, false, $"Msbuild logger not found in package: {buildLoggerFolder.FullName}");
                    return null;
                }
            }

            return $"-dl:CentralLogger,\"{buildLoggerDll.FullName}\"*ForwardingLogger,\"{buildLoggerDll.FullName}\"";
        }

I wonder if you could also support it out of the .NET Core azure devops task (by providing some nuget package). Some people call dotnet build from powershell or docker file. It would be nice to have nice experience while using this tools too

I have a build script based on bullseye that manually calls into MSBuild.
That allows us to trigger builds manually, independent of Azure DevOps.
Having this logger available would be extremely useful for us tho, so our PR build validation errors show up properly in Azure Pipelines.

I did not realize that this issue was still open. As @Blackbaud-TommyVernieri commented above the fix is already done via PR https://github.com/microsoft/azure-pipelines-tasks/pull/12358/files
Regarding the ask for a nuget package so that it can be used outside of ADO, I think this repo is not the right target for such ask as it only tracks task issues. May be a better place is to start with .Net Core team on what they think about this.
Hence I am closing this issue.

@bishal-pdMSFT not sure I follow properly on (or simply understand) how the NuGet package will solve this issue for Docker task.
Multi-stage build within Dockerfile is now encouraged, even in default aspnetcore template. So having Docker task picking up the warning properly in that case seem like a reasonable ask as it only follows guidelines enforced by Microsoft itself...

This also matches "0 Warning(s)". I think this should do the trick:

Where do I set this "warning filter" expression? I can't find any documentation about it?

Why reporting DotNetCoreCLI warnings as Azure DevOps warnings was added only to the build command?
What about some other commands like restore or publish? Why not give user option via task input to specify whether they want to capture warnings for this task regardless of command used?
Before we had restore -> build -> publish flow via DotNetCoreCLI tasks and warnings from build were reported. We simplified pipeline to restore -> publish, as publish is going to build anyways, but now all warnings are gone from Azure DevOps 🤣
Issue regarding publish command is also reported here: https://github.com/microsoft/azure-pipelines-tasks/issues/18380
I would expect DotNetCoreCLI to support reporting warnings as Azure DevOps warnings regardless of command used.

please add logging to the publish command

It is still not working for build at version 2.247.1
  - task: DotNetCoreCLI@2
    displayName: dotnet build (*.sln)
    inputs:
      command: build
      projects: '*.sln'


Also apply refactoring to files not currently open in the editor

TextFileChange.LEAVE_DIRTY causes changes to files that are not currently open
in the editor to be silently ignored. TextFileChange.FORCE_SAVE seems more appropriate if the flag saveAfter is set anyway.
Fixes #1002079

It is interesting that this change fixes the problem. Unfortunately the fix is not so easy, the saveAfter was introduced by purpose: https://github.com/scala-ide/scala-ide/commit/44fbc5f73d

In the original discussion I even saw that problem: https://github.com/scala-ide/scala-ide/pull/653

It seems that the fix should be
setSaveMode(if (saveAfter) TextFileChange.FORCE_SAVE else TextFileChange.LEAVE_DIRTY)

But organize imports sets the saveAfter flag to true, which shouldn't be the case.

Yea, I feared that it couldn't be all that easy... here is a second try ;-).

By accident, you didn't find out why the refactoring isn't written to disk when the editor is left dirty? I guess the refactorings are performed, but only to the working copies, which we then might discard somehow.

Also, try to not reference a non merged commit hash in a commit message. If someone is doing a rebase, the hash is no longer valid.

As for the commit: Yea, I know - in that case I've to amend the commit... but I could also write 'the previous commit' - or merge them altogether.
As for finding why leaving files dirty causes changes to be lost: I guess it's in parts a conceptual problem. How should a file that is not opened in an editor be left dirty? In my opinion there are only two solutions:

Open an editor with the changed file that is marked as "dirty".
Silently discard the changes.

It seems that Eclipse took option 2.

As for Eclipse taking option 2: I think the relevant code that confirms this can be found here: org.eclipse.ltk.core.refactoring.TextFileChange.needsSaving()

Ok, thanks. That makes sense.

LGTM

Just in case you are interested to continue working on this, here is a follow-up ticket: https://www.assembla.com/spaces/scala-ide/tickets/1002427-restart-presentation-compiler-after-performed-rename-refactoring#/activity/ticket:


ISPN-11174 Fix RestMetricsResource test failure

https://issues.redhat.com/browse/ISPN-11174

testMicroprofileMetricsMetadata is still failing, but at least it is not attempting to create multiple servers anymore

Merged. Thanks @tristantarrant !

I've cherrypicked this to the 10.1.x port of the metrics PR also


Mocks added in before are preserved between quarantine runs

What is your Scenario?
I'm using testcafe runner API and I'm adding request mock in before
What is the Current behavior?
If test fails and quarantine mode is enabled next quarantine attempts use the initial request mock
What is the Expected behavior?
I'd expect mocks to be cleared between quarantine attempts
What is your public website URL? (or attach your complete example)
n/a
What is your TestCafe test code?
index.js
const createTestCafe = require('testcafe');

let runNumber = 0;

const config = {
    hooks: {
        test: {
            before: async (browser) => {
                const { RequestMock } = require('testcafe');
                const staticMock = RequestMock()
                    .onRequestTo('http://getrunnumber.invalid/static')
                    .respond(`<html><body><div id="runNumberStatic">${runNumber}</div></body></html>`, 200);
                const dynamicMock = RequestMock()
                    .onRequestTo(`http://getrunnumber.invalid/${runNumber}`)
                    .respond(`<html><body><div id="runNumber">${runNumber}</div></body></html>`, 200);
                runNumber++;
                await browser.addRequestHooks([staticMock, dynamicMock]);
            }
        }
    }
}

new Promise(async (resolve) => {
    const testcafe = await createTestCafe(config);
    const runner = testcafe.createRunner();
    await runner.src('test.js').browsers('chrome').run({ quarantineMode: true });
    resolve();
});

test.js
const { Selector } = require('testcafe');

fixture('test');

let expectedRunNumber = -1;
let shouldFail = true;

test('test', async (browser) => {
    ++expectedRunNumber;
    await browser.navigateTo(`http://getrunnumber.invalid/${expectedRunNumber}`);
    await browser.expect(Selector('#runNumber').exists).ok();
    const dynamicVal = await Selector('#runNumber').textContent;
    await browser.navigateTo('http://getrunnumber.invalid/static');
    await browser.expect(Selector('#runNumberStatic').exists).ok();
    const staticVal = await Selector('#runNumberStatic').textContent;
    console.log(`run: ${expectedRunNumber}, dynamic: ${dynamicVal}, static ${staticVal}`);
    await browser.expect(dynamicVal).eql(`${expectedRunNumber}`);
    await browser.expect(staticVal).eql(`${expectedRunNumber}`);
    if (shouldFail) {
        shouldFail = false;
        await browser.expect(false).ok();
    }
})

Your complete configuration file
No response
Your complete test report
node index.js
Running tests in:

Chrome 101.0.4951.64 / macOS 10.15.7

test
run: 0, dynamic: 0, static 0
run: 1, dynamic: 1, static 0
run: 2, dynamic: 2, static 0
✖ test

AssertionError: expected '0' to deeply equal '2'

expected - actual

-0
+2
Browser: Chrome 101.0.4951.64 / macOS 10.15.7
13 |    await browser.navigateTo('http://getrunnumber.invalid/static');
14 |    await browser.expect(Selector('#runNumberStatic').exists).ok();
15 |    const staticVal = await Selector('#runNumberStatic').textContent;
16 |    console.log(run: ${expectedRunNumber}, dynamic: ${dynamicVal}, static ${staticVal});
17 |    await browser.expect(dynamicVal).eql(${expectedRunNumber});

18 |    await browser.expect(staticVal).eql(${expectedRunNumber});
19 |    if (shouldFail) {
20 |        shouldFail = false;
21 |        await browser.expect(false).ok();
22 |    }
23 |})

at  (/Users/andrzej-kodify/projects/testcafe-before-request-hooks/test.js:18:37)
at asyncGeneratorStep (/Users/andrzej-kodify/projects/testcafe-before-request-hooks/test.js:1:114)
at _next (/Users/andrzej-kodify/projects/testcafe-before-request-hooks/test.js:1:452)

1/1 failed (1s)
Screenshots
No response
Steps to Reproduce

TestCafe version
1.18.6
Node.js version
v16.14.2
Command-line arguments
n/a
Browser name(s) and version(s)
No response
Platform(s) and version(s)
No response
Other
No response

Thanks for reply, I've used another workaround where URL contains test run ID, so it's unique per quarantine attempt (although removing mocks is probably better).
I just feel like the behaviour of keeping anything between test runs is inconsistent with the rest (as e.g. user session is cleared) so I wanted to point it out. Other than that all good, maybe worth adding this to documentation (if it's not there already)

Thanks for reply, I've used another workaround where URL contains test run ID, so it's unique per quarantine attempt (although removing mocks is probably better).

Thank you for sharing this workaround.

Other than that all good, maybe worth adding this to documentation (if it's not there already)

We will consider updating our documentation though we find this use case a very rare situation.


Create a Image gallery

Create a image gallery web

Hello Sir,
can you please assign me this issue.


Support for Janitza B-Series Smart meter

Add support for the Janitza B-Series. There are two variants of these devices: one supports MBUS, the other one MODBUS/RTU. The documentation can be found here:
German
English
The register documentation starts on page 72 (of the German document). The meter provides no THD measurements.
TODO:

[x] Install test device
[x] Verify RTU packet with simple test program
[x] Create a new scheduler for the device
[x] rewrite device configuration code

Preliminary support is implemented. I still need to check for inconsistencies and extend e.g. the sdm_detect program to include the Janitza meters.

The ABB B23 312-100 seems to be a similar device, but it uses different modbus function codes.

The Janitza meter performed flawlessly during the last 7-8 days. Since no problems are obvious this issue can be closed.


Add WAU winget informations

Proposed Changes
As WAU is now installable with an MSI, it is now also officially winget compatible. I have submitted the package to Microsoft:
https://github.com/microsoft/winget-pkgs/pull/182735
This PR adds informations on how to install WAU with winget and adds WAU to the default update exclusion list.
Related Issues

(Github link to related issues or pull requests)

Perfect. As you said as WAU is now in winget, we should hopefully be able to merge this :)

Just few things that looks better to me 😇

Done, hope that suits you.


json_stream.rb:24: warning: key :path is duplicated and overwritten on line 27

I'm getting this warning from twitter-stream-0.1.12:
json_stream.rb:24: warning: key :path is duplicated and overwritten on line 27
Turns out it's right; the value is definitely in the hash twice.
    DEFAULT_OPTIONS = {
      :method       => 'GET',
      :path         => '/',
      :content_type => "application/x-www-form-urlencoded",
      :content      => '',
      :path         => '/1/statuses/filter.json',
      :host         => 'stream.twitter.com',
      :port         => 80,
      :ssl          => false,
      :user_agent   => 'TwitterStream',
      :timeout      => 0,
      :proxy        => ENV['HTTP_PROXY'],
      :auth         => nil,
      :oauth        => {},
      :filters      => [],
      :params       => {},
    }

It's not a high-priority thing, of course.
Rails 4.2.8
Ruby 2.4.6
OSX 10.15.7

Ach! I see I'm a few versions behind. Never mind.


Added Detail view support

Added detail view support for actions.
In order to hide the action either on Index or Detail, you can add the methods in the action declaraction as per:
 ActionButton::make('My action')
                    ->action((new MyNovaAction())->onlyOnDetail(), $this->id)
                    ->icon('')
                    ->asToolbarButton(),

This is available for both action buttons and action button groups, and it works in individual actions which are part of the action group.
On Icon Actions, added the functionality of tooltip hovering over the icon to display the action name.
Couple of other things that i've discovered when using this package and are not added to the documentation:
in order to run actions without confirmation, you can add the $withoutConfirmation = true property to the Laravel Nova action or provide it as a method when you declare the action button
 ActionButton::make('My action')
                    ->action((new MyNovaAction())->withoutConfirmation(), $this->id)
                    ->icon('')
                    ->asToolbarButton(),

it is possible to set permissions for actions, by defining them in the actions() method at the Resource level
public function actions(NovaRequest $request)
    {
        return [
            (new MyNovaAction())
                ->canRun(function ($request) {
                    return false;
                }),
           ];
    }

Thank you for your improvements!

And sorry for commit in your branch -> pressed on the wrong button =)

No problem, I appreciate the fast response 🙏🏻


CSVs with indicators of all Cantons combined haven't been generated after 2022-04-12

Affected:

https://github.com/openZH/covid_19/blob/master/COVID19_Fallzahlen_CH_total_v2.csv
https://github.com/openZH/covid_19/tree/master/fallzahlen_kanton_total_csv

Measures taken:

manually run Validate CSV #8120
analysing issues

Issue:

https://github.com/openZH/covid_19/blob/master/fallzahlen_kanton_total_csv_v2/COVID19_Fallzahlen_Kanton_SO_total.csv

Analysis:

Error in Row 531: cumulative field ncumul_conf: 108915 < 109485

Measures taken:

Invalid value in Row 531 manually deleted
manually run Validate CSV #8121

Measures taken:

nanually run Run scrapers #44213

Will have a look soon-ish

@andreasamsler okay the most urgent problem is fixed now. The scraper can finally commit again and the combined CSV is generated and commited as well.
As you noticed, there are still some scrapers with errors, I will check them another time and see which of those can be fixed.

Many thanks @metaodi !
Further note:
Our initiative to adapt individual cantonal scrapers to ongoing changes to cantonal websites remains limited. Especially in cases where cantons do not provide data in a structured form.


HMR support

This one is no longer WIP. Basically, just adds a plug for the hmr runtime (which will be set on window._hmr just before commonjs require definition is evaluated)
cc @paulmillr


Do not close popup when click other extension button to close sidebar.

I'm not sure whether is it a desired behavior or not.

Popups should be closed when the user clicks anywhere else. If the click is to open/close any other sidebar or extension, the behaviour should be the same IMO.

I agree that we don't have a reason to change this behavior.


Add view encoding settings. Set utf-8 encoding as default

A fix @djanowski told me on IRC in order to handle utf8 characters in views without having to declare #encoding utf-8 every time.

Cool!
Two things:

Can we add a test?
I think there's no need to add an extra setting. We should simply honor Encoding.default_external.

Looks good to me!


Remove master branch

To delete the empty master branch:
git branch -d master;
git push origin :master;

Hi, didn't understand this?

The monospace text in grey background is Terminal commands to run inside the project repository's directory to delete the master branch locally, and then delete it from Github's servers.
However, there are now 4 branches in the repo, but ideally there should only be 1 main development branch. If you have trouble merging the branches so none are ahead of yours, I can help (perhaps via hangout)

@zeynepakay said offline,

The additional branches happened because something irrevocable happened to the file and I had to checkout a previous commit and continue on that branch.

So I will merge the branches taking care of this in my fork, and detail how I did it

The pr/3 branch doesn't have anything useful any more and can be deleted like this:
git checkout gh-pages ; # make sure you are on the gh-pages branch
git branch -D pr/3 ; # remove it from this local repo
git push origin :pr/3 ; # remove it on github.com servers repo

The master branch has just 2 commits not in the Rukiye branch, which from their commit messages seem to be mistakes. You can see the comparison of the two here:
https://github.com/zeynepakay/theruqahproject/compare/Rukiye...master
So again we can just remove that branch:
git checkout gh-pages ; # make sure you are on the gh-pages branch
git branch -D master ; # remove it from this local repo
git push origin :master ; # remove it on github.com servers repo

The Rukiye branch can be merged like this:
git checkout gh-pages ; # make sure you are on the gh-pages branch
git merge Rukiye; # merge that branch
git push; # push the merge to the github server
git branch -d Rukiye ; # remove it from this local repo
git push origin :Rukiye ; # remove it on github.com servers repo

Thanks!


fix(file-icon): ignore extension case

:tada: This PR is included in version 1.2.0-rc.34 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Easier integration of the Control Toolbox into build systems

Dear developer team,
I am using your Control Toolbox for path planning problems. Specifically, I include the toolbox as an external CMake project into my path planning software.
Usually, there should be a CMakeLists.txt in the root directory of a CMake project, but there is none, which is inconvenient. Also, there are a lot of sh-scripts in the ct/ directory which perform basic tasks like installing or building the code. These can be done by CMake itself, so I don't understand what's the prupose of these scripts.
I wanted to conveniently integrate the toolbox into my build system, so I created the fork which restructured the project to have a root CMakeList. This list adds the modules like optcon etc. as submodules.
Besides this, I changed the name of the project from CT to ControlToolbox and optcon to OptimalControl etc.. So, after using find_package(ControlToolbox REQUIRED) in my project, I can add its submodules by linking my target against ControlToolbox, ControlToolbox::OptimalControl and so on.
I renamed all headers which did not have an extension to end with .h, because there was a git bug which prevented these files from being cloned onto my disk.
Another thing is that I think that documentation, examples and predefined models should not be build by default as it slows down the automated build process while wasting disk space. Thats why I added options checking to the root CMakeLists, which check if -DBUILD_EXAMPLES, -DBUILD_DOCS and -DBUILD_MODELS are set.
The last thing I changed was that when QT is not found, then examples using a GUI are not being built as there will be a compile error anyway.
There is still alot to do to get rid of the scripts. For instance, it is possible to add dependencies as an external project in case find_package() could not find them. This will work on any machine, whereas your script uses apt which is only available on some linux systems. The best way to do this is described in the google test readme.
So, I hope that you can make use of my changes. I have to warn you thou, because I have no overview about all features you implemented in this project so I have not tested everything, for example if ROS is still working. I would be glad to hear about your opinion.

Dear @schulz0r
First of all thanks a lot for your interest in contributing to this open-source project, new improvements are always very welcome!
The pullrequest as it is presented here is quite extensive (more than 200 changed files). In the interest of helping us to provide high-quality reviews and feedback, do you think there would be the possiblity to transform it into smaller, self-contained, more reviewable pieces? Also, you should know that there is an active development effort going on in the background -- merging such large PRQ into the development repo will be very hard.

Usually, there should be a CMakeLists.txt in the root directory of a CMake project, but there is none, which is inconvenient. Also, there are a lot of sh-scripts in the ct/ directory which perform basic tasks like installing or building the code. These can be done by CMake itself, so I don't understand what's the prupose of these scripts.

Le me quickly comment on this. I agree that the default use of cmake assumes a structure where we have a single project. I have been considering combining all four CT domains (core, optcon, rbd and models) for quite a while. The main challenge is that we have a quite diverse user-base, of which roughly 50% are not interested in using (and therefore building and installing) the robotics features, i.e. ct_rbd and ct_models. If we would combine everything into one single project, what would be the most elegant way of ensuring that people not interested in ct_rbd and ct_models do not have to install them, alongside their additional dependencies such as kindr?

I wanted to conveniently integrate the toolbox into my build system, so I created the fork which restructured the project to have a root CMakeList. This list adds the modules like optcon etc. as submodules.

Would there be a way of keeping ct_core as a submodule, too? I still like the idea of having the code of core, optcon, etc. at equivalent hierarchical levels. The dependency graph is
core -- optcon -- rbd -- models
but what the new structure displays is
core
optcon -- rbd --models

Besides this, I changed the name of the project from CT to ControlToolbox and optcon to OptimalControl etc.. So, after using find_package(ControlToolbox REQUIRED) in my project, I can add its submodules by linking my target against ControlToolbox, ControlToolbox::OptimalControl and so on.

Why is this required? This is a feature which is not necessary to achieve compatibility and may even break existing code from our users when upgrading. From our perspective, we would prefer to stick with the old names.

I renamed all headers which did not have an extension to end with .h, because there was a git bug which prevented these files from being cloned onto my disk.

First of all, could we verify and document that the bug that you are mentioning is affecting all potential Mac users? If this is in broad-scale issue for OSX, we will need to change something in the CT, otherwise a local workaround should be sufficient. Nevertheless, having these collective (meta) headers like State, Common simply renamed to the same name plus a *.h extension would not be my first preference. Maybe we should think of a more expressive renaming in this case?

Another thing is that I think that documentation, examples and predefined models should not be build by default as it slows down the automated build process while wasting disk space.

They (documentation and examples) have never been build by default, this has always been optional on v3.0.2.
Thats why I added options checking to the root CMakeLists, which check if -DBUILD_EXAMPLES, -DBUILD_DOCS and -DBUILD_MODELS are set.

The last thing I changed was that when QT is not found, then examples using a GUI are not being built as there will be a compile error anyway.

Good point.

There is still alot to do to get rid of the scripts. For instance, it is possible to add dependencies as an external project in case find_package() could not find them. This will work on any machine, whereas your script uses apt which is only available on some linux systems. The best way to do this is described in the google test readme.

Quick question at this point, since I have not used this mechanism before: so it would be possible to only have the external project pulled and installed whenever find_package() returns false? I think, however, we will need some more detailed solution here. For example, we have quite a number of users who are not  allowed to install some of the dependencies, like CppAD-Codgen, hpipm or ipopt, for license reasons. So you see, there is a number of dependencies which should not simply be pulled automatically if find_package() is returns false.

So, I hope that you can make use of my changes. I have to warn you thou, because I have no overview about all features you implemented in this project so I have not tested everything, for example if ROS is still working. I would be glad to hear about your opinion.

Wrapping up, I am very interested in supporting you in introducing a cmake-integration which works for your operating system. However, we need to maintain strict compatibility with users of standard linux distributions like Ubuntu and Mint, as well as ROS build system users. I just pulled your fork to my Ubuntu 16.04 machine, cmake fails after a few seconds reporting
fatal error: Eigen/Dense: No such file or directory. Therefore, I think in some way or the other, we need to enable you to test your changes on Ubuntu and with catkin. Would you be willing to use a virtual machine with Ubuntu/ROS for testing your developments?
Thanks again, I do think that you are up to making a really cool contribution to the CT.  I hope that you are interested in investing more time to resolve some of the mentioned issues, it will certainly be appreciated by many users.

@schulz0r This is a lot of work here in your PR. There are definitely some useful things here and I actually understand some of your concerns as the Arch Linux maintainer of this codebase, (having to work around the shell scripts and nonstandard CMake structure)
As @markusgft has mentioned I believe the first course of action to do here would be to try to clean this PR up by breaking it into different pieces that target a specific issue/concern. I would create a issue for each issue/enhancement you have, and then create a PR with the commits that directly address that. This creates a trace down and a platform for proper discussion so that your changes can be easily reviewed/incorporated into the main source tree if deemed fit. This is a lot of work to digest and maintaining compatibility is important.
Many of the changes specified here will definitely be breaking and I would have to rewrite some of the build/package recipes for Arch Linux, although that shouldn't be a hassle. But it should only be done on a minor version change (if we are following semantic versioning).
Maybe you can get some useful feedback by looking at how I build and package control-toolbox for Arch Linux.
Essentially each core, opt_con, etc. is a separate package and there is one meta package that pulls all of them in. Here is the build scripts for one of them, you can find more by searching the AUR. I don't utilize the shell scripts at all, but rather just the individual CMakelists.txt in each project, and that works completely fine.
Personally I think that these changes are too drastic to just get control-toolbox to work with your build system and I feel that adapting your build system a little bit to the structure of control-toolbox might have been a better idea.
However there are some useful things here and the discussion sprouted from this is meaningful. I think let's first open targeted issues for each aspect of this PR and break this PR down to address each issue you open up. This will provide us a digestible format and a systematic way to move forward.
As always contributions are most welcome and thx for the work you have done, we just need to make sure one person's code doesn't break another one's, haha.
Also @markusgft

what would be the most elegant way of ensuring that people not interested in ct_rbd and ct_models do not have to install them, alongside their additional dependencies such as kindr?

We could accomplish this with build flags inside of the root CMakeLists.txt

Okay, that looks like there is still some work to do. I would invest some time to get the rework done, so we should start with easily agreeable changes like the missing .h extensions or bugs. I have experience with ROS and CI Pipelines (basics) so I know how to work with CMake in that regard.

If we would combine everything into one single project, what would be the most elegant way of ensuring that people not interested in ct_rbd and ct_models do not have to install them, alongside their additional dependencies such as kindr?

I think acxz already posted a good solution. Other than that, I did not combine everything in one single project, so I don't know if I get you right.

The dependency graph is core -- optcon -- rbd -- models but what the new structure displays is

core
optcon -- rbd --models

That's supposed to work better with CMake. CMake works with a top-down hierarchy and core is on the top. I has to be compiled no matter which additional submodules are desired. The core target is then passed down the hierarchy to optional modules. Before, all modules were on the same hierarchy level so you would have to create interdependencies between modules. CMake can do this, but why putting in the effort?

A *.h extension would not be my first preference.

Why thou? This is what you expect a header to look like when working with C/C++.

Quick question at this point, since I have not used this mechanism before: so it would be possible to only have the external project pulled and installed whenever find_package() returns false?
You don't need to install external projects. I never do this because it requires privileged access.
You can simply pull the external project and compile it during configuration or simply add it to the project. Also, packages which need a license should not automatically be added to the project. From what I've seen, it is possible to compile the library without dependencies like CppAD-Codgen. For the other dependencies which provide the basic functionality of the toolbox, see this excerpt of one of my CMake files:

find_package(Eigen3 3.3.9 QUIET NO_MODULE)

if((NOT ${Eigen3_FOUND}) AND (NOT TARGET Eigen3-download))
    # Download and unpack eigen3 at configure time
	configure_file(CMakeLists-Eigen3.txt.in Eigen3-download/CMakeLists.txt)
	execute_process(COMMAND ${CMAKE_COMMAND} -G "${CMAKE_GENERATOR}" -DBUILD_TESTING=OFF .
	  RESULT_VARIABLE result
	  WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/Eigen3-download )
	if(result)
	  message(FATAL_ERROR "CMake step for Eigen3 failed: ${result}")
	endif()
	execute_process(COMMAND ${CMAKE_COMMAND} --build .
	  RESULT_VARIABLE result
	  WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/Eigen3-download )
	if(result)
	  message(FATAL_ERROR "Build step for Eigen3 in commandmodel failed: ${result}")
	endif()

	add_subdirectory(${CMAKE_CURRENT_BINARY_DIR}/Eigen3-src
	${CMAKE_CURRENT_BINARY_DIR}/Eigen3-build
	  EXCLUDE_FROM_ALL)
endif()

if(TARGET Eigen3)
    add_dependencies(${PROJECT_NAME} Eigen3_download)
endif()

target_link_libraries(${PROJECT_NAME} PRIVATE Eigen3::Eigen)

CMakeLists-Eigen3.txt.in looks like this:
cmake_minimum_required(VERSION 3.10)

project(Eigen3-download NONE)

include(ExternalProject)
ExternalProject_Add(Eigen3
    GIT_REPOSITORY    https://gitlab.com/libeigen/eigen.git
    SOURCE_DIR        "${CMAKE_CURRENT_BINARY_DIR}/Eigen3-src"
    BINARY_DIR	      "${CMAKE_CURRENT_BINARY_DIR}/Eigen3-build"
    BUILD_COMMAND     ""
    GIT_PROGRESS      On
    UPDATE_COMMAND    ""
    CONFIGURE_COMMAND ""
    INSTALL_COMMAND   ""
    TEST_COMMAND      ""
)

That Eigen3 was missing at your first attempt to compile this is because I did not implement above code yet, I just mentioned that it is possible to get rid of the dependency installation script.
@acxz I don't know about packaging for arch linux, but I usually use CPack to create linux packages, which also has a CMake integration. That's how packaging can be automated very easily. Creating packages for each submodule should be easily done with a cpack command for each submodule as soon as the CMakeList contains the package information. I can look into that if you want.
In conclusion, I think all problems which have been addressed here can be solved with medium effort, so let me hear where to start.

CPack to create linux packages

I'm not that familiar with CPack but I don't think it works well with Arch Linux packages so that won't be a solution for me.

let me hear where to start

From our comments:

do you think there would be the possiblity to transform it into smaller, self-contained, more reviewable pieces?

and

create a issue for each issue/enhancement you have, and then create a PR with the commits that directly address that

Please start with those suggestions

Okay, the PR will be closed and I will try again.


fixed for parallel build, largefile build, parallel szip build

Part of #1639
Fixes #1652
Fixes #1653
This fixes compiles of parallel builds.
Also update the documentation for nc_var_par_access() to describe collective vs. independent access with respect to filters.

I will take this down to make sure #1654 first merges with no conflicts.


Callbacks not being called on filterscripts

So I've this gamemode code:
public FCNPC_OnInit()
{
    // Connect all npcs
    for(new i = 0; i < MAX_NPC; i++)
    {
        new name[MAX_PLAYER_NAME];
        format(name, sizeof(name), "npc_%i", MAX_PLAYERS - 1 - i);
        FCNPC_Create(name);
    }
}

public FCNPC_OnCreate(npcid)
{
    FCNPC_SetHealth(npcid, 100.0);
    FCNPC_Spawn(npcid, 3, 0.0, 0.0, 3.0);
    return 1;
}

And this filterscript code:
public OnFilterScriptInit()
{
    for(new i = MAX_PLAYERS - MAX_NPC; i < MAX_PLAYERS; i++)
    {
        FCNPC_Respawn(i);
    }
    return 1;
}

public FCNPC_OnRespawn(npcid) // Its never called
{
    print("Respawn");
    return 1;
}

For some reason, FCNPC_OnRespawn is not being called in my filterscript. I've to mention that I load it 1s after OnGameModeInit, at that point NPCs are created and first spawned. FCNPC_OnRespawn works fine in gamemode tho

I just fixed it by defering bot spawn
public OnFilterScriptInit()
{
    SetTimer("FCNPC_RespawnAll", 1000, false);
    return 1;
}

forward FCNPC_RespawnAll();
public FCNPC_RespawnAll()
{
    for(new i = MAX_PLAYERS - MAX_NPC; i < MAX_PLAYERS; i++)
    {
        FCNPC_Respawn(i);
    }
    return 1;
}

Now FCNPC_OnRespawn is being called normally

You should use FCNPC_OnInit instead of OnFilterScriptInit in filterscripts too.

I thought FCNPC_OnInit was called only once (after plugin load). It works fine now, thanks!


collect tcp memory information under cg1

The statistics of tcp memory are missing under cg1, we need to make up.
Reference statistics:
tcp memory limit: memory.kmem.tcp.limit_in_bytes
tcp memory usage: memory.kmem.tcp.usage_in_bytes
Reference link:
https://github.com/torvalds/linux/blob/v6.4/Documentation/admin-guide/cgroup-v1/memory.rst?plain=1#L102
What type of PR is this?

What this PR does / why we need it:
The statistics of tcp memory are missing under cg1, we need to make up.
Reference statistics:
tcp memory limit: memory.kmem.tcp.limit_in_bytes
tcp memory usage: memory.kmem.tcp.usage_in_bytes
Reference link:
https://github.com/torvalds/linux/blob/v6.4/Documentation/admin-guide/cgroup-v1/memory.rst?plain=1#L102
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Robin Lu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @csfldf @waynepeking348
Any comments?

Hi @csfldf @waynepeking348 Any comments?

why we need this in katalyst?


question(1.x): what if components took module names

as an analogy to ng-app

I don't want this for now. It might make more sense after 1.x has better support for lazy-loading. Closing for now.


docker compose ps --format=json no longer returns an Array of JSON Objects

Describe the bug
In a previous version of Orbstack docker compose ps --format=json would return an Array of JSON Objects (i.e. [{...}, {...}, ...]. In the last few versions, it has changed to being JSON Lines (i.e. {} \n {} \n ...).
This breaks scripts depending on the Array and makes migrating from Docker Desktop to Orbstack require changing some scripts.
To Reproduce
Use the JSON format for various options.
docker compose ps --format=json

Expected behavior
No response
Diagnostic report (required)
OrbStack info:
Version: 0.17.3
Commit: de7357ad84f24bcb339f374c06775d1cad14564e (v0.17.3)
System info:
macOS: 13.5.2 (22G91)
CPU: arm64, 10 cores
CPU model: Apple M1 Pro
Model: MacBookPro18,1
Memory: 32 GiB
Full report: https://orbstack.dev/_admin/diag/orbstack-diagreport_2023-09-20T00-52-58.544057Z.zip

Screenshots and additional context (optional)
If this breaking change is intentional, please let me know!

This was an intentional change in upstream Docker Compose: https://github.com/docker/compose/releases/tag/v2.21.0

Makes sense. Thank you for the clarification!


[Bug]: Could not read from remote repository

Is there an existing issue for this?

[X] I have searched the existing issues

Description
After upgrading to v2.9.0, applications from GitLab can not be cloned due to a missing public SSH key.

Warning: Permanently added 'gitlab.com' (ED25519) to the list of known hosts.

<EMAIL_ADDRESS>Permission denied (publickey).

fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

The SSH key registered in GitLab is the same as the one available from the endpoint /applications/{applicationId}/configuration/sshkey.json.
I did not find any logs helping me identify the origin of the bug. I would be glad to send a PR if you have any pointers on how to debug this issue.
Steps To Reproduce
On a privately deployed version of Coolify upgraded from 2.8.x to 2.9.x, rebuild and deploy an existing application.
Version
2.9.3

Thanks for the issue!
I'm reverting to my last change for the git cloning process.
The new version will be available soon.


Some buttons are not clickable.

When the offset of flet.Container and the scale property of its content are set, some buttons in the content are not clickable.
Code example to reproduce the issue:
import flet

def main(page: flet.Page):
    page.add(
        flet.Container(
            width = 300, height = 300,
            alignment = flet.alignment.center,
            content = flet.Column(
                alignment = flet.MainAxisAlignment.CENTER,
                controls = [
                    flet.ElevatedButton(text="Elevated button 1"),
                    flet.ElevatedButton(text="Elevated button 2"),
                    flet.ElevatedButton(text="Elevated button 3"),
                    flet.ElevatedButton(text="Elevated button 4"),
                    flet.ElevatedButton(text="Elevated button 5"),
                    flet.ElevatedButton(text="Elevated button 6"),
                ]
            )
        )
    )

def main2(page: flet.Page):
    page.add(
        flet.Container(
            width = 300, height = 300,
            scale = 2,
            offset = flet.transform.Offset(0.5, 0.5),
            alignment = flet.alignment.center,
            content = flet.Column(
                alignment = flet.MainAxisAlignment.CENTER,
                controls = [
                    flet.ElevatedButton(text="Elevated button 1"),
                    flet.ElevatedButton(text="Elevated button 2"),
                    flet.ElevatedButton(text="Elevated button 3"),
                    flet.ElevatedButton(text="Elevated button 4"),
                    flet.ElevatedButton(text="Elevated button 5"),
                    flet.ElevatedButton(text="Elevated button 6")
                ]
            )
        )
    )

def main3(page: flet.Page):
    page.add(
        flet.Container(
            width = 300, height = 300,
            offset = flet.transform.Offset(0.5, 0.5),
            alignment = flet.alignment.center,
            content = flet.Column(
                scale = 2,
                alignment = flet.MainAxisAlignment.CENTER,
                controls = [
                    flet.ElevatedButton(text="Elevated button 1"),
                    flet.ElevatedButton(text="Elevated button 2"),
                    flet.ElevatedButton(text="Elevated button 3"),
                    flet.ElevatedButton(text="Elevated button 4"),
                    flet.ElevatedButton(text="Elevated button 5"),
                    flet.ElevatedButton(text="Elevated button 6")
                ]
            )
        )
    )

flet.app(target = main) # works
flet.app(target = main2) # works
flet.app(target = main3) # the first button is not clickable

Flet version (pip show flet):
Name: flet
Version: 0.4.2
Summary: Flet for Python - easily build interactive multi-platform apps in Python
Home-page:
Author: Appveyor Systems Inc.
Author-email<EMAIL_ADDRESS>License: Apache-2.0
Location: C:\Program Files\Python311\Lib\site-packages
Requires: flet-core, httpx, oauthlib, packaging, watchdog, websocket-client, websockets
Required-by:

Operating system: Windows 11

I believe that a button must have an on_click event to accept a mouse click.

As far as I can tell, the OP is referring to the button not giving visual feedback on hover and click. I just tested it with a simple on_click callback and that didn't get called either, so the wording is right: the buttons (the 6th button was affected as well for me) are not clickable in this scenario.
This is most probably due to the button column being scaled to such an extent that it doesn't fit into its  fixed-size container anymore. Since that container constitutes the window in which click and hover inputs can be linked to the contained controls, the 1st and 6th button are out of reach.
To some extent, this is a usage error. If feasible though, there should be some logic in Container that checks if the user is trying to add a control to it that it can't display correctly given its constraints.

Just prepared a medium-sized PR to prevent this and then realized that Container has a clip_behavior property. If one sets it to anything other than the default (ClipBehavior.NONE), the problem becomes apparent as the buttons are visibly cut off. @FeodorFitsner, would you prefer to:
A) see my PR which adds a dimensions property to ConstrainedControl, calculates the usable window of a container and raises a custom DimensionsError if the content dimensions exceed it.
B) set the default clip_behavior to something other than ClipBehavior.NONE, perhaps ClipBehavior.HARD_EDGE. This would make it obvious what went wrong.
C) don't change anything in the code and trust that users will understand what they have done wrong if they stumble upon this or add a note in the Container docs about this scenario.

Are there any updates on this?
I think this is also related with my problem (see code example)
flet.DataTable(
    columns=columns,
    rows=rows,
    show_bottom_border=True,
    heading_row_height=0,
    scale=flet.Scale(scale_x=6 / len(columns), alignment=flet.alignment.top_left)
    if len(columns) > 6
    else 1.0,
)

Results in a visible table which is rendered correcntly but not all elements are clickable.

Upstream issues: https://github.com/flutter/flutter/issues/27587, https://github.com/flutter/flutter/issues/75747


Ignore error during gateway init if folders already exist in volume

Proposed changes
The gateway initContainer fails when creating folders on the config volume, if they already exist:
mkdir: can't create directory '/etc/nginx/conf.d': File exists
mkdir: can't create directory '/etc/nginx/secrets': File exists

This failure prevents the gateway from starting. This PR adds a mkdir flag to ignore the error and skip folder creation if the folders already exist.
Checklist
Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING doc
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that all unit tests pass after adding my changes
[ ] I have updated necessary documentation
[x] I have rebased my branch onto main
[x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

This fix resolved the error in my environment, but I'm not sure what tests are required to validate it

@pl4nty thanks for the PR!
Instead of adding -p flag to the mkdir commands, can you clear out or remove the directories before creating them? I'd like to avoid having out-of-date or invalid configs in these directories after a restart.

Thanks @kate-osborn, how's this? Just removes the stale config if present. I've tested successfully on my dev cluster

Thanks @kate-osborn, how's this? Just removes the stale config if present. I've tested successfully on my dev cluster

LGTM!

@pl4nty the commit history on this PR has several commits from the main branch which is making the diff incorrect. Can you do an interactive rebase on main and squash all the commits into a single commit? That should fix the diff. Thanks!

@kate-osborn apologies, I was away for a while. Thanks for your patience!


429 rate limit of 1 request per minute

I switched to the latest docker image and started to see the 429 error code, when crawl4ai is saying rate limit of request is 1 per minute. However, such rate limit wasn't there when I build from source from earlier versions.
Question:

Is this 1 request / minute rate limit from docker host a must for the program to perform?
If not, how do i modify this rate limit when using docker?
Much appreciated!

I suggest you go to the root of the projects and edit the main.py file. There, you will see that we applied the rate limit in different ways. If you see some variables, we read from environment variables like ACCESS_PER_MIN and ACCESS_TIME_SPAN, and they control this kind of limit. However, you can disable them, or a better way is to look at it, as we already accept an access token. So, you can set your own access token, then set the access token in your environment variable. And whenever you pass the access token, all these limits will be disabled. That's your choice. Nevertheless, where you can do that is in the main file. Let me know if you encounter any difficulties, and I will be happy to help you.

thanks unclecode, just wasn't sure where you put the rate limit params. i can take it from here. btw great job for the async update, was gonna ask for it. you are on fire!

@monkeybiz55 Thank you so much and for your nice words. I'm glad to know that it was helpful. Let me know if you need any help for this rate limit. Happy crawling


Support new key event implementation of Opera

This issue was imported from Closure Library's previous home at http://closure-library.googlecode.com
The link to the original issue is:
https://code.google.com/p/closure-library/issues/detail?id=428

This issue is being closed as a preparation step before archiving the repository.  See the README for more detail.


Update datetime inputs

See #87
Changes

Update nsw-design-system to 3.16.0 to support date inputs component
Add templates for nswdpc/silverstripe-datetime-inputs fields with nswds classes
Apply override CSS to ensure fields take up container width, for consistency
Set version upper boundary  for nswdpc/silverstripe-datetime-inputs requirement

Please review #87 @tardinha


⚠ Bofrost.es has degraded performance

In e780cd8, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1695 ms

Resolved: Bofrost.es performance has improved in af2255e.