Android support?

Tested out the WebRTC, which works great with low latency on Desktop. How ever, on an Android device on the same local network the video will not load. Not sure if this is a valid ticket here or not, this was the only place I could think of to post a question. Is it possible, and if so, how to enable Android support?

I've never tested it on android, but I don't see why it wouldn't work as long as client app supports webrtc streams
i know chrome for android supports webrtc, but no idea about the rest, so check whats the client app capability

Yeah, I agree! I tried my best to search for this to figure out what this could be, not successful so far. Tested on multiple devices, none work, default Android chrome browser. Might just have to make two different versions of my stream, one for Android, and one for Desktop ;) Thanks for the reply!

If you attach dev tools to chrome on android, what does console log show?

From what I can find: const data = res && res.ok ? await res.text() : ''; the res.text() returns an empty string. The rest of the request seems fine to me. The data sent into the body of the stream/reciever might be of interest, and it reads as follows:
v=0
o=-<PHONE_NUMBER>820665317 2 IN IP4 <IP_ADDRESS>
s=-
t=0 0
a=group:BUNDLE 0 1
a=extmap-allow-mixed
a=msid-semantic: WMS
m=video 9 UDP/TLS/RTP/SAVPF 96 97 98 99 124 101 102
c=IN IP4 <IP_ADDRESS>
a=rtcp:9 IN IP4 <IP_ADDRESS>
a=ice-ufrag:FFxD
a=ice-pwd:OeeklTfLR2Xlimd32aW5bmr3
a=ice-options:trickle
a=fingerprint:sha-256 B7:BF:7B:B0:00:F2:46:83:30:F6:21:34:F5:86:7E:60:5C:CE:32:08:89:1C:EC:6E:E4:AF:7D:3B:B2:B8:CF:F5
a=setup:actpass
a=mid:0
a=extmap:1 urn:ietf:params:rtp-hdrext:toffset
a=extmap:2 http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time
a=extmap:3 urn:3gpp:video-orientation
a=extmap:4 http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01
a=extmap:5 http://www.webrtc.org/experiments/rtp-hdrext/playout-delay
a=extmap:6 http://www.webrtc.org/experiments/rtp-hdrext/video-content-type
a=extmap:7 http://www.webrtc.org/experiments/rtp-hdrext/video-timing
a=extmap:8 http://www.webrtc.org/experiments/rtp-hdrext/color-space
a=extmap:9 urn:ietf:params:rtp-hdrext:sdes:mid
a=extmap:10 urn:ietf:params:rtp-hdrext:sdes:rtp-stream-id
a=extmap:11 urn:ietf:params:rtp-hdrext:sdes:repaired-rtp-stream-id
a=sendrecv
a=msid:- 60f9d419-9ded-4e82-884e-5a47c908b766
a=rtcp-mux
a=rtcp-rsize
a=rtpmap:96 VP8/90000
a=rtcp-fb:96 goog-remb
a=rtcp-fb:96 transport-cc
a=rtcp-fb:96 ccm fir
a=rtcp-fb:96 nack
a=rtcp-fb:96 nack pli
a=rtpmap:97 rtx/90000
a=fmtp:97 apt=96
a=rtpmap:98 VP9/90000
a=rtcp-fb:98 goog-remb
a=rtcp-fb:98 transport-cc
a=rtcp-fb:98 ccm fir
a=rtcp-fb:98 nack
a=rtcp-fb:98 nack pli
a=fmtp:98 profile-id=0
a=rtpmap:99 rtx/90000
a=fmtp:99 apt=98
a=rtpmap:124 red/90000
a=rtpmap:101 rtx/90000
a=fmtp:101 apt=124
a=rtpmap:102 ulpfec/90000
a=ssrc-group:FID<PHONE_NUMBER><PHONE_NUMBER>
a=ssrc:2962500185 cname:EdhGA6DMzdZtENE2
a=ssrc:2962500185 msid:- 60f9d419-9ded-4e82-884e-5a47c908b766
a=ssrc:2962500185 mslabel:-
a=ssrc:2962500185 label:60f9d419-9ded-4e82-884e-5a47c908b766
a=ssrc:3763020948 cname:EdhGA6DMzdZtENE2
a=ssrc:3763020948 msid:- 60f9d419-9ded-4e82-884e-5a47c908b766
a=ssrc:3763020948 mslabel:-
a=ssrc:3763020948 label:60f9d419-9ded-4e82-884e-5a47c908b766
m=application 9 UDP/DTLS/SCTP webrtc-datachannel
c=IN IP4 <IP_ADDRESS>
a=ice-ufrag:FFxD
a=ice-pwd:OeeklTfLR2Xlimd32aW5bmr3
a=ice-options:trickle
a=fingerprint:sha-256 B7:BF:7B:B0:00:F2:46:83:30:F6:21:34:F5:86:7E:60:5C:CE:32:08:89:1C:EC:6E:E4:AF:7D:3B:B2:B8:CF:F5
a=setup:actpass
a=mid:1
a=sctp-port:5000
a=max-message-size:262144

I got hold of a more expensive (but older) Android device now, and there it works good. So, it might be a problem with cheap Android devices? The debug comes from a Moto G20

From what I can find: const data = res && res.ok ? await res.text() : ''; the res.text() returns an empty string.

That part has nothing to do with client capabilities, that's a simple request to WebRTC server to get stream info that will be used to create WebRTC client connection. No chance that result can be different between desktop and mobile.

I got hold of a more expensive (but older) Android device now, and there it works good. So, it might be a problem with cheap Android devices? The debug comes from a Moto G20

No idea.
I just tried on my old S10+ and new S21 Ultra and it works fine, I don't have any other devices available.

Checked the log from the server, which reads:
WriteHeader unable to start track, codec is not supported by remote
Does that mean that WebRTC is not supported in general, or does it mean that there is another codec that could be chosen instead?

Ahh, that's starting to make sense (a little bit)...
WebRTC is a transport while the stream itself can be encoded in any number of codecs (most commonly AVC variation of H.264, but there is no rule it that it has to be). So client needs to understand a) how to negotiate WebRTC, b) how to actually decode a stream.
Now, in case of Chrome, it has a wide codec support, but it will internally disable codecs that it thinks it cannot reliably run because platform itself does not have sufficient HW acceleration so experience is smooth.
So on "better" HW, everything just works while on lower end hardware Chrome does initial WebRTC handshake, but then responds with "codec is not supported". Only solution for that would be to run re-encoding of the stream on server-side, but that is quite resource intensive and beyond the scope of what I have.

Ah, yes this makes sense! Thank you so much for investing time into this :) If someone else stumble on to this issue, I guess possible fixes include re-encoding as described above, or maybe check if data is an empty string, and then redirect to alternative stream. I will probably choose to just not support those devices as it is not important enough for current smart home project.

Glad we've figured it out, although it's not exactly a wrapped-up solution :)


Add missing parameter to getTransactions

Adds the limit parameter to getTransactions, which gives the limit of how many transactions should be shown (important because the RPC get_transactions only shows 50 by default).
Also, I was wondering if you ran the Chia Explorer or knew who did, since I have a very simple feature suggestion for the explorer (has to do with an improvement to the miscellaneous transaction label) and haven't found any contact information on the website. Thanks!

Thanks for the contribution. Yep, I run Chia Explorer. You can contact me at<EMAIL_ADDRESS>:)

Thanks for merging! I sent an email from<EMAIL_ADDRESS>


Avoid private APIs from azure.storage

[ ] https://github.com/fsspec/adlfs/blob/4b704b1a5f39ec2350a8be44d9cb117aee9b1719/adlfs/spec.py#L25
[ ] https://github.com/fsspec/adlfs/blob/4b704b1a5f39ec2350a8be44d9cb117aee9b1719/adlfs/spec.py#L26
[ ] https://github.com/fsspec/adlfs/blob/4b704b1a5f39ec2350a8be44d9cb117aee9b1719/adlfs/spec.py#L28

Just to help out a little, BlobBlock, BlobProperties, BlobType, and BlobPrefix are all exported from the main SDK so should all be able to be imported directly from azure-storage-blob.
create_configuration is not exported and is not really recommended to be used, especially just to get the default block size. Unfortunately, we (the SDK team) don't really have an export for our default block size at this moment, but it is 4 MiB (4 * 1024 * 1024) and not likely to change anytime soon so you could consider just hardcoding it. If you really think you want that constant exported, feel free to open an issue to the SDK and we can consider adding it (but may ultimately decide not to).

create_configuration probably needs a bit of discussion, but I'd be down to put in a PR for this to help get it fixed. It should just be a drop in replacement on the imports and then a quick check that no tests are broken.


something happened to the repository - older revisions lost

Compare the mirror repo https://github.com/kabel/vscode_cobol with 1,268 commits with this one, which had the same amount two days ago and now only 11 commits.
Maybe some force-push has gone wrong?

No, The branch names have been moved from master to main & gc'ed

What is "gc'ed"?

If it's possible I highly suggest to get the old commits back to the "main" branch (possibly as new "master" branch?), the old > 1200  commits also showed some maturity :-) The last tag with the old commits was 6.10.3.

Just a ping @spgennard to tell if this repo may get the old commits "back" or not (and close the issue before the bot does it).


[fix] Updated @yojji/core in examples/todo-list and changed start script

@klykho r u sure code style is good and linters haven't warnings?


[dev-scripts] Upstream some scripts for producing scurves from csv files and graphing.

These are two small scripts that can be used to output scurves to show performance data. SCurves are a technique used to show how an optimization effects a set of tests in a way that makes it easy to visualize the % of the tests that have improved or degraded. For instance based off of some code-size work I did recently, this is the output from these scripts used together:

Notice how one can really easily tell that 5% of the benchmarks reduced in code-size by 10% and that we do not have any regressions really.
I am upstreaming this b/c @atrick and others have asked me how I produce these (which I used to do by hand). Rather than doing it by hand, I scripted this so I can forget how to do this and hopefully make people's lives easier.

@atrick a gift for you. = ).

@swift-ci smoke test

@swift-ci python lint

should have linted first...

@gottesmm cool. I love these graphs. As long as people label the Y axis "time" or "speed" appropriately.

@atrick this is just computing % change, so I am not sure if it is relevant? That would happen before. That being said, I am happy to provide both of those as an option to put on the y-axis. Maybe that with an explanation will make people think about what they are doing more.

@swift-ci python lint

@swift-ci python lint

@atrick Also, I don't take any credit for knowing about them. I think I learned how to make them from @stephentyrone actually. Many many years ago... but maybe my memory is wrong.

@swift-ci python lint

@gottesmm Could be! (Anyway we can get log-scale y-axis?)

of course!

@swift-ci python lint

@swift-ci python lint

@swift-ci python lint

@stephentyrone I was unable to get the log scale to work how I wanted it to. = (. I am out of time messing with this (I need to move on). I'll swing around at some point. Can you file an SR for that?

@swift-ci python lint

@swift-ci python lint

@swift-ci python lint

@swift-ci python lint

@swift-ci python lint

@swift-ci python lint

@swift-ci python lint

@swift-ci python lint

@swift-ci smoke test and merge

@swift-ci smoke test and merge

@swift-ci smoke test and merge


Maverick readme

Updates README to be more in line with Maverick.
Here is a more readable version of the README.

:tada: This PR is included in version 7.15.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 8.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


HTML

HTML
User Story
As a boot camp student,
I want a Prework Study Guide website,
so that I can review all the information I learned throughout Prework.
##Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, Git, and JavaScript with associated notes listed
WHEN I view the study guide
THEN I see a dark blue header and footer, and four boxes with a shadow
WHEN I open the console in my browser
THEN I can see the four topics I learned listed along with a suggestion on what I should study first
WHEN I visit the website using the URL
THEN I can access my website from any browser

Completed the tasks in module 3.1.6.
Now looking at this acceptance criteria, I think I copied and pasted the CSS requirements? ¯_(ツ)_/¯


Add support for  Moroccan Amazigh language (ZGH),

Adding support for the Moroccan Amazigh language (ZGH), with the Tifinagh script. See ( IRCAM website )
see https://github.com/tesseract-ocr/langdata/pull/87#issuecomment-324001533

any update??


Allow expect to request non-incremental frame buffer update

Closes #141
Signed-off-by: Hosgor, Tolga (CT RDA DS EU TR MTS<EMAIL_ADDRESS>

https://github.com/sibson/vncdotool/pull/142 is a partial duplicate of this pr.


Inconsistencies in type parameter error messages: type 'arguments' vs 'parameters'

Bug Report
🔎 Search Terms
generic type argument parameter error consistency
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about generics

⏯ Playground Link
Playground link with relevant code
💻 Code
function inTheEnd<First = number, Second>() {}
//                             // ~~~~~~
// Error: Required type arguments may not follow optional type arguments.

🙁 Actual behavior
The error refers to Second as a type argument.
🙂 Expected behavior
The AST node type is Parameter. The error message should refer to it as such, I think.
https://www.typescriptlang.org/docs/handbook/2/generics.html also generally refers to the declaration sites as parameters and to provided types as arguments.

Yes, in general a parameter is a variable, an argument is the value the caller provides for that variable.

Hmm, looks like this has since been fixed in TypeScript. Darn - I was hoping to contribute this 😄.
I took a peek through diagnostic messages that mention type (argument|parameter) and didn't spot any that seemed immediately wrong. If anybody spots one, I'd be happy to send a PR to fix.


Workaround for server message drop issue by reconnecting

This is to workaround the message drop issue from dxhub server.
Apparently, when we will get a consume timeout, the subsequent consume will skip a message because it counts as a confirmation of the last message.
The workaround is to disconnect, reconnect and reuse the same subscription ID to continue.
The fix mark the connection as ConsumeTimeout and while the App object receives an error from connection, it will check if it is caused by ConsumeTimeout. If so, it will trigger another app.connect.
It was tested successfully by triggering traffic in ISE and observe with dx-ws-consumer app to ensure all messages were accounted for.

Is it possible to handle this within the pubsub package itself and not expose it to rest of the SDK?

Is it possible to handle this within the pubsub package itself and not expose it to the rest of the SDK?

I haven't thought about it. But I think it is possible. Just a bit more work to wrap a layer around the connection code. Let me give it a try.


fix: update envinfo + implementation, update issue_template

This PR fixes a few outstanding issues, and supersedes https://github.com/facebook/create-react-app/pull/3859 and https://github.com/facebook/create-react-app/pull/3797.
There were a couple issues with envinfo, and the issue template that never got resolved - this is my attempt to fix all of that. Also, envinfo has been rewritten for size and speed since originally integrated, and a few more features have been added. The command is the same create-react-app --info, but now returns more info, like this:
  System:
    OS: macOS High Sierra 10.13
    CPU: x64 Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
  Binaries:
    Node: 8.11.0 - ~/.nvm/versions/node/v8.11.0/bin/node
    Yarn: 1.5.1 - ~/.yarn/bin/yarn
    npm: 5.6.0 - ~/.nvm/versions/node/v8.11.0/bin/npm
  Browsers:
    Chrome: 65.0.3325.181
    Firefox: 59.0.2
    Safari: 11.0
  npmPackages:
    react: ^16.3.2 => 16.3.2
    react-dom: ^16.3.2 => 16.3.2
    react-scripts: 1.1.4 => 1.1.4
  npmGlobalPackages:
    create-react-app: 1.5.2

Since you no longer recommend installing CRA (using via npx instead), also adding npx envinfo --preset create-react-app might be a faster option. envinfo is extremely light and fast via npx, and can be locked to a specific version - npx<EMAIL_ADDRESS>--preset create-react-app, or just installed directly yarn global add envinfo && envinfo --preset create-react-app in the case of pre npm 5.2 installs. I can add this to the template upon request.
@bondz This may interest you.

This looks great. Thanks!

I'm really not sure what's going on with ci - the only dep change should be envinfo, which doesn't use babel-loader, anywhere in the dependency tree.
npx envinfo --npmPackages babel-loader --fullTree --showNotFound
  npmPackages:
    babel-loader: Not Found

We've been having issues with node 6 tests on Travis recently but this looks like something else. And the same failure is happening on Appveyor. I'll re-trigger the tests on Travis and see what happens.

I have no idea why the tests keep failing. I wonder if it's because you're targeting master instead of next? Everything is going into next right now and I think this should too. We're not planning to release any new 1.x versions unless we absolutely have to. Can you update your PR and change the base branch to next?

Well that sure didn't work. We've lost Travis entirely and Appveyor thinks the changes are unmergeable. 😞
I'd like to avoid having you create a new PR but I'm not really sure what else to do at this point. @Timer @gaearon any suggestions?

Happy to make a new PR if that helps.
On Sat, Apr 28, 2018 at 4:27 PM Ian Sutherland<EMAIL_ADDRESS>wrote:

Well that sure didn't work. We've lost Travis entirely and Appveyor thinks
the changes are unmergeable. 😞
I'd like to avoid having you create a new PR but I'm not really sure what
else to do at this point. @Timer https://github.com/Timer @gaearon
https://github.com/gaearon any suggestions?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/facebook/create-react-app/pull/4375#issuecomment-385203260,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACyh-K67oLhwWxDVwgesyyEMeAEl1tnqks5ttNCugaJpZM4Tq5dX
.

Thanks!

Thanks to @bondz for his prior PR and review 🎉
Also, thanks @iansu for your help and review 👍


Performance not improving when using CuDNN?

Flash attention shows CuDNN outperforms FlashAttention2.
But, I'm getting roughly similar performance with flash attention 2 and transformer engine with the CuDNN backend. Here's my benchmarking script:
from flash_attn.utils.benchmark import benchmark_forward, benchmark_backward
from flash_attn import (
    flash_attn_varlen_qkvpacked_func
)
from einops import rearrange
import numpy as np
import torch
import transformer_engine.pytorch as te

import os
# CudNN Graph api
os.environ["NVTE_FUSED_ATTN"] = "1"
os.environ["NVTE_FUSED_ATTN_FORCE_WORKSPACE_OPT"] = "1"

device = "cuda:0"
dtype = torch.bfloat16

B, N, L = 2, 10_000, 300
T, H, D = (B * (N + L)), 24, 64
# create 4 sequences, evenly sizedf
SEQ_SIZE = T // 4
seqlens = [SEQ_SIZE] * 3
seqlens.append(T - sum(seqlens))
assert np.sum(seqlens) == T, f"Sum of seqlens ({np.sum(seqlens)}) must equal T ({T})"

qkv = torch.randn(T, 3, H, D, device=device, dtype=dtype)
q, k, v = qkv.unbind(dim=1)

cu_seqlens_q_cum = np.zeros(len(seqlens) + 1, dtype=np.int32)
cu_seqlens_q_cum[1:] = np.cumsum(seqlens)
cu_seqlens_q_cum = torch.from_numpy(cu_seqlens_q_cum).to(device)

te_attn = te.DotProductAttention(
    num_attention_heads=H,
    kv_channels=D,
    qkv_format="thd", # tokens, head, dim
    attn_mask_type="padding",
)

te_out = te_attn(
    q, k, v,
    cu_seqlens_q=cu_seqlens_q_cum,
    max_seqlen_q=np.max(seqlens),
    max_seqlen_kv=np.max(seqlens),
    cu_seqlens_kv=cu_seqlens_q_cum
)

tols = dict(atol=2.5e-2, rtol=2.5e-2)

flash_out: torch.Tensor = flash_attn_varlen_qkvpacked_func(
    qkv,
    cu_seqlens=cu_seqlens_q_cum,
    max_seqlen=np.max(seqlens),
)

torch.testing.assert_close(flash_out, rearrange(te_out, 'T (H D) -> T H D', H=H), atol=5e-3, rtol=5e-3)

for i in range(2):
    print(f"bench {i}")
    _, flash_m = benchmark_forward(
        flash_attn_varlen_qkvpacked_func, qkv, cu_seqlens_q_cum, np.max(seqlens), repeats=50, verbose=False
    )

    _, te_m = benchmark_forward(
        te_attn, q, k, v, repeats=50, cu_seqlens_q=cu_seqlens_q_cum, max_seqlen_q=np.max(seqlens), max_seqlen_kv=np.max(seqlens), cu_seqlens_kv=cu_seqlens_q_cum, verbose=False
    )

    print(f"Flash: mean={flash_m.mean}, median={flash_m.median}")
    print(f"TE: mean={te_m.mean}, median={te_m.median}")

for i in range(2):
    print(f"bench bwd {i}")
    flash_grad = torch.randn_like(flash_out)
    te_grad = torch.randn_like(te_out)

    qkv.requires_grad_()
    q.requires_grad_()
    k.requires_grad_()
    v.requires_grad_()

    _, flash_m = benchmark_backward(
        flash_attn_varlen_qkvpacked_func, qkv, cu_seqlens_q_cum, np.max(seqlens), grad=flash_grad, repeats=50, verbose=False
    )

    _, te_m = benchmark_backward(
        te_attn, q, k, v, repeats=50, cu_seqlens_q=cu_seqlens_q_cum, max_seqlen_q=np.max(seqlens), max_seqlen_kv=np.max(seqlens), cu_seqlens_kv=cu_seqlens_q_cum, grad=te_grad, verbose=False
    )

    print(f"Flash: mean={flash_m.mean}, median={flash_m.median}")
    print(f"TE: mean={te_m.mean}, median={te_m.median}")

Outputs:
Flash: mean=0.0021125075197778644, median=0.0021125075197778644
TE: mean=0.002271024080691859, median=0.002271024080691859
bench 1
Flash: mean=0.002129286640556529, median=0.002129286640556529
TE: mean=0.002277279000263661, median=0.002277279000263661
bench bwd 0
Flash: mean=0.006021905019879341, median=0.006021905019879341
TE: mean=0.006118590539554134, median=0.006118590539554134
bench bwd 1
Flash: mean=0.006005273800110444, median=0.006005273800110444
TE: mean=0.0061185801401734356, median=0.0061185801401734356

Any thoughts on what I might be doing wrong?
Edit: I get a definite win at head dim 128. Maybe CuDNN just does better at larger head dims.
bench 0
Flash: mean=0.003518069520359859, median=0.003518069520359859
TE: mean=0.002689688680693507, median=0.002689688680693507
bench 1
Flash: mean=0.003591226399876177, median=0.003591226399876177
TE: mean=0.0026920175598934295, median=0.0026920175598934295
bench bwd 0
Flash: mean=0.010546553599415347, median=0.010546553599415347
TE: mean=0.007746712840162218, median=0.007746712840162218
bench bwd 1
Flash: mean=0.010531400180188938, median=0.010531400180188938
TE: mean=0.00786671765963547, median=0.00786671765963547

Re-opening this because I think performance of CuDNN should be exceeding flash attention 2 @ head dim 64, according to this graph:

Maybe I'm doing something wrong?

Hi @vedantroy , I'm not surprised that cuDNN performs better at head_dim = 128 than 64. It matches with my benchmarks too.
I'm not aware of any benchmark scripts that directly produced that performance chart (maybe FA has published it somewhere). But it'd be good to check the cuDNN versions used in their scripts. Also, whether the qkv_format is bshd or thd, and add causal mask to your tests as well. I think this is all the possible differences I can see between your tests and FA's.

This might be FA's script: https://github.com/Dao-AILab/flash-attention/blob/main/hopper/benchmark_attn.py


3.6.5 python in airgap mode

buildpack fix for https://github.com/plotly/streambed/issues/13569
sets default Python version to working v3.6.5 when in airgap mode

@josegonzalez please review!

Note: this is possibly not needed given your testing of the SQLite3 requirements @josegonzalez. I'm opening this here as an alternative approach if needed!

Please test this before releasing!

Test Plan:

Run airgap deployment
Track output of deploy to confirm python v3.6.5 is used when no runtime is specified.


Bump typing-extensions minimum version to 4.5.0

Change Summary

PEP 702 deprecation by #5480 started to use typing_extensions.deprecated.
This function is available only 4.5.0 or later.
Related issue number

Checklist

[ ] Unit tests for the changes exist
[ ] Tests pass on CI and coverage remains at 100%
[ ] Documentation reflects the changes where applicable
[ ] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

please review

@samuelcolvin
Thanks for reply.
I updated requirements pinning files by ./requirements/refresh.sh

please review

Thanks @KanchiShimono


Remove the 'medium' flight for the (win10) builds ...

Since we don't have (correctly) documented any 'medium' flight build (https://buildfeed.net/rss/flight/medium/) it's better to remove it from the website.

Covered by changes made in localisation lab to Flighting enum.


Ensure storybook is not included in the installed bundle

Currently it is being included in consuming apps' node_modules
AC:

[ ] ensure it is not included in consuming apps' node_modules

From @jakeoien:

This ticket was intending to solve an issue where linking Foundry in a local project causes multiple versions of React to load. We came up with this as the solution. Turns out, this isn’t enough - we’re still seeing the issue even after this change. The problem we’re running into is that these storybook dependencies are a part of the foundry package itself.
I’m wondering if a better way of going about this would be to move all of the storybook stuff out of our src/ directory so that it’s not actually a part of our bundled code.
The big thing this blocks is trying to make changes like bugfixes using a local version of foundry, that currently won’t work.

From me:

I’ve seen packages (@react-three/drei for instance) that put all the storybook stuff in .storybook - which may solve the issue for us.

Moved to 'done' but still open


Add physics questions task

@zijwang We are now requesting that task authors please include an explicit section in the README.md file called "data source", listing exactly where you got your data from (or explicitly state that you made it up yourself). Many thanks!

@shyamupa are one of the assigned reviewers for this task.  Please provide feedback and be sure to notify me with a formal accept or does not meet criteria by Tuesday June 22 (if you have not already done so).

@vinayprabhu are one of the assigned reviewers for this task.  Please provide feedback and be sure to notify me with a formal accept or does not meet criteria by Tuesday June 22 (if you have not already done so).

The amount of tasks we received this round is tremendous.  With so many tasks to review we have decided to extend the review period to Tuesday, June 29.
Reviewers: if the submitter has made revisions please be sure to notify me with a formal ”accept” or ”does not meet criteria” by Tuesday, June 29  (if you haven't already done so).
this is an automated message

Hi @chiafullo @Sohl-Dickstein @guygurari ! It has been a long while but my task hasn't received any review yet. Could you take a look and let me know next steps?

Thanks for flagging this! Your task will receive a meta-review soon. In
your case the meta-reviewer will perform an initial evaluation, and will
solicit additional reviews as needed. You haven't been forgotten, and thank
you for submitting a task!
On Tue, Jul 13, 2021 at 6:52 PM Zijian Wang @.***>
wrote:

Hi @chiafullo https://github.com/chiafullo @Sohl-Dickstein
https://github.com/Sohl-Dickstein @guygurari
https://github.com/guygurari ! It has been a long while but my task
hasn't received any review yet. Could you take a look and let me know next
steps?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/BIG-bench/pull/418#issuecomment-879523338, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADZW4EWI7JU2W2LXRLLAXTTXTUWNANCNFSM4555TK3A
.

Hi @zijwang and thanks for your submission. I'm the meta-reviewer assigned to the task. Apologies for the long delay in reviewing.
Overall the task looks to me like a good submission. However, before proceeding, I will ask that you obtain permission to use the data in BIG-bench from owners of the site where the data originated (as specified in the README). If you already have their permission, please specify that in the README.

Thanks for the review, @guygurari ! I confirm that we have obtained the permission from the owners of the site. I also added a note in the README.

Thank you @zijwang !
Here is a full task review. The task is accepted and I'll merge once the tests finish running.
Task review
This is a difficult and thorough submission which measures a model's ability to answer basic high school level physics questions. I believe it will be an excellent addition to the benchmark.
Correctness: I checked a few of the physics questions and the answers were all correct.
Formatting: The JSON file is readable.
Specificity: The task measures the model's ability to answer physics questions at a high school level. There are many questions on a diverse set of physics topics.
Difficulty: I believe this will be a very difficult task for current language models, which makes it appropriate for BIG-bench.
Not solvable by memorizing the Internet: The questions were obtained from an existing website, which means there is risk of memorization. However, I believe this risk is low enough that it is worth including this task, while also keeping an eye out for surprisingly good performance during evaluation.


Readme udpates needed

Hey @dalechen
Great to see this sample here!
Let me suggest a couple minor changes to the Readme:

In the header, you set "Platforms" to php, this should be python
I suggest you pint to https://github.com/Azure/azure-iot-sdks/blob/master/doc/setup_iothub.md for the instructions on how to create the IoT Hub, that way you don't have to maintain this if/when this changes.

Thanks for the suggestions, I am oof now, I will make the changes on Tuesday when I come back to the office.
-Dale Chen
From: Olivier Bloch<EMAIL_ADDRESS>Sent: 2016年5月14日 0:51
To: Azure-Samples/iot-hub-python-get-started<EMAIL_ADDRESS>Cc: Dale Chen<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: [Azure-Samples/iot-hub-python-get-started] Readme udpates needed (#1)
Hey @dalechenhttps://github.com/dalechen
Great to see this sample here!
Let me suggest a couple minor changes to the Readme:

In the header, you set "Platforms" to php, this should be python
I suggest you pint to https://github.com/Azure/azure-iot-sdks/blob/master/doc/setup_iothub.md for the instructions on how to create the IoT Hub, that way you don't have to maintain this if/when this changes.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/Azure-Samples/iot-hub-python-get-started/issues/1

Hi @dalechen
Any ETA on this one?
Thanks

Thanks for tracking on this, the platform was set to Python from Php. For the second suggestion, I am confirming with the original author, I should be able to update it next Tuesday when I get to the offoce.
-Dale Chen
发件人: Olivier Bloch<EMAIL_ADDRESS>发送时间: Monday, June 6, 2016 2:05 PM
收件人: Azure-Samples/iot-hub-python-get-started<EMAIL_ADDRESS>抄送: Dale Chen<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>主题: Re: [Azure-Samples/iot-hub-python-get-started] Readme udpates needed (#1)
Hi @dalechenhttps://github.com/dalechen
Any ETA on this one?
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Azure-Samples/iot-hub-python-get-started/issues/1#issuecomment-224088098, or mute the threadhttps://github.com/notifications/unsubscribe/AGd-L7lw3qMUH8rzNEWQpBjHwXDrKJiBks5qJItugaJpZM4IeMeX.

Hi @dalechen
Can this one be closed?


added mbqc tutorial

Hi
I would like to contribute this tutorial on measurement based quantum computing to the Qiskit textbook.
It partially addresses some elements from  https://github.com/Qiskit/qiskit-aer/issues/508 using Qiskit as is, without the need to implement new features. Hopefully, I will be able to contribute code for "Conversion of a quantum circuit to MBQC" later. snapshots of internal states is a bit trickier and is not on my to-do list at the moment.
Regards

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.mbassiouny seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@atharva-satpute  thanks for fixing so many typos.
I had the impression my spell-checker was activated which is why when It complained about nothing, I assumed things were fine.
I will give it another read tomorrow and I will fix any syntax errors or typos I encounter. Thanks for your review! Appreciate it.

@atharva-satpute the latest commit 3e360ea should have fixed typos (including your edits) and few other mistakes. Thanks

Thanks for submitting this notebook to us. Unfortunately we're not accepting new content from the community at the moment, so I'm going to close this PR.
It looks like you've put a lot of work into this, and I do think many people will find this very valuable. For this reason I highly encourage you to self-publish this notebook, maybe through GitHub pages. I'm more than happy to help you set this up and to leave some review comments if you do decide to self-publish.
Please message me on the Qiskit Slack workspace if you want to chat.


[Feature] Can we separate TaskList schema from task-list-item MilkdownPlugin

Initial checklist

[X] I agree to follow the code of conduct
[X] I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Problem
https://github.com/Milkdown/milkdown/blob/aabeffa126720405be492c51e51f8458d06abea2/packages/preset-gfm/src/node/task-list-item.ts#L12
Now we cannot add new command like InsertTaskList - the reason is that taskList schema is in task-list-item Plugin only.
To add taskList checkbox I have try to insert node from listItemSchema but without success:
import {listItemSchema} from "@milkdown/preset-commonmark";

export const insertTaskListCommand = $command(
    'InsertTaskList',
    ctx => () => (state, dispatch) => {
      if (!dispatch) return true;

      const { tr, selection } = state;

      const node = listItemSchema.type(ctx).create()
      if (!node)
        return true

      dispatch(tr.replaceSelectionWith(node).scrollIntoView())
      return true;
    }
);

Solution
extract from task-list-item in new file TaskListSchema.ts that can be usable for new commands.
Alternatives
...

https://github.com/orgs/Milkdown/discussions/1028

The task list item is just the same as list item with the checked attribute. You can add commands for list item and check if it holds the checked attribute. The reason why I combine them is that if you separate them, they'll need the same keymap and they'll conflict in some cases.

@Saul-Mirone how to add the command insertTaskList item? Chekbox

About the command

export const insertTaskListCommand = $command(
  'InsertTaskList',
  (ctx) => () => (state, dispatch) => {
    if (!dispatch) return true;

    const { tr } = state;
    //const { from } = selection;

    const node = listItemSchema.type(ctx).create({ checked: false });
    //                                                                                ^ change here
    if (!node) return true;

    return true;
  }
);

About the style
You need to implement a custom task list item since we're headless now. Like what I did in playground:https://github.com/Milkdown/website/blob/main/src/components/playground-editor/editor-component/ListItem.tsx
Another good news is that I'm working on a component library which contains one can work out of box.

@Saul-Mirone it works I can create checkbox but I have error using create()

if I use createChecked
const node = listItemSchema.type(ctx).createChecked({ checked: false });
I have eror: RangeError: Invalid content for node list_item: <>
it appears that children of the listItem is missing
But it works with  const node = listItemSchema.type(ctx).createAndFill({ checked: false });
You can add in playground demo Toolbar new TaskList button.
Thanks!

@Saul-Mirone insertTaskListCommand works and create new checkbox but cursor and textSelection appears on the next line. How can I write text next to the checkbox created?


puppeteer_tests: Port to TypeScript

Merged, thanks @andersk!  @priyank-p @chdinesh1089 @showell FYI :)


Extension no longer compatible with Lodestar node

It looks like the extension no longer works on my end (just shows ⌛ Verifying...). I think the reason for this is that we updated the light client events in https://github.com/ChainSafe/lodestar/pull/6309 to be spec compliant but this also means the data that is served from our nodes does no work with older versions of the @lodestar/light-client package.
For compatibility, the package has to be updated to at least version 1.15.0

Once updated it should now be possible to use Nimbus or Lodestar node interchangeably

@rdvorkin Thanks for the fast fix! The extension is working again for me (✅ Verified @ Block 19260676)


[FEAT] Support header / subheader outlining

Is your feature request related to a problem? Please describe.
In Obsidian, a more meaningful way to outline is with headers and subheaders. All content under a header until another header at the same or higher level is considered nested
Describe the solution you'd like
I would like to use the same sorts of keyboard shortcuts to manipulate headers and their nested content as "items and subitems"
Describe alternatives you've considered
Obsidian doesn't really have a way to do it!
Additional context
Let's say I decide that Chapter 2 should actually be Chapter 1. Right now, the best way to do it is just cut and paste. "Swap line up" doesn't exactly work.

@classicrob Thank you for your request! I can understand the use case but I think it's not exactly related to Workflowy-like experience that I want to implement.
I think it's better to create another plugin like "Move heading with it's content through the document". What do you think?

Yes, this request is more suited  for another plugin,  "Microsoft Word" or "OneNote" style plugin
https://forum.obsidian.md/t/navigate-move-indent-and-unindent-by-heading/4202/10

@classicrob Thank you for your request! I can understand the use case but I think it's not exactly related to Workflowy-like experience that I want to implement.
I think it's better to create another plugin like "Move heading with it's content through the document". What do you think?

A separate plugin would be fine! Would you make it, or should I post a plugin request? I view outlining with headings and subheadings as very similar in spirit to bullet point oriented outlining (at least they are treated this way in org-mode), though it seems we differ in opinion here.

I could make such plugin, but I can't promise.
As I mentioned in Discord, I think https://github.com/manogna4/obsidian-koncham-nav-note is better place for such functionality.

@classicrob Thank you for your request! I can understand the use case but I think it's not exactly related to Workflowy-like experience that I want to implement.
I think it's better to create another plugin like "Move heading with it's content through the document". What do you think?

A separate plugin would be fine! Would you make it, or should I post a plugin request? I view outlining with headings and subheadings as very similar in spirit to bullet point oriented outlining (at least they are treated this way in org-mode), though it seems we differ in opinion here.

as @vslinko has mentioned, this is definitely in my plans for koncham-nav-note. I can't promise when it'll happen though.
I use headers similar to you in some notes, so I've felt the need. It's not a pressing need though, so I can't promise when I'll do that.


codet5-base.commons-math.mid-3457.idx-25178.2.mutant

This is an edit in the format in the MutableInterval file

Fix indentation LGTM!


OpTestFlash should verify flashed firmware matches what's expected

We should verify version strings of what we flash with what we expected to flash to ensure that we're actually running the code we expected to.
I've seen an OpenBMC system "successfully" flash BMC firmware but it not take, so this is a Real World issue.

This issue is fixed already.


Consider removing tests from the distribution

The actual code of this gem is very small, but the gem takes up more than 10MB due to the tests fixtures. Please consider removing the tests from the distributed gem.
For some background: https://github.com/rubygems/rubygems/issues/735

Agreed. Pull request welcome 👍

Already done in #11. Upgrade to 0.3.3.


Microsoft Edge - 0: 'DOMRect' is not defined

Do you want to request a feature or report a bug?
BUG
What is the current behavior?
Doesn't work on Microsoft Edge
If the current behavior is a bug, please provide the steps to reproduce and create a JSFiddle.

The jsfiddle or website example doesn't work on Edge.
What is the expected behavior?
Works on Microsoft Edge
Your environment:
Selection-version: 1.70
Browser-version:  Microsoft Edge 55.18362.449, Microsoft EdgeHtml 18.18363
Operating-system:   Windows 10

Fixed (?) in 3b1f1132eabc448261e6d1b9c15019e93b99be5e, could you try the latest version from the master branch? I don't have access to Legacy Edge anymore.

That was it. Thank you! 👍

Your welcome :) I'll publish a patch-version later today!


[PARTNER] Aiven

Add Participant Form
This is an issue created to request the Valkey Project adding a company as a participant in the website. If you want your company to be added please make sure the content is factual and related to the Valkey project.
Company Information

[x] Provide Company Name: Aiven
[x] Provide Company URL: https://aiven.io
[x] Provide Description of Company (50 words or less):

Aiven is a versatile platform empowering you with AI-driven workload optimization and control over your data.
Deploy widely adopted technologies across multiple clouds with just a few clicks to stream, store, and serve your data.

[x] Provide Link to Valkey related offering: https://aiven.io/valkey
[x] Provide Description related to Valkey offering (50 words or less):

Aiven for Valkey is a managed, in-memory NoSQL database with a small footprint and big performance.
It is built on open source Valkey and compatible with legacy Redis® OSS.

[x] Attach the company Logo (use SVG format if possible)

Contact Person
We want to be able to reach out to you if we have questions while processing this request. Please introduce your contact details (or the details of the responsible person in your company).

[x] Name: Nick Rycar
[x] GitHub handle: NickRycar
[x] E-mail<EMAIL_ADDRESS>

dependent on martinrvisser/valkey-io.github.io#2


Metrics does not show information for pods/containers

Description:
While using a list to collect metrics, for testing, metric collection for the invalid node and all nodes after it in list fails, should fail only for the invalid node and continue.
https://bugzilla.redhat.com/show_bug.cgi?id=1301861
Screenshots:
dummy node:

@miq-bot add_label providers/containers, wip
cc @simon3z

This might help us avoid errors but it doesnt sove the problem.
Something is calling that save_inventory with nils

@simon3z metrics are collected for the provider with dummy node (see screenshots above), what is wrong with my settings ?

@simon3z metrics are collected for the provider with dummy node (see screenshots above), what is wrong with my settings ?

@yaacov check with Einat, she reported the issue.

@yaacov check with Einat, she reported the issue.
@simon3z I talked with Einat, I can reproduce it now :-)

@miq-bot remove_label wip

Now that #8291 is merged, closed/reopened to restart Travis

@miq-bot add_label darga/yes

@simon3z have you reviewed this PR yet?

@simon3z check with Einat on her provider and it reads the metrics with and without dumy nodes. This fixes the issue.

LGTM :+1: cc @chessbyte

@yaacov the subject of this issue is misleading. I think we should improve it. (It's not mentioning that the nodes doesn't exists, etc.).

Description:
Metric collection for the invalid node and all nodes after it in list fails, should fail only for the invalid node and continue.

@yaacov, thanks for this description, it really helps when understanding what you're changing, even if it is a smaller bug fix.

@yaacov this seems strange to me that a failure in perf_collect_metrics for one node would kill the metrics collection for the rest of the nodes.  The collection for each node should be queued independently, so a failure in one node should only impact that node's execution.  All the other nodes should still be queued, right?

this seems strange to me that a failure in perf_collect_metrics for one node would kill the metrics collection for the rest of the nodes.

@blomquisg @simon3z @zeari My bad, the description is misleading.
TL;DR
The original reporter and me could not reproduce the bug.
Long description
Working with the original reporter of the bug, using her system and providers, we could not reproduce this bug.
While trying many ways to reproduce the bug we used this line to speed up reading metrics
ContainerNode.all.each { |n| n.perf_capture('realtime') }
and we got the exact same errors in the log, and the same lack of showing graphs.
If nodes with nil cpu and memory are allowed, a hack like the one we used, should not fail with unhandled error. This PR makes it possible to use hacks that assume nodes with no cpu or memory  will not raise unhandled errors.
It is also possible that the original report was due to a mistake in the metrics reading (like the hack we used) and not because of problem in manageiq.

ContainerNode.all.each { |n| n.perf_capture('realtime') }

Aha, yeah that kind of sequential collection of metrics for all ContainerNodes would definitely see the problem you were describing.
In general, I think the error handling is fine the way you have it here, so I'll merge it.  But, I don't think this fixes the problem experienced in the bug.


Tweak RTD theme for better representation of versions

Update the configuration for the sphinx theme so that the version of the theme is picked up from the Cilium tree
Customize the version text in the upper left corner for stable releases to show the specific version of Cilium that the docs are generated from
Reduce the redundancy of the "v: v1.1" text in the version navigation bar in the bottom right

See a preview here:
https://joestringercilium.readthedocs.io/en/stable/
Needs to be backported into:

Each active branch so that the theme will be consistent between all branches
A tagged release on github to make the stable docs consistent with the rest

This change is

test-docs-please


gccgo: runtime.Caller inconsistency

What steps will reproduce the problem?

http://play.golang.org/p/g_s9aMiETt

What is the expected output? What do you see instead?

$ go run -compiler gc main.go
main
$ go run -compiler gccgo main.go
Outer

Looks like gccgo is inserting miranda methods when an inner method is called via
embedding.

Please use labels and text to provide additional information.

% gccgo -v
Using built-in specs.
COLLECT_GCC=gccgo
COLLECT_LTO_WRAPPER=/opt/gccgo/libexec/gcc/x86_64-unknown-linux-gnu/4.9.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: ../gcc/trunk/configure --prefix=/opt/gccgo --enable-languages=go
--disable-bootstrap : (reconfigured) ../gcc/trunk/configure --prefix=/opt/gccgo
--enable-languages=go --disable-bootstrap
Thread model: posix
gcc version 4.9.0 20131119 (experimental) (GCC)

This works now with gccgo, I think because we now skip stub methods in the traceback.


Fix py_account_data_context

This change is

Codecov Report

Merging #929 (88f4653) into main (035ecee) will decrease coverage by 0.38%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #929      +/-   ##
==========================================
- Coverage   68.54%   68.17%   -0.38%
==========================================
  Files          42       42
  Lines        5872     5904      +32
  Branches     5872     5904      +32
==========================================
  Hits         4025     4025
- Misses       1473     1505      +32
  Partials      374      374

Files Changed
Coverage Δ

crates/native_blockifier/src/py_transaction.rs
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Newer podman is needed to stabilize the CI

Podman CI sometimes fails with the following error:
Error: error attaching to container 4a88c6c75919307675b210c45a5c1a61cda84cfc23d31047f238bedf885cc02a: read unixpacket @->/proc/self/fd/14/attach: read: connection reset by peer\"\n  Exit code: 126

The issue has been fixed in pod v4.2.0+: https://github.com/containers/podman/pull/14109
The podman version we are using now is 3.4.2 and it is installed on the base image in the GitHub Action: https://github.com/actions/virtual-environments/blob/ubuntu20/20220724.1/images/linux/Ubuntu2004-Readme.md#tools
We can try to upgrade it podman to v4.2.0+ if this test becomes very flaky. Otherwise, we can wait for GitHub Action to upgrade it for us.
cc: @mortent

We only see very occasional flakes, so I think we can just wait for GitHub Action to do the upgrade.

I haven't seen this happen in a while, so closing this issue.


Added allreduce python generator

There is a lot of hard coding here. Doesn't seem very maintainable


Could not find a part of the path "C:\ExportedDLC_temp\Sprite

Error
Unhandled exception has occurred in your application.  If you click Continue, the application will ignore this error and attempt to continue.  if you click Quit, the application will close immediately.

Could not find a part of the path "C:\ExportedDLC\_temp\Sprite

It does create C:\ExportedDLC_temp and \AudioClip and MonoBehavior directories.  Audioclip contains an .ogg file.
Here is the list of contents from the MonoBehavior directory.
ExampleSongBeatmapLevelData.json
ExampleSongEasyBeatmapData.json
ExampleSongExpertBeatmapData.json
ExampleSongExpertPlusBeatmapData.json
ExampleSongHardBeatmapData.json
ExampleSongNormalBeatmapData.json
ExampleSongOneSaberExpertBeatmapData.json
ExampleSongOneSaberExpertPlusBeatmapData.json
ExampleSongOneSaberNormalBeatmapData.json

Same issue here, any workaround ?


'Use Hypervisor' option prevents x86 QEMU VM from starting on Apple Silicon

Configuration

UTM Version: 3.2.4
macOS Version: 12.4
Mac Chip: M1

When importing an x86 VM that has the 'Use Hypervisor' option enabled on an Apple Silicon Mac, the VM refuses to start with the error "qemu-x86_64-softmmu: unable to find CPU model 'host'".

That’s expected because obviously you can’t virtualized x86 on arm. Go into the vm settings and uncheck the option to use hypervisor under QEMU settings.

The mouseover text for that option implies the option is ignored on Apple Silicon:

The option is grayed out on Apple Silicon, even if enabled.

Thanks


Group Convolution and batch processing

Hello
I am trying to implement a neural n/w (similar to Alexnet) using the Convolution layer APIs for ARM Neon. Does the APIs in the Compute lib support Grouped Convolution and batch processing?
If so, can you clarify how to configure for grouped convolution and batch processing using the API.
Thank you.
Kamrao

Hello @mkamrao,
The library's Tensor object supports up to 6 dimensions, thus it does support batch processing (3D batch space) for the CNN layers.
If you define a TensorShape as:
TensorShape shape(16 /* width */,16 /* height */,64 /* feature maps */,10 /* batches */);

you will have a tensor with 10 batches.
Grouped convolution is not yet supported in the current release but we are working on it.
Thanks


[ISSUE 3048] add example、fix issue #2994、remove unused line and and some notes.

add the example for OnewayProducer and ScheduledMessageConsumer.
remove a unused line and add notes.
Make sure set the target branch to develop
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.1%) to 53.95% when pulling 8d40f3be4927efa27645885de5b31aeaaa940aa5 on zplovekq:dev_simple_code into 160c5772fbdf02e55cdc67bc3b74bb9f9c4c644b on apache:develop.

It is recommended to split the pr, and each pr corresponds to an issue that needs to be resolved.


fix: Fix typo in add-ons

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Enhancement (non-breaking change which improves an existing feature or documentation)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented on my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Pull Request contains one commit. I squash my commits.

/recheck


chore(deps): :arrow_up: update dependency @types/jasmine to v5

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

@types/jasmine (source)
4.6.1 -> 5.1.2

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm WARN cli npm v10.2.0 does not support Node.js v20.2.0. This version of npm supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the latest version at https://nodejs.org/.
npm ERR! code ERR_SOCKET_CONNECTION_TIMEOUT
npm ERR! errno ERR_SOCKET_CONNECTION_TIMEOUT
npm ERR! request to https://registry.npmjs.org/pacote failed, reason: Socket connection timeout

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-10-14T02_03_06_963Z-debug-0.log

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm WARN cli npm v10.2.1 does not support Node.js v20.2.0. This version of npm supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the latest version at https://nodejs.org/.
npm ERR! code ERR_SOCKET_CONNECTION_TIMEOUT
npm ERR! errno ERR_SOCKET_CONNECTION_TIMEOUT
npm ERR! request to https://registry.npmjs.org/@material%2ftab-scroller failed, reason: Socket connection timeout

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-10-30T02_12_42_924Z-debug-0.log

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm WARN cli npm v10.2.3 does not support Node.js v20.2.0. This version of npm supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the latest version at https://nodejs.org/.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@angular/animations
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>|| ^18.0.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/@angular/material
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   2 more (@angular/platform-browser, @ngneat/spectator)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/@angular/core
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@angular/animations
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2023-11-08T20_15_40_957Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-11-08T20_15_40_957Z-debug-0.log


SVGs not rendered properly in SSR (nuxt.js)

I have a few svgs that render perfectly when running nuxt.js in dev mode.  They look like this:

When built with Nuxt using SSR, they render like this:

What are we doing wrong?

Have you found a solution? If no, could you share those SVGs here?

I am facing the same issue as well. In my production build style tags are getting stripped from the svg defs. Whereas development builds are working fine.

@shivgarg5676 Did you find a solution? I passing through the same problem. :(

I manually inlined the styles.

I'm guessing it's an issue with SVGO, might wanna try tweaking the svgo options and see if some settings solve your issue


Make wasmtime-cranelift::Builder public

Feature
wasmtime-cranelift only has 1 public function builder() which is really strange...
https://docs.rs/wasmtime-cranelift/latest/wasmtime_cranelift
at least make wasmtime-cranelift::Builder public
Benefit
developers can use customized Isa to work with wasmtime-cranelift
Implementation
based on https://github.com/bytecodealliance/wasmtime/blob/main/crates/cranelift/src/builder.rs#L17

Can you say more what you're wanting to do with this API?
wasmtime-cranelift is an internal crate of Wasmtime -- the engine is split into several crates for pragmatic reasons (build time, etc) but the APIs between these crates are not meant to be used by anyone else. Users of Wasmtime should use the wasmtime crate's API, and users of bare Cranelift should use cranelift-codegen, cranelift-frontend or cranelift-wasm as appropriate.

Can you say more what you're wanting to do with this API?

I'm writing a project compiling wasm into EVM bytecode, wanna the 100% features of cranelift, however, the TargetIsa is hardcoded in wasmtime-cranelift that I can not integrate the compiled cranelift IR with my customized Isa ))

OK, it's still not totally clear to me how the pieces fit together there. You are compiling Wasm to some target: does that mean that you have ported all of Wasmtime? Or instead are you mostly using the Cranelift pipeline (is this what you mean by "wanna the 100% features of cranelift"?) and getting at it via Wasmtime APIs? What is "EVM bytecode"? Have you ported Cranelift to this as well? (Out-of-tree Cranelift backends are another somewhat unsupported case, though we've had discussions about this one before at least.)
The standard and supported way to use Cranelift to compile Wasm is to use cranelift-wasm, and plug in your environment's specific lowerings for things like heap accesses via the relevant traits. We don't support taking internal pieces of Wasmtime and invoking them in nonstandard ways, and we don't want there to be external dependencies on these aspects of our design, so I would say the private APIs are private for a reason. We'd be happy to try to help you reuse things in some other way though, if you can fill in some more detail.

The standard and supported way to use Cranelift to compile Wasm is to use cranelift-wasm, and plug in your environment's specific lowerings for things like heap accesses via the relevant traits.

hmmm, probably got you, do you mean the optimization in wasmtime-cranelift is just for the execution logic of wasm? so what I need to do is translating wasm to cranelift IR again on my own and customize the FunctionEnvironment just for my target Isa even though my target Isa follows the basic rules like other Isas defined in cranelift-codegen?

does that mean that you have ported all of Wasmtime?

nope, I just need the part wasm -> cranelift IR with optimization

Or instead are you mostly using the Cranelift pipeline (is this what you mean by "wanna the 100% features of cranelift"?)

for example, the stack limit check in wasmtime-cranelift

and getting at it via Wasmtime APIs?

nope, I don't need wasmtime API, bcz I need the cranelift IR from wasm

What is "EVM bytecode"?

Just the binary format for a virtual machine

Have you ported Cranelift to this as well? (Out-of-tree Cranelift backends are another somewhat unsupported case, though we've had discussions about this one before at least.)

I'm using cranelift-wasm + winch-codegen now, but I just can implement a "base-line" compiler like what winch says xd

The standard and supported way to use Cranelift to compile Wasm is to use cranelift-wasm, and plug in your environment's specific lowerings for things like heap accesses via the relevant traits.

hmmm, as I learnt from the code, wasmtime-cranelift does a job translating wasm to cranelift IR with optimization ( plz point me out if I'm mistaken ) because my customized target Isa is not supported by wasmtime-cranelift, I don't want to do the job wasm -> cranelift again on my own bcz it is risky that's why I want to reuse wasmtime-cranelift

OK, I see the confusion here: wasmtime-cranelift does not translate Wasm code to Cranelift IR (CLIF). wasmtime-cranelift is only the bridge between Wasmtime and Cranelift. If you are not using or porting Wasmtime, you don't want to use wasmtime-cranelift.
Instead, cranelift-wasm is the crate (used by wasmtime-cranelift) that actually does the Wasm to CLIF translation. It requires some "hooks" to be filled in that are specific to the Wasm runtime the code will be running under.

I want to translate wasm to the binary code of a virtual machine, if it is possible to use cranelift to make it high quality and efficient?

Maybe; it depends what sort of translation you want. Cranelift is an optimizing compiler, so if you want the Wasm -> custom bytecode translation to do optimizations, you'll for sure get that. However it also makes a bunch of assumptions about the target architecture: it's really meant for "real hardware" ISAs like x86 or aarch64, and porting it to emit a custom bytecode may or may not be easy, depending on the bytecode's design. For example, Cranelift uses a register allocator and assumes that the target ISA has a fixed number of physical registers. If your bytecode is stack-based rather than register-based, that may be a problem.
Porting Cranelift is also not easy (no compiler is really super-easy to retarget; "real ISAs" tend to be large). The initial PR to add support for RISC-V, our latest addition (#4271), was 21k lines of code.

does that mean that you have ported all of Wasmtime?

nope, I just need the part wasm -> cranelift IR with optimization

Or instead are you mostly using the Cranelift pipeline (is this what you mean by "wanna the 100% features of cranelift"?)

for example, the stack limit check in wasmtime-cranelift

and getting at it via Wasmtime APIs?

nope, I don't need wasmtime API and don't need to run the wasm in wasmtime or any other wasm runtimes

OK, yeah, given the above, using wasmtime-cranelift is definitely not the right answer. In fact the stack-limit check you link is closely related to Wasmtime's data structures (its VMRuntimeLimits) so if you're not actually using Wasmtime, it doesn't make any sense to use that implementation. You'll need to develop your own CLIF lowerings for Wasm features that target your own bytecode VM.
I'll make a note on terminology here too: you need some "runtime" for the Wasm specifically, on top of your custom bytecode VM's runtime. In this context, "runtime" means support for Wasm semantics and state: for example, handling Wasm memories and tables. It could be a very simple mapping, but somehow you need to decide what a "memory load" or "table set" op becomes, and this is what you provide in your "hooks" to cranelift-wasm. wasmtime-cranelift provides code for all of this that assumes Wasmtime's data structures for memories, tables, function references, etc. exist. You'll need equivalents for all of these in order to run Wasm.

What is "EVM bytecode"?

Just the binary format for a virtual machine

Have you ported Cranelift to this as well? (Out-of-tree Cranelift backends are another somewhat unsupported case, though we've had discussions about this one before at least.)

I'm using cranelift-wasm + winch-codegen now, but I'm implementing a "base-line" compiler like what winch does xd

I'm not sure I understand what you're doing here: cranelift-wasm produces CLIF, an input format specific to Cranelift, but winch-codegen consumes Wasm and directly produces machine code, and has no understanding of CLIF at all. How are you combining the two?

Cranelift is an optimizing compiler, so if you want the Wasm -> custom bytecode translation to do optimizations, you'll for sure get that.

yeah, this is what I want! and the compiler time doesn't matter to my project!

If your bytecode is stack-based rather than register-based, that may be a problem.

Sadly it's stack-based...but while my target vm's instructions are super easy, I'll find it out if it is possible and necessary soon!

In fact the stack-limit check you link is closely related to Wasmtime's data structures (its VMRuntimeLimits) so if you're not actually using Wasmtime, it doesn't make any sense to use that implementation.

got you now, so what I can do is learning from the implementation of wasmtime-cranelift to write my own CLIF

but winch-codegen consumes Wasm and directly produces machine code

I just implemented the TargetIsa trait from winch-codegen for using the private CodeGen implementation xD
thank you for your patient explanation @cfallin, I'm closing this issue since ur right and now I know what to do next!

@cfallin  ur totally correct xD, I have to write my compiler on my own now since my target vm is stack-based... but wasmparser and the compiler ( both winch and cranelift ) implementation have inspired me really a lot! thank you for your great work!


We should make translateRoute static to EventRouter

http://backbonejs.org/#Router-extend
We should use classProperties such that instead of:
var myEventRouter = new Backbone.EventRouter();
myEventRouter.translateRoute(...);

it can just be:
Backbone.EventRouter.translateRoute(...)

@Courey want this one?


error importing pydantic using poetry in fastapi

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
When running a fastapi project using poetry, shows an error displaying:
ImportError: dlopen(/Users/jorgelopez/Library/Caches/pypoetry/virtualenvs/jlo-blog-qkDVX_54-py3.9/lib/python3.9/site-packages/pydantic/init.cpython-39-darwin.so, 0x0002): tried: '/Users/jorgelopez/Library/Caches/pypoetry/virtualenvs/jlo-blog-qkDVX_54-py3.9/lib/python3.9/site-packages/pydantic/init.cpython-39-darwin.so' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64')), '/System/Volumes/Preboot/Cryptexes/OS/Users/jorgelopez/Library/Caches/pypoetry/virtualenvs/jlo-blog-qkDVX_54-py3.9/lib/python3.9/site-packages/pydantic/init.cpython-39-darwin.so' (no such file), '/Users/jorgelopez/Library/Caches/pypoetry/virtualenvs/jlo-blog-qkDVX_54-py3.9/lib/python3.9/site-packages/pydantic/init.cpython-39-darwin.so' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64'))
Example Code
No response
Python, Pydantic & OS Version
1.10.4

Affected Components

[X] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .model_dump() and .model_dump_json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[X] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Read the error message - somehow you've installed the wrong binary.


fixes #259: use node.js to build scala.js in Travis

Current coverage is 80.11%

Merging #261 into master will increase coverage by +0.10% as of 9772d10

Powered by Codecov. Updated on successful CI builds.

Thanks, @ngbinh!
One strange thing—I pushed your commit to my scalajs branch, which is specially configured to run the Scala.js tests on Travis CI (by default they don't run), and now it's showing up here as a push build, which is still failing because of timeouts.
Are these settings reasonable to have in place even if we're not running Scala.js builds on Travis CI right now? Can I expect them to have an impact (either way) on how long and how much memory it takes to run the Scala.js tests locally?

Let me take a closer look at JS tests to make sure there are not any crazy thing I missed.
This PR should make local build a bit faster because it uses nodeJsEnv instead of Rhino

sorry for the delay. I was pretty swarm at work so will take a look at this some time next week.

I believe this is the default for Scala.js now. Feel free to re-open if the changes here are still relevant.


when to update paper and code

hi , I am very interested in your great work in multi-aspect controllable text generation, would you release your ACL23 paper and code recently? The last update is 12. 2022

We have updated our code. The camera-ready version of PriorControl will be uploaded to arXiv.org recently.


cherry-pick into 1.2:  filter: exposed functions to Lua to verify digital signature (#7050)

Description: Expose functions for users to verify digital signature in Lua script
Risk Level: Low
Testing: unit test, integration
Docs Changes: https://github.com/envoyproxy/envoy/compare/master...crazyxy:feature/boringssllua?expand=1#diff-ddc999700fdafb43c2cdcafcc7a4b887
Release Notes: https://github.com/envoyproxy/envoy/compare/master...crazyxy:feature/boringssllua?expand=1#diff-d8d3e33358b55e6c0466dd1bb5f40c79
Fixes #Issue: #7009
Signed-off-by: Yan Xue<EMAIL_ADDRESS>For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

/lgtm
/approve

/lgtm


Nesting "/" with "*" won't work

Hello,
I have just upgraded my app with react-router 1.0, but I can't reproduce the same pattern I was using before:
That's my final guess:
<Route path="/" component={ App }>

    {/* Internal routes, logged in, app ui */}
    <Route path="app" component={ Internal }>

        <IndexRoute component={ Dashboard }/>

    </Route>

    {/* External routes, not logged in */}
    <Route path="*" component={ External }>

        <IndexRoute component={ Home }/>

    </Route>
</Route>

The <Route path="*" > is not working for me..
Thanks!

I think it's something to with webpack or server. Having the same issue.

I am also using webpack, with source-map, and babel.
index
    React.render((
        <Router history={history}>
            { routes }
        </Router>
    ), ...);

And {routes} is imported from the snippet above.
With webpack 1.12
Thanks

@TCMiranda do you have this.props.children in App? Try to insert this in render function.

Yes, I do, the <Route path="app" component={ Internal }> route is working normally

@TCMiranda what do you mean by "it's not working for me"? Do you get any errors?
I've made a quick example of what you were trying to do and it works fine for me:
import React, { PropTypes, Component } from 'react';
import createBrowserHistory from 'history/lib/createBrowserHistory';
import { Router, Route, Link, Redirect, IndexRoute } from 'react-router';

class Navigation extends Component {
  render() {
    return (

<Link to='/'>Main</Link>

<Link to='/app'>Internal</Link>

<Link to='/someExternalRoute'>External</Link>

    );
  }
};

class Internal extends Component {
  render() {
    return (

        Internal component
        {this.props.children}

    );
  }
}

class Dashboard extends Component {
  render() { return
Dashboard
; }
}

class External extends Component {
  render() {
    return (

        External component
        {this.props.children}

    );
  }
}

class Home extends Component {
  render() { return
Home
; }
}

class App extends Component {
  render() {
    return (

App

        <Navigation />
        {this.props.children}

    );
  }
}

export default class Root extends Component {
  render() {
    return (
      <Router history={createBrowserHistory()}>
        <Route path='/' component={App}>
          <Route path='app' component={Internal}>
            <IndexRoute component={Dashboard}/>
          </Route>
          <Route path='*' component={External}>
            <IndexRoute component={Home}/>
          </Route>
        </Route>
      </Router>
    );
  }
}

@TCMiranda Did you get this problem worked out?  I'm experiencing a similar issue.
@knowbody My application is setup similar to your example, but for me the External component isn't being passed any children.  this.props.children is undefined, which leaves me unable to render Home.

@jackmoore if you can setup the app I can play with with this issue I'll try to help. I don't know how to reproduce your issue

@knowbody Before I go through setting something up, did you try on your own example to see what happens when you visit the / path?

what do you expect to happen?

That if the path is / then the App component's this.props.children would be the External component, rather than undefined.

no, why should it have External component. When you navigate to / it mounts App Component. If you want to have some other component mounted together with App then use IndexRoute.
The * is matched on everything besides /

@knowbody Oh ok, I see what you are saying.  You can disregard my comments then.  I assumed from your example that / should render the Home component.

@jackmoore  So do you want everything with /app to take you to Internal component and all the rest to External component?

@knowbody Thank you, thats what I was expecting also @jackmoore.
The problem is that the upgrading wiki says:

NotFound route

Not found really confused people, mistaking not finding resources from your API for not matching a route. We've removed it completely since it's simple with a * path.

// v0.13.x

// v1.0

Which is not true, because <Route path="*" does not match empty.

@TCMiranda you're welcome. and it does if / is not defined before

Ok, that makes sense...
Thanks for clarifying!


Giant width within flex container

It's quite simple, and straightforward.
I don't know if someone else reported this, I've looked within some issues but didn't found something related.
I've modified the base sandbox and here is the link: https://codesandbox.io/s/react-slick-playground-forked-dnc0n
It also happens inside children of flex elements.
Came around this while trying to use it in some projects of mine, below is the picture of what happened.
More info:
react-slick version: 0.26 (on my projects, default on the sandbox)
browser: Firefox 80.0.1 (64-bits)

Found a quick-fix for the children of flex-based elements. Applying max-width: 100%; to a non-flex child of a flex container seemed to work for me.
In the above sandbox, I've created a div inside .container and applied .container > div {max-width:100%;}

@Diegovisk came across your issue because I the same. Setting flex-direction: column on the container will prevent the unwieldy overflow. Hope it helps!

Here's how I solved it

        <Carousel >
            ~~~
        </Carousel>

@liaokaime , you saved my day!!!


maps and Elo

i need the maps and Elo of teams in the ( https://vlrggapi.vercel.app/match?q=results)
can you make it for me ?

that endpoint basically scrapes surface info from: https://www.vlr.gg/matches/results
to achieve that I would have to scrape the match detail page and get the data from there. Better implement would be a new endpoint that give match_result_details

How can i do that?
I'm currently making an data analysis program that predict the matches base on elo, maps, last games and players.


gcp_cloudfunctions_function is missing some of the column values.

Description of  the bug
After fixing the plugin for fetching GEN-2  cloud functions from vpc, gcp_cloudfunctions_function  table for gcp plugin is missing some column values. They are following below.

Status
Run Time
Available Memory
Build Id
Entry Point
Https Triggers
Ingress Settings
Max Instances
Service Account Email
Source Upload URL
Timeout

Steampipe version
Steampipe v0.22.2
GCP Plugin version
GCP Plugin v0.51.1
To reproduce
We can reproduce this issue by simply querying GCP Cloud Functions :

steampipe query
select * from gcp.gcp_cloudfunctions_function

Expected behavior
It is expected that all mentioned columns are populated when querying GCP Cloud Functions, both for GEN-1 and
GEN-2 Cloud Functions.
Additional context
Images which proves this issue.

@misraved  If you could please allocate this issue to me, as I know how to resolve this issue.

@ParthaI  Thank you, raising the fix asap.

Addressed in https://github.com/turbot/steampipe-plugin-gcp/pull/590


coveralls crashes when dealing with utf-8 source code

My project has source code that contains utf-8 (some of my tests are checking if my code works with weird inputs). My tests run fine and the python coverage tool also works fine, but coveralls crashes when processing it: see https://travis-ci.org/chmduquesne/ok/builds/43104434.
I am attaching the traceback:
$ coveralls
Submitting coverage to coveralls.io...
Traceback (most recent call last):
File "/usr/local/bin/coveralls", line 9, in <module>
load_entry_point('coveralls==0.4.4', 'console_scripts', 'coveralls')()
File "/usr/local/lib/python2.7/dist-packages/coveralls/cli.py", line 49, in main
result = coverallz.wear()
File "/usr/local/lib/python2.7/dist-packages/coveralls/api.py", line 73, in wear
data = self.create_data()
File "/usr/local/lib/python2.7/dist-packages/coveralls/api.py", line 122, in create_data
self._data = {'source_files': self.get_coverage()}
File "/usr/local/lib/python2.7/dist-packages/coveralls/api.py", line 132, in get_coverage
return reporter.report()
File "/usr/local/lib/python2.7/dist-packages/coveralls/reporter.py", line 27, in report
self.parse_file(cu, self.coverage._analyze(cu))
File "/usr/local/lib/python2.7/dist-packages/coveralls/reporter.py", line 64, in parse_file
source = source.decode(encoding).encode('utf-8')
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 1: ordinal not in range(128)

I see you've fixed a problem with malformed encoding declaration: https://github.com/chmduquesne/ok/commit/bdbf3f60f3c7565812c3433b3db91ad624d84e8d
Thanks for reporting this problem

Yes. My keyboard sometimes puts this weird white character instead of a
space, which apparently is not cool when you are declaring the encoding.
Python does not complain, but it makes coverage unhappy, as well as
coveralls. Sorry, I forgot to tell you that I fixed my code.
On Jan 5, 2015 6:04 PM, "Ilya Baryshev"<EMAIL_ADDRESS>wrote:

I see you've fixed a problem with malformed encoding declaration:
chmduquesne/ok@bdbf3f6
https://github.com/chmduquesne/ok/commit/bdbf3f60f3c7565812c3433b3db91ad624d84e8d
Thanks for reporting this problem
—
Reply to this email directly or view it on GitHub
https://github.com/coagulant/coveralls-python/issues/52#issuecomment-68738967
.


Minor documentation issue in learn service OAS yaml example

https://github.com/Kong/go-apiops/blob/cd3a7f217d4a711c4f1b3ffa5a817e738268d2fa/docs/learnservice_oas.yaml#L128C46-L128C66
documents the eventual name as "awesome-learnservice-upserttracks" but the name in x-kong-name at the top is awesome_learnservice

Need to run another test to check another edge case (regex), will fix when doing that


Build vs Pipeline

Please explain when we should use DownloadBuildArtifacts and when we should use DownloadPipelineArtifacts with the pros can cons. thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c0a16bcf-af6c-e278-f0a6-8ec95012ce4a
Version Independent ID: ae442106-33b3-786f-2158-34eed3fed6e0
Content: Download Build Artifacts task - Azure Pipelines
Content Source: docs/pipelines/tasks/utility/download-build-artifacts.md
Product: devops
Technology: devops-cicd
GitHub Login: @RoopeshNair
Microsoft Alias: ronai

I find it somewhat surprising that there's no mention of this in the docs!

I was unable to get "DownloadBuildArtifacts" to work in my yaml pipeline; however, "DownloadPipelineArtifacts" worked on my first attempt. Could be a PICNIC error on my end for BuildArtifacts.

BuildsArtifacts are the old way to storing your artifacts. Going forward we recommend you to use pipeline artifacts.
If you have published your artifacts using PublishBuildArtifacts task, then you need to use DownloadBuildArtifacts task to download them.
However if you have used PublishPipelineArtifacts task (or -publish simply) then you can use DownloadPipelineArtifacts task (or - download simply)

It would be worth documenting this, in the time I've spent looking through
the docs this is the first time I've heard that pipeline artifacts are the
way forward...
On Tue, 17 Dec 2019, 11:48 ashokirla<EMAIL_ADDRESS>wrote:

BuildsArtifacts are the old way to storing your artifacts. Going forward
we recommend you to use pipeline artifacts.
If you have published your artifacts using PublishBuildArtifacts task,
then you need to use DownloadBuildArtifacts task to download them.
However if you have used PublishPipelineArtifacts task (or -publish
simply) then you can use DownloadPipelineArtifacts task (or - download
simply)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/vsts-docs/issues/5570?email_source=notifications&email_token=AAFDGMEAIDOJYN3ZAKYMVF3QZC37FA5CNFSM4IVTIIBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHCDVDY#issuecomment-566508175,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFDGMHI4AFTOJX32RWVWTLQZC37FANCNFSM4IVTIIBA
.

We have already documented here: https://docs.microsoft.com/en-us/azure/devops/pipelines/artifacts/pipeline-artifacts?view=azure-devops&tabs=yaml#migrating-from-build-artifacts

My understanding here is that it's deprecated in favour of DownloadPipelineArtifact. Why do we now get a warning on Azure DevOps to now use the other way again?
"DownloadPipelineArtifact (DownloadPipelineArtifact)
Please use Download Build Artifact task for downloading Build Artifact type artifact. https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/utility/download-build-artifacts?view=azure-devops"

@bmargula We also started seeing a few of these warnings a few days ago:

We were originally confused by the warnings (as you were), until we realized that we were using the PublishBuildArtifacts@1 task in a few places in our pipeline (we were using PublishPipelineArtifact@1 everywhere else) due to lack of support for publishing artifacts to the same folder from multiple build steps (see microsoft/azure-pipelines-tasks#12480). As such, the warning was there to simply indicate that we should be using DownloadBuildArtifacts@0 to download artifacts published with PublishBuildArtifacts@1 and (similarly) we should use DownloadPipelineArtifact@2 to download artifacts published with PublishPipelineArtifact@1 (we were using DownloadPipelineArtifact@2 everywhere, even the ones that were being published with PublishBuildArtifacts@1).
After we switched everything the few situations that were using PublishBuildArtifacts@1 to use DownloadBuildArtifacts@0 (to match how they were being published), the warnings went away in our pipeline runs.

Thank you @sgerace for the detailed explanation!
We are using the  publish keyword which is supposedly the shortcut for the Publish Pipeline Artifact task.
When downloading we use the download keyword which is supposedly the shortcut for the Download Pipeline Artifact task.
Based on your explanation this should fit together, yet there is still this warning displayed.


[Suggestion] Add doc about "search results fewer than topk"

Note: This repository is ONLY used to solve issues related to DOCS.
For other issues, please move to other repositories.

Is there anything that's missing or inappropriate in the docs? Please describe.
User searched for top K vectors, yet there are less results than K.
Describe your suggestion
Add a description about why this happens.

#85 Already added the doc in Operational FAQ in v0.5.0.


feature: add default registry namespace

Signed-off-by: Ace-Tang<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
add registry namespace in config, it will be used in pull/push/search images.
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9e3e901). Click here to learn what that means.
The diff coverage is 16.66%.

@@           Coverage Diff            @@
##             master    #911   +/-   ##
========================================
  Coverage          ?   13.7%
========================================
  Files             ?     121
  Lines             ?    7647
  Branches          ?       0
========================================
  Hits              ?    1048
  Misses            ?    6509
  Partials          ?      90

Impacted Files
Coverage Δ

pkg/reference/def.go
33.33% <ø> (ø)

daemon/mgr/image_utils.go
0% <0%> (ø)

daemon/mgr/image.go
36.26% <0%> (ø)

pkg/reference/parse.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e3e901...4f96050. Read the comment docs.

LGTM


Feat/Add onInvalid hook to input chips

Before submitting the PR:

[ ] Does your PR reference an issue? If not, please chat to the team on Discord or GitHub before submission.
[x] Did you update and run tests before submission using npm run test?
--> There is currently 1 breaking test that is not related (autocomplete.ts:134)
[x] Does your branch follow our naming convention? If not, please amend the branch name using branch -m new-branch-name
[x] Did you update documentation related to your new feature or changes?

What does your PR address?
Please briefly describe your changes here.

Adds an optional onInvalid hook to the inputChips components + added an example in the docs for this
Added some typings to the exported

attributes

Nice and good looking addition, thanks for that!
Can be merged as far as I can tell :)

@Metaphysics0 I really like this feature, the concept is sound. But there were a few issues with the PR as submitted:

You were implementing additional types for the input chip props. We're in the process of removing primitive types like this, as Typescript can assume these automatically. No need to explicitly list them. This is the recommended practice. This change was also outside the scope of the PR.
You were implementing a custom function to run when the invalidate status is reach, however Svelte has a great mechanism in place for this scenario - using dispatched events! So I've dropped the function in place of a new event
Additionally I updated the verbiage and naming for a couple things. This is just me being nitpick-y.

You can review my last commit to see the changes in place. But this event offers a few benefits:

It's automatically documented in the Events tab on the docs page.
It uses the same general language where onInvalid becomes on:invalid
It allows us more easily package up more data in the event details if needed

With these modifications I think this is in a good state, so I'm going to merge now. This will be part of the release next week. Thanks for your contribution!


[HOLD for payment 2023-07-24] [$1000] Deep link to Profile Page is not opening in the installed app

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to Settings > Share Code > Copy URL
Paste the link in another app. ( Slack, Notes or Messages)
Try to open the link by tapping on it

Expected Result:
Profile page should get opened in the installed app (iOS & Android)
Actual Result:
The link gets opened in mobile browser (Safari / Chrome)
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:  1.3.32-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/dd72c933-7e30-4881-b802-6646c716931c
Expensify/Expensify Issue URL:
Issue reported by: @aswin-s
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687876003386849
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0143c4c287988aa719
Upwork Job ID:<PHONE_NUMBER>665750016
Last Price Increase: 2023-07-04

Proposal
Please re-state the problem that we are trying to solve in this issue.
Deep link to profile page is not working on iOS & Android
What is the root cause of that problem?
Profile page URL is of the format ‘/a/:accountID’. This URL prefix is not added to apple-app-site-association file and AndroidManifest. That’s the reason this URL is not recognized as a universal link by the app.
What changes do you think we should make in order to solve the problem?
Add ‘/a’ URL prefix to both apple-app-site-association file and AndroidManifest.xml
iOS
https://github.com/Expensify/App/blob/main/.well-known/apple-app-site-association#L10
{ "/": "/a/*", "comment": "Profile Page" },
Android
Add below lines to AndroidManifest.xml https://github.com/Expensify/App/blob/main/android/app/src/main/AndroidManifest.xml#L57

https://github.com/Expensify/App/blob/main/android/app/src/main/AndroidManifest.xml#L68

What alternative solutions did you explore? (Optional)
None

Agree with expected result 👍

@aswin-s's proposal looks good to me, looks like this was simply missed during the initial implementation of share profile link flow
🎀👀🎀 C+ reviewed!

@michaelhaxhiu @eVoloshchak This issue is not yet assigned to me. Is there another review pending?

@michaelhaxhiu, @aswin-s's proposal looks good to me, could you take a look and assign @aswin-s to this issue if you agree?

Sorry for blocking this, it's a new process for BZ to assign the contributor and I am a little behind.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~010b194c3e145d5456

Nice, this will be due for payment in about 1 week. Next is the checklist above 🤙

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/20144
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/20144/files#r1275320393
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1690395182200269
Determine if we should create a regression test for this bug.
Is it easy to test for this bug? Yes
Is the bug related to an important user flow? Yes
Is it an impactful bug? Yes

Regression Test Proposal

Have an IOS or Android device with the native app installed
Navigate to Settings > Share Code > Copy URL
Paste the link in another app. ( Slack, Notes or Messages)
Try to open the link by tapping on it
Verify that profile page is opened in the installed app

Do we agree 👍 or 👎

Requested the payment for this via NewDot

Payouts:

[ ] @aswin-s External issue reporter - $250
[ ] @aswin-s Contributor that fixed the issue - $1500
[ ] @eVoloshchak Contributor+ that helped on the issue and/or PR - $1500

@aswin-s drop me a comment here when you've accepted the upwork job invite

QA test is added here - https://github.com/Expensify/Expensify/issues/303310

@michaelhaxhiu Accepted the offer

Reviewed details for @eVoloshchak. This is accurate and approved for payment in NewDot.


Setting to Disable .js / .ts Autocomplete?

Hi @vunguyentuan 👋 hope you are well :)
Would you consider adding a setting to disable the .js / .ts autocomplete feature for projects that do not use CSS-in-JS?
Currently, in a project that does not use CSS-in-JS, the extension fills the autocomplete entries all over the place in JS, JSX, TS and TSX files with useless entries for CSS variables:

For example, adding a new setting called cssVariables.autocompleteInLanguages, default values below:
{
  "cssVariables.autocompleteInLanguages": [
    "css",
    "less",
    "scss",
    "postcss",
    "javascript",
    "javascriptreact",
    "typescriptreact"
  ],
}

Or, if this is based on file extension instead of language in the file, a new setting called cssVariables.autocompleteInFiles, default values:
{
  "cssVariables.autocompleteInFiles": [
    "*.css",
    "*.scss",
    "*.sass",
    "*.less",
    "*.js",
    "*.jsx",
    "*.ts",
    "*.tsx"
  ]
}

:+1: I do not use styles in javascript and the autocomplete is just pollution. I really only want them in css files.
It's fine if that's the default, but I was expecting a setting

@Cellule @vunguyentuan thanks for the setting!

@vunguyentuan is this new cssVariables.languages setting working completely?
I'm still receiving suggestings in a .ts files (typescript syntax), even though I have disabled those:

Disabling the extensions makes these suggestions disappear.
 It worked fine initially with my fork, then once it was published it no longer seemed to work
Haven't had time yet to investigate

@vunguyentuan can we reopen this issue?

@karlhorky I found my bug 😅
https://github.com/vunguyentuan/vscode-css-variables/pull/85
Sorry about that, hopefully it gets merged and released soon :)

Amazing, thanks! Watching #85 now :)

@vunguyentuan @Cellule thanks for the PR and merge!
I can confirm that this is fixed in the new 2.7.1 version which was just published 🙌