remove script for adding/removing heroku dynos

This reverts the changes in https://github.com/badges/shields/pull/6131 as it has moved to the other place
I've cancelled the scheduled jobs in heroku but I'll keep an eye on the new jobs to make sure they are definitely doing the business as expected before we merge this.

seems to be smooth sailing with the new approach :ship:


MINIFICPP-933: Fix raw site to site with secure comms

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Nice catch!

@phrocker The fix itself looks good, but I think there might be other issues around pemPassWordCb.
First, the callback ignores the size parameter OpenSSL supplies when copying the string to buf. If the password is exactly as long as the buffer, then the result will not be null-terminated, if the password is longer we will overwrite the buffer. I think we should check whether the password fits in the buffer and return -1, if not. (SSL_CTX_use_PrivateKey_file will use PEM_read_bio_PrivateKey internally, and will pass our callback to it: https://github.com/openssl/openssl/blob/2c18d164f52a77b9ecc1f835b83aec476334ebbc/ssl/ssl_rsa.c#L545, and this callback can return -1 on error: https://www.openssl.org/docs/man1.1.0/man3/PEM_read_bio_PrivateKey.html "The callback must return the number of characters in the passphrase or -1 if an error occurred.").
Second, we read the entire password file, and pass that string to the callback, and expect that it includes exactly one \n character (we copy pass->length() - 1 characters to the buffer). This might not be true if we are on Windows (\r\n), or if there is no newline at the end of the password file.


optimizedPoweredRails breaks how powered rails update other blocks

When enabled optimizedPoweredRails, flat powered rails give a shape update (a.k.a PP update) at the block below, which does not happen in vanilla minecraft. Sloped rails do not give that unintended shape update though.
Vanilla:

optimizedPoweredRails on:

The observers facing into the block below the rail powered.
P.S. In vanilla minecraft, rails do give a block update (a.k.a NC update) at the block below, as shown above.
By the way, update 1.18.x version please.

It seems that the bug only occurs when the rail power comes from same y-level or 1 block below. And it only occur when the rails are powered/depowered, not when they are placed or broken.


Incorrect Time/Date when exporting treatment log as CSV

Hello! I have been carefully logging the correct date and time of each injection and it reflects correctly in my "Treatment Log". However, when I go to export my Treatment Log as a CSV file in order to share with our cat's veterinarian etc, the dates and times are shifted. For example, our first injection was 3/16/2024 @ 9:07 PM, but the CSV file has it logged as 3/17/2024 @ 01:07. It seems as if the CSV file shifts each of our injection entries forward 4 hours from our treatment log. Is there a way to make the CSV file option reflect the date and time that we have in our treatment log to accurately reflect the date and time of each injection? Thank you!

Let me look into this real quick and push an update
On Sun, Mar 24, 2024, 9:13 AM rissyroo626 @.***> wrote:

Hello! I have been carefully logging the correct date and time of each
injection and it reflects correctly in my "Treatment Log". However, when I
go to export my Treatment Log as a CSV file in order to share with our
cat's veterinarian etc, the dates and times are shifted. For example, our
first injection was 3/16/2024 @ 9:07 PM, but the CSV file has it logged as
3/17/2024 @ 01:07. It seems as if the CSV file shifts each of our injection
entries forward 4 hours from our treatment log. Is there a way to make the
CSV file option reflect the date and time that we have in our treatment log
to accurately reflect the date and time of each injection? Thank you!
—
Reply to this email directly, view it on GitHub
https://github.com/JKesslerPhD/FIPInjectionLogger/issues/60, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3GD4F2FUNBBZMGSODET7DYZ33RDAVCNFSM6AAAAABFFZ2MUOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYDINBTGE3DIMA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thank you for everything you're doing to help save these cats' lives!

Alright -- I think it should be fixed now.  Let me know if there's any
other issues.
I hope you and your cat are doing well!
Cheers,
Jeff
On Sun, Mar 24, 2024 at 9:26 AM rissyroo626 @.***>
wrote:

Thank you for everything you're doing to help save these cats' lives!
—
Reply to this email directly, view it on GitHub
https://github.com/JKesslerPhD/FIPInjectionLogger/issues/60#issuecomment-2016860718,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3GD4E5NO4A2SEFF4V3YCLYZ35DDAVCNFSM6AAAAABFFZ2MUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWHA3DANZRHA
.
 That was so fast! Thank you. And Cookie is doing really well so far. It's a miracle thanks to everyone, like yourself, who has helped us to get all of these life-saving resources.


DB2 slowness exporting to CSV

Hi
I'm running a complex query in DB2 10.5, that at the end generates around 45 rows. When exporting the results to CSV, the export wizard takes a long time to complete, I was expecting this to take no more than a few seconds, but it took more than 6 minutes, is it running the query again?
Dbeaver is 3.7.7, system is Windows 7 32 bits, and file is exported to a local dir.

exporting the results to csv runs the query again

Any option to avoid DBeaver to run the query again?

I edited my comment above perhaps before you saw the second part of my response so I'll just repeat what I have above
If you don't want to run the query again you can copy/paste the results into an excel/csv file

Thanks for your answer.
Anyway, it would be a nice feature to allow exporting the results to file, instead of copy&paste them, as the wizards allows several formats of exporting the data.

Another question related to the above.
Would it be possible to directly run an extraction, without need to run the query first, and exporting later?
Thanks in advance!

You can execute query just once:
SQL editor context menu->Execute->Export from query (query under cursor will be executed).

Thanks Serge
That was exactly what I was expecting to find, I didn't realize it was possible through the context menu.
Thanks!


remove darkmode, unify public servers button styling, fix emote menu …

…arrow flipping the wrong direction

I believe this was manually integrated into restructure, please correct me if I'm wrong


[SU-106] Add option to silence expiring NIH access notification

To access some controlled datasets/workspaces, you can link an NIH account to Terra.
This link expires after 30 days. Starting 24 hours before the link expires, we show a notification that the link is about to expire or has expired every time Terra loads (every new tab, every refresh, etc). Feedback from users has been that the frequency of the notification is annoying, especially considering that we don't currently provide an option to un-link an NIH account to stop the notifications after the link has expired.
This adds a "Do not remind me again" button to these notifications which prevents showing the notification again (unless an NIH account is re-linked and the expiration time changes).

To mock an expiring link, edit these lines in auth.js:
https://github.com/DataBiosphere/terra-ui/blob/610c415f43526eb5dd36645abcdde11946d36605/src/libs/auth.js#L241-L242
authStore.update(state => ({
  ...state,
  nihStatus: {
    linkExpireTime:<PHONE_NUMBER>,
    linkedNihUsername<EMAIL_ADDRESS>  }
}))

The linkExpireTime is an epoch timestamp. For example, to mock an NIH link expiring in 12 hours, linkExpireTime would be set to the result of Math.floor(Date.now() / 1000) + 12 * 3600.

Rebased to pull in fixes for data catalog tests in #3071.


fix: remove +1s in bitbox page offset calculations

alternative to #281
We originally allocated an extra page in bitbox as a meta page. Now that metadata is handled elsewhere, we no longer need this extra page.

#290  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rphmeier and the rest of your teammates on  Graphite


slimJar task does not include slimjar.json or slimjar-resolutions.json files in CI/CD (Github and Jenkins)

Hello! I hope you're staying well.
I've been trying to use slimjar in my CI/CD processes, but the resulting jar from both GitHub Actions and Jenkins seems to be missing the slimjar JSON files, the jar file in downloads coming from here:

Whilst I am building with JBR 17 on Windows 11 on my main PC, the Github action provided uses Temurin 17 on Ubuntu 22.04.2. There's a bit more detail in the GitHub Action itself. Slimjar v1.5.4 should be in use.
Is there something wrong with what I'm doing?

Hey sorry i seem to have somehow missed seeing this, try adding this into your build file: kotlin tasks.shadowJar {     from(tasks.slimJar.outputDirectory) }
I'll eventually finish version 2 which will fix this, but i just don't have the time for it currently

Hey, it's fine, no worries! I've been busy myself.
It helps on the second run in my environment which is an improvement, since the files are already in the slimjar folder. However, when generating the files for the first time or after deleting them, they are not included in the final jar, which is the main issue I'm having.

might be a issue with task dependency, is your ci running something not isn't the standard build tasks, if so try adding a dependson for slimjar

Nope, just running slimJar. From the latest run: https://github.com/Niestrat99/AT-Rewritten/actions/runs/5811268286/job/15754103179

I'll be honest i really have no clue.
That latest run seems to be working so is it just that other ci task that wasnt?

As in the jar file runs? That would be because I added an extra task to force in the JSON files after the build finishes:

It's really weird, the isolated jar gets added to the final build, but doesn't end up in any of the resources folders, I thought it would've been but it doesn't seem like it.

Ah I see, I'll do some messing around later to see if I'm able to find anything, not too confident in my java/gradle anymore though, haven't written in over half a year since I moved to rust.

I believe there was a specific reason for that order, but if its picking up the shadowJar task even as it runs after i think that will work for the reobf too, please make the pr and ill merge it, ill do some testing with a reobf task at some point and see if that works too, sorry for basically forgetting to look into it, being swamped with work.

It's fine, don't worry, figured that would be the case so wanted to take some of the load off from you. 😄

version 1.6.1 has being published and pushed to the gradle repos


⚠ ClamAV has degraded performance

In ec4a6f7, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 66 ms

Resolved: ClamAV performance has improved in f2255a3.


Using modelmapper 2.3.8 with java.lang.ClassNotFoundException

I am running with org.modelmapper:modelmapper:2.3.8 from Maven Central at https://search.maven.org/search?q=g:org.modelmapper
When I attempt to run the ModelMapper inside an assembler (see below),
`public class AccountAssembler implements DtoEntityAssembler<AccountEntity, AccountDto> {
private static final AddressAssembler addressAssembler = new AddressAssembler();
private static final PhoneAssembler phoneAssembler = new PhoneAssembler();
public AccountEntity toEntity(AccountDto account) {
ModelMapper mapper = new ModelMapper();
mapper.createTypeMap(AccountDto.class, AccountEntity.class)
.addMapping(AccountDto::getAccountId, AccountEntity::setAccountId)  // Integer
.addMapping(AccountDto::getAddress, AccountEntity::setAddress)
.addMapping(AccountDto::getBookerAccountKey, AccountEntity::setBookerAccountKey) // String
.addMapping(AccountDto::getEmail, AccountEntity::setEmail) // String
.addMapping(AccountDto::getKey, AccountEntity::setKey) // String
.addMapping(AccountDto::getMap, AccountEntity::setMap) // String
.addMapping(AccountDto::getName, AccountEntity::setName) // String
.addMapping(AccountDto::getWebsite, AccountEntity::setWebsite); // String
return mapper.map(account, AccountEntity.class);
}
public AccountDto toDto(AccountEntity account) {
ModelMapper mapper = new ModelMapper();
mapper.createTypeMap(AccountEntity.class, AccountDto.class)
.addMapping(AccountEntity::getAccountId, AccountDto::setAccountId)
.addMapping(AccountEntity::getAddress, (dest, v) -> dest.setAddress(addressAssembler.toDto((AddressEntity) v)))
.addMapping(AccountEntity::getBookerAccountKey, AccountDto::setBookerAccountKey)
.addMapping(AccountEntity::getEmail, AccountDto::setEmail)
.addMapping(AccountEntity::getKey, AccountDto::setKey)
.addMapping(AccountEntity::getMap, AccountDto::setMap)
.addMapping(AccountEntity::getName, AccountDto::setName)
.addMapping(AccountEntity::getWebsite, AccountDto::setWebsite);
return mapper.map(account, AccountDto.class);
}
}`
I get the following root cause in my stack trace:
Caused by: java.lang.ClassNotFoundException: sun.reflect.ReflectionFactory not found by modelmapper [18]
I am using the Apache Felix framework. From my research, I understand that the sunb.reflect is not publicly available. I don't know how to work around this currently. Are there any ideas?
I am currently running Java 8 and want to upgrade to the most recent Java version at a future time. I will remain running within a Java framework like Felix or similar.
Any ideas how to get around this would be greatly appreciated.

I think this issue is related to this one: https://github.com/modelmapper/modelmapper/issues/426

Can you check if latest modelmapper can reproduce this issue? Thanks!

I am not the thread owner. Nevertheless I cannot reproduce the issue in the latest release (2.4.0). I was able to completly remove the jdk.unsupported attribute.
Thank you!

Thanks for the feedback! I will close the issue. Please feel free to reopen this issue or create a new one if this issue was still reproducible.


[CI] Remove files that related to .travis.yaml

Is your feature request related to a problem? Please describe.
Since Travis disabled from https://github.com/Azure/azure-cli/pull/11442/ and run parallelly with ADO for a while.
Should remove those uncessary files.
Describe the solution you'd like
Delete those files memtion in .travis.yaml but not in ADO.

scripts/ci/build_droid.sh
scripts/ci/publish.py
scripts/ci/publish.sh
.travis.yml

Describe alternatives you've considered
None
Additional context
None

As a follow up of https://github.com/Azure/azure-cli/pull/11442


Add focus mode to avoid notifications while work.

Description of the new feature / enhancement
Just like apple iOS focus mode. Please recreate it for windows users as well
Scenario when this would be used?
This can be quite useful. It helps you concentrate on your work without getting distracted
Supporting information
No response

Windows already has a focus mode with several settings. Is that what you need or something more specific?

No. Thanks for telling...😊

here is mine:

in settings you can also tweak this


Errors from incorrect settings files are not actionable

The errors from Script Analyzer when there is an error in a setting file are not actionable. There is nothing in $error, $stacktrace, etc. This error should be returned as a terminating error, not a warning - and should include the reason that the settings file was broken.
12 [C:\Users\leeholm]
>> '@{ Blah = $true }' > c:\temp\settings.psd1

13 [C:\Users\leeholm]
>> Invoke-ScriptAnalyzer -Path C:\temp\test.ps1 -Settings c:\temp\settings.psd1
WARNING: Cannot parse settings. Will abort the invocation.

Yes, I can confirm that and have run into this issue as well in the past.


Add types-PyYAML to requirements-dev

🗣 Description

Add types-PyYAML to requirements-dev
💭 Motivation and context

During testing it was discovered that types-PyYAML was missing from requirements-dev
causing mypy issues
🧪 Testing

After adding types-PyYAML to requirements-dev.txt, mypy --install-types src/ runs cleanly

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All new and existing tests pass.

Coverage: 100.0%. Remained the same when pulling e181f6001eded9da876e10e0f14f44ffbcfbafa0 on improvement/update_requirements into 4e6df6eb4d7527ca22e43f6fafcbba30ec88c710 on develop.


Syntax colorimetry problem

Hello,
I've downloaded the latest version of the PhPStorm plugin (0.6.3).
The plugin recognizes Alpine.js directives, but when I make changes to my code, an error systematically appears that distorts/blocks the syntax colorimetry of the code.

My PHPStorm version :

Same here, it is caused by the plugin on complex blade files.  I have to work on an other IDE during the fix time of the dev (if it gets fix)

I just submitted v0.6.4 for review, which should address some performance issues. Please let me know if the issue persists after updating!

@inxilpro Hi, I still have a lot of bugs.

@joffreypersia can you post a gist of a blade file that triggers errors?

Oh, I just saw that you opened a new ticket. Perfect, thanks!


BUG: Incorrect decoding db-name which contains a dot-character ('.')

Hey!
Have been trying your CodeIgniter 3.0 and found a bug in the program.
I don't have enough time for seeking a reson, but I can tell you next:

I have a DB, which name contains a dot: e.g. dbname.local
I had pasted this db-name into my /application/config/database.php file into the string
$db['default'] = array(..., 'database' => 'dbname.local', ...); and my application still had been working.
Next I tried to make a hook like that:

$hook['post_controller_constructor'] = function() {
    $global_instance =& get_instance();
    $global_instance->load->library('migration');
    if ($global_instance->migration->current() === FALSE) {
        show_error($global_instance->migration->error_string());
    }
};

And i had had an error on line $global_instance->load->library('migration');

Than I found, that the error was occured at this part of your code in file /system/libraries/Migration.php, when system was trying to make new table in my DB.

		// If the migrations table is missing, make it
		if ( ! $this->db->table_exists($this->_migration_table))
		{

Next I have changed the DB-name on SQL-server and in config, and in started working.

Schema objects must follow MySQL guidelines:
http://dev.mysql.com/doc/refman/5.7/en/identifiers.html
A "." in an object name is not to standard.

As I can see, MySQL guidelines says that dot-character is allowed:
Permitted characters in quoted identifiers include the full Unicode Basic Multilingual Plane (BMP), except U+0000:
ASCII: U+0001 .. U+007F
Extended: U+0080 .. U+FFFF

In Unicode dot-character has code U+002E, which falls in the specified range of permitted characters  U+0001 .. U+007F.
Guideline says, that this character is allowed for quoted identifiers, but I think it is framework's area of responsibility, not developer's.

You're right, my apologies.

This is pretty much a duplicate of #2755.
What MySQL or another datatabase allows and what CI allows are different things. CI makes some assumptions and one of them is that you use dots and commas to separate identifier names. In 99% of the time, that's the case and the effort to support a different case is not worth it.


Dotnet code coverage

Why does the test workflow exit with code 1 when all tests have passed?

Because of the xamarinios10 build target that dotnet test does not support.

Because of the xamarinios10 build target that dotnet test does not support.

Could we switch the agent to macos-latest, run msbuild before the test step, and add --no-build to the test step? It seems to work fine locally for me.

https://github.com/microsoft/setup-msbuild


ERROR: LoadLibraryEx() failed to load wslapi.dll

See title, I get this when I run the .exe.

I'm seeing this LoadLibrary error when I build the Launcher from source:
ERROR: LoadLibraryEx() failed to load wslapi.dll

I'm on `Windows 10 Enterprise, version 1809" OS Build "17763.292".
I built from a visual studio 2017 command prompt with:
cl /nologo /O2 /W4 /WX /Ob2 /Oi /Oy /Gs- /GF /Gy /Tc main.c /Fe:Launcher.exe Advapi32.lib Shell32.lib
main.c

If I use the launcher from here: https://github.com/yuk7/wsldl/releases/tag/19022600
I get don't get the dll LoadLibrary error, but I do get this error:
The specified network name is no longer available.

By the way wsl is also enabled and I can launch other distros.

Update.  I built in an x86 visual studio 2017 command prompt and load library error was resolved.  I'm going to see if there's a way to load wslapi.dll from a 32-bit program.

Oh...really?
In 32bit mode, wslapi.dll should normally not exist ...🤔

Oh I meant to say I was originally building in a x86 command prompt, but after switching to x64 it resolved the load library issue.

I understood.
Thanks.


Update readme.md

Added example on using container builder.

I think it's even cleaner to do
container.Update(builder => builder.RegisterType<MyImplementation>().As<MyInterface>());

Nice! I didn't know I could do that

Thanks :heart:


Multiple embedded form in a Bundle with separate layout for each

Hi Guys,
There is any way to have multiple embedded forms(https://github.com/oroinc/platform/tree/2.3/src/Oro/Bundle/EmbeddedFormBundle) in a bundle with separate layout for each?
All embedded forms are used embedded_default/oro_embedded_form_submit as theme/route, therefore if
I will define a layout for one form, for example as in docs,
layout:
    actions:
        - @move:
            id:        embedded_form_email
            siblingId: embedded_form_firstName
            prepend:   true                     # place moved block before sibling

    conditions:
        @eq:
            - $context.embedded_form_type
            - 'acme_demo.form.embedded_form' # form type name in container

I can't defined another layout for another form in same Bundle.
Theme is hardcoded https://github.com/oroinc/platform/blob/2.3/src/Oro/Bundle/EmbeddedFormBundle/Manager/EmbedFormLayoutManager.php#L70
Route name is taken from a request https://github.com/oroinc/platform/blob/2.3/src/Oro/Bundle/LayoutBundle/Layout/Extension/RouteContextConfigurator.php#L38
Refactor the logic for some form looks dirty.
How can I solve this in a clean way?
I know about Oro\Bundle\EmbeddedFormBundle\Form\Type\CustomLayoutFormInterface, but it was marked as deprecated and implementation Oro\Component\Layout\LayoutUpdateInterface in a FormType won't take any effect.
Thanks!

For my project I've solved the following way:
Create a empty layout and move all views into a view of form type.


Update Restic documentation for RancherOS

For #1347
Signed-off-by: Imran Pochi<EMAIL_ADDRESS>

@kmova @nrb , can we agree upon the docs  and close this ?


[ST] Linea router not bidding

Describe the bug
There's enough liquidity on linea side, but nobidsreceived
Link to ticket in discord
https://app.intercom.com/a/inbox/qge2vd8z/inbox/admin/7089273/conversation/578?view=List
Additional context
https://connextscan.io/tx/0x91e55727bd3dca0a04d42f15b6b8e26406e7c975f1fa5b00d31b53215437578f?_gl=1*11yj794*_ga*MTQzNzM4ODY1Mi4xNzEzMzU4ODQ0*_ga_MPYZEDRVQ0*MTcxMzM1ODg0NC4xLjEuMTcxMzM1ODg5NS4wLjAuMA
@oncall

Yeah the router is down again:

router address: https://connextscan.io/router/0xc770ec66052fe77ff2ef9edf9558236e2d1c41ef
Last tx bidded (Apr 16, 2024 21:54:32 PM): https://connextscan.io/tx/0x2e58d6aa9a3364238a0cad63714cb4ed54ec9dfb6b8022ac8cd15d3dd280a76a

Duplicate

Do you mean is duplicated bc of this issue?
The router came back to life and then rip again like 16 hours ago.
Also, there is another Linea router down (more than 24 hours ago)
https://connextscan.io/router/0x58507fed0cb11723dfb6848c92c59cf0bbeb9927


overcome SSL issue SNI

getting SNI errors for WSS otherwise
raise ValueError("check_hostname requires server_hostname")

I rewrote this PR to not overriding the options in constructor, and works for all implementations of clients.


Option To Disable Extension Pack Recommendations

When opening certain file types (ie. C++ > .cpp) VSCode is now recommending extension packs. I do not want this or need this. I don't mind VSCode offering suggestions for a file type I don't have an extension for currently, but these packs are overkill and unwanted. Every time I open VSCode and open a .cpp file, as an example, I get recommended a C++ pack with a handful of Microsoft-specific things.

See https://github.com/microsoft/vscode/issues/136301#issuecomment-958201119

I am asking for the option to never see said popup to begin with. Having to do this every time it wants to pop up is not ideal.
Having a setting to just disable pack recommendations altogether is the goal.

Looks like it may already be possible to disable all recommendations:
"extensions.ignoreRecommendations": true

As I said in the main post, I don't mind VSCode recommending extensions for unknown/unhandled file types, that is fine. I just don't want 'extension pack' recommendations. Especially if I have something handling the file already.

Especially if I have something handling the file already.

Can you please mention which extensions you already installed for the file type VS Code is recommending extensions?

So far the two I've noticed have been:

.cs (C#)

Gets recommended the C/C++ pack at random. Does not seem to have any consistent reason but is what is suggested.

.h, .hpp, .c, .cpp

Gets recommended the C/C++ pack.

In both cases, I already have extensions installed to handle these file types. Both of which are the Microsoft offered language support said languages.

C# -- https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.csharp
C/C++ -- https://marketplace.visualstudio.com/items?itemName=ms-vscode.cpptools

Along with some other additional helper extensions for each language.

Thats bizarre. The extension pack ms-vscode.cpptools-extension-pack that we recommend for C/C++ includes 13 extensions. It seems, we check for the existence of this extension pack and if it does not exist, we recommend this pack even if user has ms-vscode.cpptools extension installed. There are two problems here:

IMO this extension pack includes too many extensions for language recommendations
If we want to recommend an extension pack then it shall be configured with a primary extension and we shall not recommend the pack if user has this primary extension installed.

CC @isidorn @chrisdias

@WardenGnaw @bobbrow might you have more context why the C++ extension pack has so many off topic extensions. LiveShare? Doxygen documentation generator?
@sandy081 we could also just say we do not recommend an extension pack if at least one of the extensions from the pack is installed. That would also motivate extension packs to be lean.

Adding @sean-mcmanus @michelleangela who helped published the cpptools-extension-pack and might know why each extension is included in the extension pack.

In the C++ extension pack, these are the C++-specific extensions:

"ms-vscode.cpptools",
"ms-vscode.cpptools-themes",
"twxs.cmake",
"ms-vscode.cmake-tools"
"cschlosser.doxdocgen" (addresses a common feature ask for C++: https://github.com/microsoft/vscode-cpptools/issues/5683)
"jeff-hykin.better-cpp-syntax"

These are the extensions that aren't specific to C++ (Remote Development, GitHub PR & Issues, LiveShare)

"ms-vscode-remote.remote-wsl",
"ms-vscode-remote.remote-containers",
"ms-vscode-remote.remote-ssh",
"github.vscode-pull-request-github",
"ms-vsonline.vsonline",
"ms-vsliveshare.vsliveshare",
"ms-vsliveshare.vsliveshare-audio"

The reason we included the remote development pack is that most C++ developers are targeting multiple platforms, and many C++ customers we talk to are drawn to VS Code over other C++ IDEs/editors specifically for the remote capabilities.
We included GitHub PR & Issues and LiveShare to support collaborative C++ development scenarios.
FWIW, I've been monitoring how many customers uninstall each of the extensions in the extension pack. The numbers are pretty consistent across the board -- i.e. there aren't more customers uninstalling LiveShare than cpptools. There are actually slightly more customers uninstalling cpptools than LiveShare (after installing the C++ extension pack).
That being said, I'm open to removing some of the non-C++ specific extensions based on this feedback and two reviews we've gotten for the extension pack complaining about LiveShare. My vote would be to keep the remote development extensions because I think they're super relevant for C++ developers.
I also agree that we should not recommend the C++ extension pack if cpptools is already installed!

I'm happy to see this is being discussed, but we're kind of moving away from my actual point/intent with this feature request.
I'd like the option to disable VSCode from recommending 'extension packs'. I don't want these packs.
I do not mind if VSCode recommends me a specific individual extension for an unhandled file type like it worked before, but I do not want packs recommended.

@jureid thanks for providing more details. My feeling is that users are not motivated enough to uninstall extensions, they are also not sure if something will stop working. Thus the uninstall numbers are not strong.
Since VS Code tries to be minimalistic in nature, I suggest that we also try to keep our extension packs lighter weight.
If you would like to keep the remote development since they are relevant for C++ devs that makes perfect sense for me. However as you suggest I would remove the the non C++ specific extensions.
@sandy081 removing extensions from an extension pack will have no effect on the users that already installed the extension pack in the past (those extensions will not get uninstalled right)? Just double checking.
And as I mentioned above I think this simple heuristic "we do not recommend an extension pack if at least one of the extensions from the pack is installed" would solve @atom0s problems since we do not want to stop recommending extension packs in general.
Thanks

since we do not want to stop recommending extension packs in general.

I am having a hard time understanding why this is such a problem to request that this be able to be turned off. I am not saying this needs to be removed, and I'm not saying this feature request needs to be default-on. Add the option, leave it off by default, let me manually opt into it. Just like how the setting for recommended extensions is already.
It's odd to me that there is an option for general extension recommendations, but it's for some reason a big deal to add another (or even extend the existing option) to have the choice to disable pack recommendations.
So again, my suggestion is:

Add an additional settings option to 'ignore extension pack recommendations'.

This can be off by default. This can be fully manually opt-in. I don't mind.
I just would like to have the ability to not get recommended things I don't want.
You could even make the existing option have multiple choice options such as:

Disable all extension recommendations. (Which would disable single and pack recommendations.)
Disable pack recommendations. (Leaves single per-file-type recommendations enabled. Disables packs.)
Disable non-pack recommendations. (Leaves pack recommendations on, disables individual recommendations.)

@atom0s this is a fair request, but not something we would do immediately until we get more user feedback.
We will first fix the issue we outlined above before adding this.
Thanks for your feedback!

Well here's your user feedback from a fellow VSCode user with the same issue: please allow us to disable the recommendations.
No-one has an issue with how Extension-Packs for right now (except for the whole VSCode developer team internally it seems). But please try to be a tiny bit enduser-first here - all we ask for is a checkbox (which would be off by default) reading "don't show recommended extensions" and done.
Doesn't need a gigantic redesign of your whole Extension ecosystem.
You completely blew the OPs issue out of context and created a different issue from it that should rightfully be tracked in a separate issue while the original request is being dealt with.

all we ask for is a checkbox (which would be off by default) reading "don't show recommended extensions" and done.

@Shirk this already exists as a setting:
"extensions.ignoreRecommendations": true

Or did you mean to write that you want to have extension recommendations but not extension pack recommendations?

removing extensions from an extension pack will have no effect on the users that already installed the extension pack in the past (those extensions will not get uninstalled right)? Just double checking.

Yes, we do not uninstall extensions if they are removed from the pack.


AttributeError

After py deep_q_network.py:

AttributeError: module 'tensorflow' has no attribute 'InteractiveSession'

Then pip install --upgrade tensorflow==0.7
It returns:
ERROR: Could not find a version that satisfies the requirement tensorflow==0.7 (from versions: 2.2.0rc1, 2.2.0rc2, 2.2.0rc3, 2.2.0rc4, 2.2.0, 2.3.0rc0, 2.3.0rc1, 2.3.0rc2, 2.3.0)

ERROR: No matching distribution found for tensorflow==0.7

How can I run this?

Hey @Setembru I think as it's a very old repository does not update regularly.
so try with tensorflow>=0.7

Add this two lines. It resolved the issue.
import tensorflow.compat.v1 as tf
tf.disable_v2_behavior()


@sljmn Sorry for not responding sooner. I was planning on adding it next time I update it. Has this already been added in Nova by default now? If it hans't I'll be happy to add it.


[Feature request] Encrypt secret key on local storage

It is not clear to me if the secret keys are encrypted on the device local storage and decrypted when the apps starts, can you please state on this?
If not done, I strongly suggest that all TOTP secret keys are encrypted, even without entering a password or checking 'authentication required' (like Signal Messenger does for example).
This way, no hacker is able to read the configuration file and retrieve the secret keys.
I think it is very important for a security app.
I put this separate of issue #128 because that one is done for exports encryption which is something else, although still important.

Android isolates app's private storage, so no app can see other app filles. Except in case there is root access ofc, but it's generally impossible to protect something from root
Also, Android has OS-level disk encryption (force enabled by default in modern versions)
I think there is no need to encrypt already encrypted and strongly isolated app's private storage

Agreed that app storage is more or less secure for a reputable device manufacturer. I think at least the exported token should be encrypted since those are in shared storage.

Thank you @PhilKes for this link to issue #214 and new feature, this is exactly what I meant and wanted to have. Great job done, thanks a lot!
If possible, I would still like to see a password authentication when I open FreeOTPPlus, still also keeping the PIN authentication which is very nice, and that we can choose the method when we enable the authentication. Maybe I will open another feature request for this as most of the work is now done and it is probably a quite little thing to add.
I saw that there are two comments from @ShellCode33 on ticket #214 that seem to be very pertinent ("your AES implementation is flawed" and 600000 iterations), but they have been added after the commits of the solution for #214. Do you know if those comments can be addressed ?
It seems important security wise.


Refactor spec for have_http_status.rb

What are the proposed changes?
Refactor the spec file – eliminate needless and painful repetition to simply reading and understanding the spec.
Checklist:

New behavior is covered by tests and all tests are passing - well at least the changes i made are passing. this is my first pull request to rspec so i'll probably need some pointers.
No warnings (that I'm aware of) results from changes to the spec files.
There are no changes to the documentation.
Can confirm: Rubocop passes (e.g. bundle exec rubocop lib).
I've squashed all the commits to just one commit.

hi folks it's failing on some code pertaining to the mailer - amongst other things - but i haven't touched that code. Some advice on how to get it to pass would be much appreciated.

Sorry this doesn't make things more readable at all, not all repetition is bad, the fact you had to add conditionals to make this work shows that its not as repeated as you think.
Additionally there has been work over in #1951 which will supersedes this so its not worth continuing right now. After #1951 is merged if you think there are improvements that can be made by all means open another PR based off the result of that.


OCPBUGS-30095: Bump kubernetes.core to v2.4.2

Update the release/ansible/requirements.yml file to use kubernetes.core v2.4.2
Update the scaffolded requirements.yml file to use kubernetes.core v2.4.2
Run the release/ansible/update_collections.sh script to update the vendored collections
Delete the old kubernetes.core info directory created by the previous update.

/retest

/jira refresh

/retest

/label docs-approved

/lgtm
/label px-approved
(this is just a bump and shouldn't require a change in experience for the user)

/label qe-approved

/cherry-pick release-4.15


Implement support for DBGp Proxy servers

As documented here:
https://xdebug.org/docs-dbgp.php#just-in-time-debugging-and-debugger-proxies
Defines two new config parameters:

proxy_host (default '')
proxy_port (default 9001)

If both options are non-empty, the Connection class does a few new things at the beginning and end of our session.
New workflow when using a proxy is:

VIM listens for debugger connections on local IP and port X (default=9000) like always
VIM makes a connection to the proxy server on port Y (default=9001)
VIM sends a "proxyinit" command, which includes ide_key and the port we are listening on (X)
Proxy registers our IP/port with our ide_key and sends an XML response
VIM processes the XML response and disconnects
VIM starts the usual 20s wait for debugger connection
debuggers are all hard-coded to connect to the proxy for debugging sessions
If a debugger connection comes into the proxy (before the VIM timeout) with our ide_key, the proxy will connect back to us on port X and copy all data back and forth between VIM and debugger.  This connection is indistinguishable from a regular debugger connection (except originating from the proxy IP instead of the remote host IP).
When we are done, VIM makes another connection to proxy port Y and sends a "proxystop" command to un-map our ide_key

Just wanted to comment that I have used this pull-request successfully.

Due to the big changes within vdebug I can't quickly tranform this to v2 compatible code, so I'll move it to 2.1

Superceded by #511


Add coal distribution to progen

About the PR

Fixes distribution of coal in proceduraly generated environments
Fixes #22753
Fixes #22751

Why / Balance
Coal wasn't being generated in most scenarios locking the production of Steel.
Technical details
I'm 95% sure I found all the instances in the code for this. Do let me know if I missed something.
Media
n/a

[x] I have added screenshots/videos to this PR showcasing its changes in-game, or this PR does not require an in-game showcase

Breaking changes
n/a
Changelog
Make sure to take this Changelog template out of the comment block in order for it to show up.
:cl: Velcroboy

fix: Fixed coal not generating!

Needs a sprite please

😫I was hoping I cold get away without that 🙃

I'm pre sure where the other sprites came from have spare overlays that can be used still.

I'll check it out. Meanwhile these tests are blowing up

OK, added the sprite.


Add support for minItems constraint in example-compiler

Also fixes an issue where a number constraint is applied on the array. The constraint for the should be on the type inside the array, not on the array schema.

👍 thanks


Update momentum.py

fixed a typo in the documentation

Can one of the admins verify this patch?

I signed it!


fix: overlap in breakpoints

FX-3999
Description
This pull request fixes the overlap in breakpoints media queries that was causing ambiguity when detecting breakpoint ranges.
Taken from https://github.com/toptal/picasso/blob/a9e8c9189dc7a11ddb159f3c08eddffa081a1e2f/docs/decisions/13-breakpoints.md#proposal:
...
// Breakpoint ranges
xs:  0-479px
sm:  480-767px
md:  768-1023px
lg:  1024-1439px
xl:  1440px+
...

How to test

All checks should pass

Development checks

[x] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[N/A] Make sure that additions and changes on design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[x] Annotate all props in component with documentation
[N/A] Create examples for component
[N/A] Ensure that deployed demo has expected results and good examples
[x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
[x] Covered with tests

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-anvil ping reviewers


Removed go-ns/rchttp dependency from vendor.json. No reference in project

What

go-ns/rchttp removed from vendors.json

go-ns internally has dependencies with go-ns/rchttp, so it was not physically removed from vendors folder.

no dependency found with go-ns/rchttp in the dp-code-list-api code.

How to review
validated that the code builds, the unit tests pass, and the REST interface works.

➜  dp-code-list-api git:(feature/update-references-to-rchttp) ✗ make build
go build -o build/darwin-amd64/./dp-code-list-api cmd/dp-code-list-api/main.go
➜  dp-code-list-api git:(feature/update-references-to-rchttp) ✗ make test
go test -cover github.com/ONSdigital/dp-code-list-api/api github.com/ONSdigital/dp-code-list-api/cmd/dp-code-list-api github.com/ONSdigital/dp-code-list-api/config github.com/ONSdigital/dp-code-list-api/datastore github.com/ONSdigital/dp-code-list-api/datastore/datastoretest github.com/ONSdigital/dp-code-list-api/models
ok  	github.com/ONSdigital/dp-code-list-api/api	(cached)	coverage: 60.3% of statements
?   	github.com/ONSdigital/dp-code-list-api/cmd/dp-code-list-api	[no test files]
ok  	github.com/ONSdigital/dp-code-list-api/config	(cached)	coverage: 75.0% of statements
?   	github.com/ONSdigital/dp-code-list-api/datastore	[no test files]
?   	github.com/ONSdigital/dp-code-list-api/datastore/datastoretest	[no test files]
ok  	github.com/ONSdigital/dp-code-list-api/models	(cached)	coverage: 11.5% of statements

Who can review
anyone

Update: make test was not working with go version 1.12 or 1.13. In the second commit I updated the vendor versions for goconvey and gls, using the same as the ones used in revendor PR
Now make test works as expected with go 1.12 and 1.13

added back go-ns/rchttp dependency into vendors.json


Updates wording for Automated PR to stable

@rshriram PLease let me know if the wording works for you.

istio-testing/presubmit passed


No suitable appstore was found

Hi!
First of all, I must say, this is an amazing work you've done. It's first of its kind, integrating in-app billing with Kivy. Thanks for keeping it open-sourced.
After tweaking few bits and giving a Config.java file, I'm able to run the app but now it's showing up an issue saying finishSetup() === SETUP DONE === result: IabResult: 3, No suitable appstore was found (response: 3:Billing Unavailable) Appstore: null.
I already searched about this but none worked for me.
Now, I know that you should not be concerned about this because it has something to do with OpenIAB itself and I should not be asking this here but I already checked their issues related to this and their discussions were not quite helpful for me plus it's hardly that anyone else would understand because it's done using python and so many would simply reject in the name of "off-topic" or "We don't officially support that".
Any help or direction regarding this would be very helpful.
Thank you!

Okay, that wasn't an issue at all. It was showing this error because I was running this app for testing and so it could not find an appstore.
Installing the app using adb install -i com.android.vending path/to/apk let's you test the in-app billing feature. However you may see that the clicked item is not available for purchase and that's because for it to allow purchasing, the app needs to be published on the play store.


Print locking broken on Mac OS 10.15.7 with no user password

Hey guys I used this command using the latest qpdf to encrypt and block printing
qpdf --encrypt "" ownerspass 128 --print=none -- input.pdf --replace-input
my file names are in this format
generated-preview-2021-07-12T14-31-48.250Z.pdf
The print locking has worked everywhere else I tested but not on this slightly older version of MacOS, any ideas?

This would be a bug in whatever software you are using on the older version of MacOS and is most likely not related to qpdf. I'm going to close this, but feel free to reopen if you have any questions. The next release of qpdf will have a chapter in the manual that describes the ins and outs of exactly what the various encryption flags do internally to the PDF file and why PDF readers are so varied in how they respond.


Upgrade hyper to 0.10

This avoids versioning conflicts when combined with other crates (e.g., git2 and slack-hook); seems like none of the breaking changes in 0.10 affect afterparty.

Oh, sorry, I overlooked #24 (although that fails to build). I guess this PR can be closed if #24 merges.


Incorrect Hadamard visualisation trace

The Hadamard gate is a rotation around X+Z, the trace of this tool shows it moving directly from |0> to |+> and when applied again, the trace goes to |1> and then back up after a quarter turn. It should be a circle on the surface of the bloch sphere and not go into the other hemisphere.
First application of H

Second application of H

Expected result

Thank you very much for this bug report. I fixed the Hadamard gate to perform a rotation around the x+z axis.


Create function to update for all HISTORY_ variables

Would be similar to other netcdf functions, or likely even use them. When iterating a file, need to add to N_HISTORY dimension, and update all associated variables:

HISTORY_INSTITUTION
HISTORY_STEP
HISTORY_SOFTWARE
HISTORY_SOFTWARE_RELEASE
HISTORY_REFERENCE
HISTORY_DATE
HISTORY_ACTION

Completed within #58.


manifest.json does not include assets

Describe the bug
Statically imported assets (SVG file in my case) will get bundled and created in the outDir, but are missing in the generated manifest.json.
vite.config.js
import { defineConfig } from 'vite';
import legacy from '@vitejs/plugin-legacy';

export default defineConfig({
    base: '/static/',
    publicDir: 'assets/static/',
    build: {
        manifest: true,
        outDir: 'public/static/',
        assetsInlineLimit: 0,
        rollupOptions: {
            input: 'assets/main.ts',
        },
    },
    plugins: [legacy()],
});

assets/main.ts
import './icon.svg';

manifest.json
{
  "assets/main-legacy.ts": {
    "file": "assets/main-legacy.dd90b2c6.js",
    "src": "assets/main-legacy.ts",
    "isEntry": true
  },
  "assets/main.ts": {
    "file": "assets/main.9470b65c.js",
    "src": "assets/main.ts",
    "isEntry": true
  }
}

output files

main.9470b65c.js
main-legacy.dd90b2c6.js
icon.a0d73e22.svg

System Info

vite version: 2.0.5
Operating System: Windows 10
Node version: 12.16.1
Package manager (npm/yarn/pnpm) and version: npm 7.5.3

It seems this happens when using the legacy plugin. Removing the legacy plugin resolves the issue. In addition, I noticed when setting build.cssCodeSplit: false there wont' be any CSS files generated if the legacy plugin is used.

repro repo: https://github.com/thasmo/vite-2375
Anything else I can provide? Thank you!

I have encounter same question.
use build.cssCodeSplit: false would miss css in the manifest.json

It seems with the latest<EMAIL_ADDRESS>version, even without the legacy plugin, the issue now pops up. Statically imported images will not show up in the generated manifest.json.
I realize that this behavior is probably something which is not needed in modern, JS-based (PWA) applications, but in our case, when using vite in a more classic backend-rendered (PHP) application, not having all imported assets in the manifest.json file, results in not being able to render/access those assets in the first place.
Is there any chance it would be considered for vite to list all imported assets in manifest.json for this reason? Thanks a lot!

@Shinigami92 Would you be okay with removing the plugin: legacy tag as I think the issue now also occurs without it? Thanks!

Am also seeing this behavior (Vite 2.4.3). With a plain vanilla create-vite repo with zero plugins, imported CSS, JS, font, and image files. All were generated with hashed file names, but only the CSS and JS files were mentioned in manifest.json.

Also seeing this, and like @thasmo we're using Vite in a hybrid approach where once build a PHP back-end takes over. The files are indeed copied to the dist directory (in our case, we run them through imagemin), but are missing from the manifest.
vite.config.js
import { defineConfig } from 'vite'

export default defineConfig({
  build: {
    manifest: true,
  },
})

src/main.js
import './icon.svg';

manifest.json
{
  "index.html": {
    "file": "assets/index.aa78867d.js",
    "src": "index.html",
    "isEntry": true
  }
}

That's despite the actual dist folder containing the asset.
assets/index.aa78867d.js
assets/icon.03d6d6da.svg
index.html
manifest.json

I've gone all the way back to Vite v2.0.0 and this has never worked it seems?
The only way I have got this to work is if I actively use the asset somehow. For instance, doing:
import icon from './icon.svg';
console.log(icon)

Will add it to the manifest exactly as I expect. Not sure if this is a bug, or expected behaviour?

If I had to guess, imports are probably promises that are lazily resolved. So it isn't until an import is actually used (thus the behavior that @engram-design is seeing) that it'd be added to any manifest, just as a resource that can't be resolved (404 for example) isn't added either.
So I'm guessing this probably is a feature, not a bug, in that unused resources (unresolved promises) are not included in the production build.
The behavioral expectation likely comes from experience with task runners, rather than loaders.

What threw me was the fact that it was processing the file - moving it to dist but not adding it to the manifest. If the file is deemed not required, should it even end up in dist?
I'll say that in my case, I mention the use of imagemin. As @khalwat rightly guessed, I'm coming from Webpack (Laravel Mix) where I would have as part of my production build process, a task that scans the src/img/**/* folder for any and all images, processes them, and copies them to dist/img.
I'm trying to replicate that by using vite-plugin-imagemin which works perfectly, but only for assets used in Vue components, or CSS files. There are cases I want to use these assets in Twig templates, outside of Vite's awareness. Hence, my journey to try and "add" every asset to the manifest.
But I've pivoted back to my original goal, and forked the vite-plugin-imagemin plugin to allow direct copying from src/img to dist/img. In my Twig templates, I can now refer to these specifically via /dist/img/my-image.png upon build. During development these are resolved to use the dev server, http://localhost:3000/img/my-image.png.
It's quite likely me scenario is different, but just thought I'd chime in - just in case anyone has a similar scenario and how to approach this. My approach using Craft CMS for the project involves Twig server-side code, but also a sprinkling of Vue, so it's very much a hybrid approach, similar to a lot of people in the Laravel community.

@engram-design Yes. Now I have to get my CSS’s @font-face to point to the hashed font file. I see there’s postcss-url so I’m now looking into that.

@Shinigami92 This behavior is intentional, at least at the time of this comment: https://github.com/vitejs/vite/pull/1774#issuecomment-769447478

@Shinigami92 This behavior is intentional, at least at the time of this comment: https://github.com/vitejs/vite/pull/1774#issuecomment-769447478

Thanks for the info
Should I close this issue then and mark as wont fix?

If it is intentional to exclude assets from the manifest(s),

Why is there nothing about this in the docs at https://vite-ruby.netlify.app/guide/migration.html#manual-steps or https://vitejs.dev/config/#resolve-dedupe ?
How does one resolve the issue? What is the workaround? const images = import.meta.glob('../images/.') and then console.log(images)? config option?

@tgrushka Vite Ruby does not mention it because it generates its own manifest-assets.json to cover for this missing feature in Vite.js.

No, I checked both manifest files, and neither includes required assets unless imported AND used in a JS file. Further, the keys are wrong in that case, as the keys are literally "../images/something" which is not consistent with they way it worked with webpacker. All of these JS bundlers are so configuration heavy. They say they work, but not for images, not for SVGs, not for Vue components... Isn't there one that actually works as a drop-in replacement for webpacker and isn't so brittle? (The whole reason for switching away from webpacker/webpack is because it's always breaking things and not intuitive, but then if all the alternatives are just as troublesome to figure out, and the docs are just as bad, what is the incentive to switch?)

This thread is about Vite.js, please open a Discussion in Vite Ruby if you need help migrating from Webpacker.

Had a look and Vite is already tracking and outputting any assets regardless of their usage so I think it makes sense to expose them in the manifest so those integrating with a backend can take advantage of Vite for processing assets not directly used by Vite.
In my testing importing static assets via import.meta.glob is enough for Vite to process them even if not referenced.
vite.config.js
export default defineConfig({
  build: {
    rollupOptions: {
      input: 'src/main.ts'
    }
  }
})

src/main.ts

import './main.css'

let files = import.meta.glob('./files/**/*');

// The "files" variable doesn't need to used for imports to get processed.

src/main.css
@font-face {
  font-family: "Font";
  font-style: normal;
  font-weight: 400;
  src:
    url("/src/fonts/my-font.woff2") format("woff2"),
    url("/src/fonts/my-font.woff") format("woff");
}

With the above Vite will process and output files matching the glob ./files/**/*. The only missing bit is a way to get the final path. Looking at generateBundle the asset chunks are present but not exposed so I propose we add a _assets entry within the manifest that contains all assets Vite has processed e.g.
{
  "_assets": {
    "src/files/favicon.svg": "assets/favicon.17e50649.svg",
    "src/fonts/my-font.woff2": "assets/my-font.bf47658a.woff2",
    "src/fonts/my-font.woff": "assets/my-font.80d4cac9.woff",
    "main.css": "assets/main.eac10a5f.css"
  },
  "src/main.ts": {
    "file": "assets/main.6097d7e4.js",
    "src": "src/main.ts",
    "isEntry": true,
    "css": [
      "assets/main.eac10a5f.css"
    ],
    "assets": [
      "assets/my-font.bf47658a.woff2",
      "assets/my-font.80d4cac9.woff"
    ]
  }
}

The _assets entry contains assets both used within chunks i.e. fonts and non used assets i.e. those imported via the glob. This is desirable as it then allows you to more easily reference files like fonts for things like generating preload directives and other assets such as favicons or static assets referenced in the frameworks templating language.
I've quickly modified vite/packages/vite/src/node/plugins/manifest.ts to achieve the above but I'm likely missing something.
if (chunk.type === 'asset') {
  if (!manifest['_assets']) {
    manifest['_assets'] = {}
  }
  let name = normalizePath(
    path.relative(config.root, chunk.name)
  )
  manifest['_assets'][name] = chunk.fileName
}

The only thing that isn't quite right is how css is handled as Vite considers it an asset but the full path is stripped by the time the manifest is generated i.e. instead of src/main.css it appears as main.css.
I'm not sure if we should remove the CSS properties or try to add the full path back in. If we did it keep it and use the source path it would then be possible to use css as an entry.
export default defineConfig({
  build: {
    rollupOptions: {
      input: [
        'src/main.ts',
        'src/main.css',
      ]
    }
  }
})

This is currently possible (not sure if intentional) but you'd have to remember to reference your css by the file name (entry.css) rather than path (src/entry.css) and I'm assuming that relying on filename only will result in conflicts.
<link rel="stylesheet" href="/assets/{{ manifest['_assets']['entry.css'] }}" />

But by keeping the original path things would work as expected.
{
  "_assets": {
    "src/files/favicon.svg": "assets/favicon.17e50649.svg",
    "src/fonts/my-font.woff2": "assets/my-font.bf47658a.woff2",
    "src/fonts/my-font.woff": "assets/my-font.80d4cac9.woff",
    "src/main.css": "assets/main.eac10a5f.css"
  },
  "src/main.ts": {
    "file": "assets/main.6097d7e4.js",
    "src": "src/main.ts",
    "isEntry": true,
    "css": [
      "assets/main.eac10a5f.css"
    ],
    "assets": [
      "assets/my-font.bf47658a.woff2",
      "assets/my-font.80d4cac9.woff"
    ]
  }
}

<link rel="stylesheet" href="/assets/{{ manifest['_assets']['src/entry.css'] }}" />

To summarise there are two things to look at:

Exposing all assets in the manifest via something like _assets
Providing the full source path for css

Fixed in #6649


Include :: Move logic that performs include into the projection lambda to bypass the limitations of AccessorFindingExpressionVisitor for some complex cases involving Coalesce and Conditional expression

Currently in Include and ChangeTracking logic we use AccessorFindingExpressionVisitor to access entity that we should run include/tracking logic on. However this has limitations with regards to Coalesce and Conditional operators (where the same "position" in the result lambda can potentially return entities from different query sources (with different include/tracking settings).
Using current approach we can't distinguish them resulting in unexpected behavior.
Proposed fix is to move a bulk of include/tracking logic into the projection lambda itself, e.g.
instead of
Include(Select(..., t  => new { t.a ?? t.b }))
we would do:
IncludePrep(Select(..., (t, qc) => new { Include(qc, t.a) ?? Include(qc, t.b)}))

Fixed in 7bdf5818b10389588d74ecc03ba766fe24850298


Module net does not exist in the Haste module map

My app is unable to run because of this error, which is due to the fact that net is a node module which I think not available on react native. Given that, I'm wondering why does this package depend on the pouchdb http adapter which use the said node module via the touch cookie package?
Or am I missing something? Thank you.

Try running "react-native start --reset-cache" I get haste map errors from time to time and this seems to work


Minor cleanup and optimizations

These are just a few things I've noticed while reading through the code.
getClassMapping -> Optional<? extends ClassMapping<?>>:
Right now it unpacks the Optionals, just to pack them in another one, with the more generic type. IMO Optionals and Java's Generics are annoying, but the way to avoid that is to return an Optional with ? extends. Alternatively some hacky casting could be used here.
"" + char -> String.valueOf(char): see https://stackoverflow.com/a/8172439

Merged with https://github.com/jamiemansfield/Lorenz/commit/c01894113c4500d2c88e9e0c502bfe6de3f67b90 👍


Test and migrate Neo4J example to 1.9.

Anyone working on this? If not, I have neo4j going in 1.9. Everything - so far - worked out of the box. The only issue has been with a javascript driver, but I'm not sure it's 1.9 related yet.

Yes, there's https://github.com/dcos/examples/pull/140 linked here that includes the updates, we'll be reviewing it soon :)

I have closed #140 (as I had created the PR from the master branch in my fork - which did not allow me to create any new PRs for other examples) and created a new #141 for this issue. Thanks!

Resolved


Camera PostProcessing SemanticSegmentation generates void images

Using PostProcessing = 'SemanticSegmentation', it generates void (black) images.
I noticed on the documentation page, the latest code generates black images too: here:
http://carla.readthedocs.io/en/latest/cameras_and_sensors/

Hi @hs105,
The semantic segmentation image has the tags encoded in the red channel, these tags go from 0 to 12, that's very dark shades of red. The image in the documentation is a sample, if you take a closer look it is not black but it has some dark shades of red.

Thanks for your clarification.

Knowing that, how do you transform the "black image" to the color one?

Hi @RogerAylagas
This is an already answered question, but you can do something like this:
from carla import image_converter

# other stuff...

encoded_sem_seg = sensor_data.get('CameraSemSeg', None)
colored_sem_seg = image_converter.labels_to_cityscapes_palette(encoded_sem_seg)

@kk2491 which version are you using?

@marcgpuig I am using the latest version 0.9.2 pre-compiled one.


Set up Config File

Subscribtions

projects
topics
schema directory

Metadata Bucket (only name, no path)

example: gs://standard-hedwig

Staging Bucket (only name, no path)

example: gs://standard-hedwig

Output Bucket  (name and path)

example: gs://standard-hedwig/output

“Every configurable number of minutes, wake up, read all the worker’s files that exist”

ScrapeInterval

“Write to a temporary path every configurable duration (say 30 seconds), or until a configurable content size is reached (say 5MB)”

FlushAfter
FlushAtSize

I want to be careful about this task - we shouldn't create a centralised "settings" struct that's passed into every constructor. Rather, only inject specific dependencies that the constructor uses.
I recently re-did hedwig-go like so, take a look at that.
Additionally, we should not need a config file just read from env vars since config file would mean berglas and the likes which we don't want to impose. So perhaps a config struct that's created in main.go and then pick fields from that struct for every constructor as objects are constructed.

ah okay yeah I was just looking at hedwig go - was planning to just set up something similar to this? https://github.com/cloudchacho/hedwig-go/blob/e5ab05b5a6ca8c5f2f82955464c919cb2ba2c4c1/gcp/gcp.go#L265

Yep so that links to the settings specific for gcp backend. And it's a struct rather than separate parameters since that's easier to update in the future. I think we shouldn't need a struct here since the app is going to be a deployable and the "external API" is just env vars. So we can get away with just parameters everywhere (assuming it doesn't balloon to like 5 params 😛).

If it's more than like 3 config parameters definitely a struct.

ah okay so maybe we don't need a struct and just always read from ENV for this info?

Well ideally the only thing that reads from env is the entry point or something close to that - but still only in one place. So a config struct might be okay and should be the only thing that reads from env. But a function or set of functions in main.go might work also.
Also yes we'll want to make it cloud agnostic side we'd have to provide env vars for configuring gcp as well. Would that lead to too many vars and maybe a file is better just to keep things in one place?

I was thinking we could pass all the configurations as command-line arguments. We can inject those environment variables  with defaults using [Shell Parameter Expansion](https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html.   Or may be pass a file path via command-line args to load the configs from

settings set up in https://github.com/cloudchacho/hedwig-firehose/pull/9, but https://github.com/cloudchacho/hedwig-firehose/issues/4#issuecomment-1094698945 will still have to be addressed as to how they are added on start up


Add qcnn encoding circuit

For checking if the backend is a statevector simulator, please use:
if "statevector_simulator" in str(executor.backend)
That captures also IBMQ statevector simulators or AER statevector_simulators.
Maybe we should add executor.statevector_backend

I will add a functionality to swap to the BackendPrimtives automatically


updated zulu java to 8

Was getting memory explosion using Zulu Java v7. Updating to latest Zulu Java v8 fixes that issue.
Fixes: #57

Thanks!


support load env from file.

fixed #18
Signed-off-by: Bo-Yi Wu<EMAIL_ADDRESS>

Current coverage is 95.48% (diff: 100%)

Merging #19 into master will not change coverage

@@             master        #19   diff @@
==========================================
  Files             2          2
  Lines           133        133
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            127        127
  Misses            3          3
  Partials          3          3

Powered by Codecov. Last update afbe4d0...6227580


Mark 1.0.0 as latest on npm

Please mark 1.0.0 as the latest version on npm. 0.2.2 is the current latest npm release.
https://www.npmjs.com/package/@microsoft/eslint-plugin-sdl?activeTab=versions. npm installs the latest version by default if no version is specified.
1.0.0 is the latest release according to GitHub releases https://github.com/microsoft/eslint-plugin-sdl/releases/tag/v1.0.0. Perhaps the 1.0.0 release is not yet ready for production, but in that case it should probably not be marked as the latest release on GitHub.

Yeah, thanks for a reminder. I'll tag 1.0.0 as latest on npm next week.

This has been done now, closing. Let us know if you encounter any issues with 1.0.0 @vchernin.


Upgrade version.mockito 4.10.0 -> 4.11.0

This PR contains the following updates:

Package
Type
Update
Change

org.mockito:mockito-errorprone

minor
4.10.0 -> 4.11.0

org.mockito:mockito-bom
import
minor
4.10.0 -> 4.11.0

Release Notes

mockito/mockito
v4.11.0
Compare Source
Changelog generated by Shipkit Changelog Gradle Plugin
4.11.0

2022-12-28 - 1 commit(s) by Andy Coates
Improve vararg handling: approach 2 (#2807)
Mocking varargs method with any(String[].class) doesn't work as expected (#2796)
(Argument)Matchers regression from 1.10.19 to 2.18.3 for varargs (#1498)
Cannot verify varargs parameter as an array (#1222)
ArgumentCaptor can't capture varargs-arrays (#584)
Verification of an empty varargs call fails when isNotNull() is used (#567)

[ ] If you want to rebase/retry this PR, check this box

The Java Platform team wishes you a happy festive period. Here is the suggested commit message:
Upgrade Mockito 4.10.0 -> 4.11.0

See:
- https://github.com/mockito/mockito/releases/tag/v4.11.0
- https://github.com/mockito/mockito/compare/v4.10.0...v4.11.0

Renovate be like

Header generated and modified from Sweaterify.


Catch PHP7 \Throwable

There are several "catch all" traps in the code, that catch \Exception and they should be catching \Throwable.
While it's not possible to simply replace it, since that would break compatibility with PHP 5.6, it still can be fixed pretty easily.
Little worse are the typehints, as I'm not sure how much you wanna typecheck that the object is in fact a exception.

:-1: On this actually.

@GrahamCampbell can you explain why?

Throwable would indicate that the actual application is broken. Surely we only want to catch Exceptions that occur because of a bad http response.

That means you maybe don't wanna wrap such exceptions in RequestException, but there still are some places where you wanna know things broke so you don't get that object into an invalid state.

Just to be clear - I didn't study the lib deeply enough to really understand where it makes sense so I added it everywhere and was hoping for a discussion about this.

This is a good change, but I don't like all the duplication that has to be introduced. Is there a better way that other projects have been handling this?

Most projects just do the duplication. A common refactor I've seen has been to just call a function specifically for handling the catch.
So, instead of:
try {
    foo();
} catch (Exception $e) {
    bar();
    baz();
    foo();
} catch (Throwable $e) {
    bar();
    baz();
    foo();
}

try {
    foo();
} catch (Exception $e) {
    handle();
} catch (Throwable $e) {
    handle();
}

function handle()
{
    bar();
    baz();
    foo();
}

This extends to the OOP version too. I'm just too lazy to type out a class dfn and $this a few times.

Do any of those places make sense to change? Or should I just close this and consider this solved?

I've went throught the code again by myself and I came to conclusion, that it doesn't make sense to catch throwable in any of theese places.

Anyway, now I have a good feeling that this is solved :)

@fprochazka @GrahamCampbell : I don't understand why you would refuse this feature ? I have the following example: I call an API wich return null in the body (which I know is not fine but still json valid) and it throws an Error (I don't know which one yet). But Guzzle is trying to log it in the MessageFormatter::format. Because it is the wrong type it throws an other error which "hide" the previous one...


Refs #36345 - Raise minimum Puppet version to 7.0.0

Dropping of old distros should happen in a separate PR: https://github.com/theforeman/puppet-dhcp/pull/220


ListItem secondaryTextLines improvement

Thank you for creating the secondaryTextLines property for ListItem.
It would be even more helpful, if it wouldn't force the secondary text to be 2 lines long also for short texts.
That could be easily fixed by using max-height: 36px instead height: 36px.
Also 3 lines support could make big difference compared to only 1-2 :)
Versions

Material-UI: 0.15.4
React: any
Browser: any

We have been porting the component on the v1-beta branch. We reimplemented it from the ground-up. While we haven't tested it, I think that the issue is most likely fixed on that branch. Hence, I'm closing it.
Still, we will accept PR fixes until v1-beta takes over the master branch.


Consider publising the container versions

Hello Bramble team,
I really like what you all have going here on this project. Recently while trying to deploy the service I realized it's not easily discernible what versions of the software are available in docker. It would be nice to be able to find that versions easily during implementation. I realize I could just not specify the version number, but that could mean that breaking changes could sneak into my production deployments.

Hi @zquintana are you asking about the bramble image?
On every build we push an image to the GitHub Container Repository (ghcr.io) which is tagged with the version.
https://github.com/orgs/movio/packages/container/package/bramble
I haven't managed to get it to show up in the sidebar yet though.

Yea, that's what I was referring to. I've gotten used to docker hub for finding image tags. I found a workaround though... podman search ghcr.io/movio/bramble --list-tags, if you're using podman.

They are listed on the github packages site I posted above, it doesn't give you any details though other than the tag.
I'll see if I can associate them with the releases some time.


Added accessors to vector types

This basically replaces the protected m_values member with public x/y, x/y/z/w, s0..s7, s0..sf members according to the vector size.

I would recommend splitting this into two separate pull request: vector accessors and OpenCL version macros (fix for nullary_kernel() can go anywhere). Also, it would be great if you rebase it on develop branch and resolve conflicts.

Yeah, and I recommend doing it on separate branches. Using master of your fork for pull requests is not a good idea, it should be always equal to master branch of the repo it is forked from. The same comes for the develop branch. See https://help.github.com/articles/syncing-a-fork/ (you need to sync develop branch too).


initial cpu and mps support

The goal is to us the available pytorch compute devices whenever pytorch is used - e.g. cuda, mps or cpu.  A function within utils.py can be called to determine the appropriate compute device based on a user's setup.
The goal is to initiate the pull request then discuss.  Obviously, more scripts other than utils.py and pipeline.py would need to be modified to properly implement this...so the idea is to give ya'll an idea of where I'm headed then work together on this or at least get some feedback before changing multiple other scripts.
Note:
Obviously the "cuda" device refers to nvidia gpus.
However, "cuda" is also used within Pytorch when a person is using an AMD gpu and rocM is properly installed.  This was done so programmers could use the same API depending on a user's specific GPU.
Apple/MacOS, those that have metal performance shaders, still use "mps," however, within the Pytorch framework.
Hence, "cuda," "mps" or "cpu" being the available options that are set by the get_compute_device function within utils.py.
Additional notes:
Pytorch itself doesn't support gpu-acceleration for AMD gpus on Windows.  User's just need to be aware of this.  There are some unofficial workaround out there - e.g. trying WSL - but I haven't verified them.
Also, the bitsandbytes library doesn't currently support mps, but they're working on it.  So if we introduce quantization down the road it'll be important to evaluate that or other quantization approaches when we cross that bridge.  Moreover, it doesn't support Windows and the unofficial wheel for installing bitsandbytes on Windows hasn't been updated to the latest version of bitsandbytes.  I've messaged them about updating their wheels and am awaiting a response.

Should incorporate all changes by @akorzh as discussed in the "issue" for this pull request, plus my centralization of a function to determine the appropriate compute device.  His changes were subsequently tested as working on systems with mps but please test that it's still properly assigning the compute devices and the program works as a whole for cuda/mps and/or cpu-only based compute systems...

That looks great, thanks a lot.

Should be ready for review and testing.

That looks great, thanks a lot. I believe all of the commits are really logically a single "change". Would you mind pushing a single squashed commit for merging (unfortunately GitHub does not offer a "squash and rebase" option)?

That looks great, thanks a lot. I believe all of the commits are really logically a single "change". Would you mind pushing a single squashed commit for merging (unfortunately GitHub does not offer a "squash and rebase" option)?

I don't know what a "squashed commit" is, but I'll ask Chat-gpt.  ;-)

I tried squashing via the command line, using instructions from chat-gpt since I'd never done it before, but it "closed" this pull request for some reason and I can't see how to re-open it.  I've obviously never done this before.  Here's the steps I performed:

Cloned the repository, created a command prompt, navigated to the appropriate directory.
ran git checkout cpu-mps-support (name of my branch).
ran git rebase -i --root
my text editor opened and I changed all instances of "pick" to "squash" except the first instance of "pick."
saved the file and closed the text editor, and then github proceeded...
it opened another txt file with comments regarding the various commits.  I deleted all and made one comprehensive message.  Saved and closed the txt file.
ran this command git push origin cpu-mps-support --force

After that I notice that the pull request was closed on your repository...Please help, this is my first time doing this.

Hey, your steps looks perfect to me and the line "BBC-Esq force-pushed the cpu-mps-support  branch from 280d756 to ab3af85 yesterday" here suggests you did it perfectly (there are no diffs to the previous version but it's now a new single commit)... Congrats on your first interactive rebase! :)
It seems like the pull request was closed because something deleted the branch you force-pushed. But this happened 1,5hours later so it was not your squashing (you can check the precise timestamps by hovering over the fuzzy "yesterday" and "20 hour ago" labels on GitHub).

And sorry for having you do all this work, it's sometimes hard to know what's going to be an easy fix and what requires someone to spend a lot of time. I was working with git for 10+ years so I unfortunately mostly forgot what is easy and what is hard...
I sincerely hope it will pay off in the longer run but if you feel something I asked for takes a lot of time then also feel free to push back a bit.  :)


How can I get a boundingBox of a binary mask with LabelShapeStatisticsImageFilter()

I want to get the boundingBox of a binary mask quickly with the GetBouningBox() in LabelShapeStatisticsImageFilter(), but I encounter this problem.
imgPath = os.path.join(dataPath,'2_20','2_20.dcm')
maskPath = os.path.join(dataPath,'2_20','anzhongyan_t2-sag.nii.gz')

image = sitk.ReadImage(imgPath)
mask = sitk.ReadImage(maskPath)

lsif = sitk.LabelShapeStatisticsImageFilter()
lsif.Execute(image,mask)
boundingBox = np.array(lsif.GetBoundingBox(1))

Traceback (most recent call last):
  File "/home/dell/hw/seg/cervical/classification/boundingBox.py", line 14, in <module>
    lsif.Execute(image,mask)
  File "/home/dell/anaconda3/lib/python3.6/site-packages/SimpleITK/SimpleITK.py", line 43059, in Execute
    return _SimpleITK.LabelShapeStatisticsImageFilter_Execute(self, *args)
NotImplementedError: Wrong number or type of arguments for overloaded function 'LabelShapeStatisticsImageFilter_Execute'.
  Possible C/C++ prototypes are:
    itk::simple::LabelShapeStatisticsImageFilter::Execute(itk::simple::Image const &)
    itk::simple::LabelShapeStatisticsImageFilter::Execute(itk::simple::Image const &,double,bool,bool,bool)

I solved this problem by remove the image.
imgPath = os.path.join(dataPath,'2_20','2_20.dcm')
maskPath = os.path.join(dataPath,'2_20','anzhongyan_t2-sag.nii.gz')

image = sitk.ReadImage(imgPath)
mask = sitk.ReadImage(maskPath)

label = sitk.GetArrayFromImage(mask)

lsif = sitk.LabelShapeStatisticsImageFilter()
lsif.Execute(mask)

boundingBox = np.array(lsif.GetBoundingBox(1))

[254 116   9  78  98   8]

but the boundingbox seems not correct, is it because the nii format or other question?

Hello!
Glad to hear you figured out the first problem. The GetBoundingBox and  GetRegion of the LabelShapeStatisticsImageFilter returns a bounding box is as [xstart, ystart, start, xsize, ysize, zsize].
You may also be interested in the LabelStatisticsImageFilter . This also compute the bounding box, it may be more efficient, but the filter takes both the intensity and label image. Additionally it has a GetRegionMethod which returns the bounding box as above, and a GetBoundingBox method with returns the bounding box as [xmin, xmax, ymin, ymax, zmin, zmax].

I got it, thank you very much. :smile:

Is there a program that generates XML files of VOC data set by mask? Thank you very much! @muween

Hello @Wenting-Xu,
SimpleITK is an image analysis toolkit, so we don't have a program that allows you to save a mask using the Pascal VOC XML format. You will have to implement your own or look at an existing tool that saves annotations in the VOC format.

Additionally it has a GetRegionMethod which returns the bounding box as above, and a GetBoundingBox method with returns the bounding box as [xmin, xmax, ymin, ymax, zmin, zmax].

It's actually [x_start, y_start, z_start, x_size, y_size, z_size].


Increased memory usage (2X) for cardano-node when connected to MC3

Internal
Summary
Increased memory usage (2X) for cardano-node when connecting to MC3.
System info :

Node version:

cardano-node 1.17.0 - linux-x86_64 - ghc-8.6
git rev 0191ff56d194b6ac074af0d51e67493c14e08ffa

OS:  Linux Mint 19.2

Steps to reproduce
I ran node from CLI and also started Deadalus.
Process manager show now usage at ~1GiB, for the past few months it never exceeded over 0,5GiB for me when testing stage , mainnet.
cardano-wallet-shelley has 2,7 GiB
Screenshots and attachments

At the moment of creating this ticket both cardano-node and Deadalus are already running for ~6 Hours.
Expected behavior
Not sure if this is a bug or expected behavior when switching to Shelley ledger so I marked it as invalid which has description "This does not seem right" which better suits this situation/ticket.
Needs to be investigated.
Additional context
N/A

CC: @dcoutts @mrBliss

Interesting, it is business as usual for me on Windows; are you only seeing this during initial sync?

After the transition to Shelley, we will temporarily keep both the Byron and Shelley ledger in memory until we are k blocks deep in the Shelley era and no longer need to be able to roll back to the Byron era.
According to https://github.com/input-output-hk/ouroboros-network/issues/1404#issuecomment-663498571, we expect the Byron ledger to be roughly 17 MB and the translated Shelley one 22 MB (not accounting for fragmentation and other heap overhead), so it is strange to see it jump from 500 MB to 1 GB.
Also, how long has your node transitioned, more than k blocks?

@alan-mcnicholas Yes, it is increasing during initial sync, once it is synced it does not grow anymore.
@mrBliss This is the last log message fromcardano-cli shelley  query tip --testnet-magic 42 before I shut it down:
{
    "blockNo": 6707,
    "headerHash": "f3098d8cc7338385606f1fa769987f8ab5c6286d0214f75772e4437070b0a609",
    "slotNo": 79640
}

I used:
while true; do ps --pid 20367 -o rss | tail -1 ; sleep 1 ; done | tee memusage
Description of events and ~memory usage when event happened below.
File (truncated last value 1055916 that was repeating ) :  memusage-mc3-node_1_17_0.txt
1 A Event:
2020-07-24 16:44:35.19 UTC] Chain extended, new tip: (Point 204, "3b860c2ddca906f8b451042a16725d986d423b577c8f45742f5753cf0cb13087")
Event: LedgerUpdate (HardForkUpdateInEra Z (WrapLedgerUpdate {unwrapLedgerUpdate = ByronUpdatedProtocolUpdates [ProtocolUpdate {protocolUpdateVersion = 1.0.0, protocolUpdateState = UpdateConfirmed (SlotNo {unSlotNo = 204})}]}))

1 B: Memory Usage: 120104 <->123008
2 A Event:
[artur-de:cardano.node.ChainDB:Notice:23] [2020-07-24 16:45:38.43 UTC] Chain extended, new tip: (Point 420, "554a7449d9158f9528cf0732602f40e331ac22460e108ea40c6ba4ef813cb534")
Event: LedgerUpdate (HardForkUpdateInEra Z (WrapLedgerUpdate {unwrapLedgerUpdate = ByronUpdatedProtocolUpdates [ProtocolUpdate {protocolUpdateVersion = 1.0.0, protocolUpdateState = UpdateCandidate (SlotNo {unSlotNo = 420})}]}))

2 B: Memory Usage: ~ 268264
3 A Event:
[artur-de:cardano.node.ChainDB:Notice:23] [2020-07-24 16:45:38.89 UTC] Chain extended, new tip: (Point 636, "1a68379784a54785f0beafcc182441cfcaa37a4c42ccd72e0b68a2ccffc44135")
Event: LedgerUpdate (HardForkUpdateInEra Z (WrapLedgerUpdate {unwrapLedgerUpdate = ByronUpdatedProtocolUpdates [ProtocolUpdate {protocolUpdateVersion = 1.0.0, protocolUpdateState = UpdateStableCandidate (EpochNo {unEpochNo = 1})}]})

3 B: Memory Usage: ~ 351476
4 A Event:
[artur-de:cardano.node.ChainDB:Notice:23] [2020-07-24 16:49:10.87 UTC] Chain extended, new tip: (Point 1408, "2c871d1dd8805d8fbd82538e1795b9a47273a69a0d07a5211ad37f9ed7fe2e96")
Event: LedgerUpdate (HardForkUpdateInEra Z (WrapLedgerUpdate {unwrapLedgerUpdate = ByronUpdatedProtocolUpdates [ProtocolUpdate {protocolUpdateVersion = 2.0.0, protocolUpdateState = UpdateStablyConfirmed (fromList [])}]}))

4 B: Memory Usage: ~437592
5 A Event:
[artur-de:cardano.node.ChainDB:Notice:23] [2020-07-24 16:51:41.01 UTC] Chain extended, new tip: (Point 2628, "c95d3d989518dbdf7e70ed083e156b38e029c44d6cd1cf6240ae1a291be9c4ad")
[memusage-mc3-node_1_17_0.txt](https://github.com/input-output-hk/cardano-node/files/4973521/memusage-mc3-node_1_17_0.txt)

Event: LedgerUpdate (HardForkUpdateInEra Z (WrapLedgerUpdate {unwrapLedgerUpdate = ByronUpdatedProtocolUpdates [ProtocolUpdate {protocolUpdateVersion = 2.0.0, protocolUpdateState = UpdateStableCandidate (EpochNo {unEpochNo = 3})}]}))
Event: LedgerUpdate (HardForkUpdateTransitionConfirmed <EraIndex Byron> <EraIndex Shelley> (EpochNo {unEpochNo = 3}))

5 B: Memory Usage around that time : 439404 <-> 457124
6 A Event:
Event: LedgerUpdate (HardForkUpdateTransitionDone <EraIndex Byron> <EraIndex Shelley> (EpochNo {unEpochNo = 3}))
6 B: Memory Usage around that time :  561432 <-> 673416
It ended with repeating memory usage: 1055916

@mrBliss It looks like it went back to ~500 MB after ~ 24 hours:

graph:

Data:
memusage_25H.txt

hi @ArturWieczorek can you reproduce this in any current environment?

Hi @vix-io , this can be closed.


skip_documentation argument does not work inside *** Settings *** section

Hi,
I tried the documented ways to skip documentation format in the *** Settings *** section but none of them worked.

generic documentation skip from toml file:

   [tool.robotidy]
   skip-documentation = true

transformer specific way from toml file:

   configure = [
        "AlignSettingsSection: skip_documentation=True"
   ]

From CLI:
robotidy --skip-documentation  <ROBOT_FILE>

The results are the same in every case, all documentation lines were aligned.
Affected version: 4.8.0
Note: I did not try previous versions.

All the above skip options should work. Generally whenver we transform the code, we need to check if the code is not skipped manually (in the code). I see we don't do it for AlignSettingsSection. I would call it missing feature, thankfully easy to add. I will take care of it.


[DateRangePicker] Migrate internal components to emotion

These internal components follow the same approach for migration so I think it is easier to bundle them together to review.

PickersCalendar

DateRangePickerViewDesktop

DateRangePickerToolbar

DateRangePickerInput

[x] I have followed (at least) the PR section of the contributing guide.

@mnajdova  One thing that I wonder after did some of the migration for internal components. It seems like this is simpler and gives the same result?
const Root = styled('div', {}, { skipSx: true })

const Root = styled('div')

Argos fail due to PickersCalendar is not migrate to emotion and css from withStyles has higher priority. will open another PR to migrate PickersCalendar first.

@mnajdova  One thing that I wonder after did some of the migration for internal components. It seems like the second one is simpler and gives the same result as the first one?
const Root = styled('div', {}, { skipSx: true })

const Root = styled('div')

What do you mean result as the first one? The default value for skipSx is false: https://github.com/mui-org/material-ui/blob/next/packages/material-ui/src/styles/experimentalStyled.js#L81 Are you suggesting we change the default or?

@mnajdova  One thing that I wonder after did some of the migration for internal components. It seems like the second one is simpler and gives the same result as the first one?
const Root = styled('div', {}, { skipSx: true })

const Root = styled('div')

What do you mean result as the first one? The default value for skipSx is false: https://github.com/mui-org/material-ui/blob/next/packages/material-ui/src/styles/experimentalStyled.js#L81 Are you suggesting we change the default or?

My bad, didn't explain it clearly. I mean why do we need to have skipSx option here, is it help on the performance if skipSx is provided?.

My bad, didn't explain it clearly. I mean why do we need to have skipSx option here, is it help on the performance if skipSx is provided?

We discussed it in one of the first pickers PR https://github.com/mui-org/material-ui/pull/25989 In my opinion we don't need to do it, but let's follow the convention it is at this moment, we can update before the beta version if we decide it's ok to have it on the internal components as well.


ci(actions): update renovatebot/github-action action to v40.2.5

This PR contains the following updates:

Package
Type
Update
Change

renovatebot/github-action
action
patch
v40.2.4 -> v40.2.5

Release Notes

renovatebot/github-action (renovatebot/github-action)
v40.2.5
Compare Source
Documentation

update references to renovatebot/github-action to v40.2.4 (dd6134d)

Miscellaneous Chores

deps: update dependency @semantic-release/github to v10.1.2 (fd92454)
deps: update dependency @semantic-release/github to v10.1.3 (f2b9a64)
deps: update dependency @types/node to v20.14.12 (fe88a7e)
deps: update dependency @types/node to v20.14.13 (03ace83)
deps: update dependency husky to v9.1.2 (77e79d3)
deps: update dependency husky to v9.1.3 (0ff26fa)

Build System

deps: lock file maintenance (8f47962)

Continuous Integration

deps: update renovate docker tag to v38.11.0 (0736fb9)
deps: update renovate docker tag to v38.12.0 (0cff0d5)
deps: update renovate docker tag to v38.14.0 (83fcd08)
deps: update renovate docker tag to v38.16.0 (6989153)
deps: update renovate docker tag to v38.18.11 (f3071cd)
deps: update renovate docker tag to v38.18.12 (c87684f)
deps: update renovate docker tag to v38.18.4 (5384334)
deps: update renovate docker tag to v38.18.5 (f26f2f7)
deps: update renovate docker tag to v38.18.8 (51f49c4)
deps: update renovate docker tag to v38.18.9 (e572ebd)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This issue has been resolved in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[fix bug 1130419] Update fetch_bugs to use Bugzilla REST API.

@glogiotatidis or @johngian  can you please r this?

Sure @akatsoulas

Coverage decreased (-0.07%) to 91.9% when pulling b9750a100a5ff499eed6992c441dc99882420539 on akatsoulas:upgrade-bugzilla-api into 6e39bc11f7f618db015518e54833b2ecf6927efa on mozilla:master.

Coverage decreased (-0.1%) to 91.89% when pulling d1e0fa8b01d2895a19932cd775a850b0b65267b4 on akatsoulas:upgrade-bugzilla-api into 95c746de0af49d75ff8e64bd2337c66e34344f65 on mozilla:master.

I didn't actually run this but code looks ok.

BTW we have tests for this and they were not updated but they are not failing either. What's happening?

Coverage decreased (-0.07%) to 91.72% when pulling 15cb46c99bd58b63f0eef91ece9535330804532d on akatsoulas:upgrade-bugzilla-api into 79b29ff767e2da0587b2bc9a95a482368f2ae2eb on mozilla:master.

@glogiotatidis pr updated

Coverage decreased (-0.07%) to 91.7% when pulling 7e5d452aad7a0efca5a11b5680036abd5b5ab51d on akatsoulas:upgrade-bugzilla-api into 3c63db26a3a9c5f2c61ec95ebf2c12d24bfafb01 on mozilla:master.

Coverage decreased (-0.02%) to 91.76% when pulling 05399b07799b92a7edf9789d559b0b33f263631e on akatsoulas:upgrade-bugzilla-api into 3c63db26a3a9c5f2c61ec95ebf2c12d24bfafb01 on mozilla:master.

r+wc nice job!

Coverage decreased (-0.04%) to 91.75% when pulling 5a9f69f975ff41fa552da732a566bf7c72f535ee on akatsoulas:upgrade-bugzilla-api into 9e5277f0031b219bfaf1deb0990e7c5482595a0d on mozilla:master.


Test external registry feature in one of our CI scenarios

We need to test epinio deployment with an external registry, more info in the PR https://github.com/epinio/epinio/pull/974.
The feature can be added to an existing scenario or to a new one.

Successfully tested with Epinio 0.2.0 + GKE + Helm chart deployment + my own docker hub account.
Let's work on the automation with Google Container Registry instead of Docker Hub.
I will add this test in the GKE scenario.