In-portal documentation of template filters and globals

Hey, I just made a Pull Request!
Created new scaffolder plugin pages to show documented template filters and global functions/values, using code refactored from the ActionsPage.
:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
[X] Added or updated documentation
[X] Tests for new functionality and regression tests for bug fixes
[X] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

@mbenson I think we would bring this up at the Scaffolder SIG this Friday, I like the direction that this is going, but I think we want to just take a peek at the higher level approach for this and if we can take some inspiration from createTemplateAction to wrap up some of the API a little bit.
Might make the implementation a little simpler.

Sure, I'll keep working on getting the warnings and such cleaned up. I'm assuming the SIG is not something I would/could attend, but from what I could gather it was easier (which is not to say "easy") to have gone this route than to try to insert the same content into the scaffolder context menu (although I did note the allowance for additional menu items so maybe I just failed to understand how I could have hooked into those; in any case I did DRY the things that were borrowed from the actions page which I feel has value). LMK what I can/should do, and thanks @benjdlambert .

Hey :wave:
In summary from what we spoke about in the SIG:
Thinking that we should make the createRouter method take either Record<string,  TemplateFilter> or an array of NunjucksTemplateFilter (name tbd), which you can create using createTemplateFilter thats a similar API to
https://github.com/backstage/backstage/blob/ddfc3aac3f08e7b452091c0e29c487c09c4b488a/plugins/scaffolder-node/src/actions/createTemplateAction.ts#L52
Thinking that it would be good to be able to define the input and output schema a little similar to what we can do today with createTemplateAction https://github.com/backstage/backstage/blob/ddfc3aac3f08e7b452091c0e29c487c09c4b488a/plugins/scaffolder-backend-module-gitlab/src/actions/gitlabProjectDeployTokenCreate.ts#L40-L56
And this would be the same for filters functions and values.

TODO: express filters and/or global JSON schemas in terms of zod

@benjdlambert I think I'm ready for another review. For the moment I have called the items produced by createTemplateFilter|createTemplateGlobal* CreatedTemplate*; certainly these were just the most obvious descriptions available and I am open to change these to a different convention if a more suitable one can be conceived.

Hey @mbenson! Thanks for the updates here! Will come back round to this on Monday, haven't forgotten you! :pray:

Thanks @benjdlambert ... I've been AFK for a few days but will be available Monday.

To resolve these latest conflicts from master I had to add several words to the vale dictionary, including a misspelling of "compatibility" from the 1.30.0 changelog. Can we go back and correct its spelling?

@benjdlambert thanks for this initial review... do I understand you correctly to say that you are envisioning:

a single scaffolder templating extension point for (metadata-accompanied) template extensions including filters and, hopefully in future, globals
a single backend API endpoint to return same
a single page in the scaffolder plugin to display all available templating extensions

?
Thanks

Hey @mbenson sorry for the delay in the reply here!
Yes, I think that makes sense.  Let's start with one extension point for templateExtensions or something, think it's better to group these together as it probably makes a a lot of sense semantically, and it's not worth the extra API surface for other additions I'm feeling.

hi @benjdlambert , I was on vacation last week but I'm back on this now. Could you explain what you meant at https://github.com/backstage/backstage/pull/25898#discussion_r1738115924 ?

@mbenson sorry I might have gotten a little confused, but I was thinking if additionalItems is just things thats added to the dropdown menu, can we remove the other onClick handlers and just encapsulate them into the additionalItems components thats already added.
additionalItems={[
<MenuItem onClick={onTemplateFiltersClicked}>
  <ListItemIcon>
    <Description fontSize="small" />
  </ListItemIcon>
  <ListItemText primary="Template Filters" />
</MenuItem>
])

Does that make sense?

Ah OK - so to be honest, I think that with the introduction of the new frontend system we're gonna be heading down the additionalItems route anyways, so that people can add things to these submenus by creating extensions and we would provide default extensions that add the current dropdown items into the list.
So either way is fine to be honest with you :)

@benjdlambert it looks like the CI is going to pass now. I did handle filters first, but I was off for a week and by the time I got back I forgot to skip the globals, so those are also handled in the new template extensions backend endpoint and scaffolder page. If you need me to rip them back out and save them on another branch I will, but I won't say I'm looking forward to it. 😉

Hey @mbenson :wave:
It's still quite a bit to review, but I'll take a stab at it. I also wanted to draw your attention to some pretty closely related work which could affect this, #26777 #26774 and #26773. I think that we're gonna be bringing these up at the Scaffolder SIG to talk about on Friday, but it's all about restructuring how we think about the Template Editor Pages and the accompanying actions and FieldExtension pages for end users.
I'm thinking that we're probably gonna see how that work pans out first, before diving into this, but we're definitely keeping this PR in mind that there's going to want to be similar solutions for all aspects of extensibility in the Scaffolder.

hi @benjdlambert and thanks for the update. Understanding that this PR is staying on the back burner for right now, would my presence at this week's SIG meeting represent an unwelcome distraction?

Oh no - quite the opposite, I think it would be good if you wanted to attend to see which way were heading and provide some feedback which would be important for moving all pieces of work forward!
I unfortunately don't think I will be able to attend this week as i'm on PTO, but there's going to be others showcasing the work I believe.

Latest UI:

Ib case it is helpful, I have a branch that exercises custom template filters as well as template globals: https://github.com/mbenson/backstage/tree/template-extensions-module-demo . I will keep this branch up-to-date with the source branch of this PR to make it easier to verify the UI provided.

I have also just pushed a new branch with an alternate take on the zod-based schema definitions, the idea being that since both filters and global functions are in fact functions, they can be modeled directly by zod functions rather than having separately specified input|arguments|output. See https://github.com/mbenson/backstage/compare/doc-filters-globals...mbenson:backstage:dfg-zod-fn?expand=1

Added tabbed UI.

@mbenson question on https://github.com/mbenson/backstage/compare/doc-filters-globals...mbenson:backstage:dfg-zod-fn?expand=1, what does this do to the jsonschema and the view model that powers the UI? Does it still look sane?

@mbenson question on https://github.com/mbenson/backstage/compare/doc-filters-globals...mbenson:backstage:dfg-zod-fn?expand=1, what does this do to the jsonschema and the view model that powers the UI? Does it still look sane?

The API response from the scaffolder backend is unchanged, but the input/arguments/output properties of the schemas are all extracted from the single zod function definition rather than defining a new way to do what zod already does.

Updated my dfg-zod-fn branch to be compatible with latest changes here; the TL;DR of that commit is that schema definition for either functions or filters (which, after all, are functions) is reduced to a single function that is expected to return a ZodFunction. The scaffolder plugin, as a consumer of the backend API, is unchanged from the base PR/all changes happen beneath the surface of the scaffolder backend.

Does anybody have any more thoughts on which way to go with schema structure? Again, the decision is essentially between:
type TemplateGlobalFunctionSchema = {
  [K in 'arguments' | 'output']?: (zImpl: typeof z) => z.ZodType;
};

vs:
type TemplateGlobalFunctionSchema<
  Args extends z.ZodTuple<
    [] | [z.ZodType<JsonValue>, ...(z.ZodType<JsonValue> | z.ZodUnknown)[]],
    z.ZodType<JsonValue> | z.ZodUnknown | null
  >,
  Result extends z.ZodType<JsonValue> | z.ZodUndefined,
> = (zod: typeof z) => z.ZodFunction<Args, Result>;

The first, original version essentially duplicates what zod already provides in terms of modeling functions, and depicts multiple functions (2 here, 3 for filters) instead of one.

not stale

Sorry @mbenson, been pretty stretched in the run up to Kubecon along with a million and other things. Will try to get back to this ASAP! Thanks for the patience :pray:

Not stale, will update next week
On Thu, Nov 28, 2024, 10:07 AM github-actions[bot] @.***>
wrote:

This PR has been automatically marked as stale because it has not had
recent activity from the author. It will be closed if no further activity
occurs. If the PR was closed and you want it re-opened, let us know and
we'll re-open the PR so that you can continue the contribution!
—
Reply to this email directly, view it on GitHub
https://github.com/backstage/backstage/pull/25898#issuecomment-2506439311,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADXAJXWUJSY7NLXAZIULI32C45UPAVCNFSM6AAAAABL6LCLBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBWGQZTSMZRGE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Imports and Partials

The Example in the README.md doesn't work for me. I got an error message, because it doesn't found the settings.scss;
stream.js:94
      throw er; // Unhandled stream error in pipe.
            ^
[gulp] Error in plugin 'gulp-sass': source string:1: error: file to import not found or unreadable: "includes/_settings"

I used the gulpfile.js from the example:
var gulp = require('gulp');
var sass = require('gulp-sass');

gulp.task('sass', function () {
    gulp.src('./scss/*.scss')
        .pipe(sass())
        .pipe(gulp.dest('./css'));
});
gulp.task('default',['sass']);

The failure was thrown by the @import in style.scss. When i import it like
@import "scss/includes/_settings";

it would work. That means it will use the Working and not the localdir. I wrote a little Workaround for that, but it will be better to set a root-Path to the options wich will be added to opts.includePaths.
module.exports = function (options) {
  var opts = options ? options : {};

  function nodeSass (file, cb) {
    var fileDir = path.dirname(file.path);
    fileDir = path.relative(__dirname,fileDir);
    var tmp = [];
    fileDir.split(path.sep).forEach(function(element) {
      if ('..' != element)
        tmp.push(element);
    });
    fileDir = tmp.join(path.sep)+path.sep;

[...]

I hope it will help,
thanks..

closing


Select all item in multiselect

Description
Maybe this wasn't so hard after all? It's not perfect though.
Shortcomings:

It's not 100% faithful to the design spec in terms of layout; I'm
balancing that against coloring within the lines that Shoelace
offers. I think it doesn't look bad as-is. (I'm planning to replace
Shoelace soon so I don't want to put a ton of effort into getting
it pixel-perfect now.)

When you click the special item, you get a brief flicker of a check
mark next to it. If there's a way to prevent this at all, it would
be a big hack.

The color situation is not ideal. For some reason, Shoelace uses the
same color to highlight the currently-selected option (i.e. the
value of the form control) and the currently-keyboard-focused
option. It uses a different color for the currently-hovered
option. (I would think the same color should be used to indicate
keyboard focus and mouse hover, while currently-selected should be a
different color, if any.)
For the multiselect, I don't want currently-selected options
highlighted at all. This has been weird all along, but the addition
of the select-all option makes it weirder.
It doesn't seem possible to fix this within the official
customization API; it may be possible only with gross hacks, or not
possible at all without modifying Shoelace itself.

Test Plan
Use the control with mouse and with keyboard. Make sure it switches to
"deselect all" when every option is selected.

Probably going to be moot, if we go ahead with landing the Headless UI conversion I'm about to send out.


postgresql table loads failing on code engine deployment

When running ce-install-application.sh , there appear to be certification validation errors when establishing the connection to load table data. Messages like the following appear:
Type         Connection String
PostgreSQL   postgres://admin:$PASSWORD@8b6c161e-d5c5-4380-9652-45c6b6f857d7.c0v4phir0ah9ul9trho0.databases.appdomain.cloud:30911/ibmclouddb?sslmode=verify-full
CLI          PGPASSWORD=$PASSWORD PGSSLROOTCERT=./286a39f3-e1b8-4381-a83b-08ca9153eae0 psql 'host=8b6c161e-d5c5-4380-9652-45c6b6f857d7.c0v4phir0ah9ul9trho0.databases.appdomain.cloud port=30911 dbname=ibmclouddb user=admin sslmode=verify-full'
-------------------------
Create table in postgres using (create-populate-tenant-b.sql)
-------------------------

#!/bin/bash

PGPASSWORD=<redacted> PGSSLROOTCERT=286a39f3-e1b8-4381-a83b-08ca9153eae0 psql 'host=8b6c161e-d5c5-4380-9652-45c6b6f857d7.c0v4phir0ah9ul9trho0.databases.appdomain.cloud port=30911 dbname=ibmclouddb user=ibm_cloud_0ef5ca9b_978d_47f6_b48a_939027e2a295 sslmode=verify-full' -a -f create-populate-tenant-b.sql------------------------------
Verify the given entries and press return
------------------------------
psql: error: connection to server at "8b6c161e-d5c5-4380-9652-45c6b6f857d7.c0v4phir0ah9ul9trho0.databases.appdomain.cloud" (<IP_ADDRESS>), port 30911 failed: SSL error: certificate verify failed

The problem can be seen from the output - the generated CLI example has a preceding ./ for the PGSSLROOTCERT environment variable, whereas the actual command run does not.

Further testing with another way to provide the CLI command continued to fail in verification. Using openssl cert inspector it was found that the certificate being provided by the database instance was not yet valid.
This was a false error - the container running the deployment under podman had an incorrect time caused by the podman machine having clock drift away from the host while the host was in sleep mode.
Resolution was to stop/restart podman machine and then repeat the deployment.


Error in downloading annotations

I am facing an error while downloading the annotations using download_crowdsource_dataset.py. After the 48'th annotation, I receive
Downloading annotations (base mag): Slide 48 of 151 (TCGA-S3-AA15)
Traceback (most recent call last):
File "download_crowdsource_dataset.py", line 218, in
main()
File "download_crowdsource_dataset.py", line 197, in main
download_jsons()
File "download_crowdsource_dataset.py", line 152, in download_jsons
"/annotation/item/" + cf.slides[slide_name]['_id'])
File "/home/reasatt/miniconda3/lib/python3.7/site-packages/girder_client/init.py", line 471, in get
return self.sendRestRequest('GET', path, parameters, jsonResp=jsonResp)
File "/home/reasatt/miniconda3/lib/python3.7/site-packages/girder_client/init.py", line 459, in sendRestRequest
return result.json()
File "/home/reasatt/miniconda3/lib/python3.7/site-packages/requests/models.py", line 889, in json
self.content.decode(encoding), **kwargs
File "/home/reasatt/miniconda3/lib/python3.7/json/init.py", line 348, in loads
return _default_decoder.decode(s)
File "/home/reasatt/miniconda3/lib/python3.7/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/home/reasatt/miniconda3/lib/python3.7/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 8 column 130 (char 505823)

@Reasat Thank you so much for pointing this out. This was a server timeout on our end. With Kitware's help, we've now fixed this issue.


Add possible absolute value function

It takes an input of a number and returns the absolute value of the input

Hi! I can work on this.


bspwm: backport of socket unlink fix to 0.9

Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Backport of https://github.com/baskerville/bspwm/commit/645ad38885bb19a33daa7bd2ec69adc1e51963d4 to bspwm 0.9.0, to fix issues with bspwm not cleaning up its socket.
Issue can be replicated on stock bspwm 0.9 via kill -9 bspwm and then trying to launch bspwm again.
Unnecessary in nixos master as bspwm is on 0.9.1 already.

Maybe we want to update bspwm to 9.6.1 for release instead? It's a bugfix release IIUC.

@abbradar according to the PR here https://github.com/NixOS/nixpkgs/pull/15145, there are breaking changes  between 0.9.0 and 0.9.1.

Oh, thanks for the clarification!


forms formal parameters are not parsed correctly

such a code throws a syntax error despite being valid for 7.02
  PERFORM aaa USING  'sdfsdf' .
FORM aaa USING iv_test TYPE string.
  iv_test = 'asdf'.
  WRITE: 'i am here'.
ENDFORM.

thanks, I've been focusing on getting methods working...

@arcanist123 try again, fixed with 2.7.83


Update fabric-sdk-go to the latest for a fix on cert sanitizing

This pulls in https://github.com/hyperledger/fabric-sdk-go/pull/287 which a critical fix

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (caf8689) 68.78% compared to head (d9bc508) 68.71%.

:exclamation: Current head d9bc508 differs from pull request most recent head ae35476. Consider uploading reports for the commit ae35476 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   68.78%   68.71%   -0.07%
==========================================
  Files          47       47
  Lines        4482     4482
==========================================
- Hits         3083     3080       -3
- Misses       1206     1209       +3
  Partials      193      193

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Indicator]: Gender indicators

Indicator name
Gender indicators
Create or modify indicator?
Create
Contact Details
No response
Corporate Result Framework
Not included nor piloted
Unit owning the indicator
APP-MF
Batch of tasks created - DO NOT MODIFY

[ ] [Task]: R script - {{ data.indicator-name }}
[ ]  [Task]: SPSS script - {{ data.indicator-name }}
[ ]  [Task]: Stata script - {{ data.indicator-name }}

Software version
R, SPSS, Stata, Python
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

3.5 and 3.4 added, SPSS only, no test performed.
See PR: #171


Use python package tsfresh for time-series feature extraction

https://tsfresh.readthedocs.io/en/latest/text/quick_start.html

Check if stationary change (delta) is included as feature. (momentane Änderungsrate)
Can be interesting to see not just the rolling median but also how fast temp or meter readings rose up or fell in the last hour/ hours.

Sounds interesting ;)
Same as in #41 --> implement --> check if useful --> ditch/keep


Scoping and CompiledScript.Execute vs ScriptEngine.Evaluate

Hi Paul
I'm seeing some strange behavior. Just wondering if there is an explanation I'm overlooking.
I have two scripts A and B such as
function main() {
  console.log('Script A');
}
main();

and
function main() {
  console.log('Script B');
}
main();

The key thing is they both rely on the ability to declare the function main in the global scope.
What I am seeing is that running script A via CompiledScript.Execute and then running script B via ScriptEngine.Evaluate results in 'Script A' being logged twice.
Running both via CompiledScript.Execute works as expected.
Running both via ScriptEngine.Evaluate works as expected.
Running script A first via ScriptEngine.Evaluate and then script B via CompiledScript.Execute also works as expected.
It looks as if toplevel scope variables declared via CompiledScript.Execute cannot be overridden via ScriptEngine.Evaluate.
Please note that we still haven't gotten around to updating our engine from v2.2.2, so it is entirely possible that a later version fixes this issue.

Yep, that's definitely wrong, later declarations should override earlier ones.
I tried running this code in the latest version (v3.2.6):
static void Main(string[] args)
{
    var engine = new ScriptEngine();
    engine.SetGlobalValue("console", new Jurassic.Library.FirebugConsole(engine));
    engine.Execute(@"
        function main() {
            console.log('Script A');
        }
        main();");
    engine.Evaluate(@"
        function main() {
            console.log('Script B');
        }
        main();");
}

And it worked as expected. Likely it was fixed when I did a big overhaul of how scoping works a couple years back.
Note that this code prints "Script B" twice, and that's also correct (declarations are processed before code):
static void Main(string[] args)
{
    var engine = new ScriptEngine();
    engine.SetGlobalValue("console", new Jurassic.Library.FirebugConsole(engine));
    engine.Execute(@"
        function main() {
            console.log('Script A');
        }
        main();
        function main() {
            console.log('Script B');
        }
        main();");
}

Thanks for your speedy reply (as always)!
I somehow thought it would be more work testing it out on 3.2.6. I should have given it a go.
I played around with your code and I'm seeing the same thing.
Good to know that it's fixed in 3.2.6. We'll have to put some effort into getting the upgrade under way.

Our scripts are entirely dynamic, and we do have some cases where we rely on variables declared in one script being accessed from others, so scope wiping between runs will break things.
I have started the upgrade. Looks doable for now.

The code I pasted would only touch the value of "main" and nothing else (so not really "scope wiping"), but if the name of the function is dynamic then yeah that'd be problematic.


ExceptionHandler leaking

When undeploying application, Plumbr reports the following PermGen memory leak:
Leaked classloader
org.apache.catalina.loader.WebappClassLoader
The leaking classloader is being held
in com.bugsnag.ExceptionHandler
in defaultUncaughtExceptionHandler of java.lang.Thread
in reference from native code (JNI global)
I create the bugsnag client via a static method in a final class. This is done during application startup.
I'm running Tomcat 7.0.64 with JVM 1.7.0_79-b15

Thanks for the report, @relnah. Taking a look.

Came here to report the same.
If you add a call to ExceptionHandler.remove() in ServletContextListener.contextDestroyed() or something similar, the class loader will be eligible for GC. This solution is likely to be discovered the hard way, would be great if it could be avoided.

@relnah
Is there a fix for this in v3? The method (ExceptionHandler.remove) described above is not available in v3.

@relnah
I just noticed this class:-
https://github.com/bugsnag/bugsnag-java/blob/master/src/main/java/com/bugsnag/ExceptionHandler.java
I assume we need to call ExceptionHandler.disable?
Thanks.
Kamal.

Hi everyone,
The latest version of the Java notifier 3.0.1 now has a close() method which should attempt to clear up any resources that the notifier is using after the bean is finished with. Depending on what frameworks you are using, this may be a more or less manual process, for example if you use Spring and add Bugsnag as a managed bean, this will be called automatically when the bean is destroyed.
Let me know whether this solves or helps solve the issues reported here. If not it would be great if someone could supply a quick example app which does replicate this issue so we can investigate it further.
William

@foygl
Thanks.  Just want to confirm, you are talking about the close method on this class?
https://github.com/bugsnag/bugsnag-java/blob/master/src/main/java/com/bugsnag/Bugsnag.java
Thanks.
Kamal.

Yep - that's the one @KamBha


"undefined method `name' for nil:NilClass" when running "danger plugins"

danger.systems's build is breaking due to an error on danger plugins command. It executes bundle exec rake generate, which internally calls bundle exec danger plugins json <plugin-name> for each external plugin.
Investigating a little bit, I was able to find that this return statement is being called outside of the Dir.chdir(dir) block, which makes paths and gems methods run out of the temp dir scope. The solution could be either call Dir.chdir(dir) on both methods or pass the temporary dir as an argument.
Report
What did you do?
Run bundle exec danger plugins json danger-prose
What did you expect to happen?
Output correct plugin metadata
What happened instead?
bundler: failed to load command: danger (/Users/gustavo/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/bin/danger)
NoMethodError: undefined method `name' for nil:NilClass
  /Users/gustavo/Developer/danger/lib/danger/plugin_support/gems_resolver.rb:60:in `gem_metadata'
  /Users/gustavo/Developer/danger/lib/danger/plugin_support/gems_resolver.rb:47:in `block in gems'
  /Users/gustavo/Developer/danger/lib/danger/plugin_support/gems_resolver.rb:47:in `map'
  /Users/gustavo/Developer/danger/lib/danger/plugin_support/gems_resolver.rb:47:in `gems'
  /Users/gustavo/Developer/danger/lib/danger/plugin_support/gems_resolver.rb:19:in `call'
  /Users/gustavo/Developer/danger/lib/danger/plugin_support/plugin_file_resolver.rb:18:in `resolve'
  /Users/gustavo/Developer/danger/lib/danger/commands/plugins/plugin_json.rb:30:in `run'
  /Users/gustavo/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/claide-1.0.1/lib/claide/command.rb:334:in `run'
  /Users/gustavo/Developer/danger/bin/danger:5:in `<top (required)>'
  /Users/gustavo/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/bin/danger:23:in `load'
  /Users/gustavo/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/bin/danger:23:in `<top (required)>'

Your Environment

Which CI are you running on? Local environment
Are you running the latest version of Danger? Yes (4.0.3)
What is your Dangerfile? N/A

My pleasure!


feature: allow searching by ISO code

I was missing a way to quickly search a country by ISO code, e.g. "US" for United States, or "DK" for "Denmark".
This PR enables that functionality.
And oh, thanks for a super sweet library. Well done! I've been wasting too much time today trying 3-4 different libraries and trying to customize them to my needs, only to find this is by far the best library for Flutter out there.

Closed in favour of: https://github.com/cedvdb/phone_form_field/pull/161 to separate PRs


Delete unecessary ending tags

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


Structured header parameter parser is too loose

A parameter name missing leading and/or trailing _ is accepted, probably erroneously. For example, _modifiers: a Modifiers, (as currently in proposal-regexp-modifiers spec) renders like "_modifiers (a Modifiers)" with the literal _ visible and "modifiers" not wrapped in a <var> element (as currently in proposal-regexp-modifiers HTML).
The responsible code appears to be at https://github.com/tc39/ecmarkup/blob/994d663ee9245689f4d62baaffdcbfa055d5b404/src/header-parser.ts#L140
/^[A-Za-z0-9_]+ */i should probably be replaced with /^_[A-Za-z0-9]+_ */i, or maybe /^(?:_[A-Za-z0-9]+_|[A-Za-z0-9]+) */i if we want to support parameter names not wrapped in _ (which I'd personally be against). And incidentally, I also note that the i flag is redundant with A-Za-z.

Yeah, there should be a lint rule for this. (I prefer a lint rule to outright rejecting these inputs because it's nicer to get some output while iterating.)


Notebook: switching from Notebook to .json file and back loses all work

Issue Type: Bug

Open a folder with notebooks and other files (see https://github.com/kevcunnane/msbuild_ads_demo for example).
Open a notebook file and a .json file
Make edits to the notebook (e.g. add some cells), then switch to the .json and edit, then switch back

Expected:

Notebook shows the last edited state

Actual:

Notebook shows initial state on first open, not the last edited state
If you tab away then click on the notebook in the file tree, it'll load with correct state

This is, needless to say, very bad. I'm not sure if this is a regression so we should investigate, but it's got high risk. If I saved in its "showing initial content" state it would lose all active work.
@YurongHe can you please investigate for May release and see if this is a potential release blocker?
Screenshots
Initial:

Edited:

View after switching to package.json and back:

Azure Data Studio version: Azure Data Studio 1.7.0-insider (c7f5278430b9df35fb6e160a5b1cf4c653644efc, 2019-05-03T07:13:39.307Z)
OS version: Darwin x64 18.5.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.83GB free)

Process Argv
-psn_0_5981620

Screen Reader
no

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

azdata-sanddance
dan
0.2.290

azuredatastudio-postgresql
Mic
0.1.0

@kevcunnane, when you switch between files, did you notice the dirty state of notebook is changed?
I can see the problem when the notebook is loading kernel. But not in ready state.

Got the same behavior in April release.

Chris and I got a repro under specific situation, which related to open folder->file re-hydration. Vs code does the same thing. https://github.com/microsoft/vscode/issues/73854

@kevcunnane, "This is, needless to say, very bad. I'm not sure if this is a regression so we should investigate, but it's got high risk. If I saved in its "showing initial content" state it would lose all active work."
The problem we got yesterday is by design and it is using different steps.
I can't repro. Do you save the notebook file before editing json file or tab away?

This is so hard to repro - reducing priority and moving out of current milestone.

Close as not repro for now, can reopen if we manage to recreate.


Brute force interpolated obfuscation (Multithreaded)

Is your feature request related to a problem? Please describe.
It is related to many problems.
Describe the solution you'd like
Brute forcing the interpolation is the future.
Describe alternatives you've considered
ArtemisAC
Additional context
Please take this into consideration, Elon musk invented this and it is already being used
In plenty of public projects such as NASA or Tesla.
Thanks in advance, Yours sincirely Nik.
Here's the mathematical formula:
600 * 14 / 73 + 41 - 512 + CACHED_RANDOM * 500 / 2 * 2
 / (Double.NEGATIVE_INFINITY * 1.00000D) * 9412 % 1 / (Double.MAX_EXPONENT * 1.00000D)
% 1 * 599D / 2 % 96 + 1D * 9521 / 2 * 200 % .7 / 2 * 2000
% 1 * 4.71D / 2 * CACHED_RANDOM * .001D % 61 / 5 * 421D
/ 600 * 14 / 73 + 41 - 512 + CACHED_RANDOM * 500 / 2 * 2
% 1 * 599D / 2 % 96 + 1D * 9521 / 2 * 200 % .7 / 2 * 2000
* 50 % 2 / 6113 * (Math.PI * 1.00000D) / (Math.E * 1.00000D) * 5000 % Math.random() * .2
/ (Double.NEGATIVE_INFINITY * 1.00000D) * 9412 % 1 / (Double.MAX_EXPONENT * 1.00000D)
 / 100 / (Double.NEGATIVE_INFINITY * 1.00000D) * 9412 % 1 / (Double.MAX_EXPONENT * 1.00000D)
/ 600 * 14 / 73 + 41 - 512 + CACHED_RANDOM * 500 / 2 * 2
/ (Double.NEGATIVE_INFINITY * 1.00000D) * 9412 % 1 / (Double.MAX_EXPONENT * 1.00000D)
% 1 * 4.71D / 2 * CACHED_RANDOM * .001D % 61 / 5 * 421D
/ (Double.NEGATIVE_INFINITY * 1.00000D) * 9412 % 1 / (Double.MAX_EXPONENT * 1.00000D)
% 1 * 599D / 2 % 96 + 1D * 9521 / 2 * 200 % .7 / 2 * 2000```

EDIT
This issue is related to these two, Made by Generic and Electrum in the AliceAPI.
https://github.com/NikV2/AliceAPI/issues/29
https://github.com/NikV2/AliceAPI/issues/52

Almost forgot about this.

Added in f0c60ffb1d6bd1ee91c699d6dc326f962bec353e


Validate fields submitted by users to /register and /update.

Validate both client and server side.

Completed by #86


Highlight create_distributed_function

Fixes #886

@marcocitus one difficulty I ran into is that our tutorial is supposed to be able to run on Docker or a simple single-server installation. However when I do that I get this error:
ERROR:  cannot colocate function "delete_campaign" and table "campaigns"
DETAIL:  Citus currently only supports colocating function with distributed tables that are created using streaming replication model.
HINT:  When distributing tables make sure that citus.replication_model = 'streaming'

I had to run it on a PaaS such as Hyperscale that has streaming replication set up. Is there a workaround?

Issue on why streaming is required: https://github.com/citusdata/citus/issues/3126

@marcocitus says we should be good to suggest people enable streaming replication in our tutorial, so I made the change.


small typo, big consequences

Description
while reading the variable names, I've stumbled upon a variable named putin_khuylo
I totally disagree with this grammar. Usually "kh" is used to describe fricative sounds, so European languages do not have this sound. It would be proper to use just "h" (huylo), or maybe "x" (xuylo).
What do you think ?
If need be I can send a PR.

[x ] ✋ I have searched the open/closed issues and my issue is not listed.

⚠ Note
Before you submit an issue, please perform the following first:
Versions

Module version [Required]: v4.2.0

Terraform version:

Provider version(s):

Terraform v1.1.7
on darwin_amd64
+ provider registry.terraform.io/hashicorp/aws v4.9.0
+ provider registry.terraform.io/hashicorp/cloudinit v2.2.0
+ provider registry.terraform.io/hashicorp/helm v2.5.1
+ provider registry.terraform.io/hashicorp/kubernetes v2.10.0
+ provider registry.terraform.io/hashicorp/tls v3.3.0

Reproduction Code [Required]

Steps to reproduce the behavior:
N/A

No

Yes

rm -fr .terraform terraform.hcl.* *.tfstate
Expected behavior

Actual behavior

Terminal Output Screenshot(s)

Additional context

Thank you for the input, Max!
I took the spelling from English Wikipedia - https://en.wikipedia.org/wiki/Putin_khuylo!
I believe that people writing, reading, and proofreading the articles there just can't be wrong, so I will close this improvement for the time being.
Glory to Ukraine! 🇺🇦❤


Add additional styling controls

I had a need to control cell colouring, rotation for manually crafting some Excel files. I've been using this code in production since at least 2017, just thought I would share my commits if anyone else would like to use them.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ocdi sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

you can see this picture.


The latest bridge library update causes crash on startup

The matrix-org/matrix-appservice-bridge library was recently updated to use 0.7.3 of mtarix-org/matrix-js-sdk. The twitter bridge depends on js-sdk version 0.5.3, which does not have a particular function in the client instance, giving a stack trace:
Unhandled rejection TypeError: this._sdk.wrapRequest is not a function
    at ClientFactory.setLogFunction (/home/lukeb/dev/mx-as-twitter/node_modules/matrix-appservice-bridge/lib/components/client-factory.js:40:15)
    at Bridge.run (/home/lukeb/dev/mx-as-twitter/node_modules/matrix-appservice-bridge/lib/bridge.js:199:25)

The bridge should probably be using one version of the js-sdk: the same as the bridge library. Otherwise there would have to be two js-sdk dependencies installed somehow.

I saved this for a rainy day, and now feels relevant! It's a report that helped me upgrade the IRC bridge js-sdk dependency:
matrix-as-bridge API usage of matrix-js-sdk
comparing js-sdk versions 0.5.3 and 0.7.1
Example command to gather API changes:
cd matrix-js-sdk
git diff v0.5.3..v0.7.1 -- lib/ | grep -A 20 -B 20 .prototype.sendStateEvent

client.credentials.userId

Seems to still exist, and still could be null

client._http.authedRequestWithPrefix()

Signature is the same
The diff looks like a refactor:

-        var fullUri = this.opts.baseUrl + prefix + path;
-        if (!queryParams) {
-            queryParams = {};
-        }
-        queryParams.access_token = this.opts.accessToken;
-        return this._request(
-            callback, method, fullUri, queryParams, data, localTimeoutMs
+        return this.authedRequest(
+            callback, method, path, queryParams, data, {
+                localTimeoutMs: localTimeoutMs,
+                prefix: prefix,
+            }

(and upon investigation, it was just a refactor that behaves very similarly if not identically)
client._http.opts._reqId

Never existed, and so was probably always ignored

client.sendEvent

E2E message sending has been factored out to a private function

client.createRoom

(SyncAPI.prototype.createRoom was changed, but this is unimportant)

client.sendStateEvent
client.roomState
client.createRoom
client.getProfileInfo
client.createAlias
client.getStateEvent

Factored out to base-apis, but otherwise unchanged

client.sendTyping
client.sendReadReceipt
client.setPowerLevel
client.invite
client.kick
client.ban
client.unban
client.leave
client.setDisplayName
client.setAvatarUrl
client.joinRoom

No change

Fixed by 66a65ba93c08ff103e6e1c02b559f887ac30b077


json highlighting is broken in atom 1.38.0

As you can see almost is underscored and "marked" as "links"
Also invalid sintax is not recognized (marked by red rectangle by me)

Thanks for taking the time to contribute!
We noticed that this is a duplicate of https://github.com/atom/language-json/issues/75. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Update manifest.json

This should allow it to show up in Spicetify Marketplace. It just had a copy of the Fluent manifest before.

ig team spicetify asked me to develop this theme in my own repo
anyways, thanks for your fix


Internal error occurred: failed calling webhook "rancher.cattle.io.clusters.management.cattle.io": failed to call webhook: Post "https://rancher-webhook.cattle-system.svc:443/v1/webhook/mutation/clusters.management.cattle.io?timeout=10s": no endpoints available for service "rancher-webhook"

Setup

Rancher version: v2.8.2
Rancher UI Extensions:v2.8.0
Browser type & version: Chrome Latest

Describe the bug
No change in the server and also in the cluster suddenly this issue came from nowhere and the rancher cluster is not responding tried all the steps found on internet.

Reproduce the certificate
Checked the webhook pod it is up and running
Check the webhooks service it is running
check the mutating and validation configuration it is also available

Screenshots

Looks similar to https://github.com/rancher/rancher/issues/45841


Query: AQL: missing variable # for node #... location RestCursorHandler.cpp

My Environment

ArangoDB Version:        3.8.1
Storage Engine:             RocksDB
Deployment Mode:       Single Server
Deployment Strategy:   ArangoDB Starter in Docker
Configuration:               -
Infrastructure:               own
Operating System:        MacOS 11.6
Total RAM in your machine:
Disks in use:        SSD
Used Package:             image: arangodb:3.8

Component, Query & Data
Affected feature:
AQL query (if applicable):
for doc in UNION(
  (
    for doc in @@impressionCollection1
      FILTER doc.dt >= @from AND doc.dt < @to
      COLLECT fr_fd_date=DATE_FORMAT(DATE_TRUNC(doc.dt,"day"),"%yyyy-%mm-%dd")
      AGGREGATE fr_fr_views=SUM(doc.im * doc.au)
      LIMIT 1000000
      RETURN { fr_fd_date,fr_fr_views }
  ),[])
 LIMIT 1000000
return doc

AQL explain and/or profile (if applicable):
Dataset:
Collection with one document should be enought:
{
"dt":<PHONE_NUMBER>933,
"au": 17.0111,
"im": 1
}
Size of your Dataset on disk:
N/A
Replication Factor & Number of Shards (Cluster only):
Steps to reproduce

Run AQL query

Problem:
Query: AQL: missing variable #17 (16) for node #6 (CalculationNode) while planning registers (exception location: /work/ArangoDB/arangod/Aql/RegisterPlan.cpp:176). Please report this error to arangodb.com (while optimizing plan) (exception location: /work/ArangoDB/arangod/RestHandler/RestCursorHandler.cpp:290). Please report this error to arangodb.com
Expected result:
Empty or some results.

@hwde: could you also supply the exact bind parameter values and which exact indexes are present on the underlying collections? It may have to do with that, because I tried the query locally and didn't run into this problem. Thanks!

My JSON bind-values are
{
	"@impressionCollection1": "foo",
	"from":<PHONE_NUMBER>000,
	"to":<PHONE_NUMBER>000
}

and the collections structure from a dump is:
{"indexes":[{"id":"6027727","type":"persistent","name":"idx_1644469791088443392","fields":["ci"],"unique":false,"sparse":false,"deduplicate":true,"estimates":true},{"id":"6027731","type":"persistent","name":"idx_1644469791089491968","fields":["pi","dt"],"unique":false,"sparse":false,"deduplicate":true,"estimates":true},{"id":"6027735","type":"persistent","name":"idx_1644469791089491969","fields":["dt","pi"],"unique":false,"sparse":false,"deduplicate":true,"estimates":true}],"parameters":{"allowUserKeys":true,"cacheEnabled":false,"cid":"198","deleted":false,"globallyUniqueId":"h1B711C0145F8/6027722","id":"198","isDisjoint":false,"isSmart":false,"isSmartChild":false,"isSystem":false,"keyOptions":{"allowUserKeys":true,"type":"traditional","lastValue":629451},"minReplicationFactor":1,"name":"foo","numberOfShards":1,"planId":"6027722","replicationFactor":1,"schema":null,"shardKeys":["_key"],"shards":{},"status":3,"syncByRevision":false,"type":2,"usesRevisionsAsDocumentIds":false,"version":9,"waitForSync":false,"writeConcern":1}}

I get the error even if I truncate the collection or drop the docker volume and restored from a previous dump.

Now I was able to reproduce with a newly created collection:

Open UI, add a collection "foo"
go to "Indexes" of foo, click "add"
select "primary", set field to "dt" and name to "dt", click "Create"
run query.

Fixed via the 2 above PRs, targeting 3.8.2 and 3.9.0.

Hi @hwde,
I am closing this issue since a fix is available in latest versions 3.7.17, 3.8.6 and 3.9.0.
In case an error still occurs, please comment or open a new issue.


RTL 8188EUS does not work on Raspberry PI

Hello
i tried this.
uname -a
sudo apt purge firmware-realtek
sudo wget http://downloads.fars-robotics.net/wifi-drivers/8188eu-drivers/8188eu-5.4.79-1373.tar.gz
sudo tar xzf 8188eu-5.4.79-1373.tar.gz
./install.sh
The AP for normal work was sucessfull, but it does not work with Tuya Convert. It will not connect the device with the AP.
If i try a RT5370 with the same config everything works fine.
Here the log of RT5370
smarthack-wifi_RT5370.log

hostapd.conf

interface=wlan0
driver=nl80211
ssid=hostapd1
channel=1
hw_mode=g
auth_algs=1
wpa=2
wpa_passphrase=123456789
Here the log of RTL81888EUS
smarthack-wifi_8188eus.log
I have used the driver from here.
https://www.raspberrypi.org/forums/viewtopic.php?uid=81098&f=28&t=62371&start=0#p462982
What can i do ?
BR
Mathias

I have new information.
8188eus.txt
nl80211: Set wlan0 operstate 0->1 (UP)
netlink: Operstate: ifindex=3 linkmode=-1 (no change), operstate=6 (IF_OPER_UP)
nl80211: TX queue param set: queue=0 aifs=1 cw_min=3 cw_max=7 burst_time=15 -->                                                                                res=-95
Failed to set TX queue parameters for queue 0.
nl80211: TX queue param set: queue=1 aifs=1 cw_min=7 cw_max=15 burst_time=30 -->                                                                                res=-95
Failed to set TX queue parameters for queue 1.
nl80211: TX queue param set: queue=2 aifs=3 cw_min=15 cw_max=63 burst_time=0 -->                                                                                res=-95
Failed to set TX queue parameters for queue 2.
nl80211: TX queue param set: queue=3 aifs=7 cw_min=15 cw_max=1023 burst_time=0 -                                                                                -> res=-95
Failed to set TX queue parameters for queue 3.
nl80211: Set Deny ACL (num_mac_acl=0)
wlan0: interface state UNINITIALIZED->ENABLED
wlan0: AP-ENABLED
wlan0: Setup of interface done.
ctrl_iface not configured!
ralink5370.txt
nl80211: Set wlan0 operstate 0->1 (UP)
netlink: Operstate: ifindex=3 linkmode=-1 (no change), operstate=6 (IF_OPER_UP)
nl80211: TX queue param set: queue=0 aifs=1 cw_min=3 cw_max=7 burst_time=15 --> res=0
nl80211: TX queue param set: queue=1 aifs=1 cw_min=7 cw_max=15 burst_time=30 --> res=0
nl80211: TX queue param set: queue=2 aifs=3 cw_min=15 cw_max=63 burst_time=0 --> res=0
nl80211: TX queue param set: queue=3 aifs=7 cw_min=15 cw_max=1023 burst_time=0 --> res=0
wlan0: interface state UNINITIALIZED->ENABLED
wlan0: AP-ENABLED
wlan0: Setup of interface done.
ctrl_iface not configured!
RTM_NEWLINK: ifi_index=3 ifname=wlan0 operstate=2 linkmode=0 ifi_family=0 ifi_flags=0x1002 ()
nl80211: Ignore interface down event since interface wlan0 is up
RTM_NEWLINK: ifi_index=3 ifname=wlan0 operstate=2 linkmode=0 ifi_family=0 ifi_flags=0x1003 ([UP])
RTM_NEWLINK: ifi_index=3 ifname=wlan0 operstate=6 linkmode=0 ifi_family=0 ifi_flags=0x11043 ([UP][RUNNING][LOWER_UP])
VLAN: RTM_NEWLINK: ifi_index=3 ifname=wlan0 ifi_family=0 ifi_flags=0x11043 ([UP][RUNNING][LOWER_UP])
VLAN: vlan_newlink(wlan0)
BR
Mathias


Renderer redesign v4

Goals:

2D matrices
Opacity uniform
Multiple renderers at the same time
Simple interface for common tasks

#571 is a first step towards multiple renderers at the same time: it always uses the output's renderer (instead of the global server->renderer). When using multiple renderers, far less GL errors are triggered. The only place server->renderer is still used is to upload textures in wlr_surface. Uploading a texture using one renderer and drawing it using another one probably doesn't work.

Bits that still need to be ported from the old renderer redesign PR (#319):

[x] Screenshooter
[x] Matrix
[ ] Renderer (GL_KHR_debug, remove global state)
[ ] Texture (immutable, always use EGL images)
[ ] wlr_render_subtexture and use that for damage tracking
[ ] Check nobody's using raw GL calls anymore
[ ] EGL_KHR_debug

Things that could be done after that:

Remove wlr_render from wlr_surface. They are causing wlr_render to be a non-optional type.
A wlr_tex_export_dmabuf function, which may be useful for future multi-GPU work.

always use EGL images

Unfortunately, some drivers are really picky (intel) and don't allow using EGLimages created from a "local" texture, so I had to remove that in my renderer PR.

Simple interface for common tasks

Could you elaborate on this? Is the new
bool wlr_render_texture(struct wlr_renderer *r, struct wlr_texture *texture,
	const float projection[static 9], int x, int y, float alpha);

enough?

Most of the stuff has been done. Opening a separate issue for the remaining feature: #778.


WIP RF history

Codecov Report
Base: 70.46% // Head: 72.50% // Increases project coverage by +2.04% :tada:

Coverage data is based on head (28c6b22) compared to base (615b6a6).
Patch coverage: 86.48% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   70.46%   72.50%   +2.04%
==========================================
  Files          19       19
  Lines        1212     1222      +10
  Branches      252      244       -8
==========================================
+ Hits          854      886      +32
+ Misses        286      262      -24
- Partials       72       74       +2

Impacted Files
Coverage Δ

onyo/utils.py
61.41% <ø> (ø)

onyo/commands/history.py
89.13% <86.48%> (+64.13%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Store the routing key along with the message

Fixes #13

Why not cache the whole message as is instead?

Dunno :P can change that
On Apr 13, 2015 6:14 PM, "Alvaro Videla"<EMAIL_ADDRESS>wrote:

Why not cache the whole message as is instead?
—
Reply to this email directly or view it on GitHub
https://github.com/videlalvaro/rabbitmq-recent-history-exchange/pull/15#issuecomment-92300306
.

Keep in mind this exchange, besides it usefulness, started as a teaching example for the book, that's why the functions are so broken up into small pieces and so on. Not storing full messages might be something from those times… or from basing this exchange on the LVC plugin.
So having this feature moved storing messages could actually makes thing simpler in the code and more future proof.


First Usage Instructions - Training on another dataset

Firstly, I would like to thank you for this amazing work.
I am interested in using your implementation on image-to-image translation (synthetic to real-world data) on my own dataset, for example, GTA to Cityscape as done by the UNIT.
What are the steps of getting your implementation running on my dataset ?

Hi. Thanks for your interest in this work.
If your dataset only contains images without labels, then converting them to tfrecord and changing the flags should do the trick.
I haven't tried GTA to Cityscape, but training may be hard on those datasets. Feel free to share your results on this thread.


Config-level parquet-and-dataset-info

Will solve https://github.com/huggingface/datasets-server/issues/866
Part of https://github.com/huggingface/datasets-server/issues/735
Questions:

Didn't I miss anything?
Should there be any migration jobs? Technically it's a new job runner, it's not equal to the previous dataset-level one (results are not identical), and the old one doesn't exist anymore.
Can I rename relevant environmental variables (like PARQUET_AND_DATASET_INFO_BLOCKED_DATASETS -> to PARQUET_AND_INFO_BLOCKED_DATASETS) or might it break anything?

Codecov Report
Patch coverage has no change and project coverage change: -9.43 :warning:

Comparison is base (f31723e) 91.57% compared to head (e90dbcc) 82.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #985      +/-   ##
==========================================
- Coverage   91.57%   82.15%   -9.43%
==========================================
  Files          53       35      -18
  Lines        3740      762    -2978
==========================================
- Hits         3425      626    -2799
+ Misses        315      136     -179

Flag
Coverage Δ

jobs_cache_refresh
98.50% <ø> (?)

jobs_mongodb_migration
80.57% <ø> (?)

services_worker
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 88 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Wow, big PR!

Should there be any migration jobs? Technically it's a new job runner, it's not equal to the previous dataset-level one (results are not identical), and the old one doesn't exist anymore.

I think the best strategy in this PR would have been to:

keep the old /parquet-and-dataset-info
add the new config-parquet-and-info step,
make all the other steps depend on config-parquet-and-info instead of /parquet-and-dataset-info

Then in a new PR, once the cache for the new step has been filled, deprecate the old one (remove the step and delete the entries in the cache).
Otherwise, the /parquet, /info and /size endpoints will be broken for every dataset until the job has been run again.

Can I rename relevant environmental variables (like PARQUET_AND_DATASET_INFO_BLOCKED_DATASETS -> to PARQUET_AND_INFO_BLOCKED_DATASETS) or might it break anything?

No, good idea. We just have to take care to replace every occurrence.

@severo I've got back /parquet-and-dataset-info's code and tests for it (don't be scared by the number of additions in this PR it's actually mostly because of these duplicated tests) and changed env variables (hopefully everywhere), is there anything else that must be done? It just exists but no steps are dependent on it. I don't fully understand if it would work correctly. And I'm not sure if made all the required changes to chart/templates/_envWorker.tpl.

@severo another round :D I've implemented file deletion strategy and cloning from initial commit. I haven't implemented any normalization of config names because datasets lib doesn't have any normalization and huggingface_hub only uses normpath to filenames which leads to conversion of tabs and new lines to spaces but we anyway don't treat config with spaces correctly as far as I remember and I think we don't have a lot of datasets with config names containing whitespaces. there is also this validation function in huggingface_hub but it basically fixes/raises for files with slashes which are not allowed by datasets anyway. So I'd suggest to address this in another issue, wdyt?

So I'd suggest to address this in another issue, wdyt?

Yes, totally!


please bump version const

now is 0.6.1, but
https://github.com/daixiang0/gci/blob/ee9caf4c009af84cfffe196d47a2e956b8d5287b/main.go#L9

Thanks for


save test coverages in the repo

when merging code, the code coverage shall be updated and merged with the code.
we can have a helper script for that maybe.

Firstly i want to add coverage badge. When main branches get to new codes, this badge will be updated.
I will use this repo for this work; https://github.com/ncruces/go-coverage-report
It's good choice cause when we click coverage badge it go to coverage.html
I added screen shots.

If this okay for you, you can assigne to me.

It looks good to me; assigned.
Have fun 🚀 .

plus;
https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions
From this article I understand that we have 2000 minutes per month.
I think you'd want to check this out.
But other vmware's repositories use github actions.

Thanks for the reference.
That should be okay, I think.

Closing this one since the reports are there.


chore(ci): Add missing no_std crates

Description
Adds missing crates to the no_std checks that support no_std.

📚 $\text{Stack Overview}$
Pulls submitted in this stack:

#310 👈
main

This comment was automatically generated by st.


[1.16.3] Crash when Resourceful Bees mod is present

Forge: 34.1.25
Resourceful Bees 1.16.3-0.5.5b (and 2 previous versions)
dungeons_gear-1.16.2+1.16.3-2.0.12.jar (and several previous versions)
logs: https://gist.github.com/bessiq/4530d87371be852324d74493fbd9d28b
Not sure which mod is at fault, as both mods work fine if the other is not enabled. I thought I'd post here first to see what you think. Basically, the game crashes during Forge early loading when these two mods are enabled together. I know you recently added some kind of bee functionality, which I assume might be conflicting with something RBees is trying to do.
Thanks for any help you can provide.

This is their fault. They access transformed a method in an AI class called HurtByTarget, which all mobs that attack when provoked use, from private/protected to public. As I use a mixin for the same class to fix a glaring error inside that method, the mod loaded complains that I am making a public method private/protected in my mixin because Resourceful Bees made it public with their access transformer.
They should reduce their access transform usage in general to prevent problems like this. It is especially heinous in this case as that method doesn’t need to be access transformed in the first place.

Thanks for the reply. I am going to open an issue with them and reference this issue to save some typing if that's cool.

Link them to this part of my code so they can see why there's an issue:
https://github.com/Thelnfamous1/Dungeons-Gear/blob/master/src/main/java/com/infamous/dungeons_gear/mixin/HurtByTargetGoalMixin.java


Athena configuration incomplete

Describe the bug
Error in pod logs after following AWS integration instructions for OpenCost and KubeCost for Athena integration.
To Reproduce
Steps to reproduce the behavior:

Configure config map below.

apiVersion: v1
kind: ConfigMap
metadata:
  name: opencost-aws
  namespace: opencost
data:
  aws.json: |
    {
        "provider": "aws",
        "description": "AWS Provider Configuration. Provides default values used if instance type or spot information is not found.",
        "CPU": "0.031611",
        "spotCPU": "0.006655",
        "RAM": "0.004237",
        "GPU": "0.95",
        "spotRAM": "0.000892",
        "storage": "0.000138888889",
        "zoneNetworkEgress": "0.01",
        "regionNetworkEgress": "0.01",
        "internetNetworkEgress": "0.143",
        "spotLabel": "kops.k8s.io/instancegroup",
        "spotLabelValue": "spotinstance-nodes",
        "awsSpotDataRegion":"eu-west-1",
        "awsSpotDataBucket": "iobspotdatafeedsubscription",
        "awsSpotDataPrefix": "spot-datafeed",
        "athenaBucketName": "s3://aws-athena-query-results-REDACTED-eu-west-1",
        "athenaRegion": "eu-west-1",
        "athenaDatabase": "athenacurcfn_opencost_report",
        "athenaTable": "opencost_report",
        "projectID": "REDACTED"
    }

Install opencost on AKS using helm chart

Extract of the values.yaml that configures the configmap.
opencost:
  exporter:
    extraEnv:
      CONFIG_PATH: "/tmp/custom-config"
    extraVolumeMounts:
      - mountPath: /tmp/custom-config
        name: custom-configs

extraVolumes:
  - name: custom-configs
    configMap:
      name: opencost-aws

View pod logs and see the following errors.

2023-10-13T09:59:20.927916579Z ERR Failed to lookup reserved instance data: no reservation data available in Athena
2023-10-13T09:59:20.927937945Z ERR Failed to lookup savings plan data: Error fetching Savings Plan Data: QueryAthenaPaginated: athena configuration incomplete

Expected behavior
Athena integration should work according to the Kubecost documents
Which version of OpenCost are you using?
Helm chart version 1.20.1
Opencost App Version 1.106.2

This has been resolved, i hadn't setup the correct IAM permissions.


Switch inputs type to number to set values with scroll wheel

Whenever you double click a numeric value to show the popup dialog to manually set it, the input type is text, which means you don't get the native up/down arrows and scroll wheel does nothing.
Switching those inputs to type="number" and adding step="0.05" would show the arrows, and allow keyboard up/down arrows and mouse wheel to change the value in 0.05 increments/decrements. Also, min and max attributes can limit the values whenever needed. Having to manually type values while you could use the mouse wheel to change them is rather cumbersome.
➡ Input type number on MDN

The problem with this is you then cant enter expressions, e.g.

I've added an option for this as I guess people may not care about that ^


inline suggestions interfere with autocomplete suggestion selection

Does this issue occur when all extensions are disabled?: No because inline suggestions are not available w/o an extension.

VS Code Version: 1.84.0-insider
OS Version: Mac OS 13.6

Steps to Reproduce:

Enable an extension that supports inline suggestions such as Copilot or Codeium
Set "editor.quickSuggestionsDelay" to 1000. This simulates lag that may occur when working in a larger project.
Enter text that triggers an inline suggestion
Wait for the autocomplete suggestions to appear
-> The selected autocomplete suggstion is based on the inline suggestion rather than always being the first item

In this screen recording you can see that when I type "clo" the inline suggestion appears for "close();". However when the autocomplete suggestions appear the selected item is not the "consoleLogObject" snippet which is the first and highest-ranked suggestion (and the one I wanted) but is instead the close function which matches the inline suggestion that appeared earlier.
https://github.com/microsoft/vscode/assets/667716/b6ddc8bc-9218-43f0-8103-65293454b4fc

@hediet Can this be controlled or does inline suggest always select a completion?

Yeah, maybe a setting or just disable inline suggestions if this annoying. Having inline suggestion and none matching completions would also be weird

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

Yeah, maybe a setting or just disable inline suggestions if this annoying. Having inline suggestion and none matching completions would also be weird

I'm curious why you say that. I expect completions to show up when I type, but I think of inline suggestions as entirely distinct from what I'm typing until I've accepted them.

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

Very annoying. Maybe, something should be done about this? 🙏


MSTest 2.2.4+ does not runs tests contained in classes with non alphanumeric characters in the class name

This works fine with MSTest.TestAdapter and MSTest.TestFramework 2.2.3, but the test is skipped with 2.2.4 or 2.2.5.
module x.TestProject1

open System
open Microsoft.VisualStudio.TestTools.UnitTesting

[<TestClass>]
type ``babette la morue`` () =

    [<TestMethod>]
    member this.TestMethodPassing () =
        Assert.IsTrue(true);

I get the following output from dotnet test:
PS C:\Users\souellet\source\repos\TestProject1> dotnet test
  Determining projects to restore...
  All projects are up-to-date for restore.
  TestProject1 -> C:\Users\souellet\source\repos\TestProject1\bin\Debug\net5.0\TestProject1.dll
Test run for C:\Users\souellet\source\repos\TestProject1\bin\Debug\net5.0\TestProject1.dll (.NETCoreApp,Version=v5.0)
Microsoft (R) Test Execution Command Line Tool Version 16.11.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
  Skipped TestMethodPassing

None     - Failed:     0, Passed:     0, Skipped:     0, Total:     0, Duration: 2 ms - TestProject1.dll (net5.0)
PS C:\Users\souellet\source\repos\TestProject1>

Visual Studio 16.11.1
dotnet --info says:
C:\Windows\System32>dotnet --info
.NET SDK (reflecting any global.json):
 Version:   5.0.400
 Commit:    d61950f9bf

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.18363
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\5.0.400\

Host (useful for support):
  Version: 5.0.9
  Commit:  208e377a53

I can reproduce the issue. Looks like the space is causing issue.

This is not linked to the test ID generation but was linked to a bug in hierarchy processing. Updating our object model dependency fixed the issue.
I will close the issue and confirm fix will be included in v3.


Finally add linter and formatter

[ ] Follow this tutorial to integrate a linter and a formatter
[ ] Add a formatting step as a pre-commit hook
[ ] add mypy
[ ] If possible make optional pre-commit hooks for linting
[ ] Check linting status on merge
[ ] All this stuff should be in a separate requirements-dev.txt
[ ] Merging should only be possible if all linter checks are ok

Depends on #173


Traffic honoring separated lanes

Hi, this is Lazarus Man, author of NExt2.  As the title implies, I would like to add an enhancement (possibly as an option) to allow pathfinding to recognize split lanes.  The game kinda already does this if the NetInfo.m_CanCrossLanes = true.  This prevents cars from crossing oncoming traffic on roads with medians such as the vanilla medium road.  However, I wanted to take this a step further and prevent traffic from switching into any lanes that are separated by a barrier.
Currently I am working on https://streetmix.net/-/723477.  There are 4 lanes in the middle of the road with a detached parking lane on each side.  This enhancement would only allow the detached park lane to be accessed at junctions.  Since these parking lanes are a bit slower than the center four lanes, cars would only enter this lane to park, bus stop, or make a right turn at the next intersection.  I have already developed a POC where cars cannot jump the barrier (except emergency vehicles) and LaneConnections cannot be made over the barrier.  Roads with center barriers also will prevent users from making U-turn LaneConnections, UNLESS NetInfo.m_CanCrossLanes = false. While I watched this road mechanic under heavy traffic I realized that it would be very useful for situations where plenty of hand drawn LaneConnections would be needed to separate heavy local and express traffic.  I am also experimenting with a similar concept for MOM stations.
There are obviously a lot of variables to consider.  The biggest one would be your interest in the idea.  It's main goal is to open up a new road mechanic and since this mod basically completely overhauls pathfinding, it would make more sense to add this enhancement to your mod rather than build something new which would reuse a lot of the existing mechanics.
https://github.com/VictorPhilipp/Cities-Skylines-Traffic-Manager-President-Edition/issues/196

Have you developed your POC by extending TM:PE or how have you achieved it?
A feasible approach to automatically detect forbidden lane changes might be to check if the lane adjacent to a vehicle lane has m_laneType=None or m_laneType=Pedestrian. What do you think? I guess it would not be hard to implement this.

I finished it weeks ago but got lost in github lol.  I don't want to screw with your work and so I decided to continue with testing instead.  I was wondering if you could provide me a branch to commit to or if you had an idea of how to commit it in such a way you could take a look.  Unfortunately, it would be hard to test without roads that needed the functionality but I am currently building such roads..  Basically it is two part.  It checks both in the laneconnectortool and routingmanager.  In so many words, lanes are grouped by their continuity.  If two lanes have a gap between them (their edges aren't contiguous or overlapping) then they are separated into groups and both the laneconnectortool and the routingmanager will bypass that connection.
Edit: I may use the way you suggested and check if there is a non car lane between the two car lanes to decide groups.

@andreharv we're investigating issues relating to medians, etc., in new fork of the mod - if you get time, could you let us know your thoughts here: https://github.com/krzychu124/Cities-Skylines-Traffic-Manager-President-Edition/issues/89

Sorry I know this has been a while.  I got diverted with getting an update out for MOM mod.  I will probably just release the road first so everyone can get their hands on it and I can get this really annoying 'New Roads for Network Extensions' issue put to bed.  Then I will continue getting this together.  Alternatively, I suppose I could just create a new branch and put the POC in there but after your inputs it gave me pause to reconsider my approach.

Going to close this as duplicate as the issues are summarised in #89

#1528 will address this issue


wave2vec: Why always select the audio with minimum length to decide the batch dimension?

Why don't we add padding? Is there any reason only to remove excess by selecting minimal length as in this line?

@okhonko

padding would add more overhead because then you have to take it into account across the entire model, e.g. when selecting negatives, when computing loss, etc. We sort examples by length before batching them anyway, so examples of similar length are already grouped together and we found that cropping 10s from each audio file works best anyways. But you are welcome to try and let us know results!


VGSCollectSDK (1.7.6) seems to crash on vgsView.vgsCollect.sendData(path: , extraData: )

Describe the bug
I had a sample application that was using similar code from your samples
I had a line of code like so:
vgsView.vgsCollect.sendData(path: "/notification", extraData: extraData)

where vgsView is of type VGSView. On executing this line of code, the app crashes with:

Expected behavior
The app should not crash and send data to VGS. The same line of code works fine in 1.7.5
Environment (please complete the following information):

SDK Version [e.g. 1.7.6]
iOS Version: [e.g. iOS 14.4.1]
Xcode Version: [e.g. Xcode 12.4.]
Device: [e.g. iPad Air]
Dependency manager and it's version:

[ ] Cocoapods: [Latest]

Hi, @sha8wn.
Could you please provide:

test project or sample with test data causing crash;
steps to reproduce;
more detailed crash info (crash log etc).

@sha8wn
You can also send test project with you app
to<EMAIL_ADDRESS>if you don't want to expose some private info here.
We need:

demo app version with issue.
2 test credentials (API key etc) - as I see we need some credentials to run your demo app.
3 detailed steps how to replicate problem.

@EugeneIOs - I will definitely support you with this, however it will be during the course of the week as I just have some things to finish up.
I will try to recreate this in isolation and share the sample project with you so if possible, please keep this issue open till I do so.
Thank you for your support.

@sha8wn
sure, we will wait for your sample and this issue open as well.

Closed due to inactivity.


Fly fix npm start issue

Fixes the problem of npm start failing on fresh computer installs when launching with docker compose. Also will make master up to date with fly branch - resolves the conflicts.
Not related to fly deployments or launches, but launching of namespace service with docker compose. However, it should work on fly as the Dockerfile wasn't changed.
The namespace-service looks for an image to create a container from, separate from the db, per updated docker-compose.yml. Also see updated README with build and launch instructions.

Best to merge issue #2, pull the changes, then then run git merge fly when checked out in master branch and, finally, push master changes.


Filter purchased and in-cart products from recommendations

Enhance the recommendations service to filter products from recommendations that have already been purchased by the user or products in the user's cart.

Implemented recent purchase filter using Personalize filter. "Products in cart" filtering is harder to do with Personalize filter since items can be removed from cart which won't be tracked correctly with Personalize filter. That is probably better left to client-side logic to post-process recommendations.


ad-handle-definition: `ido-completing-read' got redefined

Hi, purcell, how are you ?  I found some warns below recently, I dont know whether others met the warns. I have searched the prompt, and it maybe cause by the name package .
ad-handle-definition: `ido-completing-read' got redefined
ad-handle-definition: `find-function-search-for-symbol' got redefined
my emacs version is 24.4.3 , a couple days ago I upgraded emacs to  24.5.1 , when I started ,emacs would hung up , and I had to kill by terminal . I dont know whether this problem relate to  the warns above. I will appreciate it if you give me some suggest , thanks

Hi!
The warnings are not a problem and can be ignored. I think they're a side-effect of ido-ubiquitous.
I haven't noticed the hanging problem, and I'm using a similar Emacs version (on OS X). What platform are you on?
Did C-g allow you to interrupt the hang? You can try adding (setq debug-on-quit t) to the top of init.el: then, when you kill Emacs you should get a backtrace which should provide some useful information.

Yes, I can use c-g,and backtrace below:
Debugger entered--Lisp error: (quit)
  call-process("ssh" nil t nil "-o" "ControlPath=%C" "host.does.not.exist")
  (progn (call-process "ssh" nil t nil "-o" "ControlPath=%C" "host.does.not.exist") (goto-char (point-min)) (if (search-forward-regexp "unknown.+key" nil t) (setq result (concat result " -o ControlPath='tramp.%%r@%%h:%%p'")) (setq result (concat result " -o ControlPath='tramp.%%C'"))))
  (unwind-protect (progn (call-process "ssh" nil t nil "-o" "ControlPath=%C" "host.does.not.exist") (goto-char (point-min)) (if (search-forward-regexp "unknown.+key" nil t) (setq result (concat result " -o ControlPath='tramp.%%r@%%h:%%p'")) (setq result (concat result " -o ControlPath='tramp.%%C'")))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (call-process "ssh" nil t nil "-o" "ControlPath=%C" "host.does.not.exist") (goto-char (point-min)) (if (search-forward-regexp "unknown.+key" nil t) (setq result (concat result " -o ControlPath='tramp.%%r@%%h:%%p'")) (setq result (concat result " -o ControlPath='tramp.%%C'")))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))
  (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (call-process "ssh" nil t nil "-o" "ControlPath=%C" "host.does.not.exist") (goto-char (point-min)) (if (search-forward-regexp "unknown.+key" nil t) (setq result (concat result " -o ControlPath='tramp.%%r@%%h:%%p'")) (setq result (concat result " -o ControlPath='tramp.%%C'")))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))))
  (if (zerop (length result)) nil (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (call-process "ssh" nil t nil "-o" "ControlPath=%C" "host.does.not.exist") (goto-char (point-min)) (if (search-forward-regexp "unknown.+key" nil t) (setq result (concat result " -o ControlPath='tramp.%%r@%%h:%%p'")) (setq result (concat result " -o ControlPath='tramp.%%C'")))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))) (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (call-process "ssh" nil t nil "-o" "ControlPersist") (goto-char (point-min)) (if (search-forward-regexp "missing.+argument" nil t) (progn (setq result ...)))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))))
  (progn (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (call-process "ssh" nil t nil "-o" "ControlMaster") (goto-char (point-min)) (if (search-forward-regexp "missing.+argument" nil t) (progn (setq result "-o ControlMaster=auto")))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))) (if (zerop (length result)) nil (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (call-process "ssh" nil t nil "-o" "ControlPath=%C" "host.does.not.exist") (goto-char (point-min)) (if (search-forward-regexp "unknown.+key" nil t) (setq result ...) (setq result ...))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))) (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (call-process "ssh" nil t nil "-o" "ControlPersist") (goto-char (point-min)) (if (search-forward-regexp "missing.+argument" nil t) (progn ...))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))))))
  (if (executable-find "ssh") (progn (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (call-process "ssh" nil t nil "-o" "ControlMaster") (goto-char (point-min)) (if (search-forward-regexp "missing.+argument" nil t) (progn ...))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))) (if (zerop (length result)) nil (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (call-process "ssh" nil t nil "-o" "ControlPath=%C" "host.does.not.exist") (goto-char ...) (if ... ... ...)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))) (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (call-process "ssh" nil t nil "-o" "ControlPersist") (goto-char ...) (if ... ...)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))))))
  (progn (if (executable-find "ssh") (progn (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (call-process "ssh" nil t nil "-o" "ControlMaster") (goto-char ...) (if ... ...)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))) (if (zerop (length result)) nil (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn ... ... ...) (and ... ...)))) (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn ... ... ...) (and ... ...))))))))
  (condition-case nil (progn (if (executable-find "ssh") (progn (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn ... ... ...) (and ... ...)))) (if (zerop (length result)) nil (let ((temp-buffer ...)) (save-current-buffer (set-buffer temp-buffer) (unwind-protect ... ...))) (let ((temp-buffer ...)) (save-current-buffer (set-buffer temp-buffer) (unwind-protect ... ...))))))) (error nil))
  (let ((result "") (case-fold-search t)) (condition-case nil (progn (if (executable-find "ssh") (progn (let ((temp-buffer ...)) (save-current-buffer (set-buffer temp-buffer) (unwind-protect ... ...))) (if (zerop (length result)) nil (let (...) (save-current-buffer ... ...)) (let (...) (save-current-buffer ... ...)))))) (error nil)) result)
  (defvar tramp-ssh-controlmaster-options (let ((result "") (case-fold-search t)) (condition-case nil (progn (if (executable-find "ssh") (progn (let (...) (save-current-buffer ... ...)) (if (zerop ...) nil (let ... ...) (let ... ...))))) (error nil)) result) "Call ssh to detect whether it supports the Control* arguments.\nReturn a string to be used in `tramp-methods'.")
  eval-buffer(#<buffer  *load*> nil "/usr/share/emacs/24.5/lisp/net/tramp-loaddefs.el" nil t)  ; Reading at buffer position 7082
  load-with-code-conversion("/usr/share/emacs/24.5/lisp/net/tramp-loaddefs.el" "/usr/share/emacs/24.5/lisp/net/tramp-loaddefs.el" nil t)
  #<subr require>(tramp-loaddefs nil nil)
  ad-Advice-require(#<subr require> tramp-loaddefs)
  apply(ad-Advice-require #<subr require> tramp-loaddefs)
  require(tramp-loaddefs)
  byte-code("\300\301!\207" [require tramp-loaddefs] 2)

Hmm. That's deep in the initialization of tramp, and not related to this config.
My guess is that the test ssh command at the start of the backtrace hangs when trying to connect to host.does.not.exist, so a) your DNS must be wrongly providing an IP address for that hostname and b) a local or remote firewall must be stalling the ssh connection to that IP address.

OK, maybe my vpn or some firewalls in China cause the problem. I'll observe this for some time . Thanks so such !

Hi, purcell, I think I have the answer about this problem.The 'tramp-loaddefs' hang up emacs during startover.
my DNS server is a bit complicated, sometimes it provides wrong IP address.However,I think this is not reasonable that Emacs hang up  on DNS resolution.While I have no connection, in practice, emacs should not be blocked .
Fortunately, someone report this bug,I am waiting emacs update. I add  'ConnectTimeout=0' parameter for temporary, and it works for me.
Thanks again !
PS:
this is the link: http://lists.gnu.org/archive/html/bug-gnu-emacs/2015-03/msg00281.html

Good detective work! Glad you have a workaround.

I met almost the same bug and I found a solution in an issue of spacemacs: [BUG]bookmarks make spacemacs startup very slow #1921 ,which was also caused by tramp.
By save the following to my config file
(setq tramp-ssh-controlmaster-options
      "-o ControlMaster=auto -o ControlPath='tramp.%%C' -o ControlPersist=no")

Emacs can startup without hanging problem, though I do not quite understand the core of the bug.

I do not quite understand the core of the bug.

Perhaps DNS lookups for host.does.not.exist hang on your machine?

Perhaps DNS lookups for host.does.not.exist hang on your machine?

But why tramp has to resolve host.does.not.exist even when ssh does not connect to any other machine? Is it for local compilation or accessing files via /sudo:?

It is just trying to figure out the capabilities of the installed ssh at start-up, using the code posted in the spacemacs thread you linked to. The tramp-ssh-controlmaster-options settings in your comment above are presumably not compatible with certain ssh versions.


Permit many sequences to be passed

Sequences are now passed in via the start method to avoid having to stop the PWM and restart it. Sequences continue to be constrained with the same lifetime of the Pwm struct itself. The pwm_sequence example has been extended to illustrate multiple sequences being passed around.

Converting to a draft as this present version is UB. I was expecting that the lifetime of the sequence reference would be as long as the Pwm struct. As @jacobrosenthal has pointed out though, it is only "at least as long".
I was then rather hoping that that subtypes would save me, but no cigar:
    pub fn start<'d0, 'd1: 'd0>(&'d1 self, sequence: &'d0 [u16], times: SequenceMode) -> Result<(), Error>

... my intent was to declare that self must live at least as long as sequence.

bors r+


Entry point command line arguments are forced

I want to automatically format files on commit using this command, which should be successful.
prettier --write --ignore-unknown

Exit codes do not seem to be well-documented, but after formatting is done I can confirm that this has an exit code of 0.
I see that this mirror's entry point is:
prettier --write --list-different --ignore-unknown

This is unusable because --list-different has an exit code of 1 if any differences are found, i.e. any formatting is done [1].
Arguments specified in entry cannot be overridden [2].

entry
the entry point - the executable to run.  entry can also contain arguments that will not be overridden such as entry: autopep8 -i.

I propose that going forward (next tag), entry is changed to prettier. This way consumers can use Prettier as they wish by specifying args.
ESLint follows this example. While they could specify --fix in their entry point, they do not - it is just eslint [3].
Since pre-commit requires the specification of a tag or commit as the hook source, this would not break anything, although the change should be noted in the README.
If this is not possible I will fork this and make the change, as none of the existing forks have it. In this case since this behavior is unexpected, it should be noted in the README.

This is unusable because --list-different has an exit code of 1 if any differences are found, i.e. any formatting is done [1].

independent of that, if changes are made to files then pre-commit fails the patch
from the docs

The hook must exit nonzero on failure or modify files.

you can override entry if you need to -- usually you don't need to.  the text you linked to is specifically talking about args
the only option a consuming hook can't "override" is id -- and there's alias for that

Don't know how I missed this stuff. Thanks!!!
We decided to override entry:
entry: prettier --list-different --ignore-unknown


Prevent keypress to trigger form save for detail screens

Fixes Enter key behavior on any tag/member detail pages input, which currently triggers a save operation without updating values.

Closed in favor of https://github.com/TryGhost/Ghost-Admin/pull/1381 and https://github.com/TryGhost/Ghost-Admin/pull/1379


Add an uncolored version of our disconnect icon

While we have a good disconnect icon, because it is used for debugging it has a color, and I would like to have a normal version to use. I currently am using a copied SVG version in GitLens today.

We don't add specific icons that don't have colors so i think this would need to be done on the VS Code side to scope colors for certain views. in this case only have colors in the debug view + toolbar. Can you create an issue there?


Update sphereBuilder.ts

scene type and optional in CreateSphere

We have issues with CI :(

i feel like i failed miserably :-)


Improve editor log message filter button styles.

Overall this should be more inline with the godot editor style, and is clearer about which filters are active or inactive.

Removed tinting of icons (my biggest gripe).
Added slight dimming to icons on inactive filters.
Added border bottom border highlight to active filters.

Thanks!


cannot recognize raspi pin header from linux

I found the thread relates to this issue in xilinx forum.
https://support.xilinx.com/s/feed/0D54U00005WaC3zSAF?language=ja

Pmods and rpi pin header are in PL domain.
User need to implement a custom PL design! Have fun:tada:
This article is nice.
https://www.hackster.io/whitney-knitter/rpi-pmod-connector-gpio-with-custom-pl-design-in-kria-kr260-53c40e


Clarify RSA key supportability

Removed reference to specific key (RSA 2048) and added reference to supported RSA keys. Feedback is based on customer confusion with key supportability. Also discussed with PG / Utsav Raghuvanshi.

Learn Build status updates of commit 66e5cb5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/backup/encryption-at-rest-with-cmk.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@v-amallick
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@jithubhaijabs - thanks for the updates. Signing it off ( #sign-off )

Learn Build status updates of commit 8ebaa09:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/backup/encryption-at-rest-with-cmk.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Quick Sort Algorithm

Write an implementation of quick sort algorithm on an integer array with proper explanation through comments.

@prafulla-k-roy I want to try this , please assign this to me.

I can do this in java @prafulla-k-roy, can you assign this to me for java

heyy..
i would love to do this.. please assign this task to me?

Hello @prafulla-k-roy I would love to provide the code in CPP language. Kindly assign this to me.

@prafulla-k-roy Please check my PR #50

Hey @prafulla-k-roy would like to solve it using Java!

can you assign this issue to me ?


KMS CMK key is not being rotated

We are using a KMS CMK key which is not being rotated and is picked up by Checkov scanner:
CheckID		: CKV_AWS_7
CheckName	: Ensure rotation for customer created CMKs is enabled
File		: /cdk.out/dataall-cdk-template-cicd-stack.template.json:1755-1819
Resource	: AWS::KMS::Key.dataallcdktemplatecdkpipelinePipelineArtifactsBucketEncryptionKeyDCDBA3C9
Guideline	: CKV_AWS_7

All KMS CMK keys should be rotated as a best security practice.

I believe this is in reference to the CodePipeline created in dataall/deploy/stacks/pipeline.py file. We need to test if adding the enable_key_rotation=True parameter to the CodePipeline would cause any unforeseen issues but should be easy to implement and align with best practices
Should be good to pick this up shortly barring any capacity setbacks, thank @zsaltys

Completed in #923


Unable to build...

OS: Ubuntu-Budgie 22.04 fully updated
Default host: x86_64-unknown-linux-gnu
rustup home:  /home/tracker1/.rustup

stable-x86_64-unknown-linux-gnu (default)
rustc 1.66.0 (69f9c33d7 2022-12-12)

Build & Output:
icy_term on  main is 📦 v0.4.0 via 🦀 v1.66.0 took 3s
❯ cargo build --release
   Compiling icy_term v0.4.0 (/home/tracker1/src/github.com/mkrueger/icy_term)
error[E0432]: unresolved import `rand`
 --> src/ui/phonebook.rs:6:5
  |
6 | use rand::Rng;
  |     ^^^^ use of undeclared crate or module `rand`

error[E0433]: failed to resolve: use of undeclared crate or module `rand`
   --> src/ui/phonebook.rs:185:35
    |
185 |                     let mut rng = rand::thread_rng();
    |                                   ^^^^ use of undeclared crate or module `rand`

warning: crate-level attribute should be in the root module
 --> src/ui/main_window.rs:1:36
  |
1 | #![cfg_attr(not(debug_assertions), windows_subsystem = "windows")] // hide console window on Windows in release
  |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_attributes)]` on by default

Some errors have detailed explanations: E0432, E0433.
For more information about an error, try `rustc --explain E0432`.
warning: `icy_term` (bin "icy_term") generated 1 warning
error: could not compile `icy_term` due to 2 previous errors; 1 warning emitted

Okay.. after a few tweaks, was able to get it building/running..
Had to uncomment the rand reference in cargo.toml
Had to install  a few modules...
sudo apt install libxcb-xfixes0-dev libxcb-shape0-dev libsdl1.2-dev

@mkrueger aside: nice work so far...


Stuck on "Loading user information"

Hello,
I am struggling with making the bot to work. It does not respond to any commands in chat, and is stuck (without any error) on "Loading user information" + spinning wheel whenever I try to go to any of these:

Authorization
Chat/Aliases
Chat/Commands
Chat/Promotions
Chat/Themes

I have Nightbot, Spotify, Twitch Streamer and YouTube connected. I did not do any extra settings other than the default ones. The version I'm using is 1.2.0. The bot has permission to the Windows Firewall and my other antiviruses are turned off.
Any idea what could by causing this issue? Thanks!

Adding some additional information as I installed 1.3.0 today and ran into the issue and saw this GitHub issue. Decided to dig a bit further.

Windows 10.0.19045
Browsers Tested

Firefox
Chrome
Edge
Edge in IE Mode

Versions of OxidizeBot Tested

1.3.0
1.2.0
1.1.0
1.0.5

Connection Configurations

Twitch and Nightbot
Twitch, Spotify, and Nightbot
Twitch
Nightbot
None

No errors found in log apart from "Initialize Player" failed, trying again Xs

this was solved by adding Spotify connection info, error disappeared

Thank you, so there seems like there could be some issue related to when a component (like the player) fails to initialize.

Seems to still be an issue, has anyone fonud a workaround for the time being?


Memory Usage stats not available over TCP

I have a remote Docker instance being monitored with this component, and I keep seeing these errors in my logs:
2021-05-26 21:36:49 ERROR (Thread-4) [custom_components.monitor_docker.helpers] wyzesense2mqtt: Cannot determine memory usage for container ('usage')
2021-05-26 21:36:49 ERROR (Thread-4) [custom_components.monitor_docker.helpers] wyzesense2mqtt: Raw 'memory_stats' {}

My YAML looks like:
monitor_docker:
  - name: DockerPi
    url: http://<IP_ADDRESS>:2375
    containers:
      - wyzesense2mqtt
    rename:
      wyzesense2mqtt: WyzeSense2MQTT

Also, the sensor entities (in my case, sensor.dockerpi_memory, sensor.dockerpi_memory_percent, sensor.dockerpi_wyzesense2mqtt_memory, and sensor.dockerpi_wyzesense2mqtt_memory_percent) gets created, but with an unknown state.

I've actually updated my YAML to not request these statistics:
monitor_docker:
  - name: DockerPi
    url: http://<IP_ADDRESS>:2375
    monitored_conditions:
      - state
      - status
      - uptime
      - image
      - 1cpu_percentage
    containers:
      - wyzesense2mqtt
    rename:
      wyzesense2mqtt: WyzeSense2MQTT

And I'm still getting the error from my previous comment... Which makes me feel like the integration isn't respecting my new YAML?

Actually, I only today noticed that there's a FAQ about getting memory stats from some platforms. After making that change on my (Raspbian) system, I no longer get the errors in my logs... but I'm still not configured to fetch the memory stats anyways, and am not getting the entities (as expected).
So, it still appears the integration is attempting to fetch memory stats even when not configured to do so.

On a semi-related note, what type of changes would need to be made to make this work for a Docker container running inside of an LXC container?

Is v1.11 an improvement with the TCP behavior?
Docker inside LXC should work, as long the TCP port is exposed (reachable).

This solved my issue: https://github.com/ualex73/monitor_docker/issues/26#issuecomment-723016034


Broken Links

Many of the links into the specifications from INFO-002 seem to be broken.
In particular on the "Authorization Server Setup" and "Node to Authorization Server Interactions" pages, most seem to not work.
The first broken link on "Authorization Server Setup" is:
https://specs.amwa.tv/is-10/branches/v1.0.x/docs/4.4._Behaviour_-_Access_Tokens.html#registered-claims
which I think should be:
https://specs.amwa.tv/is-10/releases/v1.0.0/docs/4.4._Behaviour_-_Access_Tokens.html#registered-claims
I'm guessing a lot of the issues will be due to similar things.
Do you want me to work on creating a PR for these, or can you fix them directly?

Closed by #52.


better translations (add later at last)

turkusk :http://www.normalift.com/kitap/files/mus/had/003/0261.htm
https://github.com/alQuranBD/Bangla-Hadith-api

search & scrape for more other languages,
do this at later(at end) ,do this in batch to save time
and note down the steps , so that I can do  this later (add in contributing or preprocessing etc)

dawud
https://www.normalift.com/kitap/files/dvd/had/001/0013.htm
bukhair
https://www.normalift.com/kitap/files/buh/had/001/0001.htm
muslim
mus
tirmidhi
tir
nasai
NES-KÜB
ibn majah
İBN-M
malik muwatta
muvat


Disabling the index.html generation does not work

Version
3.4.1
Environment info
  System:
    OS: macOS Sierra 10.12.6
    CPU: (4) x64 Intel(R) Core(TM) i5-5575R CPU @ 2.80GHz
  Binaries:
    Node: 11.4.0 - /usr/local/bin/node
    Yarn: Not Found
    npm: 6.4.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 72.0.3626.109
    Firefox: 65.0.1
    Safari: 12.0.3
  npmPackages:
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0-beta.2
    @vue/babel-plugin-transform-vue-jsx:  1.0.0-beta.2
    @vue/babel-preset-app:  3.4.1
    @vue/babel-preset-jsx:  1.0.0-beta.2
    @vue/babel-sugar-functional-vue:  1.0.0-beta.2
    @vue/babel-sugar-inject-h:  1.0.0-beta.2
    @vue/babel-sugar-v-model:  1.0.0-beta.2
    @vue/babel-sugar-v-on:  1.0.0-beta.2
    @vue/cli-overlay:  3.4.1
    @vue/cli-plugin-babel: ^3.4.0 => 3.4.1
    @vue/cli-plugin-eslint: ^3.4.0 => 3.4.1
    @vue/cli-service: ^3.4.0 => 3.4.1
    @vue/cli-shared-utils:  3.4.1
    @vue/component-compiler-utils:  2.6.0
    @vue/eslint-config-prettier: ^4.0.1 => 4.0.1
    @vue/preload-webpack-plugin:  1.1.0
    @vue/web-component-wrapper:  1.2.0
    eslint-plugin-vue: ^5.0.0 => 5.2.2
    vue: ^2.6.6 => 2.6.7
    vue-eslint-parser:  2.0.3
    vue-hot-reload-api:  2.3.3
    vue-loader:  15.6.4
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.5.21 => 2.6.7
    vue-template-es2015-compiler:  1.9.1
  npmGlobalPackages:
    @vue/cli: 3.4.1

Steps to reproduce

vue create test
create a vue.config.js file
copy and paste the content of this section: https://cli.vuejs.org/guide/html-and-static-assets.html#disable-index-generation into the vue.config.js file
npm run build

What is expected?
No index.html file under dist/index.html
What is actually happening?
There is an index.html file under dist/index.html

Of course directly after I submitted this issue I found the problem. It was a side effect because the vue-cli generates in the public folder an index.html file. The copy Plugin moves the index.html file then to dist/index.html.
Just delete the index.html file from public/index.html then everything works as expected.

I have encountered the same problem.
Is this not a bug?

even when index.html file is deleted from public folder one is still built...

I also see that it is still built in ui/dist/index.html when it's gone from public/index.html. I resorted to removing it after it is copied to my server's public folder.