Gocode completely doesn't work since version golang 1.10

Gocode completely doesn't work since version golang 1.10.
The utility does not return anything after updating golang.
If roll back golang to version 9, then everything starts working again.
:(

Might help: https://github.com/nsf/gocode/issues/500
tl;dr: Go has package cache now, with 1.10 you can with hacks make gocode work, but in the long term who knows what happens next. Start looking for alternatives or hope and pray that I'll end up writing next version of the gocode relatively soon (probably it will have a different name).

@nsf if you are going to write new version of gocode that will work with source code (instead of package cache), can we cooperate on this task? I don't really want to do it alone and maintain it for years, but it could be easier if several developers would work on that task at the same time.

@kovetskiy no, due to unpredictable schedule I don't see how it's possible. I might be coding it every day for a week and then doing zero progress for a few weeks, etc. That's just how open source works. there is nothing to colaborate over until there is a major codebase written and ready. Next gocode will be most likely called "gls" which stands for Go Language Server or Service. It will most likely implement the langauge server protocol by sourcegraph. E.g. similar to: https://github.com/sourcegraph/go-langserver. But having a compatibility mode in mind if possible for existing gocode text editor integrations. What I want is to take full advantage of this protocol and implement everything starting from syntax/semantic checks, goto, "codelense", find usages of, autocompletion, quick fixes, etc. It's a lot of work, but it needs to be done this way and no other way is acceptable. Proper and full source language server protocol implementation.
P.S. If you don't want to maintain it, then don't do it at all.

@nsf I mean that I don't want to maintain it if I would be alone as you do with gocode. That's the difference.

Well, listen, when and if I have some code to show, then we can talk about collaboration. It's pointless to collaborate over something that doesn't even exist yet. I don't know how it will look, what kind of libs it will use, what it will do exactly, etc. And I don't want to discuss those details either.

@nsf ok, no problem, just ping me if I have a chance to help you with any related issue. I will be glad to make a contribution.

FYI, I just added a -source flag to mdempsky/gocode to make it generate suggestions from source, instead of from compiled package definitions.
Caveat: the main branch of mdempsky/gocode doesn't implement any caching. For compiled imports, this is moderately slower (but IMO still acceptable for interactive use, ~200ms in large packages), but source imports are substantially slower (~1.5s for each completion, even in small packages).
I've prototyped caching in the cache branch. It's currently for compiled packages only (and standard cmd/go workspaces; no gb support), but it brings performance on par with nsf/gocode: ~30ms to ~40ms when cached.
I'd really like to implement this functionality directly into a langserver implementation so that it can make use of langserver's VFS functionality.

Added a link to "mdempsky/gocode" to README.md. Hopefully @mdempsky, you don't mind.

Although I understand that you don't have a magic fix for "package cache" problem yet. The chance that you'll have one is much higher than on my end. That "-source" flag thing looks interesting.

@nsf Thank you for the link. I don't mind.

@mdempsky , I implement a source caching based on your master branch, at localvar/gocode. I hope I could send a PR to you, but seems too difficult for me to do everything right, though I think it works in most cases.


Do not throw exception when isset is used on AbstractOptions existing object variable

Same fix as suggested by @rms230 in PR #7287. Split it up and slightly changed the assertion for BadMethodCallException.
Original description of #7287:

When calling isset() on an object variable that is a class extending AbstractOptions an exception is thrown.
An example useage of this is found in the EventManagerAwareTrait where the trait checks a class variable isset, if the class that is using the EventManagerAwareTrait extends AbstractOptions an exception is thrown.
This pull request fixes AbstractOptions by checking that the method exists and that the value is not equal to null, thus stopping the exception being thrown.

Ping @weierophinney
Just making sure this part of the original PR #7287 is included in the 2.4.0 release too :smiley:

Pushed to develop for release with 2.4; thanks, @Martin-P !


Add setFlag method

If you want to update a a message ("mark as read") you can do: $message->setFlag('\\Seen');

Great, thanks!

You're welcome. Can you release? (I would like to update my project).
Side question: I could re-indent/clean your sources, are you OK with this or is it a waste of time?

Sure.
Hmm... I wanted to refactor whole library, but I can't find the time for last 3 months. I'll try to do refactoring this month, so this is probably waste of time.


ReflectionFactory is internal proprietary API and may be removed

Expected behavior
No warnings during build
Actual behavior
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ managed-ledger ---
[INFO] Compiling 30 source files to /Users/masakazu/git/pulsar/managed-ledger/target/test-classes
[WARNING] /Users/masakazu/git/pulsar/managed-ledger/src/test/java/org/apache/zookeeper/MockZooKeeper.java:[81,23] ReflectionFactory is internal proprietary API and may be removed in a future release
[WARNING] /Users/masakazu/git/pulsar/managed-ledger/src/test/java/org/apache/zookeeper/MockZooKeeper.java:[81,58] ReflectionFactory is internal proprietary API and may be removed in a future release

Steps to reproduce
mvn install -DskipTests

System configuration
Pulsar version: master c51eaad
OS: macOS 10.12

I haven't found a way to fix this. We are using the ReflectionFactory in tests to instantiate a Zookeeper client instance without invoking the constructor (in the MockZookeeper).
Not calling the constructor is critical because Zookeeper class is trying to do many thing (like connecting) from the constructor and there is no other interface.

@merlimat is this related to your recent changes for java11?

@sijie Yes, I think it would still be required to be fixed. In #3006 I just verified it compiles and run with Java 11 though I haven't ran the tests with that yet.

@sijie - Let me look into this one

@vcottagiri great!

@sijie - thanks. Raised PR. Hope its what @merlimat was looking for.


Collect and expose Shoot alerts by the Gardener

As a Shoot operator I want to be able to see the firing/pending/resolved alerts, which are referring my cluster, on a central place for example in the Gardener Dashboard.  =As Gardener operator I want to be able to see all Shoot alerts on a central place, for example in a Grafana Dashboard. As an enduser I want to have more transparency of my Shoot clusters health.
Background
Each Shoot has an own Prometheus instance, which monitors the clusters control plane, infrastructure and parts of its workload. The alerts for the Shoot are also triggered by this Prometheus instance and then pushed to its corresponding alertmanager instance to deliver the alert to its receivers. The only way to see a list of all active alerts is accessing the Shoots Prometheus directly.
An Enduser has no option to see the active alerts at all. May that's also not required, but to have more detailed health information as only the conditions and the last operation state, would also be a benefit for the enduser and provides more transparency to the user.
Implementation proposal
The Gardener have the care controller, which collects already cluster conditions. The care controller could also query the Prometheus of the Shoot for active alerts and attach them to the status of the Shoot resource.

Do you still plan to implement this in the next time?

Good question I have not planned to implement this soon. I would rather raise the question if we still need this, because we have meanwhile end user facing monitoring and could display a list with user related alerts there.
On the other hand side we could not display the active alerts in the Gardener dashboard without these conditions (except if the dashboard queries Prometheus by their own). If we decide to introduce a condition with alert states then we would need to consider that alerts with different scopes exist (users and operators).
@rfranzke , @vlerenc WDYT?

We plan to expose Prometheus to the end user. That will alleviate the need for this a lot. On the other hand, looking with the eyes of an end user, wouldn't you agree that seeing a green cluster in the UI and active alerts in Prometheus give an inconsistent impression? Considering this, I would think it's interesting (medium priority) to have that in the shoot resources and consequently in the Dashboard.

@dkistner @wyb1 what's the plan here?

@dkistner @wyb1 can you please give an update?

/close
due to inactivity and no concrete plans - kindly reopen when it becomes relevant again


[1.3.x] MODCLUSTER-824 Improve handling of overlapping aliases in APP commands

Resolves MODCLUSTER-824
Opening as a draft since it's a backport.

ref https://github.com/modcluster/mod_proxy_cluster/pull/290

Can we please validate the removal behavior? Just to make sure there isn't a side-effect that we are missing.

Before the patch, two virtual hosts with overlapping aliases are created. When REMOVE-APP is sent to the overlapping alias, only one of the hosts gets removed. (That does no affect the case when the remove command is sent with /* path, then both get removed.)
With this PR, only one virtual hosts is present because in case of an overlap, the two get merged. Then the removal removes the only host as expected.

@rhusar  any updates on this?

Alright, so it seems we have come to a conclusion that replace is the correct actions (instead of the proposed merge). I'll fix this PR once I fix the upstream.

Alright, so it seems we have come to a conclusion that replace is the correct action (instead of the proposed merge). I'll fix this PR once I fix the upstream.

Or maybe not. In case of following configuration of tomcat
      <Host name="localhost" appBase="webapps"
            unpackWARs="true" autoDeploy="true">
            <Alias>default.example.com</Alias>
        </Host>

       <Host name="testing"  appBase="webapps-example"
            unpackWARs="true" autoDeploy="true">
            <Alias>default.example.com</Alias>
        </Host>

the merge seems the right way...

in server.xml:
+++

B

C

+++
deploy demo-1.0.war in HostA... you have in mod_proxy_cluster Alias a, b.
deploy test.war in HostB... you have in  mod_proxy_cluster Alias a, b, c .
The above looks wrong demo-1.0 was never for c and test was never for a.
undeploy test.war in HostB.... you still have Alias a, b, c ... so c still has demo-1.0 which is wrong.

in server.xml:
+++
      <Host name="A"    appBase="Aapps" unpackWARs="true" autoDeploy="true">
         <Alias>B</Alias>
      </Host>
      <Host name="B" appBase="Bapps" unpackWARs="true" autoDeploy="true">
         <Alias>C</Alias>
      </Host>
+++

deploy demo-1.0.war in HostA... you have in mod_proxy_cluster Alias a, b. deploy test.war in HostB... you have in mod_proxy_cluster Alias a, b, c . The above looks wrong demo-1.0 was never for c and test was never for a.
undeploy test.war in HostB.... you still have Alias a, b, c ... so c still has demo-1.0 which is wrong.

Right, so we have multiple levels at which both the current state and the proposed fix are not working. :smile: I'll mark this as draft, we should think it through first.

Right, so we have multiple levels at which both the current state and the proposed fix are not working. 😄 I'll mark this as draft, we should think it through first.

A partial fix went into upstream/main, so just make sure we don't forget to fix there too. 👍🏼

Another funny thing:
      <Host name="A"    appBase="Aapps" unpackWARs="true" autoDeploy="true">
         <Alias>B</Alias>
      </Host>
      <Host name="B" appBase="Bapps" unpackWARs="true" autoDeploy="true">
         <Alias>A</Alias>
      </Host>

deploy demo-1.0 in Aapps, then in Bapps, wait and later undeploy  demo-1.0 in Aapps, the VirtualHost is gone :-(

     <Host name="A"    appBase="Aapps" unpackWARs="true" autoDeploy="true">
         <Alias>B</Alias>
      </Host>
      <Host name="A" appBase="Bapps" unpackWARs="true" autoDeploy="true">
         <Alias>A</Alias>
      </Host>

gives an error in tomcat, as expected.

gives an error in tomcat, as expected.

Hm, but it gives an error due to name=A conflict, but having alias/name conflict is not problem. So this should be fixed in the java part as well.
Although thinking about it, maybe this is something to fix in tomcat directly, isn't it?


[RFC] Use job_start (vim 8.0+) or jobstart (neovim) for starting the server

This adds a way to start the server without the need to install the vim-dispatch or vim-proc plugins.
This uses the new APIs and prefers them if present (even if the aforementioned plugins are installed).
Checklist:

[x] Get Neovim's jobstart working
[x] Get Vim's job_start working
[ ] Documentation updates
[ ] Outputing of stderr as error messages
[ ] logging to file

I've run into a few issues with this PR.

Your debug function needs to output a:message instead of just message.
When starting my omnisharp server with sh, it fails.

The omnisharp I execute is, omnisharp-roslyn/artifacts/publish/OmniSharp/default/netcoreapp1.0/OmniSharp
When it prefaces the command with sh -c it seems to ignore the solution directory I specify with -s and instead just starts in my current working directory.
I'm not sure if this is related, but for me to get it to work, I had to remove the sh -c and then stop calling shellescape when building the command. I haven't tested to see if the commands coming in are already escaped. Does vimscript have a way to do this?

@waldnercharles, you are correct, it works properly only if I implement your suggestions and I will check if stuff gets escaped properly with all methods of launching the server asynchronously.

Any progress on this?

This should hopefully be relatively feature complete. I am using Fedora 25, so dotnet and the omnisharp server is tricky to build at the moment, so testing was limited, but I hope that everything works as expected.

I am pretty confident that this should work with both, neovim and vim job_start API, the only thing to test now is for regressions using vimproc and/or vim-dispatch

@waldnercharles, @thinca, if you have any time, it would be great if you reviewed this.

@aignas I really appreciate this commit but I am having problems on windows 10, I am using Windows 10 with neovim 0.1.5-dev, here is the error:
Error detected while processing function OmniSharp#StartServerIfNotRunning[2]..OmniSharp#StartServer[10]..OmniSharp#StartServerSolution[19]..OmniSharp#proc#RunAsyncCommand[2]..OmniSharp#proc#neovimJobstart:
line    4:
E902: ""C:\Users\foobar\AppData\Local\nvim\plugged\omnisharp-vim/server/OmniSharp/bin/Debug/OmniSharp.exe"" is not an executable
E902: ""C:\Users\foobar\AppData\Local\nvim\plugged\omnisharp-vim/server/OmniSharp/bin/Debug/OmniSharp.exe"" is not an executable

I think the problem might be the slashes, I look at the code everything makes sense, I tried to run the the command on the cmd and it worked.
By the way I have compiled the Omnisharp solution with the MSbuild  version 14.0.23107.0, on the following screen shoot you can see the Omnisharp.exe on the correct folder.

@augustomelo, thanks! That is exactly the feedback I was looking for. I will try to fix it soon...

No, the only config that I have is:
let g:OmniSharp_selector_ui = 'ctrlp'
    let g:OmniSharp_timeout = 1
    augroup omnisharp_commands
        autocmd!

        autocmd FileType cs setlocal omnifunc=OmniSharp#Complete
        "autocmd TextChanged,InsertLeave *.cs SyntasticCheck
        "autocmd CursorHold *.cs call OmniSharp#TypeLookupWithoutDocumentation()

        autocmd FileType cs nnoremap <F12> :OmniSharpGotoDefinition<cr>
        autocmd FileType cs nnoremap <S-A-F10>  :OmniSharpFixIssue<cr> :OmniSharpFixUsings<cr>
        autocmd FileType cs nnoremap <Leader>dc :OmniSharpDocumentation<cr>
        autocmd FileType cs nnoremap <F2> :OmniSharpRename<cr>
        autocmd FileType cs nnoremap <Leader><Space> :OmniSharpGetCodeActions<cr>
        "navigate up/down by method/property/field
        "autocmd FileType cs nnoremap <C-K> :OmniSharpNavigateUp<cr>
        "autocmd FileType cs nnoremap <C-J> :OmniSharpNavigateDown<cr>
    augroup END

The problem is that the path is correct, but some how it does not call the .exe

@augustomelo, I have tried to fix this. I think the problem might be the mixed slashes in the path (but there may be something else entirely). If you can, please check it to see if it works :)

Sill not working but the slashes are now doubled.
Error detected while processing function OmniSharp#StartServerIfNotRunning[2]..OmniSharp#StartServer[10]..OmniSharp#StartServerSolution[19]..OmniSharp#proc#RunAsyncCommand[2]..OmniSharp#proc#neovimJobstart:
line    4:
E902: ""C:\Users\augusto.melo\AppData\Local\nvim\plugged\omnisharp-vim\\server\\OmniSharp\\bin\\Debug\\OmniSharp.exe"" is not an executable
E902: ""C:\Users\augusto.melo\AppData\Local\nvim\plugged\omnisharp-vim\\server\\OmniSharp\\bin\\Debug\\OmniSharp.exe"" is not an executable

Sorry for that, hopefully it does work now.

Doesn't work here either.
I am using neovim 0.1.7 on macOS.
Here is the error message I got.
Error detected while processing function OmniSharp#StartServerIfNotRunning[2]..OmniSharp#StartServer[10]..OmniSharp#StartServerSolution[19]..Om
niSharp#proc#RunAsyncCommand[2]..OmniSharp#proc#neovimJobstart:
line    4:
E902: "'/usr/local/bin/OmniSharp'" is not an executable
E902: "'/usr/local/bin/OmniSharp'" is not an executable

I didn't go into too much details about this. But It seems like the command is wrapped up in single quote when it should not.
I actually have a barebone working example at https://github.com/autozimu/omnisharp-vim/commit/7f9dc5b2a5c4bc64f1246b9f8976428bf7f32c01.
Hope it helps.

Still does not working =/, but it is a different message now :)
Error detected while processing function OmniSharp#StartServerIfNotRunning[2]..OmniSharp#StartServer[10]..OmniSharp#StartServerSolution:
line   14:
E182: Invalid command name
E182: Invalid command name

I don't use OmniSharp any more, but it's still awesome to see this work!

@nosami Thanks! :)

I believe that we are still having trouble with the double quotes, as you can see the the omnisharp and the file location ware wrapped but the port and the solution are not (-p 2000 -s), I believe we should remove the double quotes  or wrap every thing.
I saw your commit about the test, and I forgot to mention that I am using the default server not the roslyn.
Using Neovim jobstart to start the following command:
"C:\Users\foobar\AppData\Local\nvim\plugged\omnisharp-vim\server\OmniSharp\bin\Debug\OmniSharp.exe" -p 2000 -s "C:\Users\foobar\workspace\Foo\FooSolution.sln"
Using Neovim jobstart to start the following command:
"C:\Users\foobar\AppData\Local\nvim\plugged\omnisharp-vim\server\OmniSharp\bin\Debug\OmniSharp.exe" -p 2000 -s "C:\Users\foobar\workspace\Foo\FooSolution.sln"
Error detected while processing function OmniSharp#proc#neovimErrHandler:
line    1:
stderr: ['The file name syntax, the directory name or the volume label are incorrect^M', '']
Error detected while processing function OmniSharp#proc#neovimErrHandler:
line    1:
stderr: ['The file name syntax, the directory name or the volume label are incorrect^M', '']

It seems that the start server function has been called two times, by the way I did a small change, I changed the s:debug to echom, so that I can see the message before the error ( I do not know how to see the debug messages =)

@augustomelo, regarding the quotes, my thinking is that they are needed in case there are spaces in the command. I will try to get more tests and access to a windows machine to debug this.
I think I remember seeing the StartServer being run twice as I think once it is done because of some filetype magic. This, I think is a separate issue and it should still work regardless of this fact.
As for the debug messages, you can now set it in your vimrc as per:
let g:omnisharp_proc_debug = 1

Ah, I see.
I was looking the neovim documentation and I think that I might have found the problem. The parameters to jobstart can only be a string or a list of commands.
jobstart({cmd}[, {opts}])	{Nvim} *jobstart()*
		Spawns {cmd} as a job.  If {cmd} is a |List|, it will be run
		directly.  If {cmd} is a |string|, it will be roughly
		equivalent to >
			:call jobstart(split(&shell) + split(&shellcmdflag) + ['{cmd}'])
 		NOTE: read |shell-unquoting| before constructing any lists
		with 'shell' or 'shellcmdflag' options.  The above call is
		only written to show the idea, one needs to perform unquoting
		and do split taking quotes into account.

So I believe the problem is that the role command is not wrapped on a string the port and the solution are not wrapped:
"C:\Users\foobar\AppData\Local\nvim\plugged\omnisharp-vim\server\OmniSharp\bin\Debug\OmniSharp.exe" -p 2000 -s "C:\Users\foobar\workspace\Foo\FooSolution.sln"

I think the correct way is
"C:\Users\foobar\AppData\Local\nvim\plugged\omnisharp-vim\server\OmniSharp\bin\Debug\OmniSharp.exe -p 2000 -s C:\Users\foobar\workspace\Foo\FooSolution.sln"

@augustomelo, I tried passing the command as a list of parameters without escaping the paths. Tell me if that changes anything for you.

@aignas  I am still having troubles but it is with outer function now Omnisharp#util#path_join when you passed python as a parameter. Here is the error:
Error detected while processing function OmniSharp#util#path_join:
line    5:
E706: Variable type mismatch for: parts
line    1:
E730: using List as a String

Error detected while processing function provider#python#Call:
line   18:
error caught in request handler 'python_execute_file ('C:\\Users\\foobar\\workspace\\-1', 1, 1)':
Traceback (most recent call last):

      File "C:\Python27\lib\site-packages\neovim\plugin\script_host.py", line 86, in python_execute_file
          with open(file_path) as f:

IOError: [Errno 2] No such file or directory: 'C:\\Users\\foobar\\workspace\\-1'
Error detected while processing function OmniSharp#util#path_join:
line    1:
E730: using List as a String

Error detected while processing function provider#python#Call:
line   18:
error caught in request handler 'python_execute_file ('C:\\Users\\foobar\\workspace\\-1', 1, 1)':
Traceback (most recent call last):

File "C:\Python27\lib\site-packages\neovim\plugin\script_host.py", line 86, in python_execute_file
    with open(file_path) as f:

IOError: [Errno 2] No such file or directory: 'C:\\Users\\foobar\\workspace\\-1'
Error detected while processing function OmniSharp#StartServerIfNotRunning[2]..OmniSharp#StartServer[13]..OmniSharp#util#get_start_cmd[11]..OmniSharp#util#path_join:
line    1:
E730: using List as a String

Error detected while processing function OmniSharp#StartServerIfNotRunning[2]..OmniSharp#StartServer:
line   13:
E706: Variable type mismatch for: l:command
Error detected while processing function OmniSharp#StartServerIfNotRunning[2]..OmniSharp#StartServer[13]..OmniSharp#util#get_start_cmd[11]..OmniSharp#util#path_join:
line    1:
E730: using List as a String

Error detected while processing function OmniSharp#StartServerIfNotRunning[2]..OmniSharp#StartServer:
line   13:
E706: Variable type mismatch for: l:c

This is working great for me in vim8, after a couple of days of use.

Are there any remaining issues with this PR? It would be fantastic to get it merged!

Hi,
I'll have another look at what I have done and will remove anything that is
leftover and then will mark it as ready for the merge.
I'll try to get it done soon. :)
On Wed, 16 Aug 2017, 02:05 Nick Spoon<EMAIL_ADDRESS>wrote:

Are there any remaining issues with this PR? It would be fantastic to get
it merged!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OmniSharp/omnisharp-vim/pull/275#issuecomment-322613183,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOtKqvEQ62WpkCim4u22Qv-JwJbJnkRks5sYiRDgaJpZM4Kmk_G
.

--
Ignas Anikevcius
http://anikevicius.lt

@aignas Thanks for working this. Could you please rebase from master?

I hope I did not screw up anything whilst rebasing, so it wolud be great if some one else could confirm. :)

LGTM (with my some comments)
I'm not well know about tests of omnisharp-vim. it seems using bash command in the tests, is it not tested on Windows?

Yes, the tests where only run on Linux as I haven't got a Windows box I can use. It would be good to setup AppVeyor CI to run the tests but that, I guess, is a separate PR. :)

If there are no objections, I'd like this to get merged. :)

Sorry for lazy response 🙇
I'd check the code and it is OK.
I have not tried the behavior of this change in my environment(My environment has been broken for a long time...), however I do not want to make you wait any longer.
This is maybe OK.  I'll merge this.  Thank you for this work!

@thinca, thanks, if there are any issues with the new functionality, we can fix the bugs as they come along. :)


⚠ PostgreSQL has degraded performance

In 4637d01, PostgreSQL (https://news.ycombinator.com) experienced degraded performance:

HTTP code: 200
Response time: 3740 ms

Resolved: PostgreSQL performance has improved in db1de4e after 41 minutes.


document NMDC minted identifiers usage

Document the usage of NMDC minted identifiers.

use case, i.e., why and when we want to use NMDC minted identifiers
structure of an NMDC minted identifier

Completed by: https://microbiomedata.github.io/nmdc-schema/identifiers/#ids-minted-for-use-within-nmdc


Update yarn.lock

This should fix the deploy failure: https://circleci.com/gh/artsy/force/3150

👍 - will merge on 🍏


Support custom locales in case-insensitive queries

[c] doesn't support Russian language
func searchAutocompleteEntriesWithSubstring(substring: String) {
    suggestions.removeAll()

    let realmSuggestions = realm.objects(Cities).filter("ru BEGINSWITH[c] '\(substring)'")
    for suggestion in realmSuggestions {
        suggestions.append(suggestion.valueForKey("ru") as! String)
    }
    suggestionsTableView.reloadData()
}

In English it works as expected
func searchAutocompleteEntriesWithSubstring(substring: String) {
    suggestions.removeAll()

    let realmSuggestions = realm.objects(Cities).filter("en BEGINSWITH[c] '\(substring)'")
    for suggestion in realmSuggestions {
        suggestions.append(suggestion.valueForKey("en") as! String)
    }
    suggestionsTableView.reloadData()
}

Please fix.
Realm 0.96.2 / Xcode 7.1 / OSX 10.11.1
You can find me on Facebook for further assistance.

Realm only currently supports English/US for sorting (#2004) and case insensitive searches (now tracked by this issue).
Until we add support for this, you could store both your normal string along with a "normalized" version in your data model, where you perform the case folding before storing the value in Realm, perhaps using CFStringTransform. You could then search on that string (also normalizing your search input).

Please add case insensitive searches for Cyrillic :(

@Rusik that's exactly what this ticket is tracking

It's been a while. What's the status?

+1. Must have

@ITGypsy nobody cares, I guess :(

@ITGypsy @Galeas any alternatives to realm, except core data?

We certainly care about adding this feature, but have to weigh it against all the other work that needs to be done.
The fact that it's easy to work around for most cases (see recommendations in https://github.com/realm/realm-cocoa/issues/2879#issuecomment-158101749) is one reason why this isn't prioritized more highly.

Yes indeed, it's fairly easy to work around. Just use .lowercaseString when saving a copy of your string to your model, as well as when searching.
if realmSuggestions.filter("lowercaseRU BEGINSWITH '\(substring)'").count > 0 {

        for suggestion in realmSuggestions {

            suggestions.append("\(suggestion.valueForKey("ru") as! String)")
        }

        suggestionsTableView.reloadData()
}

But still, please don't keep putting it off. A work-around is a work-around, not a solution.

@jpsim hi! Can you tell me when are you going to add this feature? There is no way to add normalized string to each Object because of it takes a lot of time and this is not the right way.

No one's working on this at the moment and I have no estimate of when it'll be available.

Case insensitive search works with Russian language if you use it with cd:
.filter("name CONTAINS[cd] %@", ...)

Yeah, it works for case-insensitive search for me with CONTAINS[cd], but not CONTAINS[c] or LIKE[cd] *word* or LIKE[c] *word*. It's pretty strange.

as relevant, is there a solution?

CONTAINS[cd] Doesn't work for me.


Change scan location does not work

Thanks for the great work, the app looks fancy.
However I am not able to change my scan location. After I long press a location on the map, the server is still scanning the position I set on my browser, and only pokemons around this position will appear in the ios app.
Some configurations issue? thanks!

Hello, do you have the latest version of the server installed ? (V2)

I have v2.1.0 server deployed.
By tailing the log, I figured out that after changing scan location in the web version, its sending a request:
at=info method=GET path="/next_loc?lat=37.560465&lon=-122.251286"

But I did not see the server received this request after setting a new scan location in iOS app.
It this a new API in 2.1.0 they used? so that the iOS version is not supporting server v2.1.0?

Works great for me with v2.1.0 ...
Do you have installed latest version of the iOS app ?

@peter4k works great for me too, for server v2.1.0
To scan in a new location, you need to press down the screen to the new location and press the search icon.

I close the issue, please create a new one if problem persist.


Update 6

Hello,
First of all thanks for this amazing mod that made life waaayyyy easier;)
Do you plan to make it compatible with update 6 ?

Hello,
Unfortunately probably not. I don't play Timberborn anymore and my time is very limited, so currently I don't see myself updating this to U6.

Thanks for the news, I wish you well then ;)


Maybe not a bug. Safety: Cannot cast nullable value to not nullable type with Std.instance

class SomeClass {
    public function new() {}
}

class MaybeBug12 {
    public function bug() : Void {
        var a = new SomeClass();

        // Safety: Cannot cast nullable value to not nullable type.
        // Probably this is not a bug in Safety, and this issue related to Std.instance() signature
        var b : Null<SomeClass> = Std.instance(a, SomeClass);
    }
}

See https://github.com/restorer/haxe-safety-bugs/blob/master/safetybugs/Main.hx#L163 for working example.

This is for Haxe 4.0.0-preview.5 and Safety from master.

This is an intended behavior for a typed cast: https://github.com/RealyUniqueName/Safety/blob/9dc8579041dd9121eba1825ac1b6a7124a85129a/test/cases/TestCompileTime.hx#L505-L509
However, Std.instance() uses an untyped cast, which should ignore null safety checks: https://github.com/RealyUniqueName/Safety/blob/9dc8579041dd9121eba1825ac1b6a7124a85129a/test/cases/TestCompileTime.hx#L511-L514
Maybe Haxe typer makes them indistinguishable for the Safety plugin in case of Std.instance()

I think problem is in Std.instance signature, which is
public static function instance<T:{},S:T>( value : T, c : Class<S> ) : S;

However, documentation says:

This method checks if a downcast is possible. That is, if the runtime type of value is assignable to the class specified by c, value is returned. Otherwise null is returned.

Proper signature should be
public static function instance<T:{},S:T>( value : T, c : Class<S> ) : Null<S>;

I "fix" this by
@:safety(unsafe)
public static function instanceExt<T : {}, S : T>(value : T, c : Class<S>) : Null<S> {
    return Std.instance(value, c);
}


UI problem with Redactor -> Edit image

I am her: Page area --> added "Content block" --> Edit block --> Redactor - insert image "hello.jpeg".
Now if the user/dev want to remove the pic from the block (very common task)
The modal have option "Delete", but The label "Delete" is ambiguous:

Option 1 - "I want to delete the pic only from this block" ("remove")
Option 2 - "I want to delete the pic from entire site"

In practice 90% most of the times you want option 1 (you are in inline edit of a block not in the "File manger").
I think in this way its to easy to delete files from the library by mistake (if you use this pic more than one it can be really headache to fix this).

Solution option: Add button  - remove. Now the user will know the difference - one is remove (option 1) and the other is delete (option 2). The remove need to be more important (color / bold)

One more think: Like in window or Android when you delete file -  The modal "are you sure?" is more "safety".

CKEDITOR IN V8. Not relevant :) THANKS!


How to display menu correctly?

Hi Chris,
I have created the start Blazor app, installed Blazoerd.Menu Nuget and want to replace the VS generated menu with Blazored.Menu.
What is wrong? How to change the font color?
I have added the

to the _Host.cshtml.
I have attached the screenshot

There is the NavMenu.razor, there is old menu left too to compare.
NavMenu.razor.txt

Hi @Oleg26Dev, you just need to override the CSS styles with the settings you want such as the text colour. You can view the default CSS classes here.

Hi Chris,
Is it possible to expand/collapse sub-menus in code?
For instance, I would like to have a sub-menu expanded after login to an app.
Thanks in advance.
Fausto


Add authorship_verification task

This adds the task Authorship Verification in a Swapping Scenario in the authorship_verification directory. Also, a writing style keyword is added.

We see issue #276: We do not own the fanfictions used in the dataset. One option might be to download the fanfiction on-the-fly (e.g. from archive.org). We could also try to rebuild the dataset using free texts as suggested by @RomanPlusPlus in 276#issuecomment-841250495.

We would be open for suggestions regarding the formulation of the task. Currently, we ask:
Choose the text that has been written by the same author as:
We also thought about asking a real question like:
Which text is written by the same author as this text?
Also, we don't explicitly instruct the language model to use writing style to determine the correct choice. This could also be added.

Currently, the task's examples are quite long (ca. 3*500 words). This might be too long for many language models. However, reducing the text length poses the risk of making the task too challenging, as authorship style might be too hard to derive from short texts.
One thing we could offer is to provide multiple versions/subtasks/? of the dataset with different text lengths each.

Currently, the task's examples are quite long (ca. 3*500 words). This might be too long for many language models. However, reducing the text length poses the risk of making the task too challenging, as authorship style might be too hard to derive from short texts.

As I understand, the BIG-bench organizers are happy with the tasks that are technically challenging for the current language models. Such tasks move the inevitable benchmark saturation farther into the future, which is nice.

@niklasdeckers We are now requesting that task authors please include an explicit section in the README.md file called "data source", listing exactly where you got your data from (or explicitly state that you made it up yourself). Many thanks!

@aditya2211 are one of the assigned reviewers for this task.  Please provide feedback and be sure to notify me with a formal accept or does not meet criteria by Tuesday June 22 (if you have not already done so).

@nullstring are one of the assigned reviewers for this task.  Please provide feedback and be sure to notify me with a formal accept or does not meet criteria by Tuesday June 22 (if you have not already done so).

Hi! I am one of the assigned reviewers! Thanks for submitting the task.
Please see the details/questions below:
Correctness: Good.
Formatting: Can be improved, currently the task has unnatural delimiters (specifically newline):

Specificity: Good.
Thoroughness: Good with swapped and non-swapped variants. It would be good to add the number of examples in the READMEs.
Difficulty: Did not find the current performance based on READMEs, would be good to add a section.
Not solvable by memorizing the Internet: Since the PAN datasets is public, is it used in any pretraining corpus ?
Novelty: Good, with a rich prior work showing that hardness.
Justification: README is missing current performance etc.
Size: Good.
Compute resources: Good.

Hi @aditya2211 ! Thank you for your comments on our task.
We generally thought that the line breaks should be included in the dataset as they make for some form of style. However, as they pose an issue with the task evaluation, we now completely removed them.

As suggested in https://github.com/google/BIG-bench/pull/431#issuecomment-855229626 we now no longer include material with questionable copyright but rather build the dataset on-the-fly (by https://github.com/google/BIG-bench/pull/369/commits/7ac230d2ad3e94e5976cc44eaf24dd5511427b48). This might result in ca. 2 hours of delay before the evaluation starts. However, this part is not optimized on runtime yet and the delay could be reduced by multiprocessing etc.
Also, if you would prefer the previous version (using an explicit task.json), this would be no problem to us. Maybe @guygurari would also like to comment on this?
We included the number of samples (n=101 for each subtask) in the README.
Evaluation results on a reasonable random subset (n=20 for each subtask) are now included.
The PAN dataset has to be manually requested on Zenodo and is therefore not included in language model datasets.

@niklasdeckers, if I read the code correctly, the script is re-building the dataset every time the task is evaluated. I would kindly suggest to implement a check if the dataset is already there, and use the local copy if available. Will greatly reduce the evaluation time.

@niklasdeckers Thank you for putting in the effort to convert this to a programmatic task! I don't yet have an answer on the licensing issue. I suggest finishing the review process, and we will figure which version to use afterward.

The amount of tasks we received this round is tremendous.  With so many tasks to review we have decided to extend the review period to Tuesday, June 29.
Reviewers: if the submitter has made revisions please be sure to notify me with a formal ”accept” or ”does not meet criteria” by Tuesday, June 29  (if you haven't already done so).
this is an automated message

Thanks for your submission! I'm one of the reviewers for this task.
This is nice task measuring writing style of different authors. It is well targeted, novel and difficult for current model (as evaluated by the authors on gpt).
Couple suggestions below:
+1 to the point @RomanPlusPlus raised. It would be great to use a cache if possible. Even better would be to pre-crawl and pre-process the dataset and store it somewhere (or submit the data file as part of this PR). Is this a viable option?
Also, the tests on this PR don't seem to pass, is it possible to fix them?

Even better would be to pre-crawl and pre-process the dataset and store it somewhere

I think it's a reasonable suggestion. Perhaps one could store it in Google Drive or something similar. It would be faster to download it from there than to scrap the data. Although such an option is likely not as good from the copyright / licensing point of view as the current solution.

or submit the data file as part of this PR

As I understand, it can't be done, due to the license of the original data being incompatible with the license of BIG-bench.

Hi @nullstring ! Thanks for your comments.
Regarding the pytest issue: It seems like the unit test requires a max_examples argument in evaluate_model(...). However, I relied on the outdated(?) api documentation. This should be fixed now (I ran pytest locally).
Thanks to @RomanPlusPlus for suggesting the persistence of the dataset. This is now implemented (only for cases when max_examples is None as we could get issues with conflicting values of max_examples).
@nullstring A pre-crawled version of the dataset can be found in a previous version of this PR. Until it is decided (https://github.com/google/BIG-bench/pull/369#issuecomment-866213926) which version should be used, we chose to offer both options (with the original deadline in mind).

It would be great to use a cache if possible.

@nullstring Should we also add this caching to the Github Actions to speed up the tests (with https://github.com/actions/cache)?

Thanks for addressing my concerns!
Re cache: if you've already discussed this issue with organizers, then I'm good.
@Baschdl No need for my review as long as it passes locally, but you'd probably have to do something about the tests before merging the PR.
@chiafullo accept!

@chiafullo accept!

Your task has been accepted in the initial review stage.  The next stage of this process is for us to assign your task a meta-reviewer for final review and merge.  An assigned meta-reviewer will follow-up by commenting on the PR should it need further revisions.

I added a merge commit b/c it looks like you had deleted the 'biological' keyword in keywords.md.  So I put it back.

Hi @ramasesh ! Thank you for the fetch & merge. We did not really explicitly delete the 'biological' keyword as it was included in the main branch after our commits. However, there was indeed a merge conflict that you resolved. :thumbsup:
As there are now more tasks on this branch, I included a multiprocessing with 10 workers that should speed up the crawling in order to not exceed the Github Actions time limit for the unit tests.

@niklasdeckers @RomanPlusPlus
Hello, after reviewing the license of the datasource we determined that we will not be able to use it. However, if you are willing to rewrite the task using an alternative source for stories that has a more permissive license we would be happy to include it.
If you can find a suitable source by Wednesday, August 18th and notify us here we will move forward with the PR; otherwise it will be closed.  The code modifications do not have to be completed by Wednesday, we just need to know the source for the stories so we can verify the license.
Thank you for your patience on this and we look forward to hearing from you :)

Kristen

I would suggest https://en.wikisource.org/ as the source of Public Domain texts.
The works of 19th-century poets could be the best choice, as there their works:

are easy to find
are in the Public Domain
are plenty

For example, one can rebuild the dataset as follows:

Get a list of 19th-century poets from this page
For each poet, obtain 10 poems from wikisource.org
Process the poems in the same way as they were process for the previous dataset

Thank you @RomanPlusPlus for your suggestion to use poems from Wikisource. We also had a look at your previous suggestion to use public domain texts from Project Gutenberg.
The main benefits of using fanfictions were the following:

Long texts (we need ca. 500 words per segment to reasonably allow for writing style analysis). This might become hard for the poems.
Authors write in multiple fandoms; and for each fandom we have multiple authors. This is required for our swapping subtask (however, the non-swapped subtask would still work nevertheless).

For the poems, we could consider categories like "war poetry" or "love poems" instead of the fandoms. However, the number of authors that have written in both categories would be very small under the restrictions of Wikisource.
For Project Gutenberg texts, we could consider categories like "children's book" and "adult's book". There should be a reasonable amount of authors that wrote in both categories.
@chiafullo So our choice would be Project Gutenberg. Once we get your OK, we would start collecting the authors/books. Please also let us know if there are restrictions to the books that we can use from Project Gutenberg.

Hi @niklasdeckers, Project Gutenberg should be fine, but please make sure to check the license for each book you use.  Their website says that A few Project Gutenberg eBooks are protected by U.S. copyright law. You can tell by reading the license inside the book. You may download our copyrighted books and give copies away, but might be limited in commercial uses and derivative works..   From browsing, I couldn't find anything that was copyrighted but better to be on the safe side.
Looking forward to seeing the revised task.

We are done with the adjustments: The task is now non-programmatic (i.e. based on a task.json) again and uses Project Gutenberg books, which are referenced in the README. Please feel free to have a look at it. 👍

Hi @niklasdeckers , thanks for getting the task redone!
I have a few requests:

Each example in your task seems to start with the words: Choose the text that has been written by the same author as: .  Could you refactor the json so that this line is just given as an example_input_prefix?  This would make the file a bit more readable.

By default, for JSON tasks the append_choices_to_input option is False.  For this task, it seems like that option should be set to True.  Do you agree, and if so, can you make this change in the JSON file?

Could you edit the description to be a short (~ 1 sentence) imperative statement telling the task solver what to do?  Something like Identify which of the given passages was written by the same author as the reference.

As far as I can tell, everything looks good apart from that.

@ramasesh Thanks for your feedback!
We now adjusted the example_input_prefix according to your suggestion.
According to the doc.md, the default for append_choices_to_input should already be true - however, we specify this explicitly now.
We also edited the description in the task.json to be: "Identify which of the passages given as choices was written by the same author as the passage given as the reference."

Great, this all looks good to me now.  I will get someone else to look over it quickly and then merge if they sign off and these running tests pass.  Thanks!


Multinomial Logistic Regression throws execution error.

According to readme file (scripts/algorithms/README.md), multiLogReg.daph should work, however daphne returns the following error message:
$ bin/daphne scripts/algorithms/multiLogReg.daph XY=\"data/wine.csv\"

-- Initially:  Objective = 4898.000000,  Gradient Norm =<PHONE_NUMBER>26,  Trust Delta = 0.002849
-- Outer Iteration 1: Had 1 CG iterations, trust bound REACHED
   -- Obj.Reduction:  Actual = 114.631208,  Predicted = 894.703251  (A/P: 0.128100),  Trust Delta = 0.001425
   -- New Objective = 4783.368792,  Beta Change Norm = 0.002849,  Gradient Norm =<PHONE_NUMBER>78
Execution error: EwBinaryMat(Dense) - lhs and rhs must either have the same dimensions, or one of them must be a row/column vector with the width/height of the other

Lines 154-156 seem to affect P  matrix during the second iteration, causing issues when assigning P_1K.
Added print to lines 157 and 293 to help demonstrate the error:
// line 151
while ( converge != 1 ) #TODO !converge
{
    print("iteration starts...");
    # SOLVE TRUST REGION SUB-PROBLEM
    S = fill(0.0, D, K);
    R = Grad * -1.0; #TODO -Grad / 0-Grad support
    print(nrow(P) + " " + ncol(P));
    V = R;
    delta2 = delta ^ 2.0
    // ...
    // rest of the code...
    // ...
    print(nrow(P) + " " + ncol(P)); // line 273
    print("iteration ends...");
}

Output:
-- Initially:  Objective = 4898.000000,  Gradient Norm =<PHONE_NUMBER>26,  Trust Delta = 0.002849
iteration starts...
4898 10
-- Outer Iteration 1: Had 1 CG iterations, trust bound REACHED
   -- Obj.Reduction:  Actual = 114.631208,  Predicted = 894.703251  (A/P: 0.128100),  Trust Delta = 0.001425
   -- New Objective = 4783.368792,  Beta Change Norm = 0.002849,  Gradient Norm =<PHONE_NUMBER>78
4898 10
iteration ends...
iteration starts...
9 9
Execution error: EwBinaryMat(Dense) - lhs and rhs must either have the same dimensions, or one of them must be a row/column vector with the width/height of the other

I tracked it down to missing reference management on slice operations (which is what the right indexing of P_1K = P[0:N1, 0:K]; is doing.

Thanks for reporting this bug, @aristotelis96. I can also reproduce it. Unfortunately, I wasn't able to quickly find the cause, but following up on @corepointer's comment, I can confirm that the script works when calling daphne with --no-obj-ref-mgnt. Please shout out if this issue is blocking you.
In fact, this script used to work properly. We need to add test cases that check if the examples work at some point (see #559) to avoid breaking the examples again in the future...


feat: extend include for environment and paths

include in apko file does not support base configurations for environments and path mutations.
Like so packages, the environment variables and path configurations also are usefull.
The main apko file always have priority over base configuration. For example to overwrite env vars.

@imjasonh @jonjohnsonjr would you be so kind to review this?

@imjasonh shall you review it?

@imjasonh one more please

@imjasonh  any comments? do you think about?

@imjasonh could you give feedback about it please?

@imjasonh @jonjohnsonjr @k4leung4  🏓

@imjasonh Do you think this still makes sense? This PR was here for the last tree months


TypeError: Cannot read properties of undefined (reading '_internal_addDataSource')

I been using a modified version of the React example found on the documentation that suggests chart.remove(); to be called once the useEffect is called.
The problem is that sometimes due to race conditions with "await" functions to fetch candle data the removed chart ends up receiving a call, for instance "const mainSeries = chart.addCandlestickSeries(....)" and when this call happens that error happens:
TypeError: Cannot read properties of undefined (reading '_internal_addDataSource')
Lightweight Charts™ Version:
Latest
Steps/code to reproduce:
    useEffect(
        () => {
          const chart = createChart(chartContainerRef.current, chartOptions)

          //sudo code

          candles = await fetchCandles()

          // hack needed to avoid errors when refreshing the chart
          // if I comment the if condition problems will be thrown on the console
          if (chart['isRemoving']) {
             return
          }

         chart.const mainSeries = chart.addCandlestickSeries(candles)

        // error happens

            return () => {
                window.removeEventListener('resize', handleResize);

                chart['isRemoving'] = true // hack to fix the problem

                chart.remove();
            };
        },
        [data, backgroundColor, lineColor, textColor, areaTopColor, areaBottomColor]
    );

Actual behavior:
TypeError: Cannot read properties of undefined (reading '_internal_addDataSource')
Expected behavior:
after chat.remove() is called function calls such as addCandlestickSeries ( and others that would error ) should silently fail as the chart is already removed?
not sure if that's ideal, but you got the idea ( :

Hi, for cases like this when you have some race conditions, we suggest you use React.useRef to check if the component is still mounted.
const isMounted = useRef(true);

  useEffect(
        () => {
          const chart = createChart(chartContainerRef.current, chartOptions)
          candles = await fetchCandles()
          if (isMounted.current) {
             // Do whatever you want to do with chart
             const mainSeries = chart.addCandlestickSeries(candles)
          }

            return () => {
                window.removeEventListener('resize', handleResize);
                isMounted.current = false;
                chart.remove();
            };
        },
        [deps]
    );

Also, you could use AbortController to prevent fetching the data if the component is already unmounted

Hi, for cases like this when you have some race conditions, we suggest you use React.useRef to check if the component is still mounted.

Also, you could use AbortController to prevent fetching the data if the component is already unmounted

Thanks for the suggestions @illetid definitely more elegant than my ['isRemoving'] hack.
Still, due the fact this happens with the most basic react example on the documentation when used on Next.js ( due to the re-render nature of hydration, etcs ) wouldn't it make sense to have the library not trying to read some _internal* variable after the remove() method has been called?

The library is client-side only, so you shouldn't render it on the server; in the case of the modern Next.js, you should use the 'use client' directive. Regarding accessing some properties after remove(), we don't have plans to change the current behavior, at least in the near future.

The library is client-side only, so you shouldn't render it on the server;
i'm not rendering on the server, on the server i show a "skeleton"

in the case of the modern Next.js, you should use the 'use client' directive. Regarding accessing some properties after remove(), we don't have plans to change the current behavior, at least in the near future.

thank you, your suggestions and explanations were very helpful.


fix(checkout): CHECKOUT-000 Add focus to checkout-customer-login

What?
Add tabIndex and role="button" to #checkout-customer-index
Why?
As proposed in #1412 adding these properties will allow screen readers and keyboard users to focus the 'Sign in now` Link
Testing / Proof

@bigcommerce/team-checkout

@bc-0dp I think this solves it! I like that you defined the role as well :)

There is a tabindex={0} now, added by this PR. https://github.com/bigcommerce/checkout-js/pull/881
Perhaps we need to replace one with tabindex={1}.
cc @animesh1987

@bc-peng According to MDN

You are recommended to only use 0 and -1 as tabindex values.

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex


Android 7.0/8.0 Request permission is not prompted

From @liuchuancong on July 3, 2018 12:21
 <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
 <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />

I don't have any tips on my phone （Android 8.0）
Copied from original issue: NativeScript/NativeScript#6020

From @liuchuancong on July 3, 2018 12:34
i want use geolocation,
on 6.0 i do it, but on 8.0 it can't

HI @liuchuancong,
I tested your case with our nativescript-geolocation demo app, however, was unable to recreate an issue with permission requests, while using Android 8. You can check the demo app here. It will help if you provide more info about your environment(CLI, tns-core-modules, tns-android versions). Also, send us sample project, which can be used for debugging.

@tsonevn thanks! I will try more

@tsonevn  How I should solve it.

Hi @zuohuadong,
As I mentioned in my previous comment, I can not recreate a similar problem with the plugin's demo project. In the demo app, we are using enableLocationRequest method to request for permissions. The method will also prompt the user to accept or denied the request. If you have a case that this does not work, send us a demo app, and we will research the issue.

after 6.0 should  get location permissions dynamically
in nativescript how do it?

@liuchuancong you can use nativescript-permissions plugin to ask for permission runtime (example)

@NickIliev No support nativescript 4.0+

@zuohuadong the plugin is working as expected with NativeScript 4+ (the linked example is using {N} 4+) - here is another test application demonstrating the above.

@NickIliev
The  nativescript-geolocation  use google service.
But it cannot be used in China.

@NickIliev
Can you help me? I have no other option.
Nativescript-geolocation Plug-ins need to be improved
What causes the need to rely on Google services?
Can we make a new version without Google service?

@zuohuadong this seems like a request for an entirely new plugin as it would break all current users (if we totally change the API).
In would suggest that you investigate what map service is not blocked in mainland China and see if there is already created a plugin for NativeScript (or wrap the related library in your own plugin/project). (e.g. check Mapbox)


Improve CSS

In a project I'm contributing to, we want to customize django-rest-swagger. But we have some issues caused by these resets. So I'm doing this pull request to be sure that the staticfiles of django-rest-swagger won't interfere with other staticfiles.

@ariovistus : Approximatively, when will be the next release ? :)

@Situphen when I'm not distracted by robotics (next week)

@ariovistus thanks! :)


Question on Alexa status

Bit of a long shot, how does this control the way Alexa sees the relay is on?
I'm using this fine with a relay which pulses a 12v diesel heater switch.
The relay is connected on the back of the on/off switch. To power on it activates the relay for 1 second then turns off the relay  & the heater starts up, then turning off it activates the relay for 5 seconds to begin the shutdown sequence of the heater & turns the relay off. the Alexa switch status only stays on when the relays on.
Is it possible to keep the status as on (even when the relays off) so i can see when the heaters running?
Kind Regards
James

It doesn’t. Alexa only sees the relay activation status, not the state of whatever you attach to it
But I hacked around one of those two other functions that are compiled along with the main Audino sketch to achieve this by assigning another auduino pin to be the feedback towards Alexa  instead. Took me ages and only works for a single control , but it’s functional , sort of.
You still can’t ask Alexa if the thing is on or off, but at least it displays correctly in the app if you look at it
But if you
Get Outlook for iOShttps://aka.ms/o0ukef

From: Jamesb4uk @.***>
Sent: Sunday, November 5, 2023 6:48 AM
To: kakopappa/arduino-esp8266-alexa-multiple-wemo-switch
Cc: Subscribed
Subject: [kakopappa/arduino-esp8266-alexa-multiple-wemo-switch] Question on Alexa status (Issue #79)
Bit of a long shot, how does this control the way Alexa sees the relay is on?
I'm using this fine with a relay which pulses a 12v diesel heater switch.
The relay is connected on the back of the on/off switch. To power on it activates the relay for 1 second then turns off the relay & the heater starts up, then turning off it activates the relay for 5 seconds to begin the shutdown sequence of the heater & turns the relay off. the Alexa switch status only stays on when the relays on.
Is it possible to keep the status as on (even when the relays off) so i can see when the heaters running?
Kind Regards
James
—
Reply to this email directly, view it on GitHubhttps://github.com/kakopappa/arduino-esp8266-alexa-multiple-wemo-switch/issues/79, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJFRJWTEO27M4CSFHSV7Z7LYCZ5XPAVCNFSM6AAAAAA65XDYESVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3TONBUGU2TIOI.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Thanks Ynot1
I started reading some of the other comments on how this interacts with Alexa & just built a 2nd test device to play with.
Hooking up the serial monitor is proving useful as i can see the comms to the D1 Mini
Got UDP Belkin Request..
Sending response to
Port : 60562
Response sent !
Got UDP Belkin Request..
Sending response to
Port : 42294
Response sent !
########## Responding to  /upnp/control/basicevent1 ... ##########
request:<s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/"s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"><s:Body><u:SetBinaryState xmlns:u="urn:Belkin:service:basicevent:1">1</u:SetBinaryState></s:Body></s:Envelope>
Got Turn on request
Relay On
Relay On
Relay On
Sending :<s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/" s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"><s:Body>
<u:GetBinaryStateResponse xmlns:u="urn:Belkin:service:basicevent:1">
1
</u:GetBinaryStateResponse>
</s:Body> </s:Envelope>
########## Responding to  /upnp/control/basicevent1 ... ##########
request:<s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/"s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"><s:Body><u:GetBinaryState xmlns:u="urn:Belkin:service:basicevent:1">1</u:GetBinaryState></s:Body></s:Envelope>
Got binary state request
Sending :<s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/" s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"><s:Body>
<u:GetBinaryStateResponse xmlns:u="urn:Belkin:service:basicevent:1">
1
</u:GetBinaryStateResponse>
</s:Body> </s:Envelope>
Got UDP Belkin Request..
Sending response to
Port : 45728
Response sent !
########## Responding to  /upnp/control/basicevent1 ... ##########
I think the Binarystate is what I'm going to work on figuring out as when it turns of it switches to 0
I'll post back if i work it out
Kind Regards
James

in module switch.cpp
I defined an external boolean
extern bool GarageDoorState; (this is attached to a read of another arduino
pin in the main sketch)
===-===--
I then just crudely overwrote switchStatus with that value before it is
sent to Alexa (which is why this solution isnt great if you are dealing
with more than 1 external thing)
if (request.indexOf("GetBinaryState") >= 0)  {
switchStatus = !GarageDoorState ;
....
On Sun, Nov 5, 2023 at 11:05 AM Jamesb4uk @.***> wrote:

Thanks Ynot1
I started reading some of the other comments on how this interacts with
Alexa & just built a 2nd test device to play with.
Hooking up the serial monitor is proving useful as i can see the comms to
the D1 Mini
Got UDP Belkin Request..
Sending response to
Port : 60562
Response sent !
Got UDP Belkin Request..
Sending response to
Port : 42294
Response sent !
########## Responding to /upnp/control/basicevent1 ... ##########
request:<s:Envelope xmlns:s="
http://schemas.xmlsoap.org/soap/envelope/"s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"><s:Body><u:SetBinaryState
xmlns:u="urn:Belkin:service:basicevent:1">1</u:SetBinaryState></s:Body></s:Envelope>
Got Turn on request
Relay On
Relay On
Relay On
Sending :<s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/"
s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"><s:Body>
<u:GetBinaryStateResponse xmlns:u="urn:Belkin:service:basicevent:1">
1
</u:GetBinaryStateResponse>
</s:Body> </s:Envelope>
########## Responding to /upnp/control/basicevent1 ... ##########
request:<s:Envelope xmlns:s="
http://schemas.xmlsoap.org/soap/envelope/"s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"><s:Body><u:GetBinaryState
xmlns:u="urn:Belkin:service:basicevent:1">1</u:GetBinaryState></s:Body></s:Envelope>
Got binary state request
Sending :<s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/"
s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"><s:Body>
<u:GetBinaryStateResponse xmlns:u="urn:Belkin:service:basicevent:1">
1
</u:GetBinaryStateResponse>
</s:Body> </s:Envelope>
Got UDP Belkin Request..
Sending response to
Port : 45728
Response sent !
########## Responding to /upnp/control/basicevent1 ... ##########
I think the Binarystate is what I'm going to work on figuring out as when
it turns of it switches to 0
I'll post back if i work it out
Kind Regards
James
—
Reply to this email directly, view it on GitHub
https://github.com/kakopappa/arduino-esp8266-alexa-multiple-wemo-switch/issues/79#issuecomment-1793565886,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJFRJWRUR5TKK2KBQB2DTY3YC23ZJAVCNFSM6AAAAAA65XDYESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGU3DKOBYGY
.
You are receiving this because you commented.Message ID:
<kakopappa/arduino-esp8266-alexa-multiple-wemo-switch/issues/79/1793565886
@github.com>

Thanks again.
I was actually looking at switch.cpp & going down the road that you have done last night its a on/off switch so no issues for me.
Interesting, you did a not operation on GarageDoorState, maybe its Monday brain shock how does that work with switchstatus?
James

GarageDoorState; (this is attached to a read of another arduino pin in the main sketch)
Get Outlook for iOShttps://aka.ms/o0ukef

From: Jamesb4uk @.>
Sent: Tuesday, November 7, 2023 8:45:45 AM
To: kakopappa/arduino-esp8266-alexa-multiple-wemo-switch @.>
Cc: Ynot1 @.>; Comment @.>
Subject: Re: [kakopappa/arduino-esp8266-alexa-multiple-wemo-switch] Question on Alexa status (Issue #79)
Thanks again.
I was actually looking at switch.cpp & going down the road that you have done last night its a on/off switch so no issues for me.
Interesting, you did a not operation on GarageDoorState, maybe its Monday brain shock how does that work with switchstatus?
James
—
Reply to this email directly, view it on GitHubhttps://github.com/kakopappa/arduino-esp8266-alexa-multiple-wemo-switch/issues/79#issuecomment-1796192607, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJFRJWQ4SIG6TN25OQ5A5ITYDE46TAVCNFSM6AAAAAA65XDYESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJWGE4TENRQG4.
You are receiving this because you commented.Message ID: @.***>

ok i think i understand, will give it a try.
Appreciate your help in this
James


[FLOC-3752] Update version of docker-py and remove workaround

Fixes https://clusterhq.atlassian.net/browse/FLOC-3752

Decided to force kick an acceptance run on Ubuntu/EBS to verify the fix. I know it is required for test_docker.silver_profile and I think it is required for test_docker.sized - so we might already have confidence from the passing sized volume creation against the loop device, but I'd like to see the profile test pass as well for added confidence.

Green tests for all of the presubmits.
Also it looks like the AWS / EBS run that I triggered is working (http://ci-live.clusterhq.com:8080/job/ClusterHQ-flocker/job/update-docker-py-to-1.6.0-FLOC-3752/job/_run_acceptance_on_AWS_Ubuntu_Trusty_with_EBS/1/console):
21:34:49 flocker.acceptance.endtoend.test_dockerplugin
21:34:49   DockerPluginTests
21:35:20     test_create_container_with_v2_plugin_api ...                           [OK]
21:36:08     test_create_silver_volume_with_v2_plugin_api ...                       [OK]
21:36:58     test_create_sized_volume_with_v2_plugin_api ...                        [OK]
21:38:12     test_move_volume_different_node ...                                    [OK]
21:39:04     test_move_volume_single_node ...                                       [OK]
21:39:51     test_run_container_with_preexisting_volume ...                         [OK]
21:40:43     test_run_container_with_volume ...                                     [OK]
21:41:58     test_volume_persists_restart ...                                       [OK]

Those OK's give me confidence that the original reason for the workaround is not broken by this PR.

LGTM.


QC is not thread safe

In version 3.1RC1
If you're using a forking worker such as puma, the QC.default_conn_adapter method gets memorized globally. Since each thread normally have their own db connection, the DB connection used by QC will be a different one to the one used by the web process.
This breaks transaction isolation and can create crashes that are very painful to debug.

:+1: good find

I'm closing this one as #248 has been merged.
@smathieu feel free to reopen if there is more todo.


Let open the URL in a specific browser

Is there a way I can configure the plugin to open the URL in a specific browser? (I have more then one browser installed)

Yes, the plugin just calls urlview or extract_url, you have to check those tools' configuration.


Add default port: 3000

Closes #75

I removed this because I wanted the default port to be a random one.

Oh, okay. I was thrown off because it doesn't work at all without explicitly setting the flag or env var.

@lukeed What's the node version you're on it? Because if you don't pass a port to a HTTP server in node, it will normally just use a random open port.

I'm on 6.9.1 🤔

@lukeed What's the error you're getting?

This happened to me on a now deployment as well, even when serve was the only dependency installed. So I don't think I'm alone here?
RangeError: "port" argument must be >= 0 and < 65536
    at assertPort (internal/net.js:17:11)
    at Server.listen (net.js:1388:5)
    at Object.<anonymous> (/Users/lukee/repos/personal/apps/colors-app/node_modules/serve/lib/index.js:47:8)
    at Module._compile (module.js:570:32)
    at Module._compile (/Users/lukee/repos/personal/apps/colors-app/node_modules/async-to-gen/register.js:37:23)
    at Module._extensions..js (module.js:579:10)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/lukee/repos/personal/apps/colors-app/node_modules/async-to-gen/register.js:40:5)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)

@lukeed Fixed! Please get the latest update.

Cool, thanks!


_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  0s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
javadoc
0m 18s

the patch passed

+1 :green_heart:
shadedjars
5m  8s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
0m 52s
/patch-unit-hbase-rest.txt
hbase-rest in the patch failed.

20m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6499/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6499

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux c94c98fe1327 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / cd1d831fda54ae7f1b48ae44aa531b8ac70f0be4

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6499/2/testReport/

Max. process+thread count
225 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6499/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 33s

master passed

+1 :green_heart:
compile
0m 37s

master passed

+1 :green_heart:
checkstyle
0m 12s

master passed

+1 :green_heart:
spotbugs
0m 42s

master passed

+1 :green_heart:
spotless
0m 49s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 16s

the patch passed

+1 :green_heart:
compile
0m 41s

the patch passed

+1 :green_heart:
javac
0m 41s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 11s
/results-checkstyle-hbase-rest.txt
hbase-rest: The patch generated 1 new + 22 unchanged - 0 fixed = 23 total (was 22)

-1 :x:
spotbugs
0m 48s
/new-spotbugs-hbase-rest.html
hbase-rest generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
hadoopcheck
11m 54s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 46s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 10s

The patch does not generate ASF License warnings.

31m 38s

Reason
Tests

SpotBugs
module:hbase-rest

org.apache.hadoop.hbase.rest.model.ScannerModel$IncludeStartRowFIlter.equals(Object) checks for operand being a Boolean  At ScannerModel.java:a Boolean  At ScannerModel.java:[line 151]

org.apache.hadoop.hbase.rest.model.ScannerModel$IncludeStartRowFIlter defines equals and uses Object.hashCode()  At ScannerModel.java:Object.hashCode()  At ScannerModel.java:[line 151]

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6499/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6499

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux afb55d73d05e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / cd1d831fda54ae7f1b48ae44aa531b8ac70f0be4

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6499/2/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Please see my comments

review comments are fixed, pls check

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

-0 :warning:
yetus
0m  4s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 56s

master passed

+1 :green_heart:
compile
0m 23s

master passed

+1 :green_heart:
javadoc
0m 19s

master passed

+1 :green_heart:
shadedjars
5m 35s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 14s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
javadoc
0m 17s

the patch passed

+1 :green_heart:
shadedjars
6m  8s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
0m 50s
/patch-unit-hbase-rest.txt
hbase-rest in the patch failed.

21m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6499/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6499

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 6436b68c659e 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 58f84949d5819175217fe82eb58609cc35a1a24e

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6499/3/testReport/

Max. process+thread count
213 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6499/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 26s

master passed

+1 :green_heart:
compile
0m 33s

master passed

+1 :green_heart:
checkstyle
0m 10s

master passed

+1 :green_heart:
spotbugs
0m 38s

master passed

+1 :green_heart:
spotless
0m 46s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  1s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m  9s
/results-checkstyle-hbase-rest.txt
hbase-rest: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)

-1 :x:
spotbugs
0m 44s
/new-spotbugs-hbase-rest.html
hbase-rest generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
hadoopcheck
11m 49s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

-1 :x:
spotless
0m 43s

patch has 23 errors when running spotless:check, run spotless:apply to fix.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 42s

the patch passed

+1 :green_heart:
compile
0m 19s

the patch passed

+1 :green_heart:
javac
0m 19s

the patch passed

+1 :green_heart:
javadoc
0m 15s

the patch passed

+1 :green_heart:
shadedjars
5m 25s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 39s

hbase-rest in the patch passed.

22m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6499/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6499

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux f55df038e81c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d7935bad22a75f7c2cefffefe4e5b9982c52d942

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6499/4/testReport/

Max. process+thread count
1666 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6499/4/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 26s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 11s

master passed

+1 :green_heart:
compile
0m 40s

master passed

+1 :green_heart:
checkstyle
0m 16s

master passed

+1 :green_heart:
spotbugs
0m 55s

master passed

+1 :green_heart:
spotless
0m 53s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 39s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m  9s
/results-checkstyle-hbase-rest.txt
hbase-rest: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)

-1 :x:
spotbugs
0m 42s
/new-spotbugs-hbase-rest.html
hbase-rest generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
hadoopcheck
11m 45s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 45s

patch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 43s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
javadoc
0m 17s

the patch passed

+1 :green_heart:
shadedjars
4m 55s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 13s

hbase-rest in the patch passed.

21m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6499/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6499

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 53a63a8ffb9b 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 074f1619b528a66bc53897c0621d6cf95a71b2e2

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6499/5/testReport/

Max. process+thread count
2082 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6499/5/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 52s

master passed

+1 :green_heart:
compile
0m 34s

master passed

+1 :green_heart:
checkstyle
0m 11s

master passed

+1 :green_heart:
spotbugs
0m 38s

master passed

+1 :green_heart:
spotless
0m 44s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 40s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 11s

the patch passed

+1 :green_heart:
spotbugs
0m 40s

the patch passed

+1 :green_heart:
hadoopcheck
9m 39s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 40s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s

The patch does not generate ASF License warnings.

26m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6499/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6499

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux ceef54b14c8b 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 074f1619b528a66bc53897c0621d6cf95a71b2e2

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6499/5/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


[Feature] Add PUID and PGID environment variables to run docker container as non-root user

Every single linuxserver.io docker container has this option which I think is amazing: https://docs.linuxserver.io/general/understanding-puid-and-pgid
I would like to run changedetection.io as a particular user, which would solve a lot of permission issues. In all LSIO containers I just set the PUID and PGID environment variables and boom, the containers runs as that user.
Would it be possible to add such a feature? It makes managing Docker containers much easier.

Cant' you just add the following to your docker-compose.yml
environment:
  - PUID=1000
  - PGID=1000

?
doesnt that solve your situation as per the documentation in that link?
I could add it but it would break the existing installations I think, i'll add it as a commented out block

I dont know how to solve this one for where people already have data in /datastore owned by root from previous installs ;(

Yes, it is true. I confirm that setting the PUID and PGID as environment variables it works. I thought that because you had not specified in the documentation then they would not work.


Added a prototype of call stack sampling using framepointers

The current implementation is disabled by default. So far there is also no flag to activate it.
It uses perf_event_open's PERF_SAMPLE_CALLCHAIN flag.

Thanks for the review. I addressed the comments and responded to the questions above.

Please try to push and reply to/resolve comments more or less at the same time, otherwise it's confusing when there are multiple reviewers.

Thanks for the review. I addressed the comments and waiting for LGTM.

Addressed the review comments. Waiting for @dpallotti 's final approval before submitting it.


Support basic type for convenience

i8 *
i32 *
i64 *
u8
u16
u32
u64
f32 *
f64 *
[V; len] as arr<V, len>, machine type?
str *

* mean more important than remains
Can convert arr<V, len> to list<V> with length len

implement i32, i64, f32, f64, () as void at commit: 0a7d6dbaf9f935ada21958d7b410209159bbb86f

i8 is important because of str operations will need it

Parser has to have a syntax detect type for literal.
Or listener changes literal type if needed.

lexer should split Int, Float format.
Default use i32 & f32
If var has the type, trying to convert to that one, else create an error report

TODO: we have default literal as i32 and f32, we need a suffix can change the default type
Ex.
a = 3_i64
b = 5_f64
c = 1_i8

Complete at commit: 9613c74f75dbe36beb8accf5ada6a648b8d92fd7

i8
i16
i32
i64
f32
f64


[AutoPR managedservices/resource-manager] [Hub Generated] Review request for Microsoft.ManagedServices to add version stable/2019-09-01

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7426

(message created by the CI based on PR content)


⚠ Itaca Gallery has degraded performance

In e8209f2, Itaca Gallery ($SITE_TCGLR) experienced degraded performance:

HTTP code: 200
Response time: 6416 ms

Resolved: Itaca Gallery performance has improved in 28fed80 after 8 minutes.


Add filesBlacklist to avoid preloading certain files

For example, sourcemaps should not be preloaded.
This is configurable via the filesBlacklist option. This would be a
breaking change, but you could easily avoid that by making the array
empty and just advising people on how to add it in the docs.
@addyosmani I needed this so I could use this in a project - thought I might as well make the PR. I'm happy to work on the README and stuff if you do want something like this in the project - else no problem!

@jackfranklin Implementation LGTM. Could you add a commit with some README content? Thanks for the PR!

@jackfranklin Fyi, we just merged a change that will require a rebase against master. Hope you're still interested in landing this :)

@addyosmani rebased and tests updated - definitely up for this to land! Just writing README.

👍

@jackfranklin thanks for the feature @addyosmani any chance you could release a version for this new feature? I would like to use that in my project. Thanks in advanced!

@laysent done! new version out :)


Simple Search tests

This PR connects #134 and is dependent on #162
As requested in the discussion at PR #151, I added new tests (both unit and e2e tests) for the simple search page.

The test coverage reduced considerably. And not because of the lack of coverage on this pull requests feature. The nature of the karma test build is how the low coverage was immediately unnoticed. Karma brings in the spec.bundle.js which it includes all the spec files by globbing. The test build and coverage is only aware of code imported into spec files.

@wwelling : I'm not sure if I fully understand your explanation (though I'm less familiar with how Karma works, as of yet).  Are you saying that this newly calculated coverage percentage (51.5%) is more accurate than the one currently noted on master (~70%)?

@tdonohue I understood from @wwelling that the coverage tool only looks at files that are used by (karma) spec files.
The existing tests only used a few components (because they probably were pretty low level and not dependent on existing components), which it also tested for the most part (70%).
The tests I added test components that are more high-level and use other components (i.e. the object-list component) that already existed, but for which no tests were written yet. So the coverage tool is now all of a sudden also aware of all those other components (as they weren't mentioned/used before in any spec file).
There may be more tests, but the tool is also aware of more code that exists.
So we probably need a way of making all code "visible" to the coverage test plugin. I think @wwelling was looking for a solution for this. At the moment the percentage has little to do with actual coverage - if you'd test a single low-level component for 100% in 1 spec file and would not add any other spec files, according to this tool, our test coverage would be 100%.

@tdonohue yes, they are more accurate. The spec tests written so far are not importing the entire code base. Therefore, there is no way for karma to create coverage against files not imported into a spec. The primary culprit is that the core module, which imports all the service singletons, is not imported into any spec.

@artlowel suggested simply importing app.module.ts into app.component.spec.ts. This should include everything app.module.ts imports. This may not include lazily loaded modules though.

Approved in today's meeting. Merging


remove UnusedImports

What is the purpose of the change
remove UnusedImports which against Checkstyle 8.9 with codestyle/checkstyle.xml ruleset
Brief changelog
remove unused constant keys: GROUP_KEY and VERSION_KEY
Verifying this change
~
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[X] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[X] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[X] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[X] If this contribution is large, please follow the Software Donation Guide.

@tangcent thanks for your contribution 👍


Bookstore: connect to API

[ ] Created the FetchWraper class
[ ] Implemented the communication with server in the BooksAPI
[ ] Installed and included the thunk as a middleware in the store creator
[ ] Created a displayBooks thunk function
[ ] Implemented communication with the API
[ ] Made the percent and chapter random figures

Hi @kingqabil,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Feature 7

Changes Unknown when pulling 1e240ff2f3d3f03e1716f38ac110ce29c5ba17e6 on feature-7 into ** on develop**.

Changes Unknown when pulling ddb36fd03837ddf1b622ffc06a966e7d99e9cda9 on feature-7 into ** on develop**.

Changes Unknown when pulling fa15733f4174e3c63f6cad73099dc3194f15df45 on feature-7 into ** on develop**.


use the rg (ripgrep) built into VS Code

VS Code ships with an rg binary for the current platform. By using this instead of bundling our own, we (1) reduce the extension bundle size (which makes it faster for people to try out Cody in VS Code), and (2) simplify and speed up our own builds.
VS Code may change the location of rg, but it is fairly unlikely because it uses the @vscode/ripgrep package that is unlikely to significantly change.
See the VS Code implementation of its builtin rg service at<EMAIL_ADDRESS>Test plan
Run a keyword context operation (such as a chat in a workspace with no embeddings) and confirm that it works and that it invokes the VS Code-bundled rg.

Reduced the .vsix size from 30 MB to 6 MB.


Builds are failing with Sphinx version issue

As of this past weekend, all Cookbook builds seem to be broken with a new version conflict.
See the nightly build here
Sphinx version error:
The sphinxcontrib.applehelp extension used by this project needs at least Sphinx v5.0; it therefore cannot be built with this version.
Traceback (most recent call last):
  File "/home/runner/miniconda3/envs/cookbook-dev/lib/python3.10/site-packages/sphinx/registry.py", line 438, in load_extension
    metadata = setup(app)
  File "/home/runner/miniconda3/envs/cookbook-dev/lib/python3.10/site-packages/sphinxcontrib/applehelp/__init__.py", line 230, in setup
    app.require_sphinx('5.0')
  File "/home/runner/miniconda3/envs/cookbook-dev/lib/python3.10/site-packages/sphinx/application.py", line 393, in require_sphinx
    raise VersionRequirementError(version)
sphinx.errors.VersionRequirementError: 5.0

https://github.com/sphinx-doc/sphinxcontrib-applehelp released a new version (1.0.8) Saturday. I suspect we'll need to specify <1.0.8 for now.


Is it possible to convert the uploaded files via hooks?

Is it possible to convert the uploaded files via hooks?
So for example, I'm making a service that would accept any type of audio file (mp3, flac, acc) and would offer them for download in a specific format (for example wav). How should I approach this conversion? I was thinking that I could do the conversion work after the final hook but how can I replace the uploaded file in tusd with the converted one? Is it possible to do it on-the-fly?

I was thinking that I could do the conversion work after the final hook

Yes, the post-finish hook is the perfect spot to start the conversion process.

how can I replace the uploaded file in tusd with the converted one?

Frankly, I would not do that at all. Yes, you can replace the files in which tusd stores the upload, but tusd is not meant as a download server. It's optimized for file uploads and does not implement caches and so on. Instead, I recommend you to save the converted files somewhere else and use a proper tool for serving those files.

Great! Thank you!

You're welcome :)