DTSPO-16389: remove keyvault roles as access policy only

Jira link (if applicable)
https://tools.hmcts.net/jira/browse/DTSPO-16389
Change description

remove keyvault role assignment as access policy only

Checklist

[x] commit messages are meaningful and follow good commit message guidelines
[x] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)
[ ] Does this PR introduce a breaking change

Plan Result (prod_app_registrations)
:warning: Resource Deletion will happen :warning:
This plan contains resource delete operation. Please check the plan result very carefully!
Plan: 0 to add, 0 to change, 1 to destroy.

Delete

module.this.azurerm_role_assignment.this["WAF Monitoring-Key Vault Secrets User-/subscriptions/1baf5470-1c3e-40d3-a6f7-74bfbce4b348/resourceGroups/core-infra-intsvc-rg/providers/Microsoft.KeyVault/vaults/cftptl-intsvc"]

Change Result (Click me)

  # module.this.azurerm_role_assignment.this["WAF Monitoring-Key Vault Secrets User-/subscriptions/1baf5470-1c3e-40d3-a6f7-74bfbce4b348/resourceGroups/core-infra-intsvc-rg/providers/Microsoft.KeyVault/vaults/cftptl-intsvc"] will be destroyed
  # (because key ["WAF Monitoring-Key Vault Secrets User-/subscriptions/1baf5470-1c3e-40d3-a6f7-74bfbce4b348/resourceGroups/core-infra-intsvc-rg/providers/Microsoft.KeyVault/vaults/cftptl-intsvc"] is not in for_each map)
  - resource "azurerm_role_assignment" "this" {
      - id                   = "/subscriptions/1baf5470-1c3e-40d3-a6f7-74bfbce4b348/resourceGroups/core-infra-intsvc-rg/providers/Microsoft.KeyVault/vaults/cftptl-intsvc/providers/Microsoft.Authorization/roleAssignments/56afa4df-4e00-5198-5dd2-4dd78df54cf6" -> null
      - name                 = "56afa4df-4e00-5198-5dd2-4dd78df54cf6" -> null
      - principal_id         = "414c87c4-9f5a-4fcf-b630-91d1c282ace0" -> null
      - principal_type       = "ServicePrincipal" -> null
      - role_definition_id   = "/subscriptions/1baf5470-1c3e-40d3-a6f7-74bfbce4b348/providers/Microsoft.Authorization/roleDefinitions/4633458b-17de-408a-b874-0445c86b69e6" -> null
      - role_definition_name = "Key Vault Secrets User" -> null
      - scope                = "/subscriptions/1baf5470-1c3e-40d3-a6f7-74bfbce4b348/resourceGroups/core-infra-intsvc-rg/providers/Microsoft.KeyVault/vaults/cftptl-intsvc" -> null
    }

Plan: 0 to add, 0 to change, 1 to destroy.


Come up with a proper name and move to the amethyst org

We need to come up with a new name for this repo/crate.
My initial thought was Aquamarine which is another gem similar to Amethyst.
https://en.wikipedia.org/wiki/Beryl#Aquamarine_and_maxixe
I would like to hear more thoughts.

My suggestion would be laminar.
This adjective is both used in geology, describing mineral crystals that look like flat planes, and in thermodynamics where it describes a flow that is not turbulent, streamlined and fast. I think it fits perfectly the idea one would want to carry with the protocol.
adjective
1. consisting of laminae.
"The lowest part consists of the mineral neomesselite, which has a delicate laminar or platelike structure."
2. (of a flow) taking place along constant streamlines; not turbulent.
"Since air in laminar flow has a higher pressure than turbulent air, the laminar flow behind the ball creates less of a ‘sucking’ effect behind the ball which would substantially slow it down."

This has been done. Please checkout https://github.com/amethyst/laminar


⚠ Bofrost.at has degraded performance

In 302286b, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1152 ms

Resolved: Bofrost.at performance has improved in fb7cbd5.


object.class was renamed to object.type in 1.9

Hi!
Based on the docs Class property of the object is stored as type since 1.9
I renamed the field in my local build, but probably it should be read based on the map's version.

I haven't had much time to work on this lib, so I think I might just track whatever the latest stable version of Tiled does, to keep things simple.

Should be fixed by 9699ee0 .
If you have a 1.10 sample map/tileset you can add to the examples and tests, that would be much appreciated.


useQueries causes constant rerenders

Describe the bug
When using useQueries, the owning component rerenders repeatedly.
To Reproduce
Steps to reproduce the behavior:

call useQueries()
put a console log in the render method, or add a useeffect:

  const result = useQueries(...);
  useEffect(() => {
    console.log('result changed!');
  }, [result]);

Expected behavior
The component should not be rerendered constantly
Desktop (please complete the following information):

OS: MacOS
Browser:  Chrome
Version: 96

Additional context
This is due to a missing useMemo(): https://github.com/tannerlinsley/react-query/blob/master/src/react/useQueries.ts#L121
The problem is that later in that function, a useEffect fires, which updates state, which causes everything to rerender, which causes this array to be generated again.
A simple useMemo() fixes the problem. Working on a PR now

While a useMemo in this spot might make some situations better, it won't do much for many cases, because it depends on the queries that is passed into useQueries, which is rarely stable. So if you do:
useQueries([{ queryKey1, queryFn1 }, { queryKey2, queryFn2 }])

the memoization won't work because we pass a new array every time. Also, useQueries is often used with dynamic amounts of queries where a .map is involved, where it also wouldn't work, like:
useQueries(something.map(...))

Maybe you can tell me more about the effect that you want to run ?

@TkDodo yes, that is correct - but if you do use useMemo() for the input then it works beautifully.
Without this, I find that useQueries is a useless API because it just makes my tab peg the CPU. There is actually no way to use useQueries in a practical way because of this...
So to answer your question: I want to use useQueries as it is documented, to make N simultaneous queries based on a previous list of items.

Without this, I find that useQueries is a useless API because it just makes my tab peg the CPU. There is actually no way to use useQueries in a practical way because of this...

ookay. At least you'll save on heating then I guess 🤷

I want to use useQueries as it is documented, to make N simultaneous queries based on a previous list of items.

I don't how see how this correlates with useMemo. I'm not against merging the PR, I just want to understand what you are trying to achieve because I don't think that useMemo will do a lot in many situations. For example:
const queries = useQueries([query1, query2])

return queries.map(query => <Component data={query.data} />

will work pretty well even without useMemo. If Component is wrapped in React.memo, it will also not re-render needlessly, because each query.data is properly memoized and structurally shared.

const queries = useQueries([query1, query2])

return queries.map(query => <Component data={query.data} />

Right, it definitely doesn't help in this case. But at least that responsibility is on the consumer of the API to deal with. without this patch, there is no way for the consumer to actually work around this issue.
But even in the above case, I guess I'm surprised that this isn't doing constant rerenders for you then? If anything, I think the docs also need to say "the queries passed in should be memoized to avoid constant rerenders"
My use case is something like this:

    const rootObj = useQuery(...get one object);
    const objQueries = useMemo(() => rootObj.subObjs.map(subObj => makeQuery(subObj.id) ?? []), [rootObj]);
    const subObjs = useQueries(objQueries);

And that is how I benefit from this patch.

will work pretty well even without useMemo. If Component is wrapped in React.memo, it will also not re-render needlessly, because each query.data is properly memoized and structurally shared.

But it will rerender needlessly, that's the point! Look in react-devtools, do a profile on ANY consumer of useQueries There is a useEffect in the hook that runs and triggers a rerender, that dirties the tree because the result of the queries:
This is the relevant code in from the hook:
function useQueries(queries) {

  // (alecf): guaranteed new version of defaultedQueries on any render
  const defaultedQueries = queries.map(options => {
     ..
  });

 // (other code here)

  // (alecf): This useEffect is always fired because defaultedQueries changes each time.
  // It dirties the observer, which in turn causes a rerender, which triggers the map() above,
  // which then triggers this useEffect, etc.
  React.useEffect(() => {
    // Do not notify on updates because of changes in the options because
    // these changes should already be reflected in the optimistic result.
    observer.setQueries(defaultedQueries, { listeners: false })
  }, [defaultedQueries, observer])
}

But even in the above case, I guess I'm surprised that this isn't doing constant rerenders for you then? If anything, I think the docs also need to say "the queries passed in should be memoized to avoid constant rerenders"

not sure what you mean with "constant re-renders". It's not like an infinite loop of re-renders?

Your component re-renders because a parent re-renders
You get a new array from useQueries
You do something with that array, e.g. pass it down to a child component

The fact that you get a new array from useQueries is only relevant if:

the child component is memoized
you want to put the result of useQueries into the dependency array of an effect, useMemo or useCallback

Again, I think that we should do it, and I will as soon as the PR doesn't have syntax or prettier errors (which it now seems to not have, so we can go ahead). But stating that the hook is useless because it returns a new Array on every render is plain false, sorry.

This is the relevant code in from the hook:

I'm aware, I have seen the PR ;)

sorry for calling it "useless" :)
But yes, I'm seeing "constant re-renders" - not an infinite loop, but yes a re-render about every 200ms when the rest of my app is fully idle

But yes, I'm seeing "constant re-renders" - not an infinite loop, but yes a re-render about every 200ms when the rest of my app is fully idle

That sounds weird, like a different kind of bug weird. I mean if you have a big array and the promises resolve over time, there will be one re-render for each resolved promise. Also, unless you use further optimizations like tracked queries, there will be re-renders when you focus the window etc.
I'm going to merge the useMemo fix, because as you said, at least it gives the control back to the users to memoize their input if they want, but I would also appreciate it if you could spawn up a codesandbox example that shows these constant re-renders please.

:tada: This issue has been resolved in version 3.33.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

It happens when you use setState inside a useEffect that depends on the result of useQueries.
Migrating to v3.39.0 doesn't seem to fix the problem.


Rasa v1.0 missing detailed logs like previous versions

Rasa version: 1.1.3
Rasa X version (if used & relevant): N/A
Python version: 3.6.6
Operating system (windows, osx, ...): Windows 10
Issue:
After upgrading to Rasa v1.0.x, logs outputted to rasa_core.log are missing any additional output that appears in the shell/server.
Error (including full traceback):
Currently the log only ever displays:
2019-07-12 12:00:20,917 [DEBUG]  Available web server routes:
/webhooks/rest                                     GET                            custom_webhook_RestInput.health
/webhooks/rest/webhook                             POST                           custom_webhook_RestInput.receive

When before, they'd look something like this:
Rasa process starting
Added 'nlp_spacy' to component cache. Key 'nlp_spacy-en'.
Available web server routes:
static                                             GET, OPTIONS, HEAD             /static/[filename]
custom_webhook_RestInput.health                    GET, OPTIONS, HEAD             /webhooks/rest/
custom_webhook_RestInput.receive                   OPTIONS, POST                  /webhooks/rest/webhook
Rasa Core server is up and running on http://localhost:5002
Creating a new tracker for id 'test'.
Received user message 'hi' with intent '{'name': 'greet', 'confidence': 0.6400831082282148}' and entities '[]'
Logged UserUtterance - tracker now has 2 events
Current slot values:
	target: None
	target_found: None
	user: None
Current tracker state [None, {}, {'prev_action_listen': 1.0, 'intent_greet': 1.0}]
There is a memorised next action '23'
There is no active form
Predicted next action using policy_2_MemoizationPolicy
Predicted next action 'action_identify_user' with prob 1.00.
Calling action endpoint to run action 'action_identify_user'.
Action 'action_identify_user' ended with events '['SlotSet(key: user, value: test)']'
Current tracker state [{}, {'prev_action_listen': 1.0, 'intent_greet': 1.0}, {'slot_user_0': 1.0, 'prev_action_identify_user': 1.0, 'intent_greet': 1.0}]
There is no memorised next action
There is no active form
Predicted next action using policy_0_KerasPolicy
Predicted next action 'utter_greet' with prob 1.00.
Action 'utter_greet' ended with events '[]'
Bot utterance 'BotUttered(text: Hi test, data: {
  "elements": null,
  "buttons": null,
  "attachment": null
})'
Current tracker state [{'prev_action_listen': 1.0, 'intent_greet': 1.0}, {'slot_user_0': 1.0, 'prev_action_identify_user': 1.0, 'intent_greet': 1.0}, {'prev_utter_greet': 1.0, 'slot_user_0': 1.0, 'intent_greet': 1.0}]
There is no memorised next action
There is no active form

Command or request that led to error:
I currently start the server as so,
rasa run -m models --endpoints endpoints.yml --port 5002 --credentials credentials.yml --debug

rasa_core.log gets generated by default, but as mentioned above, only contains a few lines of the server starting and nothing else.

Thanks for raising this issue, @federicotdn  will get back to you about it soon.

Hey @sihsob, thanks for the detailed report. I have been able to reproduce the problem and will try to see what's causing it.


Add a new command to create the default application skeleton

... something like api2html create-project
it should create the default skeleton with some sample content

fixed at #22


How does the 0-os client refresh the jwt token?

https://github.com/threefoldtech/jumpscaleX/blob/01d69d352c1577cd24f369cf268b9cd47606d723/Jumpscale/clients/zero_os_protocol/Client.py#L70-L80
According to this comment, the refresh of the jwt token used to connect to a node is now done in the ItsYouOline client ? While I don't see any relation between the 0-OS client and IYO client? So how does the refreshing can happen ?
With the code as it is now, the JWT needs to be refreshed manually ? This means we cannot use the client in any long running program ?

So it turns out commenting this code was a mistake. I'll adapt the code of IYO client and re-add the code it.

fixed: https://github.com/threefoldtech/jumpscaleX/commit/a7992ad4675dbb565e6f9b1f777eaaf6910ee413#diff-354f4ca39eea30b89d980fed3fbc4c32R81


projects/:scope is deprecated on API v4 and scopes are now set on query parameters

Hi there 👋
I was making calls to get a list of projects owned by the authenticated user, but I was getting a 404 error following the example from the gem docs:
client = Gitlab.client(endpoint: "https://gitlab.com/api/v4", private_token: access_token)
projects = lab.projects({scope: "owned"})

I looked into the Gitlab API v4 docs and saw that projects/:scope was replaced by owned, membership and starred query parameters.
Indeed, the following query worked for me:
projects = lab.projects({owned: true})

So, I think the IF clause that checks if there is a scope property can be removed from the projects method:
https://github.com/NARKOZ/gitlab/blob/b543f256c54be60a228346ba9f9932b62ffb6eba/lib/gitlab/client/projects.rb#L15-L21
And the docs can be updated to mention to use the new query parameters instead of the scope
https://github.com/NARKOZ/gitlab/blob/b543f256c54be60a228346ba9f9932b62ffb6eba/lib/gitlab/client/projects.rb#L13
If you agree with that I can submit a PR :)

PR is welcome.


Create helm chart for rustus.

It would be really cool to have a simple helm chart for rustus.

Chart created in #62.


Fix packing doc in SFTConfig and fix error when neither dataset_text_field nor formatting_func is provided.

What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a GitHub issue? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Can you review @RylanSchaeffer?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Change the "ng" prefix to something else

'ng' is reserved for official angular components. I stumbled upon this assuming it is from angular team. While I still would use it, I would like it to have some other prefix and not 'ng'

my suggestion would be awesome-range-slider or ar-slider (ar - awesome range)

I like @kanagukrs your suggestions, I will do it soon, it sounds great and awesome ;)

It would be fine if you change the directive name from slider to angular-awesome-slider, right now, you only changed the module and file names

ok, I hesitate as it was a bit long name, I will do


FancyZones causes Chrome and Edge tabs to disappear when dragged between windows

ℹ Computer information

PowerToys version: 0.31.2
PowerToy Utility: FancyZones
Running PowerToys as Admin: No
Windows build number: 20H2 19042.804

📝 Provide detailed reproduction steps (if any)

Configure FancyZones
Open a second window of Google Chrome or Microsoft Edge and size it to a FancyZone. In my case I had my main browser window on the right of monitor 1 using a FancyZone and browser window 2 was on the left of monitor 2 in another FancyZone.
Drag the Chrome tab from the 2nd window to below the address bar of browser window 1 and then up across the omnibar
Watch it close. This does not happen if you do not cross the omnibar. It also does not happen when PowerToys is not running or when browser window 2 is not filling a FancyZone.

✔ Expected result
Chrome Tab should combine to the main window
❌ Actual result
The Chrome tab dies unexpectedly and does not appear in the recently closed tabs listing. One must either remember how to get there or go back through one's Chrome history to the point of last url change on the tab.
📷 Screenshots

One could make an argument that this is a Chromium bug but I think the fact that it does not happen when PowerToys is not running means that PowerToys is somehow interfering with the tab feature of that family of browsers.
https://bugs.chromium.org/p/chromium/issues/detail?id=1178512

The main reason I run into this issue is that Windows makes it difficult to move the mouse between displays near the top of the screen so to avoid that I drag windows down and then back up which results in this bug. In additional testing with Google Chrome, Chrome Canary and Microsoft Edge I ended up with several windows and tabs where the UI was completed broken including the window's minimize, maximize and close buttons. I think this highlights that there is an incompatibility in the way FancyZones and the Chromium based tab dragging processes interact. It only happens when FancyZones is running and can break the Windows interface for users so it should be addressed at least somewhat from PowerToys side. I have linked an issue from chromium as well so they should be aware of the issue.

@pcnate
do you press shift while dragging the tab?

@enricogior no I do not

I can reproduce this constantly. It's annoying. What's also annoying is @msftbot trying to close this issue. :-P

The undesirable behavior is still there but seems to have become more annoying in July. Browser windows have become completely unresponsive

@raymo111 today I tested this with Chrome 94.0.4606.61, Edge 94.0.992.31 and PowerToys 0.45.0. Anyone else able to confirm?

@Raymo111 today I tested this with Chrome 94.0.4606.61, Edge 94.0.992.31 and PowerToys 0.45.0. Couldn't get it to crash in the same way. Anyone else able to confirm?

Unfortunately too many things were breaking for me on Windows (Office and Outlook refuse to start without crashing) and I moved back to Arch Linux. I can check the next time I use Windows for sure, but in the meantime I won't be able to help. Sorry!

@pcnate I have not experienced this lately with Chrome 94.0.4606.61 and v0.45.0. Just updated to v0.47.0 today, hopping it stays that way.

As far as I am concerned this issue is no longer present. If anyone has a different experience I suggest opening a new issue and linking to this one.

It seems the issue is back and worse.
This seems to have started happening after updating to powertoys 0.49.0. I am going to install 0.49.1 to see if the behavior continues.
I have had it crash the Chrome UI and it leaves the window open but no longer able to close, minimize etc. Chrome does not remember the tab in the history or otherwise. It is just lost.

Subscribed.
I have the same issue. My tab will either disappear entirely or go completely white/black.

cc: @SeraphimaZ FYI

Subscribed.
I have the same issue. My tab will either disappear entirely or go completely white/black.

@mcdssn @pcnate
Can you please attach a bug report and write the browser version?
Right-click on the tray icon and click Report Bug. Then drag-and-drop the generated file into the GitHub comment to upload it. Thanks!

PowerToysReport_2021-12-16-13-44-02.zip

Related to https://github.com/microsoft/PowerToys/issues/13911

Related to #13911

Interesting. Now that I see that issue I recall that my browser is almost always snapped to a zone.

Workaround: Disabling "Move newly created windows into last known zone" (translated from german) fixes the issue.

Workaround: Disabling "Move newly created windows into last known zone" (translated from german) fixed the issue for me. (v0.56.2) Correction it just happen much less frequently ;)

workaround that works always: first drag the tab(s) to a new windows without assiging it to a zone, then drag to target window

I too have this exact issue and can reproduce 100% of the time. Using Edge 100.0.1185.39, PowerToys 0.57.2, and Windows 10 Pro 20H2.

same issue here. Chrome 103.0.5060.134 (Official Build) (64-bit), PowerToys v0.60.1 @ Windows 11 22H2 25169.1000

Hi everyone. I think I've localized the problem. If you're able, please do a quick test. Disable the Restore the original size of windows when unsnapping option and try to reproduce the problem. Let me know if the problem is gone when you disable the option. It'll show if my research is correct.
/needinfo

Hi everyone. I think I've localized the problem. If you're able, please do a quick test. Disable the Restore the original size of windows when unsnapping option and try to reproduce the problem. Let me know if the problem is gone when you disable the option. It'll show if my research is correct. /needinfo

Disabling Restore the original size of windows when unsnapping seems ot be a viable workaround. I cannor reproduce the problem with this option being disabled.
Thanks!

Hi everyone. I think I've localized the problem. If you're able, please do a quick test. Disable the Restore the original size of windows when unsnapping option and try to reproduce the problem. Let me know if the problem is gone when you disable the option. It'll show if my research is correct. /needinfo

Confirmed. I tried turning it back on and then the problem hasn't happened since. Even tried restarting PowerToys and Chrome separately but it doesn't happen. The only thing left to test is logout/reboot???

Thank you for help!
So, it's confirmed that restoring size leads to this problem, we need to skip it for browser tabs dragged between windows.

The only thing left to test is logout/reboot???

No need for that :) Thank you!

Can confirm this is happening on v0.61.1 version and Windows 10 21H2.
Because the tabs are not closed, you can't restore them. They just vanish into void

I've been experiencing this issue intermittently. I'm currently trying to figure out how to recreate the issue.
My current hypothesis is that it has something to do with the Window Behavior settings. More specifically, the "Restore the original size of the windows when unsnapping." Can anyone experiencing this issue confirm that they have this ticked?

What helped (if I remember correctly) was to disable "Move newly created windows to the current active monitor (Experimental)". Who would have thought that experimental features have bugs :)

So this is happening because of FancyZones?
Omg, I was so angry so many times...
This issue is here for 1,5 year and no one cares?

well, it's clearly labeled as an experimental feature and chromium tab windows are pretty unique and have weird bugs with a lot of these kind of apps, so...
Just disable "Move newly created windows to the current active monitor (Experimental)" option and you're good.

@biiiipy but i've never enabled that and I just checked and it is disabled as I expected
i just turned off all other things in there, so let's see, maybe it will help

It's 2023 and I can confirm this is still occurring with Chrome 120.0.6099.109 (Official Build) (64-bit) (cohort: M120 Rollout)
I'll enable the workaround but oof
Worst part is the tabs aren't even recoverable using Ctrl Shift T (or even Chrome History!?)

Can also confirm this is still an issue.

Still an issue almost 3 years later on Windows 11 with Chrome. 🤷♂


Can't connect in Xamarin.Forms Android

I'm trying to connect to Azure SignalR Service from a Xamarin.Forms app that targets only Android for now. I use an Azure Function with SignalR binding (negotiate) to retrieve the correct url and token. The fuction returns the correct data with a status 200.
But then during hubconnection.StartAsync() i always receive this error:
"Unable to connect to the server with any of the available transports"
I use Microsoft.AspNetCore.SignalR.Client version 1.1.0 (preview 3 doesn't work for other reasons... :-( )
The connection is built in this way:
hubConnection = new HubConnectionBuilder().WithUrl("myurl").Build();
where "myurl" is the address to reach the negotiate function

where "myurl" is the address to reach the negotiate function

"myurl" should be the Url in the body of negotiate response rather than the address of the negotiate function

"myurl" should be the hub url.
For example, if your negotiate function's address is https://abc.def/hub/negotiate , "myurl" should be https://abc.def/hub

not the hub url (the hub url is already known using the azure signalr binding and it is specified in a function app settings (local.settings.json if you test in local)). As you said this must be the url where you can find the negotiate function...and it is
https://docs.microsoft.com/it-it/azure/azure-functions/functions-bindings-signalr-service

What I mean is https://docs.microsoft.com/en-us/azure/azure-signalr/signalr-concept-serverless-development-config#configuring-a-client-connection . But it is great if you are sure you know the way to connect signalr service.
Could you tell me :

the speed of connecting - how many signalr clients is trying to establish connections to signalr service?
total connections and the duration when the error occured?

Could email me your azure subscription and signalr service instance name? I would check the log first.

I investigated the problem more in depth and it seems related to the System.IO.Pipelines package.
If I reference only the Microsoft.AspNetCore.SignalR.Client package then I have this error:

Could not load type of field 'Microsoft.AspNetCore.Http.Connections.Client.HttpConnection:_transport' (11) due to: Could not load file or assembly 'System.IO.Pipelines, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies.

If I try to install directly the last version of System.IO.Pipelines nuget package then I have the previous error:

Unable to connect to the server with any of the available transports

As already said this happens only for Android, iOS works great.
I'll send you an email with the requested info, thank you!

the other strange thing is that System.IO.Pipelines seems to start from version 4.5.0 in nuget...

Hi @andrekiba  I didn't receive your email, and if I only referenced Microsoft.AspNetCore.SignalR.Client for version 1.1.0, but I couldn't reproduce the error. All things works well in my Xamarin.Forms Android app. Could you provide app server log and more information like your azure signalr service name?

Did you installed the System.IO.Pipelines package here? The latest is 4.5.3 since 4 months ago.

Mail sent few minutes ago, sorry for the delay.
Yes I tried to install System.IO.Pipelines 4.5.3 but it doesn't work.

Got it. Thanks. I cannot see any connection in your azure signalr service in May. Could you double check that you provide the correct signalr service resource name?

Closing this as we haven't heard from you and generally close issues with no response after ~7 days. Please feel free to comment if you're able to get the information we're looking for and we can reopen the issue to investigate further!


Mint and Token Confusion

The way the queries and tables were created is causing confusion in what they do.
E.g, When using Hasura I can see that there's a table called "Mint" which shows all the tokens that have been minted. Can we please have this exposed to GraphQL? As far as I can see, there isn't a reliable way of retrieving all the minted tokens with the correct quantities while using the "token" interface/table. E.g, you can do a distinct, but you can't order it by includedAt, so any selected "distinct" isn't guaranteed to be the minted transaction. Exposing "Mint" would solve this.
GraphQL has the "tokens" table exposed however this isn't a unique set of tokens and is actually all the transactions that have happened against a token. I feel like it would be more appropriate to call it token_transactions and token_transactions_aggregate.

Yes you're right @CyberCyclone , the mint table is a closer match for resolving a query called tokens.

I feel like it would be more appropriate to call it token_transactions and token_transactions_aggregate.

Given the current results are only relevant in the context of transactions, I'll just change the SQL queries to resolve from mint instead as we only really care about the minting and or burning of tokens in this context.

The approach in the release of 4.0.0 works a lot better now. Thanks!


Kontena stack has no stop command

The kontena stack command has start and deploy etc. similar to kontena service, but it lacks the stop command. Looks like it was an oversight during #864?
kontena stack --help
Usage:
    kontena stack [OPTIONS] SUBCOMMAND [ARG] ...

Parameters:
    SUBCOMMAND                    subcommand
    [ARG] ...                     subcommand arguments

Subcommands:
    install                       Install a stack to a grid
    ls, list                      List installed stacks in a grid
    remove, rm                    Remove a deployed stack from a grid
    show                          Show details about a stack in a grid
    upgrade                       Upgrade a stack in a grid
    start, deploy                 Deploy an installed stack in a grid
    logs                          Show logs from services in a stack
    monitor                       Monitor services in a stack
    build                         Build images listed in a stack file and push them to an image registry
    reg, registry                 Stack registry related commands

Options:
    -h, --help                    print help

only lists rm as possible command to "stop" a stack, but sometimes you only want to stop it and not get rid of it completely.

fixed in #2299


Allow adding rel attributes for elements with anchors.

Merging this pull-request adds the possibility to use the rel attribute to indicate the link relationship.
List of components allowing the rel attribute:

mjml-button
mjml-image
miml-carousel-image
mjml-location
miml-navbar
mjml-social

Hey @JoshuaLuckers
First of all, thanks for this PR ! Can you explain me how rel attributes are important within an email ?

Thanks for your comment. I think the rel attribute is important because:

It specifies the relationship between the two documents.
It's semantically correct.
Can be used to style a link based on its rel attribute.


Loading a dataframe from a pickle does not print the shape which could be useful

False alarm, it did create logs but it wasn't very visible
I changed a bit the logging so it is clearer


Fix periodic sessions and document behavior

i'm still unconvinced that it's better to err on the side of longer sessions. i'd prefer to keep it short:

it's only ever the first session so security shouldn't be an issue regarding "erring on longer sessions";
it preserves the invariant block_index_into_current_session < session_length. this could be extremely important for any logic that for whatever reason needs to index data by block into session. buffers for statistics collection would be one thing i can think of here.

@rphmeier ^^^ ?

@gavofyork could be a follow-up. right now this PR is fixing broken code

@rphmeier I added the required changes as suggestions, if you're not opposed in principle.

@gavofyork needs a docs change too


Internal server error when try to upload

Hello! I get this terminal error when I try to upload a jpg image:
error: Error uploading to Bunny.net: Request failed with status code 401
at /projectfolder/node_modules/strapi-provider-upload-bunnynet/lib/index.js:34:18
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Ive configured plugin and middleware files with the password, storage name and pullzone url without last slash. On localhost or production I get that 401 error on my terminal, and the 500 error on my chrome console. (Im using typescript).
Should I configure something else?
Thank you :)

Hello!
401 means "Unauthorized". Can you please show me the full API call including host, headers and body. Make sure to hide any keys/secrets.
/N

Hello!
401 means "Unauthorized". Can you please show me the full API call including host, headers and body. Make sure to hide any keys/secrets.
/N

Hello @thor9n :)
Thank you! Im using this config at plugins.ts:
module.exports = ({ env }) => ({   upload: {     config: {       provider: "strapi-provider-upload-bunnynet",       providerOptions: {         api_key: env('BUNNY_API_KEY'),         storage_zone: env('BUNNY_STORAGE_ZONE'),         pull_zone: env('BUNNY_PULL_ZONE'),       },     },   }, })
env variables:
`
BUNNY_API_KEY=PASSWORD(not the Read-only password)
BUNNY_STORAGE_ZONE=zonenameonly
BUNNY_PULL_ZONE=https://mypull.b-cdn.net
`
And in middleware.ts:
  'strapi::errors',   {     name: "strapi::security",     config: {       contentSecurityPolicy: {         useDefaults: true,         directives: {           "connect-src": ["'self'", "https:"],           "img-src": ["'self'", "data:", "blob:", "https://mypull.b-cdn.net"],           "media-src": ["'self'", "data:", "blob:", "https://mypull.b-cdn.net"],           upgradeInsecureRequests: null,         },       },     },   },
Should I configure something else?

The error indicates it's an authorization error so I thought it was the API_KEY that was wrong – can you please double check it's loaded correctly.
Not in the office now, but 'll double check everything tomorrow morning and get back.

I'm pretty sure that I copy and paste the password inside ftp/api section (not the token auth). Also I cant test it inside the api reference example tester :/ I get   "Message": "Authorization has been denied for this request."

@thor9n well I've chat with support and they've told me I have to use "ny.storage..." bc my server is in US (NY).
I also tried on Insomnia using the url https://ny.storage.bunnycdn.com/storagename/path/ and worked fine :)
How can we reach to this?
Thank you!

Great – sounds like you solved it?

How can we reach to this?

Not sure what you mean by this.

Hello

I had to modify that url bc it is not always https://storage.bunnycdn... maybe all that url could be a param to get from env var.

Thanks for catching that @santyas
I've added a new branch storage-endpoint-env-var which adds BUNNY_STORAGE_ENDPOINT as a environment variable.
Would you mind cloning, testing and confirm it's working as expected?
Cheers!

@thor9n oh thank you so much! Sorry but How can I test it? I added this provider to my project using yarn, but I think it install the main's branch code.


Added ability to defer setting of default values to Pydantic model in…

…stead of setting it directly.

New argument defer_set_default will not set a default value from click but instead allow the Pydantic model to set it. By doing this, something like BaseSettings can use the precedence order as expected because defaults are the lowest precedence but if passed into the init (via something like model_validate) the precedence order is ignored because the value is set.

m Modified _parse_options in pydanclic.model.validation leave values of None unset.
This makes using something like BaseSettings possible from pydantic-settings because if the argument exists in kwargs but is None, the precedence order will be ignored and thus environment variables will go unchecked.

I want to make sure I didn't miss steps/code changes that are blocking the ability to review.
There is no rush on this but I just wanted to verify I am didn't miss anything.


[Bug]: no determination appears for new Collection Object until after refresh

Steps to reproduce the bug
Working with @tmcelrath in INHS Ent Collection testing

1.After adding a taxon name, Add Collection Object
2.The Determination is selected, but doesn't appear in the display header as expected until after refresh.
...

Screenshot

Expected behavior
Expecting the determination to show up in the display without using "refresh" method. @tmcelrath can add more information about expected behavior if you need more information @jlpereira
Additional Screenshots
No response
Environment

[ ] Development (native)
[ ] Development (docker)
[ ] Sandbox
[X] Production

Sandbox Used
No response
Version
INHS ENT Collection
Browser Used
firefox

@debpaul you must save the record first.

@mjy I think we did? Will re-test.

We did save. Does not show up until either a second save or a refresh.

I can't replicate it. Please provide more detailed steps

Specifically at the top of the page. Steps:

I go to comprehensive
I add a determination (with OTU, collector, year, or any combo)
I save.
The determination does not show up at top of page until I save twice or I refresh page.

I can't replicate it.  It could be a unique case. Maybe something didn't save properly and the form didn't fill out correctly. Can you provide a link with an example case?

Happens everytime I do this: Replicated just now:

I refresh and it turns to this:

Same with using save once, then twice.

Thanks, I see now.
This happens because we save first the collection object and then the determations. I will see if I can compose the label from the client side


spec feedback from @bakkot

This incorporates the stage3 feedback from @bakkot, from https://github.com/tc39/ecma262/pull/3094, where their individual comments there are resolved per the changes here.

Have integrated these changes into the upstream PR here:

https://github.com/tc39/ecma262/pull/3094/commits/c0e32473127b7e869501fba5ff8ec7b0e1d7db73
https://github.com/tc39/ecma262/pull/3094/commits/78c0396e09969787722988114f320e3bc0d6d3b1
https://github.com/tc39/ecma262/pull/3094/commits/56b73385fe32f2e0d5b7ed3cbfb7f3d32fc045a5
https://github.com/tc39/ecma262/pull/3094/commits/50ddac9466d6704a06f50f95fc7d65546bcbdd84

I propose we stop updating this spec file, un-publish it and instead link to the PR. Maintaining both side by side will be painful. We're now at the stage of editor reviews, and doing that on the PR will be easier than on the repo.

Every completed proposal still has its rendered spec text up; I think it's pretty important for future archival purposes.

Sure we can leave it up (and add a link to the readme). But the proposal text won't be updated anymore. I don't think anyone backports PR changes to the separate specs

Prior to stage 4, that's what's typically done.


chore: cds 8 upgrade

Errors in Java test
com.sap.cds.CdsException: CDS Compiler version 5 is not supported. Please use cds-dk 7 w/ cds-compiler 4

@agoerler : do we have to simultaneously upgrade also Java?

@agoerler : do we have to simultaneously upgrade Java RT?

Sure. But it has not been released yet.


Add Sample Test to convert media file in hls format in different Resolution

@bramp
+Add
-> HLS Encoding Sample added
Impact:
-> Help to Understand how to use ffmped wrapper to convert media file into hls format file with different resolution.

@harrymaurya05 Could you please take a look at #322? This sample is much more complicated than others, and the additions made in that PR would make HLS much more approachable.

sure thanks

I think #322 implements most hls options you're using, apart from master_pl_name.
If we'd add that option, we could update this PR to use the new output type and use it as an example.


Refactor form component

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/25397
PROPOSAL: https://github.com/Expensify/App/issues/25397#issuecomment-1693410416
Tests

Login to the account
Navigate to Settings > Profile > Display name
Edit name/surname, check if illegal characters like ; causes errors
There are no error, ensure if you can update name
Check if name was changed

[x] Verify that no errors appear in the JS console

Offline tests

Ensure you're already logged into the account
Navigate to Settings > Profile > Display name
Edit name/surname, check if illegal characters like ; causes errors
There are no error, ensure if you can update name
Check if name was changed

QA Steps

Login to the account
Navigate to Settings > Profile > Display name
Edit name/surname, check if illegal characters like ; causes errors
There are no error, ensure if you can update name
Check if name was changed

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/91068263/c139ea24-2d44-4223-a453-1cab88ae95c1

Mobile Web - Chrome
https://github.com/Expensify/App/assets/91068263/7b16221d-3fea-44f7-838f-731cb90e6b84

Mobile Web - Safari
https://github.com/Expensify/App/assets/91068263/b2b5968d-09cf-4c5a-a5e7-eb1df7c1b4a6

Desktop
https://github.com/Expensify/App/assets/91068263/ae45a462-c06f-40e2-ad92-9f1b759267fa

iOS
https://github.com/Expensify/App/assets/91068263/f03abdc9-316a-439f-b194-b819164ef1bf

Android
https://github.com/Expensify/App/assets/91068263/cedb086e-f044-49af-9344-df3539005245

@thesahindia could you please check the PR as well?

@kowczarz did you get a chance to check this comment? https://github.com/Expensify/App/pull/27025#issuecomment-1721862536

@luacmartins I've already addressed it.

Nice! Bump @thesahindia for review!

@thesahindia didn't spot it, but fixed already.

@luacmartins @thesahindia FIY: from Monday I will be OOO for a week, so if we won't finish today we will need to wait one more week.

@kowczarz did you get a chance to look at the console error @thesahindia pointed out here

Tested well! But it looks like we still have one console error.

@thesahindia that's not connecteed with my PR. The root of the problem is in our fork of react-native-web library https://github.com/Expensify/react-native-web/blob/master/packages/react-native-web/src/exports/render/index.js#L46C18-L46C18

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.74-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


[WIP] Chainparameter, port, checkpoint and genesis block setup for four networks.

Sets up new consensus parameters, ports, magic numbers, prefixes and new genesis blocks for mainnet, testnet, devnet and regtest.

@sapphire-pt this code will give assertion on genesis block transaction and spork key unless some codes aren't commented until it syncs blockchain from a peer. I had setup 2 testnet seed servers and will setup the nodes ASAP. There will be 4 blocks in mainnet (which we will clear them from all nodes and make mining start from block one) and 6+ blocks in testnet (I may mine some blocks on testnet until you compile and run this branch).
I will also document the codes that should be commented in case you need to create a new genesis block and mine the blocks alone.

There will be 4 blocks in mainnet
I had to mine these for the genesis block assertion crashes go away.

Good job.
Can we create a method used with a command-line argument to mine a genesis block outputs it and another one to generate a spork key-pair and outputs it? after that, exit.
It will be useful to launch the mainnet on the D-day and create testnet's when we need it, instead of commenting code on and off, which is very cumbersome.
It will be also useful for HELIO.

Good job.
Can we create a method used with a command-line argument to mine a genesis block outputs it and another one to generate a spork key-pair and outputs it? after that, exit.
It will be useful to launch the mainnet on the D-day and create testnet's when we need it, instead of commenting code on and off, which is very cumbersome.
It will be also useful for HELIO.

Very good idea. I will look into it.


refactor(types): Move Name and TreeState to types.tsx

move Name, TreeState type to types.tsx to seperate type from module

LGTM.
Will be merged soon.


Building wheel for Yahoo-ticker-downloader failed

Is it a problem if building wheel fails during the download process? I haven't had a problem loading the downloaded stocks.pickle file using python, so I'm just wondering if there's any need for me to reinstall the package. This is the error that I get during the pip install process on a Mac OSX El Capitan:
Building wheels for collected packages: Yahoo-ticker-downloader
  Building wheel for Yahoo-ticker-downloader failed: [Errno 13] Permission denied: '/Users/Yuqi/Library/Caches/pip/wheels/bd'

It is not possible for me to debug on Max OSX. Can someone else step in and debug this problem for me?

Hi,
Something similar is happening to me on windows
Failed building wheel for reppy. Then I get
cl : Command line warning D9002 : ignoring unknown option '-std=c++11'     agent.cpp     C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.14.26428\include\crtdefs.h(10): fatal error C1083: Cannot open include file: 'corecrt.h': No such file or directory     error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.14.26428\\bin\\HostX86\\x64\\cl.exe' failed with exit status 2
It worked on mac for me. Seems to be something related with reppy and Visual Studio but don't manage to know what


[#75] Automates the dumping of SQL scripts from our production database

[#75]

[x] Automates the dumping of SQL scripts from our production database

The included script has been included in a daily cron job.

wait for #105 merge before merging this. reduce risk of anything bad

#105 doesn't touch our DB though, so it should be totally unrelated.

ok go ahead then


ISSUE #52 Fixed issue with bluetooth instructions

Changed the enclosure port from /dev/ttyAMA0 to /dev/ttyAMA1. AMA0 is required for bluetooth, AMA1 can be used as the general purpose serial port.

It seems there may some changeable settings which could alter which one works. May need to rewrite that part of the directions to include some of the options listed here: https://www.raspberrypi.org/documentation/configuration/uart.md

I've resolved this for now by changing the wording to;

First, we need to enable Bluetooth.

Edit the /etc/mycroft/mycroft.conf file
Add "port": "/dev/ttyAMA0" to the enclosure settings. You may need to use "port": "/dev/ttyAMA1" or "port": "/dev/ttyAMA2" - the port can vary depending on the Picroft and Raspbian build.


Do we need the bumpversion workflow?

The bumpversion  workflow runs poetry bumpversion upon mege to main.
That seems too often, usually on bumps once per release only, and there are typically more locations to update (docs, readme) than just the package version attribute.
Not sure what the intended workflow is here, I have not seen this before - explanations would be appreciated, @astrogilda.

... and it keeps failing:

I've temporarily removed the trigger, due to the CI element always failing.
We can re-enable it, of course it needs to run for that.


fix: back to flutter 3.0.5

What

Reverted the upgrade to flutter 3.0.5

Part of

https://github.com/openfoodfacts/smooth-app/issues/2919

Thank you @g123k!
@M123-dev Now we need the CI to downgrade to flutter 3.0.5 if we want the tests to pass.

Heyy @monsieurtanuki I took the liberty to just commit the CI & CD fixes to this PR, I hope this isn't a problem.
+ I added a disclaimer to the README

Codecov Report

Merging #2923 (d4d3cd3) into develop (d9c35d7) will increase coverage by 0.17%.
The diff coverage is 0.00%.

:exclamation: Current head d4d3cd3 differs from pull request most recent head 84a0051. Consider uploading reports for the commit 84a0051 to get more accurate results

@@            Coverage Diff             @@
##           develop   #2923      +/-   ##
==========================================
+ Coverage     6.71%   6.88%   +0.17%
==========================================
  Files          228     229       +1
  Lines        11117   11138      +21
==========================================
+ Hits           746     767      +21
  Misses       10371   10371

Impacted Files
Coverage Δ

...h_app/lib/cache/files/file_cache_manager_impl.dart
94.59% <ø> (ø)

...pp/lib/pages/onboarding/onboarding_bottom_bar.dart
0.00% <0.00%> (ø)

...h_app/lib/pages/product/edit_ingredients_page.dart
0.00% <ø> (ø)

...smooth_app/lib/pages/product/new_product_page.dart
0.00% <0.00%> (ø)

...h_app/lib/pages/product/nutrition_page_loaded.dart
0.00% <ø> (ø)

...mooth_app/lib/pages/product/simple_input_page.dart
0.00% <0.00%> (ø)

...h_app/lib/pages/scan/camera_image_full_getter.dart
0.00% <ø> (ø)

...ib/generic_lib/dialogs/smooth_category_picker.dart
86.77% <0.00%> (-0.37%)
:arrow_down:

packages/smooth_app/lib/database/dao_int.dart
0.00% <0.00%> (ø)

packages/smooth_app/lib/database/dao_string.dart
0.00% <0.00%> (ø)

... and 38 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks @M123-dev @monsieurtanuki @g123k


select doesn't work on touch screen laptop

Hi guys,
I just came across this bug where the select doesn't work in the touch screen PC, using mouse.
I was debugging the code and found out:
select.js line:1378
touchDevice = 'ontouchstart' in document.documentElement;
clickEvent = touchDevice ? 'touchstart' : 'click';
If its touch screen, it registers clickEvent with "touchstart", and ignores the mouse click event.
Cheers

For this reason it is strongly advised against testing touch support. Even when no touchscreen is connected, devices sometimes do support optional touchscreens and browsers tests return true.
I wrote a small plugin that does not test browser support, but keeps track of event cycles. This way we can ask the plugin on mouse events like click and mouseleave if the event was fired by touch or mouse. See for more information http://stackoverflow.com/a/26145343/328272

:+1:. From 2013 but as far as I know is still accurate: http://www.stucox.com/blog/you-cant-detect-a-touchscreen/


upstream connect error or disconnect/reset before headers. reset reason: local reset

I have installed istio 1.7.0 in gke environment through IstioOperator and deployed bookinfo application when i tried to access the bookinfo application using  istio-ingressgateway external-ip - i am getting the following error
GET /productpage HTTP/1.1" 503 LR "-" "-" 0 84 10001 - "IP" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.82 Safari/537.36" "d99c7ea4-f9e6-4697-bf48-2678df6616cb" "EXTERNAL_IP" "IP:9080" outbound|9080||productpage.do-bookinfo-phani.svc.cluster.local - IP:8080 IP:57846 - -
I don't see any logs on productpage istio-proxy  - however i can access the productpage service from ratings, details ,etc.. but not vice versa -  not able to access rating, detatils, etc.. services from productpage as shown below
#kubectl exec -it productpage-v1-6f9df695b7-bspbb -c istio-proxy -n do-bookinfo-phani  -- bash
istio-proxy@productpage-v1-6f9df695b7-bspbb:/$ curl -v -I ratings:9080

Rebuilt URL to: ratings:9080/
Trying ip...
TCP_NODELAY set
Connected to ratings (ip) port 9080 (#0)

HEAD / HTTP/1.1
Host: ratings:9080
User-Agent: curl/7.58.0
Accept: /

< HTTP/1.1 503 Service Unavailable
HTTP/1.1 503 Service Unavailable
< content-length: 95
content-length: 95
< content-type: text/plain
content-type: text/plain
< date: Mon, 08 Mar 2021 10:43:10 GMT
date: Mon, 08 Mar 2021 10:43:10 GMT
< server: istio-envoy
server: istio-envoy
< x-envoy-decorator-operation: ratings.do-bookinfo-phani.svc.cluster.local:9080/*
x-envoy-decorator-operation: ratings.do-bookinfo-phani.svc.cluster.local:9080/*
<

Connection #0 to host ratings left intact

Below error is showing in rating istio-proxy.
[2021-03-08T10:34:34.267Z] "HEAD / HTTP/1.1" 503 UC "-" "-" 0 0 120097 - "-" "curl/7.58.0" "dc67f769-30e2-4ac7-b0ae-c747989c2211" "ratings:9080" "<IP_ADDRESS>:9080" inbound|9080|http|ratings.do-bookinfo-phani.svc.cluster.local <IP_ADDRESS>:53328 <IP_ADDRESS>:9080 <IP_ADDRESS>:34288 - default

NAME                                                   CDS        LDS        EDS        RDS          ISTIOD                   VERSION
details-v1-5f449bdbb9-j47l9.do-bookinfo-phani          SYNCED     SYNCED     SYNCED     SYNCED       istiod-7bf95f9-75sbz     1.7.0
istio-egressgateway-6bb8b89cb4-fp8n2.istio-system      SYNCED     SYNCED     SYNCED     NOT SENT     istiod-7bf95f9-75sbz     1.7.0
istio-ingressgateway-6fbf7884dc-zp5rg.istio-system     SYNCED     SYNCED     SYNCED     SYNCED       istiod-7bf95f9-75sbz     1.7.0
productpage-v1-6f9df695b7-bspbb.do-bookinfo-phani      SYNCED     SYNCED     SYNCED     SYNCED       istiod-7bf95f9-75sbz     1.7.0
ratings-v1-857bb87c57-f26pm.do-bookinfo-phani          SYNCED     SYNCED     SYNCED     SYNCED       istiod-7bf95f9-75sbz     1.7.0
reviews-v1-68f9c47f69-qc8pj.do-bookinfo-phani          SYNCED     SYNCED     SYNCED     SYNCED       istiod-7bf95f9-75sbz     1.7.0
reviews-v2-5d56c488f5-tf69q.do-bookinfo-phani          SYNCED     SYNCED     SYNCED     SYNCED       istiod-7bf95f9-75sbz     1.7.0
reviews-v3-869ff44845-vwh6c.do-bookinfo-phani          SYNCED     SYNCED     SYNCED     SYNCED       istiod-7bf95f9-75sbz     1.7.0

<IP_ADDRESS>:9080                   HEALTHY     OK                inbound|9080|http|productpage.do-bookinfo-phani.svc.cluster.local
ip:9080                 HEALTHY     OK                outbound|9080||ratings.do-bookinfo-phani.svc.cluster.local
ip:9080                 HEALTHY     OK                outbound|9080||details.do-bookinfo-phani.svc.cluster.local
ip:9080                 HEALTHY     OK                outbound|9080||reviews.do-bookinfo-phani.svc.cluster.local
ip:9080                  HEALTHY     OK                outbound|9080||reviews.do-bookinfo-phani.svc.cluster.local
ip:9080                  HEALTHY     OK                outbound|9080||productpage.do-bookinfo-phani.svc.cluster.local
ip:9080                  HEALTHY     OK                outbound|9080||reviews.do-bookinfo-phani.svc.cluster.local

#istioctl proxy-config cluster -n istio-system istio-ingressgateway-6fbf7884dc-zp5rg | grep bookinfo
details.do-bookinfo-phani.svc.cluster.local                                                                  9080      -          outbound      EDS
outbound_.9080_..details.do-bookinfo-phani.svc.cluster.local                                                -         -          -             EDS
outbound.9080_..productpage.do-bookinfo-phani.svc.cluster.local                                            -         -          -             EDS
outbound.9080_..ratings.do-bookinfo-phani.svc.cluster.local                                                -         -          -             EDS
outbound.9080_._.reviews.do-bookinfo-phani.svc.cluster.local                                                -         -          -             EDS
productpage.do-bookinfo-phani.svc.cluster.local                                                              9080      -          outbound      EDS
ratings.do-bookinfo-phani.svc.cluster.local                                                                  9080      -          outbound      EDS
reviews.do-bookinfo-phani.svc.cluster.local                                                                  9080      -          outbound      EDS

#istioctl x describe pod productpage-v1-6f9df695b7-bspbb -n do-bookinfo-phani
Pod: productpage-v1-6f9df695b7-bspbb
Pod Ports: 9080 (productpage), 15090 (istio-proxy)
Service: productpage
Port: http 9080/HTTP targets pod port 9080
Exposed on Ingress Gateway http://EXTERNAL_IP
VirtualService: bookinfo
/productpage, /static*, /login, /logout, /api/v1/products*

Can you please let me know what am i missing?
please let me know if more log info needed
PS: have not configured mTLS.

Can you post the info on how you installed istio and configured it?
Also please note Istio 1.7 is no longer supported.

We don't have enough info to debug this any further, please feel free to re-open if you can provide more. thanks


[Grafana][Dashboard] Forgot Password flow in grafana is not working.

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
I am not receiving emails after I tapped on "Forgot Password" link in grafana screen
What do you expect to happen
I should get an email triggered that provides my temporary password
How to reproduce
Go to Config-UI and click on "Dashboard" option at the top right corner of the screen.
User is navigated to the grafana screen where you would be prompted to provide user id and password. Also, you would have "Forgot password" link as well.
After I tap on "Forgot Password" I was prompted to provide user id and after I did reset, I expect the system to send temporary password to the email id provided but did not receive.
Anything else
no
Version
v0.20.0-beta10
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I have never touched this feature, but I think it's normal. Because there is no email service provider.
You can make this feature work as expected by adding an email configuration.
Hope https://grafana.com/docs/grafana/latest/setup-grafana/configure-grafana/ can help.


Embed fields

Describe the idea you'd like to see implemented
embed fields for i.embed command which allows the ability to set the embed's Title, Field(s), Description, Footer & other stuff like that.
Additional context
This would make the embed command more useful imo.

Please see whether the attached syntax specification achieves everything it needs to

Please see whether the attached syntax specification achieves everything it needs to

I feel like full json format would be easier but that does achieve everything it needs to as far as I can see with a quit glance.

This new specification supports everything we need and includes the names. The issue with the previous specification was that there was no way to tell whether a whitespace was part of a passed string (title:I am here) or intending to separate two entries (title:Hi description:Hello).
Please review this specification.


Module does not connect to M32R

Thanks for the great code. Having an issue connecting to the small format M32R. Desk is running latest 4.x firmware and connected properly to network. M32-Edit connects and can control the desk from another computer ok. Companion version is 2.1.1-2de-1549-2569.
In the GUI the connection is stuck on "syncing" with a yellow background. Having read other threads I have attempted to send commands from companion anyway but these commands are not received by the desk. Attached is screenshot showing state of the connect when I select EDIT on the instance. Model and firmware are undefined, could this be an issue with the code not recognising the smaller format models of the desk?

There was a bug fixed in 2578 that would prevent the module connecting to a device after the config was updated. Perhaps you are hitting that issue?
If it connects after restarting companion then that will confirm that to be the cause.
As far as im aware the functionality of the various x32/m32 models is identical, just with a different form factor, so the module should work fine with them all.
Actually, the commands not working looks like a clue here, and suggests that the companion computer isnt able to talk to the m32.
In fact, the syncing state is a bit misleading, syncing really means that it is waiting for the first osc response from the desk.

assumed fixed


Request: Allow /1?[0-9]{2}/ format for Default World plugin

In #915, /[0-9]{2}/ format was added for the default world plugin, effectively allowing entries like "22" to translate to "322". As OSRS now has at least one permanent world above 399 (w417 is the permanent f2p pvp world), can /1?[0-9]{2}/ translate values between 100 and 199 to 400-499 actual values?

Fixed #1445

Never mind, #915 basically does world = world < 300 ? world + 300 : world, so the 400 worlds are already covered.


⚠ Bofrost.at has degraded performance

In a8eba2a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1177 ms

Resolved: Bofrost.at performance has improved in ef26f07 after 6 minutes.


Menu shows random entries from past

When I'm logged in. The menu (menu.html) shows totally random entries after each refresh of the page. . The entries which are shown were deleted or renamed before.
This issue doesn't occur when I'm NOT logged in.
There seems to be this issue in the past: https://groups.google.com/forum/#!topic/django-cms/_9KPqybmgWg
This happens within my production env. With the following setting:
dj-database-url==0.3.0
Django==1.7.7
django-classy-tags==0.6.1
django-cms==3.0.12
django-mptt==0.6.1
django-reversion==1.8.5
django-sekizai==0.8.1
djangocms-admin-style==0.2.5
djangocms-column==1.5
djangocms-file==0.1
djangocms-flash==0.1
djangocms-googlemap==0.2
djangocms-inherit==0.1
djangocms-installer==0.7.2
djangocms-link==1.5
djangocms-picture==0.1
djangocms-style==1.5
djangocms-teaser==0.1
djangocms-text-ckeditor==2.4.3
djangocms-video==0.1
gunicorn==19.3.0
html5lib==0.999
Pillow==2.7.0
psycopg2==2.6
pytz==2014.10
requests==2.6.0
six==1.9.0
South==1.0.2

Python = 3.4.0

Any cache enabled / which backend?

I've seen this before, but it was because I had two or more sites using the same cache-backend and I hadn't change the value of CMS_CACHE_PREFIX to something unique for each site. Could this be the case here?

Closing due to lack of info.
Please create a new ticket if this issue is still present on latest django CMS (3.4)


Add --deletions-as-missing option

Deletions add a lot of complexity and confuse the HMM. If we're focusing on recombinants and their origins, we want to be sure that the HMM isn't being biased away from sites carrying deletions (or vice versa) by overcounting the deletion events.
We want to mask deletions as missing after all the metadata has been collected, so that we can still keep track of the number of deletions, which not actually tracking them.
If we're motivated later we can add back in high-frequency deletions by remapping those sites using parsimony. It would likely do a reasonable job.

The degree of parsimony would also be a good validation how well we've performed at building the local trees, using this approximation of treating all deletions as missing data.


Finished driver

Closes #2

@mwolosewicz @pkamoda-shani We've made some changes, I hope all your conserns have been resolved. But we've run into a new issue. When the bme sensor loses connection for some reason it logs the last successful measurement but doesn't try to reconnect the device. Should we try to add some error handling to re-initialize the device when it is reconnected or should we leave this as a topic for a later date? What do you think?


Allow wrapping Tag via tagHoc prop (eg for tags that are links)

For our use case, wanted each tag to be a link to a listing page of things tagged with that tag
My solution was to allow passing a higher-order component to wrap Tag via the tagHoc prop

Rebase with master and do not commit dist/ and dist-modules/ files.


"npm install react-alwan" doesn't install the library

"npm install react-alwan" doesn't install the library. The three files visible in node_modules/react-alwan are: LICENSE, package.json and README.md.

Thanks. "npm install react-alwan" now installs the dist folder. However,
     import Alwan from 'react-alwan'

is still not working. A test repo is available at https://github.com/FrugalX/test-react-alwan.
How was it created:

npx create-next-app@latest
'npm install react-alwan' inside the repo root folder
import statement was added to src/pags/index.js
'npm run dev' throws errors.


str_random ignore certain characters

how can i ignore / not include certain characters while using str_random function e.g. i want to ignore o and i

Just filter them out, and overgenerate the string if you want to. Feel free to discuss on the fourms.


Automated backport of #1885: Add grep to Globalnet and RouteAgent images

Backport of #1885 on release-0.13.
#1885: Add grep to Globalnet and RouteAgent images
For details on the backport process, see the backport requests page.

@sridhargaddam @skitt can you merge this one?


Ferdium.Ferdium.Nightly version 6.0.0-nightly.99

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

/azp run

What's the difference between Ferdium.Ferdium and Ferdium.Ferdium.Nightly?

Hi @ItzLevvie thanks for having a look at that.
I created the winget bucket thinking that we could put all of the releases under Ferdium.Ferdium by allowing an install tag for the different types of prereleases, but I only saw after submitting it that winget does not support release channels like this. So I moved the nightly and beta into their own id, and we will keep Ferdium.Ferdium only for stable release (the first one is coming soon). Should I submit a PR to remove Ferdium.Ferdium in the meantime?

Hey @ItzLevvie, it seems like the bot has forgotten to take out the needs-attention tag. If you could remove it at any point, that would be great. Thanks :-)

@wingetbot run


Vulnerability roundup 97: postgresql-9.5.23: 2 advisories [8.8]

search, files

[ ] CVE-2020-25695 CVSSv3=8.8 (nixos-20.09)
[ ] CVE-2020-25694 CVSSv3=8.1 (nixos-20.09)

Scanned versions: nixos-20.09: 50c8d1e0deb.
Cc @danbst
Cc @globin
Cc @ocharles
Cc @thoughtpolice

See also: #99835

Can be closed as soon as #108495 is on 20.09.

Can be closed as soon as #108495 is on 20.09.

Can be closed as soon as #108495 is on 20.09.

Can be closed as soon as #108495 is on 20.09.

Updates are on 20.09 since c30ad09

Updates are on 20.09 since c30ad09


Feedback: TItles & Name too Dark + Search Redundant

didnt realise it was you who made this lol Manton

Also some images appear to big:

from https://w4rner-test.micro.blog/2020/10/12/goodreads-isnt-good.html

Of things mentioned @stettgames :

dark names fixed. But not titles on Archive page.

Relatedly on new one:
light comments on light background aren't different enough:

can't speak to auto-image sizing. It certainly got automatically better when I switched to Typewriter (dark) (original link still works). Not sure if now better on Marfa or if need to manually resize images.

kept DDG as search. Could Marfa not get a similar in-blog search like Typewriter (e.g.)

I think we can close this now. The latest version of the plug-in has been updated. Thanks y'all!


[SpeedDial] Fix crash when using custom style in FabProps

Closes #18312

[x] I have followed (at least) the PR section of the contributing guide.

@weslenng Thanks, I was hesitating to add a regression test but it seems this is more or less standard logic. We shouldn't have tried to mutate the input, it's a side effect, it's bad.


wo hope it can play anime just like popcorn time

wo hope it can play anime just like popcorn time,and support chinese language.beause many chinese like anime.

This could be a great feature.

Sooo about streaming...
There are lots of things about streaming:

It is no easy feature especially if we're talking about real "streaming" like downloading and watching at the same time. This is because KawAnime is based on torrents and watching torrents while downloading is not a good thing for torrents themselves. This can be overcome.
The main problem is this one : KawAnime is made with web technologies. Also, most of the files you can download as of right now (it will get better) are mostly mkv files. mkv is a difficult format to work with and at this day, there is no web video player that can read mkv file along with their "embed" subtitles.
I do believe that I can do no better than VLC or some other apps out there.

So yea.. very interesting feature. Definitely planned but definitely not in top priority right now. It does need a lot of time and effort.

As of Chinese support. I know the Chinese community is very large when it comes to anime but there are two problems here:

I don't really know where to find torrents and sources in Chinese.
I do not speak Chinese at all 😞 . Thus it is really hard to find stuff.

What I can do though is implementing language translations in KawAnime (probably with i18n) with Chinese in available languages. But then again, I would need:

People that can do translations.
Information site(s) (similar to myanimelist.net or livechart.me) in Chinese.

Internationalisation is actually a big problem in KawAnime for not only translations are needed but also websites similar to the ones used currently.

https://github.com/00SteinsGate00/Node-MPV
Pretty good, I'm using in https://github.com/NyaaPantsu/cinnamon

This module requires mpv to be installed on your system to work

I do not want to use things that would require third-party application to be installed 🤕

https://github.com/videojs/video.js

or https://github.com/surmon-china/vue-video-player both I tested and .mkv should working

Ok I was kinda unclear on this. The problem here isn't about reading mkv as a video file. The problem is that there is no player based on web-technologies that can read mkv along with the embed subtitles.
Don't get me wrong, you can watch the video just fine. But the subtitles won't appear. To try it you can try downloading one of the HorribleSubs video (just an example). This will be a .mkv file with embed subtitles. We don't have access to the .ass or any subtitle file. Then try to read it with video-js (There is no type "video/mkv" so you should use any other like "video/mp4"). This way you'll get to see the video but you won't see any subtitle.
video-js does support subtitles but it must be use like described here (with track tag) as it is said in this issue.
Though, if you find a way to use mkv files with embed subtitles like those released by HorribleSubs, I would gladly appreciate any advice there 😄 .

matroska-subtitles may be of use

Yes https://github.com/mathiasvr/matroska-subtitles

This could work, would need a preprocessing before reading the file + writing some code that would transform the output to an actual track that could be used by html.
Nice one guys! Thanks 😄


[Sonar] Iterate over the "entrySet" instead of the "keySet" in src/main/java/org/trebol/config/CorsConfigurationSourceBuilder.java

Summary

Source Sonar issue URL
Issue type: Code Smell
Severity: Major
Technical debt: 5min effort

I can work on this issue

@logesr Thanks! Please use the Discussions forums if you have any questions or contact me through my e-mail 👍

Hi @bglamadrid ! I am not sure if this issue was necessary. This file will be deleted soooon.. see #104

@mepox You are correct, but for now it's good to improve on the basics; letting Sonar gives us tips on how to write better code. Also allowing new contributors to step in and contribute with simple tasks.


Added pkg-config checking to Makefile where possible

This would fix #2233. I have pkg-config on my system and this seems to work correctly.

OK, I updated with the changes we discussed, and the single Jenkins test failure seems unrelated.


Add source parameter for more fine-grained authorization

This was suprisingly small change, did I forget something? Added HAUKI_SOURCE env to azure devops pipelines.

Good job 👍
I assume the build fails because of wrong api version in test.

Correct! Plan is to wait until corresponding api branch gets merged and deployed to test environment, and then re-run these tests


cosmic-screenshot: 1.0.0-alpha.1 -> 1.0.0-alpha.2

Description of changes
This is essentially a NFC, but matches the latest upstream tag.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 344497 run on x86_64-linux 1

1 package built:

cosmic-screenshot


Added a new updated resource

Hey, I have added a new resource for unique Key in SQL in in the useful links section. Got to know about this tutorial while looking for some resources to learn SQL. I believe this reference will add more value to this article. Hope this small contribution will help other learners.

Sorry,  this link useful (maybe) for articles (see https://github.com/ktaranov/sqlserver-kit/blob/master/Articles/README.md), or add your resource on https://github.com/ktaranov/sqlserver-kit#courses section


SNES images not downloading

I have completely closed out ES and ran your scraper however upon completion, there are no images showing for SNES roms nor is there a directory with downloaded images in /home/pi/emulationstation/downloaded_images.

I have this exact issue but for every system.

I've introduced a bug. I'll have a fix shortly.

I renamed the -gdb_img flag to -console_img but forgot to actually use the new flag so it wasn't downloading images. Sorry about that. The new code is being released now.

Thank you sir!!! :)


Include RapidJSON headers only if BOND_SIMPLE_JSON_PROTOCOL defined

Correct me if I'm wrong but RapidJSON headers needed only for simple JSON protocol. But this headers are included in any case. This forces a user to has a dependency on RapidJSON even if he/she is not going to use JSON at all.
I propose to include simple_json_xxx headers (along with RapidJSON headers) only if BOND_SIMPLE_JSON_PROTOCOL is defined.

Yes, this makes sense.

The boost::variant used in the implementation of bonded<T> always has all protocols, even disabled ones. The reason for this was to minimize potential for catastrophic, potentially exploitable and very hard to diagnose errors when ODR rule violation would lead to wrong layout of the internal variant data.

I've checked the code. The bonded type that minded as protocol agnostic type in fact on all protocols. That's really strange for me. How this approach will allow to add new protocols without breaking binary compatibility with old code?

Revisiting this old issue. Many of the ODR-related concerns and the issue raised above about bonded<> are now addressed as of https://github.com/Microsoft/bond/pull/425. However, SimpleJSON still appears in the list of BuiltInProtocols. I think that this would be a fairly impactful breaking change for some of the heavier users of Bond internally.

Agreed about the breakage. RapidJSON could be made opt-out pretty easily now, though.


"Last Login" for "Other Organizations" Table Not Accurate

Describe the bug
The "Last Login" column in the "Other Organizations" Table is still not working properly, and causing
To Reproduce
Steps to reproduce the behavior:

Go to "Other Organizations
Look at the table.
Error: None should be null. And because each of them had to request access to a recent incident, none should be an excessive period of time (e.g. years).

Expected behavior
Last Login should be accurate.
Screenshots

Desktop (please complete the following information):

Win 10, FF 76

This works now. Thanks, @tabiodun


Add handwired project

Add thiis handwired project to the README, is a great non-SMD-PCB alternative for mounting and soldering the ULP switches (see images in second comment link):

https://www.reddit.com/r/ErgoMechKeyboards/comments/18qr1xp/cherry_ulp_prototyping/
https://www.reddit.com/r/ErgoMechKeyboards/comments/18qr1xp/cherry_ulp_prototyping/kez1e7f/

Done! https://github.com/pashutk/Cherry_MX_ULP/commit/ac65a5b789917aae82f199629806ff953a9780a7
Thanks for sharing @nahuel thats some unique approach here. Please keep going!

Note that this is not my project, only a random one I found on reddit, please remove my name from the Readme :)

Oh thanks for pointing out, will change it for an appropriate mention!


Update to latest convention

Reviewer checklist

[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure correct labels applied
[ ] Ensure any appropriate documentation has been added or amended

Coverage remained the same at 98.678% when pulling b5d124a2494b6e00b2e78a2dc81b5f9542c73c25 on update_convention into 7c92dfab39aaa398fe195afaa1697a9cd1a6bd0d on main.