Coproduct selection is sketchy?

I am trying to use shapeless for some validation and about to abandon it because I can't prove that it works in my test cases. Essentially, the Coproduct selection mechanism doesn't seem to work on a mapped result. I've tried tracing through this in the debugger but I believe it is simply a shapeless/compiler issue. I'd be very happy to find out that I'm wrong if you can point out the error in my use of shapeless below.
The basic idea here is that I have:

a Coproduct type named "RealNumber" that permits a real value to be provided as an Int, Long, Float, Double or String,
a validation function that uses a Poly1 to validate the potential values of the coproduct, and
a set of test cases to see if it works.

It only works for the Int cases.
  "Shapeless Coproduct" should {
    object TestType {
      type RealNumber = Int :+: Long :+: Float :+: Double :+: String :+: CNil
    }
    def validate(value : TestType.RealNumber, min: Double = 10.0, max : Double = 20.0): Result = {
      object validator extends Poly1 {
        implicit def caseInt = at[Int] { i : Int ⇒
          if (i < min) Some(s"Value $i is out of range, below minimum of $min")
          else if (i > max) Some(s"Value $i is out of range, above maximum of $max")
          else None
        }
        implicit def caseLong = at[Long] { l : Long ⇒
          if (l < min) Some(s"Value $l is out of range, below minimum of $min")
          else if (l > max) Some(s"Value $l is out of range, above maximum of $max")
          else None
        }
        implicit def caseDouble = at[Double] { d : Double ⇒
          if (d < min) Some(s"Value $d is out of range, below minimum of $min")
          else if (d > max) Some(s"Value $d is out of range, above maximum of $max")
          else None
        }
        implicit def caseFloat = at[Float] { f : Float ⇒
          if (f < min) Some(s"Value $f is out of range, below minimum of $min")
          else if (f > max) Some(s"Value $f is out of range, above maximum of $max")
          else None
        }
        implicit def caseString = at[String] { s: String ⇒
          try {
            val num = s.toDouble
            if (num > max) Some(s"Value $s is out of range, above maximum of $max")
            else if (num < min) Some(s"Value $s is out of range, below minimum of $min")
            else None
          } catch{
            case x : Throwable ⇒
              Some(s"Value '$s' is not convertible to a number: ${x.getClass.getSimpleName}: ${x.getMessage}")
          }
        }
      }
      val mapped = value.map(validator)
      val selected = mapped.select[Option[String]]
      selected match {
        case Some(x) ⇒
          x match {
            case Some(result) ⇒ failure(result)
            case None ⇒ success
          }
        case None ⇒ failure("Input didn't match an acceptable type")
      }
    }

    "succeed on 10.0 <= 15.0D <= 20.0" in {
      validate(Coproduct[TestType.RealNumber](15.0D))
    }
    "succeed on 10.0 <= 15.0F <= 20.0" in {
      validate(Coproduct[TestType.RealNumber](15.0F))
    }
    "succeed on 10.0 <= 15L <= 20.0" in {
      validate(Coproduct[TestType.RealNumber](15L))
    }
    "succeed on 10.0 <= 15 <= 20.0" in {
      validate(Coproduct[TestType.RealNumber](15))
    }
    "succeed on 10.0 <= \"15.0\" <= 20.0" in {
      validate(Coproduct[TestType.RealNumber]("15.0"))
    }
    "fail on 10 <= 5.0D <= 20.0" in {
      validate(Coproduct[TestType.RealNumber](5.0D))
    }
    "fail on 10 <= 5.0F <= 20.0" in {
      validate(Coproduct[TestType.RealNumber](5.0F))
    }
    "fail on 10 <= 5L <= 20.0" in {
      validate(Coproduct[TestType.RealNumber](5L))
    }
    "fail on 10 <= 5 <= 20.0" in {
      validate(Coproduct[TestType.RealNumber](5))
    }
    "fail on 10 <= \"5.0\" <= 20.0" in {
      validate(Coproduct[TestType.RealNumber]("5.0"))
    }
  }

The results look like this:
[info] Shapeless Coproduct should
[error]   x succeed on 10.0 <= 15.0D <= 20.0
[error]    Input didn't match an acceptable type (ValidationSpec.scala:140)
[info]
[error]   x succeed on 10.0 <= 15.0F <= 20.0
[error]    Input didn't match an acceptable type (ValidationSpec.scala:140)
[info]
[error]   x succeed on 10.0 <= 15L <= 20.0
[error]    Input didn't match an acceptable type (ValidationSpec.scala:140)
[info]
[info]   + succeed on 10.0 <= 15 <= 20.0
[error]   x succeed on 10.0 <= "15.0" <= 20.0
[error]    Input didn't match an acceptable type (ValidationSpec.scala:140)
[info]
[error]   x fail on 10 <= 5.0D <= 20.0
[error]    Input didn't match an acceptable type (ValidationSpec.scala:140)
[info]
[error]   x fail on 10 <= 5.0F <= 20.0
[error]    Input didn't match an acceptable type (ValidationSpec.scala:140)
[info]
[error]   x fail on 10 <= 5L <= 20.0
[error]    Input didn't match an acceptable type (ValidationSpec.scala:140)
[info]
[error]   x fail on 10 <= 5 <= 20.0
[error]    Value 5 is out of range, below minimum of 10.0 (ValidationSpec.scala:137)
[info]
[error]   x fail on 10 <= "5.0" <= 20.0
[error]    Input didn't match an acceptable type (ValidationSpec.scala:140)
[info]
[info]
[info] Total for specification ValidationSpec
[info] Finished in 28 ms
[info] 10 examples, 9 failures, 0 error

On the cases that should fail, the debugger tells me that the mapping worked correctly as the "mapped" variable has an Option[String] in it. But, select[Option[String]] fails to return Some and always returns None, except in the case of "Int" where it works just fine.

After val mapped = value.map(validator), mapped has type Option[String] :+: Option[String] :+: Option[String] :+: Option[String] :+: Option[String] :+: CNil. This is because you have mapped each potential supported type into its validation method.
When you do val selected = mapped.select[Option[String]], you are telling Shapeless to grab the first element of type Option[String] out of the coproduct. The first element of type Option[String] is the first item (since they all have the same type), which corresponds to the Int case of the original coproduct. So, it always selects the first element (and therefore works for the Int case and no others).
It sounds like what you are looking for is the unify method. This method works on a coproduct in which each element has the same type. It grabs the item that is actually populated.
Try something like val errorMsg: Option[String] = mapped.unify. I think that should work for you.

@ceedubs - Brilliant! That's exactly what I needed. I guess I thought "select" meant select the populated item, not the first matching item .. silly me.

BTW, the best place to go with questions along these lines is shapeless Gitter channel ... see you there :-)


Correctly Sanitize git Branch and Tag Names

Change Description
This pull request fixes an edge-case where git branch names with multiple forward-slash characters (/) in the name would cause the Docker - Build and Install step in Buildkite to fail because the code which sanitizes the branch name before using it in a docker image tag only replaced the first occurrence.
I have fixed this by replacing all forward-slash characters with underscore characters, instead of just the first one. I have also dropped any forward-slash which appears at the beginning of a branch name, as this is meaningless. See this Stack Overflow answer for more details on valid git branch and tag name syntax.
Examples
Here are the builds where we ran into this error:

Build 21180 failed here with /feature/fix-spurious-ignition-failures-again as the branch name given to Buildkite
Build 21181 failed here with /feature/fix-spurious-ignition-failures-again-develop as the branch name given to Buildkite

You can see I intentionally created this pull request with a branch name containing a leading forward-slash, and several more in the middle of the name. Build 21191 passed with /zach/1.8/sanitize/branch/name as the branch name given to Buildkite.
See Also
This set of pull requests all make the same bug fix to different versions of EOSIO:

Pull Request 8875 -- eos:develop
Pull Request 8877 -- eos:release/2.0.x
Pull Request 8878 -- eos:release/1.8.x

Consensus Changes

[ ] Consensus Changes
None.

API Changes

[ ] API Changes
None.

Documentation Additions

[ ] Documentation Additions
None.

Closing to create a new pull request because pull requests using this (intentionally) mangled branch name fail to recognize new commits on the branch, or to trigger the CICD system.


Tutorial adding command

Added remark to person

Codecov Report

Merging #6 (d2d7311) into master (cf0295c) will increase coverage by 0.82%.
The diff coverage is 91.93%.

@@             Coverage Diff              @@
##             master       #6      +/-   ##
============================================
+ Coverage     72.15%   72.98%   +0.82%
- Complexity      399      419      +20
============================================
  Files            70       73       +3
  Lines          1232     1288      +56
  Branches        125      131       +6
============================================
+ Hits            889      940      +51
- Misses          311      314       +3
- Partials         32       34       +2

Impacted Files
Coverage Δ

...in/java/seedu/address/logic/parser/ParserUtil.java
97.22% <ø> (ø)

.../java/seedu/address/model/util/SampleDataUtil.java
20.00% <ø> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...c/main/java/seedu/address/model/person/Remark.java
87.50% <87.50%> (ø)

...va/seedu/address/logic/commands/RemarkCommand.java
88.00% <88.00%> (ø)

...java/seedu/address/logic/commands/EditCommand.java
97.05% <100.00%> (+0.04%)
:arrow_up:

...a/seedu/address/logic/parser/AddCommandParser.java
100.00% <100.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
100.00% <100.00%> (ø)

...ain/java/seedu/address/logic/parser/CliSyntax.java
85.71% <100.00%> (+2.38%)
:arrow_up:

...eedu/address/logic/parser/RemarkCommandParser.java
100.00% <100.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf0295c...d2d7311. Read the comment docs.


[WFLY-10080] - GSS Need to handle a http post method on pic…

…ketlink sp authentication - test
JIRA: https://issues.jboss.org/browse/WFLY-10080
Requires following PRs:
jbossas/redhat-picketlink-bindings#40
undertow-io/undertow#570
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:

[ ] Pull Request title is properly formatted: [WFLY-XYZ] Subject or WFLY-XYZ Subject
[ ] Pull Request contains link to the JIRA issue(s)
[ ] Pull Request contains description of the issue(s)
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Attached commits represent units of work and are properly formatted

For bigger changes, major and minor component upgrades make sure your PR also meets following requirements:

[ ] Pull Request requires a change to the documentation
[ ] Documentation have been updated accordingly
[ ] Tests were added to cover changes

For new features ensure as well:

[ ] Analysis was done
[ ] Test Plan has been done
[ ] Tests were verified in advance

If you are not an active contributor of the WildFly project you can request sponsorship by one of the members to help guide you through the process.

Retest this please


tests: more tests

Codecov Report

Merging #7 into master will increase coverage by 2.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   40.67%   42.91%   +2.23%
==========================================
  Files          10       10
  Lines         268      268
==========================================
+ Hits          109      115       +6
+ Misses        152      146       -6
  Partials        7        7

Impacted Files
Coverage Δ

internal/benchreader.go
100% <0%> (+100%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a40fa...81e60eb. Read the comment docs.


WebAsyncWrapper doesn't handle timeouts properly

Hi Tim,
Thank you for the project, it is very useful. I've used it to do sync web request, and it works perfectly.
Now, I'm trying to make the request async, using WebAsyncWrapper. But I get Run-time error '13': Type mismatch when I call ExecuteAsync with a webrequest and string of the callback function.
I debug into the code, and the error happens at:
web_StartTimeoutTimer()
Application.OnTime Now + TimeValue("00:00:" & web_TimeoutS), "'WebHelpers.OnTimeoutTimerExpired """ & Me.Request.Id & """'"
So the OnTime registration failed. Of course, my callback won't be called.
I searched in the examples included in the package, but no examples for WebAsyncWrapper.
Can you please share a working example for Excel 2010 or 2013?
Thanks
Jack
P.S. here is my code snippet.
Public Sub ProcessDataCB(Rsp As WebResponse)
Dim Result As String
Result = Rsp.Content
Dim resDict As Dictionary
Set resDict = ParseJson(Result)
PrintDictionaryRange resDict, Worksheets("Bullet Bond Anywhere").Range("D8:D30")
End Sub
Public Sub PostMessageAsync(Url As String, Message As String, Token As String)
Dim IASClient As New WebClient
Dim IASWrapper As New WebAsyncWrapper
Set IASWrapper.Client = IASClient
IASClient.BaseUrl = Url
IASClient.TimeoutMs = 60000

Dim IASRequest As New WebRequest
IASRequest.Method = WebMethod.HttpPost

IASRequest.AddHeader "Authorization", "Bearer " + Token
IASRequest.RequestFormat = WebFormat.FormUrlEncoded
If Token = "" Then
    IASRequest.ResponseFormat = WebFormat.PlainText
Else
    IASRequest.ResponseFormat = WebFormat.Json
End If

IASRequest.Body = Message

' Execute the request and work with the response
IASWrapper.ExecuteAsync IASRequest, "Module1.ProcessDataCB"

End Sub

You can probably workaround the issue by setting your timeout to 59 seconds (or anything under 60.
@timhall TimeValue is expecting a string representing a time. 08:08:30 is 8:08 (AM?) and 30 seconds. Values >= 60 will fail to parse as type mismatch.
If you want to allow timeouts over 60 seconds you may have to use DateAdd("s", web_TimeoutS, Now) and then do some parsing to convert 11/27/2018 8:12:38 AM to 8:12:38 AM which OnTime expects instead.

Thank you zgrose! You saved me from many hours of frustration! The issue was with the Client.TimeoutMs I set. I set it to 60 seconds, which the TimeValue had a problem to parse.
Thanks a lot!

you can also convert your timeout in day fraction
Dim web_TimeoutInDayFraction As Double
web_TimeoutInDayFraction = CDbl(web_TimeoutS) / 86400# ' 86400 = nb second per day
Application.OnTime Now + web_TimeoutInDayFraction), ....
it works fine as long as you do not call Application.OnTime from a class module
otherwise you will hit  https://github.com/VBA-tools/VBA-Web/issues/373

@timhall Sorry to bother, but I have run into an analogous problem: I am using the library VBA-Web to request some heavy calculations, that might take more than 10 min to run. I've tried both synchronous as well as asynchronous requests, by setting client.TimeoutMs to 600000 (10min), but after 60s, the response (or callback) returns, while the API is still processing...
I've read somewhere else (https://github.com/VBA-tools/VBA-Web/issues/389) that there might be a problem with office 64bits. Do you have any idea or suggestion?
Thanks

You probably should re-implement that API, if possible, to be a fire and forget then poll for completion.
POST /my-long-operation
receive job ID (or supply one)
and then GET /job-status?id=foo
Just my 0.02 if you have control over the endpoint.


UHF-X fix local tasks tab focus

UHF-X

Local tasks tab focus ring was causing false positives in our A11y tool. Handling focus ring with non-outline can be problematic.
Also, the hover animation was done with size and height properties that are not performant. Switched to use transform: scale instead. This fixes related scss linter problems too.
What was done

Focus ring was converted from pseudo element to outline
hover animation was changed from non-performant width and height properties to scale
Code cleaned up a bit

How to install

Make sure your instance is up and running on latest dev branch.

git pull origin dev
make fresh

Update the HDBT theme

composer require drupal/hdbt:dev-UHF-X_fix_local_tasks_tab_focus

Run make drush-cr

How to test

[ ] Check that login page focus ring and hover effects work as intended
[ ] Check that code follows our standards

Designers review

[X] This PR does not need designers review

I'll handle this in another PR


Search / Select in Mac Preview not working

Hi @jean-humann
I just figured out something very strange. When I open the generated PDF in my firefox, I can select and search text just fine. However, when I open the same File in Mac Preview the text is not correctly selectable.
Here a video showing it with the example pdf.
https://github.com/jean-humann/docs-to-pdf/assets/643436/46396298-5d90-465a-8e30-e09b50edc11d
When I try the same with the PDFs generated by marp which also uses pupperteer/chromium to generate PDFs from HTML, everything works fine. @yhatt do you maybe have some idea on this?
Best codingluke

Very interesting, I had the same problem with my pdfs generated on my mac. Now I generate them ina Github Action. The result. It works also on mac preview. For me the problem is resolved, even though still a little to much magic 🪄 .


Only build active arch when launching on simulator

When running the app on simulator from Android Studio or gradle, build only the active arch, i.e., if we are running on Intel mac, build X86 only, and build AARCH64 only if running on Apple silicon.
This is mainly for speeding up development of MOE 2.0 as the native image build is time consuming.

A property moe.archs has been added to the gradle plugin which you can specify the archs to build. It accepts a comma delimited list of arch names, such as -Pmoe.archs=x86_64,arm64.


Error after yarn build

Hi! Figured out with another problem. After build I open index.html. Looks fine and haven't any errors. But when I trid to switch route 'help' I see error in console:
Uncaught DOMException: Failed to execute 'pushState' on 'History': A history state object with URL 'file:///D:/help' cannot be created in a document with origin 'null' and URL 'file:///D:/frl/public/index.html'.     at file:///D:/frl/public/bundle.js:22:50605
What this? How I can fix this issue?

hey @danilsitnikov783 i'm not getting this issue but what browser are you using? I tried replicating this through firefox/chrome and it works fine for me. (using mac)

@pgerochi Chrome, win 10. I modified configs for me. Maybe error in this.
webpack.config
webpack.production

@danilsitnikov783 when you open index.html in the build folder (public) are you running it on a server? If not, that may be your problem.

URL 'file:///D:/help' so similar problem to the other one :) you need webserver to be able to run the application

@alicoding which the server?) I need to setup .htaccess for looking index.html? And user for this some MAMP or XAMPP?

@pgerochi No. I just opening index.html

@danilsitnikov783 if you have python installed on your machine then run the following command inside public directory
python -m SimpleHTTPServer 8000

then go to localhost:8000 to see the content.


Add a LICENSE file (BSD)

The README says that the repository license is BSD - https://github.com/wyp1125/MCScanX/blob/b1ca533510841155beb16dc2f2a65b2a3c37287e/README.rst#L4
With this PR I add a LICENSE file for the same.

@martin-g
While BSD LICENSE is no problem with me, I'll need to defer the license choice to the owner of this repo.
If @wyp1125 is okay then we should be able to do this.
Haibao

Actually the program currently lists BSD in its README, so I'll assume that this is fine, but @wyp1125 if you prefer otherwise.


docs: ✏ Add note about enabling skipLibCheck in README

Without this option enabled, a project importing the SDK will fail type checking
Slack convo

:tada: This PR is included in version 13.0.0-alpha.23 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 14.0.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 14.0.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


when I want to send upstream in response to some downstream, i get this error when ever I want to call "Messaging.messaging().sendMessage":

[READ] Step 1: Are you in the right place?

For issues or feature requests related to the code in this repository
file a Github issue.

If this is a feature request make sure the issue title starts with "FR:".

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
For help troubleshooting your application that does not fall under one
of the above categories, reach out to the personalized
Firebase support channel.

[REQUIRED] Step 2: Describe your environment

Xcode version: _____
Firebase SDK version: _____
Firebase Component: _____ (Auth, Core, Database, Firestore, Messaging, Storage, etc)
Component version: _____

[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
Relevant Code:
// TODO(you): code here to reproduce the problem

Closed in favor of #3553


[Candidate 3v3 Cursed Hollows ZH v1] Destructible barrels around mirrored Oil Derricks in center are not properly placed

Observed behavior
Destructible barrels around mirrored Oil Derricks in center are not properly placed.
Expected behavior
Destructible barrels around mirrored Tech Buildings are properly placed.
Screenshots

fixed

Is unchanged. On second look, it also looks like the terrain around these Oil Derricks are different. Unclear what a fair barrel setup should look like exactly, because the conditions are not the exact same.

Demoted from blocker. Terrain is not mirrored. Not straight forward to make equal conditions.

Top oil derrick terrain can be made a bit more passable.

tried my best on it

are these still on or u havent checked yet

I think I did not check. I did not update to the last edit because of the audio regression.


Text change for unlock wallet

"Please Set Your Wallet First ..." => "Unlock your wallet to start trading"

Fixed


Two factor authentication

Is two factor authentication sign-in supported? Like using Microsoft app authenticator?

Yes it is. And you can configure the 2fa authenticator issuer


Expose tls.ConnectionState for TLS connections

I wanted to check the TLS version and cipher suite negotiated by Go and RabbitMQ.

Thank you! We'd be happy to include this feature but this specific PR needs a bit of work.


flutter unable to build IOS app in release mode with Xcode 13.1 ( Undefined symbols for architecture arm64)

Error  msg :
Undefined symbols for architecture arm64:
"OBJC_CLASS$_GULAppEnvironmentUtil", referenced from:
objc-class-ref in FIRCLSApplication.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
note: Using new build system
note: Planning
note: Build preparation complete
note: Building targets in parallel
Full error log msg :
build_error.txt
IOS App running in debug mode on IOS real device . but facing issue when running in release mode
Below is the command used to build ios app in release mode
flutter build ios --release --no-codesign --dart-define=ENV=STAG_
POD Files :
Podfile.lock.txt
Podfile.txt
packages :
packages_info.txt
NOTE :
Same code working in XCODE 12.x . but facing this issue in XCODE 13.1
flutter doctor -v
[✓] Flutter (Channel stable, 2.5.1, on macOS 12.0.1 21A559 darwin-x64, locale en-GB)
• Flutter version 2.5.1 at /Users/rr-reddy/Documents/soft/flutter_soft/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision ffb2ecea52 (3 months ago), 2021-09-17 15:26:33 -0400
• Engine revision b3af521a05
• Dart version 2.14.2
[✗] Android toolchain - develop for Android devices
• Android SDK at /Users/rr-reddy/Library/Android/sdk
✗ cmdline-tools component is missing
Run path/to/sdkmanager --install "cmdline-tools;latest"
See https://developer.android.com/studio/command-line for more details.
[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 13.1, Build version 13A1030d
• CocoaPods version 1.11.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2020.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
[✓] Connected device (2 available)
• RR REDDY (mobile) • 00008030-000D749402D0402E • ios            • iOS 15.1 19B74
• Chrome (web)      • chrome                    • web-javascript • Google Chrome 96.0.4664.110
! Doctor found issues in 1 category.

https://stackoverflow.com/questions/70280008/undefined-symbols-for-architecture-arm64-objc-class-fluttererror/70280105

Hi @venkata-reddy-boya, please provide the output of flutter build ios --release --no-codesign --dart-define=ENV=STAG  -v.
The output is likely to be huge so you can just put it into a .txt file and upload it here.
Thank you

@danagbemava-nc
i am closing #95256.
This issue was resolved with firebase_crashlytics version update 2.2.0 from 2.1.1


I have added images in the images folder.

@Tejas1510

Please add the labels to the pull request too.
Thank You


Type-checked loop conditions

Suggestion
There should be a tsconfig option to enable strict type-checking of loop condition predicates
🔍 Search Terms
while, loop, for, bool, boolean
✅ Viability Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
A tsconfig bool option named typeCheckedLoops (or something else) that throws an error when any condition isn't a boolean
📃 Motivating Example
I was surprised that TS allowed the following (even with very strict config):
while ("true");

while (!"");

while ([]);

for (;{};);

None of those are bools, yet they don't trigger any errors
💻 Use Cases
This becomes a problem when the condition is a variable, or an expression composed of multiple vars.

Essentially a duplicate of #38826.

Thank you for the info. I'll close this


Django utils not found in auto import

This should have found 'django.utils'

Settings are here:
  "python.analysis.packageIndexDepths": [
    {
      "name": "",
      "depth": 2,
      "includeAllSymbols": true
    },
    {
      "name": "pandas",
      "depth": 2
    },
    {
      "name": "django",
      "depth": 4,
      "includeAllSymbols": true
    }
  ],
  "python.analysis.autoImportCompletions": true,

looks like
 {
      "name": "",
      "depth": 2,
      "includeAllSymbols": true
    },

this is messing things up. need to investigate.

This issue has been fixed in prerelease version 2023.1.31, which we've just released. You can find the changelog here: CHANGELOG.md


Findbugs

Introducing findbugs and fixing issues the tool found. Rank 6 in the configuration of findbugs maven plugin seems to provide good results in terms of no false positives have been found.

Jenkins retest this. Unable to see this failing locally, let's give it a second try.

@rsynek could you please rebase with master as this is now with conflict. Plus squash all commits into single one as I don't see much value of having them separated

@mswiderski done, tests seem to be ok now.

Thanks @rsynek!
One thing to consider: FindBugs considerably slows down the build. Do we want to keep it enabled by default? So far the Jenkins jobs were executing the checks on demand via findbugs:findbugs. We can still do that for PR builds, but locally people need mvn clean install findbugs:findbugs instead of just mvn clean install to get the results.
Just for comparison (on my machine):

mvn clean install -T4 -DskipTests takes ~4 minutes
mvn clean install -T4 -DskipTests -Dfindbugs.skip=true takes ~ 1min 30secs


Arm extension

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Associated Issue(s)
#25
Steps to Test
Use the right stick to control the arm extension. It should change the current position in shuffleboard.
Changelog
With an extending arm we need ways to move it especially with an analog stick as requested by drive team.
Why?
I am making this change so we can use our extending arm.

merging as is for competition after Saturday testing


Css Parser enhancements to CssNode

The proposal here (copied from #38) is to have a single, unified set of objects in the DOM and parse tree. The methods used to traverse the two trees are slightly different.
The parse tree preserves the original document, i.e. an inorder traversal of leaf nodes (tokens) produces the source text. In this example the start of the tree looks something like this (I have omitted the whitespace tokens, but they would be in the tree as as well.
CssStyleSheet
+ CssStyleRule
  + Selector
    + SimpleSelector
      + Token (identifier): div
    + Token (comment): /* element*/
    + Combinator:
       + Token: >
    + SimpleSelector:
       + Token :foo

We just need two different methods to retrieve the source, one that skips comments, and one that preserves them. No reordering is then necessary, and the parse tree has a simple structure with minimum memory overhead - just the _child and _next pointers.
So yes, it is true that tokens are flat - concatenating them in an inorder traversal of the tree produces the source document. But they are also contained within the parsed tree structure.
Note that this discussion pertains only to the parsed tree, i.e. the _child and _next pointers. The OM tree is unaffected.
BTW in this scenario Tokens only need one piece of data: the text. The TextPosition can be computed as needed (unless this is in the hot path of some usage; I don't need it personally.) In addition CssTokenType can be eliminated altogether by just having subclasses of CssToken. This further reduces the memory footprint.
To summarize, here is the set of proposed changes:

CssNode is the ultimate base class of all OM entities and tokens.
Each token type is a separate class, e.g. UrlToken, ColorToken (this is basically a memory optimization.)
The parse tree is composed of _child and _next pointers of CssNode.
Tokens appear at the correct position in the parse tree.
An inorder traversal of the parse tree (or any node) produces the stylesheet (or the text of the node.) Comments may be skipped during traversal if desired.

Will work on this later this week / next week.


Errors while trying to open repository

Errors while trying to open repository:
[Extension Host] TypeError: repository.match is not a function or its return value is not iterable
	at Object.directoryName (/Users/user/.vscode/extensions/ryu1kn.remote-repo-viewer-0.3.0/lib/repository.config.js:49:41)
	at Repository.downloadIfNotExist (/Users/user/.vscode/extensions/ryu1kn.remote-repo-viewer-0.3.0/lib/repository.js:15:37)
	at OpenRepositoryCommand.execute (/Users/user/.vscode/extensions/ryu1kn.remote-repo-viewer-0.3.0/lib/commands/open-repository.js:21:47)
t.log
[Extension Host] TypeError: Cannot read property 'Symbol(Symbol.iterator)' of null
	at Object.directoryName (/Users/user/.vscode/extensions/ryu1kn.remote-repo-viewer-0.3.0/lib/repository.config.js:49:41)
	at Repository.downloadIfNotExist (/Users/user/.vscode/extensions/ryu1kn.remote-repo-viewer-0.3.0/lib/repository.js:15:37)
	at OpenRepositoryCommand.execute (/Users/user/.vscode/extensions/ryu1kn.remote-repo-viewer-0.3.0/lib/commands/open-repository.js:21:47)
t.log @

OS: macOS Mojave 10.14.3
VSCode Version: 1.33.1
Plugin Version: 0.3.0

Hi @HackedBeat can you provide the steps to reproduce?

Cannot read property 'Symbol(Symbol.iterator)' of null
MacOS Mojavi
10.14.4

Thanks @caironm , could you let me know the steps to reproduce?

Hi @ryu1kn
I did the same actions as in the demo:

Run command Open repository in a new window
Paste https://github.com/ryu1kn/csv-writer.git
Press Enter

Thanks @HackedBeat I can reproduce the problem!

This line is causing the error. If repository is "https://github.com/ryu1kn/csv-writer.git", repository.match(/:([^/]+)\/([^.]+)\.git/) fails to capture user and repo. It works if I give "git@github.com:ryu1kn/csv-writer.git" and returns ryu1kn and csv-writer.

@ryu1kn So, here is the solution of this problem:
const repoLink = repository.includes('http')
  ? new URL(repository).pathname
  : repository
const [,, user, repo] = repoLink.match(/(:|\/)([^/]+)\/([^.]+)\.git/)

This code is less elegant than it was before, but it works with two types of links.

@HackedBeat the Pull Request's build failed, would you mind fixing it?
@ryu1kn The documented feature to use a shortcut g ryu1kn/vscode-remote-repo-viewer also fails.

@HackedBeat Thanks for the PR!

Released as v0.4.0. Updating ESLint caused a build failure...


Reconfigure page modals don't show up within Gnosis app

Steps to reproduce

Go to Gnosis safe which owns a Juicebox project
Go to apps -> Juicebox (should open Juicebox in the Gnosis window signed into the Gnosis wallet)
Go to your Juicebox page, reconfigure, try to reconfigure something
See modals don't appear:

https://user-images.githubusercontent.com/96150256/189799946-3f2fa0ee-856a-4d41-b509-f864d3066599.mp4
What is the current bug behavior?
What is the expected correct behavior?
Relevant logs and/or screenshots
Environment

Device/OS: [e.g. iOS]
Browser: [e.g. chrome, safari]
Hardware wallet: [e.g. Ledger w/ Metamask]

Going to assume this is no longer an issue.


Update Tokio dependencies

This PR updates Tokio to 1.x, and includes a few other related and necessary dependency updates.
There are only two small code changes required after updating Tokyo, both related to renamed APIs.
The code builds fine, tests pass and the LSP server in the examples starts up fine.

Tokio 1.x requires a recent rust compiler version. I updated the Github workflow to use "stable" instead of "1.41.0".
Let me know if the hardcoded version is actually important and cannot be changed.

This looks great - I'm keen to see a newer version with a higher tokio too. Anything that needs to be done before this can be merged?

Hey, thanks so much for submitting this PR, @p4p3r! I've chosen to close it in favor of #264, which also happens to include other changes in addition to the tokio upgrade. My apologies for the late review.


Environment variables (PATH etc.) not set in Visual Studio Code development container (IDFGH-13713)

This recent addition of code
https://github.com/espressif/esp-idf/blob/3c99557eeea4e0945e77aabac672fbef52294d54/tools/export_utils/shell_types.py#L125
causes an endless loop of ~/.bashrc sourcing /opt/esp/idf/export.py, running activate.py, activate_venv.py and the resulting script in turn sourcing ~/.bashrc again.
VSCode waits for 10 seconds for this to finish, which it doesn't, then gives up and continues without the necessary environment variables being set, resulting in builds failing with xtensa-esp32-elf-gcc not being found.

Hi @TheSeven , thank you for reporting the bug.
As for now, I can recommend a temporary workaround, by using the old export script:
ESP_IDF_LEGACY_EXPORT=1 . ./export.sh or . ./tools/legacy_exports/export_legacy.sh

I worked around it by just breaking the recursion in .bashrc by changing the related line in the Dockerfile to this:
RUN echo "[ -z \"\$ESP_EXPORT_DONE\" ] && ESP_EXPORT_DONE=yes . /opt/esp/idf/export.sh > /dev/null 2>&1" >> ~/.bashrc
With that file being automatically generated by the ESP-IDF VSCode extension, should I open an issue against that to get a workaround added there for the time being?

I worked around it by just breaking the recursion in .bashrc by changing the related line in the Dockerfile to this: RUN echo "[ -z \"\$ESP_EXPORT_DONE\" ] && ESP_EXPORT_DONE=yes . /opt/esp/idf/export.sh > /dev/null 2>&1" >> ~/.bashrc
With that file being automatically generated by the ESP-IDF VSCode extension, should I open an issue against that to get a workaround added there for the time being?

Apologies for the inconvenience. I believe this issue needs to be addressed in the export scripts. At present, the export script is sourcing .bashrc, which is incorrect.


Use weak tables to pool LRU instances

I came across the ctype-based reference counter wihle hacking on mlcache. Unless I am missing something, the same thing could be achieved a weak table in a much simpler way.
Is there any particular reason to use cdata and reference counts?

@jdesgats Yes, that is correct. I seem to recall I was exited about having a hook in the GC and do other sorts of cleanup within it, but never ended up doing so.

Great! Thank you so much!


AttributeError | Problem with MDDropDownMenu

Description
Hi, I have problems with MDDropDownMenu...
What is wrong?
main.py
from kivymd.app import MDApp

class Activity(MDApp):
    menu_items = [
        {
            'text': 'my text',
            'icon': 'box',
        }
    ]

Activity().run()

activity.kv
#:import MDDropdownMenu kivymd.uix.menu.MDDropdownMenu

ScreenManager:
    Screen:
        name: "menu"

        MDToolbar
            title: "MDDropDownMenu example"
            pos_hint: {"top":1}
            size_hint: 1, 0.1
            left_action_items: [["dots-vertical", lambda x: MDDropdownMenu(items=app.menu_items, width_mult=4).open()]]

Error
   File "/Users/felipe/Documents/MyProject/venv/lib/python3.7/site-packages/kivymd/uix/menu.py", line 626, in set_menu_properties
     self._start_coords = self.caller.to_window(
 AttributeError: 'NoneType' object has no attribute 'to_window'

Versions

OS: Mac High Sierra 10.13.6
Python: 3.7.6
Kivy: 1.11.1
KivyMD: 0.104.0

@Felipe738743872 The use of the MDDropDownMenu class has changed - https://kivymd.readthedocs.io/en/latest/components/menu/index.html#usage

@Felipe738743872 https://kivymd.readthedocs.io/en/latest/components/menu/index.html#wrong

@Felipe738743872 https://kivymd.readthedocs.io/en/latest/components/menu/index.html#menu-with-mdtoolbar

Thank you so much :)

@HeaTTheatR the kivymd version that use new behaviour of menus is not yet available in pyp, and when u use the development version of kivymd the audio provider is defaulted to be sdl and its problematic on linux, it cant play audios their

@Noor-Kalibbala KivyMD is just additional widgets for Kivy. The KivyMD library has nothing to do with audio or video providers.


Fix dynamic library issues on Macos

On my system, when linking against the 3.7.0 binary downloaded library, the name recorded inside the library is libraylib..dylib instead of libraylib.370.dylib as the installed symlink is named.
This is due to the use of $VERSION which is not set inside the Makefile. I think this was a typo, because there is no symlink built that uses that name.
The binary download for 3.0.0 works fine, but when I build locally 3.0.0, the same problem occurs. I feel the person who generated the raylib binary release must have hand-fixed the issue for the 3.0.0 version, but not the 3.7.0 version.
In addition, adding the @rpath/ prefix allows you to use DYLIB_LIBRARY_PATH or LD_LIBRARY_PATH to refer to the dynamic library. If you look at the 3.0.0 binary release, it has this prefix in it.
For sure the change from VERSION to RAYLIB_API_VERSION is correct. I'm not sure what the intent of the original author of this makefile had for the @rpath name prefix, but clearly whoever built the binary release thought it should be in there. Without that, you must have the dylib in your local path.
I think the 3.7.0 binary should also be fixed, so that one doesn't have to wait for a new release to have this corrected. Although, this is against master, I'm not sure if you maintain a branch for 3.7.

@schveiguy thanks for tracking and reviewing this issue! I'm afraid there is no 3.7 branch and current master branch is already set as 4.0-dev. Hopefully next version will be released soon.

Well, that's OK. But whomever maintains the macos binary binding may want to manually run that install-name-tool command on the dylib in the tarball. Right now, the dynamic lib loader is not going to find it, because you have to name it libraylib..dylib which nobody is going to do (I confirmed that if I symlinked a libraylib..dylib in my current directory, it would run).
From what I understand, that metadata id tag in the dylib is what tells the dynamic loader where it can find the required dynamic lib. So it links fine, but then goes searching for something that will not exist when trying to run.
Not sure if those release artifacts can be edited after the tag is formed in github...
In my case, I'm the only one who I know uses raylib on macos, so I'm covered ;) All my students are using Windows.


Integration with Bare Metal Nomad

Describe the problem to be solved
Hello, dear community,
Could you please advise if it’s possible to adapt this solution for Nomad on our own? For example, by building the code or Docker images and running it in Nomad (either as jobs or as systemd units on nodes) so that it works similarly to how it does with Kubernetes. Has anyone had such an experience?
Thank you in advance!
Proposed solution to the problem
No response

This seems like it is a duplicate of #303 which was discussed earlier. I did some work there trying to figure out how to get things working but eventually gave up mostly due to time constraints. The first hurdle is to chose the correct driver, as you either need to use the Containerd driver or the Docker driver configured with Containerd as the image store. Then you need to figure out how to get the correct networking working, which is where I stopped due to time. I think the biggest challenge is that every Nomad cluster seems to be a bit different networking wise etc.
I will close this issue so we can keep all Nomad discussions in a single issue, so it would be great if you could continue it there. I am not opposed to figuring out how to support Nomad, I just don't use it so I don't have the background to document it quickly.


Reuse token from GitHub client in container verifier

Summary
The access token set in containerAuth always comes from the GitHub client. Instead of passing in both the token and the client, only pass in the client and then fetch the access token from the client.
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[x] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 39.606% (+0.003%) from 39.603%
when pulling bc24156be792be26c0cb1b2b096842a501101308 on eleftherias:artifact-injester-refactor
into d0ea8774b9f41f31c6ab69a6301f0ea37bbfb053 on stacklok:main.


Undo Firefox changes for JPM

Undo Firefox changes for jpm, as they were breaking the dist build.
Entered https://github.com/uProxy/uproxy/issues/1909 to re-add JPM changes later on once we know how to make them support both dev + dist

:+1:


e2e test navigating artist -> recordings -> graph -> artist, then pop

nodes and text drawn in canvas are not accessible
https://developer.android.com/develop/ui/compose/accessibility#custom-actions

[ ] Make sure clickable and interactive elements are at least 48dp -> min 24 radius since we convert this to dp

overlay an element that is accessible like in https://eevis.codes/blog/2023-07-24/more-accessible-graphs-with-jetpack-compose-part-1-adding-content/?

worth random clicks to draw clicking on a sufficiently large node? will lead to flake


Segment broken?

Hello. I'm trying to follow the segment() API but it seems to be failing at new URI() - I just get an empty object with no uri.js methods on it.
Here's the code and debug screen:

Works fine for me:
➜  npm install urijs
<EMAIL_ADDRESS>node_modules/urijs

➜  node -e 'var URI = require("urijs"); var uri = URI("http://<IP_ADDRESS>:8080/u/34-34-1324-32432-3431"); console.log(uri.segment())'
[ 'u', '34-34-1324-32432-3431' ]

Which version of URI.js are you using?

Oh dear, I used npm install uri.js. That is a different library.  How dangerous. urijs works.
But. Some of my unit tests that worked with my own homemade method fail using urijs.
You might want to look at some of these test cases and see if you agree:
"use strict";
const URI = require('urijs');
const tape = require('tape');
const _ = require('lodash');

function appendUrl(url1, url2) {
    // if (!url2)
    //   return url1.trim();
    // const part1 = (url1.trim().substr(-1) === '/') ? url1.trim() : url1.trim() + '/';
    // const part2 = (url2.trim().substr(0, 1) === '/') ? url2.trim().substr(1, url2.trim().length - 1) : url2.trim();
    // return part1 + part2;

    const uri = new URI(url1); //https://github.com/medialize/URI.js/issues/312
    return uri.segment(url2).toString();
}

tape(testeeName + 'appendUrl works', (assert) => {
    assert.true(_.isEqual(appendUrl(`http://<IP_ADDRESS>:8080/u/34-34-1324-32432-3431`, `5-45-45234-545-`), `http://<IP_ADDRESS>:8080/u/34-34-1324-32432-3431/5-45-45234-545-`));
    assert.true(_.isEqual(appendUrl(`https://<IP_ADDRESS>:8080/u/34-34-1324-32432-3431`, `5-45-45234-545-`), `https://<IP_ADDRESS>:8080/u/34-34-1324-32432-3431/5-45-45234-545-`));
    assert.true(_.isEqual(appendUrl(`https://<IP_ADDRESS>:8080/u/34-34-1324-32432-3431`, `/5-45-45234-545-`), `https://<IP_ADDRESS>:8080/u/34-34-1324-32432-3431/5-45-45234-545-`));
    assert.true(_.isEqual(appendUrl(`http://<IP_ADDRESS>:8080/u/34-34-1324-32432-3431`, ``), `http://<IP_ADDRESS>:8080/u/34-34-1324-32432-3431`));
    assert.true(_.isEqual(appendUrl(`http://<IP_ADDRESS>:8080/u/34-34-1324-32432-3431/`, ``), `http://<IP_ADDRESS>:8080/u/34-34-1324-32432-3431/`));
    assert.true(_.isEqual(appendUrl(`http://ekaya.vip`, `u/34-34-1324-32432-3431/2323`), `http://ekaya.vip/u/34-34-1324-32432-3431/2323`));
    assert.true(_.isEqual(appendUrl(`https://ekaya.vip/`, `u/34-34-1324-32432-3431/2323`), `https://ekaya.vip/u/34-34-1324-32432-3431/2323`));
    assert.true(_.isEqual(appendUrl(`https://ekaya.vip/`, `u/34-34-1324-32432-3431/2323/`), `https://ekaya.vip/u/34-34-1324-32432-3431/2323/`));
    assert.true(_.isEqual(appendUrl(`https://ekaya.vip/`, `/u/34-34-1324-32432-3431/2323/`), `https://ekaya.vip/u/34-34-1324-32432-3431/2323/`));
    assert.true(_.isEqual(appendUrl(`https://ekaya.vip/`, ` /u/34-34-1324-32432-3431/2323/`), `https://ekaya.vip/u/34-34-1324-32432-3431/2323/`));
    assert.true(_.isEqual(appendUrl(` https://ekaya.vip/ `, ` /u/34-34-1324-32432-3431/2323/ `), `https://ekaya.vip/u/34-34-1324-32432-3431/2323/`));
    assert.true(_.isEqual(appendUrl(` https://ekaya.vip/ `, ` / `), `https://ekaya.vip/`));
    assert.end();
});

Oh dear, I used npm install uri.js. That is a different library. How dangerous.

Yeah, we may want to talk to @nathggns about his plans for his uri.js package. no change in 3 years sounds like it's dead. IIRC it's possible for his old versions (up to 0.1.3) to remain downloadable, while the never versions (1.x.x) would give you URI.js.

But. Some of my unit tests that worked with my own homemade method fail using urijs.

our tests are passing and I think all permutations of input are handled in there.


Fix accepted hash,Fix <IP_ADDRESS> error

Fixed by d70ba23c884567e9b05af1e43c9a90ea4257b02c

What about accepted hashes?
U didn’t divide it by 256
Y u gonna be so rude

Actually that's the right number of hashes, it always is a multiple of 256. If you log into coin-hive.com you will see your total hashes and they match this number.


Cloud Formation Error on AWS Lambda

When Previewing CloudFormation change set before deployment, i get the error

CREATE_FAILED                         AWS::Lambda::LayerVersion             DependencyLayerd10f9d4ecf             null (Service: AWSLambdaInternal;
Status Code: 403; Error Code:
AccessDeniedException; Request ID:
431229b1-6269-40b9-ad7d-24e4391d693
f; Proxy: null)

Are you using a role when deploying the CloudFormation Stack or does your user/role have permission to manage Lambda Layers?


removing dark mode

📝 Changed routes:

/reception

(view full size)

Commit 100c72a679368a259da3f05c0d52920959a7d9f6 (https://nagato-3o3y2apf8-bookman0001.vercel.app).


Soft gt for 3d and adaptative loader

Oh, could you please also change the order in the undo_transform of resample? thx

Oh, could you please also change the order in the undo_transform of resample? thx

Done :)! I tested it (verify if output is soft), everything looks good


Failed to load the native TensorFlow runtime.

I have installed Tensorflow successfully on my computer but can not load it to use. Please help. Below is stack trace. Many thanks.
Microsoft Windows [Version 10.0.18362.778]
(c) 2019 Microsoft Corporation. All rights reserved.
C:\Users\B>python
Python 3.7.6 (tags/v3.7.6:43364a7ae0, Dec 19 2019, 00:42:30) [MSC v.1916 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.

import tensorflow as tf
Traceback (most recent call last):
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow_core\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow_core\python\pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow_core\python\pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\imp.py", line 242, in load_module
return load_dynamic(name, filename, file)
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\imp.py", line 342, in load_dynamic
return _load(spec)
ImportError: DLL load failed: A dynamic link library (DLL) initialization routine failed.

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow_init_.py", line 101, in
from tensorflow_core import *
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow_core_init_.py", line 40, in
from tensorflow.python.tools import module_util as module_util
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow_init.py", line 50, in getattr
module = self.load()
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow_init.py", line 44, in _load
module = importlib.import_module(self.name)
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\importlib_init.py", line 127, in import_module
return _bootstrap.gcd_import(name[level:], package, level)
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow_core\python_init.py", line 49, in
from tensorflow.python import pywrap_tensorflow
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow_core\python\pywrap_tensorflow.py", line 74, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow_core\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow_core\python\pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow_core\python\pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\imp.py", line 242, in load_module
return load_dynamic(name, filename, file)
File "C:\Users\B\AppData\Local\Programs\Python\Python37\lib\imp.py", line 342, in load_dynamic
return _load(spec)
ImportError: DLL load failed: A dynamic link library (DLL) initialization routine failed.
Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/errors
for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.

@vosybac
What is make/model of your cpu?
I suspect your cpu model does not support AVX instructions sets.See hardware requirements
Make sure to download the latest microsoft visual c++ redistributable from here.
.Also, please follow the instructions from to install from Tensorflow website.
Also, refer similar issues.
#36167 #36151 #36138 #36054 #36045 #36020 #36003 #35988 #35903 #35880 #35865 #35805 #35789 #35773 #35772 #35767 #35766 #35749 #35721 #35618 #35204
Thanks!
Please, check Your CPU/Python is on 32 bits?Please, refer #36167 #38615 and see if it helps you.Thanks!

Closing as duplicate


HLS: Added delay cleanup old expired ts files

Some player start to play from the first ts file, which might be cleanup.
It's better to delay cleanup the ts files. issues #2999

Codecov Report

Merging #3001 (34ad906) into develop (2b2379d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

:exclamation: Current head 34ad906 differs from pull request most recent head 32b58dd. Consider uploading reports for the commit 32b58dd to get more accurate results

@@             Coverage Diff             @@
##           develop    #3001      +/-   ##
===========================================
- Coverage    56.10%   56.07%   -0.03%
===========================================
  Files          153      153
  Lines        57561    57588      +27
===========================================
  Hits         32294    32294
- Misses       25267    25294      +27

Impacted Files
Coverage Δ

trunk/src/app/srs_app_config.cpp
65.38% <0.00%> (-0.18%)
:arrow_down:

trunk/src/app/srs_app_config.hpp
100.00% <ø> (ø)

trunk/src/app/srs_app_fragment.cpp
10.79% <0.00%> (-1.41%)
:arrow_down:

trunk/src/app/srs_app_hls.cpp
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b2379d...32b58dd. Read the comment docs.


Pose per class

Pose interpolation figures created by class. A new variable vis_pose_class configuration is introduced to decide which classes will be interpolated. If not vis_pose_class is provided this step is skipped.
Example for testing with click overwriting:
python run.py --config_file avae-test-config.yml --vis_pose_class 1S3X,3QM1

python run.py --config_file avae-test-config.yml --vis_pos_class 1S3X,3QM1
--vis_pos_class is the right flag


Custom combiner improvements

This PRs contains a few small changes related to custom combiner:
1.Copying aggregate_params before sending them to custom combiner (to prevent changes in the original AggregateParams)
2. Passing AggregateParams in extract_private_output, which simplifies API of custom combiner, now the custom combiner framework would keep AggregateParams instead of the user code.

Thanks!


Merge with parent parent detection not working after a merge happened on main

Hi, I was trying to use merge-with-parent in https://github.com/metallb/metallb
What I think I found was that merge-with-parent doesn't always work when the parent drifted (i.e. because of some other merges).
Let's say we have a working branch from main, and it's possible to merge. Then someone merges another PR into main.
It seems merge-with-parent stops working in that case.
Tried to debug it a bit.
This is how the command looks for the parent:
PARENT_BRANCH=$(git show-branch | sed "s/].*//" | grep "\*" | grep
              -v "$(git rev-parse --abbrev-ref HEAD)" | head -n1 | sed
              "s/^.*\[//")

This is how git show-branch looks like before rebasing a branch:
! [main] Add support to Podman-based kind environments
 * [pull/1005] WIP Do not merge test CI
--
 * [pull/1005] WIP Do not merge test CI
+  [main] Add support to Podman-based kind environments
+* [pull/1005^] Add E2E tests to validate different ip ranges modes (ranges vs cidrs) (#990)

so the lines with main will be filtered out because they do not contain *. The others will be filtered out because they contain the current branch, and the whole command will fail.

Just had the same issue, I think its a bug:
git show-branch
* [circleci-editor/433/main] Add .circleci/config.yml
 ! [main] Merge pull request #3 from luminartech/add_testing
--
*  [circleci-editor/433/main] Add .circleci/config.yml
-- [main] Merge pull request #3 from luminartech/add_testing

git show-branch | sed "s/].*//" | grep "\*"
* [circleci-editor/433/main
*  [circleci-editor/433/main

git show-branch | sed "s/].*//" | grep "\*" | grep -v "$(git rev-parse --abbrev-ref HEAD)" --> EMPTY


Zoom to node

Like ctrl-click on a tab, ctrl-click on a nodeblock

ctrl-click being used for context menu


Build more accurate ranges for time filters

Description

Shortcut story

One option to filter using a time series widget is to select a moment in time (instead of using a range). When this happens, we build a range, using that moment as the start date.
For example, if we are aggregating by day, and the user selects 2020-08-20, we create a range to select all timestamps between 2020-08-20 00:00:00 and 2020-08-21 00:00:00. But this range has accuracy issues:

This is a close range, so if we select 07:04 PM UTC we are not filtering by 07:04 PM UTC, but also by 07:05 PM UTC.
The list we use to build the end of the range, is not accurate. It works for weeks/days/hours/minutes, but for year/months, they aren't a fixed number of milliseconds. We are wrongly assuming a month has 30 days, and a year has always 365 days:

const STEP_SIZE_RANGE_MAPPING = {
  [GroupDateTypes.YEARS]: 60 * 60 * 24 * 365 * 1000,
  [GroupDateTypes.MONTHS]: 60 * 60 * 24 * 30 * 1000,
  ...
};

Type of change

Fix

Acceptance
TODO

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.345%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1949

Relevant Lines:
2513

💛  - Coveralls


[BUG] clipboard js bundling - still uses cdn (privacy violation + prevents offline)

Information:

Prism version: download page
Plugins: clipboard
Environment: browser

Does the latest version of Prism from the download page also have this issue? Yes
Description
When checking the clipboardjs plugin on the downloads page, the resulting bundle still attempts to contact a thirdparty website. This is unexpected, a problem for offline use, a privacy attack, and a security risk.
I recommend removing the plugin from the list to avoid misleading security-relevant behavior, or removing the surprise remote code execution.
Edit: See also https://github.com/PrismJS/prism/issues/2286 . I view this as a security bug , which was what caught our eye.

the resulting bundle still attempts to contact a thirdparty website

That's weird.  Which site/url?

https://cdnjs.cloudflare.com/ajax/libs/clipboard.js/2.0.0/clipboard.min.js

I just bundled all the other plugins, and looks like 2 more potential ones:
-- https://webplatform.github.io/docs/ gets some funny string munging
-- http://www.w3.org/2000/svg some reason
clipboard definitely triggers on pageload

Interesting.  The bundled code tries to require it require("clipboard") but if/when that fails it falls back to dynamically loading it via CDN. I'd say the bundler isn't sequencing things properly or else this expected behavior - though I would agree it seems quite unexpected to me.  If I chose to build with clipboard functionality "built-in" I would expect that to be part of the bundle, not fetched via CDN later.

Ouch, so it's known, intentional, and hidden 😅
I recommend fixing the plugin download to be a plugin download, removing it from the download list, or keeping it in the download list and notifying the downloader that it isn't actually being downloaded etc

I can't speak for the core team, but I see both sides here.  Prism.js is only bundling ITSELF (and it's plugins).  It's not promising to bundle the world or EVERY necessary dependency.  If a plugin depended on jQuery or React I wouldn't expect those to magically come bundled... but I do think that just loading it randomly is potentially surprising behavior.    Perhaps an error should be raised instead.
Curious to see where this issue goes. :)

We use Clipboard.js because there is no easy cross-browser way to copy text into the user's clipboard.
I think the easiest solution here is to eliminate the dependency. Implementing our own copy to clipboard functionality will be a lot easier than making our download page a general bundler. (Our download page isn't a bundler like Rollup. It can only resolve dependencies between languages using Prism's own dependency system.)
Thoughts?
/cc @mAAdhaTTah

I just bundled all the other plugins, and looks like 2 more potential ones:
-- https://webplatform.github.io/docs/ gets some funny string munging
-- http://www.w3.org/2000/svg some reason

The WPD plugin only creates links to those sites, it doesn't directly connect to them.


one document about how to add one infra/deployment type support.

I doubt whether it's a valid scenario, in my option, infra/deployment type is well-defined previously, and typical manifest contributors shouldn't change that.

@norshtein  I mean how to add something like the jmeter or jenkins or something else.


Support merge small files in multi insert statement

Why are the changes needed?
This PR aims to support auto merge small files in multi insert statement, for example
FROM (SELECT * FROM VALUES(1) DOSTRIBUTE BY col1 ) INSERT INTO tmp1 SELECT * INSERT INTO tmp2 SELECT *;
will generate the following plan, Union is the root node instead of InsertIntoHiveTable
Union
:- InsertIntoHiveTable
:  +- Project
:     +- SubqueryAlias __auto_generated_subquery_name
:        +- RepartitionByExpression
:           +- Project
:              +- LocalRelation
+- InsertIntoHiveTable
   +- Project
      +- SubqueryAlias __auto_generated_subquery_name
         +- RepartitionByExpression
            +- Project
               +- LocalRelation

This PR also fix the canInsertRepartitionByExpression, previous did not consider the SubqueryAlias which may cause inserting error Repartition/Reblance node to currupt the data distribution.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

cc @ulysses-you @cfmcgrady

Codecov Report

Merging #1974 (56cd773) into master (6d757a3) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1974      +/-   ##
============================================
- Coverage     60.45%   60.38%   -0.08%
  Complexity       69       69
============================================
  Files           305      305
  Lines         14862    14867       +5
  Branches       1918     1921       +3
============================================
- Hits           8985     8977       -8
- Misses         5110     5119       +9
- Partials        767      771       +4

Impacted Files
Coverage Δ

...ache/kyuubi/sql/RepartitionBeforeWritingBase.scala
0.00% <0.00%> (ø)

...rg/apache/kyuubi/engine/trino/TrinoStatement.scala
65.06% <0.00%> (-4.82%)
:arrow_down:

...mon/src/main/scala/org/apache/kyuubi/Logging.scala
39.72% <0.00%> (-1.37%)
:arrow_down:

...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala
83.48% <0.00%> (-0.92%)
:arrow_down:

...ala/org/apache/kyuubi/session/SessionManager.scala
85.12% <0.00%> (-0.83%)
:arrow_down:

...in/scala/org/apache/kyuubi/config/KyuubiConf.scala
96.26% <0.00%> (-0.15%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d757a3...56cd773. Read the comment docs.

Thanks, merging to master


highwire update

I think
url = '%s/T%d.expansion.html' % (content_url, t_num)
should now just be
url = '%s/T%d' % (content_url, t_num)
for high-wire source.

Thanks! Probably won't get around to patching and testing this for a while, but will keep it in mind next time I update the DB.

No worries. Patched in my fork. Should push soon.
On Feb 21, 2017 2:10 PM, "Tal Yarkoni"<EMAIL_ADDRESS>wrote:

Thanks! Probably won't get around to patching and testing this for a
while, but will keep it in mind next time I update the DB.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/neurosynth/ACE/issues/3#issuecomment-281498148, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGPHib8Afdz45lCz21kyGVWHZLEZjvzzks5re2DSgaJpZM4MFvJo
.


Hardhat: Use sapphire and sapphire-testnet for network names

Make Hardhat network names consistent with the ones that are registered in the Ethereum chain list. This is currently:

sapphire
sapphire-testnet
emerald
emerald-testnet

In the future, we may want to register sapphire-localnet and emerald-localnet as well, rename the docker image from sapphire-dev -> sapphire-localnet and update the contracts CI scripts accordingly.

In the future, we may want to register sapphire-localnet and emerald-localnet as well, rename the docker image from sapphire-dev -> sapphire-localnet and update the contracts CI scripts accordingly.

Makes sense.


Translation Related

Hey, guys! I have notice that some of the document doesn't have a Chinese Version. I want in and do some document translate stuff for community. How can I get to do that, I can't find any words about it in docs.

@SonjaSaltzman could you take a look at this request, please.

Hello @kongxiangyan ! Our official guidelines are posted here: https://docs.microsoft.com/zh-cn/contribute/ .  As the article mentions, not all content is open to contribution.  If you would like to request to have specific articles translated, please open a GitHub issue on the English article; for example, if you would like this topic https://docs.microsoft.com/en-us/azure/virtual-machines/windows/sql/virtual-machines-windows-sql-server-iaas-overview translated to some not-yet-existing language, you could open a GitHub issue by requesting translation by clicking this button:
 and requesting translation.
cc @SunnyDeng

@kongxiangyan do you have any additional questions or concerns before we close this?

Thanks for your reply! It's pretty helpful to tell me that I can contribute in some way! I have no problem now.


tree-sitter: 0.19.5 -> 0.20.0

Motivation for this change
https://github.com/tree-sitter/tree-sitter/releases/tag/v0.20.0
Things done
Change version and update the grammars (from within the tree-sitter package source):
  # 1) change all these hashes
  # 2) nix-build -A tree-sitter.updater.update-all-grammars
  # 3) run the ./result script that is output by that (it updates ./grammars)

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 128759 at 09ccbff7 run on aarch64-linux 1

2 packages built successfully:

rizin
tree-sitter

1 suggestion:

warning: unused-argument
Unused argument: fetchurl.
Near pkgs/development/tools/parsing/tree-sitter/default.nix:5:3:
  |
5 | , fetchurl
  |   ^

This would be very useful to merge before Friday's neovim 0.5.0 release (#110837)


Recipe Image Selection

Add the ability for users to upload an image to use as the picture for recipe
Implement search functionality to find pictures to use for recipe thumbnails

Out of scope


fix(tray): Vertically center in inner bar area

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[x] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Other: Replace this with a description of the type of this PR

Description
The tray should be vertically centered in the inner area of the bar. Unequal top and bottom borders should not affect the alignment relative to other text.
Related Issues & Documents
Fixes #2950
Documentation (check all applicable)

[ ] This PR requires changes to the Wiki documentation (describe the changes)
[ ] This PR requires changes to the documentation inside the git repo (please add them to the PR).
[x] Does not require documentation changes

Thanks for the quick fix :)


Show focus ring set to false, ring still here

Hi,
This issue is in fact two issues:
Here is my actual button:
<x-bladewind.button show_focus_ring='false' button_text_css='font-black' border_width='2' uppercasing='false' outline='true' size='small' tag='a' href="{{ route('manage.images') }}">Manage Images</x-bladewind.button>

I decreased the border_width, and disabled the focus ring.
The focus ring still shows up, even though I disabled it:

And for the second issue, the focus ring is a bit too thick, but the main issue is that it is white, and not a shade of the button's color.

I have found where the issue is from.
It is from the bw-button class. I cannot edit this because it is in a .min.css file.
The white I see is a box-shadow. It would be great to make it dark when dark theme is enabled in tailwind, with dark:.
I am wondering, why would that button class be defined in

Do let me know if you’re still experiencing this in v2.5.2?

@BeBel42 will push a fix for this soon

Do let me know if you’re still experiencing this in v2.5.2?

Yes it still does that

@BeBel42
Okay.. fixed but working on a few other fixes and I'll push an update.
To answer your earlier question...
I maintain the classes for the button and a few other components in an external css file because it's easier to manage. Those specific components have a lot of conditions that make maintaining the classes inline quite tedious.

@BeBel42 this is fixed in 2.5.3.
composer update


flutter-dashboard.appspot.com dashboard is down: Not found: /index.html 404

https://flutter-dashboard.appspot.com 404:
Not found: /index.html

Not an issue.

From Discord:
@drewroengoogle: "It looked like the dashboard traffic was splitting to two versions of dashboard, and one of them was causing a 404, so I switched the traffic to all point to the most recent build"
@ricardoamador: "Yeah that was me. Testing some changes to our transactions to Datastore."


Web tutorial for Msig Txn

The tutorial should show the whole flow, not only a case where you have all the keys.

Yes the tutorial works in both cases:
If user has a partially signed txn to sign and send to network
or if it is a new one

The tutorial should show the whole flow, not only a case where you have all the keys.

Yes the tutorial works in both cases: If user has a partially signed txn to sign and send to network or if it is a new one

Could you better describe it in the tutorial? What a user should do to send partially signed transaction to a peer for another signature? Please add this as new steps (before sending the transaction to the network).
So the flow should be:

Alice creates transaction and packs it into msig and signs
Alice sends the serialized transaction to Bob (explain how she should encode it)
Bob decodes transaction and appends signature
Bob submits tx to the Algorand blockchain


Support for explicitly setting no compression via option

#281
This PR adds the support for compression options, uncompressed and none to explicitly set no compression codec.
Also, I mistakenly forgot to add DeflateCodec before. This PR also adds the compression codec.

Although I am not too sure if both uncompressed and none are what this library must need, I still think it is good to have.

If this is merged (if you think this is needed), then I will also submit a PR to spark-xml as well.

Current coverage is 86.47%

Merging #283 into master will decrease coverage by -0.19% as of 34b7cfc

@@            master    #283   diff @@
======================================
  Files           12      12
  Stmts          540     562    +22
  Branches       160     162     +2
  Methods          0       0
======================================
+ Hit            468     486    +18
  Partial          0       0
- Missed          72      76     +4

Review entire Coverage Diff as of 34b7cfc

Powered by Codecov. Updated on successful CI builds.

The commits I just submitted include removing the  broad side-effects and some tests for that, and move codec validation into saveAsCsvFile() just like other options.
As saveAsTextFile() does not accept Hadoop configuration as a parameter, it just resembles the internal logics in saveAsTextFile() by calling saveAsHadoopFile().
In saveAsCsvFile(), case clause deals with the cases below:

codec is set to uncompressed/none :  In this case, make it ignore the existing compress configuration of Hadoop but write output as uncompressed without side-effects.
codec is set to other compress codecs :  Set compress configuration by codec.
codec is not set :

compressionCodec is given as a parameter: Set compress configuration by compressionCodec .
compressionCodec is not given as a parameter: Do not set anything but follow the existing compress configuration of Hadoop.

I had to change pretty a lot of codes and it looks a bit messy (partly because this one does not implement HadoopFsRelation).
I feel like maybe, it does not necessarily have to deal with the cases for none and uncompressed even if this behaviour is not identical with Spark one...

The commits I just submitted include removing the  broad side-effects and some tests for that, and move codec validation into saveAsCsvFile() just like other options.
As saveAsTextFile() does not accept Hadoop configuration as a parameter, it just resembles the internal logics in saveAsTextFile() by calling saveAsHadoopFile().
In saveAsCsvFile(), case clause(L193-L209) below:
maybeCodecClass match {
  case Some(codecClass) if codecClass == null =>
    // This case means `codec` is set to `uncompressed` or `none`. In this vase, explicitly
    // set the output as uncompressed and ignore existing Hadoop compression configurations.
    CompressionCodecs.disableCompressConfiguration(hadoopConfiguration)
    hadoopPairRDD
      .saveAsHadoopFile(path,
        classOf[NullWritable], classOf[Text], classOf[TextOutputFormat[NullWritable, Text]],
        hadoopConfiguration, None)
  case _ =>
    // If no compression codec is set in `parameters`, then use `compressionCodec` here.
    val safeCodecClass = maybeCodecClass.orElse(Option(compressionCodec))
    hadoopPairRDD
      .saveAsHadoopFile(path,
        classOf[NullWritable], classOf[Text], classOf[TextOutputFormat[NullWritable, Text]],
        hadoopConfiguration, safeCodecClass)
}

deals with the cases below:

codec is set to uncompressed/none :  In this case, make it ignore the existing compress configuration of Hadoop but write output as uncompressed without side-effects.
codec is set to other compress codecs :  Set compress configuration by codec.
codec is not set :

compressionCodec is given as a parameter: Set compress configuration by compressionCodec .
compressionCodec is not given as a parameter: Do not set anything but follow the existing compress configuration of Hadoop.

I had to change pretty a lot of codes and it looks a bit messy.
I feel like maybe it does not necessarily have to deal with the cases for none and uncompressed even if this behaviour is not identical with Spark one...

I am closing this because I am not too sure if this change is safe and I feel this is trivial.


Add information page

To make page more clear for non github users create a information page for each incident which shows detailed updates (chat).
Also spice up the incident card with icons and counts (informations,...)

I will do this improvement.


Confidence range for inference using python library

Hi,
First of all, thank you so much for such a convenient setup to use!
I'm using the python library face emotion in my code with the model_name = 'enet_b0_8_best_afew'.
I was wondering what is the range of the confidence returned by the library or this model in particular.
I wasn't able to figure that out.
Thank you

Could you kindly clarify what do you exactly mean by "the range of confidence"? It is rather hard to estimate the confidence interval without relation to a concrete dataset. I tested my models on several datasets, and their accuracy varies significantly, though extracted facial features can be classified rather accurately (compared to the state-of-the-art) in all cases. In the main readme file of repository you could see the quality metrics for different models. If you want to apply the model as-is without training a classifier, then I should say that EfficientNet-B0 models should be used. I experimentally noticed, that enet_b0_8_best_vgaf and enet_b0_8_va_mtl are usually the best models, and enet_b0_8_best_afew has similar but slighly lower accuracy.

Oh, I meant the confidence with which emotion is predicted like a range of 0.00 to 1.00 but I think I got it the number shown beside the label is the accuracy scores for the emotions.

Thanks, I hope I understand the question. By default, the PyTorch models return logits - output of the last layer before applying softmax. If you want to compute "probabilities", you need to apply softmax to the outputs of this model. It is an easy call of get_probabs() function (see example in abaw4_mtl_train.ipynb). But my HSEmotion library supports special flag logits, so you can call fer.predict_emotions(face_img,logits=False) to get values between 0 and 1 with sum equal to 1. Please, see example

Got it. Thanks!


xmrig: 6.19.3 -> 6.20.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/xmrig/xmrig/releases.
meta.description for xmrig is: Monero (XMR) CPU miner
meta.homepage for xmrig is: https://github.com/xmrig/xmrig
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 6.20.0 with grep in /nix/store/2mz2z3r8siiaahcv3697axbciadx9751-xmrig-6.20.0
found 6.20.0 in filename of file in /nix/store/2mz2z3r8siiaahcv3697axbciadx9751-xmrig-6.20.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
xmrig

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/2mz2z3r8siiaahcv3697axbciadx9751-xmrig-6.20.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A xmrig https://github.com/r-ryantm/nixpkgs/archive/983f896bf4ed35dbf1fc25041de8c11b2d20ce5b.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/2mz2z3r8siiaahcv3697axbciadx9751-xmrig-6.20.0
ls -la /nix/store/2mz2z3r8siiaahcv3697axbciadx9751-xmrig-6.20.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

xmrig

Maintainer pings
cc @kim0 for testing.

https://github.com/xmrig/xmrig/issues/3305

@MrFoxPro
I don't have any mining rigs anymore, but feel free to ping me if this version fixes you issue. If not, I can debug it later.

@MrFoxPro
I don't have any mining rigs anymore, but feel free to ping me if this version fixes you issue. If not, I can debug it later.

Unfortunately, I already tried 6.20.0 myself and issue was same

And it seems to be related to hardening flags. Which is odd because I don't think any hardening flags were enabled (just searched for fortify3 though)


chore(main): release 0.8.0

:robot: I have created a release beep boop
0.8.0 (2023-04-26)
Features

Add calculating Tanimoto similarity #117 (c64f931)
Add display Tanimoto similarity matrix #131 (2ed0db3)
Add npscore and depict tests (14be128)
check and standardize molecules. #118,#119 (a7f8548)
return standardized SMILES with more info as distionary, minor bug fixes (a195543)

Bug Fixes

linter issues (6e8a2e2)
Naming conventions and descriptions. Fixes: #121,#122 and #123 (112b68f)
update pytest run (79f5fc4)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Steinbeck-Lab/cheminformatics-python-microservice/releases/tag/v0.8.0 :sunflower:


Repalce "torch._six.string_classes" with "str" in neuromorphic_dataset.py

Since Pytorch dropped support for _six module, the line https://github.com/jeshraghian/snntorch/blob/bf763fdf5138e976b085a700cc12e6ec3f5d1a44/snntorch/spikevision/neuromorphic_dataset.py#L145C9-L145C56 throws erro with the latest Torch and Python versions.

The datasets module has been deprecated, as Tonic is a far more useful dataloader.


Fix memory leaks

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?
Significant memory leakage
What is the new behavior?
Significant reduction in memory leakage
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

Hello 👋
As part of our project, we are using Facebook's new Memlab tool to detect memory leaks in SPA applications and their libraries. While running the tool and analyzing the code of ngx-datatable, we saw that your project does a very good job of ensuring that all async operations are cancelled when components destroy. However, as per Memlab execution results, we found some dangling animation frame requests, timeout calls and QueryLists, that were causing the memory to leak (screenshots below).
[before]

Hence we added the fix by clearing the frame requests, timeout calls and querylists in destructor, and you can see the heap size and # of leaks reducing noticeably:

Note 1. Host listener is used to ensure that ngOnDestroy is called not only when the class destroy, but also when the page refreshes, tab or browser closes or the user navigates away from the page[1]
Note 2. Static property is used to avoid losing the context of the correct ‘this’ in case any nesting changes are made to the enclosing function in future.
We executed the test suite before and after the changes, where it executed 126 of 129 (skipped 3, TOTAL: 126 SUCCESS) in both cases.
You can analyze this and other potential leak sources, if you like, by running Memlab with a scenario file covering the maximum # of use cases.
Following is a sample of the scenario file we used (it needs to be a .js file but attaching here in .txt form):
ngx-database-scenario-memlab.txt
Note that some other reported leaks (in Memlab) originated from Angular's internal objects, hence were ignored.
Reference.
[1] https://wesleygrimes.com/angular/2019/03/29/making-upgrades-to-angular-ngondestroy.html

bump @haeminn


Call to undefined method App\User::dataTableQuery()

I've been trying to use this VUE component, though I keep getting the error in the title when following the instructions on the package.
ServiceProvider has been added aswell as adding "DataTableCollectionResource" to the Controller itself.
Is there something I'm missing out on?

Hey,
I'm guessing you may have missed adding the Trait to the model.
More information can be found here
Let me know if this isn't the case.

From what I understood the trait was optional. However I got it working now, might have been me not understanding what you meant.

No you are correct, the trait is optional but you would then need to filter the data yourself and paginate the results for the "DataTableCollectionResource" to use.
Thanks for bringing that to my attention and i'll try to make the README easier to digest.


Create NodePort service from within driver pod

We want to delay the service creation to do it within driver code, so that we don't use up NodePorts when the driver pod is still pending.
One caveat is that there is a time delay between creation of the service and to when kube-proxy opens up the requisite ports on the nodes. We would want to ensure that we have the necessary retry/waiting logic as well.

@foxish is this to minimize the amount of time in which a service exists but is not in use?
Can you create a watch on a service that doesn't yet exist?  If so that could serve as the triggering mechanism connecting driver ready with service exposed -> spark-submit should upload jars and config.

This would require the KubernetesSparkRestServer to create the service and for the REST Server to agree with the Client on the labels the service is going to have. I'm uncertain if the upside for reducing the amount of time the NodePort is alive is worth the complexity we introduce here. Currently the KubernetesSparkRestServer does not have any interaction with Kubernetes at all, and it would be nice to keep the REST server as simple as possible, and to keep the lifecycle of the required K8s components in as few places as possible.
We only create the NodePort service after the driver container has started running, as the driver pod Watch listens for the container to begin running before it builds the service. Is there any reason to believe that the delay would be significant?

We only create the NodePort service after the driver container has started running, as the driver pod Watch listens for the container to begin running before it builds the service.

Ah. I haven't seen the Nodeport PR in detail yet and my issue was based on the old behavior which creates the service before creating the pod. Closing this issue.


Support case-insensitive string sorting

Is it possible to get query results sorted in a case insensitive way so that:
Cat (capital C)
comes before cow (lower case c)?
Thanks

That's not currently possible, but I've updated this ticket to track adding that functionality.
In the meantime, you could store a case-normalized version of the property you want to sort on in your model and sort on that.

thank you

What comparator is realm using when sorting strings?
Let's assume, I have several objects that have the following value for the property name:
"hello"
~hello
hello
Hello
ello
éllo

When I sort these values, using realm, the order will be the following:
|hello
~hello
ello
Ello
éllo
hello
Hello

I do understand that the uppercase names will always be placed after their lowercase equivalent. That makes sense.
However, I do not understand why "hello" and |hello are sorted to the beginning and why éllo is not placed at the very bottom. I would expect that since this would be the order of their respective unicode codes.

@tschubotz Realm has limited Unicode awareness when sorting strings, which is to say that all strings are sorted according to an en_US.UTF-8 locale, and not UTF-8 encoded byte value order.
We are aware that this is lacking for a wide range of use cases, but a proper solution to string sorting (including case-insensitivity) requires quite sophisticated locale support, which is something we are still designing.
I hope that answers your question. :-)

Sorting simply according to increasing unicode values would be very wrong in most countries. For example, there exists three symbols with unicode values Å = 197, Æ = 198, Ø = 216. However in the danish language you traditionally sort them Æ, Ø, Å.
Realm will sort unicode symbols 0...591 (upto and including Latin Extended 2) in the english ("en") locale. This gives the sorting order that you quoted, which is the correct order for most countries that have the letters "é" and "h" in their alphabet.
Our method is not perfect, though. There are minor flaws for some letters in some countries.

Wow, I am just switching to Realm today and this is kind of a big deal. Seems like I will have to store two of almost every property in my database. Has this changed at all since January of 2016?

@mommyme No, this hasn't changed since that date.

any progress on the topic since the question was raised in 2015?

@Heki2017 Unfortunately not. We are not prioritizing features by the date they were created. Although this is something we surely would like to support there are (still) other bugs or features that are more requested for the time being.

Any movement on this? It's been just over 5 years since this was opened. Not having a basic feature like this is pretty surprising. Foundation has localizedCaseInsensitiveCompare(_:). Seems like this should be the default string sort behavior anyways.

I was using LexoRank to sort my documents in FireStore, this is quite important for my project, any updates?

uh, still no realm-native lowercase sorting in 2024?

Good lord, this has been open for a decade.
 A `SortDescriptor` stores a key path and a sort order for use with `sorted(sortDescriptors:)`. It is similar to
 `NSSortDescriptor`, but supports only the subset of functionality which can be efficiently run by Realm's query engine.

If I may be so bold: a query engine that can't do case-insensitive sorting is a broken query engine. This is what Realm produces:
Adam
Bob
Susan
Vicky
allison

The only suggested workaround is to exponetially bloat your database size by storing a lowercased version of every single property you might want to sort. Great.

This is what developing with Realm often feels like. Imagine Realm is a car. It has:

Full self-driving.
Seats that massage your back.
A top speed of 498mph.
A gas tank that fills itself up automatically.

And:

No reverse.

You: "How do I get it out of my garage?"
Mongo: "Rope."

Another option is to generate the index field in memory


Feature/build script adjustments

These are mostly follow-up improvements/fixes of the earlier major build script refactor:

apply Spring Boot plugin to example apps (allows running them via bootRun Gradle task)
disable publishToMavenLocal task for example-spring-common
update deprecated compile scope to implementation (example-webflux)
use https instead of http for Artifactory
update deprecated Gradle dependency configuration in readme

Thanks a lot!


Small messaging improvements

These two text updates are based on things we've seen users struggle with in slack/support etc.
The first is a recurring issue with people setting their blog to private and not realising this disables the RSS feed.
The second is that when on the CLI it's only possible to know you're in production mode by the absence of a mode message, making this explicit makes it easier to debug as you always know what mode you started in.
no issue

update private blogging description to explicitly mention RSS
change startup message to explicitly mention production

@JohnONolan updated :wink:


Allow usernames containing an exclamation mark

The JdbcScimUserProvisioning has a check for valid usernames defined using the following regexp "[a-zA-Z0-9+\-_.@']+" which prevents username with "!" in it...and more. Is there any way to relax the constraint to allow for more characters in the username.

Thanks for the issue,we could express that pattern as a configuration variable to allow for more options

What's the scenario when this relaxation is needed? If we allow extract this pattern to a config option, how should UAA act when we change said option such that the change invalidates existing, previously valid user names?

Any updates here?

@michaljemala This issue has been prioritized in the public tracker.

@michaljemala we are working on this right now. If you weren't aware, you can change the pattern through config!

This is has been fixed in development and will be part of future releases


package print AUTH repeatly with not action

When I use storage sometimes my app just print AUTH many times and never start working.
I'm worried about that what if I lose my users login authentication. If I lose them, I lose a lot of money.
please answer fast , Did I losed them or it is just a bug of package and can be solved?

@Alavi1412 why you use alpha version in production?

so what is the last version?
I use @latest to install the package but It says AUTH_KEY_UNREGISTERED


update windows_service config file

What does this PR do?
Changes the windows_service integration config file. Previously it had implied that exact matching is done, when actually keyword.* matching is done. Specifies that you should use ^keyword$ if you want exact matching.
Motivation
Support request h/t @HadhemiDD
Additional Notes
Review checklist (to be filled by reviewers)

[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] Feature or bugfix must have tests
[ ] Git history must be clean
[ ] If PR adds a configuration option, it must be added to the configuration file.

@cswatt you should also update the default configuration file with this: https://github.com/DataDog/integrations-core/blob/master/windows_service/datadog_checks/windows_service/data/conf.yaml.example#L10

👋

Bump 😉


Commit messages history in Quick Commit input

Allow to select a previous commit message using Up / Down keys like in the Search / File Search dialog

I think this might be possible, by using the autocomplete API. But at the same time, i think it enforces terrible git habits and shouldn't be done. Why would you want multiple commits with the same message?


Self-host runner information should be provided as per-repository configuration data.

Describe the bug
Currently the CI/CD pipeline used hard-coded self-hosted runner information (runner service names and the associated test runner vm names) as listed the the ebpf-for-windows\scripts\test_execution.json file.
This requires down-stream forks of ebpf-for-windows to use the same names in their own self-hosted runner setups.  This information should really be ingested as a per-repository configuration data and the required test_execution.json file should be generated on-demand from this data.
(The <repo-name>\settings\environment facility can be used to store the per-repo self-host runner information in the current json format as a string. This string can then be converted to a test_execution.json file at the start of the CI/CD workflow).
OS information
No response
Steps taken to reproduce bug

Create a self-hosted runner setup custom names for a down-stream fork <repo-name>\ebpf-for-windows.
Try to run the CI/CD workflow on this setup.

Expected behavior
The workflow should use the custom runner setup to schedule CI/CD jobs.
Actual outcome
The Workflow fails as it cannot find the runners specified in the hard-coded self-hosted runner information.
Additional details
No response

Noting InstallEbpf.md should also be updated accordingly.


Simplify Interface

Requested by Barb. This may be implemented via toggle

[ ] Find Charlie's interface designs
[ ] Re-create our own interface designs
[ ] Decide on whether two modes are required

https://miro.com/app/board/uXjVKNJUfxU=/

TODO: create sub-tickets for design, and the different components of an implementation


Remove Lagon runtime tests

What is the feature you are proposing?
Lagon has joined Vercel!
Lagon will be closed. So, the adapter the runtime tests are not needed. We can make remove them in v4.

cc: @QuiiBz
We will do that!

Sounds good, thanks for flagging this!

Closed by #1971