Colorpicker doesn't work in Firefox

Hi;
I am using the code below:

                                    <input colorpicker colorpicker-with-input="true" type="text" ng-model="option.value" class="form-control" />

In chrome, I can select colors from color-picker, but in Firefox, I cannot.
CSS and js files are loaded. Where am I wrong?

hey can you download the latest version? Bugfix was released today, so maybe this case is already resolved.

I have 3.0.16. Which is the latest version?

yep that is the latest version. I tested your example and it is working in FF, any more details?

Maybe it is because of the scripts include locations. I included:
  <link href="assets/global/plugins/bootstrap/css/bootstrap.min.css" rel="stylesheet" type="text/css" />
<link href="lib/angular-bootstrap-colorpicker/css/colorpicker.min.css" rel="stylesheet" type="text/css" />

css like this. And js:

between the head tags.

I don't think so it's the case. can you upload your example somewhere? or create a codepen?

I've reproduced the problem in FF with bootstrap-colorpicker-module.min.js.  bootstrap-colorpicker-module.js works well.

Interesting. I'm using

thanks @PeterTim, I forgot to run build after last PR, file updated

I met the same problem in FF today.
Just copied the simplest color picker from CodePen

I am using the latest js file and it works fine in Chrome. But in FF, wherever I clicked inside the sliderSaturation, the color stuck to #000000.
Any idea what might happened?

Submitted a PR with a possible fix for Firefox (Tested in FF 37.0.2). Feature still works in other major browsers.

It works. Thanks @llattes
-Tested in FF 37.0.2 and other browsers(Safari Opera Chrome)

@Angel-AOL I submitted a new PR (#95) that does not depend on jQuery to do the trick. It should work like the previously suggested fix.

Hey, #95 looks good for me in general, but I couldn't reproduce this bug in FF. @Angel-AOL can you confirm that #95 is OK? thanks

@llattes @buberdds
I overwrote previous bootstrap-colorpicker-module.js with the new .js file to do the test. The bug re-appeared. Same as I described before. in FF 37.0.2.

@Angel-AOL Are you sure you grabbed the file with the changes corresponding to PR #95 ?
I experienced the same issue than you and with both fixes I suggested the bug is gone. Can you verify the .js you're testing has the following lines?
// Polyfills for making https://github.com/buberdds/angular-bootstrap-colorpicker/issues/93 work properly
var offsetX = (event.offsetX || event.pageX - (event.target.offsetParent.offsetLeft + event.target.offsetLeft));
var offsetY = (event.offsetY || event.pageY - (event.target.offsetParent.offsetTop + event.target.offsetTop));

I re-tested the fix using several VMs and it worked fine. I tested combinations of Win 7/8 with IE11, FF 36, 37 and 38 Beta and Mac with FF 37 and Chrome and found no problems.
I also verified the output of the polyfill in Chrome and it returns the same value than event.offsetX.
Finally, I replaced my colorpicker (which uses options like colorpicker-with-input="true" colorpicker-position="bottom") by the simple example @Angel-AOL provided (<input colorpicker ng-model="hexPicker.color" type="text">) and it worked too.
Sorry I insist with this, it's just that I forked the project to go live with this fix but would like to move back to the original project once a new release is shipped.
@burakkilic @PeterTim Could you also give the code in #95 a try?
Thanks!

Yes, it seems to work fine.Thank you.

@llattes Yes I included those lines. I copy/paste
// Polyfills for making https://github.com/buberdds/angular-bootstrap-colorpicker/issues/93 work properly
var offsetX = (event.offsetX || event.pageX - (event.target.offsetParent.offsetLeft + event.target.offsetLeft));
var offsetY = (event.offsetY || event.pageY - (event.target.offsetParent.offsetTop + event.target.offsetTop));

to replace previous
          var offsetX = (event.offsetX || event.pageX - $(event.target).offset().left);
          var offsetY = (event.offsetY || event.pageY - $(event.target).offset().top);

I am using it inside the modal component of angularUI bootstrap. Could it affect anything here?
my code is as below:

...

         <input colorpicker colorpicker-parent="true" type="text" ng-model="show.pagebackground.color" style="width:100%"/>

Any idea?

@Angel-AOL I'm using the component inside a modal too but cannot tell if it could be affecting.
There's another way of calculating the offset, using the existing getOffset function that's located at the top of the module file. Maybe you can give it a try since it works for me in every browser too.
The idea is to replace the offsetX and offsetY variables with the following code:
var offsetX = (event.offsetX || event.pageX - targetOffset.left);
var offsetY = (event.offsetY || event.pageY - targetOffset.top);

It's simpler to read and relies on existing code. It would be helpful if you can debug the code a bit with Firebug to see if you find something strange.
Thanks again!

Actually the reason it doesn't work is because of the colorpicker-parent="true". It does work on Chrome, but somehow it doesn't on Firefox.
Do you have any idea how to make it work ?

I hope it's fine now.

I'll give your change a try and get back to you soon!

Thanks for your time and your help guys.


Xcode 11.2.0 and 11.3.0 will be deprecated on Catalina image on May 13

Hello everyone,
Recently, we have added Xcode 10.3 and Xcode 11.4.1 on Catalina image. Xcode 11.5 beta will come very soon.
To simplify image maintenance and reduce image generation time / image size, we would like to deprecate Xcode 11.2.0 and 11.3.0 from our images.
Our images will keep Xcode 11.2.1 and 11.3.1 (they are fully compatible because patch version doesn't bring any breaking changes) and we will create symlinks from Xcode 11.2.0 -> 11.2.1 and 11.3.0 -> 11.3.1.
Please let us know if you have any concerns / objections

Images with changes were deployed everywhere


Problem with ModelFactory class while loading ChexNet-keras.h5 pretrained file

ValueError: You are trying to load a weight file containing 242 layers into a model with 241 layers.

You need to load model weights after adding one Dense layer. Try this -
densenet = tf.keras.applications.DenseNet121( include_top=False, weights=None, pooling='max',input_shape=(128,128,3) )
input_shape = (128,128,3)
x = densenet.output
predictions = Dense(16, activation="sigmoid", name="predictions")(x)
model = tf.keras.Model(inputs=densenet.inputs, outputs=predictions)
model.load_weights(weights_path,by_name=True, skip_mismatch=True)


Don’t show post button while publishing a post

While a post is being published, two buttons are shown: ‘Cancel‘, and ‘Post‘. However, the ‘Post’ button doesn’t (and shouldn’t work), so it should not appear in this state.

I think it should appear disabled. We'll fix that for the next update.

Done.


[Feature Request] Support item with custom lore and display name

It would be great if you support custom lore and display name and same material item which only differs display name or lore or attribute or anything
And This plugin needs to be arranged by shop name or anything. If there are too many item list on that website, it is confusing for player

Custom display name and lore item doesn't appear properly at the website

Please fix this bug and support custom item name and lore

This is not a bug, you are requesting a new feature. Like I said in Discord, I may get around to implementing this feature request when I have time.

pleeease, I really need this feature, I have waited for this update for a month


CLAS,ENHO: Post methods inactive and empty after repository pull

Hello, I am having issues with a bug, everytime I do these operations I always have to manually re implement everything.
My package X has an online repository.
I created a few enhancements post methods for the classes of my package X in package Y.
When I pull package X, all my enhancements become inactive and the post method is gone.
Can you please try to recreate this scenario and see if it can be fixed?
Thanks

sorry, no one here has time to setup test cases like this. please provide a repo that we can use to reproduce the issue.

I can confirm this is a bug. And I had it also occasionally, but somehow forget to file a bug report. Anyhow, as I'm also interested in getting this one fixed (though thinking that won't be an easy one) I prepared two test repos.
First one contains the class.
https://github.com/christianguenter2/CLAS
Second the enhancement enhancing the class via post-exit and implicit source code enhancement.
https://gitlab.com/christianguenter/test_enho_clas
Class looks like this after cloning both repos.

The issue can be reproduced with switching to branch test in the first repo and pull.
Then the post-exit disappeared.

And the enhancement is inactive.

After activating the enhancement manually, this diff appears and selective pull recreates the enhancement.

Note that the implicit source code enhancement is not affected.
@simonegaffurini is your package Y also managed by abapGit? If yes you can use it to recreate the enhancement.
Some notes which might help fixing the issue
CL_ENH_FACTORY=>FIND_ENHANCEMENTS can discover the enhancements

Whereas SEO_CLASS_TYPEINFO_GET just reveals the generated enhancement attribute

Thanks for the examples! It can be reproduced with a single repo by switching between main and test branch:
https://github.com/mbtools/CLAS
Fix coming up

@simonegaffurini & @christianguenter2 : can you help testing the fix from @mbtools in https://github.com/abapGit/abapGit/pull/5810 ?

Hello, thank you @christianguenter2 for the test repo and @mbtools  for the fix.
@larshp I tested it and it seems to work fine.
Unless you want to do more tests, this issue can be closed


TableViews Change Color! and more...

tableView cells now change their font color: Blue for "UNCHANGED!" and red for "CLEAR!"

Fixed issue where switching from scopes view to inventory view causes index out of range.
Added globalTab to make this work.

Found a great article from Apple about supporting dark mode: https://developer.apple.com/documentation/appkit/supporting_dark_mode_in_your_interface
Was able to use that to easily add programmatic text colors


Maximized Window is "Always on Top" when IgnoreTaskbarOnMaximize=True. Window remains "Always on Top" on Restore

What steps will reproduce this issue?

Open Markdown Edit, press F9 and ensure IgnoreTaskbarOnMaximize is true.
Maximize MDE.
Notice that MDE is now "Always on Top" by trying to place another window over MDE.
Restore MDE to a normal Window
Notice that MDE is still "Always on Top"

If you repeat these steps with IgnoreTaskbarOnMaximize = false, the behavior is correct.
Expected outcome
Always on Top is a bit unexpected when Maximized but I can see why that might be necessary. Restoring the Window should remove the Always on Top behavior.

Environment

MahApps.Metro .3
Windows 10
Visual Studio 2015
.NET Framework 4.6+

@mike-ward I noticed this also by using MDE. I'll try to fix this possible as soon.

No worries. The workaround is easy enough.

@punker76  I have also noticed this. Though, restoring the windows does not take any effect.

@mike-ward What's the workaround?

@sleman set IgnoreTaskbarOnMaximize to false. This solved the problem for me as of now.

Unfortunately I need that setting or else taskbar shows when app is fullscreen.

Wow, why is this closed?
If I maximise firefox and then restore it, it's permanently pinned on top - and I disabled the titlebar so I have to quit and restart the app to reset it!!!

Wow, why is this closed?
If I maximise firefox and then restore it, it's permanently pinned on top - and I disabled the titlebar so I have to quit and restart the app to reset it!!!

@ben2talk feel free to open a new issue, fill in the issue template and provide the code which does not work. Also please tell us what exactly you are meaning by firefox? I don't think that Firefox uses MahApps?
Moreover please be more kind to people working in their free time to provide this package to you and everyone else. It really keeps the enthusiasm up if we get more positive feedback. Thank you in advance.
Happy coding
Tim

@ben2talk feel free to open a new issue, fill in the issue template and provide the code which does not work. Also please tell us what exactly you are meaning by firefox? I don't think that Firefox uses MahApps?
Moreover please be more kind to people working in their free time to provide this package to you and everyone else. It really keeps the enthusiasm up if we get more positive feedback. Thank you in advance.
Happy coding
Tim

@ben2talk feel free to open a new issue
Tim
Sorry, my humble apology - this header looks identical to an issue I'm having with Krohnkite... it is not related to MahApps at all, but with Krohnkite running on KDE (Kwin script).

@ben2talk feel free to open a new issue
Tim
Sorry, my humble apology - this header looks identical to an issue I'm having with Krohnkite... it is not related to MahApps at all, but with Krohnkite running on KDE (Kwin script).


Feature: AWS X-Ray tracer extension.

Description: The implementation of X-Ray to be one of the tracing extension inside Envoy proxy, which with 5% sampling rate for spans.
Testing: Unit test, Integration test
Docs Changes: Need a separate section for X-Ray among with other tracers.
[#Issue] Related to: 5644
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Looks like there are still some work in progress here to get the tests right. Feel free to ask here or in Envoy Slack for help if you need it. You'll also want to make sure the DCO sign-off is done correctly, see: https://github.com/envoyproxy/envoy/blob/master/CONTRIBUTING.md#dco-sign-your-work and the "fixing DCO" section below it for instructions.

Close this one for now and a new one with DCO fixed is coming. Sorry for causing this trouble.


Train to be a teacher

Trello card
https://trello.com/c/H4N1jvTT/3130-build-new-navigation-pages
Context
This is the first proper attempt at adding a second level of navigation to the site. The previous attempts relied on drop-down menus that were a bit of a pain from a usability perspective, this one has 'category pages' that contain a card per category.
The files should be structured in the following manner:
app/views/content/
  - train-to-be-a-tacher.md     (the category page)
  + train-to-be-a-tacher        (a directory with matching name)
    - my-first-page.md          (pages within the cateogry)
    - my-second-page.md
    - _my-cta.html.erb          (partials placed on the category page)

Prior work was done in #2401, the content is discussed there at great length.
Changes

Add Pages::Navigation#find to select nodes
Add category page with cards for each section
Remove menu functionality from nav component

Remaining tasks

[x] Move the content over from #2401 once it's finalised
[x] Update the hero so it contains the blurb beneath the title
[x] Add the 'Questions' section and links
[ ] Remove 'Ways to train' from top nav
[x] Update the pink style of the 'also on this page' block
[x] Help and advice page
[ ] Set up any redirects needed (eg Ways to train?, SKE?, Get school experience?)
[ ] Lighthouse tests, usability review
[x] Make the events promo search actually work
[x] Replace 'Chat online' link with component

Preview

Desktop
Mobile

Note - I've left the hero background grey in this branch. It looks/feels weird when one is a different colour to the others, plus it's another variation to maintain.

@EllieNodder I'm sure you are aware of this already but a lot of the pages are missing titles/meta descriptions?

@EllieNodder I'm sure you are aware of this already but a lot of the pages are missing titles/meta descriptions?

Yep, we were holding off on those in case any of the pages/content changed. Shall be doing those today.

The new 'Why teach' section:

Desktop
Mobile

@peteryates Myles has just flagged to me that this is some additional whitespace around the mailing list bar (you might already be aware of this!)

@gemmadallmandfe - not sure why but the green bar has a 3em margin explicitly set on the bottom.

Perhaps we should ask the author why it's there 😂 cc @MylesJarvis

Green bar fixed in #2479 😄


[Exodus Migrations] Make sync command for exodus-style migrations

Definition: we call migrations "exodus-style" if they involve migrating a subset of data from a source database to a destination database. This happens when a service splits off into a separate sub-service with a subset of the original dataset.
Pgbelt can be used to perform such migrations, as long as the schema is loaded into the target database outside of pgbelt. Setup can be then run with --no-schema to not load in the schema to the target from the source database.
The rest of the steps in a pgbelt exodus-style migration are the same, except for the sync step. Two parts of the sync step must be excluded: loading in NOT VALID constraints and creating INDEXes.
The underlying code for these steps run a psql -f command and those files don't exist. We should have a --no-schema flag for the sync command to exclude those two steps.

We exclude creating indexes and applying foreign keys because those files won't have existed in pgbelt locally if the setup command was run with --no-schema.
So for exodus migrations, we will not support NOT VALID constraints. INDEXes will be covered by exodus setup steps anyways (where the user sets up their schema in their target database themselves fully).


Introduce JetBrains as a known JVM vendor.

Context
It is possible to use JetBrains Runtime in JVM Toolchain with:
kotlin {
    jvmToolchain {
        languageVersion = JavaLanguageVersion.of(17)
        vendor = JvmVendorSpec.matching("JetBrains s.r.o")
    }
}

Introducing JetBrains as a known vendor would help pick up JBR in a more convenient way:
kotlin {
    jvmToolchain {
        languageVersion = JavaLanguageVersion.of(17)
        vendor = JvmVendorSpec.JETBRAINS
    }
}

Contributor Checklist

[X] Review Contribution Guidelines
[X] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[X] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[X] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[X] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[X] Ensure that tests pass sanity check: ./gradlew sanityCheck
[X] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

Hi @hsz  👋
Thanks for the PR.
Some checks are failing.
See https://scans.gradle.com/s/5lomvvzfvsdwi/console-log?page=2#L1493-L1499
Your change adds a member to our public API. You need to accept that.
See the linked report and follow the instructions.

@eskatos Thank you for the details. I've fixed the issue and provided relevant information for the release notes.

Sorry to bother you again but it looks like the DCO check is now failing.
Could you please fix this?
See https://github.com/gradle/gradle/pull/26014/checks?check_run_id=15591659606

@eskatos Turns out I can't simply accept your suggestion here on GitHub with one click, but I need to craft a similar commit.
Anyways, everything should be fine now. 🤞

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

FTR, I just tested the following code with Gradle built from sources:
kotlin {
    jvmToolchain {
        languageVersion = JavaLanguageVersion.of(17)
        vendor = JvmVendorSpec.JETBRAINS
    }
}

It works well with the FooJay resolver as well:
plugins {
    id("org.gradle.toolchains.foojay-resolver-convention") version "0.6.0"
}

It pointed to the following JBR distribution:
Download https://api.foojay.io/disco/v3.0/ids/889f2f5999789ae9c926cd06b3376cb6/redirect, took 42 s 564 ms (200.23 MB)

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

Thank you Jakub!
This will be in Gradle 8.4

FTR: the vendor display name was adjusted to simply JetBrains — ref: #26022


[shapes] Shape Drawing Functions are missing ...LinesEx variants with a line thickness parameter.

Issue description
I am basically missing some function variants for drawing shapes with lines with a custom line thickness. All of the following functions do not exist yet but I actually need a lot of them because setting the line thickness is pretty important for the visual style of my game. All of the basic functions already exist so I hope making the line thickness a parameter is not too much trouble :)
It's ordered by importance for me, so the "DrawCircleLinesEx" is the function I would need the most. (But I pretty much need all of them ^^)

DrawCircleLinesEx
DrawLineStripEx
DrawTriangleLinesEx
DrawCircleSectorLinesEx
DrawRingLinesEx
DrawEllipseLinesEx

@SoloByte I'm afraid those functions are out-of-scope for raylib but feel free to implement them for your specific use case.

Can I ask why they are out of scope? All of those already exist, it is just not possible to change the line thickness... Being able to draw rectangles and lines with line thickness but not circles and line strips is odd (at least for me). I don´t want to annoy you but Raylib basically checks all the boxes for what I need except those few functions.
I don't think I can implement them myself because I am using the c# bindings (Raylib CsLo) of raylib.
I am already using my own c# functions for drawing line strips and triangles with line thickness by just using DrawLineEx but I can´t really do that (efficiently) for circles and rings...
Anyway thanks for taking the time to answer ;)

Okay I understand, I will figure something out ;) Thanks for answering and keep up the great work!

GL_LINES are problematic especially width wise which had different maximums and often quite small depending on implementation to implementation...
In the end when I needed draw thick wires between nodes I used a cylinder model with a length of 1
I made a lookat matrix between the start and end points and inverted it, then made a scale matrix along the axis of the model to scale the length of the model between the start and end points
Munge those matrices together and you get a nice fat wire between the two points, simpler than it sounds and it worked first time...
`
Vector3 hw = Vector3Subtract(from,to);
hw.x = (hw.x / 2) + to.x;
hw.y = (hw.y / 2) + to.y;
hw.z = (hw.z / 2) + to.z;
        // angled between the input and output and scaled to length...
        Matrix wla = MatrixLookAt(from, to, (Vector3){0,1,0});
        wla = MatrixInvert(wla);
        wire.transform = MatrixMultiply(MatrixScale(1,1,Vector3Distance(from,to)),wla);
        DrawModel(wire,(Vector3){0,0,0},1,WHITE);

`
and et voilà


Update llm_inference.md

Explanation
Use a smaller batch size to make sure the llama-simple.wasm can work on most machines.
Related issue
https://github.com/LlamaEdge/LlamaEdge/issues/199
What type of PR is this

/kind documentation

Hello, I am a PR summary agent on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


Status of SAP instance doesn't get updated after trento-agent got stopped

I stopped trento-agent on vmnwprd04 and vmnwprd04 disappered from Hosts list which is another issue in general.
The status should get updated and but it keeps 'SAPControl-GREEN'.
See http://<IP_ADDRESS>/sapsystems/97a1e70aeff3c0685d65c4c3d32d533b

A little bit of background on this: we wanted to see how Trento reacts when the Trento agent running in a host with a PAS or AAS SAP instance crashes. For that we stopped the agent running in the AAS host (vmnwprd04) and then checked the status in Trento Console. We checked two things:

The status of the AAS instance (#02) in the SAP system detail view: we expected it to be unknown (given that the agent is stopped) but instead it was showing green. It might be that Trento is retrieving the status information using SSH. In which case, there is nothing to say.
The status of host vmnwprd04 itself: we expected the host to be in critical status with Agent status = stopped. But instead we found host vmnwprd04 gone from the list of hosts. Maybe that's how it is supposed to work by design but, in my opinion, if Trento Server cannot connect to an agent, the corresponding host should still show in the list with Agent status = stopped, so that we can act on it.

@lee-martin no, we captured the problem in the tests (test ID 05.160) but now that I'm reviewing the script I notice that we used this issue as a reference rather than opening a new one. I will create one right away.

@lee-martin done issue #536

Hey @abravosuse ,
Here some comments:

This is tricky thing you ask hehe When the agent stops working, we simply stop getting data so we are not able to update the data coming from this node, and we show the latest stored information. In this case, the unique thing we could do is check if the agent is not running, and in this case, only update the Status column to Unknown,
The host status is updated properly since the recent changes. Now, once the trento agent is stopped, the host will report an error icon in the host list and it has a error badge in the host specific view saying that the runner is not working:

Finally, talking about states, there is work to do in the SAP system list page, as there, in the status icons, we always show a grey icon...

Hi @arbulu89

Status Unknown is good because it's all that Trento can say about the instance at that moment.
That looks great. We will confirm in our 3rd testing round.

Thank you!

v0.7.0:

Status still showing as SAPControl-Green rather than Unknown. Fix pending.
Trento Agent status showing as Not Running. Great!

@abravosuse As commented, the 1st point is a really tricky thing, and I think we shouldn't implement the 1st solution that comes to our mind. After thinking it twice, I wouldn't implement anything like put Unknown or similar.
We need to decide project wide but happens when the agents stops sending data. Maybe, we need to apply some generic strategy for this like:

Remove data from not running agents
Set some kind of flag if the data has not been updated because the agent is not running
How to visualize this. Maybe we need to make the whole row like grayish, or some other visualization.

As commented, this needs some team work to think about this generic scenario

I totally agree with Xabi that we need a generalized solution for this problem, and this needs going to the drawing board and properly design it.

I also agree with @arbulu89. I will include it as a potential enhancement to be reviewed in the future: what to do, console wide, when an agent is not reachable. At least now we are not seeing instances in green status with an agent stopped. That's a big step further.
Issue can be closed.


Thank you very much for your work, this can make the lightning interface hot plug

https://1drv.ms/u/s!Ai021ZyMKLF25WS1s844vWyLYYaB
i have try
very nice！

Thunderbolt 3 is testing to be hot-plugged  with the current repo, the kext will be tested and decided  whether adding to repo or not.
Thanks for the work.

Then, can you look into the shutdown button. Some devices press the shutdown button to pop up the shutdown menu

i try PWRB in https://github.com/daliansky/P-little
But nothing happens

IOElectrify.kext would not be added to current repo, cause hot-plugged is normally, and PCI device is recognized normally.
What would you expect when "Power button" is pressed ?

https://lh3.googleusercontent.com/proxy/5TVwPPqk4fvtC_nD3XbhrH7MDIEv4mo-F5HIJs6zfHbFzVI3kMSkztN-Ks1N8YbRzDpx3hLcA06T-IjA8Xghmi1OYc4g5LcSflEONuz-FUtIb8Rgesi_WtY
I have successfully called it out before, but then it is gone.
Hot plugging may be the difference between our devices. I'm 9360 i5 8250u. When I use it, there is no hot plugging. . .
Thank you very much for your efforts. I tried almost all 9360 EFI on GitHub. You are the perfect one. . .

Since hot-plugged problem would occur on some 9360 i5 8250u, IOElectrify.kext will be added to repo recently.
To activate menu when "Power button" is pressed, "rename PBTN to PWRB" is needed, will trying to improve later.

Since hot-plugged problem would occur on some 9360 i5 8250u, IOElectrify.kext will be added to repo recently.
To activate menu when "Power button" is pressed, "rename PBTN to PWRB" is needed, will trying to improve later.

me use 8250u, i think don't need it

https://lh3.googleusercontent.com/proxy/5TVwPPqk4fvtC_nD3XbhrH7MDIEv4mo-F5HIJs6zfHbFzVI3kMSkztN-Ks1N8YbRzDpx3hLcA06T-IjA8Xghmi1OYc4g5LcSflEONuz-FUtIb8Rgesi_WtY
I have successfully called it out before, but then it is gone.
Hot plugging may be the difference between our devices. I'm 9360 i5 8250u. When I use it, there is no hot plugging. . .
Thank you very much for your efforts. I tried almost all 9360 EFI on GitHub.

IOElectrify.kext deleted.


Unable to write in text box

Some of the text boxes on the sheet cant be writt

en on due to spacing

Thanks for raising this! Should be fixed in 0.2.2 which is now available.


Replaced IN_NOTEBOOK to fix vscode show_doc error

This PR fixes https://github.com/fastai/nbdev/issues/580
This is related to this issue in fastcore where fastcore.utils.IN_NOTEBOOK returns False in vscode, even though in_notebook() returns True.
Removing IN_NOTEBOOK and using a try/except ModuleNotFoundError block seems like a Pythonic way to handle this and fixes the error.

Yup makes sense to me! I'll go ahead and fix this locally to avoid the conflict.


Update New Submission

This submission is contained in the file "Prediction_X_Final.csv" generated by the notebook "Facies_classification_LA_TEAM_05.ipynb".

Hi Alfredo... this one gets 0.490. I've had good results from TPOT in the past... Have you tried using more samples in the population, and more generations?


Migrate to Bootstrap v5.x

Describe what problem your feature request solves:
Threat Dragon is stuck on Bootstrap version 4.6.1 because of breaking changes going to Bootstrap v5.x
See https://getbootstrap.com/docs/5.0/migration/
Describe the solution you'd like:
provide Bootstrap 5.3.3 in file td.vue/package.json
Additional context:
Moving to Bootstrap 5.3.3 was tried in commit 37a1734906767b5db265064244222f3ce3c2e90f

Hi @jgadsden,
I’d like to work on this issue to help migrate Bootstrap from version 4.6.1 to 5.3.3.

Hello @ChandraDevs1 , it is not a straight forward task but you are welcome to work on it


2nd attempt, did a ruff --fix

does it pass?

is it gooooood? decided to add loguru to replace print tests

is it gooooood? decided to add loguru to replace print tests

Not sure why you added loguru when the bot has a logger already setup?

removed loguru since logger is setup already @u@


chore: proto-gen

Attempt to proto-gen correctly for https://github.com/celestiaorg/celestia-core/pull/1021

thanks @SweeXordious, I'd still like to figure out what is incorrect about my setup

No idea to be honest, could it be the permissions?

Does CI not check for this?

@adlerjohn It does:
https://github.com/celestiaorg/celestia-core/blob/de9b4ec9b346dd70dfc14358dfed1e9e3267bb4d/.github/workflows/check-generated.yml#L52-L65
But for a series of commits, which I suspect were merged (or cherry picked) and not squashed, the code was not generated correctly, and the PR got merged regardless. That's why I created this PR to fix the generated code.


Very slow real time indexing comparing to SQL-backed one

On my MBP with SSD and the table having over 3 mln records ts:rebuild takes  57 seconds. But
ts:regenerate takes 10 minutes! That's the huge difference. Why is that?

With SQL-backed indices, Sphinx is able to access your database directly via SQL queries. With real-time indices, though, each ActiveRecord instance is loaded and used to gain the data - so, you've got the overhead of Ruby and Rails to contend with.
Real-time indices have the option of defining an initial scope - which can allow you to specify preloaded associations to optimise the loading of your objects. So, this may help improve the performance?
Still, SQL-backed indices are almost always going to be faster to process. The downside is that when your records change, SQL-backed indices can't update a single record with your new details. You'd need to use delta processing, or otherwise your Sphinx documents are going to be out-of-date with any changes since the last time you ran rake ts:index/rake ts:rebuild. Also, with SQL-backed indices you're limited to SQL statements to generate data for Sphinx, whereas real-time indices gives you the power of Ruby for data manipulation.

Is ts:generate' working like ts:reindexexcept it uses RT indeces? With SQL-backed indeces I can runts:reindex` without putting down my web app. Is it something similar if I use real time indeces?

Maybe I could run manually something using ThinkingSphinx::RealTime.callback_for(:verse). I tried, it does not index anything. Maybe there is another way?

With SQL-backed indices:

Use ts:index regularly to keep your indices data up-to-date.
Use ts:rebuild only when you've changed your Sphinx schemas, and yes, this will involve Sphinx being down while it runs.

With real-time indices:

Use the real-time callbacks to keep your indices data up-to-date immediately.
Use ts:generate semi-regularly to confirm your indices data are up-to-date (in case any data is modified and callbacks aren't invoked).
Use ts:regenerate only when you've changed your Sphinx schemas. This will mean Sphinx is down briefly at the beginning of the task, but then it'll be running though not all data will be present until this task has finished.

If your data is changing frequently, then I'd recommend real-time indices (ts:generate may only need to be run once a day, if you're quite sure the callbacks should catch all data changes?).
However, if your data is changing infrequently, then SQL-backed indices may be a better approach, especially if having your search matches slightly out-of-sync is not a big problem.
The real-time callbacks can only be used for models with real-time indices. Sphinx only allows immediate updates for real-time indices, not SQL-backed indices.
If you want to invoke a real-time update at some other point (besides callbacks), you can do the following:
ThinkingSphinx::RealTime.callback_for(:verse).after_save(verse)

And just to be clear: both ts:generate and ts:index will not stop Sphinx, and thus your app should continue to work fine while they're running.

That's great explanation. Thank you.


BLE Observer Role required for scan response (IDFGH-14147)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.3.1
Espressif SoC revision.
ESP32
Operating System used.
Windows
How did you build your project?
VS Code IDE
If you are using Windows, please specify command line type.
None
Development Kit.
Custom Board
Power Supply used.
USB
What is the expected behavior?
I would expect to receive scan responses while scanning when only BLE Central is enabled and BLE Observer is not.
What is the actual behavior?
When running a slighlty modified version of the nimble example blecent, such that active scanning is used, discovery events for the scan response are only received if "Enable BLE Observer role" is checked in menuconfig. If only Enable BLE Central role is checked, scan responses are not received.
Steps to reproduce.

Create Project based on nimble/blecent example
Modify ble_cts_cent_gap_event  as follows (Added specific output on scan response, remove other output, avoid connects):

ble_cts_cent_gap_event(struct ble_gap_event *event, void *arg)
{
    struct ble_gap_conn_desc desc;
    struct ble_hs_adv_fields fields;
    int rc;

    switch (event->type) {
    case BLE_GAP_EVENT_DISC:
		if(event->disc.event_type == BLE_HCI_ADV_RPT_EVTYPE_SCAN_RSP){
			ESP_LOGI(tag, "Scan response event received");
		}
        rc = ble_hs_adv_parse_fields(&fields, event->disc.data,
                                     event->disc.length_data);
        if (rc != 0) {
            return 0;
        }

        /* An advertisment report was received during GAP discovery. */
        // print_adv_fields(&fields);

        /* Try to connect to the advertiser if it looks interesting. */
        // ble_cts_cent_connect_if_interesting(&event->disc);
        return 0;

...
}

In ble_cts_cent_scan change the following line to enable active scanning:

    /**
     * Perform a passive scan.  I.e., don't send follow-up scan requests to
     * each advertiser.
     */
    disc_params.passive = 0;

Leave menuconfig as is and build and run the example. after starting the scan, you should see "Scan response event received" outputs in the console
In menuconfig, disable all roles except central role. (Bluetooth->NimBLE Options)
Rebuild and run the example. No "Scan response event received" outputs are shown since no scan response is received
(opt.) In menuconfig reenable Observer role (only Central and Observer enabled now)
(opt.) Rebuild an run the example. Scan response output is available again

Debug Logs.
No response
More Information.
No response

Hi @PironexJRunge ,
If observer role is enabled, nimble will post all adv reports regardless of flags AD types .
If observer role is not enabled, there are stringent checks for Flags AD type ( General / Limited flag ) . If these are not set, then the adv packet is dropped by nimble and hence you don't observe them since the reports are not passing for the checks ( i.e. they are not formatted correctly with all exact information).  The code can be checked here.

Hi @rahult-github,
thanks for your fast reply. I checked the code and compared what the device that I am scanning is providing and the device is only sending its AD flags in the advertising data, not in its scan response. Is this an issue with the device`s BT protocol?
Or is there any way to combine  the advertising and scan response data for the sanity check? Currently the advertising and the scan response are given separately to the sanity check, which makes it fail for the scan response.
This issue occured to me while upgrading from 5.0.2 to 5.3.1. Looking into 5.0.2 no sanity check was done at all when the limited flag was set to 0.
Kind regards
Jan

Is this an issue with the device`s BT protocol?

For general discoverable mode, adv reports should have some AD flag.

And for non-discoverable mode:

By not setting the AD type, the advertising events are received but being treated as non-discoverable and hence being dropped.
By not setting observer role, the above conditions get checked and hence the observation.

This issue occured to me while upgrading from 5.0.2 to 5.3.1. Looking into 5.0.2 no sanity check was done at all when the limited flag was set to 0.

True, we migrate nimble versions and also keep adding fixes. So code difference observed .

I think the main issue for me here is, that the advertising data does contain AD flags, but the scan response does not.
Adding two log outputs to ble_gap_rx_adv_report:
void
ble_gap_rx_adv_report(struct ble_gap_disc_desc *desc)
{
#if NIMBLE_BLE_SCAN
    ESP_LOGI("SCN", "Event type: %d with data:", desc->event_type);
    ESP_LOG_BUFFER_HEX("SCN", desc->data, desc->length_data);
    if (ble_gap_rx_adv_report_sanity_check(desc->data, desc->length_data)) {
        return;
    }

    ble_gap_disc_report(desc);
#endif
}

provides the following output for the BT device I am interested in:
I (2985) SCN: Event type: 0 with data:
I (2985) SCN: 02 01 06 06 09 65 6c 6c 69 6f 0d ff c0 01 11 01
I (2985) SCN: 01 06 90 38 0c fb 5d 62
I (3025) SCN: Event type: 4 with data:
I (3025) SCN: 09 09 65 6c 6c 69 6f 54 61 67

We can see that the first three bytes of the advertising contain the AD flag field, so sanity check runs fine while the scan response only contains the device name and is thereby discarded by the sanity check. Is this an intended behaviour? Or would you expect that the scan response contains an AD flag field as well?
From my point of view the scan response is an addition to the advertising data already received and therefore must not contain the AD field again but I might be wrong on this.

Hi @PironexJRunge ,

From my point of view the scan response is an addition to the advertising data already received and therefore must not contain the AD field again

Vol 3, Part C, Section 11 has the Advertising and Scan Response data format.  So it is safe to say that AD information is part of scan response .

Alright, thanks for your efforts, I will contact the device manufacturer then and ask them how to get their device to provide a proper scan response.
Kind regards
Jan


ditch memcache and maybe replace with DAX

Now that we are storing chunks in DynamoDB instead of S3, it is questionable whether we still need memcache - one would hope that fetching chunks from DynamoDB is fast enough, and if it isn't then DAX is probably a better alternative.
I suppose one question is whether we want to keep memcache around in order to speed up access to historical data predating the s3->dynamo switch.

According to the docs

At this time, DAX clients are available for Java and Node.js.

so this is not an option yet.

Still not an option, and we have multiple back-ends and multiple caches now, so I don't think this issue is going anywhere.


Signature aka Unknown6

Since the unknown6 field has been reverse engineered, did you start looking into implementing it in this API? My main concern is the encrypt.so/.dll that is used. I think we can't use it directly since it's not a PHP shared library. We would have to write a wrapper or port the function to PHP code. The latter would have copyright issues. Any thoughts?

Using a DLL file in PHP directly is a new one, that's for sure. Additionally, the python scripts are using xxHash, which is another dependency that we might have to deal with.
On a slightly related note, we should consider "re-merging" all the pogoprotos-php repositories to a common place, so there's not duplicate work done with so few people.

Regarding @Ni42's note here, merging them would be good, but that would (again) raise a discussion (jaspervdm/pogoprotos-php#8) whether bramp/protoc-gen-php or protobuf-php should be used. I think the main reason why everyone's creating his own fork is that they're fixing bugs with bramp's one :laughing: . The only problem that came up with protobuf-php so far was fixed within a day by the original dev after mentioning it (protobuf-php/protobuf-plugin#3). Of course by now, where most projects are quite advanced, switching to a new Protobuf-lib is some work to adjust (to be honest, though, the changes are not that big, mostly just other class names and passing streams in constructor instead of a read-method).

I don't have enough insight in the work required, but just from what I'm reading, would you rather keep fixing things in an inactive/abandoned library or do the work of switching to a maintained one? It's an easy decision I guess, especially if you have to maintain these files anyways to to game API updates (or the current unknown6 situation).

This is what I had to change to get the RetrievePlayerProfile-Example working: https://github.com/NicklasWallgren/PokemonGoAPI-PHP/compare/master...DrDelay:patch5-protobuf-php
Disclaimer :laughing: :
This is not properly tested. Probably adjustments to the AuthTicket saving need to be made (resetting streams).
This is only a proof-of-concept.

For sure protobuf-php seems the way to go, especially since that repo is still maintained. Ideally everyone that wants to use the protos for their API or whatever uses the same repo for the PHP classes to avoid doing double work. On Wednesday I am back at home. At that point I will test the test-protobuf branch some more (especially using same auth ticket multiple times as DrDelay already referenced) and merge it into master.
Regarding the actual topic of this thread: under Windows PHP extensions are DLLs. I was thinking if we could somehow use the encrypt.so/.dll as an extension. But like I said, we cannot use it directly since it's not written for PHP. I don't have experience writing extensions, but I am starting to look into it. I'm not sure if it's possible but the best option imo would be to write something that uses the encrypt.so/.dll as an external, so the extension itself wouldn't contain copyrighted material and we can put it on github.

I updated my branch with 67344129bd58ab92aa374b573e0ac0bf24a696cc, because I now encountered the "AuthTicket stream thing" mentioned. This fix works, however I'm not sure whether this should be handled in the pogoprotos dependency.

I'm all for switching to protobuf-php, eventually.
We should get a separate branch going.

So I tried around a little bit, and it is not too hard writing a PHP extension. I successfully compiled a PHP extension on my windows install that can find an external DLL and call a function from it... I can share my pathetic VC2015 file if you guys want it.
That basically means welcome to platform-specific PHP programming, because using a DLL using the Win32 API obviously doesn't work un Unix ^^
Anybody else got some progress?

I tried my luck with The COM class, no success however: Uncaught com_exception: Failed to create COM object 'encrypt.dll': Ungültige Dateierweiterung (Means "Invalid file extension")

Another thought I had:
I saw a repo with the source (encrypt.c and encrypt.h) of this .dll/.so, I think it was this, but it says 404 now.
The thought was: Why do we need a .dll/.so? Wouldn't this do (sorry for mistakes, my C is a bit rusty):
/* pogoencrypt.c */
#include <stdio.h>
#include "unknown6/encrypt.h"

int main(int argc, char** argv)
{
    printf("%s", encrypt(argv[1]);
    return 0;
}

The repo would be included as a submodule unknown6. We could then just call pogoencrypt(.exe) with shell_exec.
Are the copyright issues with this (if we ever find that repo again).

You can only use the COM library for DLLs that are specially compiled, I may or may not have the C file, so we could try some things out.
The main problem was mentioned by @jaspervdm above, we can't really directly redistribute the encrypt DLL (or a recompiled version) without also going into copyright territory... That only really leaves us with the option of creating a way to "externally load" the DLL/SO, which has to be in the form of a PHP extension or external executable file.

Looks like there's a pure JS implementation of encrypt.c:
https://www.reddit.com/r/pokemongodev/comments/4wo75h/pure_javascript_typescript_port_of_encryptc/
So I guess that would also be possible in PHP?
We could include the "encrypt.php" from some external source than.

Might work too, would be easier than dealing with extensions/library files, two things come to mind: copyright (I have really no idea how this really works), and performance.

I've handled the xxhash dependency
https://github.com/MatthewKingDev/php-xxhash
tested vs the python implementation and the values are returning correctly so that's one less headache.

@MatthewKingDev Whats the difference between the original onces?
https://github.com/Megasaxon/php-xxhash
https://github.com/dred86/php-xxhash
They both supports PHP 7

His implementation has a  argument to set the seed

The difference between dred86 and Measaxon is

I've had a go at converting the pure JS implementation to PHP tonight, feel I'm pretty close though I've run into a bit of a wall. My lack of understanding of both C / JS TypeArrays doesn't help. Can any of you guys point me in the right direction, I'm not understanding how the below is happening and how to recreate that in PHP?
 You don't understand the type conversion? That's a pretty huge list, can you maybe create a smaller example, or is the size relevant?

Check out:
https://github.com/Sjaakmoes/pokapi/blob/master/src/Pokapi/Rpc/Service.php
At the bottom it looks like they have this done already.

Maybe I'm missing it, but I don't see anything relating to the signature field. Which line are you referring to?

Can't really be it, since the changes for the signature are only 4 days old now, and there weren't many things updated on that project since then.

@Ni42 Do you have discord, so we could discuss the encrypt library? I am on the pokemongodev discord server, username kebabtent#5947

@KyleBoyer I didn't add the signature to that yet, planning to do that later still.

I'll take a crack at converting the encrypt library to PHP aswell.

@jaspervdm Oh, that's you, yes, will drop you a message later.

@Sjaakmoes I don't know if that will be practical, it may be better/faster to get up and running by simply including the encrypt files for windows/Linux/Mac (32/64bit) and have an ID statement decide which one to use(being, somewhat OS independent). Once that has been done, porting the encrypt library to PHP would be best.

Just my 2 cents:
I would prefer if this library had nothing related to the Unknown 6. I mean there's tons of other libraries that got this available ( not PHP ) and using Map resources in this API would increase the chance of C&D by Niantic. I like it here, I don't want it gone :(

IMO any encrypt implementation/wrapper should be a separate repo anyway, since more than one API project could profit from it. In the same way, the proto classes should also be a separate repo.

There is now a pure PHP implementation available: https://github.com/POGO-PHP/POGOEncrypt-PHP

Wow, thank you!

Now we still need the xxHash extension, do we?

User @MatthewKingDev made one: https://github.com/MatthewKingDev/php-xxhash

@Ni42 : I could add a pull request to update composer.json, however that alone is not enough to generate valid requests

I'm working on a small library to generate a correct signature.

@POGO-PHP right, that wouldn't be the problem, it needs to be implemented on our RequestEnvelope... on that context, @NicklasWallgren can you upgrade the proto files? ;)

@Ni42 The files have been updated :)

Thanks!
@Sjaakmoes I saw you already have the signature implemented in your version, are you planning to add a PR here? If not, would you mind if someone took your implementation and transferred it here?

@Ni42 By all means go ahead, I'm thinking about creating a PR for this. I wanted to ask, before I do that, @NicklasWallgren . My current implementation requires a PHP extension for xxhash, is that a problem? It's also PHP7+ only because of random_bytes but that can be fixed.

If you want to do it, that would be great, I can only do it tomorrow evening at the earliest.
Since there is no way around the xxhash extension for now (I don't think there is a PHP implementation), we should just add some error handling for the queries that currently need signing if the required functions aren't present, for those users that don't need the signed queries.

I think composer also has ability to do require for extensions. At least I have seen it for mbstring so maybe it also works for custom ones.

Yes, probably, but can you make it optional if you only want to, for example, use the inventory functions?

I made a PR, couldn't test it on PHP 5.6 tho. Can anyone do that? I've included a polyfill for random_bytes in the composer file.

@Sjaakmoes Thanks, I'll be reviewing it later today.

How about using this one? https://github.com/POGO-PHP/POGOEncrypt-PHP
No library DLL/.so needed.

@b6oy That repo was already referenced here and is already being included in the PR #92 (see the composer.json ). It is used to calculate the hash of the Signature protobuf. But some of the fields in this Signature protobuf require a hash of specific variables (like latitude, longitude), calculated with xxhash. As far as we know, there is no pure PHP implementation of xxhash, this is why we are discussing using the extension (.dll/.so file).
I have already compiled it for windows, it can be found here. When I get around to it, I will also do it for linux and mac.

Why not using https://github.com/POGO-PHP/POGOEncrypt-PHP as @b6oy  said ?

Because implementing it takes longer than writing a one-line issue text? :/
Pretty sure it will come soon enough.

@lambasoft Well I tried to explain that to you in my message above, its not the only thing you need.

I understand we would need both POGOEncrypt-PHP and an xxHash implementation. But why are we so against an extension for xxhash? Something like:
https://github.com/Megasaxon/php-xxhash
Or others? I dont understand why some people were saying extensions would make the API Windows only?

I dont think people are fundamentally against using an extension. For example Droeftoeter/pokapi and jaspervdm/pogoapi-php both use this fork. However, at some point people were discussing whether a pure PHP option is desirable or not, but I dont think anyone actually wrote it.


probs with the righthand panel

after browsing to a language via the plus icon, the “info” panel keeps showing the country I selected even when selecting a language in a different country on the map

I'm having trouble reproducing this.

Seems to be working now.


Refactor auth buttons

What type of Pull Request is this?

Refactoring (no functional changes, no API changes)

Other information
Created a AuthButton component to encapsulate the auth navigation and loading logic.

Thanks for this, but I plan to refactor on stream. I'll leave this PR open as a reference.


goaccess-close-visitors

"Hello, I would like to use the GoAccess tool to display only the 'Hits' panel in the graph and hide the 'Visitors' panel. How can I modify my GoAccess command to achieve this?
my command; cat   log_file | docker run --rm -i -e LANG=en_US.utf8 allinurl/goaccess -a -o html
--log-format='%h [%dT%t.%^] "%m %U" %s %Dms'
--date-format='%Y-%m-%d'
--time-format='%T'
--ignore-panel='REQUESTS_STATIC'
--ignore-panel='BROWSERS'
--ignore-panel='OS'
--ignore-panel='REFERRING_SITES'
--ignore-panel='NOT_FOUND'
--no-ip-validation - > report_output

Hello!
Maybe --ignore-panel=VISITORS will help?
If you're looking to disable the Visitors column then the Panel Options on the right corner of the Panel, you can disable the visitors and enable only the Hits column under Column Options, and if you change the Plot Metric to Tx amount, it only shows Hits on the graph.

 Panel's Graph is something that would be helpful to me as well..

It seems that there isn't a GoAccess command to remove the bars inside the graphs. I'm not exactly sure what to do.

To clarify, are you seeking to eliminate the visitors column or panel? Removing the column is not feasible, but may I inquire about your objective in concealing this column? If your goal is to hide the panel, you can achieve this by using the --ignore-panel=VISITORS option.

I would like to eliminate the visitor data from the graph, while retaining the hit counts. (Concealing the visitor column will not help me because it doesn't change the graph, and I don't want to hide the VISITORS panel because I still want to see the graph about number of hits.
In my case, the visitor IPs in my logs (due to preprocessing) consistently reflect the proxy IP, so the visitor line (marked in red) in the graph has a constant x value = 1. It would be really helpful if the graph could only show the number of Hits per day, or an option to toggle between the visitor and hits data in the graph.

Got it. Keep an eye out because this has already been implemented for the upcoming release of v2.0.

awesome, thanks a lot!

@Urvika-gola np, happy to help.

@allinurl  The goal is to analyze only the data related to "hits" for our reports. Since we don't have a large number of visitors in our reports, we want it to be easier to read and analyze, so we would like to remove the "visitors" bars if possible.

instance graph

@ismailunsall, a quick method is to hover over the "hits" legend below to dim those bars. But, as I mentioned earlier, keep an eye out for version 2; it's on the horizon!


Makes ElectionModule more generic

Fix #905
Ok, so basically what I did was:

Move ElectionModule and made it generic (non-snx specific).
Renamed governance-modules to synthetix-governance with SNX specific stuff.
synthetix-governance extends ElectionModule and brings in all the debt share specific stuff.
All debt share stuff is moved out of ElectionStorage into DebtShareStorage.
synthetix-governance tests try to not duplicate ElectionModule tests in core-module, but there is still some duplication. This can, and should, be improved.

@dbeal-eth in response to your comment:
"to clarify, in practicality, should it ever be deployed? is it useful for testing, for example? trying to figure out what "dumb" means here 😆"
Yes, sorry, I should have been clearer. This contract is inherited by the ElectionModule, which makes the EM itself be non-deployable, or abstract.
I really picked the wrong word with "dumb". I guess what I meant is that this particular deployable implementation uses the simplest possible way of solving tallying and vote power.


Prefix/suffix implementaiton

added Pre-/Suffix to the UiInputContainer
Methods added to the interface:

setPrefix
hasPrefix
getPrefix
setSuffix
hasSuffix
getSuffix
the methods hasSuffix and hasPrefix where implemented as default functions in the Interface

Interesting travis error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:3.0.0-M1:deploy (default-deploy) on project mmm-ui-api-parent: ArtifactDeployerException: Failed to deploy artifacts: Could not transfer artifact io.github.m-m-m:mmm-ui-api-parent:pom:1.0.0-20200609.053939-44 from/to deploy (https://oss.sonatype.org/content/repositories/snapshots/): Transfer failed for https://oss.sonatype.org/content/repositories/snapshots/io/github/m-m-m/mmm-ui-api-parent/1.0.0-SNAPSHOT/mmm-ui-api-parent-1.0.0-20200609.053939-44.pom 401 Unauthorized -> [Help 1]

Seems I missed out to prevent deployment for PR builds. I thought I had this right. Will double check. However, you do not have permission to deploy so obviously leading to 401.
I will try to fix this. We then need to update your PR with the change...
Further, I will also need the PRs for the implementations because if I merge the PR all implementations are broken as they do not implement the new feature/methods. The trouble with modular repos (non mono-repo) is that the PRs for implementations will fail unless this PR is merged. However, I can then review all of them and if they are fine, I merge API, then restart builds of the other PRs and merge them as soon as the build is green...

Great, the build is also fixed. So as announced, I would need the PRs for the ui-* implementations so that I do not merge this PR alone breaking the rest...

After several experiments it turned out that using the UiInputContainer for this feature is nice for maintenance but has the problem that then the input widget without label but with its belonging prefix/suffix can not be added via official API.
I am closing the PR as I already redid the feature directly in UiInput. Thanks for your work (esp. https://github.com/safibarri/ui-fx/tree/Feature/9_Prefix_Suffix).


Autocomplete with Noice messes up indentation in some cases

Describe the bug
When installing Noice (empty .setup()), any completion done without an LSP is de-indented by a single space. I have tried with -u NORC to no avial, and I've also uninstalled all other plugins temporarily to no avail. Having popupmenu disabled is also without effect on this issue. I am testing this on Lua files, as I don't regularly have sumneko installed.
If I leave everything in my RC, I can:

C-x C-f to complete path names without deindent
C-x C-o to produce a complaint about no omnifunc in lua files and deindent by one space
C-x C-n to complete without deindent

I'd appreciate any pointers on how to go about debugging this, I realise that this report does almost nothing to narrow this down yet, and that the actual issue could even be unrelated to Noice, even though I only notice it with Noice installed.
Which version of Neovim are you using?
v0.8.0 in kitty
To Reproduce
Steps to reproduce the behavior:

install Noice as suggested by README
enjoy all Noice features
suffer completion breaking indentation

Expected Behavior
Not messing with completion results.
Screenshots
https://paste.selfnet.de/index.php/Lwfw/ (<200kB mp4)
Noice Log
None is produced

I cant reproduce this. Can you create a minimal.lua that reproduces this?

I've narrowed it down to some conflict with the mini.nvim's mini.complete module. I'm not sure how this issue persisted through vim.o.loadplugins = false on yesterdays attempt... See the attached minimal config. To reproduce:

set XDG_CONFIG_HOME=./test.config and XDG_DATA_HOME=./test.local
put attached config in .test.config/nvim/
ensure nvim has installed packer and all plugins and do a clean launch
4jol<BS>l -> the second attempt at autocompleting the word "local" deindents (no  or anything required)

Might be this actually is an issue for @echasnovski's mini.nvim.
vim.o.termguicolors = true
vim.o.expandtab = true
vim.o.shiftwidth = 2

local ensure_packer = function()
  local fn = vim.fn
  local install_path = fn.stdpath('data')..'/site/pack/packer/start/packer.nvim'
  if fn.empty(fn.glob(install_path)) > 0 then
    fn.system({'git', 'clone', '--depth', '1', 'https://github.com/wbthomason/packer.nvim', install_path})
    vim.cmd [[packadd packer.nvim]]
    return true
  end
  return false
end

local packer_bootstrap = ensure_packer()

return require('packer').startup(function(use)
  use 'wbthomason/packer.nvim'
  -- My plugins here
  -- use 'foo1/bar1.nvim'
  -- use 'foo2/bar2.nvim'
  use({
    "folke/noice.nvim",
    event = "VimEnter",
    config = function()
      require("noice").setup()
    end,
    requires = {
       -- if you lazy-load any plugin below, make sure to add proper `module="..."` entries
       "MunifTanjim/nui.nvim",
       "rcarriga/nvim-notify",
    }
  })

  use({ -- mini plugin suite
    'echasnovski/mini.nvim',
    config = function()
      require('mini.completion').setup({})
    end
  })

  -- Automatically set up your configuration after cloning packer.nvim
  -- Put this at the end after all plugins
  if packer_bootstrap then
    require('packer').sync()
  end
end)

I think I managed to reproduce this without 'mini.completion'. It doesn't deindent, but rather... swaps second to last character to be last after completion?
It is not an issue with 'mini.completion' per se, but with using <C-n> builtin completion (imitated by 'mini.completion' with default fallback completion). It seems to be doing so because of a notify window with message "Scanning tags" (usually displayed in command line).
Here is config:
-- Replace `packadd` arguments to actual plugin names in your 'pack' directory
vim.cmd('packadd nui')
vim.cmd('packadd nvim-notify')
vim.cmd('packadd noice')
require('noice').setup()

Here is demo with stable Neovim 0.8 release:
https://user-images.githubusercontent.com/24854248/195148443-6dffd507-8c69-4ff0-b9c3-e871b2d0fbe9.mp4

@echasnovski thank you for the repro!
The problem is that Neovim shows scanning messages. And since cmdheight=0, a more-prompt gets triggered. To bypass that we nvim_input a <CR>. That <CR> apparently messes with the indentation.
Seems related to https://github.com/echasnovski/mini.nvim/issues/5 :)

I was able to fix @echasnovski 's issue.
@debugloop can you check that yours is also fixed? I'm pretty sure it's the same issue

Thanks for your quick diagnosis, both of you 👍🏻 I can confirm the original issue is resolved in my own as well as in the minimal setup.
However, Noice is reporting a loop now and shutting down after about 50 of these "Scanning" messages. This is not reproducible with the minimal setup though, so I'll investigate and open a new issue if necessary.

@debugloop you can try setting config.hacks.skip_duplicate_messages = true. Should resolve the shutting down

The problem is that Neovim shows scanning messages. And since cmdheight=0, a more-prompt gets triggered. To bypass that we nvim_input a <CR>. That <CR> apparently messes with the indentation.

Yeah, but this prompt doesn't need <CR>. But you seem to know that already :)

Seems related to echasnovski/mini.nvim#5 :)

Well, yes, that was the reason of this issue, but not the underlying problem. I couldn't get rid of those "Scanning" messages, no matter how much I've tried. Those are the result of how <C-n> works. It feels like it should be possible to disable via some 'shortmess' value, but it doesn't seem like. I am yet to find time and try to fix this in Vim source code.

https://github.com/neovim/neovim/pull/20633
For scanning messages, please see this.

neovim/neovim#20633
For scanning messages, please see this.

Thanks for bringing this up. And @bfredl for making initial patch! And yet back again to using nightly :)

That's awesome :)


Consider adding guidance regarding partition count, metric volume, collection interval & correlation to Log Analytics cost.

Empirical data shows increasing a service's partition count has a direct & drastic correlation to the volume of metrics emitted. Please consider adding guidance for how often the Service Fabric metrics should be collected and the correlation to volume & cost in Log Analytics.
Related:
Support for node level rolled-up (aggregated) metrics

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: be578698-0c7c-9ea9-5e66-d629b1b5ae8c
Version Independent ID: a5c63cb3-0131-fea6-2d98-55982bf5fa1e
Content: Azure Service Fabric Performance Monitoring
Content Source: articles/service-fabric/service-fabric-diagnostics-event-generation-perf.md
Service: service-fabric
GitHub Login: @srrengar
Microsoft Alias: srrengar

@MedAnd Thanks for the comment! We will share this feedback with the content owner for further review and update as appropriate.

Hi @MedAnd, great suggestion. Unfortunately I've spoken with the team and it appears this isn't something we have the capacity to do presently, but we've made note of it in our backlog.
Thanks,
Nick
#please-close


AST/Sema: Introduce AvailabilityContext

AvailabilityContext is designed to be a compact representation of the active availability constraints in a specific scope. For now, it only models platform introduction availability but it will soon be updated to cover additional availability constraints, like platform unavailability.
TypeRefinementContext now represents availability constraints using AvailabilityContext instead of just an AvailabilityRange representing only platform introduction versions. In anticipation of the memory requirements for AvailabilityContext growing, a cache of uniqued instances of AvailabilityContext are stored in a
llvm::FoldingSet on ASTContext.
There should be no functional changes since this just changes the representation of the existing information stored by TypeRefinementContext. However, in the future AvailabilityContext will be expanded to represent additional availability constraints.

@swift-ci please smoke test

@swift-ci please smoke test Windows

@swift-ci please smoke test

@swift-ci please smoke test


Details how to set Keys from the CLI would be helpful

 Issue by Frannsoft
Monday Nov 20, 2017 at 02:22 GMT
Originally opened as https://github.com/Wyamio/Wyam.Web/issues/61

I wasn't able to find any info in the docs about setting Keys from the command line using the --settings command.  If this indeed does not exist currently I'm happy to add it.
It's something I ran into recently when looking to set DocsKeys like Title and AssemblyFiles and Keys like LinkRoot from the CLI.
Thanks!

 Comment by daveaglick
Tuesday Nov 21, 2017 at 22:05 GMT

Good catch. The CLI reference needs to be updated across the board. I was originally just copying and pasting the output from --help but that's barely usable and is out of date now anyway because I haven't kept up with it. What I really need to do is rewrite that section with more details on each argument.


Update README.md

Nitpick about phrasing — it probably doesn't matter, but it just occurred to me.

Going to pull this into another branch


fix: reduce flakiness of kfp-api integration tests

The mysql-k8s charm during deployment sometimes lands temporarily in an error state.  This error state resolves over time and the charm continues on to work as expected, but causes our integration tests to fail (like this example) because we do wait_for_idle(['mysql-k8s'], ...raise_on_error=True).  This fix sets raise_on_error=False to avoid this.
This does not change the passing condition of the test - the test will only pass if mysql-k8s goes to Active/Idle.  The only change is that mysql-k8s going to Error state does not result in a fast failure - the test will continue until the timeout before failing.

This makes me concerned why is it going to error state? Should not we open issue on mysql charm? No problem with the change just to notify mysql team about it.

100% agree @misohu - but I forgot to link it here!  https://github.com/canonical/mysql-k8s-operator/issues/337

Hey @ca-scribner I just changed the channel we are using for deploying mysql-k8s to be on sync with what we know works. This should be a better solution for this issue.

During review, @dnplas found that the flakiness was solved by bumping mysql-k8s to latest/stable, so the PR has been updated to this.


Overlord

@ddzz Your tests look great however I don't see the bomb exploding other than inputting the wrong deactivation code. Please implement a detonation feature and include the proper tests.

@incazteca I have designed the bomb so that it detonates only if an incorrect deactivation code is entered three times.  Is a separate feature to directly detonate it necessary?

This is looking good.  I like that you're using HTML5 markup in some cases.  Take a look at the comments and refactor.

You do not need an additional detonation feature.  The only requirement for detonation is three wrong deactivation attempts.  All others are optional.

Revision:  No resubmission needed.


Docker build of the backend doesn't work without Rust compiler

The backend docker image currently falls over if you try to build it
The error message that comes out is - error: can't find Rust compiler

Removed the backend docker image with todays code change. The issue does not exist with then new code.


Refactor CalculateScore, move GetBlockHash out of it

CalculateScore is often called in a loop for the same block height and it doesn't make a lot of sense to call GetBlockHash every time. Also given the function CalculateScore is meant to perform I think it just feels a bit better to keep it hash-agnostic so to speak.

makes sense


Any documentation on using --multicontainer-config-type Kube?

This examples makes use of --multicontainer-config-type compose however there is also an option to use --multicontainer-config-type Kube.  Any documentation on how to make that work?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b2472d79-baad-f202-75dc-c0d7c08e5c49
Version Independent ID: 7816cf1e-2264-e365-4d5c-b1fc9f7d08fe
Content: Create multi-container app in Web App for Containers - Azure App Service
Content Source: articles/app-service/containers/tutorial-multi-container-app.md
Service: app-service
GitHub Login: @msangapu
Microsoft Alias: msangapu

Hi @mapoitras Thank you for your feedback! We will review and provide an update as appropriate.

@mapoitras Thanks again for asking Question! You may refer to this doc.

@mapoitras We will close this out but if you feel you need more information please just let us know.


x/crypto/ssh: handshake failed: ssh: no common algorithm for client to server cipher; client offered: [aes128-ctr aes192-ctr aes256-ctr<EMAIL_ADDRESS>arcfour256 arcfour128], server offered: [aes256-cbc 3des-cbc aes128-cbc]

Please answer these questions before submitting your issue. Thanks!
We onboarded a new client with a new SFTP endpoint and are seeing an error message we never encountered.  What is the configuration I need to use to allow the CBC ciphers?
Error
ssh: handshake failed: ssh: no common algorithm for client to server cipher; client offered: [aes128-ctr aes192-ctr aes256-ctr<EMAIL_ADDRESS>arcfour256 arcfour128], server offered: [aes256-cbc 3des-cbc aes128-cbc]
What version of Go are you using (go version)?
1.8.1
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
from the current golang docker image
What did you do?
Attempting connection to SFTP host
What did you expect to see?
Successful authentication and connection
What did you see instead?
ssh: handshake failed: ssh: no common algorithm for client to server cipher; client offered: [aes128-ctr aes192-ctr aes256-ctr<EMAIL_ADDRESS>arcfour256 arcfour128], server offered: [aes256-cbc 3des-cbc aes128-cbc]

/cc @hanwen

works as intended. 3DES is deprecated, and the CBC ciphers have weaknesses, so they're disabled by default.

@hanwen - can I allow the CBC cipher using the ssh.ClientConfig options, or does this require forking the package as discussed here? https://github.com/golang/go/issues/13776

just try it. it should work.

Is it possible to just add the cbc ciphers to the already default ciphers?  I don't want to explicitly define the ciphers such that, when there are changes to the default ciphers, I don't get those changes.  Can anyone point me to a code sample doing this b/c I haven't been able to find a single example of this anywhere.

Ended up finding an example of how to use this from one of the unit tests:
https://gondolaweb.com/doc/src/golang.org/x/crypto/ssh/test/session_test.go

hm. This doesn't work for me. Is this correct?

	var sshconfig ssh.Config
	sshconfig.SetDefaults()
	cipherOrder := sshconfig.Ciphers
	cipherOrder = append(cipherOrder, "aes128-cbc", "3des-cbc")
// Authentication
config := &ssh.ClientConfig{
	Config: sshconfig,
	User:   "ciscouser",
	//Auth: []ssh.AuthMethod{SSHAgent()},
	//alternatively, you could use a password
	Auth:            []ssh.AuthMethod{ssh.Password("blablabla")},
	HostKeyCallback: ssh.InsecureIgnoreHostKey(),
}

I think I am going to have to use telnet instead of ssh...
Mebus

you're not changing the slice inside sshconfig

What do I have to change?
Mebus

config.ciphers = append(config.ciphers, ...)

It's in there, but the github is formatting it badly:
cipherOrder = append(cipherOrder, "aes128-cbc", "3des-cbc")
Like this?
Mebus

you're not changing config.Ciphers, you're just changing cipherOrder

aaaahh!!! My fault. Working now :-)
sshconfig.Ciphers = append(cipherOrder, "3des-cbc")
Thanks. :-)
Mebus

is there documentation somewhere that lists supported ciphers?


Upgrade terraform build image from 1.0.10 to 1.5.x

Step #1 - "tf version": *************** TERRAFORM VERSION ******************
Step #1 - "tf version": ******* At environment: environments/prod *************
Step #1 - "tf version": *************************************************
Step #1 - "tf version": Terraform v1.0.10
Step #1 - "tf version": on linux_amd64
Step #1 - "tf version": + provider registry.terraform.io/hashicorp/google v3.90.1
Step #1 - "tf version": + provider registry.terraform.io/hashicorp/google-beta v4.75.0
Step #1 - "tf version": + provider registry.terraform.io/hashicorp/null v3.2.1
Step #1 - "tf version": + provider registry.terraform.io/hashicorp/random v3.5.1
Step #1 - "tf version":
Step #1 - "tf version": Your version of Terraform is out of date! The latest version
Step #1 - "tf version": is 1.5.4. You can update by downloading from https://www.terraform.io/downloads.html

20231015
for https://github.com/hashicorp/terraform-provider-google/issues/16217
We will need to look at upgrading from 1.0 to 1.5.7 or the new 1.6.0 https://releases.hashicorp.com/terraform/1.6.0/ as a first step in the https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding codebase

go past 1.5.8 if not using 1.6.x

20240406: Closing issue during retrofit/rebase of this TEF V1 based/modified repo to TEF V4 standards
This issue may participate in the LZ refactor after rebase
Query on all issues related to the older V1 version via the tag
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/labels/2024-pre-tef-v4


WIP: DNS

DNS in smoltcp! Overall design matches the rest of smoltcp, there should be no surprises :)
The DNS state machine is implemented as a DnsSocket, instead of using UdpSocket, because:

It can send and receive UDP packets on the fly, avoiding the problems we ran into with DHCP (need big buffers, if they're full packets get dropped...).
The UDP source port has to be randomized per query, so running N queries in parallel would require N UdpSockets.

wire is complete, socket works with a few missing things:

[ ] Remove hardcoded IP addresses in socket.
[ ] Support multiple servers, retry queries with other servers when one doesn't work.
[ ] Allow specifying DNS names in human-friendly string format: "rust-lang.org" -> b"\x09rust-lang\x03org\x00";
[ ] Add protection against CNAME loops
[ ] Handle NXDOMAIN and other DNS server errors
[ ] Handle when query completes succesfully but there are no A/AAAA records.
[ ] Add support for AAAA queries.
[ ] Perhaps add a way to query A+AAAA at the same time?

Rebased, it's now fully working! TODO in PR description.


OS Browser Plugin/Extension

Credit to @nanalan:
How about we have a browser plugin that adds a button to the OpenSprites site next to the download one to "Add to Backpack". Then it uses the session id from Scratch so we don't have to ask for the user and password of the Scratch account to add the resource to the user's backpack.
I can do the chrome extension, but not Firefox-- I have no experience in Firefox's extension development.

I can do the chrome extension, but not Firefox-- I have no experience in Firefox's extension development.

Same here

Also we could have a "share from backpack" button that allows us to read their backpack as files - this is blocked by #28 though

So the way this would probably work is we'd load Scratch in an iframe on OpenSprites and postMessage to it, the extension would hook into Scratch URLs, read posted messages, and would be able to ajax with Scratch's session id

Features we might want

Sync OS backpack with Scratch backpack
Upload projects from OpenSprites

Is this really necessary for initial release? While I totally support this feature, directly uploading from your downloads folder isn't that hard (and also a useful skill for people to have, should we teach it to them!). :P

Nope, I don't think so. Feel free to put it back to Initial Release if you think I'm wrong.


.json metafiles of PMC-OA

I find the .jsonl metafiles you provided are the whole captions, that is, PMC-OA Beta Version. Can you provide the .jsonl metafiles of separated captions, that is, PMC-OA Version? Thanks!

Yes, and we have augmented PMC-OA captions with the help of GPT, we would release the new dataset by 7, July.

Hi @paradisetww ,we have released both PMC-OA and beta version on Huggingface-Dataset.
Checkout https://huggingface.co/datasets/axiong/pmc_oa


Grizzly exception mapper

Grizzly is overwriting the Jersey Provider entity body in Exception Mappers with HTML.
This is a fix.

Go ahead and merge.


Understanding the book and the code...

Hello, I was trying to contact the author or any who can help... is there any forum for questions about the book? I'm now at the section 2, and what I have is a full functional project, with all classes, several projects, services, repositories, etc etc... and the book only explains some parts of it... is there any part on the book that I actually create classes of the objects (book, author, etc)... how will I practice what is being shown? thank you for your help, maybe I'm missing something...

In other words, the book ask me to open the project, run it and it runs, vuala! but how did we get to that point? when can I start building my own project? I did a blazor project, and linked the author's data project, but that means the dbcontext is already there, classes are there even the overrided method to create relatioships is already there... if I can't create my classes and the book only gives and idea of what the classes are, how will I memorize these things?

Hi @sipi41,
My Entity Framework Core in Action book is about Entity Framework Core (EF Core) and doesn't cover how to create applications. However I do provide example applications so that a) I am sure want I write in the book is correct, and b) users can try an application yourself to see EF Core in action.
The Console App is the easiest app to understand, but the BookApp is quite complex (the Part3 branch BookApp is VERY complex).
I suggest you find articles / books about how to build the type of application you need. I would recommend the ASP.NET Core in Action, Third Edition book, the Microsoft documentation is also excellent.

Thank you @JonPSmith sorry if I sound harsh, its because when you create something, most of the times you understand what you did there, and the reason to do it... when others see you code, they may not think the same way, I think we should start by creating our own classes, our own dbcontext and go from zero to develop the complete solution, and yes, you can provide a whole solution as a reference in case something goes bad on the way... we are not (or at least me) as smart as you, just a suggestion.


Update kafka-schema-registry-client to 7.1.3

Updates io.confluent:kafka-schema-registry-client from 7.1.2 to 7.1.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.confluent", artifactId = "kafka-schema-registry-client" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "io.confluent", artifactId = "kafka-schema-registry-client" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #967.


Add support for uploading Verio range meters in UiW (UPLOAD-1184)

Addresses UPLOAD-1184.

I'm going to merge this, as it is against in-browser-merged and not master, so that we can get these changes onto QA1.


Hovering events do not work when using computed plotting data.

Hello,
when using computed or data that is added dynamically vue-plotly should reinitialize the event handlers so it supports hovering on new plotted points as well.
Best,
Jacob

Should be fixed now after using react instead.


Move AtomRef Fitting to numpy to avoid bug

Summary
Change the fitting method of AtomRef from torch.linalg.lstsq to np.linalg.pinv mthod
Issue with previous implementation
for i in range(3):
    training_set, validation_set, test_set = split_dataset(
        dataset,
        frac_list=[0.9, 0.05, 0.05],
        random_state=42,
        shuffle=True
    )
    train_graphs = []
    energies = []
    forces = []
    for (g, lat, l_g, attrs, lbs) in training_set:
        train_graphs.append(g)
        energies.append(lbs["energies"])
        forces.append(lbs['forces'])
    element_refs = AtomRef(torch.zeros(89))
    element_refs.fit(train_graphs, torch.hstack(energies))
    print(element_refs.property_offset)

The output for the above block gives:
tensor([ -3.3743,  -0.3157,  -2.5775,  -3.6737,  -7.1368,  -8.9913,  -8.6316,
         -8.3601,  -6.4603,   0.0000,  -3.3769,  -4.0194,  -6.7818,  -8.5984,
         -9.2705,  -8.9952,  -7.0834,   0.0000,  -5.5053,  -7.3827, -11.5063,
        -12.9402, -13.5851, -14.2839, -14.2125, -13.8046, -12.6301, -11.5235,
        -10.0505,  -8.2310, -11.4159, -13.4431, -15.1073, -15.3583, -13.2858,
        -12.5697, -13.3787, -14.9390, -20.1400, -22.2983, -23.6922, -24.7945,
        -24.2404, -24.4331, -24.0019, -22.8785, -20.6089, -19.5086, -22.2762,
        -24.5344, -25.7248, -25.8512, -24.8157,   0.0000, -24.7562, -26.4343,
        -29.8681, -30.8821, -30.2253, -29.7089, -29.5530, -30.3643, -39.8913,
        -41.8080, -31.4633, -32.3610, -33.5807, -34.2840, -35.7176, -36.9142,
        -38.3371, -44.4273, -47.3390, -49.7190, -50.7680, -51.4679, -51.8229,
        -51.4508, -50.5201, -48.9885, -52.5689, -55.8178, -58.1974, -68.5187,
        -73.4779, -76.3807, -79.9365, -82.4917, -86.1527])
tensor([ -3.3741,  -0.3157,  -2.5770,  -3.6740,  -7.1357,  -8.9899,  -8.6315,
         -8.3597,  -6.4601,   0.0000,  -3.3769,  -4.0186,  -6.7819,  -8.5977,
         -9.2708,  -8.9946,  -7.0839,   0.0000,  -5.5013,  -7.3825, -11.5063,
        -12.9395, -13.5878, -14.2835, -14.2104, -13.8024, -12.6283, -11.5223,
        -10.0490,  -8.2301, -11.4112, -13.4407, -15.1071, -15.3573, -13.2845,
        -12.5697, -13.3787, -14.9336, -20.1477, -22.3081, -23.6842, -24.7941,
        -24.2397, -24.4296, -24.0034, -22.8813, -20.6172, -19.5162, -22.2746,
        -24.5340, -25.7308, -25.8615, -24.8152,   0.0000, -24.7562, -26.4344,
        -29.8817, -30.8813, -30.2255, -29.7091, -29.5509, -30.3798, -39.8911,
        -41.8073, -31.4633, -32.3481, -33.5813, -34.2697, -35.7157, -36.9134,
        -38.3561, -44.4379, -47.3521, -49.7313, -50.7668, -51.4649, -51.8226,
        -51.4462, -50.5176, -48.9868, -52.5704, -55.8190, -58.1957, -68.5190,
        -73.4780, -76.3839, -79.9386, -82.4904, -86.1447])
tensor([-2.3409e+00,  0.0000e+00, -3.8910e+01, -3.3982e+01, -3.6587e+00,
        -2.2113e+00, -5.9076e+00, -9.2585e+00, -2.3856e+01,  0.0000e+00,
        -9.4978e-01, -1.9004e+00, -2.2413e+00, -4.4733e+00, -2.2184e+00,
        -1.5416e+00, -4.9846e-01,  0.0000e+00, -2.4982e-01, -1.4432e+00,
        -1.5095e+00, -3.0284e+00, -1.6905e+00, -1.0165e+00, -2.1386e+00,
        -4.3439e+00, -4.6343e+00, -2.4745e+00, -2.5669e+00, -1.1788e+00,
        -1.2643e+00, -2.8717e+00, -1.3953e+00, -6.4185e-01, -4.3861e-01,
         0.0000e+00, -5.6298e-01, -2.0991e+00, -2.1398e+00, -1.4777e+00,
        -1.3475e+00, -1.0482e+00, -6.0546e-01, -4.2556e+00, -4.3206e+00,
        -2.9284e+00, -1.3899e+00, -1.2171e+00, -1.9820e+00, -1.3938e+00,
        -1.5526e+00, -7.1934e-01, -2.0661e-01,  0.0000e+00, -4.1892e-01,
         0.0000e+00, -1.4509e+00, -8.1555e-01,  0.0000e+00,  0.0000e+00,
         0.0000e+00,  0.0000e+00, -3.1925e-01, -4.8536e-01,  0.0000e+00,
         0.0000e+00,  0.0000e+00,  0.0000e+00, -1.1423e-06,  0.0000e+00,
        -3.3690e-01, -1.6648e+00, -1.7475e+00, -1.3389e+00, -2.6458e+00,
        -4.1660e+00, -4.1146e+00, -5.2788e+00, -2.3409e+00, -1.6857e+00,
        -1.1703e+00, -1.3632e+00, -1.4343e+00, -8.8050e-01, -6.5525e-01,
        -2.6236e-01, -5.4861e-01, -1.6136e+00, -4.7265e-01])

The fitted parameters have super large deviations from several runs.
np.linalg.pinv should solve the issue

I think I also went into this before. This seems to be an issue only when using CPU, while it gives consistent results when using CUDA. Not sure why.

@JiQi535 This may be the reason see the linkhttps://github.com/pytorch/pytorch/issues/71222. I also want to say that I didn't discover the problem when I used GPU. Anyway, I think it is better to have more consistent outputs with CPU and CUDA. Thanks Bowen for finding out the problem!


LUCENE-9573 Add Vectors to TestBackwardsCompatibility

This patch adds KNN vectors for testing backward compatible indices

Add a KnnVectorField to documents when creating a new backward
compatible index
Add knn vectors search and a check for vector values to the testing
of search of backward compatible indices
Add tests for knn vector search when changing backward compatible
indices (merging them and adding new documents to them)

@jpountz Thank you for your initial review. I've addressed your feedback in c93a40f108167e55181084e9b4baba9387eaa795.


Remove blank lines from ServiceMonitor

The ServiceMonitor contains blank lines when adding custom labels and annotations:
# Source: cockroachdb/templates/serviceMonitor.yaml
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: cockroachdb
  namespace: "crdb"
  labels:
    helm.sh/chart: cockroachdb-9.1.0
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "my-instance"
    app.kubernetes.io/managed-by: "Helm"
                                                         <---- This line
    my-label: and-a-value-for-it

This PR should fix it.

LGTM. However can you please rebase it with master. I would like to see all jobs pass before merging.

Done. Thank you for taking a look

Thank you for the contribution!


Data loader does not check that segmentation labels are mutually exclusive

load_labels_from_dataset_source builds up the ground truth tensor from individual binary masks. It sets the background mask correctly, but does not check if each pixel is really only in 1 class. If that assumption is violated, model training may later fail when computing the FocalLoss.
Suggestion:

Add a check in load_labels_from_dataset_source. If violated, it should print out the actionable information about how to fix that: Which classes overlap, how many pixels overlap, what are the file names?
we have a script "check annotation quality" that can help diagnose. Can we add that as an optional part of a training run, with a flag check_labels? What might be tricky: at the moment, that script takes a structure name as an argument. We would want all pairs of structures checked for overlap, but we don't want a quadratic runtime.

AB#3908

One model where that problem happens is the Lung model
normal codepath: Raise an exception if the labels are not mutually exclusive.
there should be a commandline switch to not execute the check for mutually exclusive labels.
The error message raised if something is wrong in load_labels_from_dataset_source should suggest to trigger the check annotation quality.

When using FocalLoss, the segmentations need to be mutually exclusive.
when using SoftDice loss, they don't need to be (the loss function will cope, but the models assume that labels are mutually exclusive because we do a softmax)
Maybe we want to have a flag that turns the check for mutually exclusive segmentations on/off? If people use FocalLoss, they must do the check. If SoftDice, not having mutually exclusive labels is at your own risk.

For tests: Could test with FocalLoss in isolation, just feed in tensors of appropriate size.
End-to-end-test: maybe write something like test_runner1, but with a segmentation model.
Check is probably best in InnerEyeContainer setup method


Profile.onSaved Signal

So, I know as of the moment, that saved signals sound useless, they mostly are.
It seems like you're against the idea of having a Signal / Callback which is fired before a auto-save/save happens. I agree with that.
However, I would like one to have as a after-save signal. It can be useful for data-saved notifications and etc.
There are some problems by having a indicator for the player for when their data is auto-saved, like them trying to throttle a profile by leaving as it was saved, but most of the time that's harmless anyway, and it's a developer's choice. I think it would be fine. I personally have something like this on a module I made, for debugging.
In this case, I know you would probably use something like Profile:ListenToSaveCompleted() or Profile:ListenToSucessfulSave() or something to stay consistent.

Would help with dev products so you can see if data was saved (or check when data from MetaTags appears in MetaTagsLatest) without loops

So, I know as of the moment, that saved signals sound useless, they mostly are.
It seems like you're against the idea of having a Signal / Callback which is fired before a auto-save/save happens. I agree with that.
However, I would like one to have as a after-save signal. It can be useful for data-saved notifications and etc.
There are some problems by having a indicator for the player for when their data is auto-saved, like them trying to throttle a profile by leaving as it was saved, but most of the time that's harmless anyway, and it's a developer's choice. I think it would be fine. I personally have something like this on a module I made, for debugging.
In this case, I know you would probably use something like Profile:ListenToSaveCompleted() or Profile:ListenToSucessfulSave() or something to stay consistent.

I'm trying to keep the ProfileService method collection tight so it would try not to distract amateur developers with false pre-assumptions on how ProfileService might work. However...

Would help with dev products so you can see if data was saved (or check when data from MetaTags appears in MetaTagsLatest) without loops

This might be a valid suggestion and I'm willing to add a signal Profile.MetaTagsUpdated   [ScriptSignal] (meta_tags_latest)

This might be a valid suggestion and I'm willing to add a signal Profile.MetaTagsUpdated [ScriptSignal] (meta_tags_latest). This signal would be fired after every finished auto-save.

Do you have any ETA on that? Don't worry if not, but I just started working on a project so it would be helpful

Profile.MetaTagsUpdated [ScriptSignal] has been added.
Thank you for your contribution!
See documentation here:
https://madstudioroblox.github.io/ProfileService/api/#profilemetatagsupdated