When dots in the name, filenames are wrongly defined

When exporting data with names that include dots (.), the filenames are wrongly defined.
Example:
Horizon name in RMS: MyFormation_1.1 --> Filename: myformation_1.gri
This is problematic for several reasons, but especially when multiple horizons get the same outgoing filename.
Example:
Horizon names MyFormation_1.1, MyFormation_1.2 and MyFormation_1.3 will be exported with the same filename, hence only the last one will be exported. Also, if there is a MyFormation_1 present, this last one will look like it is this one.

Looks like anything after the last . in a filename is stripped away here:
https://github.com/equinor/fmu-dataio/blob/0af3599a5e9b759762f563768b5edc95cb0267e3/src/fmu/dataio/_utils.py#L95

But, when a filename with dots is given to XTgeo, it also strips them away. So after this line, "outfile" does not exist.
https://github.com/equinor/fmu-dataio/blob/0af3599a5e9b759762f563768b5edc95cb0267e3/src/fmu/dataio/_export_item.py#L586

A possible solution that intially seems to work is to replace
https://github.com/equinor/fmu-dataio/blob/0af3599a5e9b759762f563768b5edc95cb0267e3/src/fmu/dataio/_utils.py#L95
with...
    path = (Path(folder) / filename.lower())
    path = path.with_suffix(path.suffix + ext)


Add style for table inside docs page

add table css style
change conditional statement to hide sidebar if there is specific hide tag

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Vickel: Watch 1-800-583-05-72

Vickel requests the watch of the watch_number 1-800-583-05-72. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Dragonrage in Charcoal HQ


CI: Remove user as project approver

Remove user dlespiau as a project approver as he is no longer a core
maintainer.
Fixes #420.
Signed-off-by: James O. D. Hunt<EMAIL_ADDRESS>

Coverage remained the same at 55.39% when pulling dea9ac5768163c61b6c2f0ef2b431f99c1714d0e on jodh-intel:remove-approver into 5dea7cbe5041755038941373dc9f16ee9205b596 on clearcontainers:master.

LGTM

lgtm


Add log to metrics plugin

What this PR does / why we need it:
Add LogToMetrics Filter plugin
Which issue(s) this PR fixes:

Fixes #1285
Does this PR introduced a user-facing change?
Nope

Add `LogToMetrics` Filter plugin to Fluentbit component

Additional documentation, usage docs, etc.:
Updated in the codebase itself.

@cosmo0920 the build is failing for some other reason. I have raised PR so that we can get started with the discussions. Meanwhile i will try to look at the build issue. Also running make is actually modifying some other files dont know why. Would need your help in this part.
Do we need to add tests for this plugin?

@benjaminhuo Now the local build is working. I guess make is autoformatting the code and wantedly changing
        modified:   apis/fluentbit/v1alpha2/plugins/filter/zz_generated.deepcopy.go
	modified:   apis/fluentbit/v1alpha2/zz_generated.deepcopy.go
	modified:   go.mod
	modified:   go.sum

Not sure why. I removed those changes and then pushed it for now

@benjaminhuo push to ghcr seems to fail (403 error code). I guess thats issue with some configuration in gcp i guess. Does this seem fine now?

@cosmo0920 Could you check the PR? i  have addressed your comments

Not sure why. I removed those changes and then pushed it for now

The auto-generated files shouldn't be removed.
You should run make manifests generate fmt vet docs-update or even make test docs-update and commit everything generated @Athishpranav2003

Ok fine
Will do it and update

@benjaminhuo Have added them too as well

I put an approve and kicked CI tasks as well.

@cosmo0920 seems like its passing the tests. Anything else i missed?

@benjaminhuo addressed your comments. I wasnt sure about the convention part that you guys followed

@benjaminhuo addressed your comments. I wasnt sure about the convention part that you guys followed

Thanks for the contribution! @Athishpranav2003


Polygon extruded height on terrain

Hello,
does  ol3-cesium support using polygon extruded height on terrain?  As in the link below.   https://cesiumjs.org/demos/Swisstopo.html

Hi @alithegara, these are not extruded polygons but 3D models.


"Black" theme for the OLED screen joy

Well, the Twitter account called my bluff, so I half-remembered how to develop for Android and added this child of the the Dark Theme!
I tried to slim down my additions a bit, but I bet it could be a lot less verbose in styles.xml or at least in ThemeUtils.java with some refactoring of setActivityTheme(), and speaking of ThemeUtils.java perhaps I should have done something in regards to getResourceId()? Still, what I do have definitely appears to work, and though this pull request in GitHub in my browser is searing my 3AM eyes, glancing down at my Nexus 6P running Riot.im is a comforting relief of minimal light :)

Oh, and I would have given translating the additional string a pass but, uhh, the other languages don't appear to have entries for the theme_readables array?

LGTM

@keithzg thanks, this is ace! sorry for calling your bluff on twitter, but thank you for rising to the challenge :D


Seems like it does not adds provided message to the facebook dialog

Only url. Maybe we should for FB put all data (message and the url) into url section?
It is possible to differentiate data for different targets. See http://stackoverflow.com/a/16888058/506954
P.S. all works fine with SMS/email//pinterest sharing.

That's because Facebook wants the user to type their own personal message. See the readme for details.


Version change in next branch fails setup.py version check

Describe the bug
The "-dev" added to the version number in next branch python/depthcharge/version.py causes the version check in python/setup.py to fail.
Depthcharge Version
https://github.com/nccgroup/depthcharge/commit/31042d53992706dbcf3c4e901a94d2dbe93305c9
Target System
Attempted install on Ubuntu 20.04
Python version: 3.8.5
Additional context
Suggested change to regex in python/setup.py:
r"__version__\s*=\s*'(?P<version>[0-9]+\.[0-9]+\.[0-9]+(-[a-zA-Z0-9]+)?)'"

Thanks for reporting this @m0n0cle - I ran into this myself while working on the v0.3.x series and failed to address it. Yikes - my apologies.
With regard to -dev -- I learned that this actually violates the versioning scheme mandated by PEP440.  It should be .dev0 or something to that effect.  I'll need to remember this moving forward, but will still make the version regex more flexible.
Nonetheless, I shouldn't have a next commit broken like this -- need to set up a proper CI pipeline.  Created #73 to track  this.
Additionally, the fix for #23 will require an API addition, so I'll need to bump this to 0.3.0.dev0

Fix in 22e6a74bd1d5f258d15f0ad4e648c212284b9c71.


Adopt psalm and minor fix

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
-

Adopt psalm.
Update dev dependencies.
Fixed: if name is null, then don't add slash to end in ViewRenderer::getViewPath().

👍


[openstackclient] re-create pod when NodeSelector changes

When the NodeSelector gets updated via the OpenStackClient NodeSelector api we have to re-create the pod that it gets scheduled for the new configuration
Jira: OSPRH-9443

/cherry-pick 18.0.0-proposed


Remove BQ logging

If we are  not planning on using BQ for the current cataloging schema. Should we remove any BQ related table building and cataloging transforms from this module?
cc @jbusecke @andersy005

I still need the CMIP stuff in #9 but if we do not need this in a general way, we can kick the rest out. Lets discuss this over on #9?

The way I refactored #9 the CMIP stuff still depends on this base class. Happy to refactor this further, but rn ripping this out will break stuff.


Layout issue in loyalty card branding

Hi,
Can we have a ETC of this issue so we can update.
Else If the issue is solved please put the status_resolved label and close the issue.
Thanks!


[docs] Mention downloading Oracle driver bits

LGTM @vjuranek, feel free to merge yourself, as you see fit.


Improve arm64 tuning

The default tune for the aws-ec2-arm64 machine is v8.0, which might have been true for graviton1 but isn't optimal for graviton3 and certainly isn't for graviton4 (which is speculated as having Arm V2 cores, so supports v9).

Hi Ross, thanks for pointing this out. Will fix asap.
Cheers, Thomas

This is a good overview and mapping instance type to Graviton version to instruction sets.
https://en.wikipedia.org/wiki/AWS_Graviton
-> decided to go for arch-armv8-2a by now


Getting error when trying to import card in composer

Getting error as below, when trying to import an updated card/newly created card.
Error: Failed to save card: admin@test-bna
Command failed
Any help??

@JayasreeVenugopal please reopen if this is still an issue after help given.


Choose a gem and create setup for javascript unit test

It is important to write tests for javascript code and the first step is to define a convention for every project.
I never used this gem, but jasmine does not depend on any framework like ember or angular.
https://github.com/searls/jasmine-rails
It is also important to have the tests running on rake task for jumpup tasks.

If going with jasmine, I highly recommend teaspoon: https://github.com/modeset/teaspoon

I think we can try the https://github.com/fnando/test_squad, I never used but we can create a sample app to test this.

I've been using jasmine-rails [1] and my only complain is that it does not support test coverage. Besides that its great. I think test_squad would be pretty similar in functionality, I would be happy to try it.
For proper coverage support I am afraid we would need to use something like karma. I've used it with sinatra before, and it worked well because we were pointing to the raw js files. If we want to use something like babel, then its a different story because we would need to integrate with the asset pipeline. There is this rails_karma [2] gem which does just that, but I haven't tried it. Also, karma needs node installed.
[1] https://github.com/searls/jasmine-rails
[2] https://github.com/enspiral/rails_karma

I failed to make clear that I've mentioned karma because I think it is the proper choice, I don't think coverage is something we can afford not having.

rails_karma has no tests and integrates with karma itself poorly AFAICT. :-1:
Take a look at teaspoon. It supports istanbul for code coverage and has a bigger community than any of the other gems mentioned here so far.

@lunks :100: looks awesome!

:+1: for teaspoon.


Document shrinking script

Summary Document shrinking script: I thinks it's both in a good enough state and valuable enough to document it's usage.

Current dependencies on/for this PR:

main

PR #5915

PR #5942   👈

PR #5943

This comment was auto-generated by Graphite.


Hello, when will the full code be published?

diff += torch.norm(left_res - right_res)
What does diff stand for

left_res is vanilla transfomer‘s result and right_res is cosFomer's result, the code use same W, compare attention output

Diff is just to verify the correctness of the implementation.
Full code is in progress.


fix bug at KafkaMessageListenerContainerTests.testInvokeRecordInterceptorAllSkipped()

Backport of https://github.com/spring-projects/spring-kafka/commit/5beb8fe607bd131ced632dbc7afa32e11a6ff2dd

Closing since this issue works via automation.


Use cli-based Helm install for tests-smoke conformance workflow

Move conformance-smoke workflow to helm install mode, in an effort to knock one of the line items off of: #25156
This is a small change for the most part since these tests already used Helm, just not viacilium-cli proper.
act isn't cooperating so I'm leaning on CI for troubleshooting, I expect it to fail.

Thanks, I've converted this to draft so you can iterate, don't hesitate to mark as ready for review when you feel you are ready for a first look :)

@nbusseneau ready for a look when you are, ty

Looks good, spotted one small thing to correct below.

TY! Fixed.

Smoke tests passed and this PR does not need any other CI, marking ready to merge.


Configure logging such that log files are not huge

Could start utilising different logger levels etc
Or just print out debugging info to stdout or something
See #46 for where we first noticed this.

ive used GH actions for artifacts up to GBs, is that not ok?

Could implement a sampling rate to the logger, combining this with logger levels like -log_tower, -log_agents would allow finer control over this.

Started a branch for this : infra-log-compression

I don't think is actually an issue worth spending time on


Add explanations about setting envoy

What this PR does / why we need it?
Improve explanations about setting envoy to connect to yorkie gRPC server when using Linux machine.
Any background context you want to provide?
This PR "Add comments to help configure envoy and yorkie containers #131" in yorkie-team/yorkie-codepair deals with the same issue.
What are the relevant tickets?

.
Checklist

[x] Added relevant tests or not required
[x] Didn't break anything

This PR is related to https://github.com/yorkie-team/yorkie-codepair/pull/131


0.7.3 has issues with TypeScript typings

Buggy Behavior
    ERROR in project\node_modules\react-apollo\lib\graphql.d.ts
    (4,10): error TS2305: Module ''graphql'' has no exported member 'DocumentNode'.

    ERROR in project\node_modules\react-apollo\lib\graphql.d.ts
    (4,24): error TS2305: Module ''graphql'' has no exported member 'FragmentDefinitionNode'.

    ERROR in project\node_modules\react-apollo\lib\graphql.d.ts
    (2,1): error TS2688: Cannot find type definition file for 'graphql'.

Expected Behavior
Should see no warnings. <= 0.7.2 works fine
Version

<EMAIL_ADDRESS><EMAIL_ADDRESS>

Oh dang, @jbaxleyiii we should have published the typings as 0.8, since it's definitely a breaking change for TypeScript users.
@alexgorbatchev you can fix this by installing @types/graphql and upgrading to the newest version of Apollo Client I think. We accidentally published a breaking change as a patch version.

I'm going to fix this by re-releasing 0.7.2 again as 0.7.4 and then releasing what's currently 0.7.3 as 0.8.0.

@helfer you're done right? @alexgorbatchev can you verify that 0.7.4 resolves your issue?

Discussion in #398 now. The version to install should be 0.8.1.


UnicodeEncodeError

When I use the jq function in Windows 10, I get the following error:

When I change the code in line 200
out, err = p.communicate(bytes(raw_json))

to
out, err = p.communicate(raw_json.encode('utf-8'))

, it works.
Hope it helps. Or maybe another better solution.

change line 200 to
out, err = p.communicate(unicode(raw_json).encode('utf-8'))
I fork and in my repo


Unable to start bgpd with libmnl

on ubuntu-22.04 using openbgpd-8.1, I'm stuck with a problem. When I do bgctl show fib I get permission denied，I found that it automatically loads the kroute-disabled.c. Then I downloaded libmnl using apt-get install -y libmnl-dev, but bgpd cannot start.
The escription is as followswhen I do bgpd -d:
startup
PF_KEY not available, disabling ipsec
mnl_attr_validate for RTA_METRICS failed.
mnl_cb_run error
failed to load routing table 0
route decision engine ready
peer closed imsg connection
fatal in RDE: Lost connection to parent
session engine ready
rtr engine ready
peer closed imsg connection
peer closed imsg connection
fatal in RTR: Lost connection to parent
SE: Lost connection to parent
session engine exiting
terminating
I want to know which kroute file should I choose, kroute-linux.c or kroute.c or others，and what dependencies should I install like libmnl?

Same problem on RHEL 8.5

See 9abfa3f135f62515557c78cc182dcc3a683c125e which is hopefully a fix for this issue.
RTA_METRICS is an undocumented mess. Since we don't use it, just ignore the object.
Since my linux test systems don't return RTA_METRICS I never seen this issue.

No feedback, consider this closed


Using Route's render prop instead of component prop for src/pages/App.

nice work - would love it if there's some explanation as to why we did this :) I think it would be good not only for education purposes but also for documentation

Yeah mb about that. I did write some explanation in the issue description but I'll just put it here as well.
The reason why we are switching from component prop to render prop for Route in src/pages/App is because:

When using component prop, mounting and unmounting of the React component/page that the Route points to happens at every re-render. Using the render prop prevents this from happening, which will improve the performance/speed of the webapp (since (un)mounting is expensive). Also, we get smaller stack trace for (memory leak) errors if we use render prop, meaning it's a lot easier to identify where the (memory leak) errors are coming from.


Ability to generate sln/csproj in CI

Context

I'd like to run some tools like StyleCop, which I'm able to invoke locally with dotnet build ./project.sln. I'm wondering if theres some way to use various Game-CI processes to bootstrap the SLN file so these tools could be used in a pipeline.
This may already be possible with the tools, but I haven't figured out how...

If you have the JetBrains Rider Editor package installed, you could try using unity-builder with buildMethod: Packages.Rider.Editor.RiderScriptEditor.SyncSolution
Does that work for you?

We dont currently use that (we're mostly using free/open source tools) but it sounds promising. Will look into it. I would assume it would generate references to DDL's that are only valid within the container runtime. Is there a way I would be able to run arbitrary tools inside the container afterwards?

At that point, I recommend usbking github actions inside the container.
That's what I do for running Sonar.
See my lint job:
https://github.com/finol-digital/Card-Game-Simulator/blob/11d7f6fa222ef001b142fdcbf3691b5eb50a03b5/.github/workflows/main.yml#L82

This seems promising! Thank you!


Windows: Dragging kit window has some "lag"

I perceived that every time I intend to drag the kit Window it "lags" and when is out of focus it disappears.
Is this intentional?
Edition:	Windows 10 Pro
Version:	22H2
OS build:	19045.2486
Experience: Windows Feature Experience Pack 120.2212.4190.0

Lag isn't intentional. Any chance you could make a video of it?
Also, could you check the ~/.kit/logs/kit.log and see if there are a lot of "Resized" calls firing or anything suspicious?
If you want to keep a prompt open when losing focus, you need to "ignoreBlur":
await arg({
    placeholder: "This should stay open",
    ignoreBlur: true
}, ["Yay", "Huzzah!"])

Logs: https://pastebin.com/KYzyz1AW
Video: https://streamable.com/pu7c4x
Brand new first-time installation

Does dragging lag after the install is complete?

Does dragging lag after the install is complete?

Yes, after a PC restart it still behaves like shown

@FlareFlo Can you adjust the log level to "silly", drag the window around, then check the logs again?
(On windows, right-click on the tray icon)

Hi guys, I had exactly the same issue on the same Windows version. To solve it I had to execute the program in Windows 7 compatibility mode (right click on the program icon > properties > compatibility tab). Hope that this workaround can help to fix/reproduce the issue.

https://pastebin.com/HaqHK5eT @johnlindquist

@Evyweb any idea why that would only be required on certain machines? Really curious if that's something I can fix on our end.

I don't really know what happens but if I remove the option "Display the content of windows when moving" (may not be the exact translation) in the Windows performance settings, I can run Kit without changing the compatibility mode. Maybe something related to the blur effect in the background of the program that Windows 10 doesn't like? Do we have an option to remove this blur effect that I can eventually test quickly?

@Evyweb No options yet.
It uses the https://www.npmjs.com/package/glasstron-clarity lib for the window background effect. I'll put an option in the next build to be able to turn it off.

Did this setting every get implemented?  If so what is it called?


Git Completions Out of Date (completions @ v2.21 vs latest v2.26)

In discussing / working on #1525 for the git switch, I realized that the current git completions don't support the switch command.
Looking into a bit, I see the lats update to the git completions was:
@trmaphi : Update bash completion for git v2.21.0
The switch command was added to git in v2.23, so that explains why it doesn't work.
I'm creating this issue to:

Track the fact that the git completions are a bit out of date.
Give a place to ping @trmaphi to see if they might be interested in updating them? :)

cc: @trmaphi

@davidpfarrell, I haven't take a look at git switch  and limited to test in only on macOS. So, feel free to open MR and work on it. Thanks to get me involved 😄


Array.from fails with Set on IE11

On IE11 (on Windows 10, if that's important), when Array.from is passed a set, the Array.from polypill is failing to detect the set.  This appears to be an issue with the order in which polyfills are being loaded:

Array.from first captures the Set.size property descriptor using Object.getOwnPropertyDescriptor(Set.prototype, 'size').get
Then the Set polyfill kicks in and defines a new Set.size prototype using Object.defineProperty(Set.prototype, 'size', {

Placing a breakpoint in the Array.from polyfill's isSet function, you can see that:

executing setSize.call(set) throws an exception
executing Object.getOwnPropertyDescriptor(Set.prototype, 'size').get.call(set) succeeds
Object.getOwnPropertyDescriptor(Set.prototype, 'size').get === setSize is false

In other words, using an uncaptured value for the Set.prototype.size.get function succeeds, but using the previously captured value fails. So it looks like Array.from is capturing IE11's native Set.size.get function, but then later trying to invoke the polyfilled version and throwing an exception as a result.
Here's what the service is loading
UA detected: ie/11.0.0
Features requested: Array.prototype.@@iterator,Array.prototype.find,Array.prototype.includes,IntersectionObserver,Promise,Symbol,WeakMap,default,fetch,matchMedia,navigator.sendBeacon

Earlier resolutions
```
Object.assign, License: CC0 (required by "default", "_Iterator", "_ArrayIterator", "Array.prototype.@@iterator", "Array.from")
Symbol, License: MIT (required by "Map", "default", "Set", "Symbol.iterator", "Array.prototype.@@iterator", "Symbol.species", "_Iterator", "_ArrayIterator", "Array.from", "Symbol.toStringTag")
Symbol.iterator, License: MIT (required by "Array.prototype.@@iterator", "Map", "default", "Set", "_Iterator", "_ArrayIterator", "Array.from")
Symbol.toStringTag, License: MIT (required by "_Iterator", "_ArrayIterator", "Array.prototype.@@iterator", "Array.from", "default")
 _Iterator, License: MIT (required by "_ArrayIterator", "Array.prototype.@@iterator", "Array.from", "default")
Object.setPrototypeOf, License: MIT (required by "_ArrayIterator", "Array.prototype.@@iterator", "Array.from", "default")
String.prototype.includes, License: CC0 (required by "default", "String.prototype.contains", "_ArrayIterator", "Array.prototype.@@iterator", "Array.from")
String.prototype.contains, License: CC0 (required by "_ArrayIterator", "Array.prototype.@@iterator", "Array.from", "default")
_ArrayIterator, License: MIT (required by "Array.prototype.@@iterator", "Array.from", "default")
Array.prototype.@@iterator, License: CC0
Array.prototype.find, License: CC0
Array.prototype.includes, License: CC0
Event, License: CC0 (required by "default", "IntersectionObserver", "CustomEvent", "XMLHttpRequest", "fetch", "navigator.sendBeacon")
IntersectionObserver, License: CC0
Promise, License: MIT (required by "default", "fetch")
WeakMap, License: https://github.com/webcomponents/webcomponentsjs/blob/master/LICENSE.md
fetch, License: MIT
navigator.sendBeacon, License: MIT
Number.isFinite, License: MIT (required by "Array.from", "default")
```

Number.isNaN, License: MIT (required by "default", "Array.from", "Map", "Set")
Array.from, License: CC0 (required by "default")
Array.of, License: MIT (required by "default")

followed by
```
Array.prototype.fill, License: CC0 (required by "default")
CustomEvent, License: CC0 (required by "default")
_DOMTokenList, License: CC0 (required by "DOMTokenList", "default")
DOMTokenList, License: CC0 (required by "default")
_mutation, License: CC0 (required by "DocumentFragment.prototype.append", "default", "DocumentFragment.prototype.prepend", "Element.prototype.after", "Element.prototype.append", "Element.prototype.before", "Element.prototype.prepend", "Element.prototype.remove", "Element.prototype.replaceWith")
DocumentFragment.prototype.append, License: CC0 (required by "default")
DocumentFragment.prototype.prepend, License: CC0 (required by "default")
Element.prototype.after, License: CC0 (required by "default")
Element.prototype.append, License: CC0 (required by "default")
Element.prototype.before, License: CC0 (required by "default")
Element.prototype.matches, License: CC0 (required by "default", "Element.prototype.closest")
Element.prototype.closest, License: CC0 (required by "default")
Element.prototype.prepend, License: CC0 (required by "default")
Element.prototype.remove, License: CC0 (required by "default")
Element.prototype.replaceWith, License: CC0 (required by "default")
Symbol.species, License: MIT (required by "Map", "default", "Set")
Map, License: CC0 (required by "default")
Node.prototype.contains, License: CC0 (required by "default")
```

Set, License: CC0 (required by "default")
String.prototype.endsWith, License: CC0 (required by "default")
String.prototype.startsWith, License: CC0 (required by "default")
URL, License: CC0 (required by "default")

Does https://github.com/Financial-Times/polyfill-service/pull/1385 help this one at all?

It doesn't appear so. Going to https://qa.polyfill.io/v2/docs/ and doing Array.from(new Set([1, 2, 3])) in IE11 yields an array of length 0.

@JakeChampion @triblondon This one may still be an issue, I remember opening https://github.com/Financial-Times/polyfill-service/issues/1161 a while back, but maybe this one crept up again.

We use your service on our project. And faced this issue with IE. Quick fix for us was moving block with "// Map" before "// Array.from" in polyfill.js file.
// Map
(function(global) {
...
})

// Array.from
// Wrapped in IIFE to prevent leaking to global scope.

Rolling back to 3.22 works so indeed this is a regression between those two version

@JSteunou Is it possible to retrieve that version as a user of the service? I was unable to find such a parameter in the docs.

@timm-gs https://github.com/Financial-Times/polyfill-service/blob/master/package.json#L142

@timm-gs not if you're using the online service. You can rollback if you run your own. Using npm or git you can get the specific version you want.

Array.from() and new Set() are not usable on IE 11, the resulting Array is always empty. The same thing happens when using [...new Set()]

Just come accross this issue when trying to create an array of unique items like so:
const toUniqueArray = array => [...new Set(array)];
A simple fix that works in IE11 and doesn't cause problems in other browsers is to replace the above with:
const toUniqueArray = array => [...new Set(array).values()];
I'd guess (but haven't tested) that this would work with Array.from as well.

Can this problem please be resolved? It seems to have been resolved before: #1161


Unbundle error similar to #75

I have the exact error shown in #75.,   I have Node 5.6, VS 2015, Aurelia beta 1.1.6.  I tried jspm update.  Nothing helped.  This is straight skeleton code and no customizations.  Any guidance is appreciated.

That.S an npm/node thing, not jspm. Mabe try npm install aurelia-bundler or so to get the last Version there

I just ran npm install aurelia-bundler.  Still the same.

This fixed it,
var ctx = vm.createContext(sandbox);
vm.runInContext(cfgCode, ctx); // I changed the second parameter from sandbox to ctx
return sandbox.System.cfg;
The update still had this line in config-serializer


[#152638275] Add separate GOV.UK crown logo image for PaaS HTML emails

What
I copied source/images/gov.uk_logotype_crown.png as a separate file to be
used in the PaaS HTML email headers. This way we can avoid breaking the emails
if the original logo is changed.
How to review
After merge please check if https://www.cloud.service.gov.uk/images/email/gov.uk_logotype_crown.png becomes available.
Who can review
Not @bandesz

This repo serves https://docs.cloud.service.gov.uk/ whereas it's alphagov/paas-product-page that serves https://www.cloud.service.gov.uk/
I think it's OK to use the existing URL in the product pages, but we should add a test that asserts it's there and describes the additional usage so that people get feedback if we change it.

After merge please check if https://www.cloud.service.gov.uk/images/email/gov.uk_logotype_crown.png becomes available.

Did you mean docs.cloud.service.gov.uk? That's where this site is deployed. If you want www.cloud.service.gov.uk you'll need to update alphagov/paas-product-page.

After talking with @alext I'll close this PR as we're going to use the existing logo from the paas-product-page. I'll add a test to that repo to make sure we don't delete that specific image.


Adds urgency and size to the clipboard

Problem: At the moment the copied text only include the links and not the size and urgency
Solution: We add a popup to the extension which allows setting size and urgency and it will be included in the produced clipboard

Thanks for doing this!!


Consider using other Gene2Phenotype panels as evidence

Currently we only use the Developmental Disorders (DD) gene panel to generate evidence but G2P also have separate panels for cancer, eye disorders and skin disorders.

Closing as it's a duplicate of #1078


Can we use this for sequential logging on a react native application ?

Hello,
We use Sentry for error reporting in our react native iOS and Android application.
This is not convenient for debugging purpose, we would like to configure some sequential logging but we can't find a good service.
Our platform is hosted on GCP, do you think we can use this client side on a react native app or is it only for server side ?
Best regards and thanks!

Thank you @kopax-polyconseil for reaching out and sorry for late response.
Unfortunately, this library is designed to be used on server side and currently there are no plans to make this library to be client side compatible. And I never tried to run this library on a client side :-)
As for client side logging, we have the experimental library stackdriver-errors-js which provides an ability to integrate directly with Google Cloud Error Reporting, so it could be used at least to report errors. Thats said, I am not sure if that will work with your native iOS/Android application - please take a look and let me know if it could work, I would really appreciate your input on this.

Hello @losalex , we already use Sentry for error reporting and it is "better", what we are looking now is to activate some sequential logging on demand on specific device. Do you have another solution to recommend ?

Hi @kopax-polyconseil, I am not aware of any other client side solution which I can recommend.
If you have any server side components in your solution, you could definitely leverage those to propagate logging to Cloud Logging, but as for clients I am not aware of any other solution.
One thing to mention, there is a blog which describes some technique to collect logs from browser however I am not sure if that would solve your problem since it still assumes you will need to run some server side component in GCP.

@kopax-polyconseil, I am going to close this issue - feel free to reactivate it or comment if you have any more questions. Thank you!


Builders

Adds a barBuilder and backdropBuilder so that they can be wrapped in PointerInterceptors or other widgets

Also fixes an issue with Flutter 3.10

Sorry for the long time it took to review this. I will add the changes to the 0.5.1 branch and upload the corresponding version to pub.dev.


Add Minecraft 1.17 support

Add new block types and (currently unused) biomes, as well as a README for future contributions.
Opening as draft for now, as I didn't test this yet.
Closes #16

works great! Tested with an upgraded world from 1.16.5 to 1.17.
Here's a screenshot of roughly the same area from main branch vs mc1.17 branch. Note the house on the top-right with the copper roof, and also the dirt paths.

The only issue I found was that the amethyst_block was missing.
Warning: unknown block type: minecraft:amethyst_block
Testing locally, I got the same results as the pull request:
Running ./blocklist.py diff data/1.16.5 data/1.17 shows that the amethyst_block is there:
+ amethyst_block
+ amethyst_cluster
+ azalea
+ azalea_leaves
...

But when running ./blocklist.py added data/1.16.5 data/1.17 | jq -R -S --tab '[inputs] | map({key: ., value: {}}) | from_entries', it seems that the amethyst_block is missing:
{
        "amethyst_cluster": {},
        "azalea": {},
        "azalea_leaves": {},
...

which is the same as found in https://github.com/NeoRaider/MinedMap/blob/mc1.17/resource/blocks.json
--
Also, huge thanks to writing the documentation on the resources section! It really helps!

Okay, I've fixed up the jq command not to miss the first entry and updated the PR. Thanks for testing!

Works perfectly now in my testing!
Here's a render with the amethyst_block working as intended


Trouble linking

Hi,
I am testing out your statically compiled interpreter, and it seems to build fine.
I have a test project I'm using to see if I can link to it, and I have this compilation error:
Error	1	error LNK2019: unresolved external symbol __imp__Py_Initialize referenced in function _main	static_python_test.obj	static_python_test_2
Running dumpbin /all on my generated pythonembed.lib shows that the expected symbols are there:
B297C2 _Py_Initialize
But I don't understand why the linker is looking for __imp__Py_Initialize and not _Py_Initialize.
Are you able to point me in the right direction please?
Thanks,
James

It may be necessary to compile your code with the macro Py_BUILD_CORE defined, so pyconfig.h does not mark Py_Initialize as a dllimport.

In fact since posting, I tried with Py_NO_ENABLE_SHARED defined, and got past the __imp prefix thing.
I also found the blog post you did about this with the extra flags, so switched from building my project in VS 2015 to the command line environment.  I actually tried both from the 7.1 SDK and from the VS2015 developer prompt with different resutls.  Here is my make file based on your flags:
PYTHON_V=2.7.3
OPENSSL_V=1.0.1c
ROOT=..\\

CFLAGS=/c /GF /MP4 /nologo /EHsc /I$(ROOT)openssl-$(OPENSSL_V)\inc32 \
    /I$(ROOT)Python-$(PYTHON_V)\Include /I$(ROOT)Python-$(PYTHON_V)\PC \
    /DPy_BUILD_CORE /MD /W4 /O2
LINKFLAGS=/MACHINE:X86 /RELEASE /LTCG
LIBS=$(ROOT)openssl-$(OPENSSL_V)\out32\libeay32.lib \
    $(ROOT)openssl-$(OPENSSL_V)\out32\ssleay32.lib \
    $(ROOT)Python-$(PYTHON_V)\PCbuild\pythonembed.lib ws2_32.lib
CC= cl
LINK= link

all: simple.exe

simple.obj:
  $(CC) $(CFLAGS) simple.c

simple.exe: simple.obj
  $(LINK) $(LINKFLAGS) -out:simple.exe simple.obj $(LIBS)

The code is very simple:
#include <stdio.h>
#include <Python.h>

int main()
{
Py_Initialize();
return 0;
}

A sample of some link issues.
7.1 SDK:
MSVCRT.lib(MSVCR100.dll) : error LNK2005: _abort already defined in LIBCMT.lib(abort.obj)
pythonembed.lib(unicodeobject.obj) : error LNK2001: unresolved external symbol __imp__CharPrevA@8
libeay32.lib(cryptlib.obj) : error LNK2001: unresolved external symbol __imp__GetUserObjectInformationW@20

VS 2015 Dev env:
pythonembed.lib(pythonrun.obj) : error LNK2001: unresolved external symbol __imp__sprintf
OLDNAMES.lib(execve.obi) : error LNK2001: unresolved external symbol __imp__execve
libeay32.lib(cryptlib.obj) : error LNK2001: unresolved external symbol __imp__GetUserObjectInformationW@20

I think the "already defined" error points to the python.lib and your code not being compiled with the same flags or compiler. Especially the /MT or /MD switches have to match in both builds.

I have managed to build the executable now.
Thanks for your help with this Christian.  Actually required me to just get my head down and learn how it all works.  It wasn't those switches in fact, but some changes to my Makefile did it for me.  Had to include the extra libraries shown below and change the nodefaultlib switch:
PYTHON_V=2.7.3
OPENSSL_V=1.0.1c
ROOT=..\\

CFLAGS=/c /GF /MP4 /nologo /EHsc /I$(ROOT)openssl-$(OPENSSL_V)\inc32 \
    /I$(ROOT)Python-$(PYTHON_V)\Include /I$(ROOT)Python-$(PYTHON_V)\PC \
    /DPy_BUILD_CORE /MD /W4 /O2
LINKFLAGS=/MACHINE:X86 /RELEASE /LTCG /NODEFAULTLIB:LIBCMT
LIBS=$(ROOT)openssl-$(OPENSSL_V)\out32\libeay32.lib \
    $(ROOT)openssl-$(OPENSSL_V)\out32\ssleay32.lib \
    $(ROOT)Python-$(PYTHON_V)\PCbuild\pythonembed.lib ws2_32.lib msvcrt.lib user32.lib shell32.lib advapi32.lib oleaut32.lib Gdi32.Lib Ole32.lib
CC= cl
LINK= link

all: simple.exe

simple.obj:
  $(CC) $(CFLAGS) simple.c

simple.exe: simple.obj
  $(LINK) $(LINKFLAGS) -out:simple.exe simple.obj $(LIBS)

Incidentally, to get the initial lib built on Windows 10, some modifications of the process in your README were necessary.  I didn't mention this before, but now I have a build it might help someone else get there:
Windows 10 Notes:

To install the  7.1 SDK with the full MSBuild tools, it is necessary to alter all locations in the registry
(8, not the 2 reported, need to search) where the version of the installed .NET software is recorded:

http://stackoverflow.com/questions/32091593/cannot-install-windows-sdk-7-1-on-windows-10

GNU patch doesn't work.  Triggers UAC and loads in a new console, doing nothing.  Instead use Cygwin's patch and
put the Cygwin bin folder where it's located in the path.

Neither versions of 7zip downloaded came with a 7za.exe, so it was necessary to rename 7z.exe to 7za.exe

nasm didn't install in the path supposed by the above path update.  Instead use :

SET PATH=C:\Program Files\7-Zip;C:\Users\james\AppData\Local\nasm;%PATH%

I have now started to get your examples/embed.c, and have made some progress, but I am stuck with this:
error LNK2001: unresolved external symbol _initcustomimport

I can't find any reference to that function.  In fact, if you google it, it leads you back to this project as the only result.

No, if you don't have a custom importer ready, you can just delete lines 19-40 in the example. Sorry about the confusion!

I am sure it would have been obvious if I had really studied the code, but I am new to c and Python, so looking for as many clues as I can get.
My interest in your sample code is that it seems I could use it towards my goal, which is to create an standalone executable containing a specific package I have.  This package calls for numpy and scipy, so I was hoping that using the direction in your example, I could perhaps call these two libraries at runtime rather than trying to statically build them into pythonembed.lib, which I know will be hard.

Well, writing a custom importer without knowing details about Python and it's C API will be hard - but doable!
Linking numpy and scipy statically will probably be a similar effort to what I did in the project here.

Ok.  But do I actually need to write a custom importer. Can I not just
invoke the built in importation mechanics?
I am happy to bundle the external ready made libraries, so it isn't
necessary to go the static route if it is avoidable.
On 13 Apr 2016 09:45, "Christian Hofstaedtler"<EMAIL_ADDRESS>wrote:

Well, writing a custom importer without knowing details about Python and
it's C API will be hard - but doable!
Linking numpy and scipy statically will probably be a similar effort to
what I did in the project here.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/zeha/python-superstatic/issues/2#issuecomment-209308909

You need a custom importer if you want to ship a single binary file, which can not rely on external files -- by default, even the static python lib will load (pure) Python modules (resembling the standard library) from an external folder.
If you want to replace that, you need a custom importer. As hinted in the example, Python's zipimporter can be used as a starting point for such an importer.

Very grateful for your engagement on this Christian.
Let me make it clear, as I mentioned, I am happy to rely on external files.  I do not need to ship a single binary.
What I want is to build some stuff, or to be precise, my stuff into the binary.  Public stuff like numpy and scipy I don't mind if my new Python calls these externally as normal Python would.  In fact it's better.

I see what you mean, you can't have a statically linked python load c extensions.
So as you say I'll have to try to build Numpy and Scipy statically.  Wish me luck.


Add a quick status utilility

It would be nice if there was a quick way to get stats about an action. So something like:
wsk stats ACTIONNAME

Which would report a very brief summary:
ACTIONNAME has had X invocations in 24h. Average duration is 219ms. Error rate is 2%

Obviously Bluemix's online reporting can show some of this and you can build your own tools to report similar values, but I'm thinking that the CLI could provide a quick summary of your action and that could be pretty useful.

Issue moved to apache/incubator-openwhisk-cli #123 via ZenHub


HADOOP-18504. Fixed an unhandled NullPointerException in class KeyProvider

Description of PR
JIRA: HADOOP-18504
How was this patch tested?
Modified an existing unit test testParseVersionName of test class TestKeyProvider to verify.
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 14s

trunk passed

+1 :green_heart:
compile
27m 11s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
21m 58s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 37s

trunk passed

+1 :green_heart:
mvnsite
2m  4s

trunk passed

+1 :green_heart:
javadoc
1m 42s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 25s

trunk passed

+1 :green_heart:
shadedclient
25m  2s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  7s

the patch passed

+1 :green_heart:
compile
24m 10s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
24m 10s

the patch passed

+1 :green_heart:
compile
21m 49s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m 49s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 23s

the patch passed

+1 :green_heart:
mvnsite
1m 59s

the patch passed

+1 :green_heart:
javadoc
1m 17s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  9s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m  2s

the patch passed

+1 :green_heart:
shadedclient
23m 44s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m  8s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m 16s

The patch does not generate ASF License warnings.

229m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5064/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5064

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 3024a9566db8 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 59fb5805137fb79e42f8e1882c9e32a125971858

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5064/1/testReport/

Max. process+thread count
1369 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5064/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

sorry, i'd meant to say requireNonNull(); its what we are using to validate arguments now

No worries at all, we have updated the code. Kindly review.


Create CsvEventQuery to query and filter VIDs from CSV file in KiND

Create CsvEventQuery to query event data from a CSV file, create event template, use eventFilter to filter events, and output the filtered VIDs. The CsvEventQuery is used with KiND deployment. Some local k8s resource configs are modified to run with large CSV file.
This PR is co-authored with @jcorilla by merging https://github.com/world-federation-of-advertisers/cross-media-measurement/pull/650

This change is

build/repositories.bzl line 28 at r7 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
The DO_NOT_SUBMIT comment is to indicate that we don't want to submit without replacing this commit with a released version. The preferred form is the same as TODOs, e.g. DO_NOT_SUBMIT(world-federation-of-advertisers/common-jvm#156): Replace with version once released from main., which would offer more context.
I imagine that the commented-out version number is just what was there when this PR was created, and it has since been updated.

Done. Update to common-jvm release version number

src/main/k8s/local/README.md line 10 at r7 (raw file):
Previously, matthewclegg (Matthew Clegg) wrote…
To me, the previous formatting seemed a little more readable.  Why the change?

It's formatted with Google mdformat? https://g3doc.corp.google.com/devtools/markdown/mdformat/g3doc/index.md?cl=head

src/main/k8s/local/README.md line 10 at r7 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
I had the same problem in my PR. mdformat requires lists after a paragraph to have a blank line between, which is consistent with original Markdown implementations. Therefore the formatter saw what was intended to be a list as part of the paragraph before it.
The "correct" formatting for the above section is:
Minimum Version Required:

-   KiND: v0.13.0
-   kubernetes server: v1.24.0
-   kubectl: compatible with kubernetes server

Done.

src/main/kotlin/org/wfanet/measurement/loadtest/dataprovider/data/synthetic-labelled-events.csv line  at r7 (raw file):
Previously, matthewclegg (Matthew Clegg) wrote…
Is this the same as the file cross-media-measurement/src/main/k8s/testing/data/synthetic-labelled-events.csv?  Just curious, why move it?

I copy the file to this directory and use it as a sample file for CsvEventQuery. I feel it makes more sense to put the CSV file under the same directory with CsvEventQuery?

src/test/kotlin/org/wfanet/measurement/loadtest/dataprovider/CsvEventQueryTest.kt line 73 at r7 (raw file):
Previously, matthewclegg (Matthew Clegg) wrote…
Could you add another test to check the case when the event filter is not specified in the measurement request?

Done.

src/main/k8s/testing/secretfiles/resource_requirements_kind.yaml line 1 at r20 (raw file):
Previously, renjiezh wrote…
Do we want to move this file to k8s/local/?

I don't have a preference and now I just put it in the same folder as resource_requirements.yaml

src/main/kotlin/org/wfanet/measurement/loadtest/dataprovider/ForwardStorageEdpSimulatorRunner.kt line 33 at r7 (raw file):
Previously, matthewclegg (Matthew Clegg) wrote…
I agree with you that it would be better to have a single option for the file path.  This is what I had intended, I was just a little loose with my language.  Thank you for pointing that out.

Now use a separate bazel target edp_simulators_kind_csv and specify the local CSV filepath in the kubectl cp command


⚠ ClamAV has degraded performance

In 6b1ef54, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 188 ms

Resolved: ClamAV performance has improved in 61858ac after 542 days, 13 hours, 39 minutes.


Multiple instances of the polyfill leads to unexpected behaviour

I am trying to include the latest version of the polyfill and there is a possibility of an existing version (0.5.4) already included inlined in the page that might not be able to be removed. The two versions seem to work and with window.customElements.define being polyfilled for older browsers and not for native implementations.
I noticed that if you include the latest version of the polyfill it leads to strange behaviour, after it is included the second time the following (caught) exception occurs:
DOMException: Failed to execute 'define' on 'CustomElementRegistry': the name "document-register-element-a" has already been used with this registry
And the second time:
DOMException: Failed to execute 'registerElement' on 'Document': Registration failed for type 'document-register-element-a'. A type with that name is already registered.
How is performance affected if window.customElements is polyfilled for modern browsers?

Latest patch fixes this 👋


[AppService]: fix #13646 - Unable to create App Service Plan in a different resource group to App Service Environment

Description
Fix 13646
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

AppService

/azp run


chore(deps): bump unstructured to 0.10.25

Revert the workaround added in #285

Oops my bad, there are regression on docker output brought by https://github.com/Unstructured-IO/unstructured/pull/1801 on this change
I didn't notice this since i saw the local output is better...

OK, thanks for mentioning @yuming-long . 0.10.25 has other important changes, so let's update the test and create an issue to track fixing the regression.

issue to track table regression: https://github.com/Unstructured-IO/unstructured/issues/1853


implement map source for measure/show altitudes

there are maps which provide altitude informations (from swisstopo / GeoAdmin) and similar to zskarte/zskarte#25 it would be possible to display altitudes along to a drawed line
this information could be provided as additional information in the line-symbol-detail window
example for altitude information on https://www.schweizmobil.ch/de/wanderland/routen/lokale-routen/route-0262.html (see "Aufstieg/Abstieg" or download "Höhenprofil zeigen" PDF)

we have discussed this in the project team and do not see much added value in this issue. or the effort to integrate something like this in relation to the added value is not in a pleasant ratio.


Fix scale when beginAtZero is false and datasets contain null values

PR for issue #1016

Closing this one (bad commits) and opening #1026


Add 429 Too Many Requests

Adding an image for the 429 status code "Too Many Requests". The image is an edited version of this one, which is free to use. I think the pizza boxes represent the "requests", and there a quite a bit of them.

This is awesome, thanks for contributing! ✅


Wrong values while converting the model from Keras to ONNX

Hello,
I have built a model for Semantic segmentation of street scenes in Keras and wanted to convert it into ONNX as I have to work in Windows ML.
I could successfully convert the model to ONNX and when I load the model and evaluating it, no error but if I print the output values they are all 0.
This is the following script I used to convert the same:
**import keras2onnx
import onnx
from keras.models import load_model
model = load_model(filepath="unet_full_model.h5")
onnx_model = keras2onnx.convert_keras(model=model, channel_first_inputs= input_1)
onnx.save_model(onnx_model, "new_unet.onnx")
print("DOne")**
Could someone please help me on this?

@Rathna21 Can you share the keras model file please?

@jiafatom Thanks for the reply:)
Yea please find the attached Keras model.
https://drive.google.com/file/d/1y2TP-2mhDkgkCOJKBTvPdAE0hTPJuECd/view?usp=sharing

I see the output mismatches the keras result. Need some time to debug (possibly check each layer to compare the output, which is non-trivial). Just wonder if you can give me a sub model, for example, only containing the first Conv2D and BatchNormalization, and then I can quickly test it to see whether it is correct.

@jiafatom
Thanks for the reply.
What do you mean by a sub model?
Should I create a new model and train and send or how could this be done?
And I have one more query?
With your keras2onnx script I am trying to covert yolo model in keras to onnx.
But at the end there is a transpose layer which changes the shape of the output?
Is there a way i can eliminate this?
Please find the screenshot.

Yes, can you train a new model with less layers (just include the first Conv and Batchnormalization) to see the output matches? This can help locate which layer contains issues, especially I want to see Batchnormalization.
About outputshape, the onnx model should match your keras model output shape, this is why it has a transpose here. Are you talking about the keras model output shape is different?

@jiafatom  Okay I will train the model with few layers and upload the keras model.
And about the output shape, I have converted Darknet yolo model into Keras using ya2dk script and want to convert the keras model to ONNX and work in Windows ML .
The actual problem is, in Keras the way it accepts input and output shape is { batch_size, height , width, channels } but in Windows ML it is { batch_size , channels , height, width }
So, i used your script and gave channels_first_input as my input so now the input shape in onnx model is like { batch_size, channels, height, width} But i want this channels first in output shape as well.
Please find the attached issue.
https://github.com/Microsoft/Windows-Machine-Learning/issues/205
I have created the above mentioned issue for some other problem and some one helped me with channels_first_input . But is there a way I can get channels_first for output as well?
ALSO:
While converting my model which I have already sent you , I converted into onnx giving channels_first_input so, is this the problem for mismatch in output values?
Please do help me with this?

@Rathna21 the output shape depends on the keras model. I checked the model you shared with me, the input data shape is (2, 256, 512, 3), and the output shape is (2, 256, 512, 4) when I do model.predict(data) using keras. This is how keras gives you, and our onnx output shape matches this.
channels_first_input is to give input shape channel first, which is the way works in WindowsML. We don't do channel_first_output, I don't see a reason why we do this, onnx output shape just match keras output shape. keras result is not channel_first_output, don't understand why you need channel_first_output?
(if you want to do channel_first_output, you can add a transpose layer in keras layer)

@jiafatom Correct as you said the model I shared with you has output shape (2,256,512,4). That is what even I want. Thats fine. The problem in that is my output values .
But I have another issue. I am working with yolo as well. I need to integrate the yolo model in Windows ML. YOLO in darknet is converted into keras using yad2k script. So, in keras it changes the input and output shape as (batch_size, height, width, channels) . But in windows ML its different. When I see yolo model in onnx model zoo, the output shape is (batch_size, channels , height, width) . Its the same in CORE ML as well. So, further to get the bounding boxes this is the shape I require in Windows ML. So, like channels_first_input I am expecting a channels_first_output such that if I want , I can enable else disable like channels_first_input.
As you said , Can I load the model in keras , do model.predict(data) and do transpose of that result array and add it back to model and then convert the yolo model into onnx ? Is it possible ? I just taught we can just add layers like convolution , max pooling but not transpose?
Is it correct?

@Rathna21 I just extract the first three layers, Conv2D, BatchNormalization, Activation Relu, and get the weights from original model. In this way I formulate a keras model and convert to onnx, the output result is correct. Then there should be something wrong in the remaining layers conversion. We need a sub model to debug this.
It is not efficient I just extract the layers and set weights, because it is not easy to decompose the model from the whole model file.
You can also try yourself by looking at the examples in test_layers.py. there is assertTrue to compare results between keras and onnx. Since you have the source code, you can easily locate which layer is wrong by decomposing the model.

@jiafatom Thanks for the reply. Will try working on that and check.
Do you need any sub model? If yes which layers do you require?

It is great if you can try testing because that is more flexible. You can also give the submodel where the last layer is the Concatenate. You have 4 Concatenate, then you can generate 4 sub models. Then it is good to compare each with onnx.

@jiafatom Correct as you said the model I shared with you has output shape (2,256,512,4). That is what even I want. Thats fine. The problem in that is my output values .
But I have another issue. I am working with yolo as well. I need to integrate the yolo model in Windows ML. YOLO in darknet is converted into keras using yad2k script. So, in keras it changes the input and output shape as (batch_size, height, width, channels) . But in windows ML its different. When I see yolo model in onnx model zoo, the output shape is (batch_size, channels , height, width) . Its the same in CORE ML as well. So, further to get the bounding boxes this is the shape I require in Windows ML. So, like channels_first_input I am expecting a channels_first_output such that if I want , I can enable else disable like channels_first_input.
As you said , Can I load the model in keras , do model.predict(data) and do transpose of that result array and add it back to model and then convert the yolo model into onnx ? Is it possible ? I just thought we can just add layers like convolution , max pooling but not transpose?
Is it correct?

@Rathna21 I don't have a definite answer for this last question. it is about data manipulation and out of converter scope....

@jiafatom , What do you mean sub model? Could you explain little more briefly?

@Rathna21 by sub model I mean that you can just extract the first few layers into one model, not all the layers.

@jiafatom Yea ok I will do that upload  the sub models.
And regarding the channels_first_output, you said you don't have any reason to implement it. But as the shape in Keras and other platforms is different , ie in Keras it is NHWC and most other platforms it is NCHW. Just to make onnx compatible with a framework with NCHW for input channels_first_input was enabled , could output also be done the same way so there will be no extra data manipulation at the end.
Ex: I want to work with YOLO in Windows ML. The problem was Windows ML would accept only NCHW to bind input to the model, whereas Keras was NHWC, I changed the input using keras2onnx to NCHW. I would expect to change my output shape as well. Even in darknet , the output of the yolo is in NCHW.
So, I would like to work as such because in most of the frameworks it is NCHW expect Keras and tensorflow.
I would like to convert the darknet yolo model to convert to ONNX by using a intermediate framework which helps me support NCHW. But after a long research I see everyone using yad2k script to first convert into keras and then to any other framework. But only in keras it is changed to NHWC.
I tried removing the transpose layer in Keras. I face a lot of issues.
Is there a way you can help me in this? Of course most of them would be interested in NCHW output from this script as well.

I converted unet here, and the converted onnx model gives me the correct result.

@jiafatom , Hello sorry for the delay in submodels.
I have created two subgraphs with concatenation layer at the end. Is this you were expecting?
https://drive.google.com/open?id=1BWss7g2wKFbO7eiWyzG2Ma7HXA0274x9
https://drive.google.com/open?id=12_vfwyzp752v-8rmq4VzSywhfV6sBkoj
Could you have a look into it?

@Rathna21 Yes, this is what we want. Both submodels gives correct result after conversion. Can we have more (end with the 3rd and 4th Concat)

@jiafatom ,
Yes, please find the remaining 2 models.
https://drive.google.com/open?id=1xhAY-1L-TcjJOyWFLhXBXu9PbR_wSJ4m
https://drive.google.com/open?id=1h0o7Z_qlS-PUth7Sh2jv4gCpCyeVMD7y

@Rathna21 Both models are correct, meaning that the submodel ending with all Concat is correct. So the remain difference is two sets of Conv2D/BatchNormalization/Acitvation, plus a last Conv2D. Can you give me two submodels, each end with Activation op (that is activation_24 and activation_25 in original unet_model.h5)?

@jiafatom , Ok will send the models.
But, I have a question. Will have my weights changed , when I load the entire model and just extract some models from it?
Should I just load the weights instead?

@Rathna21 Not sure on this question. I randomly checked the weights for the submodels you send to me, looks same as original model. So please send the two models I mentioned, I can test it again.

@jiafatom ,
Please find the models you asked for!!
https://drive.google.com/open?id=1ikx1vfas2lKqmJxAhlFLbUdCPHqRI6KQ
https://drive.google.com/open?id=1WfY16pjmBP4RuNrmPgFb9s7WKVI3f7YD

@Rathna21 The results are correct. So the only difference is the last Conv2D. Can you do a test? Now you can extract any sub model, then you use this way to extract the whole model for me?

@jiafatom , You mean you want me to create a final sub model including last convolutional layer or test it by myself?
Dint get the exact thing you said?

@Rathna21 just checked in the fix, and now your model is converted correctly. Please check, thanks.

@jiafatom
It worked and values are perfect now.
Thank you so much for your assistance.


[BUG]

Please make sure to search for existing issues and check the FAQ before filing a new one.
Describe the bug
I get an error when attempting to execute step 2-gke-cluster.   When I run terrform init, I get the follow error.

Finding latest version of hashicorp/google-beta...
Installing hashicorp/google v4.31.0...
Installed hashicorp/google v4.31.0 (signed by HashiCorp)
Installing hashicorp/google-beta v4.31.0...
╷
│ Error: Failed to install provider
│
│ Error while installing hashicorp/google-beta v4.31.0: open
│ .terraform\providers\registry.terraform.io\hashicorp\google-beta\4.31.0\windows_amd64\terraform-provider-google-beta_v4.31.0_x5.exe: The system cannot find
│ the path specified.

To Reproduce
Steps to reproduce the behavior:
run terraform init against step 2-gke-cluster
Expected behavior
step 2-gke-cluster is supposed to create gke cluster.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

The directory structure was too long.  I deleted an unnecessary subdirectory to shorten the tiers , thus the path name length was reduced.   Windows limitation of 260 bytes.


Searching the SPDX Database for a License Name

Is it possible to get a license in Json or XML format form SPDX database by searching through the license names using a string (or a regular expression)? The result can also be a best effort result if the given search string is not exact.

Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.


Initialize all namespaces in all GKE clusters.

The original goal of this was to update the setup script to create all the namespaces discussed in our docs. While I was in there, I thought I'd go ahead and rename "core" -> "command_center" where it makes sense, again to match the docs. I forgot that renaming TF resources is a breaking change until after I tried to apply the renamed configs, and tore everything down...
Everything should be back up now, but we need to merge this before testing any other changes branched from master to avoid another renaming debacle.

Side note, I discovered the "proper" way to rename stuff in TF: https://www.terraform.io/docs/commands/state/mv.html


Obsolete Event QR-Code

CWA can no longer scan QR codes, so the Event QR-Code is now obsolete.
It has a prominent position in the header

so it should be removed from there.
On https://www.coronawarn.app/en/eventregistration/ there should at least be a note that it is no longer applicable, if the page itself is still retained. If the page is removed, then the Cypress tests would also need to be changed.

Internal Tracking ID: EXPOSUREAPP-15169

Hi Mike,
thank you for raising this issue! We will see how we best handle this, just an idea that popped up in my head while I was writing this: Adding a disclaimer to the page & deactivating the input fields and buttons, so that no new QR codes can be created. But as said, this is just one way how we could possibly handle this.
In general, the team agreed that we don't want to remove any pages.
The idea is to keep the content of the website available, maybe archive some (for example the FAQ entries by changing the structure, or removing some of the screenshot pages), but it was important to us that everyone can still see and access most of the features and information the website once offered.
Our internal work on this, however, is not yet finished, and we will take all of your feedback into consideration!

FYI PR https://github.com/corona-warn-app/cwa-website/pull/3492

@dsarkar

Do you plan to remove "Event QR-Code" from the header or do you want to close this issue now that #3492 has been merged?

@MikeMcC399 We will keep "Event QR-Code" in the header.

@dsarkar

We will keep "Event QR-Code" in the header.

Thanks. So I will close, since at least part of the suggestion has been implemented and there is no further action planned.


Is it possible to know the input values for a multi-layer risk analysis?

The one-layer analysis results form contains the list of data inputs used in the analysis. This list is not for the current multi-layer analysis result form.
We need the input values in the results form with a button "Save & Run". The missing values should be marked with a "warning" icon

Added ~56 and removed ~51 labels


feat(classification): allow parallelisation to improve performance

Changes to allow parallel processing of column info types prediction. This uses multiprocessing. Multithreading does not help, most likely because classification is compute intensive process.
(Tests) Changes to parameterize mocked snowflake query results
(Tests) Snowflake performance test to compare performance for different parameters (skipped from CI)

Here are the results of single run of this test - in brackets - [number of workers-number of columns per table-number of tables] - ordered by number of workers.
55.06s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[1-80-1]
30.97s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[2-80-1]
20.24s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[4-80-1]
20.48s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[6-80-1]
17.93s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[8-80-1]

28.16s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[1-40-1]
15.20s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[2-40-1]
10.14s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[4-40-1]
10.20s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[6-40-1]
9.10s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[8-40-1]

7.28s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[1-10-1]
3.69s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[2-10-1]
3.70s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[4-10-1]
3.70s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[6-10-1]
3.72s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[8-10-1]

5.37s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[1-5-1]
3.38s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[2-5-1]
3.38s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[4-5-1]
3.40s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[6-5-1]
3.43s call     tests/integration/snowflake/test_snowflake_classification.py::test_snowflake_classification_perf[8-5-1]

Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[x] Tests for the changes have been added/updated (if applicable)
[x] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@mayurinehate is there anything we can do to just make the classification faster?
I would've expected classification to be on the order of milliseconds, not seconds.

@mayurinehate is there anything we can do to just make the classification faster?
I would've expected classification to be on the order of milliseconds, not seconds.

@hsheth2 I agree with you. Making classification faster is the ideal solution and it would involve investigating and improving predict_infotypes in datahub-classify repo. @mardikark-gslab is going to take a point on that in a couple of days. Meanwhile, this PR allows the provision to parallelise classification, as a partial fix on this.


Use grid of active station location for distance calculations

This fixes https://github.com/wavelog/wavelog/issues/766

Added function to update distance information for all QSOs. Could you please re-check @AnreasK79?

Added function to update distance information for all QSOs. Could you please re-check @AndreasK79?

I think we have an issue here with all those functions in country files section as they update all QSOs instead of only the ones for the current user. Needs investigation and will be handled separately.

Needs investigation and will be handled separately.

Handled in https://github.com/wavelog/wavelog/issues/769.

Tested and works:
Idea: Can we add a spinner / lock for the button, since this is a long-running operation and the admin can't see if there's something happening in the BG?

I will refactor the htmx stuff separately. Merging the current state.

Spinner stuff to be handled in https://github.com/wavelog/wavelog/issues/771.


update roadmap page for 2023

Looking for suggestions on what to add in the "2023" achievements tab
Closes #2204

Some suggestions. Patch dates are when they were available in release binaries - not time of creation/merge.
March

CLI and GUI <IP_ADDRESS> "Flourine Fermi" released
Start of Cuprate - alternative Monero node implementation
Transaction confirmations 60s faster (initiative from Rucknium and pool cooperation)
P2Pool Hardfork

April

CLI and GUI <IP_ADDRESS> "Flourine Fermi" released
tx_extra limited

May

10-Block-Old Decoy Selection Bug Disclosure
ETH <-> XMR atomic swap on mainnet (beta)

October

CLI and GUI <IP_ADDRESS> "Flourine Fermi" released
Improved transaction rescanning
1s wallet startup speedup (not sure if we should be proudly announcing this patch :D)
RandomX v1.2.1 released (2 years since last release)

Thanks for the feedback @hinto-janai, but the roadmap is only for major changes to Monero (and only Monero). What you list are nice improvements, but are not major enough to be listed singularly (see the other entries in the roadmap for what i mean). This pr is the result of a short conversation in the workgroup chat (#monero-site) on what to list for this year, but can be reconsidered. We also decided time ago to not post minor releases in the roadmap.

Thanks for the feedback @hinto-janai, but the roadmap is only for major changes to Monero (and only Monero). What you list are nice improvements, but are not major enough to be listed singularly (see the other entries in the roadmap for what i mean). This pr is the result of a short conversation in the workgroup chat (#monero-site) on what to list for this year, but can be reconsidered. We also decided time ago to not post minor releases in the roadmap.

Last years monero roadmap had a future plans by years, now it is only "future".

Not really. We have been showing "future" for a very long time. That's on purpose, because we cannot plan when some roadmap items will be completed. We only no it will be done in the future.
The roadmap still needs to be updated tho. I'll take care of it.

Anything is better than having nothing on 2023 and 2024 so on. We need to show there is an active development team still perfecting the only "people's currency" in the world.
Deadlines generate hype and hype generates free advertisement.


nice, but how to disabled spring effects

spring effect is pretty good, however, sometime I don't need it, so how to disabled it?

Hello 😄,
If you want your gestures to be "instantaneous", you can bind them directly to your element's style properties!
const element = ref<HTMLElement>()

// Drag handler
const handler = ({ movement: [x, y] }) => {
  // Check element existence
  if (!element.value) return

  // Apply movement values
  element.value.style.transform = `translate3d(${x}, ${y}, 0`
}


Register hive.review domain for our AWS account

Given there were no objections to hive.review as a domain name and it leaves possibilities of calling the platform The Hive or Review Hive or something related, this seems like a good first step.

Due diligence on the name: https://miro.com/app/board/o9J_ksUxGvM=/?moveToWidget=3074457348873278955&cot=15

Noticing the Route 53 only has .reviews domain rather than .review, for $22/year. Both TLDs exists.

However, hive.reviews is taken (unknown by whom) and it's a potential clash.

.review goes for $111 (for the first year) on GoDaddy but it's managed by a company that can't do HTTPS so it looks all a bit shady.

To buy it somewhere else, will need credit card details which we can obtain from Vikki.

If you're setting up the DNS as part of this ticket, can we have the MX records set the same as for libero.pub so that we can use it as a Gmail alias please?
I'll create follow up tickets to create the email alias etc.
More info on Gmail MX records: https://support.google.com/a/answer/140034

Awaiting DNS propagation for mail to work then I'll create an admin account for DNSimple to manage the domain on<EMAIL_ADDRESS>


Heroku Guide

Would it be possible for a maintainer to create a guide on using makara on Heroku? I'm thinking something along the lines of this: https://devcenter.heroku.com/articles/distributing-reads-to-followers-with-octopus
I'm finding the setup process for this gem to be difficult to go through for a Heroku app.
Edit: How do I know I've set this up correctly? With Octopus, I can easily see which shard a query runs on, but I'm not sure how to do that in Makara. Thanks!

hmmm, we don't use heroku.
if you turn on SQL logging in Rails, it shows if it is using the Master or the Slave
[Master|Slave] User Load (1.3ms) SELECT * FROM users; for example.

Anyone is free to write a heroku guide. Please let me know if you are interesting in helping or how I could help.


Windows (of buildings)

What are we going to do with the windows in the splat?

Use curved Interface in model to avoid splats in far distance


Modify Design-Add-and-Search-Words-Data-Structure.py: Revert cur.end to cur.word

cur.end is not a property of class TrieNode.
The correct property is cur.word

File(s) Modified: 211-Design-Add-and-Search-Words-Data-Structure.py
Language(s) Used: python3...
Submission URL: _https://leetcode.com/submissions/detail/830732890/_

Thanks, @programmer-04!


”Ernei” is listed in the drop-down menu

Description:
"Ernei" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Ernei" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Ernei, MUREȘ".


docs: rename docs to kebab-case

Fixes #822

Nice!
I looked at the Sumo docs, and it seems like there's only one place we need to update; https://github.com/SumoLogic/sumologic-documentation/search?q=sumologic-otel-collector

Three https://github.com/SumoLogic/sumologic-documentation/pull/897/files


DrawerContentComponentProps - 4.x upgrade - missing methods on navigation props

Hi everybody,
I did not know where to post it so here it goes as an issue - not sure if this is one.
I was using react-navigation: 3.11.1 and wanted to update so now my package.json looks like following:
"react-navigation": "4.0.5",
"react-navigation-drawer": "2.2.1",
"react-navigation-stack": "1.7.3",
"react-navigation-tabs": "2.5.2",

My app is not really that large so it went pretty much swiftly, the only problem I am facing with following piece of code:
Drawer configuration to use custom Drawer Component:
createDrawerNavigator({
... my routes...
		},
		{
			contentComponent: (props) => (
				<Drawer drawerProps={props} />
			)
		}

In previous version, props of contentComponent was of type: DrawerItemsProps which provided navigation property with navigate method so following code inside my custom Drawer component was not complaining:
this.props.drawerProps.navigation.navigate("SOME_ROUTE")

But now props is of type: DrawerContentComponentProps and navigation prop there is of type:
navigation: NavigationProp<NavigationDrawerState>;
and NavigationProp only holds following method definition:
  export interface NavigationProp<S> {
    state: S;
    dispatch: NavigationDispatch;
  }

And because of that TSLint comlains:
Property 'navigate' does not exist on type 'NavigationProp<NavigationDrawerState>'.
Is this a bug? Because after launching the app, everything works correctly so it seems like Types definition bug?

Hi everybody,
I did not know where to post it so here it goes as an issue - not sure if this is one.
I was using react-navigation: 3.11.1 and wanted to update so now my package.json looks like following:
"react-navigation": "4.0.5",
"react-navigation-drawer": "2.2.1",
"react-navigation-stack": "1.7.3",
"react-navigation-tabs": "2.5.2",

My app is not really that large so it went pretty much swiftly, the only problem I am facing with following piece of code:
Drawer configuration to use custom Drawer Component:
createDrawerNavigator({
... my routes...
		},
		{
			contentComponent: (props) => (
				<Drawer drawerProps={props} />
			)
		}

In previous version, props of contentComponent was of type: DrawerItemsProps which provided navigation property with navigate method so following code inside my custom Drawer component was not complaining:
this.props.drawerProps.navigation.navigate("SOME_ROUTE")

But now props is of type: DrawerContentComponentProps and navigation prop there is of type:
navigation: NavigationProp<NavigationDrawerState>;
and NavigationProp only holds following method definition:
  export interface NavigationProp<S> {
    state: S;
    dispatch: NavigationDispatch;
  }

And because of that TSLint comlains:
Property 'navigate' does not exist on type 'NavigationProp<NavigationDrawerState>'.
Is this a bug? Because after launching the app, everything works correctly so it seems like Types definition bug?

Same problem occurred

I got same problem, hope someone can provide a way to navigate from contentComponent


Detect and preserve npm package-lock.json file indentation

I used detect-indent package as it was used for npm install fix

Can we avoid extra dependency and write a small function to do it? Our use case is very simple to use extra dependency for that.

Sure. I fixed it.
But I discovered interesting fact. Really npm v7+ doesn't preserve indentation style after npm install (and we use it for updating). More information about it here. It uses indentation of package.json file.
So this PR was useful only for npm version less v7.
Our team use npm v6 now so we'll find it useful.

Thanks. Released in 1.0.6.


Set service name correctly when using Azure Pipelines urls

The previous service naming logic used the instance's subdomain. When an
Azure Pipelines url was provided, "dev" was always used. Now, the instance
name will be obtained from the url's path if an Azure Pipelines url is
provided.
Resolves #1841

It looks like the CI job failed on ARM due to a bug within DotNet c3ore, rather than a bug within the PR itself.
See https://github.com/dotnet/coreclr/issues/18486 for details.

@JacobHenner thanks for fixing this 👍

This is ready for review. The CI job keeps failing for reasons unrelated to my change (different each time, oddly enough).


tweaks to readBUGSmodel

Several suggestions for readBUGSmodel:

Rename "returnModelComponentsOnly" to "returnComponents"
Change roxygen statement about that argument to not suggest it is not useful outside of MCMCsuite.  I think it is commonly useful to read just a code file, because a common way to use R2WinBUGS and rjags is to write out code files from R and then read them in via R2WinBUGS.  We can support that idiom by using readBUGSmodel(..., returnComponents = TRUE)$model
In the list returned when returnModelComponentsOnly=TRUE, rename "model" to "code".  We have made this change in nomenclature in other spots previously.
Currently readBUGSmodel("fileIjustWrote.bug", returnModelComponentsOnly = TRUE) does not work because the dir argument defaults to NULL and then file.path(dir, modelFile) returns character(0) instead of modelFile.  I think we need either to make dir default to "" or check if it's NULL before that call to file.path.

Obviously these changes would require tracking down any usages in our code base, examples etc and updating them, which is why I'm not just running ahead and making the changes now.

Can you remind me where the examples (i.e., MCMC comparisons) on the webpage are stored? I don't see this in nimble-dev/nimble-demos nor elsewhere.  I need to modify code there for the ice example (perhaps others) in light of this.

I believe the code is in the demos repo and the generates html is  manually placed on my web site.  The former you can modify.  We should find a better place for the latter but for now I guess that requires a manual step by me.

On Jul 16, 2016, at 11:50 AM, Christopher Paciorek<EMAIL_ADDRESS>wrote:
Can you remind me where the examples (i.e., MCMC comparisons) on the webpage are stored? I don't see this in nimble-dev/nimble-demos nor elsewhere. I need to modify code there for the ice example (perhaps others) in light of this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/nimble-dev/nimble/issues/177#issuecomment-233145160, or mute the thread https://github.com/notifications/unsubscribe-auth/AHpCMfoRGjaEcL78XVtGZo_Np-6hUhmYks5qWSgCgaJpZM4I1jhX.

I didn't see the ice example (which uses readBUGSmodel) in
nimble-dev/nimble-demos so not clear to me that all of the r-nimble.org
examples are there in that repo.
On Sat, Jul 16, 2016 at 3:01 PM, perrydv<EMAIL_ADDRESS>wrote:

I believe the code is in the demos repo and the generates html is manually
placed on my web site. The former you can modify. We should find a better
place for the latter but for now I guess that requires a manual step by me.

On Jul 16, 2016, at 11:50 AM, Christopher Paciorek <
<EMAIL_ADDRESS>wrote:
Can you remind me where the examples (i.e., MCMC comparisons) on the
webpage are stored? I don't see this in nimble-dev/nimble-demos nor
elsewhere. I need to modify code there for the ice example (perhaps others)
in light of this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <
https://github.com/nimble-dev/nimble/issues/177#issuecomment-233145160>,
or mute the thread <
https://github.com/notifications/unsubscribe-auth/AHpCMfoRGjaEcL78XVtGZo_Np-6hUhmYks5qWSgCgaJpZM4I1jhX
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nimble-dev/nimble/issues/177#issuecomment-233153246,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACYr3hafjGDKPM4qXnqCvj5CIko8eQkOks5qWVSkgaJpZM4I1jhX
.

Oh, you’re probably right.  Ok I’ll try to fix up the situation but probably not before the release.

On Jul 16, 2016, at 3:16 PM, Christopher Paciorek<EMAIL_ADDRESS>wrote:
I didn't see the ice example (which uses readBUGSmodel) in
nimble-dev/nimble-demos so not clear to me that all of the r-nimble.org
examples are there in that repo.
On Sat, Jul 16, 2016 at 3:01 PM, perrydv<EMAIL_ADDRESS>wrote:

I believe the code is in the demos repo and the generates html is manually
placed on my web site. The former you can modify. We should find a better
place for the latter but for now I guess that requires a manual step by me.

On Jul 16, 2016, at 11:50 AM, Christopher Paciorek <
<EMAIL_ADDRESS>wrote:
Can you remind me where the examples (i.e., MCMC comparisons) on the
webpage are stored? I don't see this in nimble-dev/nimble-demos nor
elsewhere. I need to modify code there for the ice example (perhaps others)
in light of this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <
https://github.com/nimble-dev/nimble/issues/177#issuecomment-233145160>,
or mute the thread <
https://github.com/notifications/unsubscribe-auth/AHpCMfoRGjaEcL78XVtGZo_Np-6hUhmYks5qWSgCgaJpZM4I1jhX
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nimble-dev/nimble/issues/177#issuecomment-233153246,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACYr3hafjGDKPM4qXnqCvj5CIko8eQkOks5qWVSkgaJpZM4I1jhX
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/nimble-dev/nimble/issues/177#issuecomment-233153871, or mute the thread https://github.com/notifications/unsubscribe-auth/AHpCMdM7GeBwAbDmxIsWZ61DIezRJSlaks5qWVg9gaJpZM4I1jhX.

I've fixed this up per Perry's suggestions and looked for uses of returnModelComponentsOnly in our various examples/demos/outreach.  Things should be fine except for the examples in MCMC comparisons that are not in the nimble-examples repo.
Leaving this open so we remember to fix up MCMC comparisons (specifically the ice example and perhaps others).

This was addressed long ago but the issue left open as a reminder for something else.  Closing it now.


Fix Bool pattern matching to be exhaustive

Fixes https://github.com/com-lihaoyi/upickle/issues/456

Gonna merge this to get it in for the 3.0.0 release


Mago/Mago-Mi: On some windows systems debugging x86_64 does not work

I have this sample application:
import std.stdio;

void main(string[] args)

{
    writeln(args);
}

Which I compile with different architectures:
dub --arch x86
dub --arch x86_mscoff
dub --arch x86_64
On my pc A I am able to load the executable in Mago-Mi for all architecture
C:\D\tools\mago-mi.exe --interpreter=mi2
-file-exec-and-symbols C:/D/projects/testapp/testapp.exe

On pc B only architecture x86 and x86_mscoff is working. While execute the command "-file-exec-and-symbols C:/D/projects/testapp/testapp.exe" for the x86_64 architecture there is an error message
Launch failed. Result=-2147024894
Located here
https://github.com/rainers/mago/blob/master/MagoMI/mago-mi/source/MIEngine.cpp#L535
https://github.com/rainers/mago/blob/master/MagoMI/mago-mi/source/debugger.cpp#L876
I assume the issue is not DMD version related as I tried different version on my pc A and everyone is working. PC A has a windows build 1803 while pc B has 1709. Unfortunately I cannot install Visual Studio on PC B to test whether debugging of x86_64 fails there too.

I suspect you have Visual D installed on one PC, but not the other?
I guess you need MagoRemote.exe on PC B and linked to in the registry at
HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\MagoDebugger
value Remote_x64, e.g. "C:\Program Files (x86)\VisualD\Mago\MagoRemote.exe"

At the moment I cannot test it but I am pretty sure that is the reason. On pc A where debugging x86_64 is working I removed the regedit key and I get the same result as on pc B.
I would like to add an output to Mago-Mi which gives a hint if a X86_64 is tried to debug and MagoRemote isn't setup correctly. There are 2 possibilities:
Option 1) Mago-Mi checks whether an executable is of x86_64 architecture and a regedit key exists pointing to a file "MagoRemote.exe" which should exists on file system. If this pre-requisites are not meet, an error message is shown.
Option 2) Mago could provide a method "GetLastErrorText" which Mago-Mi could call after launch failed. In case of the missing regedit/Mago-Remote.exe this method could provide an error text "Mago-Remote.exe isn't setup correctly".
Just a small hint within Mago-Mi would be sufficient to point into the right direction

Maybe Mago-Mi could also be enhanced.  I would like to call mago-mi like:
mago-mi install path/to/MagoRemote.exe
This command would create the regedit key
mago-mi uninstall
This command would uninstall the regedit key.

If launching the debuggee fails, can't you just provide an appropriate message with the error status?
Usually mago is run with the users credentials, so it cannot modify this registry key.
Providing the path to MagoRemote.exe via registry key is not set in stone. It is useful for the debug engine that plugs into VS, because it is run from different locations. mago-mi.exe could just try to run it from its own directory (see StartAgent in RemoteDebuggerProxy.cpp).

I had the chance to test it on PC B. I installed VisualD on top of Visual Studio Build Tools 2017 - 15.5.7
to have everything setup correctly.
While the executable is now loaded for all 3 architectures, loading the symbols only works for X86 (OMF).
For x86_mscoff and x86_64 no symbols are loaded:
dub build --arch=x86_64
=library-loaded,id="debug.exe",target-name="debug.exe",host-name="debug.exe",symbols-loaded="0",thread-group-id="i1"
=library-loaded,id="ntdll.dll",target-name="ntdll.dll",host-name="ntdll.dll",symbols-loaded="0",thread-group-id="i1"
=library-loaded,id="kernel32.dll",target-name="kernel32.dll",host-name="kernel32.dll",symbols-loaded="0",thread-group-id="i1"
...
dub build --arch=x86_mscoff
=library-loaded,id="debug.exe",target-name="debug.exe",host-name="debug.exe",symbols-loaded="0",thread-group-id="i1"
=library-loaded,id="ntdll.dll",target-name="ntdll.dll",host-name="ntdll.dll",symbols-loaded="0",thread-group-id="i1"
=library-loaded,id="kernel32.dll",target-name="kernel32.dll",host-name="kernel32.dll",symbols-loaded="0",thread-group-id="i1"
...
dub build --arch=x86
=library-loaded,id="debug.exe",target-name="debug.exe",host-name="debug.exe",symbols-loaded="1",thread-group-id="i1"
=library-loaded,id="ntdll.dll",target-name="ntdll.dll",host-name="ntdll.dll",symbols-loaded="0",thread-group-id="i1"
=library-loaded,id="kernel32.dll",target-name="kernel32.dll",host-name="kernel32.dll",symbols-loaded="0",thread-group-id="i1"
...
On pc B Visual Studio Build Tools 2017 - 15.5.7 is installed with following configuration:
  Visual C++ build tools
    Visual C+ Build Tools core features
    VC++ 2017 v141 toolset (x86,x64)
    Visual C++ 2017 Redistributable Update
  Windows 10 SDK
  Visual C++ tools for CMake

I suspect PDBDebugStore::InitDebugInfo fails to create a symbol provider via COM. It's usually implemented in a DLL like msdia140.dll. This is probably missing or not registered with the build tools.

I found the file here: "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\DIA SDK\bin\amd64\msdia140.dll" and here (X86 ?) "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\DIA SDK\bin\msdia140.dll".
I try to find out whether it is registered. By chance do you know how to check this?

I think it has to be referenced form here:
HKEY_CLASSES_ROOT\CLSID{e6756135-1e65-4d17-8576-610761398c3c}\InprocServer32

Do you think it is possible to enhance the Mago setup routine:

Include Mago-Mi
Call regSvr32 for x86 / x86_64 dll in case Build Tools is found
(OPTIONAL) add path containing mago-mi exe to PATH environment variable

The reason for the path environment variable is to enable IDEs to automatically find the location of mago-mi. But that would be some sugar on top.
As far as I know Mago-Mi is not only used in IntelliJ but also in Visual Studio Code. Providing a simple install routine would be great from an user experience perspective.

There is no "Mago setup" so far. I doubt it makes to add that to the Visual D setup, as the user has probably chosen an IDE other than Visual Studio.
I think this should rather be part of the respective installer for the IntelliJ/VS Code plugin.

is Mago Remote and the registry key actually required?
I tried the regSvr32 command with the msdia140.dll, but an error pops up saying it was loaded but the call to "DllRegisterServer" failed with error code 0x80070005
I want to automate this and can't expect administrator access and would prefer not to write to registry, is there something that can be done to avoid this?

is Mago Remote and the registry key actually required?

magoremote.exe is used to debug x64-processes with the mago debug engine. This is necessary in VS as VS is a 32-bit process.
I guess you are talking about mago-mi, though. Not sure if mago-remote is necessary if mago-mi itself is built as an 64-bit-executable.
The registry key is the way the executable is found, see https://github.com/rainers/mago/blob/master/DebugEngine/MagoNatDE/RemoteDebuggerProxy.cpp#L46. It seems simple to also search a fixed name (magoremote.exe) in the same directory as the invoking exe/dll by extracting the path from GetModuleFileName() or similar. PR welcome ;-)