bm_diff is failing to comment on PR's

Traceback (most recent call last):
  File "tools/profiling/microbenchmarks/bm_diff.py", line 255, in <module>
    eintr_be_gone(finalize)
  File "tools/profiling/microbenchmarks/bm_diff.py", line 200, in eintr_be_gone
    return fn()
  File "tools/profiling/microbenchmarks/bm_diff.py", line 251, in finalize
    comment_on_pr.comment_on_pr('```\n%s\n```' % text)
  File "tools/profiling/microbenchmarks/../../run_tests/python_utils/comment_on_pr.py", line 49, in comment_on_pr
    print urllib2.urlopen(req).read()
  File "/usr/lib/python2.7/urllib2.py", line 154, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 435, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 548, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 473, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 556, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 403: Forbidden

I think this is related to exceeding GH's API quota, so I'm switching the commenting to a different GH account and will see how if this resolves this issue.

According to https://developer.github.com/guides/best-practices-for-integrators/#dealing-with-abuse-rate-limits, specific actions, e.g. commenting on PRs, are subject to stricter rate limits. Maybe having an account dedicated to commenting might resolve this issue.

This issue hasn't been seen in a while.

just seen again in both the bm_diff and trickle_diff jobs:
19:11:57
19:11:57 [microbenchmarks] Performance differences noted:
19:11:57 Benchmark                                                                            cpu_time    nows_per_iteration    real_time
19:11:57 -----------------------------------------------------------------------------------  ----------  --------------------  -----------
19:11:57 BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/1/1/1  +4%                               +4%
19:11:57 BM_UnaryPingPong<InProcessCHTTP2, NoOpMutator, NoOpMutator>/0/16M                                -4%
19:11:57 Traceback (most recent call last):
19:11:57   File "tools/profiling/microbenchmarks/bm_diff/bm_main.py", line 145, in <module>
19:11:57     main(args)
19:11:57   File "tools/profiling/microbenchmarks/bm_diff/bm_main.py", line 140, in main
19:11:57     comment_on_pr.comment_on_pr('```\n%s\n```' % text)
19:11:57   File "tools/profiling/microbenchmarks/bm_diff/../../../run_tests/python_utils/comment_on_pr.py", line 34, in comment_on_pr
19:11:57     print urllib2.urlopen(req).read()
19:11:57   File "/usr/lib/python2.7/urllib2.py", line 154, in urlopen
19:11:57     return opener.open(url, data, timeout)
19:11:57   File "/usr/lib/python2.7/urllib2.py", line 435, in open
19:11:57     response = meth(req, response)
19:11:57   File "/usr/lib/python2.7/urllib2.py", line 548, in http_response
19:11:57     'http', request, response, code, msg, hdrs)
19:11:57   File "/usr/lib/python2.7/urllib2.py", line 473, in error
19:11:57     return self._call_chain(*args)
19:11:57   File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
19:11:57     result = func(*args)
19:11:57   File "/usr/lib/python2.7/urllib2.py", line 556, in http_error_default
19:11:57     raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
19:11:57 urllib2.HTTPError: HTTP Error 403: Forbidden

in bm_diff and
19:48:28 2017-09-15 02:47:19
19:48:28 Benchmark                                         Time           CPU Iterations
19:48:28 -------------------------------------------------------------------------------
19:48:28 BM_PumpUnbalancedUnary_Trickle/64/1/256k    2233467 ns      98562 ns       7092   644.026kB/s writes/iter:3.26325 cli_transport_stalls/iter:0 cli_stream_stalls/iter:0 svr_transport_stalls/iter:0 svr_stream_stalls/iter:0
19:48:28
19:48:28 2017-09-15 02:48:28,236 PASSED: bm_fullstack_trickle BM_PumpUnbalancedUnary_Trickle/64/1/256k opt old 3/4 [time=68.3sec; retries=0:0]
19:48:28 [trickle] No significant performance differences
19:48:28 Traceback (most recent call last):
19:48:28   File "tools/profiling/microbenchmarks/bm_diff/bm_main.py", line 145, in <module>
19:48:28     main(args)
19:48:28   File "tools/profiling/microbenchmarks/bm_diff/bm_main.py", line 140, in main
19:48:28     comment_on_pr.comment_on_pr('```\n%s\n```' % text)
19:48:28   File "tools/profiling/microbenchmarks/bm_diff/../../../run_tests/python_utils/comment_on_pr.py", line 34, in comment_on_pr
19:48:28     print urllib2.urlopen(req).read()
19:48:28   File "/usr/lib/python2.7/urllib2.py", line 154, in urlopen
19:48:28     return opener.open(url, data, timeout)
19:48:28   File "/usr/lib/python2.7/urllib2.py", line 435, in open
19:48:28     response = meth(req, response)
19:48:28   File "/usr/lib/python2.7/urllib2.py", line 548, in http_response
19:48:28     'http', request, response, code, msg, hdrs)
19:48:28   File "/usr/lib/python2.7/urllib2.py", line 473, in error
19:48:28     return self._call_chain(*args)
19:48:28   File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
19:48:28     result = func(*args)
19:48:28   File "/usr/lib/python2.7/urllib2.py", line 556, in http_error_default
19:48:28     raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
19:48:28 urllib2.HTTPError: HTTP Error 403: Forbidden
19:48:28 Build step 'Execute shell' marked build as failure

in trickle_diff
in https://grpc-testing.appspot.com/job/gRPC_performance_pull_requests/14717/console and https://grpc-testing.appspot.com/job/gRPC_performance_pull_requests_trickle/2100/console

I see this job was failing for a few hours last night, but it seems to be passing now. It probably was a GitHub API quota issue, which I haven't seen happen in a while.

Haven't seen this in a while. It was probably a transient error


Add -pch-output-directory driver flag and ClangImporter option

This will control the output path of a precompiled header (PCH) file
generated from the bridging header.
rdar://problem/31198711

@swift-ci Please smoke test

@swift-ci Please smoke test

Mishal says the branch is in a weird state and this already passed tests on master branch, so I'll merge.


Etcd attempts

allowing that the attempts of get_client_path are configurable in the postgresql.yml.

So…this is a much deeper issue than it appears at the surface.  There needs to be an extensive amount of warning around the extension of timeouts and re-attempts. Governor relies on the expectation that ETCD has all the information about the environment.  The extension of timeouts and connection reattempts reduces the trust that Governor puts on ETCD, which introduces more potential for split brain clusters.  This is "okay" for people who can trade off consistency for availability.  Scenario:
etcd:
  timeout: 60
  attempts: 5

The above scenario would mean that a Governor acting as a leader, if losing connection to ETCD, would hold the state of primary for 5 minutes before going read-only.  In the mean time, during that 5 minutes, other members of the cluster would take over the primary role.  This behavior introduces manual cleanup because of split brain, and may be a serious issue for people who require higher consistency.

Maybe it helps if I explain what problems we're encouter in some of our environments. We had some problems with etcd not responding on a request. We were not able to debug this but installed some monitor scripts to see the availability of etcd. The check runs every 5 seconds to check for an etcd response. After serving one repsonse with return code 500 it continued to respond with 200. But one failed request to etcd leads to a postgresql shutdown which terminates all existing connections. In the next loop it recovers and the old master promotes himself to the master again.
This leads to an unexpected downtime of postgres because one request to etcd failed. A second check attempt helps to solve this problem.
Your example scenario can lead to a split brain, thats right.
Maybe we could ensure that the absolute retry time for etcd is lower than the etcd TTL. But we have to consider the loop_wait too.
if config["etcd"]["timeout"] * (config["etcd"]["attempts]" - 1) >= (config["etcd"]["ttl"] - config["loop_wait"])
  logger.warning("Failed to start governor: absolute retry time for etcd requests is higher than the lock TTL")
  sys.exit(1)

(code snippet not tested, just for an example)

After thinking about this, the compare to the TTL doesn't fix the split-brain issue either.
I'll need to have a look when read requests are sent and when the current master is updated and the TTL gets refreshed.
Maybe I can find a solution this way.

I fixed the problem with a more robust etcd setup.
I will close this PR. Thank you for your time!


Locking mechanisms

Especially when integrating TensorFlow into an exiting multi-threaded application, it's not always easy to use queues for synchronization. Currently, we must use Python locks to lock the sess.run(...) calls from different threads. Exposing a TensorFlow lock interface could allow to synchronize access only to needed values of the session:
x = tf.placeholder(tf.float32, [None, 784])
y = tf.placeholder(tf.float32, [None, 10])
W = tf.Variable(tf.zeros([784, 10]))
b = tf.Variable(tf.zeros([10]))

lock = tf.Lock()
with lock:
  pred = tf.nn.softmax(tf.matmul(x, W) + b)
loss = -tf.reduce_mean(tf.reduce_sum(y * tf.log(pred), 1))
with lock:
  train_step = tf.train.GradientDescentOptimizer(0.5).minimize(loss)

def inference_thread():
  while True:
    # Generate data...
    sess.run(pred, data)

def training_thread():
  while True:
    # Generate data...
    sess.run(train_step, data)

Or simpler:
with tf.Lock():
  W = tf.Variable(tf.zeros([784, 10]))
# ...

Why do you need to use locking? Session is designed to support multiple
.run calls in parallel. For instance, Supervisor and queue_runners launch
enqueue ops in parallel with main training loop without locking.
There are some special cases -- ops like tf.assign_add have "read
variable"/"update variable" parts. If you don't want another thread to
modify the value between these two steps, there's
tf.assign_add(...,use_locking=True) option
On Fri, Dec 16, 2016 at 5:45 AM, Danijar Hafner<EMAIL_ADDRESS>wrote:

Especially when integrating TensorFlow into an exiting multi-threaded
application, it's not always easy to use queues for synchronization.
Currently, we must use Python locks to lock the sess.run(...) calls.
Exposing a TensorFlow lock interface could allow to synchronize access only
to needed values of the session:
x = tf.placeholder(tf.float32, [None, 784])
y = tf.placeholder(tf.float32, [None, 10])W = tf.Variable(tf.zeros([784, 10]))
b = tf.Variable(tf.zeros([10]))
lock = tf.Lock()with lock:
pred = tf.nn.softmax(tf.matmul(x, W) + b)
loss = -tf.reduce_mean(tf.reduce_sum(y * tf.log(pred), 1))with lock:
train_step = tf.train.GradientDescentOptimizer(0.5).minimize(loss)
def inference_thread():
while True:
# Generate data...
sess.run(pred, data)
def training_thread():
while True:
# Generate data...
sess.run(train_step, data)
Or even simpler:
with tf.Lock():
W = tf.Variable(tf.zeros([784, 10]))# ...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/6360, or mute the thread
https://github.com/notifications/unsubscribe-auth/AABaHHDatqz7ifXWt50kVKAhv3hGhl21ks5rIpXrgaJpZM4LPMvQ
.

So access to variables is already protected by a lock that allows multiple reads or one write? My understanding was that assigning to a variable while using it in a computation from another sess.run() can cause interference.

The lock is activated by use_locking option. Here's a simple experiment to confirm -- https://gist.github.com/yaroslavvb/3a53132dcddc8ff47e4e919579b98c6a
If you turn on use_locking, then each read takes at least as long as each write. If you turn it off, the reads are near instant.

Okay, thanks for putting together an example. Seems like we might not need locking primitives then. One more question, without use_locking are the reading threads guaranteed to read consistent versions of the variable? By consistent, I mean that they are either not yet updated or already fully updated.

No -- in the example I gave the writes >1 seconds each, while reads take 0.0005 seconds, so they must be looking at partially update states.

You're right, here is a slightly more compact example to reproduce the issue. The writer thread increases the elements of the matrix exponentially using locking. The reader thread checks for all elements of the matrix being identical at any point, which fails. Isn't this a bug in TensorFlow's implementation of use_locking?
import threading
import time
import numpy as np
import tensorflow as tf

variable = tf.Variable(np.ones((100, 100)), trainable=False)
write_op = variable.assign_add(variable, use_locking=True)
sess = tf.Session()
running = True

def writing():
  global running
  for _ in range(1000):
    sess.run(write_op)
    time.sleep(0.001)
  running = False

def reading():
  while running:
    value = sess.run(variable)
    assert (value == value.flat[0]).all()  # This fails

if __name__ == '__main__':
  sess.run(tf.global_variables_initializer())
  threading.Thread(target=writing).start()
  threading.Thread(target=reading).start()

Hm, looks like use_locking sets a write-lock rather than read lock? cc @mrry for his expertise

Exactly, but it seems quite counter-intuitive to me. I'd expect a write lock to block both reads and writes. There are some people on Github who tried to implement A3C (Mnih et al.; 2016) and ran into this issue. They ended up using processes and aggregating updates on the Python side with Numpy. Would be interesting to hear an opinoin from @mrry.

At present, all TensorFlow variables (creating using the tf.Variable API) are associated with an individual mutex, which is acquired when that variable is the lvalue input to one of the assignment ops (like "Assign") or one of the training ops that updates a set of related variables (like "ApplyGradientDesign"), and use_locking = true is set on that op.
In principle these locks could protect reads as well (e.g. if there were a "Snapshot" op that took a copy of the variable under the lock), but this doesn't happen in practice because TensorFlow automatically converts variable "reference tensors" to Tensor values, and regular Tensor values don't have a mutex, so the ops that operate on them aren't able to acquire the lock to protect reading.
Since this is a sad state of affairs, we've been revising the memory model for variables, so that reads are explicit (and safely protected by a mutex), and values don't alias mutable buffers. This is still a work in progress, but @michaelisard or @alextp could comment more.

@mrry Thanks for the update. What do you think about explicit locking like the example in the first post?

@alextp has been leading the design and implementation of the new variables and can give you details about status and immediate future plans.
We have in the past discussed high-level locks like the one you describe, but we have struggled to come up with the use cases to help design what is required. We in general like to keep as much of TensorFlow as possible functional, because it simplifies automatic optimizations, and placement onto a variety of devices. The most common original use case for variables was asynchronous updates, which by their nature are expected to be somewhat racy. We have talked about putting support in the graph for "short" transactional updates of multiple variables, but for your initial example where you hold a lock around an entire training step it might make more sense to do higher-level serialization from the session API, as you are doing currently.
We would definitely be happy to hear more details about what you are trying to achieve, to help us plan!

hi @mrry , you said

...because TensorFlow automatically converts variable "reference tensors" to Tensor values...,
I don't quite understand what that means. Could you give an example to show such "automatical conversion"? And could you please explain what is "reference tensors"? Thanks!

Here's a simple example that appears quite frequently: the tf.identity() removes the ref-ness from its input, but doesn't make a copy, so the result, which has tf.float32, is actually a mutable buffer(!):
>>> import tensorflow as tf
>>> v = tf.Variable(37.0)
>>> v.dtype
tf.float32_ref
>>> id_v = tf.identity(v)
>>> id_v.dtype
tf.float32

thanks for your kind response @mrry. But could you please explain more about in which cases we might need to remove the ref-ness from input? I have found no docs introducing the differences of reference and non-reference dtype, thus I have no idea when I should use which one of them.
Thanks for your time!

@AIROBOTAI you shouldn't have to worry about keeping / removing refness from inputs. While now it's not currently true that it's safe to treat all tensors as constant, I'm working on changing the system to make this true, so the notion of ref won't be necessary.
That said, removing ref from inputs is not something you do; the type system allows ref tensors to be treated as non-ref tensors, but not the other way around (so you cannot assign to a constant, but can use the value of a variable in any operation you'd like).

Wow, cool! Thanks @alextp! Also, sorry for deviating from the topic of this issue :-P

@michaelisard so turns out @danijar were both working on an A3C, and have similar use-case -- use-case is for Snapshot type op that lets you obtain a variable between updates. More specifically, our A3C implementation in https://github.com/openai/universe-starter-agent has agents trying to make prediction using parameters stored on a parameter server, which may be in the process of being updated by other agents, hence inconsistent. We'd like to be able to get a consistent version of parameters. A complication is that network parameters are typically split over several variables.
So maybe something like this, when updating params stored on parameter server.
ops.apply_gradients(grads_and_vars, snapshot_vars)
Then on workers, when transferring central parameters to a local copy.
tf.copy_snapshots(snapshot_vars, local_vars)
The last op would be guaranteed to place a consistent version of global parameter variables into local parameter variables.

Yes this is a use case that we thought about when @alextp was designing the new variable implementation, and will be relatively straightforward. I don't know the timeframe but the idea is that a lot of this functionality will be filled in after TF 1.0 is out.

@alextp Okay cool. Will this change the last paragraph of the tf.Variable.value() docs? I think that's the unexpected behavior we ran into for A3C. It's definitely not safe behavior when running sessions from multiple threads.

tf.Variable.value()
Returns the last snapshot of this variable.
You usually do not need to call this method as all ops that need the value of the variable call it automatically through a convert_to_tensor() call.
Returns a Tensor which holds the value of the variable. You can not assign a new value to this tensor as it is not a reference to the variable. See ref() if you want to get a reference to the variable.
To avoid copies, if the consumer of the returned value is on the same device as the variable, this actually returns the live value of the variable, not a copy. Updates to the variable are seen by the consumer. If the consumer is on a different device it will get a copy of the variable.

Instead there will be a sister class to variable (now named
ResourceVariable, already in the codebase but hidden as it's still
incompatible with a lot of things) with different behavior. It will have a
Read op where a Read is guaranteed to see the result of all writes on which
it depends and to not see the results of writes which depend on it. It'll
also be possible to add operations with stronger contracts, such as the
group snapshot read Yaroslav mentioned (which I might add from the start).
On Tue, Jan 10, 2017 at 3:57 PM, Danijar Hafner<EMAIL_ADDRESS>wrote:

@alextp https://github.com/alextp Okay cool. Will this change the last
paragraph of the tf.Variable.value() docs? I think that's the unexpected
behavior we ran into for A3C. It's definitely not safe behavior when
running sessions from multiple threads.
tf.Variable.value()
Returns the last snapshot of this variable.
You usually do not need to call this method as all ops that need the value
of the variable call it automatically through a convert_to_tensor() call.
Returns a Tensor which holds the value of the variable. You can not assign
a new value to this tensor as it is not a reference to the variable. See
ref() if you want to get a reference to the variable.
To avoid copies, if the consumer of the returned value is on the same
device as the variable, this actually returns the live value of the
variable, not a copy. Updates to the variable are seen by the consumer. If
the consumer is on a different device it will get a copy of the variable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/6360#issuecomment-271736413,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAATxZrtuYPX1_IsBHJq3N_nxDS3iR-3ks5rRBsHgaJpZM4LPMvQ
.

--

Alex

BTW, there's another potential use-case for locking that came up here
You have two aligned queues of images and labels. Then you have something like f(images.dequeue(), labels.dequeue(). If you run this function in two parallel run calls, the queues can get out of sync. A user-facing interface might be to have f be a Function node, and have a property use_locking which adds a lock on all of its inputs on start of execution, and releases a lock at the end.

For queues I recommend using a single queue for both images and labels. This is why all queues support tuples of Tensors.
What's the advantage of separate queues, if the enqueues and dequeues need to match, and so need any internal shuffling and whatnot?

Not sure what the advantage is. I guess this is similar to the use-case that was mentioned earlier, you may have function f(a,b) which modifies variables a,b and you don't want that function to see a,b variable in a partially updated state another copy of f is being executed concurrently

I have a different use case and/or question -- which may need another thread. I am trying to implement a custom op to run a L-BFGS solver. On the C++, I have a co-routine using threads: one runs the solver detached, the other manages the TF control. It operates inside a TF while_loop with the compute call serving as a defacto generator function to fetch data when needed. I can run this on a single node, but it seems to lock up the graph somewhere when I run it in distributed. Can I prevent another thread from trying to acquire a lock and/or can I manage the locks to update the variable when needed and release the lock otherwise?

@benring, I need more information to understand what is going on. Can your
custom op be trying to access state on another machine or something?
On Mon, Mar 6, 2017 at 12:26 AM, benring<EMAIL_ADDRESS>wrote:

I have a different use case and/or question -- which may need another
thread. I am trying to implement a custom op to run a L-BFGS solver. On the
C++, I have a co-routine using threads: one runs the solver detached, the
other manages the TF control. It operates inside a TF while_loop with the
compute call serving as a defacto generator function to fetch data when
needed. I can run this on a single node, but it seems to lock up the graph
somewhere when I run it in distributed. Can I prevent another thread from
trying to acquire a lock and/or can I manage the locks to update the
variable when needed and release the lock otherwise?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/6360#issuecomment-284331206,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAATxdynpYZsNle_AvPvFSTtSy8_xjA9ks5ri8NBgaJpZM4LPMvQ
.

--

Alex

@benring the "lock up the graph" behavior would be a TensorFlow bug unless you introduced a circular dependency in the graph (like in https://github.com/tensorflow/tensorflow/issues/6961), or your graph is waiting for input.
If you can rule out the latter with session timeout, it might be worth filing a bug with reproducible example
  config = tf.ConfigProto()
  config.operation_timeout_in_ms=50000   # terminate on long hangs
  sess = tf.InteractiveSession("", config=config)

I rechecked and this is not a distributed issue -- my single node version I tried yesterday used a different model. I tried the config setting and the session never times out. Does this imply a circular dependency in the graph? I can execute the custom op on a toy example, but am having a hard time reproducing the error to demonstrate it. Our model is pretty complex -- it's an extension of GPFlow -- so tracing the graph is no simple task. Is there  a way I can crank up the logging? Also: I am using TF r0.12

Can you get a backtrace to see where it's stuck? You can get stuck for reasons unrelated to tensorflow, for instance, I've had a model stuck because a GPU op was calling Nvidia drivers, which was trying to store some temporary files on NFS which was hanging (solution was to set CUDA_CACHE_PATH to local directory). You can get more logging with export TF_CPP_MIN_VLOG_LEVEL=1, although it's going to be a deluge

We finally resolved this. We had a tf.cond() buried in the objective function which caused our while_loop to hang. We wound up doing some re-factoring using the tf.where(). Is there a better op which can implement a simple conditional which accepts a single bool scalar (vice a bool mask) and returns a tensor?

I think tf.cond is such conditional, it shouldn't be producing a hang, can you give a reproducible example so this could be fixed?

Give me  bit to simplify an example. If/when -- shall I post it as a new issue?

yes, new issue

cc @yuanbyu to verify there are no known cases where executing tf.cond is supposed to cause a hang

Periodically evaluating model performance on unseen test data while training is an important use case.  Any updates that occur to the model during testing invalidate the test's results.

Is this issue ready to close?

@alextp said something about plans for a mechanism to update a group of variables together, did anything happen with it?

I think @ebrevdo might be taking this on. Assigning to him so he can confirm or deny....

@danijar Indeed I'm working on a locking mechanism; we can talk about it offline.  There's an early design, and some code, but I'm not sure if the version I have in mind now will be the version we end up with in the end.  It relies on using ResourceVariables instead of regular Variables.  @sguada is also appraised on the situation.

Note as of now, the locking mechanism is restricted to all ops and associated [Resource]Variables sitting on the same device.  And one initial limitation might be that it must be a CPU.

It has been 14 days with no activity and this issue has an assignee.Please update the label and/or status accordingly.

@ebrevdo Any updates, or ready to close?

Yes; see tf.contrib.framework.CriticalSection.


Add setup script

This should be able to download Emacs, tmux, etc. and configure them appropriately (backing up dotfiles, creating symlinks, etc.). In particular, it should be able to set iTerm2 keybindings so that things like C-/ work properly.

This can be tested using VirtualBox, which I've managed to get a copy of El Capitan running on.

This is partially addressed in b42daf55f3e8d3aa391df95ddeef29eed4840f0d. More features will need to be added as this project expands to include dotfiles for vim, tmux, etc.

This can considered to be fairly complete as of f1f6992173b9d8196ed08c3455896f3cf7d8d5ca. It's not a complete setup, but it does cover all of the things that are implemented so far. (Except Leiningen, I suppose. But that should wait until profiles.clj is configured more appropriately, probably.)


Extension assembly isolation

Current behavior
DevToys relies on some dependencies, such as NuGet.Versioning, version 6.9.
If I create a DevToys extension that relies on a different version of NuGet.Versioning, such as 5.0 or 6.11, it is ignored, and instead, the version 6.9 is used.
This causes a major problem when an extension tries to invoke a feature from 6.11 that does not exist in 6.9.
See discussion here: https://github.com/DevToys-app/DevToys/discussions/1333#discussioncomment-11053480
How to reproduce it (as minimally and precisely as possible)
Create a DevToys extension that uses Nuget.Versioning version 6.11.
Expected behavior
it should uses the NuGet version I used in my extension
Screenshots

Workaround
Use the same version than DevToys.
Affected platforms
No response
Affected DevToys kind
DevToys (app with GUI)
DevToys Version
<IP_ADDRESS>
Relevant Assets/Logs
No response

Sadly the fix was reverted in #1449 as it was not compatible for all platforms.
Can we reopen this issue and is there a potential different fix?
Is this even an issue for Mac?

Indeed, sorry about that. It was causing a regression on Mac so I quickly reverted the change. And yes, this issue also applies on Mac and Linux.


A question on action_gradients in critic_net_bn.py

Hi,
I just read through your DDPG implementation, and it looks awesome. Thanks for sharing!
Currently, I feel confusion about the below code
self.action_gradients = [self.act_grad_v[0]/tf.to_float(tf.shape(self.act_grad_v[0])[0])]
in critic_net_bn.py.
Why do we add [0] after self.act_grad_v  since we use a batch of actions to compute gradients?
What does "[0]" use for?
Thank you so much!

self.act_grad_v[0] retrieves elements in the list.


Cloud Config Server returns 404 when profile name contains more than one dash "-"

Spring Cloud Config supported dashes "-" in profile names when using spring-cloud-dependencies: 2020.0.3.
We wanted to migrate to Version: 2021.0.1, but there was a problem, that you'll always recive a 404 (NOT FOUND), wenn die profile name contains a dash "-". Reason for this Error is probably this change:
Commit: https://github.com/spring-cloud/spring-cloud-config/commit/facb18da95e81f7058a63b408c180fe333a5c29d
Class: https://github.com/spring-cloud/spring-cloud-config/blob/main/spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/environment/EnvironmentController.java
We saw, that in the newest version, there will be a fix for that problem in Version 2021.0.2 so we waited for it. The good news it, that now the EnvironmentController does support dashes in Profile Names. But now, when the profile name contains json, you recieve a 404 (NOT FOUND). For example: enable-json-conversion, enable-json

So you are saying that if the profile name contains -json it returns a 404?

Yes first i thought, more than one dash is the problem, but it is, when the profile name contains json. For example enable-json-conversion


SD Card not showing in Gamepad UI settings after formatting with Chimera App

Build: 4728e72
Device: Intel HD615/GPD Win2
Bios: 2.13
Problem:  After formatting an SD card on the Win2, and rebooting system the SD card does not show up in the GamepadUI under "settings".  Unable to install a game from within GameMode to this drive.
Troubleshooting:
SD card (8GB) shows as successfully formatted in the Chimera OS web app.
lsblk command shows that the card is mounted to the /run/media/gamer/{GUID} dir
Navigating to the path shows that there is a steamapps directory structure on the sdcard
Reviewing Journelctl I can see that the device is mounted, and system thinks all is well.

I have done some work to fix this recently. Can you see if this issue persists on the testing channel?
sudo frzr-deploy chimeraos/chimeraos:testing


Strange code in kvstore rangeKeys function

https://github.com/coreos/etcd/blob/master/mvcc/kvstore_txn.go#L134
https://github.com/coreos/etcd/blob/master/mvcc/kv.go#L24
There is limit parameters parsed to the range function. However, the range limit is always 0. It will result in range all the keys from kv store.
type RangeOptions struct {
	Limit int64
	Rev   int64
	Count bool
}

func (tr *storeTxnRead) rangeKeys(key, end []byte, curRev int64, ro RangeOptions) (*RangeResult, error) {
...
	var kvs []mvccpb.KeyValue
	for _, revpair := range revpairs {
		start, end := revBytesRange(revpair)
		_, vs := tr.tx.UnsafeRange(keyBucketName, start, end, 0)
		if len(vs) != 1 {
			plog.Fatalf("range cannot find rev (%d,%d)", revpair.main, revpair.sub)
		}
...

@armstrongli it's fetching keys one-by-one since end bounds the range request to a single key; the unlimited fetch is in tr.s.kvindex.Range(...), however. I think there's potential for getting rid of an allocation in this path, though-- the end doesn't look necessary.


🐛 Hotfix/multiple mark call storing issue 1478

This PR resolved ticket #1478 to store every mark call of a user for simple/factorial experiment.

Closing this as not relevant now, I will create another fresh PR for the correct issue.

Closing this PR as not a bug, I will create another fresh PR for the correct issue pointed in ticket.


Group unit tests in test suites

Right now many unit test files only include top-level unit tests (with test() or it()). We'd like to group all unit tests of a file into a test suite. To do this, we need to wrap all tests into a describe call.
This could look like this:
Before:
const { decrement } = require("../lib");

test("decrement of 1 to equal 0", () => {
  expect(decrement(1)).toBe(0);
});

test("decrement of 2 to equal 1", () => {
  expect(decrement(2)).toBe(1);
});

test("decrement of 0 to equal -1", () => {
  expect(decrement(0)).toBe(-1);
});

After:
const { decrement } = require("../lib");

describe("decrement", () => {
  test("decrement of 1 to equal 0", () => {
    expect(decrement(1)).toBe(0);
  });

  test("decrement of 2 to equal 1", () => {
    expect(decrement(2)).toBe(1);
  });

  test("decrement of 0 to equal -1", () => {
    expect(decrement(0)).toBe(-1);
  });
});

An example of the it function can be found in test/combinations.test.js

@damjanh Thanks! I will add the label :)

Thank you for this @damjanh !!


reword output of create to point to analyze

Description
Since we renamed the init task to analyse we might as well incentivise people to use that one directly instead to prevent them getting any future bumps with deprecations and whatnot

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@all-contributors please add @bastienboutonnet for code


Remove deprecated properties

Clean up and remove several deprecated properties for the 3.0.0 release
This closes #3105

I'd like a couple people to take a look to make sure I didn't screw anything up when I was removing deprecated properties. I ran through the sunny tests and they passed but we should also kick off a full IT if it looks good. As I noted in #3105, this is the first pass to remove most of the properties that were easy to clean up. Follow on issues will be done for more in depth changes for things like compaction strategy.

I updated to remove the deprecated HadoopLogCloser class as well as it was moved to a new location and the deprecated property is removed as part of this PR

@ctubbsii - I forgot this PR was still open as well but I will have to fix the merge conflicts, probably Friday.

Ok I fixed the merge conflicts so it should be ready to go.


Replace GnuPG with Sequoia-PGP to improve compatibility against OpenPGP RFC 9580

https://sequoia-pgp.org/
https://wiki.archlinux.jp/index.php/OpenPGP
https://wiki.archlinux.jp/index.php/GnuPG#OpenPGP_.E3.81.AE.E4.BA.92.E6.8F.9B.E6.80.A7
https://www.rfc-editor.org/rfc/rfc9580.html
https://gitlab.com/sequoia-pgp/sequoia
https://gitlab.com/sequoia-pgp/sequoia-gpg-agent
https://github.com/sequoia-pgp/authenticate-commits
https://github.com/NixOS/nixpkgs/blob/6c843e113714e5e47a446ef949a6c12e028cf669/pkgs/by-name/se/sequoia-sq/package.nix
Looks like https://github.com/cortex/ripasso is also using Sequoia-PGP
https://github.com/NixOS/nixpkgs/blob/6c843e113714e5e47a446ef949a6c12e028cf669/pkgs/tools/security/ripasso/cursive.nix#L20

--export-secret-subkeys

https://superuser.com/questions/1577858/what-is-export-secret-subkeys-used-for

The second form of the command has the special property to render the secret part of the primary key useless; this is a GNU extension to OpenPGP and other implementations can not be expected to successfully import such a key. Its intended use is in generating a full key with an additional signing subkey on a dedicated machine. This command then exports the key without the primary key to the main machine.

ref: https://github.com/kachick/dotfiles/pull/869

https://github.com/NixOS/nixpkgs/blob/64b80bfb316b57cdb8919a9110ef63393d74382a/pkgs/tools/security/gnupg/24.nix#L36C17-L36C27


Problem with the firmware

Good afternoon, I wanted to try your project, but I can't flash the esp, wifi does not start. Could you check it out or is there any additional instruction for your project? Or when can I expect new software? page "For More Information Visit https://www.studiopieters.nl/esp8266-homekit-blinds" it doesn't work the same way.
Do I need blankconfig and rboot for the firmware? if so, where can I get it?
Thank you in advance for your response and for your invaluable projects.

@EgorMuhin here you will find all information needed": https://www.studiopieters.nl/homekit-accessoires/


feat(quantic): added accessibility functionality to quanticFacetValue Implementation A

SVCC-2272
SVCC-2273
SVCC-2274
Two implementations are implemented for selection

Implementation A:
Added dom element "fieldset" and "legend" for voiceover
Edited tabindex attribute of "fieldset" and "legend"
Function onKeyDown added to track keyboard input
Implementation B:
https://github.com/coveo/ui-kit/pull/2248

To be clear about what this proposed solution does @MSLI-Coveo ,
this keeps the original HTML except changing the  to be in the Facet component instead of the FacetValue component right?
Also it adds a FieldSet and Legend + a div role checkbox|button attribute?

You need to run a linter on your code as well to fix the formatting and to make sure to have ; everywhere etc.
I am also unsure of having a aria-checked attribute on a <div role="button" is compliant but maybe we can overlook it.
We can talk about it during the review.

can you build the live-demo link for me to test with the screen reader ?
@erocheleau fyi

@MSLI-Coveo I added this jira too, since you are fixing it at the same time in this PR right?
SVCC-2287


[BUG] TC-CC-6.5: Getting incorrect value of start-up-color-temperature-mireds attribute of color control cluster

Reproduction steps

Commission device using chip-tool
Execute the below command
./chip-tool colorcontrol write start-up-color-temperature-mireds 32639 1 1
power off DUT
Power on DUT
Execute the below command
./chip-tool colorcontrol read start-up-color-temperature-mireds 1 1
Expected that the DUT response indicates that the StartUpColorTemperatureMireds and color-temperature-mireds attributes match the StartUpColorTemperatureMireds set in Step 2. but, I'm getting a null value for StartUpColorTemperatureMireds and 250 for color-temperature-mireds which is getting before setting StartUpColorTemperatureMireds attribute.
esp32.txt
chip-tool.txt

Bug prevalence
Everytime
GitHub hash of the SDK that was being used
1aca004d68640ae7df27adea09315308cf1913cd
Platform
esp32
Platform Version(s)
v1.2
Anything else?
No response

@VaishaliAvhale In the ZAP config for your device, is the storage for color-temperature-mireds set to RAM or NVM?  It should be set to NVM.


Build the production site for Cypress tests.

In #593 I noticed that building the production site actually sped up the overall time for Cypress tests in Travis because the production site responds faster (see the difference between the partner Cypress tests with production build and the public Cypress tests with dev build here). So, apply the same to the public site.

Is the partner build timing out because it's trying to restore a cache that's way too large? I can't really tell from the output logs.

That's a good question - I can't tell either; it could be?

This thread may be useful: https://github.com/travis-ci/travis-ci/issues/10113
It suggests we clean the cache and rebuild.

Maybe it was just a transient failure - it only happened that one time on this branch (and after merging with main again it passed).


[FR] deepflow-agent set dynamic configurations

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
The current configuration is located in src/config/ as .rs files rather than in config files or env vars that can be populated during the agent setup dynamically.
The feature is make the agent/server configuration dynamic as env vars with code defaults.to makes
Use case
I'd like to enable only metrics by default (l7_metrics_enabled) and disable (l4_performance_enabled) in some cases to improve DB capacity management and align the needs with expectations.
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello, it appears you wish to alleviate storage pressure by reducing the amount of data in certain areas. You can refer to this article to address this issue by reducing unnecessary collection points. However, in most cases, users require data from all aspects, so we do not disable the collection of certain metrics by default. Users must decide for themselves which data they do not need. For information on how to change the configuration, you can refer to this article.

Thanks for the quick answer @1473371932
I'll take a look at both links, it seems there is still a lot of info that hasn't been translated like this which includes networking info.
Any plan to translate more pages to EN soon?

Any plan to translate more pages to EN soon?

We will release version 6.5 soon (planned for mid-June). Before that, we will update all the documentation to English. @panda87

Thanks for the quick answer @1473371932 I'll take a look at both links, it seems there is still a lot of info that hasn't been translated like this which includes networking info. Any plan to translate more pages to EN soon?

done
https://www.deepflow.io/docs/best-practice/reduce-storage-overhead/


Problem about the dirID

In the code  bindCore((CPU_PHYSICAL_CORE_NUM - 1 - dirID) * 2 + 1), why there is a multiply by 2 since CPU_PHYSICAL_CORE_NUM is already the total number of the CPU cores.

Hi MiraHyc,
The CPU_PHYSICAL_CORE_NUM represents the total number of CPU cores in the NUMA node that is close to the RNIC.
We only bind clients to CPU cores that are close to the RNIC to maximize the performance.
The existing code is written for the r650 machine. In the r650 machine, there are two NUMA nodes. CPU cores with even IDs are on NUMA node 0, while those with odd IDs are on NUMA node 1. Thus, there is a "multiple by 2" in this code.
You can adjust this line of code according to your machine's CPU info (using the lscpu command).
@MiraHyc


Jadeite and unicode

Currently it appears that Jadeite does not handle unicode strings correctly:

Here is the unicode text I used for the experiment:
Unicode16: 'Я можу їсти скло, і воно мені не зашкодить.'

Unicode32: '𣎏'

I have confirmed that Rowan and GemStone handles these strings in methods by first creating methods using topaz and the Rowan api (#rwCompileMethod:):
topaz 1> run
RowanSample1
    rwCompileMethod: 'bar
"
Unicode16: ''Я можу їсти скло, і воно мені не зашкодить.''

Unicode32: ''𣎏''
"

^''bar''
'
    category: 'unicode'
%
'''set -e; cd $ROWAN_PROJECTS_HOME/RowanSample1; git --git-dir $ROWAN_PROJECTS_HOME/RowanSample1/.git --work-tree $ROWAN_PROJECTS_HOME/RowanSample1 log  -1 --pretty=format:%h '''
'a9e1b1a'
aGsNMethod
topaz 1> commit
Successful commit

and then using git diff to confirm that the unicode strings have been written to disk properly (using Jadeite) this includes a sample method created in Jadeite (#foo) with the same strings in a coment :
rogue:RowanSample1>git diff
diff --git a/rowan/src/RowanSample1-Core/RowanSample1.class.st b/rowan/src/RowanSample1-Core/RowanSample1.class.st
index 1f44772..f0fe3c0 100644
--- a/rowan/src/RowanSample1-Core/RowanSample1.class.st
+++ b/rowan/src/RowanSample1-Core/RowanSample1.class.st
@@ -4,6 +4,26 @@ Class {
        #category : 'RowanSample1-Core'
 }

+{ #category : 'unicode' }
+RowanSample1 >> bar [
+"
+Unicode16: 'Я можу їсти скло, і воно мені не зашкодить.'
+
+Unicode32: '𣎏'
+"
+
+^'bar'
+
+]
+
 { #category : 'accessing' }
-RowanSample1 >> foo [ ^'foo'
+RowanSample1 >> foo [
+"
+Unicode16: '? ???? ???? ????, ? ???? ???? ?? ?????????.'
+
+Unicode32: '??'
+"
+
+^'foo'
+
 ]

Using Jadeite only, it doesn't seem to have trouble with Characters in the range up to 256.  I can enter these as method text and the returned text looks correct and the Characters return the correct codepoint and look good on disk.
Oddly, I can also enter the euro character (codePoint U+20A0 / 8352).  It looks fine in the method text and when the method returns it it also looks fine.  However it claims the codepoint is 128 so something is going on.   Possibly dolphin has special case handling.  When I wrote to disk, the method says '<80>' which is clearly wrong.  The worrisome bit is that it looks quite OK in Jadeite... misleading is worse than failing...
My repository is not in unicode comparison mode.  Not sure what the "normal" mode is for Rowanized GemStone.
Customer's list from HR 9823 is:
Prêt-or
Métal
Gültigen
Währung
Trägt
ÄÖÜäöüßéèàôÔ
I would add the Euro
'€'
though we can check with the customer if this is really needed.

Dolphin returns 128 for the code point of the euro character. Based on that, it appears that Dolphin (and hence Jadeite) may be using Windows code page 1252.
https://en.wikipedia.org/wiki/Windows-1252

@dalehenrich I created the method below & committed it to my local repository. Then I reloaded that from disk. It worked as expected.
euro
^'$€ "16r20AC"'

Here is some promising Dolphin/unicode news -  https://github.com/dolphinsmalltalk/Dolphin/issues/508#issuecomment-387853997

Yes, it is good to see that there is progress being made!

Here's a case that I ran into while porting the STON tests that uses the string élève en Français which has 8 bit characters and is treated as a String in GemStone:
Inspect 'élève en Français'/
--------------------
.            -> 'élève en Français'
(class)@     -> String
(oop)@       -> 289553665
(invariant)@ -> true
(size)@      -> 17
(bytes)@     -> #[ 233 108 232 118 101 32 101 110 32 70 114 97 110 231 97 105 115]
(utf8)@      -> #[ 195 169 108 195 168 118 101 32 101 110 32 70 114 97 110 195 167 97 105 115]
1@           -> $é
2@           -> $l
3@           -> $è
4@           -> $v
5@           -> $e
6@           -> $
7@           -> $e
8@           -> $n
9@           -> $
10@          -> $F
11@          -> $r
12@          -> $a
13@          -> $n
14@          -> $ç
15@          -> $a
16@          -> $i
17@          -> $s

I made a change to the method using the Jadeite debugger and saved it to disk and then committed my change and ended up with a difference where the string élève en Français was somehow converted to ?l?ve en Fran?ais when the method was saved/written.
I used Rowan to read the original source from filetree and Rowan to write the filetree source as Tonel after loading the code into GemStone and given the evidence of diff ... the  élève en Français was preserved until the method was saved using Jadeite debugger ... it appears that saves from the system browser preserve the source.
Here's a screen shot that shows the corrupted source:

Here's a screen shot that shows the correct source (after restoring the string using vi):

Here's a screen shot that shows the correct source after save in browser (added comment):

And finally here's a screen shot that shows that the source is corrupted when displayed in the debugger (correct string visible in system browser code pane):

Soooo we might not quite be out of the woods with unicode issues, but this particular problem just might be solvable ... the debugger must be doing something different to display/save source ...


WebStorm support

Any plans on supporting WebStorm?

compatible with any IntelliJ IDE if possible

Please see #13

We now support IntelliJ IDEs! https://tabnine.com/install


Exiting the app

When the function tagged with #[ndk_glue::main] returns, the app hangs, unless ndk_glue::native_activity().finish() is called just before. Should the ndk_glue::main append ndk_glue::native_activity().finish() at the end of the function?

@zarik5 Thanks for reporting! I have definitely been thinking about calling it after fn main():
https://github.com/rust-windowing/android-ndk-rs/blob/49e8ed51220567dccac9fd1e8baa526e9cdac163/ndk-glue/src/lib.rs#L183-L202
We can perform and publish this as a breaking change as it might potentially break an application that spawns its own thread while accidentally returning from fn main() when the app (and looper etc) is still very much alive.

We've had quite the discussion in #160 and automatically calling .finish() upon returning from fn main() seems undesirable at best; applications will have to call it themselves.
I'll think about how to best resolve this issue; probably by updating some examples and documentation to explicitly call this function.

closing for now, please reopen in https://github.com/rust-mobile/android-activity if still relevant


Error thrown on startup

This is with the latest atom version since today.
It happens on startup
Wild guess: this could be the problem: https://github.com/atom/atom/pull/12925/commits
Atom Version: 1.11.0
Electron Version: 0.37.8
System: Microsoft Windows Server 2012 R2 Standard
Thrown From: tab-switcher package, v1.5.3
Stack Trace
Failed to activate the tab-switcher package
At Arguments to CompositeDisposable.add must have a .dispose() method

TypeError: Arguments to CompositeDisposable.add must have a .dispose() method
    at assertDisposable (C:\Users\vagrant\AppData\Local\atom\app-1.11.0\resources\app.asar\node_modules\event-kit\lib\composite-disposable.js:70:13)
    at CompositeDisposable.module.exports.CompositeDisposable.add (C:\Users\vagrant\AppData\Local\atom\app-1.11.0\resources\app.asar\node_modules\event-kit\lib\composite-disposable.js:43:11)
    at new TabListView (file:///C:/Users/vagrant/.atom/packages/tab-switcher/lib/tab-list-view.coffee:60:17)
    at new TabList (file:///C:/Users/vagrant/.atom/packages/tab-switcher/lib/tab-list.coffee:16:17)
    at Object.TabSwitcher.deserialize (file:///C:/Users/vagrant/.atom/packages/tab-switcher/lib/tab-switcher.coffee:36:34)
    at Object.module.exports.activate (file:///C:/Users/vagrant/.atom/packages/tab-switcher/lib/tab-switcher.coffee:66:19)
    at Package.module.exports.Package.activateNow (C:\Users\vagrant\AppData\Local\atom\app-1.11.0\resources\app.asar\src\package.js:183:20)
    at C:\Users\vagrant\AppData\Local\atom\app-1.11.0\resources\app.asar\src\package.js:156:32
    at Package.module.exports.Package.measure (C:\Users\vagrant\AppData\Local\atom\app-1.11.0\resources\app.asar\src\package.js:92:15)
    at C:\Users\vagrant\AppData\Local\atom\app-1.11.0\resources\app.asar\src\package.js:149:26
    at Package.module.exports.Package.activate (C:\Users\vagrant\AppData\Local\atom\app-1.11.0\resources\app.asar\src\package.js:146:34)
    at PackageManager.module.exports.PackageManager.activatePackage (C:\Users\vagrant\AppData\Local\atom\app-1.11.0\resources\app.asar\src\package-manager.js:538:21)
    at C:\Users\vagrant\AppData\Local\atom\app-1.11.0\resources\app.asar\src\package-manager.js:519:29
    at Config.module.exports.Config.transactAsync (C:\Users\vagrant\AppData\Local\atom\app-1.11.0\resources\app.asar\src\config.js:337:18)
    at PackageManager.module.exports.PackageManager.activatePackages (C:\Users\vagrant\AppData\Local\atom\app-1.11.0\resources\app.asar\src\package-manager.js:514:19)
    at PackageManager.module.exports.PackageManager.activate (C:\Users\vagrant\AppData\Local\atom\app-1.11.0\resources\app.asar\src\package-manager.js:497:46)
    at C:\Users\vagrant\AppData\Local\atom\app-1.11.0\resources\app.asar\src\atom-environment.js:779:28

Commands

Config
{
  "core": {
    "autoHideMenuBar": true,
    "disabledPackages": [
      "refactor",
      "symbols-view",
      "omnisharp-atom",
      "json-schema",
      "atom-yeoman",
      "wrap-guide",
      "styleguide"
    ],
    "openEmptyEditorOnStart": false,
    "packagesWithKeymapsDisabled": [
      "jasmine-runner",
      "tree-view",
      "git-time-machine",
      "git-line"
    ],
    "projectHome": "C:\\Development",
    "telemetryConsent": "limited",
    "themes": [
      "atom-material-ui",
      "new-moon-atom-syntax"
    ]
  }
}

Installed Packages
# User
advanced-open-file, v0.16.4 (inactive)
aligner, v0.22.2 (inactive)
aligner-javascript, v1.0.0 (inactive)
aligner-ruby, v1.5.0 (inactive)
atom-beautify, v0.29.13 (inactive)
atom-material-ui, v1.3.6 (inactive)
atom-ternjs, v0.15.0 (inactive)
atom-visual-studio-code-ui, v1.3.4 (inactive)
autoclose-html, v0.23.0 (inactive)
autocomplete, v0.47.0 (inactive)
autocomplete-paths, v1.0.2 (inactive)
bottom-dock, v0.4.4 (inactive)
clipboard-history, v0.6.6 (inactive)
color-picker, v2.2.2 (inactive)
column-select, v0.2.0 (inactive)
docblockr, v0.8.7 (inactive)
double-tag, v0.4.0 (inactive)
editorconfig, v1.4.1 (inactive)
feedback, v0.38.0 (inactive)
file-icons, v1.7.21 (inactive)
git-history, v3.2.0 (inactive)
git-line, v0.5.0 (inactive)
git-log, v0.4.1 (inactive)
git-time-machine, v1.5.3 (inactive)
gulp-manager, v0.2.19 (inactive)
highlight-selected, v0.11.2 (inactive)
language-batch, v0.3.3 (inactive)
language-cshtml, v0.2.1 (inactive)
language-gherkin, v1.0.4 (inactive)
language-groovy, v0.6.0 (inactive)
language-powershell, v4.0.0 (inactive)
language-puppet, v0.21.0 (inactive)
linter, v1.11.18 (inactive)
linter-eslint, v8.0.0 (inactive)
linter-rubocop, v0.5.0 (inactive)
merge-conflicts, v1.4.4 (inactive)
minimap, v4.25.0 (inactive)
minimap-highlight-selected, v4.4.0 (inactive)
minimap-linter, v1.6.0 (inactive)
minitest-snippets, v0.2.0 (inactive)
new-moon-atom-syntax, v2.0.6 (inactive)
open-in-browser, v0.4.7 (inactive)
open-recent, v5.0.0 (inactive)
pretty-json, v1.6.1 (inactive)
ruby-block, v0.3.5 (inactive)
ruby-bundler, v0.3.0 (inactive)
save-session, v0.16.0 (inactive)
sync-settings, v0.7.2 (inactive)
tab-switcher, v1.5.3 (inactive)
todo-show, v1.7.0 (inactive)
xml-formatter, v0.10.0 (inactive)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.44.0 (inactive)
base16-tomorrow-dark-theme, v1.2.0 (inactive)
base16-tomorrow-light-theme, v1.2.0 (inactive)
one-dark-ui, v1.6.0 (inactive)
one-light-ui, v1.6.0 (inactive)
one-dark-syntax, v1.3.0 (inactive)
one-light-syntax, v1.3.0 (inactive)
solarized-dark-syntax, v1.0.2 (inactive)
solarized-light-syntax, v1.0.2 (inactive)
about, v1.7.0 (inactive)
archive-view, v0.61.1 (inactive)
autocomplete-atom-api, v0.10.0 (inactive)
autocomplete-css, v0.11.2 (inactive)
autocomplete-html, v0.7.2 (inactive)
autocomplete-plus, v2.31.1 (inactive)
autocomplete-snippets, v1.11.0 (inactive)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (inactive)
background-tips, v0.26.1 (inactive)
bookmarks, v0.42.0 (inactive)
bracket-matcher, v0.82.1 (inactive)
command-palette, v0.38.0 (inactive)
deprecation-cop, v0.54.1 (inactive)
dev-live-reload, v0.47.0 (inactive)
encoding-selector, v0.22.0 (inactive)
exception-reporting, v0.40.0 (inactive)
find-and-replace, v0.201.1 (inactive)
fuzzy-finder, v1.4.0 (inactive)
git-diff, v1.1.0 (inactive)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.2 (inactive)
image-view, v0.59.0 (inactive)
incompatible-packages, v0.26.1 (inactive)
keybinding-resolver, v0.35.0 (inactive)
line-ending-selector, v0.5.0 (inactive)
link, v0.31.1 (inactive)
markdown-preview, v0.158.0 (inactive)
metrics, v1.0.0 (inactive)
notifications, v0.65.1 (inactive)
open-on-github, v1.2.0 (inactive)
package-generator, v1.0.0 (inactive)
settings-view, v0.242.2 (inactive)
snippets, v1.0.2 (inactive)
spell-check, v0.68.2 (inactive)
status-bar, v1.4.1 (inactive)
styleguide, v0.47.0 (inactive)
symbols-view, v0.113.1 (inactive)
tabs, v0.101.0 (inactive)
timecop, v0.33.2 (inactive)
tree-view, v0.209.3 (inactive)
update-package-dependencies, v0.10.0 (inactive)
welcome, v0.35.1 (inactive)
whitespace, v0.33.0 (inactive)
wrap-guide, v0.38.2 (inactive)
language-c, v0.52.1 (inactive)
language-clojure, v0.21.0 (inactive)
language-coffee-script, v0.47.2 (inactive)
language-csharp, v0.12.1 (inactive)
language-css, v0.37.1 (inactive)
language-gfm, v0.88.0 (inactive)
language-git, v0.15.0 (inactive)
language-go, v0.42.1 (inactive)
language-html, v0.45.1 (inactive)
language-hyperlink, v0.16.0 (inactive)
language-java, v0.23.0 (inactive)
language-javascript, v0.119.0 (inactive)
language-json, v0.18.2 (inactive)
language-less, v0.29.5 (inactive)
language-make, v0.22.2 (inactive)
language-mustache, v0.13.0 (inactive)
language-objective-c, v0.15.1 (inactive)
language-perl, v0.35.0 (inactive)
language-php, v0.37.2 (inactive)
language-property-list, v0.8.0 (inactive)
language-python, v0.45.0 (inactive)
language-ruby, v0.69.0 (inactive)
language-ruby-on-rails, v0.25.0 (inactive)
language-sass, v0.56.0 (inactive)
language-shellscript, v0.22.4 (inactive)
language-source, v0.9.0 (inactive)
language-sql, v0.23.0 (inactive)
language-text, v0.7.1 (inactive)
language-todo, v0.28.0 (inactive)
language-toml, v0.18.0 (inactive)
language-xml, v0.34.9 (inactive)
language-yaml, v0.26.0 (inactive)

# Dev
No dev packages

Maybe need to do this for the listeners https://github.com/atom/dom-listener?

Thanks for the report -- fix pushed!


Armor names to automatically include runes

Currently, Weapons will automatically calculate price and modify their name based on what runes it has.
Could this same feature be added to armor?

Duplicate of #1845


feat: added docker-compose for running postgres

Fixes Issue
closes #35

Changes proposed
Added a docker compose file for running postgres database .

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Please can you add some docs to the README, on how to use this during development

I have updated the documentation

Thank you both! Great collab 💪


fix: typescript rendering wrong array type when union

Description
This PR fixes an issue where an array with union type renders it incorrectly.
Fixes https://github.com/asyncapi/modelina/issues/914
Part of https://github.com/asyncapi/modelina/pull/905

/rtm


Use ConcreteAttributePath for reads below ReadSingleClusterData.

The ReadSingleClusterData in TestReportingEngine.cpp was not being
used, because it had the wrong signature.  And making it be used
by fixing the signature apparently makes the test fail...
Problem
We're using ClusterInfo, which is a very generic data structure that may not be a valid concrete attribute path.
Change overview
Use ConcreteAttributePath, which is what we will have after group/wildcard expansion.
Testing
Passes existing unit tests.  No intended behavior changes.

@mrjerryjohns @saurabhst @andy31415 @Damian-Nordic @jelderton @jepenven-silabs @jmartinez-silabs ?


Misconfigured strategies are activated but fail silently

I've found that invalid strategies can be added to a coordinator, and even activated, but they fail silently (even with blocking: true) during task processing.
Some examples of invalid strategies:

Using SyncStrategy with JSONAPISource (which is not Syncable)
Misspelling the action to invoke for the target (this is generalization of the first case)
Misspelling the on to listen for the source

In the first two cases, the generated listener throws an exception when trying to invoke the (missing) action, but (unless the listener was attached to a beforeXxx event) the exception is swallowed by settleInSeries.
In the third case, the generated listener is attached to an event that will never fire, so it has no effect.
To avoid confusion and help identify invalid strategies, it would be ideal if these cases were detected during coordinator/strategy activation.

I just realized this was the wrong repo.  Re-filed as https://github.com/orbitjs/orbit/issues/723


Algorithm functions bug and tgcloud.io Connection Failure

We are using pyTigerGraph to do tg_louvain alogorithm on our graph database. We tried to do this in two ways.

As the screen shot shown below, we have set up a local TG database(3.7) on our local server and successfully get connected through pyTigerGraph(1.1) connection.(python 3.8)

However, when trying to use installAlgorithm or runAlgorithm functions, we meet a connection error as shown below:

It would be much appreciated If this problem can be solved.

Alternatively, we tried to connect to TigerGraph cloud db to see if it works. However, the connection could not be set up. It seems that the updated 3.7.0/3.6.2 versions of TG online clusters are not well documented. We couldn't find helpful guidlines or tutorials to make the pyTigerGraph connection successful.

Hi @tonymhl - can you tell us more about the environment you are running the notebook in? The first issue appears to be that pyTigerGraph cannot access the Louvain query on our github repo. Does the machine you are running it on have internet access?
The TG cloud issue is due to the way you should specify usernames and passwords. It is not your login info, rather, you need to set up users in the access management screen you took a screenshot of.
Hope this helps!

Hi @parkererickson - The environment I am running the notebook is Python3.8. The machine we are running it on does have the internet access.
Curretly, we have almost resolved issue of connecting tgcloud, by adding  SSL certificate on local server, which missing will stop the server connecting to tgcloud.
We are getting assistance from CUSTOMER SUPPORT#46248,
where provided below script to connect tgcloud solution:
import pyTigerGraph as tg
hostName = "https://mydb.i.tgcloud.io"
graphName = "Cora"
secret = "token"
userName = "tigergraph"
password = ""
conn = tg.TigerGraphConnection(host=hostName, graphname=graphName)
authToken = conn.getToken(secret)
authToken = authToken[0]
print(f"SHHHH.... Keep this a secret. Here's your token:\n {authToken}")
Establish Connection
conn = tg.TigerGraphConnection(host=hostName, graphname=graphName, username="__GSQL__secret",
password="token",
apiToken=authToken)
print("hello")
ls_results = conn.gsql("LS")
print("ls result", ls_results)
results = conn.getSchema()
print(results)

or I am simply doing:
from pyTigerGraph import TigerGraphConnection
conn = TigerGraphConnection(host="https://mydb.i.tgcloud.io", graphname="Cora", gsqlSecret="token")
conn.getToken('token')
We notice that when we run the notebook on Google Cloab, the runAlgorithm function will run successfully. However, if we do it on our local Linux server installed with TigerGraph Community edition, the runAlgorithm function might report ConnectionError.
We can successfully have our local Linux server installed with TigerGraph Community edition, and have our python notebook connected to it, as the picture shows:

It can successfully show all the available algorithms, e.g. Louvain query, on TG github repo, as shown below:

However, whenever we try to run any specific algorithm, for example, tg_louvain, we get ConnectionError:

We tried to install the algorithm manually in advance, we see that installAlgorithm part gets pass, however the runAlgorithm part still gets ConnectionError:

Kinda wondering why running installed query still requires connection to TG github repo? (*If running installed query no longer requires connection to TG github repo, this issue will get resolved.)
We have figured out that it is an issue with the VPN for Internet access on our machine that caused the ConnectionError, since switching VPN could resolve the issue.
In conclude, We are trying to implement this project which is available on GitHub: https://github.com/KstecGit2021/TG-mlworkbench-docs-kr/tree/main/tutorials/basics
The main issue is about this Feature Engineering part, which involves doing TG Algorithms:
https://github.com/KstecGit2021/TG-mlworkbench-docs-kr/blob/main/tutorials/basics/2_feature_engineering.ipynb
In brief, our final goal is that we make this workflow run successfully, either through local TigerGraph Community version  or through tgcloud .  For tgcloud, we see that Google Cloab managed to run the workflow successfully, however, since Colab is a google service, we cannot move on to our next stage of software engineering which involves packaging our workflow into a program. We need to have a successful and stable workflow on our local python script, either through local TigerGraph Community version or tgcloud.
Thank you.


Return self from NativeMailerHandler::addHeader().

NativeMailerHandler::setContentType() and NativeMailerHandler::setEncoding() both return the NativeMailerHandler object, allowing a fluent coding style.  This fix adds the same behaviour to NativeMailerHandler::addHeader() for so that all public non-inherited methods behave this way for consistency.

Thanks

No probs, thanks for merging.


Fixed formatting of jetbrains index

I just made a pull request earlier and the content was fine, but for whatever reason the formatting was all messed up. I fixed that now and it looks a lot better.
Thanks!

Thanks @jeffreylec!

of course! thanks!


[bug]: Checking the checkbox in data table increases height of rows.

Describe the bug
Issue
On checking the CheckBox component in the Data Table, the height of rows increases.
My Solution
The Checkbox component contains the following code:
"use client"

import * as React from "react"
import * as CheckboxPrimitive from "@radix-ui/react-checkbox"
import { Check } from "lucide-react"

import { cn } from "@/lib/utils"

const Checkbox = React.forwardRef<
  React.ElementRef<typeof CheckboxPrimitive.Root>,
  React.ComponentPropsWithoutRef<typeof CheckboxPrimitive.Root>
>(({ className, ...props }, ref) => (
  <CheckboxPrimitive.Root
    ref={ref}
    className={cn(
      "peer h-4 w-4 shrink-0 rounded-sm border border-primary ring-offset-background focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:cursor-not-allowed disabled:opacity-50 data-[state=checked]:bg-primary data-[state=checked]:text-primary-foreground",
      className,
    )}
    {...props}
  >
    <CheckboxPrimitive.Indicator
      className={cn("flex items-center justify-center text-current")}
    >
      <Check className="h-4 w-4" />
    </CheckboxPrimitive.Indicator>
  </CheckboxPrimitive.Root>
))
Checkbox.displayName = CheckboxPrimitive.Root.displayName

export { Checkbox }

Changing the following line
  <Check className="h-4 w-4" />

to
  <Check className="h-3 w-3" />

fixes the issue.
I don't know if this solution messes up the implementation of Checkbox in any other case. If this seems an acceptable solution, I would like to be assigned this issue. I would create a PR with the above-mentioned solution.
Affected component/components
Data Table
How to reproduce
Implement the demo table on https://ui.shadcn.com/docs/components/data-table.
OR
Check out the StackBlitz link provided.
Codesandbox/StackBlitz link
https://stackblitz.com/edit/stackblitz-starters-rx7yav?file=app%2Fpage.tsx
Logs
No response
System Info
System: Macbook M1
Issue is seen in the following browsers: Chrome, Brave, Safari, Firefox

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues

The easiest way to fix this is to set wherever you're using the checkbox to the same height as the checkbox.
Using the Shadcn example for Row Selection:
    header: ({ table }) => (
      <Checkbox
        className="flex h-4 w-4"
        checked={
          table.getIsAllPageRowsSelected() ||
          (table.getIsSomePageRowsSelected() && "indeterminate")
        }
        onCheckedChange={(value) => table.toggleAllPageRowsSelected(!!value)}
        aria-label="Select all"
      />
    ),
    cell: ({ row }) => (
            <Checkbox
              checked={row.getIsSelected()}

              className="flex h-4 w-4"
              onCheckedChange={(value) => row.toggleSelected(!!value)}
              aria-label="Select row"
            />

This also resolves the cross browser differences. However the sizing of the checkmark itself slightly increases, but you can try to change that in the component itself.

I just set the height of wherever I'm using the Checkbox as the height of the Checkbox.
Using the Shadcn example for Row Selection:
    header: ({ table }) => (
      <Checkbox

        className="flex h-4 w-4"

        checked={
          table.getIsAllPageRowsSelected() ||
          (table.getIsSomePageRowsSelected() && "indeterminate")
        }
        onCheckedChange={(value) => table.toggleAllPageRowsSelected(!!value)}
        aria-label="Select all"
      />
    ),
    cell: ({ row }) => (
            <Checkbox

              className="flex h-4 w-4"

              checked={row.getIsSelected()}
              onCheckedChange={(value) => row.toggleSelected(!!value)}
              aria-label="Select row"
            />

I think this also resolves the issue across browsers. However the sizing of the checkmark itself slightly increases, but you can try to change that in the component itself to fix that.

https://github.com/shadcn-ui/ui/pull/4772


Planned refactors and changes

[x] Fixtures need entry point. #52
[x] Family as attribute (sorted). #55
[ ] Maybe some way to sort families.
[ ] Check/rating unify language.
[ ] --url (auto?) loading.
[ ] Selection mechanism (backends, for example)

Pretty much, this is basically the todo list of things that might change the API for plugins (well, except for URL, but that's easy). Getting these done before the split would be ideal.

Refactored. Starting split next.

Remaining things before a non-beta release (at beta 2 currently):

[ ] Update readme
[ ] Basic docs on writing checks / fixtures
[ ] Some downstream checking to make sure sp-repo-review works

This is pretty close to a non-beta release. @pllim or @Carreau, let me know if you have any final thoughts. Docs are up at https://repo-review.readthedocs.org, with details on how to write plugins with fixtures & checks.

Hello! At a glance, would be nice for the doc to have "Install" and "Getting Started". I would like to know how to install the engine and then build customized checks (the latter seems to be covered well in the docs).
Also, did you say you plan to have Action workflow as well at some point, or maybe I got confused with a different effort at the summit?
Thanks! 😸

I do have an action (#45), but it's not really very useful without a plugin - there are no built-in checks. And you'd want to have the action pinned on the plugin, I'd expect, so it's more of an example for plugins than a useful thing by itself. Same thing is a bit of an issue for supporting pre-commit (#48), and a reason I didn't really have a installing/getting started - you can't do anything without installing at least one plugin. But (like the web app), I can do it with sp-repo-review as an example, I guess.

Okay, finished off the action & pre-commit, plus added some docs.

Do you think the engine could come with one plugin shipped so it could run as-is? Is there some check that everybody wants? flake8? 🤔

Thank you, the updated doc is super helpful!

Repo-review doesn't make any assumptions about what is in the repo you want to review. It doesn't have to be Python. It does provide a pyproject fixture, since it supports reading config from pyproject.toml, but one doesn't need to exist. It also does have integrated support for a "package" separate from the repo "root", but that's not Python specific.
I'm just using sp-repo-review as the demo, and maybe we could make a repo-review-example repo or something like that in the future with a few example checks.
Also, does anyone still use flake8 now that Ruff exists? Every repo I'm involved with transitioned to Ruff some time ago.


Overhaul the function parameters so they have only the options they need

We currently allow the global roku-deploy options to just be passed around everywhere, which makes all the functions much more confusing because most of the time they don't need most of those options.
We need to create separate objects/interfaces for each function call, so it's clear how to use each one.

In https://github.com/rokucommunity/roku-deploy/pull/126


Refactor sorting

This was supposed to be straightforward but it grew horns and turned a bit nasty. I've tried to break it up a bit by commits but it is a bit chunky.
https://www.figma.com/file/wyEeHQ1U9aCXOJdzh8lF8a/Sprint-72?node-id=91%3A1092
Changes in this PR

Fix and refactor sorting for publisher jobs dashboard
Update jobseeker saved jobs dashboard to accommodate refactored sorting
Add sorting to jobseeker subscriptions dashboard while I'm here

Other than my comments, looks good! There still feels like a refactoring or two left in it somewhere, but let's get this in first.

The whole journey from where we were to now has been a hell of a ride, and we probably would have benefitted from having a dedicated ticket from the outset about sorting dashboards.
We've gone from the original sorting service which was exclusively for vacancies and tables, to a sorting service that could handle more than just vacancies, to a dashboard that no longer used tables, and eventually to this. Hopefully a separate ticket  will help iron out the kinks we've accumulated along the way!

Other than my comments, looks good! There still feels like a refactoring or two left in it somewhere, but let's get this in first.

The whole journey from where we were to now has been a hell of a ride, and we probably would have benefitted from having a dedicated ticket from the outset about sorting dashboards.
We've gone from the original sorting service which was exclusively for vacancies and tables, to a sorting service that could handle more than just vacancies, to a dashboard that no longer used tables, and eventually to this. Hopefully a separate ticket  will help iron out the kinks we've accumulated along the way!


It looks as I was kicked out of some group chats

There are two whatsapp groups on which I cannot text from whatsie because instead of the usual space where to input text I see the message
You can't send messages to this group because you're no longer a participant.
but from my phone I still can (I am still in those groups).
System: Manjaro KDE on wayland
Whatsie version: latest on AUR (just installed)

Please try to reload the app or maybe wait for it to load properly. BTW its not whatsie's issue.


path length extractor

How can we have an automatic path length extractor graph visualizer?
ideally it would take the netlist and compute the number of bends and total straight

I have a pretty nice tool for this. I can see what I can do about opening it up.

It would be great to have 😊


Module ID conflict on first dev server compilation

The latest version of extract-text-webpack-plugin triggers a weird bug in a webpack bundle where multiple modules share the same module ID.
For more context, see: https://github.com/webpack/webpack/issues/5560#issuecomment-324339585

@avaly thanks for issue, can your provide minimum reproducible test repo?

Unfortunately, no I don't have a minimal test case. Any attempts to remove any number of modules from our giant bundle (1000+ modules) makes the bug not present itself.

@avaly maybe problem in webpack, if you disable extract-text-webpack-plugin all work fine?

I'm running into a similar issue when attempting an upgrade of extract-text-webpack-plugin.
In our case webpack-dev-server successfully completes the initial build of the project.
If you edit a stylesheet the rebuild will have the inconsistent module ID issue mentioned here.
If you then edit a javascript file the rebuild will complete successfully.
Downgrading extract-text-webpack-plugin to 2.1.2 avoids the issue.
Bypassing extract-text-webpack-plugin and just using style-loader directly avoids the issue.

@khalsah maybe you can create minimum reproducible test repo or at least make the screenshot?

We're blocked from upgrading to 3.0 by this issue too, and I've managed to reduce our app down to a near-minimal test case: https://github.com/cultureamp/multi-loader-extract-text-bug
This Webpack configuration uses both multi-loader and extract-text-webpack-plugin, and removing either one seems to make the problem disappear, although I strongly suspect the use of multi-loader is merely a coincidence.

@avaly, @khalsah: Are either of you using multi-loader in your configs?

No multi-loader in our config.

same issue, no multi-loader. also tested:

<EMAIL_ADDRESS>+<EMAIL_ADDRESS>ok
<EMAIL_ADDRESS>+<EMAIL_ADDRESS>not ok

first build is fine, but on rebuild module IDs get moved around

@joaovieira can you provide minimum reproducible test repo, it is allow more faster find solution, thanks!

Yes, will try and see what I can find. Just had to run off of work earlier. Will post with details.

Ok, spent hours trimming it down to this: https://github.com/joaovieira/webpack-extract-bug. Maybe its too small as there are no CSS modules and the Sass file and class that go through extract-text are not even used. But the symptoms are always the same - a module is replaced and called with unexpected args.
I hope it helps. Removing any of the loaders causes it to work 😕

@joaovieira thanks!

@joaovieira seems something wrong with cache, try to add cache: false to webpack.config.js and all works as expected :confused:

@joaovieira just add code for invalidate cache to https://github.com/webpack-contrib/extract-text-webpack-plugin/blob/master/src/loader.js#L51
var subCache = "subcache " + NS + " " + request; // eslint-disable-line no-path-concat
    childCompiler.plugin("compilation", function(compilation) {
      if(compilation.cache) {
        if(!compilation.cache[subCache])
          compilation.cache[subCache] = {};
        compilation.cache = compilation.cache[subCache];
      }
    });

@sentience @joaovieira and you are right, it is regression after upgrade from 2.1.2 to 3

PR https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/627

This is a webpack bug. The cache is not correctly created. webpack should handle caches for child compilers.

@sokra should we https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/627 as workaround before webpack fir this bug?

Give me a few hours and I fix it in webpack...

Awesome. Great work guys! @sokra @evilebottnawi glad I could help.


Rust chapter

Covers:

unit testing: improvements like sanitizers, mirim
property testing
gathering coverage
necessist
clippy and dylint - TODO: need expansion
model checking: Prusti and Kani tools, list of other tooling
TODO: add concurrency model checking (shuttle and loom)

PR adds static files than are linked from unit testing page. Users can click a button to be redirected to the static content.

I can't see Rust under "Languages" in the PR Preview. How to fix that?

Fixed. And how to fix that Rust hides when someone clicks on Languages?

Copied data to the doc: https://docs.google.com/document/d/1NgO-tmgrnvV4CX5RnewwWiAduVUyMg3bEOfDMRu_8HM/edit
Continuing work there


#32 Download apps to deploy

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions
Remember to set idealista:develop as base branch;

Description of the Change

Benefits

Possible Drawbacks

Applicable Issues

Could you please add this fragment to .travis.yml?
notifications:
  email:
    if: branch = master
    on_success: change
    on_failure: always
    recipients:
      -<EMAIL_ADDRESS>


DNN-21505: Upgrade page is displayed after install Evoq Engage <IP_ADDRESS>-2

Fixes DNN-21505

Need to make changes for versions

*.dnn files

solutioninfo.cs

add 09.02.20.sqlprovider

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Mohtshum sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Related to #2158, this correctly sets us up for 9.2.2 release @dnnsoftware/tag.
Without these changes (the SQL Provider file actually), Platform goes nuts and tries to perform an upgrade right after installation

hello there - can you help to expedite this review - it is blocking our 9.2.2 testing cc @ashishpd


Updated, Page border width, size, fit to width book mode, etc.

@barteksc i updated the code into your new release, tested and working.
New code gives function to add a user defined page border/marker.
Also allows custom sizes of the page border/marker.
Also some additions for book mode or horizontal swipes have been added.

I see comment in pull request, please do not create unnecessary issues


feat: only autolabel PRs if they do not already have an autolabel

The autolabelling script will now inspect whether the PR has a label that it could have applied and, if so, it will not add a label itself.

Seems reasonable, thanks!
maintainer merge

Thanks :tada:
bors merge


[QUESTION] Expected lag/delay?

Hi,
can you share the lag you experience (f any) with piccap in your configuration?
I'm currently on wifi-connected wled and I tried both hyperion and hyperhdr, either local on my TV (LG C9) and on a lan server, and I see about 0.5s, which looks like is higher than online user videos.
Attached is a sample video using the embeded youtube webos app, the delay is more or less the same regardless of the source (either internal apps or external hdmi sources in game mode).
Thanks in advance.
https://user-images.githubusercontent.com/115389/205592494-acce57f8-d6b1-4ab4-87be-c1fe79d56bc9.mp4

Hey @psychowood,
can you please show a video how it looks like in hyperion video preview?
And which resolution have you set up in PicCap?

Hello,
I also have a LG C9. I have no lag for the moment. I have not yet finished to build the final frame for the leds (still a proto with bamboo), but all the software part is done.
If it could help, here are my settings :

LG TV
Model: LG 55C9
Software: 05.20.07
Netword: ethernet

Homebrew
WebOSBrew version: 0.5.1

PicCap
PicCap version: 0.4.2
Resolution: 320x180
Max FPS: 25 (I force it to 25 when I increased the resolution)

hyperion.ng
Hyperion.Ng (TV app) version: 0.1.8
Hyperion (web interface) version: 2.0.14

Leds
LED type: APA102
Number: 158
Managed by: ESP32
Network: Wi-Fi (2.4 GHz)

All other settings are the one by default on the several apps.
I take this opportunity to thanks everyone working on this amazing project !

@Dammouz Thanks, I'll check my settings. Any filter applied on Hyperion.NG (I'm currently using HyperHDR that should be even faster)?
@TBSniller Sorry for the delay, I'll provide asap the video. Anything specific to look out for? If it is a network delay I expect to see the Hyperion leds to be in sync with the preview...

Hi. I have the same problem as you. The preview is stuttering, so it has to be piccap that doesn't send the video to hyperion.
Did a few tests with changing the resolution, but that didnt help...

Hey there,
is it possible that you guys are using 5Ghz Wifi?
You can follow this Discord thread to get to know why I'm asking: https://discord.com/channels/407937994037919756/939893245767454740

@TBSniller I can't open the link, not sure why...

Anyways, if I remember correctly my TV is connected over 5Ghz, thanks for the hint. I'll try it in a few weeks to change it to 2.4GHz when I get home.

@psychowood Oh funny
Here you go:

More or less an issue at LG


[main] Upgrade to latest dependencies

Cron. -knative-prow-robot
/cc knative/operations-wg-leads
/assign knative/operations-wg-leads
Produced via:
./hack/update-deps.sh --upgrade --release v0.23
./hack/update-codegen.sh

Details:
bumping knative.dev/serving 09f07d7...ae54012:
  > ae54012 Update net-istio nightly (# 11221)
  > 912936a Allow for more overscale in tests if the deployment is being rolled (# 11209)
  > 1b83b4b upgrade to latest dependencies (# 11217)
  > 9a5f4b8 Update net-istio nightly (# 11180)
  > 44f6033 Fix activator index update log (# 11203)
  > 40a54e3 Statically configure passthrough lb in the activator (# 11184)
  > 9054d8b Don't hardcode replica count in the Activator HA test (# 11189)
  > b6af5b6 Update net-contour nightly (# 11182)
  > ef78b9a Replace all copies of autoscaling annotations with constants (# 11213)
  > db9538d Add addressable-resolver role for serving controller (# 10693)
  > bdc0db4 use GKE 1.18 for CI until we sort out 1.19 failures (# 11206)
  > bbfa917 Set useragent for digest resolver (# 10590)
  > 935bcc8 Excluse domainmapping-webhook from chaos (# 11202)
  > 0640781 Add specific port to instruct istio to open correct listener (# 11063)
  > c50bbf8 Update net-kourier nightly (# 11191)
  > 3b198ec Fix couple of nits in scale tests (# 11204)
bumping knative.dev/pkg b51994e...b80a192:
  > b80a192 Improve state reporting in kube checks (# 2082)
bumping knative.dev/eventing fc115ae...97c0d30:
  > 97c0d30 upgrade to latest dependencies (# 5263)
  > e745733 make sure the mtchannelbasedbroker uses trigger.spec.delivery (# 5267)
  > 71153e6 Adding dataplane conformance tests for Delivery Specs for Brokers. (# 5262)
  > 92fb0f4 Do not panic prober if report fetched too early (# 5264) (# 5265)

/ok-to-test

@maximilien why are we holding this for release? How are we detecting nested breakages with that?

/unhold


Add text2data connector

Description
Add text2data connector
Fixes https://github.com/ballerina-platform/ballerina-extended-library/issues/82
One line release note:
Add text2data connector
Test Configuration:

Ballerina Version: Ballerina Swan Lake Beta 3
Operating System: Linux
Java SDK: JDK 11

Checklist:
Changes to OpenAPI definition

[X] Modified info section of the OpenAPI definition file - Example

description - what the connector is about
x-ballerina-init-description OpenAPI extension - connector initialization details
x-ballerina-display OpenAPI extension - connector name and path to the connector icon

[X] Added proper description each API Key, if API Key authentication is defined in OpenAPI definition file

Changes to connector module

[X] Added license header at the top of each .bal file.
[X] Added Package.md as per the guide here
[X] Added Module.md for the module of the  connector as per the guide here
[ ] Created a directory called resources at the root of the connector and copied the connector icon there.
Name of the icon file need to be <connector-name>.svg
[X] Added Ballerina.toml file with following information. For keywords refer to guide

Verifying connector module

[X] Compiled the connector successfully with the targeted ballerina version.
[X] Conducted smoke tests on the connector (Recommended when OpenAPI definition is obtained from an unofficial source)

Security checks

[X] Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines?
[X] Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?

Build with latest slbeta3 pack and fix CI build

Did the suggested changes.


Unable to build apk after recent framework update. tflite seems to be involved.

As the title states, I'm not able to build or run with --release flag after my last framework update. Tflite seems to be involved. The error message provided states:
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':tflite:verifyReleaseResources'.
> java.util.concurrent.ExecutionException: com.android.builder.internal.aapt.v2.Aapt2Exception: Android resource linking failed
  /Users/eduard/workspaces/flutter_projects/vitmo_model_tester/build/tflite/intermediates/res/merged/release/values/values.xml:236: error: resource android:attr/fontVariationSettings not found.
  /Users/eduard/workspaces/flutter_projects/vitmo_model_tester/build/tflite/intermediates/res/merged/release/values/values.xml:237: error: resource android:attr/ttcIndex not found.
  error: failed linking references.

I have already changed my targetSdkVersion to 28, but with no success.
$flutter doctor
[✓] Flutter (Channel beta, v1.12.13+hotfix.6, on Mac OS X 10.15.2 19C57, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 10.2)
[✓] Android Studio (version 3.5)
[✓] VS Code (version 1.41.1)
[✓] Connected device (1 available)

• No issues found!

Any help would be greatly appreciated.

@eduardkieser
Can you you please try this solution https://github.com/shaqian/flutter_realtime_detection/issues/17#issuecomment-570999128?
Thanks,
Qian

Hi @eduardkieser,
I released a new version 1.0.5 and it works on my end with Flutter v1.15.4, master channel. Can you please have a try?
Thanks,
Qian

Hi, the problem went away after addressing some other issues.
Cant remember exactly what fixed it...
E
On Mon, Apr 6, 2020, 16:10 sha<EMAIL_ADDRESS>wrote:

Hi @eduardkieser https://github.com/eduardkieser,
I released a new version 1.0.5 and it works on my end with Flutter
v1.15.4, master channel. Can you please have a try?
Thanks,
Qian
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/shaqian/flutter_tflite/issues/82#issuecomment-609818965,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQ5DCGO6ZXATKPPF6AG5DLRLHPGLANCNFSM4KD6F3XA
.


Ytc-Filter Auto Disconnect From Any SuperChat Live or Archive on Firefox 84.0.2 (64-bit)

Ytc-Filter Auto Disconnect Chat & Doesn't work on Firefox 84.0.2 (64-bit)
I don't know how to fix this but it work on Chrome Latest Version  - Is there anyway workaround to fix this?
Chat disconnected. Please wait while we try to reconnect you
Disabling the Extension make the SuperChat work - Other Translation tool work but I liked Ytc-Filter best

Which version of the extension do you have? 2.1.2?
Could you check your console to see if there is any error message please?

Which version of the extension do you have? 2.1.2?
Could you check your console to see if there is any error message please?

I was about to comment before I realized the OP mentioned using other translation tools, and I had both ytcFilter and LiveTL enabled. Disabling LiveTL got rid of the browser console errors, and I can see chat again normally after refreshing the page. I don't mind disabling it, though; I wasn't using it anyway. Leaving what I wrote before; I hope it's helpful at least in figuring out what's conflicting:

I'm having the same issue, since 2.1.0, I think. It's happening in 2.1.2 either way. Firefox is v84.0.2, 64-bit, on Manjaro Linux. Every stream or vod I open on Youtube can't successfully connect to the chat.
It manifests on the stream/vod page in the chat as just these two lines:
Chat disconnected. Please wait while we try to reconnect you.
Unable to connect to chat. Please try again later.
And the following looks to be spamming the Browser Console:
Unchecked lastError value: Error: Could not establish connection. Receiving end does not exist. 80 background.js:46
 moz-extension://d5b0cf48-4504-40cc-9237-3fe4c4bf67c0/js/background.js:46
There are also errors in the Web Console, but I'm not sure those are related. They still pop up with ytcFilter disabled.

I was about to comment before I realized the OP mentioned using other translation tools, and I had both ytcFilter and LiveTL enabled. Disabling LiveTL got rid of the browser console errors, and I can see chat again normally after refreshing the page. I don't mind disabling it, though; I wasn't using it anyway. Leaving what I wrote before; I hope it's helpful at least in figuring out what's conflicting:

I'm having the same issue, since 2.1.0, I think. It's happening in 2.1.2 either way. Firefox is v84.0.2, 64-bit, on Manjaro Linux. Every stream or vod I open on Youtube can't successfully connect to the chat.
It manifests on the stream/vod page in the chat as just these two lines:
Chat disconnected. Please wait while we try to reconnect you.
Unable to connect to chat. Please try again later.
And the following looks to be spamming the Browser Console:
Unchecked lastError value: Error: Could not establish connection. Receiving end does not exist. 80 background.js:46
 moz-extension://d5b0cf48-4504-40cc-9237-3fe4c4bf67c0/js/background.js:46
There are also errors in the Web Console, but I'm not sure those are related. They still pop up with ytcFilter disabled.

https://i.imgur.com/UEmI13b.png Yes 2.1.2 that how look the console to me.  it seem to me though the error only started to happen since 2.1.1 / 2.1.2 update - i had 2.0 before and it was fine.  with multiple stream open at same time even

https://i.imgur.com/UEmI13b.png Yes 2.1.2 that how look the console to me.  it seem to me though the error only started to happen since 2.1.1 / 2.1.2 update - i had 2.0 before and it was fine.  with multiple stream open at same time even

I was about to comment before I realized the OP mentioned using other translation tools, and I had both ytcFilter and LiveTL enabled. Disabling LiveTL got rid of the browser console errors, and I can see chat again normally after refreshing the page. I don't mind disabling it, though; I wasn't using it anyway. Leaving what I wrote before; I hope it's helpful at least in figuring out what's conflicting:

hey that fixed it - i had both i guess it conflict now? but not in chrome thank for the information.

I was about to comment before I realized the OP mentioned using other translation tools, and I had both ytcFilter and LiveTL enabled. Disabling LiveTL got rid of the browser console errors, and I can see chat again normally after refreshing the page. I don't mind disabling it, though; I wasn't using it anyway. Leaving what I wrote before; I hope it's helpful at least in figuring out what's conflicting:

hey that fixed it - i had both i guess it conflict now? but not in chrome thank for the information.

I see. I will test both extension together later and see, but it's highly possible there is conflict for the simple reason that since we both have extension which had performance issues, we may have optimizations which are not compatible together.

I see. I will test both extension together later and see, but it's highly possible there is conflict for the simple reason that since we both have extension which had performance issues, we may have optimizations which are not compatible together.

Fixed in 2.1.3

Fixed in 2.1.3


Amalgamation not working

I've been trying to integrate Wren by mean of the amalgamation file, and I've encountered two different issues.
The first being that the "optional" sources are tentatively merged in the amalgamated source but, due to the position in a sub-path, the build fails prematurely.
Even when moving the optional files from their folder to the main, the amalgamated result does not compile properly since the 'call()' function is defined twice with a different signature.
Should the optional files be moved elsewhere (or skipped during the amalgamation)?

Fixed by #541 and https://github.com/wren-lang/wren/commit/cdeb0db5c34691c1b715dd3e48e77596dd94fc58 !


Add license to OWL header

http://obo-dashboard-test.ontodev.com/ - the ontology is failing the 'open' check
the release owl should contain:
     xmlns:terms="http://purl.org/dc/terms/"
...
        <terms:license rdf:resource="https://creativecommons.org/publicdomain/zero/1.0/"/>

See https://github.com/OBOFoundry/OBOFoundry.github.io/issues/1041

Hi @cmungall -
Do you want the license for Mondo to be: https://creativecommons.org/publicdomain/zero/1.0/
?
Currently it is http://creativecommons.org/licenses/by/4.0/ in protege and noted as
CC BY 3.0 on the OBO Foundry page.
Should I change both of those to https://creativecommons.org/publicdomain/zero/1.0/

Thanks!

no stick with cc by for now, only the logic subset gets cc-0
On Thu, Dec 12, 2019 at 3:18 PM Nicole Vasilevsky<EMAIL_ADDRESS>wrote:

Hi @cmungall https://github.com/cmungall -
Do you want the license for Mondo to be:
https://creativecommons.org/publicdomain/zero/1.0/
?
Currently it is http://creativecommons.org/licenses/by/4.0/ in protege
and noted as
CC BY 3.0 on the OBO Foundry page
http://obofoundry.org/ontology/mondo.html.
Should I change both of those to
https://creativecommons.org/publicdomain/zero/1.0/
[image: image]
https://user-images.githubusercontent.com/6722114/70756826-79d6b900-1cf2-11ea-96f7-ed8aa9b126d9.png
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/monarch-initiative/mondo/issues/1031?email_source=notifications&email_token=AAAMMOLK7GX5ROU643WNKSTQYLBDFA5CNFSM4JZCDZN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGYLUBA#issuecomment-565230084,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAMMONLB6KEIVEA4WYR7YDQYLBDFANCNFSM4JZCDZNQ
.

closing, please reopen if needed


Template overlay validations are not shown

It is only shown that a template overlay validation failed for the entire template - not which overlay and what the error is. That is highly annoying :)

Fixed in https://github.com/nedap/archetype-languageserver/pull/30


Set the /build/number back to 0

Part of #147 and requires #129
We need the recipe bumper to reset the build number on a version update command.
Example:
build:
  number: 42

Should become:
build:
  number: 0

No, this is part of the primary update process, not a flag. I guess you could think of it as "by default" reset the build number to zero.

So will it go like:
crm bump-recipe update-version?

No just crm bump-recipe meta.yaml.  The default update path does not require an additional command or flag or option.

Remember that this ticket is just part of what we plan to do. In the future crm bump-recipe <file> will update the version number, the SHA-256 (if applicable), dependencies, etc.