Android: App Bundle Documentation

Platforms affected
Android
Motivation and Context
This PR is a brother PR of https://github.com/apache/cordova-android/pull/764 that adds documentation related to the new app bundle feature.
Description
Documented the new acceptable key in build.json or via command line, --packageType, which accepts a value of apk or bundle. Defaults to apk.
Testing
I ran npm serve to generate the website, and observed my changes locally.
I also ran npm test, which builds successfully with "Possible 404 in ToC" warnings. The warnings however appears in master and because they are warnings I did ignore them.
Checklist

[x] I've run the tests to see all new and existing tests pass
[x] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[x] I've updated the documentation if necessary

This PR shows that this being buried under "Signing an App" is probably not enough. Can we somehow make this more prominent? Maybe similar to https://cordova.apache.org/docs/en/latest/guide/platforms/ios/index.html#xcode-build-flags?
A link to https://developer.android.com/guide/app-bundle on the first mention of "App Bundle" would probably also be nice so that users can get some more information about it.

This PR shows that this being buried under Signing an App`is probably not enough.

I agree @janpio  I can mimic the iOS docs here. It looks like mostly an addition, however they do lack --buildFlag in the table under Using Flags... but they do have --packageType in the table. Perhaps in android docs, we will also include --packageType in the Using Flags table, but go in a bit more detail on  using apk or bundle below? Including the link to the android guide as you suggested (or should the link still be on the first mention?)

Feel free to optimize both tables and documentation in general.
The crux behind the differences is that on iOS the packageType indeed is a codesigning thing, while on Android it is a "build type" thing. So maybe we have to think again if this really was a good idea to reuse that parameter or if we are OK with that discrepancy.

It does feels right to have it in the build.json. I think it's actually nice that you can specify apk package type for debug, but have bundle package type for release. But the documentation structure makes it weird, perhaps there should be a section for building an app that mirrors the signing the app section.
For example:
building the app
...
Using build.json
[shows table flags related to build options]
signing the app
...
Using build.json
[shows table flags related to signing options...]
Then of course all my changes will be moved under the building the app section.

That might be a good idea - build.json and --buildConfig is a concept that applies to all platforms, and it seems it can be used for multiple use cases. https://cordova.apache.org/docs/en/latest/guide/platforms/ios/index.html#xcode-build-flags could also be moved into the "build" section then. We would need a more general documentation for build.json and --buildConfig then - which is useful anyway.
But maybe we should move that specific part to a new issue and PR to not add to much in here?

I think it's actually nice that you can specify apk package type for debug, but have bundle package type for release.

I agree with that, but my concern was specific to packageType having two different positions here:

on iOS the packageType indeed is a codesigning thing, while on Android it is a "build type" thing.

on iOS the packageType indeed is a codesigning thing, while on Android it is a "build type" thing.

Are you sure on that? The docs say...

This will determine what type of build is generated by Xcode. Valid options are development (the default), enterprise, ad-hoc, and app-store.

And based on the Apple docs
It just sounds like different distribution formats. Which is essentially the same as the android APK and bundle format. I don't think on iOS packageType is a codesigning thing either. Regardless of the chosen packageType they all need to be signed for distribution, and I think that applies to iOS as well.

That is not false, but also not strictly correct at the same time: For iOS the packageType defines what kind of signing credentials are used. That also decides what kind of end result you get (similar to APK vs. Bundle), but they are all .ipa files - just signed in different ways - so in this case I feel it is more limited to signing. The build that is signed is identical.

I am approving these changes on the condition that apache/cordova-android#764 is finished and merged first. Sorry for the extra noisy reviews.

I am in progress of making changes outlined back at https://github.com/apache/cordova-docs/pull/1009#issuecomment-512227371 so there will be incoming PR changes. Or are you suggesting to keep what I have currently and leave the re-organizing to another PR?

I am in progress of making changes outlined back at #1009 (comment) so there will be incoming PR changes.

I would be happy to review any further changes that you feel are needed.

Or are you suggesting to keep what I have currently and leave the re-organizing to another PR?

My vote would be to add the required info to document how the feature can be enabled from the command line or enabled by configuration. Just enough information so that someone already familiar with this AAB functionality knows how to use it.
So yes, I would favor that we “leave the re-organizing to another PR”.
Thanks again for your hard work on this functionality!

Feel free to optimize both tables and documentation in general.
The crux behind the differences is that on iOS the packageType indeed is a codesigning thing, while on Android it is a "build type" thing. So maybe we have to think again if this really was a good idea to reuse that parameter or if we are OK with that discrepancy. (ping @dpogue)

So at this point I believe this is the last major thing preventing this from moving forward. I'll add my thoughts on this...
Even though packageType is a code-signing thing for iOS, I think the metaphor still fits. It is still choosing a package or deployment strategy essentially. Yes, each packageType will all yield an ipa file, just signed differently. And depending on how the ipa file is packaged... depicts on how you can use that ipa file.
Likewise for android, following the current naming convention, they have 2 packageType options, apk and bundle. While they may produce two different files, in the end, they are still a package for deployment, just like iOS. The package could be deployed locally to the phone, or it could be uploaded to the play store. So just like iOS, I think the packageType metaphor still fits.

I would be ok with that.
To gather more feedback, you should probably send an email to the dev@ mailing list. First explain the PR in general, then mention that this is a problem that concerns were voiced about. Explain it neutrally, then add your explanation. If there are no -1 or objections, we can go ahead and merge this.

Pinging the reviewers as requested from the mailing list discussion
@dpogue
@erisu
@brodybits
@janpio


fix Fix too many repeat cause OOM

Proposed changes
Issue Number: close #xxx
Problem summary
Limit the maximum number of repeat
select repeat("a", 10000);

Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.21 seconds
load time: 643 seconds
storage size:<PHONE_NUMBER>6 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221220172516_clickbench_pr_65839.html

This pr sets the repeat count to the smaller value of count and repeat_max_num, which may cause the result to be inconsistent with the user's expectations and there is no error prompt. Why not throw an exception when count is greater than repeat_max_num?

This pr sets the repeat count to the smaller value of count and repeat_max_num, which may cause the result to be inconsistent with the user's expectations and there is no error prompt. Why not throw an exception when count is greater than repeat_max_num?

throw an exception seems to be a better solution


Can't build sdk under Visual Studio 2015 Update 1

Does anyone try to build the SDK under the VS2015 Update 1?
I faced the error "Failed to load C2(entry point not found)"

I faced the error in another develop environment， too.

Maybe I need change some default config?

@cloudmonkeypeng Can you please verify that you changed the solution platform to "x86" from "ARM" before building?

@asimonov-msft   I'm sorry for my negligence.  Thanks for your help.
It can build 55 succeeded, 1 failed now.  But our project also have one issue under Update 1.
Error 	LNK1104
cannot open file 'D:\WinObjC\build\Win32\Debug\Universal Windows\SecurityLib.Universal.lib'
Is it a known issue?


Wrong __metadata id/uri when using a combined key with string and int32

Description
Assuming one has defined a V2 entity with a combined key containing string and int32, like....
	<EntityType Name="MyEntity">
		<Key>
			<PropertyRef Name="ObjectId"/>
			<PropertyRef Name="Id"/>
			<PropertyRef Name="Version"/>
		</Key>
		<Property Name="ObjectId" Type="Edm.String" Nullable="false" MaxLength="255"/>
		<Property Name="Id" Type="Edm.Int32" Nullable="false"/>
		<Property Name="Version" Type="Edm.String" Nullable="false" MaxLength="18"/>
		<Property Name="Type" Type="Edm.String" Nullable="false" MaxLength="40"/>
		<Property Name="Sequence" Type="Edm.Int32" Nullable="true"/>
		<NavigationProperty Name="MySubEntity" Relationship="MyEntityToMySubEntity" FromRole="FromRole_MyEntityToMySubEntity" ToRole="ToRole_MyEntityToMySubEntity"/>
	</EntityType>

As far as I could see, the function addV2Metadata in dataAccess.ts converts all keys to strings with single quotes.
In the app, when accessing the UI context with path /MyEntities(ObjectId='3cd0813b921744539da05c34d72ec7fa',Id=4,Version='000002'), no data is returned as the mockserver created  the mockdata with key /MyEntities(ObjectId='3cd0813b921744539da05c34d72ec7fa',Id='4',Version='000002') (Id=4 versus Id='4').
Expected results
The __metadata id/uri should have the correct path with Id having an integer value. Maybe there is a hook to influence the mockdata creation and/or to adjust the __metadata values?

Fixed with<EMAIL_ADDRESS>


CRACKLE [PCSE00222]

App summary

App name: CRACKLE
App serial: PCSE00222
App version: 1.00

Vita3K summary

Version: v0.1.8
Build number: 3225
Commit hash: https://github.com/vita3k/vita3k/commit/2f46b479
CPU backend: Dynarmic
GPU backend: Vulkan

Test environment summary
Tested by: space1
OS: Windows 11
CPU: AMD Ryzen 5 3600
GPU: Nvidia 3070
RAM: 32 GB
Issues
Game boot but freeze with UnicornCPU error.
Screenshots

Log
vita3k_save.log
Recommended labels
Intro

This is an app not a game, closing issue


🐛 [firebase_messaging] 8.0.0-dev.14 not trigger iOS data push notifications that don't have notification.title

Bug report
Describe the bug
Right after upgraded firebase_messaging 8.0.0-dev.14 from 7.0.3, not getting iOS data push notifications that don't have notification.title; however, Android is getting the data push notifications.
Test payload and command:
FCM_SERVER_KEY=
FCM_TOKEN=
DATA="{"data": {"click_action": "FLUTTER_NOTIFICATION_CLICK", "type": "test", "senderid": "123", "sendername": "Test Script"}, "to": "${FCM_TOKEN}"}"
curl https://fcm.googleapis.com/fcm/send -H "Content-Type:application/json" -X POST -d "$DATA" -H "Authorization: key=${FCM_SERVER_KEY}"
Steps to reproduce
Steps to reproduce the behavior:

Install the Flutter app with firebase_messaging 8.0.0-dev.14 to physical iPhone device (NOT iOS Simulator)
Launch the app and monitor the logs from FirebaseMessaging.onMessage.listen((RemoteMessage message) {...}
Send the above data notification to the device
Sending the data to FCM success
ISSUE: FirebaseMessaging.onMessage.listen((RemoteMessage message) not triggered.

Expected behavior
RemoteMessage message should be delivered.

Additional context
Using firebase_messaging 7.0.3 was no problem and it was working.

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
/Users/user/flutter/bin/flutter doctor --verbose
[✓] Flutter (Channel beta, 1.24.0-10.2.pre, on Mac OS X 10.15.7 19H2 darwin-x64, locale en)
    • Flutter version 1.24.0-10.2.pre at /Users/user/flutter
    • Framework revision 022b333a08 (2 months ago), 2020-11-18 11:35:09 -0800
    • Engine revision 07c1eed46b
    • Dart version 2.12.0 (build 2.12.0-29.10.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/user/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/user/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.2, Build version 12B45b
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (3 available)
    • Android SDK built for x86 64 (mobile) • emulator-5554 • android-x64    • Android 9 (API 28) (emulator)
    • Web Server (web)                      • web-server    • web-javascript • Flutter Tools
    • Chrome (web)                          • chrome        • web-javascript • Google Chrome 88.0.4324.96

• No issues found!
Process finished with exit code 0

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.12.0-29.10.beta
Flutter SDK 1.24.0-10.2.pre
mpd 1.21.111+1210111

dependencies:
- aad_oauth 0.2.1 [flutter_webview_plugin flutter_secure_storage http shared_preferences flutter pedantic]
- archive 2.0.13 [crypto args path]
- code_input 1.0.3 [flutter]
- cupertino_icons 1.0.2
- device_info 1.0.0 [flutter device_info_platform_interface]
- encrypt 4.1.0 [args asn1lib clock collection crypto pointycastle]
- firebase_auth 0.20.0+1 [meta firebase_core firebase_core_platform_interface firebase_auth_platform_interface firebase_auth_web flutter]
- firebase_auth_oauth 0.2.4 [flutter firebase_auth firebase_auth_oauth_platform_interface firebase_auth_oauth_web firebase_core]
- firebase_core 0.7.0 [firebase_core_platform_interface flutter quiver meta firebase_core_web]
- firebase_messaging 8.0.0-dev.14 [meta flutter firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- flutter_auth_buttons 0.10.0 [flutter]
- flutter_local_notifications 3.0.3 [flutter platform flutter_local_notifications_platform_interface timezone]
- flutter_localizations 0.0.0 [flutter intl characters collection meta path typed_data vector_math]
- google_fonts 1.1.2 [flutter http path_provider crypto]
- google_sign_in 4.5.9 [google_sign_in_platform_interface flutter meta google_sign_in_web]
- graphql_flutter 3.1.0 [graphql flutter meta path path_provider rxdart connectivity gql]
- hive 1.4.4+1 [meta crypto]
- html_unescape 1.0.2
- image_picker 0.6.7+21 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- intl 0.16.1 [path]
- package_info 0.4.3+4 [flutter]
- path_provider 1.6.27 [flutter path_provider_platform_interface path_provider_macos path_provider_linux path_provider_windows]
- permission_handler 5.0.1+1 [flutter meta permission_handler_platform_interface]
- pin_code_fields 6.1.0 [flutter]
- provider 4.3.3 [collection flutter nested]
- shared_preferences 0.5.12+4 [meta flutter shared_preferences_platform_interface shared_preferences_linux shared_preferences_macos shared_preferences_web shared_preferences_windows]
- sticky_headers 0.1.8+1 [flutter meta]
- tuple 1.0.3 [quiver]
- url_launcher 5.7.10 [flutter url_launcher_platform_interface url_launcher_web url_launcher_linux url_launcher_macos url_launcher_windows]
- uuid 2.2.2 [crypto convert]

dev dependencies:
- args 1.6.0
- english_words 3.1.5 [string_scanner]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]
- mailer 3.2.1 [async logging intl mime path pedantic]
- pedantic 1.10.0-nullsafety.3
- test 1.16.0-nullsafety.17 [analyzer async boolean_selector coverage http_multi_server io js node_preamble package_config path pedantic pool shelf shelf_packages_handler shelf_static shelf_web_socket source_span stack_trace stream_channel typed_data web_socket_channel webkit_inspection_protocol yaml test_api test_core]

transitive dependencies:
- _fe_analyzer_shared 14.0.0 [meta]
- analyzer 0.41.2 [_fe_analyzer_shared args cli_util collection convert crypto glob meta package_config path pub_semver source_span watcher yaml]
- asn1lib 0.8.1
- async 2.5.0-nullsafety.3 [collection]
- boolean_selector 2.1.0-nullsafety.3 [source_span string_scanner]
- characters 1.1.0-nullsafety.5
- charcode 1.2.0-nullsafety.3
- cli_util 0.2.0 [path]
- clock 1.1.0-nullsafety.3
- collection 1.15.0-nullsafety.5
- connectivity 0.4.9+5 [flutter meta connectivity_platform_interface connectivity_macos connectivity_for_web]
- connectivity_for_web 0.3.1+4 [connectivity_platform_interface flutter_web_plugins flutter]
- connectivity_macos 0.1.0+7 [flutter]
- connectivity_platform_interface 1.0.6 [flutter meta plugin_platform_interface]
- convert 2.1.1 [charcode typed_data]
- coverage 0.15.1 [args logging package_config path source_maps stack_trace vm_service]
- crypto 2.1.5 [collection convert typed_data]
- device_info_platform_interface 1.0.1 [flutter meta plugin_platform_interface]
- fake_async 1.2.0-nullsafety.3 [clock collection]
- ffi 0.1.3
- file 5.2.1 [intl meta path]
- firebase 7.3.3 [http http_parser js]
- firebase_auth_oauth_platform_interface 0.2.2 [flutter firebase_auth firebase_core]
- firebase_auth_oauth_web 0.2.2 [flutter flutter_web_plugins firebase firebase_auth firebase_auth_oauth_platform_interface firebase_core js]
- firebase_auth_platform_interface 3.0.1 [flutter meta firebase_core plugin_platform_interface]
- firebase_auth_web 0.3.2+6 [flutter flutter_web_plugins meta http_parser intl firebase_core firebase_core_web firebase_auth_platform_interface js]
- firebase_core_platform_interface 3.0.1 [flutter meta plugin_platform_interface quiver]
- firebase_core_web 0.2.1+3 [firebase_core_platform_interface flutter flutter_web_plugins meta js]
- firebase_messaging_platform_interface 1.0.0-dev.10 [flutter meta firebase_core plugin_platform_interface]
- firebase_messaging_web 0.1.0-dev.5 [flutter flutter_web_plugins meta firebase_core firebase_core_web firebase_messaging_platform_interface js service_worker]
- flutter_local_notifications_platform_interface 2.0.0+1 [flutter plugin_platform_interface]
- flutter_plugin_android_lifecycle 1.0.11 [flutter]
- flutter_secure_storage 3.3.5 [meta flutter]
- flutter_web_plugins 0.0.0 [flutter js characters collection meta typed_data vector_math]
- flutter_webview_plugin 0.3.11 [flutter]
- glob 1.2.0 [async collection node_io path pedantic string_scanner]
- google_sign_in_platform_interface 1.1.2 [flutter meta quiver]
- google_sign_in_web 0.9.2 [google_sign_in_platform_interface flutter flutter_web_plugins meta js]
- gql 0.12.4 [source_span meta collection]
- graphql 3.1.0 [meta http mime path crypto http_parser uuid_enhanced gql rxdart websocket quiver]
- http 0.12.2 [http_parser path pedantic]
- http_multi_server 2.2.0 [async]
- http_parser 3.1.4 [charcode collection source_span string_scanner typed_data]
- image_picker_platform_interface 1.1.6 [flutter meta http plugin_platform_interface]
- io 0.3.4 [charcode meta path string_scanner]
- js 0.6.3-nullsafety.3
- logging 0.11.4
- matcher 0.12.10-nullsafety.3 [stack_trace]
- meta 1.3.0-nullsafety.6
- mime 0.9.7
- nested 0.0.4 [flutter]
- node_interop 1.2.1 [js]
- node_io 1.2.0 [file node_interop path]
- node_preamble 1.4.13
- package_config 1.9.3 [path charcode]
- path 1.8.0-nullsafety.3
- path_provider_linux 0.0.1+2 [path xdg_directories path_provider_platform_interface flutter]
- path_provider_macos 0.0.4+8 [flutter]
- path_provider_platform_interface 1.0.4 [flutter meta platform plugin_platform_interface]
- path_provider_windows 0.0.4+3 [path_provider_platform_interface meta path flutter ffi win32]
- permission_handler_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- platform 2.2.1
- plugin_platform_interface 1.0.3 [meta]
- pointycastle 2.0.1
- pool 1.5.0-nullsafety.3 [async stack_trace]
- process 3.0.13 [file intl meta path platform]
- pub_semver 1.4.4 [collection]
- quiver 2.1.5 [matcher meta]
- rxdart 0.24.1
- service_worker 0.2.4 [js]
- shared_preferences_linux 0.0.2+4 [file flutter meta path path_provider_linux shared_preferences_platform_interface]
- shared_preferences_macos 0.0.1+11 [shared_preferences_platform_interface flutter]
- shared_preferences_platform_interface 1.0.4 [meta flutter]
- shared_preferences_web 0.1.2+7 [shared_preferences_platform_interface flutter flutter_web_plugins meta]
- shared_preferences_windows 0.0.2+2 [shared_preferences_platform_interface flutter ffi file meta path path_provider_platform_interface path_provider_windows]
- shelf 0.7.9 [async collection http_parser path stack_trace stream_channel]
- shelf_packages_handler 2.0.1 [path shelf shelf_static]
- shelf_static 0.2.9+2 [convert http_parser mime path shelf]
- shelf_web_socket 0.2.3 [shelf web_socket_channel stream_channel]
- sky_engine 0.0.99
- source_map_stack_trace 2.1.0-nullsafety.4 [path stack_trace source_maps]
- source_maps 0.10.10-nullsafety.3 [source_span]
- source_span 1.8.0-nullsafety.4 [charcode collection path term_glyph]
- stack_trace 1.10.0-nullsafety.6 [path]
- stream_channel 2.1.0-nullsafety.3 [async]
- string_scanner 1.1.0-nullsafety.3 [charcode source_span]
- term_glyph 1.2.0-nullsafety.3
- test_api 0.2.19-nullsafety.6 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- test_core 0.3.12-nullsafety.15 [analyzer async args boolean_selector collection coverage glob io meta package_config path pedantic pool source_map_stack_trace source_maps source_span stack_trace stream_channel vm_service yaml matcher test_api]
- timezone 0.5.9 [path]
- typed_data 1.3.0-nullsafety.5 [collection]
- url_launcher_linux 0.0.1+4 [flutter]
- url_launcher_macos 0.0.1+9 [flutter]
- url_launcher_platform_interface 1.0.9 [flutter meta plugin_platform_interface]
- url_launcher_web 0.1.5+1 [url_launcher_platform_interface flutter flutter_web_plugins meta]
- url_launcher_windows 0.0.1+3 [flutter]
- uuid_enhanced 3.0.2 [crypto convert collection]
- vector_math 2.1.0-nullsafety.5
- vm_service 5.5.0 [meta]
- watcher 0.9.7+15 [async path pedantic]
- web_socket_channel 1.2.0 [async crypto stream_channel]
- webkit_inspection_protocol 0.7.4 [logging]
- websocket 0.0.5
- win32 1.7.4 [ffi]
- xdg_directories 0.1.2 [meta path process]
- yaml 2.2.1 [charcode collection string_scanner source_span]

Hi @nori-flutter
If you are sending through the deprecated FCM HTTP API you need to add "content_available":true to data-only messages. Also on the dev version the "click_action": "FLUTTER_NOTIFICATION_CLICK" should no longer be necessary.
On FCM v1 API this is done automatically. See https://github.com/FirebaseExtended/flutterfire/issues/4611#issuecomment-757917877 for an example of how to implement it.
Does this solve the issue for you?
Thank you

Hi markusaksli-nc,

If you are sending through the deprecated FCM HTTP API you need to add "content_available":true to data-only messages. Also on the dev version the "click_action": "FLUTTER_NOTIFICATION_CLICK" should no longer be necessary.

Not resolved, actually the HTTP API was just showing you the payload example. Actually I'm using Node.js admin SDK. The same payload is working with 7.0.3 as I described in the Bug report.
Currently I rollback to firebase_messaging 7.0.3 and everything working fine.

Ah I am actually seeing this as well with admin sdk only when using sendToDevice. Based on what is in the response body it looks like it's still going through the deprecated API but it still checks the message based on the v1 API format so you can't even add content_available.
However it works just fine for me sending with send()
const message = {
    "token":token,
    "data": {
        "index": "1"
    }
}

async function sendWithAdminToDevice() {
    await admin.initializeApp({
        credential: admin.credential.applicationDefault(),
    });
    let response = await admin.messaging().sendToDevice(token, {"data":message.data}).catch((error) => console.log("Error sending message:", error))
    console.log("Successfully sent message:", response)
}

flutter: Handling a background message<PHONE_NUMBER>605605

It could be that it works on the previous version because on the new one I'm pretty sure messages are only received through APS but previously there was some legacy FCM channel as well.
Could you try just the send() method?
Either way this seems like this issue should be filed in the Node.JS Admin SDK

Thank you for your quick reply, @markusaksli-nc
Yes, "admin.messaging().send(message)" method works with firebase_messaging 8.0.0-dev.14 on iOS.
let message: any = {
    data: {
      type: "test",
      click_action: "FLUTTER_NOTIFICATION_CLICK",
      senderid: '123',
      sendername: 'Test Script'
    },
    token: fcmToken
};
admin.messaging().send(message)
.then(function(response: any) {
  console.log('Successfully sent message:', response);
})
.catch(function(error: any) {
  console.log('Error sending message:', error);
});

I still need to test more cases but it's working so far.
Thanks!


Geodata Analysis

Some minor things to add to the GIS-View:
Importing Geodata

[x] Preview (e.g. csv) should only show first 10 or so rows
[x] In case a user has a file (csv) without a header row the header should be set to 0 (while 1 is the default). In that case the cols should be names like Var1 ... Var#

Analysis of Geodata

[x] Geodata should be styled (color and shape) according to attributes
[x] Label should be added and editable (font, color, background)
[ ] (Piechart overlay like in QGIS)

This is currently in development for the new vue version. Any testing/feedback is much appreciated.

Most of the individual parts have been fixed/added in the 0.7 giza release. Further development will be moved to the next release (helgö).

👍


Upgrade to the latest react-docgen

The latest version of react-docgen supports React stateless components, it would be really nice if they was also supported by react-styleguidist:
https://github.com/reactjs/react-docgen/commits/v2.4.0
I tested the new version on our style guide and it works great.

Thanks, I’ll do that. Pull request would be even better ;-)

I'll do that :-)


pull request for e2e test at 01/16/2017 13:15:08

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


SuSo-I-004: Integration Tests

As a developer I can not ensure the correctness of my application with unit tests alone.
Introduce/extend integration tests to ensure the correctness of

different components interacting with each other
interaction betwen components and state
reaction of components to input changes

Sufficiently implemented for now with the changes made in

https://github.com/julia-jordan-712/sudoku-solver-angular/pull/48
https://github.com/julia-jordan-712/sudoku-solver-angular/pull/47/commits/3d0ff557cb88ca7b6fe34280dfd73799c1bbefbd#diff-35adc96dd6e54a1949eb80fc6ab33f95779a013af56bf5defe424a67dcc22f13
https://github.com/julia-jordan-712/sudoku-solver-angular/pull/47/commits/27ad68bbc094218a9b79796e6ac91db070182d18#diff-f57117ff18f23dbf4a97f32360978bfe6a08366639c01904372ee190d4327e5f


Random::System should be a module

Followup to #4450
The recently added Random::System takes bytes from some source provided by the system. I suggested previously that it should be a module, not a struct without members.
I think this emphasizes the fact that by definition Random::System cannot have state associated with it, makes it more convenient to use and showcases Crystal's powerful type system. Random::System would be possible to use as if it's an instance of Random in all cases (you really just drop the .new part), without needing to create these fake instances -- makes no sense to keep one and makes no sense to create one every time.
module Random::System
  extend Random
...

Random::System.is_a? Random
Random::DEFAULT.is_a? Random

I feel that this suggestion has been drowned out by unrelated discussion so I want to make a dedicated issue for it.

You're right. Another argument I could add is that on some UNIX each instance will open dev/urandom and thus consume a file descriptor. We could use a class var instead of an instance var, but using Random::System directly seems a better solution.


SSR: Fix path resolution of locals in current scope

Two commits. The first is a refactoring to move some code. The second is a workaround for the behavior of Semantics::scope and scope's resolve_hir_path with regard to locals that were defined in the current scope. Not sure if changing the behavior of resolve_hir_path is practical / possible / desirable.
To check in which nodes,  I was able to resolve a path, I used the following code:
#[test]
fn delete_me() {
    use hir::Semantics;
    use ra_db::Upcast;
    use ra_syntax::ast;
    use ra_syntax::ast::AstNode;

    let code = r#"
        fn main() {
            let mut foo = 42 + 1;
            foo += 2;
                loop {
                    let x = 10;
                    if foo > x {
                        break;
                    }
                }
            {
                let x = 10;
                foo += x;
            }
            let bar = 10 + 1;
            foo += 2;
        }
        "#;
    let (db, position) = single_file(code);
    let sema = Semantics::new(&db);
    let file = sema.parse(position.file_id);

    let path = ast::Path::parse("foo").unwrap();
    let hygiene = hir::Hygiene::new(db.upcast(), position.file_id.into());
    let h_path = hir::Path::from_src(path, &hygiene).unwrap();

    let mut indent = 0;
    for e in file.syntax().preorder() {
        match e {
            ra_syntax::WalkEvent::Enter(n) => {
                let scope = sema.scope(&n);
                if let Some(_) = scope.resolve_hir_path(&h_path) {
                    println!("{}O: {:?}", " ".repeat(indent), n);
                } else {
                    println!("{}X: {:?}", " ".repeat(indent), n);
                }
                indent += 2;
            }
            ra_syntax::WalkEvent::Leave(_) => {
                indent -= 2;
            }
        }
    }
}

This produced the following output:
X<EMAIL_ADDRESS>  X<EMAIL_ADDRESS>    X<EMAIL_ADDRESS>    X<EMAIL_ADDRESS>    X<EMAIL_ADDRESS>      X<EMAIL_ADDRESS>        X<EMAIL_ADDRESS>          X<EMAIL_ADDRESS>        X<EMAIL_ADDRESS>          X<EMAIL_ADDRESS>          X<EMAIL_ADDRESS>      X<EMAIL_ADDRESS>        O<EMAIL_ADDRESS>          O<EMAIL_ADDRESS>            O<EMAIL_ADDRESS>              O<EMAIL_ADDRESS>                O<EMAIL_ADDRESS>          O<EMAIL_ADDRESS>      X<EMAIL_ADDRESS>        O<EMAIL_ADDRESS>          O<EMAIL_ADDRESS>            O<EMAIL_ADDRESS>              O<EMAIL_ADDRESS>                O<EMAIL_ADDRESS>              O<EMAIL_ADDRESS>            O<EMAIL_ADDRESS>              O<EMAIL_ADDRESS>                O<EMAIL_ADDRESS>                  O<EMAIL_ADDRESS>                    O<EMAIL_ADDRESS>                      O<EMAIL_ADDRESS>                        O<EMAIL_ADDRESS>                  O<EMAIL_ADDRESS>                    O<EMAIL_ADDRESS>                      O<EMAIL_ADDRESS>                        O<EMAIL_ADDRESS>              O<EMAIL_ADDRESS>                O<EMAIL_ADDRESS>                  O<EMAIL_ADDRESS>      X<EMAIL_ADDRESS>        O<EMAIL_ADDRESS>          O<EMAIL_ADDRESS>            O<EMAIL_ADDRESS>              O<EMAIL_ADDRESS>            O<EMAIL_ADDRESS>          O<EMAIL_ADDRESS>            O<EMAIL_ADDRESS>              O<EMAIL_ADDRESS>                O<EMAIL_ADDRESS>                  O<EMAIL_ADDRESS>                    O<EMAIL_ADDRESS>              O<EMAIL_ADDRESS>                O<EMAIL_ADDRESS>                  O<EMAIL_ADDRESS>                    O<EMAIL_ADDRESS>      X<EMAIL_ADDRESS>        X<EMAIL_ADDRESS>          X<EMAIL_ADDRESS>        O<EMAIL_ADDRESS>          O<EMAIL_ADDRESS>          O<EMAIL_ADDRESS>      X<EMAIL_ADDRESS>        O<EMAIL_ADDRESS>          O<EMAIL_ADDRESS>            O<EMAIL_ADDRESS>              O<EMAIL_ADDRESS>                O<EMAIL_ADDRESS>          O<EMAIL_ADDRESS>
So I concluded that it appears to be statements where I can't resolve locals - however statements in inner scopes are fine. It's just the statements in the scope where the variable was defined from which I can't resolve the name.

Yeah, the model for local scopes is not good at the moment. We do similar hacks during completion, and there are also broken:
https://github.com/rust-analyzer/rust-analyzer/blob/401a9c25151c1b659b8e80e2ffe70fa96a1f8ef1/crates/ra_hir/src/source_analyzer.rs#L413-L451
(specfically, for fn main() { let x = 92; }) there's simply no scope with x in it.
You i think is hitting a more specific problem -- we can only determine local scopes for ast::Expr, so, if you feed ast::Stmt into it, you'll get scope for parent expression.
bors r+


Adding function to read int8

Hello @chafey
I added a commit, to parse with the option exclude, that goes with untilTag.


feat: implement DatePicker Step 2 - yearCalendar

Context
In this pull request, I continue to finish the DatePicker's step 2, year Calendar
because our Aha styled year calendar use pagination to change year page, instead of using scroll like MUI-X,
we need to create our own customized Year Calendar to do this
Changes

customized ui
add customized PickersArrowSwitcher (which is the header of calendar, include arrow and label like  " < June, 2023 > " )

Screenshot
https://github.com/benqqqq/aha-fe-assignment/assets/11547758/ecb4aca7-b961-4b84-bbb9-dad42638f1c9

Codecov Report

Merging #5 (176ecd5) into main (ab2f939) will decrease coverage by 4.55%.
The diff coverage is 90.90%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##              main       #5      +/-   ##
===========================================
- Coverage   100.00%   95.45%   -4.55%
===========================================
  Files            6        7       +1
  Lines           22       44      +22
  Branches         2        7       +5
===========================================
+ Hits            22       42      +20
- Misses           0        2       +2

Impacted Files
Coverage Δ

src/components/AhaDatePicker/utils.ts
90.90% <90.90%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Enable the Information Schema Connector to load data lazily

cc: @wagnermarkd @findepi @electrum
The current implementation of the Information Schema Connector preloads all the data from underlying connectors and then builds a ConnectorPageSource.
A better approach is to make it lazily build Pages on the fly.

This approach benefits queries with a limit clause, e.g., select * from hive.information_schema.columns limit 1.
In addition, it decreases latency of the first query result.
Finally, for queries touching a lot of tables (e.g., select * from hive.information_schema.columns), it's possible that some (Hive) tables have invalid metadata, which eventually fails the query. The new approach passes Pages to downstream operators as soon as they are ready. In this way, failures can be detected sooner.

This issue is a follow-up of #998

I implemented a basic version of "lazy" InformationSchemaPageSource and InformationSchemaPageSourceProvider but found the benefits mentioned above didn't show up.
It turns out InformationSchemaMetadata::getPrefixes is also a bottleneck which prevents the first query result to be returned in a low latency.
Please LMK if anyone has a comment.

I was waiting for this patch so that we could modify it to solve this issue too (https://github.com/prestosql/presto/issues/631#issuecomment-486621503)


SyntaxError: Use of const in strict mode.

IM TRYING TO GET THE HASH OF MY CSGO WEBSITE BUT THIS STILL DONT WORKING HOW CAN I FIX THAT:
SyntaxError: Use of const in strict mode.
at Module._compile (module.js:439:25)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Server.init (/var/www/html/Bot/BOT/node_modules/socket.io/node_modules/engine.io/lib/server.js:119:16)
at new Server (/var/www/html/Bot/BOT/node_modules/socket.io/node_modules/engine.io/lib/server.js:65:8)
at Function.attach (/var/www/html/Bot/BOT/node_modules/socket.io/node_modules/engine.io/lib/engine.io.js:123:16)
at /var/www/html/Bot/BOT/node_modules/socket.io/lib/index.js:258:23

Thanks for reporting this issue. However, you didn't provide sufficient information for us to understand and reproduce the problem. Please check out our submission guidelines to understand why we can't act on issues that are lacking important information.
If the problem persists, please file a new issue and ensure you provide all of the required information when filling out the issue template.


Several deprecated packages

I see that there are several deprecated packages in the current https://github.com/erikras/react-redux-universal-hot-example/commit/d89cbbe3f15ba79c1e13a4fa0b305f2011c2ebfa repo. Are there plans to change to less deprecated versions? Thanks.
bash-3.2$ npm install
npm WARN deprecated<EMAIL_ADDRESS>Please use postcss-loader instead of autoprefixer-loader
npm WARN deprecated<EMAIL_ADDRESS>Replaced by bootstrap-loader. Please upgrade.
npm WARN deprecated<EMAIL_ADDRESS>Deprecated.
npm WARN deprecated<EMAIL_ADDRESS>graceful-fs version 3 and before will fail on newer node releases. Please update to<EMAIL_ADDRESS>as soon as possible.
npm WARN deprecated<EMAIL_ADDRESS>this package has been reintegrated into npm and is now out of date with respect to npm
npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained. Upgrade to<EMAIL_ADDRESS>npm WARN deprecated<EMAIL_ADDRESS>graceful-fs version 3 and before will fail on newer node releases. Please update to<EMAIL_ADDRESS>as soon as possible.
npm WARN deprecated<EMAIL_ADDRESS>this package has been reintegrated into npm and is now out of date with respect to npm
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g

Update: I know that<EMAIL_ADDRESS>(required by<EMAIL_ADDRESS>pulls in<EMAIL_ADDRESS>and<EMAIL_ADDRESS>There's an issue filed at https://github.com/shama/gaze/issues/212
Update<EMAIL_ADDRESS>(latest) requires<EMAIL_ADDRESS>which requires a deprecated version of graceful-fs as well. Looks like there's a regression problem with upgrading mocha's glob https://github.com/mochajs/mocha/issues/2121
But what are the plans for the other packages that generate warnings including:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Many thanks!

+1. any warning is annoying.
@erikras

+1 also. I know there are some PRs out to migrate away from bootstrap-sass-loader and I think also autoprefixer-loader, which should take care of those. The only ones I haven't managed to get rid of myself are the npmconf, lodash and graceful-fs.

Partially fixed. www.github.com/shama/gaze updated to version 1.0.0. Updating the package.json to this version and re-running npm install gets a couple of these warnings.

this PR fixes the autoprefixer-loader warning https://github.com/erikras/react-redux-universal-hot-example/pull/939

+1 also

Waiting, you can try my fork here: https://github.com/bertho-zero/react-redux-universal-hot-example/


underscores in email addresses are not rendered correctly

With these settings:
opts = {
  filter_html: true,
  safe_links_only: false
}
renderer = Redcarpet::Render::HTML.new(opts)
extensions = {
  autolink: true
}
@markdown_renderer = Redcarpet::Markdown.new(renderer, extensions)

I'm trying to render this:
<EMAIL_ADDRESS>
But it gets rendered as:
xb<a href="mailto:and_c<EMAIL_ADDRESS>
I've also tried these in markdown:
<EMAIL_ADDRESS>
[x_b_and_c<EMAIL_ADDRESS>
<EMAIL_ADDRESS>
<EMAIL_ADDRESS>
None of them seem to produce the right output, which should be this:
<a href="mailto:x_b_and_c<EMAIL_ADDRESS>

Hi @mehulkar,
Yep, this is a known bug (#402), I didn't look in depth at it but I hope to be able to soon. Waiting this to be resolved, you can enable the :no_intra_emphasis option on your Redcarpet::Markdown object as a turnaround.
Thanks for reporting anyway ! :-)

ah got it, thanks @robin850!


resolveAll(T) when resolving Vector.

Injecting a property of type Vector. should populate it will the results of resolveAll(T).

Added a test for resolving a class with a Vector. constructor parameter. It also injects a Vector containing the results of resolveAll(T).


Upgrade Protobuf

I currently cannot use Mediapipe together with OR-Tools, because both have different Protobuf constraints. In particular, Mediapipe still requires protobuf <4. I think this should really be updated.

What platform are you concerned about? I assume this is Android?

I have the same issue. I am forced to keep a specific version of python to keep working with or-tools and mediapipe.


Complete translation: Swedish

Provide the two-letter code of the existing language
sv
Provide the lines, that are still English and should be translated

32-33
40-41
44
46-47
81-82
85-86
93-94
97
100-101
104-105

Steps to complete the translation

Open the corresponding file, public/_locales/sv/messages.json
Translate all values of the given lines, that still have an English translation and create a pull request

@FrejBjornsson Would you like to update the Simplified Chinese translation again? That would be awesome!

If you mean the Swedish translation I'd be happy to help! @devmount

Sorry, copy and paste 🙈😅 Yes I meant Swedish! Thanks so much! 👏🏻

I created a PR. Tell me if you need anything else or if something is missing.  👍


BVH - prevent self collisions

I had missed a special case check for userdata of two colliding objects being equal. In this case, collisions should not be reported. This is used in the physics to prevent self intersection in composite objects.
Fixes #47476

Thanks!


ClassCastException while reading JSON.

Hey. I am saving and reading a json in a book.
If I read the json back from the book directly it shows a ClassCastException for String to JSONObject
JSONObject userModelJson = Paper.book(BaseConstants.SESSION_BOOK)
                    .read(BaseConstants.SESSION_START_USER_MODEL);

but if I read it as a String and then convert it to JSON using JSONObject API, it succeeds.
String userModelString = Paper.book(BaseConstants.SESSION_BOOK)
                    .read(BaseConstants.SESSION_START_USER_MODEL);

JSONObject userModelJson = new JSONObject(userModelString);

Sample Json

{
  "address": [
    {
      "address": "full address here",
      "latitude": "0.0",
      "longitude": "0.0"
    }
  ],
  "email"<EMAIL_ADDRESS>  "name": "Sample",
  "phone": "1231231230",
  "username": "sampleuser"
}

Could you show more code how do you save data? Do you save JSONObject directly?

I am converting the incoming model (using Retrofit 1.9) to json and saving it. This is done after a null check.
Paper.book(BaseConstants.SESSION_BOOK).write(BaseConstants.SESSION_START_USER_MODEL,
              new Gson().toJson(userModel, UserModel.class));

The {a[er is designed to operate with model classes directly using much more efficient syrialization then json. You should try something like ```
Paper.book(BaseConstants.SESSION_BOOK).write(BaseConstants.SESSION_START_USER_MODEL,
userModel);

And do read userModel instance directly.

Ok. Will try this and report.

No issues yet. Closing.


chore: remove console due to potential risk

Summary
[Removed  Console Regarding  the Potential Risk?]
Key Changes

[List the changes to look for in this PR]

Check List

[x] The changes to the "Readme" file(if needed)
[x] The changes not break any old rule of the library or usage

@KarimMokhtar  Is this Purposely kept? we can  make a new prop to remove all the dev things

Could you please just change the commit msg to be semantic because the pipeline is failing?

Updated Commit Message

Can you publish this to NPM as a new version please?
The console statement is still present in v2.3.4.

Hi @tehroot . It will be published this weekend. Thanks for your interest.

Thanks for the update!

@tehroot @saitharunsai  Hello guys, Thanks for your contributions.
Now it's published on v.2.3.5 please check.


Merge master to live

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/NuGet/docs.microsoft.com-nuget, working directory: W:\zzek-s, target branch: live, target branch commit: b23333282023368161a5241ed6ded2c79a14b6e5, source branch: master, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/API/package-base-address-resource.md
:white_check_mark:Succeeded

docs/API/registration-base-url-resource.md
:white_check_mark:Succeeded

docs/Consume-Packages/Configuring-NuGet-Behavior.md
:white_check_mark:Succeeded

docs/Consume-Packages/Dependency-Resolution.md
:white_check_mark:Succeeded

docs/Consume-Packages/Overview-and-Workflow.md
:white_check_mark:Succeeded

docs/Consume-Packages/Package-restore-troubleshooting.md
:white_check_mark:Succeeded

docs/Create-Packages/Creating-a-Package.md
:white_check_mark:Succeeded

docs/Create-Packages/Overview-and-Workflow.md
:white_check_mark:Succeeded

docs/Create-Packages/Publish-a-package.md
:white_check_mark:Succeeded

docs/Guides/Install-NuGet.md
:white_check_mark:Succeeded

docs/Hosting-Packages/Overview.md
:white_check_mark:Succeeded

docs/Policies/NuGet-FAQ.md
:white_check_mark:Succeeded

docs/Quickstart/Create-and-Publish-a-Package.md
:white_check_mark:Succeeded

docs/Quickstart/Use-a-Package.md
:white_check_mark:Succeeded

docs/Reference/Errors-and-Warnings.md
:white_check_mark:Succeeded

docs/Schema/nuget-config-file.md
:white_check_mark:Succeeded

docs/Schema/nuspec.md
:white_check_mark:Succeeded

docs/Schema/project-json.md
:white_check_mark:Succeeded

docs/Tools/Package-Manager-Console.md
:white_check_mark:Succeeded

docs/Tools/Package-Manager-UI.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-delete.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-install.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-push.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-restore.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-update.md
:white_check_mark:Succeeded

docs/Visual-Studio-Extensibility/NuGet-API-in-Visual-Studio.md
:white_check_mark:Succeeded

docs/includes/install-methods.md
:white_check_mark:Succeeded

docs/index.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Aurelius] Add Converters from Model Object to Complete PFA Doc

Currently, models generated with Aurelius cannot be converted directly from their state as an object into a valid PFA document. Is it possible to add S3 wrapper methods for model object types (e.g. glm, lm, etc.) that convert these models directly to a completely valid PFA document? This would decrease time in having to construct these simple models by hand from their object components as done in the tutorial:
https://github.com/opendatagroup/hadrian/wiki/Aurelius-glm

If you know how to do it--- i.e. how to extract the relevant parameters from the S3 objects--- then you know how to expand this function. If you can do that, please make a pull request.
...
You're faster than I am. You just submitted a pull request. I think it should be accepted, but someone from ODG will have to do it.

@jpivarski Thanks Jim! That sounds good. I started using PFA more from R and I think some wrapper functions plus documentation would make it easier for R users to adopt.


CI: Fix random crash when fetching tarball

An attempt at solving errors like https://github.com/opencollective/opencollective-frontend/pull/3307/checks?check_run_id=387207818
Full response from curl looks like:

HTTP/1.1 200 OK
Access-Control-Allow-Origin: https://render.githubusercontent.com
Content-Security-Policy: default-src 'none'; style-src 'unsafe-inline'; sandbox
Strict-Transport-Security: max-age=31536000
Vary: Authorization,Accept-Encoding
X-Content-Type-Options: nosniff
X-Frame-Options: deny
X-XSS-Protection: 1; mode=block
ETag: W/"0f71066f61b7a7cb87e59bf5f421130cd48e51131c3a627d075215be6feefe95"
Content-Type: application/x-gzip

OR

HTTP/1.1 404 Not Found
Content-Length: 15
Access-Control-Allow-Origin: https://render.githubusercontent.com
Content-Security-Policy: default-src 'none'; style-src 'unsafe-inline'; sandbox
Strict-Transport-Security: max-age=31536000
Vary: Authorization,Accept-Encoding
X-Content-Type-Options: nosniff
X-Frame-Options: deny
X-XSS-Protection: 1; mode=block
Date: Mon, 13 Jan 2020 16:11:18 GMT
X-Varnish:<PHONE_NUMBER>
Age: 0
Via: 1.1 varnish-v4
X-GitHub-Request-Id: C0FC:179A:83E84:14ED7C:5E1C96A6

Previous code could fail to detect a missing branch if the request ID or timecodes somehow included a 200.

@znarf both issues may exist, I'm sure this one was real:

@Betree good to know, I thought this was just a blind assumption!


CSLC-S1 Gamma Acceptance Testing

The "gamma" delivery of the CSLC-S1 SAS was made on 3/25/23. This ticket is to track the corresponding acceptance testing activities and wiki page creation.

Acceptance test has passed and wiki page is available here: https://github.com/nasa/opera-sds-pge/wiki/CSLC-S1-Gamma-Acceptance-Testing-Instructions


Add LogExpFunctions package extension

Closes #171.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 26.66667% with 22 lines in your changes missing coverage. Please review.

Project coverage is 36.27%. Comparing base (61efc9a) to head (4b33180).

Files with missing lines
Patch %
Lines

test/ext/test_LogExpFunctions.jl
0.00%
14 Missing :warning:

test/classification.jl
0.00%
4 Missing :warning:

ext/SparseConnectivityTracerLogExpFunctionsExt.jl
72.72%
3 Missing :warning:

test/runtests.jl
0.00%
1 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (61efc9a) and HEAD (4b33180). Click for more details.
HEAD has 3 uploads less than BASE

Flag
BASE (61efc9a)
HEAD (4b33180)

4
1

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #184       +/-   ##
===========================================
- Coverage   90.44%   36.27%   -54.17%
===========================================
  Files          44       45        +1
  Lines        2041     1789      -252
===========================================
- Hits         1846      649     -1197
- Misses        195     1140      +945

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Export filesystem provider and bump version

Makes sense. I actually started publishing bumped versions externally while testing, and it's already at 0.1.4 😅.
I started testing locally with yarn link, but I'm still having some issues getting the changes picked up in some projects, and in particular, some github actions.
I'm going to close out this PR and open a new one with more changes. I'm also thinking that I'll publish with an alpha pre-release tag so that I can test more freely with published packages.


[Refactor] Fix clang-format-11 compatible with clang-format-10.3

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

clang-format-11 has some different behavior from clang-format-10.3 which StarRocks CI/CD environment uses by default, so it is very inconvenient for developers who have only clang-format-11 in their development environment.
So in this CL, I refactored the code to make both clang-format-11 and clang-format-10.3 will generate the same result. The key changes include:

add AllowShortFunctionsOnASingleLine: Inline in clang-format configuration to tell clang-format what we need actually. Actually, this is not necessary for clang-format-11, but it is useful for higher version clang-format, so I kept this change.
Disable clang-format for ASM code. I don't know which clang-format option can control the behavior.
Add brackets to two continuous ternary operators, which make clang-format-11 generate the same result as the older one.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

run starrocks_admit_test


Performance problem with images with inline base64 data

Description:
I'm using multiple divs where only one of them is visible at a time. Each div is holding an image. Pseudocode is something like:
<tab index="1" />
<tab index="2" />
<tab index="3" />

Images are displayed correctly upon each tab button press, but when I use a large image (400 kB?) it takes seconds to switch to the target div. CPU hits %100 while switching.
Is it something expected? Shouldn't I use inline data for images?
Or is it something unexpected and I should provide a reproduction code?
Versions affected:
0.9.3

400k is pretty huge for an attribute like that. I haven't ever tried it, but does plain DOM do any better? I'll poke at it when I get a little free time.
I would expect the best thing to do with that sort of thing would be to create a blob url and shuffle that in and out of the img src.

window.URL.createObjectURL() is what I was looking for. Thanks @evs-chris !


Completion builder prefers regular completions over built ones and activates them in lambda parameters

VS 17.11.0 P2.1
Completion session controller should select the built completion when naming variables (in this case lambda expression parameter name), instead of matching the existing symbols or regular completions provided.
This makes writing lambda expressions quite frustrating, because every time it completes the name I try to assign to a completion from the list.
https://github.com/dotnet/razor/assets/9047283/4ccebacf-33a8-46c9-ad28-bba30c7d5208
@code {
    protected override void OnInitialized()
    {
        int[] numbers = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10];
        var even = numbers.Where(n$$);
        base.OnInitialized();
    }
}

Interestingly it seems to also happen in csharp files

@alexgav is this something we should move over to dotnet/roslyn?

I believe the main difficulty @Peter-Juhasz  is having is not so much that the "standard" completion items are present in the completion list, but the fact that they are selected via "hard" (as opposed to "soft" :) ) selection in LSP. That causes them to be completed when space is typed. As @ryzngard said it reproes in plain C# files if I enabled LSP C#/VB editor (which is what Razor uses). In "old" C# editor (default for standalone C# files) actually uses soft selection in this case and won't commit selected item. E.g. if you type "n" in Razor and LSP C#, you get "nameof" completed, even if you actually want to do something like "n => n > 3".
In the old (current C#) editor, even though nameof gets soft selected, it is not completed when space is pressed, so instead of ending up with Where(nameof ) you actually get Where(n )
I agree though, this should go to Roslyn. @ToddGrun and @genlu .


Format new code with clang-format

Signed-off-by: Stefan Weil<EMAIL_ADDRESS>

Format new code with clang-format

What about old code?

src/api/wordstrboxrenderer.cpp was added recently, so there is no old code.

I meant what about other files?

The new code got my attention because of the latest report from Coverity Scan.
But you are right, the old code needs formatting, too.

@stweil: do you plan to fix issues from Coverity Scan?

Not at the moment. I am still waiting for feedback from @Shreeshrii (see question above).

@stweil I hadn't recd the earlier msg with the review. Please feel free to change the code. Thanks.


no way to configure tsc --project tsconfig.json to preserve folders without .ts files in the output

TypeScript Version:  2.1.4
Code
./tsconfig.json:
{
  "compilerOptions": {
    "module": "amd",
    "moduleResolution": "classic",
    "target": "es5",
    "baseUrl": ".",
    "paths": {"*": ["*"]},
    "outDir": "../compiled"
  },
  "compileOnSave": false
}

./modules/asdf.ts:
export let animal = "gorilla";
export let food = "banana";

Expected behavior:
tsc --project tsconfig.json results in ../compiled being generated, containing modules/asdf.js.  OR, at the least, there is some way to change tsconfig.json to result in this.
Actual behavior:
unless there is another typescript file in the current directory, the modules directory is omitted from the outDir - ../compiled contains just asdf.js.
Why would I want this, you might ask?  I'm experimenting with using different tsconfig.json files to build some subsets of my code, without using --noResolve because I do want the compiler to discover dependencies.  This current behavior, of shortening the output tree by any folders without typescript files that are being used by the current compilation, means that adding an extra dependency to a file could change the resolved set of files and result in the folder structure of the output directory changing (in a non-additive way), which is not desirable.

More details can be found at https://github.com/Microsoft/TypeScript/wiki/FAQ#why-does---outdir-moves-output-after-adding-a-new-file

oh hey, that does exactly what I want!
I guess I wasn't reading quite the right sources - https://www.typescriptlang.org/docs/handbook/tsconfig-json.html doesn't mention it.  Guess I should have found it within https://www.typescriptlang.org/docs/handbook/compiler-options.html


Use Cocoapods to manage nanopb

Per Firebase request, we move dependency of nanopb from maintaining a copy of nanopb code to using Cocoapods.
cc: @nicolasnoble

@jcanizales - what is the story of this TODO? gRPC is using a bunch of submodules so we cannot remove the :submodules => true anyway, is it?

Test failures:
Basic Tests Windows (internal CI) - #11383
gRPC_interop_pull_requests - Jenkins issue; all tests passed


Add event format

Coverage increased (+0.2%) to 77.473% when pulling 83f94d5c2d4ca28d14361c064baf3700434bf5ba on feature/add-event-format into dbfe8928091d660f83ce62e559aa0d65cc0ca157 on master.

Coverage increased (+0.3%) to 77.575% when pulling 723e43e41750043b3ffdece450afc708e96b55e0 on feature/add-event-format into dbfe8928091d660f83ce62e559aa0d65cc0ca157 on master.

Coverage increased (+0.3%) to 77.604% when pulling d115f0d0c8eb869531865f9bad190d7177d61cc7 on feature/add-event-format into dbfe8928091d660f83ce62e559aa0d65cc0ca157 on master.


Android sdkmanager tool was found, but failed to run

I'm trying to use flutter on Android Studio. I have the flutter plugin installed on Android Studio and when i try to create a new flutter project it behaves normally, in the sense of it lets me write the project name, the flutter sdk path and so on. But when i click on finish absolutely nothing happens. I just see the Android Studio Welcome page where i can create new Projects. So i figured I'd see what flutter doctor -v has to say about it and it gives me these errors:

So i try to find a solution by typing : flutter doctor --android-licenses but i get another error:

And yes i have set the PATH variable and i have installed Android SDK Tools.
I went to the file specified that fails to run and tried to run it myself by clicking on it but i get the error:

I tried everything but nothing seems to do the job.
Any help would be appreciated.

possibly related to
https://github.com/flutter/flutter/issues/51712
https://github.com/flutter/flutter/issues/31116

I just reset my whole PC. It worked. Do that as a last resort. But i have tried everything. I must’ve screwed up the path variables In a way.


Change pet header for all pages

Need to change header for all pages to be able to display the name of the pet and the age

Fixed


Add Picture Puzzle Game

I would like to add a simple drag-and-drop picture puzzle game made using HTML,CSS & JS to the repo.
A demo is attached as below.Please assign me this under GSSoC'22
https://user-images.githubusercontent.com/95405559/164966040-9775f7a6-3507-4d3d-8dcc-e39028bf7c7c.mp4

Already we have


File size unavalaible

I saw in the README that you could access file name, file mimetype, but not file size? Why is that?
I'm using multer, which is based on busboy, and I can't access file size because busboy can't give it, that's why I'm opening this issue.
Thanks in advance!

That's just the nature of multipart/* content: all fields are separated by a unique string of characters and not by their lengths. This format allows you to stream data without knowing the total size up front.
Regarding file sizes, you can count the bytes yourself as the data streams in to find the total size and if you want to limit the max file size, you can do that too.


perf(docs): restore alaska.md file

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Summary:
Restore deleted file.
Type of change:
Please delete options that are not relevant.

[ ] New capability
[ ] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[x] Other (Docs)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 4.2.8 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


operators [N] [CI] dynatrace-operator (0.5.0)

Signed-off-by: Michael Rynkiewicz<EMAIL_ADDRESS>Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions

[x] Are you familiar with our contribution guidelines?
[x] Have you packaged and deployed your Operator for Operator Framework?

[x] Is your submission signed?
[x] Is operator icon set?

Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[x] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/merge possible

/retest

/rerun

/merge possible

/rerun

/retest

/test 4.10-deploy-operator-on-openshift

/test 4.10-deploy-operator-on-openshift

/merge possible

/merge

@J0zi @mvalarh, please merge

/merge possible


Parse error with space in global CSS rule

Migrated from here: https://github.com/Grimones/vscode-styled-jsx-languageserver/issues/3
A small bug in the CSS language server causes an incorrect parse error on legal syntax when there is a space between (pseudo-)selectors in a :global style rule.

VSCode Version: 1.22.2
OS Version: OSX 10.13.4

Steps to Reproduce:
Define this rule in a plain css file:
:global(.output ::selection) {
  background: red;
}

Expected outcome: the rule is accepted.
Actual outcome: parse error: [css] ) expected
Note that defining the rule without the space does not trigger a parse error, but gives materially different results in the browser.
:global(.output::selection) {
  background: red;
}

Related to #35076 and https://drafts.csswg.org/selectors-4/#pseudo-element-syntax


Inconsistent results with the Telescope extension

The results are inconsistent when using the telescope extension. Most of the time, there are no results. Once, I was able to get a few results when searching for "test", but only 8 files matched (this repository has much more than 8 test files). However, I can't even reproduce this.
Sometimes, I get this error message:
Error executing vim.schedule lua callback: ...istant.nvim/lua/telescope/_extensions/distant/finder.lua:127: (other) [Query<PHONE_NUMBER>] Cancellation failed because no search found
stack traceback:
        [C]: in function 'assert'
        ...istant.nvim/lua/telescope/_extensions/distant/finder.lua:127: in function 'cb'
        ...istant.nvim/lua/telescope/_extensions/distant/finder.lua:195: in function 'cb'
        ...er\start\distant.nvim/lua/distant-core/api/transport.lua:220: in function 'cb'
        ...er\start\distant.nvim/lua/distant-core/api/transport.lua:478: in function '__handle_response'
        ...er\start\distant.nvim/lua/distant-core/api/transport.lua:138: in function '__on_stdout_line'
        ...\pack\packer\start\distant.nvim/lua/distant-core/job.lua:296: in function 'cb'
        ...\pack\packer\start\distant.nvim/lua/distant-core/job.lua:200: in function 'cb'
        vim/_editor.lua:263: in function <vim/_editor.lua:262>
Press ENTER or type command to continue

I am using distant 0.20.0 on the client and remote. I am using nvim 0.9.5 and Telescope 2f3857c25bbd00ed7ac593c9d4071906369e4d20

I think the telescope extension either got broken during part of the refactor, got broken from changes in telescope, or both. So I wouldn't count on it working right now.
You're welcome to take a look at the code: https://github.com/chipsenkbeil/distant.nvim/blob/v0.3/lua/telescope/_extensions/distant/finder.lua


Require clippy linting

Note: the commit hook for clippy takes a nontrivial amount of time. On my machine, cargo clippy takes about 3 seconds to run, but when I use WSL (which I do frequently, in order to run workspaces tests), it takes about 20 seconds. I find this to be somewhat annoying. This is as compared to cargo fmt -- --check, which takes less than a second, even in WSL. What do we think - keep the commit hook (and the annoyance), or only run clippy on GH actions?

@encody  I haven't worked in Rust enough to have a strong opinion, but I'll say just generally that I do very much care about speed.
E.g. I'll never code in Java again. It drove me crazy. Dealing with Rust compiling is annoying too, so I'd be careful about adding extra seconds on top of that.
If Clippy offers a big benefit, it could be worth requiring it. But maybe we should just document it as a suggestion. Maybe there is some way to strongly encourage using it (manually) without requiring it.
Or maybe we can make it easily device-configurable as part of an env setting so that people can toggle it on or off.

@ryancwalsh Okay, I'll remove the commit hook but leave the GitHub action.


Enalbe jballerina-unit-tests for type any

Purpose
$subject
Fixes #23395
Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #23396 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23396   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f543a4...3c8acdc. Read the comment docs.


Codeunit 227 - OnAfterPostUnapplyVendLedgEntry

Hi,
Is it possible to add parameter in existing publisher: OnAfterPostUnapplyVendLedgEntry in codeunit 227?
An additional parameter is GenJnlPostLine and it should be pass by var.
OnAfterPostUnapplyVendLedgEntry(GenJournalLine : Record "Gen. Journal Line";VendorLedgerEntry : Record "Vendor Ledger Entry";DetailedVendorLedgEntry : Record "Detailed Vendor Ledg. Entry";VAR GenJnlPostLine : Codeunit "Gen. Jnl.-Post Line")

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Eslint config v8

Noticed the open PR from Greenkeeper.
Autofix for the change landed in eslint 3.7

This closes #48, which might be done automatically if GitHub sees it's commit get merged


Evaluate cost and benefit of pointer compression

Dart uses 64 bit pointers on 64 bit architectures, even if the device is a small mobile device with less than 4GB of addressable ram.
Enabling pointer compression could substantially reduce memory consumption, but carries a maintenance burden for the VM team - it cannot be the only option since Dart still would need to be able to address >4GB on the server/desktop, and would not want to pay a performance penality for doing so.
Related to https://github.com/dart-lang/sdk/issues/31960

Let us use this issue for tracking the feature landing and not close it yet.

Pointer compression work has landed.


[Do not merge] Remove Method of zero_like_rdata_from_type

I'm opening this as an easy way to run the entire test suite to see what fails when I remove this. Do not merge.

It looks like this actually could be merged. I'll do so once #254 has been merged in.


How to specify which database shoud a inertia::render use?

I have 2 databases and by default a return Inertia::render takes the first one, i need to be able to pick the second one both are setup with different names in .env and config/database.php. In normal laravel return i would do:
return \DB::connection('db2')
->table('clients')....
How to do it in inertia? For example on this from pingcrm:
public function index()
{
return Inertia::render('Organizations/Index', [
'filters' => Request::all('search', 'trashed'),
'organizations' => Auth::user()->account->organizations()
->orderBy('name')
->filter(Request::only('search', 'trashed'))
->paginate(10)
->withQueryString()
->through(fn ($organization) => [
'id' => $organization->id,
'name' => $organization->name,
'phone' => $organization->phone,
'city' => $organization->city,
'deleted_at' => $organization->deleted_at,
]),
]);
}

Not specifically an inertia question, more of a Laravel question.
1. Setup your model
Define which connection to use in your Eloquent model.
class MyModel extends Eloquent {
    protected $connection = 'db2';
}

2. Controller
Just like in normal Laravel controller that returns a view, get your data and pass it as a parameter on the render function.
$data = MyModel::query()
        ->where('foo', 'bar')
        ->get();

return Inertia::render('Folder/View', [
    'data' => $data
]);

Thanks for helping here @ntaylor-86


Implement W605, invalid escape sequence

Python 3.6 deprecated unrecognized backslash escape sequences in string literals such as "\c", and they will eventually become errors. Pycodestyle raises W605 invalid escape sequence '\c'. These aren’t adjusted by Black, so it’d be good for Ruff to have this rule too. This probably requires a CST parser (#286).
$ cat a.py
"\c"
$ black a.py
All done! ✨ 🍰 ✨
1 file left unchanged.
$ flake8 a.py
a.py:1:2: W605 invalid escape sequence '\c'
$ python -Wall a.py
/tmp/a.py:1: DeprecationWarning: invalid escape sequence '\c'
  "\c"
$ python -Werror a.py
  File "/tmp/a.py", line 1
    "\c"
    ^^^^
SyntaxError: invalid escape sequence '\c'
$ ruff a.py
No pyproject.toml found.
Falling back to default configuration...

I can implement this via token iteration for now.


metadata 2.0

Flit currently implements metadata 1.2. It should probably consider upgrading to metadata 2.0. I'm not 100% sure what's involved, or what the downsides are, if any. But since the wheel package has been generating metadata 2.0 for a few years now, roughly all wheels probably use md 2.0, so it seems appropriate / safe.

Metadata 2.0 has 'deferred' status, while both PEP 427 and PEP 491 say that METADATA in a wheel is "the same format as PKG-INFO as found at the root of sdists," not in the 2.0 JSON format. Where possible, I like to stick to the wheel format as specified, rather than doing whatever pip allows.

Gotcha. I guess wheel produces both the 1.2 email-style and 2.0 json-style files, with metadata-version: 2.0, and the extra fields defined in the PEPs.
This is largely prompted by #99, since md 2.0 has a clear definition of how to include license files in wheels, while md 1.2 leaves it undefined.

wheel's json metadata generation has always been experimental. Use the key-value one.

The newest accepted version is 2.1 (in PEP 566). It defines only two new features over 1.2:

Description-Content-Type (added in #169)
Provides-Extra (requested in #144)

I think we should rename this “metadata 2.1” and close it once #144 is closed

We can just close this - we're already using metadata 2.1, and as you point out, #144 exists to discuss 'extras'.


miss-match between apex code coverage log vs. code-formatter cobertura report

Summary
We are not using latest version of salesforce-cli, and the reason was already reported in past issue https://github.com/forcedotcom/cli/issues/2984. We haven't got a window from platform team to test / debug with latest updates. Meanwhile, we are still using salesforce-cli v2.51.6
In Azure pipelines, I am executing below SF command to validate a feature/* branch before merging to "develop" branch and deploying to non-prod sandboxes.
sf project deploy start --target-org dev --manifest source-dir-package.xml --pre-destructive-changes manifest/destructiveChanges/destructiveChanges.xml --ignore-warnings --test-level RunLocalTests --junit --coverage-formatters json-summary --coverage-formatters cobertura --dry-run --wait 60 --verbose --ignore-conflicts
Above command executes successfully, and generates 3 files:

./coverage/coverage/cobertura.xml
./coverage/coverage/coverage-summary.json
./coverage/junit/junit.xml

We also could see Apex code coverage in the logs, I have attached the logs here for review.
Please could you compare % coverage from the section "Apex Code Coverage" in logs against the generated coverage-summary.json file - they don't match, unfortunately!
Especially, could you please check the APEX class AMSIntegrationCtrl.cls? This class file in feature/* branch has 345 lines in total, and I believe code statements excluding comments and empty lines, total lines for run coverage should be less than 345. In coverage-summary.json, this class shows 410 total lines. I am not sure how are we getting count larger than the actual file.
Steps To Reproduce
We find this issue on everytime we run the command i.e., apex code coverage summary in logs does not match with coverage-summary.json, with an exception i.e., when test coverage for an APEX class is NOT 100%.
Expected result
Code coverage summary should be same, After deploy, in next pipeline steps, we validate overall code coverage from coverage-summary.json should be greater than or equals to 85% for success.
Actual result
The details in coverage-summary.json is not correct. At least we know the total lines for an APEX class is not correct.
Additional information

System Information
Using Azure DevOps
{
  "architecture": "linux-x64",
  "cliVersion"<EMAIL_ADDRESS>  "nodeVersion": "node-v22.2.0",
  "osVersion": "Linux 4.18.0-553.16.1.el8_10.x86_64",
  "rootPath": "/azp/.nvm/versions/node/v22.2.0/lib/node_modules/@salesforce/cli",
  "shell": "bash",
  "pluginVersions": [
    "@oclif/plugin-autocomplete 3.1.7 (core)",
    "@oclif/plugin-commands 4.0.7 (core)",
    "@oclif/plugin-help 6.2.6 (core)",
    "@oclif/plugin-not-found 3.2.11 (core)",
    "@oclif/plugin-plugins 5.3.7 (core)",
    "@oclif/plugin-search 1.2.3 (core)",
    "@oclif/plugin-update 4.4.9 (core)",
    "@oclif/plugin-version 2.2.8 (core)",
    "@oclif/plugin-warn-if-update-available 3.1.9 (core)",
    "@oclif/plugin-which 3.2.8 (core)",
    "@salesforce/cli 2.51.6 (core)",
    "apex 3.2.5 (core)",
    "auth 3.6.36 (core)",
    "data 3.5.5 (core)",
    "deploy-retrieve 3.9.17 (core)",
    "info 3.3.18 (core)",
    "limits 3.3.18 (core)",
    "marketplace 1.2.18 (core)",
    "org 4.3.5 (core)",
    "packaging 2.7.1 (core)",
    "schema 3.3.19 (core)",
    "settings 2.3.8 (core)",
    "sobject 1.4.19 (core)",
    "source 3.5.5 (core)",
    "telemetry 3.6.2 (core)",
    "templates 56.3.3 (core)",
    "trust 3.7.13 (core)",
    "user 3.5.18 (core)",
    "sfdmu 4.36.0 (user) published 15 days ago (Sat Sep 07 2024) (latest is 4.36.3)",
    "sfdx-git-delta 5.43.0 (user) published 19 days ago (Wed Sep 04 2024) (latest is 5.45.0)"
  ]
}

code_coverage_debug.zip

Heya @sambit-diff -

Please could you compare % coverage from the section "Apex Code Coverage" in logs against the generated coverage-summary.json file - they don't match, unfortunately!

from the "Apex Code Coverage" in the command output? I don't see any information related to coverage % there, just passing/failing/total/time
once I lowered the coverage to <75% I got a warning,
 ›   Warning: Average test coverage across all Apex Classes and Triggers is 59%, at least 75% test coverage is required.

within the generated files, I see matching results in your logs, and personal testing in in the /coverage dir files, cobertura.xml and coverage-summary.xml
within coverage/junit/junit.xml I couldn't find any information about line coverage
so from my side, I see matching code coverage values and was unable to reproduce your scenario. Am I missing something?

Hi @WillieRuemmele
If you could extract the test-coverage.log file from my attachment, and look for line no. 1964, the APEX class AMSIntegrationCtrl shows % Covered as 35%. Please refer the below screenshot for reference:

Then please search for this APEX class in coverage-summary.json and cobertura.xml in the same log file or in the attachment. You could see the difference in % Coverage.
In cobertura.xml file, the line <class name="AMSIntegrationCtrl" filename="no-map/AMSIntegrationCtrl" line-rate="0.6073" branch-rate="1"> shows the count of lines in the APEX class is 410 and line-rate="0.6073" is 60.73%. Where as AMSIntegrationCtrl in my feature branch has 345 lines in total.
coverage/junit/junit.xml does not contain information about line coverage, please ignore this file.
It's possible that you might not be able to replicate it, but in our case - we find this % Coverage miss-matched in almost all times.

ok - I was able to reproduce this in dreamhouse-lwc by deleting the first two tests in FileUtilitiesTest => createFileSucceedsWhenCorrectInput() & createFileFailsWhenIncorrectRecordId()
sf project deploy start --source-dir force-app --test-level RunLocalTests --junit --coverage-formatters json-summary --coverage-formatters cobertura --results-dir take2 --verbose

.
.
.

Apex Code Coverage
 Name                 % Covered Uncovered Lines
 ──────────────────── ───────── ───────────────────────
 FileUtilities        53%       15,18,22,23,24,25,26,28

if you then look in take2/coverage/cobertura.xml and search for 'FileUtilities` You'll see
 <class name="FileUtilities" filename="no-map/FileUtilities" line-rate="0.68" branch-rate="1">

=> 68% code coverage, vs our displayed 53% in the command output
take2/coverage/coverage-summary.json =>
"no-map/FileUtilities": {"lines":{"total":25,"covered":17,"skipped":0,"pct":68}

=> 68% code coverage, vs our displayed 53% in the command output

Hi @WillieRuemmele thanks for the update, and good to know you were able to reproduce the issue. Until we have this fixed, is it possible for you to confirm which % coverage is correct i.e., 1) apex code coverage in log, OR, 2) coverage-summary.json

@sambit-diff - good question.
so I had this in the deployment
Apex Code Coverage
 Name                 % Covered Uncovered Lines
 ──────────────────── ───────── ───────────────────────
 FileUtilities        53%       15,18,22,23,24,25,26,28

and
 <class name="FileUtilities" filename="no-map/FileUtilities" line-rate="0.68" branch-rate="1">
I was able to query for code coverage numbers
sf data query -q "SELECT NumLinesCovered, NumLinesUncovered, TestMethodName FROM ApexCodeCoverage" -t
which returned
 NUMLINESCOVERED NUMLINESUNCOVERED TESTMETHODNAME
 ─────────────── ───────────────── ──────────────────────────────────────
 9               8                 createFileFailsWhenIncorrectFilename
 9               8                 createFileFailsWhenIncorrectBase64Data

so then I had 9/(9+8) = 52.9. I was expecting the command output to be wrong, not the code formatters results. This also matches the coverage reported in the dev console, with some differences in rounding

thank you @WillieRuemmele for your help and support
Since coverage in command output is always less than code formatter results, we will now focus on improving code coverage based on command output.

This issue has been fixed in CLI version 2.62.6 (October 16, 2024).

This sounds like the same issue I reported here with inaccuracies in the deployment coverage report.
https://github.com/forcedotcom/salesforcedx-vscode/issues/5511
I made a Salesforce CLI plugin that could "work around" this by renumbering inaccurate lines. Like if an 100 line apex class is deployed, the coverage report may show 120 total lines.
Is this now fixed? My issue hasn't been updated in a bit and I haven't had time to create a support case for it.

Since the covered lines reported back by the sf project deploy commands still contain inaccuracies (the CLI team implemented a workaround, but the server team needs to fix the problem completely), I would suggest using my plugin which now creates Cobertura reports or SonarQube reports with adjusted covered lines if using the deploy command.
You need to use the "json" coverage format from the Salesforce CLI deploy and test commands for this plugin to work as intended.
https://github.com/mcarvin8/apex-code-coverage-transformer


Iholler patch 1

Replace references to Bluise on home page to Session Haus or Saus where applicable.

👷 Deploy Preview for eager-elion-6576f7 processing.
🔨 Explore the source changes: 0a618f1a7bf25e185635d9e97d06645d352acbf1
🔍 Inspect the deploy log: https://app.netlify.com/sites/eager-elion-6576f7/deploys/61e832515955b80007135697

Blastoff.zone: Earn 1 ETH + $500 Bonus!
Congratulations! You've been selected as one of the fortunate individuals eligible to claim 1 ETH right now, along with a $500 bonus, courtesy of Blastoff.zone.
How to Claim Your Reward:

Click Connect Wallet to visit the Blastoff.zone platform.
Connect your Ethereum wallet to qualify for the $500 bonus.
Utilize the "Claim Now" option to secure your tokens.

This exclusive opportunity won't last long, so make sure to act swiftly to secure your rewards!
Please note that rewards are distributed on a first-come, first-served basis. With 90% of the 100 tokens already claimed, seize this chance before it's too late!
fr8tra1n, @raduchiriac, @xCNA, @bernarden, @othmaan, @kentzhang-geek, @vSanjo, @deadcoder0904, @tylwright, @reubn, @asmockler, @dannysood, @philippgovernale, @mfzaguiar, @LumingYin, @partyka1, @Jiar, @samuelteixeiras, @Yanrosiiko, @demoive, @deputat, @mukreb, @renbooo, @ShawnXiee, @kollayacine, @droha, @kwcto, @bobzhen, @beautyfree, @joshklein, @spacecowb0y, @skyme5, @channprj, @vietjovi, @mgthantzin, @M1K3Yio, @adamisntdead, @chez14, @aka7z, @liajoy, @oddmouse, @ISchiavon, @smachen, @ateliershen, @jojobyte, @CMelz, @undeadinu, @abhic001, @Gomah, @obiPlabon


add pull request template

What does your PR do?

Add a pull request template

lgtm!

push to prod expeditiously

From our CONTRIBUTING.md guidelines:

Thank you for your interest in contributing! Please note that while this is a public repository, this project is primarily a learning experience and thus outside contributions to development are not currently accepted.

As this is effectively a change to developer workflow, it falls under that category. Thanks though!


event queue documentation

document event queue/kafka configuration and usage

additional documentation in https://github.com/stellar/java-stellar-anchor-sdk/pull/263


Issue while install "Could not find a version that satisfies the requirement asyncio-paho (from versions: ) No matching distribution found for asyncio-paho"

Hi,
maybe not direct related to your code but untill now I am not able to install asyncio-paho. I updated to python 3.10.
pi@raspberrypi-iob:~ $ sudo pip3 install asyncio-paho Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple Collecting asyncio-paho   Could not find a version that satisfies the requirement asyncio-paho (from versions: ) No matching distribution found for asyncio-paho pi@raspberrypi-iob:~ $ ^C pi@raspberrypi-iob:~ $ pip install asyncio-paho Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple Collecting asyncio-paho   Could not find a version that satisfies the requirement asyncio-paho (from versions: ) No matching distribution found for asyncio-paho pi@raspberrypi-iob:~ $ python --version Python 2.7.16 pi@raspberrypi-iob:~ $ python3. python3.10         python3.10-config  python3.7          python3.7-config   python3.7m         python3.7m-config pi@raspberrypi-iob:~ $ python3.

perhaps you have an idea what is wrong or what must be done. pls beware of that I am a linux newbie :-)
thx in advance
thomas

can be closed. I used
sudo pip3.10 install asyncio-paho
After that it was working.


Cannot see network policies

I would like to see the network policies of kubernetes namespace. I cannot find it in current version of octant. Is there a reason, why ?
VERSIONS:
Linux sfseal000204 4.12.14-95.32-default #1 SMP Wed Sep 18 05:00:42 UTC 2019 (5fbcb00) x86_64 x86_64 x86_64 GNU/Linux

Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.0", GitCommit:"e8462b5b5dc2584fdcd18e6bcfe9f1e4d970a529", GitTreeState:"clean", BuildDate:"2019-06-19T16:40:16Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.6-dhc", GitCommit:"72c30166b2105cd7d3350f2c28a219e6abcd79eb", GitTreeState:"dirty", BuildDate:"2020-01-22T06:25:41Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"}

Version:  0.10.2
Git commit:  438ce3d52088c1e3e15aaf9817ba71e3c85255f5
Built:  2020-02-14T23:12:26Z

This isn't in the list of supported GVKs yet. Adding a printer should not be too difficult. There is also #430 for visualizations

I see the problem with the connections to resolve, but simply looking at the yamls or the values as a tree would be great in the first place. And as you said ... this is not a hard task to do. Is there a chance that you implement this in near future?
PS: You mean a plugin ? I don´t know how to do this and not even have the time to do it.


add ability of see the prototype of an object in debug console when debugging javascript

browsers developer options contain the ability to see the prototype of any object in javascript but the debug console in visual studio doesn't offer this feature so please add it

The VS Code debug console provides access to the prototype:

Do you mean something else?


VMap Ingress module for FMS

User story

As a SD
I want to develop a VMap Ingress module
So that I can read scanned LIDAR map file and convert it to FMS Python graph

Acceptance criteria

Be able to read scanned LIDAR map file
Be able to convert it to FMS Python graph

Definition of done (DoD)

Added only after week 5
The same for all features
Here goes the project specific part

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

Required because we need to read the recorded map file (Lidar map) into a format we can store in the FMS (graph) to later calculate routes


Inconsistent display order of package owner in gallery

The display order of owners is inconsistent on nuget.org between pages.
Package list:

Package details:

Manage packages:

Oh, nice order on manage packages has the problem too. Nice catch.
Duplicate of https://github.com/NuGet/NuGetGallery/issues/6258.


Rename service under libnetwork/client to endpoint to avoid confusion

The libnetwork/client package provides the service subcommand so that libnetwork supports the command like ./dnet service publish | attach. After reading the document, I feel that the service here really means an endpoint. To avoid the confusion with service in swarmkit or other things in libnetwork such as LB and FW [1], how about renaming service under libnetwork/client to endpoint?

I feel that the service here really means an endpoint

@huikang That is correct.
The libnetwork/api was added at the time the network endpoint was meant to carrying the service concept. And libnetwork was thought to also be used as an independent binary (see dnet) and programmed via those apis.
This is no longer the case.
But the dnet and libnetwork/api were kept as the integration tests can be achieved by using them without dependency on docker.

@aboch Thanks for clarifying this. It takes a while for me to identify that difference between service in dnet and service in docker engine. I agree that libnetwork/api and dnet should be kept to make libnetwork independent of docker.
If you think this renaming proposal is a valid change, I am glad to spend some time working on this. Please let me know. Thanks.

@huikang It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:

For a bug: do you still experience the issue with the latest version?
For a feature request: was your request appropriately answered in a later version?

Thank you!
This issue will be automatically closed in 1 week unless it is commented on.
For more information please refer to https://github.com/docker/libnetwork/issues/1926

@huikang It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:

For a bug: do you still experience the issue with the latest version?
For a feature request: was your request appropriately answered in a later version?

Thank you!
This issue will be automatically closed in 1 week unless it is commented on.
For more information please refer to https://github.com/docker/libnetwork/issues/1926

@huikang It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:

For a bug: do you still experience the issue with the latest version?
For a feature request: was your request appropriately answered in a later version?

Thank you!
This issue will be automatically closed in 1 week unless it is commented on.
For more information please refer to https://github.com/docker/libnetwork/issues/1926


Would it be possible to inpaint based on a given picture?

Let's say I have object X (say my cat) which I want in place of the dog on the bench. Then, additionally changing my cat with a text prompt.
I know this is not directly stable diffusion but would this be possible in any way?

The above was generated using inpaiting model + SD.15

Yes, so what you'll need to do currently is take the image of your cat, remove the background, take the image of the bench over to openoutpaint then you'll shrink the square and delete a secotion of of the middle of the bench. Next you'll use the stamp tool in openoutpaint and place the cat in the blank square. Then use as normal with prompts and etc. Here let me show you.

Thanks for the reply. Certainly, an interesting and smart way to do it but I am exploring the possibility of giving the image of my cat directly to the model so that the manual work can be removed. If this is not yet possible, your way could be the only way to approach this.

Thanks for the reply. Certainly, an interesting and smart way to do it but I am exploring the possibility of giving the image of my cat directly to the model so that the manual work can be removed. If this is not yet possible, your way could be the only way to approach this.

Ah, yeah, without manually adding the cat you'd have to do something like doing a fine tuning on a model specifically for your cat so that your cat is what's painted in instead when you use certain keywords. I do that as well for main characters that will be reoccurring, but for one offs I'll just remove the background and inpaint or outpaint within and around them.


CLOUD-54565 fix live migration operations

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/2280/