Kqlmagic in Azure Data Studio should behave like pip install where it picks the latest best non-dev version

Azure Data Studio Version:
Version: 1.22.1
Commit: 1b5c54dd8c6eb03bf7ed1e04889d9f41de0523b3
Date: 2020-09-29T16:38:23.291Z
VS Code: 1.49.0
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.4.0-48-generic

Steps to Reproduce:

Use Manage Packages on a Python Notebook.
Click on Add New then search for Kqlmagic.
Actual -

Expected -
pip upgrade command today installs/upgrades kqlmagic with the latest non-dev version. It would be best to match this behavior.
i.e. only list 0.1.11, 0.1.12, 0.1.13, 0.1.113post etc.
(For testing purposes, users can install the dev versions from pip manually if needed)

@corivera is there a relatively simple fix that we can do here? I seem to recall that we have that logic that allows us to sort package versions, so wondering if we can augment that with sorting when a package has "dev" like it does here.

The sorting method we use is here: https://github.com/microsoft/azuredatastudio/blob/main/extensions/notebook/src/common/utils.ts#L146
I'll take a look at these new cases.


Fix note menu placement on tablets

Comparing the note menu between default and current EBW. I will need to fix.

This is a toggle-able style setting:

Running into issues trying to reduce the space between the items on landscape view. Will keep hammering at this.

When you have a moment, @ebullient, what would you suggest?
The goal for me is to move the header actions either closer to the arrows on the left, or title in the middle.

Mine already looks different.. I have a few additional with commander:

So I'm not sure why you have things so spread out.

In source:

view order messes the floats around, and reverses the order of actions:

It's possible, as I dont use it.

Latest 1.7.2 with stacked tabs on, header actions to the left while in landscape. It seems consistently in that spot. Trying to nail down now.

Developer mode on desktop shows regular; will look for maybe a mobile selector we are missing.

Do you have contextual typography?

Well, I am at a loss. Maybe we table this until someone else reports it, as it's not a breaking type of issue for me. Thoughts?


Clarify/clean up spacecraft/cpu names/ids

Is your feature request related to a problem? Please describe.
Defined in platform config:

CFE_PLATFORM_CPU_ID (referenced by CFE_PLATFORM_TBL_VALID_PRID_1 and CFE_CPU_ID)

CFE_PLATFORM_TBL_VALID_PRID_1 is used in internal table logic
CFE_CPU_ID looks unused

CFE_PLATFORM_CPU_NAME (referenced by CFE_CPU_NAME)

CFE_CPU_NAME looks unused

Defined in mission config:

CFE_MISSION_SPACECRAFT_ID (referenced by CFE_PLATFORM_TBL_VALID_SCID_1 and CFE_SPACECRAFT_ID)

CFE_SPACECRAFT_ID looks unused
CFE_PLATFORM_TBL_VALID_SCID_1 used in internal table logic

Defined by cmake:

CFE_CPU_ID_VALUE (from TGTID), sets .Default_CpuId in target config
CFE_CPU_NAME_VALUE (from TGTNAME) sets .Default_CpuName in target config
CFE_SPACECRAFT_ID_VALUE (from SPACECRAFT_ID) sets .Default_SpacecraftId in target config

Describe the solution you'd like
Remove/deprecate unused and/or clarify use/intent.  Looks like spacecraft ID may actually be defined differently (42 vs 0x42).
Describe alternatives you've considered
Stay confused.
Additional context
Table use looks like it could lead to inconsistencies.
Requester Info
Jacob Hageman - NASA/GSFC, triggered by @johnphamngc comments on nasa/psp#154

The CFE_CPU_NAME, CFE_CPU_ID, and CFE_SPACECRAFT_ID should already be deprecated.
The values from CMake are the ones which actually drive the return value of CFE_PSP_GetSpacecraftId() and CFE_PSP_GetProcessorId().
The recommended practice should be for apps to call these PSP routines to get the values at runtime, not to rely on the value in the header file.  Now that CMake is being used for all, the CMake definitions should be there, so we should deprecate all header file constants.
Unfortunately, there is no CFE_PSP_GetProcessorName() or equivalent.  Probably need to add this (trivial, would work just like ID, except a const char *).

The CFE_CPU_NAME, CFE_CPU_ID, and CFE_SPACECRAFT_ID should already be deprecated.

Correct. I'm more surprised about use of the PLATFORM/MISSION values in table logic.  Didn't dig into it though.

Yeah, we might have a bug here in that tables will get the wrong value if they use the header file define.  Probably need to remove from these headers and add as "-D" options when invoking the compiler as part of table file builds.

Quick check shows these TBL Values are only used depending on CFE_PLATFORM_TBL_VALID_SCID_COUNT and CFE_PLATFORM_TBL_VALID_PRID_COUNT being greater than 0.  Default config is zero.  Also a case of the code getting "compiled out" when its zero, so it could be broken.

Also note about table file builds that the actual value in the header (IIRC) comes from elf2cfetbl command line parameters, which comes from CMake, so its OK.  I don't know of any tables that actually contain the CPU ID / Spacecraft ID in the table content.

I've noticed it would probably be desirable to be able to override the CPUID manually, rather than having them sequentially assigned by TGTID, in scenarios where multiple integration repositories are used to build the spacecraft software and they all need to communicate over SBN(g).

Ultimately the PSP determines the CPU ID at runtime.  The value from CMake is just a default.  For instance the pc-linux PSP allows it to be overridden on the command line via an argument.  Other FSW target PSP's could do something similar.
Table builds are a different story- if you also need to put the CPU ID in a table then this would be a new feature/enhancement.

Ping @excaliburtb

So, no one should not rely on the contents of cfe_platform_cfg.h directly from an app level but from an integration level, the default values compiled into the PSP should probably come from the header, not from cmake. In other words, I would want CFE_PSP_GetProcessorId() to return CFE_PLATFORM_CPU_ID by default. The advantage of the header is that it clearly defines those values and is not obfuscated by cmake variable or build scheme. If you want to provide an optional cmake variable that allows the user to override the header content, I guess you could do that.

Note that there is (currently) no requirement for a unique/different cfe_platform_cfg.h file per cpu.   In fact I would always encourage/recommend NOT redefining things that aren't really necessary to redefine.  So whenever possible we should try to use a common/shared platform config unless there is a good reason not to.
Also note that cfe_platform_cfg.h applies to CFE core, not to the PSP.  Up until recently it wasn't even possible to #include this file from PSP code (the compiler include path didn't have this file).  Although a recent change did relax that by consolidating the 3 different scopes back to 2, and thereby make this inclusion possible, I still wouldn't recommend it - again because the PSP isn't recompiled for each CPU.  If more than one CPU shares the same platform, the same PSP binary library is used.  CPU ID is runtime data.
Conversly - If we fixed #265 to allow independently configuring the number rather than assuming consecutive numbering, wouldn't that also address this issue?  In that case, the CPU numeric IDs would be specified in targets.cmake right where the name is specified, which seems quite logical to me.   They just wouldn't have to match the CMake IDs anymore.

Yes, fixing #265 would help a lot. The point is, don't decide for me what the default cpuid is with no way to set it myself.

Okay, there's one more way to look at this that shouldn't require me waiting for #265. Right now the default CPU ID is actually built into target_config.c which is not in the PSP itself. It's in CFE. So, I need to be able to specify, either by platform_cfg.h or a cmake variable what is used to set that default. I'm assuming target_config.c is not considered a "shared" library between targets.


Feature: Publishing date - roadblock

- Feature
Don't let me publish without updating the date....unless I want to.
- What is the current behavior?
Right now you're able to publish, even if the date is postdated - and, if you're me, you may forget you wrote that a week ago and you need to change the date. Then, it doesn't show up on your page or DP and you almost panic...
- If the current behavior is a bug, please provide the steps to reproduce.
See above
- What is the expected behavior?
You can remind me when I 'save' to update the date. However, since you're able to publish from the editorial workflow homepage, it's even more pertinent I know the date wasn't updated. A popup may make the most sense.

A publishing date isn't something that's baked into netlify cms so that's totally generic.
But there's validation functionality for widgets, so we could run the validation when something is being published, waddayathink @Benaiah @erquhart O_O

Hmm good point. Metadata handling seems to be in limbo right now - this might not be a great ticket to handle as a one-off.

Perhaps the ability to provide a prompt for a specific event, like publish, would be a broad solution to this and maybe other issues we're not hearing about. It would be cool if I could create a React component that would show as a modal, and maybe my component would provide a checklist where the user has to check each box before being allowed to confirm and move forward with publishing. With access to the entry itself, one line could specifically call out the publishing date.
Or the prompt could show or not show based on a function returning true or false, and I could return true to show the modal only if a specific date field is not the same date as today.

Closing as stale and/or outdated.


Raise error on Ruby 2.6 until it is supported

As the project does not tell the user that Ruby 2.6 is not yet
suypported, they frequently ask why their code is not working with the
following error:
Error parsing classes in /root/manageiq/app/models/account.rb:
RuntimeError: type should be a Symbol, not: 6

This commit is to prevent those questions until we can get Ruby 2.6
working.

@jrafanie @bdunne Please review.

LGTM


Fix create and validate button

Story
Prior to these changes:
In Bulkrax, the Create and Validate button is affected by a bug known in the community. Within SoftServe we agreed to hide this button to reduce the confusion it’s causing amongst Bulkrax users. We will create an issue as a reminder to discuss and/or fix the functionality of this button in the future.
Issue: #
With these changes:
After discussion, the solution we chose to implement was to add a conditional statement to the importer's new.html.erb file that hides the Create and Validate button until the bug is fixed.
Screenshots

ENV Variable set to true

ENV Variable set to false

ENV Variable set to violet

ENV Variable set to no value

Acceptance Criteria
The Create and Validate button on the importer form functions as expected.

Please link the issue to this PR @DeonFranklin


Gotta fix = -> ==

https://github.com/shunk031/chainer-skin-lesion-detector/blob/1865eb0bd287b3493f2bbe48720b567ebd9f3850/requirements.txt#L10

Sorry, just want to know after training, how to do the evaluation?


Allow passing of null to labels, same way as datapoints

Chart.js should ignore null labels, much the same way it ignores null data-points.
This allows for better non-syncing line datasets, ex. a dataset with an index and datapoints.
I've submitted a pull request, although I am not sure if my solution is the optimal, just a quick fix.
I've also added a sample which demonstrates the usecase for this.

Or, apperantly, I cannot figure out how to create a pull request. Github noob, sorry about that.
I'll make that pull request ASAP.

@fellmirr take a look at my comment on #1433

See #1433


In 1.8.22 and 1.8.23 all my Xiaomi Switched stopped working

When clicking a switch the "click", "double" click ect. events don´t fire. But I see that the switches are connected because the msg_from_zigbee and link_quality become highlighted in green (screenshot)
If I downgrade to 1.8.21 everything works fine again.

Versions:

Adapter version: 1.8.23
JS-Controller version: 4.0.24
Node version: v18.17.0
Operating system: raspi mit linux

Is this correctl created on radar2 Repo? Seems not


<CoreServices/CoreServices.h>

when i port my iOS project,I got the error "'CoreServices/CoreServices.h' file not found" in the file "AFHTTPSessionManager.h",the error code-->#import <CoreServices/CoreServices.h>

This is really a bug in AFHTTPSessionManager.h
#if TARGET_OS_IOS || TARGET_OS_WATCH || TARGET_OS_TV
#import <MobileCoreServices/MobileCoreServices.h>
#else
#import <CoreServices/CoreServices.h>
#endif
The first line should also include WINOBJC.  We do have MobileCoreServices.h

Closing since this is external.

I added the word "WINOBJC" in the first line and I do not recognize the code of the library


[Fix] Should not cache the owner that does not belong to current server

this PR also solve #8071 , we don't add the incorrect bundle data int the server own cache
Motivation
modify the get ownership logic to support getOwnerAsync twice can get the same result.
Modifications
org.apache.pulsar.broker.namespace.OwnershipCache;

    private CompletableFuture<Optional<Map.Entry<NamespaceEphemeralData, Stat>>> resolveOwnership(String path) {
        return ownershipReadOnlyCache.getWithStatAsync(path).thenApply(optionalOwnerDataWithStat -> {
            if (optionalOwnerDataWithStat.isPresent()) {
                Map.Entry<NamespaceEphemeralData, Stat> ownerDataWithStat = optionalOwnerDataWithStat.get();
                Stat stat = ownerDataWithStat.getValue();
                if (stat.getEphemeralOwner() == localZkCache.getZooKeeper().getSessionId()) {
                    LOG.info("Successfully reestablish ownership of {}", path);
                    OwnedBundle ownedBundle = new OwnedBundle(ServiceUnitZkUtils.suBundleFromPath(path, bundleFactory));
                    if (selfOwnerInfo.getNativeUrl().equals(ownerDataWithStat.getKey().getNativeUrl())) {
                        ownedBundlesCache.put(path, CompletableFuture.completedFuture(ownedBundle));
                    }
                    ownershipReadOnlyCache.invalidate(path);
                    namespaceService.onNamespaceBundleOwned(ownedBundle.getNamespaceBundle());
                }
            }
            return optionalOwnerDataWithStat;
        });
    }

Verifying this change
add the test for it.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


kid3: fix autoupdate with releases

Relates to https://github.com/ScoopInstaller/Extras/pull/10970#issuecomment-1506782703

[X] I have read the Contributing Guide.

This should be a better fix to #10970 and #11040.

/verify


🌟Feature request: Add aria-label option for the Slider builder

Currently, the Slider's aria label is hardcoded to 'Volume'.
I can override it by adding the attribute after the {...$thumb()} on the element itself, but it would be nice if could provide it directly to the builder as an option.

We definitely shouldn't be applying one in this case.
I don't that having it as an option to pass to the builder would be a great idea since it could be applied directly to the element (once we remove the internal application).
My reasoning for this is that then we'd have to do the same for every builder and possibly additional attributes, which could get messy. Options should be reserved to things we need to use internally for one reason or another IMO, but open to having my mind changed!

Ah I think what you said makes a lot of sense. I'm still new to Melt-UI, so I'm not yet aware of the patterns and convention. Indeed, if no other builder works with label options (or other attributes), when it makes sense to keep it that way.
It's still pretty weird to hardcode an aria-label by default though.

It's still pretty weird to hardcode an aria-label by default though.

The aria-label should not be there by default, mistake on our end! Will remove it. Closing this issue for the reasons @huntabyte mentioned


Directly destructuring awaited generic collapses to any

New in 3.2.2(?) is this type mistake in baz() below.  result should be destructured to having type string, but instead it is any even though the unabbreviated syntaxes work correctly.
type responseType = { result: string }

declare function post<T = responseType>(): Promise<T>;

async function foo() {
    const response = await post(); // response : responseType  OK
    const result = response.result; // result : string OK
}

async function bar() {
    const response = await post(); // response : responseType OK
    const { result } = response; // result : string OK
}

async function baz() {
    const { result } = await post(); // result : any !!!!!!!!!!!
}

This is fixed in our latest nightlies, by #39081


Architecture

What architecture is the project meant to support? When building it on Yosemite I am faced with Error ld: symbol(s) not found for architecture x86_64 for symbols like "_Pa_CloseStream", "_Pa_GetDefaultOutputDevice" etc. Do you know where this would be coming from? Thanks.

Hi!
The x86_64 architecture is supported, that's what I have on my MacBook.
$ file stinkeedemo
stinkeedemo: Mach-O 64-bit executable x86_64

First, can you confirm that you installed the dependencies? Those _Pa_ symbols belong to the PortAudio library. If you haven't, then follow instructions on http://www.portaudio.com and install the latest stable release.
If you have, then perhaps you only installed it for i386 and your compiler is trying to build for x86_64? Find where it's installed and then use file again to confirm the shared library supports x86_64. Here's where it's installed on my computer.
$ file /usr/local/lib/libportaudio.2.dylib
/usr/local/lib/libportaudio.2.dylib: Mach-O universal binary with 2 architectures
/usr/local/lib/libportaudio.2.dylib (for architecture i386):	Mach-O dynamically linked shared library i386
/usr/local/lib/libportaudio.2.dylib (for architecture x86_64):	Mach-O 64-bit dynamically linked shared library x86_64

Hi there, thanks for getting back to me so promptly, I really appreciate
it. I've ran the checks you suggested and I get the same things as you for
libportaudio.2.dylib.
However, I noticed something in my portaudio install directory which I made
following the website steps for Mac OS: there's a file at
portaudio/lib/.libs/libportaudio-symbols.expsym
that contains a list of every Pa thing that was throwing an error. Is
this significant?
I would start over again with a new install of Portaudio but it's not clear
to me that that would change anything.
Your help is very much appreciated!
On Thu, Mar 26, 2015 at 12:33 PM, randomgen<EMAIL_ADDRESS>wrote:

Hi!
The x86_64 architecture is supported, that's what I have on my MacBook.
$ file stinkeedemo
stinkeedemo: Mach-O 64-bit executable x86_64
First, can you confirm that you installed the dependencies? Those Pa
symbols belong to the PortAudio library. If you haven't, then follow
instructions on http://www.portaudio.com and install the latest stable
release.
If you have, then perhaps you only installed it for i386 and your compiler
is trying to build for x86_64? Find where it's installed and then use file
again to confirm the shared library supports x86_64. Here's where it's
installed on my computer.
$ file /usr/local/lib/libportaudio.2.dylib
/usr/local/lib/libportaudio.2.dylib: Mach-O universal binary with 2 architectures
/usr/local/lib/libportaudio.2.dylib (for architecture i386):    Mach-O dynamically linked shared library i386
/usr/local/lib/libportaudio.2.dylib (for architecture x86_64):  Mach-O 64-bit dynamically linked shared library x86_64
—
Reply to this email directly or view it on GitHub
https://github.com/randomgen/stinkee/issues/8#issuecomment-86474889.

I'm not sure, but I suppose the extension expsym stands for exported symbols, so I am not surprised if _Pa_CloseStream and _Pa_GetDefaultOutputDevice are listed there. By the way, here's the list of _Pa_ symbols needed by the stinkeedemo program:
$ nm -j stinkeedemo | grep _Pa_
_Pa_CloseStream
_Pa_GetDefaultOutputDevice
_Pa_GetDeviceInfo
_Pa_GetErrorText
_Pa_Initialize
_Pa_OpenStream
_Pa_SetStreamFinishedCallback
_Pa_StartStream
_Pa_Terminate

Could it be that the compiler cannot find the library? But then I would expect a similar error message: ld: library not found for -lportaudio. The build currently assumes that PortAudio is installed in a "standard" directory: a path the linker will automatically search when looking for libraries. There must be a way to list those directories, but maybe to get the sample program to build first, start by modifying Makefile and after "-L." insert "-Lpath/your/portaudio/install".

If you still can't link against the PortAudio library, consider installing it with the Homebrew package manager (http://brew.sh/).
$ brew install portaudio

I have just tested it: compiled stinkeedemo successfully and executed it to activate the Scentee diffuser.

And I have just updated the README.md file to mention common package managers that include the correct PortAudio library. Hope that helps.

Hi, thanks for you additional help but I'm still not getting it to work.
With brew installed and the brew install portaudio command I find I have to
edit the Makefile to the full path as in -lportaudio to
-I/usr/local/Cellar/portaudio/19.20140130/lib/libportaudio.2.dylib
,
and also stinkee_diffuser.cpp from #include <portaudio.h> to
</usr/local/include/portaudio.h>.
Is that right or is my understanding of the linking way off? Thanks very
much!
On Wed, Apr 8, 2015 at 11:40 PM, randomgen<EMAIL_ADDRESS>wrote:

And I have just updated the README.md file to mention common package
managers that include the correct PortAudio library. Hope that helps.
—
Reply to this email directly or view it on GitHub
https://github.com/randomgen/stinkee/issues/8#issuecomment-91044029.

It's odd the library isn't automatically found, I believe that is one of the reasons brew installs everything in /usr/local (see "Why does Homebrew insist I install to /usr/local with such vehemence?" from https://github.com/Homebrew/homebrew/blob/master/share/doc/homebrew/FAQ.md).
man ld also confirms that "The default library search path is /usr/lib then /usr/local/lib"; brew must've already symlinked libportaudio.a in that second directory:
$ ls -log /usr/local/lib/libportaudio.a
lrwxr-xr-x  1   50  8 Apr 21:46 /usr/local/lib/libportaudio.a -> ../Cellar/portaudio/19.20140130/lib/libportaudio.a

Anyway, perhaps your environment has been customized in such a way that the default search paths don't point to those directories any more.
You shouldn't have to change any of the C++ header or implementation files, so I suggest you revert those changes; modifying Makefile should be enough.
Once you've reverted any changes, including in Makefile, try this:
$ env -i make

I think the -i option should prevent customizations in your environment variables to be inherited when running make.
If that doesn't fix it, try to set the include and library search paths explicitly:
$ env -i CXXFLAGS="-std=c++11 -Wall -pedantic -g -I/usr/local/include" LDFLAGS="-L/usr/local/lib" make


Added responsiveness

I have added responsiveness for mobile screens in the login/register page.

Kindly resolve conflicts @meayushsriv


Add hargovind to contributors list

#490

@HargovindArora, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?


Bot wont startup

Modmail bot keeps saying Connecting to Discord.

Mail bot is still offline too

Make sure the token is set properly in the config.

@TornadoGaming were you able to resolve this?

Closing this issue for inactivity. Feel free to reopen if you still need help.


Avoid termination due to SM throttling in early stage of experiment with SageMaker backend

If an HPO experiment with SageMaker backend and n_workers=16 is run, this can fail with a ThrottlingException.
The problem is that at the start, all 16 trials are started very close to each other, as a batch.
Need to avoid this failure by simply trying to start jobs again until this succeeds.

It is also the case that things fail when the SM backend tries to launch jobs, so it currently does not use this feature to avoid throttling exceptions. Maybe I miss something ...

OK. SageMaker BaseEstimator accepts a sagemaker_session argument (we don't use it), which in turn accepts a boto session argument. Maybe this would be a way to make it use of our boto config?

David:
Also I saw that retrying in presence of capacity error (internal SM error) is something that can be configured as well in estimators:
https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/estimator.py#L340

Solved by #342


How to get data on mouse move in ng2-nvd3 chart?

I am using ng2-nvd3 line chart.I want to get the data values on mouse move event.
Html as,
<nvd3 [options]="options" [data]="data">
And ts file,
ngOnInit() {
    this.options = {
        chart: {
            type: 'lineChart',
            interpolate: 'basis',
            height: 140,
            showLegend: false,
            x: function(d){ return d.fixTime; },
            y: function(d){ return d.speed; },
            useInteractiveGuideline: true,
            xAxis: {
                axisLabel: 'Time',
                tickFormat: function(d){
                    return d3.time.format('%I:%M:%S %p')(new Date(d));
                },
            },
            yAxis: {
                axisLabel: 'Speed (km)',
                tickFormat: function(d){
                    return d3.format('.02f')(d);
                },
            },
            interactiveLayer: {
                dispatch: {
                    elementMousemove: function(e){
                        console.log(e);
                     },
                }
            }
        }
    }

Here i have used elementMousemove fuction to get the values.Its working fine when we put some string inside console.log, but when i give the data i am getting, its not working,
I had given like,
dispatch: {
elementMousemove: function(e){
console.log(this.onChartDataMouseOver);
},
}
Where the values are from this.onChartDataMouseOver.
onChartDataMouseOver = (data) => {
    this.latlngMarker = this.chartDetails[data.index];
    this.lat = this.latlngMarker.latitude;
    this.lng = this.latlngMarker.longitude;
}

This displays as undefined in console when i mouse move over chart.
Previously i have used c3 chart in which i used the following,
    this.chart = c3.generate({
        bindto: '#chart',
        data: {
            onmouseover: this.onChartDataMouseOver,
        },
     });

And i got the desired output but here in nvd3 i am unable to get the data values.Here when i mouse move over the graph i am in the need to get the values from this.onChartDataMouseOver function.Kindly help me to get the values from data on mousemove.
Same thing asked in stackoverflow https://stackoverflow.com/questions/46970366/how-to-get-data-on-mouse-move-in-ng2-nvd3-chart

@ManirajMurugan, I'm not sure, but it could be your logic has an error, the code works fine. I might understand your situation better if i know your series, but for now this is my conclusion.
The event provides you the particular data from the series array. It does not provide you the entire array.
so when you try to access data.index it is bound to give you undefined.
dispatch: {
elementMousemove: (e) => {
this.onChartDataMouseOver(e.data));
},
}
and for the next onChartDataMouseOver function
onChartDataMouseOver(data) {
// Change logic here, try printing and see what data returns. don't use data.index
console.log(data);
}
Let me know how this goes :)

dispatch: {
elementMousemove: (e) => {
console.log(e.data);
},
}
@Prashanth-Thomas , For the above code i am getting e.data value as undefined even without using onChartDataMouseOver.

@ManirajMurugan  if you could share a sample of your series data, il try looking into it :)

In a vehicle tracking application, i am using playback component which means this component shows the vehicle previously travelled paths.
I am using the following,
// Function to listen the mouse over event
onChartDataMouseOver = (data) => {
  this.latlngMarker = this.chartDetails[data.index];
  this.lat = this.latlngMarker.latitude;
  this.lng = this.latlngMarker.longitude;
}

In this function i am getting the latidude and longitude of that particular point in graph on mouse move..
Here the lat and long values were there and no issue with it.
The issue comes with the chart options, because on mouse move in graph that particular location needs to be located in map.
For which i have used chart options inside ngOnInt as,
ngOnInit() {
this.options = {
chart: {
type: 'lineChart',
interpolate: 'basis',
height: 140,
showLegend: false,
zoom: {
enabled: true,
scaleExtent: [1, 1000],
verticalOff: true,
unzoomEventType: 'dblclick.zoom'
},
x: function(d){ return d.fixTime; },
y: function(d){ return d.speed; },
useInteractiveGuideline: true,
interactiveLayer: {
dispatch: {
elementMousemove: (e) => {
console.log(e.data);
},
}
},
}
}
}
Here for console.log(e.data) value is showing as undefined, i am in the need to know how to get the data inside this elementmouse move.


[CCI][BUG] Test support required for Python v3.9+

Description
Minor changes have been made. Test suite now run for python version 3.10 and 3.11
Issues Resolved
#323
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Hello @bl1nkker, as we can see here your DCO test is failing. Please merge all the commits into single commit and also see that your commit message includes a line like this  Signed-off-by: Author Name<EMAIL_ADDRESS>


[Spark-24024][ML] Fix poisson deviance calculations in GLM to handle y = 0

What changes were proposed in this pull request?
It is reported by Spark users that the deviance calculation for poisson regression does not handle y = 0. Thus, the correct model summary cannot be obtained. The user has confirmed the the issue is in
override def deviance(y: Double, mu: Double, weight: Double): Double =
{ 2.0 * weight * (y * math.log(y / mu) - (y - mu)) }
when y = 0.

The user also mentioned there are many other places he believe we should check the same thing. However, no other changes are needed, including Gamma distribution.
How was this patch tested?
Add a comparison with R deviance calculation to the existing unit test.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Jenkins, please test this.

ok to test

Test build #89699 has started for PR 21125 at commit 3c6a4da.

Test build #89699 has finished for PR 21125 at commit 3c6a4da.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89699/
Test PASSed.

Merged build finished. Test PASSed.

Test build #89723 has started for PR 21125 at commit da53b1a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89723/
Test PASSed.

LGTM, merged into master. Thanks.
DB Tsai | Siri Open Source Technologies |  Apple, Inc


Can't find variable: ARGON_PORT

I am working on getting the 4-vuforia tutorial starting.
The error I am getting is "Unhandled Error: Can't find variable: ARGON_PORT".
Any ideas?

This appears to happen when I reload the URL


Cow: Watch themedspawaco.com

Cow requests the watch of the watch_keyword themedspawaco\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

themedspawaco\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


return json

Hi, it would be great if the script responds with a json.
Like: benchmark.php?json

Done


Update LoggerFactoryExtensions.cs

Suggest to shorten the implementation

There is an argument made that there should only ever be one return statement at the end of a method. This makes a lot more sense for larger methods where having return statements in the middle can be confusing (a bit like a goto statement). These particular methods are super simple and I'd be happy with either implementation, so I don't think there is much value in accepting this PR. That said, I totally appreciate the effort.


Remove session controls from external users

Was this meant to be a remove app protection for external users?

Based on https://docs.microsoft.com/en-us/azure/active-directory/external-identities/conditional-access#mobile-application-management-policies

Reduce 502 to internal users, new policy to limit external users to browser on iOS/Android

New policy to limit external users to browser on iOS/Android will be 507

https://github.com/AlexFilipin/ConditionalAccess/commit/6d62d70aa03fc2fd51352f6bdb55f29c1dc80014
https://github.com/AlexFilipin/ConditionalAccess/wiki/Release-history#policy-repository-update-2021-03-05


Example added to 'For Each..' docs, to explain how to create & use custom collection classes

Actual Change
Change is self-explanatory.
I learned how to create such a custom collection class from web pages such as those stored here & here.
Further Improvements
Note that such custom collection classes appear to be referred to as 'strongly typed collection classes'. See here & here for examples of this. If this is the right terminology, it might be best to use it in the VBA documentation.
Really, the VBA documentation needs to contain documentation on the following things (that would support the added example):

[ ] "Attribute NewEnum.VB_UserMemId = -4".

[ ] The Property Get procedure NewEnum that returns an IUnknown object, and that can be used to create collection classes.

[ ]  Class-module attributes that you cannot see in the VBE.

[ ]  The process by which such custom collection classes are created (not just an example). It would also be useful to provide coding advice in regard to using such classes.

[ ] If all collection classes should implement a particular interface, this should be explained in some detail.

History
Spawned from ISSUE #977.
Please Note
Footnotes table
I tried as much as possible to code the Footnotes table using Markdown syntax (at least for the links.) Unfortunately, I couldn't get the formatting desired. In particular, I had problems with spanning cells, Markdown wrapping text with HTML paragraph tags, & with the alignments of texts. I therefore settled on using HTML instead.
I am slightly concerned that the links in the HTML will not work properly, as they point to '.md' files, rather than web-pages. If the HTML links won't work properly, you can optionally change the HTML to the following markdown code:
| **Footnotes** ||
| --- | --- |
| [**cc1**] | You can create a [class module](../../glossary/vbe-glossary.md#class-module) by choosing the _Class Module_ menu item from the [_Insert_ menu](../../reference/user-interface-help/insert-menu.md). You can rename a class module by modifying its properties from the [properties window](../../reference/user-interface-help/use-the-properties-window.md). |
| [**cc2**] | You can activate the [Export File dialog box](../../reference/user-interface-help/export-file-dialog-box.md) by choosing the [_Export File..._ menu item](../../reference/user-interface-help/file-menu.md#import-file-export-file) from the [_File_ menu](../../reference/user-interface-help/file-menu.md). |
| [**cc3**] | You can remove a class module from the VBE by choosing the [_Remove_ Item menu item](../../reference/user-interface-help/file-menu.md#remove-item) from the [_File_ menu](../../reference/user-interface-help/file-menu.md). |
| [**cc4**] | You can import an external class-module file, by activating the [Import File dialog box](../../reference/user-interface-help/import-file-dialog-box.md) by choosing the [_Import File..._ menu item](../../reference/user-interface-help/file-menu.md#import-file-export-file) from the [_File_ menu](../../reference/user-interface-help/file-menu.md). |

Other Commit
Note that other commit that used to be in 'this patch', has now been placed in another patch according to the direction given by @Linda-Editor. PR #979 has been created for that other related commit. Viewing this PR with the other PR together might be beneficial.

Docs Build status updates of commit 8b75130:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Language/Concepts/Getting-Started/using-for-eachnext-statements.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@MarkFern I merged this PR and then did an edit pass. Changes will be live later today. I've never used the Footnote section before, so not sure if this will render properly on our publishing system. If it doesn't, we may need to change the format of this section. I ended up using your markdown table instead of the HTML.

@MarkFern I just checked the results in the GitHub UI, and I think your footnotes will work. Let's see what happens after it goes live later today.

Changes are live and the footnotes are working: https://docs.microsoft.com/en-us/office/vba/language/concepts/getting-started/using-for-eachnext-statements


withDeleted not working with relations

fixes #4

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.782%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1194

Relevant Lines:
1194

💛  - Coveralls


Consider adding a button Tag Helper

We want a tag helper that we can wire up to work with form-action/handler/whatever it's called for pages.
<button asp-handler="delete">Delete</button>

It's a cool idea .. I already implement such a feature
<button asp-command="delete">Delete</button>

it would be nice if we can pass a param too
<button asp-command="delete" asp-command-args="23">Delete</button>

This is actually already done.

Oh really!! I don't know about it

Could you please refer to it?

Yeah, right here https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.TagHelpers/FormActionTagHelper.cs

Thanks it seems like what we have seen in MVC, it would be nice if extend this to have something useful for CRUD operation, such as
<button asp-command="delete" asp-command-args="23">Delete</button>

where delete is the page, 23 the id passed into the OnGet or OnPost


SSH Hardening Option

Changing the default SSHD_Config by adding a list of keys allowed under Ciphers and Keying will harden Open SSH.

Sorry for the delay in getting to this PR. I'm not against adding the code to set these 3 options but I am slightly concerned that the maintainability of this going forward. I'm no expert in SSH and the options specified here so I wouldn't know when these options become out of date and when they should be updated.
I'm also concerned that these options may only be supported by certain sshd versions and trying to install an older version with a newer algorithm would cause a failure in starting up sshd. If sshd just ignores algorithms it doesn't know about then that's good but I just don't know what the current behaviour is.
The last thing is I've tried to set up most of the config tasks to detect if the option is also specified. The current PR will just add these lines after the # Ciphers and keying key if they are not present but won't be able to detect if the option itself is already present. Normally this isn't a problem as this role is mostly used to install OpenSSH and the default config doesn't contain any of these entries but that may change in the future. We could add the regexp: '^#?Ciphers\s+' value so it will replace what is already there but I'm unsure if this is the behaviour we really want.

On the default state it is commented out. I considered doing a loop.

name: Change allowed ciphers in sshd_config_default
win_lineinfile:
path: '{{ opt_openssh_install_path }}\sshd_config_default'
insertafter: '^# Ciphers and keying'
line: "{{ item }}"
loop: "{{ opt_openssh_ciphers_keying }}"
when: opt_openssh_cipher_hardening
ignore_errors: '{{ ansible_check_mode }}'
Defaults:
opt_openssh_ciphers_keying:

Ciphers @.@.@.***,aes256-ctr,aes192-ctr
MACs @.@.@.***,hmac-sha2-512,hmac-sha2-256
KexAlgorithms @.***,ecdh-sha2-nistp521,ecdh-sha2-nistp384,ecdh-sha2-nistp256,diffie-hellman-group-exchange-sha256

Then you could just change ciphers with no PR.
But the way I wrote it,  you can just change ciphers in the play book as needed.
Let me know.
Sent from Workspace ONE Boxer
On Jul 10, 2022 6:33 PM, Jordan Borean @.***> wrote:
⚠ External Email
Sorry for the delay in getting to this PR. I'm not against adding the code to set these 3 options but I am slightly concerned that the maintainability of this going forward. I'm no expert in SSH and the options specified here so I wouldn't know when these options become out of date and when they should be updated.
I'm also concerned that these options may only be supported by certain sshd versions and trying to install an older version with a newer algorithm would cause a failure in starting up sshd. If sshd just ignores algorithms it doesn't know about then that's good but I just don't know what the current behaviour is.
The last thing is I've tried to set up most of the config tasks to detect if the option is also specified. The current PR will just add these lines after the # Ciphers and keying key if they are not present but won't be able to detect if the option itself is already present. Normally this isn't a problem as this role is mostly used to install OpenSSH and the default config doesn't contain any of these entries but that may change in the future. We could add the regexp: '^#?Ciphers\s+' value so it will replace what is already there but I'm unsure if this is the behaviour we really want.
—
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjborean93%2Fansible-role-win_openssh%2Fpull%2F19%23issuecomment-1179823815&data=05|01|anwilson%40vmware.com|55e6016f5d174da1af6a08da62cc92d1|b39138ca3cee4b4aa4d6cd83d9dd62f0|0|0|637930928032113310|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=eEJdVAJrzo%2BJ4ArW4lyPZzpjkt1JE48qhkoQkLn8g2s%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAZ2WHJTC2YVQDE246IRQ3MTVTNMT7ANCNFSM52GR6SFA&data=05|01|anwilson%40vmware.com|55e6016f5d174da1af6a08da62cc92d1|b39138ca3cee4b4aa4d6cd83d9dd62f0|0|0|637930928032113310|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=7%2FWrGD8cuMu%2FyEd6GR6Z59Um6wrWlut79a3DOQDA6I0%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

⚠ External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.


added update feature to student

Verified student update but more changes required

Verified student update but more changes required


Add qkv_proj to the saved name list

Update QKV offloading and rename remat policy.

Add qkv_proj to offloadable names due to query/key/value fusion
Rename remat_policy from qkv_proj_offloaded to save_qkv_proj_offloaded

For those models like "default" model don't have qkv_proj, it won't be recognized and there will be an error regarding it. So this CL needs to  be further polished.


clarify license to public domain

We need to clarify the license on the shell scripts.  Since they're so commonly cut-and-pasted, I'd just like to propose a public domain CC0 license for simplicity.  If you've contributed, could you please acknowledge this here in the comments field that you are ok for your patch to be under the CC0 license?

[x] @avsm
[x] @Chris00
[x] @dsheets
[x] @jonludlam
[x] @MagnusS
[x] @samoht
[x] @talex5

thanks!

Ping, @MagnusS ...

I agree for my contributions to be licensed under the CC0

Thanks everyone!


[SPARK-35912][SQL] Fix nullability of spark.read.json

What changes were proposed in this pull request?

Rework PR with suggestions.
This PR changes the behavior of spark.read.json  when nullability fields are false. the JacksonParser should return a default value instead of null for the primitive type when the nullability of the field is setting to false.
here is an example:
  val schema = StructType(Seq(StructField("value",
    StructType(Seq(
      StructField("x", IntegerType, nullable = false),
      StructField("y", IntegerType, nullable = false)
    ))
  )))
  schema.printTreeString()
  // root
  // |-- value: struct (nullable = true)
  // |    |-- x: integer (nullable = false)
  // |    |-- y: integer (nullable = false)

  val testDS = Seq("""{"value":{"x":1}}""").toDS
  val jsonDS = spark.read.schema(schema).json(testDS)

  jsonDS.show()

output before this pr:
+---------+
|    value|
+---------+
|{1, null}|
+---------+

output after this pr:
+------+
| value|
+------+
|{1, 0}|
+------+

Does this PR introduce any user-facing change?

No, only bug fix.
How was this patch tested?

New test.

Can one of the admins verify this patch?

cc @HyukjinKwon @cloud-fan @maropu @viirya

should return a default value instead of null for the primitive type

I don't agree with this. It's a correctness bug if an integer value is null in the JSON file but Spark read it as 0. We should fail at runtime. We can either do this null check in the jackson parser, or leverage the AssertNotNull expression.

Yeah, I think we should fail.

cc @MaxGekk FYI

Could you update the title and description, too?

kindly ping @HyukjinKwon

Run ./dev/lint-python
starting python compilation test...
python compilation succeeded.
starting black test...
black checks passed.
starting pycodestyle test...
pycodestyle checks passed.
starting flake8 test...
flake8 checks passed.
starting mypy test...
mypy checks failed:
python/pyspark/mllib/tree.pyi:29: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/tree.pyi:38: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/feature.pyi:34: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/feature.pyi:42: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/feature.pyi:48: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/feature.pyi:54: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/feature.pyi:76: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/feature.pyi:124: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/feature.pyi:165: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/clustering.pyi:45: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/clustering.pyi:72: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/classification.pyi:39: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/classification.pyi:52: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
Found 13 errors in 4 files (checked 314 source files)
1
Error: Process completed with exit code 1.

The check failure is not related to this pr.


Remove Expand Row Padding

How can I remove the expanded row padding?
Or add a class to the expanded row?
This is so that a nested table will align perfectly with the parent table columns
See the screenshot below.

What a coincidence, but I also came across this just about 2 days ago. I have tried everything so far, but have not found a solution to inject a class to the subtable. Once we had a class option, we could modifiy it how we want.
Now, I thought that maybe we can still manipulate it, once we can access it with CSS selectors somehow. However, the only option I found it selecting the table as such (without background) with td > .react-bs-table-container.
It would be great, it we could supply a class to the subtable.

Workaround:
Add
  headerStyle={{ display: 'none' }}
  tableStyle={{ margin: -8, borderRadius: 0, border: 0 }}
> ... </BootstrapTable>```
to the nested table (assuming it's react-bootstrap-table).

Hello forks, I'm wondering if this is helpful for your case, let me know your concern, and I'll support this feature if above solution is not good for you, thanks 👍

Thanks for your approach @ZephD :+1: . However, I need to modifiy :hover pseudo effects and others, which are not that easy with inline styles (if even possible). And anyway, we try to avoid the inline styling due to our reuse of the structures everywhere.
So, @AllenFang , I would be delighted if you could introduce expandBodyClass and expandParentClass l like in the example. It's more versatile. :thumbsup:

ok, let me mark it as in progress, I'll give a quick introduction for expandBodyClass and expandParentClass after my work off, thanks

.expand-row-body {
  > td {
    padding: 0 !important;
  }
}

 const options = {
    expandBodyClass: 'expand-row-body',
  };

Sadly, expandBodyClass affects the <tr> not the <td> that has the padding, resulting in the need to affect the direct child.
Also, the default padding: 8 for the tds is more specific and therefore overrides the expand body class, resulting in the need for !important.
However, this does fix the issue.

yes, expandBodyClass  will apply your custom class on the tr, but the padding was cause by td 👍
I think @ZephD 's solution is good and @PeterMerkert you may take a look on it 👍
and let me know if there's any concern, thanks

Yeah, the option should fix my issue, too. :+1:

ok, I'm going to close this ticket but feel free let me know if you want more support, thanks a lot 👍

Yes, I just double checked it, and @ZephD selector is working just fine. However, big thanks for the additional classes. They help a lot to customize @AllenFang  the table :-)
Simply great work!

@AllenFang Is there a way to align parent row and child row columns?


Image data is sent incorrectly to streetscape

I am trying to stream image data to streetscape. I have a very simple implementation:
if(this.dataForCurrentFrame){
       var array = this.nodeBufferToTypedArray(this.dataForCurrentFrame);
       xvizBuilder
                .primitive("/camera/test_stream")
                .image(array, 'png')
                .dimensions(128, 128)
                .position([1,1,1]);
}

data in dataForCurrentFrame variable is binary buffer data received over a TCP socket. If I use this to save it, it works fine, I can open the image.
fs.writeFile('image.png', imagedata, 'binary', function(err){
            if (err) throw err;
            console.log('File saved.');
        });

When I look at frame data that is being sent to streetscape it looks like this:
"/camera/test_stream":{"images":[{"data":{"0":255,"1":216,"2":255,"3":224,"4":0,"5":16,"6":74,"7":70,"8":73,"9":70,"10":0,"11":1,"12":1,"13":1,"14":0,"15":72,"16":0,"17":72,"18":0,"19":0,"20":255,"21":254,"22":0,"23":19,"24":67,"25":114,"26":101,"27":97,"28":116,"29":101,"30":100,"31":32,"32":119,"33":105,"34":116,"35":104,"36":32,"37":71,"38":73,"39":77,"40":80,"41":255,"42":219,"43":0,"44":67,"45":0,"46":3,"47":2,"48":2,"49":3,"50":2,"51":2,"52":3,"53":3,"54":3,"55":3,"56":4,"57":3,"58":3,"59":4,"60":5,"61":8,"62":5,"63":5,"64":4,"65":4,"66":5,"67":10,"68":7,"69":7,"70":6,"71":8,"72":12,"73":10,"74":12,"75":12,"76":11,"77":10,"78":11,"79":11,"80":13,"81":14,"82":18,"83":16,"84":13,"85":14,"86":17,"87":14,"88":11,"89":11,"90":16,"91":22,"92":16,"93":17,"94":19,"95":20,"96":21,"97":21,"98":21,"99":12,"100":15,"101":23,"102":24,"103 ... etc.

but in streetscape i get an
Uncaught (in promise) DOMException

it is located in this file:
https://github.com/uber/streetscape.gl/blob/master/modules/core/src/utils/image-buffer.js
when creating a new Blob(); The error says that data could not be decoded.
I am not sure where the actual error in this chain is. So I wasn't sure if should post the issue on streetscape repo or here. I decided to do it here because I do not like how that frame data looks like. It's an object, not an array, but I am pretty sure I send an array to xvizBuilder. If I try to print it out right before calling the builder it looks like this:
Uint8Array [
  255,
  216,
  255,
...
  21,
  21,
  21,
  12,
  ... 1816 more items ]

So I made it work by first converting the frame to glb using the xviz writer and then sending it
Now everything is fine.
Is sending images over json not supported?

We'll have to look at this more closely.  When sending the data as JSON it should be sent as a base encoded buffer not a binary array like that.  So it should be:
"/camera/test_stream":{"images":[{"data":"TWFuIGlzIGRpc3Rpbmd1aXNoZWQsIG5vdCBvbmx5IGJ5IG...

So the things that are possibly broken here are:

The encoder in pure JSON form (definitely looks broken)
The decoder of the JSON data (possibly broken)

Right now we have only been doing this in glb for efficiency reasons but we should definitely support both.

So I made it work by first converting the frame to glb using the xviz writer and then sending it
Now everything is fine.
Is sending images over json not supported?

Hi
Could you please share me the code snippet for converting the frame to glb using the xviz writer, as i am facing a similar issue, would like to try on this.


feat: Implement eth_getBalance method

Description

Get starknet address from the registry contract.
Call starknet rpc Ethereums balanceOf method with that address.
Return value with same format as ethereums.

Requirements

Unit tests have to be implemented.
Do not change the existing type structure

Completion Time
The issue is assumed to be completed in 5 days. If you need more time, please also specify that.

Also do not forget to check, if the address returns zero from the registry, then return zero. It might be a revert, so handle the revertion.

Also do not forget to check, if the address returns zero from the registry, then return zero. It might be a revert, so handle the revertion.

I'd like to take this serr

@Akashneelesh any updates?

@all-contributors add @Akashneelesh for code,tests


Export sanitizer settings in cargo CLI

Problem
Using sanitizers currently requires RUSTFLAGS this is not discoverable.
Proposed Solution
Expose sanitizer settings in cargo's CLI.
Notes
I've opened this as requested in https://github.com/rust-lang/cargo/issues/12739#issuecomment-2338147752

Could you provide more details on this as it doesn't provide enough background to understand requirements.  Which sanitizer settings?  How do you use them?

For instance, we currently set these flags in CI: RUSTFLAGS='-Zsanitizer=address -Clinker=clang -Cforce-frame-pointers=yes'
Having something like cargo test --sanitize=address would be more discoverable and easier to type.

As in you'd want cargo test --sanitize=address to mean RUSTFLAGS='-Zsanitizer=address or RUSTFLAGS='-Zsanitizer=address -Clinker=clang -Cforce-frame-pointers=yes'?
If the latter, why is that specific policy the one we should set on users behalf?  It especially seems worrisome to override the linker as that would be surprising.
Could you go into:

How do you use them?

What is important for us to understand is the requirements behind this.  You suggested this to be in the CLI but is that the right place?  Would this be better as a profile config?  Understanding how people would expect to use it will help in understanding how to abstract these rustc features.

I'm not super knowledgeable about sanitizer specifics but IIRC without the linker flag it doesn't work at all and without -Cforce-frame-pointers=yes the backtraces are messed up and it's hard to understand what went wrong, so it likely should be the defaul.

How do you use them?

Each sanitizer is ran in a separate process (because it requires different recompilation). I think it could work with custom profiles, though requiring everyone to set the same profiles (possibly polluting Cargo.toml) seems too much to me. If only one sanitizer existed I guess I would be more open to it but since there's multiple of them and people likely want to use more than one it's quite some boilerplate.


Start making multiplex bodies work

Currently mostly refactoring and setup, will follow up with more changes, probably should not be merged for now.

Thanks! Most of this work has gotten included :)


Low performance when transferring long arrays from PSSession

I faced with the performance problem when I tried to recive a long array (e.c. file system entries) from remote pssession. The transfer of such an array takes a long time. Unfortunately it is obvious that Powershell has problems with it.
Steps to reproduce

$session = New-PSSession localhost
# or
# $session = New-PSSession -HostName localhost -UserName <username>

$arrayLen = 1024000
Measure-Command{
  Invoke-Command -Session $session -ScriptBlock {
    Write-Host ("Preparing test array {0} elements length..." -f $using:arrayLen)
    $global:result = [Byte[]]::new($using:arrayLen)
    [System.Random]::new().NextBytes($result)
  }
} |% {Write-Host ("Completed in {0} sec`n" -f $_.TotalSeconds)}

Measure-Command{
  Invoke-Command -Session $session -ScriptBlock {
    Write-Host ("Transfer array ({0})" -f $using:arrayLen)
    return $result
  } | Out-Null
} |% {Write-Host ("Completed in {0} sec`n" -f $_.TotalSeconds)}

Measure-Command{
  Invoke-Command -Session $session -ScriptBlock {
    Write-Host ("Transfer same array nested in a single object")
    return @{array = $result}
  }
} |% {Write-Host ("Completed in {0} sec`n" -f $_.TotalSeconds)}

Expected behavior
less than a second.

Actual behavior
Preparing test array 1024000 elements length...
Completed in 0.0211385 sec

Transfer array (1024000)
Completed in 48.0192142 sec

Transfer same array nested in a single object
Completed in 0.0990711 sec

Environment data

> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.0.1
PSEdition                      Core
GitCommitId                    v6.0.1
OS                             Microsoft Windows 10.0.17074
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Previous versions have the same problem

Use return ,$result, otherwise you are transferring 1024000 individual bytes instead of one byte array.

/cc @PaulHigin @SteveL-MSFT   It seems bad UX in remoting.

@iSazonov
IMHO, not really related to remoting. You can see similar difference in time without remoting envolved:
$Array = [byte[]]::new(1024000)
(Measure-Command { ,$Array | Out-Null }).TotalMilliseconds
(Measure-Command { $Array | Out-Null }).TotalMilliseconds

@PetSerAl Thanks for the sample! I see that pipeline add 50% time (I believe it is expected) but in original message with remoting we are slow in many times.

@PetSerAl Thanks for your explanation! I've understood why this happens, but I think that this behavior is not obvious and should be corrected

The current behavior is "expected" in that it's a difference of passing an array vs passing elements of an array through the pipeline.  Certainly we should continue to improve the performance of the pipeline.


flyctl: 0.1.147 -> 0.1.148

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/superfly/flyctl/releases.
meta.description for flyctl is: Command line tools for fly.io services
meta.homepage for flyctl is: https://fly.io/
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.1.148 with grep in /nix/store/w7996zgwzqjdgfq1sdvm7ylxxhc7a4za-flyctl-0.1.148
found 0.1.148 in filename of file in /nix/store/w7996zgwzqjdgfq1sdvm7ylxxhc7a4za-flyctl-0.1.148

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
flyctl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/w7996zgwzqjdgfq1sdvm7ylxxhc7a4za-flyctl-0.1.148 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A flyctl https://github.com/r-ryantm/nixpkgs/archive/931224b27591e115fb8ac8f867235d84ce35a37c.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/931224b27591e115fb8ac8f867235d84ce35a37c#flyctl

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/w7996zgwzqjdgfq1sdvm7ylxxhc7a4za-flyctl-0.1.148
ls -la /nix/store/w7996zgwzqjdgfq1sdvm7ylxxhc7a4za-flyctl-0.1.148/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

flyctl

Maintainer pings
cc @adtya @jsierles @techknowlogick for testing.

Result of nixpkgs-review pr 287434 run on x86_64-linux 1

1 package built:

flyctl


Added code that implements the lnurl lud03 and lud08 spec.

Very nice :-)
ACK https://github.com/Blockstream/greenlight/pull/241/commits/c5c304b0359abd87039b03be31563dedaa8ed038

ACK https://github.com/Blockstream/greenlight/pull/241/commits/c8a737b135c9d000ca6597d15fbd3741c72d8389


Investigate AGC, REG_7E

I started looking into the AGC regs as the register table suggests there are tunable params for Rx (IF) and Tx (MIC). As I can see #217 touches code I've made changes to, it may cause a merge conflict.
I'm currently somewhere that has no AM traffic so my changes are untested. Should I raise a PR anyway?

I started looking into the AGC regs as the register table suggests there are tunable params for Rx (IF) and Tx (MIC). As I can see #217 touches code I've made changes to, it may cause a merge conflict.
I'm currently somewhere that has no AM traffic so my changes are untested. Should I raise a PR anyway?

No never do any PR that is not fully tested.

Hi, The AGC code if blocks are just swapped in my PR, and the uint8_t Value argument became a boolean, as the function wasn't doing much with Value except checking for 0 or 1.

The current code keeps AGC disabled in both cases. It matched the DisableAGC code from RT-890's OEFW.

No never do any PR that is not fully tested.

Understood. The worry is it will go stale and cause problems later on. Should I instead hide it behind a compile flag so it doesn't unintentionally change current behaviour?

gggrrr, google have just decided that github mail is all spam and so has been blocking it all for a few hours now :( .. just going through it all, bare with me.
I don't think google approve if github :(

Just tried your fix, seems the AM fix is still needed :(
Keep trying though, maybe you'll find the correct register configuration to fix the complete lack of AM agc .. be nice if you find the solution :)

Just tried your fix, seems the AM fix is still needed :(

The potential 'fix' is commented out due to my inability to test it at this time.
My last PR only brings parity with fagci's FW since we weren't making use of AGC at all. I can't play with registers again until I'm surrounded by air traffic again.

I noticed that just after I sent the message, my fault
just tryng now

I noticed that just after I sent the message, my fault
just tryng now

Be aware that enabling it will need a higher squelch setting due to it trying to boost weak signals. I'd suggest disabling the option that makes squelch more sensitive since it affects noise thresholds as well.

hmmmm, interesting result using the signal generator !
Just going to leave the radio scanning to find some AM transmissions - can be rare for me too here in shropshire.

hmmmm, interesting result using the signal generator !
Just going to leave the radio scanning to find some AM transmissions - can be rare for me too here in shropshire.

I had to reduce the 'fix index' from max to min as my radio was finding unintelligible noise in freqs that should actually have activity. That was before I disabled the squelch sensitivity compile option. Hopefully you find something that makes it worth tweaking.

I have two UV-K5(8)'s, one seems good on AM and the other has the distorted AM back, same firmware, no AM fix code compiled in, using the AGC enable.
Interesting. Don't know why one works and the other doesn't, wonder if the BK4819 chips are different versions.

I have two UV-K5(8)'s, one seems good on AM and the other has the distorted AM back, same firmware, no AM fix code compiled in, using the AGC enable.
Interesting. Don't know why one works and the other doesn't, wonder if the BK4819 chips are different versions.

I was looking at BiliBili recently and I suspect there was an audio change to units made after July. I have a K5(8) from June and it's horrible, I have a second one coming that's with the courier.
My stock 5R+ wasn't distorted when I last tried. My curiosity wants to know if it's more than a case acoustics change.

I've just noticed the REG_7E values are swapped. '1u << 15' should be in EnableAGC, '0u << 15' in DisableAGC (not called for now). I had them commented out.

I'm going to document my results here, now that I know I can hear air traffic.
The filter appears to affect it most.
000 = clicking, voices inaudible
...
100 = whistling, voices understood

TL;DR
BK4819_WriteRegister(0x7E,
(1u << 15) |      // 0  AGC fix mode
(2u << 12) |      // 3  AGC fix index
(5u <<  3) |      // 5  DC Filter band width for Tx (MIC In)
(3u <<  0));      // 6  DC Filter band width for Rx (I.F In)
Tx filter bandwidth can be adjusted at a later date, it's outside the scope of what I aimed to achieve.

Wonder where you found the filter cutoff vs value details ? .. I've not found those details anywhere I don't think :(
Not sure what you mean "AM shouldn't use oscillation" ?

Wonder where you found the filter cutoff vs value details ? .. I've not found those details anywhere I don't think :(

I inferred the filter values from REG_2B. I can only assume the same layout, based on their defaults.

Not sure what you mean "AM shouldn't use oscillation" ?

I'm learning on the job. I came across this:
"On sets having the AM bands in addition to FM, there will be two IF transformers between each stage of IF amplification. [...] The oscillator section of the AM mixer-oscillator will be disabled, and the mixer section used as the first FM IF amplifier."

oh I see.
I think their may be some misunderstanding you have about what they are referring to through the super-het chain.
All RF mixers need a local oscillator, the mixer mixes the RF with the local osc to produce an output at a difference freq. without an osc nothing works.
This is all part of very basic RF theory you learn during college etc.

Yes definitely, we ONLY learn by playing, trial and error etc.

I've not long realised I've had one of the LNA registers set wrong, have fixed that now.

I've not long realised I've had one of the LNA registers set wrong, have fixed that now.

I was playing with it before I noticed your commit. I told someone already I should stop but I can't help myself.

Keep playing !

I get things wrong all the time, ask anyone lol  all engineers/coders do.

Not wrong, just differences of opinion.

Seeing as I now properly understand how this register works, I think this issue should be closed. I'd be interested to know how Tx is affected between AGC being on and off, but that's for another day. I appreciate the time and effort spent in looking at this, and the resultant changes.
Thank you.

Don't give up !
The BK chip is a mystery to us, we don't know how to properly configure it as we don't have the details on it's registers, wish we did.
I was battling with the gain/AGC registers for ages before I too gave up and decided to write my own code to overcoming our inability to configure the AGC inside the chip.
It may be that the firmware inside the BK chip has yet to be fixed/updated to deal with things like AM, but there's nothing we can do about that, but it might explain why my two radios react differently to same register settings.

I wasn't planning to give up, just a deflating balloon moment finding out it didn't get the results I was looking for. Since other reg values they reference now differ between 'disabled' and 'enabled' state (they were the same before I touched it), maybe they could be useful outside of airband. I think the only main difference I found with fagci's code was PGA gain. Looking at bk4819.c, lines 316 and 355, it's minor but would affect Rx.
Unrelated, my second K5(8) arrived today and it differs to my first. The tinny sound is gone and the aluminium backing plate is now magnesium. I'll have to back up the EEPROM and see what else is different.

REG_62 is yielding interesting results. I have two radios set up, each with different AGC on/off settings. I'm getting 20dB(!) difference between them, the one with AGC appears to be attenuating the signal.
I hope to carry this on tomorrow when there's air traffic about. There may still be hope for this rabbit hole.


[PL] - big update for current intents and added new intents for cover, valve, vacuum, media_player, person, todo, weather and more

@witold-gren Let me know when the PR is ready for a review, I can see you are still doing some commits.

@Uriziel01 PR is ready to review

@Uriziel01 PR is ready to review

Nice, I'll have a look in the evening.

 Sorry for the delay, I have a 3 week baby, hard to find any free time 🙂

@Uriziel01 congrats and condolences at the same time, you won't have any free time for the next 10 years at least (speaking as a father of two ;)

Guys.. come on.. I have four children.. 😉 And as you can see, I'm not short on time..
Back to the business. I updated the person entities to make them more flexible when asking questions (I followed PR as example https://github.com/home-assistant/intents/pull/1779). Today is the last day of my updates. I'm leaving tomorrow, so unfortunately I won't be able to update this PR. I won't be available until Monday.

Hey @Uriziel01 @synesthesiam,
since there are still no comments or urgent requests for any changes, please include this PR in the master version, as I would like it to be available in today's release. We can make some changes in the next PR if they will be required. I will also be unlocked to work on sensors and binary_sensors sentences.

Hey @Uriziel01 @synesthesiam, since there are still no comments or urgent requests for any changes, please include this PR in the master version, as I would like it to be available in today's release. We can make some changes in the next PR if they will be required. I will also be unlocked to work on sensors and binary_sensors sentences.

I think I for once agree with that sentence, I'm going through it aws but in reality 80 files at the same time changed and refactered
within 61 commits makes it almost unreviewable  properly. If you merge it before I'm finished that's fine, if I'm first and I find anything in this enormous pile that's also good. Win-win 🙂

Sorry, but unfortunately I don't have permission to merge any PR related with polish language.

@witold-gren I've finished the very initial review, I'm sure there is more to fix but even going through it just with just a first glance took almost an hour and because the webUI of GitHub was not happy when jumping around through 6k+ lines of code in the diff 😁 It will have to cut it for now, just ping me when finished fixing/answering and I'll merge it, if I've missed something (and I'm very sure I did missed more bugs) I hope we will fix it on a later iteration as you've proposed.  At least that's what I'm hoping for, time will tell 😉

Like I mentioned, now I'm unavailable until Monday. Big thanks for quick review. However, since this was not added to this version it not make a sens to close it with potential bugs. Now you can work on this PR calmly, let me know when you check everything and I will make corrections. 💪🏻

@Uriziel01 I improved the expressions related to Media Player so that there are no contains incorrect sentences. Take a look at this place.


Remove not working or unnecessary files

For example:

AdditionalOutput.jl
EnergySaving.jl

and remove Plots from Project.toml.
It might be a good idea to include all functions from TrainRunCalc.jl in TrainRun.jl and remove TrainRunCalc.jl.

done with https://github.com/railtoolkit/TrainRuns.jl/commit/e2842157dae9f8c4b60b8ed24328fcb0a19e67bd


[UT] Fix unstable RollupJobV2Test

What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] refactor
[ ] others

The PR https://github.com/StarRocks/starrocks/pull/8758 mistakenly removed one line codes, which will make the RollupJobV2Test unstable.

run starrocks_admit_test


[0.9.6.] Windows to build trafficmanager fails

Hi there,
I'm new to Carla. I just built Carla from source. Everything is fine except the trafficmanager executable cannot be found in the place the docs say it should be.
'make trafficmanager' gives "nothing todo for this target"
What might be wrong?
Cheers,
Michael

Obviously there is no target in the makefile for the TrafficManager and also no Batch File in /Utils to build it. I don't know the reason for that either


[ #4943] Update from feedback on Gravitino CLI demo

What changes were proposed in this pull request?
Feedback arising from the demo including:

asking users are you sure to any dangerous operations
adding a --force option
remove --metalake from examples
update documentation

Why are the changes needed?
Update from demo.
Fix: #5537
Does this PR introduce any user-facing change?
Delete commands and rename metalake now ask the user are you sure.
How was this patch tested?
Locally.

@shaofengshi I've merged main into this and it ready for review.

Please update the PR title to reflect what you really did. Also #4943 doesn't reflect what this PR is, please create a new issue for this.

Created issue #5537 for this PR and updated title.

@shaofengshi / @jerryshao waiting for further comments or merge from you


Fix typo in README.md

This PR fixes a typo in the Reference Properties section of README.md.

Thanks!
If you're using this gem, maybe take on https://github.com/mongoid/mongoid-cached-json/issues/27? I can help review.


Allow skipping compile source build phase for bundles

Motivation
We've added a resource bundle to our app and this caused the following issue while uploading to the ASC:

ERROR ITMS-90171: "Invalid Bundle Structure - The binary file 'XXX.app/YYYY.bundle/YYYY' is not permitted. Your app can't contain standalone executables or libraries, other than a valid CFBundleExecutable of supported bundles. Refer to the Bundle Programming Guide at https://developer.apple.com/go/?id=bundle-structure for information on the iOS app bundle structure."

We solved this by removing CFBundleExecutable parameter from the bundle’s Info.plist file (as per default behaviour described in xcodegen docks) and Compile Sources build phase from the its target. However, when we use xcodegen, the Compile Sources build phase comes back, even though it’s empty.
Judging by the source it seems impossible to make xcodegen skip Compile Sources unless the target’s type is hardcoded in canSkipCompileSourcesBuildPhase.
This issue is very similar to https://github.com/yonaskolb/XcodeGen/pull/149
Solution
I propose adding bundle to the list of types whose canSkipCompileSourcesBuildPhase property returns true.

Great, thanks @nkukushkin! Could you add a changelog entry as well?

Done 👌


Don't send attributes destination.ip and destination.port from HTTP filter.

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

/lgtm
/approve

Why not, can you add an explanation here?

This destination.ip contains upstream host ip, not envoy's own IP address. And destination.port contains upstream host port, not envoy's own port.
There are some Istio tests failures, where Mixer is supposed to get destination.ip attribute, and the value in that attribute should match what Pilot has set. Somehow that attribute is overwritten. After discussed with @qiwzhang, I revert this change to see if the tests would pass.
I discussed with @wattli about mTLS connection monitoring, customer would like to get a global view about which service-to-service communication is mTLS enabled. I am going to implement this feature first. And make improvement after that, such as counting mTLS connections between services.


[AutoRelease] t2-storagemover-2023-07-11-41793(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/4330
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=5935

issue link:https://github.com/Azure/sdk-release-request/issues/4330


The model list's download progress doesn't match that of the log files

Describe the bug

The model list's download progress doesn't match that of the log files
Steps to reproduce
https://github.com/user-attachments/assets/c1756520-4924-43f6-979f-4a5140058417
Expected behavior

Environment

GPUStack version: main(2a39cd7)
UI version: 5c372bb
OS: macOS 14.6.1
GPU: Apple M2, 24G

Additional context
Add any other context about the problem here.

The model consists of a total of 9 shards; when downloading the ninth shard, the model's progress calculation restarts.

Environment

GPUStack version: main(44fee25)
OS: macOS 14.6.1
GPU: Apple M2, 24G

Test Result:

The progress display issue after resuming the download from the breakpoint: pass
download progress issue of the sharded model files: https://github.com/gpustack/gpustack/issues/254


When you change permissions for the app it kills the current design studio and app restarts

fixed an issue with DS not working b/c it crashed mid studio

@sshaar08 let's look at other apps to see if this is how they do it elsewhere


PowerRename shows no instant previews??

Microsoft PowerToys version
0.67.1
Installation method
GitHub
Running as admin
No
Area(s) with issue?
PowerRename
Steps to reproduce
i can see no preview if i enter text or $YYYY
✔ Expected Behavior
PR must show instant preview of done edits before
❌ Actual Behavior
i can see no preview if i enter text
Other Software
No response

Try the latest version (0.73.0) I am able to see instant previews
/needinfo


VCD dumps not generated in certain conditions

It seems single-cycle runs won't generate a VCD dump.
Also, report() needs to be called, which isn't obvious and also includes console printing. Perhaps separate that functionality into finish / write_vcd / report_statistics (which would return a case class, leaving it to the testdriver to report it)?

@ducky64 Is this still an issue? I agree with a cleanup but it seems like this is really a general Chisel simulation API issue, and the specifics of treadle can be changed to be in line with whatever we need.

@ducky64 can you point me at an example. I tried to reproduce locally in treadle but could not.


Trim whitespaces in setext headings

Fixes https://github.com/raphlinus/pulldown-cmark/issues/344.

@raphlinus this is also a low risk PR

:raised_hands:


store: implement rebalance process

If we add new store node/s to a cluster, they will boot up empty. There should be some process by which they can receive some of the data set from other nodes. (Needs design thinking.)

Curious whether you already had any thoughts on how to ensure that one doesn't end up rebalancing two or more replicas of the same record onto the same node?
 Especially if you end up having to break up segments again.
One hits a very similar case with any kind of repair procedure AFAICS.

We already do per-record checking in all consumption, merge, and compaction operations, so I guess this wouldn't be any different.

A use case: I am designing a system that has a control cluster (running in some kind of cloud, like AWS, GCE or similar) comprised of three nodes, each running identical setup including zookeeper, galera and some other software irrelevant to this discussion. Node OS images are prepared using packer. Any non-trivial configuration changes are done by preparing a new OS image and performing a rolling upgrade, i.e. recreate the first node with the new image, wait for it boot and join the other two nodes; then similarly recreate the second and the third node. During this sequence, zookeeper on newly created nodes pulls entire state from other nodes. Thus, upon completion, we have three shiny new nodes that all have the state of the pre-update cluster (note: this has been practically tested). As far as I understand galera also has similar behavior (not tested yet).
I plan use oklog, and hoped it would have a similar behavior, but having seen this issue, I understand it does not.
Whenever/if oklog gets to have such functionality, it would be nice to have some API to monitor synchronization progress so as to know when it is safe to proceed with the next node.
Meanwhile, is there any manual step (other than backing up oklog's data directory) that would make this use-case possible?


Workaround for ambiguous variable names

Depends on PR #268
Workaround for #186, #106, #83

Going to close this out for now, we may revisit once we get closer to announcing a 1.0 release. I'd really rather not implement workarounds, instead I'd favor trying to make sure things get fixed upstream.


ECR: fix error location when specified wrong io_name

This PR makes ECR wrap loc pragma and expression by #<loc:push> and #<loc:pop>.
For example, there are the following two files.
foo.cr:
require "ecr"

io = IO::Memory.new
ECR.embed "./foo.ecr", ioo
io.to_s STDOUT

foo.ecr:
<% foo = 1 -%>
<%= foo %>

crystal run foo.cr will fail because ioo is wrong io_name, it should be io.
It shows such a error message before this PR:
$ crystal run foo.cr
Error in foo.cr:4: expanding macro

ECR.embed "./foo.ecr", ioo
    ^~~~~

in foo.cr:4: expanding macro

ECR.embed "./foo.ecr", ioo
^

in macro 'embed' /crystal/0.27.0/src/ecr/macros.cr:69, line 1:

>  1.     {{ run("ecr/process", "./foo.ecr", "ioo") }}
   2.

expanding macro
in ./foo.ecr:2: undefined local variable or method 'ioo' (did you mean 'io'?)

<%= foo %>
^~~

This location looks wrong. <%= foo %> is irrelevant to ioo.
After this PR, crystal run foo.cr shows expanded macro source.
$ crystal
Using compiled compiler at `.build/crystal'
Error in foo.cr:4: expanding macro

ECR.embed "./foo.ecr", ioo
    ^~~~~

in foo.cr:4: expanding macro

ECR.embed "./foo.ecr", ioo
^

in macro 'embed' /crystal-lang/crystal/src/ecr/macros.cr:69, line 1:

>  1.     {{ run("ecr/process", "./foo.ecr", "ioo") }}
   2.

expanding macro
in macro 'embed' /crystal-lang/crystal/src/ecr/macros.cr:69, line 1:

>  1.     {{ run("ecr/process", "./foo.ecr", "ioo") }}
   2.

expanding macro
in macro 'macro_4521946960' expanded macro: embed:1, line 2:

   1. #<loc:push>#<loc:"./foo.ecr",1,3> foo = 1 #<loc:pop>
>  2. ioo << ""
   3. #<loc:push>(#<loc:"./foo.ecr",2,4> foo )#<loc:pop>.to_s ioo
   4. ioo << "\n"

undefined local variable or method 'ioo' (did you mean 'io'?)

I think it is better than old.
Thank you.

This might come as a later PR, but I think we should not see the #<loc:....> pragmas in the trace, they are just clutter for the user reading it

rebased


fix:  added support for scrollableView

Describe your changes
Added support for scrollableView
Screenshots [Optional]
Issue ticket number and link
Closes #645
Checklist before requesting a review

[ ] I have performed a self-review of my code
[ ] I have added tests
[x] I have added a changeset pnpm changeset add
[ ] I have added example usage in the kitchen sink app

This seems a bit unintuitive for web pages to not be scrollable by default. This will require uptaking changes on atlas side @anserwaseem @sibteali786.
@vusters what's the reason that the flutter runtime is not scrollable by default?


fix: drag and drop issue on firefox

Fixes #3094
Changes I made in this PR -
This was actually a one line change, prettier makes this look like I have made some huge changes. Anyway, the issue as shown in the video on #3094 clearly shows that the image icon was getting dragged on firefox which was causing the drag event listeners to not fire at all. To avoid this, initial steps had already been taken using CSS property user-drag:none;, however when I tried it on firefox, I found out that there was no such property supported by firefox as shown in this screenshot.

Long story short, I added a pointer-events: none; to the image icon and that did the job perfectly.
Screencast -
Basically proof that it works...
https://user-images.githubusercontent.com/52719271/171304140-48d09283-b869-442f-8ea2-356a2bf94ed3.mp4

Coverage remained the same at 81.785% when pulling afd8bd03ec994300cf7bc00fafd685a2201770f5 on Jaagrav:fix-drag-and-drop-firefox#3094 into a6180262927e148b97c305224971097b41d17806 on CircuitVerse:master.

@vedant-jain03 sorry to mention you but maybe the team wasn't notified of this PR? So I'm requesting a review from you.

@Jaagrav Thanks for the PR.
The implementation LGTM but the code change is much large to accept from my perspective.
WDYT @gr455 ?

@Jaagrav Thanks for the PR.
The implementation LGTM but the code change is much large to accept from my perspective.
WDYT @gr455 ?

I understand, but it's actually my linter that caused this by adding extra spaces, anyway have fixed it.

Cool I trust you @vedant-jain03. Merging :tada:


If sending read receipts is disabled, we should clear notifs whenever we open the app

We need to check the 'dontSendReadReceipts' synced setting in accountData, and if so, clear the app's notifs somehow at launch.
This solves the concerns in https://github.com/turt2live/matrix-react-sdk/commit/1bdae495fa384a5d51b4d8665b258a4bd54332b6.
See https://github.com/vector-im/riot-web/issues/2527

actually, we need a more generic mechanism for users to clear their notifs serverside otherwise we see stuck notifs on all clients. keeping this bug open to track that.

Related: https://github.com/vector-im/riot-android/issues/339


All ScanReportFields are now set to 'Pass from Source' by default

This PR sets all ScanReportFields to "Pass from Source" by default (on scan report upload). This ultimately changes the number of items in the data dictionary list view (and therefore what data is sent to NLP).
This change has been implemented because it's probably better to allow users to select which field values they should let through, rather than having them filter out everything that they don't want to send to NLP (i.e. is quick to let data through than it is to filter out everything that isn't required)

Hi @py5gol, set pass_from_source=True at the model level as requested. I've also merged master with this branch so you should be good to merge if you're happy with the latest change (y)


fix/update .goreleaser.yaml file

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR fixes the issue in goreleaser.yaml file - update version and replace depracated values in snapshot
Which issue(s) this PR fixes:

Fixes #206
Does this PR introduce a user-facing change?:

NONE

Thanks @subrajeet-maharana !
Did you test the github workflow works as expected with this change?
/ok-to-test

Hi @LiorLieberman,
Yes. The test were successful. Please find the images attached.

Sweet! thanks for picking this up
/lgtm
/approve


docs: document supported JSDocs syntax

The doc website currently only supports a limited subset of JSDocs tags and syntax, and the vibe is that there is much desire to maintain a larger set of support (REF: https://github.com/denoland/doc_website/pull/226).
For transparency, could we consider adding the supported tags / syntax to the docs website (or manual) so it is clear to users what the docs website supports? Namely:

Inline descriptions
Fenced code blocks
@param
@return
@link
@deprecated (only at the beginning of a comment https://github.com/denoland/doc_website/issues/227)
Types {type} syntax not supported

At the moment it is possible to misinterpret the likes of<EMAIL_ADDRESS>which have examples using unsupported syntax (types) and tags (@returns), to then think https://doc.deno.land/ will also support this in it's generated documentation. Finding that it doesn't support some of the common JSDocs tags / syntax can be confusing for users as it is unclear whether there is an error in their JSDocs or if it is a limitation of the docs website itself - e.g. https://github.com/denoland/doc_website/issues/217

I’m not sure if this is an issue with the deno doc parser or with the html rendering done here...

This documentation could be added to the https://doc.deno.land/ homepage, or to the manual.
As an aside, in places where https://doc.deno.land/ is promoted, we should also consider writing examples to reflect the actual JSDocs support.
For prior art / precedent, see how TypeScript documents the subset of JSDoc that it supports https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html, and how TSDoc documents the subset of JSDoc that it supports https://tsdoc.org/ (e.g. doesn't support @return unlike https://doc.deno.land/, opting instead for @returns - REF: https://github.com/denoland/doc_website/issues/151).

I’m not sure if this is an issue with the deno doc parser or with the html rendering done here...

I believe all deno doc does in regards with doc.deno.land is give it the JSDoc stripped of comments and *'s.

I’m not sure if this is an issue with the deno doc parser or with the html rendering done here...

I believe all deno doc does in regards with doc.deno.land is give it the JSDoc stripped of comments and *'s. I'll look into PRing support for @ignore tags.

Ah that was a quote from https://github.com/denoland/doc_website/issues/217 😅