Remove dummy gas price and robustify gas budget in tests

Description
For Reviewers: meat is in non-test files.
Today the gas budget in our tests are hardcoded and does not adapt to dynamic gas prices. This has caused several problems in the past. This PR is the first step to robustify the gas budget in our tests. In particular, this PR:

remove DUMMY_GAS_PRICE and all functions using it
use reference gas price and GAS_UNIT ffwhen making transactions
change the default reference gas price to 100
fix a few flaky tests

Caveat:

This change may break load tests
So far the GAS_UNIT is conflated with storage price, which is costly for genesis objects. In a higher gas price setting e.g. 1000, some tests would fail because the Gas is too high.

Test Plan
Tests

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

I think the two things we need to protect against from future test failures are

Budget <= 50 SUI
GasCoin value > Budget

Maybe the way to make tests more robust is to just use MaxBudget and GasCoin base value is always > 50Sui for all tests that are not testing gas specific things. Outside of that maybe we need to factor in COMPUTATION_COST + STORAGE_COST and properly calculate expected gas value and budget value .
Also is there any reason we can't use RGP 1000 everywhere as the baseline?

Also is there any reason we can't use RGP 1000 everywhere as the baseline?
The current GasUnit is so large (because storage price is expensive for genesis objects) that RGP == 1000 would break a few tests by exceeding MaxGas. I can try to tune the gas unit down though because storage price is flat in most of our tests.

Maybe the way to make tests more robust is to just use MaxBudget and GasCoin base value is always > 50Sui for all tests that are not testing gas specific things. Outside of that maybe we need to factor in COMPUTATION_COST + STORAGE_COST and properly calculate expected gas value and budget value .

I thought about using MaxBudget but feel like it's so large that it may hide some issues. For example, we didn't notice a lot of gas issues until public traffic in previous waves, even though we did make some transactions using very wealthy accounts. This was exactly because these accounts are very wealthy so these problems are covered.
In terms of considering storage cost, that's also a tons of work which I'm not sure we want to spend time on at the moment (i'm not a gas expert, as you know) . This is also why it's currently conflated with GAS_UNIT.


In Windows OS, terminal hangs if I try to show a sampleset a second time

If I try from a CMD terminal of a Win 10 OS running iPython to use dwave.inspector.show(sampleset) twice, the second attempt causes the terminal to hang and it needs to be closed (CNTR-C and closing the browser window do not end the task).
This happens for both Pegasus and Chimera graphs.
Brower: Chrome version Version 88.0.4324.182 (Official Build) (64-bit)

Verified. It happens on Linux as well.


Vbulletin Password capture

Firstly let me thank you for this work.  Its a fantastic project and very interesting.   My questions is this:
Vbulletin uses javascript to hash the password a few times before its submitted in a POST request.  any insight on how to intercept that javascript event and capture the plain text password as entered?
<form class="block vbform" method="post" action="login.php?do=login" onsubmit="md5hash(vb_login_password, vb_login_md5password, vb_login_md5password_utf, 0)">
function onsubmit(event) {   md5hash(vb_login_password, vb_login_md5password, vb_login_md5password_utf, 0) }

I think for now it would only help to dynamically modify the vBulletin javascript and have it send vb_login_password value in an extra POST field, that Evilginx could intercept.

Closing for now - this could probably be solved when Javascript injection feature is implemented sometime in the future.

FYI
I've got javascript injection working, but still was having issues getting the credentials....
I was able to capture credentials by oddly enough commenting out the md5 function for mimetype text/html.   But it still logs in to proxied site without any issues and captures the credentials, not cookies though.   I have a specific site in mind that I am working with that does not use 2 factor auth so not TOO concerned about the tokens.
Is there a way to turn off the unauthorized redirect for short periods of time ?
I would gladly open a new issue if you'd prefer..
thanks again for your time :)


Use a better monotonic clock source on Darwin

CLOCK_MONOTONIC can jump backwards, but CLOCK_MONOTONIC_RAW won't.
Ref: https://reviews.llvm.org/D74341

Doesn't seem to solve the timer test issue but a good change nonetheless I think. @bnoordhuis PTAL!

I think you misread the llvm change. It talks about uptime vs. monotonic, not raw vs. not-raw (cooked?)
I'd stick with CLOCK_MONOTONIC because that aligns better with other platforms.

I did check a few sources, I can double check, but if the current implementation doesn't jump when time changes or on sleep we should be fine indeed!

The difference between CLOCK_MONOTONIC and CLOCK_MONOTONIC_RAW is that the former smooths out forward time changes (clock moving forward, e.g., DST) whereas the latter simply "jumps" into the future.
What your preferred behavior is depends on the situation but, since we use CLOCK_MONOTONIC on other platforms, I wouldn't diverge from that on macos.


feat: added Immervision post

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix to add exampleHttpHeaders to the DocService debug page

Motivation:
At the debug page in the documentation service, only service level exampleHttpHeaders are shown.
Modification:

Fix to add method level and entire level exampleHttpHeaders to the debug page

Result:

Better debug page

I just added the exampleHttpHeaders in the order of method, service and entire level. But I was wondering if I have to append the exampleHttpHeaders in the order of entire, service and method while overriding same headers.

@anuraaga Interested in reviewing?

Oh can you run the command in the readme to update licenses?

Thanks, @minwoox!


Try to optimize merge priority

Summary
follow up #10581
I try to move a segment of link list in on an action.
It already pass the octets but Im not sure the behavior is better or worse than before.
Does anyone can teach me how to testing the performance?
Impact
scheduler performance
Testing
sim:ostest

Study the algorithm more detail.
The node remove from clone will put forward and the node from tcb2  is back.
My original idea is collecting node from clone but if I do that, the fragment need to be reveresed.


Page transition is not possible after biometric authentication.

The following issues have been resolved.
https://github.com/naoki0719/flutter_screen_lock/issues/5#issuecomment-753588215

The following issues have been resolved.
https://github.com/naoki0719/flutter_screen_lock/issues/5#issuecomment-753588215

https://github.com/naoki0719/flutter_screen_lock/blob/5a6f2ac3b1562e9c0a724a393a0577c3f134f70b/example/lib/main.dart#L121-L147

https://github.com/naoki0719/flutter_screen_lock/blob/5a6f2ac3b1562e9c0a724a393a0577c3f134f70b/example/lib/main.dart#L121-L147


Try java 14 records with recursive comparison

Summary
The recursive comparison relied on reflection to find the values to compare, let's check it that works properly with java 14 records with bare name properties enabled or disabled.

It is now possible to have dedicated tests relying on records with a new module under assertj-integration-tests.

hello @scordio, @joel-costigliola - I would like to get involved here.
The issue is a bit older, is it still relevant? Is it just a matter of adding tests for recursive comparison for records, and using both options for ExtractBareNamePropertyMethods?

it is @etrandafir93, yes the idea is to play with the recursive comparison and records

Hello @joel-costigliola, Thanks for the quick reply.
I've added a few tests using a flat record, a nested record, and a double-nested record that contains a collection of objects. Are there other cases we should cover?
Also, I've used the static method Assertions.setExtractBareNamePropertyMethods() to test the recursive comparison with both configurations. However, since this is a static method, the tests should not run in parallel.
This is my PR link: https://github.com/assertj/assertj/pull/3241
Cheers, Emanuel


Use production CSS and JS on Darwin Core website

Once we have a production website, we should update the linked CSS and JS in this file:
https://github.com/tdwg/dwc/blob/master/build/config/index.tmpl

Done in https://github.com/tdwg/dwc/commit/7aa6e587ea3566f03ca8047e067e1acad0ad3869


Increased memory requirements for llama 2 models

I was previously able to compile llama 2 7B using tensor parallelism on 2 Neuron Cores, with the default n_positions=2048 and a batch_size=1.
With transformers-neuronx==0.7.84 and neuronx-cc==<IP_ADDRESS>, I get the following error:
RuntimeError: Failed compilation with ['neuronx-cc', '--target=trn1', 'compile', '--framework', 'XLA', '/tmp/neuroncc_compile_workdir/5c616a4d-b0cc-4c8d-8768-df08facd8aec/model.MODULE_875d0cfa
b1be718dcdb8+8737852b.hlo.pb', '--output', '/tmp/neuroncc_compile_workdir/5c616a4d-b0cc-4c8d-8768-df08facd8aec/model.MODULE_875d0cfab1be718dcdb8+8737852b.neff', '--model-type=transformer', '--
model-type=transformer', '--verbose=35']: 2023-09-18T14:15:06Z Too many instructions after unroll for function sg0000 !

I only managed to compile the model properly setting batch_size=1 and n_positions=784.
With that configuration, the device memory during inference in neuron-top is at 20.4 G (out of 16 G x 2 cores = 32 G).
I did another test this time splitting the model on 24 Neuron Cores, and faced the same error. In that configuration however, I managed to get up to n_positions=1536.
If I try to estimate the KV cache memory requirements for the 7B models, knowing that:

the KV cache size for each layer should be 16 Kb per token (2 x hidden_size x token_byte_size = 2 x 4096 x 2),
the total KV cache for the 32 layers require at most 512 Kb per token.

It gives n_positions * token_size = 2048 * 512 = 1 GB per batch.
Considering that:

each core has 16 GB of memory
the 7B model float16 weights require around 14 GB,
neuron-top reports that around 4 Gb are taken by the model code and constants,
then we should be able to fit the KV cache for up to 14 batches on two cores.

As a final note, I face the same kind of errors when using the larger llama 2 13B model. I was previously able to compile and run it just fine on 24 Neuron Cores for n_positions=2048 and batch_size=2, but now I only manage to run it with n_positions=1024 and batch_size=1.

I did more tests, changing the default compiler optimization option from -O2 to -O1, and I am able to use the same configurations I used with transformers-neuronx==0.6.106: batch_size=1 and n_positions=2048.
During inference, the device memory is at 64 Gb for the 13B model and 22 Gb for the 7B model.
I also tested with -O3 but got the same kind of errors.

Thank you for reporting the issue. We are replicating the issue on our end and will get back with a fix.

Hi
What’s the throughput tokens/sec did u get on 7 billion model ?

With the 2.14.1 compiler (neuronx-cc), I am able to compile the llama2 7B model with -O1 for different batch sizes.
I tested several combinations of cores / batch size with the default maximum sequence length for llama model (2048).
Here are the results:
| cores/batch | 128 tokens | 512 tokens | 1024 tokens | 2048 tokens | Throughput   |
|-------------|------------|------------|-------------|-------------|--------------|
| 2c / bs2    |  8.5 s     | 34 s       | 69 s        | 143 s       | 29 tokens/s  |
| 2c / bs4    |  8.6 s     | 35 s       | 72 s        | 150 s       | 55 tokens/s  |
| 24c / bs2   | 1.3 s      | 5.4 s      | 11.5 s      | 22.8 s      | 180 tokens/s |
| 24c / bs4   | 1.4 s      | 5.8 s      | 11.5 s      | 24 s        | 341 tokens/s |

Note: I experienced extremely long compilation times for batch size 4 (more than 3 hours), even with -O1, when it takes only minutes for batch size 1 or 2.

closing

Hi @dacorvo:
We confirmed that the Llama 7B compilation error you reported is fixed in the 2.15.2 Release. Can you install the latest Neuron SDK and try re-running your script to confirm that you no longer see compilation issues for this model?


[WIP] Native compilers

This is a WIP PR for collaborating on implementing support for using the native compiler binaries instead of the wasm ones.
WASM binaries sometimes take a lot more time (likely loading or first JIT-ing). This causes us to have VERY long test cycles, with CI often taking an hour.
This PR has several things implemented already:

Adds a new option "frontend" to all the compile entry points. Valid values are CompilerFrontend.{Default, WASM, Native}. (Note that the name 'CompilerFrotend' is terrible. We should pick something more accurate. CompilerBackend maybe? Idk)

Re-factors a lot of the compiling logic into new classes in frontend/wasm.ts and native_compilers.ts (note - native_compilers.ts should be moved under frontend)

Makes all of the compile* entry-points async (as they may need to fetch a native compiler on-the-fly)

Adds logic to download compiler binaries for the current architecture in native_compilers.ts

Adds a new partial Soliidty parser for top-level definitions only in compile/inference/top_level_definitions_parser.pejgs. We can use this to detect all import statement in a file (along with all compiler pragmas as well)

Adds some unit testing for the new parser

And its missing several more things:

frontend/CompilerFrontend is the wrong name - should probably be more backend
Add a new unit test that does the folowing:

for every solidity file X.sol in the samples, that doesn't import anything:
let a = top level definitions in X.sol after running the WASM frontend
let b = top level definitions in all files discovered after running the top-level definitions parser on X.sol
expect(a).toEqual(b);

Run the unit tests from (4) on a sizable subset of flattened files from the contract archive repo (to sanity check the parser)

Write the logic in the native_compilers.ts that uses the top-level definitions parser, and the ImportFinder provided by the callers, to find all imported files by the compiler. If any of those files live require a path-remapping (e.g. @open-zeppelin imported from node_modules/), then build a proper path-remapping option to be passed to the native compiler

Add a unit test that runs both the native compiler and the wasm compiler for every sample that we have under tests, asserting that they produce the same ASTs

Run test 7 for a good subset of the contract archive repo to sanity-check the whole logic.

I think at this point we can trust the code enough that it works. @blitz-1306 what do you think?

Codecov Report

Merging #87 (0101114) into master (cce4f86) will decrease coverage by 0.15%.
The diff coverage is 87.37%.

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   92.24%   92.09%   -0.16%
==========================================
  Files         244      251       +7
  Lines        4992     5137     +145
  Branches      796      809      +13
==========================================
+ Hits         4605     4731     +126
- Misses        245      259      +14
- Partials      142      147       +5

Impacted Files
Coverage Δ

src/compile/import_resolver.ts
90.00% <ø> (-3.11%)
:arrow_down:

src/types/abi.ts
79.68% <57.14%> (ø)

src/compile/kinds/native.ts
72.72% <72.72%> (ø)

src/compile/input.ts
78.57% <78.57%> (ø)

src/bin/compile.ts
89.33% <88.57%> (-2.10%)
:arrow_down:

src/compile/utils.ts
91.30% <92.72%> (+0.71%)
:arrow_up:

src/compile/kinds/wasm.ts
96.87% <96.87%> (ø)

src/compile/compiler_selection.ts
83.33% <100.00%> (+0.83%)
:arrow_up:

src/compile/constants.ts
100.00% <100.00%> (ø)

src/compile/index.ts
100.00% <100.00%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cce4f86...0101114. Read the comment docs.


Your screenshot doesn't match your sample

Your screenshot doesn't match your sample, should probably update this article.
  <appSettings>
    <!-- Update these settings for your test environment -->
    <add key="VaultUrl" value="URL to your Vault" />
    <add key="AuthClientId" value="Client Id of your Service Principal" />
    <add key="AuthCertThumbprint" value="Thumbprint of the certificate used for authentication" />
    <add key="TracingEnabled" value="false" />
  </appSettings>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 19456c4d-d3ad-7490-16d9-be2662fb13a1
Version Independent ID: e2314a70-1614-9d79-95a5-d4e303cc8424
Content: Allow apps to access Azure Stack Key Vault secrets
Content Source: azure-stack/user/azure-stack-key-vault-sample-app.md
Service: azure-stack
GitHub Login: @sethmanheim
Microsoft Alias: sethm

@nateforsyth Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@nateforsyth Thank you for the feedback and sorry for the delay. I have just submitted a PR to update the sample code in the article. #please-close


Discussion: How should FE display the execution error?

Now FE scheduler do not correctly display the execution error, see
https://github.com/singularity-data/risingwave/blob/a50393a30b7830d392b0092af460871c8e9cede1/src/frontend/src/scheduler/distributed/stage.rs#L393
Should frontend aware of the detail reason like (ExprError, Divde by Zero error etc)? If yes, maybe we should consider how to encode this into proto.
cc @liurenjie1024. May relates to #3908

Currently we don't do fault tolerant of query execution, so I think frontend doesn't need to know the exact error kind, and just the error message.

+1 for error message only, because it seems difficult to define all kinds of errors.

cc. @TennyZhuang

Now the solution is we wrap the execution err msg in string into a Err struct returned by streaming GRPC API. So when there is an execution failure in CN tasks, FE scheduler will imediately know and return Err.
https://github.com/risingwavelabs/risingwave/blob/6f1764f2bc913aae8c4c041654f9b2f59909f59f/src/frontend/src/scheduler/distributed/stage.rs#L374
https://github.com/risingwavelabs/risingwave/blob/6f1764f2bc913aae8c4c041654f9b2f59909f59f/proto/task_service.proto#L75
Now FE should be able to get the execution failure so I think we can close this issue now.


Add a CLI script

This pull request adds a CLI command get-repository-url. Usage example:
$ npm i -g get-repository-url
$ git clone $(get-repository-url assemble)

Travis build failure seems to be unrelated.

thanks! just published to npm!

Awesome, thanks! :)


Spring Cloud support with zookeeper registry

What would you like to be added:
Pixiu should support Spring Cloud proxy with zookeeper registry
Why is this needed:

Close via #354


Add flake8 linter and do style fixes

Adds support for using the flake8 linter and a travis job that runs it to check for code style and other errors. Also adds a script for using the autopep8 formatter and applies the suggested changes. Both autopep8 and flake8 are added as developer dependencies in pyproject.toml.
Most of the fixes can be done by running an autopep8 command and are indicated as such in the commit message using the scripted-diff format even though scripted diffs aren't actually being checked by travis.
Closes #221
Closes #192

Rebased following merges of #137 and #247

ACK d07e102e95849d5a619acb4f96598e132453aecc -- diff looks correct
In addition to flake8/autopep8: what about also using black to reduce the degrees of freedom when it comes to DIY formatting?

In addition to flake8/autopep8: what about also using black to reduce the degrees of freedom when it comes to DIY formatting?

I don't care about formatting that much and IMO black's style is too restrictive.


Async draco decompression

This PR moves gltf draco decompression from the main thread onto a configurable set of workers.
A new function called dracoInitialize is added, which is used as follows:
dracoInitialize({
    jsUrl: 'draco.wasm.js',
    wasmUrl: 'draco.wasm.wasm',
    numWorkers: 2,
    lazyInit: true
});

It's also possible to set configuration via the WasmModule class.
A followup PR will change gltf buffers and textures to load asynchronously.

Please mention some performance data if possible, it'd be great to see.

Can we depend on workers being available on all browsers we support? (including older versions)

Thank you for the performance notes! It is interesting that adding a worker would make it actually slower on some devices.

Thank you for the performance notes! It is interesting that adding a worker would make it actually slower on some devices.

I wouldn't read too much into the timings because they are quite noisy and the "slowdown" is tiny.
The big win with this change is that decoding is now happening off the main thread and once glb-parser stops stalling for buffers and images to complete loading, we should end up doing a lot more work concurrently than we currently are, meaning load times should be even better. (On devices with multiple CPU cores anyway).


Weird behavior of extending selection in a multi selectable list

Provide a general summary of the issue here
From discussion:

Hi, I wanted to ask about expected behavior of the extendSelection method.
As a live example I will use this code sandbox.
Reproduction steps:

Select "Games" with Space
Unselect "Games" with Space
Press down arrow 2 times, to move to "bootmgr"
Hold Shift and press down arrow.

Expected: "bootmgr" and "log.txt" will be selected Actual: All rows are selected.
More precisely, I think the question is whether the anchorKey should work the same when there are no selected rows. For me, it is a bit confusing to see all rows being selected.
Wanted to know your thoughts about this and to know if there's a particular reason it works like this.
Thanks!

🤔 Expected Behavior?
anchorKey should be set to the focusedKey when the shift key is pressed.
😯 Current Behavior
anchorKey is the last selected item
💁 Possible Solution
Address anchorKey should be set to the focusedKey when the shift key is pressed
🔦 Context
No response
🖥 Steps to Reproduce
https://codesandbox.io/s/lucid-fire-mf0m6j?file=/src/App.js

Select "Games" with Space
Unselect "Games" with Space
Press down arrow 2 times, to move to "bootmgr"
Hold Shift and press down arrow.
Expected: "bootmgr" and "log.txt" will be selected Actual: All rows are selected.

Version
latest
What browsers are you seeing the problem on?
Firefox, Chrome, Safari, Microsoft Edge
If other, please specify.
No response
What operating system are you using?
MacOS
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

We talked about this as a team today. Slight change to this. Instead of setting the anchorKey when shift is pressed, instead, we'd just like to 'unset' the anchorKey when the anchorKey is deselected.


go test -race reports import cycles with gccgo

What version of Go are you using (go version)?
go version go1.6.1 gccgo (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1) linux/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/aconway/go:/home/aconway/proton/proton-c/bindings/go"
GORACE=""
GOROOT="/usr/lib/golang"
GOTOOLDIR="/usr/libexec/gcc/x86_64-redhat-linux/6.3.1"
GO15VENDOREXPERIMENT="1"
CC="/usr/bin/gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0"
CXX="/usr/bin/g++"
CGO_ENABLED="1"
What did you do?
Create a package "tmp" containing a single "tmp.go" source file with one line: package tmp
go test -race tmp
What did you expect to see?
go test -race tmp
?   	tmp	[no test files]
What did you see instead?
go test -race tmp
import cycle not allowed
package tmp
imports runtime
imports runtime/internal/atomic
imports runtime/race
imports syscall
imports internal/race
imports runtime/race
I do not have this  problem if I use golang's go compiler, only with gccgo. I can see the problem on a real codebase, but the above reproducer shows it doesn't require any actual code to exhibit the problem, in particular you don't need import "runtime".
I have been seeing this problem since Go 1.4. I'm not sure whether it is a gcc problem or a go tools problem, I am reporting on both sites.

Reported as:
https://github.com/golang/go/issues/18696
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79122

Does gccgo support the race detector?

On Tue, 2017-01-17 at 15:28 -0800, Minux Ma wrote:

Does gccgo support the race detector?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

No: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79122

Currently with the gccgo version go test -race foo_test.go reports:
# command-line-arguments
package testmain
	imports runtime/race: cannot find package "runtime/race" in any of:
	/home/iant/gcc/go-install/src/runtime/race (from $GOROOT)
	/home/iant/gopath/src/runtime/race (from $GOPATH)
FAIL	command-line-arguments [setup failed]

According to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79122#c2 gccgo doesn't support the -race option at all, so it is expected that -race won't work with gccgo. The issue on gcc.gnu.org is still open in hopes that someone will improve the error reporting to make this more clear.


State encoding issue

Fixes #3491
This PR ->
-Removes nested decodeURIComponent in queryStringToObject{StringUtils.ts}
-Removes the decodeURIComponent in parseRequestState {ProtocolUtils.ts} (which was resulting in an extra decode of the state val)
-Unit tests for each of the above changes
-Removes an existing unit test case in AuthorizationCodeClient.spec.ts that was checking for server response in case of double encoded state val

Codecov Report

Merging #3903 (1635883) into dev (006f87f) will not change coverage.
The diff coverage is 100.00%.

Flag
Coverage Δ

*Carryforward flag

msal-angular
95.85% <ø> (ø)

Carriedforward from 006f87f

msal-browser
85.07% <ø> (ø)

Carriedforward from 006f87f

msal-common
85.16% <100.00%> (ø)

Carriedforward from 006f87f

msal-core
76.66% <ø> (ø)

Carriedforward from 006f87f

msal-node
83.55% <ø> (ø)

msal-react
94.11% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

lib/msal-common/src/utils/ProtocolUtils.ts
83.33% <100.00%> (ø)

lib/msal-common/src/utils/StringUtils.ts
100.00% <100.00%> (ø)


allow test folders to end without a number

thanks

you should have write access, so you dont need to keep the fork, but feel free


Tasks 73 - 76: Copa_hr dataset

@shailaja183 , wondering if you can help review this task?

Task 74/76 are NOT clearly a question generation task, looks like classification tasks.
I do not understand from your definition that why one is correct choice and other is incorrect choice.
Frame them as given a sentence and two follow up statements, classify whether follow up statements are a "cause" or "effect" for a given a sentence.
task74:

Break down long sentences in definition into multiple sentences
"Since the word realized is mentioned in both the choices, the question directly falls under the effect category." and "The choices are clearly providing the reason in the form, the guest was, for the statement hence it will come under the cause category." are not good explanations -- rewrite
You have negative examples where both followup statements contradict (one is effect, one is cause). In that case you also need a third class label (if your dataset has any such annotations; if not, they are bad negative example) Include negative examples where labels are misclassified (cause predicted as effect and vice-versa)

Task 75/77 are NOT clearly an answer generation task, looks like answer selection tasks.
Frame them as a given a sentence and a label (cause or effect), select the correct answer choice
See all comments mentioned above and fix for all tasks. Will review other tasks after fixes.

See examples of classification tasks and answer selection tasks at https://github.com/allenai/natural-instructions-expansion/blob/master/tasks/

@AnshitaSinghBais, Can you address reviewer comments so that I can evaluate your HW?

Task 74/76 are NOT clearly a question generation task, looks like classification tasks.
I do not understand from your definition that why one is correct choice and other is incorrect choice.
Frame them as given a sentence and two follow up statements, classify whether follow up statements are a "cause" or "effect" for a given a sentence.
task74:

Break down long sentences in definition into multiple sentences
"Since the word realized is mentioned in both the choices, the question directly falls under the effect category." and "The choices are clearly providing the reason in the form, the guest was, for the statement hence it will come under the cause category." are not good explanations -- rewrite
You have negative examples where both followup statements contradict (one is effect, one is cause). In that case you also need a third class label (if your dataset has any such annotations; if not, they are bad negative example) Include negative examples where labels are misclassified (cause predicted as effect and vice-versa)

Task 75/77 are NOT clearly an answer generation task, looks like answer selection tasks.
Frame them as a given a sentence and a label (cause or effect), select the correct answer choice
See all comments mentioned above and fix for all tasks. Will review other tasks after fixes.

Thank you for your suggestions.

@shailaja183, check if you are happy with the tasks or have any other feedback?

for all tasks:

instead of "label/question" -> use just "label"

73:

Positive Example 1 - not properly formatted like other examples using \n
All positive/negative/instances - instead of "Question" -> use "Label"
add in the definition that there is exactly one choice correct for a given passage and label.
specify in the definition that the output must be the text corresponding to the given choice and not "Choice 1"

73/75: your readme and category inside json still has "answer generation" change it to "answer selection"
74:
You did not address my previous comment
You negative examples cannot include choices where one is effect, one is cause. Include negative examples where labels are misclassified (cause predicted as effect and vice-versa)
76:

instead of "statement and answer", change it to "statement1 and statement2" (answer is misleading)
(change the definition accordingly)
instead of "classify the group in which the answer and the statement are related" -> say "identify a label based on the relationship between statement1 and statement2

75: is duplicate with 73 except there are four answer choices in 75 and in 73 there were two
76: is duplicate with 74 except there were three sentences to determine label in 74 and in 75 there are two
@swarooprm let her know if you want to keep both or remove one
I do not understand the relationship between input and output in task 77/78.
@swarooprm review tasks 77/78.

for all tasks:

instead of "label/question" -> use just "label"

73:

Positive Example 1 - not properly formatted like other examples using \n
All positive/negative/instances - instead of "Question" -> use "Label"
add in the definition that there is exactly one choice correct for a given passage and label.
specify in the definition that the output must be the text corresponding to the given choice and not "Choice 1"

73/75: your readme and category inside json still has "answer generation" change it to "answer selection"
74:
You did not address my previous comment
You negative examples cannot include choices where one is effect, one is cause. Include negative examples where labels are misclassified (cause predicted as effect and vice-versa)
76:

instead of "statement and answer", change it to "statement1 and statement2" (answer is misleading)
(change the definition accordingly)
instead of "classify the group in which the answer and the statement are related" -> say "identify a label based on the relationship between statement1 and statement2

75: is duplicate with 73 except there are four answer choices in 75 and in 73 there were two
76: is duplicate with 74 except there were three sentences to determine label in 74 and in 75 there are two
@swarooprm let her know if you want to keep both or remove one
I do not understand the relationship between input and output in task 77/78.
@swarooprm review tasks 77/78.

Am I allowed to edit the submission and resubmit it by making the changes suggested?

Yes, commit your files again with the above mentioned changes.

You can keep both 73 and 75. Similarly, you can keep both 74 and 76. But they won't be considered as unique tasks.
Tasks 77 and 78 appear ambiguous. Fix their definitions.
In general, modify definitions so that they are like how you instruct your friend to do a task.

You can keep both 73 and 75. Similarly, you can keep both 74 and 76. But they won't be considered as unique tasks.
Tasks 77 and 78 appear ambiguous. Fix their definitions.
In general, modify definitions so that they are like how you instruct your friend to do a task.
Leaving for @shailaja183 to check if she is happy or has any other feedback.

Thank you,
I will edit the definition for tasks 77 and 78. Please let me know, if 73 and 75 both tasks are considered and 74 and 76 are considered then I will be graded for 4 tasks or 2 tasks, as you mentioned above that they won't be considered as unique tasks.

yes, they will not be considered as 4 tasks. Would you like to create 1-2 extra tasks to be safe? I can provide you a new dataset if you are interested. @AnshitaSinghBais

@swarooprm provide dataset

@AnshitaSinghBais, use this one
https://allenai.org/data/openpi
Sorry for the delay

@AnshitaSinghBais, use this one https://allenai.org/data/openpi
Sorry for the delay

@shailaja183, check if you are happy or have any other feedback?

@shailaja183, check?

Task 79 - OK
Task 80 - OK but  newline delimiters '/n' are incorrect


Backport(2.2): Update EKS AMI's for k8s 1.13

backport: https://github.com/rancher/rancher/issues/21992

rancher/rancher:v2.2-head ec468dea

Saw older AMIs being used in v2.2.8
Deploy 2.2-head
Create 1.13 EKS cluster
Cluster is using the updated ami for the region (us-east-2): `ami-0355b5edf93d47112
Cluster comes up successfully


Update ledger to tip of release/1.0.0

This fixes a bug whereby nodes always re-sync from the start when the last ledger snapshot was in the Babbage era.
See https://github.com/input-output-hk/cardano-ledger/pull/2897 (release/1.0.0 was branched off of ce3057e0863304ccb3f79d78c77136219dc786c6 and cherry-picked the commit from the ledger PR 2897).

bors r+


Update step-2.mdx

Step 2 is broken atm and fails with missing mixins, when compared to step 3 the diff is the missing "carbon--" in front of the mixins which fixes the broken build
Closes #
Following the tutorial, step 2 failed for me with missing mixin error
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

I have read the DCO document and I hereby sign the DCO.

recheck

recheck

Hi @JuliusKoronci! Thanks so much for opening this to correct the tutorial's usage to include the new naming scheme for mixins.
All the tutorial instructions are based on the v10 packages and have not been updated to reflect changes for the next major version. We'll need to make this update and all the other updates in one swoop, https://github.com/carbon-design-system/carbon/issues/10991. The team is working on this now.

Hi @JuliusKoronci! Thanks so much for opening this to correct the tutorial's usage to include the new naming scheme for mixins.
All the tutorial instructions are based on the v10 packages and have not been updated to reflect changes for the next major version. We'll need to make this update and all the other updates in one swoop, https://github.com/carbon-design-system/carbon/issues/10991. @aledavila and @jnm2377 are working on this now.

Tutorial update PRs are up and closing in favor of #2917 and #2912
Please comment again if this is incorrectly closed


Want to add a new Open Source Event in the list

Event Name - Apertre - An Open Source Event
Organised By - Resourcio Community and GDSC AOT
Event Website - https://os.apertre.tech/
Event Timeline - 3rd JAN 2024 - 17th JAN 2024
Description - "Apertre":  15-day tech program by Resourcio and Google Developer Students Club - Academy Of Technology. Enhance web, mobile, and ML skills, collaborate on real projects, mentorship. Open to all levels. Boost experience, portfolio, and tech career.
@ayush-sleeping

Event Name - Apertre - An Open Source Event Organised By - Resourcio Community and GDSC AOT Event Website - https://os.apertre.tech/ Event Timeline - 3rd JAN 2024 - 17th JAN 2024 Description - "Apertre": 15-day tech program by Resourcio and Google Developer Students Club - Academy Of Technology. Enhance web, mobile, and ML skills, collaborate on real projects, mentorship. Open to all levels. Boost experience, portfolio, and tech career.
@ayush-sleeping

Hi @Soumyajit2825 ,
I hope this message finds you well. I noticed that you've created an issue in the repository, and I appreciate your engagement with the OS Programs list. I've reviewed the suggestions, and I agree that adding the following programs would be valuable.
If you could kindly create a PR with these additions, I'd be more than happy to review and merge it into the main branch.

Event Name - Apertre - An Open Source Event Organised By - Resourcio Community and GDSC AOT Event Website - https://os.apertre.tech/ Event Timeline - 3rd JAN 2024 - 17th JAN 2024 Description - "Apertre": 15-day tech program by Resourcio and Google Developer Students Club - Academy Of Technology. Enhance web, mobile, and ML skills, collaborate on real projects, mentorship. Open to all levels. Boost experience, portfolio, and tech career.
@ayush-sleeping

Hi @Soumyajit2825 ,
I hope this message finds you well. I noticed that you've created an issue in the repository, and I appreciate your engagement with the OS Programs list. I've reviewed the suggestions, and I agree that adding the following programs would be valuable.
If you could kindly create a PR with these additions, I'd be more than happy to review and merge it into the main branch.

Sure!
I am doing a PR!
Thanks


Fix boilerplate controller

When we use $controller variable karma throws that error
ReferenceError: Can't find variable: $controller
Just changed $controller to _$controller_

Thanks @pedrotcaraujo. Merged.


TypeScript Module Naming

//cc @vladima
In order to support bundling with TypeScript, we need to tell typescript what to name the compiled ES6 modules.
For example, in Traceur we pass load.name as a parameter to the transform - https://github.com/systemjs/builder/blob/master/compilers/esm.js#L80.
This then provides the output - System.register("load name", ... where "load name" is the name we set.
This is the last critical issue to get full TypeScript support. https://github.com/systemjs/builder/issues/178 and https://github.com/systemjs/builder/issues/177 will then help to improve the experience too.

@guybedford I'll check if this change can fit into the forthcoming release. In case if it cannot - is this issue a release blocker or ES6 module loader/SystemJS can be released without this part and I can submit it later as a PR?

@vladima thanks. Yes we can patch later certainly - it does block the full use case but will just note that bundles are not supported for TypeScript yet in the release notes.

@guybedford as I see SystemJS 0.17 was already released. Assuming that we can fix this issue on the TypeScript side pretty soon, what is the timeline for the next patch  that can actually use this fix?

@vladima we can roll out the patches quickly now that the release is out, so in just a day or two now.

@guybedford a general question: how SystemJS / Builder expect transpile errors to be reported?

as I can see here for Traceur it re-throws the first error in the list. Is it expected behavior in general or other errors should at least be printed to console?
does SystemJS/Builder has the same expectations (first transpile error is raised as exception)

The story here isn't excessively developed - we're just throwing the error from the compiler through the promise chain in a way that looks good in the browser and Node. Whatever works best within a single error object for TypeScript is great. We just had to alter this for Traceur because the error array didn't display well when thrown. There is the ability to do this differently between the browser and Node, although in future we plan on converging into a single transpiler implementation.

Released in 0.12.0. Tests tracking at https://github.com/systemjs/builder/issues/200.


internal/mod/modregistry: gitlab registry does not support modules artifact type

What version of CUE are you using (cue version)?

$ cue version
v0.8.0-alpha.1

Does this issue reproduce with the latest stable release?
N/A (feature didn't exist in latest stable)
What did you do?
env TOKEN=xxxx
env GITLAB_USER=rogpeppe
env CUE_REGISTRY=registry.gitlab.com/rogpeppe/registrytest
env CUE_EXPERIMENT=modules
env DOCKER_CONFIG=$WORK
exec docker login registry.gitlab.com -u $GITLAB_USER --password $TOKEN
exec cue mod publish v1.0.0

-- cue.mod/module.cue --
module: "foo.com@v1"
-- m.cue --
package cuemodtest
x: 2

What did you expect to see?
A passing test
What did you see instead?
> env TOKEN=xxxx
> env GITLAB_USER=rogpeppe
> env CUE_REGISTRY=registry.gitlab.com/rogpeppe/registrytest
> env CUE_EXPERIMENT=modules
> env DOCKER_CONFIG=$WORK
> exec docker login registry.gitlab.com -u $GITLAB_USER --password $TOKEN
[stdout]
Login Succeeded
[stderr]
WARNING! Using --password via the CLI is insecure. Use --password-stdin.
WARNING! Your password will be stored unencrypted in $WORK/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

> exec cue mod publish v1.0.0
[stderr]
cannot put module: cannot tag<EMAIL_ADDRESS>400 Bad Request: manifest invalid: manifest invalid; detail: "unknown media type: application/vnd.cue.module.v1+json"
[exit status 1]
FAIL: /tmp/testscript4093019353/gitlab2.txtar/script.txtar:7: unexpected command failure

It turns out that gitlab does not support arbitrary media types.
See https://gitlab.com/gitlab-org/container-registry/-/issues/973.
If the internal/modregistry code is changed to use a simple application/json type for the artifact type, the test above succeeds.
TODO

[ ] Raise a PR with GitLab to add support for our media type
[ ] Raise a PR with the central media type "registry" to record our media type

For the record, this does not apply to self-managed Gitlab installations, because they apparently do not use the new container registry.

These are the custom media types currently used by internal/mod/modregistry package:

application/vnd.cue.module.v1+json - the artifact type for the top level module manifest
application/vnd.cue.modulefile.v1 - the artifact type for the module file blob within the above

The gitlab registry only has an issue with the former: it seems to ignore unusual blob media types.
The list of currently assigned IANA media types is here: https://www.iana.org/assignments/media-types/media-types.xhtml
Some instructions for registering a new media type are here: https://www.w3.org/2020/01/registering-mediatypes
Here is a previous Gitlab PR that added support for a new media type: https://gitlab.com/gitlab-org/container-registry/-/merge_requests/1063

Per our discussion offline, here is a summary of the proposed plan:

Raise a PR with GitLab to add support for two media types mentioned in https://github.com/cue-lang/cue/issues/2817#issuecomment-1953796090, specifically:

application/vnd.cue.module.v1+json
application/vnd.cue.modulefile.v1

Use this issue to better understand the requirements for submitting something to IANA.

In the worst case, we get pushback/feedback from IANA on our choice of media type. In which case we can revisit. Hence we should try and flush out issues there ASAP.
But the most important thing for GitLab users is to get things unblocked.

But the most important thing for GitLab users is to get things unblocked.

@rogpeppe raised https://gitlab.com/gitlab-org/container-registry/-/issues/1203, which was then resolved by the now-merged https://gitlab.com/gitlab-org/container-registry/-/merge_requests/1588. We will update in this issue as we learn about the availability of that fix via GitLab "products".

According to a reply to the above-mentioned issue, the fix should be released with GitLab 16.10, due out 2024-03-21.


Support NewType.

@m09 can you play around with this and give feedback? I'm not experienced with NewType, so I could use some backup 😄. The actual past in object never gets cast to the declared new-type, but I don't think that matters since static type checkers  in the parenting project won't be peaking into Cyclopts.
Addresses #262.

I tried it in a few ways (newtype alone, in a union, in a list, then give it as argument to a function to see if mypy complains) and everything went perfectly fine on my 3.10 (as you suspected I didn't get warnings from mypy even though the object is not cast).
I cannot speak for other python versions but it looks very promising (and what a lightning fast PR!)
Thanks for the great work :)

good enough for me! Other python versions are checked by the unit tests. Merging now and this will be available in v3.1.1 momentarily!


Bad error message when Android toolchain isn't installed

If the Android toolchain isn't installed (I had the wrong path set in ANDROID_HOME), flutter run and flutter devices report "No devices detected" instead of "Can't find adb / Android tools".

Please add the output of flutter doctor -v.


Add search link to show archival sets results containing digital image thumbnails (from 1728)

Problem` Description:
This is an enhancement to the explore hierarchy feature.  Although we now have a icon to indicate archival objects that have digital images, there is no easy way for a user to browse the digital images on the archival collection level.
Expected Behavior/Solution:
The hierarchy will have a link to the results page where a user can view records with images. The HAL link will have to cover objects and works.
Requirements:

link on archival set page
corresponding object results page (when user follows link)

Needed for promotion:

[x] Wireframe/Mockup - Mike
[x] Update mock-up to make link more prominent. Looks like it is part of the list above, but misaligned - Mike
[x] Feasibility/Team discussion - Sarah
[x] additional requirements - TBD
[x] https://github.com/project-lux/lux-middletier/issues/14 (119)
[ ] Questions
List of questions for discussions. Answers should be documented within the issue.

UAT/LUX Examples:

https://lux-front-tst.collections.yale.edu/view/set/5f1ff079-5f3a-4bd6-921a-5c6ae8f88262
https://lux.collections.yale.edu/view/set/2bbba369-f848-42ee-8b25-b2d56da76b01
~Advanced Search Query~ (No longer applicable)
~advanced search query~ (No longer applicable)

Dependencies/Blocks:

Blocked By: Issues that are blocking the completion of the current issue.
Blocking: Issues being blocked by the completion of the current issue.

Related Github Issues:

Issues that contain similar work but are not blocking or being blocked by the current issue.

Related links:
Bugherd: - https://www.bugherd.com/projects/284041/tasks/851
Wireframe/Mockup:

@miketullo95 should this be assigned to you instead?

From old tix(https://git.yale.edu/lux-its/lux-web/issues/1728):
12/5/23
Per ticket forming - ready to promote as blocked and needing HAL link completed.

@miketullo95 - this is for you next; mockup needs updating.

This will require 2 links. One for View objects from this archive with images and the other being View works from this archive with images. The hierarchy shows both works and objects.
cc: @miketullo95

@kkdavis14 - would there ever be works with images in archival hierarchy? I'm thinking not. Only the archival object is digitized.

@prowns I don't think so, archival Objects don't carry any Works, and I think all the Works that are Archives are top level or Series level collections, not Visual Items or Textual Works.

I looked at the third UAT example in tst (here) and it shows me an error. Is that supposed to happen? @kamerynB

@roamye I'm not sure why those search links are in the UAT block. The ones to be concerned about are the entity links, ie the first 2 UAT examples. The archives in those entities should have a link saying View records from this archive with images and those links should be valid. I'm not sure where those search links came from.

@kamerynB looks like it was added back in 2023 (old issue). I will strike them out. Thanks Kam.

@jffcamp A PR for the hotfix is already open.
What it will look like:

@kamerynB I believe the archive collection name also needs to be bold to reflect the wireframe in the mockup.
cc: @jffcamp

@roamye I've included that in #27. The current entity link has not been bolded since I deployed the SI changes as I accidentally removed that styling when making those changes. That bug was not introduced with this deployment.
cc: @jffcamp

@kamerynB - Thanks. Please deploy.

Deployed!
cc: @roamye @jffcamp

Approved by UAT

Looks good in prod, closing.


Elevation profile table - Does not appear in widget list of WAB

Hi,
I am trying to implement the Elevation profile table in a web app but I cannot make it work. I have followed the instructions but I cannot find the list.json file. The last step to implement the widget says to add "ElevationProfileTable" entry to /stemapp/widget/list.json. Am I doing something wrong? The Elevation Profile Table widget does not appear in the list of widgets (Choose widget).
Besides, I have a couple of questions/requests:

I think it would very useful to be able to select any raster file in the web app and not only elevation. I mean, would it be possible to create profiles from any raster file available in the web app?

Is there any possibility to save/export the results of the profile? I would like to export the table with the X, Y, M, Z values so I can use them later or create graphs using other software.

Many thanks for these useful widgets!
Maria

@cuevasgonzalez I am assuming you are trying to integrate this widget into WAB 2.1. The steps listed in the README is meant for WAB 2.0 and we will need to update that for WAB 2.1.
You can create your own profile service and have this widget consume it. Have a look at this link of creating your own profile service: https://blogs.esri.com/esri/arcgis/2014/08/26/setting-up-your-own-profile-service/
Saving/exporting is on the enhancement list but we do not have a timeline of tackling it just yet.
Also, I recommend using the elevation profile dijit that is part of the JS API: https://developers.arcgis.com/javascript/3/jsapi/elevationprofile-amd.html. It offers more functionalities than the elevation profile table.


Enable two modern features of GNU global

This enables:

Use of SQLite as the storage backend (available since 6.3.3)
Optional use of the ctags backend (which, by way of pygments, allows indexing many more languages than what GNU global normally provides).  Using ctags requires setting up a configuration file, so this should not affect users who only care about GNU global's normally supported languages.

+1


SC 100 violation!

https://github.com/Lambda-School-Labs/mission-control-be/blob/da9625015eda021dbede6ecf5a2c28cbd47c0bed/apollo/src/datasources/GitHubAPI.js#L7
RE: https://lambda-school-labs.github.io/labs-engineering-standards/topics/security/#sc-100-never-commit-secrets

This was removed and added to environment variables with PR #107 Update the Environment Variables.


POC compute API changes

@postelrich @llllllllll here's my proof-of-concept for the compute() API changes.  It's messy, and some of the imports will have to change, and we'll need some small refactoring, but I like that it doesn't require huge code changes, and fits in with the existing compute implementation easily.
Example usage:
In [26]: s = bz.symbol('s', 'var * {name: string, id: int}')

In [27]: t = bz.symbol('t', 'var * {name: string, a: int}')

In [28]: sdata = [['a', 1], ['b', 2]]

In [29]: tdata = [['a', 5], ['c', 7]]

The default gives back a list as one would expect:
In [30]: bz.compute(bz.join(s, t, 'name', how='outer'), {s: sdata, t: tdata})
Out[30]: [('a', 1, 5), ('c', None, 7), ('b', 2, None)]

And the return type can be easily overridden:
In [31]: bz.compute(bz.join(s, t, 'name', how='outer'), {s: sdata, t: tdata}, return_type=pd.DataFrame)
Out[31]:
  name  id   a
0    a   1   5
1    c NaN   7
2    b   2 NaN

In [32]: bz.compute(bz.join(s, t, 'name', how='outer'), {s: sdata, t: tdata}, return_type=np.ndarray)
Out[32]:
array([('a', 1.0, 5.0), ('c', nan, 7.0), ('b', 2.0, nan)],
      dtype=[('name', 'O'), ('id', '<f4'), ('a', '<f4')])

@llllllllll agreed on your comments, and if we go with this approach, we'll definitely make those improvements.  This is just a quick and dirty POC to demonstrate the API I'm thinking of, and how it can be implemented without a major rename or big refactoring.
What are your thoughts on the API?

I like the API. I would like to be able to register new return types like discussed in the other issue but for a first pass this looks great.

+1, it looks good.

returning results is a more intuitive response from compute()
list output by default makes sense for SQLA backends
being able to override output return_type is a good idea

@llllllllll will be merging this in the next day or so, last call.

No other comments, thanks!


recode variables in I2D2

In making GLD I realized that the top-value 99999 for "not reported" needs to be recoded as . a la
	replace 		wage_no_compen = . if 	wage_no_compen == 99999

Also, ensure that all variables for basis of payment is coded to the appropriate variable or missing, then recoded, a la
	gen byte 		unitwage_2 = c33_obasis
	recode 			unitwage (0 1 5 6 7 = 10) /// other
								(2 = 9) /// hourly
								(3 = 1) /// daily
								(4 = 5) // monthly


KAFKA-17661: Fix flaky BufferPoolTest.testBlockTimeout

It's regarding KAFKA-17661.
The test relies on 3 asynchronous threads being triggered in parallel with the test thread[1]. However, there is no guarantee of parallelism in test environment. The 25 ms delay(10 ms maxBlockTimeMs) is obviously unreliable in the test environment.
In KAFKA-9852, maxBlockTimeMs was reduced from 2000 ms to 10 ms. Proposed to move 2000 ms back in this PR.
[1] https://github.com/apache/kafka/blob/40360819bb97d6b05dfef6451888b4d908fc3bf4/clients/src/test/java/org/apache/kafka/clients/producer/internals/BufferPoolTest.java#L175-L179
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Annother possible solution is to remove the asnchronous delayedDeallocate() in testBlockTimeout.
But I prefer to keep the more complexity test since there are no similar tests existing in BufferPoolTest.

Another possible solution is to remove the asynchronous delayedDeallocate() in testBlockTimeout.

In fact, this solution looks good to me. We can have a follow-up to add multi-threaded tests for deallocate and allocate, but I don't think this test case requires asynchronous operations.

@chia7712 That make sense to me. I will rewrite this PR.

Hi @chia7712,
After rethink about it, I believe we can resolve the racing issue while still keeping the multi-threading test logic by removing the third delayed deallocation.
The root casue of racing is all the three delayed deallocation threads occur before the test thread.
So we can remove the third deallocation to make sure the pool.allocate(10, maxBlockTimeMs) will never be satisfied.
The following test target can be kept in the test:

allocate() waits for maxBlockTimeMs for more memory  (Link)
allocate() won't returned early when receiving a notification from other thread.  (Link)

Below is the detailed explanation for the new test:

[test thread] allocate buffer 1
[test thread] allocate buffer 2
[test thread] allocate buffer 3
[test thread] request buffer with 10 memory, await for more memroy
[delayed thread] At 5 ms,  deallocate buffer 1, signal test thread
[test thread]  Awaken at 5 ms, await again for more memroy
[test thread]  Awaken at 10 ms, allocation() timeout -> Can run assertions after this point.
[delayed thread] At 10 ms,  deallocate buffer 2

No matter when the delayed thread occurs, the timeout in the test thread always hits.
(pool.allocate(10, maxBlockTimeMs never get enough memory)
Just updated the PR to this version.

(pool.allocate(10, maxBlockTimeMs) never get enough memory)

What if the previous two threads haven’t allocated before this allocation? Would it still encounter a buffer exception?

@chia7712
The asynchronous thread is for pool.deallocate()

What if the previous two threads haven’t allocated before this allocation?

So it won't happen. The first three allocate() calls are run in the test thread, and they are synchronous.

The asynchronous thread is for pool.deallocate(), not for allocation.

Sorry for the typo. My point is that deallocate is a no-op in this test, as the case will pass even if those threads haven't deallocated. If you prefer the solution of removing the threads, you should remove all deallocation threads

My point is that deallocate is a no-op in this test, as the case will pass even if those threads haven't deallocated.

You're right, removing the async deallocation doesn't change the test result.
The reason I decided to keep the async deallocation is that the deallocate threads are intended to validate this correct behavior under multi-threading scenario:

When a block allocate() is signaled by other thread's deallocate() call (BufferPool.java#L273-L275), it still re-enter the the while loop until hits the block timeout. (BufferPool.java#L148-L153)

I won't say the deallcoate is a no-op in this test, but the orignal test name is not accurate.
I can split the test into 2 tests as you suggested previously.  Split the testBlockTimeout() into below tests:

testBlockTimeout()
testAsyncDeallocateNotBreakBlockTimeout()

@chia7712 WDYT?

When a block allocate() is signaled by other thread's deallocate() call (BufferPool.java#L273-L275), it still re-enter the the while loop until hits the block timeout. (BufferPool.java#L148-L153)
I won't say the deallcoate is a no-op in this test, but the orignal test name is not accurate.

I don't think this test case has actually tested this behavior, which is why I believe the deallocate is a no-op, as the related behavior isn't asserted in the test.

I can split the test into 2 tests as you suggested previously. Split the testBlockTimeout() into below tests:

Perhaps this PR can simplify the test case to address the flakiness, and then you can file a follow-up to add more test cases.

OK, I just update this PR to simplify the test case.
We can create follow-up to discuss whether we should bring the multi-threading test back.

@chenyulin0719 fyi, there was a build issue on trunk. I have fixed the issue and updated your branch with the fix.

@mumrah Thank you for letting me know. :)


Example for use with a global/unified state machine

For Advanced Examples, it would be nice to see a way to use this against a state engine like Zustand, Jotai, Valtio, Redux or MobX.  Since being able to integrate a larger shared state would be beneficial for use in larger application(s) development.

Yep I was wondering if there was context api or if van.state() can be shared globally like preact signals.

Could this not be achieved with Moyes import/export. in a svelteKit style way?
main.js imports state required from store.js? On my phone but will test it this evening

I have some quite simple way to use jotai with vanjs, but didn't test in most case, it works on my simple todomvc app
import type { State } from './lib/van'
import { Atom, WritableAtom, atom, createStore } from 'jotai/vanilla'
type UseAtom = {
  <Value, Args extends unknown[], Result>(atom: WritableAtom<Value, Args, Result>): State<Value>
  <Value>(atom: Atom<Value>): State<Value>
}

function vanjsJotaiFactory(): UseAtom {
  const store = createStore()
  return <Value, Args extends unknown[], Result>(atom: WritableAtom<Value, Args, Result> | Atom<Value>) => {
    const atomState = van.state(store.get(atom))
    return new Proxy(atomState, {
      get(state, prop) {
        if (prop === 'val')
          return store.get(atom)
        //@ts-expect-error
        return state[prop]
      },
      set(state, prop, newValue: Value) {
        //@ts-expect-error
        state[prop] = newValue
        if (prop === 'val' && 'write' in atom && newValue !== store.get(atom)) {
          //@ts-expect-error
          store.set(atom, newValue)
        }
        return true
      }
    })
  }
}

Zustand is very lightweight and has an extremely simple api in vanilla with zustand/vanilla. Create a store useStore = createStore((set) => ({a: null, b: false,...}))  and just call useStore.getState().a to read from the store and useStore.setState().a = 1 to update it.  If you have multi-page navigation, then you will inject fresh components so the pattern (context)=>(props)=> [dom elts] used here is enough: you pass van.state in the context and just use it. I used this exact pattern here and it just works.

Remember the primary goal of VanJS
Enable everyone to build useful UI apps with a few lines of code, anywhere, any time, on any device.__

Hi @tracker1,
With VanJS, you can build your app based on a single global state. Here is an example (state persistence is supported as well):
https://vanjs.org/demo#todo-app

Closing the issue as the example is provided in https://github.com/vanjs-org/van/issues/12#issuecomment-1742201991.


custom icon for player

Can add a custom icon for each player buttons is a nice feature.

that will be nice. and i suggest an option for setting the background color of the player also will be appreciated


luci-app-nut: Add support for NUT configuration

Adds app to configure NUT (Network UPS Tools), including
nut-server, nut-monitor, and nut-cgi.
Signed-off-by: Daniel F. Dickinson<EMAIL_ADDRESS>

Found a couple of things to fix....

I've got this fixed, but RL is getting in the way for a week or two so will reopen when I can respond if there are problem when I post the final edition.


LandingUpdate

Here the new landing page

The Hero Text is missing, add lorem ipsums.

Also we saw you have added Bootstrap, just wanted to know will this not cause namespace pollution, as for styling Tailwind CSS has been already added.

Where do you want me to add the hero text.
As for the bootstrap it does not causes any conflicts if you want I can remove it

If you are talking about this text I can add this on the top and continue with the other design which I have made

Modify first label, second label...etc that you have put on image slider in the hero section. Make it a bit larger, similar to the design that I have provided from webflow. And yes, also add two get started buttons below first label, second label....

I will send you screenshot

ok how about this
I can make a new section of relief connect that you have on the vercel deploy
and then continue with the image slider ( and I will modify it like the webflow design )

Yeah that works!

You can check the code now
PS. Removed bootstrap :)


Linear interpolation in angle

Fixed texture_progress to interpolate linearly in angle instead of "on rect".

This PR was superseded by #17422. I'll let you and @robfram check if the current state is good enough or if some changes made here would still be relevant.


feat: allow ComplexContentElement to have a restriction as child element and implement attributes parsing for RestrictionElement

feat: allow ComplexContentElement to have a restriction as child element and implement attributes parsing for RestrictionElement

Looks good to me. When do you need these changes in release?

Looks good to me. When do you need these changes in the release?

@w666 Would be nice to release it asap, that i don't have to use my own fork 👍. But i don't want to pressure you at all. Thx for the quick response. 🥇

@TheDadi new release 1.1.3 has been published to npm


fac: 2.0.0 -> unstable-2023-12-29

Description of changes
Last release was 2018, let's grab some minor fixes from main and the recent move to Go modules.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I've also updated the version with a prefix for the previous release, following
https://github.com/NixOS/nixpkgs/blob/e7069e4aa2b66cdc57a3f6812f96cb970081d63e/pkgs/README.md?plain=1#L353-L355


Bug while build

Description
There is a bug while trying to build the app. It's a syntax error in theme.min.css file inside dist directory.

<EMAIL_ADDRESS>ParserError: Syntax Error at line: 1, column 26
Reproduction

Preview →
Steps

Go to ...
Click on ...
Scroll down to ...
See error

Expected behavior

Environment

OS: [e.g. Windows / Linux / macOS / iOS / Android]
Browser: [e.g. Chrome, Safari]
Autocomplete version: [e.g. 1.0.0]

this is a bug in your css parser, and can be fixed by updating that, or using the non-minified version of the css theme:
import<EMAIL_ADDRESS>
duplicate of https://github.com/algolia/autocomplete/issues/794, https://github.com/algolia/autocomplete/issues/626, https://github.com/algolia/autocomplete/issues/586


Node doesn't match existing scaleset when you add a new node to a node array

CycleCloud - 8.1.0-1275
Slurm -  19.05.8-1
Scenario:

Submit a job to the HPC node array.
Increase max core count from UI and run scale (cyclecloud_slurm.sh scale) command.
Node which is in the acquiring state stuck with the below message:

{{{
This node does not match existing scaleset attributes: Configuration.cyclecloud.mounts.additional_nfs.export_path, Configuration.cyclecloud.mounts.additional_nfs.mountpoint
}}}

This will be fixed in 8.1.1.

Upgrading to CycleCloud 8.1.1 fixes this.


Enable assertions

Codecov Report

Merging #81 (ef414ac) into master (a5ea7d8) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master      #81   +/-   ##
=========================================
  Coverage     72.37%   72.37%
  Complexity      487      487
=========================================
  Files            79       79
  Lines          1502     1502
  Branches        173      173
=========================================
  Hits           1087     1087
  Misses          362      362
  Partials         53       53

Impacted Files
Coverage Δ

src/main/java/seedu/address/MainApp.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5ea7d8...ef414ac. Read the comment docs.


Update devnet

While working on #395 I tried updating devnet and dependencies and latest hardhat starknet plugin, which led me to a pretty deep rabbit hole.
Basically:

Deploying has changed: now it needs to go through accounts
Those accounts need to be funded, so I added a getAccount(index) which attaches to one of the 10 prefunded accounts from the devnet
I added a declareAndDeploy utility function
For some reason, this broke the nice trick we had to deploy multiple smart contracts in parallel (putting them all as Promises in an array, and calling await Promise.all(array)). It simply broke. Idk if came from starknet-devnet or the hardhat plugin or me...
For some reason I also had to update some tests with a padLeft function. Basically starknet addresses are felts which are 251 bits long (at most). Meaning in most cases, an address isn't 64 chars but 63. However, calling _signedTypedData on addresses of odd-length simply doesn't work. So, to help, I added the padLeft utility function and used it when necessary.

Linter is broken because I believe cairo-format was soft-broken in 0.10.3 (need to double check that).

Tests are still failing because I have a weird issue with tx_info.version where it sometimes shows up as 1 and sometimes as 0x100000000000000000000000000000001.... need to investigate some more...

Linter is still broken.
Fixed all tests except from the one I mentioned above. Indeed something is odd with the tx_version...

I suggest we merge this one, I've created a tracking issue for tx_version bug :)


doc: posix: options: alphabetic order, heading levels

reorder posix options and option groups so that they are
in alphabetical order in documentation.
decrement header level of option group items so that they
are not listed in the outline
make column size consistent
note which Kconfig option is used to activate each POSIX Option or Option Group to address this comment.

Doc Preview

@aescolar, @nashif - this is really just a cosmetic change to make docs a bit more readable for the LTS release. Can we merge this prior to v3.7.0? If not, can it be backported for v3.7.1?


Replace ImageContentSourcePolicy by new configuration

Is your feature request related to a problem? Please describe.
As from OpenShift 4.13, ImageContentSourcePolicy is deprecated: https://docs.openshift.com/container-platform/4.13/openshift_images/image-configuration.html#images-configuration-registry-mirror-convert_image-configuration
Need to change this to the new ImageDigestMirrorSet and ImageTagMirrorSet objects.

Hi @fketelaars it looks like the version checks in automation-roles/50-install-cloud-pak/cpfs/cp-ocp-icsp/tasks/main.yml for this patch are wrong. We just ran with this on an OCP 4.12.32 cluster and it was trying to create an ImageDigestMirrorSet rather than an ImageContentSourcePolicy because of the version check failed.
All of the _p_current_ocp_version < '4.12' checks should be - _p_current_ocp_version < '4.13' or you cannot install on a 4.12 cluster (4.14 would also be OK I think, as long as it's not 4.12). Once I made this change I was able bypass the error.
The full error we saw was:
<IP_ADDRESS>> EXEC /bin/sh -c 'rm -f -r /home/cloud-user/cpd-config/fusion/status/tmp/ansible-tmp-1715615122.2915306-6353-17299247688719/ > /dev/null 2>&1 && sleep 0'
fatal: [localhost]: FAILED! => changed=true
  cmd: |-
    oc apply -f /home/cloud-user/cpd-config/fusion/status/openshift/cloud-pak-idms.yaml
  delta: '0:00:01.276810'
  end: '2024-05-13 15:45:23.740366'
  invocation:
    module_args:
      _raw_params: |-
        oc apply -f /home/cloud-user/cpd-config/fusion/status/openshift/cloud-pak-idms.yaml
      _uses_shell: true
      argv: null
      chdir: null
      creates: null
      executable: null
      removes: null
      stdin: null
      stdin_add_newline: true
      strip_empty_ends: true
      warn: true
  msg: non-zero return code
  rc: 1
  start: '2024-05-13 15:45:22.463556'
  stderr: |-
    error: resource mapping not found for name: "cloud-pak-mirror" namespace: "" from "/home/cloud-user/cpd-config/fusion/status/openshift/cloud-pak-idms.yaml": no matches for kind "ImageDigestMirrorSet" in version "config.openshift.io/v1"
    ensure CRDs are installed first
  stderr_lines: <omitted>
  stdout: ''
  stdout_lines: <omitted>

It fails because 4.12 clusters do not have an ImageDigestMirrorSet CRD.

Thank you for catching this @m-g-k , fixed in fk-misc branch

Thanks for the quick patch @fketelaars ! However, I just noticed in the same file that the IDMS creation also needs changing. In this part:
include_tasks: create-idms.yml
  when:
  - _mco_exists
  - (all_config.cp_alt_repo | default({})) == {}
  - _p_current_ocp_version >= '4.12'
- include_tasks: create-idms-alt.yml
  when:
  - _mco_exists
  - (all_config.cp_alt_repo | default({})) != {}
  - _p_current_ocp_version >= '4.12'

The two instances of _p_current_ocp_version >= '4.12' should be _p_current_ocp_version >= '4.13'

Oops. Fixed.


New display style: Human Case

I would like to see a "Human Case", where instead of using a _ or - as seperator I'd like to have a   (space, 0x20, ...).
Example:
#[derive(Display, FromStr, PartialEq, Debug)]
enum StyleExample {
  #[display(style = "Human Case")]
  VarH,
}

assert_eq!(StyleExample::VarH.to_string(), "Var H");

Thanks for posting the issue.
I would like to avoid using terms that are not common.
Could you please tell me the origin of the term "Human Case", if any?
If there is no origin, then heck crate uses the term "Title Case", and I would like to match it.

Could you please tell me the origin of the term "Human Case", if any?

There isn't any. I just searched for something that could describe it ;)
If "Tile Case" is the "official" term I don't mind using it.

For now, I've made ‘[#display(style = "Title Case")]‘ available with 8cfd5b0a78ec60f5a879e22a9b9526a738ccd5a8 & 7a178be6397820847db533873074d6846d849f3b.
If you find a more appropriate style name, please let me know.

Wow, amazing! This issue can be closed.
Thanks a lot for the quick and easy work! :heart:

One thing:
https://github.com/frozenlib/parse-display/blob/7a178be6397820847db533873074d6846d849f3b/parse-display-derive/src/lib.rs#L807-L817
Would you like to add TITLE CASE, Title case and title case as well?

Thanks.
It certainly looks like I should add it.
I've fixed it now in 4893a8a536714d1e8440be47d727990bc9978a20.

Oops.
title case is now title Case, so I'll fix that right away.


Upgrade error-chain to 0.12 and expose it publicly

To also bring the Linux firewall integration into sync with the rest I want to upgrade error-chain. And same as the other crates, as to not repeat old mistakes, expose the ChainedError trait publicly so users of this lib can use display_chain without having to depend on the same version of error-chain themselves.

This change is

Reviewed 2 of 2 files at r1.
Review status: :shipit: complete! all files reviewed, all discussions resolved

Comments from Reviewable


Update Post “2019-12-14-princess-mononoke”

Automatically generated by Netlify CMS

👷 Deploy Preview for mystifying-heyrovsky-e13280 processing.
🔨 Explore the source changes: 0858ab8af07b15433a65e39fafb9c7d2893f47f2
🔍 Inspect the deploy log: https://app.netlify.com/sites/mystifying-heyrovsky-e13280/deploys/622fb27caa490c00093ea20a


Correction for raw affiliation ITAP, Univ. Montpellier, INRAE, Institut Agro, 34060, Montpellier, France

Correction needed for raw affiliation ITAP, Univ. Montpellier, INRAE, Institut Agro, 34060, Montpellier, France
raw_affiliation_name: ITAP, Univ. Montpellier, INRAE, Institut Agro, 34060, Montpellier, France
new_rors: 051escj72;03rnk6m14;003vg9w96;00ftatp57
previous_rors: 051escj72;03rnk6m14;003vg9w96
works_examples: W4319592049;W4382866992
contact: 935be967bd93a807a798ee80a0dfb115:054c5ce5b6e348114835db7f5c71caadfc @ supagro.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-09. The new affiliations should be visible within the next 7 days.


run_squad.py F1 and EM score are differ from tensorflow version

I use squad1.1 data from https://www.kaggle.com/stanfordu/stanford-question-answering-dataset
I ran convert_tf_checkpoint_to_pytorch.py (using google's uncased_L-12_H-768_A-12 model) and run_squad.py. result was
{"exact_match": 73.30179754020814, "f1": 82.10116863001393}

Alse I ran run_squad_hvd.py from https://github.com/lambdal/bert (it wraps original tensorflow BERT with horovod) and result was
{"exact_match": 80.66225165562913, "f1": 88.09365604437863}

bert_config.json is the same.
my parameter's are
pytorch ver
--train_batch_size", default=32,
--learning_rate", default=5e-5.
--max_seq_length", default=384,
--doc_stride", default=128,
--max_query_length", default=64
--predict_batch_size",default=8

tensorflow ver
--train_batch_size=8,
--learning_rate=5e-5,
--num_train_epochs=3.0.
--max_seq_length=384,
--doc_stride=128,
--max_query_length=64,
--predict_batch_size=8

I wonder

If src pretrained model and parameters are the same, results of pytorch version and tensorflow version are too near score, perhaps F1:88, EM:80. Is it right?
If 1. is true, my parameter or procedure is wrong.Where should I see?

I also can't get the same result on my squad dataset


Question: supervisor configuration: where is the bash script located?

I followed the Publish to a Linux Production Environment instruction. But I’m struggling with the supervisor configuration. I have no idea where the bash file is located.
command=bash /var/aspnet/HelloMVC/approot/web
I use the ASP cli-samples (HelloMvc) but there is no “/approot/web” included.
Thanks tons!

@shirhatti Can you help out here?

@stevo-knievo That article is out of date. I'm working on updating it /var/aspnet/HelloMVC/approot/web was the shell script generated with the dnu publish gesture in RC1.
In RC2, replace that with command=dotnet ./foo.dll (where foo is the name of your app.

@shirhatti
it would be good to put documentation, which is not the case today. :wink:


feat (IBM Cloud SCC node sdk ): first release

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


⚠ ClamAV has degraded performance

In 5ab4c35, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 421 ms

Resolved: ClamAV performance has improved in 5538333.


Duke Nukem Megaton Edition Symlink addons to gameroot

Feature Request
Hey there,
I was testing out Luxtorpeda + raze / eduke32 on Duke Nukem 3D: Megaton Edition and found that I couldn't play the Addons: Life's a Beach, Nuclear Winter and Duke it out in D.C.
After referring to raze and eduke32 installation guides I quickly figured out that both engines are expecting the addon files and maps to be in the same directory as the engine itself.
All addons are located at gameroot/addons/[dc/nw/vacation].
Providing eduke32 and raze with symlinks to all files in those folders solved the issue.
Solution
What I'd like to ask if it would be possible to automate this process.
Therfore that Luxtorpeda checks if the folder addons/[dc/nw/vacation] do exist and symlink all files to the gameroot directory?
Since both engines seem not to look up these folders on their own.
Additional Context
I apologize if this would be more appropriate for the actual package and not the luxtorpeda client.
Kind regards,
Vortex :)

@VortexAcherontic
Thanks for the issue report, and this would be a package issue, so I've moved it over here.
Sadly, I don't own this game and looks like it isn't for sale anymore. Could you describe the symlink you're doing? As in what the folder paths would be and where you're trying to put them?
These scripts are the ones that run eduke32 and raze:
https://github.com/luxtorpeda-dev/packages/blob/master/engines/raze/assets/run-raze.sh
https://github.com/luxtorpeda-dev/packages/blob/master/engines/eduke32/assets/run-eduke32.sh
So those would be the places to change, if you can either send me some commands for the symlink or create a pull request for each one individually, then that should help.
Thanks

Hey there currently I am debuging this issue as I noticed that the packages should evaluate the star game by a number. I suspect the nubers are wrong or not set at all and raze and eduke32 scripts do default to LD_LIBRARY_PATH="lib:$LD_LIBRARY_PATH" ./raze or LD_LIBRARY_PATH="lib:$LD_LIBRARY_PATH" ./eduke32
How can I tell luxtorpeda to not fetch the package script from https://github.com/luxtorpeda-dev/packages/releases/download/raze-24/ but to use my modified local shell script?

@VortexAcherontic
There should be a ~/.cache/luxtorpeda directory with a eduk32 and raze folders. If you open the .xz file that it is using, then you can edit the files there. When you do this, the client will extract the files you changed.

@d10sfan Found the issue, fixed the issue and created a PR #561 :)

Closing this to continue discussion in pull request


Player stacking in minimap, right clicking only shows one player

When there is more player in the same direction you can only right click on the one that is on the top of the stack. This is not that bad when the icons are different, as in the images below but it is hard to differentiate when there is stack of the same icon.

2 players at the same direction but right click only shows one.

That's sadly how the Runelite map features work. I have midterms right now but will look at it when that's over.
For now my temporary "solution" would be to focus on the guy who is on top to then see where the other players are.


having trouble with flashing

I am following your Drone book
on the stage when we first execute command
just flash
after long compilation i get this error
   Compiling hello-world v0.1.0 (/Users/abfdogovsky/Documents/hello-world)
error: linking with `drone-ld` failed: exit code: 1
  |
  = note: "drone-ld" "-L" "/Users/abfdogovsky/.rustup/toolchains/nightly-2020-04-30-x86_64-apple-darwin/lib/rustlib/thumbv7m-none-eabi/lib" "/Users/abfdogovsky/Documents/hello-world/target/thumbv7m-none-eabi/release/deps/hello_world-a1ac9290e105fc96.hello_world.5zhwcm3y-cgu.4.rcgu.o" "-o" "/Users/abfdogovsky/Documents/hello-world/target/thumbv7m-none-eabi/release/deps/hello_world-a1ac9290e105fc96" "--gc-sections" "-L" "/Users/abfdogovsky/Documents/hello-world/target/thumbv7m-none-eabi/release/deps" "-L" "/Users/abfdogovsky/Documents/hello-world/target/release/deps" "-L" "/Users/abfdogovsky/.rustup/toolchains/nightly-2020-04-30-x86_64-apple-darwin/lib/rustlib/thumbv7m-none-eabi/lib" "--start-group" "--end-group" "-Bstatic" "/Users/abfdogovsky/.rustup/toolchains/nightly-2020-04-30-x86_64-apple-darwin/lib/rustlib/thumbv7m-none-eabi/lib/libcompiler_builtins-864f260ba82b8e34.rlib" "-Bdynamic"
  = note: Error: Couldn't find `llvm-size`

The issue is already closed by the author, but for future discoverability I will add the solution: run just deps to install required dependencies first. Please correct me if I'm wrong.


Add examples using Algorithm HS256

Add an example encoding and decoding using Algorithm HS256, because of the examples of the README.md doesn't work.

you have the old version?


webapp: az webapp container up release as preview on extensions

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/panchagnula/azure-cli-extensions.git@NKing-container-up#subdirectory=src/$EXT&egg=$EXT"

@Nking92 can you please review to make sure i haven't modified anything while trying to rebase to upstream master

Looks good

@tjprescott  can i get a review here please so that i can merge the changes?


SITES-10893 Function cannot be performed by keyboard alone

https://jira.corp.adobe.com/browse/SITES-10893
This issue has been reproduced on Firefox(MacOS), but with this fix the issue has no longer been reproduced:
https://github.com/adobe/coral-spectrum/assets/71783091/cf2635d1-c897-48bc-858d-e243b5ad769f

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.

@bcenusa @dpetcu can you take a look at the PR please?

Closing the ticket, it's no longer reproducing


Precision issues when camera is far away

Related to #114
Related to https://github.com/google/model-viewer/pull/3496
When the camera is far away (xyz values > ~1000 or so) there seem to be precision issues in the positioning of the ray origins resulting in "chunky" or pixelated looking images. Scaling the scene and values down to be within [-1, 1] fixes the issues.
Not exactly sure what can be done about this other than recommending that people scale the scene as appropriate.
Seen on second generation Mac M1 laptop.
Example:

Zooming out significantly in a demo results in the same kind of artifacts:

I wonder if we should apply a translation / scale factor to the camera transform and model to keep the camera in a relative "safe" numeric zone for rendering.

I took a look at the issue and it seems that computing the rayDirection differently for the perspective camera resolve the issue. There might still be precision issues to some extent, but at least the buggy is no longer blocky (well, it is, but that's intended :smile: ) and zooming out doesn't cause the environment to show artifacts.
See #190 for the change.

I wonder if we should automatically apply a translation / scale factor to the camera transform and model to keep the camera in a relative "safe" numeric zone for rendering.

Scaling the model is a bit tricky IMO. With different light types being introduced, the light should be 'scaled' as well, which isn't the default behaviour in glTF or Threejs. Given that glTF is the prominent format, I would also say the scale of the scene should be in meters. So if any scaling needs to be done, it should be on the shader side of things, or at least, completely transparent to the user.
It might be a good idea to have test-cases that demonstrate the bounds of what still renders correctly and where precision issues become an issue (too large and too small). Perhaps a simple scene that is scaled up/down. This not only gives the bounds users should try to stay within, but could also help detect regressions or improvements.

Thanks for the fix - it's a great improvement. Now the precision issues will be a result of ray origin calculations but they seem to be less of an issue an start showing up closer to ~400,000-500,000 units away from the origin which I think is reasonable for now. I think we can wait until there are other issues before investing in more complex solutions to this. Thanks again!


US-Core: Implement Operation $docref

Is your feature request related to a problem? Please describe.
This operation is used to return all the references to documents related to a patient.
Describe the solution you'd like

Implement Operation $docref
Add Operation Tests
Drive off of the Search API
https://www.hl7.org/fhir/us/core/OperationDefinition-docref.html

Describe alternatives you've considered
None
Additional context
None

some related conversation: https://chat.fhir.org/#narrow/stream/179166-implementers/topic/.24docref.20operation.20Q
see especially the [suggested] JIRA on a potential change from CodeableConcept to Codings, and the comment about not enforcing the required binding to http://hl7.org/fhir/ValueSet/c80-doc-typecodes


Fixing XSS Vulnerabilities: Workflow Component

Addressing the comments and added missing XSS Fixes solved by #1039

Addressing the comments and added missing XSS Fixes solved by #1039


Add xml to Microsoft.Diagnostics.Runtime nupkg

/cc @leculver

@chcosta,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Initial schema for rvm-csi

I thought this schema might write in yaml, and used to describe RVM-CSI API naming and its API documentation, currently it is used to describe CPU feature.


Support serving of favicon.ico, sitemap.xml and robots.txt

See #89
See Pull request #37

looking forward to finishing


Cow: Watch piegaming

Cow requests the watch of the watch_keyword piegaming. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

piegaming has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Rejected by Jeff Schaller in Charcoal HQ. Reason: 'should exclude the domain with (?!.com)'


webviewRef.current.goForward() not working for android.

webviewRef.current.goForward() simply doesn't work, goBack() is working but goForward() is not working even if navState.canGoForward is true.

How you set the ref, I always fail to set Ref?


Collect cloud provider flavor disk data

This PR will populate the appropriate DB column for flavor disk information
as described in the below table by Cloud Provider
(Azure uses the term to Series for Flavor)

MiQ DB column
Amazon
OpenStack
Azure

root_disk_size
NA
disk
OS disk

swap_disk_size
NA
swap
swap

ephemeral_disk_size
instance_store_size
ephemeral
NA

ephemeral_disk_count
instance_store_volumes
1 if ephemeral > 0
NA

Fixes #4427

@bdunne, @matthewd, @Fryguy please review.

@Fryguy Thank you for the help. I believe I've addressed all the points you've raised.

@jvlcek There is a test failure on Travis.  Please investigate.
Besides that, what is holding up this PR?  /cc @blomquisg

@chessbyte I'm investigating the failure now. @Fryguy had reviewed. Waiting for him to OK how I addressed the issues he raised.

:+1:

@Fryguy Thanks for the :+1: Can someone please merge this? @chessbyte or @blomquisg perhaps?

The failure is some sporadic error in self_service UI, so merging.


JAMES-3600 Fix check Content-Length when ProvisioningTest

The test case ProvisioningTest.provisionMailboxesShouldNotDuplicateMailboxByName some times pass, some times fail.
Because the Content-Length is not a 2735 for all repeat tests.
Example:

If the id in response is 9 => length =1
If the id in response is 10 => length =2

I checked other JUnit tests that have validated content length in https://github.com/apache/james-project/pull/494.
But I don't think the risk from them. So, I just only fix this JUnit test

Good catch!


transparency: extra depth buffer

Use Case
Child of #256
When PDB geometry is rendered, there are so many overlapping spheres that the alphas accumulate to essentially be totally opaque.  They don't look transparent.  This can happen with any type of geometry but PDBs are easy to see the problem.
Acceptance Criteria
We want roughly the frontmost faces of an agent to show transparency and hide the complexity of the possible transparent layers  behind it.  At least on a per agent basis but possibly globally.
Details
Consider implementing a second depth buffer to handle transparency, and then generate a color buffer to be blended with the regular opaque geometry as an overlay.

Depends on results of the easier-to-implement #309
This ticket probably merits a meeting to discuss and brainstorm further.


Added one Useful Link

Have Added Scaler Topics C++ Program Page under font_to_svg(anchored - C++ program). Kindly Please check the suggested changes.

i will do this one... but this is the only one. thank you.


Know if there are no differences

Hi
Thank you very much for this code that is very useful to me.
I would like to know if there is any method to know if there are no differences and thus not show anything or if it is possible to add it

As far as I'm aware most, if not all, renderers should produce either nothing or a string saying 'No differences found'.
To which renderer are you referring?

@DigiLive There shouldn't be any output. However, when I compare a.txt with a.txt in the example folder I get a difference.
@@ -32,3 +32,3 @@
     </body>
 </html>

I tired the orginal from chrisboulton/php-diff. There it isn't. I will track that tomorrow which commit caused that.

v1.15 doesn't have that issue. It came with v1.16

98d993ef14bc7a254c0b060a33b77b3a0bd3c54d is the cause.

Agree... It's a combo of option trimEqual and context.
I think I've found where it goes wrong, but I need to verify some things because of the SequenceMatchers's complexity.

Related to issue #24.

@csalgadow We need your feedback for the renderer

Thank you very much
I have downloaded the updated version and now it works very well, it gives message of differences not found except in Text Unified Diff Text Context Diff that does not output any text, although for me it is not necessary.
I will include your scipt in the online voting platform that I have at https://bitbucket.org/csalgadow/demokratian_votaciones/
The idea is that users can check if any of the scripts that collect the vote has been altered so that they can be sure that the vote is secure.
Again, thank you very much for your quick response and for your work with php-diff

You're very welcome.
If you have any other issues/suggestions, please let us know!


New ebuild: gui-apps/labwc-tweaks

Hey, I use labwc-tweaks and decided to make an ebuild for it.
I tried to make everything as up-to-standard as possible with the wayland-display repo as possible.
Thanks :)

Thanks for the PR!


Backport significant changes from the 5.x branch to 4.x

Backport the changes for
#283
#280
#287
#288
#296
From 5.x to 4.x

Done!


Request for compatibility with OldTitleBar

First off, thank you for making this. I'm really enjoying my time with this plugin.
As of now, when using OldTitleBar and while on the friends/DMs tab, CollapsibleUI's buttons show up on the right of the close button.

I hope it's not too much trouble to ask if you could make it so they appear on the left instead.
Thank you and best regards.

Fixed in upcoming release


WIP: update kfile pkg to use lazy path

What type of PR is this?

What this PR does / why we need it:
update kfile to use lazy path
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 55.504%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
6812

Relevant Lines:
12273

💛  - Coveralls


Use POSIX string equality operator

shebang is looking for sh but is using bash's == operator to compare strings.
According to http://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html correct operator is =.

To further clarify here's the output of running update.sh before this fix on a Debian with sh being linked to dash:
λ eta git:(master) ./update.sh
./update.sh: 6: [: Already up-to-date.: unexpected operator

Thanks for the catch!