Crash when opening plugins tab on all versions

Vendetta doesn't work anymore on any build. It stopped working on all three of my devices, one by one. Lower builds were working fine until the storage was moved from MMKVManager to FS
I think the error occurred after this commit ( I'm not sure )
I noticed that the plugins tab stopped working when the app data went over 300MB.
Error - https://pastebin.com/ACALsjvG
Versions
--  Vendetta - 98cecb4
-- Discord - 211.2 (211202)
--  React - 18.2.0
--  React Native - 0.72.3-discord-23
-- Bytecode - 94
Versions
--  Vendetta - 98cecb4
--   Discord - 203.4 (203204)
--  React - 18.2.0
--  React Native - 0.72.3-discord-19
--  Bytecode - 94
Platform
--  Loader - VendettaXposed
-- Operating System - Android 10
--  SDK - 29
--  Manufacturer - Realme
-- Model - RMX1825

Versions
--  Vendetta - 98cecb4
--  Discord - 202.8 (202208)
--   React - 18.2.0
--   React Native - 0.72.3-discord-19
--   Bytecode - 94
Platform
--   Loader - VendettaXposed
--  Operating System - Android 13
--   SDK - 33
--   Manufacturer - Xiaomi
--   Model - 22101320l

Versions
--  Vendetta - 98cecb4
-- Discord - 211.8 (211208)
--  React - 18.2.0
--  React Native - 0.72.3-discord-23
--   Bytecode - 94
Platform
--   Loader - VendettaXposed
--   Operating System - Android 12
--   SDK - 31
--  Manufacturer - vivo
--   Model - vivo 1907

after this commit eed535549eb0987c5bd866c616d23f5cc4a13b1c
JSON Parse error: Unexpected end of input

    at parse (native)
    at ?anon_0_?anon_0_get (Vendetta:1:7951)
    at next (native)
    at anonymous (/tmp/tmp3dxsp38q/ReactAndroid/hermes-engine/.cxx/MinSizeRel/5w36155w/arm64-v8a/lib/InternalBytecode/InternalBytecode.js:610:30)
    at step (/tmp/tmp3dxsp38q/ReactAndroid/hermes-engine/.cxx/MinSizeRel/5w36155w/arm64-v8a/lib/InternalBytecode/InternalBytecode.js:595:23)
    at anonymous (/tmp/tmp3dxsp38q/ReactAndroid/hermes-engine/.cxx/MinSizeRel/5w36155w/arm64-v8a/lib/InternalBytecode/InternalBytecode.js:609:17)
    at tryCallOne (/tmp/tmp3dxsp38q/ReactAndroid/hermes-engine/.cxx/MinSizeRel/5w36155w/arm64-v8a/lib/InternalBytecode/InternalBytecode.js:53:16)
    at anonymous (/tmp/tmp3dxsp38q/ReactAndroid/hermes-engine/.cxx/MinSizeRel/5w36155w/arm64-v8a/lib/InternalBytecode/InternalBytecode.js:139:27)
    at apply (native)
    at anonymous (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:165:2034)
    at _callTimer (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:165:575)
    at _callReactNativeMicrotasksPass (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:165:1017)
    at callReactNativeMicrotasks (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:165:3831)
    at __callReactNativeMicrotasks (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:48:3309)
    at anonymous (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:48:1164)
    at __guard (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:48:2908)
    at flushedQueue (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:48:1122)
    at invokeCallbackAndReturnFlushedQueue (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:48:1044)```
```in at
in On
in RCTView
in Unknown
in Unknown
in StaticContainer
in EnsureSingleNavigator
in SceneView
in RCTView
in Unknown
in MaybeNestedStack
in RCTView
in Unknown
in RNSScreen
in Unknown
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in InnerScreen
in AnimatedComponent(InnerScreen)
in Unknown
in Unknown
in ReanimatedScreenWrapper
in Screen
in SceneView
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in RNSScreenStack
in ScreenStack
in NativeStackViewInner
in RCTView
in Unknown
in SafeAreaProviderCompat
in NativeStackView
in PreventRemoveProvider
in NavigationContent
in Unknown
in NativeStackNavigator
in RCTView
in Unknown
in SafeAreaPadding
in SafeAreaPaddingView
in Provider
in Unknown
in Unknown
in StaticContainer
in EnsureSingleNavigator
in SceneView
in RCTView
in Unknown
in MaybeNestedStack
in RCTView
in Unknown
in RNSScreen
in Unknown
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in InnerScreen
in AnimatedComponent(InnerScreen)
in Unknown
in Unknown
in ReanimatedScreenWrapper
in Screen
in SceneView
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in RNSScreenStack
in ScreenStack
in NativeStackViewInner
in RCTView
in Unknown
in SafeAreaProviderCompat
in NativeStackView
in PreventRemoveProvider
in NavigationContent
in Unknown
in NativeStackNavigator
in StaticContainer
in EnsureSingleNavigator
in SceneView
in RCTView
in Unknown
in MaybeNestedStack
in RCTView
in Unknown
in RNSScreen
in Unknown
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in InnerScreen
in AnimatedComponent(InnerScreen)
in Unknown
in Unknown
in ReanimatedScreenWrapper
in Screen
in SceneView
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in RNSScreenStack
in ScreenStack
in NativeStackViewInner
in RCTView
in Unknown
in SafeAreaProviderCompat
in NativeStackView
in PreventRemoveProvider
in NavigationContent
in Unknown
in NativeStackNavigator
in Profiler
in RCTView
in Unknown
in SafeAreaPadding
in SafeAreaPaddingView
in _default
in RCTView
in Unknown
in AnimatedComponent(View)
in Unknown
in RCTView
in Unknown
in Wrap
in AnimatedComponent(Wrap)
in Unknown
in GestureDetector
in LaunchPadContainer
in DCDVisualEffectViewTarget
in Profiler
in StackNavigator
in PanelsViewController
in RCTView
in Unknown
in SafeAreaPadding
in SafeAreaPaddingView
in SafeAreaWrapper
in RNCSafeAreaProvider
in SafeAreaProvider
in DCDSafeArea
in DCDSafeArea
in SafeAreaProvider
in KeyCommandsView
in KeyCommandsView
in ErrorBoundary
in RNGestureHandlerRootView
in GestureHandlerRootView
in GestureWrapper
in t
in WebViewContextProvider
in EnsureSingleNavigator
in BaseNavigationContainer
in ThemeProvider
in NavigationContainerInner
in AppNavigationContainer
in AppNavigationContainerOrEmpty
in RedesignIconContextProvider
in AccessibilityPreferencesContextProvider
in RootThemeContextProvider
in RootThemeContextProvider
in ReanimatedScreenProvider
in Profiler
in AppContainer
in Profiler
in profiler(AppContainer)
in Profiler
in App
in RCTView
in Unknown
in RCTView
in Unknown
in AppContainer```

I see a slightly different error on higher build
Discord: 211202 ( Android )
Vendetta: eed5355

JSON Parse error: Unexpected character: a

SyntaxError: JSON Parse error: Unexpected character: a
    at parse (native)
    at ?anon_0_?anon_0_get (Vendetta:1:7951)
    at next (native)
    at anonymous (/tmp/tmptfj5ay7j/ReactAndroid/hermes-engine/.cxx/MinSizeRel/4f394w5o/arm64-v8a/lib/InternalBytecode/InternalBytecode.js:610:30)
    at step (/tmp/tmptfj5ay7j/ReactAndroid/hermes-engine/.cxx/MinSizeRel/4f394w5o/arm64-v8a/lib/InternalBytecode/InternalBytecode.js:595:23)
    at anonymous (/tmp/tmptfj5ay7j/ReactAndroid/hermes-engine/.cxx/MinSizeRel/4f394w5o/arm64-v8a/lib/InternalBytecode/InternalBytecode.js:609:17)
    at tryCallOne (/tmp/tmptfj5ay7j/ReactAndroid/hermes-engine/.cxx/MinSizeRel/4f394w5o/arm64-v8a/lib/InternalBytecode/InternalBytecode.js:53:16)
    at anonymous (/tmp/tmptfj5ay7j/ReactAndroid/hermes-engine/.cxx/MinSizeRel/4f394w5o/arm64-v8a/lib/InternalBytecode/InternalBytecode.js:139:27)
    at apply (native)
    at anonymous (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:166:2034)
    at _callTimer (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:166:575)
    at _callReactNativeMicrotasksPass (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:166:1017)
    at callReactNativeMicrotasks (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:166:3831)
    at __callReactNativeMicrotasks (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:49:3309)
    at anonymous (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:49:1164)
    at __guard (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:49:2908)
    at flushedQueue (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:49:1122)
    at invokeCallbackAndReturnFlushedQueue (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:49:1044)

in at
in On
in RCTView
in Unknown
in Unknown
in StaticContainer
in EnsureSingleNavigator
in SceneView
in RCTView
in Unknown
in MaybeNestedStack
in RCTView
in Unknown
in RNSScreen
in Unknown
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in InnerScreen
in AnimatedComponent(InnerScreen)
in Unknown
in Unknown
in ReanimatedScreenWrapper
in Screen
in SceneView
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in RNSScreenStack
in ScreenStack
in NativeStackViewInner
in RCTView
in Unknown
in SafeAreaProviderCompat
in NativeStackView
in PreventRemoveProvider
in NavigationContent
in Unknown
in NativeStackNavigator
in RCTView
in Unknown
in SafeAreaPadding
in SafeAreaPaddingView
in Provider
in Unknown
in Unknown
in StaticContainer
in EnsureSingleNavigator
in SceneView
in RCTView
in Unknown
in MaybeNestedStack
in RCTView
in Unknown
in RNSScreen
in Unknown
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in InnerScreen
in AnimatedComponent(InnerScreen)
in Unknown
in Unknown
in ReanimatedScreenWrapper
in Screen
in SceneView
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in RNSScreenStack
in ScreenStack
in NativeStackViewInner
in RCTView
in Unknown
in SafeAreaProviderCompat
in NativeStackView
in PreventRemoveProvider
in NavigationContent
in Unknown
in NativeStackNavigator
in StaticContainer
in EnsureSingleNavigator
in SceneView
in RCTView
in Unknown
in MaybeNestedStack
in RCTView
in Unknown
in RNSScreen
in Unknown
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in InnerScreen
in AnimatedComponent(InnerScreen)
in Unknown
in Unknown
in ReanimatedScreenWrapper
in Screen
in SceneView
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in RNSScreenStack
in ScreenStack
in NativeStackViewInner
in RCTView
in Unknown
in SafeAreaProviderCompat
in NativeStackView
in PreventRemoveProvider
in NavigationContent
in Unknown
in NativeStackNavigator
in Profiler
in RCTView
in Unknown
in SafeAreaPadding
in SafeAreaPaddingView
in Unknown
in RCTView
in Unknown
in AnimatedComponent(View)
in Unknown
in RCTView
in Unknown
in Wrap
in AnimatedComponent(Wrap)
in Unknown
in GestureDetector
in LaunchPadContainer
in DCDVisualEffectViewTarget
in Profiler
in StackNavigator
in PanelsViewController
in RCTView
in Unknown
in SafeAreaPadding
in SafeAreaPaddingView
in SafeAreaWrapper
in RNCSafeAreaProvider
in SafeAreaProvider
in DCDSafeArea
in DCDSafeArea
in SafeAreaProvider
in AssistantContextProvider
in KeyCommandsView
in KeyCommandsView
in ErrorBoundary
in PortalProviderComponent
in RNGestureHandlerRootView
in GestureHandlerRootView
in GestureWrapper
in t
in WebViewContextProvider
in EnsureSingleNavigator
in BaseNavigationContainer
in ThemeProvider
in NavigationContainerInner
in AppNavigationContainer
in AppNavigationContainerOrEmpty
in RedesignIconContextProvider
in AccessibilityPreferencesContextProvider
in RootThemeContextProvider
in RootThemeContextProvider
in ReanimatedScreenProvider
in Profiler
in AppContainer
in Profiler
in profiler(AppContainer)
in Profiler
in App
in RCTView
in Unknown
in RCTView
in Unknown
in AppContainer

I am not sure why nobody has said this yet, but at least for me, even uninstalling and reinstalling didn't work, but clearing the app's cache and data fixed this issue for me.
I believe it may be related to this comment made in another issue:

After some testing I concluded this:
Let's first start off with that I personally use the latest version of discord however anything I will discuss here has been tested on 207.7 aswell.
Firstly, to fix the issue clear your cache and the entire data of your app, you will lose as your plugins and themes but you won't need to reinstall discord all together + you'll have a working vendetta again.
Secondly, this seems to only happen when installing a lot of plugins using the plugin-browser plugin, after scrolling down a while it gets very laggy, downloads take way longer, pressing gets laggy etc.
When installing plugins using the discord plugins channel it seems to work fine and won't crash vendetta. Furthermore, it seems that if you search for a plugin in the plugin-browser instead of scrolling it also works fine and doesn't lag.
What I think is happening (this is not based an any evidence since I don't know how to test this effectively) is that when scrolling down in the plugin-browser (btw scrolling down too far makes it loop back which is also weird) it probably doesn't install the plugin you want correcly/fully turning it into an uncomplete file which crashes the plugins tab. Again, I don't have any evidence for this so this needs to be investigated futher.
For now, I suggest staying away from the plugin-browser all together (or atleast filter by search before installing), this should prevent the issue from accuring. However, this is just what I experienced and I could have just gotten lucky or smth.
(On a sidenote, I haven't had anything break (except this) with vendetta on the latest discord version (208.17) so if anyone could clarify what exactly should be broken that isn't in 207.7 that would be great.)

Originally posted by @sbot50 in https://github.com/vendetta-mod/Vendetta/issues/202#issuecomment-1859089175

I am not sure why nobody has said this yet, but at least for me, even uninstalling and reinstalling didn't work, but clearing the app's cache and data fixed this issue for me.
I believe it may be related to this comment made in another issue:

I've tried reinstalling and clearing data, but it only works for a little while before breaking again. I'm not going to keep doing that every few days. Like I said before, this problem started happening on older versions when the storage was moved from MMKVMANAGER to FS. After migrating to the new storage system, the issue was supposed to be resolved. Although it did get resolved, some users are still experiencing issue with older versions that were not affected before and as well as newer versions.

I can confirm that this is a different issue, and a result of the migration of the storage system. Unfortunately, none of us could reproduce the bug, hence we have no clue what's actually going on
Anyone that can reproduce this and happen to have access to the debug websocket, may evaluate the following:
nativeModuleProxy.RTNFileManager.readFile(`${nativeModuleProxy.RTNFileManager.getConstants().DocumentsDirPath}/vd_mmkv/VENDETTA_PLUGINS`, "utf8").then(console.log).catch(console.error)

The output possibly will be useful to us

[Debugger] Prompt history loaded                  > nativeModuleProxy.RTNFileManager.readFile(`${nativeModuleProxy.RTNFileManager.getConstants().DocumentsDirPath}/vd_mmkv/VENDETTA_PLUGINS`, "utf8").then(console.log).catch(console.error)
 > [Vendetta] { _40: 0, _65: 0, _55: null, _72: null }
 >
   [Vendetta]
 >

Oh, so the file content is empty, which is never supposed to happen..
Can you also evaluate with the one with JSON Parse error: Unexpected character: a?

The error message is too big. I can only see half of it.
https://mclo.gs/HaD1YFT

any updates?


Remove unnecessary check

Resolves #1

Huh, looks like some other bugs exist.
I'll jump into some fixes later.


builder-base: install go-licenses to different folders

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve


[CARBONDATA-3015]  Support Lazy load in carbon vector

This PR depends on PR https://github.com/apache/carbondata/pull/2822
Even though we prune the pages as per min/max there is a high chance of false positives in case of filters on high cardinality columns. So to avoid that we can use the lazy loading design. It does not read/decompresses data and fill the vector immediately when the call comes for data filling from spark/presto.
First only reads the required filter columns give back to execution engine, execution engine starts filtering on the filtered column vector and if it finds some data need to be read from projection columns then only it starts reads the projection columns and fills the vector on demand. It is the concept of presto and same is integrated with spark 2.3. Older versions of spark cannot use this advantage as ColumnVector interfaces are non-extendable.
For the above purpose added new classes 'LazyBlockletLoad' and 'LazyPageLoad' and changed the carbon vector interfaces.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/814/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1011/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9079/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/826/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9091/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1023/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/828/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9093/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1025/

retest this please

retest this please

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9175/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9183/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/927/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1125/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9189/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9196/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/952/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1160/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9217/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9232/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/971/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9238/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1184/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1228/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1015/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9280/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1027/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1239/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9292/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1240/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9293/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1028/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1031/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9296/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1243/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1033/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1245/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1052/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9318/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1054/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1268/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9320/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1058/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1272/

Build Success with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9324/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1065/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9331/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1279/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1067/

Build Failed  with Spark 2.3.1, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/9334/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1282/

LGTM


Fix remaining memory leaks, .clang-format, fixes

I hopefully fixed the other memory leaks in #157 . I also added .clang-format. I don't really care about styling, but it would be nice to keep it unified throughout the whole project. Feel free to change it.
Currently, we dynamically allocate memory for dirs in the load_files function. What I think would be better is to scan the /exercise folder for all the files and malloc all the necessary memory at the beginning (with some kind of init function). Then we would have just one cleanup function in the end.

I'll review this tomorrow! thanks for helping on this one

Also added data types exercise: Resolves #131

FYI, i rebased master into 'fix/memory-leaks' to eliminate the huge diff, looks like that created some conflicts in your branch.

Finally, it should be okay. I am sorry for the mess. Git is difficult for me.


Gradle publish

Should match maven for artifacts, including $NAME-platform artifacts for jnigen natives.
TODO:

[x] Javadocs from GWT are broken somehow. I commented out the javadocs jar for now.

https://github.com/libgdx/libgdx/pull/6725/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R98

[ ] Developers listing in pom. I just copy/pasted from gdx-jnigen.
[ ] Fully test and verify everything matches perfectly.
[ ] Verify signing and release to sonatype. I've only tested ./gradlew publishToMavenLocal
[ ] Populate POM_DESCRIPTION in gradle.properties for each project.
[ ] Decide if we care about parent/child module links in pom. I don't think these do anything?

https://github.com/libgdx/libgdx/blob/master/extensions/gdx-box2d/pom.xml#L15-L19
https://github.com/libgdx/libgdx/blob/master/extensions/gdx-box2d/gdx-box2d/pom.xml#L4-L9

gwt's javadocs issue has been work around by specifying the sourcepath option.
I have also moved gwt-dev to a compileOnly dependency to more accurately match maven.
https://github.com/libgdx/libgdx/blob/42a59f2f7bbef736ef61df45ab89475473cffeff/backends/gdx-backends-gwt/pom.xml#L32
@MrStahlfelge can you verify this is correct?


[PDI-17293] - Pentaho Reporting Output: Paged HTML option throws erro…

…r when selected as output processor

Added Java7 NIO's API to deal with paths and filenames.

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/steps/pentahoreporting/PentahoReportingOutput.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1.2% :small_red_triangle_down:

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -0.4% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.4% :small_red_triangle_down:
Line Change: -3.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Branch Change: -2.6% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.7% :small_red_triangle_down:
Complexity Change: -1.2% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

@pamval , @pentaho-lmartins , @mbatchelor , @lucboudreau please review and merge if it's all ok.

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/steps/pentahoreporting/PentahoReportingOutput.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.trans.steps.calculator.CalculatorMetaFunction

Branch Change: -8.7% :small_red_triangle_down:
Complexity Change: -3% :small_red_triangle_down:
Instruction Change: -0.7% :small_red_triangle_down:
Line Change: -0.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Method Change: -1% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Branch Change: -2.6% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

Bah ... this class is a disaster. I don't see a reasonable way to create a test case for this without completely refactoring the thing. Accepting the change in spite of the lack of a test case because in it's current condition, it's unsuitable for a test case.


http://sorgalla.com/projects/jcarousel/ Source Discrepency

http://sorgalla.com/projects/jcarousel/ offers quite a different version from what is available on git-hub, although both are tagged with 0.2.8. Perhaps most notable is the CSS styling, things break if styled using the version available on http://sorgalla.com/projects/jcarousel/ but then switching to the git-hub hosted source.

The master branch contains the new version 0.3 which is still work in progress and not released yet. This is a complete rewrite and not compatible with the 0.2.x versions.

Ah yes my mistake, I thought I had downloaded from the tags tab, but must have been the master branch. The filename also had 0.2.8 in there which didn't help my confused self.
Thanks.


fix: add last upload id

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#745  👈
#535
#534
#533
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on  Graphite


update testing documentation

Check and update testing documentation with latest changes.
At least it contains old action signature.
PR are welcome.

Also would be great to review best practicies section.

still used deprecated methods, eg. Controller(model, services)

@christianalfoni we need document cerebral-testable and connect/Computed behaviour with NODE_ENV='test'

done


Add system test of string normalization in GCS

This tests that the client library does not normalize the string encoding, which would affect access to buckets with similar but differently-encoded names.
The test has a hard-coded bucket name - should this be a constant in StorageTestCase?

failure was just appveyor choking.


added safeDivide func for gval

check values, and return 0  on fail

For which use case you need this new function? are the ternary operators not enough?
divisor == 0 ? 0 : dividend / divisor


Added DISTRICTS OF TAMIL NADU

@vinayak-kr
Thanks for creating 4 PRs in our Project.
Keep Contributing


feat: make Trunc a Quotient

mathlib3 PR: https://github.com/leanprover-community/mathlib/pull/18320

bors merge


The Icon component can't be used

Bug Report
Steps
A clear and concise description of steps to reproduce the problem.
Expected Result
The result that you expected.
Actual Result
The actual result that happened 💣
Version
x.y.z
Testcase

Please fill issue template fully :octocat:


Provide way to skip compileOnly dependencies

Create a mechanism to skip compileOnly dependencies.
(this ticket was moved from the core dependency-check issue tracker here: https://github.com/jeremylong/DependencyCheck/issues/2149)

Pretty sure this can be accomplished using existing features:
dependencyCheck {
   skipConfigurations = ['compileOnly', 'compileClasspath']
}

It works properly for compileOnly and compileClasspath, but is there a limit which configurations can be skipped?
I have dependencies with providedCompile for which following configuration doesn't work:
dependencyCheck {
   skipConfigurations = ['compileOnly', 'compileClasspath', 'providedCompile', 'testImplementation']
}

After changing dependencies from providedCompile to both compileClasspath and testImplementation, vulnerabilities are not shown in report.

I am using org.owasp:dependency-check-gradle:5.3.2 and couldn't get this working
dependencyCheck {
skipConfigurations  = ['compileOnly']
failBuildOnCVSS=1
}


VS 2022 issue

I have an android Mobile Blazor Bindings that works fine under Visual Studio 2019 Version 16.11.7.
Android 10.0 (Q)
Trying the same project under VisualStudio 2022 Version 17.0.1 gives the following:
Unhandled Exception
The type initializer for 'Microsoft.AspNetCore.Components.ElementReferenceJsonConverter' threw an exception

It was an fixed by a NuGet upgrade


correct misplaced paren

corrects misplaced paren
also adds commas for copy/paste convenience

Thanks for the fix.


Lint with rubocop-jekyll

This just lays the foundation to decouple from Jekyll's bundled .rubocop.yml.
Doesn't make any changes to any file in lib/ or spec/..

TIL'd about rubocop todo. Thanks!


Update Playwright driver to 1.14.0-next-1627675969000

The parameter definitions of Locator#select_option is still strange...


#12 issue sidebar active link styles

Hey Aadarsh, let's delete all the braches which are already merged...to keep the project clean. What do u say?


Minor Issue with border glow on search input field

I can't find a way to change the blue border around the active search field.

https://github.com/bastienwirtz/homer/issues/483#issuecomment-1174245908


Make Plugin-checking check hash of file

RN Using SNAPSHOT builds or plugins that dont specify a version in the jar-name means it just wont update the plugin
For example all our plugins, like MineInAbyss, are not updated even when a new SNAPSHOT build is published as the file is the "same"

Should effectively be fixed now that Keepup tracks the date header. Open an issue in Keepup if needs reopening.


Next/Previous post

It would be nice to have the ability to link to the next/previous post from each post.

If I get some time this month I will work on a PR for this functionality.

This makes perfect sense and seems like an elegant solution.

Having seen the discussion on categories(#19), the aforementioned mdFile struct could contain a reference for the category/s it's in which can then be used to segment files for each categories index.

Hmm... To be honest, I think this is getting a bit too complicated, as to seemingly defeat the purpose of underblog. I believe prev/next links should not take categories into account, but rather navigate globally, between all posts.


[RFC] configuration: fix configure scheme

Both compute_net and mgmt_net can only represent one
subnet. This commit changes the configure scheme for
compute_net and mgmt_net to accept a list of subnets.
both values should be now a YAML list of subnets like:
  launcher:
    compute_net: [<IP_ADDRESS>]
    mgmt_net: [<IP_ADDRESS>/24, <IP_ADDRESS>/24]

or
  launcher:
    compute_net:
      - <IP_ADDRESS>
    mgmt_net:
      - <IP_ADDRESS>/24
      - <IP_ADDRESS>/24

Fixes #232
Signed-off-by: Simental Magana, Marcos<EMAIL_ADDRESS>

missing code coverage, created early PR for reviewing purposes

Coverage decreased (-0.03%) to 64.68% when pulling 2f83fe85ff5018ddb9a030c2a6e1998c0c4f8d46 on mrkz:fix_conf_scheme into dd98c8947fcf0431c4606760491c81c64576703e on 01org:master.

There's a duplicated function ( equalNetSlice(slice1, slice2 []string) bool ) which is duplicated in payloads/configure_test.go and configuration/configuration_test.go as it wasn't clear enough where this could be placed to be used in both places, any suggestion here would be appreciated.

Also, please notice that by the nature of the Issue (#232) this PR fixes, the YAML schema is changed; some data which was previously a YAML string type will be now a YAML list type,  breaking previous CIAO clusters setup, in order to fix it, both compute_net and mgmt_net values in yaml should be changed into a list format. e.g:

Previous PR format:

  launcher:
    compute_net: <IP_ADDRESS>
    mgmt_net: <IP_ADDRESS>/24

New PR format:

  launcher:
    compute_net:
    -  <IP_ADDRESS>
    mgmt_net:
    -  <IP_ADDRESS>/24

@sameo the order of the subnets does not really matter. We scan all the network interfaces and see if they belong to one or more of the subnets. To run traffic we choose the first network interface that matched any of the subnets.
So the interface discovery order matters (not the subnet order).

@mrkz So we're in case #2, where order does not matter. I think you can order them without copying, remove duplicates and then call reflect.DeepEqual(slice1, slice2) on them.
Since this really is a subnet comparison routine, it probably makes sense to have it exported from libsnnet.

Coverage decreased (-0.09%) to 65.265% when pulling 3f90027f12187f14ca70b5040b7174900fed09e2 on mrkz:fix_conf_scheme into 56930eab39e00665cbdcd9f56bd0748f3129ee67 on 01org:master.

Coverage decreased (-1.07%) to 64.357% when pulling dcc21dc89350ecf7ff760699862c02feb171b841 on mrkz:fix_conf_scheme into 981bb660aac26415bd7976100eb5f337eb5a8572 on 01org:master.

Coverage decreased (-1.03%) to 64.431% when pulling db86e6323b2bb4095dfe7f77c0f64f762f0d54a0 on mrkz:fix_conf_scheme into d6cef89020e9574ee91792a662977d4972c04b9e on 01org:master.

Coverage increased (+0.1%) to 65.554% when pulling c49e3af7b077812727699bb3211737c7a059804a on mrkz:fix_conf_scheme into d6cef89020e9574ee91792a662977d4972c04b9e on 01org:master.


Integrate all pieces together for 01_serialize_transmission_sweep.py

This is the last piece of #13
We may need some adjustments after completion of #14, #15

Thank yoU! Looks great!


containerization: Deprecate Ip from tablet record

The IP does not need to be stored in the tablet record. Most code
should use the hostname instead. If the IP is really needed, it's
better to resolve it from the hostname.
This is prep work for introducing MySQLHostname which will not
store an IP either. This way, it will be less confusing if no
IP is cached.

LGTM but not sure about the travis failures

Two of them look like a travis problem. So, I'm running the full suite on my box as we speak, just to make sure.

Tests are kind of passing on my box. I see some flakyness that doesn't look related. So, I'm going to optimistically merge this.


feat: gate calibrations as a kwarg of the converted program call

Issue #, if available:
https://github.com/orgs/amazon-braket/projects/2/views/6?pane=issue&itemId=35379372
Description of changes:

Implement a GateCalibrations for composing and collecting a set of defcal
Enforce the body of gate calibration to have only pulse operations
Add gate_calibrations kwarg in converted program call to attach defcal to a main program

gate_calibrations = GateCalibrations()

@gate_calibrations.register("h", (0,))
def cal_1():
    pulse.barrier(0)

@gate_calibrations.register("h", (1,))
def cal_2():
    pulse.delay(1, 0.00123456)

@aq.main
def my_program():
    h(0)

print(my_program(gate_calibrations=gate_calibrations).to_ir())

Alternatively, AutoQASM can export a GateCalibrations object that is compatible with device.run() (WIP)
bdk_gate_calibrations = gate_calibrations.export()
task = device.run(my_program(), shots=1000, gate_calibrations=bdk_gate_calibrations)

TODO

register new gate
calibration with args
more complete tests
(optional) convert to BDK GateCalibrations
(optional) warning: overwriting definitions
warning: defined calibrations not used
throw: defcal takes invalid args while it should not
simplify type hint

Testing done:
tox
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[x] I have read the CONTRIBUTING doc
[x] I used the commit message format described in CONTRIBUTING
[x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This is awesome! Let's pick only one way for it to work for now. This will make our tools easier for our customers to learn.
I think either option is good (initial instinct is that I like device.run? no strong preference)


Support Custom SimDeviceSets

It's possible to change Simulator.app to use a different device set by passing -DeviceSetPath as an arg to the launched Simulator. This will be vastly preferable to using Prefixes to isolate simulators between processes.
cc @mmmulani @ExtremeMan

tests red?

The test is failing on pre-Xcode 7. I've updated the tests to take this into account and skip in the Custom Device Set case.
We can get probably get this working for Xcode 6 by injecting and swizzling the Simulator app process (which we can't do for Xcode 7 because amfid). I am happy to do this later (if at all) for Xcode 6, if you agree?

ahh, this lgtm then
I'm happy to pass on Xcode 6 support as long as we can get as far back as iOS 7 running under Xcode 7. (which should be possible if we copy the simulator SDKs over)

Added some comments =) Feel free to ignore because they are mostly nits and I don't know what is preferred style here.


Allow overriding port values for named ports in arbiter config

The problem is this: https://github.com/vkottler/runtimepy/blob/master/runtimepy/net/arbiter/config.py#L50
If we want to define some "known ports" this way in the configuration, how could we populate real values into the configuration e.g. from command-line arguments?

Implemented on https://github.com/vkottler/runtimepy/pull/132.


HADOOP-18231. Fixes failing tests & drain stream async.

Description of PR
This is a combined PR for:
Add new test for Prefetching:
JIRA. Previous PR before rebase was opened here.
ITestS3AInputStreamPerformance was failing when prefetching is enabled. This PR disables prefetching when running ITestS3AInputStreamPerformance and adds in a new test class ITestS3PrefetchingInputStream with tests specific for prefetching.
Drain stream async:
JIRA. Previous PR before rebase was opened here.
If we close the prefetching input stream before prefetched blocks have finished reading the S3 input stream, the sdk repeatedly complains "Not all bytes were read from the S3ObjectInputStream". This happened on S3AInputStream as well, see this issue for more details. Closing the stream before draining it will abort the connection, so to allow for connection reuse we drain it asynchronously when remaining bytes is > async drain threshold.
Fix ITestS3AOpenCost:
JIRA
This test was failing after the rebase.
 testOpenFileShorterLength fails because inputStreamStats need to be created before opening the stream so that the time to prepare to open the file is included.
testOpenFileLongerLength fails because in this read method when for eg: file length is 8 and length to read is 18, it swallows the EOF exception and returns the num of successful bytes read which will be 8. So readFully doesn't throw an EOF immediately but then tries to read bytes 8-18 again, and then fails.
How was this patch tested?
Tested in eu-west-1 by running
mvn -Dparallel-tests -DtestsThreadCount=16 clean verify

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 19s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ feature-HADOOP-18028-s3a-prefetch Compile Tests _

+1 :green_heart:
mvninstall
44m 28s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
compile
1m 11s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 58s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 52s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
mvnsite
1m  7s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
javadoc
0m 53s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 51s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 46s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
shadedclient
27m 35s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 47s

the patch passed

+1 :green_heart:
compile
0m 51s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 51s

the patch passed

+1 :green_heart:
compile
0m 44s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 44s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 30s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11)

+1 :green_heart:
mvnsite
0m 48s

the patch passed

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 34s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 24s

the patch passed

+1 :green_heart:
shadedclient
26m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
3m 12s
/patch-unit-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

118m 27s

Reason
Tests

Failed junit tests
hadoop.fs.s3a.read.TestS3InputStream

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 284e82df641d 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-HADOOP-18028-s3a-prefetch / 3e5113f97350690a5dbe890e26197a42992cab41

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/1/testReport/

Max. process+thread count
595 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ feature-HADOOP-18028-s3a-prefetch Compile Tests _

+1 :green_heart:
mvninstall
67m  9s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
compile
1m  2s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 56s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 45s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
mvnsite
1m  3s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
javadoc
0m 44s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 49s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 37s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
shadedclient
22m 34s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 27s
/patch-mvninstall-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

-1 :x:
compile
0m 30s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-aws in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javac
0m 30s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-aws in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
compile
0m 28s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
javac
0m 28s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 28s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13)

-1 :x:
mvnsite
0m 30s
/patch-mvnsite-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

-1 :x:
javadoc
0m 33s
/results-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 4 new + 38 unchanged - 0 fixed = 42 total (was 38)

-1 :x:
spotbugs
0m 29s
/patch-spotbugs-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
shadedclient
23m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 40s
/patch-unit-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

123m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 013096cf9b4b 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-HADOOP-18028-s3a-prefetch / 13d181f3db9110d31a6fa791f69838160d52747b

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/2/testReport/

Max. process+thread count
639 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ feature-HADOOP-18028-s3a-prefetch Compile Tests _

+1 :green_heart:
mvninstall
42m 44s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
compile
0m 55s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 47s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 41s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
mvnsite
1m  0s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
javadoc
0m 41s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 44s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 40s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
shadedclient
24m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 39s

the patch passed

+1 :green_heart:
compile
0m 46s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 46s

the patch passed

+1 :green_heart:
compile
0m 35s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 35s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 24s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15)

+1 :green_heart:
mvnsite
0m 41s

the patch passed

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

-1 :x:
javadoc
0m 31s
/results-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 4 new + 38 unchanged - 0 fixed = 42 total (was 38)

+1 :green_heart:
spotbugs
1m 26s

the patch passed

+1 :green_heart:
shadedclient
23m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
3m  7s
/patch-unit-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

107m 48s

Reason
Tests

Failed junit tests
hadoop.fs.s3a.read.TestS3InputStream

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 4d4e1ccd53e7 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-HADOOP-18028-s3a-prefetch / d96babea2786a71d8623b5c2ffe2e3ab44b4358f

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/4/testReport/

Max. process+thread count
524 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
15m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ feature-HADOOP-18028-s3a-prefetch Compile Tests _

+1 :green_heart:
mvninstall
39m 23s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
compile
0m 57s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 48s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 48s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
mvnsite
1m  5s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
javadoc
0m 45s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 49s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 40s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
shadedclient
23m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 41s

the patch passed

+1 :green_heart:
compile
0m 44s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 44s

the patch passed

+1 :green_heart:
compile
0m 38s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 38s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 25s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 3 new + 14 unchanged - 1 fixed = 17 total (was 15)

+1 :green_heart:
mvnsite
0m 43s

the patch passed

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 19s

the patch passed

+1 :green_heart:
shadedclient
21m 29s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 42s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

116m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 53bf47fe0868 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-HADOOP-18028-s3a-prefetch / 52e6f96ecd9de25a919337633049c0c1adf0ef9d

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/5/testReport/

Max. process+thread count
740 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

made some comments. looked at the EOF swallowing code...i think we need to be happy there that all is good in terms of handling recoverable failures but not retrying on nonrecoverable ones.

@steveloughran thanks for reviewing, I've updated as per your comments

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
6m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ feature-HADOOP-18028-s3a-prefetch Compile Tests _

+1 :green_heart:
mvninstall
42m  9s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
compile
1m  1s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 50s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 44s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
mvnsite
0m 57s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
javadoc
0m 40s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 44s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 38s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
shadedclient
23m 39s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 40s

the patch passed

+1 :green_heart:
compile
0m 47s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 47s

the patch passed

+1 :green_heart:
compile
0m 38s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 38s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 29s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 3 new + 14 unchanged - 1 fixed = 17 total (was 15)

+1 :green_heart:
mvnsite
0m 46s

the patch passed

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 32s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 24s

the patch passed

+1 :green_heart:
shadedclient
23m 41s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 59s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

113m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 0b4784e0f25d 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-HADOOP-18028-s3a-prefetch / ebb1b1dcc3dc90612057f3e16e9895cd603d4041

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/7/testReport/

Max. process+thread count
612 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
18m 19s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ feature-HADOOP-18028-s3a-prefetch Compile Tests _

+1 :green_heart:
mvninstall
42m 29s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
compile
1m  0s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 51s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 44s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
mvnsite
1m  0s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
javadoc
0m 42s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 43s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 39s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
shadedclient
24m 24s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 42s

the patch passed

+1 :green_heart:
compile
0m 49s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 49s

the patch passed

+1 :green_heart:
compile
0m 42s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 42s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 26s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 3 new + 14 unchanged - 1 fixed = 17 total (was 15)

+1 :green_heart:
mvnsite
0m 44s

the patch passed

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 34s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 26s

the patch passed

+1 :green_heart:
shadedclient
23m 41s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  5s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

125m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 452c5c56edcf 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-HADOOP-18028-s3a-prefetch / ebb1b1dcc3dc90612057f3e16e9895cd603d4041

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/6/testReport/

Max. process+thread count
523 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
19m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ feature-HADOOP-18028-s3a-prefetch Compile Tests _

+1 :green_heart:
mvninstall
41m 21s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
compile
0m 59s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 45s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 46s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
mvnsite
0m 58s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
javadoc
0m 41s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 46s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 41s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
shadedclient
24m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 40s

the patch passed

+1 :green_heart:
compile
0m 45s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 45s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 23s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 3 new + 14 unchanged - 1 fixed = 17 total (was 15)

+1 :green_heart:
mvnsite
0m 40s

the patch passed

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 32s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 26s

the patch passed

+1 :green_heart:
shadedclient
25m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 16s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

127m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux ccfb94facc8c 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-HADOOP-18028-s3a-prefetch / a5f32e747dc2c8315704180941d5567cce4ef0cf

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/8/testReport/

Max. process+thread count
571 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ feature-HADOOP-18028-s3a-prefetch Compile Tests _

+1 :green_heart:
mvninstall
41m  0s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
compile
0m 55s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 47s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 42s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
mvnsite
0m 55s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
javadoc
0m 40s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 43s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 29s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
shadedclient
23m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
0m 43s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 43s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 24s

hadoop-tools/hadoop-aws: The patch generated 0 new + 14 unchanged - 1 fixed = 14 total (was 15)

+1 :green_heart:
mvnsite
0m 39s

the patch passed

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 14s

the patch passed

+1 :green_heart:
shadedclient
23m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 47s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

104m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 349990bc413e 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-HADOOP-18028-s3a-prefetch / 115c4e0edcca8a621f8ba86f4ac63c8c24ff354b

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/9/testReport/

Max. process+thread count
601 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  7s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ feature-HADOOP-18028-s3a-prefetch Compile Tests _

+1 :green_heart:
mvninstall
41m 33s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
compile
1m  1s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 48s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 44s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
mvnsite
0m 58s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
javadoc
0m 50s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 50s

feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 43s

feature-HADOOP-18028-s3a-prefetch passed

+1 :green_heart:
shadedclient
28m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 45s

the patch passed

+1 :green_heart:
compile
0m 50s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 50s

the patch passed

+1 :green_heart:
compile
0m 42s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 42s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 28s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 1 new + 14 unchanged - 1 fixed = 15 total (was 15)

+1 :green_heart:
mvnsite
0m 48s

the patch passed

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 35s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 27s

the patch passed

+1 :green_heart:
shadedclient
26m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  2s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

114m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 01a1f9042d56 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
feature-HADOOP-18028-s3a-prefetch / eca1cba362212e129c0fff89b1739b679996b2cf

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/10/testReport/

Max. process+thread count
622 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4386/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

thanks @steveloughran, have added in the new line

Hey @steveloughran, we have a few prefetching PRs starting to get blocked on this one which fixes some unit tests. Can you take a look next week?


IOS run issue

Hi everyone:) I have a problem with my project when I add this plugin. The application is started and immediately collapses. When I remove this plugin all works fine. I made all according Install guide. In xcode I have this error (please look on screenshots)
http://prntscr.com/f1dkaa,
http://prntscr.com/f1dkv1,
http://prntscr.com/f1dluo,
http://prntscr.com/f1dmee,
My system information:
Cordova CLI: 6.5.0
Ionic Framework Version: 3.1.0
Ionic CLI Version: 2.2.2
Ionic App Lib Version: 2.2.1
Ionic App Scripts Version: 1.3.5
ios-deploy version: 1.9.1
ios-sim version: 5.0.13
OS: macOS Sierra
Node Version: v7.8.0
Xcode version: Xcode 8.3.1 Build version 8E1000a
I will be grateful for help:)

Go to General settings, and set Deployment Info / Main Interface to none.
Also be sure Launch Screen File is empty in App Icons and Launchg Images

I'm grateful for the help that helped me. This helped me:) I'm happy now.


Move printing sub-test information into test harness

This removes all the duplicated code from each test, and moves it to
test harness so that we have single place where this information is
printed.
Signed-off-by: Radek Szymanski<EMAIL_ADDRESS>

Raised https://github.com/KhronosGroup/OpenCL-CTS/issues/427 so we review the list of required image formats.


Remove pattern1.py

Related Issue
Closes: #166
Describe the changes you've made ✍
removed the py file also
Screenshots (if any) 📸

@AtharvePandey close the previous pr then as you have made two prs

@AtharvePandey if you liked this repo please give it a star.


Installation Issue (Please include to your user guide...)

cannot install via composer require zoutapps/laravel-backpack-multiauth --dev directly if anyone want to install your package out of the fresh Laravel installation.
Error:
[InvalidArgumentException]   Could not find package zoutapps/laravel-backpack-multiauth at any version for your minimum-stability (stable). Check the package spelling or your m   inimum-stability
Can only install by update composer.json
"require-dev": {         "zoutapps/laravel-backpack-multiauth": "dev-master",     },

As this is more or less an issue with composer and we currently have the "stable-no release" badge in the Readme I think this is not really necessary to change.
If you think this must be mentioned in the readme pleas create a pull request for the readme.

As this is more or less an issue with composer and we currently have the "stable-no release" badge in the Readme I think this is not really necessary to change.
If you think this must be mentioned in the readme please create a pull request for the readme.
Closing this.


Reduce macOS overscroll friction

Increases the frictionFactor on BouncingScrollPhysics when decelerationRate = ScrollDecelerationRate.fast. This in effect reduces the friction when overscrolling. Now it's double the friction compared to ScrollDecelerationRate.normal. Previously, it was over 7 times in order to match other macOS apps. But it made it impossible to use some common Flutter interactions like RefreshIndicator. Even though this change makes it less "native", I think the experience is better.
Fixes #119702
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing.

(triage) @moffatman Do you still have plans to work on this PR and respond to the feedback given above?

Ran into the same issue with CupertinoSliverRefreshControl + ClampingScrollPhysics. I don't think there is any easy way to have it communicate with the physics. I will capture some videos of before/after the change compared to native

Look like in UIKit, when you have a UIRefreshIndicator, it makes that "segment" of overscroll easily scrollable, while applying harsh friction beyond it. Not sure if that's easily possible in flutter?
Current behaviour

I can't get the flutter list to refresh without flinging (as the fling code has different friction handling).
After the first "easy" UIKit scrolled section, the frictions match up, which we would lose if merging this PR.

https://user-images.githubusercontent.com/789275/229949953-f9c6ae0c-fbf4-44f4-a8e1-cd9ed7b7e41e.mov
With this PR

Doing the pull-to-refresh takes the same amount of overscroll as in UIKit
After/without any refresh indicator, flutter applies relatively less friction than UIKit

https://user-images.githubusercontent.com/789275/229949970-3e263a29-83d6-4a27-8004-a2bb580760d3.mov

Look like in UIKit, when you have a UIRefreshIndicator, it makes that "segment" of overscroll easily scrollable, while applying harsh friction beyond it.

I haven't quite followed the details of the UIKit behavior you're observing, but this description sounds like the sort of thing that should be possible to express in the sliver protocol. It's a "scroll effect", where you'd be taking the distance the user has scrolled along a somewhat abstract coordinate axis, and then doing something nonlinear with it so that it has an effect more complex than literal scrolling.
Because CupertinoSliverRefreshControl is already based on a sliver, that could offer a way to get the effect you want there.

the sort of thing that should be possible to express in the sliver protocol.

Good point! I think this makes sense on the physics though. Otherwise, every sliver would have to implement this special case, or a specific sliver would have to be included wherever we would want this behavior.


can't use for new lazada seller center return undefined error

A PHP Error was encountered
Severity:    Notice
Message:     Undefined index: Product
Filename:    /var/www/web/public_html/application/vendor/rocket-labs/sellercenter-sdk-php/src/RocketLabs/SellerCenterSdk/Endpoint/Product/Response/GetProducts.php
Line Number: 43

@luqmanpaisal The PHP SDK supports the API described on https://sellerapi.sellercenter.net/
Since Lazada migrated to a different Seller Center where also API payloads and responses did change, as far as we know. This is not supported by us and the SDK. You need to raise your question via https://lazada-sellercenter.readme.io/docs to get some help. This is not the correct channel, neither is this SDK intended to support the different payload and response formats.


publish normal artifact (in addition to gradle portal)

this way we can write:
    dependencies {
        classpath 'com.palantir.configurationresolver:gradle-configuration-resolver-plugin:0.2.0'
    }

which is more consistent with usage of internal plugins

@atrocities + @nmiyake any thoughts?

Yup I'm fine with this


Fixes LIKE special characters escaping for Cubrid/MSSQL/Oracle/SQLite in yii\db\QueryBuilder (#8120)

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
#8120

I report - I fix. (tm) :)
I could fix this with no upgrade note but I don’t think that copy-pasting in this case is a smart idea. But it’s up to you. Or I can move $escapeChars to QueryBuilder as a protected property.

We can probably introduce a method like protected getLikeEscapeCharacters() and use it to keep backwards compatibility of the existing interface.

I modified tests to test LIKE special characters and discovered that Oracle, Cubrid and SQLite all suffer from this bug (confirmed with a manual testing). They simply all imply ESCAPE ‘’ by default.
I want to fix them all and also improve tests for this case.
@samdark, should I:

modify #8120
open individual issues per driver
open a common issue for these 3

?
I also stick to
protected $likeCharacterReplacements = [
    ‘la-la’ => ‘bla-bla’,
    //
];

protected $likeEscapeCharacter = null;

as it looks like exactly what we need (luckily all dbs have the same syntax for escape characters).

Modify #8120 and this pull request.

Did it in the issue. I will update this PR as soon as all tests pass.

Okay, it’s ready.

Thank you!

Thanks too! The best is yet to come… ;)


Add 1hour to Resources Page

Please add 1hour to Resource Page under

Link to: https://1hour.life/

@sradu Is this possible? I'm not sure, this was requested by the PO of 1hour.life. They also just launched mobile apps.


Bug 1325025 code block and bold issue fixed.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Exchange-Server-2013/active-directory-permissions-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-a-mailbox-database-copy-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/add-the-federation-mailbox-to-the-ad-rms-super-users-group-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/applicationimpersonation-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/archiveapplication-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/audit-logs-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/configure-a-cross-forest-send-connector-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/configure-activation-policy-for-a-mailbox-database-copy-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/configure-exchange-2013-for-split-permissions-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/configure-mail-flow-and-client-access-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/configure-message-retry-resubmit-and-expiration-intervals-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/configure-the-managed-folder-assistant-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/configure-the-maximum-recording-duration-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/configure-um-to-work-with-lync-server-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/configuring-federated-sharing-between-exchange-organizations-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/create-a-digital-certificate-request-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/create-a-mailbox-audit-log-search-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/create-a-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/create-an-email-address-policy-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/create-and-manage-distribution-groups-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/create-certificates-for-um-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/create-or-modify-a-mobile-device-mailbox-policy-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/customize-the-built-in-dlp-sensitive-information-types-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/data-loss-prevention-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/database-availability-groups-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/database-copies-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/databases-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/deploy-exchange-2013-um-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/disable-or-enable-exchange-search-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/disaster-recovery-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/distribution-groups-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/dlp-policy-templates-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/e-mail-address-policies-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/enable-imap4-in-exchange-2013-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/enable-or-disable-email-for-a-mail-contact-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/enable-the-mrs-proxy-endpoint-for-remote-moves-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/exchange-server-certificates-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/export-dlp-sensitive-information-types-from-exchange-2013-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/federated-sharing-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/header-firewall-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/iis-7-net-extensibility-component-is-required-longhorniis7netext-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/iis-logs-and-log-parser-studio-reports-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/import-custom-prompts-from-exchange-2007-to-exchange-2013-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/import-or-export-certificates-for-um-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/in-place-archiving-in-exchange-2013-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/information-rights-management-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/install-the-exchange-2013-management-tools-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/journaling-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/legal-hold-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

Exchange-Server-2013/legalholdapplication-role-exchange-2013-help.md
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[ProgressPlugin] webpack progress shows deranged on windows 10.1803 with new console terminal

Bug report

What is the current behavior?
webpack progress shows deranged

If the current behavior is a bug, please provide the steps to reproduce.

run npx webpack -w (with webpack.ProgressPlugin)

What is the expected behavior?

https://github.com/webpack/webpack/blob/3b6d1495c3858d59cfdb46b2343c07f2e4c1316d/lib/ProgressPlugin.js#L126
It conflict with webpack-cli's logs,  handler(0, "compiling"); should invoked async.
Changing this to process.nextTick(() => handler(0, "compiling")); seem to work fine.

Other relevant information:
webpack version:  4.19.0 (with new webpack.ProgressPlugin())
Node.js version: 10.10.0
Operating System: Windows 10.1803 with default new console terminal (cmd/powershell)
Additional tools:

@Aqours problem still exists? Can you create minimum reproducible test repo?

Clone this repo https://github.com/Semibold/webpack-issues-8066
then run below commend in new  Windows 10 CMD
npm install
npm run watch


cleaned up documentation Globals issue #4539

issue #4539
cleaned up documentation Globals, corrected formatting

Congrats on your first PR @Pansaai! Thanks for stepping up.

Thank you @bigtimebuddy and @GoodBoyDigital for making this a pleasant experience ! Glad i could help.


Add TLS support via configmap and secrets

Adds support to enable TLS for a cluster by mounting secrets into the NATS container with the certificates.  For this to work,  version 1.0.4 of the server has to be used as it is less aggressive when dns lookup fails, which can take some time on pod startup.  Example:
apiVersion: "nats.io/v1alpha1"
kind: "NatsCluster"
metadata:
  name: "nats"
spec:
  # Number of nodes in the cluster
  size: 3

  # Must use 1.0.4 in order to allow waiting for the A record
  # from nodes in the cluster to be ready
  version: "1.0.4"

  tls:
    # Certificates to secure the NATS client connections:
    serverSecret: "nats-clients-tls"

    # Certificates to secure the routes.
    routesSecret: "nats-routes-tls"

Thanks @pires for taking a look, sounds good on changing to constants. Following up in a PR containing these fixes.