Encoder should remove None: Option[T] values

It would be nice if the Encoder would remove the key/value completely when the type is Option[T] and the value is None. Currently, it encodes None to JSON null.
(Json4s works this way.)
This code:
  case class Test(foo: String, bar: Option[String])
  implicit val testEncoder: Encoder[Test] = deriveEncoder
  println(Test("FOO", None).asJson.noSpaces)

currently prints:
{"foo":"FOO","bar":null}

I would like it to be:
{"foo":"FOO"}

@mikaelstaldal you should just use a custom Printer with dropNullKeys = true.
By default it's true.

Ah, that works. But it seems like dropNullKeys by default is false?
This is also something that is missing from documentation.

yes, it's false :) I made a mistake and fixed the comment afterwards

I commented on this elsewhere, so a quick repeat:
My take is that the printer should not modify the actual JSON format. This is something each Encoder should decide for itself. Inevitably there will be a case where you want to combine the two options for different types, AFAICT that's not possible at the moment.

Could nested options be interpreted differently? For
case class Foo(bar: Option[Option[String])
Foo(None) = {}
Foo(Some(None) = {"bar": null}
Foo(Some("actual data") = {"bar": "actual data"}

Now that we have dropNullValues on both the printer and Json I think we can close this.


Implement Genesys Cloud API rate limit retries

Currently HTTP Status 429 is handled as a standard error.
We should implement proper retries.

This will be implemented directly in the go-request package.
See: https://github.com/gildas/go-request/issues/6


How can I CUDA acceleration for the prover?

Can I use GPU to accelerate the prove?I am a beginner of the zkp.

Yes. Turn on the cuda feature flag for therisc0-zkvm crate when you run the prover. If you're run of our examples, they have a cuda feature that passes through to risc0-zkvm, so you can turn on the cuda feature at the command line when running, e.g.
cargo run -r -F cuda

Yes. Turn on the cuda feature flag for therisc0-zkvm crate when you run the prover. Most of our examples have a cuda feature that passes through to risc0-zkvm, so you can turn on the cuda feature at the command line when running, e.g.
cargo run -r -F cuda

thanks,it works

Great!


Error on create Weblogic Container

Good morning. When I run the ./buildDockerImage.sh script the error is showed on Java step.
Set- WebLogic's Version <IP_ADDRESS>
Set- Distribution:Generic
Version= <IP_ADDRESS> Distribution= generic
Checking if required packages are present and valid...
fmw_<IP_ADDRESS>.0_wls_Disk1_1of1.zip: SUCESSO
md5sum: AVISO: 1 linha está formatada inapropriadamente
Building image 'oracle/weblogic:<IP_ADDRESS>-generic' ...
Building image using Dockerfile.'generic'
Sending build context to Docker daemon    839MB
Step 1/19 : FROM oracle/serverjre:8 as builder
pull access denied for oracle/serverjre, repository does not exist or may require 'docker login': denied: requested access to the resource is denied
There was an error building the image.
Congrats for your project and thanks for your support

@adelmosilva
You need to first create the Server JRE image in https://github.com/oracle/docker-images/tree/main/OracleJava/8.  Once you have built the Server JRE image you will see in your local repo an oracle/serverjre:8 image then you can build the WebLogic image.

Not sure if you are aware that we have pre-built images of WebLogic in the Oracle Container Registry https://container-registry.oracle.com/.


beta distribution

do we consider use this repo for distribution before upload to official market?

Thanks for checking out the plugin! At the moment I'm not sure that a beta program is viable. A beta program requires a large enough user base to have people who both want to test experimental features and are willing to provide feedback. Right now I don't think there are enough users. That said, I can see a beta program being useful in the future.
I'm going to close this for now, but feel free to reopen or create a new issue in the future.


kubernetes-cli 1.23.7

Checklist

[X] I have checked the moderation queue that no new version has been submitted (only visible when logged in), or the submitted package version has failed the automated checks.

Please navigate to the following link to view the moderation queue.

[X] I have verified that the new version is a stable release.
[X] I have looked to see if there are any Bug reports that prevents a new version being submitted and that no existing Outdated Reports have been created.
[X] I have verified the new version has a Windows binary (EXE or MSI installer, Zip or other archive, etc).

New Software Version
1.23.7
Download location
https://github.com/kubernetes/kubernetes/releases/tag/v1.23.7
Package Page
https://community.chocolatey.org/packages/kubernetes-cli

@rgl That package version wasn't published. However, the package is up-to-date with the latest version being 1.24.1. So, the package isn't outdated.

I've open https://github.com/chocolatey-community/chocolatey-packages/discussions/1901.


How to use?

I downloaded and built the project hoping to use it to interface OSC with existing LV2 plugins but am left wondering how to use it. The README only informs how to build. It would be advantageous to have a description of what this does and how to use it.

This has no use of its own, it is a header-only library to be embedded as a subproject into other projects. This is intended for developers of LV2 plugins, not users. I figure you are the latter.
Not sure what you're looking for exactly, but eteroj [1] and moony [2] LV2 plugins both make use of this and may be of use to you.
[1] https://open-music-kontrollers.ch/lv2/eteroj/
[2] https://open-music-kontrollers.ch/lv2/moony/

I am a developer working on Zynthian project. I am looking for a method to control LV2 parameters via OSC. The intention is to provide a generic mechanism for using OSC to control any LV2 plugin. I will read the resources you referenced. I would recommend adding to your README a description of the library"s purpose and how to integrate with other code. Cheers!

I am a developer working on Zynthian project. I am looking for a method to control LV2 parameters via OSC. The intention is to provide a generic mechanism for using OSC to control any LV2 plugin.

OK, it was not clear at all what you were looking for and I cannot read minds, sorry for the confusion.

I will read the resources you referenced.

This lib is mainly about serializing/deserializing raw OSC to/from LV2 Atom events, in order to be able to route them between plugins (like MIDI). E.g. the library mainly is for plugin developers, not host developers. It has no notion of lv2:Parameter, that's the host's job to map MIDI/OSC to parameters, this library won't help you in this regard (but stream.h).
You seem to want to do the equivalent to MIDI-learn, just with OSC, I guess?  Well, there's no magic involved there: Run an OSC server in zynthian and come up with some static OSC path-mappings (or offer OSC-learn) for all plugins in the graph.
Disclaimer: I don't know how zynthian works, so I may make totally wrong assumptions.
This lib contains an minimal OSC server (stream.h) without any dependencies, but most other hosts that support OSC use liblo [1].

I would recommend adding to your README a description of the library"s purpose and how to integrate with other code.

Well, I'm its sole user so far, so it was not needed until now :-)
I'll repoen the issue for now
[1] http://liblo.sourceforge.net/

I'm pretty sure I can help you, e.g. hint you in the right direction, as I am both LV2 plugin + host author and knowledgeable in LV2s event system. But in order to help, I would need to know exactly what you're trying to do (and how zynthian works under the hood).


Support PHP 8

Introduction
Support PHP 8 as tests already pass.
Fixes #287

Giving up :(

@szepeviktor thanks for the PR. I'll look into it more carefully this week but I'll have to admit I'm currently focused in finished the next major version of the library you can already see the code in the feature/v6 branch to be able to release it around the time PHP8 hits. Which means that the new version will support PHP7.4 and PHP8.
I might then release the two aroud the same time but I'll mainly focus on v6 and v5 will only receive security fixes if any for another 6 months.

You're welcome.
All right. Removing --ignore-platform-reqs should be enough.

@szepeviktor I'll be switching the package over using githubs actions instead of travis. So I'll close this PR after and will make sure to include PHP8 in the actions like I've already did for the feature/v6 branch.

Thank you.

This is a highly usable integration test suite for PHP/GHA
https://github.com/ergebnis/php-library-template/blob/main/.github/workflows/integrate.yaml


The project can't be run on MacOS X

Hi,
Considering you've switched this project to use LWJGL3, these changes require passing additional property to JVM on MacOS X( any 7\8 jvm will fail): -XstartOnFirstThread
Otherwise application fails during the start with the following:
Exception in thread "main" java.lang.ExceptionInInitializerError 	at org.lwjgl.glfw.GLFW.glfwShowWindow(GLFW.java:1689) 	at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Window.setVisible(Lwjgl3Window.java:174) 	at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.createWindow(Lwjgl3Application.java:326) 	at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.<init>(Lwjgl3Application.java:92) 	at com.mbrlabs.mundus.Main.main(Main.java:40) Caused by: java.lang.IllegalStateException: Please run the JVM with -XstartOnFirstThread and make sure a window toolkit other than GLFW (e.g. AWT or JavaFX) is not initialized. 	at org.lwjgl.glfw.EventLoop$OnScreen.<clinit>(EventLoop.java:64) 	... 5 more
The fix that worked for me was modification of the editor/build.gradle script with extension of the task run with the following:
   jvmArgs "-XstartOnFirstThread"
There is another issue with LWJGL3 and keyboard input that I will post separately.

Hi krukhlis,
thanks for the report. Unfortunally i don't have a mac. Maybe you can make a pull request if this fix works for you.


Strip unnecessary browser tags

        if event['action'] == "browse":
            soup = BeautifulSoup(event['args']['output'], 'html.parser')
            for non_text_tag in soup.find_all(["script", "style", "iframe", "noscript", "header", "footer", "nav"]):
                non_text_tag.decompose()
            text = ' '.join(soup.stripped_strings)
            event['args']['output'] = text

@FreightCompanionDavid the right place for this logic is in opendevin/actions/browse.py, as mentioned in https://github.com/OpenDevin/OpenDevin/pull/410

My bad. I'm on my phone..


[IOTDB-3371] Fix bug when using alias in SELECT clause

Before:

After:

Coverage increased (+0.01%) to 44.562% when pulling 127dd8b9ddef0fe9eb4eef5964baeb1e8f266ae8 on lmh/AliasDebug into eff66ef3a3739da432af15933bc3cdea212ef49d on master.


Better typing for providers and useProvider

I fallback to JsonRpcProvider when there is no web3provider
This causes conflicts because JsonRPCProvider does not have provider.provider but Web3Provider does.
Can we fallback to a generic web3provider instead, and then have ethers.web3provider types be used everywhere?

@rstycedar

Need to focus talent on other tickets, closing this.


Add more configuration options

Coming from Zephyr (and it's BMI160 library), there are two features that seem to be missing that would be really nice to have:

Configuring Accelerometer and Gyroscope Ranges and ODR (see here) -> with the scale/ranges known, this will also fix #2 and allow to calculate meaningful values
Trigger / Interrupt Support (see here)
Setting up the low-pass filter

Sounds like a nice project. I would welcome this in a PR.

That is also what I thought of. I could not immediately think of something simpler that does not lead to returning InvalidInputData errors just for the sake of a "simpler" interface. Also, maybe the user code does not feel as clunky.


KYLIN-3648 Use Path as the input of addResource

Can one of the admins verify this patch?

Pull Request Test Coverage Report for Build 3811

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.001%) to 23.305%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

storage-hbase/src/main/java/org/apache/kylin/storage/hbase/HBaseConnection.java
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java
1
78.12%

Totals

Change from base Build 3810:
0.001%

Covered Lines:
16317

Relevant Lines:
70016

💛  - Coveralls

Codecov Report

Merging #315 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #315   +/-   ##
=========================================
  Coverage     21.29%   21.29%
+ Complexity     4446     4445    -1
=========================================
  Files          1090     1090
  Lines         70016    70016
  Branches      10098    10098
=========================================
  Hits          14913    14913
+ Misses        53702    53701    -1
- Partials       1401     1402    +1

Impacted Files
Coverage Δ
Complexity Δ

...rg/apache/kylin/storage/hbase/HBaseConnection.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...a/org/apache/kylin/dict/Number2BytesConverter.java
81.74% <0%> (-0.8%)
17% <0%> (-1%)

...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java
69.6% <0%> (-0.61%)
7% <0%> (ø)

.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java
66.15% <0%> (+2.3%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e427a...3bcef1a. Read the comment docs.


add $PFLAU sentences

For a better Flarm emulation the $PFLAUsentences are needed.
These sentences should be send every second as a heartbeat signal.
Some Navigation Software (e.g. LK8000) use the $PFLAU to identify the presence of a Flarm and disable all Flarm functions if no $PFLAU is detected.

Example:
$PFLAU,0,1,1,1,0,,0,,*63
PFLAU,,,,,,,,
,
must be send every second!
according to the Flarm dataport manual;
http://delta-omega.com/download/EDIA/FLARM_DataportManual_v3.02E.pdf


distinguish between oloop error vs error in given phrase

Right now the return type of eval is (Outcometree.out_phrase * 'a Output.t, error * string) Result.t, which I feel is a misuse of the Error value. Normally if a function returns an Error, it means the function failed to execute correctly. However, in this case the Error (err,msg) value is actually a correct result from Oloop's perspective. The eval did its job successfully. It called the toploop and found that the given phrase had some error. As I explain in the documentation of Oloop_script, one could very well want to use Oloop to show examples of incorrect OCaml input.
I plan to define the following type:
type 'a outcome = [
| `Ophr_val of out_value * out_type * 'a Oloop.Output.t
| `Ophr_signature of (out_sig_item * out_value option) list * 'a Oloop.Output.t
| `Ophr_exception of exn * out_val * 'a Oloop.Output.t
| `Lexer of Lexer.error * Location.t * string
| `Syntaxerr of Syntaxerr.error * string
| `Typedecl of Location.t * Typedecl.error * string
| `Typetexp of Location.t * Env.t * Typetexp.error * string
| `Typecore of Location.t * Env.t * Typecore.error * string
| `Symtable of Symtable.error * string
]

The first 3 are semantically equivalent to Outcometree.out_phrase * 'a Output.t, and the rest are equivalent to  error * string. Putting them all in a flat list now forces the user to decide what is considered an error or not, which I think is the only option. We really cannot know if evaluation of a script should stop on the first lexer error, for example. Maybe all the subsequent phrases make perfect sense still.
Note that eval could truly fail, e.g. oloop-top shutdown since it was launched. The current implementation doesn't capture this, and maybe it's okay to leave this as an exception.

Right, it is a matter of perspective on what an error is.  Since most of the time the phrases will be perfectly valid, some helper functions to handle that case smoothly are desirable.
I'm not sure why you want to split the Outcometree.out_phrase.  There are already useful functions defined on that value — such as !Oprint.out_phrase.  Maybe
| `Phrase of Outcometree.out_phrase * 'a Output.t

is enough — I think  `Phrase Ophr_eval is as easy as and not much heavier than  `Ophr_val.

why you want to split the Outcometree.out_phrase

True, maybe we shouldn't. My thinking was that it doesn't stand out as a logically distinct item from what we currently call error due to the fact that it includes exceptions. An exception is maybe an error. Probably we want to provide a few groupings that logically mean the following things:

out_phrase: OCaml was able to run the phrase
invalid_ocaml: the phrase isn't a valid OCaml statement, i.e. the current error
any_error: like invalid_ocaml + Ophr_exception
no_error: Ophr_val + Ophr_signature

Now the trick is to think of how to define these. Polymorphic variants would allow us to mix as desired. Or we can provide convenience functions to transform between different representations.
I'll take a shot at it, and we can iterate.

Done in 2ccac62dc157a5d7eb6f190d3a7cbe979d275b2b.


[Feature Request] Duplicate control

I'd like an option to duplicate a control and order it right after the one that got duplicated (saves having to drag around in big boards).
It's useful when doing int toggles, like in this case where I have a bunch of phone wallpapers.

Added in a4b90094632ec7d27a904df6506ff25669983a75, but I would be careful with updating already, since things are still largely untested,

Neat. I'll wait for headers first tho because my current setup is largely complete.

From: Jan Scheiper @.>
Sent: Saturday, January 7, 2023 8:35:33 PM
To: jangxx/VRC-Avatar-Remote-Server @.>
Cc: rurre @.>; Author @.>
Subject: Re: [jangxx/VRC-Avatar-Remote-Server] [Feature Request] Duplicate control (Issue #4)
Added in a4b9009https://github.com/jangxx/VRC-Avatar-Remote-Server/commit/a4b90094632ec7d27a904df6506ff25669983a75, but I would be careful with updating already, since things are still largely untested,
—
Reply to this email directly, view it on GitHubhttps://github.com/jangxx/VRC-Avatar-Remote-Server/issues/4#issuecomment-1374568142, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD7RGWM5TMJ7XNYRVIPCCMLWRGZPLANCNFSM6AAAAAATOJ3O3A.
You are receiving this because you authored the thread.Message ID: @.***>


RHAM-84 Add OpenSearch search backend

https://issues.redhat.com/browse/RHAM-84
This is the pr to add a search backend to the cache manager
The service will be used by the project after that a driver for it is present (e.g.: https://github.com/gingersnap-project/cache-manager/pull/5 for instance)

@ryanemerson I finally added the test and evolved a bit the SearchBackend interface that is supposed to be used within the same Cache Manager, so not exposing it as Cache Manager API.
@wburns As soon as we have the events from the db sync on cache manager I can start to implement the api that will use this service.

Thank you @wburns for the review.
I applied some suggestions. Let me know if there is something else we can improve here.

Thanks @fax4ever!
We can resume the Multi vs Uni debate as we progress and the needs of the endpoints become more clear, but we need to  work on exposing the query capabilities via the REST endpoint now.

Makes sense to me.
Thank you @ryanemerson


Add itcelaya.edu.mx

@devmaufh First stage of verification passed, official domain is celaya.tecnm.mx as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://celaya.tecnm.mx/directorio/

@devmaufh Thank you for your patience while waiting for a review and processing your request. Pull request merged.


remove Bad Apostrophe from README.md

A possessive belonging to an "it" doesn't need an apostrophe. Don't believe me? Ask the Oatmeal (look for the velociraptor)!

Good catch! And I do believe you! :)


Create c++.cpp

Introduced C++ programming language cheatsheet

I have not received my code review, should be done to encourage us continue contributing


LHLS Player

Hi,
bumped into this project coming from LHLS blog post from THEOPlayer and noticed the begging for a FOSS player. Found a post implementing the ideas from Periscope on top of HLS.js:
https://github.com/openfresh/hls.js/commit/8e6746ba0393e424a92c7b5de340e037fdd5e177
Hope it helps

Hey!
Yeah I saw that. Very cool. I've been leaning towards doing low latency DASH though (with HLS fallback) for the next version so that I can do VP9 as well. Not sure.
Thanks for sharing!

Does anyone have a sample embed of this working?


Error: No named parameter with the name 'primary'.

Trying to build, but get this error:
../../../../../.pub-cache/hosted/pub.dev/mat_month_picker_dialog-1.1.1/lib/src/mat_month_picker_dialog.dart:300:9: Error: No named parameter with the name 'primary'.
        primary: isSelected
        ^^^^^^^
../../../../../flutter/packages/flutter/lib/src/material/text_button.dart:146:22: Context: Found this candidate, but the arguments don't match.
  static ButtonStyle styleFrom({
                     ^^^^^^^^^
../../../../../.pub-cache/hosted/pub.dev/mat_month_picker_dialog-1.1.1/lib/src/mat_month_picker_dialog.dart:332:9: Error: No named parameter with the name 'primary'.
        primary: isSelected
        ^^^^^^^
../../../../../flutter/packages/flutter/lib/src/material/text_button.dart:146:22: Context: Found this candidate, but the arguments don't match.
  static ButtonStyle styleFrom({
                     ^^^^^^^^^
Target kernel_snapshot failed: Exception

FAILURE: Build failed with an exception.

Flutter version informations:
Flutter 3.19.1 • channel stable • https://github.com/flutter/flutter.git
Framework • revision abb292a07e (3 days ago) • 2024-02-20 14:35:05 -0800
Engine • revision 04817c99c9
Tools • Dart 3.3.0 • DevTools 2.31.1

I got the same issue

Please upgrade to 1.1.2, fixed in #6.


Placeholder should show up for a TextField with type "time"

If you set a TextField's type to "time" any placeholder text isn't visible.
One should be able to set placeholder text, at the very least a placeholder time that follows the standard placeholder style instead of being styled like input values.
Currently you can set a default value which acts as input text.
This is helpful in conveying to a user the format of the time field they're being asked to fill without pre-setting any values.

@amkkelley Let us know if you can reproduce that we a native input. We try to be as close as possible to the native inputs. We are documenting the time integration in https://material-ui.com/demos/pickers/.


CAMEL-11235: Proposal to fix an issue where a method inherited from a superclass overrides a superinterface method

This PR proposes a fix for CAMEL-11235.
Basically, the BeanInfo introspection mechanism traverses the single rooted class hierarchy collecting overrides first, and then proceed with interfaces.
I've also created a new overload of ObjectHelper.isOverridingMethod(...) to deal with the case where a method inherited from a class overrides a superinterface method.

Thanks for the PR, giving that a test now

@aldettinger btw I wonder if you would fancy looking at https://issues.apache.org/jira/browse/CAMEL-11178 its related to this great fix you did

Hi Claus. I have quite a lot of interviews these days, but I would be happy
to have a look at it in a week or two if it is not too urgent.
On Tue, May 23, 2017 at 2:24 PM, Claus Ibsen<EMAIL_ADDRESS>wrote:

@aldettinger https://github.com/aldettinger btw I wonder if you would
fancy looking at https://issues.apache.org/jira/browse/CAMEL-11178 its
related to this great fix you did
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/camel/pull/1703#issuecomment-303381279, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVIAtYQoAUAoNxv9dnHZRD_g5J-4VOvhks5r8tAPgaJpZM4NhRXp
.

Thanks @aldettinger that sounds good


[IOTDB-6201] Fix possible query timeout error in TimeJoinNode and possible query cycle in last query.

Description
see descriptions in https://issues.apache.org/jira/browse/IOTDB-6201

Codecov Report

Merging #11347 (93c67fd) into master (89f3730) will increase coverage by 0.02%.
Report is 8 commits behind head on master.
The diff coverage is 93.67%.

@@             Coverage Diff              @@
##             master   #11347      +/-   ##
============================================
+ Coverage     48.68%   48.70%   +0.02%
- Complexity    24351    24365      +14
============================================
  Files          2801     2801
  Lines        171838   171878      +40
  Branches      20575    20585      +10
============================================
+ Hits          83651    83718      +67
+ Misses        88187    88160      -27

Files
Coverage Δ

...e/iotdb/db/queryengine/common/MPPQueryContext.java
71.79% <100.00%> (+2.35%)
:arrow_up:

.../planner/distribution/DistributionPlanContext.java
94.44% <100.00%> (+0.32%)
:arrow_up:

...ne/plan/planner/distribution/NodeGroupContext.java
92.30% <100.00%> (ø)

...gine/plan/planner/distribution/SourceRewriter.java
75.03% <100.00%> (+0.17%)
:arrow_up:

...e/plan/planner/distribution/ExchangeNodeAdder.java
70.91% <87.80%> (-1.19%)
:arrow_down:

... and 31 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Nebra Dashboard

Hi when the Nebra Dashboard launched it was working, now any commands sent to any of my miners it does not work. If I need to reboot or shut down i am having to do it manually.
When will we see a fix for the dashboard please?

Please share the details with the error code to<EMAIL_ADDRESS>

There are no error codes, it executes a restart or a shutdown, yet 24 hours pass nothing has happens. This is across all 3 of our devices in different locations with different setups.
Before when we execute a command it use to happen within minutes or within 5 minutes. Now nothing, forced to manually switch the device off.
Also emailing takes over 1 week for somebody to respond....


Makes possible git clone failure reasons stand out

Does the error in question only ever get logged, or can it be returned through the API?
If you want to provide a long-form error message for users, you can construct a fluxerr.Error{...}. In the case that it gets logged, just the error message (which could be this wrapped error) will be output; but if it makes its way back through the API to the user, it will be displayed in full.
For an example of these in use, see https://github.com/weaveworks/flux/blob/master/remote/errors.go.
If it will not be returned via the API ... ignore me.

This branch can be deleted: please see https://github.com/weaveworks/flux/issues/722


🎬 Add tutorial to the docs

Nice! Should we add the video stream that Jamen and I made as well?
https://www.youtube.com/watch?v=56PRggTDcAY&t=6420s

haha yes nice catch!


Add Maldives holidays

Links:

https://en.wikipedia.org/wiki/Public_holidays_in_the_Maldives
https://www.timeanddate.com/holidays/maldives/
http://www.mma.gov.mv/#/about/bankholidays

Implemented in #1508.


pass scenario into definitions

this way you can do things like attach screenshots to the results or getting contexts of the scenario.

Coverage remained the same at 27.668% when pulling c0b74b36008458f09abcde7e0697369b38fc654c on appersonlabs:master into d0ebd44005c195926eec4f42d7858681fc0b47f5 on eridem:master.

blah, messed this up

Coverage remained the same at 27.668% when pulling 45aee69008551837fcc019d175712ffbcf82866b on appersonlabs:master into d0ebd44005c195926eec4f42d7858681fc0b47f5 on eridem:master.


Version the 1.1 PDF of the Kestrel and Web Host topics

Fixes #9565

Cool ... no probs. There's one other ... I'll patch that here. brb

Let me know if you prefer to make that <= 1.1.
Now that we know this approach works, we could even have an = 2.0 remark that says something to effect that 2.0 has reached EOL and to see the 2.1 version (link it).

One more quick note: I was right about the warning, but it isn't on the build itself ... it's limited to the email that is generated about the build. It comes back with ...

Line : [Warning] No intersection between zone and file level monikers. The result of zone level range string < aspnetcore-2.1 is , while file level monikers is aspnetcore-2.1,aspnetcore-2.2.

... and that's on the build details here :point_right: https://opbuildstorageprod.blob.core.windows.net/report/2018\11\13\6a0d29ae-bb37-09f1-c55a-4cfa862c6784\PullRequest\201811130117356690-9567\workflow_report.html?sv=2015-02-21&sr=b&sig=x44U6fuz9rJFloUp6f8mOo%2FWv0Ms7tFKWzzEbgBFkFc%3D&st=2018-11-13T01%3A19%3A12Z&se=2018-12-14T01%3A24%3A12Z&sp=r
... so there is some concern about whatever this ends up rendering correctly. I'll put an internal topic link here so that someone can check ...
Internal Review Topic (Kestrel)

Now that we know this approach works, we could even have an = 2.0 remark that says something to effect that 2.0 has reached EOL and to see the 2.1 version (link it).

That sounds like a great plan. Create an include and use a regex to put that in every file. That would really pat your numbers.
@scottaddie 	@tdykstra 	 is that over-kill?

Right now (based on this PR), someone could load the 2.0 version and receive 2.1 content without any indication that the topic is really a 2.1 topic.
If the build system isn't modified to deal with this scenario ... and if we can't merge with the warning and have it work that way ... and if we don't provision some text at the top for 2.0 ...
... I don't think what we have in the PR right now is going to work out. One of those approaches (or something else) is needed.

Create an include and use a regex to put that in every file. That would really pat your numbers.
is that over-kill?

I think so

@guardrex 	create the include and use it where you need it.

Create the include and use it where you need it.

I can change the link text on these, but how do I handle the link itself? ... it will change for every include. For example ...

For the 1.1 version of this topic, download [URL Rewriting Middleware in ASP.NET Core (version 1.1, PDF)](https://webpifeed.blob.core.windows.net/webpifeed/Partners/URL_Rewriting_1.1.pdf).

Never mind. We'll figure this out later.


Changelog Errors

The changelog functionality is causing all sorts of errors. It is gridlocking the login script. It needs to be resolved immediately, and added to the master.

Found the fix; Nil value on :close() due to changelog variable not being defined if the changelog doesn't exist. It has been changed to only run if the variable exists (aka a file was found).
This fix will be in the next master update.


HADOOP-16711 Add way to skip verifyBuckets check in S3A fs init()

Testing Bucket used : https://mthakur-data.s3.ap-south-1.amazonaws.com/file2
Ran all the UT's and IT's using default settings with S3guard.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 58s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
27m  6s
trunk passed

+1 :green_heart:
compile
0m 38s
trunk passed

+1 :green_heart:
checkstyle
0m 33s
trunk passed

+1 :green_heart:
mvnsite
0m 47s
trunk passed

+1 :green_heart:
shadedclient
20m  8s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 35s
trunk passed

+0 :ok:
spotbugs
1m 22s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 15s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 39s
the patch passed

+1 :green_heart:
compile
0m 34s
the patch passed

+1 :green_heart:
javac
0m 34s
the patch passed

-0 :warning:
checkstyle
0m 26s
hadoop-tools/hadoop-aws: The patch generated 22 new + 15 unchanged - 0 fixed = 37 total (was 15)

+1 :green_heart:
mvnsite
0m 42s
the patch passed

-1 :x:
whitespace
0m  0s
The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
17m 52s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 29s
the patch passed

-1 :x:
findbugs
1m 22s
hadoop-tools/hadoop-aws generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 34s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 36s
The patch does not generate ASF License warnings.

78m 33s

Reason
Tests

FindBugs
module:hadoop-tools/hadoop-aws

Switch statement found in org.apache.hadoop.fs.s3a.S3AFileSystem.doBucketProbing() where default case is missing  At S3AFileSystem.java:where default case is missing  At S3AFileSystem.java:[lines 463-470]

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1838

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux d8622c0ac2b8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / d23317b

Default Java
1.8.0_232

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/1/artifact/out/whitespace-eol.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/1/artifact/out/new-findbugs-hadoop-tools_hadoop-aws.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/1/testReport/

Max. process+thread count
342 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
24m 22s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
23m 46s
trunk passed

+1 :green_heart:
compile
0m 36s
trunk passed

+1 :green_heart:
checkstyle
0m 24s
trunk passed

+1 :green_heart:
mvnsite
0m 40s
trunk passed

+1 :green_heart:
shadedclient
17m 11s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 27s
trunk passed

+0 :ok:
spotbugs
1m  3s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  1s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s
the patch passed

+1 :green_heart:
compile
0m 29s
the patch passed

+1 :green_heart:
javac
0m 29s
the patch passed

+1 :green_heart:
checkstyle
0m 18s
the patch passed

+1 :green_heart:
mvnsite
0m 32s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 42s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

+1 :green_heart:
findbugs
1m 14s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 25s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

91m  0s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1838

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 482fb6d9e33f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / d5467d2

Default Java
1.8.0_242

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/2/testReport/

Max. process+thread count
340 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 16s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
markdownlint
0m  1s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
21m 54s
trunk passed

+1 :green_heart:
compile
0m 32s
trunk passed

+1 :green_heart:
checkstyle
0m 22s
trunk passed

+1 :green_heart:
mvnsite
0m 35s
trunk passed

+1 :green_heart:
shadedclient
16m 24s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s
trunk passed

+0 :ok:
spotbugs
0m 59s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 57s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s
the patch passed

+1 :green_heart:
compile
0m 26s
the patch passed

+1 :green_heart:
javac
0m 26s
the patch passed

+1 :green_heart:
checkstyle
0m 17s
the patch passed

+1 :green_heart:
mvnsite
0m 31s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 15s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 22s
the patch passed

+1 :green_heart:
findbugs
1m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 21s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 27s
The patch does not generate ASF License warnings.

64m 10s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1838

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 70be778f4667 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / cc8ae59

Default Java
1.8.0_242

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/3/testReport/

Max. process+thread count
340 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
21m 40s
trunk passed

+1 :green_heart:
compile
0m 31s
trunk passed

+1 :green_heart:
checkstyle
0m 23s
trunk passed

+1 :green_heart:
mvnsite
0m 36s
trunk passed

+1 :green_heart:
shadedclient
16m 13s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s
trunk passed

+0 :ok:
spotbugs
0m 59s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 57s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s
the patch passed

+1 :green_heart:
compile
0m 26s
the patch passed

+1 :green_heart:
javac
0m 26s
the patch passed

+1 :green_heart:
checkstyle
0m 18s
the patch passed

+1 :green_heart:
mvnsite
0m 30s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 17s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 22s
the patch passed

+1 :green_heart:
findbugs
1m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 25s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

62m 52s

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1838

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux cf0667027565 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / cc8ae59

Default Java
1.8.0_242

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/4/testReport/

Max. process+thread count
342 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

OK, production code all LGTM; just that test tuning
if closing the fs value triggers failures in superclass cleanup, then you are sharing an FS instance between test cases. (i.e you are actually picking up the last one created).
That is fixed now. That was a mistake from my side. Closing "fs" is not causing any problem in superclass cleanup now.
One other thing to notice here is there is only one test case where the 'fs' is actually created. All others are just failure scenarios.

If you disable caching you should get a new one, which you can then close safely
Already disabled file system caching.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
22m 14s
trunk passed

+1 :green_heart:
compile
0m 33s
trunk passed

+1 :green_heart:
checkstyle
0m 26s
trunk passed

+1 :green_heart:
mvnsite
0m 35s
trunk passed

+1 :green_heart:
shadedclient
16m 30s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s
trunk passed

+0 :ok:
spotbugs
1m  0s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 56s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s
the patch passed

+1 :green_heart:
compile
0m 26s
the patch passed

+1 :green_heart:
javac
0m 26s
the patch passed

-0 :warning:
checkstyle
0m 17s
hadoop-tools/hadoop-aws: The patch generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15)

+1 :green_heart:
mvnsite
0m 29s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 25s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 24s
the patch passed

+1 :green_heart:
findbugs
1m  2s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 17s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

64m 38s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1838

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 2732dfab6c4e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e637797

Default Java
1.8.0_242

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/5/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/5/testReport/

Max. process+thread count
425 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

All review comments addressed.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
22m 45s
trunk passed

+1 :green_heart:
compile
0m 35s
trunk passed

+1 :green_heart:
checkstyle
0m 23s
trunk passed

+1 :green_heart:
mvnsite
0m 38s
trunk passed

+1 :green_heart:
shadedclient
16m 26s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s
trunk passed

+0 :ok:
spotbugs
0m 59s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 57s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s
the patch passed

+1 :green_heart:
compile
0m 25s
the patch passed

+1 :green_heart:
javac
0m 25s
the patch passed

+1 :green_heart:
checkstyle
0m 18s
the patch passed

+1 :green_heart:
mvnsite
0m 30s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 16s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

+1 :green_heart:
findbugs
1m  2s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 23s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

65m 21s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1838

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 75831ca7b3e5 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 9709afe

Default Java
1.8.0_242

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/6/testReport/

Max. process+thread count
341 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

testing myself, setting validation to 0 for the entire test run to field test it better.
one failure so far in the new test
[INFO] Running org.apache.hadoop.fs.s3a.ITestS3GuardTtl
[ERROR] Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 7.739 s <<< FAILURE! - in org.apache.hadoop.fs.s3a.ITestS3ABucketExistence
[ERROR] testNoBucketProbing(org.apache.hadoop.fs.s3a.ITestS3ABucketExistence)  Time elapsed: 1.258 s  <<< ERROR!
java.lang.IllegalArgumentException: Path s3a://random-bucket-442f6634-4892-4239-bd8c-ac5a2b0a3700 is not absolute
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:216)
	at org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore.checkPath(DynamoDBMetadataStore.java:1851)
	at org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore.get(DynamoDBMetadataStore.java:718)
	at org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore.get(DynamoDBMetadataStore.java:205)
	at org.apache.hadoop.fs.s3a.s3guard.S3Guard.getWithTtl(S3Guard.java:900)
	at org.apache.hadoop.fs.s3a.S3AFileSystem.innerGetFileStatus(S3AFileSystem.java:2729)
	at org.apache.hadoop.fs.s3a.S3AFileSystem.getFileStatus(S3AFileSystem.java:2696)
	at org.apache.hadoop.fs.s3a.ITestS3ABucketExistence.lambda$testNoBucketProbing$0(ITestS3ABucketExistence.java:66)
	at org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:498)
	at org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:384)
	at org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:453)
	at org.apache.hadoop.fs.s3a.ITestS3ABucketExistence.testNoBucketProbing(ITestS3ABucketExistence.java:64)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
``

Also once I fix that by adding a trailing /, the getFileStatus("/") fails to raise an FNFE, which is because S3Guard is enabled for all buckets on my test setup, and s3guard DDB will create a stub FS Status on a root entry.
java.lang.AssertionError: Expected a java.io.FileNotFoundException to be thrown, but got the result: : S3AFileStatus{path=s3a://random-bucket-11df1b68-2535-4a9b-9fd5-c6a4d5a6c192/; isDirectory=true; modification_time=0; access_time=0; owner=stevel; group=stevel; permission=rwxrwxrwx; isSymlink=false; hasAcl=false; isEncrypted=true; isErasureCoded=false} isEmptyDirectory=UNKNOWN eTag=null versionId=null

	at org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:499)
	at org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:384)
	at org.apache.hadoop.test.LambdaTestUtils.intercept(LambdaTestUtils.java:453)
	at org.apache.hadoop.fs.s3a.ITestS3ABucketExistence.testNoBucketProbing(ITestS3ABucketExistence.java:59)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
	at java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:266)
	at java.util.concurrent.FutureTask.run(FutureTask.java)
	at java.lang.Thread.run(Thread.java:748)

We could consider shortcutting some of the getFileStatus queries against / in S3A FS itself -it's always a dir after all

Two tests are failing. Will debug. Also will rebase from trunk and fix merge conflicts.

[INFO] Running org.apache.hadoop.fs.contract.s3a.ITestS3AContractRootDir
[ERROR] Tests run: 9, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 48.592 s <<< FAILURE! - in org.apache.hadoop.fs.contract.s3a.ITestS3AContractRootDir
[ERROR] testListEmptyRootDirectory(org.apache.hadoop.fs.contract.s3a.ITestS3AContractRootDir)  Time elapsed: 15.053 s  <<< FAILURE!
java.lang.AssertionError:
Expected no results from listLocatedStatus(/), but got 1 elements:
S3ALocatedFileStatus{path=s3a://mthakur-data/fork-0002; isDirectory=true; modification_time=1582129763970; access_time=0; owner=mthakur; group=mthakur; permission=rwxrwxrwx; isSymlink=false; hasAcl=false; isEncrypted=true; isErasureCoded=false}[eTag='', versionId='']
at org.junit.Assert.fail(Assert.java:88)
at org.apache.hadoop.fs.contract.AbstractContractRootDirectoryTest.assertNoElements(AbstractContractRootDirectoryTest.java:218)
at org.apache.hadoop.fs.contract.AbstractContractRootDirectoryTest.testListEmptyRootDirectory(AbstractContractRootDirectoryTest.java:202)
at org.apache.hadoop.fs.contract.s3a.ITestS3AContractRootDir.testListEmptyRootDirectory(ITestS3AContractRootDir.java:82)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)
[ERROR] testSimpleRootListing(org.apache.hadoop.fs.contract.s3a.ITestS3AContractRootDir)  Time elapsed: 0.819 s  <<< FAILURE!
java.lang.AssertionError:
listStatus(/) vs listLocatedStatus(/) with
listStatus =S3AFileStatus{path=s3a://mthakur-data/test; isDirectory=true; modification_time=0; access_time=0; owner=mthakur; group=mthakur; permission=rwxrwxrwx; isSymlink=false; hasAcl=false; isEncrypted=true; isErasureCoded=false} isEmptyDirectory=FALSE eTag=null versionId=null listLocatedStatus = S3ALocatedFileStatus{path=s3a://mthakur-data/fork-0002; isDirectory=true; modification_time=1582129765040; access_time=0; owner=mthakur; group=mthakur; permission=rwxrwxrwx; isSymlink=false; hasAcl=false; isEncrypted=true; isErasureCoded=false}[eTag='', versionId='']
S3ALocatedFileStatus{path=s3a://mthakur-data/test; isDirectory=true; modification_time=1582129765040; access_time=0; owner=mthakur; group=mthakur; permission=rwxrwxrwx; isSymlink=false; hasAcl=false; isEncrypted=true; isErasureCoded=false}[eTag='', versionId=''] expected:<1> but was:<2>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.apache.hadoop.fs.contract.AbstractContractRootDirectoryTest.testSimpleRootListing(AbstractContractRootDirectoryTest.java:235)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)

Two tests are failing. Will debug. Also will rebase from trunk and fix merge conflicts.
Fixed merge conflicts. Above tests are succeeding now.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
22m 46s
trunk passed

+1 :green_heart:
compile
0m 30s
trunk passed

+1 :green_heart:
checkstyle
0m 29s
trunk passed

+1 :green_heart:
mvnsite
0m 43s
trunk passed

+1 :green_heart:
shadedclient
16m 43s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s
trunk passed

+0 :ok:
spotbugs
1m  4s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  2s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed

+1 :green_heart:
javac
0m 27s
the patch passed

-0 :warning:
checkstyle
0m 18s
hadoop-tools/hadoop-aws: The patch generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30)

+1 :green_heart:
mvnsite
0m 32s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m 40s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 30s
the patch passed

+1 :green_heart:
findbugs
1m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 35s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

66m 32s

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1838

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint xml

uname
Linux 9de8b593adf5 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ec75071

Default Java
1.8.0_242

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/8/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/8/testReport/

Max. process+thread count
342 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/8/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 25s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
22m 42s
trunk passed

+1 :green_heart:
compile
0m 31s
trunk passed

+1 :green_heart:
checkstyle
0m 24s
trunk passed

+1 :green_heart:
mvnsite
0m 37s
trunk passed

+1 :green_heart:
shadedclient
16m 19s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 24s
trunk passed

+0 :ok:
spotbugs
1m  0s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 56s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s
the patch passed

+1 :green_heart:
compile
0m 26s
the patch passed

-1 :x:
javac
0m 26s
hadoop-tools_hadoop-aws generated 3 new + 15 unchanged - 0 fixed = 18 total (was 15)

-0 :warning:
checkstyle
0m 18s
hadoop-tools/hadoop-aws: The patch generated 2 new + 30 unchanged - 0 fixed = 32 total (was 30)

+1 :green_heart:
mvnsite
0m 32s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m 35s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

+1 :green_heart:
findbugs
1m  1s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 12s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

65m 10s

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1838

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint xml

uname
Linux 3f134164c323 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 181e6d0

Default Java
1.8.0_242

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/9/artifact/out/diff-compile-javac-hadoop-tools_hadoop-aws.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/9/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/9/testReport/

Max. process+thread count
425 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1838/9/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

+1; merged with a couple of final fixups of the test (add @Deprecated) to the test class to shut up checkstyle
thanks!


Add docs on releasing buildpacks

My previous comment got two 👍🏻 , do you want to change this PR so that it points to a version of this in our languages-team repo @schneems?

One of those thumbs was mine 😄 . I'm in the process of converting the docs. It's not a straight copy/pasta since this references node specific URLs. One downside of moving this over to the language playbooks is that it makes the process less open. Other teams looking to adopt and publish buildpacks while they're in this early stage of development might not have access. I don't think it's enough to be a blocker, but it's a consideration.
As CNB authors we have a vested interest in the long-term success of the ecosystem so we don't end up with another V2 legacy system no one else adopts or uses. I want us on the lookout for ways we can support that community in the open when it doesn't largely conflict with our own needs to ship products.

Merged in https://github.com/heroku/languages-team/pull/74. Updated to point at the internal doc.

@schneems I don't think we'll keep the current process when the migration to Rust is finished. It's quite complex because it has to support shimming V2 buildpacks, introduces a layer of build abstraction to support bash AND Rust buildpacks, etc.
Ideally, the whole build and packaging process will be handled by Cargo mid-term.


Sealed Secrets sealed from UI can't be decrypted in cluster

I have injected my own cert into my sealed secret controller and verified that I can encrypt and decrypt secrets. However the secrets encrypted from the UI can not be decrypted.
Furthermore have I verified that the certificate which is copied to '/kubeseal-webgui/cert/kubeseal-cert.pem' is the same as the latest kubeseal-secert-key secret.  So the fetch part works.
I have installed it using helm chart, this is the argo application yaml file
---
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: sealed-secrets-gui
  namespace: argocd
spec:
  destination:
    namespace: kube-system
    server: https://kubernetes.default.svc
  project: default
  source:
    chart: kubeseal-webgui
    repoURL: https://jaydee94.github.io/kubeseal-webgui/
    targetRevision: 5.0.0
    helm:
      parameters:
        - name: ingress.ingressClass
          value: "nginx"
        - name: api.loglevel
          value: "DEBUG"
        - name: ingress.hostname
          value: "kubeseal-webgui.domain"
        - name: ingress.tls.secretName
          value: kubeseal-webgui-tls
        - name: ingress.tls.enabled
          value: "true"
        - name: serviceaccount.create
          value: "true"
        - name: api.url
          value: ""
        - name: sealedSecrets.autoFetchCert
          value: "true"
        - name: ingress.enabled
          value: "true"
      values: |-
        ingress:
          annotations:
            kubernetes.io/tls-acme: "true"
            cert-manager.io/cluster-issuer: letsencrypt
            nginx.ingress.kubernetes.io/auth-url: ""
            nginx.ingress.kubernetes.io/auth-signin:  ""
  syncPolicy:
    automated:
      prune: true
      selfHeal: true
...

Any insight would be nice :)

Hey @sebastian-lind-stratsys have you verified that you used the correct secret name while encrypting?
Which Version of kubeseal-webgui did you use?
What Kind of insight Do you expect?

I'm getting this error messages when describing the sealedsecret object. I meant unsealed that's my bad, and I'm using the 5.0.0 helm chart version so that version it points to. I'm copying the yaml file that the web gui is producing
Error message:
  Warning  ErrUnsealFailed  6s (x12 over 8s)  sealed-secrets  Failed to unseal: no key could decrypt secret (foo)

why this error is occurring

This error usually occurs when the sealed secrets controller can't decrypt the sealed secret object.
I'm guessing the public certificate that you configured in kubeseal-webgui is wrong or maybe wrong formatted.
Have you configured the certificate by yourself in the value of the Helm chart?
Maybe you can try to use the autofetch certificate functionality.
The api container will then fetch the certificate directly from the sealed secrets controller.
Let me know if this solves your issue.

As seen in the OP I've provided the configured file this is the values that is set
helm:
      parameters:
        - name: ingress.ingressClass
          value: "nginx"
        - name: api.loglevel
          value: "DEBUG"
        - name: ingress.hostname
          value: "kubeseal-webgui.domain"
        - name: ingress.tls.secretName
          value: kubeseal-webgui-tls
        - name: ingress.tls.enabled
          value: "true"
        - name: serviceaccount.create
          value: "true"
        - name: api.url
          value: ""
        - name: sealedSecrets.autoFetchCert
          value: "true" #set to true
        - name: ingress.enabled
          value: "true"

So It's enabled, and the cert if fetches and puts into /kubeseal-webgui/cert/kubeseal-cert.pem is the correct cert

As i said before. The error that you are seeing comes from the sealed secret controller. Have you had a look into the logs of sealed-secrets?

It gives the same error, failed to unseal: no key could decrypt secret (secret name)

It just started to work no idea why, but thanks for the help :)


Add CargoTel to the list

Please review our Contribution Guidelines to ensure your changes abides by it.
Review your changes and complete the checklist below.

[x ] Company name
[x] Company description
[x] Company location
[ ] GitHub link
[x] How Elixir is used

CargoTel doesn't currently have an active github, but will.

Thank you @starbelly 😁


How ready is multispeaker training?

found this TODO
https://github.com/p0p4k/pflowtts_pytorch/blob/b00f7b45ad777c21fa42b77cd36df87e2ceeb9ef/pflow/data/text_mel_datamodule.py#L169
would like to try multispeaker training, it this good to have fixed for that or could i already give it a go?

The only small issue I need to fix is samples less than 3 seconds must be either discarded or use another sample as a prompt. I'll do it today or tomorrow.


can't initialize database models

Bug report
When running dbmate up, i get this error: Error: pq: unsupported startup parameter: search_path
To Reproduce
Just clone the repo and run dbmate up after updating the .env
System information

OS: macOs
Version of supabase-js: Using online version
Version of Node.js: 14.16.0
Version of Dbmate: 1.12.1

Are you connecting to your database directly, or using pgbouncer @HarunKilic ? I saw this happens with pgbouncer


💡 Idea: nx command

nx could serve as the ni version of npx, dlx, and pnpx.

Additional info:

npm: npx
yarn: dlx
pnpm: pnpx

I like it! Would you like to make a PR for it? Thanks!

Sure thing.


MaterialExtensionTessellation

Add a MaterialExtensionTessellation Node to use ShaderFX inside the domain stage.
Example provided. see help/Tessellation/HowTo Beziert.vl
known issues:

Need to set streams going to domain stage by hand ... see MaterialExtensionTessellation-Node not a big issue, but i think this can be handled automatically
ShaderFX Nodes behave confused Create 2 input pins for each input in the shader, one named nicely, that behave confused, one other named by shadername + property name ... this works correctly not a big issue ... because i just use the second inputs
Displacement not working on extended Materials, it just didn't compile correctly, so nothing to see I think some stage/streams are not set up correctly ... but i didn't dive in this deep

Looks good to me, few little things though:

Please remove the EditShaders.sln
Reference the csproj in the help patch directly and remove the *.dll - it is good to know for the end-user how to define a custom struct for the shader
The help patch is called "Beziert" - maybe call it how to extend a material with tesselation? The question here is about the new tesselation extension and not about b-splines, right?

The patch works nice though:

wouldn't go fullscreen for a help patch. reset bounds pin
am I the only one here? I am getting runtime excpetions when hovering pins:

when hovering the MaterialExtension output:
 mesh or material typed pins this might not be your fault, but it's bad. So we should either discuss a viewer for the particular type, that doesn't try to draw the material, thus doesn't crash or maybe there is a way to fix the issue

it's a bummer that we don't have a help patch for the other material extension node. It's quite tricky... I'll give it some more attetnion later on

I have no crashes like that on my machine.

Was looking at it with @azeno.
We'd love to accept the pull request but hit too many questionmarks. Some of them for sure are not because of you, but because we are not that deep into the system right now.

MaterialTessellation should that be called CustomTessellation? We figured that other "standard" tesselations can be connected also.
Is there a reason for the material extension input, which tweaks the vertex color? It sounds like not related to tesselation.
Is this a combination of features that always comes as a pair? Tessellation and Vertex Color tweaking? If not, should they end up on different nodes for modularity reasons?
Why do we use material extensions instead of building the material from scratch? It feels quite like a hack. Also because the material specification now operates on another level when compared to the original material node.

Hopefully we can shed some light on the topic and only tweak some little bits.

The different of the both nodes i provide is:
MaterialTessellation

you connect directly to the Material
you can write your own Tessellation for this material
works on stride side internally the same as the MaterialExtensionTessellation

MaterialExtensionTessellation

you can extend a Material with an Tesselation Shader, some how inject the TesselationShader
that approach allow me and others to write somthing like BezierSplineTubeEntity where the user can connect his own Material
the fuse Sphereimposter use the same approach

i like the idear to rename the MaterialTessellation node to CustomTessellation, this is more clear i think
so next question why there is this extra MaterialExtension pin on MaterialExtensionTessellation node

at the end this is a copy of the code from the original MaterialExtension and it is needed in one node if you whant stream (pass) somthing to an other stage than Domain

the porblem is that the MaterialExtension node dont work after the MaterialExtensionTessellation node

but if i think about maybe it is the best idea to add the Tessellation feaure to the existing MaterialExtension node
than we has one Materialextension node with all features

so whats yor opinion, tomorrow i will has time to push all the changes
next question ... should i provide a more simple sample than the bezierTube with own geometry own struct ...

somthing like Sphere Tesselation ... with simple inputs positionBuffer sizebuffer
maybe i sould bring the BezierTubeSegment and some more what i want write in the future (BezierTubeSpline ...) to a seperate nuget

summary:

rename MaterialTessellation node to CustomTessellation
add TesselationFeature to existing Materialextension node
more simple basic sample

all of what you propose sounds good to me.

THX TATA ... beeing a c# coder helps
all Changes are now pushed ... now
rename MaterialTessellation node to CustomTessellation

add TesselationFeature to existing Materialextension node
more simple basic sample

tessellate a HalfSphere facing to Camera out of

      float3 SpherePos  : SPHEREPOS
      float3 SphereSize : SPHERESIZE

so no need for csproj
and much more clear simple Example to understand

By the way, this problem

ShaderFX Nodes behave confused Create 2 input pins for each input in the shader, one named nicely, that behave confused, one other named by shadername + property name ... this works correctly not a big issue ... because i just use the second inputs

are still there ... ShaderFX behave a little bit confused if it found streams in the DSMain, HSMain ...
And if sombody looks to this, maybe we can get rid of the TessellationStream pin.

maybe the shaderCompiler knows some how witch streams a there?

2. ShaderFX Nodes behave confused Create 2 input pins for each input in the shader, one named nicely, that behave confused, one other named by shadername + property name ... this works correctly not a big issue ... because i just use the second inputs

This is indeed a weird issue, it looks like the shader reflection returns two pins and we don't sift them out. needs further investigation.


Gateway issue with image upload.

I have two services gateway and myfunction services.
I am uploading image using angular js.
But when request routing to myfunction services the Image file get removed from request.
I have used customer filter to in both gateway and myfunction sevrices to check if the request content image file or not.

import java.io.IOException;
import java.util.Collection;
import java.util.Map;

import org.springframework.http.HttpHeaders;
import org.springframework.http.MediaType;
import org.springframework.stereotype.Component;
import org.springframework.web.filter.OncePerRequestFilter;

import jakarta.servlet.FilterChain;
import jakarta.servlet.ServletException;
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
import jakarta.servlet.http.Part;

@Component
public class CustomFilter extends OncePerRequestFilter {

    @Override
    protected void doFilterInternal(HttpServletRequest request, HttpServletResponse response, FilterChain filterChain) throws ServletException, IOException {
        String contentType = request.getHeader(HttpHeaders.CONTENT_TYPE);
        Object parameterValue = request.getParameter("file");

        		if(contentType!=null && request.getContentType().startsWith(MediaType.MULTIPART_FORM_DATA_VALUE)) {
                    Collection<Part> parts = request.getParts();
                    for (Part part : parts) {
                        // Check if the part is a file or a form field
                        if (part.getContentType() != null) {
                            // File part
                            System.out.println("File part name: " + part.getName());
                            System.out.println("File name: " + part.getSubmittedFileName());
                            // You can process the file here
                        } else {
                            // Form field part
                            System.out.println("Form field name: " + part.getName());
                            // You can process the form field here
                        }
                    }
        		}

        // Check if the request contains a file
        boolean hasFile = request.getContentType() != null && request.getContentType().startsWith(MediaType.MULTIPART_FORM_DATA_VALUE);

      Map<String, String[]> parameterMap = request.getParameterMap();
        for (String paramName : parameterMap.keySet()) {
            Object paramValues = parameterMap.get(paramName);
            System.out.println("manoj" +paramName);
           // for (String paramValue : paramValues) {
           //     System.out.println("Parameter: " + paramName + ", Value: " + paramValue);
            }

        // Perform your validations based on file presence, content type, and parameter value
       // if (hasFile && contentType != null && contentType.equals(MediaType.APPLICATION_JSON_VALUE) && parameterValue != null) {
            // Proceed with the request
            filterChain.doFilter(request, response);
       // } else {
            // Reject the request with a 400 Bad Request response
        //    response.setStatus(HttpStatus.BAD_REQUEST.value());
          //  response.getWriter().write("Invalid request parameters");
          //  return;
       // }
    }
}

I can see the file when request is in gateway but it get missed when it come to myfunction services.
I am using oauth2 client in gateway and ouath2 resources server in myfunction services.
please can you tell me what is worng with the gateway.
one more point to hightlight When I use postman It works fine the file did lost.

I have also check this link
but here tere haven't touch the part file which is coming with my request.
which filter do that.

reading the parts reads the stream and it is, therefor, not available to send anymore.

Can you explain in detail..I did not get what you are explaing

Can you explain in detail..I did not get what you are explaing

I might be misunderstanding but it sounds like what Spencer is saying is that you're already reading the stream in your filter. Once the stream has been read it's not being sent to your controller.


Remove Uglifier, try Terser

Do some more testing before switching.

Closing as this is now in #3675


Update Lamp

They fixed an important bug that spams your console with an error
https://github.com/Revxrsal/Lamp/issues/82
Also, it would be nice if you could update AxGraves

Hi, I'm terribly sorry for not looking into this PR earlier, and not pushing to the repo when I should have. But thanks for your contribution anyways :D

No worries, i also included non-related stuff mistakenly my bad.


Wrong author displayed

Description
The paper displays some sort of default author value instead of the names and affiliations of the actual authors.
(Optional:) Please add any files, screenshots, or other information here.
The author shown is:
David S. Hippocampus
Department of Computer Science Cranberry-Lemon University Pittsburgh, PA 15213<EMAIL_ADDRESS>(Required) What is this issue most closely related to? Select one.
Other
Internal issue ID
cda4b86b-9bfe-42b3-b56b-a4c16dab84fd
Paper URL
https://browse.arxiv.org/html/2401.04933v1
Browser
Firefox/121.0
Device Type
Desktop

There are two almost identical sources in the submission bundle here - arxiv.tex and draft.tex. The reported wrong author came from draft.tex which seems to have been wrongly used as the primary source.
It looks like latexml can guess the right file in this case (from a ZIP input, which is the ar5iv formulation), but it is certainly very subtle - probably alphabetic order.


influx_database option is ignored

lib/cloudwatch/sender/base.rb line 8 => @influxdb = InfluxDB::Client.new "graphite",
It takes the graphite as the database name. But we have influx_database option to give the database name.

Why is this issue closed?  AFAICT, the problem still exists.  "graphite" is still hard-coded into base.rb.

@jpriebe I'm not sure why I closed this issue. Reopening again after your verification.

Do we have any updates related to this issue ? I am also facing the same issue .Any write-up on how was this issue fixed will be helpful


Replace Travis/AppVeyor with GitHub Actions

:wave: We, the GitHub Desktop Team, are happy users of prebuild in several projects that we depend upon. We've recently been working on yet another native module and ran into trouble building using the windows-latest GitHub Actions image. This seems to be resolved in a more recent version of node-gyp which is how I stumbled upon https://github.com/prebuild/prebuild/issues/286 and more specifically https://github.com/prebuild/prebuild/issues/286#issuecomment-1049305694

Replace Travis (and Appveyor) with a GitHub Actions workflow, because our CI is currently broken and we'd like to test all of this. Also replace the badges in the README.

I figured we (I) could spend some time on this to see how difficult it would be. Overall the end result isn't too bad, macOS and Linux builds are both passing and Windows builds only have two failing tests, both related to nw-gyp.
The "can prebuild a gyp native module for node-webkit" test fails with the following error
Traceback (most recent call last):
        File "D:\a\prebuild\prebuild\node_modules\nw-gyp\gyp\gyp_main.py", line 16, in <module>
          sys.exit(gyp.script_main())
        File "D:\a\prebuild\prebuild\node_modules\nw-gyp\gyp\pylib/gyp/__init__.py", line 545, in script_main
          return main(sys.argv[1:])
        File "D:\a\prebuild\prebuild\node_modules\nw-gyp\gyp\pylib/gyp/__init__.py", line 538, in main
          return gyp_main(args)
        File "D:\a\prebuild\prebuild\node_modules\nw-gyp\gyp\pylib/gyp/__init__.py", line 514, in gyp_main
          options.duplicate_basename_check)
        File "D:\a\prebuild\prebuild\node_modules\nw-gyp\gyp\pylib/gyp/__init__.py", line 98, in Load
          generator.CalculateVariables(default_variables, params)
        File "D:\a\prebuild\prebuild\node_modules\nw-gyp\gyp\pylib/gyp/generator/msvs.py", line 1916, in CalculateVariables
          generator_flags.get('msvs_version', 'auto'))
        File "D:\a\prebuild\prebuild\node_modules\nw-gyp\gyp\pylib/gyp/MSVSVersion.py", line 444, in SelectVisualStudioVersion
          versions = _DetectVisualStudioVersions(version_map[version], 'e' in version)
      KeyError: '2019'

This is due to nw-gyp using an old version of gyp which doesn't have an entry for VS 2019. Unfortunately that project seems rather stale so I don't know what the best way forward here is.
I also had to bump cmake-js in order to support VS 2019 (I chose the latest version but it's possible we would only need 6.1.0).
TL;DR A GitHub workflow for buillding on Windows (currenty failing), macOS (passing), and Linux (passing). Hoping to get some help figuring out the best path forward to get tests passing on Windows with VS2019.

This is due to nw-gyp using an old version of gyp which doesn't have an entry for VS 2019. Unfortunately that project seems rather stale so I don't know what the best way forward here is.

Seems it was fixed: https://github.com/nwjs/nw-gyp/commit/966ca060299ea3a31ccd81b35916ccb26980faed

@niik Thank you for this PR. Is there anything else you wanted to add or change before merging? I've left a couple of questions/comments inline, primarily around newer versions released since this was first opened that we may now want to take advantage of.

:wave: I applied your suggestions and the good news is that Windows builds are now passing, the bad news is that macOS and Linux builds are now failing. See https://github.com/niik/prebuild/actions/runs/4912267923/jobs/8771095211
I'm afraid I don't have much bandwidth to dig into this so hopefully there's something in here that y'all can figure out. For the macOS builds the error seems pretty clear
prebuild info begin Prebuild version 11.0.4
prebuild info build Preparing to prebuild<EMAIL_ADDRESS>for node-webkit 0.26.6 on linux-x64 using nw-gyp
prebuild ERR! configure error
prebuild ERR! stack Error: Python executable "/opt/hostedtoolcache/Python/3.10.11/x64/bin/python" is v3.10.11, which is not supported by gyp.

The Node 20 builds are failing for different reasons it seems.
Let me know if there's anything I can do to help but also feel free to take this PR as-is and iterate on it in subsequent PRs.

Upgrading node-gyp should fix the macOS build error. The current version definitely doesn't work on Python 3.11 but seems to works fine if manually upgraded #286

It looks like that failing test is due to a (documented) lack of support for Python 3 in the nw-gyp dependency (a fork of an old version of node-gyp, has ~8k downloads/week, I suspect mostly driven by being a dependency of this module).
It's possible to install both Python 2 and 3 via actions/setup-python:
https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#specifying-multiple-pythonpypy-version
If this works, then the addition of a --python=python2 flag here should help.
https://github.com/prebuild/prebuild/blob/e148f4554fa1fa435b79f5964c5fc06c9bda1331/test/native-module-gyp/package.json#L8
Alternatively we might consider skipping this test until nw-gyp supports Python 3.

Applying commit https://github.com/lovell/prebuild/commit/4f504140fb666e32063d7b83bb659f42b86c39f7 to the niik:aaaaaand-action-(s) branch appears to get the GitHub Actions based CI passing, e.g. https://github.com/lovell/prebuild/actions/runs/5169702326

The nw-gyp dependency has a --python flag to specify the version but sadly it doesn't appear to work as advertised so we'll have to skip this test until https://github.com/nwjs/nw-gyp/issues/122 is fixed.

I had to remove Node.js 20 for now as it (correctly) makes the process.config.target_defaults object read-only but node-gyp v6 tries to modify it, which produces the following error:

TypeError: Cannot assign to read only property 'cflags' of object '#'
at createConfigFile (D:\a\prebuild\prebuild\node_modules\node-gyp\lib\configure.js:118:21)

please merge this so that someone can update the node-gyp, I'm wasting so much time on this

I've pushed my change to the niik:aaaaaand-action-(s) branch via commit https://github.com/niik/prebuild/commit/bfeab27458f999f92fd4ec12312724a484917089 but it looks like there are temporary networking problems with GitHub Actions at the moment so I'll try again later - see https://github.com/niik/prebuild/actions/runs/5452106212

I can't re-run Actions on the niik:aaaaaand-action-(s) branch so I pushed the same changes to the lovell:aaaaaand-action-(s) branch this morning and it passed - see https://github.com/lovell/prebuild/actions/runs/5462011420 so I think we're ready to :shipit:

I can't re-run Actions on the niik:aaaaaand-action-(s)

Just triggered a re-run for ya :+1:

@lovell Go ahead and merge when you're happy with it (I personally don't have time to review and other folks are quiet).

Thank you very much @niik and everyone else that has helped with this.

I've created a follow-up PR for this at https://github.com/prebuild/prebuild/pull/304


Add protection against data loss

Adding defensive detection of data loss scenario, based on https://github.com/microsoft/FluidFramework/issues/3840
Note: I'm not checking against last known sequence to client as I find it risky - that would add potential race where same op can come at the same time from socket & storage.
Instead, I'm validating that sockets ops only move forward (including across multirole connections)
@GaryWilber , @tanviraumi - Is this valid assumption?
I.e. Can client in normal flow reconnect to another connection and receive prior messages? I.e. can there be a case when newly connected server is behind in retransmitting messages and transmits (after new connection) something that client already observed on another socket?
If this is not the right check, how else (safely) we can detect data loss by PUSH and reversal in sequence numbers?

There is no guarantee that the sequence number only moves forward. Service can always send duplicate sequence number because our broadcast is optimistic. For example, Push stamped seq# 50, 51, 52, 53 and its last checkpoint was # 49. Before Push can checkpoint again, deli restarts. After the restart, deli still thinks that next sequence should be # 50. So it will start sequencing again starting at 50. Just to be clear, this does not mean any data loss. Ops were sent to kafka first, and we tied the logOffset with seq number, meaning that after a restart, Push will rebroadcast the same 4 messages again. It's basically what Fluid service does (or tries) to provide "at least once". Now to convert this into "exactly once", clients are responsible for the following:

Discard duplicate op based on sequence number.
Ask for missing ops when there is a gap. Service will be responsible for providing any missing op and clients can not move forward with a gap.

This is how r11s works today. I am not sure whether Push moved to this model yet. @GaryWilber can add more insight regrading #3840

Ok, different approach - remember last message and compare any duplicate message with same seq number to it - if they are not matching, then game over


Binding of HOME and END keys to do different actions on macOS is unreliable

Description
Configuring HOME key to do "Line Start" and END key to do "Line End" does not work properly on macOS. The binding works only if the application is restarted but after some time, the binding is forgotten and HOME key starts doing "Text Start" and END key starts doing "Text End", which are the macOS default behavior, however I want to use these keys in "Windows-way". I did not check other keys so I don't know if the complete key binding configuration is lost after some application run time or only these two keyboard buttons are affected.
DBeaver Version
Community Edition <IP_ADDRESS>407211303
Operating System
macOS 14.5
Database and driver
Affects SQL Editor globally.
Steps to reproduce

Have this key binding configured: dbeaver_key_binding.csv
Open an SQL editor and write some text lines
Try out HOME and END keys --> they should work as expected
Leave the application running for several hours in the background
Go back to the editor and try out the HOME and END keys --> they should jump to text start and text end instead of line start and line end

Additional context
No response

Duplicate of https://github.com/dbeaver/dbeaver/issues/9414.


Speed up mbed-cli new command by performing shallow clone of mbed-os

When running mbed-cli new <name>, the entire repo history of mbed-os is cloned into the user's repository.
At the current size of the mbed-os repo, the git clone <mbed-os repo> command takes ~3 minutes on my system.
Replacing this with git clone -b latest --depth=1 <mbed-os repo> cuts this time down to ~1.5 minutes.

Maybe instead of being an default option, there could be an optional configurational parameter to deploy Mbed OS as shallow. This way it would affect equally import, deploy and new.

@cmonr You can actually already do this with the option --depth [DEPTH]. It's currently present in mbed import, mbed add, mbed deploy, and mbed update.
I don't think we can make this the default option like @teetak01 mentioned because the .lib files that are then turned into repositories can reference any commit in the repository's history. If the depth is set too shallow, this commit won't be present and it will error.

@bridadan Using --depth on its own is definitely not enough and can cause the entire clone to fail, but (from what I can tell) all that goes into mbed-os.lib is the git URL with the specific commit hash. You can still get the same hash if -b latest is used, with the benefit of a faster clone and less disk space used.

Ah I see, so you're saying just for the mbed new command (which always clones from the latest tag), just run git clone https://github.com/ARMmbed/mbed-os -b latest since that will be faster?
Seems fine to me, do you need some pointers on where to make the change? This is the relevant section of the CLI: https://github.com/ARMmbed/mbed-cli/blob/master/mbed/mbed.py#L1727. You'll probably need to look into the Git abstractions as well: https://github.com/ARMmbed/mbed-cli/blob/master/mbed/mbed.py#L610

Yes, and no. More specifically, right now the mbed new command does a clone of the entire repo, then switches to the latest branch.
Both --depth=1 and -b latest are needed, the former to speed up the clone, and the latter to make sure that all files needed are actually pulled.

Ah, I see, thanks for the explanation. I think that should be fine, but I think the final call may end up being @screamerbg's.
@theotherjimmy Do you know if this will affect the online compiler? Typically you can always go back in commits in the online compiler. If the online compiler uses mbed CLI in the back end then this would be a breaking change.

The online compiler does not use Mbed CLI, as it's directory structure is very very different.

@cmonr With the mbed cache feature now being default, do you still think we need this?

OH. Forgot this was still open.
This can be closed. The crux of my problem was Shared Directory performance in VirtualBox.
But I agree that now that caching is a thing, things should be much faster.


Fix string replacement when filtering countries

Following the changes in PR #14, text filtering doesn't account for the latest edit, as the method for updating the string with it is currently incorrect. Instead of replacing the string at the given range with the latest edit, it will look for text in range and replace it with string (and the complete text probably never appears in range, which represents a substring of text):
https://github.com/mobven/CountryPicker/blob/251706ac6b4143dd7218b8c541874af32239e351/Sources/CountryPicker/CountryPickerViewController.swift#L252
The wanted behavior here is to simply replace a range of the receiver string with another string (the latest edit). This pull request fixes this issue without using an NSString.
And btw, thanks for this simple and useful library 🙂

Hello @pjay
Great catch. I don't believe how I missed it. Though modern APIs are better, the correct way in NSString would be replacingCharacters(in:, with:).
Thank you for contribution. Stay safe 🍻


On the OpenIdConnect authentication enabled HTTPS callback RedirectUri does not take effect, the default is HTTP

IdentityServer4 + asp.net Core 2.0，
Deployed to the production environment, the use of OpenIdConnect authentication, enabled HTTPS, callback RedirectUri default HTTP, how to solve? Server:https://uc.xxx.com, OpenIdClient:https://mvc.xxx.com.

This seems to be a general question about IdentityServer - not a bug report or an issue.
Please use one of the our free or commercial support options
See here for more details.
Thanks!