ValueError: array must not contain infs or NaNs

Seems to happen when return_mitigation_overhead=True is set and there is only one bitstring with nonzero count.
Code:
from qiskit import Aer, QuantumCircuit, transpile
import mthree

qc = QuantumCircuit(6)
qc.measure_all()

backend = Aer.get_backend("statevector_simulator")
mit = mthree.M3Mitigation(backend)
mit.cals_from_system(range(6))

trans_qc = transpile(qc, backend)
raw_counts = backend.run(trans_qc, shots=100).result().get_counts()

quasis = mit.apply_correction(raw_counts, range(6), return_mitigation_overhead=True)

Output:
/home/kevinsung/.local/share/virtualenvs/qiskit-terra-rZn7sWYf/lib64/python3.9/site-packages/mthree/norms.py:76: RuntimeWarning: invalid value encountered in true_divide
  x = (-1)**(x+1)*(1+(x-1)/(dims-1))

---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Input In [1], in <module>
     11 trans_qc = transpile(qc, backend)
     12 raw_counts = backend.run(trans_qc, shots=100).result().get_counts()
---> 14 quasis = mit.apply_correction(raw_counts, range(6), return_mitigation_overhead=True)

File ~/.local/share/virtualenvs/qiskit-terra-rZn7sWYf/lib64/python3.9/site-packages/mthree/mitigation.py:366, in M3Mitigation.apply_correction(self, counts, qubits, distance, method, max_iter, tol, return_mitigation_overhead, details)
    362 quasi_out = []
    363 for idx, cnts in enumerate(counts):
    365     quasi_out.append(
--> 366         self._apply_correction(cnts, qubits=qubits[idx],
    367                                distance=distance,
    368                                method=method,
    369                                max_iter=max_iter, tol=tol,
    370                                return_mitigation_overhead=return_mitigation_overhead,
    371                                details=details)
    372                     )
    374 if not given_list:
    375     return quasi_out[0]

File ~/.local/share/virtualenvs/qiskit-terra-rZn7sWYf/lib64/python3.9/site-packages/mthree/mitigation.py:439, in M3Mitigation._apply_correction(self, counts, qubits, distance, method, max_iter, tol, return_mitigation_overhead, details)
    437 if method == 'direct':
    438     st = perf_counter()
--> 439     mit_counts, col_norms, gamma = self._direct_solver(counts, qubits, distance,
    440                                                        return_mitigation_overhead)
    441     dur = perf_counter()-st
    442     mit_counts.shots = shots

File ~/.local/share/virtualenvs/qiskit-terra-rZn7sWYf/lib64/python3.9/site-packages/mthree/mitigation.py:540, in M3Mitigation._direct_solver(self, counts, qubits, distance, return_mitigation_overhead)
    538 gamma = None
    539 if return_mitigation_overhead:
--> 540     gamma = ainv_onenorm_est_lu(A, LU)
    541 out = vector_to_quasiprobs(x, sorted_counts)
    542 return out, col_norms, gamma

File ~/.local/share/virtualenvs/qiskit-terra-rZn7sWYf/lib64/python3.9/site-packages/mthree/norms.py:80, in ainv_onenorm_est_lu(A, LU)
     76 x = (-1)**(x+1)*(1+(x-1)/(dims-1))
     78 x = la.lu_solve(LU, x, check_finite=False)
---> 80 temp = 2*la.norm(x, 1)/(3*dims)
     82 if temp > gamma:
     83     gamma = temp

File ~/.local/share/virtualenvs/qiskit-terra-rZn7sWYf/lib64/python3.9/site-packages/scipy/linalg/_misc.py:145, in norm(a, ord, axis, keepdims, check_finite)
    143 # Differs from numpy only in non-finite handling and the use of blas.
    144 if check_finite:
--> 145     a = np.asarray_chkfinite(a)
    146 else:
    147     a = np.asarray(a)

File ~/.local/share/virtualenvs/qiskit-terra-rZn7sWYf/lib64/python3.9/site-packages/numpy/lib/function_base.py:603, in asarray_chkfinite(a, dtype, order)
    601 a = asarray(a, dtype=dtype, order=order)
    602 if a.dtype.char in typecodes['AllFloat'] and not np.isfinite(a).all():
--> 603     raise ValueError(
    604         "array must not contain infs or NaNs")
    605 return a

ValueError: array must not contain infs or NaNs

mthree version: 0.19.0

This is probably because you are using a statevector simulator with no error.  As such it has truncated your problem down to just a single float number.  Not sure the use case here, especially since there are no measurements, but can address the error.


feat(Table): style row action button

Closes FEP-1624

@youssefssc that could be caused by that we still didn't migrate to the new typography scale in implementation but designs are already migrated


Having both a try processor and output is confusing

There is a try processor (https://www.benthos.dev/docs/components/processors/try) and a try output (https://www.benthos.dev/docs/components/outputs/try). Both of these components look similar in that they are a list of child components. However, the behaviour of them is pretty much the opposite:
The processor variation executes a list of processors in order, where a processor is only executed if all prior processors were successful (similar to lines of code in a try block in a typical programming language).
The output variation routes a message to a list of outputs in order, where the message is only routed if all prior outputs were unsuccessful (if an output fails, try the next one).
It has been noted that this is hella confusing and it would be dope (I'm paraphrasing here) if the two components weren't given the same name. I think of the two the output variant is the least goodly named, and we should consider renaming it to fallback or similar, to make it clear that each output listed is a fallback option to the prior.
We can do this rather easily and in a backwards compatible way by deprecating try and adding a new alias component with the same implementation, then we just need to swap out mentions of the try output in the docs to seal the deal.

I went for fallback in the end https://github.com/Jeffail/benthos/commit/f7935003018833859a7ee34611c66e0cb58580c5, but there's still time to change it.


pkg/sdk: don't exit on failure to create metrics service

ref: #356
/cc @fanminshi
Setting up the operator metrics service was supposed to be best effort and not fail. With this operator-sdk up local should be fixed:
$ operator-sdk up local --namespace=haseeb
INFO[0000] Go Version: go1.10.2
INFO[0000] Go OS/Arch: darwin/amd64
INFO[0000] operator-sdk Version: 0.0.5+git
ERRO[0000] Failed to initialize service object for operator metrics: OPERATOR_NAME must be set
INFO[0000] Watching app.example.com/v1alpha1, App, haseeb, 5

lgtm


bx-pages-select-changed event not being fired when arrow navigation in bx-pagination

Detailed description

When trying to handle the event when a page has changed, the event bx-pages-select-changed is not being sent out when the arrows are clicked within the bx-pagination component.

Is this issue related to a specific component?
bx-pagination and bx-pages-select

What did you expect to happen? What happened instead? What would you like to
see changed?
The event bx-pages-select-changed should be fired indicating that the page has changed when clicking on the arrows. The event only fires when a page size is chosen. Since the bx-pages-select component changes when arrows clicked, it should be the one to fire the event indicating that the page has changed.

What browser are you working in?
Chrome

What version of Carbon Web Components are you using?
1.13.0

Steps to reproduce the issue

Once pagination has been loaded, click on the left or right arrow to navigate pages
Clicking on the arrow doesn't trigger the event
Changing the page through the dropdown does work however

Additional information
<bx-pagination
    page-size="10"
    total="100"
    @bx-pages-select-changed=${({ detail }) => {
        console.log(`Page changed to ${detail.value}`);
    }}
>
    <bx-pages-select total="10" value="0"></bx-pages-select>
</bx-pagination>

Weighing in; If you go to https://web-components.carbondesignsystem.com/?path=/story/components-pagination--default, open Actions tab at the bottom or at the right, and try arrow navigation in the component, you'll see bx-navigation-changed-current events logged. OTOH bx-pages-select-changed event is solely of the select box (not arrow).

@patrickklick confirmed that the actions are getting fired, can you see if this works for you?

@asudoh thank you for jumping in!

Thanks @asudoh and @jeffchew for replying. We did discover the bx-pagination-changed-current event after playing with the component a bit more. The only thing that was beneficial with the bx-pages-select-changed event was that it told us directly which page we were going to.
As a potential improvement, if the event bx-pages-select-changed was fired whenever the pages selector changed, it would be helpful to capture those events. Even if its not changed directly, it would still be helpful to have that event fired.
Thanks for your help!

Just in case it's worth noting, bx-pagination-changed-current is the only event that needs to be listened to - It's fired when the select box is changed as well as when arrow button is clicked on.

That is true. Thanks @asudoh.

bx-navigation-changed-current

Hello, thi event is not referenced in the documentation page.
Eric


Serializing Outputs as JLD2 files

We should support serializing the output of the solvers to a stable serialization format. JLD2 would be a good candidate.

The current practice is to use JLD2.@save to save the simulation results, so this issue is technically closed.
More "structured" means of saving (and loading) data is encompassed by simulation-pipeline work with @olynch and @quffaro .


Clarify UDP errors and recvmmsg

Is there any further action from me needed here? I don't know what the process is here, was just trying to be a good citizen after my question was answered so promptly.
Happy to progress and also happy to wait, just didn't want to this to get lost waiting on some action by me. :-)

Landed in https://github.com/libuv/libuv/commit/9cc2667f765b40a38c6d7a58cc40c8127905635c. Thanks!


fix: added fees to bridge struct

@ezynda3 Are we not going to support callbacks? If we plan that, maybe we should also take the callback data from the struct.


Directory import of buffer not supported with ES modules

Description
When starting up the app with npm run dev I get the follow error:
Error: Directory import 'my_project/node_modules/@remix-pwa/cache/node_modules/buffer/' is not supported resolving ES modules imported from<EMAIL_ADDRESS>
Did you mean to import buffer/index.js?

How to replicate

Setup remix with npx create-remix@latest
Follow the installation steps.
Start the app with npm run dev

I have added ESLinting and formatting to the project, but none of these seem to have changed any of the node module resolution options set by remix.
Workaround
If I patch cache.js from import * as B from 'buffer/'; to import * as B from 'buffer/index.js'; then it resolves the issue, but seeing as how other people have this working (and I can't see anything like this in the playground) there must be a configuration I have wrong somewhere in my project.
For now, I'm going to patch the file and keep moving, but if anyone can replicate or advise, that would be great.

@paul-kuihi Patching the package is one way to go. The other way is to add the remix pwa packages to serverDependenciesToBundle field. Look at this issue: https://github.com/remix-pwa/monorepo/issues/112

This is great, thanks @ShafSpecs ! I've moved from the patch to config and is working nicely both locally and deployed.

I guess it's not so much of a gotcha but likely part of the standard installation.  I created a baseline Remix project (using https://remix.run/docs/en/main/other-api/create-remix) and only went through the installation steps and ran into this issue.
Perhaps adding to the walkthrough here: https://remix-pwa.run/docs/installation#set-up-your-remix-config and removing the "You don't need to change any other thing in your Remix config."
The repo created by following the steps in Create Remix + Remix PWA: https://github.com/Kikketer/remix-base

I guess it's not so much of a gotcha but likely part of the standard installation.  I created a baseline Remix project (using https://remix.run/docs/en/main/other-api/create-remix) and only went through the installation steps and ran into this issue.
Perhaps adding to the walkthrough here: https://remix-pwa.run/docs/installation#set-up-your-remix-config and removing the "You don't need to change any other thing in your Remix config."
The repo created by following the steps in Create Remix + Remix PWA: https://github.com/Kikketer/remix-base

👍 Working on the new release of remix-pwa and the cache package is getting deprecated. Hopefully, that sorts out a lot

I had to go to<EMAIL_ADDRESS>and edit the first line:
import * as B from 'buffer/';
to
import * as B from 'buffer/index.js';


Merge broken paragraphs- separate bullets= separate paragraphs?

Is there any way to use the merge broken paragraphs function for a document containing many bullet points and have each bullet point be treated as its own paragraph? Currently I am converting them 1 by 1 which takes a while.
Thanks!

Could you give a simple sample of the document?
Maybe you can use Format bullet list command after Merge broken paragraphs🤔

Thanks for the speedy reply. I actually thought of that. When I merge broken paragraphs, it still keeps the - before each bullet point but when I format bullet list the formatting doesn't change at all? It doesn't separate them back into bullets. Maybe user error? I have tried it on a few created documents and have the same issue.

Walk the
dog
Go to the
movies
Train the
dolphins

After merge broken paragraphs (works great)

Walk the dog - Go to the movies - Train the dolphins

After format bullet list

Walk the dog - Go to the movies - Train the dolphins

I see the problem actually by taking another look at the readme example. For the command to register there needs to be a • in between, a "-" won't work.

• first, blahblah • second, blahblah • third, blahblah

You can add - in the setting, as the figure is shown above.

Thank you so much. Your plugin will save me hours of tidying up highlighted notes from pdfs. Appreciate the help


Bug: Gulp Build failing with error TS2307: Cannot find module 'sqlops'.

Gulp Buld is currently reporting the following yet the build/extension works
PS C:\GitHub\sqlops-mssql-instance-insights> gulp build
[22:43:46] Using gulpfile C:\GitHub\sqlops-mssql-instance-insights\gulpfile.js
[22:43:46] Starting 'build'...
[22:43:46] Starting 'clean'...
[22:43:46] Finished 'clean' after 40 ms
[22:43:46] Starting 'lint'...
[22:43:46] Finished 'lint' after 141 ms
[22:43:46] Starting 'compile'...
[22:43:46] Starting 'compile:src'...
src\apiWrapper.ts(19,23): error TS2307: Cannot find module 'sqlops'.
src\controllers\instanceUtils.ts(13,25): error TS2307: Cannot find module 'sqlops'.
src\controllers\mainController.ts(19,25): error TS2307: Cannot find module 'sqlops'.
src\controllers\mainController.ts(23,22): error TS2497: Module '"C:/GitHub/sqlops-mssql-instance-insights/node_modules/@types/opn/index"' resolves to a non-module entity and cannot be imported using this construct.
src\controllers\mainController.ts(72,19): error TS6133: 'openVersionHealthCheckWebSite2' is declared but its value is never read.
src\data\createInstanceData.ts(19,25): error TS2307: Cannot find module 'sqlops'.
[22:43:48] TypeScript: 6 semantic errors
[22:43:48] TypeScript: emit succeeded (with errors)
[22:43:48] Finished 'compile:src' after 1.98 s
[22:43:48] Starting 'compile:test'...
[22:43:48] Finished 'compile:test' after 4.59 ms
[22:43:48] Finished 'compile' after 1.99 s
[22:43:48] Finished 'build' after 2.17 s
PS C:\GitHub\sqlops-mssql-instance-insights>

After comparing the sqlops module with the vscode module, I have found that the issue is due to a missing sqlops.d.ts file in the sqlops npm module that is installed.
Copying the sqlops.d.ts from the /src/sql/sqlops.d.ts of the sqlopsstudio repo does remove the error.
I'm emailing anthonydresser to find out more.

Needed a postinstall step in scripts section of package.json
I had the install script referenced in the prepare step but not in the postinstall.
This is required as both the vscode and sqlops modules will pull down their *.d.ts files as part of the install script.
was
"scripts": {
        "prepare": "node ./node_modules/sqlops/bin/install",
        "build": "gulp build",
        "compile": "gulp compile",
        "watch": "gulp watch",
        "postinstall": "node ./node_modules/vscode/bin/install"
    },

Needed to be
"scripts": {
        "prepare": "node ./node_modules/sqlops/bin/install",
        "build": "gulp build",
        "compile": "gulp compile",
        "watch": "gulp watch",
        "postinstall": "node ./node_modules/vscode/bin/install && node ./node_modules/sqlops/bin/install"
    },

Then run npm install and it fixes the issue.

Side note.... also fixed the import for opn by changing
import * as opn from 'opn';

to
const opn = require('opn');

Found that the sample extensions also have an additional task in gulp scripts for copytypings to handle the proposed apis file sqlops.proposed.d.ts.
"scripts": {
        "build": "gulp build",
        "compile": "gulp compile",
        "watch": "gulp watch",
        "typings": "gulp copytypings",
        "postinstall": "node ./node_modules/vscode/bin/install && node ./node_modules/sqlops/bin/install && gulp copytypings"
    },

Also updated the gulp buildtasks file. The step though tries to copy the file from the source so will exclude these for now and stick to manually installing the file.


assembling canu corrected reads

Hi,
So I am trying to to assemble ONT reads that have been corrected with canu. But I am getting a strange error:
Laurens-MacBook-Pro:Ecoli_644 laurencowley$ ../git_repo/miniasm/miniasm -f source_canu_lowcov/Ecoli644.correctedReads.fasta.gz Ecoli644_correctedminimap.paf.gz > Ecoli644_miniasm.gfa
[M::main] ===> Step 1: reading read mappings <===
[M::ma_hit_read::1.8501.00] read 1687161 hits; stored 1257327 hits and 14342 sequences (124608869 bp)
[M::main] ===> Step 2: 1-pass (crude) read selection <===
[M::ma_hit_sub::2.0421.00] 14340 query sequences remain after sub
[M::ma_hit_cut::2.0681.00] 1257303 hits remain after cut
[M::ma_hit_flt::2.0960.99] 1112831 hits remain after filtering; crude coverage after filtering: 54.73
[M::main] ===> Step 3: 2-pass (fine) read selection <===
[M::ma_hit_sub::2.1530.99] 14335 query sequences remain after sub
[M::ma_hit_cut::2.1790.99] 1112203 hits remain after cut
[M::ma_hit_chimeric::2.2070.99] identified 143 chimeric reads
[M::ma_hit_contained::2.2360.99] 749 sequences and 10538 hits remain after containment removal
[M::main] ===> Step 4: graph cleaning <===
[M::ma_sg_gen] read 10294 arcs
[M::main] ===> Step 4.1: transitive reduction <===
[M::asg_arc_del_trans] transitively reduced 3498 arcs
[M::asg_arc_del_multi] removed 1652 multi-arcs
[M::asg_arc_del_asymm] removed 0 asymmetric arcs
[M::main] ===> Step 4.2: initial tip cutting and bubble popping <===
[M::asg_cut_tip] cut 8 tips
[M::asg_pop_bubble] popped 11 bubbles and trimmed 0 tips
[M::main] ===> Step 4.3: cutting short overlaps (3 rounds in total) <===
[M::asg_arc_del_multi] removed 0 multi-arcs
[M::asg_arc_del_asymm] removed 345 asymmetric arcs
[M::asg_arc_del_short] removed 1725 short overlaps
[M::asg_cut_tip] cut 8 tips
[M::asg_pop_bubble] popped 127 bubbles and trimmed 0 tips
[M::asg_arc_del_multi] removed 0 multi-arcs
[M::asg_arc_del_asymm] removed 29 asymmetric arcs
[M::asg_arc_del_short] removed 47 short overlaps
[M::asg_cut_tip] cut 1 tips
[M::asg_pop_bubble] popped 15 bubbles and trimmed 0 tips
[M::asg_arc_del_multi] removed 0 multi-arcs
[M::asg_arc_del_asymm] removed 9 asymmetric arcs
[M::asg_arc_del_short] removed 11 short overlaps
[M::asg_cut_tip] cut 1 tips
[M::asg_pop_bubble] popped 4 bubbles and trimmed 0 tips
[M::main] ===> Step 4.4: removing short internal sequences and bi-loops <===
[M::asg_cut_internal] cut 0 internal sequences
[M::asg_cut_biloop] cut 0 small bi-loops
[M::asg_cut_tip] cut 0 tips
[M::asg_pop_bubble] popped 0 bubbles and trimmed 0 tips
[M::main] ===> Step 4.5: aggressively cutting short overlaps <===
[M::asg_arc_del_multi] removed 0 multi-arcs
[M::asg_arc_del_asymm] removed 1 asymmetric arcs
[M::asg_arc_del_short] removed 1 short overlaps
[M::asg_cut_tip] cut 0 tips
[M::asg_pop_bubble] popped 0 bubbles and trimmed 0 tips
[M::main] ===> Step 5: generating unitigs <===
Assertion failed: (sub[id].e - sub[id].s <= ks->seq.l), function ma_ug_seq, file asm.c, line 267.
Abort trap: 6
Do you know why this might be?

Could you check if the input contains duplicated read names?

I don't think so the reads are in fasta format with read names in the format:

143b9016-9b2f-4a9f-b3e7-a87378b5afa2_Basecall_2D_2d NBCOL1105_Ecoli_644_3618_1_ch32_file16_strand

Could you run the following:
zcat input.fa.gz | perl -ne 'print "$1\n" if />(\S+)/' | sort | uniq -d

ok it has outputted the read names in order and there are no repeats

That command line would have no output if there were no duplicated read names. -d means to output duplicated strings only.

oh I see!! right I will sort out the file and try miniasm again, sorry!

Never mind. I should have let minimap/miniasm check input name. This is actually a common error.


Create or Choose our Brand Colors

A good app needs colors. Nice ones too. I like mint green but its overused 💯
So maybe like a neat purple?

Something with purple as a primary color and grey as a secondary yet prominent color


Facing- ValueError: Longitude is out of range [-180, 180]

Hi authors,
I tried to clone your project in my cluster, with the pre-trained model and tried to run it, however, I am facing the issue of ValueError: Longitude<PHONE_NUMBER>449724 is out of range [-180, 180]
Environment Details:
NAME="Rocky Linux"
VERSION="8.7 (Green Obsidian)"
ID_LIKE="rhel centos fedora"
Details of setup:-
Since the cluster doesn't support the conda environment, I installed all the libraries with their latest version in virtualenv. I am attaching the libraries version file here. requirements.txt
Data Set and pre-trained model details:
Train  Dataset
Inference Dataset
Pre-trained Model
I am using these files:- config_new.json and weights_new.pth
Details of execution:-

After installing and running the pre-trained model, at the histogram plot generation step, it was observed that numpy=1.24 which doesn't support np.int but support np.int_, given that your repository is built on numpy==1.19.2 and using np.int which is removed from numpy==1.24, I changed this in code at lines 28,55 in /project/60025/anshita/ClimateNet/climatenet/track_events.py Source: https://stackoverflow.com/a/74946903
After this change, it worked fine.
When I ran the project again, it halt with this error- ValueError: Longitude<PHONE_NUMBER>449724 is out of range [-180, 180] in this file- /project/60025/anshita/ClimateNet/climatenet/analyze_events.py at line 192. Also, when I tried to check the values of the latitudes and longitudes, I found that all the values are not within this range.
Here are the values for pos1 and pos2 (highlighted in yellow color and marked as red for perceptible purposes):

In my humble opinion, these values should be scaled by code. Please provide your advice and kind suggestions.
Here the example.py file for your reference example.zip
Please let me know in case you need further details of how I am running your code or any configuration-related details. I will wait and appreciate your attention to this issue.
Appreciate your response at the earliest.
Thank You.
Best regards,
Anshita Saxena

Hello Anshita,
thanks a lot for reaching out!
The values of pos1 and pos2 you print seem to be correct and as expected, since those are simply the pixel positions (for which these values are normal).
Line 192 now turns them into the appropriate lat/lon before computing the haversine distances:
distances = np.array([hs.haversine(pixel_to_degree(pos1), pixel_to_degree(pos2)) for pos1, pos2 in zip(termination_centroids, genesis_centroids)])
Since you're getting an error, I expect there's something going wrong in the pixel_to_degree function (line 31). Can you share event_masks.shape, which gets used there? I suspect there's some issue with the dimensions.
Best
Andre

Hi Andre,
Heartily appreciate your response. Now, I got that you are normalizing the pixel values to that range through pixel_to_degree(). Here is the shape of event_masks: 768
Here is the output screenshot for reference:

I will wait for your further advice and suggestions on this.
Thank You.
Best regards,
Anshita Saxena

Hi Andre,
Appreciate your help here. Yes, I was printing event_masks.shape[1]. Here is the output: (61, 768, 1152)
I will wait for your further advice and suggestions on this.
Thank You.
Best regards,
Anshita Saxena

Hey Anshita,
thanks! This is puzzling, since these numbers look completely normal (and calling pixel_to_degree on the pos1 and pos2 values you shared should result in numbers in the required range). I'm not sure what's going on, can you show me the output of np.array([[pixel_to_degree(pos1), pixel_to_degree(pos2)] for pos1, pos2 in zip(termination_centroids, genesis_centroids)])? This is basically just the inputs to the haversine function which throws the error. If these are not strange, can you give me more details on which function exactly throws this ValueError? I assumed it was the haversine function but just want to make sure.
Best
Andre

Thank you!
This helps, it seems like there is really an issue with the pixel_to_degree function. I'll check with Lukas and get back to you as soon as possible.
Best
Andre

Hi Andre,
Sure. I will wait for your response. Thanks for your reply.
Thank You.
Best regards,
Anshita Saxena

Hi Andre,
I tried to debug this issue and found that we have written '+180' term instead '-180' term for pos[2]. Isn't it '-180'?

Example:-
pos=(444.4273699539777,<PHONE_NUMBER>639117)=(pos[0], pos[1])
pos[0] * 180.0 / event_masks.shape[1] - 90 ------> We got 14.16266483 which is expected and within the range [-180, 180]
pos[1] * 360 / event_masks.shape[2] + 180 ------> We got<PHONE_NUMBER>4 which is out of range [-180, 180] and if we put pos[1] * 360 / event_masks.shape[2] - 180  ------> We will get 76.34537664 which is within the range [-180, 180].
Wanted to confirm you that are these the expected value, if yes, may I open the pull request for this change and merge it?
I will wait and appreciate your attention to this issue.
Appreciate your response at the earliest.
Thank You.
Best regards,
Anshita Saxena

Hi Andre,
I just wanted to append the results directory also for the validation of your side. These plots are generated after I performed the above change in code.
Could you please have look at the plots and confirm whether these are expected based on the functionality? Please find the attachments.
I am new to this project and currently trying to build my understanding of it.
genesis_frequency_results.zip
global_frequency_results.zip
termination_frequency_results.zip
histogram_lifetime.zip
I will wait and appreciate your attention to this issue.
Appreciate your response at the earliest.
Thank You.
Best regards,
Anshita Saxena

Any news @andregraubner ?
Thank You.
Best regards,
Anshita Saxena


Add progress bar to create_deep_image

For consistency with other functions processing the dataset, a progress bar should be added to any other functions which may take time to process.
Known to be missing this bar is create_deep_image.

Also need to add this to create_snr_map

Added tqdm wrapper to the outer loop of create_snr_map

I broke up the np.sum funciton to work on individual chunks so that I could add a progressbar to create_deep_image.

Nice - as long as it shows progress for anything that takes longer than a couple of seconds, you're golden


Implement drone-plugin-fossa

By default, this plugin will run the analyze command per the generic CI documentation for FOSSA.

Please assign someone to review and merge @Sahota1225

@Sahota1225 ping


remove pdf target

What does this PR do?
Temporarily remove the pdf target from ReadTheDocs to fix build.

Codecov Report

Merging #3415 (afa7e33) into main (b39e70a) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3415      +/-   ##
==========================================
- Coverage   83.69%   83.68%   -0.02%
==========================================
  Files          56       56
  Lines        6808     6808
==========================================
- Hits         5698     5697       -1
- Misses       1110     1111       +1

see 1 file with indirect coverage changes


Notification feature

Issue

#82

Overview (Required)

This PR provides first cut of notification feature.

Show notification 10 minutes ago of session which user checks.
Cancel notification when user unchecks session.
By tapping the notification, app will launch.
If user disables notification in setting screen, the notification will not show.

Links

Screenshot

Before
After

:eyes:

@kobakei Reviewed! Can you check the comments if you have a time?
Thanks for your quick contribution!! 👍 👍

@konifar yeah, it will get overridden next time we import translations.
Please add only to the main strings.xml and translate on onesky.
On Mon, Feb 6, 2017, 07:44 Yusuke Konishi<EMAIL_ADDRESS>wrote:

@kobakei https://github.com/kobakei Reviewed! Can you check the
comments if you have a time?
Thanks for your quick contribution!! 👍 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/DroidKaigi/conference-app-2017/pull/92#issuecomment-277556318,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAY_q9mEJw1ozQLE6pr1xps2iX6JQNPKks5rZlC0gaJpZM4L3kTC
.


Deprecate the default rooms beta for #admins and #announce rooms

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/280874
Tests
Before performing any local tests

Delete  || canUseAllBetas(betas) from the condition in canUseDefaultRooms.
Create an account in OldDot. Go to Settings > Domains and create a new domain.
Sign into that same account in NewDot. Create a workspace, or use an existing one. Be sure to have the #announce and #admins rooms ready.
Make sure you're using the Web Proxy

LHN Options

Verify that the #admins room for your workspace appears in the LHN
Verify that the #announce room for your workspace appears in the LHN.
Verify that the #domain.com room does not appear in the LHN
Add back the  || canUseAllBetas(betas) to the condition in canUseDefaultRooms.
Verify that the #domain.com room appears in the LHN.

Last viewed report
If you added  || canUseAllBetas(betas) to the condition in canUseDefaultRooms, delete it again.

Navigate to the #admins room.
Sign out and back into your account.
Verify you are taken to the #admins room after signing in.
Navigate to the #admins room.
Sign out and back into your account.
Verify you are taken to the #announce room after signing in.

Offline tests
N/A
QA Steps
ping @jasperhuangg to QA
LHN Options
1 Verify that the #admins room for your workspace appears in the LHN
2. Verify that the #announce room for your workspace appears in the LHN.
3. Verify that the #domain.com room does not appear in the LHN
Last viewed report

Navigate to the #admins room.
Sign out and back into your account.
Verify you are taken to the #admins room after signing in.
Navigate to the #admins room.
Sign out and back into your account.
Verify you are taken to the #announce room after signing in.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/31285285/236312398-cbbb86d9-57ca-41b4-85d9-329e67acc1d4.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/31285285/236313933-fd5acc68-4597-479d-b2af-f79ea30d5a04.mov

Mobile Web - Safari
https://user-images.githubusercontent.com/31285285/236314740-f35a7983-5834-41e5-a6c4-1c2a6b8f34b1.mov

Desktop

iOS

Android

Asked about test domains here (see QA steps for context)

Adding CP Staging label as there's some urgency around this

@yuwenmemon Yeah it can, just thought there was some urgency around this. If you don't agree feel free to remove the label.

@jasperhuangg yeah better to err on the side of caution IMO. If someone wants it right now we can always CP it later too.

Ah @0xmiroslav you need to be an internal employee to do that on your dev environment. You can just test the changes to admins and announce rooms for now. Ignore anything that has anything to do with domain rooms.

Hey @jasperhuangg I think the steps under "Last viewed report" repeat, is that's intentional?

Hey @jasperhuangg I think the steps under "Last viewed report" repeat, is that's intentional?

@PauloGasparSv fixed them, was a typo, thanks for pointing that out!

@0xmiroslav will you be able to compete your review today?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Verification API implementation

This is an implementation of the Paystacks' Verification API. This API performs three different actions at the time of this implementation

Resolve Bank Account Number
Validate Bank Account
Resolve Customers' card with the BIN (first 6 characters of the card)

hey @devfresher thanks for the contrib, sorry took me long to check

No worries at all! I'm glad the changes have been merged. I'll make sure to update all my dependent projects accordingly.
Thanks for the feedback!


KAFKA-16286; Notify listener of latest leader and epoch

KRaft was only notifying listeners of the latest leader and epoch when the replica transition to a new state. This can result in the listener never getting notified if the registration happened after it had become a follower.
This problem doesn't exists for the active leader because the KRaft implementation attempts to notified the listener of the latest leader and epoch when the replica is the active leader.
This issue is fixed by notifying the listeners of the latest leader and epoch after processing the listener registration request.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Is there any chance we could fire leader change more than once on a transition? (I guess this might be allowable behavior?)

Thanks. I updated the KRaft tests to check that there no duplicate notifications.

All of the raft:test tests passed. There seem to be some unrelated failures. Running the tests again.


Typescript Error

In the file, components/cart/index.tsx the code below throws a TS error per the error below. How is this TS error removed?
<LineItemsCount>
                 {({ quantity }) =>
                   quantity ? (

                       {quantity}{" "}
                       {t("general.item", { count: quantity })}

                   ) : null
                 }
               </LineItemsCount>

The error reported is:
Type '({ quantity }: Omit<LineItemsCountProps, "children"> & { quantity: number; }) => Element | null' is not assignable to type '(LineItemsCountChildrenProps & (string | number | boolean | ReactElement<any, string | JSXElementConstructor<any>> | ReactFragment | ReactPortal | null)) | undefined'.
  Type '({ quantity }: Omit<LineItemsCountProps, "children"> & { quantity: number; }) => Element | null' is not assignable to type 'LineItemsCountChildrenProps & string'.
    Type '({ quantity }: Omit<LineItemsCountProps, "children"> & { quantity: number; }) => Element | null' is not assignable to type 'string'.ts(2322)

Hi @osseonews,
I was looking into this and unfortunately, I could not reproduce the issue.
Where do you get the TS error?
The build task (yarn run build) works fine and type-checking is enabled.
Are you able to build the app?
I remember probably seeing this when trying to use React 18, which is not supported yet (we are working on it).

Hi @osseonews
Sorry if this took a while. We have just released a new cart version 2.0.0 which also includes the update to React 18 (using @commercelayer/react-components v4).
This solves the issue you had with Typescript when using react 18.
Please notes that this version comes with some breaking change since it does not use NextJs anymore, but a much simpler Vite.js build that can be deployed on any static site web hosting and does not require any server-side capabilities.
You can check the release notes to see what's changed.
Any feedback is appreciated.


add google-form-submitter

Submits drop screenshots to a Google Form.

This plugin always submits requests to imgbb.com, even if its key is empty. Please either add a guard to prevent outgoing requests with the default (empty) configuration, or add a warning to the plugin indicating that it will make outbound requests. (see example)

This plugin always submits requests to imgbb.com, even if its key is empty. Please either add a guard to prevent outgoing requests with the default (empty) configuration, or add a warning to the plugin indicating that it will make outbound requests. (see example)

Hi, I have made both changes that you suggested.


build(modules): allow skipping uthash download

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Some build systems run on air-gapped environments, making it impossible to download stuff from the internet at build time. Since the uthash version we use doesn't seem to provide a proper way of installing for cmake to find, we can at least allow a way for adopters to provide the required header file directly from the local system. If someone knows of a better way to do this, I'm open to change the PR 🙂.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Molter73
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Molter73]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I think you can just copy what we do for eg: tinydir: https://github.com/falcosecurity/libs/blob/master/cmake/modules/tinydir.cmake
And install it in the ci through the install-deps script.

Ok, fatherhood is destroying my brain, I realize now you can just download the uthash.h file to the proper directory and call it a day. It would still be nice to get an error message if we are not using the bundled deps and the file isn't there, so I'll rework the changes a little.

I don't get all the changes; couldn't we just use:
option(USE_BUNDLED_UTHASH "Enable building of the bundled uthash" ${USE_BUNDLED_DEPS})

if(UTHASH_INCLUDE)
    # we already have uthash
elseif(NOT USE_BUNDLED_UTHASH)
    find_path(UTHASH_INCLUDE uthash.h)
    if(UTHASH_INCLUDE)
        message(STATUS "Found uthash: include: ${UTHASH_INCLUDE}")
    else()
        message(FATAL_ERROR "Couldn't find system uthash")
    endif()
else()

    set(UTHASH_SRC "${PROJECT_BINARY_DIR}/uthash-prefix/src/uthash")
    set(UTHASH_INCLUDE "${UTHASH_SRC}")

    message(STATUS "Using bundled uthash in '${UTHASH_SRC}'")

    ExternalProject_Add(uthash
            PREFIX "${PROJECT_BINARY_DIR}/uthash-prefix"
            URL "..."
            URL_HASH "SHA256=..."
            CONFIGURE_COMMAND ""
            BUILD_COMMAND ""
            INSTALL_COMMAND "")
endif()

if(NOT TARGET uthash)
    add_custom_target(uthash)
endif()

include_directories("${UTHASH_INCLUDE}")

Just like we do for other header only libraries?
Then, a single change to the install-deps script to install uthash header under /usr/include would do the trick.

Yeah, that's probably better, I was trying not to completely change the module but that's a better solution.

Should be better now, had to add uthash as a dependencies on a bunch of scap targets but I think it's clearer.
Also, userspace/libscap/scap_savefile.c is executable for some reason? I just changed it to not be so.

I am not sure about the new deps; a quick grep shows:
grep -R "uthash_ext.h" userspace/
userspace/libscap/linux/scap_fds.c:#include "uthash_ext.h"
userspace/libscap/linux/scap_cgroup.c:#include "uthash_ext.h"
userspace/libscap/linux/scap_linux_int.h:#include "uthash_ext.h"
userspace/libscap/scap_suppress.h:#include "uthash_ext.h"
userspace/libscap/scap_fds.c:#include "uthash_ext.h"
userspace/libscap/scap.h:#include "uthash_ext.h"

It seems like only scap + linux platform should need it.

I understand! Then this is the way to go; CI is :green_circle: after all!

/milestone 0.14.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, Molter73
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,Molter73]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 11770364ef6ce02da33468d75478714872837e04

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, Molter73
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,Molter73]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


true token a mis-parse: parsing Nixpkgs

*** Exception: Failed to parse /home/deepfire/nixpkgs/pkgs/development/haskell-modules/hackage-packages.nix:
ErrInfo {_errDoc = /home/deepfire/nixpkgs/pkgs/development/haskell-modules/hackage-packages.nix:71311:47: error: expected: "]",
    ., bool, identifier, integer,
    letter, list, null, parens,
    path, set, spath, string
         scientific template-haskell text true-name unordered-containers
                                              ^                                , _errDeltas = [Directed "/home/deepfire/nixpkgs/pkgs/development/haskell-modules/hackage-packages.nix" 71310 46 2793041 46]}
CallStack (from HasCallStack):
  error, called at ./NH/Misc.hs:27:10 in main:NH.Misc

Also, interestingly (despite both true/false and assert being reserve tokens):
[nix-shell:~/hnix]$ hnix --expr 'let assert-a = 1; in assert-a'
let assert-a = 1; in assert-a
[nix-shell:~/hnix]$ hnix --expr 'let true-a = 1; in true-a'
let true-a = 1; in true - a


[MRG] Enable anti-aliasing in plot_raw

Fix #4434

+1 for MRG

Should we add a whats_new entry just in case?

Should we add a whats_new entry just in case?

Sure, why not

it should be done with Epochs plotter too before we forget.

Codecov Report

Merging #4442 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4442      +/-   ##
==========================================
+ Coverage   82.81%   82.81%   +<.01%
==========================================
  Files         349      349
  Lines       64364    64364
  Branches     9910     9910
==========================================
+ Hits        53303    53304       +1
+ Misses       8323     8322       -1
  Partials     2738     2738

@cbrnr can you do that in this PR, too?

Sure. What about line 1040 in viz/_3d.py?

try to see the impact

@agramfort this requires mayavi which currently doesn't work in Python 3. I don't have the time to set up a Python 2 env just to test this, so I suggest that we leave this setting as it is (unless someone else can check the plot with and without antialiasing and let me know if this can also be set to True).

it does not require mayavi. it's in the function:
def _smooth_plot(this_time, params):
"""Smooth source estimate data and plot with mpl."""
that is meant to work with matplotlib
also mayavi works on python 3. With conda I do:
conda install pyqt=4.11.4 qt=4.8.7
conda install -c satra vtk
pip install mayavi
and it should work assuming you use a mac.

OK, I'll try that. All tests using _smooth_plot have the @require_mayavi decorator, which is the easiest way for me to produce a plot with this function.

that's bad not to be able to test without mayavi. This should be fixed.

~ $ conda install pyqt=4.11.4 qt=4.8.7
Fetching package metadata .........
Solving package specifications: .

UnsatisfiableError: The following specifications were found to be in conflict:
  - pyqt 4.11.4* -> python 2.7* -> openssl 1.0.1*
  - python 3.6*

Let's not worry about this in this PR. I suggest to open a new issue where we can discuss setting antialiased=True also for this type of plot.

ok thx @cbrnr


flutter-engine: allow local version pinning

currently the local patches in flutter-engine do only fit for the proposed default version of FLUTTER_SDK_TAG.
If one would want to locally pin the version to something different one or more patches wouldn’t apply.
Fix this by weak defining a new variable called FLUTTER_ENGINE_PATCHES which can be easily overridden in a local setup or a layer on top of meta-flutter to have the right set of patches stored there

Please sign your commit
git ammend -s`
git push --force


dma: Better suspend/resume testing

Make the test data larger to help slow down the transfer long enough
to get suspend to work. Then attempts to spin on suspend. If we can
suspend any of the test transfers, we succeed.
Previous suspend resume test would always fail on DesignWare DMA
as it was seemingly already done by the time dma_suspend would be
called.
Fixes #44006
Fixes #44106
Signed-off-by: Tom Burdick<EMAIL_ADDRESS>

Verified on intel_adsp_cavs25.

@FRASTM saw an issue on STM32 that should be resolved with the latest push

I can confirm it passes on the disco_l475_iot1 too :+1:


Add Threads API

I would love to use this module as its well-maintained & uses TS.
However, I need support for threads. You can use https://github.com/adblanc/twit-thread/ for inspiration.
Curious to see docs, supported features, comparison with other Twitter modules? Basically roadmap :)

Hey, thanks for checking out the library. Supporting threads sounds cool but unfortunately there is no endpoint for this in Twitter API v2. The library you have linked is a wrapper for another twitter api library and the former adds support for threads by looping over the sent tweets. This isn't something that a core client library like twitter.js can add natively as it's too specific and should be either done by the user itself or by a framework of the library. You can ask for this feature for the API here. Once an endpoint for threads is public we will definitely add support for it in twitter.js.
We do have docs that get generated using the comments in the source code, you can see it here. It's a bit outdated, I'll make the docs build & publish on each merge soon, which will keep it up to date with the source code. The other thing related to docs that we have planned is a custom site for it. The current docs site gets auto generated by typedoc. We also have a guide website planned that will help new users learn how to use the library. This will be the best place to teach niche topics like "how to create a thread using twitter.js?" and more. The guide will come sooner than the custom docs website.
As you can see most of the roadmap isn't written anywhere as I'm working alone at this point of time and the current highest priority is to add support for all the endpoints that are currently public in Twitter API v2. With v0.3.0 we would reach that point as I've added support for most of the endpoints that were left. This means twitter.js v0.3.0 will be here in a week or two. After that I'll shift the focus towards docs, guide, a proper README and hopefully an actual roadmap ;)
I'll keep the issue open until we have all of the above stuff done. 👍

@iShibi so the threads API isn't available in v2? Or it was never available in v1 as well but users were looping through tweets as a workaround?

There doesn't seem to be anything related to threads in v1. The Twitter API v2 is still in dev and the endpoints for creating tweets haven't been released yet. So they may or may not add threads this time. However, I did find an old post asking for this feature here. It says it's under review.

@iShibi can you tell me then if it's possible to support threads using your library as twit-thread uses twit underhood so I don't want to install 2 libraries doing the same thing :)

Currently twitter.js can't even post normal tweets as the endpoints for it aren't published yet. Once they are here then yes you can easily create threads using tweet create and replies (which is what that lib is doing). We will have a section in the guide teaching how to do it.
If twitter decides to provide endpoints for creating threads then the lib will support that natively and you won't have to do the above stuff.
tl;dr if you want a solution right now then you can use them but, if you can wait then yeah you won't have to install two libs in any case, as twitter.js will let you create threads. The "How" depends on whether twitter provides an endpoint for threads or not.

Perfect! Lmk when you ship the tweets endpoint :)


fix(carousel): carousel rtl fixes

Related Ticket(s)
Closes https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/10950
Depends on https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/11031
Description
RTL fixes for the carousel.
Changelog
Changed

Changes carousel CSS to use CSS logical properties to better support RTL.

Testing
NOTE: The RTL build is not auto-adding the dir="rtl" attribute to the <html> tag, which we expect, so the below test instructions include adding that manually on page load. There is a fix for this in progress: https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/11031

[ ] Navigate to Carousel stories
[ ] Open Chrome Dev tools and set dir="rtl" attribute on the <html> tag
[ ] Verify the slide navigation arrows are correct
[ ] Verify the slider works as expected in RTL
[ ] Regression test the carousel in LTR writing mode (eg. without adding any attribute to the <html> tag)

Comparing the LTR and RTL versions by executing $$('*').forEach(el => el.dir = "rtl") has shown a couple additional fixes needed:

The nav buttons need to be inline-end aligned
The nav buttons should be pointing in the direction of "more cards" (make sure correct button is disabled)
CTA icons need to point to inline-end (this might be out of scope for this ticket)

Comparing the LTR and RTL versions by executing $$('*').forEach(el => el.dir = "rtl") has shown a couple additional fixes needed:

I've merged @annawen1 's fix for RTL, so that we can just look at the Web Components (RTL) deploy preview now. We're dependant on that now, which hopefully lands in the not too distant future.

The nav buttons need to be inline-end aligned

✅

The nav buttons should be pointing in the direction of "more cards" (make sure correct button is disabled)

✅

CTA icons need to point to inline-end (this might be out of scope for this ticket)

Yeah, I agree that it's out of scope. Issue is with the <dds-card-footer> component.

Thanks for the review @jkaeser .
This is ready for review by the rest of you all. Please note that I merged in @annawen1 's PR to fix the Storybook RTL build, so this PR effectively depends on that one.

Things we're getting messy since my branch had merged an older set of commits from @annawen1 's PR. Now that's merged to main, I decided to rebase my branch, and picked just my commits representing work on this branch. Much clearner commit history now.

@kennylam I'm not sure what to make of the job failures here. main is also in a failed state across many of the CI jobs, so I'm going to assume it's not me. For instance ci-check / check-packages is failing on yarn install. All is well on my local.
Is this a known issue ATM?

@m4olivei Definitely not just you. We're looking into it now.


Bump ember version to latest 'develop' - 6/20/2018

tested the UI - worked as expected, except for the reappearance of container-title field in metadata blob, for which ticket had been submitted.


YAML language server fails to install and retries over and over

Check for existing issues

[X] Completed

Describe the bug / provide steps to reproduce it
Zed tries to install the YAML language server over and over nonstop. To reproduce, open a project with a YAML file inside, or open a yaml file.
It shows this in Zed's interface
https://github.com/zed-industries/community/assets/72631767/5aada5bd-2be0-4ab0-85fc-39d33394ec58
Environment
Zed: v0.107.7 (stable)
OS: macOS 14.0.0
Memory: 16 GiB
Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.
If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.
Zed.log
I x'd out my name for privacy reasons

+1, I am also seeing this. In my case it's cycling between Yaml and Javascript

Yep, unfortunately this is a known issue and a hard one.  We will focus on trying to fix it again shortly.

Also have this issue.

Thanks for looking into this @JosephTLyons. I just want to add that the fact that the download doesn't succeed bothers me less than seeing the toolbar at the bottom constantly switch text at short intervals intervals. The consequence of the text switching between download x/y language language server is that it keeps catching my attention which gets in the way of me focusing on actual development (I would prefer if the download was cancelled instead of retried). This might sound petty, but it is the reason why I prefer not to use zed currently.

Thanks for looking into this @JosephTLyons. I just want to add that the fact that the download doesn't succeed bothers me less than seeing the toolbar at the bottom constantly switch text at short intervals intervals. The consequence of the text switching between download x/y language language server is that it keeps catching my attention which gets in the way of me focusing on actual development (I would prefer if the download was cancelled instead of retried). This might sound petty, but it is the reason why I prefer not to use zed currently.

lol I am the exact same in this regard

I totally get it. This is a frustrating problem. We have some incredibly intelligent human beings exploring it right now, but its hard to say if it will get fully addressed or not before we finish our burn list to go open source, as that is our biggest blocker for giving everyone the ability to help us!

I totally get it. This is a frustrating problem. We have some incredibly intelligent human beings exploring it right now, but its hard to say if it will get fully addressed or not before we finish our burn list to go open source, as that is our biggest blocker for giving everyone the ability to help us!

No problem, ya'll take your time <3


[android] Click 'Remove Torrent and Data' for a Torrent file with status 'Finished' or 'Seeding' - The file remains on My Files temporally

To reproduce this issue:

Go to the Transfer list and select a Torrent file with status 'Finished' or 'Seeding'

Click the option 'Remove Torrent and Data'

Go to 'My Files > My Torrents' and you will see the file remains on the list of torrents

Try to select the file and FW will say: 'The file was deleted from the SD card, or the SD card you have inserted is a different one':

If you go to Storage Location you won't find the Torrent so it should be fixed refreshing My Files after canceling and deleting the data.
This issue is related to: https://github.com/frostwire/frostwire/issues/273

this is one annoying bug. confirmed this today when testing the new feature to remove .torrent files when transfers start. The .torrent file isn't there but it keeps appearing on the adapter. gotta take a look at how .torrent files are fetched, if we have a custom table fetcher or something.

Should be fixed with https://github.com/frostwire/frostwire/commit/624ccaf027e8e4715f73b4d2e94d1eab2e849120

Tested on FW 2.0.2-build-497 on android 6 and 7
Files saved within SD card and Internal Memory
I cannot reproduce it again with the files I had in Transfer... The 'zombie' torrents that remained there before were from pretty old builds, I remember trying this in January https://github.com/frostwire/frostwire/issues/620 and I could see these 'zombies' around but since I don't have old data in Transfer for the latest builds I could say is fixed.
Closing here unless I can find a particular scenario where I can reproduce.


Infinite Redirect Loop on 404 Page in Production

Link to reproduction
No response
Environment Info
Website Template
Payload: 3.0.0-beta.107

Describe the Bug
When visiting a non-existent page (404) in production, the page flickers continuously, suggesting an infinite redirect loop. The browser console shows the following error:
Server Error: NEXT_NOT_FOUND
    at PayloadRedirects (webpack-internal:///(rsc)/./src/components/PayloadRedirects/index.tsx:34:69)

This issue only appears in production mode. In development mode, the error is displayed in the console, but the 404 page loads correctly without flickering.
Reproduction Steps

Use the latest website template.
Seed the database.
Remove the seed page redirect in [slug]/page.tsx.
Visit any non-existent page in production mode.

Adapters and Plugins
No response

Hey @lorenzrabs,
I'm able to reproduce your issue consistently by building (via npm run build) the app and navigating to a page I know doesn't exist - triggering the 404.
I'm attaching a video of the current behavior. I haven't deployed this application, it's currently running on my local windows machine however I'm able to reproduce your issue with both mongodb and the postgres adapter. I've attached a video of the issue. Looking at console logs indicates it's an RSC problem.
https://github.com/user-attachments/assets/b6d61a6a-3d2e-4b08-8d10-da69d0207182

Just pushed an update to the website template in https://github.com/payloadcms/payload/pull/8454
Along with the previous bumping of next canary, payload updates and this I haven't been able to reproduce this issue. Let me know if you do

I also have this issue.
I assumed that generateStaticParams() in page template doesn't render routes for created pages in cms, during build process, so instead i used getStaticPaths() returning paths with option "fallback: 'blocking'". And routes to my pages are generated, but.. in this case i got infinite redirect loop on Page 404 on production.
export async function getStaticPaths() {
  const payload = await getPayloadHMR({ config: configPromise });
  const pages = await payload.find({
    collection: 'pages',
    draft: false,
    limit: 1000,
    overrideAccess: false,
  });

  const paths = pages.docs
    .filter((doc) => doc.slug !== 'home')
    .map(({ slug }) => ({
      params: { slug },
    }));

  return { paths, fallback: 'blocking' };
}

I assumed that generateStaticParams() in page template doesn't render routes for created pages in cms, during build process, so instead i used getStaticPaths

Actually it should still generate static paths at build: https://nextjs.org/docs/app/api-reference/functions/generate-static-params and you'll see these routes in the output during build.
getStaticPaths doesnt work in the app router anymore, it's been replaced by the above: https://nextjs.org/docs/app/building-your-application/upgrading/app-router-migration#dynamic-paths-getstaticpaths
The pages will be statically generated at build time if you add the following in the page.tsx file while maintaining the previous features:
export const dynamic = 'force-static'

During build you'll see this static indicator
├ ○ /[slug]           <- static
├ ƒ /api/[...slug]    <- dynamic

As for the redirect loop I still haven't been able to reproduce it. But I have found a couple of other bugs that I'll be deploying in a bit.
I will close this issue for now, but if anyone has any further info or reproduction steps we can re-open it or make a new issue and tag me in it, thanks everyone!


fixed bug on issue 9

Hi Sergio,
I hope it can be useful to you.

I merged the pull request and done some additional changes as described in the commit messages here: https://github.com/sbtourist/Journal.IO/tree/wip-threads-oom
Btw, as I needed to keep the Journal-specific writer thread, it sill goes OOM due to too many native threads.
I'm not sure if it is worth the inclusion in master.
Any feedback/ideas are welcome.

I think that the solution to use a kind of reactor is the best solution that you can choice,
then for the moment I close this pull request.


gp.se and www.gp.se false positive

This is the biggest newspaper in Gothenburg, Sweden and should not be blocked.

Hello and thanks for your interest!
Unfortunately, this repository is just our "frontend" (Basically just a distributor). Therefore let's continue the discussion about this in our backend at https://github.com/Ultimate-Hosts-Blacklist/whitelist/issues/81.
Cheers,
Nissar


Add application/octet-stream to consumed content types in S3 Handler

The AWS Java client uses this content type in its requests. Also, the
body content type is only consumed in a single method anyways, and is
treated the same regardless of its type.
What changes are proposed in this pull request?
Add application/octet-stream to the default mime types which are allowed
Why are the changes needed?
Some S3 clients (e.g. Java AWS SDK) use the application/octet-stream by default for the request content type. We only ever consume a byte stream in the handlers anyways, so adding application/octet-stream to the types should be harmless and increase support.
Does this PR introduce any user facing changes?
No

Codecov Report

Merging #14101 (e968689) into master (1a760b6) will decrease coverage by 25.90%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #14101       +/-   ##
=============================================
- Coverage     43.26%   17.35%   -25.91%
+ Complexity     9206     2698     -6508
=============================================
  Files          1425     1425
  Lines         82510    82510
  Branches       9983     9983
=============================================
- Hits          35697    14323    -21374
- Misses        43848    66934    +23086
+ Partials       2965     1253     -1712

Impacted Files
Coverage Δ

...in/java/alluxio/proxy/s3/S3RestServiceHandler.java
0.00% <ø> (-3.09%)
:arrow_down:

...mon/src/main/java/alluxio/shell/CommandReturn.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/util/ExceptionUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/wire/AlluxioProxyInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/alluxio/wire/AlluxioMasterInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/job/meta/JobIdGenerator.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/stress/BaseParameters.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/client/UnderStorageType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...main/java/alluxio/underfs/options/ListOptions.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...main/java/alluxio/worker/block/io/BlockReader.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 671 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a4942...e968689. Read the comment docs.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.6 please


It's Blackjack! Try to get your card total as close to 21 as possible without going over.

How do you play your game?
Press J to bet credits, and L to start the game. Press L to hit after the initial draw, D to double down, and K to stand.
After a round has finished, J will reset the cards and add credits to your bet. It is also possible to play without betting anything, but that's not any fun at all!
The number to the left of the suit (heart, spade, etc) is the card value.
The dealer's second card will be face down until the player (that's you!) has finished their turn.
The rules of this version are as you expect: all face cards are worth 10, aces count as both 1 and 11 depending on the other cards in your hand.
This version also contains the "5-Card Charlie" rule, so getting 5 cards without going over 21 is an automatic win.

Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[x] The image is in the /games/img directory.
[x] The name of the image matches the name of your file.

Thanks for your PR!

Thanks for submitting this game - it was fun to play! You'll be able to see it in the gallery starting Wednesday.
If you're a teen, you can get a Sprig console for free - just fill out this form. Also, feel free to join our Slack to talk to other teens in the #sprig channel.


Cannot use -H command line option

Using the -H command line option does not seem to work.
node: bad option: -H
Without this, you can't use a socket-proxy

Yeah you're right, I didn't forward command to /portainer binary.
Fixed in this commit https://github.com/ngxson/portainer-ce-without-annoying/commit/06278098dc50769aa0caf4042a2b2db22b35c4ea
Please pull the new image from docker hub. Thanks.

Seems to work fine now. Thanks!


Does not support Laravel 5.1

The last few releases require Illuminate/support 5.2 which implies Laravel >= 5.2.
Was there a reason to require 5.2? Would you consider lowering the bar to 5.1? I have to keep using 5.1 LTS for a bit.
Thanks.
/S

Yeah I'm down with lowering it to 5.1.
5.2 was what I was using at the time.
I'll see what I can do tonight

Thanks, if it works it would be appreciated.
/s
On Feb 2, 2017 5:26 PM, "Tyler Arbon"<EMAIL_ADDRESS>wrote:

Yeah I'm down with lowering it to 5.1.
5.2 was what I was using at the time.
I'll see what I can do tonight
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tylercd100/lern/issues/44#issuecomment-277104722, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC30Ftg8K-HtaTphQ8SrtgQK0VUlc8Pqks5rYlgfgaJpZM4L0UOX
.

Can you give 3.8.0 a try?

sorry, try 3.8.1
3.8.0 wasnt actually installing 5.1 oops!

:1st_place_medal:
Works! Thanks a lot for considering this change, it's really appreciated. Your package is helping me a lot.
Couple of notes in case it helps someone else or even myself next time I encounter these issue:

The composer command ran out of memory with this error:

PHP Fatal error:  Allowed memory size of<PHONE_NUMBER> bytes exhausted (tried to allocate 134217728 bytes) in phar:///usr/local/bin/composer/src/Composer/DependencyResolver/Solver.php on line 220
PHP Stack trace:
PHP   1. {main}() /usr/local/bin/composer:0
PHP   2. require() /usr/local/bin/composer:24
...

The solution was to unlock the memory limit for that command with:
$ php -d memory_limit=-1 /usr/local/bin/composer update tylercd100/lern

I had to first remove LERN then require it again, otherwise composer would not update it.

 $ php -d memory_limit=-1 /usr/local/bin/composer remove tylercd100/lern
 $ php -d memory_limit=-1 /usr/local/bin/composer require tylercd100/lern:^3.8.1

My project is getting pretty big with lots of dependencies, so I suppose that composer is not only requiring a lot of memory to process them all, but that it may get a little confused as it does.
Again, thank you very much.
/s


breaking: use .prebuild for prebuild versions

rename the build portion of --target to --prebuild, so it still looks nice in the prebuildrc.
tests are passing now, i hope though i didn't miss anything.
what do you devs think?

fixes #80

I'm +1. Maybe rename targets.js to something better? Or maybe replace:
if (rc.all === true) {
  delete rc.prebuild
  rc.prebuild = targets
}

with
if (rc.all === true) {
  rc.prebuild = [
    '0.10.41',
    '0.12.9',
    '1.0.4',
    '1.8.4',
    '2.5.0',
    '3.3.1',
    '4.2.4',
    '5.3.0'
  ]
}

and remove targets.js completely?

targets.js is used in tests as well, so i guess we need to keep it

targets.js is used in tests as well, so i guess we need to keep it

I trust your judgment :grinning:
@mafintosh Anything to add?

@juliangruber @ralphtheninja i trust your judgement :tada:

i'll look over this for a bit and then merge :)

needed to update docs. looks good? i'll squash once we agree to merge

needed to update docs. looks good? i'll squash once we agree to merge

Looks good!

@mafintosh @ralphtheninja ready to publish a 3.0.0?

:ship:

3.0.0 it is :rocket:

https://twitter.com/juliangruber/status/697867311554936833

:fireworks:


Add Solutions in Golang Language

Solutions are welcomed for each problem in golang. Please check contributing Guidelines before starting.

[ ] Day 0 Assigned to @Kausam
[ ] Day 1  Assigned to @Kausam
[ ] Day 2  Assigned to @Kausam
[ ] Day 3  Assigned to @Kausam
[ ] Day 4
[ ] Day 5
[ ] Day 6
[ ] Day 7
[ ] Day 8
[ ] Day 9  Assigned to @garvita-jain
[ ] Day 10  Assigned to @garvita-jain
[ ] Day 11
[ ] Day 12
[ ] Day 13
[ ] Day 14
[ ] Day 15
[ ] Day 16
[ ] Day 17
[ ] Day 18
[ ] Day 19
[ ] Day 20
[ ] Day 21
[ ] Day 22
[ ] Day 23
[ ] Day 24
[ ] Day 25
[ ] Day 26
[ ] Day 27
[ ] Day 28
[ ] Day 29

Hi, @sagarchoudhary96 I would like to work on this.

@Jolly1234 , mention the day numbers for which you would like to work on first. then you can start working on it and  make a PR for it.

@sagarchoudhary96, I would like to work on problems part of Day 0 to Day 15.

@Kausam, you can pick max 4 at once and send a PR for it so that it's easy for me to review too and others can also get chance to contribute. once one apr is merged then you can pick other 4.

Okay, I will take up the first 4 problems. That is problems from Day 0 to Day 3.

okay @Kausam , go ahead👍

@sagarchoudhary96 I'd like to work on Day 9 and 10 problems. Can you please assign those to me.

sure @garvita-jain

Hi Sagar,
Anything is fine.. day 4,5,6,7 I can pick

Also, Sagar, I was thinking of updating readme.md like right now it contains only the solutions may be a link for questions would be better ( just a suggestion if u are fine with it)

hey @Jolly1234 , sure go ahead you can update Readme too. I will Create a new issue for it and assign to you.

hi @garvita-jain @Kausam , request you to start sending solution for the question solutions you have implemented one by one.

hi @sagarchoudhary96 , may I have 8, 11, 12 and 13, please?

Sure go ahead.

@sagarchoudhary96 , getting this error while trying to push the branch. Are you supposed to grant me access?
ERROR: Permission to sagarchoudhary96/30-Days-Of-Code.git denied to vigneshashokan.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

You cant directly push to my repo. You need to fork the repo then make changes in forked repo commit there and maie a pull request from forked repo to my repo.

I'll work on Day14

@kmalik31 sure go ahead 👍

hi @sagarchoudhary96 , can i solve day 15?

@gmgalvan sure go ahead, will assign it to you

@kmalik31 any updates on the progress?

@sagarchoudhary96 @vigneshashokan @kmalik31  can you guys update about your progress. if u are not working on it , let me know  will open them up so that anyone else can pick it up.

Sorry about the delay, @sagarchoudhary96 .. I got held up with something. I'm working on it and I'll have the PRs ready over the weekend.

sure @vigneshashokan  looking forward for your PR's :)

Quick question @sagarchoudhary96 , there is no Golang option available to submit in Hackerrank. If I just have a working solution for Day 12 and 13 is it fine? or is there a place where you want me to check my solution for test cases before I can create a PR?

it would be great if you can let me know which question is not available to be solved in golang on hackerrank, you can skip that one and work on the one which is available.

@vigneshashokan if both are not available you can pick from other available question and let mee know will assign them to you.

@sagarchoudhary96 unfortunately day14 problem doesn't accept any solutions in Golang :(

@Kausam  you can look in other open question we are about to finish it, i think only 28,29 is available on hackerrank in golang, can you check and update once and also if you would like to take available question.

Sure. Looks like Day 29 is already done. I'd be happy to take up Day28

@Kausam sure go ahead, waiting for your PR :)

we have finally finished this too. thanks to everyone for contributing to this issue 🎉😄


The gitter link on README points to a 404

Due to the recent repo change name, the Gitter link on the README now points towards a 404.
So either keep the old name for the gitter OR change it and then this PR is useless :)
(but in the meantime it fixes the 404).

Ok, I went too fast :running_man:
I close this PR in favor of #9284 (which includes this fix and wayyyy more :+1: )


DEFAULT.QC_Accessibility_Eservices - Defect # 487 - HTML validation issues

Accessibility Tests were on landing page - following errors highlighted
defect487.docx

Anticipated fix: remove code

Results of validation test on landing page:
ian@ian-desktop $ curl http://localhost:3000 | tidy5 -e
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 18319  100 18319    0     0  56398      0 --:--:-- --:--:-- --:--:-- 56540
Info: Document content looks like XHTML5
No warnings or errors were found.

About HTML Tidy: https://github.com/htacg/tidy-html5
Bug reports and comments: https://github.com/htacg/tidy-html5/issues
Or send questions and comments to: https://lists.w3.org/Archives/Public/public-htacg/
Latest HTML specification: http://dev.w3.org/html5/spec-author-view/
Validate your HTML documents: http://validator.w3.org/nu/
Lobby your company to join the W3C: http://www.w3.org/Consortium

Fixed version on lr-pres-dev-c

fixed - closed


implementation for #1332

Implementation collect methods for Value interface.

[Current coverage][cc-pull] is 95.57%

Merging [#1352][cc-pull] into [master][cc-base-branch] will increase coverage by <.01%

File ...rent/FutureImpl.java (not in diff) was modified. more

Misses -1
Partials -2
Hits +3

@@             master      #1352   diff @@
==========================================
  Files            86         86
  Lines          9991       9997     +6
  Methods           0          0
  Messages          0          0
  Branches       1803       1803
==========================================
+ Hits           9545       9554     +9
+ Misses          319        318     -1
+ Partials        127        125     -2

Powered by Codecov. Last updated by [a7958de...b10665f][cc-compare]
[cc-base-branch]: https://codecov.io/gh/javaslang/javaslang/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/javaslang/javaslang/compare/a7958de50177c27be60d726039ab17bad1db4783...b10665fa4f5f54c381b58591bac0b981759db4f3
[cc-pull]: https://codecov.io/gh/javaslang/javaslang/pull/1352?src=pr

Hi @earlzero, thank you for your contribution!
I will add some comments regarding formatting to match the Javaslang code base style.

@ruslansennov thanks, I didn't realise that it may hold multple values initially. I've implemented multi-value case.
@danieldietrich Don't mention :). I've fixed issues you mentioned (spaces, final, etc).

I've modified your code a bit and used StreamSupport, it does only depend on the underlying splitterator/iterator. For multi-valued types (like Traversable) we iterate the elements only once (instead of twice in the previous solution).
    /**
     * Collect value using provided collector
     *

     * Use {@link #collect(Supplier, BiConsumer, BiConsumer)} internally
     *
     * @param collector Collector performing reduction
     * @return R result of "reduction" with collector
     */
    default <R, A> R collect(Collector<? super T, A, R> collector) {
        return StreamSupport.stream(spliterator(), false).collect(collector);
    }

    /**
     * Collect value using supplier, accumulator and combiner
     *

     * Since it is provided for a single value, it do not use combiner
     *
     * @param supplier    provide unit value for reduction
     * @param accumulator perform reduction with unit value
     * @param combiner    function for combining two values, which must be
     *                    compatible with the accumulator.
     * @return R result of "reduction"
     */
    default <R> R collect(Supplier<R> supplier, BiConsumer<R, ? super T> accumulator, BiConsumer<R, R> combiner) {
        return StreamSupport.stream(spliterator(), false).collect(supplier, accumulator, combiner);
    }

Please use the formatting above, your formatter seems to differ from our IntelliJ IDEA settings (provided in this repo).

Please insert the code right behind the line
    // -- conversion methods

@danieldietrich Thanks for modification. I do not use IDEA, so I can't import this settings. I've checked for tabs/spaces again and moved everything according to your second comment.

Thanks for your effort, I really appreciate it!


Improve error handling

Currently when there's an exception in production, the logging is very minimal. Especially on RunKit this makes debugging impossibly hard.

:tada: This issue has been resolved in version 1.3.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: