hi

the best time for collaboration probably would have been when starting the project but I guess the second best time is now!
the slated long-term plan for pre-commit is to replace the python implementation with rust -- I've been slowly working towards that over the last couple of years but I've been busy and progress has been slow.  I figure we can probably accelerate that if you'd like to work together on accomplishing it
there's also the tricky task of compatibility and migration (which I've fortunately thought a lot about and will hopefully make the transition smoother!) -- the main compatibility issues is going to be around regular expressions, language: pygrep, and ultimately bootstrapping python where missing for language: python (though I think uv will likely take that responsibility at some point) -- happy to talk more on this though as it's kinda the hardest part of making such a shift successful
can also help with the planned direction I'm going for with languages in general -- as that's going to break a lot of what isn't yet implemented here (or there) since the structure and internals are likely to change a lot there (goal being to divorce the installations, repositories, and languages as they're really three separate entities currently represented as one (maybe 1.5 if we're being honest))
an aside -- the repository in the current state violates several copyrights and licenses.  I intentionally chose to release my code under MIT to make it very simple to abide by the license (simply distribute a copy of the license in derivative works) but unfortunately your current implementation reads as a plagiarism -- fortunately an easy fix to include the licenses of your copied work!

I'm thrilled to see you, @asottile!
I apologize for the copyright violation regarding pre-commit. I must admit that I essentially translated the original Python implementation into this project. I've now added a copyright notice for pre-commit to the LICENSE in #74. Thank you so much for your outstanding work on pre-commit!
I started this project purely to practice Rust and was completely unaware of the existence of https://github.com/pre-commit/pre-commit-rs, which has been around for two years! I never intended for this project to become widely known, so I didn't reach out for collaboration—especially since my Rust skills are quite basic and I wasn't sure how far this project would go.
I'm truly honored by your invitation to collaborate! I believe the ideal home for this project is https://github.com/pre-commit/pre-commit-rs. Do you have any specific plans for moving forward? Since I wasn't aware of https://github.com/pre-commit/pre-commit-rs, my implementation took a slightly different path. How do you find the current approach? Would you prefer a merge, or should we develop anew from the ground up?
But there are reasons this project should continue. I have ideas that might differ from yours regarding implementations or feature additions. Initially, I envisioned this project as a unique dialect of the original pre-commit, not a replacement. I might keep some distinct features here, as the original pre-commit is so widely used, and adding features or making breaking changes is challenging. This way, users can choose whichever suits them best.
What do you think? Thanks again for reaching out—I really appreciate it!

I'm truly honored by your invitation to collaborate! I believe the ideal home for this project is https://github.com/pre-commit/pre-commit-rs. Do you have any specific plans for moving forward? Since I wasn't aware of https://github.com/pre-commit/pre-commit-rs, my implementation took a slightly different path. How do you find the current implementation? Would you prefer a merge, or should we develop anew from the ground up?

I haven't had time to look over much of this code yet -- though the few files I've glanced at look like they were straight ported by chatgpt?  given that I think I'd prefer to continue in the approach I was going with -- which is carefully porting a piece of functionality at a time until the rest is built out -- and then working on the compatibility / transition plan (tool for testing existing configuration for regex compatibility, "deprecating" pygrep for rsgrep (doesn't exist yet), etc.)

But there are reasons this project should continue. I have ideas that might differ from yours regarding implementations or feature additions. Initially, I envisioned this project as a unique dialect of the original pre-commit, not a replacement. I might keep some distinct features here, as the original pre-commit is so widely used, and adding features or making breaking changes is challenging. This way, users can choose whichever suits them best.

I was a little worried you'd say this.  I hope you understand the optics of what you've built so far looks like a hostile fork -- and is unethical to lift the code as you've done.  the "not a replacement" at the very least seems disingenuous given your README uses exactly the word replacement.
ideally this wouldn't continue.  two separate divergent implementations is going to create a rift in users and add undue compatibility / complexity pains (for both parties!).

I would also recommend this project to distance itself from pre-commit as much as possible. Just not for the above reasons...
Next time he should use GPL if he feels the need to bully people


add oneforall

Add oneforall for subdomain enumration

https://www.daehee.com/oneforall/

oneforall is not giving better results than already have


Update cats-effect-laws, cats-effect-std, ... to 3.4.4

Updates

org.typelevel:cats-effect-laws
org.typelevel:cats-effect-std
org.typelevel:cats-effect-testkit

from 3.3.14 to 3.4.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.typelevel" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #839.


⚠ ClamAV has degraded performance

In 2d96580, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 215 ms

Resolved: ClamAV performance has improved in 700a211.


Are there plans to expose the Resolvers interface?

https://github.com/microsoft/vscode/blob/main/src/vscode-dts/vscode.proposed.resolvers.d.ts

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


pm: device: Get rid of core devices list

Use device tree dependencies between devices to replace hardcoded core devices.

this fixes a bug AFAIK, please add a reference

I think that the solution here is too complex, and still doesn't get rid, e.g. of CONFIG_PM_MAX_DEVICES.
As mentioned earlier, using devices as they are sorted by the linker should be enough. Current priorities duplicate dependency information to some extent. A device B depending on A will never appear before on the device list, since it's wrong to have prio(B) < prio(A).
If we want to have a list of devices with PM instead of checking for PM availability every time, we can:

Duplicate device list for PM purposes and drop those with no PM at init time
Use the proposal in #35257

I understood that using current priorities and checking for PM != NULL was the chosen solution to move forward.

Yep, that was what we had talked. I just thought this solution was simple enough and was consuming the right API to this. The proposal in #352577 I really want o avoid, I think is complex because the logic is scattered across different areas, linker sections, preprocessor magic, ...
Anyway, lets keep it simple and go with what we have discussed for now. I'll keep CONFIG_PM_MAX_DEVICES to track which devices were suspended and need to be resumed though.

this fixes a bug AFAIK, please add a reference

Yep, I've added the fixes tag in the first commit. Don't know why it is not linking the pr with the issue though.

I understood that using current priorities and checking for PM != NULL was the chosen solution to move forward.

I did not see a followup PR that addresses the feedback given last week. We agreed that #35257 was not enough and would require significant changes to devices


Release 1.0.6

Adds Chapter 4 to production
Adds Tracking with Umami

@benalleng I've raised a new release PR but I've named it with the same version - I think if we merge this without squashing then we will redeploy without losing commit history (if I increment the version in the PR title then we will lose your other 1.0.6 merge commit which will mean we will be skipping that version number in the commit history).


fix two badger cases where things can get stuck CORE-5156

Two changes here which will improve badger behavior:
1.) Change version check to strict inequality in case for some reason the badging info is wrong. Subsequent updates will fix it, or at least be at least as right as what is currently in there. You really only need to protect against truly old updates for this feature.
2.) Set the icon badge number always in the update for the main component. There seems to be some kind of race condition where the props value gets the updated value ahead of time and this update never happens. Furthermore, it will never happen until the badge state changes, so background/foregrounding the app does nothing. Change it so we always set the badge icon, I'm not sure why we would not want to always do this. Is it expensive?

Mmmm we shouldn't need either of these changes really. Let's discuss on the morning.

I think the first one is definitely needed, since technically that number just tracks the inbox version. Other aspects of the badge state can change other than chat, and the frontend should be processing those changes.
The second, I guess I'm not sure, but it seemed like the easiest change to make.

Ok I thought that it would be incremented when the badge state itself got
updated. If not then it actually serves very little value right?
On Wed, May 17, 2017 at 10:58 PM Mike Maxim<EMAIL_ADDRESS>wrote:

I think the first one is definitely needed, since technically that number
just tracks the inbox version. Other aspects of the badge state can change
other than chat, and the frontend should be processing those changes.
The second, I guess I'm not sure, but it seemed like the easiest change to
make.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/pull/7034#issuecomment-302287165, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAfhU94URUOx1XxH6tfmm9ZaqEinX0Nkks5r67PrgaJpZM4NeqkO
.

It was supposed to solve the problem of the icon badge number, which is only tracking chat. That is, syncing the updates from the server (through APNS) and from the service. It turns out that wasn't the problem anyway, but that was the attempt there. If we were to expand the icon badge to more than just chat, we would need to get a different number.

Also FWIW, my second change seems to fix the problem, I can't repro anymore on the build I am running. That being said, I am definitely onboard with this not being the right fix, there may be some underlying problem I don't know how to fix.

Hah spoke too soon! Juts repro'd, so it isn't the fix I guess.

Yeah I'll fix it in the morning. There are edge cases it leaves open
On Wed, May 17, 2017 at 11:04 PM Mike Maxim<EMAIL_ADDRESS>wrote:

Hah spoke too soon! Juts repro'd, so it isn't the fix I guess.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/pull/7034#issuecomment-302287778, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAfhU58PMEG5NMKyyfJaICYdD1jhB4Qoks5r67UsgaJpZM4NeqkO
.

Although I can get it to go away after foregounding... so not sure what is going on.

just to capture the conversation we shouldn't delegate to the main component this job of sending the badge state. on mobile its possible this isn't even mounted so its the wrong place to do it. making that change is larger and will be worked on aside from this ticket / release


is possible to be use DateTime.Date in Linq queries?

Hi,
I have the following query:
           using (var session = documentStore.LightweightSession())
            {
                list = session.Query<Sample>().Where(x => x.CompleteDate >= date).ToList();
                return list;
            }

This works perfectly returning my data from database and is translated to the following SQL:
select d.data, d.id, d.mt_version from public.mt_doc_sample as d where (d.mt_deleted = False and d.complete_date >= :arg0)
Now if change my query to this:
           using (var session = documentStore.LightweightSession())
            {
                list = session.Query<Sample>().Where(x => x.CompleteDate.Date >= date).ToList();
                return list;
            }

It doesn't return any value and is translated to the following SQL
select d.data, d.id, d.mt_version from public.mt_doc_sample as d where (d.mt_deleted = False and CAST(d.data -> 'CompleteDate' ->> 'Date' as timestamp without time zone) >= :arg0)
Is this suppose to happen?

@quicoli yes, it lies in the JSON storage nature. Normally dates are stored as strings. If you're doing .Date then query parser assumes that your type is object. So it generates such query with json selector - so d.data -> 'CompleteDate' ->> 'Date'.
As there is no data like that as CompletedDate is something like 2019-02-21 18:50:11 and not
{
    Date: '2018-02-21'
}

Then it's just not able to find matching record.
Unfortunately our query parser is not smart enough for that case. We might concider at some point of supporting that, but it won't happen soon, as we have limited capacity...
For this time being I'd suggest you to add getter:
DateTime CompletedDateDay =>CompleteDate.Date

then you can query by this date.
It's not ideal, as it will make the data redundancy, but it will work.

@quicoli I'm closing this issue for now. If you feel that suggested workaround is not enough. Please sennd comment and I'll reopen it.


feat: support imgix as an image service, and report perf numbers

This adds support for imgix as an image resizer, which I've added to the staging and production ENV.
It also moves our lambda URL into an ENV var (already added to staging and production).
Additionally, it tweaks the performance reporting to allow images from any of the supported image resize domains to be supported.

Gonna try to merge, even tho the test timeout is plaguing it.


Changed the available racks in some munitions

Added the ability of certain appropriately sized (small) munitions to use the smaller single munition rack:

9M120 Ataka
AGM114 Hellfire
250kg bomb
250kg glide bomb
GBU-12
GBU-16
S-24

Also removed the 3xRK from the 250kg glide bomb for consistency (the regular 250kg can't use it) and because the bombs clip each other.

I have two problems with this PR:

Although minor in my opinion, the small variant of the single munitions rack is usually intended for the small munitions of each missile class. I don't really mind this change though, as I allowed a lot of racks to be able to get used by more than a pair of missile types.

I don't really believe missiles that are fired from pods (Ataka) or that have racks specifically designed for them (Hellfire) should be allowed to use more racks. In the case of the Ataka, it lacks a "loaded" model or attachment, so the fins will be always out (not to mention this missile was never intended to be ever loaded on racks). As for the Hellfire, I'm really against it being able to be loaded on single munitions racks for two reasons: Realism (as far as I'm aware of, it can only be fired from the M299 (4-rail) and M310 (2-rail) launchers which we do have in ACFM) and balance, the Hellfire itself is really good considering its high penetration and fire-and-forget capabilities so allowing it to use a single munitions rack you can easily hide will give it even more advantages.

But that's just my opinion on the matter, if more people is willing to share their opinion they're welcome so I won't be closing this PR yet.

2. I don't really believe missiles that are fired from pods (Ataka) or that have racks specifically designed for them (Hellfire) should be allowed to use more racks. In the case of the Ataka, it lacks a "loaded" model or attachment, so the fins will be always out (not to mention this missile was never intended to be ever loaded on racks). As for the Hellfire, I'm really against it being able to be loaded on single munitions racks for two reasons: Realism (as far as I'm aware of, it can only be fired from the M299 (4-rail) and M310 (2-rail) launchers which we do have in ACFM) and balance, the Hellfire itself is really good considering its high penetration and fire-and-forget capabilities so allowing it to use a single munitions rack you can easily hide will give it even more advantages.

But that's just my opinion on the matter, if more people is willing to share their opinion they're welcome so I won't be closing this PR yet.

I only changed smaller munitions which already have access to the larger single rack, due to it looking extremely oversized for the missile. In that case, the model issue for the ataka isn't new, as it already had access to the 1xRK. Same with the hellfire, it can already be deployed from the large 1x rack. If you're concerned with that I can instead remove the option for both the small and regular 1x rack on the ataka and the hellfire, does that sound good?

If you're concerned with that I can instead remove the option for both the small and regular 1x rack on the ataka and the hellfire, does that sound good?

Sounds fine for me.

Single rack hellfire is possible because MML system exists https://en.wikipedia.org/wiki/Multi-Mission_Launcher
thats why it was added to single racks in first place

I applied the requested changes, removing the 1xRK and 1xRK small from the ataka's list, and the 1xRK small from the hellfire


Notes

Pull them in!    Save to a new mongo collection and create a new domain object for handling them.  The rest should fall into place.

The basics of the import are done with this commit: https://github.com/rsoden/osm-history/commit/b7baae19c07b0dc031f553f49a880a89f64895de
We still need to add questions, may need to update data model accordingly.
This issue is now about that stuff


[DOCS] Improve release docs

Why are the changes needed?

Add a step: generate change log and send pr to master branch before vote
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

@yaooqinn @pan3793 @turboFei

Generate change log for the release and send a pr to master branch

this is wrong. you can not use master branch for voting

It's a good point.. but the change log required the tag exists, seems the pipeline can be ?

create tag for the release candidate at local
generate the change log
delete the tag at local
push the change log to the release branch
create tag for the release candidate

Codecov Report

Merging #2873 (019565a) into master (8838895) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2873      +/-   ##
============================================
- Coverage     63.34%   63.33%   -0.01%
  Complexity      205      205
============================================
  Files           485      485
  Lines         21701    21706       +5
  Branches       2862     2863       +1
============================================
+ Hits          13746    13747       +1
- Misses         6655     6658       +3
- Partials       1300     1301       +1

Impacted Files
Coverage Δ

.../org/apache/kyuubi/engine/jdbc/JdbcSQLEngine.scala
51.51% <0.00%> (-3.04%)
:arrow_down:

...ache/kyuubi/operation/KyuubiOperationManager.scala
80.82% <0.00%> (-1.37%)
:arrow_down:

.../org/apache/kyuubi/operation/KyuubiOperation.scala
68.00% <0.00%> (-1.34%)
:arrow_down:

...kyuubi/engine/spark/operation/SparkOperation.scala
82.71% <0.00%> (-0.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8838895...019565a. Read the comment docs.

It's annoying...

thanks, merging to master


snyk is pricey

have just received an email that we have already spent 120 out of our 200 snyk scans this month... if we want unlimited scans, we need to buy a license for the organisation. alternatively, @HLasse suggested we could do the scans, only when merging into main (hopefully <200 times a month). thoughts, @MartinBernstorff @KennethEnevoldsen?

Don't know if the above is possible to do, though

Ahh, this is frustrating. Another option would be to only run it on changes to the requirements*.txt files. I think that keeps all the benefits of the current approach and saves us a subscription

Don't know if the above is possible to do, though

In GitHub CI it is very easy to enable workflow only on push to main branch.

will take a look at it tomorrow

Completely agree with @KennethEnevoldsen here. We can gate the snyk workflow so that it only runs if any of the requirements have changed since main. E.g. using filetype_modified_since_head with .txt.


[BinaryPrimitives] CollectionAssert.AreEqual instead of custom method

Description

Use CollectionAssert.AreEqual in tests instead of custom method

Motivation and Context

No need for a custom method

How Has This Been Tested?

All tests are passing
Screenshots
Types of changes

[ ] Improvement (non-breaking change that improves a feature, code or algorithm)
[ ] Bug fix (non-breaking change which fixes an issue with code or algorithm)
[ ] New feature (non-breaking change which adds functionality to code)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)
[ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
[x] Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
[ ] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

[x] My code follows the code style of this project (only if there are changes in source code).
[ ] My changes require an update to the documentation (there are changes that require the docs website to be updated).
[ ] I have updated the documentation accordingly (the changes require an update on the docs in this repo).
[x] I have read the CONTRIBUTING document.
[x] I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
[ ] I have added new tests to cover my changes.

Summary by CodeRabbit

Chores

Updated dependency versions for improved functionality and compatibility.

@KlausVcb please rebase this branch with upstream/develop. All conflicts should be fixed then.

@KlausVcb please rebase this branch with upstream/develop. All conflicts should be fixed then.

Hope that did the trick. Still new to PRs based on a fork :-)

Hope that did the trick. Still new to PRs based on a fork :-)

My personal trick:

add both origins to your git git add origin nano https://github.com/nanoframework/repo..on.nano.git
One you then merge a PR on the nano repo:

git checkout main
git pull nano main
git checkout -b my-new-branch-now-up-to-date

so, you're always up to date and never have to rebase ;-)


Automatically initializeApp on Firebase hosting

Description
firebase-app should automatically initializeApp when being hosted on Firebase hosting. firebase-app should only have to be called like this:
<firebase-app name="optional"></firebase-app>

Expected outcome
firebase-app element should pull properties from the Firebase hosting ENV variables.
Actual outcome
Currently, dev has to create their own secrets or ENV variables.

This could be handled with an auto attribute that would go fetch the config from the reserved URL. However, that would be asynchronous which would make certain things difficult until we have a solution for lazy loading in the JS SDK.

@mbleigh I got this idea while watching one of your talks at I/O '17. I have been trying to figure out a solution. I think I might be close I'm going to put up a PR and try to get some help with it.

Changed to stale


Evaluating on custom dataset

Hi all,
I would like to evaluate on a custom dataset. I tried to use the "run_cosypose_eval.py", but struggled. Are there any hints about that?

Hey, its me again.
While evaluation (run_cosypose_eval.py" I need a *.pkl file (for e.g. tless located in "saved_detections"). For eval on my custom dataset i do not have such a pkl file.
Can someone help me please?

Why does I need this file? I thougt the groundtruth is in the "scene_gt.json" !?
How can I generate such a file? Is there some script? Does anyone did it allready?
What is in this file? I think its the groundtruth?

Hi,
my assumption is, that the pkl file contains the 2D bounding box detections of an independent detection model. Therefore, it is not ground truth data but contains predictions that might be faulty. However, I would also be interested in generating such an file for a custom dataset. Has someone an answer to @hannes56a second question:

How can I generate such a file? Is there some script? Does anyone did it allready?


Request Report Issue

Hi,
Request report sending this response [code] => 403
"not a valid key=value pair (missing equal-sign) in Authorization header"
Can you guide please.
Thanks

first make your header like this:
array:4 [   0 => "Authorization: bearer Atza|IwEBIFI1lhHRkK3AjG9VXZBNiNtGPnqYit0axJmOgiqgzzr3FiSKUj7p6CA9o9Ha_uRC9YIUbBQhEDNWf4VuZ2AOpu0vle6gy3oWLBV6QLJ0TmsroQMqTkfWbJ6xoflhPxXC54shZJtIkL59c2ryjXmzc5UqV8WXZi25prYdaPQpgZWkh7bK9McoS8BpzEfx-3D9SeQ2_e_XozMXUjzfHf1KZqERx_XGfsYr1bgHEukE_syYQEuQchE475ckT0pRvqk3ewK9YIxu1Qzcjc8ziEzSo4_Drhn0eEK5zG***************************************SVzWnuPjeG8A"   1 => "User-Agent: Amazon advertising API library"   2 => "Amazon-Advertising-API-ClientId: amzn1.application-oa2-client.ec2e714*****************"   3 => "Amazon-Advertising-API-Scope: 129665*********" ]
And then you can debug the "doRefreshToken" function separately and check whether it responds correctly.


Let user decide whether animation auto stop/start when app resign/resume active

Add bool value to let sdk user decide whether animation should be

automatically stopped before resign active
automatically started after resume active

@eJamesLin
Maybe let's add back the autoStartAnimationAfterResumeActive so we can keep align the behavior for both sides.

After some more consideration, autoStopAnimationBeforeResignActive flag would make it quite complicated when determine the wasAnimating. So let keep it as it is for now!


Improved comments AddEnvironmentVariables method

Improved the comment for the prefix parameter in the AddEnvironmentVariables method
Issue #488

Hi @miguelcrpinto, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, DNFBOT;

Merged, thanks! e82c7aa236271b22792441caadce001e7fd426fa


[language] Update transaction fee payments so events are under 0xFEE

Previously, the call to LibraAccount.deposit in the block prologue
was causing events to be published under the 0x0 address. This addresses
this issue by adding a pay_from_capability function to the Libra
account module. From an event perspective, any
pay_from_capability-based payments should appear as though the
delegator of the withdrawal capability performed them.
Testing

Added a test to make sure the capability payments work the way they should.
Added a test to make sure that payments from the block prologue emit events with an event key of "0xFEE".

This PR should resolve #2047

:umbrella: The latest upstream changes (presumably 51576b3f6e39f9af5da52308e095bca6e82352de) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-libra r=sblackshear

:pushpin: Commit 2234a83 has been approved by sblackshear

:hourglass: Testing commit 2234a8356b4de063492753633899101efeee8f9d with merge f3a4895ccd6bdd6065184a49049510bd86b835da...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: sblackshear
Pushing f3a4895ccd6bdd6065184a49049510bd86b835da to master...


Cherry-pick latest changes from master

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


DNS error after chain reorg

Background
Been persistently slow and crashing from time to time. Looks like there is a whole mess of errors going on. By examining the logs, the error starts after a chain reorg. Any guidence on what might be going on would be helpful.
Your environment

version of lnd
0.5.1-beta commit=v0.5.1-beta
which operating system (uname -a on *Nix)
Linux lnd 4.14.70-v7+ #2 SMP Wed Sep 19 07:49:26 UTC 2018 armv7l Linux
version of btcd, bitcoind, or other backend
bitcoind: 0.17.0
any other relevant environment details
bitcoind and lnd are running in docker containers
raspberry pi 3b+

Steps to reproduce
Just by unlocking lnd all there errors start poping up in the logs.
Expected behaviour
Lnd should boot up and not have any errors.
remarkable logs
Initial errors from chain reorg
2019-02-03T05:04:00Z lnd UNKNOWN[5723] 2019-02-03 05:03:56.316 [ERR] LNWL: Unable to process chain reorg: Post http://<IP_ADDRESS>:8332: http: server closed idle connection
2019-02-03T06:46:19Z lnd UNKNOWN[5723] Post http://<IP_ADDRESS>:8332: EOF
2019-02-03T11:45:10Z lnd UNKNOWN[8930] 2019-02-03 11:45:10.052 [ERR] LNWL: Failed to process consensus server notification (name: `blockconnected`, detail: `failed to store sync information<PHONE_NUMBER>000000001c6a6aed9c7ddfc42d32d08df614c63db63989aa319583: failed to fetch block hash for height 561349: block not found`)
2019-02-03T11:48:43Z lnd UNKNOWN[8930] 2019-02-03 11:48:43.609 [ERR] LNWL: Failed to process consensus server notification (name: `blockconnected`, detail: `failed to store sync information<PHONE_NUMBER>0000000011232739925d985d9cc7da3b49a76e2a4293e3222b54b4: failed to fetch block hash for height 561350: block not found`)
2019-02-03T11:55:38Z lnd UNKNOWN[8930] 2019-02-03 11:55:38.521 [ERR] DISC: Unable to query bootstrapper BOLT-0010 DNS Seed: [[nodes.lightning.directory soa.nodes.lightning.directory]]: lookup soa.nodes.lightning.directory on <IP_ADDRESS>:53: server misbehaving
2019-02-03T11:55:38Z lnd UNKNOWN[8930] 2019-02-03 11:55:38.538 [ERR] SRVR: Unable to connect to<PHONE_NUMBER>b6887cef47b7505df97f877afc0488ec3ad2a33f0a8e3290a1a5a604@<IP_ADDRESS>:9735: dial tcp <IP_ADDRESS>:9735: connect: connection refused
2019-02-03T11:55:38Z lnd UNKNOWN[8930] 2019-02-03 11:55:38.538 [ERR] SRVR: Unable to connect to<PHONE_NUMBER>b6887cef47b7505df97f877afc0488ec3ad2a33f0a8e3290a1a5a604@<IP_ADDRESS>:9735: dial tcp <IP_ADDRESS>:9735: connect: connection refused
2019-02-03T11:55:48Z lnd UNKNOWN[8930] 2019-02-03 11:55:48.565 [ERR] DISC: Unable to query bootstrapper BOLT-0010 DNS Seed: [[nodes.lightning.directory soa.nodes.lightning.directory]]: lookup soa.nodes.lightning.directory on <IP_ADDRESS>:53: server misbehaving
2019-02-03T11:55:48Z lnd UNKNOWN[8930] 2019-02-03 11:55:48.570 [ERR] SRVR: Unable to retrieve initial bootstrap peers: no addresses found
2019-02-03T11:55:53Z lnd UNKNOWN[8930] 2019-02-03 11:55:53.608 [ERR] DISC: Unable to query bootstrapper BOLT-0010 DNS Seed: [[nodes.lightning.directory soa.nodes.lightning.directory]]: lookup soa.nodes.lightning.directory on <IP_ADDRESS>:53: server misbehaving
2019-02-03T11:55:53Z lnd UNKNOWN[8930] 2019-02-03 11:55:53.608 [ERR] SRVR: Unable to retrieve initial bootstrap peers: no addresses found
2019-02-03T11:55:58Z lnd UNKNOWN[8930] 2019-02-03 11:55:58.643 [ERR] DISC: Unable to query bootstrapper BOLT-0010 DNS Seed: [[nodes.lightning.directory soa.nodes.lightning.directory]]: lookup soa.nodes.lightning.directory on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:37807-><IP_ADDRESS>:53: i/o timeout
2019-02-03T11:55:58Z lnd UNKNOWN[8930] 2019-02-03 11:55:58.661 [ERR] SRVR: Unable to retrieve initial bootstrap peers: no addresses found
2019-02-03T11:56:08Z lnd UNKNOWN[8930] 2019-02-03 11:56:08.691 [ERR] DISC: Unable to query bootstrapper BOLT-0010 DNS Seed: [[nodes.lightning.directory soa.nodes.lightning.directory]]: lookup soa.nodes.lightning.directory on <IP_ADDRESS>:53: server misbehaving
2019-02-03T11:56:08Z lnd UNKNOWN[8930] 2019-02-03 11:56:08.698 [ERR] SRVR: Unable to retrieve initial bootstrap peers: no addresses found
2019-02-03T11:56:13Z lnd UNKNOWN[8930] 2019-02-03 11:56:13.733 [ERR] DISC: Unable to query bootstrapper BOLT-0010 DNS Seed: [[nodes.lightning.directory soa.nodes.lightning.directory]]: lookup soa.nodes.lightning.directory on <IP_ADDRESS>:53: server misbehaving

Switches to failing to connect to
2019-02-03T16:45:49Z lnd UNKNOWN[10400] 2019-02-03 16:45:49.371 [ERR] DISC: Unable to query bootstrapper BOLT-0010 DNS Seed: [[nodes.lightning.directory soa.nodes.lightning.directory]]: lookup soa.nodes.lightning.directory on <IP_ADDRESS>:53: server misbehaving
2019-02-03T16:45:49Z lnd UNKNOWN[10400] 2019-02-03 16:45:49.419 [ERR] DISC: unable to reply to peer query: unknown message: *lnwire.ReplyChannelRange
2019-02-03T16:45:49Z lnd UNKNOWN[10400] 2019-02-03 16:45:49.450 [ERR] SRVR: Unable to connect to 02eae56f155bae8a8eaab82ddc6fef04d5a79a6b0b0d7bcdd0b60d52f3015af031@<IP_ADDRESS>:9735: dial tcp <IP_ADDRESS>:9735: connect: connection refused
2019-02-03T16:45:49Z lnd UNKNOWN[10400] 2019-02-03 16:45:49.450 [ERR] SRVR: Unable to connect to 02eae56f155bae8a8eaab82ddc6fef04d5a79a6b0b0d7bcdd0b60d52f3015af031@<IP_ADDRESS>:9735: dial tcp <IP_ADDRESS>:9735: connect: connection refused
2019-02-03T16:45:49Z lnd UNKNOWN[10400] 2019-02-03 16:45:49.462 [WRN] SRVR: Established outbound connection to peer 024bd94f0425590434538fd21d4e58982f7e9cfd8f339205a73deb9c0e0341f5bd, but already connected, dropping conn
2019-02-03T16:45:49Z lnd UNKNOWN[10400] 2019-02-03 16:45:49.470 [ERR] SRVR: Unable to connect to 028aa5a991a2acf33da91674fe062219b640e5e57d77a48de6df3c0d30be22b05b@<IP_ADDRESS>:9735: dial tcp <IP_ADDRESS>:9735: connect: connection refused
2019-02-03T16:45:49Z lnd UNKNOWN[10400] 2019-02-03 16:45:49.470 [WRN] ATPL: Unable to connect to 028aa5a991a2acf33da91674fe062219b640e5e57d77a48de6df3c0d30be22b05b: exhausted all advertised addresses
2019-02-03T16:45:49Z lnd UNKNOWN[10400] 2019-02-03 16:45:49.522 [ERR] DISC: unable to reply to peer query: unknown message: *lnwire.ReplyChannelRange
2019-02-03T16:45:49Z lnd UNKNOWN[10400] 2019-02-03 16:45:49.721 [ERR] SRVR: Unable to connect to 028aa5a991a2acf33da91674fe062219b640e5e57d77a48de6df3c0d30be22b05b@<IP_ADDRESS>:9735: dial tcp <IP_ADDRESS>:9735: connect: connection refused
2019-02-03T16:45:49Z lnd UNKNOWN[10400] 2019-02-03 16:45:49.721 [ERR] SRVR: Unable to connect to 028aa5a991a2acf33da91674fe062219b640e5e57d77a48de6df3c0d30be22b05b@<IP_ADDRESS>:9735: dial tcp <IP_ADDRESS>:9735: connect: connection refused
2019-02-03T16:45:49Z lnd UNKNOWN[10400] 2019-02-03 16:45:49.763 [WRN] ATPL: Unable to open channel to 03fab7f8655169ea77d9691d4bd359e97782cb6177a6f76383994ed9c262af97a5 of 0.003 BTC: not enough witness outputs to create funding transaction, need 0.003 BTC only have 0 BTC  available
2019-02-03T16:46:09Z lnd UNKNOWN[10400] 2019-02-03 16:46:09.755 [ERR] DISC: Unable to query bootstrapper BOLT-0010 DNS Seed: [[nodes.lightning.directory soa.nodes.lightning.directory]]: lookup soa.nodes.lightning.directory on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:50734-><IP_ADDRESS>:53: i/o timeout
2019-02-03T16:46:29Z lnd UNKNOWN[10400] 2019-02-03 16:46:29.748 [ERR] DISC: Unable to query bootstrapper BOLT-0010 DNS Seed: [[nodes.lightning.directory soa.nodes.lightning.directory]]: lookup soa.nodes.lightning.directory on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:34353-><IP_ADDRESS>:53: i/o timeout
2019-02-03T16:46:29Z lnd UNKNOWN[10400] 2019-02-03 16:46:29.752 [ERR] SRVR: Unable to connect to 027ccec61f4bf1fafb5156931da6527dc104ec3613dd4f4050161d89dd76ab494c@[2001:470:5f:5f::232]:9735: dial tcp [2001:470:5f:5f::232]:9735: connect: network is unreachable
2019-02-03T16:46:29Z lnd UNKNOWN[10400] 2019-02-03 16:46:29.752 [ERR] SRVR: Unable to connect to 027ccec61f4bf1fafb5156931da6527dc104ec3613dd4f4050161d89dd76ab494c@[2001:470:5f:5f::232]:9735: dial tcp [2001:470:5f:5f::232]:9735: connect: network is unreachable
2019-02-03T16:46:34Z lnd UNKNOWN[10400] 2019-02-03 16:46:34.985 [ERR] SRVR: Unable to connect to 02a3d830cbd960b17ac55208ab9642a77d6bc3c24007e72d39994829b2d5471053@<IP_ADDRESS>:9735: EOF
2019-02-03T16:46:34Z lnd UNKNOWN[10400] 2019-02-03 16:46:34.985 [ERR] SRVR: Unable to connect to 02a3d830cbd960b17ac55208ab9642a77d6bc3c24007e72d39994829b2d5471053@<IP_ADDRESS>:9735: EOF
2019-02-03T16:46:54Z lnd UNKNOWN[10400] 2019-02-03 16:46:54.752 [ERR] DISC: Unable to query bootstrapper BOLT-0010 DNS Seed: [[nodes.lightning.directory soa.nodes.lightning.directory]]: lookup soa.nodes.lightning.directory on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:38790-><IP_ADDRESS>:53: i/o timeout
2019-02-03T16:46:54Z lnd UNKNOWN[10400] 2019-02-03 16:46:54.763 [ERR] SRVR: Unable to connect to 02ad6fb8d693dc1e4569bcedefadf5f72a931ae027dc0f0c544b34c1c6f3b9a02b@[2604:a880:800:a1::1375:5001]:9735: dial tcp [2604:a880:800:a1::1375:5001]:9735: connect: network is unreachable
2019-02-03T16:46:54Z lnd UNKNOWN[10400] 2019-02-03 16:46:54.764 [ERR] SRVR: Unable to connect to 02ad6fb8d693dc1e4569bcedefadf5f72a931ae027dc0f0c544b34c1c6f3b9a02b@[2604:a880:800:a1::1375:5001]:9735: dial tcp [2604:a880:800:a1::1375:5001]:9735: connect: network is unreachable
2019-02-03T16:47:48Z lnd UNKNOWN[10400] 2019-02-03 16:47:48.327 [ERR] RPCS: unable to open channel to NodeKey(&{1353420 17890e3aad8d35bc054f43acc00084b25229ecff0ab68debd82883ad65ee8266 ba04ce746a70320a83281f438177838ad729c60ce29aa2631ab79b7d2053376e}): not enough witness outputs to create funding transaction, need 0.001 BTC only have 0 BTC  available
2019-02-03T16:48:04Z lnd UNKNOWN[10400] 2019-02-03 16:48:04.859 [ERR] DISC: Unable to query bootstrapper BOLT-0010 DNS Seed: [[nodes.lightning.directory soa.nodes.lightning.directory]]: lookup soa.nodes.lightning.directory on <IP_ADDRESS>:53: server misbehaving
2019-02-03T16:48:22Z lnd UNKNOWN[10400] 2019-02-03 16:48:22.582 [ERR] SRVR: Unable to connect to 029eda74de66b675354054af719ba9e8f3f8954f88e2a8bcd0be8d7d191e9a11c1@<IP_ADDRESS>:9735: dial tcp <IP_ADDRESS>:9735: connect: connection timed out
2019-02-03T16:48:22Z lnd UNKNOWN[10400] 2019-02-03 16:48:22.582 [ERR] SRVR: Unable to connect to 029eda74de66b675354054af719ba9e8f3f8954f88e2a8bcd0be8d7d191e9a11c1@<IP_ADDRESS>:9735: dial tcp <IP_ADDRESS>:9735: connect: connection timed out
2019-02-03T16:48:22Z lnd UNKNOWN[10400] 2019-02-03 16:48:22.582 [ERR] SRVR: Unable to connect to 0265fae305778b7cb157365f70cf3a2047d2cad5c1ccc5f550c6d8a033084a8ea5@<IP_ADDRESS>:9735: dial tcp <IP_ADDRESS>:9735: connect: connection timed out
2019-02-03T16:48:22Z lnd UNKNOWN[10400] 2019-02-03 16:48:22.583 [ERR] SRVR: Unable to connect to 0265fae305778b7cb157365f70cf3a2047d2cad5c1ccc5f550c6d8a033084a8ea5@<IP_ADDRESS>:9735: dial tcp <IP_ADDRESS>:9735: connect: connection timed out

Eventually hits an out of memory error (i think)
2019-02-05T02:07:11Z lnd UNKNOWN[10400] 2019-02-05 02:07:09.561 [ERR] HSWC: ChannelLink(561385:1443:0) link failed, exiting htlcManager
2019-02-05T02:08:47Z lnd UNKNOWN[10400] 2019-02-05 02:08:42.730 [ERR] HSWC: ChannelLink(561386:3217:0) Failing link: ChannelPoint(d66d91f7b18c9eef136a33902991f8b487ef9d7d11440098dccc3e7d5aa120c0:0): received error from peer: sync error
2019-02-05T02:08:47Z lnd UNKNOWN[10400] 2019-02-05 02:08:43.477 [ERR] HSWC: ChannelLink(561386:3217:0) link failed, exiting htlcManager
2019-02-05T02:27:49Z lnd UNKNOWN[10400] runtime: pointer 0x2b30402 to unallocated span span.base()=0x2b30000 span.limit=0x2b31fe0 span.state=0
2019-02-05T02:27:49Z lnd UNKNOWN[10400] fatal error: found bad pointer in Go heap (incorrect use of unsafe or cgo?)
2019-02-05T02:27:52Z lnd UNKNOWN[10400]
2019-02-05T02:27:52Z lnd UNKNOWN[10400] runtime stack:
2019-02-05T02:27:53Z lnd UNKNOWN[10400] runtime.throw(0x9e0473, 0x3e)
2019-02-05T02:27:53Z lnd UNKNOWN[10400] #011/usr/local/go/src/runtime/panic.go:608 +0x5c fp=0x7edb3a64 sp=0x7edb3a50 pc=0x3df58
2019-02-05T02:27:53Z lnd UNKNOWN[10400] runtime.findObject(0x2b30402, 0x0, 0x0, 0x2542d90, 0x76ea3924, 0x1f)
2019-02-05T02:27:53Z lnd UNKNOWN[10400] #011/usr/local/go/src/runtime/mbitmap.go:399 +0x324 fp=0x7edb3a88 sp=0x7edb3a64 pc=0x24268
2019-02-05T02:27:53Z lnd UNKNOWN[10400] runtime.wbBufFlush1(0x2432000)
2019-02-05T02:27:53Z lnd UNKNOWN[10400] #011/usr/local/go/src/runtime/mwbbuf.go:252 +0xb0 fp=0x7edb3ac0 sp=0x7edb3a88 pc=0x39e54
2019-02-05T02:27:53Z lnd UNKNOWN[10400] runtime.wbBufFlush.func1()
2019-02-05T02:27:53Z lnd UNKNOWN[10400] #011/usr/local/go/src/runtime/mwbbuf.go:195 +0x20 fp=0x7edb3ac8 sp=0x7edb3ac0 pc=0x68900
2019-02-05T02:27:53Z lnd UNKNOWN[10400] runtime.systemstack(0x6a294)
2019-02-05T02:27:53Z lnd UNKNOWN[10400] #011/usr/local/go/src/runtime/asm_arm.s:354 +0x84 fp=0x7edb3acc sp=0x7edb3ac8 pc=0x6a428
2019-02-05T02:27:53Z lnd UNKNOWN[10400] runtime.mstart()
2019-02-05T02:27:53Z lnd UNKNOWN[10400] #0

Then goes into whatever this is.
06T11:17:32Z lnd UNKNOWN[10400] 2019-02-06 11:17:27.555 [WRN] DISC: no channel updates found for short_chan_id=518813:1551:0
2019-02-06T11:17:32Z lnd UNKNOWN[10400] 2019-02-06 11:17:27.611 [WRN] DISC: no channel updates found for short_chan_id=519526:931:0
2019-02-06T11:17:33Z lnd UNKNOWN[10400] 2019-02-06 11:17:28.003 [WRN] DISC: no channel updates found for short_chan_id=518674:151:0
2019-02-06T11:17:33Z lnd UNKNOWN[10400] 2019-02-06 11:17:28.003 [WRN] DISC: no channel updates found for short_chan_id=519526:927:0
2019-02-06T11:17:33Z lnd UNKNOWN[10400] 2019-02-06 11:17:28.003 [WRN] DISC: no channel updates found for short_chan_id=519122:991:0
2019-02-06T11:17:33Z lnd UNKNOWN[10400] 2019-02-06 11:17:28.003 [WRN] DISC: no channel updates found for short_chan_id=518813:1566:0
2019-02-06T11:17:33Z lnd UNKNOWN[10400] 2019-02-06 11:17:28.004 [WRN] DISC: no channel updates found for short_chan_id=518960:2496:0
2019-02-06T11:17:33Z lnd UNKNOWN[10400] 2019-02-06 11:17:28.004 [WRN] DISC: no channel updates found for short_chan_id=518226:943:0
2019-02-06T11:17:33Z lnd UNKNOWN[10400] 2019-02-06 11:17:28.004 [WRN] DISC: no channel updates found for short_chan_id=519471:1113:0
2019-02-06T11:17:33Z lnd UNKNOWN[10400] 2019-02-06 11:17:28.004 [WRN] DISC: no channel updates found for short_chan_id=518954:440:0
2019-02-06T11:17:33Z lnd UNKNOWN[10400] 2019-02-06 11:17:28.004 [WRN] DISC: no channel updates found for short_chan_id=519526:926:0
2019-02-06T11:17:33Z lnd UNKNOWN[10400] 2019-02-06 11:17:28.004 [WRN] DISC: no channel updates found for short_chan_id=519526:920:0
2019-02-06T11:17:33Z lnd UNKNOWN[10400] 2019-02-06 11:17:28.004 [WRN] DISC: no channel updates found for short_chan_id=518512:1962:1
2019-02-06T11:17:33Z lnd UNKNOWN[10400] 2019-02-06 11:17:28.005 [WRN] DISC: no channel updates found for short_chan_id=519121:1231:1
2019-02-06T11:17:33Z lnd UNKNOWN[10400] 2019-02-06 11:17:28.008 [WRN] DISC: no channel updates found for short_chan_id=518813:1551:0
2019-02-06T11:17:33Z lnd UNKNOWN[10400] 2019-02-06 11:17:28.008 [WRN] DISC: no channel updates found for short_chan_id=519526:931:0
2019-02-06T11:17:33Z lnd UNKNOWN[10400] 2019-02-06 11:17:28.008 [WRN] DISC: no channel updates found for short_chan_id=518674:151:0
2019-02-06T11:17:33Z lnd UNKNOWN[10400] 2019-02-06 11:17:28.008 [WRN] DISC: no channel updates found for short_chan_id=519526:927:0

Then hits an out of mem error and restarts the no channel updates found again.

I don't think this is related to a re-org. Instead: it's unable to maintain a proper connection to bitcoind, the router that it's behind doesn't like the default DNS server, someone sent it a bunch of zombie channels, and it OOM'd.

Looks more like a networking issue, no information provided thus far is actionable, will re-open if we get more information we can investigate.


How to disable forcing uppercase in MetroWindow title

Is there a way to not force uppercase letters in the title of a MetroWindow?

@shaggygi use TitleCaps property on MetroWindow if you use 1.2.4 or TitleCharacterCasing if you use the pre-release.

That did the trick.  Thx!


CSS for links needs to be fixed when primary color is used

If the background for a section is set to the primary color (blue) then links are hard to see on hover.

In addition, even without hover the "white" color is not apparent enough and should be fixed.

we have different link color


Make consent request for federated claims non mandatory

Currently, consent for federated user claims (when SP claim configs are not available) are prompted as mandatory, this should be changes as required as the user should have the option to proceed with authentication by selecting only a subset of federated claims.

Thank you for your contribution!
We are closing this issue since it has not been prioritized for a long time. Chances are that it has already been solved in more recent versions. If not, we will be re-evaluating this when it becomes a priority.


Client times out from server after a short time

Maybe we are sending keep alive packets incorrectly or are not sending them at all, this needs to be resolved quickly

This could also be related to the server i am testing on, as after checking the code it appears that we are actually responding to keep alive packets as we are supposed to

What version was this issue on? I can check to see if the issue is present with a vanilla server.

This could also be related to the server i am testing on, as after checking the code it appears that we are actually responding to keep alive packets as we are supposed to


Move parsers to matrix-discord-parser

This moves the parsers to matrix-discord-parser for less maintenance of the codebase in the future.
This also fixes #459 due to the threadsafe nature of matrix-discord-parser

Should some of the tests for matrix message parsing be removed as the other repo covers them already?

Should some of the tests for matrix message parsing be removed as the other repo covers them already?

Yes, if you are 100% sure that the test is covered elsewhere. I'm very happy to reduce the number of tests we need.


Remove unused CollectionId parameter of RekognitionFacesPolicy

Issue:
Fixes #974
Description of changes:
Removed unused CollectionId parameter of RekognitionFacesPolicy (policy template)
Description of how you validated changes:

make test: passed all tests
verified transformed template in the steps written in DEVELOPMENT_GUIDE

using this SAM template
# template.yaml
Resources:
  HogeFugaFunction:
    Type: AWS::Serverless::Function
    Properties:
      CodeUri: src/hogefuga/
      Handler: app.lambda_handler
      Policies:
        - RekognitionFacesPolicy: {}

I executed the commands below:
aws cloudformation package --template-file MY_TEMPLATE_PATH/template.yaml --output-template-file output-template.yaml --s3-bucket MY_S3_BUCKET
bin/sam-translate.py --template-file=output-template.yaml

Then I got expected transformed template like this
...
          {
            "PolicyName": "HogeFugaFunctionRolePolicy1",
            "PolicyDocument": {
              "Statement": [
                {
                  "Action": [
                    "rekognition:CompareFaces",
                    "rekognition:DetectFaces"
                  ],
                  "Resource": "*",
                  "Effect": "Allow"
                }
              ]
            }
          }
...

Checklist:

[x] Write/update tests
[x] make pr passes
[ ] Update documentation:

have to update this document when this pr merged.

[x] Verify transformed template deploys and application functions as expected
[x]  Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #985 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #985   +/-   ##
========================================
  Coverage    94.71%   94.71%
========================================
  Files           69       69
  Lines         3160     3160
  Branches       606      606
========================================
  Hits          2993     2993
  Misses          85       85
  Partials        82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88df20c...6c4c429. Read the comment docs.


Keep-Alive Stops

I have not fully investigated this issue yet, but I can post logs if you like.
Here are the conditions so far:

default KeepAlive=90
using ssl connections on port 8883

On initial connect, there is a proper:
44 [debug] [listener-YmqGbHeKno@<IP_ADDRESS>:47297] SENT: PINGREQ(Q0, R0, D0)
45 [debug] [listener-YmqGbHeKno@<IP_ADDRESS>:47297] SENT: <<192,0>>
[debug] [Client <0.3009.0>] RECV: PINGRESP(Q0, R0, D0)
This particular process is only doing subscriptions.  There are no publishes occurring from this.
The issue, is that there are no further KeepAlive's triggered.  And since we are relying on the internal reconnect process at this point, the KeepAlive process does not appear to be restarted.
I have about a 30-40% chance per run to get it into this state.  If it gets into this state, it never leaves.

@akutta ssl options? could you send me the whole logs? email: feng at emqtt.io

@erylee
I have just e-mailed it to you.

@erylee One additional note.  The server I am connecting to will disconnect the user if a keepalive is not received within 150% of the time specified.  Example:  KeepAlive = 90.  If a message hasn't been received within 135 seconds then the socket is disconnected.

I think I know what the issue is.
This client nearly guarantees that there will be a keep alive sent within 2x the keep-alive, while the server expects to have the keep-alive within 150% of the timing.  The keep-alive mechanism checks to see if there has been data sent to the server through the connected socket.  In order to have the server disconnect me, I need to send a subscribe message within the first 45 seconds (assuming 90 second keep-alive) of the last keep-alive.
The keep-alive mechanism does not appear to re-enable properly after a disconnect / reconnect.

I was able to reproduce this with the AWS IoT servers. Rather nasty bug I must say.

I have encountered this problem as well and debugged it further.  I know exactly what the problem is.
The emqttc_keepalive is recording the size of the last sent packet when it goes to "sleep" and then comparing it against the last sent packet when it "wakes up".  If they are not the same, it goes to "sleep" for another full keepalive duration.
The problem with this is that if your last message occurred immediately after your last keepalive, you can "sleep" for up to 2x the keepalive time.  This is exactly what Akutta was talking about.
You can either remove this check entirely and simply do a keepalive at the keep alive interval or the keepalive needs to know WHEN the last message was sent and determine the time from there.  Otherwise it is essentially guessing when the keep alive is suppose to be and it doesn't always work.

Bump

We have released the latest emqx now and the implementation is totally different from which is the past. Please try it.


chore: update and adding pre-commit.ci config hook

Description
Adding pre-commit.ci config hook + update of other hook versions
Issue linked
None
Checklist

[X] I have tested my changes locally.
[X] I have added necessary documentation or updated existing documentation.
[X] I have followed the coding style guidelines of this project.
[X] I have added appropriate unit tests.
[X] I have reviewed my changes before submitting this pull request.
[X] I have linked the issue or issues that are solved to the PR if any.
[X] I have assigned this PR to myself.
[X] I have added the minimum version decorator to any new backend method implemented.
[X] I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.23%. Comparing base (ff42ecc) to head (2d2dfd9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1109   +/-   ##
=======================================
  Coverage   90.23%   90.23%
=======================================
  Files          93       93
  Lines        6839     6839
=======================================
  Hits         6171     6171
  Misses        668      668

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


How to add participants in whatsapp?

I'm looking for some way to add new participants to an existing group. I've seen this topic #429 , however I do not know how to implement it, any ideas?

Testing  NEW wapi.js => https://github.com/Theblood/Wapi_NEW/blob/master/wapi.js

Yes, i update the wapi.js in my library but i do not know make the function for add participants at exists group;


on_player_left_game, eject from uplink station

If needed, use new 0.13 event to prevent offline players from hogging uplink stations.

Sadly player.character isn't readable when the player isn't connected...


chore: Update Nodeclaim Garbage Collection Controller Name

Fixes #N/A
Description

Update Nodeclaim controller garbage collection name

How was this change tested?

N/A

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 82.472%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/nodeclaim/garbagecollection/controller.go
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
90.32%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
4917

Relevant Lines:
5962

💛  - Coveralls


flame_tiled RenderableTileMap  does not render nested TileLayer & ImageLayer

Very related to https://github.com/flame-engine/flame/issues/1873
I don't know if this is expected as I am not a heavy Tiled user, but seems off to me and libGDX did render every TileLayer without caring about levels deep.
Current bug behaviour
Currently RenderableTileMap does only consider the first level of layers to render.
Thus if I have the following Tiled map structure the current implementation will fail to render all layers, as it will only consider the two group layers (Foreground and Background), which will be considered as _UnrenderableLayer:
TileMap/
├─ Foreground/
│  ├─ spawns
│  ├─ collisions
│  ├─ trees
├─ Background/
│  ├─ weed
│  ├─ floor (TileLayer)

Expected behaviour
I expect that RenderableTileMap looks for every renderable layer and renders it accordingly. It shouldn't care about its deep.
Steps to reproduce

Make a TiledMap with the structure attached before
Check how RenderableTileMap ignores the TileLayer and ImageLayer

Flutter doctor output

[✓] Flutter (Channel stable, 3.0.5, on macOS 11.6 20G165 darwin-x64, locale es-ES)
    • Flutter version 3.0.5 at /Users/raulmateobeneyto/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f1875d570e (7 weeks ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/raulmateobeneyto/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.46.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.6 20G165 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 104.0.5112.101

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

More environment information

flame: ^1.3.0
flame_tiled: ^1.7.2

More information

I am open to make a PR.

This will probably be quite a big undertaking, but we are of course open to PRs if you're interested in building this!
What do you think @kurtome @ufrshubham @nathanaelneveux?

It might be really simple to just add the child layers of Groups recursively as independent renderable layers.
I'm not sure if parent Group properties (like offset x/y) can affect the children though.

I'm not sure if parent Group properties (like offset x/y) can affect the children though.

Yeah, they do affect all the child layers.

What do you think about the following solution:

Render all renderable layers without caring about its level deep, doing a DFS.
Each layer should have a reference to its parent layer in order to calc the resulting properties.

So if each layer has a reference to its parent layer, forming a LayerTree; we could have the following getters:

opacity -> get opacity => (parent?.opacity ?? 1) * opacity;
offsetX -> get offsetX => (parent?.offsetX ?? 0) + offsetX
offsetY -> get offsetY => (parent?.offsetY ?? 0) + offsetY

libGDX does an invalidation and validation pattern to only do these calculations when they have been modified. I don't know if this a big improvement on performance; although it seems like the only reason.
Lmk if I'm missing something

Sounds like these layers possibly could be built with PositionComponents? Which would enable a lot of cool things.

That sounds interesting although I don't know the full benefits as I am just learning about flame. Would you care elaborating? As I understand the current layers are not build as PositionComponents are they?

Yeah, extending layers from the position component seems worth it. Along with handling the transformations automatically and correctly, it will also allow users to play around with priority values for each layer. Creating a foreground and background layer using the same tilemap will become possible.

So if each layer has a reference to its parent layer, forming a LayerTree; we could have the following getters:

opacity -> get opacity => (parent?.opacity ?? 1) * opacity;
offsetX -> get offsetX => (parent?.offsetX ?? 0) + offsetX
offsetY -> get offsetY => (parent?.offsetY ?? 0) + offsetY

This looks right to me, I played with Tiled a bit and the offsets are definitely additive and the opacity is multiplicative. I'm guessing the parallaxX and parallaxY are also multiplied with their parent (so, 0.5 and 0.5 => 0.25), similar to opacity. Although I didn't test the parallax much.
Another important note here is that you can nest groups within groups, so when calculating the value for the current layer, you need to use the parent's value based on it's parents all the way up the tree. So, you probably want to store the calculated value at each group layer for its children to access.
This actually seems pretty doable with the current structure of the code, a new _RenderableGroupLayer can call render on its children, etc.

Sounds like these layers possibly could be built with PositionComponents? Which would enable a lot of cool things.
Ya! This would be awesome, it's definitely a much bigger refactor to accomplish this though.

Related to Group layers generally: https://github.com/flame-engine/tiled.dart/pull/51

This isn't the prettiest solution, but it seems to get the job done: https://github.com/flame-engine/flame/pull/1886


如何开启tcp fast open？

还是说默认就是fast open？

Not supported.

to make it an idiomatic go project, we do not support fastopen unless golang has such underlying implementation.


New object: FontSet?

So, given how a fontParts "Font" is often quite like a "master", I still feel that we’re lacking a higher-level entity. So I’d like to suggest that perhaps something like a "font set" object could be specified? It could be loosely modeled after https://github.com/fonttools/fonttools/tree/master/Doc/source/designspaceLib
but without stuff like paths etc.
It would be a very simple object, really. In its most minimal sense, it would have a sources property that would be a list of src entries that point to fp font objects, a bit like a TrueType Collection. It might have some optional things, but I’m really mostly thinking of having just a slightly prettier and more pythonic lightweight rewrap of DesignSpace+UFO, but not ties 100% to interpolation.
FontSet:
  info:
    srcLib: # should point to one of the sources.src
    srcInfo: # should point to one of the sources.src
    srcGroups: # should point to one of the sources.src
    srcFeatures: # should point to one of the sources.src
  sources:
    - src:
         name:
         font:
         designspace:
            location:
            muteKerning: #?
            muteInfo: #?
            mutedGlyphNames: #?
    - src...:
  designspace:
    axes:
      - axis:
      - axis...:
    instances:
      - instance:
      - instance...:
    rules:
      - rule:
      - rule...:
  lib:

Adam, I think this ties into the idea of the Unified Font Set (http://unifiedfontobject.org/roadmap/) that is on the UFO roadmap. You are right, we need something like this, but I think getting that in the spec would be a good first step, then fontParts.

Ben,

What would be the best place to discuss this?

I think what could work would be a two-tier approach: one thing is having a "spec" (for both a document structure and an API), and a "declaration" or "proposal", which could have a status of being far less formal and the notion that it's not necessarily stable.

For example — tools already have some structure in which they hold data. And the content on that higher level is not so different, just the organization is different.
I forgot to look at UFS before I suggested "font set", but it's actually great that I came up with the same name. So ultimately, we may think of having a unified font set. Or semi-unified.

The big question is: do we need both a file spec and an API proposal at the same time, or can they be separate things? I think the latter. For example, my above suggestion for the fontset object (a mere sketch) takes from .designspace but shuffles things mildly. Yet I wouldn't necessarily want to change the .designspace document format — that's already implemented by several indepenent packages and works reasonably well. Since it works on paths and folders, the relative placement between .designspace and .ufo can be quite free, and I like that.

But once you've read those things into memory, you may want to have an API that's a bit more aligned.
Here, my thinking in my sketch was:

A font set should not enforce the notion of the fonts being sources of variability. You may want to just keep a static family of fonts on a set and manage them. Or they may be masters in a FontLab VI or Glyphs project — it doesn't matter so much. The API is ones particular method of viewing the data, and it can abstract the access — just like it already does in case of fontParts—UFO. After all, UFO is folders, plists and xmls organized one way, and fontParts is  API for objects.

So I think the file-based serialization of a font set is different from a thin proposal of budling font objects together, attaching some extra data that is currently missing and providing a way to expose other objects in that.
After all, fontParts should be a usable API even if a tool vendor decides to, say, use an entirely different serialization (e.g. monolithic JSON or whatever).
And, of course, I think a fontset proposal shouldn't be too strict, esp. to allow people to not have to change their existing implementations too much.
For example fontmake also already has some way to maintain a "fontset", but it's tied to designspace very directly, I think.
I wouldn't mind modelling closely on designspace, because I think Erik and the others have done the key work there already.
I just think it'd be odd and simply impractical for verbosity purposes to have a top level object in a slightly more generalized API called "DesignSpaceDocument" :)

@twardoch I opened an issue on the UFO spec, it's better to discuss there (https://github.com/unified-font-object/ufo-spec/issues/86).
What fontParts does and what the UFO does doesn't need to be super tightly coupled, but it would be good to get the UFO spec part done so that it can go into defcon, and then we can write tests for an implementation. Let's hash things out on the UFO side and then get it into fontParts.


AVRO-2153 Clearer error msg while parsing - specify which node had a …

…problem

I tried to reproduce the problem on my mac, and I couldn't.
Which platform and compiler are you using? Alternatively, can you attach a small schema that triggers this problem? Thank you.

Hi @thiru-apache I'm using g++ 4.8, gcc 4.7, ubuntu 14.04, and boost 1.66.0. I do also assume this is a problem with dependencies, but on the other hand I feel like it's good to have backwards compatibility in the parser if it doesn't make things less readable or clean, and I feel like in this case the commit does the opposite. Let me know what you think.
Nick

@nicksbyman It looks like boost::format does not work in your environment. While this patch will fix the specific problem you faced (by sidestepping boost::format), there are many other places we use boost::format. Either we get to the bottom of why this does not work in your environment or get rid of boost::format altogether. I don't think fixing a single instance is a good idea.
By the way, I had difficulty creating an Ubuntu instance with boost 1.66.0. By any chance is there an AWS AMI with the relevant software that I can use to understand the problem better? Thank you.


Measure fixes and improvments

Next measure PR :)

add MeasureSize flag to window, useful when you want window with scrollbars but on show just adapt window size to content size.
all dialogs fixed, now in dlangide preferences shows without horizontal scrollbars, file dialog fixed too
restore window in SDL (2.0.4 on linux) reset position and size to window initial. So after restore we must set it
SDL can't resize window to size with frame, so I modified windows version to works like SDL, fix function never goes to resize code
ability to set how many cols/rows sets minimum widget size, use example in file dialog

Now WindowFlag.MeasureSize and WindowOrContentResizeMode.resizeWindow looks the same but I plan add minimum window size support and then when you set WindowOrContentResizeMode.resizeWindow the window size can't be changed to smaller than content. This can be done with WindowOrContentResizeMode.shrinkWidgets.


Backport/pr30

Backport #30 to plugin-api-v1

This is blocked due to test failures until https://github.com/elastic/logstash/issues/5273 is resolved.

@jordansissel The PR now pick the correct gems, but the build fails because this PR uses the Event#get method.

@ph confirmed that the plugin-api-v1 branch passes specps after doing a bundle update. :heart:

Tests pass for me. Waiting on travis.

Hurray tests pass on Travis, too.

LGTM test passes

Merged into plugin-api-v1


Implement sss javascript wrapper using WASM

Refs: #1
Demo https://bakaoh.github.io/sss-wasm

[x] Implement a javascript library that can call the sss C code though WASM
[x] Make the implementation compatible with sss-node, should work with the same tests as in that repo
[x] Works in all major browsers, mobile and desktop, as well as node.js

Looks nice! Would be cool if there were some regression tests that could be used to make sure we're getting the same values from this as from the original SSS library. This seems to not be possible though because of the randomness introduced below the exposed interfaces.

Also would be nice to have @dsprenkels take a look if he is able to. This library could then potentially be donated to his collection of various sss-bindings.

@oed --- i've just updated randombytes.c, i hope that will be clearer
@christianlundkvist --- i don't know how to do that T__T

@bakaoh seems like https://dsprenkels.com/sss/ is down

Another project recently launched (EthBuenoAires) to do time-lock secret sharing, might also be interested in helping support this library?
Kimono

Kimono relies on an algorithm called Shamir’s Secret Sharing, which makes it possible to create N fragments from a secret such that any K of the fragments can reconstruct the original secret.

https://github.com/hillstreetlabs/kimono
https://medium.com/@pfh/kimono-trustless-secret-sharing-using-time-locks-on-ethereum-8e7e696494d

@oed (cc @bakaoh). Thanks for the heads-up. I think this may be due to a nginx/node.js HTTP2 upgrade issue, which looks like it could take some time to solve.
If you expect that your demo will remain up, then I could change the sss-node README to point to http://bakaoh.com/sss-wasm/ demo instead. What'd you think?

@dsprenkels -- sure, it's a github static pages so it'll always up

Awesome. Will do then. :)


feat: add new format and implement VCDICredFormatHandler

add VC_DI in CredFormat.Format
lay out VCDICredFormatHandler
add new schema classes for cred offer and request
implement CredExRecordVCDI
fix schemas on cred_abstract and cred_request, improve on vc_di support on alice-faber demo

next step
fix unittests issues
Note: this is a rebased version of @tra371 's pr #2759

Overall this looks good to me, but do we also want to add some readme/markdown about what VC_DI is and how to get the verifiable credential out or how it can interoperate with other wallets?  we could also do that separtely from the repo or later, but i'd like to make sure new folks have an idea why, when and how to use them?

@dhh1128 would greatly appreciate (and recognize) your guideance here to get this over the line nicely, if you have any suggestions.

@ianco do we care that we don't have codecov? should we worry if we actually covered all the new stuff?

Personally I'm not too concerned about the level of code coverage as long as we have good integration tests.  However we do need a minimal set of unit tests to confirm that the code works.  I did a quick review of the code and it doesn't look like there are any new tests (?) in this PR yet.
Regarding the broken tests, many are throwing a "StopAsyncIteration" error - for example:
./scripts/run_tests aries_cloudagent/protocols/issue_credential/v2_0/tests/test_routes.py::TestV20CredRoutes::test_credential_exchange_issue

... raises this error.  I'm not sure the cause (it's raised during a "mock" call) but I suggest we focus on getting the demo working (see my comments about the credential proposal format), and once we confirm the demo is working properly we can revisit the tests.

@ianco do we care that we don't have codecov? should we worry if we actually covered all the new stuff?

Personally I'm not too concerned about the level of code coverage as long as we have good integration tests. However we do need a minimal set of unit tests to confirm that the code works.

mmm yeah usually I am lazy and start by looking at the codecov report, to make sure those unit tests are added.  @supersonicwisd1 do you want to try to just add some tests, or maybe run a quick local codecov and see where we are at - we need to make sure new code has tests

We did pass the integration tests which run alice-faber so we should be close now...just need the real presentation format maybe

There aren't any integration tests for the new VC_DI format tho ...

As currently structured, this strictly supports only AnonCreds format, right? In the future, what will be required to add support for issuing, say, DIP-VC or JWT-VC? Is there anything we can or should do now to make that easier for us later?

Keeping in mind that this initial work is being done under a Code With Us (https://marketplace.digital.gov.bc.ca/opportunities/code-with-us/7afcbd7c-2bbc-41ed-bf27-b6ba6e2903c5) we need to be mindful of scope creep.  @swcurran  what do you think?  My preference would be to keep the initial use case as simple as possible.

As currently structured, this strictly supports only AnonCreds format, right? In the future, what will be required to add support for issuing, say, DIP-VC or JWT-VC? Is there anything we can or should do now to make that easier for us later?

Keeping in mind that this initial work is being done under a Code With Us (https://marketplace.digital.gov.bc.ca/opportunities/code-with-us/7afcbd7c-2bbc-41ed-bf27-b6ba6e2903c5) we need to be mindful of scope creep. @swcurran what do you think? My preference would be to keep the initial use case as simple as possible.

We're more than happy to structure for future extensibility, not concerned with scope creep if we can possibly complete after the formal approvals (once we get to there!)
do you guys have specific suggestions about structuring this for extensibility?

Agree that we will need future extensibility with this, so if there are some things that are obvious and easy, let’s do them. But highest priority is delivery the AnonCreds in W3C VCDM, so that’s the current focus.  I can’t answer Golda’s question about specifics to do, but if others have suggestions, please add them.  Thanks!!!

I should add that the goal would be to transition from the existing 0592 and 0593 Credential Attachment RFCs for both legacy AnonCreds and JSON-LD VCs (and 0771 AnonCreds) to the VC-DI attachments.  It will take some time, but that is the goal.

, DIP-VC or JWT-VC

hey @dbluhm we are definitely interested in this after we get the first stage working, if we can plan a sync to understand your thoughts on it.  @tra371 @clehner

@gvelez17 I was hoping you might have recommendations for where the right points in the implementation would be to extend later to support other credential formats and signature types.

@gvelez17 I was hoping you might have recommendations for where the right points in the implementation would be to extend later to support other credential formats and signature types.

hey Daniel is this still relevent based on the conversation in Anoncreds working group today that V2 will always default to a W3C compliant format?  Are we moving more towards a consensus format rather than ability to plug in many?  Happy to still look at this however will give some suggestions

@gvelez17 I was hoping you might have recommendations for where the right points in the implementation would be to extend later to support other credential formats and signature types.

hey Daniel is this still relevent based on the conversation in Anoncreds working group today that V2 will always default to a W3C compliant format? Are we moving more towards a consensus format rather than ability to plug in many? Happy to still look at this however will give some suggestions

Yes; the VCDI credential attachment format is explicitly capable of issuing credentials with multiple cryptosuites, of which, AnonCreds is just one variety. We will want to be able to support signing credentials with other cryptosuites besides just AnonCreds.

New PR:
https://github.com/hyperledger/aries-cloudagent-python/pull/2861

Closed in favor of https://github.com/hyperledger/aries-cloudagent-python/pull/2861


Refactor tracking bug

@itchix has started a complete refactor of the app based on https://github.com/MindorksOpenSource/android-mvp-architecture

https://github.com/itchix/TestMVPAndroid

@itchix Even though the refactor didn't go through, is there a way you can backport the chart to the main app ?


URL of any link in section "Repository" includes port 3030

Description
Hello,
when I click a link in section "Repository" the URL includes port 3030.
This URL will result in a 404.
If I use the link in section "main screen" the URL is correct.
I have attached screenshots that document

link in section "Repository"
link in section "main screen"
WebUI showing 404 error

Can you advise how to fix the links in section "Repository"?
THX
Screenshots

Gitea Version
Gitea version 1.16.8 built with GNU Make 4.1, go1.18.2 : bindata, sqlite, sqlite_unlock_notify
Can you reproduce the bug on the Gitea demo site?
No
Operating System
Ubuntu 20.04.4 LTS
Browser Version
Chrome Version 102.0.5005.63

Maybe related to this one

https://github.com/go-gitea/gitea/issues/19345

Correct your ROOT_URL related settings in your app.ini


MainService's foreground notification doesn't start up automatically

It seems that, when the MainService connects automatically (while MainActivity isn't showing), it successfully starts up the apps and they connect, but the foreground notification doesn't start up. It seems that (especially if the NotificationListener isn't running) this causes Android to kill the app after a few minutes, while leaving other BMW apps still running.

Turns out it was because I set the app to have Background Restriction. It seems that Android won't let the Foreground Notification happen even with background-disabled apps.


New API available for EventKit

https://developer.apple.com/documentation/technotes/tn3152-migrating-to-the-latest-calendar-access-levels
In IOS 17, a new API is used for calendar Event store access.  Code needs to add in logic to detect that in CalendarViewController.  The new API call is eventStore.requestFullAccessToEvents.  You will also need to add in a new reference in the plist for full access.  Privacy - Calendar Full Access Usage Description
private func requestAccessToCalendar() {
    do {

        if #available(iOS 17.0, *) {
            eventStore.requestFullAccessToEvents { [weak self] granted, error in
                DispatchQueue.main.async {
                    guard let self else { return }
                    self.initializeStore()
                    self.subscribeToNotifications()
                    self.reloadData()
                }
        }

        } else {

            eventStore.requestAccess(to: .event) { [weak self] granted, error in
                // Handle the response to the request.
                DispatchQueue.main.async {
                    guard let self else { return }
                    self.initializeStore()
                    self.subscribeToNotifications()
                    self.reloadData()
                }
            }
        }
    }
}

Would you be able to create a pull request to fix this issue? Both, the code side as well as changing the Info.plist string key? Thanks.

Sorry for the delay.  But glad you got it in there.


Outdated information | Composite models on Power BI datasets

Hi there,
https://learn.microsoft.com/en-us/power-bi/transform-model/desktop-storage-mode#considerations-and-limitations
This part of the page is possibly outdated since with the GA of Composite models on Power BI datasets and Azure Analysis Services using a composite model, one can combine the data in Power BI datasets with other DirectQuery and imported data.
At least I have the impression that it is outdated.
Thank you.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7d807f76-0284-c917-4e56-b5c897c9ed61
Version Independent ID: e837a12c-fa26-ea56-cfb3-46ac87a1843c
Content: Use storage mode in Power BI Desktop - Power BI
Content Source: powerbi-docs/transform-model/desktop-storage-mode.md
Service: powerbi
Sub-service: pbi-transform-model
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Good point, thanks for bringing that to our attention. I'll update that section based on updated functionality. Much appreciated!


First try at Cython

Most of the time creme is slower than sklearn. This is mostly due to the fact that sklearn can vectorize code because all the data is available in memory at once. There might be some low hanging fruits that we can optimize using Cython instead of pure Python. A good start might be "cythonize" some of the optimizers in the optim module and see if there is a noticeable gain.

Done! Mean, Var, and the loss functions are now written in Cython.


Remove Headers::Mixin

Deprecate [] and []= delegators on Request/Response objects
Remove Headers::Mixin

Although res["Content-Type"] looks nice, it's also a bit confusing.

/cc @httprb/core


Help: integrate open RMF with 2 robots

Hi @Yadunund, I'm trying to connect a robot simulation with rmf_core using a custom fleet_adapter. It can do this command ros2 run rmf_demos_tasks dispatch_loop -s p0 -f p1 --use_sim_time
I'm trying to add a new robot to fleet_adapter. I update config.yaml, nav_graph.yaml. but I'm not sure what need to do more or what am I missing. I have an issue with the second robot is called the position of the first robot.

This is a real position.

This question is far too general and lacking details on technical implementations. So without seeing your code, I can't offer much help as it is not a problem with this template but rather your setup. In particular I would need to see how you implemented the "fleet manager" that communicates with robots in simulation and provides endpoints for your adapter to query.
I'm also assuming when you say "robot simulation", are you referring to one of the rmf_demos where robots are powered using the slotcar plugin.
But as of recently, all our robots in rmf_demos are controlled by a fleet adapter that was implemented using this template. We have an rmf_demos_fleet_manager which the adapter communicates to. So what you're trying to do is already achieved in the rmf_demos repository. Take a look at the documentation here for more information.

Thank you for your  answer.


[Update] Firebase v6.5.0

This PR includes the following updates:

Firebase Core v6.1.0
Firebase Instance ID v4.2.1
Firebase Analytics v6.0.4
Firebase AdMob v7.47.0
Firebase Dynamic Links v4.0.1
Firebase Cloud Messaging v4.1.1
Firebase Auth v6.2.1
Firebase Cloud Firestore v1.4.2
Firebase Database v6.0.0
Firebase Invites is now deprecated
Firebase Storage v3.4.0
Firebase A/B Testing v3.0.0
Firebase Remote Config v4.2.1
Firebase Performance Monitoring v3.1.1

Closing in favor of #308


29427 models to sql

This branch name is now out of date - this branch doesn't attempt to convert django model data to an example SQL output.
Instead, this branch is an update to the underlying Django models which facilitate the many:many relationships between source table:field pairs and OMOP table:fields.
The rationale for the relationship of many:many is;

Each table:field pair in a source data set can potentially be associated with multiple fields in OMOP
Each unique pair of OMOP tables:fields can be associated with many different source table:field pairs

I thought many:many might be a useful structure for in the future. For example, we may want to go back and check where each OMOP field has been mapped (back to the original source data) for integrity checks. I don't think this would be possible if we had a 1:many relationship between the source table and the mapping table. Would be happy to discuss ideas if you like.
Example data can be loaded into a test SQLite db. Instructions on how to do this can be found in the ReadMe.

@py5gol Addressed all your changes in your review.

@py5gol Addressed all your changes in your review.


fix: Improve warnings in case of cache errors

Closing this as I accidentially already merged the changes to main.


feature: support dynamic subitems

With this PR we should be able to provide an array of submenu options dynamically, like so:
children: $q(function (resolve) {
    resolve(
        function ($itemScope) {
            return service.prepareSubItems($itemScope, jumpOptions);
        }
    );
})

Thank you for your contribution, @zoladkow!


Fixing configuration docs and history verification error messages

Codecov Report
Patch coverage: 54.16% and project coverage change: -0.07% :warning:

Comparison is base (be1055e) 87.73% compared to head (c43d1f3) 87.67%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
- Coverage   87.73%   87.67%   -0.07%
==========================================
  Files          39       39
  Lines        8771     8785      +14
==========================================
+ Hits         7695     7702       +7
- Misses       1076     1083       +7

Files Changed
Coverage Δ

akd/src/directory.rs
83.42% <ø> (+0.14%)
:arrow_up:

akd_core/src/configuration/experimental.rs
98.98% <ø> (ø)

akd_core/src/configuration/whatsapp_v1.rs
99.09% <ø> (ø)

akd_core/src/verify/history.rs
87.01% <54.16%> (-4.42%)
:arrow_down:

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Hack-together] feat: levate User Experience with 3D Street View for Property Listings

Are you accessing the project from the GitHub Codespaces?

[✅] Yes, I am using GitHub Codespaces.

Note: The project is optimized to run on Codespaces. We welcome contributions to enhance it for cross-platform local development, but it's not something we will prioritize right now. Thank you!

Feature description

✅ 3D Street View for Property Listings
Incorporating an interactive 3D street view into property listings will provide users with a realistic and immersive understanding of the properties in their real-life context.
This addition is particularly beneficial for users who prioritize their potential neighborhoods and environment before making significant commitments like moving.
✅ Feature Benefits to user
⭕ Users can explore the property's environment from the comfort of their homes, enabling informed decision-making without the need for physical visits.
⭕ The feature enhances users' confidence in their choices by offering a more authentic and tangible experience.
⭕ It saves users time and resources that would otherwise be spent traveling to the property location.
All these together will make Contoso Real Estate user's go-to whenever moving💫.
✅ Feature Details
To illustrate the implementation of this feature, consider the following scenario:
When users access a property listing they are interested in, they will have the option to interact with an embedded 3D street view of the apartment's surroundings.
This interactive experience allows users to virtually navigate around the property's neighborhood, simulating the experience of being there in person.
✅ sample tour of this feature
For demonstration purposes, an example of the proposed feature can be seen by playing this video (or following this link):
https://github.com/Azure-Samples/contoso-real-estate/assets/135356007/022c0c0a-c44c-491c-876f-cbe468d9ce38
To get the full demonstration; here is an AdobeXD link:
https://xd.adobe.com/view/a3174e9d-4262-437f-acec-f834e9d43ed5-f644/?fullscreen
✅Additional Input:
I'm open to suggestions regarding CSS design and any technical improvements that can further enhance the implementation. Your insights will greatly contribute to creating a seamless and user-friendly experience.
Plus I like learning new stuff🙂🙂
Screenshots
Here are screenshots demonstrating the feature in action

OS (please complete the following information):

OS: Windows 11 Home Single Language
OS Version:22H2
npm version: (codespaces)
Node.js version: (codespaces)
output of azd version: (codespaces)

Hi @VictorCodebase ! As with the video player suggestion, it is a great feature but out of scope for compliance, for the moment. Thank you for your amazing creativity and in-depth demos!


Dockerfile | copy only necessary files for Rust to compile the application

When compiling the Rust application via the Dockerfile it is done so by:
COPY . .

RUN cargo build --release --features server \
    && dx build --release --features web

This works but if package.json for example is modified, which is not ignored in .dockerignore due to tailwind dependency, it will result in the Rust application recompiling. This is because Docker's caching system interprets that package as necessary for the compilation of the Rust application because it is included in the COPY . . statement.
Instead this copy statement needs to copy only the necessary files to build the Rust application, the following should work but unfortunately it doesn't
COPY Dioxus.toml .cargo assets src ./

RUN dx build --release --features web \
    && cargo build --release --features server

When attempting to run the build process an error will then be thrown:
 > [rust_stage 7/7] RUN cargo build --release --features server     && dx build --release --features web:
0.244 error: none of the selected packages contains these features: server

This indicates there is some form of copying issue present when specifying the exact files.
While resolving this is not urgent, it is useful in order to follow best practices to prevent unnecessary rebuilds of the Rust application which can be time consuming.

Needs to be resolved sooner rather than later otherwise Docker Build Cloud will waste build minutes rebuilding the Rust application for something as simple as a modification to .dockerignore

This has been resolved, the proper solution is to copy each directory separately like this:
COPY Dioxus.toml ./
COPY .cargo ./.cargo
COPY assets ./assets
COPY src ./src

RUN dx build --release --features web \
    && cargo build --release --features server


chore(get_current_session): Return default session if current is explicitly None

From https://github.com/posit-dev/py-shiny/pull/1084#issuecomment-1915683032

@wch should we merge this?

Yes, good idea, thanks!


Not supported long file names.

It's hard to see what are file names if they are to long to fit in sidebar.

Can you provide me an example?

@deadlyjack i think he's referring to this one, I'm having similar issue too.
Maybe scrollable sidebar or title might be helpful


fix: reloadButton refreshes all data in the store

Pull Request Test Coverage Report for Build 75

10 of 17 (58.82%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 83.425%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/reducers/lists/index.js
0
1
0.0%

src/components/main-app/index.js
0
1
0.0%

src/reducers/boards/index.js
0
1
0.0%

src/components/main-app/component.js
4
8
50.0%

Totals

Change from base Build 61:
-0.5%

Covered Lines:
438

Relevant Lines:
517

💛  - Coveralls


Maya integration cleanup

After moving Maya integration to OP it would be nice to clean up the code and unify the behavior of menu functions and give the user more feedback
Reset Resolution is correctly informing the user about performed action in script editor
# openpype.hosts.maya.api.lib : Setting scene resolution to: 1920 x 1080 #
but other two (Reset Frame Range and Set Colorspace) are silent and there is no feedback given if operation is successful.
It can help the user to diagnose potential issues in production (wrong shot range entered in Ftrack, etc.)
[cuID:OP-2604]

This is very loosely related to #1306 - so just dropping this here for future reference.


[Chef-16] Replace deprecated macos-10.15 instances with macos-11

Signed-off-by: Neha Pansare<EMAIL_ADDRESS>
Github actions has deprecated macos10.15 and is going to completely remove it on Dec22, so replace it with macos11, for which we have been getting warning in builds.
Refer https://github.com/actions/runner-images/issues/5583
Description

Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] All commits have been signed-off for the Developer Certificate of Origin.

We have working builds for macos12, so merging the pr


Add supported Docker image for install

Support a standard downloadable docker image as an install option.
Interface
Each release should automatically include a versioned docker image download from the install page. Consider uploading to Docker Hub as well.
Implementation
Currently all packages are built from the tasks/dist.js grunt file, and distributed as best as I'm able on build runners in .travis.yml. Each type of artifact is also tested (e.g. through the test:deb grunt task) and uploaded to S3 automatically if it's placed in the dist directory during a build.
Acceptance Criteria
We'd need a new build job to create and test the docker image, running all functional tests against mountebank running from the image.
Prior Art
Look at https://hub.docker.com/u/andyrbell/

Already a lot of docker images on github


rnd-name: init at 1.0.0

Description of changes
Added the rnd-name package
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thanks for catching the typo!
We've been using it for years internally. I looked for something similar in nixpkgs but couldn't find anything. So I decided to submit this PR.

what about rust-petname?


Implement custom settings through env params for NAV and Clients

This addition allows to set customNavSettings, customWinSettings and customWebSettings to set arbitray config settings for the NAV server instance, ClickOnce Windows Client and WebClient. The format is:
<variablename>="<key1>=<value1>,<key2>=<value2>"
e.g.
customNavSettings="EnableDebbuging=true,ReportPDFFontEmbedding=false"
In cases where the config setting doesn't exist, the script creates it. Setting or creating a config value is also shown in the log
Tested with 2017-cu5-de and 2018-rtm-de

SetupClickOnce exists in all version folders, you have only modified the one in 100.
Today they are identical, but some at least the prereqs are different for some of the older versions (which is the reason for copying them out)
The Web Configuration should be done in SetupWebClient (which also is in the version folders) - SetupWebConfiguration should be left empty for override purposes.

Yes, I wanted to get your feedback before copying to all folders.
SetupWebClient vs. SetupWebConfiguration: As it is the same in all releases I thought it might make sense to put it in the central one instead of copying. But I'll move it. 2017 is the only release where we need to support web.config and navsettings.json, right? 2013 to 2016 is web.config only and 2018 navsettings.json only?

Thanks
2017 is only web.config
2018 is only navsettings.json
There were some preview builds in between with both, but we are not going to rebuild those.

ok, moved the parts around

Merged, thanks Tobias

What would be the format to pass these customsettings via the additionalParameters?
New-CSideDevContainer -additionalParameters @("-e customNavSettings=ApiServicesEnabled=true")

Use new-navcontainer instead of new-csidedevcontainer.
New-csidedevcontainer is only there not to break people who has used that, you can see in the implementation that new-csidedevcontainer just calls new-navcontainer https://github.com/Microsoft/navcontainerhelper/blob/master/ContainerHandling/New-CSideDevContainer.ps1