AddressType of Listener in Gateway to represent IPv4, IPv6, dual stack and named address

AddressType specifies the type of address for Listeners associated with a Gateway. Discuss what types should be defined to represent cases of IPv4, IPv6, dual stack and named address.

IPv4Address - represents an IPv4 Address
IPv6Address - represents an IPv6 Address

Reference: EndpointSlice AddressType field

NamedAddress

Use case: Static IP address
Example: Ingress GCE
Annotation kubernetes.io/ingress.global-static-ip-name
If a permanent IP address is wanted that stays the same across deleting Ingress and creating a new one, a static IP address must be reserved. Such a static IP address is reserved for a customer’s project until they decide to release it. A name is specified to call this address. Then in the Ingress manifest, the annotation “kubernetes.io/ingress.global-static-ip-name” is included that gives the name of the reserved static IP address.

Is NamedAddress in this sense an arbitrary string identifying an infrastructure resource, or is it a DNS FQDN?

The former - an arbitrary string identifying an infrastructure resource

I think this has actually been resolved now. We have both NamedAddress and IPAddress as types. I don't think we have any reason to differentiate between IPv4 and IPv6 addresses. Feel free to reopen if I missed anything though.
/close


RK4

In GitLab by @nmansard on Jan 20, 2019, 10:49
I would like that we reintroduce the RK4 in the refact branch, and compare it with impl-eul. This means defining a new IntegratedActionModel, based on the impl-eul class.
We should have one DifferentialActionData (DAD) per integration point (each time you call a DAM.calc, it should be on a different DAD).
The calc function should just be a copy paste of the devel branch.
The calcDiff can be discussed. Basically, the idea is to call the DAM.calcDiff on every integration point, and then make the same operation on the calcDiff matrices that were done on the calc vectors.
Let's not think of RK45 (variable-time integration) yet.

In GitLab by @proyan on Jan 21, 2019, 12:36
assigned to @rbudhira

In GitLab by @proyan on Jan 21, 2019, 13:13
unassigned @rbudhira

In GitLab by @nmansard on Jan 21, 2019, 15:34
assigned to @rbudhira

In GitLab by @proyan on Jan 22, 2019, 14:30
mentioned in merge request !57

In GitLab by @proyan on Jan 24, 2019, 20:16
TODO:
Apparently, my last message here has been lost.
Obviously the method does not pass the numdiff test. So either we consider the method incorrect, or the test incorrect. But the method should be tested with a DiffActionModelLQR on vector state space with a(x,u) = Ax*Bu, before we can really decide.
In case we consider the method incorrect: it should be investigated with a simpler test case, I suggest to try RK2 with 1st order system.
In case we consider the test to be incorrect: we can try the RK4 model instead of ImplEuler model in a DDP, and check that RK4 does produce no more DDP iterations that ImplEul.
Should we copy this last comment to issue #55 and close this MR until somebody has time to investigate this?

In GitLab by @proyan on Jan 27, 2019, 21:28
mentioned in merge request !67

In GitLab by @nmansard on Jan 30, 2019, 17:38
solved by !67

In GitLab by @nmansard on Jan 30, 2019, 17:38
closed


Document Staging instance usage with Keyless

Signed-off-by: Kenny Leung<EMAIL_ADDRESS>
Summary

This is to document how to use the staging Sigstore instance with keyless signing.
@haydentherapper @priyawadhwa PTAL
Ticket Link

Fixes
Release Note

Codecov Report

Merging #1824 (fca3d6c) into main (e74f180) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1824      +/-   ##
==========================================
- Coverage   33.02%   32.99%   -0.04%
==========================================
  Files         147      147
  Lines        9347     9347
==========================================
- Hits         3087     3084       -3
- Misses       5906     5908       +2
- Partials      354      355       +1

Impacted Files
Coverage Δ

pkg/cosign/tuf/client.go
61.68% <0.00%> (-0.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e74f180...fca3d6c. Read the comment docs.


change branch name: master -> main

GitHub and Git have changed dedault branch name from master to main.
I want to do so in order to go ahead.

I have changed the default branch!!
Issueたててすぐデフォルトのブランチをmainに変更したので、閉じます。


[Research / Analysis] Automatic cluster label assignment

As of now we have been manually inspecting and labeling clusters through subjective evaluation of what the most significant themes are within each cluster while looking at the tweets text.
Open question
Optimally this can be done automatically after clustering. Solving this along with #3 will allow for a fully automated pipeline from search & sampling to visualization.
Some possible techniques:
a) Term frequency analysis of the top-k nearest neighbors to the cluster and sub-cluster centers. The top n non-stopword terms could be put together to form a label.
b) Topic modeling via Latent Dirichlet Allocation (LDA) or Latent Semantic Analysis (LSA) (gensim has APIs for this in python)
c) Assemble a "document" by concatenating the top-k nearest neighbors to the cluster and sub-cluster center and then use deep learning methods (transformers) to create a summary of the "document" to act as the label. Here is a recent neural text summarization model: Text Summarization with Pretrained Encoders

Addressed in c98d87d303852f766a6b629061d103fbea77b0fa.
Implemented option (c) from above: we assemble "documents" by concatenating the top-k nearest neighbors to the cluster & subcluster centers. These documents are fed to a huggingface implementation of DistilBART (sshleifer/distilbart-xsum-12-6) for summarization.


fix for bug #4593

Hi Developers,
http://dev.opennebula.org/issues/4593
When VM in UNKNOWN state is rescheduled it can not be migrated anymore because a check in VirtualMachineMigrate::request_execute is not satisfied due to previous history record not closed properly.
https://github.com/OpenNebula/one/blob/master/src/rm/RequestManagerVirtualMachine.cc#L1097
The suggested patch updates(closes) previous history record properly (I hope) and the VM is in proper state then.
Kind Regards,
Anton Todorov

Needs to handle the other PROLOG_MIGRATE states and failure.

Hi Anton,
After reviewing this, I've decided to move your changes to the action. This case is slightly different to the others as the capacity is decremented before issuing the prolog. So I prefer to treat the history record in a similar way to a POWEROFF/SUSPEND migration, where the actual registry is closed. All changes are now in master if you want to give them a try, but I basically moved the update from the callback to the trigger.
THANKS!


[Ghost tables] Feature flag event trigger creation

Include the new event trigger creation for the user database inside the ghost_tables_trigger feature flag in order to avoid users have it created until we want it

[ ] new user: if the user has the ghost_table_trigger FF, install the event trigger
[ ] install event trigger rake: a rake that receives a usernames list. For each user adds the FF and creates the event trigger (only if is an org admin or regular user)
[ ] uninstall event trigger rake: a rake that receives a usernames list. For each user removes the FF and drops the event trigger

After talking offline, the idea will be adding a FF to disable the trigger creation. Changing the main comment to reflect it.


CLOUD-680 added cluster checks

@biharitomi

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1104/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1106/


Fix JDK install on CI

https://github.com/exercism/java/commit/447027d79039cdbd12228496b4810dbb4660eda3#diff-354f30a63fb0907d4ad57269548329e3
https://travis-ci.community/t/error-installing-oraclejdk8-expected-feature-release-number-in-range-of-9-to-14-but-got-8/3766/5

Can be closed if the approach in #318 is preferred.

Closing in favor of #323


help: bot command to list help

show help info as specified/configured/given in tiny-matrix-bot.cfg config file
usually this lists a list of available bot commands
see also example config file

sorry, opened by accident. Please ignore.


Specification is not clear about metadata before enums

The Dart Programming Language Speciﬁcation version 1.9 is not clear about metadata for enums.
Chapter '13 Enums' reads:

An enumerated type, or enum, is used to represent a ﬁxed number of constant values.
enumType:
metadata enum id ‘{’ id [‘, ’ id]* [‘, ’] ‘}’
;

Metadata is allowed. But chapter '15 Metadata' reads:

Metadata can appear before a library, part header, class, typedef, type pa-
rameter, constructor, factory, function, ﬁeld, parameter, or variable declaration
and before an import, export or part directive.

Enums are not mentioned here, i.e. not allowed for enums.
So it is not clear whether metadata can appear before enum or not.

No milestone now: Said correction should be performed (add enums in ch. 15), but this does not block Dart 2.

Noted that this had been reported already in https://github.com/dart-lang/sdk/issues/22311. Closing this issue as a duplicate of that one.


async arrow functions not defining _this

Bug report

What is the current behavior?
async nameOfFunc() {
  this.doStuff();
}

is transpiled to
nameOfFunc() {
  var _this = this;

  return (0,node_modules_babel_runtime_helpers_esm_asyncToGenerator_js__WEBPACK_IMPORTED_MODULE_0__["default"])(function* () {
    _this.doStuff();
  }
}

nameOfFunc = async () => {
  this.doStuff();
}

is transpiled to
nameOfFunc = (0,node_modules_babel_runtime_helpers_esm_asyncToGenerator_js__WEBPACK_IMPORTED_MODULE_0__["default"])(function* () {
    _this.doStuff();
}

nameOfFunc = () => {
  this.doStuff();
}

is transpiled to
nameOfFunc = () => {
  this.doStuff();
}

If the current behavior is a bug, please provide the steps to reproduce.
I believe the current behavior is a bug, as shown above by simple switching from an async function to an async arrow function the _this is no longer created.

What is the expected behavior?
I would expect that no matter how i create the async function that the _this exists if needed. Without it my arrow function will fail.

Other relevant information:
webpack version:  5.73
Node.js version:  16.13.2
Operating System: Windows 10
Additional tools: Angular 14/14.1, Babel 7.17, Typescript 4.7

https://github.com/babel/babel/issues/14749
the folks over at babel think it is related to them, so we might be able to close this instead, but i wasn't sure. sorry... sort of a shotgun approach here


Support Decimal128/Decimal256 in Arrow parser (23.2)

b24f71e64f22e615ebb32f33fb2cfc5c88198c1a
Pull Request resolved: https://github.com/ytsaurus/ytsaurus/pull/769
Co-authored-by: nadya02<EMAIL_ADDRESS>

Shipped!


Move monitored resource detection utils to a separate artifact.

Closes https://github.com/census-instrumentation/opencensus-java/issues/1130.

Codecov Report

Merging #1135 into master will increase coverage by 0.02%.
The diff coverage is 65.33%.

@@             Coverage Diff             @@
##             master   #1135      +/-   ##
===========================================
+ Coverage     82.48%   82.5%   +0.02%
- Complexity     1211    1222      +11
===========================================
  Files           187     191       +4
  Lines          5767    5774       +7
  Branches        523     524       +1
===========================================
+ Hits           4757    4764       +7
  Misses          878     878
  Partials        132     132

Impacted Files
Coverage Δ
Complexity Δ

...ib/monitoredresource/util/AwsIdentityDocUtils.java
54.9% <ø> (ø)
6 <0> (?)

...ensus/contrib/monitoredresource/util/Resource.java
100% <100%> (ø)
2 <2> (?)

...s/contrib/monitoredresource/util/ResourceType.java
100% <100%> (ø)
3 <3> (?)

...ensus/contrib/monitoredresource/util/LabelKey.java
100% <100%> (ø)
3 <3> (?)

...rter/stats/stackdriver/StackdriverExportUtils.java
94.63% <100%> (+10.59%)
26 <2> (-3)
:arrow_down:

.../monitoredresource/util/MonitoredResourceUtil.java
42.22% <42.22%> (ø)
6 <6> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e518c6...427d98b. Read the comment docs.

Why do we need to split out the monitored resource detection into a separate artifact?  Where will the new artifact be used, outside of the Stackdriver stats exporter?  It would help to add an explanation to the commit message.

We plan to reuse the resource detection utils in Stackdriver Trace. I added some comments in the PR description, will add that to the commit message when I squash commits and merge.

Thanks for review!


[test]: random execution of unit tests while using multiple stub components in same spec

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [x] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions
NodeJS: v10.13.0
npm: 6.4.1
Angular CLI:
Angular CLI: 7.0.6
Node: 10.13.0
OS: darwin x64
Angular: 7.0.4
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.10.6
@angular-devkit/build-angular     0.10.6
@angular-devkit/build-optimizer   0.10.6
@angular-devkit/build-webpack     0.10.6
@angular-devkit/core              7.0.6
@angular-devkit/schematics        7.0.6
@angular/cli                      7.0.6
@ngtools/webpack                  7.0.6
@schematics/angular               7.0.6
@schematics/update                0.10.6
rxjs                              6.3.3
typescript                        3.1.6
webpack                           4.19.1

Repro steps
I discovered random behavior in unit testing components using ng test command. While using multiple stub components in same .spec.ts file those get executed randomly and not producing desired results. I created sample here. Reproduce steps:
git clone https://github.com/jkuri/abstruse.git -b v2.0.0
cd abstruse
npm install
ng test

Note that tests are sometimes executed correctly.
The log given by the failure
It's karma or Jasmine output about failing tests because wrong expectation of values.
Desired functionality
Tests should get executed in the way stub components are not affecting one another.
Mention any other details that might be useful
https://github.com/jkuri/abstruse/tree/v2.0.0

If you use the karma-jasmine, you can set the random is false. like this:
module.exports = function(config) {   config.set({     client: {       jasmine: {         random: false,       }     }   }) }
The jasmine changed the default set in the v3.x

@jkuri I don't quite follow why you think this is a bug in Angular CLI. It sounds like it's mostly a Jasmine or Karma thing.

@filipesilva I got a feeling it is related to cli compilation procedure or even more, it's @angular-devkit/build-angular/plugins/karma issue. Maybe I did not explained the problem very well, but for example, sometimes I get values from that stub component in this stub component. This causes tests failing sometimes randomly, but sometimes are passing just fine.

I don't really see how the compilation would affect the runtime behaviour of your test stubs. If you can come up with a simple repro maybe we can investigate further but with the information available I don't think it's a CLI issue.

@jkuri Are you sure all of your assertions are being reached? Your component under test uses an external template and stylesheet with input bindings that trigger ngOnChanges and update the view, so there's a lot of change detection/asynchronous stuff going on that could cause leaks in your tests.
See one possible explanation with a similar test setup here.
To troubleshoot you could try logging test A begin, test A stable, test B begin, test B stable, ... for each test and analyze any ungrouped outputs whenever the unexpected behavior occurs.  It's possible that a fixture could fail to compile or never become stable, so you may also want to add catch to each compileComponents() and whenStable() and then fail() if so.
Or just don't depend on whenStable() (which is ironically unpredictable in my experience) and use Jasmine's done callbacks or another solution.

Closing as inactive.


ReferenceError: ogComplete is not defined

Looks like ogComplete has not been declared before use here. Also might be a hint that we are not testing the streaming anywhere.
https://github.com/ryansolid/dom-expressions/blob/a85d688353fef165b0456d5e192f4359dc00d5cb/packages/dom-expressions/src/server.js#L201C14-L201C14

This only impacts the render async flow. But yeah it wouldn't crash (outside of strict mode) but it would pollute the global namespace.


Fix filename casing in CMakeLists.txt

These typos broke the bootstrap build in NixOS packaging of the Swift 5.8 release, so hoping these fixes can land in a potential 5.8.1.
It looks like main and release/5.9 are already fixed.

@swift-ci smoke test

thanks @stephank


Selectively remove DebugDeclare in ssa-rewrite

ssa-rewrite should remove DebugDeclare only when it is replaced by
DebugValue instructions for every store and phi instruction.

I missed this case in #3356.
Basically, the existing ssa-rewrite pass removes all DebugDeclare even when it should not.
If some DebugDeclare instructions are not propagated as DebugValue for store and phi instructions, we must not remove them.
For example,
 #version 140

 in vec4 BC;
 out float fo;

 void main()
 {
     float f = 0.0;
     for (int j=0; j<4; j++) {
       // BB_inside
       int &i = j;
       f = f + BC[i];
     }
     fo = f;
 }

 %f = OpVariable %_ptr_Function_float Function
 %j = OpVariable %_ptr_Function_int Function
 OpStore %f %float_0
 OpStore %j %int_0
 %decl0 = OpExtInst %void %ext DebugDeclare %dbg_f %f %null_expr
 %decl1 = OpExtInst %void %ext DebugDeclare %dbg_i %j %null_expr   ; %dbg_i == "int &i"

If we use %j for int &i in BB_inside, we must not add a DebugValue for the j++.
In this case, we must not remove %decl1 = OpExtInst %void %ext DebugDeclare %dbg_i %j %null_expr   ; %dbg_i == "int &i".

I cannot remember if we have talked about this or not.  This does not look right.  Replacing a debug declare should always be an all or nothing.  You can either replace the debug declare with a series of debug value instructions, or you do not add any debug value instructions.
More over, if ssa rewrite is able to rewrite the variable, then it should always be able to replace the debug declare with debug value instructions.  So the logic should be: "if ssa-rewrite chooses to rewrite the variable, then the DebugDeclare should be removed."  Nothing more complicated should be needed.

@s-perron Thank you for your comment.
Let me clearly understand what the expected behavior is.
Let's assume that

There are variables a, b
We can replace DebugDeclare of a to DebugValue, but we cannot do that for b

In this case, what we should do among the following E1 - E4?

E1: Replace only DebugDeclare of a to DebugValue and remove DebugDeclare of b
E2: Replace only DebugDeclare of a to DebugValue and keep DebugDeclare of b
E3: do not replace any DebugDeclare to DebugValue and just keep both DebugDeclares of a and b
E4: Replace DebugDeclare of a to DebugValue and replace DebugDeclare of b to DebugValue with Deref?

if b is already declared by DebugValue with Deref, do not update the DebugValue for b

E2: Replace only DebugDeclare of a to DebugValue and keep DebugDeclare of b
Sorry that I was not clear.  I was thinking of a single variable at a time, because logic of ssa-rewrite acts on each variable individually.

Thank you for clarifying it. I updated the description of this PR and the code. PTAL.

I agree. Thank you for the suggestion. I updated the code to simply kill DebugDeclares for target variables. PTAL


Allow links to point to the top of the document

This PR enables linking to the top of a document on GitHub and Gitlab.
Both services have an anchor called #readme at the beginning of a rendered markdown document. This is useful for skipping the (potentially long) file list above it and it's heavily used in production (for example by npm init which appends it automatically if your package homepage is a GitHub repo).
BitBucket has no equivalent to this anchor, so this PR implements the feature as an environment-specific configuration.
I'll open this as a draft PR since I need clarification on the tests: I added a link pointing to #readme to each the github.md and the gitlab.md. They work as expected, however I added the same link to bitbucket.md, expecting it to fail, but it passed because it was tested as being in a GitHub environment.
Is there any mechanism in place to simulate BitBucket for tests?

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #48   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          12     12
  Lines         279    285    +6
=====================================
+ Hits          279    285    +6

Impacted Files
Coverage Δ

lib/find/find.js
100% <100%> (ø)
:arrow_up:

lib/find/config.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13a54a5...eb2074e. Read the comment docs.

Hmm, the reason Bitbucket doesn’t warn about #top or #readme and the like (which I think you’re asking, right?), is that Bitbucket uses #markdown-header- as a heading prefix, and we ignore all anchor links that don’t use the heading prefix.
Because GH and GL use # as a heading prefix, in those environments, every anchor fails if it isn’t know. In case of BB, we ignore everything that doesn’t start with #markdown-header- silently.

Ah, alright. 👍
Then this is ready to review I guess. 🙂

Hey @wooorm, just for a bit of planning — when is the next minor release of this package scheduled? Having this thing solved would spare me a couple dozen noisy messages on my lint runs. 🙂

Thanks, released!

Weee, thanks! 😄


conf: temporary disable base-files package in meta-debain

Since meta-debian has base-files recipes, no one provides /etc/nsswitch.conf.
However, systemd requires /etc/nsswitch.conf if use meta-debian's base-files,
building image is failed.
WARNING: core-image-minimal-1.0-r0 do_rootfs: Postinstall for package systemd failed with 2:
sed: can't read /home/masami/emlinux/build/tmp-glibc/work/qemuarm64-emlinux-linux/core-image-minimal/1.0-r0/rootfs/etc/nsswitch.conf: No such file or directory

ERROR: core-image-minimal-1.0-r0 do_rootfs: Postinstall scriptlets of ['systemd'] have failed. If the intention is to defer them to first boot,
then please place them into pkg_postinst_ontarget_${PN} ().
Deferring to first boot via 'exit 1' is no longer supported.

Details of the failure are in /home/masami/emlinux/build/tmp-glibc/work/qemuarm64-emlinux-linux/core-image-minimal/1.0-r0/temp/log.do_rootfs.
ERROR: core-image-minimal-1.0-r0 do_rootfs:
ERROR: core-image-minimal-1.0-r0 do_rootfs: Function failed: do_rootfs
ERROR: Logfile of failure stored in: /home/masami/emlinux/build/tmp-glibc/work/qemuarm64-emlinux-linux/core-image-minimal/1.0-r0/temp/log.do_rootfs.23800
ERROR: Task (/home/masami/emlinux/repos/poky/meta/recipes-core/images/core-image-minimal.bb:do_rootfs) failed with exit code '1'

This patch temporary disables base-files package.

Thanks!


minor: roles/billing.projectManager set twice in bootstrap.sh - safe to remove one

https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/blob/main/environments/bootstrap/bootstrap.sh#L85
The following role is set twice - we can remove one and retest in a truncated bootstrap.sh run
roles/billing.projectManager
ROLES=("roles/billing.projectManager "roles/orgpolicy.policyAdmin" "roles/resourcemanager.folderCreator" "roles/resourcemanager.organizationViewer" "roles/resourcemanager.projectCreator" "roles/billing.projectManager" "roles/billing.viewer")
in
gcloud organizations add-iam-policy-binding $ORGID  --member=user:$USER --role=$i --quiet > /dev/null 1>&1

existing roles on the super admin are
owner, folderAdmin, org admin, org policy admin

20240406: Closing issue during retrofit/rebase of this TEF V1 based/modified repo to TEF V4 standards
This issue may participate in the LZ refactor after rebase
Query on all issues related to the older V1 version via the tag
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/labels/2024-pre-tef-v4


Change login request from POST to GET

Conceptually this makes more sense as a GET request as you are getting a JWT for the front end.  More importantly, popular http libraries like axios will generate the auth header for you easily if you are using a GET.  See my stackoverflow question and answer here  https://stackoverflow.com/questions/62730511/axios-equivalent-of-curl-u-flag

Hi @honkskillet . Thanks for the suggestion.
IMO JWT generation resembles CREATE in the traditional REST definition. Using POST looks more REST-compliant (though I agree it's arguable).
Also, making changes due to one specific frontend library is not something we usually do in this generator.

Looking into it more deeply there are security reasons not to use GET, so POST is correct.  Maybe some beefed up documentation in the readme then?  Most people won't actually be using CURL with this library.
@pedro-victor I can add  some more axios documentation to the readme.  Can you accept pull requests?

Looking into it more deeply there are security reasons not to use GET, so POST is correct. Maybe some beefed up documentation in the readme then? Most people won't actually be using CURL with this library.

I forgot to mention that as well.

@pedro-victor I can add some more axios documentation to the readme. Can you accept pull requests?

I do but since we don't have a lot of documentation apart from what's in README.md this first approach on showcasing frontend libraries might be up to @diegohaz on where to put it.
I'm in favor of having these examples in a webpage/wiki instead of the repo so it could move faster than the PR approval process.
What do you think, @diegohaz ?
I'd love to write about creating microservices from this generator. I have created 50+ microservices from it and this generator is awesome for that use case too.

Wiki sounds nice! I've enabled the wiki section on this repo. I guess anyone can edit, but let me know if you need any additional permission. I'm also curious to learn more about that microservices approach. :)


Add auto-update on hide workflow for Electron on Mac

Details
This change allows the Electron app to auto-update when it has finished downloading the update and it is backgrounded.
Fixed Issues

Fixes #1011.
Tests

Install and run MinIO locally.
Point the publish spec in electron.config.js at the local server.
Publish a new version with the build number set very high (i.e. 1.0.1-999).
Build a new version for local development with a lower build number (i.e. 1.0.1-374). It is important that this is notarized, so you must use npm run desktop-build. This build should also have the publish spec pointed at MinIO.
Run the app.
Verify the app version is 1.0.1-374.
Once the new update has been downloaded, either hide or close the window.
The app may reboot a few times.
Foreground the app and verify that the app version is 1.0.1-999.

Tested On

[ ] Web
[ ] Mobile Web
[X] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

N/A
Mobile Web

N/A
Desktop

Before hiding:

After hiding and waiting ~10 seconds before foregrounding:

iOS

N/A
Android

N/A

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA

Just pinging this again!

Just pinging this again!

I ran into this issue notarizing the desktop app:
Package Summary:

1 package(s) were not uploaded because they had problems:
	/var/folders/0l/2cyzv7b14fx8rs5w8xpvvbyc0000gn/T/9185A388-AB1B-4C7A-9092-E8BF05A0CA7F/com.expensifyreactnative.chat.itmsp - Error Messages:
		The username<EMAIL_ADDRESS>is not a member of the provider . Contact your team admin for assistance. (1296)
2021-02-01 09:16:22.785 altool[10536:83496] *** Error: Unable to notarize app.
2021-02-01 09:16:22.785 altool[10536:83496] *** Error: code 1296 (The username<EMAIL_ADDRESS>is not a member of the provider . Contact your team admin for assistance. (1296))

Did you encounter this issue? Do you know what the problem is/how to resolve the error?

I haven't seen that error before so I'm not 100% sure how to resolve it. My best guess is that you have local certificates installed that are for a member of some team/organization and that your personal account<EMAIL_ADDRESS>is not allowed access to that. If that's the case, my guess would be that switching to your corporate account should let you upload properly.
This issue I found online seems roughly related: https://developer.apple.com/forums/thread/119445

^ real quick on the above: I only tested from a paid developer account, so I'm not sure if that's also a requirement.

Thanks for finding a way to test this and making those documentation updates, but it seems that the only way we can test this is to use a personal paid developer account (we don't want to use our production credentials). So could you please:

Move all the great documentation you have here to a separate README in the desktop directory (there should be no diff on the README in the root).
Make a note in the documentation that in order to test with a notarized build you'll need to have a paid apple developer account.
Post a screen recording of the auto-update happening so we can see that it works for you in real time and not just screenshots?

Thanks!

Updated the README as described and below is a video cast of the experience: https://www.dropbox.com/s/un6xgb4gepibmm6/Screen Recording 2021-02-02 at 6.26.57 PM.mov?dl=0
The flickering on the screen you see right before we re-load it is Big Sur's "verification" of the binary. It is sometimes slow and sometimes this fast.

Hi @nbhargava, do you think it would be possible to have the auto-update happen in the middle of the night (even if the laptop is sleeping), rather than when the app is backgrounded?

Shouldn't be too difficult. What counts as middle of the night? 11pm-3am local time?
Also do you want it to be both middle of the night AND backgrounded or just middle of the night?

Oh sorry, missed the part about the laptop sleeping. If the laptop is sleeping I don't know how we'd be able to resume control to initiate the update. Not sure if that changes things.

Hi @nbhargava, after chatting about this internally a bit, we've decided on a change of plans.
Long-term, I think we're going to create a separate issue to investigate remote-hosting the JS bundle so that electron can auto-update its JS without having to close and reopen at all (like the Slack desktop client).
For this PR, could you please update it so that instead of closing and restarting the app when it's hidden, instead we just provide a custom notification to autoUpdater.checkForUpdatesAndNotify that includes an Update Now button. If the Update Now button in the notification is clicked, then it should close the app, install the update, and restart it (no need to immediately hide the app on relaunch).
Thanks!

I'll take a swing at this and see what I can do. The part that may be tricky is handling the fact that the "install" part of quitAndInstall doesn't seem to always fire reliably.

@roryabraham -- I've uploaded a new version with the requested changes. Here is a screen recording: https://www.dropbox.com/s/n8a04piq2nijhnv/Screen Recording 2021-02-06 at 1.56.26 PM.mov?dl=0

Hi @nbhargava, we'd really prefer if the notification and modal maintain a look-and-feel that's consistent with the rest of our application. So that means:

Please use a browser notification to inform the user that there's an update available and to provide a button to trigger the update. We have a LocalNotification module which ideally could be extended to have a showUpdateNotification function.
Please use a react-native-modal component to display the confirmation dialog. We have a Modal module you can use to start.

The modules I linked above use the ES6 module system, so if you want to use them (which would be ideal), you may have to refactor our Electron configuration to enable the importation of ES6 modules into desktop/main.js. Do you think that's something you'd be up to? I noticed that the Electron v12 beta uses Node 14, and therefore should offer interoperability between CJS and ES6 modules without the use of an external package such as ESM. There is some more info in this GH issue.

Also, for the record @nbhargava has completed the task we initially gave him, and my previous comment constitutes a change in the scope-of-work. Do we have other examples for what we do when we increase the scope-of-work after the fact?  cc @michaelhaxhiu @laurenreidexpensify @puneetlath – have you guys encountered this situation yet?

I think in that case let's just increase the scope of the Upwork job/pay by the same scale as the increase in scope.

+1 to that @puneetlath. Let's provide a bonus for the additional scope if it's agreeable for @nbhargava !

Sounds great -- will take a swing at this and report back when I have an update!

Also to clarify before I dive too deep, is the "upgrade to electron v12 beta" the preferred path you'd have me take on this, or is something else preferable?

Yeah, I think the ideal implementation of this would use our existing modules for LocalNotifications and Modals, but I don't want to see those converted to use CJS. So that means that ideally you can configure desktop/main.js to import and use ES6 modules. I think there are two main ways you could do that:

Using the esm package. (I tried this a while back without success, but it should be possible).
Using Node 13+ (aka upgrade Electron to the beta).

I think I would prefer to just upgrade Electron, but I'll let you dig into it and report back with which option you think will be best. The best source of information I've found on this topic so far is this GH issue.

Hi! I just wanted to chime in with a possible alternative solution that might help solve the issue of importing ES6 modules into desktop/main.js.
Rather than importing code into that file to try and display a modal (and having to also import all of React), I think I would prefer if we just keep all the UI elements as part of the action app (ie. have it all be in the same bundle as /src). Then in desktop/main.js, whenever we need to display the upgrade modal, there should be a way (sorry, I am not familiar with Electron specifically) to just signal the app to display the upgrade modal? Like through some kind of event system, or maybe even with Onyx.

Thanks @tgolen, great point about trying to keep React-specific UI code (i.e: the Modal module) out of Electron's main process.
I think you should be able to use the LocalNotification module in there without using React, though, because it just uses browser notifications, which should be natively supported by Electron.
Check out this example of a function exported from the LocalNotification library. You'll notice that you can provide an onClick callback for a browser notification. Ideally you can use that callback to signal the app to display the upgrade modal as @tgolen has suggested.
Does that make sense? Any questions or concerns?

Definitely on-board for keeping react code out of desktop/main.js. This path forward makes sense. I'll keep poking around on this but may not have an updated PR until this weekend.

After playing around for a while, it seems like Electron 12 still doesn't seem to have ES6 module support fully turned on. I was able to make some progress with 'esm', but we'll see if I run into any more pitfalls.
As part of trying to drive through imports of LocalNotification, I'm running into issues in upstream dependencies. I filed this PR if someone could please take a look! https://github.com/Expensify/expensify-common/pull/334

Why are we still trying to import ES6 modules into that file? The above solution I mentioned was intended to remove the need to do this at all. Specifically, what modules are you importing?

At the time, I was trying to import LocalNotification, but as you mention, it's much cleaner to just use Electron's IPC to get this done.
FWIW, in the future, the esm strategy does work quite well if you do need to end up importing ES6 modules in the future.

This new diff has the updates that pop open a modal when the download is available and then triggers the download when the user interacts with the popover. Below is a video of the interaction:
https://www.dropbox.com/s/6oa7p4qtnms58yr/Screen Recording 2021-02-21 at 4.19.05 PM.mov?dl=0

@nbhargava The video you've provided looks great to me! @AndrewGable, what do you think?
However, I noticed your code has several lint and test failures, so could you please work on resolving those before I dive into a review?

Yup, I realized yesterday that there are some rebase issues due to refactors that happened while I was developing.
Will update later today and re-ping the thread once those are fixed.

Looks great to me, cc @Expensify/design to make sure this is the UI element we'd like.

Are the screenshots on the original comment correct? From my understanding of reading through this, it seems like there should be some kind of Update button but I wasn't seeing one in the screenshots. It also looks like the video link you provided was deleted.

I believe this is the latest video

Got it, @nbhargava can you update the original comment with both the video as well as static screenshots that clearly show the update flow?
In terms of the UI, I think it's great and is the best thing we can do right now before we have some kind of in-app notification/growl/toast component created. We can address that as a separate problem/solution when we start to develop the need for it.

Updated the original comment with the video & a static screenshot of the modal and fixed all the rebase issues
Not sure how to re-run the iOS tests, but from the log output: This is an error with npm itself, so I'm not too sure that I'm newly causing this error?

Updated with your feedback and added a new video/screenshot to the top.

@nbhargava sorry, it seems like the video link is broken.

@nbhargava Any update here?

Sorry, forgot to push! The video is working for me, even in an incognito window. Are you still having issues with it?

propTypes warnings were not fixed :( we should just make them errors

propTypes warnings were not fixed

Idk why I didn't think about this some more (should have held on merging), but it seems like a false warning to me. The prop types were imported from another file then altered, but should actually include onSubmit.


NETOBSERV-779 topology view crashes when layout display changed to Grid

Updated cypress and PF dependencies (including https://github.com/patternfly/patternfly-react/pull/8761)
Fixed cypress tests
Moved to typescript

https://github.com/patternfly/patternfly-react/issues/8659

/ok-to-test

https://github.com/patternfly/patternfly-react/pull/8761

@jpinsonneau Still seeing crashes when changing groups are changed when animation is still running. Changing the layout when the animation is running does not seems to lead to crashes

@jpinsonneau Still seeing crashes when changing groups are changed when animation is still running. Changing the layout when the animation is running does not seems to lead to crashes

@Amoghrd - could you share screen recordings if this is being reproduced conistently? I just ran entire topology test suite  it runs successfully with no crashes (ran multiple times). The tests itself require some modifications for routes URL, I'll create a PR for it.

/approve


PascalVOC XMLs Contain Multiple Distinct Objects, But Want to Train/Detect One Object

I have used LabelImg to create bounding boxes for my objects. Each image has two distinct objects (i.e. classes). I have tried training on both objects. and it seems it works. Now I would like to train ONLY based on one of the objects (single class). Obviously I want to keep my original PascalVOC XML as it is, and just to ignore the other class during training.
I have tried to eliminate having the other class  in 'generate_tfrecord.py' for generating the train.record and test.record files, but I could not! Apparently all classes that are part of the 'train_labels.csv' and 'test_labels.csv' needs to be mentioned explicitly.
The only places I then thought I can exclude the other class was in 'labelmap.pbtxt' and in having ONLY 'num_classes: 1' in 'faster_rcnn_inception_v2_pets.config'! However the training results in weird losses. After 500 Epochs the loss drops from 1.2 to small values around 0.1, then there is a abrupt increase like 543467 in loss, and present in all losses. Again it drops and goes on dropping and then again I will see an increase (quite large and non sense). And this weird behavior doesn't change even after 150K epochs.
The only thing I suspected was the only thing I changed, the number of classes. While all classes being present in PascalVOC XML, record files as well as 'train_labels.csv' and 'test_labels.csv' still contained both classes. I believe this has caused confusion during training and resulted in such weird behavior.
What can I do in this case? Should I go back to LabelImg  and remove the other object bounding boxes and generate the PascalVOC XML again? I hope not, as this seems really not necessary.

Have you just tried to restart from STEP 2c. and delete all the necessary files and recreate it from scratch?

Well, yes and no. I deleted all the necessary files STEP 2c, and did STEP 2e but skipped through the rest including STEP 2d (obviously I have had the installs) and STEP 2f! I wonder now whether STEP 2f needs to be repeated for Protobuf files, which are used by TensorFlow to configure model and training parameters?
I am starting to think maybe it does. Anyone can confirm whether STEP 2f (compile Protobuf files) needs to be repeated whenever changing configs, labels etc.? I need to test it though.
The confusion comes from the fact that the tutorial starts with the example that is given in the this git repo (for Cat and Dog), and it continues explaining how to do it in your own dataset (herein for Cards). But switching from Cat/Dogs to Cards, the tutorial doesn't repeat the STEP 2f, thus I thought it is not needed!


add karmada performance testing process

Signed-off-by: Phil-sun<EMAIL_ADDRESS>What type of PR is this?
/kind documentation
What this PR does / why we need it:
add karmada performance testing process
Special notes for your reviewer:

/lgtm
/cc @RainbowMango

Why put resources under adminstrator?

I think we should organize resources by articles.

/lgtm


docs: formatting and typo fixes to 3.0 migration guide

Some small updates to the 3.0 migration guide

Oh. lets target the release-3.0 branch.

Oh. lets target the release-3.0 branch.

Done


Add an email link to easily share with others

Signed-off-by: David A. Wheeler<EMAIL_ADDRESS>

looks good to me.

Great!  This fixes #953


            # This will ensure that we resend the entire contents of the
            # body.
            request.reset_stream()
            # Create a new request when retried (including a new signature).
            request = self.create_request(
                request_dict, operation_model)
            success_response, exception = self._get_response(
                request, operation_model, context)
        if success_response is not None and \
>               'ResponseMetadata' in success_response[1]:
E               TypeError: argument of type 'NoneType' is not iterable

../venv/lib/python3.8/site-packages/botocore/endpoint.py:150: TypeError

Thanks for raising this @bsledz. Looks like we're not supporting the USER_PASSWORD_AUTH-flow at the moment, so I'll mark this as an enhancement to implement that.
The only flows we currently do support (as of moto 2.2.2) for initiate_auth is USER_SRP_AUTH and REFRESH_TOKEN.

@bblommers Thank you! I suggested change, please take a look.

This is now fixed as of Moto >= 2.2.3, so I'll close this.
Let us know if there's anything else missing.

@bblommers I am getting this exact issue in moto version 2.2.16 - it may have been re-introduced perhaps?

The test from the OP still passes in master, so it looks like you're running into a different bug @JamieMcKernanKaizen . Feel free to open a new issue, ideally with a reproducible test, and we'll look into it.

The test from the OP still passes in master, so it looks like you're running into a different bug @JamieMcKernanKaizen . Feel free to open a new issue, ideally with a reproducible test, and we'll look into it.

Opened new issue here #4623


Unknown BABEL option

It works after removing .babelrc.

Fixed in 0.5.1

I'm on 0.5.1 and still having this issue.
TransformError: /Development/DiscoveryVR-New/node_modules/redux-promise/node_modules/flux-standard-action/lib/index.js: [BABEL] /Development/DiscoveryVR-New/node_modules/redux-promise/node_modules/flux-standard-action/lib/index.js: Unknown option: /Development/DiscoveryVR-New/node_modules/redux-promise/node_modules/flux-standard-action/.babelrc.stage


Relational fields in create and update mutations

Let's start discussion about schema generation for create and update mutation. We need an API to update relational fields with mutations. Here is one idea how this could be done. I got inspiration from here: https://docs.fauna.com/fauna/current/api/graphql/relations#create
create
# create object and create, add or set relations
  createUser(data: {

    # one to one relation
    group: {
      # set by using primary key
      set: { id: 1 }
      set: 1  # question, should we accept also id/pk?
      # set existing object, filters have to be set so that there is only one matching object (will be implemented later)
      set: { username: "friend" }
      # create new object and add it to the user (will be implemented later)
      create: { name: "best friend" }
    }

    # many to many relation
    groups: {
      # add existing objects, can be used together with create
      add: [{ id: 1}, { id: 2 }],
      add: [1, 2],  # question, should we accept also list of id/pk values?
      # set, cannot be used together with create or add
      set: [{ id: 3 }, { id: 4 }],
      # create new objects along with user  (will be implemented later)
      create: [
        { name: "group 1" }
        { name: "group 2" }
      ],
    }
  }) {
    groups {
      id
      name
    }
  }

update
  # update relation field
  updateUser(data: {

    # one to one relation
    group: {
      # set primary key
      set: 1
      # clear user
      set: null
      # create new object and add it to the user (will be implemented later)
      create: { name: "best friend" }
    }

    # many to many relation
    groups: {
      # add new groups
      add: [{ id: 1}, { id: 2 }],
      # remove groups
      remove: [{ id: 3 }, { id: 4 }],
      # set the list of objects, cannot be used together with create, add or remove
      set: [{ id: 3 }, { id: 4 }],
      # clear all objects
      set: [],
      # create and add objects (will be implemented later)
      create: [
        { name: "new group" }
      ],
    }) {
    groups {
      id
      name
    }
  }
}

I'm still very new to Django/Python but here are some notes to consider:
While in Django I'm using the AutoBigField as PK I exclusively share an UUID to the frontend so setting the correct pk via default_fields or query to lookup is crucial.
I'm having quite a few many-to-many fields implemented via a 'through' intermediate model. So adding this into the mutation would be nice. So I guess there would have to be a couple of nested mutations. Here "assignees" is a intermediate model. So if I understand it correctly I first would have to create/get a task, load up the users/teams and then create/update the corresponding model "task_assignments" which has ForeignKeys to the models User and Task and set the corresponding role in the rrespective fields.
mutation updateTask( data: {
  task(uuid: $uuid) {
    name: "new name",
    assignees: {
      user1: {
        "user1_uuid": $user1_uuid,
        "user1_role": $user1_role
        },
      user2: {
        "user2_uuid": $user2_uuid,
        "user2_role": $user2_role
        },
      team1: {
        "team1_uuid": $team1_uuid,
        "team1_role": $team1_role
      }
    }
  }
}

On the matter of multiple and/or nested mutations I think this is important to consider (although I'm not sure if that's handled by GraphQL-core: "While query fields are executed in parallel, mutation fields run in series, one after the other.
This means that if we send two incrementCredits mutations in one request, the first is guaranteed to finish before the second begins, ensuring that we don't end up with a race condition with ourselves." (quoted from https://graphql.org/learn/queries/)
Also, besides create, update and I quite like the idea of the "upsert"-mutation that Hasura offers. Prisma.io has this mutation type as well. Maybe it's worth having a look if they're good for some more inspiration.

While in Django I'm using the AutoBigField as PK I exclusively share an UUID to the frontend so setting the correct pk via default_fields or query to lookup is crucial.

I'm having quite a few many-to-many fields implemented via a 'through' intermediate model. So adding this into the mutation would be nice. So I guess there would have to be a couple of nested mutations. Here "assignees" is a intermediate model. So if I understand it correctly I first would have to create/get a task, load up the users/teams and then create/update the corresponding model "task_assignments" which has ForeignKeys to the models User and Task and set the corresponding role in the rrespective fields.

Maybe we could use following syntax to pass through_default for django.
{
  set: [ ... ],
  throughDefault: { ... }
}

mutation updateTask( data: {
  task(uuid: $uuid) {
    name: "new name",
    assignees: {
      user1: {
        "user1_uuid": $user1_uuid,
        "user1_role": $user1_role
        },
      user2: {
        "user2_uuid": $user2_uuid,
        "user2_role": $user2_role
        },
      team1: {
        "team1_uuid": $team1_uuid,
        "team1_role": $team1_role
      }
    }
  }
}

That's also one option. We could accept list of related objects and values of "through" fields.

On the matter of multiple and/or nested mutations I think this is important to consider (although I'm not sure if that's handled by GraphQL-core: "While query fields are executed in parallel, mutation fields run in series, one after the other.
This means that if we send two incrementCredits mutations in one request, the first is guaranteed to finish before the second begins, ensuring that we don't end up with a race condition with ourselves." (quoted from https://graphql.org/learn/queries/)

Need to investigate how the graphql core and strawberry work today.

Also, besides create, update and I quite like the idea of the "upsert"-mutation that Hasura offers. Prisma.io has this mutation type as well. Maybe it's worth having a look if they're good for some more inspiration.

Interesting idea. Need to thing about that.

Create and update mutations have been to follow that syntax updated in #30. This will be part of v0.2 release.
Let's created new tickets for other features if needed.


Appstudio update test-component-pac-uiyf

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-uiyf-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
25 seconds
build-container

✅ Succeeded
1 minute
sast-snyk-check

✅ Succeeded
27 seconds
inspect-image

✅ Succeeded
18 seconds
clair-scan

✅ Succeeded
28 seconds
deprecated-base-image-check

✅ Succeeded
47 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
25 seconds
label-check

✅ Succeeded
6 seconds
show-summary

✅ Succeeded
6 seconds
show-sbom

Pipelines as Code CI/test-component-pac-uiyf-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
25 seconds
build-container

✅ Succeeded
1 minute
sast-snyk-check

✅ Succeeded
27 seconds
inspect-image

✅ Succeeded
47 seconds
clamav-scan

✅ Succeeded
28 seconds
deprecated-base-image-check

✅ Succeeded
18 seconds
clair-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
25 seconds
label-check

✅ Succeeded
6 seconds
show-summary

✅ Succeeded
6 seconds
show-sbom

Pipelines as Code CI/test-component-pac-uiyf-on-pull-request has successfully validated your commit.


Eliminate duplicate email addresses. Fixes #388

I tested locally whether it's deterministic by running it twice and cross-checking md5sums and they aligned.
cat out-sf1a/graphs/csv/bi/singular-projected-fk/initial_snapshot/dynamic/Person_email_EmailAddress/part-0000*.csv | sort | md5sum


missing javax.json:javax.json-api:1.1.4

.. and friends

PR? :wink:

in progress...
jar --describe-module --file javax.json-api-1.1.4.jar
java.json jar:file:///.../javax.json-api-1.1.4.jar/!module-info.class
exports javax.json
exports javax.json.spi
exports javax.json.stream
requires java.base mandated
uses javax.json.spi.JsonProvider

Thus, mapping Maven Group ID javax.json to java.json...

.. and friends

Which "friends" did you refer to? Seems like the updated alias map only caught a single "new" Java module.


chore: general clean up and improve usefulness of readme.md

As a part of Roadmap Issue 321, this PR fixes a few small issues found when auditing the ganache docs:

[x] consistent punctuation
[x] consistent capitalization
[x] consistent use of inline code formatting
[x] add navigation to top of readme (similar to ganache-core)
[x] add navigation within sections where applicable

Closing this PR... the work is not necessary


[5.2] fix convenience accessors on CocoaError and URLError

fixes SR-13037 (https://bugs.swift.org/browse/SR-13037)

(previously merged to master in https://github.com/apple/swift-corelibs-foundation/pull/2828)

cc @drexin

@swift-ci test

note: merged to the 5.3 branch in #2845

@swift-ci test 5.2 macos

@swift-ci test 5.2 macos


source generated json serialization

https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/source-generation?pivots=dotnet-8-0

not using aot so this is not required, closing


Can't find /Game/Maps/RaceTrack

Hi! I just have a quick question.
Where can I find the location of /Game/Maps/RaceTrack?
I installed Carla 0.8.4 as mentioned but when I run the command:
./CarlaUE4.sh /Game/Maps/RaceTrack -carla-server -benchmark -fps=20 -carla-no-hud,
it cannot find the the map file and says "./CarlaUE4.sh /Game/Maps/RaceTrack: No such file or directory"
Thank you in advance!

Hi! I just have a quick question. Where can I find the location of /Game/Maps/RaceTrack? I installed Carla 0.8.4 as mentioned but when I run the command: ./CarlaUE4.sh /Game/Maps/RaceTrack -carla-server -benchmark -fps=20 -carla-no-hud, it cannot find the the map file and says "./CarlaUE4.sh /Game/Maps/RaceTrack: No such file or directory"
Thank you in advance!

Hi have you fix this ?


Adding range based pruning to bloom index

keys compared lexicographically using String::compareTo
Range metadata additionally written into parquet file footers
Trim fat & few optimizations to speed up indexing
Add param to control whether input shall be cached, to speed up lookup
Add param to turn on/off range pruning
Auto compute of parallelism now simply factors in amount of comparisons done
More accurate parallelism computation when range pruning is on
tests added & hardened, docs updated

@ovj @alunarbeach Please test it out once if you can. Planning to merge this in the next few days

@vinothchandar will try this change today.

@vinothchandar  will update you tomorrow.

Thanks @vinothchandar for the change.
Ran below test with and without range pruning. Saw large improvement for "filterExists" query. Rough idea about the dataset which was purposefully created to test it.

1000 files with approximately 500M each.
Each file is having ~2M records. (200M records were inserted with 100 parallelism for bulkInsert to create dataset.)
Now ran 2 workloads one with range pruning and another one without it. With the change it took ~15-30min to do filter exists vs 2.5hrs+ for without it (existing change). Didn't notice any stage taking too much time or is having very high parallelism.

@ovj thanks for testing it out, looks like a win .
@alunarbeach can you please your exp as well? it would be helpful
@prazanna any other concerns before I merge this?

Ran the below test with and without range pruning.
Did a Bulk Insert of the dataset is ~474M records (~110 GB Snappy Parquet). Key is a combination of date + uuid. Then did a upsert of 57M records over the 474M records.
Partition Fields - DayId, HourId
Without Range pruning:
BULK_INSERT Time - 1 Hr 33 Min
Upsert Time - 1 Hr 29 Min
With Range Pruning:
BULK_INSERT Time - 1 Hr 32 Min
Upsert Time - 1 hr.
This is a huge win for the overall run time.
Thanks @vinothchandar


Fix download links for Chrome

Fixes #484
Fixes the links on the download page for Chrome. Preserves the behaviour across Firefox and Safari as well. I haven't tested it out on any other browsers but I expect the behaviour to be the same (original page will redirect to support page while download starts without a popup and external links opens new tab)

thank you @limzykenneth!


Changed email regex

Because the current doesn't allow capital letters and other things

Coverage remained the same at 83.155% when pulling 863b7ab61f7d365d60dd260320a585cde87aac1b on SPAHI4:master into 4c02e015c89dd54fefa80ff804d9d4b06be31028 on yiminghe:master.


Add Cumulus as an organization allowed to use ocaml-ci

Cumulus is currently the owner of Syndic which is a library used by ocaml.org. It will be nice to have an access to ocaml-ci and check if Syndic is in a good shape.

We would be delighted for you to run OCaml-CI against Syndic.
We have recently changed the onboarding process of OCaml-CI.  See PR #892.  We now update only deploy-data/github-organisations.txt and rebuild stack.yml using a Makefile.  This ensures that everything remains correctly synchronised.

I rebased this PR according to your request :+1:.


Set-Content on Unix system not working with created PSDrives with the FileSystem provider

Also activate the tests which were marked as skipped for those tests
Anything that went against the single rooted drive was fine, but
new-psdrive -name TEMP -root /tmp -psprovider filesystem`
set-content TEMP:/file

would fail

Hi @JamesWTruher, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Jim Truher). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

PR #2392 is a better change (this one is too specific to set-content) - Sharu will take these tests


⚠ GitLab Server has degraded performance

In 3269346, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6245 ms

Resolved: GitLab Server performance has improved in 25e5c1c.


Gettogm error : libusb: pipe error [code -9]

Hey, am trying on MacM1 , and getting error
libusb: pipe error [code -9]
when try to send keyboard message, i used the exact same code sample you mentioned in readme

Hi, could you try otg mode of the scrcpy?
Scrcpy is a great project and my code is based on this.
Let me know what Android mobile device you used and how otg mode runs on it.

@Tryanks otg mode works fine for me, i tried in OnePlus Nord and Samsung Galaxy Note20, and same error in both devices
i tried replicating the code from your's and scrcpy section in dart ( a wrapper over libusb ), and strangely i also got the same error message when tried calling SendEvent, seems like something is missing in the implementation

Sorry, but since I don't have an M1 Mac (nor an Intel Mac), I'm not entirely confident in fixing the issue you've encountered here.
The main probrom is that I 'can't get any clues that might help with the fix from just a pipe error, which work in the very majority of my use cases: Arm/Amd64 | Windows/Linux.
I'll try to check code again later.

@Tryanks ok thanks, i will give it a try on windows


A discord server would be nice

Spitballing stuff in coderbus isn't very convenient since all of the relevant people either need to be pinged or the messages will get lost in general coderbus chatter.

I've made a bare-bones discord server for us to use
https://discord.gg/RnthcQcqjY
@ZeWaka @ike709 @willox @redmoogle @MarkSuckerberg


[Documentation] Need instructions on how to update existing Morpho installation

Updating Morpho currently requires performing a git pull operation in the Morpho directory followed by installation. These steps aren't documented in the current README.md

This is a really great suggestion, @joshichaitanya3! I'm going to update the README.md file before the next release to include information about updating morpho. We should probably include this in the manual.

I've added this to the manual!


Remove Private Internet Access Due to Kape Technologies Merger

From the CyberGhost VPN Private Policy (Part of Kape Technologies):

Lastly, we may share Non-personal Data associated with the use of our Website with 3rd part suppliers for the purposes of optimization of our Website and Services as well customer analytics (e.g.VWO, Facebook, Yahoo, Twitter, Bing, Google, Mixpanel, Instabug, BugSplat, OpenX etc). These third parties will use Non-personal Data and/or Personal Data relating to your use of our Website to evaluate your use of the Website, compile reports on Site activity and provide other Site activity and internet related services, all in accordance with their applicable privacy policy.
We may further collect and possibly share your Personal Data to enforce the Terms of Service. This may be done to prevent a crime or violation of our Terms of Service or to help solve a transgression that has been committed.
We also reserve the right to disclose your Personal Data as required by law and when we believe that disclosure is necessary to protect our rights and/or comply with a judicial proceeding, court order, or legal process served on our Web site.

+1


where are labels  for val images?

I can't find the labels of val images in official website

BUMP. any updates?


fix(assets-entry): string.endsWith compatibility issue

Summary
string.endsWith is es6 API and can be replaced with nextDomain[nextDomain.length - 1] === '/'.
Also renamed some variables to make the bundle smaller(asyncChunkRetry.min.js 2,995 bytes -> 2,849 bytes)
Related Links
https://caniuse.com/?search=endsWith
Checklist

[x] Tests updated (or not required).
[x] Documentation updated (or not required).

If I could make IE disappear in the world with one click...


Authorization: Bearer wrong key for PATCH with Cypress

Bug report
Describe the bug
This is a bit of a weird bug that I am encountering after upgrading supabase-js from 1.27.0 to 1.31.1.
I am not sure if I am able to reproduce this, so let me try to explain instead.
I have a set of Cypress tests running on my supabase front-end, and after upgrading SupabaseJS, they started failing. Tests are failing because any PATCH-calls are receiving a 404 from the backend.

By inspecting the network calls in Cypress, I can see that there is something weird with the Authorization-header: It is using the API-token instead of the Access/refresh token!
Consider the Authorization-header for the successful GET-call:

and compare it to the failing PATCH-call:

Running the exact same operation through the browser (Firefox in this case):

Some further details:

only PATCH-calls are failing with 404, not GET
the PATCH calls are only failing in Cypress. When I run through the same steps manually in a browser, it works as expected
This started only after upgrading supabase-js from 1.27.0 to 1.31.1

Any idea if this is something I'm doing wrong? Or maybe it's not an issue with Supabase but with Cypress? Any hints or pointers would be greatly appreciated!
System information

OS: Linux 5.13.19-2
Version of supabase-js: 1.31.1
Version of Node.js: 16.13.0

EDIT: I have narrowed down the problem to the change in supabase-js from 1.27.0 to 1.28.0: https://github.com/supabase/supabase-js/compare/v1.27.0...v1.28.0

Hey everyone, just checking, is this still an issue if you update to the latest supabase/js verison?

I haven't had this issue for a long time now, so my gut feeling would be that this have been resolved by the new versions. 👍


Cannot make an input layer that takes scalars with the keras functional api

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): no
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): source (branch 1.4)
TensorFlow version (use command below): 1.4.0-dev
Python version: 3.5
Bazel version (if compiling from source): 5.4.0
CUDA/cuDNN version: 8.0/6.0
GPU model and memory: nVidia 1080Ti 11G
Exact command to reproduce: run the script below

Describe the problem
The following is an attempt to use the keras functional api to make a model that accepts scalars as input:
import tensorflow as tf
from tensorflow.contrib.keras.api.keras.models import Model
from tensorflow.contrib.keras.api.keras.layers import Input
i = Input(batch_shape=(None, ), dtype=tf.uint8, name="input")
m = Model(inputs=i, outputs=i)

which fails like so:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-54-dd00bec66757> in <module>()
----> 1 i = Input(batch_shape=(None, ), dtype=tf.uint8, name="input")
      2 m = Model(inputs=i, outputs=i)

/usr/local/lib/python3.5/dist-packages/tensorflow/python/keras/_impl/keras/engine/topology.py in Input(shape, batch_size, name, dtype, sparse, tensor, **kwargs)
    611     dtype = K.floatx()
    612   if not shape and tensor is None:
--> 613     raise ValueError('Please provide to Input either a `shape`'
    614                      ' or a `tensor` argument. Note that '
    615                      '`shape` does not include the batch '

ValueError: Please provide to Input either a `shape` or a `tensor` argument. Note that `shape` does not include the batch dimension.

Using a sequential model instead works fine:
import tensorflow as tf
from tensorflow.contrib.keras.api.keras.models import Sequential
from tensorflow.contrib.keras.api.keras.layers import InputLayer
m = Sequential()
m.add(InputLayer(batch_input_shape=(None, ), dtype=tf.uint8, name="input"))

Additionally using the external keras works fine:
import tensorflow as tf
from keras.models import Model
from keras.layers import Input
i = Input(batch_shape=(None, ), dtype=tf.uint8, name="input")
m = Model(inputs=i, outputs=i)

It appears that this broke when the tensor and batch_size arguments were added to the internal version.
Here is one possible way to fix it which I can propose if people are ok with it:
diff --git a/tensorflow/python/keras/_impl/keras/engine/topology.py b/tensorflow/python/keras/_impl/keras/engine/topology.py
index f9be782..74df725 100644
--- a/tensorflow/python/keras/_impl/keras/engine/topology.py
+++ b/tensorflow/python/keras/_impl/keras/engine/topology.py
@@ -605,21 +605,20 @@ def Input(  # pylint: disable=invalid-name
       raise ValueError('Only provide the shape OR '
                        'batch_shape argument to '
                        'Input, not both at the same time.')
-    batch_size = batch_shape[0]
-    shape = batch_shape[1:]
+  else:
+    if not shape and tensor is None:
+      raise ValueError('Please provide to Input either a `shape`'
+                       ' or a `batch_shape` or a `tensor` argument.'
+                       ' Note that `shape` does not include the batch '
+                       'dimension.')
+    batch_shape = (batch_size,) + tuple(shape)
   if kwargs:
     raise ValueError('Unrecognized keyword arguments:', kwargs.keys())

   if dtype is None:
     dtype = K.floatx()
-  if not shape and tensor is None:
-    raise ValueError('Please provide to Input either a `shape`'
-                     ' or a `tensor` argument. Note that '
-                     '`shape` does not include the batch '
-                     'dimension.')
   input_layer = InputLayer(
-      input_shape=shape,
-      batch_size=batch_size,
+      batch_input_shape=batch_shape,
       name=name,
       dtype=dtype,
       sparse=sparse,

FYI, it is not possible to model.predict() at the moment with a scalar input_shape, even though it is totally valid to put scalars into a feed_dict using session.run(). In fact, some tensorflow operations like tf.images.decode_jpeg require scalar inputs. The missing scalar support is a separate keras issue that I have reported here: https://github.com/fchollet/keras/issues/8436

@fchollet FYI, feel free to assign this issue to others.

You are supposed to specify shape and batch_size as two separate arguments. We are deprecating the batch_shape argument from the public API.

@fchollet I understand the desire to deprecate batch_shape but that means there is no way to define an input that takes a scalar. Are you suggesting that accepting scalar input will not be supported at all? Or are you saying that the implementation needs to be different, perhaps with a new kwarg or a special sentinel value for shape? I personally think packing scalars into 1d vectors is pretty ugly, but if the decision is keras will not support scalars, I will abide by it.

@fchollet  so what is the solution here? Is there a way to define a scalar keras variable, or are we supposed to have it as vector and slice it?

In case anyone else needs help with this - My solution was to use shape=(1,). Equivalently, I think, you could do batch_shape=(batch_size,1)


Virus test file causes header_present? method to fail

We recently added virus scanning to our file transfer process, which we already used SymmetricEncryption to encrypt (uploade) and decrypt (download) the files. However when we use a sample virus file the SymmetricEncryption::Reader.header_present? call raises an OpenSSL::Cipher::CipherError: wrong final block length error.
The sample file is simply a text file with the body of
eicar_test_file.txt
X5O!P%@AP[4\PZX54(P^)7CC)7}$EICAR-STANDARD-ANTIVIRUS-TEST-FILE!$H+H*

Sorry, I missed the github email notification for this issue somehow.
Trying to reproduce the issue via the console:
SymmetricEncryption::VERSION
# "3.8.3"

SymmetricEncryption::Writer.open('eicar_test_file.txt.enc') {|f| f.write File.read("eicar_test_file.txt")}
# 69

SymmetricEncryption::Reader.open('eicar_test_file.txt.enc') {|f| f.read }
# "X5O!P%@AP[4\\PZX54(P^)7CC)7}$EICAR-STANDARD-ANTIVIRUS-TEST-FILE!$H+H*\n"

Or, hopefully you have been able to resolve or workaround this issue?

Configure your anti-virus software to not check .enc files since they are encrypted.


Gigasecond unit tests don't include the proper boost headers

In the test suite for gigasecond, the compiler emits errors about not finding the types from boost.dateTime. This is because the proper header isn't included. I can see two ways forward for this:

Don't do anything. Having to debug this issue was a good exercise, because it taught me to remember to check the headers (which have to be used in the user-provided gigasecond.h anyway).
Include the headers into the test suite. The user will still need to include the header in their own solution files, so they'll still get that practice.

I don't remember this being an issue when I did the problem, but I don't usually try to compile an empty solution. I understand many people do though, which is one reason why we've been adding some of the std includes needed by the test suite. ( #121 )
This one is a bit different though, since reading the Boost docs (with the link given in the test suite) and then writing the obvious 1 liner is the entire exercise. Giving them the right header in the test suite lets the user avoid the issue of figuring out what include file they need.
I think it's better to leave as is. Thanks for bringing it up though :)
(If you do feel strongly that it should be in there, reopen and we can discuss more. These types of discussions about improving the test suite are really valuable to have. )

I was torn on whether including the header would be better or worse, so thanks for your input. I agree with this decision.


Updated configs for Blender 4.1 to 4.3

Solved keymaps issues and added some new featues in the Special pie menu (CTRL Shift D )
Updated install instruction page

There was a conflict during the pull request. I hope I solved it properly.

Thank you @Renart84!!

Thank you, @Renart84 and @HEAVYPOLY, for continuously helping and providing updates.


etcdserver: start real txn for txn request

We should open real txn for applying txn requests. Or the intermediate
state might be observed by reader.
This also fixes #3803. Same consistent(raft) index per multiple indenpendent
operations confuses consistentStore.

LGTM


Update the main README with info and link upgrade & migration docs #3145

Updating Readme.md with Upgrade and Migration steps from respective docs folder  issue #3145
contents are taken from below.
upgrade
migrate

@Naveenkhasyap The issue https://github.com/openebs/openebs/issues/3145 was to raise the README changes in the  https://github.com/openebs/upgrade repo. Can you please move this PR to that repo.

@shubham14bajpai ok will correct it .

Moving this to Upgrade repo.


Cannot uninstall dependents unless the dependencies' formulae still exist

CC @alyssais @MikeMcQuaid
Reproducer:
$ brew pull https://github.com/Homebrew/homebrew-core/pull/7288
$ brew install -dvs gtkglext
$ brew install open-scene-graph
$ brew uninstall open-scene-graph
Error: No available formula with the name "pangox-compat"
$ brew uninstall --ignore-dependencies open-scene-graph
Uninstalling /usr/local/Cellar/open-scene-graph/3.5.5... (782 files, 36.9M)

As a result, I will now have to revision bump open-scene-graph even though it's not at all broken.
Edit: Note that open-scene-graph does not itself even depend on pangox-compat directly, only via gtkglext, which no longer depends on pangox-compat if 7288 has been pulled. So pangox-compat is not actually anywhere in the dependency tree of open-scene-graph when the error occurs:
iMac-TMP:homebrew-core joe$ brew deps open-scene-graph|tr '\n' ' '
atk cairo fontconfig freetype gdk-pixbuf gettext glib gobject-introspection gtk+ gtkglext harfbuzz hicolor-icon-theme icu4c jpeg libffi libpng libtiff openssl pango pcre pixman pkg-config shared-mime-info wget

Oh and it also means that even if I revision bump it, users who are on the current version of open-scene-graph and try to uninstall it, instead of upgrading to the new revision, will hit this bug.
This affects any and all dependents that have boneyarded formulae.

Thanks @ilovezfs.
This should be a pretty straightforward fix. Will have time to investigate properly over the next couple of days (probably mostly Wed).
Noting this here for my own benefit:
The problem is that Keg#installed_dependents resolves all of the formulae listed as dependencies in a tab with Formulary.factory, which raises an exception when the formula can't be found. Instead of this, it should catch that exception and fail gracefully in such a case.

@alyssais thanks. I'll hold off on merging https://github.com/Homebrew/homebrew-core/pull/7288 because right now it contains two unnecessary revision bumps in order to compensate.

The problem is that Keg#installed_dependents resolves all of the formulae listed as dependencies in a tab with Formulary.factory, which raises an exception when the formula can't be found. Instead of this, it should catch that exception and fail gracefully in such a case.

Yep, exactly 👍. brew uninstall should silently ignore either the requested formula or any dependencies not existing.

Hmm... what if a tap has been uptapped ...

Not much we can do in that case. We need brew uninstall foo to work if there's /usr/local/Cellar/foo even if there's no more foo formulae in any tapped taps.

I think we should still protect the dependents, though, even if the original formula file isn't there.

The problem is that Keg#installed_dependents resolves all of the formulae listed as dependencies in a tab with Formulary.factory

Assuming we're not in the fallback code, doesn't the Cellar + the receipt have enough info to protect the kegs without having to have the formula file?

Also, aren't we keeping copies of the original formula file in the .brew directory?

I think we should still protect the dependents, though, even if the original formula file isn't there.

Yes, I see your argument now. If Formula.factory fails we should try to get a Keg with the same name and protect that if possible.

Also, aren't we keeping copies of the original formula file in the .brew directory?

We are. We also aren't using them for anything currently.

Going to proceed with merging https://github.com/Homebrew/homebrew-core/pull/7288 with the revision bumps.

So, if a keg can't be resolved to a formula, just compare the full name in its install receipt to the full name specified in the runtime dependencies list of all the other install receipts?

Is the install receipt updated with the new name during a formula rename migration?

I don't believe it is


Can't read XML error files with encoded nulls

The problem is that if an error is logged that contains a null character in the body, it's encoded and saved to the XML error file, but can't be read back again. It's easy to reproduce by adding an error file with the following contents...
<error errorId="2be61d3b-a1a9-4b76-9de3-133200ec8708">
  <form>
    <item name="$request-body">
      <value string="�" />
    </item>
  </form>
</error>

... and then trying to view it in the web interface, which will conplain about a "data loading error" because the API didn't return any of the logged errors.
This has actually been raised before with #101 and fixed by passing CheckCharacters = false to XmlReader.Create, however there are two more uses of XmlReader.Create that weren't fixed. They are at https://github.com/ElmahCore/ElmahCore/blob/1d045c0075dc760d831970a4c4066c9eb157e667/ElmahCore/Logs%24/XmlFileErrorLog.cs#L143 and https://github.com/ElmahCore/ElmahCore/blob/1d045c0075dc760d831970a4c4066c9eb157e667/ElmahCore/Logs%24/XmlFileErrorLog.cs#L183

#143


Unwanted logs in console.

This package is filling the console with the following output and I an wondering whether this can be put off.
I/flutter (10704): Column is address
I/flutter (10704): Column is body
I/flutter (10704): Column is address
I/flutter (10704): Column is body
I/flutter (10704): Column is address
I/flutter (10704): Column is body
I/flutter (10704): Column is address
I/flutter (10704): Column is body
I/flutter (10704): Column is address
I/flutter (10704): Column is body
I/flutter (10704): Column is address
I/flutter (10704): Column is body
I/flutter (10704): Column is address
I/flutter (10704): Column is body
I/flutter (10704): Column is address
I/flutter (10704): Column is body
I/flutter (10704): Column is address
I/flutter (10704): Column is body
I/flutter (10704): Column is address
I/flutter (10704): Column is body
I/flutter (10704): Column is address
I/flutter (10704): Column is body
I/flutter (10704): Column is address
I/flutter (10704): Column is body
I/flutter (10704): Column is address
I/flutter (10704): Column is body
I/flutter (10704): Column is address
I/flutter (10704): Column is body

I have a similar issue. It will be nice if debugPrint is removed when creating a release.

Can someone fix this please its really annoying

Can someone fix this please its really annoying

I fixed it here https://pub.dev/packages/another_telephony


Add logs to indicate that the token does not have sign permission.

Description
Add log for troubleshooting.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


replace []Issue with []*Issue and for other large structs as well

Note that this is an API-breaking change but should have minimal
impact on users of this package due to the nice inference
properties of the Go programming language.
Fixes #180.
Change-Id: Ib386135e6b8f306d1f54278968c576f3ceccc4e7

LGTM.
Most clients will not need to change their code at all. Some will need to update it, if they have wrappers or mock implementations of these interfaces. But it's easy to do so, and it makes the API better/resolves an issue.
It is a breaking API change (even if slightly), so I'd suggest waiting to hear @willnorris's thoughts too. But I think it's worth it (at least I'm not opposed).
P.S. You would not be able to do this in C++ as easily, because each . in user code would have to become ->. :)

I think more people are going to have to change their code than you think.  For example, just looking at the Issues.List method, both of the two people using it would have compilation errors.  Now granted, it's a very easy fix for them, but it's still a breaking change nonetheless.
That said, I'm still fine with doing it.


Wrong PKCS7 signature data

When parsing the PKCS7 signatureData from AppStore Receipts, we may end up with the field:
    OCTETSTRING {
        GRAPHICSTRING: 3 bytes
        CONTEXTSPECIFIC(11):
        APPLICATION(2) {
            NUMERICSTRING {
                APPLICATION(8):
            }
        }
        APPLICATION(7)
    }

instead of
Optional<ASN1Object>
  ▿ some : OCTETSTRING: 256 bytes

If so, accessing the SignatureInfo's signatureData field yields nil  (as signature?.value == nil). Access via signature.rawValue returns 256 bytes.
I've attached a sample b64 sandbox receipt which results in such behavior:
receipt.b64.txt

Fixed with b1cd17c9950a764df657de036f800869fd2fdfaf


cleaner directory seperation between release and debug

Currently include files are shared between debug an release build, with debug binaries placed in a debug subfolder of the release folder.
I think this could give some problems:
a) Some libraries auto-generate custom header files during compilation. Eg configuartion headers.
These might be different for release and debug, possibily resulting in horrible abi breakages.
b) Same problem holds for generated cmake files in install folder (?)
c) The upcoming c++ module system ifc files are (probably) different for realease and debug builds, thus require an clean seperation anyways
d) With the debug libraries in the same folder, wrong libraries could be linked in when referencing libraries by hand.
Maybe its better to split:

realease and debug folders with bin, include, lib, ... subfolders
build an checksum over the include folder to allow a consistency check later

a)
This is a good point, and one we did consider when initially deciding the file layout initially. The idea was to potentially support a debug\include\ folder that could optionally be provided and would be put first in the include order compared to the base include\ folder. This would allow libraries that did what you've described (different headers in release vs debug) to override our base behavior.
However, in the 175+ libraries we have, this has yet to be an issue. This inclines me to say that it's rare enough (<0.5% of libraries) that we can have "special" handling when it's needed instead of making it the default behavior for every library. An example of this special handling would be to generate "shadow" headers which simply have an "#ifdef NDEBUG" and forward to the correct true header.
As with everything, it's tradeoffs. We think that avoiding duplication of headers for Debug vs. Release is pretty important given the number of header-only libraries that exist for C++ (such as large parts of Boost). The cost that we may need to do some "ugly" things for one or two libraries that generate different debug and release headers seems worth it.
Do you have a concrete example of a library which does generate incompatible headers for debug and release?
I do agree that the checksum over the headers sounds like a reasonable way to check for difference between debug/release, however the devil is in how to implement it without placing undue burden onto port maintainers.
b)
CMake supports multiple configurations out-of-the-box for "config" mode. We already have many libraries that provide these files; essentially there is a "foo-targets-release.cmake" and "foo-targets-debug.cmake" which each supply the relative paths for their configuration. These do require fixups on install to make it work (see opencv for one of the most complex examples).
c)
We will probably put ifc files into either the lib\ folder or they will get their own toplevel folder which will be split for debug/release.
d)
Not 100% sure what you're stating here, but we currently put debug libraries into debug\lib\ and debug\bin\ to fix this exact issue. There is an outstanding issue with CMake's multi-configuration generators, "FindX.cmake" modules, and libraries that do not use debug suffixes where the wrong import library will be selected; the workaround for these libraries is (for now) to use separate build trees for Release and Debug.


MAINT: Remove all functionality for AMRFinderPlus

sloves #105
Reverts all these commits:
"ENH: add new type AMRFinderPlusDatabase #81"
"ENH: add AMRFinderPlusAnnotation type #86"
"BUG: added database_format_version.txt to AMRFinderPlusAnnotationsDirFmt #92"
"ENH: Added new action that can download AMRFinderPlus database called fetch_amrfinderplus_db  #82"
"ENH: Action to annotate MAGs and contigs with AMRFinderPlus #88"
"ENH: Removed AMRFinderPlusAnnotation type #95"
"ENH: Add three new parameters to run_amrfinderplus_n #97"
All this functionality was moved to q2-amrfinderplus.

Hi @misialq
The Ci is not running and its failing in the setup miniconda part. I have basically the same code as in the moshpit ci. The only difference is teh python version of 3.8 or 3.9.
Have you seen this before?
Error: Unable to locate executable file: /usr/share/miniconda/condabin/mamba. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.

Unfortunately, I have seen this in moshpit as well and as of today I have no clue what the problem is 😅


Links on website are broken

On the website, some links are broken. In particular, for NVIDIA+CoreWeave links are of form
https://github.com/mlcommons/training_results_v3.0/blob/main/NVIDIA%2BCoreWeave/systems/coreweave_hgxh100_n448_ngc23.04_pytorch.json
instead of
https://github.com/mlcommons/training_results_v3.0/blob/main/NVIDIA_CoreWeave/systems/coreweave_hgxh100_n448_ngc23.04_pytorch.json

@Randl Thanks for catching this issue. We've fixed the links. Please let us know if you encounter any further problems.


SOLVED - CORS issue local development

Hi Philo,
I am getting a CORS block on the load attempt of my counter component.
I have followed the steps in your setup from the blog post.  Ill post the contents of my cors config below.
I have built the demo component from your blog post and stored in App/Livewire folder.
Questions:

Do I need to create a route to the component ?

How should I provide any folder nesting in the livewire data-component declaration   i.e. example.counter ...

Here is my example hosting page:
<!DOCTYPE html>

Wire Extender Test

	<livewire data-component="counter" data-params='{"count":10}'></livewire>

Here is the cors.php :
<?php

return [

    /*
    |--------------------------------------------------------------------------
    | Cross-Origin Resource Sharing (CORS) Configuration
    |--------------------------------------------------------------------------
    |
    | Here you may configure your settings for cross-origin resource sharing
    | or "CORS". This determines what cross-origin operations may execute
    | in web browsers. You are free to adjust these settings as needed.
    |
    | To learn more: https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS
    |
    */

    'paths' => ['livewire/*', 'api/*', 'sanctum/csrf-cookie'],

    'allowed_methods' => ['*'],

    'allowed_origins' => ['*'],

    'allowed_origins_patterns' => [],

    'allowed_headers' => ['*'],

    'exposed_headers' => [],

    'max_age' => 0,

    'supports_credentials' => false,

];

Here is the VerifyCsrfToken.php
<?php

namespace App\Http\Middleware;

use Illuminate\Foundation\Http\Middleware\VerifyCsrfToken as Middleware;
use WireElements\WireExtender\Http\Middlewares\IgnoreForWireExtender;

class VerifyCsrfToken extends Middleware
{
    use IgnoreForWireExtender;

    /**
     * The URIs that should be excluded from CSRF verification.
     *
     * @var array
     */
    protected $except = [
        'stripe/*',
    ];
}

And finally here is the result showing the blocked resource :

I have found the issue:
Because the local development environment is running with APP_DEBUG=true this then configures Livewire to return a non-minimised version of the javascript asset.
See vendor/livewire/livewire/src/Mechanisms/FrontendAssets/FrontendAssets.php
If debug is true, then Livewire will return /livewire/livewire.js , but wire-extender.js is requesting /livewire/livewire.min.js.
Setting debug to false solves this issue.
Could you consider requesting the appropriate javascript depending on the debug config.  This is how Livewire does it :
app($this::class)->setScriptRoute(function ($handle) {
    return config('app.debug')
        ? Route::get('/livewire/livewire.js', $handle)
        : Route::get('/livewire/livewire.min.js', $handle);
});

Instead of setting APP_DEBUG=false, you can also manually set data-livewire-asset-uri="/yourwebsite/livewire/livewire.js" in your HTML file during developement as a workaround.

Instead of setting APP_DEBUG=false, you can also manually set data-livewire-asset-uri="/yourwebsite/livewire/livewire.js" in your HTML file during developement as a workaround.

Nice idea thanks !

Thanks @clementmas & @dircm! Great to hear it is working.
I'll make sure to include this in the documentation 😄


nlm-ingestor installation is failing due to lxml, pandas, xxhash

Hi,
nlm-ingestor seems promising one but i couldn't able to move forward with the installation issue.
I got the "ERROR: Failed to build installable wheels for some pyproject.toml based projects (lxml, pandas, xxhash)" when i try to install using the command "pip install nlm-ingestor".
I thought it may be due to dependencies lower versions issue and tried installation using constraints.txt by specifying latest versions (lxml>=5.2.1, pandas>=2.2.2) with the command "pip install -c constraints.txt nlm-ingestor". This also failed saying "nlm-ingestor 0.1.5 depends on pandas==1.2.4"
Please advise on this issue. Thanks in Advance !!

Getting the same issue. Actually I even tried to break it down step by step and even had it installed but now it asks for OPENAI_API_KEY as env variable while running the ingestion daemon. Seems like these packages are configured for python3.10 and not for the latest 3.12+

Same issue, any updates?

this fixed the issue for me:
conda create -n sherpa39 python=3.9
conda activate sherpa39
pip install nlm-ingestor
pip uninstall python-magic
pip install python-magic-bin==0.4.14

Thank you KOG-Nisse. Its worked for me also with your suggestion.
Now i am getting SSLCertVerificationError when i ran the nlm_ingestor.ingestion_daemon. I've opened new issue for this.
https://github.com/nlmatics/nlm-ingestor/issues/81
Please respond if you encounter this ?

Getting the same issue. Actually I even tried to break it down step by step and even had it installed but now it asks for OPENAI_API_KEY as env variable while running the ingestion daemon. Seems like these packages are configured for python3.10 and not for the latest 3.12+

Thanks for your input. Its configured for lower python version.


Issues loading any image

Hi all, this may have been already raised in #88.
I am writing a reader for DBit-seq and while I have no apparent issues with tables and shapes, I cannot parse images.
In the simplest form, I have a 800x800 TIFF image which I can load in a xarray.DataArray object, using two lines I copied from any plugin.
image = imread('test.tif').squeeze().transpose(2, 0, 1)
image = DataArray(image, dims=("c", "y", "x"), name=dataset_id)

When I parse it using Image2dModel I have
sd.models.Image2DModel.parse(image)

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[712], line 1
----> 1 sd.models.Image2DModel.parse(image)

File ~/miniforge3/envs/sc01/lib/python3.10/site-packages/spatialdata/models/models.py:180, in RasterSchema.parse(cls, data, dims, transformations, scale_factors, method, chunks, **kwargs)
    178 data = to_spatial_image(array_like=data, dims=cls.dims.dims, **kwargs)
    179 # parse transformations
--> 180 _parse_transformations(data, transformations)
    181 # convert to multiscale if needed
    182 if scale_factors is not None:

File ~/miniforge3/envs/sc01/lib/python3.10/site-packages/spatialdata/models/models.py:67, in _parse_transformations(element, transformations)
     65 def _parse_transformations(element: SpatialElement, transformations: MappingToCoordinateSystem_t | None = None) -> None:
     66     _validate_mapping_to_coordinate_system_type(transformations)
---> 67     transformations_in_element = _get_transformations(element)
     68     if (
     69         transformations_in_element is not None
     70         and len(transformations_in_element) > 0
     71         and transformations is not None
     72         and len(transformations) > 0
     73     ):
     74         raise ValueError(
     75             "Transformations are both specified for the element and also passed as an argument to the parser. Please "
     76             "specify the transformations only once."
     77         )

File ~/miniforge3/envs/sc01/lib/python3.10/functools.py:889, in singledispatch.<locals>.wrapper(*args, **kw)
    885 if not args:
    886     raise TypeError(f'{funcname} requires at least '
    887                     '1 positional argument')
--> 889 return dispatch(args[0].__class__)(*args, **kw)

File ~/miniforge3/envs/sc01/lib/python3.10/site-packages/spatialdata/transformations/_utils.py:37, in _get_transformations(e)
     35 @singledispatch
     36 def _get_transformations(e: SpatialElement) -> Optional[MappingToCoordinateSystem_t]:
---> 37     raise TypeError(f"Unsupported type: {type(e)}")

TypeError: Unsupported type: <class 'xarray.core.dataarray.DataArray'>

I also tried to run pieces of other parser (visium) with their own data but I get the very same error, so running lines 201-203 of the visium reader with visium data downloaded from the same source as yours:
image_hires = imread(fullres_image_file).squeeze().transpose(2, 0, 1)
image_hires = DataArray(image_hires, dims=("c", "y", "x"), name=dataset_id)
images[dataset_id + "_hires_image"] = sd.models.Image2DModel.parse(
            image_hires, transformations={"downscaled_hires": transform_original}
        )

I have the same error.
I'm running SpatialData 0.0.14

Hi, the latest release should fix this https://github.com/scverse/spatialdata/releases/tag/v0.0.15. The datatypes used upstream in the libraries spatial-image and multiscale-spatial-image changed and broke the single-dispatch in spatialdata, so for the moment we pinned down the old versions in the install configuration.

Excellent, it works, thanks!


Possible to publish the Figma project as a library?

I would like to design my plugin UI using your figma file, I'm not sure if this can be done?