Nearly 3 points below the provided VQAv2 fine-tuning result

Hi,
Thank you for releasing the code!
I want to have a try on getting the result of fine-tuning on VQAv2 recently.
The result generated by the provided vilt_vqa.ckpt (ViLT-B/32 200k finetuned on VQAv2) is [{"test-dev": {"yes/no": 87.44, "number": 50.2, "other": 62.38, "overall": 71.32}}].
Then, I used "num_gpus=4 num_nodes=1 task_finetune_vqa_randaug per_gpu_batchsize=16 load_path=".../vilt_200k_mlm_itm.ckpt"" to fine-tune on VQAv2 using my GPUs and uploaded to VQA Challenge 2021 to evaluate. The result was [{"test-dev": {"yes/no": 85.28, "number": 46.63, "other": 58.87, "overall": 68.36}}].
Will there be the same result if I use the same settings?

I didn't test gradient accumulation for max_epoch based training (=fine-tuning), unlike max_step setting (=pre-training) I've set max_step manually in the max_epoch setting.
Going over the code again, I suspect this line  https://github.com/dandelin/ViLT/blob/master/vilt/modules/vilt_utils.py#L247 could be the source of the degradation.
If I'm guessing it right, the gradient accumulation in current fine-tuning will follow wrong, condensed learning rate schedule.
Please delete the line and try again.

Can you report lr summary in the tensorboard log?

@dandelin Thank you for your advice and time. I happened to find that I made some mistakes during the dataset preparation. The code and paper provide sufficient information. Now, I can achieve the same VQAv2 test-dev result as the paper.
Thank you again for your patient help. I will close this issue.


Rename RelmRemovableExt to RelmRemoveExt

A small fix to make the trait name more intuitive.

Indeed, "removable" doesn't make sense for a container. Thanks for the PR!


Don't close connections made outside of SideQuest

I connected my quest to scrcpy wirelessly and then opened SideQuest to update an app. After closing SideQuest, the adb connection was closed, and I had to start all over. Adb is used for many more things than sidequest, and as such should not live and die with SideQuest.

Hi there! I'm afraid the ADB bundled with sidequest needs to be killed in order to be able to do other operations like uninstall or troubleshooting without the ADB folder being in use. This is intended functionality and for most sidequest users ADB does not get used for other things.

For the users that this does affect, it is a big issue, since side quest can't be used without breaking adb functionality outside of it. Perhaps an "advanced mode" or "advanced options" could be added to allow those users to disable closing the adb server as needed.


No actions in the list

Hey there,
I have tried installing this plugin in my neovim config using lazy but when I run the telescope nx action the list is empty so I cannot run anything.
I have looked in the logs and I seem to be able to see the build targets, I am just unsure why they aren't showing in the list.
I have followed the readme and below is my config
config/plugins.lua
  {
    "Equilibris/nx.nvim",

    dependencies = {
      "nvim-telescope/telescope.nvim",
    },

    config = function()
      require("nx").setup({})
    end,    -- Plugin will load when you use these keys

    keys = {
      { "<leader>nx", "<cmd>Telescope nx actions<CR>", desc = "nx actions"}
    },
  },

plugins/nx.lua
require('nx.nvim').setup{
    -- Base command to run all other nx commands, some other values may be:
    -- - `npm nx`
    -- - `yarn nx`
    -- - `pnpm nx`
    nx_cmd_root = 'npx nx',

    -- Command running capabilities,
    -- see nx.m.command-runners for more details
    command_runner = require('nx.command-runners').terminal_cmd(),
    -- Form rendering capabilities,
    -- see nx.m.form-renderers for more detials
    form_renderer = require('nx.form-renderers').telescope(),

    -- Whether or not to load nx configuration,
    -- see nx.loading-and-reloading for more details
    read_init = true,
}

NX Version
nx --version

Nx Version:
- Local: v17.2.7
- Global: Not found

Any help is appreciated, I am new to neovim so it might be user error but I have spent a good amount of time trying to wrap my head around it and I am unsure whats going on. 😁

Addresses in this PR https://github.com/Equilibris/nx.nvim/pull/26

I experience the same issue.
However, I have noticed that for me the list is populated just fine on the second execution so as a workaround I developed a habit to run <leader>nx, then Escape, then <leader>nx again. 🙈


sqlite3 instrumentation support added

Please let me know if this is something that you guys would like to add to logfire, I will add some more tests and make any changes that you guys suggest.
TODO

[ ] Add more tests

Yes this would be appreciated. It'd also need docs.

@deepakdinesh1123 Are you willing to resume your work on this PR?

@Kludex No, I am busy at work so I have not been able to work on this.

@deepakdinesh1123 I'll close this PR since you don't have time to finish.
Let us know if you want to do it later. We'll be happy to help. :)

We'll eventually implement this anyway.

This is being done in https://github.com/pydantic/logfire/pull/634


Improve help view on how to delete a view

Adding "press d" option, besides the "delete key"

Thank you, @wesleymiao :)


[Suggestion] - Add the option to add a local proxy container in de application pod when the Base URL is not reachable from within the pod

Suggestion
We are running into the following situation:
Jira needs to be able to reach itself using the base URL but the ingress controller we have at our disposal does not allow connections from within the cluster. Therefore there is no path to the base URL and Jira cannot work properly.
Similarly Confluence needs to be able to reach synchrony through the same URL as user do, which is the URL configured at the ingress controller. Therefore Confluence synchrony do not work properly together.
Another related issue is the creation of an application link which does not work due to the same problem when running both applications in the same cluster.
One solution would be to add a proxy container to the application pod and "trick" the application to connect to it instead when the application connects to the base URL.
The Jira proxy would then redirect Jira traffic to the Jira container within the pod and the Confluence proxy would redirect synchrony traffic to the synchrony service.
Additionally this proxy could be used by Jira and Confluence to reach each other using their respective services instead of the ingress controller.
The implementation could look something like this: https://github.com/ChampiYann/data-center-helm-charts/tree/local-proxy
Proposed network flow diagram:
graph TB
client --TCP/443--> ingress-controller
subgraph cluster
  ingress-controller --TCP/80--> jira-svc
  ingress-controller --TCP/80--> confluence-svc
  subgraph jira-ns
    jira-svc{jira-svc} --TCP/8080--> jira
    subgraph jira-pod
      jira --TCP/443--> jira-proxy[proxy]
      jira-proxy --TCP/8080--> jira
    end
  end
  subgraph confluence-ns
    confluence-svc{confluence-svc} --TCP/8090--> confluence
    synchrony-svc{synchrony-svc} --TCP/8091--> synchrony-pod
    confluence-proxy --TCP/80--> synchrony-svc
    subgraph confluence-pod
      confluence --TCP/443--> confluence-proxy[proxy]
    end
  end
end
jira-proxy --TCP/80--> confluence-svc
confluence-proxy --TCP/80--> jira-svc

Product
Jira, Confluence
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @ChampiYann , can I work on this ?

I don't see why not. You can start from the work I already did on my fork if you want.


Different color badges

Change color of badge by coverage result.
Also add -f flag to force overwrite output path.

Sorry for not responding earlier. I somehow missed this PR.
Awesome change, thanks @Samael500! :)
There's a last request I have - would you mind adding an option to manually override the color to a fixed value? Some people might prefer static colors.

Add -p flag for plain color mode.

Thanks!

PyPI release will follow tonight.

Version 0.2.0 is released: https://pypi.python.org/pypi/coverage-badge/0.2.0


workflow: fix the vitest bench ran twice

Our repo has two vitest config files, vitest.e2e.config.ts and vitest.unit.config.ts. these two config are responsible for different parts.
However. the same Benchmark was mistakenly run twice because the exclude and include for the benchmark needs to be configured separately.

This PR is no longer needed due to https://github.com/vuejs/core/commit/83430a35f4865f02e6ab1029add66bf36dd26c5c

Fixed in https://github.com/vuejs/core/commit/83430a35f4865f02e6ab1029add66bf36dd26c5c


Autumn blossoms update

Added Autumn Blossoms photo series and made minor updates and sanitized code.

Hey!
Sorry there, didn't see that your branch was selected when I made the pull.


UI Error on Order in Service Catalog

While performing a demo, user clicked on the order button and received this error.  Error continued to be thrown until the user did a page refresh, at which point it moved past the error.

Find it here:  https://gist.github.com/zackary-deems/a5313c0ef68d8b20869fc85bc0cb6803

@kavyanekkalapu Please take a look.

@zackary-deems I couldn't reproduce it with master. Are you using Morphy or Lasker?

Lasker

For what it's worth, I'm not sure what the steps are to reproduce this.  It was just normal clicking around the UI.  I get similar errors when I try to access the Settings accordion as a superadmin user OTHER than Admin.

@zackary-deems Thanks. I will check with lasker.

@zackary-deems I am not able to reproduce it in Lasker too. @Fryguy what else we can try?

It must be something specific to @zackary-deems 's setup?  Perhaps something in that middle nav that doesn't exist in our DBs?


clean imports

There where some unused imports, and set np.cov(X, rowvar=False) in place of calculate_covariance_matrix(X) to make the file more simple.

Isn't «calculate_covariance_matrix(X)» used to show all the process of machiene learning including covariance matrix calculating?…

You are right, than why we are using numpy in this project for the rest of our calculations?
I guess back than numpy did not have a .cov() available.
And would be better to not over compilicate things.


training vgg model E

I haven't had any luck training vgg model E from scratch using the example fbcunn code. After 20 epochs with a learning rate of 1e-2 (mom=.9, wd=5e-4), 10K epoch size, and 128 batch size on 4 Tesla K40's, I don't get any increase in training/test set accuracies or noticeable reduction in training loss. This seems very strange. I have not made any modifications to the example code and I have recent torch, nn, cunn, cudnn, and fbcunn modules. I don't experience any memory limitation errors using 128 batch size.
I've successfully trained alexnet with this code so I am wondering if anyone else has had luck with training vgg model E (or even model A) using the example code. The original paper states that they were successful with training model E not only by initializing some layers with model A pre-trained weights but /also/ by initializing model E weights using Xavier initialization which is what the nn code does.

If you want to train vgg model E from scratch using this code, you'll have to initialize the weights to MSR initialization.
Here's some code to do initialize weights according to different papers: https://github.com/e-lab/torch-toolbox/tree/master/Weight-init
The MSR initialization is referred to as "kaiming":
https://github.com/e-lab/torch-toolbox/blob/master/Weight-init/weight-init.lua#L43

Thanks a bunch, I'll give it a go.


Import-sorting (a ruff approximation of isort)

isort does have some wacky heuristics to determine first v third party, but ultimately I'd love to elide the import-sorting it does with ruff :zap:
To me, doesn't have to be 1:1, so long as the behavior is there for import sorting/grouping I'm happy :smile:
If we want to keep this in the realm of flake8, it'd be flake8-import-order with a fixer :wink:

(I continually dip my toe into Rust and even a little PyO3 as I work on pantsbuild) Perhaps one day I'll pick this up myself :wink:

Yes! I want to do this. I've been a little intimidated by the sheer amount of functionality that's packaged with isort, but we don't need to cover every possible setting right from the start.
I'm not certain if this will fit into the same "autofixable lint error" pattern, or if it will be its own sub-command.

A potential first approximation that delays dealing with the first vs. third party heuristic would be to sort only within import groups separated by existing blank lines. This would be isort-compatible in that it preserves a superset of the possible isort outputs.

I like this idea! In my case it's just Isort with the Black profile, that's pretty much what I would like. :nerd_face:

👍 I'm thinking that this should be a separate subcommand (ruff isort). I've been meaning to introduce subcommands anyway (such that the current ruff call becomes ruff check; and maybe ruff --fix becomes a standalone ruff fix?) since it opens the door to bundling a lot more functionality into ruff. The downside is that this will likely be a breaking change in the CLI API.

Can you explain a little why you think it'd need its own subcommand and not be folded (optionally, config-enabled) into ruff fix or ruff?
From my perspective seems like I'd need to run two commands when one would be sufficient.

You're probably right that it could be folded into ruff or ruff fix. I will aim for that outcome. My main concern is that in order to model this as an autofixable error under the current autofix API, I'll likely need to treat the entire unordered import section as a single violation with a single fix. And if there are unused imports in the import block, there will be conflicting fixes for that chunk of code, and we'll fail to autofix one of them due to the conflicting source code ranges (that is, we'll either fail to remove the import, or fail to reorder the block).
However, these are really deficiencies in the autofix API and not essential blockers to adding import-sorting as a "fixable lint error". And moving isort out to its own subcommand is arguably just a hack to get around these problems.
(One solution to this problem, which I don't love but is arguably already needed, is to iteratively re-check and autofix errors until there are no more fixable errors. So, e.g., you'd run ruff fix once, then internally, we'd check the file, find the unused import and the unsorted import block, and remove the unused import; we'd then re-check the modified source code, find the unsorted import block, fix that, etc.)
(Another solution is to try and develop a more semantically-aware fix API, or maybe something based on CRDTs (???), that lets you apply both "Reorder these statements" and "Remove this one statement" in a single pass.)

(I've started work on this tonight.)

 But I have to admit that I'm not a big fan of how isort sorts out-of-the-box. And prefer something like this:
[tool.isort]
profile = "black"
force_sort_within_sections = true
order_by_type = true  # Order by CONSTANT, CamelCase, snake_case

Mostly because it reduces noise in diffs when going back and forth between import foo and from foo import bar since the import would remain on the same line.
It's also bit jarring to make such a change, save, and then the line moves 10 lines up/down when you have "format on save" enabled in your editor.
But maybe that's just me 🤷♂ People seems to like separating import and from.

I noticed that isort seems to avoid merging from imports intentionally (this is the combine-as-imports setting).
That is, isort doesn't modify this block:
from .param_functions import Body as Body
from .param_functions import Cookie as Cookie

Whereas, if you omit the as alias, like so:
from .param_functions import Body
from .param_functions import Cookie

Then isort gives you:
from .param_functions import Body, Cookie

Here's an example from FastAPI (\cc @tiangolo):

There are some issues in isort suggesting that they wanted to make this the default (https://github.com/PyCQA/isort/issues/1305, https://github.com/PyCQA/isort/issues/1812).
I'm partial to making this Ruff's default, but curious if others feel strongly?

As long as
from .param_functions import Body as Body
from .param_functions import Cookie as Cookie

became
from .param_functions import (
    Body as Body,
    Cookie as Cookie,
)

and that still is kosher from mypy's "reexport" stance, I'd +1 the cleanup.

(I usually see in our codebase)
from .param_functions import Body as Body  # re-export
from .param_functions import Cookie

which I'd kinda prefer:
from .param_functions import (
    Body as Body,  # re-export
    Cookie
)

but I understand if that's prohibitively difficult to get right :wink:

Yeah that's what happens with the current implementation I have going -- you get:
from .param_functions import (
    Body as Body,
    Cookie as Cookie,
)

The main unsolved thing with my current implementation is that it removes and disregards comments. Comment handling is tricky (by this, I mean it's hard to know what the best behavior is, not that it's hard to implement).
You can see how isort handles comments -- if you start with this:
# comment 1a
# comment 1b
from .param_functions import (
	Body,  # comment 1c
	Header,  # comment 1d
)
# comment 2a
# comment 2b
from .param_functions import Cookie
from .param_functions import Request

...it becomes:
# comment 1a
# comment 1b
# comment 2a
# comment 2b
from .param_functions import Body  # comment 1c
from .param_functions import Header  # comment 1d
from .param_functions import Cookie, Request

(So, they move any line-level comments to the top of the import block, retain any end-of-line comments, and avoid merging statements with end-of-line comments.)

I don't feel strongly about this, what would matter to me the most would be compatibility with mypy, Black, and minimization of diffs, but apart from that, I'm fine with anything. 🚀

At the point now where I'm finishing all the test cases, so an initial version of this should go out in the next day or so. There will be a few limitations that I'll document and resolve later (e.g., doesn't preserve comments).

The first version of this is going out in v0.0.110. Feedback and Issues welcome!
There are two main limitations that I want to address in future PRs:

We don't preserve comments.
If you have unused and unsorted imports, Ruff will only fix one of those two problems in the first invocation, and you have to run ruff again to fix the remaining issue. (See: #660.)

If you're just using Ruff to sort imports, it's about 30x faster than single-threaded isort, and 10x faster than multi-threaded isort.
But... if you're already using Ruff for linting, the performance hit for adding import sorting on top of that existing workflow should be extremely negligible (in the 5s or 10s of milliseconds for CPython), since the majority of execution is spent on parsing the AST.
In other words: if you already use Ruff for linting, then using Ruff for import sorting should be basically "free".

Nice! I’ve opened these issues I ran into:

#673
#674
#675

Much appreciated!

So awesome! Amazing to see you build these things! 🚀🎉

v0.0.122 (which just hit PyPI) contains a bunch of compatibility improvements, including comment preservation, respecting isort: skip, and more. It's also about 10% faster than reported above.
If you're able to test it out on your projects, would love feedback, issues, etc.!

Fantastic thank you!
I noticed ruff will insert an empty line before comments (unlike isort), eg:
import yaml

# use importlib_resources backport for compatibility with python < 3.9
from importlib_resources import files

I presume this is a deliberate change.

It’s deliberate. isort --profile=black  inserts the same empty line, as does black itself.

I just integrated the zulip/zulip pull request to use this. ruff is amazing, thanks so much for building this!

That's awesome! Thanks @timabbott! Made my day :)

I saw Ruff insert a line between :
 import Cython.Compiler.Options

from Cython.Build import build_ext, cythonize

How can this be avoided, I am on version v0.0.286

How does one enable ruff's isort support? I have a project in which ruff format . works fine in general, but imports are not being sorted. I'm running ruff v0.1.3. ruff . also detects no issues.
Even import blocks as gross as
import jax
import copy
from typing import Optional
import jax.numpy as jnp
import jax.dlpack
import torch

import math

import functools

are immune to ruff's import formatting. OTOH, running isort --dont-follow-links . works just fine.

@samuela - Import sorting is currently part of the linter (ruff check --fix) rather than the formatter. So in this case, you'd want to add the following to your pyproject.toml:
[tool.ruff.linter]
# Enable the isort rules.
extend-select = ["I"]

Or, e.g., ruff check --select I --fix /path/to/file.py.
(We're continuing to discuss whether import sorting should be part of the formatter (ruff format), but it's a little tricky because -- unlike the rest of the formatter -- import sorting can actually change the behavior of your code.)

Thanks so much @charliermarsh ! Using [tool.ruff.linter], gave me an error: unknown field 'linter', but
[tool.ruff]
# Enable the isort rules.
extend-select = ["I"]

did the trick for me.
Thanks for all your hard work on ruff! 🏄♀

Oof, sorry, it's tool.ruff.lint -- my mistake. Will edit my original message. Really glad to get this working for you!

Thanks so much @charliermarsh ! Using [tool.ruff.linter], gave me an error: unknown field 'linter', but
[tool.ruff]
# Enable the isort rules.
extend-select = ["I"]

did the trick for me.
Thanks for all your hard work on ruff! 🏄♀

Sorry if I am asking a dumb question, but where in the documentation can I find an explanation of this behaviour and why it works?

 The generated documentation for that field is here: https://docs.astral.sh/ruff/settings/#extend-select. And a prose write-up on rule selection is here: https://docs.astral.sh/ruff/linter/#rule-selection.
(extend-select is like select, except it adds to the list rather than replacing it -- so extend-select = ["I"] enables the isort rules on top of the default rules, while select = ["I"] would enable only the isort rules.)
(You can use either [tool.ruff.lint] or [tool.ruff] right now. We're moving towards the former, but the latter is still supported and appears in all the docs at the moment.)

 The generated documentation for that field is here: https://docs.astral.sh/ruff/settings/#extend-select. And a prose write-up on rule selection is here: https://docs.astral.sh/ruff/linter/#rule-selection.
(extend-select is like select, except it adds to the list rather than replacing it -- so extend-select = ["I"] enables the isort rules on top of the default rules, while select = ["I"] would enable only the isort rules.)
(You can use either [tool.ruff.lint] or [tool.ruff] right now. We're moving towards the former, but the latter is still supported and appears in all the docs at the moment.)

Thank you for you thorough response. Can I also run the isort functionality from the command line?
Something like:
ruff --fix -["I"]

If somebody is wondering how to add this in pre-commit, use this
-   repo: https://github.com/charliermarsh/ruff-pre-commit
    rev: v0.2.0
    hooks:
    -   id: ruff
        args: ["check", "--select", "I", "--fix"]
    -   id: ruff-format

[tool.ruff.lint]
# Enable the isort rules.
extend-select = ["I"]

This works for both ruff-pre-commit with example configuration and ruff-vscode.

@Insighttful see this issue for tracking: https://github.com/astral-sh/ruff/issues/6371


Fix a few problems in instructions and setup for running a custom backend

This evening I tried following the instructions in CONTRIBUTING.md for running dart-pad with a local dart-services backend and found two small problems:

The substitution that replaced the official server address with the user-specified address didn't work because it referred to an obsolete host - the current host is here (though there may be some problems related to the new null-safe host).

The instructions in CONTRIBUTING.md indicated that the backend server would start on port 8002 when actually it was configured for port 8082.

@domesticmouse Should this be merged, or are we waiting on any other changes?
I think both 8002 and 8082 are used in differrent places for serving the app, so standardizing seems like a good idea to me. Likewise, though the original endpoint still works, moving to the new one also seems like a good plan (though TBH, I can't remember the last time I used the serveCustomBackend grinder task).

Actually, I think this PR is due to changing the default target to v1, as the local serving changes from default target to localhost. Landing this PR as is.


Move providers under their own package

Codecov Report

Merging #427 (3d8a959) into main (070f984) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #427      +/-   ##
============================================
- Coverage     93.95%   93.93%   -0.03%
+ Complexity     2006     2005       -1
============================================
  Files           222      222
  Lines          4021     4021
  Branches        384      384
============================================
- Hits           3778     3777       -1
- Misses          146      150       +4
+ Partials         97       94       -3

Impacted Files
Coverage Δ

src/main/java/net/datafaker/FakeCollection.java
86.53% <ø> (ø)

src/main/java/net/datafaker/Faker.java
66.66% <ø> (ø)

.../main/java/net/datafaker/idnumbers/EnIdNumber.java
100.00% <ø> (ø)

...ain/java/net/datafaker/idnumbers/EnZAIdNumber.java
91.66% <ø> (ø)

...ain/java/net/datafaker/idnumbers/EsMXIdNumber.java
100.00% <ø> (ø)

.../main/java/net/datafaker/idnumbers/NricNumber.java
96.42% <ø> (ø)

...main/java/net/datafaker/idnumbers/PeselNumber.java
100.00% <ø> (ø)

...in/java/net/datafaker/idnumbers/PtNifIdNumber.java
100.00% <ø> (ø)

...ain/java/net/datafaker/idnumbers/SvSEIdNumber.java
100.00% <ø> (ø)

...ain/java/net/datafaker/idnumbers/ZhCnIdNumber.java
95.74% <ø> (ø)

... and 200 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Speeding up mulE

mulE description says return a*exp[b] over GF(2^r) so it's a simple multiplication in GF(2^r) optimizable with PSHUFB. they just precompute logarithms of twiddle factors to speed up their implementation

I sent an Email to the authors and they have been responding actually!  You're totally right; I missed that the operation looks like a multiplication.  But the problem is still that we can't use 4-bit table lookups to perform the operation:
For a normal GF(2^^16) I can do this successfully:
const uint16_t yy = GF256Ctx.GF256_LOG_TABLE[y];
for (int i = 0; i < bytes; ++i)
{
    const uint16_t xx1 = GF256Ctx.GF256_LOG_TABLE[x[i] & 0x00ff];
    uint8_t value1 = GF256Ctx.GF256_EXP_TABLE[xx1 + yy];
    const uint16_t xx2 = GF256Ctx.GF256_LOG_TABLE[x[i] & 0xff00];
    uint8_t value2 = GF256Ctx.GF256_EXP_TABLE[xx2 + yy];

    z[i] ^= value1;
    z[i] ^= value2;
}

But the same does not work for mulE:
    const GFSymbol sum1 = static_cast<GFSymbol>(AddModQ(GFLog[a &

0x00ff], z));
GFSymbol value1 = GFExp[sum1];
const GFSymbol sum2 = static_cast(AddModQ(GFLog[a &
0xff00], z));
GFSymbol value2 = GFExp[sum2];
    vx[i] ^= value1;
    vx[i] ^= value2;

This causes the decoding to fail...  I'm stuck =(

it SHOULD work, we just need to pint out the culprit.

instead of checking whether decoding work you can print immediate computation results and compare them for original mulE and any modification. or just check that modified mulE returns the same result as original one for any x,y pair

fast phusfb-based multiplication in GF(65536) was employed by MultiPar, RAR5 and GF-Complete (and described in "screaming fast galois field arithmetic" paper). afair the point is that you split each number into 4 4-bit parts, but you better to look into paper

the first code you provided is clearly GF(256). i can't find bugs in the second code, but i just don't remember details of GF(2^n) operation

you can find gf-complete at http://jerasure.org/ , on github and bitbucket

i still don't understand - is mulE just a simple multiplication, or something else?
the formula exp[(log[a]+b &mod) + (log[a]+b >>len)] is equivalent to exp( (log(a)+b) mod (size-1)) and it seems proper code for a*exp[b] in GF(size) since 2^(size-1)==1
@SianJhengLin, can you clarify that mulE is indeed a*exp[b] in choosen field? in that case, it doesn't need any optimization on your side - the pshufb technique is directly applicable to this code

It is true that mulE returns a*exp[b] over GF(2^^m). However, the elements of GF(2^^m) are represented in a special basis, rather than the monomial basis. Hence the conventional field multiplications cannot be applied directly.

even if mathematically it's diferent, algorithmically it seems the same as ordinal multiplication, may be just with different log/exp table - unless i misunderstand something. let's see: for multiplication of non-zero values you use formula
   a*b = exp( log(a) + log(b) )

also, you reduce log(a)+log(b) modulo size-1 since 2^(size-1)=1
i think that it can be implemented using existing GF multiplication code, may be with different exp/log tables
Chris, may be you can try to apply your GF(256) code with their expr/log tables? And start with GF(256) implementation to simplify transformation (instead of GF(65536))

Okay Dr. Lin figured it out.  We just have to change the basis from Cantor to monomial:
GFSymbol kGFBasis[kGFBits] = {
1, 2, 4, 8, 16, 32, 64, 128
//    1, 214, 152, 146, 86, 200, 88, 230
};
And now this works:
    const GFSymbol sum = static_cast<GFSymbol>(AddModQ(GFLog[a], z));
    GFSymbol value = GFExp[sum];

    GFSymbol sum1 = static_cast<GFSymbol>(AddModQ(GFLog[a & 0x0f], z));
    GFSymbol value1 = GFExp[sum1];
    if ((a & 0x0f) == 0)
    {
        value1 = 0;
    }
    GFSymbol sum2 = static_cast<GFSymbol>(AddModQ(GFLog[a & 0xf0], z));
    GFSymbol value2 = GFExp[sum2];
    if ((a & 0xf0) == 0)
    {
        value2 = 0;
    }

    LHC_DEBUG_ASSERT(value == (value1 ^ value2));

I'm going to resume work on the codec using normal GF mul ops =)

i think you are missed the whole point - we use Cantor basis because it's required for so-called additive FFT. Of course, multiplication will work correctly in monomial basis, but not additive FFT. At least i think so - if it was possible to implement additive FFT in monomial basis, the "Novel basis" paper authors can skip most part of their work, significantly simplifying the entire algorithm and math behind it

Cantor basis is working too.  The important fix was the two extra if-statements that map LUT[0] to 0.

oh, afair avoiding check for zero require to double the table size. it was done in GF(256) code from your libraries but not in the "novel polynomial" code

Yeah I forgot about that ^_^


Change the type name of the "Venue" to "UnifiedSearchVenue"

LIIKUNTA-336.
The Venue type name is already taken in the supergraph
where there is TPRek merged in to it.
Related to https://github.com/City-of-Helsinki/events-helsinki-monorepo/pull/108, https://github.com/City-of-Helsinki/events-helsinki-monorepo/pull/109 and https://github.com/City-of-Helsinki/events-helsinki-monorepo/pull/110.
NOTE: The change of this PR should not affect any how to the running production services, because the Unified-Search is in active use only in the Liikunta-Helsinki.
NOTE 2: The current production version of Liikunta-Helsinki is built from the Liikunta specific old deprecated repo https://github.com/City-of-Helsinki/liikunta-helsinki. The new version of the Liikunta is hosted in https://github.com/City-of-Helsinki/events-helsinki-monorepo. The old deprecated version does not need this change and probably this should not be merged before the Liikunta service is deployed to the production from the monorepo. Anyway, this should affect only in the types generation, and not in the handling of requests anyhow.

Venue has been renamed to UnifiedSearchVenue, see PR #104 and PR #105.


Make more settings for the Checkmarx builder configurable; change BDDSecurityBuilder scm config

also adds .git to excluded folders

@marcesher Please update groovydoc and examples

@imuchnik done


The data of the video file transmitted through MultipartFile cannot be passed in through the pipe, and an error is reported as invalid input, and then it is changed to a local file and then transferred to the buff when outputting.

The data of the video file transmitted through MultipartFile cannot be passed in through the pipeline, and an error is reported as invalid input, then it is converted to a local file, and it is converted to buff when outputting. In this way, the call can be completed, but after the buff is input, the parameters of the video cannot be obtained. such as playback time
pipeline：
newByte := new(bytes.Buffer)
err = ffmpeg.Input("pipe:",ffmpeg.KwArgs{}).
Output("pipe:", ffmpeg.KwArgs{"c:v": "copy", "f": "flv"}).
OverWriteOutput().
WithInput(reader).
WithOutput(newByte, os.Stdout).
Run()
local：
newByte := new(bytes.Buffer)
err := ffmpeg.Input(Name,ffmpeg.KwArgs{}).
Output("pipe:", ffmpeg.KwArgs{"c:v": "copy", "f": "flv"}).
WithOutput(newByte, os.Stdout).
Run()

It's probably irrelevant for the author at this point, but after testing the command manually, i've found out you have to specify output file format if using pipe.
So in my case i had to change this:
ffmpeg.Input("pipe:0").WithInput(input).
         Output("pipe:1", ffmpeg.KwArgs{
	    "acodec": "libopus",
         }).WithOutput(output).
	OverWriteOutput().
	Run()

To this:
ffmpeg.Input("pipe:0").WithInput(input).
	Output("pipe:1", ffmpeg.KwArgs{
		"acodec": "libopus",
		"f":      "ogg", // this in particular
	}).WithOutput(output).
	OverWriteOutput().
	Run()


README: Debian link is 404

README links to https://herrhotzenplotz.de/gcli/pkg/Debian, which is 404:

Not Found
The requested URL was not found on this server.

I removed the links from the readme. The packages for Debian/Devuan
weren't really maintained and only there for experimentation. However
since sjr submitted a real Debian package I suggest you look at
that. See https://ftp-master.debian.org/new/gcli_2.0.0-1.html.


Could not authenticate with provided credentials

I've been using Auth2 method of getting tokens, once the generated monzo.json file was made I was using the following line of code which only works for like a day until I get the error below, has anyone had the same or know whats causing it?
oclient = MonzoOAuth2Client(client_id, client_secret).from_json()
client = Monzo.from_oauth_session(oclient)

["Traceback (most recent call last):
File "/home/ubuntu/.local/lib/python3.6/site-packages/monzo/auth.py", line 107, in make_request
self.session.request(method, url, data=data, **kwargs))
File "/home/ubuntu/.local/lib/python3.6/site-packages/requests_oauthlib/oauth2_session.py", line 330, in request
http_method=method, body=data, headers=headers)
File "/home/ubuntu/.local/lib/python3.6/site-packages/oauthlib/oauth2/rfc6749/clients/base.py", line 198, in add_token
raise TokenExpiredError()
oauthlib.oauth2.rfc6749.errors.TokenExpiredError: (token_expired)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "auth_test.py", line 24, in
balance = client.get_balance('acc_00009U1x5f20Agu9wEFoS9')
File "/home/ubuntu/.local/lib/python3.6/site-packages/monzo/monzo.py", line 132, in get_balance
response = self.oauth_session.make_request(url, params=params)
File "/home/ubuntu/.local/lib/python3.6/site-packages/monzo/auth.py", line 110, in make_request
self.refresh_token()
File "/home/ubuntu/.local/lib/python3.6/site-packages/monzo/auth.py", line 160, in refresh_token
auth=HTTPBasicAuth(self.client_id, self.client_secret)
File "/home/ubuntu/.local/lib/python3.6/site-packages/requests_oauthlib/oauth2_session.py", line 309, in refresh_token
self.token = self._client.parse_request_body_response(r.text, scope=self.scope)
File "/home/ubuntu/.local/lib/python3.6/site-packages/oauthlib/oauth2/rfc6749/clients/base.py", line 415, in parse_request_body_response
self.token = parse_token_response(body, scope=scope)
File "/home/ubuntu/.local/lib/python3.6/site-packages/oauthlib/oauth2/rfc6749/parameters.py", line 425, in parse_token_response
validate_token_parameters(params)
File "/home/ubuntu/.local/lib/python3.6/site-packages/oauthlib/oauth2/rfc6749/parameters.py", line 432, in validate_token_parameters
raise_from_error(params.get('error'), params)
File "/home/ubuntu/.local/lib/python3.6/site-packages/oauthlib/oauth2/rfc6749/errors.py", line 405, in raise_from_error
raise cls(**kwargs)
oauthlib.oauth2.rfc6749.errors.InvalidClientIdError: (invalid_request) Could not authenticate with provided credentials"](url)

Which version of requests_oauthlib do you have?

I downgraded it to 1.0.0

Could it be this? Are you refreshing the tokens given to you?
Any example code snippet I can use to recreate this (please omit any sensitive data).

I made a client as Confidencial with a redirect url to http://localhost/ and running it on an AWS inststance and it looks like monzo.json has a refresh token,
I generate the monzo json file first with:
auth_start_url =  MonzoOAuth2Client(client_id, client_secret).authorize_token_url()
print(auth_start_url)

then I paste the code I get to:
code = 'CODEHERE'
MonzoOAuth2Client(client_id, client_secret).fetch_access_token(code)

which seems to work when I use this but only for a day or so
oclient = MonzoOAuth2Client(client_id, client_secret).from_json()
client = Monzo.from_oauth_session(oclient)

@NordineKB that is odd. Looking at the original trace you send, it looks like there's an issue with refreshing the token. I'll look into this for you.

Many thanks 👍 @muyiwaolu

@NordineKB just a heads up, still looking into this. I'm going to wait a day for the expiry on a test project I have and see if I can replicate your issue.

@muyiwaolu Any luck replicating it? I've created a new confidential client and I got the same issue today

Any news? I got a similar problem.

@streetpunkpl Hi, yes I've figured out a way around it, I'll post my fix later today

@NordineKB Thanks so much. It will help me a lot.

@streetpunkpl
Essentially in auth.py (https://github.com/muyiwaolu/monzo-python/blob/dev/monzo/auth.py) the way it requests tokens is wrong. I've had a look at the API documentation and it needs to be some thing like:
def refresh_token(self):         """Step 3: obtains a new access_token from the the refresh token         obtained in step 2. Only do the refresh if there is token_updater(),`
which saves the token.
        :rtype: A Dictionary representation of the authentication token.
    """
    filename=MONZO_CACHE_FILE
    token = load_token_from_file(filename)
    client_id = token.get(CLIENT_ID)
    client_secret = 'PUTYOURCLIENTSECRETHERE'
    refresh_token = token.get(REFRESH_TOKEN)

    token = self.session.refresh_token(
        MonzoOAuth2Client._refresh_token_url,
        body=urllib.parse.urlencode({'grant_type': 'refresh_token','client_id':client_id,'client_secret':client_secret,'refresh_token':refresh_token})
        )

    token.update({CLIENT_SECRET: self.client_secret})

    if self.session.token_updater:
        self.session.token_updater(token)

    return token`

This is a bit hacky and I'm sure someone can write a cleaner way of fixing it without pasting in the client secret. I might make a PR if I get the time to but this code fixed it for me :)

Man send me your PayPal.me link if it's working I'm gonna tip you for ☕ :P

@streetpunkpl Happy to help! let me know if it works for you

@NordineKB Your fix works FLAWLESSLY! Thank you so much :))))

@NordineKB awesome fix! I'll integrate it.


Module 1 exercises [Prosper Kwame Detornu]

Module 1 exercise 2 [Prosper Detornu].pdf
Module 1 exercises [Prosper Detornu].pdf

Please "drag & drop" exercise 1 pdf file below.

Please "drag & drop" exercise 2 pdf file below.

Please UPDATE THE TITLE of this "Issue" in the title bar above with your name.

If you haven't done so, please go back to Module 1 and make sure to take
the post-training survey. Participating in surveys is required for receiving
the "GALUP Certificate" by the University of Florida.

Well done, Prosper. You clearly grasped the material outlined in Module 1 and successfully applied it to these exercises. Thank you for your participation! Please be sure to fill out the post-Module survey before you begin the next Module.


Tests (via Karmatic)

I took a second to check if @surma's testing PR could be done with Karmatic, and once I patched that lib to work with Webpack 4 it does!  This has the advantage of using webpack inside Karma, so there's no configuration needed (it inherits our webpack config).

Definitely want @kosamari and  @jakearchibald to take a look before merging, tho.

Updated to fix issues & merge master.
We ended up with a package-lock in here - is that intentional?

I was surprised we don’t have a package-lock.json on master, honestly. For an app, we should always commit it. @jakearchibald wdyt?

If we commit the lockfile, I think it would be nice to have git set up to diff it without generating conflicts. Something like npm-merge-driver would work.

I’m gonna close this and get back to this if we get considerable community activity.


Chat Interface prints room description on user entry.

Not sure if this is something i want to implement just yet, future plans is to have UI read it to user...or have room generated based on description and then read it to user. Phil was working on room generation based on description using luis. I should ask.

(Phil's "room generation" thing was not a LUIS thing.)


Collect Hajs from AWS

@mik-laj this is about filling this form?
https://aws.amazon.com/blogs/opensource/aws-promotional-credits-open-source-projects/


Data connector ISpreview-false to true

Required items, please complete
Change(s):

ISpreview changed from false to true

Reason for Change(s):

For data connector title

Version Updated:

yes

Testing Completed:

See guidance below

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

/Package


[Feature] JFXCheckBoxTreeItem

Javafx has a special tree item that works as a checkbox. It selects all the children when in a checked state and becomes indeterminate when only some of the children are checked.
http://docs.oracle.com/javafx/2/ui_controls/tree-view.htm
Example 13-5 shows an implementation of this. Currently there isn't one for JFXCheckBoxes.

Hello,
it's more of a custom tree cell (there are many examples online), feel free to add your own contribution to JFoenix.
Regards,


[#142059793] Remove Hector from admin users and commit signers

What
Hector has left the team. His accounts in staging and production will be manually cleaned up.
How to review
Check if correct data has been removed.
Who can review
Not @paroxp

👍  confirmed key. Will merge when Travis has finished.
😢  👋  @keymon


[pred-memopt] Provide normal succ manipulation methods on TermInst in…

…stead of SILBasicBlock.
I am doing this for a few different reasons:

The code for manipulating successors was partially in TermInst (with
SILBasicBlock delegating to TermInst) and partly in SILBasicBlock itself. It
makes more sense to just be consistent and move all said functionality into
TermInst and just always delegate to SILBasicBlock.

I am preparing an API around gathering all critical edges. All of the
critical edge breaking APIs to take a TermInst. I wanted to use some of the
successor APIs, only to discover that we were not delegating to TermInst.  By
moving said functionality onto TermInst itself and delegating, we have it in
both places.

rdar://31521023

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Just splitting off of a larger commit.

@swift-ci smoke test and merge


Redis-ha ServiceAccount

Adds option to set Kubernetes Service Account required on GKE deployments by default

Thank you for contributing to kubernetes/charts. Before you submit this PR we'd like to
make sure you are aware of our technical requirements and best practices:

https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements
https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices

For a quick overview across what we will look at reviewing your PR, please read
our review guidelines:

https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md

Following our best practices right from the start will accelerate the review process and
help get your PR merged quicker.
When updates to your PR are requested, please add new commits and do not squash the
history. This will make it easier to identify new changes. The PR will be squashed
anyways when it is merged. Thanks.

/assign @mgoodness

Closing since this change was applied to another branch and it's conflicting.


[RFC] Find and replace

This is a Proof of concept Find & Replace that finds text if there are is no format mismatch, eg. not spread across multiple text nodes. Right now, it highlights the found text, next step is to replace it with a MarkNode that is local to the user searching.
The current logic is not efficient. If someone has an efficient scrolling window algo for the text spread across spans, please reach out. Have to clean up CSS as well.
https://github.com/facebook/lexical/assets/7893468/eff62bd1-c64a-46f8-8e5b-0ea8919b6b22

Sadly don't have enough time to invest in moving this PR forward, if someone else is more keen on creating a proper one should go ahead.


Don't log in demo mode

[#180522053]

Merging pre-review since it's a small change and want to make sure it gets into the testing pipeline.


Add nox to excludes

This adds the .nox directory to the excludes in pyproject.toml alongside .tox to avoid unnecessary checks of embedded python files.
Closes #71

Good idea, thanks @zklaus !


[SPARK-43886][PYTHON] Accept generics tuple as typing hints of Pandas UDF

What changes were proposed in this pull request?
Accept generics tuple as typing hints in Pandas UDF.
Why are the changes needed?
Adapt to PEP 585 with Python 3.9.
Does this PR introduce any user-facing change?
Yes. tuple is accepted as typing hints of Pandas UDF.
FROM
>>> @pandas_udf("long")
... def multiply(iterator: Iterator[tuple[pd.Series, pd.DataFrame]]) -> Iterator[pd.Series]:
...   for s1, df in iterator:
...     yield s1 * df.v
...
Traceback (most recent call last):
...
    raise PySparkNotImplementedError(
pyspark.errors.exceptions.base.PySparkNotImplementedError: [UNSUPPORTED_SIGNATURE] Unsupported signature: (iterator: Iterator[tuple[pandas.core.series.Series, pandas.core.frame.DataFrame]]) -> Iterator[pandas.core.series.Series].

TO
>>> @pandas_udf("long")
... def multiply(iterator: Iterator[tuple[pd.Series, pd.DataFrame]]) -> Iterator[pd.Series]:
...   for s1, df in iterator:
...     yield s1 * df.v
...
>>> multiply._unwrapped.evalType
204  # SQL_SCALAR_PANDAS_ITER_UDF

How was this patch tested?
Unit tests.

@HyukjinKwon @ueshin @zhengruifeng would you please review that?

Merged to master.

cc @harupy FYI


[Feature Request] Style Setting option to disable the animation

Describe the change you'd like
There are themes which provides an option to disable the animations. I would love to have it in this theme as well. I have seen this reduces the CPU usage to a quite good extent so a worth option to have in the settings.
Love your theme, it looks great !

true, i was thinking about this too


execution error: Finder got an error: AppleEvent timed out. (-1712)

Description
I am hitting this issue running java jpackage from an AdoptOpenJDK install with the github runner.
 Current runner version: '2.273.0'
Operating System
  Mac OS X
  10.15.6
  19G2021
Virtual Environment
  Environment: macos-10.15
  Version: 20200829.1
  Included Software: https://github.com/actions/virtual-environments/blob/macos-10.15/20200829.1/images/macos/macos-10.15-Readme.md

2020-09-03 00:48:36.975 diskimages-helper[1172:8455] _postflightMountPointsAfterDAMount: disk2 aborting because no mount point found.
/dev/disk2          	GUID_partition_scheme
/dev/disk2s1        	Apple_HFS                      	/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/jdk.incubator.jpackage6368649391411397710/images/packit
Running [/usr/bin/SetFile, -c, icnC, /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/jdk.incubator.jpackage6368649391411397710/images/packit/.VolumeIcon.icns]
Running [/usr/bin/SetFile, -a, C, /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/jdk.incubator.jpackage6368649391411397710/images/packit]
Running [osascript, /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/jdk.incubator.jpackage6368649391411397710/config/packit-dmg-setup.scpt]
/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/jdk.incubator.jpackage6368649391411397710/config/packit-dmg-setup.scpt:60:109: execution error: Finder got an error: AppleEvent timed out. (-1712)
java.io.IOException: Command [osascript, /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/jdk.incubator.jpackage6368649391411397710/config/packit-dmg-setup.scpt] exited with 1 code
	at jdk.incubator.jpackage/jdk.incubator.jpackage.internal.Executor.executeExpectSuccess(Executor.java:73)
	at jdk.incubator.jpackage/jdk.incubator.jpackage.internal.IOUtils.exec(IOUtils.java:179)
	at jdk.incubator.jpackage/jdk.incubator.jpackage.internal.IOUtils.exec(IOUtils.java:150)
	at jdk.incubator.jpackage/jdk.incubator.jpackage.internal.MacDmgBundler.buildDMG(MacDmgBundler.java:348)
	at jdk.incubator.jpackage/jdk.incubator.jpackage.internal.MacDmgBundler.bundle(MacDmgBundler.java:75)
	at jdk.incubator.jpackage/jdk.incubator.jpackage.internal.MacDmgBundler.execute(MacDmgBundler.java:451)
	at jdk.incubator.jpackage/jdk.incubator.jpackage.internal.Arguments.generateBundle(Arguments.java:641)
	at jdk.incubator.jpackage/jdk.incubator.jpackage.internal.Arguments.processArguments(Arguments.java:514)
	at jdk.incubator.jpackage/jdk.incubator.jpackage.main.Main.execute(Main.java:97)
	at jdk.incubator.jpackage/jdk.incubator.jpackage.main.Main.main(Main.java:51)

Area for Triage:
Scripting and command line
Apple
Bug:
Virtual environments affected

[X] macOS 10.15
[ ] Ubuntu 16.04 LTS
[ ] Ubuntu 18.04 LTS
[ ] Ubuntu 20.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Expected behavior
No exception build
Actual behavior
Running jpackage on Mac OS runner throws exception after timeout every run. Since this happens every build, and github charges you 10x1 for minutes in private accounts, this has a huge impact on github actions alloted time.
Similar closed issue? #553
Repro steps
https://github.com/mitm001/packit/actions
Pick any build, all have MacOs build.

Install AdoptOpenJDK
#https://github.com/joschi/setup-jdk

name: Set up OpenJDK
uses: joschi/setup-jdk@v2
with:
java-version: ${{ matrix.java }}
architecture: x64

Run gradle.build packit command from repo.

Could be related to the active issue about modal window https://github.com/actions/virtual-environments/issues/1520

Hi @mitm001! Small update: I'm able to reproduce the issue, here is the screenshot on what's happened in the VM

We'll investigate possible solutions.

@mitm001 could you please add these lines before ./gradlew build? This resolves the issue for me
JavaPath=$(which java)
sqlite3 "$HOME/Library/Application Support/com.apple.TCC/TCC.db" "insert into access (service, client, client_type, allowed, prompt_count, indirect_object_identifier_type, indirect_object_identifier) values ('kTCCServiceAppleEvents', '$JavaPath', 1, 1, 1, 0, 'com.apple.finder')"

Yes, this works. Thank you.
I am not familiar with this, is this something I should open another issue on?
DI_kextDriveDisconnect: could not disconnect from IOHDIXHDDrive object - 268435459
diskimages-helper: DI_kextDriveDisconnect returned 268435459 ((ipc/send) invalid destination port).

2020-09-03 16:28:43.912 diskimages-helper[1032:6951] _postflightMountPointsAfterDAMount: disk2s1 aborting because disk image has no band size specified.
2020-09-03 16:28:43.913 diskimages-helper[1032:6954] _mountDevEntries: disk2s1 aborting mountpoint postflight because disk image has no band size specified.
2020-09-03 16:28:43.915 diskimages-helper[1032:6951] _postflightMountPointsAfterDAMount: disk2 aborting because no mount point found.

@mitm001 it looks like some sort of warning,  I haven't seen such kind of errors before and judging by the logs the package created successfully after all
DIDiskImageNewWithBackingStore: CUDIFDiskImage
DIDiskImageNewWithBackingStore: instantiator returned 0
Elapsed Time:  1.050s
File size: 58752880 bytes, Checksum: CRC32 $69DF94F9
Sectors processed: 322772, 281644 compressed
Speed: 130.9Mbytes/sec
Savings: 64.4%
DIDiskImageConvertWithDiskImage: converter returned 0
created: /Users/runner/work/1/s/packit/build/jpackage/packit-2.1.0.dmghdiutil: convert: result: 0

Result DMG installer for packit: /Users/runner/work/1/s/packit/build/jpackage/packit-2.1.0.dmg.
Succeeded in building Mac DMG Package package

Ok, I will close this, thanks for the fix.


ADD THE GSSOC TIMELINE AND POINT SYSTEM TO README

I WOULD LIKE TO WORK ON THIS ISSUE UNDER GSSOC'23


BROOKLYN-440: ssh not use StreamGobbler for logging stdout

Improves thread usage when executing ssh remote commands. Simplifies the code to use a new LoggingOutputStream, rather than using the StreamGobbler thread.
@neykov I'd appreciate your thoughts. It only does the first part of https://issues.apache.org/jira/browse/BROOKLYN-440; it doesn't do your suggestion of having the single thread polling to see if the streams have any bytes available.

retest this please

@neykov @geomacy Do you think I need to worry about multi-threaded calls to this new LoggingOutputStream stream's write, flush and close methods?!

@aledsage I'm fine with not updating the code to handle multi-threaded calls. Would be nice if you mark it explicitly as not supported it in the docs. It's been used just fine as is and we'll keep using it in the same context as before where it's single threaded.

@neykov @geomacy thanks for comments - I've added another commit to address those. Could you review again please?

Failure unrelated?
Retest this please.


Suggesting Pull request naming convention change needed after merge Pull request

In Github, so called "Pull request", once a request to merge code in to another branch often named as "Master" called "Pull request" as it should be accepted pull request or merged request.Kindly please look in to this issue.

Hi, I believe this is a question about GitHub.com, the website. This issue tracker is for a command-line utility called hub, not the website itself. For reporting bugs and requesting features for GitHub the website, please visit https://github.com/contact. Thank you!


Move get_file and save_file to ConfigurationManagementMixin

In moving, the methods become settings_for_resource_yaml and
add_settings_for_resource_yaml, respectively.  The old interfaces are
still left intact temporarily until the UI is changed to use the new
methods.
Also preserved is the special activation that is currently done for
ntp_reload, as introduced in ManageIQ/manageiq@939524fa, which avoids
repeated activation for every worker, instead preferring to do it once
at the server level.
Replaces https://github.com/ManageIQ/manageiq/pull/17458
@carbonin Please review
cc @h-kataria

@carbonin While I left the yaml interface here in this PR, I'm wondering if instead that should just live in the advanced_settings screen directly, essentially moving the yaml handling code and the password encryption/decryption there.

Not changing the YAML.load calls as rubocop wants.

@Fryguy tested it with https://github.com/ManageIQ/manageiq-ui-classic/pull/3967, seems to work :+1:

@carbonin Fixed.  Also, I added an extra spec for the different types of YAML failures, and there's a note above about the changes to how it's rescued (not sure you saw those changes in your review)

I am not fixing the https://www.rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/RescueStandardError.  I just disagree with it and am going to open a PR to guides to change the default.

@carbonin Done for real now.
Also, thoughts on https://github.com/ManageIQ/manageiq/pull/17494#issuecomment-392918382 ?

While I left the yaml interface here in this PR, I'm wondering if instead that should just live in the advanced_settings screen directly, essentially moving the yaml handling code and the password encryption/decryption there. Thoughts?

I guess it depends on if you want that to be a "supported API" or if that's just a quirk of the way we are displaying things. I'm fine with either, but I think it only makes sense if we admit that saving the whole YAML at once is an exception rather than the norm.


London worker classification

Notebook
Adds a prelim notebook for person classification as 'able to wfh' and 'key worker' - based on NOMIS employment stats for London. The methodology is pretty janky:

using SOC2010 level 2 employment categories (this is currently a big dictionary in the notebook):
1.1 manually map to lopops occupation categories
1.2 manually classify as  'able to wfh' and 'key worker'
based on london population for each category (gender, occ and work status (ft/pt):
2.1 wrangle tables so that frequencies are exposed for  'able to wfh' and 'key worker'
2.2 convert to probability based on frequency
2.3 build distribution dicts

eg:
{'occ1': {'ft': {'male': 0.5, 'female': 0.4}...
Note that the distribution for each point is binary, ie probability of being key worker.
I am very happy to take feedback on the mappings or the methodology - feels wrong at the moment.
Code
Also made some small changes to the attribute sampler so that if it fails to find a key it returns False. This behaviour is controlled by the value careful and set as default to not be careful, ie to return False. I like this behaviour because then the input distribution dictionaries do not need to be exhaustive.
For example in the case of work from home, a person with work status in education would be missing from the distribution dictionary, rather than failing it is useful to return False.
However, this does facilitate silent fails if a distribution dict is miss specified.

If I read this correctly (and I may be wrong), I think you need to apply either step 1 or 2 - but not both.
Given occupation, the probability of being a key worker is the same regardless of gender: P(key_worker|occ)=P(key_worker|occ,male)=P(key_worker|occ,female).
The different demographic composition of each occupation category is already represented in the demand matrix, so even if the same probabilities are applied by gender/ employment status, the resulting matrix will still capture the distribution which (I think) you are aiming for with step 2.
You can also do the reverse (with step 2): find the demographic characteristics of key workers and calculate probabilities to apply (based on gender/employment status), but leaving occupation field outside the distribution dictionaries, as it would have already been embedded in the results.
Let me know of any thoughts.

@Theodore-Chatziioannou
So my defence is that i am using the additional SOC2010 distribution data for gender and work-status to better assign the probability of being a key-worker (for example) within an occupation group.
So i guess i disagree that: P(key_worker|occ)=P(key_worker|occ,male)=P(key_worker|occ,female)
becasue within each occupation group (from lopops) there are multiple soc2010 codes which have a distribution of key/not key across gender for example.
Non mathematically: given person A who has occ1 i see that they are one of N possible SOC2010 codes, some of which are labelled key, some not. I then sample based on gender and employment status to more sensibly assign key from within this group of SOC2010 codes.
A concern is that the distribution of gender and employment status across the occ categories will (probably) be different from teh lopops and SOC2010 data.
ie; P_lopos(male|occ) != P_soc2010(male|occ)
Which i think is agreeing with your point that "The different demographic composition of each occupation category is already represented in the demand matrix," - but I am using my mapping to soc2010 codes to deterministically sample from that distribution.
Does that make sense?

@fredshone
Thanks Fred, I see what you mean now and makes sense to me. The grouping in the build_dist() function is not making the key worker designation dependent on demographics, but rather their occupation within an occupation group. Which is better to what I had in mind, so I 'm happy with the approach :) .


Run top command in Pod without tty=true get OOMKilled event

With this Pod:
apiVersion: v1
kind: Pod
metadata:
  name: img
  namespace: default
spec:
  runtimeClassName: kata
  restartPolicy: Never
  containers:
    - image: ubuntu #docker.io/containerstack/alpine-stress:latest
      name: ctr1
      env:
      - name: CONTAINER_NAME
        value: ctr1
      command:
        - top
      resources:
        limits:
          cpu: '2'
        requests:
          cpu: '2'

The pod will get OOMKilled after created.
Add this will OK:
      tty: true

The OOMKilled may be not correct.

Close it because it's created in a wrong repo.


Terminal + WSL + Fish shows spurious characters on every line

VS Code Version: 1.55.2 (System x64)
OS Version: W10 20H2 x64

See the image above. For some reason, the unique combination of VS Code on Windows + ConPTY + WSL + fish causes a spurious "h" character to appear on every line. When resizing the terminal window by just one pixel, these spurious characters disappear and everything is fine. This does not occur when:

using bash, zsh, or any other terminal
using fish in a different WSL install
running VS Code on WSL Remote
using WinPTY instead of ConPTY
using this shell in any other terminal (Tilix on WSL, Windows Terminal, cmd.exe, or powershell.exe)
using this shell in other IDEs (such as PhpStorm)

So I guess this must have something to do with my WSL install, since it does not happen with other shells in VS Code. But on the other hand, the characters do not seem to appear in the output when storing it to a file, and disappear after just a 1px resize, which makes me suspect VS Code. Does anyone have any idea?
The raw byte output:
¶(B
¶
Linux Floris-PC 4.4.0-19041-Microsoft x86_64
 18:29:50 up 14:48,  0 users,  load average: 0.52, 0.58, 0.59
(B(B]0;fish ~
(B ~ (B (B Thu 29 Apr 2021 06:29:50 PM CEST(B

(B¶(B
¶
(B]0;fish ~
(B ~ (B (B Thu 29 Apr 2021 06:29:52 PM CEST(B

(B¶(B
¶
(B]0;fish ~
(B ~ (B (B Thu 29 Apr 2021 06:29:53 PM CEST(B

(B(B

test.txt

I guess the h is coming from fish ~. Unconfirmed.

That might be, but I guess that is a rendering bug then? Strange that it would only catch the h, because this doesn't happen in any other terminal.

It could have something to do with https://github.com/microsoft/vscode/issues/119204, or your set of zsh plugins?

Unfortunately, that doesn't seem to be related. The strange thing is that when working in the WSL Remote via the extension, I have no problems at all. This only recently appeared after upgrading VS Code from 1.49 while also upgrading my WSL distro 18.04->20.04, but I don't know which of the two caused it.
Additional observations:

When terminating a line with Ctrl+C it does not show the extra character
Any visual reload of the terminal causes the characters to disappear (changing the local echo setting for example)
Sometimes it also shows an l: when running a command, a spurious l will show at the beginning of the command line (it does not show before pressing enter, it appears after pressing enter)

I'm also having this exact same problem. Don't remember since how long ago since I kept ignoring it and I've had problems on/off with fish themes, but I took the time and checked that it was still happening with a vanilla fish install. I'm on a Arch WSL 1.0 distro if that helps and it only happens when accessing WSL without the Remote WSL, which I do a lot because I have a bunch of helpful functions written in fish but might not necessarily be developing in wsl.

Disabling local echo might help this: "terminal.integrated.localEchoLatencyThreshold": -1

@Tyriar Thanks, but I just tried it and it doesn't work ☹. Also what is that setting about? I read it's description but what does it mean by server? ssh? or is it talking about something related to the remote wsl extension?

@AlansCodeLog if input/output latency is high (default is 30ms I think), it will attempt to echo what you type locally. This applies to connecting via ssh in the terminal or using a remote extension

Having an identical issue (with the same two characters, l and h). It seems that the only time an l appears is when a command is entered while a fish autosuggestion is pending, and it usually appears on the same line as that prompt/command, though it appears on the next line right next to the h when any sequence of only space characters is entered as a command. The h indeed always appears, sometimes following a command's output and sometimes on the first line of output (either preceding or following that line).

I think you might be on to something, I'm getting something similar, but mine changes to powershell ??? I saw this the other day while the shell was loading and thought VS Code was confused or something, but now I see it happens on executing any command and coincides like you say with the characters printed. This is not on a clean fish install though, just checked on my current one real quick, but I can't think of anything powershell related it could have.
I can't seem to replicate the other stuff, maybe I'm doing it wrong, but both letters always seem to appear to me. The only other thing I
can confirm is they don't appear when pressing Ctrl+C.

I'm not able to reproduce the issue, so believe the problem has been fixed upstream in conpty, which you'll see when you update windows.

@FWest98 something really weird is going on with your shell, looking at the byte output you pasted in:
�[K�[?2004h��[30m�(B�[m�]0;fish ~
�(B�[m�[38;5;247m�[48;5;236m �[1m�[38;5;231m�[48;5;236m~ �(B�[m�[38;5;236m �(B�[m�[K�[42C�[38;5;240m Thu 29 Apr 2021 06:29:53 PM CEST�(B�[m
�[47C
�[5C
�[30m�(B�[m�[30m�(B�[m�[?2004l

That is:

�[K Clear the line
�[?2004h Enable bracketed paste mode
Bunch of content...
�[?2004l Disable bracketed paste mode

The really weird thing is around the h and l sequences, bracketed paste mode is only meant to go from the terminal frontend to the backend such that processes are able to know the difference between text that is copied and that which is pasted.
Some questions, sorry if they have already been asked as the issue is quite long:

Which WSL distro was this?
You say it doesn't happen when using Remote - WSL, can you clarify what you meant by "Windows + ConPTY + WSL"? Are you running wsl.exe, or pwsh.exe and running wsl inside that?
Do you know of anything in fish that leverages bracketed paste mode?
Have you customized the shell at all?
How did you capture the byte output?

Thank you for looking into this! I'm happy to answer these questions.

Ubuntu 18.04, manually upgraded to 20.04 (which is when this issue started; but at the same time I updated VS Code from 1.49 to 1.55)
It does not happen when using the Remote plugin and connecting to WSL (so the terminal connects to fish directly, I presume). It does happen when running VS Code locally on Windows; it does not matter whether I start wsl inside cmd.exe or pwsh.exe, or run wsl directly from the terminal dropdown. So in terms of process layout; the tree in the green square works fine (running terminal inside a Remote WSL session), while both tress in the red square do not work (running "locally")

I don't know what bracketed paste mode means, so I'm not sure whether I can answer that question
This problem occurs even without any modifications to my shell (and these are limited to the shebang contents)
I ran wsl > output in cmd.exe; I am not sure whether this is the correct way to do so. If you have any other way, please let me know and I will report back.

Some more information I can think of:

This problem does not occur in Windows Terminal
This problem does not occur in Jetbrains IDEs terminal window
I believe these extra characters are not actually in the shell output anywhere; as soon as I run nano, clear, htop, etc; or as soon as I resize the terminal window, or change any other setting about it, these artifacts disappear.

It's looking more and more like an issue in conpty that is fixed in Windows Terminal/later Windows as @meganrogge suggested, which we wouldn't be able to action unfortunately.
What I was thinking was maybe we're not handling the bracketed paste mode sequences coming the other direction and wrongly printing it, echoing it out seems to work:

I am not sure whether this is the correct way to do so. If you have any other way, please let me know and I will report back.

Could you try enabling escape sequence logging to make sure this bracketed paste mode isn't caused randomly by wsl > output? https://github.com/microsoft/vscode/wiki/Terminal-Issues#enabling-escape-sequence-logging

Interesting test. Manually echoing these characters do trigger the issue - but only in fish. When running bash, this works just fine.

As for the escape logging, I get this for every time I simply press enter

I'm on Windows 10 21H1 still and was not planning on updating to 11 for a while probably, but if it's possible to go back after updating I might give it a try just to see if it fixes this issue.
Not sure what all these characters are about but if I do echo -e '\x1b[2004ltest \x1b[2004htest' usually I get test test, but sometimes I get extra characters though it seems I have to hit enter between some attempts for it to happen and it takes a while. When it doesn't add extra characters, if the console is slow enough (at the start usuall), I temporarily see llt which is then replaced by the correct test test.

Terminal changes to look like:
h/mnt/t/Code/folder
❯ echo -e '\x1b[2004ltest \x1b[2004htest'
test test

/mnt/t/Code/folder
❯ echo -e '\x1b[2004ltest \x1b[2004htest'
test test

/mnt/t/Code/folder
❯
h
/mnt/t/Code/folder
❯
h
/mnt/t/Code/folder
❯ echo -e '\x1b[2004ltest \x1b[2004htest'
test test

/mnt/t/Code/folder
❯ echo -e '\x1b[2004ltest \x1b[2004htest'
test test

/mnt/t/Code/folder
❯

/mnt/t/Code/folder
❯

/mnt/t/Code/folder
❯ echo -e '\x1b[2004ltest \x1b[2004htest'
test test

/mnt/t/Code/folder
❯

/mnt/t/Code/folder
❯ echo -e '\x1b[2004ltest \x1b[2004htest'
test test

/mnt/t/Code/folder
❯

/mnt/t/Code/folder
❯ echo -e '\x1b[2004ltest \x1b[2004htest'
test test

/mnt/t/Code/folder
❯

/mnt/t/Code/folder
❯ echo -e '\x1b[2004ltest \x1b[2004htest'
test test

/mnt/t/Code/folder
❯ echo -e '\x1b[2004ltest \x1b[2004htest'
test test

/mnt/t/Code/folder
❯

/mnt/t/Code/folder
❯ echo -e '\x1b[2004ltest \x1b[2004htest'
test test

/mnt/t/Code/folder
❯

And console output logs like it seems to reparse the whole section or something, the relevant output is I think this:
xterm.js: parsing data ❯

/mnt/t/Code/folder
❯

/mnt/t/Code/folder
❯ echo -e '\x1b[2004ltest \x1b[2004htest'
test test

/mnt/t/Code/folder
❯

/mnt/t/Code/folder
❯ echo -e '\x1b[2004ltest \x1b[2004htest'
test test

/mnt/t/Code/folder
❯

/mnt/t/Code/folder
❯ echo -e '\x1b[2004ltest \x1b[2004htest'
test test

/mnt/t/Code/folder
❯

/mnt/t/Code/folder
❯ echo -e '\x1b[2004ltest \x1b[2004htest'
test test

/mnt/t/Code/folder
❯ echo -e '\x1b[2004ltest \x1b[2004htest'
test test

/mnt/t/Code/folder
❯

/mnt/t/Code/folder
❯ echo -e '\x1b[2004ltest \x1b[2004htest'
test test

/mnt/t/Code/folder
❯

Hope that helps. I'll report back if I decide to try W11.
Note: I'm using fish with some customizations here, didn't have time to try a fresh install, but I had tested this previously with a fresh install and was running into the same issue.


[FEATURE] Issue in search bar

"When we give the more input  into the search bar, icon of the search bar overlap the text " which will decrease the user experience. So we have to solve this issue.
screenshot:-

I would like to work on this issue so please assign this issue to me.

Please assign this issue to me.

There is some issue in search bar of overlapping the text on search icon. I want to work on thus issue can u please assign me this issue.

Helo, I am currently a GSSOC contributor, kindly assign the issue to me

I would like to work on this issue .sir, @codervivek5, please assign it to me.

whose solve it first I will merge their PR with level 3

@codervivek5, I solved the problem of the Search Bar Please look the changes and merge the PR.


Docker stellar/quickstart is not syncing

I follow the instruction of https://hub.docker.com/r/stellar/quickstart/ .  The core and horizon is running but not syncing.
The log in supervisor/supervisor.log only shows
horizon                          RUNNING    pid 143, uptime 0:01:12
postgresql                       RUNNING    pid 126, uptime 0:01:13
stellar-core                     RUNNING    pid 125, uptime 0:01:13
Do I need to change any configuration?
The following metrics shows it is not sycing http://<IP_ADDRESS>/metrics
$ sudo docker run --rm -it  -v /home/cheny/stellar:/opt/stellar   -p "8000:8000"     -p "11626:11626"     -p "11625:11625"     --name stellar stellar/quickstart --testnet
running `/start --testnet'
pids are [6]

Starting Stellar Quickstart

mode: persistent
network: testnet (Test SDF Network ; September 2015)
postgres user: stellar
Enter New Postgresql Password:
Confirm:
finalize-pgpass: ok
init-postgres: ok
Waiting for postgres to be available...
postgres: up
create-horizon-db: ok
create-core-db: ok
stellar-postgres-user: ok
chown-core: ok
finalize-core-config: ok
init-core-db: ok
chown-horizon: ok
init-horizon-db: ok
postgres: down
starting supervisor
2019-05-03 02:02:53,533 CRIT Supervisor running as root (no user in config file)
2019-05-03 02:02:53,551 INFO RPC interface 'supervisor' initialized
2019-05-03 02:02:53,551 CRIT Server 'unix_http_server' running without any HTTP authentication checking
2019-05-03 02:02:53,551 INFO supervisord started with pid 6
2019-05-03 02:02:54,555 INFO spawned: 'postgresql' with pid 135
2019-05-03 02:02:54,559 INFO spawned: 'stellar-core' with pid 136
2019-05-03 02:02:54,563 INFO spawned: 'horizon' with pid 137
2019-05-03 02:02:54,564 INFO reaped unknown pid 132
2019-05-03 02:02:55,891 INFO success: postgresql entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2019-05-03 02:02:55,891 INFO success: stellar-core entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2019-05-03 02:02:55,892 INFO success: horizon entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)```

@Cheny-chen sounds like you are unable to join the Testnet network due to stale scp messages following our testnet reset.
You can confirm this by checking stellar-core's /info endpoint:
curl -s localhost:11626/info | grep status
If you notice that the ETA never goes down then you can try fixing this by following the below steps:
First add the below stanza to your stellar-core.cfg:
PREFERRED_PEERS=[
"core-testnet1.stellar.org",
"core-testnet2.stellar.org",
"core-testnet3.stellar.org"]
PREFERRED_PEERS_ONLY=true

Then start up the container:
docker run --rm -it  -v /mnt/xvdf/stellar-quickstart-data:/opt/stellar   -p "8000:8000"     -p "11626:11626"     -p "11625:11625"     --name stellar stellar/quickstart --testnet
Once the container is available:
docker exec -it stellar /bin/bash
This will give you a shell within the container, you can then truncate the peers table:
psql --username=stellar -d core -c 'TRUNCATE peers;'
Finally you should be able to kill the running container and on next restart it should join the network successfully.
Once your node is synced it is best to remove the PREFERRED_PEERS_ONLY=true config parameter as this will allow other users to join the network using your node.
Hopefully this resolves the issue you are experiencing, please be assured that we are actively looking for solutions to mitigate these Post Testnet reset issues.

@brahman81 I tried what you have mentioned but I am stuck in new set of issues
running /start --testnet'
pids are [6]
Starting Stellar Quickstart
mode: persistent
network: testnet (Test SDF Network ; September 2015)
postgres: config directory exists, skipping copy
supervisor: config directory exists, skipping copy
stellar-core: config directory exists, skipping copy
horizon: config directory exists, skipping copy
postgres: already initialized
core: already initialized
horizon: already initialized
starting supervisor
2019-06-04 10:13:04,001 CRIT Supervisor running as root (no user in config file)
2019-06-04 10:13:04,021 INFO RPC interface 'supervisor' initialized
2019-06-04 10:13:04,022 CRIT Server 'unix_http_server' running without any HTTP authentication checking
2019-06-04 10:13:04,022 INFO supervisord started with pid 6
2019-06-04 10:13:05,025 INFO spawned: 'postgresql' with pid 19
2019-06-04 10:13:05,027 INFO spawned: 'stellar-core' with pid 20
2019-06-04 10:13:05,030 INFO spawned: 'horizon' with pid 21
2019-06-04 10:13:05,031 INFO reaped unknown pid 16
2019-06-04 10:13:06,338 INFO success: postgresql entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2019-06-04 10:13:06,338 INFO success: stellar-core entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2019-06-04 10:13:06,339 INFO success: horizon entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2019-06-04 10:13:06,622 INFO exited: stellar-core (exit status 1; not expected)
2019-06-04 10:13:06,632 INFO spawned: 'stellar-core' with pid 71
2019-06-04 10:13:06,830 INFO exited: stellar-core (exit status 1; not expected)
2019-06-04 10:13:08,719 INFO spawned: 'stellar-core' with pid 83
2019-06-04 10:13:08,969 INFO exited: stellar-core (exit status 1; not expected)
2019-06-04 10:13:10,987 INFO spawned: 'stellar-core' with pid 99
2019-06-04 10:13:11,177 INFO exited: stellar-core (exit status 1; not expected)
2019-06-04 10:13:14,195 INFO spawned: 'stellar-core' with pid 115
2019-06-04 10:13:14,402 INFO exited: stellar-core (exit status 1; not expected)
2019-06-04 10:13:15,256 INFO gave up: stellar-core entered FATAL state, too many start retries too quickly
`
Can you please suggest me something . and also I am unable to understand what do you mean by 'ETA goes down'

This issue is now resolved using stellar-core version 11.1.0 nodes should be able to join the testbet network without issues.


Making test change

Codecov Report

Merging #1 (25a2df6) into main (bdff9cc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #1   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines            8         8
=========================================
  Hits             8         8

Impacted Files
Coverage Δ

example-app/utils/tests/test_time.py
100.00% <100.00%> (ø)

example-app/utils/time.py
100.00% <100.00%> (ø)

Related Entrypoints

/time


fix(changelog): conventional commit scope should allow more characters

Taken from the grammar published in https://github.com/conventional-commits/parser#the-grammar
Refs: https://github.com/conventional-commits/conventionalcommits.org/issues/223
I noticed the issue with dependabot commits of the form: build(deps-dev): bump mockito-core from 4.8.1 to 5.2.0 which were not properly categorized as conventional.
Checklist

[x] Review Contribution Guidelines.
[x] Make sure all contributed code can be distributed under the terms of the
Apache License 2.0, e.g. the code was written by
you or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Update documentation when applicable.

I should have mentioned that i couldn't use \R for the unicode newline within a [^] block, i don't know why. Thus i resorted to use the more classic \n.

Thank you 😄


v1.29.0 causes the Extension Host to crash

Hi,

VSCode: 1.60.2
Extension: 1.29.0
OS: Windows 10.0.19043 x64

After starting VSCode, the error message "Extension host terminated unexpectedly" appears, with an option to restart it. After restarting it, it terminates again after a few seconds.
From the window log:
[2021-09-30 11:26:03.284] [renderer1] [error] Extension host terminated unexpectedly. The following extensions were running: aaron-bond.better-comments, mechatroner.rainbow-csv, vscode.extension-editing, vscode.typescript-language-features, christian-kohler.npm-intellisense, p42ai.refactor, VisualStudioExptTeam.vscodeintellicode, vscode.microsoft-authentication, ms-vscode.js-debug, vscode.debug-auto-launch, vscode.git, acarreiro.calculate, mhutchie.git-graph, PKief.material-icon-theme, rafamel.subtle-brackets, ritwickdey.LiveServer, vincaslt.highlight-matching-tag, vscode-icons-team.vscode-icons, wayou.vscode-todo-highlight, vscode.configuration-editing, vscode.json-language-features, vscode.npm
Checking the "Running Extensions" list, the P42 refactor extension is marked as unresponsive. Disabling the extension solves the problem (extension host does not terminate anymore).
Could you please look into this? TIA

Just wanna confirm it's working alright again. Thanks.

Perfect, thanks for confirming 👍🏻


Trouble with scroll bar and highcharts navigator

I am having the same issue described in the SO
http://stackoverflow.com/questions/24960994/highstocks-draggable-element-interfering-with-gridster-dragging
However, with angular, I am not sure how to disable gridster from my highcharts plugin (extension js file).
Similarly, when i resize my widget and scrollbar appears, not sure how to get the scroll bar working so gridster doesn't think im resizing the widget

I see a lot on stackoverflow to use this line $('.gridster ul').gridster().data('gridster');
However, im not sure if this is for jquery only, or angular-gridster ( I am also using jquery separately though).

I believe angular-gridster should ignore clicks/mouse down on buttons and other objects that have ng-click attributes.  So you may be able to just add:
In your controller:
$scope.nothing = angular.noop;
and on your charts element:
ng-click="nothing()"

Thanks for getting back to me. I'm using Highchart and it has its own Navigator. The navigator should do stuff when dragging the buttons, and gridster should not move the widget.
I tried this above, and its not helping

I wonder if you can help. I am also using highCharts and I am having issues resizing my chart when I resize the grid. Is there a way to have the chart resize anytime I resize the grid element? Thanks


Some languagesystems might not have any features assigned (FeatureIndex is missing)

Feel free to reject this. It seemed easier to make a PR than issue for this one.

when does that happen?

I think (!) I have some languagesystems which are not used in any features yet or they end up empty after compilation/optimization of the code (they appear in the code, but they do not really make a difference). I guess this is primarily a problem with my unfinished features’ code, but I thought it should not crash the compilation.

weird, I would expect that FeatureIndex attribute to be present (as an empt list)..

Ah! Look at the fontTools.subset module. It is calling an ensureDecompiled method before attempting to access attributes from an otBase.BaseTable (mother class of all the otData tables).
Maybe that code in featureVars should do the same?

@MrBrezina How can I reproduce the AttribuetError?


Release new llama-cpp-haystack version

Describe the bug
The model_path parameter was renamed to model in #243. This change is not reflected on the current llama-cpp-haystack version on pypi.
The documentation showcases the new API with model, causing a mismatch.
To Reproduce
To download the model:
curl -L -O "https://huggingface.co/TheBloke/OpenHermes-2.5-Mistral-7B-GGUF/resolve/main/openhermes-2.5-mistral-7b.Q4_K_M.gguf"

from haystack_integrations.components.generators.llama_cpp import LlamaCppGenerator

generator = LlamaCppGenerator(
    model="openhermes-2.5-mistral-7b.Q4_K_M.gguf",
    n_ctx=512,
    n_batch=128,
    generation_kwargs={"max_tokens": 128, "temperature": 0.1},
)
generator.warm_up()
prompt = f"Who is the best American actor?"
result = generator.run(prompt)

Describe your environment (please complete the following information):

OS: Linux
Haystack version: haystack-ai==2.0.0b8
Integration version: llama-cpp-haystack==0.2.1

Thanks for reporting this!
I've just released a new version: https://pypi.org/project/llama-cpp-haystack/0.3.0/


Relicense under dual MIT/Apache-2.0

This issue was automatically generated. Feel free to close without ceremony if
you do not agree with re-licensing or if it is not possible for other reasons.
Respond to @cmr with any questions or concerns, or pop over to
#rust-offtopic on IRC to discuss.
You're receiving this because someone (perhaps the project maintainer)
published a crates.io package with the license as "MIT" xor "Apache-2.0" and
the repository field pointing here.
TL;DR the Rust ecosystem is largely Apache-2.0. Being available under that
license is good for interoperation. The MIT license as an add-on can be nice
for GPLv2 projects to use your code.
Why?
The MIT license requires reproducing countless copies of the same copyright
header with different names in the copyright field, for every MIT library in
use. The Apache license does not have this drawback. However, this is not the
primary motivation for me creating these issues. The Apache license also has
protections from patent trolls and an explicit contribution licensing clause.
However, the Apache license is incompatible with GPLv2. This is why Rust is
dual-licensed as MIT/Apache (the "primary" license being Apache, MIT only for
GPLv2 compat), and doing so would be wise for this project. This also makes
this crate suitable for inclusion and unrestricted sharing in the Rust
standard distribution and other projects using dual MIT/Apache, such as my
personal ulterior motive, the Robigalia project.
Some ask, "Does this really apply to binary redistributions? Does MIT really
require reproducing the whole thing?" I'm not a lawyer, and I can't give legal
advice, but some Google Android apps include open source attributions using
this interpretation. Others also agree with
it.
But, again, the copyright notice redistribution is not the primary motivation
for the dual-licensing. It's stronger protections to licensees and better
interoperation with the wider Rust ecosystem.
How?
To do this, get explicit approval from each contributor of copyrightable work
(as not all contributions qualify for copyright) and then add the following to
your README:
## License

Licensed under either of
 * Apache License, Version 2.0 ([LICENSE-APACHE](LICENSE-APACHE) or http://www.apache.org/licenses/LICENSE-2.0)
 * MIT license ([LICENSE-MIT](LICENSE-MIT) or http://opensource.org/licenses/MIT)
at your option.

### Contribution

Unless you explicitly state otherwise, any contribution intentionally submitted
for inclusion in the work by you, as defined in the Apache-2.0 license, shall be dual licensed as above, without any
additional terms or conditions.

and in your license headers, use the following boilerplate (based on that used in Rust):
// Copyright (c) 2016 rust-sdl2_mixer developers
//
// Licensed under the Apache License, Version 2.0
// <LICENSE-APACHE or http://www.apache.org/licenses/LICENSE-2.0> or the MIT
// license <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. All files in the project carrying such notice may not be copied,
// modified, or distributed except according to those terms.

Be sure to add the relevant LICENSE-{MIT,APACHE} files. You can copy these
from the Rust repo for a plain-text
version.
And don't forget to update the license metadata in your Cargo.toml to:
license = "MIT/Apache-2.0"

I'll be going through projects which agree to be relicensed and have approval
by the necessary contributors and doing this changes, so feel free to leave
the heavy lifting to me!
Contributor checkoff
To agree to relicensing, comment with :
I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option

Or, if you're a contributor, you can check the box in this repo next to your
name. My scripts will pick this exact phrase up and check your checkbox, but
I'll come through and manually review this issue later as well.

[ ] @andelf
[ ] @bvssvni
[ ] @sbidin
[ ] @LQKI
[ ] @rphmeier
[ ] @Outfl3sh
[x] @werecat
[x] @xaviershay
[ ] @coeuvre
[ ] @xilec
[ ] @Machtan
[ ] @crumblingstatue
[ ] @OxyDeadbeef

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option
(don't even remember contributing! must have been ages ago)

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option


Update framework version to 1.0.1

Ping @Icenium/core

Test if the sample will be correctly cloned with the changed directory structure. I suspect that you will have to rename the app folder to nativescript-sample-cuteness

:+1:


Fix styling of Koa vs Express docs

split sentences
add commas where needed
fix various grammar errors
replace "node.js" with "Node"
replace "koa" with "Koa"

sorry, we don't merge style-only PRs. it's not worth the git diff.
can you edit this PR to only fix:

grammatical errors (i can't tell what they are from this diff)
koa => Koa

Hey @shime nice to see you here 🙌  can you fix the PR per Jonathan's comments?

@niftylettuce 👋  thanks for reminding me, just made the fixes per Jonathan's comments.


Add the nested test directories to the code checks

Now that we have tests nested throughout source, we should recursively check for test subdirectories. Note: this is gross because cmake apparently doesn't understand GLOB **.

Codecov Report

Merging #541 (e841ef7) into develop (e4c669b) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #541      +/-   ##
===========================================
- Coverage    96.14%   96.12%   -0.02%
===========================================
  Files          103      103
  Lines         6457     6457
===========================================
- Hits          6208     6207       -1
- Misses         249      250       +1

Impacted Files
Coverage Δ

.../physics/tests/serac_thermal_structural_solver.cpp
98.70% <0.00%> (-1.30%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4c669b...e841ef7. Read the comment docs.

another thought: we could keep tests alongside sources in their appropriate directory, but put a unique suffix on them, e.g. "_test.cpp". This would make it easier to grab all the tests by doing
file(GLOB_RECURSE _test_sources "*_test.cpp")

it looks like another option is to just glob all of the sources (which we currently do) and then filter by an appropriate regex:
cmake_minimum_required(VERSION 3.18)
project(example_project LANGUAGES CXX)

file(GLOB_RECURSE sources "${PROJECT_SOURCE_DIR}/src/*.cpp")
set(test_sources ${sources})
list(FILTER test_sources INCLUDE REGEX ".*/test/.*pp")
MESSAGE(STATUS "${test_sources}")

applied to this project
sam@provolone:~/code/tmp$ tree
.
├── CMakeLists.txt
└── src
    ├── main.cpp
    ├── subdirectory
    │   ├── foo.cpp
    │   ├── subsubdirectory
    │   │   └── test
    │   │       └── subsubtest.cpp
    │   └── test
    │       └── subtest.cpp
    └── test
        └── test.cpp

6 directories, 6 files

gives:
sam@provolone:~/code/tmp/build$ cmake ..
-- The CXX compiler identification is GNU 9.3.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- /home/sam/code/tmp/src/subdirectory/subsubdirectory/test/subsubtest.cpp;
/home/sam/code/tmp/src/subdirectory/test/subtest.cpp;
/home/sam/code/tmp/src/test/test.cpp
-- Configuring done
-- Generating done
-- Build files have been written to: /home/sam/code/tmp/build

Also, should line 72 include the .inl files from Functional as well?

one other thought: would it make sense to move the base test directory to src/serac/test?

one other thought: would it make sense to move the base test directory to src/serac/test?

The reason I left it here is they test stuff external to our source (e.g. external library smoke tests and compiler issues). I'd be OK moving it if people feel strongly about it though.


Minor README fixes

Show the correct default path for plugins.
Fix the bootstrap commands to use the same repository URLs.

Good grief. You're the second person now that's found errors in the README. I'm really going to have to look that over to ensure there's not anything else.
Good catch, by the way.


User Transfer's Failing on Beamer dApp

Description
A user KINDMIND#6463 faced issues when bridging USDC from Optimism to Arbitrum. (seen below)
Discord message link: https://discord.com/channels/958324380226695188/1077479897372557352/1077480370557173800

The user later opened a ticket and shared their screenshots and explained what had happened:

User bridged USDC from Optimism to Arbitrum
Transaction showed that it failed but,
Later became successful after 1 minute.
User used Bitkeep Wallet
User not sure what version of Optimism RPC was used
Wallet connected automatically
Error messages popped up (seen below).

System information
OS & Version: Windows/Linux/OSX
Browser & Version: Chrome/Firefox
Commit hash: when using checkout
Expected behavior
Actual behavior
Steps to reproduce the behavior

Findings so far (all on goerli):

when I'm first connected to optimism, then switch to arbitrum by using the source selector, I get the following error when trying to make a transfer:
underlying network changed (event="changed", network={"name":"arbitrum-goerli","chainId":421613,"ensAddress":null,"_defaultProvider":null}, detectedNetwork={"name":"optimism-goerli","chainId":420,"ensAddress":null,"_defaultProvider":null}, code=NETWORK_ERROR, version=providers/5.7.2)
It seems like they do the network change but don't emit the chainChanged event, because the page is not reloaded.
when connecting to optimism and reloading, trying to make a transfer leads to the following error text for the ensure token allowance step: [object Object]
It's really hard to debug without access to the console.
when the above [object Object] error text is shown for the ensure token allowance step, trying to make the same transfer again leads to an error in the request transaction step (again [object Object]). This means the first transaction actually goes through. After checking the other rollup, I realized the transfer actually went through.
I found a way to debug the integrated Bitkeep browser by connecting my phone to my laptop via USB and using the desktop chrome. Allows seeing errors in the console. See https://developer.chrome.com/docs/devtools/remote-debugging/#discover
Using the debugging method, I could find more information. The goerli.optimism.io RPC throws the following error when requested to do a transaction:
{"jsonrpc":"2.0","error":{"code":-32601,"message":"invalid JSON-RPC version"},"id":null}
So it's the same as the user from Discord experienced. So something in the decoding of the JSON error is also wrong in our app. Not sure at the moment if the mainnet and testnet deployments diverged in that regard.
The corresponding request to the error is:
{"method":"eth_getTransactionByHash","params":["0xddedde0179b8a6a8dfc965bd50c2b86c2aee76abdea053b575973ea5017e986c"],"id":1677003171008}
It's always this RPC method that leads to the error.

So overall it seems like there is more than one problem to solve.

Further investigations:

I tried to query the rpc manually. The issue about the request is that the payload is missing the "jsonrpc":"2.0" field. ethers.js seems to not add it in this method call. All other calls are fine.
Interestingly, ethers.js does not generate this method call in a desktop browser environment, only in Bitconnect.
When doing a transfer the other way round (arbitrum -> optimism), this method's payload is also missing the jsonrpc version field, but the arbitrum rpc does not respond with an error in that case.

Done