Pick a single icon set if possible, and preload it

Right now we use a mixture of icons from five icon sets. This isn't good from a memory usage or a visual consistency standpoint. Designers have been using the AntDesign icons so we should probably follow suit.

❯ rg "import.*vector-icons"
components/AvalancheForecastZoneMap.tsx
20:import {FontAwesome5} from '@expo/vector-icons';

components/TelemetryStationMap.tsx
4:import {FontAwesome5} from '@expo/vector-icons';

components/icons/nac-icons.tsx
1:import {createIconSet} from '@expo/vector-icons';

components/content/Carousel.tsx
5:import {AntDesign, FontAwesome5} from '@expo/vector-icons';

components/content/Card.tsx
6:import {FontAwesome} from '@expo/vector-icons';

components/DangerScale.tsx
3:import {MaterialIcons} from '@expo/vector-icons';

components/Observations.tsx
8:import {FontAwesome, MaterialCommunityIcons} from '@expo/vector-icons';

components/Observation.tsx
5:import {FontAwesome5, MaterialCommunityIcons, Fontisto} from '@expo/vector-icons';

App.tsx
7:import {AntDesign} from '@expo/vector-icons';

We should preload icons so they're ready to go when we need them - https://docs.expo.dev/archive/classic-updates/preloading-and-caching-assets/#pre-loading-and-caching-assets

@floatplane looks like we pre-load fonts these days but not icons, this seems relevant still.

@beaucollins I'm not sure if our startup/loading time is at all an issue, anecdotally it does not seem to be, but this may be something we can improve on for bundle size etc.


Have you had a try to convert .pth model trained out by fast-reid to onnx ?

Dear team,
As you know, NVIDIA TRT supports onnx-formatted models and TRT running models on Jetson platform gains a very good performance,  it would be great if  fast-reid pth models can be converted to onnx successfully, that will help us a lot in deploying models on Jetson devices.   Thanks.

We are making efforts to support TRT runtime.
If we finished, we will release the tutorial as soon as possible.

We have finished supporting onnx/trt export, please check the deployment.


Product filter [Shop By]

Bug report
We want to display only those attributes who belong to at least one or more products
Issue Description

As shown in screenshot - this particular attribute does not belong to any products.

Important things to remember

I did not select attributes in combination.
Only one attribute is selected.

Expected result
Display only those attributes who belong to at least one or more products
This will directly affect user experience
Nowadays major e-commerce platform follows this pattern - You can check on Flipkart

Hi @AkashWeybee,
Please refer to this issue,
https://github.com/bagisto/bagisto/issues/3950

Hi @AkashWeybee,
Please refer to this issue,
#3950

Not working in demo.
kindly check demo

Hi @AkashWeybee,
The demo is not updated with the master. Please refer to the above issue.

Hi @AkashWeybee,
The demo is not updated with the master. Please refer to the above issue.

Hi @AkashWeybee,
The demo is not updated with the master. Please refer to the above issue.

we cannot replace our entire code with master branch,
can you tell me - what was the change?

Hi @AkashWeybee,
Please  refer to this PR i.e.,
https://github.com/bagisto/bagisto/pull/4017

A high level of dedication.
Thank you.

Hi @AkashWeybee,
Please refer to this PR i.e.,
#4017

A high level of dedication.
Thank you.

@ghermans @devansh-webkul
The issue is resolved now but - it is not optimized at all.
Because currently, we have 10k products and the one category has approximate 3.5k to 4.5k products. Each attribute may have 1k+ values. [Electrical products]
we are targeting for 80k to 1 lakh products. [Electrical]
Each category will have approximate 10k products. Each attribute may have 2k+ values.
And you've used brute force approach to scan all products in the respective category.
Think innovative sir.
We are working on our side, I think, Together we will solve this issue.

@AkashWeybee thanks for the feedback, i will reopen this issue so we can further investigate this.

Link: https://github.com/bagisto/bagisto/pull/4315

As the optimization thing is a different case that can be enhanced with time.

Hi @AkashWeybee,
One more thing you can remove this line from the view i.e. https://github.com/bagisto/bagisto/blob/b6a30fc015c7468792eafcf0181e844cb358a1a2/packages/Webkul/Velocity/src/Resources/views/shop/products/list/layered-navigation.blade.php#L10 and same for shop.
As this is the main source of duplicacy, I have removed it in the above mentioned PR.

I am closing this issue, as the main issue is fixed. If you want you can raise another PR for optimization.

Tested myself on 3000 plus products, page taking more time to load on category filter. So this needs to be optimized to some extent as well. Really apology for closing this.


NoLabel fix for Object Detection

This PR fixes the nolabel for object detection, by bringing all nolabels to (none), similar to the rest of the image dashboards.
Description

Checklist

[x] I have added screenshots above for all UI changes.
[ ] I have added e2e tests for all UI changes.
[ ] Documentation was updated if it was needed.

Codecov Report

Merging #2356 (c4564b8) into main (7900db3) will decrease coverage by 13.34%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##             main    #2356       +/-   ##
===========================================
- Coverage   92.40%   79.07%   -13.34%
===========================================
  Files         108       26       -82
  Lines        5415     2270     -3145
===========================================
- Hits         5004     1795     -3209
- Misses        411      475       +64

Flag
Coverage Δ

unittests
79.07% <66.66%> (-13.34%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

..._vision/rai_vision_insights/rai_vision_insights.py
77.11% <66.66%> (ø)

... and 133 files with indirect coverage changes


Generate timing results for CLARITY to CLARITY registration comparing CIS To ITK at differnt scales

thanks @kkutten1 can you clarify:

you'll make a table?
you'll send us a link NLT today?
didn't you already do this? i don't see how this will clarify whether it is the integration scheme or the library.  you were going to clarify that for me today, correct?

Algorithm
RK4 Scale
Time(s)

CIS
NA
4.437

ITK (RK4)
1.0
17.964

ITK (RK4)
0.5
9.025

ITK (RK4)
0.25
1.993

RK4 Scale is scale at which Runge-kutta algorithm is run relative to image

@kkutten1 please be MUCH more clear.  provide all details you possibly could.
if you provide too many, i'll let you know :)


[BUG] Placeholder loading spinner for images that are loading in edit modal

Description
A brief description of the bug
Reproduction Steps
Steps to reproduce the bug
Expected Behavior
Description of the expected behavior

Empty File objects used instead - temporarily resolved


Status codes are not correct, or how can I add them?

Hey everyone,
first of all, thank you for this wonderful package! It really takes of so much work.
However, the status codes shown are not correct. Are those just the default ones, or how are those generated?
In my controller I have the following response:
public function update(UpdateCommentRequest $request, Comment $comment): JsonResponse
    {
        $comment = $request->perform($comment);

        return $this->updatedWithPayload(new CommentResource($comment));
    }

The updatedWithPayload method is part of my Controller which is extended. This is the code for the method
public function updatedWithPayload($data, string $message = "The ressource was successfully updated."): JsonResponse
    {
        return $this->successWithPayload($data, $message, 202);
    }

Which means, I send a 202 back as a status code. But the generated docs just show me a 200 code instead. Is this a bug? How can I change that etc?
Also, I have a custom status code 483. This is being thrown in my EnsureEmailIsVerified middleware. So, a 483 can be thrown, when the route is protected by the verified middleware. I also cannot find the status code 483 in the docs. How can I add them?
Kind regards

Hi

Are those just the default ones, or how are those generated?

You should be able to override default responses as
    /**
     * @LRDparam username string|max:32
     * // either space or pipe
     * @LRDparam nickaname string|nullable|max:32
     * // override the default response codes
     * @LRDparam responses 200,422
     */

or in the config
https://github.com/rakutentech/laravel-request-docs/blob/4f47d1d15733593a2b84a3fa3f6c1e4376afbb2e/config/request-docs.php#L42
--

Which means, I send a 202 back as a status code. But the generated docs just show me a 200 code instead. Is this a bug?

hmm, you should be seeing 202
https://github.com/rakutentech/laravel-request-docs/blob/4f47d1d15733593a2b84a3fa3f6c1e4376afbb2e/ui/src/components/ApiAction.tsx#L134
try turning off app.debug to false and see if mistakenly the middleware is not overriding the status code.
https://github.com/rakutentech/laravel-request-docs/blob/4f47d1d15733593a2b84a3fa3f6c1e4376afbb2e/src/LaravelRequestDocsMiddleware.php#L34C22-L34C31

hmm, you should be seeing 202

What do you mean by the referenced ApiAction.tsx line? How can I make use of it or test it?

try turning off app.debug to false and see if mistakenly the middleware is not overriding the status code.

It is already turned off as it is the default setting. Any other idea why it is not showing me a 202?

It is, but it just shows the default response codes and not the response codes which I have implemented such as 202 or 483

Here is the screenshot of the status codes:

ok got it. Well those are the basic status codes that are taken from the config file hard coded.
https://github.com/rakutentech/laravel-request-docs/blob/4f47d1d15733593a2b84a3fa3f6c1e4376afbb2e/ui/src/libs/constants.tsx#L1-L15
These were added just for the reference to the user.
Your status code 201 not showing is due to that. Currently it is not customization via config, I am not sure if many people would desire that feature. If enough people want it, I ll implement it.

But the status code 201 and 202 are both included in the hard coded config file, as you have quoted.
Why aren't they showing up? I think I don't understand you.

ah ok, in that case, also need to add their definitions here too, so they are displayed on the UI.
I think you can submit a pull req and I ll merge and push the new tag
 export const responsesText: {[key: string]: string} = {
     "200": "OK",
     "201": "Created",
<------------ append here
     "202": "Accepted",
     "204": "No Content",
     "400": "Bad Request",
     "401": "Unauthorized",
     "403": "Forbidden",
     "404": "Not Found",
     "405": "Method Not Allowed",
     "422": "Unprocessable Entity",
     "429": "Too Many Requests",
     "500": "Internal Server Error",
     "503": "Service Unavailable",
 }

Sorry, I don't understand you.
I thought the generated API docs will display the correct response code. So, if one route response with 201 and another route with 202, then it will show the correct status code in the documentation. Isn't that the case and feature of this package?

It by default shows all the response codes that are inside the config/request-docs.php. For each route, if you need to override those, it can be done using * @LRDparam responses 200,201. However, since, the frontend responsesText only has limited definitions declared, so even if you put 201 right now, it is not correctly displayed.

So, this package does not support to discover the correct response status codes for now and just displays the default ones?

Yes

I ll close this and I have added it to the todo list for next version features.

v2.31
Partially fixed- still custom status codes are not supported. But added more codes ranges that are supported by standard HTTP. Won't support in near future. Pull Reqs welcome.


CocoaPods Error On Build

I'm trying to build the app on my laptop, but I'm running into an issue with bin/setup.
It looks like the gemfile installs 0.35.0, but the pods file actually requires 0.37+. Running bundle update followed by ./bin/setup appears to fix the error. This is using ruby 2.2.1p85 on OSX 10.11.
Fetching gem metadata from https://rubygems.org/.........
Fetching version metadata from https://rubygems.org/...
Fetching dependency metadata from https://rubygems.org/..
Installing i18n 0.6.11
Using json 1.8.1
Installing minitest 5.4.3
Installing thread_safe 0.3.4
Installing tzinfo 1.2.2
Installing activesupport 4.1.8
Installing claide 0.7.0
Installing fuzzy_match 2.0.4
Installing nap 0.8.0
Installing cocoapods-core 0.35.0
Installing cocoapods-downloader 0.8.0
Installing cocoapods-plugins 0.3.2
Installing netrc 0.7.8
Installing cocoapods-trunk 0.4.1
Installing cocoapods-try 0.4.2
Using colored 1.2
Installing escape 0.0.4
Installing molinillo 0.1.2
Installing open4 1.3.4
Installing xcodeproj 0.20.2
Installing cocoapods 0.35.0
Installing xcpretty 0.1.7
Using bundler 1.10.4
Bundle complete! 2 Gemfile dependencies, 23 gems now installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.
Analyzing dependencies
[!] The version of CocoaPods used to generate the lockfile (0.37.2) is higher than the version of the current executable (0.35.0). Incompatibility issues may arise.
/Users/will/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/pathname.rb:430:in `open': No such file or directory @ dir_initialize - /Users/will/.cocoapods/repos (Errno::ENOENT)
	from /Users/will/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/pathname.rb:430:in `foreach'
	from /Users/will/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/pathname.rb:430:in `children'
	from /Users/will/.rvm/gems/ruby-2.2.1/gems/cocoapods-0.35.0/lib/cocoapods/sources_manager.rb:63:in `all'
	from /Users/will/.rvm/gems/ruby-2.2.1/gems/cocoapods-0.35.0/lib/cocoapods/user_interface/error_report.rb:130:in `repo_information'
	from /Users/will/.rvm/gems/ruby-2.2.1/gems/cocoapods-0.35.0/lib/cocoapods/user_interface/error_report.rb:34:in `report'
	from /Users/will/.rvm/gems/ruby-2.2.1/gems/cocoapods-0.35.0/lib/cocoapods/command.rb:58:in `report_error'
	from /Users/will/.rvm/gems/ruby-2.2.1/gems/claide-0.7.0/lib/claide/command.rb:300:in `handle_exception'
	from /Users/will/.rvm/gems/ruby-2.2.1/gems/claide-0.7.0/lib/claide/command.rb:274:in `rescue in run'
	from /Users/will/.rvm/gems/ruby-2.2.1/gems/claide-0.7.0/lib/claide/command.rb:264:in `run'
	from /Users/will/.rvm/gems/ruby-2.2.1/gems/cocoapods-0.35.0/lib/cocoapods/command.rb:45:in `run'
	from /Users/will/.rvm/gems/ruby-2.2.1/gems/cocoapods-0.35.0/bin/pod:43:in `<top (required)>'
	from /Users/will/.rvm/gems/ruby-2.2.1/bin/pod:23:in `load'
	from /Users/will/.rvm/gems/ruby-2.2.1/bin/pod:23:in `<main>'
	from /Users/will/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in `eval'
	from /Users/will/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in `<main>'

-------------------------------------------------
Created Tropos/Secrets.h. Please add your keys to it.
-------------------------------------------------

Thanks for reporting this. Would you be interested in opening a PR to fix this?

Closing in favor of #129


[proposal]clear code dependencies of sqlite3.

What is your proposal:
see https://github.com/koordinator-sh/koordinator/issues/1241 for full description.
Why is this needed:
remove ependencies of sqlite3 and clear code.
Is there a suggested solution, if so, please add it:

/area koordlet

/assign @LambdaHJ


Work with mangling

Currently the joint-points are declared with regular expressions:
export interface MethodSelector {
  classNamePattern: RegExp;
  methodNamePattern: RegExp;
}

export interface MemberSelector {
  classNamePattern: RegExp;
  fieldNamePattern: RegExp;
}

This will prevent the library work with mangled production build.
Possible solutions:

Introduce "production" mode as part of the build process into which the code will be woven in-place (i.e. we will inject code on the place of the joint point).

Drawbacks:

Code duplication (given advice needs to be copied each place we use it).
Need to generate sourcemaps.
Complicated.

Pass a list of classes and their methods:
class Bar {
  foo() {
    return 2;
  }
  baz() {
    return 42;
  }
}

Bar.prototype.foo;
Bar.prototype.baz;

Drawbacks:

Couples the advice with all the places it is used in more explicitly.
Need to alter existing API.
More verbose.

Option 2 seems reasonable at this point.

The benefit of 2 would also be that you can drop the @Wove() decorator. This way, the woven classes/method now nothing about them being part of an aspect.

Great work @mgechev ! :beers:

I'd love to introduce build-time woving one day... :smile:

That would be super cool!


Prepare yew 0.20.1 patch release

Description
Prepare for 0.20.1 patch release. This PR updates the change log. I'm not sure if a blog post is in order. This is targeting the performance regression observed in the 07_create10k testcase of js-framework-benchmark and the connected bugs, #3024, #3043 as well as a regression in listeners #2989.

Retargeting this to the feature branch. @hamza1311 do you know if it would work if I just executed the publish action from the branch? We really shouldn't include the breaking change as pointed out by futursolo.

Can we get the gloo-history fix included as well? @hamza1311  knows what I mean.

@simbleau, that was in a patch release so cargo should automatically resolve the latest version.  What happened?


Justus Exercises_05

Please do not delete my comments without solving them Try using sets or a dict to make number detection faster. Please implement non-static paths to make your code executable on other devices Please follow the PEP8 guidelines line 35 is hard to read, try to split it up in more lines

Please use proper grammar and sentence structure when you try to write reviews. You can use such symbols as a period.

Please do not delete my comments without solving them Try using sets or a dict to make number detection faster. Please implement non-static paths to make your code executable on other devices Please follow the PEP8 guidelines line 35 is hard to read, try to split it up in more lines

Please use proper grammar and sentence structure when you try to write reviews. You can use such symbols as a period.

nah

[!CAUTION]
Please do not delete or edit my comments without solving them

Details to my change request

Try using sets or a dict to make number detection faster.
Please implement non-static paths to make your code executable on other devices
Please follow the PEP8 guidelines
line 35 is hard to read, try to split it up in more lines


refactor: make weight argument in xtokens transfers optional

Closes #838.
Make the weight argument in xtokens transfers optional since in practice it's very rare to set a specific limit - most of the time people just set some arbitrary high value. With this change, you can pass None to set the BuyExecution limit to Unlimited, which is cleaner and less fragile.

This looks good but we could also choose to make dest_weight of type WeightLimit instead of Option<Weight> and thus having to convert it to WeightLimit; doing so would also make the API more readable by passing WeightLimit::Unlimited instead of None.

Yea that makes sense, I'll try to update the pr later today


fixed active in hierarchy gameobject reference

throwing an error in unity if you don't do this

Forgotten to push this. Thanx for the reminder.


Improve parsing error messages

We can treesitter to improve the parsing error messages:

SyntaxNode.hasError() API to show if parts of a script fail to parse (see https://github.com/tree-sitter/tree-sitter-bash/issues/27#issuecomment-410867036)
error recovery to show more specific errors if a specific node is missing (see https://github.com/tree-sitter/tree-sitter-bash/issues/27#issuecomment-410865045)

@skovhus That's really cool 👍


Filtering nodes by farm name from the capacity filter with the farmerbot returns nodes with insufficient resources

Description
Filtering nodes by farm name from the capacity filter with the farmerbot returns nodes with insufficient resources and wakes up nodes even though it doesn't have enough resources for the mentioned deployment.
Screencast from 06-04-23 14:20:56.webm
As seen in the video above i tried to deploy a full VM with 50GB disk and selected Amer-Farmerbot-testnetfarm from the farm name field in the capacity filter this farm (farm 336) has 4 nodes and none of these nodes has 50GB of free sru.
But instead of returning that there are no nodes in this farm available with these resources it returned node 248 which only has 19GB of free sru and as seen on the left side in the polkadot ui it changed the state of node 248 and the node started shortly after the state was changed.
And after node 248 was powered on i tried to deploy on it with the same resources but it didn't appear in the capacity filter.

And in the manual filter it returned that the node doesn't have enough resources.

Steps to reproduce

Find a farm ran by farmerbot and check the power target and state of its nodes.
Navigate to the weblets and prepare any deployment with resources more than the available on any node in the mentioned farm.
Select the capacity filter.
Select the farm from the Farm Name list.
Click on Apply Filters & Suggest Nodes
Check the power state and target of the returned node.

@mohamedamer453
Hello Amer,
I did the whole scenario you mentioned in test/qa net they have the same version of the playground and yes I faced the issue, while when did the same on the dev network I didn't find the issue, maybe because there we check on the disk input every single time the user changes the value of it and it's a new feature, so can you please try it on the dev version and update the issue if the bug still there?
Thanks

@Mahmoud-Emad I checked the issue on devnet and the following results were performed on Nodes 83, 84, 85, 86 these nodes belong to brandon-farm. These are the same nodes that i had in my farm on testnet but they were booted on devnet so the same disk sizes that were originally mentioned in the issue still apply.
The case where the capacity filter returned powered off nodes when the farm didn't have any nodes with enough resources was fixed and now when there's not enough resources in any of the nodes the capacity filter doesn't return nodes.
However another issue is still present when i add valid disk size and selected the farm from the capacity filter it returned 2 nodes that were powered off by the farmerbot 83, 84
both cases can be seen in the video below.
Screencast from 30-04-23 12:26:09.webm
Environment

Network: devnet.
Weblets Version: 35919fc.

Closing this issue since the main issue was solved and verified above and the other issue mentioned in the comment above is a duplicate of #78


Upgrade the built in Chef from 15.12.22 to 15.14.0

We need to get on the latest version of 15:
Update omnibus:
https://github.com/chef/chef-server/blob/master/omnibus_overrides.rb#L9
Update the gemfile.lock in https://github.com/chef/chef-server/tree/master/src/chef-server-ctl by running bundle update chef
Update the gemfile.lock in https://github.com/chef/chef-server/tree/master/oc-chef-pedant by running bundle update chef

This has been updated to 15.15 (latest from the chef-15 branch) https://github.com/chef/chef-server/pull/2228

This has been updated to 15.15 (latest from the chef-15 branch) https://github.com/chef/chef-server/pull/2228

Closing out as a duplicate https://github.com/chef/chef-server/issues/2229

Closing out as a duplicate https://github.com/chef/chef-server/issues/2229


Put assets (modules, logo, PrestaShop versions) in the bucket

Questions
Answers

Description?
The main purpose of this PR is to upload module zips and logo & PrestaShop zips to the bucket and make the API returns the url of those files instead of using Github files. It also add some optimizations and add download_url & stability information on the /prestashop & /prestashop/{stable,rc,beta} endpoints.

Type?
improvement

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes #3 #10 & #11

How to test?
See below

Possible impacts?

How to test

Replace the url in modules/ps_distributionapiclient/src/DistributionApi.php line 36 by:

-private const API_ENDPOINT = 'https://api.prestashop-project.org';
+private const API_ENDPOINT = 'https://integration-api.prestashop-project.org';

Clear cache: rm -rf var/cache/*
Fully uninstall any native modules (psgdpr for instance)
You should be able to install it back when ps_distributionapiclient is enable

I approve the PR but

I added some suggestions to strengthen the code against network failures, bad filesystem paths and process failures (like building a ZIP archive)
With the addition of the Google Bucket management, is it still easy to work on localhost? I'm worried we're coupling hard the codebase with Google Bucket dependency. How could we work-around that?

For the first point, I think we want the script to fail and stop if there is any error so we don't have half a release available
For the second point, yes it's getting more coupled but you can easily create a personal bucket to run it

For the first point, I think we want the script to fail and stop if there is any error so we don't have half a release available

OK but in the logs I wish we could see "Throw Exception at line ..." rather than "Fatal error ..." (see above comment)

@atomiix If you agree with my suggestion, do we go for QA and you improve error logs later or do you wish to include logs error improvement in another PR? I approved the PR to help you move forward as my feedback is not blocking

We need https://github.com/PrestaShopCorp/terraform-core-oss-distribution-api/pull/7 to be merged to be able to test this PR but yeah, as soon as it's merged, let's go for QA and I'll improve the error logs in another PR ;)

@matks I updated the how to test section, I add the waiting for QA label ;)


[K8S004] Ensure podDisruptionBudget set & at least one of minAvailable or maxUnavailable is provided

Use case
To ensure services are configured for high-availability to reduce the chance of disruption or downtime during an upgrade, users should have podDisruptionBudget set and at least one of minAvailable or maxUnavailable is provided for each workload construct (Deployment, ReplicaSet, ReplicationController, StatefulSet)
Solution/User Experience
Report on any workload constructs that do not have an associated podDisruptionBudget or if the associated podDisruptionBudget does not have minAvailable or maxUnavailable configured
Alternative solutions
None

this requires the match selector helper which the go client has but the rust client currently does not


Fancy zones change default & delete layouts

Description of the new feature / enhancement
When I use Fancy Zones via Remote Desktop session, it is constantly reverting from my custom 3x2 grid (4K monitor, this is a sweet layout) to the "Priority Grid" layout. Several times a week I have to pop up the layout editor and re-select my custom grid.
I would like to either be able to:

set my custom grid to be the default so if it ever wigs out, my custom grid is what it reverts to
be able to remove all the other layout options, so that mine is the only option

Scenario when this would be used?
This would ensure that any RDP hiccups do not revert the layout from the one I want.
Supporting information
No response

I'm MSFT employee, erlong

Hi @cloudstake, thank you for the suggestions. The feature of setting your custom layout as a default is in progress, you can track it here: https://github.com/microsoft/PowerToys/issues/12466. Thanks!
/dup of https://github.com/microsoft/PowerToys/issues/12466


heapprofile make program very slow

Program will be very slow when heapprofile enable .
OS: Ubuntu 18.04.2

Yes, this is by design. heap profiler actually instruments every single allocation. Closing as wontfix.


Add adaptive federated optimization

This PR adds an implementation of adaptive optimizers (based on numpy ndarray) and tests for it.
TODO:

[x] Add Adagrad optimizer
[x] Add Adam optimizer
[x] Add Yogi optimizer
[x] Add more info like links to the original papers and docstrings inside __init__ methods
[x] Add another function to verify the correctness of optimizers inside tests

@alexey-khorkin Could you clarify the purpose of introducing numpy-based optimizers instead of using PyTorch-based ones?

@alexey-khorkin Could you clarify the purpose of introducing numpy-based optimizers instead of using PyTorch-based ones?

@itrushkin, This is necessary to get rid of the dependence of the PyTorch installation on the aggregator (director) side

@alexey-khorkin Could you clarify the purpose of introducing numpy-based optimizers instead of using PyTorch-based ones?

@itrushkin, This is necessary to get rid of the dependence of the PyTorch installation on the aggregator (director) side

Optimizer steps are usually performed on the collaborator side while performing a training task. Why do we need them on the aggregator?

Docs render:

Maybe make sense to use this library https://github.com/ddbourgin/numpy-ml

Maybe make sense to use this library https://github.com/ddbourgin/numpy-ml. If we implement AdaptiveAggregation using this library we can simply add support for RMSProp and SGD. I didn't find Yogi optimizer there, but we can create pull request to numpy-ml.

This question

Maybe make sense to use this library https://github.com/ddbourgin/numpy-ml. If we implement AdaptiveAggregation using this library we can simply add support for RMSProp and SGD. I didn't find Yogi optimizer there, but we can create pull request to numpy-ml.

This question

@igor-davidyuk , with @dmitryagapov  and @alexey-gruzdev, we have decided not to use this library for now.


Inconsistent error output on SSR rehydration

Description
1) 404 cases lead to different SSR and Browser representations of error.
2) SSR representation seems to be slightly off.
Steps to reproduce

Access 404 API from Browser directly (trigger SSR).
Access 404 API from Browser via link (trigger client fetching).

By 404 API I mean any API returning message: "Not Found", code: INTERNAL_SERVER_ERROR which is probably not perfect but is the default ApolloServer behavior:

AuthenticationError — for authentication failures
ForbiddenError — for authorization failures
UserInputError — for validation errors on user input
As a fallback for uncaught failures, any other unknown errors thrown within your resolver will add the code INTERNAL_SERVER_ERROR
https://blog.apollographql.com/full-stack-error-handling-with-graphql-apollo-5c12da407210

and shouldn't really matter for the context of this issue.
Code
// some NextJS page

let [dataResult] = useQuery({
  query,
})

if (dataResult.error) {
  console.log(dataResult.error) // !!!
  return <Error message={dataResult.error.toString()}/>
}

SSR Error
[CombinedError: [Network] undefined] {
  name: 'CombinedError',
  message: '[Network] undefined',
  graphQLErrors: [
    GraphQLError: Not Found
        at rehydrateGraphQlError (/.../node_modules/urql/dist/cjs/index-dddbd19e.js:23:12)
        at Array.map (<anonymous>)
        at new CombinedError (/.../node_modules/urql/dist/cjs/index-dddbd19e.js:39:61)
        ...
        at b (/.../node_modules/wonka/dist/wonka.js:865:14)
        at Array.forEach (<anonymous>) {
      message: 'Not Found'
    }
  ],
  networkError: Error: undefined
      at /.../node_modules/urql/dist/cjs/core.js:525:25
      ...
      at d (/.../node_modules/wonka/dist/wonka.js:137:16),
  response: undefined
}

error.toString() currently produces (at server) [Network] undefined.
Somehow it misses the informative  GraphQLError: Not Found part and goes for the weird  [Network] undefined
Browser
Talking about the same error in Browser.
error.toString() currently produces [GraphQL] Not Found.
Which LGTM.

The same error should probably lead to the same structures in Browser and Server.
At least, the error in Server should be improved to match the Browser one.
Stacktraces will be different for sure, but the final messages of toString should match IMO.

Hey, this is part of the latest urql release! Thanks for reporting this issue


WIP: Rename monitor methods and add channel cleanup

Closes #73

Codecov Report

Merging #81 (8e88d87) into master (22bb38b) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   55.28%   55.23%   -0.06%
==========================================
  Files         106      106
  Lines       10203    10256      +53
==========================================
+ Hits         5641     5665      +24
- Misses       4190     4219      +29
  Partials      372      372

Flag
Coverage Δ

unittests
55.23% <0.00%> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

chainstate/monitor.go
0.00% <0.00%> (ø)

client_internal.go
81.55% <0.00%> (ø)

chainstate/client.go
61.45% <0.00%> (-3.48%)
:arrow_down:

client_options.go
68.51% <0.00%> (-1.78%)
:arrow_down:

action_transaction.go
38.51% <0.00%> (-1.23%)
:arrow_down:

client.go
61.68% <0.00%> (-0.53%)
:arrow_down:

model_transaction_config.go
84.08% <0.00%> (ø)

model_draft_transactions.go
75.21% <0.00%> (+0.30%)
:arrow_up:

chainstate/client_options.go
91.21% <0.00%> (+0.70%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22bb38b...8e88d87. Read the comment docs.


Temporary error handler wrong log dir

Good day. In WebApplicationRunner::createTemporaryErrorHandler class FileTarget take first argument as `dirname(DIR) . '/runtime/logs/app.log'. But it's create /runtime/logs/app.log in src directory extends of @root/runtime. Thanks

This issue seems to be fixed in yiisoft/yii-runner-http.


Regex "Classifier"

Proposed changes:

closes #9328

Status (please check what you already did):

[x] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

Why is the RegexInterpreter in shared? -- If it is because of the functionality that is now included in this "handler" component, then I guess I should move it back to shared and create a graph component in rasa.nlu that just wraps the class from shared (i.e. adds a create).

@ka-bu I guess it was only because other stuff from shared depends on it (for example, rasa.shared.importers.importer).

@wochinge  , test-core-featurizers, ubuntu-latest, 3.8 fails with this mitie error.  ....?
_____________ ERROR collecting tests/nlu/utils/test_mitie_utils.py _____________
ImportError while importing test module '/home/runner/work/rasa/rasa/tests/nlu/utils/test_mitie_utils.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.8.11/x64/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/nlu/utils/test_mitie_utils.py:10: in <module>
    import mitie
E   ModuleNotFoundError: No module named 'mitie'

I re-ran. I hope it's just some flakiness. From the logs it appears as if the dependency was installed correctly

I re-ran. I hope it's just some flakiness. From the logs it appears as if the dependency was installed correctly

should've thought of that - thanks!


Expose container ref in Grid

Hey!
I need to be able to imperatively call ref.scroll({ left: n, behavior: 'smooth' }) on the container of a virtualized grid based on users clicking a button - at present the lib doesn't have any way to expose that ref, think the simple approach here should work? Is this something you'd support?
Not sure if this really counts as a feature which needs testing or documentation, so I've left those for now.

[x] The existing test suites (npm test) all pass
[ ] For any new features or bug fixes, both positive and negative test cases have been added
[ ] For any new features, documentation has been added
[ ] For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
[x] Format your code with prettier (npm run prettier).
[x] Run the Flow typechecks (npm run typecheck).

Any chance someone could take a look at this? Happy to make any changes which might be requested!


v-on:change event not firing.

Hello Thank you for this tool.
change event is not firing.

Hi @TAUFEEQ1, since this acts like a wrapper for roundSlider the events will be treated as props. So the events should be passed like v-bind:change="handler" or :change="handler" instead of v-on. I have updated the same info in the readme also.
Check the below demo and let me know your comments.
https://codesandbox.io/s/vue-round-slider-event-binding-x2emq?file=/src/components/SliderDemo.vue
Thanks..

Hello, @soundar24 , The change handler is still not firing.
https://codesandbox.io/s/vue-round-slider-event-binding-o0e7j?file=/src/components/SliderDemo.vue

@TAUFEEQ1 yes I can find this issue. While click on the slider range, at that time change event was triggered. But when drag the handle and release, at that time change doesn't triggered (seems broken in the recent release).
I will fix this and release in.a couple of days. Good finding, thanks..

@TAUFEEQ1 The change event related issue was resolved, and updated in the below release [v1.0.1]
https://github.com/soundar24/vue-round-slider/releases/tag/v1.0.1
You can simply update to this version and confirm. I have updated in the same demo where change event is working fine.
https://codesandbox.io/s/vue-round-slider-event-binding-x2emq
Please check and let me know if you have any other concerns.. thanks...

Yes its working, Thank you.


Doc issue with GetObject

Hi !
I run into a leak when running mino with GetObject: I was using the doc and it does not call defer obj.Close()
I thought it'd be a nice addition in case people run into it as well!

If a function returns an io.ReadCloser - by contract it is expected that you close the reader after reading, not closing is your application bug and not understanding the contract presented.
However, we will update the doc to mention closing the reader 39267760ed9bb78c88d17be63fcafcefb767a366


[Suggestion] Make htmlTag the same color as htmlEndTag

It is pretty standard to make these two the same color (tried to find a color scheme that didn't do it and couldn't) and for me personally them being different is very distracting

I think it might be related to your plugin / syntax. What are you using for html?


Laravel 6.0

Will this package support Laravel 6.0?

Is this package still being maintained?

Probably not, his personal blog hasn't been updated in a while and he has almost no github contributions for the last year...
I've just sent him a friendly tweet on twitter (https://twitter.com/ltrunghieu) asking him to either transfer the repo or add a collaborator. Let's hope for the best ...

This is an awesome package, would be cool if it would support Laravel 6 in the future!

Thank you for all of your support. I'm updating this package (and my other packages). I am going to be more active on GitHub after my long busy time 😄 .
@celcius-jochen thank you for reaching me on Twitter. That message reminds me of my open-source projects that need updating.

I've updated this package with the release 4.0.0


Long description has odd line-break

Note the line-break between is and broken.
$ az storage container lease break -h

Command
    az storage container lease break: Break the lease, if the container has an active lease.
        Once a lease is
        broken, it cannot be renewed. Any authorized request can break the lease;
        the request is not required to specify a matching lease ID. When a lease
        is broken, the lease break period is allowed to elapse, during which time
        no lease operation except break and release can be performed on the container.
        When a lease is successfully broken, the response indicates the interval
        in seconds until a new lease can be acquired.

This is happening because the code that pulls in the docstring help text is preserving the line break.
The original text looks like:
        Break the lease, if the container has an active lease. Once a lease is
        broken, it cannot be renewed. Any authorized request can break the lease;
        the request is not required to specify a matching lease ID. When a lease
        is broken, the lease break period is allowed to elapse, during which time
        no lease operation except break and release can be performed on the container.
        When a lease is successfully broken, the response indicates the interval
        in seconds until a new lease can be acquired.

Since the first sentence is promoted to the short description, the first line gets shortened. If the library handles the text wrapping, we should be able to address this by stripping out the line breaks.


Cow: Watch cibrvarsity.uk

Cow requests the watch of the watch_keyword cibrvarsity\.uk. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

cibrvarsity\.uk has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


[proposal]: Add DefaultMap[K,V] or Map[K,V]::set_default like in Python

Currently, there is no concise way to set a default value for a key in Map[K,V]. The Map::get_or_default method returns the default value without updating the map. This makes tasks like word counting more verbose.
I propose adding a Map::set_default method that updates the map with the default value and returns it if the key does not exist.
Alternatively, a DefaultMap[K,V] could be introduced to automatically create entries for missing keys. This would be particularly useful if it follows a standard Map trait.

I propose adding a Map::set_default method that updates the map with the default value and returns it if the key does not exist.

This looks good to me

As my experience, DefaultMap and MultiMap is more useful than set_default

I prefer set_default (or merge if possible). In my experience, set_default is primarily used during the building phase. For the rest of the time, sticking to get ensures safety.


[GDP] Add breadcrumb

Why is this issue important?
Sub-task of Grant Detail Page sprint.
Current State
Converted modal doesn't yet have a breadcrumb.
Expected State
Breadcrumb should be at the top of the new Grant Detail Page as described in the design
Implementation Plan
Changes should be made to GrantDetails.vue, which will only be in use when the GDP feature flag is in use.
Relevant Code Snippets
No response

Design file for Grant Details, to be reviewed on Mon 1/15:
https://www.figma.com/file/yQx55VTr5awPYClHIJCz8y/Grant-Details?type=design&node-id=1110-2419&mode=design

this is what it might look like when the title is really long.  @caitlinwinner does that seem right?

Caitlin & Mouna to review and come back wtih proposal for back and home

Un-assigning and moving back to Ready as I prepare to roll off of Grants.  Existing work is on the 2369-gdp-add-breadcrumb branch.

@TylerHendrickson can you please add implementation details?

@ClaireValdivia Implementation details added

These buttons are working as expected, but the styling doesn't seem to match what is in the design here
I think the link I had provided before may have gotten out of date. @inaki would you be able to adjust the styling to match the design linked above? The wording you have is correct, but I think the font/size/underline need to be adjusted

@inaki  Styling looks good now, just need "Back to Results" to change to just say "Back" when navigating from anywhere inside the app.
Link looks great when coming to the page not from within the app

Just tested in staging and looks great!


remove xtend dep, closes #1044

Removes extend from Dat. Let's also get it out of these other dependencies:

~dat-node~
~dat-registry~
~dat-json~
~subcommand~
[check others]

I think we've got all of them under our purview.


Update webhook types

:tada: This PR is included in version 1.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Missing fields in generated marshaler/unmarshaler when the object extends other objects

Problem statement
When an object extends other objects (using allOf), the generated Marshaler and Unmarshaler don't handle the fields in enclosing object.
The fix to #847 looks good (not tested myself)
Swagger specification
swagger.yaml
Steps to reproduce

generate server from the swagger file.
swagger generate server
verify the generated models/b.go file.
expecting field F3 and F4 are handled correctly in MarshalJSON and UnmarshalJSON methods.

Environment
swagger version: from 71225c4a7882ae49cd57e22292a58dff382908e8 to 0.10.0 and the latest
go version: go version go1.7.1 linux/amd64
OS:   Linux test 3.10.0-327.18.2.el7.x86_64 #1 SMP Fri Apr 8 05:09:53 EDT 2016 x86_64 x86_64 x86_64 GNU/Linux

See the diff that compare the fix 847 with 7125c.

I'm seeing this problem as well.  The generated JSON Unmarshallers don't handle property extensions correctly.

FWIW's my problem was with generating the client. I realized my swagger api yaml was subtly wrong. In order to get the data composition to work correctly with codeGen, I had to add the extra properties to the 'allOf' array, instead of being in the outside of that array. I noticed my problem when I looked at this example in the swagger spec documentation.
definitions:
  ErrorModel:
    type: object
    required:
    - message
    - code
    properties:
      message:
        type: string
      code:
        type: integer
        minimum: 100
        maximum: 600
  ExtendedErrorModel:
    allOf:
    - $ref: '#/definitions/ErrorModel'
    - type: object
      required:
      - rootCause
      properties:
        rootCause:
          type: string```

Any news about this issue?

As sethcleveland noted, the allOf format in the Swagger document is incorrect.

Yes! thanks!
Works for me.
Just to make it clear to next person who meets this:
definitions:
  ErrorModel:
    type: object
    required:
    - message
    - code
    properties:
      message:
        type: string
      code:
        type: integer
        minimum: 100
        maximum: 600
  ExtendedErrorModel:
    allOf:
    - $ref: '#/definitions/ErrorModel'
+    - type: object
+      required:
+      - rootCause
+      properties:
+        rootCause:
+          type: string
-   type: object
-   required:
-   - rootCause
-   properties:
-     rootCause:
-       type: string

I think this issue can be closed, right?

Common problem with yaml is that errors are just a space away. This a big concern for spec validation.
I suggest we let the original issue raiser close this if appropriate.

I'll re-test with the suggested solution.
Thanks

The yamls in both cases is valid, and the swagger UI shows both of them the same.

@posener That's good to know.  I tried using allOf that way in the past, but ran into issues, and changed it to match the examples in the spec, which always showed the two complete objects nested under allOf.  I thought that there had been Swagger validation errors, but maybe it was only go-swagger errors, meaning this one.

Retested and it works with correct spec (both cases). Going to post this in PR as yet another non-reg UT.
@posener : the first invalid spec is correctly detected as invalid by swagger validate (I admit that the error message is not obvious to understand).

The version 0.15.0 works with correct syntax. But it didn't report any errors with incorrect syntax.
incorrect $ swagger validate swagger.yaml
2018/07/18 15:49:44
The swagger spec at "swagger.yaml" is valid against swagger specification 2.0

This is indeed a valid JSONSchema specification, but unsupported by codegen as for now. See recent issue which follows the same structure as yours: #1617


Add custom formatter

Break out the error string generation into an interface. This way the formatting can easily be changed and possibly allow for user defined formatting.
Possibly allow for json structure or toml or something else?

Included with https://github.com/thenorthnate/evs/pull/5


Many companies rather not say

In money/notsay.
One thing might be that they are afraid of the legal ramifications if someone gets hurt by the project or by the feature they sponsored. It is less likely that someone will sue an individual developer as they cannot expect any real compensation, but if there is a corporation with deep pockets is somehow associated with the project or with a specific feature then this can increase the risk of being sued despite the license on the project. Someone might even think they are entitled to support from the sponsoring company.
If you agree I can send this as a PR as well.

This was one of the explanations I've heard. Was this the real reason? I don't know.


Missing gconf2 dependency with Ubuntu 17.04 (Zesty)

Ubuntu 17.04 doesn't ship anymore by default gconf2 (it uses dconf), so on a fresh Ubuntu 17.04 install you get this error after installing VSCode:
$ code
/usr/share/code/bin/../code: error while loading shared libraries: libgconf-2.so.4: cannot open shared object file: No such file or directory

this is easily fixed by:
$ sudo apt install libgconf-2-4

but the dep should nonetheless be in the .deb package (or maybe Electron/VSCode should use dconf too, but that's another story)
EDIT: fixed package name

Hmm, I'm running Ubuntu 17.04 and I don't have that installed. Any idea why I'm not experiencing it?
~/dev/Microsoft/vscode @master +1/-1
❯ dpkg -s libgconf2-4
dpkg-query: package 'libgconf2-4' is not installed and no information is available
Use dpkg --info (= dpkg-deb --info) to examine archive files,
and dpkg --contents (= dpkg-deb --contents) to list their contents.

Sorry, my bad, you should apt install libgconf-2-4, libgconf2-4 is a virtual, transictional package, so if you don't have it installed, nothing breaks. You should indeed have libgconf-2-4 installed, which is the package that provides /usr/lib/x86_64-linux-gnu/libgconf-2.so.4

@vide oh I only put that there because apt install libgconf-2-4 was going to install a new package:
~/dev/Microsoft/vscode @master +1/-1
❯ sudo apt install libgconf2-4
[sudo] password for daniel:
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
  libgconf2-4
0 to upgrade, 1 to newly install, 0 to remove and 12 not to upgrade.

@Tyriar the output you pasted means that you already had libgconf-2-4 installed (otherwise it would be pulled by libgconf2-4), that maybe you installed with something else (I think that any electron app needs gconf2). But on a pristine Ubuntu 17.04 gconf2 is not installed anymore, leading to the error I reported

@vide oh? I'm confused?
It says 1 to newly install in the output, 0 to upgrade. Doesn't that mean it's not installed?

@Tyriar you missed the edit on the original post: try to install the libgconf-2-4 package, please. Please note the extra dash between libgconf and 2.

Doh, my bad.

@vide related to this is https://github.com/Microsoft/vscode/issues/13089, right now we're not specifying many dependencies for the .deb. If you know of a nice way of getting the actual package names (eg. libgconf-2-4 not libgconf-2.so.4) that I could run I can go ahead and do that. That's the only thing blocking me there.


update phpbench

Bumping the minimum required version of phpbench to get a fix for an issue that was causing the benchmark script to fail in my PHP 7.4 environment.
Also, for some reason the syntax listed on contributing.md doesn't work for me, so I've updated it to what does work. If I'm just not understanding something simple please let me know.

Coverage remained the same at 86.31% when pulling 78fbc17d6a579ad7619af16bc3ef222a50f577bc on shmax:fix-phpbench into 0dd030e0074cd4774620608408ad9bfae95b902f on webonyx:master.

Thanks for the quick review!


social posts aren't updated live anymore

E.g. do
http://localhost:8080/shell/apps/web/?arc=-LDoDjH2XMjGkBRogp5i&user=-LBYGLHNzVrAvHho_nzX
and in another window play a word game and share it (e.g. as Walt or Maria or almost any of the other users, as long as they are Berni's friends :) )
expected: post immediately appears at the top
actual: post doesn't appear at the top until after a reload of the arc

At least on my system (though it sounds like @sjmiles is getting a different result), the data just doesn't arrive in the social feed's handle until I reload.
e.g. if I open a console on the feed and do arc._stores[4]._version, it might be 9 (for arguments sake). Also there are 9 entries in the collection.
Then I create a new game arc, share it, wait, and look at arc._stores[4]._version again. It's still 9 and there are still 9 posts. My new game hasn't shown up in the feed.
I reload, and immediately, arc._stores[4]._version has been updated to 10, there are 10 entries in its collection, and my game has shown up.
What does this imply? Somehow the data isn't getting from firebase back into the store until a reload occurs. I have no idea why this would be happening though :(

It looks like the reason @shans and I were seeing different things was due to a *Ranker particle that consumes the raw post list and produces a sorted post list. I was looking at the raw post list and @shans was looking at the sorted list. The problem appears to be that Ranker is operating on slightly stale data (pre-change data is delivered while processing the change event).

I more-or-less managed to trace this back to something that looks a lot like the issues we were having when we tried to build the github integration.
Mick's new event API is designed to fix these issues, so I switched PostTimeRanker over to using that instead. That seems to work well.


NextJS example out of date

Hey Phrase Team,
it seems that with the recent releases of NextJS and next-il8next@8 the configuration has changed quite a bit.
We don't have configurable il8next instances anymore but rather a config file that is mounted in next.config.js:
Docs example:
https://github.com/isaachinman/next-i18next
next-i18next.config.js
module.exports = {
  i18n: {
    defaultLocale: 'en',
    locales: ['en', 'de'],
  },
}

What's the recommended way to attach the i18next-phrase-in-context-editor-post-processor here?
Thanks in advance!

I have tried the following approach:
const path = require('path');
const PhraseInContextEditorPostProcessor = process.browser
  ? require('i18next-phrase-in-context-editor-post-processor').default
  : require('i18next-phrase-in-context-editor-post-processor');

module.exports = {
  i18n: {
    defaultLocale: 'en',
    locales: ['en', 'de', 'ja'],
  },
  localePath: path.resolve('./public/static/locales'),
  use: [
    new PhraseInContextEditorPostProcessor({
      phraseEnabled: true,
      projectId: 'xxx',
    }),
  ],
  postProcess: ['phraseInContextEditor'],
};

but then I get the following Server error:
Error: Error serializing `._nextI18Next.userConfig.use[0]` returned from `getStaticProps` in "/".
Reason: `object` ("[object Object]") cannot be serialized as JSON. Please only return JSON serializable data types.

ok, so I think I have found the answer myself,
in addition to the changes above, in my _app.ts file I had to do this:
import index18nextConfig from 'next-i18next.config';
....
export default appWithTranslation(App, index18nextConfig);

This is my currently working setup with typescript and latest nextjs
next-i18next.config.js
const path = require('path');
const PhraseInContextEditorPostProcessor = process.browser
  ? require('i18next-phrase-in-context-editor-post-processor').default
  : require('i18next-phrase-in-context-editor-post-processor');
const defaultLocale = 'en-AU';
const locales = ['en-AU', 'en-GB'];

exports.defaultLocale = defaultLocale;
exports.locales = locales;

module.exports = {
  i18n: {
    defaultLocale,
    locales,
  },
  localePath: path.resolve('./public/locales'),
  defaultNS: 'common',
  serializeConfig: false,
  use: [
    new PhraseInContextEditorPostProcessor({
      phraseEnabled: process.env.NEXT_PUBLIC_PHRASE_ENABLE_INLINE_TRANSLATIONS === 'true',
      projectId: process.env.NEXT_PUBLIC_PHRASE_PROJECT_ID ?? '',
    }),
  ],
  postProcess: ['phraseInContextEditor'],
}

next.config.js
const { i18n } = require('./next-i18next.config');

module.exports = {
  i18n,
  ...
}

src/pages/_app.tsx
import nextI18NextConfig from 'next-i18next.config';

...

export default appWithTranslation((MyApp as unknown) as React.FC, nextI18NextConfig);

src/pages/index.tsx
...
import { serverSideTranslations } from 'next-i18next/serverSideTranslations';
import { useTranslation } from 'react-i18next';
import { defaultLocale } from 'next-i18next.config'; // local config file

...
export const getStaticProps: GetStaticProps = async ({ locale = defaultLocale }) => {
    return {
        props: {
            ...(await serverSideTranslations(locale, ['common'])),
        },
        revalidate: +(process.env.NEXT_PUBLIC_STATIC_PAGES_CACHE_TIME ?? 86400),
    };
};

export default Home;

Also I have typings in next-env.d.ts file
// import the original type declarations
import 'react-i18next';
// import all namespaces (for the default language, only)
import common from 'public/locales/en-AU/common.json';

declare module 'react-i18next' {
    interface Resources {
        common: typeof common;
    }
}

We have decided to close all GitHub issues and, instead, handle them through our Customer Support. We think this shift will allow us to offer proper prioritization of issues as well as a more appropriate response time that would be expected from Phrase products.
We apologize for any inconveniences this may cause. If you believe your issue is still relevant or has a high priority, please contact<EMAIL_ADDRESS>and we can take more direct action toward finding a solution.


Initial commit for Native Account Abstraction EIP

EIP draft to support a native account abstraction transaction type. This is one of three EIPs: AA transaction, aggregation, validation rules.  See https://hackmd.io/@alexforshtat/native-account-abstraction-roadmap
and https://vitalik.eth.limo/general/2023/09/30/enshrinement.html

Thanks for reviewing, @lightclient !

Some initial thoughts. There is a lot here, still don't fully follow the entire flow. I think a diagram of the stages of execution could help a bit. Maybe you already have this.

Good idea, we will add a diagram.

This is a very complex change to the protocol. I think you are going to have a hard to getting EL teams interested in this change for this reason.

Initially we're not aiming for L1 mainnet.  The early adopters are likely to be L2 networks that are already considering some form of native account abstraction.  Some networks already enshrined modified versions of ERC-4337 in different ways.  This EIP is an attempt to standardize a safe way of doing this, to ensure protocol safety and to avoid ecosystem fragmentation.  E.g. the need for chain-specific wallets.
Having said that, we do need feedback from L1 devs.  After gaining traction on multiple L2s, there may be user demand to backporting it to L1 so we need to ensure that design choices don't conflict with L1 plans and make this harder than it needs to be.
As for the level of complexity, we tried to make it as simple as possible while retaining the safety properties of ERC-4337.  For that reason we moved the complexity of the ERC-4337 validation rules to a separate EIP which can be handled at the mempool level (and is not mandatory for the use of type-4 transactions unless they use that mempool).  If you see ways to further simplify this EIP without losing these properties, we're very interested to discuss them.

I think the strongest motivator for this is point 3) in the motivation: 4337 not benefiting as much from crLists. Otherwise, I don't think the other motivating factors are strong enough to take on the risk and complexity of this EIP.

crLists are indeed one of the primary motivations, but Vitalik pointed out a few others - see the "Enshrining ERC-4337" section of his recent post.  Gas efficiency, for example, is an important factor.  The network currently subsidizes EOA, loading and executing its validation code for free (21000 gas, which AA accounts also need to pay in addition to loading and executing their own validation code).  This is a major hindrance to the adoption of AA.

Additionally, I don't think it is a good idea to enshrine application layer standards into the protocol (solidity abi, func selector, etc). I think it is best to keep the two worlds separate.

I share that concern.  However, smart accounts are implemented as a contract, and the protocol needs a way to communicate with it in order to separate validation from execution, which is essential for AA if we want a DoS resistant mempool.  My initial thought was to try to achieve this with EIP-2938 PAYGAS instead of enshrining an interface, but it became harder to retain some of the safety properties of ERC-4337.  For example, running all validations before any execution is essential for protecting block builders against DoS, and can't be done if the separation happens during transaction execution.
Another option would be to use EOF and add multiple code entrypoints to the contract, so it would have a separate entrypoint for validation (which only smart accounts will populate, while other contracts won't).  But adding a dependency on EOF would significantly delay adoption, which may result in more L2 networks enshrining an incompatible solution.  Therefore we chose to favor a solution that doesn't add dependencies on other future EIPs.  When EOF is finally merged, it'll be possible to have a modified version of this EIP that uses code sections, and combine it with an ERC that makes it compatible with the current EIP.
Smart account developers are typically solidity developers, and are comfortable with using interfaces.  If we come up with a different scheme we'd probably have to wrap it in a way that is compatible with how ERC-4337 interfaces work.
Do you see another way to avoid enshrining an interface?
As a side note, Ethereum already enshrined a solidity ABI in DepositContract.  CL has an implicit dependency on an EL contract, even though the ABI may not be a part of the protocol specs.
Another question I wanted to get your input on, is SSZ vs. RLP.  The EIP uses RLP encoding and adds an EIP-2718 transaction type, because it's how wallets currently work.  However, there's a plan to move things to SSZ.  My initial preference was to use RLP in order not to add unnecessary friction to existing wallets that want to support the new type.  WDYT?

Anyways, nice work on this proposal. A lot of work has gone into it and

Thanks!  We really appreciate your feedback and looking forward to collaborating further.

Thanks @hazim-j !

First off, amazing effort on this initial draft for native account abstraction!

Thanks!

the EIP has a very similar flow to ERC-4337, but there seems to be enough differences to make it not entirely backwards compatible

One of the goals is actually to make the flows equivalent, making migration as easy as possible.

From my understanding, this does not seem to be the case. Current smart contracts would still need to be upgraded to support new interfaces.

Yes, contracts will need to be upgraded to support the new standard, but the different phases, the validation rules, etc. remain the same.  The struct is different so it requires a different function, but validateUserOp and validateTransaction could just parse the struct and wrap a unified implementation of the account’s validation.  We will provide a template for this.

and then reduce to just the latter post transition period.

Not necessarily reduce it after transition.  The account can be deployed on different chains.  Ones that don’t use native AA and continue to use ERC-4337, ones that use native AA from the start, and ones that go through a transition process.  I think it’ll make sense for accounts to support both interfaces as long as there are chains without native AA, which will continue to be the case at least for a number of years.

In this case, what would be the rationale for CAs to upgrade their EP to an adapter contract? Is it purely to help re-route AA_TX_TYPE methods to their 4337 counterparts?

An adapter is just the easiest way for an account to migrate to native AA with as little changes as possible.  But in the long run I think it’ll make more sense to directly support the new interface in the account and not add the overhead of the adapter.  The EIP is not opinionated about this.  It’ll be up to each account developer, and we’d like to offer the tools to make the transition as easy as possible.

On the client side, there would still be some effort required to migrate from UOs to an AA_TX_TYPE

Yes, wallets will need to support the new transaction type and become familiar with the associated RPC.  But if the account supports both modes, it’ll remain usable with UserOps as well so it’ll be able to continue using wallets that are still unaware.  It’s similar to the transition to EIP-1559.  Legacy transactions remain possible if you’re using a legacy wallet - they’re just less efficient.

How is this possible if a userOpHash is signed based on different values to a TransactionType4?

Right. It would require the account to convert the TransactionType4 back to a UserOperation and hash it (on-chain).  I’m not sure this would make sense, because if the account is already aware of both structs, it could just accept both UserOps from the 4337 EntryPoint and TransactionType4s from the native EntryPoint.  Maybe we'll just remove it, and the account will instead support both modes directly.

I think more details/diagrams on the migration path would helpful here. Especially for teams who are currently building production applications on 4337 and need to understand what is exactly required to transition to native AA.

Yes, we should have a separate document outside of the EIP, that focuses on migration.  We’re still far from finalizing the EIP so it may be able to write it when the details are more or less known.  Our goal, however, is to ensure that projects built on 4337 will have an easy migration path.  You can safely continue building for 4337 and assume that there will be a migration path that doesn’t require a major rewrite :)   You are also welcome to join the effort and help us make sure things are done that way.

Not much to say on this part yet, but based on how complex gas estimation has been for UserOperations, I'd be interested to see how similar the process for estimating an AA_TX_TYPE would be.

It should actually be quite similar.

I see that we now have paymasterGasLimit as opposed to using validationGasLimit like in 4337. What was the rationale behind this as opposed to using validationGasLimit for the paymaster validation frame andcallGasLimit for the paymaster post-transaction frame?

The rationale has to do with some corner cases we’ve discussed lately, where staked entities could affect each other’s reputation. For example, a rogue deployer could use its own state to detect on-chain execution (as opposed to single simulation), and waste more validation gas in order to cause the paymaster to revert at its own reputation expense.  After discussing a few such cases we came to the conclusion that it’s best to separate it to two limits.
It will be compatible with 4337 since we intend to propose this change to 4337 as well.  The same may be true for other ways in which the EIP differs from 4337.  By the time we finalize both the ERC and the EIP, they’ll be mostly equivalent and therefore migration will be trivial.

What was the rationale behind a new RPC method rather than extending eth_estimateGas?

Different return values.  eth_estimateGas returns one value, whereas the new RPC returns something more complex.  It doesn’t seem right to change the return value type of an existing EIP and possibly break existing tools that are unaware of it.

Also since fee value isn't returned by eth_estimateGas, why does this method return builderFee instead of having something similar to eth_maxPriorityFeePerGas for AA_TX_TYPE?

builderFee serves a different purpose.  Note that it is denominated in wei rather than gas.  It’s a generalization of EIP-4337’s preVerificationGas.  A fee that is paid to the bundler/builder in addition to the gas fees.  It’ll be used in different ways on different chains.  In 4337 it’s things like the 21000, calldata cost, etc.  In native AA it may be things like signature aggregation fee, ZK proving cost, L1 calldata gas for rollups, etc.  The node will know how to suggest a number that enables inclusion.  The user may choose to use a smaller number but it may delay inclusion (or even prevent it if it’s too low).  E.g. if the account uses an aggregator, a lower number will mean that the transaction will only be included when there are a lot more transactions with the same aggregator in the mempool.  Or if it’s a sequencer that writes calldata to L1, setting it too low may delay inclusion until L1 gas cost drops.  These things are not directly associated with the amount of gas consumed by the transaction, so it required a wei-denominated fee.

Just finished reading the full EIP, great work and congratulations on this milestone.

Thanks!

Very excited about this. Great work team!

Thanks @dancoombs , for so many insightful comments.

Left some initial thoughts. Will probably read this a few more times and add more. Apologies for nits, left comments on things that were unclear to me coming from a 4337 background.

Much appreciated.  I think I replied all of them.

From my perspective, the hardest things to get right as an ERC-4337 bundler, aside from the validation rules, have involved gas estimation. My most pressing comments are around the builderFee definition and changes to the gas estimation RPC.

See my explanation of  builderFee above. I don't think we can avoid it without losing important use cases, although it could be set to zero in all other cases.  See separate comment.

As it seems like the function names are changing for the smart contracts, we should ensure that ERC-6900 can handle both definitions as users may want to use both 4337 and enshrined-AA.

Yes, after this EIP is finalized we should extend ERC-6900 to support this as well.  It should be straightforward because the flows remain the same, so it's just different names.


put user defined configs to the front of the list

Fix #118

Makes sense! Gonna merge it to develop and I'll include it in the next version.


Bürokratt understands Riigikogu-related questions in natural language

[!NOTE]
This is a sub-issue of #81

Acceptance Criteria
NLU
Bürokratt detects intended services based on End-Clients input in natural language in the following scope:

[x] #82
[x] #83
[x] #84

Service triggering
Bürokratt triggers intended services based on End-Clients input in natural language in the following scope:

[x] #82
[x] #83
[x] #84

Working as intended. Inputs are described under task: https://github.com/buerokratt/Common-Services/issues/81#issuecomment-2461582700


Redundant section in Docs

In the AIRR Standards section, we have:

Study Reporting (MiAIRR)
Data Model
V(D)J Sequence Representation
Metadata Representation
Software Guidelines
Data Commons API
Ontologies and Vocabularies
Schema Release Notes

Under Data Model, we have:

Requirement levels of fields
Repertoire Schema
Rearrangement Schema
Alignment Schema (Experimental)
Clone and Lineage Tree Schema (Experimental)
Cell Schema (Experimental)
Cell Expression Schema (Experimental)
Germline Schema (Experimental)
Receptor Schema (Experimental)

AIRR Standards -> V(D)J Sequence Representation just links to AIRR Standards -> Data Model -> Rearrangement Schema
AIRR Standards -> Metadata Representation just links to AIRR Standards -> Data Model -> Repertoire Schema
This is confusing and I think a left over from past days when that was all there was???
I would suggest removing the menu items:
AIRR Standards -> V(D)J Sequence Representation
AIRR Standards -> Metadata Representation

It's deliberate. The intent being to make the two primary use cases easier to find. I think Data Model is too high up the tree.
Though, we need to rework "Getting Started" so we can do this better via that page.

It seems quite confusing to me - maybe partially because the names are so different, maybe partially because I am so past just being about Rearrangements 8-). I suppose since the other schemas are still "Experimental" this makes sense but for v2.0 I would hope that we would be past that???
One confusing thing is you click on Metadata and it takes you to Repertoire and you click on V(D)J Sequence Representation and it takes you to Rearrangement.  The links between the two wordings are not obvious...
If you want you can close this and create a different issue as you see fit, although maybe it makes sense to keep it open for v2.0 release?

I agree that the organization seems somewhat odd. The Data Model section is meant to introduce all of the objects and their relationship to each other, I think it does a somewhat decent job there.
One thing I've always found odd is that if you go under MiAIRR, it doesn't really tie into any of the appropriate data standards. One idea is that Metadata and V(D)J Sequence go under MiAIRR.
Another idea as Jason suggests is to fill out Getting Started so that it does a better job of explaining the organization of the website and where to find things.

From the call: Discuss again in January, potential strategy for v2.0 might be to complete the Docs first in terms of content and then have a look at a meaningful and consistent structure for the individual sections.

From the call:

@ustervbo will offer some opinions on the structure.
Otherwise, yes, we'll work through the v2.0 docs and then sort out the structure.

I agree with Brian and Scott; the organization is odd, and I think that the sections V(D)J Sequence Representation and Metadata Representation should only be subsections somewhere.
We can (and probably should) add more information to Getting Started, but I don't think it will solve the confusion in the structure and the redundant entries.
Reading through the documentation front to back, I have found other oddities:
I perceive the Study Reporting (MiAIRR) section as merely providing an overview. Details are left to the further subsections, each of which serves as a reference. The subsection MiAIRR-to-NCBI Specification is out of place and is probably better off in Data Submission and Query alone.
The section Metadata Annotation Guidelines in Study Reporting (MiAIRR) doesn't tie to anything and seems to come out of left field. Its purpose is very confusing, but maybe, based on the coincidence of 'Metadata', it thematically goes with Metadata Representation.
The TOC entry Study Reporting (MiAIRR) is probably better as Introduction to MiAIRR, because that is what it is - it is not about how to report a study. The section can keep MiAIRR Data Elements as a subsection. I think it should be the only subsection. Everything else should go someplace else.
Should the TOC entry Data Model be named Data Representations? At least then it matches the heading in the document it points to. Also, Data Model is only a subsection in that document. Irrespective, the TOC level can be the same as it is, and subsections can also stay. The Annotation Guidelines could go into this TOC element too.
The connection between the Data Model and the primary schema objects of the AIRR Data Model is missing. The first four schema objects are easy to place; the rest require some guesswork.

From the call:

Redesign TOC tree from use case perspective
Write Getting Starting
Follow above from @ustervbo to start.

Changed to AIRR 2.0, since this is not ADC specific.

We have three types of potential readers:

People like my boss - very high level

Wants to know what it is about
Focus on top level entries and glossy pictures

People like me - medium level

Wants to use the standard
Focus on practical examples and tutorials

Most of AIRR-Std WG - low level

Wants to know the technical aspects
Focus on implementation

We also have two major areas to cover - MiAIRR and Data Model. It makes sense if these two can be read on their own, so some degree of redundancy is required.
Suggested TOC/Outline for AIRR Standard documentation
Note: I am not sure where to place the documentation for the Software WG, especially since it easily conflicts with the 'Software' section, altough this might be handled with a better naming.

Overview Getting Started [comment: The text is much more a detailed overview than a 'step 1: Download the software, step 2:...']
AIRR Standard

Study Reporting (MiAIRR)
Data Model
V(D)J Sequence Representation
Metadata Representation
Data Commons API
Ontologies and Vocabularies
AIRR Compliant ToolsSoftware Guidelines [comment: I place this last, because all other entries are about obtaining and storing information and this is about tools that use the AIRR-Standard and fulfil some requirements. Rename section to set focus]

List of compliant tools
Guidelines
Check list
Evaluation Data Sets

Data Submission

MiAIRR to NCBI submission guide
CEDAR's CAIRR submission pipeline
VDJServer Community Data Portal
iReceptor Turnkey Repository
OGRDB

Querying Repositories in the AIRR Data Commons
Software

Python Library
R Library
JavaScript Library
ADC API Reference Implementation
AIRR Data Commons Repositories
Applications Supporting the Rearrangement Schema

Tutorials, examples and workflows

AIRR Rearrangement TSV Interoperability Example
ADC API Query and Analysis Example
Scientific Query Scenarios for AIRR Data Commons API
Guide for submission of AIRR-seq data to NCBI

Community

Resources and Tools Supporting AIRR Standards
Applications Supporting the Rearrangement Schema
Useful Websites for the AIRR Community
AIRR Data Commons
AIRR Data Commons Repositories

Glossary
References
Release Notes

Schema Release Notes
Python Library Release Notes
R Library Release Notes
JavaScript Library Release Notes

Hi Ulrik,
I think this looks really good. I added a tiny bit below in blue.
Thanks!

Lindsay G. Cowell, MS, PhD
Associate Professor
Peter O’Donnell Jr. School of Public Health
Department of Immunology, School of Biomedical Sciences
Population Science Program, Simmons Comprehensive Cancer Center
UT Southwestern Medical Center
5323 Harry Hines Blvd., Dallas, Texas  75390-9066
Office | G9.220E, MC9066
Phone |<PHONE_NUMBER>
Fax |<PHONE_NUMBER>
<EMAIL_ADDRESS>https://www.utsouthwestern.edu/education/public-health/
From: Ulrik Stervbo @.>
Date: Monday, July 15, 2024 at 4:22 AM
To: airr-community/airr-standards @.>
Cc: Subscribed @.***>
Subject: Re: [airr-community/airr-standards] Redundant section in Docs (Issue #730)
EXTERNAL MAIL
We have three types of potential readers:

People like my boss - very high level

 *   Wants to know what it is about
 *   Focus on top level entries and glossy pictures

People like me - medium level

 *   Wants to use the standard
 *   Focus on practical examples and tutorials

Most of AIRR-Std WG - low level

 *   Wants to know the technical aspects
 *   Focus on implementation

We also have two major areas to cover - MiAIRR and Data Model. It makes sense if these two can be read on their own, so some degree of redundancy is required.
Suggested TOC/Outline for AIRR Standard documentation
Note: I am not sure where to place the documentation for the Software WG, especially since it easily conflicts with the 'Software' section, altough this might be handled with a better naming.

Overview Getting Started [comment: The text is much more a detailed overview than a 'step 1: Download the software, step 2:...']
AIRR Standard

 *   Study Reporting (MiAIRR)
 *   Data Model
 *   V(D)J Sequence Representation
 *   Metadata Representation
 *   Data Commons API
 *   Ontologies and Vocabularies
 *   AIRR Compliant ToolsSoftware Guidelines [comment: I place this last, because all other entries are about obtaining and storing information and this is about tools that use the AIRR-Standard and fulfil some requirements. Rename section to set focus]

    *   List of compliant tools
    *   Guidelines
    *   Check list
    *   Evaluation Data Sets

Data Submission It might make sense to address data submission and metadata submission as two separate processes.

 *   MiAIRR to NCBI submission guide
 *   CEDAR's CAIRR submission pipeline
 *   VDJServer Community Data Portal
 *   iReceptor Turnkey Repository
 *   OGRDB

Querying Repositories in the AIRR Data Commons

 *   ADC API
 *   GUIs

    *   VDJServer Community Data Portal
    *   iReceptor Gateway

Software

 *   Python Library
 *   R Library
 *   JavaScript Library
 *   ADC API Reference Implementation
 *   AIRR Data Commons Repositories Not sure this fits under Software? We may need a Databases section that describes the ADC and its component repositories, OGRDB, VDJbase, and the AKC
 *   Applications Supporting the Rearrangement Schema

Tutorials, examples and workflows

 *   AIRR Rearrangement TSV Interoperability Example
 *   ADC API Query and Analysis Example
 *   Scientific Query Scenarios for AIRR Data Commons API
 *   Guide for submission of AIRR-seq data to NCBI

Community

 *   Resources and Tools Supporting AIRR Standards
 *   Applications Supporting the Rearrangement Schema
 *   Useful Websites for the AIRR Community
 *   AIRR Data Commons
 *   AIRR Data Commons Repositories

Glossary
References
Release Notes

 *   Schema Release Notes
 *   Python Library Release Notes
 *   R Library Release Notes
 *   JavaScript Library Release Notes

—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/airr-community/airr-standards/issues/730*issuecomment-2228053366__;Iw!!MznTZTSvDXGV0Co!BYaosHeaCIJgbu6aAk9CdKM_QJYYva9TeRf21Wdkl8N6c-3TmLe3R_E_aC2NBWUthISGgE5XDtuLprpuNyl7T39Ajsn_NW6UdbgWPQ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ABPC5BLJ5ERZD4PCQXBONULZMOIDRAVCNFSM6AAAAAA6QABVZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRYGA2TGMZWGY__;!!MznTZTSvDXGV0Co!BYaosHeaCIJgbu6aAk9CdKM_QJYYva9TeRf21Wdkl8N6c-3TmLe3R_E_aC2NBWUthISGgE5XDtuLprpuNyl7T39Ajsn_NW7-6Bwm3Q$.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
CAUTION: This email originated from outside UTSW. Please be cautious of links or attachments, and validate the sender's email address before replying.

UT Southwestern
Medical Center
The future of medicine, today.

Introducing a Databases section that describes the ADC and its component repositories, OGRDB, VDJbase, and the AKC is a good idea!
Here's a modified TOC outline with Lindsay's suggestions:

Overview Getting Started [comment: The text is much more a detailed overview than a 'step 1: Download the software, step 2:...']
MiAIRRAIRR Standard [comment: I think it makes sense to separate out Data Model, because it is growing in sub-sections. We should then have a section devoted to MiAIRR]

Study Reporting (MiAIRR)
V(D)J Sequence Representation
Metadata Representation
Ontologies and Vocabularies

Data Model

todo outline
Data Commons API

AIRR Compliant ToolsSoftware Guidelines [comment: I place this last, because all other entries are about obtaining and storing information and this is about tools that use the AIRR-Standard and fulfil some requirements. Rename section to set focus]

List of compliant tools
Guidelines
Check list
Evaluation Data Sets

Databases

AIRR Data Commons

AIRR Data Commons Repositories

OGRDB
VDJbase
AKC

Community [comment: Should be renamed]

Resources and Tools Supporting AIRR Standards [comment: This is also a subsection to 'Software']
Applications Supporting the Rearrangement Schema
Useful Websites for the AIRR Community

Querying Repositories in the AIRR Data Commons

ADC API
GUIs

VDJServer Community Data Portal
iReceptor Turnkey Repository

Data Submission [comment (Lindsay): It might make sense to address data submission and metadata submission as two separate processes]

MiAIRR to NCBI submission guide
CEDAR's CAIRR submission pipeline
VDJServer Community Data Portal
iReceptor Turnkey Repository
OGRDB

Software [comment: I understand the difference to the content of AIRR Compliant Tools/Software Guidelines, but it still clashes in my head]

Python Library
R Library
JavaScript Library
ADC API Reference Implementation
Applications Supporting the Rearrangement Schema

Tutorials, examples and workflows

AIRR Rearrangement TSV Interoperability Example
ADC API Query and Analysis Example
Scientific Query Scenarios for AIRR Data Commons API
Guide for submission of AIRR-seq data to NCBI

Glossary
References
Release Notes

Schema Release Notes
Python Library Release Notes
R Library Release Notes
JavaScript Library Release Notes

From the call:

The above looks like a good starting point, so let's starting moving stuff around in the toctree entries.


Set correct assembly version for IdentityModel assemblies

By default IdentityModel assemblies have a version of 0.0.1, which is the default version specified in the azure-activedirectory-identitymodel-extensions-for-dotnet repo. This differs from the Microsoft-produced versions of these assemblies that the SDK contains, which has an assembly version of 7.0.0.
This is fixed by explicitly updating the AssemblyInfo.cs file of each source project in the repo to have the desired version attributes. There's already an existing PowerShell script which does this. However, that script can't be executed in the context of source-build because it relies on PowerShell which is not source-buildable. Instead, that script has been ported to Bash.
Fixes dotnet/source-build#3565

I've submitted a PR to get this backported at https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2211.


ISPN-10059 Off-heap clustered cache cannot start with segmentation di…

…sabled
https://issues.jboss.org/browse/ISPN-10059

Implement addSegments/removeSegments in OffHeapDataContainer
Use the InternalDataContainerAdapter implementation in all
non-segmented InternalDataContainer implementations
Only retry the join request on failure

Updated to fix the retry, override InternalDataContainer methods in BoundedOffHeapDataContainer, and skip tests that require segmentation when the feature is disabled.

Updated to fix the retry, override InternalDataContainer methods in BoundedOffHeapDataContainer, and skip tests that require segmentation when the feature is disabled.
There's still a failure in ExpirationSingleFileStoreDistListenerFunctionalTest that might be related. Please run test suite with -Dorg.infinispan.feature.data-segmentation=false to verify.

I can confirm it consistently fails for me as well.

Integrated into master, thanks @danberindei !

We still need a JIRA for max idle expiration being available in iteration for non segmented containers in a cluster.

I created https://issues.jboss.org/browse/ISPN-10074, although when I created it I thought the problem was with the segmented containers returning expired entries.


Is there any way to trigger this when an event is added, updated or deleted?

Hi, I have a similar flow running that triggers "When an event is added, updated or deleted (V3)" and it syncs.  is there a way to make that the trigger for your version? I appreciate the more polished approach your flow takes. Any advice would be helpful

While technically possible, doing so would not be advisable. My flow takes a long time to complete (several minutes) and consumes many actions of your daily quota, which is why the trigger is in my flow only fired a few times per day. The "When an event is added, updated or deleted (V3)" trigger is executed rather often throughout the day, making it incompatible.


How to replace navigation button on pagination

Hello,
thank you for your pagination package is very helpful.
i have a question about when i need to change firstPageText it doesn't work the icon is showing but the action click doesn't work this my code :
<Pagination 						     activePage={this.state.activePage}
itemsCountPerPage={10}
firstPageText={
React.createElement('li', {className: ''},             React.createElement("a", {href: '#'}, React.createElement("i", {className: 'material-icons'}, "fast_rewind")))
}
totalItemsCount={100} 					      pageRangeDisplayed={5}
onChange={this.handlePageChange.bind(this)}
/>
thank's in advance.

Hi, i have fixed this issue already, i will deploy soon. I will let you know here

Hi, thank you so mush i'm waiting for you.
2016-12-27 21:37 GMT+00:00 Sergey<EMAIL_ADDRESS>
Hi, i have fixed this issue already, i will deploy soon. I will let you
know here
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vayser/react-js-pagination/issues/16#issuecomment-269386151,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMSjQ2vID5v0NCBSbAaZEqRaBO4LXNOVks5rMYT-gaJpZM4LWQJa
.

--
Mostafa Lafi
Développeur Web/Mobile
06 21 17 39 34

Hi, I published 2.0.2 version, you can replace buttons text like here http://vayser.github.io/react-js-pagination/#custom-navigation-elements

Great work man thank you so much.


About 2.4 documentation issues

I downloaded the AdminLTE 2.4 found the link to the document, pointing to the https://adminlte.io/docs, and unpacking the documentation directory, which is the 2.3.12 version of the document.
How can i download a document to version 2.4?
Because, I intend to AdminLTE 2.4 localized into Chinese, has now completed, 2.3.11 version.
From Google Translate

Hi
AdminLTE’s documentation has now moved completely online and there isn’t a way to download it at this point.
Sorry for the inconvenience.


Add flag to verify OIDC issuer in certificate

Summary

See #1305 for the refactor that's included in this PR.
This PR adds support for --cert-oidc-issuer to verify the OIDC issuer of a Fulcio certificate. In combination with --cert-email, users should be able to verify and pin the expected identity of the Fulcio certificate.
Also added certificate generation test utilities. These might be more useful in sigstore/sigstore.
Ticket Link

Ref #556
Release Note

* Added `--cert-oidc-issuer` to verify the OIDC issuer of a Fulcio certificate

Nice!
@mattmoor FYI for the policy task force

Awesome.  Looks like it needs a rebase

Rebased and updated with flag doc change. I also removed x509.ExtKeyUsage(x509.KeyUsageDigitalSignature) from the list of EKUs used during cert verification, because digital signature is not an extended key usage.


OWR to OWR broken

test-send-receive is very shaky, giving output which is very strange for localhost usage, like:
0:00:13.797182000  6613 0x7fb9b30d19e0 WARN         rtpjitterbuffer gstrtpjitterbuffer.c:2456:gst_rtp_jitter_buffer_chain:<rtpjitterbuffer1> Packet #10423 too late as #10464 was already popped, dropping
0:00:13.797211000  6613 0x7fb9b30d19e0 WARN         rtpjitterbuffer gstrtpjitterbuffer.c:2456:gst_rtp_jitter_buffer_chain:<rtpjitterbuffer1> Packet #10445 too late as #10464 was already popped, dropping
0:00:14.844525000  6613 0x7fb9b315b8f0 WARN               rtpsource rtpsource.c:1412:rtp_source_get_new_sr: no clock-rate, cannot interpolate rtp time
0:00:20.128171000  6613 0x7fb9b315b8f0 WARN               rtpsource rtpsource.c:1412:rtp_source_get_new_sr: no clock-rate, cannot interpolate rtp time
0:00:22.832046000  6613 0x7fb9b30d19e0 WARN         rtpjitterbuffer gstrtpjitterbuffer.c:2456:gst_rtp_jitter_buffer_chain:<rtpjitterbuffer1> Packet #12999 too late as #13028 was already popped, dropping
0:00:22.832146000  6613 0x7fb9b30d19e0 WARN         rtpjitterbuffer gstrtpjitterbuffer.c:2456:gst_rtp_jitter_buffer_chain:<rtpjitterbuffer1> Packet #13019 too late as #13028 was already popped, dropping
0:00:22.985626000  6613 0x7fb9b30d19e0 WARN         rtpjitterbuffer gstrtpjitterbuffer.c:2456:gst_rtp_jitter_buffer_chain:<rtpjitterbuffer1> Packet #13068 too late as #13068 was already popped, dropping
0:00:25.350223000  6613 0x7fb9b315b8f0 WARN               rtpsource rtpsource.c:1412:rtp_source_get_new_sr: no clock-rate, cannot interpolate rtp time

Similarly using openwebrtc-daemon to video chat with itself gives blackness. I wonder if this is related to #299.

Those RTP problems really shouldn't happen locally and hint at bigger problems somewhere else. I would first debug those and then after they are fixed it makes sense to look at anything at remains.
It might be related to the work I started on only starting to send packets once we actually can... because if we send too early stuff is even lost on localhost, and we also get bursts (that are currently not handled well in rtpjitterbuffer in GStreamer, there's a bug about that with an implementation plan for that)

I'm pretty sure I had NativeDemo working between two iPhones (using the older framework). Will need to double check.

#244 seems relevant.

Rob, did you try NativeDemo on two iOS devices?

Why closing?

I suspect it was an accident. Reopening.

@stefanalund - no but the daemon and test-send-receive showed similar problems and @ijsf observed the same in #244 with iOS I think.

Perhaps this commit makes a difference (see my relevant commit in #244): https://github.com/ijsf/openwebrtc/commit/997ac7e5b5a07572de2d6cd554d4788448c75d34

@ijsf - can you please submit pull requests for such changes?

I had iOS to safari and Safari to safari working the other day I think. But it was hit and miss. Sometimes it worked better than others. Sometimes just black. But it's clear we have some issues to address.

(sorry about the close, I have no idea how that happened, maybe a misclick)

Latest NativeDemo works between 2 iPhones:

As pointed out before, this app currently uses an older version of the OpenWebRTC.framework.

@stefanalund - cool. This is maybe two issues or just one but the timing with the daemon is such that it triggers more severely.
test-send-receive also works, but exhibits intermittent black frames in the remote view quite a lot. Do you see bursts of black frames in the remote view with native demo against itself?
I'll investigate this and ijsf's patch more thoroughly on Tuesday.

Yes, I see long sequences of black frames on both sides occasionally. Pretty sure it's not a NW issue as I'm sitting very close to the AP.
When the video is good, it's really good, like FaceTime good 😀

test-send-receive is now working with VP8 after https://github.com/EricssonResearch/cerbero/commit/4ca6e8b48e177fc56a6c5a2f4769678be99fc523 which will get fixed properly in this issue https://bugzilla.gnome.org/show_bug.cgi?id=747208 .
However, with H264 I think it is still not working in test-send-receive. I will check again and respond here.

It seems that the H.264 not working between OWR and OWR is something going wrong in the h264parse code: https://gist.github.com/superdump/1cc1d2206ac648004ddb
It gets stuck in a loop of requesting a new keyframe and then deciding that it can't parse the NALU:
0:00:01.063659000 70742 0x7f882483c000 DEBUG      codecparsers_h264 gsth264parser.c:1419:gst_h264_parser_identify_nalu_avc: Can't parse, buffer has too small size 82929, offset 82929

Backtracing in that error case gives: https://gist.github.com/superdump/a779c7c6877ce7ed840f
It seems a bit strange to me that the offset (third argument) passed into gst_h264_parser_identify_nalu_avc in this case is offset + size and not just offset, but perhaps that's that's correct...? http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/videoparsers/gsth264parse.c#n807 (the call is on line 865.)
I'm going to look att #299 some more and come back to this one.

Switching VP8 to H264 in test-send-receive works for me here on Linux. Anything specific I need to do to reproduce what you're seeing?

Agreed about sync and whatnot.
It could be something that changed with VideoToolbox then. There was a recent OS X and Xcode upgrade just a few days ago but I thought I saw this before then. Perhaps VideoToolbox is outputting a slightly different bitstream format now. Can you paste a gist of GST_DEBUG=h264:6? Maybe that will give clues.

Here we go: http://arunraghavan.net/temp/log.h264.txt (it's got the color information in, so you'll need to use less -RS)

A small update - I have tested with disabling RTX in test-send-receive and then modifying owr_payload.c to either explicitly create vtenc_h264 or openh264enc on OS X. With openh264enc it works. With vtenc_h264 I see the issue I mentioned in the comment above: https://github.com/EricssonResearch/openwebrtc/issues/311#issuecomment-91482542 .

This seems to only happen with H264 in test-send-receive on my MacBook Pro using VideoToolbox for encoding. Removing from release milestone.


Module boilerplate doesn't work as expected in webpack

The boilerplate at the top:
if (typeof define === 'function' && define.amd) {
		// AMD. Register as an anonymous module.
		define([], factory);
} else ...

is triggered for webpack for some reason. This would work in the same way, except that you're not defining the AMD module in the same way as the commonJS module. The commonJS module is an object with a HashMap key set to the HashMap object, while the AMD one is directly set to the HashMap object.
Could you make these more consistent by setting module.exports to factory() rather than exports.HashMap?

You mean like this?
if (typeof define === 'function' && define.amd) {
  // AMD. Register as an anonymous module.
  define([], factory);
} else if (typeof module === 'object') {
  // Node js environment
  var HashMap = module.exports = factory();
  // Keep it backwards compatible
  HashMap.HashMap = HashMap;
} else {
  // Browser globals (this is window)
  this.HashMap = factory();
}

Yeah, exactly

Thanks! I had an issue in a project which would have caused me a lot of headache if this change wasn't made : )