eureka: detect _ in the trackerRegex

It's possible for the tracker id to be generated with an underscore.
Example: https://ffxiv-eureka.com/v3y_9B

Thanks for the fix!


fix: pullsync ignore overwrite error

Checklist

[ ] I have read the coding guide.
[ ] My change requires a documentation update, and I have done it.
[ ] I have added tests to cover my changes.
[ ] I have filled out the description and linked the related issues.

Description

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

@mrekucci so in some places in pushsync/pusher code we only add 1 chunk at a time... So we did not need to handle session related stuff. Secondly we cannot include storer package in pusher/pushsync code as the pusher.Op is included in storer so there is a cyclic dependency. To fix this we would have to move Putter session into the storage interfaces. We can do that later if required.


Make the TaskQueue big lock fair

This is related to https://github.com/druid-io/druid/pull/1862 where there might be a timeout during a shutdown request.
If the big lock is not fair, then it is very possible for the while(active) loop to simply acquire the big lock again and timeout again.
This makes the big lock fair to allow multiple other operations to squeak in between retries.

:+1:

:+1:


Problem about saving .mp4 files during training process

Hi, Julian.
Sorry to disturb you. The research is so great! I am trying to refactor that on my custom dataset. But I am trapped with the problem about saving .mp4 files during training process. I can not save the .mp4 file by "ani.save(f'{ROOT_DIR}diffusion-videos/ARGS={args["arg_num"]}/sample-EPOCH={epoch}.mp4')"
The error message indicates issues with the ffmpeg encoder, mentioning "incorrect library version loaded' and 'Error initializing output stream 0:0'. It suggests that there might be incorrect parameters such as bit_rate, rate, width, or height."
I have already checked the matplotlib's version is 3.1.1, and also installed some other versions. Does anyone have some idea about this problem? Thanks.

Unfortunately I reckon it will be due to the ffmpeg and mpl versions but I don't have the original versions I used available.
I'd recommend doing a clean install of ffmpeg and mpl and trying to get the sample to generate?
I've found ffmpeg to be a tad finicky in the past too.

Thank you very much for your suggestion. I successfully resolved the issue by reinstalling the relevant packages. I solved the problem following the method described in the link below, hoping it might help others facing the same issue.
https://stackoverflow.com/questions/72596662/error-in-making-animation-through-ffmpeg-python3-9

the problem would be solved by updating or reinstalling the ffmpeg package :)


Add the React.js Image

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

I have added a image at the top of the article of this index.md


Tagging Version Numbers

Would it be possible to create some version tags for this repo? I'm using it in a project and I need to specify the version of this library being used. I'm having to reference it by a commit ID and actual versions would be great!

Tagged the latest release


Fallback locale for translated fields

Hi,
Is the fallback_locale supported with $block->translatedinput? I have specified the fallback as per the dimsav/translatable documentation but I'm getting a null returned rather than the input for the fallback locale specified in my config.
Thanks

Hi @layout-lab,
It currently does not support using fallback_locale but you should be able to decide to support it globally in your application by using the use_fallback and use_property_fallback configuration of the dimsav/translatable package.
You can then disable it at the model level if needed too. Checkout their documentation, it's really good!
It could be nice to provide an option in Twill that only enables it when rendering blocks if that's something you need.

This is now supported in 1.2.2!


removing not needed demos + migrating to 5.0

removing not needed demos + migrating to 5.0.
JetInstanse things are still them the code, we'll remove them once Hazelcast.bootstrappedInstance() is available

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Viacheslav Sytnyk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@slavagithub please see inline comments.
Regarding JetInstance and Hazelcast.bootstrappedInstance() - if I understand it correctly, Hazelcast.bootstrappedInstance() should be replacement for Jet.bootstrappedInstance() but we still should use JetInstance for working with Jet, i.e. something like JetInstance jet = Hazelcast.bootstrappedInstance().getJetInstance();.
And this is not replacement for Jet.newJetInstance(), we should use Hazelcast.newHazelcastInstance().getJetInstance() as replacement for it.
@ufukyilmaz can you please confirm that I understand it correctly? (AFAIK you're currently working on Hazelcast.bootstrappedInstance())

Hi @olukas , All what you said is true. To add to this discussion, we deprecate Jet class and all of the static factory methods of it (Jet was the main entry point for old Jet product), because we wanted the entry point of this merged product to be the Hazelcast class. Users will get HazelcastInstance using the methods of this Hazelcast class. Then, if they want to access JetInstance, they can get it only from HazelcastInstance by calling the HazelcastInstance#getJetInstance(). This will be only way to access JetInstance unless they use deprecated methods.
To list all the replacements:

Jet.newJetInstance() should be replaced by Hazelcast.newHazelcastInstance().getJetInstance()
Jet.newJetClient() -> HazelcastClient.newHazelcastClient().getJetInstance()
Jet.bootstrappedInstance() or JetBootstrap.getJetInstance()(which is a usage of the internal API that we are removing in 5.0) -> Hazelcast.bootstrappedInstance().getJetInstance()
Jet.newJetFailoverClient() -> HazelcastClient.newHazelcastFailoverClient()

btw, https://github.com/hazelcast/hazelcast/pull/18672 including Hazelcast.bootstrappedInstance() changes, is not merged yet. It will be merged very soon.


Maximum update depth exceeded when ThemeProvider is portalled

Describe the bug (current behavior)
Using a ReactDOM.createPortal() with ThemeProvider component results in an Error: Maximum update depth exceeded. error.
This is initially caught by our e2e tests while trying to bump a minor version of iTwinUI https://github.com/iTwin/appui/pull/855
I'm not certain if the provided minimal repro sample is exactly what we hit in the AppUI repo as it is very tricky to determine what is going on (i.e. removing one of the parent ThemeProviders avoids this issue).
Additionally, memoizing the ref of a Box used in an iTwinUI Root component seems to solve this issue.
Expected Behavior
ThemeProvider should not produce any run-time issues.
Link to minimal repro
https://stackblitz.com/edit/github-vk35v4?file=src%2FApp.tsx,src%2Fmain.tsx
Steps To Reproduce

Open minimal repro
Open dev-tools console
Observe the error Error: Maximum update depth exceeded.

Anything else?
No response

This seems to fix the issue on user end (see sandbox). Investigating more deeply to find a proper fix.
 export default function App() {
  const [el, setEl] = React.useState<HTMLElement>();

  React.useEffect(() => {
-   setEl(document.getElementById("x"));
  }, []);

  return (
    <ThemeProvider>
      <div
       id="x"
+      ref={setEl}
      />
      {el &&
        ReactDOM.createPortal(
          <ThemeProvider>
            <Button>X</Button>
          </ThemeProvider>,
          el
        )}
    </ThemeProvider>
  );
}

@GerardasB @ignas-k This should be fixed in 3.11.2!


Fix warnings - few more

Fix some warnings: do not use JCAUtil (not recommended) and fix generics in ant test case.

Looks reasonable, thanks.


InteractableObjects gives NullExceptions when touching multiple objects

Environment

Source of VRTK == Unity Asset Store
Version of VRTK ==Unity Asset Store as of 2nd April 2017
Version of Unity3D == Unity 5.5.2f1
Hardware used == Vive
SDK used == OpenVR

Steps to reproduce
When using the VRTK_InteractableObject on multiple objects and I start touching/using two objects with one controller I get NullException from StartTouching, StopTouching, IsGrabbed.
I think the reason is that GetGrabbing() can return a null, which is then assigned to grabbingObjects in stopGrabbingInteractions. Then when StartTouching uses StartTouching we get null.
I added nullchecks before the use of grabbingObjects, touchingObjects when they are used in StartTouching etc as such:
if (grabbingObjects == null)
{
grabbingObjects = new List();
}
This removed the problem. I think a better solution is to not return null in GetGrabbing, instead return a empty list.
Expected behavior
No null exceptions lol
Current behavior
Null exceptions.

Have you tried this in the latest github master version?

No, I have not. But when I look at the latest master version on git the same functions should produce the error.
On row 517:
public virtual GameObject GetGrabbingObject()  {         return (IsGrabbed() ? grabbingObjects[0] : null);  }
The above can return null, and then when it is called on row 883 it assigns grabbingObject as null:
        protected virtual void ForceReleaseGrab()         {             var grabbingObject = GetGrabbingObject();             if (grabbingObject)             {                 grabbingObject.GetComponent<VRTK_InteractGrab>().ForceRelease();             }         }
Later when we try to use grabbingObjects e.g in IsGrabbed we try to get Count from grabbingObjects, which is null.
public virtual bool IsGrabbed(GameObject grabbedBy = null)         {             if (grabbingObjects.Count > 0 && grabbedBy != null)             {                 return (grabbingObjects.Contains(grabbedBy));             }             return (grabbingObjects.Count > 0);         }

Can you provide steps to reproduce in an example scene

Hmm. I tried but to no success. I probably fiddled with the parameters in my own project. Thanks for quick answers anyway!


[TIR][Hexagon] Use the "target" value in T.func_attr for VTCM limit

For the VerifyVTCMLimit, read directly from the function attribute, if the function has already been annotated with the target.

@Lunderberg Need to resolve the conflict.


[Doc]: API reference for LLM class

📚 The doc issue
I can't find on https://docs.vllm.ai/ the API reference for the LLM class. This would make it easier than digging through the code to look at the docstrings - the examples in the docs don't explain most of the arguments.
Suggest a potential alternative/fix
No response

I guess they are largely overlapping with the engine arguments, but this isn't obvious, as the two classes have pretty different purposes.

I have opened #4709 to add some documentation for offline inference. Is there anything else you want to be included?


Set different time expire for different state params ?

How to set different time expire for different state params ?

I use js-cookie.

I would overwrite the setState and getState methods yourself with any expiration logic yourself, something like;
{
  getState() {
    // Check for any expired params before returning.
  },

  setState() {
    // Set state to storage with any additional expiration values.
  }
}


Updates DutyStation and BlackoutDate generators to new pattern

Description
In an effort to finish up the work started in #744, this refactors a couple more testdatagen generators. I also noticed that the mergo transformer I wrote wasn't quite behaving as I wanted it to, so I fixed it.
I also removed the DutyStation scenario (#3), since it's no longer needed
Code Review Verification Steps

[x] All tests pass.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
[ ] Any migrations/schema changes also update the diagram in docs/schema/dp3.sqs
Any new client dependencies (Google Analytics, hosted libraries, CDNs, etc) have been:

[ ] Communicated to @willowbl00
[ ] Added to the list of network dependencies

[ ] Request review from a member of a different team.
[ ] (TRIAL) Have the Pivotal acceptance criteria been met for this change?

:shipit:


wasm-tools: implementation of imports naming implementations (component-model #222)

https://github.com/WebAssembly/component-model/pull/222

We will ship compatibility with this change in wasmtime 15.
We can add support to tooling today to support the old mode and new mode, and at some point we will deprecate support for the old mode.

This is now done and implemented, so closing.


[move-only] Implement support for move only deinits

This PR implements support for move only deinits for move only types. It does this by introducing a new SIL construct called a SILMoveOnlyDeinit. This maps at the SIL level a move only nominal type to its deinit. It is used by a new pass called MoveOnlyDeinitInsertion which maps destroy_value, destroy_addr of types to an apply of the deinit. This makes it so that simple buffer view like things can now be written in Swift.
NOTE: I have not wired up IRGen support for handling destroy_value of move only types. This only matters for cases where a type does not have any deinit or if we were to use a move only address only type. Luckily for us, the former is easily fixed by adding an empty deinit (e.x.: deinit {}) and for now in the proof of concept, I am not going to handle address only types. until I get back from vacation.

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test

Windows test failure is most likely this: https://github.com/apple/llvm-project/pull/5334

@swift-ci test windows platform

@swift-ci smoke test linux platform

@swift-ci smoke test

@swift-ci test macOS platform


Update Pages “about”

Automatically generated by Netlify CMS

👷 Deploy Preview for nervous-engelbart-a15395 processing.
🔨 Explore the source changes: ddc49d4ea80e249e142f3cdee19a5ab2a34e86c1
🔍 Inspect the deploy log: https://app.netlify.com/sites/nervous-engelbart-a15395/deploys/61b387256e7eac0007ee48fd


Fix GAEN notification bug.

If there is no symptom (or no Illness_onset_date),  we should filter out this type of message.
Add a quality filter to filter out this type of message.

Hi Ott,
The below onset dates would be blank because there were no symptoms.
Message Id	illness_onset_date	date_result_release	Explanation of failure	Senders/ordering_facility_name  	CLIA	Admin Email	Email sent
ac8175f9-33c4-447a-96b8-d0e64f77ad65
12/2/2022	Missing illness_onset_date	Sunrise- Woodcreek Pediatrics-Mary Bridge Children's	50D0932635<EMAIL_ADDRESS>No symptoms so no onset date
a2f54261-6bb2-41f3-90e8-8fd057574a86
12/7/2022	Missing illness_onset_date	Zellerbach District Office	50D2223198<EMAIL_ADDRESS>No symptoms so no onset date
Best regards,
Sharon
The ReportStream Support Team
Contact us at<EMAIL_ADDRESS>Support hours:  8:00 am through 9:00 pm Eastern time
Monday-Friday, excluding US public holidays

Will be handled in ticket 7723.


Add map layers toggle component to Discover Projects' map

IMPORTANT
This PR includes (because it depends on) #311 and #316 .
Description
This PR adds a selector so the user can select contextual layers to display on the Discover page map.
Testing instructions
Verify that:

The user can click on the "Map layers" button and a selector opens
The user can toggle layers by clicking on them
Note: the layers display is not part of this task, so some may not work. They've been added for demonstration/testing purposes.
If the user clicks outside the selector closes

Tracking
LET-654
Screenshot

Video
https://user-images.githubusercontent.com/6273795/175551759-6ab5e996-7733-4125-a1d2-dd3e6783b747.mp4

the map is not being displayed,

The map didn't really get touched in this PR, but it was on #274. Do you have NEXT_PUBLIC_MAPBOX_API_TOKEN set?
(See: https://github.com/Vizzuality/heco-invest/blob/develop/frontend/README.md)

neither for local or staging envs

It should be working on staging (https://staging.hecopilot.org), but you're right it doesn't work on vercel deployments unfortunately. @tiagojsag


Adding support for the AlchemyAPI nodes and update Watson GA services.

:+1:

I've rebased all the changes into two commits, one to add the Alchemy API nodes and the other with the Watson GA API changes.
:bomb:

Feature Branches James. Feature Branches....
One feature per PR....
Tsk Tsk.
Will look at it later.

I know, I know.
The changes overlapped with the authentication changes to all the nodes.

Yay ! :+1:


store data properly

transfer to data()

https://stackoverflow.com/questions/47499671/how-to-store-frequently-used-data-or-parameters-within-an-r-package

Solved already


implement getting multiple resources

WHAT
Fix a bug in getting multiple resources
WHY
Originally, getting multiple resource using kubecolor had a bug.

2nd header was not in headerColor.

Codecov Report

Merging #31 into main will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   92.94%   92.96%   +0.01%
==========================================
  Files          12       12
  Lines         411      412       +1
==========================================
+ Hits          382      383       +1
  Misses         22       22
  Partials        7        7

Impacted Files
Coverage Δ

printer/table.go
95.12% <100.00%> (+0.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 236798e...366f9ae. Read the comment docs.


Update Release Script

Description

Update CHANGELOG as part of the "release" commit of the version being released
Publish only once at the end of the release flow
Add CHANGELOG diff to Github Release

Motivation and Context
Better release experience for publishers (less risk) and better release consumer experience
Checklist:

[x] I have updated the documentation accordingly.

:+1:

:+1:


release 0.36 stable build to replace arch 0.35.0-2 stable build

Description
hyprland-git update too frequently, it release five versiones for about five days,one of which may be the reason leads to fail boot I just experienced,I hope it settled on a stable version of 0.36, now It contains enough feature and bug fixes.It's maybe a good time to realease a stable version of 0.36.

There's already an 'official' 0.36.0 release, it was done last week.
There's a 0.36.0 arch package sitting in extra-testing; you'll have to wait until they promote that out of the testing repo

Vaxry is not the maintainer of the Arch Linux package, please direct your concerns to the Arch Linux Gitlab

brother I am not a manintainer for your distro


Cannot scroll to bottom of screens when image closed

Hi
I'm using this in my flutter app.
However, after I click on the image, and it opens in a new window, the image works and zooms great.
However, when I exit the image (with the x in the top), from now on, on all my other screens, I'm not able to scroll to the bottom. The last few lines of the screen are cut off at the bottom
Very strange.

Thank you for reporting this issue. Do you mind using the bug ticket template and providing the information it's requesting (like operating system etc). Could you maybe also do a screen recording of the bug and post it here? Thank you! That'll help us investigate.

Here is my flutter class:
class ImageViewerScreen extends ConsumerStatefulWidget {
const ImageViewerScreen({
Key? key,
}) : super(key: key);
@override
ConsumerState createState() => _ImageViewerScreenState();
}
class _ImageViewerScreenState extends ConsumerState {
final titleController = TextEditingController();
final detailsController = TextEditingController();
@override
Widget build(BuildContext context) {
titleController.text = 'Percription for 3/4/2022';
detailsController.text =
'Thisofsoor turpose ofsno was imputted fthe purpose ofimputted for the purpose of everyone.';
return Scaffold(
  appBar: AppBar(
    title: Text('Image details'),
    actions: [
      IconButton(
        icon: Icon(
          Icons.delete,
          color: Colors.white,
        ),
        onPressed: () {
          // do something
        },
      )
    ],
  ),
  body: ListView(
    shrinkWrap: true,
    // padding: EdgeInsets.all(15.0),
    children: [
         Padding(
        padding: const EdgeInsets.all(8.0),
        child: Container(
          width: MediaQuery.of(context).size.width,
          child: GestureDetector(
            onTap: () {
              showImageViewer(context,
                  Image.network("https://picsum.photos/250?image=9").image,
                  swipeDismissible: false, doubleTapZoomable: true);
            },
            child: FadeInImage.memoryNetwork(
              placeholder: kTransparentImage,
              image: 'https://picsum.photos/250?image=9',
              fit: BoxFit.fill,
            ),
          ),
        ),
      ),
      EditableTextInputWidget('Title', titleController),
      EditableTextInputWidget('Description', detailsController),
      // SizedBox(height: 50,),
    ]),
  );
// );

}
}

Here is a video
https://user-images.githubusercontent.com/28511238/211392103-d2add1d6-8954-4ca2-9424-b29641149f7b.mp4

That's super helpful, thanks so much! I'll take a look as soon as I can.

@bermanapps I could not reproduce your issue. (See attached video). Could you please provide a complete sample application that demonstrates the issue you are seeing? Then I'm happy to take another look. Thanks!
https://user-images.githubusercontent.com/16358/211788747-1bd0778a-2dc5-43ac-bdde-2ac8b95fa0d0.mp4

@bermanapps I'll close this issue for now. If you get around to providing a sample project I'm happy to take another look. Thanks!


SPDX PackageLicenseDeclared should be NOASSERTION

What happened:
Running syft photon:3.0 -o spdx the PackageLicenseDeclared for all packages is listed as NONE. According to the SPDX spec, however, NONE should only be used if "the package contains no license information whatsoever". The photon packages do contain license information, however, so NOASSERTION should be the value of PackageLicenseDeclared since a license is available but not provided.
PackageName: bash
SPDXID: SPDXRef-Package-rpm-bash
PackageVersion: 4.4.18-2.ph3
PackageDownloadLocation: NOASSERTION
FilesAnalyzed: false
PackageLicenseConcluded: NONE
PackageLicenseDeclared: NONE
PackageCopyrightText: NOASSERTION

What you expected to happen:
At a minimum, NOASSERTION should be the value of PackageLicenseDeclared (and probably PackageLicenseConcluded). Ideally, the License or LicenseRef for the package would be listed since the license is provided in the json format:
"purl": "pkg:rpm/photon/bash@4.4.18-2.ph3?arch=x86_64",
   "metadataType": "RpmdbMetadata",
   "metadata": {
    "name": "bash",
    "version": "4.4.18",
    "epoch": null,
    "architecture": "x86_64",
    "release": "2.ph3",
    "sourceRpm": "bash-4.4.18-2.ph3.src.rpm",
    "size": 3315720,
    "license": "GPLv3",
    "vendor": "VMware, Inc.",

How to reproduce it (as minimally and precisely as possible):
syft photon:3.0 -o spdx
Anything else we need to know?:
https://spdx.github.io/spdx-spec/package-information/
Version:       0.32.0

Thanks @rnjudge for the find here!
We've got some work in-flight regarding identifying and propagating license information info the SPDX format/base syft data shape.
I think we can do a quick patch that gets NOASSERTION into place as the default rather than using NONE in the meantime.
I can get this in when I have some bandwidth this week. Also, if it seems small enough and you're interested in becoming a contributor, feel free to throw a PR up. I'd be happy to review it and help merge it in for our next release.

@spiffcs sounds good! I can do that before vacation next week :)


Merge branch 'feature' of https://github.com/Mahesh-MSFT/Enterprise-Scale into feature

This PR fixes

updated section "Configure default deployment regions" to remove reference to both files. There are 3 files now.
also correced checkout to check out.

updated section "Configure default deployment regions" to remove reference to both files. There are 3 files now.
also correced checkout to check out.


When i am removing Sign from the application its removing one mp3 file from the application

From<EMAIL_ADDRESS>on September 15, 2011 07:20:59
What steps will reproduce the problem? 1. Open any application which is having mp3 file and remove the key
2.click on the button which is using mp3 file 3. What is the expected output? What do you see instead? its should not display error What version of the product are you using? On what operating system? Please provide any additional information below.
Original issue: http://code.google.com/p/robotium/issues/detail?id=157

From<EMAIL_ADDRESS>on September 15, 2011 22:20:49
This is not a robotium issue.
Status: Invalid


refactor(pkg/lds) Cleanup a redundant call to ListAllowedServices

Signed-off-by: Sean Teeling<EMAIL_ADDRESS>Affected area:

Functional Area

New Functionality
[ ]

Documentation
[ ]

Install
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Ingress
[ ]

Egress
[ ]

Networking
[ ]

Observability
[ ]

SMI Policy
[ ]

Sidecar Injection
[ ]

Security
[ ]

Upgrade
[ ]

Tests
[ ]

CI System
[ ]

Demo
[ ]

Performance
[ ]

Other
[ x]

Cleanup
Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project?

Did you notify the maintainers and provide attribution?
No

Is this a breaking change?
No

Codecov Report

Merging #3602 (d1f0c20) into main (9684c97) will increase coverage by 1.24%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #3602      +/-   ##
==========================================
+ Coverage   66.12%   67.36%   +1.24%
==========================================
  Files         174      175       +1
  Lines        8309     8496     +187
==========================================
+ Hits         5494     5723     +229
+ Misses       2784     2742      -42
  Partials       31       31

Flag
Coverage Δ

unittests
67.36% <50.00%> (+1.24%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/envoy/lds/inmesh.go
77.23% <50.00%> (-0.11%)
:arrow_down:

pkg/service/types.go
33.33% <0.00%> (-66.67%)
:arrow_down:

pkg/cli/chart_source.go
77.77% <0.00%> (-2.23%)
:arrow_down:

pkg/envoy/proxy.go
86.30% <0.00%> (-1.03%)
:arrow_down:

cmd/osm-controller/osm-controller.go
15.21% <0.00%> (-0.79%)
:arrow_down:

pkg/envoy/lds/wasm.go
95.74% <0.00%> (-0.26%)
:arrow_down:

pkg/catalog/inbound_traffic_policies.go
83.03% <0.00%> (-0.16%)
:arrow_down:

cmd/cli/install.go
70.79% <0.00%> (ø)

pkg/kubernetes/util.go
95.00% <0.00%> (ø)

cmd/cli/mesh_upgrade.go
45.83% <0.00%> (ø)

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86ef383...d1f0c20. Read the comment docs.


Uncaught TypeError Due to Missing Original Event

Every once in a while, when the mouse moves out of the image, the following error is seen:
jquery.magnify.js:87 Uncaught TypeError: Cannot read property '0' of undefined
    at HTMLUnknownElement.moveLens (jquery.magnify.js:87)
    at HTMLUnknownElement.dispatch (jquery.js:5237)
    at HTMLUnknownElement.elemData.handle (jquery.js:5044)

If we can maybe return from the moveLens method if the event doesn't have a originalEvent, then perhaps that might be a good enough workaround?
              // Save last coordinates in case we need to call this function directly (required when
              // updating magnifiedWidth/magnifiedHeight while the lens is visible).
              nPosX = e.pageX || e.originalEvent.touches[0].pageX;
              nPosY = e.pageY || e.originalEvent.touches[0].pageY;

@karthicks I think you did not add the  magnify.css add and check it


Initial implementation of test harness

The tests need to be extended but I wanted to get something checked in as a starting point

LGTM merging


Register rabug.localplayer.dev

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.
[x] There is no NS Records (Enforced as of Sepetember 4th, 2024)

Description

Link to Website

I didn't saw it recently sorry :'D this should be fine

recheck

recheck


Garbage values are returned for errors

eg:
import ballerina.lang.errors;

function testJsonToJsonArrayCasting() (json[], errors:TypeCastError){
    json j1 = [[7]];
    var j2, e = (json[]) j1;

    return j2, e;
}

Here the value returned for 'e' is 7. It should be null, since there are no runtime errors.

This garbage-value issue for this particular scenario is fixed with #2888.
However, we need to check for other places where this could occur and fix them as well.

This issue occurs in the following instance
Sample code
function getAllAttributesWithDifferentNamespacePrefixes(xml value)(string attributeValue, errors:TypeCastError error){
    xmlns "http://example.com/ServiceName/sample/test" as ns0;
    xml firstLevelChildren = xmls:children(value);
    xml specificChild = xmls:select(firstLevelChildren, "{http://example.com/ServiceName}CNTROLAREA");
    xml secondLevelSpecificChild = xmls:selectChildren(specificChild, "{http://example.com/ServiceName/sample/test}DATETIME");
    map attributes = <map> secondLevelSpecificChild@;
    attributeValue, error = (string)attributes[ns0:qualifier];
    system:println(attributeValue);
    return;
}

Here attributeValue is returned, hence error should be null.

Another sample incident
var firstname, err = (string)dataset.batchOne[i].firstname;

Checked all scenarios in v0.94.0. Seems they are all fixed. Hence closing the issue.

I am reopening this issue. I can see this behaviour with 0.95.0 as well.
function main (string[] args) {
json j1 = "Apple";
var s,err = (string)j1;
if(err != null) {
println( err);
}
println(s);
}


Update search.js

Added 10 random profiles to show in the search bar

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Please link the Issue that this PR relates to in the Description
It looks like this PR is related to https://github.com/EddieHubCommunity/LinkFree/pull/7753
As the code changes and test changes have been done in two separate PRs this will cause them to fail
Please combine them into a single PR (and close the PR you are not going to use)


Downloading a large file needs a more prominent indication

Try grabbing the audio from gemini://konpeito.media/konpeito-05-a.mp3  and there's no indication if the download is still happening  or not.  All you can do is try "Save" until it eventually works.

The current indications are:

the progress bar fills up and disappears
the download size counter in the URL bar changes color
the 🌐 changes into 🔃

Granted, in light mode these are less noticeable changes. Are you using light mode?
Possible changes are using the URL bar background as the progress bar so it's much thicker, and doing a small animation in the stop/reload button while the request is ongoing.

I do indeed use light mode: black print on white paper, like God and Gutenberg intended.  :-)
The progress bar and the number of bytes received use (nearly) the same color as the light-mode background of the tab, so invisible.  They should be some other color, preferably black.  I never looked at the globe before.

Thicker progress bar (on retina) and an "ongoing request" spinner were added in v0.13.2.


Windows console

I tried -quiet or disable_stdout but nothing... The console still popup.
Is good for debugging but not for final release. I saw there was a similar issue but was closed and marked as fixed... Pretty strange...

You mean this option? It works for me...

are you running with a binary compiled for release? In general what should
happen is when you build with target=debug or target=debug_release, it gets
linked with /subsystem:console, so there'll be a console windows. If you
use target=release, the flag is /subsystem:window (or something) and
there's no console.
I don't know what happens on the cross compiled mingw builds tho, but there
should be something equivalent..
On Sat, Aug 15, 2015 at 1:10 AM, bugless1<EMAIL_ADDRESS>wrote:

I tried -quiet or disable_stdout but nothing... The console still popup.
Is good for debugging but not for final release. I saw there was a similar
PR but was closed and marked as fixed... Pretty strange...
—
Reply to this email directly or view it on GitHub
https://github.com/okamstudio/godot/issues/2373.

AlexHolly suggestion worked for me on windows 7 x64 with x64 build from http://<IP_ADDRESS>/godot_win64-1.1stable.exe . bugless1 can you give a bit more information about the your environment should the solutions so far not solve your problem. Information that would help may be are you building for windows, linux, mac. Is it the default download or a compiled download from github. tnx

Solved! I was missing target=release...


Allow Calendar app to begin on Sunday

Adds a setting in a Calendar app which allows it to start the week on Sunday rather than Monday.

Nice - thanks! Looks great, but I think there's a typo in apps.json where you meant to say calendar.json? "data": [{"name":"messages.json"}]

Merging anyway - and I'll fix it


Accordion Submenu not displayed correctly / Title-bar

Hey,
I noticed that the title bar menu seems to be 'broken'.

It seems to be a problem somewhere around .menu.vertical > li { display: block }. If loaded in a small window the display property is set to table-cell. I tried tracking it don't but couldn't find anything. Working around the problem and adding "vertical" to the menu walker helped, but surely isn't "the solution".
Tested in safari and chrome on mac.
Anybody else got any ideas?
thanks in advance

Looking to dig into this, do you have the code you're using or a demo to share? Blank codepen http://codepen.io/rafibomb/pen/dGLqYj

It's on my password protected dev server. Could I send you an E-Mail with the login?

We just need enough HTML to recreate the bug. Doesn't need extra CSS (it would be better without extra CSS) or any real data.

Problem was with the way the menu was generated. Fixed now, thanks anyway!


Fix errors reported by jscs

This pull request fixes the code-style errors reported by "jscs:all" grunt task.

I don't think this is the error that's breaking the build. I was looking at the same issue, and I actually get entirely different errors from the linter, once I change the JSCS configuration that they have a deprecation on. Ultimately, we have to change the following error message, or peg the dependency back:
Running "jscs:all" (jscs) task
Warning: Config values to remove in 3.0:
The `esnext` option is enabled by default. Use --force to continue.

I'm going to make a pull to just push the dependency back right now since I have it done locally.

Oh, I haven't run npm install for months, that's probably why I got different errors. I did now, and now I get this instead:
[DEPRECATION NOTICE] Esperanto is no longer under active development. To convert an ES6 module to another format, consider using Babel (https://babeljs.io)
Warning: Task "jscs-all" not found. Use --force to continue.

Closing this pull as it doesn't fix the issue at hand. If you want to get everything working with the latest JSCS version, we certainly wouldn't say no to that.


Cannot save file into a non-existent directory: 'merged/2024-jr'

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/runner/work/sr-detection/sr-detection/sr-data/src/sr_data/steps/merge.py", line 52, in main
    df.to_csv(path, index=False)
  File "/home/runner/.cache/pypoetry/virtualenvs/sr-data-iIS7NBSl-py3.12/lib/python3.12/site-packages/pandas/util/_decorators.py", line 333, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/.cache/pypoetry/virtualenvs/sr-data-iIS7NBSl-py3.12/lib/python3.12/site-packages/pandas/core/generic.py", line 3967, in to_csv
    return DataFrameRenderer(formatter).to_csv(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/.cache/pypoetry/virtualenvs/sr-data-iIS7NBSl-py3.12/lib/python3.12/site-packages/pandas/io/formats/format.py", line 1014, in to_csv
    csv_formatter.save()
  File "/home/runner/.cache/pypoetry/virtualenvs/sr-data-iIS7NBSl-py3.12/lib/python3.12/site-packages/pandas/io/formats/csvs.py", line 251, in save
    with get_handle(
         ^^^^^^^^^^^
  File "/home/runner/.cache/pypoetry/virtualenvs/sr-data-iIS7NBSl-py3.12/lib/python3.12/site-packages/pandas/io/common.py", line 749, in get_handle
    check_parent_directory(str(handle))
  File "/home/runner/.cache/pypoetry/virtualenvs/sr-data-iIS7NBSl-py3.12/lib/python3.12/site-packages/pandas/io/common.py", line 616, in check_parent_directory
    raise OSError(rf"Cannot save file into a non-existent directory: '{parent}'")
OSError: Cannot save file into a non-existent directory: 'merged/2024-jr'
error: Recipe `merge` failed on line 182 with exit code 1

@rultor release, tag is 0.0.21, title is 0.0.21

@h1alexbel OK, I will release it now. Please check the progress here.

@rultor release, tag is 0.0.21, title is 0.0.21

@h1alexbel Done! FYI, the full log is here (took me 21min).


crossings table - add columns for PSCIS photos/ecocat urls? Or link to full PSCIS dataset for given crossing?

For now, adding columns for photos and ecocat link to the crossings table makes sense to me.
But for assessed crossings, the full PSCIS dataset should be available via a single click. This is more of an application design issue than a bcfishpass modelling issue - the full set of PSCIS data is easily requested via WFS via stream_crossing_id

include columns these with alpha data release

Maybe not. To get this to work correctly, the dates of the activities at the crossing would have to be parsed. We can generally assume that most recent would match the pattern of assessment -> confirmation -> design -> remediation... but this is not always the case. I'd prefer to get this right if bothering to do it.

Its been a couple years, closing this inactive issue - use source PSCIS datasets for photos/urls rather than parsing dates of the PSCIS records for the latest.


Dk modkit

This change adds a process to run the modkit command line tool for generating bedMethyl files from modBAM files.
https://github.com/nanoporetech/modkit
There is a new file modules/local/modkit.nf, and a single change to workflows/sarek.nf to call the MODKIT process after merging bam files.
I tested this change on a small merged bam file during development, and I ran the pipeline successfully on STATE 035 data.
Here is the repo for the Docker file I created for modkit:
https://github.com/eitm-org/modkit_docker
And it's published here:
https://github.com/orgs/eitm-org/packages/container/package/modkit

The module looks good. A couple nits.

For exposing args, can you please add a config file for this process (example)
Is there an option that can be passed in from the nextflow run command that allows you to skip modkit and/or only run modkit without running downstream workflows (ie variant calling and markduplicates)? If not can you please add that logic into sarek.nf and the config (example)?

For 2, one option I see is to use --skip-tools, this might require the least code change.  https://github.com/eitm-org/sarek/blob/master/nextflow_schema.json#L94-L99

The changes to config look good to me, please make sure to test the latest change with --tools modkit --tools clairs and --tools modkit,clairs. Also, for modkit, they seem to be releasing new updates regularly. Is is possible to specify the version number in your docker image and similarly in the modkit nextflow module?

Good idea to tag/pin the versions.
I made the changes in eitm-org/modkit_docker to pin the version of modkit at 0.1.12:
https://github.com/eitm-org/modkit_docker
I also added a tag for the Docker image:
https://github.com/orgs/eitm-org/packages/container/modkit/116516916?tag=1.0
And made small change in modkit.nf to use the tagged version ghcr.io/eitm-org/modkit:1.0.
My tests with --tools clairs and --tools "clairs,modkit" work, but --tools modkit fails with error "Missing workflow output parameter: clairs_vcf_normal_germline".  I hadn't tested the pipeline without "--tools clairs" before -- this may be a separate issue.

This one was tricky to debug -- Nextflow offered very little guidance.
The variant calling code was controlled by the condition:
if (params.tools) { ...
https://github.com/eitm-org/sarek/blob/master/workflows/sarek.nf#L996
Running the pipeline with '--tools modkit' makes this condition true, but we don't want the variant caller to run in this case.
I've changed the condition to check specifically for "clairs" in the --tools string.
I've tested that the pipeline runs successfully with:

no --tools arg
--tools clairs
--tools modkit
--tools "clairs,modkit"


Not working

hmm it's not working. I'll try to find out how to fix it.
spotify search ar metallica
1: Artist: Metallica Followers: 3911072
2: Artist: Metallica Tribute Band Followers: 162
3: Artist: Made famous by Metallica Followers: 80
4: Artist: Various Artists - Metallica Tribute Followers: 486
prompt: selection:  1
Unhandled rejection Error: 87:92: syntax error: Zeilenende, etc. erwartet, aber Identifier gefunden. (-2741)

    at ChildProcess.<anonymous> (/usr/local/lib/node_modules/spotify-cli-mac/node_modules/node-osascript/lib/index.js:39:15)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at maybeClose (internal/child_process.js:927:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)

Thanks for reporting this Chuck, I'll try to have a look this weekend. If you manage to track down the issue, feel free to submit a PR.

I was not able to replicate this issue @Chuck-Aguilar . I will publish a new version on npm shortly. You could give that a go.

Closing this as I can not replicate the issue, please try the new version we're about to publish. If it doesn't work again, feel free to open a new issue @Chuck-Aguilar


[Build] Stable and Latest reconfiguration

Due to the ssl issue (issue #129), I am promotic jammy build to stable and kinetic build to latest, until bookworm becomes the current stable debian.

Available in release 2022-11-05.2


Merged cell handling

First, thank you for this library. Second, if I'm in the wrong place to be asking questions, I apologize.
I'm working with documents that contain merged cells. I'd like to iterate over rows and for a particular cell grab the value in a column header above it. The column headers are in merged cells.
Based on the demo, the sheet.xml files, and relevant sections of the spec (29500-1 SS <IP_ADDRESS> and A.2 ln. 2293 through ln. 2298), it seems the merge cell value is always in the top left cell and subsequent cells in the merge range are undefined.
Are there any helper attributes on the JS object of a merged cell (obj.mergeValue or obj.isMergeCell) or is that something I'll have to handle myself?
Cheers and thank you for your time! :beers:

+1 It would be great to have isMergeCell.

@vjpr I think you should probably turn that into its own issue so it gets the appropriate attention.
@SheetJSDev since it looks like you added this functionality, I think this issue can be safely closed. Thank you for the work!

Example for write:
var merges = wb.sheets["mysheetId"]['!merges'] = [];
//then push merges into array
merges.push( { s: 'A1', e: 'F1' } );

can you tell me how to set the alignment property of merge cell?

can someone tell me how to write in the merged cell?

https://github.com/Krishnakanth94/Xlsx-styles-working-code
the above code shows merge cells
alignment should be given to starting cell to merge it will we done!


Scrollvew scroll to the top of face board of the Lord would happen quickly drag down

Scrollvew scroll to the top surface for the board master would happen quickly drag down but there is no consumption eventsBecause one click panel it will rebound again. Pay attention to this problem is not so good repetition to try a few times more drag down by not too bigI analyzed the conflict is the event and custom by intercepting the Scrollview the following main code
@Override
public boolean dispatchTouchEvent(MotionEvent ev) {
switch (ev.getAction()){
case MotionEvent.ACTION_MOVE:
if (isScrolledToTop){
getParent().requestDisallowInterceptTouchEvent(false);
}
break;
case MotionEvent.ACTION_UP:
if (!isScrolledToTop){
getParent().requestDisallowInterceptTouchEvent(true);
}
break;
}
return super.dispatchTouchEvent(ev);
}
Add the following code in the dispatchTouchEvent method
if (mScrollableViewHelper.getScrollableViewScrollPosition(mScrollableView, mIsSlidingUp) > 0) {
mIsScrollableViewHandlingTouch = true;
return super.dispatchTouchEvent(ev);
}else if (mScrollableViewHelper.getScrollableViewScrollPosition(mScrollableView, mIsSlidingUp)<=0){
return handled;
}

I understand and am experiencing the same issue, except with RecyclerView. Is your code above a proposed solution?

Yes, thank you

在 2017年3月4日，上午12:33，Timothy Miller<EMAIL_ADDRESS>写道：
I understand and am experiencing the same issue, except with RecyclerView. Is your code above a proposed solution?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/umano/AndroidSlidingUpPanel/issues/798#issuecomment-284001962, or mute the thread https://github.com/notifications/unsubscribe-auth/AL8amCgdgtpvQ5-IZPKXKhHk1w4kEkPdks5riEDGgaJpZM4LXhHX.

@lipingaccp Could you please share more of your proposed fix? Such as when isScrolledToTop is set and to which class does "Add the following code in the dispatchTouchEvent method" refer to?

It made it very clear.That is my solution.Try it!Thank you very much!

在 2017年3月7日，下午3:18，Timothy Miller<EMAIL_ADDRESS>写道：
@lipingaccp https://github.com/lipingaccp Could you please share more of your proposed fix? Such as when isScrolledToTop is set and to which class does "Add the following code in the dispatchTouchEvent method" refer to?

@lipingaccp You are misunderstanding me. I asked for more details.

加我qq 429873911

在 2017年3月7日，下午4:03，Timothy Miller<EMAIL_ADDRESS>写道：
@lipingaccp https://github.com/lipingaccp You are misunderstanding me. I asked for more details.

gg

@fxmeister  the class ScrollableViewHelper, in method getScrollableViewScrollPosition, has conditions for differents views (ScrollView, ListView and RecyclerView).
I copied the code for ScrollView and change the type to NestedScrollView.
       else if(scrollableView instanceof NestedScrollView) {
           if (isSlidingUp) {
               return scrollableView.getScrollY();
           } else {
               NestedScrollView sv = ((NestedScrollView) scrollableView);
               View child = sv.getChildAt(0);
               return (child.getBottom() - (sv.getHeight() + sv.getScrollY()));
           }
       }


About Task.Yield()

Describe your question
Why does MQTTnet.Server.MqttClient have Task.Yield() in it's ReceivePackagesLoop method and what does it do?
Would the performance have been better without it?

The reason is that we have up to two tasks which will access the channel. 1 all the time for receiving and another occasionally for sending. In the past we had issues with timeouts because the receiver has blocked the sender due to a high number of pending packets. The yield now gives the sender a change to send even if there are a lot of messages incoming. Sampe applies for the other direction is there is much being sent and only a few packets received.

If you modify it like this, whether the effect is the same?
await Task.Yield();
while (!cancellationToken.IsCancellationRequested)
{
    ...

As an aside, I am currently trying to improve the performance of MQTTnet.AspNetCore and have found a bug in MqttBufferReader. I'll talk about this bug in another issue.

If you modify it like this, whether the effect is the same?
await Task.Yield();
while (!cancellationToken.IsCancellationRequested)
{
    ...

I believe that moving the yield before the loop will make it work like before. If the loop is processing lots of messages the send will get timeouts.

Closing this due to inactivity


Properly handle transform cancellation. Fix tests

Handle cases where the transformation status is canceled.
Update tests to latest models.

Will do. Actually after discussion with @gordonwatts I need to tweak some contracts so I will Draft-ify it for the moment.

24 hour countdown for comments here :-) The key point here is that cancellation/fatal errors will now raise an exception; we need to decide how far up this propagates, e.g. right now partial success will give a partially-complete output (whereas apparently the 2.0 client would raise an exception).

@ponyisi can you fix the conflicts?


How to push the dragged event inside of the background event  (background: true)

I used the background event as container of the event. Because before I put my event into the calendar I'll put the container first then I pull all the events inside of the container. So I want to know how to get or how to push the event data into the background event data.


Does not work with Powershell Core

https://devblogs.microsoft.com/scripting/powertip-identify-if-you-are-running-on-powershell-core/

Isn't this more of an issue with PowerShell Core?

Yeah maybe, but it could display a better error if the referenced
assemblies fails to load, perhaps?
On Sun, 7 Mar 2021 at 21:20, David Anson<EMAIL_ADDRESS>wrote:

Isn't this more of an issue with PowerShell Core?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/DavidAnson/ConvertTo-Jpeg/issues/13#issuecomment-792345337,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOSSCMW3Q7UW6TZRGN3JC3TCPNXXANCNFSM4YYGDABA
.

Yeah maybe, but it could display a better error if the referenced assemblies fails to load, perhaps?

I found a similar thread, someone saying "WinRT support was removed from .Net 6.0 and as result from PowerShell 7.2 too.". David, any chance you will adapt this valuable script to PS Core?

I don't use this script anymore, so the urgency for me is less. This issue is a candidate for PR if someone digs in and figures out the changes!


[Enhancement]: Google Cloud Storage API

What does this PR do?
Add Google Cloud Storage to testcontainer

Why is it important?

Now testcontainer will have Azure, AWS and GCP for tests
Related issues

#1022

there is one problem
    return base.Init()
            .WithImage(GCSImage)
            .WithPortBinding(GCSPort, newPort)
            .WithCommand("-scheme", "http")
            .WithCommand("-backend", "memory")
            .WithCommand("-external-url", $"http://localhost:{newPort}")
            .WithCommand("-port", newPort.ToString())
            .WithWaitStrategy(Wait.ForUnixContainer().UntilHttpRequestIsSucceeded(request =>
                request.ForPath("/").ForPort(newPort).ForStatusCode(HttpStatusCode.NotFound)));

I have to pass acutal port into -external-url paramenter.
how can I do this?

this is how docker config shoud looks like
https://github.com/fsouza/fake-gcs-server/blob/main/examples/dotnet/docker-compose.yaml

I have to pass acutal port into -external-url paramenter.

Hi 👋 do you mean the actual random assigned host port? It is not very common that a services running inside a container requires it, but you can configure something similar like Kafka and utilize the WithStartupCallback builder member:
https://github.com/testcontainers/testcontainers-dotnet/blob/44a1d3a9418f22c1761de7e8d64e4f7fb9d1c7f8/src/Testcontainers.Kafka/KafkaBuilder.cs#L65-L66
The WithStartupCallback builder member prepares a shell script and copies it during the start to the container. The callback has access to the random assigned host port (see L:82):
https://github.com/testcontainers/testcontainers-dotnet/blob/44a1d3a9418f22c1761de7e8d64e4f7fb9d1c7f8/src/Testcontainers.Kafka/KafkaBuilder.cs#L82-L87

Yeah, it’s because of container, I have no idea why.
But super thanks a lot I will try!

@HofmeisterAn  the problem is I have to pass port number into paramter
so for code .WithPortBinding(GCSPort, true)
I have to get somehow this random port and pass it as RandomPort
.WithCommand("-external-url", $"http://localhost:{RandomPort}")
in parameter.
so this is the issue

if I do like hits
return base.Init()
            .WithImage(GCSImage)
            .WithPortBinding(GCSPort, GCSPort)
            .WithCommand("-scheme", "http")
            .WithCommand("-backend", "memory")
            .WithCommand("-external-url", $"http://localhost:{GCSPort}")
            .WithCommand("-port", $"{GCSPort}")
            .WithWaitStrategy(Wait.ForUnixContainer().UntilHttpRequestIsSucceeded(request =>
                request.ForPath("/").ForPort(GCSPort).ForStatusCode(HttpStatusCode.NotFound)));

then all is fine, and it works. but it's not possible to run several containers at the same time

As mentioned in my previous comment, you need a configuration similar to Kafka:

Override the entrypoint that executes a shell.
Override the command and set a command that waits until the startup script is written and then executes it.
Prepare the startup script in WithStartupCallback, where you have access to the random assigned host port.
Finally, copy the prepared startup script to the container. As soon as it is written, the overridden entrypoint and respective command will execute it, starting the service inside the container.

ok if I do [Collection("Google")] for collections thet all is fine

ok if I do [Collection("Google")] for collections thet all is fine

I am sorry, I do not understand. Modules must work with random assigned host ports; we cannot accept the pull request using fixed host ports. You can find further details in our best practices.

@Hofmeisteran that was my random thoughts anyway thanks for your help, now it works fine =)
also I maked right tests.

@HofmeisterAn the problem is I have to pass port number into paramter

As mentioned in my previous comment, you need a configuration similar to Kafka:

Override the entrypoint that executes a shell.
Override the command and set a command that waits until the startup script is written and then executes it.
Prepare the startup script in WithStartupCallback, where you have access to the random assigned host port.
Finally, copy the prepared startup script to the container. As soon as it is written, the overridden entrypoint and respective command will execute it, starting the service inside the container.

This is really amazing suggeest! thanks a lot!

Now it’s ready for review

fixed, but with some reason one pipline is borken,  I did that?

@HofmeisterAn thansks a lot! This is sniper cool finding!

@HofmeisterAn  Hi! Thanks for merging this request!
By the way, when will his package be available?

I have not planned a release yet. I want to make some minor changes in the next days, but I need a short break as I am feeling drained.

Sure! I'm just checking to see when I can throw out my old implementation and replace it with a nice nuget package =)


source leakage correction

I don't think that MNE currently supports source leakage correction. According to the work of people from OHBA: https://www.ncbi.nlm.nih.gov/pubmed/27262239, correlation of envelopes after correction is one of the most reliable connectivity estimators.
For the purpose of my study I implemented symmetric orthogonalization from this paper: https://www.ncbi.nlm.nih.gov/pubmed/25862259
It's here: https://gist.github.com/dokato/7a997b2a94a0ec6384a5fd0e91e45f8b .
I'm happy to contribute it to mne if you want (but need some advice e.g. on where to place it).

Hi,
That sounds like a good idea. We plan adding power envelope correlations
soon. It’s essentially written but I need time to add it to MNE. Source
leakage correction should come with it but I haven’t looked into it yet.
Perhaps we can team up :)
Denis
On Sun 18 Feb 2018 at 15:17, dokato<EMAIL_ADDRESS>wrote:

I don't think that MNE currently supports source leakage correction.
According to the work of people from OHBA:
https://www.ncbi.nlm.nih.gov/pubmed/27262239, correlation of envelopes
after correction is one of the most reliable connectivity estimators.
For the purpose of my study I implemented symmetric orthogonalization from
this paper: https://www.ncbi.nlm.nih.gov/pubmed/25862259
It's here: https://gist.github.com/dokato/7a997b2a94a0ec6384a5fd0e91e45f8b
.
I'm happy to contribute it to mne if you want (but need some advice e.g.
on where to place it).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/issues/4947, or mute the thread
https://github.com/notifications/unsubscribe-auth/AB0fipA7k6aqm0mycPbs3v60QICuTf01ks5tWDDogaJpZM4SJtEx
.

@dengemann Sure, sounds like a great idea! My implementation requires some amendments obviously, but in my tests worked fine. Let me know if you have any guidelines how to insert it to mne. My guess is that it should be a part of connectivity subpackage, shouldn't it? And then utils, or rather separate module (e.g. leakage.py)?

One reason we still don't have power envelope correlations in MNE is that I
would like to introduce a new API for this that is independent from the
spectral connectivity one. This always takes discussions, hence, time. I
think we should do a submodule for envelope correlations and just add a
leakage module there. Maybe I should start a PR next week to propose the
API I have in mind. Then we can take it from there.
On Sun, Feb 18, 2018 at 4:55 PM dokato<EMAIL_ADDRESS>wrote:

@dengemann https://github.com/dengemann Sure, sounds like a great idea!
My implementation requires some amendments obviously, but in my tests
worked fine. Let me know if you have any guidelines how to insert it to
mne. My guess is that it should be a part of connectivity subpackage,
shouldn't it? And then utils, or rather separate module (e.g. leakage.py)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/issues/4947#issuecomment-366525727,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB0fioq81FY377PJ0lF13rRP944rdGxiks5tWEgGgaJpZM4SJtEx
.

Maybe we could hang out next week to exchange / synchronize ideas? It is
not unlikely that we have some parallel work going :)
On Sun, Feb 18, 2018 at 5:00 PM Denis-Alexander Engemann <
<EMAIL_ADDRESS>wrote:

One reason we still don't have power envelope correlations in MNE is that
I would like to introduce a new API for this that is independent from the
spectral connectivity one. This always takes discussions, hence, time. I
think we should do a submodule for envelope correlations and just add a
leakage module there. Maybe I should start a PR next week to propose the
API I have in mind. Then we can take it from there.
On Sun, Feb 18, 2018 at 4:55 PM dokato<EMAIL_ADDRESS>wrote:

@dengemann https://github.com/dengemann Sure, sounds like a great
idea! My implementation requires some amendments obviously, but in my tests
worked fine. Let me know if you have any guidelines how to insert it to
mne. My guess is that it should be a part of connectivity subpackage,
shouldn't it? And then utils, or rather separate module (e.g. leakage.py
)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/issues/4947#issuecomment-366525727,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB0fioq81FY377PJ0lF13rRP944rdGxiks5tWEgGgaJpZM4SJtEx
.

Yeah. Please, keep me in the loop about envelopes and I'm happy to hang out next week as well!

Cool. My email is<EMAIL_ADDRESS>let's find a date for next week.
Denis
On Sun, Feb 18, 2018 at 5:06 PM dokato<EMAIL_ADDRESS>wrote:

Yeah. Please, keep me in the loop about envelopes and I'm happy to hang
out next week as well!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/issues/4947#issuecomment-366526417,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB0fiv5qwKf0lObrJg9f2k6w9hwXBEugks5tWEqXgaJpZM4SJtEx
.

that should land in the connectivity module. It would be great if this code
enters
master with a tutorial on rest data eg using the brainstorm data we already
ship
or any other data source.
cc @SherazKhan

@agramfort I plan to work on that, finishing what we started in Boston last
year with Sheraz.
On Tue, Feb 20, 2018 at 4:45 PM Alexandre Gramfort<EMAIL_ADDRESS>wrote:

that should land in the connectivity module. It would be great if this code
enters
master with a tutorial on rest data eg using the brainstorm data we already
ship
or any other data source.
cc @SherazKhan
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/issues/4947#issuecomment-367019524,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB0finwcYwDXG8ODecMO2_ZLrmDHR47Pks5tWuiFgaJpZM4SJtEx
.

small reminder @dengemann :)

Depends on #5389.

We have envcorr now


PR -- updated README, added widget to radiology paper notebook, csv links now points to IDC repo instead of ccosmin97

@fedorov

We can improve this further later, but it already improves the current content, so I am merging.


Flag annotations

Another type of annotation column that the user should be able to add, besides state-based annotations, are flags. Using flags, events can be annotated when they satisfy certain user-specified conditions. The mechanism is quite similar to state-based annotations. The values that occur in a flag column are called flags (instead of states). The conditions that specify whether a certain flag marks an event are similar to the conditions that specify state transitions in case of a state-based annotation. A difference is that, in contrast to a state, a flag marks an individual event and does not "persist" to the next event.

Included in v0.0.6


Replace use effect alt demo

Alternate solution to https://github.com/waterthetrees/wtt_front/pull/410

@mwpark2014 Thanks, this looks more react-like. Your other version was maybe easier to read but I think with the nice variable names in this, we can avoid having to comment the code, this is good and let's use it! We should keep the other version around in case we want to revert or this doesn't work out.

Sure, I can get behind this. Let's 🚀 !

Feel free to merge this.

@zoobot I merged this branch into https://github.com/waterthetrees/wtt_front/pull/410. Could you approve that instead so we provide an easy link to all the relevant PR discussion and context from the merge commit?


Fix issue: reduce_max on empty int32 array

Fix the issue https://github.com/tensorflow/tensorflow/issues/31325
reduce_max on empty int32 array should throws an error message instead of  returns -2147483648

@Kelvin Guu @ravikyram @jvishnuvardhan
Fix the issue https://github.com/tensorflow/tensorflow/issues/31325.
Please have a review

Can you add a test?
It's unclear to me that the smallest integer is the wrong answer here (I'd definitely support returning -inf for empty floating point arrays, and I am worried this breaks that)

Hi @alextp Thanks for the review.
Are you talking about this snippet of code?
https://github.com/tensorflow/tensorflow/blob/2c9cd7db6c9b17956518dd4c76e2858dba4f685c/tensorflow/core/kernels/reduction_ops_common.h#L189-L194
Which handling the situation when the input is empty arrays

With this PR, it do will fail the test when the input is an empty array.
I tried numpy, when the input is empty it will also failed.
>>> import numpy as np
>>> np.max([])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib64/python2.7/site-packages/numpy/core/fromnumeric.py", line 2505, in amax
    initial=initial)
  File "/usr/lib64/python2.7/site-packages/numpy/core/fromnumeric.py", line 86, in _wrapreduction
    return ufunc.reduce(obj, axis, dtype, out, **passkwargs)
ValueError: zero-size array to reduction operation maximum which has no identity

So as-is this is a backwards-incompatible change to TF, so we can't do this. If we want to do this we should make a reduce_max_v2 (and a reduce_min_v2 probably since I doubt the bug is in only one of them) and deprecate the original one.

Thanks @alextp Should I close this one and open a  new PR with reduce_max_v2 ?

Reusing this or opening a new is up to you.
On Tue, Aug 27, 2019 at 4:42 PM Leslie-Fang<EMAIL_ADDRESS>wrote:

So as-is this is a backwards-incompatible change to TF, so we can't do
this. If we want to do this we should make a reduce_max_v2 (and a
reduce_min_v2 probably since I doubt the bug is in only one of them) and
deprecate the original one.
Thanks @alextp https://github.com/alextp Should I close this one and
open a new PR with reduce_max_v2 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/31978?email_source=notifications&email_token=AAABHRNO5JIQIJEBYOIOT7DQGW3VJA5CNFSM4IPP7KDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5JNRZQ#issuecomment-525523174,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAABHRJ3AXMMKSG5RRO7H7LQGW3VJANCNFSM4IPP7KDA
.

--

Alex

But let me run this proposal by the tf api owners tomorrow before you spend
too much time on it.
On Tue, Aug 27, 2019 at 4:53 PM Alexandre Passos<EMAIL_ADDRESS>wrote:

Reusing this or opening a new is up to you.
On Tue, Aug 27, 2019 at 4:42 PM Leslie-Fang<EMAIL_ADDRESS>wrote:

So as-is this is a backwards-incompatible change to TF, so we can't do
this. If we want to do this we should make a reduce_max_v2 (and a
reduce_min_v2 probably since I doubt the bug is in only one of them) and
deprecate the original one.
Thanks @alextp https://github.com/alextp Should I close this one and
open a new PR with reduce_max_v2 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/31978?email_source=notifications&email_token=AAABHRNO5JIQIJEBYOIOT7DQGW3VJA5CNFSM4IPP7KDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5JNRZQ#issuecomment-525523174,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAABHRJ3AXMMKSG5RRO7H7LQGW3VJANCNFSM4IPP7KDA
.

--

Alex

--

Alex

But let me run this proposal by the tf api owners tomorrow before you spend too much time on it.
…
On Tue, Aug 27, 2019 at 4:53 PM Alexandre Passos @.> wrote: Reusing this or opening a new is up to you. On Tue, Aug 27, 2019 at 4:42 PM Leslie-Fang @.> wrote: > So as-is this is a backwards-incompatible change to TF, so we can't do > this. If we want to do this we should make a reduce_max_v2 (and a > reduce_min_v2 probably since I doubt the bug is in only one of them) and > deprecate the original one. > > Thanks @alextp https://github.com/alextp Should I close this one and > open a new PR with reduce_max_v2 ? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#31978?email_source=notifications&email_token=AAABHRNO5JIQIJEBYOIOT7DQGW3VJA5CNFSM4IPP7KDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5JNRZQ#issuecomment-525523174>, > or mute the thread > https://github.com/notifications/unsubscribe-auth/AAABHRJ3AXMMKSG5RRO7H7LQGW3VJANCNFSM4IPP7KDA > . > -- - Alex
-- - Alex

Thanks, Alex. Please let me know the results after your discussion.


Use LazySets.AbstractDirections in TemplateReachSet

xref: https://github.com/JuliaReach/LazySets.jl/issues/2087

fixed in https://github.com/JuliaReach/ReachabilityAnalysis.jl/pull/115


Web Cam Photo URL returns invalid picture when saved

I'm trying to intergrate my rpi-cam with HomeAssistant and trying to trigger a picture when my motion sensor detect something (I know I could do something similar only with raspi-cam-srv but I already have some motion sensor so...).
If I use the URL given in the WebCam tab I can see the image in my browser but if I save it (right click -> save as) and open it with my image viewer I get this error :
Format error decoding Jpeg: Invalid JPEG format: first two bytes are not an SOI marker
And I'm getting the same issue when setting the Picture URL into my HA setup.
Taking picture in the Live tab and saving them from the Photos tabs works just fine tho...
Happy to provide any information you need !

Thanks for the report.
This is fixed in V2.7.1

Great this fixes all of it !
Thanks for the quick update !


[BEAM-189] The Spark runner uses valueInEmptyWindow which causes values to be dropped

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @tomwhite and also anyone from the thread in beam-dev ("question about windowed values") - @kennknowles / @tgroh  / @robertwb

+1 from me


GetEvents request

Description
Closes #53
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented on my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Pull Request Test Coverage Report for Build b5d29acee6019ba8b5615fd440eea9a7fffdf50c-PR-69

74 of 74 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 26c1f61ee75ec65512ff6e230918f3208afc772b:
0.0%

Covered Lines:
343

Relevant Lines:
343

💛  - Coveralls


TSServer: Smart select API

Background
VS Code has proposed a smart selection API (https://github.com/Microsoft/vscode/issues/63935) that allows language extensions to intelligently control how selections are expanded and collapsed.
Just as an example, consider a simple class:
class Foo {
  bar(a, b) {
    if (a === b) {
      return true
    }
    return false;
  }
}

If the user starts with their cursor in the a in  a === b expression, progressively running expand selection may result in the following selections:

The identifier a
The expression a === b
The body of the bar method
The entire bar method declaration
The entire Foo class

The exact selections we want may differ.
You can find the current state of the VS Code API proposal in vscode.proposed.d.ts under the name selection range provider
Proposal
I think we should investigate supporting smart select for JavaScript and TypeScript users, but do so in a cross editor compatible way. The current proposal is derived from VS Code's needs so we should make sure it will work for other editors too
The current VS Code smart selection API proposal takes a position in a document and returns a list of potential expansion ranges. Each returned range also has some metadata about the range's kind (class, expression, statement, interface, ...)
On the TS Server side, a possible API would be:
interface SelectionRangeRequest extends FileLocationRequest {
     command: "selectionRanges";
     arguments: SelectionRangeRequestArgs;
}

interface SelectionRangeRequestArgs extends FileLocationRequestArgs { }

interface SelectionRangeResponse {
     body?: ReadOnlyArray<SelectionRange>;
}

interface SelectionRange {
    textSpan: TextSpan;
    kind: SelectionKind;
}

// Either enum or string?
// VS Code has proposed a dot separated scope: expression.identifier, statement.if
enum SelectionKind {
    Expression,
    Statement,
    Class
}

We also need to determine which selection ranges we should target for a first iteration. A few basic ones:

Whole expression
Statement line
Class / interface
Function
Literal

/cc @DanielRosenwasser, @jrieken, @amcasey

related LSP discussion https://github.com/Microsoft/language-server-protocol/issues/613

/cc @minestarks

A FileRangeRequestArgs might be more appropriate than FileLocationRequestArgs, so that you can pass in the currently selected span.
I think in VS this would roughly map to an implementation of GetSpanOfEnclosing

Here's some thoughts on how expansion could work:
Where should selection stops be added?
Walk the ast from the current position up to the root node, adding a selection to the smart select response when encountering:

Expressions
Statements
Type annotation (such as param: number)
Object literal element (key + value)
Block bodies (both for lists of statements and for class/interface/object bodies, but without the braces)
Comments
String content (without the quotes)
Lists of imports
Whole program

Examples
class Foo {
  bar(a, b) {
    if (a === b) {
      return true;
    }
    return false;
  }
}

Starting on true in return true

true
return true;
The body of the if statement (without braces)
The entire if statement
The body of bar (without braces)
The entire bar method
The body of the class (without braces)
The entire class declaration

class Foo {
  bar(a, b) {
    if (a === b) {
      return true
    }
    return false;
  }
}

Starting on a in a === b

a
a === b
The if statement
The body of bar (without braces)
The entire bar method
The body of the class (without braces)
The entire class declaration
whole program

export interface IService {
	_serviceBrand: any;

	open(host: number, data: any): Promise<any>;
}

Starting on host

host
host: number
host: number, data: any
open(host: number, data: any): Promise<any>;
the body of IService (without braces)
the IService interface
whole program

import { x as y, z } from './z';
import { b } from './';

console.log(1);

Starting on x in x as y

x
x as y
x as y, z
{ x as y, z }
{ x as y, z }
import { x as y, z } from './z';
the list of imports
whole program

We've refined our API on the VS Code side and have decided not to include the Kind in v1.  We've also moved to use a linked list structure instead of an array. Here's an update proposal that reflects this:
interface SelectionRangeRequest extends FileLocationRequest {
     command: "selectionRange";
     arguments: SelectionRangeRequestArgs;
}

interface SelectionRangeRequestArgs extends FileLocationRequestArgs { }

interface SelectionRangeResponse {
     body?: SelectionRange;
}

interface SelectionRange {
    textSpan: TextSpan;
    parent?: SelectionRange;
}

The VS Code api also takes a list of positions in the file and we return a list of selection ranges for each of those positions. This avoids extra requests in some cases. We should consider doing this in the TS api as well, as I don't think there's any downside. This would look like:
interface SelectionRangeRequest extends FileLocationRequest {
     command: "selectionRange";
     arguments: SelectionRangeRequestArgs;
}

interface SelectionRangeRequestArgs extends FileRequestArgs {
    locations: Location[];
}

interface SelectionRangeResponse {
     body?: SelectionRange[];
}

interface SelectionRange {
    textSpan: TextSpan;
    parent?: SelectionRange;
}

Here's the VS Code api: https://github.com/microsoft/vscode/blob/caafa5b6920b0e4b8ce2a8300a61568372da0f7b/src/vs/vscode.d.ts#L3791
/cc @jrieken

@mjbvz when you mention that blocks should be selected without braces, do you want a) all characters including whitespace between the braces to be selected, or do you want b) the selection to be begin and end at non-whitespace characters?

a
b

B I think. That's how we've implemented the feature for VS Code's json and html support at least

Can I get your input on these? (You can consider line independently.)
type X = { /*|*/x?: string };
type M = { [K in keyof /*|*/any]: string };
const x = { /*|*/y };
function f(...ar/*|*/gs) {}

Also, I was looking at an existing smart select test in VS Code, and it looks like there are cases where you expect to get a range with an identical parent range? My approach so far includes deduping identical equal ranges (e.g., in a whole file containing a single function declaration with no surrounding trivia, the function declaration range is the same as the whole file range) on TypeScript's side. Let me know if you'd rather me keep syntactically distinct but positionally redundant ranges in the list.

De-duplicating the ranges sounds correct to me. @jrieken can you confirm if smart select providers should de-duplicate or not?
Some thoughts on those examples:
type X = { /*|*/x?: string };

x
x?
x?: string
{ x?: string }
type X = { x?: string };

type M = { [K in keyof /*|*/any]: string };

any
K in keyof any
 [K in keyof any]
[K in keyof any]: string
{ [K in keyof any]: string }
type M = { [K in keyof any]: string };

const x = { /*|*/y };

y
 { y }
const x = { y };

function f(...ar/*|*/gs) {}

args
...args
function f(...args) {}

function f(
  /*|*/a,
  b,
) {}

a

a,
  b,

function f(
  /*|*/a,
  b,
) {}

const s = `one two ${
  /*|*/three
} four`;

three

${
  /*|*/three
}

one two ${
  /*|*/three
} four

`one two ${
  /*|*/three
} four`

const s = `one two ${
  /*|*/three
} four`;

@jrieken can you confirm if smart select providers should de-duplicate or not?

It's kind of optional because the editor will deduplicate ranges anyways - so if it hinders an elegant implementation I won't do it.

@mjbvz @jrieken thanks! So, in my earlier question, I had swapped my "a" and "b" labels such that the screenshots demonstrated the opposite of the options I had written, but I assumed when you responded "B," you were referring to the picture. (I've since edited the question to be consistent.)
If your answer is still "B," I'm trying to figure out the logical rule for: when do we select all the way up to braces vs. leaving trivia unselected? E.g., in the if statement we want to select all the way up to the braces, but in the import clause ({ x as y, z }) and most of the object-like syntaxes I sent you, we only select up to the whitespace.
I've been trying to think through these scenarios in terms of the probable desired outcomes a user has when expanding a selection, and how easy it is to achieve those outcomes given a particular selection. When braces are on the same line, it's a bit of a toss-up:

I want a multi-line object
Backspace, Backspace, Delete, Return
Return

I want to start my single-line object over
(just start typing)
Space, Space, Left Arrow

I want {}
Backspace, Backspace, Delete
Backspace

When the braces span multiple lines, selecting all the way up to the braces seems to be more versatile:

I want a multi-line object type
(just start typing)
Return

I want a single-line object type
Backspace, Cmd+Backspace, Backspace, Space, Delete, Delete?
Space, Space, Left Arrow

I want {}
Same as above plus one more Delete
Backspace

Now, the really painful sequences above can be avoided by simply expanding the selection one more time to include the braces, then typing {. However, for class declaration bodies and function parameters, that’s not an option:

I want to rewrite my parameters on multiple lines
(just start typing)
Return

I want to delete my parameters or rewrite them on a single line
(painful)
Backspace

These scenarios lead me to suggest one of two possible governing rules:

Always add a stop on both whitespace-exclusive contents and whitespace-inclusive contents. Most versatile, but maybe users would feel like it's too much granularity?
Stop only on whitespace-inclusive contents when braces or parens are on separate lines; stop only on whitespace-exclusive contents when braces or parens are on the same line. This eliminates the most painful scenarios without introducing extra stops. I also think it matches your intuition on every example you've given me so far except the function with parameters on separate lines, which I would select all the way up to the parens.

There are possibly other heuristics that could be considered (like the difference between objects, which have a stop just outside the braces, and classes, which select the braces plus the text class ClassName ), but that might be too unintuitive.
By the way, I'm in Redmond (visiting from SF) until Friday afternoon, so if it's easier to discuss in person, feel free to ping me or come by the TypeScript team room.

Updating thread with results of in-person meeting for posterity: we agreed to go with option 2 above and see how it feels once we have it wired up with VS Code.

One other selection stop to consider for multiline cases: select the entire line including leading whitespace.
For code such as:
function foo(
   /**/a,
   b
)

This would result in the selections:

I've checked in a stubbed out VS Code implementation with https://github.com/Microsoft/vscode/commit/f635233740f2bb44d9e4663f4152f1980ce0bb2b
This is based on the second version of the api proposal, the one that takes a Location[] and returns a SelectionRange[]

Cool, it works with my WIP branch!
It does look like the ranges provided by tsserver are getting merged with Code's other guesses, e.g. when on Syn/**/taxKind, I verified that tsserver says “select SyntaxKind,” but the first selection is just Syntax. Not sure if this is intentional or not, guess that's up to you all.

but the first selection is just Syntax. Not sure if this is intentional or not, guess that's up to you all.

Yeah, that's VSCode itself, expanding words along separators, aA, _, and -

Ok @mjbvz @jrieken, do you want to give it a try? I'm getting the feeling that I could find little bits of syntax to nitpick and customize forever, but I'm pretty sure at this stage I've covered every example listed in this issue discussion plus some. If you don't find any glaring issues, I'll open a PR. Thanks!

Thanks @andrewbranch. I've done some initial testing and ran into one problem. With the cursor at the /**/ in the code:
const z = 1;

interface foo {
    bar(): void/**/
}

In this case, the first returned range is:
        "textSpan": {
            "start": {
                "line": 4,
                "offset": 9
            },
            "end": {
                "line": 4,
                "offset": 9
            }
        },

which causes VS Code's selection range conversion to fail. The top returned range must contain the initial position.
I'll keep testing and share other feedback

Looking good overall. A few other  notes:

const callback/**/ = this.fetchCallback(serverRequest.seq);

There's currently a stop where just the assignment expression is selected:

I don't think this step is necessary. We could jump right to selecting the entire const statement

Doc comments are currently not handled. I think these docs should either be included when the element being documented is or as a separate step. For example:
const x = 1;

/**
 * docs
 */
function foo/**/() {}

Would have some stop with the selection:

Invalid selection range also returned for the case:
function foo() {
	// bla/**/
}

Few more cases may need to consider with explicit separate rules:

JSX <elements attributes={express + ions}> and static text inside those </elements>
`string literals with ${expres + sions} inside them`
Generic<Ty|P|E, "Arguments">

Also, should this enrich resulting range objects with minimal context description?
When IDE extends selection, imagine a tooltip fade in for few seconds, indicating WHAT is selected:

Could be helpful in complex code/JSON spanning multiple screen heights.

@mjbvz @jrieken I just found a case where adding VS Code interlacing its own expansions (specifically the one where it wants to select a full line) produces a pretty weird sequence:

You can see the expansion where [K in keyof P]:  actually gets removed, which I think should never be the case when expanding. TypeScript is giving instructions to expand through the whole type on the right-hand side of the colon, but once that type spans multiple lines, I guess VS Code wants the whole line to be highlighted first. But that line taken on its own is semantically nonsensical.
I would suggest for VS Code to:

disable these full-line selections when taking ranges from TSServer, or
disable them when they are outside the range you get from TSServer.

Simpler example:

I have a general fix for this in vscode that prevents any line selection range that isn’t fully contained by the next range in the list from being added. Will add a test after lunch and PR.


curl is only available on Windows 10 build 17063 or higher

Update documentation to highlight that curl is only available in Windows 10 build 17063 or higher. For a couple of my team their version was too low. Might be worth highlighting on the prerequisites too.
Workaround: just download the file manually.
https://blogs.msdn.microsoft.com/commandline/2018/01/18/tar-and-curl-come-to-windows/

Noted. Fixed in Module 04.


QFieldCloud Jobs : very long time to Process QGIS Project File (SVG files)

Hello,
The project I created refers to 385 SVG files in the project file folder. (SVG file size between 1K and 7K)
I am currently working with QGIS 3.22.4 LTR and QFieldSync 4.0.0.
The SVG project files were uploaded successfully to the cloud, however the project is in busy status for a long time

Checking the jobs with the WebUI, I could notice that it takes 25 seconds per SVG file (pending -> started > finished>

So for 385 files, it should take 385 /2 = around 3 hours before the project status change from busy to ready.
Could you find out why it takes so long, and/or fix this issue.

The problem has been located and immeadiate action will follow today. I will keep you posted when it will not result in an avalanche of jobs again.

Thanks for the fix. I will test it tomorrow.
However the SVG files are not part of the DCIM directory since they are used as road signs (and refer to the SCG directory in QGIS).
Should I consider to copy them in the DCIM directory ? The symbology refers to the SVG file as a feature attribut.


linalg bug fix & cython integration

Summary of changes

Fixed small bug in so_bidiagonalize
Migrated kronecker_fator function to Cython (~60% speedup)
Migrated so4_to_so2 function to Cython (~5% speedup)
These initial Cython migrations weren't as much out of concern for performance, but rather done as more of an experiment and to learn how it works. Now that the structure is there, we may be able to migrate some of the other larger functions and get an actual performance improvement out of kak_decomposition_angles, if we wanted to.

Codecov Report
Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

src/pyqasm/linalg.py
92.85%
1 Missing :warning:

:loudspeaker: Thoughts on this report? Let us know!

I like the idea here and the speed up is pretty good! Going forward, do you think it would be better to arrange the .pyx files in a cython folder and rename the .pyx file as the module name? Eg. -

src/pyqasm/linalg_cy.pyx becomes src/pyqasm/cython/linalg.pyx and
from pyqasm.linalg_cy becomes from pyqasm.cython.linalg import ...


Add more notifications for stylesheet errors

This is a follow up to #5828 which adds custom notifications for a few places that weren't showing them when stylesheet loading failed.
Closes #6356

:blue_heart:


serialization: format the config example as valid JSON

Recognized while implementing validation code for it.
Signed-off-by: Sergiusz Urbaniak<EMAIL_ADDRESS>

LGTM, thanks


"Preparing files for removal" - SimpleDNSCrypt64.msi fails

Hi @bitbeans , thank you for trying to fix Issue #357. The problem unfortunately remains for me. The .msi installers for 0.5.7 --> 0.6.2 fail with the message, "Preparing files for removal." The installation stops there. I use Windows 7 Pro (x64).
I tried to fix the problem:

updated .NET Framework (4.7.1)
updated Microsoft Visual C++ 2017 Redistributable
uninstalled and removed everything from the previous installation

None of those actions solved the problem. 0.5.5. is the last version of Simple DNSCrypt that I can install. (Will 0.5.5 eventually be unsafe for me to use?)
(I tried to comment in #357 instead of opening a new issue. #357 is closed and didn't allow new comments. Sorry.)

Same here.
Windows 10 build 1803
update from 0.6.0 to 0.6.2 fails with same message as above.
I didn't try to manual update (remove and install).

@Woofy-Wolf no its not unsafe to use. There a no known security issues.
@BeBest123 please try a manual uninstall and a fresh install of 0.6.2

@bitbeans I've uninstalled 0.6.0 version, using uninstall.exe in SimpleDNSCrypt directory.
Afterwards, A new installation of version 0.6.2 fails with the same error message above (Status is "Preparing files for removal").
I also got a new window poping up:


Random delay fixes

Found these while writing flows using the random mode of the delay node.
-Mark

Coverage decreased (-0.02%) when pulling 5510dffe184d91203a1e0a72cad5d01b0726ab12 on hindessm:random-delay-fixes into eee2996e8afc84b4650b5df9bcad5374264df9d4 on node-red:master.


[bug] Tauri Updater Azure SAS URL

Describe the bug
I've deployed a static manifest in an Azure storage container, and generated an SAS URL to access it, it would seem that Tauri is calling percent_encoding::percent_decode(url.as_bytes()) on all the endpoints which is breaking the SAS token, for example the SAS signature sig=vyZh2oP1amTzPRAr%2F%2FRac2m3qhpOIwIKD%2B2grtzAtYE%3D becomes sig=vyZh2oP1amTzPRAr//Rac2m3qhpOIwIKD+2grtzAtYE= which causes it to no longer be valid to azure.
Reproduction
1.) Deploy a simple static manifest to an azure storage container.
2.) Create a SAS URL to access the manifest
3.) Setup Tauri updater to point to the manifest.
4.) I locally cloned Tauri to add some debug prints to see the URLs
5.) launch your tauri app.
Expected behavior
I expect it to work and fetch the manifest successfully.
Platform and versions
[✔] Environment
    - OS: Windows 10.0.19045 X64
    ✔ WebView2: 114.0.1823.43
    ✔ MSVC: Visual Studio Community 2022
    ✔ rustc: 1.67.1 (d5a82bbd2 2023-02-07)
    ✔ Cargo: 1.67.1 (8ecd4f20a 2023-01-10)
    ✔ rustup: 1.25.2 (17db695f1 2023-02-01)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 18.14.2
    - yarn: 3.5.0
    - npm: 9.5.1

[-] Packages
    - tauri [RUST]: 1.3.0
    - tauri-build [RUST]: 1.2.1
    - wry [RUST]: 0.24.3
    - tao [RUST]: 0.16.2
    - @tauri-apps/api [NPM]: 1.2.0 (outdated, latest: 1.3.0)
    - @tauri-apps/cli [NPM]: 1.3.1

[-] App

Stack trace
N/A

Additional context
N/A

Managed to fix it by replacing % with %25