anvil: add --memory-limit option

Motivation
Closes #7478
My first rust/foundry PR so let me know  if I can improve anything.
I saw #7482 was opened (thanks @DoTheBestToGetTheBest) but figured some of the code here might be better (better description of the flag that matches the other modules, adds a test, etc.)
Solution
This solution still isn't solving my anvil issues with memory limit even after building locally and passing a high number, but figure it's nice to still have configurable. It's hard for me to share a repro case because it requires a complex setup of ~10 txs (balance updates, mint new nfts, approvals, then fulfill them through Seaport) but I hope to find a more simple repro case to share separately as a bug.

Closing since https://github.com/foundry-rs/foundry/pull/7482 was merged


Minor fix

upload sample of vcc2018
add dependency of mosnet
rename some bins

Yes, I did. But I could not calculate MCD due to lacking GT target data.


Convert authors to list

They're currently strings. Prevents generation of consistently formatted lists.

Converted.


Use enums for requesting permissions

Use enumeration for requesting permission instead of strings.
This is breaking changes, as the method signatures are different.
The default path of requestPermission(String permissionName, Activity activity) in PermissionUtil.java for Android will become unreachable.

In case of Android, it seems like you can use this functions to requires any arbitrary permission, not just one from the list, so change it to enum is likely completely wrong.

In case of Android, it seems like you can use this functions to requires any arbitrary permission, not just one from the list, so change it to enum is likely completely wrong.

The change was made with bringing support to other OSes in future in mind.
It is indeed that the capability of requesting arbitrary permission on Android will be lost, but it has limited use if Godot cannot access what it request permissions for without a plugin (bluetooth, location comes to the mind in the case of Android), and said plugin should already have ways to request permissions for what it is trying to access, without relying on Godot code in the first place.
Of course there might be other ways to achieve cross-platform permission requests without breaking the ability of doing platform-specific (like string constants from what I can think of, but haven't found other classes doing that).

Closing, breaking platform-specific permission requests is not a good idea after all.


Switch to GeometryBasics 0.4.1

This is an updated version of https://github.com/JuliaPlots/Makie.jl/pull/1132. I reran the script (https://github.com/JuliaGeometry/GeometryBasics.jl/pull/97#issue-497319718) and added the deprecation warnings for Quaternionf0, RGBf0, and RGBAf0 from the previous PR.

@SimonDanisch I think this PR is ready for review :slightly_smiling_face:
As in the previous PR, I reexported the deprecated bindings from GLMakie etc. to avoid a breaking change. Unfortunately, this leads to deprecations warnings such as https://github.com/JuliaPlots/Makie.jl/pull/1252/checks?check_run_id=3402333581#step:7:195 in the tests. However, users should not notice it since they won't see the warnings :shrug:

Awesome :) I think we should re-export the old names with a depwarn?

Ah yeah, so far only the names defined in Makie were deprecated and these deprecations were reexported by CairoMakie etc. In the last commit I also reexported the deprecated bindings from GeometryBasics in Makie, so Vec3f0 etc. should be still available if one loads Makie but show a deprecation warning (if warnings are enabled). And they should be reexported by CairoMakie etc. automatically.

I just checked with julia --depwarn=yes, and it seems to work :smile:
julia> using GLMakie
[ Info: Precompiling GLMakie [e9467ef8-e4e7-5192-8a1a-b1aee30e663a]
WARNING: importing deprecated binding GeometryBasics.FRect into Makie.
WARNING: GeometryBasics.FRect is deprecated, use Rectf instead.
  likely near none:1
WARNING: importing deprecated binding Makie.FRect into GLMakie.
WARNING: importing deprecated binding GeometryBasics.FRect2D into Makie.
WARNING: GeometryBasics.FRect2D is deprecated, use Rect2f instead.
  likely near none:1
WARNING: importing deprecated binding Makie.FRect2D into GLMakie.
WARNING: importing deprecated binding GeometryBasics.FRect3D into Makie.
WARNING: GeometryBasics.FRect3D is deprecated, use Rect3f instead.
  likely near none:1
WARNING: importing deprecated binding Makie.FRect3D into GLMakie.
WARNING: importing deprecated binding GeometryBasics.IRect into Makie.
WARNING: GeometryBasics.IRect is deprecated, use Recti instead.
  likely near none:1
WARNING: importing deprecated binding Makie.IRect into GLMakie.
WARNING: importing deprecated binding GeometryBasics.IRect2D into Makie.
WARNING: GeometryBasics.IRect2D is deprecated, use Rect2i instead.
  likely near none:1
WARNING: importing deprecated binding Makie.IRect2D into GLMakie.
WARNING: importing deprecated binding GeometryBasics.IRect3D into Makie.
WARNING: GeometryBasics.IRect3D is deprecated, use Rect3i instead.
  likely near none:1
WARNING: importing deprecated binding Makie.IRect3D into GLMakie.
WARNING: importing deprecated binding GeometryBasics.Point2f0 into Makie.
WARNING: GeometryBasics.Point2f0 is deprecated, use Point2f instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Point2f0 into GLMakie.
WARNING: importing deprecated binding GeometryBasics.Point3f0 into Makie.
WARNING: GeometryBasics.Point3f0 is deprecated, use Point3f instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Point3f0 into GLMakie.
WARNING: importing deprecated binding GeometryBasics.Point4f0 into Makie.
WARNING: GeometryBasics.Point4f0 is deprecated, use Point4f instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Point4f0 into GLMakie.
WARNING: Makie.Quaternionf0 is deprecated, use Quaternionf instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Quaternionf0 into GLMakie.
WARNING: Makie.RGBAf0 is deprecated, use RGBAf instead.
  likely near none:1
WARNING: importing deprecated binding Makie.RGBAf0 into GLMakie.
WARNING: Makie.RGBf0 is deprecated, use RGBf instead.
  likely near none:1
WARNING: importing deprecated binding Makie.RGBf0 into GLMakie.
WARNING: importing deprecated binding GeometryBasics.Rect2D into Makie.
WARNING: GeometryBasics.Rect2D is deprecated, use Rect2 instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Rect2D into GLMakie.
WARNING: importing deprecated binding GeometryBasics.Rect3D into Makie.
WARNING: GeometryBasics.Rect3D is deprecated, use Rect3 instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Rect3D into GLMakie.
WARNING: importing deprecated binding GeometryBasics.Vec2f0 into Makie.
WARNING: GeometryBasics.Vec2f0 is deprecated, use Vec2f instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Vec2f0 into GLMakie.
WARNING: importing deprecated binding GeometryBasics.Vec3f0 into Makie.
WARNING: GeometryBasics.Vec3f0 is deprecated, use Vec3f instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Vec3f0 into GLMakie.
WARNING: importing deprecated binding GeometryBasics.Vec4f0 into Makie.
WARNING: GeometryBasics.Vec4f0 is deprecated, use Vec4f instead.
  likely near none:1
WARNING: importing deprecated binding Makie.Vec4f0 into GLMakie.

julia> Vec3f0
WARNING: GeometryBasics.Vec3f0 is deprecated, use Vec3f instead.
  likely near REPL[3]:1
Vec{3, Float32}

Alright lets do this!!!


Deployment of D365FO LCS project and environments in France.

Hello,
We are trying to get our D365FO LCS project and environments in French datacenters since October 2019.
This seems not to be possible, we cannot deploy one single environment in France, not for the moment at least.
We have hard time getting answers from Microsoft also, do not know why this is not working and when will it work.
If anyone could give hand on this one, it would be great.
Thanks
Saso

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9be03020-97a8-0f3c-d39c-f50f9987a89d
Version Independent ID: 0737be8a-48fc-3e5d-e99d-a5c4d54d0744
Content: Finance and Operations apps in France
Content Source: articles/fin-ops-core/dev-itpro/deployment/france-local-deployment.md
Service: dynamics-ax-platform
Product: ****
Technology: ****
GitHub Login: @tfehr
Microsoft Alias: tfehr

@SasoGLIGOR, have you contacted Support? If not, please do so to get assistance from the Support team. If you have contacted Support, and you have a pending support ticket, please let us know so we can follow up in regard to this issue.

Hi Tonya and thanks for the reply.
Sure, we have contacted support, and still have an ongoing ticket with Microsoft.
The résumé is the following :

First we were asked to justify why do we need our environments in France.
Then, we needed to recreate our LCS project in the French version: fr.lcs.dynamics.com
Then, we weren’t able to complete the onboarding process, cannot choose Azure region.
Then, we weren’t able to deploy the environments, cannot choose Azure region, again.
Then, we deployed the environments but they stayed in “Queued” state.
Then, the Tier-1 environments were deployed, but not the Tier-2, incomplete state.
To be continued…
Here we are today, advancing but very slowly.
Objectively speaking, the possibility described in this article, is just not yet available.
Thanks
Saso

Thanks for the update, I will forward your info on to the appropriate team. Please send me a personal email at<EMAIL_ADDRESS>so I have your email address.

Hello,
I have some good news, we managed to deploy our D365FO environments in French DC.
Let me continue with the steps that followed my preceding post :

We had to redeploy all of the environments, the Azure connectors were incorrect.
Then, we were able to connect the Tier-2, but not to Tier-1 environments.
Then, we were able to connect to all of the environments, but the details page.
Then, after all of the tuning, we finally managed to have an operational LCS project.

There are some small side effects to be resolved, but this is really minor issues.
I hope that the path we traced will help French clients to get the service more effortlessly.
Thank you Tonya and MS support team.
Kind regards,
Saso

This is great news, thank you for the update. I will pass this information on to the rest of the team.


Possible accuracy issues.

I think we have some problem with the measurements,
Scenario: If I'm on a bike, the measurements fail and it doesn't register on the map correctly.
Another scenario: walking seems to work well or better, without errors.
I'm not sure if it's a problem with the country (Brazil) or not, I'm still investigating the problem further.

Well, the app uses a simple PDR algorithm. PDR stands for Pedestrian Dead Reckoning, which only applies to pedestrians, not cyclists.

Well, the app uses a simple PDR algorithm. PDR stands for Pedestrian Dead Reckoning, which only applies to pedestrians, not cyclists.

In this case it makes sense that it doesn't work with bikes, do you have any ideas how you could make this work with bikes?

Unfortunately, no. This is the term project of a course about indoor positioning technology, since indoor cycling is usually not possible, the research on the positioning of cyclists is beyond the scope of the course. The GNSS(Global Navigation Satellite System) signal is usually weak indoors, so the PDR algorithm mainly relies on accelerometers, gyroscopes and magnetometers. If you are on a bike, using GNSS directly is much better.
In fact, the PDR algorithm itself has many limitations. It assumes that the pedestrian's phone is being held forward smoothly. The pace is then detected by the pattern of changes in the sensor output. For the cycling scenario, I don't know how to do this.

Unfortunately, no. This is the term project of a course about indoor positioning technology, since indoor cycling is usually not possible, the research on the positioning of cyclists is beyond the scope of the course. The GNSS(Global Navigation Satellite System) signal is usually weak indoors, so the PDR algorithm mainly relies on accelerometers, gyroscopes and magnetometers. If you are on a bike, using GNSS directly is much better.
In fact, the PDR algorithm itself has many limitations. It assumes that the pedestrian's phone is being held forward smoothly. The pace is then detected by the pattern of changes in the sensor output. For the cycling scenario, I don't know how to do this.

Thanks for the explanation, I think I'm starting to understand your project better.
If you are interested in improving the project even further, I would like to be part of it and contribute more PR, there is still a lot to improve, background services (which I have already done) and other things.
Thank you for everything so far.

I don't think I'll be working on it anymore, but I'm very glad to see someone interested in my project and make it better. I would invite you to be a collaborator on this repository. Just feel free to do it. Thank you for your contribution.


fix(express): use the same clock for span start and end

Fixes #1193
Fixes #1209
Express instrumentation does not pass a time to span start but does pass a time to span.end, which results in undefined behavior. Previous to https://github.com/open-telemetry/opentelemetry-js/pull/3134 this was not a problem as the span always used the same hrTimer that we expose in core. Now that we anchor clocks, it is possible for these clocks to be out of sync.

Hey @dyladan - first off thank you so much for your work on the anchored clock to mitigate the time drift!
We have recently tried to rollout 1.7.0/0.33.0 OTEL instrumentation and faced a similar issue as the ones this PR fixes – negative span durations caused by start time being higher than the end time (negative span duration probably results in out of bound error and is shown as a very long duration in Honeycomb instead):

I understand that this PR address the issue with node.js instrumentation only.
Do you think there could be a similar issue but in the web instrumentation?

Hey @dyladan - first off thank you so much for your work on the anchored clock to mitigate the time drift! We have recently tried to rollout 1.7.0/0.33.0 OTEL instrumentation and faced a similar issue as the ones this PR fixes – negative span durations caused by start time being higher than the end time (negative span duration probably results in out of bound error and is shown as a very long duration in Honeycomb instead):  I understand that this PR address the issue with node.js instrumentation only. Do you think there could be a similar issue but in the web instrumentation?

There definitely could be a similar issue but I'm surprised to see it both in XHR and Fetch. Is that happening on all spans or just some?

Good question @dyladan , looks like in our case it happened on a significant portion of the spans but not all of them:

All of the bad spans are coming from the same instrumentations? Do you have any other instrumentations? Are they reporting good or bad spans?

fetch is setting end time also manually see
https://github.com/open-telemetry/opentelemetry-js/blob/afe065772360d3acec8b8fc15e20536fd896c6c6/experimental/packages/opentelemetry-instrumentation-fetch/src/fetch.ts#L99-L116
https://github.com/open-telemetry/opentelemetry-js/blob/afe065772360d3acec8b8fc15e20536fd896c6c6/experimental/packages/opentelemetry-instrumentation-fetch/src/fetch.ts#L281-L289

All of the bad spans are coming from the same instrumentations? Do you have any other instrumentations? Are they reporting good or bad spans?

Majority of the "negative" spans were coming from XHR and Fetch instrumentations. Notable, document load wasn't affected at all as it probably just uses the timings provided by the browser resource timing.

Relevant code for the XHR instrumentation:
https://github.com/open-telemetry/opentelemetry-js/blob/610808d3b64b9f660f4dd640ad961b8c9f67be66/experimental/packages/opentelemetry-instrumentation-xml-http-request/src/xhr.ts#L434-L441
I think both Fetch and XHR have to store the timestamp and then schedule a timeout to wait for the network events to be ready. There's a comment explaining that:

 // the timeout is needed as observer doesn't have yet information
 // when event "load" is called. Also the time may differ depends on
 // browser and speed of computer


'minimumContrastRatio' Client Parameter No Longer Working in Build 1.7.3-a8cae75

Describe the bug
Client option ('-t') 'minimumContrastRatio' setting is no longer respected in 1.7.3-a8cae75.
To Reproduce
Steps to reproduce the behavior:

Enable high-contrast theme with an accessibility best practice contrast ratio of 21:1 using the supported underlying xterm.js parameter 'minimumContrastRatio' as follows:

ttyd -p 8080 -i lo -t titleFixed="Cimple Cloud" -t fontSize=16 -t minimumContrastRatio=21 \
-t 'theme={"background": "#ffffff", "foreground": "#000000", "cursor": "#000000", "selection": "#000000"}' \
/opt/my/script.sh

Connect to ttyd session in latest Chrome or Edge browsers and select any terminal text.
Observe that the selection is not visible: white selection is shown on a white background making it impossible to see what text you are trying to select. Thus, it seems 'minimumContrastRatio' setting of 21:1 is not effective.
Revert back to ttyd version 1.7.1-45ef578 and select the same text which is now shown properly; black selection bar on selected black text turns the text white so you can see what you are selecting.

Expected behavior
When high contrast theming is in use (ex. white background, black foreground, white selection), 'minimumContrastRatio=21' should be respected by ttyd.
Screenshots

Environment:

ttyd server: OS Ubuntu Server 22.04, client: Windows 10 21H2
Browser: Chrome 110.0.5481.177, MS Edge 110.0.1587.57

Additional context
Not sure if this was something broken between ttyd versions or broken in underlying xterm.js. If it is determined that nothing changed in ttyd with respect to 'minimumContrastRatio' client option, then I am happy to open a bug report with the underlying xterm.js devs. Thank you for your excellent software and continued support. You are greatly appreciated.

Not sure if this was something broken between ttyd versions or broken in underlying xterm.js

You can check if it can be reproduced with xterm.js demo

Hello,
Thank you for your quick response and suggestion of testing the xterm.js demo. I should have RTFM or, more specifically, checked the xterm.js ITheme changes prior to opening this bug report for ttyd as the source of the problem was not related to ttyd or 'minimumContrastRatio' at all. The root cause was actually a change in the ITheme interface option, "selection". It seems the old, singular "selection" option has now itself been replaced and broken out into multiple options which offer more fine-grained control over text selection color:

After testing, I have found the following updated configuration to sufficiently replicate the behavior I required without having to use "minimumContrastRatio" at all:
ttyd -p 8080 -i lo -t titleFixed="Window Title" -t fontSize=16 \
-t 'theme={"background": "white", "foreground": "black", "cursor": "black", "selectionBackground": "black", "selectionForeground": "white"}' \
/opt/my/script.sh

Please accept my apologies for opening this bug report in error. I know too well the headache of users opening false bug reports and the undue frustration it can cause. In future I will do better about checking upstream changes in xterm.js before making any assumptions about ttyd.


Non-zero exit status when no tests found with --findRelatedTests`

Do you want to request a feature or report a bug?
bug
What is the current behavior?
$ jest --findRelatedTest index.js
No tests found
$ echo $?
1

What is the expected behavior?
The exit status should be 0.
IMHO, this behavior makes sense for all dynamic tests selection: --onlyChanged, --lastCommit, etc.
Note: I know about --passWithNoTests but I don't think it should be necessary for these use cases.
Please provide your exact Jest configuration and mention your Jest, node,
yarn/npm version and operating system.

jest 22.0.4
Node 9.3.0
yarn 1.3.2

Dup of #5112, but I still think it should be the default.

It seems this issue has been decided in #5127.
Closing this .


User location not centered to and shown when opening app for the first time

As stated in the title, when you open the app for the first time and get the question to allow the app to track your location. After selecting that you want the app to track your location, it decides to not reload the user's location marker or center the user's location.

Based on what I'm thinking. You probably could add a quick line to the track user location segment of the code to refresh all that data.


database performance improvement : use foreach() when possible

Previously, there are count() and then loop with for(), the foreach actually should already can handle it.
Checklist:

[x] Securely signed commits

Honestly, the performance difference you're going to see here is likely so close as to be non-existent. But this is cleaner, easier to read, and doesn't look like it will break anything so I'm down.


Show a single 422 error for invalid values

This is an additional fix on top of #5851.
The idea is that the API should return a 422 Validation Error for requests with invalid values for parameters. The controller layer has already been updated in #5851 to ensure that it only looks for valid values from the API, meaning it only ever serves 404
refs #5808

This PR needs https://github.com/TryGhost/Ghost/pull/5870 to be merged then I can rebase it.


Feature request: Add example with real data

This is a very nice package.  I like how you leverage the Pandas library. I think it would be very helpful to include a Jupyter Notebook with an example of your functions and their output.  I noticed that the input for your key functions are Pandas dataframes, and would like to see how you go from the source data to the Pandas dataframe format.

This is a very nice package. I like how you leverage the Pandas library. I think it would be very helpful to include a Jupyter Notebook with an example of your functions and their output. I noticed that the input for your key functions are Pandas dataframes, and would like to see how you go from the source data to the Pandas dataframe format.

Great idea, I will add some examples to the readme and will include some demo files.
Thanks for the comments!

An example Jupyter Notebook and csv file with 5 spectra have been added to a demo folder in the repo directory, and I added to the readme showing the code and results from the example Jupyter Notebook. Hope it is helpful! Will add more later when I get a chance. Have more ideas for some fun features! (Note: I haven't added the new files to pypi yet)

That is extremely helpful. That was fast! Thank you!


Update msal 0.2.x

Updated the sample to support the latest MSAL version.
Switched to Webview authentication (instead of default Chrome) to make it work on Android Emulators #18

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Glennmen sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@danieldobalian I changed WEBVIEW to DEFAULT. After a quick test it does seem it works on devices without Chrome.
The docs where just very confusing to me.

Closing this PR as we are archiving this sample. Please see https://github.com/microsoftgraph/msgraph-training-android for an Android sample.


Initial version of operator

[x] Inject cluster-id in cloud configuration.
[x] Parse secret generated by CCO.
[ ] Create a StorageClass

I won't cover the creation of the SC in this PR.
CC @openshift/storage

I'll not cover creating the StorageClass (and the storage policy) in this PR.

/lgtm
/approve

/refresh

/hold

/hold cancel
(trying to trigger the bot to approve this PR)

/approve


Use full textspan tree instead of top level textspan

The TextSpan holds text as a tree of strings. It was incorrect usage of API to check only _text.text. This fixes it to use the full tree traversal through TextSpan.toPlainText()

cc @jslavitz This fixes the iOS caret bug you found yesterday.

+1 for a test.  Would that just be a double wide character before or after the cursor?  Otherwise it looks good to me and shouldn't interfere with my text painter work.

+2 for a test!


tfchain explorer client expects byte message in explorer response but string is possible too

It seems that https://github.com/threefoldtech/jumpscaleX/blob/0b4eeae47d63865fc632dc09be62615f003a0ff7/Jumpscale/clients/blockchain/tfchain/TFChainExplorerClient.py#L43 expects a bytes type, while a user (@zaibon) had a situation where a string as e.message is possible as well.
It should be checked in the HTTP client what kind of types are possible, and make sure that the explorer client handles this properly.
Now a confusing error is raised as can be seen in the following screenshot provided by @zaibon:

Fixed by fd30a2c532a4fa58f5fc91c9c14c99d5922a657d.


Canonical way to to convert AST objects to dicts

For viewing the whole parsed AST in a Python console/notebook, or iterating over it, it's practical to convert the AST objects to dicts. At the moment, I'm using the following snippet, but it would be nice to have a canonical way in TextX, perhaps as an object method.
def obj_to_dict(o):
    if isinstance(o, TextXClass):
        return {
            k: obj_to_dict(v) for k, v in vars(o).items()
            if k[0] != '_' and k != 'parent'
        }
    elif isinstance(o, list):
        return [obj_to_dict(x) for x in o]
    return o

Usually when dealing with your AST/model you need to know structure and semantics to do anything useful. But, as you say, there are times when some generic processing is needed like printing. There is a model API call children_of_type that can be used for generic iteration.
If that doesn't work for you and you come up to some better generic solution feel free to send a PR and I'll be glad to review/merge it!
Be aware that elements of ASTs/models can also be instances of user provided classes.


[WIP] F#+ Lenses

[x] Tests

Additional tests needed

[x] write to array
[x] write to object
[x] write using _Type
[x] write: what happens when index does not exists?
[x] read: what happens when index does not exists?
[ ] write: what happens when key does not exists?
[x] read: what happens when key does not exists?

Starting to port lenses from lens-aeson
Note: Depends on pre release version of f#+

We need to verify that usage of the lenses doesn't cause to much of a slowdown when used.

If they do so, it may be worth exploring other lens implementations, based on Data.Lens and add PR to F#+ to a different namespace.

I'm not sure lenses are needed as much for JSON data, since the format is inherently mutable.

Sounds like a plan 😄

It would be nice of you could mix them somehow?

The compilation cost of lenses are now negligible! Awesome work @gusty !

Compilation times:

No lenses: Time Elapsed 00:00:45.90
F#+ 1.1.0-CI00230 lenses: Time Elapsed 00:02:10.57
F#+ 1.1.0-CI00240 lenses: Time Elapsed 00:01:03.53
F#+ 1.1.0-light-lenses lenses: Time Elapsed 00:00:44.95


error calling the service

this is error i get:
SoapFault in Service.php line 218: Object reference not set to an instance of an object.

there is my code:
SoapWrapper::add(function ($service) {
            $service
                ->name('multipass')
                ->wsdl('http://<IP_ADDRESS>/MultipassServices/GenericTransactionsService.svc?wsdl')
                ->trace(true);
        });

        $data = [
            'OrganizationCode' => '44',
            'OrganizationUserName' => 'StandardPOS',
            'OrganizationPassword' => 'StandardPOS1562',
            'PosId' => 11299,
            'CardCode' => '21890001016144650',
            'TranType' => 'T',
            'IsMaster'=> 'N',
            'MasterAmount' => '0',
            'tranSum' => 3000,
            'tranValue' => 3000,
        ];

        SoapWrapper::service('multipass', function ($service) use ($data) {
            dd($service->call('AddTransaction', [$data]));
        });

there is dump from Service.php:call()
SoapClient {#342 ▼
+"trace": 1
+"_soap_version": 1
+"sdl": Unknown resource @325
}

found what was the issue:
$data = [ 'tranInfo' => [
    'OrganizationId' => 44,
...
]];


Potential memory corruption in exponentially unrolled linked list

Describe the bug

What did you do?
I'm using tantivy to index the C source of OpenBSD. I wrote a custom tokenizer to break up C code syntactically. With the default tokenizer it works fine.
What happened?
All indexing threads panic, after 30-40 seconds of indexing (longer in debug mode). Backtraces show that the panic happens here - I added some debug code and it looks like its happening the first time through the loop. The page section of the addr seems to be invalid (index out of bounds: the len is 7 but the index is 514).
What was expected?
Tantivy not to panic (buggy tokenizer or no).

Which version of tantivy are you using?
0.9.1 and then Master (5559e61)
To Reproduce
Was caused by running this tool on the OpenBSD codebase.

@ashfordneil Thanks for the report.
I was able to reproduce and spot the problem.
Terms are limited to u16::max_value() = 65_536 bytes.
You can solve your problem by plugging the RemoveLongFilter to your tokenizer.
I'll see what should be done so that the problem does not hit other users in the future.
use tantivy::tokenizer::{Tokenizer, RemoveLongFilter};
index.tokenizers().register("c", CTokenize.filter(RemoveLongFilter::limit(100)));

Cool program
 looker git:(master) ✗ ./target/release/looker search contents hello
/home/paul/git/openbsd/usr.sbin/ospfd/hello.c
/* hello header */
	hello.mask = iface->mask.s_addr;
	hello.hello_interval = htons(iface->hello_interval);
	hello
/home/paul/git/openbsd/usr.sbin/ospf6d/hello.c
hello.opts = htonl(hello.opts);

	hello.hello_interval = htons(iface->hello_interval);
	hello
/home/paul/git/openbsd/regress/lib/libc/open_memstream/open_memstreamtest.c
"failed, buffer non zero (offset %d). (14)", i);
			failures++;
			break;
		}

	if (memcmp(buf + OFFSET, hello, sizeof(hello

@ashfordneil  Did you manage to work around the problem?

I assume this is this piece of code.

https://github.com/ashfordneil/looker/blob/master/src/lexer.rs#L136-L138

1 << 16 itself  is not accepted, so your fix will still bug if you meet a token with exactly the size 1 << 16. The largest accepted value is 1 << 16 - 1.
That being said, I recommend you set a lower value than this for the largest token.
In my experience, long tokens are always binary data that people will never be able to search.
Restricting the token length to let's say 500 characters will most likely not have any impact on your users.

In 0.10 token exceeding the accepted length will be discarded.

Do you think it might be helpful to log on warning or info levels to tell the user that some tokens were skipped?
AFAIK, the fix prevents panics, but the failure to tokenize is silent to the user.

@petr-tik It certainly does not hurt to add a log in debug mode at least.

@petr-tik Added an info! log.


Version check uses wrong version

Installed version 0.1.0 of sc-toolbox is outdated. Newest version is 0.6.0!
Something is not in the cookietemple.cfg file

I can reproduce it, but it makes no sense. There is no 0.1.0 anywhere.
Got an idea @Imipenem ?


CreateSnapshotAndAttach does not kill the created process

I would expect calling Dispose on the returned target to kill the suspended process created by CreateSnapshotAndAttach.
The problem can be seen with this simple sample:
static void Main()
{
    for (int i = 0; i < 10; i++)
    {
        using var dt = DataTarget.CreateSnapshotAndAttach(Process.GetCurrentProcess().Id);
    }
}

If you break on the last line you can see that the 10 processes are still there:

While looking at the code, I noticed that adding in WindowsProcessDataReader.Dispose
Process.GetProcessById(ProcessId)?.Kill();

does fix the issue.
I'd be happy to propose a PR!

It looks like the kill was removed in https://github.com/microsoft/clrmd/pull/903

Sorry for the delay, I've been working on other projects.  I have a small issue on the PR to resolve.

@leculver @jairbubbles can you please tell if this is released? I see that the latest version is 2.0.226801 and was released 3 months ago, and looks like fix was done later

It doesn't seem so indeed. A simple workaround is to manually kill the process.

On our case we want to dump thread stack traces into logs whenever we identify that our process is in deadlock in production environment. So this might be problematic there. Is there any plans to release this functionality?

I'm just a dev there 😁, only @leculver can answer!

Got it, anyway thanks for reply :)

My implementation of this - doesn't need modifying the source, but is super hacky:
                if (target.DataReader.GetType().Name == "WindowsProcessDataReader")
                {
                    var val = int.Parse(target.DataReader.DisplayName["pid:".Length..], System.Globalization.NumberStyles.HexNumber);
                    var proc = Process.GetProcessById(val);
                    if (proc.ProcessName == thisProc.ProcessName)
                    {
                        try { proc.Kill(); } catch { }
                    }
                }


HDDS-3291. Write operation when both OM followers are shutdown.

What changes were proposed in this pull request?
Added a new parameter for om rpc client time out. In this way, it will only affect OM Rpc Client.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3291
How was this patch tested?
Tested this on a docker cluster with the below settings. We should increase the timeout duration to a larger value so that OM will think it is the leader for a longer period even though it is not, and the request will be accepted by leader, and it will retry forever.
OZONE-SITE.XML_ozone.om.client.rpc.timeout=30s
OZONE-SITE.XML_ozone.om.leader.election.minimum.timeout.duration=1m
Now with this patch, request fails after 15 retries. And for OM Server which it thinks it is leader, we get SocketTimeOutException, and move to next OM.
Logs:
2020-04-13 21:59:44,667 [main] INFO  RetryInvocationHandler:411 - com.google.protobuf.ServiceException: java.net.UnknownHostException: Invalid host name: local host is: (unknown); destination host is: "om3":9862; java.net.UnknownHostException; For more details see:  http://wiki.apache.org/hadoop/UnknownHost, while invoking $Proxy20.submitRequest over nodeId=om3,nodeAddress=om3:9862 after 13 failover attempts. Trying to failover immediately.
2020-04-13 21:59:44,667 [main] INFO  RetryInvocationHandler:411 - com.google.protobuf.ServiceException: java.net.UnknownHostException: Invalid host name: local host is: (unknown); destination host is: "om1":9862; java.net.UnknownHostException; For more details see:  http://wiki.apache.org/hadoop/UnknownHost, while invoking $Proxy20.submitRequest over nodeId=om1,nodeAddress=om1:9862 after 14 failover attempts. Trying to failover immediately.
2020-04-13 22:00:14,677 [main] INFO  RetryInvocationHandler:411 - com.google.protobuf.ServiceException: java.net.SocketTimeoutException: Call From 531e9bfac0d9/<IP_ADDRESS> to om2:9862 failed on socket timeout exception: java.net.SocketTimeoutException: 30000 millis timeout while waiting for channel to be ready for read. ch : java.nio.channels.SocketChannel[connected local=/<IP_ADDRESS>:47798 remote=om2/<IP_ADDRESS>:9862]; For more details see:  http://wiki.apache.org/hadoop/SocketTimeout, while invoking $Proxy20.submitRequest over nodeId=om2,nodeAddress=om2:9862 after 15 failover attempts. Trying to failover immediately.
2020-04-13 22:00:14,678 [main] ERROR OMFailoverProxyProvider:286 - Failed to connect to OMs: [nodeId=om1,nodeAddress=om1:9862, nodeId=om3,nodeAddress=om3:9862, nodeId=om2,nodeAddress=om2:9862]. Attempted 15 failover

Thank You @arp7 for the review.


Can't rename files

Whenever I try to rename a file from say 'sentence.js' to 'Sentence.js' (changing from lower case to upper case). VSCode will change the name for a second but immediately falls back to the old name. The name in the explorer is different from the name on the tab. I have disabled all extensions and the issue remains. I am not sure if this is a bug or a feature that I am not aware of.
Steps to recreate

create a file 'hello.js;
change the file name to 'Hello.js' (change the letter case only h->H)
save the file.
issue: the file changes back to' hello.js' on the tab. The file in the explorer is 'Hello.js'. Also auto import will import the file from 'hello.js'

Version: 1.52.1
Commit: ea3859d4ba2f3e577a159bc91e3074c5d85c0523
Date: 2020-12-16T16:30:02.420Z (1 wk ago)
Electron: 9.3.5
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.6.0
Computer OS: Mac Catalina 10.15.7

This works just fine for me.
Can you reproduce with latest vscode insiders
https://code.visualstudio.com/insiders/
fyi @bpasero in case you are aware of duplicates

This works just fine for me.
Can you reproduce with latest vscode insiders
https://code.visualstudio.com/insiders/
fyi @bpasero in case you are aware of duplicates

It would be interesting if the file fails to change on disk and this is just a label issue or if the casing really does not change on disk. We have had other issues such as https://github.com/microsoft/vscode/issues/113277 which are similar.

It would be interesting if the file fails to change on disk and this is just a label issue or if the casing really does not change on disk. We have had other issues such as https://github.com/microsoft/vscode/issues/113277 which are similar.


Developer environment fails to launch as a result of CNI issues within minikube.

Is this a bug report or feature request? (choose one): BUG REPORT

Kubernetes Version (output of kubectl version): v1.5.1 and v1.5.2
Helm Client and Tiller Versions (output of helm version): v2.1.3
Development or Deployment Environment?: Development
Release Tag or Master: All
Expected Behavior: Happy developers, rainbows, unicorns etc
What Actually Happened: Minikube blows up.
How to Reproduce the Issue (as minimally as possible):
Follow minikube developer documentation to the letter. (13/Feb/2017)
Any Additional Comments:
There appears to be some bugs in minikube when using CNI networking. In particular there looks to be a race issue with ipset that causes Calico to crash when loading a large number of pods: https://paste.fedoraproject.org/556865/94945148/raw/
As a workaround we can develop without CNI support, as we are not yet making use of network policy:
# Clone the project:
git clone https://github.com/att-comdev/openstack-helm.git && cd openstack-helm

# Get a list of the current tags:
git tag -l

# Checkout the tag you want to work with (if desired, or use master for development):
git checkout 0.1.0

# Start a local Helm Server:
helm serve &
helm repo add local http://localhost:8879/charts

# You may need to change these params for your environment. Look up use of --iso-url if needed:
minikube start \
        --kubernetes-version v1.5.2 \
        --disk-size 40g \
        --memory 16384 \
        --cpus 4 \
        --vm-driver kvm \
        --iso-url=https://storage.googleapis.com/minikube/iso/minikube-v1.0.6.iso

# Initialize Helm/Deploy Tiller:
helm init

# Package the Openstack-Helm Charts, and push them to your local Helm repository:
make

# Label the Minikube as an Openstack Control Plane node:
kubectl label nodes openstack-control-plane=enabled --all --namespace=openstack

# Deploy each chart:
helm install --name mariadb --set development.enabled=true local/mariadb --namespace=openstack
helm install --name=memcached local/memcached --namespace=openstack
helm install --name=rabbitmq local/rabbitmq --namespace=openstack
helm install --name=keystone local/keystone --namespace=openstack
helm install --name=cinder local/cinder --namespace=openstack
helm install --name=glance local/glance --namespace=openstack
helm install --name=heat local/heat --namespace=openstack
helm install --name=nova local/nova --namespace=openstack
helm install --name=neutron local/neutron --namespace=openstack
helm install --name=horizon local/horizon --namespace=openstack

The Calico error is
FailedSystemCall: Failed system call (retcode : 1, args : ('ipset', 'restore'))
  stdout  :
  stderr  : ipset v6.29: Error in line 1: Kernel error received: set type not supported

  input  : create felix-all-ipam-pools hash:net family inet maxelem 1048576 --exist
create felix-all-ipam-pools-tmp hash:net family inet maxelem 1048576 --exist
flush felix-all-ipam-pools-tmp
add felix-all-ipam-pools-tmp <IP_ADDRESS>/16
swap felix-all-ipam-pools felix-all-ipam-pools-tmp
destroy felix-all-ipam-pools-tmp
COMMIT

It suggests that the relevant ipsets kernel module isn't being loaded.

Yes, looks like the v1.0.6 ISO is missing the relevant IP sets kernel modules (but they are present in v1.0.4.
On v1.0.6, the core IP set module is compiled in but all the "type" modules are disabled (so you can't actually create an IP sets). In addition, there is a low limit (256) on the number of IP sets:
$ zcat /proc/config.gz  | grep IP_SET
CONFIG_IP_SET=y
CONFIG_IP_SET_MAX=256
# CONFIG_IP_SET_BITMAP_IP is not set
# CONFIG_IP_SET_BITMAP_IPMAC is not set
# CONFIG_IP_SET_BITMAP_PORT is not set
# CONFIG_IP_SET_HASH_IP is not set
# CONFIG_IP_SET_HASH_IPMARK is not set
# CONFIG_IP_SET_HASH_IPPORT is not set
# CONFIG_IP_SET_HASH_IPPORTIP is not set
# CONFIG_IP_SET_HASH_IPPORTNET is not set
# CONFIG_IP_SET_HASH_MAC is not set
# CONFIG_IP_SET_HASH_NETPORTNET is not set
# CONFIG_IP_SET_HASH_NET is not set
# CONFIG_IP_SET_HASH_NETNET is not set
# CONFIG_IP_SET_HASH_NETPORT is not set
# CONFIG_IP_SET_HASH_NETIFACE is not set
# CONFIG_IP_SET_LIST_SET is not set

@fasaxc Awesome! Thanks for the update, I'll try and test again against the 1.0.4 iso that we caught this issue with last time: https://github.com/kubernetes/minikube/issues/973.
@v1k0d3n, we should probably keep an eye on this issue: https://github.com/kubernetes/minikube/issues/1110 as it may help us keep sidestep these regressions in future, and let us add other goodies to the iso that we would like to use moving forward.

i think this issue is resolved, and we're having other new issues with minikube and older versions of kube under v1.5.3. going to close out this issue @intlabs in favor of tracking this as a side kubernetes item. i've gotta think of some ways to monitor dependencies on minikube, but i'd like to think that having our own ISO would help with this some (at least this specific problem).


Make a standard toolkit for adding launch with options

We have special methods for each of the DNAstack/DNANexus/Firecloud.  We would like to see a toolkit for adding buttons that we could provide for external collaborators.
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Fix Versions: Dockstore 2.X
┆Sprint: Seabright Sprint 16 Pram
┆Issue Number: DOCK-94
┆Epic: Launch-with Support

Toolkit should include recommendations for API endpoints to hit as well depending on when this is done

➤ Charles Overbeck commented:
This is mainly done, although need to tidy up to handle non-WDL partners.

➤ Charles Overbeck commented:
Also, mention /metadata/config.json endpoint (DOCK-839)

➤ Denis Yuen commented:
Was merged and is present (not really user facing)


How to convert project created in windows to mac for ios app

I am not sure what should be title but here is my problem.
1 year ago I had created Flutter Projects in Windows pc without kotlin and swift support
So all of the plugins and others things were done in that format.
AT THAT TIME I DONT WANT IOS APP BUT NOW I WANT IOS APP

So please anyone suggest me what should i do because its android application is already live now when i run on ios app there are plugins error
flutter doctor -v
[✓] Flutter (Channel stable, v1.12.13+hotfix.8, on Mac OS X 10.15.4 19E287, locale en-IN)
    • Flutter version 1.12.13+hotfix.8 at /Users/imac/Development/flutter
    • Framework revision 0b8abb4724 (4 months ago), 2020-02-11 11:44:36 -0800
    • Engine revision e1e6ced81d
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/imac/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.45.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (1 available)
    • iPhone SE (2nd generation) • 8A98002E-B189-4353-9192-A243F0DED18E • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator)

• No issues found!

Pod file
platform :ios, '9.0'

target 'Runner' do
  \# Comment the next line if you don't want to use dynamic frameworks
  use_frameworks!

  \# Pods for Runner

end

ERROR:
Running Xcode build...
Xcode build done.                                           11.2s
Failed to build iOS app
Error output from Xcode build:
↳
    ** BUILD FAILED **

Xcode's output:
↳
    === BUILD TARGET Runner OF PROJECT Runner WITH CONFIGURATION Debug ===
    /Users/imac/Development/flutter-projects/catalog-share/ios/Runner/GeneratedPluginRegistrant.m:10:9: fatal error: module 'connectivity' not found
    @import connectivity;
     ~~~~~~~^~~~~~~~~~~~
    1 error generated.

Could not build the application for the simulator.
Error launching application on iPhone SE (2nd generation).```

Hi @AdnanKazi
Could you please run flutter upgrade --force.
If the issue persists, please provide your updated flutter doctor -v,
your flutter run --verbose,
your pubspec.yaml
and a minimal reproducible code sample.
Thank you

Thank you @iapicca for instant response but i found that was the problem of pod install now it doesn't show error but on ios it stuck on splash screen I mean after than no logs ver performing.
Please Can you tell me how is this possible ?
flutter doctor -v
    • Flutter version 1.17.3 at /Users/imac/Development/flutter
    • Framework revision b041144f83 (2 days ago), 2020-06-04 09:26:11 -0700
    • Engine revision ee76268252
    • Dart version 2.8.4

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/imac/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.45.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (1 available)
    • iPhone SE (2nd generation) • 8A98002E-B189-4353-9192-A243F0DED18E • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator)

• No issues found!

pubspec.yaml
description: Catalog app for create your instant online shop.
version: 2.2.19+23

environment:
  sdk: ">=2.2.2 <3.0.0"

dependencies:
  flutter:
    sdk: flutter
  cupertino_icons: ^0.1.2
  http: ^0.12.0+4
  connectivity: 0.4.4+1
  flutter_svg: ^0.17.4
  multi_image_picker: ^4.6.1
  flutter_share_me: ^0.9.1
  shared_preferences: ^0.5.6+1
  device_info: ^0.4.1+4
  intl: ^0.16.1
  basic_utils: ^2.4.8
  image_picker:
  path: ^1.6.4
  dio: ^3.0.8
  qr_code_scanner: ^0.0.12
  firebase_messaging: ^6.0.9
  flutter_open_whatsapp: ^0.1.2
  razorpay_flutter: ^1.2.1
  flutter_webview_plugin: ^0.3.10+1
  url_launcher: ^5.4.1
  path_provider: ^1.6.0
  google_sign_in: ^4.1.1
  pull_to_refresh: ^1.5.8
  flutter_facebook_login: ^3.0.0
  printing: ^3.4.0
  pdf: ^1.8.1
  share_extend: ^1.1.6
  flutter_html_to_pdf: ^0.5.2

dev_dependencies:
  flutter_test:
    sdk: flutter

flutter:
  uses-material-design: true
  assets:
    - assets/images/
    - assets/svg/
  fonts:
   - family: Montserrat
     fonts:
       - asset: fonts/Montserrat/Montserrat-Medium.ttf
       - asset: fonts/Montserrat/Montserrat-MediumItalic.ttf
       - asset: fonts/Montserrat/Montserrat-Regular.ttf
       - asset: fonts/Montserrat/Montserrat-SemiBold.ttf

flutter run --verbose
log.txt

Hi @AdnanKazi
your logs don't show any error and according to your description
the issue seems to occur at runtime, to be certain that
it depends from flutter and not from the implementation or a plugin
the issue has to be reproducible;
could you please provide a minimal reproducible code sample
that does not use 3rd party plugins
Thank you

@iapicca Actually problem was in my coding as i was developing only for android so there was plugin connectivity which was generating realtime exception i have updated that plugin and also update code according to platform depended hence it solved my problem and application working perfectly


Drop component support

Fixed in https://github.com/shinnn/is-string-int.js/commit/5779b9bd17a0b95c1a8ab88d17e2350710e15df2.


Script to deploy a new cluster from scratch.

This is a Haskell-based script for deploying a new Cardano SL cluster on cardano-deployer server.

Thanks! https://github.com/input-output-hk/iohk-nixops/pull/47 will automate some part of this to make it simpler. Next sprint will include DEVOPS-22 so we can commit config.yaml in iohk-nixops repo.
The idea was to use https://github.com/input-output-hk/iohk-nixops/blob/master/CardanoCSL.hs to automate any deployment logic around provisioning clusters, I don't think we should duplicate this work :)
My suggestion is to wait ~week for devops to automate deployment parts and then we can revisit documentation and provisioning of a fresh cluster :) This is also tracked in DEVOPS-100

Thanks! I'll revisit this after https://github.com/input-output-hk/iohk-nixops/pull/47 is done as it will be simpler for all of us :)


[SPARK-46863][DOCS] Cleanup custom CSS

What changes were proposed in this pull request?

Remove rules for the following classes that we do not use:

.code (We use code elements, but not a code class.)
.code-tab (We do have a codetabs class, however.)
.jumbotron (No idea where this came from, but we don't use it.)

Remove some superfluous comments.
Using css-purge, merge rules for the same selectors that were previously scattered across several blocks, and remove overridden rules.
Format the whole file with VS Code. This makes the spacing consistent, and puts each selector on its own line.

Why are the changes needed?
It's very difficult to make improvements to the presentation of the documentation due to the noise in this CSS file. This change will facilitate future improvements to the documentation.
Does this PR introduce any user-facing change?
No, it shouldn't. This change should be functionally neutral.
How was this patch tested?
I built the docs and manually reviewed them. Code blocks and tables look the same to me.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @gengliangwang and @grundprinzip.
I am trying to fix how code and text inside tables wrap, but I found it very difficult to do due to a few problems in custom.css. This PR makes an initial round of cleanup.
In a future PR, I intend to reduce our use of the .global class selector, which is very invasive due to its specificity, and makes it harder to define simple styling rules for tables.

Thanks, merged to master


My email is not my identity

For a number of reasons (primarily spam related), my email address is different for every single service that I use. Many people use plus-addressing for this purpose - I happen to own a domain and just use identifiers before the @. This protocol assumes that I want to share a single email with every service that uses it. Facebook login and other systems will give me an option to not provide an email. When that option is not there, I choose not to login with FB / Google.

In the end any service will still require an email. You either give it on first request, or you type it manually again.
In that case you can always create a profile with fake email address.
Would a check box "dont share my email" be enough?

You could put the email into an "advisory information" section of the profile. The public key is the identifying part of the profile, so that should be the only required piece of information in the profile.
Anything else could be in the set of "suggested" fields which you can decide to fill in or not depending on the use of the profile.
Say you want an anonymous profile. Just create one and start using it. If you want to make a public profile then create one, and then type your public info into the advisory fields so your client can send them to services when logging in with that profile.
Though with the public key being the identifier it might be good to use a more human-recognizable signature of the public key. For example a generated name or avatar.

That wouldn't work, though, because then the public key would depend solely on the master password, meaning that two people who came up with the same password would have a collision. You can't expect users to have unique passwords.

If it's not a unique password then it's probably not strong enough to be used as the securing mechanism for all your accounts in the first place. As it is the email is essentially a (probably publicly known) salt.
This actually brings up something else I had a concern about. The master password needs to contain enough entropy to be unguessable while also being user-friendly enough that it can be manually transferred to different devices by a human that may not know much about information security.
Having randomly generated device-local keys that mutually sign when you sync your devices sounds like a better idea to me. It would take a lot more of the responsibility for securing key material out of users hands, plus you could individually revoke device keys instead of having to create all new accounts if your phone was stolen. Example.

That sounds like an entirely different protocol.
Also see #21 on the subject of stolen phones.

If it's not a unique password then it's probably not strong enough to be used as the securing mechanism for all your accounts in the first place.

Have you seen the amount of crossover in passwords between data breaches? It's pretty massive.

As it is the email is essentially a (probably publicly known) salt.

Nope. You could guess my email for a service, but it would be a guess not a known fact. If a spammer guesses I delete that address and change the email with affected services.

The public key is the identifying part of the profile, so that should be the only required piece of information in the profile.

It seems that you're saying that if I know who a user is because I run service A, I can potentially see whether that user uses service B? (either directly enumerated or through a data breach).

That wouldn't work, though, because then the public key would depend solely on the master password, meaning that two people who came up with the same password would have a collision.

No, key = scrypt(email + pw) not just scrypt(pw).

@homakov

the public key would depend solely on the master password

We were talking about the possibility of making email optional and why it wouldn't work. If two users come up with the same password and choose not to enter an email, their accounts would collide.

There are two ways email is used in the system:

as a salt for creating root hash. This is required.

as a suggested email value for websites. We can easily drop it so website won't have it BUT in the end most services will still require to type it anyway, because they love sending "news" about your account.

this is how we can go about it: you can edit email if you want but it's required to set something

So in this case the email acts simultaneously as an account label, a password salt, and an advisory contact point?

Yes, profile label for dropdown list, pw salt and currently sent by default as contact

Another part of this then is what happens when I wish to change my email address that I've originally chosen as the pw salt. This is not specifically relevant in my case as I own the domain. Often normal users however change their primary email when the move between ISPs, graduate from their university, change jobs, or decide that<EMAIL_ADDRESS>doesn't represent their identity anymore.
While I can understand that using an email that you no longer as an identity should continue to work, why should a user be forced to do so?

@joshka You can theoretically change your email using the same process as the password:
https://github.com/sakurity/securelogin/wiki/How-password-is-changed
Judging by the example code there, services identify you by your public key and save the new key when you change the password. If you change email, the same thing would happen, so I guess the protocol already supports it.

Alright, now user can set new email (as salt and label) when they change password. This email will also be broadcasted inside of new_sltoken to all /securelogin endpoints so they can change email on their part too.

Reading http://gizmodo.com/gop-data-firm-accidentally-leaks-personal-details-of-ne-1796211612?rev=1497877260890 just now, I'm not sure I want any ability for sites to be able to know that I am a single identity let alone an email address.

We can generate app specific public keys and allow user to change email (see above) or entirely hide with checkbox.
Which one works for you?

Site-specific public keys would have annoying edge cases. I presume you'd use the domain name as additional data from which to generate the key. What if the domain changes? Even www.github.com to github.com.

Yea, there will always be edge cases here so I don't really like site-specific public keys. If you leave the subdomain, dashboard.myapp.com would be different than myapp.com. If you exclude the subdomain, there would be no difference between app1.herokuapp.com and app2.herokuapp.com making it mostly useless.

It would not be fatal (provider can be set by site, but client is forced by Origin header) but would be more ugly.
I just don't understand what people ask for: do they want to hide or modify email and why simply creating a profile with<EMAIL_ADDRESS>is not an option?

Profiles allow full compartmentation. E.g. you can use profile1 in host machine, profile2 on a virtual machine etc. Simply mimicking privacy with unique pubkeys and no emails is not long term solution. Web is full of trackers: if you use two apps in one browser it's safe to assume they can figure out the link. That's what you need to tell users to start with.

@homakov forspam is not an option. And it's not spam.
How many of your emails appear in the haveibeenpwned database? Can you track the reason why?
Not sure if profiles would work, will think about the approach on the weekend

Just tell me which way suits you. Editing email? I'm fine with adding it transparently.

I'm closing this down because we didn't figure out what exactly people want. If they want privacy, just create a profile with throwaway email. If you don't want to provide any email, just use fake mailinator. No one requires you to use your real one.


bug: CoreContainer is not rendering

Describe the bug
CoreContainer is not rendering.
I have added the below code in one of my component and it is not rendering.
<CoreContainer>hello</CoreContainer>

To Reproduce
Steps to reproduce the behavior:
Use <CoreContainer>hello</CoreContainer> anywhere.
Expected behavior
CoreContainer should render.
Stack Trace
Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

Check the render method of `CoreContainer`.
Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

Check the render method of `CoreContainer`.
    at createFiberFromTypeAndProps (http://localhost:3000/static/js/bundle.js:296313:21)
    at createFiberFromElement (http://localhost:3000/static/js/bundle.js:296334:19)
    at reconcileSingleElement (http://localhost:3000/static/js/bundle.js:285433:27)
    at reconcileChildFibers (http://localhost:3000/static/js/bundle.js:285483:39)
    at reconcileChildren (http://localhost:3000/static/js/bundle.js:288422:32)
    at mountIndeterminateComponent (http://localhost:3000/static/js/bundle.js:289259:9)
    at beginWork (http://localhost:3000/static/js/bundle.js:290487:20)
    at HTMLUnknownElement.callCallback (http://localhost:3000/static/js/bundle.js:275503:18)
    at Object.invokeGuardedCallbackDev (http://localhost:3000/static/js/bundle.js:275547:20)
    at invokeGuardedCallback (http://localhost:3000/static/js/bundle.js:275604:35)

This issue was resolved in Native-web and Native-mobile.

resolved this issue


Added span node to Tooltips with 'Hidden' children.

@aymanhab This should take care of the Jest errors and fix the misplaced elements in the AppBar.
The first error was the tooltips having non referenceable elements as children, which throws a warning; and the second error related to test of the AppBar failing because we changed text buttons to icons in the bar and the test was looking for text buttons.


Current release is incompatible with Django >= 1.7; fixed in master

django-otp only gained native Django migrations in version 0.3.0. The tag for 0.3.0 directly follows the commit that added native Django migrations to all apps.
https://bitbucket.org/psagers/django-otp/commits/01fe986b9fc23b136e92c798502c763e7e3a835d
https://bitbucket.org/psagers/django-otp/commits/cf6cd0b34451bfcd64956b008cca8d412e9d2c06
The current release of django-two-factor-auth is 1.2.1. It depends on django-otp>=0.2.0,<0.2.99. So pip install django-two-factor-auth installs django-otp==0.2.7. This makes it impossible to use Django >= 1.7 because the 'otp_static.StaticDevice' model has a foreign key to the AUTH_USER_MODEL and no native Django migrations.
Indeed, Django doesn't allow models without migrations to depend on models with migrations, because the backwards compatibility layer starts by creating all models without migrations and then migrates those with migrations.
In practice we get the following error when trying to run our tests:
ALTER TABLE "otp_static_staticdevice" ADD CONSTRAINT "otp_static_staticdevi_user_id_107aea364f0973a5_fk_users_user_id" FOREIGN KEY ("user_id") REFERENCES "users_user" ("id") DEFERRABLE INITIALLY DEFERRED

psycopg2.ProgrammingError: relation "users_user" does not exist

(We have AUTH_USER_MODEL = "users.User".)
This was fixed in master six weeks ago. It would be very helpful if you could push a release to PyPI. (We manage our dependencies with pip-tools, which makes it inconvenient to pin git commits of libraries which have dependencies.)

Thanks for the report. Sadly some changes in Django are preventing releasing from master, as demonstrated by the failing tests. I've released a patch (1.2.2) in the interim.

Thank you very much!


Update BUMP input/output

Companion PR of https://github.com/JCSDA-internal/saber/pull/154, see this PR for details.

Not ready yet.

Replaced by the feature/bumpinputparams branch for SABER, no need for companion PRs anymore.


fix misspelling of "target" in docstrings

"target" is misspelled as "targe" in multiple docstrings in the project. Fix this misspelling.

Thank you for this contribution @dmjb!
Unfortunately, the locations of these typos are in generated code, so unless they are fixed in their specification documents next time this is regenerated the typos will reappear.
@kasobol-msft, @amishra-dev could you propagate these fixes into the Swagger definitions.

https://github.com/Azure/azure-rest-api-specs/pull/14081
This will be picked up by next generation.
@gapra-msft  FYI


Not running in 120hz on Oneplus 9 pro

Gave the app a try but it doesn't seem to push the 120fps and feels quite sluggish compared to my other apps.

Thanks for the report! Can you try branch feature-request-max-fps and see if it's better?

@esDotDev Can probably try it during the weekend, I am 99% sure this will work though. Have had to do the same change myself to get 120fps support.

Ok, we'll merge this into the main app since it seems like a good practice anyways. Please let us know how it goes!


If you insert into two or more images of multiple sheets, the images will be pasted in duplicate.

Create a new Excel file, insert an image into one cell of one sheet, create another sheet, insert another image into one cell of another sheet, as the result, causes a event that pasted two images on both cells of both sheets.
It doesn't occur when you finish inserted an image into one cell of a sheet, or inserted images into two or more cells of the same sheet.
func main () {
    xlsx: = excelize.NewFile ()
    // Create a worksheet
    index: = xlsx.NewSheet ("Sheet2")
    // Insert image1.jpg into A2 cell of sheet 1
    // Still okay at this point
    err: = xlsx.AddPicture ("Sheet1", "A2", "./image1.jpg", "")
    if err! = nil {
        fmt.Println (err)
        return err
    }
    // Insert image2.jpg into A20 cell of sheet 2
    // If this is executed, image1.jpg is pasted A2 cells of Sheet 1 and Sheet 2
    // and image2.jpg is pasted A20 cells of Sheet 1 and Sheet 2.
    err: = xlsx.AddPicture ("Sheet2", "A20", "./image2.jpg", "")
    if err! = nil {
        fmt.Println (err)
        return err
    }
   // Save Excel
   err: = xlsx.SaveAs ("./Book1.xlsx")
   if err! = nil {
        fmt.Println (err)
        return err
    }
    return nil
}

When I extracted the Excel file and saw it, the value of the name held inside of drawing1.xml was the same (Picture 1), so it is considered to be due to that.
If SaveAS is executed first and then reopened and the image is executed only after Save is executed, the stored information will disappear or it will operate normally.
Of course, there is no problem if you insert image1.jpg into one cell of one sheet, execute SaveAS, reopen it, and insert image2.jpg into another cell of another sheet.
func main () {
    xlsx: = excelize.NewFile ()
    // Create a worksheet
    index: = xlsx.NewSheet ("Sheet2")
    // Save Excel
    err: = xlsx.SaveAs ("./Book1.xlsx")
    if err! = nil {
        fmt.Println (err)
        return err
    }
    // Reopen
    xlsx, err: = excelize.OpenFile ("./Book1.xlsx")
    if err! = nil {
         fmt.Println (err)
         return err
    }
    // Insert image1.jpg into A2 cell of sheet 1
    err: = xlsx.AddPicture ("Sheet1", "A2", "./image1.jpg", "")
    if err! = nil {
        fmt.Println (err)
        return err
    }
    // Save Excel
    err: = xlsx.Save ()
    if err! = nil {
        fmt.Println (err)
        return err
    }
    // Insert image2.jpg into A20 cell of sheet 2
    err: = xlsx.AddPicture ("Sheet2", "A20", "./image2.jpg", "")
    if err! = nil {
        fmt.Println (err)
        return err
    }
    // Save Excel
    err: = xlsx.Save ()
    if err! = nil {
        fmt.Println (err)
        return err
    }
    return nil
}

When this is executed, Book1.xlsx is generated in which image1.jpg is inserted into only A2 cell of sheet 1 and image2.jpg is inserted into only A20 cell of sheet 2.

Hi @GinSanaduki, thanks for your issue. I have tested based on your code and it works well. Which version of Excelize and Go are you using?

Hi @GinSanaduki, thanks for your issue. I have tested based on your code and it works well. Which version of Excelize and Go are you using?

Hi @xurl, Thanks for the reply.
The excelize library, which I downloaded March 21, 2019, is one version before the latest commit.
When I tried with 2 windows 10, the same phenomenon occurred.
go version go1.12.1 windows/amd64

Hi @GinSanaduki, thanks for your issue. I have tested based on your code and it works well. Which version of Excelize and Go are you using?

Hi @xuri , thanks for the reply.
The excelize library, which I downloaded March 21, 2019, is one version before the latest commit.
When I tried with 2 windows 10, the same phenomenon occurred.
go version go1.12.1 windows/amd64
I know what to do here for the time being, so if you don't reproduce it, let me wait and see please.
Thank you for confirmation.

I see something similar with comments on 69b38ddcd6:
package main

import "github.com/360EntSecGroup-Skylar/excelize"

func main() {
	xlsx := excelize.NewFile()
	xlsx.NewSheet("Sheet2")

	err := xlsx.AddComment("Sheet1", "A1", `{"author":"Me:","text":"Comment"}`)
	if err != nil {
		panic(err)
	}

	err = xlsx.AddComment("Sheet2", "A2", `{"author":"Me:","text":"Comment"}`)
	if err != nil {
		panic(err)
	}

	err = xlsx.SaveAs("./Test.xlsx")
	if err != nil {
		panic(err)
	}
}

Sheet1:

Sheet2:

I did not know that the same event would occur even with the addition of comments...thank you for providing the information.

Hi @nateglims @GinSanaduki,  I have fixed it, but the issues of duplicate images haven't been confirmed yet.

Just in case, I put the reproduction file of those days.
Book1.xlsx

It did not occur with modified sources.
Book1.xlsx


Nested projects result in Atom opening files in wrong project window

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
A project which contains another project within a subdirectory can result in files being opened in the incorrect project window.
Given a main project at /project, and another project at /project/subproject. Upon opening a file from Finder, Atom doesn't open the file in the correct project window if one of the other project windows is already open.
This can result in a file at /project/subproject/file.txt being opened in the /project project window.
Steps to Reproduce

Open a new window in Atom, and add a directory as a project folder.
Repeat this step, adding a directory which is a subdirectory of the first.
Close the second project window.
In macOS Finder, open a file which lives in the subdirectory.

Expected behavior:
Atom opens the project window for the subdirectory project and opens the file.
Actual behavior:
Atom opens the file in the existing project window for the root directory project.
Reproduces how often:
Every time.
Versions
Atom    : 1.19.0
Electron: 1.6.9
Chrome  : 56.0.2924.87
Node    : 7.4.0
OS      : macOS 10.12.3
Additional Information
Note that if you already have both project windows open, the problem does not appear to occur.

Thanks for the report!  So though I can reproduce with your steps, I'm not sure it's related to the nested projects?  E.g. if I have I have some project open (and the project root isn't the parent of the project in your step 2) and then continue on with your steps to reproduce, Atom will open the file in the currently open project whatever it is.
If I have no windows open or I have a window open with no project, then if open the file in the subdirectory from Finder (your step 4), it will open the project at the subdirectory.

Ah you're correct, this bug doesn't rely on nested projects. Any file that you open will open in the currently open project window if its own project isn't open.
Is this expected behaviour?

Is this expected behaviour?

I feel like it is (or at least the behavior hasn't changed as of 1.19.0) but I'll double check with the other maintainers.

@johnbillion - so it looks like it's expected behavior but understandably can be unexpected for some folks.  For now we'll close this in favor of https://github.com/atom/atom/issues/10517 which is a high level issue about Atom's startup story.


Whether the calculated Rt is differentiable

Hello, I observed on your code that when Rt is calculated according to the point correspondence, it is solved by SVD. But is the loss obtained in this way derivable?

https://github.com/mbanani/unsupervisedRR/blob/4ba5b1cc76080f5c6fd99cec155453f43b547bcd/unsupervisedRR/models/alignment.py#L127

Hi @linxcan,
PyTorch's implementation of SVD is differentiable, as seen here, allowing us to define losses using the estimated Rt and back propagating the loss to the features.

Thanks for your response!


Add endpoint to give me a list of mock transactions

Since #30 will take some more time, give me a list of mock transactions please :)
Example: https://github.com/cstenglein/raspiblitz-web/blob/master/backend-mock/transactions.js
Don't know if these fields are fine, will adapt to your solution :+1:

Working on actually implementing #30 soon. Groundwork is done. Should be ready in a few days.


Improvements to frames in CameraGeometry

With the introduction of the EngineeringCameraFrame, the CameraGeoemetry also gained a frame attribute describing the the frame in which the pixel coordinates are defined.
However, a few things could be improved:

[ ] define the frame in the geometry fits files
[ ] allow transformation into TelescopeFrame or even all other frames
[ ] Make CameraDisplay work with CameraGeometry in TelescopeFrame, see #1186

This is also related probably to #1090, as it would be easy to do, by just transforming the CameraGeometry into TelescopeFrame and then passing to hillas_parameters.

Note that CameraDisplay and other displays could also have a frame attribute, and should convert the given geometry and parameters as needed

I have a conceptional problem here, or a problem of understanding ... or so.
TL;DR: I think (and might be wrong) our world would be better, if CameraGeometry and OpticsDescription were merged into TelescopeDescription and were hard to split apart.
My problem goes like this:
1.) CameraGeometry has a frame, by default it is None, but when needed it is actually CameraFrame().
2.) CameraFrame can get a bunch of parameters to initialize itself, and I do not really understand which of them are needed and which are optional. Apparently all are optional, but if one ever wants to transform into a TelescopeFrame then at least focal_length must not be zero (which happens to be its default, and it is the only sensible default, if you do not know anything better, I think).
3.) coming back to the default frame of CameraGeometry, which is CameraFrame(with focal_length=0).  I think CameraFrame is a useful default, but more so, if one would know the focal_length at the time, when a default frame is needed. But the focal_length is stored in CameraGeometrys sister structure OpticsDescription.
In my understanding these structures are "sisters" since the live together in the same house, called TelescopeDescription. For all intends and purposes every user who needs to get access to a CameraGeometry, the user will get it from the enclosing TelescopeDescription. Some people have seen free living CameraGeometries in the wild, but only under very rare circumstances, like examples or so.
The reason for having only CameraGeometries in examples and not complete TelescopeDescriptions, in my understanding is convenience, it is easy to write:
geom = CameraGeometry.from_name("LSTCam")

and it is harder to write:
tel_des = TelescopeDescription.from_name("LST", "LSTCam")

since one needs to remember, two arbitrary strings (was it cam or Cam??) and the order of the strings.
But honestly, do we still need this? Is it still useful to be able to write?
tel_des = TelescopeDescription.from_name("SST-1M", "LSTCam")

I mean ... of course ... there are other ways to fix my issue, without merging these structures, which have been divided since the beginning, but to me it really feels strange, when I am inside a function and I have access to the instrument description ... but only part of it... the focal length is missing.

Anyway, I tried to think of a different way of fixing my problem, which is "how to transform a CameraGeometry (which is given in a CameraFrame) convenientry into a TeleskopeFrame?"
And I think Max gave the answer in his top post, since he wrote "define the frame in the geometry fits files". I might get him wrong here, but I assume, this means: do not set frame=None, but provide the correct CameraFrame during construction of the CameraGeometry. Now if we did this, then we needed to specify the focal_length (which is a member of OpticsDescription) during construction of any CameraGeometry and ultimately we would store the same information in two different places, but we cannot do that, it violates DRY.

do not set frame=None, but provide the correct CameraFrame during construction of the CameraGeometry.

Yes!

CameraFrame can get a bunch of parameters to initialize itself, and I do not really understand which of them are needed and which are optional. Apparently all are optional, but if one ever wants to transform into a TelescopeFrame then at least focal_length must not be zero (which happens to be its default, and it is the only sensible default, if you do not know anything better, I think).

This is a bit unfortunate, but I think necessary for two reasons.
First: CameraFrame needs all these attrinutes to really be a SkyCoord, meaning it identifies a fixed position in the sky. This is only possible when location, obstime, focal_length and pointing_direction are set.
Second: we have situations where we need to deal with conversion from CameraFrame to AltAz but don't have sensible obstimes (mcs) so always requiring them to be set is also not possible.
The semantics are: if something is not set, assume it is the same for both frames!
Astropy would allow us to transform a CamereCoordinate at obstime1, location1, ... to a CameraFrame
at obstime2, location2, .....
Basically answering the question: "Where would object X that was at obstime1 visible at camera coordinates x, y in telescope 1 be at obstime2 in the camera of telescope2."
That's very powerful, but seldomly needed here. We mostly need transformations from Camera to Telescope to AltAz for the same obstime, location, ... and such don't set them and jsut assume they are the same.

Right .. thanks!
sorry for the wall of text, let me try to rephrase:

CameraGeometry knows nothing about a focal_length, but OpticsDescription does.
for a useful CameraFrame construction, we need to store focal_length in CameraGeometry.

--> I think this "forces" us to merge CameraGeometry & OpticsDescription due to DRY principles.
Do you agree Max?

For me, it's just that we pass info to the coordinate transforms in the wrong order.  CameraFrame should not require any attriubutes (focal len, etc).  It's purely meters on the camera, and should work fine.  When you want to go to the TelescopeFrame, the telescope has a focal length, and should be an attribute of that frame (not something you add to CameraFrame, since the camera does not have a focal length!).  You can put the same camera on 2 telescopes with different focal lengths.
see this comment on #231:  https://github.com/cta-observatory/ctapipe/issues/416#issuecomment-303441757

To be more clear: CameraGeometry, hillas parameterization, etc, should all work fine without knowing anything about the telescope, even if you start to analyze data that is taken in the lab (which we will do ), where there is no telescope.

If an algorithm needs the focal length, it should receive a TelescopeDescription, not just a CameraGeometry.

For me, it's just that we pass info to the coordinate transforms in the wrong order. CameraFrame should not require any attributes (focal len, etc). It's purely meters on the camera, and should work fine. When you want to go to the TelescopeFrame, the telescope has a focal length

That's not how this works!
To be a valid coordinate, a frame needs all the information so it really represents a fixed coordinate in the sky.
So for a coordinate in x,y in the camera, you need the telescopes focal length, it's position and pointing position and the time.
So a CameraFrame needs to be able to store all those attributes.

Is that a requirement of SkyCoord? Or just the way we are using it?

A coordinate in CameraFrame is not a SkyCoord in any semantical way if this does not hold true and you will not be able to do direct transformations from camera_frame or telescope_frame to ICRS if this is not the case.
Right now, we can go from CameraFrame to ICRS directly. If we remove focal_length and pointing_position attribute from the CameraFrame, each intermediate step would have to be done explicitly and each intermediate frame would have to be instantiated with its respective metadata.

Ok, I see the problem then - it is a but unintuitive.
Still I'd prefer not merging Camera and Telescope objects.  We could put the frame in the TelescopeDescription, perhaps?

I guess that means we also have a temperature and pressure attribute of CameraFrame? (since those can be used by the transform from Alt/Az to Ra/Dec for refraction?). I.e. all attributes of frames between it and ICRS are inherited?

No at the moment we don't have that.
To do that, you would need to transform to an intermediate AltAz having those attributes set and then to ICRS.
But refraction corrections are on the order of mas, are they not?

We could put the frame in the TelescopeDescription, perhaps?

This is functionally what I was asking for, no? If we merge the two constituents of TD into one another, or attach the frame to the TelDes ... results in the same, no? Every decent function, will from then moment on ask for a TelDes instead of a CamGeom, if it ever wants to be able to be used within a different frame, no?
the next thing, which will happen ... people will ask for convenience properties, since teldes.camera.pix_x is longer than teldes.pix_x. The next might be .. people realize that in virtually all cases where a TelDes is being constructed ... first both its constituents need to be made, and then combined into a TelDes .. so they might ask for a convenient init to do all in one.... but maybe I am wrong here.

You can put the same camera on 2 telescopes with different focal lengths.

Yes, that is true. I think we are all aware of the reasoning behind the current implementation. I did not mean to invalidate that reasoning. I was merely trying to ask, if there are other arguments, which might weigh heavier, which might point towards a functional merging of ImageSensorGeometry and OpticsDescription into a true CameraDescription.
It is true, that people in the lab, will want to try their image sensors without a lens ... or mirror, but does it really hurt them if the description object contains additional information, which allowed them to transform their image from the EngineeringFrame into a TelescopeFrame and see how the image would look, had they mounted their sensor on a telescope, and had pointed it somewhere? I think it hardly hurts, but it sounds very useful to me...

If we merge the two constituents of TD into one another
Why merge them? TelescopeDescription is exactly that! It's a merge of the optics and camera. There may be other things added later - if we put them all in one class, it will grow to something unusable.

teldes.camera.pix_x I think is pretty clear, as is teldes.optics.mirror_facet_x (or similar). Rememebr taht eventually this will be used to define MC simulations, so it will grow into a fairly complex class. It may also have teldes.drive.x.  We could shorten some things, like go for teldes.camera.x rather than pix_x, but it's not super clear that that is not the x-position of the camera, rather than each pixel.

One more thing: we are also forgetting astrometric corrections, which are an input to the coordinate transformations as well. Those are clearly a function of the telescope optics (not the camera), drives, etc.   So the question is, is it ok to have some attributes of a Frame not filled in until they are known? I think yes, since there are many cases where you want to only work at a low level (like parameterization), or where you don't need light-bending corrections, or astrometric corrections.
Of course, one could say those are optional attributes, whereas focal length is require.  Anyhow, I think the semantic problem could just be solved by giving the Display a TelescopeDescription.

I think the semantic problem could just be solved by giving the Display a TelescopeDescription.

I do agree ... if we also move the frame from the the ImageSensorDescription to the TelescopeDescription, right?

Now that I think about it, we need to have a way to nicely define the CameraFrame and later set the focal_length and poiting_position attributes.

see: https://docs.astropy.org/en/stable/coordinates/inplace.html

I do agree ... if we also move the frame from the the ImageSensorDescription to the TelescopeDescription, right?

Yes.  Of course, if instead we keep the frame in CameraGeometry, we should just go all in and store the pix_x/y coordinates as SkyCoords.

That concerns mutating the data, not the attached frame. For that:
c = c.replicate(obstime=t, location=lp)

Does not copy the data but updates the properties of the frame

I am lost.

I think this was finally implemented by a series of PRs,

#1476
#1407


Project on hold

I'm currently going through some personal issues, and I haven't been able to work on this project since the last version. It looks like this is going to be long term, so I'm just letting everyone know that I don't know when this project will be updated and to what extent. Thanks for understanding.

Thanks for letting us know and best of luck with everything!

Thanks again for letting us know. I think once per month (or even just as needed) is perfectly reasonable. The main thing is take care of your personal life and don't let this project start feeling like a chore otherwise you'll just want to stop completely. And that would be a shame because it's definitely the best overall app of its kind and worth maintaining.


Title

Song Name
Rush e
Artist Name
Mike
Source
Direct file download
Youtube Link
No response
Direct File Link
No response
Song ID
1216798
Extra
No response

No audio link given..


Thanks and provide some suggestions about this project

About three years ago, when I am a newbie of C/C++, I wrote an e-mail to @wj32 for asking the permission of using the phnt lib because it contains plenty of NT APIs and it looks fashion.

Dear wj32
I find the phnt lib when I was searching for information about Native API a few days ago.
I modify it and want to add it into my open source project which is distributed under The MIT License.
But the Process Hacker is distributed under the GNU GPL version 3. So I want to ask you for the permission.
I will add your permission text into the readme of my project
I am looking forward to hearing from you.
Yours,
Mouri

Here was his reply.

I'm not clear on the copyright status of API headers, but sorry I will not relicense such a big part of the project under MIT.
Nevertheless some say that headers cannot be copyrighted and have copied phnt verbatim anyway without asking me. So do what you will...

I'm very grateful to him. And made some modifications and create a repo at https://github.com/Chuyu-Team/NativeLib and distributed under the Public Domain because he said "So do what you will..." to me and it's a way for me to thank him.
All these years have passed. I am not crazy about the NT APIs any more. I have archived the work uses the NT APIs at https://github.com/M2Team/M2-SDK and rewritten my work with the documented APIs.
But I have found the repo recently, and I am happy to know this repo. I want to provide some suggestions to the owner. That's what my modified version does.

Please provide the version which the header files are amalgamated. I don't like include plenty of headers. You can read https://github.com/nlohmann/json/tree/develop/third_party/amalgamate and may get some help.
Use definitions in SDKDDKVer.h instead of something like PHNT_WIN2K.
Compatible with /W4 /WX.

I hope my advice will be adopted.
Mouri

he said "So do what you will..." to me and it's a way for me to thank him.

That's a figure of speech in english that means you do not consent? 🤔

Please provide the version which the header files are amalgamated.

I can understand version numbers in a desktop program but not so much for header files. Can you give me a decent use case for version numbers in header files?

I don't like include plenty of headers.

You only need to include two headers per the documentation? If you're including more than these two headers then you're not using this repository correctly:
#include <phnt_windows.h>
#include <phnt.h>

Use definitions in SDKDDKVer.h instead of something like PHNT_WIN2K.

The problem with using SDK versioning is that we introduce a dependency on Microsoft updating the  SDK versioning (which isn't always reliable) and we won't ever be able to add definitions for insider builds of Windows until after a new SDK is released (which Microsoft doesn't update for insider builds).

Compatible with /W4 /WX.

No. I can guarantee /W3 (production quality) which is the default. If someone wants to manually enable /W4 for their project then it's assumed they require/need informational warnings and it would be counter intuitive disabling those warnings and overriding their configuration.

@dmex
I understand all except the following things:

That's a figure of speech in english that means you do not consent?

I don't know what your meaning because I am not good at English and wj32's reply is read by my friend which is good at English and translate to me.
I can write an English letter easily but not good at to understand the reply. Although I can understand some of the replies now. If I misunderstood his mean( I think his mean is that I can do any thing like other people who is not ask him for the permission, so I think he is a good man and express my gratitude. ), I will feel very sorry.

You only need to include two headers per the documentation?

I think you misunderstood my mean. I mean I don't want to include plenty of headers in the repository.
Mouri.

wj32's reply is read by my friend which is good at English and translate to me.

I figured that was the case.

I don' want to include plenty of headers in the repository.

You can add this repository as a git sub module so you don't have to copy files?

@dmex

You can add this repository as a git sub module so you don't have to copy files?

Also, I have some new ideas.

How do you think about separating the PHNT's definitions of Kernel Mode from User Mode?
"ntzwapi.h" should be improved. We can set the target OS version by PHNT macros but the content in "ntzwapi.h" is not under the management of PHNT macros.

Mouri


Add multi_tiff attribute for Bruker scans

Closing because I agree that we shouldn't store information specific to one acquisition software in the more general scan.ScanInfo table. This can be implemented more cleverly in the prairie_view_loader.py or differently in the field_processing.py modules