K8SPXC-1293: Fix hanging mysqlbinlog in case proxy protocol enabled

CHANGE DESCRIPTION
Problem:
mysqlbinlog hangs and collector deadlocks.
Cause:
In case proxy protocol enabled mysqlbinlog fails to connect to DB using port 3306. Collector creates a named piped with read only mode but it hangs forever because no one writes to it.
Solution:
mysqlbinlog needs to use port 33062.
CHECKLIST
Jira

[ ] Is the Jira ticket created and referenced properly?
[ ] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
[ ] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

[ ] Is an E2E test/test case added for the new feature/change?
[ ] Are unit tests added where appropriate?
[ ] Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

[ ] Are all needed new/changed options added to default YAML files?
[ ] Are the manifests (crd/bundle) regenerated if needed?
[ ] Did we add proper logging messages for operator actions?
[ ] Did we ensure compatibility with the previous version or cluster upgrade process?
[ ] Does the change support oldest and newest supported PXC version?
[ ] Does the change support oldest and newest supported Kubernetes version?

Test name
Status

We run 0 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1501/commits/ad58122b6e258fd8fd3e8abb8156621cd0f80368
image: perconalab/percona-xtradb-cluster-operator:PR-1501-v1.12.0-9-gad58122b

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
failure

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

pitr-gap-errors-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
failure

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
failure

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
failure

users-5-7
passed

users-8-0
passed

validation-hook-8-0
passed

We run 37 out of 37

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1501/commits/daedfb8ab4f74e8197afcf582ab878cf1316d69d
image: perconalab/percona-xtradb-cluster-operator:PR-1501-daedfb8a

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
failure

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

pitr-gap-errors-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
passed

users-8-0
passed

validation-hook-8-0
passed

We run 37 out of 37

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1501/commits/daedfb8ab4f74e8197afcf582ab878cf1316d69d
image: perconalab/percona-xtradb-cluster-operator:PR-1501-daedfb8a


Crash at startup

Crash log: https://pastebin.com/YnykVs06
VanillaFix <IP_ADDRESS>
Forge 2705
Rolling back to <IP_ADDRESS> fixes the crash.
Full mod list: https://pastebin.com/vFixUFy1

It seems to be incompatible with one of your other mods. Could you upload a full log?

Full crash log is there along with mod list.

No, I need the latest.log and debug.log files that are in your "logs" folder, inside your Minecraft folder.

https://www.dropbox.com/s/27fiosz04b2cvxq/logs.7z?dl=0

That's the wrong log. Minecraft doesn't seem to have crashed on the run those logs are from. Could you re-run Minecraft with 1.0.6 and then upload latest.log and debug.log?

Updated Forge and it no longer crashes.

I got the last Forge version, and it still crashes for me. https://pastebin.com/LD9hJUzP


Build failure on OpenBSD: ld: error: unable to find library -ldl

When running go test ., go install, or any other build step on OpenBSD:
# github.com/miekg/pkcs11
ld: error: unable to find library -ldl
cc: error: linker command failed with exit code 1 (use -v to see invocation)
FAIL    github.com/sigstore/fulcio/pkg/api [build failed]

This is due to two dependencies referencing an old buggy version of the https://github.com/miekg/pkcs11 library:

https://github.com/ThalesIgnite/crypto11 - fixed by https://github.com/ThalesIgnite/crypto11/pull/89
https://github.com/containers/ocicrypt - fixed by https://github.com/containers/ocicrypt/pull/56

https://github.com/miekg/pkcs11/pull/140 fixes the issue in the upstream, and is available in miekg/pkcs11 v1.1.0 or newer.

It seems like running go get<EMAIL_ADDRESS>successfully fixes this problem, so I will raise an appropriate PR for it.

Let's use this to also track adding a presubmit test somehow to make sure this still compiles!


Search results do not show right results and are different for VS and gallery

For example:

Search for "Xaml Behaviors" and the results the top result being a package that has very less download counts (popularity?)

Search for "aspnetcore". Top results show either a package with great download number but the term only in the tag (is it considered same as name/id for match?) OR contains packages that have very low download counts. In VS the result is very different.
NuGet gallery:

In VS we get different set of search result for the same term:

Not quite sure what its sorting by; isn't even a priority of release date as later ones (MS.ANC.Xxx) are more recent

The screenshot says "Sorted by relevance", whatever that means 😂

You should check "include prerelease" in VS and you will get the same results:

Regarding the bad sorting of results, it's related to this issue: https://github.com/NuGet/NuGetGallery/issues/3778
Can I close this issue?

@skofman1 missed that. May be we should have a checkbox for pre-release on gallery too?

If that's what the clients want..


Issue with custom action method

Hi, i have added "actions" (NgxGalleryAction) to the gallery and it works perfectly ( it shows icons on the top right corner and trigger my custom method ). But when I use "this" keyword within this custom method, it return "NgxGalleryAction" object. This means, i cannot use any variables / objects which are define outside of this method.
What is the solution for this ?

pls check this plunker https://plnkr.co/edit/S0AsmOzS4OoZ9RDRu2Xz?p=preview

yes... it worked 👍

Hi @lukasz-galka,
The example you provide work perfect for thumbnailActions, but when i use actions i get an undefined index. I need to get the link parameter of the image in order to go to an external url.
Can you help me
Thanks in advance

fixed in 5.5.1

How can I trigger a function when I clicked on the thumbnail??


Can xeditable be used with ng-form (nested forms)?

I've created a plunkr which contains a simplified version of the problem I'm facing. We generate a complex form which can show one or more child forms using ng-form.
I'd like to be able to make all elements editable, or ideally make elements in a single ng-form editable. I'm not sure if this is supported or if I'm just doing it wrong.
The plunkr shows two attempts to do this. Ideally, I'd like to be able to make the elements in individual ng-form's editable (as shown in the last example on the plunkr).
Would be happy to work on a pull request, but I might need to some help in getting started. But first and foremost, I'd like to get your thoughts on using ng-form :)

+1

+1

actually i have a different problem. as soon as i add ng-form, editable links stop working. almost as if editable was not registered on them.

+1

+1

+1

I might have a solution to this, but I'm not sure how to run the test suite for this repo. Can anyone help w/that please? Thanks!

@lalitkapoor It looks like those tests are using angular-scenario. That's been deprecated since I don't know when, but at least since 2013 when I started w/Angular.
Maybe you can add Karma to the project (literally and figuratively), I'm sure the repo owner wouldn't mind such a fix. I took a quick look at the tests, many of them were simply commented out :)

On the other hand, I did some poking around and managed to get something running by doing this:

Install grunt globally, if you haven't already: npm install -g grunt-cli
npm install in the project
grunt server
open a browser and navigate to: http://localhost:8000/test/e2e/dev-test.html

Hey, I did that locally as well against master, but they all seem to fail

@Painyjames Hi, this is out of the blue, but I noticed you have commit access to the repo and so I was wondering if you could help me get the tests running locally against master? Thanks

@vitalets @Painyjames ping!

@mitcht, could you take a look?

At 12 EST I will.

Hey @lalitkapoor can you share your solution in the meantime?
I'm not able to use xeditable form in an asp.net page due to the duplicated form tag. I believe using ngForm would do the trick!
Thanks!

@anaisamp you can take a look at this branch here: https://github.com/viewthespace/angular-xeditable/tree/use-xeditable-with-existing-forms

Thank you so much @lalitkapoor. Fingers crossed :)

@lalitkapoor if your change is working, can you create a pull request?

@lalitkapoor I tried making your changes from the commit you posted above, but the changes seem to break the editable form and row examples.
Is there a different commit that contains more changes?

@lalitkapoor your solution not working.
I`m kinda made xeditable to work with nested forms, but i dont have time to commit\pull, cause project where it used is currenty under heavy time schedule.

add e-form-nested="true" prop to editable element which linked to nested form (ex: div editable-form ng-form )
change line ( 1322 for me)  - if (ctrl[1]) { )  to if (ctrl[1] && !attrs.eFormNested) {
lastly you need to trigger submit event, in my case iv just added 'name-hook="rowform_{{rowIndex}}"' attr to div with ng-form, and added click event for pseudo submit button ( ng-click="submitRow(rowIndex)" ) , which just triggers submit $timeout(function(){  				angular.element(document.querySelector('[name-hook="rowform_'+i+'"]')).trigger('submit')  			})


feat: split_with_parser, split_with_scanner

I'm noticing some weirdness in the split_with_scanner example. Malformed tokens seem to be getting dropped:
assert_eq!(
    pg_query::split_with_scanner("select 1; asdf; select 3;").unwrap(),
    vec!["select 1", "asdf", "select 3"],
); // fails: actually produces ["select 1", "select 3"]

Is this expected?
Resolves #5.

I'm noticing some weirdness in the split_with_scanner example. Malformed tokens seem to be getting dropped:
assert_eq!(
    pg_query::split_with_scanner("select 1; asdf; select 3;").unwrap(),
    vec!["select 1", "asdf", "select 3"],
); // fails: actually produces ["select 1", "select 3"]

Is this expected?

Yup, that's expected, if the statement only contains invalid tokens, we skip it here:
https://github.com/pganalyze/libpg_query/blob/13-latest/src/pg_query_split.c#L113
We could change that behavior, its not something that anyone relies on today, to my knowledge. Would it be helpful for your use case?

Cool, I'll update my comment on the function.
I don't depend on that function, but I did have a use-case for split_with_scanner: I wanted to split the postgres regression tests into individual statements to build a SQL test corpus (skalt/sql_parser_tests). The problem was using split_with_scanner ended up mixing in psql meta-commands, so I bailed and wrote a nom parser that did what I wanted (skalt/pqsl_splitter).

Cool, I'll update my comment on the function. I don't depend on that function, but I did have a use-case for split_with_scanner: I wanted to split the postgres regression tests into individual statements to build a SQL test corpus (skalt/sql_parser_tests). The problem was using split_with_scanner ended up mixing in psql meta-commands, so I bailed and wrote a nom parser that did what I wanted (skalt/pqsl_splitter).

Great, and neat idea!
I'll leave the Rust code review to @seanlinsley, since he's been maintaining most of the library, but looks good from a quick glance :)

First-time contributors need a maintainer to approve running workflows

@seanlinsley would you be willing to approve workflows on this PR so we're all looking at the same unit test output?

Thanks for submitting this PR @SKalt!


Update ssl.md

Corrected minor typo on #426 - useu --> use

@RachelAmbler Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@RachelAmbler Thank you for signing the Contributor License Agreement!

Thank you!


feature: add way to show error in promise toast with server actions

Describe the feature / bug 📝:
it is posible to handle errror in toast.promise in other way than throwing new error [throw new Error("MESSAGE")] in async function?
i have toast with promise function where i am deleting user, if i have error in server function i wanna have error variant of toast, it is possible with throwing error but it also give it in console etc.
function in client component
onClick={async () => {
    toast.promise(
        deleteUser({
            email: row.getValue("email"),
        }),
        {
            loading: "Usuwanie...",
            success: ({ data }) => data,
            error: ({ message }) => message,
            finally: () => {
                // final
            },
        }
    );
}}

server action function
"use server";

import prisma from "@/lib/prisma";
import { z } from "zod";
import { auth } from "@/lib/auth";
import { revalidatePath } from "next/cache";

const deleteUserSchema = z.object({
    email: z.string().email(),
});

export async function deleteUser(values: z.infer<typeof deleteUserSchema>) {
    const schema = deleteUserSchema.safeParse(values);
    const { user, session } = await auth();

    if (!user) {
        throw new Error("Musisz być zalogowany");
    }

    if (user?.email === values.email) {
        // it works but it also throw error in console and i dont want it...
        throw new Error("Nie możesz usunąć swojego konta");
    }

    if (!schema.success) {
        return { success: true, data: schema.data };
    }
    const { email } = schema.data;

    const deletedUser = await prisma.user.delete({
        where: {
            email,
        },
    });

    if (!deletedUser) {
        throw new Error("Taki użytkownik nie istnieje");
    }

    revalidatePath("/(dashboard)/dashboard/members");

    return {
        success: true,
        data: `Użytkownik ${email} został usunięty`,
    };
}

stupid sollution

// client
onClick={async () => {
    setLoading(true);

    const toastTest = toast;

    toastTest.loading("Usuwanie...");

    const { success, data } = await deleteUser({
        email: row.getValue("email"),
    });

    toastTest.dismiss();

    if (success) {
        toastTest.success(data);
    } else {
        toastTest.error(data);
    }
}}

// server
if (user?.email === values.email) {
    return { success: false, data: "Nie możesz usunąć swojego konta" };
}

it works but it pretty goofy
it is the best solution but also very goofy and long...

// client
onClick={async () => {
    async function generatePromise<T>(
        promise: Promise<{ success: boolean; data: T }>
    ): Promise<T> {
        const action = await promise;
        if (action.success) {
            return action.data;
        } else {
            throw action.data;
        }
    }

    const promise = generatePromise(deleteUser({ email: row.getValue("email") }));

    toast.promise(promise, {
        loading: "Usuwanie...",
        success: (data) => data,
        error: (message) => message,
        finally: () => {
            // final
        },
    });
}}

// server - same as above
if (user?.email === values.email) {
    return { success: false, data: "Nie możesz usunąć swojego konta" };
}

ok after thinking about it, the best way is to add another example in docs with server action...

but I dont think there is anyone who also uses sonner with server actions in this way xd

In my case I didn't care that the error was displayed in the server console, my problem was that the error message was displayed correctly in development but not in production
"use server" turns all functions in your actions.ts file into endpoints for the client.
That is why handling errors with the Error instance does not work correctly in production, because Next uses a structure defined for these cases and avoid leaks of important information in the response.
https://nextjs.org/docs/app/api-reference/file-conventions/error#error
Therefore you must find a way to "reject" the promise with an error without using Error instance in the server action.
Works in development:
//actions.ts
'user server'
export async function serverAction(){
    const { error, someResult } = await someDatabaseQuery();
    if (error) {
        throw new Error("Error:" error);
    }
    if (!someResult) {
        throw new Error("Error message");
    }
    return someResult
}
//page.tsx
'use client'
toast.promise(serverAction()), {
      loading: 'await response...',
      success: 'response ok!',
      error: (error) => error.message,
});

but in production the error message is not shown, instead it is shown:
An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.
Solution
This works for me, it just reduces generatePromise function a little, but it's still the same:
//utils.ts
export async function customPromise<T>(promise: Promise<{ success: boolean; data: T }>): Promise<T> {
  const { success, data } = await promise;
  if (success) {
    return data;
  }
  throw data;
}

avoid generating an Error instance in the server action:
'user server'
export async function serverAction(){
    const { error, someResult } = await someDatabaseQuery();
    if (error) {
        return { success: false, data: error.message || "Error message" };
    }
    if (!someResult) {
        return { success: false, data: "Error message" };
    }
    return { success: true, data: someResult };
}

on the client I use customPromise. This function generates a promise that may fail and return the error message:
 toast.promise(customPromise(serverAction()), {
      loading: 'await response...',
      success: 'response ok!', //you can get someResult
      error: (message) => message,
});

Personally I would like them to include this in the documentation, but I don't think there are many use cases, since in next js server actions are not the only way to do fetching and it is not the most preferred by everyone. So this will probably never be added...


[Issue-207] By default add the name of the board to the image's name

The board_setup function now saves the board's name to BOARDNAME, and
board_generate_image_name will later use it to add it to the image's name.
For https://github.com/freebsd/crochet/issues/207

Looks great!  Thanks!


Drop support for EOL Python 3.7

Python 3.7 is EOL since 2023-06-27: https://devguide.python.org/versions/
Dropping 3.7 means the https://pypi.org/project/importlib-metadata and pkg_resources fallbacks can be removed.

Thanks, high time to revisit this (and also update the link in our docs ...)
@birkenfeld I just checked: RHEL9 ships with 3.9, Ubuntu 22.04 uses 3.10, and Debian Bookworm is Python 3.11. So we could technically drop 3.7 as per our own guidelines (https://pygments.org/docs/contributing/) -- any concerns?

👍


add info when debug server fails

fixes #9

@wkloucek wouldn't make sense to fix this as well in the extension template?

@wkloucek wouldn't make sense to fix this as well in the extension template?

The extensions template already have a logic similar to this in place, albeit not 100% the same semantics. We could update it to this as it is more precise and uses oklog/grouprun more accordingly.


Bump up ws to 6.1.0

This PR upgrades ws to the latest stable version.
All tests pass.

Is there a particular reason? I usually don't upgrade a dependency if everything works fine.

@cyrus-and No particular reason; After Node 4 was marked EOL, most packages removed support for it and upgraded their dependencies. v5.x of ws did the same too, and I thought it would make it a little easier to upgrade this project in the future.

Alright, thanks.


sslmode?

Support for sslmode for connections appears to be completely absent. I can understand not supporting it yet due to the state of Zig's TLS support but this at least deserves a prominent mention in the README.

I added a note.
FWIW, there is a TLS branch, but it's buggy/dangerous (you can get junk bytes) due to, as you mention, issues with Zig's TLS support.


Scenarios endpoints

Moved all functions to queries.js and fixed everything else you mentioned.

formatted all query strings
fixed games/wins response descriptions
removed heroIdParamPath from params.js I was not using it anymore


Failed to execute npm run seq

Hey, I'm trying to run the documentation locally to see some changes I'm making live, I tried installing the dependencies using npm install, it got to the "seq" stage and failed there, i tried using a different computer but im facing the same issue.

seq
bash -c 'for cmd in "$@"; do npm run $cmd || exit 1; done' - get:submodule _prepare:docsy

<3>WSL (2192) ERROR: CreateProcessEntryCommon:505: execvpe /bin/bash failed 2
<3>WSL (2192) ERROR: CreateProcessEntryCommon:508: Create process not expected to return
npm error code 1
npm error path C:\Users\levsh\Documents\oren-test\opentelemetry.io
npm error command failed
npm error command C:\WINDOWS\system32\cmd.exe /d /s /c npm run seq -- get:submodule _prepare:docsy
npm error A complete log of this run can be found in: C:\Users\levsh\AppData\Local\npm-cache_logs\2024-06-09T10_20_51_496Z-debug-0.log
Could anyone help me with that?

@Orenico10 can you share some details about your environment (OS, Arch, Node + NPM version, etc) this will help us to debug

@Orenico10 can you share some details about your environment (OS, Arch, Node + NPM version, etc) this will help us to debug

Yes of course,
I'm using windows 10 on an 8th gen Intel laptop processor,
Node version 20.14LTS,
The bundles npm version when installing node 20 (10.6 I think),
The WSL2 has docker and Ubuntu 22.04LTS
I tried installing on a different laptop and got similar results.

Can you share the complete log as well (C:\Users\levsh\AppData\Local\npm-cache_logs\2024-06-09T10_20_51_496Z-debug-0.log)?

Can you share the complete log as well (C:\Users\levsh\AppData\Local\npm-cache_logs\2024-06-09T10_20_51_496Z-debug-0.log)?

2024-06-09T10_20_51_496Z-debug-0.log

Thanks, unfortunately no helpful details. Can you run
C:\WINDOWS\system32\cmd.exe /d /s /c npm run seq -- get:submodule _prepare:docsy

in the shell directly and see what error you get from that?

Thanks, unfortunately no helpful details. Can you run
C:\WINDOWS\system32\cmd.exe /d /s /c npm run seq -- get:submodule _prepare:docsy

in the shell directly and see what error you get from that?

C:\Users\levsh\Documents\oren-test\opentelemetry.io>c:\windows\system32\cmd.exe /d /s /c npm run seq -- get:submodule _prepare:docsy

seq
bash -c 'for cmd in "$@"; do npm run $cmd || exit 1; done' - get:submodule _prepare:docsy

/bin/bash: -c: line 1: unexpected EOF while looking for matching `''
/bin/bash: -c: line 2: syntax error: unexpected end of file

I can not reproduce this issue locally, although I also have no windows machine at hand to verify that.
Here is the line that leads to that problem:
https://github.com/open-telemetry/opentelemetry.io/blob/11df7eb3826331346273d744fadbb1fcdbc76c19/package.json#L85
Maybe it needs to be modified for WSL?

I tried dockerizing the website files and that worked but im getting a new error when running npm run serve
2024-06-10 11:13:34 > cp:spec
2024-06-10 11:13:34 > scripts/content-modules/cp-pages.sh
2024-06-10 11:13:34
2024-06-10 11:13:34 /usr/bin/env: 'bash\r': No such file or directory
2024-06-10 11:13:34 /usr/bin/env: use -[v]S to pass options in shebang lines

the dockerfile is:
FROM node:latest

COPY ./opentelemetry.io /opentelemetry.io
WORKDIR /opentelemetry.io

RUN git config --global --add safe.directory /opentelemetry.io
#RUN npm config set fetch-retry-maxtimeout 600000
#RUN npm config set fetch-retries 3
RUN npm install

EXPOSE 1313

CMD ["npm", "run", "serve"]

the entire log from docker:
2024-06-10 11:06:23
2024-06-10 11:06:23 > serve
2024-06-10 11:06:23 > npm run serve:hugo --
2024-06-10 11:06:23
2024-06-10 11:06:23
2024-06-10 11:06:23 > preserve:hugo
2024-06-10 11:06:23 > npm run _prebuild
2024-06-10 11:06:23
2024-06-10 11:06:23
2024-06-10 11:06:23 > _prebuild
2024-06-10 11:06:23 > npm run seq -- get:submodule cp:spec
2024-06-10 11:06:23
2024-06-10 11:06:24
2024-06-10 11:06:24 > seq
2024-06-10 11:06:24 > bash -c 'for cmd in "$@"; do npm run $cmd || exit 1; done' - get:submodule cp:spec
2024-06-10 11:06:24
2024-06-10 11:06:24
2024-06-10 11:06:24 > get:submodule
2024-06-10 11:06:24 > npm run _get:${GET:-submodule}
2024-06-10 11:06:24
2024-06-10 11:06:24
2024-06-10 11:06:24 > _get:submodule
2024-06-10 11:06:24 > set -x && git submodule update --init ${DEPTH:- --depth 1}
2024-06-10 11:06:24
2024-06-10 11:06:24
2024-06-10 11:06:24 > postget:submodule
2024-06-10 11:06:24 > git submodule
2024-06-10 11:06:24
2024-06-10 11:06:25  f16a58e11ca14982ce5c3cf375c2384422dfb3ac content-modules/community (f16a58e)
2024-06-10 11:06:25  950df2967e22526aa553aac1d874ac90b973d140 content-modules/opamp-spec (v0.9.0-2-g950df29)
2024-06-10 11:06:25  eabcef4c2da6149b7e6dbbb8b7294402fcc287c1 content-modules/opentelemetry-go (trace/v1.23.0-rc.1-31-geabcef4c)
2024-06-10 11:06:25  b3060d2104df364136d75a35779e6bd48bac449a content-modules/opentelemetry-proto (v0.11.0-163-gb3060d2)
2024-06-10 11:06:25  a7bb6473769d93ddbe063071c94729a242a2cdb2 content-modules/opentelemetry-specification (v1.1.0-1086-ga7bb647)
2024-06-10 11:06:25  9adff435c76ea3b8cba89babefc832d3dd3c1ab9 content-modules/semantic-conventions (v1.26.0)
2024-06-10 11:06:25  102892d931ab79b573cb6aeca094b6f0f37b73b1 themes/docsy (v0.10.0-6-g102892d)
2024-06-10 11:06:25
2024-06-10 11:06:25 > cp:spec
2024-06-10 11:06:25 > scripts/content-modules/cp-pages.sh
2024-06-10 11:06:25
2024-06-10 11:06:24 + git submodule update --init --depth 1
2024-06-10 11:06:25 /usr/bin/env: 'bash\r': No such file or directory
2024-06-10 11:06:25 /usr/bin/env: use -[v]S to pass options in shebang lines
2024-06-10 11:13:32
2024-06-10 11:13:32 > serve
2024-06-10 11:13:32 > npm run serve:hugo --
2024-06-10 11:13:32
2024-06-10 11:13:32
2024-06-10 11:13:32 > preserve:hugo
2024-06-10 11:13:32 > npm run _prebuild
2024-06-10 11:13:32
2024-06-10 11:13:32
2024-06-10 11:13:32 > _prebuild
2024-06-10 11:13:32 > npm run seq -- get:submodule cp:spec
2024-06-10 11:13:32
2024-06-10 11:13:33
2024-06-10 11:13:33 > seq
2024-06-10 11:13:33 > bash -c 'for cmd in "$@"; do npm run $cmd || exit 1; done' - get:submodule cp:spec
2024-06-10 11:13:33
2024-06-10 11:13:33
2024-06-10 11:13:33 > get:submodule
2024-06-10 11:13:33 > npm run _get:${GET:-submodule}
2024-06-10 11:13:33
2024-06-10 11:13:33
2024-06-10 11:13:33 > _get:submodule
2024-06-10 11:13:33 > set -x && git submodule update --init ${DEPTH:- --depth 1}
2024-06-10 11:13:33
2024-06-10 11:13:33 + git submodule update --init --depth 1
2024-06-10 11:13:33
2024-06-10 11:13:33 > postget:submodule
2024-06-10 11:13:33 > git submodule
2024-06-10 11:13:33
2024-06-10 11:13:33  f16a58e11ca14982ce5c3cf375c2384422dfb3ac content-modules/community (f16a58e)
2024-06-10 11:13:33  950df2967e22526aa553aac1d874ac90b973d140 content-modules/opamp-spec (v0.9.0-2-g950df29)
2024-06-10 11:13:33  eabcef4c2da6149b7e6dbbb8b7294402fcc287c1 content-modules/opentelemetry-go (trace/v1.23.0-rc.1-31-geabcef4c)
2024-06-10 11:13:33  b3060d2104df364136d75a35779e6bd48bac449a content-modules/opentelemetry-proto (v0.11.0-163-gb3060d2)
2024-06-10 11:13:33  a7bb6473769d93ddbe063071c94729a242a2cdb2 content-modules/opentelemetry-specification (v1.1.0-1086-ga7bb647)
2024-06-10 11:13:33  9adff435c76ea3b8cba89babefc832d3dd3c1ab9 content-modules/semantic-conventions (v1.26.0)
2024-06-10 11:13:33  102892d931ab79b573cb6aeca094b6f0f37b73b1 themes/docsy (v0.10.0-6-g102892d)
2024-06-10 11:13:34
2024-06-10 11:13:34 > cp:spec
2024-06-10 11:13:34 > scripts/content-modules/cp-pages.sh
2024-06-10 11:13:34
2024-06-10 11:13:34 /usr/bin/env: 'bash\r': No such file or directory
2024-06-10 11:13:34 /usr/bin/env: use -[v]S to pass options in shebang lines

Tested using WSL2 (Ubuntu) on Windows 11 and it worked well. NPM version was 20.
added 234 packages, and audited 235 packages in 6s

73 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

added 1013 packages, and audited 1014 packages in 2m

235 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
npm notice
npm notice New minor version of npm available! 10.7.0 -> 10.8.1
npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
npm notice To update run: npm install -g<EMAIL_ADDRESS>npm notice

What's your npm when you enter which npm? Mine is /home/<user>/.nvm/versions/node/v20.14.0/bin/npm.
As possible solutions, see:

https://github.com/oven-sh/bun/issues/5669#issuecomment-1729452448
https://stackoverflow.com/a/63458916

Thanks @theletterf!

2024-06-10 11:13:34 /usr/bin/env: 'bash\r': No such file or directory

This looks like a linebreak issue with the script

Any news. @Orenico10 ? I'm partial to closing this one due to what seems to be npm's system configuration.

Any news. @Orenico10 ? I'm partial to closing this one due to what seems to be npm's system configuration.

The only solution I have found for this is dockerizing it on a Linux vm, which is pretty much what I was looking for (dockerizing it so it can work offline)

Thanks Orenico!
@svrnm @chalin This reminds me of this idea we posted a while ago... https://github.com/open-telemetry/opentelemetry.io/discussions/3810

Thanks all for your investigations.
I'm noticing that that #! of scripts/content-modules/cp-pages.sh differs from other .sh files. Could you change that starting line to match other .sh files and see if that works. That is, change it to:
#!/bin/bash

Yes, it reminded me of that as well @theletterf 😄 ... but if we can find a simple solution, I'd vote for that.


[Feature Request]: Customer Managed Key support for Azure Data Factory

Description
We use CMK's pretty extensively within our org and require them on the services that support them. Storage Accounts has this now and the next immediate need for us is for Azure DataFactory.

@jtucker CMK has recently been added to the Azure DataFactory module through PR #1585. Please check that out :blush:


Use of ocr in Evaluation

In Appendix A's Image-text Data Collection, mention "It is important to note that the
OCR detector is utilized solely for generating enriched data and is not employed during testing ". But the textvqa scripts is using llava_textvqa_val_v051_ocr.jsonl which has ocr. So have you ever test a version without ocr in textvqa, was it worse than llava_textvqa_val_v051_ocr.jsonl ? can we understand that model could get better result with ocr input?

Hi, the word in Appendix A means that we do not perform an extra PaddleOCR detector for evaluation. For the TextVQA, we keep the OCR Token with that in LLaVA. It should have a worse result without the original OCR tokens.


No WebWorker support

There are three window and two document references spread through systemjs-hmr and systemjs-hot-reloader:

https://github.com/alexisvincent/systemjs-hmr/blob/master/lib/index.js#L13
https://github.com/alexisvincent/systemjs-hmr/blob/master/lib/index.js#L17
https://github.com/alexisvincent/systemjs-hot-reloader/blob/master/lib/index.js#L54
https://github.com/alexisvincent/systemjs-hot-reloader/blob/master/lib/index.js#L10
https://github.com/alexisvincent/systemjs-hot-reloader/blob/master/lib/index.js#L17

However, even after removing them, hot-reloading from a worker does not work.
The update event seems to be triggered correctly and systemjs-hot-reloader logs:
reloading src/updatedModule.js
reloading cache.json

However, the updated module is not re-evaluated (break points are not hidden/console.log statements are not printed).
Unfortunately, I couldn't find the source of the problem... :(

Just digged a bit deeper in it. The base functions (System.unload and System.import) are also functional in the worker. Modules are successfully re-imported when manually triggering System.unload and System.imports in a worker context, too.
However, when system-hmr is not able to detect the right entries. That means that a changed module gets unloaded by system-hmr but not imported again, as its module is not a dependency of the entries that are identified by system-hmr.
@alexisvincent Is there a way to provide the entries to systemjs-hot-reloader (https://github.com/alexisvincent/systemjs-hmr/blob/master/lib/index.js#L223)?

yeah, System.reload('someModule', {entries: ["entry"]}). Will give a better explanation when I'm not on my phone

@mpfau Having a look now,
The following might not be necessary.

https://github.com/alexisvincent/systemjs-hmr/blob/master/lib/index.js#L13
https://github.com/alexisvincent/systemjs-hmr/blob/master/lib/index.js#L17

This is legacy and only there for backwards compatibility.

https://github.com/alexisvincent/systemjs-hot-reloader/blob/master/lib/index.js#L54

These are needed if we want full page reload and automatic host detection.

https://github.com/alexisvincent/systemjs-hot-reloader/blob/master/lib/index.js#L10
https://github.com/alexisvincent/systemjs-hot-reloader/blob/master/lib/index.js#L17

Is what you're wanting to achieve here being able to hot reload web worker scripts. Or run the hot-reloader in a web worker?
As I said before, you can manually provide entries, but then no entry discovery will happen. This could change in the future if it's more useful to merge entries.
Manually specifying entries is achieved as follows
System.reload('someModule', {entries: ["entry"]})

@alexisvincent full page reload is not possible from a worker anyways. Could be wrapped in a if (typeof window !== 'undefined').
I'm currently trying to run the hot-reloader in a webworker. However, I think that both approaches (reload the worker script if a module loaded by that script is modified (1) / updating a script in the webworker on module change (2)) are valid depending on your use-case.
Manually specifying the entries only works when systemjs-hmr is used directly. What do you think about an entries option for systemjs-hot-reloader?

@mpfau Yeah could totally add entries as an option to the connect function.
in terms of window detection, this could probably be generalized to an environment detection. Eg. web, web-worker, node etc. Then we can do the following:
if (isNode) {
    ...
} else if (isWorker) {
    ...
}

@mpfau Have pushed entries option in connect function. See if that works for you.

@alexisvincent thanks! This is working fine and enables an absolutely awesome workflow :)
I created a the pull requests https://github.com/alexisvincent/systemjs-hmr/pull/23 and https://github.com/alexisvincent/systemjs-hot-reloader/issues/132 in order to enable systemjs-hmr and systemjs-hot-reloader for worker usage.

@mpfau are there any real benefits to running the hot-reloader in a web worker by default?

@mpfau Can you give me a short description of what the current codebase can do with regards to web workers. Would like to add something to the README

I am working on a description. Give me a few more minutes... :)

#137


startuptest

Original author: Nikhil Jain
Original issue: https://charm.cs.illinois.edu/redmine/issues/615

No body.

Original date: 2015-01-21 01:00:25

Updated to current CkArrayIndex API.  Fixed bug in Makefile.
As far as I can tell, this functionality is not being tested elsewhere.  So, I added it to the top level test Makefile.


dashboard/app: Linkify source code paths in stacktraces

In the dashboard, there are stack traces which contain various paths in the kernel tree. For example, https://syzkaller.appspot.com/bug?extid=f0fdc967350bd580a80b.
It'd be great if syzkaller turned those into links to an online source code viewer, at the particular line (at the revision/tree that syzkaller was testing). For example the first path/lineno: lib/dump_stack.c:77 might become a link to https://github.com/torvalds/linux/blob/master/lib/dump_stack.c?utf8=✓#L77
oss-fuzz's UI performs this and it's an incredible boon for quickly reviewing code to diagnose an issue.

Are you asking for yourself, or for a friend? :)
Main syzbot reporting channel is plain text emails on Linux kernel mailing lists. Some reports go into internal bug tracking system which does not support html/markdown too. So in most cases people won't see links. Lost of the trees we test are not on github and/or rebased (net, bpf, linux-next).

Fair question :-)
I'm not involved in upstream kernel development, so I'm probably not your primary audience, since I won't really be fixing bugs.
My interest is that, as a security engineer, I read lots of the syzkaller reports and try to understand what patterns produce memory unsafety, mostly to contribute to my personal hypothesis that C/C++ are a preventable root cause for many of these bugs, and to shape my thinking about API/internals design in https://github.com/alex/linux-kernel-module-rust

I see. I agree it would be nice to have. But it won't be high on my todo list.


Update README.md

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

Merging, the two tests that are broken are know-broken on main.


Render error

Hi
I have an issue: when Im trying to render my stats in README.md Github I get an error

This page contains the following errors:
error on line 71 at column 36: AttValue: ' expected
Below is a rendering of the page up to the first error.

And it stops rendering stats.
if I use a link with my ID in browser everything is good https://steam-stat.vercel.app/api?profileName=KeoFoxy
But
<img src="https://steam-stat.vercel.app/api?profileName=KeoFoxy"/>

From now I mentioned that it renders correctly but gives a bad link and img does not show up

I guess it worked? :3

Yeah :)


Update CVE links in more Finding sections

Description
Some broken links in Findings section > Fixable CVEs tables of Namespace Overview and Deployment Overview.
Plus, the Findings section > Platform CVEs table of Cluster Overview had broken in a regression. Fixed that, too.
Checklist

[ ] Investigated and inspected CI test results

Testing Performed
Cluster Overview > Findings section > Platform CVEs table
BEFORE

AFTER

Namespace Overview > Findings section > Image CVEs table
BEFORE

AFTER

Deployment Overview > Findings section > Image CVEs table
BEFORE

AFTER

/retest


Couldn't find a debug adapter descriptor for debug type 'coreclr' (extension might have failed to activate) in VScode version 1.56.2

from the moment we upgraded to VSCode to latest version 1.56.2 we can not debug any kind of project...
ERROR:
Couldn't find a debug adapter descriptor for debug type 'coreclr' (extension might have failed to activate).
Downloading package 'Razor Language Server (Windows / x64)' Failed at stage: downloadPackage
Error: unable to get local issuer certificate
just in case; we do not have this folder: C:\Users...vscode\extensions\ms-vscode-csharp not even the .razor directory.
we have the folder: ms-dotnettools.csharp-1.23.11. And inside this there is a .razor folder.
we saw other post on github but below commands did not work for us:
git clean -xfd
Update to the latest version of node
npm i -g gulp
gulp vsix:offline:package
we uninstalled the C# extensions packaged and then re-installing we get this failure:
Downloading package 'Razor Language Server (Windows / x64)' Failed at stage: downloadPackage
Error: unable to get local issuer certificate
When we try to run debug, we get a prompt to Select the process to attach to with a long list, what we should select?.
is this a bug on latest VCode Version as it did not happens in previous ones?
your help please_

I'm having the same issue. Did you find a resolution?

there´s a proxy in between which block downloads.
from VSCode there´s a setting should be false: http.proxyStrictSSL
that will solve it.
https://code.visualstudio.com/docs/setup/network


Query xidlelock disabled/enabled

I would like to query if I am in disabled or enabled state and maybe even if there is something (e.g. a full screen video) inhibiting the screensaver.
Use case:
i3bar displaying whether screensaver is on or off as well as toggling the functionality from there.
Is there any option to get this information or do we need to extend xidlehook-client with the parameters --toggle and --query?

Would probably be implemented together with #27

Yeah this is fixed now, I forgot to clean up the issue list after !6


Bootstrap OCaml

Motivation for this change
Bootstrap ocaml with https://github.com/Ekdohibs/camlboot.
Replaces #138519.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This is cool, but I would prefer if the bootstrapping was done in Nixpkgs and not the package -- packages doing their own bootstrapping generally causes issues long term. Would it be possible to package the miniml compiler and OCaml interpreter separately? And if so, then use those packages (so those tools pre-built) to do the OCaml build? OK if the handwritten lexer isn't packaged separately --- I'm OK with that being more one-off.

I agree, it makes the bootstrapping logic easier to reason about. This would probably require some patching as the bootstrapping logic is done using makefiles which build previous steps' executables as targets. Hopefully upstream will be receptive to changes allowing this.


feat: improving loginAttempt storage

Summary of Changes
Fix issue storing loginAttempt on keychain
Related Issues
Resolves  #1031
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

[X] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
[X] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
[X] Updated documentation as needed for changed code and new or modified features;
[X] Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓

Read our contribution guide at least once; it will save you a few review cycles!
Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@wadeking98  @jleach @bryce-mcmath may you take a look, please?

@wadeking98 can you check this one out when you have a moment?


Question--Using dynamic routes with NextJS and MF

Is it possible to use dynamic routes with MF and a NextJS client and remote?
i.e. is it possible to route /plugin/foo and /plugin/bar to [[...index]].tsx in the remote just by using the plugin/MF or is that something i would need to implement myself around the webpack api?

yeah it is, but you will need to use the low level apis, you can take a look at the utilities package which contains dynamic remote loading options and so on which give you lots of flexability

Not in next. But modernjs.dev will release route discovery and stitching as well a completely dynamic support as first class citizen in the meta framework. Sometime over the next few weeks.


Airflow has not released 1.10.9 yet.

1.10.8 was released about a week ago
https://github.com/conda-forge/airflow-feedstock/blob/b8d0a4e89fae650898ebeb8208ec53045b1b623d/recipe/meta.yaml#L2

@atronchi, I was concerned about that, see my comment here: https://github.com/conda-forge/airflow-feedstock/pull/41#issuecomment-583687205
However, conda-forge got triggered when a 1.10.9 release was uploaded to pypi:
https://pypi.org/project/apache-airflow/1.10.9/
I wasn't sure to follow GitHub where there wasn't a 1.10.9 or pypi where there was.

If you can confirm, that 1.10.9 was released unintentionally on pypi, we can get the package moved to broken.


Test for DROOLS-355

This is an example test for the DROOLS-355: by having it in master before the fix/PR is applied, the merger can see what has changed.
Thanks,
Marco
@mswiderski or @psiroky, would you mind reviewing and/or merging? Thanks.

@mrietveld not sure I am the best one to review it as I don't know much about this feature (psd with rules). Anyway just added one question out of curiosity as this really looks interesting :)


Table 11011 function CheckDate event needed

Hi,
we would like to extend check in funtion CheckDate therefore we need event like:

Please provide country code and full name of table.

oh yes, sorry...
table: 11011 "Sales VAT Advance Notification"
country code: DE
thanks

Table 11011 "Sales VAT Advance Notification" does not contain procedure CheckDate. Request cannot be processed.

Sorry thank you. We will refacture our code


fix(SDK): regeneration after content review

PR summary

Fixes: <! -- link to issue -->
PR Checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

:tada: This PR is included in version 0.0.32 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Adding the possibility for an individual prefix

This closes https://github.com/NamelessMC/Nameless-Link/issues/54

I also considered allowing it to be set per guild in the database (so people using the central bot can change the prefix) but this is enough for now, adding it to the database adds a lot of complexity.

I wasn't really shure if the bot is used in a selfhosted was or not. That is why I used environment variables.
After reading your comment, I think it is a managed bot. I will take a look at your database system and will propably implement the per guild prefix.
That is also the reason, was this is a draft PR

It is both, it can run in a centrally managed mode with a database and it can run self-hosted in "stateless mode" for one discord guild and website.
Outside of DMs, the bot only responds to direct matches of specific commands so the chance of conflict is low.
As a lazy person, I'd say this is fine.

After merging this PR, you will need to add the command_prefix column in your connections database.
The command_prefix column is located between api_url and last_use. The comment to modify the prefix for a guild is also implemented.
Please note, that these changes are untested as I don't have the possibility to test them. I don't have a Nameless Instance running anywhere. So please, for your own stability of your system, please test these changes before merging and deploying to your production system.

Thanks so much for your contributions :)


Add build targets to Dockerfile and add Docker Compose functionality

This PR seeks to provide new features and capabilities to the repo that primarily entail;

Update the root Dockerfile with new functionality and capabilities that will enable those new to the repo to be able to right away have a working environment that they can build and reproduce. Even those that do not know Elixir.
Provide a "production-ready" docker container build
Provide a "development capable" docker container build
Provide a docker compose that automates the deployment and setup of the entire server and all it's dependent components in order to;

Enable reproducible production environment spinups
Provide a fully working stack to developers, not just a working Dockerfile
Enable portability and become agnostic of distro or OS. The only strict dependency becomes Docker.

Enable strict version control mechanisms to accelerate version-specific bug identification and triage
Use technologies and methods that, eventually if needed, already support software and ops industry standard High Availability capabilities for the server.
Where possible, dynamically generate credentials where the lifetime of a dynamically generated credential is the lifetime of the deployment. When the deployment is redeployed, dynamic credentials are automatically rotated preventing credential drift and reducing risk of weak credential usage.

These features allow a larger audience of contributors to, in parallel of primary contributors, undertake troubleshooting and bugfixing without the need to reproduce a "golden image" environment from documentation or memory. Utilizing a docker compose and docker containers makes the target environment portable to everyone. These mechanisms also make the server capable to potentially be deployed to many container orchestration platforms. Which would allow this project to tap into the strong industry-standard capabilities provided by container orchestration to enable high availability, horizontal scaling, vertical scaling, direct platform integration, etc.
Implementing the above tenants and features would be a huge step towards decoupling teiserver from it's environment, which is a important step in enabling dynamic horizontal scaling

Left ToDo:

Finalize NGINX reverse proxy

There are really 2 workflow changes that merging this PR would have over the current workflow that people have when operating this repo. They are

When using the scripts/generate_release.sh script, the output tarball no longer contains full paths. So when you tar -xzf it, it won't extract to the root paths in /opt on your system like it was doing
Anyone that was using the Dockerfile directly for /stuff/ will have a different experience now...

If this is going to break my existing workflows them I'm not inclined to make use of it.
All non-docker workflows are not affected. You can continue to do everything the way you were doing it before. I have made no dependency changes, compile time or runtime requirements for non-docker workflows.

if my existing docker flows will break then I'm going to be extra wary
As far as I'm aware from what you shared of your docker workflow. The only change is that the output tarball that get's generated by scripts/generate_release.sh no longer contains full paths (used to be /opt/teiserver... IIRC). I can change this back, it just caught me by surprise when it tried to extract itself to /opt on my system.

To my knowledge, the only docker flows you have are just scripts/generate_release.sh and scripts/build_container.sh. Both of these scripts work the same as they did before, with the exception of that tarball output I mentioned above.

I just now saw the dependency you have on scripts/generate_release.sh in documents/guides/hot_reloading.md. I'll go and ensure that scripts/generate_release.sh works as it did before.

@Teifion Ok I've fixed the scripts/generate_release.sh to generate the same output as before (according to the bin/build file you shared with me in Discord)

Example Output:
$: tar -tf teiserver.tar
opt/build/_build/prod/
opt/build/_build/prod/rel/
opt/build/_build/prod/rel/central/
opt/build/_build/prod/rel/central/releases/
opt/build/_build/prod/rel/central/releases/COOKIE
opt/build/_build/prod/rel/central/releases/0.1.0/
opt/build/_build/prod/rel/central/releases/0.1.0/start_clean.script
opt/build/_build/prod/rel/central/releases/0.1.0/runtime.exs
opt/build/_build/prod/rel/central/releases/0.1.0/start.boot
opt/build/_build/prod/rel/central/releases/0.1.0/start_clean.boot
opt/build/_build/prod/rel/central/releases/0.1.0/elixir
...
opt/build/_build/prod/lib/gen_stage/ebin/Elixir.GenStage.Dispatcher.beam
opt/build/_build/prod/lib/gen_stage/ebin/Elixir.ConsumerSupervisor.beam
opt/build/_build/prod/lib/gen_stage/ebin/Elixir.GenStage.BroadcastDispatcher.beam
opt/build/_build/prod/lib/gen_stage/ebin/Elixir.ConsumerSupervisor.Default.beam
opt/build/_build/prod/lib/gen_stage/ebin/Elixir.GenStage.beam
opt/build/_build/prod/lib/gen_stage/ebin/Elixir.GenStage.Utils.beam
opt/build/_build/prod/lib/gen_stage/ebin/Elixir.GenStage.DemandDispatcher.beam

@Teifion I have added documentation, squashed the commits into a single commit. This is now ready for a review.

Sorry for above, there was a line terminator issue that I had to normalize back to what the rest of the repo was using

I've gotten halfway through the files and all I'm seeing is a huge amount of added complexity even to run it locally. I'm really not sure what the upside to this PR is.

This complexity already existed in the repo. Simply reading the local_setup.md document demonstrates that. All of this is just automating and integrating the manual labor required in documentation to get the server up and running.

For me specifically, I don't want to spend my time scrubbing databases or dealing with any of the other menial tasks associated with running this server as I work on a feature that has some change somewhere.
For me and I think most people that come to this repo for the first time seeking to contribute, having an automation system that greatly simplifies all of the manual labor involved in even getting a development version of this server to run is a godsend.

This is some great stuff. Haven't had the time to go through everything yet but from what I've seen this is really impressive.

Cheers for the feedback @BAR-eL-bArTo and @Okema1

This is awesome work, and I would only have some nit comments but before that @Teifion can you please list your issues with this PR and why it's not merged? I would like to help explain why this stuff is good but don't know what you miss.

@p2004a I had several questions for him but due to delays from both of us (at different times of course) we never got a chance to discuss them and I cannot recall the questions. Given your seal of approval I'll merge it.


app.py added

In the folder where app.py locates, terminal: flask run
Open a new terminal, curl -X POST http://<IP_ADDRESS>:5000/predict -d '[1,2,3,2,2,2,2,2,2,2,2,2,2,2,2,2,2,2,2,2,2,2,2,2,55]' -H "Content-Type: application/json"
(can change to any len=25*int numeric list in the code)

I'm going to merge this PR to deploy it. If you want to change anything, feel free to do so @berkaybulut


[BUG] Automated tests for Premium users

Description
We should at least test that pages with premium features and premium pages load without any error
Screenshots
No response
Do you want to work on this issue?
None
Additional information
No response

Hello, I am new here and would like to take up this issue as my first contribution. Can this be assigned to me?

Hi @Abhishek-90 welcome! Thank you for your enthusiasm but we ask that all new contributors start out with issues which range from 1 Point to 3 Points.

using playwright?

yes we use playwright, you can find existing test files in the tests directory

I would like to work on this. I will start by taking a look in the tests directory.

Awesome Erik! I have assigned it to you.
This issue is quite vague, I think we should keep it small enough to add value, then new issues can be created afterwards. After you have looked at the test directory let me know what you think or if you have any questions

Unassigning as no activity

I would like to take it up, but can you describe more as to what is the expectations out of it?

I will take that if abhishek has opened assigned issues.

I will take that if abhishek has opened assigned issues.

@theunhackable I have assigned this to you

I am getting this error while using docker compose up or using npm ci
npm ERR! code 1
npm ERR! path /media/solo/New Volume1/git_contrib/theunhackable-LinkFree/node_modules/sharp
npm ERR! command failed
npm ERR! command sh -c (node install/libvips && node install/dll-copy && prebuild-install) || (node install/can-compile && node-gyp rebuild && node install/dll-copy)
npm ERR! sharp: Downloading https://github.com/lovell/sharp-libvips/releases/download/v8.14.5/libvips-8.14.5-linux-x64.tar.br
npm ERR! sharp: Integrity check passed for linux-x64
npm ERR!
npm ERR! make: Entering directory '/media/solo/New Volume1/git_contrib/theunhackable-LinkFree/node_modules/sharp/build'
npm ERR!   CC(target) Release/obj.target/nothing/../node-addon-api/nothing.o
npm ERR! rm -f Release/obj.target/../node-addon-api/nothing.a Release/obj.target/../node-addon-api/nothing.a.ar-file-list; mkdir -p `dirname Release/obj.target/../node-addon-api/nothing.a`
npm ERR! ar crs Release/obj.target/../node-addon-api/nothing.a @Release/obj.target/../node-addon-api/nothing.a.ar-file-list
npm ERR!   COPY Release/nothing.a
npm ERR!   TOUCH Release/obj.target/libvips-cpp.stamp
npm ERR!    System Linux 6.2.0-39-generic
npm ERR! gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm ERR! gyp ERR! cwd /media/solo/New Volume1/git_contrib/theunhackable-LinkFree/node_modules/sharp
npm ERR! gyp ERR! node -v v20.10.0
npm ERR! gyp ERR! node-gyp -v v10.0.1
npm ERR! gyp ERR! not ok

npm ERR! A complete log of this run can be found in: /home/solo/.npm/_logs/2024-01-07T03_39_28_914Z-debug-0.log

Given the length of time since this issue has been assigned and as no PR has been created, @theunhackable I am unassigning this from you to give someone else a chance to work on it.

I would like to take it up.

I would like to take it up.

@Abhishek-90 I will assign this to you

So far as per my analysis, there 3 premium features present.

Hide Navbar: We can add a test to check if when the account is a premium user, the navbar is hidden.
Hide Footer: We can add a test to check if when the account is a premium user, the footer is hidden.
Custom Domain: We can add a test to check if when the account is a premium user, the domain(url) is of users choice.

To implement these, one thing that is required is to check if the account is premium, in that case, we can simply check if the for the page, the navbar and footer are hidden or no.
For 3rd one, I will need some assistance.
Hence, we can create 3 different issues, to add 3 different test cases.
Let me know you views and suggestions.

Hello, I went through the features of premium page again and referred existing tests for different pages. There are some basic automated tests that also we can add:

Go to url:/account/manage/premium, there should be a switch with Label Hide Navbar on your Profile.
Go to url:/account/manage/premium, there should be a switch with Label Hide Footer on your Profile.
Go to url:/account/manage/premium, there should be a SAVE button which is disabled by default.

If there seems like valid test, let me know how should I proceed further, Should I add all 3 tests in 1 go, or shall I created 3 different issues for each cases. Each Issue can be a 2/3 pointer, whereas a single issue could be 8 pointer.


Dependency injection

Ideas for a modern version of the library in the future.
https://google.github.io/dagger/
https://mvnrepository.com/artifact/com.google.dagger/dagger/2.15 (35kb)
https://mvnrepository.com/artifact/javax.inject/javax.inject/1 (1kb)

https://mvnrepository.com/artifact/com.google.dagger/dagger

https://github.com/RumiRajbhandari/DaggerDemo
https://github.com/EktaRobo/Evaluation_2017

https://www.paradigmadigital.com/dev/inyeccion-dependencias-dagger-2/

Rejected by LEAN


[Component] Create use case and tests for component item

Create a use case that accepts a colors and tab intent and returns a color token.
Tabs only have two intents, primary and secondary


Ignition Transport fails to build on Debian/Ubuntu with pkg-config 0.29.2

Upgrading pkg-config from 0.29-6 to 0.29.2 has broken FindZeroMQ.cmake, I think.
Building ignition-transport 8.0.0 in Debian fails with this error:
CMake Error in src/CMakeLists.txt:
  Imported target "ZeroMQ::ZeroMQ" includes non-existent path

    "-isystem"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

Presumably caused by:
$ pkg-config --cflags-only-I libzmq
-isystem /usr/include/mit-krb5 -I/usr/include/pgm-5.2

It used to output:
$ pkg-config --cflags-only-I libzmq
-I/usr/include/pgm-5.2

The relevant pkg-config change is: https://cgit.freedesktop.org/pkg-config/commit/?id=d5d80748936c1ddb2e32bc713f2ed51dc6f753ea
Full build log: https://launchpadlibrarian.net/478683366/buildlog_ubuntu-groovy-amd64.ignition-transport_8.0.0+dfsg-3_BUILDING.txt.gz
Debian Bug: https://bugs.debian.org/960081

This is a cmake bug tracked here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959064

Aha. And fixed too.


isValid() doesn't recognize abbreviated French month strings for format "MMM" when locale == "fr".

moment("Jan", "MMM", "en", true).isValid() will return true as expected.
After setting moment.locale("fr"), moment().format( "MMM" ) returns ["jan.", "fév.", ...] instead of ["Jan",  "Feb", ...].
moment("Jan", "MMM", "fr", true).isValid() and moment("jan", "MMM", true).isValid() returns false, which is expected.
But moment("jan.", "MMM", "fr", true).isValid() will also return false. "jan." is the same string used by format(), so why was it not accepted as valid?
There doesn't seem to be a way to validate abbreviated month for "fr" locale.
From Developer Console:

moment.locale("en");
<- "en"
moment(Date.parse("2016-01-05")).format("MMM");
<- "Jan"
moment("Jan", "MMM", "en", true).isValid();
<- true
moment.locale("fr");
<- "fr"
moment(Date.parse("2016-01-05")).format("MMM");
<- "janv."
moment("Jan", "MMM", "fr", true).isValid();
<- false
moment("janv.", "MMM", "fr", true).isValid();
<- false

same for me ... switching from 2.12 to 2.13 changed behavior of this code snippet:
const moment = require("moment");
moment.locale("de");
moment.updateLocale("de", {
  monthsShort : "Jan._Feb._Mrz._Apr._Mai_Jun._Jul._Aug._Sep._Okt._Nov._Dez.".split("_")
});

let date = moment("01. Mrz 18", ["DD. MMM YY"], true);
console.log(date.isValid());

let date1 = moment("01. Mrz. 18", ["DD. MMM YY"], true);
console.log(date1.isValid());

output 2.12
true
false
false

output 2.13
false
true
false

so in my eyes this should have been a major update :(

So, just getting around to this one now.
@hrimhari, when I run that code, I see the following:
moment.locale('fr')
"fr"
moment("Jan", "MMM", "fr", true).isValid();
false
moment("janv.", "MMM", "fr", true).isValid();
true

This is what I would expect, given that the french short month abbreviation we have on record is in fact 'janv.'.
On that same note, I would expect the following to be invalid:
moment("jan.", "MMM", "fr", true).isValid()

You are parsing in french, and the short month for French is 'janv.' not 'jan.'.
Am I missing something here?

@pkyeck I'm not sure why you have three result sets. I only see two. In any case, if I run your code (including your update locale statement) I see the following:
moment("01. Mrz 18", ["DD. MMM YY"], true).isValid()
false
moment("01. Mrz. 18", ["DD. MMM YY"], true).isValid()
true

This is again what I would expect since there is a . at the end of Mrz that we expect to match.
This IS a change from previous versions, in the sense that parsing any month abbreviation with a . was broken before and now it's not.
If you want the following behavior:
moment("01. Mrz 18", ["DD. MMM YY"], true).isValid()
true
moment("01. Mrz. 18", ["DD. MMM YY"], true).isValid()
false

You could run the following code:
moment.updateLocale("de", {
  monthsShort : "Jan._Feb._Mrz._Apr._Mai_Jun._Jul._Aug._Sep._Okt._Nov._Dez.".split("_"),
monthsParseExact:false
});

That monthsParseExact param is what @ichernev added to make the strict parsing work. To be honest, I'm not entirely sure of what the implications of toggling it back are, but I think it should result in the old behavior.

@maggiepint thanks for the reply.
the third output was something else I had in my test script and I just forgot to remove the last false from the output.

This IS a change from previous versions, in the sense that parsing any month abbreviation with a . was broken before and now it's not.

Good that we agree on that ;)
But my point is, that it was a major change, that breaks existing code when you have ^2.12.x in your package.json. If you follow semver this should have been released as 3.0.0 to not break older code snippets - even if it was broken before. People were relying on this broken behavior.
I just downgraded back to 2.12 and pinned the version in my package.json.

@pkyeck , why not try flipping that monthsParseExact bool back? I think it should result in the same thing.

I had a similar issue with an older version, but it appears this has been solved by now.


Allow bosh_cli to start/restart/recreate a job or all jobs in deployment

#108399300
Signed-off-by: Alexey Miroshkin<EMAIL_ADDRESS>

it would be great to also include a stronger assertion in integration tests on the output to see if instance was updated or not in the task output. currently these tests dont check that director did anything.
Sent from my iPhone

On Nov 25, 2015, at 4:15 AM, cfdreddbot<EMAIL_ADDRESS>wrote:
Hey barthy1!
Thanks for submitting this pull request!
All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).
When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.
If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.
—
Reply to this email directly or view it on GitHub.

well missed the checks for vm cid and state changes. may be then just add a check that only one cid changed when doing recreate of a single vm? and check that starting a single vm doesnt start them all?
Sent from my iPhone

On Nov 25, 2015, at 4:15 AM, cfdreddbot<EMAIL_ADDRESS>wrote:
Hey barthy1!
Thanks for submitting this pull request!
All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).
When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.
If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.
—
Reply to this email directly or view it on GitHub.


Correctly parse suggested result name on all servers

/cc @grapesmoker @jimmynotjim
A quick fix to ensure that the parsing of the suggested search result's name from its URL works no matter the server the code is running on.

👍


RTL Support

Hi,
it seems that there is no RTL support And I was wondering if there is any planning to create or update for this kind of support.
specially relevant for Hebrew in Arabic languages.

I don't know if I did something wrong, I reuploaded the solution and this is the result

Hi Alex,
Can you remove the existing PCF from your instance and importing again.

Hi
unfortunately it's the same

I will try to reproduce this on my trial and fix it.

Hi Alex,
Unfortunately i cannot reproduce this at my end.
Can you try below steps if not already done.

Remove control from case form.
Delete PCF from your environment.
Import solution again from here.


Ukrainian localization

Thank you very much! I don't know ukrainian, but checking with Google Translate it looks good to me.


Add Git origin and upstream remotes

Need to add remote since it's the first time.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherrypick main

/lgtm
/approve

/approve

/cherry-pick release0.10

/cherry-pick release-0.10


style.css changes overidden by bootstrap.css?

Hi All,
First off, roots rocks! I've been using 1140 starkers as a base theme (i'm a newbie WP designer, slowly getting into this framework stuff) but roots is an excellent alternative.
My problem is this:
I wanted to change the default font to Times New Roman for a client, but I'm not versed in the ways of LESS yet, so I added:
body, p {
  font-family: TimesNewRoman, "Times New Roman", Times, Baskerville, Georgia, serif;
}

to: css/style.css
Unfortunately, it seems that my styles are being overidden by bootstrap.css when I check things out in firefox.
What is the easiest way to change the default font? Is there a way I can just use style.css, or do I need a crash course in LESS?
Thanks,
Nick

The styles are being overridden because styles.css is called BEFORE bootstrap.css, so bootstrap styles will override them, if they have the same specificity. (I agree that it might be a bit confusing, as the style.css has a space to put your styles. But I think this comes from the original HTML5 Boilerplate style file, which, in Roots, is now combined with bootstrap css...)
A simple solution would be to put your styles in app.css, which is called AFTER bootstrap.css. That's were wordpress specific styles reside.

Great, thanks Sam!
Yeah, I was a little bit confused about that.
I wonder if there's a way to make it clearer in the documentation, which currently says: "style.css is simply used to tell WordPress that we're a theme. The actual stylesheet you need to be editing is located at css/style.css"
Anyway, much thanks for your help!

So what's the file for custom styles? Both css/app.css and css/style.css are being overriden by bootstrap.css. What am I doing wrong?

Hi odysseas,
When you view the source of your page, what is the order the stylesheets are listed in your ?
App.css works for me. If you want to get a little hacky,  you can check the order of sheets in inc/roots-actions.php and bump app.css below boostrap.css

The styles are being overridden because styles.css is called BEFORE bootstrap.css, so bootstrap styles will override them, if they have the same specificity. (I agree that it might be a bit confusing, as the style.css has a space to put your styles. But I think this comes from the original HTML5 Boilerplate style file, which, in Roots, is now combined with bootstrap css...)
A simple solution would be to put your styles in app.css, which is called AFTER bootstrap.css. That's were wordpress specific styles reside.

thanks man


🐛 Bug Report: Spurious "Failed to stitch" errors in 1.33.4

📜 Description
Spurious failed to stitch errors as below. An entry already exists in the final_entities table for the entity ref and has a stitching ticket.
[1] 2024-12-09T19:20:54.758Z catalog error Failed to stitch component:default/<some unique name>, error: insert into "final_entities" ("entity_id", "entity_ref", "hash", "stitch_ticket") values ($1, $2, $3, $4) on conflict ("entity_id") do update set "stitch_ticket" = excluded."stitch_ticket" - duplicate key value violates unique constraint "final_entities_entity_ref_uniq"

👍 Expected behavior
We should not see the errors, this is new behavior upgrading from 1.32.2 to 1.33.4
👎 Actual Behavior with Screenshots
Even though we see these errors, it appears the entity is stitched properly ultimately.
👟 Reproduction steps
This will be difficult to describe how to reproduce since our environment has custom providers that emit systems/components as well as several GitHub repositories with catalog-info.yaml files that source domains, users, groups, etc.
I started from a clean database. I'd note that I've tried running several times from a fresh database and I see errors from all sources (custom provider, GitHub yamls).
📃 Provide the context for the Bug.
No response
🖥 Your Environment
1.33.4 upgrading from 1.32.2
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Related discussion: https://discord.com/channels/687207715902193673/1311275671397601341

Interesting.
This is the actual query. Right before the actual stitch operation, a random "ticket" string is to be inserted into the table as a protection against data races due to concurrent ongoing stitches. The entity_ref column (whose index now causes the reported uniqueness constraint error) is pretty new, it wasn't always there.
The thing is, in the refresh_state table that feeds all this, there should never ever exist two entities with the same entity_id OR the same entity_ref. Both have a uniqueness constraint over there too. So I'm honestly a bit unsure how it comes to be, that the stitcher could ever end up in a situation where one given entity_id being inserted could interfere with another row's entity_id because there should be a 1:1 mapping between these in the first place.
I'll have to ponder it a bit. Any help looking into it, or ideas why this might have happened, is very welcome

How about just using upsert for the ticket? At least it gets rid of the error 😄
Just wondering if running the catalog plugin on multiple nodes (like we do) can trigger this randomly when both instances process same entities 🤔

@drodil FYI, I saw this error when running ("locally") with a single node.

@jslott2sigma ok, thanks for confirming it's not because of that!


Refactor Layout component to be more friendly with tablets

Please note that most of the application (except hotels) doesn't
look good (is broken). We are focusing mainly on hotels now...
Checklist:

[x] it works in landscape and portrait mode
[x] it works offline (if possible) otherwise cacheConfig.force=true is used

How to test it: open iPad simulator and change from portrait mode to landscape mode (command + arrow left/right). Relevant only to hotels part (see Zeplin)...

Please test these changes in Expo after build has finished:

exp://exp.host/@mrtnzlml/code-review-ipad

Integrated: https://github.com/kiwicom/react-native-app/commit/8817044fb7f90bbaed2346b8bb269c0389092950
Now we can improve it! :)


Not getting past SSL configuration

Before opening, please confirm:

[X] I have checked the custom domains troubleshooting guide.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
No response
Region
Singapore
Step
SSL configuration
Status
Pending
Issue or question
The https://docs.aws.amazon.com/amplify/latest/userguide/to-add-a-custom-domain-managed-by-godaddy.html
I added the CNAME records (there is no ANAME in godaddy)
Step. 7 is not clear.
How to redirect in godaddy?
What domain to use?
Error message
No response
Additional information

Hi @MemeMaster2023 step 7 is asking you to setup domain forwarding in GoDaddy if you want to update your root domain. You can also follow these steps from GoDaddy to complete step 7: https://www.godaddy.com/help/forward-my-godaddy-domain-12123
If you're still stuck on SSL configuration after adding the proper CNAME record, please provide your App ID so we can investigate further.


Transition Google Maps plugin to use Hybrid Composition on Android

Proposal
google_maps_flutter still uses virtual displays which is incompatible with hybrid composition. This makes google_maps_flutter incompatible with any plugin that uses hybrid composition. (e.g. webview_flutter or google_mobile_ads.

Bumping the priority since it blocks users of admob. cc @bparrishMines

Marked as fixed (waiting for PR to land)


Java linter stop working

Java linter stop working, after recently update. This is the output of ALEInfo and I use neovim.
 Current Filetype: java
Available Linters: ['checkstyle', 'javac']
  Enabled Linters: ['checkstyle', 'javac']
 Linter Variables:

let g:ale_java_checkstyle_options = '-c /google_checks.xml'
let g:ale_java_javac_classpath = ''
let g:ale_java_javac_options = ''
 Global Variables:

let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%s'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_keep_list_window_open = 0
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'always'
let g:ale_linter_aliases = {}
let g:ale_linters = {'html': ['htmlhint'], 'javascript': ['eslint']}
let g:ale_open_list = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 0
let g:ale_sign_error = '⨉'
let g:ale_sign_offset = 1000000
let g:ale_sign_warning = '⚠ '
let g:ale_statusline_format = ['⨉ %d', '⚠ %d', '✓']
let g:ale_warn_about_trailing_whitespace = 1
  Command History:

It's work for other filetype like javascript with eslint. I have check with another linter plugins like neomake and run javac -Xlint manually. There're no problems.

Were any commands run at all?

Nothing, the Command History is empty.

Can you pin-point a commit where it stopped working?

I'm not sure the exact commit, but it's works on https://github.com/w0rp/ale/commit/45c2d6b580e8e4bfe73412667268c48a3034caf5#diff-4ffc1dd158437b680efcd83f1cbe4a26
and stop working on
https://github.com/w0rp/ale/commit/528355e2c6cf64fbc0d459a7a512a7823f90043d#diff-4ffc1dd158437b680efcd83f1cbe4a26

Does it work if you remove the check for if s:is_javac_an_app_store_stub? That's from a commit where I was trying to prevent certain versions of Max OSX from showing an annoying popup for Java files when you don't have Java installed.

yes, it's work. FYI, I use Sierra.

Okay, I just reverted that commit. Maybe there will be another way to solve that in future.


Mongo problem

Hello, I have pulled, install and run and I have this error:
C:\...\mern-starter-master\node_modules\mongodb\lib\server.js:267
        process.nextTick(function() { throw err; })
                                      ^
 MongoError: failed to connect to server [localhost:27017] on first connect [MongoError: connect ECO
NNREFUSED <IP_ADDRESS>:27017]
    at .<anonymous> (C:\...\mern-starter-master\node_modules\mongodb-core\lib\topol
ogies\server.js:327:35)
    at emitOne (events.js:96:13)
    at emit (events.js:188:7)
    at .<anonymous> (C:\U...\mern-starter-master\node_modules\mongodb-core\lib\conne
ction\pool.js:274:12)
    at g (events.js:286:16)
    at emitTwo (events.js:106:13)
    at emit (events.js:191:7)
    at Socket.<anonymous> (C:\...\mern-starter-master\node_modules\mongodb-core\lib
\connection\connection.js:177:49)
    at Socket.g (events.js:286:16)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at emitErrorNT (net.js:1271:8)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)

Is there any possible solution for this. Do I miss something?

Hi, to start this repo you have to start mongodb on your machine too.


Add pylint fixes

This was a suggested change by Pylint.
There are still a few others that should get resolved but this is the easy, low hanging fruit

Thanks!


remove hotspot

After calling removeHotSpot, the hotspot does not disappear from the screen, but the method returns true

That sounds like a bug, but you need to provide an example, so I can reproduce it.

Closing due to lack of response.


Playerdata API

Get persistent player data from the database in JSON by HTTPS request.
It could be useful to build dashboards and leaderboards.

If it's possible to do i can also help, but i still have to start with nodejs

@barnabwhy That's neat, i started looking at the json form of the playerdata to look for what i could get and use for the API, but without any game played on my master server i only have default values and only my account.
It could be useful to have a minimal part (like 5 to 10 accounts) of the real master server, but i have seen that there are ip addresses and i think origin tokens (didn't figure out what the id col in the database is really), so i understand i could be kind of a trouble to use

@barnabwhy i also have seen on your branch that you too have trouble with usernames, so i'm not the only one who found it strange there isn't really a proper attribute on the player table

@barnabwhy i also have seen on your branch that you too had trouble with usernames (i've seen the pull request), so i'm not the only one who found it strange there isn't really a proper attribute on the player table

I made the PR that adds username stuff, I added a comment in the player api stuff just so i don't forget i can add it once that pr is merged

@barnabwhy That's neat, i started looking at the json form of the playerdata to look for what i could get and use for the API, but without any game played on my master server i only have default values and only my account. It could be useful to have a minimal part (like 5 to 10 accounts) of the real master server, but i have seen that there are ip addresses and i think origin tokens (didn't figure out what the id col in the database is really), so i understand it could be kind of a trouble to use

id is just a uuid generated by the master server on first auth and origin tokens aren't stored. also, yes, ip addresses are stored in the table but that isn't just gonna be put on an endpoint. i'm ideally gonna make stuff that has cherry-picked properties

@barnabwhy That's neat, i started looking at the json form of the playerdata to look for what i could get and use for the API, but without any game played on my master server i only have default values and only my account. It could be useful to have a minimal part (like 5 to 10 accounts) of the real master server, but i have seen that there are ip addresses and i think origin tokens (didn't figure out what the id col in the database is really), so i understand it could be kind of a trouble to use

id is just a uuid set by the master server on first auth (origin player id) and origin tokens aren't stored. also, yes, ip addresses are stored in the table but that isn't just gonna be put on an endpoint. i'm ideally gonna make stuff that has cherry-picked properties

Yeah that's what i was thinking, there is no reason for an api to exists if you can make any sort of request, i made a little list of things you could ask to the API maybe i can write it here so we can work on them, they are mainly items and player leaderboards and single accounts stuff

Account info:

[ ] Username
[ ] Faction
[ ] Last game(s) played
[ ] Current loadout
[ ] Current titan
[ ] K/D
[ ] Most used weapon
[ ] Most kill in single match
[ ] Total kills
[ ] Total deaths
[ ] Stats per weapon (?)

I'd say it's probably better to have some of those split off into loadout and stats endpoints

I'm not sure about the leaderboard stuff, because you have to check every account, maybe i could write a script that updates a separate table every time a player ends a match, but i understand it could be a lot of resource usage

maybe a routine check or something

I'd say it's probably better to have some of those split off into loadout and stats endpoints

Yeah, it won't be much of a trouble to split it up or get everything depending on the GET request params, i've already done something similar in the past (not in JSON but with SQL queries)

maybe a routine check or something

I'm kinda new to nodejs, didn't now it is a thing

The things that my branch returns through GET requests:
/player/pdata

[x] All pdata (excluding pdiff)

Pretty much encompasses all the below and more, the other ones are for getting more specific information
This endpoint notably excludes username

/player/info

[x]  Username (if #42 gets merged)
[x]  Player id
[x]  Gen
[x]  XP
[x] Calling card
[x] Callsign icon
[x] Net worth

/player/stats

[x]  Player id
[x]  Gen
[x]  XP
[x] Credits
[x] Net worth
[x] Faction XP
[x] Titan XP
[x] FD titan XP
[x] Game stats
[x] Map stats
[x] Time stats
[x] Distance stats
[x] Weapon stats
[x] Weapon kill stats
[x] Kill stats
[x] Death stats
[x] Misc stats
[x] FD stats
[x] Titan stats
[x] KD ratio
[x] PVP KD ratio
[x] Win streak
[x] Highest win streak

/player/loadout

[x]  Faction
[x] Full active pilot loadout
[x] Full active titan loudout
[x] Full pilot loadout list
[x] Full titan loadout list

Closed by #48


Split views.py into separate files like we split models

I tend to like smaller code files; easier to navigate.
We previously split up our giant models.py into a separate folder (models) with individual .py files for each model. I think we should do something similar for views:
Some helpful links:

https://vsupalov.com/large-django-views-file/
https://stackoverflow.com/questions/1921771/split-views-py-in-several-files

This code has been running and apparently working on -test for a while now...


getFirstVisibleCfi not working with certain markup, for certain browsers

I'm using the API call "getFirstVisibleCfi" to determine whether a page has visible content or not; and if not, I display a message indicating that the page is blank.
In particular, this is not working correctly for IE11.
Consider a chapter with the following markup (press the "pencil" (edit) to view the markup):

Some Text

the "Some Text" is visible text; but the code that is executed by getFirstVisibleCfi does not find it on IE11; it does not return a CFI.  On Chrome and FF it works correctly.
It appears to be the  tag with no content that is the issue here.  I've also seen cases where there is similar markup, but instead of the span, there is an a tag ().
Hybrid app using ReadiumJS, release version (also appears in develop branch)

ping @JCCR (just in case this issue, or similar, is on your radar already)

Not sure what you meant there; should I ask JCCR if he's addressed this issue?

Sorry, that wasn't clear at all: I just "pinged" Juan Corona by mentioning him, he will get a GitHub notification :)

I have a solution for IE11 related visible CFI issues in the works.


Color picker

Color picker is fairly common use case in my web development, and I often have to open online image color picker to retrieve a color from web page or canvas element. In DevTools, Color picker functionality is available in color, background-color swatches in Elements > styles pane.

I believe adding a color picker that is easily accessible in top level UI in DevTools will be useful to developer's workflow. I added a command in a prototype, gif below. It can be added as a button in other places as well.

Great idea. I can see how this would be useful. Having something at the browser-level could be great too. I experimented with this some time ago with this browser extension btw: https://chrome.google.com/webstore/detail/eye-dropper/fjnpfdnpkpdccebgadceaieifiiblabh (source code).

I agree this is an amazing idea


Fallback for wght=1 and wght=1000?

Cairo has an ExtraBlack weight. The wght definition here seems contradictory on this as it allows 1 and 1000 but doesn’t define fallbacks for those values. Shall we add them?

For now we have been allowing them in FVAR ans STAT, but GF still doesn't support them I think for rendering issues

Wille add it to the the pipeline meeting subjects, cause at least 1000 could be supported imo.

For now we have been allowing them in FVAR ans STAT, but GF still doesn't support them I think for rendering issues

Allowing them both wght= 1 - HairLine and wght=100 - ExtraBlack in the fvar table also?
Otoh, I would advocate for:
fallback {
  name: "HairLine"
  value: 1
}
fallback {
  name: "ExtraBlack"
  value: 1000
}

So the users receive the static instances. This would be particularly helpful for projects such as Sofia Sans.
cc @davelab6

+1

Nunito Sans also needs ExtraBlack, https://github.com/googlefonts/NunitoSans/pull/14

No, we won't add them, because fall backs is about legacy system support, and legacy systems only support the 100 to 900 weights.


UX / UI Education Programs Details Page

Update to include the details Naive and Hailey have provided

After diving into the spreadsheet and updating the conceptual wireframes to match, it has been identified during UX connect a different approach that marries UX/UI, DEV and potentially business needs.
Potentially more tickets to come to align with new approach.


Merge conflicts should use outlines in high contrast

Testing #27549

create a file as described in https://github.com/Microsoft/vscode/issues/27288#issuecomment-304138928
switch to the high contrast theme
observe that background colors are used. In high contrast, borders are preferred over background colors.

Using contrastBorder color on the header, splitter and footer.

Not sure how great an idea green is here, it at least seems to contrast well with the other colors:


391 nf unique resource names

Codecov Report

Merging #423 into master will increase coverage by 0.06%.
The diff coverage is 87.09%.

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   75.05%   75.12%   +0.06%
==========================================
  Files          71       71
  Lines       10195    10222      +27
==========================================
+ Hits         7652     7679      +27
  Misses       2543     2543

Impacted Files
Coverage Δ

cate/conf/template.py
0% <ø> (ø)
:arrow_up:

cate/core/workspace.py
84.91% <100%> (+0.47%)
:arrow_up:

cate/ops/io.py
86.89% <100%> (ø)
:arrow_up:

cate/version.py
100% <100%> (ø)
:arrow_up:

cate/ds/esa_cci_ftp.py
46.27% <100%> (+0.16%)
:arrow_up:

cate/ops/plot.py
26.99% <100%> (ø)
:arrow_up:

cate/core/wsmanag.py
65.07% <100%> (ø)
:arrow_up:

cate/core/op.py
91.86% <100%> (ø)
:arrow_up:

cate/conf/defaults.py
100% <100%> (ø)
:arrow_up:

cate/webapi/wsmanag.py
28.24% <60%> (ø)
:arrow_up:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b4e7e...940e049. Read the comment docs.

@JanisGailis pls review my changes in cate.core.op - added new @op property res_prefix. Used in cate.ops.io and cate.ops.plot.
Oops, just found a "problem": the kwarg is res_prefix but the property assign is resource_prefix

@kbernat Please note that I've changed the DataStore.query(id=None, ...) into DataStore.query(ds_id=None, ...) and consistently used that first argument with its keyword.
Furthermore I've moved cate.core.ds.gete_data_stores_path() to cate.conf.conf


Fix heap buffer overflow in function yaml_emitter_emit_flow_sequence_…

…item, releated issue:https://github.com/yaml/libyaml/issues/258

Do you know how the problem can be reproduced?

As mentioned in #258, I think this shouldn't even happen, and something is wrong already before. The state machine should not get into this position. So I think this wouldn't fix it.

I think #290 is a more general fix for this

Closing this as it would only be a partial fix (same problem in yaml_emitter_emit_flow_mapping_key), and actually this code shouldn't be called anyway as it only happens when calling yaml_emitter_close after a failing yaml_emitter_dump, see comments in https://github.com/yaml/libyaml/issues/258#issuecomment-2058613931


Modifying a file causes the file to enter a never-ending loop of having the modified time changed until you restart Obsidian.

Restart Obsidian
Modify a file
Wait until the modified time changes
Wait until the next modified debounce expires
Notice that the modified time updates again
This repeats forever. (Until Obsidian is restarted)

It seems the way the files are being listened to for changes (this.app.vault.on("modify", (file) => {..etc})) is being triggered by both manual edits AND then the actual change to the frontmatter the plugin does, entering an infinite loop.
I fixed it locally with the following changes:
Track files in a grace period
constructor() {
    super(...arguments);
    this.timer = {};
    this.gracePeriod = {};
  }

Wrapping the entire body of the vault.on("modify") call with:
if(!this.gracePeriod[file.path]) {
    // original code
} else {
    this.gracePeriod[file.path] = false;
}

And changing the timeout function to do:
this.gracePeriod[file.path] = true;
// Existing code

It's not perfect as technically someone editing at just the right time would trip it up. But it's working for me so far.

I just created a brand new vault, with one file and just this plugin and it's still doing it.
Other info I can share is:

I have changed the settings of the plugin

I have changed the frontmatter property in the settings to updatedAt
I have it set to ignore a folder, Extras

Cheers, that should hopefully give me enough detail to track it down.

Thanks @mGuv , I could reproduce and this should be resolved in v1.0.4. Can you please test and let me know?

@alangrainger, no worries. Just tested a couple scenarios and all looks good.
Your plugin was the first plug-in I could find that would actually work with how I want to track files across multiple machines. All the others relying on file.ctime and file.mtime don't sync as it's all per machine based. This way I can actually commit my modified times without worry.
That's when I saw the issue as git status would keep flagging files for no reason, so I diffed them and it was the updated at time constantly changing, so took a look at the main.js file of the plugin to see what was going on and guessed it would be related to a setTimeout or setInterval so had a look for those and saw it.
Thought I'd let you know so you could fix it how you were comfortable with, so all good from me.

Fixed in #d5aa158925bd5975de5f7508a1d50e1c67435130 / v1.04

Fixed in d5aa158925bd5975de5f7508a1d50e1c67435130 / v1.04

Your plugin was the first plug-in I could find that would actually work with how I want to track files across multiple machines. All the others relying on file.ctime and file.mtime don't sync as it's all per machine based.

Exactly! Using the filesystem time just seemed silly - I'm surprised I'm the first plugin developer who wanted it this way.
Glad it's working for you now 👍


Cypress E2E Tests Failing for fetching multiple input boxes with cy.click()

What happened?
We see a subset of e2e cypress tests failing against mainline. Tests that are failing are the following:

userIsAbleToSearch
userIsAbleToUseGeofence
userIsAbleToUseTheSidebar
userIsAbleToUseTracker
userIsAbleToConnectAndDisconnectAwsAccount.

During our investigation, we found out that in these testscy.click() is trying to fetch the input box by trying to filter input boxes with [placeholder="Search"] filter. 😮 This returnes 2 input boxes. One is hidden for mobile view.
The tests fail with the following error message:
cy.click() can only be called on a single element. Your subject contained 2 elements. Pass { multiple: true } if you want to serially click each element.
We tried running the github workflow of E2E tests against mainline using gh workflow run. But the workflow_dispatch trigger is not supported for this workflow.
So, we created a dummy branch from main to run the E2E tests #84 in order to determine if the fault was coming from main. The results were consistent with the test from #83, which was our original PR and is blocked due to this.

Action Points:
We suggest the following action points:

Adding a HTML id for the desktop Search input box and amend the tests.
Ensuring that the mobile input box is not present in the HTML dom in desktop view. Adding an integration test case for this should help us from regression.
Additionally these workflows should be able to be triggered with workflow_dispatch event. We suggest to add that if there are no big red flags. :)

If the investigation and suggested action points look correct, we will go ahead and create Github issues for the suggested paths forward. Happy to hear thoughts and misses.

@mbalfour-amzn @TheRBajaj I believe the recent Cypress E2E tests have resolved this issue, I think we can close this issue now.

@TheRBajaj If you see the issue again, please open a new ticket. Thanks!