Group Operation With Result

Hi,
I'm refactoring part of my code into operations and I'm struggling with modelling a couple of scenarios.
I'll post the 1st on here then the next on a separate issue.
class CompressAssetOperation: GroupOperation, InjectionOperationType, ResultOperationType {
    var requirement:AssetConvertable?
    var result:CompressionResult?

    let asset:PHAsset
    var options:ImageCompressionOptions

    let loadDataOperation:LoadImageDataOperation
    let compressDataOperation:CompressImageDataOperation

    init(asset:PHAsset, options:ImageCompressionOptions) {
        self.asset = asset
        self.options = options

        loadDataOperation = LoadImageDataOperation(asset: asset)
        compressDataOperation = CompressImageDataOperation(options: options)
        compressDataOperation.injectResultFromDependency(loadDataOperation)

        super.init(operations:[loadDataOperation, compressDataOperation])

//        injectResultFromDependency(compressDataOperation) { op, compress, errors in
//            guard let requirement = compress.result else {
//                self.log.fatal("failed to get compressed data")
//                return
//            }
//            self.result = CompressionResult(compressedData: requirement, originalAsset: asset)
//
//        }
    }

I have the operation as above, it needs to call the LoadImageDataOperation which produces the result that gets passed into the CompressImageData operation.
The issue is that I want the CompressAssetOperation to have a result based on the compress operation, so I can then use this group operation and inject it somewhere else.
Basically what I need to do is the commented out part of my code, but if I uncomment it, none of the operations are actually executed.
Thanks for this library and any help.

Oh - this is interesting! Great question -  I haven't thought about using result injection inside a group. Let me have a think and get back to you.

Maybe I'm being silly here, but would this work?
class CompressAssetOperation: GroupOperation, InjectionOperationType, ResultOperationType {

    // etc

    var result: CompressionResult? {
        return compress.result.map { CompressionResult(compressedData: $0, originalAsset: asset) }
    }

    // etc
}

I think that might work. Very simple :)
I probably don't need the InjectionOperationType anymore in this case right ?

Yup :+1: - you can remove those commented out lines in your sample.
Also, it's probably best to move the checking of the result being nil (self.log.fatal) into the execute method of whatever operation will consume this result. I think instead, that operation should assert that it's requirement is fulfilled.

When I'm trying to add this group operation as a parameter to another in operation2.injectResultFromDependency(op), the compiler keeps complaining that I'm not passing the block to configure the dependency {op, dep, errors in }.
So i've had to do this:
 op.injectResultFromDependency(dep) {op, dep, _ in  op.requirement = dep.result }

I wonder if it would be better for this operation to not be a group operation, and instead produce those child operations with op.produceOperation()

Hmm, I think you're on the right track with it being a Group - that makes more sense.
Does operation2 conform to AutomaticInjectionOperationType?

Oh I had it just as InjectionOperationType. My bad

That's no worries - this is great feedback for me. It's a bit subtle. The InjectionResultType is basically an empty protocol, but it provides the injectResultFromDependency API with the block. And AutomaticInjectionOperationType extends this and adds the requirement property, and then you can call the same API without the block.
My thinking behind this, is that it's quite possible that an Operation will have multiple independent dependencies, and so, AutomaticInjectionOperationType is too restrictive.
But for simple A -> B -> C type dependency chains it makes everything much easier. I think?

The AutomaticInjectionOperation pretty much creates the same block as what I had to do manually so it makes sense

Yup. So it works?

Yes it does work!
As I was typing out my 2nd question I came up with a solution, so I guess I'll have to bug you again some other time :)

Great!
Yeah - feel free to create issues on here is you have questions, queries, bugs, or any problems really. I'll always try to help, and there are other contributors here that will often help out too :)
I'm gonna close this issue now if that's okay?

Ok feel free to close it.
Thanks!

:+1:


Preview and Build website in docker container

fix https://github.com/oam-dev/kubevela/issues/1665
Now we can preview website in docker container, every time you modify the related files, the change will sync automatically.
we can also build and check the correctness of docs in docker container.
Development Experience Improvement:

No need to install the node environment locally, Docker is enough.

The modification of the docs/* and sidebar.js will be automatically synchronized to the website

1. Preview Website
run make docs-start, after docusaurus ready, you can preview the website by http://localhost:3000/
$ make docs-start
docker run -it -p 3000:3000 -v /Users/yangs/Project/oam.dev/kubevela/docs/sidebars.js:/workspace/kubevela.io/sidebars.js \
	 -v /Users/yangs/Project/oam.dev/kubevela/docs/en:/workspace/kubevela.io/docs \
	 yangsoon/kubevela.io:v1 -t start
update kubevela.io
From https://github.com/oam-dev/kubevela.io
 * branch            main       -> FETCH_HEAD
 * [new branch]      main       -> origin/main
start docs
yarn install v1.22.5
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
Done in 84.79s.
yarn run v1.22.5
$ docusaurus start --host <IP_ADDRESS> --port 3000
Starting the development server...
Docusaurus website is running at: http://localhost:3000/

✔ Client
  Compiled successfully in 25.69s

2. Test Build
make docs-build will check the correctness of the link, please refer to https://github.com/oam-dev/kubevela/blob/master/docs/README.md for link writing rules
make docs-build
docker run -it -v /Users/yangs/Project/oam.dev/kubevela/docs/sidebars.js:/workspace/kubevela.io/sidebars.js \
	 -v /Users/yangs/Project/oam.dev/kubevela/docs/en:/workspace/kubevela.io/docs \
	 yangsoon/kubevela.io:v1 -t build
update kubevela.io
build docs
yarn install v1.22.5
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
Done in 80.03s.
yarn run v1.22.5
$ docusaurus build
Site will be built for all these locales:
- en
- zh
[en] Creating an optimized production build...
✔ Client
✔ Server
  Compiled successfully in 1.62m
✔ Client
✔ Server
Compiled successfully in 1.19m
Success! Generated static files in build.
[zh] Creating an optimized production build...
✔ Client
● Server █████████████████████████ cache (99%) shutdown IdleFileCachePlugin
 stored

Success! Generated static files in build/zh.
Use `npm run serve` to test your build locally.
Done in 236.78s.

You can see the docker image details here https://github.com/yangsoon/kubevela-website

That's great.
Could you please keep the old-fashioned way which I prefer to do the preview. As my laptop will become noisy when the docker starts up.

sure I will keep the old-fashioned way in hack/website, please pending util I restoret he old-fashioned way

the docker image yangsoon/kubevela.io:v1 is a private docker image at @yangsoon, I think not controllable, unoffical, and the user may want how to build it, where its dockerfile.

the docker image yangsoon/kubevela.io:v1 is a private docker image at @yangsoon, I think not controllable, unoffical, and the user may want how to build it, where its dockerfile.

yes, we should opensource the dockfile and move the image into oamdev docker hub org.


PCB cutout not included

Describe the bug
PCB cutout not included when creating footprint
To Reproduce
Steps to reproduce the behavior:

Load part C559118 in EasyEDA, use 3D viewer to see a cutout in the part
Create footprint with this lib, and load into KiCad. There is no hole

Expected behavior
I would expect the lib to also be able to include cutouts in the parts
Screenshots
EasyEDA:

KiCad:

i'm not sure it's an issue with this script but with Kicad himself.

Hi, thanks for reporting this.
It is indeed missing as EasyEDA consider the cutout as not just a regular shape on the Edge.Cuts layer, but as a solidregion which was not handled.
I added a handler for the simple polygons cutouts, unfortunately I do not have the time to look deeper into it and try to understand the logic of how EasyEDA parse the more complex shapes.
The polygons function correctly once they are placed on a board, but the 3D preview may not display correctly in some instances. I am unsure of the reason for this issue :
footprint 3D preview :

PCBnew 3D viewer :

Help would be greatly appreciated to handle more complex shapes and solve the previous issue.
The component  C2687297  contains shapes that can be used to work on this.
If you are want to help, the current handler can be found in the footprint handler file :
https://github.com/TousstNicolas/JLC2KiCad_lib/blob/fd492d0f21c526d10292b3d26dc50af3f3c9b13f/JLC2KiCadLib/footprint/footprint_handlers.py#L329-L337

Thanks for you effort! I will check out the new version when I have time. Maybe if I have time in the future, and feel the need, I will investigate


feat: tools to convert ION jwk to hex and encrypt/decrypt data with ION key

This pull request includes two parts

Convert jwk to hex
ION DID adopts jwk format.
However, we know blockchain account key is hex format and hex format can be used with many libraries(like bitcoinjs-lib).
So, easy methods to convert ion jwk to hex will provide more utilites for those who wants to find more usage in ION.
Encrypt/decrypt data with ION keys
DID issues VC and holder needs to get VP from VC.
ION needs to include highly confidential info regarding holder's credential.
So, methods to encrypt data with ION public key(so that can be decrypted only with its private key) could be very useful.
DID holder can encrypt data and add it on his own ION DID, or a lot else.
ECIES is implemented, which is known for high security.

It supports for ECDSA ION key.
If merged, I will try to add EDDSA support.


Pose Refinement Error

Hi, there are  few issues with refinement. First issue has already been reported (key error: ["coord_x"]). I resolved that by adding "or cfg.TEST.USE_DEPTH_REFINE" on line 203 of GRDN_double_mask. I now have another issue:

File "/gdrnpp_bop2022/core/gdrn_modeling/../../core/gdrn_modeling/engine/gdrn_evaluator.py", line 543, in process_depth_refine
    query_img_norm = query_img_norm.numpy() * ren_mask * depth_sensor_mask_crop
                     │              │         │          └ array([[False, False, False, ...,  True,  True,  True],
                     │              │         │                   [False, False, False, ...,  True,  True,  True],
                     │              │         │                   [False...
                     │              │         └ array([[False, False, False, ..., False, False, False],
                     │              │                  [False, False, False, ..., False, False, False],
                     │              │                  [False...
                     │              └ <method 'numpy' of 'torch._C._TensorBase' objects>
                     └ tensor([[0.0402, 0.0875, 0.1061,  ..., 0.1182, 0.1044, 0.0653],
                               [0.0913, 0.1657, 0.1896,  ..., 0.2083, 0.1792, 0.1090...

ValueError: operands could not be broadcast together with shapes (64,64) (256,256)

It seems that the depth_sensor_mask crop is (256,256), while the other two tensors are (64,64)
how do I solve this?

I am getting the same error when adding "or cfg.TEST.USE_DEPTH_REFINE", and without that I get the "coor_x"  error. I'd be  interested in a way to solve this too

I managed to solve this by resize the depth_sensor_crop, and it seems working fine.
depth_sensor_crop = _input['roi_depth'][inst_i].cpu().numpy().copy().squeeze()
depth_sensor_crop = cv2.resize(_input['roi_depth'][inst_i].cpu().numpy().copy().squeeze(), (64, 64))

Thank you @tzsombor95, its seems working fine for me too.


TOC Candidate Nomination for Stephan Merker

Candidate Name: Stephan Merker (@stephanme)
Affiliation: SAP
Nomination Statement:
Stephan has been active in the Cloud Foundry community for the past 6+ years. He is very active in Github issues, Slack conversations and has been contributing pull requests to Cloud Foundry.
He has been looking into and trouble-shooting issues with Cloud Foundry at scale in areas like Cloud Controller/CAPI, Diego, Loggregator, observability and monitoring of both Cloud Foundry itself as well as Cloud Foundry applications, cf-deployment, blobstore integration, Concourse, documentation and many more.
With his broad areas of expertise, Stephan is probably one of the people who has the broadest view on how Cloud Foundry is operated and being used by developers productively as he is the product owner of one of the SAP teams responsible for operating some of the biggest Cloud Foundry deployments world-wide on a broad set of IaaS infrastructures.

Acknowledged and confirmed to meet TOC nominee criteria.


FFI Module

Contains the development of the FFI module

One other thing that would be good would be a test that requires this file just to make sure there are no parsing errors.

I'm not sure you should test this on the llvm backend yet. I suspect that the test will fail to link. Just use the ocaml backend for now and we'll update it once we implement the hooks


Proposal: Grafana 7.0 Logo

Grafana 7.0 will be released soon. A new matching logo would be cool.
Unfortunately I dont know which file has to be changed. That is why I have not opened a Pull Request.
I made this with draw.io.
<?xml version="1.0"?>
<svg width="64" height="64" xmlns="http://www.w3.org/2000/svg" xmlns:svg="http://www.w3.org/2000/svg">

 <g class="layer">
  <title>Layer 1</title>
  <g id="svg_1">
   <path d="m28,32l2,0" fill="none" id="svg_2" stroke="#84aff1" stroke-miterlimit="10" stroke-width="2"/>
   <rect fill="none" height="12" id="svg_3" rx="1.8" ry="1.8" stroke="#f9b11f" stroke-width="3" width="24" x="2" y="26"/>
   <rect fill="none" height="12" id="svg_4" rx="1.8" ry="1.8" stroke="#f3cb0d" stroke-width="3" width="24" x="38" y="14"/>
   <rect fill="none" height="12" id="svg_5" rx="1.8" ry="1.8" stroke="#ff9a2f" stroke-width="3" width="24" x="38" y="38"/>
   <path d="m32,6.5l0,50.15" fill="none" id="svg_6" stroke="#3865ab" stroke-miterlimit="10" stroke-width="3"/>
   <ellipse cx="32" cy="4" fill="#3865ab" id="svg_7" rx="2.5" ry="2.5" stroke="#3865ab" stroke-width="3"/>
   <path d="m32,60.65l-2,-4l4,0l-2,4z" fill="#3865ab" id="svg_8" stroke="#3865ab" stroke-miterlimit="10" stroke-width="3"/>
   <path d="m34,20l2,0" fill="none" id="svg_9" stroke="#84aff1" stroke-miterlimit="10" stroke-width="2"/>
   <path d="m34,44l2,0" fill="none" id="svg_10" stroke="#84aff1" stroke-miterlimit="10" stroke-width="2"/>
  </g>
 </g>
</svg>

Nice ! Good idea

The files ares in src/img

What is the use case for the files in dist/img?

src file moved to build after build

I posted it on twitter to know advice of users

Closed in #158. Thanks!

Welcome to the project


Create table of contents

In the final PDF a table of contents need to be created.

This was pretty pretty easy, see 976cec8.
The real question is: how should the toc be designed (@elbotho)? The style can be set directly via commands in the latex_template.tex.

I close this issue. For the design we have #33


[Community] Fix PR labeling github action workflow

Proposed changes
My change is the fix and improvement for github action which labels approved PRs (introduced in this PR).
It is inspired by solution introduced and tested in Apache Airflow (thanks @potiuk @ashb 🚀 )
Corresponding Apache Airflow workflows on which I based this PR:

https://github.com/apache/airflow/blob/main/.github/workflows/label_when_reviewed.yml
https://github.com/apache/airflow/blob/main/.github/workflows/label_when_reviewed_workflow_run.yml

Problems which were solved in this PR:

Permissions.
@morningman opened a related bug: [Help] Error: Resource not accessible by integration. It is related to limited permissions of workflows being triggered by pull_request_review (GITHUB_TOKEN has read-only permissions). More information about it you can find in the article:  Keeping your GitHub Actions and workflows secure: Preventing pwn requests.
TL;DR:  On pull request review event (on: pull_request_review ) "dummy" workflow Label when reviewed triggers another workflow Label when approved workflow run which has sufficient permissions (on:  workflow_run:  workflows: ["Label when reviewed"]).

Safe use of 3rd-party Github Actions by using submodules pattern.  It is decribed in:
https://cwiki.apache.org/confluence/display/BUILDS/GitHub+Actions+status

NEVER use 3rd-party actions directly in your workflows - use the "submodule" pattern.

This pattern is successfully used by projects like:

Apache Airflow (PR)
Apache Beam (PR)
Apache Superset (PR)

Types of changes
What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
[ ] Code refactor (Modify the code structure, format the code, etc...)
[ ] Optimization. Including functional usability improvements and performance improvements.
[ ] Dependency. Such as changes related to third-party components.
[x] Other.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
[ ] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If these changes need document changes, I have updated the document
[ ] Any dependent changes have been merged

I will add description and then ping for reviews.

I will add description and then ping for reviews.

Great, thank you very much for your help!

I have updated description. Ready for review.
cc @morningman  @EmmyMiao87

Thanks @TobKed , it works!

hi @TobKed, I am a developer from the Apache APISIX community and I have a similar question.
Sorry for taking your time, I would like to ask a question, do I need to give GITHUB_TOKEN write permission to post comments elsewhere in Github Action?

Hi @tzssangglass , I am happy to help you.
If undestrand you question correctly, there is no need for any additional configuration.
GITHUB_TOKEN permissions are set here: https://github.com/apache/incubator-doris/blob/c2520c878c3d827e27c32f1dab5e5953a25b52e7/.github/workflows/approve-label.yml#L24
I am pretty sure if you introduce to APISIX  same changes as in in this PR it should work out of the box.
If you need any help with it or some problems occurs do not hesitate to contact me.
Edit: I've checked https://github.com/apache/apisix/pull/6136 and I think the problem which you relates to there is solved here as well: important thing here is that labelling consists of two workflows:

https://github.com/apache/incubator-doris/blob/master/.github/workflows/approve-label-trigger.yml
https://github.com/apache/incubator-doris/blob/master/.github/workflows/approve-label.yml

where first one just triggers second one. Reason for that is described here: Preventing pwn requests. In your case you may need to adjust permissions (https://github.com/apache/incubator-doris/blob/c2520c878c3d827e27c32f1dab5e5953a25b52e7/.github/workflows/approve-label.yml#L24). This article may be helpful: Permissions for the GITHUB_TOKEN

Hi @TobKed .Are two action modules necessary?

Hi @TobKed .Are two action modules necessary?

According to my knowledge they are necessary, however not sure if something change during last year :)


tags and categories template

links for tags and categories in .extra. …
--with optional postcount.
tag and categories template.
fix in google analytics for pjax.

Can you not merge 'no message' commit (9ac75be99db1efc674b9a7c07e54ae11eb8e08ea)?
I dont know how its in here, since I already undid the changes on the files several commits back...


Add simdjson dependency to libvast.

:notebook_with_decorative_cover: Description
Integrate simdjson into CMake build setup.
:memo: Checklist

[ ] All user-facing changes have changelog entries.
[ ] The changes are reflected on docs.tenzir.com/vast, if necessary.
[ ] The PR description contains instructions for the reviewer, if necessary.

:dart: Review Instructions

@ngrodzitski I'll cherry-pick this onto the base branch tomorrow. CI changes are not picked up external contributors. We're very busy with this months' release today.


Add profile management into STS

We can use Scaffold Identity:

https://docs.microsoft.com/en-us/aspnet/core/security/authentication/scaffold-identity?view=aspnetcore-2.2&tabs=visual-studio

Or use MVC version

https://github.com/damienbod/IdentityServer4AspNetCoreIdentityTemplate

@skoruba
Just a quick heads-up.
There is a little issue on scaffolder.
All projects must use C# 7.0 or less to be able to run scaffolder.
Then can be switched to C# 7.0+.
Can be problem if default literal was used throught project (haven't noticed it).
I will see to integrate it and send a PR request in free time since I already have something like that in an older project (but it's upgraded to IS4 2.3 and .NET Core 2.2) :)

@duki994 - Please, take a look at this PR: https://github.com/skoruba/IdentityServer4.Admin/pull/161

We are working on it. :)
Thank you.

Done on master.


'Unable to extract %s' % _name'

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2020.01.24
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

❯ youtube-dl  --verbose --all-sub --cookies cookies.txt "https://www.ondemandkorea.com/youns-kitchen-season-2-e1.html"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', '--all-sub', '--cookies', 'cookies.txt', 'https://www.ondemandkorea.com/youns-kitchen-season-2-e1.html']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.01.24
[debug] Python version 3.6.9 (CPython) - Linux-5.3.0-28-generic-x86_64-with-Ubuntu-18.04-bionic
[debug] exe versions: ffmpeg 3.4.6, ffprobe 3.4.6
[debug] Proxy map: {}
[debug] Using fake IP <IP_ADDRESS> (CA) as X-Forwarded-For.
[OnDemandKorea] youns-kitchen-season-2-e1: Downloading webpage
ERROR: Unable to extract jw config; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/youtube_dl/YoutubeDL.py", line 796, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/lib/python3.6/dist-packages/youtube_dl/extractor/common.py", line 530, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/lib/python3.6/dist-packages/youtube_dl/extractor/ondemandkorea.py", line 52, in _real_extract
    webpage, 'jw config', group='options'),
  File "/usr/local/lib/python3.6/dist-packages/youtube_dl/extractor/common.py", line 1005, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract jw config; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

Tried different web browsers (firefox, chrome, brave) to download cookies with cookies.txt extension.
Replaced new lines with '\n'
Tried with and without VPN
Haven't tried it on different OS

Same error

Same here I think, cant use it at all. Tried multiple links with multiple options


Add missing shader debug documentation

Introduced by #73588, fixes CI

Filling in these descriptions

Oh no worries! I didn't quite know what to fill into those and very appreciated

Everything should be ready

Thanks!

Thank you!


Remove dead transform/ code

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1043
Originally created by @mbergeron on 2019-09-25 12:43:32

As seen in https://gitlab.com/meltano/meltano/merge_requests/914#note_221766248 there is some leftover code in transform/ that is unneeded.
We should remove dead code.

View 2 previous comments from the original issue on GitLab


~access shouldn't be on persistent storage

resolution_fixed   |    by<EMAIL_ADDRESS>
The contents of /projects/access are downloaded from a subversion repo, it doesn't need to be persistent.

Issue migrated from trac:36 at 2024-01-31 17:11:25 +1100

<EMAIL_ADDRESS>changed resolution from `` to fixed

<EMAIL_ADDRESS>commented

Looks like it's not- only /projects/access.dev is mounted on NFS

<EMAIL_ADDRESS>changed status from new to closed

<EMAIL_ADDRESS>commented

Milestone Future deleted

<EMAIL_ADDRESS>removed milestone (was Future)


add custom_header variable to send custom headers to origin

what

Adds the ability to specify custom headers that are sent to the origin for requests

why

To facilitate the common pattern of only allowing traffic to origins that come form a certain CloudFront CDN, or for other use cases

references
closes #46

/test all

Seems to have failed bats with:
ERROR: unsatisfiable constraints:
  json2hcl (missing):
    required by: world[json2hcl]
make: *** [Makefile.alpine:4: deps] Error 1
Error: Process completed with exit code 2.

@osterman any chance we can retest this?

/test bats

@mihaiplesa thanks for your contribution!

Credit goes to @bkero here at Brave. Thanks for helping on a Sunday!

@mihaiplesa my mistake!
Thanks for the PR @bkero !


Add more tracing

We need to add some more jaeger tags to tsdb to:

Record the referrers (to get the dashboard)
Client IP from the X-Forwarded-For header

note that we can't enable jaeger for tsdb currently due to https://github.com/raintank/tsdb-gw/issues/62
but as tsdbgw is just a proxy, I think that should be fine.. as long as gw proxies to mt, but in most deployments it proxies to graphite


Menu System groups

For consistency, there should be a way to group menu profiles so that they do not need to be redefined if used within another part of the system

This is not needed, and more info needs to be given in any case


Optional pre-indexing rollup job as part of Hadoop indexing

See also: https://groups.google.com/d/topic/druid-user/FjU68ZoQ4OM/discussion
The problem is that for datasets where rollup is really effective, we can funnel a huge amount of data through each reducer. Rollup ratios of 100:1 or 1000:1 are not unheard of. This creates a bottleneck in the IndexGeneratorJob.
Possible solution,

add an optional job before IndexGeneratorJob that pre-aggregates your data and writes it to a tmp location, using as many reducers as necessary
teach the IndexGeneratorJob how to operate on that pre-aggregated data (should be skipping a bunch of things it would have done, and reading from that tmp location instead of your actual data location)
add a config to enable the extra pre-aggregation job
bonus: possibly also enable pre-aggregation automatically if the determine-partitions job determines that the rollup ratio is above a certain threshold

Wouldn't it be possible to have the map task do a rollup on its data? This way a lot less data will hit the reducer.

Ah, that is already an option, you can try that to see if it's enough for your dataset. I guess it depends on how much data you're sending through each mapper. You can turn that on by setting useCombiner to true in your tuningConfig.

erikdubbelboer  @gianm I believe "useCombiner" should be able to handle this. ( doc http://druid.io/docs/0.8.3/ingestion/batch-ingestion.html )

@himanshug It did, as I wrote in https://groups.google.com/forum/#!topic/druid-user/TvwIBUEzqwM it made things much much faster and better.


Build issues with version 0.20.0

I am having build issues wit the latest release of xtensor-python (0.20.0)
and xtensor (0.17.4) / xtl (0.4.16).
The lines
#define FORCE_IMPORT_ARRAY
#include "xtensor-python/pyarray.hpp"

are causing:
                 from /home/cpape/Work/software/src/z5/src/python/lib/z5py.cxx:7:
/home/cpape/Work/software/conda/miniconda3/envs/z5-bld/include/xtensor/xiterator.hpp: In function ‘constexpr auto xt::detail::trivial_begin(C&)’:
/home/cpape/Work/software/conda/miniconda3/envs/z5-bld/include/xtensor/xiterator.hpp:406:25: error: ‘xtl::mpl’ has not been declared
             return xtl::mpl::static_if<has_storage_iterator<C>::value>([&](auto self)
                         ^~~
/home/cpape/Work/software/conda/miniconda3/envs/z5-bld/include/xtensor/xiterator.hpp: In function ‘constexpr auto xt::detail::trivial_end(C&)’:
/home/cpape/Work/software/conda/miniconda3/envs/z5-bld/include/xtensor/xiterator.hpp:418:25: error: ‘xtl::mpl’ has not been declared
             return xtl::mpl::static_if<has_storage_iterator<C>::value>([&](auto self)
                         ^~~
/home/cpape/Work/software/conda/miniconda3/envs/z5-bld/include/xtensor/xiterator.hpp: In function ‘constexpr auto xt::detail::trivial_begin(const C&)’:
/home/cpape/Work/software/conda/miniconda3/envs/z5-bld/include/xtensor/xiterator.hpp:430:25: error: ‘xtl::mpl’ has not been declared
             return xtl::mpl::static_if<has_storage_iterator<C>::value>([&](auto self)
                         ^~~
/home/cpape/Work/software/conda/miniconda3/envs/z5-bld/include/xtensor/xiterator.hpp: In function ‘constexpr auto xt::detail::trivial_end(const C&)’:
/home/cpape/Work/software/conda/miniconda3/envs/z5-bld/include/xtensor/xiterator.hpp:442:25: error: ‘xtl::mpl’ has not been declared
             return xtl::mpl::static_if<has_storage_iterator<C>::value>([&](auto self)
                         ^~~

I am using Ubuntu 18.04 and gcc 7.3.
Note that this error does not occur with xtensor-python (0.19.1), xtensor (0.16.4) and xtl (0.4.16)

Thanks for reporting!
The following workaround should fix your issue, we'll release a version with a fix soon.
#include "xtl/xmeta_utils.hpp"
ine FORCE_IMPORT_ARRAY
#include "xtensor-python/pyarray.hpp"

The workaround fixed it, thanks!

We have released 0.20.1 with a fix for this issue.


make it so that you can shift click on a ladder to place above/below it depending on the half of the ladder you click on?

handy for creating ladders from above a drop where you can't reach the underside of the ladder to place more

sorry for not answering so long, thats definetly a nice idea!
although i won't implement it b/c for me this mod is supposed to be just a decorative building helper, changing as little vanilla behavior as possible. Also i wouldnt even know where to begin trying to implement that lol
there is https://modrinth.com/mod/better-ladder-placements for forge though, maybe ask them if they can replicate it for fabric?


fix: consistent naming across render function/button

This PR proposes a change in the "render Word" button and related function to make it consistent with the other button/formats, i.e., "PDF" and "HTML" are the formats, while "Word" is the software, thus "DOCX" would be the consistent name.
This could also help clarify that this is the formats not a type of document.
Partially related to some of the following discussion: https://github.com/quarto-dev/quarto-cli/discussions/2234

Thanks!


BuiltinFunctionType and BuiltinMethodType are different

Feature
types.BuiltinFunctionType must be equal to types.BuiltinMethodType.
In other word, types returned by builtin function and types returned by builtin method must be of the same type.
In CPython
>>> import types
>>> types.BuiltinFunctionType == types.BuiltinMethodType
True
>>> type(len) == type([].append)
True

In RustPython
>>>>> import types
>>>>> types.BuiltinFunctionType == types.BuiltinMethodType
False
>>>>> type(len) == type([].append)
False

Python Documentation
BuiltinFunctionType and BuiltinMethodType have same descriptions.
Also, commented at source code.

This issue does not matter anymore.
>>>>> import types
>>>>> types.BuiltinFunctionType == types.BuiltinMeth
odType
False
>>>>> type(len) == type([].append)
False

I'm working on this issue. I left this comment to avoid task conflicts.

I'll take a look!

Maybe, we can adapt the optimization idea but not about the exact types.
CPython internally uses PyCMethod but expose it as PyCFunction. I think that will be very tricky in rust.

Partially resolved by #4873
I decide not to strictly follow CPython implementation for this behavior. We expose BuiltinMethodType to user.


Rename Datasette.init(config=) parameter to settings=

While I'm doing this I should rename this internal variable to avoid confusion in the future:
https://github.com/simonw/datasette/blob/e837095ef35ae155b4c78cc9a8b7133a48c94f03/datasette/app.py#L203

Originally posted by @simonw in https://github.com/simonw/datasette/issues/1431#issuecomment-898072940

Also this method: https://github.com/simonw/datasette/blob/77f46297a88ac7e49dad2139410b01ee56d5f99c/datasette/app.py#L422-L424
And the places that use it:
https://github.com/simonw/datasette/blob/fc4846850fffd54561bc125332dfe97bb41ff42e/datasette/views/base.py#L617
https://github.com/simonw/datasette/blob/fc4846850fffd54561bc125332dfe97bb41ff42e/datasette/views/database.py#L459
Which is used in this template: https://github.com/simonw/datasette/blob/77f46297a88ac7e49dad2139410b01ee56d5f99c/datasette/templates/table.html#L204

This is going to break some plugins: https://ripgrep.datasette.io/-/ripgrep?pattern=config%3D&literal=on&glob=!datasette%2F**
I should fix those as soon as this goes out in a release. I won't close this issue until then.

It's only datasette-publish-vercel that will break the actual functionality - the others will have broken tests.

@simonw I am getting the below issue again now, even after removing branch argument from vercel datasette plugin
module initialization error: init() got an unexpected keyword argument 'config'
module initialization error
init() got an unexpected keyword argument 'config'

Resolved, with assistance from @ashishdotme (Thank you!)
Updated requirements.txt to include:
datasette==0.59
datasette-publish-vercel==0.11
sqlite-utils==3.6

Ran:
$ pip3 install -r requirements.txt

The site is back at work! Yay!

This issue is obsolete thanks to the new metadata v.s. config change in Datasette 1.0.


Height for the single element in row

I have a One item in a row, and it is not giving height to that item. Can we give height to that item? It seems it gives height to the elements if there are only two or more items in the row.
Thanks

This is intentional when you're using the byRow option, can you should try setting it to false?

Hi! I have the same issue, I need the height to be applied even when there is only one element in a set. I am using vertical centering solution inside the element that does not work if the height is not explicitly set.
I understand why you made it like this, but an option to turn this behavior on/off would be great.
Thanks for the plugin, it's great!

A temporary solution that worked for me was changing the line 127:
from:
if (this.length <= 1 && !opts.target) {
to this:
if (this.length <= 0 && !opts.target) {

This feels like something you should just write your own additional code for, since the reason you need an explicit height is not related to matching heights of multiple elements?

Yeah, it's highly debatable, I can see the pros and cons. Honestly, I don't know if it's worth adding for everyone since I am biased by my particular use case.
Are there any downsides if you would simply change 1to 0 in your code for everyone? I don't see the big picture but you might know better.
I understand there is no point in matching heights when there is only one element in a set but let's say you did that, would it create any problems for people that I can't foresee?

+1 for this. I have a set of elements which wrap onto multiple lines based on the screen size. Each contains an image div which has matchHeight called on it, and the position: relative; top:50%; transform:translateY(-50%) trick to center the images vertically.
When items wrap so that there is a single item on a row, that item doesn't have a height set, which breaks the CSS trick.


Add missed libraries' check headers.

Official Windows builds of Boost have internal implementation for zlib and bzip2 libraries used by Boost::iostreams. Adding headers check would suppress the "No header defined for…"
warning.

Cc: @rleigh-dundee

My first question would be exactly how you are using FindBoost to get such an error?  We don't expose the internal embedded zlib or bzip2 at the moment; there is no mention of zlib or bzip2 in the iostreams dependencies or anywhere else.  Are you specifically invoking find_package with zlib or bzip2 as component names?
The current design of FindBoost is that each component is a library.  With your build, do you have boost_zlib and boost_bzip2 DLLs or static libs?  If so, I can see that this change would be useful.
However, I would caution that it also makes your program non-portable since these components will not exist on any other platform.  And they might not even exist on Windows.  (I, for example, build zlib and bzip2, then build boost with these DLLs.  This means my use of FindBoost works across every platform.)
Regarding that portability aim, would it make sense to add support to FindZLib and FindBZip2 to also check for the Boost variant as fallbacks?  If it's drop in compatible with the regular zlib and bzip2 headers and library API/ABI, that would allow you to use find_package with ZLib and BZip2 portably, so that your code will work on Windows with the boost versions, and everywhere else with the regular standalone versions.
That said, the change itself looks completely harmless since it won't be used unless these Windows-specific components are explicitly requested, and so I wouldn't have any reservations about merging this once the question above regarding the intent has been clarified.
Regards,
Roger

My first question would be exactly how you are using FindBoost to get such an error? We don't expose the internal embedded zlib or bzip2 at the moment; there is no mention of zlib or bzip2 in the iostreams dependencies or anywhere else. Are you specifically invoking find_package with zlib or bzip2 as component names?

Yes, I do. My project uses iostreams w/ gzip filters, so my find_package() contains it. But, I've faced w/ link errors:

in *nix systems I also have to call find_package(ZLIB) before boost (cuz it uses external implementation) and add it to target_link_libraries() among other boost libs
but in windows, I use BOOST_ALL_NO_LIB, so I've add zlib as a component to search and use Boost::zlib to link with

The current design of FindBoost is that each component is a library. With your build, do you have boost_zlib and boost_bzip2 DLLs or static libs?

I use official Windows prebuilt binaries. And yes, I have that libs:
<EMAIL_ADDRESS>ls *zip*
boost_bzip2-vc140-mt-1_59.dll     boost_bzip2-vc140-mt-gd-1_59.lib     libboost_bzip2-vc140-mt-s-1_59.lib    libboost_bzip2-vc140-sgd-1_59.lib
boost_bzip2-vc140-mt-1_59.lib     libboost_bzip2-vc140-mt-1_59.lib     libboost_bzip2-vc140-mt-sgd-1_59.lib
boost_bzip2-vc140-mt-gd-1_59.dll  libboost_bzip2-vc140-mt-gd-1_59.lib  libboost_bzip2-vc140-s-1_59.lib

<EMAIL_ADDRESS>ls *zlib?*
boost_zlib-vc140-mt-1_59.dll     boost_zlib-vc140-mt-gd-1_59.lib     libboost_zlib-vc140-mt-s-1_59.lib    libboost_zlib-vc140-sgd-1_59.lib
boost_zlib-vc140-mt-1_59.lib     libboost_zlib-vc140-mt-1_59.lib     libboost_zlib-vc140-mt-sgd-1_59.lib
boost_zlib-vc140-mt-gd-1_59.dll  libboost_zlib-vc140-mt-gd-1_59.lib  libboost_zlib-vc140-s-1_59.lib

But I use only static libraries of Boost…

However, I would caution that it also makes your program non-portable since these components will not exist on any other platform.

Yeah, as I described above, in non Windows, I have to use FindZLIB, but Windows build uses boost_zlib library available in official build -- and thanks to CMake it is easy to define a seamless build process ;)

I, for example, build zlib and bzip2, then build boost with these DLLs. This means my use of FindBoost/FindZLib/FindBZip2 works across every platform.

Unfortunately I can't afford this way… My goal is to minimize efforts on deploy "build environment" -- it is why I prefer pre-built binaries.

Regarding that portability aim, would it make sense to add support to FindZLib and FindBZip2 to also check for the Boost variant as fallbacks?

As I told above, I don't have builds of ZLIB/BZIP2 in Windows… its just another dependency which I have to track/build/deploy to compile cluster and inform other developers that they have to get and install "just another small package". No reason to do that, if Boost already contains all that I need.

If it's drop in compatible with the regular zlib and bzip2 headers and library API/ABI, that would allow you to use find_package with ZLib and BZip2 portably,

In my case it is "cheaper" to use a bit more CMake code to choose depending on platform what to find and what to link with at build time, than having a pure portable way...

@rleigh-dundee, @bradking,
Am I answer all questions of smth else remains? (I have another patch to FindBoost.cmake pending for PR and just waiting when this will be closed %)

@zaufi I have no objections to this being merged.
However, I think there's still a significant missing piece.
Are you using these libraries directly, or are you using them indirectly via boost.iostreams?
For the latter, there's clearly the need for a proper library dependency so that this stuff works automatically by linking with Boost::iostreams.  The complication is that we don't know whether to link with the system zlib/bzip2 or the boost-provided versions (or is there?).  Certainly on Windows, it could be either.  We could certainly add logic to check for the presence of both the system and embedded versions and then add the appropriate dependencies.  We already do this for Boost::threads on Threads::Threads.
Regarding the last question "Regarding that portability aim, would it make sense to add support to FindZLib and FindBZip2 to also check for the Boost variant as fallbacks?", to which you answered "As I told above, I don't have builds of ZLIB/BZIP2 in Windows… its just another dependency which I have to track/build/deploy to compile cluster and inform other developers that they have to get and install "just another small package". No reason to do that, if Boost already contains all that I need." I think you might have misunderstood what I was asking here.  I'd like for this to be completely transparent and work uniformly across all platforms.  I wasn't suggesting that you should install anything.  Merely that the find_package macros should search for both the standalone and boost variants to make this uniform and functional across all platforms, which is what I'm also asking above with regard to exactly how you are using these libraries (direct or indirect via iostreams).  It might be better to do this in the reverse, if the only case to cater for is indirect use via iostreams, by adding the appropriate dependencies to Boost::iostreams.

Are you using these libraries directly, or are you using them indirectly via boost.iostreams?

The only way for me is to use them directly. First of all, a project I worked on, uses static Boost libraries and have BOOST_ALL_NO_LIB.
The other side of the "problem" -- to use or not to use gzip filters of boost::iostreams is a configuration option of this project, so depending on it, I have to add (or not) boost::zlib to target_link_libraries() (and #define HAVE_GZIP_FEATURE at compile time) . So, I'm really in doubt how FindBoost.cmake can help me here in a "smart way"… In the case I've described, depending on the project option (and thanks to static libraries) I use boost::iostreams with or without ZLIB/BZIP2, so how the finder could guess: should it (or shouldn't) find that libs for me… -- it looks too complicated, so simplest (easiest and explicit) solution is to find and add that libs when they really needed.

Sorry, my question was ambiguous.  Are you using the boost zlib or bzip2 headers in your own code or are you using the higher-level iostreams classes?

@rleigh-dundee, the project uses boost::iostreams headers only, and #include gzip support conditionally.

Thanks, folks.  Applied as commit cb1a434ce093ea2530a7acd5692f4da8cfb9f8aa.


[Draft] support k8s cluster

Summary
Support K8s system.
Test Plan
Submit sleep job:
cloudai    --mode run    --system-config conf/system/kubernetes_cluster.toml    --test-templates-dir conf/test_template
   --tests-dir conf/test    --test-scenario conf/test_scenario/sleep.toml

Check jobs in k8s cluster:
kubectl get job
NAME      COMPLETIONS   DURATION   AGE
tests-1   1/1           13s        18s
tests-2   1/1           8s         13s
tests-3   1/1           8s         13s
tests-4   0/1           18s        18s

Additional Notes
Some configuration is hard code and there some functions that have not been implemented(such as getting job status and running time, etc).

@TaekyungHeo  I update the code to support check whether the job is running.
BTW, is there are big differences between jobs in different frameworks in K8s. So I think we need a json_gen_strategy class to handle the job in different framwork.  Please check the latest diff.

@wpeng102 I have created a PR based on your changes: https://github.com/NVIDIA/cloudai/pull/169.


[1.0.1] Fix color output in command prompt

Backport #268 to 1.0.1
Resolves #271
NB: this is merging to "namc/rel/1.0.1". If approved, I'll rename that branch to "rel/1.0.1" and rebase this PR to merge into that branch.

Is this approved as in merge to rel/1.0.1? Or do we still need DJ approval?

Is this going to happen soon?

Is it expected that this fix will work on Windows 7 (SP1) 64-bit?

Still pending approval. It fixes Command Prompt color, which should mean Win 7 is fixed. The dev branch already has this fix. You can take the fix for a test drive by using our nightly feeds.

@natemcmaster - thanks. The steps I took were:
Download ZIP of latest Windows X64 SDK:
https://dotnetcli.blob.core.windows.net/dotnet/Sdk/master/dotnet-dev-win-x64.latest.zip
Unzip the file. Place the contents of the unzipped dotnet-dev-win-x64.latest folder in the test project folder in the source code (i.e. the mytests folder, described in the blog post written by @shanselman) :
https://www.hanselman.com/blog/CommandLineUsingDotnetWatchTestForContinuousTestingWithNETCore10AndXUnitnet.aspx
Open a command line (cmd.exe)
Navigate to the mytests folder
Type dotnet --version
2.0.0-preview1-005660
Type dotnet test
Expected result:
Colorised output
Actual result:
All output is white text
Note: I'm also seeing character-encoding issues in cmd.exe (and Powershell) but not Git-Bash, similar to the issue #265.
It's possible I have missed some necessary steps.

@snerks I'm not sure what you're trying to do. I didn't see mention of dotnet-watch anywhere in your repro steps. This PR is only about changes to dotnet-watch, not dotnet-test. Consider opening an issue instead of commenting on this PR if you're having trouble using our nightly builds.

@natemcmaster - I've moved the comment to #265 and tried to clarify the steps, to show usage of dotnet-watch.

Let me know if you want to pair on this @natemcmaster. The issue is that when we do "dotnet watch SOMETHING" the colors are not used, as in "dotnet watch test"

@shanselman It sounds like there are two overlapping things being discussed. (1) the color dotnet-watch produces (2) the color dotnet-test produces when run by dotnet-watch. This PR (and issue #265) only address (1). Can you open a separate issue for (2)?

@natemcmaster I don't think dotnet test produces color. So I think you've fixed it with https://github.com/aspnet/DotNetTools/issues/265#issuecomment-289608589 right?

I don't think dotnet test produces color

Not yet ;) https://github.com/Microsoft/vstest/pull/641.
Was just making sure we were talking about the same thing. Yes, #265 is resolved. This is the only color output issue I'm aware of. If you find others, feel free to open a new issue.

OK, cool. We should just watch out/make sure that when it does, everything works as it should on cmd.exe and powershell.exe.

FYI 1.0.1 is now available on NuGet.org.
https://www.nuget.org/packages/Microsoft.DotNet.Watcher.Tools/1.0.1


refactor blas/ext/base/dcusumkbn to follow current project conventions

Resolves #1472 .
Description

What is the purpose of this pull request?

This pull request:

refactors the existing implementation of blas/ext/base/dcusumkbn to follow the current project convention.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves #1472

Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.
Checklist

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

@Planeshifter I've made the requested changes.

I think, I made some big mistakes: 64008be & 64ddf87

If you are unable to revert those here, please feel free to open a new PR and close this referring to new one.

If you are unable to revert those here, please feel free to open a new PR and close this referring to new one.

Ok, working on it. Thanks for the clarification.

I'm closing this PR and opened a new PR #2036 . Please take a look into that:

#2036

And sorry for the inconvenience 🙏


auth: Allow expiry to be specified in .createCustomToken

Resolves #1016

At this time we cannot accept changes that affect the public API.  If you'd like to help
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.

If this gets a 👍 happy to do any changes needed, etc.!

Thanks for your contribution, @rhodgkins. This requires an internal API review and the API should not be Node.js specific. In addition, we need to check the service we use internally to mint these tokens are ok with the proposed changes. We may even need an internal launch review for this. Will need to double check it.

🙃

Hi @rhodgkins, This is a great feature that we are also looking to implement.
Any info from Google team, when this will be made public and available publicly?
Also, do you have have a way or suggestion to invalidate the custom JWT token on user logout. with the current setup although the user signs out from app but token is still usable / active for 60 mins (if accessed from outside) via postman or sorts.
@googlebot
Thanks

No idea sorry! I’ve given up waiting / keeping this up to date now 🤷♂

It's really impressive the speed at which things move around here. I'm not being sarcastic, I'm genuinely impressed.
@rhodgkins thanks for the contribution. Hopefully in another year we'll have the needed reviews 🤞

18 months later - any updates? Happy to rebase this one last time if it's realistically going to be used...

Hi @rhodgkins Thank you again for your contribution!
I really want to thank you for your patience on this. As mentioned in one of the previous comments, this a special change that requires multiple internal processes (API review, internal verifications, and may be a launch review) to be completed and approved before we can merge the PR.
Since this feature is not included in any of the immediate roadmaps, it is going to take time to complete the internal approvals. I can't unfortunately promise you a timeline for when this feature will be released. However, I will discuss this with the team so that we can do our best to move forward.
@prameshj PTAL. Thank you!


Option searchable by custom properties via data-custom-properties attribute is not working

Describe the bug
Option searchable by custom properties via data-custom-properties attribute doesnt work.
ERROR: value.trim is not a function
To Reproduce
Steps to reproduce the behavior:

Go to 'Option searchable by custom properties via data-custom-properties attribute and try searching for 'fantastic', ("Label 3" should display')
type  'fantastic'
See error

Expected behavior
Label 3 should display
Desktop (please complete the following information):

OS: iOS
Browser chrome
Version 104.0.5112.101

It looks like fuse requires all items to have a custom property value if you are using it to be searchable field.


Add additional toolchains maintained by cross-rs.

These toolchains are not automatically tested by CI, and must be built manually by the user. However, they are confirmed to build at least once, and are likely to work as-is.

I think that's everything. We now locate the Dockerfiles ahead of time, allowing mixing and matching in the docker root or the cross-toolchain docker root:
fn locate_dockerfile(
    target: String,
    docker_root: &Path,
    cross_toolchain_root: &Path,
) -> cross::Result<(String, String)> {
    let dockerfile_name = format!("Dockerfile.{target}");
    let dockerfile_root = if cross_toolchain_root.join(&dockerfile_name).exists() {
        &cross_toolchain_root
    } else if docker_root.join(&dockerfile_name).exists() {
        &docker_root
    } else {
        eyre::bail!("unable to find dockerfile for target \"{target}\"");
    };
    let dockerfile = dockerfile_root.join(dockerfile_name).display().to_string();
    Ok((target, dockerfile))
}

...

    let targets = targets
        .into_iter()
        .map(|t| locate_dockerfile(t, &docker_root, &cross_toolchains_root))
        .collect::<cross::Result<Vec<_>>>()?;


Addafter action with default name is not possible if same default name exists on multiple actions

Was trying to find if already reported, but no luck. I was trying to extend "Order Processor Role Center", but I cannot add action e.g. after Action "<Page Customer List>". All actions with default name are listed under the Caption string, but in this case, there are two Actions with default name "<Page Customer List>" having same caption "Customers". ALC will automatically use the first one (ID 26), but I need to place it after second one, with id 61. Main problem is the duplicity if no ID is used to identify the action.

Hi @kine ! We should be generating a name for the second action that doesn't conflict with any other action name. Could you check if you have any action with Action{ActionId} ?

Ah, Ok, now I have found the control. It is as Action61. Didn't know that in this case it will generate such a control name. I will expect e.g. "Page Customer List 61" or "Customers (61)" or something like that to easily find the action and make it unique.

We will not do any further tooling changes in the area of default name generation. The individual naming issues will be addressed by the application going forward.


fix: Resolve password show/hide button overlapping with password input(#503)

issue #503

Nice job, merged 💯


Updated network section with Ports & Subnet requirements

Updated network section with Ports & Subnet requirements

okay, we should be good to go.. please approve as soon as you can guys. :+1:


[QUESTION] Correct example for bash to chat with RAG via curl?

Question
Api doc provides following example:
api_name: /chat

curl -X POST http://localhost:8001/call/chat -s -H "Content-Type: application/json" -d '{
  "data": [
							"Hello!!",
							"RAG",
							"Hello!!"
]}' \
  | awk -F'"' '{ print $4}'  \
  | read EVENT_ID; curl -N http://localhost:8001/call/chat/$EVENT_ID

no result, but get an error in logs:
File "/home/worker/app/.venv/lib/python3.11/site-packages/gradio/blocks.py", line 1620, in validate_inputs
 raise ValueError(
ValueError: An event handler (_chat) didn't receive enough input values (needed: 4, got: 3).

You can check the API usage format on the Swagger Endpoint, just put it on the postman then convert to Curl


Rename to Repo Automator?

Describe your question
Given the scope of this action has expanded beyond just PR automations to other items covering issue automations and project/repo management, it might make sense to update the name (again) to Repo Automator?
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I'm fine with a rename but any concerns with repos that are using this action? I'm assuming they'd all need to be updated for things to still work, though I guess not sure how best to handle deprecations/renames with GitHub Actions. Looking at the last PR that renamed things (#27) not seeing any discussion there around that concern so maybe it's not a big deal?

@jeffpaul I think we are good to proceed with Rename.

I guess not sure how best to handle deprecations/renames with GitHub Actions. Looking at the last PR that renamed things (https://github.com/10up/action-pr-automator/pull/27) not seeing any discussion there around that concern so maybe it's not a big deal?

We don't have many users using this action, only internal 10up repos using this action. So, we can easily update the workflows to accommodate this rename.
Thanks

@jeffpaul we have to do code level updates at multiple places. I will raise PR and will ask you to rename the repo.
Also, once rename is handled here, I will raise the PRs for the repos where we are using this action.
Thanks


Subtraction overflow on startup

After cloning and attempting to start the project, I get a subtraction overflow panic because top < height in the set_yrange function of Chunk.rs.
I think this could be fixed by capping height at dy instead of dy+1 in set_yrange of voxel_world.rs.

closing as the PR was merged


Use parent and child Injectors instead of creating a new one for each verticle

I think the use case is similar to one described here: https://stackoverflow.com/a/12774246/1237617
This should allow one to have global modules that will only be applied once per Vertx creation and child modules that will be applied per each verticle.
If you think it's a valid improvement I'll be glad to send a PR quite soon as we have a real use case for it

We had actually been discussing something similar for vertx-hk2 which we use with Jersey.
I have pushed a branch feature/parent-child-injector.
Is this similar to what you had in mind?
The issue is how to initialize the parent injector on the factory since it doesn't run on the vert.x event loop with a Context so the JSON config is not available.  I have left it so you can programmatically set the injector.  Thoughts?

Looks promising, though I need some time to process your last remark about setting the injector.


(fix) a minor bug fix for jupyter notebooks

After the subaccount property was added to the SDK the jupyter wrapper now stores the api wrapper object as a property of the helper, this is a fix to make sure we don't do that.

I'm closing this PR, need to sync first and re-do the PR


simple_form_for

rails g bootstrap:install --template-engine=haml
It try to overview some files, like lib/templates/haml/scaffold/_form.html.haml
but it try to change simple_form to form_for, bootstrap-generators do support to simple_form_for??

it does not support simple_form. But if you want to keep the simple_form version, you just need to reject the substitution; or compare both versions and update the simple_form template.

Here is the Simple Form _form template for haml: https://github.com/plataformatec/simple_form/blob/master/lib/generators/simple_form/templates/_form.html.haml


Screenshot does not work on iOS 16

I have no idea what the problem is. Might have to look into that soon.

Fixed in commit 3067c0cab23e3a8d5b34b71e7fa39e0e15202fe6


Fix for #765: Made all imaging study instances get exported in CSV

Fix for #765

Added iteration through all instances of all series in an imaging study when creating the imaging_studies.csv export file.
Added SERIES_UID and INSTANCE_UID fields.

This PR is going to change the ImagingStudy CSV table, so that Id is no longer a unique primary key. This is going to be a breaking change to the table.
Anyone who builds a database according to https://github.com/synthetichealth/synthea/wiki/CSV-File-Data-Dictionary will need to update their tables for the new format.

This PR is going to change the ImagingStudy CSV table, so that Id is no longer a unique primary key. This is going to be a breaking change to the table.
Anyone who builds a database according to https://github.com/synthetichealth/synthea/wiki/CSV-File-Data-Dictionary will need to update their tables for the new format.

The https://github.com/synthetichealth/synthea/wiki/CSV-File-Data-Dictionary has been updated to reflect this new format.

The https://github.com/synthetichealth/synthea/wiki/CSV-File-Data-Dictionary has been updated to reflect this new format.

The https://github.com/synthetichealth/synthea/wiki/CSV-File-Data-Dictionary has been updated to reflect this new format.

The https://github.com/synthetichealth/synthea/wiki/CSV-File-Data-Dictionary has been updated to reflect this new format.


[Performance] splitting Nighthawk out of Meshery's container

Signed-off-by: Rudraksh Pareek<EMAIL_ADDRESS>Description
This PR fixes #4075
Notes for Reviewers

[x] Deploy in k8s
[ ] Deploy in docker containers
[ ] Transform results natively

Signed commits

[x] Yes, I signed my commits.

Task linked: CU-94zvye Split Nighthawk out of meshery docker image

Codecov Report

Merging #4135 (a04d4b5) into master (ad0aadc) will increase coverage by 0.94%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4135      +/-   ##
==========================================
+ Coverage   19.34%   20.28%   +0.94%
==========================================
  Files          59       59
  Lines        5015     5043      +28
==========================================
+ Hits          970     1023      +53
+ Misses       3750     3722      -28
- Partials      295      298       +3

Flag
Coverage Δ

unittests
20.28% <ø> (+0.94%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/config.go
8.61% <0.00%> (+7.48%)
:arrow_up:

mesheryctl/pkg/utils/sse-client.go
92.50% <0.00%> (+92.50%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a791b4b...a04d4b5. Read the comment docs.

@DelusionalOptimist It totally looks good for me, can you provide more information about how it runs?

@DelusionalOptimist is on break from the project for another few weeks or so. He might respond, however, we should assume that he won't while he's on break and we should proceed in his absence.

@DelusionalOptimist is on break from the project for another few weeks or so. He might respond, however, we should assume that he won't while he's on break and we should proceed in his absence.

@leecalcote Thanks, got it. I try to run this code in my host to verify it works, but I have few knowledge about how to build Meshery code. Can you provide some docs?
@navendu-pottekkat FYI

@navendu-pottekkat I'll try it, thanks.

Link to design spec - https://docs.google.com/document/d/1Qy_BpHXibTvL9daLTc5L4fjmr1F051ya0UYeghNUq_I/edit#

@DelusionalOptimist, I probably missed the note... are we migrating this issue to the meshery-perf repo or handling this effort under a different issue?

@leecalcote The code in this PR was to help Meshery server interact with the Nighthawk gRPC service directly. AFAIK that won't be happening.. so I think it becomes unnecessary to keep this in Meshery.
Yes, the proper place where this functionality should be meshery-perf... I suppose, right @gyohuangxin?
Relevant slack thread: https://layer5io.slack.com/archives/CFGG6U10E/p1642937943024200

@DelusionalOptimist Yes, I think so. I paused this PR due to our new design of meshery-perf component.


Support script deletion

Add support for the script deletion API.
https://docs.influxdata.com/influxdb/cloud/api/#operation/DeleteScriptsID
This will require additions to the Go client library.

Consolidating into a single issue.


All Elements in Two Binary Search Trees

Pull Request Template
What have you Changed(must)
Added solution for 1305. All Elements in Two Binary Search Trees
Issue no.(must) - #1240
Pr will be close and marked as spam. If issue number not found or issue was assigned to someone else.
Marking as spam can block your account from HacktoberFest.
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me if not it will be marked as spam.
[x] My file is in the proper folder
[x] I am following clean code and Documentation.
[x] I have added the title and what program will do first in the file
[x] I have named the file as (Problem #). (Problem Title(in Camel Case)).(extension)
ex. 2. AddToNumbers.py

README - How to Contribute

I created an issue. Assign me to contribute for that.
On Fri, Oct 30, 2020, 21:02 Shantanu Kale<EMAIL_ADDRESS>wrote:

Closed #1166 https://github.com/SHY-Corp/LeetCode-Solutions/pull/1166.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SHY-Corp/LeetCode-Solutions/pull/1166#event-3941814930,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMX6C5JDSBCVTWAICGDBSM3SNLMCNANCNFSM4S6PVZKQ
.


Draft: feat(i18n): locales rework

In Draft should be reviewed.
This issue was a bit painful but now I'm a copy/paste master and fluent in all languages.
Let me know if we should keep .py script.
Before submitting this PR, please make sure:

[ ] Code builds clean without any errors or warnings (need help with last require and README warn)
[x] I've merged recent default branch -- main and I've no conflicts
[x] I didn't break any original functionality

Optional

[x] I've tested it on mobile and everything works

PR type

[x] Feature

What's new? (maybe part of changelog)

closes #101
#284 related

Reworked locales

[x] bn.json
[x] cn.json
[x] cz.json
[x] de.json
[x] en.json
[x] es.json
[x] fr.json
[x] hi.json
[x] it.json
[x] jp.json
[x] ko.json
[x] nl.json
[x] pl.json
[x] pt.json
[x] ru.json
[x] sk.json
[x] tu.json
[x] ua.json
[x] ur.json
[x] vt.json

This issue was a bit painful but now I'm a copy/paste master and fluent in all languages.
Let me know if we should keep .py script.

vous pourrez désormais parler plusieurs langues 😄
Okay I've checked for Slovak it's working https://deploy-preview-656--nftkodadot.netlify.app/rmrk/faq
Maybe remove  tags and leverage markdown bold using **  ?
For me all good, it's looking amazing and we can finally unfreeze translations!
Let me pass this to stewards to check their languages if anything critical is there and we can still fix it in new way others making PR to their language translations.

Let me know if we should keep .py script.

Yes please ❤

Oh, one last question @roiLeo
What about adding that foldable effect? So whenever one searching for a question, one don't need to see all answers
It's the last point from https://github.com/kodadot/nft-gallery/issues/101

Foldable answers, use https://buefy.org/documentation/collapse#accordion-effect
Visual like https://nftshowroom.com/faq foldable, got foldable cards

Oh, one last question @roiLeo
What about adding that foldable effect? So whenever one searching for a question, one don't need to see all answers
It's the last point from #101

Foldable answers, use https://buefy.org/documentation/collapse#accordion-effect
Visual like https://nftshowroom.com/faq foldable, got foldable cards

Let's make it a separated good first issue :)

@yangwao I didn't know if it was still relevant but I can propose something.
I still got one issue that I can't fix "Detected usage of the any type" on i18n.ts file.

@yangwao I didn't know if it was still relevant but I can propose something.

Yeah, I mean, rather wait and accept it once it's working, it will be huge upgrade for FAQs :)

I still got one issue (Warning) that I can't fix "Detected usage of the any type" on i18n.ts file.

That sounds like typescript warning 🤔

I made some changes to include collapsible in faq.
By default all opened.
UI looks weird... Should I remove arrow ? or maybe change title width ?
Screenshot

I mean looks good, I would

put chevron to the left (to not be random placed)
different colour for chevron, maybe try $main? To know it's actionable.
maybe smaller text for headline

All good for me!

Screenshot

I still have a small problem with scrolling to the anchor. (For example when you click on chevron)
Same with link like /rmrk/faq#What-wallet-do-I-need-to-mint,-buy-and-collect? doesn't work when I don't have the right locale.

I mean, we can flex addressable later stage...
right now to just dispatch it to live I see this one issue there that you lose headline text as it seems viewport starts under navbar if I see right?
All good, really like this going unfreeze translations!:)
https://user-images.githubusercontent.com/5887929/131492662-3a5f3e60-e5bb-4485-b762-4f8437410ddb.mov

Ship it! 🚀


Improve copy paste error snackmessage

The current messages the user get when trying to paste a invalid content is not very descriptive.

@QiJin-Bouvet This is ready for test

Tested with commit d1bbfbc in TEST env.
Error message shown as below:


Selenium Grid not running tests

I have configured my Selenium Grid Hub and one node. I see that the node is registered correctly, no errors appear to be showing on the Hub console.
However, when I launch my tests the selenium grid just appears to be unresponsive.. No logging or anything that its about to start passing out tests or things like that. I am starting to wonder if it may be related to how i am handling the capabilities?
Here is my Hub, you can see the node configured

Here is my AppiumNode.json file. I have my host set to the nodes IP address and the hubHost set to the hubs IP address.

And then here is my code that does the WinAppDriver startup
appCapabilities.AddAdditionalCapability("platformName", "WINDOWS");
appCapabilities.AddAdditionalCapability("app", GetLaunchFile());
                    appCapabilities.AddAdditionalCapability("appArguments", "enableautomation");
                    session = new WindowsDriver<WindowsElement>(new Uri(HubIP), appCapabilities, TimeSpan.FromMinutes(2));
                    session.Manage().Window.Maximize();

Shouldnt I see atleast something happening in the cmd prompt window thats running the Hub acknowledging that its going to pass it out to the node? Could it be something with how im specifying the platformName?

The hub command line will show the registered nodes, but on the web interface it will not show anything, that's how it is

@anunay1 Right, I see on the cmd line that it registered the node but what I was expecting was that when it receives a test, it should atleast log something saying it received that request right? Nothing is shown on the cmd line for the Hub.
Is anything off about my above setup? Why would the tests not be passed to the node?

You are correct that the hub should be logging a message as it receives a driver.start command. It will look something like "Trying to create a new session on test slot [blahblahblah]"
I'd be willing to bet the HubIP you're passing to it is not targeting the right port or endpoint. That URI should end with :portnumber/wd/hub for a hub session whereas for local driver sessions it accepts the direct ip:port combo for starting sessions.


Sorting a child to the top-most parent doesn't seem to work

Trying to sort a child to the top most level doesn't seem to work as expected.

What is your configuration?

Without more information I can only assume that it doesn't work due to the root level restriction. This restriction is enabled by default and can be removed as follows:
const tree = new SortableTree({
  nodes,
  element,
  lockRootLevel: false,
  stateId: 'state',
});

I also added an example to the demo page.


Use WithProperties to improve properties handling (CASSANDRA-18453)

Using WithProperties to improve handling of property set and cleanups.
To find the actual try catches, I've used IntelliJ structural search with this pattern:
try ($ResourceType$ $resource$ = $init$; $expression$) {
  $TryStatement$;
} finally {
    $property$.clearValue();
}

patch by Bernardo Botella

Awesome to see the usage of structural search. We talked offline that the template needs to be improves to cover different code structures.

Awesome to see the usage of structural search. We talked offline that the template needs to be improves to cover different code structures.

I ended up going with Stephan's suggestion and spotted a bunch more cases.

 I think it is common practice to fix something right before committing, so LGMT. @bbotella thank you very much for picking this up!


Simplify processing/sending/receiving context switches and Timers

The goals of this change are:

to move the processing of context switches to the service, where they are known to come in order, the same way it's done for dynamically-instrumented functions and gpu jobs;
to send scheduling slices already as Timers the same way as dynamically-instrumented functions and gpu jobs, to make to code simpler and more consistent;
to simplify how Timers are handled on the client, in particular avoiding the old TimerManager.

Commits:
Add ContextSwitchManager with tests to OrbitLinuxTracing
This class matches in and out context switches assuming they come in order on
the same core.
The goal is to move the matching of in and out context switches to the service.
Use ContextSwitchManager and send scheduling slices already as Timers
The processing of context switches into Timers is moved from TimeGraph
(where it doesn't belong) all the way to service in OrbitLinuxTracing.

We can assume context switches on the same core come in order.
This means that using the std::map m_CoreUtilizationMap is not necessary.
The code is greatly simplified. In particular, scheduling slices are now dealt
with in the same way as slices from dynamic instrumentation and gpu jobs.

Remove TracerThread::ProcessContextSwitchEvent
As PERF_RECORD_SWITCHes are unexpected, only PERF_RECORD_SWITCH_CPU_WIDE
(we print an error when the former type is encountered), this code is basically
dead.
Remove all code related to sending context switches instead of Timers
As all the processing of context switches into Timers has been moved to the
service, remove all the code that is now unnecessary.
Bypass the obsolete GTimerManager entirely to add Timers
The TimerManager is a leftover from Windows profiling, its logic is not
necessary to add Timers received from the service (unfortunately, it cannot be
removed as a lot of old Windows-profiling-related code depends on it).

Since we do a bit more work on the service side, do you think we should defer processing the scheduling events to another thread like we do of other events?

The additional processing is not that much, but we can have a lot of context switches, so you might be right, I need to test this.

Since we do a bit more work on the service side, do you think we should defer processing the scheduling events to another thread like we do of other events?

The additional processing is not that much, but we can have a lot of context switches, so you might be right, I need to test this.

It seems that this change doesn't make things worse but in very extreme cases it can already happen to lose context switches, so I created http://b/158543776 but I will leave this for another change.

I think right now this is a good change, but we need to discuss where, eventually, we want to do all our processing, on the client or on the service side. The main issue with doing it on the service side is that it takes additional processing time away from the process(es) that we are profiling. Moving all the logic to the client is better in that regard, but then the logic is spread out a lot more.


Merge 'cytochrome P450 fatty acid omega-hydroxylase activity' with 'acyl-[acp] hydrolase activity'

'cytochrome P450 fatty acid omega-hydroxylase activity' has no annotations.
In addition it has as db cross reference EC:3.1.2.-, which is the EC of the parent thiolester hydrolase activity.
Also, there is nothing EC or the metcyc reaction that refers to cytochrome P450.
'acyl-[acp] hydrolase activity' has exact synonym 'acyl-CoA thiolesterase activity', so it seems like these two are equivalent.
@tberardini do you want to comment ?
Thanks,
Pascale

Digging a little further, I found in UniProt entry Q02928 (from PMID:18433732) that cytochrome P450 gene 4 family catalyzes omega- and (omega-1)-hydroxylation of various fatty acids such as laurate, myristate and palmitate.
I also found
https://en.wikipedia.org/wiki/Linoleoyl-CoA_desaturase
that catalyzes 'linoleoyl-CoA + AH2 + O2 <=> gamma-linolenoyl-CoA + A + 2 H2O'
and has EC <IP_ADDRESS>.
However in GO EC <IP_ADDRESS> is linoleoyl-CoA desaturase activity:
Catalysis of the reaction: linoleoyl-CoA + reduced acceptor + O2 = gamma-linolenoyl-CoA + acceptor + 2 H2O.
@hdrabkin do you know anything about these enzymes?
Thanks, Pascale

No, not really.. One is specifying "reduced acceptor", which I believe is what "AH2" is used as an abbreviation for.

Hmmm. A hydrolase catalyzes the cleavage of a covalent bond with the introduction of the elements of a water molecule. Proteases are hydrolases. A hydroxylase introduces an -OH group into a substrate. Many textbook cytochrome P450 enzymes are hydroxlases. I don't know of any that are  hydrolases, so a priori the proposed merger sounds wrong.

Nothing to add, @pgaudet.  This is not my area of expertise.  However, I see quite a few papers describing this activity:
http://www.jbc.org/content/267/27/19051.short
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC2423664/
It looks like the parentage and EC reference need updating but how and to what, we'd need some input from people with more biochemical background than I have.  I would not recommend merging or obsoletion of this term given the current information I've seen.

Thanks for the feedback, I'll look further.
Pascale

Hi Ingrid,
How are you doing ? I need some help to understand a MetaCyc reaction that we have as a cross-link to GO:0102033 cytochrome P450 fatty acid omega-hydroxylase activity
https://github.com/geneontology/go-ontology/issues/14194
The link we have, MetaCyc:LINOLEOYL-RXN, take me to
https://biocyc.org/META/NEW-IMAGE?type=REACTION&object=<IP_ADDRESS>-RXN
which has a different EC from what GO has. Can you help me understand what I am looking at?
Thanks, Pascale

Hi Pascale,
First, for me the link on the GO site, http://amigo.geneontology.org/amigo/term/GO:0102033
actually goes to
https://biocyc.org/META/NEW-IMAGE?type=NIL&object=LINOLEOYL-RXN
and not to the <IP_ADDRESS> reaction.
The big disconnect seems to be between the name of the term, cytochrome P450 fatty acid omega-hydroxylase activity, and the definition/activity, which is a CoA hydrolase, very different from what is suggested by the name.  The current location of GO:0102033 in the hierarchy fits with the definition, but not the term name. So if you decide to keep it, at least the term name needs to be fixed.
As for the term/enzyme/reaction itself, I don't know what, if anything, the evidence for it is.  The reaction in MetaCyc doesn't have an enzyme catalyzing it, and from my reading of the pathway summary at https://biocyc.org/META/NEW-IMAGE?type=PATHWAY&object=PWY-6917, it may have been included because the pathway needed an input of linoleate without a CoA group.  At one point in prehistory, there seems to have been an enzyme catalyzing the reaction in a different pathway, but both seem to have disappeared.
So, if you decide to keep the term, I'd fix the name and actually move it under GO:0016289, the CoA hydrolases.  In the GIT ticket, you wrote that 'acyl-[acp] hydrolase activity' has exact synonym 'acyl-CoA thiolesterase activity', but I actually don't see that synonym for GO:0016297.  Which is good, because ACP is definitely not the same as CoA.  (Are we looking at different versions of GO? I'm using AmiGO at the geneontology web site.)
As for EC <IP_ADDRESS>, there is actually already GO:0016213.
Does this help?  I can ask Ron Caspi more about the history of the LINOLEOYL-RXN if needed.
Cheers,
Ingrid

Thanks for the input @keseler
In the end I kept the concept of the term name, and changed the definition and cross references (including MetaCyc and EC). If we ever need the reaction represented by MetaCyc:LINOLEOYL-RXN someone can request it.
Changes:
id: GO:0102033
-name: cytochrome P450 fatty acid omega-hydroxylase activity
+name: fatty acid omega-hydroxylase activity
namespace: molecular_function
-def: "Catalysis of the reaction: linoleoyl-CoA(4-) + H2O <=> H+ + linoleate + coenzyme A" [EC:3.1.2.-, MetaCyc:LINOLEOYL-RXN]
-xref: MetaCyc:LINOLEOYL-RXN
-is_a: GO:0016790 ! thiolester hydrolase activity
+def: "Catalysis of the reaction: long-chain fatty acid + NADPH + H+ + O2 = an omega-hydroxy-long-chain fatty acid + NADP+ + H2O." [EC:<IP_ADDRESS>]
+synonym: "cytochrome P450 fatty acid omega-hydroxylase activity" RELATED []
+xref: MetaCyc:RXN-16394
+xref: PMID:18544608
Thanks, Pascale


ISSUE TEMPLATE

Have a look here first of all https://github.com/himanshu007-creator/SFC-foundations/issues/12

I would like to work on this .
Please assign it to me

I would like to work on this .
Please assign it to me

HI @Subhangini GSSOC will begin on 1st march, then only issues will be alotted . Please have a look here https://github.com/himanshu007-creator/SFC-foundations/issues/12

HI @Subhangini GSSOC will begin on 1st march, then only issues will be alotted . Please have a look here #12

Ok @himanshu007-creator .Will wait till then.

I would like to work on this issue under GSSOC ?
Please assign me

I would like to work on this as a part of GSSOC! Please assign me this!

@Subhangini   yes you can work on it. We just need an idea like how you will proceed. As we are redesigning everything so everything will be changes and so will the site structure. We just need to know how you are going to implement it. Prepare a prototype of code and send it within this week. Best of luck!


feat(upload): use strategy pattern for multipart/form-data or direct upload

Since we've got questions regarding uploading images directly to Amazon S3, we can use the strategy pattern to switch the behavior of ngx-uploader.class.ts.
Defaults to: multipart/form-data upload
ngx-uploader.class.ts #L225
see
#391
#285

#391

How to direct upload? Seems the multipart option is removed.

Please look at the example in the repository. All files are transfered as multipart upload. But not in one transfer (all files in one upload). Each file will uploaded as single multipart upload.

I like the idea of a strategy pattern switch.
For my purposes, allowing the implementer to create their own strategy pattern would be immensely useful as I have to work with a team that created a custom backend loosely based on the one of the common strategies... but not exactly.


[5.8] SameSite=None support

Laravel Version: 5.8

Description:
Google introduces new Chrome policy, marking all Cookie without SameSite flag to 'strict' by default. If you want to allow third party cookies you must set samesite flag to 'none'.
For cookie related logic laravel uses symfony/http-foundation and they already have released the support for it. There is no mention of it in the laravel configuration, but the config/session.php says that only 'strict' and 'lax' are supported, where we need 'none'.
Symfony Ticket: symfony/symfony#31475
Can we set it to 'none' regardless, or if not possible, when is this expected to be possible? This problem has been known for a while, and it is only a few days until Chrome enforces it.

Fortunately, I found out that setting this setting to none is perfectly valid.

your issue is resolved? with which version?

Had the same problem. Change the ff lines to:
'secure' => env('SESSION_SECURE_COOKIE', true),
'same_site' => 'none',

in config/session.php

If you change same_site to something other than null I'd definitely advise testing your work in Safari 12.x if that's relevant to you, as it has a related bug on both macOS and iOS (See https://github.com/Fyrd/caniuse/issues/4813).


angular-scroll not working when triggered by touch event

Hi,
We are using angular-scroll on our gift ideas & wishlist service https://www.wishtack.com.
But the problem is that we think that we noticed a bug on mobile devices. We trigger the scroll using an 'ng-click' but the touch event also cancels the scroll before it can't really start.
This happens in 'cancelScrollAnimation' where you have this condition '$event.which > 0' but the touch event '$event.which' is set to 1. Maybe, the condition should be more restrictive?
Thanks in advance and thank you by the way for this great module.
Younes
for Wishtack.com

Hi,
Had a hard time finding where on the site the bug appears, can you point me in the right direction?
Anyway, does it solve your problem if you replace the condition you are referring to with the following?
if (!$event || (startTime && $event.which > 0)) {

Having this issue with my mobile device, although $event.which is undefined, probably because I call scrollToAnimated().
But animation doesn't happen, it just scrolls to, normally.

@yjaaidi & @panstav : Did you try my proposed solution?

Hi Joel, sorry but we are still not using angular-scroll on production.
That's why you couldn't find it :)
I'm gonna try your solution right now!
On Tue Feb 17 2015 at 7:03:25 AM Joel Arvidsson<EMAIL_ADDRESS>wrote:

@yjaaidi https://github.com/yjaaidi & @panstav
https://github.com/panstav : Did you try my proposed solution?
—
Reply to this email directly or view it on GitHub
https://github.com/oblador/angular-scroll/issues/106#issuecomment-74621144
.

Well, it still doesn't work as the scroll is canceled during the first
animation step so 'startTime' is initialized.
But, when I moved 'progress' variable declaration to 'duScrollToAnimated'
and using it in the condition it works with:
if (!$event || (progress && $event.which > 0) {
Is it an acceptable solution?
Thnaks!
On Tue Feb 17 2015 at 7:34:59 AM Younes JAAIDI<EMAIL_ADDRESS>wrote:

Hi Joel, sorry but we are still not using angular-scroll on production.
That's why you couldn't find it :)
I'm gonna try your solution right now!
On Tue Feb 17 2015 at 7:03:25 AM Joel Arvidsson<EMAIL_ADDRESS>wrote:

@yjaaidi https://github.com/yjaaidi & @panstav
https://github.com/panstav : Did you try my proposed solution?
—
Reply to this email directly or view it on GitHub
https://github.com/oblador/angular-scroll/issues/106#issuecomment-74621144
.

@oblador, yea, what I meant by my previous comment was that I did try your solution - with no results.
I believe it is because I used that method - scrollToAnimated(), so that $event.which doesn't get populated with click / touch, and a beacon I've set inside the event cancellation function doesn't get called at all.

UPDATE: It actually IS working for me, trying it out on different devices - I found out the animation was just a bit too fast to notice, which is exactly why I needed the module - to make sure user understands he's just a scroll away from where he previously been.
Tried different duration times, I now have a great effect working on both desktop and mobile.
Thanks!

@yjaaidi: used your solution but don't really get why they should differ since they are populated in the same function call :-)

Great! Thanks!
Actually it doesn't work with 'startTime' because on the first call to
animationStep, 'startTime' is initialized to 'timestamp' and progress is
initialized to 'timestamp - startTime' which is equal to 0 on the first
call. So 'progress' will only get greater to 0 at the second call ;)
By the way, when are you planning to release the 0.6.5 with this fix?
Thank you again!
Younes
for https://www.wishtack.com
On Fri Feb 20 2015 at 8:08:18 AM Joel Arvidsson<EMAIL_ADDRESS>wrote:

@yjaaidi https://github.com/yjaaidi: used your solution but don't
really get why they should differ since they are populated in the same
function call :-)
—
Reply to this email directly or view it on GitHub
https://github.com/oblador/angular-scroll/issues/106#issuecomment-75198385
.

Here's 0.6.5!

Super! Thanks!
On Fri Feb 20 2015 at 9:51:10 AM Joel Arvidsson<EMAIL_ADDRESS>wrote:

Here's 0.6.5
https://github.com/oblador/angular-scroll/releases/tag/v0.6.5!
—
Reply to this email directly or view it on GitHub
https://github.com/oblador/angular-scroll/issues/106#issuecomment-75206786
.