tmux broken on macOS

Describe the bug
Running tmux on macOS fails with the error:
➜ tmux
error creating /run/user/$(id -u)/tmux-501 (No such file or directory)

I've tracked down the issue to this line which provides a default for the TMUX_TMPDIR value of "/run/user/$(id -u)". Unfortunately, on macOS, there is no such /run directory, so the only option is to provide an override for $XDG_RUNTIME_DIR.
To Reproduce
Steps to reproduce the behavior:

Turn on Mac
Install Nix
Install tmux
Start tmux

Notify maintainers
@shlevy
@matthiasbeyer
@wkennington
@peterhoeg
@fpletz
@xrelkd
@Pamplemousse
@dezgeg
@tobias-hammerschmidt
@ruediger
@dupgit
@globin
@kimat
@Mic92
@ookhoi
@doronbehar
@darklajid
@LnL7
@kmille
@bjornfor
@aneeshusa
@7c6f434c
Metadata
 - system: `"x86_64-darwin"`
 - host os: `Darwin 19.5.0, macOS 10.15.5`
 - multi-user?: `no`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.3.6`
 - channels(davidlewis): `"home-manager, nixpkgs-20.09pre230446.a84cbb60f02"`
 - nixpkgs: `/Users/davidlewis/.nix-defexpr/channels/nixpkgs`

Random
There seems to be a significant number of maintainers for this package based on what I've seen in GitHub. Sorry for notifying you all, I have no idea who would have been the best person to notify.

The file you mentioned is a nixos module, that's no relevant for other platforms, including non nixos linux distributions.

There seems to be a significant number of maintainers for this package based on what I've seen in GitHub. Sorry for notifying you all, I have no idea who would have been the best person to notify.

I don't know what you're talking about, there are only two maintainers:
maintainers = with stdenv.lib.maintainers; [ thammers fpletz ];

(taken from pkgs/tools/misc/tmux/default.nix)

Also what @LnL7 said. I propose to close this, as this is not an issue with the module.

I think I remember this error, it comes from home-manager https://github.com/rycee/home-manager/blob/1f174f668109765183f96b43d56ee24ab02c1c05/modules/programs/tmux.nix#L306.
You can set secureSocket = false as a workaround:
tmux = {
  enable = true;
  secureSocket = false;
};

Closing since it doesn't belong to nixpkgs

In other words please open this issue in either home-manager or darwin-nix depending what module you are using, thanks!

The file you mentioned is a nixos module, that's no relevant for other platforms, including non nixos linux distributions.

You're absolutely right. Sorry about that, I'm new to the project and missed that fact in the path.

There seems to be a significant number of maintainers for this package based on what I've seen in GitHub. Sorry for notifying you all, I have no idea who would have been the best person to notify.

I don't know what you're talking about, there are only two maintainers:
maintainers = with stdenv.lib.maintainers; [ thammers fpletz ];

(taken from pkgs/tools/misc/tmux/default.nix)
Also what @LnL7 said. I propose to close this, as this is not an issue with the module.

Ah, I must have missed that - thanks for pointing that out for me.

I think I remember this error, it comes from home-manager https://github.com/rycee/home-manager/blob/1f174f668109765183f96b43d56ee24ab02c1c05/modules/programs/tmux.nix#L306.
You can set secureSocket = false as a workaround:
tmux = {
  enable = true;
  secureSocket = false;
};

Closing since it doesn't belong to nixpkgs

I see what you mean, still getting used to Nix, so I appreciate the response. Thanks!

In other words please open this issue in either home-manager or darwin-nix depending what module you are using, thanks!

Appreciate you all taking the time to set me off in the right direction. Apologies if I've derailed you all from your current work.
And thank you for putting your effort into this project - I'm absolutely loving it, despite going through the ol' learning curve 😅


If the issue persists, you can try to fix it yourself. Build the project as Debug, run the check, and see where the error occurs. If you're unable to do it on your own, there is plenty of information available online regarding such errors, or as a last resort, you can ask ChatGPT for assistance.
Still working after the update:

Also, if anyone needs it, I have created a small project that converts all the required signatures from script.json into HEX format for faster updates after Rust has been updated.
https://github.com/MaRf1Mm/Script.json-Converter-for-Rust

Sounds like it is outdated, you need to update it. The issues regarding python will require you to just reinstall and set the system directory for python.


refactor(framework): adopt to eva mappings [partial]

Please read and mark the following check list before creating a pull request:

[x] I read and followed the CONTRIBUTING.md guide.
[x] I read and followed the New Feature Checklist guide.

Short description of what this resolves:
Updates following components to eva mappigns:

Layout
Modal
OverflowMenu
BottomTabNavigator
TopNavigationBar
Toggle

This closes #311

Merged in #313


Problem with Signature V2 on requests

Hi, I just tried out the package, but it seems my case doesn't quite supported yet. I found that your request builder is using Signature V4 for signing requests. My target host are using Signature V2 and probably it makes my responses always returning 403. Maybe you can add this one feature to allow choosing signature version when initializing the client.
One more question, is it a mandatory to put all keys on client initialization, but I just want to retrieve list of objects from my public bucket? Thanks.

Hi!

I did some research and it seems like v2 has been deprecated for a few years now and v4 is supported everywhere. (https://aws.amazon.com/blogs/aws/amazon-s3-update-sigv2-deprecation-period-extended-modified/ ).
I don't know how AWS handles access to public buckets. Do you have an IAM user? If you do, I think it should work.

sorry, I didn't search through the official blog and just know that it has been deprecated, thanks for the info 👍🏻. However, my storage host do still require V2 signature (based on their knowledge base if users want to browse the bucket using S3 browser). I need to tell my team to do more research about our host on this matter.
Anyway, the objectives of the package generally match with my requirements for additional feature for my app —I just want to make our S3 browsable and users can directly download files to their phone. Beforehand, I used some workaround to just call full path of the bucket, and that's totally inefficient and I got overwhelmed about how to iterate the thousands of keys efficiently, from XML which I can't get along with well... so I came to your package and my hope is almost achieved 😅
Thanks for your response.

Hey,
Since there is now an official package for accessing AWS services, I decided to not longer support this package. please migrate to https://github.com/aws-amplify/amplify-flutter / https://pub.dev/packages/amplify_storage_s3/example


Why is this Acceptable

https://github.com/real-logic/agrona/blob/db6bb9205683baf3274bc0090940bb6defbf159a/agrona-concurrency-tests/src/main/java/org/agrona/concurrent/ringbuffer/OneToOneRingBufferTests.java#L102C9-L102C9
@JCStressTest
@Outcome(id = "19, 0", expect = Expect.ACCEPTABLE, desc = "Write before read")                         <- OK
@Outcome(id = "19, 42", expect = Expect.ACCEPTABLE, desc = "Read before write")                       <- OK
@Outcome(id = "42, 0", expect = Expect.ACCEPTABLE, desc = "Write in the middle of the read")   <---- WHY ACCEPTABLE
@State
public static class WriteFullBuffer
If this is acceptable then the consumer will miss a message, which does not sound correct. Shouldn't it be FORBIDDEN?
Run the JCstress locally  (below spec) and that state is never observed.
java.specification.vendor | Oracle Corporation
java.specification.version | 17
java.vendor | Azul Systems, Inc.
java.version | 17.0.12
java.vm.name | OpenJDK 64-Bit Server VM
java.vm.vendor | Azul Systems, Inc.
java.vm.version | 17.0.12+7-LTS
os.arch | amd64
os.name | Linux
os.version | 6.8.0-44-generic

@theodimop This is not acceptable. I've updated the test in https://github.com/real-logic/agrona/commit/f6c6d8be2cef3318d99ce31c347a3844d3c2acaa.


update TeamViewer to 15.19.3

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Duplicate of #18929.

I'm sorry, I searched before but it seems I missed it.


Evaluate values when prefixed with operator

This is a potential breaking change so I suggest to bump the major version to 0.2

Values prefixed with operators like < <= => > ! are always rendered as string even if they are obviously numbers (i.e. ">25" to > '25' instead of > 25). This PR fixes the issue by evaluating the value and convert it into a JavaScript number type before rendering the condition.

Hi, can someone have a look at this PR please?

Hi @expobrain ! Sorry for the delay and thanks for your contribution.


Solutions for caching matching results in treatment effect

Will be completed by #149

Will be completed by #149


Git tags for releases

Would it be possible to add git tags for releases?
I'm looking to package this for Nix, and would like to be able to run the tests on the fetched source during the build. The PyPI source tarball does not include the required examples directory, so a git tag would be nice.

Sorry it took me a long time to do this. I'll start making tagged releases going forward (and have backfilled v0.1.4 and v0.1.5).


Local Storage

Local stage should be either Most Recent Searches and/or Favorites.  Group to decide later.

Working but need to make an array for  multiple saves


Iterating multiple staples

Stapler works like a charm for one time pictures.
Is there an easy way of creating a set of staples that can be iterated over? For example a user uploads multiple avatars.
For the time being I have 6 separate forms, one for each staple, this is not scalable and involves a lot of copy paste.

I have similar issue

Yeah you can. I used to have an example for doing this in the docs but it looks like it got removed at some point. Essentially, you need to create a separate table for your avatars and then define your attachment in that model. Then, you you need to add a hasMany relationship to your User model so that  User has many avatars (or whatever you decide to name it). Then, in your file upload form you need to create an html array of file upload fields:
{{ Form::open(['url' => '/users', 'method' => 'post', 'files' => true]) }}
    {{ Form::text('first_name') }}
    {{ Form::text('last_name') }}
    {{ Form::file('files[]') }}
    {{= Form::file('files[]') }}
    {{ Form::file('files[]') }}
{{ Form::close() ?>

Then in your controller:
public function store()
{
    // Create the new user
    $user = new User(Input::get());
    $user->save();

    // Loop through each of the uploaded files:
    // 1. Create a new Avatar instance.
    // 2. Attach the file to the new instance (stapler will process it once it's saved).
    // 3. Attach the Avatar instance to the user and save it.
    foreach(Input::file('files') as $file)
    {
        $avatar = new Avatar();             // (1)
        $avatar->file = $file;                    // (2)
        $user->avatar()->save($avatar);    // (3)
    }
}

This is taken from an old example and can probably be simplified further, but I've broken it down into discrete steps to make it easier to understand the process. This is just one way this could be done. Hope it helps!

Nice one.. Cheers @tabennett  even it I found it earlier


Run pre-commit (eslint, prettier) in both docker & local

We use husky to run eslint before committing but this doesn't work when running docker. Warning:
Can't find Husky, skipping pre-commit hook
You can reinstall it using 'npm install husky --save-dev' or delete this hook

We want this to work for people working with and without docker. Here is one potential resolution but it might work only for docker: https://github.com/MadeInHaus/react-starter/pull/30/files
EDIT: The above linked example is also not appropriate because we have multiple npm projects.
Needs to be added to both client/package.json & backend/package.json

@robinv85 from what I've been reading it seems the recommended path for a monorepo is to add a root level npm project for husky/lint-staged.
https://github.com/typicode/husky#monorepos
https://www.horacioh.com/writing/setup-lint-staged-on-a-monorepo
This repo is an example using lerna but with two non-lerna alternates. This seems like the best choice for us (at least at first). The 3rd one I don't think will work with docker-compose. The main lerna option might work with docker-compose with some tweaks but maybe lerna is overkill is us?
Everyone would need to install Node.js regardless of if using local or docker set-up but I don't think that's too big a deal.
If you have any other suggestions or thoughts on this let me know.

@joshmorel interesting information, I will look at the links you provided and give it some thought
I am not sure if the long term vision here is to keep the backend and the web frontend in a monorepo, also because there are mobile apps as clients?
About Lerna, I have seen that this is often successfully used for libraries and tools such as Babel and Lodash but I am wondering if this would fit our use case since it's not just a multi-package monorepo but we are running multiple separate Docker services (back- and front-end in the same repo).
Eventually this might also affect the deployment process and such, maybe @mannykary has some valuable insights here.
Last one looks ok, I guess I haven't really thought of using the package.json in the root folder like that

@robinv85 - For lerna I think you're right - not just overkill but inappropriate for us.
I'm not sure about the long term vision but in the medium term I can't see this changing anytime soon (~6 months). For one thing, I have a feeling the feasibility of running cypress e2e tests on commit might depend on keeping f/e & b/e together in one repo.

I think for the short-term we can just follow this method as @joshmorel mentioned as we will likely break up frontend and backend into separate repos at some point. They will likely be independently deployable and independently scalable as well since as @robinv85 mentioned there are more frontend clients/consumers of the backend API than just the React web frontend, and as it's currently set up, the other clients would have to connect directly to the web frontend container to be proxied to the backend for any API call it needs to make. So this would put unnecessary strain on the web frontend container.

Hey @joshmorel @mannykary are we still working on this issue?

@tejasm2  - yeah we need it . I will try to fix within 2 weeks - but will ask in #engineering if anyone wants to take this on.
p4 is fine.

Thanks @joshmorel


Re-export in6_addr

Sorry for the delay. It looks like this got pulled in: https://github.com/carllerche/nix-rust/blob/master/src/sys/socket/mod.rs#L36


Open-source IoT Platform using Leshan

Dear Leshan Team,
Hope you are doing well and had a good weekend. Thank you for your support.
We had a look at https://github.com/eclipse/leshan/issues/830 , and were wondering if there are any open-source IoT platform utilizing Leshan.
Our use-case is quite similar to https://github.com/eclipse/leshan/issues/974

Endpoint sensor connects to the Edge system (Raspberry Pi) running a Leshan Bootstrap Server.
Bootstrap server at the edge provides the credentials and the secure keys to the endpoint device.
Edge Leshan server at the edge registers the device and forwards the device details to the cloud-Leshan server (similar to https://github.com/eclipse/leshan/issues/974)
Data transfer for the endpoint travels securely to the edge and to the cloud.

Yours Sincerely,
bitvijays

I'm not aware of something like this. :thinking:
I know that at sometime there was some plan to integrate Leshan in kapua but I don't know if this is always planned. (maybe you should ask them again)
If in your research you finally found something, just let me know :pray:

Do you find anything interesting to share ?
Should we close this issue ?

Thanks @sbernard31 for your support.

@bitvijays I found this recently https://github.com/thingsboard/thingsboard It seems it uses Leshan.
I never test it.

Thanks @sbernard31 :)


Keeps on trying to get access to contacts, reminders, photos

When I start nvim from home directory, and open a lua file in another directory (in my case ~/Desktop/somefolder/file.lua), I keep on getting popup messages that some subprocess of my terminal is trying to access contacts, reminders, and photos. Is there a way to disable filesystem search? I have following settings, but it still doesn't stop:
{
    "Lua.telemetry.enable": false,
    "Lua.workspace.maxPreload": 0,
    "Lua.workspace.library": {},
    "Lua.diagnostics.enable": false
}

Is it possible to hardcode directory paths that should be ignored? While in home directory, a reverse option would work better: allow only certain sub-directories.

Got around this by adding all the folders in my home directory to .gitignore file.

This should really be reopened I think. With raw language server configuration one can set "ignoredRootPaths": ["~"]  to avoid the server from scanning the entire home folder. There's no option to do the same with the extension.

Or maybe it's a coc.nvim issue.


Asus X99M WS motherboard could not write ReBarState UEFI variable

System

Motherboard:  ASUS X99M-WS，
BIOS Version:  4001
GPU:   RTX A6000 / Titan RTX

Description
Describe the issue here. Do not ask if it will work on a certain device try and see it yourself. Make sure CSM is off and 4G decoding is on
Doubled checked and confirm CSM is off / all UEFI only, and above 4G decoding is enabled.
Followed miyconst's youtube instruction to append the ReBar.fss to the BIOS downloaded from ASUS website, and flashed the modified BIOS back to the mobo using BIOS flashback successfully.
And then run into the following issue (as shown in photo) when running the ReBarState as Administrator .
`Writing value of 10 / 1024 MB to ReBarState
Failed to write ReBarState UEFI variable
GetLastError: 5
You can close the app now.`
Tried different inputs, for example 10, 20, 32 and 0, the returned errors are the same.

I just quickly looked into the code but was not able to  figure out what does GetLastError 5 mean.

You have to use UEFIPatch to fix this. It's described in the readme/wiki how to do it.

Thanks, just tried to apply UEFIPatch, and the I also checked the Pad-file content to make sure it's the same as the stock BIOS. And the Pad-file content does not seem to have issue.

So I wrote the patched BIOS back to the motherboard, enabled Above 4G decoding, disabled secure boot, and then ran ReBarState as Administrator, and it was able to modify the reg successfully this time.
However, after rebooting, the system just hang at boot screen code 99 (For ASUS motherboard, it means USB or legacy boot device error) though I've removed all USB drives already before booting. The screen is all black without even showing BIOS self-test or mobo vendor logo.
Just wondering where else could be wrong.

BTW, I'm able to restore the system by flashing the stock BIOS back using ASUS BIOS flashback without any issue, but re-flashing the patched/modified BIOS will still cause black boot screen.

@terryjx you have to disable CSM

Sorry it's a typo, the one disabled is CSM, not secure boot.

Just tried it again from scratch, and it's working now even with unlimited resizable bar size (key in 32).
Two interesting findings:

In GPU-z, it's still showing CMS not disabled, although I've disabled CSM in BIOS, is it the same for other people's case or just me?
2, The value of "Resizable BAR enabled in BIOS" is  still NO, does it matter?

In HWINFO, I can see the Resizable BAR size is now 64GB, does it mean that it's successful already?  The VRAM of RTX A6000 is 48GB, so I assume it's more than enough already.

@terryjx update your GPU-Z and it will display properly

Just tried with GPU-Z 2.51.0 which should be the latest version,  weirdly the incorrect information is still there.

Probably it's just a problem with GPU-Z, thanks for the help!

Posting my patched BIOS here, just in case anybody else wants to try it by themselves.
I only tried flashing it using ASUS BIOS Flashback function, so suggest you do it this way.
BTW, the .CAP file in the zip package is already renamed to the right format, so just extract it to a FAT16 or FAT32 USB thumb drive's root directory would be good to go.
X99MWS.zip

@terryjx I recommend you report this bug to GPU-Z developers since HWInfo has no problem detecting the 64GB BAR.

Just tried with GPU-Z 2.51.0 which should be the latest version, weirdly the incorrect information is still there.

Probably it's just a problem with GPU-Z, thanks for the help!

Can you confirm that this still happens with GPU-Z 2.57.0?


GraphQL / Photon timeout in aws serverless environment

Sample with reproducible issue: https://github.com/BradDC/graphql-broken
Description: This appears to affect only graphql in combination with photon specifically with aws lambda, when run locally there is no issue. It appears that data is returned normally from photon but the process might be continuing indefinitely eventually resulting in a timeout.
ref: https://github.com/prisma/prisma2/blob/master/docs/photon/api.md#debugging

Recommendation is to run photon.disconnect() - is there a good place to do that in the context of a graphql lambda server.
serverless.yml includes 3 paths as below.
✅path: /photon - working test of pure photon only call with plain http return.
❌path: / - full graphql lambda server including nexus, not working suspect as no location to run photon.disconnect() ?
❌path: /graphql - simplified graphql service, returns and works correctly only if photonTest.disconnect() is called after.

Additional Information:
tested with<EMAIL_ADDRESS>tested with<EMAIL_ADDRESS>

I can't reproduce this.
I deployed the exact same code here: https://zej6qrc3za.execute-api.ap-southeast-2.amazonaws.com/prod/
You will need to view it via a GraphQL API client eg graphql playground desktop or insomnia
It works:

Can you please check the logs and see the underlying issue?

logs simply indicate the lambda process timed out, the mutation used in your example looks different to the sample, are you working from a different example codebase?
11:50:54 am
START RequestId: 32c818b5-2fa2-4071-8d98-585dfffe3542 Version: $LATEST
11:51:04 am
END RequestId: 32c818b5-2fa2-4071-8d98-585dfffe3542
11:51:04 am
REPORT RequestId: 32c818b5-2fa2-4071-8d98-585dfffe3542	Duration: 10010.15 ms	Billed Duration: 10000 ms 	Memory Size: 1024 MB	Max Memory Used: 87 MB
11:51:04 am
2019-09-04T23:51:04.950Z 32c818b5-2fa2-4071-8d98-585dfffe3542 Task timed out after 10.01 seconds

My logs are fine:

I think we changed the connect mechanism in one of the recent releases. Can you please make sure that you are on the latest version of prisma2. Rerun prisma2 generate and try deploying this app

@BradDC Can you use the native Postgres connector and try to make a connection from your lambda. Could it be that it is a permission issue and the DB is not accessible from Lambda function?

Hello,
I think I am facing the same issue<EMAIL_ADDRESS>If the request takes "too large" it ends with time out.
I'm deploying on Zeit Now. Some requests respond 200, others 502. No issue on local.
2019-10-18T10:20:38.854Z b1976ac4-41a1-4150-b162-a8c898153ade Task timed out after 10.01 seconds

You can try : https://quiet-5xp2jkb4f.now.sh/graphql
{
  collections(first:20){
                    id
                    name
    	           owner {id}

  }
}

Take first 5, it works (even if it's long).

I tried to debug with now dev but definitely works locally.

On the free plan, the lambda execution time of Zeit now is limited to 10 secs so that is why it is failing for first: 20.
Where is your database hosted though? It feels pretty slow for this operation.
Locally there is no limit, so it works fine.
The workaround here would be to get a paid zeit plan.

 My DB is an RDS instance. It's really slow indeed, can't not figure out, why? My first assumption is that my query requests nested models and photon does not solve n+1 problem. Is that make sense?

I can't tell that without seeing your GraphQL implementation.
Note that currently, nexus prisma does introduce N+1 which we will solve before GA.

Yes, I noticed that. I am using graphql-yoga and nexus. I am newcomer in prisma & graphql ecosystem, I may missing something. It seems that implementation is quite basic

Your implementation looks fine. So preview software and slow RDS is to blame here.
The performance will increase in the coming weeks so stay tuned.

I am closing this one in favor of https://github.com/prisma/photonjs/issues/272 as it has a better reproduction.
I noticed that the last comment on this issue was in October, since then, we have made many performance improvement.
If you have an issue that is urgent/not covered by #272 or this. Please post a comment on #272 and tag me.
Thank you 🙂🙏


Planner: refactoring + packaging (WAR)

I refactored the code of the Planner in such a way to be compliant (in directories and packaging) together with other SeaClouds components.
The generation of the .WAR package file is also automatic and working.

@buccarel thanks for this PR
A couple of preliminary comments:

the PR can't be automatically merged, can you investigate why?
I can see you removed almost 50 files from the planner without replacing them: was it intentional?

Fixing very small issues.


Don't assign C versions of functions if we don't use them.

These two commits save an extra 236 bytes on MSVC. First commit saves 168, second one saves 68.

This was done initially to avoid running capability tests twice when someone tries to use zlib-ng from multiple threads. Instead of using mutexes which are not available on C code, it returns the default implementation.

I think in these cases the default/fallback implementation is determined at compile time rather than runtime.

The issue is if something in cpu_check_features causes switch from userland to kernel, which is slow. As we don't use thread-local storage yet, it's possible that the value isn't initialized when some other thread tries to access the stub.

Looks like that only applies to crc32_stub.

I made a commit that should fix that issue, and actually if that case were to happen where a thread accesses it before features have been checked, it will now use a better optimized crc32 function for the endianness.

Making something better is always more desired choice than introducing regressions in corner cases...

Looking at the preprocessor behavior, we entirely discount optimized versions of string comparisons if unaligned loads aren't legal and we know we have an unaligned access?
Strictly speaking, there are ways to do unaligned loads with VSX, VMX, and family, though they are a tad bit hairier.  If I remember correctly, Apple's documentation suggested the best way to deal with it is to partially overlap the previous unaligned load carried in the loop and recombine the register contents to a single full 128 bits of content.  Now, for 258 bytes...I dunno if this is that worthwhile, but, maybe?  I know that VMX specifically made unaligned loads a bit simpler, though, by doing something weird that modified endianness for some reason.

As far as I remember, big-endian PowerPC had instruction to calculate the shift amount required for two separate registers so the contents can be combined. This made unaligned loads a little bit cheaper than on architecture which can't calculate the shift amounts in same instruction. PowerPC also has "extra" offset parameter in most instructions.
The main issue is that compiler can still generate unaligned loads elsewhere if it tries to vectorize code during optimizations. With gcc it usually meant avoiding optimization level 3, which allowed vectorizing code that doesn't use vector intrinsics.

As far as I remember, big-endian PowerPC had instruction to calculate the shift amount required for two separate registers so the contents can be combined. This made unaligned loads a little bit cheaper than on architecture which can't calculate the shift amounts in same instruction. PowerPC also has "extra" offset parameter in most instructions.
The main issue is that compiler can still generate unaligned loads elsewhere if it tries to vectorize code during optimizations. With gcc it usually meant avoiding optimization level 3, which allowed vectorizing code that doesn't use vector intrinsics.

Hmm, I'm not sure how the elsewhere case affects this case though, where we are leveraging explicitly the vec_ family of intrinsics.  I suspect GCC would mostly leave that alone apart from rescheduling operations a little bit better for the target architecture.  The -O2 vs -O3 seems like it'd be a separate issue.
From what I recall with altivec, GCC kind of rarely autovectorizes code to begin with.  Though, I haven't tried it in a while (probably not since GCC 8).

@KungFuJesus I was thinking both about other big-endian architectures -- as those generally don't like unaligned accesses --  and also combining adjacent loads and stores originally using general-purpose registers.

@KungFuJesus I was thinking both about other big-endian architectures -- as those generally don't like unaligned accesses -- and also combining adjacent loads and stores originally using general-purpose registers.

Ah can't say I've dealt much with MIPS or Z. I do think an unaligned compare258 may be of benefit on PowerPC with altivec though. VSX's special unaligned load may make more sense on modern POWER.

I haven't had real PowerPC hardware since I changed jobs, so I can't do benchmarks even if I could write the code for compare258 using unaligned loads. Last time I used PPC version of Ubuntu inside qemu to learn AltiVec.

Do we even need the use_byfour? Seems like this can be controlled via UNALIGNED_OK preprocessor.

It looks like the use_byfour was an old detection that was used to determine if there is a 4 byte integer type. See https://github.com/zlib-ng/zlib-ng/commit/6c9bd474aa08312ef2e2e9655a80e18db24a1680.
We shouldn't have to do this check anymore since we are targeting newer systems.

Squashed two commits.


Need more customization api/props about handler color

This is a wonderful tool for image annotation. 💯
I have a problem that It is so hard to see those handlers when background color is grey, could u please add some props/api for its color?
It is difficult for me to change the source code because I am not a professional front-end developer. 😿

This is something that you can override with css:
.handle {
  stroke: "red",
  fill: "red",
  fill-opacity: .5;
}

Are you having issues with that?

Works like a charm, Thanks so much!


net/http: make Transport retry more aggressively on failures if GetBody is set

Make both the http1 and http2 Transports more aggressive on idempotent retries, if the new Go 1.8 Request.GetBody is defined. That means we can back up the Body and replay the whole request.
Go 1.8 uses that for redirects, but not for connection failures.
Do that in Go 1.9.

can I work on this? @bradfitz

Sure, if you're familiar with the http code. Note that we already did this for the http2 Transport (during server graceful shutdown in GOAWAY), so be sure to read that code first.

@bradfitz Thanks. I will spend some time this weekend.

Sorry for very late reply.
I started going through the code, to understand the problem correctly.
I noticed like you mentioned, http2 transport already creating the retry Request via Request.GetBody in http2shouldRetryRequest function inside h2_bundle.go
At the same time, in transport.go, the same operation is done via
pconn.shouldRetryRequest()
and
treq := &transportRequest{Request: req, trace: trace}
creating new request every time. Instead we have use to Request.GetBody to achieve that.
@bradfitz

To clarify: is this issue specifically about retrying on idempotent-method requests (GET/HEAD/OPTIONS/TRACE) which have non-nil Body but have GetBody set?

In Go 1.12 we now have the fix for https://github.com/golang/go/issues/19943#issuecomment-421092421 ....

Change https://golang.org/cl/147457 mentions this issue: net/http: make Transport respect {X-,}Idempotency-Key header


[FEATURE] UX - Command tree caching

Symptom
caios cli is quite slow and could be optimized.
Suggested Solution
Save generated CLI in local file with timestamp, and regenerate only if source py have modified.
First caios -h would cache everything.

@avitalyahel IMHO this should come from the importer optimization rather than DynaCLI.

@asterkin Ideally yes, question is what can come first.


[Draft] Low level http emitter

Emitter rendering the cadl as a http low level view

Does this output equivalent Cadl? Is that what "low-level HTTP" means?

Does this output equivalent Cadl? Is that what "low-level HTTP" means?

Yeah the idea is that it represent an equivalent http protocol. In a way thats easier to understand from the http layer.(Extract the body into its own parameter for example).
This however mean that the logical model representation of the cadl isn't the same but the http protocol definition should be. In other words you should be able to generate the same openapi3 document(At least equivalent in meaning)


examples

examples folder https://github.com/DannyBen/bashly/tree/master/examples
jupyter notebooks
example data https://github.com/opencultureconsulting/openrefine-batch/tree/master/examples/powerhouse-museum and https://github.com/opencultureconsulting/openrefine-task-runner

orcli 0.1.0 includes a getting-started tutorial with meaningful test data ("duplicates.tsv).


i256: Fix logical errors in doc comments for is_negative and is_zero

This should be less confusing ;)

PR on upstream instead


Change Success Screen message

When users are logged in using query params, they won't receive NFTs until they log in using their wallet. Instead of showing that the user received an NFT after completing as action while being logged in in this state, we want to show the default message

This issue is currently on hold until election day. Instead of using the custom message, we are displaying a single description about voter information, as shown in the screenshot below.

@twistershark what's the status on this? Does this issue still make sense?

@lucasrmp-cb This is still an issue if I'm not mistaken because users coming from CB app will not receive the NFT until they manually login on SWC, but on our current success screens, we show that the user has received an NFT even though they are not logged in with thirdweb.
I think that we should tweak the message just for clarity


Rewrite Full Project

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@a64ef98). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage        ?   64.15%
=======================================
  Files           ?       21
  Lines           ?      332
  Branches        ?       54
=======================================
  Hits            ?      213
  Misses          ?      119
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a64ef98...36d8de1. Read the comment docs.


Tessellating block in world - Indium Renderer

The game loads up until right after 100%, I hear campfires and footsteps from the villagers around my base, then it says "Saving World" and crashes the game.
Trying to read this log is giving me a bit of a headache
https://gist.github.com/pinkangel725/d9c83631f69eaf4fc4cb2821adef64a9#file-crashreport-txt
Would appreciate some help on this, as google searches haven't helped me much

Use Fabric API 0.88.1 to make Indium 1.0.25 work.
Or upgrade Sodium to 0.5.3 and Indium to 1.0.27.


Part 3: Make APIResource controller client calls scoped

Summary
Related issue(s)
Fixes #

/retest
/lgtm
/approve


GH-35445: [R] Behavior something like group_by(foo) |> across(everything()) is different from dplyr

Rationale for this change
The argument .cols of the dplyr::across function has the following description.

You can't select grouping columns because they are already automatically handled by the verb (i.e. summarise() or mutate()).

However, this behavior is currently not reproduced in the arrow package and an error occurs when selecting the column used for grouping with everything().
mtcars |>
  arrow::as_arrow_table() |>
  dplyr::group_by(cyl) |>
  dplyr::summarise(dplyr::across(everything(), sum)) |>
  dplyr::collect()
#> Error in `compute.arrow_dplyr_query()`:
#> ! Invalid: Multiple matches for FieldRef.Name(cyl) in mpg: double
#> cyl: double
#> disp: double
#> hp: double
#> drat: double
#> wt: double
#> qsec: double
#> vs: double
#> am: double
#> gear: double
#> carb: double
#> cyl: double
#> Backtrace:
#>     ▆
#>  1. ├─dplyr::collect(...)
#>  2. └─arrow:::collect.arrow_dplyr_query(...)
#>  3.   └─arrow:::compute.arrow_dplyr_query(x)
#>  4.     └─base::tryCatch(...)
#>  5.       └─base (local) tryCatchList(expr, classes, parentenv, handlers)
#>  6.         └─base (local) tryCatchOne(expr, names, parentenv, handlers[[1L]])
#>  7.           └─value[[3L]](cond)
#>  8.             └─arrow:::augment_io_error_msg(e, call, schema = schema())
#>  9.               └─rlang::abort(msg, call = call)

Created on 2023-05-05 with reprex v2.0.2
This PR fixes this behavior to match with dplyr's original behavior.
What changes are included in this PR?

Auto exclude grouping columns in across in mutate, transmute, and summarise.
The .data argument of internal function expand_across should be arrow_dplyr_query.
Some tests have been slightly modified to accommodate this change.
mutate, transmute, arrange, filter always return arrow_dplyr_query.
Currently, arrow_dplyr_query is not returned in the following cases, which was not consistent.mtcars |> arrow::arrow_table() |> dplyr::mutate()

Correct the order of columns in results of group_by(foo) |> mutate(.keep = "none")
Currently, the results of the following query show that the columns used for grouping have moved to the tail and differ from the behavior of dplyr.mtcars |> arrow::arrow_table() |> dplyr::group_by(cyl) |> dplyr::mutate(am, .keep = "none") |> dplyr::collect()

Correct the order of columns in results of group_by(foo) |> transmute()
Currently, the results of the following query show that the columns used for grouping have moved to the tail and differ from the behavior of dplyr.mtcars |> arrow_table() |> group_by(cyl) |> transmute(mpg) |> collect()

After transmute, the group columns move to the left.

Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.

Closes: #35445

I noticed that the column order is also wrong after select, but this is beyond the scope of this pull request, so I will create another issue.
> mtcars |> group_by(cyl) |> select(mpg) |> collect()
Adding missing grouping variables: `cyl`
# A tibble: 32 × 2
# Groups:   cyl [3]
     cyl   mpg
   <dbl> <dbl>
 1     6  21
 2     6  21
 3     4  22.8
 4     6  21.4
 5     8  18.7
 6     6  18.1
 7     8  14.3
 8     4  24.4
 9     4  22.8
10     6  19.2
# … with 22 more rows
# ℹ Use `print(n = ...)` to see more rows

> mtcars |> arrow_table() |> group_by(cyl) |> select(mpg) |> collect()
# A tibble: 32 × 2
# Groups:   cyl [3]
     mpg   cyl
   <dbl> <dbl>
 1  21       6
 2  21       6
 3  22.8     4
 4  21.4     6
 5  18.7     8
 6  18.1     6
 7  14.3     8
 8  24.4     4
 9  22.8     4
10  19.2     6
# … with 22 more rows
# ℹ Use `print(n = ...)` to see more rows


Add React 17 into peer dependencies

Hey @andregardi ,
This small change will remove warnings on install for those projects that are using React 17.
I have checked and seems like you are using several methods from React which were not have had any breaking (maybe even non breaking) changes.
Cheers. ;)

@andregardi ???


Does EMPIAR have a manifest or other straightforward way to discover all files in the catalog?

Summary of  meeting with Matt Iadanza:

EMPIAR .sch and associated EMPIAR API https://www.ebi.ac.uk/empiar/api/documentation/ SHOULD be sufficient for this but ISN'T because of poor metadata entry standards during deposition of many entries
One solution is to create a list of all known-compliant EMPIAR entries and only allow Empiarreader to use those, but has major disadvantage of inflexibility and limiting usage of the tool. So probably not the way forward?
Next step is to get in touch with EMPIAR contact (M. Iadanza offered to put us in touch soon) to figure out how they show the file directory structure of EMPIAR website (and web-interface of their ftp)
If no optimal solution is found from that, an alternative is to implement an ftp-parser/scraper which returns the full directory and file structure of a given EMPIAR entry and can be used in conjunction with user-supplied wildcard/regexp path to select files/directories for indiviudual download

Method for searching EMPIAR archive via:

entry #
dir path (optional)
wildcard/regexp path
is implemented in #33 on command line

Please review whether this closes this issue


Remove deprecated reference to ui-router

During the build a warning shows up, that angular-ui-router is deprecated in favor of @uirouter/angularjs. For some reason we have both in our package.json. The deprecated variant should be removed from there and the import-satements in app.js updated accordingly.

The full message:
[INFO] ><EMAIL_ADDRESS>install /home/rsinger/Workspace/webofneeds/webofneeds/won-owner-webapp/src/main/webapp/node_modules/angular-ui-router
[INFO] > node migrate/migratewarn.js
[INFO]
[INFO] WARNING! this npm package "angular-ui-router" has been renamed to "@uirouter/angularjs".  Please update your package.json
[INFO] See https://ui-router.github.io/blog/uirouter-scoped-packages/ for details.


Setting content-encoding header

I've got an issue in laravel with pushing files' metadata to s3, when I execute the following code:
\Storage::disk('s3')->getDriver()->put('image/'.$name, gzencode(file_get_contents($this->path)), ['ContentEncoding' => 'gzip', 'ContentType' => 'image/jpeg']);

And look in s3 to see what metadata is stored, I only see the Content-Type header. The same for:
\Storage::disk('s3')->getDriver()->put('file/'.$name, gzencode(file_get_contents($this->path)), ['ContentEncoding' => 'gzip', 'ContentType' => 'application/octet-steam', 'ContentDisposition' => 'attachment']);

Content encoding and content disposition are nowhere to be found, I can however set them manually and then the file decompresses/downloads as expected.

First, compressing JPEG image is unnecessary (you won't get smaller size and it will take more time to decompress on client).
But to solve your issue, I was able to set gzip headers on S3 this way (change their values as well as ACL and removev StorageClass if needed)
Storage::disk('s3')->getDriver()->getAdapter()->getClient()->upload(
    env('S3_BUCKET'),
    $s3_filename,
    $gzdata,
    'public-read',
    ['params' => [
        'ContentType' => 'application/json',
        'ContentEncoding' => 'gzip',
        'StorageClass' => 'REDUCED_REDUNDANCY',
    ]
]);

The ContentEncoding settings has been added to the metadata list and will now be properly forwarded.


if device not support web audio api

Is there support for using native html audio tags now?

hello?

No.


ci: try reproduce the CI error on tier3 (x86_64-unknown-dragonfly)

What does this PR do
Checklist:

[ ] I have read CONTRIBUTING.md
[ ] I have written necessary tests and rustdoc comments
[ ] A change log has been added if this PR modifies nix's API

Can reproduce this in both CI and my local Linux machine with nightly cargo 1.78.0-nightly (7065f0ef4 2024-03-12).
To reproduce:
$ cargo new foo
$ cd foo
$ cargo +nightly --version
cargo 1.78.0-nightly (7065f0ef4 2024-03-12)

$ cargo +nightly check -Zbuild-std --target x86_64-unknown-dragonfly
   Compiling std v0.0.0 (/home/steve/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std)
error[E0425]: cannot find function `getrandom` in crate `libc`
  --> /home/steve/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys/pal/unix/rand.rs:73:24
   |
73 |         unsafe { libc::getrandom(buf.as_mut_ptr().cast(), buf.len(), 0) }
   |                        ^^^^^^^^^ not found in `libc`

For more information about this error, try `rustc --explain E0425`.
error: could not compile `std` (lib) due to 1 previous error

And that function is indeed unavailable on DragonFlyBSD with libc 0.2.153.


disable ingress-ip controller as we are not allowing configuration of IngressIPNetworkCIDR

external IPs on services should be assigned manually and not automatically in microshift
followup to https://github.com/openshift/microshift/pull/1011#discussion_r1004232794 conversation

@dhellmann @zshi-redhat

So we don't need this controller because we are going to require users to set IPs on services themselves? I assume that only applies in the case where they want an IP other than the default one for the cluster?

/approve

So we don't need this controller because we are going to require users to set IPs on services themselves? I assume that only applies in the case where they want an IP other than the default one for the cluster?

Yes, applies to LoadBalancer services that need an external ingress IP set

/lgtm


[Request for Protected vars] Page 403 "Purchase Order Statistics"

Hello,
we need multiple vars in the Page 403 "Purchase Order Statistics" as protected vars in order to use them in our modfied calculation.
The vars we need are:
TotalAmount1: array[3] of Decimal;
TotalAmount2: array[3] of Decimal;
i: Integer;
VATAmount: array[3] of Decimal;
Thank you.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Address TODOs in the new .API module

The .API module, copied from the old .Aux module in consensus, contains a bunch of TODOs, mostly related to questions about spec (related: #706) and responsibilities (related: #708). These should be addressed.

Marking as medium priority because some of these TODOs are questions about "is this conform spec? to which we should really have an answer.


Drop osx builds with Node 0.12

As per https://github.com/nodejs/nan/pull/729#issuecomment-363618436, stop testing against Node.js 0.12 on OSX.

This is ready for review. @kkoopa PTAL.


Fixed tests for refs #24767 on databases that don't support microseconds.

buildbot, test on precise.


NLTK to SPACY Migration

Hi Alfred I did the NLTK to SPACY migration so please accept this pull request

Thank you Varatharaj for the contribution


⚠ Bofrost.lu has degraded performance

In 8e7db6e, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1639 ms

Resolved: Bofrost.lu performance has improved in 3fdaeab after 13 minutes.


Thermal ellipsoids

Options to render Coot's (thanks, Paul!) thermal ellipses with or without "Ortep" style.

This PR is kinda required to be able to compile/run with current Coot git. There is a caveat that showAniso/showOrtep options are not passed to get_bonds_mesh_for_selection_instanced. For this function these two params seem to be true, false. This means that some things (custom representations) will can only be drawn as thermal ellipsoids (at present).


Change .nav-tabs to use flex-wrap by default

Currently .nav-tabs uses flex without wrap to display, however when the viewport is narrower than the width of all of the tabs, they overflow.
With flex-wrap as default they'll continue to behave as they did with the previous versions, and flow underneath.
Without flex-wrap

With flex-wrap:

Dupe of #21660.


packages/external-dns: Service account annotations

What this PR does / why we need it
This commit adds support for workload identity when running ExternalDNS on GKE clusters.
Details for the Release Notes (PLEASE PROVIDE)
ExternalDNS can now be used on GKE clusters that have workload identity enabled.

Which issue(s) this PR fixes
Closes #2863
Describe testing done for PR
Added a set of unit tests to verify the ytt templates.
Special notes for your reviewer

Thanks for your contribution


Vickel: Watch onest.asia

Vickel requests the watch of the watch_keyword onest\.asia. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

onest\.asia has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Mast in Charcoal HQ

Approved by Makyen in Charcoal HQ


Make new ALL implementation for ClojureScript

ALL currently relies on core.reducers which much of ClojureScript appears to be incompatible with (e.g. #50). A different implementation specific to ClojureScript that still preserves collection types should be developed

Should look into using transducers for CLJS version. Transducers cannot be used for Clojure version because of need to maintain Clojure 1.6 compatibility

This is in master.


yuzu-{ea,mainline}: {2557,953} -> {2690,992}

Description of changes
This adds support for their in-app compatibility list, which previously did not work:

The compatibility list does not provide any stable URLs for downloads, so we have to include it in nixpkgs and refetch it every time the program gets updated.
I've also added an update script so that r-ryantm can update this, which is always nice. When running the script manually it updates both branches, and when running it from passthru.updateScript it only does so for the branch from the derivation.
We're now running unit tests as well, and using SDL from nixpkgs :)
The only thing left to do is replacing the icons, as they have an unfree license. Because of that yuzu won't get build by hydra, and compiling it takes a while. Not a great user experience.
cc @sbruder @JoshuaFern
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and “core” functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

I opened an issue upstream (https://github.com/yuzu-emu/yuzu/issues/8102) to ask about the feasibility of snapshots of the game compatibility database, though we can just include it in nixpkgs for the time being.
Also, in the time since you opened this PR, upstream changed the license to gpl3Plus, so this should also be reflected in this update.

I opened an issue upstream (https://github.com/yuzu-emu/yuzu/issues/8102) to ask about the feasibility of snapshots of the game compatibility database, though we can just include it in nixpkgs for the time being.

Sounds good :+1:

Also, in the time since you opened this PR, upstream changed the license to gpl3Plus, so this should also be reflected in this update.

Done. I've also updated both brances to the latest versions again. I think there should be nothing blocking this anymore :blush:

I've rebased this to the latest versions again, unless anyone has any objections I'll go ahead and merge this in a few days :+1:

seriously, a 1.2M file that could just be fetched from a archive site? please switch to using a archive site
$ fd --type f --size "+1MiB"
pkgs/applications/editors/emacs/elisp-packages/recipes-archive-melpa.json
pkgs/applications/emulators/yuzu/compatibility-list.json
pkgs/desktops/gnome/extensions/extensions.json
pkgs/development/haskell-modules/hackage-packages.nix
pkgs/development/node-packages/node-packages.nix
pkgs/development/r-modules/cran-packages.nix
pkgs/servers/monitoring/prometheus/webui/webui/package-lock.json
pkgs/tools/typesetting/tex/texlive/pkgs.nix
pkgs/top-level/all-packages.nix

this is seriously messing up my grepping @IvarWithoutBones


Add link for brand guidelines

Kind of issue

[x] Improvement
[ ] Bug
[ ] Other, namely:

Description
This request depends on https://github.com/simple-icons/simple-icons/pull/2846 being merged, see also https://github.com/simple-icons/simple-icons/issues/755.
Include a link to the brand guidelines of a brand in the .grid-item if such a link is available, e.g. following the original design on which the website is based.

Resolved by 3e8946e8e8c4a9e36e156ced72549b06233b5886

Resolved by 3e8946e8e8c4a9e36e156ced72549b06233b5886


(WIP)(dropbox-beta) package with usage of --pre

Description

@AdmiringWorm
This is a WIP of the dropbox-beta package accessible via choco install dropbox --pre.
This should take all the files needed for the beta builds from the normal package.
Motivation and Context

This will install the beta builds if users have selected it in dropbox settings
How Has this Been Tested?

Tested on my local network, AU grabbed the files and built the package. It at this time needs the s switch to have the proper location.
Screenshot (if appropriate, usually isn't needed):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package have been migrated from another repository)

Checklist:

[x] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this mean usually the notes in the description of a package).
[ ] I have updated the documentation accordingly (this mean usually the notes in the description of a package).
[x] All files is up to date with the latest Contributing Guidelines
[x] The added/modified package passed install/uninstall in the chocolatey test environment.
[x] The changes only affect a single package (not including meta package).

@RedBaron2 you could please rebase this one before you push the next update of the PR?
I made a few changes to the Test-RepoPackage script that's run by the appveyor PR building, which should fix an error that occurred for this PR (hopefully).

@AdmiringWorm
I hope that was the right way to do the rebase

@AdmiringWorm
How do we pass to Appveyor to run it with the  --pre  switch?

@RedBaron2 looks like your rebase went a little wrong, it came up as new commits instead.
Please review the rebasing mentioned in the choco CONTRIBUTING.md docs for how to do a correct rebasing, anyhow I've taken care of the rebasing for now though.

How do we pass to Appveyor to run it with the --pre switch?

Shouldn't be needed, the Test-RepoPackage script should actually pick that up automatically from the version. There was a little bad logic on my part in it though, so it didn't actually pick up the nupkg file at all from the dropbox-beta package (which is now fixed hopefully).

btw, the appveyor build will most likely always fail for this PR.
Because you have changed both the dropbox, and the dropbox-beta package (so it's unable to install the normal dropbox package and just returns an error message).

@AdmiringWorm
Thanks for the re-base. I will need to work on that step in the future.
I also reverted my change of the dropbox install file. Appveyor seems to be happy again.

@AdmiringWorm
Thanks for the re-base. I will need to work on that step in the future.
I also reverted my change of the dropbox install file. Appveyor seems to be happy again.

@AdmiringWorm
Should I change this to a PR or create a new one?

@RedBaron2 change it to a PR?
It already is a PR, just remove the (WIP) from the title, and request a review when it's ready.

@AdmiringWorm
Review please 😄
Title has been changed

@RedBaron2 Unfortunately I don't have the time (and probably not the willpower either) to review this PR right now, I'll see if I can't put in some time this weekend to do that though.

@AdmiringWorm
Whenever you have time is fine. 👍

@AdmiringWorm
I renamed the directory to be dropbox_beta
I don't use the dropbox package update file at all. So the elimination of global:au_SearchReplace would not be wise IMHO

thanks for your contribution, everything LGTM


Devise is marking email addresses generated by the Faker gem as invalid

Pre-check
I've been experiencing this issue for well over a year now, and periodically search the internet but to no avail.
Using the RSpec and Faker gems along with factory bot (6.1.0), I am generating test users. Often, the user will fail validations with "email is invalid".
Environment

Ruby 2.7.1
Rails 6.0.3
Devise 4.7.2

Current behavior
Here is my user factory:
FactoryBot.define do
  factory :user do
    first_name { Faker::Name.first_name }
    last_name { Faker::Name.last_name }
    username { Faker::Internet.username(specifier: 2, separators: %w[]) } # minimum 2 letters and only letters
    email {  Faker::Internet.email }
    password { 'Test1234!!' }
    password_confirmation { 'Test1234!!' }

    trait :customer do
      role { :customer }
    end

    trait :admin do
      role { :admin }
    end
  end
end

I expect this to always pass validation. Instead, I often get the following (not specifically with this spec, but for example):
Failure/Error: user { create(:user) }

     ActiveRecord::RecordInvalid:
       Validation failed: Email is invalid
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/evaluation.rb:18:in `create'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/strategy/create.rb:12:in `block in result'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/strategy/create.rb:9:in `tap'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/strategy/create.rb:9:in `result'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/factory.rb:43:in `run'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/factory_runner.rb:29:in `block in run'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/factory_runner.rb:28:in `run'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/strategy_syntax_method_registrar.rb:28:in `block in define_singular_strategy_method'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/evaluator.rb:43:in `method_missing'
     # ./spec/factories/comments.rb:5:in `block (3 levels) in <top (required)>'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/attribute/dynamic.rb:16:in `instance_exec'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/attribute/dynamic.rb:16:in `block in to_proc'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/evaluator.rb:85:in `instance_exec'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/evaluator.rb:85:in `block in define_attribute'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/attribute_assigner.rb:58:in `get'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/attribute_assigner.rb:16:in `block (2 levels) in object'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/attribute_assigner.rb:15:in `each'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/attribute_assigner.rb:15:in `block in object'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/attribute_assigner.rb:14:in `tap'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/attribute_assigner.rb:14:in `object'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/evaluation.rb:13:in `object'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/strategy/create.rb:9:in `result'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/factory.rb:43:in `run'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/factory_runner.rb:29:in `block in run'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/factory_runner.rb:28:in `run'
     # /Users/arimendelow/.rvm/gems/ruby-2.7.1/gems/factory_bot-6.1.0/lib/factory_bot/strategy_syntax_method_registrar.rb:28:in `block in define_singular_strategy_method'
     # ./spec/models/comment_spec.rb:12:in `block (2 levels) in <top (required)>'

Expected behavior
I expect to not have this error.

Do you have a custom email_regexp set on Devise?
I'm unable to repro this with a few tries of this small script: (using faker (2.17.0), devise (4.7.3))
% ruby -r faker -r devise -e "puts 1000.times.map { Faker::Internet.email }.reject { |e| Devise.email_regexp.match? e }.inspect"
[]

I don't, and I also never get this error with my seedfile (though that's creating many less users) - is it possible the error is with FactoryBot or RSpec?

Devise's default email regex is very simple and just aimed to avoid basic/common mistakes with emails. It also seems unlikely to be FactoryBot or RSpec in this case.
It sounds like that is something that may happen randomly at times with Faker? Are you able to add some logging that can at least output the email that's being tested with that fails, so we could reproduce it?
I don't think the email regex in Devise will change necessarily any time soon, but a way to see the email and repro it would be nice.
You might also want to try comparing those same emails with URI::MailTo::EMAIL_REGEXP which is a much more sophisticated regex, just to see if the same emails generated by Faker would match there.

There's no way to log that I know of - I've opened up an issue on the FactoryBot gem that will hopefully help shine some light.

Maybe instead of create a user, you build it, check for its validity, and output the user email if it doesn't validate or something like that?
Also please share your Devise.email_regexp, and if you have any other validations on the email field on your model.
Without any way to reproduce it or see some output / details of what could be causing the issue, I'm not gonna be able to offer much

Aha! Here's an example of an email that fails the regex<EMAIL_ADDRESS>I see now from looking at the regex that it'll fail any email addresses with less than 3 letters before the @. While rare, it's not impossible - see here for one crazy example.
Is this intentionally unsupported?

@arimendelow cool, that's good info.
I'm not sure where you see it will fail email address with < 3 chars in the username part? Is that configured on your app, perhaps in config/initializers/devise.rb?
Here's the current regex in Devise master: https://github.com/heartcombo/devise/blob/5d5636f03ac19e8188d99c044d4b5e90124313af/lib/devise.rb#L116
Testing it against the email you shared with 2 letters:
irb> Devise.email_regexp
=> /\A[^@\s]+@[^@\s]+\z/
irb> Devise.email_regexp.match<EMAIL_ADDRESS>=> true

We even have a test with email<EMAIL_ADDRESS>as a valid email: https://github.com/heartcombo/devise/blob/5d5636f03ac19e8188d99c044d4b5e90124313af/test/devise_test.rb#L98-L99

Yup, look at that. I'm using the following custom regex -
  /             start of regex
  \A            match start of string
  \w+           at least one word character
  [\w+\-.]+     at least one word character, plus a hyphen or dot
  \w+           at least one word character
  @             exactly one literal at sign
  [a-z\d]+      at least one letter or digit
  [a-z\d\-.]+   at least one letter, digit, hyphen, or dot
  [a-z\d]+      at least one letter or digit
  \.            exactly one literal dot
  [a-z]{2,}     at least two letters
  \z            match end of string
  /             end of regex
  i             case insensitive

Now that I see it, it's coming back to me. This is an older project that I had migrated over to Devise and kept the regex, I completely forgot about it :) Thanks for all the help! Will close this issue.
And thanks for all the work you do on Devise, by the way. Absolute gem of a gem.

Cool, mystery solved :). Thanks!


Error extracting text from PDF exec: "pdftotext": executable file not found in %PATH%

I followed this tutorial for windows:
https://www.reddit.com/r/ChatGPT/comments/12qbrmw/comment/jhptv12/?utm_source=reddit&utm_medium=web2x&context=3
and I'm getting this error:
Error extracting text from PDF exec: "pdftotext": executable file not found in %PATH%
[negroni] Apr 18 14:44:58 | 200 | 26.1222ms
POST /upload

I also have this error and not found solution yet

You need to install poppler:
https://github.com/pashpashpash/vault-ai/issues/16#issuecomment-1514546452


elaboration of ^ shouldn't try to put the arguments in the same type

Description
The macro for the ^ notation for exponentiation is defined as
macro_rules | `($x ^ $y)   => `(binop% HPow.hPow $x $y)

However, the binop% elaborator tries to make the type of x and y the same, which is not desired for exponentiation.
MWE
class NatCast (R : Type u) where
  natCast : Nat → R

instance [NatCast R] : CoeTail Nat R where coe := NatCast.natCast
instance [NatCast R] : CoeHTCT Nat R where coe := NatCast.natCast

axiom Real : Type
notation "ℝ" => Real

instance (n : Nat) : OfNat ℝ n := sorry

variable (a : ℝ)

instance natCast : NatCast ℝ where natCast n := sorry
instance : HPow ℝ Nat ℝ := sorry

set_option pp.all true

#check a ^ 4
-- @HPow.hPow.{0, 0, 0} Real Nat Real instHPowRealNat a (@OfNat.ofNat.{0} Nat 4 (instOfNatNat 4)) : Real

instance : HPow ℝ ℝ ℝ := sorry

#check a ^ 4
-- @HPow.hPow.{0, 0, 0} Real Real Real instHPowReal a (@OfNat.ofNat.{0} Real 4 (instOfNatReal 4)) : Real

#check a ^ (4 : Nat)
-- @HPow.hPow.{0, 0, 0} Real Real Real instHPowReal a (@NatCast.natCast.{0} Real natCast (@OfNat.ofNat.{0} Nat 4 (instOfNatNat 4))) : Real

The desired result is that all checks use the instHPowRealNat instance, i.e. that 4 is interpreted as a Nat.
Additional Notes
Just removing binop% and replacing the macro with the following fixes the current issue, but it causes problems in other elaboration problems.
macro_rules | `($x ^ $y)   => `(HPow.hPow $x $y)

With this macro an example like the following fails.
example (n : Nat) := ∃ k, n = 2 ^ k -- fails to find any instance, needs to know the type of `k`

Zulip Discussion
link

The idea is to have a default instance for Pow here:
macro_rules | `($x ^ $y) => `(HPow.hPow $x $y)

class Semiring (R : Type) extends Pow R Nat
instance : Semiring Nat where
@[default_instance high] instance [Semiring R] : Pow R Nat := inferInstance

example (n : Nat) := ∃ k, n = 2 ^ k -- works fine

(We have that instance in Mathlib/Algebra/Group/Defs.lean btw.)

@gebner A design I've been thinking about that would help with HPow and other sorts of functions that are more actions than operators would be to have a couple additional term elaborators that participate in the "binop%" algorithm. I don't think we actually want the algorithm to ignore both the arguments to HPow, but rather it should descend into the base of the exponent (and similarly in mathlib, we want it to descend into the second argument of SMul). In both cases, the acted-upon argument should have a type that's compatible with the whole arithmetic expression.
 Then we would have
macro_rules | `($x ^ $y)   => `(actionop1% HPow.hPow $x $y)

The effect is that x would still be coerced to the common type that the elaborator solves for, but y will be left untouched, letting it remain a Nat for example even in a Real expression.
Another design would be to adjust unop% to allow these lambdas and to do beta-reduced application. Then we'd have
macro_rules | `($x ^ $y)   => `(unop% (fun x' => HPow.hPow x' $y) $x)

I have a prototype of my suggestion at https://gist.github.com/kmill/bc58941368cc60738f3c932fe2546c9d
With it, we can see the following behavior:
import Mathlib.binop2
import Mathlib.Data.Real.Basic

#check (3 : ℝ) ^ 2
-- 3 is real
-- 2 is a nat

#check (1 : ℝ) + 3 ^ 2
-- 1 is real
-- 3 is real
-- 2 is a nat

#check (1 + 3 ^ 2 : ℝ)
-- 1 is real
-- 3 is real
-- 2 is a nat

In particular, exponentiation is modeled as a right action, and only the LHS participates in the coercion protocol.
We'll see how it works in practice in some mathlib files, and then if it seems good I'll create a PR. I think it only involves adding about 15 lines.

An undergraduate just ran into this issue: they had a working file, and then added an import, and a simp only call which was closing a goal stopped working. I told them to add local macro_rules | `($x ^ $y) => `(HPow.hPow $x $y) to the top of their file; this fixed it.
import Mathlib.RingTheory.RootsOfUnity.Basic
import Mathlib.Data.Complex.Basic
-- uncomment this import to break the proof
--import Mathlib.Analysis.SpecialFunctions.Pow.Complex

-- uncomment this hack to fix it again
--local macro_rules | `($x ^ $y) => `(HPow.hPow $x $y)

example (q : ℕ+) : ζ ∈ rootsOfUnity q ℂ ↔ ((ζ : ℂˣ) : ℂ) ^ ((q : ℕ+) : ℕ) = 1 := by
  simp only [mem_rootsOfUnity']
  done

The solution of adding local macro_rules | ($x ^ $y) => (HPow.hPow $x $y) can change elaboration in weird ways however, see for instance
import Mathlib.Analysis.SpecialFunctions.Pow.Real

-- local macro_rules | `($x ^ $y) => `(HPow.hPow $x $y)

lemma foo (t : ℝ) (ht : 3 ≤ t) : 12 * t + 1 ≤ 13 * t ^ 2 := sorry

in which uncommenting the macro changes the elaboration of 12 (and in my case also broke a proof)

https://github.com/leanprover-community/mathlib4/pull/6852 has a large-scale experiment with my modifications to the binop% elaborator. It switches to marking HPow as a right action and mathlib's HSMul as a left action. It took some tweaking of type ascriptions, but overall it seems to be an improvement (it seems you can usually just delete the local macro_rules fixes!)
In Bhavik's example, the conclusion elaborates as (12 : ℝ) * t + (1 : ℝ) ≤ (13 : ℝ) * t ^ (2 : ℕ). (To be clear, as OfNat literals, not as coerced literals.)


Change the Twitter icon to X icon

Description
I want to change the Twitter icon to the X icon.I would be grateful if you assign me this issue under gssoc-ext,hacktoberfest-accepted.my GitHub username is @Bhanuprakash842
Screenshots

Any additional information?
No response
What browser are you seeing the problem on?
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@Bhanuprakash842 you are assigned.
Do one thing: instead of the Twitter icon, add the GitHub icon and insert the Ezyshop GitHub repo link. In the LinkedIn icon, insert the LinkedIn link found in the README.md, and instead of Facebook, add the Discord icon and include the Discord invite link, which is also available in the README.md.


Jadeite and unicode

Currently it appears that Jadeite does not handle unicode strings correctly:

Here is the unicode text I used for the experiment:
Unicode16: 'Я можу їсти скло, і воно мені не зашкодить.'

Unicode32: '𣎏'

in case this is still needed


Remove more dependencies from requirements.txt

When setting up Ambuda dev environment from scratch, these dependencies (grpc, lxml) take the longest to download and install, but as far as I can tell (based on text search of the repo's code) they are not actually used. (How to check?)

Sadly some of these might be transitive. The only way I know how to check is by grepping within the env folder.
For example, I see grpcio is referred to by the google cloud vision API code, and lxml is referred to by fontTools <- aksharamukha (???) <-  indic_transliteration (???).
@vvasuki might be worth creatnig a build of indic_transliteration that doesn't depend on such heavy dependencies like aksharamukha and selenium (https://github.com/indic-transliteration/indic_transliteration_py/blob/master/requirements.txt).

@vvasuki might be worth creating a build of indic_transliteration that doesn't depend on such heavy dependencies like aksharamukha and selenium (https://github.com/indic-transliteration/indic_transliteration_py/blob/master/requirements.txt).

कृतम्।

This makes sense, thanks!
(Looks like ripgrep was too clever and skipped the env folder, so I hadn't found these earlier.)


[QT-Wallet] Change wallet instance folder name title need to be changed.

Description:
Change "Wallet instance" page Title need to be changed.
Steps to reproduce

Open QT wallet
Click "Wallet Instance" link
Verify the Title of the page

Expected Result:
"Wallet instance" page Title need to be changed from "Select mwc713 folder name" to "Select MWC QT-Wallet folder name".
Please refer screenshot,

Modal dialogs can't change anything outside themselves.
Dialog has a title "Select mwc713 folder name".  Title looks simple because it is how UI style is defined.

This UI doesn't exist any more and new one handle wallet names fine.


Can’t get version number

Describe the bug
I noticed that it’s not always possible to get the currently installed version of swiftDialog using --version. Seems this happens if you try shortly after installing and/or before running for the first time.
Will add the error message I found shortly.
To Reproduce
Install swiftDialog and run dialog --version.

Here's the error message I see in my script log when it fails to get the version number.
Failed to get user context: 156: Domain creation with that UID is not allowed anymore

can you check this with 2.5.2

I honestly have no clue how to reproduce the issue, just saw it a couple of times and I think it was on ‘less powerful’ (slower, Intel) machines. But I will keep you posted if I might see it again.

Ah, you might be correct on this, however I didn’t check specifically. Has probably to do with how swiftDialog runs as current user?


[No QA] Fix/52558 fix card name and images

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/52558
PROPOSAL:
Tests

IMAGES
Check if the card icon sizing is appropriate on:

Card List page (feed selector),
Feed Selector page,
Members -> Member Details -> New Card page (accessed after clicking New Card)
Wallet main page (cards section)

CARD NAME

verify that the "[FirstName]'s card" is displayed as a fallback for the cards that had no name displayed after issuing

verify that the newly created Expensify Cards will have the "card" lowercased

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Should the card have rounded edges?
I would think yes - not sure if that's something we should do on the svg itself or if that comes from a style we apply?

@shawnborton 🤔 Hmm, interesting. It looks like the SVGs do have rounded corners?

@dannymcclain we no longer use the icons from the company cards folder - we use the ones saved in companycards/large
still, it's strange as the icons from the 'large' folder also have the corners rounded
cc @mountiny

@dannymcclain @shawnborton what is the appropriate border radius for the small card icons - in the lists?

after the lates changes

Nice, that's feeling better! Looks like we're using 4 for the border radius of the small cards in Figma.

@shawnborton fixed

@mountiny and what about this one? https://github.com/Expensify/App/pull/52735#issuecomment-2491116917

I fixed the problem with the cards in Search
cc @joekaufmanexpensify

@allgandalf addressed

@mountiny conflicts resolved. Text truncated

cc @allgandalf

For the truncation part... is it better to just show the last 4 digits on mobile? Otherwise you basically see the same exact numbers there and it isn't super helpful.

Agree. I'm not sure we can truncate the last 4 here. @shawnborton do you think it'd be better to:

never truncate the number and truncate more of the name
do both like we're doing here but truncate the beginning of the card number instead of the end
just show last 4 on mobile like you suggested?

do both like we're doing here but truncate the beginning of the card number instead of the end

I could get down with something like this

🤔 Hmm, if we're considering truncating the beginning of the card number... Is there any reason not to just go ahead and only show the last 4? If you can't see the beginning, are the middle card numbers particularly helpful at all?

I also changed the header to "Last 4" instead of "Card Number" when only 4 last digits are displayed for mobile/narrow screen.

@allgandalf fixed

I think that is good!

If any other changes will be necessary, I suggest to do it as a follow-up PR as it'll be more changes in the code.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

IMAGES
Check if the card icon sizing is appropriate on:
Card List page (feed selector),
Feed Selector page,
Members -> Member Details -> New Card page (accessed after clicking New Card)
Wallet main page (cards section)

Art looks good everywhere!

CARD NAME
verify that the "[FirstName]'s card" is displayed as a fallback for the cards that had no name displayed after issuing

Confirmed.

verify that the newly created Expensify Cards will have the "card" lowercased

Not sure where I am supposed to check this. Asking!

Asked

@joekaufmanexpensify for the physical Expensify Card if you don't change the default name during the issuing process

Got it. Tested and confirmed default name is %Firstname's% card and card is lowercased.


rememberPagerState() update makes basing two Pagers off of one state impossible?

Describe the bug
I was using rememberPagerState() populated with an initial page count because I have two different pagers on the screen that are driven by a single state. Now that page count has to be passed as an arg into HorizontalPager, it seems like that ability is now lost.
To Reproduce
This is what I was using before and I was driving two pagers off of this state.
val pagerState =
rememberPagerState(
pageCount = viewModel.state.items.size)
Am I doing something wrong? When I scroll through one pager, the other pager doesn't change.
Edit: Another example of things not working correct is that I have Text(pagerState.currentPage) and that doesn't update ever. It starts at 1, and even though I'm scrolling through my HP it just stays at 1. This was also working before but is now broken. I'm assuming this is because my pagerState doesn't know how many items and therefore doesn't know it's current page?

Hey! yes, one PagerState or LazyListState cannot really be used with multiple components. reason is your different components can be displaying different content - with different items count, or different items sizes, different content paddings. If we take Pager as an example, imagine they display items with different content padding, then in order to scroll from one item to the next one they need different amount of pixels to be scrolled. Even for PagerState it was mostly accidentally working for you previously.
It should be theoretically possible to just sync the scroll positions of two states, like when one changes do similar change for another one


enum support in 0.12 breaks --derive Default

the enums generated by 0.12 (#65) don't label which variant is the default, so if you try using --derive Default, you will end up with a lot of errors like
error: no default declared
    --> foo/bar/baz.rs:1116:48
     |
1116 | #[derive(Serialize, Deserialize, Clone, Debug, Default)]
     |                                                ^^^^^^^
     |
     = help: make a unit variant default by placing `#[default]` above it
     = note: this error originates in the derive macro `Default` (in Nightly builds, run with -Z macro-backtrace for more info)

oh, there's not a great way to solve this; what are we supposed to do?

if the enum is nested within a struct that derives default, then the enum needs to impl Default (so we can't just skip it for enums)
we can't just pick a default (if it's not specified in the schema)

So either we have to tell the user to impl Default for EnumVariant or we have to bail! if there's no specified default in the schema. Not sure what is good to do here immediately.

Actually, I think the sane thing for us to do is to:

never add #[derive(Default)] to an enum
if we see a default value in the schema; then add a special impl Default for ThatEnum
if we don't see that; leave it missing, requiring the user to impl Default for ThatEnum

Master has a partial fix for this now. We will no longer add #[derive(Default)] to enums.
This will still end up not compiling in the larger context, but you can at least now sideload a impl Default for the enum to fix it. We can never truly fix this for all cases (if it's not in the schema), and for the cases we can cover, I'll defer to issue #67.

Thanks very much for this @clux , I was just about raise this and suggest that exact solution.


Add Go SDK generation config

Automation for azure-sdk-for-python

Fixes https://github.com/Azure/azure-sdk-for-go/issues/1246

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-go

    AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.
File: specification/security/resource-manager/readme.md

:warning:0 new Warnings.(76 total)

:x:0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback
Thanks for your co-operation.

    AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.
File: specification/security/resource-manager/readme.md

:warning:0 new Warnings.(1 total)

:x:0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback
Thanks for your co-operation.

Automation for azure-sdk-for-java

Automation for azure-sdk-for-node

@chlahav there seems to be a problem with the swagger, are the 2 api version specs compatible ?
The following error shows up when trying to generate the Go SDK:
FATAL: System.InvalidOperationException: Found incompatible property types ,  for property 'properties' in schema inheritance chain

@vladbarosan We try to move to language configuration in its own file readme.go.md. Could it be done this way? Thanks!
Not critical.

@lmazuel  sure will update either wont merge until the generation actually works

    AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.
File: specification/security/resource-manager/readme.md

:warning:0 new Warnings.(1 total)

:x:0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback
Thanks for your co-operation.

    AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.
File: specification/security/resource-manager/readme.md

:warning:0 new Warnings.(74 total)

:x:0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback
Thanks for your co-operation.

    AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.
File: specification/security/resource-manager/readme.md

:warning:0 new Warnings.(74 total)

:x:0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback
Thanks for your co-operation.

    AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.
File: specification/security/resource-manager/readme.md

:warning:0 new Warnings.(1 total)

:x:0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback
Thanks for your co-operation.

@lmazuel is there a way to re trigger the go generation to see if it works ?

@AutorestCI rebuild azure-sdk-for-go

Encountered a Subprocess error
Command: ['/usr/local/bin/autorest', '/tmp/tmpyk8g9yg0/rest/specification/security/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpyk8g9yg0/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=<EMAIL_ADDRESS>'--use-onever', '--verbose']
Finished with return code 1
and output:
AutoRest code generation utility [version: 2.0.4280; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core<EMAIL_ADDRESS>(2.0.4280)
   Including configuration file 'file:///tmp/tmpyk8g9yg0/rest/specification/security/resource-manager/readme.go.md'
   Loading AutoRest extension<EMAIL_ADDRESS>(~2.1.105->2.1.105)
   Loading AutoRest extension<EMAIL_ADDRESS>(2.3.38->2.3.38)
Processing batch task - {"tag":"package-composite-v1"} .
   Including configuration file 'file:///tmp/tmpyk8g9yg0/rest/specification/security/resource-manager/readme.go.md'
FATAL: System.InvalidOperationException: Found incompatible property types ,  for property 'properties' in schema inheritance chain
   at AutoRest.Modeler.SchemaResolver.ExpandAllOf(Schema schema) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaResolver.cs:line 157
   at AutoRest.Modeler.SchemaResolver.Unwrap(Schema schema) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaResolver.cs:line 75
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 35
   at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 271
   at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 66
   at AutoRest.Modeler.Program.<ProcessInternal>d__2.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\Program.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: go/imodeler1 - FAILED
FATAL: Error: Plugin imodeler1 reported failure.
Process() cancelled due to exception : Plugin imodeler1 reported failure.
Failure during batch task - {"tag":"package-composite-v1"} -- Error: Plugin imodeler1 reported failure..
  Error: Plugin imodeler1 reported failure.

@vladbarosan it seems it doesn't :(

@lmazuel thanks for the command. Yes I noticed the problem is that it seems to be a modeler error which seems to point to a swagger issue FATAL: System.InvalidOperationException: Found incompatible property types ,  for property 'properties' in schema inheritance chain

Merging and https://github.com/Azure/azure-rest-api-specs/pull/3453 should fix generation issues


LTRIM bug

Ardb(left) vs Redis2.8(right)
ltrim items

ltrim 1000 items out of range

ltrim offset

fixed in last commit

lgtm


Added details for indexing triage meeting

Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]

Check List

[ ] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross @peternied

@ankitkala Thanks for this update