Add abbreviation recognition for subcommands and options

Currently using code snippet from @remkop #732 with minor changes.
For ease of debugging, the NameMatcher class is in separate file for now.
This is a draft, no javadoc are added yet, and tests may not cover all cases.
Feedbacks are welcomed!
This draft's goal is to resolve #10 and resolve #732.

Codecov Report

Merging #1047 into master will decrease coverage by 0.16%.
The diff coverage is 79.45%.

@@             Coverage Diff              @@
##             master    #1047      +/-   ##
============================================
- Coverage     94.35%   94.18%   -0.17%
- Complexity      443      461      +18
============================================
  Files             2        3       +1
  Lines          6482     6555      +73
  Branches       1735     1757      +22
============================================
+ Hits           6116     6174      +58
- Misses           94      100       +6
- Partials        272      281       +9

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/picocli/CommandLine.java
94.13% <79.16%> (-0.06%)
307.00 <3.00> (+3.00)
:arrow_down:

src/main/java/picocli/NameMatcher.java
79.59% <79.59%> (ø)
15.00 <15.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee28eb1...7137d68. Read the comment docs.

This currently does not work with case-insensitive mode, because the match function does not take it into consideration.
For POSIX options, the current implementation will prioritize full name, and in this case, also the abbreviation. For example, if we have three options: -A, -B and --ABC, if the input is -AB, this PR will match --ABC instead of -A and -B, which is counter-intuitive.
Also, if there are options --a-B, --aB, -a, -B... this will currently be unable to process. (Always throws a ParameterException!)
I think the behaviour of this feature should be: full-match > posix-match > abbrev-match? If this is the case, we may make the entire part of pre-processing options to a method, and call with original arg first, then try to match POSIX, if both failed, call the method again with matched arg.

Another way is to limit abbreviations to long options only (options starts with --), so it will probably not conflict with POSIX options.

Not sure how to splitIntoChunks with case-insensitivity...

Any thoughts on behaviour about case-insensitivity and POSIX options mentioned above?

Bedtime for me. I’ll take another look tomorrow.

I haven't had a chance yet to sit down and think clearly about the interaction between case insensitive mode, posix short options, negatable options and abbreviated options. It is possible that some combinations will always give counter-intuitive results.
I would be fine with reducing scope, like leaving negatable options out of scope: for example, we could recognize the abbreviated original option, but the negatable form must always be specified fully and cannot be abbreviated. Just an idea.
The examples you provided are useful to help list up and think through the possible combinations. I just need to find a block of time where I can focus on this. I may not be able to do so this weekend.
Abbreviated commands are easier. One idea is to (initially?) only provide this feature for subcommands.

Actually the negatable form options does work since 747720c.
Feel free to take your time, I am not in a hurry. 😀

It makes sense to me that we only split blocks using hyphen (ignore cammelCase) in case-insensitive mode.

Also, if there are options -A, -B and -AB, if user inputs -AB, picocli will match -AB instead of -A and -B (full option name match has higher priority than POSIX cluster-options). So we can define a priority for options matching and let the users to avoid ambiguity.

Codecov Report

Merging #1047 into master will decrease coverage by 0.08%.
The diff coverage is 86.74%.

@@             Coverage Diff              @@
##             master    #1047      +/-   ##
============================================
- Coverage     94.35%   94.26%   -0.09%
- Complexity      443      466      +23
============================================
  Files             2        3       +1
  Lines          6482     6573      +91
  Branches       1735     1757      +22
============================================
+ Hits           6116     6196      +80
- Misses           94       99       +5
- Partials        272      278       +6

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/picocli/CommandLine.java
94.13% <81.81%> (-0.06%)
306.00 <3.00> (+2.00)
:arrow_down:

src/main/java/picocli/AbbreviationMatcher.java
90.00% <90.00%> (ø)
21.00 <21.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee28eb1...9f5a525. Read the comment docs.

Hi @remkop, any new idea on this?

Sorry I’ve had other commitments, I’ll try to take another look tomorrow morning.

I finally had time to take a look.
Overall, this is very good progress!

let's move the abbreviation-related tests from CommandLineTest to AbbreviationMatcherTest
can we add tests for abbreviated options in case-insensitive mode?

On the topic of matching abbreviated options:

I don't think we should restrict this to options that start with --

//picocli.CommandLine.Interpreter#processArguments
if (commandSpec.parser().abbreviatedOptionsAllowed() && arg.startsWith("--")) {

should be
if (commandSpec.parser().abbreviatedOptionsAllowed()) {

There may be a bug in our implementation: abbreviations should not abbreviate the non-alphanumeric prefix. If an option is defined as --x-y then even in abbreviated mode, we should not match -x, -x-y or -xY, only --x, --x-y and --xY. If we fix that, it should resolve the problem you mentioned:

... if there are options --a-B, --aB, -a, -B... this will currently be unable to process if user inputs -aB. (Always throws a ParameterException!)

The previous point would also resolve the interaction you mentioned between abbreviations and POSIX options. In your example with three options -A, -B, and --ABC, user input -AB, should be matched being matched as -A and -B, not as the long option --ABC, because the non-alphanumeric prefix is significant. However, user input --AB will be matched as the long option --ABC, not as the POSIX options  -A and -B. This is unambiguous.

In case-insensitive mode, users can only abbreviate options with hyphens, so if an option is defined as -CamelCaseOption then users can only abbreviate as -c-c-o; we will not match -CCO as an abbreviation. That is a limitation of combining abbreviations with case-insensitive options. As long as we document this I believe this is fine.

Correction: I said

if an option is defined as -CamelCaseOption then users can only abbreviate as -c-c-o ...

This is incorrect. In case-insensitive mode, we cannot distinguish chunks by case any more, so we can recognize -CamelCas or -came as an abbreviation, but not -c-c-o or -CCO.
We can still recognize chunks (even in case-insensitive mode) if the option is defined in kebab-case, and the user specifies chunks in kebab-case.
I believe the below tests are reasonable:
@Test
public void testAbbrevOptionsCaseInsensitive1() {
    class App {
        @Option(names = {"-CamelCaseOption"}) boolean camelCaseOption;
    }

    try {
        new CommandLine(new App()).setAbbreviatedOptionsAllowed(true).setOptionsCaseInsensitive(true).parseArgs("-CCO");
        fail("Expected exception");
    } catch (CommandLine.UnmatchedArgumentException ex) {
        assertEquals("Unknown option: '-CCO'", ex.getMessage());
    }

    try {
        new CommandLine(new App()).setAbbreviatedOptionsAllowed(true).setOptionsCaseInsensitive(true).parseArgs("-c-c-o");
        fail("Expected exception");
    } catch (CommandLine.UnmatchedArgumentException ex) {
        assertEquals("Unknown option: '-c-c-o'", ex.getMessage());
    }
    App app = new App();
    new CommandLine(app).setAbbreviatedOptionsAllowed(true).setOptionsCaseInsensitive(true).parseArgs("-came");
    assertTrue(app.camelCaseOption);
}

@Test
public void testAbbrevOptionsCaseInsensitive2() {
    class App {
        @Option(names = {"-kebab-case-option"}) boolean kebabCaseOption;
    }

    try {
        new CommandLine(new App()).setAbbreviatedOptionsAllowed(true).setOptionsCaseInsensitive(true).parseArgs("-KCO");
        fail("Expected exception");
    } catch (CommandLine.UnmatchedArgumentException ex) {
        assertEquals("Unknown option: '-KCO'", ex.getMessage());
    }
    App app = new App();
    new CommandLine(app).setAbbreviatedOptionsAllowed(true).setOptionsCaseInsensitive(true).parseArgs("-k-c-o");
    assertTrue(app.kebabCaseOption);

    app = new App();
    new CommandLine(app).setAbbreviatedOptionsAllowed(true).setOptionsCaseInsensitive(true).parseArgs("-kebab");
    assertTrue(app.kebabCaseOption);
}

Now we enforce the non-alphabetic prefix matching on abbrev options, which (hopefully) solves the previous issues.
Case-insensitive abbrev options tests from @remkop added, and they all passed. 😄

Where should AbbreviationMatcher go though? Another static class in CommandLine.java seems good.

I'm fine with making AbbreviationMatcher a private static class in CommandLine.
Question: does this test pass?

@Test
public void testAbbrevOptionsAmbiguous() {
    @Command
    class App {
        @Option(names = "--a-B")
        public boolean a_b;

        @Option(names = "--aB")
        public boolean aB;

        @Option(names = "-a")
        public boolean a;

        @Option(names = "-B")
        public boolean B;
    }

    App app = new App();
    new CommandLine(app).setAbbreviatedOptionsAllowed(true).parseArgs("-aB");
    assertFalse(app.a_b);
    assertFalse(app.aB);
    assertTrue(app.a);
    assertTrue(app.B);

    app = new App();
    new CommandLine(app).setAbbreviatedOptionsAllowed(true).parseArgs("--aB");
    assertTrue(app.a_b);
    assertTrue(app.aB);
    assertFalse(app.a);
    assertFalse(app.B);
}

If there are options -A, -B and -AB, the ambiguity may be unavoidable. If we have document about this it should be fine.
The current impl will pass the following test:
    @Test
    public void testPOSIXClusterOptionsWithAbbrevOptions() {
        @Command
        class App {
            @Option(names = "-A")
            public boolean a;

            @Option(names = "-B")
            public boolean b;

            @Option(names = "-AB")
            public boolean ab;
        }

        CommandLine commandLine = new CommandLine(new App());
        commandLine.setAbbreviatedOptionsAllowed(true);

        ParseResult result = commandLine.parseArgs("-AB");
        assertFalse(result.hasMatchedOption("-A"));
        assertFalse(result.hasMatchedOption("-B"));
        assertTrue(result.hasMatchedOption("-AB"));

        result = commandLine.parseArgs("-A");
        assertTrue(result.hasMatchedOption("-A"));
        assertFalse(result.hasMatchedOption("-B"));
        assertFalse(result.hasMatchedOption("-AB"));
    }

I'm fine with making AbbreviationMatcher a private static class in CommandLine.
Question: does this test pass?
@Test
public void testAbbrevOptionsAmbiguous() {
    @Command
    class App {
        @Option(names = "--a-B")
        public boolean a_b;

        @Option(names = "--aB")
        public boolean aB;

        @Option(names = "-a")
        public boolean a;

        @Option(names = "-B")
        public boolean B;
    }

    App app = new App();
    new CommandLine(app).setAbbreviatedOptionsAllowed(true).parseArgs("-aB");
    assertFalse(app.a_b);
    assertFalse(app.aB);
    assertTrue(app.a);
    assertTrue(app.B);

    app = new App();
    new CommandLine(app).setAbbreviatedOptionsAllowed(true).parseArgs("--aB");
    assertTrue(app.a_b);
    assertTrue(app.aB);
    assertFalse(app.a);
    assertFalse(app.B);
}

It does not. When parsing --aB, a_b is not matched.

It will pass if the second part first assertion is assertFalse(app.a_b). Which does make sense to me.

Package private is fine. :-)
About the test, if we pass --AB or --a-b then both a_b and aB options are matched?

--a-b

If we pass --AB then an UnmatchedArgumentException is thrown: Unknown option: '--AB'
If we pass --a-b then it causes a ParameterException: --a-b is not unique: it matches '--a-B', '--aB'

If we pass --aB and --a-B then both options are matched.

So the cuurent impl will find exact match first, if there is exact match, then any ambiguity is not considered. Otherwise, if there is ambiguity, a ParameterException is thrown.

The lastest code should have addressed most issues.

Great, thank you! I’m not sure if I’ll be able to review today, I’ll try to get it done this weekend.

I went ahead and merged the PR.
Thank you very much for the contribution!
I’ll add documentation in the next few days.

Great, glad I could contribute to the picocli community! 😀


add groups to console(non-urgent)

@kunallillaney @j6k4m8 @Aeusman

Closing in favor of #409 - This is part of the enhancement to create user/group owned projects


fix set-output deprecation

Could this get merged and released?

@diegosz Thank you for the contribution and sorry for taking so long to notice this.


When would wave support Laravel 9

Firstly, I would like to apologize for using an unconventional means to  make this discussion. But considering that discussions are turned off, I had to. I'm sorry.
I just would like to ask, is there any plan soon for wave to support Laravel 9? As i am not a pro member, I do not know if there are any steps/discussions being made to allow Wave to support Laravel 9.
The reason I ask is because I was planning to get involved in upgrading Wave to Laravel 9, and merge it as a pull request. But I want to be sure that there are no already set plans for that to prevent conflicts and prevent me from wasting my time.
Thank so you much for you anticipated reply. Keep up the good work!

Hi there,
We do plan to upgrade Wave to Laravel 9, we have this in our backlog, though we have not started working on it.
If you have the time feel free to submit a PR for this! It will be highly appreciated!
Also, let me know if you have any questions!


Start again

Guy, this library is a mess. It's really confusing. All your examples have practically the same outputs AND NONE of the functions have a description of what they do, in place you wrote different variable names to go with each invocation, which is visible in the example, but clarifies all most nothing of the difference... Not cool

Thank you for your suggestion. I'll try to improve it. My point of the README is to be a guideline for people at Jitta of how to use the module. And I forgot to point out what my module really does (The point was to compare between the old json data and new json data and generate some sentences to inform the users.)
I'm a beginner at this kind of thing (open-source stuff) and I was an intern developing this module for people at Jitta. You can give me some detailed suggestion at<EMAIL_ADDRESS>I'd be really appreciated! +1

@Gblumentals Hey! I think the way you do, this is called "NOT COOL" at all. First the module doing great on what we expected and @withlovee open source code for other to hack or do something as them wish (dont need to reinvent the whole wheel)
The polite way or the good manner way you can just tell "Please rewrite the README so I can understand it or easy to know what this module can do" this is the way of people in the opensource world do, give comment, give feedback and cheer them up! She open the code for FREE and this is not the way to support what she did.
It will be awesome if you don't do something like this to other open source projects.


Do not ship typescript-language-features/out

It looks like we use dist/extensions.js and the out folder is no longer needed.

Good catch


Add map and list builders

I've posted a branch with these changes and my edits, since it was much easier to explore the changes in an editor that enforced type safety. Some of the suggested changes are already done.
https://github.com/rdblue/incubator-parquet-mr/commit/6f5332acdecc5847f675bcf17d819dd768dc3fcf

Ryan, thanks for the valuable comments. I have addressed them. Let me know if I missed out on anything.

Nice work, Ashish! Mostly ready to go in but has a few more tasks. Could you also add a JIRA issue for this work? I think the next PR should be submitted to the upstream project so we can review it there and merge it.

Created PARQUET-223 and PR for upstream project.


docs: Translate doc to Turkish

Translated add-borders-around-your-elements.turkish.md to Turkish.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Reason:  We are only accepting translations of challenges for Arabic, Chinese, Portuguese, Russian, and Spanish at this time.  We do welcome translations of files in the docs directory though.
Thank you and happy coding.


Add output for commited changes

This allows stopping following steps if pre-commit found an issue that was auto-fixed.

How does outputting the commit allow stopping following steps?

@nitrocode I just fail the build if commited is non-empty.


[release-1.9] contrib: import system containers

@mrunalp PTAL

Needed by Justin over at https://github.com/openshift/enterprise-images/pull/102


Embedded acorr screws up autocorrelation

When using libxcorr, old days:
sevagh:pitch-detection $ ./bin/sinewave --freq 1337 --algo autocorrelation --size 8092
Freq: 1337      pitch: 1339.12

With embedded acorr:
sevagh:pitch-detection $ ./bin/sinewave --freq 1337 --algo autocorrelation --size 8092
Freq: 1337      pitch: 1492.58

I believe the longer the result, the worse autocorrelation is, and with the new changes and zero-padding to largest power of 2, the array ends up longer so the weakness of autocorrelation shows sooner.


是否支持网易邮箱登录

只能手机号登录吗

手机或微信
On Tue, Aug 14, 2018 at 9:37 AM mayunbaba2<EMAIL_ADDRESS>wrote:

只能手机号登录吗
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/trazyn/ieaseMusic/issues/257, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABsVMjZP4hTmaScIJpmPq2IyFYabefi9ks5uQim-gaJpZM4V7p_q
.

Close #284


Genome fasta downloading issue

Hello Martin, during running the pipeline I have some issues with downloading NCBI fasta file for my samples. All samples downloading fail with the errors(I will give one of them as an example):
Traceback (most recent call last):   File "/mnt/pankb_ale/bgcflow/.snakemake/conda/a7741b92e8354497f5d9a4ef0b351f0c_/bin/ncbi-genome-download", line 10, in <module>     sys.exit(main())   File "/mnt/pankb_ale/bgcflow/.snakemake/conda/a7741b92e8354497f5d9a4ef0b351f0c_/lib/python3.9/site-packages/ncbi_genome_download/__main__.py", line 26, in main     ret = args_download(args)   File "/mnt/pankb_ale/bgcflow/.snakemake/conda/a7741b92e8354497f5d9a4ef0b351f0c_/lib/python3.9/site-packages/ncbi_genome_download/core.py", line 178, in args_download     return config_download(config)   File "/mnt/pankb_ale/bgcflow/.snakemake/conda/a7741b92e8354497f5d9a4ef0b351f0c_/lib/python3.9/site-packages/ncbi_genome_download/core.py", line 197, in config_download     download_candidates = select_candidates(config)   File "/mnt/pankb_ale/bgcflow/.snakemake/conda/a7741b92e8354497f5d9a4ef0b351f0c_/lib/python3.9/site-packages/ncbi_genome_download/core.py", line 308, in select_candidates     for entry in filter_entries(entries, config):   File "/mnt/pankb_ale/bgcflow/.snakemake/conda/a7741b92e8354497f5d9a4ef0b351f0c_/lib/python3.9/site-packages/ncbi_genome_download/core.py", line 354, in filter_entries     if not config.is_compatible_assembly_accession(entry['assembly_accession']): KeyError: 'assembly_accession'

This is related to this issue: https://github.com/kblin/ncbi-genome-download/issues/209
A PR is underway: https://github.com/kblin/ncbi-genome-download/pull/210


fix: abort transmission after response timeout, do not retry, do not restart controller unless callback is missing

for https://github.com/zwave-js/node-zwave-js/issues/6402
This PR changes how timed out Send Data responses are handled. Previously, we'd retry the command up to 3 times without awaiting the end of the command cycle, which can likely put the controller in a weird state, possibly triggering the "unresponsive controller" recovery unnecessarily.
Now we abort the transmission and wait for the callback to be received (expected to be with status NoACK), then treat it like a NoACK (node marked dead/asleep).
If the callback doesn't come, the recovery will kick in, possibly restarting the controller.
Since we now actively abort, the default timeout was reduced back to 10s, as not responding to incoming commands for an extended amount of time can cause further problems. Users regularly experiencing these timeouts should fix their mesh or increase the timeout.

@zwave-js-bot automerge


didEndDecelerating callback method is not getting called for the first month

When we swipe through and come back to the first month, didEndDecelerating method is not being called if it is the first month.

@rizwan95 I can confirm that I'm seeing this behavior if the calendar has no declaration animation after you lift your finger. This is the same behavior as UIScrollView's didEndDecelerating.
You will need to also implement calendarView.didEndDragging... I'm now realizing that I should have included a boolean on that closure callback to indicate whether the calendar will decelerate or not.
I've implemented a fix here. Once you update to v1.9.0, you can use calendarView._didEndDragging = { visibleDayRange, willDecelerate in ... }

Awesome! Your proposed fix should solves the issue! Thanks a lot @bryankeller

@rizwan95 v1.9.0 has been released with the new _didEndDragging API, which includes a flag for whether the scroll view will decelerate or not 🙂


Do not track raw pnext-data in DescriptorInfo

this was basically duplicating storage of VkAccelerationStructureKHR-handles and only used to track descriptors containing VkAccelerationStructureKHR. we still need a pNext-pointer/struct later, when assembling VkWriteDescriptorSet, but can create that on-the-fly using stack-memory.

CI gfxreconstruct build queued with queue ID 169532.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

CI gfxreconstruct build # 4024 running.

CI gfxreconstruct build queued with queue ID 169544.

CI gfxreconstruct build # 4025 running.

CI gfxreconstruct build queued with queue ID 169558.

CI gfxreconstruct build # 4026 running.

CI gfxreconstruct build # 4026 passed.

CI gfxreconstruct build queued with queue ID 169613.

CI gfxreconstruct build # 4027 running.

CI gfxreconstruct build # 4027 passed.

Without understanding this change in too much depth yet, this changes code that was commited in 0d04134e578e4177038e30589a319f3266ce875e, "Trimming for deferred operation" in https://github.com/LunarG/gfxreconstruct/pull/776.  I don't think we have a host deferred operation test.  Have you tried a test with trimming for any of the samples mentioned in the PR https://github.com/LunarG/gfxreconstruct/pull/653 that was one of the source branches for #776?

I compiled and captured mentioned samples from https://github.com/nvpro-samples/vk_raytracing_tutorial_KHR :

vk_ray_tracing_advanced_compilation_KHR_app
vk_ray_tracing_animation_KHR_app
vk_ray_tracing_instances_KHR_app

I can confirm that capture(w. trimming)/replay of those samples (and some others I tested) worked for the baseline and this PR, no notable changes whatsoever.
this was expected as this PR 'should' not temper with anything related to "host deferred operation".
there are some issues with said samples, when replaying with gfxrecon-replay --validate, but those issues seem unrelated to the changes applied here. I'll look around if we already know/track those issues.


Provide simple cli for interpolation

This is more actually a question but I was wondering why go-patch is only a library and doesn't provide a simple cli to do interpolation as we can do on bosh cli v2 ?
This is pretty useful to have it outside of bosh cli to use it for any yaml file (i'm actually thinking about fly cli) and interpolate command seems quite untied to the bosh cli.
We can obviously use interpolate command through bosh cli to perform patch on yml file but doesn't have much sense to have this dependencies on something which is not bosh.
Any reasons to don't have this kind of cli ? Will it be appreciate to have a PR to add one ?

People from the PCF pipelines do use the yaml-patch CLI for such use-case.
See the customizing the pipelines section of their README.


Add testkube kubeshop

Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you added your SVG to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] ~15 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Build failed because of:
No cached entry, and Testkube has issues with logo: testkube.svg, Error in parsing SVG: Non-whitespace before first tag.
Line: 0
Column: 1
Char: a
Empty twitter for Spotinst Functions: https://twitter.com/spot_hq
Empty twitter for Mail.Ru Cloud Solutions (member): https://twitter.com/mailru
Empty twitter for Mail.Ru Cloud Containers: https://twitter.com/mailru
Empty twitter for Karmada: https://twitter.com/karmada_io
Item Testkube has no image_data


🐛  Updating staging and prod registries

This fixes the builds which were erroring cause of GCP projects for releasing the images.
XRef: #91
Signed-off-by: Chris Hein<EMAIL_ADDRESS>

/kind bug
/assign @vincepri


the cdn that are provided on access  bootstrap is down

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
when i tried to access bootstrap using cdn  i received errors on phpstorm to download the lib and also when accessing thos links from the browser i get error error screenshots are uploaded below and access the bootstrap from this provider website give me error all of them it seems like the links is done or there are somthing wrong please check
CSS |<EMAIL_ADDRESS>JS |<EMAIL_ADDRESS>
when try to download from IDE

this when i try to access the cdn from browser

also i got this in the bowsers inspector when added the cdns links

Note :Same happiens for the popperjs lib
Reduced test cases
the only way that i can access the link from the browse is through vpn also there are some one that have the same issue and here is the link for the chats
https://github.com/orgs/twbs/discussions/38732#discussioncomment-6151998
What operating system(s) are you seeing the problem on?
Linux
What browser(s) are you seeing the problem on?
Firefox
What version of Bootstrap are you using?
v5.3.0

Closing it since it's an integration error. The integrity value is probably not the right one. We use the CDN everywhere without any issues.
More details in https://github.com/orgs/twbs/discussions/38732#discussioncomment-6170502.

In general if anyone notices any CDN issues please report them directly to us https://github.com/jsdelivr/jsdelivr :)
In most cases its an overly active LAN firewall breaking things


Update vendor satori/go.uuid

This updates the satori/go.uuid vendor to address the vulnerability outlined in WS-2018-0594.
Signed-off-by: Shane Jarych<EMAIL_ADDRESS>

Hm. for some reason CI doesn't kick in. Let's see if it's just slow

Hm. for some reason CI doesn't kick in. Let's see if it's just slow

I noticed that my update to my PR on release/2.7 had CI run against it fairly quickly.  Is this still slow for master, or something else?

What is the issue this is protecting against in the registry? I only see this dependency brought in through the Azure library, and that library just seems to be using it string conversion rather than UUID generation. This should really be done along with updating the Azure library since the registry isn't using it directly. Unless I am missing something here.

What is the issue this is protecting against in the registry? I only see this dependency brought in through the Azure library, and that library just seems to be using it string conversion rather than UUID generation. This should really be done along with updating the Azure library since the registry isn't using it directly. Unless I am missing something here.

I missed that -- good points.  I think this PR can be abandoned, along with the release/2.7 one.


Adjust linked static libraries after migrating libchromiumcontent to GN

See libchromiumcontent #249 for context.

Closed in favor of https://github.com/electron/brightray/pull/269.


⚠ 한경주요지수-코스피200 has degraded performance

In 0e7339d, 한경주요지수-코스피200 (https://markets.hankyung.com/indices/kospi200) experienced degraded performance:

HTTP code: 200
Response time: 20213 ms

Resolved: 한경주요지수-코스피200 performance has improved in 779e805.


splits harbor into batch build for images

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve


Peer-to-peer review

😎 Great work, the project looks very nice, the API fetch is very clean, and you are way ahead of schedule! 👍🏻  💯
For only displaying a certain number of cards, you could for example:

use the counter to hide all cards after the first 20 (or any number you want), with for example style.display
create a button
every time you click the button, you can change the style.display of the next batch of the cards (for example you can reveal always the next 20)

Good job so far! 🎉
As Matt said above, I kindly recommend you use different strategies to display a certain number of cards. Another example could be the use of the property Overflow on the Y-axis and the width to take control of the number of cards that you could display

Good job so far:  it could be better if the footer content will be wrapped with an H or P tag, span tag is more used for applying extra styles, and H,P tag if for defining content.

Thanks @J2ZROMERO I will work on this asap

😎 Great work, the project looks very nice, the API fetch is very clean, and you are way ahead of schedule! 👍🏻 💯
For only displaying a certain number of cards, you could for example:

use the counter to hide all cards after the first 20 (or any number you want), with for example style.display
create a button
every time you click the button, you can change the style.display of the next batch of the cards (for example you can reveal always the next 20)

Thank you @MattGomb I will reach out once I implement this feature. Just to check if I have done it correctly

Good job so far! 🎉
As Matt said above, I kindly recommend you use different strategies to display a certain number of cards. Another example could be the use of the property Overflow on the Y-axis and the width to take control of the number of cards that you could display

Thanks @carreraprogrammer I will implement both your idea and @MattGomb idea to see which one works better.


GUI color picker for fzf

What is GUI color picker for fzf
It is a tool that helps fzf to set color theme easily, which is implemented with go-astilectron.
See details here
How to use GUI color picker

Build the project (in fzf directory, run "go build")
For the GUI colorpicker to work properly, the path to fzf must be registered in the FZF_PATH environment variable.
When you run fzf with "--color g" option, the GUI color picker window appears.
Config your custom color and push 'Apply to fzf' button
When you close the GUI window, fzf will be executed with the color theme just set.
This color theme is stored in the .ColorConfig file in the fzf directory. If you want to initialize the color theme, delete this file.

Notice: The first time you run the GUI, it will take some time to generate the necessary files.
Assignees: @contestpark @minSW

See my answer in #1602. Thanks.


Spec workflow passing + Lint errors fixed

Checklist

[✅ ] I have read the Contribution & Best practices Guide.
[✅ ] My branch is up-to-date with the upstream master branch.
[ ✅] The tests pass locally with my changes.
[x] I have added tests that prove my fix is effective or that my feature works(if appropriate).
[✅ ] I have added necessary documentation (if appropriate).

Short description of what this resolves/which issues does this fix?:

Changes proposed in this pull request:

Closing pull request due to codeclimate error. Need to update rubocop.


Make sample eco-products

Make a solar panel product which can be purchased with energy. Doesn't have to be too complicated to start off.

Add in fe91759919ea2d1a043e678924fc219e8261d726


Disable lsp-mode project guessing with projectile

I think this particular setting should be left off by default just like it is off in the original project.
When your project follows projectile conventions, it's great, but if for some reason your lsp root and projectile root are different it causes really annoying issues.
If this setting is off and lsp-mode can't find the root it just asks the user, whereas if it's left on, as it is now, if lsp-mode can't find the root it just throws an error and offers no solutions. I couldn't get my particular setup to work for quite a while until I disabled it, then everything started working perfectly.
Even lsp-mode source code clearly indicates that this setting should only be used by users who  know what they're doing and understand how lsp-mode works internally, therefore it doesn't seem to be a good default.

Do not use this setting unless you are familiar with lsp-mode' internals and you are sure that all of your projects are following projectile'/`project.el' conventions."

As of 8c3f24f LSP will prompt for the project root, so I'll consider this resolved. Thanks for bringing it to my attention!


Incomplete documentation of Office update config locations.

Can't you also configure 365 Apps update settings via Endpoint Manager (SCCM), Intune (Device config policy), or Intune (Endpoint Management), or https://config.office.com/officeSettings/serviceprofile (Which seems to override all the others)?
As far as when each is in effect, or what happens when multiple policy locations are configured, and what has priority I have no idea.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 601039de-64e0-6f70-a5c6-f569f7d0cf87
Version Independent ID: 861e9906-f260-fdcd-9bba-eb86056e51bd
Content: Configure update settings for Microsoft 365 Apps - Deploy Office
Content Source: DeployOffice/configure-update-settings-microsoft-365-apps.md
Service: o365-proplus-itpro
GitHub Login: @nicholasswhite
Microsoft Alias: nwhite

To make it easier for you to submit feedback on articles on learn.microsoft.com, we're transitioning our feedback system from GitHub Issues to a new experience.
As part of the transition, this GitHub Issue will be moved to a private repository. We're moving Issues to another repository so we can continue working on Issues that were open at the time of the transition. When this Issue is moved, you'll no longer be able to access it.
If you want to provide additional information before this Issue is moved, please update this Issue before December 15th, 2023.
With the new experience, you no longer need to sign in to GitHub to enter and submit your feedback. Instead, you can choose directly on each article's page whether the article was helpful. Then you can then choose one or more reasons for your feedback and optionally provide additional context before you select Submit.
Here's what the new experience looks like.
Note: The new experience is being rolled out across learn.microsoft.com in phases. If you don't see the new experience on an article, please check back later.
First, select whether the article was helpful:

Then, choose at least one reason for your feedback and optionally provide additional details about your feedback:

Article was helpful
Article was unhelpful

Finally, select Submit and you're done!


Couch and Postgres DBs

Hi,
Looking at the readme, both couch and postgres databases seem to be necessary to run the autoscaller. Could you elaborate on the need for/use of both of them? Is it a valid idea to use cf services?
Thanks

Couch is required for the initial version on master.
The current development is going to require Postgres which is on develop but non-functional.


Priority support for registrering of subscribers

I'd like a specific subscriber to be executed before another subscriber. But there is no support for priority.
But the middlewares do have support. Any special reason for this?
Should I submit a PR to fix it?

I think this is because of the fact that if events are going trough something like RabbitMQ you don't have a guarantee that the subscribers are beging processed in order. @matthiasnoback wrote a artikel about the commands and events on his blog maybe this is helpful?

http://php-and-symfony.matthiasnoback.nl/2015/01/from-commands-to-events/

The lack of priority forces you to not rely on a particular order. If you
need a chain of actions you need to find some other solution.

I forgot to mention that I'd be happy to think about your case if you like!
On Nov 12, 2015 2:35 PM, "Matthias Noback"<EMAIL_ADDRESS>wrote:

The lack of priority forces you to not rely on a particular order. If you
need a chain of actions you need to find some other solution.


crowtty trace filtering seems a bit broken

for example, if i run just crowtty --trace info,mnemos_beepy=trace, i don't get any TRACE events from that module:
     Running `target/release/crowtty serial /dev/ttyUSB1 --trace info,mnemos_beepy=trace`
[2 +0000.000002584s] UART KEYB pseudo-keyboard (SerMux port :2) reading from STDIN
[  +0018.749538871s] UART TEXT DRAM only have internal ZQ!!
[  +0018.749567886s] UART TEXT get_pmu_exist() =<PHONE_NUMBER>
[  +0018.749571583s] UART TEXT ddr_efuse_type: 0x0
[  +0018.749574098s] UART TEXT [AUTO DEBUG] two rank and full DQ!
[  +0018.749575410s] UART TEXT ddr_efuse_type: 0x0
[  +0018.749576613s] UART TEXT [AUTO DEBUG] rank 0 row = 15
[  +0018.749579117s] UART TEXT [AUTO DEBUG] rank 0 bank = 8
[  +0018.749580901s] UART TEXT [AUTO DEBUG] rank 0 page size = 2 KB
[  +0018.749582243s] UART TEXT [AUTO DEBUG] rank 1 row = 15
[  +0018.749583285s] UART TEXT [AUTO DEBUG] rank 1 bank = 8
[  +0018.749584868s] UART TEXT [AUTO DEBUG] rank 1 page size = 2 KB
[  +0018.749585970s] UART TEXT rank1 config same as rank0
[  +0018.749588275s] UART TEXT DRAM BOOT DRIVE INFO: %s
[  +0018.749589828s] UART TEXT DRAM CLK = 792 MHz
[  +0018.749590819s] UART TEXT DRAM Type = 3 (2:DDR2,3:DDR3)
[  +0018.749592843s] UART TEXT DRAMC ZQ value: 0x7b7bfb
[  +0018.749594166s] UART TEXT DRAM ODT value: 0x42.
[  +0018.749595168s] UART TEXT ddr_efuse_type: 0x0
[  +0018.749596911s] UART TEXT DRAM SIZE =1024 M
[  +0018.749598514s] UART TEXT DRAM simple test OK.
[  +0018.749599556s] UART TEXT
[3 +0019.769572978s] UART BEAT Max level set to Some(TRCE)
[3 +0019.839977126s] UART INFO kernel::serial_trace: git=eliza/i2c-puppet-irq@5e1c4e4, message=hello from mnemOS, profile=release, target=riscv64imac-unknown-none-elf, version=0.1.0
[  +0061.029418280s] UART DMUX ERR! Bad decode!
[  +0061.309416052s] UART DMUX ERR! Bad decode!
^X^C%

this used to work, so i don't know what's up. possibly #194 broke it?

hmm, it looks like the issue is actually specific to the i2c_puppet module. trace filtering works correctly for other crates. idk what's up here.

logs from that module work correctly when the log level is set to DEBUG rather than TRACE for that module. i suspect the issue is probably just because the TWI interrupt logs a bunch at TRACE and the buffer is filling up, or something like that...


Use Project folder for automatic intellij project detection

As an intellij user, I want IDEasy to automatically detect my intellij projects located in the IDEasy projects folder structure so that I can easily update all of my ide-settings.

We will not implement this. IDEasy will open IntelliJ in your workspace. You can from there have your git repo(s) inside the workspace as subfolder and only this way we can properly preconfigure maven installation, settings.xml, etc. via .idea folder.


Add option to use custom pruning module

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] The changes are appropriately documented (if applicable).
[x] The changes have sufficient test coverage (if applicable).
[x] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
This should help avoid package manager specific pruning issues as we now walk the dependency tree manually.

There should probably be a test added too.

@MarshallOfSound pruner itself is not Node 4 compatible: https://travis-ci.org/electron-userland/electron-packager/jobs/257800435#L2470

@malept Changed the tsc target and it should be v4 compatible now 👍

@malept The failure here look unrelated to the code changes, is it gtg?


New page of different layout loaded and displayed before out animation is finished

Describe the bug
Set an out animation on a  link in a nested layout page, which links to a page using the parent layout above. Click on it: instantly, the next page is loaded and displayed below the current one, while the out animation plays. After it's finished, the current page disappears and navigation is complete.
Note: I can't reproduce it here, but in my full project it doesn't even hide the current page at the end, and pages pile up one after the other on the bottom as I continue navigating back and forth, with no page ever disappearing.
Note: I use adapter-static, not sure it's relevant.
Expected result:
It seems to me the new page and its layout should be loaded only AFTER all out animations are complete.
Reproduction
https://github.com/g012/svelte-anim-link
Just run the code from this repo, then click the "Go Test" button, then click either "Go Home" or "Link Home" from the new page. Observe the bug.
Logs
No response
System Info
System:
    OS: macOS 12.3.1
    CPU: (8) x64 Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz
    Memory: 28.73 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.0 - /usr/local/bin/node
    Yarn: 1.22.17 - /opt/local/bin/yarn
    npm: 8.1.3 - /opt/local/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 100.0.4896.127
    Firefox: 99.0.1
    Firefox Developer Edition: 100.0
    Safari: 15.4
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.40
    @sveltejs/adapter-static: ^1.0.0-next.29 => 1.0.0-next.29
    @sveltejs/kit: next => 1.0.0-next.324
    svelte: ^3.44.0 => 3.47.0

Severity
serious, but I can work around it
Additional Information
No response

This is expected behaviour — in Svelte, in and out transitions play simultaneously, otherwise you couldn't do things like this: https://svelte.dev/repl/97d3f7c689c7439686d5a3cacfdfd82b?version=3.48.0. It would also be impossible to do deferred transitions.
As @moritzebeling suggests, you can use delay to control the behaviour (e.g. https://svelte.dev/repl/19797e30fd4b4092a61db1a836d5a171?version=3.48.0); you can also use things like position: absolute to keep things out of the document flow so that they can exist in the same part of the screen (though this can get a bit finicky).
It would definitely be nice to have slightly more control over transitions (e.g. a staggered mode), though strictly speaking that's an issue for Svelte rather than SvelteKit (which knows nothing about transitions). It's something I hope to look at later this year. For now, will close this issue as there's nothing to change in SvelteKit itself.
(Though if you're able to reproduce "pages pile up one after the other on the bottom as I continue navigating back and forth, with no page ever disappearing", please do open a new issue!)


[ClassicsKotlin] Media files return 404

Hi,
All the media files in media-feed.json of ClassicsKotlin returns 404, e.g.
https://android-tv-classics.firebaseapp.com/content/buffalo_dance/poster_art_buffalo_dance.jpg
This broke the sample app.

Hosting issue fixed.

Hi there, it seems like the hosting issue happens again.


New unit type krg

Looks good!
(Just mentioning that in the foundational metadata received from SIKT, the short name of the identifier was KRG_TILFELLEID and not KRG_KREFTILFELLEID, but I am not sure if it matters)

Good catch! It matters a lot 🎉


Bug / Error: MicaWPFRuntimeComponent.UWPColors not registered

System.TypeLoadException: 'Windows-kørselstypen 'MicaWPFRuntimeComponent.UWPColors', der anmodes om, er ikke registreret.'
Roughly translated to Windows cant load MicaWPFRuntimeComponent.UWPColors because its not registered...
I installed MicaWPF using NUGET into my existing solution and removed all references to the old theme (MahApps Metro)
I then fixed all bugs ..
But now the application wont start.
The App is .NET Framework 4.7.2 WPF .. pretty basic.
I've tried adding the Nuget package MicaWPFRuntimeComponent but that didn't fix anything.

It is referencing that library for the windows 11 native colors what os are you running and do you use xaml islands?

Im running Windows 11, all patched up.
No i don't use XAML Islands , what's that ?

XAML island are WPF hybrid with UWP.
I think I nailed the issue down pushing Version 4.2.0 can you try again with this version? (Should be available in the next hour)

Thanks I'll try

heh i'm now getting a weird error :
Severity	Code	Description	Project	File	Line	Suppression State
Error	MSB3644	The reference assemblies for .NETFramework,**Version=v4.8.1** were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks	MicaWPF	C:\Program Files\Microsoft Visual Studio\2022\Professional\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets	1220

Framework 4.8.1 😄 ?

If you are using the source itself you need .Net Framework 4.8.1 to compile it:
https://go.microsoft.com/fwlink/?linkid=2203306

I removed the NET481 from the target frameworks in the MicaWPF project.
Now it works !

.Net 4.8.1 is brand new I think it came out the 9th of august.


Fix function signature in flash suspend example (IDFGH-9888)

Fixes misspelling of function signature in the flash suspend example.

sha=7a192131986745a83f468821a70cc4bc6b41802b

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


bug, when parse srt

Hi,
I'm using pysubs2 to parse a existing srt file, which contains following snip. It treated 394 as text of 393. which should be two different subs with empty text.
And, it looks like subs  are better separated by "A blank line " instead of timecode's line by https://www.matroska.org/technical/specs/subtitles/srt.html
Regards,
Jarod
`
392
00:29:27,46 --> 00:29:29,83
I'm Liza Minnelli..
393
00:00:00,00 --> 00:00:00,00
394
00:00:00,00 --> 00:00:00,00
`

Thanks for the test case!
I wholeheartedly agree that "subs are better separated by a blank line", however I've seen too many SRT files with multiple subs without any blank lines inbetween to implement the parsing like that. I find multiple subtitles merged into one more annoying when viewing/editing than an occasional subtitle that contains an extra number. Parsing in the library is implemented with "best effort" goal in mind, since 100% correct parsing of files which are routinely malformed in various ways is just not possible.
In the case that the file has reasonable formatting, however, it should behave cleanly. I've fixed your issue in the newly released 0.2.3 version of the library :)


Method for admins to give feedback on broken gallery apps?

It would be very helpful if admins could flag broken gallery apps for update. For example, the Concur Solutions gallery app (password sign-on) has the wrong sign-in URL, and this can't be changed on a gallery app.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 806e36a4-f5ae-bc07-e7e2-ea9d2ab98131
Version Independent ID: 3dea2974-8f2b-0e21-b7a2-b1381cf127b6
Content: List your application in the Azure Active Directory application gallery
Content Source: articles/active-directory/develop/howto-app-gallery-listing.md
Service: active-directory
GitHub Login: @CelesteDG
Microsoft Alias: celested

@xencon
Thanks for your feedback! We will investigate and update as appropriate.

@xencon Please post this as a feedback https://feedback.azure.com/forums/169401-azure-active-directory This will allow the community to upvote and for the product team to include into their plans. We also have the "Give Product Feedback" button in our documents now to take you directly to the appropriate feedback page.

@xencon We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Add dustmaps to requirements

This PR adds dustmaps to requirements.

@MickaelRigault

Hi Thanks, this is still under developpement, I now realize I pushed in main....


Load image

Hello!
I'm writing a sample demo to render gltf model on image, and i can save image (by renderer->readPixels)
but I can't find any functions to load image to render on, load bytebuffer or something similar.

Filament is only a renderer and does not provide image loaders. You can load an image using whatever APIs are at your disposal in the language you use and feed the resulting bytes to a Texture. If you use C++ you can look at our samples to see how we use stb_image for instance for this purpose.


feat: create script for updating lists of ecosystems

This introduces a new script to make it easier to ensure all "lists of ecosystems" within this codebase remain up to date, including:

the table in docs/schema.md
the Go constants being introduced in #292
the JSON schema in validation/schema.json (both the pattern and the enum being introduced in #296)

To make it a bit easier, I've introduced a top-level ecosystems.json which is a map of defined ecosystems and a markdown description, sorted alphabetically (which the script also ensures) - I felt this was easier than trying to extract the list from markdown or another source, though it does mean double quotes need to be manually escaped.
I went with JSON as it can be read without requiring an external dependency, though if we use Python 3.11 we could switch to toml instead as that ships with tomllib

https://github.com/ossf/osv-schema/pull/292#discussion_r1811556242 made me think we should later expand ecosystems.json to include other properties like if an ecosystem supports a prefix i.e.
{
  "npm": {
    "description": "xyz",
    "supportsSuffix": false
  }
}


how to apply?

I have a server and I want it to be registered as known instead of as a private server
How do i do that?
i have a server and not have access to pull new request for apply

i understand alone


Change behavior of interceptors

This changes changes behavior of interceptors as following:

Change interceptor gets called after serialize() to avoid possible race conditions.
State interceptor gets called after distinctUntilChanged() to avoid interception of not dispatched state.

@gustavkarlsson What do you think?

Codecov Report

Merging #10 into master will increase coverage by 3.06%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #10      +/-   ##
===========================================
+ Coverage     94.14%   97.2%   +3.06%
  Complexity       14      14
===========================================
  Files             5       5
  Lines           222     215       -7
  Branches         20      20
===========================================
  Hits            209     209
+ Misses            8       1       -7
  Partials          5       5

Impacted Files
Coverage Δ
Complexity Δ

knot/src/main/kotlin/de/halfbit/knot/Knot.kt
95.65% <100%> (ø)
0 <0> (ø)
:arrow_down:

...t/src/main/kotlin/de/halfbit/knot/CompositeKnot.kt
95.12% <100%> (ø)
0 <0> (ø)
:arrow_down:

...ain/kotlin/de/halfbit/knot/CompositeKnotBuilder.kt
97.91% <0%> (+5.75%)
6% <0%> (ø)
:arrow_down:

...not/src/main/kotlin/de/halfbit/knot/KnotBuilder.kt
98.3% <0%> (+6.24%)
8% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae735e...ccdd45b. Read the comment docs.

Change interceptor gets called after serialize() to avoid possible race conditions.

Makes sense.

State interceptor gets called after distinctUntilChanged() to avoid interception of not dispatched state.

To be honest I don't think the library should enforcing distinctUntilChanged on the state. It can have a huge unwanted impact on performance if the equals is expensive to calculate or updates are frequent.
IMO that should be left to the developer, probably using an interceptor.

To be honest I don't think the library should enforcing distinctUntilChanged on the state. It can have a huge unwanted impact on performance if the equals is expensive to calculate or updates are frequent.

Absolutely! The intention was to filter out state.only value coming from reducer. Current implementation is rather unfortunate. I changed it into distinctUntilChanged { prev, curr -> prev === curr } which fulfils the need and has no performance penalties.


Update basic-https.yaml

Certificate in ca-issuer.yaml in this address https://raw.githubusercontent.com/cilium/cilium/1.16.4/examples/kubernetes/servicemesh/ca-issuer.yaml must be ca and demo-cert does not work.
Please ensure your pull request adheres to the following guidelines:

[ ] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[ ] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[ ] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[ ] Thanks for contributing!

Fixes: #issue-number
<!-- Enter the release note text here if needed or remove this section! -->

/test


Cache missed in private repo

Thank you for a great project. Great idea and work.
I had a problem getting the action to work under a private repository. Every time the cache was reported missed. It seems the list artifact api returned soft error each activation. It did not throw.
https://github.com/felixmosh/turborepo-gh-artifacts/blob/a73d2a81585ca9fb37c3a22070c4bc809b93dc6b/src/turboServer.ts#L51
{
  "message":"Resource not accessible by integration",
  "documentation_url":"https://docs.github.com/rest/reference/actions#list-artifacts-for-a-repository"
}

Eventually it seems the GITHUB_TOKEN is not enough in private repos. You need to create a private api token with the "repository" permission to be able to use the endpoint.

If the repository is private you must use an access token with the repo scope.

I'm not sure why the call did not throw. Maybe Github does not return error for this case. Maybe a check can be added to guard against it. Regardless, it works very well now with the correct token.

Hi @elpddev, there is a node in the README that the token most have repo permissions.
You are right, GitHub API returns 200 with an error message, I've added a print of this error, hope that it will direct the next user into the right direction :]
Thank you for reporting this issue 🙏🏼


[BEAM-7850][BEAM-9005] Sets missing environment ID in several locations.

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.


Building lua 5.1 fails to find ncurses on debian stretch

# python /hererocks.py -r^ --lua=5.1 /lua5.1
Fetching Lua 5.1.5 (cached)
Verifying SHA256 checksum
Building Lua 5.1.5
Skipping 1 patch, use --patch to apply it
/usr/bin/ld: cannot find -lncurses
collect2: error: ld returned 1 exit status
Error: got exitcode 1 from command gcc -o luac luac.o print.o liblua51.a -Wl,-E -ldl -lreadline -lhistory -lncurses -lm

This is consistent with make linux when using the official Makefile. --no-readline helps.


model_mgr_nce? what is nce?

Hello,
Thank you for providing .ipynb examples! I have been creating spectral libraries from FASTA files on Colab.
However, I was wondering what nce means. It seems that it has to be specified when predicting MS2, RT and CSS.

The default value appears to be 30.

Could you let me know what nce is?
Thank you.

NCE is the Normalized Collision Energy or Collision Energy, it depends on what instrument you used.

ok, this is helpful. Thank you for your swift reply!


Active speaker detection in a video

In run_visualise.py I don't see that you detect active speaker. How do you detect active speaker when you have multiple faces?

You will need to set a threshold for the feature distance, or use some other measure of confidence.

Hello,
I declared a tracks_scores list and I am appending fdist_mf to corresponding track.
Here what is fdist_mf is it confidence for each frame ?
Please see the below snippets
tracks_scores = [ [] for i in range(1000000) ]
for ij, frame in enumerate(track[0][0].tolist()) :
       faces[frame].append([ii, fdist_mf[ij], track[1][0][ij], track[1][1][ij], track[1][2][ij]])
       tracks_scores[ii].append(fdist_mf[ij])

#Afterwards when I am drawing rectangle for the average values between 6 and 8 as bellow
tracks_average_scores = {}
while True:
        ret, image = cap.read()
        if ret == 0:
                break
	first_face = True
	for face in sorted(faces[frame_num], key=itemgetter(1)):
			if face[0] not in tracks_average_scores:
				tracks_average_scores[face[0]] = numpy.average(tracks_scores[face[0]])
			if first_face  and tracks_average_scores[face[0]] < 8 and tracks_average_scores[face[0]] > 6:
				first_face = False
				cv2.rectangle(image,(int(face[3]-face[2]),int(face[4]-face[2])),(int(face[3]+face[2]),int(face[4]+face[2])),(255,0,0),3)
				cv2.putText(image,'Track %d, L2 Dist %.3f %d'%(face[0],tracks_average_scores[face[0]], len(tracks_scores[face[0]])), (int(face[3]-face[2]),int(face[4]-face[2])),cv2.FONT_HERSHEY_SIMPLEX,0.5,(255,255,255),2)
				continue
			cv2.rectangle(image,(int(face[3]-face[2]),int(face[4]-face[2])),(int(face[3]+face[2]),int(face[4]+face[2])),(0,0,255),3)
			cv2.putText(image,'Track %d, L2 Dist %.3f %d'%(face[0], tracks_average_scores[face[0]], len(tracks_scores[face[0]])), (int(face[3]-face[2]),int(face[4]-face[2])),cv2.FONT_HERSHEY_SIMPLEX,0.5,(255,255,255),2)

For our applications, we used the fconfm variable given in SyncNetInstance.py


Added nerdtree plugin + autocmd property to not autocomment new line

Added nerdtree
Added keybind to map fe
Added autocmd to not comment new line.

If I were to add a filetree, I'd add either nvim-tree or chadtree. They both look awesome and are not written in viml. Chadtree promises some better performance, and nvim-tree is easily configured in Lua. So despite them being a bit less known than nerdtree, I think they fit better in this project's idea (specially nvim-tree, which is is neovim focused and also simpler to install).

No thanks, I'm not interested in adding a file tree to this repo at this time. Thanks for sending a PR though!

Thanks for confirming.
May I ask what things you've like to see in this repo moving forwards?


Feature new item form

WIP

@ariejan please review and merge.

Looks cool :-)
One thing I noticed is that it does not allow me to leave Code blank. This does not save the item and it does not give me feedback. The Code is actually optional an in practice it should be an exception to request one yourself - 99% of the time you'll want the next available, shortest option. Generating the code is already handled by the server when the Code field is blank.

Please continue this PR on https://github.com/bubblebox/client-ember.


Fix dismissing Onboarding on iOS

Details

The PR fixes a case when the user can be back on the onboarding flow by gestures.
Fixed Issues

$ https://github.com/Expensify/App/issues/40555
PROPOSAL: N/A
Tests

Go to Settings > Troubleshoot > Onboarding flow to open the modal.
Pull down vertically (right under the status bar) or horizontally.
Verify that you cannot close the flow by the gesture.
Verify that on the further screens (business name and names) you can use the gesture to return to the first one.

[x] Verify that no errors appear in the JS console

Offline tests

Same as "Tests".
QA Steps

Same as "Tests".

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/Expensify/App/assets/57314631/fd323502-551a-41b7-bbe2-331317390853

iOS: Native

https://github.com/Expensify/App/assets/57314631/690d8809-9a45-44b5-9853-bffff46452b4

iOS: mWeb Safari

https://github.com/Expensify/App/assets/57314631/5f573b9e-5793-44e5-b1e2-5bd8439379a2

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/57314631/74ca72be-f709-4b39-89d7-e06caa5a790e

MacOS: Desktop

https://github.com/Expensify/App/assets/57314631/12eabb45-c25f-4145-9e9a-6763ab4a9a85

Running here

@parasharrajat are you able to install the builds above or is your uuid missing from ti?

@parasharrajat, just pulled!

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.73-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.73-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[explain](point query) modify explain for SHORT-CIRCUIT query

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Dart fix for unused_element removes parameters when it shouldn't

When applying dart fix --apply to the following code:
void main() {
  final _Foo foo = _Foo();
  print('$foo');
}

class _Foo {
  _Foo({this.bar}); // The "bar" parameter is never given a value, but it's nullable.

  final String? bar;
}

The bar parameter is never given a value, so the unused_element lint shows up for that line:
   info • bug.dart:7:14 • A value for optional parameter 'bar' isn't ever given. Try removing the unused parameter. • unused_element

Running dart fix --apply to the code yields:
void main() {
  final _Foo foo = _Foo();
  print('$foo');
}

class _Foo {
  _Foo();

  final String? bar;
}

Which yields the following error:
  error • bug.dart:7:3 • All final variables must be initialized, but 'bar' isn't. Try adding an initializer for the field. • final_not_initialized_constructor

The Dart Fix for unused_element shouldn't remove parameters that are nullable, since they have implicit default values.  Alternatively, it could also remove the uninitialized variable, but I suspect that has tons of corner cases.

cc @goderbauer

I would go one step farther. I don't think that unused_element should flag that parameter because it's being used to initialize the field, even when no argument is passed in.
@srawlins

I believe the fix for an unused field-formal parameter (this.) should remove the parameter, and add bar=null to the initializer list.

I would go one step farther. I don't think that unused_element should flag that parameter because it's being used to initialize the field, even when no argument is passed in.

I don't think that's a reason to pollute the parameter list of a constructor. The situation should still be reported, and the fix can be to move the initialization to the constructor initializer list. The goal is to indicate unnecessary complexity, perhaps unnecessary fields (such as the final field which is only ever initialized with a value of null).

I assume this is what the end result above would be:
void main() {
  final _Foo foo = _Foo();
  print('$foo');
}

class _Foo {
  _Foo() : bar = null;

  final String? bar; // Would this line get a lint warning that says it's always null?
}

So, in that case, would there also now be a lint warning for the final field that is always null?  Presumably there's no dart fix for that because of the possible complexity involved in removing the member and all of its uses.

We actually don't produce any warnings on that last code. We also don't produce a warning if you have a final field with an initializer like final foo = 'hello';.

Oh, sure, I guess it could easily be the case that someone wants a base class to have a final field that is always null that they  then override the getter for in a subclass.


Link and Unlink icons not showing in 2.2.2

Link and Unlink icons are not showing in today's download of https://github.com/Semantic-Org/Semantic-UI/archive/master.zip (2.2.2).
Reproduce with HTML:

Outcome:
Only user icon shows.

You should try change from (un)link to (un)linkify.

Kindly read the icons docs Here
linkify and unlinkify are the classes to be used as @Slowhand0309 said.


Newline characters are lost when .typistRemove is called

While using jquery.typist on a paragraph element, and taking advantage of '\n' to start writing in the next line, the text remains formatted (with newlines and all) until the first time .typistRemove() is called. At that point, the text reformats to fill the element in which it is in, disregarding '\n' characters.

Got it, wait fix for a few days.

Fixed in v0.0.6.


GROUP BY does not take COLLATE into account

Consider the following statements:
CREATE TABLE t0(c0 VARCHAR COLLATE NOCASE);
INSERT INTO t0(c0) VALUES ('a'), ('A');
SELECT t0.c0 FROM t0 GROUP BY t0.c0; -- expected: {'a'} or {'A'}, actual: {'a', 'A'}

Unexpectedly, the GROUP BY does not respect the COLLATE and fetches both a and A. I found this based on commit 50a9e7670827042c94302dc12a8acf0e8bb50fb2.

Good point! I had not considered the GROUP BY for collations yet. Fixed now :)


fix: favicon update

I have deleted old favicon and added a new kubeSimplify favicon.

issue #34

Hey, @shivam-sharma7 it is a bad practice to go directly for PR without getting assigned on the issue, please first get assigned on the issue and then go for the PR.

@SuperAayush okay, I understood.

Hey @shivam-sharma7 I can see some commit related to the readme changes can we do seperate PR for both the commits


PyPI package updated without release notes, changelog, or Github release available

Because I use Github's Dependabot, I get notified when there is a new Mediapipe version available to install from PyPI. However, often I can't find any documentation (release notes, changelog, tag, etc) on Github to give me any idea of what the update contains or addresses. There's also no clear information as to when the release will show up on Github, so I'm left waiting to upgrade without knowing if there's a security or some other kind of serious issue resolved in the newest version.
In fact, the only reference I can find to the latest (0.10.14) version is this comment.
It would be extremely helpful to have some kind of release documentation available when a new PyPI version is released. Thanks!

Hi @cchadowitz,
Apologies for the delay in releasing version 0.10.14 on all platforms including Github as well. You can now view the release notes on Github.
Thank you!!

Thank you, much appreciated!

I have the same quest, seems version .18 has been released recently https://github.com/google-ai-edge/mediapipe/issues/5710#issuecomment-2456563472
Github is at version .15, additionally does that mean that GH repo is behind with fixes/commits or just release wasn't prepared for it?

I have the same quest, seems version .18 has been released recently https://github.com/google-ai-edge/mediapipe/issues/5710#issuecomment-2456563472
Github is at version .15, additionally does that mean that GH repo is behind with fixes/commits or just release wasn't prepared for it? @kuaashish

Hi @cchadowitz,
Apologies for the delay. The release notes have now been published and are available here Release Notes v0.10.18.
Thank you!!

We are working on streamlining our release process, but since we have a fair number of binary releases, our builds can sometimes take multiple days. The last step in our release process is publishing the GItHub release notes. While we will continue to try to limit the window between publishing the fist and the last release artifact, there will always be a window. As of now, this is working as intended.


HTTP client to support async DNS resolver

So far, aleph relies on the domain name resolution mechanism provided by JDK (default in netty). Which brings a few well-known problems: names resolving in blocking manner (doesn't play well with i.e. crawlers), no way to employ an alternative cache/retry policy, set TTLs etc.
The solution provided gives the user ability to switch DNS resolving to async mechanism provided by netty. How it could be used:
(def pool (http/connection-pool {:dns-options {:max-ttl 16 :query-timeout 200}}))
@(http/get "http://google.com" {:pool pool})

This code creates a shared instance of DNS resolver (io.netty.resolver.dns.DnsAddressResolver) which is passed to each created connection.
In addition to that, you can now switch off names resolving at all. Might be helpful/desirable when working with proxies.
(def pool (http/connection-pool {:connection-options {:name-resolver :noop}}))
@(http/get "http://<IP_ADDRESS>:3000" {:pool pool})

The only one question that I have is placed here: when using a shared instance of the resolver we need to .close it when the connection pool is shutting down. To do that I need to extend flow/instrumented-pool with either a callback to be call after shutdown is performed or with some kind of .terminationFuture that I might use to add a listener. @ztellman  What do you think is more preferable?

Beyond the one doc fix I mentioned in the comments, this looks good.

@ztellman I fixed the documentation, thanks! But there's another issue that I want to discuss: https://github.com/ztellman/aleph/pull/355/files#diff-95720affa86696b46c5458a71ab3e8d7R773 - I close DNS resolver on when client-group is terminated, but, ideally, it should be closed when the appropriate connection pool is terminated. To do that, I need to be able to set a callback on a shutdown of the flow/instrumented-pool. Which can be done i.e. by subclassing dirigiste.Pool. Is there any better way?

Sorry, I guess I'm missing something, but I don't see how Dirigiste connection pools factor into this change.  Those are only used for HTTP connections, as far as I know.

@ztellman The problem that we create DNS resolver here: https://github.com/ztellman/aleph/pull/355/files#diff-f4435cedcc2c6307b45b191b2933fcbdR131, when creating connections pool. Meaning that the best moment to close the resolver is when connections pool is closed (destroyed). With the current implementation, it would be closed only on client group's termination, here: https://github.com/ztellman/aleph/pull/355/files#diff-95720affa86696b46c5458a71ab3e8d7R811

@ztellman Reimplemented once again using DnsAddressResolverGroup subclass to benefit from InflightNameResolver caches. Netty interfaces and class hierarchy for dns namespace is pretty clumsy. I will probably open a pull request to extend DnsAddressResolverGroup implementation to be more flexible, but for now, we can move on with this.
Please, disregard my comment about .close. As we use AddressResolverGroup it will close appropriate resolver when the executor is terminated.


Add jump_to_track method

As proposed in #513. I will gladly make any change that is requested.

Coverage increased (+0.01%) to 60.777% when pulling 43d500b10b858bdd54a3c29a68fee54eb38fe60f on ghcs27:jump_to_track into 06a5e758f65dcb920f72b21353094b468173fa77 on SoCo:master.

The Travis CI build errors on Python 2.6 with
ERROR: You need Python 2.7 or 3.3+ to install the typing package.

Hi @ghcs27,
tested change and it all works as expected.
In the documentation:  it raises a 701 error if not already playing from the queue, and a 711 error if index out of range. Need to correct this.
I think it would be worth adding a bit of context:
'''This function  can only be used if the player is already set to use the queue. If not use play_from_queue. This is faster than play from queue if already using the queue, as it only make one call rather than 3. Note: if the queue is already playing it will continue to play using the new track after jump_to_track. If paused it will remain paused.
'''
Lets get input from others too
Cheers David

Thanks for the doc infos! Updated now.

Coverage increased (+0.01%) to 60.777% when pulling 84f6f54f39e9156a8d09ec0b271a2e08afa5defa on ghcs27:jump_to_track into 06a5e758f65dcb920f72b21353094b468173fa77 on SoCo:master.

Since @DPH already reviewed this, I will just give this a quick glance. I am annoyed about the Python 2.6 issue, since I prefer not to pull stuff that doesn't pass test. I will check where we are on deprecating Python 2.6.

I think we are moving on removing 2.6 now (#526), so I would ask you to rebase it afterwards

@ghcs27 #526 was merged. Can you rebase against master, so that we can see if the tests pass?

Done.

Sure! But can you please tell me how I can check how my docstrings will look in Sphinx?

Sure! But can you please tell me how I can check how my docstrings will look in Sphinx?

@ghcs27 of course. You will need to compile the docs locally, so you will need to install sphinx locally. If you develop SoCo in a virtual environment this should be fairly easy. If you install the development requirements:
pip install -r requirements-dev.txt

then enter the doc folder, and then do:
make html

then the docs will be built inside the _build/html sub-folder and so you should be able to open _build/html/index.html in a browser to view the results.
If you are on Windows you will need to use the make.bat. I don't know the syntax for it, but I suspect it is similar and easily googlable.
Let me know if it doesn't work for you.

@KennethNielsen thanks for the instructions!
I took care of the docstring (I hope it's ok now).
But before you merge anything, please await another PR for comparison which integrates this functionality into seek(). This will (a) be closer to the implementation by Sonos (they both use the avTransport.Seek() method) and (b) allow you to construct a dict {track=0, position='0:00:00'} representing the absolute position and seek to this position with a single call (useful for snapshot et al.).

Closed in favor of #541.


Update README.md

add contact info to readme

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.77%.  Consider uploading reports for the commit de24113 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #49      +/-   ##
=============================================
- Coverage      69.35%   68.77%   -0.59%
+ Complexity       313      310       -3
=============================================
  Files             64       64
  Lines           1201     1201
  Branches          69       69
=============================================
- Hits             833      826       -7
- Misses           327      336       +9
+ Partials          41       39       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Kubernetes Operator for OSBA?

Are there plans for a kubernetes operator for OSBA? https://kubernetes.io/docs/concepts/extend-kubernetes/operator/

Service operator? Yes. But the GitHub repo is private for now. I don't know when it will come to public.

Do you have an idea of what sort of functionality you would want in a Kubernetes operator?


Fix uBlock Origin install steps

The "3rd-party Filters" tab was renamed. Also, previously it wasn't clear how to get to the dashboard.
These instructions were tested on both Chrome and Firefox.
The thumbnail image is still outdated, but I'm not sure how to update that.

This looks good. Thanks for updating. I'll have a PR in a sec for an updated image.


f64 in adjacently tagged enums fails to deserialize when arbitrary_precision feature is enabled

The crate fails to deserialize this JSON, when arbitrary_precision feature is enabled:
{
    "data": {
        "field": 1.0
    },
    "kind": "Variant"
}

A reproducible snippet that panics at the serde_json::from_str line:
/*
[dependencies]
serde = {version = "1.0.177", features = ["derive"] }
serde_json = {version = "1.0.104", features = ["arbitrary_precision"]}
*/

use serde::{Deserialize};

#[derive(Deserialize, Debug)]
#[serde(tag = "kind", content = "data")]
pub enum Enum {
    Variant {
        field: f64
    }
}

fn main() {
    let string = r#"{
        "data": {
            "field": 1.0
        },
        "kind": "Variant"
    }"#;
    // thread 'main' panicked at 'works: Error("invalid type: map, expected f64", line: 6, column: 5)', src/main.rs:25:59
    let deserialized: Enum = serde_json::from_str(string).expect("works");
    println!("{:?}", deserialized);
}

Any of the following actions make the panic go away:

Replacing 1.0 with 1
Removing #[serde(tag = "kind", content = "data")] and changing the JSON structure accordingly
Removing arbitrary_precision feature
Deserializing to serde::Value first and, then, deserializing serde::Value to Enum
Place kind before data in JSON

seva@X serde-issue % rustc -V
rustc 1.65.0 (897e37553 2022-11-02)

Also reproduces in RustExplorer.

Oh, it seems like a duplicate of #959. However, should it be closed if it's not fixed yet? Might be worth to track it as a known bug. Anyway, feel free to close the issue, sorry for bringing it again.

Can confirm this error still happens with the latest release.

Is there an older version not affected by this?


python37Packages.identify: 1.5.14 -> 1.6.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.identify is: "File identification library for Python"
meta.homepage for python37Packages.identify is: "https://github.com/chriskuehl/identify"
meta.changelog for python37Packages.identify is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.6.1 with grep in /nix/store/4g68hrj2n70bi3sfr9bsrfrp1c46ldqz-python3.7-identify-1.6.1

directory tree listing: https://gist.github.com/486517f5bc94e4ae44e3af61f00457b6

du listing: https://gist.github.com/9e1c7d670419ad09ddcdae1c0ab7f150

Rebuild report (if merged into master) (click to expand)

28 total rebuild path(s)

7 package rebuild(s)

7 x86_64-linux rebuild(s)
7 i686-linux rebuild(s)
7 x86_64-darwin rebuild(s)
7 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
pre-commit
python37Packages.identify
python37Packages.pre-commit
python38Packages.identify
python38Packages.pre-commit
python39Packages.identify
python39Packages.pre-commit

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/4g68hrj2n70bi3sfr9bsrfrp1c46ldqz-python3.7-identify-1.6.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.identify https://github.com/r-ryantm/nixpkgs/archive/196b4ead1d3b064cf3bc94c06ffb790662e1c608.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/4g68hrj2n70bi3sfr9bsrfrp1c46ldqz-python3.7-identify-1.6.1
ls -la /nix/store/4g68hrj2n70bi3sfr9bsrfrp1c46ldqz-python3.7-identify-1.6.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages built:

pre-commit (python38Packages.pre-commit)
python37Packages.identify
python37Packages.pre-commit
python38Packages.identify
python39Packages.identify
python39Packages.pre-commit

Maintainer pings

Result of nixpkgs-review pr 114615 at 196b4ead run on aarch64-linux 1

6 packages built:

pre-commit (python38Packages.pre-commit)
python37Packages.identify
python37Packages.pre-commit
python38Packages.identify
python39Packages.identify
python39Packages.pre-commit

1 suggestion:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/identify/default.nix:17:3:
   |
17 |   meta = with lib; {
   |   ^

Result of nixpkgs-review pr 114615 run on x86_64-linux 1

6 packages built:

pre-commit (python38Packages.pre-commit)
python37Packages.identify
python37Packages.pre-commit
python38Packages.identify
python39Packages.identify
python39Packages.pre-commit


Add ChannelData to Cmd

This stores a bit more info than just the channel name; in addition you get the protocol (irc, slack, telegram), server host, and whether the channel is a private chat or a public channel.
As of now this is a drop-in replacement without BC breaks.
Also relevant to #6 and #37 .

I see I have left out the proper info for Slack channels, please hold off on merging this PR.

Added some code to get the proper channel name for Slack channels, rather than just some Cxxxxxx code. I'm not 100% sure if this is the most effective way - am I not pissing away memory by storing / retrieving the Channels this way? Should or shouldn't I use pointers? Some guidance would be nice, since I'm still new to Go. :)
While adding this code, I saw that extractUser doesn't seem to do any sort of caching - is that really what we want to do, or should we cache the User ID's with the attached Slack User, similar to what I'm doing with Channels now? I could use the user_change event to update our list in case of user profile updates. Let me know if that's desired.

@doenietzomoeilijk You are right, the extractUser could be cached, if you are willing to change it will be a nice optimization.
And I don't think this list of channels would be an issue to be stored, go uses so little memory that you must try harded than this for it to be an issue 🤣
Thanks for your PR, I'll merge it and deploy this new changes to my bot to test it out.


[BUG] Interpreter seems not to be able to handle substructured field properly

Thank you for developing such a nice tool!! and congratulations for the 1.0.0 rc release 🎉 I tried to apply<EMAIL_ADDRESS>local testing function to my product, and I found this issue.
Describe the problem
(Maybe this post includes two issues 🙏 )
falco's interpreter seems not to be able to handle substructured field properly in HTTP Header Field, both of setter/getter.
VCL code that cause the problem
sub vcl_recv {
    set req.http.VARS:hoge = "hoge";
    set req.http.VARS:fuga = "fuga";
    // @debugger
    set req.http.VARS:bar = "bar";
}

also, I make the small reproduction https://github.com/Shinyaigeek/falco-interpreter-playground
I executed
./falco simulate --debug ./default.vcl

and launched the simulator's debugger and checked req.http.VARS and req.http.VARS:hoge
Screenshots
if I call req.http.VARS, falco outputs the below result
│> req.http.VARS                                                                              │
│>> (STRING)hoge=hoge

if I call req.http.VARS:hoge, falco outputs the below result
│> req.http.VARS:hoge                                                                         │
│>> (STRING)

Expected behavior
In calling req.http.VARS, the expected outputs are the below
│> req.http.VARS                                                                              │
│>> (STRING)hoge=hoge; fuga=fuga

In calling req.http.VARS:hoge, the expected outputs are the below
│> req.http.VARS:hoge                                                                         │
│>> (STRING) hoge

Desktop (please complete the following information):

OS: macos
Shell: zsh

@Shinyaigeek Thanks for finding an issue with more details!
It seems a bug, I will look into it.

This issue should be fixed in 1.0.0-rc2 including #178 , please try the new RC version.
In addition,  multiple headers like VARS:xxx  will be combined with a comma:
set req.http.VARS:foo = "bar";
set req.http.VARS:hoge = "huga";

On HTTP request:
vars: foo=bar,hoge=hufga

You can see the above behavior in fiddle
Thank you for reporting the issue.

@ysugimoto This worked perfectly on my environment!! Thank you for the quick fix 👍 (and sorry for mistake 🤦)


⚠ GitHub has degraded performance

In 50f3b6a, GitHub (https://www.githubstatus.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 281 ms

Resolved: GitHub performance has improved in 34faa23 after 15 minutes.


Injection sidecar pod cannot access other services

After injecting sidecar， An error occurred while accessing other services through domain name inside the pod。
For example, pod1 passes through svc.cluster.local access pod2's servcie

Please give more info about your setup, what calls you are making, what is failing, the config, etc: https://github.com/istio/istio/wiki/Troubleshooting-Istio

Closing as we do not have enough info


ZigBee Clusters and Ikea Symfonisk Volume Control

Hi,
I have been trying to get the Ikea Tradfri Symfonisk device to report its events via Observe in this library. The device is connected sucessfully and I can ask the gateway for its details and it even send random updates using Observe, however it will not report click and rotation events.
A clue as to why may be in the following comment within the deconz project. The developer says:
"bind the client OnOff cluster to a group. And then the client Level Control cluster. After that, it now behaves normally, waking up to send commands on click and turn. " (https://github.com/dresden-elektronik/deconz-rest-plugin/issues/1898#issuecomment-535090364)
Is there the ability to do this in CoAPnet? I would really love to get this device working. So many uses for it.
Cheers!

Hi,
I also have a Sonos so may I can debug as well.
Please share some prepared code so that I can try it on my own.
But general speaking: It should work 😄
Best regards
Christian

Hi,
Thanks for replying. For clarity, I am not trying to control the Sonos, simply I want to get the events from the Symfonisk volume control from Ikea (https://www.ikea.com/au/en/p/symfonisk-sound-remote-white-40370481/)
Here is some rought test code I threw together:
Connecting:
    try
    {
    var LConnectOptions = new CoapClientConnectOptionsBuilder()
	    .WithHost(INSERT_IP_ADDRESS_HERE)
	    .WithPort(INSERT_PORT_HERE)
	    .WithDtlsTransportLayer(o => o.WithPreSharedKey(INSERT_CLIENT_ID_HERE, INSERT_PSK_HERE))
	    .Build();

    FCoapClient.ConnectAsync(LConnectOptions, CancellationToken.None).Wait();

    MessageBox.Show("Connection Successful!");
    }
    catch(Exception ex)
    {
    MessageBox.Show(ex.Message);
    }

Once connected:
		class ResponseHandler : ICoapResponseHandler
		{
			public Form1 FForm1;

			Task ICoapResponseHandler.HandleResponseAsync(HandleResponseContext context)
			{
				FForm1.AppendTextBox(Encoding.Default.GetString(context.Response.Payload));

				return Task.CompletedTask;
			}
		}

		public void AppendTextBox(string value)
		{
			if (InvokeRequired)
			{
				this.Invoke(new Action<string>(AppendTextBox), new object[] { value });
				return;
			}
			textBox17.Text += value;
		}

		private void button6_Click(object sender, EventArgs e)
		{
			ResponseHandler LResponseHandler = new ResponseHandler();
			LResponseHandler.FForm1 = this;

			var observeOptions = new CoapObserveOptionsBuilder()
						.WithPath("15001/" + INSERT_DEVICE_ID_HERE)
						.WithResponseHandler(LResponseHandler)
						.Build();

			var observeResponse = FCoapClient.ObserveAsync(observeOptions, CancellationToken.None).Result;
		}

Does this information help?
https://www.zigbee2mqtt.io/devices/E1744.html
https://www.zigbee2mqtt.io/information/binding

Sorry but I don't had the time to test it on my own. I hope to have a look at the weekend.

Hi. Any chance you have made any progress on thi? Cheers.

Sorry for the long delay. I do not have this device so I cannot reproduce the issue.
But to me is sounds like a regular observation of messages. This feature is indeed supported by the library.
I created a test and subscribed to changes of a Tradfri Bulb and it works. Hope this helps.


build failed

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Failure { command: "\"pkg-config\" \"--libs\" \"--cflags\" \"libavutil\"", output: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "Package libavutil was not found in the pkg-config search path.\nPerhaps you should add the directory containing `libavutil.pc\'\nto the PKG_CONFIG_PATH environment variable\nNo package \'libavutil\' found\n" } }', src/libcore/result.rs:997:5
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

stainless-ffmpeg is runnable.

Related: https://github.com/meh/rust-ffmpeg/issues/47

Nailed it! Had to just install these dependencies to make build work:
sudo apt-get install libavutil-dev
sudo apt-get install libavformat-dev
sudo apt-get install libavfilter-dev
sudo apt-get install libavdevice-dev
sudo apt-get install libclang-dev

Note, ffmpeg-next seems to be more popular and better documented than stainless-ffmpeg

This guideline is also useful. After doing steps on FFmpeg guideline, run PKG_CONFIG_PATH="$HOME/ffmpeg_build/lib/pkgconfig cargo build, panic disappears.