Fixed SiteBranding CSS bug for generated sites

When using the 'generate' command the generation of the site-branding.css file was occurring before the workspace DSL had been read in to memory meaning that it was always using the defaults instead of any properties in the DSL.
I've moved the call to 'copySiteWideAssets' to after the DSL is read in for both the local workspace DSL and for repository based DSLs. In the case of a repository based DSL the copySiteWideAssets call is only done once on the default branch.
Fixes #219

The copySiteWideAssets method only copies static content. Moving this call further down really shouldn’t make a difference.
The generating of the branding stylesheet happens later in https://github.com/avisi-cloud/structurizr-site-generatr/blob/main/src/main/kotlin/nl/avisi/structurizr/site/generatr/site/SiteGenerator.kt#L65

oh I think you are right and I did a bad test on my side.
I'm seeing the issue because I build three branches and the last branch that I build does not have any custom style on the dsl so I get the defaults and that is overwriting the site-branding.css file in the root and being applied to all sites.
I'm going to redo this PR and rewrite it to move the site-branding.css to the branch directory and have it loaded from there depending on which branch is being viewed.

@jp7677 I've made the changed on the comments you left but I've noticed something unusual in addition to the fix above.
When you generate a site ( or local serve ) there is a 'puml' and 'svg' directory created in the root folder with names of the files duplicated in the filename, for example if you have a softwareSystem called MySystem there is a file created called MySystem-SystemContext-MySystem-SystemContext.puml while in the branch folders puml folder there is a similar file called MySystem-SystemContext.puml
I'm wondering if this is a bug of some sort. It seems to happen during the generateHtmlFiles stage of the process.

@jp7677 I've made the changed on the comments you left but I've noticed something unusual in addition to the fix above.

Thanks a lot, looks good and cool that you were able to drop the first two commits.

When you generate a site ( or local serve ) there is a 'puml' and 'svg' directory created in the root folder with names of the files duplicated in the filename, for example if you have a softwareSystem called MySystem there is a file created called MySystem-SystemContext-MySystem-SystemContext.puml while in the branch folders puml folder there is a similar file called MySystem-SystemContext.puml
I'm wondering if this is a bug of some sort. It seems to happen during the generateHtmlFiles stage of the process.

This is the working directory for creating the embedded/clickable diagrams (https://github.com/avisi-cloud/structurizr-site-generatr/blob/main/src/main/kotlin/nl/avisi/structurizr/site/generatr/site/DiagramGenerator.kt#L37). Here we always pass the root exportDir as location. As far as I’m seeing this is fine, since we also check the definition of the diagrams when deciding if they are up to date or not. As a side effect this greatly improves performance by not repeatedly generating the same diagrams across multiple branches.

LGTM, I’ll do a brief test when being again in front of my machine (unless @dirkgroot beats me), though I expect this PR to be fine and will merge afterwards.


Flutter app not runing on ios app

Thank you for taking the time to file an issue! This tracker is for issues related to the Dart analyzer and linter, the Dart core libraries (dart:async, dart:io, etc.), the Dart native and web compilers, and the Dart VM.
When reporting an issue, please include:

The Dart version and tooling diagnostic info (dart info)
Whether you are using Windows, macOS, or Linux (if applicable)
Whether you are using Chrome, Safari, Firefox, Edge (if applicable)

Other pieces of the Dart ecosystem are maintained elsewhere; please file issues in their respective repositories:

Flutter: https://github.com/flutter/flutter
Dart language: https://github.com/dart-lang/language
Dart website: https://github.com/dart-lang/site-www
dart format: https://github.com/dart-lang/dart_style
dart pub: https://github.com/dart-lang/pub
dart test: https://github.com/dart-lang/test
Dart & Flutter DevTools: https://github.com/flutter/devtools

If you have a question, instead of using this issue tracker, please refer to the community resources at: https://dart.dev/community#join-the-conversation.

I have the same issue here! :-)

Same issue here!
Semantic Issue (Xcode): Use of undeclared identifier 'FIRVectorValue'
/Users/gabrieluca/.pub-cache/hosted/pub.dev/cloud_firestore-5.6.0/ios/cloud_firestore/Sources/cloud_firestore/FLTFirebaseFirestoreWriter.m:34:35

Specs:

Flutter 3.27.1
$FirebaseSDKVersion = '10.29.0' in Podfile.

  firebase_auth: ^5.3.4
  firebase_core: ^3.9.0
  firebase_crashlytics: ^4.2.0
  firebase_messaging: ^15.1.6
  firebase_remote_config: ^5.2.0
  firebase_storage: ^12.3.7
  cloud_firestore: ^5.6.0
  cloud_functions: ^5.2.0

This appears to be an issue with the flutterfire packatges not Dart. I've raised an issue there https://github.com/firebase/flutterfire/issues/16906
A temporary workaround for this issue is pinning cloud_firestore to 5.5.1
cloud_firestore: 5.5.1


[SPARK-10913][SPARKR] attach() function support

Merged build triggered.

Merged build started.

Test build #43286 has started for   PR 8997 at commit 804052f.

Test build #43286 has finished for   PR 8997 at commit 804052f.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43286/
Test FAILed.

Merged build finished. Test FAILed.

Hi admin, I have added some more test cases, could you please rerun? Thanks.

Merged build triggered.

Merged build started.

Test build #43304 has started for   PR 8997 at commit 5f3f262.

Test build #43304 has finished for   PR 8997 at commit 5f3f262.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43304/
Test PASSed.

Hi, anything else needed from me to have this PR delivered? Thanks.

@adrian555 Could you bring this up to date with master branch ?

@shivaram I have created the new pull request #9031 with the up-to-date files.

Ok thanks. We shouldn't need to open a new PR for this and you can just push a merge to this same branch and this PR should get updated. Anyways, could you close this PR to avoid confusion ?
Only the PR author has permission to do this.

Thanks @shivaram. First time doing so. :) I will follow your suggestion next time.
Closing this PR.


Alignment issue in Footer.

The various links such as Home About Contact etc are aligned vertically. This would look better is aligned in  a horizontal manner.

I request you to assign me this issue

The issue is complete and the pr has been merged
Thank you for your contribution


[Add] New Button with RGB animation on the boundary

Details
I want to add a new Button with RGB animation on the boundary
Kindly assign me the issue under Hacktoberfest'23 @Spyware007
Screenshots
No response
Type of Contribution

[ ] Update to an existing Animated Button
[X] Adding a new Button
[ ] Resolving a bug
[ ] Proposal to the Repository
[ ] Changes related to documentation or README.md
[ ] Other Changes

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue
[ ] I am a GSSoC'23 contributor

Please assign to me

Hi @singodiyashubham87 i am interested in this issue
So please assign me this issue

@Priyanshu-ai902 I'm also interested to work, Mate.
Only the repo owner can assign.

Please assign this issue to me

please allow me the opportunity to resolve this issues at hand.


Solve the todos, please

Hello, you have published a great paper.
But can you please solve the todos, because I need your code for a university project and it would help immensely.
Thanks in advance

Thanks! I didn't get time to complete it. Planning to update it in the coming week.

When exactly?

please?


add nodeBlockForRowAtIndexPath support

fallback to nodeForRowAtIndexPath if nodeBlock is not defined by constructor.

@fumito-ito Thanks for your PR and sorry for the delay.
Can we use both nodeForRow and nodeBlockForRow ? If no, should we create another init construction for each to help other users avoid implement both closures by mistake?

@dangthaison91

Can we use both nodeForRow and nodeBlockForRow ?

No. According to API docs, nodeBlockForRow  takes precedence over tableNode:nodeForRowAtIndexPath: if implemented.

If no, should we create another init construction for each to help other users avoid implement both closures by mistake?

I think so too ! I will implement this PR in this weekend.

Hi @fumito-ito, have any progress on this PR? I'm really looking forward to merging it.

@dangthaison91 sorry for delay.
But I found my PR has already separated constructor for nodeBlockForRow and nodeForRow.
So I guess that users will not be able to implement both closure.
Do I understand you ? If no, Could you tell me more description ?

@fumito-ito Oh really sorry, It's my mistake :D.


Proposal: port subscription lifecycle events

It would be helpful for JavaScript code to know if the Elm app is currently subscribed to the messages it's sending.  The JS code could then free up resources, stop timers, or close web sockets when they are not needed.
In my particular case, I have a single page that listens to a websocket via an inbound port.  I had to add some logic to my router to send a close message when it sees the user transition away from that page, which did not feel very elegant.

We try to keep issues just about specific bugs. We tend to discuss feature suggestions on discourse. Maybe try to get other people to share other concrete examples of cases where they think this would be helpful.


feature: add syntax @@session.xxx

Proposed changes
add syntax @@session.xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[x] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.25 seconds
load time: 647 seconds
storage size:<PHONE_NUMBER>3 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230105161916_clickbench_pr_74415.html


Enable NEON-optimized slide_hash on aarch64

NEON-optimized slide_hash wasn't built on aarch64 even if NEON-optimizations were enabled.

See https://github.com/zlib-ng/zlib-ng/pull/560#issuecomment-647063133

made https://github.com/dankegel/zlib-ng/commits/cmake-intrinics-files-v2-plus-bug638 go green for aarch64!


BRS-291-1: Convert A&R to use SAM

Jira Ticket:
BRS-291
BRS-322
BRS-323
BRS-342
BRS-343
Jira Ticket URL:
#291
#322
#323
#342
#343
Description:
Credentials in env.js to hit the Tools API from a local setup:
window.__env.API_LOCATION = 'https://r9f4ib8x0m.execute-api.ca-central-1.amazonaws.com';
window.__env.API_PATH = '/dev';
window.__env.API_PUBLIC_PATH = '/dev';

# 291 - Move A&R to use SAM

A complete overhaul of the deployment strategy of BC Parks Attendance & Revenue API to use AWS's Serverless Application Model (SAM).

This includes migrating the functions into their equivalent SAM functions, changing util functions into applicable layers, converting/reintegrating tests to use SAM, and removing any Terraform legacy code

uses an Authorizer (authorizer/index.js) to process the JWT from Keycloak and create the necessary IAM roles for each function

sets up the API in API Gateway using the Authorizer

creates a new ParksAr, ConfigAr, and NameCacheAr tables in DynamoDB

create a new S3 bucket for export assets

dependent on additional tickets (322, 323, 342, 343)

# 322 - Update Functions

builds the Lambda functions using SAM, update dependency and other import paths, add respective package.json files for each Lambda's required dependencies
configure roles/permissions to be expected from the event, as they are now decoded in the Authorizer
fixes to export and variance export and their invokables - now use v3 SDK and properly upload to the S3 bucket

VarianceExportGetFunction altered slightly to more closely resemble ExportGetFunction (was easier to debug during update).

# 323 - Create Layers

create any necessary layers from the utils files

merge the logger, sendResponse, and the dynamoUtils file into a BaseLayer file to circumvent the five-layer restriction set by AWS

add Makefiles to build layers

# 342 - Convert Tests

Remove old tests files and directories and convert/integrate them to use the SAM configuration

roles come from the event so roles/permissions are allocated in the headers of the tests

update Postman environment paths (will need updating once fully built in dev/test/prod), fix a few typos and tests
update READMEs accordingly to reflect changes

# 343 - Cleanup Terraform and non-SAM Code

updates the .github/wokflows deploy actions to build and deploy the SAM files in each AWS environment
pull out all Terraform deployment files and strategies
update the READMEs to reflect the new start up procedures for local startup, AWS deployment, etc.

Remade PR after the previous one was accidentally merged and reverted here: https://github.com/bcgov/bcparks-ar-api/pull/344


xAi support

xAi just dropped! and we need NextChat to support it.
https://accounts.x.ai/sign-in?redirect=cloud-console

https://chat.proxyxai.com

docs
https://docs.x.ai/docs/quickstart#making-your-first-request
pricing

can using openai sdk


Fixing buttons

This is a(n):

[x] Update to an existing Animated Button
[x] Any Error
[ ] Proposal to the Repository
[ ] Documentation / README.md changes

Details:

These 2 buttons have errors

1st button's text is not visible due to larger size
2nd is not a button there may be some error in the code
I want to add a button in place of 2nd button which I have provided through the screen-shot

Please assign me in these issues @Spyware007

@Soumyajit2825 Assigned to you!


PayPal email receipt contains no product information and no seller info

- Do you want to request a feature or report a bug?
Bug.
- What is the current behavior?
PayPal email receipt contains no product information. Product name and seller info is empty.
- If the current behavior is a bug, please provide the steps to reproduce.
Purchase any product using paypal and see generated receipt mailed. See example attached.

- What is the expected behavior?
Product names and seller info are filled out.
- Please mention your Go version, and operating system version.
Any.

@pukhalski did you know that you can already pass a description parameter when calling /paypal?
This should set the description for the single amount that is displayed currently.
I will extend the paypal provider to accept an already created order for getting line items to pass to paypal.

I didnt mean to reopen this.


"Edit template" always opens "default theme"

Reproduce

Login to admin CMS
Go to document type settings
Select a document type, e.g Author:  /_/admin/type/author/edit
Click "Edit template"

The "edit template" form will open the default theme without prefilling the selector field.
Expectations

The selector field should be prefilled with the id of the document type (i.e. blog, page, etc)
The template edit form should use currently active theme as configured in site settings.

Wrongfully reported. Turns out it works as it should. User error 🤦♂


"html code" is blocked by "copy button"

html code is blocked by copy button
I wanted to copy the class manually, but it was blocked

I maximized the browser and finally copied it


After playing the youtube player in fullscreen for 20+ minutes it crashes

So I am using 2 fragments for the YouTube player, one for the small view, the other for full screen, every time the full-screen button gets pressed I set all views to GONE and then I pass an array list of YouTube IDs I wanna play in sequence to the full screen fragment which uses a player with dimensions that match the whole screen. I am also listening to "ENDED" state and I am passing the player a new ID every time it is reaching that state. After around 20+ minutes, sometimes takes around an hour to happen, the app crashes with the following log. Note that I have an exo player as well for HLS streams that uses the same methods im calling in the youtube player to fetch data on ENDED and it plays for 6 hours without a hiccup. I am posting here because I am not sure what is causing this problem and it's very confusing. Apologies in advance if I am missing something and this is not an issue with the player and as always thanks for your help and your great work!
Here is a pastebin with the crash (too huge to post here)  https://pastebin.com/M2CMXe2V

This log is not very helpful (and a bit too much :)), I don't think the issue is with the player, but it's hard to tell for sure.

What log do I need to send so we can figure this out.

I am facing the same issue with Android 8.0 based Smart TV.


golint

Would you accept a PR to fix all golint errors and warnings?

Yes. I wasn't aware these warnings were present, but we'd certainly like to fix them.

created PR https://github.com/mjibson/esc/pull/38


Fixed #13312 -- Added a way to customize the order_by() of null fields

I prepared new PR based on 6981 due to inactivity. I also fixed test failure on Oracle and made few small requested changes.

Buildbot, test on Oracle.

@timgraham test on Oracle please.

I think you should have permission to run the tests on your own PRs. Did you try "buildbot, test on oracle." as per Jenkins?

buildbot, test on oracle

(trailing period required)

buildbot, test on oracle.

I updated the job configuration, please try once more.

buildbot, test on oracle.

Buildbot, test on Oracle.

Buildbot, test on Oracle.

Buildbot, test on Oracle.

I updated PR. Thanks for review.


start kapacitor failed

ts=2021-01-14T14:17:30.540+08:00 lvl=error msg="encountered error" service=run err="failed to open diagnostic service: open /var/log/kapacitor/kapacitor.log: permission denied"
ps ： I hava start influxDb and telegraf

@chuck199202104 -- you do not need to use Kapacitor with InfluxDB 2.0, unless you have been using Kapacitor previously with InfluxDB 1.x.
If you are starting fresh with a new installation of InfluxDB 2.0, use the Flux tasks capability.

Hi @timhallinflux ,
You mean the functions of Kapacitor provide have been integrated into influxdb 2.0? Which mean influxdb 2.0 can do all the stuff?

InfluxDB v2.x has an embedded task scheduling facility.  You define the tasks using Flux.  There is a helper package to assist with the conversion of TICKscripts to Flux:  https://docs.influxdata.com/influxdb/v2.0/reference/flux/stdlib/contrib/tickscript/
However, the tasks are batch tasks.  If you were creating stream tasks with a window, they are effectively batched.
So, other than the pure stream tasks... we do believe that InfluxDB v2.x is ready for addressing all your workloads and has an embedded UI as well.


Print statements within function not displyated

def print() : Unit = println("Hello")
print()

Output is
()

I confirm that. I know I fixed this some time ago, but didn't push it on github at the time. I'll close this issue once that's done.

This is now fixed:

Although, admittedly, the output could be in reverse order (function is defined, then it is called). Re-opening until I can have a look at this.

@alexarchambault Further to this, stdout that is put out after a delay doesn't display at all (beyond a small, fixed window).
Perhaps this might be hard to mesh with IPython's cells concept? (the likes of Scastie and RunKit solve this in a very heavyweight fashion with containers and spawning new runtimes for each output)
That said, the following:
import monix.eval.Task, monix.execution.Scheduler.Implicits.global
import scala.concurrent.duration._

Task("test").delayExecution(1.second).dump("O").subscribe()

The above is a simple example, but being unable to see/capture delayed output makes jupyter-scala pretty impossible to use for debugging async/delayed execution.
The above works fine in ammonite (albeit jankily, printing the output after the shell prompt), presumably because the output is fully unmanaged.
Any ideas on a path towards this use case being possible with jupyter-scala?

@tekacs With the new kernel version (on the develop branch for now), one can update previously displayed values, like
val handle = text("foo") // displays text "foo"
handle.update("other") // updates the previous text - can be done in the background, from an another cell, etc.

println is only supposed to work while a cell is running, yes. AFAIK, jupyter only allows to send actual stdout / stderr output while a cell is running.


Generate Models with Supabase Local Env (Docker)

@karlreginaldo
make the command line access the .env in the project folder to generate the models? Am I understanding this correctly?

ipWhat I mean by local environment is that I want to obtain the generated models while in local development.
Because right now, what’s working is only the Supabase host and the anon key that comes directly from the Supabase.com dashboard

@karlreginaldo Hmm that's weird... this tool typically works even for local development,
This is an example one for the cli
dart pub global run supadart -u http://localhost:8000 -k eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyAgCiAgICAicm9sZSI6ICJhbm9uIiwKICAgICJpc3MiOiAic3VwYWJhc2UtZGVtbyIsCiAgICAiaWF0IjogMTY0MTc2OTIwMCwKICAgICJleHAiOiAxNzk5NTM1NjAwCn0.dc_X5iR_VP_qT0zsiyj_I_OZ2T9FtRU2BBNWN8Bu4GE
This one is from the website it also works

could you provide some logs if the cli is giving some?

Using supadart cli with yaml

D:\Project\Personal\servebeez-mobile\_packages\servebeez_common> supadart supadart.yaml
🚀 Supadart v1.4.2
==============================
URL:        http://<IP_ADDRESS>:54321
ANON KEY:   eyJhbGciOiJIUzI1NiIsInR5c...
Output:     lib/generated/models/
Separated:  true
Dart:       false
Mappings:   null
==============================
Generating...
Error Fetching Supabase Swagger
{"code":"PGRST100","details":"unexpected \"e\" expecting \"not\" or operator (eq, gt, ...)","hint":null,"message":"\"failed to parse filter (eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJzdXBhYmFzZS1kZW1vIiwicm9sZSI6ImFub24iLCJleHAiOjE5ODM4MTI5OTZ9.CRXP1A7WOeoJeXxjNni43kdQwgnWNReilDMblYTn_I0)\" (line 1, column 1)"}
Failed to fetch database

Could you try typing this into your browser? <SUPABASE_URL>/rest/v1/?apikey=<SUPABASE_ANON_KEY>
this will get the raw swagger json if its correct
ex:
http://localhost:8000/rest/v1/?apikey=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyAgCiAgICAicm9sZSI6ICJhbm9uIiwKICAgICJpc3MiOiAic3VwYWJhc2UtZGVtbyIsCiAgICAiaWF0IjogMTY0MTc2OTIwMCwKICAgICJleHAiOiAxNzk5NTM1NjAwCn0.dc_X5iR_VP_qT0zsiyj_I_OZ2T9FtRU2BBNWN8Bu4GE
also, make sure that they key ur using is in anon_key.

hmmm this makes sense now.

btw i tried removing the apikey queryparams and swagger json showed up
http://<IP_ADDRESS>:54321/rest/v1/

I see the problem now.
You are most likely using the cli for local development (thus the 54321 port)
https://supabase.com/docs/guides/cli/getting-started?queryGroups=platform&platform=npx
and not this self hosting docker part.
https://supabase.com/docs/guides/self-hosting/docker
and based on the query you made it actually behaves different and doesnt need the apikey..
i guess this tool doesn't support (will work on it) this version of local supabase. what i suggest is probably to just recreate the db in an online version of supabase or switch to docker self hosting. will work on solutions for this though.

yeah you're right! I'll switch to self hosting.
Thanks @mmvergara. you can close this issue

@karlreginaldo
should now support cli type of local development
https://github.com/mmvergara/supadart/pull/57


Date picker throws error when try to edit value in search boxes

The date picker seems to work well if boundary dates are mouse picked from the presented choices but throws and error if try to keyboard enter a value in one of the date boundaries search boxes
Example:

go to
https://dev.gpcrconsortium.org/chaise/search/#1/gpcr_browser:construct_gui?facets=(construct_gui:site::eq::USC)&layout=table&page=1

select the "date_registered" facet

try to backspace on any of the search boxes

error
Status: 409
ResponseText: 409 Conflict
The request conflicts with the state of the server. invalid input syntax for type date: "2016-01-"
LINE 8: ...te" = 'USC'::text)) AND ((t0."date_registered" >= '2016-01-'...
^
TextStatus: error
ErrorThrown: Conflict
URL: https://staging.gpcrconsortium.org/ermrest/catalog/1/aggregate/A:=gpcr_browser:construct_gui/site=USC/date_registered::geq::2016-01-/$A/cnt:=cnt_d(title)

Fixed in the master with commit 714e6461a1b2994d8981c1941b8685e6fab5645a by making readonly the input fields of the date picker.
In this way, the user can modify the dates only through the date widget.

I confirm that the read only works and no longer throws error when trying to edit the field. But, is that the behavior we want? Wouldn't be a case in which the user wants to manually enter the value?

I think we should allow user to manually edit the date.. For example, the default on rbk is in 2014. If I want to set it to the current year, I would need to do too many clicks.

I am closing this issue for search. We will deal with this in recordset app.


Feature that allows us to set menu item more customizable

Hey everyone, me again! Soooo, I found myself in a position where i needed to set custom spacings and height for the menu items. So I added this feature so everyone can do so. Hope you'll like it. Have a great day everyone!
Signed by Branislav Mateáš.

I think it should be fixed now ;)
Signed by Branislav Mateáš.

In itemBorderRadius it's better to get BorderRadius instead of double.
So user can do more customization

Well, with your first point I can agree upon, however with second sentence, I see a problem as your innerPadding isn't really Padding as you're solving this inner spacing by SizedBox, which is not as good imo. I can rewrite it if necessary but for now, I kept the itemInnerSpacing - double type, but changed itemOuterSpacing to itemOuterPadding as it is the only true padding - EdgeInsetGeometry type. Have a great day.
Signed by Branislav Mateáš.


Possible improvement to the speed of the algorithm

Hi, I've recently learned about t-digest and really like the algorithm. I coded a very naive implementation in C++ using std::multimap for centroids and found 3µs per measurement way too expensive (I'm trying to use it in a fast map/reduce-like setting with up to 10 million measurements per chunk, and 3µs made response unacceptable).
However in my search for improving the speed I found that too much time is spent in computing the head sum after finding closest centroids, which was possible to amortise: I first collect a big enough array of measurements (e.g. 8192), which when full is turned into centroids with weight 1 and sorted with the rest of the summary. Then I go over centroids from left to right compress it by checking if it is possible to merge two centroids by computing q = sum + (l.count + r.count) / 2 (for the possibly merged centroid) and compute k based on it. If l.count + r.count is less than or equal to k, then I merge two centroids into one, which becomes the new l, otherwise I consider the next pair and so forth.
In my very simple checks on random data so far I found this seems to give less accurate results than the original t-digest, however the accuracy was still pretty good considering the final summary size, and the best part is that this variant gives me around 70ns per measurement. I considered other variants, like computing all head sums and then trying to merge closest or smallest centroids first, but this didn't give much accuracy improvement while slowing it down.
I'm wondering what you might think about this extremely simplified version and what are fatal flaws with using it like this?

To the above formula for q I just had an idea to use either left q or right q when computing k, whichever gives the smallest q * (1 - q). This way two centroids on the opposite sides of the center would only get merged if each of them has enough capacity.

Yes.  Head sum is the critical issue.
What I would recommend is that you take a look at the MergingArray implementation.  No need for trees.  Very fast insertion.
The algorithm is even simpler than the tree versions.
The idea is that you simply accumulate new data into an array.  When the array fills, you sort it and merge with the existing t-digest centroids. Because the merge transits the merged data in order, all of the head sum stuff is handled trivially.  This also allows an incremental improvement suggested by otmar that we can get a very precise bound on whether the new data and the existing centroids should merge so that there is a finite bound on the size of the entire data structure.  As a result, we can also avoid all dynamic allocation while the algorithm is running while preserving accuracy as before.
So far, I have only been able to match the performance of the existing tree based algorithm (the AVL-tree), but I really think that we could beat it significantly.  Right now, the cost is about 200ns per new data point. I think that can drop noticeably.

Ah! So sorry, somehow I missed MergingDigest class among all other classes, and it looks a lot like what I had in mind, except the condition for merging is different. Description of integratedLocation is very helpful, thank you very much!

Hmm. I tried using merging condition of ∆integratedLocation <= 1 like in MergingDigest, it causes a much smaller number of centroids in the end, but accuracy is not as nice, and there are other differences like edge centroids no longer stay at count 1, etc. However this: https://github.com/snaury/t-digest-simple/blob/master/merging_tdigest.hpp (sorry for C++, I'm not as comfortable with Java) gives a similar number of final centroids to TreeDigest and is much faster (looks like asin is a little slower than simple multiplications).

Yes, the integrated location approach does give fewer centroids. In fact,
it gives a bounded number while the other criteria tend to give an
unbounded O(log(n)) result.
Bounds are good.
On Thu, Oct 22, 2015 at 4:29 PM, Alexey Borzenkov<EMAIL_ADDRESS>wrote:

Hmm. I tried using merging condition of ∆integratedLocation <= 1 like in
MergingDigest, it causes a much smaller number of centroids in the end,
but accuracy is not as nice, and there are other differences like edge
centroids no longer stay at count 1, etc. However this:
https://github.com/snaury/t-digest-simple/blob/master/merging_tdigest.hpp
(sorry for C++, I'm not as comfortable with Java) gives a similar number of
final centroids to TreeDigest and is much faster (looks like asin is a
little slower than simple multiplications).
—
Reply to this email directly or view it on GitHub
https://github.com/tdunning/t-digest/issues/61#issuecomment-150383383.

Is there further action required here?
Did you get a fully functional cpp version going?  Did you want to host it as part of this main repo?

No, I think MergingDigest in Java is already good, and although what I proposed is a little faster in practice it comes at the expense of memory. If I noticed MergingDigest from the start I would probably not even created this issue.
As for C++ implementations I've done several and I feel like once you understand the algorithm it becomes very easy to reimplement and adapt it in a way suitable for the task at hand, while coding a generic implementation worth making it official would take too much work or make it very complex and hard to understand. There are a lot of different ways for computing quantiles and percentiles, for example, as well as choices of data types. I'm not sure I would be able to summon enough will to do the grunt work in my free time.

OK.
Btw... I have some new ideas coming that could improve accuracy and
run-time noticeably.
On Sun, May 29, 2016 at 5:04 PM, Alexey Borzenkov<EMAIL_ADDRESS>wrote:

Closed #61 https://github.com/tdunning/t-digest/issues/61.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tdunning/t-digest/issues/61#event-675450241, or mute
the thread
https://github.com/notifications/unsubscribe/AAPSepY8rRCLwyierL-F7ZRjXA5MbHocks5qGbj8gaJpZM4GT-8l
.


Incorrect value highlighted when adding Igneous Volcanic Rock

Describe the bug
When pressing the "+" to add a volcanic rock the modal s Plutonic selected but shows the values for volcanic.

Fixed with commit 72da6c5


preferred spelling guillemot <-> guillemet

https://github.com/LettError/glyphNameFormatter/blob/master/Lib/glyphNameFormatter/rangeProcessors/latin_1_supplement.py#L38-L39
a collection of preferred spelling could be handy, now only dieresis is there, I guess there will be more
https://github.com/LettError/glyphNameFormatter/blob/master/Lib/glyphNameFormatter/__init__.py#L31

It could be a dictionary, but it would not automatically apply to everything, right? The diaeresis pref is used in a range processor only when necessary..

For reference, it seems "guillemot" is an old Adobe typo.
https://twitter.com/typenerd1/status/724677953657790466

Can this be closed?


Rendering bug with icons wider than one column (gap in background)

Windows Terminal version
1.14.1962.0
Windows build number
10.0.19044.1826
Other Software

WSL Ubuntu 22.04
nvim 0.7.2,
FiraCode Retina NerdFont.
lualine nvim plugin (example appears anywhere where an icon is rendered in front of solid background)

Steps to reproduce

Install FiraCode NF (https://github.com/ryanoasis/nerd-fonts/tree/master/patched-fonts/FiraCode)
Install nvim 0.7.2 in ubuntu WSL
Install lualine plugin (https://github.com/nvim-lualine/lualine.nvim)
Open test xml file with nvim test.xml and observe rendering bug, where icon is rendered

Expected Behavior
No gap in rendering
alacritty (windows) or kitty (ubuntu), do not have this issue with the same font:

Actual Behavior
Gap in background highlight rendering, when icons wider than 1 column (e.g., xml file icon in nerd fonts) are rendered.
ms-terminal:

more info:
https://github.com/nvim-lualine/lualine.nvim/issues/790

This might be fixed by the new experimental renderer. I think we've got some fixes in the works for 1.16 that might just address this. /cc @lhecker


fix(pooler): allow supabase.green domain in pooler url

What kind of change does this PR introduce?
Bug fix
What is the new behavior?
Allow connecting to staging pooler for testing.
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-14 of 20 (30.0%)  changed or added relevant lines in 1 file are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.08%) to 58.715%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/utils/connect.go
6
20
30.0%

Files with Coverage Reduction
New Missed Lines
%

internal/utils/connect.go
2
77.78%

internal/gen/keys/keys.go
5
11.76%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
6141

Relevant Lines:
10459

💛  - Coveralls


Add HTML focus management APIs

See https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis

@facebook-github-bot shipit


Fix fullscreen in high DPI displays

Currently, using fullscreen or desktop fullscreen in high DPI displays makes the fonts hard to read.

Won't do for now

Won't do for now


TypeError: path.replace is not a function when using LiveDirectory on windows

Hi, I need to ask about live directory on windows cause i still got an error from live directory. The code looks like this
import HyperExpress from 'hyper-express'
import env from './config/envs.js'
import routes from './routes/index.js'
import LiveDirectory from 'live-directory'

const { APP_URL, PORT, MAX_BODY_LENGTH } = env

const directoryPath = 'C:/laragon/www/work/attendance/hr-saas-upload/src/public'

const app = new HyperExpress.Server({
  max_body_length: 1024 * 1024 * MAX_BODY_LENGTH, //100 MB
})

const AssetsDirectory = new LiveDirectory({
  static: true,
  path: directoryPath,
  cache: {
    max_file_count: 200,
    max_file_size: 1024 * 1024 * 2.5,
  },
  keep: {
    extensions: ['.css', '.js', '.json', '.png', '.jpg', '.jpeg'],
  },
  ignore: (path) => {
    return path.startsWith('.')
  },
})

app.get('/assets/*', (req, res) => {
  console.log(req.path)
  const path = req.path.replace('/assets', '')
  const asset = AssetsDirectory.get(path)
  if (!asset) return res.status(404).send('Not Found')
  if (asset.cached) {
    return res.send(asset.content)
  } else {
    const readable = asset.stream()
    return readable.pipe(res)
  }
})

app.get('/', (req, res) => {
  res.status(200).json({
    success: true,
    message: `Hello Hyper Express Api`,
  })
})

app.use('/api/v1', routes)

app.set_error_handler((req, res, error) => {
  res.status(400).json({
    success: false,
    message: error.message,
  })
})

app.set_not_found_handler((req, res) => {
  res.status(404).json({
    success: false,
    message: 'Sorry, Route not found.!',
  })
})

app
  .listen(PORT)
  .then(() => console.log(`Server is running on port  : ${APP_URL}:${PORT}.`))
  .catch((error) =>
    console.log(`Failed to start Server on port : ${APP_URL}:${PORT}.`, error)
  )

anything wrong with this code?

Hi, you should not see that error. What does you console print for console.log(req.path) before that error occurs? A hyper-express object should always have a path.

It seems an error occurred when defining the directorypath
C:\laragon\www\work\attendance\hr-saas-upload\node_modules\.pnpm\live-directory@3.0.3\node_modules\live-directory\src\components\LiveDirectory.js:60
        path = forward_slashes(resolve_path(path.replace(/\/$/, '')));
                                                 ^

TypeError: path.replace is not a function

Solve with this
const AssetsDirectory = new LiveDirectory(directoryPath,{
  static: true,
  cache: {
    max_file_count: 200,
    max_file_size: 1024 * 1024 * 2.5,
  },
  keep: {
    extensions: ['.css', '.js', '.json', '.png', '.jpg', '.jpeg'],
  },
  ignore: (path) => {
    return path.startsWith('.')
  },
})

Ah yes, the path is always the first argument. Will improve error throwing for that.


implement proxy for Goodreads API requests

Hey! This is a great plugin! We're reviewing it promptly.
I noticed it was tough to test this on the dev environment, so I made some changes to help alleviate some CORS pain. Let me know if these are helpful to you at all!
I didn't find any issues when following your instructions. Your manifest.json, readme.md, and index.ts all look good!
This pull request includes changes to the src/widgets/index.tsx and webpack.config.js files to improve the handling of Goodreads URLs and to update the Webpack configuration for better development and production builds. The most important changes include the addition of a proxy URL for Goodreads requests and updates to the Webpack configuration to handle CSS loading and proxy settings.
Improvements to Goodreads URL handling:

src/widgets/index.tsx: Added a proxy URL for Goodreads requests to ensure proper handling and logging of the URL.

Updates to Webpack configuration:

webpack.config.js: Added a proxy configuration for Goodreads to handle CORS and set the origin header correctly.

Wow that was fast! And thank you a bunch, I was struggling a bunch with CORS 😅
This PR works perfectly, merging noe


update: more help flag

To be synced with the help flag list in brew.rb

👍

I just found out that I forget to escape ?. Fixed in https://github.com/Homebrew/brew/commit/67944c2f2df16f1b68fb425ffb11dc416ee38d49


Use @rpath for SDL frameworks

This adds @executable_path/../Frameworks to the list of rpaths.
Don't change the install name of the SDL frameworks: they are already rpaths.

Sorry for taking so long to get to this; I had it flagged as a thing I needed to get to, but by then it was marked as read and I forgot about it. :(
The main reason why I had those there was because I was getting an error saying that there were multiple versions of SDL and that it was undefined which one would be used.  Is that something that can be safely ignored (or will this make it go away as well)?  I'm pretty clueless when it comes to the finer points of OS X development, as you've probably guessed, so any tips on best practices would be super welcome.

If you mean that you are getting warnings about multiple SDLTranslatorResponder classes, it should be harmless.
It looks like libswresample links against SDL 1.2, so using an install_name_tool hack on it won’t work.
Also, the current Mac version doesn’t have libswresample.dylib included, causing the game to fail to launch.
I’ll try to catch you later.
On Oct 14, 2016, at 10:18 PM, GabuEx <notifications<EMAIL_ADDRESS>wrote:
The main reason why I had those there was because I was getting an error saying that there were multiple versions of SDL and that it was undefined which one would be used.

D'oh, I thought I finally had everything, since it was launching without incident for both me and multiple people. :(  I'll have to add that to the package tomorrow.
Is there any way to identify all of the dependencies something has?  The way I've been doing it is basically just seeing what it breaks trying to load and then adding that, and it seems like there must be a better way than that.

otool -L


New package: Pluto v0.2.0

Registering package: Pluto
Repository: https://github.com/fonsp/Pluto.jl
Created by: @fonsp
Version: v0.2.0
Commit: 98914eca7c7d80fd1520b024344c6f173cd04b27
Git reference: master
Release notes:

Initial release! 🌈

Okay, I'll fix these issues!


baseline commit - secure ingress workload - kubecost

Issue #, if available:
Description of changes: Adding a workload for the secure ingress auth cognito pattern
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rameshv29 do you mind applying slight refactoring based on the above comment?

Thanks for the feedback @shapirov103 !! I have updated the structure and pushed the PR. Can you please review once and provide your approval?


Fix table on the styling article

Looks better https://deploy-preview-509--allotment-website.netlify.app/docs/styling


Embed code on post with GitHub

Can we have something like this for markdown code
https://medium.com/javascript-scene/10-tips-for-better-redux-architecture-69250425af44

There is script tag that renders those:
<script src="https://gist.github.com/Sekhmet/1ace20856d2b524c7a3295c40d4261cf.js"></script>

We can add more embeds in the future when we update post rendering.

+1 for this, been watching this one for a while.


chore: Move examples

This PR aims to align our examples with tokio-rs/tracing (if someone wants to complain about examples/examples, that's fixable and is how tokio is set up).
A secondary effect is that https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#scrape-examples becomes much easier to implement, should we desire it.

it isn't possible to remove the nested examples folder, is it


fix(v2_meta): hint data as being potentially undefined

I've been bitten by this in production a while ago, so here's my attempt at fixing it.
Not sure why we have duplicate types definitions in the react package, instead of a re-export from server-runtime.
Also, not sure this is the smartest fix, would definitely accept a better one

Closes: #6210

[ ] Docs
[ ] Tests

Testing Strategy:

Before
 After

Note this is a duplicate of #5787.

Good catch @aaronadamsCA, thank you!

Reopening for @brophdawg11 consideration.
I think that we both did half the job 😅

yeah I like this one better too I think


onNodeClick prop prevents nodes from being locked

Describe the Bug
When a function is passed to onNodeClick, it prevents pointer-events: none from being applied.
I have nodesDraggable=false, nodesConnectable=false, and elementsSelectable=false and expect pointer-events: none on all nodes. However, onNodeClick is preventing this. When I don't set onNodeClick or set it to undefined, the issue is fixed.
In my opinion, nodesDraggable, nodesConnectable, elementsSelectable and other interactive props should override onNodeClick, as is currently the case with all other event handler props.
Would be good to have this resolved or get an explanation for the current behaviour. Thanks!
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

Pass any function to onNodeClick
Set nodesDraggable=false, nodesConnectable=false, elementsSelectable=false

Expected behavior
When the interactive properties are set to false, I expect to be able to pan around by dragging on the background or the nodes themselves. The nodes should not be selectable, should not move, and should allow panning when clicked on and dragged.
Screenshots or Videos
No response
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context
No response

Hey! This was the behaviour in a previous version. We changed it, because users expect the onNodeClick event to work when they pass it. With pointer-events: none this wouldn't work and it feels broken. Does this answer your question?

@moklick Gotcha, thanks for the info!
For anyone looking for a solution, I've just set
onNodeClick={isEditing ? onNodeClick : undefined}

Could this be re-opened please? I'm in a very similar problem. I need to enable the click functionality, while at the same time also having disabled the nodesDraggable, nodesConnectable and elementsSelectable configurations (so the later fix given by louis wouldn't help in my case). Any ideas?


[clean&fix] Clean up documentation 2nd pass

Look at each commit separately.
[deadlink] Fix all dead-links (internal/external) was by far the most annoying thing I ever made.

 Snippets tests reports   SDK Version Tests overview      v6        v5                           :heavy_check_mark:                            v1        v1        v1        v1


rafthttp: report error to correct chan

Fix #5535.
I messed this up when refactoring the rafthttp. So if the node is removed before it receives the removal command, it will be stuck there since the network layer is not able to report error. This pr fixes it.

lgtm


Rewrite of the README, more open contribution rules

As discussed in our weekly meeting, I've rearranged the README.md and also made the contribution rules/instructions more open for new developers that are interested in contributing to Frosh.

I like it so far. IMHO all that is missing is the part concerning new plugins submissions. Maybe it could read something like this:

If you do want to contribute your own plugins, please be aware that we won't guarantee admission before you provide at least a functional prototype. The important thing is that you are convinced by your idea and you should be developing solely for this occasion.

You're absolutely correct @dneustadt. I like your suggestion and have added it to the README.md.

I missed that bold "you". This is fixed now.


Implement proper zebrad health check endpoint

We currently expose and leverage the tracing configuration endpoint as our health check when we deploy our Docker images to gcloud, hitting it with a GET and expecting a 200 with certain latency params to consider the zebrad start process healthy. This endpoint is unauthenticated, so exposing it is also leaving open a pathway that changes how we log tracing data, to the world.
Instead, we should have a stand-alone health check endpoint that just replies to GET's with the appropriate response code (or you know, nothing if the node isn't really up), with perhaps some metadata about the state of the process, but right now we don't depend on anything besides a 200 in ~10 seconds.
We can literally copy the tracing endpoint impl as an Abscissa component and remove the handling for POSTs and anything more complex than 'i am up and responsive'.

[ ] impl health check endpoint, listening on 8080
[ ] make it off by default? either way make it configurable on/off via our Config
[ ] Update the Dockerfile to not expose the tracing endpoint via port 3000 and not enable  the endpoint in our generated config
[ ] Update the Dockerfile to expose port 8080 and (if not enabled by default) enable the health check endpoint via our generated Config passed to the zebrad start command

Sounds good!
Just a few questions and comments:

with perhaps some metadata about the state of the process, but right now we don't depend on anything besides a 200 in ~10 seconds.

What metadata would be useful?
How much metadata should go in health check, rather than metrics?
How should we decide?

We can literally copy the tracing endpoint impl as an Abscissa component and remove the handling for POSTs and anything more complex than 'i am up and responsive'.

I think that endpoint has some locking bugs right now, see #1001. So we might not want to duplicate it. (Or we might find interesting bugs when we duplicate it.)
Let's also make a copy of the tracing endpoint acceptance test?
We don't want to deploy code with a broken health check endpoint.

make it off by default? either way make it configurable on/off via our Config

I think off by default is the best. Then we don't have to choose a safe default IP address, and we don't have to choose between IPv4 and IPv6.
(Also, adding a new listener that's on by default will break our parallel acceptance tests - that's fixable, but annoying.)

Does the health check have to be unauthenticated, or does that just make it more convenient?
Would we want the health check to be a standalone endpoint, or part of a more general RPC endpoint?  We haven't made any decisions about what kind of RPC we want to support for chain data, and there are choices about whether and to what extent we want to be compatible with Zcashd.
But it seems likely that we'll want to have Zebra-specific RPC methods that aren't related to the chain state or chain data, but are just related to the operation of the node itself. For instance, there's the health check, tracing controls (currently just the filter but in the future, potentially other things like dynamic flamegraphs, etc).  Do we want to create a common "Node RPC" endpoint for this, distinct from the future "Chain RPC"?

Does the health check have to be unauthenticated, or does that just make it more convenient?
Would we want the health check to be a standalone endpoint, or part of a more general RPC endpoint? We haven't made any decisions about what kind of RPC we want to support for chain data, and there are choices about whether and to what extent we want to be compatible with Zcashd.
But it seems likely that we'll want to have Zebra-specific RPC methods that aren't related to the chain state or chain data, but are just related to the operation of the node itself. For instance, there's the health check, tracing controls (currently just the filter but in the future, potentially other things like dynamic flamegraphs, etc). Do we want to create a common "Node RPC" endpoint for this, distinct from the future "Chain RPC"?

For the health check that monitors whether the instances in our instance groups are healthy, it has to be unauthenticated.
For a health check like this, it really should be standalone. It should be bare-bones, not queryable, very simple. It's to answer "is the application alive?" or not, and that's about it. If we want to do more 'Node RPC' stuff, that's a different ball of wax.

The locking bugs for the endpoint are caused by trying to access Abscissa state.  So if the health check endpoint doesn't access that state, it should be fine.

The locking bugs for the endpoint are caused by trying to access Abscissa state. So if the health check endpoint doesn't access that state, it should be fine.

Yeah fairly certain we don't need that, at least for this.

Per #1030 we may want to move from Abscissa components to just "components" that are started up by the start command's main future.  In that case, it wouldn't be necessary to deal with Abscissa, just producing some function that constructs a server task would work.

down with dependency injection! sized the means of future production!

Let's open a specific ticket when we actually need a health check endpoint.


net: add checks for isIPv4

Signed-off-by: Christopher M. Luciano<EMAIL_ADDRESS>
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
These checks are basically a replication of the existing IPV4
checks. A similar method is used for IPv4 address checking in the
k8s/k8s dual_stack e2e testing. Adding these checks to k8s/util can cleanup a TODO mentioned in https://github.com/kubernetes/kubernetes/blob/master/test/e2e/network/dual_stack.go#L528-L542 .
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Release note:
net: add checks for isIPv4

/assign @thockin
for new API review.


Splitter Bar

A very feature rich components.
Would be good if splitter bar is there

https://github.com/carlfranklin/BlazorSliders

https://github.com/luncheon/flex-splitter-directive

Is this feature in the planning stage?

Good news. MudSplitter is ready as extension component. It created with no js.
NuGet: https://www.nuget.org/packages/CodeBeam.MudExtensions/6.0.11


Add UI component for token issuer selection in OAuth/OpenID Connect Configuration

Add UI component for token issuer selection in OAuth/OpenID Connect Configuration

Fixed


Add option to restart prowjob when node is terminated (enabled by default)

Recreate the prowjob when the node is terminated.
This prevents us from having to rerun jobs that were terminated due to a spot instance shutdown.
The pod status that we see on pods terminated due to a spot instance shutdown look like this:
status:
  message: Pod was terminated in response to imminent node shutdown.
  phase: Failed
  reason: Terminated

or
status:
  conditions:
  - message: 'PodGC: node no longer exists'
    reason: DeletionByPodGC
    status: "True"
    type: DisruptionTarget
  phase: Failed

or
status:
  conditions:
  - message: 'GCPControllerManager: node no longer exists'
    reason: DeletionByGCPControllerManager
    status: "True"
    type: DisruptionTarget
  phase: Failed

Most code in this PR is a copy of the existing ErrorOnEviction code, updated for ErrorOnTermination.

Hello @inteon
AFAIK Plank was deprecated.
Since this PR is adding codes under 'pkg/plank/',
I wonder whether:

Adding codes under 'pkg/plank/' is okay regardless of the deprecation of Plank; or
There exists another method to achieve the same goal, adding codes to directories other than 'pkg/plank/'.

Please take a look! 😃

Hello @inteon AFAIK Plank was deprecated. Since this PR is adding codes under 'pkg/plank/', I wonder whether:

Adding codes under 'pkg/plank/' is okay regardless of the deprecation of Plank; or
There exists another method to achieve the same goal, adding codes to directories other than 'pkg/plank/'.

Please take a look! 😃

The code still seems to be used in prow-controller-manager: https://github.com/kubernetes-sigs/prow/blob/0a3518154cf7d730ddc5ad7c6b978c480a6e5dc9/cmd/prow-controller-manager/main.go#L202-L204

/label tide/merge-method-squash

Info: we use this change on our cert-manager prow cluster https://prow.infra.cert-manager.io/ (see https://github.com/cert-manager/testing/tree/0b5dfa456f691e849bb0b3c40f3e00bd8d607127/images/prow-controller-manager-spot).
It works very well, this change has removed a lot of flaky failures due to spot instance shutdowns!

Info: we use this change on our cert-manager prow cluster https://prow.infra.cert-manager.io/ (see https://github.com/cert-manager/testing/tree/0b5dfa456f691e849bb0b3c40f3e00bd8d607127/images/prow-controller-manager-spot). It works very well, this change has removed a lot of flaky failures due to spot instance shutdowns!

This change seems like a nice feature but I am not sure if you are covering all of the generic cases of those pod terminations that are not only related to GCP. Also, this issue can be resolved by adding a pod disruption budget to your cluster.
In my opinion, we shouldn't enable this feature by default. Instead, we can configure specific reasons for recreating the prowjobs, which will allow users to be more specific about their infrastructure.

I am not confident about enabling this feature by default. The implementation covers only a GCP case, and a pod's termination is deeply dependent on the infrastructure. This means, that a prowjob can run forever in a loop in many cases. Perhaps keeping it disabled as default and allowing the user to enable it in the global config? Also, to avoid the infinite runs, perhaps its better to keep track of the number of the retries and allow the user to control the threshold.
@petr-muller @stevekuznetsov @cgwalters @BenTheElder Do you guys have any input?

I updated the PR and added a RetryCount which is now incremented every time the pod is re-created (it also counts other retries that were already present in code). There will be a hard failure after 3 retries have been reached (we might want to make this a variable in the future).

Blocked by https://github.com/kubernetes-sigs/prow/pull/196 since CRD is too large for my setup.

@droslean I don't think PDB would help here since you don't get a choice as to when spot instances get taken away from you.

@droslean I don't think PDB would help here since you don't get a choice as to when spot instances get taken away from you.

Yep. My only concern is whether we should allow this feature to be enabled by default.  Since Prow doesn't directly know what the job will do, there can be cases where the job costs will triple if we allow this by default. I would prefer to make this configuration and let the user decide based on the infrastructure.

@droslean I don't think PDB would help here since you don't get a choice as to when spot instances get taken away from you.

Yep. My only concern is whether we should allow this feature to be enabled by default. Since Prow doesn't directly know what the job will do, there can be cases where the job costs will triple if we allow this by default. I would prefer to make this configuration and let the user decide based on the infrastructure.

I discovered there is already a lot of logic to restart pods (and no limit): Eviction, NodeUnreachable, a PodUnknown Phase. So, I added a global limit of 3 and applied that to all restart, including the existing logic. I haven't (yet) made the restarts disabled by default.

@droslean I don't think PDB would help here since you don't get a choice as to when spot instances get taken away from you.

Yep. My only concern is whether we should allow this feature to be enabled by default. Since Prow doesn't directly know what the job will do, there can be cases where the job costs will triple if we allow this by default. I would prefer to make this configuration and let the user decide based on the infrastructure.

I discovered there is already a lot of logic to restart pods (and no limit): Eviction, NodeUnreachable, a PodUnknown Phase. So, I added a global limit of 3 and applied that to all restart, including the existing logic. I haven't (yet) made the restarts in case of a Spot instance restart disabled by default, because I think the retryCount limit is a better solution.

I would prefer to let the user to decide the list of reasons to restart the prowjob and the retry count limit. For example, in my infrastructure, we run costly jobs, and this feature can potentially increase the cost since its rerunning them by default for those specific reasons. Your solution is good, but I would prefer to make it configurable so the user won't be limited on hardcoded termination reasons and retry limits.  @stevekuznetsov WDYT?

Getting the config semantic right might be hard but I'm for it.

Yeah, I share some concerns about the restart implications.
For example, with 5k node scale tests, we may prefer to simply take the failure and leave boskos to cleanup rather than attempt to start another run, and yet with the many many CI jobs we have it would be difficult to properly identify and opt out all of the relevant jobs.
cc @aojea @pohly
Also, even as a GCP employee, I think we should prefer to use portable Kubernetes, but I guess this is at least somewhat more portable now ... do any of the other major vendors with spot instances set a similar status that can be matched or do we need a different mechanism entirely?
What's the use case where the next periodic attempt and/or /retest is not sufficient?
Are you using the automatic /retest commenter? It's clunky but it has done the job ~OK.

I suspect for most jobs this is better, if bounded, but it's still a surprising behavior change and there's limited bandwidth to go comb through jobs and opt them in/out.
For Kubernetes we could probably opt-out anything reference the boskos scalability pools and be in OK shape.
I don't think we want another best practice field that everyone has to opt in though either .... (like decorate: true which should ideally not be redundant eventually)
What if we have a global option to enable this, in addition to per job opt-out? We could wait to turn this on in until we've opted out any jobs with cost concerns?
I'm also not sure about having a single retrycount is the best approach, but I haven't put much thought into it yet. E.G. failure to schedule is pretty distinct from the other modes (Thought I think we already handle that separately?)

/remove-lifecycle rotten


I believe I followed the instructions on how to set up docker with radarr, made a fresh install of nzbget with no options set apart from my usenet server.
In radarr I have Nzbget as the download client and completed download handling enabled. In the connections, /usr/local/sma/postRadarr.sh is setup
The download handles fine but as soon as its downloaded, nothing happens, the file is left in the download directory, not renamed.
this is from the radarr log:
Import failed, path does not exist or is not accessible by Radarr: /volume1/downloads/completed/Movies/Casablanca.1942.70th.Anniversary.1080p.BluRay.DTS-HD.MA.1.0.x264-HDH

Seems like you need to make sure your paths are consistent across your containers. The path to your downloads seems to be in /downloads in Radarr and /volume1/downloads in NZBGet

Are you suggesting I use nzbget in a docker also?

Yep, if you’re gonna use docker you might as well use it for the whole setup. Otherwise you’ll have issues and there’s no point. At least for the integrated components.
Sent from my iPhone

On Apr 16, 2020, at 7:18 AM, j-burton<EMAIL_ADDRESS>wrote:

Are you suggesting I use nzbget in a docker also?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I'll give it a go now...

Working fantastically, youre the best
Can you shed any light on why my Plex isnt updating after each download?
[Plex]
host = <IP_ADDRESS>
port = 32400
refresh = True
token = j5JiWfx5LFsEU6qa6CCm

That should be fine unless the token is expired. The logs should shed some light onto why it’s failing. If plex is in a docker container some network setups can have issues.


[QUERY] [Azure-core] Response cannot access to the raw http response body.

Query/Question
According to https://azure.github.io/azure-sdk/java_design.html#java-response-logical-entity, the response should include body.
My question, the body here means raw body string or entity type? Because when deserialize the body to an entity object may lost some information of the original body values.
This is situation I met when adopting this PR: https://github.com/Azure/azure-sdk-for-java/pull/6303.  Status information lost after the activation phase. Thus, the downstream flux method cannot handle the provisioning status correctly.

Raw-Body (byte stream) vs Entity-Type depends on the type of T in Response<T>. If the return type of service interface method is - Response<Flux<ByteBuffer>> then it is Raw-body, if it is Response<Foo> then the internal raw http content will drained and be deserialized to Foo.
I'm adding tests to the above PR to cover various ARM LRO cases, it should show how the LRO method in "private" service interface should look like and how activationFunction should wrap it. My initial thought is to have "private"  service interface LRO methods to return  Response<Flux<ByteBuffer>> then read it from activation Function.

This is resolved and tests are added. Closing.


STICKY NAVIGATION

Helloo sir/ma'am , I have participated in GSSOC 22 and I want to contribute in this project . Please assign to me  .
PROJECT DETAIL:
STICKY NAVIGATION :
Why do this project?
-It teaches you how to keep your elements in a fixed position on a page, which is a skill you might need in your front end developer role
-You can use this to upgrade the design of your website or portfolio
-Learn more about how to use query electors, event listeners, and offsetting
Key concepts covered:
.querySelector
.offsetTop
Event listeners
What to do:
Implement the JavaScript code so that when you scroll up or down the page, your navigation bar remains in a fixed and visible position.

/assign

Kindly assign me this @gurjeetsinghvirdee


Fix GCC dereference warning

A downstream customer noticed a build failure on GCC 8.3.1 due to a null pointer dereference warning when building in Release mode.

ping @junkudo

Codecov Report

Merging #620 (80e9edf) into develop (840f6e0) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop     #620      +/-   ##
===========================================
- Coverage    96.09%   96.08%   -0.02%
===========================================
  Files          119      119
  Lines         7658     7661       +3
===========================================
+ Hits          7359     7361       +2
- Misses         299      300       +1

Impacted Files
Coverage Δ

src/serac/numerics/quadrature_data.hpp
100.00% <ø> (ø)

...c/serac/physics/integrators/wrapper_integrator.cpp
97.43% <83.33%> (-2.57%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 840f6e0...80e9edf. Read the comment docs.


Incorporate new logo design

The image in the next comment should be next to the header title of the site and should be the favicon as well

Alternate possibility:


Set Private to false for specific projects instead of everything.

Set Private explicitly to false for certain projects instead of setting it to false for everything and then setting it true for certain projects.

/azp run

@jlaanstra "/azp run" is no longer required.

Maybe add documentation for what this is for here: https://github.com/microsoft/cppwinrt/tree/master/nuget

Is this PR still active?

@kennykerr yes it is. I still need to add docs for the property.

@kennykerr this is ready to merged.

Thanks!


[Documentation Bug]: Block Game

Describe the bug ✍
Currently, the README.md file of the Bock Buster project includes a link instead of screenshot, which could be improved for better user experience and presentation. It would be beneficial to replace this link with an actual screenshot of the game.
Screenshot of the bug📸

Provide step by step information reproduce the bug 📄

Steps to Reproduce the Bug
Clone Repository
Navigate to Repository Directory
Open README.md
Identifying the Issue
Locate Screenshot Link
Steps to Fix the Issue
Capture Game Screenshot
Add Screenshot to Repository
Update README.md
Finalizing Changes
Save and Commit

Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Bindusree1515 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @Bindusree1515 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Can't use custom theme on jodit-react

Jodit Version:  1.3.39
Browser:  Chrome
OS:  Windows
Is React App:  True
Code
// A *self-contained* demonstration of the problem follows...

Expected behavior:
Actual behavior:

@mahabubsaki  hi ,  have you successfully find any solution on how to customize the theme.


Updating Workflows

Adding an auto assign bot in workflows

Assigning myself @Rayman-Sodhi plz check the merged PR for changing labels if you want to change


feat: turn i18n.dir function calls in Donate_Modal into global CSS

As written in #973
Instead of calling the function every time the Modal opens, is it possible to call it with Global CSS Rules?
https://github.com/hasadna/open-bus-map-search/blob/ccbad0275beb58fc7e47a4c841ad922ce069d02a/src/pages/DonateModal/DonateModal.tsx#L31

@yontank  It was already global in theme.direction, I added the logic to update it when goggling the language so it will be consistent and have one source of truth. Is it ok if I assign this to myself?
@NoamGaash

hey, of course!
thanks so much for the help, glad to know more about how the application works.


Ruby: list the core API classes in README.md

Because Gapic/Ruby now generates 'doc' files, the generated
package document contains tons of classes and it's hard for
users to find where they can start.
This patch scans the files under lib/ and generates the list
of core classes. This logic assumes that Gapic/Ruby generates
the 'doc' files under a directory 'doc/'.
Upgrading to 0.6.3 considering I've uploaded some packages
to 0.6.2 in rubygems.org.
Fixes #32

[Current coverage][cc-pull] is 92.79%

Merging [#34][cc-pull] into [master][cc-base-branch] will decrease coverage by -1.03%

@@             master        #34   diff @@
==========================================
  Files             3          3
  Lines           551        569    +18
  Methods         108        114     +6
  Messages          0          0
  Branches         86         88     +2
==========================================
+ Hits            517        528    +11
- Misses           34         41     +7
  Partials          0          0

Powered by Codecov. Last updated by [d40c5b5...0864cac][cc-compare]
[cc-base-branch]: https://codecov.io/gh/googleapis/packman/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/googleapis/packman/compare/d40c5b53333338d21ee4f638b4a9011b8638e6ed...0864cacb055d1a7517f27b6fc360f90c1263bc56
[cc-pull]: https://codecov.io/gh/googleapis/packman/pull/34?src=pr

ping?


Add words starting with letter "U"

Add words starting with letter "U"

[ ] Ultimatum
[ ] Umbrage
[ ] Uncouth
[ ] Uncanny
[ ] Unassailable
[ ] Unctuous
[ ] Undulating
[ ] Unequivocal
[ ] Unerringly
[x] Unfeigned

Refer Contribution.md for more details on how to contribute.
Comment the word/words you're working on to avoid conflicts.
Add reference to this issue i.e Issue #452 in your pull request description.

Uncouth, Uncanny

Uncouth, Uncanny #455

Uncouth, Uncanny #456

working on Unassailable, Undulating!

working on Unequivoval


Updated README

Changed beta version from 1.3.2 to 1.3.8
Changed the potentially dangerous command of using 'brew upgrade' (which could affect more packages than just parity).

thanks!


Timeout

Hi,
it took me a while to figure out, how the timeout works. I thought, that timeout configuration in codeception yml files would work for this, but they don´t.
        - MailHog:
            url: '<IP_ADDRESS>'
            port: 80
            pageload_timeout: 10
            connection_timeout: 10
            request_timeout: 10
I had all the timeout settings set for around 10 seconds but fetchEmails() timeouted after 1000ms everytime.
So after some time i found it here:
src/MailHog.php  line 74
$this->mailhog = new \GuzzleHttp\Client(['base_uri' => $url, 'timeout' => 1.0]);
I just want to post this issue here if anyone would look for the same thing.
Thanks

Hi
Sorry for the inconvenience.
I am not currently setup to test anything with Mailhog, but could you try these changes locally and see if you can get the behavior you'd be expecting?
Mailhog.php
line 61
protected $config = array('url', 'port', 'guzzleRequestOptions', 'deleteEmailsAfterScenario', 'timeout');

line 74
$timeout = 1.0;
if(isset($this->config['timeout']))
    $timeout = $this->config['timeout'];
$this->mailhog = new \GuzzleHttp\Client(['base_uri' => $url, 'timeout' => $timeout]);

Thanks

Hi,
sorry for the delay, I had to do other stuff. But i tried what you suggested and it works like a charm.
I modified Mailhog.php and then tested various timeouts.
So now it works exactly as I expected, in my acceptance.suite.yml I have url, port and timeout options.
I am closing this issue.
Thank you


Are you planning to update Python's inferopt in the future?

As the title

Hi @luyifanlu, we are not aware of a Python version of InferOpt.jl, although there are some libraries that come close (see our paper). And we do not plan to work on one, but if you want to try feel free to reach out!


Add 3box read only support

https://explorer.livepeer.org/api/3box?account=0x4a43b1d7e6227c8b0512e413f406555647ff7bdb
just pull it from livepeers gateway. EZ

copy pasted ENS code. Make it prettier later


Possible integration with @testing-library/react-render-stream

Hi there,
a few weeks ago I released @testing-library/react-render-stream, which, among other things, tracks which components rerendered during a single React render.
Thing is - right now, users have to do that tracking by hand by executing a hook in their components.
I'm aware of the hacks that this package is using, and it was a long-term goal to do something similar there. But now this seems to be around :)
Sooner or later I'll hopefully find the time to integrate with react-scan, but I already wanted to bring it up here - I'm currently swamped with work, and if you want to entertain the idea of playing around and making a PR on our side, it would be very welcome :)

@phryneas package looks sick!
currently you can hook into lifecycle hooks, so if you know / have access to the functions itself, you can match the fiber in the onRender, and get the render data from there
import { setOptions } from 'react-scan';

setOptions({
  onCommitStart() {},
  onRender(fiber, render) {},
  onCommitFinish() {},
  onPaintStart(outline) {},
  onPaintFinish(outline) {},
});

console.log(getReport());


Ability to lowlight or omit a difference between undefined and omitted values in expectation failure diff

🚀 Feature Proposal
I would like for undefined properties of an object to be de-emphasized from the diff presented after an equality match failure.
Motivation
I have run into many properties being present, but set to undefined in the subject of an assertion, and do not wish to replicate them in the expected value.  The default equality testing mechanism does not care about a key which is missing on one object and set to undefined in another, the difference between a missing key and the undefined key is visually highlighted, making me need to sort through visual clutter to get to the actual differences.
Example
When executing this failing test:
expect({one: "two", three: "four", five: undefined}).toEqual({one: "two", three: "broken"});

The output in the console would lowlight the difference between the two objects regarding the key five being missing in one object and set to undefined explicitly in the other.  The lowlight would perhaps be similar to how the one key is grayed out, or perhaps the diff would even be omitted.
Pitch
I am uncertain that this needs to belong in the Jest core platform, simply because I'm not sure if the diff output is a result of the reporter or of some more intrinsic piece of Jest.  If I'm wrong about it belonging here, let me know so I can better contribute in the future!

I think that's a weakness in the toEqual matcher, and one of the reasons we introduced the toStrictEqual matcher.
That said, I agree it's inconsistent. @thymikee @rickhanlonii @pedrottimark thoughts?

@byronanderson do you think if we changed this people would create an issue like "Highlight difference between undefined and omitted values"?

@rickhanlonii I definitely think that is possible, seeing that there is a difference between the two:
const object = {foo: undefined}
"foo" in object // true
"bar" in object // false
object.hasOwnProperty("foo") // true
object.hasOwnProperty("bar") // false
Object.keys(object) // ["foo"]

My business just happened to frequently be adding these undefined values, which didn't matter since JSON.stringify would later omit the key.
Having thought it through with a bit more distance from the problem I was having, I'll revise my position to:
Since keys set to undefined behave differently (as illustrated in snippet above), if you don't want them to be highlighted, strip them manually!
Something like:
expect(recursivelyStripUndefinedKeys(actual)).toEqual(expected);

Or, more precisely for the case I had:
expect(actual).toBeJsonEquivalentTo(expected);
// expectation will pass if serializing `actual` with JSON.stringify and then deserializing it with JSON.parse will make it equal to `expected`

which, again, is in user land, so I will close this feature request.
Thanks for the feedback @rickhanlonii !

@byronanderson Yesterday and today, I invested time experimenting on this issue :)
Copying works for literal objects:

getObjectSubset(receivedObject, expectedObject) in toMatchObject
JSON.stringify and then JSON.parse as you mentioned

For some features like “asymmetric matchers” or class instances with getters it might not work.
Another solution is change relationship between jest-diff and pretty-format packages:

if toEqual fails, compute difference between received and expected props as data structure
use data structure to guide diff display of formatted props (this is the hard part)

If you are willing, I might ask some questions from time to time about possible improved differences.

Wow @byronanderson, great analysis, thanks for following up

Has anyone implemented something like toBeJsonEquivalentTo mentioned before that would omit undefineds from the diff?


xAxis position is different on the boxplot

Version
5.1.1
Reproduction link
https://jsfiddle.net/vfk75uc3/2/
Steps to reproduce
The position of the boxplot does not overlap with that of the outlier (scatter)
There are two series and each uses a different x value(category), Why using two spaces?
What is expected?
boxplot position to overlap with the outlier position
What is actually happening?
The position of the boxplot does not overlap with that of the outlier

I can't see anything unexpected in the demo. Can you provide an example shot to describe it?


Date-picker

Expected Behavior
Format:
begin=2019-01-24&end=2019-01-26

[x] new element in form builder
[x] ducumentation

System GA

component: form-builder v1.5.0
styles: indigo-layout v1.9.0

➤ Galymzhan Begimov commented:
If I use fb-date component like this:

It’s all works fine, but if I use it like it’s explained in docs:

it fails with an error: TypeError: Cannot read property 'addEventListener' of null

Looks like preset value for date range dont work:
<fb-date-range min="2019-05-09" max="2019-06-20" value-start="2019-05-15" value-end="2019-06-06"></fb-date-range>
Above limits possible range to select, but doesnt set start and end date on date pickers

After testing further, noticed an interesting moment:
<fb-date label="Pick a date" min="2019-05-09" max="2019-06-20"></fb-date>
<fb-date label="Pick a date" min="2019-05-09" max="2019-06-20" value="2019-05-10"></fb-date>
The first one works and the second one doesn't. Hope this helps.

<fb-date name="date" label="Pick a date" yearRange="1"></fb-date>
'yearRange' prop doesn't seem to do anything.

➤ Ilya Kitayev commented:
v1.5.2:

fix:  properly sets inital values (value-start and value-end props)
fix: docs examples rewritten for  usage (with name prop)


Update sharepoint-pnp-cmdlets.md

Fixing broken link to build details

Docs Build status updates of commit df957dd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/docs-conceptual/sharepoint-pnp/sharepoint-pnp-cmdlets.md
:bulb:Suggestion
View (sharepoint-ps)
Details

sharepoint/docs-conceptual/sharepoint-pnp/sharepoint-pnp-cmdlets.md

Line 2, Column 1: [Suggestion-audience-missing] Missing required attribute: 'audience'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit ccb5305:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/docs-conceptual/sharepoint-pnp/sharepoint-pnp-cmdlets.md
:bulb:Suggestion
View (sharepoint-ps)
Details

sharepoint/docs-conceptual/sharepoint-pnp/sharepoint-pnp-cmdlets.md

Line 2, Column 1: [Suggestion-audience-missing] Missing required attribute: 'audience'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@yogkumgit Please have a look at the proposed change at hand. It's just a broken link, nothing fancy or that needs feedback to our PnP team :)


Errors outside of tests don't cause the test run to fail

This seems to have been discussed before in previous issues, but we've ran into multiple problems at Shopify where something in our javascript bundle throw a SyntaxError or ReferenceError or whatever, which would then not make Teaspoon fail and instead cause our CI to silently succeed and us to miss it.
I propose that we make Teaspoon fail the test run if there's an error before Teaspoon.execute is ran, as that will make it non-disrupting when there's errors in asynchronous things, but still makes sure this doesn't silently let errors slip through.

previous issues; https://github.com/modeset/teaspoon/issues/445 https://github.com/modeset/teaspoon/issues/425

Yeah, I've been torn on this because it doesn't indicate a real failure directly. That being said, it's an easy fix with phantomjs, but may not be true elsewhere.
If you decide to look into this I tend to think we might need to do this at the controller level (suite_controller) and handle that exception by ending everything.

Jeremy Jackson

On May 5, 2016, at 9:13 AM, Bouke van der Bijl<EMAIL_ADDRESS>wrote:
This seems to have been discussed before in previous issues, but we've ran into multiple problems at Shopify where something in our javascript bundle throw a SyntaxError or ReferenceError or whatever, which would then not make Teaspoon fail and instead cause our CI to silently succeed and us to miss it.
I propose that we make Teaspoon fail the test run if there's an error before Teaspoon.execute is ran, as that will make it non-disrupting when there's errors in asynchronous things, but still makes sure this doesn't silently let errors slip through.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

fixed


Multiple MAX/AVG window functions are mixed in one SQL, and the MAX result is incorrect.

Steps to reproduce the behavior (Required)

CREATE duplicated key table with columns time_id, uuid and some metrics, like tbl_data_res_2080_15_starrocks

create table tbl_data_res_2080_15_starrocks (
    time_id datetime,res_ins_id bigint,r2080_i10005 double,r2080_i10006 double,r2080_i10007 double,r2080_i10008 double
)
DUPLICATE KEY(time_id, res_ins_id)
PARTITION BY RANGE(time_id) (
    START ("20231205") END ("20231207") EVERY (INTERVAL 1 HOUR)
)
DISTRIBUTED BY HASH(res_ins_id)
PROPERTIES(
    "dynamic_partition.enable" = "true",
    "dynamic_partition.time_unit" = "HOUR",
    "dynamic_partition.start" = "-168",
    "dynamic_partition.end" = "12",
    "dynamic_partition.prefix" = "p",
    "dynamic_partition.history_partition_num" = "0"
);

INSERT INTO table with some metrics with time_id and uuid

row_data.csv

select time_id, res_ins_id as longID,
        r2080_i10005,MAX(r2080_i10005) OVER (partition by res_ins_id order by time_id rows between 3 PRECEDING and current row) as OutboundPeakTrafficUtilization,
        r2080_i10006,AVG(r2080_i10006) OVER (partition by res_ins_id order by time_id rows between 3 PRECEDING and current row) as OutboundBandwidthUtilization,
        r2080_i10007,MAX(r2080_i10007) OVER (partition by res_ins_id order by time_id rows between 3 PRECEDING and current row) as InboundPeakTrafficUtilization,
        r2080_i10008,AVG(r2080_i10008) OVER (partition by res_ins_id order by time_id rows between 3 PRECEDING and current row) as InboundBandwidthUtilization
from tbl_data_res_2080_15_starrocks
where from_unixtime(time_id/1000) > '2023-12-13 12:00:00' and res_ins_id = '50086357'
order by res_ins_id,time_id;

Expected behavior (Required)
get the correct window aggregation result for each metrics over past 4 time_id
Real behavior (Required)
only the AVG aggregation result is correct, the MAX aggregation result is incorrect, which is only the first value.
like "OutboundPeakTrafficUtilization" is always 41.84,  and "InboundPeakTrafficUtilization"  is always 73.49
+---------------------+----------+--------------+--------------------------------+--------------+------------------------------+--------------+-------------------------------+--------------+-----------------------------+
| time_id             | longID   | r2080_i10005 | OutboundPeakTrafficUtilization | r2080_i10006 | OutboundBandwidthUtilization | r2080_i10007 | InboundPeakTrafficUtilization | r2080_i10008 | InboundBandwidthUtilization |
+---------------------+----------+--------------+--------------------------------+--------------+------------------------------+--------------+-------------------------------+--------------+-----------------------------+
| 2023-12-06 17:00:00 | 50086357 |        41.84 |                          41.84 |        33.62 |                        33.62 |        73.49 |                         73.49 |        40.76 |                       40.76 |
| 2023-12-06 17:15:00 | 50086357 |        28.33 |                          41.84 |        71.49 |            52.55499999999999 |        80.47 |                         73.49 |        88.71 |                      64.735 |
| 2023-12-06 17:30:00 | 50086357 |         24.6 |                          41.84 |        48.39 |           51.166666666666664 |        23.89 |                         73.49 |         3.62 |           44.36333333333334 |
| 2023-12-06 17:45:00 | 50086357 |        37.71 |                          41.84 |        91.71 |           61.302499999999995 |        58.25 |                         73.49 |        39.67 |                       43.19 |
| 2023-12-06 18:00:00 | 50086357 |        94.94 |                          41.84 |        73.91 |                       71.375 |        43.18 |                         73.49 |         0.07 |                     33.0175 |
| 2023-12-06 18:15:00 | 50086357 |        43.31 |                          41.84 |        19.22 |                      58.3075 |          3.1 |                         73.49 |        71.51 |                     28.7175 |
| 2023-12-06 18:30:00 | 50086357 |        89.48 |                          41.84 |        32.29 |            54.28249999999999 |        37.73 |                         73.49 |        53.39 |                       41.16 |
| 2023-12-06 18:45:00 | 50086357 |         6.29 |                          41.84 |        40.76 |           41.544999999999995 |        23.53 |                         73.49 |        81.96 |          51.732499999999995 |
| 2023-12-06 19:00:00 | 50086357 |        43.18 |                          41.84 |        32.03 |           31.074999999999996 |        30.48 |                         73.49 |        22.34 |                        57.3 |
| 2023-12-06 19:15:00 | 50086357 |        34.09 |                          41.84 |        78.35 |           45.857499999999995 |         6.39 |                         73.49 |        53.19 |                       52.72 |
| 2023-12-06 19:30:00 | 50086357 |        67.57 |                          41.84 |        88.36 |                       59.875 |        87.76 |                         73.49 |        76.93 |          58.605000000000004 |
| 2023-12-06 19:45:00 | 50086357 |        68.73 |                          41.84 |        31.49 |           57.557500000000005 |         3.75 |                         73.49 |        96.81 |           62.31750000000001 |
| 2023-12-06 20:00:00 | 50086357 |        20.35 |                          41.84 |        22.53 |           55.182500000000005 |        28.32 |                         73.49 |           51 |           69.48250000000002 |
| 2023-12-06 20:15:00 | 50086357 |        29.51 |                          41.84 |           14 |           39.095000000000006 |        56.85 |                         73.49 |         8.43 |           58.29250000000002 |
| 2023-12-06 20:30:00 | 50086357 |        13.99 |                          41.84 |        30.55 |           24.642500000000005 |         9.65 |                         73.49 |        31.98 |          47.055000000000014 |
| 2023-12-06 20:45:00 | 50086357 |        77.88 |                          41.84 |        46.34 |           28.355000000000008 |         2.65 |                         73.49 |        96.62 |          47.007500000000014 |
| 2023-12-06 21:00:00 | 50086357 |        70.09 |                          41.84 |        51.64 |            35.63250000000001 |        86.52 |                         73.49 |        92.36 |           57.34750000000001 |
| 2023-12-06 21:15:00 | 50086357 |        47.68 |                          41.84 |        83.87 |            53.10000000000001 |         96.1 |                         73.49 |        54.39 |                     68.8375 |
| 2023-12-06 21:30:00 | 50086357 |         97.3 |                          41.84 |         46.7 |                      57.1375 |         6.29 |                         73.49 |        35.54 |                     69.7275 |
| 2023-12-06 21:45:00 | 50086357 |         27.4 |                          41.84 |        35.07 |                        54.32 |        56.51 |                         73.49 |           32 |          53.572500000000005 |
| 2023-12-06 22:00:00 | 50086357 |        11.29 |                          41.84 |         46.7 |           53.084999999999994 |        30.84 |                         73.49 |        94.79 |           54.18000000000001 |
| 2023-12-06 22:15:00 | 50086357 |        95.17 |                          41.84 |        30.92 |                      39.8475 |         3.65 |                         73.49 |         41.7 |           51.00750000000001 |
| 2023-12-06 22:30:00 | 50086357 |        16.15 |                          41.84 |        83.15 |           48.959999999999994 |        36.99 |                         73.49 |        37.67 |          51.540000000000006 |
| 2023-12-06 22:45:00 | 50086357 |        52.84 |                          41.84 |        99.61 |                       65.095 |        94.55 |                         73.49 |         8.88 |          45.760000000000005 |
| 2023-12-06 23:00:00 | 50086357 |         8.09 |                          41.84 |        54.55 |                      67.0575 |        96.25 |                         73.49 |        86.43 |                       43.67 |
| 2023-12-06 23:15:00 | 50086357 |        67.59 |                          41.84 |        28.97 |                        66.57 |        43.19 |                         73.49 |        35.93 |          42.227500000000006 |
| 2023-12-06 23:30:00 | 50086357 |        60.79 |                          41.84 |        68.72 |            62.96249999999999 |        64.92 |                         73.49 |        77.72 |                       52.24 |
| 2023-12-06 23:45:00 | 50086357 |        69.72 |                          41.84 |        51.83 |           51.017499999999984 |        20.15 |                         73.49 |         88.2 |           72.07000000000001 |
+---------------------+----------+--------------+--------------------------------+--------------+------------------------------+--------------+-------------------------------+--------------+-----------------------------+
StarRocks version (Required)

3.1.2-4f3a2ee

This problem has been solved by https://github.com/StarRocks/starrocks/pull/34312
Fixed version: >=3.1.5


Does Bitcoin-XT support a solo mining option?

Dears,
Just I wonder if Bitcoin-XT supoort a solo mining option. because Yesterday I was installed it on my computer in order to test and I found when after Installed it cound not possible connect a local wallet with cgminer and mfgminer for solomining configuration on bitcoin.conf file.

@jeong760 Can you provide any details / logs to document what you are seeing?

No answer, closing.


select named query option not showing up

using the example code here I am no longer seeing a list show up when I have multiple queries defined in a single tab and I click the big "play" button
whatever query is the first in the document is what gets executed 😞
I'm fairly confident this worked in at least 1.7.13 but doesn't appear to work anymore in 1.7.28 (which is the latest on NPM but I can't tell if that is the expected latest version or not)
example "query" document (contains 2 named queries):
query a {
  foo
}

query b {
  bar
}

I want to be able to click the Play button again and get a list containing "a" and "b" (or whatever my named operations are) and then click an operation by name so that I can have similar operations grouped together in a query and execute whichever I need with a single extra click
thank you

I can confirm having the same issue on 1.7.27. The list of queries on play button appears only after making some edit to the queries on the left. Before editing anything it executes the first query only.


Added verde import

Hey guys,
Thanks for the tuto, when running the notebook on binder I happened to notice verde wasn't imported, understandably after the amount of work done. So just a small patch so the notebook runs seamlessly.

Thanks for this, one of those Jupyter Notebook gotchas!
Leo raised the same issue in #5 but I decided to revert to sticking with NumPy/SciPy for most of the tutorial, since the point is partly to show people how to use those core tools.


AndGiven step repeated as AndThen step in reflective Examples

I've seen this issue a few times recently when working with Examples in the reflective API. I'm getting the AndGiven step repeated as an AndThen step in the reports (And <activity status> status).
Given a Step with a dependent step
And <activity status> status
When the Parent Step has completed
Then child Step should <shouldStart>
And <activity status> status

    public class ChangeActivityStepStatusWithDependentStep : ScenarioFor<ActivityActor>
    {
        public ChangeActivityStepStatusWithDependentStep()
        {
            this.Examples = new ExampleTable("Activity Status", "Should Start")
            {
                { ActivityStatus.Queued, true },
                { ActivityStatus.InProgress, true }
            };
        }
        public void Given_a_Step_with_a_dependent_step() { }
       // [AndGiven("And <activityStatus> status")]
        public void AndGiven__activityStatus__status(ActivityStatus activityStatus) { }
        public async void When_the_Parent_Step_has_completed() { }
        public void Then_child_Step_should__shouldStart__(bool shouldStart) { }
        }
    }

A workaround is to add the [AndGiven] attribute, which solves the problem and prevents the redundant AndThen from displaying.
Any ideas what might be causing this?

Sorry for not responding to this sooner. had a look at the fix. Looks good to me.


video, iframe not supported

Is video or iframe supported by the library?
For some reason i'm not able to load any video
CodeSandbox
import React from "react";
import AwesomeSlider from "react-awesome-slider";
import "react-awesome-slider/dist/styles.css";

export default function App() {
  return (
    <AwesomeSlider>
      <video>
        <source
          src={
            "https:....mp4"
          }
          type="video/mp4"
        />
      </video>
      <div data-src={"https://placekitten.com/200/300"} />
    </AwesomeSlider>
  );
}

Hey @muscaiu. Just wrap the <video> on a <div> container.
Check it out on this codesandbox example.


Update toolbar for Cost management Sources

The toolbar for Cost management Sources page is out of sync with the PatternFly design used for the new Cost Model page.
One toolbar shows a filter icon while the other does not. Cost management Sources has a secondary "Add source" button, while Cost Models uses a primary button.

After speaking with @nlcwong, we would like to update the toolbar for the Cost management Sources page to be in sync with the Cost Model page.
The design is here:
https://www.patternfly.org/v4/design-guidelines/usage-and-behavior/filters#attribute-value-textbox-filters

dup of https://github.com/project-koku/koku-ui/issues/946