fix: remove file storage block from default values

Overview

Helm merges the default chart values under vault.config.storage with the supplied storage value when generating the config.json for vault. This causes the vault container to error out due to the multiple storage blocks.
We can do without the default chart value for config.storage and instead require the user to supply the value
Example of supplied values with a storage block included:
vault:
  vault:
    config:
      storage:
        dynamodb:
          ha_enabled: true
          region: us-east-1
          table: "vault-backend"

Resulting config.json
{
  ...
  "storage": {
    "dynamodb": {
      "ha_enabled": true,
      "region": "us-east-1",
      "table": "vault-backend"
    }
  },
 ...
}

Fixes https://github.com/bank-vaults/vault-helm-chart/issues/180
Notes for reviewer

Hi @MuriukiPM, thanks for raising this. Would you mind fixing the E2E tests after which we can merge. Note that it's important to fix this in a backwards-compatible way for other chart users.

Context:
PR that removed the workaround: https://github.com/bank-vaults/vault-helm-chart/pull/103
Issue before: https://github.com/bank-vaults/vault-helm-chart/issues/25
Workaround PR: https://github.com/banzaicloud/banzai-charts/pull/215
Original issue: https://github.com/helm/helm/pull/3912

Context: PR that removed the workaround: #103 Issue before: #25 Workaround PR: banzaicloud/banzai-charts#215 Original issue: helm/helm#3912

@csatib02 please correct me if I am wrong;
The way I understand it, the workaround was reverted when https://github.com/helm/helm/pull/3912 was merged. The manual test that was done was setting vault.vault.config.storage to null in the supplied value file and checking that the generated config.json had storage:null.
However, I cannot reproduce this locally. Setting storage to null or {} results in the a config json that has "storage": {     "file": {       "path": "/vault/file"     }   }, from the charts default value file. I think helm still merges the contents of the supplied vault.vault.config map with those of the charts config map but doesn't overwrite when the supplied vault.vault.config is set to null.

@MuriukiPM
I revisited this, and I can reproduce my manual tests.
Are you using the latest version of the Helm-Chart?
Could you provide us with some screenshots, or yaml's, so we can further investigate.

@csatib02 I have created a public repo with the set up I am testing this with -> https://github.com/MuriukiPM/helm-charts-playground/blob/vault/charts/vault/README.md. I am using chart version 1.20.4 which should be latest. Also using helm version 3.15.3.
Use helm template vault ./ -n vault -f ./values.yaml >  vault.yaml to generate the manifests then inspect and base64 decode the config.json value in the vault-config secret from the vault.yaml file that is generated.
You will see that if the vault.vault.config.storage or vault.vault.config.storage.file are set to null, the generated config.json still contains the file storage block.

Could you please try changing the last secret as part of this PR to this:
apiVersion: v1
kind: Secret
metadata:
  name: "{{ template "vault.fullname" . }}-config"
  namespace: {{ .Release.Namespace }}
  labels:
    helm.sh/chart: {{ template "vault.chart" . }}
    app.kubernetes.io/name: "{{ template "vault.name" . }}"
    app.kubernetes.io/instance: {{ .Release.Name | quote }}
    app.kubernetes.io/managed-by: {{ .Release.Service | quote }}
data:
  config.json:
    {{- if .Values.vault.config.storage }}
    {{ .Values.vault.config | toPrettyJson | b64enc }}
    {{ end }}
  vault-config.yml:
    {{ .Values.vault.externalConfig | toYaml | b64enc }}

You can find it at vault/templates/secret.yaml.

@csatib02  done in https://github.com/bank-vaults/vault-helm-chart/pull/185/commits/35508de58689ac86b15a3d7843cc5ff69e368dc2

Hi, this PR is still relevant, we're having the same problem on our Vault setup (Google Cloud Storage)

Same issue using mysql storage

@MuriukiPM
If you place back the workaround we can merge this, good enough solution for now.

@csatib02 ok, you are referring to this workaround -> https://github.com/banzaicloud/banzai-charts/pull/215 ?

secret.yaml >>
  config.json: |
    {{- if .Values.vault.config.storage }}
    {{ .Values.vault.config | toJson }}
    {{ else }}
    {{ (merge .Values.vault.config .Values.vault.config.defaultStorage) | toJson }}
    {{ end -}}

values.yaml >>
NOTE: please have defaultStorag at .Values.vault.config.defaultStorage
  storage: {}
  defaultStorage:
    storage:
      file:
        path: "/vault/file"

@csatib02 added in https://github.com/bank-vaults/vault-helm-chart/pull/185/commits/a0367801614d4a726587ee2cfa6b5d1c7da45760
I also included | toPrettyJson | b64enc from the change before

@MuriukiPM
May I ask you to open a ticket regarding placing back the workaround?

@csatib02 I see you have closed https://github.com/bank-vaults/vault-helm-chart/issues/180, presumably this was the ticket you were referring?

Maybe a new ticket just about revisiting or fixing the workaround.


headscale: 0.14.0 -> 0.15.0

Description of changes
Upgrades headscale and uses the same Go version as the upstream.
Closes #165076
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 165130 run on x86_64-linux 1

1 package built:

headscale


Relative $PROJECT path no longer working

Hi,
I'm using a relative $PROJECT path to point to my virtual environments flake8 which was working fine. Suddenly it has stopped working (maybe from an update?) and it's throwing 'Failed to spawn' errors.
The path it spits out looks correct to me so I'm not sure why it's breaking. '/Users/jamesstidard/Development/MyProject/Server/venv/bin/flake8'. I've also checked this directory and flake8 is present.
Please let me know if there are any more details I can give to help
Thanks,
James

Is there a permissions issue possibly? What is the full error you are seeing?

I've attached a copy of the console .log.
I get a couple of red Atom error bubbles as well:

Failed to spawn command /Users/jamesstidard/Development/MyProject/Server/venv/bin/flake8. Make sure /Users/jamesstidard/Development/MyProject/Server/venv/bin/flake8 is installed and on your PATH

Error: spawn /Users/jamesstidard/Development/MyProject/Server/venv/bin/flake8 ENOENT
Error: spawn /Users/jamesstidard/Development/MyProject/Server/venv/bin/flake8 ENOENT
at exports._errnoException (util.js:837:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:178:32)
at onErrorNT (internal/child_process.js:344:16)
at doNTCallback2 (node.js:441:9)
at process._tickCallback (node.js:355:17)

P.S. I don't prefix my venv with a dot.

What do you get from running the following?
cd /Users/jamesstidard/Development/MyProject/Server/venv/bin
ls -l

The error is claiming that the file doesn't exist, but you say that it is, so something funky is going on.

Funky indeed. Here's the dump:

total 320
drwxr-xr-x  15 jamesstidard  staff    510 27 Feb 21:09 pycache
-rw-r--r--   1 jamesstidard  staff   2275 27 Feb 21:09 activate
-rw-r--r--   1 jamesstidard  staff   1301 27 Feb 21:09 activate.csh
-rw-r--r--   1 jamesstidard  staff   2514 27 Feb 21:09 activate.fish
-rw-r--r--   1 jamesstidard  staff   1137 27 Feb 21:09 activate_this.py
-rwxr-xr-x   1 jamesstidard  staff    619 27 Feb 21:09 createfontdatachunk.py
-rwxr-xr-x   1 jamesstidard  staff    268 27 Feb 21:09 dotenv
-rwxr-xr-x   1 jamesstidard  staff    284 27 Feb 21:53 easy_install
-rwxr-xr-x   1 jamesstidard  staff    284 27 Feb 21:53 easy_install-3.5
-rwxr-xr-x   1 jamesstidard  staff   1569 27 Feb 21:09 enhancer.py
-rwxr-xr-x   1 jamesstidard  staff   2500 27 Feb 21:09 explode.py
-rwxr-xr-x   1 jamesstidard  staff    275 27 Feb 21:09 flake8
-rwxr-xr-x   1 jamesstidard  staff    703 27 Feb 21:09 gifmaker.py
-rwxr-xr-x   1 jamesstidard  staff   2169 27 Feb 21:09 painter.py
-rwxr-xr-x   1 jamesstidard  staff    270 27 Feb 21:09 pep257
-rwxr-xr-x   1 jamesstidard  staff    270 27 Feb 21:09 pep8
-rwxr-xr-x   1 jamesstidard  staff   2420 27 Feb 21:09 pilconvert.py
-rwxr-xr-x   1 jamesstidard  staff  15636 27 Feb 21:09 pildriver.py
-rwxr-xr-x   1 jamesstidard  staff   2728 27 Feb 21:09 pilfile.py
-rwxr-xr-x   1 jamesstidard  staff   1089 27 Feb 21:09 pilfont.py
-rwxr-xr-x   1 jamesstidard  staff   2599 27 Feb 21:09 pilprint.py
-rwxr-xr-x   1 jamesstidard  staff    267 27 Feb 21:09 pip
-rwxr-xr-x   1 jamesstidard  staff    267 27 Feb 21:09 pip3
-rwxr-xr-x   1 jamesstidard  staff    267 27 Feb 21:09 pip3.5
-rwxr-xr-x   1 jamesstidard  staff   2235 27 Feb 21:09 player.py
-rwxr-xr-x   1 jamesstidard  staff    276 27 Feb 21:09 pyflakes
lrwxr-xr-x   1 jamesstidard  staff      9 27 Feb 21:08 python -> python3.5
lrwxr-xr-x   1 jamesstidard  staff      9 27 Feb 21:08 python3 -> python3.5
-rwxrwxr-x   1 jamesstidard  staff  25384 27 Feb 21:08 python3.5
-rwxr-xr-x   1 jamesstidard  staff   1856 27 Feb 21:09 thresholder.py
-rwxr-xr-x   1 jamesstidard  staff   1029 27 Feb 21:09 viewer.py
-rwxr-xr-x   1 jamesstidard  staff    263 27 Feb 21:53 wheel

It looks like a conflict with the MagicPython package. When I disable MagicPython I no longer get the errors.

What in the world...? language-python for sure shouldn't be affecting this (other than marking files as Python).

Just updated to 1.13.0 and the errors are gone. Don't know if they have just been silenced or it's working now.

v1.13.0 does silence a potential error, but not one that would be related to this. In any case I'm willing to chalk it up to gremlins and close this if you aren't seeing this any more.

Sorry false report. I wrote $PROJECTS instead of $PROJECT so it was using my fallback python instead

Solved. I had moved my virtual environment so it's $VIRTUAL_ENV was still pointing to it's old location. I don't know if that's in scope of your project to handle.
Thanks for being my rubber duck and your quick responses. You can have your weekend back now :)

Glad you got it figured out :wink:


bin (Windows)

please add \bin\ folder with executables (Windows)

Added a release with binaries: https://github.com/dmsc/zx02/releases/tag/v1
Have Fun!


[EN] Feedback for: /web/fundamentals/getting-started/your-first-progressive-web-app/step-02?hl=en

There are missing instructions to get from the index.html listed here to the index.html of the "Try It" link.  Also, this page suggests using the app.js resource from the step-03 folder, but the "Try It" button links to step-04.

This will be updated in the new DevSite launch


Create a new endpoint for contact information of an organisation in SblBridge

Description
The official contact information for an organisation is currently maintained and kept in Altinn 2. To access the data from Altinn 3 we need to create a new lookup endpoint in SblBridge.
The endpoint needs to use data from Register. Specifically the KoFuVi services. It should be possible to retrieve the information for multiple organisations at the time.
Tasks

[x] Create a new consumer for unit contact information
[x] Create a new controller for unit contact information
[x] Create an input model that can hold lookup parameters like the organisation numbers
[x] Create a model for unit profile that can hold official contact information
[x] Create a new endpoint for lookup of official contact information
[ ] Optional: Create a few Bruno tests of the endpoint for manual testing

General tasks

[x] Add / modify unit tests
[x] QA
[x] Regression test
[x] Manual test

Testing
POST  /register/api/organizations/contactpoints
{
"organisationNumbers":["123456", "123456"]
}

Acceptance criteria

[ ] All tasks above have been completed
[ ] Endpoint returns correct contact information for the given organisations

Tested in at22. Looks like there is a bug in mapping. Instead of returning the full email address it's only returning the username part of the address.
{
    "contactPointsList": [
        {
            "organisationNumber": "312508729",
            "emailList": [
                "terje.holene"
            ],
            "mobileNumberList": []
        }
    ]
}

Tested ok


How to get access key and access secret key

Hey @ortmann64 can you please give a little hint how to get those keys?
Thank you :)

Hey @bahuma20,
thank you for using this package. Please refer to the NFON support for getting access to their API.
https://www.nfon.com/en/request-information


Checkpoints using base method and LLaVA dataset

Thank you for your great work!
I'm planning to use the checkpoints trained with the base method with the LLaVA dataset.
Is it possible to release the checkpoints in public?
Plus, is it possible for you to release the training scripts?
Thank you in advance!

Thank you for your great work! I'm planning to use the checkpoints trained with the base method with the LLaVA dataset. Is it possible to release the checkpoints in public? Plus, is it possible for you to release the training scripts?
Thank you in advance!

Training scripts will be released this weekend. As for the checkpoints, we are still figuring out the best way to release them all(since there are 12 of them).


Add GNU cpio

I added new package: GNU Cpio.

Check appveyor fail

@mati865 fixed the build error.

replaced hardcoded version by pkgver and squashed all three commits.


Check Functionality for Mid-Project Release

User story

As a user
I want a software
So that has no severe bugs and fulfills its core functionality

Acceptance criteria

[ ] Test usability of frontend
[ ] Test completeness and correctness of backend API
[ ] Test integration of frontend and backend
[ ] POs should check the UI for bugs from the perspective of an enduser

Definition of done (DoD)

Feature is done when the acceptance criteria are fullfiled
Feature is done when there are test where it is necessary and they pass
Feature is done when the linter passes
Feature is done when it is merged onto our main branch (after the code has been reviewed by at least one other person)
Feature is done when the code has been documentend or commented properly

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

Only high level looking (for errors)


table missing style, css

I am learning react, new bee ,  trying bootstrap table, table  renders, but without any style  , I am missing something, my table class src below , I  included css using   [import 'react-bootstrap-table/dist/react-bootstrap-table-all.min.css']   not sure if this is write?,   this project is in  github,  project link
import React from 'react';
import { BootstrapTable, TableHeaderColumn } from 'react-bootstrap-table';
import 'react-bootstrap-table/dist/react-bootstrap-table-all.min.css';

const products = [];

function addProducts(quantity) {
 const startId = products.length;
 for (let i = 0; i < quantity; i++) {
   const id = startId + i;
   products.push({
     id: id,
     name: 'Item name ' + id,
     price: 2100 + i
   });
 }
}

addProducts(70);

export default class DefaultPaginationTable extends React.Component {
 constructor(props) {
   super(props);
 }
 renderShowsTotal(start, to, total) {
   return (

       From { start } to { to }, totals is { total }  (its a customize text)

   );
}
 render() {

   	const options = {
   		 page: 1,
   		 sizePerPageList: [ {
   	        text: '5', value: 5
   	      }, {
   	        text: '10', value: 10
   	      }, {
   	        text: '20', value: 20
   	      } ]
   	      ,sizePerPage: 5,  // which size per page you want to locate as default
   	      pageStartIndex: 0, // where to start counting the pages
   	      paginationSize: 10,  // the pagination bar size.
   	      prePage: 'Prev', // Previous page button text
   	      nextPage: 'Next', // Next page button text
   	      firstPage: 'First', // First page button text
   	      lastPage: 'Last', // Last page button text
   	      paginationShowsTotal: this.renderShowsTotal

   	};
   return (

       <BootstrapTable data={ products } pagination={ true } options={options} >
         <TableHeaderColumn dataField='id' isKey={ true }>Product ID</TableHeaderColumn>
         <TableHeaderColumn dataField='name'>Product Name</TableHeaderColumn>
         <TableHeaderColumn dataField='price'>Product Price</TableHeaderColumn>
     </BootstrapTable>

   );
 }
}`

image of rendered table

applying jquery and bootstrap  script and link tag resolved the issue.
    <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.2/css/bootstrap.min.css">

@fachhoch : If the issue is resolved, feel free to close it by yourself please.

@fachhoch, In near future, bootstrap.min.js and jQuery this both dependency will be removed on v3.0.0. Anyway, you can check v3.0.0-beta.2.

@AllenFang : I am using v3.5.1  are the dependencies removed? I was unable to make it work without the dependencies

Remember to import the css of react-bootstrap-table
No need bootstrap.js anymore.

This is the react component that I am trying to use react-bootstrap-table
`import React from 'react';
import {BootstrapTable, TableHeaderColumn} from 'react-bootstrap-table';
var products = [{
id: 1,
name: "Product1",
price: 120
}, {
id: 2,
name: "Product2",
price: 80
},{
id: 1,
name: "Product1",
price: 120
}, {
id: 2,
name: "Product2",
price: 80
}];
class AccessList extends React.Component{
constructor(props) {
super(props);
}
render() {
return (

<BootstrapTable data={ products } striped hover condensed>
Product ID
Product Name
Product Price

);
}
}
module.exports = AccessList;`
This is the main component that serves as a container for all my components, where I imported the CSS
`import React from 'react';
import ReactDOM from 'react-dom';
import './css/style.css';
import './css/style.css';
import '../node_modules/react-bootstrap-table/dist/react-bootstrap-table.min.css';
import App from './components/App'
import  'adp-css-framework';
ReactDOM.render(,document.getElementById('root'));`
This does not work. I work only if I add bootstrap.min.css & jquery in my HTML as shown below
`

<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.2/css/bootstrap.min.css">

<meta name='viewport' content='width=device-width, initial-scale=1.0'>

`
Not sure if I am doing something wrong as I am still quite a rookie at REACT

I'm not sure what's going on in your repo, could I have a demo repo to reproduce this one? Please give me a repo for me, I will help you to check, thanks

Hi,
I also face same problem like @maulikdesai21
I do import as below:
import React from 'react';
import 'react-bootstrap-table/dist/react-bootstrap-table-all.min.css'
import {BootstrapTable, TableHeaderColumn} from 'react-bootstrap-table'
and the result is without css,
Please assist, thanks!

I am doing something very similar with electron+react, and there not even the import statement works out.

Is there a fix for this yet? My import statement is not working either.

hey guys, I dont think there's any issue there, please give me a repo and to show me the problem. and please write a good readme for me to setup your code

@AllenFang I think below is an easy illustration of the problem that I and some other people faced.
I found these two jsFiddles of react-bootstrap-table on Google for reference. None of their stylings work.
https://jsfiddle.net/omerts/5asms7j7/
https://jsfiddle.net/03h4dvav/
However, if you add https://maxcdn.bootstrapcdn.com/bootstrap/3.3.2/css/bootstrap.min.css to the External Resources tab on the left, both of the examples now work.
These two examples seem to indicate that, people are not aware they need to import the bootstrap css file.

I see, I'll write some indication to mention this.. @shal-xu thank you

@AllenFang : I am facing the same issue. I have imported the table css. as below but the styling is not working for my pagination table.
import 'react-bootstrap-table/dist/react-bootstrap-table-all.min.css'
import {BootstrapTable, TableHeaderColumn} from 'react-bootstrap-table'
however Adding the CDN (as show below) to my index.html makes the styling applied to the table but screwing up my all other stylings. Is there a fix so that i don't have to add this bootstrap link and still it works with just above two imports . Please help me in this regard.
""

@AllenFang

however Adding the CDN (as show below) to my index.html makes the styling applied to the table but screwing up my all other stylings. Is there a fix so that i don't have to add this bootstrap link and still it works with just above two imports . Please help me in this regard.

Any solution for this ?
the bootstrap.min.css destroy the old page design when import it into he index.html


home-manager and plasma5

I'm trying to run home-manager together with plasma5, but can't figure out what I should specify in xsession.windowManager option. I've tried ${pkgs.kwin}/bin/kwin_x11, but it didn't work.

Hmm, I'm not familiar with kwin but in principle your configuration looks ok here. Do you get any error message or similar when starting your X session? Anything suspicious in the output of journalctl --user -b after attempting it?
What is your complete settings in the system services.xserver and the home manager xsession sections?

This error appears in log after I login in sddm:
/home/user/.xsession line 19: /nix/store/<hash>-kwin-5.10.3/bin/kwin_x11: No such file or directory
when I execute ls -la /run/current-system/sw/bin/kwin_x11 I get:
/run/current-system/sw/bin/kwin_x11 -> /nix/store/<hash>-kwin-5.10.3-bin/bin/kwin_x11
Seems like I should specify another package instead of ${pkgs.kwin}, but not sure what.

Ah, you could try ${lib.getBin pkgs.kwin}/bin/kwin_x11…

 The log output for journalctl --user -b looks like this: https://pastebin.com/N9senvFb

Here is the settings for xserver service from my /etc/nixos/configuration.nix:
xserver = {
    enable = true;
    layout = "gb";
    libinput = {
      enable = true;
      clickMethod = "clickfinger";
      naturalScrolling = true;
      tapping = false;
    };
    displayManager.sddm.enable = true;
    desktopManager.plasma5.enable = true;
    videoDrivers = [ "intel" ];
};

Ok, so the problem may be that you are trying to run a whole desktop manager. The way Home Manager does X sessions at the moment doesn't work very well together with that (basically it overrides the whole start up the desktop manager thing). You could attempt to do something like
xsession.windowManager = pkgs.plasma5.startkde;

but if that doesn't work I'm afraid that the xsession option won't work for you. I hope to improve this situation in the future.

That actually helped :) KDE launched and graphical services seem also work as it should.
Thank you for your help and for this project in general :)

Ah, that is very nice! Thanks for reporting this issue and I'm glad to learn it works.


Add sparse vectors to migration tests

https://github.com/qdrant/qdrant-client/blob/efb876fe3915dc5e2855f60a5617e940c84591e5/tests/test_migrate.py#L67

I've reviewed the code and believe I can enhance the migration test by adding sparse vectors and already started working on it. If you have any thoughts or suggestions lemme know

I encountered following issue while adding sparse_vector to the migration tests.
I made some adjustments to the migration tests to included sparse vectors in the points in the below image.
Changes ai did:
![Screenshot 2](https://github.com/qdrant/qdrant-client/assets/141582345/b6b0f1c2- [ ] -a806-46ad-9985-ef63bc2b2324.png)
After running the tests locally, I encountered 3 failures
Failures of the test:

I suspect there might be an issue related to the sparse vectors or project setup.
Suggestions or guidance to resolve this issue are most welcome

#700


"Not" operator does not match

I may be missing something, but from what I can see, the Not operator does not isn't matching anything:
Image of problem
Other glob implementations seem to work

Negated patterns are not supported, but you can use ignore for this.
// v8 and before
glob('**', { ignore: 'node_modules/**' }, (er, matches) => { ... })

// v9 and above
matches = await glob('**', { ignore: 'node_modules/**' })


Fix/floating point errors

To test:
Review new test case
npm run dev
npm test
Represent Bin and Item dimensions as rounded integers after multiplying by a factor of 10.
Before this fix, item collision detect fell prey to situations like:
Math.max( .0025, .0075 ) - Math.min( .0025, .0075 )
0.004999999999999999
This caused false positive collisions in rectIntersect().

I don't like the idea of factor Integer everywhere to fix this specific error.


[BUG] Recommendation banner overflow out of container

Description
I am not sure whether this is intended or not, but I am raising an issue as this seems out of the flow with other content.
The recommendation banner here in the screenshot is of "Pradumna Saraf's", should be within the container which is set for all the other elements in the home page.
Screenshots

Do you want to work on this issue?
Yes
Additional information
If this is unintended I would like to work on this, otherwise we can close this issue.

Thank you, but this was an intentional design choice so I will close.


Etherpad Whiteboard is broken

Console is showing this error:
Refused to display 'https://pad.railsschool.org/p/rails-school-lesson-293?userName=Brad' in a frame because it set 'X-Frame-Options' to 'SAMEORIGIN'.
ping:1 Given URL is not allowed by the Application configuration: One or more of the given URLs is not allowed by the App's settings.  It must match the Website URL or Canvas URL, or the domain must be a subdomain of one of the App's domains.

This is probably because our etherpad host is down, not an actual problem with this site.

It should be fixed now. For some reason, the etherpad-lite upstart script was failing due to a missing or outdated version of curl.


Adds check if account is claimed before moving OU

Adds a check to switch which OU the account should be in based on the claimed state of the account.
Work towards completing OSD-9910

/hold
I still need to test this locally

Codecov Report

Merging #724 (220c1aa) into master (78d762c) will decrease coverage by 0.02%.
The diff coverage is 9.09%.

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
- Coverage   38.61%   38.59%   -0.03%
==========================================
  Files          50       50
  Lines        5508     5511       +3
==========================================
  Hits         2127     2127
- Misses       3205     3208       +3
  Partials      176      176

Impacted Files
Coverage Δ

...roller/validation/account_validation_controller.go
58.06% <9.09%> (-0.82%)
:arrow_down:

Updated to make sure that we find the correct OU.
One thing I want to double check though is whether we want ALL unclaimed accounts to be in the pool OU, even if they're reused, or if we want only those that have never been claimed to be in the pool OU.

/lgtm

/hold cancel


Make auto-render example file run in-place in repository

I ran into this when trying to test #656.  This will make future autorender tests easier, but also make it easier for someone checking out the repo to just try out the example.  I don't think it breaks any other settings for the HTML, but please correct me if I'm wrong (e.g. if it's accessible on https://khan.github.io/KaTeX/ somehow).
I can't imagine it ever working as written, in particular because auto-render.js uses require, so it can't run directly in a browser -- you need to run the compiled version that ends up in dist.

The file as it stands is intended to be opened by the KaTeX server. Run “make serve” and open http://<IP_ADDRESS>:7936/contrib/auto-render/index.html to see it working in the current version. Running HTML files from a local directory is problematic as modern browsers (Chrome in particular) don't allow access to resources like fonts from local disk. Thus we should design all our examples to use the HTTP server. Perhaps we might want to add a comment to that effect somewhere.

+1 to everything @gagern said. There's a rule in server.js for serving auto-render.js as a browserified bundle, which is why the require() works. So I don't think we need these changes. That said, it would probably be helpful to add to the documentation about how you're supposed to view the examples for future devs.

Oops, thanks -- that makes sense in hindsight!  I'll add documentation to this effect in a different PR.


Update emsl_project_identifiers description

Closes https://github.com/microbiomedata/nmdc-schema/issues/1329

@turbomam  when you get a chance, could you review this

moving to next sprint for review by @turbomam


fix: improve error handling in global fixtures #5208

PR Checklist

[x] Addresses an existing open issue: fixes #5208
[x] That issue was marked as status: accepting prs
[x] Steps in CONTRIBUTING.md were taken

Overview
Description
This PR addresses an issue with the handling of errors in global teardown functions. Previously, if a global teardown function threw an error, the error was not logged clearly, and the process exit code might not reflect the failure.
Changes Made
Updated the _runGlobalFixtures method in lib/mocha.js to:
Log errors with a clear and descriptive message.
Set the process exit code to 1 when a global teardown function fails.
Improved debugging output to aid in identifying which function caused the error.
New Behavior
When a global teardown function fails:
A descriptive error message is logged.
The process exits with a non-zero code, signaling the failure.

All tests pass locally using npm run test-node:unit on both the main branch and my working branch. However, they fail in CI. This suggests an environment-specific issue. I'm investigating further and would appreciate any guidance on differences between the CI and local setups.


Application Extension Name

Hey I would recommend changing the extension name because omni is reserved for NVIDIA Application or Extensions.

@JenNVIDIA  Thanks for the heads up! Perfect timing, checkout my commit 10 minutes ago :D
https://github.com/cadop/ov_dhart/commit/5fbd8e05071a715c5d77aa7657cb5a8522c17802


Create Wire Frame for Web Based Interface

https://balsamiq.cloud/su695f9/pk67p06/r2278
Link to wireframe from website


when previewing a map with charites serve,  it shows Use alt + scroll to zoom the map

When I preview a map with charites serve style.yml and try to zoom in the map. It shows "Use alt + scroll to zoom the map" message. I think we can disable this function for the map development.

I found, this problem is solved at c6e26a6660ee6884a055c465068d63641a8035c7.


Loading adapter from S3 fails

Uploaded the adapter used in the default example in LoRAX docs to a personal lorax-adapters bucket on S3, no change to dir structure:
aws s3 ls s3://lorax-adapters/adapter-1/ --human-readable
2024-01-02 16:15:10    1.5 KiB .gitattributes
2024-01-02 16:15:10    1.3 KiB README.md
2024-01-02 16:15:10  501 Bytes adapter_config.json
2024-01-02 16:15:10   13.0 MiB adapter_model.bin
2024-01-02 16:15:10    4.0 KiB training_args.bin

Tried to load the adapter dynamically from S3 using Python client, got :
Traceback (most recent call last):
  File "/home/ubuntu/user/client.py", line 8, in <module>
    print(client.generate(prompt, max_new_tokens=64, adapter_id=adapter_id, adapter_source=adapter_source).generated_text)
  File "/opt/conda/envs/pytorch/lib/python3.10/site-packages/lorax/client.py", line 157, in generate
    raise parse_error(resp.status_code, payload)
lorax.errors.GenerationError: Request failed during generation: Server error: PREDIBASE_MODEL_BUCKET environment variable is not set

this env var is not documented, happy to contribute. Relaunching the container with PREDIBASE_MODEL_BUCKET set, got
Traceback (most recent call last):
  File "/home/ubuntu/user/client.py", line 8, in <module>
    print(client.generate(prompt, max_new_tokens=64, adapter_id=adapter_id, adapter_source=adapter_source).generated_text)
  File "/opt/conda/envs/pytorch/lib/python3.10/site-packages/lorax/client.py", line 157, in generate
    raise parse_error(resp.status_code, payload)
lorax.errors.GenerationError: Request failed during generation: Server error: No .bin weights found for model s3://lorax-adapters/adapter-1

even though I have verified that adapter_model.bin is present in the provided path.
Running latest Docker on an EC2 g5 instance, instance role has s3 get permission.
Information

[X] Docker
[ ] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction
#!/bin/bash

# Create bucket, assuming AWS creds are configured
acct_id=$(aws sts get-caller-identity --query "Account" --output text)
bucket_name=${acct_id}-lorax-adapters

aws s3 mb s3://${bucket_name}

# Install HF HUB CLI
pip install -U "huggingface_hub[cli]"
huggingface-cli download vineetsharma/qlora-adapter-Mistral-7B-Instruct-v0.1-gsm8k --local-dir ./mistral-adapter

# Upload adapter to S3
aws s3 cp ./mistral-adapter s3://${bucket_name}/adapter-1 --recursive

# Run LoRAX docker container with PREDIBASE_MODEL_BUCKET set to new bucket name
model=mistralai/Mistral-7B-Instruct-v0.1
volume=$PWD/data  # share a volume with the container as a weight cache

docker run --gpus all --shm-size 1g -p 8080:80 -v $volume:/data -e PREDIBASE_MODEL_BUCKET=${bucket_name} \
    ghcr.io/predibase/lorax:latest --model-id $model

# python

from lorax import Client

bucket_name=<REPLACE_BUCKET_NAME>
client = Client("http://<IP_ADDRESS>:8080")
prompt = "[INST] Natalia sold clips to 48 of her friends in April, and then she sold half as many clips in May. How many clips did Natalia sell altogether in April and May? [/INST]"
adapter_id = "s3://bucket_name/adapter-1"
adapter_source = 's3'

print(client.generate(prompt,max_new_tokens=64, adapter_id=adapter_id, adapter_source=adapter_source).generated_text)

Expected behavior
Adapter is downloaded from S3 and loaded to GPU for inference.

Thanks for reporting @joaopcm1996. This code path definitely hasn't been tested thoroughly outside of our internal usage of it. I can definitely take a look and see what the issue is.

@joaopcm1996 assuming you set PREDIBASE_BUCKET_NAME to bucket_name (or whatever the true bucket name is), can you try setting adapter_id = "adapter-1" in your script? I believe this is the current form the s3 source expects (which is out of date with the docs, I'll fix this as soon as possible to be consistent with the docs).

Thanks @tgaddair, that solved it! I'll let you handle the issue, if you want to use it for tracking the change.

Thanks for confirming, @joaopcm1996! This should be fixed going forward by #155.

@tgaddair I believe there is still a discrepancy between docs and behaviour; an absolute S3 path (s3://bucket/adapter_prefix) does not work as adapter_id, as the docs indicate.

^ Facing the same issue @tgaddair


Fetch limit and pages

Unsplash gives a default response of 10 items, by adding page and per page parameters I can increase number of collections

Added per-page parameter with a limit of 30 collections per page


Week View

Not an issue but more of a friendly tip.
My fork has a week view. It's not perfect but it works. I am able to switch to week and month view. If anyone would want this as an option let me know, I'll try to submit it as a PR.

https://github.com/jedt/react-native-calendar/blob/master/CalendarIOS.js#L231-L273

Excellent work! I have a need for this as well. Looks good.

For me, renderHeading gives me error which is "this.props.dayHeadings.map"  is not a function. And If I keep that lines in comment, then it displays calendar without week days.

Would love to see this as well :)

It's been a while. @jedt Do you need help with that warning?

+1


Add status: int argument to Response's constructor

Currently Response class only receive data:
    Response(Any)

The idea would be to be able to pass on the response code for cases where it is needed:
    Response(Any, status=401)

Or use predefined methods https://developer.mozilla.org/es/docs/Web/HTTP/Status:
    Response(Any)
    UnathorizedResponse(Any)
    UpdatedResponse(Any)
    ...

Closing this issue as it is moved to https://github.com/minos-framework/minos-python/issues/73


Fetch limited vehicle info over BLE

Following this tesla-command PR263 that was merged 2 days ago, we can start reading some data.

Presence of the car
Sleep state
Lock / Closure states

@baylanger you were faster than me :)
When vehicle is asleep:
{
        "vehicleLockState":  "VEHICLELOCKSTATE_LOCKED",
        "vehicleSleepStatus":  "VEHICLE_SLEEP_STATUS_ASLEEP",
        "userPresence":  "VEHICLE_USER_PRESENCE_NOT_PRESENT"
}

When vehicle is awake:
{
        "closureStatuses":  {
                "frontDriverDoor":  "CLOSURESTATE_CLOSED",
                "frontPassengerDoor":  "CLOSURESTATE_CLOSED",
                "rearDriverDoor":  "CLOSURESTATE_CLOSED",
                "rearPassengerDoor":  "CLOSURESTATE_CLOSED",
                "rearTrunk":  "CLOSURESTATE_CLOSED",
                "frontTrunk":  "CLOSURESTATE_CLOSED",
                "chargePort":  "CLOSURESTATE_OPEN",
                "tonneau":  "CLOSURESTATE_CLOSED"
        },
        "vehicleLockState":  "VEHICLELOCKSTATE_LOCKED",
        "vehicleSleepStatus":  "VEHICLE_SLEEP_STATUS_AWAKE",
        "userPresence":  "VEHICLE_USER_PRESENCE_NOT_PRESENT"
}

Key element: no authentication needed. No need to supply any key


Reporting Security Vulnerability affecting IPX

Hey team,
I'm trying to get in contact with someone to report a security vulnerability affecting IPX. Is there a good email or place I'd be able to report this?
Cheers,
Sam

<EMAIL_ADDRESS>

Cheers, thanks @nimarion.


UI for Playback Speed & Video Resolution (Quality)

Hi,
Thanks for this great library.
Loved the UI you created. Can you please add Playback speed & Video quality option into player UI?

Hi,
Thanks for this great library.
Loved the UI you created. Can you please add Playback speed & Video quality option into player UI?

For playback speed check the example https://github.com/the-meedu-app/flutter-meedu-player/blob/master/plugin/example/lib/pages/playback_speed_example_page.dart

Can you please add this along with quality options into player UI?

Can you please add this along with quality options into player UI?

For quality change check the example https://github.com/the-meedu-app/flutter-meedu-player/blob/master/plugin/example/lib/pages/change_quality_example_page.dart


936 block number range 2

Added check for latest block to avoid regression, multiple calls to the mirrornode.
Fixes #936

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (7711dd4) 75.08% compared to head (03d7279) 75.08%.

:exclamation: Current head 03d7279 differs from pull request most recent head 16dce7b. Consider uploading reports for the commit 16dce7b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1270   +/-   ##
=======================================
  Coverage   75.08%   75.08%
=======================================
  Files          31       31
  Lines        2304     2304
  Branches      452      452
=======================================
  Hits         1730     1730
  Misses        442      442
  Partials      132      132

Impacted Files
Coverage Δ

packages/relay/src/lib/eth.ts
83.35% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Addressed in another PR.


Import button seems non-responsive

Awesome plugin! I'm looking into importing tokens from a JSON file, but I'm not sure what I'm doing wrong. Clicking "Import" shows a modal, but then clicking the 2nd "Import" button only closes the modal and does nothing else on my screen:

Chrome. Mac.
As a workaround, I can still copy-paste the text of the JSON file into the JSON tab. The sync feature is very exciting.

Are there any styles in the document? Import will use local styles (color, text, shadow) and generate tokens from these.

Oh sorry, I see what you mean, looking at https://youtu.be/Ka1I5TphDb0?t=13m46s it's more like the Import button actually pulls styles from the page ("import from page to figma-tokens"). I misunderstood the button to mean that I can take an existing JSON file from my computer to populate tokens ("import from file to figma-tokens"), instead of manually copy-pasting the text. User error 😆 Would it make sense to have a hover/focus tooltip? It could be a quicker fix than adding an import button to the JSON tab, or adding drag-and-drop.

Those all make sense! The plugin definitely needs a better Import file/Export file to quickly load from your computer and not just one set at a time.
I'm thinking of making the Import / Create Styles section one button with different options (Import or Create), as it would then be in a Styles context. I think that could help as well while reducing the number of available options, what do you think?

I've created a new issue to tackle this: I'll close this one, feel free to comment on the new one!
https://github.com/six7/figma-tokens/issues/394


Next/Previous Track and Stop/Pause/Play Media stopped working globally

Microsoft PowerToys version
0.65.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
Keyboard Manager
Steps to reproduce
try to use mapped keys that are supposed to make spotify play the next track or play pause stop spotify when spotify isnt focused
✔ Expected Behavior
spotify does what the key mas are supposed to make it do...
❌ Actual Behavior
spotify only does that when focused
Other Software
No response

Hi,
I've tested going into open.spotify.com , having it play a playlist. I've mapped A to "Previous Track" and B to "Next Track". I've put the focus in another application and tried pressing A and B. Tracks were changed as expected.
Are you saying this worked in previous versions but not this one?
What are your mappings? Perhaps a /bugreport might allow us to emulate the mappings.
Can you please go into more details into what you're trying to do?


Add Persistence Data to all Actions that output metrics

The following actions need to be updated to include the new Persistence field

Display
Email
File
Log
Print

Merged into v0.19.alpha


Genpect added

Congratulations on making a pull request!
Please make sure you check all the items.

[ ] The numbering of the company that you added starts with 1.
[ ] You have increased the Total Companies Added count.

It's having merge conflicts please resolve it first.
Thank you 😊


Help with Docker

Hi All,
I don't know if I'm being stupid here, but how do I find out what port the Docker container uses?
I've tried to run it with various different combinations but can't seem to figure it out:
sudo docker run -d \
 --name fintech2ynab \
 --restart=unless-stopped \
 -p 8080:8080 \
 -e YNAB_ACCESS_TOKEN="xxxx" \
 -e YNAB_BUDGET_ID="xxxx" \
 fintechtoynab/fintech-to-ynab

To help new users, could we perhaps but some sample docker commands in the getting started guide?

Hey
Rails/puma uses port 3000 by default

When I fork the project it doesn't bring the wiki with it, so I can't find a way to edit that.


Can't Load any Plugin

Hyprland Version
Hyprland, built from branch main at commit db8f13291a4e046e82c9b11c5bfd08f223bd52b1 dirty (hyprctl: add monitors all to report all connected monitors (3730)). Tag: v0.32.3-29-gdb8f1329  flags: (if any) debug
Bug or Regression?
Bug
Description
i can't load any plugin even i installed hyprland the right && normal way.
How to reproduce

install hyprland :

git clone --recursive https://github.com/hyprwm/Hyprland
cd Hyprland
make all && sudo make install

compile and load the plugin:

git clone https://github.com/hyprwm/hyprland-plugins && cd hyprland-plugins/borders-plus-plus
make all
hyprctl plugin load borders-plus-plus.so

Crash reports, logs, images, videos

are you sure you're running the correct hyprland rev? verify with hyprctl version. Plugins should also pop up a notification in the case of a rev mismatch.

yes i am sure

and... no, there is notification. just the error in the screenshot.

oh, I see it.
hyprctl plugin load borders-plus-plus.so

this has to be an absolute path. cwd is not passed between hyprctl and hyprland.

worked like charm , thanks dude >3

I'll improve the logging a bit in a sec. This is resolved though, so closing :)

a bit better, I think.


fixed basic example over query service

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 38.96%. Comparing base (5dbe765) to head (9cbc00c).

Files
Patch %
Lines

internal/params/list.go
0.00%
3 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1098       +/-   ##
===========================================
- Coverage   67.40%   38.96%   -28.45%
===========================================
  Files         286      285        -1
  Lines       27993    27860      -133
===========================================
- Hits        18870    10856     -8014
- Misses       8254    16598     +8344
+ Partials      869      406      -463

Flag
Coverage Δ

?

go-1.21.x
40.31% <0.00%> (-28.84%)
:arrow_down:

go-1.22.x
38.96% <0.00%> (-28.45%)
:arrow_down:

integration
?

macOS
38.89% <0.00%> (-0.03%)
:arrow_down:

ubuntu
38.88% <0.00%> (-0.01%)
:arrow_down:

unit
38.96% <0.00%> (-0.03%)
:arrow_down:

windows
38.93% <0.00%> (-0.03%)
:arrow_down:

ydb-22.5
?

ydb-23.1
?

ydb-23.2
?

ydb-23.3
?

ydb-24.1
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ghost project that can be like ember.js packaged into a static item?

For ember.js project can use the command ember build --prod packaged into static files directly, no longer need to run npm start to run the project, I would like to ask whether ghost support to do so, I looked at the official website tutorial did not find the relevant instructions.

Hi @ubuntuvim!
This sounds like a question about development / contributing? We have a #dev channel in our slack team, as well as a #help channel for general questions, which are both far more suited to questions than GitHub. The issue tracker here on GitHub is used by devs for keeping tabs on what's going on with development of the software: bugs and work in progress issues.
If you head over to slack I'm sure someone can help you :+1:

@ErisDS thanks.


TallyArbiter-set-devices-in-companion

Is this a feature relevant to companion itself, and not a module?

[X] I believe this to be a feature for companion, not a module

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the feature
I wanted to know if it would be possible to configure the devices from companion,
in order to make tally crosspoints faster on the same key.
Or do you know another way to make TSL crosspoint ?
Usecases
No response

I am the author of tallyarbiter and I don't understand what you are asking for


Scaled Segmented Configuration Results in Multiple Backends

Do you want to request a feature or report a bug?
Bug
What did you do?
I am attempting to scale up a container, which exposes multiple ports, and for each of the containers to exist under a single named backend. The traefik configuration utilises the segmented configuration notation in order to route the different frontends to the relevant ports exposed on the containers.
I have pruned this back to it's simplest form to demonstrate the issue. In running the below I would expect a number of frontends, linked to two backends (app1 and app2) and for there to be two containers in each of the backends. There are, however, a number of frontends with an equal number of backends, each made up of a single container.
docker run -d  -p 80:80 -p 81:81 -p 8080:8080 -v /var/run/docker.sock:/var/run/docker.sock traefik:latest --api --docker
docker run -d -l traefik.app1.frontend.rule=Host:app1.docker.local -l traefik.app1.port=8000 -l traefik.app1.backend=backend1 jwilder/whoami
docker run -d -l traefik.app1.frontend.rule=Host:app1.docker.local -l traefik.app1.port=8000 -l traefik.app1.backend=backend1 jwilder/whoami
docker run -d -l traefik.app2.frontend.rule=Host:app2.docker.local -l traefik.app2.port=8000 -l traefik.app2.backend=backend2 jwilder/whoami
docker run -d -l traefik.app2.frontend.rule=Host:app2.docker.local -l traefik.app2.port=8000 -l traefik.app2.backend=backend2 jwilder/whoami

If I then curl request to the different front ends you can see there isn't any round-robin-ing going on between the two containers which should make up the backends:
$ curl -H "Host:app1.docker.local" localhost
I'm 835402dd612d
$ curl -H "Host:app1.docker.local" localhost
I'm 835402dd612d
$ curl -H "Host:app1.docker.local" localhost
I'm 835402dd612d
$ curl -H "Host:app2.docker.local" localhost
I'm d7ecfb7002cc
$ curl -H "Host:app2.docker.local" localhost
I'm d7ecfb7002cc
$ curl -H "Host:app2.docker.local" localhost
I'm d7ecfb7002cc

If I take the segmentation away and run the following, I see a setup close to what I want i.e. a number of frontends, linked to a single backend (backend1) and two containers as members. Clearly, this takes away the ability to have the setup serve content from app2.
docker run -d  -p 80:80 -p 8080:8080 -v /var/run/docker.sock:/var/run/docker.sock traefik:latest --api --docker
docker run -d -l traefik.frontend.rule=Host:docker.local -l traefik.port=8000 -l traefik.backend=backend1 jwilder/whoami
docker run -d -l traefik.frontend.rule=Host:docker.local -l traefik.port=8000 -l traefik.backend=backend1 jwilder/whoami

It seems as though as soon as you introduced any segmentation, the ability to have multiple containers under a single backend isn't possible.
What did you expect to see?
I was expecting to see each of the whoami containers to exist under a single backend.
What did you see instead?
Each of the whoami containers existed under their own backend.


unsupported platform Linux

hi Niklas Rosenstein
i'm really interested in your work ,very amazing//
but i tried to run your code in whezziy linux giving error unsupported platform
im using raspberry pi 2
i want to insert your code in my project , so i will be Thankful if you helped me to run this code
thanks for your hard working

Hi @abdelrhmn3,
that's because Thalmic does not support Linux. As you can see on the SDK Download page, they only support Windows, Mac OS, iOS and Android. Take a look at projects like

Myo4Linux
PyoConnect


Is it Possible to Remove Colon in Field List?

Problem
Sometimes it is useful to display an image as a field instead of text as shown below. While this may appear slightly strange, it's a design decision. However, there is always a Colon even when an image is used instead of text. There needs to be a way to disable the colon (:) for cases such as this.

Reproducible Project
Please give a link to a public reproducible project or provide an example of the Restructured Text that gives an issue.
:|e710|:
  **New Transaction:** Creates a new transaction for the selected account and opens the :ref:`transaction_editor`.
:|e118|:
  **Import:** Open the transaction import overlay.

Error Logs/Results
N/A
Expected Results
There should be a configuration to remove the colon. In fact I would argue that adding a colon to even text should not be the default behavior. The default should display the text exactly how it is written in the source file.
Environment Info

Python Version:
Sphinx Version:
RTD Theme Version: 0.5.2

You can add custom css for this:
dl.field-list > dt:after {
  display: none;
}

To make this only affect select field list use a container directive:
https://docutils.sourceforge.io/docs/ref/rst/directives.html#container
.. container:: custom

   :|image|: Lorem Ipsum
   :|image|: Lorem Ipsum
   :|image|: Lorem Ipsum

In the case above the custom CSS would become:
.custom > dl.field-list > dt:after {
  display: none;
}

See the documentation below on how to add custom css to sphinx:
https://docs.readthedocs.io/en/stable/guides/adding-custom-css.html

Let me know if everything works for you, ill close this issue in a few days.


FIX Admin bloacklisted messages using correct $.inArray check

See discussion #5312
The $.inArray returns the index of the found item and -1 if there is no match.

You got your logic backwards. :D

As a note, I'm merging this up from 3 -> master with this code.
// Show message (but ignore aborted requests)
    if (xhr.status !== 0 && msg && $.inArray(msg, ignoredMessages) === -1) {
      // Decode into UTF-8, HTTP headers don't allow multibyte
      statusMessage(decodeURIComponent(msg), msgType);
    }

Note: Close https://github.com/silverstripe/silverstripe-framework/issues/5281 again once this is merged. :D

Merged with https://github.com/silverstripe/silverstripe-framework/commit/71a4f1e605d35fec63165a2036110d3cf38d08a1

I've got a similar problem on v3.4. In the dev env the issue doesn't manifest, however in the stage env on the destination server I've got a slew of notifications. It happens in OSX Safari, doesn't happen in OSX Google Chrome. I think a new browser update added to the problem.


64: dust

if i send 1 sat, i got error. i understand banning this dust. my question is whats the dust limit?

2 sat same

294 sat : OK
https://sugar.wtf/#/transaction/e446935e109e6c9359ddb4ca70d163cfe5a0005cb455b09b11e1ddfea8a91adb

however i suggest minimum transfer limit is at least 1 SUGAR against dust attack.

https://github.com/sugarchain-project/sugarchain/blob/master-v0.16.3/src/policy/policy.cpp#L52-L55

https://github.com/sugarchain-project/sugarchain/blob/master-v0.16.3/src/policy/policy.cpp#L20-L33

This is Yumekawa related issue.


Install errors

php 5.6:
Whoops\Exception\ErrorException thrown with message "Call to a member function getPackageID() on null"
Stacktrace:
#0  in /public/packages/community_store/src/CommunityStore/Payment/Method.php:192
php 7:
Declaration of Concrete\Package\CommunityStore\Src\Attribute\Key\StoreOrderKey::load($akID) should be compatible with Concrete\Core\Attribute\Key\Key::load($akIdentifier, $loadBy = 'akID')

Sorry about this one, I'd made some last-minute changes to the way payment methods can be configured.
This should be fixed by https://github.com/concrete5-community-store/community_store/commit/84010bbf4a1a58cb0fa9037d6e81afccd128d1a3
Try installing again.
I haven't got PHP7 currently installed, but I've also put in what I think is the fix for the second issue.

thx!

Let me know if it fixes it and I'll close this issue

5.6 works now. 7 not. but there are more issues with 7 than just installing, as far as I see.

No worries. I'll close this issue for now - I think PHP7 issues should be raised separately.
(I better get PHP7 installed hey!)


Deal with no colorcolumn settings

When colorcolumn is not set, colorcolumn (local variable) should
become { [2] = "" } and an error occurs as below.
the error
E5108: Error executing lua ...packer/opt/virt-column.nvim/lua/virt-column/commands.lua:12: Vim(lua):E5108: Error executing lua ...ack/packer/opt/virt-column.nvim/lua/virt-column/
init.lua:60: attempt to compare nil with string
stack traceback:
        ...ack/packer/opt/virt-column.nvim/lua/virt-column/init.lua:60: in function <...ack/packer/opt/virt-column.nvim/lua/virt-column/init.lua:59>
        [C]: in function 'sort'
        ...ack/packer/opt/virt-column.nvim/lua/virt-column/init.lua:59: in function 'refresh'
        [string ":lua"]:1: in main chunk
        [C]: in function 'cmd'
        ...packer/opt/virt-column.nvim/lua/virt-column/commands.lua:12: in function 'refresh
        [string ":lua"]:1: in main chunk
stack traceback:
        [C]: in function 'cmd'
        ...packer/opt/virt-column.nvim/lua/virt-column/commands.lua:12: in function 'refresh'
  '      [string ":lua"]:1: in main chunk

This fixes it.

Got it. I confirmed the error has disappeared. Closing.


New UI showing Comments & Description on the side

New YouTube UI is terrible, comments are appearing on the side. If this can fix it would be amazing

If you're using uBlock Origin, put this in your custom filter:
youtube.com##+js(set, yt.config_.EXPERIMENT_FLAGS.kevlar_watch_grid, false)

If you're using uBlock Origin, put this in your custom filter: youtube.com##+js(set, yt.config_.EXPERIMENT_FLAGS.kevlar_watch_grid, false)

It worked thanks!


Hide sidebar

NOTE: Before you start, the following should be completed.

Read tutorial to understand the usage and the correct effect of functional design.
Make sure no similar issue(including closed ones) exists.
Make sure the request is based on the latest code in the master branch.

Is your feature request related to a problem? Please describe
Chirpy is a minimal, responsive and feature-rich Jekyll theme for technical writing. Because of this, the reading experience is great and can be improved by hiding the sidebar, this would allow to have a full focus on the reading side.
Describe the solution you'd like
I would like to achieve hiding the sidebar by the pressing of a button.
Describe alternatives you've considered
Making a script that removes the sidebar's html code is not enough, alignment errors would happen with the text and the search bar.
Additional context
This screenshot simplifies pretty much how the reading experience is improved.

Hi there! I stumbled upon this issue while trying to figure out how to hide the sidebar on my post layouts in Jekyll. As a newbie to Jekyll 🤚 , I tried several workarounds but none seemed to work elegantly. Eventually, I found a solution that might not be the most efficient, but it did the job. If anyone else is struggling with this issue, this solution might come in handy:
According to the Jekyll documentation, you can customize the HTML template files from the theme by locating them in the gem directory. You can follow those instructions to find your directory, or you can simply copy the default.html file from the repository into _layouts/default.html.
Once you have added that file, you can remove the % include sidebar.html lang=lang %} line to completely remove the sidebar. Alternatively, if you only want to hide it when reading a post, you can use the following lines (to replace the one removed)
    {% unless page.layout == "post" %}
    {% include sidebar.html lang=lang %}
    {% endunless %}

Although the solution gets the job done, it's not ideal. I would have preferred to see the hamburger menu collapsed that you get when seen the site on mobile. Hopefully, this helps someone!


Missing Nav

When the component was show from a hidden or display none mode, the navigation (arrow) is missing

BTW, wait until you have your data loaded loaded to populate the dom before you render vue-horizontal or it will need to have its refresh() method run again.
<vue-horizontal ref="myVueHorizontal">...</vue-horizontal>

// only when you're sure data was there to render inside of vue-horizontal...
this.$refs.myVueHorizontal.refresh();

Better to just make sure the parent component has the data it needs when vue-horizontal is mounted otherwise its calculations are based on empty contents (i.e. outdated hasPrev and hasNext) hence no buttons.
Why no use MutationObserver to watch slot content? Just a thought not sure if it would work 97+% slaps tho caniuse.com/mutationobserver

// only when you're sure data was there to render inside of vue-horizontal...
this.$refs.myVueHorizontal.refresh();

Hi ndmgrphc
Thanks for you comments, it has helped me implement this with a reactive array of data which can change length at any time.
Although I have got it to work, I get an error in the console, but even with the error it still seems to work.
Uncaught (in promise) TypeError: t is not a function     at eval (vue-horizontal.es.js?de74:formatted:265)
because i am using vue3, i am using a watcher to refresh vue-horizontal when the image array changes,
<vue-horizontal ref="vh">     .....      </vue-horizontal>
    watch(imgs, () => {       vh.value.refresh()     })
Any advice on how to improve this set up or how to get rid of this error would be much appreciated.
Thanks in advance
parkb

Thanks @ndmgrphc, this got my arrows back.  What does "wait until you have your data loaded to populate the DOM before you mount vue-horizontal" mean?  Can you tell vue-horizontal to wait until some point to get its data?

@CoderTonyB I fixed it with a simple v-if on the vue-horizontal to check if the data are loaded.

@CoderTonyB I fixed it with a simple v-if on the vue-horizontal to check if the data are loaded.

Ok, so something like v-if="data.length > 0" - I'll give it a shot, thanks.

I had same issue. I must be sure if parent/child component has all data, I aplied v-if="data.length" into <vue-horizontal..., an then navigation appear.


useEdgeState doest get updated when set edges inside provider

What platform were you using when you found the bug?

React Flow / Svelte Flow version: 12.3.2
Browser and version:  chrome 129.0.6668.101 (Official Build) (arm64)
OS and version: macos

Live code example
No response
Describe the Bug
we use this in the root component where react flow provider exist:
  const [nodes, setNodes] = useNodesState<CustomNode>([]);
  const [edges, setEdges] = useEdgesState<Edge>([]);

and then inside the custom node we have a button that add a new node and edge. everything works fine but the edges in the root. it doesnt get updated when we set new edges, however nodes get updated correctly
I tried both useStore and useReactFlow functions to set the edge or add the edge and they didnt work.
Steps to reproduce the bug or issue
use react flow provider with useNodesState and useEdgesState and then try to set a new edge somewhere inside childrens. the root doesnt get updated
Expected behavior
it should get updated like nodes
Screenshots or Videos
No response
Additional context
No response

Same here

Would you mind creating a small reproduction for this? You can create a new code sandbox  at new.reactflow.dev/ts.

I have a similar issue when using this:
 const [nodes, setNodes, onNodesChange] = useNodesState<Node<NodeData>>(
    initialNodes || []
  )
  const [edges, setEdges, onEdgesChange] = useEdgesState<Edge<EdgeData>>(
    initialEdges || []
  )

in the main component as a child of the ReactFlowProvider. and passing the onXChange to the ReactFlow component.
Everything works as expected, but when i use const { setNodes } = useReactFlow() somewhere in a child, the some states only update when I drag around a node;
For example the getNodes() is not triggering the component to update when it in fact has:
See this example:
const DetachDescendantsButton: React.FC<{
  id: string
}> = ({ id }) => {
  const { getNodes, setNodes } = useReactFlow()
  const nodes = getNodes()

  const updateNodeInternals = useUpdateNodeInternals()
  const removeParentIdFromMultipleNodes = useCallback(
    (parentIdToRemove: string) => {
      setNodes((nodes) => {
        const parentNode = nodes.find((n) => n.id === parentIdToRemove)

        return nodes.map((node) => {
          if (node.parentId === parentIdToRemove) {
            return getNodeDataWithoutParentId(node, parentNode)
          }
          return node
        })
      })

      updateNodeInternals(id)
    },
    [setNodes]
  )

  const hasDescendants = useCallback(
    (nodeId: string) => {
      return nodes.some((node) => node.parentId === nodeId)
    },
    [nodes, getNodes]
  )

  return (
    hasDescendants(id) && (
      <Tooltip title="Detach all descendants">
        <IconButton
          size="small"
          onClick={(e) => {
            removeParentIdFromMultipleNodes(id)
          }}
        >
          <Icon>clear</Icon>
        </IconButton>
      </Tooltip>
    )
  )
}

And this button will only update when something I move around the node where the button is in (in this case in the special Toolbar component), or when unmounting and rerendering the toolbar/button.
I initially thought it was the lack of updateNodeInternals() that I needed to trigger after doing setNodes(), but this doesn't help.
I should probably make this into a separate issue, but it seems related.


Add nested resources to document outline

Fixes: #1958

@rynowak - any capacity to pick this one again?

I think we let the perfect be the enemy of good on this one 😟I resolved the conflicts and decided to merge it.

Btw, nested symbols look really good in VS code especially with how breadcrumbs handle it.


Support for scoped/organizational engines => mount('@org/engine')

So, I tried to create a scoped engine @org/engine and tried mounting it in the dummy app:
Router.map(function () {
  this.mount('@org/engine, { path: '/foo'});
});

which gives this error: Assertion Failed: Asset manifest does not list any available bundles.
I traced it down to this line: https://github.com/ember-engines/ember-asset-loader/blob/f8f1a448456697dbf128da27a15ca034d848763a/addon/services/asset-loader.js#L230
Second, here is the function that invokes the one above: https://github.com/ember-engines/ember-engines/blob/93f40763e22e536437a8fa63c66840ff9fa7b20d/addon/-private/router-ext.js#L238

Oh @lennyburdette hit me up on slack, he already did a PR to support this. See ember-engines/ember-asset-loader#63

Other than publishing a release of ember-asset-loader that has that fix in it, is there anything else blocking the use of engines with scoped names?

So it turns out that fixing ember-asset-loader was only step 1. I didn't test out subroutes.
I believe the problem is that the engine is trying to look up its route map through the resolver with the key route-map:@scope/pkg-name. The @ sigil already has some meaning in the classic resolver so it's being stripped away (see relevant tests here). It ends up calling require('scope/pkg-name/routes') instead.
@rwjblue Do you think it's worth it to extend the classic resolver to handle route-map:@scope/pkg-name correctly? Or will it add more confusion because of the other uses of @?

Any progress here?

@rwjblue Do you think it's worth it to extend the classic resolver to handle route-map:@scope/pkg-name correctly? Or will it add more confusion because of the other uses of @?

@lennyburdette - We can probably teach the resolver specifically about :@, which should unblock us here...

https://github.com/ember-cli/ember-resolver/blob/master/addon/resolvers/classic/index.js#L46-L75
Seems like there's already an exception for helper:@content-helper. Would the valid fix be just allowing any fullName containing :@?

Is this resolved now? https://github.com/ember-cli/ember-resolver/pull/330 suggests as much.

@buschtoens it's https://github.com/ember-cli/ember-resolver/pull/330 resolved your problem with scope? ca we close this issue?

Yes, it did. :)

@rwjblue it's already fixed, can you close this, please?

It pretty much just works like with non-scoped engines.
// router.js
this.mount('@my-org/my-engine', {
  path: 'foo',
  as: 'foo'
});

// app.js
const App = Application.extend({
  // ...
  engines: {
    '@myOrg/myEngine': {
      dependencies: {
        services: [ /* ... */ ],
        externalRoutes: { /* ... */ }
      }
    }
  }
});

@gossi this issue was solved for you as well

Pretty sure it does 👍

@gossi can you close this issue, please? I don't privilege to do it


Looking for help maintaining this library!

If you are interested please get in touch with me. Both @svenjacobs and I are very busy in other project and would appreciate some help!
Thanks!

I would be willing to help maintain.

Awesome, you have already been a great contributor as well. Would like one more to help as well, @crevete? :)

Yep, I'd like to help you to maintain this lib :-)

Awesome, you two have done an amazing job already. I will add you guys as maintainers and email you guys out instructions on how to deploy SNAPSHOTs and releases. Thanks, we really appreciate it.

If you guys can shoot me an email at<EMAIL_ADDRESS>and I can send you that stuff, that would be great! I added you guys as maintainers, you should be free to merge PRs, close issues, whatever you guys need to be done.


Collaborative wallet: UI issues.

Remove button of default co-signer is not responding.

https://github.com/bithyve/bitcoin-keeper/assets/62699947/fd70112c-698c-4cd2-99a0-2e79afe277ce

If we removed all the added co-signers from Add signers screen of collaborative wallet then we can not add them again.Each time we have to go back to the previous screen and come to the Add signers screen to add the signers.

https://github.com/bithyve/bitcoin-keeper/assets/62699947/143a31cb-ee03-4c08-a5ea-16065d994cf9

Added details are not showing below the added co-signer.

Disabled removing our own cosigner (we're not supposed to)

Please close this as UI has been updated

Verified this issue on keeper app v 1.1.12(303)


Regression requesting to sideload related records between 0.16.1 and 0.16.3

This code:
    let { user, userDomainCapabilities: domainCapabilities } = await this.store.findRecord(
      'session',
      'current',
      {
        label: 'Find current session',
        sources: { remote: { include: ['user', 'user-domain-capabilities'] } }
      }
    );

In 0.16.1 generates api/sessions/current?include=user%2Cuser-domain-capabilities but in 0.16.3 generates just api/sessions/current.

I've tracked this down to this line:
<EMAIL_ADDRESS>If an object of options is received, that object replaces the options in the query. I'm not sure if that behavior is intentional or merging both would be more desirable.
The arguments received by that function come from<EMAIL_ADDRESS>and in turn from<EMAIL_ADDRESS>In here the hints are being passed as second argument, and taken as the options of the request by the url generator.

@cibernox Do you have a custom action handler in your RequestStrategy? And if so, are you forwarding ...arguments to an action (probably query) on a source? If both are true, try instead forwarding only the first argument on to query.
The reason that the RequestStrategy now forwards all args to a custom handler (here) is that custom listeners were missing out on some critical details, such as errors for queryFail events that are passed as a second argument. I still think this is the right decision, but I should have considered how it could break existing strategies. Sorry about this.

I am indeed doing that:
    return new RequestStrategy({
      name: 'store-remote-query-optimistic',

      source: 'store',
      on: 'beforeQuery',

      target: 'remote',
      action(query, ...rest) {
        return this.target.pull(query, ...rest).then(transforms => {
          // uninteresting code
        })
      }

@cibernox based on our discussion in gitter, your issue is resolved and we can close this now, right?

It can indeed be closed, as was relying on a buggy behavior


request: Back button default on empty history stack

It would be nice to have the option to define a default "back state" in situations when the user lands on a non-default ("non-home") view.
For example:

User clicks something on a view that takes them to another state and shows a back button
if the user refreshes the page here then the back button no longer shows. A refresh can also occur when the user minimizes the app and returns to it after a longer period of time.
the user is then unable to return to the home view, posing a problem.

There have been a few forum threads on this issue, see: http://forum.ionicframework.com/t/manipulating-history-states-and-back-button-after-a-refresh/5590
and http://forum.ionicframework.com/t/back-button-behaviour-like-home-when-there-is-no-history/5072

I'd like to use this snippet, but get an error:
Unknown provider: $ionicNavBarConfigProvider
and $ionicNavBarConfig is nowhere to be found in beta 14 sources. Did they remove it this quickly?

Code above doesnt work for me either (even after removing $ionicNavBarConfigProvider which is only used to get the back-button css class. The button doesn't show up in any case.
I'm surprised this functionality isn't built in already. I'd like to use my Cordova app in place of the website when loaded on mobile so this funtionality is a must. It's pretty bad, you literally get stuck on the page you landed on.

It would be helpful. I've created a simple workaround (snippets in coffeescript and slim):
app.directive 'defaultNavBackButton', ['$ionicHistory', '$state', ($ionicHistory, $state) ->
  link: (scope, element, attrs) ->
    scope.backTitle = ->
      $ionicHistory.backTitle() || 'Intro'

    scope.goBack = ->
      if $ionicHistory.backTitle()?
        $ionicHistory.goBack()
      else
        $state.go 'intro'

    # Fire only on initial page load
    unbindEvent = scope.$on '$stateChangeSuccess', ->
      element.removeClass 'hide'
      unbindEvent()
]

ion-nav-back-button default-nav-back-button="" ng-click="goBack()"
  | {{ backTitle() }}

thanks @hodak. I added some code to make it somewhat more robust:
$ionicHistory.nextViewOptions({
    disableAnimate: true,
    historyRoot: true
});
$state.go($state.current.back);

where $state.current.back is configured on the state object:
.state('tab.user', {
            back: 'tab.search',
            url: '/user/:username',
            ....
        })

So instead of always going to the same page, I would have a bit more control. Setting historyRoot: true was neccesary to prevent a behavior where going to the "tab.search" the normal way would then return to the landing page. I didn't want that. Also disabledAnimation to prevent it from sliding to the right when going "back" (it doesn't feel right, it would be nice to be able to configure it to go left instead)

@hodak that you so much for the solution!
can you publish it to a Github repo for the directive please?
would be easier to maintain and for me to contribute
thanks!

Hi guys, I had the same issue so i write a directive inspired by the solution posted by @hodak and @parliament718, i also added the support for android back button.
Here the directive, work fine for me:
app.directive('defaultNavBackButton', defaultNavBackButton);

/* @ngInject */
function defaultNavBackButton($ionicHistory, $state, $ionicConfig, $ionicViewSwitcher, $ionicPlatform) {
  var directive = {
    link: link,
    restrict: 'EA'
  };
  return directive;

  function link(scope, element, attrs) {
    scope.backTitle = function() {
      var defaultBack = getDefaultBack();
      if ($ionicConfig.backButton.previousTitleText() && defaultBack) {
        return $ionicHistory.backTitle() || defaultBack.title;
      }
    };
    scope.goBack = function() {
      if ($ionicHistory.backView()) {
        $ionicHistory.goBack();
      } else {
        goDefaultBack();
      }
    };
    scope.$on('$stateChangeSuccess', function() {
      element.toggleClass('hide', !getDefaultBack());
    });
    $ionicPlatform.registerBackButtonAction(function () {
      if ($ionicHistory.backView()) {
        $ionicHistory.goBack();
      } else if(getDefaultBack()) {
        goDefaultBack();
      } else {
        navigator.app.exitApp();
      }
    }, 100);
  }

  function getDefaultBack() {
    return ($state.current.data || {}).defaultBack;
  }

  function goDefaultBack() {
    $ionicViewSwitcher.nextDirection('back');
    $ionicHistory.nextViewOptions({
      disableBack: true,
      historyRoot: true
    });
    $state.go(getDefaultBack().state);
  }
}

 <ion-nav-bar class="bar-positive">
  <ion-nav-back-button default-nav-back-button ng-click="goBack()">
    {{ backTitle() }}
  </ion-nav-back-button>
</ion-nav-bar>
<ion-nav-view></ion-nav-view>

@gffuma, Thanks. Works for me!
Curious, what do your state definitions look like? Reverse-engineering from the code it looks like you have:
     data: { defaultBack: { state: 'backstate' } }
      url: '/myState/:actionId', ...
    })```

Just wondering why you chose to make it 2 levels deep? Rather than just:

```    .state('myState', {
     defaultBack: 'backstate',
      url: '/myState/:actionId', ...
    })```

I modified the directive to make them work with stateParams. In my case, I needed to be able to have a defaultBack view for a comments view that correspond to a certain post, so:

postView => defaults back to posts timeline
postCommentsView => defaults back to postView

Here's the sample code:
.state('in.posts.show', {
	url: '/:postId',
	templateUrl: 'app/modules/posts/show/show.html',
	controller: 'ShowPostController',
	defaultBack: {
		state: 'in.tab.timeline'
	}
})

.state('in.posts.comments', {
	url: ':postId/comments',
	templateUrl: 'app/modules/posts/show/comments.html',
	controller: 'PostCommentsController',
	defaultBack: {
		state: 'in.posts.show',
		getStateParams: function(stateParams) {
			return {
				postId: stateParams.postId
			};
		}
	}
})

Here's the modified directive:
angular.module('app.directives', [])
	.directive('defaultNavBackButton', function ($ionicHistory, $state, $stateParams, $ionicConfig, $ionicViewSwitcher, $ionicPlatform) {

		return {
			link: link,
			restrict: 'EA'
		};

		function link(scope, element, attrs) {

			scope.backTitle = function() {
				var defaultBack = getDefaultBack();
				if ($ionicConfig.backButton.previousTitleText() && defaultBack) {
					return $ionicHistory.backTitle() || defaultBack.title;
				}
			};

			scope.goBack = function() {
				if ($ionicHistory.backView()) {
					$ionicHistory.goBack();
				} else {
					goDefaultBack();
				}
			};

			scope.$on('$stateChangeSuccess', function() {
				element.toggleClass('hide', !getDefaultBack());
			});

			$ionicPlatform.registerBackButtonAction(function () {
				if ($ionicHistory.backView()) {
					$ionicHistory.goBack();
				} else if(getDefaultBack()) {
					goDefaultBack();
				} else {
					navigator.app.exitApp();
				}
			}, 100);

		}

		function getDefaultBack() {
			return ($state.current || {}).defaultBack;
		}

		function goDefaultBack() {
			$ionicViewSwitcher.nextDirection('back');
			$ionicHistory.nextViewOptions({
				disableBack: true,
				historyRoot: true
			});

			var params = {};

			if (getDefaultBack().getStateParams) {
				params = getDefaultBack().getStateParams($stateParams);
			}

			$state.go(getDefaultBack().state, params);
		}
	})
;

Thanks @gffuma for your implementation, it's really useful!
@Crashthatch
This is because ionic uses ui-router to track states. And ui-router defaults a data: object for custom data, this object will gain backward compatibility when ui-router has new releases.

@gffuma Thanks for the directive, everything works as expected! I'm experiencing a small visual glitch though. $stateChangeSucces seems to fire multiple times which causes the back-button to flicker. Any idea how I could fix this?

Hi, I'm using the latest implementation @maurotrigo inspired from all the others. I can see this helps providing a default value when there is no state. But is it just me or it doesn't solve the case when the browser refreshes?
I understand I can set params for the defaultBack, but the problem is that when I've navigated through to a second view the back button is shown alongside the menu button, which shouldn't show given the fact that enable-menu-with-back-views is set to false. Is there anything I'm missing?
this is my code:

directive:

angular.module('starter.directives', [])
    .directive('defaultNavBackButton', function ($ionicHistory, $state, $stateParams, $ionicConfig, $ionicViewSwitcher, $ionicPlatform) {

        return {
            link: link,
            restrict: 'EA'
        };

        function link(scope, element, attrs) {

            scope.backTitle = function() {
                var defaultBack = getDefaultBack();
                if ($ionicConfig.backButton.previousTitleText() && defaultBack) {
                    return $ionicHistory.backTitle() || defaultBack.title;
                }
            };

            scope.goBack = function() {
                if ($ionicHistory.backView()) {
                    $ionicHistory.goBack();
                } else {
                    goDefaultBack();
                }
            };

            scope.$on('$stateChangeSuccess', function() {
                element.toggleClass('hide', !getDefaultBack());
            });

            $ionicPlatform.registerBackButtonAction(function () {
                if ($ionicHistory.backView()) {
                    $ionicHistory.goBack();
                } else if(getDefaultBack()) {
                    goDefaultBack();
                } else {
                    navigator.app.exitApp();
                }
            }, 100);

        }

        function getDefaultBack() {
            return ($state.current || {}).defaultBack;
        }

        function goDefaultBack() {
            $ionicViewSwitcher.nextDirection('back');
            $ionicHistory.nextViewOptions({
                disableBack: true,
                historyRoot: true
            });

            var params = {};

            if (getDefaultBack().getStateParams) {
                params = getDefaultBack().getStateParams($stateParams);
            }

            $state.go(getDefaultBack().state, params);
        }
    });

html

<ion-side-menus enable-menu-with-back-views="false">
    <ion-side-menu-content>
        <ion-nav-bar class="bar-positive">
            <ion-nav-buttons side="left">
                <button class="button button-icon button-clear ion-android-menu" menu-toggle="left">
                </button>
            </ion-nav-buttons>
            <!--<ion-nav-back-button default-nav-back-button="" ng-click="goBack()">-->
                <!--{{ backTitle() }}-->
            <!--</ion-nav-back-button>-->

            <ion-nav-back-button default-nav-back-button ng-click="goBack()">
                {{ backTitle() }}
            </ion-nav-back-button>

            <!--<ion-nav-back-button id="back-button">
            </ion-nav-back-button>-->
        </ion-nav-bar>
        <ion-nav-view name="main-view"></ion-nav-view>
    </ion-side-menu-content>

    <ion-side-menu side="left">
        <ion-nav-view name="side-menu-view"></ion-nav-view>
    </ion-side-menu>
</ion-side-menus>

That's how i do it:
   $scope.goBack = function() {
        var v = $ionicHistory.viewHistory();
        if(!v.backView){
            $state.go('app.home');
        }
        else{
            $ionicHistory.goBack();
        }
    };

this is awesome guys ... ! You should consider integrating it by default or create a proper git for it !


Guidance on the callback URL for GitHub app authentication

This controller is fantastic. I have a question about authenticating via a GitHub application. When I go to create an org level app, I'm required to add an Oauth callback URL. What should use for that? I feel like this might be something the controller will expose provided GitHub can access it over the internet.
Any help here is appreciated.

@matthewcummings Hey! You don't need it, because actions-runner-controller doesn't rely on the user authorization.


Add Alluxio POSIX API troubleshooting and performance investigation doc

What changes are proposed in this pull request?
Add the doc about how to troubleshooting Alluxio POSIX API errors and how to investigate Alluxio POSIX API performance.
Why are the changes needed?
Does this PR introduce any user facing changes?
docs

Codecov Report

Merging #14195 (96f4c50) into master (492647b) will decrease coverage by 25.91%.
The diff coverage is 8.69%.

@@              Coverage Diff              @@
##             master   #14195       +/-   ##
=============================================
- Coverage     43.22%   17.31%   -25.92%
+ Complexity     9263     2699     -6564
=============================================
  Files          1436     1436
  Lines         83108    83180       +72
  Branches      10052    10057        +5
=============================================
- Hits          35923    14400    -21523
- Misses        44198    67520    +23322
+ Partials       2987     1260     -1727

Impacted Files
Coverage Δ

...va/alluxio/cli/fs/command/LoadMetadataCommand.java
0.00% <0.00%> (ø)

...o/stress/jobservice/JobServiceBenchParameters.java
0.00% <0.00%> (ø)

...java/alluxio/stress/cli/StressJobServiceBench.java
0.00% <0.00%> (ø)

...ommon/src/main/java/alluxio/metrics/MetricKey.java
97.47% <100.00%> (-0.38%)
:arrow_down:

...io/master/file/replication/ReplicationChecker.java
9.82% <100.00%> (-60.35%)
:arrow_down:

...mon/src/main/java/alluxio/shell/CommandReturn.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/util/ExceptionUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/wire/AlluxioProxyInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/alluxio/wire/AlluxioMasterInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/job/meta/JobIdGenerator.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 680 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea36bb3...96f4c50. Read the comment docs.

alluxio-bot, merge this please


🐛 BUG: @astrojs/check not working with typescript import aliases

Describe the Bug
I'm using Astro version v4.4.0 & the last version of @astrojs/check v0.5.5. Also I have configured a list of aliases paths in tsconfig.json file.
When I run the task "npm run astro check", I get a lot of errors of this type: "Cannot find module<EMAIL_ADDRESS>or its corresponding type declarations." (one by every component or layout imported).
It only happens with astro check, in dev mode everything works ok.
Steps to Reproduce

Have an aliased folders in tsconfig.json:

"paths": {
  "@components/*": ["src/components/*"],
  "@layouts/*": ["src/layouts/*"]
},

Use one of these aliases in an Astro file:
import Layout from<EMAIL_ADDRESS>

Run the task astro check:
npm run astro check

Can you post your full config? Many people are successfully using aliases and astro check, including myself.

Closing due to inactivity. Many people use astro check and import aliases together with no issues, so this is likely a configuration issue.


inline scripts with invalid type attribute get executed

Hi Assaf,
I just found out, that inline-script tags that have an invalid attribute-type will still get executed. This behaviour differs from other major browsers. See this snippet:
<html>
<body>

<script type="true/text/javascript">

console.log('i am executed on zombie/jsdom.');

</script>
</html>

will not be executed in other browsers, but on zombie/jsdom. The main problem is, that jQuery uses this trick with prepending true/(couldn't believe it either ...) when parsing html, that should be appended to the dom to disable the script tags temporarly.
With the current behaviour inline-script-snippets added to the dom with jQuerys html()-function will be executed twice on zombie but once on browsers (chrome).
I created a test, but I wasn't sure if you want to fix this in your JSDOM-Patch scripts.js workarounds or upstream?
Hope the test helps to understand.
Thank you so much
Philipp
References:
https://github.com/jquery/jquery/blob/master/src/manipulation.js#L52

JSDOM picks the language from the script element, and then Zombie taps into that (dom/scripts.js).  We can put a temporary patch to disable scripts, but ultimately JSDOM should not be running these.

I think this is fixed in jsdom 8.2.0 now. https://github.com/tmpvar/jsdom/blob/master/Changelog.md#820


Confusing and wrong "Expired" message for received in past symbol.xym (if current balance = 0)

Steps:

Create an empty account
Send to account transaction with some XYM (probably applies also to other mosaics)
Send back all XYM from account to make it 0

Result: In transaction history (detailed view) you can see Mosaic (1/1) Expired.
Expected result: Expired should be not presented because symbol.xym mosaic did not expired (you just don't have any in wallet)

Same problem is when:

empty account receive partial aggregate bonded (In details, it's expired.)
empty account receive simple tx just before confirmation (In details, it's expired.).

Fixed in branch.

Fixed in integration branch.


added a slider to debug dynamic scaling issues

This is a big hackish, but is intended to help us debug scaling issues,
this adds a couple of sliders under [Debug] to control dynamic
scaling manually.

I didn't realize dynamic scaling worked on desktop!

well... if the timerquery stuff is implemented in the backend, then it'll attempt to work :-)


Lists with tags with async tranforms fail

What happened?
A basic list with a an async transformed tag (for data fetching) throws the following error
TypeError: children.map is not a function
    at render3 (/home/arranf/valinde-rpg/node_modules/@markdoc/markdoc/dist/index.js:7934:131)
    at Array.map (<anonymous>)
    at render3 (/home/arranf/valinde-rpg/node_modules/@markdoc/markdoc/dist/index.js:7934:131)
    at Object.dynamic [as react] (/home/arranf/valinde-rpg/node_modules/@markdoc/markdoc/dist/index.js:7936:10)
    at MarkdocComponent (webpack-internal:///./src/pages/codex/creating-your-character/paths/test.md:84:68)
    at renderWithHooks (/home/arranf/valinde-rpg/node_modules/react-dom/cjs/react-dom-server.browser.development.js:5658:16)
    at renderIndeterminateComponent (/home/arranf/valinde-rpg/node_modules/react-dom/cjs/react-dom-server.browser.development.js:5731:15)
    at renderElement (/home/arranf/valinde-rpg/node_modules/react-dom/cjs/react-dom-server.browser.development.js:5946:7)
    at renderNodeDestructiveImpl (/home/arranf/valinde-rpg/node_modules/react-dom/cjs/react-dom-server.browser.development.js:6104:11)
    at renderNodeDestructive (/home/arranf/valinde-rpg/node_modules/react-dom/cjs/react-dom-server.browser.development.js:6076:14)

To reproduce

Create a file with a list and async tag e.g.

* foo bar {% my-async-tag bar="baz %}hello world{% /my-async-tag %}. More lorem ipsum.
* foo bar

export const myAsyncTag = {
  render: MyComponent,
  description: "Demo",
  attributes: {
    bar: {
      type: String,
      errorLevel: "critical",
      description: "Some important information",
    },
  },
  transform: async (node, config) => {
    const attributes = node.transformAttributes(config);
    const children = node.transformChildren(config);
    console.log(children);
    return new Tag("span", attributes, children);
  },
};

Removing the async keyword this renders correctly. Note that with the async keyword the children is logged after the error is thrown.
Version
"@markdoc/markdoc": "^0.1.13"<EMAIL_ADDRESS>"^0.1.11-0",

Additional context
Using nextjs for rendering.

@arranf are you using @markdoc/next.js? Async transforms are still experimental, and have not been enabled in the @markdoc/next.js Next.js plugin. If you are using it separately from @markdoc/next.js, you might need to await somewhere within your stack.

Gonna close this as async transforms are still experimental, but please let me know if this doesn't full capture the issue you are facing, and I will re-open. Appreciate your involvement in the project @arranf! 🙂


⚠ Processors has degraded performance

In f03a826, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 81 ms

Resolved: Processors performance has improved in f1e7ae7.


perf(net): backoff on IO error

A failed outgoing session attempt can be caused by several IO error kinds, commonly:

Connection Refused
Unreachable
TimedOut

This checks fo io error in should_backoff check so followup requests to the same peer are prevented.

Codecov Report

Merging #633 (9c12aab) into main (d4d8a8c) will increase coverage by 0.03%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
+ Coverage   72.20%   72.23%   +0.03%
==========================================
  Files         257      257
  Lines       25817    25822       +5
==========================================
+ Hits        18641    18653      +12
+ Misses       7176     7169       -7

Flag
Coverage Δ

unit-tests
72.23% <83.33%> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/net/eth-wire/src/errors/eth.rs
47.05% <80.00%> (+13.72%)
:arrow_up:

crates/net/network/src/error.rs
87.50% <85.71%> (ø)

crates/net/discv4/src/lib.rs
51.57% <0.00%> (-0.10%)
:arrow_down:

crates/stages/src/stages/bodies.rs
93.30% <0.00%> (+1.72%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[Tabs] Closable Tabs.

It would be great if tabs had a prop like isClosable: boolean and corresponding events:

Called when the close icon is clicked before the tab is closed: closing: (value) => boolean or closing: (e:{preventDefault: () => void, value}) => void
Called after the tab is closed: closed: (value) => void

The value refers to the value from controlled tabs.
This feature is great for applications that work with documents.

This cal be implemented leveraging the label property on Tab component since it can accept Element now.

This issue may be resolved, but it would be great to have a working example.

@delineated Actually it would work before Tab started using button it's not impossible to implement as it is, and since the specs don't talk about it I decided to solve it differently ( put close somewhere else ). What you can do though, is probably rewrite Tab and have it contain a close button next to it's actual button.

Thank you for the reply. I was hoping to use the onChange event to somehow close the tab, but yeah definitely seems like rewriting Tab will be the way to go.

Except, my team doesn't want to rewrite Tab or any part of material-ui. Is there any component within material-ui that allows you to close it (apart from the appbar)?

No there isn't unfortunately. If your team is open to it, it might not be a bad idea to provide the functionality in the Tab component with a prop to enable/disable it.

I'll pass that along, thank you.

I solved this problem this way:
<Tab component="div" label={   title   <IconButton onClick={...}>     <Close/>   </IconButton> }/>
Render tab component as div or other DOM element, so you can put button inside it.

I solved this problem this way:
<Tab component="div" label={
  <div>
  	title
  	<IconButton onClick={...}>
    	<Close/>
  	</IconButton>
  </div>
} />

Render tab component as div or other DOM element, so you can put button inside it.

I am trying to close a tab and came across this post. I've been stuck and can't solve the problem. I posted it here https://stackoverflow.com/questions/54508683/how-to-target-child-covered-by-parent-overlay-in-material-ui

@chrisdel101
you have to use handler of onChange function, and read e.target. If e.target from CloseIcon - e.preventDefault(); What I mean:
handleTabChange(e, tab) {

    if (e.target.tagName !== 'DIV') { // Our label wrapped by div tag, so, if it isn't true - click made to specific buttons or icons and etc...
      e.preventDefault();
    }

    const { onTabChange } = this.props;
    onTabChange(tab);
  }

Hi @fsdevblog,
preventing using div tag doesn't work in IE.
IE doesn't identify nested tags, it stops with first tag that is button

I'm getting
Warning: validateDOMNesting(...): <button> cannot appear as a descendant of <button>.

Is there a way to prevent this?