authenticator: 4.4.0 -> 4.5.0

Upgrade authenticator to 4.5.0
Fixed camera not working after update to gnome 47 -> I just copied the preFixup from the "snapshot" package

Tested on my nixos x86/64 laptop running nixos-24.11 without issue
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Feel free to ping me in a couple days if there are no other reviews :)

It's a few days later and there is no other reviews ;)

Shouldn't we backport this change to nixos 24.11 ?


collate_igblast_results function

Pull Request Checklists
Important: When opening a pull request, keep only the applicable checklist and delete all other sections.
Checklist for all PRs
Required

[x] I tested the new code for my use case (please provide a reproducible example of how you tested the new functionality)

`

sample_table <- read_tsv("/projects/nhl_meta_analysis_scratch/gambl/results_local/shared/gambl_genome_results.tsv")
sample_table <- collate_igblast_results(sample_table = sample_table)
[1] "Searching for MiXCR results in directory:/projects/nhl_meta_analysis_scratch/gambl/results_local/gambl/mixcr-1.2/01-mixcr/genome/"
[1] "Removing empty entries"
[1] "Removing rows that exceed missing threshold"
[1] "Joining tables"
Joining, by = "biopsy_id"
`

[x] I ensured all dplyr functions that commonly conflict with other packages are fully qualified.

This can be checked and addressed by running check_functions.pl and responding to the prompts. Test your code after you do this.

[x] I generated the documentation and checked for errors relating to the new function (e.g. devtools::document()) and added NAMESPACE and all other modified files in the root directory and under man.

Optional but preferred with PRs

[ ] I updated and/or successfully knitted a vignette that relies on the modified code (which ones?)

Checklist for New Functions
Required

[x] I documented my function using ROxygen style.)

[x] All parameters for the function are described in the documentation and the function has a decriptive title.

Example:
#' Use GISTIC2.0 scores output to reproduce maftools::chromoplot with more flexibility
#'
#' @param scores output file scores.gistic from the run of GISTIC2.0
#' @param genes_to_label optional. Provide a data frame of genes to label (if mutated). The first 3 columns must contain chromosome, start, and end coordinates. Another required column must contain gene names and be named `gene`. (truncated for example)
#' @param cutoff optional. Used to determine which regions to color as aberrant. Must be float in the range [0-1]. (truncated for example)

[x] My function uses a library that isn't already a dependency of GAMBLR and I made the package aware of this dependency using the function documentation import statment.

Example:
#' @return nothing
#' @export
#' @import tidyverse ggrepel

Checklist for changes to existing code

[ ] I added/removed arguments to a function and updated documentation for all changed/new arguments

[ ] I tested the new code for compatability with existing functionality in the Master branch (please provide a reprex of how you tested the original functionality)

@mannycruz is this ready to go or is it still in development?

@Kdreval Ready to go!


feat: Copy annotations from parent resource if not defined on pod

Fixes #67

Codecov Report

Merging #305 (d3e64d7) into main (3bc9405) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #305   +/-   ##
=====================================
  Coverage   5.03%   5.03%
=====================================
  Files          9       9
  Lines        794     794
=====================================
  Hits          40      40
  Misses       749     749
  Partials       5       5

Flag
Coverage Δ

keptn-lifecycle-operator
5.59% <ø> (ø)

scheduler
0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Mitosis Context docs example does not work

I am interested in helping provide a fix!
No
Which generators are impacted?

[X] Angular
[X] React
[X] Solid
[X] Svelte
[X] Vue

Reproduction case
https://mitosis.builder.io/?outputTab=E4UwhgxgLkA%3D&code=JYWwDg9gTgLgBAbzgYygUwIYzQYQgO2wA94BfOAMyghDgCIABAIwFdgAbAEzSgDpgIAehDAYEAM7BxdAFAzkBcfACyATzyE0JOAF4U6LLgLEYAHgBKaBVE6mlUYPgDmAGjgZ8qgHxwAPnHwWdnYvAAoEGTgUdmA0QgAuAKD2GVIASjktSFg4bgoMIPgKFnxkGAF8ODxwAjiYAHVRAAsNE1C0xEi4dBgWKErQrqjTNVatGF4ABWoAN2BuKDgZjHYWNB0EJAoICES6JgwoOjhSUi8hqLhTTmAZuEFzy6vBUeNxqdn5nke4DNIZIA%3D%3D
Expected Behaviour
Context.Provider should be recognized
Actual Behaviour
Context.Provider is not recognized.
Additional Information
I followed the exact instructions outlined here https://github.com/BuilderIO/mitosis/blob/main/docs/context.md. No matter what I do, I cannot get the Provider property on the context object to be recognized. Is there a specific version of Mitosis that I need to install??

@thedanchez are you on the dev or latest version of Mitosis? you want to use dev. We should actually start using latest because I know many folks get confused by this as well (the docs do not make that clear either)

The types might be lacking for Provider, but the JSX parser does handle it correctly AFAIK. Looking at the code that you are sharing, I see the Vue, React, Svelte, Solid code all parses Provider properly and sets context.
Is this just a types issue you are encountering?

For context, for whoever is interested in fixing the types: it's here: https://github.com/BuilderIO/mitosis/blob/2c01f46fdddce0adbd2f3a214375d67da9c94c37/packages/core/src/index.ts#L3
The object is empty. I believe we'll want to add a definition like so:
function Provider<T>(props: {
  value: T;
  children: JSX.Element
}): any {
  return null;
}

export type Context<T> = {
  Provider: Provider<T>
};

This is very hand-wavy, not sure if it's the exact right syntax! Can be inspired by our For/Show/Slot component definitions here: https://github.com/BuilderIO/mitosis/blob/2c01f46fdddce0adbd2f3a214375d67da9c94c37/packages/core/src/flow.ts#L1-L35

The types might be lacking for Provider, but the JSX parser does handle it correctly AFAIK. Looking at the code that you are sharing, I see the Vue, React, Svelte, Solid code all parses Provider properly and sets context.
Is this just a types issue you are encountering?

It's that and one other thing. I keep getting an error telling me that I'm in violation of https://github.com/BuilderIO/mitosis/blob/main/packages/eslint-plugin/docs/rules/no-var-declaration-or-assignment-in-component.md
This happens whenever I invoke useStore.
const state = useStore({ foo: new CustomObject(props.url, props.apiKey) });

@thedanchez, ah the ESLint rule has been updated to reflect useStore but now published yet. Will do that soon: it's a false positive


Added functionality for delimiting multi-line block by newline characters

See https://github.com/kyverno/kyverno/pull/1597.

https://github.com/kyverno/kyverno/releases/tag/v1.3.5-rc1


Single Node k3s cluster - Extra paragraph

on https://kairos.io/docs/examples/single-node/ on the last paragraph it refers to a write_files section of the cloud-init which is not reflected in the example give:
We use write_files to write manifests to the default k3s manifest directory (/var/lib/rancher/k3s/server/manifests/) see [docs](https://kairos.io/docs/reference/configuration#kubernetes-manifests) to deploy MetalLB and configure it with the <IP_ADDRESS>-<IP_ADDRESS> IP range. Make sure to pick up a range which doesn’t interfere with your local DHCP network.

But that stanza doesnt appear anywhere on the example in the page. Leftover, wrong text or missing lines in config?

guilty here... it was a leftover :sweat_smile:


Fix wobbly spinner

Adjusting the line-height to the font size seems to do the trick for me. I also adjusted the height so that the icon is aligned vertically with the text. I have only tested this in Safari and Chromium through the web inspector. #26

Preliminary tests in OSX Chrome and Firefox look good. A bit wobbly in Safari. Will need to test further in Tor and on Windows browsers, but I think this is better than what we had previously.


[AutoPR datamigration/resource-manager] Syncpublicpreview

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3567

(message created by the CI based on PR content)

Codecov Report

Merging #3066 into restapi_auto_datamigration/resource-manager will decrease coverage by <.01%.
The diff coverage is 37.83%.

@@                               Coverage Diff                               @@
##           restapi_auto_datamigration/resource-manager    #3066      +/-   ##
===============================================================================
- Coverage                                        57.43%   57.43%   -0.01%
===============================================================================
  Files                                             7781     7781
  Lines                                           158515   158518       +3
===============================================================================
+ Hits                                             91036    91037       +1
- Misses                                           67479    67481       +2

Impacted Files
Coverage Δ

.../azure/mgmt/datamigration/operations/operations.py
41.93% <0%> (ø)
:arrow_up:

...tamigration/operations/resource_skus_operations.py
39.39% <0%> (ø)
:arrow_up:

...mgmt/datamigration/operations/usages_operations.py
39.39% <0%> (ø)
:arrow_up:

...-datamigration/azure/mgmt/datamigration/version.py
100% <100%> (ø)
:arrow_up:

...mt/datamigration/operations/services_operations.py
41.97% <33.33%> (+0.19%)
:arrow_up:

.../mgmt/datamigration/operations/tasks_operations.py
55.47% <47.05%> (-0.41%)
:arrow_down:

...mt/datamigration/operations/projects_operations.py
63.39% <57.14%> (-0.58%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4feed5a...bae3ad7. Read the comment docs.

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/3213


Make filters object immutable

removing the v1 milestone from this as it might be a bit of more work than expected

This was fixed in #67


SDWebImage downloader hangs for ever if NSURL is 404 not found

I have created a method to download an array of images , the problem occurs when one of the NSURLs for images is 404 not found, the downloader seems to freeze for ever.
Here is a snippet of my code
-(void)downloadVenueMapsForVenueMaps:(NSArray*)venueMaps
   withDownloadImagesCompletionBlock:(DownloadImagesCompletionBlock)downloadImagesCompletionBlock{

    NSMutableDictionary* eventVenueMapDict = [[NSMutableDictionary alloc] init];
    NSMutableArray* eventVenueMapsArray = [[NSMutableArray alloc] init];

    if ([venueMaps count] > 0) {
        SDWebImageDownloader *downloader = [SDWebImageDownloader sharedDownloader];
        for (EventVenueMap* venueMap in venueMaps) {
            [downloader downloadImageWithURL:[venueMap eventVenueMapURL]
                                     options:0
                                    progress:^(NSInteger receivedSize, NSInteger expectedSize) {
                                        // progression tracking code
                                    }
                                   completed:^(UIImage *image, NSData *data, NSError *error, BOOL finished) {
                                       if (image && finished) {
                                           // do something with image
                                           [eventVenueMapDict setObject:image forKey:@"image"];
                                           [eventVenueMapDict setObject:[venueMap eventVenueMapTitle] forKey:@"title"];
                                           [eventVenueMapsArray addObject:eventVenueMapDict];

                                           if (eventVenueMapsArray.count == venueMaps.count) {
                                               downloadImagesCompletionBlock(YES,eventVenueMapsArray);
                                           }
                                       }
                                   }];
        }
    }

}

This issue should be fixed by #735 in version 3.7.0. Which version are you using?


API to handle drawing order

We need easy tool to manage drawing order of items.
Example applications:

move last touched item on top

Paper.js has following API for managing drawing order:

insertChild(index, item)
insertChildren(index, items)
insertAbove(item)
insertBelow(item)
sendToBack()
bringToFront()

The Paper.js API does not handle zIndex but an ordered list of items instead. TapSpace can use the same method, freeing us from juggling with zIndex.

HTML DOM Node has the following API for managing drawing order:

insertBefore(newNode, referenceNode)
nextSibling
previousSibling
lastChild
firstChild

Inkscape has following tooltips for its four drawing order tools:

Lower selection to bottom
Lower selection one step
Raise selection one step
Raise selection to top

Proposition for Tapspace ordering API and implementation approach given here. The new methods are tree operations and therefore should be implemented in AbstractNode.
Properties:

_next
_previous

Getters:

getNextSibling()

return this._next

getPreviousSibling()

return this._previous

lastChild()

return children[children.length - 1]

firstChild()

return children[0]

Manipulators:

insertBefore(item)

setParent(this._parent, this._parent._childrenOrder.indexOf(item))

insertAfter(item)

setParent(this._parent, this._parent._childrenOrder.indexOf(item) + 1)

bringToFront()

setParent(this._parent, 0)

sendToBack()

setParent(this._parent, this._parent._childrenOrder.length - 1)


Importing duplicates in same product under different engagement

Problem description
I am not sure if I am using DD as intended but the issue I am having is that duplicate issues are imported under the same produc(API1)s but different engagement(Sprint1 and Sprint2). If I close issues in Sprint1 and try to upload the same results in Sprint2 I get the same issues highlighted.
I am using trivy and grype scans uploaded via the API(between them I have no duplication as deduplication_on_engagement=True for /api/v2/import-scan/ is working). I have Deduplicate findings and  Delete duplicates set to true and Max Duplicates set to 0.
Please provide guidance  for this issue or how to approach this use case correctly
Deployment method

[ ] Docker Compose
[x] Kubernetes
[ ] GoDojo

Environment information

version 2.29.2
Mysql and Reddis

Hi @mrupnikm,
take a look here: https://defectdojo.github.io/django-DefectDojo/usage/features/#deduplication
If you have issues with deduplication, you should be more specific, e.g. name the parser and also add a sample scan file.
Also, you can ask in the slack channel.
This can be closed @mtesauro


[WIP] More impro

Sorry, didn't think you'd be up this early so I wasn't really clear about the other PR..
I'm doing some more improvisation...

[x] Tox
[x] Coverage
[x] Travis
[ ] Python 2.7, ~3.4~ and pypy broken
[x] Not understanding why scheduler and storage don't have __init__.py files to make them packages

Python 2.7, 3.4 and pypy is broken (because of using enum ?).

There's a backport available here: https://pypi.python.org/pypi/enum34
Can you add that as a dependency?

@aronasorman thanks for finding that, adding! Looks good, since it's pure python..

Tests now pass in Python 3.4

Seems we now have No module named queue in Python 2.7...

@benjaoming hmm it's probably been renamed between python 2 vs. python 3. Let me check the name

Yup, it's called Queue in python 2 and queue in python 3.

@aronasorman added 3 missing __init__.py files, any reason why they were missing? I don't actually understand why this was working in Py3 tests and not in Py2.. perhaps because of a weird way that find_packages works in setup.py?

>       assert isinstance(shutdown_event, threading.Event)
E       TypeError: isinstance() arg 2 must be a class, type, or tuple of classes and types

Apparently, in Py2, Event is a factory function, returning a new instance of threading._Event

@aronasorman sorry I can't pursue the Py2 stuff any further. The PR is growing too much :) I recommend that you use logging outputs in tests and add -s for pytest, which you can invoke outside of tox, provided that you do pip install -e . to get the latest requirements.
There are some threads/queues that never join, and then the following error that I think you'd be better at debuggin :)
✗ pytest -s tests/worker/backends/test_inmem.py
================================================================= test session starts =================================================================
platform linux2 -- Python 2.7.12, pytest-3.0.7, py-1.4.33, pluggy-0.4.0
rootdir: /code/barbequeue, inifile:
plugins: mock-1.6.0, cov-2.5.1
collected 3 items

tests/worker/backends/test_inmem.py .WARNING:barbequeue.worker.backends.inmem.WORKER[moon-oscar-spaghetti-spring]:Got exception for job simplejob: id() takes exactly one argument (0 given)
Exception in thread MONITOR-fanta-stairway-monkey-west:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/code/barbequeue/src/barbequeue/common/classes.py", line 94, in run
    self.main_loop(timeout=self.DEFAULT_TIMEOUT_SECONDS)
  File "/code/barbequeue/src/barbequeue/worker/backends/inmem.py", line 84, in main_loop
    self.receive_incoming_messages(timeout)
  File "/code/barbequeue/src/barbequeue/worker/backends/inmem.py", line 98, in receive_incoming_messages
    self.handle_incoming_message(msg)
  File "/code/barbequeue/src/barbequeue/worker/backends/inmem.py", line 109, in handle_incoming_message
    raise UnknownMessageError()
UnknownMessageError


Merge pull request #1 from apache/master

pull code
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.

pull

Can one of the admins verify this patch?

Can one of the admins verify this patch?

so sorry.this is a misoperation.  please ignore.


get_symbol_info in line 140 returns none in both Testnet and Spot

   @retry     def get_symbol_info(self, symbol):         return self.binance.get_symbol_info(symbol)
returns None
This leads to a TypeError: 'NoneType' object is not subscriptable error when you run
     store = BinanceStore(           api_key=BINANCE.get("key"),           api_secret=BINANCE.get("secret"),           coin_refer=COIN_REFER,           coin_target=COIN_TARGET,           testnet=True         )

Closed. Swapping my entries for COIN_REFER and COIN_TARGET fixed it.


feat: A possible way to deploy key vault, route tables etc and accompanying resources to different respective subscriptions in Lz vending loop

feat: A possible way to deploy key vault, route tables etc and accompanying resources to different respective subscriptions in Lz vending loop
I've incorporated the LZ Vending module into a for_each loop to enhance its usability. However, since the module autonomously manages subscription deployments, I'm seeking guidance on how to simultaneously deploy additional resources, such as key vaults, route tables, and network security groups (NSGs), alongside each landing zone associated with different subscription.
I would greatly appreciate any suggestions in this regard.

If you need anymore clarification on what I mean let me know, Im not most experienced with terraform so might not be crystal clear.

Hi!
Yes this is possible. You use the same loop value that you use for the sub vending as you do for the other resources.
The thing is that you have to use the azapi provider as you don't know the subscription id.

okay so just to clarify I can add key vault.tf , route tables.tf etc to the LZ_Vending module and get these resources to deploy to the same subscription id specified landing zone. The sub id will differ as the loop iterate, based on a object map.

Have you got any resources/examples I can look at for trying to achieve this using azapi provider?
Thanks for your help

Hi, you don't modify the lz_vending module, you use its outputs.
E.g. using your example above to create a resource group in each created sub. (this is an example, and actually the module does rg creation already, the RG is just is a simple resource to use as an example).
For Key Vault use this reference: https://learn.microsoft.com/en-us/azure/templates/microsoft.keyvault/vaults?pivots=deployment-language-terraform
You can add extra data to var.landing_zones
resource "azapi_resource" "symbolicname" {
  type      = "Microsoft.Resources/resourceGroups@2022-09-01"
  for_each  = var.landing_zones
  name      = each.value.rgname
  location  = each.value.location
  parent_id = module.landing_zones[each.key].subscription_resource_id
  body = jsonencode({
    properties = {}
  })
}

Thanks you alot for your help!  I will give this a shot

Hey Matt! Im having trouble accessing the output subscription_resource_id from the module. Im sure its something Im doing wrong. I can see the output when I dig into  .terraform /module/LZ_Vending.lz_vending directory but terraform cant access it maybe it got something to do with my directory structure?

@matt-FFFFFF  figured it out, worked like a charm, thanks for you help

Using the parent_id parameter assigned to each azapi resource you can link the additional resources to the subscriptions being vended. e.g.  parent_id  = "${module.lz_vending[each.key].subscription_resource_id}/resourceGroups/


fix sample hostendpoint policies in bare-metal docs for v3

Description
fix sample hostendpoint policies in bare-metal docs for v3
Release Note
None required

LGTM thanks @2ffs2nns 👍


generate DES-like images with realistic PSFs

PIFF seems like a promising way to fit PSFs:
https://github.com/rmjarvis/Piff/blob/main/examples/Tutorial.ipynb


Provide links on main page about sections of the website.

The front page needs to have details about the website.

Done.


TS 3.5 regression - objects aren't inferred

TypeScript Version:  3.5
Search Terms: protobuf
Code
import * as protobuf from 'protobufjs/light';

const root = new protobuf.Root();

export const protobufRoot = root.addJSON({
    hello: {
        nested: {
            Foo: {
                fields: {
                    permission: {
                        keyType: 'string',
                        type: 'int32',
                        id: 1
                    },
                }
            }
        }
    }
});

3.4 behavior:
No errors
3.5 behavior:
It seems like TypeScript isn't able to infer anymore that keyType implies that the value is of type IMapField. It expects it to be a IField, which doesn't contain this field.
index.ts:11:25 - error TS2326: Types of property 'nested' are incompatible.
  Type '{ Auth: { fields: { permission: { keyType: string; type: string; id: number; }; }; }; }' is not assignable to type '{ [k: string]: INamespace | IEnum | IExtensionField | IExtensionMapField | IType
 | IService; }'.
    Property 'Auth' is incompatible with index signature.
      Types of property 'fields' are incompatible.
        Type '{ permission: { keyType: string; type: string; id: number; }; }' is not assignable to type '{ [k: string]: IField; }'.
          Property 'permission' is incompatible with index signature.
            Type '{ keyType: string; type: string; id: number; }' is not assignable to type 'IField'.
              Object literal may only specify known properties, and 'keyType' does not exist in type 'IField'.

11                         keyType: 'string',
                           ~~~~~~~~~~~~~~~~~

Playground Link:
I didn't reproduce it without the protobufjs dependency.

Note that it might be a bug in the library - IMapField doesn't seem to be connected to IField so I would actually expect it to fail in both 3.4 and 3.5 .. but I'm not sure if I'm missing a TS feature that would explain why it works. I tried to repro with the following code, but it fails on both versions:
https://www.typescriptlang.org/play/#src=export interface IField {

    %2F** Field rule *%2F
    rule%3F%3A string%3B

    %2F** Field type *%2F
    type%3A string%3B

    %2F** Field id *%2F
    id%3A number%3B

    %2F** Field options *%2F
    options%3F%3A { [k%3A string]%3A any }%3B
}

%2F** Map field descriptor. *%2F
export interface IMapField extends IField {

    %2F** Key type *%2F
    keyType%3A string%3B
}

type Foo %3D {
  [key%3A string]%3A IField%3B
}%3B

function foo(foo%3A Foo) {}

foo({
  test%3A {
    keyType%3A 'string'%2C
    type%3A 'int64'%2C
    id%3A 1%2C
  }%2C
})%3B

We need a reduced repro that doesn't depend on an external .d.ts file in order to investigate this

Found a repro! I'm almost positive that it's a bug that got fixed, however. Replacing keyType with foo doesn't yield any error either in 3.4.
https://www.typescriptlang.org/play/#src=%2F** Field descriptor. *%2F
export interface IField {

    %2F** Field rule *%2F
    rule%3F%3A string%3B

    %2F** Field type *%2F
    type%3A string%3B

    %2F** Field id *%2F
    id%3A number%3B

    %2F** Field options *%2F
    options%3F%3A { [k%3A string]%3A any }%3B
}

%2F** Map field descriptor. *%2F
export interface IMapField extends IField {
    %2F** Key type *%2F
    keyType%3A string%3B
}

%2F** Namespace descriptor. *%2F
export interface INamespace {

    %2F** Namespace options *%2F
    options%3F%3A { [k%3A string]%3A any }%3B

    %2F** Nested object descriptors *%2F
    nested%3F%3A { [k%3A string]%3A AnyNestedObject }%3B
}

%2F** Any nested object descriptor. *%2F
type AnyNestedObject %3D (IType|INamespace)%3B

function fromJson(json%3A INamespace) { }

%2F** Message type descriptor. *%2F
export interface IType extends INamespace {

    %2F** Field descriptors *%2F
    fields%3A { [k%3A string]%3A IField }%3B

}

fromJson({
        nested%3A {
            Auth%3A {
                fields%3A {
                    permission%3A {
                        keyType%3A 'string'%2C
                        type%3A 'int32'%2C
                        id%3A 1
                    }%2C
                }
            }
    }
})%3B

See "Improved excess property checks in union types" in the release notes https://devblogs.microsoft.com/typescript/announcing-typescript-3-5/

Seems like it - when I replace:
type AnyNestedObject = (IType|INamespace);
// By
type AnyNestedObject = IType;

I get the expected error in 3.4 as well. Thanks for the explanation! 👍


Website/Hugo: Search template

Add searchbar to search template
Add google search cx ID to template
Overrule some google & base styles within search.scss
Add some custom lines to google script tag to get value of search parameter and set value in input to see currently searched term

Signed-off-by: Jorinde Reijnierse<EMAIL_ADDRESS>Test url: https://deploy-preview-299--cue.netlify.app/search/
For the broken icons on the preview url's we've created a new issue in Linear: CUE-128

cc @Lyoness

@Lyoness This is happening because of the icon issue with the previews because of the base url mismatch.
https://linear.app/usmedia/issue/CUE-128 & https://github.com/cue-lang/cuelang.org/pull/300
As we discussed yesterday in our meeting Paul will have a look at this to fix it the right way.

What is the scope of the search on Google? Just alpha.cuelang.org? Does it include GitHub?

@myitcv It's the same as the current cue-lang website. It seems to do both. I tried out some search queries and get both the website & github

This was merged in 7ffb5d0


TypeAdapter does not support V1 BaseModel

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
We are in the progress of migrating to Pydantic V2, and use a mix of V1 and V2 in the meantime. A class that previously only supported V1 type parsing using parse_obj_as should now support V2 models as well. From the documentation, the TypeAdapter appears to be the perfect solution to parse both version's BaseModel and non-BaseModel types. Unfortunately, it does not appear handle V1's BaseModel properly (see the code example below). Is this intended? Would it be possible to add support for this?
Example Code
from pydantic import TypeAdapter
from pydantic.v1 import BaseModel

class Item(BaseModel):
    id: int
    name: str

item_data = [{"id": 1, "name": "My Item"}]

items = TypeAdapter(list[Item]).validate_python(item_data)
# Traceback (most recent call last):
#   File "./test.py", line 18, in <module>
#     items = TypeAdapter(list[Item]).validate_python(item_data)
#             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#   File "pydantic/type_adapter.py", line 239, in validate_python
#     return self.validator.validate_python(__object, strict=strict, from_attributes=from_attributes, context=context)
#            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# TypeError: BaseModel.validate() takes 2 positional arguments but 3 were given

Python, Pydantic & OS Version
pydantic version: 2.5.3
        pydantic-core version: 2.14.6
          pydantic-core build: profile=release pgo=false
               python version: 3.12.3 (main, Apr  9 2024, 08:09:14) [GCC 13.2.0]
             related packages: pydantic-settings-2.2.1 typing_extensions-4.11.0 mypy-1.10.0

@Aed3r,
Thanks for reporting this. We don't currently plan on adding support to TypeAdapter for V1 models - we're trying to reduce our V1 oriented changes given that V2 has now been out for about a year.
Going to close this as not planned for now.
If you're interested / think it'd be helpful, feel free to open a docs update PR that adds a note about this to the migration guide :).


States of tasks following over when dragged in the TaskBoard

Currently when a task is dragged and dropped its checked and expanded states don't copy over.

Due to the way the react-beautiful-dnd library works, the checked and expansion state of draggable items is currently associated with the index of the task item rather than the id. The use of index can be seen in TaskBoardColumn where tasks are mapped to an index when the component gets returned. This means that checking the top item in a column then dragging it to a new position will cause the task item that takes its place to become checked instead. This behavior is the same when dragging expanded items.


fix(schema): fix nullable decorator and mixed type usage

Information
Closes: #2735

Type
Breaking change

Fix
No

Todos

[x] Tests
[x] Coverage
[x] Example
[x] Documentation

:tada: This PR is included in version 7.75.4 :tada:
The release is available on:

v7.75.4
GitHub release

Your semantic-release bot :package::rocket:


HA for chainlink node and eth1

In k8s in two availability zones
chainlink nodes reference both eth1, using private network, no TLS
chainlink nodes both reference the same PGSQL DB with DB lock
Test failover scenarios

Tested and working


Modify getting started example for version 4.0

@beenanner try closing and reopening the PR to trigger a new build.

Thanks @ilanbiala I closed and reopened the pull-request

Looks good. Thanks!


Merge pull request #6

John's-branch

Second Onboarding screen

There are no changes to the file from your pull request. Please confirm!


Duplicate clients appear in admin dashboard

I believe this is due to https://github.com/BuoyantIO/linkerd/pull/836

These duplicates are tricky to remove because the stats that they're generated from look like perfectly valid concrete names.  For example:
"rt/http/dst/id/#/io.l5d.fs/cat/path/http/1.1/GET/cat/requests": 1

This is a duplicate of the /#/io.l5d.fs/cat client but it could just as well have been a legitimate client called /#/io.l5d.fs/cat/path/http/1.1/GET/cat.  We can notice that the former is a prefix of the latter, but there's still no reason the latter could not be a legitimate client as well.


Idiomatic Java timestamps (#180)

Proposal for changing the API surface area with respect to passing timestamps
into and out of the API, leveraging the (long, TimeUnit) tuple pattern than
was introduced in and encouraged after JDK 1.5.
Intended as a discussion point for Issue #180.

Coverage increased (+0.4%) to 74.503% when pulling e4e436b983c9e9081a4ee3ab8455c1f5f8775fa8 on mcumings:master into a0fc80516b3ad1ce8fd45e7d0fc27529ea3b0c0b on opentracing:master.

Coverage decreased (-1.3%) to 72.816% when pulling ed35ff7401b989bd26492a1065c96d0ec217964f on mcumings:master into a0fc80516b3ad1ce8fd45e7d0fc27529ea3b0c0b on opentracing:master.

Coverage increased (+2.3%) to 76.375% when pulling e60107b81bc84f1056f8b3f6bf8395344a514fa6 on mcumings:master into a0fc80516b3ad1ce8fd45e7d0fc27529ea3b0c0b on opentracing:master.

I think this is a positive change... somewhat complicated in that TimeUnit usually seems to be reserved for durations (and "duration since the epoch" honestly seems like bulls**t to me... that's pretty much the definition of an absolute timestamp). Nevertheless, constructing Date objects feels like overkill here, and the precision information in the TimeUnit is genuinely useful (esp when transcoding millisecond- or second-granularity data).
I'd propose we merge this in 72h if there are no objections. cc @pavolloffay @yurishkuro since you've looked already.

+1
I don't share the concerns about "duration" vs. "timestamp". Every programmer understands the notion of a timestamp expressed as a number of some time units since epoch. Rather than insisting on one specific time unit that can only be seen from documentation, we're letting the caller specify it and making the API self-describing. In other words, I don't see why span.finish(timestampMicros) is less or more confusing than span.finish(timestamp, TimeUnit.Micros). Both are the unfortunate consequence of inefficient type system that doesn't allow creating strongly typed, allocation-free value+unit combos.

@pavolloffay I just saw your comment on #180... WDYT? Are there reasonable alternatives that (a) allow the caller to specify units, (b) support microsecond precision, and (c) don't involve excess allocations?

My first concern is that TimeUnit is from java.util.concurrent and it is used to model timeouts in various units. For timeouts/scheduled things it makes sense, however, I haven't seen this class being used for timestamps in JDK or any 3rd party library.
Does it make sense to use TimeUnit for timetamps?
Would anybody use following? And how it would call it? There is no easy way how to get minute/hour/day timetamp in java.
span.finish(val, TimeUnit.DAYS);
span.finish(val, TimeUnit.HOURS);
span.finish(val, TimeUnit.MINUTES);
span.finish(val, TimeUnit.SECONDS);

honestly when I see this API without reading the javadocs I think that val is span duration and not timestamp (my primary language is java, so I judge based on my previous experience).
Small example how to get timestamp in seconds:

System.currentTimeMillis() / 1000
TimeUnit.SECONDS.convert(val, TimeUnit.MILLISECONDS)
almost the same applies for other units (the first will be even more awkward).

The most natural timestamp units in java are milliseconds, therefore all APIs are defigned to work weel with them.
I don't see benefits in this API change. It's confusing and more error prone to pass less precise value or even think about it as a span duration.
@mcumings do you have any specific use-case where this API chage simplify usage?

@pavolloffay I agree that the more natural unit would be milliseconds, but the current API is defined as microseconds, not milliseconds, which I think is very confusing and error prone in the java landscape given that it will always require a conversion.  This also means that we can't change the units over to milliseconds without a difficult API change.
Regarding TimeUnit.SECONDS.convert(val, TimeUnit.MILLISECONDS)...
First I prefer calling the specific convert method for the units I want toMillis as I think that is more intuitive than just convert.
Second I generally like to static import TimeUnit.* which gives us something like SECONDS.convert(val, MILLISECONDS).
Third, the origin unit will be passed in as an argument in most cases, so the static import would be less necessary, as it would look something like this:
public void myMethod(long duration, TimeUnit units) {
    long durationInMicros = units.toMicros(duration);
    // do the rest as you would with the previous API.
}

The use case is documented in the issue and in the tests associated with this PR. i.e., it is the specific case you identified: "the most natural timestamp units in java are milliseconds".  But an OpenTracing API cannot assume that all consumers and implementors would be okay with losing precision by only working in milliseconds and thus we need a way to specify the data along with its precision.
We could do as you suggested and add an additional method call for each level of precision that we'd like to support, thereby binding the precision up with the method name.  This expands the API surface area and would (IMHO at least) feel quite clunky.  e.g., Should we add an additional set of methods throughout the API as well in order to support nanosecond precision when an implementation desires it?
At the base of your argument against the use of time units appears to be the fact that the core JDK does not internally use TimeUnit for anything other than time deltas.  I think this is a bit chicken and egg.  I'm not aware of any APIs added to the JDK in Java 7 that would required such a specification.  NIO would be the closest but filesystems don't support sub-millisecond precision (i.e., even millisecond precision has been a problem for some OSes).  Java 8 introduces Instant which we both agree would be a better choice but we cannot leverage due to API compatibility levels.
I'm definitely open to alternate suggestions but I think that TimeUnit is a well understood construct, provides the consumer the ability to specify whatever useful precision they want, and preserves the implementation's ability to use the greatest precision possible.
I think the "duration" versus "timestamp" definition split is overly pedantic but if we want to go that route, System.currentTimeMillis() is documented as a "difference" between two timestamps.  A difference between two instants of time is what?  A duration. 😄

Regarding TimeUnit.SECONDS.convert(val, TimeUnit.MILLISECONDS)...
First I prefer calling the specific convert method for the units I want toMillis as I think that is more intuitive than just convert....

This is just a syntactical sugar... It conceptually does not change anything from what I said.
We cannot define new finish method with the same name e.g. span.finish(long millis), the only way to do it is to change the name e.g. span.finishMilli() like here.

@pavolloffay are you suggesting that instead of this PR, we change the API to look like this:
span.finish(System.currentTimeMillis() * 1000); //<-- the deprecated method that takes micros
span.finishMillis(System.currentTimeMillis()); // <-- new method that takes millis instead of micros

While that is an improvement, I still think the API change proposed in this PR is better.

Ported this PR to target v0.31.0 here: https://github.com/opentracing/opentracing-java/pull/200

I think log(long timestamp, TimeUnit timestampUnit, ...)  is problematic in a way as the unit is only a single one. Let me explain.
Before that, I don't think this has to do with the name timestamp vs duration(since start of the span).
The problem I see is that this effectively does not have a way to say "3h2m4s20ms" other than providing this in the smallest possible unit, which could be millis or even nanos (JDKs these days all have a nano-second timer).
If you consider millis here, then you'd need to translate the above int millis and then call log(12335,TimeUnit.MS), where the time unit in reality will always be TimeUnit.MS and thus is redundant.


Improve PyLint Score

Is your feature request related to a problem? Please describe.
Current PyLint score is 8.18.
Describe the solution you'd like
A PyLint score of >9.0
Describe alternatives you've considered
N/A
Additional context
Must not result in a breaking change for backend_cli.py
See recent PyLint actions run for more details:
https://github.com/euanwm/OpenWeightlifting/actions/runs/3260823388/jobs/5354728255#step:5:1

To be clear, all Python files are located within the python_tools folder. There is an abundance of code that is unused and could probably be removed.

Can you assign me this issue?


enabling sparkup inside *.html.twig (htmljinja) files

Hi there!
Is there any way to enable sparkup inside file types other than *.php, *.html and such?
Thanks in advance

this issue is duplicate from #33


Some file are missing

Hi,
I'm trying to install the package but some errors occurs, i've laravel/framework ^8.65, rezaamini-ir/laravel-easypanel ^1.8, breeze for login manager and below all step executed:
composer require laravel/laravel laravel-easypanel.dev.local
composer require laravel/breeze --dev
php artisan breeze:install
npm install && npm run dev
composer require rezaamini-ir/laravel-easypanel

Here i've created sqlite db, added is_superuser type boolean on user migration, create a seed wirth only one user as admin, next steps:
php artisan panel:install
php artisan migrate:fresh --seed
php artisan panel:add 1

I see the panel when i go to /admin, but if i try to create CRUDs from panel and i've got an error

So i try to perform crud from console and i run:
php artisan make:model -crfm Article
php artisan panel:config Article

This return message:
Article config file was created for Article model
You can manage it in : app/CRUD/ArticleComponent.php and then run
php artisan panel:crud article

but i've got this other error

In other issue posted i've seen that the folder structure after package installation are bit different, in the resource/view folder i've only vendor, and i can't see the cruds for the user, the attachments below show up my folder structure after run all of the commands above.

And another thing is that if i try to run php artisan panel:migration and then i run php artisan migrate an then set 'todos' => true to config/easy_panel.php i've got this

What can i do for this?
Thank you!

Do you use 1.8.1 version with GUI?

No, i have the 1.8.0 installed, but if i try to add version constraint to composer.json to 1.8.1 i've got this error:
Your requirements could not be resolved to an installable set of packages..
How can i update package?
Thanks.

Something has a conflict with the new version.
Please add more detail of the error or re-install package with the new laravel project.

I've tested on fresh laravel installation, i've tried to update package from command with composer update rezaami-ir/laravel-easypanel:"^1.8.1"

And i have add ^1.8.1 version constraint to composer.json and try to run composer update

From both clear laravel and easypanel installation which command i should run for update package to 1.8.1?
Thank you

Hmm, please try this command:
composer update rezaamini-ir/laravel-easypanel --no-cache

Oh... great!
Now it's work, but only from GUI, from shell cruds creation throw an exception, but now i can see the package, good!
Thanks for help!


Fix two Ignored Problematic json tests

Fixes two ignored package.json tests. Both tests should throw exceptions.

Let's just remove these two tests. In v4.5 of newtonsoft.json they were testing that parsing worked. The fact that they throw an exception now isn't particularly significant since we're not going to take any action if they stop throwing an exception (other than changing the test back again :wink:)

Done


Change autoscale triggers to be within a desired capacity range

https://ocd.appscale.com:8080/job/Daily Build/3285/

@jeanleonov Regarding the capacity usage bit, I can see how it tends to be a little confusing. But what we were trying to go for is the to check what capacity has the system achieved, and we have a range as to what would be the desired capacity we want the system to have. And if above the max threshold, then we assume the system needs more AppServers and autoscale it. And if capacity seems low and not doing much now then we downscale it. Is that helpful, what do you suggest? Maybe change the terminology?

https://ocd.appscale.com:8080/job/Daily Build/3294/

Recreating with different branch.


Accessing the Maestro UI

Hi everyone,
I have successfully set up and run Maestro following the provided instructions. The CLI commands are working perfectly for creating, triggering, and managing workflows. However, I am unsure how to access the Maestro UI for a more user-friendly experience.
Could someone provide detailed steps or documentation on how to access and use the Maestro UI? Specifically, any information on:

Accessing the UI:

Is there a specific URL or port to access the UI?
Do I need to configure any additional settings in the application.yml or other configuration files?

UI Features:

What features are available in the UI for managing workflows?
Any screenshots or usage examples would be greatly appreciated.

Troubleshooting:

Common issues and their resolutions when trying to access the UI.

If the UI is not yet documented or fully developed, I would be interested in contributing to this aspect of the project. Any guidance on where to start or existing branches/work in progress would be helpful.
Thanks to the contributors for this excellent tool! Looking forward to enhancing its usability further.
Best regards,
LumosTech

It seems there is no UI now.

Hi @LumosNexus, Thanks a lot for your interest! Maestro UI is not there yet. We have an issue #3 for it.
We might first get it started by directly creating a simple single page UI powered by SpringBoot directly. But I am also open to have a powerful UI with its own backend as well, which might need bigger efforts.


Assignment of new instructor recruitment process

When a new instructor recruitment process is opened, the recruitment process should be assigned to the same person that the event itself is assigned to.
Additionally, we should have the option to change who it is assigned to, just as we do for the event itself.
If the event assignee changes, the recruitment assignee should also automatically change.

@pbanaszkiewicz @elichad  is there any other information needed to implement this feature?

@maneesha this requirements seems clear, you can decide which milestone you want this in.


bad require external libraries "react" and "react-dom"

the requires in dist/react-openlayers.umd.js shoud be "react" and "react-dom" instead of "React" and "ReactDOM"

This has been fixed, please retest


raftstore-v2: adaptive manual flush rate

What is changed and how it works?
Issue Number: Ref #12842
What's Changed:
Lift up manual flush rate when total flush rate is high.

Related changes
Check List
Tests

Unit test

Release note
None

/release

/release

/release

Benchbot sysbench shows no difference.

/merge

/run-test retry=5


Support JSON format input for tags

Is your feature request related to a problem? Please describe.
If the tag parameter passed in the script contains spaces, the parameter input will be cumbersome.
Relevant issues: #10798 #13170
Describe the solution you'd like
For this scenario, it is more convenient for customers to input tags in JSON format.
Describe alternatives you've considered

Additional context

JSON format for tags

--tag should support the use of a json input as follows
{
"Agency": "OCIO",
"Application": "Azure",
"Description": "RG for testing policies",
"FinancialPOC": "John Smith",
"Name": "policy-testing-rg",
"PMO": "Dan White",
"Program": "Cloud Operations",
"Purpose": "RG for testing policies",
"Service Request": "None",
"TechnicalPOC": "Steven Fowler",
"Workload-Type": "Resource Group"
}


Add transaction_context object to Computation

Creating a PR to track this work in progress. From #262.

Perfect. Thanks. That's what I meant.
On Fri, Feb 9, 2018 at 02:13 Piper Merriam<EMAIL_ADDRESS>wrote:

@pipermerriam commented on this pull request.
In tests/json-fixtures/test_state.py
https://github.com/ethereum/py-evm/pull/327#discussion_r167021733:

@@ -295,6 +302,8 @@ def test_state_fixtures(fixture, fixture_vm_class):
computation, _ = vm.apply_transaction(transaction)
except ValidationError as err:
transaction_error = err

   LOGGER.warn("Got transaction error:")

There is no TransactionError in py-evm that I know of so I'm not entirely
sure what you're referring to here.
In the case of this section of code, yes, transactions can error and
the tests still pass because some of the tests are designed to throw
errors, testing invalid transactions do not succeed to execute in the EVM.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ethereum/py-evm/pull/327#discussion_r167021733, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADKbNGzWdqEsPjFZphXUQjDx5E9c72N2ks5tSzk0gaJpZM4RxcMt
.


Restructure

@jeffbaumes PTAL.
I cannot spell separate correctly. I even changed it from the first (correct) spelling to this one. Oh well.


Authorization | Cancel Recommended Credit Balance Changes (Validation/Award/Reduction) |5|

https://trello.com/c/HadsYv1o/571-authorization-cancel-recommended-credit-balance-changes-validation-award-reduction-5
Story:
As the Director, I want to be able to cancel a Recommended credit balance change (Validation/Award/Reduction) without officially Declining the recommendation so that the Branch has the ability to correct mistakes in the balance change recommendation.
Scenario:
GIVEN that I am an Organization
AND my organization type is Government
AND my role is the Director
AND I have received a Recommended credit balance change from a Government Analyst
AND the Government Analyst is recommending approval
AND the Government Analyst made a mistake in the details of the recommendation
WHEN I am viewing the recommended credit balance change in TFRS
THEN I am able to see a Cancel/Go Back button
AND when I click on the Cancel/Go Back button
THEN the Recommendation gets sent back to the Government Analyst who made the original recommendation.
Note:
This task was added after B. Finn identified a potential gap in the branch's processing of credit balance changes within TFRS. The gap: If a government analyst makes an error when inputting the details of a credit balance change, and fails to correct the error before sending the recommendation to the Director, then the Director can only Decline the recommendation. This is problematic because Declining a recommendation makes the transaction visible to the Fuel Supplier Organization. We need to have a mechanism where the Branch can correct mistakes without the Director having to Decline the Recommendation.
Demo:
Show the Cancel / Go Back button on Recommended credit balance changes (as the Director)
Show that when the Cancel / Go Back button is used by the Director that the Recommendation is returned to the analyst
Show that the Cancel / Go Back button is not available to any other role in the TFRS system

 Authorization | Cancel Recommended Credit Balance Changes (Validation/Award/Reduction) |5|


Add LB DNS examples under the second (more advanced) docs/input-manifest/providers/examples

For example, for GCP, there are two examples. A simple one, and a more complex one.
The more complex one might as well already include an LB + DNS.

related to https://github.com/berops/claudie/issues/835


AWS LZ1 Upgrade to v1.5

Describe the issue
ASEA v1.5 has been released. This releases addresses issues related to security hub, that limit the number of subscribes accounts to 50.
Which Sprint Goal is this issue related to?

Note: 'Milestone' is a ZenHub term that we use synonymously with 'Sprint'.

The 'Milestone' description (created in ZenHub) should clearly list Sprint Goals. This section should indicate which 'goal' this issue is related to.
Additional context

Max and Jon will do the upgrade in LZ1, with Warren's support.
Part of this ticket is also reading through the upgrade documentation and for Jon and Max to familiarize themselves with the document.

https://github.com/aws-samples/aws-secure-environment-accelerator/releases/tag/v1.5
Upgrade Guide : https://github.com/aws-samples/aws-secure-environment-accelerator/blob/main/docs/installation/installation.md

Definition of done

Coordinate with Ryan J and Warren
LZ1 upgraded to 1.5
Create a new project set
Deploy and Test a demo app

Machine swap added time to this


Local Shortcut conflig with other plugin, can we change Local Shortcut?

Hi!
I have another plugin also has shortcut key of Ctrl + T for their job. Unfortunately, this plugin has not been developed anymore. Can we have an option to allow changing Ctrl + T shortcut to customer one, just like the global shortcut key?
Thank you so much!

Hey @cheatmo,
sure, this should be an easy one.
I'm very busy at the moment. Please stay patient.
Kind regards
tiuub

Hello @cheatmo,
I have implemented your enhancement.
Check out the new version 1.5.8.
Kind regards
tiuub

Work beautifully!
Thank you so much!


INT-B-21506

Agility ticket
Summary
This story was created to handle the common error cases when updating the port for a service item. By the time I got around to working this story I realized that all the common error cases were already handle in the upstream story for updating the port (B-21505). This story will still be used for testing these error cases so the testing load on B-21505 isn't too high. Since there was no validation code needed for the port error handling we decided to use this story to update the port locations model to be readonly as this reflects the current business rules which weren't settled on until recently.
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test
Note: the functionality for ordering POEFSC and PODFSC service items does not yet exist. Therefore in order to test you will need to manually create either a POEFSC or PODFSC service item for a shipment.

Create an INTL UB shipment as a customer (CONUS -> AK or AK -> CONUS)
Manually create the mto_service_items table for the shipment: INSERT INTO mto_service_items (  				id,                  mto_shipment_id,                  move_id,                  re_service_id,                  status,                  created_at,                  updated_at,                  approved_at              )              VALUES (              uuid_generate_v4(),                  '8eeba537-bb40-4f58-a534-74ea9ff64590',                  '813b7a43-2e3f-42f3-8c4e-eca95390d5ca',                  '388115e8-abe9-441d-96cf-a39f24baa0a3',                  'APPROVED'::service_item_status,                  NOW(),                  NOW(),                  NOW()              );
In the prime v3 api, call getMoveTaskOrder using the move_id for the service item you created in step 2. You will need the etag for the newly created service item for the next step.
In the prime v1 api, call updateMTOServiceItem using a payload like this (adjust for you specific service item ID): { "id": "40b7e71a-6b03-4413-8601-dea694253ee3", "modelType": "UpdateMTOServiceItemInternationalPortFSC", "portCode": "ABC", "reServiceCode": "PODFSC" }
Verify that you receive an error response like this:  { "detail": "Unsupported port code (ABC): No port location found for port code ABC", "instance": "cffb4ea1-311b-4842-bdf3-bfad74e6f722", "title": "Validation Error", "invalidFields": {} }
In the prime v1 api, call updateMTOServiceItem using a payload like this (if you're service item is for PODFSC, pass in POEFSC and vice versa): { "id": "af98b57c-f3dc-46c2-b12e-0e42ba221b02", "modelType": "UpdateMTOServiceItemInternationalPortFSC", "portCode": "PDX", "reServiceCode": "POEFSC" }
Verify that you receive an error response like this: {    "detail": "ID: af98b57c-f3dc-46c2-b12e-0e42ba221b02 is in a conflicting state POE Location can only be updated for service item POEFSC",    "instance": "6c023056-221b-46bd-b1bb-c2e8cf0dd231",    "title": "Conflict Error" }
In the prime v1 api, call updateMTOServiceItem using a payload like this{ "id": "af98b57c-f3dc-46c2-b12e-0e42ba221b02", "modelType": "UpdateMTOServiceItemInternationalPortFSC", "portCode": "PDX", "reServiceCode": "IUBPK" }
Verify that you receive an error response like this: { "title": "Validation Error", "instance": "bd14418a-b11f-4409-be69-26df3fc29c08", "detail": "reServiceCode in body should be one of [PODFSC POEFSC]" }

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Prime V1


508: Identification of an element across pages is inconsistent

The Lefthand links for read-only and editing are named the same. Suggest adding an Aria labeled by to indicate the Workspace links.
Issue: Add aria-label to differentiate between the options under the Global-View and the Workspace
Global-View (Add aria-labels as below):
Monitoring Plans - Global-View
QA & Certifications - Global-View
Emissions - Global-View
Workspace (Add aria-labels as below):
Monitoring Plans - Workspace
QA & Certifications - Workspace
Emissions - Workspace

Aria labels have been properly implemented, closing ticket


TestBdxTransferSession tries to read out of packetbuffer bounds

Problem
In TestBdxTransferSession.cpp, VerifyStatusReport does:
    Encoding::LittleEndian::Reader reader(msg->Start() + headerSize, msg->DataLength());

This is starting reading headerSize bytes into the data, but still claiming the full data length is available to be read, which seems wrong.
Proposed Solution
Consume headerSize bytes first, then just pass Start() as the first arg.  Or subtract headerSize from the data length if we don't want to change the packet buffer state.  Or something.
@holbrookt

Thanks for catching this. My goal with this line was to parse the data in the message without doing Consume() because the same message may be passed to a HandleMessage() method after this, so the Start pointer needs to be set to the beginning of the header.
I'll subtract headerSize from the data length like you suggested


register ssw method on w3c method registry

DID core 문서: https://w3c.github.io/did-core/
Register 경로: https://github.com/w3c/did-spec-registries
DID methods: https://w3c.github.io/did-spec-registries/#did-methods
Registration Process: https://w3c.github.io/did-spec-registries/#the-registration-process

SSW DID Method Specification 리포지토리 생성
https://github.com/sktston/ssw-did

문서 작성완료
https://sktston.github.io/ssw-did/did-method-spec.html

w3c/did-spec-registries 에 PR 올림

https://github.com/w3c/did-spec-registries/pull/312
merge 완료
W3C DID methods : https://www.w3.org/TR/did-spec-registries/
SSW DID method: https://sktston.github.io/ssw-did/did-method-spec.html


Deprecate probability distribution circuits

Summary
Deprecate probability distribution circuits, LogNormalDistribution, NormalDistribution, and UniformDistribution.
Details and comments
Deprecate probability distribution circuits and move them to Qiskit finance (https://github.com/Qiskit/qiskit-finance/pull/11)

Hi Matsuo-san, can you put the exact import path in the deprecation warning instead of just saying "in Qiskit finance" ? 🙂

Hi Julien, sure. I added the exact path qiskit_finance.circuit.library.probability_distributions. I also changed the word "an alternative" (You're right. I just copied the message from somewhere without thinking xD )


Change throwOnError to expectError

The TestHarness.exec method takes a throwOnError with a default value of true. Let's replace it with an expectError flag with a default value of false, to clarify the intent of the flag.

if expectError is true and the process returns with exit code 0, it should throw an error and fail the test
if expectError is true and the process returns with exit code 1, it should return the output and status code
if expectError is false and the process returns with exit code 0, it should return the output and status code
if expectError is false and the process returns with exit code 1, it should throw an error and fail the test
the default value of expectError should be false

Thanks, sounds good! It's clear now.


[SPARK-37903][PYTHON] Replace string_typehints with get_type_hints

What changes were proposed in this pull request?
Replaces string_typehints with get_type_hints.
Why are the changes needed?
Currently we have a hacky way to resolve type hints written as strings, but we can use get_type_hints instead.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.

Before this PR
>>> from pyspark.pandas.typedef.typehints import infer_return_type
>>> infer_return_type(max)
Traceback (most recent call last):
  File "/usr/lib/python3.9/inspect.py", line 1162, in getfullargspec
    sig = _signature_from_callable(func,
  File "/usr/lib/python3.9/inspect.py", line 2334, in _signature_from_callable
    return _signature_from_builtin(sigcls, obj,
  File "/usr/lib/python3.9/inspect.py", line 2145, in _signature_from_builtin
    raise ValueError("no signature found for builtin {!r}".format(func))
ValueError: no signature found for builtin <built-in function max>

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/u02/spark/python/pyspark/pandas/typedef/typehints.py", line 568, in infer_return_type
    spec = getfullargspec(f)
  File "/usr/lib/python3.9/inspect.py", line 1171, in getfullargspec
    raise TypeError('unsupported callable') from ex
TypeError: unsupported callable

after this PR
>>> from pyspark.pandas.typedef.typehints import infer_return_type
>>> infer_return_type(max)
ScalarType[DoubleType]

Should we change to raise Exception or keep default return value is ScalarType[DoubleType] ?
@ueshin @HyukjinKwon

I think it's correct to infer the type from max. does it cause any problem?

oh, okay, max doesn't have a return type hint. we should raise an exception


Schema Compare Extension - no differences found when there should be

Situation:
Comparing two Azure SQL Single Databases using SQL Authentication (Admin account).
Error:

It keeps saying that no differences were found while I'm 100% sure there are a lot of differences. I enabled debug logs as well but no logs were created at all.
All help is appreciated!

Can you try comparing the two databases using the SSDT Schema compare and see if any differences are found?

Hi Kisantia,
Thanks for your reply! Unfortunately, also using the SSDT schema compare it's not working. I receive the following 'strange' error:

Any idea to help me troubleshooting this would be great. But I guess it's not really related to the Schema Compare Extension but more to the database itself?
Kinds regards

@Dvnoten thanks for reporting the issue. the 'DABO' permission is added to DacFx and will be in next release of DacFx.

@Dvnoten the DABO permission is now in the DacFx version in ADS. Can you try using schema compare again?

@kisantia thank you for the update. I updated the SSDT extension in VS and the Azure Data Studio client but the issue remains the same. I still get the DABO permission warning in VS as illustrated above and in Azure Data Studio I still don't see any results using schema compare. Could you tell me how I can maybe better troubleshoot the exact issue or did I forgot to update something maybe?

@Dvnoten The new DacFx bits might not be in the SSDT yet, which is why the DABO permission is still there. Would you be able to share the dacpacs of the databases so we can debug this?

@Dvnoten any update on this?

@kisantia I'm sorry for the late response. Unfortunately due to copyrighted content of a client I cannot share the dacpac files. This would expose some stored procedures and logging mechanisms that I may not share explicitly. I can try to create a dacpac file by excluding some objects but don't know if this is helpful for you.

@Dvnoten sure it would be helpful if you can create two dacpacs that repro this behavior so we can debug this.


Added check for QNX define when using in_pktinfo.ipi_spec_dst

Added check for QNX define when using in_pktinfo.ipi_spec_dst

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 61 days ago

Can you please sign a cla so that we can review and potentially accept this issue

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

Why is the bot reporting an incorrect status? This PR needs a CLA, not OTC action - although TBH to me it looks like it could be accepted as trivial - it's extending a #if presumably based on a compiler error

I think the bot response is just an artifact of which label it checks first.  As for trivial, I'm honestly not sure

As for trivial, I'm honestly not sure

In which case @klausholstjacobsen can you sign and submit a CLA so we can review and hopefully accept this contribution?

Yes, will do!

Was the CLA submitted? IMO this would be clearly OK with CLA: trivial as well.

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically,alternatively please review and set the label manually.

@t8m Agree trivial.

Merged to the master, 3.4, 3.3 and 3.2 branches. Thank you for your contribution.


Issue when java.util.List is used in @ConfigurationProperties and @RefreshScope

Hi spring could team,
I've encountered a problem when a list of values from yml file is mapped to java.util.List in a bean which is @ConfigurationProperties and @RefreshScope.
This issue is when the list values in yml changes and /refresh is done on the client.
New additions and changes to existing entries in list works fine when refreshed but if an entry is removed from yml list - it is never getting updated in the bean property on refresh.
config yml
test:
  configurationProperties:
    myList:
      - value1
      - value2
      - value3

Java Bean
@ConfigurationProperties(prefix="test.configurationProperties")
@RefreshScope
public class ConfigReader {
    private List<String> myList;
........

When value3 is removed from the yml file and /refresh is posted, myList will still have values value1, value2, value3

Where is the YAML file? In a config repo, or locally in the app?

I tested this by placing the yaml locally in app and config server. Both cases if we remove an entry from yaml the same is not getting removed from List when refreshed.
Thanks.

It works for me. Can you share a project with a minimal set of features to reproduce the problem?

Thanks. Please refer https://github.com/deepzGitHub/RefreshList
This is a simple spring boot application were the yaml file is kept locally. Check README.md for the testing scenarios and steps.

Your RefreshListConfig isn't actually in @RefreshScope. You can put that annotation on a type, but it only has an effect if the type is component scanned. You would have to component scan it, or declare a @Bean (with @RefreshScope).

Thanks.
Issue #1,
As you suggested I defined  RefreshListConfig as @Bean in RefreshListApplication and it worked. But i noticed one issue, I have a logic that needs to be executed whenever this List gets changed. I had written that logic in @PostConstruct method in RefreshListConfig  assuming when an http POST on /refresh is done the config change will be initialized before the post construct is executed. When /refresh is done PostConstruct method is executed but at that time the List still has old value but when the reference of RefreshListConfig bean is used in another bean as part of next request it's updating correctly in PostConstruct method. Is that expected behavior?
Issue #2,
If I used a second configuration class to define RefreshListConfig  @Bean which is @RefreshScope, and import that configuration using @Import in main configuration class or ComponentScan that configuration class in main configuration class, the list is not getting updated.
This scenario is needed when I have to include a refresh-scoped bean in a dependent library and use with another spring boot application.
I have updated this scenario in https://github.com/deepzGitHub/RefreshList
Please share your thought on both. Thanks

Regarding #1 that is the expected behaviour. There is an event you can consume if you want to know which properties changed during a refresh.
Regarding #2, I don't see any problem with the @Import. Check again, and let us know with more detail if something isn't working (steps to reproduce, or a test case).

Regarding Issue #2 I still feels there is an issue when an entry is removed from List.
I have detailed all the scenarios to replicate the issue in https://github.com/deepzGitHub/RefreshList
List refresh (addition and deletion) works perfect when ComponentScaned ONLY from the java configuration where the Bean is defined
Few Scenarios where the list is getting messed up when some entries are removed
Case 1 -
Component Scan is on a java configuration class present in a package other than the package where RefreshScope bean is defined. (Since the configuration class is in root folder technically it scans all the folders below it)
Case 2 -
The java configuration which defines the refresh scoped bean is scanned twice (One from the Configuration class present in the root of the source package and second scan is from the java configuration where refreshscope bean is defined.)

None of that makes any difference for me. Your app works fine. It does print out the list twice, and the first time is wrong if the list shrank, but that's the way the @PostConstruct is called (once on the old object, and once on the refreshed one).

Hi Dave,
I'm ignoring the PostConstruct issue but when it is used in the Controller,
the list still has the deleted entries as mentioned in the Test case
scenario. Please let me know if you are getting the correct response in
browser.
On Jul 16, 2015 12:17 PM, "Dave Syer"<EMAIL_ADDRESS>wrote:

None of that makes any difference for me. Your app works fine. It does
print out the list twice, and the first time is wrong if the list shrank,
but that's the way the @PostConstruct is called (once on the old object,
and once on the refreshed one).
—
Reply to this email directly or view it on GitHub
https://github.com/spring-cloud/spring-cloud-config/issues/183#issuecomment-122026008
.

@deepzGitHub is this still an issue for you?

Closing for lack of feedback.

Hi,
I don't know if you guys appreciate the update, but i have a similar or even the same issue.
We have a spring config server which pull's its configuration from a git repository. In the same project we have a component which we configure by a yaml file. This yaml file contains a few hundred (e.g. 500+ entries) entries with each multiple properties.
All of these entries are added to a database when the app reload or restart. This was firstly done by purging the database content and overwriting it with the entries the app got from the config server.
We're encountering performance issues when we're running the app twice or triple, as for every restart the database (which is really frequently used) is emptied and filled up again.
To fix this, we did use the entries and/or properties, check if there are some changes and update the database.
When we add one or more entries, this works as expected (for a restart as well as a reload of the app).
When we delete one or more entries, a restart works fine. But when we reload the application, it's complaining about double entries (which is always the last entry in the properties file).
We think the following happens:
1: We delete one entry (something in the middle, not the lasT) from the config.
2: We reload the app
2b: Spring updates it's array from zero to the max number of entries, note that the number of entries are decreased.
2c: Spring stops updating the array when she reaches the last properties entry in the yaml file.
2d: Spring complains about a double property, what makes sense if the array is never cleaned up, but got only an update. So every value moves one place up (until the 'gap' that was created by removing an entry has filled up), and the last value from the previous config does stil exists. This results in an array which have two double entries at the end. So for example entires[514] and entries[515] are the same.
As i think this is supposed to work, entries[515] should be deleted, as this is not a valid properties entry anymore. It's not declared anymore, so it's not needed and should not persist in the array.

@spencergibb I did updated the issue, could you reconsider this issue please?

I don't think that's anything to do with the original issue here. Please put your @ConfigurationPorperties bean in @RefreshScope and try again. Ask questions in StackOverflow, or gitter.

Hi, I'm facing the same issue. After some investigation, it seems the problem comes from org.springframework.beans.AbstractNestablePropertyAccessor used to update value.
The method processKeyedProperty supports in-place replacement ou new entry. The remove element is not handled :
                    int size = list.size();
		if (index >= size && index < this.autoGrowCollectionLimit) {
			for (int i = size; i < index; i++) {
				try {
					list.add(null);
				}
				catch (NullPointerException ex) {
					...."': List does not support filling up gaps with null elements");
				}
			}
			list.add(convertedValue);
		}
		else {
			try {
				list.set(index, convertedValue);
			}
			catch (IndexOutOfBoundsException ex) {
				.... ex);
			}
		}

Where list is the current value of property.
Here is a use case when we remove an item
If I have a property
toto:

A
B
C

then I change it to
toto:

B
C

After checking if modification occured,  the ContextRefresh publishes new EnvironmentChangeEvent(context, keys) where keys are in format toto[0] = B .... toto[1]= C
When the rebinder consumes the event it triggers (it's a shortcut) bindPropertiesToTarget ... so processKeyedProperty processes the key  toto[0].
In the previous piece of code list variable has the current size 3 and index correspond is 0 so runtime executes a list.set(...) <-- in-place replacement.
Same thing is done with the key toto[1].
Finally, at the end of the rebind, list instance is made of 3 items
1rst with value B (new value of the 1rst entry)
2nd with value C (new value of the 2nd entry)
3trd with value C (unchanged property)

@RaphC while List and refresh are common to this issue, I think it is unrelated, please open a new issue with steps to recreate the problem (a project would be even better).

Hi @spencergibb , ok. I will create a new issue with gist and step to recreate.


Fix Buffer deprecation warning

Fix #23
Fixed (node:1301) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Used Variant 1 from Node.js documentation

@sturman  thank you.


Can you please release a new tag 1.5.0

Hi jpuri,
When i tried to use "npm install html-to-draftjs" , i am getting v 1.4.0 and when i checked the dist folder file it is showing me the "april 25th 2018" dated file. This file doesn't have latest changes of the module.  Can you please release a newer version of this package asap. We can fix couple of issues in our application.
Thanks,
Jaffar

Can we bump this up as this is blocking our release? Thank you so much.


Component label + local service definition

Most importantly (and trivially), this PR adds a component label to the pods that are part of the daemonset.  Without this label it is impossible to target the agent pods with any selector (the other parts of the chart have component labels).
Secondly, it defines an (optional) service resource targetting the pods in the daemonset and using a "local" internal traffic policy (This tells kube-proxy to only use node local endpoints for cluster internal traffic).  This is useful because pods that have no way to be configured with the node ip can use the entry.

Hi, @mr-miles. Thanks for your contribution. The change itself LGTM.
The problem is that it changes immutable fields (daemonset selector labels), which breaks the helm upgrade, and users will have to reinstall their daemonsets.
We will need to migrate all the labels to the recommended naming conventions anyway, so I think if we can go through that only once and avoid doing it this time additionally.
What if we just add the component: otel-agent pod label only and keep the selector as is? The service selector should work well, right?

Thanks @jinja2 @dmitryax - have done that and checks looks more healthy.  Didn't know about the daemonset selectors being immutable so learnt something too :-)

Please run make render to generate examples

Make render worked but the cri-o test is still complaining, not sure how to sort that though

Looks like a flaky test. I restarted it

Hi  @jinja2  @dmitryax - wondering if it is possible to revive this PR?  I think it just fell between the cracks.
I have just freshened it up by rebased it onto main and re-rendered the examples.
Alternatively please let me know if its no longer useful.

I think we can still go ahead with this PR. But I am wondering if we should make settinghostNetwork for the daemonset optionally false (default will still be true) possible with the PR. I can see users running non-hostmetrics receivers leveraging this service option and wanting to not run in the hostnetwork. @dmitryax wdyt?

@mr-miles can you run make render to regenerate examples?

hmm not sure why it closed the PR ...
but I have rebased and "make render"-ed so should be good


Mod Options - Intermodule Interaction

I had an idea while integrating ModLib today.
What about an attribute we can set on a property to signify a 'link' to another mod.  For example BannerTweaks and TournamentsXP share some of the same features.  If we could link our settings so if it is toggled on in yours, it gets toggled off in mine and vice/versa it may make mod compatibility easier for the end user.

That is a very good suggestion. I'll have a think and see what I can come up with.


How to use resnet18 as the backbone?

Hello, I want to use resnet18 as the backbone. To achieve the results of Table 5 in your paper,  what parts do I need to modify in the code? Or if you can provide the checkpoints under resnet18, I would be very grateful!

Using ResNet-18 as an example, if you want to use layer1+layer2+layer3, you can modify L12~L14 in run-mvtec.sh as follows:
    -b resnet18 \
    -le layer1 \
    -le layer2 \
    -le layer3 \

That's right. To achieve the result of resnet18 in Table 5, you only need to modify L12 to:
    -b resnet18 \


decK v1.1.0 not supporting mtls_auth_credentials

deck does not support mtls_auth_credentials on a consumer.
I am attaching a kong.yam which causes the folliwing error when used with deck v1.1.0:
Error: reading file: validating file content: 1 errors occurred: 	consumers.0: Additional property mtls_auth_credentials is not allowed
using kong config db_import kong.yaml works with the same file
kong.yaml.txt

We are adding support for this via #175.

Added in https://github.com/hbagdi/deck/commit/b1b6633f1296346168dcc2b8d003367f9fcff03c


⚠ Mobitopup has degraded performance

In a15008b, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 3049 ms

Resolved: Mobitopup performance has improved in 22344a4.


Run almost all jobs --detach

jupyter, filebrowser, develop don't need to be attached

only training should be attached.

already done


Regarding scale

Can you explain why you're using a separate scale function when batch norm scales the output anyway?

You can refer to this thread: https://github.com/flyyufelix/DenseNet-Keras/issues/5


Generic library rules

This patch implements the suggestion by @angerman in #538 -- to "register" the rules for building libraries (.a, .so, .dylib, etc) without having to parse any Cabal file. This dramatically decreases the "boot" time of hadrian and will, as soon as we address the problem I describe below, allow us to use the -c option again.
Instead of defining a whole bunch of precise rules for <build root>/stage<N>/<path/to/lib/in/ghc/tree>/build/libHS... for each package, we just define catch-all rules for each type of library (extension, really) and use simple parsec parsers (parsec is already a dependency, through Cabal, since ghc 8.4.1 / Cabal 2.2) to deconstruct the path and basically turn it into a suitable library Context.
The remaining issue: I still seem to be able to build a GHC just fine if I run the ./boot && ./configure step myself explicitly, but not if I start from a clean source tree and run hadrian with -c. The error I get in that case is:
...
[hadrian/cfg/system.cfg, settings, mk/config.h]
about to need ["hadrian/cfg/system.config.in","settings.in","mk/config.h.in"]
about to run ./configure
in doWith
builder ready
shakeArgsWith                      0.000s    0%
Function shake                     0.272s   65%  =========================
Database read                      0.001s    0%
With database                      0.000s    0%
Running rules                      0.140s   33%  ============
Pool finished (14 threads, 4 max)  0.000s    0%
Total                              0.414s  100%
Build system error - indirect recursion detected:
  Key value 1:  OracleQ (KeyValue ("hadrian/cfg/system.config","host-os"))
  Key value 2:  hadrian/cfg/system.config
  Key value 3:  hadrian/cfg/system.config settings mk/config.h
  Key value 4:  OracleQ (KeyValue ("hadrian/cfg/system.config","project-version"))
Rules may not be recursive

(the first few lines come from debugging output I added -- see the patch)
Does anyone have any idea of where that cycle comes from and why my patch makes this happen?

Try running with -j1 and you might get a better description of the cycle.

@ndmitchell Thanks for the tip! In this particular case though it doesn't seem to unlock a more precise description:
$ hadrian/build.sh -c -j1 --trace
Up to date
Up to date
[hadrian/cfg/system.cfg, settings, mk/config.h]
about to need ["hadrian/cfg/system.config.in","settings.in","mk/config.h.in"]
about to run ./configure
in doWith
builder ready
shakeArgsWith                     0.000s    0%
Function shake                    0.315s   80%  =========================
Database read                     0.000s    0%
With database                     0.000s    0%
Running rules                     0.077s   19%  ======
Pool finished (1 threads, 1 max)  0.000s    0%
Total                             0.393s  100%
Build system error - indirect recursion detected:
  Key value 1:  OracleQ (KeyValue ("hadrian/cfg/system.config","host-os"))
  Key value 2:  hadrian/cfg/system.config
  Key value 3:  hadrian/cfg/system.config settings mk/config.h
  Key value 4:  OracleQ (KeyValue ("hadrian/cfg/system.config","project-version"))
Rules may not be recursive

Now, if we carefully look at the error, we see that hadrian wants the config file for the host-os setting (line 1), so it then starts looking for a rule to produce it as it doesn't exist on a clean tree (line 2), it then finds the rule from Rules.Configure that produces it, along with the settings and mk/config.h files. Finally, that rule apparently ends up requiring the project-version setting from the config file.
The debugging output I added suggests that hadrian errors out when executing this line:
doWith :: (Builder b, ShakeValue c)
       => (b -> BuildInfo -> Action a)
       -> (Target c b -> Action ())
       -> [(Resource, Int)] -> [CmdOption] -> Target c b -> Args c b -> Action a
doWith f info rs opts target args = do
    putLoud "in doWith"
    needBuilder (builder target)
    putLoud "builder ready"
    argList <- interpret target args          -- /!\ HERE /!\
    putLoud $ "args: " ++ show argList
    trackArgsHash target
    putLoud "args hash tracked"
    info target
    putLoud "target info printed"
    verbose <- interpret target verboseCommand
    putLoud "target interpreted"
    let quietlyUnlessVerbose = if verbose then withVerbosity Loud else quietly
    quietlyUnlessVerbose $ f (builder target) $
        BuildInfo { buildArgs      = argList
                  , buildInputs    = inputs target
                  , buildOutputs   = outputs target
                  , buildOptions   = opts
                  , buildResources = rs }

@alpmestan Thanks for the PR! I'm running from one meeting to another today, will hopefully find more time to have a look at it later today :)

Alright, -c is fixed by https://github.com/snowleopard/hadrian/pull/571/commits/502e2c3184278b00dc9ff84953397df3d6c339fc. I switched all the .travis.yml scripts to using it again. I left the appveyor one alone as Windows currently requires that distro toolchain switch to ./configure and I don't think our configure rule currently has that logic. I'm leaving this out, to be fixed whenever we get rid of the need for the distro toolchain flag.
Now, let's see how the travis tests go.

@alpmestan Looks like we still have some cyclic rules failure on AppVeyor:
Error when running Shake build system:
* _build/stage1/lib/package.conf.d/integer-gmp-<IP_ADDRESS>.conf
* _build/stage1/libraries/integer-gmp/build/HSinteger-gmp-<IP_ADDRESS>.o
* _build/stage1/gmp/include/ghc-gmp.h
* _build/stage1/gmp/.libs/libgmp.a
Build system error - key matches multiple rules:
  Key type:       FileQ
  Key value:      _build/stage1/gmp/.libs/libgmp.a
  Rules matched:  2
Modify your rules/defaultRules so only one can produce the above key

Full build log: https://ci.appveyor.com/project/snowleopard/hadrian/build/1.0.1076

This isn't a cyclic value error, it's overlapping rules - way easier to fix. Just find which patterns match and adjust one.

@ndmitchell Ah, indeed!

@snowleopard Alright, the selftest + the 3 builds that we do on travis all succeed! Modulo that weird error at the end (Lint checking error - 14 values have changed since being depended upon: ...).

@alpmestan Looks like we still have some cyclic rules failure on AppVeyor:

I'll look into this.

OK, trying something for the error you mentionned above. See last commit.

Alright, the selftest + the 3 builds that we do on travis all succeed!

@alpmestan Indeed! 🎉 After the fix in #574 this will hopefully succeed on AppVeyor as well :)

End of the build log on appveyor:
/--------------------------------------------------------------------------\
| Successfully built program 'haddock' (Stage1).                           |
| Executable: _build/stage1/bin/haddock.exe                                |
| Program synopsis: A documentation-generation tool for Haskell libraries. |
\--------------------------------------------------------------------------/
Writing report to -
* This database has tracked 1 runs.
* There are 19178 rules (19178 rebuilt in the last run).
* Building required 4255 traced commands (4255 in the last run).
* The total (unparallelised) time is 59m58s of which 53m47s is traced commands.
* The longest rule takes 1m37s (_build/stage0/compiler/build/HsInstances.o _build/stage0/compiler/build/HsInstances.hi), and the longest traced command takes 1m36s (ghc.exe).
* Last run gave an average parallelism of 1.64 times over 32m50s.
shakeArgsWith                       0.001s    0%
Function shake                      0.387s    0%
Database read                       0.001s    0%
With database                       0.000s    0%
Running rules                    1969.551s   99%  =========================
Pool finished (926 threads, 2 max)  0.002s    0%
Lint checking                       1.013s    0%
Profile report                      0.228s    0%
Total                            1971.182s  100%
Build completed in 32:52m
cd ..
_build/stage1/bin/ghc -e 1+2
'_build' is not recognized as an internal or external command,
operable program or batch file.
Command exited with code 1

Should we not cd there?

Woohoo!
Indeed, looks like we need to fix ApoVeyor script. Would you like to do that?

Windows requires foo\bar for command lines to run for the first component. Shake cmd changes foo/bar bar/baz to foo\bar bar/baz inside, but if you are running on Windows directly you'll need to swap the slash on the executables.

Indeed, looks like we need to fix ApoVeyor script. Would you like to do that?

Sure. It's just weird that we have to remove cd .. all of a sudden, isn't it? Anyway, pushed a commit that tries just that.

Did the appveyor build get killed?

@alpmestan I've left a couple of minor comments, but overall this PR looks great, thank you! I'm looking forward to simplifying other build rules following the same approach :)

Hmm, the appveyor build fails with:
_build\stage1\bin\ghc -e 1+2
ghc: could not execute: gcc
Command exited with code 1

@alpmestan I guess this failure could be fixed after #564, so let's not bother about it for now.

@snowleopard I think I'm done addressing your feedback.

@alpmestan No, looks great -- merged. Thanks again :)


Some container nodes are not displayed all the time

Report

What view is this? The container view?

This is a dupe of #1130


& and r commands are not working

Your & and r math commands stopped working man hope you can get them running again pretty oon i use them a lot in my combats and non-combat stuff with my players

Hello! Thanks for the report. Looking into it now.

I think I have found the issue.
As a workaround until the fix goes out, it should be possible to ping rollem to perform the path like @rollem 20+20

This is now going out to shards 1-20 and 30 as a hotfix for the previous release.
Please let me know if anything else has gone wrong.


[Bug]: Parameters for POST, PUT, PATCH, DELETE missing for all access-list plugin endpoints in Swagger

NetBox access-list plugin version
v1.5.0
NetBox version
v3.7.5
Steps to Reproduce

Install netbox-acls on NetBox v3.7.5.
Log in to NB.
Open Swagger interface ("REST API documentation").
Select any of POST, PUT, PATCH, or DELETE for any endpoint.

Expected Behavior
Swagger will list the parameters for these methods.
Observed Behavior
Swagger shows "No parameters" for these methods or just "id" for endpoints that have "id" as an endpoint parameter.
Please note that it's still possible to use all of the above methods with pynetbox, the API isn't broken. However, the Swagger interface doesn't display parameters the way it should. It's not a permission issue, this effect also holds true for superusers.

It seems like this is a general nb issue. I'll investigate and come back with the results.


Grid onDeleted Not Being Called

onDeleted is not being called for a w2ui grid.  jsfiddle is here:
http://jsfiddle.net/appliedsd/cwvv2p7u/3/

I see in the changelog that this was removed in version 1.5, but the docs are still online.

Yes, it was removed. However, http://w2ui.com/web/docs/w2grid.onDeleted says that it is called when server responds back after records where deleted. In your jsFiddle it is local data, not remove. In this case you can just use onComplete loop of the event.
With server side, it will work. Just checked.


Fix deprecation warnings from upb

First attempt at a PR, which I am quite certain will fail a great many CI tests but hopefully we can fix them all easily enough.

Closing for now, will return with a clean patch soon.


Variables & Types

Here's how I imagine Polygolf typing and scoping should work.
Types
Top types
Types that don't have any proper supertype. Every type is a subtype of exactly one top type. These are

Int
Text
(List TMember)
(Table TKey TValue)
(Func Tout Tin1 Tin2 ...)
Void

All of these types can be used as types of variables and nested as type arguments of other types, except for Void - this can only be a type of an expression and it is never nested.
(I removed Array = a subtype of List should be used instead, and Set - poor support and not that much important).
Subtypes
Top types have subtypes, similar to now.
(List TMember) has subtypes (List TMember TLength) and a special internal type EmptyList - the only type that has multiple tops as supertypes. The only value with the EmptyList type is (list) and this type nor any type containing it cannot be used as a type of a variable.
Variable declarations and scopes
Each variable must be declared before it is referred to. There are three ways to declare a variable:

Annotation on the variable node in an assignment node.
Such variable can be read from and written to anywhere in following siblings of the block or in descendants of those.
Only expressions with a subtype of the declared type can be written to this variable. Expressions read from this variable are guaranteed to types that are subtypes of the declared type (but might be narrower, based on the context).
The type in the declaration can be omitted, in which case the top supertype of the assigned type is used, unless it contains the EmptyList type. $i:<-0; is equivalent to $i:Int<-0;.
Loop variable of a for loop. Such variable is readonly and can only be read from in the body of the loop and in all descendants of the body and the type of the expression will be a subtype of the type of members of the passed list.
Arguments of a function. Such variable can only be read from and the type can either be annotated on the argument or on the variable that this function is assigned to.

Referring to un undeclared variable is an error.
Redeclaring a visible variable is an error (no shadowing).
Declaring a variable twice in two disjoint scopes is fine.
Variable type narrowing
On each assignment in addition to checking that the type of the assigned expresion is a subtype of the declared type, the assigned type is stored and used whenever the variable is read between this and the next assignment. Control flow analysis should be used to determine what "between" means.
The union of all the assignments to a variable is calculated and defines the "global inferred type" of the variable. This will sometimes be equal to the declared type and sometimes be a proper subtype. The global inferred type of a variable can be used to determine the target type in the target language (for example using arrays instead of list, bounded int instead of bigint etc.).
Conditions (If, While, ConditionalOp) can be used to further narrow the types of variables inside of them.
Type annotations
One, already described function of type annotations is declaring variables.
The other is narrowing inferred type of expressions. Type on a expression overrides the inferred type of that expression, provided it is its subtype, otherwise is an error.

Since functions are contravariant on their input types, one can create arbitrary function supertypes by using argument subtypes. Solutions?

Accept the fact that a top for a given type is not unique. It's already broken for EmptyList anyway.
Allow function input types to only be top types. This will inevitably widen the output types of the functions. On the other hand, when examining the type of a result of a function call, we might want to look inside the definition of the function to calculate a narrower type. This requires the function variable to be constant, but should we even allow reassignment to variables of type function? Should functions even have type in this case? Should they just be some kind of "macros" instead?

Is there no boolean type?
Some notes:

Desmos "functions" are actually macros. So f(L) = L[5];     f([1,2,3]) can compile without needing to infer L as a list in the definition of F. This ends up working well-enough in general.
It's reasonable to put special cases for EmptyList. But you might need to infer a "top" for every EmptyList variable. E.g. in Python, x = []; x.append(5). A strongly-typed language would need to infer the type of x ((List Int))  at the declaration time of x.

Is there no boolean type?

Ig Bool might be a synonym to 0..1 instead of a distinct type, but I actually just forgot to mention it.

But you might need to infer a "top" for every EmptyList variable. E.g. in Python, x = []; x.append(5). A strongly-typed language would need to infer the type of x ((List Int))  at the declaration time of x.

That's why I disallowed variables of type EmptyList and omitting the declared type if the RHS includes the EmptyList type. Anything else, seems like unnecessary complication.

Superseded by #383 Variables & Types 2