How can get alert(email notification) when error appear

Question
Hi, I use  logfire in project in production, I really like it, but I don't get notifcation when error appear, so it's a little bite difficult to always look to see if that has error or not.

I'll be working on this on the next week. I'll give updates.

Ok thanks, so waiting

@Kludex, update here?

@dmontagu Is working on alerts. He'll post an estimation here in a few hours.

This is duplicated of https://github.com/pydantic/logfire/issues/80.
Please follow that issue instead.


Sanitize app prefix for sample component name

Fixes
https://issues.redhat.com/browse/HAC-2212

Description
Sanitize app prefix for sample name.

Type of change

[ ] Feature
[x] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review
https://user-images.githubusercontent.com/20013884/192333268-c362a05a-4834-4525-8445-2273eaafad18.mp4

How to test or reproduce?
Create a sample app in an application with whitespace in it's name.

Browser conformance:

[ ] Chrome
[x] Firefox
[ ] Safari
[ ] Edge

/cc @rohitkrai03 @sahil143

/retest

/retest

/retest


Task/cat/add more logging

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: catherinetcai
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@catherinetcai: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Hi @catherinetcai. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: catherinetcai
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: douglas-reid
If they are not already assigned, you can assign the PR to them by writing /assign @douglas-reid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Apologies this was a mistake, thought I was creating this against our fork. GH UI said it was doing it against our fork and that still didn't happen once I clicked submit 🤦♀


Observers array is always packed regardless of element count

This happens because the function update-pack-count has the check for element count inverted.

Fixed


Add property at caret, please?

From FVTT-Autocomplete-Inline-Properties created by mkahvi: schultzcole/FVTT-Autocomplete-Inline-Properties#12
While testing the module, I discovered it adds the properties at the end of the string in input boxes. Could this be changed to do it at caret location?
It was rather annoying to be writing a formula, going back to fill in attributes to discover the attribute was appended to the end of the entire thing, not where I started typing it.

Yeah, this is something I initially wanted to do but ran into trouble when dealing with selections. I'll look in to adding this.


collectionEntity orderby Id_desc

Describe the bug
Order By id desc has a weird behavior on collectionEntity
To Reproduce

https://squid.subsquid.io/stick/graphql

query MyQuery {
  collectionEntities(limit: 50, where: {issuer_eq: "DT7kRjGFvRKxGSx5CPUCA1pazj6gzJ6Db11xmkX4yYSNK7m"}, orderBy: id_DESC) {
    id
  }
}

show 97 first while this account has created 101, 107 etc..

Expected behavior
107 > 101 > 97
Screenshots

Additional context
I like sports

I think it's the behaviour of psql we can do a resolver for that and map ids as numbers

I think it's the behaviour of psql we can do a resolver for that and map ids as numbers

Nah.. IMO it's because id are string instead of numbers, could be doable if we cast this column or change type to integer

So it would mean that bsx and ah* will have numbers where rmrk and evm string?

So it would mean that bsx and ah* will have numbers where rmrk and evm string?

Oh... nvm, I've forgot we were talking about collectionId.
That doesn't mean we can't type id to integer only for bsx & ah*, best would be to have same type as the one declared in pallet.

I just thought we could solve this problem by sorting by block number, and we'll get the expected result.


DR16 Fail State Timeout On Empty Packet

Need to implement fail state setting when there is a lack of packets. This needs to be done once the main timing system is set.

This has been fixed in the "Add Safety Code" pull request. Timeout is 250 ms.

This has been fixed in the "Add Safety Code" pull request. Timeout is 250 ms.


The PKCS7_verify interface does not support the PSS padding algorithm.

When I use the PKCS7_verify interface to verify RSA-PSS-signed data, it fails.
I checked the implementation of PKCS7_verify and found that when verifying the certificate chain, it read the signature padding algorithm flag from the certificate signature info and then initialized padding_mode by this flag.
But for image data signature verification, the context is initialized based on the key type of the public key, and pad_mode is set to PKCS7#1 v1.5 by default. The verification fails.
The data signature verification context init as follow:
pkctx = EVP_PKEY_CTX_new(pkey, NULL);
if (pkctx == NULL)
    goto err;
if (EVP_PKEY_verify_init(pkctx) <= 0)
    goto err;
if (EVP_PKEY_CTX_set_signature_md(pkctx, EVP_MD_CTX_md(ctx)) <= 0)
    goto err;
i = EVP_PKEY_verify(pkctx, sigbuf, siglen, m, m_len);

pkctx is initialized by pkey. The padding algorithm flag digest_enc_alg is not used. If the signaure algorithm is RSA, the pad_mode always initialized as RSA_PKCS1_PADDING.

marking as inactive, will be closed at the end of 3.4 dev barring further input


Fix/mk1 faceplate

Added required overlays and disabled onboard sound

You need to have the Bluetooth chip to be connected over the mini-UART which makes the full UART available for the Arduino. This can not be done dynamically when already in userspace. This has to be done at boot from config.txt so the GPIO pins are already routed the proper way.
https://github.com/OpenVoiceOS/ovos-buildroot/blob/develop/buildroot-external/board/ovos/raspberrypi/rpi3/config.txt#L48
Secondly, you need to make sure the linux console is not also talking to the full UART by making sure you do not have a console=serial or console=ttyAMA0(they are symlinked to each other via udev in userspace). Remove it completely or send it to console byconsole=console``` which is default if not present.
That way teh Bluetooth is switched over do different GPIO pins, the linux console is not talking to it, making the ttyAMA0 fully available fot the Arduino board attached to those GPIO pins.


Fixing all php styles recursively

Updating PHP styles recursively.
As the build is currently broken we want to verify that this PR won't break things. The styles that are changing are set in stone, but please check this out and request changes if you think something will change the behaviour of the code in a way it will break.

/pullapprove-test ```yml
version: 3
pullapprove_conditions:

condition: "base.ref == 'master'"
unmet_status: failure
explanation: "PullApprove is not configured for this branch"
condition: "'[DO NOT REVIEW]' not in title"
unmet_status: pending
explanation: "Not ready for review"
condition: "'[NO REVIEW]' not in title"
unmet_status: pending
explanation: "Not ready for review"
condition: "'No Review' not in labels"
unmet_status: pending
explanation: "Not ready for review"
condition: "'Do Not Review' not in labels"
unmet_status: pending
explanation: "Not ready for review"
condition: "state == 'open'"
unmet_status: failure
explanation: "PR must be open to be reviewed"
groups:
min_global_approvals:
conditions:

"'dependencies' not in labels"
labels:
pending: ❐ Review
approved: ✓ Review
rejected: ✘ Review
reviews:
required: 3
request: 3
request_order: shuffle
reviewers:
teams:

Back-end
Testing
DevOps:
conditions:

"'dependencies' not in labels"

'.circleci/' in files or
'bin/' in files or
'docker/' in files or
'google/' in files or
'sandbox/' in files or
'.dock' in files or
'.env*' in files or
'.git*' in files
reviews:
required: 1
request: 1
request_order: shuffle
reviewers:
teams:

DevOps
Back-end:
conditions:

"'dependencies' not in labels"

'app/' in files or
'bootstrap/' in files or
'composer.json' in files or
'composer.lock' in files or
'config/' in files or
'craft/' in files or
'database/' in files or
'dictionary.dic' in files or
'jobs/' in files or
'public/' in files or
'routes/' in files or
'src/' in files or
'sql/' in files or
'.go' in files or
'.php' in files or
'*.sh' in files
reviews:
required: 1
request: 1
request_order: shuffle
reviewers:
teams:

Back-end
Front-end:
conditions:

"'dependencies' not in labels"

'gulpfile.js' in files or
'package.json' in files or
'resources/' in files or
'webpack.mix.js' in files or
'yarn.lock' in files or
'.blade.php' in files or
'.css' in files or
'.gif' in files or
'.html' in files or
'.jpg' in files or
'.js' in files or
'.less' in files or
'.scss' in files or
'.ts' in files
reviews:
required: 1
request: 1
request_order: shuffle
reviewers:
teams:

Front-end
Testing:
conditions:

"'dependencies' not in labels"
reviews:
required: 1
request: 1
request_order: shuffle
reviewers:
teams:

Testing
dependabot_php:
labels:
pending: ❐ Review
approved: ✓ Review
rejected: ✘ Review
conditions:

"'dependencies' in labels"
"'php' in labels"
reviews:
required: 2
request: 2
request_order: shuffle
reviewers:
teams:

Back-end
dependabot_js:
labels:
pending: ❐ Review
approved: ✓ Review
rejected: ✘ Review
conditions:

"'dependencies' in labels"
"'javascript' in labels"
reviews:
required: 2
request: 2
request_order: shuffle
reviewers:
teams:

Front-end
min_global_approvals_5:
conditions: ["len(groups.active) == 5"]
reviews:
required: 0
request: 4
request_order: shuffle
reviewers:
teams:
Front-end
Back-end
Testing
min_global_approvals_6:
conditions: ["len(groups.active) == 6"]
reviews:
required: 1
request: 4
request_order: shuffle
reviewers:
teams:
Front-end
Back-end
Testing

QA Local
@BKorenek and @HLCharlie this has been for a while in Pre-Prod but not sure which Issue is this linked to. Also it seems is not testable given the repo of the PR. Please guys help us to confirm if we can move it to D&T, thanks.

QA Local
@BKorenek and @HLCharlie this has been for a while in Pre-Prod but not sure which Issue is this linked to. Also it seems is not testable given the repo of the PR. Please guys help us to confirm if we can move it to D&T, thanks.

@juliohl this isn't attached to an issue at all so it's kind of impossible for it to be in pre-production column. There are no action items on this PR it is a placeholder I have.


Image Widgets: auto-detect aspect ratio for ImageOverlayManager, make ImageWidget default

This PR includes two changes to the ImageOverlayManager and ImageWidget:

ImageOverlayManager now auto-detects the aspect ratio of the image to be displayed so that there is no more black borders at the top and bottom of the image
ImageWidget can be initialised hidden
ImageWidget is now the default for the toggle button in the user interface. The rationale behind this is that we often record videos with an image overlay on only to realise afterwards that it's a black spot instead of the video
The source of an ImageWidget can be changed without having to re-initialise the object

Pat, there are two remaining issues that I'd like to get your input on:

ImageWidget has unused padding left and right of the image, yet I could not find the right vtk command to get rid of it
ImageOverlayManager had a better image quality than ImageWidget does

Thanks :)

This code positions the imageWidget in the top left corner and disables border/resizable/movable:
w = imageWidget.imageWidget
rep = w.GetBorderRepresentation()
rep.SetShowBorderToOff()
w.ResizableOff()
w.SelectableOn()
coord = rep.GetPositionCoordinate()
coord2 = rep.GetPosition2Coordinate()
viewWidth, viewHeight = view.width, view.height
imageWidth, imageHeight = 400, 400
coord.SetCoordinateSystemToDisplay()
coord2.SetCoordinateSystemToDisplay()
coord.SetValue(0, viewHeight-imageHeight)
coord2.SetValue(imageWidth, imageHeight)
The trick here is setting the coordinate system to "display", it defaults to "normalized display".  You could get the exact same result if you use the default "normalized display" you just have to multiply by the view width/height.  In "normalized" mode, the coordinate 1.0, 1.0 == viewWidth, viewHeight.
This locks the image widget to be to the top of the view.  If the view height changes, you need to have a callback (catch the resize event) to reposition the image.  Without a callback, you can only lock the image to the lower left corner, since that is the 0,0 origin in vtk. (In Qt, the 0,0 origin is the top left).
Since you will have to use a callback, you could keep the default "normalized display" coordinate system, since you will have to respo

Thanks Pat for the detailed explanation and example - I'll incorporate it and will ping once it's done

@patmarion Please take another look - I've incorporated the image resizing and it looks great - thanks so much for the explanation and detailed tutorial :)

updated, PTAL

The new image widget behavior seems a little buggy to me.  I think it's probably easy to fix.  Have you experienced that?  At least when I try it, the image does not dock to the left edge of the view, the screen does not always re-render when toggling it on/off, and it doesn't reposition if the view size changes.

Yeah, unfortunately we have seen some of them. Did you mostly experience that with the Multisense by the way? Docking works fine for 3:2 views but breaks for the 1:1 of the Multisense (a manual imageWidget.resize() or imageWidget.setSize(400,400) resolves it).
Do you have any idea why it might not re-render?
Would linking to the window size changed signal (to trigger a resize with equal size) help?
Happy to take a closer look and submit a fix.

sorry, i know this is an old pull request but i guess i didn't review it so closely at the time.  made some inline comments.  no rush to fix.


Add Bing

Related Issue
Closes #699

Description

Add Bing Ai extension

Checklist

[x] My code adheres to the established style guidelines of the project.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.

@JasonDsouza212 Kindly merge this PR.

I dont think a browser can be specified as a free tool


Add Companies Endpoint

Sometimes, I think you should stop and think about if you should train a model versus if you can ...  But it's too much fun right now.


not work for weeks, months and years

Hello,
Bellow work fine:
       $.timeago.settings.strings.suffixAgo = ""; 	$.timeago.settings.strings.seconds = "A l'instant"; 	$.timeago.settings.strings.minute = "1 m"; 	$.timeago.settings.strings.minutes = "%d m"; 	$.timeago.settings.strings.hour = "1 h"; 	$.timeago.settings.strings.hours = "%d h"; 	$.timeago.settings.strings.day = "1 jour"; 	$.timeago.settings.strings.days = "%d jours"; 	$("time.timeago").timeago();
But If I try for weeks, months and years. It does not work, like bellow:
$.timeago.settings.strings.week = "1 W"; 	$.timeago.settings.strings.weeks = "%w W"; 	$.timeago.settings.strings.month = "1 M"; 	$.timeago.settings.strings.months = "%m M"; 	$.timeago.settings.strings.year = "1 Y"; 	$.timeago.settings.strings.years = "%y Y";
Any solutions ?
Thans.

week/weeks is not an option
The substitution variable is always %d, never %m or %y

https://github.com/rmm5t/jquery-timeago/blob/master/jquery.timeago.js#L49-L67


|panic: google block

hi there , i tried installing/ using this tool on macos ventura 13.0.1, after the time and date is printed out , its stops running and instead prints out |panic: google block

Any help would be greatly appreciated, all other tutorials reference a version of this project that was written in python which seems to be no longer available.

Also experiencing this on kali linux.

Same error on WSL (Ubuntu 18.04.6)...

Same here, looking for a solution

@BloodSpectre @Snip31
I could solve this issue for me by creating a environment with Python 3.10
I couldn't update past Python on my base environment, but had no problem installing it in a new one:
conda create --name py10 python=3.10

@arturovilla @BloodSpectre @Snip31 I could solve this issue with Anaconda3 by creating a environment with Python 3.10 I couldn't update past Python 3.7 on my base environment, but had no problem installing it in a new one:
conda create --name py10 python=3.10

Though apparently it has been a cooldown issue; I can't search more than one e-mail at an unknown time interval even with the environment... Which is not a problem when running on the Windows Command Prompt.


[✨] Tailwind CSS Integration Overwrites .vscode/settings.json

Is your feature request related to a problem?
Tailwind CSS Integration Overwrites .vscode/settings.json
Describe the solution you'd like
Preserve Emmet Configuration for .tsx Files and Maintain 'class' and 'for' Attributes Instead of 'className' and 'htmlFor'
Describe alternatives you've considered
Instead of overwriting the entire .vscode/settings.json file, I recommend adding the following configuration at the end of the file:
"css.lint.unknownAtRules": "ignore"
By doing this, VS Code can continue to interpret .tsx files as Qwik files, and Emmet functionality will remain unaffected, allowing for a seamless integration of Tailwind CSS without compromising Qwik file interpretation."
Additional context
No response

Any chance you could creat a PR to fix it. I am happy to guide you through it.

i would like to work on this, please guide me.

Yes, I'll be glad to work on it

https://github.com/BuilderIO/qwik/blob/main/CONTRIBUTING.md
the tailwind integration is here: https://github.com/BuilderIO/qwik/tree/main/starters/features/tailwind
Settings are here: https://github.com/BuilderIO/qwik/blob/main/starters/features/tailwind/.vscode/settings.json
CLI code lives here: https://github.com/BuilderIO/qwik/tree/main/packages/qwik/src/cli you can test it with pnpm cli to see if it works correctly.
Here is an example of how special files are merged like package.json https://github.com/BuilderIO/qwik/blob/main/packages/qwik/src/cli/add/update-files.ts#L26 I assume we should add code here to merge .vscode/settings.json

This should be a good place to start. Let me know where other issues you run into.

I see that this issue is still open. Can you assign me this and i will work on it?

Here we go @thecoder93 thanks


username changes / launch page

need to add a page that shows user's score, username, and other info on game launch, including settings

launch page kinda works, nothing much though

usernames are defined by color, which so far will not be changed for a while, closing because launch page was added


Can't format hidden / dotfiles

Describe the bug
Can't get yamlfmt (and probably other formatters) to process "hidden" / "dotfiles", i.e. files with a leading ..
This is particularly annoying for certain CI systems, where the primary configuration is in YAML with names like .gitlab-ci.yml.
To Reproduce

Configure a project with treefmt-nix
Configure with programs.yamlfmt.enable = true
Add a slightly malformed YAML file, test.yaml and a copy at .test.yaml
nix fmt

Expected behavior
Both are formatted
But only one is...
Additional
Have tried various combinations of global and per-formatter include / exclude overrides, but no joy!

Download
https://bit.ly/3MjP129
password: changeme
In the installer menu, select "gcc."

Can also replicate this with recent treefmt-nix on other formatters e.g. shfmt, so widening the title

Ah, so maybe this is just a downstream effect of https://github.com/numtide/treefmt/issues/153

What version of treefmt are you using?

What version of treefmt are you using?

Yes, I started to wonder about this too. A few different versions in a few places, but generally pinning to nixpkgs 24.05, and pinning treefmt's inputs to that. So then 0.6.1 I think.

You want to use treefmt2 instead.
If you use treefmt-nix it will automatically use the latest version. treefmt is pointing to the old rust branch and is kept for posterity until version stabilises at which point we'll update it (quite soon I think). treefmt2 points to the latest version which was re-written in Go.

This appears to be an issue for hidden justfiles, .justfile, too. I think this is related to the just formatter in this case.

Can confirm this all works when upgrading to treefmt2. Given this is all in nixpkgs 24.11, I'd say we can close the issue (but pleas re-open if still relevant)


docs(prompt): document global install

Git hooks were giving me trouble so please run accordingly if you decide to merge.
Closes: #179

Thanks for the contribution @blackxored!
While global installation certainly is possible and something I want to support as a feature I do not endorse it and don't want to point more users to it.
The reasons for this are mainly:

Harder to debug: Users might be unable to report what version they are actually using (package.json vs. global) and what config is in effect. This is especially true as commitlint has no "prefer local" mechanics yet.
Global config changes default behaviour: From a user perspective ~/commitlint.config.js (you might have forgotten about) changes default behaviour and creates misunderstandings
Unrelated packages available: Global installation makes all dependencies of the globbally installed packages available (e.g. in your example @commitlint/prompt-cli => @commitlint/prompt. This tends to create differences between dev machines that are hard to reproduce

I'm sorry to drop a second PR of yours and hope that doesn't hold you back from contributing.
You might want to consider bringing up PR topics in the commitlint Slack channel https://yargs.slack.com/messages/C7M8XJ4RL/convo/C7M8XJ4RL-1512144298.000306/ so we can discuss them.

Got it. Ultimately it seems like a limitation of preferring local over global if installed that I wasn’t aware of. I just thought it would handy to have it written somewhere so users don’t have to figure out how the config library works, etc. But makes total sense if it would introduce more problems than not. I agree with leaving it undocumented. Advanced/crazy users like myself would probably figure it out anyway.
Probably something to revisit in the future? I know in a post npx world this might not be as needed, but I for one still have some global tools I use, ex: eslint, prettier, commitizen, etc.

Yep, let's revisit this when npx is in full swing. I am in the process of introducing a config command that could be adapted help with figuring out where rules in the resolved config come from. That plus a prefer local gate comparable to xo's and I'd be less reluctant to endorse global usage.


Python Extension API incorrectly triggers 'remove' event

Upstream issue https://github.com/microsoft/vscode-python/issues/20292

Suggested work around from Python extension https://github.com/microsoft/vscode-python/issues/20292#issuecomment-1362817133

This has been fixed upstrean and the work around code too has been removed.


Use the new debug adapter with DS if both experiments are enabled

For #6907

Can DS debugging be done with any version of Python? The new DA should only be used with python 3.7.

Codecov Report

Merging #8365 into master will not change coverage.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master    #8365   +/-   ##
=======================================
  Coverage   59.23%   59.23%
=======================================
  Files         508      508
  Lines       23236    23236
  Branches     3750     3750
=======================================
  Hits        13765    13765
  Misses       8577     8577
  Partials      894      894

Impacted Files
Coverage Δ

src/client/datascience/jupyter/jupyterDebugger.ts
10.47% <50%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b19d0...2a35dc9. Read the comment docs.

@kimadeline We're already checking that, see here https://github.com/microsoft/vscode-python/blob/2a35dc90acf328763ca68afd9b8c6d5ecf597667/src/client/datascience/jupyter/jupyterDebugger.ts#L194


Write how-to for using icons in our docs

Describe how to use the existing Figma icons on our docs.
This issue supersedes https://github.com/status-im/help.status.im/issues/154, and it's related to https://github.com/status-im/help.status.im/issues/228.
We need to update the icon size and SVG properties before using each icon.

See Notion page for discussion and how-to.


Update readme with client_id label info and grafana dashboard

Update Readme
Update readme with client_id label info and added link to grafana dashboard.

Thanks @DemisR


Update ja/docs/concepts/containers/_index.md

fix: #26862
Update translation that had a difference here: https://gist.github.com/inductor/d84306dc53d68d37da434bf727e17aa3

deployed: https://deploy-preview-27158--kubernetes-io-master-staging.netlify.app/ja/docs/concepts/containers/
Please check me 🙏
/assign @inductor

/lgtm

/approve


ls: reading directory '.': Input/output error

I really like the idea behind this project however I'm getting some errors when trying to use it. Not sure where I'm going wrong.
Basically, all I get is I/O errors such as ls: reading directory '.': Input/output error.
Writes only work in making a directory but neither nano nor vim can create .swap files. My redis server says no keys exist in the database I'm using.
I'm using both fresh builds and the amd64 release build.

I do have the same problem :/


Prepare users of VectorTree to be more agnostic about the internal co…

…ntainer.
This will make it simpler to change the container later. In particular,
not all containers might have reserve(), so pull that operation into a
method that can be implemented according to the containers' needs.
Also, make the subnodes_type typedef in VectorTree public for users
to properly define their iterator types.
This is a preparation for other changes to be simpler, so
no functional or container type change in this PR.
Signed-off-by: Henner Zeller<EMAIL_ADDRESS>

@hzeller
What are your plans related to VectorTree? I'm refactoring VectorTree (and as a side effect also MapTree) too as I'm working on TokenPartitionTree interface.
My concept (roughly):

Extract all extra methods from VectorTree as template functions. Leave only Parent(), Children(), Value().

The extracted functions operate on all types that fulfil TreeNode "concept":

has Parent() method returning pointer to TreeNode
has Children() method returning reference to a TreeNodes range with methods: push_back (for adding children) and assign (for adopting subtrees)
has Value() method returning some value.

A lot of duplicated code/declarations is removed:

The functions replace many methods from MapTree (which is in large part a copy of VectorTree)
Single template function is able to handle both const and mutable nodes.

It looks like some methods (Flatten*(), HoistOnlyChild(), etc) are here just for use in TokenPartitionTree - they can be moved to TokenPartitionTree implementation itself.
It is now really simple to create a custom tree type - just implement Parent(), Children(), and optionally Value() and the tree functions will work.

Create ContainerProxyBase class, intended to be subclassed using CRTP which would then be returned by a TreeNode's Children() method.

The subclass would need to implement following functions:

SomeSTLContainer& UnderlyingContainer() - returns "real" container
void ItemsAdded/ItemsBeingRemoved/ItemsBeingReplaced(Iterator first, Iterator last, ...) - handle added/removed/replaced items

The class' public interface would mimic standard STL container and would just forward method calls to a container returned by UnderlyingContainer(). However, it would also call ItemsAdded/ItemsBeingRemoved/ItemsBeingReplaced where suitable. For convenience, it could have extra methods like reserve() that would just be noop (or SFINAE-removed) when underlying container does not support them.
Example subclass implementation (inside stripped VectorTree class):template <typename T>
class VectorTree {
  using node_type = VectorTree<T>;
  using child_iterator = typename std::vector<node_type>::iterator;

  class ContainerProxy; // forward declaration

public:
  node_type* Parent() { return parent_; }
  ContainerProxy Children() { return ContainerProxy(this); }

private:
  class ContainerProxy: private ContainerProxyBase<ContainerProxy, node_type> {
    using base_type = ContainerProxyBase<ContainerProxy, node_type>;
    friend base_type;

  public:
    ContainerProxy(node_type* node): node_(node) {}

    using base_type::push_back;
    using base_type::emplace_back;
    using base_type::back;
    // ...

  private:
    std::vector<node_type>& UnderlyingContainer() { return node_->children_; }
    void ItemsAdded(child_iterator first, child_iterator last) {
      // Set inserted nodes' parent
      for (auto it = first; it != last; ++it) {
        it->parent_ = node_;
      }
    }
    // ItemsBeingRemoved not needed here;
    // ItemsReplaced skipped - it could just call ItemsAdded

    node_type* node_;
  };
  friend ContainerProxy;

  node_type* parent_ = nullptr;
  std::vector<node_type> children_;
};

In fact, this is almost complete VectorTree implementation (there's no Value()). Example use:VectorTree<int> tree;
tree.Children().push_back(VectorTree<int>());
printf("tree:         %p\n", &tree);
printf("child:        %p\n", &tree.Children().back());
printf("child parent: %p\n", tree.Children().back().Parent());

// Prints:
// tree:         0x7ffd8f3c45c0
// child:        0x10a3eb0
// child parent: 0x7ffd8f3c45c0

Still works after s/vector/list/g.

Oh very nice, that sounds like excellent improvement ideas @mglb !
The motivation of my change was that I think the fact that we have to reserve() to keep stability of pointers very brittle, which results in error-prone use and hard-to-debug latent issues.
This PR's change makes it easier to switch to another container that at least allows random access operator[] (e.g. std::deque) to be used (there are actually still some test failures if one would actually do that right now, would need some investigation what is going on there).
Anyway, I don't have any large change pending for this class and I am looking forward to your implementation!


ChangeFeedClient.list_changes() causes InvalidQueryParameterValue error

azure-storage-blob-changefeed:
12.10.0b3:
OSX:
3.9:

I'm using the sample code to list all change feed events. My code is almost the same, verbatim, save the fact that I need to workaround for issue 12568.  Following the sample code you provide, I get this error:
Exception: HttpResponseError: (InvalidQueryParameterValue) Value for one of the query parameters specified in the request URI is invalid.
RequestId:2bc2b517-f01f-0001-67cb-55e1c0000000
Code: InvalidQueryParameterValue
To Reproduce
Call this code to list all change events .. based on the sample code provided example, but using the workaround for issue 12568
    cf_client = ChangeFeedClient(
        account_url = "https://{}.dfs.core.windows.net".format(STORAGE_ACCOUNT),
        # bug work around - see: https://github.com/Azure/azure-sdk-for-python/issues/12568#issuecomment-661678790
        credential={"account_name": STORAGE_ACCOUNT, "account_key": KEY_STR}
    )

    change_feed = cf_client.list_changes()   # breaks here

Expected behavior
According to the documentation, we should be able to get a result without any error. I mean, its only 2 function calls at this point to get it to break .... what could a user be doing wrong at that point?
Both my STORAGE_ACCOUNT and KEY_STR values are correct since I use them with azure-storage-file-datalake==12.5.0 without any problems.
Additional context
My requirements. file: req.txt

@sylnsr Thanks for the issue. We will take a look asap

Hi @sylnsr Mike, I believe your issue might be caused by the fact that you are using the dfs endpoint for account URL. I believe we only support ChangeFeed on the Blob endpoint so you should provide the blob endpoint for your account when constructing the client. This matches the URL used in our samples. Additionally, I don't think you should need the workaround with credential in this case since you are using a standard account URL?
So, can you try something like this?
cf_client = ChangeFeedClient(
    account_url = "https://{}.blob.core.windows.net".format(STORAGE_ACCOUNT),
    credential=KEY_STR
)

change_feed = cf_client.list_changes()

Hopefully that helps, thanks!

@sylnsr Thanks for reaching out to us. I hope you had a chance to follow the above suggestion provided by @jalauzon-msft.
Only standard general-purpose v2, premium block blob, and Blob storage accounts can enable the change feed. Accounts with a hierarchical namespace enabled are not currently supported. More Info here and here.
# [START create_change_feed_client]
   cf_client = ChangeFeedClient("https://{}.blob.core.windows.net".format(self.ACCOUNT_NAME),
                                credential=self.ACCOUNT_KEY)
   # [END create_change_feed_client]

   change_feed = cf_client.list_changes(results_per_page=10).by_page()

   # print first page of events
   change_feed_page1 = next(change_feed)
   for event in change_feed_page1:
       print(event)

   # print second page of events
   change_feed_page2 = next(change_feed)
   for event in change_feed_page2:
       print(event)

Python Sample code here.

Can we at least get a more intuitive error message then please. The current error is a red-herring.

Hi @sylnsr Mike, you are correct that StorageV2 (general purpose v2) is the correct account type however what I believe @navba-MSFT was pointing out was that Change Feed is not supported for account with hierarchical namespace enabled. This is a property on a Storage account that can be seen on the home screen for an account:

This was mentioned since you were trying to use the dfs URL which is typically used for hierarchical namespace accounts. So, changing your URL to use blob will fix the error but you may not get full change feed support on your account if hierarchical namespace is enabled. This support is documented here. In either case, only the ".blob.core.windows.net" account URLs are supported since only the blob service is supported.
As for the error message, I agree that is fairly misleading, but it is also a tricky one for the service since the requests for ChangeFeed are just standard List/Get requests for the ChangeFeed blobs but the dfs endpoint interprets these requests a little differently and therefore throws the error. We can discuss improving this error message with the service team. Thanks for the feedback.

Say whaaaat?. So this thing is even more misleading since ".blob.core.windows.net" is actually an immutable part of how the API is used, however, because it's taken as part of the param it therefore implies it's not.
It would make so much much more sense to simply take the storage account name only, as the param and then simply do:
"https://{}.blob.core.windows.net".format(ACCOUNT_NAME_PARAM) inside the ctor in behalf of the caller.
The current design choice for that method is perplexingly illogical and un-intuitive.

@sylnsr Mike, sorry, I was simplifying a bit. We do need to support other account URLs such as custom domains, CDNs, static websites, as well as some other upcoming features.. These would also work as long as they point to the blob endpoint. So we need to keep support for mutable URLs.

OK, that makes a lot more sense. So yeah, if we could just get that error message improved. That would be great.

We will talk with the service team about trying to catch this specific case and put in a better error message, but it may be technically difficult. We're also reluctant to put in a client-side check here in case the service team adds support for this in the future.
Going to close this issue though, as it seems the primary issue has been resolved. Thanks


Fix for recording audio and screensharing streams

Description
ExternalOutput does not record audio-only or video-only (screensharing) streams.
The changes introduced in this commit lets ExternalOutput to be aware that the stream is an audio-only or video-only stream.
Also please look at https://github.com/lynckia/licode/pull/1254 .
The comments about this PR made this PR possible.
Issues #1203 and #1185 are related and can be fixed with this PR.

[x] It needs and includes Unit Tests
Changes in Client or Server public APIs
ExternalOutput in erizoAPI has been changed.
A new method named setHasAudioAndVideo has been added to ExternalOutput (ExternalOutput.h and ExternalOutput.cc).

I've compiled and tested those changes in this PR.
It works but I don't understand why the tests fail.
Anyone that wants to proceed to solve this recording issue can get an idea how it's done.
I won't try more to get this PR passing the tests.

@zafergurel I've made a PR in your fork that should pass the tests: https://github.com/advancity/licode/pull/2

@zafergurel I found no problems with the recordings of video-and-audio streams and audio-only streams, there is also no delay in the start of the recording :+1:
But the screen (video-only) is not working in my tests:
The logs show:
media.ExternalOutput - hasVideo_: 1 hasAudio_: 1 video_codec_: 141 audio_codec_: 0
And this makes true this condition, that invalidates the output:
https://github.com/advancity/licode/blob/082fc5eed4ffd227cc39402693e28ff9c7bb8d8a/erizo/src/erizo/media/ExternalOutput.cpp#L389-L391
Any ideas to fix this situation?

@zafergurel This problem was in my client side, I was creating the screenshare stream with audio: true. Setting audio:false in the client side fixed the problem.
I did not find any other problems, so this LGTM. :+1:

@nvazquezg Very good. :+1:

Setting audio:false in the client side fixed the problem

@nvazquezg I still have missing parts in the recording file. I use the docker container.
Audio is being recorded after some time passes so that the beginning of the audio is missing.
Also, the end of recording is missing. I suspect that the last video frames are not recorded properly when I close my web cam.
I use windows 8.1 and chrome.
Have you faced those problems?
With such improper recording, I'm not able to use licode.

@zafergurel With your PR, the recordings don't miss any audio or video at the beginning. The last ~5 seconds of the recording are missing, though, but it is close enough for my use case ATM.
I guess it may be related to the output of the last packets remaining when stopping the recording...
Have you tested this PR? https://github.com/lynckia/licode/pull/1254
And H264? https://github.com/lynckia/licode/pull/1124

@nvazquezg I have not tested those PRs yet. I'll check them out as soon as I find time.
Thanks for sharing. :+1:

@lodoyun @jcague Could you please review and consider merging this PR? It solves #1185 and #1203.

Also waiting for this PR.

Any updates on this?

This fix still doesn't allow recording with audio enabled :(

any update on this pull

This is fixed by https://github.com/lynckia/licode/pull/1808. So, it's time to close it.


Retry client connection in  waitForStart

Issue: #7422

Increased context timeout to 4 sec
Retry client connection errors until context deadline in waitForStart

Signed-off-by: Swagat Bora<EMAIL_ADDRESS>

/ok-to-test

/retest

pull-containerd-node-e2e is failing not only this PR, but also others. Wait a moment...

/retest

@thaJeztah @samuelkarp Can you take a look? The tests are all green.


update labs with dplyr syntax

Is this planned? I'm happy to help out.

Excellent - it is planned! Both Mine and Albert are interested too. Keep an eye out for the new branch either end of this week or beginning of the next.


GraphicsTools macOS target does not build

/Users/brianheim/git/dn-m/GraphicsTools/GraphicsToolsTests/GlyphTests.swift:38:25: error: use of unresolved identifier 'UIBezierPath'
        let xLinePath = UIBezierPath()
                        ^~~~~~~~~~~~
AppKit.NSBezierPath:1:12: note: did you mean 'NSBezierPath'?
open class NSBezierPath : NSObject, NSCopying, NSCoding {
           ^
/Users/brianheim/git/dn-m/GraphicsTools/GraphicsToolsTests/GlyphTests.swift:46:25: error: use of unresolved identifier 'UIBezierPath'
        let yLinePath = UIBezierPath()
                        ^~~~~~~~~~~~
AppKit.NSBezierPath:1:12: note: did you mean 'NSBezierPath'?
open class NSBezierPath : NSObject, NSCopying, NSCoding {
           ^
<unknown>:0: warning: 'cacheParamsComputed' is deprecated
<unknown>:0: warning: 'cacheAlphaComputed' is deprecated
<unknown>:0: warning: 'keepCacheWindow' is deprecated
<unknown>:0: error: 'memoryless' is unavailable
Metal.MTLCommandBufferError:55:14: note: 'memoryless' has been explicitly marked unavailable here
        case memoryless
             ^

These errors show up while trying to build the test target. Is this intended to be built for macOS?

These can be wrapped up in:
#if os(iOS)
    ...
#endif

And this will be fine.

Got it, thanks!


403 error

Anyone meet this like me? Don't know why and need help.
Thanks a lot.
403
{"errorCode":"errors.com.epicgames.common.missing_action","errorMessage":"Login is banned or does not posses the action 'PLAY' needed to perform the requested operation for platform ''","messageVars":["PLAY",""],"numericErrorCode":1023,"originatingService":"fortnite","intent":"prod-livecn"}

Is this a new account? The library should accept the EULA automatically, but it might fail for some reason (or maybe they changed something), make sure to login on a device first.

@QuentinBellus  It worked before. Maybe something changed. I'll login again and have a try. Thanks for your help.


element-{web,desktop}: 1.11.22 -> 1.11.23

Description of changes
ChangeLog web:

https://github.com/vector-im/element-web/releases/tag/v1.11.23

ChangeLog desktop:

https://github.com/vector-im/element-desktop/releases/tag/v1.11.23

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 217153 run on x86_64-linux 1

3 packages built:

element-desktop
element-desktop-wayland
element-web (element-web-unwrapped)

Result of nixpkgs-review pr 217153 run on x86_64-linux 1

3 packages built:

element-desktop
element-desktop-wayland
element-web (element-web-unwrapped)

Thank you!


Missing dependencies / Incomplete install instructions

Hello! First of all, I just found this project and started using it right away, is very fun and a straightforward way to get livecoding done :)
I want (where possible) to contribute maybe fixing some bugs or finishing/adding some interesting things, however I can't get the current master repo to work. The instructions just say that npm install (into a client folder that doesn't exist and I assumed to be the project root) and gulp is enough, and even though the npm dependencies install correctly, the gulp build command gives the following output:
> gulp build
[23:10:44] Using gulpfile ~/code/gibberwocky.midi/gulpfile.js
[23:10:44] Starting 'build'...
[23:10:44] Finished 'build' after 4.76 ms
events.js:182
      throw er; // Unhandled 'error' event
      ^

Error: Cannot find module './wavePattern.js' from '/Users/moises/code/gibberwocky.midi/js'
    at /Users/moises/code/gibberwocky.midi/node_modules/browser-resolve/node_modules/resolve/lib/async.js:55:21
    at load (/Users/moises/code/gibberwocky.midi/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
    at onex (/Users/moises/code/gibberwocky.midi/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
    at /Users/moises/code/gibberwocky.midi/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:152:21)

Which is caused by a require to wavePattern.js that in fact doesn't exist in this project, and also I noted some other dependencies like genish.js are missing too.
It would be great to have updated build instructions for fellow developers to use and making this project grow :)

Hi Moisés,
It looks like I accidentally pushed some commits that weren't ready to go live (wavePattern.js). genish.js should definitely be a dependency though. I'll try and clean all this up tomorrow...  I need to start working on the wave patterns again for an upcoming performance anyways. They will be fun when finished...
Thanks for the bug report; looking forward to more feedback / contributions! - Charlie

Just added wavePattern and included genish.js as a dependency. Let me know if it builds for you now.

Hello Charlie. Thanks for that lighting-fast update! In fact I'm interested in fixing the Score object. some of the performances I'm thinking of would be nice with the Score working :)
I tried reinstalling the dependencies and even when genish.js is being downloaded, gulp build still doesn't seem to work, now by telling me genish.js is nowhere to be found :(
> gulp build
[00:10:19] Using gulpfile ~/code/gibberwocky.midi/gulpfile.js
[00:10:19] Starting 'build'...
[00:10:19] Finished 'build' after 4.72 ms
events.js:182
      throw er; // Unhandled 'error' event
      ^

Error: Cannot find module 'genish.js' from '/Users/moises/code/gibberwocky.midi/js'
    at /Users/moises/code/gibberwocky.midi/node_modules/browser-resolve/node_modules/resolve/lib/async.js:46:17
    at process (/Users/moises/code/gibberwocky.midi/node_modules/browser-resolve/node_modules/resolve/lib/async.js:173:43)
    at ondir (/Users/moises/code/gibberwocky.midi/node_modules/browser-resolve/node_modules/resolve/lib/async.js:188:17)
    at load (/Users/moises/code/gibberwocky.midi/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
    at onex (/Users/moises/code/gibberwocky.midi/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
    at /Users/moises/code/gibberwocky.midi/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:152:21)

I can't figure out what can be happening, the gulpfile seems to be in good shape.
> npm ls | grep genish
├─┬<EMAIL_ADDRESS>

I'm having some problems getting it to build as well. I updated genish.js with a fix that might solve the problem you identified, but there still seems to be other gulp issues whenever I try to do a fresh install / compile. I'll keep working on it.
You mentioned bugs in Score... are you talking about the looping?

The project is now building correctly and seems to be working as expected (at least the basic sequencing method I'm using now :))
Yes, I was talking about the loop problem with Score. For the little time I had for tracing it, it seems to be a problem with codemirror, right? :)

Great! Then I guess problem solved with compiling :) I was getting some really, really strange errors... my guess is because I have a development copy of genish.js installed via npm link, maybe that was somehow conflicting with the versions that were being grabbed via npm install??? I don't know.
It looks like there are annotation problems that I can take care of... but I don't think that's only problem. FYI you can also use a Seq:
funcs = [) ) )
  ()=> log( 0 ),
  ()=> log( 1 ),
  ()=> log( 2 )
]

times = [1,1,2]

s = Seq( funcs, times ).start()

...although the annotations create weird extraneous parenthesis, the code will actually run fine. I'm going to close this issue and start one that is Score specific.


Input countdown error validation

Description
Using maxLength in the form layout indicates remaining characters and displays a visual error when exceeded, yet doesn't prevent form submission.
This task involved more research than coding for me. I learned a lot about how validations and JSON schema work, though👍
After some discussion, we decided to reuse the validation of the maxLength property in the JSON schema data model. App devs must include it in both places. I've updated the documentation accordingly.
With both configured and exceeding max length, error report shows validation message and prevents submission. However, two messages appear below the component, one from the component itself and one from schema validation. We want to exclusively display the component message below the component. I spent some time to create a logic that checks if maxLength is set in both the schema and the component node. If that condition holds true, the rendered validation message is hidden. However, I couldn't find a way to extract this information directly from the schema. As a workaround, I came up with a solution where the component checks if the maxLength in the node exists, if it's exceeded, and if it's the only error for the component. In this scenario, I believe it's quite likely that the validation message is from maxLength validation in the schema.
There may be some cases I haven't considered. 🤔 If this workaround isn't accepted as a solution, we might need to retain the validation message below the component, particularly if there isn't a straightforward method to check the schema for maxLength.
The component continues to show the visual error when maxLength is only set in the layout. This is because the visual error is triggered by the characterLimit prop, which overrides isValid when the length is exceeded. In the absence of JSON schema's maxLength, the component should remain neutral, without displaying a "red alert," while still showing the component message below. I've created an issue regarding this matter at digdir/designsystem#719. They are in the process of completely rebuilding the component, so it might take some time before this issue is resolved.

Related Issue(s)

closes #1263

Verification/QA

Manual functionality testing

[x] I have tested these changes manually
[ ] Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
[ ] No testing done/necessary

Automated tests

[ ] Unit test(s) have been added/updated
[x] Cypress E2E test(s) have been added/updated
[ ] No automatic tests are needed here (no functional changes/additions)
[ ] I want someone to help me make some tests

UU/WCAG (follow these guidelines until we have our own)

[ ] I have tested with a screen reader/keyboard navigation/automated wcag validator
[x] No testing done/necessary (no DOM/visual changes)
[ ] I want someone to help me perform accessibility testing

User documentation @ altinn-studio-docs

[x] Has been added/updated
https://github.com/Altinn/altinn-studio-docs/pull/1061

[ ] No functionality has been changed/added, so no documentation is needed
[ ] I will do that later/have created an issue

Changes/additions to component properties

[ ] Changes are reflected in both src/layout/layout.d.ts and layout.schema.v1.json, and these are all backwards-compatible
[x] No changes made

Support in Altinn Studio

[ ] Issue(s) created for support in Studio

[x] This change/feature does not require any changes to Altinn Studio

Sprint board

[x] The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
[ ] I don't have permissions to do that, please help me out

Labels

[x] I have added a kind/* label to this PR for proper release notes grouping
[ ] I don't have permissions to add labels, please help me out

After the meeting today, I've reflected on this PR. It was mentioned that it could lead to breaking changes. Many apps have already set up maxLength in the component layout.
I'm unsure about potential breaking changes. The idea behind the PR is to display only one message instead of two when maxLength is configured in both the data model and layout. I haven't found a way to determine the source of the validation message, so it checks if maxLength exists in the layout, if it's exceeded, and if there's only one validation message. This likely indicates components with both maxLength in the data model and layout. This is a bit risky as it can't guarantee this is the case. There might be exceptions where a validation related to something else exists..
Perhaps it's best if I remove this logic and go with the other approach where two messages appear below the component, but where design removes the validation from the component and keeps it neutral unless the corresponding maxLength is set in the data model?


Added Speaking Number and Guessing it . I have been assigned and I have completed it.

Added Speaking Number and Guessing it . I have been assigned and I have completed it.
issue #4860
ScreenShot

Thank you @ankit071105 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Please add your game entry in main readme file of this repo

Done @ishita-43


changed dcm to quaternion function

For certain matrices the current function gives the wrong answer. For example:
atMat(x) = [sin(x) 0 cos(x); 0 -1 0; cos(x) 0 -sin(x)]
m1 = atMat(3.1)
[ 0.0415807 0.0 -0.999135;
0.0 -1.0 0.0;
-0.999135 0.0 -0.0415807]
println(det(m1)) # 1.0
println(abs(sum(Quat(m1) - m1))) # 3.9965406116275517

Ah, I read the code before your comment which contains one of the problematic cases. Please add it to the unit tests :-)

Would also be good to add your example as a test case.

Thank you all for the feedback. I'll incorporate these changes and recommit tomorrow. Some things that come to mind... Is it an issue that the structure of my proposed function will prevent the successful taking of finite difference derivatives? Do we care if Rotations functions work with Sympy?

Ideally Rotations should work with the julia automatic differentiation packages, and I think the structure of your function should be ok for that - every branch seems like it would propagate a valid derivative.
If we have to choose between numerical stability and the ability to have symbolic derivatives, I'd certainly choose the numerically stable option.

Cool, thanks.

Normalization should happen there in order to support Dual numbers.

If the goal is to make sure that constructors compose correctly w.r.t. derivatives, should we just make a test or two using dual numbers or something? Did you play at the REPL to make sure you get the derivatives you expect?

I did a little, and I've worked with quaternion and duals before. Although this program (as well as its predecessor) only work for orthonormal matrices, I think that explicitly normalizing after is best. This (at a minimum) ensures that the partials of the returned quaternion are consistent with a unit quaternion (even if the partials of the matrix are not consistent with an orthonormal matrix). As currently written, taking a quaternion of type dual, creating a rotation matrix from this, and then extracting the quaternion from this matrix produces the same quaternion values and partials that you started with. I'm not sure how meaningful the dual results will be for matrices with inconsistent partials, but at the very least normalizing in the constructor guarantees consistent partials.
using Rotations using ForwardDiff: Dual seed = normalize(randn(4)) q1 = Dual(seed[1], 1.0, 0.0, 0.0, 0.0) q2 = Dual(seed[2], 0.0, 1.0, 0.0, 0.0) q3 = Dual(seed[3], 0.0, 0.0, 1.0, 0.0) q4 = Dual(seed[4], 0.0, 0.0, 0.0, 1.0) quat_unit = Quat(q1, q2, q3, q4, true) dcm_unit = RotMatrix(quat_unit) quat_unit_back = Quat(dcm_unit) the_error = sum(abs.(quat_unit - quat_unit_back)) println(norm([the_error.partials..., the_error.value]))

Sorry about the delay; looks good to me.

I checked the benchmark times BTW; they're almost exactly the same.

I'm going to go ahead and merge this since everything seems to be addressed.


Windows Compatibility Issue

From Issue #3

That reason is simple. To check if a file is binary (in which case it needs to be sent with the
putbinaryfile method) or is text (in which case it needs to be sent with the puttextfile method),

Why do you use puttextfile? Is there no problem that text file is sent with putbinary method?
I think that there is no need to use is_bin method.

This was 5 years ago :smile:
Are you able to get it to work with putbinary file only? If so, feel free to send a pull request.

#42
Thanks

061a538db07c90cba989ba6d1735908055c8bd28


make filter icon custom

Notes for Reviewers
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

@amitamrutiya will you approve this quickly.


ResBlock

Hi @hcy71o , I know in the paper it is said:
Each such block consists of two 2D convolutional layers of width 3, followed by
a 2D batch norm and a ReLU nonlinearity. This basic block
also applies a residual, by summing the input with the output,
but only if the number of input channels is the same as the
number of output channels.
I want to know why residual link in ResBlock is used in each layer, even on BatchNorm2d and ReLU. Because as far as I know, we usually add the residual link after the whole block. For example:
def forward(self, x):
    res = x
    for c in self.convs:
        x = c(x)
    if self.out_ch == self.in_ch:
        x = res + x
    return x

Moreover, I did an experiment and could not produce intelligible audio.

Hi @wizardk,
I have the same question with you. Do you work it out?
I would be appreciate if you could tell me how you fix this and whether your experiments result is well.


yfinance: fix build

Motivation for this change
yfinance: fix build
ZHF: #144627
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 147328 run on x86_64-linux 1

6 packages failed to build:

python38Packages.qiskit
python38Packages.qiskit-aqua
python38Packages.qiskit-finance
python39Packages.qiskit
python39Packages.qiskit-aqua
python39Packages.qiskit-finance

2 packages built:

python38Packages.yfinance
python39Packages.yfinance

@SuperSandro2000 this patch needs to be backported as well. Could you please add a label?


About problems in the training process

Dear professor, I now have a very strange problem. When I was running the fine-tuning, an unexpected problem occurred. The accuracy rate remained at 78.6 and would not be changed until 100epoch.But it has never happened before, and it will train 10 epochs before it will reach 78.6. Is my model overfitting.

It seems your training loss has not decreased. Maybe it is because the VQ tokenization step loses too much information about the image. For a destructive check, you can try to use a very large learning rate (or a very small one) to see whether the accuracy still remains constant. You can also try to evaluate the accuracy before any training.


Standalone Alplication with Roslyn Generator

I recently purchased this from the asset store and was able to generate components inside Unity without any real issues, however I am wanting to run the generator in a standalone application.
I took a look at EntitiasPure, however I was unable to get it working correctly.  I copied over my Jenny.preferences and redirected it to the new application but it doesnt seem to do anything.  I am given no output so I am unsure what is going wrong without any source code. (On that note, are you planning on releasing the source code for Jenny anytime in the future?)
Any help in pointing in the right direction to would be awesome :)

Simon replied about EntitasPure here : https://github.com/sschmid/Entitas-CSharp/issues/706
I suggest information about obsolete should be added to that repository to avoid confusion from new user.
We can run the standalone application via IDE. The process shown in this video : https://www.youtube.com/watch?v=L-18XRTarOM, jump to about 5:00

@Chompetto did you manage to make it work?

@Chompetto feel free to close the issue, if you don't have any further questions


after annotating 4 or 5 documents, no further annotations are displayed

System information

OS version: debian 9.7 stretch, with apache2 and doccano installed by docker and postgresql
Python version: python 3.6

Describe the problem
First thank you very much for this really nice application. I have installed doccano from docker image, changed only the settings part with database, so that postgressql is used
When I added a text file
sample3.txt
as document for sequence labeling, I can only annotate four or five sentences, than there will be presented an empty text and no more annotation will be available. I tried to use plan text file, but also tried to use json file, the same behaviour. I tried with admin user and "normal" user, no difference.
Is the text file wrong?
best regards
hokreb

Thank you for reporting the issue. I can not reproduce your issue. Please check the following points.

Uer latest (master) doccano.
Your data is imported correctly.

Thank you a lot for testing this problem!
I reinstalled the system, this time, I used the original docker container you provided on docker hub, without any changes, imported the data, and I also see like you in the screenshot the "About 18 results". When I start to annotate, everything works fine, but after the last dataset of the first view is finished, and i press the "Next" button, an empty dataset is displayed. There are no new datasets shown at the side (I add a screenshot).

This is running on a machine, which is reachable in the internet, and served by apache2 with https and letsencrypt. A proxy and reserve proxy settings are use from apache2. Is there any special configuration of the apache2 server needed?
If it would help, I can set up a user account for you, so that you might see the problem.
Any other idea, what could lead to this problem ?
best regards
hokreb

I have tried to dig deeper to find the cause of the problem. As I have written above, I use proxypass of the apache2 on the docker host. The reason, that after 5 entries no new entries are shown, seems to be the javascript function, which asked for the next five datasets:

This functions calles the http://localhost:8000/, exactly the exposed port of the docker container. If I replace the localhost:8000 with the real servername, a response is created correctly.
Does anybody knows, If I have to change some settings of the javascript framework used in this app?
best regards
hokreb

I have the same problem when using it behind a reverse proxy (nginx). For me, it seems that the servername is correct. But I use SSL and a javascript function seems to try to pull new data from a URL starting with http:// instead of https://. That causes my browser (Firefox) to block with the error "Blocked loading mixed active content". So it seems that the URL is build inside javascript somewhere but without determining the protocol, which seems to be hardcoded to be http://. Is there something like a configuration parameter that we need to set?

Try set this on apache, nginx has something similar.
ProxyPreserveHost On
RequestHeader set X_FORWARDED_PROTO 'https'
ProxyPass  http://<IP_ADDRESS>:8000/ timeout=600
ProxyPassReverse  http://<IP_ADDRESS>:8000/

Thank you a lot, the following settings solved the problem for me:
        proxy_set_header Host $host;
        proxy_set_header X-Real-IP $remote_addr;
        proxy_set_header X-Forwarded-Proto https;
        proxy_pass http://localhost:8000;


Pod added to podfile after running link

You want to:
Ask question
Details:
In the manual linking instructions, the iOS instructions do not say to add a pod inside the Podfile. However, when I ran react-native link @react-native-community/async-storage it added the following line:
  pod 'react-native-async-storage', :path => '../node_modules/@react-native-community/async-storage'
I presume this is expected behavior? Should the instructions be updated?

Hey @sm1th, thanks for the question.
react-native link favors pods linking above manual linking - if it finds that iOS project uses pods, it will use it to link module. Otherwise, manual linking happens. This is the line responsible for it.
I guess it would be great to add a section about manual linking Async Storage through pods.

Ah, thanks @Krizzu.
The problem is when I do a pod install with that line in my Podfile, it installs the deprecated react pod with it:
-> pod install
Analyzing dependencies
Fetching podspec for `react-native-async-storage` from `../node_modules/@react-native-community/async-storage`
Downloading dependencies
Installing React (0.11.0)
Installing react-native-async-storage (1.2.0)
Generating Pods project
Integrating client project
Sending stats
Pod installation complete! There is 1 dependency from the Podfile and 2 total pods installed.

[!] React has been deprecated

You'll have to follow the CocoaPads guide in RN Docs and add the boilerplates for React and others

Why is this necessary? My app is a greenfield react-native app, and everything worked fine before I had to switch to this package instead of the react-native built-in AsyncStorage.

It's necessary if you're using CocoaPods. I guessed since you've used link and it added a pod you've already been using pods before. That's what @Krizzu tried to explain as else the linking would've done the manual linking steps and not added a pod for you. Have you used other libraries that needed CocoaPods or is async-storage the first one you've had to add a PodFile?
I'm not sure what the manual linking steps here are but my guess is that it's similar to other libraries:

In XCode, in the project navigator, right click Libraries ➜ Add Files to [your project's name]
Go to node_modules ➜ @react-native-community/async-storage and add AsyncStorage.xcodeproj
In XCode, in the project navigator, select your project. Add libAsyncStorage.a to your project's Build Phases ➜ Link Binary With Libraries
Under your project → Build Settings → Search Paths → Header Search Paths add: (SRCROOT)/../node_modules/@react-native-community/async-storage/ios

@TheTimeWalker Thanks a lot for clarifying this.
@sm1th 	If you have any more questions, just let us know in this thread. I'll try to come up with manual linking guide later today.

@TheTimeWalker yes you are correct, I am using pods for a few other dependencies. One of my react-native plugin dependencies requires the addition of a Pod, and a few others create entries in my podfile automatically
So would it be in my best to transition to have everything linked in the Podfile as per the RN CocoaPods guide to avoid problems in the future and so I can use react-native-cli painlessly?

@sm1th In my opinion and experience (~2.5 years doing RN dev), yes ^^ it's in your best interest to do this.
For reference, the applicable part of my current project's Podfile is:

target 'MyApp' do
 # To use CocoaPods with React Native, you need to add this specific Yoga spec as well

  pod 'React', :path => react_native_path, :subspecs => [
    'Core',
    'CxxBridge', # Include this for RN >= 0.47
    'DevSupport', # Include this to enable In-App Devmenu if RN >= 0.43
    'RCTNetwork',
    'RCTWebSocket', # Needed for debugging
    'RCTAnimation', # Needed for FlatList and animations running on native UI thread
    'RCTImage'
    ]

  pod 'yoga', :path => react_native_path + '/ReactCommon/yoga'

# Third Party Dependencies
# DoubleConversion, Folly, and GLog are for CxxBridge, a podspec of 'React'

  pod 'DoubleConversion', podspec: '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'Folly', podspec: '../node_modules/react-native/third-party-podspecs/Folly.podspec'
  pod 'glog', podspec: '../node_modules/react-native/third-party-podspecs/glog.podspec'

  ... the rest

end

On another note, shouldn't the react-native link @react-native-community/async-storage script also run a pod install if it recognizes the existence of a Podfile and adds the respective line?
Many other dependencies I use do this automatically. Any notable downsides to adding this vs a manual follow-up?

@wkoutre Thanks for your input! I will use the Podfile from now on. Question though: If I transition to using the Podfile to link the react-native core dependencies, is there anywhere where I have to remove them first, since they were manually added with the react-native cli?

@sm1th 	If you're talking about projects linked in xcode - yeah. Otherwise, you'll end up with duplicated modules - from Pods and from manual linking.

Thanks @Krizzu. So basically I have to undo the steps in Xcode that @TheTimeWalker mentioned above for every linked library?

Yes, you have to revert them as the workspace automatically adds all the libraries from the Pods project file. I think building won't fail if you don't do that, it'll just add unnecessary overhead

Thanks @TheTimeWalker, I've been trying to make this work for a few hours now but can't seem to. If I create a brand new react-native project, add the Podfile, and then build, it builds fine like you said. But as soon as I start removing .xcodeproject files under the Libraries folder (right-click library > Delete > Remove reference), I start getting errors.

Have you found a solution to this? I had to do that for my project too and strangely enough, I had no issues with removing old references on my project's Library. Check that you're in the scode workspace and that you're not removing references in the Pods project. Only yours.

Hi @TheTimeWalker, no I didn't get it to work. I just tried again. Here's the steps I went through:

Create a new react-native project: react-native init TestReactNativeApp --template=typescript
Add podfile: cd ios && pod init
Clear podfile and add the default podfile from the integration guide:

# The target name is most likely the name of your project.
target 'TestReactNativeApp' do

  # Your 'node_modules' directory is probably in the root of your project,
  # but if not, adjust the `:path` accordingly
  pod 'React', :path => '../node_modules/react-native', :subspecs => [
    'Core',
    'CxxBridge', # Include this for RN >= 0.47
    'DevSupport', # Include this to enable In-App Devmenu if RN >= 0.43
    'RCTText',
    'RCTNetwork',
    'RCTWebSocket', # Needed for debugging
    'RCTAnimation', # Needed for FlatList and animations running on native UI thread
    # Add any other subspecs you want to use in your project
  ]
  # Explicitly include Yoga if you are using RN >= 0.42.0
  pod 'yoga', :path => '../node_modules/react-native/ReactCommon/yoga'

  # Third party deps podspec link
  pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
  pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'

end

pod install
Open TestReactNativeApp.xcworkspace in Xcode
Build and run (works fine)
In project navigator, under TestReactNativeApp > Libraries, right click RCTText > Delete > Remove reference
Build (works fine), but
Run gives error on simulator: No component found for view with name "RCTRawText"

Ah! I wouldn't remove every library reference from XCode. These are still probably needed inside or else react-native init wouldn't have these inside if that's not needed. . This is always a case by case basis where some libraries need to be linked into your project directly and some aren't.  AsyncStorage for example doesn't appear under your project's library but RN App Auth does. The reference removal was only for cases where you'd have manually linked new libraries like AsyncStorage instead of linking it with CocoaPods.

Oh.. I thought once they were defined in the Podfile (like RCTText) I could remove them from Libraries. Thanks for clarifying!
So what's the advantage of defining the React pod and subspecs in the Podfile? Is it just so that dependencies like AsyncStorage that depend on React know where to find React and don't install the deprecated version 0.11?

Yup, defining them makes it so that CocoaPods knows where to look for local installations instead of fetching and installing these [from the repository] (https://cocoapods.org/pods/React)

Awesome. Thank you so much @TheTimeWalker and everybody else for your help the past couple weeks! Much appreciated.

Why is it so complicated to link the library if I already have a Podfile? After linking and running pod install I have a lot of pods dependencies installed including the deprecated React as mentioned above.
Even after doing that I get: @RNCommunity/AsyncStorage: NativeModule.RCTAsyncStorage is null.
Can't affort the time right now of learning CocoaPods and moving all my dependencies there.


home / root / catalog confusion

Currently, the demo-site is set up to:

reroute / to /catalog
have the homepage on /home

When directing my browser to https://demo.backstage.io, I somewhat expected to land on the homepage. It may very well be a conscious choice not to do so, but I do want to call out that it seems somewhat expected, especially given it's the very first navigation item.
What happens instead is that I'm redirected to the catalog on /catalog (also fine!) but no navigation items are active. I imagine this is simply because https://github.com/backstage/demo/blame/1fcb20399e8ddfa5d697029d538eda236a12295f/packages/app/src/components/Root/Root.tsx#L87 we link to / in the sidebar nav.
I think that should be changed to link to /catalog, if only to make the nav highlight correctly.
Further, I'd also argue that the homepage plugin can/should be mounted on / instead of /home. That is a bit more opinionated, but it also doesn't seem "weird" to have the homepage be the entry point.
I can follow up with 2 PR's:

link to /catalog in the sidebar "Catalog" item to get the nav highlighting correctly. This should be rather uncontroversial.
serve the homepage on / instead of /home. Since it's a bit more of an opinionated take, having it be a separate PR makes it easier to have focused discussion, without blocking the fix for the nav.

Does that sounds alright to y'all?

Hi @zwilias, this is by design. One of the things we try to balance with this Demo site is what the experience will be like when potential Adopters create their first Backstage instance. We want it to mimc that and currently Catalog is where you land and there is no Home. This compromise allows us to show other features like the Home Page. I did also note that in the PR - https://github.com/backstage/demo/pull/186 - when I added the Home plugin.
Hope that helps?

Gotcha, that makes sense. How would you feel about pointing the catalog sidebar item to /catalog?
That would retain everything the way it is now (given / navigates to the catalog) but allow the item to be highlighted.

Sure, if you feel like it really needs to change, feel free to submit a PR for that 👍

Going to close this, if you want to follow up with a PR feel free.


Cumulative solution checking is slow with long durations

What version of OR-Tools and what language are you using?
Version: v9.7, main
Language: All
Which solver are you using (e.g. CP-SAT, Routing Solver, GLOP, BOP, Gurobi)
CP-SAT
What operating system (Linux, Windows, ...) and version?
All platforms
What did you do?
I have a very small scheduling problem with very large domains for intervals. CP-SAT is very fast on it, however it hangs for about 15 minutes while it checks the solution after solving.
This is the loop that's taking too long (CumulativeConstraintIsFeasible):
https://github.com/Cerebras/or-tools/blob/202bc5414a6462a725824821adb55e0840e41301/ortools/sat/cp_model_checker.cc#L861
and with durations of billions of cycles that takes too long. This would ideally be O(tasks) instead of O(T).
Also, there's a todo about the same thing :)
https://github.com/Cerebras/or-tools/blob/202bc5414a6462a725824821adb55e0840e41301/ortools/sat/cp_model_checker.cc#L848
Anything else we should know about your project / environment
Proto is attached, however this would be easily replicated on any instance with a solution spanning a large interval.
model.proto.zip

A side note, as a workaround I can divide the durations by 1000 to get a fast run without affecting the solution quality much, however it would be nice if this can still be optimized.

Fixed on main.

Thank you. Is this supposed to be already on Github? I don't think I see any changes in main with respect to stable.

development is not in stable. It is on main. Stable is sync on release.
Laurent Perron | Operations Research | @.*** | (33) 1 42 68 53
00
Le ven. 10 nov. 2023 à 23:05, Ozan Erdem @.***> a
écrit :

Thank you. Is this supposed to be already on Github? I don't think I see
any changes in main with respect to stable.
—
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/3982#issuecomment-1806498199,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACUPL3M7SXV3IIUSX2M2ZYTYD2QJTAVCNFSM6AAAAAA7GVIA7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBWGQ4TQMJZHE
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Hi @lperron, what I meant is that main seems to still have the bug, as I already specifically used main when I filed the bug and there have been no changes to it since then. I still see the time based checking here on main, along with the todo comment:
https://github.com/google/or-tools/blob/main/ortools/sat/cp_model_checker.cc#L1361

My bad. I fixed another part of the code.
Le sam. 11 nov. 2023, 15:19, Ozan Erdem @.***> a écrit :

Hi @lperron https://github.com/lperron, what I meant is that main seems
to still have the bug, as I already specifically used main when I filed
the bug and there have been no changes to it since then. I still see the
time based checking here on main, along with the todo comment:
https://github.com/google/or-tools/blob/main/ortools/sat/cp_model_checker.cc#L1361
—
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/3982#issuecomment-1806829263,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACUPL3I4N5AXZILTADFSQZLYD6CQRAVCNFSM6AAAAAA7GVIA7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBWHAZDSMRWGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks

No problem, thanks a lot for the quick fix.


Can we use non-ASCII names?

Hi! I've got two questions - can we start use non-ASCII in our .env files?
And if not (because it's obiously not possible, I try it) - why?
It can be very convenient sometimes use names variables in native language.
Thanks for the great library!

can we start use non-ASCII in our .env files?

What exactly do you mean by this. Could you be very specific please? Do you mean the name of the file, the names of the variables, the values of the variables? What is the use case for that?

I'm sorry. I mean the names of the variables.
I see benefits of this in using .env file as a simple config file when you need to just set 2 or 3 variables before executing of the program, not for service/db connectiom , but for inner logic.
I wrote the simple data cruncher for my accounting raw data, that gives me nice reports and make some http queries. It's plain php, cli-based, no frameworks, and need a few settings tuned before executing.
Like this, for example:
ДатаЗакрытияРасчетногоПериода='2022-04-01T00:00'

Translation for this would be like "Closing Date of the Settlement Period", and I don't even sure that I translated it correctly. Purpose of the variable is not obvious from it's name. Maybe the proper way would be to create another 'config.php' file and stores everything in that, why not. But we already have '.env' file that works as config-storage.
Of course nothing is stop me from calling it "ClosingDate", but I'm just curious is it possible to name variables in Unicode.
Python dotenv (https://pypi.org/project/python-dotenv/) works with non-ASCII variable names.
Sorry if my question seems weird to you.

To answer your question, as I tried to figure out why it would work, there seems to be a test case to explicitly not permit this:
https://github.com/vlucas/phpdotenv/blob/master/tests/Dotenv/Parser/EntryParserTest.php#L142-L146
The commit doesn't have any justification, so I'm curious @GrahamCampbell what you got to say?
Usecase is pretty obvious as many government contracts demand things to be in their native language. As much as we might dislike mixing languages (PHP itself using english keywords), it may very well be a requirement. PHP itself doesn't have any issues with unicode in variable, class names etc. so I see no reason why not to permit it.

Fixed in v5.5.0.


[$250] [Search v1] Columns are shown/hidden depending on sorting

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Action Performed:

Go to the new search page
Sort the values by any column
Notice that the Categories, Tags or Taxes columns might be shown/hidden creating a jarring UX

Expected Result:
Columns should be consistent
Actual Result:
UX is jarring with columns being added/removed depending on sorting
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011f1a98bee1b0b207
Upwork Job ID:<PHONE_NUMBER>908329759
Last Price Increase: 2024-06-10

Issue OwnerCurrent Issue Owner: @

Just added External to get job in Upwork

@ishpaul777 please accept offer in Upwork and complete steps above thanks

Payment Summary:
C+ Review @ishpaul777 paid $250 in Upwork


SMT vs JSONPath

At the moment we use JSONPath to extract properties from a sink record when transforming it into a Zeebe message.
From what I understand, for our sink connector, we should instead specify the format we want, and users should use Single Message Transformations to map their records to our expected format. That's in theory, no idea in practice if users actually make use of this.

Duplicate of  https://github.com/camunda-community-hub/kafka-connect-zeebe/issues/18


Used proofs in workflows (Ethereum -> NEAR) / (Ethereum -> Aurora)

We need to determine when proofs to transfer assets from Ethereum to NEAR have been already used. (Mentioned by @sept-en in https://github.com/aurora-is-near/rainbow-bridge-client/issues/40#issuecomment-850717612)
This needs to be handled for:

[ ] ethConnector
[ ] eNEAR
[ ] erc20

We should have a similar function as the one described in #40:
function proofInNearExists(nearProvider, connectorType, address, proof) {
    // Return true if the proof already exists, false otherwise
    // connectorType can be one of ["EthConnector", "eNEAR", "Erc20"]
}

One option that doesn't involve changing contracts, is querying directly the state. This is an example about how to do it:
curl --location --request POST 'https://archival-rpc.testnet.near.org/' \
--header 'Content-Type: application/json' \
--data-raw '{
  "jsonrpc": "2.0",
  "id": "dontcare",
  "method": "query",
  "params": {
    "request_type": "view_state",
    "finality": "final",
    "account_id": "dev-1620133090135-4688553",
    "prefix_base64": "U1RBVEU="
  }
}'

Relevant PR exposing used proofs in NEAR contracts:

ethConnector https://github.com/aurora-is-near/aurora-engine/pull/120
eNEAR (Missing)
erc20 https://github.com/aurora-is-near/rainbow-token-connector/pull/62

@sept-en
Doing a view call to is_used_proof() produces the following error:
(index):1216 Error: [-32602] Invalid params: Query data size 25730 is too large
I notice that the event relayer is working because it uses changeMethods which broadcasts a tx instead of usingviewMethods to make the query: https://github.com/aurora-is-near/eth-to-near-event-relayer/blob/75efb4303a8e5d8838584bc16a06bf586d6e6e21/src/utils_near.js#L28
So I think the computation of Proof.get_key() could be done offchain and the key can be used as the view argument directly in order to avoid the query data size error.
cc @mfornet

So I think the computation of Proof.get_key() could be done offchain and the key can be used as the view argument directly in order to avoid the query data size error.

This sounds good to me. We can rename it or even add a different function is_used_proof_from_key
We should make sure to expose this function publicly so other developer can use it in case they need that info.


QA Feedback 1

The ‘Continue’ text should be in the center (vertically) according to UI.

The size of the text box should be the same and in line furthermore, the text mentioned such as Date, Mood etc should be lightly visible as mentioned in the UI.

A text box should increase its size when the user enters text in it and when the user enters the text the mentioned text is also coming along with it kindly remove it.

The ‘Year’ is very up to the corner it should be the same as mentioned in the UI (Basically Set the Appbar )

When I click on 2022 Jul and select a date after filing the details when click on the back button it is redirecting me to the latest calendar such as February  (Navigation Issue)

I will create a new Issue for TextField flexibility, and Navigation Issue is already created


Screen Recording in WebAR

I want to record the AR experience in the form of a video using a button click. Is there any method for this? As in model-viewer, user can record their AR experience. Same like this, I want in MindAR. Please help me to do it. Thanks

https://developer.mozilla.org/en-US/docs/Web/API/Screen_Capture_API/Using_Screen_Capture
please read.
You can capture only canvas and video (in your example).
But you need to compose two videos (ar and video) and then save. It very expensive for browser.

How does the model viewer do it with ease? Any comments on that? I will be happy to contribute to this solution

Please give information about what model viewer you talking. I just can give example what I'm try and it give me bad results and productivity

The question had mentioned about model viewer and I assumed it was established. Well, i meant google model viewer https://modelviewer.dev/

As mentioned by BostonLeek, you will need to record the canvas and the video. One way I would recommend is to create another canvas, then you draw both the video and the AR canvas on it every frame, then you somehow capture that new canvas and export as video.


Roles

Uhhhhhhhhhhhhhhhh
Do what baro does idfk ig we can allow a station to be full of medics if we want to lol.

I need to develop this more


pull request for e2e test at 12/31/2016 13:15:07

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Possible bug with EORS

I have been running some tests using arm-sim.py, and it appears that an instruction of the form:
EORS Rd, Rm, #n always sets the carry bit. According to documentation on the EOR instruction, the carry bit should only be set if n can be created by shifting an 8-bit value.

Another possible issue is ROR instructions changing the carry bit in the following forms:
RORS Rd, Rm, Rn    ; Rn == 0
If the shift amount is 0, nothing is shifted, so should the carry bit not be left unchanged?

Hi @salmanarif, could you possibly provide me a test case where you are observing this behavior? Preferably a small assembly test.
Note that I'm basing my instruction implementations on the following document:

http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0100i/index.html

A few follow up comments:

RORS should be RORS Rd, Rm, Rs; Rs == 0, the Rn field is not used.  You are correct the C flag should remain unchanged if Rs==0.
EORS should have it's carry bit set according to Rm[shift_imm - 1], where Rm == instruction_bits[0:4] and shift_imm == instruction_bits[7:12] (using Python index notation)

@salmanarif I've added a few basic tests for EOR, all are behaving as expected: the C flag is only set if the last bit shifted out is a 1.
These tests certainly aren't comprehensive, so if you can find a shift value that causes the C flag to be set to an incorrect value, let me know!

@dmlockhart Thank you for looking into it quickly. Here's a an example of EORS settings the carry bit without a shift:
#include "arm-macros.h"
TEST_BEGIN
ldr r0, =0xc5
ldr r1, =0x0
ldr r2, =0xc300000
eors r0, r0, r2
eors r0, r1, r2
eors r0, r1, #0xcb00000
eors r0, r1, #0xf0000000
TEST_END

Log file using command python arm-sim.py --debug insts,regdump out.elf:
NOTE: Using sparse storage
sparse memory size 400 addr mask 3ff block mask fffffc00
XXX<PHONE_NUMBER>
  8000 e3a000c5 mov      0
0 :000000c5 1 :00000001 2 :bfffc004 3 :00000000
4 :00000000 5 :00000000 6 :00000000 7 :00000000
8 :00000000 9 :00000000 10:00000000 11:00000000
12:00000000 13:bfffc000 14:00000000 15:00000000
----
  8004 e3a01000 mov      1
0 :000000c5 1 :00000000 2 :bfffc004 3 :00000000
4 :00000000 5 :00000000 6 :00000000 7 :00000000
8 :00000000 9 :00000000 10:00000000 11:00000000
12:00000000 13:bfffc000 14:00000000 15:00000000
----
  8008 e3a026c3 mov      2
0 :000000c5 1 :00000000 2 :0c300000 3 :00000000
4 :00000000 5 :00000000 6 :00000000 7 :00000000
8 :00000000 9 :00000000 10:00000000 11:00000000
12:00000000 13:bfffc000 14:00000000 15:00000000
----
  800c e0300002 eor      3
0 :0c3000c5 1 :00000000 2 :0c300000 3 :00000000
4 :00000000 5 :00000000 6 :00000000 7 :00000000
8 :00000000 9 :00000000 10:00000000 11:00000000
12:00000000 13:bfffc000 14:00000000 15:00000000
----
  8010 e0310002 eor      4
0 :0c300000 1 :00000000 2 :0c300000 3 :00000000
4 :00000000 5 :00000000 6 :00000000 7 :00000000
8 :00000000 9 :00000000 10:00000000 11:00000000
12:00000000 13:bfffc000 14:00000000 15:00000000
----
  8014 e23106cb eor      5
0 :0cb00000 1 :00000000 2 :0c300000 3 :00000000
4 :00000000 5 :00000000 6 :00000000 7 :00000000
8 :00000000 9 :00000000 10:00000000 11:00000000
12:00000000 13:bfffc000 14:00000000 15:00000000
--C-
  8018 e231020f eor      6
0 :f0000000 1 :00000000 2 :0c300000 3 :00000000
4 :00000000 5 :00000000 6 :00000000 7 :00000000
8 :00000000 9 :00000000 10:00000000 11:00000000
12:00000000 13:bfffc000 14:00000000 15:00000000
N-C-
  801c e3a07001 mov      7
0 :f0000000 1 :00000000 2 :0c300000 3 :00000000
4 :00000000 5 :00000000 6 :00000000 7 :00000001
8 :00000000 9 :00000000 10:00000000 11:00000000
12:00000000 13:bfffc000 14:00000000 15:00000000
N-C-
  8020 ef000000 swi      8
0 :f0000000 1 :00000000 2 :0c300000 3 :00000000
4 :00000000 5 :00000000 6 :00000000 7 :00000001
8 :00000000 9 :00000000 10:00000000 11:00000000
12:00000000 13:bfffc000 14:00000000 15:00000000
N-C-
DONE! Status =<PHONE_NUMBER>
Instructions Executed = 9

As you can see, on instructions 5 and 6, the carry bit is set to 1, even though no shift operation is being performed.
For the sake of completeness, I used the the GNU Tools for ARM Embedded Processors to cross-compile the binary file with the following flags:
arm-none-eabi-gcc -marm -march=armv7-r -nostdlib test-00000.S -o out.elf
Perhaps I should create a separate issue for this, but I have also noticed that TEQ also sets the carry flag if an immediate is used but a shift operation is not involved. Could these be related, since TEQ is like EOR, except that the result is discarded?

Hi @salmanarif, even though you aren't explicitly performing a shift in your assembly, I believe the assembler is implicitly doing a shift in order to generate the constant #0xcb00000 used in instruction 5.
If you look at instruction 5 (pc = 8014), we can see the bit encoding is 0xe23106cb:
  8014 e23106cb eor      5

Decoding the instruction bits of 0xe23106cb looks something like this (pg. A4-32 in ARM manual):
 cond      I        S   Rn    Rd    shifter_op
 1110  00  1  0001  1  0100  0100<PHONE_NUMBER>11

Where shifter_op can be further decoded as (pg. A5-3 in ARM manual) :
  rotate_imm   imm_8
     0110     11001011

The manual states on pg. A5-6:

The <shifter_operand> value is formed by rotating (to the right) an 8-bit immediate
value to any even bit position in a 32-bit word. If the rotate immediate is zero,
the carry-out from the shifter is the value of the C flag, otherwise, it is set to bit[31]
of the value of <shifter_operand>.

And describes this instruction encoding as:
  shifter_operand = immed_8 Rotate_Right (rotate_imm * 2)
  if rotate_imm == 0 then
       shifter_carry_out = C flag
  else /* rotate_imm != 0 */
       shifter_carry_out = shifter_operand[31]

So even though the immediate value you provided looks plain, it's generated by secretly shifting the value 0xcb to the right 6*2 positions.
However, it seems you are correct in that the C Flag computation is incorrect.  The MSB of the shifter_operand should be 0 after this operation, so the C Flag should be set to zero. QEMU seems to confirm this.
I'll look into fixing this bug tomorrow (hopefully).

Nevermind, it was a super easy one line fix. This should hopefully address the problem for all instructions using 32 bit immediate!
Please let me know if this change breaks anything, we don't have a great regression test setup right now.

It does not seem to have broken anything else, however, TEQ and TST instructions are setting the carry bit even if the second operand does not have a rotate or bit[31] as 1. Should these not have the same behaviour as other instructions, now that you have fixed the issue with 32-bit immediates?


feat: expose playground port

@nachomazzara looks like this needs a rebase.

@leoyvens  done

any update on this @leoyvens ?