refactor: add BatchWriter

Separate the CloudWatch Logs batch-writing client from the logrus
Hook data structure. This allows other logging frameworks to use
the BatchWriter client, and logrus clients can use both the
BatchWriter and the Hook.
Example Usage
w, err := cloudwatch.NewBatchWriter(groupName, streamName, awsCfg)
hook := cloudwatch.NewLogrusHook(w)
logrus.Hooks.Add(hook)

Other logging frameworks can still make use of the CloudWatch logs API client (BatchWriter) and don't need to use the logrus hook:
w, err := cloudwatch.NewBatchWriter(groupName, streamName, awsCfg)
zerolog.Out(io.MultiWriter(os.Stderr, w))

Hey, I don't have push permissions here, but review activity is rather low in this repo and I am willing to help to push this forward since our project don't use logrus too and I ended up writing cloudwatch writer myself: https://github.com/lzap/cloudwatchwriter2
The idea of leveraging the Writer interface is great, couple of points before we start:

This appear to change the contract, so this must be v2 for sure.
It also drops the Sync function which currently allows use of the writer for the zap library, this effectively makes impossible to use it for project on zap. You need to add zap support back, I guess a second adapter would be way to go.
This would be a chance to upgrade from AWS SDK v1 to v2, I've done this myself in my cloudwatchwriter2 and it's pretty straightforward.
This package (and the whole repository) desperately needs some tests. I use unit mocking in cloudwatchwriter2, however, what I've seen was also a fully functional AWS SDK mock HTTP simulator, that is also an option. Finally, there is also some kind of mocking embedded into the AWS SDK itself: https://aws.github.io/aws-sdk-go-v2/docs/unit-testing/ this is the best option I think as that's the official stack.

Overall, I don't know how active this project is. I recently discovered another "identity" package that appears to be fixing some issues with the identity package in this project. @lphiri Is this project being retired in favor of individualized ones like identity?

Not much active, I have no idea what the relationship with the other project is. However, looking at the repository name, I don't think a cloudwatch writer adapters do not belong into repository named middlewares to be honest. There are multiple projects doing the same which also have some unit tests, e.g. https://github.com/innix/logrus-cloudwatch
I wonder why you don't use one of these in the first place...

So if you want to get back to this PR I can help it to get it merged. Do you have some real world use for such refactoring? Other popular libraries already do have their own cloudwatch writers, I actually ported one:

https://github.com/kdar/logrus-cloudwatchlogs (logrus, the original code from our repo)
https://github.com/mec07/cloudwatchwriter (zap, ported from the logrus library above)
https://github.com/lzap/cloudwatchwriter2 (zap, my port of the above for AWS SDK v2)

Since logrus project is in maintainance mode now and the slog (structured logger) was recently added into Go standard library, unless you have a practical use case, I would not bother evolving this too much.

I don't have any personal or professional interest in improving this logging package. Is it worth keeping at all as part of the v2?

Rebased and fixed the go.mod conflict.
Renamed Hook to LogrusHook.


Allow passing config via environment variables to zulip-botserver

Component: zulip-botserver
Package: https://pypi.org/project/zulip-botserver/
Code: https://github.com/zulip/python-zulip-api/tree/master/zulip_botserver
Instead of requiring that config be passed as a file with the --config-file option, it would be great if we could pass config via environment variables.
This would make our secure key storage system much easier, as right now we use env variables to pass down secure keys to containers, and creating a config file to store them on disk is suboptimal.
[helloworld]
email=foo-bot@hostname
key=dOHHlyqgpt5g0tVuVl6NHxDLlc9eFRX4
site=http://hostname
token=aQVQmSd6j6IHphJ9m1jhgHdbnhl5ZcsY

Becomes:
env BOT_EMAIL=foo-bot@hostname BOT_KEY=abc... BOT_SITE=https://hostname BOT_TOKEN=abc... zulip-botserver

I would require adding ~20 LOC to https://github.com/zulip/python-zulip-api/blob/master/zulip_botserver/zulip_botserver/server.py, if this proposal sounds reasonable, I can probably submit a PR for it myself without too much difficulty.

@zulipbot claim

Ah, I think I mis-read this issue. It looks like @showell implemented this in #491. I thought this issue was about being able to specify a config file via an environment variable. This is useful so that one can easily run a bot server with multiple bots in an environment like Heroku while also using a production web server like gunicorn.

@zbenjamin My changes were for the standalone config.  We probably need to fix botserver the same way.

@zulipbot claim

@timabbott I hope this issue is should be closed, or can I take it up if anything is pending

@zulipbot claim


defer loading of feeds until visible

Should help #1233
Each of the tab screens renders when you open the app, so this relies on isPageFocused to trigger a first load of the feed itself. And since loading happens lazily, we need a loading state ready for the user on each swipe, hence the change to loading logic to show a default loading state only if isInitialLoading = true.
isInitialLoading is named after the same feature in React Query.

@onmyouji no problem. The issue here was that we were loading posts for every pinned feed on startup. That part has been fixed. We do still need to load a feed's info (like display name) for every pinned feed, but we only load the posts of the feed that you're currently viewing.
We definitely want to help if we can. What kind of device are you using? Is feed loading from your home screen slow too, or is it only the settings page where you reorder your feeds? Thanks!


Bug - Drag&Drop resizes events

Bug - Drag&Drop resizes events

When dragging an event sometimes it resizes. It happens in two latest versions (0.22.1, 0.22.0).
It works fine in version 0.21.0, but it uses old unsave lifecycle methods componentWillReceiveProps and componentWillMount which without UNSAFE_ prefix won't work in React version 17.
Can you please fix this bug?

I cloned the component's repozitory and run it (link). But it doesn't work either in my testing project.
version: 0.22.1
Opera, Chrome, Mozilla Firefox on Ubuntu Budgie

There is a workaround for the resize issue from:
https://github.com/intljusticemission/react-big-calendar/issues/1387#issuecomment-531465438
You add the the specific version in the resolutions of the package.json:
 "resolutions": {
        "date-arithmetic": "3.1.0"
  },

It works!!! :tada: :tada: :tada:
Thank you very much! :+1:

That's still not fixed, every import of react-big-calendar is using ^4.0.1 version of date-arithmetic.
Changing it manually to 3.1.0 on package-lock.json doesn't help, either add "resolutions": {         "date-arithmetic": "3.1.0"   }, to package.json doesn't help

Hello,
Is this problem resolved? Can we remove the dependency on "date-arithmetic": "3.1.0"
Thanks

https://github.com/jquense/date-math/issues/18


How are loop closures supported in GradSLAM?

❓ Questions and Help
Loop closures are not explicitly discussed in the original paper for GradSLAM nor are present in the project's code nor documentation in an explicit way.
As loop closures play a fundamental role in classical SLAM, I'd like to know if you could explain how GradSLAM deals with them.
As far as I could understand from your paper, you use the "active part of the map" (  'Ma' )  from features, which they are matched with sensor data (Pa) in a one-to-many fashion. It is not clear to me if the position and orientation of the sensor plays a role in such matching (e.g. if odometry from the integration of velocities plays a role in sensor-to-map matching).
Furthermore, the  "Differentiable map fusion" is to me the only thing that resembles loop closure as I guess one can consider that when the same object is seen twice, then they are fused ( "or loop closed" ). Is this the case?
Again, it is not really clear whether the position+orientation resulting from velocity integration plays any role there.
The biggest concern I have is that if odometry is not taken into account, then two very similar observations could be easily "fused".
I would also like to know if "Differentiable map fusion" uses odometry and takes the role of loop closure, if it is reasonable to transform its inputs before entering in the "Differentiable map fusion" module so that a custom trained "loop closure detector" can be learnt from data.

Thanks for your interest @paucarre!
In gradslam, at each time step we align the "entire map" with the current frame. This implicitly means that we're performing global optimization at each step (and wouldn't need explicit loop closure detection). However, this also means that currently gradslam can operate in relatively-small environments (as global alignment at each timestep would become computationally expensive for large scenes).

The differentiable map fusion module indeed uses camera poses as input (which may in-turn be computed from odometry). This can be used for learning odometry estimation (but not loop closure detection, since we don't have an explicit loop closure step in gradslam)

Thanks for your answer @krrish94 !
That clarifies a lot.
I was wondering if you see feasible with the current state the following setup to solve the memory problem:

Using a neural network, downsample the high memory 3D textured map to a low-memory 2D map where
it's fesible to do mapping with limited memory resources (which happens often in robotics)

To be specific, say the original high-memory map we call "Detailed_Map" is a pointcloud (as per GradSLAM documentation).
Assume "Detailed_Map" pointcloud has the following tensor-size structure (as per documentation):
Detailed_Map = [
  points = [ (K_1, 3), (K_2, 3), ... , (K_N, 3) ],
  normals = [ (K_1, 3), (K_2, 3), ... , (K_N, 3) ],
  colors = [ (K_1, 3), (K_2, 3), ... , (K_N, 3) ]
]

where both N and K_i are very high (lots of samples with lots of points).
We want to reduce N and K_i in Detailed_Map by flattening and downsampling it to a 2D Compact_Map ("birds eye map").
A neural network would transform the original Detailed_Map to a Compact_Map with the following structure:
Compact_Map = [
  points = [ (H_1, 2), (H_2, 2), ... , (H_M, 2) ],
  normals = [ (H_1, 2), (H_2, 2), ... , (H_M, 2) ],
  embeddings = [ (H_1, L), (H_2, L), ... , (H_M, L) ]
]

Where:

M is very significantly smaller than N ( M << N).
H_i is very significantly smaller than K_i (H_i << K_i ).

Then we perform both Differentiable Map as well as Map Fussion on the Compact_Map with low memory as the
tensor itself will be orders of magnitude smaller.

Compact_Map to Detailed_Map Correspondence

Then the only thing that's left is to establish a correspondence between Compact_Map and Detailed_Map.
As they are locally similar from a 2D point prespective (and ground projected normals), one could try to
reconstruct the Detailed_Map from Compact_Map using a convolutional layer. Something similar to
an autoencoder.

Production setup

An autoencoder-style neural network wourld be trained to downsample Detailed_Map to Compact_Map on a high-memory computer outside the robot.
A 2D map ("birth eye map") would be created using Compact_Map and GradSLAM layers.
The Compact_Map  would be used in the robot for real-time localization.
Overall, I was wondering if setups like that would be feasible within the current state of the project of there
would be major changes in the framework itself of these to be possible. I'm concerned the embedding space would need to be somewhat regularized to behave like RGB colors.


v-model with uninitialized property

Vue.js version
2.0 rc
Reproduction Link
http://codepen.io/anon/pen/xEqbmN?editors=1010#0
What is Expected?
Not sure if this is what is expected in Vue 2.0. Tried to search but couldn't find anything.
e.g:
data: {
  model: {
    a: ''
  }
}

<input v-model="model.a" />
<input v-model="model.b" />

If you pass an uninitialized property (model.b) to v-model, it's obviously not reactive so bindings won't update or a deep watch on this.model won't fire off either.
Any chance that v-model could use Vue.set internally if it detects a binding with value undefined to automatically create reactive properties? (like Vue 1.0)
Or failing that, it should warn when an uninitialized property is passed to v-model

This is an intended change in 2.0 - v-model no longer creates non-existent properties for you, all root-level properties must be declared in data at instance creation.

@yyx990803 is there any other way i can do this in vue2?

It's ok that non-existent properties of data could not be tracked, but when data.row = {} and data.row.username could not be tracked?  Ridiculous.

When building large forms, I now need to duplicate all property names in the template, the data initialiser function (for create) and make sure any objects that are edited have all possible properties present (null value for missing properties) before binding them in vue.
v-model still creates the properties without warning, but not as a reactive property, meaning some properties become reactive and some not, leading to strange behaviour. (for instance when using computed properties)
A custom v-model directive can be a solution, but it's a pity the default behaviour has changed.

@yyx990803 we definitely need this as well to have bindings to non-existend sub-properties. Any workarounds? The models we're dealing with here are way to big to provide default stuff (also, this is send to the API and is just messy).

@codeofsumit You should always try to fill the data property. If that's not possible use Vue.set
Next, time please, use the forum or StackOverflow for questions. Thanks 🙂

@posva I'll follow up on this in the forums. Thank you!

This seems like a big deal. Is it just root-level properties or properties on root-level properties as well? My data has a root level property declared. When edit an existing object, I pull that record from the API. The API (as most I have seen) does not serialize null values. Instead it ignores them. In this case, is vue incapable of adding that property via v-model? I am seeing strange behavior like @laurentvdl points out. As I edit a form with 10 values. Sometimes properties get created and sometimes they don't.

According to the documentation, v-model="item.prop" is just syntactic sugar for:
v-bind:value="item.prop" v-on:input="item.prop = $event.target.value"
So to achieve what we all (except Evan) want, we should stop using v-model="item.prop" and start writing: v-bind:value="item.prop" v-on:input="$set(item,'prop',$event.target.value)" which is sugar free and sad.

This behavior seems to have been reverted. In the latest version 2.5.16, reactivity also works with previously uninitialized properties. Can't find the pull request that brought this back, though.


make release notes required from CLI

Enforce CLI release to come with an initial release notes to best support the breaking changes story.
PTAL @jonathan-codaio @patrick-codaio @alan-codaio
cc @erickoledadevrel
-> % npx ts-node cli/coda.ts release test/packs/fake_v2.ts
coda.ts release <manifestFile> [packVersion]

Set the Pack version that is installable for users. You may specify a specific
version, or omit a version to use the version currently in the manifest file.
The version must always be higher than that of any previous release.

Options:
      --version  Show version number                                   [boolean]
      --help     Show help                                             [boolean]
  -n, --notes    Notes about the contents of this Pack release
                                                             [string] [required]

Missing required argument: notes
Please provide release notes, which will be shown to Pack users to understand the release.

Making them required feels like it adds unnecessary friction for those that are building for their internal team, etc. If we make release notes editable, then I think we don't need to be so forceful as to always require them.

If we don't require it, it would likely to be always ignored. Even codans would ignore release notes.
As a result the release history page observed by the pack user will be completely empty.
I understand that internal tool pack may not need a release note (I doubt though as the maker would have no idea what they have released, just like I have no idea what we have released for 1pp), most pack makers are for public packs and they should attach a release note.
At the very minimum, a release with breaking changes should be forced to add notes.
Also curious what others think.

most pack makers are for public packs

FWIW, I don't think this is true today (or at least not overwhelmingly the case). This is not a one way door so I'm fine proceeding, but I think we shouldn't forget about the significance of the internal Pack use case.

sure. I agree that "public" isn't the correct thing here.
What I meant to say is that even for internal packs, you'd only create a release when you are sharing the pack to someone else (otherwise you just create a build, which doesn't require a note). And in that case, we should prompt them to enter a release note so that whoever using the pack (not the pack maker) would have some information of what happened.


workspaceFolder not usable from vsconan/config.json

It would be useful to have ${workspaceFolder} available from vsconan/config.json files. Some profiles could be part of the project directory itself, and they can't be referenced reliably.

hi @tamasmeszaros
thanks for the input, I will take care of this :)


tests: use testing helpers for env and cleanup

Codecov Report
Patch and project coverage have no change.

Comparison is base (37196ea) 33.98% compared to head (9faaded) 33.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #992   +/-   ##
=======================================
  Coverage   33.98%   33.98%
=======================================
  Files         101      101
  Lines       12201    12201
=======================================
  Hits         4147     4147
  Misses       7651     7651
  Partials      403      403

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Snyk] Upgrade org.apache.logging.log4j:log4j-api from 2.14.1 to 2.22.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-api from 2.14.1 to 2.22.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 11 versions ahead of your current version.
The recommended version was released 2 months ago, on 2023-11-17.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


⚠ Bofrost.fr has degraded performance

In 2933ba9, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1156 ms

Resolved: Bofrost.fr performance has improved in 97eac4b after 6 minutes.


In either case, prometheus records multiple metrics with the instance ip in, and the dashboard fails.
This uses aggregation functions to get sensible output in either case
I've switched between max and min to try and be pessimistic where appropriate (e.g. max for generations and total replicas, min for available replicas etc.)
Shouldn't really matter given multiple copies should report the same data anyway

Great stuff! Do you think it's worth bumping the kube-state-metrics deployment to at least have two replicas then? As in HA by default.

@brancz Yeh, sounds good, done :)

Awesome! lgtm :+1:


[DataFactory]SDK for Object Type and Readsettings name change

SDK generated based on the swagger change: https://github.com/Azure/azure-rest-api-specs/pull/6396

Your project has been excluded from build.
  azure-sdk-for-net/sdk/datafactory/Microsoft.Azure.Management.DataFactory/src/Microsoft.Azure.Management.DataFactory.csproj

     Line 28
  in
  4cd52b6

       <ExcludeFromBuild>True</ExcludeFromBuild>

Either delete that property or set it to false.
Similarly check your test project and make sure they are set to build and execute tests.
This test was excluded because it was failing to build and execute tests.
Updated. Thanks. also updated ExcludeFromTest of test project to false which I assume that needs to be updated as well.

@wenbof  Please also update the changes in  https://github.com/Azure/azure-sdk-for-net/blob/4cd52b69d495cadef4c6548e66638818c2ad3072/sdk/datafactory/Microsoft.Azure.Management.DataFactory/src/Microsoft.Azure.Management.DataFactory.csproj#L11
And also make this:
True
into
False

@wenbof My previous comment doesn't show up properly. It was about this line:
https://github.com/Azure/azure-sdk-for-net/blob/4cd52b69d495cadef4c6548e66638818c2ad3072/sdk/datafactory/Microsoft.Azure.Management.DataFactory/src/Microsoft.Azure.Management.DataFactory.csproj#L28
The true should be changed to false here.

@wenbof please add serialization samples for all the types for below changes:

Added support for the follwoing new datasets in ADF - ParquetDataset, DelimitedTextDataset, SapTableResourceDataset
Added a new property dataProxyProperties to Integration Runtime
Added new SapTable Linked Services type

And at least one of which for below changes:

Added types for Read and Write Connector settings in activities - AzureBlobStorageReadSetting, AzureBlobFSReadSetting, AzureDataLakeStoreReadSetting, AmazonS3ReadSetting, FileServerReadSetting, FtpReadSetting, SftpReadSetting, HttpReadSetting, HdfsReadSetting,
AzureBlobStorageWriteSetting, AzureBlobFSWriteSetting, AzureDataLakeStoreWriteSetting, FileServerWriteSetting, FormatReadSetting, DelimitedTextReadSetting, FormatWriteSetting, DelimitedTextWriteSetting
Added new Copy sources - SapTableSource, SqlServerSource, AzureSqlSource
Added new Copy sinks - ParquetSink, SqlServerSink, AzureSqlSink


Update README.MD

Add --save option for npm install

This is more of an example indicating the name of the package as it appears in npm rather than what command makes sense for an individual's actual use case.

Casey, I've know my PR is annoying 🙂 but although you feel this is an example, most devs just copy paste the code into the terminal, there are several reasons for this, one being not typing the package name wrong and installing something else.
Just trying to be helpful


Move Twitter workflow to upon PR merge instead of PR open

using https://stackoverflow.com/a/59588725/12486544 and https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-workflow-when-a-pull-request-merges
I'm not 100% sure this will work correctly... hard to test these things.

Let's give it a try

Sorry @logankilpatrick looks like I didn't copy over the formatting change from https://github.com/JuliaRegistries/General/pull/60880 - want to a make a PR against the new workflow?

I update it in #4818af2

Ah just saw that, alright! Now we wait for a package to be merged :)

Yes, looks like #60696 is close


Add Microsoft copyright header to scripts contributed by Microsoft

Overview
To make sure we're in compliance with the copyright header rules, this adds the header to any Powershell or Python script that was contributed by a Microsoft employee. Most of these are custom to do with our CI.
We normally keep on top of this for C# scripts well, but seems we've overlooked some non-C# scripts.
Follow-up to https://github.com/microsoft/MixedRealityToolkit-Unity/pull/8102.

/azp run


Unable to install rancher 2.x (pod logs show - waiting for server-url setting to be set)

What kind of request is this (question/bug/enhancement/feature request):
QUESTION
Steps to reproduce (least amount of steps as possible):
Install rancher with helm with default ingress.
Result:
Pods, services and ingress is created along with tls secret. But pod logs show:
2018/12/27 12:26:05 [ERROR] ClusterController local [cluster-deploy] failed with : waiting for server-url setting to be set
W1227 12:38:13.742910       7 reflector.go:341] github.com/rancher/rancher/vendor/github.com/rancher/norman/controller/generic_controller.go:144: watch of *v1.Endpoints ended with: too old resource version: 230131 (231742)
2018/12/27 12:42:45 [ERROR] ClusterController local [cluster-deploy] failed with : waiting for server-url setting to be set
2018/12/27 12:49:02 [INFO] Running cluster events cleanup
2018/12/27 12:49:02 [INFO] Done running cluster events cleanup
2018/12/27 12:49:02 [ERROR] ClusterController local [cluster-deploy] failed with : waiting for server-url setting to be set
2018/12/27 12:49:02 [ERROR] ClusterController local [cluster-deploy] failed with : waiting for server-url setting to be set
2018/12/27 12:49:02 [ERROR] ClusterController local [cluster-deploy] failed with : waiting for server-url setting to be set
W1227 12:50:09.748887       7 reflector.go:341] github.com/rancher/rancher/vendor/github.com/rancher/norman/controller/generic_controller.go:144: watch of *v1.Endpoints ended with: too old resource version: 233650 (234370)
2018/12/27 12:59:26 [ERROR] ClusterController local [cluster-deploy] failed with : waiting for server-url setting to be set
W1227 13:07:27.753790       7 reflector.go:341] github.com/rancher/rancher/vendor/github.com/rancher/norman/controller/generic_controller.go:144: watch of *v1.Endpoints ended with: too old resource version: 236332 (238243)
2018/12/27 13:16:06 [ERROR] ClusterController local [cluster-deploy] failed with : waiting for server-url setting to be set
W1227 13:23:21.759282       7 reflector.go:341] github.com/rancher/rancher/vendor/github.com/rancher/norman/controller/generic_controller.go:144: watch of *v1.Endpoints ended with: too old resource version: 240195 (241815)

The UI is never accessible. It returns 404.
Environment information

Installation option (single install/HA):
HA

Please check the troubleshooting steps mentioned in https://rancher.com/docs/rancher/v2.x/en/troubleshooting/rancherha/, especially the created ingress (has to match the URL you are trying to visit) and the logs of the ingress controller which will reveal why it can't route the request to the correct destination.

I've checked the rancher pod logs and I've already added the logs I am seeing. Apart from the ingress is fine. It is showing correct host along with an IP address. And nginx ingress logs are something like this:
I1227 08:49:29.699197       8 status.go:388] updating Ingress cattle-system/rancher status to [{<IP_ADDRESS> }]
I1227 08:49:29.726742       8 event.go:221] Event(v1.ObjectReference{Kind:"Ingress", Namespace:"cattle-system", Name:"rancher", UID:"3412ff52-09b4-11e9-8989-2cfda16d3cfd", APIVersion:"extensions/v1beta1", ResourceVersion:"182643", FieldPath:""}): type: 'Normal' reason: 'UPDATE' Ingress cattle-system/rancher
I1227 08:49:29.774255       8 event.go:221] Event(v1.ObjectReference{Kind:"Ingress", Namespace:"cattle-system", Name:"rancher", UID:"3412ff52-09b4-11e9-8989-2cfda16d3cfd", APIVersion:"extensions/v1beta1", ResourceVersion:"182646", FieldPath:""}): type: 'Normal' reason: 'UPDATE' Ingress cattle-system/rancher
I1227 08:49:29.905277       8 backend_ssl.go:189] Updating local copy of SSL certificate "cattle-system/tls-rancher-ingress" with missing intermediate CA certs
I1227 08:49:33.061531       8 controller.go:172] Configuration changes detected, backend reload required.
I1227 08:49:33.282003       8 controller.go:190] Backend successfully reloaded.

Is there anything else I should check?


Windows binary

Dear @ozwaldorf, is there a chance that you will make your program available to a wider audience by releasing an executable file for Windows 7 x64?

Can you try this build?
x86_64-pc-windows-gnu.tar.gz

Added to the last release, and I'll start building these for future releases

Added to the last release, and I'll start building these for future releases

0.9.0 works fine on my end, but 0.10.0 has no Windows build.

Added to the last release, and I'll start building these for future releases

0.9.0 works fine on my end, but 0.10.0 has no Windows build.

Fixed! Setup a CI builder I can dispatch on any revision to easily build this for releases

See https://blog.rust-lang.org/2024/02/26/Windows-7.html

Yep, it makes me sad. Go, Python, Rust programming languages turned out to be modern Trojan horses. Under the guise of progress, they have become a tool for dividing people into classes: the golden billion and the rest. Thank goodness this did not affect C language, for its apps can still be compiled for the widest range of hardware and operating systems, including Windows 7.

Added a legacy-windows binary built with rustc 1.77.2

Thank you for staying true to the mission of helping humanity through technology.


Implement Standard Header

See the ruleset and my PR to the current homepage.

This looks good to me.

Publius Scribonius Scholasticus
On Wed, May 24, 2017 at 9:39 AM, Gaelan<EMAIL_ADDRESS>wrote:

See the ruleset and my PR to the current homepage.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/AgoraNomic/wiki/issues/7, or mute the thread
https://github.com/notifications/unsubscribe-auth/AbchWl8z3UR_Yiec11DuGzuyWSQWN-K0ks5r9DL4gaJpZM4NlHtx
.


line 40 on NETCONF mission answer

Hey guys! Would you mind checking line 40 on the NETCONF lab answer ? I believe it should be interfaces instead of interface. Thanks in advance!

This is still a problem.. there were multiple PRs for it (#31 and #33) but they never seemed to have been merge.

Yeah, not sure why the forks were deleted, I've now fixed it.


Data cleanup job fix

This contains 2 fixes.

Store deletion and Store retention change along with DataRetention job.
tar ball does not contain contrib jar and causes the shell to fail with weird class/schema missing exceptions.

LGTM!

Rebased and Merged https://github.com/voldemort/voldemort/commit/71280330a8ecb6a60409f0a2594445ef568da150 https://github.com/voldemort/voldemort/commit/b1284224a62bb7ac95d162b652a5b1ddc035c459


refactor volume_stats and stats

Is this a BUG REPORT or FEATURE REQUEST or IMPROVEMENTS?

Improvements

lot of the codes are uncommented,  need to put the function level comments.
Follow generic approach, i.e, reuse of the variables of similar types.
Make use of OOPS, i.e, Bind the methods with suitable struct types
remove redundant code

merged via openebs/maya#172


Miwaku Kabe

After merging and deploying, please delete the "ghost" (https://fiveringsdb.com/card/miwaku-district).
My bad, sorry =_=

Ok I fixed it. When there's such an error on a card name, the card id is wrong, and if the card id is wrong, and the card is used in a deck, I have to update the deck to replace the wrong id. It's dangerous and annoying. That should not happen anymore since we're only including official previews, but even then, mistakes can happen. So let's double-check before we submit ;)


Permission Denied during 'git clone git@github.com:SpongePowered/Sponge.git'

Trying to do git clone git@github.com:SpongePowered/Sponge.git and got:
Cloning into 'Sponge'...
The authenticity of host 'github.com (<IP_ADDRESS>)' can't be established.
RSA key fingerprint is 16:27:ac:a5:76:28:2d:36:63:1b:56:4d:eb:df:a6:48.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added 'github.com,<IP_ADDRESS>' (RSA) to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

Either generate an ssh key or clone from https://github.com/SpongePowered/Sponge. And please learn how to use git/gradle before creating useless issues on this project.


Repeating Error Causes Lag

The errors start when Foundry boots up, and continue if the game is unpaused, causing input lag.
I have tried with no mods, and still get the error. Here is a screenshot (I used Find the Culprit).
Browser: Chrome 130.0.6723.117 (Official Build) (64-bit), Foundry 12.331, PF2E 6.6.1

This is due to very old, unmigrated data. Please feel free to seek support on Discord.

Actually, I did post this to the PF2E system Discord...


Allow auto edit/delete of lessons/routines from timetable when a lesson/routine is edited/deleted

Codecov Report

Merging #105 into master will decrease coverage by 0.08%.
The diff coverage is 27.77%.

@@             Coverage Diff              @@
##             master     #105      +/-   ##
============================================
- Coverage     44.57%   44.49%   -0.09%
- Complexity      581      582       +1
============================================
  Files           161      161
  Lines          3118     3135      +17
  Branches        397      397
============================================
+ Hits           1390     1395       +5
- Misses         1634     1646      +12
  Partials         94       94

Impacted Files
Coverage Δ
Complexity Δ

.../seedu/address/model/person/UniqueRoutineList.java
38.29% <0.00%> (-0.84%)
17.00 <0.00> (ø)

...ava/seedu/address/model/person/UniqueSlotList.java
34.54% <22.22%> (-2.42%)
8.00 <0.00> (ø)

src/main/java/seedu/address/model/AddressBook.java
64.75% <33.33%> (-0.25%)
36.00 <0.00> (ø)

...ain/java/seedu/address/model/person/Timetable.java
66.66% <50.00%> (-4.77%)
6.00 <1.00> (+1.00)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec7a851...788fc14. Read the comment docs.


Help With Scatter Reads

Hi, I'm learning to program now, I saw that you use scatter, I couldn't identify how you read several address strings with scatter to make it quick?
type:
read A = 0x500
and in the same function read B = A + 0x600

So what you're doing is impossible, picture it like this:
So you are sending off a package of reads, This package of reads has 2 addresses
a = Class + 0x10
b = (a) + 0x50
Once it gets the bundle of reads it just says, DO IT and sends all the reads at once but returns them all at the same time too not one by one. So the variable A is set at the same time a B so when you packaged up the data to the card it just got A = Class + 0x10 and B = 0+0x10 as A doesn't have a value yet.
If you want to use scatter reads then you must loop your entities multiple times and read each part individually, so i loop over players in my player caching to get the address, then I loop again read to get the base projectile class and player model, Then i loop over it again and get the position.  So I use 3 loops but I am getting all the entities addresses at the same time and then reloop using those addresses so i can get all of the playemodels at the same time. Therefore instead of packaging all the reads for 1 player at once, we use it to package 1 or 2 reads for all players at once.
Here is my code example for caching the player list:
	if (VisiblePlayerList == 0)
		return;
	std::vector< std::shared_ptr<BasePlayer>> templayerlist;
	uint32_t size = TargetProcess.Read<uint32_t>(VisiblePlayerList + VisiblePlayerListSize);
	uint64_t buffer = TargetProcess.Read<uint64_t>(VisiblePlayerList + VisiblePlayerListBuffer);
	if(size == 0 || buffer == 0)
		return;
	std::vector<uint64_t> playerlist;
	playerlist.resize(size);
	auto handle = TargetProcess.CreateScatterHandle(); // create bundle
	for (int i = 0; i < size; i++)
	{
		TargetProcess.QueueScatterReadEx(handle, buffer + (0x20 + (i * 8)), reinterpret_cast<void*>(&playerlist[i]), sizeof(uint64_t)); // get all the addresses

	}
	TargetProcess.ExecuteScatterRead(handle); // execute the bundle
	TargetProcess.CloseScatterHandle(handle);
	handle = TargetProcess.CreateScatterHandle(); // new bundle
	for (int i = 0; i < size; i++)
	{
		if (playerlist[i] == NULL)
			continue;
		templayerlist.push_back(std::make_shared<BasePlayer>(playerlist[i], handle)); // create into class, this will intiailize a scatter read in the class constructor

	}
	TargetProcess.ExecuteScatterRead(handle); // execute the bundle
	TargetProcess.CloseScatterHandle(handle);
	handle = TargetProcess.CreateScatterHandle(); // new bundle
	for (int i = 0; i < templayerlist.size(); i++)
	{
		std::shared_ptr<BasePlayer> player = templayerlist[i];
		player->IntializeClasses(handle); // this contains a scatter read for the player model class
	}
	TargetProcess.ExecuteScatterRead(handle); // execute the bundle
	TargetProcess.CloseScatterHandle(handle);
	handle = TargetProcess.CreateScatterHandle(); // new scatter read
	for (int i = 0; i < templayerlist.size(); i++)
	{
		std::shared_ptr<BasePlayer> player = templayerlist[i];
		player->SetName(handle); // read the name
		player->SetNPC(handle); // read if its an npc
	}
	TargetProcess.ExecuteScatterRead(handle); // execute the bundle
	TargetProcess.CloseScatterHandle(handle);
	PlayerList = templayerlist;

As you can see I go step by step scatter reading the player's information so I never use an address that's going to rely on an address that I don't already have, if I need an address for a read then I read it all in 1 bundle, make a new loop and read what i need from there. Just keep making loops for each layer of information you need down the classes.

Thank you for such a complete answer.
I have another doubt, I have another doubt, i looked you eftrecode, How do you access the offsets?

Is this only possible in C#? or is it possible in python too?

Sure, You can access mono types and fields in python externally, You need to adapt one of these sources to use python:
https://github.com/reahly/mono-external-lib
https://github.com/imerzan/MonoSharp


Add warning for deleted files to prevent errors during processing

Hey guys,
I was working on an extension, where I deleted the default YourContract.sol file, which resulted in an error when I tried to use yarn create-extension {projectName}.
Steps to reproduce:

yarn cli
Delete e.g. the YourContract.sol file
yarn create-extension {projectName}

After this fix it should work like this:

Hey thanks @moltam89! actually, the real problem was that since we were finding diff earlier like:
const { stdout } = await execa("git", ["diff", "--name-only", `${firstCommit.trim()}..HEAD`], {
    cwd: projectPath,
});

Timeline: 1. initial commit (had YourContract.sol), 2. In second commit you removed YourContract.sol)
Now because of the above git logic. Even though you removed YourContract.sol in second commit the above result of stdout would still contain YourContract.sol. We have to pass --diff-filter=d to tell git exclude deleted files.

Another improvement I pushed tp create-extension CLI is let suppose, Timeline:

Initial commit
Createa file and add it as commit (In this example I created this commit adding a new page)
I run yarn create-extension <instance_path> (This will copy newly created page in cli/externalExtension/<instance_name>
I delete that page from instance, commit and now I run create-extension command again. This will delete the file from cli/externalExtension/<instance_name> since extension developer don't want this file anymore in his extension.

 Test instructions:

Clone my instance outside of this CLI repo.

git clone https://github.com/technophile-04/ctf-extension-instance.git && cd ctf-extension-instance

Now we switch the instance to where we added a new page

git checkout c6eb90c666cdfee52a31ca969fb9ee62864066c5

We go to CLI repo and run it to generate the extension.

yarn build:dev && yarn create-extension ../ctf-extension-instance

^ This will create a new page in extensionExtension/ctf-extension-instance

Now in Clonned instance repo we switch to main commit where we deleted the newly added page.

git checkout main

In CLI repo we again run the command it shall delete he deleted page from extension too.

yarn create-extension ../ctf-extension-instance

Thanks @technophile-04 ,
This is a thorough solution, works great for me!

Thanks @rin-st for the review just pushed the tweak 🙌

Thank you! Lgtm!

Thank you Shiv, great PR!

Oops, @moltam89 thank you for idea and PR too!


Product that you are trying to add is not available

Describe the bug
"Product that you are trying to add is not available" this message is not cleared when visiting other available product
Expected behavior
"Product that you are trying to add is not available" this message should be cleared after page refreshed..
Current Behavior
"Product that you are trying to add is not available" this message not cleared when visiting available product..its stays there and cleared when add to cart button pressed..
Screenshots*

Smartphone (please complete the following information):

Magento Version: [e.g. 2.2.3]
Device: [e.g. xiaomi mi mix2]
OS: [e.g. miui 10]
Version [e.g. <IP_ADDRESS>]

@mak147 thanks for the report, @Dtema1996 please take a look.

Yes perfectly working now

No actions were taken still has to be reviewed.

Ohh sorry i thought you fixed it.

@troublediehard check it out, please

done


Issue with constructing vectors

Hiya, Loving this module so far, but I have an issue constructing a 3 dimension vector.
I have a large array of floats that represent 3d vertices. I wish to loop over them on a per vertex basis so i constructed the following piece of code.
for(int i=0; i<n; i++) {
   vec3 v = VEC3(array[i+0], array[i+1], array[i+2]);
}

But this gives me the following compile error (using g++)
linmath.h:148:30: error: array must be initialized with a brace-enclosed initializer
  #define VEC3(x,y,z)   (vec3){x,y,z}
                              ^~~~~~~
vertexbuf.h:76:17: note: in expansion of macro ‘VEC3’
       vec3 p1 = VEC3(grid[i+0], grid[i+1], grid[i+2]);

Am I doing something wrong here?

Well, to initialize a struct you can omit the (vec3) and just write
vec3 v = {array[i+0], array[i+1], array[i+2]};

No need for that VEC3 macro.

Thanks! Makes sense. Still wondering what the macro is for then.

The macro is for returning vec-s from functions.
vec3 foobar(…)
{
    /* ... */
    return VEC3(a,b,c);
}


can List concat serializes the objects in the list before adding it to the resulting list

Fiddle:
http://jsfiddle.net/qYdwR/2468/
when you click on a source item (either), it adds it to a bucket
I concat both buckets and check if the item is in either before adding it
the concat clones the items into a new array/list rather than just putting the item itself in the new array/list
the item should still be the same item after a concat
just also be in the new list/array
https://github.com/bitovi/canjs/blob/master/list/list.js#L998
Thoughts?

Sooo we need some discussion on this, via #1758
Points of argument:
1) The problem in #1758 says that if your can.List has a custom Map Type, pushing a new item which is already a map of some other type onto that list, you would expect the pushed item to be converted to the custom Map Type because the List's Map Type is set.
2) The problem in this issue ( #1616 ) is that concat was serializing the items from each input list before creating the concatenated output List, which means:
sourceList[ 0 ] !== ( sourceList.concat( [] ) )[ 0 ];
which is wrong by typical definition of concatenation.
-- The list created by concat uses the same constructor as the list on the left side of the argument
Goals/Discussion:
1) Be consistent. Which should we favor?:
-- Any item in the List should be the same type as it's Map Type, so all List methods should type cast.
OR
-- List methods should behave like array methods ( without type casting the args ) so any type casting needs to be done manually.
2) Should we give the option for either?
someList.push( /* can push fn, type enforced / );
someList.push.raw( / vanilla push fn, no type casting */ );
3) Document this behavior for each method. ( even if we don't resolve the inconsistency? )

Can't we check the type?
Sent from my iPhone

On Sep 17, 2015, at 1:58 PM, James Atherton<EMAIL_ADDRESS>wrote:
Sooo we need some discussion on this, via #1758
Points of argument:

The problem in #1758 says that if your can.List has a custom Map Type, pushing a new item which is already a map of some other type onto that list, you would expect the pushed item to be converted to the custom Map Type because the List's Map Type is set.

The problem in this issue ( #1616 ) is that concat was serializing the items from each input list before creating the concatenated output List, which means:
sourceList[ 0 ] !== ( sourceList.concat( [] ) )[ 0 ];
which is wrong by typical definition of concatenation.
-- The list created by concat uses the same constructor as the list on the left side of the argument

Goals/Discussion:

Be consistent. Which should we favor?:
-- Any item in the List should be the same type as it's Map Type, so all List methods should type cast.
OR
-- List methods should behave like array methods ( without type casting the args ) so any type casting needs to be done manually.

Should we give the option for either?
someList.push( /* can push fn, type enforced / );
someList.push.raw( / vanilla push fn, no type casting */ );

Document this behavior for each method. ( even if we don't resolve the inconsistency? )

—
Reply to this email directly or view it on GitHub.

To further clarify, should it be more like:
concat: function () {
			var args = [];
                        var MapType = this.constructor.Map;
			can.each(can.makeArray(arguments), function (arg, i) {
				args[i] = (arg instanceof can.Map) && !(arg instanceof MapType) ? arg.serialize() : arg;
			});
			return new this.constructor(Array.prototype.concat.apply(can.makeArray(this), args));
		},

Closing for: https://github.com/canjs/can-list/issues/3


FluidDict incompatibility with Mekanism

In a pack with AdvancedRocketry-1.10.2-1.2.0c, LibVulpes-1.10.2-0.2.3, and Mekanism-1.10.2-<IP_ADDRESS>1, I'm running into an oxygen issue. When attempting to pipe oxygen into an oxygen vent, it does not accept it. The same thing happens with the gas charging pad. If I put oxygen into a pressurized tank, the tank accepts it - but when I put that tank into a spacesuit, I still suffocate in Survival Mode.
After some testing (with lots of help from a friend, MrEldritch), it seems that this is an inter-mod issue with Mekanism. Removing Mekanism allows the exact same setups to work as intended.
My guess here: Since Mekanism also supplies a Forge Fluid called Oxygen, it must grab the name for its fluid class. However, Advanced Rocketry is (apparently?) checking for the specific class instance or class when checking to see if a fluid is oxygen.
It would also be worth checking to see if the same issue occurs with hydrogen, since Mek also supplies a Hydrogen fluid, but I haven't tested that at all yet.
Please let me know if you need any more info! I'm a bit rusty at submitting MC mod bug reports. Logs didn't seem necessary in this situation but I can provide logs if you'd like.

If you could provide logs, or at least the line specifying the default fluid used for oxygen, that would be helpful

Wow, okay, good idea. Weirdly enough, this is what I have:
[19:43:58] [Server thread/DEBUG] [FML/]: The fluid advancedRocketry:oxygen has been selected as the default fluid for oxygen
I have just tested again, and confirmed that this bug only occurs when Mekanism is installed. Removing Mekanism and only Mekanism from the pack fixes the issue. So, it's still an inter-mod issue with Mek, even though advancedRocketry:oxygen is the default fluid for oxygen.

I was looking through mekanism's code and noticed his fluid is actually registered as "liquidoxygen".  Can you see if that shows up as a fluid as well?  And if so what other mods that supply oxygen are you testing with other than mekanism and AR?  Have you tested to see if oxygen produced by AR is still compatible?

Here are some screenshots of the testing setup. This works with Mekanism removed from the modpack:

Strange indeed.  I'll see if I can replicate this on my end.

Interesting. I was producing AR Rocket Fuel using Mekanism oxygen and hydrogen earlier today on MC 1.7.10.

I think we're talking about 1.10. That being said, I can produce rocket
fuel fine from fluids carried from the electrolyser to the chemical reactor
through mekanism fluid pipes, and if I use a pressurized tank block I can
convert the tanks of hydrogen back to liquid which the rotary
condensentrator works fine with, so I'm at a loss here.
On May 30, 2017 4:17 PM, "Kin37ix"<EMAIL_ADDRESS>wrote:

Interesting. I was producing AR Rocket Fuel using Mekanism oxygen and
hydrogen earlier today on MC 1.7.10.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/zmaster587/AdvancedRocketry/issues/663#issuecomment-305011100,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJzt6kRKuJ7-Db7EnKmmwkh-MzzNDWjQks5r_IdngaJpZM4No4a_
.

@TheGuyRunningSouth  I know that's why I specified. I did not see the OP say anything about a condensentraror.
@NotGyro are you converting the gas into fluid first?

Would you be willing to test again with the latest build of libvulpes/advanced rocketry on here: http://<IP_ADDRESS>:8080/
Apologies for my poor naming conventions, roundplanets/unstable is the 1.2.x builds and the other builds are for 1.0.x builds

Humm, I've tested with AdvancedRocketry-1.10.2-1.2.1-23, LibVulpes-1.10.2-0.2.4-14, and Mekanism-1.10.2-<IP_ADDRESS>1. I have the gas charge pad fed from the output of an advanced rocketry electrolyser, but it still won't charge my suit.

@Shados is the primary maintainer of the modpack I'm testing.
The latest update has resolved the issue with the oxygen vents for me, but as @Shados said, the problem with the gas charge pads is still not resolved. They do accept piped-in oxygen, now, but they will not charge suits with that oxygen.
Kudos for fixing the oxygen vents, though!

Suits should be fixed now, and you're welcome!


Newbie has errors on Neptune 4 Pro

Hello,
I was given a Neptune 4 Pro and a link that helped me configure the LAN connection. I am total new to Klipper and to Github, never got the hang of it, it's not intuitive for me so please have patience.
On the home page I have some errors. One of them I managed to solve following a discussion (issue 83) here, but I'm stuck with the rest:
Moonraker warnings found.
[update_manager]: Failed to load extension display: Invalid path for option path in section [update_manager display]: Path /home/mks/display_connector does not exist
Unparsed config option 'primary_branch: ' detected in section [update_manager display]. This may be an option no longer available or could be the result of a module that failed to load. In the future this will result in a startup error.
Unparsed config option 'virtualenv: /home/mks/display_connector/venv' detected in section [update_manager display]. This may be an option no longer available or could be the result of a module that failed to load. In the future this will result in a startup error.
Unparsed config option 'requirements: requirements.txt' detected in section [update_manager display]. This may be an option no longer available or could be the result of a module that failed to load. In the future this will result in a startup error.
Unparsed config option 'origin: https://github.com/OpenNeptune3D/display_connector.git' detected in section [update_manager display]. This may be an option no longer available or could be the result of a module that failed to load. In the future this will result in a startup error.
The printer is printing fine, but those errors annoy me so I decided to get them solved.

Please see:
https://github.com/Clon1998/mobileraker_companion/issues/83#issuecomment-2217960466


Added CUAD dataset

Dataset link : https://github.com/TheAtticusProject/cuad/
Working on README.md currently.
Closes #2084 and #1.

Changed the language in a few places apart from those you mentioned in README
Reduced the size of dummy data folder by removing all other entries except the first
Updated YAML tags by using to the past version of datasets-tagging app. Will update the quick fix on that repository too in a while

@bhavitvyamalik  Thanks for adding the dataset on huggingface! Can you please add a metric also for the dataset using the squad_v2 metric file?

@MohammedRakib you can check #2257


Fixed spacing to avoid glitch in code visualisation

Avoid to have a code block breakage

@andsel This renders beautifully. Thanks for the fix. And thank you for giving me a chance to build it locally and test it. Asciidoc spacing changes can sometimes have unexpected outcomes, and it's always a good idea to validate them.

The red CI is catched with by #18


DRILL-5571: Cancel running query from its Web UI

Currently, a running query can be cancelled by navigating to the Edit Query Tab of the profile page, making it difficult to access. This commit allows the user to cancel from the query page.
In addition, the Duration segment is also made visible by default rather than collapsed.
Screenshot of a running query

Screenshot of a query being cancelled

Screenshot of a query after cancellation

Running Query:

During Cancellation:

Post Cancellation Status:

@kkhatua what kk127 on the screenshot with modal window?

@arina-ielchiieva that is my Drillbit's hostname.

Looks good, please squash the commits.

Squashed and merged with Commit ID c3080fedf9dcfe3d2c12a7942d3f82713be695f2


say goodbye vue polkadot

Rationale
KodaDot started as a fork of our previous project vue-polkadot, to speed-up the process of development we removed a ton of components

removed extrinsics
next batch of removed
removed shared components from vue-polkadot
removed useless views from vue-polkadot
removed wrappers from vue-polkadot
removed shared components from vue-polkadot
removed obsolete components from RMRK::0.0.1

Thank you for your contribution to the KodaDot NFT gallery,
we really appreciate your contribution!
PR type

[x] Bugfix
[x] Feature
[x] Refactoring

Before submitting this PR, please make sure:

[x] Your code builds clean without any erros or warnigns
[ ] You've posted screenshot of demonstrated change in this PR
[x] Merged recent default branch, main and you have no conflicts
[x] Didn't break any original functionality

Optional

[ ] You've tested it on mobile
[ ] Are there any edge cases?

Other
Unused components that stays in the codebase:
- src/components/rmrk/Create/CustomAttributeInput.vue
- src/components/shared/format/Percent.vue
- src/components/shared/OptionDropdown.vue
- src/components/subsocial/BaseCommentSection.vue
- src/components/subsocial/CreatePostModal.vue

LGTM


adding-scatter-matrix-app

Adding my apps one at a time, as Adam recommended :)

Hi @pierreolivierbonin
Thanks for making this a separate PR.  It makes it easier :+1:
I like this app - it's a nice addition! :slightly_smiling_face:
Before this is deployed it needs code formatting with black.  We are using black==21.6b0 to be consistent with dash (which reminds me - we need to add this to the requirements.txt) .

Thanks - this looks great and it's good to go! :woman_dancing:
I have similar comments on the css in the ecdf app.  Would you be able to update that one as well?  Since it's related, it would be ok to make the changes add the commit here, or you could do a separate PR.


Issue about create_color_image_mapped_to_depth and create_depth_image_mapped_to_color

Hey guys,
I've got a RealSense SR300 and I was trying to use RealSense SDK to create a fusion image which used the code below approximately.
intrinsics color_intrin = convert_intrinsics(device->get_stream_intrinsics(rs::stream::color));
intrinsics depth_intrin = convert_intrinsics(device->get_stream_intrinsics(rs::stream::depth));
extrinsics extrin = convert_extrinsics(device->get_extrinsics(rs::stream::depth, rs::stream::color));

// ...
// Got the color image and depth image using the code about the same as in the projection sample.
// ...

// Using the functions below to create fusion image.
auto colorImageMappedToDepth = get_unique_ptr_with_releaser(projection_->create_color_image_mapped_to_depth(depthImage.get(), colorImage.get()));
auto depthImageMappedToColor = get_unique_ptr_with_releaser(projection_->create_depth_image_mapped_to_color(depthImage.get(), colorImage.get()));

I tried to print out extrin's rotation and translation components and it seemed valid. But soon after I created both of the two mapped images, I found out that the translation parameter in the extrinsic is weird. By which I mean either color image or the depth image is shifted horizontally -ish and the mapped images are not in the right place.
I tried to extrin.translation[0] *= 10 to enlarge the x component of translation, and this fixed part of the problem and it seemed almost right but still shifted (after all it's just a work around).
I don't know whether the parameters fixed for every SR300 or it's read dynamically from every hardware and values are all different. But either way I think something is wrong about the extrinsic parameters, or the way I took it.
Any ideas about this situation?

Hi Kun Lin,
Sorry for the late response.
I am currently not completely sure what the problem is. You can try to use rs::stream::rectified_color instead for now, shift should disappear with this work around.
We will come back to you once we figure out the issue and have a proper answer for you.
Meanwhile, I would recommend you to ask about "weirdness" in translation component on the librealsense page: as we simply pass intrinsics and extrinsics data provided by librealsense to our domain (without any additions, as far as I know).
By the way, the SDK do not officially support SR300 camera, only ZR300 (you can see this information in the "Compatible Devices" section in the README.md on the main page).
Thanks for you question!


Use square brackets to denote optional parameters

JSDoc suggests certain formats when it comes to optional parameters and parameters with default values. See https://jsdoc.app/tags-param.html#optional-parameters-and-default-values
Storage libraries followed this guideline until #5791 where it got removed.
This issue is to discuss if we should indeed follow the above format and if yes, then to add it to not just storage, but all other libraries

Hi Ramya, I think JSDoc takes this as a rule/standard instead of a suggestion. We need to follow them if Azure JS SDK decides to follow JSDoc.

What's the status of storage packages now regarding the guideline?
Can we add some pipeline rule to enforce it?

I'll close this in favor of https://github.com/Azure/azure-sdk-for-js/issues/3027.
In the coming months we will look into linter checks that we can add which will help here


FABRIC-install chaincode job fails due incorrect chaincode path

Describe the bug
Chaincode installation jobs fails for fabric 2.0.0 with error as
"Error: error getting chaincode deployment spec for CHAINCODE_NAME"
For "platforms/hyperledger-fabric/charts/install_chaincode/templates/install_chaincode.yaml" at line number 154 we perform a change directory with "cd $GOPATH/src/github.com/chaincode && dep ensure"  command but then again on line no 156 for peer chaincode install command we are using the chaincode path variable value as. "-p github.com/chaincode/${CHAINCODE_NAME}/${CHAINCODE_MAINDIR}" which is not reachable from the present directory which is already at $GOPATH/src/github.com/chaincode/ and the install command is not able to find the chaincode to install
Branch:Master
To Reproduce
Steps to reproduce the behavior:

Set up a new fabric network with details of chaincode to be installed
At chaincode installation step look for logs of Job "installchaincode-{{ $.Values.peer.name }}-{{ $.Values.chaincode.name }}-{{ $.Values.chaincode.version }}"
the job would fail with "Error: error getting chaincode deployment spec for <chaincode_name>: exit status 1
Re executing same commands of install_chaincode.yaml file through a peer cli would present the same error

Expected behavior
Chaincode to get installed and instantiated on the network
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Azure Kubernetes service
Version 2.0.0

Additional context
Add any other context about the problem here.

hi @bafsunsu , can you please provide us more details on the issue as we are not able to reproduce the same from the master branch.
Also a seperate point being we are not actively supporting Hyperledger-Fabric v2.0.0, currently we are supporting HL Fabric v1.4.4 and v2.2.x is in active development.

@lakshyakumar Sorry there was little mistake in the issue description as I had mentioned instantiate_chaincode.yaml files reference instead of install_chaincode.yaml file at "platforms/hyperledger-fabric/charts/install_chaincode/templates/install_chaincode.yaml"
Have updated the issue description and also have created a pull request for this issue fix from my public git hub id(accidentally created issue through baf test github ID)

Can you verify is this is a valid bug on Fabric 2.2 latest code

Can you verify is this is a valid bug on Fabric 2.2 latest code

Closing this issue as Fabric version 2.0.0 is not actively supported by BAF anymore and the bug is not reproducible in the supported fabric version (2.2 and 1.4.4)


[Question] How to Configure SMS Backup+ to Only Backup New SMS and Call Logs to Same Gmail Account?

I have been using the SMS Backup+ app on my Android phone for years now, and it has stored over 100,000 SMS and call logs in my Gmail account. I purchased a new phone, I installed SMS Backup+ on it and configured it with my app password to restore my SMS and call logs. However, the process is taking a lot of time to restore those 100,000+ SMSs and Call Logs on my new phone.
Therefore, I used Superbackup to export my SMS and call logs from my old phone and then quickly imported them into my new phone. Now, all my previous messages and call logs are present on my new phone.
Now, on my new phone I want to configure and automate SMS Backup+ to only back up all the new SMS and call logs to my same Gmail account (because all the previous SMSs and call logs already present there)
When I choose Maximum items per backup to 100, in the staus it shows 👉 https://i.imgur.com/bMcSJdH.jpg
Can anyone please guide me on how to do this?

There is an option to skip existing when you press backup after first installing the app, but for me that causes the app to crash. So, I'm in the same boat as you unfortunately.


freeCodeCamp Cookeville TN

Please provide the following information to aid in adding your group to the directory:
Esssential

[https://www.facebook.com/groups/887942791410756/about/] Group URL (Web address)
[Cookeville] Town or City group is located in
[Tennessee] State / County / Region
[USA] Country

Nice to have

[ ] Co-ordinates

If you have one

[ ] URL of Group Photo

PR submitted


Change the traceId type to be collection in trace graphql protocol.

trace.graphqls
type BasicTrace {
-   traceId: String
+   traceIds: [String!]!
}

Coverage decreased (-0.01%) to 19.497% when pulling 08d26eca09af37d0ca1fd49d9e820381655ea6b6 on peng-yongsheng:feature/queryBasicTraces into a498a91fceade42436fd3d990d31ddd06c218860 on apache:master.


Last update broke things...

Issue Type: Bug
After updating to the latest update my color theme stopped being supported (only some colors are shown correctly - switching to different themes also has the same ugly color being shown for certain elements)
I also randomly got VS studio code settings errors when saving a file (seems to have disappreared at the moment)
VS Code version: Code 1.67.0 (57fd6d0195bb9b9d1b49f6da5db789060795de47, 2022-05-04T12:06:02.889Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info

Item
Value

CPUs
AMD Ryzen 7 1700X Eight-Core Processor          (16 x 3394)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
47.93GB (25.42GB free)

Process Argv
--crash-reporter-id c21d2e72-42b5-4bb2-bfc5-e838104fbedf

Screen Reader
no

VM
0%

Extensions (42)

Extension
Author (truncated)
Version

json-parse-validator
Adr
1.1.2

armview
ben
0.4.6

random-string-password-generator
bib
1.0.2

xslt-xpath
del
1.2.5

EditorConfig
Edi
0.16.4

vscode-pull-request-github
Git
0.42.0

gitkraken-authentication
git
1.0.3

go
gol
0.33.0

terraform
has
2.22.0

randomeverything
hel
0.0.3

angular-essentials
joh
13.0.0

Angular2
joh
13.0.0

firebase-explorer
jsa
0.3.3

json2csv
kha
0.0.1

vscode-github
Kni
0.30.7

rainbow-csv
mec
2.3.0

vscode-language-babel
mgm
0.0.36

vscode-html-format
moh
0.0.4

vscode-azureresourcegroups
ms-
0.4.0

vscode-azurevirtualmachines
ms-
0.5.0

vscode-bicep
ms-
0.6.1

vscode-dotnet-runtime
ms-
1.5.0

data-workspace-vscode
ms-
0.2.0

python
ms-
2022.6.1

vscode-pylance
ms-
2022.4.3

jupyter
ms-
2022.4.1011282140

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.6

azure-account
ms-
0.10.1

vscode-typescript-next
ms-
4.8.20220510

vsliveshare
ms-
1.0.5561

vsliveshare-audio
ms-
0.1.91

vsliveshare-pack
ms-
0.4.0

vscode-streamdeck
nic
4.1.6

indent-rainbow
ode
8.3.1

vscode-yaml
red
1.7.0

glassit
s-n
0.2.4

vscode-scss-formatter
sib
2.4.2

swdc-vscode
sof
2.6.30

tech-debt-tracker
Ste
0.28.4

ms-teams-vscode-extension
Tea
3.8.0

pdf
tom
1.2.0

(3 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
pythonvspyl392:30443607
pythontb:30283811
pythonvspyt551cf:30345471
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscorecescf:30445987
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
pythonvsnew555:30457759
vscscmwlcmt:30465135
cppdebug:30475216
vsclangdf:30486550

Did you see the release notes item about bracket pair colorization?

https://github.com/microsoft/vscode/issues/148977#issuecomment-1120139318

I'm sorry it doesn't work for you. Can you share a screenshot?

After the last update, it seems the file changes watcher is not working. File save does not trigger hot-reloading in my vue.js application. I have to manually re-run my application after each save.

@Vishnu053 that sounds like a different issue.

@Vishnu053 I've just tried modifying main.js in a Vue CLI 5 app started in VSCode 1.67.1 terminal and hot reloading works just fine. You may be having other issues. If you're using @vue/cli 5, you might try re-installing it globally. Also notice the latest webpack update https://github.com/webpack/webpack/releases/tag/v5.72.1 mentions "fix webpack_nonce with HMR" in the release notes... so that might be giving you issues. My app is still using using webpack 5.72.0.
If you're still having issues after updating your dependencies, you might want to open a new issue, as @gjsjohnmurray suggested and tag me there so we can test further.

@lorand-horvath @gjsjohnmurray  reinstalling my vs-code did the trick! Maybe something broke while updating I guess. Thank you so much for your inputs.

Did you see the release notes item about bracket pair colorization?

I did not - just disabled the feature and everything is working as normally. Thanks for the reply!


Use arrow function in the ts code

To be perfectly honest, I am not sure how useful this is, but I thought I put this out there in case there are benefits that I am no aware of.

We will close this issue by inactivity, fell free to reopen it.


Unable to close verification code modal when editing a group

Reproduced with Chrome and Firefox on Linux desktop.
Repro steps

Navigate to any group page
Click the 3 dots next to Update all
Click Edit

Expected results
I can hit esc or click an X in the top right of the modal to close it.
Actual results
The only way to get rid of the modal is to navigate away from the page.

that's not really a bug, although my approach might be flawed.
The idea is that you cannot just dismiss that dialog and continue editing because the verification code is required. Maybe we should add a "Go back" option to the dialog, in case people want to go back to the group's page.

Yeah, it just felt counterintuitive. I think that would be a good solution.

Fixed in https://github.com/wise-old-man/wise-old-man/pull/1506


Poor geodesic distance accuracy in a simple case

Forgive me if my expectations for accuracy are unreasonable for the HEAT method. I have the following minimal example
import numpy as np
from potpourri3d import MeshHeatMethodDistanceSolver

solver = MeshHeatMethodDistanceSolver(np.array([[0, 0, 0], [1, 0, 0], [0, 1, 0]]), np.array([[0, 1, 2]]))
solver.compute_distance(0) # -> array([0.        , 0.70710654, 0.70710654])
solver.compute_distance(1) # -> array([0.91430181, 0.        , 1.31933315])
solver.compute_distance(2) # -> array([0.91430181, 1.31933315, 0.        ])

The fact that the first example is returning distances of sqrt(2)/2 makes it seem like this is a bug rather than a limitation of the method somehow.
Its worth noting that setting t_coef=0.001 makes the results of the second two cases more accurate, but the first case returns [0.        , 0.70710654, 0.70710654] no matter the value of t_coef

Hi! Thanks for reaching out.
What you observe here sounds correct and is the typical behavior of this algorithm. The Heat Method is a PDE-based method, so it works by solving a sequence of partial differential equations on the surface. This is great because it gives it nice smooth results and allows us to leverage fast numerical solvers, but a small downside is that your mesh needs to have enough vertices to accurately represent the solution. This is similar to simulation problems, where simulating on an extremely coarse mesh often doesn't work well.
You should find that if you refine the mesh to have more vertices, the solution quickly becomes more accurate.
For a fancier solution to this problem, intrinsic refinement quickly produce meshes on which PDEs are very accurately solved, while avoiding many of the usual pitfalls of remeshing (however, this refinement is not currently exposed in Potpourri3d, only a simpler intrinsic flipping :) )
I also just added a small note to the potpourri3d readme about topic.

Understood, thanks for the response! It would be great to expose more of the functionality supported by the intrinsic triangulation in general!


PostgreSQL minor version updates (17.2, 16.6, 15.10, 14.15)

The community decided to make a new off-schedule release due to ABI
breakage in last week's release. We're not affected by the ABI
breakage because we rebuild all extensions in our docker images, but
let's stay up-to-date. There were a few other fixes in the release
too.

Corresponding postgres repository PRs:

https://github.com/neondatabase/postgres/pull/528
https://github.com/neondatabase/postgres/pull/529
https://github.com/neondatabase/postgres/pull/530
https://github.com/neondatabase/postgres/pull/531

If this looks good, please approve those too.
There were no merge conflicts.


Fix bundle exec rake install failing

What was the end-user problem that led to this PR?
The problem was that I noticed bundle exec rake install was failing on my gem using the latest prerelease of bundler.
What was your diagnosis of the problem?
My diagnosis was that bundler silences output of rubygems by default, and in a bundle exec context, bundler/setup is always required by subprocesses. So, the rake install task is silencing rubygems, but it requires it to not be silent:
https://github.com/bundler/bundler/blob/bada03dd6d4d15828fb5b2cf7f744948e88a69a3/lib/bundler/gem_helper.rb#L91-L92
What is your fix for the problem, implemented in this PR?
My fix is to wrap the execution of the rubygems subprocess with Bundler.with_original_env so that the gem command runs without bundler involved.

@bundlerbot merge


Use a more descriptive channel name for the resampler

When trying to debug issues with the resampler not getting relevant data, the name of the channel is being used to identify the component and metric with issues, but the string contains other data, which makes it hard to identify the component and metric in the string.
This commit uses a new, more descriptive channel name for for any component metric request, which is also used by the resampler.
The previous string was: component-stream::{component_id}::{metric_id.name}::{start_time}::{namespace}
The new string is: component_metric_request<namespace={namespace},component_id={component_id},start={start_time}>

Updated!

Rebased and updated to use use .name and squashed the Update README commit.

Updated the commit message and PR description too.


[Docs] Typo fixes

This PR fixes the typo errors in Footer of docs
Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit 986433facb7c1fb678186e5ea82a9ef86691b4db at: https://662a094ca409986c89a19247--meshery-docs-preview.netlify.app


fix2443: offline browsing perfomances

Closes #2443 .

@deviantony did the loading screen the most generic way possible. Need to find a way to detect low and high latency environments to avoid 1s loading with high speed responses.
Needed to add a $timeout of 1 sec before removing the loading view to avoid displaying/hidding the loading view when chaining requests.


Railfence cipher in c and c++

🛠 Issue (Number)

Issue no #530
👨💻 Changes proposed

Added Railfence cipher program in c and c++.

✔ Check List (Check all the applicable boxes)

[✔] My code follows the code style of this project.
[✔] This PR does not contain plagiarized content.
[✔] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
Initially the matrix is initialised with "*"
📷 Screenshots
Output in C :

Ouput in c++ :

Ok mam
On Mon, 13 Feb 2023, 11:37 Shreya Sarkar, @.***> wrote:

@.**** requested changes on this pull request.
remove .exe files
—
Reply to this email directly, view it on GitHub
https://github.com/Kumar-laxmi/Algorithms/pull/558#pullrequestreview-1294991106,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATCQWHSFLXI67UIJYTI5YTDWXHFQPANCNFSM6AAAAAAUZIWN7I
.
You are receiving this because you were assigned.Message ID:
@.***>

Please review done the mentioned changes
On Mon, 13 Feb 2023, 11:37 Sri Harika, @.***> wrote:

Ok mam
On Mon, 13 Feb 2023, 11:37 Shreya Sarkar, @.***>
wrote:

@.**** requested changes on this pull request.
remove .exe files
—
Reply to this email directly, view it on GitHub
https://github.com/Kumar-laxmi/Algorithms/pull/558#pullrequestreview-1294991106,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATCQWHSFLXI67UIJYTI5YTDWXHFQPANCNFSM6AAAAAAUZIWN7I
.
You are receiving this because you were assigned.Message ID:
@.***>

Please review done the mentioned changes
…
On Mon, 13 Feb 2023, 11:37 Sri Harika, @.> wrote: Ok mam On Mon, 13 Feb 2023, 11:37 Shreya Sarkar, @.> wrote: > @.**** requested changes on this pull request. > > remove .exe files > > — > Reply to this email directly, view it on GitHub > <#558 (review)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/ATCQWHSFLXI67UIJYTI5YTDWXHFQPANCNFSM6AAAAAAUZIWN7I > . > You are receiving this because you were assigned.Message ID: > @.***> >

@Harikaraja Resolve your CodeFactor issues

How to do it sir can you please tell
On Wed, 15 Feb 2023, 06:56 Kumar Laxmikant, @.***>
wrote:

Please review done the mentioned changes
… <#m_-6643782156622676203_>
On Mon, 13 Feb 2023, 11:37 Sri Harika, @.> wrote: Ok mam On Mon, 13
Feb 2023, 11:37 Shreya Sarkar, @.> wrote: > @.**** requested changes
on this pull request. > > remove .exe files > > — > Reply to this email
directly, view it on GitHub > <#558 (review)
https://github.com/Kumar-laxmi/Algorithms/pull/558#pullrequestreview-1294991106>,

or unsubscribe >
https://github.com/notifications/unsubscribe-auth/ATCQWHSFLXI67UIJYTI5YTDWXHFQPANCNFSM6AAAAAAUZIWN7I
. > You are receiving this because you were assigned.Message ID: > @.***>

@Harikaraja https://github.com/Harikaraja Resolve your CodeFactor
issues
—
Reply to this email directly, view it on GitHub
https://github.com/Kumar-laxmi/Algorithms/pull/558#issuecomment-1430619562,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATCQWHU7GBS7UXMZHXY5TVLWXQWEBANCNFSM6AAAAAAUZIWN7I
.
You are receiving this because you were mentioned.Message ID:
@.***>

How to do it sir can you please tell On Wed, 15 Feb 2023, 06:56 Kumar Laxmikant, @.> wrote:
…
Please review done the mentioned changes … <#m_-6643782156622676203_> On Mon, 13 Feb 2023, 11:37 Sri Harika, @.> wrote: Ok mam On Mon, 13 Feb 2023, 11:37 Shreya Sarkar, @.> wrote: > @.*** requested changes on this pull request. > > remove .exe files > > — > Reply to this email directly, view it on GitHub > <#558 (review) <#558 (review)>>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/ATCQWHSFLXI67UIJYTI5YTDWXHFQPANCNFSM6AAAAAAUZIWN7I > . > You are receiving this because you were assigned.Message ID: > @.> > @Harikaraja https://github.com/Harikaraja Resolve your CodeFactor issues — Reply to this email directly, view it on GitHub <#558 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATCQWHU7GBS7UXMZHXY5TVLWXQWEBANCNFSM6AAAAAAUZIWN7I . You are receiving this because you were mentioned.Message ID: @.>

Click on the Details near CodeFactor

Sir should i resolve and again push my code to the same PR
On Wed, 15 Feb 2023, 07:00 Kumar Laxmikant, @.***>
wrote:

How to do it sir can you please tell On Wed, 15 Feb 2023, 06:56 Kumar
Laxmikant, @.
> wrote: … <#m_-7913388852483094858_> Please review done the mentioned
changes … <#m_-6643782156622676203_> On Mon, 13 Feb 2023, 11:37 Sri Harika,
@.> wrote: Ok mam On Mon, 13 Feb 2023, 11:37 Shreya Sarkar, @.> wrote: > @.***
requested changes on this pull request. > > remove .exe files > > — > Reply
to this email directly, view it on GitHub > <#558
https://github.com/Kumar-laxmi/Algorithms/pull/558 (review) <#558
(review)
https://github.com/Kumar-laxmi/Algorithms/pull/558#pullrequestreview-1294991106>>,

or unsubscribe >
https://github.com/notifications/unsubscribe-auth/ATCQWHSFLXI67UIJYTI5YTDWXHFQPANCNFSM6AAAAAAUZIWN7I
. > You are receiving this because you were assigned.Message ID: > @.>
@Harikaraja https://github.com/Harikaraja https://github.com/Harikaraja
https://github.com/Harikaraja Resolve your CodeFactor issues — Reply to
this email directly, view it on GitHub <#558 (comment)
https://github.com/Kumar-laxmi/Algorithms/pull/558#issuecomment-1430619562>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATCQWHU7GBS7UXMZHXY5TVLWXQWEBANCNFSM6AAAAAAUZIWN7I
https://github.com/notifications/unsubscribe-auth/ATCQWHU7GBS7UXMZHXY5TVLWXQWEBANCNFSM6AAAAAAUZIWN7I
. You are receiving this because you were mentioned.Message ID: @.>

Click on the Details
https://www.codefactor.io/repository/github/kumar-laxmi/algorithms/pull/558
near CodeFactor
—
Reply to this email directly, view it on GitHub
https://github.com/Kumar-laxmi/Algorithms/pull/558#issuecomment-1430622173,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATCQWHRP7BTQSECWUPA36ZTWXQWTLANCNFSM6AAAAAAUZIWN7I
.
You are receiving this because you were mentioned.Message ID:
@.***>

Sir should i resolve and again push my code to the same PR On Wed, 15 Feb 2023, 07:00 Kumar Laxmikant, @.> wrote:
…
How to do it sir can you please tell On Wed, 15 Feb 2023, 06:56 Kumar Laxmikant, @. > wrote: … <#m_-7913388852483094858_> Please review done the mentioned changes … <#m_-6643782156622676203_> On Mon, 13 Feb 2023, 11:37 Sri Harika, @.> wrote: Ok mam On Mon, 13 Feb 2023, 11:37 Shreya Sarkar, @.> wrote: > @. requested changes on this pull request. > > remove .exe files > > — > Reply to this email directly, view it on GitHub > <#558 <#558> (review) <#558 (review) <#558 (review)>>>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/ATCQWHSFLXI67UIJYTI5YTDWXHFQPANCNFSM6AAAAAAUZIWN7I > . > You are receiving this because you were assigned.Message ID: > @.> > @Harikaraja https://github.com/Harikaraja https://github.com/Harikaraja https://github.com/Harikaraja Resolve your CodeFactor issues — Reply to this email directly, view it on GitHub <#558 (comment) <#558 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATCQWHU7GBS7UXMZHXY5TVLWXQWEBANCNFSM6AAAAAAUZIWN7I https://github.com/notifications/unsubscribe-auth/ATCQWHU7GBS7UXMZHXY5TVLWXQWEBANCNFSM6AAAAAAUZIWN7I . You are receiving this because you were mentioned.Message ID: @.> Click on the Details https://www.codefactor.io/repository/github/kumar-laxmi/algorithms/pull/558 near CodeFactor — Reply to this email directly, view it on GitHub <#558 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATCQWHRP7BTQSECWUPA36ZTWXQWTLANCNFSM6AAAAAAUZIWN7I . You are receiving this because you were mentioned.Message ID: @.***>

Yes!

@Harikaraja Please resolve the CodeFactor issue

Good afternoon sir ,
Sir I have done my code in c language how can I reduce the time complexity
of my code.
On Sun, 19 Feb 2023, 12:51 Kumar Laxmikant, @.***>
wrote:

@Harikaraja https://github.com/Harikaraja Please resolve the
CodeFactor issue
—
Reply to this email directly, view it on GitHub
https://github.com/Kumar-laxmi/Algorithms/pull/558#issuecomment-1435913501,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATCQWHSZYQMIBP4FEGUM6UTWYHCWVANCNFSM6AAAAAAUZIWN7I
.
You are receiving this because you were mentioned.Message ID:
@.***>

@Harikaraja Kindly make necessary changes withing a week or else this PR will be closed


Release date of new version with firewall?

Just discovered this library and I must say this is just excellent. The way it is organized is just intuitive and doesn't require you to look up documentation. I wish AWS SDK was this easy but I guess they just have too many calls to cover. Sorry I digress.
Anyway, i was wondering when the new version with Firewall will be released? I'm currently using the dev branch in my project, but would rather switch to a stable release soon.
Thanks again for the excellent work!

Thanks for your feedback! Normally sometime next week a new release will be available...

Hmmm, I now notice I never updated this issue, the 1.1.0 release was added on Tue Mar 14 09:17:47 2017 +0100


Revert removal of homepage no-cache rules

Revert "Revert no-cache rule for front-end homepage"
This reverts commit 9213f54c855b753931239a3f0fa87b237bb65db8.
We're running the Javascript detection experiment again. This reinstates
no caching rules for the tracking images.
Merge required prior to https://github.com/alphagov/frontend/pull/1115.

@alexmuller does this look ok to you? The code I'm reverting is a bit old - will this change have the intended effect of ensuring the tracking images aren't cached?

What's the reason for disabling this in development? Can we remove all of that logic?

I'm probably not understanding this, but what the reason for not caching this? All calls to the cache will be reported in Fastly anyway.

@tijmenb I believe this refers to the expires header set on responses to requests for the images - if you're still within the expiry time the browser won't request the image at all.

@alexmuller regarding the dev-specific config - not sure. I would assume it could be removed without issue.
Original commit message https://github.com/alphagov/govuk-puppet/commit/e10bc998cc9229308c321f00 doesn't clear things up much. I also have no idea what govuk_platform is.

Closing for now, see: https://trello.com/c/ee87DdP0/350-determine-how-many-people-have-don-t-have-javascript#comment-58a2dfb0b53567cacc648184


Cmp not showing up

🐛 Describe the bug
As per the issue title, I'm not getting cmp to work. It simply does not show up when for example typing [[ or #.
I have also tried to manually add cmp source in my cmp.lua config file, but it still doesn't work.
CmpStatus and ObsidianDebug seem fine to me (at least I do not see any warning).

Config
-- Obsidian: https://github.com/epwalsh/obsidian.nvim
-- Integration with Obsidian note taking app.
{
    "epwalsh/obsidian.nvim",
    version = "*",
    lazy = true,
    ft = "markdown",
    dependencies = {
	"nvim-lua/plenary.nvim",
	"hrsh7th/nvim-cmp",
	"nvim-telescope/telescope.nvim",
    },
    config = function()
	require("configs.obsidian")
    end,
},

local present, obsidian = pcall(require, "obsidian")

if not present then
	return
end

obsidian.setup({
	workspaces = {
		{
			name = "Obsidian",
			path = "~/Notes/Obsidian",
		},
		-- {
		-- 	name = "Work",
		-- 	path = "~/Notes/Obsidian/Work",
		-- 	-- Optional, override certain settings.
		-- 	overrides = {
		-- 		-- notes_subdir = "notes",
		-- 	},
		-- },
	},
	-- Optional, completion of wiki links, local markdown links, and tags using nvim-cmp.
	completion = {
		-- Set to false to disable completion.
		nvim_cmp = true,
		-- Trigger completion at 2 chars.
		min_chars = 1,
	},
	mappings = {
		-- Overrides the 'gf' mapping to work on markdown/wiki links within your vault.
		["<leader>ol"] = {
			action = function()
				return require("obsidian").util.gf_passthrough()
			end,
			opts = { noremap = false, expr = true, buffer = true },
		},
		-- Toggle check-boxes.
		["<leader>oc"] = {
			action = function()
				return require("obsidian").util.toggle_checkbox()
			end,
			opts = { buffer = true },
		},
	},
	-- Where to put new notes. Valid options are
	--  * "current_dir" - put new notes in same directory as the current buffer.
	--  * "notes_subdir" - put new notes in the default notes subdirectory.
	new_notes_location = "current_dir",
	-- Optional, customize how note IDs are generated given an optional title.
	---@param title string|?
	---@return string
	note_id_func = function(title)
		-- Create note IDs in a Zettelkasten format with a timestamp and a suffix.
		-- In this case a note with the title 'My new note' will be given an ID that looks
		-- like '1657296016-my-new-note', and therefore the file name '1657296016-my-new-note.md'
		local suffix = ""
		if title ~= nil then
			-- If title is given, transform it into valid file name.
			suffix = title:gsub(" ", "-"):gsub("[^A-Za-z0-9-]", ""):lower()
		else
			-- If title is nil, just add 4 random uppercase letters to the suffix.
			for _ = 1, 4 do
				suffix = suffix .. string.char(math.random(65, 90))
			end
		end
		return tostring(os.time()) .. "-" .. suffix
	end,

	-- Optional, customize how note file names are generated given the ID, target directory, and title.
	---@param spec { id: string, dir: obsidian.Path, title: string|? }
	---@return string|obsidian.Path The full path to the new note.
	note_path_func = function(spec)
		-- This is equivalent to the default behavior.
		local path = spec.dir / tostring(spec.id)
		return path:with_suffix(".md")
	end,

	-- Optional, customize how wiki links are formatted. You can set this to one of:
	--  * "use_alias_only", e.g. '[[Foo Bar]]'
	--  * "prepend_note_id", e.g. '[[foo-bar|Foo Bar]]'
	--  * "prepend_note_path", e.g. '[[foo-bar.md|Foo Bar]]'
	--  * "use_path_only", e.g. '[[foo-bar.md]]'
	-- Or you can set it to a function that takes a table of options and returns a string, like this:
	wiki_link_func = function(opts)
		return require("obsidian.util").wiki_link_id_prefix(opts)
	end,

	-- Optional, customize how markdown links are formatted.
	markdown_link_func = function(opts)
		return require("obsidian.util").markdown_link(opts)
	end,

	-- Either 'wiki' or 'markdown'.
	preferred_link_style = "wiki",

	-- Optional, customize the default name or prefix when pasting images via `:ObsidianPasteImg`.
	---@return string
	image_name_func = function()
		-- Prefix image names with timestamp.
		return string.format("%s-", os.time())
	end,

	-- Optional, boolean or a function that takes a filename and returns a boolean.
	-- `true` indicates that you don't want obsidian.nvim to manage frontmatter.
	disable_frontmatter = false,

	-- Optional, alternatively you can customize the frontmatter data.
	---@return table
	note_frontmatter_func = function(note)
		-- Add the title of the note as an alias.
		if note.title then
			note:add_alias(note.title)
		end

		local out = { id = note.id, aliases = note.aliases, tags = note.tags }

		-- `note.metadata` contains any manually added fields in the frontmatter.
		-- So here we just make sure those fields are kept in the frontmatter.
		if note.metadata ~= nil and not vim.tbl_isempty(note.metadata) then
			for k, v in pairs(note.metadata) do
				out[k] = v
			end
		end

		return out
	end,

	-- Optional, for templates (see below).
	templates = {
		subdir = "templates",
		date_format = "%Y-%m-%d",
		time_format = "%H:%M",
		-- A map for custom variables, the key should be the variable and the value a function
		substitutions = {},
	},

	-- Optional, by default when you use `:ObsidianFollowLink` on a link to an external
	-- URL it will be ignored but you can customize this behavior here.
	---@param url string
	follow_url_func = function(url)
		-- Open the URL in the default web browser.
		-- vim.fn.jobstart { "open", url } -- Mac OS
		vim.fn.jobstart({ "xdg-open", url }) -- linux
	end,

	-- Optional, set to true if you use the Obsidian Advanced URI plugin.
	-- https://github.com/Vinzent03/obsidian-advanced-uri
	use_advanced_uri = false,

	-- Optional, set to true to force ':ObsidianOpen' to bring the app to the foreground.
	open_app_foreground = false,

	picker = {
		-- Set your preferred picker. Can be one of 'telescope.nvim', 'fzf-lua', or 'mini.pick'.
		name = "telescope.nvim",
		-- Optional, configure key mappings for the picker. These are the defaults.
		-- Not all pickers support all mappings.
		mappings = {
			-- Create a new note from your query.
			new = "<C-x>",
			-- Insert a link to the selected note.
			insert_link = "<C-l>",
		},
	},

	-- Optional, sort search results by "path", "modified", "accessed", or "created".
	-- The recommend value is "modified" and `true` for `sort_reversed`, which means, for example,
	-- that `:ObsidianQuickSwitch` will show the notes sorted by latest modified time
	sort_by = "modified",
	sort_reversed = true,

	-- Optional, determines how certain commands open notes. The valid options are:
	-- 1. "current" (the default) - to always open in the current window
	-- 2. "vsplit" - to open in a vertical split if there's not already a vertical split
	-- 3. "hsplit" - to open in a horizontal split if there's not already a horizontal split
	open_notes_in = "current",

	-- Optional, define your own callbacks to further customize behavior.
	callbacks = {
		-- Runs at the end of `require("obsidian").setup()`.
		---@param client obsidian.Client
		post_setup = function(client) end,

		-- Runs anytime you enter the buffer for a note.
		---@param client obsidian.Client
		---@param note obsidian.Note
		enter_note = function(client, note) end,

		-- Runs right before writing the buffer for a note.
		---@param client obsidian.Client
		---@param note obsidian.Note
		pre_write_note = function(client, note) end,

		-- Runs anytime the workspace is set/changed.
		---@param client obsidian.Client
		---@param workspace obsidian.Workspace
		post_set_workspace = function(client, workspace) end,
	},

	-- Optional, configure additional syntax highlighting / extmarks.
	-- This requires you have `conceallevel` set to 1 or 2. See `:help conceallevel` for more details.
	ui = {
		enable = true, -- set to false to disable all additional syntax features
		update_debounce = 200, -- update delay after a text change (in milliseconds)
		-- Define how various check-boxes are displayed
		checkboxes = {
			-- NOTE: the 'char' value has to be a single character, and the highlight groups are defined below.
			[" "] = { char = "󰄱", hl_group = "ObsidianTodo" },
			["x"] = { char = "", hl_group = "ObsidianDone" },
			[">"] = { char = "", hl_group = "ObsidianRightArrow" },
			["~"] = { char = "󰰱", hl_group = "ObsidianTilde" },
			-- Replace the above with this if you don't have a patched font:
			-- [" "] = { char = "☐", hl_group = "ObsidianTodo" },
			-- ["x"] = { char = "✔", hl_group = "ObsidianDone" },

			-- You can also add more custom ones...
		},
		-- Use bullet marks for non-checkbox lists.
		bullets = { char = "•", hl_group = "ObsidianBullet" },
		external_link_icon = { char = "", hl_group = "ObsidianExtLinkIcon" },
		-- Replace the above with this if you don't have a patched font:
		-- external_link_icon = { char = "", hl_group = "ObsidianExtLinkIcon" },
		reference_text = { hl_group = "ObsidianRefText" },
		highlight_text = { hl_group = "ObsidianHighlightText" },
		tags = { hl_group = "ObsidianTag" },
		hl_groups = {
			-- The options are passed directly to `vim.api.nvim_set_hl()`. See `:help nvim_set_hl`.
			ObsidianTodo = { bold = true, fg = "#f78c6c" },
			ObsidianDone = { bold = true, fg = "#89ddff" },
			ObsidianRightArrow = { bold = true, fg = "#f78c6c" },
			ObsidianTilde = { bold = true, fg = "#ff5370" },
			ObsidianBullet = { bold = true, fg = "#89ddff" },
			ObsidianRefText = { underline = true, fg = "#c792ea" },
			ObsidianExtLinkIcon = { fg = "#c792ea" },
			ObsidianTag = { italic = true, fg = "#89ddff" },
			ObsidianHighlightText = { bg = "#75662e" },
		},
	},

	-- Specify how to handle attachments.
	attachments = {
		-- The default folder to place images in via `:ObsidianPasteImg`.
		-- If this is a relative path it will be interpreted as relative to the vault root.
		-- You can always override this per image by passing a full path to the command instead of just a filename.
		img_folder = "assets/imgs", -- This is the default
		-- A function that determines the text to insert in the note when pasting an image.
		-- It takes two arguments, the `obsidian.Client` and an `obsidian.Path` to the image file.
		-- This is the default implementation.
		---@param client obsidian.Client
		---@param path obsidian.Path the absolute path to the image file
		---@return string
		img_text_func = function(client, path)
			path = client:vault_relative_path(path) or path
			return string.format("![%s](%s)", path.name, path)
		end,
	},
})

Environment
NVIM v0.9.5
Build type: Release
LuaJIT 2.1.1702233742

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info

No breakpoints found.
Obsidian.nvim v3.7.4 (68da7299505a74dcd0f45292c202197840
615425)
Status:
   buffer directory: nil
   working directory: /home/marco/Notes/Obsidian
Workspaces:
  ✓ active workspace: Workspace(name='Obsidian', path='/
home/marco/Notes/Obsidian', root='/home/marco/Notes/Obsi
dian')
Dependencies:
   plenary.nvim: f7adfc4b3f4f91aab6caebf42b3682945fbc35
be
   nvim-cmp: 04e0ca376d6abdbfc8b52180f8ea236cbfddf782
   telescope.nvim: f06eeb79e14d5c95745558927c5b1f341c0a
3a28
Integrations:
   picker: TelescopePicker()
   completion: enabled (nvim-cmp)
Tools:
   rg: ripgrep 14.1.0
Environment:
   operating system: Linux
Config:
   notes_subdir: nil⏎

I use NvChad framework if this information is somehow relevant.

Hey @h0pes does cmp work with other cmp sources? Any error messages in the logs?

Hi, thanks for replying.
Yes, cmp works just fine with other multiple sources.
Regarding logs, which ones should you advise to inspect?

You should check :messages as well as :Noice (if you have noice.nvim) after trying to get a completion. If you don't see anything there, I recommend poking around in cmp_obsidian.lua. Try adding vim.print(items) on this line: https://github.com/epwalsh/obsidian.nvim/blob/dd1e7adf5fe110bf7763e8b9c06281f91778d19c/lua/cmp_obsidian.lua#L280
If see a big table being printed out there, then we know that obsidian.nvim's source is definitely being called, so then it's just a question of why cmp is not showing it. I would do this myself but I'm not able to reproduce the issue...

I am also facing this issue.
I can get other completions to show up, but nothing from Obsidian.
There are no error messages in the logs
I am using WSL with Ubuntu on Windows 10
This is my :ObsidianDebug output:

I added the vim.print(items) as described in the above reply but nothing was printed.
I added another print statement under https://github.com/epwalsh/obsidian.nvim/blob/1265a1fbfca5979f629ecedb2552f743c70f458f/lua/cmp_obsidian.lua#L19
That print statement ran
I also added another print statement under I added another print statement under https://github.com/epwalsh/obsidian.nvim/blob/1265a1fbfca5979f629ecedb2552f743c70f458f/lua/cmp_obsidian.lua#L56
and that did not run at all so that function is not getting called.

I've got it working now and it has presumably been working the whole time.
User error on my part. I had expected the functionality to behave as if
completion = {
    min_chars = 0,
}

was set. I had never actually tried starting to type a file name after the initial [

Same issue. Confirmed by uninstalling obsidian.nvim which brought back cmp. A reinstall removes all cmp again.
Output of :ObsidianDebug
Obsidian.nvim v3.9.0 (unknown commit)
Status:
  • buffer directory: /home/tai/Brain
  • working directory: /home/tai/Brain
Workspaces:
  ✓ active workspace: Workspace(name='brain', path='/home/tai/Brain', root='/home/tai/Brain')
Dependencies:
  ✓ plenary.nvim: unknown
  ✓ nvim-cmp: unknown
  ✓ telescope.nvim: unknown
Integrations:
  ✓ picker: TelescopePicker()
  ✓ completion: enabled (nvim-cmp) ✓ refs, ✓ tags, ✓ new
    all sources:
      • obsidian
      • obsidian_new
      • obsidian_tags
Tools:
  ✓ rg: ripgrep 14.1.0
Environment:
  • operating system: Linux
Config:
  • notes_subdir: nil

And here is the output of :lua vim.print(require("cmp").get_config().sources) when in my vault:
{ {
    name = "obsidian",
    option = {}
  }, {
    name = "obsidian_new",
    option = {}
  }, {
    name = "obsidian_tags",
    option = {}
  } }