feat(execution): add next_task method to the scheduler

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.79%. Comparing base (d53d212) to head (1e3f7a2).

Additional details and impacted files
@@                                    Coverage Diff                                    @@
##           avi/concurrency/add-execution-and-validation-counters    #1700      +/-   ##
=========================================================================================
- Coverage                                                  74.57%   73.79%   -0.78%
=========================================================================================
  Files                                                         59       59
  Lines                                                       8913     8595     -318
  Branches                                                    8913     8595     -318
=========================================================================================
- Hits                                                        6647     6343     -304
+ Misses                                                      1862     1834      -28
- Partials                                                     404      418      +14

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

crates/blockifier/src/concurrency/scheduler.rs line 23 at r2 (raw file):

    pub chunk_size: u32,
    // A marker indicating that all transactions have been executed and validated.
    pub done_marker: AtomicBool,

IMO the name of the field doesn't need any other explanation, the interesting point that should be explained here is why we have both check_done and this field.
Suggestion:
    // Updated by the `check_done` procedure, providing a cheap way for all threads to exit their main loops.
    pub done_marker: AtomicBool,

crates/blockifier/src/concurrency/scheduler.rs line 34 at r2 (raw file):

    pub fn done(&self) -> bool {
        self.done_marker.load(Ordering::Acquire)
    }

In the main loop in the thread logic, if we can access the variable without the function, I think it's cleaner.
Something like while !scheduler.done {} instead of while !scheduler.done() {}.
This way, we avoid this "redundant" code which is very similar to property in Python, just that I can't see why to use it.
Maybe the atomicity mechanism will not allow doing what I suggested (and then it's a good reason to do that).
Code quote:
    // Returns the done marker.
    pub fn done(&self) -> bool {
        self.done_marker.load(Ordering::Acquire)
    }

crates/blockifier/src/concurrency/scheduler.rs line 34 at r2 (raw file):
Previously, avi-starkware wrote…
I don't think it is good practice to touch the atomic variables of the scheduler from outside the scheduler.
The orderings are confusing enough when they are all in the same file.
Plus, it is an implementation detail that shouldn't matter to the worker running the code.

You're right (: resolved.

crates/blockifier/src/concurrency/scheduler.rs line 44 at r2 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Why do we need it in addition to the thread loop?
When will we have more than one iteration?

It is mainly for the case where next_version_to_validate / next_version_to_execute return None.
This might be due to many threads increasing the counters simultaneously, such that the counter exceeds chunk_size by the time the current thread finishes next_version_to_validate / next_version_to_execute.
The more common reason I think would be because the tx_status is not right yet.
This loop ensures that the method next_task always returns a task. NoTask is returned only when all relevant tasks to be done are executing in other threads, and Done is returned only when the entire chunk is ready to be committed.
It is an optimization from the aptos repo. I now see that in the case where NoTask is returned, the thread loop simply calls next_task again. I guess they just wanted to skip some of the overhead of restarting the thread loop.

crates/blockifier/src/concurrency/scheduler.rs line 55 at r4 (raw file):
Previously, noaov1 (Noa Oved) wrote…
We catch it in the next_version_to_validate/execute methods, no?
Why is it needed here as well? For an early return?

We load these two atomic variables anyway to compare their values, so this check has minimal overhead and saves us going into next_version_to_... when it is clearly not needed.

crates/blockifier/src/concurrency/scheduler.rs line 62 at r2 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Interesting. Let's think.
Assume idx_to_validate < idx_to_execute and no task is ready to be validated. When it can happen?
We finish validation of tx_i and tx_i+1 have not finish execution yet. Do we want to execute tx_j for j necessarily larger from i+1? Or wait for tx_i+1 to be ready?

I think we shouldn't wait, actually. Think of the first few thread loops. We'd want all the threads to start executing immediately and not have some threads stuck waiting for a validation task to be available when transactions are still being executed. (Barak's suggestion to have validation_index start at chunk_size slightly mitigates this case, but once the first execution completes, the validation_index will be decreased, and we will have threads waiting for validation tasks to be available anyway.)


/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
2706a2e9a4cac70c3ca874bfa4263e28a64f013b
link
/test analyze-tests_istio

integ-ipv6-k8s-tests_istio
c3549f543bd9ff45992e3871450d5b6fd0dbb954
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
c3549f543bd9ff45992e3871450d5b6fd0dbb954
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c3549f543bd9ff45992e3871450d5b6fd0dbb954
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c3549f543bd9ff45992e3871450d5b6fd0dbb954
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
2706a2e9a4cac70c3ca874bfa4263e28a64f013b
link
/test analyze-tests_istio

integ-ipv6-k8s-tests_istio
c3549f543bd9ff45992e3871450d5b6fd0dbb954
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
c3549f543bd9ff45992e3871450d5b6fd0dbb954
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c3549f543bd9ff45992e3871450d5b6fd0dbb954
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
2706a2e9a4cac70c3ca874bfa4263e28a64f013b
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
c3549f543bd9ff45992e3871450d5b6fd0dbb954
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c3549f543bd9ff45992e3871450d5b6fd0dbb954
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
2706a2e9a4cac70c3ca874bfa4263e28a64f013b
link
/test analyze-tests_istio

integ-multicluster-k8s-tests_istio
c3549f543bd9ff45992e3871450d5b6fd0dbb954
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
2706a2e9a4cac70c3ca874bfa4263e28a64f013b
link
/test analyze-tests_istio

integ-distroless-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
2706a2e9a4cac70c3ca874bfa4263e28a64f013b
link
/test analyze-tests_istio

integ-galley-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
2706a2e9a4cac70c3ca874bfa4263e28a64f013b
link
/test analyze-tests_istio

integ-galley-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
2706a2e9a4cac70c3ca874bfa4263e28a64f013b
link
/test analyze-tests_istio

integ-galley-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
2706a2e9a4cac70c3ca874bfa4263e28a64f013b
link
/test analyze-tests_istio

integ-galley-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
2706a2e9a4cac70c3ca874bfa4263e28a64f013b
link
/test analyze-tests_istio

integ-telemetry-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
2706a2e9a4cac70c3ca874bfa4263e28a64f013b
link
/test analyze-tests_istio

integ-telemetry-k8s-tests_istio
9e068760ea268c2b28509cec11620411f2fa4c61
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
2706a2e9a4cac70c3ca874bfa4263e28a64f013b
link
/test analyze-tests_istio

integ-distroless-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
bd02b0a55f1d0da4446cf1e0a0bc57bc2d24e17b
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn @esnible I have also updated the warning message. Let me know if this sounds ok ?
$ $GOPATH/src/istio.io/istio/out/linux_amd64/istioctl install
! istioctl version 1.8.0 and the control plane version 1.6.5 are different.
! Proceed with caution because after installation the cluster may misbehave.

This will install Istio 1.8.0 into the cluster. Proceed? (y/N)

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
2706a2e9a4cac70c3ca874bfa4263e28a64f013b
link
/test analyze-tests_istio

integ-distroless-k8s-tests_istio
855d26638972d0cf75a9f313a459c9d980e155a8
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-distroless-k8s-tests_istio

@shamsher31 Can you get your final approver on this?

@shamsher31 Can you get your final approver on this?

@esnible Yes, waiting for @howardjohn feedback.

We still have no solved the issue that we are comparing two "versions" which are not derived from the same source

As far as I understood, I think we need to compare the Istio Control Plan installed in a running cluster with the latest istioctl installed on the user machine.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
2706a2e9a4cac70c3ca874bfa4263e28a64f013b
link
/test analyze-tests_istio

integ-security-k8s-tests_istio
e2754418bfbc9dbe5dc696415eb4e41a259c6817
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-tests_istio

@shamsher31: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shamsher31: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shamsher31 our policy bot has a mind of its own. Would you care to continue work on this PR?

@howardjohn - there are many new pushes since your blocking review. I have not reviewed this PR - is there still a blocking problem?
Cheers,
-steve

@ericvn approximately 30 days seems a little aggressive for closure of a PR that has had a bunch of pushes without further followup review. Do you know how to improve the bot to add improved logic?
Cheers,
-steve

cc @istio/wg-test-and-release-maintainers

@sdake I'd have to go back and find the design doc (I believe this was done by Martin as part of Code Mauve), but I believe 30 days to make stale and 15 days to close was the approved values.

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
7dec936a409a5e5136e59ac2775e697caaefd8cc
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn I spent a lot of time rebasing this (almost 400 commits since this PR) and finally decided to delete and re-create the local branch with handpicked changes.

/test integ-ipv6-k8s-tests_istio

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c5f5dffa93175a06458410f85a0e4b86fb7080c8
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-pilot-k8s-tests_istio

lint_istio
fb66eecf265ee19cc80cad589801dede84a93eca
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible Hope this is what you suggested.
When there is a multiple control plane already installed.
$ kubectl get pods -n istio-system
NAME                                    READY   STATUS    RESTARTS   AGE
istio-ingressgateway-6994d999bb-72wxs   1/1     Running   0          16s
istiod-1-6-8-69cd9dd85d-jpnsf           1/1     Running   0          54s
istiod-1-7-2-545654f869-vsvxc           1/1     Running   0          20s
prometheus-7dd7f7c65-kxbjg              2/2     Running   0          48s

When there are multiple control planes, and does not supply --set revision=, the message might better read "Istio control planes installed: X,Y. Use --set revision= or --force to install Istio.

When a revision is not passed
$ ./out/linux_amd64/istioctl install --set hub=gcr.io/istio-testing -d manifests/
! Istio control planes installed: 1.6.8, 1.7.2.
! Use --revision=1.8.0 or --force to install Istio.
This will install the Istio 1.8.0 profile into the cluster. Proceed? (y/N)

When upgrading this message looks too strong. Perhaps something like "Istio is being upgraded from X -> Y. Before upgrading, you may wish to 'istioctl analyze' to check for IST0002 deprecation warnings"

When a revision is passed.
$ ./out/linux_amd64/istioctl install --revision=1-8-0 --set hub=gcr.io/istio-testing -d manifests/
! Istio is being upgraded from 1.7.2 -> 1.8.0.
! Before upgrading, you may wish to 'istioctl analyze' to check for IST0002 deprecation warnings.
This will install the Istio 1.8.0 profile into the cluster. Proceed? (y/N)

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-pilot-k8s-tests_istio

lint_istio
fb66eecf265ee19cc80cad589801dede84a93eca
link
/test lint_istio

integ-distroless-k8s-tests_istio
fb66eecf265ee19cc80cad589801dede84a93eca
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
fb66eecf265ee19cc80cad589801dede84a93eca
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
fb66eecf265ee19cc80cad589801dede84a93eca
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
fb66eecf265ee19cc80cad589801dede84a93eca
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
fb66eecf265ee19cc80cad589801dede84a93eca
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
37b0b06453835ddc022da62828694bfd3090ec6a
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible @howardjohn any idea why tests are failing?

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
805151719e46146e009c1d5b7524c91b84164ca3
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart I think I found why tests is failing. It is because of --set values.global.tag=istio-testing-distroless in the integration test.
Running istio control plane on cluster cluster-0 [install --skip-confirmation -f /home/prow/go/src/istio.io/istio/tests/integration/iop-integration-test-defaults.yaml -f /logs/artifacts/security-d34ed5d85ba94bcaa6717a/_suite_context/istio-deployment-455539552/iop.yaml
--set values.global.imagePullPolicy=IfNotPresent
--manifests /home/prow/go/src/istio.io/istio/manifests
--set values.global.imagePullPolicy=IfNotPresent
--set values.global.hub=localhost:5000
--set values.global.tag=istio-testing-distroless]

If I pass tag=istio-testing-distroless it throws error.
$ ./out/linux_amd64/istioctl install --set hub=gcr.io/istio-testing --set tag=istio-testing-distroless -d manifests/
Error: Malformed version: istio-testing-distroless

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
ca76f48c261651cf8ebe217a797e3c18258eb9ac
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shamsher31: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
48b63319bcbc1d0f19817e891c69ca426d5f6db8
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
58f2281174496cbad0453a3c2563ecfb55122e47
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@ostromart PTAL.


It looks three bmfont-text is not support chinese/japanese text

how can i make it display other languages?

This only supports simple text layout, ie Latin languages with left-to-right text.
Something like Chinese or Arabic is unfortunately much more challenging, and outside of the scope of this module.
Instead you would have better luck rendering to a canvas element and turning it into WebGL textures.
Cheers! 😁


chart/node-exporter: restore disabled collectors

Metrics exported by these collectors are used in alerting, so disabling collectors affected read load to be lower than expected.

 But as I remember, it somehow affected our sandbox benchmark.
We can merge and see how it will affect the benchmark, and maybe create a custom config on sandbox.


Implement didClose notification in LSP

Implements the didClose notification to satisfy clients that require it or complain when it is not implemented. Fixes #50272 .

Thanks!

Cherry-picked for 3.4.

Cherry-picked for 3.3.3.


Scrolling is often laggy

On iOS, when in the message view (narrowed to a stream), if I scroll around a bit, the app often doesn't respond to some of my swipes. That is: I touch and swipe to scroll, it starts moving normally; then I touch again and try to swipe either to scroll further or to stop scrolling; and nothing happens, just as if I hadn't touched the screen at all.
This behavior is very unusual in my experience as an iPhone user (might happen very occasionally, but basically no app I've used routinely suffers it), and it sticks out. I imagine what's happening is something like the relevant thread being busy and not responding to the scroll event, but I don't know enough about how the app actually works for that to be more than speculation.

(I'm on 1.0.15 (1), the build recently uploaded to TestFlight.)

Your speculation is likely on point. Me and @Sam1301 will improve this further.
Message rendering is for sure part of the problem and possibly the only problem. We need to make sure we confirm where the CPU cycles go (just a note to Saumya, it is often the case we are over confident we know what the reason for some slow down is, and when we fix the cause, the problem does not go away, so we just need to make sure our hunch is right).
We might be able to fix something, but if not, our replacement of the MessageList with a FlatList or WebView will be the solution.
The likely cause is: rendering of messages is a UI blocking operation, and we don't have much control over it.

Makes sense -- sounds like a good plan!

@gnprice wanna try the latest version? Should be smoother now.

Indeed -- much smoother! I just installed 1.0.29 from TestFlight and played around with it some. Very nice.
There is still an occasional hiccup, which I imagine has a different cause so maybe this issue should be closed and a new one opened. Specifically, it looks like when the app gets a new batch of old history, the UI freezes briefly (like 400ms). One symptom is that any scrolling stops (and doesn't resume after, until I swipe again); another is that if I'm at the top of the existing history, the "Z" spinner at the top freezes for that period until the newly downloaded old messages appear in its place.

I am closing this, as we made most (or all) of the perf optimizations related to scrolling.
We can open another issue if another optimization is needed.


Add Power/Ground plugs to Rails

Power and Ground will attach to dedicated plugs to the left (power) and right (ground) of each horizontal rail.
Only power and ground can connect to these plugs, they will not be selectable for wiring otherwise.

This also got fixed in the refactor (see #8 and related)


More hooks

Thank you for this crate and its tutorial book. I'm coming to rust from python where I have been using behave. I have made generous use of its various hooks (see in their documentation), especially hooks before or after certain tags, no matter if a Feature, Scenario, or Step is tagged with it.
Are there any plans to add hooks like that to cucumber-rs? If not, how do users currently satisfy their needs for fixtures which only should be set up or torn down before or after certain (but not all) steps or, scenarios? Is there more strategies other than smuggling them as extra steps into the feature files?

@Nagidal as far as I recall, original Cucumber has only Before/After hooks on Scenario level. We have them too. Also, World's init()/Drop may be used for that too.
Regarding behave's additional hooks:

before_step(context, step), after_step(context, step)
These run before and after every step.

We don't support them, as for now. It's a little bit hard to imagine how this can be useful, since touches every possible step, so definitely requires some sort of filtering inside, basing on the step definition, which does ... not much differ from invoking some functions inside desired step matchers? I see this only may be helpful for something like trying to measure each Step execution time, but, again, we could use timestamps feature for that.

before_feature(context, feature), after_feature(context, feature)
These run before and after each feature file is exercised.

This implies there is some shared state between Scenarios of a Feature. Maybe behave does this, but in cucumber-rs the order of executing Scenarios is not defined, and they're executed concurrently, thus having a shared state between multiple Scenarios may lead to fragile tests. Maybe this is the place where we differ with behave in execution only. Considering that Scenario is an execution unit in cucumber-rs (fresh World is initialized when Scenario starts and drops when Scenario ends), I don't see any cases where before_feature/after_feature may be more helpful than existing before_scenario/after_scenario.

before_all(context), after_all(context)
These run before and after the whole shooting match.

Similar here. This could be done in main before/after running Cucumber::run().

before_tag(context, tag), after_tag(context, tag)
These run before and after a section tagged with the given name. They are invoked for each tag encountered in the order they’re found in the feature file. See controlling things with tags.

This looks useful, but again, doesn't really comply with our execution model. Scenarios are not run in the order they're defined, so there are not actual sections defined by tags. Rather, Scenarios inherit tags from their Features, so we could run a hook before every Scenario having the specified tag, but not before a section, but how that than differs from inspecting Scenario tags in the usual before_scenario hook?

Are there any plans to add hooks like that to cucumber-rs?

There were no such plans. But with enough demand/motivation this could be implemented.

If not, how do users currently satisfy their needs for fixtures which only should be set up or torn down before or after certain (but not all) steps or, scenarios? Is there more strategies other than smuggling them as extra steps into the feature files?

Extra steps are an idiomatic way for that, IMHO, as make stuff explicit for specs reader. In case we really need "smuggling" something without the reader noticing it, we still do have before/after hooks for a scenario, where we can inspect its tags/definition and decide what to do or do nothing.
Something like:
World::cucumber()
    .before(|_feature, _rule, scenario, _world| {
        if scenario.tags.constains("sleepy") {
            time::sleep(Duration::from_millis(300)).boxed_local()
        }
    })
    .run_and_exit("tests/features/book");

Moreover I not aware of any cucumber format (cucumber-junit, cucumber-jsonschema etc), that can differentiate between different hooks. Even the most recent cucumber-messages format lacks it at the moment.

Ok, I think I can work with the limited hook possibilities for now. But thanks for the consideration


Jump Search in Array

I would love to add the Implementation of the Jump Search in Python. Kindly assign it to me

I would love to work on this issue as a part of Girl Script Summer Of Code. Kindly assign it to me.

I want to resolve this issue in python.Please assign this issue to me.

@tarun26091999, Under GSSOC21 I would like to work on this issue using C++. Please assign me this issue.

Hi,
I am a GSSOC'21 participant. I would like to solve this issue in Java. Please assign it to me.

Hi, I am a GSSOC'21 participant. I would like to solve this issue in C++. Please assign it to me @tarun26091999