Warning about explicit reference for console apps (8.0.200)

Hey! Since 8.0.200, I now get a warning when explicitly referencing Microsoft.NET.Build.Containers, similar how it changed for web applications. That's great if it's now fully included in the SDK.
However, if I remove the reference, when I publish a project, no container is published (but there are also no errors).
Project file (simply just dotnet new console):
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net8.0</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <Compile Include="Program.fs" />
  </ItemGroup>

</Project>

When publishing:
λ dotnet publish --os linux --arch x64 -c Release /t:PublishContainer
MSBuild version 17.9.4+90725d08d for .NET
  Determining projects to restore...
  Restored /.../Container/Container.fsproj (in 147 ms).
  Container -> /.../Container/bin/Release/net8.0/linux-x64/Container.dll
  Container -> /.../Container/bin/Release/net8.0/linux-x64/publish/

As you can see no container is published. If I readd the reference, things work as I expect:
λ dotnet add package Microsoft.NET.Build.Containers
dotnet publish --os linux --arch x64 -c Release /t:PublishContainer
  Determining projects to restore...
  Writing /var/folders/g5/tmdb3_294sb_zfk2nd474nsc0000gp/T/tmpYwCkLT.tmp
info : X.509 certificate chain validation will use the fallback certificate bundle at '/usr/local/share/dotnet/sdk/8.0.201/trustedroots/codesignctl.pem'.
info : X.509 certificate chain validation will use the fallback certificate bundle at '/usr/local/share/dotnet/sdk/8.0.201/trustedroots/timestampctl.pem'.
info : Adding PackageReference for package 'Microsoft.NET.Build.Containers' into project '/.../Container/Container.fsproj'.
info :   CACHE https://api.nuget.org/v3/registration5-gz-semver2/microsoft.net.build.containers/index.json
info : Restoring packages for /.../Container/Container.fsproj...
info :   CACHE https://api.nuget.org/v3/vulnerabilities/index.json
info :   CACHE https://api.nuget.org/v3-vulnerabilities/2<IP_ADDRESS>.28.27/vulnerability.base.json
info :   CACHE https://api.nuget.org/v3-vulnerabilities/2<IP_ADDRESS>.28.27/2<IP_ADDRESS>.28.32/vulnerability.update.json
info : Package 'Microsoft.NET.Build.Containers' is compatible with all the specified frameworks in project '/.../Container/Container.fsproj'.
info : PackageReference for package 'Microsoft.NET.Build.Containers' version '8.0.200' added to file '/.../Container/Container.fsproj'.
info : Generating MSBuild file /.../Container/obj/Container.fsproj.nuget.g.props.
info : Generating MSBuild file /.../Container/obj/Container.fsproj.nuget.g.targets.
info : Writing assets file to disk. Path: /.../Container/obj/project.assets.json
log  : Restored /.../Container/Container.fsproj (in 71 ms).
MSBuild version 17.9.4+90725d08d for .NET
  Determining projects to restore...
  Restored /.../Container/Container.fsproj (in 120 ms).
  Container -> /.../Container/bin/Release/net8.0/linux-x64/Container.dll
/usr/local/share/dotnet/sdk/8.0.201/Containers/build/Microsoft.NET.Build.Containers.targets(194,5): warning : Microsoft.NET.Build.Containers NuGet package is explicitly referenced. Consider removing the package reference to Microsoft.NET.Build.Containers as it is now part of .NET SDK. [/.../Container/Container.fsproj]
  Container -> /.../Container/bin/Release/net8.0/linux-x64/publish/
  Building image 'container' with tags 'latest' on top of base image 'mcr.microsoft.com/dotnet/runtime:8.0'.
  Pushed image 'container:latest' to local registry via 'docker'.

However, as you can see, I get the warning.
λ dotnet --version
8.0.201

This is also reflected on "real" projects in our CI, so not just locally for me.
What am I doing wrong? Or are my expectations wrong?

Hello! The tl;dr is that console apps will need to add a property to their project files:
<PropertyGroup>
...
  <EnableSdkContainerSupport>true</EnableSdkContainerSupport>
...
</PropertyGroup>

The slightly longer form is that the container publishing target needs to be available but not necessarily enabled for all project types in order to support calling dotnet publish /t:PublishContainer at a solution level and having all relevant projects containerize themselves.  Web Projects and Worker Projects have a hook to automatically set this property, but console apps don't (because otherwise all library/etc. projects would have the ability to containerize, which doesn't make sense). So there's a bit more of a 'process' to enabling console apps. We hope to find a good way to default this property to true for them in a later release.

Aha! Thanks a lot! Just to confirm, this fixes things.
Also wanted to add that we are super happy publishing containers this way, it has cleaned up both CI and local development a lot since .NET 7. This minor hiccup does not change that.


Video player component

Hey there, @surajondev. I’m new to contributing to open source projects and just found this lovely repo. I see there aren’t any video related UI components, such as custom media players and the like. Would you be open to me contributing a custom video player component I’ve created? It does leverage some JS— should all the components contributed here be HTML/CSS only? Thanks for the clarification. Hope I can be of assistance.

It's a nice idea. You can use JS too if it requires. I am assigning you to work on this.

Thanks so much @surajondev. I've attempted to commit my video player component to your main repository here: https://github.com/surajondev/UI-UX-Design/pull/119/commits/3801fb741f5a9ea174a0328a4cea3910d79c5c0b
Apologies if I did not correctly associate this assigned issue with my submitted merge request. Of course let me know if there are any modifications or clarification I can provide. Thanks again for the assistance and opportunity to learn here.


Fix user login cucumber integration test

generated users have a different naming scheme now
depends on api#57

Does that mean that that test isn't currently passing in master?


Unable to start appium server in the updated version

Description
Unable to start appium server programatically using C#
Environment

.NET client build version or git revision if you use some shapshot:
Appium server version or git revision if you use some shapshot: v1.0.2-beta.2
Desktop OS/version used to run Appium if necessary: Windows10
Node.js version (unless using Appium.app|exe) or Appium CLI or Appium.app|exe:
Mobile platform/version under test: 7.1.1
Real device or emulator/simulator: Real device

Details
Unable to start appium server programatically after update to the latest. Appium.js is missing in the latest version. I have used main.js.
Code To Reproduce Issue [ Good To Have ]
AppiumLocalService service = new AppiumServiceBuilder().WithIPAddress("<IP_ADDRESS>").WithLogFile(new FileInfo(@"c:\temp\log.txt")).UsingPort(4723).WithAppiumJS(new FileInfo(@"C:\Users\Myuser\AppData\Local\Programs\appium-desktop\resources\app\main.js")).UsingDriverExecutable(new FileInfo(@"C:\Program Files\nodejs\node.exe")).Build();
service.Start();
Ecxeption stacktraces
'OpenQA.Selenium.Appium.Service.Exceptions.AppiumServerHasNotBeenStartedLocallyException' occurred in appium-dotnet-driver.dll but was not handled in user code
The local appium server has not been started. The given Node.js executable: C:\Program Files\nodejs\node.exe Arguments: "C:\Users\Myuser\AppData\Local\Programs\appium-desktop\resources\app\main.js" --port 4723 --address <IP_ADDRESS> --log c:\temp\log.txt.
Time 120000 ms for the service starting has been expired!
Link to Appium logs
Please create a gist which is a paste of your full Appium logs, and link them here. Do not paste your full Appium logs here, as it will make this issue very long and hard to read!
If you are reporting a bug, always include Appium logs as linked gists! It helps to define the problem correctly and clearly.

I have the same issue, I used space character in LogFile (e.g. new FileInfo("D:\temp directory\log1.txt")), when I changed log file location to path without space character (e.g. "D:\temp\log1.txt") AppiumLocalService starts correctly.

i also have same issue. Any updates?

Linked #192


[FEA][JSON] Support Decimal type in to_json

Is your feature request related to a problem? Please describe.
We do not support Decimal types in to_json.
Describe the solution you'd like
Support Decimal type in to_json
Describe alternatives you've considered
Additional context

Fixed by https://github.com/NVIDIA/spark-rapids/pull/9873


prepend website url to the font name

Hello. Very convenient bash script that you wrote here. Thank you.
My project required self-hosting of fonts for multiple subdomains. I added the website parameter to prepend the url to the font name so it gets saved to font.css as url('https://example.com/fonts/FONT-NAME.woff2').
Just a simple convenience parameter. If you don't want to include it, that's okay and I'll delete the pull request. But if you do, great.

Interesting idea, but I'm wondering why you're not just putting the CSS on example.com as well, which would make this unnecessary?

Good point. Could be done that way. It's a larger federated project, so we used a subdomain to host common resources.
I thought of different use case that might have more value.... I concatenate all core .css files into a single file which is stored in a different folder than the fonts. Since the default is relative-pathing, the fonts would not be found. This is fixed by using an absolute url. In this case I would use website="/fonts/ to create /fonts/FONT-NAME.woff2. For reference, see W3, Section 6.4, which says: "Partial URLs are interpreted relative to the source of the style sheet, not relative to the document."

OK, I see that use case and am willing to accept this patch, but I'm not convinced --website is a good parameter name for this. Let's maybe use --base-path instead?
However, I don't like that the generated output CSS file would then not work in-place, i.e. if you were to generate a CSS file with this parameter and attempted to use it without modifications in a web page, it would not work. So I'm thinking maybe the better approach would be to support putting the fonts into a subfolder, i.e. making this parameter also affect the path where the fonts would be stored and call it --font-subdir? What do you think?

I like your idea of --base-path - it is a better and more correct name than --website.
The --font-subdir parameter is a good idea and I understand what you say about modifications to the CSS. For many simple websites, this is a good thing. I think you should include it.
I actually already mimic --font-subdir in my setup script. This script creates a directory per font and then calls google-font-download to download that font to that folder and create the css inside of it.
And this is perfect I think for simple websites. But once concatenation of css files occurs, then --base-path might need to still be used.  Maybe my use case is more complex than other developers? Or maybe my /css folder hierarchy needs to be tweaked?  I am not certain. What I know is that --font-subdir would be useful but I would still need to use --base-path with it.
I will try to explain by using one of my websites as an example. For tigsus.com, there are font dependencies on...

google
font-awesome

And then for site-layout, third party assets are isolated from local assets or sub-sections.

Third party fonts:  _fonts
Third party libraries: _third
css, including concatenated css from third-party libs and _fonts: /css
css that's in a sub-section:  /users/css

For example, during development, I may use combined-font-local.css but then in production I use a concatenated/combined file in combined-local.css.
Then in my setup scripts for fonts, I declare various types of css types.
URL_FONTS_LOCAL="/public/_fonts"
URL_FONTS_DEV="//dev.public-url.com:8401/public/_fonts"
URL_FONTS_PROTO="//proto.public-url.com/public/_fonts"
URL_FONTS_PROD="//public-url.com/public/_fonts"
URL_FONTS_AWS="//cdn-public/_fonts"

The script automatically creates font/css directories and google-font-download greatly assists in this process. Then css is combined for all third party libraries and internal resources into a single file for publishing. I could use @import but I don't see an advantage to it right now.
So.... if --font-subdir would get me a better development paradigm, then great!  Do you see it?  Right now I don't see it. I would still need --base-path as well. I wish there was a simpler paradigm because it would also simplify my setup script. Maybe I'm missing something but I don't think so.
But also my example is most likely in the minority. Adding --base-path is sufficient for my needs and I wouldn't need to keep a fork open.

With some retooling for my complex example, what might work is using a combination of --base-path and --font-subdir and --output. The assumption is that font.css is not automatically created inside the font directory inside --font-subdir.
For example, run google-font-download with the following inputs:

--base-path=../_fonts
--font-subdir=_fonts
--output=css/_fonts.css
Multple urls might need to be supported, if not already:

"https://fonts.googleapis.com/css?family=Roboto+Slab:400,100,300,700"
"https://fonts.googleapis.com/css?family=Kaushan+Script"
"https://fonts.googleapis.com/css?family=Montserrat:400,700"

This is created:

_fonts/Roboto
_fonts/Kaushan-Script
_fonts/Montserrat
css/_fonts.css  ( --base-path for each font would be ../_fonts/ and the --font-subdir would have been _fonts)
css/combined-css-all.css (concats _fonts.css or uses @import plus all other referenced css)

Then the font urls inside the generated output CSS file should work in place without resorting to multiple specialized url prefixes (eg URL_FONTS_LOCAL or URL_FONTS_DEV). But like I said, my use case is most likely in the minority. I'm perfectly happy getting --base-path included.

@neverpanic Will this be merged?  We also have the case of locally hosting but on an independent subdomain.  Another case is if we want to combine / minify the font css, relative paths will lose the font file location.


ci: add nightly eval

Motivation
add Llama 3.1 8B for test
This PR will continue to be improved upon.

Modifications

Checklist

[ ] Format your code according to the Contributor Guide.
[ ] Add unit tests as outlined in the Contributor Guide.
[ ] Update documentation as needed, including docstrings or example tutorials.

It works well https://github.com/sgl-project/sglang/actions/runs/10655959596/job/29534081214 and I'll update it

ref
https://github.com/sgl-project/sglang/compare/main...ci
https://github.com/sgl-project/sglang/issues/1272
TODO

[ ] add more models
[ ] add result threshold verification


Entropy value is always zero in detailed view

Describe the bug
The final report contains enthropy graph and value but the detailed view in EMBArk shows only 0.

so the graph on the main page is missing:

To Reproduce
Steps to reproduce the behavior:

EMBArk installation (default mode)
Start EMBArk: sudo ./run-server.sh
Use the firmware available here: anything
Do a scan
Check enthropy on detailed view page.

Desktop (please complete the following information):

OS: Ubuntu Server 22.04.1

btw ... we will remove the Entropy statistics from the dashboard in the near future.


Bring fluent emojis to WSA

Is your feature request related to a problem? Please describe
No response
Describe the solution you'd like
Replace Android default emojis with the Windows Fluent Emojis would bring a more consistence Windows11 experience to WSA.
Describe alternatives you've considered
No response
Please specify the version of Windows Subsystem for Android
2301.40000.4.0

Hi, thank you for this feature request. Currently this isn't on our immediate roadmap, but we're always listening to the community!

Please no! 😅 Google's Noto Emoji is fully open source and very colourful. See: https://googlefonts.github.io/noto-emoji-animation/

Is your feature request related to a problem? Please describe
No response
Describe the solution you'd like
Replace Android default emojis with the Windows Fluent Emojis would bring a more consistence Windows11 experience to WSA.
Describe alternatives you've considered
No response
Please specify the version of Windows Subsystem for Android
2301.40000.4.0

OH HELL NAW, I dislike the windows emojis. The AOSP emojis look far better

If only there was a way to get Android emojis on Windows...

If only there was a way to get Android emojis on Windows...

What a coincidence. I just did that. Check out the project below
perguto/Country-Flag-Emojis-for-Windows


Cardboard masks

About the PR
Added a "Cardboard Mask" which can be constructed using 1 sheet of cardboard and 5x LV cables.
Why / Balance
I personally believe the cardboard mask would fit in the game, particularly with how simple it is. I have little more to say.
Media

(There is a typo in the first and second screenshot ("masks" instead of "mask") - it has been fixed and now reads correctly.)
Requirements

[x] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl:

add: New cardboard masks can now be constructed out of a sheet of cardboard and a few low-voltage cables.

How is this a BreathMask?

How is this a BreathMask?

Perhaps you are breathing through a tube made out of an electrical cable with the wire removed? I am not entirely sure myself - and i had as such considered not making it one.
The main reason i made it a BreathMask was that other similiar masks were BreathMask-s. The primarily influence being the very similiar "joy mask", which seems to be only a flat piece of either paper, plastic or cardboard, held up by string, which can also be using as a breathing mask.
(The clown mask and mime mask being BreathMask-s are other influence, although less so as they are more dissimilar to a mask made out of cardboard and electrical cables.)
I am open to making changes.

The sprite looks a little flat, something about it feels strange but I can't put my finger on what.

I have brought this addition up for discussion with the other maintainers and the general agreement was that this item is not needed. The main reason stated is that there are already similar, more visually interesting indentity blocking items, for example the cardborg mask. Feel free to continue to contribute in the future. Thank you.


added option to overwrite existing files (not adding #XX)

Dupe of https://github.com/behdad/fonttools/pull/208


Fix camera limitation due to jpg encoding

I noticed that the camera sensor was limited in resolution and frequency, by default is set to 640x480 10fps, when trying to increase that the frame rate was falling down to 6/7fps on a Quadro RTX 5000.
After looking in the code and searching for a performance bottleneck with unity profiling tool, I find out that the image where send in CompressedImage format made from Texture2D.EncodeToJPG().
This method was intended for screenshots purpose and not real-time encoding.
Following ZeroSimROSUnity camera sensor implementation, a good way is to simply send raw buffer without any encoding, allowing high quality.

Now running the simulation at 140fps in the demo scene, using camera sensor of 1920x1080 at 20fps (Running on Ubuntu 22.04 with Quadro RTX 5000).

[!WARNING]
The depth camera may be broken I didn't check.

@alexandrefch
Our changes have made it difficult to merge this PR into the master branch.
Could you please submit the PR to beta/v2.0? so we can include your changes in v2.0.6.


Consider allowing specifying specific versions for audit-as-crates-io in edge-case scenarios.

In the majority of cases, an audit-as-crates-io entry should be applied to all versions of the crate, as it's due to a locally developed crate being also deployed to crates.io or a crates.io crate being vendored locally to perform some modifications.
There is an edge-case when we patch a specific version of a crate to redirect all exports to the more recent version of the crate in order to reduce crate version duplication across our version graph. We don't want to audit the version we're replacing with a redirect, however we do want to audit the target version if we happen to vendor it locally to make changes.
To handle this edge-case, it may be possible to make the value of audit-as-crates-io either a bool (as it is today), which would apply to all versions, or potentially a table with entries corresponding to specific versions. If a table is in use, each version in use must be specified explicitly.

We realized that since our forwarder crates use fake version numbers (0.7.999), they'll actually never match crates.io and cargo-vet will automatically do the right thing. As such I don't think we have a use-case for this.


[Crystal] Update maintainers

Signed-off-by: Mabel Zhang<EMAIL_ADDRESS>

Please re-add my name as an author.

Oops sorry! Dropped this one somehow


Add tasks for Transactor milestone

Kicking off transactor design. There are two major surfaces of the transactor interfaces:

Staging Transactions

Point of interaction for clients

Journal syndication

API used by clients--push or pull

We want to focus on interface driven design, allowing us to fake as many things as possible. These include:

Journal persistence

In memory, array/linked list based (our approach for now)
RocksDB
IPFS
Cassandra, etc

Consensus

We should aim to wrap Raft in a layer more domain (journal) specific, so we can tolerate "unity" i.e. single node consensus (ht @parkan)

Syndication

Push/pull whatever

Are there any interfaces missing here?

we also need to consider health checking and dealing with crashes.

We can start by describing the PhaseII development milstone:
A few tier-1 nodes (transactors) in a fully connected graph effectively providing data write services.
Then we can isolate parts, both at the interface level but also at the component/process level.
So to start we need

basic overlay maintenance with simplified transaction commit
client API and stub implementation
store interface and stub implementation

I think this is missing the Peer API

right, I mean the Client in RFC2 nomenclature -- L-SPACE will be a client of the core network.
Do we want a separate repo for the core network, or do we want to build in L-SPACE with a separate package?

So, in terms of implementation as a replicated state machine (eg with copycat), the transactor network effectively maintains the blockchain index.
The responsibilities of the transactor:

maintain canonical -> chain head index
accept a sequence of Entities/Artefact/Cells for a store write / blockchain commit
perform a replicated write which updates the index
collect the operations in a current block
every X transactions or Y minutes write the block, extending the blockchain

Using copycat with an in memory index and binary index snapshots to disk, we can scale up to the RAM of our node cloud instances. If we go for something small and inexpensive we can say have 1G of RAM for the index, so we can effectively scale up to about 10 mil entries.
In terms of the final Phase II/Transactor network milestone we should consider writing the seed data and constructing the Genesis blockchain.

The atomicity of datastore needs some elaboration.
The transactors can race to either write or pin the data to the store. Because the index is maintained consistent by the state machine, the representation of the data in the store is deterministic. In effect the "atomic write to the store" is a "write or pin".
One important detail, in regards to persistence in the store, is that we need to pin all cells in the various chains recorded in the blockchain, not just the heads.
The pinning can serve from disk and not in-memory, with a scaling limit at the size of the blockchain. With cheap cloud instances we should be able to scale up to ~20G for the blockchain.

Another point: Given the index any node can recover all chain cells by walking backwards from chain heads, provided they are already pinned by other nodes.
Also, we should have a separate component for the store, with the transactors interacting through an interface.
The store would handle journal persistence and write/pinning for objects in the chain and could handle the blockchain as well.
In addition, the decomposition allows us to mock the store, either with a key-value store db or dynamodb etc.
Let's put it in a separate process/box from the transactors, and let's limit the latter to a replicated state machine maintaining the index.

My assumption so far was that this repo would hold the core network code (I already made an sbt multiproject with a few stub projects, see the top level)
re: journal persistence, do you mean writing to local FS on the node, or to IPFS?

I mean writing to the datastore -- we can do various forms of persistence if we have an external component: local key-value for testing, dynamodb for bootstrap, and ipfs for when we go live.
We can actually use dynamodb for backing store (instead of S3) even when we are writing to ipfs.

Ok, sounds good. So the initial implementation will be no-op, presumably. Agreed on separation then.

@parkan to be clear this was just for transactor design

@bigs I've made individual tasks for these and mostly assigned them to you (other than the ones I know vyzo is working on). Please take a look and make sure they're correct/reassign + close this issue 😄


devicelab mac-10 is under expected diskspace on /

mac-10 was quarantined because it was showing less free space than required on /.
Cleaned up sudo rm -rf /private/var/folders/* which brought it back to required levels.


fix: switch enabled state of custom model settings

The model path and prompt template settings were not being enabled / disabled when user starts or stops the server.

@HarukaMa Can you please rebase your PR locally?
The file has since been moved 2 directories down from / to:
src/main/java/ee/carlrobert/codegpt/settings/service/LlamaModelPreferencesForm.java
src/main/java/ee/carlrobert/codegpt/settings/service/llama/form/LlamaModelPreferencesForm.java

I probably will need to check if other newly added local model settings need to be updated as well.


Update docs to make worker nodes count optional

Description of changes:
Updated docs to change the worker nodes count field from "required" to "optional" and specifying the default value as 1.
Testing (if applicable):
make build
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/cherry-pick release-0.19

/cherry-pick release-0.18


refactor: refactored chat.py

What does this PR do?
Refactors chat.py file in the following ways:

List Comprehension in history_langchain_format: This removes repetitive .append() calls by using a cleaner and faster list comprehension approach.
Refactor source_md Function and Source Deduplication.
Simplify Conditionals for response and query_rewrite.
args.repo_id is only included if available, with a default fallback.

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag  members/contributors who
may be interested in your PR.

Thanks for your contribution! Could you please run these formatting tools:
isort --profile=black .
black --line-length=120 .


Improve multicluster security by using service accounts with reduced RBAC permissions

@costinm had suggested improving security by reduced RBAC permissions in https://github.com/istio/istio/issues/4822#issuecomment-395318154.  Need a little more clarity on requirements.
A couple options were discussed in the multicluster 0.8 issue tracker.

Place RBAC rules in the istio-remote helm chart
Reduce permissions from admin to some lesser privileges on credentials registered with the Istio control plane

Do 1, or 2, or both?

doc PR with multicluster procedure with service-account and minimal clusterRole:   https://github.com/istio/istio.github.io/pull/1484
rendered page:  https://deploy-preview-1484--preliminary-istio.netlify.com/
Possibly the ServiceAccount, ClusterRole, and ClusterRoleBinding creation could be added to the istio-remote helm chart.  Still the documented procedure would need to have instructions for building the remote's kubeconfig for the serviceaccount token.

With the merge of #6366 an istio-multi service-account is created via the istio-remote. This service-account is bound to a clusterrole, istio-reader, with minimal and read-only access.  The setup->kubernetes->multicluster document details how to create a kubeconfig file mapped to this service-account and create the multicluster secret for pilot to use it.
Closing this issue.


Switch to use ESM modules with Dual export for supporting CJS

Discussions

https://github.com/TypeStrong/ts-node/issues/1007

Tutorials

Publishing node modules using typescript and ES modules
Import ESM .ts module in node
Latest Typescript and Node - as bare-bone as possible example app

Links

Native ES Modules in NodeJS: Status And Future Directions, Part I
7 Different Ways to Use ES Modules Today!
TypeScript / Node.js: Importing Knex into an ES6 module
Typescript, NodeJS and ES6/ESM Modules

Done


Do not pass "wrapFocus" List prop to Tag

Allowing wrapFocus to remain in the ...rest parameter will throw a react-dom warning about an unrecognized prop.

Thanks!


[WIP] #7 - add get package support

Implemented getPackage(params) function, see Python equivalent API here
Related issue #7
Related EPIC #4
Prettier styling has been used on some files, that's why some places you might see no any logic changes just styling.

@kmanaseryan i recommend closing this and starting a clean PR ...


Increase max size limit to 250MB

What does this change?
In https://github.com/guardian/pfi/pull/839 we set the file upload limit to 100MB. This PR bumps that further. As  far as I can tell, there was no particular reason to limit workspace uploads to 100MB. We have had at least one user need to upload a file larger than 100MB, this change would have helped them.
As a follow up piece of work, we should expose the file size limit in the UI and warn users when they try to upload a file above the limit.
How to test
Tested on playground with a 190MB file
Have we considered potential risks?
There could be performance implications of allowing such a large file to be uploaded via the UI. Hopefully the new dashboards should allow us to pick those up as and when they occur

Update: I have added some client side code to warn users about the limit:

Outstanding gif game @zekehuntergreen @srbd


chore: Use GitHub Action task for PR creation

Only run on the main repo, not forks
Use peter-evans/create-pull-request for commit/PR work
Don't run CI jobs on sync branch, just PR as it creates

Closes #1771

@tabatkins @foolip getting pretty close, but the current job failed during the commit creation, so I swapped to a GitHub Action task I've used before for nodejs/docker-node to do automated PRs
https://github.com/tabatkins/bikeshed/runs/1930321063?check_suite_focus=true

PS: It looks like when using the built-in GITHUB_TOKEN the rate limit is 1000 vs. if you change over to use a personal PAT, where it is 5000

@tabatkins will you review this?


⚠ Bofrost.fr has degraded performance

In 5fba763, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1649 ms

Resolved: Bofrost.fr performance has improved in 16e689e after 19 minutes.


Problem with :style in vue teamplate

Describe the issue / bug.
The dot is replaced with a comma when we want to add a fractional value to :style. This error only occurs in the Electron. When checking the code in the browser, everything works steadily.
How can I reproduce this problem?
Take a clean template and replace the LandingPage component with my component.
If visual, provide a screenshot.
https://yadi.sk/i/PmunbybK3UHj2s
https://yadi.sk/i/z-qzuN1z3UHj7C
landingPage
https://yadi.sk/d/i6wZ5DPX3UHjBq
Tell me about your development environment.

Node version: 9.11.1
NPM version: yarn 1.5.1
vue-cli version: (if necessary)
Operating System: MacOS High Sierra

If you are looking to suggest an enhancement or feature, then feel free to remove everything above.

I find smth about that bug
https://bugs.chromium.org/p/chromium/issues/detail?id=623347


Fix launch urls

Part of #365
Test URLs:

Before:

https://main--shredit--stericycle.aem.page/

After:

https://fix-launch-urls--shredit--stericycle.aem.page/

Doing a cowboy merge, since the changes are definitely fine and don't affect anything else right now


Relevant functionality buttons are getting deactivated when clicking on a feature in the map twice

Reported by Rachel during yesterday's bug out event
Relevant functionality buttons, zoom, delete, clear selection, show selected are getting deactivated when clicking on a feature in the map twice.
If I select a feature in the map, I see it selected in the table view. The Zoom, Delete, Clear Selection, and Show Selected button are all active at the top of the table. If I click the same feature in the map again, it still appears as selected in the map and table, however the Zoom, Delete, Clear Selection, and Show Selected buttons are no longer active.

It is still reproducible in devext. here is a test app https://sg-em-devext.mapsdevext.arcgis.com/apps/instant/manager/index.html?appid=580af16b1142418bb69c2991008039a7

@azizaparveen installed this last week...should be good to go.

Looks good


Feature Request: Ability to add a new comment (nested resource)

Very nice gem.  I'm using it on my first Rails 3.1 project and it is working well.  I'm an inexperienced coder and the ease of install/setup is very much appreciated.
Going outside the box of "editing in place", I tried to use this gem to create a "new comment" on a page where I'm showing a Post.  In my models:

Post

has_many :comments
accepts_nested_attributes_for :comments
-Comment
belongs_to :post
attr_accessible :body

In the :show action of my posts_controller.rb I created a new instance of :comment (@new_comment = @post.comments.new) and assigned the :body text to be: "Click here to add a comment...".  In the show.html.erb file I added: <%= on_the_spot_edit @new_comment, :body %>
When I entered some text and click "OK" I got the error:  "Couldn't find Comment without an ID"  I'm assuming that the :update action cannot save a new instance.  I'm guessing that if on_the_spot could be told to call the :create action, this might work, but I'm too inexperienced with Rails to know for sure.
I've found many approaches to adding a Comment to a page where I'm showing a Post, but they all seem to be overly complex.  This is a common enough use-case, you may want to consider adding the ability for on_the_spot to create a new nested-resource record "in place."  I'm sure it would be a popular addition.  (Or if there is a way to accomplish this already, adding some documentation on the subject would be great.)

Actually that is quite identical. Just use form_for and fields_for. Does that help?


Add support for ICS Files (#59)

Done #59
There's issue that it can not set absolute value to icalendar's trigger.
So I just set 365days, 182days, 90days, 30days to notify 1 year, 6 months, 3 months and 1 month for now.
I'm working on the issue.

Looks great! A few suggestions:

Text should point users to the ics file, with maybe a link on how to subscribe?
Add corresponding redirects and Link headers, same as for JSON files.

Few suggestions for calendar text:

Doesn't look like we can use HTML, because the spec expects ICS files to be part of a multi-part email message. I might be wrong
Links should go to both endoflife.date as well as the upstream page
The text should make it clear what the event is about, and why the user has gotten a notification. Something like "Nodejs 17 will become End-of-life on $DATE" for eg.

A calendar: true/false property on the global level to turn off calendars for products where we don't have dates (just yes/no).
Thanks a lot for the PR, this is gonna be very helpful 🥇!

Thank you for your quick review.

The main text for every product should point users to the ics file, with maybe a link on how to subscribe?

I added calendar link in template file.

Add corresponding redirects and Link headers, same as for JSON files.

I edited _headers, _redirects.

Doesn't look like we can use HTML, because the spec expects ICS files to be part of a multi-part email message. I might be wrong

Could you explain what I should do?
I couldn't understand.
You want to use HTML message?

Links should go to both endoflife.date as well as the upstream page

It seems icalendar doesn't accept multiple urls.
So I just added endoflife.date to the ALTREP.

The text should make it clear what the event is about, and why the user has gotten a notification. Something like "Nodejs 17 will become End-of-life on $DATE" for eg.

I added description like that except for the $DATE
It can not describe the date exactly in the message since it depends on client's timezone.

A calendar: true/false property on the global level to turn off calendars for products where we don't have dates (just yes/no).

There are products which has release date but not eol date: android, go, macos, etc.
I would like to add only release date to the calendar in the case.
A single flag such calendar: true/false can not cover this.

There's issue that it can not set absolute value to icalendar's trigger.
So I just set 365days, 182days, 90days, 30days to notify 1 year, 6 months, 3 months and 1 month for now

I got feedback and fixed it.

Any update?

I'll review and merge this soon. I just want to test this with more than a few clients (haven't tested on iOS/Android yet).

@captn3m0 ^^ ping ?

The link on https://deploy-preview-755--endoflife-date.netlify.app/wagtail links to webcal:///calendar/wagtail.ics, rather than webcal://deploy-preview-755--endoflife-date.netlify.app/calendar/wagtail.ics.
Works well on Apple calendar otherwise.
The event name being "Wagtail 2.13 EOL" would also be superior to just "EOL 2.13" -- the description of "Wagtail 2.13 will become End-of-life." is good though.
I don't see a link to endoflife.date, though, only to the Wagtail release schedule at https://github.com/wagtail/wagtail/wiki/Release-schedule

@captn3m0 ping ? what is the situation about this PR ?

This PR is rather old. I just rebased it from master resolved the conflicts.

New conflicts introduced by #2031 resolved.

Here is the template to use if later we want to implement Jekyll Generator instead : https://gist.github.com/woodworker/6725728.

@rikuson, it took some time but it's finally merged! Thanks a lot for your contribution.


[issue/20] commands lowercase

regular commands are not case insensitive!

Please can you rebase out the first and third ones? It might just be easier to squash all three.

Also, it would be nice in the admin set and remove commands for that to lowercase it - otherwise they could set a command and it would be impossible to call it.

Merged.


Feature/function scoped

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Stealth confidential wallet "transfer_from_blind" adds fee twice...

The fee code surrounding wallet_api::blind_transfer_help (calls to and internally) is confusing.  I believe in one case the user pays double fees.
double fee case
wallet_api::transfer_from_blind adds the fee to the amount
auto blind_in = asset_obj->amount_to_string( from_blind.fee + amount )

and passes this to wallet_api::blind_transfer_help where later the change amount is found by getting the fee subtracted out twice (so they appear to be paying a double-fee).  The first is the "amount" that contains the fee and the second is the fee itself:
auto change = total_amount - amount - blind_tr.fee

Note, there is another call to blind_transfer_help which is not subtracting fees first.
Related #452

James was going to produce a pull request with the suggested fix.

Not an issue..


feature: Check chrom length within VCF header

Is your feature request related to a problem? Please describe.
For vcf2parquet, option for chrom length is not easy to deal with.
option '-c' / '--chrom2length-path'.

Describe the solution you'd like
Check within the VCF to obtain the chrom length (contigs), if exists
Describe alternatives you've considered
None, yet.
Additional context
NA

Unfortunately, chromosome lines are not mandatory in VCF. A solution might be to make the chrom2length option not mandatory and if it's not present and chromosome lines are missing, raise an error.
Does that sound satisfying?

That sounds good!


Resizing panes on left monitor break when right is primary

Description
The UI doesn't quite work right on secondary monitors when the coordinate system is negative for them.
Repro steps
Have two monitors.  Have the monitor on the right be the windows primary.  When renderdoc is displayed on the left monitor (which has negative X coordinates in windows UI terms), when you drag the control to resize the EventBrowser to make it wider, it snaps to a position near the right edge of the display.  Moving renderdoc to the other monitor, and the resize works as expected.
Environment

RenderDoc build: e.g. v1.3 nightly from Apr 04 2019
Operating System: Windows 10
API: D3D11/D3D12,
GPU : Radeon VII, latest gpu drivers (2019.4.2)

I can't reproduce this, but I'm testing on windows 7 so maybe it's a windows 10 exclusive bug. I'll need to see if I can connect up multiple monitors to my win10 test box.
Could you record a video/screencast showing the problem?

I have found 2 more requirements:

An empty renderdoc session won't exhibit the UI quirk.  There must be a capture being analyzed (so there are events showing in the EventBrowser pane).
DPI scaling of 150%.  When it is changed to 100% the UI is behaving normally.

Does it happen with 200% DPI scaling? It came up recently that Qt doesn't properly support non-integer DPI scaling so there might be bugs there that I can't fix, I'll try to test and see if it's some calculation on my side that's going wrong.

I was able to set something up to repro this. I think it's actually independent of the scale factor, but I can't verify since windows 10 doesn't let me set a DPI scaling of 200% on my 1080p monitors.
I stepped through the Qt code and it's a Qt bug, the negative pointer position breaks under DPI remapping between actual and logical co-ordinates it seems. You might be able to report this to Qt but I would be surprised if it ever gets fixed unfortunately.


[vcpkg] Added command line switch --all-installed to allow exporting of all packages without needing to specify individual packages

Describe the pull request
A command line switch has been added to the export command that allows all installed packages to be exported without requiring them to be specified individually.

What does your PR fix? Fixes issue #
N/A

Which triplets are supported/not supported? Have you updated the CI baseline?

The PR does not consider triplets. It simply allows the export command to export all installed packages which I found to be useful in our own project that uses vcpkg.

Does your PR follow the maintainer guide?

Yes. In particular the PR is concerned with the export function of the vcpkg tool itself (not any ports).

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: miseri sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

I have also considered adding this feature, but because some ports will fail in the build queue, subsequent ports will abort the build. I think we should consider this situation.

Hm... I think it's an interesting idea, but I'd rather put it behind an experimental flag if anything. I'll see if we can discuss this in our meeting.

Okay, our feeling in the meeting was that this was a good feature, but it should be experimental; can you rename the flag --x-all-installed?

Ok, great, thanks for the quick feedback.
I will rename the flag to --x-all-installed.
On Fri, Mar 6, 2020 at 1:44 AM nicole mazzuca<EMAIL_ADDRESS>wrote:

Okay, our feeling in the meeting was that this was a good feature, but it
should be experimental; can you rename the flag --x-all-installed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vcpkg/pull/10304?email_source=notifications&email_token=AAP4OSZX326C3TNURLQLD63RGA2PHA5CNFSM4LBEZ472YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN7DN5Q#issuecomment-595474166,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAP4OS2LXZ2MF3XGXHYCNMDRGA2PHANCNFSM4LBEZ47Q
.

Alright, this looks good to me, but I'm not personally comfortable merging it since I'm pretty new to the team; I'll approve it and request someone else review. Thanks so much @miseri 😄

clang-format'd, LGTM!

Alright, this looks good to me, but I'm not personally comfortable merging it since I'm pretty new to the team; I'll approve it and request someone else review. Thanks so much @miseri smile

Thank you for the great tool, glad I could contribute a little something back. :-)


[ERROR] [sr]fail to solve inverse kinematics (please change the solver) for 7-DoF open-manipulator-p

Hello everyone,
I am working on an open-manipulator-p setup that has a third party end-effector mounted, which has an additional DoF. Following from this our kinematic chain contains 7-DoF. Three of the IK-solvers in /open_manipulator_p_libs/src/kinematics.cpp behave really strange for this setup and can't find solutions. One of the solvers Forward: ChainRule, Inverse: SRJacobianOnlyPosition works good out of the box. As I am pretty new to robotics, I am searching for paper references, but I was not able to determine any. Can anyone give a paper reference on which the implementations are based?

@towardthesea tagged

Closing this issue as there isn't any recent activity. Please feel free to reopen when necessary.

Hi @ROBOTIS-Will ,
We are still waiting for a response from the Open-Manipulator-P developers, so please keep it open and kindly tag who from Robotis taking charge of this issue.
Thanks!

Hi @towardthesea
I'm afraid that we do not provide a specific guideline for a customized product.
Please note that the kinematics solution is designed based on 6DOF OpenMANIPULATOR-P.
If you are running on ROS, using the MoveIt tool might help you to operate your solution.
Thank you.