remove provider url from check error method

Fixes #1991 .

Changes proposed in this PR:

fix provider url field

@bogdanfazakas @mariacarmina can you please review this.

this breaks the validation for Custom parameters if the users selects to publish and algo and use Custom parameters
LE: actualy not related to custom parameters, step 1 not validated at all for algorithms

Can you please provide the exact steps please. I haven't been able to reproduce it.

Validation Custom Parameters:

sure, so on my end the issue the issue is that even if all fields are valid when trying to publish an algorithm the continue button is not active, so it should be something with the disable logic for this button

when selecting dataset is all good with the disable logic and the validations

sure, so on my end the issue the issue is that even if all fields are valid when trying to publish an algorithm the continue button is not active, so it should be something with the disable logic for this button

Ok, got it. It looks like the custom params check is not optonal anymore. I'll take a look

Found the issue, unfortunately is not related to this PR. I created an issue to keep track of it and fix it.


Provide ability to check whether VCR is recording or not

The ruby client provides this as VCR.current_cassette.recording?. This is particularly helpful when you have a method that polls an endpoint. You can have a typical polling interval during recording, but set it to 0 during playback.

Code should not depend on test utils. Make your interval or sleep function a  parameter of your unit under test

Not suggesting that the code under test would use the test util. In the test code either the polling interval values can be mocked, or the function parameter can be adjusted, based on whether the cassette is recording or playing back.

But the test code would know if it was running under a cassette, it would be inside the decorator or with block

A lot of changes have happened to VCRpy since this ticket was opened. As this ticket has become stale and we have a lot of old tickets that need to be groomed, I'm closing this for now to make it easier to see what is still relevant.
However if it is still needed, please feel free to re-open or create a new ticket.
Thanks! 🙏


chore: switch from @stylistic/eslint-plugin to @stylistic/eslint-plugin-js

With this PR there will be no more warnings during npm install.
Since @stylistic/eslint-plugin-js has no recommended config, I choose the all-flat config and adapted some of the rules to the current code style.

Thx :)


GPU Plugin High GPU Usage

Type
Performance
Operating System
Windows
OS Version
WIN 11
Bug description
GPU Plugin is using as much as 80% utilization on a 4070 ti when unlock FPS is turned on with either adaptive or "on" Vsync is selected. Never noticed this behavior previously and have been using the GPU plugin for 2+ years. (~6 months with the 4070ti).
Screenshots or videos

RuneLite version
Runelite <IP_ADDRESS>
Launcher 2.6.1
Logs
No response

We haven't changed anything about the GPU plugin recently, so this is likely due to some change on your machine.

Thanks. Good to know. Maybe it was something in a recent GPU driver...

I'd recommend using the FPS Control plugin to limit your FPS if you don't want it to run at maximum FPS at all times.


Retry ECS task waits

Long DB dump/loads hit the limit on the ECS Task waiter from the aws-sdk.

This was resolved


dreaded error code 6

I've tried this on 3 different computers, 3 different OS'es (OS X, Ubuntu, and Debian on an ARM7 SOC), and I'm consistently getting
Playing: Kraftwerk - Tour De France - 2009 Remastered Version

events.js:154
      throw er; // Unhandled 'error' event
      ^
TrackError: Failed to send to backend
    at Spotify._onmessage (/Users/nbor/Documents/progproj/node/node-spotify-web/lib/spotify.js:464:15)
    at emitTwo (events.js:100:13)
    at WebSocket.emit (events.js:185:7)

if I just console.log(msg) at line 464 in spotify.js, it returns
{ error: [ 12, 1, '' ], id: 6 }

Error 6 seems to be a common problem with Windows machines, according to the Spotify community boards. I found one thing that documents it as  "A playback function was invoked before playback was initalized properly."
I'm kind of at a loss. It worked last week... :(

Still having this issue? I can look into it via VM if so.

Having the same issue.

Have you tried updating anything? I'm using the fork from Xstasy and running protobufjs 2.2.1, no issues on Win. Loading my VM now to test things with your architecture.

I've tried updating, I just now tried the fork from "Xstasy" and I am now getting:
"Uncaught Exception:
TypeError: Cannot read property 'length' of undefined
at Object.exports.hex2bin"
Something to do with encryptions

Finally got a bit of free time and managed to get things working with OS X. Simply ran npm install on the new package.json for Xstasy's fork, then npm update. Running any version of node before 4.4.0 has worked so far. My spotify.js has only a few minor tweaks different than Xstasy's, but nothing substantial.

I have tried all of the above and I'm still getting the previously mentionned error, it happens when using the following methods on a track Instance: trackUri, play and getStreamURL

Ok, so trackUri is giving me undefined, strangely play works, and getStreamURL gives me a callback error. I'll see if I can fix this. trackUri seems easy, but I'm not entirely sure why getStreamURL is giving me a callback error. Method looks underdeveloped though.

getStreamURL is something I added back before Spotify added encrypted streams - it's no longer functional and should really be removed.

I figured it out. Since I'm using electron, the newer versions come with node 6.*, I had to downgrade back to electron v1.0.2 for the library to work correctly.

Thanks for the help guys!

@MadScripter You can disable that. I never had it setup that way with my app, but I see others with that. Just look for spotify.disconnect (or whatever the object name is), and remove.

If you are talking about the "example" then I never used it either, but if I try and play 2 songs in a row, I get an error about the account not being premium, so I assume you have a premium account :P

I plead the 5th. You can bypass such a requirement though. It's seriously just a simple check.

Haha alright I'll try to figure it out, thanks!

Such a modification would go against the TOS of course, and also probably yield some errors once in a while. One would probably have to add some error handling to gracefully recover from such errors.


Move to SDL_ShaderCross namespace

The fact that we're using SDL_ directly is an artifact from when the SPIR-V interop was inside SDL itself - we should fix this to make it clearer in applications.

https://github.com/flibitijibibo/SDL_gpu_shadercross/commit/2753e64204a60f893270d48b11a58aeedf2aa398


Integration Not Recovering After Error

The integration is being used on a Microsoft Windows Server 2016 Datacenter host. At certain times the host seems to get maxed out on resources, i.e. we get CPU, load average, disk utilisation spikes, and then the integration appears to stop sending samples.
The issue is that the integration doesn't appear to recover until the Infrastructure agent is restarted.
Description
Some internal info has been outlined in support ticket #448676
We get errors in the logs like:
time="2021-02-27T08:21:39Z" level=warning msg="integration exited with error state" component=integrations.runner.Runner error="exit status 2" integration_name=com.newrelic.winservices stderr="(last 10 lines out of 7476): ....
and a message below for the monitored services:
time="2021-02-28T15:01:42Z" level=info msg="Removing inventory cache" agentEntityIDChanged=false component=PatchSender entityKey=":" offlineTime=24h0m0s
Expected Behavior
I would expect the integration to recover once resources become available again.
NR Diag results
Steps to Reproduce
Max out resources on the host, observe windows services samples not being sent, integration does not recover.
Your Environment
Microsoft Windows Server 2016
Additional context
I've built a troubleshooting dashboard that is detailed in support ticket: #448676.

Thanks @roobre
We've got a support ticket open if you have access, #448676
Otherwise here's the rest of the log:
time="2021-02-27T08:21:39Z" level=warning msg="integration exited with error state" component=integrations.runner.Runner error="exit status 2" integration_name=com.newrelic.winservices stderr="(last 10 lines out of 7476): [INFO] exporter msg=Build context (go=go1.14.4, user=fv-az104\runneradmin@fv-az104, date=20200617-17:40:48) source=exporter.go:352\n[INFO] exporter msg=Starting server on <IP_ADDRESS>:9182 source=exporter.go:355\n[INFO] exporter msg=Enabled collectors: service, cs source=exporter.go:326\n[INFO] exporter msg=Starting windows_exporter (version=0.13.0-10-gc9f1e50-dirty, branch=HEAD, revision=c9f1e5068a267aeb3e8cff47bc5323cbc050055a) source=exporter.go:351\n[INFO] exporter msg=Build context (go=go1.14.4, user=fv-az104\runneradmin@fv-az104, date=20200617-17:40:48) source=exporter.go:352\n[INFO] exporter msg=Starting server on <IP_ADDRESS>:9182 source=exporter.go:355\n[INFO] exporter msg=Enabled collectors: service, cs source=exporter.go:326\n[INFO] exporter msg=Starting windows_exporter (version=0.13.0-10-gc9f1e50-dirty, branch=HEAD, revision=c9f1e5068a267aeb3e8cff47bc5323cbc050055a) source=exporter.go:351\n[INFO] exporter msg=Build context (go=go1.14.4, user=fv-az104\runneradmin@fv-az104, date=20200617-17:40:48) source=exporter.go:352\n[INFO] exporter msg=Starting server on <IP_ADDRESS>:9182 source=exporter.go:355"
time="2021-02-27T11:37:56Z" level=warning msg="integration exited with error state" component=integrations.runner.Runner error="context canceled" integration_name=com.newrelic.winservices stderr="(last 10 lines out of 52): [INFO] exporter msg=Build context (go=go1.14.4, user=fv-az104\runneradmin@fv-az104, date=20200617-17:40:48) source=exporter.go:352\n[INFO] exporter msg=Starting server on <IP_ADDRESS>:9182 source=exporter.go:355\n[INFO] exporter msg=Enabled collectors: service, cs source=exporter.go:326\n[INFO] exporter msg=Starting windows_exporter (version=0.13.0-10-gc9f1e50-dirty, branch=HEAD, revision=c9f1e5068a267aeb3e8cff47bc5323cbc050055a) source=exporter.go:351\n[INFO] exporter msg=Build context (go=go1.14.4, user=fv-az104\runneradmin@fv-az104, date=20200617-17:40:48) source=exporter.go:352\n[INFO] exporter msg=Starting server on <IP_ADDRESS>:9182 source=exporter.go:355\n[INFO] exporter msg=Enabled collectors: service, cs source=exporter.go:326\n[INFO] exporter msg=Starting windows_exporter (version=0.13.0-10-gc9f1e50-dirty, branch=HEAD, revision=c9f1e5068a267aeb3e8cff47bc5323cbc050055a) source=exporter.go:351\n[INFO] exporter msg=Build context (go=go1.14.4, user=fv-az104\runneradmin@fv-az104, date=20200617-17:40:48) source=exporter.go:352\n[INFO] exporter msg=Starting server on <IP_ADDRESS>:9182 source=exporter.go:355"

Thanks for raising this. Since you already have a ticket open, the support/product team will follow from that, as it is our preferred method for managing issues that require troubleshooting and/or have a big scope.

Thanks @roobre
We've got a support ticket open if you have access, #448676
Otherwise here's the rest of the log:
time="2021-02-27T08:21:39Z" level=warning msg="integration exited with error state" component=integrations.runner.Runner error="exit status 2" integration_name=com.newrelic.winservices stderr="(last 10 lines out of 7476): [INFO] exporter msg=Build context (go=go1.14.4, user=fv-az104\runneradmin@fv-az104, date=20200617-17:40:48) source=exporter.go:352\n[INFO] exporter msg=Starting server on <IP_ADDRESS>:9182 source=exporter.go:355\n[INFO] exporter msg=Enabled collectors: service, cs source=exporter.go:326\n[INFO] exporter msg=Starting windows_exporter (version=0.13.0-10-gc9f1e50-dirty, branch=HEAD, revision=c9f1e5068a267aeb3e8cff47bc5323cbc050055a) source=exporter.go:351\n[INFO] exporter msg=Build context (go=go1.14.4, user=fv-az104\runneradmin@fv-az104, date=20200617-17:40:48) source=exporter.go:352\n[INFO] exporter msg=Starting server on <IP_ADDRESS>:9182 source=exporter.go:355\n[INFO] exporter msg=Enabled collectors: service, cs source=exporter.go:326\n[INFO] exporter msg=Starting windows_exporter (version=0.13.0-10-gc9f1e50-dirty, branch=HEAD, revision=c9f1e5068a267aeb3e8cff47bc5323cbc050055a) source=exporter.go:351\n[INFO] exporter msg=Build context (go=go1.14.4, user=fv-az104\runneradmin@fv-az104, date=20200617-17:40:48) source=exporter.go:352\n[INFO] exporter msg=Starting server on <IP_ADDRESS>:9182 source=exporter.go:355"
time="2021-02-27T11:37:56Z" level=warning msg="integration exited with error state" component=integrations.runner.Runner error="context canceled" integration_name=com.newrelic.winservices stderr="(last 10 lines out of 52): [INFO] exporter msg=Build context (go=go1.14.4, user=fv-az104\runneradmin@fv-az104, date=20200617-17:40:48) source=exporter.go:352\n[INFO] exporter msg=Starting server on <IP_ADDRESS>:9182 source=exporter.go:355\n[INFO] exporter msg=Enabled collectors: service, cs source=exporter.go:326\n[INFO] exporter msg=Starting windows_exporter (version=0.13.0-10-gc9f1e50-dirty, branch=HEAD, revision=c9f1e5068a267aeb3e8cff47bc5323cbc050055a) source=exporter.go:351\n[INFO] exporter msg=Build context (go=go1.14.4, user=fv-az104\runneradmin@fv-az104, date=20200617-17:40:48) source=exporter.go:352\n[INFO] exporter msg=Starting server on <IP_ADDRESS>:9182 source=exporter.go:355\n[INFO] exporter msg=Enabled collectors: service, cs source=exporter.go:326\n[INFO] exporter msg=Starting windows_exporter (version=0.13.0-10-gc9f1e50-dirty, branch=HEAD, revision=c9f1e5068a267aeb3e8cff47bc5323cbc050055a) source=exporter.go:351\n[INFO] exporter msg=Build context (go=go1.14.4, user=fv-az104\runneradmin@fv-az104, date=20200617-17:40:48) source=exporter.go:352\n[INFO] exporter msg=Starting server on <IP_ADDRESS>:9182 source=exporter.go:355"

Hi Charlie
Would you be interesting on be an EAP of our new beta version?
Performance problems because of WMI have been fixed.
If yes, please send me an email to<EMAIL_ADDRESS>Regards

Hi
We just released a new open beta version of the Windows Services integration.

This issue was closed because it has been inactive for a long time despite it can be reopened at any point if you think it still relevant.
Thank you for your contribution!


Azure AD groups for project members

Is your feature request related to a problem? Please describe.
At my employer we provision projects around sets of groups and access to resources with these same groups. Every project/team gets an Administrator, Contributor and Reader role. These roles more or less exactly relate to azure devops and azure RBAC roles of the same name. There might be other roles if more specific RBAC is needed by the project but every project gets at least those basic roles. I couldn't find any mention of this in the docs so I assume it's not yet supported.
Describe the solution you'd like
Create azure AD groups when a new project is created. Users added to the project will be added to the azure ad group(s)
Describe alternatives you've considered
Since there doesn't appear to be any RBAC yet, we could start with just one group per project. Ideally of course we would like to have full RBAC support.

closed because of solution redesign


Error:(118, 32) error: DocumentRevision is abstract; cannot be instantiated

getting error in tasks model class
The document revision is an interface that it tries to instantiate

@raihan-mpower we are currently re-writing the DocumentRevision/BasicDocumentRevision classes. You should visit the documentation for our latest tagged release here: https://github.com/cloudant/sync-android/tree/0.15.5
This will explain that you can instantiate BasicDocumentRevision classes.
In the near future we will make a release which removes BasicDocumentRevision and changes DocumentRevision from an interface to a concrete class. Apologies for any confusion.

When will the new release be?

Hopefully in the not too distant future, we still have a few things to work through before we release.


Unhandled Promise: Something with SSH2

Hi,
I am trying to set up a simple connection and it's possible my service account doesn't have the right permissions but I am not sure that's the case as I've given it some pretty wide ranging permissions and the client was able to create empty files... So it definitely has a connection and some form of access.
Here is how I have run the command:
node sftp-gcs.js --bucket gs://xxxx-sftp --port=xxxx --service-account-key-file=/home/xxxx/xxxx.json --debug=debug --user=xxxx --password=xxxx

Here are the permissions I have provided (one section for each set of permissions in each role I have assigned to this service account):
customRole
logging.buckets.copyLogEntries
logging.buckets.create
logging.buckets.delete
logging.buckets.get
logging.buckets.list
logging.buckets.undelete
logging.buckets.update
logging.cmekSettings.get
logging.cmekSettings.update
logging.exclusions.create
orgpolicy.policy.get
resourcemanager.projects.get
storage.buckets.create
storage.buckets.delete
storage.buckets.get
storage.buckets.list
storage.multipartUploads.abort
storage.multipartUploads.create
storage.multipartUploads.listParts
storage.objects.create
storage.objects.delete
storage.objects.get
storage.objects.list
storage.objects.update

LoggingAdmin
logging.buckets.copyLogEntries
logging.buckets.create
logging.buckets.delete
logging.buckets.get
logging.buckets.list
logging.buckets.undelete
logging.buckets.update
logging.cmekSettings.get
logging.cmekSettings.update
logging.exclusions.create
logging.exclusions.delete
logging.exclusions.get
logging.exclusions.list
logging.exclusions.update
logging.fields.access
logging.locations.get
logging.locations.list
logging.logEntries.create
logging.logEntries.download
logging.logEntries.list
logging.logMetrics.create
logging.logMetrics.delete
logging.logMetrics.get
logging.logMetrics.list
logging.logMetrics.update
logging.logServiceIndexes.list
logging.logServices.list
logging.logs.delete
logging.logs.list
logging.notificationRules.create
logging.notificationRules.delete
logging.notificationRules.get
logging.notificationRules.list
logging.notificationRules.update
logging.operations.cancel
logging.operations.get
logging.operations.list
logging.privateLogEntries.list
logging.queries.create
logging.queries.delete
logging.queries.get
logging.queries.list
logging.queries.listShared
logging.queries.share
logging.queries.update
logging.queries.updateShared
logging.sinks.create
logging.sinks.delete
logging.sinks.get
logging.sinks.list
logging.sinks.update
logging.usage.get
logging.views.access
logging.views.create
logging.views.delete
logging.views.get
logging.views.list
logging.views.listLogs
logging.views.listResourceKeys
logging.views.listResourceValues
logging.views.update
resourcemanager.projects.get
resourcemanager.projects.list

LogWriter
logging.logEntries.create

StorageAdmin
firebase.projects.get
orgpolicy.policy.get
resourcemanager.projects.get
resourcemanager.projects.list
storage.buckets.create
storage.buckets.createTagBinding
storage.buckets.delete
storage.buckets.deleteTagBinding
storage.buckets.get
storage.buckets.getIamPolicy
storage.buckets.list
storage.buckets.listTagBindings
storage.buckets.setIamPolicy
storage.buckets.update
storage.multipartUploads.abort
storage.multipartUploads.create
storage.multipartUploads.list
storage.multipartUploads.listParts
storage.objects.create
storage.objects.delete
storage.objects.get
storage.objects.getIamPolicy
storage.objects.list
storage.objects.setIamPolicy
storage.objects.update

Here are some errors I am encountering:
List Doesn't work:
sftp> ls

(node:16740) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'EOF' of undefined
    at SFTP.<anonymous> (/home/noahgary/sftp-gcs/sftp-gcs.js:663:69)
    at SFTP.emit (events.js:314:20)
    at 12 (/home/noahgary/sftp-gcs/node_modules/ssh2/lib/protocol/SFTP.js:3115:15)
    at SFTP.push (/home/noahgary/sftp-gcs/node_modules/ssh2/lib/protocol/SFTP.js:278:11)
    at CHANNEL_DATA (/home/noahgary/sftp-gcs/node_modules/ssh2/lib/server.js:747:23)
    at 94 (/home/noahgary/sftp-gcs/node_modules/ssh2/lib/protocol/handlers.misc.js:859:16)
    at Protocol.onPayload (/home/noahgary/sftp-gcs/node_modules/ssh2/lib/protocol/Protocol.js:2024:10)
    at ChaChaPolyDecipherNative.decrypt (/home/noahgary/sftp-gcs/node_modules/ssh2/lib/protocol/crypto.js:753:26)
    at Protocol.parsePacket [as _parse] (/home/noahgary/sftp-gcs/node_modules/ssh2/lib/protocol/Protocol.js:1993:25)
    at Protocol.parse (/home/noahgary/sftp-gcs/node_modules/ssh2/lib/protocol/Protocol.js:292:16)
(node:16740) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:16740) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

put command works for empty file: but throws error:
sftp> put emptytest.file
Uploading emptytest.file to /emptytest.file
emptytest.file                                                                                100%    0     0.0KB/s   00:00

2021-12-16T20:15:37.378Z debug: [sftp-gcs] Client connected!
2021-12-16T20:15:37.436Z debug: [sftp-gcs] authentication: method=none
2021-12-16T20:15:37.436Z debug: [sftp-gcs] We have at least a user to match
2021-12-16T20:15:40.870Z debug: [sftp-gcs] Client disconnected
2021-12-16T20:15:53.185Z debug: [sftp-gcs] Client connected!
2021-12-16T20:15:53.193Z debug: [sftp-gcs] authentication: method=none
2021-12-16T20:15:53.193Z debug: [sftp-gcs] We have at least a user to match
2021-12-16T20:15:56.672Z debug: [sftp-gcs] authentication: method=password
2021-12-16T20:15:56.673Z debug: [sftp-gcs] Client authenticated!
2021-12-16T20:15:56.676Z debug: [sftp-gcs] Client SFTP session
2021-12-16T20:15:56.678Z debug: [sftp-gcs] REALPATH<1>: path: "."
2021-12-16T20:15:56.678Z debug: [sftp-gcs] Returning "/"
2021-12-16T20:16:02.617Z debug: [sftp-gcs] OPEN<2>: filename: "/emptytest.file", flags: w
2021-12-16T20:16:02.617Z debug: [sftp-gcs] Converted "/emptytest.file" to "emptytest.file"
2021-12-16T20:16:02.617Z debug: [sftp-gcs] Opening file for WRITE
2021-12-16T20:16:02.621Z debug: [sftp-gcs] CLOSE<3>: handle: 0
2021-12-16T20:16:02.621Z debug: [sftp-gcs] Closing GCS write stream
2021-12-16T20:16:02.926Z debug: [sftp-gcs] Detected an error with writeStream to the GCS file: TypeError: Cannot read property 'OK' of undefined

put command for non-empty file doesn't work:
sftp> put another.file
Uploading another.file to /another.file
another.file                                                                                0%    0     0.0KB/s   --:-- ETAConnection to localhost closed by remote host.
Connection closed

2021-12-16T20:19:09.735Z debug: [sftp-gcs] Client connected!
2021-12-16T20:19:09.748Z debug: [sftp-gcs] authentication: method=none
2021-12-16T20:19:09.748Z debug: [sftp-gcs] We have at least a user to match
2021-12-16T20:19:12.919Z debug: [sftp-gcs] authentication: method=password
2021-12-16T20:19:12.919Z debug: [sftp-gcs] Client authenticated!
2021-12-16T20:19:12.964Z debug: [sftp-gcs] Client SFTP session
2021-12-16T20:19:12.967Z debug: [sftp-gcs] REALPATH<1>: path: "."
2021-12-16T20:19:12.967Z debug: [sftp-gcs] Returning "/"
2021-12-16T20:19:17.813Z debug: [sftp-gcs] OPEN<2>: filename: "/another.file", flags: w
2021-12-16T20:19:17.814Z debug: [sftp-gcs] Converted "/another.file" to "another.file"
2021-12-16T20:19:17.814Z debug: [sftp-gcs] Opening file for WRITE
2021-12-16T20:19:17.819Z debug: [sftp-gcs] WRITE<3>: handle: 0, offset 0: data.length=10
/home/noahgary/sftp-gcs/sftp-gcs.js:534
                        sftpStream.status(reqId, STATUS_CODE.OK);
                                                             ^

TypeError: Cannot read property 'OK' of undefined
    at /home/noahgary/sftp-gcs/sftp-gcs.js:534:62
    at afterWrite (/home/noahgary/sftp-gcs/node_modules/readable-stream/lib/_stream_writable.js:469:3)
    at processTicksAndRejections (internal/process/task_queues.js:86:21)

Please forgive me for any IAM issues as I'm pretty new to GCP and still learning how to manage all of this...

I used @karatekaneen 's typescript fork and was able to get this running in no time. Same permissions and everything.
https://github.com/karatekaneen/sftp-gcs

@noahjustinsure OOOh ... thank you for the post.  It appears a few days ago, Github came into my project and force upgraded some of the package.json files.  Specifically, it changed a dependency from a 0.x version to a 1.x version.  This introduced a breaking change.  Researching now.

@kolban-google Oh my! Silly Github. Thanks so much for your work! I noticed the syntax for ssh2 is different now:
const {
  Server,
  sftp: {
    OPEN_MODE,
    STATUS_CODE,
  },
} = require('ssh2');

rather than what we have now:
const ssh2 = require('ssh2');

const STATUS_CODE = ssh2.SFTP_STATUS_CODE;

@noahjustinsure Ahh ... TY sir am dedicated to fixing this now ... here is the Pull Request that broke the show
https://github.com/kolban-google/sftp-gcs/pull/19
The fault is ALWAYS and ultimately mine.  Apparently Github made the recommendation to upgrade and another committer (this week) accepted.  He issued a pull request ... and it was ME who didn't test it.  That means that the fault is mine (bad moderator).

No worries at all @kolban-google you've done great work.


Fix flist for verilator

PR #52 forgot to update the Makefile for verilator simulation. This PR adds back those updates. Now verilator can run properly.

Probably need to update vivado/ as well then

Okay let me figure out that before we merge.

Thanks!

Should be able to merge now.

Thanks!


Split conversions with long

Split conversion types
Add long conversion
Refactored structure
Corrected some summary blocks

I would like to check around the max and min values more in a later issue.

Fixes #18 #17 #25 #26


Icon setting in React Mode

Do you intend on restoring the "Icon Mode" which would export height and width =1em ?

Hey, thanks for using my plugin!
As for the "Icon Mode", I didn't think it was used very much, but I see that I was wrong. I will add it back :+1:

added in #11, will be released with #12


fix problem with LONG commandlines

either by using files as compiler option input

or env variables

or a mixture of all

or by not using transitive includes in lake

Done by using Process.spawn (ruby 1.9) and by text file passing to the compiler (ruby 1.8).


Consider releasing data under CC-BY-SA license

Currently it is unclear what license the data is released under. The existence of a public API means that the team wants others to use the data. But not knowing what license the data comes in makes it difficult for others to use the same.
I suggest that the license under which the dataset is released be documented clearly.
I would say use CC-BY-SA, but there are other possible licenses documented here: https://help.data.world/hc/en-us/articles/115006114287-Common-license-types-for-datasets

Regarding the GPL license, https://asd.learnlearn.in/gpl-api-output/

@asdofindia Thanks for raising this issue. Yes, we have been pondering over the correct licensing format for the data. The link you shared should be helpful.
cc @triedcatched

Open Data Commons Open Database License
https://opendatacommons.org/licenses/odbl/index.html

+1 we're looking at using this data in open-covid-19 (https://github.com/open-covid-19/data), but cannot do so until the licensing is clear.

@themonk911 some #opendata govt of India is releasing.
https://data.gov.in/major-indicator/covid-19-india-data-source-mohfw

Thanks @naveenpf, unfortunately it doesn't look like they provide historical data. Do you know if any other source provides historical data?

@themonk911 Wikidata https://www.wikidata.org/wiki/Wikidata:WikiProject_India/COVID-19_task_force

Thanks @naveenpf, that's really useful :)

I have split the License of the repository into two - one for code and one for the data. Both are listed separately in two different files.
https://github.com/covid19india/api/blob/master/LICENSE_DATA
https://github.com/covid19india/api/blob/master/LICENSE_CODE
Shifted from GPL3.0 to MIT for the codebase to make things more permissive. Will send out a communication regarding this in the dev group
@themonk911 @asdofindia, hope this clears the licensing situation.

Thanks so much!


Fixed lib cryptoconditions pytest

added libcryptoconditionstest.so build for py tests
added test run config on macos
fixed py tests (retcode checks, c function definitions)

The PR has been closed because it is not relevant. We are no longer responsible for maintaining sfusd-core.


Same issue

It was working fine but not anymore since yesterday, on my Windows 10 Pro Version 1709 build 16299.64 64bit.

The issue seems to be, those who have exercised their own initiative to download and replace the resolver list and minisig, are now presented with a null reference error from bootstrap code. The error handling (having taken a quick look) could do with being more defensive, while being protective of passing invalid parameters to non-managed code. Better to perform existence checks on expected files at start-up (async) and present the user with a list of missing prerequisites as they are discovered. The app can take some time to start at times too, since the UI is not shown until a number of initialisation tasks are complete, it can be alarming. Perhaps these activities can be performed on a background thread fully async. Get the UI up immediately, it’s the very first thing to do.  Then show the traditional load screen spinner, letting the user know what the app is waiting on. The UX has a fault here too. But this error is indicative of these issues.

How you will let these users know a new version is available, is going to be a challenge, since the update code is unreachable since the error happens before the user has access to the UI and kills the application instead of placing the application into a limited mode of operation, while allowing other aspects unrelated to still function. Better to zone the application vertically, so that is becomes composited modules of functionality. only the UI controls related to a given zone are disabled when a show stopper affects that zone, but keep other areas functional.

@Rubber-Duckie weird, Github doesn't list any of your pull requests.

Perhaps this needs my help. I am not a big user of the project, but its value is indisputable.


Add linear warmup for use with existing schedules

Proposed changes
Add linear_warmup to schedulers, which takes a scheduler function (cosine_decay, etc.), the number of steps for the warmup, the initial value (defaults to 0), and the final value
Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING document
[x] I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have updated the necessary documentation (if needed)

def join_schedules(schedules, boundaries
  def schedule(step: chex.Numeric) -> chex.Numeric:
    output = schedules[0](step)
    for boundary, schedule in zip(boundaries, schedules[1:]):
      output = jnp.where(step < boundary, output, schedule(step - boundary))
    return output
  return schedule

I was trying to avoid lazily evaluating the schedules every time. But I have now updated/adapted per @awni


view missing context method

when a view is created without a collection, it will not have a context method, which throws an error in render. We can just decorate the same methods that are used on collection-views onto view to avoid this

should be fixed


Jobs healthcheck

Reason for This PR
https://github.com/roadrunner-server/roadrunner/issues/1363
Description of Changes
Checking if queue exists via SQS.
Required PRs:

https://github.com/roadrunner-server/status/pull/41
https://github.com/roadrunner-server/jobs/pull/58

License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

[ ] All commits in this PR are signed (git commit -s).
[ ] The reason for this PR is clearly provided (issue no. or explanation).
[ ] The description of changes is clear and encompassing.
[ ] Any required documentation changes (code and docs) are included in this PR.
[ ] Any user-facing changes are mentioned in CHANGELOG.md.
[ ] All added/changed functionality is tested.

Close, because State func will be used for status purpose.


build(ci): skipping dependabot builds

v13.5.2 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.


Version 1.4.1 - Revit.DesignApplication

Features

Create Revit.DesignApplication with DesignApplication to load correct assembly version in the bundle. (#7)

Updates

Use DesignApplication to load correct assembly version in the bundle.
Add ApplicationInitialized event to test.

Video with this update.


Update dependencies

Coverage remained the same at 86.116% when pulling 8ad56afdef87591ba6ba78bce9bb995a47fa3b53 on rel_branch into c9df29fbb0e57097584f55ecf66bcc1762bfdc5a on master.


Does this module support concurrent calls?

Thanks for writing this module - it works perfectly. But I saw you used single file /tmp/exec.sock as the data pipe for executing the command and retrieve the result. What happens if multiple worker processes execute commands at the same time? Do the results mix up? Thanks.

Oh, I just checked https://github.com/jprjr/sockexec, the concurrent calls should be handled properly in individual connections.
Note: sockexec -m option is a good choice for massive concurrent calls. :-)


A lot of miscellaneous work

Nice project you've got! I made a bunch of changes here:

Merge in the wip-reconnect branch, which gives a big improvement in robustness.

Rename README and TUTORIAL to .md files, for GitHub user-friendliness, and expand the README.

Add a connection timeout. We can't do a general socket timeout, but we can add a timeout to the socket's initial connection attempt, which could be useful.

Get rid of the dependency on PyYaml, replacing it with a custom parser that's more compatible with beanstalkd, and about 30 times faster. Adjust documentation to match.

Add basic docstrings to all public methods.

There was also a brief attempt to make connections thread-local, but that patch was reverted. The Right Thing in this case is probably to keep thread-local connection pools, like they do over in redis-py.
Anyway, you've made what is easily the best beanstalkd client for Python, so thanks for that.

I would also love to see these fixes merged.
Thanks.


Wrong display on sidebar

I created some VM and I really like UTM.
The display of VM in sidebar is wrong :

Configuration

iMac 27-inch
UTM Version: 2.0.27
OS Version: macOS Big Sur
Intel or Apple Silicon? Intel i7

Thank's

Duplicate of #2335


Support terminateThreads

Add support for terminate threads. Useful when more than one scripts are being debugged and we want to terminate only one instead of all.
Before this PR can be applied the vscode-debugadapter requires a fix submitted in PR https://github.com/microsoft/vscode-debugadapter-node/pull/214

I suggest merging #378 first, as that one is bigger and includes package fixes already.


[AMBARI-23132] Fix ConfigUpgradeValidityTest.testConfigurationDefinitionsExist test failure

What changes were proposed in this pull request?
Ignoring org.apache.ambari.server.state.stack.ConfigUpgradeValidityTest#testConfigurationDefinitionsExist since there are no active HDP stacks in the Ambari code tree.
How was this patch tested?
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.ambari.server.state.stack.ConfigUpgradeValidityTest
[WARNING] Tests run: 2, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 11.897 s - in org.apache.ambari.server.state.stack.ConfigUpgradeValidityTest
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 2, Failures: 0, Errors: 0, Skipped: 1

Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/932/
Test PASSed.


Import not working

Trying to reproduce the import example as follows:
$ cat justfile
include "foo/bar.just"
a: b
    @echo A

$ cat foo/bar.just
b:
  @echo B

Then , when I run just:
$ just -l
error: Expected '*', ':', '$', identifier, or '+', but found string
 ——▶ justfile:1:9
  │
1 │ include "foo/bar.just"
  │

Fails in ubuntu 22.04 (LTS) with the Prebuilt-MPR just version 1.14 and also with the cargo just 1.23.0

Also tested with just 1.23 (installed with cargo) and also fails.
Running on zfs. Could it be related?

Nope. With bash the result is the same.

Replace include with import, and it should work:
$ cat justfile
import "foo/bar.just"

a: b
    @echo A
$ cat foo/bar.just
b:
  @echo B

Frack.  ;-)
Thanks a lot for your help!

You bet, and thank you for using it!


Code blocks do not render 88 chars without horizontal scrollbar

We're using a line length of 88 characters in our code base, and that's also the standard in the Python community nowadays (e.g., enforced by Ruff and Black). Therefore, I think it would be great if code blocks on our documentation website could be rendered without horizontal scrollbars. For example, see the very last code block at the bottom of https://mne.tools/stable/auto_tutorials/epochs/40_autogenerate_metadata.html.

I don't understand the intention here, how would I scroll if you remove the scrollbar? I have to scroll on my screen to uncover all of the code

Or are you suggesting enforcing shorter lines for code blocks?

I thought the intent was "make the content area wider and/or shrink the font so that 88 chars is visible without scrolling". @cbrnr can you confirm/clarify?

Yes, exactly what you're saying @drammock!

yeah but ... on my screen, you cannot make it any wider without hiding the navigation
slightly reducing the font size should be fine, but I'm not sure of this will free up enough space

I mean, since we are using 88 characters in our codebase, I think our website should also support displaying 88 characters without scrolling. I'm not a fan of shrinking the font size since this will make the code harder to read, and I would prefer making our main area wider. Forcing a shorter line length for our documentation is also not a good option since we want to stay consistent with our source code.

Maybe we can make one or both navigation panes a bit narrower so that the main area works with 88 chars in code blocks.


How do I test this?

Something like this would be very useful. Our current BigIPReport takes 2 minutes to load in a browser.

I know DataTables can take a json as source, but I don't know if we can talk it into rendering the tables, links and other things that are currently in the table. I'm not sure if DataTables would also render the entire table before displaying or not. A "react" front end or something similar would be awesome. load the json files into memory, do any searching and filtering from those data files, and dynamically render only the requested rows. It could leave out rendering the pool view until requested, and the status polling could handle dynamically adding or removing pool members as well as status.
Our current config has:
9 device groups
17 load balancers
6054 iRules
8597 pools
6996 virtualservers
10132 rows in BIG-IP Report
38704091 bytes in trim()ed "index.html"
Hmm. Might be nice to have a statistics page... I'll open an enhancement request. :)
The last reload 64 bit Chrome took 3.9 minutes before any of the json files were requested and then another 45 seconds after that to show the page. So we're almost up to 5 minutes to render the page.

It could leave out rendering the pool view until requested, and the status polling could handle dynamically adding or removing pool members as well as status.

I don't think this particular thing is a good idea. Most people would not use BigIPReport if they had to create the polling nodes. From the sessions I've had with people around the globe almost nobody understands how it works. And setting it up can be painful depending on firewall rules and security policies. Besides, we'd lose the name property here (could potentially be looked up from the JSON though I suppose).

Oh, I don't mean removing the pool rendering, I mean that if you have polling setup, re-render the pool info so it gets the updates. The initial render would come from the json pool data.


Sonoff cloud-connected devices becomes unavailable every couple of minutes

I have some sonoff devices connected to my home assistant. Some of them are locally connected, and they work flawlessly. I also have two other networks (away from home) where I have a 4g modem router and some sonoff in each one.
These are cloud connected to my home assistant at home.
Everything works fine, except that all my cloud-connected devices keep becoming unavailable for a couple of seconds.
I don’t think it’s a network problem, since they are always on in the ewelink app (using the main account which shares the devices to a secondary one that's used by HA). (Edit 2: I found out that the devices go offline on ewelink too.)
I would have no problem with this situation, but I can’t have reliable automations.
Would it be possible to keep last state if device becomes unavailable for less than a minute?

I think you did not create a second ewelink account as described in the readme

I think you did not create a second ewelink account as described in the readme

I did!

Are you sure no one and no other soft using this credential?

Are you sure no one and no other soft using this credential?

100%. I created it just for HA

There may be some problems with your Internet

There may be some problems with your Internet

To both my 4g connections (300km apart one from the other)? I doubt...😓

I found out that the devices go offline on ewelink too

So this is not a problem with integration


Style/SymbolArray autocorrect breaks code in partial-newline case

The Style/SymbolArray cop has autocorrect functionality to change, e.g., [:one, :two] to %i(one two). This mostly works correctly, though there is one case where the autocorrect would change the functionality of the code. There is already a test case that tests for a similar case, though unfortunately does not catch this.
The existing test case (passes):
new_source = autocorrect_source("[:one,\n:two, :three,\n:four]")
expect(new_source).to eq("%i(one\ntwo three\nfour)")

A slightly modified version of the test case (fails on master at time of writing):
new_source = autocorrect_source("[:one, :two,\n:three,\n:four]")
expect(new_source).to eq("%i(one two\nthree\nfour)")

Test output:
expected: "%i(one two\nthree\nfour)"
     got: "%i(onetwo\nthree\nfour)"

(compared using ==)

Diff:
@@ -1,4 +1,4 @@
-%i(one two
+%i(onetwo
three
four)

I caught this because we had code similar to the following in our codebase:
SOME_CONSTANT = [:one, :two,
  :three,
  :four]

Which was incorrectly autocorrected (see expected/actual below).

Expected behavior
Rubocop should autocorrect into an array of the same symbols (preferably with the same or further autocorrected layout/indentation):
SOME_CONSTANT = %i(one two
  three
  four)

Actual behavior
Rubocop merged the first two symbols:
SOME_CONSTANT = %i(onetwo
  three
  four)

Steps to reproduce the problem
Add the above test to spec/rubocop/cop/style/symbol_array_spec.rb and observe it fail, or otherwise try to autocorrect the case provided above.
RuboCop version
$ rubocop -V
0.53.0 (using Parser <IP_ADDRESS>, running on ruby 2.4.1 x86_64-darwin17)

Tested via spec against master at commit 841569b30 (latest at time of writing).

I ran into this as well. It seems like 0.49.1 does not have the issue. I'll take a look at bisecting where this was introduced.

I narrowed it down to 2ee27d2a55d44c973dc8c6eb57a8bec76b7b769e.

This is also present in Style/WordArray.
$ cat test.rb
foo = ['test', '123',
       'foo', 'bar']
$ rubocop -a --only Style/WordArray test.rb
Inspecting 1 file
C

Offenses:

test.rb:1:7: C: [Corrected] Style/WordArray: Use %w or %W for an array of words.
foo = ['test', '123', ...
      ^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected, 1 offense corrected
$ cat test.rb
foo = %w[test123
       foo bar]


Fixed OpenSSH infinite link. #2927

Fixes #2927

Should not there be some uninstaller.script property, which unlink that junction?

@Ash258 I have no idea. I guess simple delete shall understand that directory junction is something to be unlinked.

Personally, I think it is ready to merge. One can work on 32-bit versions for OpenSSH.
I can't properly test it because for some reason I have fresh OpenSSH in my system:
C:\Users\vladi\Documents\src\scoop-user>where ssh
C:\Windows\System32\OpenSSH\ssh.exe

C:\Users\vladi\Documents\src\scoop-user>ssh -V
OpenSSH_for_Windows_7.7p1, LibreSSL 2.6.5

I guess it is Windows Update.


Disable currently unsupported Hue Entertainment Areas

Description:
Philips introduced the so called "Entertainment Areas" feature a few weeks or month ago. In the Hue API, these are handled as a group, similar to "Room"-groups and "LightGroups". If a "Entertainment Area" is called like a "Room"-group (which makes sense and is used by users this way), the Hue platform will generate two identical entities. (same Entity ID with incr. number, same behaviour) Others also had this issue already with HA (https://github.com/home-assistant/home-assistant/issues/12969).
Unless HA differentiate between entertainment areas and other hue group types, maybe its appropriate to exclude the "Entertainment Areas"? I do not see any use case for them currently. Grouping of any kind is/can be done with the "Room" or "LightGroup" group-type (see https://developers.meethue.com/documentation/groups-api#214_notes) and there is no support in HA (also no PR or issue) for the special "Entertainment Area" features which differentiates them from the other hue group-types.
Related issue (if applicable): -
Pull request in home-assistant.github.io with documentation (if applicable): -
Checklist:

[X] The code change is tested and works locally.
[X] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Yes, I also think aiohue should support the Entertainment Areas/features. And yes, this is not a solution, its more like a temporary workaround until aiohue is ready.
Probably this could take some time as there is much to be implemented afaik. Hue Entertainment needs to know the positions of the bulbs in the room and so on...
Maybe someone else has a better idea how to deal with this?

I agree with @awarecan that this is not the right solution. What if users do care about being able to control an entertainment group at once? Users can already rename the entities and also they can just not set them up to be shown.

Just for discussion, I currently am using the entertainment groups in my config and names them "er_name_something" to tell them apart but would appreciate better entertainment group support.

We're going to keep entertainment. People can hide them or not set them up if they don't want to see it.


Swap low quality image for high quality one in full screen mode.

In full screen mode, the image as expected loses its quality. Is it possible to swap the current image for bigger higher quality version? Probably in the image array list, you specify the image source and an optional corresponding bigger version.

This sounds like a good idea, I'll look into it more to see if there's anything I can do first.


Refactor project to use goapi

[x] Remove git submodules
[x] Remove gen codes and graphql api
[x] Update makefile and readme

CI failed, codes LGTM, thanks for the quick reaction!!

CI failed, codes LGTM, thanks for the quick reaction!!

The project looks much compact. BTW, does goapi need release ?

CI failed, codes LGTM, thanks for the quick reaction!!

The project looks much compact. BTW, does goapi need release ?

It would be nice if goapi can be released so that we have clear change logs between releases, though it's not a must.
@hanahmily FYI this PR is merged


Tag White

In the screenshot the div tag are withe but I get mine red I'm the only one with this ?

I assume you are using Atom or Sublime? The screenshot is taken from VS Code, which shows the colors a little bit different than Atom/Sublime
We have adjusted the original Oceanic Next theme to make some parts of the code to appear in italics, and we haven't adjusted any of the colors of the original theme.
We are aware that the screenshot is not representative for Atom and Sublime, and are working on creating specific screenshots for each editor.
If you want to see how the original theme looks like, you can take a look at the orginal repo

Thank you

If you want help with the atom version I can change it for be like the screenshot.


[FilePicker] "Stock images" label not showing in portugues nor spanish

[ ] Enhancement
[x] Bug
[ ] Question
Version
[3.1.0]
Expected / Desired Behavior / Question
The label should show "Imagens de stock" in pt-pt and "Imágenes de stock" in es-es
Observed Behavior
Shows nothing
pt-pt:

es-es

Thanks!me

Hi @gabsnery , thanks for raising this issue.
There were updates to localised string files recently. Could you please install the latest beta version and try again?
npm i<EMAIL_ADDRESS>

Hi @gabsnery , thanks for raising this issue.
There were updates to localised string files recently. Could you please install the latest beta version and try again?
npm i<EMAIL_ADDRESS>

@joelfmrodrigues It worked =)
Is there any date for v3.3.0 release?

@gabsnery we are trying to get it out this week if all goes to plan :) stay tunned :)


⚠ Bofrost.at has degraded performance

In dde5e57, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1084 ms

Resolved: Bofrost.at performance has improved in 4d6bb51.


fix: Update doc site dependencies

Overview

Replicates change from #133, due to Github Actions failing to pick up e2e tests.

Tests
[Include a link to the passing GitHub action running the test suite here.]
Legal
This project is available under the Apache 2.0 License.

closing this as inactive. Reopen when updated with passing tests


more word-terminating characters

This PR contains a few more added word-terminating characters which I've found while using penda. To provide some context, the stoppedTypingAWord method is used to dictate during writing if the POST call for fetching text markings should be made. There are a few improvements and bugs associated with this current state, for which I intend to create additional issues and PRs.

Regarding the notes/reminders, yea I fully agree. Moreover there are bugs with this current behavior, e.g. if you change the text before the last word, the POST request is not triggered, even though it should. One reason of having these word-terminating characters, is to prevent being annoying to the user (if they are writing a word, and if the request is made after every text change, we would attempt to correct every word even though it's still not yet fully written), so this is some sort of quick fix.
But yea this is not a straightforward topic, I'll create an issue about this and we can further address it there.


[Test]Fix flaky markdown preview test

Summary of the Pull Request
What is this about:
CI runs are failing a lot on the MarkdownPreviewHandler Tests.
What is included in the PR:

Increase the timeout to wait for WebView2 to get initialized, as that might be what's taking longer on CI.

How does someone test / validate:

CI test runs pass more reliably.

Quality Checklist

[x] Linked issue: #18839
[ ] Communication: I've discussed this with core contributors in the issue.
[x] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[x] Binaries: Any new files are added to WXS / YML

[x] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Doing a second run to see if it passes
/azp run


Is this compatible with Algolia Autocomplete?

As far as my understanding goes, Instant Search and Autocomplete are treated as different things in Algolia's Instant Search documentation. My current implementation in Algolia uses the Autocomplete feature and i am trying to migrate it to Typesense, but Algolia's documentation is making me a bit confused if Autocomplete is part of instant search or not

@edsonfeimberg I used to find this a little confusing too! It turns out that there is a library called Autocomplete.js and then there's a widget called autocomplete in the Instantsearch.js library.
If you are using Autocomplete.js, then you don't need this adapter to use it with Typesense, as it already supports fetching data from any async data sources. So you can use the Typesense JS library directly and make calls to the search or multi search endpoints to fetch the data from Typesense to pass on to autocomplete.js.
If you are using the autocomplete widget in Instantsearch.js, then you can indeed use this adapter to integrate it with Typesense. Here's an example from the test-suite on how to do this.

Please document this!!!  I'm in the same boat as the OP and was struggling to decide which is which.

@vnugent I'm trying to implement this but I'm having a hard time converting the data received from typesense into a form that I can use components.Highlight({hit: item, attribute: "value"}) which is provided by the autocomplete library. I wish I could import SearchResponseAdapter to adapt the response. Is there any recommended way?

@joker-777 You should be able to import the SearchResponseAdapter from the typesense-instantsearch-adapter and pass it the Typesense response to get an object in Algolia's response format that should work with the highlight component.

@jasonbosco I'm trying but it doesn't work
import SearchResponseAdapter from "typesense-instantsearch-adapter/lib/SearchResponseAdapter"

webpack also tell me export 'default' (imported as 'SearchResponseAdapter') was not found in 'typesense-instantsearch-adapter/lib/SearchResponseAdapter' (possible exports: SearchResponseAdapter, __esModule)

@jasonbosco is there a public sandbox example or a public typesense server with some dummy data which I could use to create some examples?

@joker-777 You want to import it like this:
https://github.com/typesense/typesense-docsearch.js/blob/f2c496434b58c75767d534eb5cef2cd72a49af90/src/lib/DocSearch.js#L7
Feel free to use this collection: https://recipe-search.typesense.org/. You'll see the API keys in the network requests.

@jasonbosco oh wow didn't realize there was a search response adapter! I've been trying to get this to work with an algolia autocomplete custom plugin so this adapter will be super helpful. However using the import as specified above, it states there are missing declaration files :(

@uncvrd I think that's just a warning. We don't yet publish types for that file. So if you add // @ts-ignore before the import line, the warning should go away.

@jasonbosco Thanks a lot. I created a sandbox that shows my current problem. I can't get the highlight to work. In fact components.Highlight doesn't work at all. Only components.Snippet but the highlight markers are displayed as text. @uncvrd Does it work for you?
https://codesandbox.io/s/typesense-autocomplete-rkgrkr?file=/src/index.js

@joker-777 It looks like <mark> tags are not compatible with that component. It worked once I switched the highlight tags to the default one autocomplete.js expects. I've highlighted the changes I did from your code snippet below:
import { autocomplete } from '@algolia/autocomplete-js';
import Typesense from 'typesense';
import { SearchResponseAdapter } from 'typesense-instantsearch-adapter/lib/SearchResponseAdapter';
import '@algolia/autocomplete-theme-classic';

const init_search_field = () => {
  const client = typesense_client();
  // const adapter = typesense_adapter()
  autocomplete({
    debug: true,
    container: '#root',
    getSources: ({ query }) => [
      {
        sourceId: 'r',
        templates: {
          item({ item, components, html }) {
           // ======> Had to surround with a <div> to fix issues with the default CSS ===
            return html`<div>
              ${components.Snippet({
                hit: item,
                attribute: 'title',
              })})
            </div>`;
          },
        },
        getItems: () =>
          client
            .collections('r')
            .documents()
            .search({
              q: query,
              query_by: 'title',
              highlight_start_tag: '__aa-highlight__', // <===== Customize highlight tags
              highlight_end_tag: '__/aa-highlight__',  // <===== Customize highlight tags
            })
            .then((result) => {
              return search_response_adapter(result).adapt().hits;
            }),
        getItemInputValue: ({ item }) => {
          return item.title;
        },
      },
    ],
  });
};

const search_response_adapter = (result) =>
  new SearchResponseAdapter(
    result,
    { params: {} },
    { geoLocationField: '_geoloc' }
  );

const typesense_client = () =>
  new Typesense.Client({
    apiKey: 'XXX',
    nodes: [
      {
        host: 'XXX',
        port: '443',
        protocol: 'https',
      },
    ],
    connectionTimeoutSeconds: 2,
  });

init_search_field();

Link to code sandbox: https://codesandbox.io/s/typesense-autocomplete-forked-www6x9?file=/src/index.js

@jasonbosco Thanks a lot for this detailed solution it works indeed. Are you planning to support this in a more convenient way? For example, you could provide a method that basically does the following
export const adaptSearchResponse = (result) => {
  const adapter = new SearchResponseAdapter(
    result,
    { params: {} },
    { geoLocationField: '_geoloc' }
  return adapter.adapt().hits
}

or simply a method that creates a SearchREsponseAapter instance using the default configuration object.

@joker-777 I'm wondering where a method like this would go in the adapter...

@jasonbosco Something like this https://github.com/typesense/typesense-instantsearch-adapter/compare/master...joker-777:master (I didn't test it)
Then I could just write adapter = new SearchResponseAdapter(result)

For future reference, here's another way to use highlights without having to use the typesense-instantsearch-adapter: https://github.com/typesense/typesense-autocomplete-demo/blob/ad77a4a57635d0b82fdce4b4abc69a950bbbcbd4/index.html#L78-L86


Prevent tags from being duplicated by adding only unique tags to list

tks, do u think it is better to have a prop to determine if we should avoid duplicates?
something like in this PR: https://github.com/jwohlfert23/react-native-tag-input/pull/21?

Yes, @sibelius. I thought about that while working on this. And then scenarios where unique tags don't matter, and couldn't really think about a lot of use-cases. It's something we could add in though.

it makes sense, tks


cannot remove containers created during build with docker rm -f $(docker ps -a -q)

after successfully build images/services I´m unable to clean up the environment with docker rm -f $(docker ps -a -q)
Running with gitlab-runner 10.0.0 (2055cfdc)
  on Docker Runner (cf026217)
Using Docker executor with image docker:17.09.0-ce ...
Using docker image sha256:b7fe03622cba84a355d30dc6eb0efd66cd307293e0ba3ba1702bc0a7e0da6e1c for predefined container...
Pulling docker image docker:17.09.0-ce ...
Using docker image docker:17.09.0-ce ID=sha256:8e00cef02fc58f70eb68e1f5f8ddfa2a66195b5402edde6228072c57d17ff9b7 for build container...
Running on runner-cf026217-project-8-concurrent-0 via 83b72742801d...
Fetching changes...
HEAD is now at 22160db Update .gitlab-ci.yml
Checking out 22160dbf as gitlab-ci...
Skipping Git submodules setup
$ docker ps -a
CONTAINER ID        IMAGE                        COMMAND                  CREATED              STATUS                     PORTS               NAMES
514314bc4150        8e00cef02fc5                 "docker-entrypoint..."   15 seconds ago       Up Less than a second                          runner-cf026217-project-8-concurrent-0-build
ed1e355b7a96        b7fe03622cba                 "gitlab-runner-build"    19 seconds ago       Exited (0) 3 seconds ago                       runner-cf026217-project-8-concurrent-0-predefined
ae857fdf7703        wordpress_wordpress:latest   "docker-entrypoint..."   About a minute ago   Up About a minute          80/tcp, 443/tcp     wordtest.org
9449df1915b0        mariadb:latest               "docker-entrypoint..."   About a minute ago   Up About a minute          3306/tcp            wordtest.org_db
19d3f07c9614        wordpress_wordpress:latest   "docker-entrypoint..."   About a minute ago   Up About a minute          80/tcp, 443/tcp     example.com
411f691fec47        mariadb:latest               "docker-entrypoint..."   About a minute ago   Up About a minute          3306/tcp            example.com_db
720be5c226eb        b7fe03622cba                 "gitlab-runner-cac..."   9 minutes ago        Exited (0) 9 minutes ago                       runner-cf026217-project-8-concurrent-0-cache-3c3f060a0374fc8bc39395164f415a70
1f130e35737e        b7fe03622cba                 "gitlab-runner-cac..."   9 minutes ago        Exited (0) 9 minutes ago                       runner-cf026217-project-8-concurrent-0-cache-2ad4863160b155a50a63bfced3d597d7
$ docker rm -f $(docker ps -a -q)
ERROR: Job failed: exit code 137

I do not understand why this job fails.
and here is the part of the gitlab-ci.yml :
cleanup_job:
  stage: clean
  script:
    - docker ps -a
    - docker rm -f $(docker ps -a -q)
    - docker system prune
  when: always

docker system prune will already remove "all stopped containers", though it will most likely need a -f to not prompt for confirmation.  I would guess the failure might be a limitation of GitLab CI, but that is not my area of expertise. Since this doesn't seem to be a problem with the Docker image for Docker, I will close the issue.
In the future, this type of question might be a better for the Docker Community Forums, the Docker Community Slack, on Stack Overflow, or maybe the GitLab Forums.  Thanks!


Implemented horn sound base functionality

-Added GetKey method (modified copy of GetKeyDown method already present there) in CustomInput to operate continuous key pressing
-Looping of the horn sound is still not perfect yet. As we discussed before, problem is apparently in the original horn sounds SA engine was most probably modifying at runtime to better blend.
-I do have concerns about the method MakeSubclip() that is used to create loop-able sample for AudioSource, as it hasn't been tested for leaks yet. There are probably none, but it's a good practice to test it anyways. So should be tested horn AudioSource, since it has to be created additionally (due to new radio implementation which already uses one AudioSource), to prevent more of these components being created on, say, scene loads or whenever Awake is additionally called (but I reckon such scenario is not very common in game like this? I'm thinking this further as I work with RPGs where such scenario is quite common). I'll do all this in future commints.
-There is a doppler effect on horn sound. It sounds good in environment, although the effect is also laudable for the player inside car as well. This can be prevented pretty easily though, I'll implement that in next commit.

TODO:

Make looping of the sound better.
PlayerController.ReadEvents() is used to read events, not states. With GetKey() you are reading the state of the key. ReadStates() is used for reading states.
BaseScriptState should not be aware of vehicles. Yes, it should have OnHornButtonPressed(), but it should not handle the logic for this. The logic should be handled in VehicleSittingState.
Vehicle.IsHornOn has a wrong name. It's name suggests in what state is the horn, but you are using it as 'was horn button pressed this frame'.
Use different sound for different type of vehicle.
You are creating memory leaks. Every created AudioClip should be destroyed. Or, even better solution would be to create AudioClip only once during application lifetime and store it in a static variable.
Should work in multiplayer (I don't think it works right now)
As for CustomInput - again, you don't understand the difference between key state and key event. GetKey() is used for state, GetKeyDown() is used for event.

rip P/R

Umm,,mmmmmm


Ensure all requested bytes are read when using seek on caching stream

There was an issue discovered from aws-sdk-php that was causing getimagesize() to fail as seek was only reading to the end of a block instead of up to the requested offset.
This change fixes the issue.

@jeskew very true, updated!

Could you add a test that makes sure read is called more than once if the first attempt returns partial content?

Done :)

:shipit:


Define a SubJoin class to do subjoins into querybuilder

At the moment YII allows only to do sub-query, but SQL allows also to do sub-joins.
I usually use with an INNER JOIN chain LEFT JOINed with the FROM table.
The goal is this kind of sub-JOIN:
FROM user us
LEFT JOIN ( `lessonactivity` `st` INNER JOIN  `lesson` `ls` ON st.lessonId=ls.id INNER JOIN `chapter` `ch` ON ls.chapterId=ch.id INNER JOIN `topic` `tp` ON ch.topicId=tp.id) ON st.userId=us.id

The code
$_subJoin = (new \yii\db\SubJoin())
                    ->subJoin(['st'=>'lessonactivity'])
                    ->innerJoin([ 'ls'=>'lesson' ],'st.lessonId=ls.id')
                    ->innerJoin([ 'ch'=>'chapter' ],'ls.chapterId=ch.id')
                    ->innerJoin([ 'tp'=>'topic' ],'ch.topicId=tp.id');

$_query = (new \yii\db\Query())
->from(['us'=>'user'])
->leftJoin(["sj"=>$_subJoin], 'st.userId=us.id' );

I tried to reduce at the minimum the impact, and may be there's a better way to do, so I'm open to any improvement.

what is the difference between sub-join and normal join? can you point to the docs of some dbms?

There're two kind of differences:

optimization
precedence

Talking about the precedence, in a nested join (a better name than sub-join) you can specify the precedence of the joins like the AND/OR.
The concrete case
I'll use my situation as example:
user table may have or may have not a reference in lessonactivity for each user

levelactivity  --- userId:id --> user

lesson table has always a reference in lessonactivity table.

lessonactivity --- levelId:id --> lesson

chapter table has always a reference in lesson table

lesson --- chapterId:id --> chapter

the all inner join query
FROM user us
INNER JOIN  lessonactivity st  ON st.userId=us.id
INNER JOIN  lesson ls ON st.lessonId=ls.id
INNER JOIN chapter ch ON ls.chapterId=ch.id
returns a row for each user only if has a lessonactivitiy entry
the mixed inner/left join query
FROM user us
LEFT JOIN  lessonactivity st  ON st.userId=us.id
INNER JOIN  lesson ls ON st.lessonId=ls.id
INNER JOIN chapter ch ON ls.chapterId=ch.id
same as "the all inner join query" returns a row for each user only if has a lessonactivitiy entry
the all inner join query
FROM user us
LEFT JOIN  lessonactivity st  ON st.userId=us.id
LEFT JOIN  lesson ls ON st.lessonId=ls.id
LEFT JOIN chapter ch ON ls.chapterId=ch.id
returns one row for each user if has not a lessonactivitiy entry and many rows for each user as many lessonactivitiy entries
the correct query
FROM user us
LEFT JOIN ( lessonactivity st INNER JOIN  lesson ls ON st.lessonId=ls.id INNER JOIN chapter ch ON ls.chapterId=ch.id ) ON st.userId=us.id
return one line for each user with or without lessonactivitiy entry
Documentation
Here's the MySql doc page

After a more accurate reading of (MySql Join syntax)[http://dev.mysql.com/doc/refman/5.0/en/join.html]

This is a conservative extension if we consider each comma in a list of table_reference items as  equivalent to an inner join. For example:

> SELECT * FROM t1 LEFT JOIN (t2, t3, t4)
>                 ON (t2.a=t1.a AND t3.b=t1.b AND t4.c=t1.c)

is equivalent to:

> SELECT * FROM t1 LEFT JOIN (t2 CROSS JOIN t3 CROSS JOIN t4)
>                  ON (t2.a=t1.a AND t3.b=t1.b AND t4.c=t1.c)

In MySQL, JOIN, CROSS JOIN, and INNER JOIN are syntactic equivalents (they can replace each other). In standard SQL, they are not equivalent. INNER JOIN is used with an ON clause, CROSS JOIN is used otherwise.

My query could be
FROM USERS us
LEFT JOIN (
      `lessonactivity` `st` , `lesson`  `ls`, `chapter` `ch`
  )
    ON st.userId = us.id AND st.lessonId = ls.id AND ls.chapterId = ch.id

So a different solution can be:
the param $table of the joins (Join, LeftJoin, RightJoin and LeftJoin) behave like the param table of the From:

@param string|array $tables the table(s) to be selected from. This can be either a string (e.g. 'user')
or an array (e.g. ['user', 'profile']) specifying one or several table names.
Table names can contain schema prefixes (e.g. 'public.user') and/or table aliases (e.g. 'user u').
The method will automatically quote the table names unless it contains some parenthesis
(which means the table is given as a sub-query or DB expression).
When the tables are specified as an array, you may also use the array keys as the table aliases
(if a table does not need alias, do not use a string key).
Use a Query object to represent a sub-query. In this case, the corresponding array key will be used
as the alias for the sub-query.

example of implementation
Every *Join should be modified as in From:
    public function leftJoin($tables, $on = '', $params = [])
    {
        if (!is_array($tables)) {
            $tables = preg_split('/\s*,\s*/', trim($tables), -1, PREG_SPLIT_NO_EMPTY);
        }

        $this->join[] = ['LEFT JOIN', $tables, $on];
        return $this->addParams($params);
    }

Then if the $tables has more elements I wrap them with the round parentheses
    public function buildJoin($joins, &$params)
    {
        if (empty($joins)) {
            return '';
        }

        foreach ($joins as $i => $join) {
            if (!is_array($join) || !isset($join[0], $join[1])) {
                throw new Exception('A join clause must be specified as an array of join type, join table, and optionally join condition.');
            }
            // 0:join type, 1:join table, 2:on-condition (optional)
            list ($joinType, $table) = $join;
            $tables = $this->quoteTableNames((array)$table, $params);
            if(count($tables)>1){
                $table = "(".implode(', ', $tables).")";
            } else {
                $table = reset($tables);
            }
            $joins[$i] = "$joinType $table";
            if (isset($join[2])) {
                $condition = $this->buildCondition($join[2], $params);
                if ($condition !== '') {
                    $joins[$i] .= ' ON ' . $condition;
                }
            }
        }

        return implode($this->separator, $joins);
    }

Hi Cebe,
I'd like to close this push request, make new branch using the alternative solution and re-push.
Waiting your feed.

I've implement the new solution in new branch.
I've opened a new issue #7290 and where I'll pull the new patch request.


add a password generator

skeletonkey should be able to generate new passwords and save them with a new or old key

should be something like: skeletonkey add --generate-password KEY


Race condition in concurrent shutdown/startup (2: lock)

This is a really scrappy version of the locking method that forces schedulers to wait for others' startup
@fw42

Oops. Didn't mean to open this PR in this repo. Will submit again later on :)


RuntimeError: Sizes of tensors must match except in dimension 1. Expected size 1 but got size 2 for tensor number 1 in the list.

Error occurred when executing KSampler:
Sizes of tensors must match except in dimension 1. Expected size 1 but got size 2 for tensor number 1 in the list.
mac m3
help

@nullquant run BrushNet_SDXL_basic.json

Can you please post complete log of error?

Can you please post complete log of error?

Error occurred when executing KSampler:
Sizes of tensors must match except in dimension 1. Expected size 1 but got size 2 for tensor number 1 in the list.
File "/Users/jack/works/StableDiffusion/ComfyUI/execution.py", line 151, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "/Users/jack/works/StableDiffusion/ComfyUI/execution.py", line 81, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "/Users/jack/works/StableDiffusion/ComfyUI/execution.py", line 74, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "/Users/jack/works/StableDiffusion/ComfyUI/nodes.py", line 1344, in sample
return common_ksampler(model, seed, steps, cfg, sampler_name, scheduler, positive, negative, latent_image, denoise=denoise)
File "/Users/jack/works/StableDiffusion/ComfyUI/custom_nodes/ComfyUI-BrushNet/brushnet_nodes.py", line 335, in modified_common_ksampler
samples = comfy.sample.sample(model, noise, steps, cfg, sampler_name, scheduler, positive, negative, latent_image,
File "/Users/jack/works/StableDiffusion/ComfyUI/custom_nodes/ComfyUI-AnimateDiff-Evolved/animatediff/sampling.py", line 279, in motion_sample
return orig_comfy_sample(model, noise, *args, **kwargs)
File "/Users/jack/works/StableDiffusion/ComfyUI/custom_nodes/ComfyUI-Advanced-ControlNet/adv_control/control_reference.py", line 47, in refcn_sample
return orig_comfy_sample(model, *args, **kwargs)
File "/Users/jack/works/StableDiffusion/ComfyUI/custom_nodes/Comfyui-StableSR/nodes.py", line 69, in hook_sample
return original_sample(*args, **kwargs)
File "/Users/jack/works/StableDiffusion/ComfyUI/custom_nodes/ComfyUI-Impact-Pack/modules/impact/sample_error_enhancer.py", line 22, in informative_sample
raise e
File "/Users/jack/works/StableDiffusion/ComfyUI/custom_nodes/ComfyUI-Impact-Pack/modules/impact/sample_error_enhancer.py", line 9, in informative_sample
return original_sample(*args, **kwargs)  # This code helps interpret error messages that occur within exceptions but does not have any impact on other operations.
File "/Users/jack/works/StableDiffusion/ComfyUI/comfy/sample.py", line 37, in sample
samples = sampler.sample(noise, positive, negative, cfg=cfg, latent_image=latent_image, start_step=start_step, last_step=last_step, force_full_denoise=force_full_denoise, denoise_mask=noise_mask, sigmas=sigmas, callback=callback, disable_pbar=disable_pbar, seed=seed)
File "/Users/jack/works/StableDiffusion/ComfyUI/comfy/samplers.py", line 755, in sample
return sample(self.model, noise, positive, negative, cfg, self.device, sampler, sigmas, self.model_options, latent_image=latent_image, denoise_mask=denoise_mask, callback=callback, disable_pbar=disable_pbar, seed=seed)
File "/Users/jack/works/StableDiffusion/ComfyUI/comfy/samplers.py", line 657, in sample
return cfg_guider.sample(noise, latent_image, sampler, sigmas, denoise_mask, callback, disable_pbar, seed)
File "/Users/jack/works/StableDiffusion/ComfyUI/comfy/samplers.py", line 644, in sample
output = self.inner_sample(noise, latent_image, device, sampler, sigmas, denoise_mask, callback, disable_pbar, seed)
File "/Users/jack/works/StableDiffusion/ComfyUI/comfy/samplers.py", line 623, in inner_sample
samples = sampler.sample(self, sigmas, extra_args, callback, noise, latent_image, denoise_mask, disable_pbar)
File "/Users/jack/works/StableDiffusion/ComfyUI/comfy/samplers.py", line 534, in sample
samples = self.sampler_function(model_k, noise, sigmas, extra_args=extra_args, callback=k_callback, disable=disable_pbar, **self.extra_options)
File "/Users/jack/works/StableDiffusion/stable-diffusion-webui/venv/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/Users/jack/works/StableDiffusion/ComfyUI/comfy/k_diffusion/sampling.py", line 701, in sample_dpmpp_2m_sde_gpu
return sample_dpmpp_2m_sde(model, x, sigmas, extra_args=extra_args, callback=callback, disable=disable, eta=eta, s_noise=s_noise, noise_sampler=noise_sampler, solver_type=solver_type)
File "/Users/jack/works/StableDiffusion/stable-diffusion-webui/venv/lib/python3.10/site-packages/torch/utils/contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/Users/jack/works/StableDiffusion/ComfyUI/comfy/k_diffusion/sampling.py", line 613, in sample_dpmpp_2m_sde
denoised = model(x, sigmas[i] * s_in, **extra_args)
File "/Users/jack/works/StableDiffusion/ComfyUI/comfy/samplers.py", line 272, in call
out = self.inner_model(x, sigma, model_options=model_options, seed=seed)
File "/Users/jack/works/StableDiffusion/ComfyUI/comfy/samplers.py", line 610, in call
return self.predict_noise(*args, **kwargs)
File "/Users/jack/works/StableDiffusion/ComfyUI/comfy/samplers.py", line 613, in predict_noise
return sampling_function(self.inner_model, x, timestep, self.conds.get("negative", None), self.conds.get("positive", None), self.cfg, model_options=model_options, seed=seed)
File "/Users/jack/works/StableDiffusion/ComfyUI/comfy/samplers.py", line 258, in sampling_function
out = calc_cond_batch(model, conds, x, timestep, model_options)
File "/Users/jack/works/StableDiffusion/ComfyUI/comfy/samplers.py", line 218, in calc_cond_batch
output = model.apply_model(input_x, timestep, **c).chunk(batch_chunks)
File "/Users/jack/works/StableDiffusion/ComfyUI/comfy/model_base.py", line 97, in apply_model
model_output = self.diffusion_model(xc, t, context=context, control=control, transformer_options=transformer_options, **extra_conds).float()
File "/Users/jack/works/StableDiffusion/stable-diffusion-webui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/Users/jack/works/StableDiffusion/stable-diffusion-webui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/Users/jack/works/StableDiffusion/ComfyUI/custom_nodes/ComfyUI-BrushNet/brushnet_nodes.py", line 413, in forward_patched_by_brushnet
input_samples, mid_sample, output_samples = brushnet_inference(x, timesteps, transformer_options)
File "/Users/jack/works/StableDiffusion/ComfyUI/custom_nodes/ComfyUI-BrushNet/brushnet_nodes.py", line 367, in brushnet_inference
return brushnet(x,
File "/Users/jack/works/StableDiffusion/stable-diffusion-webui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/Users/jack/works/StableDiffusion/stable-diffusion-webui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/Users/jack/works/StableDiffusion/ComfyUI/custom_nodes/ComfyUI-BrushNet/brushnet/brushnet.py", line 823, in forward
brushnet_cond=torch.concat([sample,brushnet_cond],1)

@nullquant  Please take a look at what issue

Okay, check it now, please

Running normally 。。tks


[FLINK-10593][table, cep] Add support for ALL ROWS PER MATCH

What is the purpose of the change
This pull request adds support for ALL ROWS PER MATCH
Brief change log

Changes to use PatternFlatSelectionFunction no matter ONE ROW PER MATCH or ALL ROWS PER MATCH  is used
Add support of ALL ROWS PER MATCH
Add the documentation for ALL ROWS PER MATCH

Verifying this change
This change added tests and can be verified as follows:

Added tests MatchRecognizeITCase#testAllRowsPerMatch

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): ( no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs)

@dawidwys  @twalthr It would be great if you could take a look at this PR when you're available. Thanks in advance.


feat(payouts): implement list and filter APIs

Type of Change

[ ] Bugfix
[x] New feature
[ ] Enhancement
[x] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description
Explained in issue - #3652
Additional Changes

[x] This PR modifies the API contract
[x] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?
Postman collection - https://galactic-capsule-229427.postman.co/workspace/My-Workspace~2b563e0d-bad3-420f-8c0b-0fd5b278a4fe/collection/9906252-a81197fa-a22b-4ff6-a912-42f6c1187591?action=share&creator=9906252
Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed the submitted code
[ ] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

@apoorvdixit88

* Why two APIs, none is JWTAuth based?

Will add this in a separate PR. We need to define payout user roles.
I have resolved other comments.


Rules that trigger "again" end afx transitions

Describe the bug
Rules that trigger "again" end afx transitions
Reproduction Steps

Moving object with a move afx:... effect
A rule that calls "again"

What did you expect would happen?
Expect player to move smoothly, but player moves instantly.
OS & Browser version, desktop/mobile
Browser
Screenshots, example projects, other relevant issues, etc.
Repro save.
author rolopogo

level_select
run_rules_on_level_start
again_interval 0
animate_interval 0.25
verbose_logging

========
OBJECTS
========

player
green

background
black

=======
LEGEND
=======

. = background
p = player

=======
SOUNDS
=======

player move afx:slide

================
COLLISIONLAYERS
================

background
player

======
RULES
======

[moving player] -> again

==============
WINCONDITIONS
==============

=======
LEVELS
=======

section level
.....
.....
..p..
.....
.....```

I think what you're asking for is that the again cycle does not start until the animation is complete. They can't run at the same time.

I fixed it in https://github.com/david-pfx/PuzzleScriptNext/pull/111 by directly reverting the changes made by the dry run.
However, delaying the execution of again seems much more maintainable vs ensuring no changes happen during the dry run of the rules. What would happen when again_interval is less than animation time?

I had in mind to replace line 1455 in inputoutput.js:
        if (timer>againinterval && messagetext == "") {
by
        if (timer>againinterval && messagetext == "" && !isAnimating) {
and see if that fixes it.

Fixed. Same idea as #111 but different place for code.


General lookup table class

Stores a key_row of values which maps to multiple lookup_row values. Can create a lookup tables with any number of rows.
To lookup desired value from row, call lookup function.
Values are passed into the key_row and return interpolated value from the desired row.
Uses linear interpolation to estimate values.
Has optional linear extrapolation for values outside of bounds, otherwise caps value at point value.
TODO:

Write test cases to ensure it works as intended
Implement lookup table classes into shooter and other appropriate components

Looks good, I think we just need some tests now. Cases that come to mind:

Normal interpolation
Lookup at a data point
Linear extrapolation
Constant extrapolation
Zero gradient case
Happy to help if you need a hand writing them.


chore: add .nvmrc to ensure node v18

@Atinux can u review the pr ? i opend many days ago.

Actually it depends of which tool you use for install node, you should use the engines in the package.json, see https://docs.npmjs.com/cli/v9/configuring-npm/package-json#engines

thanks @Atinux . i have added engines. can you check it pls ?


Federation v2 fix attributed fields

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

9 of 9 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 87.681%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
363

Relevant Lines:
414

💛  - Coveralls


Change JUL Logging to SLF4J

Fixes #315.
I tried to map all levels according to https://www.slf4j.org/apidocs/org/slf4j/bridge/SLF4JBridgeHandler.html

Coverage increased (+1.2%) to 81.951% when pulling 0a6653d23e1a2fbe05cc8d38f795197c092d1560 on MALPI:log-to-slf4j into b842b9241f3977f12a31c6563b93806d998a0131 on j-easy:master.

Hi @MALPI
Thank you very much for this PR! I really appreciate your effort!
I added a few comments which are really minor, you did already the hard work 👍
Please do not hesitate also to add your name to the contributors list in the readme.
Just a quick information, the build on windows is ko: https://ci.appveyor.com/project/benas/easy-batch/build/1.0.43
I'm not sure if it is related to your changes, but can you please take a look just in case?
Many thanks upfront!
Kr
Mahmoud

Hi @MALPI
Fantastic! Thank you for all these updates 👍
I've merged your PR which will be part of v5.3. Keep tuned.
Best regards,
Mahmoud

@MALPI I added you to the awesome contributors list 7c83757d56f06712a9526c5b487d8453b7859311 !

When are you planning to release the next iteration?

There is no enough material done for v5.3 yet.. So I'm not sure when to do it.
You can still use the snapshot in the meantime. It's already deployed to maven central with your changes.

Hey @benas can you tell me where exactly I can find the snapshots? Btw it's year since I made the changes what about releasing a bugfix version or something similar?
Best

The latest snapshot can be found in sonatype's snapshot repo: https://oss.sonatype.org/content/repositories/snapshots/org/easybatch/
Sorry for not being active here for a while, I'm currently releasing Easy Random and Easy Rules (planned for April 28th) then I will give Easy Batch the love it deserves.
Thank you for your comprehension!


Process affinities in MPI point-to-point benchmark

Maybe I missed it but you don't seem to explicitly specify the affinity of the Julia processes (i.e. each MPI rank) in the, say, MPI ping pong benchmark (neither here nor in MPIBenchmarks.jl). Do you rely on the job scheduler taking care of that?
In ThreadPinning.jl I have implemented a somewhat similar latency measurement for multithreading and it nicely reveals the socket structure of a Noctua 1 node. On Fugaku, it would be interesting to run the same (both for threads and MPI) and see how the NUMA structure manifests itself.

so that the two processes talk across different nodes

Ah, that makes sense. Somehow thought it was an intra-node benchmark. My bad.

Do you know a Julia-way to pin the processes to the different nodes?

No, and I don't think there is/can be. (Again, I was thinking intra-node and in this case there are a bunch of ways including using ThreadPinning.jl on each MPI rank to pin itself to the desired core based on the rank id, for example)

But it's a bit different from what you got, is this what you'd expect?

Yes, I think so. It nicely shows the four-fold structure due to the 4 NUMA domains (and that intra-NUMA domain is fastest). Perhaps I would have expected a hierarchy of speed levels for inter-NUMA but 1) I would have to look at the physical topology of the chip units and 2) maybe this requires fine-tuning and is overshadowed by the much faster intra-NUMA (which sets the color scale).

Yes, I think so. It nicely shows the four-fold structure due to the 4 NUMA domains (and that intra-NUMA domain is fastest).

To be clear, to count the NUMA regions you're just looking at the low-latency diagonal boxes, right? For some reasons I was initially trying to interpret the off-diagonal boxes, which however have a more complex pattern and in hindsight (and after sleeping) I'm not really sure that makes much sense 😅

To be clear, to count the NUMA regions you're just looking at the low-latency diagonal boxes, right?
Well, you see the four-fold structure not just on the diagonal but also in x and y direction (although less pronounced between off-diagonal blocks). But yes.
Of course, it doesn't tell you that it's NUMA domains. Could, in principle, also be different sockets (like for the Noctua 1 example in the ThreadPinning docs linked above) or something else.

For some reasons I was initially trying to interpret the off-diagonal boxes, which however have a more complex pattern and in hindsight (and after sleeping) I'm not really sure that makes much sense 😅

While diagonal (intra-NUMA) vs off-diagonal (inter-NUMA) is the dominant feature, the off-diagonal boxes are also somewhat interesting. As I said above, one might (or might not) be able to find a minor hierarchy of latencies (essentially asking the question whether all inter-NUMA connections are equal or whether there are subtle differences). But one would probably work much harder and improve the benchmark quality. After all, the output matrix should be symmetric which it isn't (although "almost").