Timestamp embedding in URLs

I am currently not deploying to Netlify but "simply" to GitHub Pages via static rendering previewing locally before commiting.  That strikes me a defensible workflow even if more docs assume one would always push to Netlify.
One downside of the current (still somewhat default) use is that something (the embedded search?) embeds the current-time since epoch in the rendered html.  So there is a lot of spurious change from commit to change.
Is there a way to turn this off?

I understand the use case. You're right it's not ideal but is a nice simple approach to getting the website online.
I think you might be referring to the timestamp after the css, js, etc. files? such as ./css/hugo-theme.css?1542379156 and ./js/search.js?1542379156
Add this under the [params] section of config.toml
disableAssetsBusting = true

Yes that is precisely the issue.
I added the disableAssetsBusting = true and re-ran, for which I use
#!/bin/bash
hugo server --destination docs --renderToDisk

(as docs/ makes it even easier with GH pages) and it added the dreaded timestamps back again in updated values, ie
+    <link href="./css/nucleus.css?1542380680" rel="stylesheet">
+    <link href="./css/fontawesome-all.min.css?1542380680" rel="stylesheet">

and that timestamps is indeed 'now':
R> anytime::anytime(1542380680)    ## an R helper function
[1] "2018-11-16 09:04:40 CST"
R>

And I don't see a 'reopen' button.

Timestamps shouldn't get added if the option is set to true. Is the option within the [params] section in your config.toml?
[params]
  disableAssetsBusting = true

Yup.  Simply indented but that should not matter:
baseURL = "http://dspm.stat430.com"
title = "STAT430 - Data Science Programming Methods - Spring 2019"
theme = "hugo-theme-learn"

copyright = "© 2018 Dirk Eddelbuettel"
enableEmoji = false

footnotereturnlinkcontents = "<sup>^</sup>"
ignoreFiles = ["\\.Rmd$", "\\.Rmarkdown$", "_files$", "_cache$"]
relativeurls = true

# Only use English, no multilingual support
defaultContentLanguage = "en"
defaultContentLanguageInSubdir = false

# code highlighting
pygmentsStyle = "trac"
pygmentsUseClasses = true
pygmentsCodeFences = true
pygmentsCodefencesGuessSyntax = true

# Languages
[languages.en]
  languageCode = "en-us"

# Outputs
[outputs]
  home = [ "HTML", "RSS", "JSON"]
  section = [ "HTML", "RSS" ]
  taxonomy = [ "HTML", "RSS" ]
  taxonomyTerm = [ "HTML", "RSS" ]

# Rendering engine
[blackfriday]
  hrefTargetBlank = true

[params]
  # Change default color scheme with a variant one
  themeVariant = "illinois"

  # Set this to true to disable copy-to-clipboard button for inline code.
  disableInlineCopyToClipBoard = true

  # no JS highlighting
  useHLJS = false

  # help with issue #193 on timestamp
  disableAssetBusting = true

It's pretty vanilla. I mod'ed the theme to fit school colours etc, have the other issue #187 regarding code markup and that's it.  hugo as the binary in Ubuntu 18.04.1, ie package version 0.40.1-1.

Good suggestions.  I see 0.47 in Ubuntu 18.10 and Debian unstable.
Ok, fetched 0.51 from the hugo site, and ran it via /usr/local/bin/hugo with the argument.  And same bad outcome:
+    <link href="./css/nucleus.css?1542382354" rel="stylesheet">
+    <link href="./css/fontawesome-all.min.css?1542382354" rel="stylesheet">

where
R> anytime::anytime(1542382354)
[1] "2018-11-16 09:32:34 CST"
R>

is three minutes when I ran this.
:-/
I can upgrade the theme, it should be reasonably current and I had pulled then (maybe a month ago).

Running with  /usr/local/bin/hugo  server hugo --cleanDestinationDir helps. Let me play some more later to get the destination directory back.  Currently it is not writing anywhere, public/ or docs/.

It seems that as soon as I ask it to write to disk, the seconds-since-epoch timestamp is updated and I have the spurious diff.

I punted and wrote this script to revert timestamps in order to minimize diffs somewhat.
#!/bin/bash

if [ $# -ne 2 ]; then
    echo "Usage: timestampFix.sh from to"
    echo ""
    echo "where 'from' and 'to' are timestamp values"
    exit 1
fi

set -eu

in=${1}
out=${2}

echo -n "Changing ${in} to ${out} ... "
for f in $(find . -name \*.html | xargs grep -l "\?${in}"); do
    sed -i -e "s/?${in}/?${out}/g" ${f}
done
echo "done."

@matalo33 Maybe I was too hasty ... and mistook changes to frameworks (ie chapter title) affecting all pages.  I just made a more local change and lo-and-behold only the relevant pages (plus, for some reason, the 404.html) changed.  I'll keep an eye on it.

Looks like I was wrong, and your disableAssetsBusting = true trick works as expected -- so thanks!
Closing this now.

It's back.  As soon as I relaunch the scripts/runMe.sh I added I get each timestamp remade:
hugo server --destination docs --renderToDisk

I had kept that instant running and serving.  Incremental changes once hugo keeps running are then just to a page but otherwise it clearly does not work too well for batch mode.  Weird.


feat: recursive structure

Adds support for recursive structures. Refactors structure elaboration to pave way for structure appearing in mutual blocks. Improves error reporting.
Example:
structure Tree where
  n : Nat
  children : Fin n → Tree

def Tree.size : Tree → Nat
  | {n, children} => Id.run do
    let mut s := 0
    for h : i in [0 : n] do
      s := s + (children ⟨i, h.2⟩).size
    pure s

Closes #2512

I want to try putting the breaks on this, at least as far as the kernel is concerned. The kernel notion of isStructureLike really needs to imply non-recursive, although it's fine if this is just an elaborator thing. Primitive projections are fine-ish (they are already allowed on some non-structures, although this was the source of a soundness bug in the past), but structure eta is not feasible.

@digama0 This is not touching the kernel. This is just making it possible to use the structure elaborator to define one-constructor inductive types, since it gives convenient notations. Do you still have any objections?

So maybe the title could be “feat: structure syntax in mutual datatype definitions”

@kmill

Something I'm considering is also having inductive register types as being structures in the elaborator when it makes sense to do so, and use mkProjections.

If this feature is added, I would hope it can be toggled. I sometimes uses inductive rather than structure for structure-like types specifically when I don't want the auto-generated projections.

@digama0 This is not touching the kernel. This is just making it possible to use the structure elaborator to define one-constructor inductive types, since it gives convenient notations. Do you still have any objections?

No objections.

@digama0 Isn't the kernel only using is_structure_like for a couple applications of eta? I see just try_eta_struct (used by is_def_eq_core), is_def_eq_unit_like, and to_cnstr_when_structure (used by inductive_reduce_rec). Primitive projections don't use it, and this is why this PR works without making any changes to is_structure_like/isStructureLike. There are still some places that break in the elaborator though because of misuse of isStructureLike.
Notice that I did not change isStructureLike in this PR. It is important for it to reflect the kernel implementation, and you can rest assured that it it will remain that way.


Update README.md

My GitHub username was changed a year or two ago. matthewhesketh -> wrxck

Thanks!


Extend the current automatic test execution to automatically report test coverage on pull requests

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@8ffc461). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #148   +/-   ##
==========================================
  Coverage           ?   87.40%
==========================================
  Files              ?       60
  Lines              ?     2898
  Branches           ?      172
==========================================
  Hits               ?     2533
  Misses             ?      350
  Partials           ?       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ffc461...779d14d. Read the comment docs.

Er det fint den bare har rettet alt der hed .Services til .Repository?

Det var for at det stemte overens med hvad mappen hed.

Er det fint den bare har rettet alt der hed .Services til .Repository?

Det var for at det stemte overens med hvad mappen hed.

?

?

Missclick. Looks fine my guy

?

Missclick. Looks fine my guy

Approve then pls my guy


Sometimes print is not paused

h

i'm testing from an hour, and the plug-in don't stop printing. a pop up appear to advertise me  "filament run out", but the print continues.
the printer don't see the M600 command?
tried on a creality ender 3 with marlin 2.0.7

I think I know what the problem is. Plugin works but print is not paused directly after filament runout. Octorpint tries to finish sent commands or is still sending commands I'm not sure.
I have changed plugin to "Filament Sensor Reloaded" and it works fine...

i didn't modify the configuration file, but i wil try to send a M600 in the terminal to look if it make something

Then the issue is closed?

yes

@Fredlepp  please the issue then :)

it's not me who has create this issue, sorry


Update node and npm

Description
Changes proposed in this pull request:

... and all the packages needed

Now using node v16.13.2 (npm v8.1.2)

Closes #834

/test pre-busola-integration-test-k3s


[Bug] Serve port and hot port conflict on Windows

Operating System: Windows 10
Node Version: v8.11.1
NPM Version: v5.5.1 (yarn v1.6.0)
webpack Version: 4.8.1
webpack-serve Version: 0.3.2

This issue is for a:

[x] bug
[ ] feature request
[ ] modification request

Code
API
const serve = require('webpack-serve')
const compiler = /* our compiler */
serve({
    compiler,
    host,
    port: 8081
})

Expected Behavior
Works well
Actual Behavior
｢serve｣:  { Error: listen EADDRINUSE <IP_ADDRESS>:8081
    at Object._errnoException (util.js:1022:11)
    at _exceptionWithHostPort (util.js:1044:20)
    at Server.setupListenHandle [as _listen2] (net.js:1367:14)
    at listenInCluster (net.js:1408:12)
    at GetAddrInfoReqWrap.doListen [as callback] (net.js:1517:7)

How Do We Reproduce?
It's related to:
https://github.com/webpack-contrib/webpack-serve/blob/c9235b5fc5135257809c15994b84b03088afd211/lib/server.js#L117-L118
If all ports are free, only 8081 port have this error. As those two getPorts will both find port from 8081 and then use the same port.
The core problem is that those two getPorts have the possibility to get a some port and cause conflict

We noticed that at https://github.com/vuejs/vuepress/issues/424

@meteorlxy this isn't a bug - that's the default port for the WebSocket server. If you're choosing to use that as the primary web serve's port as well, then you're configuring this for failure out of the gate. The solution is simply not to do that.

@shellscape
It's possible that, set the primary web serve's port as 8080 our smaller, but from primary web serve's port  to 8080 are all in used, then the first getPort will choose 8081 and cause this error, too.
I think we could make it cleverer to avoid it.


Teleport with air tap

I'm using the teleport system with Hololens2.
I'd like to teleport using air tap.
How can I show the the teleport pointer  when the hand is in the poke gesture for example?
thanks

Hi @sonostrano, we don't have a great story for Hololens and teleport right now. Generally, using teleportation (or locomotion) at all in AR is mostly discouraged, as it doesn't make for a very good user experience. There is no "floor" object/height in Hololens, which makes teleportation-based locomotion tricky, and breaking the connection between the in-experience reference frame and the user's real-world reference frame can reduce the immersiveness of the experience.
However, if you do need to move holograms towards the user (i.e., what locomotion in this context would probably be used for), you can create a root parent object and have your scene content as children of this root pivot. By moving the pivot around, you can allow the user to bring content towards them.
If this doesn't solve your needs, please reopen this and we will get back to you!


Stats

#12
Initial amp stat command implementation (based on proposal here).
Only cpu for now as decided
Not implemented
--time-unit
--status and --health (requires amp-agent/etcd)
current data (not historic)
Verification
$ amp stats --cpu --container --service-name=kafka  --period 5m
Should display cpu metrics of all containers for the kafka service, for the last 5 miutes
$ amp stats --cpu --node --period 5m
Should display cpu metrics for all nodes, for the last 5 minutes

@freignat91 and @chrisccoy I just rebased with master and force pushed. Make sure you perform the following steps on your local branch:
$ git fetch origin stats
$ git reset --hard origin/stats

I just formatted the source and squashed commits. I'm going to go ahead and merge this even though it's a work in progress to make it easier to coordinate project-wide CLI restructuring.


New text rendering engine distorts font (it looks horrible)

Windows Terminal version
1.21.2911.0
Windows build number
10.0.22631.4317
Other Software
No response
Steps to reproduce
Use the (default) Cascadia Mono font (size 12) and compare the appearance of text in the terminal between the old renderer (possible to still use in versions prior to 1.21) and the new renderer.
I mostly use 2560x1440 display resolution but this happens on any display resolution with Windows' rendering scale set to default 100%.
(Option to use the old renderer was removed in 1.21.2361.0 as per the release notes.)
(I was still using the option to use the old renderer and now the option to use it is gone. I'm assuming the reason is that 1.21 was recently pushed to all users, including me. I don't know exactly on what version I was before; I was hit by the changed rendering on Oct 25th and then noticed I had 1.21 and the old option was gone.)
Expected Behavior
Expecting to see the same well-proportioned font as before (and not this vertically elongated abnormity).
Actual Behavior
The new engine renders the font differently. Most noticeably tall characters (e.g. capital letters, numbers, lowercase L, etc.) are vertically elongated (pixel or two taller than before), distorting the font proportions. The font also looks generally thicker.
New renderer (1.21, distorted font):

Old renderer (preferred):

The most noticeable difference in the above attached screenshots are the numbers, especially the zeros, and the capital A letter.
Other changes are a lot easier to notice when comparing the images in-place one after the other (center them on full screen with 100% image scale and hit arrows or some other key to switch between them).
For some, this may seem like a minuscule problem but for me this is a big deal. I look at the terminal a lot and a change like this is distracting. The new taller and thicker rendering is more "restless" to me.

Confirmed at 1920x1080 resolution in 1.21.2911.0 too.

Can you try and decrease your font size ever so slightly by 0.1 steps until the appearance changes? E.g. something like 11.5?

I don't use Cascadia Mono as my terminal font. But I'm seeing rendering problems with it in other places. The problem may be the font, not WT.
I have both VS 2017 and VS 2022 installed on my laptop, and I updated both of them on Friday. Today (Monday) I noticed that VS and VS Code both looked wrong. I suspect one of the VS updates broke it.
It looks to me like all the font weight variants of Cascadia Mono are rendering as ExtraLight.

FWIW, the difference in your screenshots just looks like hinting.
Fonts often contain instructions on how to snap to crisp pixel boundaries at specific point sizes. Those instructions are designed to reduce blurriness when presented at 100% scale on LCD monitors from before the industrial era. :)
For comparison, this is what ExtraLight actually looks like (150% scale)

cf. Regular

This is what ExtraLight looks like at 100% scale:

I do not think that you are seeing ExtraLight. Just properly-hinted Regular. You can bust the hinting by using a fractional font size (as Leonard points out, but with more explanation.)

(I have also de-editorialized your title.)

I've just had a chance to test this and a font size of 11.5 indeed restores the look of the previous text renderer. I've updated my comment above accordingly. Please give it a try and let us know if that works for you!
As an aside, I strongly recommend enabling ClearType (unless you dislike it). You can enable it in the settings when you click on the "Defaults" profile, then on "Advanced" at the bottom. The second item will be "Text antialiasing". If you set it to ClearType, it'll significantly improve the text clarity. I've been meaning to make it the default on low-DPI displays but haven't gotten to it yet.
What DHowett said above matches my understanding of how DirectWrite works. In the old text renderer when you'd ask for a font size of 12, you'd actually get 11.749232428 or some other fractional number due to workarounds that aren't relevant anymore. The new text renderer on the other hand will render the text at the exact font size you tell it. This is the reason why I don't want to change the behavior, even though I fully get what you mean.
But... I think we can take another potential solution from this issue: We currently unconditionally enable hinting for text rendering and disable vertical anti-aliasing (this is the default under Windows for small font sizes). It would be very easy for us to add a "disable hinting" setting (= DWRITE_RENDERING_MODE_OUTLINE) and a "enable vertical AA" setting (= DWRITE_RENDERING_MODE_NATURAL_SYMMETRIC). The former would solve your issue similar to using the 11.5 font size. It would also have the benefit that text will be rendered just like on MacOS/iOS. I feel like we already have an issue for that somewhere though...

Looks like changing the font size to 11.5 works.
Thank you!
I'm using Fira Mono.
12

11.5

I don't use Cascadia Mono as my terminal font. But I'm seeing rendering problems with it in other places. The problem may be the font, not WT.
I have both VS 2017 and VS 2022 installed on my laptop, and I updated both of them on Friday. Today (Monday) I noticed that VS and VS Code both looked wrong. I suspect one of the VS updates broke it.
It looks to me like all the font weight variants of Cascadia Mono are rendering as ExtraLight.

I noticed my problem already in March 1st 2024, when the default option for renderer was changed to the new renderer.
(Back then I found the option for old renderer and it solved my problems. I did not have time to make an issue about it, sorry, and I did not expect the option for the old renderer to disappear.)

(I have also de-editorialized your title.)

That's ok, the old title was a little unprosessional anyway but it seems to have served it's purpose, hehe. 😁 Thanks for the fast responses, I really appreciate them!
I understand that the new renderer is probably better in many aspects and it is preferred. So the new title is only partially true (for me).
I have really enjoyed the Terminal and it looked just lovely. I just don't like how the font changed.

As an aside, I strongly recommend enabling ClearType (unless you dislike it). You can enable it in the settings when you click on the "Defaults" profile, then on "Advanced" at the bottom. The second item will be "Text antialiasing". If you set it to ClearType, it'll significantly improve the text clarity. I've been meaning to make it the default on low-DPI displays but haven't gotten to it yet.

I enabled ClearType in the Settings of WT and did not notice any difference. The text in WT looks sharp and clear with both ClearType and Grayscale.
(I do have ClearType enabled in Windows already, I dunno if this affects it.)
(Also, the screenshots I posted look a bit blurry when viewed in this page. When viewed separately with 100% image scale they look sharp. However, AFAIK ClearType only affects how the display shows pixels on the screen so it should not affect screenshots?)

I've just had a chance to test this and a font size of 11.5 indeed restores the look of the previous text renderer. I've updated my comment above accordingly. Please give it a try and let us know if that works for you!

I did not know fractional font sizes were supported. (The Settings won't let me enter 11.5, which I had tried before.) Now I found out it can be changed in the settings.json.
I tried 11.5pt and it indeed works, thanks! (That is, the font looks now the same as with the old renderer and 12pt in the settings.)
I tried also 11.6pt and the result was identical to 11.5pt. Also, 11.7pt looked the same as 12.0pt (bad).
Here are some screenshots:
New renderer (v1.21) with 12.0pt in settings.json: (BAD)

New renderer (v1.21) with 11.5pt in settings.json: (GOOD)

Old renderer with 12pt in Settings: (GOOD)

I do not think that you are seeing ExtraLight. Just properly-hinted Regular. You can bust the hinting by using a fractional font size (as Leonard points out, but with more explanation.)

Does this mean that I actually prefer the unhinted 11.5pt version of the font, and it is the properly-hinted 12.0pt that is giving me gray hair?

I have heard of hinting, mostly in the context of LaTeX and there it usually resulted in better appearance and usually not the whole looks of the font changing. (Although poorly hinted fonts were known to have issues.)

LaTex does not use hinting - that's the job of your PDF viewer or printer. You may be thinking of "kerning", e.g. via the microtype package, which makes the letter spacing more uniform.

However, AFAIK ClearType only affects how the display shows pixels on the screen so it should not affect screenshots? Is this true?

ClearType will affect screenshots as well. You can recognize it by the red/blue shift on the edges (these are screenshots taken directly from Windows Terminal):

I did not know fractional font sizes were supported. (The Settings won't let me enter 11.5, which I had tried before.)

It should just work:

I tried also 11.6pt and the result was identical to 11.5pt. Also, 11.7pt looked the same as 12.0pt (bad).

DirectWrite uses pixel snapping and has no vertical anti-aliasing and so there's only a limited amount of decimal precision during rendering. But even if the appearance doesn't change in an obvious way, the font size still affects numerous other things, like the cell width and line height.

There is still maybe some tiny difference with line spacing but it doesn't matter. :)

Below the font size setting is a "Line height" setting. Try changing it to something around 1.2.

Does this mean that all this time I actually preferred the unhinted 11.5pt version of the font, and it is the properly-hinted 12.0pt that is now giving me gray hair?

I did some more tests. It took a while because I need to pull out Microsoft Visual TrueType for that as well as the old text renderer. 😅 In your particular case it's not actually because hinting got circumvented, but rather because 11.5 happens to trigger DirectWrite to rasterize the glyph at 11pt, while it just so happened to trigger the old text renderer to draw the line height as if it was 12pt (due to fractional rounding). Roughly the same thing happens with the new text renderer but at 11.5pt.
Put differently, you liked the appearance of 11pt Cascadia Mono with an increased line height. 🙂

LaTex does not use hinting - that's the job of your PDF viewer or printer. You may be thinking of "kerning", e.g. via the microtype package, which makes the letter spacing more uniform.

Ah yes, you are correct. I meant that LaTeX distributions usually come with some font packages, and some of the fonts had better hinting than others which is then visible in the produced pdf file.

ClearType will affect screenshots as well. You can recognize it by the red/blue shift on the edges

Thanks for correcting this!

I did not know fractional font sizes were supported. (The Settings won't let me enter 11.5, which I had tried before.)
It should just work:

I guess there is (another) funny little bug: when the Settings show the default value, it shows it with a decimal point. But if I want to use a fractional value it only accepts the input with a decimal comma (probably due to my locale settings, we use a decimal comma around here).

Below the font size setting is a "Line height" setting. Try changing it to something around 1.2.

Now that I could successfully change it (because of the comma/period thing), it looks like font size 11.0 with line height ~1.27--1.32 gives the look I want. Same with font size 11.6 and line height 1.2. (Font size 11.0--11.5 and line height 1.2 gives tighter line spacing, and font size 11.7 gives the 12pt font which I apparently hate :D)

I did some more tests. It took a while because I need to pull out Microsoft Visual TrueType for that as well as the old text renderer. 😅 In your particular case it's not actually because hinting got circumvented, but rather because 11.5 happens to trigger DirectWrite to rasterize the glyph at 11pt, while it just so happened to trigger the old text renderer to draw the line height as if it was 12pt (due to fractional rounding). Roughly the same thing happens with the new text renderer but at 11.5pt. Put differently, you liked the appearance of 11pt Cascadia Mono with an increased line height. 🙂

Thanks for your efforts, this really helped! :)

Glad it worked! Closing!


Added test to check if names are not duplicate

Awesome! thanks
merged #40

Thanks for merging :)
Can I also take a look at this issue?

Test all language codes against a ISO-639-3 language codes, to make sure they all valid

I was thinking of adding this npm package to get all the ISO-639-3 language codes. This would make it easier to maintain and extensible.
Do you think this is a good idea or would it be better to keep the static data and not use any external dependencies?

I think it's a great idea, can't wait to merge it. :)


refactor: skip mkExpectedTypeHint in replaceTargetEq

Looking at the proof terms produced by rewrite I noticed an extra id
call without further explanation. I’m trying to find out whether

It’s strictly needed to help the type checker (in which case I’d like
to add a test case).
It’s not strictly needed, but helps with performance (in which case
I’ll add a comment)
Turns out to be not needed and maybe even has a measurable
performance hit (in which case maybe it should be removed).

Mathlib builds, and the bench results at http://speed.lean-fro.org/mathlib4/compare/ed8d927b-e006-4c9b-a660-00049b15865c/to/41aeb673-3fe0-4471-afe0-69e16f6f4225 are mostly green (-0.754 % smaller oleans, -0.3% build wall-time/instructions).
So maybe this mkExpectedTypeHint is not that useful?

Discussed this with Leo and learned that while it’s not always possible to give hard evidence for why these type hints are absolutely needed, it’s probably better to be conservative here and leave it in, at least unless we have evidence that they hurt.


TODO List

[x] Add a readme with usage instructions
[x] Use reflection to deserialize queue messages (if possible)
[x] Better testing
[x] Example file
More clever-er name?

Reflection to deserialize is both ugly and not very go-like. The string should be fine for now


Make mandelbrot set use latest bussin x terminology, update some code stuff, add len(string)

Also, probably need some updates for the readme for fs and fetch, along with bussin x transcription


Add time factor adjustment for debug testing

Allow the consumer to adjust what a day means in real time. For instance if I have the cool down set to 7 days but I want to test I would be able to set 1 day to 1 minute or something like that to allow for easy event testing.

Actually allowing a dilation would be pretty invasive; that dilation would need to be passed into individual event checks, as well as into the application checks manager. How do you feel rewriting all time-based methods to be based on seconds instead? Then debug testing would look something like
AmplifyStateTracker.get(this)
        .setInstallTimeCooldownSeconds(BuildConfig.DEBUG ? 30 : TimeUnit.DAYS.toSeconds(7))
        .trackLastEventTime(AmplifyViewEvent.USER_GAVE_CRITICAL_FEEDBACK,
                new CooldownSecondsCheck(BuildConfig.DEBUG ? 30 : TimeUnit.DAYS.toSeconds(7)));

I thought about allowing both seconds-based and days-based methods, but they you'd need to calling different configuration methods in debug vs release modes...
Thoughts @btkelly ?

Alternatively, leave everything in days but allow fractional input; then we'd have something like
AmplifyStateTracker.get(this)
        .setInstallTimeCooldownDays(BuildConfig.DEBUG ? TimeUnit.SECONDS.toDays(30) : 7)
        .trackLastEventTime(AmplifyViewEvent.USER_GAVE_CRITICAL_FEEDBACK,
                new CooldownDaysCheck(BuildConfig.DEBUG ? TimeUnit.SECONDS.toDays(30) : 7));

I think I like that better.

Not bad, I wonder if debug mode should set a prefix on all keys as well. Just to make sure the adjusted timings don't get screwed up by setting debug vs production.

Hmm, but both those suggestions mess up configureWithDefaults...

Good thought r.e. debug prefix! Will think on that.


pythonPackages.tess: init at unstable-2019-05-07

Motivation for this change
Used Tess for some graduate work a few years ago.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build pythonPackages.tess

Tested locally on NixOS and Darwin
Thanks!


Improve createProps perf

Before
├─ createProps#empty: 575K iterations/s ±1.46%
├─ createProps#realWorld: 417K iterations/s ±6.83%
After
├─ createProps#empty: 6.01M iterations/s ±1.98%
├─ createProps#realWorld: 1.94M iterations/s ±2.27%
Change List

Use Symbol instead of Object.defineProperties for props' non-enumerable fields
Add deprecation warning/fallback to setters on the props prototype, instead of checking with for loop
Bench tests

Coverage increased (+2.4%) to 83.089% when pulling 9219e8298c15b80d99fd908b685670eda62c0f0f on x/props-perf into 80b23c254e7dcfeaed81e42fea42948298b0cc7d on master.

I wasn't aware that symbols had such a perf advantage.

Object.defineProperties is apparently much slower than direct assignment, not mentioning the re-creation of property definition objects.

Do we feel that we have sufficient test coverage to catch regressions here?

lifecycle/*.js has ~97% test coverage, and its usage in all layers is tested by automated layer tests.


the problem of cli

os: centos 5.5
use 9.0.1 rpm to install
/opt/influxdb.influx in cli
i can do use mydb and  select * from cpu it is right.
but use select * from cpu immediately, and not use database. return ERR: Get http://localhost:8086/query?db=&q=select+%2A+from+cpu: EOF . and the server will shut down . i think it is too week.

Duplicate of #3112 which was closed. If you can reproduce this with 0.9.1 please show the direct CLI output.

Fresh Ubuntu box with brand new InfluxDB install doesn't panic when selecting a non-existent measurement, whether or not a non-existent database is already selected, or even if the database does exist:
root@sean3:~# sudo dpkg -i influxdb_0.9.1_amd64.deb
Selecting previously unselected package influxdb.
(Reading database ... 86964 files and directories currently installed.)
Preparing to unpack influxdb_0.9.1_amd64.deb ...
Unpacking influxdb (0.9.1) ...
Setting up influxdb (0.9.1) ...
 Removing any system startup links for /etc/init.d/influxdb ...
 Adding system startup for /etc/init.d/influxdb ...
   /etc/rc0.d/K20influxdb -> ../init.d/influxdb
   /etc/rc1.d/K20influxdb -> ../init.d/influxdb
   /etc/rc6.d/K20influxdb -> ../init.d/influxdb
   /etc/rc2.d/S20influxdb -> ../init.d/influxdb
   /etc/rc3.d/S20influxdb -> ../init.d/influxdb
   /etc/rc4.d/S20influxdb -> ../init.d/influxdb
   /etc/rc5.d/S20influxdb -> ../init.d/influxdb
root@sean3:~# /etc/init.d/influxdb start
Starting the process influxd [ OK ]
influxd process was started [ OK ]
root@sean3:~# /opt/influxdb/influx
Connected to http://localhost:8086 version 0.9.1
InfluxDB shell 0.9.1
> select * from foo
ERR: database name required
Warning: It is possible this error is due to not setting a database.
Please set a database with the command "use <database>".
> use mydb
Using database mydb
> select * from foo
ERR: database not found: mydb
> create database mydb
> select * from foo
ERR: measurement not found: "mydb"..foo
>

···
Linux version 2.6.32-220.23.2.ali927.el5.x86_64<EMAIL_ADDRESS>(gcc version 4.1.2 20080704 (Red Hat 4.1.2-50)) #1 SMP Mon Jan 28 14:57:06 CST 2013
/opt/influxdb/influx
Connected to http://localhost:8086 version FIXME
InfluxDB shell 0.9.0

select * from mydb
ERR: Get http://localhost:8086/query?db=&q=select+*+from+mydb: EOF
select * from mydb
ERR: Get http://localhost:8086/query?db=&q=select+*+from+mydb: dial tcp <IP_ADDRESS>:8086: connection refused
···

@kcrosswind You are running an older version. Please upgrade to 0.9.1 or newer. This is a known bug that has been fixed.


security fix, WS-2019-0037

weird syslog-ng bug. might be related to 18.04 upgrade:
[2019-05-24T04:05:05.122Z] [<IP_ADDRESS>] out: [ERROR   ] Command '['systemd-run', '--scope', 'systemctl', 'start', 'syslog-ng.service']' failed with return code: 1
[2019-05-24T04:05:05.122Z] [<IP_ADDRESS>] out: [ERROR   ] stderr: Running scope as unit: run-ra6cbfc8757d44e4898522b9c02411d2b.scope
[2019-05-24T04:05:05.122Z] [<IP_ADDRESS>] out: Job for syslog-ng.service failed because the control process exited with error code.
[2019-05-24T04:05:05.122Z] [<IP_ADDRESS>] out: See "systemctl status syslog-ng.service" and "journalctl -xe" for details.
[2019-05-24T04:05:05.122Z] [<IP_ADDRESS>] out: [ERROR   ] retcode: 1
[2019-05-24T04:05:05.122Z] [<IP_ADDRESS>] out: [ERROR   ] Job for syslog-ng.service failed because the control process exited with error code.
[2019-05-24T04:05:05.122Z] [<IP_ADDRESS>] out: See "systemctl status syslog-ng.service" and "journalctl -xe" for details.

investigating ...


GitHub Actions: for now, comment out the ${{ runner.arch }} line

We need https://github.com/julia-actions/setup-julia/pull/108 and https://github.com/julia-actions/setup-julia/pull/110 before we can uncomment this line.

bors merge


Add a histogram for tcp events based on Event type

Motivation
To better understand what is going on in SnarkOS TCP land, it may be beneficial to create a histogram (1 metric in Prometheus) that shows count and sum in bytes of each Event Message type, so this PR adds one called snarkos_tcp_gateway_messages_received, with dynamic labeling based on the event name, in the Decoder impl of the EventCodec. I am using the basic metrics rust crate to call the histogram macro, however it appears that in SnarkVM this functionality is overridden by the implementation of the snarkVM metrics crate, so I figured the easiest thing to do was to just add an alias for the default crate.
Note, the histogram! macro used currently only needs to be called once, so we don't need to register the metrics in /node/metrics/src/names.rs, which might be worth revisiting at a later date.
Test Plan
Run on local devnets

closing this in favor of https://github.com/AleoHQ/snarkOS/pull/3097


akita/cli barrel circular dependency

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[x] Support request
[ ] Other... Please describe:

Current behavior
Because of the barrel index files, I always get circular dependency warnings at compile time. Example:

movies/state/index.ts imports movies/state/movies.service.ts
The latter imports actors/state/actor.model.ts via barrel actors/state/index.ts
actors/state/index.ts imports actors/state/actors.query.ts
The latter imports movies/state/movies.query.ts via barrel movies/state/index.ts
Three circular dependency warnings 😞

Such cases are unfortunately very common and the barrel files create more unconviniences than they help.  Do you just remove the barrel? Thanks!
PS. Are the missing line breaks around providedIn: 'root' in the CLI for Store intentional?
PPS. Is there a slack/gitter room for asking such small questions?

We consider removing the barrel file. We are going to release Angular schematics support and will not include it.

Are the missing line breaks

Not sure what you mean.

Is there a slack/gitter room

We'll open soon, meantime you can ask here.

The entity-store.tpl contains @Injectable({ providedIn: 'root' }) whereas in other services and also in the Angular docs @Injectable({ providedIn: 'root' })

One line makes the code shorter.

Agree. Then it would make sense to have it also in one line in the Query and Service templates 😊


Fix error when running npm start

Webpack was failing to compile when running npm start. The error was being caused by an arrow function class property in a component. Class properties are stage-2, so I added babel-plugin-transform-class-properties to dev dependencies.
I also went ahead and upgraded babel-preset-react-app which removes the following deprecated warning
npm WARN deprecated<EMAIL_ADDRESS>💥  preset-latest accomplishes the same task as babel-preset-env. 🙏  Please install it with 'npm install babel-preset-env --save-dev'. '{ "presets": ["latest"] }' to '{ "presets": ["env"] }'. For more info, please check the docs: http://babeljs.io/docs/plugins/preset-env 👌. And let us know how you're liking Babel at @babeljs on 🐦

Sorry, that was my bad. I have put in a PR to just get rid of the syntax as it's a 1 line change: https://github.com/reactstrap/reactstrap/pull/371

@balloob no problem


Memory leak suspect in BasicMonitorRegistry

Hi,
I'm running Neflix Zuul in Docker on Kubernetes. Once in a few days Zuul restarts on kubernetes due an out of memory. An analysis shows that its the Set of monitors in the com.netflix.servo.BasicMonitorRegistry that is growing. I really have no clue how this can grow.
Specs:
Spring cloud starter Zuul 1.3.1 in Spring Cloud version Dalston.SR1
Spring boot version 1.5.3
Spring cloud netflix core version: 1.3.1
Heap dump analysis shows the following:

Diving deeper:

And even deeper:

Any idea how this can happen?  I can send you the heapdump on request (+300Mb).

My guess something is just registering a lot of monitors. If you dump the contents of the registry does anything stand out?

Thanks for answering. Yesterday I disabled Servo with  -Dspring.metrics.servo.enabled=false. That seems to be working. No memory leak now. This morning I enabled it again in production to see what kind of monitors are registered with /manage/metrics. I made a snapshot and will compare this with the result after a few days. I'll keep you posted.

After one day running on production, the metrics shown in /manage/metrics is not increasing substantially. I got 133 metrices. Memory usage is increasing, so it looks like the memory leak is happening again.

Did some more investigation on the content of the hashmap that is growing. The hashmap is showing 1.2 million instances of AtomicLong:

Following this AtomicLong Reference shows each time this trace:

So it looks like it has something to do with the use of Netflix Eureka in Zuul.

I faced a similar issue with Servo on a long duration load test. Heap dumps showed that it primarily had the metrics from List in updateImpl() we were sending via the observer that was long delivered but still in heap. Added a finally block to explicitly nullify the List and other local objects created in the updateImpl method of the observer which seemed to help with those objects getting garbage collected

Thanks @hxs8839 for your comment. I finally removed Netflix Eureka(was planned) and the problem is gone now. I now use the kubernetes dns with loadbalancer to find my services. I don't have the time to investigate the combination Netflix Servo and Netflix Eureka and why its causing problems.

@hxs8839 based on the memory profiles included in this ticket that sounds like a different problem. Feel free to submit a PR if you think it would help.
Looking at NamedConnectionPool in Eureka and the memory profiles above, it looks like something is creating NamedConnectionPool instances and not unregistering.

@brharrington agreed. Yeah I made the change for my custom observer, Working on if we can generalize it

@brharrington. I'm not in the position right to spend a lot of time on this. Hopefully somebody else can profit from this. Thanks anyway.

@marckamerbeek  please look at : https://github.com/spring-cloud/spring-cloud-netflix/issues/947

i have same problem

hashmap has too many key

version: com.netflix.servo:servo-core:0.10.1  by SpringBoot Dalston.SR4

See the linked spring ticket (spring-cloud/spring-cloud-netflix#947), it seems like a bug in how spring is registering metrics.

@brharrington  #947 not a prefect solution,  sometime our api-gateway don't konw how many queryparm in url, so the code will be
 this.restTemplate.postForEntity(url + "?" + requestVo.getQueryString(), formEntity, String.class).getBody()
RestTemplate has no dynamic queryparm method, if use urlBuilder then question begin again


Add neutron rx/tx and disk io + vogue

What it says on the box.
Also vogues a few files.

I know it's just the same as cpu, but can you add tests?

roger

Yeah, looks good pending tests.

also I don't see the definition for valDiskReads etc. in Tags?

You had already defined the required tags, I just added in the supporting types.

cool. What happened to travis anyway? Shouldn't it be reporting here?

Travis should indeed be reporting here, unsure why it isn't. Either way travis build now passes: https://travis-ci.org/anchor/ceilometer-common


Clarification required for some Important statements on the page.

This statement has very broad context and isnt clear:
Statement: Instances of certain Azure services including Azure DevOps Services are currently unable to access the container registry.
More clarification required on these points:

Does this statement apply when public access to registry is blocked? Or in general?
Does this apply to self hosted agents of Azure Devops or also to the managed agents in Azure

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8e01945a-5892-a416-716f-c499f110586c
Version Independent ID: e2aef346-266f-3e69-842d-58004084609b
Content: Set up private endpoint with private link - Azure Container Registry
Content Source: articles/container-registry/container-registry-private-link.md
Service: container-registry
GitHub Login: @tejaswikolli-web
Microsoft Alias: tejaswikolli

@Tarvinder91
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@tejaswikolli-web
Can you please check and add your comments on this doc update request as applicable.

@tejaswikolli-web here are some clarifications:
"Does this statement apply when public access to registry is blocked? Or in general?"
This statement applies once public network access to the registry is disabled.
"Does this apply to self hosted agents of Azure Devops or also to the managed agents in Azure."
This applies to both managed and self-hosted agents in Azure DevOps. Managed agents cannot be linked to a user VNET, therefore they cannot access a registry over the private endpoint. Private endpoints are not currently supported with self-hosted agents on Azure DevOps, including standalone VMs, VMSS or function apps in user VNETs. cc @northtyphoon

Added clarification to the doc.
https://github.com/MicrosoftDocs/azure-docs-pr/pull/205876
#please-close

@jaysterp can you point me to where "Private endpoints are not currently supported with self-hosted agents on Azure DevOps, including standalone VMs, VMSS or function apps in user VNETs" is mentioned somewhere in our public docs?
I am not sure whether this is a restriction on self-hosted agents. So wondering if we mention this somewhere. I am not finding anything back on this in the DevOps docs.

Hello, stumbled upon this question when I was looking for some information in setting up Private endpoints for ACR. Came across this documentation here - https://learn.microsoft.com/en-us/azure/container-registry/container-registry-private-link
which mentions "Private endpoints are not currently supported with both self-hosted agents and managed agents."
Does that mean, if we use our own agentpools hosted in a VNET using VMSS, those agents won't be able to access private endpoints in the case of ACR?

@vermegi @haripraghash thanks for reaching out. This statement should have said "Microsoft-hosted agents" instead of "self-hosted agents". Microsoft-hosted agents will not have access to an ACR over private endpoint since requests to the registry are made over public network. As long as the self-hosted agent is added to the VNET with a private link to the ACR, then the pipeline can access the registry over private endpoint. @tejaswikolli-web please update the doc to fix this statement.

https://github.com/MicrosoftDocs/azure-docs-pr/pull/224979

Change was merged. All good!


Handle undefined workspace folders

What problem did you solve?
Close #366
Currently, when user starts an R session with session watcher init, it writes attach request to the global ~/.vscode-R/request.log, and vscode-R checks if the working directory of that R session is identical to or child of any of the workspace folders.
However, when VSCode has no workspace folder open, then workspace.workspaceFolders is undefined, and R session started always does not attach. This PR makes isFromWorkspace handle this case so that attach requests from home folder is accepted so that session watcher could work with no folder open.
We only attach R session started from home folder because if it allows all sessions to attach, then if multiple VSCode is started on the the same machine with different workspace folders, then a VSCode with no folder open will respond to all requests from different workspace folders, which could be messy and useless.
(If you do not have screenshot) How can I check this pull request?

Open VSCode without a folder open.
Open an R script to activate the extension.
Start an R session with session watcher enabled.
Check if the session watcher is attached by looking at the pid in status bar item.
Change terminal folder (e.g. cd ~/.vscode-R), and start R again.
The session is not attached since it is not started from home folder.

LGTM, Thank you and the change is clean!


[parseh.cpp] fix the memory leak

Greetings @andrewrk & co, on line number 1041 of 'parseh.cpp' there is a memory leak, which is an error. The reason we should free is that memory is a finite resource within our running programs. Sure in very short running simple programs, failing to free memory won't have a noticeable effect. However on long running programs, failing to free memory means we will be consuming a finite resource without replenishing it. Eventually it will run out and our program will abruptly crash. This is why we must free memory.

I'll be amazed if this is the only memory leak you find. Currently the zig compiler does not free any memory, instead relying on the OS to free the entire process memory when the compiler exits.
This is not the long term strategy, but rather a simplification used to help maintain development speed as the compiler is in the research phase.
Current plan is to eventually rewrite the compiler in zig itself (the self hosting process) which will include some refactoring and improvements such as better memory management.
I'll merge this but I recommend not wasting your time looking for memory leaks quite yet.

Actually on second thought, I will not merge this because it doesn't actually free element_types in every circumstance, and having a free call would trick my future self or another code reader into thinking that the memory was freed correctly in all cases, which would be an incorrect conclusion.
I think it's going to be better to have no frees at all until such time as described above.

I do appreciate these kind of pull requests but I think they may be a bit premature. Could I ping you when a release candidate is available?

Yes, please ping me. It'll be my reminder to sync my fork of your repository to keep it up-to-date with the upstream repository.
Your assertion that the free doesn't cover every circumstance is on the money. For what it's worth (FWIW), there are only a few other cases in which cppcheck found memory leaks, so I'll include the complete list in a moment. It's also worth noting that the list I'm about to include is all that remains in terms of bugs found by cppcheck. Cheers.
poda124-14-08:~ public002$ git clone https://github.com/andrewrk/zig
poda124-14-08:~ public002$ cd zig/
poda124-14-08:zig public002$ ../cppcheck/cppcheck . | grep -i "(error)"
[src/analyze.cpp:1541]: (error) Memory leak: element_types
[src/analyze.cpp:2607]: (error) Memory leak: field_use_counts
[src/analyze.cpp:6232]: (error) Memory leak: peer_nodes
[src/analyze.cpp:6232]: (error) Memory leak: peer_types
[src/analyze.cpp:6232]: (error) Memory leak: field_use_counts
[src/parseh.cpp:1041]: (error) Memory leak: element_types
poda124-14-08:zig public002$


glTexture.cpp:360 [cuda]unknown error

@dusty-nv
hi dusty, I'm trying to test my jetson-inference using command
./imagenet.py images/orange_0.jpg images/test/output_0.jpg
the error turns out like
glDisplay video options:
------------------------------------------------
  -- URI: display://0
     - protocol:  display
     - location:  0
  -- deviceType: display
  -- ioType:     output
  -- codec:      raw
  -- width:      1920
  -- height:     1080
  -- frameRate:  0.000000
  -- bitRate:    0
  -- numBuffers: 4
  -- zeroCopy:   true
  -- flipMethod: none
  -- loop:       0
  -- rtspLatency 2000
------------------------------------------------
[image] loaded 'images/orange_0.jpg'  (1024x683, 3 channels)
class 0950 - 0.966309  (orange)
[OpenGL] glDisplay -- set the window size to 1024x683
[OpenGL] creating 1024x683 texture (GL_RGB8 format, 2098176 bytes)
[cuda]      unknown error (error 999) (hex 0x3E7)
[cuda]      /home/hazeee/jetson-inference/utils/display/glTexture.cpp:360
[image] saved 'images/test/output_0.jpg'  (1024x683, 3 channels)

[TRT]    ------------------------------------------------
[TRT]    Timing Report networks/bvlc_googlenet.caffemodel
[TRT]    ------------------------------------------------
[TRT]    Pre-Process   CPU   0.01483ms  CUDA   0.30925ms
[TRT]    Network       CPU   7.42990ms  CUDA   7.06483ms
[TRT]    Post-Process  CPU   0.01944ms  CUDA   0.02016ms
[TRT]    Total         CPU   7.46416ms  CUDA   7.39424ms
[TRT]    ------------------------------------------------

the output picture was saved well but the display windows which was black just flashed and was close immediately.
Thanks very much for your time!I appreciate it
Besides:
my pc is x86_64 non-jetson
cuda10.2 cudnn 8.2.x tensorRT <IP_ADDRESS>
if you need more information please tell me, thanks~

I was alse trying to test jetson inference using cmd
./imagenet --network=resnet-18 jellyfish.mkv images/test/jellyfish_resnet18.mkv
the error is here
[gstreamer] initialized gstreamer, version <IP_ADDRESS>
[gstreamer] gstDecoder -- creating decoder for jellyfish.mkv
[gstreamer] gstDecoder -- Your GStreamer installation is missing a plug-in.
[gstreamer] gstDecoder -- try manually setting the codec with the --input-codec option
[gstreamer] gstDecoder -- failed to create decoder for file:///home/hazeee/jetson-inference/build/x86_64/bin/jellyfish.mkv
imagenet:  failed to create input stream


XML: Structural error in xml file, 12 open items. -- JSON: The returned JSON does not match the expected structure (Invalid JSON.). (code: PE231)

Hi,
Our sensor has stopped working for a few days now. In the output we see the following error:
### Get-vPCRepoInfo : Exception calling "SyncSpaceInfoToDb" with "2" argument(s): "
Failed to register new route"
At C:\Program Files (x86)\PRTG Network Monitor\custom sensors \EXEXML\PRTG-Veeam
BRStats.ps1:635 char:29
What could this be? Nothing wrong with the sensor has changed.

Hi,
the "Get-vPCRepoInfo" function precesses all Datastores in your Veeam Inventory.
Had something changed in your Veeam Environment (new or changed Repo, etc.)?
Do you use the latest version of the Script from this Repo?
Which Veeam Version do you use?
Might you please run the Script with the -debug switch and share the result?


standard functions sometimes can't be used after the as function

What happened?
From https://github.com/eitsupi/querying-with-prql/blob/4acff8fa395a9a2c33cad15ed61866dabac25157/docs/method_chaining.qmd#L128-L158
I rewrote the example that worked in PRQL 0.8 with the 0.9 syntax and an error occurred.
let time_to_datetime = string -> (FlightDate | as timestamp) + s"""
  TRY_CAST(regexp_replace({string}, '^2400$', '0000').substr(1, 2).concat(' hours') AS INTERVAL) +
  TRY_CAST(regexp_replace({string}, '^2400$', '0000').substr(3, 2).concat(' minutes') AS INTERVAL)
"""

from tab
select {
  FlightDate,
  DepTimeOld = DepTime
}
derive {
  DepTime = (time_to_datetime DepTimeOld)
}
take 5

For example, the following minimal example will result in the following error:
Error:
   ╭─[:2:23]
   │
 2 │ select col1 = (col1 | as int) + 1
   │                       ───┬──
   │                          ╰──── function std.add, param `left` expected type `int || float || timestamp || date`, but found type `scalar`
───╯

PRQL input
from tab
select col1 = (col1 | as int) + 1

SQL output
NA

Expected SQL output
SELECT CAST(col1 AS int) + 1 AS col1
FROM tab

MVCE confirmation

[X] Minimal example
[X] New issue

Anything else?
No response

Interestingly,
from tab
select col1 = (col1 | as int) * 2

works. It's std.add/std.sub that throws this error.

Good find.
And to note, adding parentheses doesn't help:
from tab
select col1 = ((col1 | as int) + 1)

Error:
   ╭─[:2:24]
   │
 2 │ select col1 = ((col1 | as int) + 1)
   │                        ───┬──
   │                           ╰──── function std.add, param `left` expected type `int || float || timestamp || date`, but found type `scalar`
───╯

It seems that only add and sub are specifing types.
Perhaps scalar should also be allowed?
https://github.com/PRQL/prql/blob/fe4edca40c2ca85b1be4f47588c54ef2166783bc/crates/prql-compiler/src/semantic/std.prql#L18-L23

I have looked at this and it seems that allowing scalar will not pass the following test. (Errors will no longer occur)
https://github.com/PRQL/prql/blob/fe4edca40c2ca85b1be4f47588c54ef2166783bc/crates/prql-compiler/src/tests/test_error_messages.rs#L175-L190

So the main difference is that there are constraints on types for add (and sub) but not for mul (and div)
let add = left<int || float || timestamp || date> right<int || float || timestamp || date> -> <int || float || timestamp || date> internal std.add
let mul = left right -> <int || float> internal std.mul

Meaningselect col1 = (col1 | as int) * 2 is ok but select col1 = (col1 | as int) + 2 is not when it should be.
At the same time something like (a && b) * col1 is ok even though it's wrong and is rightly caught as an error with +.
So the question is : should we write
let add = left right -> internal std.add
in order to solve this problem even though some errors are not caught anymore?
If not, a clean fix needs to be found to allow add to work. If this fix is found, it will probably be available for mul and stuff and some constraints could be added to mul to stop allowing stuff like  (a && b) * col1

in order to solve this problem even though some errors are not caught anymore?

I would tend towards "fewer false positives, even if that means fewer false negatives" — particularly for instances where there's no escape hatch.
So I'm +0.2 on this. @aljazerzen understands it much better, so if he has a view, it likely outweighs mine...

If the right fix is hard to implement I'm also in favor of a quick fix to allow valid syntax.
@aljazerzen or you are the best to say whether the proper fix is hard to implement

So, the problem here is that:

Type of col1 | as int is inferred to be scalar, but it should be int.
std.add has type-annotated params, so the type of argument is checked and we get a type error.
(because scalar contains text and bool, which cannot be std.add-ed)

Problem 1 is a missing feature, since std.as does not do any type inference at all, but just compiles to an SQL cast. The "right fix" is to actually implement type casting. This would involve:

adding special grammar for parsing type casts, since we want to parse a type expression, which is not the same thing as "normal" expressions,
removing std.as in favor of a special compiler implementation,
add RQ operators for casting between different types.

Problem 2 is not really a problem, it is expected behavior.
Reporting an error here is very inconvenient, so the quick fix of removing type annotation in std module seems a reasonable thing to do now. They can easily be added back later. If we do that, make sure to add a test for this case.


[e2e]: nodejs push main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/7650553017
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.push.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.nodejs.push.main.default.slsa3.yml
Trigger: push
Branch: main
Date: Thu Jan 25 06:09:42 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/7664574320
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.push.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.nodejs.push.main.default.slsa3.yml
Trigger: push
Branch: main
Date: Fri Jan 26 06:10:39 UTC 2024
Tests are passing now. Closing this issue.


Better extensibility of Query class

Problem: In my project I needed to customize the way how exceptions are thrown in _populate() method, so I created a child class and overrode _populate method there. Since the response processing logic is encapsulated into several private methods, I had to pull most of them into my class in order to have everything working.
This PR introduces 2 changes:

visibility of some methods changed to protected, so that it's not necessary to override all dependent methods of _populate
added httpClientExtraConfig property so that subclass can extend/override configuration of the http client.

merged


Order status and line status can't be translated

The status pipelines relies on strings to work. I just marked them translatable, but got an import error for that file - I presume marked strings can't be used as dictionary keys. That makes it hard to translate the order status and line status.

@maikhoepfel @mvantellingen done in PR #1783

We decided to try django-fsm as proper solution for the issue.

Are there some news on this issue?

closing all issues that are feature requests that don't have PR's attached.


Graceful Shutdown of Keptn components

Action Item
Services shall be able to shut down gracefully.
Details
When shutting down a service (a.k.a., receiving a SIGTERM) a keptn service shall stop accepting/processing new messages.
In general, each service shall handle the termination signal gracefully by cleaning up its resources and finishing its current activity, so that it can gracefully shut down without being killed by K8S.
Long-running tasks
The majority of Keptn Integrations are task executors that are triggered by a *.triggered* event and ar then executing their task. This could be something that is immediately done like sending out a notification event, or it could be something that is potentially long-running like executing some tests against a system (e.g. jmeter-service)
Hence, the proposal is to make use of k8s preStop lifecycle hook. This is called immediately before the container is terminated. The lifecycle of the pod is blocked until the preStop handler completes or the pod's grace period expires. By introducing an endpoint in the service it can be (repeatedly) checked whether the service is currently active executing a (long-running) task or not. If not the script is exited, and the container is shutting down. Note that the terminationGracePeriodSeconds configuration parameter needs to be set to an appropriate (high) value.
Zero Downtime
During shutdown/deletion of a pod this is what happens:

pod is removed from the endpoints of all services
preStop Hook is executed
SIGTERM signal is sent to containers in pod.
termination grace period is started (this defines the time in seconds K8S waits before killing the pod) (30 per default)
SIGKILL is sent after the termination grace period is over.

Note, that 1-4 is performed simultaneously. Hence, it is possible that the pod has not been removed from the endpoints after it received the SIGTERM signal which will result in a partial downtime of the service, since the pod already stopped working at this time.
The solution for that is to configure a preStop hook for the pod, so that the pod sleeps for some time after it receives SIGTERM (see keptn-nats-cluster for an example).
Acceptance Criteria

[ ] Keptn services do not process any messages/requests once they are scheduled for termination
[ ] Keptn services are able to finish long-running tasks, such as executing a load test (jmeter-service) before they get terminated.

Definition of Done

[ ] feature implemented and reviewed
[ ] manually tested

Proposal
Zero Downtime
During shutdown/deletion of a pod this is what happens:

pod is removed from the endpoints of all services
preStop Hook is executed
SIGTERM signal is sent to containers in pod.
termination grace period is started (this defines the time in seconds K8S waits before killing the pod) (30 per default)
SIGKILL is sent after the termination grace period is over.

Note, that 1-4 is performed simultaneously. Hence, it is possible that the pod has not been removed from the endpoints after it received the SIGTERM signal which will result in a partial downtime of the service, since the pod already stopped working at this time.
The solution for that is to configure a preStop hook for the pod, so that the pod sleeps for some time after it receives SIGTERM (see keptn-nats-cluster for an example).
Long-running tasks
The majority of Keptn Integrations are task executors that are triggered by a *.triggered* event and ar then executing their task. This could be something that is immediately done like sending out a notification event, or it could be something that is potentially long-running like executing some tests against a system (e.g. jmeter-service)
Hence, the proposal is to make use of k8s preStop lifecycle hook. This is called immediately before the container is terminated. The lifecycle of the pod is blocked until the preStop handler completes or the pod's grace period expires. By introducing an endpoint in the service it can be (repeatedly) checked whether the service is currently active executing a (long-running) task or not. If not the script is exited, and the container is shutting down. Note that the terminationGracePeriodSeconds configuration parameter needs to be set to an appropriate (high) value.

To allow estimating this issue, a breakdown in its component it necessary.


Downloading

When i choose the second option, the download never start, I live in Cuba... Any recommendations on alternative?

for what device / board name? post a pic of the main menu please

https://github.com/MrChromebox/scripts/blob/master/sources.sh

https://github.com/MrChromebox/scripts/blob/master/sources.sh

for example
cd ~/Downloads/
sudo flashrom -w yourname.rom
reboot

closing due to lack of follow up


Fixed the Collapse example in the 1.0.0-release branch

This is intended/targeted for the 1.0.0-release branch
The collapse example button was not responding to mouse clicks.

Thanks for catching this! But actually it should be onClick=(action "toggle")! Can you update?

Fixed this in your branch already and merged it. Thanks!


Update README.md: differences table is broken

There is an extra line break in the "difference" table which is causing the last rows to not show in the table.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks, good catch. Would it be possible for you to sign the CLA?

Closing this is because we fixed it #188


Cleanp - Adding a single variable for default configmaps.

Changes
/kind cleanup
Prior, the New* function was called each time when we need to get the
default configuration for the default, feature flags, metrics and spire configmap.
Now, we created those variables first in corresponding file, and use a deepcopy
of it each time.

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep

Release Notes
NONE

/assign @jerop PTAL

/assign @jerop

/approve

/lgtm

/test pull-tekton-pipeline-go-coverage

/test pull-tekton-pipeline-alpha-integration-tests


> is rendered as > on the server

When rendered on the server
.Foo > *:not(:first-child) {
  ...
}

is rendered as
.Foo > *:not(:first-child) {
  m...
}

and this causes the initial styling to not be proper

Just tried and it seems to work fine, can you put together a sample repo to reproduce?

Actually I just realised that I was doing <style> instead of <style jsx>. Apologies for the time waste. I will close this issue.

no worries!


Create ili.txt

Instituto da Língua Inglesa
ili.com.br
Cuiaba-MT-Brazil

This seems to be a primary school; this database is for post-secondary (higher education) schools. Closing.


ABCI++ vote extensions & FinalizeBlock

This is the continuation of the work started in tendermint/tendermint#9053: backport ABCI++ implementation, which lives in the v0.36.x branch.
Once this tracking issue is completed, the whole ABCI++ interface should be ready for QA process, and then release.
Proposed Path to Done. Summary
The main idea behind this plan is to proceed in the same way as tendermint/tendermint#9053.
The main approach is:

We will "follow" our work on v0.36.x. By "following a PR", I mean looking at that PR (similar work done for v0.36.x) and copying over only what makes sense. "git cherry-pick" turned out to be our best friend for "following" PRs in tendermint/tendermint#9053
We will be considering only commits related to vote extensions and FinalizeBlock
We will be skipping PrepareProposal/ProcessProposal related commits (as they are already in main via tendermint/tendermint#9053)

The work is structured very similarly to #9053. It consists of two main parts (further described below):

[x] (1) Preliminary work
[ ] (2) Core feature work

(1) and (2) can mostly proceed in parallel.
protobufs will be managed as in v0.37.x → They will evolve with the code
Proposed Path to Done. Details
(1) Preliminary Work
We could have two threads here, but as all these tasks serialized are shorter than the critical path in "Core Feature Work", there's no point

[x] Create feature branch: feature/abci++vef
[x] Restore CI on feature/abci++vef branch
[x] e2e tests: port any improvements not included in the core work section (git diff HEAD..v0.36.x -- test/e2e) (tracking: https://github.com/tendermint/tendermint/pull/9426)

(2) Core feature work
We have three threads that can proceed in parallel:

Vote extensions (*)
FinalizeBlock (*)
Spec and doc work

(*) Only when vote extensions and FinalizeBlock are done, can we proceed with the fourth part:

Final adjustments

tasks here could be further parallelized

Vote Extensions

[x] Old vote extensions

Follow tendermint/tendermint#6646, then tendermint/tendermint#6885
Double-check integration of PrepareProposal -- vote extensions

Check if there is something missing from tendermint/tendermint#7821 (or tendermint/tendermint#6915)

[x] tendermint/tendermint#9835

First cherry-pick tendermint/tendermint#8031 (ignore spec part),
Main part: follow tendermint/tendermint#8141

[x] tendermint/tendermint#9846

follow tendermint/tendermint#8402

[x] Vote extension propagation tendermint/tendermint#9852

follow tendermint/tendermint#8433

[x] tendermint/tendermint#9861

Add activation logic: follow tendermint/tendermint#8547

[x] tendermint/tendermint#9864

follow tendermint/tendermint#8587

[x] tendermint/tendermint#9887

FinalizeBlock

[x] tendermint/tendermint#9427  [Estimation: 4 days]

Follow tendermint/tendermint#7798 (it's bulky, and might depend on other infra PRs, if yes cherry-pick them first)

[x] Sync FinalizeBlock with spec

Description: follow tendermint/tendermint#7983

Final adjustments
Most of these tasks can be done in parallel, but they are quite short.

[x] #10

Spec and doc work
Low risk, can proceed completely in parallel with the rest

[x] #24
[ ] #25

Original issue: tendermint/tendermint#9396

Closing this as it's pretty much done. The only item left is issue 25, which is tracked separately.


Create install script

Move all the 'try it out' commands into an install script.
Bonus points:

install script can check if the docker daemon is running and if not then ask the user to turn it on.
Check to see if python 3 is installed and if not ask the user to install it.

Tabling this as we have not had any feedback that installation is a problem.


⚠ Friends API Endpoint has degraded performance

In 7c213e3, Friends API Endpoint (https://friends.roblox.com/v1/metadata) experienced degraded performance:

HTTP code: 503
Response time: 3646 ms

Resolved: Friends API Endpoint performance has improved in 43bf01b after 13 minutes.


Docker compose

🚀 Feature Request
add docker compose file to bring up client and server services, users with docker should basically be able to go from download, configure, and deploy locally in a couple commands.

closed with #138


Asset size

I'm using vite and when i implement this package, it use almost 481,7kb of space of the bundle.
With

Without

Isn't a huge problem but this issue is a concern. To be honest, it seems linked to buffer library which provides web browser compatibility but with a huge cost.
Anyways, thanks for your library.

Thanks for reaching out!
I totally see how this can be a concern. The package size is indeed too large due to polyfills used for hashing.
I'll look into it as soon as I can.

@Zen0x7 just pushed a new version of the package, please see if it resolves the bundle size issue for you.

@sauromates now appears the following:

The previous can be fixed by adding js-sha256 to my project but sounds weird.

At the end of the day, it solves the problem.

Hm. Sorry to hear about the error, I'll try to investigate. The js-sha256 is externalized already and shouldn't trigger this error, Yarn should have loaded it as a peer dependency. Thanks for providing a project link, I'll try to reproduce.
Anyways, I'm glad to hear that you have managed to integrate the library into your project. I will keep the issue open until I'm certain about the cause of this issue.

@Zen0x7 I've deployed the project you provided locally but couldn't get the error you've provided. Can you please provide some steps to reproduce it?
Using my own email instead of yours in the seeder gives me this without errors (on fresh install):
.

@sauromates just remove js-sha256 as a dependency and try to build again.

@Zen0x7 I believe I've managed to resolve the issue.
Somehow Yarn doesn't install peer dependencies automatically like NPM does. I've moved js-sha256 to direct dependencies and tested on your project - looks like everything working as it should be now.

Please do try the latest release. Feel free to close the issue if everything is fine.

@sauromates Yeah, seems like all is fine right now.
Thanks a lot. This is one good package. I'll use a couple of times in twice projects.


Tests causing error

There are two tests which are cooked for some reason.
They cause an error, which I've posted on stack overflow for: http://stackoverflow.com/questions/42972419/jasmine-node-failing-a-passing-test-with-npm-error-code-elifecycle
Thing is even though they fail, they should pass. That is the test fail msg states expected x to equal y, but when I manually check x and y, they are identical. Given that. I'm commenting these out for now, and I'll just continue as if they pass (which they should ffs!!).
Be good to sort out at some point though.

Finally fixed this with commit 026221f4191280912090e12b43cca8a5d44e47ad
After switching test runners to Jasmine, I saw a different logging error:
Expected
[ ({ id: '123', name: 'Tom' }), ({ id: '456', name: 'Tim' }), ({ id: '789', name: 'Tum' }) ]
to equal
[ Object({ id: '123', name: 'Tom' }), Object({ id: '456', name: 'Tim' }), Object({ id: '789', name: 'Tum' }) ]

This made it clear that there was actually some difference between the arrays. It was because the expected array was made up of object literals, rather than 'constructed' objects.


Penalize far apart pairs not more than as if they were two single ends

Closes #321.
The accuracy increases indeed a little bit.
Comparing accuracy

dataset
main (4893484)
this PR (d723bb4)
difference

drosophila-50
90.189
90.1903
+0.0013

drosophila-75
91.6441
91.64485
+0.0007

drosophila-100
92.38785
92.38855
+0.0007

drosophila-150
93.2112
93.21115
-0.0001

drosophila-200
93.52085
93.52115
+0.0003

drosophila-300
95.36085
95.36125
+0.0004

drosophila-500
95.6936
95.6938
+0.0002

maize-50
71.4703
71.47195
+0.0016

maize-75
82.1255
82.12625
+0.0007

maize-100
87.13175
87.1324
+0.0007

maize-150
91.6731
91.67345
+0.0003

maize-200
92.92045
92.9206
+0.0002

maize-300
96.70835
96.70855
+0.0002

maize-500
97.2899
97.29025
+0.0003

CHM13-50
90.635
90.63505
+0.0001

CHM13-75
92.5158
92.5161
+0.0003

CHM13-100
93.21985
93.22015
+0.0003

CHM13-150
94.14035
94.1402
-0.0002

CHM13-200
94.43405
94.43425
+0.0002

CHM13-300
95.62665
95.62645
-0.0002

CHM13-500
95.9505
95.9505
+0.0000

rye-50
69.1402
69.14095
+0.0007

rye-75
80.53445
80.5352
+0.0007

rye-100
85.6483
85.6488
+0.0005

rye-150
90.20375
90.2038
+0.0001

rye-200
91.4773
91.4774
+0.0001

rye-300
94.5574
94.55795
+0.0005

rye-500
95.1326
95.1331
+0.0005

Average difference: +0.0004
I tried a couple of other things. In the formula you suggested in #321, you had an epsilon_pair term. I tested with epsilon_pair=2 and epsilon_pair=5 and while individual accuracies change a little bit for each dataset, the average difference remains at +0.0004 in both cases. I guess the term would have an effect for other datasets, so if you want, we can include it, but we canot measure its effect with the data we have.
Also, as you suggested, I tried changing the three occurrences of the hard-coded -20 in the function to either -10 or -30 (this was in addition to introducing the std::max()). This made the average difference worse (-0.1860 and -0.0056, respectively).

Great to have this fix!

if you want, we can include it, but we canot measure its effect with the data we have.

With epsilon_pair I meant that it should be the deciding factor only in cases where 'all else equal'. An epsilon_pair 2 or 5 sounds a bit high and may interfere with disjoint alignments that have better alignment score.  How about epsilon_pair=0.001? I would be ok with adding such term without having a proper SV dataset.

Alright, I added an epsilon of 0.001. I also think it’s fine to have this without more extensive testing.

Ok, approved


update

Hi @jalourenco - please do not submit pull requests unless you're contributing code back to Wagtail. This is just adding extra noise for us to sort through!


[KYUUBI #1556]Upgrade swagger-ui version from 4.1.0 to 4.1.3

Why are the changes needed?
Close https://github.com/apache/incubator-kyuubi/issues/1612
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #1630 (71fe05b) into master (21f10d7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1630   +/-   ##
=========================================
  Coverage     58.32%   58.33%
  Complexity      164      164
=========================================
  Files           260      260
  Lines         12930    12930
  Branches       1633     1633
=========================================
+ Hits           7542     7543    +1
  Misses         4756     4756
+ Partials        632      631    -1

Impacted Files
Coverage Δ

.../main/scala/org/apache/kyuubi/server/api/api.scala
100.00% <100.00%> (ø)

...ache/kyuubi/operation/KyuubiOperationManager.scala
85.00% <0.00%> (+2.50%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21f10d7...71fe05b. Read the comment docs.

@ldzhjn rayliu<EMAIL_ADDRESS>the committed author is not in your github account. Maybe you can add the email when you have time

@ldzhjn the committed author is not in your github account. Maybe you can add the email when you have time

Sure, will do.
In the mean time, do you mind masking the email in your comment please?

@ldzhjn the committed author is not in your github account. Maybe you can add the email when you have time

Sure, will do. In the mean time, do you mind masking the email in your comment please?

edited


[FR]prefabPublishing multiple header directories for one library

It would be great if you could specify multiple header directories for one prefab library. Example:
prefab {
        TelemetryReceiver {
            headers "src/main/cpp/TelemetryReceiver"
            headers "src/main/cpp/SharedCppC"
        }
}

That's an Android Gradle feature. Please file the big against the Android Gradle Plugin.

Hello,
Unfortunately I don't think I have permissons to file bugs agains the android gradle plugin.
Aka Android Public Tracker > App Development > Android Studio > Gradle > Android Gradle Plugin > Prefab Integration
Therefore I filed the bug here:
Android Public Tracker > App Development > Android Studio
https://issuetracker.google.com/issues/168775349

Yeah, that's expected. Everything gets filed at the top level and goes through a common triage process.
I've moved it into the correct component and assigned it to myself since I'll probably be the one that fixes it.

en...,the same question, any update on this issue?

No. Locking to try to help guide people to the correct bug: https://issuetracker.google.com/issues/168775349. Comment there, not here.


Docs: document of this is wrong? or I'm wrong about this?

Page URL: https://www.typescriptlang.org/docs/handbook/functions.html
Issue:
quote

We can fix this by making sure the function is bound to the correct this before we return the function to be used later. This way, regardless of how it’s later used, it will still be able to see the original deck object.

Actually this for the arrow function is bound to the anonymous function outside, not to deck object, so it should still be any?

Currently TypeScript tells that type of this is fixed to deck, which seems not right to me.

because this depends on how createCardPicker is used, like code below, this is now bound to deck2.

Recommended Fix:
Not sure, maybe there is a problem about TS inferring this?
Browser:  Chrome

If you run the code sample in the Playground with a console log on this, it logs the deck - which is what TypeScript says it is. It might be worth taking a second look to check yourself.

Yeah, the sample code is right about deck,
I mean it should be any though ? 🤔
sample code  => deck1

another case => not deck1, deck2

which means, it should still be any?
maybe this is intentional from typescript, if that's the case I think maybe we better clear it out in the link above.

https://www.typescriptlang.org/docs/handbook/functions.html#this-parameters
oh the next sections explains it well though. I'll close it


[red-knot] feat: implement integer comparison

Summary
Implements the comparison operator for [Type::IntLiteral] and [Type::BoolLiteral] (as an artifact of special handling of True and False in python).
Sets the framework to implement more comparison for types known at static time (e.g. BoolLiteral, StringLiteral), allowing us to only implement cases of the triplet <left> Type, <right> Type, CmpOp.
Contributes to #12701 (without checking off an item yet).
Implementation Details
I couldn't avoid allocating a Vec<Type> for the first evaluation of initial expressions before iterating over pairs of expression types (.windows(2)). Currently, I couldn't use .windows on iterators. This seems to be possible using some crates or an experimental API. If anyone has an idea on how to achieve this without allocation, I'd love to hear it.
Test Plan

Added a test for the comparison of literals that should include most cases of note.
Added a test for the comparison of int instances

Please note that the cases do not cover 100% of the branches as there are many and the current testing strategy with variables make this fairly confusing once we have too many in one test.
I'll probably open a separate PR with a candidate util function for cases like this (checking the public type of many separate statements).

I'll probably open a separate PR with a candidate util function for cases like this (checking the public type of many separate statements).

You can do this, but note that I'm also working on a test framework (see discussion in https://github.com/astral-sh/ruff/issues/11664 ) which should also make this a lot less verbose. So it may not be worth investing a lot into test utils like this one in the meantime.

Just dropping this here for future reference (@AlexWaygood sent a similar article for #13590):
https://snarky.ca/unravelling-rich-comparison-operators/

I think I should have an attempt that should covers all comments (to my knowledge) except the tuple_windows, I'll try to give more details on why I couldn't get that to work with code comments.

Couldn't find one for in, not in

https://snarky.ca/unravelling-membership-testing/
All the blog posts can be found under https://snarky.ca/tag/syntactic-sugar/ . If you want to look the posts up by syntax, https://github.com/brettcannon/desugar/blob/main/README.md is a good way to do that.


External extensions for 16.0

Pulling the extensions from d16.0 branch for 16.0 release.

@dotnet-bot Test this please.

@dotnet-bot test this please

@dotnet-bot test this please


⚠ Bofrost.at has degraded performance

In 854af77, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 855 ms

Resolved: Bofrost.at performance has improved in 57cc314 after 6 minutes.


Either alert text or fix the technology so Google Workspace works Configure federated sign-in for student assigned devices

Please do one of the two following for both websites
https://learn.microsoft.com/en-us/education/windows/federated-sign-in?tabs=intune
https://learn.microsoft.com/en-us/education/windows/configure-aad-google-trust

update this documentation with a notice
update the technological solution so in some way this works such as getting windows login off of basic authentication ws-fed/ws-trust

I setup federation with Google Workspace https://learn.microsoft.com/en-us/education/windows/configure-aad-google-trust then set up the sign in https://learn.microsoft.com/en-us/education/windows/federated-sign-in?tabs=intune only to later find out it doesn't work. If there was an alert on the page others would be saved from the PITFA I just dealt with in then after thorough testing to roll everything back.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: aab824fb-b795-518a-8d52-7490975ab5ac
Version Independent ID: aab824fb-b795-518a-8d52-7490975ab5ac
Content: Configure federation between Google Workspace and Azure AD - Windows Education
Content Source: education/windows/configure-aad-google-trust.md
Product: windows-client
Technology: itpro-edu
GitHub Login: @paolomatarazzo
Microsoft Alias: paoloma

Hello @l2g2h and thank you for the constructive feedback. Can you please elaborate what didn't work? The steps have been validated multiple times, so I would suggest you checking again. Without further information, I can't add any disclaimer or updates to the documentation. Also, you can open a support request to get assistance.

Thank you @paolomatarazzo for the clear request. I forgot to include it.
The federation with Google Workspace Education only works for SaaS.
https://learn.microsoft.com/en-us/education/windows/configure-aad-google-trust
Does not work for Windows/Intune.
https://learn.microsoft.com/en-us/education/windows/federated-sign-in?tabs=intune
https://cloud.google.com/architecture/authenticating-corporate-users-in-a-hybrid-environment
M365 for Education/A3 & Google Workspace Education.
Request:
Update both urls that this does not work with/for Windows sign in which is functionally unacceptable it prevents use of Windows machines.
If @paolomatarazzo  there are steps that have been validated multiple times then Microsoft needs to raise their quality of documentation to include the screenshots of the documentation. Without that proof I do not believe Microsoft got the Google Workspace federation to work with Windows until Microsoft updates the legacy auth login to Windows. Again. Microsoft needing to raise their own bar. Without this customers are thinking this works instead being lied to then having to cancel the licenses because of being mislead.
https://cloud.google.com/architecture/authenticating-corporate-users-in-a-hybrid-environment

@l2g2h Both documentations contain an animated gif showing federation working between GW and AAD, I'm not sure which other "proof" you're asking for. It works with Windows and Intune. Please check the prerequisites in the documentation to determine whether the OS you're using is supported.

here's the proof:
https://github.com/MicrosoftDocs/windows-itpro-docs/assets/74918781/f87d74bd-55ae-4e2a-aa15-9e449c2458e2

Thank you very much for the gif that is reassuring that it works/worked.

What I'm further requesting is screenshots re configurations for the mentioned Federations.
I see some documentation shows admin side screenshots and some don't just instead text of the configurable pieces. Yes I understand technology changes the GUI may change. I've configured all the elements & not had success so I'm working to compare to what Microsoft configured on all sides because it's outright bewildering.
Yes, I understand can use a support ticket; however, lately support takes in excess of 1 month to initially get started, an additional 3-4 months to get escalated and transferred to the right knowledgeable resource, then ultimately told to go work with the 3rd party because Microsoft support across all paid options (including Msft Partner support) doesn't resolve on any production timeline.
It would be so much nicer if documentation was simply up to date & included screenshots because the support options aren't worth engaging. I had a 5 month partner ticket that got nowhere with all the escalation, transferring then being told it was on the 3rd party. There was a time when Microsoft support was worth engaging.

what exactly are you "requesting"... or rather asking for? an output of a powershell command? in our documentation, we don't include screenshots of a 3rd party solution like GW. So if it could help, I can share how I configured the test tenant used for documentation purposes. I ask to be polite and courteous. Ultimately, I'm not part of support and trying to help out.

this is all you see from entra.microsoft.com