sometimes|required fails due to Validator method passesOptionalCheck returning true

Laravel Version: 5.5.17
PHP Version: 7.0.10
Database Driver & Version: N/A

Description:
Rule sometimes|required does not behave as expected for collections.
https://laravel.com/docs/5.5/validation#conditionally-adding-rules
I want to validate the field as required if present. Therefore removing required and nullable did not work.
I believe its because Validator passesOptionalCheck() is returning true while it should be returning false.
This means the required validation is not skipped even though the attributes are not present in the data.
As I am new I do apologies beforehand. If the question is not to standard.
Steps To Reproduce:
METHOD: PUT
Content-Type: application/json

json:
[
    {"id" : "93049", "port" : "5"},
    {"id" : "93050", "password" : "55555", "version" : "5"}
]

$rules = [
    '*.type' => 'sometimes|required|string'
];

Using lumen:
$this->validate($request, $rules);

Response:
{
    "errors": [
        {
            "title": "Validation Error",
            "detail": "The type field is required",
            "status": 422,
            "source": "0.type"
        },
        {
            "title": "Validation Error",
            "detail": "The type field is required",
            "status": 422,
            "source": "1.type"
        }
.......
}

$request->request:
object(Symfony\Component\HttpFoundation\ParameterBag)[46]
  protected 'parameters' =>
    array (size=2)
      0 =>
        array (size=3)
          'id' => string '93049' (length=5)
          'port' => string '5' (length=1)
          'server_id' => string '4222' (length=4)
      1 =>
        array (size=4)
          'id' => string '93050' (length=5)
          'password' => string '55555' (length=5)
          'version' => string '5' (length=1)
          'server_id' => string '4222' (length=4)

Debugging:
modified the method to pass the $rule for debugging:
    protected function passesOptionalCheck($attribute, $rule = null)
    {
        if (! $this->hasRule($attribute, ['Sometimes'])) {
            return true;
        }
        $data = ValidationData::initializeAndGatherData($attribute, $this->data);

        if ($attribute === "0.type" && $rule === 'Required') {
            dd( array_key_exists($attribute, $data)); //returns false (ok)
            dd( in_array($attribute, array_keys($this->data))); // returns true (problem)
            dd( array_keys($this->data)); // gives [0, 1]
            dd( in_array( '0.type', [0,1])); // returns true (problem)
            dd(in_array( '0.type', [0,1], true)); //returns false (problem solved)
        }

        return array_key_exists($attribute, $data)
                    || in_array($attribute, array_keys($this->data));
    }

using strict comparison fixes the problem for me:
in_array($attribute, array_keys($this->data), true);
However the check should be against keys within the array and not the index.
$data = ValidationData::initializeAndGatherData($attribute, $this->data);
$data is fine as it returns empty as the field is not present in data but in_array($attribute, array_keys($this->data)) uses $this->data.
using $data instead of $this->data fixes the problem for me:
in_array($attribute, array_keys($data));
Extra info:
illuminate/validation: v5.5.17
PHP 7.0.10 (cli) (built: Nov  3 2016 08:06:03) ( NTS )
Copyright (c) 1997-2016 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2016 Zend Technologies
with Xdebug v2.5.5, Copyright (c) 2002-2017, by Derick Rethans

already have the same error
First of all, Taylor Otwell, thanks for laravel, excellent work, and thanks for sharing this fabulous framework with us.
When sending a post for creating a sponsor, appear than accept the request, but didn't enter the request to the function, so don't create the sponsor but redirect the view with no issues reported on $errors array,

Laravel Version: 5.5.33
PHP Version: 7.1.13
Database Driver & Version: MySql Version 5.7.21 Driver PHP7.1-msql
Web service: Nginx 1.10.3
Dropplet on Digital Ocean, with OS Ubuntu 16.04 of 64bits

Already I have this file on app/Http/Request/SponsorRequest:
<?php

namespace App\Http\Requests;

use Illuminate\Foundation\Http\FormRequest;

class SponsorRequest extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        return [
          'name' => 'required|unique:sponsors,name|string|max:255',
          'description' => 'required|string|max:255',
          'number_of_travels' => 'required|numeric|max:255',
          'name_package' => 'required|unique:travels_hired,name|string|max:255',
          'file_svg' => 'required|image',
        ];
    }
}

file on app/Http/Controller/SponsorController(function create):
<?php

namespace App\Http\Controllers;

use DB;
use App\Sponsor;
use \Carbon\Carbon;
use App\TravelHired;
use App\PVPeopleRequest;
use App\RequestBikeAngel;
use Illuminate\Http\Request;
use Maatwebsite\Excel\Facades\Excel;
use App\Http\Requests\SponsorRequest;
use App\Http\Requests\PackageRequest;
use Illuminate\Support\Facades\Storage;
use App\Http\Requests\SponsorUpdateRequest;

class SponsorController extends Controller
{
    protected $params;
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        $this->params = array();
        $this->params['notification_created_user'] = $request->has('notification_created_user')?$request->input('notification_created_user'):false;
        $this->params['notification_updated_user'] = $request->has('notification_updated_user')?$request->input('notification_updated_user'):false;
        $this->params['notification_package_create'] = $request->has('notification_package_create')?$request->input('notification_package_create'):false;
        $this->params['sponsors'] = Sponsor::all();
        return view('sponsor.index', $this->params);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create(SponsorRequest $request)
    {
        $this->params = array();
        $this->params['sponsor_new'] = new Sponsor;
        $this->params['sponsor_new']->name = $request->input('name');
        $this->params['sponsor_new']->description = $request->input('description');
        $this->params['sponsor_new']->statuses_id = 1;
        $path = public_path().'/sponsors/logo/';
        $file = $request->file("file_svg");
        $fileName = $file->getClientOriginalName();
        $file->move($path, $fileName);
        $this->params['sponsor_new']->logo = '/sponsors/logo/'.$fileName;
        $this->params['sponsor_new']->save();
        $this->params['travel_hired'] = new TravelHired;
        $this->params['travel_hired']->name = $request->input("name_package");
        $this->params['travel_hired']->number_travels_hired = (Integer) $request->input("number_of_travels");
        $this->params['travel_hired']->sponsors_id = $this->params['sponsor_new']->id;
        $this->params['travel_hired']->travels_consumed = 0;
        $this->params['travel_hired']->save();
        $this->params['notification_created_user'] = true;
        $this->params['notification_updated_user'] = false;
        $this->params['notification_package_create'] = false;
        return redirect()->route('sponsors', $this->params);
    }
}

This has been fixed in 5.6.18 (#24012) and will be fixed in the next release of 5.5 (#25852).

Thanks everyone!


[Bug]:  Portable Version is not truly Portable

Version

[X] I'm using version 1.10.0

Known issues

[X] I've checked Known issues

Existing issues

[X] I've checked Existing issues

What operating system are you using?
Windows
Operating System Version
Windows 10 Pro
Reproduction steps

Download and extract portable version in a different location other than System Drive.
Open app and change some settings.
Reinstall Operating System (Windows)
Open app.
...
Reproduces how often: [What percentage of the time does it reproduce?]

Expected Behavior
remembers all setting because it is a portable version and the app folder is intact.
Actual Behavior
remembers nothing. act like just born.
Relevant log output
No response
Preferences
No response
Additional information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Well, I guess you're right. Preferences are always saved in the same location.


The "Connect to a database" cannot be executed after opening an extra file

OS: Win10
Build Version: 20231119.1
Regression: Not a regression
Repro Steps:

Create a scrapbook.
Open a file, such as setting.json.
Navigate to the scrapbook file -> Click "Connect to a database".
Check whether the "Connect to a database" can be executed.

Expect:
The "Connect to a database" can be executed.
Actual:
The "Connect to a database" cannot be executed.

More Info:
The "Connect to a database" can be executed after editing something in the scrapbook file.

Scrapbooks are now deprecated and this work fine with the new Query Editor experience for vCore. Let's resolve this once we add support for Mongo Accounts there. cc @tnaum-ms


nautobot-default container fails to stabilize

Environment

Nautobot version (Docker tag too if applicable): v2.1.9-py3.11
Python version: 3.11 (Built into the docker image)
Database platform, version: Postgres 16.2 inside container
Middleware(s): Traefik to control ingress routing to Nautobot pod(s)

Upgraded to v2.1.9-py3.11 and receiving the following error in the nautobot-default container logs.  Rolling back to v2.1.8-py3.11 stabilizes the nautobot-default container.
[uWSGI] getting INI configuration from /opt/nautobot/uwsgi.ini
[uwsgi-static] added mapping for /static => /opt/nautobot/static
*** Starting uWSGI 2.0.23 (64bit) on [Fri Mar 29 15:33:31 2024] ***
compiled with version: 12.2.0 on 25 March 2024 20:07:05
os: Linux-6.1.0-18-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.76-1 (2024-02-01)
nodename: nautobot-default-5fcf6dc4b6-mxztn
machine: x86_64
clock source: unix
detected number of CPU cores: 4
current working directory: /opt/nautobot
detected binary path: /usr/local/bin/python3.11
!!! no internal routing support, rebuild with pcre support !!!
your memory page size is 4096 bytes
detected max file descriptor number: 1048576
building mime-types dictionary from file /etc/mime.types...1545 entry found
lock engine: pthread robust mutexes
thunder lock: disabled (you can enable it with --thunder-lock)
uWSGI http bound on <IP_ADDRESS>:8080 fd 6
uWSGI http bound on <IP_ADDRESS>:8443 fd 7
uwsgi socket 0 bound to TCP address <IP_ADDRESS>:40585 (port auto-assigned) fd 5
Python version: 3.11.8 (main, Mar 12 2024, 11:52:02) [GCC 12.2.0]
--- Python VM already initialized ---
Python main interpreter initialized at 0x7f83f4198218
python threads support enabled
your server socket listen backlog is limited to 128 connections
your mercy for graceful operations on workers is 60 seconds
mapped 333504 bytes (325 KB) for 6 cores
*** Operational MODE: preforking+threaded ***
15:33:31.168 INFO    nautobot :
  Nautobot initialized!
WSGI app 0 (mountpoint='') ready in 0 seconds on interpreter 0x7f83f4198218 pid: 1 (default app)
spawned uWSGI master process (pid: 1)
spawned uWSGI worker 1 (pid: 9, cores: 2)
15:33:31.184 INFO    nautobot.core.wsgi :
  Closing existing DB and cache connections on worker 1 after uWSGI forked ...
spawned uWSGI worker 2 (pid: 10, cores: 2)
15:33:31.185 INFO    nautobot.core.wsgi :
  Closing existing DB and cache connections on worker 2 after uWSGI forked ...
spawned uWSGI worker 3 (pid: 12, cores: 2)
spawned uWSGI http 1 (pid: 14)
15:33:31.186 INFO    nautobot.core.wsgi :
  Closing existing DB and cache connections on worker 3 after uWSGI forked ...
15:33:36.584 WARNING django.request :
  Forbidden: /api/
[pid: 9|app: 0|req: 1/1] <IP_ADDRESS> () {30 vars in 354 bytes} [Fri Mar 29 15:33:36 2024] GET /api/ => generated 58 bytes in 23 msecs (HTTP/1.1 403) 8 headers in 239 bytes (1 switches on core 0)

Steps to Reproduce

Roll out version 2.1.9 from 2.1.8 via Kubernetes
Observe pod state as new pods are spun up to replace the 2.1.8 pods
Observe the nautobot-default pod throwing the described errors above in the logs and preventing container from fully stabilizing (container keeps restarting)

Expected behavior
nautobot-default pod should fully stabilize without throwing said errors in the logs

Observed behavior
nautobot-default pod fails to stabilize and constantly restarts

This is the same root cause as #5490 and https://github.com/nautobot/helm-charts/issues/371. The /api/ endpoint is no longer accessible as an unauthenticated health-check. If you're using the helm-charts repo, upgrading to chart version 2.1.0 should fix the issue. Sorry for the trouble!

What if one does not use the helm chart install method?  I am a bit more manual in that I like to control the deployment of individual components.  Wait for 2.1.10?

You just need to change the health-check that your container is using - either to /health/ rather than /api/, or calling the CLI nautobot-server health_check are our recommendations (we added the documentation https://docs.nautobot.com/projects/core/en/stable/user-guide/administration/installation/health-checks/#nautobot-server-container-in-k8s in the 2.1.9 release)

Thanks, sorry it was not obvious by looking at the links you referenced without interrogating the helm chart.


Add Evergreen and Fixed Version docs for WebView2 GA

Preparing the docs for Evergreen GA and Fixed Version preview. Looking to publish on 10/19 9AM.
[InstallerSample]: https://aka.ms/wv2installersample "WebView2 Installer Sample"
Will replace the aka.ms link once I have the real link

Docs Build status updates of commit b042fb8:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:warning:Warning
View
Details

microsoft-edge/webview2/concepts/distribution.md

Line 80, Column 739: [Warning-file-not-found] Invalid file link: '../reference/win32/0-9-622/webview2-idl'.
Line 80, Column 785: [Warning-file-not-found] Invalid file link: '../howto/webdriver'.
Line 93, Column 65: [Warning-file-not-found] Invalid file link: '../reference/win32/0-9-622/webview2-idl'.
Line 95, Column 21: [Warning-file-not-found] Invalid file link: '../reference/wpf/0-9-515/microsoft-web-webview2-wpf-webview2'.
Line 95, Column 209: [Warning-file-not-found] Invalid file link: '../reference/wpf/0-9-515/microsoft-web-webview2-wpf-corewebview2creationproperties'.
Line 96, Column 42: [Warning-file-not-found] Invalid file link: '../reference/wpf/0-9-515/microsoft-web-webview2-wpf-webview2'.
Line 96, Column 134: [Warning-file-not-found] Invalid file link: '../reference/winforms/0-9-515/microsoft-web-webview2-winforms-webview2'.
Line 96, Column 313: [Warning-file-not-found] Invalid file link: '../reference/dotnet/0-9-538/microsoft-web-webview2-core-corewebview2environment'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 4a452f9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/gettingstarted/win32.md
:bulb:Suggestion
View
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/index.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/gettingstarted/win32.md

Line 2, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Host web content in your Win32 app with the Microsoft Edge WebView 2 control' is duplicated in 'webview2/gettingstarted/win32.md(2,14)', 'webview2/reference/dotnet/0-9-515-reference-webview2.md(2,14)', 'webview2/reference/win32/0-8-190-reference-webview2.md(2,14)', 'webview2/reference/win32/0-9-430-reference-webview2.md(2,14)', 'webview2/reference/win32/0-9-488-reference-webview2.md(2,14)'.... NOTE: This Suggestion will become a Warning on 1/29/21.
Line 28, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /cpp/windows/walkthrough-creating-windows-desktop-applications-cpp?view=vs-2019 NOTE: This Suggestion will become a Warning on 1/29/21.
Line 52, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /cpp/cppcx/wrl/windows-runtime-cpp-template-library-wrl?view=vs-2019 NOTE: This Suggestion will become a Warning on 1/29/21.
Line 61, Column 9: [Suggestion-alt-text-bad-value] Alt text 'Nuget' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text. NOTE: This Suggestion will become a Warning on 1/29/21.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 3558c99:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/gettingstarted/win32.md
:bulb:Suggestion
View
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/index.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/toc.yml
:white_check_mark:Succeeded

microsoft-edge/webview2/gettingstarted/win32.md

Line 2, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Host web content in your Win32 app with the Microsoft Edge WebView 2 control' is duplicated in 'webview2/gettingstarted/win32.md(2,14)', 'webview2/reference/dotnet/0-9-515-reference-webview2.md(2,14)', 'webview2/reference/win32/0-8-190-reference-webview2.md(2,14)', 'webview2/reference/win32/0-9-430-reference-webview2.md(2,14)', 'webview2/reference/win32/0-9-488-reference-webview2.md(2,14)'.... NOTE: This Suggestion will become a Warning on 1/29/21.
Line 28, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /cpp/windows/walkthrough-creating-windows-desktop-applications-cpp?view=vs-2019 NOTE: This Suggestion will become a Warning on 1/29/21.
Line 52, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /cpp/cppcx/wrl/windows-runtime-cpp-template-library-wrl?view=vs-2019 NOTE: This Suggestion will become a Warning on 1/29/21.
Line 61, Column 9: [Suggestion-alt-text-bad-value] Alt text 'Nuget' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text. NOTE: This Suggestion will become a Warning on 1/29/21.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 3063d79:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/gettingstarted/win32.md
:bulb:Suggestion
View
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/index.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/toc.yml
:white_check_mark:Succeeded

microsoft-edge/webview2/gettingstarted/win32.md

Line 2, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Host web content in your Win32 app with the Microsoft Edge WebView 2 control' is duplicated in 'webview2/gettingstarted/win32.md(2,14)', 'webview2/reference/dotnet/0-9-515-reference-webview2.md(2,14)', 'webview2/reference/win32/0-8-190-reference-webview2.md(2,14)', 'webview2/reference/win32/0-9-430-reference-webview2.md(2,14)', 'webview2/reference/win32/0-9-488-reference-webview2.md(2,14)'.... NOTE: This Suggestion will become a Warning on 1/29/21.
Line 28, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /cpp/windows/walkthrough-creating-windows-desktop-applications-cpp?view=vs-2019 NOTE: This Suggestion will become a Warning on 1/29/21.
Line 52, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /cpp/cppcx/wrl/windows-runtime-cpp-template-library-wrl?view=vs-2019 NOTE: This Suggestion will become a Warning on 1/29/21.
Line 61, Column 9: [Suggestion-alt-text-bad-value] Alt text 'Nuget' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text. NOTE: This Suggestion will become a Warning on 1/29/21.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 7645a54:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/gettingstarted/win32.md
:bulb:Suggestion
View
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/index.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/toc.yml
:white_check_mark:Succeeded

microsoft-edge/webview2/gettingstarted/win32.md

Line 2, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Host web content in your Win32 app with the Microsoft Edge WebView 2 control' is duplicated in 'webview2/gettingstarted/win32.md(2,14)', 'webview2/reference/dotnet/0-9-515-reference-webview2.md(2,14)', 'webview2/reference/win32/0-8-190-reference-webview2.md(2,14)', 'webview2/reference/win32/0-9-430-reference-webview2.md(2,14)', 'webview2/reference/win32/0-9-488-reference-webview2.md(2,14)'.... NOTE: This Suggestion will become a Warning on 1/29/21.
Line 28, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /cpp/windows/walkthrough-creating-windows-desktop-applications-cpp?view=vs-2019 NOTE: This Suggestion will become a Warning on 1/29/21.
Line 52, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: /cpp/cppcx/wrl/windows-runtime-cpp-template-library-wrl?view=vs-2019 NOTE: This Suggestion will become a Warning on 1/29/21.
Line 61, Column 9: [Suggestion-alt-text-bad-value] Alt text 'Nuget' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text. NOTE: This Suggestion will become a Warning on 1/29/21.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 820f432:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit f56d844:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/gettingstarted/win32.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/index.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 3a86818:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/gettingstarted/win32.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/index.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit b64b8d3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/gettingstarted/win32.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/index.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 7738188:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/gettingstarted/win32.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/index.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 78c4437:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/gettingstarted/win32.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/index.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit b00e41a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/gettingstarted/win32.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/index.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit dbaab97:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/gettingstarted/win32.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/index.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit f6e8bd7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/gettingstarted/win32.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/index.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded
View

microsoft-edge/webview2/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

#sign-off and merged.


Add missing fields for tournament

Add some missing fields like the number of player per team or the number of validated teams.

Why are there migrations?

Why are there migrations?

Migrations are not generated by the prod environment atm (I don't even know why) and conflict migrations are hard to handle when using a filled database.
The easiest way to solve theses problems is to commit the migrations (https://paulonteri.com/thoughts/should-you-commit-migrations).

The easiest way to solve theses problems is to commit the migrations (https://paulonteri.com/thoughts/should-you-commit-migrations).

Indeed, but migrations should only be committed between 2 production deployment, not in PRs. The review will ask for model changes, so we will have dozens of useless migrations adding, patching, reverting changes, etc.

The easiest way to solve theses problems is to commit the migrations (https://paulonteri.com/thoughts/should-you-commit-migrations).

Indeed, but migrations should only be committed between 2 production deployment, not in PRs. The review will ask for model changes, so we will have dozens of useless migrations adding, patching, reverting changes, etc.

Ok, I agree with that, that was a misconception of mine. I will commit a fix in this PR soon.

Logic-wise it all works as I'd expect it to, without tests but, you know, we can add those later.
Now it's time to see if I can nitpick some code.

Wait, actually, there's one thing wrong: you accidentally added a migration

Wait, actually, there's one thing wrong: you accidentally added a migration

Oh, yes, mb

Wait, actually, there's one thing wrong: you accidentally added a migration

Oh, yes, mb

Wait, actually it turns out they might come from the production environment?

Wait, actually, there's one thing wrong: you accidentally added a migration

Oh, yes, mb

Wait, actually it turns out they might come from the production environment? A ton of them were pushed earlier this month. Maybe we can handle that elsewhere anyways.

The migration file is the one currently in migration, yes, but the pseudo field rename should not be there, it should be commit later for the prod deployment preparation.


Improves linters setup

Description
Self-explained
Types of changes

[x] House cleaning (change at project level, like tooling revamp, refactors, etc)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (non-breaking change which improves existing functionality)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (something that would cause existing functionality to not work as expected)
[ ] Documentation (self-explained)

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b77c588). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master      #81   +/-   ##
=========================================
  Coverage          ?   96.64%
=========================================
  Files             ?        8
  Lines             ?      149
  Branches          ?        0
=========================================
  Hits              ?      144
  Misses            ?        5
  Partials          ?        0

Impacted Files
Coverage Δ

gradle_profiler_pttest/analysis_reporter.py
100.00% <100.00%> (ø)

gradle_profiler_pttest/benchmark_parser.py
100.00% <100.00%> (ø)

gradle_profiler_pttest/benchmarks_analyser.py
100.00% <100.00%> (ø)

gradle_profiler_pttest/cli_parser.py
71.42% <100.00%> (ø)

gradle_profiler_pttest/gradle_benchmark.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77c588...56c3000. Read the comment docs.


add support for making a topic as listed or unlisted similar to youtube

add support for making a topic as listed or unlisted similar to youtube https://support.google.com/youtube/answer/3127309?hl=en.

Feature
Unlisted
Private
Public

Can share URL
Yes
No
Yes

Can be added to a channel section
Yes
No
Yes

Shows up in search, related videos, and recs
No
No
Yes

Posted on your channel
No
No
Yes

Shows in Subscriber feed
No
No
Yes

All I have to tell my family members now is download ntfy app, add the server and susbscribe to whatever topics you are interested in. Will probably want to support capability to add/remove servers first - https://github.com/binwiederhier/ntfy/issues/295

While this is an interesting concept, it doesn't really fit into ntfy's model well. All interactions in the apps are topic specific. We do not log into a server or or add servers to the app. I'd have to change the paradigm to make it more server-centric.
The one appeal this would have is that I could much more easily promote the stats and announcement topics on the ntfy.sh server. For now I will close this as "wont do". Thanks for the idea.


[replay] add replay player

This PR adds a new program for playing replay: otns-replay based on PR #76
Example usage:
$ otns-replay otns_0.replay

should we include file web/site/bindata.go?

This PR neither changes the web site, or the gRPC protocol, thus no bindata.go change.


chore(*) bump to Kong 2.8.2

At this point Kong 2.8.3 has already been released / merged, so let's close this one.


How to populate and embedded array?

I have 2 structs with data like this:
type User struct {
  Pics Pic[]
}

type Pic struct {
  Id int
  UserId int64
}

Although everytime I insert an User, Each of the pics are inserted on their table everytime I find the users, pics are not populated:
var users []User
db.Limit(pagesize).Where("updated_at > ?", date).Find(&users)

Am I doing something wrong?

@javiermanzano You should use Preload(). Like this:
var users []User

db.Preload("Pics").Where("updated_at > ?", date).Limit(pagesize).Find(&users)

for _, user := range users {
    // You should have pics now
    fmt.Println(user.Pics)
}

Documented here.
Hope it helps.


Changing zoom level breaks connection knots

Describe the bug
When changing the connection zoom level, the connection lines are not rendered based on the knots:

Fixed in commit 4fbb279 and backported to 2.0.


DataPackage Viewer: check to see if README.md is returned correctly

Currently the DataPackage View will include the README.md even if the page returns a 404 status code.
e.g.
http://data.okfn.org/tools/view?url=http%3A%2F%2Fmorty.co.uk%2Fdatapackage.json

@morty great spot - another one to push down onto the underlying library https://github.com/okfn/datapackage-read - if you wouldn't mind. (It can also stay here until the fix is deployed).

This issue was moved to okfn/datapackage-read-js#2


chore: move comment to avoid chartpress problem

This apparently useless PR addresses a silly issue I experience with chartpress.
In short: every time I run chartpress it duplicates/moves data for the callbackUrl value (see screen below). I guess it doesn't like a comment next to an empty value :man_shrugging:

we've run into this before - I thought it was a ruamel.yaml version problem - it could also be that you need more than one space between the : and the # but in any case, putting it on a different line definitely fixes the issue :)

I just ran chartpress and don't see this - which version of ruamel.yaml are you using?

I was on 0.15.51. Last time I only tried to update chartpress and I already had the last version, but now I have just tried to bump ruamel and it's working :tada: (the version is 0.16.5).
I guess we can close the issue :slightly_smiling_face:


IPv6 support

🚧

Could you make this take a general list of socket options like Postgrex does?

Yes certainly, though I've not managed to get this to work with this approach or the equivilent when passing a list of options. I've tested with an application that runs both PGO and Postgrex with the same configuration. Postgrex succeeds but PGO fails. I can't immediately see any difference between how they use gen_tcp:connect so I'm not sure what the issue might be.

@tsloughter How does this look now?

@tsloughter ping :)

Oh, sorry, I forgot this wasn't the issue but an PR that was ready to go :). Will get it merged. Thanks!

I'll merge it but weird the CI isn't running.

💜


OLD: Docs update

@nicolevasilevsky Can you check whether these changes should still be done? Some old changes that were never merged.. Maybe they are in the gh-pages branch?

These should be merged

into gh-pages or master?

master, please!


RFC about read-only replica

RFC for https://github.com/neondatabase/neon/issues/769

@lubennikovaav let's close this one? I think we merged this one instead https://github.com/neondatabase/neon/pull/8546 Or do we need something from this PR?


Adding Scalar Root finding algorithm: bisect, regula falsi and ridder

Preface
I want to help adding some more module, and root finding seems a good place to start.
I am not expert at rust or scientific computing.
It's a long commit, take you time.
thank you very much.
Meta
I can cargo build the project, but I can't link amo.lib, there are a linker error 1181, I went online to find that that might be issue with Visual Studio build tool, and I fixed that, but the linker error presist, I run my test my deleting all part that required the amo.lib/complex-bessel-rs, do you know if it is a windows specific problem? Like, is it because some setting in complex-bessel-rs/build.rs that compile code only for linux system?
I will try to find some solution, and if it still does work, I will open an issue.
File
/optimize    <------------------ the optimize root folder, following scipy
    L mod.rs
    L root_scalar/    <--------- the module for scalar root finding
        L mod.rs    <----------- Base iterative root finding logic
        L bracket.rs    <------- the interface for scalar root finding with bracket
        L bisect.rs    <--------    bracket root finding algorithm: Bisect
        L regula_falsi.rs    <--    bracket root finding algorithm: regula_falsi
/test/root_scalar.rs

API
see test/root_scalar.rs to see more example of root_scalar api.
Simple example
$f(x)=(x^2+1)(x-0.5)$
// to make the solver
let solver = RootScalarSolver::<f64>::default()
    .set_rtol(None)
    .set_ftol(Some(1e-12));

// define the function to solve
fn fun(x:f64)->f64{ (x.powi(2) + 1.0_f64) * (x - 0.5_f64) }
// specify the bracket to find root
let bracket = (-10_f64,10_f64);
// specify the bracket-based root finding method
let method = BracketMethod::Ridder;

// get the result
let res: RootScalarResult<f64> = solver.solve_with_bracket(
    &fun, bracket, method
);

// short-hand method
let res = solver.bisect(&fun,bracket);

RootScalarSolver<T>
pub struct RootScalarSolver<T>
where
    T: PartialEq + PartialOrd + Display + Debug,
{
    rtol: Option<T>,
    ftol: Option<T>,
    xtol: Option<T>,
    maxiter: Option<u64>,
}

It has generic for different type of float type: f64, f32, f128..., and also might be complex number, in the future, if I could figure it out.
This is a struct that hold all the iterative root finding algorithm's termination condition, namely rtol, ftol, xtol, maxiter.
To see the detail explaination, see /optimize/root_scalar/mod.rs to find doc comment of RootScalarSolver<T>.
Implement for Float (real-domain)
impl<T> RootScalarSolver<T>
where
    T: PartialEq + PartialOrd + Display + Debug + Float + 'static,
{...

This is where the bracket-based root finding algorithm defined, since bracket-based root finding algorithm cannot be use to find complex root.
BracketMethod
#[derive(Debug,Clone, Copy)]
pub enum BracketMethod{
    Bisect,
    RegulaFalsi,
    Ridder,
    Brent, //<-- not implemented
}

The bracket-based root finding algorithms. Only applicable for real value.
RootScalarResult<T>
pub struct RootScalarResult<T>
where
    T: PartialEq + PartialOrd + Display + Debug,
{
    pub root: T,
    pub error: T,
    pub iterations: u64,
    pub function_called: u64,
    pub flag: RootScalarResultFlag,
}

Store the result of the root finding algorithm.
RootScalarResultFlag
#[derive(Debug,Clone)]
pub enum RootScalarResultFlag{
    Running,
    Success{
        rtol: bool,
        ftol: bool,
        xtol: bool,
    },
    Fail(String),
}

Store the terminate condition of the root finding algorithm
Testing Runing Result
to run only the root_scalar.rs's test.
cargo test root_scalar -- --nocapture

Running tests\root_scalar.rs (~\target\debug\deps\root_scalar-fe9a190e7d848b97.exe)

running 1 test
[Bisect]
  root :    +4.0000, error :    +0.0000, iteration :     44, no. of function called :     46, flag : Success { rtol: false, ftol: false, xtol: true }
  root :    +4.0000, error :    +0.0000, iteration :     44, no. of function called :     46, flag : Success { rtol: false, ftol: false, xtol: true }
  root :    +0.0000, error :    +0.0000, iteration :      0, no. of function called :      0, flag : Fail("Bracket must evaluate to different sign.")
  root :    +0.0000, error :    +0.0000, iteration :      0, no. of function called :      0, flag : Fail("Bracket must evaluate to different sign.")
  root :    +0.0000, error :    +0.0000, iteration :      0, no. of function called :      0, flag : Fail("Bracket must evaluated to be finite.")
[Regula Falsi]
  root :    +4.0000, error :    +0.0000, iteration :    320, no. of function called :    323, flag : Success { rtol: false, ftol: false, xtol: true }
  root :    +4.0000, error :    +0.0000, iteration :    241, no. of function called :    244, flag : Success { rtol: false, ftol: false, xtol: true }
  root :    +0.0000, error :    +0.0000, iteration :      0, no. of function called :      0, flag : Fail("Bracket must evaluate to different sign.")
  root :    +0.0000, error :    +0.0000, iteration :      0, no. of function called :      0, flag : Fail("Bracket must evaluate to different sign.")
  root :    +0.0000, error :    +0.0000, iteration :      0, no. of function called :      0, flag : Fail("Bracket must evaluated to be finite.")
[Ridder]
  root :    +4.0000, error :    +0.0000, iteration :     80, no. of function called :    164, flag : Success { rtol: false, ftol: true, xtol: false }
  root :    +4.0000, error :    +0.0000, iteration :     86, no. of function called :    176, flag : Success { rtol: false, ftol: false, xtol: true }
  root :    +0.0000, error :    +0.0000, iteration :      0, no. of function called :      0, flag : Fail("Bracket must evaluate to different sign.")
  root :    +0.0000, error :    +0.0000, iteration :      0, no. of function called :      0, flag : Fail("Bracket must evaluate to different sign.")
  root :    +0.0000, error :    +0.0000, iteration :      0, no. of function called :      0, flag : Fail("Bracket must evaluated to be finite.")
test test_root_scalar ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Codecov Report

Merging #4 (966d048) into master (8e81281) will increase coverage by 6.2%.
Report is 2 commits behind head on master.
The diff coverage is 79.3%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Files Changed
Coverage Δ

src/optimize/root_scalar/mod.rs
71.7% <71.7%> (ø)

src/optimize/root_scalar/bracket.rs
81.8% <81.8%> (ø)

src/optimize/root_scalar/regula_falsi.rs
97.8% <97.8%> (ø)

src/optimize/root_scalar/bisect.rs
100.0% <100.0%> (ø)

... and 8 files with indirect coverage changes

Heyy, thanks again for the contribution!
This is awesome! As soon as I can I'll review it.
For the windows stuff now I have some ci checks to ensure compilation, I'll try to add some other checks to ensure that tests run as well.
I'll probably be able to review everything by next weekend

As, I continue to work on it I think that I call the wrong shot by coupling the actually solving function to the solving termination criteria. I'll de-couple that later, probably after the weekedn.


Client Allocation Request for: Speedium

Client Allocation Questions
Core Information

Name: Speedium
Website / Social Media: www.speedium.network
DataCap Requested: 5TiB
Addresses to be Notarized: f1luelfcqktlgpw55cqsqieyilusqrayzxbctsqfa
Notary Requested: Rin-huang

Dear Rin-huang, we are looking for 1TiB daily. Thank you.

Dear Rin-huang, we are looking for 1TiB daily. Thank you.

looking for 1TiB daily.

Can you provide me the email of the person in charge of your company's Filecoin + project? We will contact you soon. Thanks!

@1am5UP3RasM4R10 Philipp is our notary. As per notary governance call it is preferred to handle everything with one notary so i am going to close this issue for now.

This user’s identity has been verified through filplus.storage


Add rules for the Fares v2 base implementation

After the PR # 286 was merged in May 2022.
Additional files:

fare_products.txt
fare_leg_rules.txt
fare_transfer_rules.txt
areas.txt
stop_areas.txt

Changes to existing files

routes.txt: additional network_id field
fare_rules.txt: the file becomes conditionally required

New requirement concept
Conditionally forbidden: The field or file must not be included under conditions outlined in the field or file description.
New field type
Currency amount: A decimal value indicating a currency amount. The number of decimal places is specified by ISO 4217 for the accompanying Currency code. All financial calculations should be processed as decimal, currency, or another equivalent type suitable for financial calculations depending on the programming language used to consume data. Processing currency amounts as float is discouraged due to gains or losses of money during calculations.

Hey Brian,
I also had a quick look at the acceptance test report generated by your PR (the one attached here, which I hope is accurate because I see the GH action wasn't completed).
Here are some answers to your questions:

May fare_leg_rules.txt are missing a fare_product_id. Instead, these leg rules are specifying a cost amount directly in the rules file. fare_product_id is a required field in the spec as adopted, but I'm wondering if it didn't start that way in the initial spec revision?

That's exactly it, the initial implementation didn't require fare_product_id (cc @omar-kabbani).

Most currency amounts do not specify the number of decimal places to match the ISO 4217 spec. Not sure if that should be an error? Spec seems to imply it should match.

Do you mean most currency amounts do not have the number of decimal places required? We have allocated the severity ERROR for validation of every field type so yes, an invalid currency should be an error.

I think there is a question of how we manage validation given the number of feeds that are implementing additional experimental fields.

My quick answer to this is that we should first only add rules according to what was adopted, which we believe will help agencies update their data to match the latest version of it.
Adding validation for the additional experimental fields that are widely used would be a good use case for the custom validation functionality.
That being said, having datasets being flagged invalid if they have additional fields is an issue, and it's a bit of a surprise, isn't this breaking the backward compatibility?
Is the addition of the future new types of matching in fare_leg_rules.txt or fare_transfer_rules.txt making existing data invalid? (@omar-kabbani, do you have the answer?)

Regarding currency amounts, that's correct: they do not have the number of decimal places required.
Regarding backwards compatibility, I think this is a little subtle.  Per the Guiding Principles, backwards compatibility is first and foremost about preserving backwards compatibility for feed producers.  In that sense, adding new optional fields to fare_leg_rules.txt is probably ok.  But it does make it pretty painful for feed consumers.  Ideally, changes wouldn't break existing parsers, but I don't think that's going to be possible?  Right now, to support Fares V2 as a consumer means you probably need to support the experimental spec as well.
What we do about validation is an open question.  I'd like to learn more about the plan for the incremental adoption and extension of Fares V2 (if there is a plan?).  @omar-kabbani maybe that's something I can chat with you about?

Hi @bdferris-v2, thanks for bringing this up!
I'll just add on to what @isabelle-dr mentioned:
MobilityData has published a plan for the next steps for GTFS-Fares v2 which includes adding 5 features to the specification. These features require adding optional files and fields that do not affect the way fares are modelled. We do not want to introduce any breaking changes that will break compatibility with previous GTFS datasets.
With regards to feeds not passing validation, I understand that some data producers are still using amount and currency instead of fare_product_id, so I believe that would be the main reason for validation errors.
As for the additional (experimental) fields, I did not think they would trigger errors or warnings, the validator should simply ignore them. The only case I can think of where the validator raises warnings is if the Primary Keys have changed with the addition of fields.
Would you be able to share with us a dataset that failed due to additional fields so we can investigate?
Also, we are happy to discuss things in more detail!

This has been completed, the validator has been updated to reflect changes to the Fares v2 base implementation.
We have decided not to include the changes done on fare_rules.txt and fare_attributes.txt in this issue, please see google/transit/issues/354 for additional context.


chore(ci): update Podman to 5.x in e2e tests workflows

What does this PR do?
Update the podman on ubuntu-24.04 gha runner to the 5.2.5.
Screenshot / video of UI

What issues does this PR fix or reference?
#7267

How to test this PR?

[ ] Tests are covering the bug fix or the new feature

later improvement: would be interesting to move the same lines of code to a specific separate file

Hoping to get some time for this, maybe increasing priority would be nice: https://github.com/podman-desktop/podman-desktop/issues/8959 as we already spoke about it.


Reset Frame.Scheme on each request (#366).

cc @halter73 @Tratcher @loudej

Looks good. Just waiting on a test.

:shipit:

Fixes #366.


Handle ctrl-C as keyboard input in CLI

After the recent changes to read keyboard input during the status
update loop, the handler for SIGINT sporadically stops working.
When this occurs, ctrl-C is read as normal keyboard input.

Looks good


Forcing reload on +page.server redirects

Describe the problem
I have a /login page which can either show a login form for local accounts, or hit an api server that handes oauth logins, depending on whether oauth was configured and the presence of a ?bypass_oauth=1 parameter.
Basically it goes like this:

 link navigates to /login
oauth was configured: the load function of +page.server.ts redirects to https://API_DOMAIN/auth/oauth2
oauth was bypassed or not configured: the /login page is shown as usual

and in my use case, API_DOMAIN is actually the same as the frontend origin.
But when navigating from the client (so, not on the first page load), I get client-side navigated to /auth/oauth2.
Describe the proposed solution
An optional parameter on the Redirect object (not having it on the redirect convenience function is fine to me since the use case is pretty rare) that essentially does what data-sveltekit-reload does
maybe sth like
throw new Redirect(301, "Full URL", { reload: true })

Alternatives considered
Using <a data-svelkit-reload>, but it becomes hard to ensure all links anywhere that point to /login have the correct behavior - it kind of prevents encoding the required redirection logic in the load function itself. Using a <LoginLink> component can work but unfortunately not for everything - in some cases my app calls goto on /login
Using +server.ts - not really an option in my use case since I also have a +page.svelte
Importance
would make my life easier
Additional Information
No response

Are you currently using an enhanced form? Would customising the enhanced form behaviour to navigate natively when logging in solve your issue? Something such as:
<script>
	import { enhance, applyAction } from '$app/forms';

	/** @type {import('./$types').ActionData} */
	export let form;
</script>

<form
	method="POST"
	use:enhance={({ formElement, formData, action, cancel }) => {

		return async ({ result }) => {
			// `result` is an `ActionResult` object
			if (result.type === 'redirect') {
				window.location.pathname = "/dashboard"
			} else {
				await applyAction(result);
			}
		};
	}}
>

https://kit.svelte.dev/docs/form-actions#progressive-enhancement-customising-use-enhance

is there any workaround for this as the moment ?

is there any workaround for this as the moment ?

Theoretically, you could create a beforeNavigate hook in your root layout and if the page the user is navigating to matches /login you can execute code to make it native navigation.
if (to !== '/login' && from?.pathname === '/login') {
  // hard refresh
  window.location.pathname = '/login'
}

is there any workaround for this as the moment ?

Theoretically, you could create a beforeNavigate hook in your root layout and if the page the user is navigating to matches /login you can execute code to make it a native navigation.
if (from !== '/login' && to?.pathname === '/login') {
  // native navigation
  window.location.pathname = '/login'
}

https://kit.svelte.dev/docs/modules#$app-navigation-beforenavigate

well in my case i have Form action and upon success i redirect to the route and append the response of that form request so i need something which can work on server side as window.location is for client side

to be honest i kinda want to give it a try, I started looking around the kit codebase.
from what i understand, calling server_fallback or simply native_navigation on the Redirect error case in src/runtime/client/client.js:load_route would work?
https://github.com/sveltejs/kit/blob/b2acab8374c92a20d201293cadea0360f7f37f66/packages/kit/src/runtime/client/client.js#L985-L993
like here i'd add the function call if the Redirect object has a reload property to true
i'd like to start working on a PR if there's a chance it'd be accepted

i'd like to start working on a PR if there's a chance it'd be accepted

I'm in support for it but would like to know what the other maintainers think.


Readme: Fix invalid link to "http-resource".

The link used to lead to https://github.com/fsprojects/Paket/blob/master/11 because of invalid syntax used.

Thx


rambox: unmaintain & mark as insecure

Motivation for this change
Rambox hasn't had a stable release in a while and an increasing number
of issues which is why I don't intend to use this anymore.
While taking a closer look at the source I also realized that it uses
Electron 7.2.4[1]. This is not only EOLed[2], it also contains a few
security vulnerabilities which is why I decided to mark it as insecure.
A few (most likely not all) vulnerabilities can be found by looking at
the Electron 7 changelog[3]: after 7.2.4 there were a few more releases
with security backports - mostly from Chromium. Security issues that
were found later on (and are probably exploitable on the dependency
chain of rambox) aren't listed here. I only added two issues that seemed
applicable to rambox, but I haven't researched enough to check the
other ones.
[1] https://github.com/ramboxapp/community-edition/blob/0.7.7/package.json#L70
[2] https://www.electronjs.org/docs/tutorial/support#currently-supported-versions
[3] https://www.electronjs.org/releases/stable?version=7
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

There is some work to update the Electron version (https://github.com/ramboxapp/community-edition/pull/2897), but it's not merged because it breaks Skype (https://github.com/ramboxapp/community-edition/issues/2947). I guess marking the vulnerabilities is the best Nixpkgs can do, unless the Skype issue is fixed or an active fork appears.


New insiders: extensions side bar empty

and this link is broken..

@joaomoreno Looks like extensionManagementService.getInstalled() call is not returning. Do you know why?

Same here, and once I click on the "Extension button", the VS Code starts to behave very weirdly. Git tab is empty, search tab looks weird and incorrect.
Help -> Report Issues doesn't work as well. :)
I am on the latest Insiders Build: 1.15.0-insider (3245039b4f78).

Further investigating.. I see that Shared process is broken and hence methods to shared process services are not returning. Here are the logs from Shared process

Some how #30759 broke the Shared Process which caused this.
Thanks @joaomoreno for reverting #30759 in #30923

Same here.
If I try to open "Extensions: Install Extension," I get the error Cannot read property 'getHTMLElement' of undefined

Yes there is a new insiders build with the fix. Please update to it.

Hm. It did update (or downgrade) to the previous insiders release, but I'm not seeing anything new yet. (OS X version is 3cfa565abbd6e162b7ae6f3055c231128da63df2).
Thx, I'll keep checking.

Sorry I just checked that we downgraded first (which makes sense) and span new builds with the fix. New builds are not not released and not generated for all platforms yet. Will check on that and let you know.

Today's insiders has the fix.


(Delete this issue then)

Hi rurush47,
I'm a master student at Tilburg University and I would like to contact you because I'm really interested in using this browse extension in my master thesis experiment. Would you like to collaborate? Is there any way to contact you? an e-mail?
Thanks!

Yes, of course :) Please contact me at<EMAIL_ADDRESS>


[Errno 22] Invalid argument

Describe the bug
[Errno 22] Invalid argument
use basicWorkflowWithPromptGenerator.json workflow, error when running to Prompt Generator node
To Reproduce
Use basicWorkflowWithPromptGenerator.json workflow, error when running to Prompt Generator node
Code
Traceback (most recent call last):
File "D:\SDLocal\ComfyUI_windows_portable\ComfyUI\execution.py", line 151, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "D:\SDLocal\ComfyUI_windows_portable\ComfyUI\execution.py", line 81, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "D:\SDLocal\ComfyUI_windows_portable\ComfyUI\execution.py", line 74, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "D:\SDLocal\ComfyUI_windows_portable\ComfyUI\custom_nodes\prompt-generator-comfyui\prompt_generator.py", line 284, in generate
self._generated_prompts = get_generated_texts(
File "D:\SDLocal\ComfyUI_windows_portable\ComfyUI\custom_nodes\prompt-generator-comfyui\generator\generate.py", line 106, in get_generated_texts
generated_text = preprocess(prompt + result, preprocess_mode)
File "D:\SDLocal\ComfyUI_windows_portable\python_embeded\lib\site-packages\preprocess.py", line 363, in preprocess
contentType = registry.getContentType(infile)
File "D:\SDLocal\ComfyUI_windows_portable\python_embeded\lib\site-packages\preprocess.py", line 803, in getContentType
content = open(path, 'rb').read()
OSError: [Errno 22] Invalid argument: '((masterpiece, best quality, ultra detailed)), illustration, digital art, 1girl, solo, ((stunningly beautiful)), ((upper body portrait)), by Stanley Artgerm Lau, (by Loimu), nami  with black hair and blue eye makeup mernie (honkai star rail yuuutsu ), smile\n'
Operating System
Windows
** Python Version**
Python version: 3.10.9
** Transformers and optimum packages versions **
transformers-4.39.2
optimum-1.18.0

Hello, thanks for reporting. I have added updates. Please update the node and let me know if the issue is going on.

Thank you for fixing this so quickly!


/v1/message/search POST - no consumes type set

On about line 561 of agent-api-public-deprecated.yaml, there should be:
      consumes:
        - application/json

.. in order to be consistent with all the other api swagger definitions.  This is causing problems for JAX-RS as it doesn't know how to marshall the body object for me.
thanks
Rob

👍


remove zafira_report_emails property and related functionality

As only qps-pipeline can notify owners we can remove above property and apropriate code from zafira client.
https://github.com/qaprosoft/qps-pipeline/issues/30

implemented in https://github.com/qaprosoft/zafira/tree/demo

closed https://github.com/qaprosoft/zafira/pull/878


[ISSUE #2321] In the  implementation of the dashboarduserservice interface, the database access in the loop is optimized.

[ISSUE #2321] In the  implementation of the dashboarduserservice interface, the database access in the loop is optimized.

Codecov Report

Merging #2527 (f819b64) into master (3359b3c) will decrease coverage by 0.32%.
The diff coverage is 84.00%.

@@             Coverage Diff              @@
##             master    #2527      +/-   ##
============================================
- Coverage     60.23%   59.91%   -0.33%
+ Complexity     4190     4158      -32
============================================
  Files           651      651
  Lines         18334    18344      +10
  Branches       1658     1658
============================================
- Hits          11043    10990      -53
- Misses         6451     6511      +60
- Partials        840      843       +3

Impacted Files
Coverage Δ

...u/admin/service/impl/DashboardUserServiceImpl.java
85.55% <84.00%> (-0.70%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
61.38% <0.00%> (-11.89%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

...ache/shenyu/admin/utils/PluginHandleH2Trigger.java
63.63% <0.00%> (-9.10%)
:arrow_down:

...henyu/admin/service/impl/UpstreamCheckService.java
54.40% <0.00%> (-8.00%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
56.84% <0.00%> (-7.37%)
:arrow_down:

.../apache/shenyu/admin/model/dto/BatchCommonDTO.java
50.00% <0.00%> (-7.15%)
:arrow_down:

...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java
57.14% <0.00%> (-7.15%)
:arrow_down:

...org/apache/shenyu/admin/model/dto/AuthPathDTO.java
58.82% <0.00%> (-5.89%)
:arrow_down:

...in/response/strategy/NettyClientMessageWriter.java
69.56% <0.00%> (-4.35%)
:arrow_down:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3359b3c...f819b64. Read the comment docs.


Event recorder is broken for CertificateSigningRequests controller

Describe the bug:
There seems to be an issue with certifcate-signing-requests controller on latest master, where throwing any event, i.e here results in an error:
E0321 19:03:46.694477       1 event.go:332] Could not construct reference to: '&v1.CertificateSigningRequest{<redacted>}' due to: 'no kind is registered for the type v1.CertificateSigningRequest in scheme "pkg/runtime/scheme.go:100"'. Will not report event: 'Normal' 'WaitingApproval' 'Waiting for the Approved condition before issuing'

We don't test that particular part, but I deployed manually and saw that this error was not present in cert-manager v1.7.1.
Perhaps this is an upstream bug with one of our updated kube libraries- I would have thought that the CertificateSigningRequest API should have been part of the default schema.
We should:

fix the bug
add some tests for pkg/controller/certificatesigningrequests/sync.go to catch issues like this

Environment details::

Kubernetes version:
Cloud-provider/provisioner:
cert-manager version: latest master from cbf6d8720dab8c6f70303aa15d19f7b68974f3e9
Install method: e.g. helm/static manifests

/kind bug

The error seems to be thrown from here so must be to do with the scheme passed to the recorder.

I see that currently we set up recorder's scheme here and pass a scheme that is runtime.NewScheme()](https://github.com/kubernetes/apimachinery/blob/master/pkg/runtime/scheme.go#L91) with cert-manager scheme and gateway scheme on top.
It looks like previously we were using client-go scheme which explicitly registers core types


⚠ Secret Website 3 has degraded performance

In 76b06ef, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2400 ms

Resolved: Secret Website 3 performance has improved in c2eac4b.


Application Gateway waf DRS 2.1 preview ruleset has the rule 942430 active

DRS 2.1 preview ruleset has the rule 942430 active even said to be deactivated by default in the document.
The document:  https://learn.microsoft.com/en-us/azure/web-application-firewall/afds/waf-front-door-drs?tabs=drs21#disabled-rules

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 079888f6-188c-1bb9-0516-bd52ad0f287e
Version Independent ID: 1971c541-4019-f620-b57b-8cfd5acf87a1
Content: CRS rule groups and rules - Azure Web Application Firewall
Content Source: articles/web-application-firewall/ag/application-gateway-crs-rulegroups-rules.md
Service: web-application-firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

@1konna Thanks for your feedback. We shall review this and get back to you soon

@1konna I created a new WAF Policy and I can see the rule 942430 being disabled by default only.

It appears you are referring to an isolated scenario for your specific case.
In this case we request you to please post your question on Microsoft Q&A and other forums , we have our engineers and others who are monitoring them and will be happy to help .


Invalid System Name in Cortx Onboarding

In the Onboarding Guide number 2, an image is shown to enter "opensource ova" as System Name. However, it seems that any name with spaces are considered invalid.
Is there any reason for such validations? If so, perhaps the image should be changed?

cc @kupranay


OpenZipkin Docker image needs upgrading Java opensdk

Looking at the Docker layers.
"Image Layers"
Scanners are detecting vulnerablities on docker image because of Java 15.   I'd have to remove it or look for an alternative Tracing solution.
Plugin Output:
The following Java JRE installation is unsupported :
Path              : /var/lib/docker/overlay2/e5359f7882becb7615e423493538755a692dc00ec542285914111a0a06e072a0/diff/usr/lib/jvm/java-15-openjdk
Installed version : 1.15.0_5_
Latest versions   : 1.11.x / 1.17.x / 1.18.x
Support dates     : 2021-03-01 (end of Premier Support)
Can this be updated from Java 15 to 17?

Ping @llinder
On Thu, 22 Sept 2022, 22:16 Dan Idoux, @.***> wrote:

Looking at the Docker layers.
"Image Layers"
https://hub.docker.com/layers/openzipkin/zipkin/latest/images/sha256-8a0fb7d6871c9d617b2e951b629f94b33affb8aa039110a69f3d466afd3e2d6b?context=explore
Scanners are detecting vulnerablities on docker image because of Java 15.
I'd have to remove it or look for an alternative Tracing solution.
Plugin Output:
The following Java JRE installation is unsupported :
Path :
/var/lib/docker/overlay2/e5359f7882becb7615e423493538755a692dc00ec542285914111a0a06e072a0/diff/usr/lib/jvm/java-15-openjdk
Installed version : 1.15.0_5_
Latest versions : 1.11.x / 1.17.x / 1.18.x
Support dates : 2021-03-01 (end of Premier Support)
Can this be updated from Java 15 to 17?
—
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/issues/3475, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXOYARSITCYS4A3B54Z2B3V7S5AZANCNFSM6AAAAAAQTMS5GM
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Upgrading to Java 17 makes sense. Not sure if it will be seamless but I will look for time to give it a try.

Any update on this?

zipkin is all the latest things lately


Document API methods in schema.yaml

Many methods don't have proper documentation in the schema.yaml. I tend to just live edit these in the online swagger editor and then copy the yaml back https://editor.swagger.io/

Hi! I tried adding a documentation https://github.com/MasonEgger/digitalocean-classroom/pull/11, I'm new to hacktoberfest, let me know if it is right!

Moved to drf_spectacular, this is no longer relevant. Will open relevant issues needed


Fix ordering of template-pcuic in cachedMake

Is this necessary?  I have basically no idea what I'm doing here...

I don't think that erasure depends on template-pcuic, only the plugins should.
But if it works better this way for some compilations, we can merge.

It didn't used to, but now it does.
https://github.com/MetaCoq/metacoq/blob/ec018f3766022bcf60a4b7f9a1eace171bc25c40/erasure/theories/Typed/Extraction.v#L16
This is what was causing all the issues with the nix CI failing.


Script for automatically "smoke testing" against a set of libraries, looking for regressions.

https://github.com/bcoe/nyc/pull/108#issuecomment-167260866
I think this could be an awesome general purpose module. My thoughts:

It needs a simple config file that lists the projects that depend on the one you want to "smoke test".
Mimic .travis.yml for configuring scripts (just the script names from the travis Build Lifecyle, not all their config options).
The config file would need to point to the repository and branch to clone.
The module would clone each individual downstream dependent in a temp directory and run the scripts described above, npm linking the module under test.
If there are any failures, it will open the temp folder in your Finder/File Explorer, and list the failing dependents (maybe deleting the folders of passing dependents).

Folder structure:
some/temp/dir/
   downstream-dependent-1/
     ...
   downstream-dependent-2/
     ...

// @bcoe @novemberborn
I think we have a need for something like this for AVA as well.
// @sindresorhus @vdemedes

:+1: We should definitely have this for AVA. I currently do it manually once in awhile and before a release.

Prior art: https://github.com/bahmutov/dont-break // @bahmutov

Cool. Let's try using that and see how it goes.

I will be happy to help

@jamestalmage I like this idea, and I could see it being a useful hosted service like travis :+1:
I've only thought about it a bit, but some things I'd like to be able to do:

run another test-suite with an arbitrary library linked in against it (the library you're testing).
it would be nice to be able to assert to CLI output.
it would be nice to be able to assert that a file exists, and that it has certain content in it.
it would be nice to be able to assert that an HTML, JSON, or XML file has specific fields.

@bcoe - instead of building all that in, what if the config file just added a validate field that pointed to a script that was passed the output directory of the automated run?

I'm cleaning up some old issues.  I think this is a good idea, but I feel like this is outside the scope of nyc.  Maybe this belongs in https://github.com/nodejs/tooling/issues instead?  Could we leverage dont-break for this (either as a dependency or by contributing required features to dont-break)?


Portrait fade incorrect

in 2019.10f2 in portraits that are fading between two states but not for the first time fade from fully visible to fully transparent.
Can be easily observed in the Conversation or Sherlock scenes

The issue appears to be due to a change in UI.Image behaviour in 2019.10f2 and has already been reported here

Also occurs on the Character Image on the say dialog.
The error only presents when changing the sprite directly on an image that already had one. Looks like some internal cache is not being invalidated. Cycling active doesn't fix it, nor does calling SetNativeSize, nor using overrideSprite

Above PR, fixes some of the issues by using overrideSprite exclusively. There is still an issue with the fade out behaviour when the user rapidly forces them to end early.


Better status integration during mutagen sync flush, especially on start

When people try out ddev config --mutagen-enabled for the first time, there can be a delay during start that causes them to give up because they think nothing's happening. @xenoscopic suggests parsing or otherwise passing on the output of mutagen sync monitor <syncname>, which should really help people to understand.

I agree with that - especially the first ddev start feels really slow.

Even a message: Mutagen enabled, syncing first time, please wait would help ;)


Support tabs for viewdock

This is partially taken into account as the Container struct in ViewDock support having more than one Dock. What needs to be implemented is dragging and rendering support for this. Some people have done similar things for imgui so might be worth investigating that also. Still the viewdock should be imgui independent.

Implemented


Jobs archived placeholders with job name not works as intended

*Description of issue:
Hello, i'm having some trouble using your placeholderapi integrations, in my opinion the wiki around isn't really a "goto" i couldn't wrap my head around it atleast, i wanna show archived jobs stats when the player isn't a part of the job any longer but still has xp, however this isn't working, i also tried the /jobs placeholders parse - nothing works for me :/

Server Type (Spigot/Paperspigot/etc): Purpur
Server Version (using /ver): 1.16.4 (build-939)
Jobs version: I tried both on latest aswell as on 4.16.3
Relevant plugins (Delete if this isn't needed):
PlaceholderAPI
DeluxeMenus

@montlikadani Is there a place where i can download Dev builds? or do i need to wait 2-3 months before a new release?

@montlikadani Is there a place where i can download Dev builds? or do i need to wait 2-3 months before a new release?

You can mention me on discord, and I'll upload the file with this fix.

You can mention me on discord, and I'll upload the file with this fix.


fixing resource links

fix resource section links for side nav
I got rid of usage of guideline, do we need this section?

We don't for now


HTML select tag with Bootstrap 4 Beta has the lower part of some letters like "gqpy"truncated in MS Windows?

Operating system and version: Windows 10 or 7, standard DPI no scaling.
Browser: FF, Chrome, Edge, IE
Demo of the bug: https://codepen.io/zijianhuang/pen/RLBZRp

The same page works well in FF, Chrome, Safari on iPad, and Chrome and FF on Android tablets.
The same page but with Bootstrap 3.3.7 works well in browser on MS Windows.

duplicate #23347
fix in #24199

Bootstrap 4 Alpha 6 does not have this problem. So I am looking forward to the release of Beta 2, while at this stage I don't want to have a local copy of the fix at #24199.


Draft plain language blog post

@eelzi-ONRR @AlexandracmONRR @lpgoldstein @Maroyafaied
This first draft is ready for review and can be found here; https://doimspp.sharepoint.com/:w:/r/sites/NRRD/Shared Documents/General/Blog/In Progress/plain language on onrr.gov.docx?d=wcb27cb5231bf4128a92dec9e0905daf9&csf=1&web=1&e=Sd3gBJ
This post is about coordinating with SMEs and rewriting in plain language. I couldn't talk about plain language without going through our coordination process with the SMEs.
I have some questions/thoughts already in the comments for feedback.
I also went though and reduced reading levels for each section as much as I could (reading levels in red type).
The images make the document long, but you can open the navigation pane to jump around easier.

This article is great! My edits are in tracked changes and I have left a few comments for your consideration.
Let me know if you have any questions or comments on my feedback.
Best,
Alex

@cthomasONRR love the post. It will be a great reference for us the next time we need to go through the process or share with colleagues and interns who are interested in doing something similar. Everyone should know how to do this.

@cthomasONRR This is so good! I made a couple minor suggestions, but I also think it's great as is!

@cthomasONRR Great blog! I left two minor comments/suggestions.

I have everyone's comments/suggestions incorporated. This is ready to publish after USWDS blog :) Thanks for everyone's help!


= and <= considered as setters, allow only one arguments, unlike > and <

>= and <= ends with =  are considered as setters. This comes from https://github.com/crystal-lang/crystal/blob/1c8a41e0341891d8295f589fe29c97e36fa25c56/src/compiler/crystal/syntax/parser.cr#L3519, which is aimed to exclude assigns from having more than one argument.
If there are the only exceptions, they can be added to the condition to exclude them.

IMO < and > and the rest of the binary operators should also only have exactly one argument parameter, and we shouldn't allow different arities just because the function call syntax is available to them.

It can be useful in a case where __FILE__ and/or __LINE__ are used, for example in a DSL for debug purposes, like:
def <(other, file = __FILE__, line = __LINE__)
  ...
end

There is no disadvantage to allow this. At the end, there are just regular methods like others.

I think restricting the language for no reason isn't good. I think we should revert all those PRs

I agree that unnecessary restrictions should be avoided. But I think for actual setters this is good because it avoids confusion when you can define a method but not actually call it with the usual syntax.
This is also realted to #7707 which would be a bit weird if a setter accepts multiple arguments.

Can this ule be enough in this case? "If the name[-2] char (before =) is not a number/letter, it is not a setter".
The method to use will be Char#alphanumeric?. Then, the condition with name != "[]=" could be removed.

Nah, you can do foo.=(a, b, c). So why restrict it?

That call is actually a syntax error:
foo.=(a, b, c) # Error: expecting any of these tokens: IDENT, CONST, +, -, *, /, //, %, |, &, ^, ~, !, **, <<, <, <=, ==, !=, =~, !~, >>, >, >=, <=>, ===, [], []=, []?, [, &+, &-, &*, &** (not '=')

We could probably make that compile and lift the parameter count restriction on setter methods.
But would it really help anything?
I understand the main reason for #6324 (and what caused me to open #5856) is conciseness and user-happiness.
If you define a method def foo(a, b); end you would expect to call it like foo(1, 2). Apply the same to foo= and it doesn't work. Neither does the even more common setter syntax foo = 1, 2.
If it only worked as somewhat obscure foo.=(1, 2) I wouldn't expect anyone to think of using that.
A better solution is to directly produce an error when you define a setter method with more than one parameter. It just tells you that it won't work.

Oh, sorry, I mean foo.bar=(a, b, c). That's a setter and without trying it I'm pretty sure that compiles just fine.
Whether it's useful or not is subjective. But there's no reason to forbid it.

Nope, it triggers an unterminated parenthesized expression because parenthesis in a setter call is parsed as expressions, not as arguments. So this is equivalent to foo.bar= (a, b, c).
I also tried a full example it with 0.25.1 which was the last version before #6324 was merged and it didn't work back then either.

Cool! So this is working like in Ruby :-)
Okay... so let's say you define a setter with multiple arguments and that compiles/parses fine. But then you can't call it. So what's the point of defining it in any case?
So the question is: why do we need to proactively forbid it if it's not causing any issues?
Note that def foo=(a, b, c) in Ruby is not a syntax error... though in Ruby you can then do send(:foo=, 1, 2, 3).
I guess I don't see the point of limiting this in the parser if it's already limited on the call side, that's what I'm saying.


Fix golangci-lint on master

countNewlines was unused (intentionally?)

It was unused intentionally though it should be a port of packages interface so rename it please with CapitalFirstLetter also if you feel like it you can rewrite as per comment in it

It was unused intentionally though it should be a port of packages interface so rename it please with CapitalFirstLetter also if you feel like it you can rewrite as per comment in it

Ok, I've done that


Adds Secret Network testnet config, and more mainnet endpoints

@levackt rather than submit a new PR after this. Can you update yours to remove roninventures API's from testnet and mainnet? Thanks!

No problem, done


Fuse main log addition

Summary of changes
This pull request includes following changes or fixes.

Fix of issue #403
Added warning message when fuse main function returns an error code.

Description
This change is needed to be able to track an error on fuse_main in case it happens.
Fixes #403
Type of change

New feature: Addition of warning message to show error code returned by fuse_main function.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have confirmed my fix is effective or that my feature works

@piste-jp-ibm I have seen that the Build for Debian9 is failing since some index files are not able to be downloaded during the validation process.

Do you know how can I solve this issue?

I have seen that the Build for Debian9 is failing since some index files are not able to be downloaded during the validation process.

It looks debian9 is little bit old. Need to consider to move to debian11 instead. But, as you know, I'm not an official owner of this project, I believe your team need to handle such kind of operations for this project.
Of course, I can assist your team. But I don't have enough time to manage this project as I did before.

I have seen that the Build for Debian9 is failing since some index files are not able to be downloaded during the validation process.

It looks debian9 is little bit old. Need to consider to move to debian11 instead. But, as you know, I'm not an official owner of this project, I believe your team needs to handle such kind of operations for this project.
Of course, I can assist your team. But I don't have enough time to manage this project as I did before.

@piste-jp-ibm I also think that we should change it to Debian11 as you are commenting.
@juliocelon Could we work on this item together?
Regards

@piste-jp-ibm I also think that we should change it to Debian11 as you are commenting.

The build check except CentOS7/8 is optional. So it is not required for merging the change (when I'm managing this repository at least).
I recommend that you just remove Debian9 check build from the tree.

@piste-jp-ibm, all comments were addressed.

Message example:
This is how the warning will be shown on ltfs.log:
[root@miller log]# grep 14123W ltfs.log | tail -n 1
2023-06-19T17:33:19.980700-06:00 miller ltfs[1819615]: 1bc3df LTFS14123W The main function of FUSE returned error (1).

Message example:
This is how the warning will be shown on ltfs.log when LE is requested to be started:
[root@miller log]# grep 14123W ltfs.log | tail -n 1
2023-06-19T17:33:19.980700-06:00 miller ltfs[1819615]: 1bc3df LTFS14123W The main function of FUSE returned error (1).

I assume "1bc3df" will have a meaning under the FUSE return code spec. Right?

Message example:
This is how the warning will be shown on ltfs.log when LE is requested to be started:
[root@miller log]# grep 14123W ltfs.log | tail -n 1
2023-06-19T17:33:19.980700-06:00 miller ltfs[1819615]: 1bc3df LTFS14123W The main function of FUSE returned error (1).

I assume "1bc3df" will have a meaning under the FUSE return code spec. Right?

It is just the thread id from where the message was show.

@juliocelon , @perezle
One of you need to merge this into the correct branch. At this time, v2.4-stable is the branch for IBM products. (Please use Squash and merge for keep the branch clean. Away from really tiny meaningless commits like Fix typos.)

@juliocelon , @perezle
It looks this PR is opened against the master branch. You have 2 options.

Merge this to the master with Squash and merge and then cherry-pick this to the  v2.4-stable branch
Reject this and ask open another new PR against the v2.4-stable branch. After that merge the new one to the  v2.4-stable branch and then cherry-pick to the master branch

@juliocelon , @perezle
It looks this PR is opened against the master branch. You have 2 options.

Merge this to the master with Squash and merge and then cherry-pick this to the  v2.4-stable branch
Reject this and ask open another new PR against the v2.4-stable branch. After that merge the new one to the  v2.4-stable branch and then cherry-pick to the master branch

Thanks, Abe-San, we will take option 1.

Merge this to the master with Squash and merge and then cherry-pick this to the  v2.4-stable branch


Add a new age-calc-project

Describe the project you want to add with tech stack
Wants to add a age calculator responsive component in front-end folder
Please assign  me this task
Expected behavior

Screenshots (optional)

Additional context (optional )

Please assign this issue to me, I would like to work on this issue

Hey @pranjay-poddar  please assing me this


Update maternity: added SPL exceptions

Also removed old markdown

Closing in favour of https://github.com/alphagov/smart-answers/pull/1528


improve type miss-match error messages

fixes https://github.com/edgedb/edgedb-go/issues/5
This change adds the data structure field path to type miss-match error messages. An example error message would look like:
expected mypackage.MyType.path.to.field to be int64, got int

This change is based on https://github.com/edgedb/edgedb-go/pull/72. WIP until upstream is merged.

This change is based on https://github.com/edgedb/edgedb-go/pull/72. WIP until upstream is merged.


fix(next-urql): avoid a redundant copy of the urql-client

Resolves #2524
Summary
In next-urql we have three flows, two of which are on the server and one of which is on the client.
Server
First and foremost we have the classic getInitialProps, the automated way of handling data, this is the one that runs two passes on the server with react-ssr-prepass. It's our way of passing the urql-client from getInitialProps to be used for renderToString, code located here this first pass builds up the cache so we can use it during the renderToString pass. After the state is JSON.stringified and the client is ignored thanks to a toJSON: () => null.
Secondly we have the getXProps methods, which we documented is a self-serve solution as we can't easily intervene in these functions.
Both of the above don't rely on the global variable set in initUrqlClient as we always reset it when reaching that code-path.
Client
This is where stuff gets a bit more complicated and I can understand the reason why we went with the approach of sharing a client but reevaluating it, we should get rid off it so people won't fall into this as the issue outlines, we aren't offering a choice. I would advise people that want this behavior to wrap _app in withUrqlClient and people who don't want this behavior to do it on a page-basis.
Set of changes

remove global client var

As @kitten pointed out in #2524 it's intended behavior, we can reopen this when we want to do a major and not support this anymore.


How do I get non-HTML encoded output?

I'm running ecto with the following code  and it's producing  html encoded output.  Is there any way to force non-encoded?
...
(async () => {
  const filePath = _path.join(this.project.path, path)
  const engineName = this.ecto.getEngineByFilePath(filePath)
  try {
    const source = await fs.promises.readFile(filePath, "utf8")
    const content = await this.ecto.render(source, {path: this.project.path, lists: this.project.lists}, engineName)
    this.project.copyToClipboard(content, `${name} copied to clipboard!`)
  } catch (err) {
    console.log(`Error copying ${name} to clipboard`, err)
  }
})()
...

The template...
# {{path}}

{{#lists}}
## {{name}}
{{/lists}}

The output...
# /Users/jesse/projects/imdone-plugins-dev

## What's Due?
## NOTE
## TODO
## DOING
## DONE
## Recently Completed

@piascikj - by default it does do html encoding. One thing you could do us un-encode it after it is rendered. I can also look at a way to remove the html encoding if needed but it would take longer.

@piascikj - fix should be done and released today. Closing this down so we do not do the escape anymore.

@piascikj this should be fixed on the latest release. https://github.com/jaredwray/ecto/releases/tag/v1.1.3


Add support for Decimal in Pydantic and SQLAlchemy

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the SQLModel documentation, with the integrated search.
[X] I already searched in Google "How to X in SQLModel" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to SQLModel but to Pydantic.
[X] I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
class City(SQLModel, table=True):
    id: Optional[int] = Field(default=None, primary_key=True)  # pylint: disable=invalid-name
    name: str = Field(nullable=False, max_length=150, index=False)
    population: Optional[int] = Field(default=None, index=False)
    latitude: condecimal(max_digits=13, decimal_places=10) = Field(nullable=False, index=False)
    longitude: condecimal(max_digits=13, decimal_places=10) = Field(nullable=False, index=False)

Description
When setting max_digits and decimal_places to condecimal these are ignored.
The SQL CREATE TABLE resulting from the previous model city definition results in:
CREATE TABLE city (
	id INTEGER AUTO_INCREMENT,
	name VARCHAR(150) NOT NULL,
	population INTEGER,
	latitude NUMERIC NOT NULL,
	longitude NUMERIC NOT NULL,
	PRIMARY KEY (id)
)

So latitude and longitude are created with default parameters max_digits = 10 and decimal_places = 0.
Operating System
Linux
Operating System Details
Ubuntu 18.04
SQLModel Version
0.0.4
Python Version
3.7.11
Additional Context
This is my requirements.txt:
fastapi==0.68.1
uvicorn==0.15.0
python-multipart==0.0.5
pydantic==1.8.2
pymysql==1.0.2
python-jose[cryptography]
passlib
starlette-json
bcrypt
sqlmodel==0.0.4

I submitted a PR https://github.com/tiangolo/sqlmodel/pull/103 to address this. Pydantic arguments needed to be mapped to sqlalchemy's for that type.

Thanks for the feedback @roomm! :nerd_face:
This was added in @robcxyz's PR #103, it is now included in the (just released) SQLModel 0.0.5 :tada:


Add DateTime Delta Operation

Adds DateTime Delta operations.
This allows to calculate a new DateTime given an input DateTime and the amount of time passed / before the input DateTime.
For example:
Input: 20/02/2024 13:36:00
Difference: +0.00:01:00
Output: 20/02/2024 13:37:00

I've gone back to this PR half a dozen times and, umming and erring as to whether to approve it or not.  The operator works (apart from a few linting issues caught by eslint).  The parsing of dates is normal and supports a wide variety of formats.
My issue is with the 'delta' argument.  It is very brittle and needs to be in that specific format.  I wonder if we could replace it with a better format?  I can't find any great examples online to use.  The 'moment' library accepts partial times (e.g. 12:13:14) but parses them to the current day, which isn't useful.
I'm open to suggestions / opposition, but I don't think the current format is suitable.  Some options off the top of my head:

A time period like "15 seconds", "23 minutes" is used by some libraries.
Input seconds (e.g. 86400 for a day).
Enter in a string and it's format (e.g. '00:10:22' and 'hh:mm:ss').

Hey, thanks for input.
I understand what you are saying, the delta parameter is indeed quite specific, but I think it's the best way to represent this operation.
What if instead of delta being a string, I'll make a textbox for each time unit (one for days, hours, minutes, seconds, and if we add or substract time). That way it will be more obvious and less brittle, but still keeps the format.
If not, I'm open to implement other changes. Can you give an example of time period? can this be like "5 hours, 32 minutes and 3 seconds?"

I like your idea of separating out the time units into each individual text box!  That feels like a way better solution.  ❤

Yell when this is ready to re-review :)

Hey, I think it's ready :)


Fixes to timers, add timer system test

Apparently Jenkins runs on ancient ubuntu, which has clang3.6 which has the auto-lambda problems.