Project Tools

Addressing #72 and #40

poetry added as a package and Venv manager
Set up Auto Tests
Added Examples Placeholder
Added CONTRIBUTING.md guide
Added CI/CD pipeline with GitHub
Added black for code formatting
Added ruff for Linting
Added autotests using pytest

TODO: PyTests are blocked in pre-commit run yet. But can easily be activated.

@taranjeet looking for your feedback. If we want to adapt these changes, I can further work on it.
docs feature can easily added with few hours of work.

POETRY is an emerging Project and Environment manager and is being adopted by python developers.
Read the below article on comparisons.
https://medium.com/towards-data-science/poetry-a-better-way-to-manage-python-dependencies-bd7b5f1eab25

@cachho : can you start taking up this PR and collaborate with @amjadraza to get this merged.
we should definitely split the PR and right now lets start with adding contributing guidelines, and then a proper linting setup.
we can focus on next items post this.

I suggest migrating to the POETRY environment and package manager as a first step.

@amjadraza : @deshraj has raised a PR: https://github.com/embedchain/embedchain/pull/208
Both of you are trying to solve something similar, so its better to collaborate and distribute task accordingly.
let me know if you need help in any planning or collaborating. Happy to setup a call as well.

Hey @amjadraza, lets split the work in a way that we are not stepping on each other's toes here.
Can you please update your PR to have the following changes only (I will take care of the rest in my PR):

Issue template
CI/CD configuration
PR template
Pre-commit hook

And then I will take care of:

Adding black
Adding ruff

We can work on adding poetry in a follow up PR.

Hey @amjadraza, can you please update us if you are going to work on this feature? If you don't have bandwidth, thats totally fine. We will pick changes from your PR and incorporate. In any case, please let us know. Thanks!

@deshraj thanks, sorry was busy in family stuff.
Your plan looks alright. Let us go step by step.
Thanks

Closing this PR since I believe we have added all the things from this PR from smaller follow up PRs.
Thanks a lot @amjadraza for taking initiative on this.


this code doesn't work on Azure App Service

I am trying to make this work and it doesn't seem to be working on Azure App service
we get this error on Line 80 - and this error seems like is related to Azure AD
Any guidance is very much appreciated.
"ExceptionMessage": "Error HRESULT E_FAIL has been returned from a call to a COM component.",
       "ExceptionType": "System.Runtime.InteropServices.COMException",
       "StackTrace": "   at Microsoft.IdentityModel.Clients.ActiveDirectory.Internal.WebUI.<AcquireAuthorizationAsync>d__12.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at Microsoft.IdentityModel.Clients.ActiveDirectory.AcquireTokenInteractiveHandler.<AcquireAuthorizationAsync>d__10.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at Microsoft.IdentityModel.Clients.ActiveDirectory.AcquireTokenInteractiveHandler.<PreTokenRequest>d__9.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)\r\n   at Microsoft.IdentityModel.Clients.ActiveDirectory.AcquireTokenHandlerBase.<RunAsync>d__57.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at Microsoft.IdentityModel.Clients.ActiveDirectory.AuthenticationContext.<AcquireTokenCommonAsync>d__39.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at Microsoft.IdentityModel.Clients.ActiveDirectory.AuthenticationContext.<AcquireTokenAsync>d__28.MoveNext()"

Hi,
I think the code uses AAD interactive authentication which is not designed for an app service. You should edit it to use AAD Service Principal authentication. See https://docs.microsoft.com/en-us/azure/media-services/media-services-dotnet-get-started-with-aad

thank you Xavier for quick response. That's one of the thing I was looking for too. Here is what is suggested in the article.
var tokenCredentials = new AzureAdTokenCredentials("{YOUR Azure AD TENANT DOMAIN HERE}",
                            new AzureAdClientCertificate("{YOUR CLIENT ID HERE}", "{YOUR CLIENT CERTIFICATE THUMBPRINT}"),
                            AzureEnvironments.AzureCloudEnvironment);

the problem is that I don't see any way I could get the Client certificate thumbprint for the Service Principal. It all happens behind the scene.. I don't know why AMS team made this such a herculean task.

There is another way to use Service principal. You can pass the client id and secret.
var tokenCredentials = new AzureAdTokenCredentials("{YOUR Azure AD TENANT DOMAIN HERE}",
new AzureAdClientSymmetricKey("{YOUR CLIENT ID HERE}", "{YOUR CLIENT SECRET}"),
AzureEnvironments.AzureCloudEnvironment);
var tokenProvider = new AzureAdTokenProvider(tokenCredentials);
If you are using Windows, you can test the secret id and secret with AMSE http://aka.ms/amse


Efficient hint computation for bls curves

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Testing
[ ] Other (please describe):

What is the current behavior?
Roots are computed with generic nth_root(x) function, which takes ~2s to compute all required hints for BLS curve.

What is the new behavior?

By exploiting the group structure and clearing any 27th root of unity (instead of just primitive) all roots are now being computed by simple modular inverse exponentiations. This substantially improves the efficiency of hints computation.
Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

Perfect
Thank you very much!


Improve payload documentation

What's needed?
Extend the documentation for the payload parameter as shown below:

Creates a new dispatch with the specified payload.
Note: The payload must conform to the following constraints:

Maximum nesting depth of 5. Payloads with structures nested deeper than this will be rejected.

Payloads must be valid according to the JSON structure.
*/

Proposed solution
message Dispatch {
  // ...

  // The dispatch payload.
+  //
+  // Note!!!
+  //     The payload field allows for flexible JSON data to be associated with this dispatch.
+  //     The payload must adhere to the following constraints:
+  //      - Maximum JSON nesting depth: 5 levels.
+  //      - The data should not contain executable code or scripts.
+  //      - Ensure all data is properly sanitized and encoded.
+  //      - The total size of the payload should not exceed 50 KB.
  google.protobuf.Struct payload = 11;

Use cases
No response
Alternatives and workarounds
No response
Additional context
No response

I can see adding size limits being useful to avoid resources over-usage, but any particular reason for adding a nesting limit?
Also it would be probably good to be more clear if these are just guidelines or if the server will reject requests not following these rules. In particular the "data is properly sanitized and encoded" seems not implementable in the server side, as the payload will be obscure to the server.
Also nitpick, maybe we shouldn't talk about JSON in this context, it is a Struct in protobuf lingo. Related to that, the 50K limit is in protobuf wire format or do you expect the server to actually convert it to JSON and take the size of the JSON text?

I can see adding size limits being useful to avoid resources over-usage, but any particular reason for adding a nesting limit?

Well if the nesting is infinite it would take infinite time to expand it. I'd like to avoid a situation where this is used for some kind of attack.


WIP: Create job schedule

Adds UI elements to choose between "run now" and "run on a schedule." The API will be implemented in #45.
This change also makes the environment picker's label be inside the UI control instead of just above it. This required a small change to the theme.
Demo:
https://user-images.githubusercontent.com/93281816/193711578-d23c7918-77e7-45b6-b777-b12cbb605670.mov

Looks great!


[WFLY-10709] Support Eclipse MicroProfile OpenTracing

Signed-off-by: Juraci Paixão Kröhling<EMAIL_ADDRESS>cc @jmesnil , @pavolloffay, @rsvoboda
This is a first WIP draft and is based on #11320 and https://github.com/jpkrohling/java-wildfly-tracing .
JIRA: https://issues.jboss.org/browse/WFLY-10709
Proposal: https://github.com/wildfly/wildfly-proposals/pull/106
When deploying an application such as https://github.com/jpkrohling/java-wildfly-tester , a curl call like the one below results in a trace similar to the one in the image.
curl -X POST localhost:8080/java-wildfly-tester-1.0-SNAPSHOT/v1/order -v

Please make sure your PR meets the following requirements:

[x] Pull Request title is properly formatted: [WFLY-XYZ] Subject or WFLY-XYZ Subject
[x] Pull Request contains link to the JIRA issue(s)
[x] Pull Request contains description of the issue(s)
[x] Pull Request does not include fixes for issues other than the main ticket
[x] Attached commits represent units of work and are properly formatted

For bigger changes, major and minor component upgrades make sure your PR also meets following requirements:

[x] Pull Request requires a change to the documentation
[x] Documentation have been updated accordingly
[x] Tests were added to cover changes

For new features ensure as well:

[ ] Analysis was done
[ ] Test Plan has been done
[ ] Tests were verified in advance

Can one of the admins verify this patch?

@jpkrohling trace on the picture does not use Microrofile-Opentraicng (smallrye) operation names. Are the operation names overridden or it's just an old picture? Also there should not be /serialize span if you want to pass TCK.

Juca, you are so quick.
Before proceeding with development, wf proposal https://github.com/wildfly/wildfly-proposals/pull/105 must be reviewed and agreed on, I still miss feedback from relevant QE and from Jeff.
Also PR should be created when feature is finished, reviewed and tested. Dev and QE are supposed to work on top of feature branch. Master has to have finalized stuff so it's "releasable anytime".
If you wanted to have our CI runs for your code, TeamCity supports custom runs against any repo and branch.
My understanding was that MP OT will be work for WildFly 15 and for WildFly 14 we will be focused on MP Config, MP Health and Logging enhancements for OpenShift.

trace on the picture does not use Microrofile-Opentraicng (smallrye) operation names

My bad, I was using opentracing-jaxrs. I just switched to SmallRye's.

I still miss feedback from relevant QE and from Jeff.

I'll ping Jeff, would you ping them today, thanks!

Also PR should be created when feature is finished, reviewed and tested. Dev and QE are supposed to work on top of feature branch. Master has to have finalized stuff so it's "releasable anytime".

Understood. Should this feature branch located under my repository?

My understanding was that MP OT will be work for WildFly 15 and for WildFly 14 we will be focused on MP Config, MP Health and Logging enhancements for OpenShift.

I thought this was for WF14, but might have misunderstood. The JIRA WFLY-10709 also seems to mention WF 14:

This requirement can be delivered as Technology Preview for WF 14.

The reason I'm trying to get this done quick is because I'm on PTO for two weeks starting this Friday. Looks like either we'll have to continue after my return or someone will have to take it over.

This is ok to test

Adding the 'hold' label after speaking to @rsvoboda. Ping me/ @jmesnil / @jamezp when it is ready

Status: the build is mostly passing, except for the very last module (Smoke tests), where one test is failing due to https://github.com/smallrye/smallrye-opentracing/issues/17 .

Can you comment, preferably at the relevant point in the code, if not there then in the proposal, how all the Jaeger stuff gets brought in, configured etc. I don't mean the config details, e.g. that it reads env vars, but rather the hook that causes it all to happen. It's quite magical now. My guess is it's done as part of loading the CDI Extension?
Related to that is what of that is static, i.e. done once per VM?  Anything done once per VM is problematic is it cannot be updated via a server reload; it requires a full process restart.

Can you comment, preferably at the relevant point in the code, if not there then in the proposal, how all the Jaeger stuff gets brought in, configured etc.

Right now, we are using the tracer resolver, which uses Java's ServiceLoader behind the scenes:
https://github.com/wildfly/wildfly/pull/11454/files#diff-968be69b1c607965089a660b4fdebf76R19
https://github.com/opentracing-contrib/java-tracerresolver/blob/353f318a883bc4f1675c7565e4d0a68c8af909b4/opentracing-tracerresolver/src/main/java/io/opentracing/contrib/tracerresolver/TracerResolver.java#L75
https://github.com/jaegertracing/jaeger-client-java/blob/f3e504992d19843245872fdd1c9f0006a3b70b57/jaeger-tracerresolver/src/main/java/io/jaegertracing/tracerresolver/internal/JaegerTracerResolver.java#L25

Related to that is what of that is static, i.e. done once per VM? Anything done once per VM is problematic is it cannot be updated via a server reload; it requires a full process restart.

Great point. I think the only place where it could be a problem is with the GlobalTracer .
cc @pavolloffay, @objectiser : can you think of any other places where we might get bitten by this?

@jpkrohling no, global tracer is the only one - and that is scoped to the deployment classloader so assume will be replaced on server reload.

Right now, we are using the tracer resolver, which uses Java's ServiceLoader behind the scenes:

This is not true anymore, as I'm having Jaeger-specific code now inside the TracerInitializer, so that we don't need to write a system property with the service name (https://github.com/wildfly/wildfly/pull/11454#discussion_r207976139).

Is the GlobalTracer required? Why not use only CDI? MP-OpenTracing defines that tracer should be injectable.

@pavolloffay wrote:

Is the GlobalTracer required? Why not use only CDI? MP-OpenTracing defines that tracer should be injectable.

You are right. If I create the SpanFinishingFilter on the ServletContextListener, I don't need the GlobalTracer. But the underlying application might still expect to find the tracer there, as it's the usual idiom in OT.

Status (cc @jmesnil, @rsvoboda, @bstansberry):
I added a simple basic test to make sure that the tracer can be injected into the application. I also addressed some concerns from reviewers of this PR. The only thing that is still open is about the granularity of the modules. Also on my list is the inclusion of more tests, to assess other aspects of this work, like, to make sure spans are created when JAX-RS requests are made.
I'd like to understand first, though, what would be required to get this PR merged as Technology Preview and prioritize those tasks.

@jpkrohling Thanks for the pointer to the ServletContextInitializer; I missed that. So this opens a client socket per webapp. I guess that's ok, and in any case it's an internal detail.
Here's what I think are the most important things:

I assume the MP OT TCK covers a lot of scenarios that fit typical WildFly Swarm use cases. So since that's more covered, some testing of WildFly oddities is good. Specifically we support ears, we support multiple deployments and it's common for people to reload the server. So a test of an ear that contains 2 wars (which therefore kind of covers the multiple deployment case) and also does a reload would be good.  @yersan can help you out with the reload part if you need that.

We should clarify the GlobalTracer thing.  It is not scoped to the deployment classloader in WildFly; the class is part of a static module so there's only going to be one instance per server. Looking at it, it seems it expects someone to call GlobalTracer.register. It should not be any deployment code that succeeds in doing that. But the class is exposed to a deployment so to prevent a deployment setting the tracer the subsystem should. But I don't know the implications of that, particularly if a reload happens. I don't know what kind of state a Tracer keeps, e.g. if keeping one in GlobalTracer across reloads might leak a classloader.

About the module thing we can defer creating another module but the code should be reorganized so the stuff that needs to be visible to the deployment is in a different package from the subsystem stuff. That's better organization regardless and let's us look into simple things like adding a module that simply has a module.xml that depends on the current one and exports 1 package.

For the GlobalTracer issue, could we register a Tracer proxy in the global tracer, that when called will try to use a tracer injected in the local deployment context? Hopefully the GlobalTracer will not be used, but in case the deployment does, it would be good if it just deferred to CDI.

Looking at it, it seems it expects someone to call GlobalTracer.register. It should not be any deployment code that succeeds in doing that.

I'll need some help with JBoss Modules here to see if we are doing the right thing... We cannot remove a dependency on the GlobalTracer, as some instrumentation libraries (JAX-RS, for instance) has references to it, although that code shouldn't be reached.

About the module thing we can defer creating another module but the code should be reorganized so the stuff that needs to be visible to the deployment is in a different package from the subsystem stuff.

Done: I moved the initialized, producer and CDI extension to a deployment package.

@jpkrohling FYI. I don't know the details, but, if you need to do any reload, there is a handy class for such purposes: https://github.com/wildfly/wildfly/blob/master/testsuite/shared/src/main/java/org/jboss/as/test/shared/ServerReload.java

I believe this is now ready for a code review. cc @bstansberry, @jmesnil
@kabir: do you think the hold label could be removed as well?

There are some TODO's in here that make me a little nervous if this is going into WF 14 as the deadline for features is very soon

Two of the TODOs are about bugs found during the development of this PR. If we get a release from those components by the time this PR gets merged, those TODOs will be removed. Otherwise, they are just reminders that something has to be done.
One is about a question, but I decided to remove, as there's a test that hits that condition already.
The other is about a decision we made already, so, I just removed.
I updated this PR with fixes to most of the comments by @jamezp . The current state passes the TCK as well. Once this is deemed ready to be merged, I can squash the commits, but I'll leave with individual commits for now, to make it easier to get a re-review.

All TODO's are now addressed: I released a new version of Jaeger Client Java and got a new release of Tracer Resolver as well, so that we are now in a good state to get this merged.
I tested this PR at its current state and it passes the TCK.

I noticed that some of the source is using 2 spaces instead of 4 for formatting.

Sorry, my bad! Should be fixed in the latest commit.
As usual, the current state of the PR is confirmed to pass the TCK.

@jpkrohling I think the mixed domain test failures in the linux and windows jobs are because you need to do something similar to https://github.com/wildfly/wildfly/pull/11503/files#diff-a638e7e043f2b0642d831a9f9069c59eR64 to remove the new extension and subsystem.
These tests are not run by default as there is some setup involved. If you want to run them locally, you need to download EAP 6.4.0, 7.0.0 and 7.1.0 and put the zips into a folder (e.g /some/where). Then to run these tests you execute: mvn clean install -pl testsuite/mixed-domain -DallTests -Djboss.test.mixed.domain.dir=/some/where

Looks like the tests are passing now, thanks! The only one still failing is "Linux JDK10 (Pull Request) - merge", but looks like it's failing due to some unrelated SSL tests.
Is there anything still missing, or is this PR ready to get merged?

Test-dev shall be done. There are two failing tests:
[ERROR] Failures:
[ERROR]   EarOpenTracingTestCase.testEarServicesUseDifferentTracers:79->testHttpInvokation:98 Service one and service two tracer instance hash is same -<PHONE_NUMBER>. Actual:<PHONE_NUMBER>
[ERROR]   EarOpenTracingTestCase.testEarServicesUseDifferentTracersAfterReload:85->testHttpInvokation:98 Service one and service two tracer instance hash is same -<PHONE_NUMBER>. Actual:<PHONE_NUMBER>

These tests are currently marked to be ignored. There is a tracker jira to resolve root issue https://issues.jboss.org/browse/WFWIP-104. The issue shall be fixed after the feature is merged into master.
We are okay to merge this.

I filed https://issues.jboss.org/browse/WFWIP-108, which we need to fix ASAP but doesn't need to block merging this for Beta2.

I made a couple doc comments that I'd like in for .Final but again those should not block merging this.


"Permission denied"

I'm trying to transfer roms to retroarch, but it won't allow me to upload files. Is this because my tv isn't rooted? If so, is there a workaround? I don't want to root my tv.

Where are you trying to upload them? You should have permission to write to pretty much any directory under /media/developer, although not to /media/developer itself.

Have you rebooted the TV (with Quick Start+ disabled etc. or using the reboot feature in Homebrew Channel settings) since installing RetroArch?

same problem, disabled Quick Start+ already, but still don't have permission

to all the folks struggling with this, you'll have to connect an external USB to the tv to play the roms. although, writing permissions are still absent.

There is more information in #179, but this is not a bug in Dev Manager. If anyone still needs help, join the OpenLGTV Discord server or Matrix channel (links on webosbrew.org.


Add u32 literals

Part of #1

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (e0cbd24) to head (0137477).
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           13        13
  Lines          450       462   +12
=========================================
+ Hits           450       462   +12

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


updating master

Codecov Report

Merging #256 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   96.77%   96.77%
=======================================
  Files          45       45
  Lines        1459     1459
  Branches      167      167
=======================================
  Hits         1412     1412
  Misses         45       45
  Partials        2        2

Impacted Files
Coverage Δ

src/components/DatatableContainer.js
100.00% <ø> (ø)

src/redux/reducers/textReducer.js
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe7ca7e...4aa6df4. Read the comment docs.


Added 'objectKeys' and 'underscore' to polymer-filters.html

Just noticed that two ('objectKeys' and 'underscore') js files were not included in the polymer-filters.html,
And sorted all the script files in ascending order.

Thanks!


[c++][c#][grpc] Deprecate Bond-over-gRPC

Microsoft ceased its direct investment in Bond-over-gRPC in December
2021. GitHub issue #1131, Bond-over-gRPC will be deprecated February
2022, outlines a two-step removal process should no one in the
community be interested in maintaining Bond-over-gRPC:

mark Bond-over-gRPC as deprecated in February 2022 and
delete the Bond-over-gRPC code in May 2022.

No one in the community has expressed an interest in maintaining
Bond-over-gRPC.
Mark the Bond-over-gRPC code as deprecated using the [[deprecated]]
attribute in C# and the [Obsolete] attribute in .NET, implementing
step 1.

Add suppressions for the new errors this generates in test and example
code.
Remove the weekly gRPC master branch build: it has been failing since
April 2021. Fixes https://github.com/microsoft/bond/issues/1108
Add note about deprecation in documentation.
Minor usability improvements to the Install-Boost.ps1 script.

lgtm


formik-persist.d.ts points to /Users/jared/workspace/github/jaredpalmer/ ..

Hi,
the formik-persist.d.ts published with the latest version (1.1.0) references ../../../../../../../Users/jared/workspace/github/jaredpalmer/formik-persist/node_modules/formik/dist/types resulting in a compile-time error for typescript users.
See<EMAIL_ADDRESS>I saw that it's already fixed in https://github.com/jaredpalmer/formik-persist/commit/862aae84a9153ff48ab5afd2f417733bb91d52cb and referenced in https://github.com/jaredpalmer/formik-persist/issues/18.
Am i missing something? Any chance you can publish a new version?

This is still an issue 4+ months later, apparently.


Add example usage to README.md

Closes reactjs/reselect#109

Current coverage is 100.00%

Merging #110 into master will not affect coverage as of 8f0ec6a

@@            master    #110   diff @@
======================================
  Files            1       1
  Stmts           43      43
  Branches         0       0
  Methods          0       0
======================================
  Hit             43      43
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 8f0ec6a

Powered by Codecov. Updated on successful CI builds.

Coverage remained the same at 100.0% when pulling 9780f0470e53368cd28c7a0b3a271258d58bf94a on HeyImAlex:master into 7c2de7671414bc94a3dc1b66b0f18e3b4a99636d on reactjs:master.

Great, thank you!

Perfect! Thank you


Tortoise TTS and  Audiocraft incompatible

Audiocraft 1.0.0 requires transformers 4.31.0, however, Tortoise TTS only works with 4.29.2 due to a regression in 4.31.0 that makes it throw an unexpected keys error.
In order to get the tortoise code to run I had to comment a couple lines as well.
#tokenizer_vocab_file=tokenizer_path,
#tokenizer_basic=tokenizer_basic,

Due to tortoise not using these.
TypeError: TextToSpeech.__init__() got an unexpected keyword argument 'tokenizer_vocab_file'

It seems that my tortoise patch had issues. Did you have the webui installed before? Then I need to bump up the version of tortoise to force the reinstall.

Yes, I had it installed before. I usually download the new zip and reinstall from that. I looked at the latest version of tortoise and didn't see any mention of the tokenizer_vocab_file. I'm going to try to update it again, a full fresh install.

After manually installing tortoise from github and install pytorch with cuda support, it seems to be fine.
Previously I would use the update.py but it seemed to miss some things. I changed to downloading a zip and install the requirements files, but it seems tortoise never got updated.
I'll mark this as closed. Tortoise test audio generated and audiogen produced a sound file as well on the same install.

Thank you for your time!
What I'll do is add the latest tortoise updates, and I'll also merge the vocab file into main. This repo uses my fork or Tortoise which is almost the same but a little bit different. Then I'll bump the version, which will make the update.py work correctly.


Stateful Preemption

This PR:

Implementes stateful preemption;
Fixes bugs in bad cell tracking;
Refactors the algorithm package.

  		sr.chain = chain

Can we early skip a chain if target VC does not have it?

Refers to: pkg/algorithm/hived_algorithm.go:648 in 4d0db47. [](commit_id = 4d0db47a39d449b3627219fd1fd5162135ca01cd, deletion_comment = False)

  		}

Can we early skip a chain if target VC does not have it?

Refers to: pkg/algorithm/hived_algorithm.go:633 in 4d0db47. [](commit_id = 4d0db47a39d449b3627219fd1fd5162135ca01cd, deletion_comment = False)

move to top

Refers to: pkg/algorithm/types.go:218 in b065ba5. [](commit_id = b065ba5f958b81a1a2656bdfb1fb1726623831fb, deletion_comment = False)

}

Also expose cell isNodeLevel field?

Refers to: pkg/algorithm/hived_algorithm.go:341 in b065ba5. [](commit_id = b065ba5f958b81a1a2656bdfb1fb1726623831fb, deletion_comment = False)

Aware bad nodes or suggestednodes of preempting phase, to undo preemption?

defer h.algorithmLock.RUnlock()

Rename getPCStatus getAllVCsStatus  getVCStatus to full name to align others?

Refers to: pkg/algorithm/hived_algorithm.go:344 in ad05383. [](commit_id = ad053838b9fc7c424da0b92a693b1d992551365d, deletion_comment = False)

Refine router:
// Inspect current cluster status
ClusterStatusPath = InspectPath + "/clusterstatus"
// Inspect current physical cluster status
PhysicalClusterPath = ClusterStatusPath + "/physicalcluster"
// Inspect current virtual cluster(s)' status
VirtualClustersPath = ClusterStatusPath + "/virtualclusters/"

Refers to: pkg/algorithm/hived_algorithm.go:345 in ad05383. [](commit_id = ad053838b9fc7c424da0b92a693b1d992551365d, deletion_comment = False)

h.algorithmLock.RLock()

align VC cellChildren

Refers to: pkg/algorithm/hived_algorithm.go:343 in ad05383. [](commit_id = ad053838b9fc7c424da0b92a693b1d992551365d, deletion_comment = False)


Values from a function return

Checklist

[x] Are you running the latest v2 release? The list of releases is here.
[x] Did you check the manual for your release? The v2 manual is here
[x] Did you perform a search about this feature? Here's the Github guide about searching.

What problem does this solve?
Sometimes, Global flag ( used by all subocommands) requires dynamic initialization. Thus, literal default values, values from env vars, values from file content or even values from alt src will not work.
If this dynamic initialization does not done in a one place, it will lead to repeating ourselves then not complying with DRY.
Solution description
  		Name:    "myflag",
		Value:   "hello",
                ValueFromFunc: () string {
                       // read value set by user ( if any)
                     //.. do something
                    // return a-string
                }

Describe alternatives you've considered
For now, i am just repeating myself everywhere

@abdennour Cant you use a Before func for the command to do the Global Initialization for all the subcommands. The App/Command/Subcommand all have Before funcs, so you can do multi level initialization depending on your needs


Combine Loot and Point History

Would really like loot history costs to be linked into point history.
For point history to truly reflect the history of points it should, by name, also show expenditure of points.
Loot history functions well by showing where loot went but it shouldn't take looking between both lists to understand the total history of where someone's points went.

They are still stored separately but fed together to common UI as per #327


The client config writer uses ES module syntax which makes the config file unusable in CommonJS

The config writer generates the .js config file using ES module syntax. This makes the config file unusable in a CommonJS environment. E.g. the next.config.js of Next.js. This issue blocks some use cases with Amplify JS V6.
Related issue in Amplify CLI: https://github.com/aws-amplify/amplify-cli/pull/13174
https://github.com/aws-amplify/samsara-cli/blob/c1ce1230185dbb242faa0dd144036281e6918984/packages/client-config/src/client-config-writer/client_config_writer.ts#L20

This is now resolved with the --format option:
➜  npx amplify generate config --help
amplify.js generate config

Generates client config

Stack identifier
  --stack  A stack name that contains an Amplify backend                [string]

Project identifier
  --app-id  The Amplify App ID of the project                           [string]
  --branch  A git branch of the Amplify project                         [string]

Options:
  --help     Show help                                                 [boolean]
  --profile  An AWS profile name.                                       [string]
  --format   The format which the configuration should be exported into.
                  [string] [choices: "mjs", "json", "json-mobile", "ts", "dart"]
  --out-dir  A path to directory where config is written. If not provided defaul
             ts to current process working directory.                   [string]


charts: Move the images and change the key word #140

What type of PR is this?
documentation
enhancement
Which issue(s) this PR fixes?
Fixes #140
What this PR does?
Summary:

move images(percona,xenon) to radondb repository
change the key word : xenondb -> radondb
add image radondb/sidecar:v01   todo

Test:
after move, Re-deployment, no abnormalities
Special notes for your reviewer?
check again：
helm install demo radondb-mysql-kubernetes/charts/helm

The images have been pushed?
moved:
https://hub.docker.com/repository/docker/radondb/percona
https://hub.docker.com/repository/docker/radondb/xenon
todo:
acekingke/sidecar:v01 ->radondb/sidecar:v01
wait for backup feature merge


Image "Tap" Not working in Facebook Messenger

Bot Info

SDK Platform: .NET
SDK Version: 3.15
Active Channels: facebook messenger
Deployment Environment: local

Issue Description
I created a hero card with an image, the image contains a "Tap" so when a person taps on the image, it should go to some url. It works in the emulator correctly but not in Facebook Messenger.
Code Example
            Activity reply = activity.CreateReply();
            HeroCard heroCard = new HeroCard
            {
                Title = "a random title",
                Images = new List<CardImage>
                {
                    new CardImage
                    {
                        Url = "https://images-na.ssl-images-amazon.com/images/I/41wp0Rb%2Bl9L._SX425_.jpg",
                        Tap = new CardAction
                        {
                            Type = ActionTypes.OpenUrl,
                            Value = "https://google.com"
                        }
                    }
                }
            };
            reply.Attachments = new List<Attachment>
            {
                heroCard.ToAttachment()
            };

            await context.PostAsync(reply);

In order to accomplish this, you will need to move your Tap CardAction to a HeroCard property rather than a CardImage property like this:
            Activity reply = activity.CreateReply();

                 var card = new HeroCard
                {
                    Title = "title",
                    Text = "text",
                    Images = new List<CardImage>()
                    {
                        new CardImage(url: @"https://images-na.ssl-images-amazon.com/images/I/41wp0Rb%2Bl9L._SX425_.jpg")
                    },
                    Buttons = new List<CardAction> {new CardAction(ActionTypes.OpenUrl,"button", text: "button", value:@"https://www.bing.com"),
                    },
                    Tap = new CardAction(ActionTypes.OpenUrl, value: @"https://www.google.com/")
                 };

            reply.Attachments.Add(card.ToAttachment());
            await context.PostAsync(reply);

This seemed odd that it wasn't working on FB as I thought it would so I looked over their API to see if there was something we could do on our end to include this at the CardImage level.  After reviewing the Generic template API documentation, which is what our HeroCards translate to in facebook speech it seems that there is no properties you can set at the image level.  So it appears that ths is not something we can add.  So adding the Tap at the card level is the way to accomplish this.  I tested it with buttons of with ActionType.OpenURL and the buttons still worked as expected in tandem with the click of the image.


Can I execute some jobs before and after deploying to servers?

Hello,
Can I execute some tasks before and after (create build for deploying, remove build)?
Thanks

Done in v3.

Thanks


postgres:11-alpine is still 3.13

I see that alpine has been updated to 3.14
https://github.com/docker-library/postgres/blob/718c12a2ad571c564f3425fb6cc6d0986d6a210f/11/alpine/Dockerfile#L2
However it seems like the official docker image has yet to be updated:
docker pull postgres:11-alpine && docker run -it postgres:11-alpine cat /etc/alpine-release
Shows 3.13.5
When will the docker image 'postgres:11-alpine' be updated to alpine 3.14?
Thanks
@yosifkit

IMHO: expected in the next working days.   (  ~ Tuesday? )
see:  "README:See a change merged here that doesn't show up on Docker Hub yet?"

The PR to update the Postgres variants was merged a few days ago https://github.com/docker-library/official-images/pull/10376
But there's an issue with the Alpine 3.14 builds https://github.com/docker-library/official-images/pull/10379#issuecomment-863396878

Builders are updated and builds are either queued or in progress -- sorry for the delay!


Premission to publish "SyncLounge" app in Umbrel App store

Hi team,
I need your team's permission to try and host this app on the Umbrel App Store. I have given appropriate credits and mentions to your team as you are the sole Developer of the App I am just publishing it to the Umbrel App Store for free as I have done with a lot of other OSS applications.
It would be great to have a go-ahead from your team as I have already created a PR https://github.com/getumbrel/umbrel-apps/pull/254 for this but it has been closed as I was not the developer of this application
Thanks,
Pranshu

@IMPranshu Yup all good, thanks for that!


Make Light/Dark toggle not toggle to AUTO_MODE

Although I understand that sometimes needing two clicks to switch between light and dark modes may feel a bit counterintuitive. I think it's more important to ensure that every mode can be selected by just clicking the icon. I am closing this PR, but I still appreciate your contribution.


Missing docker container, Kubernetes support as an exporter

This could be a very powerful toolset if it were dockerized and available for use on docker-hub (and resultingly in Kubernetes). Highly suggest moving forward to implement this for a docker context, with (perhaps) a daemonset example to set this up for a given cluster. FYI, the daemonset will need a mount set for it, and it will need support for the other PR, where the root-dir would need to be modified.
https://github.com/prometheus-community/node-exporter-textfile-collector-scripts/pull/178

I am not sure I understand this issue. This is a library to be used by exporters or applications that want to expose metrics. The exporters or applications could have Docker images, but I do not believe the client should.


IndexError: index -1 is out of bounds for axis 0 with size 0

when execute step1_preprocessing.py on 384.bmp, raised an error
IndexError: index -1 is out of bounds for axis 0 with size 0

I suspect it might be a data issue. Please verify if the uncompressed training image data is indeed 8.3 GB in size.


Unit tests are broken

The following versions of boto:
boto==2.49.0
boto3==1.9.120
botocore==1.12.120

... seem to be breaking the following tests:

test_cloudformation
test_kms
test_s3

CloudFormation is breaking with:
yaml.constructor.ConstructorError: could not determine a constructor for the tag '!Ref'
  in "<unicode string>", line 22, column 18:
              Value: !Ref TagName
                     ^

KMS is breaking on:
line 663, in test_schedule_key_deletion
    assert response['DeletionDate'] == datetime(2015, 1, 31, 12, 0, tzinfo=tzlocal())
AssertionError

S3 is breaking on server tests.

It looks like the S3 tests are failing because the the authenticated_client doesn't seem to be setting a proper Content-Length header 🤔:
        if not request.headers.get('Content-Length'):  # <--- This is getting tripped
            return 411, {}, "Content-Length required"

It looks like PyYAML 5.1 broke the CloudFormation tests. Pinning to 3.1 should resolve, but I would rather make it 5.1 compatible.

Yep, 3.13 has a CVE against it where loading yaml can execute arbitrary code

Semi-related–https://github.com/spulec/moto/pull/2047

The CloudFormation error can be resolved on PyYAML 5.1 with the fix in yaml/pyyaml#266, or you can wait for the release of PyYAML 5.2 which should automatically resolve the issue.

Part of the issue is that it appears that boto's code is raising the exception. So unless we alter the YAML, we'll need to wait until 5.2 (or a newer version of boto that implements the fixes).

Related: https://github.com/boto/boto3/issues/1468

I looked at the CI output and it looks like it isn't boto code ultimately causing the exception, but rather Moto parsing the CloudFormation template in moto.cloudformation.models:
https://github.com/spulec/moto/blob/master/moto/cloudformation/models.py#L85-90
Try adding Loader=yaml.Loader to the yaml.load() call in line 88; that's the fix/workaround.

Related: boto/boto3#1468

The error message matches the linked issue, but I think it's old and unrelated -- I don't have confirmation at the moment, but my recollection is that boto3/botocore dropped its dependency on PyYAML some time ago.

Well I stand corrected! That seems to have worked. Thanks @kgutwin ! Pushing the update now.

They're fixed! :)


dust-apps: more stability + observability

Description

bump eventsource-client library version in core
Remove streaming retries, as they make no sense (unless streamed_retryable is true for specific errors (mostly thought trough early on for OpenAI but not others)
Add observatiliby on the Error streaming chunks to get a better understanding of where they come from

Risk
N/A
Deploy Plan

deploy front
deploy core

PMRR


Update check occasionally disconnects users and causes server to need manual restart

It seems that every once in a while (maybe once a day) on the turn of the hour XX:00 the update check believes the server has no players online even though there are 2-3 active. It then takes the server down and it fails to initially come up cleanly (at least it does not appear in the server browser again until about 10mins later on the dot and there are some timeouts in the logs). This seems like similar behavior to #178 - though the machine has 4CPU cores @2.3GHz and 8GB ram allocated and never appears to even get close to those resources.
Attached are the relevant server logs - let me know if there's anything else you want me to grab/change to test. Overall its been really solid and stable besides this hiccup.
valheim-server.log

Ok went over the entire log. Here's what's happening:
It's not the update check disconnecting players it's the daily 5 AM restart. See RESTART_CRON in the README.
The update check just happens to run at the same time (every 15 minutes) and because the server has already been restarted by the daily restart cron it sees that no players are currently connected and runs. Which is all correct behavior. If 5 AM in the container is not 5 AM local time set TZ to the correct value for your time zone. The default is UTC.
From the logs it looks like your server is back after 30 Seconds not 10 minutes.
2021-03-20 05:00:27 [136710] (DEBUG) Waiting for server to listen on port 2456

Once this message stops appearing in the log the server is back online. As to when the server shows up in the server browser again, that's a different story and completely Steam related. Has nothing to do with the server or container. You will be able to reconnect after 30 seconds. Just add the server as a Steam favorite and you'll be good to go.
The only timeout I see is Steam failing to connect to its update servers.
ERROR! Timed out waiting for AppInfo update.
2021-03-20 05:01:11 [31] (ERROR) Failed to update Valheim server from Steam - however an old version was found - trying to start

This might also explain why it takes long for the server to show up in server browser again.
As to why that is is something for you to figure out. It has nothing to do with the container. Could be an intermittent network or Steam issue.

Awesome, thanks! I noticed that the time was in UTC which usually I don't mind though I somehow totally overlooked the RESTART_CRON variable. I'll keep looking into why the steam errors are coming up and take a couple packet captures to see what's happening and post back if I come up with anything conclusive. Thanks for the quick answer!

FYI in the latest container version I committed https://github.com/lloesche/valheim-server-docker/commit/82c81095301165b286442a1245dddc2bf6002f7e which makes it so that by default the daily restart is only performed when no players are connected to the server. Similar to how the update check works.


Create !help command

Since the influx of new members, maybe adding a !help command to use the bot especially in #bot-commands won't be that bad of an idea.
More ideas:

Depending on which chat !help was used example if in #chat it could return !deadchat and more, if in #bot-commands the voice and group commands
Maybe the ability to edit the description without having to change it in the code directly could put in the DB and modify it there (no clue if this is possible need to update my docker and prisma skills :')🤔

The !help command makes a lot more sense to add when we have the new event system in place for all message based interactions with the bot. Since all commands are registered with a trigger, channels in which they are valid, the role needed to use (if any) and a description, we can generate channel and even role specific help messages from the data that we collect for the event handling.

Since that is the intended way to implement it, I marked this as blocked until all commands are fully moved over.

Not relevant anymore with Slash Commands finally in place. The bot becomes self-documented at that point with all commands and options having description fields and proper names.


Add plot package

Resolves: #237
This PR adds the plot package, which includes the [plot] and [plot-list] modules.
Current features:

plot arbitrary functions of one variable (now you can plot several functions in the same graph!)
plot a list of points
specify axis ranges
sqrt, log, sin, cos, tan, mod are supported inside functions
store the resulting SVG as a file
decent error handling (no custom error type though), verification that the provided function is valid
figure, caption and label
set line width used in plot

Known limitations/bugs:

only x,y,z are supported as a variables (and they are treated as the same variable) still restricted to single characters
plot cuts off early for certain functions
unexpected jumps close to y-bounds for certain functions
function args such as "2x" do not work (example: "sin(2x)") sin(2*x) works now, but not sin(2x)
squiggly plot (don't know if this is just a result of floating point arithmetic) mostly solved, also added "samples" arg
suboptimal plots of functions such as 1/x, ideally it should produce two separated lines mostly solved
there seems to be some issues with operator precedence as well

Example usage:
[plot 0 20 0 20 save="myplot.svg"]
4*sin(x)+x
20-x^2

[plot-list line_width=2 connect=true point_size=4]
0 0
5.3 2.5
0 4
3.2 -0.8
3.2 5
0 0

Opening for review now! The plots are not flawless, but should be good for most functions and axis ranges. There is quite a lot going on in the modules, so I'm open to suggestions on how to improve them. I encourage you to play around with the plots and find problems :)
I've thought a bit about how to add LaTeX support. The best I've come up with is always saving the resulting SVG to a file, and then generating an [image] module pointing to the saved file. This approach requires the path to be accessible both from the LaTeX document and the [plot] module itself. Thoughts?
Some changes to note since last commit regarding usage:
-[plot_list] has been renamed to [plot-list]

[plot] now supports more than one function (separated by newlines)
There is now a samples argument  to set the "granularity" of the plot. Generally, fewer samples means smoother plot.
There are now separate arguments for each axis boundary, instead of x_range and y_range. This means you can write [plot -10 10 0 20]
You can no longer set the color of the plot. This became messy to implement when supporting plots for several functions.

Nice work! Will take a look : )

I've thought a bit about how to add LaTeX support. The best I've come up with is always saving the resulting SVG to a file, and then generating an [image] module pointing to the saved file. This approach requires the path to be accessible both from the LaTeX document and the [plot] module itself. Thoughts?

Seems like a good idea! I've been thinking about a similar problem for the chalmers-thesis template. The problem with saving a file is that we don't have any control of the output path and we don't know if that will link up with the assets folder correctly. I still think it's good approach and not a major problem. Another possibility that has it's own trade-offs is embedding the svg directly in the .tex file. I'm actually looking at that right now :sweat_smile: maybe the \filecontents command can be of help.


Dropzone modal

Turn the add items dialog into a modal so it can't be closed accidentally by clicking on the overlay

:+1:

:-1:


exclude constant in auto_arima()

hi,
I have been told by my advisor to exclude the constant when fitting the ARIMA.  Is this possible in auto_arima()?
thank you!

Thanks Taylor.   I'm trying to understand how to install the development
version using pip.
best
On Mon, Dec 17, 2018 at 12:29 PM Taylor G Smith<EMAIL_ADDRESS>wrote:

Also, here is the doc for the bleeding edge. See the with_intercept param:
http://www.alkaline-ml.com/pmdarima/develop/modules/generated/pmdarima.arima.auto_arima.html#pmdarima.arima.auto_arima
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tgsmith61591/pmdarima/issues/70#issuecomment-447813626,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMumDKCnb_92f-RfJGVrMz3u_ZQxoEZks5u54AvgaJpZM4ZWHW-
.

You'll need to pip install cython. You'll also need gcc (which can take a while to install if you don't already have it). On a mac, that would be brew install gcc, on Linux you can use yum, apt-get or whatever other installer you use.
Then, to install, you can run:
$ python setup.py install

Thanks, this looks useful too:
https://stackoverflow.com/questions/20101834/pip-install-from-git-repo-branch
On Mon, Dec 17, 2018, 12:51 PM Taylor G Smith<EMAIL_ADDRESS>wrote:

You'll need to pip install cython. You'll also need gcc (which can take a
while to install if you don't already have it). On a mac, that would be brew
install gcc, on Linux you can use yum, apt-get or whatever other
installer you use.
Then, to install, you can run:
$ python setup.py install
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tgsmith61591/pmdarima/issues/70#issuecomment-447818568,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMumFiu41q7s5rHciuap-W8foahrJn3ks5u54VBgaJpZM4ZWHW-
.


Update example to use disk storage with EF Core

The Todo model has been introduced with a migration for the DB setup. Also, the DB set up has been changed to Sqlite in 'Program.cs'. Usage of the database in Todo operations through the 'Database.cs' context, instead of the previous in-memory solution, has been implemented.

I'd also like to say to @kjeske that this is a pretty cool project and keep at it. I wish you the best of luck. Feel free to reach out to your JetBrains friends if you need help. :)
Cheers 🍻

@khalidabuhakmeh I am getting the error below

I just checkout the branch and then dotnet run below for future reference

Be sure to run dotnet ef database update before running the app to create the database and table.

Thank you @khalidabuhakmeh for this nice change. Thank you also for kind words, I appreciate that!


ionic-app-scripts build --prod errors with rc8

testing out with sample ionic app compilation  throws errors - (with rc6-rc14...)
npm run ionic:build --prod
small error:
missing node_mnodules/ng2-formio/src/formio.component.css
bypassed by creating an empty file...
another issue:
[16:43:23]  Error: ./~/formiojs/build/formio.js Module build failed: RangeError: Maximum call stack size exceeded at
getCheckFlags (./node_modules/typescript/lib/typescript.js:26030:31) at
getTypeOfSymbol (./node_modules/typescript/lib/typescript.js:29477:17) at
getTypeOfParameter (./node_modules/typescript/lib/typescript.js:39794:24)
at getTypeAtPosition (./node_modules/typescript/lib/typescript.js:39805:57)
at checkApplicableSignature
(./node_modules/typescript/lib/typescript.js:38808:37) at chooseOverload
(./node_modules/typescript/lib/typescript.js:39316:30) at resolveCall
(./node_modules/typescript/lib/typescript.js:39220:26) at
resolveNewExpression (./node_modules/typescript/lib/typescript.js:39482:33)
at resolveSignature (./node_modules/typescript/lib/typescript.js:39639:28)
at getResolvedSignature
(./node_modules/typescript/lib/typescript.js:39669:26) @
./~/ng2-formio/src/formio.component.js 9:13-32 @ ./src/pages/object.ngfactory.ts @
./src/app/app.module.ngfactory.ts @ ./src/app/main.ts
Error: ./~/formiojs/build/formio.js
Module build failed: RangeError: Maximum call stack size exceeded
at getCheckFlags (./node_modules/typescript/lib/typescript.js:26030:31)
at getTypeOfSymbol (./node_modules/typescript/lib/typescript.js:29477:17)
at getTypeOfParameter (./node_modules/typescript/lib/typescript.js:39794:24)
at getTypeAtPosition (./node_modules/typescript/lib/typescript.js:39805:57)
at checkApplicableSignature (./node_modules/typescript/lib/typescript.js:38808:37)
at chooseOverload (./node_modules/typescript/lib/typescript.js:39316:30)
at resolveCall (./node_modules/typescript/lib/typescript.js:39220:26)
at resolveNewExpression (./node_modules/typescript/lib/typescript.js:39482:33)
at resolveSignature (./node_modules/typescript/lib/typescript.js:39639:28)
at getResolvedSignature (./node_modules/typescript/lib/typescript.js:39669:26)
@ ./~/ng2-formio/src/formio.component.js 9:13-32 @ ./src/pages/test/test.ngfactory.ts
@ ./src/app/app.module.ngfactory.ts
@ ./src/app/main.ts
at new BuildError (./node_modules/@ionic/app-scripts/dist/util/errors.js:16:28)
at callback (./node_modules/@ionic/app-scripts/dist/webpack.js:119:28)
at ./node_modules/webpack/lib/Compiler.js:256:15
at Compiler.emitRecords (./node_modules/webpack/lib/Compiler.js:351:37)
at ./node_modules/webpack/lib/Compiler.js:249:12
at ./node_modules/webpack/lib/Compiler.js:344:11
at next (./node_modules/tapable/lib/Tapable.js:154:11)
at Compiler.compiler.plugin (./node_modules/webpack/lib/performance/SizeLimitsPlugin.js:99:4)
at Compiler.applyPluginsAsyncSeries1 (./node_modules/tapable/lib/Tapable.js:158:13)

The line it is complaining about (./~/ng2-formio/src/formio.component.js 9:13-32) is
var Formio = require('formiojs'); ...
@travist any ideas as to what might be causing this  / what i can do to help debug?

I am actually looking at this right now. I may try to turn it into a import command and see if that has an effect.

ng2-formio is in  node-modules/formiojs/package.json
It doesn't seem like it really should be there... is it possible that it's causing a circular dependency?
Also, is it possible that formiojs is importing itself (or other some other library that depends on itself, creating a circular dependency? (quick grep seems like it's formiojs/form that it imports...)

Ah... I will get new release out today that cleans all this up. Thank you!

So, I just took a look and do not see ng2-formio within the package.json of formiojs. I see that it is within the _requiredBy and _location but that is done during the installation of the module so I don't think that is it. Pretty frustrating since the errors that are thrown do not really indicate the real problem, and since it is fine with regular builds, I am having a hard time figuring out the cause here. Open to other suggestions.

ah - my bad.
i read some people suggesting trying to use source maps on the call stack helping to help to track down the circular dependency...
maybe something like https://github.com/evanw/node-source-map-support ?

a good writeup as to how easy it is to create an infinite loop in angular... https://github.com/angular/angular/issues/7930


Remove tests, code changes that are not related oss

logstash-output-elasticsearch can use non oss features of ES. Since they won't be supported in logstash-output-opensearch, we need to remove this .

Completed.


Run automated testing on all pull requests

Other IBM repos using Travis Continuous Integration can be found at See: https://travis-ci.org/ibm

Thanks, merging in as placeholder for the time beeing. We need yet to work out right way to deal with secrets when testing against a WA instance


testclient: Fix races when invoking fake actions

https://github.com/openshift/origin/issues/3757
Parallel Invokes try to resize a shared slice

@kargakis, thanks for the PR but I think #10783 already covers this.

@kargakis, thanks for the PR but I think #10783 already covers this.

Ok, closing this.


Terraform and CLI work for GA of Azure Fluid Relay

Resource Provider
Microsoft.FluidRelay
Description of Feature or Work Requested
Azure Fluid Relay is a new PaaS offering providing a platform for building low-latency, collaborative experiences. We are working on GA release and would like to request the release of Terraform and CLI libraries.
Minimum API Version Required
2022-06-01
Swagger Link
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/fluidrelay/resource-manager/Microsoft.FluidRelay/stable/2022-06-01/fluidrelay.json
Target Date
30th June 2022

Fluid Relay


Added examples to the methods #197

Solves issue #197
I have added one example for each heading. I have also come across a duplicate entry in the list of methods which you can see in the changes. @nikhil25803 Please take a look at it and merge if it is ok.

ok👍


[express] On thrown errors that aren't Fern-generated errors, call next(error)

If the user throws a non-Fern error, just call next() and let their middleware handle it.

closing as stale


Fix "Challenges" visual treatment

The UI was updated to indicate which words do or do not have synonyms, but "challenges" has synonyms and has the wrong visual treatment.

new release so we close this


Improve forked-to style

Drop unused styles

Vertically align icon

Update to GitHub's new list style (refer to the native issue filter dropdown)

Changed "external link" icon to "right arrow" icon, inspired by "Explore more" on dashboard

Reasons:

It is not an external link

Even GitHub does not use the "external link" icon all the time

Test URLs
Visit your forks at https://github.com/<username>?tab=repositories&q=&type=fork
Screenshot

Before
After

I'm ok with the changes and it can be merged today, I'm not too sure about the arrow though since it almost points to the stars. Maybe the link icon?

How about https://primer.style/octicons/chevron-right-16? It's also an arrow but less prominent, and we are already using chevron-left in default-branch-button.

First to see this message, release the kraken!

I had to release it myself 🤷♂


Make afl-tmin compatible with aflgo.

Allocate the 16 (unused) bytes for distance values (used by afl-fuzz). Caused
false-positive SEGV's.
Fix .gitignore rules to include some of the generated binaries.

Thanks @theKidOfArcrania !


chore: Refactor DataSidePane to accept selector as prop to show usage messages in EE

Description
Adds a couple of props to alter the data displayed in the datasources left pane to show the right count of entities using datasource. This props are going to be used in Packages and Workflow editors datasources page.
PR for https://github.com/appsmithorg/appsmith-ee/pull/4026
Automation
/ok-to-test<EMAIL_ADDRESS>@tag.Datasource, @tag.Sanity"
:mag: Cypress test results

[!TIP]
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8796846837
Commit: 4263448d8627e302467dc241d36d4d1dffc40a7b
Cypress dashboard url: Click here!

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

Summary by CodeRabbit

New Features

Enhanced the DataSidePane to display the name and count of actions, improving the informational context for users.
Added a new selector function to calculate and display the count of queries for each datasource in the app.

/build-deploy-preview skip-tests=true


Weight expressed in metric units breaks during import from GCS

At present, the ruleset only recognizes a total amount of units of measurement, not which units are used.
This causes problems during import from GCS - e.g. if a character sheet uses metric units of weight, during import the ruleset just converts basic lift to 1kg=1lbs while it converts equipment weight accurately (taking the base weight from the item, which is already expressed in lbs.)
This breaks encumbrance during import from character sheets using metric units.

@zurizig Can you upload a character file or export that demonstrates the problem? Right now we don't support metric but I'm willing to look at the export to see if we can at least tell what is metric versus Imperial.

Space Pirate Stormtrooper.zip


Suffix visitor

Now that #1089 is solved, we can include the suffix visitor I was talking about in that issue.
This is safer and more clear than using the current SuffixExtensions.Suffix because it only applies to Expression<Func<T, object>> instead of any object.
It also allows me to build a list of fields (of type Expression<Func<T, object>>) and apply a suffix to that whole list (useful for mapping multiple string fields with multiple analysers).
// put this anywhere you want
public static Expression<Func<T, object>> AppendSuffix<T>(this Expression<Func<T, object>> property, string suffix)
{
    var newBody = new SuffixExprVisitor(suffix).Visit(property.Body);
    return Expression.Lambda<Func<T, object>>(newBody, property.Parameters[0]);
}

/// <summary>
/// Calls <see cref="SuffixExtensions.Suffix"/> on a member expression.
/// </summary>
private class SuffixExprVisitor : ExpressionVisitor
{
    readonly string Suffix;

    public SuffixExprVisitor(string suffix)
    {
        Suffix = suffix;
    }

    protected override Expression VisitMember(MemberExpression node)
    {
        return Expression.Call(typeof(SuffixExtensions), "Suffix", null, node, Expression.Constant(Suffix));
    }

    protected override Expression VisitUnary(UnaryExpression node)
    {
        // allow rewriting child expressions
        return node;
    }
}

Great stuff, thanks @mausch !  Will look into implementing this in the next few days.


Added a more readable decode logic

The existing decode logic looked confusing. So I have added a more readable one along with inline comments so that anyone can understand it better.

hi @anushibin007 ! thanks for contributing!
do you mind resolving the merge conflicts? it seems like the solution was updated and some of the code changed

closing as stale! please feel free to reopen once the changes have been made, provided there are no existing solutions for the problems given


Automated cherry pick of #10944: fix(region): tag list key case insensitive

Cherry pick of #10944 on release/3.7.
#10944: fix(region): tag list key case insensitive

Codecov Report

Merging #10945 (909eeeb) into release/3.7 (0ff3997) will decrease coverage by 0.40%.
The diff coverage is 1.13%.

@@               Coverage Diff               @@
##           release/3.7   #10945      +/-   ##
===============================================
- Coverage         5.98%    5.58%   -0.41%
===============================================
  Files              848      518     -330
  Lines           131795    90247   -41548
===============================================
- Hits              7887     5036    -2851
+ Misses          123206    84811   -38395
+ Partials           702      400     -302

Flag
Coverage Δ

aFlag
5.58% <1.13%> (-0.41%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apis/const.go
0.00% <0.00%> (ø)

pkg/apis/input.go
0.00% <ø> (ø)

pkg/apis/list.go
0.00% <ø> (ø)

pkg/appsrv/appsrv.go
44.32% <0.00%> (-4.35%)
:arrow_down:

pkg/baremetal/tasks/baseprepare.go
0.00% <0.00%> (ø)

pkg/baremetal/tasks/bm_register.go
0.00% <0.00%> (ø)

pkg/baremetal/tasks/ipmiprobe.go
0.00% <0.00%> (ø)

pkg/baremetal/tasks/stop.go
0.00% <0.00%> (ø)

pkg/cloudcommon/cronman/cronman.go
49.44% <0.00%> (ø)

pkg/cloudcommon/notifyclient/events.go
0.00% <ø> (ø)

... and 469 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72cac9a...909eeeb. Read the comment docs.


Map object returns true regardless of key entries

Copied from node console:
> const equal = require('fast-deep-equal');
undefined
> const mapA = new Map();
undefined
> const mapB = new Map();
undefined
> equal(mapA, mapB)
true
> mapA.set('a', 1);
Map { 'a' => 1 }
> equal(mapA, mapB)
true

My guess is because they both have the same key properties

The same is true for Sets:
> equal(new Set([1]), new Set([2]))
true

It essentially doesn't support all new JavaScript primitives...

Please document this. It just caught me out...

Oh I just came to report this problem. Looks like it's already reported.

Tracked in #32

released in beta


docs: remove module-metadata.json and commitlint.config.js

/run pipeline

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


VsCode update everyday!!!!

I have a question!  Why my vsCode update everyday! I opened it and it tell me,it should be update!!!
WHY!
Please give some solutions! Thank you!

What version are you on? Are you using insider-preview?

You seem to have our insiders version installed (the one with the green application icon). Please uninstall and install our stable version from https://code.visualstudio.com/Download.  Stable updates every 4-5 weeks.


Fix relative link to web5-wallet README

thanks @AnthonyPichardo - will do a full refresh of all these soon


Same key can be added multiple times to a Page

Tried to add the same key twice and it worked:
{
    "type": "keyPage",
    "merkleState": {
        "count": 4,
        "roots": [
            null,
            null,
            "f5dc2d85ca80ae45636e36259d3836044109436b587537a942de329ef195cd57"
        ]
    },
    "data": {
        "type": "keyPage",
        "url": "acc://luap/luap-page2",
        "keyBook": "acc://luap/my-book",
        "managerKeyBook": "",
        "creditBalance": 0,
        "keys": [
            {
                "publicKey": "8ebd6915084a24b41cc8a36b056a1439aee4da0fe8b6a4d884628f413b2dcfb0"
            },
            {
                "publicKey": "285b1528faf4a2da3fef25d17084212742374cfb273f81f2468e3f45780d135f"
            },
            {
                "publicKey": "285b1528faf4a2da3fef25d17084212742374cfb273f81f2468e3f45780d135f"
            }
        ]
    }
}

But documentation say that a Page is supposed to be a set. Not sure what are also the implication for "n of m" cases if the same key is present multiple times.

Also if I later call to delete the key that appear twice, only one of them is deleted, so the key is still in the page, which could be  confusing for the user

Not sure what are also the implication for "n of m" cases if the same key is present multiple times.

That is a very good point and makes this more urgent than it would otherwise be. IIRC @PaulSnow you agree?

Paul fixed this in !45


Auto build addressables.

Context
Addressables is an asset solution with increasing popularity. Building these assets used to be automatically but Unity has disabled this because it didn't scale well in bigger projects. At the moment the only way to auto build these assets is with a custom build script.
Suggested solution
Update the build script method so that it includes the AddressableAssetSettings.BuildPlayerContent(); call. Maybe some configuration is needed, not sure at the time. A new input for the action would be nice to let us choose if we want to build addressables or not.

This is a few months old now. Is anything happening with it.

This is a few months old now. Is anything happening with it.

It's a great idea. We're open for contributions.

It's a great idea. We're open for contributions.

I have made a Fork and did it on 1.5 as we couldnt get the 2.0 alpha working.
The problem I see for putting this in for everyone is not everyone will have the Addressables package installed. So it will fail for all those that don't. I am assuming there is no way to do #IF PACKAGE type of command?

I have made a Fork and did it on 1.5 as we couldnt get the 2.0 alpha working.
The problem I see for putting this in for everyone is not everyone will have the Addressables package installed. So it will fail for all those that don't. I am assuming there is no way to do #IF PACKAGE type of command?

Version 1 will soon be discontinued so that will not be very helpful honestly.
There may not be a pragma for #IF PACKAGE but that would also be semantically incorrect.
Instead we can simply parse the packages manifest and check if the Addressables package is present.
This can be done as part of the javascript or as part of the c# build script.

Version 1 will soon be discontinued so that will not be very helpful honestly.
There may not be a pragma for #IF PACKAGE but that would also be semantically incorrect.
Instead we can simply parse the packages manifest and check if the Addressables package is present.
This can be done as part of the javascript or as part of the c# build script.

Got any pointers for doing it as part of the c# build script.

Got any pointers for doing it as part of the c# build script.

You can adapt the default build script (part of this repo) to have it read the packages file and check if it contains a definition for Addressables, and if so; build with addressables support.

You can adapt the default build script (part of this repo) to have it read the packages file and check if it contains a definition for Addressables, and if so; build with addressables support.

There's also an implementation from javascript side that's already implemented in test runner.

There's also an implementation from javascript side that's already implemented in test runner.

This issue should be resolved by https://github.com/game-ci/unity-builder/pull/231, right?

Yes, I assume it should close this issue. If not, please report a bug or reopen.


The GO GAF loader needs to handle extensions.

https://github.com/pombase/curation/issues/1516
fairly soon.....

I've made the changes needed and it seems OK when I test it locally.  I'll check the results of tonight's load in the morning.

well the update is on http://pombase2.aska.gen.nz/
and modifications are present:
http://pombase2.aska.gen.nz/gene/SPAC15A10.15
but the cdc2 substrates with extensions not:
http://pombase2.aska.gen.nz/gene/SPBC11B10.09

Sorry!  I made the change locally but forgot to "git push".  So the file wasn't included.
I've just added it from the command line and it's now visible:
http://pombase2.bioinformatics.nz/reference/PMID%3A27984725
(Might need a reload)

OK, that is all working. I think we can improve, but I don't  know if this is the submission file or a display issue.

For M @mah11  can we use "cyclin-dependent protein serine/threonine kinase activity"?

I expected the grouping to be slightly different, but i can't remember where our precedence is documented.

For sure I would not expect to see
has substrate ase1 , abp1 , adn2 , ask1 , atf1 , alp14 , bir1  during mitotic M phase
has substrate bud6 , cdc12 , byr4 , bun107 , brf1 , bqt4 , ccq1 , bpb1  during mitotic M phase
has substrate cph1 , clp1 , cmk2 , cdc25 , cnt5  during mitotic M phase
has substrate dbl7 during mitotic M phase
instead I would expect to see
has substrate  ase1 , abp1 , adn2 , ask1 , atf1 , alp14 , bir1, bud6, bpb1, cph1 , clp1 , cmk2 , byr4 , bun107 , brf1 , bqt4 ,  cdc25 , cnt5  , cdc12 , ccq1 , dbl7 during mitotic M phase
(that isn't quite alphabetical but you get the picture).
I would  only expect to see them separated out if there is additional information.

Above I am looking at the cdc2 page
http://pombase2.aska.gen.nz/gene/SPBC11B10.09
rather than the publication page, but I think the same issues apply.
Maybe we haven't addressed this yet  because we usually have information about  the process before we have information about the phase?
I even wonder if there is an outstanding ticket about precedence that might help?

Hmm. I have reloaded several times, and shift-reloaded once or twice, and I do not see the GO annotations on either the publication page or the cdc2 gene page. Kim also hasn't updated the ticket (#637) about loading the GAF for this paper.
I have updated the GAF to use GO:0004693.

I have reloaded several times

Sorry about that.  I forgot to check in the change to the load script twice.  I've definitely done a successful "git push" now.  I've also added that file to the web data so it should be there now if you reload:
http://preview.pombase.org/reference/PMID%3A27984725

They are indeed there now - yay!

Odd that I could see them.
Kim could you look at the grouping query above next. Can you see why these aren't grouping as expected. Any insights anyone? Kim, if this doesn't make sense to you we can have a chat tomorrow.

Odd that I could see them.

I had added the new annotations temporarily so you could have a look but it got overwritten by the nightly load.

Kim could you look at the grouping query above next. Can you see why these aren't grouping as expected.

Yep, I'll look into that.

instead I would expect to see

The summary is improved now:
http://preview.pombase.org/reference/PMID%3A27984725
but because of the way I fixed it, the details view has changed.  The annotations are now ordered and grouped together by the during relation.  If you have a look it will be clearer than my explanation.
Grouping by phase probably makes sense but the order is alphabetical (G2, M, S) rather than the actual order.
Also it might not make so much sense for other relations.
Let me know what you'd like me to do.

That looks great. I think the publication page is as I expected.
The gene page works as expected to. Grouping  by phase is a longer term goal. There is an open ticket about this.
One more improvement if it is quick, I think if a  GP has an  substrate +involved_in  it should come above anything which has substrate+ phase (only)...more information.
Is that easy  or tricky?
If tricky close this an'd I'll append to the other  open extension ordering ticket.

If there is just a list of substrates
has substrate SPAC11G7.01 , mac1 , sgo2 , bud6 , cph1 , pom2 , shd1 , clp1 , ulp2 , lem2 , nup40 , pan3 , SPAC1B2.03c , mkh1 , spo15 , cdc12 , cdc15 , byr4 , snt1 , SPAC22H10.11c , cmk2 , plo1 , rad4 , nup146 , ies4 , SPAC24B11.07c , sid2 , cdc25 , sld3 , SPAC24H6.08 , gef1 , rga2 , mgs1 , rga3 , hal4 , sec16 , prp3 , pom1 , nup124 , rad52 , mis4 , dbp10 , rod1 , bun107 , mvp1 , spo12 , rad2 , nsk1 , mpd2 , ppc89 , pof1 , ies2 , drc1 , rif1 , iss10 , slf1 , wis4 , cyk3 , SPAC9G1.07 , inp53 , mdb1 , ase1 , abp1 , pre6 , pob1 , adn2 , sad1 , fkbp39 , cdc23 , SPBC13E7.03c , SPBC13E7.07 , brf1 , cut3 , tam10 , klp9 , tea2 , nrm1 , fkh2 , srp40 , SPBC17A3.05c , SPBC17D1.05 , cnt5 , sce3 , bqt4 , psy2 , mmb1 , dnt1 , ask1 , rga4 , sfr1 , hmo1 , orc1 , atf1 , ebs1 , csi1 , hip1 , pch1 , pic1 , tmf1 , mug176 , wis1 , SPBC428.10 , wpl1 , sep1 , kin1 , pxl1 , swi10 , mod5 , dbl7 , orc2 , ppk30 , mde4 , sog2 , kms2 , SPBC9B6.03 , SPBC9B6.11c , SPBP8B7.26 , SPBPB7E8.02 , utp502 , lnp1 , tfg1 , mcm4 , scw1 , ccq1 , SPCC23B6.04c , nup60 , msh6 , mto1 , nur1 , dfp1 , sup35 , epe1 , rgf3 , mmi1 , dis1 , bit61 , alp14 , bir1 , bpb1 , puf6 , vps5
These should default to alphabetical (one there is an involved in, we use that to sort alphabetically)

Easier to locate gene of interest...

One more improvement if it is quick, I think if a GP has an substrate +involved_in it should come above anything which has substrate+ phase (only)...more information.

Ignore this request. It is in conflict with our long term request to order by phase, so gine as it is for now!

These should default to alphabetical

I thought there was an issue about that.  I couldn't find it so I made a new one: https://github.com/pombase/website/issues/437

Is that easy or tricky?
If tricky close this an'd I'll append to the other open extension ordering ticket.

That's not completely easy so I'll close this.


parse title?

Is it possible to writeout the title in <title>.torrent?

Sure.
You can use parse-torrent to get title.
const torrent = parseTorrent(buffer);
console.log(torrent.name);

Maybe I can integrate it into API of magnet2torrent-js.

I have published a new version, you can get its title easily now.
Please refer to the readme.


Unable to build generated Stencil lib

Following the documention at https://www.npmjs.com/package/@nxext/stencil,
I created a new nx workspace, installed the plugin, ran the generate command, and tried to build it.
Here are the commands I ran in order:
npx create-nx-workspace@latest selecting an empty workspace with any name.
npm install @nxext/stencil --save
nx g @nxext/stencil:lib my-lib --publishable --importPath @test/my-lib selecting scss
nx build my-lib
I am the faced with the following error:
[ ERROR ]  Rollup: Parse Error: ../../../libs/my-lib/src/components/my-component/my-component.tsx:4:0
           Unexpected character '@' (Note that you need plugins to import files that are not JavaScript)

      L4:  @Component({
      L5:    tag: 'my-component',

[46:03.1]  build failed in 601 ms

If you'd like me to set up a public repo for this, I can, but I'm not doing anything special. As a side note, I tried this with a generated app too, same result.
Running on Windows 10
Package.json:
{
  "name": "test",
  "version": "0.0.0",
  "license": "MIT",
  "scripts": {
    "nx": "nx",
    "start": "nx serve",
    "build": "nx build",
    "test": "nx test",
    "lint": "nx workspace-lint && nx lint",
    "e2e": "nx e2e",
    "affected:apps": "nx affected:apps",
    "affected:libs": "nx affected:libs",
    "affected:build": "nx affected:build",
    "affected:e2e": "nx affected:e2e",
    "affected:test": "nx affected:test",
    "affected:lint": "nx affected:lint",
    "affected:dep-graph": "nx affected:dep-graph",
    "affected": "nx affected",
    "format": "nx format:write",
    "format:write": "nx format:write",
    "format:check": "nx format:check",
    "update": "nx migrate latest",
    "workspace-generator": "nx workspace-generator",
    "dep-graph": "nx dep-graph",
    "help": "nx help"
  },
  "private": true,
  "dependencies": {
    "tslib": "^2.0.0"
  },
  "devDependencies": {
    "@nrwl/cli": "12.5.0",
    "@nrwl/jest": "12.5.0",
    "@nrwl/tao": "12.5.0",
    "@nrwl/workspace": "12.5.0",
    "@nxext/stencil": "^12.0.3",
    "@stencil/core": "^2.6.0",
    "@stencil/sass": "1.4.1",
    "@types/jest": "26.0.8",
    "@types/node": "14.14.33",
    "@types/puppeteer": "~3.0.2",
    "dotenv": "8.2.0",
    "jest": "27.0.3",
    "prettier": "^2.3.1",
    "puppeteer": "~5.3.1",
    "ts-jest": "27.0.3",
    "ts-node": "~9.1.1",
    "typescript": "~4.2.4"
  }
}

Any help is appreciated, thanks :)

Hey, thanks for the report. I'll take a look. After some short tests, seems a problem just on windows

Updated, tested and it works! Thanks for the fast response and fix!

Great to hear. :-)


Display alt attribute of  in article view

Fixes #1505.
alt is preferable to title since it is specific to <img> and its semantics are directly related to rendering, while the latter is not and has semantics that depend on the element.

Coverage increased (+0.009%) to 58.796% when pulling 0aec8c6ccd2f62d137f976e565887a3792464d04 on markmatney:bugfix/img-alt-rendering into 884bfec3f355f273a352f024ebc719919ffa6d54 on newsboat:master.


If CI fails on master, post a message in the #ci-failures-stdlib Slack channel

Codecov Report

Merging #104 (b84d77b) into master (6bb8306) will decrease coverage by 1.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   92.98%   91.52%   -1.47%
==========================================
  Files           5        5
  Lines         485      484       -1
==========================================
- Hits          451      443       -8
- Misses         34       41       +7

Impacted Files
Coverage Δ

src/Curl/utils.jl
80.00% <0.00%> (-17.50%)
:arrow_down:

src/Curl/Easy.jl
94.09% <0.00%> (-0.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb8306...b84d77b. Read the comment docs.


Training on Kubric Dataset

I am trying to train the TAPIR model on the Kubric Dataset using Google Colab however my code keeps stopping without any errors. I am using the python ./experiment.py --config ./configs/tapir_config.py command and the config file is loaded successfully. The training process stops abruptly without any errors. I am unable to determine the cause and would be really grateful for any help in this regards.

Thank You!

@yangyi02 The execution stops since I'm able to run other cells. Even with batch_dim set to 1, within 3 - 5 mins the execution stops. The last message printed is Initializing Parameters after which it displays a few warnings and stops.


Account balance corruption. Staking bug?

Note
The problem occurred on the second day after the node was launched and has not been resolved since than (see what were the steps to do it bellow). I can provide full access to the node.
Description
When staking after a day or so the sum of "balance" plus "immature_balance" on "getwalletinfo" will be less than the real sum on the node, which you can see on blockchain explorer. The difference will never go away but rather will stay for another day or so and then will increase. The range of the difference might vary from few coins up to four digit sum value. When occurred it might stop the staking (though most of the times it doesn't), once I even suspect it resulted to node stopping.
The only way to "treat it" is to reload the node.
Steps to solve the problem
Originally the node was installed on Ubuntu 22.04.01 LTS.
First step was to launch it in Docker (it didn't help).
Second step was to use 1(one) processor core instead of 8 since the node is installed on VPS and there could be some "virtual issues" with processor (8 vCPU Cores of AMD EPYC™ 7282 processor 30 GB RAM 400 GB NVMe) (it didn't help).
Third step was to creat a new wallet.dat (it didn't help).
To Reproduce
Steps to reproduce the behavior:
Just wait a couple of days with staking active.
I will provide access to the problem VPS (please ask for credentials).
Expected behavior
The sum of "balance" plus "immature_balance" will be less than the sum on blockchain explorer. The difference will never go away but rather will stay for another day or so and then will increase.
VPS

8 vCPU Cores of AMD EPYC™ 7282 processor 30 GB RAM 400 GB NVMe
OS: Ubuntu 22.04.01 LTS

Thank you for your response! I will think about possible steps to get more details. Access to yours is not needed, I think we can reproduce the situation on the test node. Do not give anyone access to your node with coins!

All coins withdrawn now. You can perform all tests on it (using testnet)!

I observe the same problem on our test nodes, OS features or server hardware are not related to this problem.
I haven't delved into the question yet, but I'm almost sure that if you run a node with the argument -zapwallettxes=1, then the difference in your balances will disappear.

after restarting the node, the balance does not match? on my test node, the balance matched after restarting

I'm clarifying this because it gives a direction to think about exactly where the problem is - I think the problem is in the staking mechanisms, namely the distribution of coins inside the wallet. There has long been a problem with "rejected" bets that are not accepted by the network, but the wallet ceases to take them into account in the balance. This may not be the only problem, but if the recalculation of the wallet corrects the situation, then perhaps the problem is not very serious.
You need to dig deep inside the wallet while debugging the node - it will take some time, I will keep you informed.

@HiHat Hi! I am currently searching for a problem, working with the new version of node 0.21-beta and I don't see a problem yet. In this version, the node code was updated (to version 0.21 bitcoin), where, among other things, there were many improvements in the operation of the wallet.
Since the zapwallettxes method is removed in more recent versions of bitcoin, I suggest you try this sequence to try to reproduce the problem:

Restart node with zapwallettxes argument on version 0.20.29 and stop after full launch (before first staking block)
Install 0.21.0-beta9
Start and wait staking

0.21.0-beta9 available here:
https://github.com/pocketnetteam/pocketnet.core/actions/runs/3656434804
https://github.com/pocketnetteam/pocketnet.core/suites/9767857087/artifacts/469349412

Although I found the problem on the test node, but my actions were quite chaotic and are not subject to investigation - we need clearer steps to reproduce the problem

I also want to note that the node wallet always operates with several addresses - the listaddressgroupings method will show all addresses in the wallet with their confirmed balances

After switching to testnet and long waiting for blockchain sync (last 5000 blocks was synced in 3 days) bug was reproduced on 0.20.29 and then on 0.21!
The sum of "balance" plus "immature_balance" from "getwalletinfo" became less than the real sum on the node (on blockchain explorer); however, sum calculated by following command is always correct:
I can't repair wallet balance on 0.21 by rescanblockchain (due to removed zapwallettxes option). Only rollback to 0.20.29 repairs the wallet balance for some time with further corruption.

The problem is fixed in version 0.21.0-beta10 (available via link below or through docker pocketnetteam/pocketnet.core:0.21.0-beta10)
https://github.com/pocketnetteam/pocketnet.core/actions/runs/3694145539
Perhaps after the first launch, it will be necessary to remove previously suspended transactions from the wallet - this can be done via GUI or in the terminal using the following commands:
# Get all transactions for removing
pocketcoin-cli potencialabandontransactions
# Clear suspended transactions
pocketcoin-cli abandontransaction <TX>


Use of dataset stats override

System Info
Mac OS

Information

[X] One of the scripts in the examples/ folder of LeRobot
[ ] My own task or dataset (give details below)

Reproduction
Wondering why do we use image override stats for the policies that do not use pre-trained resnet models eg Diffusion:
configs/policy/diffusion.yaml
Shouldn't these be computed from the dataset?
What do the original authors use?
Expected behavior
Appreciate your assistance.

In diffusion policy, these were used to exactly match the stats from the original implementation so that we could port their weights and reproduce eval results. We did this to avoid any differences in stats because of numerical errors associated with the way we compute the stats.
Apart from diffusion policy, we don't use the overrides anywhere else where we do not use pre-trained image models.
Hope that answers your question :)

Thanks for the prompt response @alexander-soare . In the author's repo, I am looking at:
diffusion_policy/model/vision/multi_image_obs_encoder.py
Where the values they used are: mean=[0.485, 0.456, 0.406], std=[0.229, 0.224, 0.225]
whereas the ones you have are: mean: [[[0.5]], [[0.5]], [[0.5]]]  # (c,1,1), std: [[[0.5]], [[0.5]], [[0.5]]]  # (c,1,1)

Yeah, I can't remember where exactly but elsewhere it ends up being overridden. You can check this by breakpointing in their code where the normalization happens. In any case, we wouldn't have been able to port weights and eval correctly if we got this wrong.

@alexander-soare with an std of 0.5 (and with mean of 0.5), the values can go outside of 0 to 1 range. I see one place in the code where the mean is 0.5 but the std is 1/12.
Its in get_image_range_normalizer func in diffusion_policy/common/normalize_util.py

I see, and what's the issue with the values being outside that range?
Note that you won't be able to find the normalization values from our config in the code. They are either dynamically computed, or loaded from their dataset files.

Unnormalized values are between 0-1 so I thought it might be undesirable to to have normalized values go outside of this range. I am not sure if it's a real issue though.
To your second point, I was under the impression that these values in yaml override the calculated values.

To your second point, I was under the impression that these values in yaml override the calculated values.

Okay maybe I'm getting confused between LeRobot and the official Diffusion Policy repository. Without trying to untangle the details, I can confidently say that we have dataset normalization stats that match theirs for the PushT (image) task, and this can be verified by breakpointing into their code at the right place when eval'ing PushT.


ISO 639-1 code for Czech: is 'cs', not 'cz'

I tried fixing this in https://github.com/ModernMT/MMT/commit/d1d8e525d03163e6d3e5c221e8c06fcdb41f9ed0
But somebody should verify that it works before closing this.

It seems perfectly ok for me. I close this issue, thanks for the fix!

LanguageAnalyzer.java:59
        analyzers.put("cz", org.apache.lucene.analysis.cz.CzechAnalyzer.class);

Any other places with hardcoded language codes?

It shouldn't. Thanks for the debugging!


Transaction manager to not retry inner transactions

This resolves b/256151008
The test added shows that without the change outer transaction retries 3 times and inner transaction retries 9 times, with the change inner transaction retries 3 times as well as outer transaction.

This change is

@weiminyu  Kind reminder to check this PR


adjacent lanelet problem

I need to get adjacent lane relation of 2 lanelets with the opposite direction, but Optional RoutingGraph::adjacentLeft(const ConstLanelet& lanelet) in src/lanelet2/lanelet2_routing/src/RoutingGraph.cpp get nothing for this scenario, the scenario is like pic below, i want to get adjacentLeft lanelet of laneletB, which should be laneletA, but get nothing by function adjacentLeft.

I checked, and find function leftOf is used when build boost::graph
template <typename Lanelet1T, typename Lanelet2T>
IfLL<Lanelet1T, IfLL<Lanelet2T, bool>> leftOf(const Lanelet1T& left, const Lanelet2T& right);
it judge the left relation use:
left.rightBound() == right.leftBound()
which only work for lanelet whose direction is the same.
for opposite direction adjacent lanelet,should be checked by this condition:
left.leftBound().invert() == right.leftBound()
Is return nothing specification for this scenario, or there should be return?

So for overtake maneuver using opposite lane(yellow dashed line), there is no routing method? or this situation should be include in trafficRules ?

Traffic rules are meant to be a customization point for users where they can implement their own behavior for the routing graph. For overtaking, I would suggest to create special overtaking traffic rules and use the graph created from them to plan these maneuvers.

Ok, thank you very much for your suggestion.

I just came across this today too, it seems like a common use case (#100). Would it make sense to add an official opposing relation?
If adjacent left/right are available, but not traversable, then it shouldn't be much different to add opposing right?
I don't know all the details behind the routing graph though.

Yes, could definitively make sense. Also for applications like overtaking using the opposing lane. Basically we would need four new different opposing relations (left/right, lane change for overtaking possible/not possible). I think we even have the information about opposing lanelets at some point when we create the graph, but we discard them after finding out that they are neither adjacent nor left/right.
Even though it should be quite straightforward to add this, it would require resources that we currently don't have, tbh. Unless there is an internal use case that makes it necessary for us. If you need this, I would suggest you implement it yourself.


watchtower/wtclient: add prefix logging

Follow up from #4782, adds the (legacy) or (anchor) prefix to logs output by the individual sub-clients

probably not worth adding a prefix logger just for that single line.

yeah this was also my thinking. that log should never execute anyway 👌

probably not worth adding a prefix logger just for that single line.

yeah this was also my thinking. that log should never execute anyway 👌

PR is good to go IMO. Do we want this for RC4?

PR is good to go IMO. Do we want this for RC4?

@guggero yes i think so, otherwise it will be difficult to debug watchtower logs in 0.12+

@guggero yes i think so, otherwise it will be difficult to debug watchtower logs in 0.12+


add OpenBSD to OS_LinuxBSD::get_name()

as per title, I found this while looking for #48938, and thought it would be nice to have the os properly detected :)

Thanks!