Run the entire advection loop on device

This PR hoists the data transfers out of the advection loop, making the entire timestep device resident and resulting in big reductions in the data offload cost. The attached plot shows the effects of the optimisations included herein.
The most invasive change is to OUTBLOCK. Whilst not a very computationally heavy routine, it needs to run on device in order to prevent copying all the state fields back to host. The indirection + accumulation pattern in OUTBLOCK wasn't compatible with how scalars are privatised to GPU threads. @jkousal32 your recent ifs-source PR conflicts with some of these changes, I'll resolve that conflict once I merge this back into develop.
One more optimisation PR is planned after this, which will focus on improving the GPU performance of the physics kernel.

@jksoual32 and @jrbidlot, could you please also review this PR? Many thanks!

Ahmad,
silly question. Changing outblock affects the output, many of those are pure diagnostic parameters.
Have you checked that the output file id the same in both cases?

Ahmad, silly question. Changing outblock affects the output, many of those are pure diagnostic parameters. Have you checked that the output file id the same in both cases?

The validation passes both on CPU and GPU after these changes, so I am reasonably confident I haven't changed the results. But of course I will double check and run checksums on the output file before and after this change.
Just to be sure, the relevant file to check would be the path stored in CNORMWAMOUT_FILE right?

Ahmad, silly question. Changing outblock affects the output, many of those are pure diagnostic parameters. Have you checked that the output file id the same in both cases?

Just confirmed (using sha256sum) that the contents of CNORMWAMOUT_FILE are identical on CPU before and after this PR. On GPU they are not, but that is expected because as this PR runs more of ecWAM on device, we will get small round-off differences.

Many thanks @wdeconinck for spotting that, it is indeed more intuitive to rename the preproc def as you suggest. As discussed offline, if you are happy with the fix, could you please merge the branch? I will address the failing macos CI tests in a follow up PR.


Expand on what exactly is required for the pcf_ert_domain

@sahilm @eamonryan @chentom88 and I were exploring pcf-pipelines as part of PRE summit in Dublin and we came across this configuration item. We haven't heard this domain referred to as the ERT Domain before.
Perhaps this isn't as much of an issue for those new to PCF, but we thought explaining it via an example makes it a tiny bit clearer.

@scottmuc Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@scottmuc Thank you for signing the Contributor License Agreement!

Thanks @scottmuc! Sorry about the delay. Thanks again for creating an pull request.


How to use variable as a message

I am using the plugin in ionic 1. I would like to the message a dynamic content. I saved message content into $scope.detailService.itemName.message. I tired to put it into vm.share, but it can’t show, only contents can show. May I know is there anything I made wrong? Many thanks.
The code is as below :
console.log($scope.detailService.itemName.message); // it show correct message content

var vm = this;

            vm.share = {
                'networks': ['facebook', 'twitter', 'whatsapp', 'anywhere', 'sms', 'email'],
                'message':  $scope.detailService.itemName.brief,
                'subject':  'Custom share subject',
                'file':     'www/img/ionic.png',
                'link': '',
                'toArr'<EMAIL_ADDRESS>                'bccArr':   [],
                'ccArr':    [],
                'phone':    '098765432
            }

Well, for one the code that you shared references $scope.detailService.itemName.message but then the share object references $scope.detailService.itemName.brief instead.


iOS does not support https with self signed certificates

To Reproduce:
Setup a sample https website with a self signed cert
On the iOS simulator install the certificate by dragging and dropping it on the simulator
Create a http client with the modernhttp handler
do a GetAsync on the server
Expected result: Success
Actual result: System.Net.WebException: An SSL error has occurred and a secure connection to the server cannot be made.
If you use safari on the simulator it will successfully download that url.

You need to purchase ModernHttpClient-Pro to get this functionality.

That's funny.  If I can't get through the red tape to get our QA servers to use real certificates (which you can get for free).  There's no way I'm going to get them to shell out the cash for a pro version.  I think I've read a book about this.


Resourcedesigner finds 0 refrences to this plugin

'Resource.Drawable' does not contain a definition for 'abc_ic_star_half_black_36dp'
i get this with "i think" every resource that this plugin has.
Runnig on XF <IP_ADDRESS>29

Hi
I believe this would only be an issue directly on the android project. Do
you have android.support.v7.appcompat installed and if so what version.
Thanks
Adam
On Wednesday, October 5, 2016, bentmar<EMAIL_ADDRESS>wrote:

'Resource.Drawable' does not contain a definition for
'abc_ic_star_half_black_36dp'
i get this with "i think" every resource that this plugin has.
Runnig on XF <IP_ADDRESS>29
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.<
https://ci3.googleusercontent.com/proxy/-sCRrtEoRVZmDkX88HyytrSuCIdYVZ6ks2CjxuyVQ4Mre0BJi8pM_2aedo_byhQp5hd-DhDx9Qk3q5anlc0HQuMRgbA5v-mO_zjhZpui9ZX_JcO4XmAY3IBpuPSrxWXURESXaqVC6oaw9mutUXR1oosAkEPoHg=s0-d-e1-ft#https://github.com/notifications/beacon/ANCg1p4i4ZSmiUbzxQU-M8pqIXYtKuiDks5qwmc6gaJpZM4KNxK6.gif

yes, <IP_ADDRESS>

Android Toasts package requires at least 23.3.0. Apologies I should have
specified that in the Nuget package, I will do that in the next upgrade of
the package.
As such you need to upgrade to Xamarin Forms 2.2.0 or higher. 2.2.0 came
out 6 months ago and references 23.3.0. Ideally I would recommend upgrading
to 2.3.2 as all the versions up to that point include a huge number of bug
fixes and they all reference 23.3.0 of the support library.
Thanks
Adam
On Wed, Oct 5, 2016 at 11:33 PM, bentmar<EMAIL_ADDRESS>wrote:

yes, <IP_ADDRESS>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/EgorBo/Toasts.Forms.Plugin/issues/94#issuecomment-251661257,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANCg1lAD4daDLVH8vqFDwbq-MQDLFpgwks5qw5kbgaJpZM4KNxK6
.

Oh okay!
In the current project we can´t upgrade any higher atm because of a bug in appearing/dissapearing events, it will finally be solved in the upcoming release :D (trust we, i want to update so bad).
fyi, i managed to get it "working" in my current project, but it doesnt relly fix it (deleting failing rows in resourcedesigner.cs)
Thank for the response!


service start retry, if the start.sh failed.

Coverage increased (+13.05%) to 64.929% when pulling e20378926bfd94a74020a58da65d790e08469d81 on yuye/retry-service into 012f22e926b0b43451cbeae37528c61a4da30520 on master.


Replace snippet variables with numbered holes

I thought we supported named snippet placeholders?

As substitutions yes, but that requires you to actually call the python api with those substitutions. When you just insert a snippet we don't do any transformation like Cursorless. The default text made behavior is to insert the variable name.

Maybe we should use cursorless snippet insertion when it's available? The behaviour of inserting the name isn't wrong, and it leaves it selected, I believe, so i think it's still usable without cursorless
Not opposed to also making these numbers; I personally prefer names but given all the others are numbers I guess more consistent for the time being

All other snippets in community use numbers. I think we should make this change and then we can have a discussion later about how to handle variables?


LCFS - Show organization balance in top banner

Description:
Calculate organization's balance on the back-end for display purposes in the banner. BCeID only.
Wireframe: Private Zenhub Image
Purpose and benefit to user: Can easily see compliance standing on every page while navigating the application
Acceptance Criteria:

[ ] Given I am a , When I am , then
[ ] Given I am a , When I am , then

Development Checklist:

[ ] A
[ ] B
[ ] C

Notes:

I believe this functionality is covered in a different card. Will need to confirm once we have the LCFS portal set up

Compliance balance is showing '0' for all BCeID accounts. They should be reflecting the real-time accurate balance in the top right hand corner of the screen instead of '0':

Completed a new transfer from start to finish between LCFS Org 1 and LCFS Org 2 and the balances did not adjust to reflect the 20 compliance unit difference for either organization:

There should be a comma in compliance unit balance as shown in the wireframe:

Still missing point #2 in the comment above. No comma in the compliance unit balance :(


(feat) Validation Webhook for validating Chaos target application details

Signed-off-by: Rahul M Chheda<EMAIL_ADDRESS>

@prateekpandey14 Removed liveness check from the YAML itself, because of CrashBackLoopOff issue.

Can we add the description in this PR with what it accomplishes and its usage model.

For building the image of this repo, Are you sending new PRs


Lots of assertions (e.g. in loops) are slow

If I have a test like the following:
CustomArrayClass<int> array;

const size_t element_count = 64*1024*1024;

for (size_t i = 0; i < element_count; i++)
{
    CHECK(array.size() == i);
    array.push_back(42);
}

CHECK(array.size() == element_count);

for (size_t i = 0; i < element_count; i++)
{
    CHECK(array[i] == 42);
}

The problem is the CHECK asserts in the loops are very slow, which appears to be because the values are being converted into strings each time.
It seems like the above is not the best practice with Catch (?), so could you suggest how a test like this should be written?

Hmm...this makes me wonder...
What if Catch used type erasure to store the lhs and rhs without converting it to a string? Then it can convert it if it actually needs to, not at every test case.

For very long loops, give a single boolean expression to CATCH, instead of an A == B expression:
for (size_t i = 0; i < element_count; i++)
{
    CHECK( (array.size() == i) );
    array.push_back(42);
}

The extra set of parentheses will make array.size() == i appear as a single boolean expression. Of course, if the assertion fails, you will lose the nice textual information on the LHS and RHS values. The INFO and FAIL macros can be useful in obtaining more diagnostic information on a failure.

@scross99 Can you try out #562?

Thanks for making these changes; the following has some timing figures that hopefully make sense.
Here's a simple example:
#include <vector>

#define CATCH_CONFIG_MAIN  // This tells Catch to provide a main() - only do this in one cpp file
#include "catch.hpp"

TEST_CASE("Example Test", "[tag]") {
	std::vector<int> array;

	const size_t element_count = 1024*1024;
	array.reserve(element_count);

	for (size_t i = 0; i < element_count; i++)
	{
		CHECK(array.size() == i);
		array.push_back(42);
	}

	CHECK(array.size() == element_count);
}

I've reduced the number of iterations 64 times from the original example to make the timing more feasible.
Building with:
$ g++ -o test_example -O3 test_example.cpp

With the unmodified Catch:
$ time ./test_example
===============================================================================
All tests passed (1048577 assertions in 1 test case)

real	0m7.171s
user	0m7.090s
sys	0m0.008s

With the modified Catch:
$ time ./test_example
===============================================================================
All tests passed (1048577 assertions in 1 test case)

real	0m6.959s
user	0m6.944s
sys	0m0.008s

By adding extra parentheses to assertion with unmodified Catch:
$ time ./test_example
===============================================================================
All tests passed (1048577 assertions in 1 test case)

real	0m2.560s
user	0m2.550s
sys	0m0.000s

If the assertion in the loop is removed entirely:
$ time ./test_example
===============================================================================
All tests passed (1 assertion in 1 test case)

real	0m0.010s
user	0m0.005s
sys	0m0.008s

Given that I'd like to do 64 times the number of comparisons, these timing numbers are too large for either a normal EXPECT or extra parentheses to work. So far I've been using:
#include <vector>

#define CATCH_CONFIG_MAIN  // This tells Catch to provide a main() - only do this in one cpp file
#include "catch.hpp"

TEST_CASE("Example Test", "[tag]") {
	std::vector<int> array;

	const size_t element_count = 64*1024*1024;
	array.reserve(element_count);

	for (size_t i = 0; i < element_count; i++)
	{
		if (array.size() != i) { CHECK(array.size() == i); }
		array.push_back(42);
	}

	CHECK(array.size() == element_count);
}

This gives (note that I'm now building without optimisation and I increased the iterations back to the original 64*1024*1024):
$ g++ -o test_example test_example.cpp
$ time ./test_example
===============================================================================
All tests passed (1 assertion in 1 test case)

real	0m2.815s
user	0m2.723s
sys	0m0.080s

This is a reasonably viable figure, though it does show that performing this many comparisons is bound to be slow anyway. Of course, it's a lot faster if I re-enable optimisation:
$ g++ -o test_example -O3 test_example.cpp
$ time ./test_example
===============================================================================
All tests passed (1 assertion in 1 test case)

real	0m0.483s
user	0m0.341s
sys	0m0.139s

Do you really need to check all<PHONE_NUMBER> permutations? Couldn't you just check corner cases, with a few spot checks in between? You might also consider some kind of mathematical proof by induction.

Couldn't you just check corner cases, with a few spot checks in between?

Yeah, I think this is the best solution.

@scross99 This ticket seems to be about a performance issue. How about renaming this ticket "Lots of assertions (e.g. in loops) are slow"

@kirbyfan64 you got my attention with the claimed performance increase. Lazy stringifying makes sense to me. Travis CI seems to be failing on the current PR. What are your plans for the patch? I'd be interested in helping you test and improve it if you plan to keep working on it.
Lazy stringifying aside, I noticed a couple of potential perf issues with the current master:

ExprComponents::op could be a const char *, and op comparisons could be reworked to always use pointer comparisons rather than string comparisons.
C++11 versions of setLhs and setRhs could tale string parameter by r-value reference and move into ExpComponents::lhs, rhs, instead of copying.

I just haven't gotten a chance to fix the failures yet. I'll hopefully do it today or tomorrow.

The patch by @kirbyfan64 takes the approach of moving a lot of string conversion into one place, and then avoiding generating strings unless needed.
An alternative approach is to improve string handling. There are numerous opportunities to improve string handling performance in Catch. For example, static file names don't need to be std::string, and string concatenation with operator+ is slow with multiple operands.
Here is a rough-cut of some improvements:
https://github.com/philsquared/Catch/compare/master...RossBencina:rb-master-optimized?expand=1
I get roughly 50% of the performance improvement given by @kirbyfan64's patch. Combining the patches is possible, but since @kirbyfan64's disables most string generation, it disables most of the optimizations in my patch, so there is no aggregate benefit unless some strings will be generated.
I likely won't submit this as a PR until Phil merges some of the smaller dependent changes. In my view, much of this improvement should be done irrespective of the status of the lazily stringify patch.

#772 is halfway through to being on master, which helps a lot. I am going to open a new meta issue ( #781 ) to keep track of possible performance improvements, but I am closing this one in the meantime.


Does the order of Java api runner.feed(#1).feed(#2).feed(#3)... matters?

Hi, guys, I have a quesion about the Tensorflow Java api.
When I feed the data to the model, the feed order matters ?
For example, runner.feed(#1).feed(#2).feed(#3)... is equal to runner.feed(#2).feed(#1).feed(#3) ?
Besides, recently, I run some response generation work from github(https://github.com/tuxchow/ecm), which use the old seq2seq code (implement with buckets), and i use the python to train the model, java to predict, as a result, I feed the test sentence word by word into the model, e.x. runner.feed(word1).feed(word2).feed(word3)... , However, I found that except the first word's logits is correct,  from the second word it's wrong, why is that?
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): windows10
TensorFlow installed from (source or binary):  binary
TensorFlow version (use command below): 1.6.0
Python version: 3.6
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:
Exact command to reproduce:None

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

The order shouldn't matter as long as each call to runner.feed() is provided a unique inputName. As for why other outputs would be wrong, it's hard to say without access to the model. Any chance you can share the model in question?

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?


Add ServiceRequestContextCaptor.isEmpty()

Motivation:
ClientRequestContextCaptor has isEmpty() but ServiceRequestContextCaptor doesn't.
Modifications:

Add ServiceRequestContextCaptor.isEmpty()

Result:

Closes #4757

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Distribute via package manager

As a developer, I don't want to care about RR updates. Instead, it would be nice to keep it up to date automatically.
For me, an apt, snap or flatpack package (in an own rep) would fit since my VM runs on ubuntu.

No capacity.


[BugFix] fix comment lost escape character

Fixes #24908
When parse a string, we need obtain the real meaning of a character followed by a escape character (like insert string values). The escapeBackSlash() method do this job.
@Override
    public ParseNode visitString(StarRocksParser.StringContext context) {
        String quotedString;
        NodePosition pos = createPos(context);
        if (context.SINGLE_QUOTED_TEXT() != null) {
             ....
        } else {
            .....
        }
        return new StringLiteral(escapeBackSlash(quotedString), pos);
    }

But when parse comment string value, we need remain these escape character or the show result is not a legal string. Like comment "\"abc\"", it becomes ""abc"" if we remove the escape character.
I don't want to change the exist comment object too much, so I just add the escape character back when print the comment string.
Reason for removing QUOTED_IDENTIFIER in StarRocksLex.g4:
Some tokens have been regard as QUOTED_IDENTIFIER affectting the extract string process. Actually, ee haven't referenced this lex def in StarRocks.g4, so delete it.
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.0
[x] 2.5
[x] 2.4
[ ] 2.3

[FE PR Coverage Check]
:disappointed: fail : 31 / 44 (70.45%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/lake/LakeTable.java
0
3
00.00%
[210, 211, 213]

:large_blue_circle:
com/starrocks/catalog/MaterializedView.java
1
2
50.00%
[839]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
8
16
50.00%
[2729, 2764, 2780, 2781, 2787, 2797, 2807, 2871]

:large_blue_circle:
com/starrocks/lake/LakeMaterializedView.java
2
3
66.67%
[180]

:large_blue_circle:
com/starrocks/catalog/Table.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/Column.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/CatalogUtils.java
10
10
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/Catalog.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
4
4
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 31 / 44 (70.45%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/lake/LakeTable.java
0
3
00.00%
[210, 211, 213]

:large_blue_circle:
com/starrocks/catalog/MaterializedView.java
1
2
50.00%
[839]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
8
16
50.00%
[2729, 2764, 2780, 2781, 2787, 2797, 2807, 2871]

:large_blue_circle:
com/starrocks/lake/LakeMaterializedView.java
2
3
66.67%
[180]

:large_blue_circle:
com/starrocks/catalog/Table.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/Column.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/CatalogUtils.java
10
10
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/Catalog.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
4
4
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 31 / 44 (70.45%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/lake/LakeTable.java
0
3
00.00%
[210, 211, 213]

:large_blue_circle:
com/starrocks/catalog/MaterializedView.java
1
2
50.00%
[839]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
8
16
50.00%
[2729, 2764, 2780, 2781, 2787, 2797, 2807, 2871]

:large_blue_circle:
com/starrocks/lake/LakeMaterializedView.java
2
3
66.67%
[180]

:large_blue_circle:
com/starrocks/catalog/Table.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/Column.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/CatalogUtils.java
10
10
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/Catalog.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
4
4
100.00%
[]

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5

@Mergifyio backport branch-2.4

@Mergifyio backport branch-3.1


Windows standalone startup script errors

Looking between jreleaser 1.10 and 1.12:
2c2
< rem Generated with JReleaser 1.10.0-SNAPSHOT at 2023-11-12T14:42:47.766560409Z
---
> rem Generated with JReleaser 1.12.0-SNAPSHOT at 2024-03-28T16:48:08.276663714Z
54a55
> set JAVA_OPTS="%JAVA_OPTS% "
59c60
< %JAVACMD% %DEFAULT_JAVA_OPTS% %JAVA_OPTS% -cp %CLASSPATH% -jar "%JARSDIRS%\spring-cli-0.7.4.jar" %CMD_LINE_ARGS%
---
> %JAVACMD% %DEFAULT_JAVA_OPTS% %JAVA_OPTS% -cp "%CLASSPATH%" -jar "%JARSDIRS%\spring-cli-0.9.0-SNAPSHOT.jar" %CMD_LINE_ARGS%

It's the JAVA_OPTS causing error:
Error: Could not find or load main class
Caused by: java.lang.ClassNotFoundException:

This doesn't effect msi installer as it's using jlink.

Instead of overriding jreleaser template files there's a PR in jreleaser to fix it in a source. We always have an option to do local override if we get trouble waiting fix.

JReleaser 1.12.0 scheduled for release by the end of April 😅

As we're still using jreleaser snapshots this issue got fixed from upstream. We'll move to 1.12.0 when it's out.


Update proactive-failure-diagnostics.md

Added a note on notification not sent when a smart detection alert is resolved

@yairgil : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @yairgil - It looks like you have a PR open for an update in the same file in the private repo. Is this a duplicate PR that can be closed? Thanks.
PMs should work in the private repo. so if the two PRs update the same article, you should use the PR that's already open in the private repo.

Hi @ktoliver
Correct, the PR in master can be closed, it was opened by mistake.
Thanks, Yair

PR opened by mistake

Hi @ktoliver
Correct, the PR in master can be closed, it was opened by mistake.
Thanks, Yair

@yairgil Super! Thanks.


python3Packages.python-telegram: fix build

Description of changes
Fixup after https://github.com/NixOS/nixpkgs/pull/266730
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Can you explain why/how it fails?

Can you explain why/how/when it fails?

We replaced find_library call with full path, but test expects find_library mock call.


[INLONG-8438][Manager] Removes the restriction that only the admin user can create DataNodes by openAPI

Prepare a Pull Request

Fixes #8438

Motivation
Removes the restriction that only the admin user can create DataNodes by openAPI.
Modifications
Removes the restriction that only the admin user can create DataNodes by openAPI.

Please check user role in controller. The delete/remove/update should be done by Inlong admin or tenant admin.


Use of MmapedDict results in fd leaks (resource leaks)

When running the test suite with -Wdefault, I get multiple reports of resource leaks, plus one of the tests is flaky and sometimes fails because of ResourceWarning being emitted where UserWarning was expected first:
$ python -m pytest -Wdefault
========================================================= test session starts =========================================================
platform linux -- Python 3.11.8, pytest-8.0.0, pluggy-1.4.0
rootdir: /tmp/client_python
collected 309 items

tests/openmetrics/test_exposition.py ....................                                                                       [  6%]
tests/openmetrics/test_parser.py .............................................                                                  [ 21%]
tests/test_asgi.py ssssssss                                                                                [ 23%]
tests/test_core.py ....................................................................................................         [ 55%]
tests/test_exposition.py ..........................................................                                             [ 74%]
tests/test_gc_collector.py ..                                                                                [ 75%]
tests/test_graphite_bridge.py .......                                                                                [ 77%]
tests/test_multiprocess.py .....................F.......                                                                        [ 87%]
tests/test_parser.py ........................                                                                                [ 94%]
tests/test_platform_collector.py ..                                                                                [ 95%]
tests/test_process_collector.py ....                                                                                [ 96%]
tests/test_samples.py ..                                                                                [ 97%]
tests/test_twisted.py s                                                                                [ 97%]
tests/test_wsgi.py .......                                                                                [100%]

============================================================== FAILURES ===============================================================
_____________________________________________ TestMultiProcess.test_remove_clear_warning ______________________________________________

self = <tests.test_multiprocess.TestMultiProcess testMethod=test_remove_clear_warning>

    def test_remove_clear_warning(self):
        os.environ['PROMETHEUS_MULTIPROC_DIR'] = self.tempdir
        with warnings.catch_warnings(record=True) as w:
            values.ValueClass = get_value_class()
            registry = CollectorRegistry()
            collector = MultiProcessCollector(registry)
            counter = Counter('c', 'help', labelnames=['label'], registry=None)
            counter.labels('label').inc()
            counter.remove('label')
            counter.clear()
            assert os.environ['PROMETHEUS_MULTIPROC_DIR'] == self.tempdir
>           assert issubclass(w[0].category, UserWarning)
E           AssertionError: assert False
E            +  where False = issubclass(<class 'ResourceWarning'>, UserWarning)
E            +    where <class 'ResourceWarning'> = <warnings.WarningMessage object at 0x7f22956b82d0>.category

tests/test_multiprocess.py:395: AssertionError
========================================================== warnings summary ===========================================================
tests/test_exposition.py::TestPushGateway::test_push_with_tls_auth_handler
  /usr/lib/python3.11/urllib/parse.py:480: ResourceWarning: unclosed <socket.socket fd=37, family=2, type=1, proto=0, laddr=('<IP_ADDRESS>', 40145)>
    for b in _UNSAFE_URL_BYTES_TO_REMOVE:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_exposition.py::TestPushGateway::test_push_with_tls_auth_handler
  /usr/lib/python3.11/urllib/parse.py:480: ResourceWarning: unclosed <socket.socket fd=38, family=2, type=1, proto=0, laddr=('<IP_ADDRESS>', 46167)>
    for b in _UNSAFE_URL_BYTES_TO_REMOVE:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_collect
  <frozen os>:676: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmp9on9bz25/counter_1334413.db' mode='ab+' closefd=True>
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_all
  /usr/lib/python3.11/glob.py:176: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpp8qzgxdb/counter_1.db' mode='ab+' closefd=True>
    with contextlib.closing(_iterdir(dirname, dir_fd, dironly)) as it:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_all
  /usr/lib/python3.11/glob.py:176: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpp8qzgxdb/gauge_all_1.db' mode='ab+' closefd=True>
    with contextlib.closing(_iterdir(dirname, dir_fd, dironly)) as it:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_all
  /usr/lib/python3.11/glob.py:176: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpp8qzgxdb/histogram_1.db' mode='ab+' closefd=True>
    with contextlib.closing(_iterdir(dirname, dir_fd, dironly)) as it:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_all
  /usr/lib/python3.11/glob.py:176: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpac3ow5d8/counter_1.db' mode='ab+' closefd=True>
    with contextlib.closing(_iterdir(dirname, dir_fd, dironly)) as it:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_all
  /usr/lib/python3.11/glob.py:176: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpac3ow5d8/gauge_all_1.db' mode='ab+' closefd=True>
    with contextlib.closing(_iterdir(dirname, dir_fd, dironly)) as it:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_all
  /usr/lib/python3.11/glob.py:176: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpac3ow5d8/histogram_1.db' mode='ab+' closefd=True>
    with contextlib.closing(_iterdir(dirname, dir_fd, dironly)) as it:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_all
  /usr/lib/python3.11/glob.py:176: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpx3sjgfk6/counter_1.db' mode='ab+' closefd=True>
    with contextlib.closing(_iterdir(dirname, dir_fd, dironly)) as it:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_all
  /usr/lib/python3.11/glob.py:176: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpq0v2xj70/counter_123.db' mode='ab+' closefd=True>
    with contextlib.closing(_iterdir(dirname, dir_fd, dironly)) as it:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_all
  /usr/lib/python3.11/glob.py:176: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpq0v2xj70/counter_456.db' mode='ab+' closefd=True>
    with contextlib.closing(_iterdir(dirname, dir_fd, dironly)) as it:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_mostrecent
  /tmp/client_python/prometheus_client/mmap_dict.py:86: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpoa1u3zei/gauge_liveall_123.db' mode='ab+' closefd=True>
    with open(filename, 'rb') as infp:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_mostrecent
  /tmp/client_python/prometheus_client/mmap_dict.py:86: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpoa1u3zei/gauge_liveall_456.db' mode='ab+' closefd=True>
    with open(filename, 'rb') as infp:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_mostrecent
  /tmp/client_python/prometheus_client/mmap_dict.py:86: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpkwjjpl18/gauge_livemax_123.db' mode='ab+' closefd=True>
    with open(filename, 'rb') as infp:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_mostrecent
  /tmp/client_python/prometheus_client/mmap_dict.py:86: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpkwjjpl18/gauge_livemax_456.db' mode='ab+' closefd=True>
    with open(filename, 'rb') as infp:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_mostrecent
  /tmp/client_python/prometheus_client/mmap_dict.py:86: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmp02r2ouao/gauge_livemin_123.db' mode='ab+' closefd=True>
    with open(filename, 'rb') as infp:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_mostrecent
  /tmp/client_python/prometheus_client/mmap_dict.py:86: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmp02r2ouao/gauge_livemin_456.db' mode='ab+' closefd=True>
    with open(filename, 'rb') as infp:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_mostrecent
  /tmp/client_python/prometheus_client/mmap_dict.py:86: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpryrzvlpo/gauge_livemostrecent_123.db' mode='ab+' closefd=True>
    with open(filename, 'rb') as infp:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_mostrecent
  /tmp/client_python/prometheus_client/mmap_dict.py:86: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpryrzvlpo/gauge_livemostrecent_456.db' mode='ab+' closefd=True>
    with open(filename, 'rb') as infp:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_mostrecent
  /tmp/client_python/prometheus_client/mmap_dict.py:86: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpribv4xj9/gauge_livesum_123.db' mode='ab+' closefd=True>
    with open(filename, 'rb') as infp:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_mostrecent
  /tmp/client_python/prometheus_client/mmap_dict.py:86: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpribv4xj9/gauge_livesum_456.db' mode='ab+' closefd=True>
    with open(filename, 'rb') as infp:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_mostrecent
  /tmp/client_python/prometheus_client/mmap_dict.py:86: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmp22gzxk2n/gauge_max_123.db' mode='ab+' closefd=True>
    with open(filename, 'rb') as infp:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_mostrecent
  /tmp/client_python/prometheus_client/mmap_dict.py:86: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmp22gzxk2n/gauge_max_456.db' mode='ab+' closefd=True>
    with open(filename, 'rb') as infp:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_mostrecent
  /tmp/client_python/prometheus_client/mmap_dict.py:86: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmp6n8vag2o/gauge_min_123.db' mode='ab+' closefd=True>
    with open(filename, 'rb') as infp:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMultiProcess::test_gauge_mostrecent
  /tmp/client_python/prometheus_client/mmap_dict.py:86: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmp6n8vag2o/gauge_min_456.db' mode='ab+' closefd=True>
    with open(filename, 'rb') as infp:
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMmapedDict::test_expansion
  /tmp/client_python/.tox/py311/lib/python3.11/site-packages/_pytest/unittest.py:211: ResourceWarning: unclosed file <_io.BufferedRandom name='/tmp/tmptd9lerf6'>
    self._obj = None
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMmapedDict::test_multi_expansion
  /tmp/client_python/.tox/py311/lib/python3.11/site-packages/_pytest/unittest.py:211: ResourceWarning: unclosed file <_io.BufferedRandom name='/tmp/tmp4ho56w3t'>
    self._obj = None
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMmapedDict::test_process_restart
  /tmp/client_python/.tox/py311/lib/python3.11/site-packages/_pytest/unittest.py:211: ResourceWarning: unclosed file <_io.BufferedRandom name='/tmp/tmpp3siphvy'>
    self._obj = None
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_multiprocess.py::TestMmapedDict::test_process_restart
  /tmp/client_python/.tox/py311/lib/python3.11/site-packages/_pytest/runner.py:546: ResourceWarning: unclosed file <_io.BufferedRandom name='/tmp/tmpqi5kklpc'>
    fin()
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_parser.py::TestParse::test_untyped
  /tmp/client_python/tests/test_parser.py:18: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmp8lpdamo1/summary_123.db' mode='ab+' closefd=True>
    for sa, sb in zip(a.samples, b.samples):
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

tests/test_parser.py::TestParse::test_untyped
  /tmp/client_python/tests/test_parser.py:18: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmp8lpdamo1/summary_456.db' mode='ab+' closefd=True>
    for sa, sb in zip(a.samples, b.samples):
  Enable tracemalloc to get traceback where the object was allocated.
  See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================================================= short test summary info =======================================================
FAILED tests/test_multiprocess.py::TestMultiProcess::test_remove_clear_warning - AssertionError: assert False
======================================== 1 failed, 299 passed, 9 skipped, 32 warnings in 4.10s ========================================

An example tracemalloc output:
$ PYTHONTRACEMALLOC=20 python -m pytest -Wdefault
[…]
tests/test_parser.py::TestParse::test_untyped
  /usr/lib/python3.11/typing.py:362: ResourceWarning: unclosed file <_io.FileIO name='/tmp/tmpyaxyl9i6/summary_456.db' mode='ab+' closefd=True>
    return cached(*args, **kwds)

  Object allocated at:
    File "/tmp/client_python/.tox/py311/lib/python3.11/site-packages/_pytest/runner.py", line 114
      runtestprotocol(item, nextitem=nextitem)
    File "/tmp/client_python/.tox/py311/lib/python3.11/site-packages/_pytest/runner.py", line 133
      reports.append(call_and_report(item, "call", log))
    File "/tmp/client_python/.tox/py311/lib/python3.11/site-packages/_pytest/runner.py", line 226
      call = call_runtest_hook(item, when, **kwds)
    File "/tmp/client_python/.tox/py311/lib/python3.11/site-packages/_pytest/runner.py", line 265
      return CallInfo.from_call(
    File "/tmp/client_python/.tox/py311/lib/python3.11/site-packages/_pytest/runner.py", line 345
      result: Optional[TResult] = func()
    File "/tmp/client_python/.tox/py311/lib/python3.11/site-packages/_pytest/runner.py", line 266
      lambda: ihook(item=item, **kwds), when=when, reraise=reraise
    File "/tmp/client_python/.tox/py311/lib/python3.11/site-packages/pluggy/_hooks.py", line 501
      return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
    File "/tmp/client_python/.tox/py311/lib/python3.11/site-packages/pluggy/_manager.py", line 119
      return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
    File "/tmp/client_python/.tox/py311/lib/python3.11/site-packages/pluggy/_callers.py", line 102
      res = hook_impl.function(*args)
    File "/tmp/client_python/.tox/py311/lib/python3.11/site-packages/_pytest/runner.py", line 173
      item.runtest()
    File "/tmp/client_python/.tox/py311/lib/python3.11/site-packages/_pytest/unittest.py", line 333
      self._testcase(result=self)  # type: ignore[arg-type]
    File "/usr/lib/python3.11/unittest/case.py", line 678
      return self.run(*args, **kwds)
    File "/usr/lib/python3.11/unittest/case.py", line 623
      self._callTestMethod(testMethod)
    File "/usr/lib/python3.11/unittest/case.py", line 579
      if method() is not None:
    File "/tmp/client_python/tests/test_multiprocess.py", line 79
      s2 = Summary('s', 'help', registry=None)
    File "/tmp/client_python/prometheus_client/metrics.py", line 151
      self._metric_init()
    File "/tmp/client_python/prometheus_client/metrics.py", line 513
      self._count = values.ValueClass(self._type, self._name, self._name + '_count', self._labelnames,
    File "/tmp/client_python/prometheus_client/values.py", line 68
      self.__reset()
    File "/tmp/client_python/prometheus_client/values.py", line 82
      files[file_prefix] = MmapedDict(filename)
    File "/tmp/client_python/prometheus_client/mmap_dict.py", line 64
      self._f = open(filename, 'rb' if read_mode else 'a+b')

This is with 0.20.0 (7a80f001237fe881d3607861947292abc85bf205).

This seems to be because the MmapedDict objects in the 'files' attribute are not having '.close()' called on them. As a workaround, in my unittests I monkey patched a del function onto them that calls the '.close()' function when they are garbage collected and this stopped the resource warnings. This is obviously a hack but was the best I could do at the time. The MmapedDict class wrapped in a function using the 'files' closure attribute makes it hard to nicely clean up.


Replace ZeroClipboard with Clipboard.js

See #4217
clipboard.js now supports Safari 10.0+

Thanks for the review


bug(navigation): no color on top mat-toolbar on version 18.1.2 (works with v17.3.8)

Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
v17.3.8
Description
The top mat-toolbar generated from @angular/material:navigation does not have any color.
The css in v18:
.mat-toolbar.mat-primary[_ngcontent-ng-c3026548424] {
    position: sticky;
    top: 0;
    z-index: 1;
}

The css in v17:
.mat-toolbar.mat-primary {
    background: #3f51b5;
    color: #fff;
}

Reproduction
$ npm install<EMAIL_ADDRESS>$ ./node_modules/.bin/ng new --skip-git myapp
? style format: css (default)
? server-side rendering: no (default)

$  cd myapp
$ ./node_modules/.bin/ng add @angular/material
? prebuilt theme: indigo/pink (default)
? global typography styles: no (default)
? include animation: include and enable (default)

$ ./node_modules/.bin/ng generate @angular/material:navigation main-nav

# Add <ng-content></ng-content> in main-nav.component and replace app.component template by <app-main-nav>Hello World</app-main-nav>

$ ./node_modules/.bin/ng serve

Expected Behavior
How it looks like in v17

Actual Behavior
How it looks like in v18

Environment

Angular: 18.1.2
CDK/Material<EMAIL_ADDRESS><EMAIL_ADDRESS>Browser(s): Brave 1.68.128 Chromium: 127.0.6533.73 (Official Build) (64-bit)
Operating System (e.g. Windows, macOS, Ubuntu): Archlinux x64

The mat-toolbar does not have a background color in M3 like it used to in M2. See this example: https://material.angular.io/components/toolbar/examples#toolbar-basic
Although you update the background with custom styles. Changing this CSS variable should allow you to update the background color: --mat-toolbar-container-background-color

Is it possible to use mat.get-theme-color function ?
It looks like function are called only for properties, not variables.
:root {
  some-property: mat.get-theme-color($theme, primary, 50);
  --mat-toolbar-container-background-color: rgb(0, 87, 201);
  --mat-toolbar-container-background-color: mat.get-theme-color($theme, primary, 50);
}


Accept multiple arguments

The program should accept multiple arguments and find organizations which uses at least one of them.


WiremockServer class expose verify with CountMatchingStrategy

WireMock class seems to have very useful method called
verifyThat(CountMatchingStrategy expectedCount, RequestPatternBuilder requestPatternBuilder)
which is being used by wiremockServer class in this method:
 public void verify(int count, RequestPatternBuilder requestPatternBuilder)
Unfortunately this method takes only exact number, not a CountMatchingStrategy.
can you please expose version with CountMatchingStrategy also?

Do you feel like creating a pull request?

sure, I can raise one next week if that's ok

Fine by me


gst-plugins-base: apply patch for CVE-2019-9928

Motivation for this change
Refactor the patchPhase management for the package along the way to
something more standard.
#70097 (security bug)
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build gst-plugins-base


Resetting components tabs no longer removes tab from UI - 1.1.16-11

Look like fix to https://github.com/valor-software/ng2-bootstrap/issues/696 (thanks BTW) may have broken something.
Changing a components tabs no longer causes the old tabs to go away.
HTML
<tabset>
	<tab *ngFor="let tabz of tabs"
        ....

Component
private tabs: any[];
...
in ngOnInit
this.tabs = [...]
at some point in the future
this.tabs = [...]
Original tabs from onInit should go away and be replaced with new tabs. Instead original tabs are still on screen along with new ones.
(Actual use case is my workaround described in https://github.com/valor-software/ng2-bootstrap/issues/699 where I veto tab selection by replacing the current tab state with the previous tab state. This seems to be a bug in any case but perhaps its time for me to revisit that, maybe something has changed since then)

The same problem here. Works with 1.1.16, but not with 1.1.16-11.

Ironically my workaround to allow me to grab new versions of ng2-bootstrap is now to add:
(TabDirective as any).prototype.ngOnDestroy = function () {
  this.tabset.removeTab(this);
};

similar issue with 1.1.16-11, when I remove any entry essentially from tabs the tab stays there.

@slubowsky I had to removed because of another issue, with multiply events triggering on page destroy >.<

@valorkin I know. I authored that issue :) but I have a workaround in place for that one already (see that issue where someone discusses something similar to what I did) so basically just reverting back to that state for now.

Why not just have TabDirective.OnDestroy pass a flag that says not to event the removal or something simple like that?

@slubowsky 's suggestion, in my opinion, is the best way to solve it.
Here are my analysis and current workaround:
I think the root of the problem is there are two sets of 'tabs' being maintained, one is the 'tabs' provided/maintained by our client code(let's call it ClientTab), another is the set of TabDirective maintained by the library.
Analysis:
In order for the library to function properly, we have to guarantee that these two sets of 'tabs' are synced probably, which means:

When a ClientTab is created, a corresponding TabDirective shall also be created.
When a ClientTab is destroyed, its corresponding TabDirective shall also be destroyed.
When a TabDirective is closed by a user action (clicking on the remove button), its corresponding ClientTab shall also be destroyed.

In the previous version, 1 and 2 are well maintained. The problem is with 3, as the removed (and the cascading select ) event fires when

user clicks on the remove button
or the TabDirective is destroyed when the whole containing view is being destroyed (for example, switching to another route).

and our client code is unable (at least not as I can perceive) to distinguish these two scenarios, thereafter, we cannot maintain our ClientTab states properly. For example, if:

we have some tabs open and one active tab
switch to another route
then switch back, we want to see the same set of tabs and the same active tab.

This was broken because in the previous version, when switching to another route, removed and select events got fired inevitably and our ClientTab states got messed up.
By removing the ngOnDestroy in TabDirective, we are able to fix this problem. But, by doing so, we break the rule 2:

When a ClientTab is destroyed, its corresponding TabDirective shall also be destroyed.

because when a TabDirective got destroyed with the ClientTab, it failed to remove itself from its TabsetComponent 's state and therefore got recreated later.
Current workaround:
When a ClientTab got removed, we remove its corresponding TabDirective from the TabsetComponent manually. Assuming:

TabDirective and ClientTab have the one-to-one relationship and their positions are the same in the lists they reside.
We can get a hold of the TabsetComponent by using the ViewChild API.

then
let idx = ...
clientTabsList.split(idx, 1);
tabset.removeTab(tabset.tabs[idx])

Notice this remove operation will fire the removed event and the possibly cascading select event as well, we need to handle them probably.

Thanks for the guidance, guys!
In Typescript I am doing this to get hold of Tabset component:
export class PriorityDataComponent implements OnInit {
@ViewChild(TabsetComponent)
private ts: TabsetComponent;
and this to replace old tabs with new ones:
       ..................

// Clear old tabs
while (this.ts.tabs[0] != null){
this.ts.removeTab(this.ts.tabs[0])
}
// Insert new tabs
this.tabs = [];
                newValue.forEach(p => {
                    let tab = new PriorityTab(p);
                    this.tabs.push(tab)});

                this.setActiveTab(0);

       ..................

Sorry I that I did not know how to format the code properly!

I'm having this issue on 1.3.1 as well. Any signs of it being officially fixed?

Not yet

What's the current state on this, also facing this issue right now!

While trying to hack TabDirective, I found another Bootstrap feature that could achieve similar results: Button>Radio. This alternate approach addresses the issue of old tabs not being removed after routing to a new component like so:
Import ButtonsModule as usual,
//Assuming you use Angular-cli
import { ButtonsModule } from 'ng2-bootstrap';

@NgModule({
  imports: [ButtonsModule.forRoot(),...]
})

Then simply use it like so:
<div class="btn-group">
  <label
      *ngFor="let item of collection"
      (click)="routeSomewhere(item.title)"
      class="btn btn-primary"
      [(ngModel)]="radioModel"
      btnRadio="{{item.title}}">
      {{item.title}}
      </label>
</div>

We add a (click) event to fire off a method routeSomewhere that in turn does the routing. The radio buttons act like tabs because only one can be active. It has the extra benefit of showing the active state / selected button. Hope that helps.

Any news about this bug? I still have it in version 1.6.6

The fact this still exists, is stupid... I think i'll use some other framework.

fix published in v1.7+

fixed by https://github.com/valor-software/ngx-bootstrap/pull/1941


"Parameter is never cleared or assigned" in CALL TRANSFORMATION block

Hello there,
I have the following method:
METHOD serialize.
  " TODO: parameter RESULT is never cleared or assigned (ABAP cleaner)

  CALL TRANSFORMATION id
       SOURCE values = object
       RESULT XML result.
ENDMETHOD.

ABAP cleaner gives the warning that result is never assigned, even though the call of "CALL TRANSFORMATION ... RESULT XML result" assigns a new value to result.

Hi Niko,
thanks a lot for reporting this! This bug will be fixed with the next release.
Kind regards,
Jörg-Michael

Hi Niko,
this bug should now be fixed with version 1.15.0, which was just released! Thanks again for opening this issue.
Kind regards,
Jörg-Michael


fix: update validation for wallet name, include upper case and spaces for the consistency with default wallet name

fix: update validation for wallet name, including upper case and spaces for the consistency with default wallet name
The issue with the wallet name if submitting the default one.
Updated validation and added more cases for the upper case and spaces, to be consistent with the default wallet name, right now is possible to create Wallet Name 5, and it will be valid.

record:
https://github.com/spacemeshos/smapp/assets/54288612/cf2ffc40-16b5-41b1-b5f0-48d3a45c8bb2

LGTM, will approve after changes suggested by K


specs: VEP proposal for VDK Properties Based Configuration

This VEP proposes a new provider for VDK configuration that allows users to set job-specific configuration for data jobs.
Currently, users can only set configuration using environment variables or the config.ini file, both of which have limitations. The new provider will take configuration from properties with the "vdk.config." prefix and have lesser priority than environment variables and the config.ini file.

Closed due to inactivity for more than a month


how to add some animation on APAlertView when present & dismiss

Hi hywoody,
Thanks for raising an issue.
I have added animation and updated the repository. thanks

Hi hywoody,
Thanks for raising an issue. I have added animation and updated the repository. thanks

thx, that's very kind of you


[Q] How we can watch satellite tv on phone or pc with app by only internet so that it uses internet very very few?

I assume that you are looking for IP streaming services of satellite channels over Internet. This is has nothing to do with TSDuck. And the vast majority of these services are illegal (even though sometimes their web pages dare to mention it is legal...)

Hi @haddi21fr ,
You need to transcode the source with a very high compression. And this is not the objective of this tool. Perhaps you want to consider the tvheadend tool for this objective.
Regards.


Viewport customization

Add options to customize carousel viewport: count of elements, width of slide, side offsets, gridding. You should be able to display a grid of slides at each index/position of carousel, swipe up/down or left/right, customize the representation of upcoming left/right side positions

Slide sizing (width, height) was implemented in #4


GNU License or MIT License ?

Jodit Version:  3.2.xxxxx
Browser:
OS:
Code
// A *self-contained* demonstration of the problem follows...

Expected behavior:
Hello, I am planning to use Jodit but I am confused about if i can use this. I am not sure if whether the license is MIT or GNU.
@xdan , Can you please update on this. The Repository says MIT but the Website says GNU.
Actual behavior:
A confirmation on the License will be helpful

@Vbboi24 MIT of course! Send me please link on the website about GNU, I will fix it

Hey @xdan , Found this on the homepage https://xdsoft.net/jodit/
Thanks for clarifying. Cheers!


fix: Incorrect exports

Closes #68, Closes #77, Closes #62, Closes #60...
We need to mimic the behaviour of Node ESM resolution and my testing so far without the loader suggests that:

export * from only exports named exports and we don't need to pass through default exports
If there are duplicate named exports, none of these should be exported

Ideally we should have tests that ensure that module exports are identical both with and without the loader hook because currently this isn't the case.
To accomplish the above:

I've added mapExcludingDuplicates for setters which does as it suggests
Removed auto-renaming of default exports as this doesn't appear to be what Node does (ie. #68)
Use the export name as the Map key so we remove duplicates
In the emitted code, only add exports to _ if there a corresponding key in set. Without this, the exports passed to Hook don't match the final module exports

Closing in favour of #85 which removes more redundant code


Feature Request: add scroll to top and to bottom button

Note: there is already a button for scrolling to the bottom of the screen.

Note: there is already a button for scrolling to the bottom of the screen.

Yes, I've seen it. Do you think It is necessary to add a scroll to top button?

I think it's far rarer to need to scroll to the top than the bottom, but could still occasionally be useful


🐛 photo={true} and keeps returning an error that is not enabled

What's happening?
even though I set
photo = true,
[capture/photo-not-enabled: [capture/photo-not-enabled] Photo capture is disabled! Pass photo={true} to enable photo capture.]
I got this error, and as others issues, my camera gets black and doesn't return to normal state.
Reproduceable Code
<Camera
                        ref={camera}
                        style={StyleSheet.absoluteFill}
                        device={device}
                        isActive={showCamera}
                        photo={true}
                        onError={(error) => {cameraOnError}}
                        onInitialized={() => {setShowCamera(true)}}

                    />

Relevant log output
[capture/photo-not-enabled: [capture/photo-not-enabled] Photo capture is disabled! Pass `photo={true}` to enable photo capture.]

Camera Device
{
  "sensorOrientation": "landscape-right",
  "hardwareLevel": "limited",
  "maxZoom": 4,
  "minZoom": 1,
  "maxExposure": 200,
  "supportsLowLightBoost": false,
  "neutralZoom": 1,
  "physicalDevices": [
    "wide-angle-camera"
  ],
  "supportsFocus": true,
  "supportsRawCapture": false,
  "isMultiCam": false,
  "minExposure": -200,
  "name": "BACK (0)",
  "hasFlash": true,
  "hasTorch": true,
  "position": "back",
  "id": "0"
}

Device
samsung galaxy
VisionCamera Version
3.6.17
Can you reproduce this issue in the VisionCamera Example app?
I didn't try (⚠ your issue might get ignored & closed if you don't try this)
Additional information

[ ] I am using Expo
[X] I have enabled Frame Processors (react-native-worklets-core)
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

the error seems to be on the device definition, since I changed back to front and it opens the camera, but when I take the photo it gets black again. When I change again to back device it opens just for one photo and then blacks out.

I have the same issue here on the OnePlus.
LIbrary version 3.6.17
Android version 13
 <PinchGestureHandler enabled={isActive} onGestureEvent={onPinchGesture}>
      <Reanimated.View style={theme.styles.flex1}>
        <TapGestureHandler numberOfTaps={2}>
          <ReanimatedCamera
            animatedProps={cameraAnimatedProps}
            device={device!}
            isActive={true}
            onError={(error) => logger.error({ tag: TAG, error, message: error?.message })}
            onInitialized={() => setIsCameraReady(true)}
            orientation="portrait"
            ref={ref}
            video={false}
            enableHighQualityPhotos
            photo={true}
          />
        </TapGestureHandler>
      </Reanimated.View>
    </PinchGestureHandler>

Same thing!

Hey - weird issue!
Can you try if my PR fixes this issue? https://github.com/mrousavy/react-native-vision-camera/pull/2339

Hey Marc, this problem is solved, but the blackout in the camera, for me, didn't change...... still has this strange behavior working only once when I change the device to back to front......
I downloaded the commited code inside my project, but still returns this error.

Someone else said that the blackscreen issue is fixed: https://github.com/mrousavy/react-native-vision-camera/issues/2340#issuecomment-1878931287
Can you share a video and logs of the issue? @juliacremus

"react-native-vision-camera": "^3.6.16",
"react-native": "0.72.4",
  const renderCamera = useCallback(() => {
    return (
      <Camera
        onInitialized={onInitialized}
        onError={_ => {
          console.log('Camera', _);
        }}
        ref={camera}
        enableHighQualityPhotos={true}
        style={[
          {
            flex: 1,

            borderWidth: 0,
            zIndex: 0,
            width: width,
            height: height,
          },
        ]}
        photo={true}
        device={device}
        isActive={isActiveCamera && isCameraInitialized && isFocused}
      />
    );
  }, [isActiveCamera, isCameraInitialized, isFocused, device]);

Someone else said that the blackscreen issue is fixed: #2340 (comment)
Can you share a video and logs of the issue? @juliacremus

@NoatToan please share the full logs. Not a screenshot showing three lines of logs.

@mrousavy Sorry my mistake.
Here is for you. Hope that you will know and help me fix the issue.
photo_true_issue.md

it still happened in version 4.0.3

@NoatToan please share the full logs. Not a screenshot showing three lines of logs.


Unstable servers

These last days I've been having issues with my connection to JupyterHub servers. Today I've had my server stopped twice while running simulations. All of the sudden my connection dropped and I had to start again a server. This is particularly annoying when working with Julia, since one needs to download and re-compile all the packages.
Is there a reason behind this unstable behaviour? Thanks again for your help!

Today I've had my server stopped twice while running simulations. All of the sudden my connection dropped and I had to start again a server.

While you were actively using your server via your browser etc, not just running a script in a terminal over the night etc, your server is shut down and soon you see that jupyterhub gives you a "start server" button / choice on what server type to start?
What kind of server have you chosen? Was it a shared 1/16th, shared 1/4th, or dedicated server of some size?

Yes, while running simulations directly from VSCode (i.e. active development and launching simulations). First I see that the VSCode connection has dropped, then I go to the launch pad or to a terminal and it asks to restart the server.
I'm using a dedicated "massive" machine.

@JordiBolibar are you using SSH from your local computer or VSCode from your local computer, or are you doing everything from browsing hub.jupytearth.org ?

I'm running everything directly on the browser (including VSCode). So no SSH.

@JordiBolibar thanks, investigating further - about when was the last server shutdown event? It can help me find relevant log entries in a sea of logs?

This morning, between 9 and 11 am CET, I had 2 shutdowns.

@JordiBolibar is this the named server called ODINN, or something else?

Yes, I'm using ODINN and ODINN-2. I think this morning I only used ODINN.

I observe this in the logs of JupyterHub, so it seems that your server is getting culled by considered to be inactive. All times below are in UTC time, so one hour behind CET.
# march 1st, 13:11 CET time
[I 220301 12:11:26 __init__:190] Culling server jordibolibar/ODINN (inactive for 01:08:54)
# march 1st, 23:21 CET time
[I 220301 22:21:26 __init__:190] Culling server jordibolibar (inactive for 01:03:12)
# march 2nd, 21:01 CET time
[I 220302 20:01:26 __init__:190] Culling server jordibolibar (inactive for 01:07:32)
# march 3rd, 17:11 CET time
[I 220303 16:11:26 __init__:190] Culling server jordibolibar (inactive for 01:00:35)

In #105 we discussed a workaround, are these shutdowns following having applied such workaround or not?

Well, that was to leave simulations running overnight. Here I am actively using the session. The thing is that I've had zero issues with the same working routine until some days ago.
And BTW, the Jupyter notebook with the sleep command only did the trick sometimes. In the last month it stopped working and my server was getting stopped anyway.

On the 64 CPU node you are running now, you should have at least 224 GB of memory.  I think I was running a very memory expensive task on several nodes, so I basically blew the memory of the server. I controlled memory usage and I'm using the notebook sleep trick to keep the kernel alive, and so far it is working better. I still get the note shut down sometimes, despite these measures, but it is way less frequent.


Error when running the application

Hi Team,
The CI/CD implementation for your project works well. The Jenkins pipeline stages are implemented properly. I also liked that you have used Docker in this milestone. But I am getting an error when I try to run the application. I get the following error in add listing.

We have fixed this issue. Please check if you are able to perform the functionalities.

Hi, I am now able to perform the functionality.


Server side metrics

@hacktobeer ptal

LGTM. The example server_tasks I added can of. course be removed if you deem it duplicate :).


too much bug in RC1

I very regret put my project upgrade to RC1,EF of RC1 version brings more new BUG, my project from Beta 4 to beta 8 has been work good, today I upgrade to RC1,EF was not worked, first is inherited mapping of problem, if base class has Object type property inherited mapping will throw Exception, even using has "ignore" method also has the same problem, when i fix this （remove the object propery）i think it will work fine, I am wrong !  Then new BUG（https:// Github.com/aspnet/EntityFramework/issues/3679 ）appeared , I spent the whole day did not solve, please don't release often the BUG out version, it impossible to achieve the quality of RC, ASP.NET 5 works good except the EF, would return to EF6? I really do not want to use EF7, very painful each time you upgrade, not to change the rules again and again, please!!

RC version of such a low quality as there are no tests, beta8 is much better than it !!!!!

In your case I would stick with EF 6.  You need to accept there will be bugs at this early stage in the products life-cycle.  It is not really in the spirit of opensource to blame bugs on others.  The idea is that these bugs get visibility to a wider audience and the quality of the end product actually benefits.

@mikes-gh
In the beta stage, we are always happy to help improve the project, we think at the time to release a RC version, stable and less BUG should be the ultimate goal,but what we see is more BUG than the beta stages, rules and logic kept changing, it cannot be called RC, more appropriate perhaps beta9, It's very disappointing that more and more developers want to return back to EF6, we grow together and EF7 for half a year, but its progress is very slow, too many BUG is still opened。
Compare ASP.NET 5 (MVC), it has become more and more stable, we are confident that they can release RTM on time, what about EF7 ?  No body know how long it will take to RTM。

@endink Unfortunately, the EF team have been forced to follow the same release cycle as ASP.NET 5, so an EF RC may not mean the same as an ASP.NET RC, as you have noticed. But you have to accept that there are bugs and even regressions in software under developemnt.

Closing because there is nothing actionable here. Please continue to file bugs for individual issues that you find.
You can find some info on using EF6 with ASP.NET 5 here; https://docs.asp.net/en/latest/data/entity-framework-6.html


android.app.ProgressDialog' is deprecated as of API 26 ("Oreo"; Android 8.0)

looks like this feature is deprecated, is there a fix for newer versions?
ps: got it working under android 7.1.1 but would still be better if it would support newer versions, smth like from android 9, everything earlier is irrelevant ig noone is using old android (and if someone does i wouldnt support it for obvious reasons)

As this component is not essential for the whole thing to work, you can simply remove this from your app, and replace it with your own custom loading animation by using javascript + GIF or SVG animation (for example: https://loading.io/). by doing so, you can even have seemless user experience accross different platform (web, ios, android).

for some reason, I somehow feel that this feature is sometime annoying. The ProgressDialog appears every time when the app is trying to accessing a page. I will replace this with SVG loading animation in my future project.

As this component is not essential for the whole thing to work, you can simply remove this from your app, and replace it with your own custom loading animation by using javascript + GIF or SVG animation (for example: https://loading.io/). by doing so, you can even have seemless user experience accross different platform (web, ios, android).

okay will do that, thanks man
that means i have to remove exactly this paragraph right?
// initialize the progressDialog
progressDialog = new ProgressDialog(MainActivity.this);
progressDialog.setCancelable(true);
progressDialog.setMessage("Loading...");
progressDialog.show();

I have a question about back btn it doesn't work when I go back it switches off the app needs back button and splash update maybe

that doesn't use anyone maybe but gives errors with hardware back btn goes behind works


prisma2 dev stacktrace output detail

Seems on crash the stacktrace output has stack backtrace: at the beginning and the end currently:

I would also like to add additional new lines before and after the stack trace, wdyt?

Yes, that would probably make sense as well.
Note that on Linux and macOS the "Please help us improve ..." error reporting modal thing might look a lot different already and be better separated from the stracktrace.

@pantharshit00 Can you please reproduce this?

Unable to reproduce now, it is hard for me to produce that big of a backtrace now as connection issues are handled by our error handling logic and invalid lift steps are also properly handled.
If I encounter a larger stacktrace like that, I will reopen this.


Ability to enable and disable "stickyness"

Is it possible to convert sticky headers to normal header items that just scroll of the screen like all the normal items?

On Apr 2, 2015 8:24 AM, "MichaelFlisar"<EMAIL_ADDRESS>wrote:

Is it possible to convert sticky headers to normal header items that just
scroll of the screen like all the normal items?
—
Reply to this email directly or view it on GitHub
https://github.com/timehop/sticky-headers-recyclerview/issues/39.

I would like to toggle it. My use case is, that I want to use the same adapter in two places, in one with sticky headers and in another with normal headers. So it would be nice to have this possibility.

It's definitely possible but I don't think it's common enough of a use case
to include in the library. It should be rather easy with a small
modification to the source. I can point you in the right direction if you'd
like.
On Apr 3, 2015 1:33 AM, "MichaelFlisar"<EMAIL_ADDRESS>wrote:

I would like to toggle it. My use case is, that I want to use the same
adapter in two places, in one with sticky headers and in another with
normal headers. So it would be nice to have this possibility.
—
Reply to this email directly or view it on GitHub
https://github.com/timehop/sticky-headers-recyclerview/issues/39#issuecomment-89186902
.

Actually, I do it manually now. I use getItemViewType and add the headers to the data...
I haven't looked into your code yet, so pointing me into the right direction will definitely help me...
Btw, think of users writing their own base adapters that extends yours, they may put together their own code with libraries like yours and write a super adapter. That's actually what I do and that's why a simple switch between headers and sticky headers would be nice for me. But I understand your point of view.

I disabled this on a branch for you so you can see how it's done.  Simply remove Math.max() and remove the getTop() (or getLeft()).  Check it out here.  If you want to find a way to integrate it into the library without breaking the API we may consider merging it.

Thanks a lot, that's really nice from you


FCM Sender ID (null)

Expected Behaviour
GoogleService-Info.plist is correctly placed in the root folder, <resource-file src="GoogleService-Info.plist" /> is correctly placed under the iOS platform. The plugin is expected to use FCM.
Actual Behaviour
Uses APNS instead
Steps to Reproduce
Install the plugin and follow the instructions ;)
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
iOS 11
Cordova CLI version and cordova platform version
Cordova 7.01
Plugin version
Github latest (2.0.0)
Logs taken while reproducing problem
2017-10-01 02:02:18.849202+0200 APP[1185:294928] FCM Sender ID (null)
2017-10-01 02:02:18.849241+0200 APP[1185:294928] Using APNS Notification
My push config:
  var push = PushNotification.init({
      "android": {
        "senderID": senderId
      },
      "ios": {
        "gcmSandbox": false, //also attempted setting this to true, as well as use fcmSandbox
        "alert": true,
        "badge": true,
        "sound": true
      }
  });

For your issue try to put in your config :
<resource-file src="GoogleService-Info.plist" target="GoogleService-Info.plist"/>

@speedfl I have that correctly set as mentioned in the issue description

Yes but I had this issue as well. I was missing the target part

Then don't put senderID as it is deprecated in 2.0.0

I'm not using it for iOS :)

@1N50MN14 do you see the GoogleService-Info.plist file in your platforms/ios folder? Does it included a FCM Sender ID? What version of cordova-ios are you using?

@macdonst I'm using cordova-ios 4.5.1, yes I do have GoogleService-Info.plist properly located under platforms/ios, I wonder if I should attempt to re-add the platform...

@macdonst Ok re-adding iOS seemed to have solved this issue.. only thing now is that push notifications are not arriving, no errors or logs from xcode, payload is correct...

@macdonst Ok I think I figured it out, it's FCM data messages which are not arriving.. push messages arrive correctly

@1N50MN14 yeah, that's documented here: https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#gcm-and-additional-data

@macdonst Yeah I think my issue is different because I'm sending a data only FCM message without the notification attribute, following https://firebase.google.com/docs/cloud-messaging/concept-options#data_messages, the payload is correct but the plugin is not intercepting it...

@macdonst Yup, I can confirm this is the case, if you send a sample payload:
{
   "to" : "XXX",
   "data" : {
     "foo" : "bar",
     }
 }

It won't arrive the device, however, if you add the notification attribute then it's treated as push message and arrives as expected.

@1N50MN14 when sending to Android use data and to iOS use notification when going over FCM.

@macdonst Sorry for my naive question, I'm using FCM on both Android and iOS. How does the plugin, on either platform, distinguish between a notification message and a data message? In the case of data messages I'm using that to send some information to the app which I do not wish to notify the user of.

(notification & data messages as in FCM terms)


⚠ Bofrost.lu has degraded performance

In 01193a4, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1667 ms

Resolved: Bofrost.lu performance has improved in e4e6e05 after 37 minutes.


Design the Self-Driving Architecture

This is probably going to be a long running discussion over time as we build the self-driving component for Peloton.
The high-level idea we have right now is that we want the computationally expensive part of our self-driving component, we called "the brain", to be a separate process outside Peloton. There would be a thread in Peloton called "the nerve center", that is responsible for talking with the brain. The brain shouldn't directly talk to any internal component of Peloton. In that case, (1) brain won't directly compete resources with normal queries in the database, such as opening up a transaction to access the catalog, (2) it's better modularization and isolation from a software engineering point of view, (3) if the brain dies or crashes, it won't affect the database itself, (4) I probably won't remain in the team at that point, but if we finally go distributed, we can directly port the brain to a stand-alone machine and put a GPU there.
We definitely need a bigger discussion on this in the team meeting.

https://docs.google.com/document/d/1hBkoBrNvM80b53jv3AI2upjWGEMuD2Yej9lul3hPmco/edit?usp=sharing


Please do open source all  source code Files

hey can you describe what should I do?

hey can you describe what should I do?

your some file are not in repo
right?

hey can you describe what should I do?

your some file are not in repo
right?

All files are Open Source Just node_modukes are not.


chore(deps): update tubenhirn/semantic-release-gitlab docker tag to v4.0.9

This PR contains the following updates:

Package
Update
Change

tubenhirn/semantic-release-gitlab
patch
v4.0.8 -> v4.0.9

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 5.2.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix fix total received rows in delta writer incorrect

Proposed changes
As title. total received rows in memtable writer was not passed to delta writer.

run buildall

run buildall


support R language

Closes #59. This is a first draft, let's see if CI passes. This installs R via the debian packaging system, with the default repos. For maximal compatibility, no version number is set.
Installing R into a specific location is only possible when building from source, and that requires additional build dependencies like Fortran Compiler, Make etc. I assumed it's enough to locate the execution binary in /opt/r, so I just moved it there after installation.
The test I adapted from swift and rust.

alright I got this a bit further, but I think this actually needs changes in pre-commit itself to work properly
from what I can tell, there's an RENV_ROOT_PATHS which is where renv "caches" the packages -- however, they actually get run from there (?) -- I suspect what pre-commit should be doing is setting that while building the renv environment and at runtime as some subdir of that such that those packages are carried forward in the renv prefix
I might be wrong though -- hoping you know a little more about this than I do

Cool. I missed your stream yesterday, otherwise we could have collaborated 😄. So there are two things I believe:

a global package cache where packages are installed into. Multiple package versions for multiple R versions.
a library for each environment (like for each conda env). The cool thing here is that package sources are not copied from the cache into the library, but only symlinked from the global cache.

So yes, they get "ran from there" in the sense that the symlink points to the cache and removing the cache after initializing the renv environment breaks the installation, but  renv::restore()` should fix it. Do you do that?

nothing is persisted outside of the environment directory, so the cache needs to be inside that

it seems we could also disable the cache:

While we recommend enabling the cache by default, if you’re having trouble with renv when the cache is enabled, it can be disabled by setting the project setting renv::settings$use.cache(FALSE). Doing this will ensure that packages are then installed into your project library directly, without attempting to link and use packages from the renv cache.

can that be set in an /etc/R.conf or some sort of file?

(my guess is not since it says "project setting")

You can customize the R startup process as described here. We are emulating --vanilla in pre-commit, so setting env variables in any of these startup files won't have any effect.

Did the multistage build not work? I see you used a GitHub release. Should the code be stored somewhere to generate the release?

Did the multistage build not work? I see you used a GitHub release. Should the code be stored somewhere to generate the release?

it did work, but it was very slow -- the code is checked in at ./languages/R/... in #89


Fix typo in the IngressRoute TCP proxying docs

Signed-off-by: Jonas Fonseca<EMAIL_ADDRESS>

Thank you.


docs(setup): omit raw HTML based patron list in long description

This is probably the ugliest silver taping I've done in a while. Suggestions to make this cleaner are very welcome!


Display confetti for custom emoji

You now have write permissions to the repo so you can more easily sort this out!

i think we're good 🤞🏾


Irregular access time to datasets in subgroups (h5py) from colab

Hi, I am a bit disorientated, I am using h5py to read datasets from a hierarchical multi group h5 file
First I implemented a NN using jupyter-notebook on google colab, then I decided to move most of the stuff inside custom libraries and only run a command with arguments from jupyter notebook in colab but the run was much slower!
In both cases, the library reading the datasets on the hdf5 files are custom libraries (.py files called from jupyter)
The only difference is that in one case I loop through each epoch and batch from jupyter, in the new (and much slower implementation) I call custom libraries for looping through epochs and batches, that’s all.
In the last case, the code is much slower. I tracked carefully the origin of the delay and it seems to be when reading and managing datasets in h5py
For instance, the following code
def _get_signal_window(self, with_labels=False):
    if (self.get_number_of_avail_windows() == 0):
        self._reset_random_wind()

    sample = self._get_sample()
    Cnp = sample[0]
    Duration = sample[1]
    Dnp = sample[2]
    window_number = sample[3]
    # >>>>>>>>>>>>> HERE IS THE DIFFERENCE
    dset = self.File['Cnp_' + str(Cnp+1) + '/Duration_' + str(Duration+1) + '/Dnp_' + str(Dnp+1) + '/data']
    assert dset.shape[1] % self.length == 0
    samples_per_second = int(dset.shape[1] / self.length)
    samples_per_window = int(samples_per_second * self.window)
    begin = window_number * samples_per_window
    end = begin + samples_per_window
    time_window = torch.Tensor(dset[0,begin:end]).to(self.device)
    clean_signal = torch.Tensor(dset[1,begin:end]).to(self.device)
    noisy_signal = torch.Tensor(dset[2,begin:end]).to(self.device)

    if with_labels:
        starts, widths, amplitudes, categories, number_of_pulses, average_width, average_amplitude = self._get_labels(time_window, Cnp, Duration, Dnp)
    # >>>>>>>>>>>>> HERE IS THE DIFFERENCE
        return time_window, clean_signal, noisy_signal, starts, widths, amplitudes, categories, number_of_pulses, average_width, average_amplitude
    else:
        return time_window, clean_signal, noisy_signal

runs at least 6 times faster when all the code in in jupyter than when I use custom libraries (remember this code above is in a custom library in both cases)
The code between the tags is the one which makes the difference and is identical in both cases
I can share repo link and jupyter files too
What is happening here?
Thanks!!!

My bad, the error was hidden in another part of the code which had nothing to do with h5py.
Sorry!


Search fails on any string

What did you expect to happen?
Searching highlights the string that I'm searching using 'evil-ex-search-forward'.
What actually happened?
String is not searched. I get Search failed: "string".
Describe your attempts to resolve the issue
Tried rebuilding emacs and doom-emacs. Other methods to search works as expected. evil-ex-search-* commands all fail.
Steps to reproduce
Search using 'evil-ex-search-forward'
System Information
https://pastebin.com/BFDJCCXM

For additional information: evil-search-* commands seem to work as expected

I ran into the same problem. The issue seems to have arisen due to changes to the emacs master branch (i.e. emacs 29 branch).
Okay with 29.0.50 master 935f400a3 (April 21)
Fails with 29.0.50 master abc92b0d5 (April 27)
There are about 100 commits between those versions. I have not tried to bisect further to find the commit that precipitated the problem.

I cannot reproduce this issue on Emacs 27.x or 28, and it appears to be a 29 issue (further evidenced by @jpgrayson's findings). I highly recommend downgrading to 28.1 instead. Doom will not support 29 for now, because it is in a highly unstable stage of its development cycle---new breakages are introduced almost every other week.
Since this is not a Doom issue, and a solution exists, I will close it, but feel free to follow up here.


Error on docker-compose up

The error is:
ERROR: Cannot locate specified Dockerfile: Dockerfile.notebooks
When Dockerfile.notebooks was renamed to Dockerfile, the docker-compose.yml file wasn't updated accordingly.

fixed by #57


TypeError: Cannot read property 'getAllSwatchesFromUrl' of undefined

For some reason, this was closed with advice to "try linking" the library, but I have tried linking the library repeatedly, tried to manually install and several other methods, and still no luck.
I am on React Native .60

When I manually add linkings, I get the error:
node_modules/react-native-palette-full/ios/RNPalette.h:5:9: fatal error: 'React/RCTImageLoader.h' file not found
#import <React/RCTImageLoader.h>

Despite the fact that my podfile has this:
  pod 'React-RCTImage', :path => '../node_modules/react-native/Libraries/Image'

Sorry for the delay, but I have not tried in react native 60, these days I will try and update if necessary

hi @haveamission try upgrade please


Same Origin Policy(Cors) seems that not works L 5.7.13

Laravel Version: 5.7.13
PHP Version: 7.1.9
Database Driver & Version: MySQL 5.7

Description:
When I create a middleware and return from it the $next($request) with specific headers I got error that Same Origin Policy blocked my ajax(axios) request.
In my middleware
return $next($request)
->header('Access-Control-Allow-Origin', '*')
->header('Access-Control-Allow-Methods', 'GET, POST, PUT, PATCH, DELETE, OPTIONS')
->header('Access-Control-Allow-Headers', 'Content-Type, Authorization');
Steps To Reproduce:

Create a middleware and add the following code in handle() function
return $next($request)
->header('Access-Control-Allow-Origin', '*')
->header('Access-Control-Allow-Methods', 'GET, POST, PUT, PATCH, DELETE, OPTIONS')
->header('Access-Control-Allow-Headers', 'Content-Type, Authorization');
Add the created middleware in global array $middleware in kernel.php so that the middleware runs for every request
Comment the middleware \App\Http\Middleware\VerifyCsrfToken::class
Create a POST route and make an ajax request to the route so that you get the error that Same Origin Policy blocks your request.
Important: Using Postman looks that it works but using Chrome as an example throws the error

I post also some images they may help
The Error image in console

The request details

Can you first please try one of the following support channels? If you can actually identify this as a bug, feel free to report back. You may also want to check into https://github.com/barryvdh/laravel-cors

Laracasts Forums
Laravel.io Forums
Discord
Larachat
IRC
StackOverflow


[FEATURE] CRD to add data-streams and indices

Is your feature request related to a problem?
It would be nice to have the possibility to create data-streams/indices by CRD.
What solution would you like?
The CRD can manage which data-streams/indices will be deployed.
What alternatives have you considered?
Run an ansible-job.
Do you have any additional context?
None

You can already do that by using the templates :) https://github.com/opensearch-project/opensearch-k8s-operator/blob/main/charts/opensearch-operator/files/opensearch.opster.io_opensearchindextemplates.yaml

Thanks for the quick response.
I was already aware of the option using the index template.
The problem with the index template is that the index/data stream is only created when an event is received from OpenSearch for the first time.
However, the wish would be to create the indices/data stream in advance.

[Triage]
Hi @moglitsch ,
Thanks for opening the issue. While we get to it, please feel free to contribute the feature if you can.
Thanks!

You can already do that by using the templates :) https://github.com/opensearch-project/opensearch-k8s-operator/blob/main/charts/opensearch-operator/files/opensearch.opster.io_opensearchindextemplates.yaml

Might be worth trying creating your indexes with the "curator" like this :
https://github.com/flant/curator-opensearch/tree/main/examples/actions