HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone

Reorganize MOB compaction tests for more reuse.
Add tests for mob compaction after snapshot clone operations
note the original table used to write a given mob hfile and use that to find it later.

Signed-off-by: Esteban Gutierrez<EMAIL_ADDRESS>
Ported to branch-2 for HBASE-27154
Co-authored-by: Andrew Purtell<EMAIL_ADDRESS>

All MOB unit tests pass for me locally:
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.mob.TestMobStoreCompaction
[INFO] Running org.apache.hadoop.hbase.mob.TestMobFileName
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.443 s - in org.apache.hadoop.hbase.mob.TestMobFileName
[INFO] Running org.apache.hadoop.hbase.mob.TestMobCompactionRegularRegionBatchMode
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.708 s - in org.apache.hadoop.hbase.mob.TestMobStoreCompaction
[INFO] Running org.apache.hadoop.hbase.mob.TestMobCompactionOptMode
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 167.5 s - in org.apache.hadoop.hbase.mob.TestMobCompactionOptMode
[INFO] Running org.apache.hadoop.hbase.mob.TestMobDataBlockEncoding
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.027 s - in org.apache.hadoop.hbase.mob.TestMobDataBlockEncoding
[INFO] Running org.apache.hadoop.hbase.mob.TestMobCompactionWithDefaults
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 269.02 s - in org.apache.hadoop.hbase.mob.TestMobCompactionRegularRegionBatchMode
[INFO] Running org.apache.hadoop.hbase.mob.TestMobCompactionOptRegionBatchMode
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 162.783 s - in org.apache.hadoop.hbase.mob.TestMobCompactionWithDefaults
[INFO] Running org.apache.hadoop.hbase.mob.TestMobFile
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.944 s - in org.apache.hadoop.hbase.mob.TestMobFile
[INFO] Running org.apache.hadoop.hbase.mob.TestMobStoreScanner
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.321 s - in org.apache.hadoop.hbase.mob.TestMobStoreScanner
[INFO] Running org.apache.hadoop.hbase.mob.TestMobFileCleanerChore
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.639 s - in org.apache.hadoop.hbase.mob.TestMobFileCleanerChore
[INFO] Running org.apache.hadoop.hbase.mob.TestMobFileLink
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.564 s - in org.apache.hadoop.hbase.mob.TestMobFileLink
[INFO] Running org.apache.hadoop.hbase.mob.TestMobWithByteBuffAllocator
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.788 s - in org.apache.hadoop.hbase.mob.TestMobWithByteBuffAllocator
[INFO] Running org.apache.hadoop.hbase.mob.TestMobFileCache
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.168 s - in org.apache.hadoop.hbase.mob.TestMobFileCache
[INFO] Running org.apache.hadoop.hbase.mob.TestMobCompactionRegularMode
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 48.695 s - in org.apache.hadoop.hbase.mob.TestMobCompactionRegularMode
[INFO] Running org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 24.397 s - in org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions
[INFO] Running org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClientNormal
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 269.391 s - in org.apache.hadoop.hbase.mob.TestMobCompactionOptRegionBatchMode
[INFO] Running org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientSimple
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 33.287 s - in org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClientNormal
[INFO] Running org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientClone
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.717 s - in org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientClone
[INFO] Running org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClientError
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.984 s - in org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientSimple
[INFO] Running org.apache.hadoop.hbase.client.TestMobSnapshotFromClient
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.227 s - in org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClientError
[INFO] Running org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientGetCompactionState
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.527 s - in org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientGetCompactionState
[INFO] Running org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClientAfterSplittingRegion
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.1 s - in org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClientAfterSplittingRegion
[INFO] Running org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClientCloneLinksAfterDelete
[INFO] Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 70.423 s - in org.apache.hadoop.hbase.client.TestMobSnapshotFromClient
[INFO] Running org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.803 s - in org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClientCloneLinksAfterDelete
[INFO] Running org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterTruncate
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.497 s - in org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange
[INFO] Running org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.713 s - in org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterTruncate
[INFO] Running org.apache.hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 50.296 s - in org.apache.hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient
[INFO] Running org.apache.hadoop.hbase.snapshot.TestMobRestoreSnapshotHelper
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 92.566 s - in org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence
[INFO] Running org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 42.037 s - in org.apache.hadoop.hbase.snapshot.TestMobRestoreSnapshotHelper
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.427 s - in org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
[INFO] Results:
[INFO] Tests run: 92, Failures: 0, Errors: 0, Skipped: 0

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 51s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 24s
branch-2 passed

+1 :green_heart:
compile
2m 40s
branch-2 passed

+1 :green_heart:
checkstyle
0m 40s
branch-2 passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 40s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  5s
the patch passed

-1 :x:
compile
0m 56s
hbase-server in the patch failed.

-0 :warning:
javac
0m 28s
hbase-common generated 2 new + 153 unchanged - 2 fixed = 155 total (was 155)

-0 :warning:
javac
0m 56s
hbase-server in the patch failed.

-0 :warning:
checkstyle
0m 27s
hbase-server: The patch generated 2 new + 34 unchanged - 0 fixed = 36 total (was 34)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
7m 46s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

-1 :x:
spotless
0m 33s
patch has 33 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
1m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

29m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4617

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux f07e066ee4df 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / fbfe7b3880

Default Java
AdoptOpenJDK-1.8.0_282-b08

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
64 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 14s
branch-2 passed

+1 :green_heart:
compile
0m 54s
branch-2 passed

+1 :green_heart:
shadedjars
3m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 11s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
3m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 28s
hbase-common in the patch passed.

-1 :x:
unit
195m 32s
hbase-server in the patch failed.

214m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4617

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c0b2af789d4e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / fbfe7b3880

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/testReport/

Max. process+thread count
2430 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 47s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 35s
branch-2 passed

+1 :green_heart:
compile
1m 19s
branch-2 passed

+1 :green_heart:
shadedjars
4m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 52s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 59s
the patch passed

+1 :green_heart:
compile
1m 13s
the patch passed

+1 :green_heart:
javac
1m 13s
the patch passed

+1 :green_heart:
shadedjars
4m 33s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 29s
hbase-server generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)

_ Other Tests _

+1 :green_heart:
unit
2m  9s
hbase-common in the patch passed.

+1 :green_heart:
unit
228m 18s
hbase-server in the patch passed.

254m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4617

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8bca2e086ac7 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / fbfe7b3880

Default Java
AdoptOpenJDK-11.0.10+9

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/testReport/

Max. process+thread count
2290 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I got the same results:
[INFO] Results: [INFO]  [INFO] Tests run: 92, Failures: 0, Errors: 0, Skipped: 0

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 55s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 23s
branch-2 passed

+1 :green_heart:
compile
2m 42s
branch-2 passed

+1 :green_heart:
checkstyle
0m 40s
branch-2 passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 45s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  5s
the patch passed

-1 :x:
compile
0m 57s
hbase-server in the patch failed.

-0 :warning:
javac
0m 27s
hbase-common generated 2 new + 153 unchanged - 2 fixed = 155 total (was 155)

-0 :warning:
javac
0m 57s
hbase-server in the patch failed.

+1 :green_heart:
checkstyle
0m 38s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
7m 50s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 48s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

29m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4617

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux ddc8db072026 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 47230c4727

Default Java
AdoptOpenJDK-1.8.0_282-b08

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

Max. process+thread count
65 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Valid error prone findings:
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4617/yetus-general-check/src/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java:[442,57] error: [FormatString] extra format arguments: used 0, provided 2
(see https://errorprone.info/bugpattern/FormatString)
[ERROR] /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4617/yetus-general-check/src/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java:[498,51] error: [FormatString] extra format arguments: used 0, provided 2
(see https://errorprone.info/bugpattern/FormatString)
Back soon with a fix.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 56s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 55s
branch-2 passed

+1 :green_heart:
compile
0m 59s
branch-2 passed

+1 :green_heart:
shadedjars
4m 19s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 39s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
4m 17s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 24s
hbase-server generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)

_ Other Tests _

+1 :green_heart:
unit
1m 39s
hbase-common in the patch passed.

+1 :green_heart:
unit
185m  4s
hbase-server in the patch passed.

207m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4617

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e74505c105ce 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 47230c4727

Default Java
AdoptOpenJDK-11.0.10+9

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/testReport/

Max. process+thread count
2495 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 57s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 14s
branch-2 passed

+1 :green_heart:
compile
2m 42s
branch-2 passed

+1 :green_heart:
checkstyle
0m 39s
branch-2 passed

+1 :green_heart:
spotless
0m 40s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 34s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  1s
the patch passed

-1 :x:
compile
2m  9s
hbase-server in the patch failed.

-0 :warning:
javac
0m 28s
hbase-common generated 2 new + 153 unchanged - 2 fixed = 155 total (was 155)

-0 :warning:
javac
2m  9s
hbase-server in the patch failed.

+1 :green_heart:
checkstyle
0m 37s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
7m 38s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 48s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

30m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4617

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux ecd6516e872f 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 70a561eb63

Default Java
AdoptOpenJDK-1.8.0_282-b08

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

Max. process+thread count
65 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Precommit test failures are similar to recent flakes on other issues, and are not related to this change.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
8m 30s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m  5s
branch-2 passed

+1 :green_heart:
compile
0m 55s
branch-2 passed

+1 :green_heart:
shadedjars
3m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  9s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
3m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 25s
hbase-common in the patch passed.

+1 :green_heart:
unit
186m 25s
hbase-server in the patch passed.

213m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4617

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d063f8d31a72 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 70a561eb63

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/testReport/

Max. process+thread count
2391 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 46s
branch-2 passed

+1 :green_heart:
compile
1m  5s
branch-2 passed

+1 :green_heart:
shadedjars
3m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 34s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
shadedjars
3m 56s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 27s
hbase-server generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)

_ Other Tests _

+1 :green_heart:
unit
1m 51s
hbase-common in the patch passed.

+1 :green_heart:
unit
197m 16s
hbase-server in the patch passed.

219m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4617

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 603595529e67 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 70a561eb63

Default Java
AdoptOpenJDK-11.0.10+9

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/testReport/

Max. process+thread count
2426 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 16s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 16s
branch-2 passed

+1 :green_heart:
compile
2m 44s
branch-2 passed

+1 :green_heart:
checkstyle
0m 46s
branch-2 passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 47s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 11s
the patch passed

+1 :green_heart:
compile
2m 44s
the patch passed

-0 :warning:
javac
0m 31s
hbase-common generated 2 new + 153 unchanged - 2 fixed = 155 total (was 155)

+1 :green_heart:
checkstyle
0m 46s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
7m 38s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotless
0m 43s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

31m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4617

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux dbc8e549c887 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 70a561eb63

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt

Max. process+thread count
64 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m  9s
branch-2 passed

+1 :green_heart:
compile
0m 55s
branch-2 passed

+1 :green_heart:
shadedjars
3m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  8s
the patch passed

+1 :green_heart:
compile
0m 56s
the patch passed

+1 :green_heart:
javac
0m 56s
the patch passed

+1 :green_heart:
shadedjars
3m 41s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 28s
hbase-common in the patch passed.

+1 :green_heart:
unit
190m 24s
hbase-server in the patch passed.

209m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4617

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 30b51a7070e1 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 70a561eb63

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/testReport/

Max. process+thread count
2414 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 16s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 34s
branch-2 passed

+1 :green_heart:
compile
1m  5s
branch-2 passed

+1 :green_heart:
shadedjars
3m 53s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 44s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 38s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
shadedjars
3m 57s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 27s
hbase-server generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)

_ Other Tests _

+1 :green_heart:
unit
1m 51s
hbase-common in the patch passed.

+1 :green_heart:
unit
202m 50s
hbase-server in the patch passed.

225m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4617

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1b2bde033584 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 70a561eb63

Default Java
AdoptOpenJDK-11.0.10+9

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/testReport/

Max. process+thread count
2312 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Working on old information, a github page rendering that was not updating properly, I thought the build was still failing in compilation due to error-prone and changed how the IOExceptions are formatted again, this time with string concatenation instead of String#format. I assume this is not a problem @wchevreuil and will go ahead and merge this if I don't hear back in 24 hours or so.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 19s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 14s
branch-2 passed

+1 :green_heart:
compile
2m 45s
branch-2 passed

+1 :green_heart:
checkstyle
0m 46s
branch-2 passed

+1 :green_heart:
spotless
0m 46s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 46s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 10s
the patch passed

+1 :green_heart:
compile
2m 44s
the patch passed

-0 :warning:
javac
0m 31s
hbase-common generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154)

-0 :warning:
javac
2m 13s
hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193)

+1 :green_heart:
checkstyle
0m 46s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
7m 58s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotless
0m 43s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 20s
The patch does not generate ASF License warnings.

32m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4617

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 90025c45c9c7 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 5cf9a9b4b1

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

Max. process+thread count
60 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 56s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  1s
branch-2 passed

+1 :green_heart:
compile
0m 58s
branch-2 passed

+1 :green_heart:
shadedjars
4m 19s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
4m 18s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 24s
hbase-server generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)

_ Other Tests _

+1 :green_heart:
unit
1m 40s
hbase-common in the patch passed.

+1 :green_heart:
unit
191m 40s
hbase-server in the patch passed.

215m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4617

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8999940d244f 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 5cf9a9b4b1

Default Java
AdoptOpenJDK-11.0.10+9

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/testReport/

Max. process+thread count
2494 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 17s
branch-2 passed

+1 :green_heart:
compile
0m 55s
branch-2 passed

+1 :green_heart:
shadedjars
3m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 10s
the patch passed

+1 :green_heart:
compile
0m 56s
the patch passed

+1 :green_heart:
javac
0m 56s
the patch passed

+1 :green_heart:
shadedjars
3m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 31s
hbase-common in the patch passed.

+1 :green_heart:
unit
208m 23s
hbase-server in the patch passed.

228m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4617

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f561acb23217 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 5cf9a9b4b1

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/testReport/

Max. process+thread count
2335 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Seems everything is good, merge it to branch-2 and do a backport to branch-2.5.


bumping up gosnappi version

OTG added support for EgressTracking as part of new release and need to bump the gosnappi version to use that.
This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an as is basis without any warranties of any kind.

We'll test with the latest Gosnappi and update the Ondatra version simultaneously.


Troubles finding a connection to Kuka iiwa 14 controller

Hello, I am having troubles connecting to my kuka controller, my HMI shows the following dialouge:

In addition, I get the warning that I have to use Real Time Kernel - is this the reason? I tried it with RT Kernel but than the FIFO scheduling didn't work out.

Do I have to set the IP of the kuka controller anywhere in the code? Or how does the connection work?

thank you for your quick response, that worked perfectly!

wow I would love that !


[Fix] Broken builds on GNU/Linux without <fpu_control.h>, i.e., glibc

I'd like to contribute to icestorm providing installing guidelines for Alpine Linux. This is the preferred distribution for lightweight docker containers, because the base image requires only a few MB: https://www.brianchristner.io/docker-is-moving-to-alpine-linux/ Therefore, it is a sensible choice to provide a relatively compact precompiled "multiplatform" distribution of icestorm + arachne-pr + yosys + iverilog, as opposed to actually cross-compiling each tool.
I have managed to build all the tools but yosys. Precisely, since Alpinex linux does not use glibc (https://en.wikipedia.org/wiki/Alpine_Linux), the following dependency in libs/minisat/System.h cannot be met:
#if defined(__linux__)
#include <fpu_control.h>
#endif

My actual workaround is to remove that line:
$ git clone https://github.com/cliffordwolf/yosys.git ~/yosys
$ cd ~/yosys && sed -i "/#include <fpu_control.h>/d" libs/minisat/System.h && make -j$(nproc) && make install \

However, I think that it is quite an ugly solution.

I checked ENABLE_* settings in the Makefile, but I couldn't identify any related to this feature.

An alternative solution is to check __GLIBC__ (seen here):
#if defined(__linux__)
#if defined __GLIBC__
#include <fpu_control.h>
#endif
#endif

@cliffordwolf, if you agree, I will make a PR with this.

Furthermore, I don't know at what extent does the removal of fpu_control affect performance. It may be possible to use fenv.h instead, as shown here. However, I don't feel confident enough to dive into it. Any clue on how many files should be modified will help.

Fixed in 71cbe98.

Wow, so fast. Thanks a lot.


Documentation homepage, use of panels for visibility to users

🚀 Pull Request
Description

Added some panels and use of badges on the documentation index, in order to make it more visible to users.

The link to the legacy docs was in a note, now moved to lower on the page and uses a badge link instead.
Added panels using the sphinx-panels extension.
Made the index on the main body hidden, now it only appears in the sidebar.
Added the dependency for sphinx-panels.
Moved the Iris API link in the sidebar to the Reference section

You can view all rendered changes at https://iris-test-doc.readthedocs.io/en/latest/ for the lifetime of this PR.

Consult Iris pull request check list

any thoughts @SciTools/iris-devs?

:+1: really like the improved clarity of this (and incorporating #3880).
Can't find anything to fault with this, but I will leave @bjlittle to complete review

Love it!

Review comments addressed via https://github.com/SciTools/iris/pull/3884/commits/0d47a55fe3dc26f4def67655d5c0476c61dd0e14

anymore comments?  if not could someone please review and approve please.

@tkknight Could you just make sure that you've serviced all the reviewer comments, then I'll bank this 👍

Think mine were the only comments, so now banked.


persistance

we will need at least some persistance as mete mentioned that the h2 db will not be sufficient. To quickly store it this option would be feasible in app.properties:
spring.datasource.url=jdbc:h2:file:~/testdb;DB_CLOSE_ON_EXIT=FALSE;AUTO_RECONNECT=TRUE
=> like that we would have some file storage. but the file gets deleted after a while as well when the server shuts down (google cloud)

our app is not per se slow, but we have issues with google cloud.
spring.datasource.url=jdbc:h2:file:./data/db;DB_CLOSE_ON_EXIT=FALSE;AUTO_RECONNECT=TRUE
=> this works if the db is shut down properly. if it is restarted and at the very same time there are requests from the fe to the backend it fucks up.

i have tried to use a google cloud database and it did not work the way i wanted it to. thus i left this approach behind. but we need to clarify whether we now need a persistent storage or not as in a meeting mete mentioned something of it.

I definitely would not change the DB now this will def make us fail. What we could maybe change is increasing ram if we keep it in memory. In memory is the fastest solution so we might need to explore this. Can you clarify where the slow performance occurs? Is it the app start or during a game(s)?
On 20 May 2023, at 20:09, daniel @.***> wrote:

i have tried to use a google cloud database and it did not work the way i wanted it to. thus i left this approach behind. but we need to clarify whether we now need a persistent storage or not as in a meeting mete mentioned something of it.
—
Reply to this email directly, view it on GitHubhttps://github.com/sopra-fs23-group-13/meme-it-server/issues/175#issuecomment-1555964211, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVWPCRKTRMKQJWC3QUQAR2LXHECGFANCNFSM6AAAAAAYCWDI2U.
You are receiving this because you were assigned.Message ID: @.***>


[Hide My Email] Love this extension! 🎯

Extension
https://www.raycast.com/svenhofman/hidemyemail
Description
Just wanted to say thanks for creating this extension! Being able to manage Apple's Hide My Email service directly from Raycast is amazing. I was previously using this shortcut, but this is so much more efficient. Great work! 👏
Who will benefit from this feature?
No response
Anything else?
No response

Hi @jlpajares
Thank you for your kind words! It's really nice of you to take the time to write this message :)
It's still awaiting approval, but there will soon be an update that makes the extension much faster to use!
Happy holidays 🎆


Bundle Splitting not Working (Debug)

Prerequisites

[x] Can you reproduce the problem in a MWE?
[x] Are you running the latest version?
[x] Did you perform a search in the issues?

Environment Details and Version
Piral v0.9 on WSL with a pilet development for sample-piral.
Description
When doing a bundle splitting via
const Page = React.lazy(() => import('./Page'))

the page "crashes", i.e., the bundle splitting does not work.
Steps to Reproduce

Create the following root module

import * as React from "react";
import { PiletApi } from "sample-piral";
import { Link } from "react-router-dom";

const Page = React.lazy(() => import('./Page'));

export function setup(app: PiletApi) {
  app.registerPage('/my-page', Page);

  app.registerMenu(() => <Link to="/my-page">My Page</Link>);
}

Create the Page.tsx file

import * as React from "react";

export const Page: React.FC = () => (

My Awesome Page!

Lorem ipsum!

);

export default Page;

Start debugging
Go to the page

Expected behavior
The page loads (by initially first loading the side bundle).
Actual behavior
The page crashes ("Error: Cannot find module 'Page.tsx'").
Possible Origin / Solution
Maybe a problem in the injection. The created bundle looks fine.

Landed in develop and is released as preview!


Unable to install latest version of CLI

The documented approach to install the CLI on Linux:
curl -fsSL https://clis.cloud.ibm.com/install/linux | sh

Stopped working with the release of version 2.4.0.  Get the following error:
Unable to parse installer url and checksum url. Quit installation.

The problem seems to with these lines:
platform_binaries=$(echo "$metadata_section" | sed -ne '/'"$platform"'/,/'"checksum"'/p')
...
sh1sum=...

platform_binaries does not include "checksum"

Thank you for reporting. This has now been addressed.


Chatting Web Application

Project title
Chatting Web Application
Project Description
This is a web application like Chatting clone.
Which is also responsive made by (HTML, CSS, Js (vanilla js))
Doc Domain

[] Solidity , Html, Css , JavaScript , Web3.js / Ether.js
[] Solidity , ReactJs /NextJs , Web3.js /Ether.js
[] Solidity , Python3 , Web3.py
[] Other , feel free to mention below

Are you contributing under any open-source program ? Yes

@Vikash-8090-Yadav Please assign this project to me. so that ill start working on it

Great start working on this.


certs: Sync with Mozilla bundle as of Dec 13, 2023

https://github.com/bagder/ca-bundle/commit/bef37a977ccb45fb4c1b213b79dd6ba438077561

Thanks!

Cherry-picked for 4.2.2.

Cherry-picked for 3.6.
Cherry-picked for 3.5.4.

Cherry-picked for 4.1.4.


acme: The client does not correctly support ES512 signatures.

What version of Go are you using (go version)?
go version go1.7 linux/amd64
What did you do?
Use a elliptic.P521() key for the acme client signer
example:
https://gist.github.com/mendsley/840ce420b1769b05b4e2a22b12538e8e
What did you expect to see?
No output - Acme client correctly signed request using EC512 key
What did you see instead?
output "Should support ES512 signatures"

It looks like the error is coming from LetsEncrypt, and not Go's client library. Correct me if I'm wrong. Can other users use P512 with LetsEncrypt?
Note that only Go's P256 implementation is both fast (in assembly on amd64 and s390x currently) and constant-time, and LetsEncrypt is largely written in Go, which might be why they don't accept other curves.

Oh, now I see your CL.


No performance test for Q5

The follow-up of Q5 Find best meeting point in grid-like city cannot be solved in not linear time. A non-linear performance test should be added.

Superseded by #255.


Import error.

Hi, I keep getting import error when the xray step is run.
Code in yaml file :
name: xray-action
if: always()
uses<EMAIL_ADDRESS>with:
    username: ${{ secrets.XRAY_CLIENT_ID }}
    password: ${{ secrets.XRAY_CLIENT_SECRET }}
    testFormat: "junit"
    testPaths: "**/test-result-reports/*-junit.xml"
    projectKey: "QA"

Error -
Run<EMAIL_ADDRESS>  with:
    username: ***
    password: ***
    testFormat: junit
    testPaths: **/test-result-reports/*-junit.xml
    projectKey: QA
    xrayCloud: true
    combineInSingleTestExec: false
    failOnImportError: false
    continueOnImportError: true
    importParallelism: 2
🚀 Connect to xray
  ℹ Configured XrayCloud
  ℹ Start logging in procedure to xray
  ℹ Completed login and retrieved token
📝 Import test reports
  ℹ Importing from: **/test-result-reports/*-junit.xml
  ℹ Importing using format: junit
  Warning: 🔥 Failed to import: /home/runner/work/portal/portal/test-result-reports/jest-junit.xml (Timeout awaiting 'request' for 60000ms)
  ℹ Processed 0 of 1 elements. Failed to import: 1

Can someone help me understand whats wrong?

@nehalagrawal-blu thank you very much for the report.
It's difficult to say, ultimately the API failed to allow importing the file.
Is it by coincidence huge?
API itself seems to be in reach as the authentication looks to have went through

it may be a temporary networking issue or it could happen during an upgrade rollout. does it still happen @nehalagrawal-blu ?

Seems to work now :) I didn't change anything. So could be networking issue :)

Thank you so much. Glad things work now :)


main --> 0.3.0

Also, has everything been tested with respect to regression prevention? I don't think so (failing blocks have been fixed, but we haven't done a full run with the latest develop as far as I recall).

Also, has everything been tested with respect to regression prevention? I don't think so (failing blocks have been fixed, but we haven't done a full run with the latest develop as far as I recall).

Running the 701 blocks (and maybe the 240) is probably a good idea. In theory it's only the debug stuff from Vlad and your stuff ( you and Linda) that hasn't been run but it's worth running anyway.

I'm not approving right away because of the auto-merge squash activated, cf my comment above. Waiting on others opinions.

I've removed the automerge. Merge commits are available to do it "nicely".
And yeah we need a tag.

Sorry, "squash" is just muscle memory now. :slightly_smiling_face:
There should be a tag (v0.3.0) on develop (I might have done this wrong). Also agree that we should run the 701 blocks again before merging.

I guess it's no big deal, but I still find it confusing to have a global monorepo tag, while there's no way to peg zk_evm v0.3.0 to evm_arithmetization v0.1.3 for instance.
On the plonky2 side, I've been using crate-tags (eg starky-v0.2.1). But that's a low-importance topic I guess.

Just an update. John is a bit busy, but it's in his queue to run the 701 tests against this PR. Just waiting for that.

Hey just a heads up. I started running the 701 blocks yesterday evening, and it's still running... I think it might be a good idea to temporarily stop adding new commits to this PR just so I don't have to restart this :sweat_smile:.


PWA-767 Re-enabled User tracking subscription. Added default grey bac…

…kground to Search route

Pull Request Test Coverage Report for Build 1730

0 of 2 (0.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 38.306%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pages/Search/index.jsx
0
1
0.0%

pages/subscribers.js
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

pages/Search/index.jsx
1
0.0%

Totals

Change from base Build 1729:
-0.02%

Covered Lines:
1342

Relevant Lines:
3236

💛  - Coveralls


relationship model  select filed doesn't display table field

i 've test your apps, great
but the relationship model filed  doesn't doesn't display table field, i've see your youtube, better use input for field

Whoops !!
make sure that your chosen table was migrated first.
if it doesn't work for you,pleas contact me soon as you can.

check v1.3.2


fix too small char buf

fix pintia/issues#

[ ] break change (should be carefully deployed)

Proposed Changes

上游合了，已经同步到master


Missing command

Hello! I can't find any command to make current window the main one in my tree of windows (make it the biggest). Am I missing something?

This is not a thing yet, but it probably should be.

implemented on master.
chunkc tiling::window --focus biggest
chunkc tiling::window --swap biggest
chunkc tiling::window --warp biggest

Thank you.


feat: Doc Storage interface definition

The Aries Framework should support pluggable storage(e.g file store, embedded db store, cloud store, etc.) for DID documents along with Connections(pairwise mapping).
This change defines the interface for the doc storage.
Signed-off-by: Rolson Quadras<EMAIL_ADDRESS>

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   92.92%   92.92%
=======================================
  Files           5        5
  Lines         198      198
=======================================
  Hits          184      184
  Misses          7        7
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d623d0e...3e95436. Read the comment docs.


Make docker images publicly available

@JesseMaxwell I don't have access here, could you please turn these images from private -> public?
https://github.com/orgs/swiftotter/packages?repo_name=den


IBM MQ containersource

Containersource that reads events from IBM MQ
Fixes previous PR #451
Requires CGO module to work with IBM bindings, overrides ko's base image, ships mq lib.
Can be deployed with ko (from repository root):
CGO_ENABLED=1 ko apply -f contrib/ibm-mq/

/ok-to-test

overall it looks good to me - just a couple of minor comments

thanks for the review @duglin but there is an issue with this event source - IBM MQ go client requires MQ itself to be installed on the machine where build happens. I don't see how I can make it pass build on CI, even though it's not needed to be ko apply-able.

@adrcunha for thoughts on how to handle this requirement for cgo builds for this message source.
Separately, I'll point out that Google is running separate CI and releases for Google-specific integrations (PubSub, Cloud Storage, etc) at: https://github.com/google/knative-gcp and TriggerMesh is doing the same at https://github.com/triggermesh/knative-lambda-sources, etc, so if the CI here is being difficult, we want to make cross-linking to vendor repos easy and first-class on https://knative.dev/.

You should be able to install IBM MQ in the E2E setup phase. Use the instructions at
https://github.com/ibm-messaging/mq-golang#common
and hook them to a cluster_setup() function in e2e-tests.sh like in
https://github.com/knative/client/blob/dbb63d45429a102ef499586069c8bf21a88f9f7c/test/e2e-tests.sh#L36

You should be able to install IBM MQ in the E2E setup phase. Use the instructions at
https://github.com/ibm-messaging/mq-golang#common
and hook them to a cluster_setup() function in e2e-tests.sh like in
https://github.com/knative/client/blob/dbb63d45429a102ef499586069c8bf21a88f9f7c/test/e2e-tests.sh#L36

looks like e2e-tests.sh being executed only for integration tests (here), so I had to put required env variables in presubmit-tests.sh script:
https://github.com/knative/eventing-contrib/pull/500/files#diff-8f99251cc2fba45d21cb371ad880c91c
MQ dependencies are stored in kodata so they could be used in both, local build and for "ko apply".
@evankanderson @adrcunha could you take a look at this once again please?

Indeed e2e-tests.sh only runs for integration tests. I think something is missing here, because now there are only a few env vars added to presubmit-tests.sh. Are they required because of the new code in contrib?

Indeed e2e-tests.sh only runs for integration tests. I think something is missing here, because now there are only a few env vars added to presubmit-tests.sh. Are they required because of the new code in contrib?

right, these env variables are the only thing required to build MQ source - they are pointing compiler to the kodata directory where MQ libs are stored

@adrcunha could you check this again, see if @tzununbekov works for you ?
@evankanderson any suggestions on how to get this moving ?

@tzununbekov the IBM MQ team has started to review this, but due to time constraints their comments may not land until next week.  Just wanted you to know that it's on their radar ;-)

@duglin thanks for the heads up!

Hi @tzununbekov - thanks for submitting this - on behalf of the IBM MQ development team we're pleased to see you submit a KNative event source for IBM MQ, and we're looking forward to seeing how customers will use it!
We have reviewed within the MQ development team and would like to share the following review comments/requests please.
Thanks again for your contribution!
Comments:

Suitability for production

There are a few changes that can be made to harden the code to make it more suitable for production style usage
In particular we would recommend adding appropriate error handling so that messages can be retried if the delivery to the event client fails
This could/should include consuming the message under a sync point (transaction) so that it can be rolled back and redelivery attempted by the MQ infrastructure
https://github.com/knative/eventing-contrib/pull/500/files#diff-401655c4da416f7172aea1639245b63bR153
Similarly, what is the behaviour if the connection to the queue manager is broken while the loop is running (e.g. queue manager is restarted) - the GET will fail with an error and break out of the for loop - does the main method automatically get re-run from the top by the framework in that scenario in order to establish a new connection to the queue manager?
What sort of retry behaviour is there in the framework that controls the main method - for example if the queue manager was unavailable at the time that main.go is executed?

Licensing of the IBM MQ redistributable client files

There are a number of IBM MQ files (.h and .so) checked in to /contrib/ibm-mq/kodata/inc which are licensed under the IPLA license and not the Apache 2.0 license that covers the repo as a whole
The IPLA section on "Redistributables" also has a series of conditions which are potentially violated by checking in copies of the files, in particular clause 1 (object code only) and probably also 3, 11-ii and 11-iii
To avoid these licensing issues these files should be extracted dynamically from the redist client download as part of the build process, and removed from the checked in source tree please

If possible, please update the redist client import (https://github.com/knative/eventing-contrib/pull/500/files#diff-c449959a02664b1bdb78228113d3bcd2R5) to the LTS <IP_ADDRESS> package

Unless there are specific functions in the 9.1.x CD releases that is required?
(for example ccdt_schema.json is not included in the v<IP_ADDRESS> download - is that file required for the runtime?)
(ccsid.tbl, ccdid_part2.tbl are included in v<IP_ADDRESS>, as are the .so files)
Using the LTS release will ensure a long support window for this library, rather than requiring it to be updated every 12 months in order to stay in support
If you can't switch to the LTS option then please update to the latest MQ CD release v9.1.3 to give the maximum possible window for support (July 2020 for v9.1.3)

Please also update the mq-golang dependency version to 4.1.0 in order to keep up to date with the latest there;

https://github.com/knative/eventing-contrib/pull/500/files#diff-db5d2e36b7f6907ca4bd4d2d2e45a263R30

Please update the phrase "IBM Message Queue" to either "IBM MQ" or "an IBM MQ queue" (the product name MQ is never expanded)

https://github.com/knative/eventing-contrib/pull/500/files#diff-2adb19385e6b3a9e58c8f38e632898e3R3

For the WaitInterval of 3 seconds, since this code is running in an infinite loop is there any reason that this should be made slightly longer, such as 10 or 15 seconds?

https://github.com/knative/eventing-contrib/pull/500/files#diff-401655c4da416f7172aea1639245b63bR128
This would reduce the churn on the Go process

From a Go style perspective, can we suggest not checking in the /vendor directory, and instead allowing it to be generated at build time?

We suggest removing the commented out line that tries to set the ApplName

https://github.com/knative/eventing-contrib/pull/500/files#diff-401655c4da416f7172aea1639245b63bR82
Note that this is one aspect which will likely not be supported by the <IP_ADDRESS> redistributable client, but on balance it is better to have the longer support window

Thanks @matrober-uk for the review of the IBM MQ code; I'm not familiar with
I'm taking a look at this right now, and I have a couple concerns:

Why is this in contrib/ibm-mq? All the other components are in top-level directories.
Why do you have a separate Gopkg.toml and Gopkg.lock? None of the other contrib components have separate dependencies like this.
I'm uncomfortable with checking in the .so library files without (at a minimum) some README indicating:

Where they came from
How to refresh them
Any licensing requirements

@sebgoa -- can you confirm that you will be on the hook for fixes to this component going forward? If not, @tzununbekov or someone else will need to be on the hook for this.

Comments on individual sections of code will follow in a separate review. Some emphasis on @matrober-uk 's comments.

Hi @tzununbekov - thanks for submitting this - on behalf of the IBM MQ development team we're pleased to see you submit a KNative event source for IBM MQ, and we're looking forward to seeing how customers will use it!
We have reviewed within the MQ development team and would like to share the following review comments/requests please.
Thanks again for your contribution!
Comments:

Suitability for production

There are a few changes that can be made to harden the code to make it more suitable for production style usage
In particular we would recommend adding appropriate error handling so that messages can be retried if the delivery to the event client fails
This could/should include consuming the message under a sync point (transaction) so that it can be rolled back and redelivery attempted by the MQ infrastructure
https://github.com/knative/eventing-contrib/pull/500/files#diff-401655c4da416f7172aea1639245b63bR153

+1 to this suggestion; the expectation is that

Similarly, what is the behaviour if the connection to the queue manager is broken while the loop is running (e.g. queue manager is restarted) - the GET will fail with an error and break out of the for loop - does the main method automatically get re-run from the top by the framework in that scenario in order to establish a new connection to the queue manager?

If the container exits, a new container will be started. Restarting the loop seems like it could be an incremental improvement.

What sort of retry behaviour is there in the framework that controls the main method - for example if the queue manager was unavailable at the time that main.go is executed?

The container source Deployment will keep launching new Pods when the previous Pod dies. This will generate some amount of extra churn in the cluster, but is probably not dire.

Licensing of the IBM MQ redistributable client files

There are a number of IBM MQ files (.h and .so) checked in to /contrib/ibm-mq/kodata/inc which are licensed under the IPLA license and not the Apache 2.0 license that covers the repo as a whole

Is the IPLA in question this license: https://www-03.ibm.com/software/sla/sladb.nsf/pdf/ipla/$file/ipla_en.pdf ?
Alternatively, is it the IPL: https://opensource.org/licenses/IPL-1.0 ?
At a minimum, there needs to be a LICENSE or LICENSE.txt file in text format alongside the code. Since this is native code, it's not clear that https://github.com/knative/test-infra/tree/master/tools/dep-collector will find it, so additional work may need to be done to get license generation working correctly.
Once we know which license this is, we may also need Google's legal team to sign off on the IPL usage here. I'm guessing IPL is probably okay, but I am not a lawyer.

The IPLA section on "Redistributables" also has a series of conditions which are potentially violated by checking in copies of the files, in particular clause 1 (object code only) and probably also 3, 11-ii and 11-iii
To avoid these licensing issues these files should be extracted dynamically from the redist client download as part of the build process, and removed from the checked in source tree please
If possible, please update the redist client import (https://github.com/knative/eventing-contrib/pull/500/files#diff-c449959a02664b1bdb78228113d3bcd2R5) to the LTS <IP_ADDRESS> package

How do these licensing terms apply to redistributing a docker container containing the combination of IPLA software and Knative AGPL software? Is this a case where we'd need to ask each customer to build that combination themselves?

Unless there are specific functions in the 9.1.x CD releases that is required?

(for example ccdt_schema.json is not included in the v<IP_ADDRESS> download - is that file required for the runtime?)

(ccsid.tbl, ccdid_part2.tbl are included in v<IP_ADDRESS>, as are the .so files)

Using the LTS release will ensure a long support window for this library, rather than requiring it to be updated every 12 months in order to stay in support

If you can't switch to the LTS option then please update to the latest MQ CD release v9.1.3 to give the maximum possible window for support (July 2020 for v9.1.3)

Please also update the mq-golang dependency version to 4.1.0 in order to keep up to date with the latest there;

https://github.com/knative/eventing-contrib/pull/500/files#diff-db5d2e36b7f6907ca4bd4d2d2e45a263R30

Gopkg.lock seems to indicate version = "v4.1.0"

Please update the phrase "IBM Message Queue" to either "IBM MQ" or "an IBM MQ queue" (the product name MQ is never expanded)

https://github.com/knative/eventing-contrib/pull/500/files#diff-2adb19385e6b3a9e58c8f38e632898e3R3

For the WaitInterval of 3 seconds, since this code is running in an infinite loop is there any reason that this should be made slightly longer, such as 10 or 15 seconds?

https://github.com/knative/eventing-contrib/pull/500/files#diff-401655c4da416f7172aea1639245b63bR128
This would reduce the churn on the Go process

From a Go style perspective, can we suggest not checking in the /vendor directory, and instead allowing it to be generated at build time?

The dep tool automatically vendors the Go code. Additionally, we've found that fetching dependencies dynamically introduces a wide range of failure modes around availability of the original package (including cases like package deletion or repo unavailability).
We've decided to prefer duplicating the bytes in preference to the availability risks of late-binding.

We suggest removing the commented out line that tries to set the ApplName

https://github.com/knative/eventing-contrib/pull/500/files#diff-401655c4da416f7172aea1639245b63bR82
Note that this is one aspect which will likely not be supported by the <IP_ADDRESS> redistributable client, but on balance it is better to have the longer support window

@evankanderson yes we will be on the hook, but if you don't want this in the repo please say so now and we will maintain it outside.
It is not clear to me what is the future of this repo since the google knative source is now outside of it.

The most critical item is clarification of the license status of this code vis-a-vis redistribution. Beyond that, I think we intend to keep maintaining the contributed items here, and adding them where they make sense (mostly consumers for OSS systems like Kafka and NATSS, but also common infrastructure which may not provide its own importer, like Amazon and GitHub).
I'm fine with having the IBM importer here if the packaging/licensing can be aligned with the rest of the items here.

FWIW, it may make more sense to see whether the test-infra tooling can work with a Dockerfile for parts of the repo, though it's unfortunate that we'll lose capabilities like dep-collector to automatically manage the LICENSE files shipped with each Docker container.

@matrober-uk @evankanderson thanks for the review and comments, I'm working on incorporating changes you suggested. In general I see three directions for me here:

message delivery reliability - ensure "at-least-once" delivery approach, improve code testability
remove .h and .so files from the repository - figure out how to dynamically load redist libs during the build (though there is no actually scripted build step). Make sure to use latest LTS versions of MQ dependencies
licensing - I'm not sure where we are in this question. Does it make sense now to work on these changes, if at the end it turns out that the code cannot be merged due to a license conflict?

I'll gradually update the code with these changes while the licensing question is something that I'd like to clarify as soon as possible. Thanks again!

Thank you all for the reviews, it seems that the licensing, build and distribution are significant issues. We are going to close this PR and make the code available in a separate repo where we can make the appropriate changes quickly without too much disturbance to this repo.
@matrober-uk we will ping you on the new location asap


[backport] CI: Manage test tags in yaml

Backport of #6429 by @kmaehashi

/test mini

Confirmd test tags interpreted as intended.
https://github.com/cupy/cupy/runs/5104026501?check_suite_focus=true#step:5:1


Unable to start service apache2: Job for apache2.service failed because the control process exited with error code.

Written Yaml code as given the below

hosts: all
become: yes
tasks:

name: installing apach2 and update packages
apt:
name: apache2
update_cache: yes
name: apache2 restarted
service:
name: apache2
enabled: yes
state: restarted
name: Php installing and adding additions packages to it
apt:
name: "{{ item }}"
state: present
with_items:

php
libapache2-mod-php
php-mcrypt
php-mysql

name: apache2 restarting again
service:
name: apache2
enabled: yes
state: restarted

After executing the ansible-playbook
getting error as givne in the below screen shot

Not yet installed apache2(state: present) not given ,but trying to restart.

state: present is default.
No need for present.
My doubt is regarding configuration.
Can you share results of ansible -m ping all

From: devopsawsazure<EMAIL_ADDRESS>Sent: 27 July 2018 12:46
To: QT-DevOps/DevOpsIssues
Cc: Subscribed
Subject: Re: [QT-DevOps/DevOpsIssues] Unable to start service apache2: Job for apache2.service failed because the control process exited with error code. (#68)
[image]https://user-images.githubusercontent.com/39402697/43307037-ba0ef116-919a-11e8-89ce-940a85777274.png
Not yet installed apache2(state: present) not given ,but trying to restart.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/QT-DevOps/DevOpsIssues/issues/68#issuecomment-408333799, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACU0rVSZkxsM37-oR5H0uXagwOhFQngRks5uKr5mgaJpZM4Vfew-.

And now the above error not came when i used handlers in the playbook yml file

Ok Great. But that has no dependency on handlers


chore: rename iteratedDeriv_const_{smul,mul}

Do you plan to add the "right" iteratedDeriv_const_smul statement in a later PR?

Yes, after the next lean bump in early January (if this one gets in before then).

And vice versa add the within version of iteratedDeriv_comp_const_smul?

If I can find the proof :)

If not, could you add some TODOs?

Sure


Clear not working properly (maybe its just display)

Steps to reproduce:

Create custom prefix (prefix=N, fullName=Namu)
Attach this custom prefix to an exercise
Delete this custom prefix
Execute clear
The screen below should appear

Was unable to reproduce this error. Anyone able to reproduce it?
@kwekke @garylyp @jietung @weihaw08

I was unable to reproduce this error too.

nope

Addressed this issue in PR fix-bug-add-docs. Apparently, clear command returns a CommandResult with ListResourceType.SUGGEST as list type. My bad.


Run tests using GitHub Actions

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b1c7340). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   73.78%
=========================================
  Files             ?        1
  Lines             ?      103
  Branches          ?        0
=========================================
  Hits              ?       76
  Misses            ?       27
  Partials          ?        0

Flag
Coverage Δ

#unittests
73.78% <0.00%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1c7340...d64362a. Read the comment docs.


Fix infinite loop in ReconfigurableEventLoggingProvider

Fix an infinite loop in the EventLoggingProvider after reconfiguration.
Testing done

Submitter checklist

[ ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[ ] Ensure that the pull request title represents the desired changelog entry
[ ] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@kuisathaverat we have a regression that I couldn't detect before I used the last release on an instance with authentication enabled. Can you please look at this PR?


Added SHSelections

Project URL
https://github.com/iamshezad/SHSelections
Category
Table View
Description
A sample project demonstrates the usage of SHSelection Class to implement checkbox and radio buttons easily.
Why it should be included to awesome-ios (mandatory)
Checklist

[x] Only one project/change is in this pull request
[ ] Has unit tests, integration tests or UI tests
[x] Addition in chronological order (bottom of category)
[ ] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 4 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          3 Warnings

:warning:
Please rebase to get rid of the merge commits in this Pull Request

:warning:
Too many changes (when adding, please keep it to one project per Pull Request)

:warning:
Found 23 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

206
403
https://www.udemy.com/arkit-beginner-to-professional/?couponCode=CREATORS

407
301
https://github.com/cagricolak/CoreCharts redirects tohttps://github.com/CoreCharts/CoreCharts

547
301
https://developer.couchbase.com/mobile/ redirects tohttps://www.couchbase.com/products/mobile/

930
301
https://github.com/schibsted/layout redirects tohttps://github.com/nicklockwood/layout

1003
301
https://github.com/caffe2/caffe2 redirects tohttps://github.com/facebookarchive/caffe2

1174
301
https://github.com/bakkenbaeck/Viewer redirects tohttps://github.com/3lvis/Viewer

1567
301
https://github.com/quickbirdstudios/RxCoordinator redirects tohttps://github.com/quickbirdstudios/XCoordinator

1682
301
https://github.com/VirgilSecurity/sdk-x redirects tohttps://github.com/VirgilSecurity/virgil-sdk-x

1705
301
https://github.com/VirgilSecurity/crypto-x redirects tohttps://github.com/VirgilSecurity/virgil-crypto-x

2327
Dupe
https://github.com/filletofish/CardsLayout

2449
301
https://github.com/hyperoslo/Dropdowns redirects tohttps://github.com/onmyway133/Dropdowns

2583
301
https://github.com/vsmithers1087/VSVerticalSlider redirects tohttps://github.com/vsmithers1087/VerticalSlider

2704
Dupe
https://github.com/HamzaGhazouani/HGPlaceholders

2705
Dupe
https://github.com/jeantimex/CollapsibleTableSectionViewController

2706
Dupe
https://github.com/younatics/ExpandableCell

2707
Dupe
https://github.com/muukii/DataSources

2708
Dupe
https://github.com/mmick66/KDDragAndDropCollectionView

2709
Dupe
https://github.com/malkouz/ListPlaceholder

2710
301
https://github.com/bakkenbaeck/SectionScrubber redirects tohttps://github.com/3lvis/SectionScrubber

2710
Dupe
https://github.com/bakkenbaeck/SectionScrubber

2712
Dupe
https://github.com/SoySauceLab/CollectionKit

3111
301
https://developer.apple.com/app-store/review/rejections/ redirects tohttps://developer.apple.com/app-store/review/#common-app-rejections

3166
301
https://github.com/hyperoslo/SwiftSnippets redirects tohttps://github.com/onmyway133/SwiftSnippets

  Generated by :no_entry_sign: Danger

@arasu01 Can you please help me with this issue?

@iamshezad  We cannot merge your PR yet until you write some tests for your lib. Feel free to open PR once it is ready.
Please check our CONTRIBUTION GUIDELINES


Update the Faye typing to include other common client methods

Ran into the issue in a couple of projects where there are missing methods on the current Faye module.  Just extending the existing type to include those.
I Ran the build locally and attempted to test against a fresh dev org, but had 11 failed tests.
Test Suites: 3 failed, 16 passed, 19 total
Tests:       11 failed, 6 skipped, 186 passed, 203 total
Snapshots:   0 total
Time:        387.473 s

Did I miss a setup step maybe?

Oh also I had an update to the package-lock.json file that I didn't include in the commit.  I assume it was caused by me having a different version of npm. Mostly removing dev properties and integrity value changes.  Let me know if that should be committed.


setApplicationIconBadgeNumber should not be called on background thread

Describe the bug
Platform: iOS
When calling setBadgeNumber on iOS, this plugin calls setApplicationIconBadgeNumber on a background thread giving the following output in the log:
Main Thread Checker: UI API called on a background thread: -[UIApplication setApplicationIconBadgeNumber:]
PID: 743, TID: 499358, Thread name: (none), Queue name: com.apple.root.default-qos, QoS: 21
Backtrace:
4   Taskrunner Debug                    0x0000000100ab8074 __33-[FirebasePlugin setBadgeNumber:]_block_invoke + 104
5   libdispatch.dylib                   0x00000001016b91dc _dispatch_call_block_and_release + 24
6   libdispatch.dylib                   0x00000001016b919c _dispatch_client_callout + 16
7   libdispatch.dylib                   0x00000001016c5200 _dispatch_queue_override_invoke + 968
8   libdispatch.dylib                   0x00000001016ca7c8 _dispatch_root_queue_drain + 604
9   libdispatch.dylib                   0x00000001016ca500 _dispatch_worker_thread3 + 136
10  libsystem_pthread.dylib             0x0000000183e7bfac _pthread_wqthread + 1176
11  libsystem_pthread.dylib             0x0000000183e7bb08 start_wqthread + 4
...
To Reproduce
Steps to reproduce the behavior:

Call setBadgeNumber in iOS

Plugin Version
2.0.2
Smartphone (please complete the following information):

Device: iPhone6
OS: iOS 11.4.1

I just set Badge number and get the same issue.

Unfortunately, this project seem kind of dead. I'm hoping for Ionic to come up with a replacement

Agreed!


winget install results in 0x80d03002 : unknown error

Brief description of your issue
winget install results in 0x80d03002 : unknown error
Steps to reproduce
In Powershell issue the following command:

winget install 'Visual Studio Code'

Expected behavior
Installation of visual studio code should begin.
Actual behavior
Found Visual Studio Code [Microsoft.VisualStudioCode]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://az764295.vo.msecnd.net/stable/054a9295330880ed74ceaedda236253b4f39a335/VSCodeUserSetup-x64-1.56.2.exe
An unexpected error occurred while executing the command:
0x80d03002 : unknown error
Environment
Windows Package Manager v1.0.11451
Windows: Windows.Desktop v10.0.19043.985
Package: Microsoft.DesktopAppInstaller v1.11.11451.0
Any other software?

@vaughan-naidoo we've seen this error on a few different machines. We believe it is related to Delivery Optimization and possibly enterprise managed settings. You can try to change your winget settings to specify "wininet" for the download mechanism.
Example from settings.json:
{
    "$schema": "https://aka.ms/winget-settings.schema.json",

    // For documentation on these settings, see: https://aka.ms/winget-settings
    // "source": {
    //    "autoUpdateIntervalInMinutes": 5
    // },

    "network": {"downloader": "wininet"}
    }
}

Thank you @denelon that fixed it.

Thank you @denelon this fixed the issue for me too.
for others with the same issue, I didn't have a settings.jason. I had to type winget.exe settings and this created the file in the following path $env:LOCALAPPDATA\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState
then I updated based on denelon's post above and I am loving winget.exe now.


Update component documentation to match package name conventions

What does this PR do?
Update documentation on how to create components such that it matches the conventions used for package names in new style components.
Motivation
Keeping docs consistent with linter rules from https://github.com/DataDog/datadog-agent/pull/27868
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
N/A

/merge


GPII-1499:  Move "passthrough" router in from other package...

See GPII-1499 for details.

Just to summarize, it looks to me as though all feedback has been addressed.


[Bug] Tag x.x.x does not exist

Based on the documentation, --git will automatically create the tag and push it
--git
Enable the git command to automatically submit after the version is updated, create a tag and push it to the remote repository (git add -> git commit -> git tag -> git push)

But...
❯ pnpm release

><EMAIL_ADDRESS>release /Users/user/App
> tr release --git

[💢 updater] UPDATE_LOG.md Tag v0.0.1 does not exist.

I understand, I need to manually update UPDATE_LOG.md first.


Fixes excludedUrls handling

Currently, for pages that match excludedUrls, Vimari still adds the stopSitePropagation() handler, which causes all keystrokes to stop working on that page. Fixes it to stop adding stopSitePropagation() handler for pages that match excludedUrls.

@isundaylee thank you for this, hopefully it will get merged and released by @danielcompton ASAP. Without this, Vimari is essentially broken when people try to use the excludedUrls feature.

@nbelzer what are your thoughts? Happy for you to merge if you're happy with the change.

@danielcompton I'll merge it now, we'll have to see what I can get done today towards some of the other issues, perhaps we can release this in a patch update (together with some other fixes) soon.

Hi all, Vimari user here
I was just about to raise an issue for this, but I see that it has been fixed and merged. I discovered the issue because I've added YouTube to the excluded URLs list and Vimari was preventing rewind/fast-forward with j and l.
I've pulled down the master branch, and the change looks to have fixed the issue I was experiencing 🎉

@graham-mc You are right, this change has yet to ship in the next patch release. Will hopefully have some time soon to fix a few other issues that have been encountered since the minor release and upload a new version to the app store.

@nbelzer Is it possible to release without waiting on any additional fixes? This issue was fixed two months ago – it would be really nice to have this fix available without having to build the app.

Thanks again for this, @nbelzer and @isundaylee!

Any chance someone could post a snapshot binary build that includes this fix?  Vimari is amazing, but I really need the excludedURLs functionality to work


Add a test

Copied over the example code from the JavaScript template and slightly modified it to be compatible with TypeScript.
The tests run successfully, but Standard fails with the following error:
λ ~/Projects/template-typescript/ add-test* npm run test

><EMAIL_ADDRESS>test /Users/timon/Projects/template-typescript
> jest && standard **/*.ts

 PASS  test/index.test.ts
  ✓ that we can run tests (4ms)
  My Probot app
    ✓ creates a comment when an issue is opened (5ms)

18:51:51.851Z  INFO probot: Yay, the app was loaded!
Test Suites: 1 passed, 1 total
Tests:       2 passed, 2 total
Snapshots:   0 total
Time:        1.678s, estimated 2s
Ran all test suites.
=============

WARNING: You are currently running a version of TypeScript which is not officially supported by typescript-eslint-parser.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: ~3.0.1

YOUR TYPESCRIPT VERSION: 3.1.1

Please only submit bug reports when using the officially supported version.

=============
standard: Use JavaScript Standard Style (https://standardjs.com)
  /Users/timon/Projects/template-typescript/src/index.ts:1:10: 'Application' is defined but never used.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>test: `jest && standard **/*.ts`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/timon/.npm/_logs/2018-10-02T18_51_52_827Z-debug.log
λ ~/Projects/template-typescript/ add-test*

This is just a heads up, I might solve this in a seperate PR :)
Fixes: #3

@hiimbex Thanks, good to know that it's being reworked! I'll check it out :)

The test in particular is here: https://github.com/probot/create-probot-app/pull/36/files#diff-5e27b297aa22294ff0126763d5fbce56! I used nock instead, but I think it gets at the same point!


fix: Use ORIGIN in RPATH inside of Makefiles

Use single quotes and $$ to properly guard ORIGIN when LDFLAGS are injected into Makefiles. e.g. '$$ORIGIN/_fastjet_core/lib' Without this guard, when Make evaluates the variable $ORIGIN will get evaluated as RIGIN.
Related to https://github.com/scikit-hep/fastjet/pull/277

(fixing a local build issue, so went to draft mode)

@lgray This fixes multiple issues and is ready now to be merged.


Fix infer_queue errors on sidekiq_options nil

The infer_queue method fails when :sidekiq_options is nil
Re: #279

Coverage increased (+0.09%) to 98.058% when pulling c0f88c93b2b2b949b8341745dd9e8c2b1f031df2 on fieldse:patch-1 into 25d3406044196dfb58d74caac920c9a2991eb486 on moove-it:master.


update prow dependency

needed for https://github.com/openshift/ci-tools/pull/4339

/cc @bradmwilliams


Projection Overhaul for V4

V4 Event Projection Model
This pull request completely replaces the supported projections in Marten. Temporarily, this pull request completely removes all support for the "async daemon", and a replacement should be the next work as a follow on.
The projection types are:

Implement your own IInlineProjection class to do whatever you wanna do. This is simplified from the old IProjection model in V3
"Self-Aggregates": Superset of the V3 ability to stick Apply() methods directly on the aggregate type. There are some other improvements like being able to use constructor functions or a static Create(event, IQuerySession) : Self method.
EventProjection -- base class.  Supports both a limited selection of inline lambda signatures, or a Project(EventType @event, IDocumentOperations ops) / Transform(EventType) : DocumentType conventional method set
AggregateProjection<T> -- new base class for aggregating by stream. Inline lambdas + conventional method discovery for Apply(), Create(), and ShouldDelete()
ViewProjection<T, TId> replacement. Inherits from AggregateProjection<T>. This differs a bit from the existing V3 ViewProjection, so we'll need some docs on migrating to V4. I think it has a much easier to use API.

@jeremydmiller I was going through the PR changes earlier today, it was a bit overwhelming for me to run through it in the GH web view so was using Rider to run through it. Given that you have merged it now, I can run few tests etc and can learn the changes better.

@jeremydmiller I was going through the PR changes earlier today, it was a bit overwhelming for me to run through it in the GH web view so was using Rider to run through it. Given that you have merged it now, I can run few tests etc and can learn the changes better.


Add AFM cache volume support

Add support for AFM cache volume

AFM modes supported: IW, RO, SW, LU

Driver image: quay.io/amdabhad/csi-driver:afmCaching3041

quay.io/amdabhad/csi-driver:afmCaching3053  (with review comments + some improvements)
quay.io/amdabhad/csi-driver:afmCaching3065 (With fix for secret mask - scale-core#7094)
quay.io/amdabhad/csi-driver:afmCaching3080 (With more review comments + 70% soft quota support by Badri)

Operator image: quay.io/amdabhad/csi-operator:afmCaching3002

Signed-off-by: amdabhad<EMAIL_ADDRESS>Co-authored-by: jacohn16<EMAIL_ADDRESS>Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature Enhancement
[ ] Test Automation
[ ] Code Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Community Operator listing
[ ] Other (please describe):

How risky is this change?

[ ] Small, isolated change
[ ] Medium, requires regression testing
[x] Large, requires functional and regression testing

@deeghuge, @Jainbrt there should be a better review process in CSI, dev should not spend time on fixing review comments every day.

@Jainbrt, you are added as a reviewer 2 weeks back, why are you adding comments now after dev approval? Please open defect if you disagree?

@Jainbrt, you are added as a reviewer 2 weeks back, why are you adding comments immediately after dev approval? Please open defect if you disagree.

@amdabhad these are valid comment. lets address those as an issue.

@Jainbrt, unless it's a blocker issue, we will not change anything in this PR now. Please record your findings in the issues, we will address which are valid ones, thanks!

@deeghuge  @hemalathagajendran   - Test team covered testing of this PR and is completed with no blockers at this moment.Good to go for merge. Thanks!


fix the dependency

Remove ReqMgr2 dependency from WMStats server

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/196/ for details

No pylint warnings for pull request 6101:

Unit test changes for pull request 6101:

Api_t.Tester:test_multi_throw5a was added. Status is error
Api_t.Tester:test_accept_reject_octets was added. Status is error
Daemon_t.TaskTest:test_gc was added. Status is success
Api_t.Tester:test_multi_throw0 was added. Status is error
Api_t.Tester:test_accept_reject_gif was added. Status is error
Api_t.Tester:test_accept_good_gif was added. Status is error
Api_t.Tester:test_multi_throw5b was added. Status is error
Simple_t.SimpleTest:test_basic_fail was added. Status is error
Daemon_t.TaskTest:test was added. Status is error
Api_t.Tester:test_accept_good_json was added. Status is error
Api_t.Tester:test_accept_good_gif2 was added. Status is error
Api_t.Tester:test_accept_reject_xfoo was added. Status is error
Api_t.Tester:test_simple_json was added. Status is error
Simple_t.SimpleTest:test_basic_success was added. Status is error
Api_t.Tester:test_simple_json_deflate was added. Status is error
Simple_t.SimpleTest:test_auth_fail was added. Status is error
Simple_t.SimpleTest:test_gc was added. Status is success
Api_t.Tester:test_accept_good_xml was added. Status is error
WMCore_t.Agent_t.HarnessCouchBackend_t.HarnessCouchBackend_t:testAddWorker changed from failure to success
Simple_t.SimpleTest:test_auth_success was added. Status is error
Api_t.Tester:test_multi_throw10 was added. Status is error
Api_t.Tester:test_gc was added. Status is success
Api_t.Tester:test_multi_nothrow was added. Status is error
Api_t.Tester:test_accept_reject_gif2 was added. Status is error
Api_t.Tester:test_accept_reject_png was added. Status is error