Citrix Workspace App doesn't work anymore

If I execute the following command, the result is an empty folder.
PS C:\Windows\system32> EvergreenAdmx.ps1 -WorkingDirectory "C:\Users\axadmin\Downloads\ADMX" -Languages @("en-US") -UseProductFolders:$true -Include @("Citrix Workspace App")
Cannot convert value "Files.0" to type "System.Version". Error: "Input string was not in a correct format."
At C:\Program Files\WindowsPowerShell\Scripts\EvergreenAdmx.ps1:1120 char:9
+     if (-not $Version -or [version]$evergreen.Version -gt [version]$V ...
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [], RuntimeException
    + FullyQualifiedErrorId : InvalidCastParseTargetInvocation

Looks like Citrix changed the filenaming convention.. again..
It used to be something like CitrixWorkspace_ADMX_Files_2202, for which I took 2202 as the version for this file.
It now is CitrixWorkspace_ADMX_Files, so no longer a version indicator.
For now, I am sorry, no fix for this on my end.

This is still broken even with the latest release. Here's the fix. I can submit a pull request if you prefer.
`function Get-CitrixWorkspaceAppAdmxOnline {
<#
.SYNOPSIS
Returns latest Version and Uri for Citrix Workspace App ADMX files
#>
try {
    $ProgressPreference = 'SilentlyContinue'
    $url = "https://www.citrix.com/downloads/workspace-app/windows/workspace-app-for-windows-latest.html"
    # grab content
    $web = (Invoke-WebRequest -UseDefaultCredentials -Uri $url -UseBasicParsing -DisableKeepAlive -ErrorAction Ignore).RawContent
    # find line with ADMX download
    $str = ($web -split "`r`n" | Select-String -Pattern "_ADMX_")[0].ToString().Trim()
    # extract url from ADMX download string
    $URI = "https:$(((Select-String '(\/\/)([^\s,]+)(?=")' -Input $str).Matches.Value))"
    # grab version
    $VersionRegEx = "Version\: ((?:\d+\.)+(?:\d+)) \((.+)\)"
    $Version = ($web | Select-String -Pattern $VersionRegEx).Matches.Groups[1].Value
    $ShortVersion = ($web| Select-String -Pattern $VersionRegEx).Matches.Groups[2].Value
    # return evergreen object
    # return evergreen object
    return @{ Version = $Version; URI = $URI }
}
catch {
    Throw $_
}

}
function Get-CitrixWorkspaceAppAdmx {
<#
.SYNOPSIS
Process Citrix Workspace App Admx files
.PARAMETER Version
Current Version present

.PARAMETER PolicyStore
Destination for the Admx files

#>
param(
    [string]$Version,
    [string]$PolicyStore = $null,
    [string[]]$Languages = $null
)

$evergreen = Get-CitrixWorkspaceAppAdmxOnline
$productname = "Citrix Workspace App"
$productfolder = ""; if ($UseProductFolders) { $productfolder = "\$($productname)" }

# see if this is a newer version
if (-not $Version -or [version]$evergreen.Version -gt [version]$Version) {
    Write-Verbose "Found new version $($evergreen.Version) for '$($productname)'"

    # download and process
    $outfile = "$($WorkingDirectory)\downloads\$($evergreen.URI.Split("?")[0].Split("/")[-1])"
    try {
        # download
        $ProgressPreference = 'SilentlyContinue'
        Write-Verbose "Downloading '$($evergreen.URI)' to '$($outfile)'"
        Invoke-WebRequest -UseDefaultCredentials -Uri $evergreen.URI -UseBasicParsing -OutFile $outfile

        # extract
        Write-Verbose "Extracting '$($outfile)' to '$($env:TEMP)\citrixworkspaceapp'"
        Expand-Archive -Path $outfile -DestinationPath "$($env:TEMP)\citrixworkspaceapp" -Force

        # copy
        $sourceadmx = "$($env:TEMP)\citrixworkspaceapp\$($evergreen.URI.Split("/")[-2].Split("?")[0].SubString(0,$evergreen.URI.Split("/")[-2].Split("?")[0].IndexOf(".")))"
        $targetadmx = "$($WorkingDirectory)\admx$($productfolder)"
        Copy-Admx -SourceFolder $sourceadmx -TargetFolder $targetadmx -PolicyStore $PolicyStore -ProductName $productname -Languages $Languages

        # cleanup
        Remove-Item -Path "$($env:TEMP)\citrixworkspaceapp" -Recurse -Force

        return $evergreen
    }
    catch {
        Throw $_
    }
} else {
    # version already processed
    return $null
}

}
`

Thanks!
Just tested this and committed the code in the dev branch.

Nice! looking forward for the change to the prod branch!
On Tue, Jul 5, 2022, 8:58 AM Arjan Mensch @.***> wrote:

Thanks!
Just tested this and committed the code in the dev branch.
—
Reply to this email directly, view it on GitHub
https://github.com/msfreaks/EvergreenAdmx/issues/15#issuecomment-1175030348,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADSO5QMD3C35AFYXOLOWJXTVSQWPBANCNFSM5WO6H7KQ
.
You are receiving this because you commented.Message ID:
@.***>

Not to sound pushy or anything but since this is broken in the prod release, can you please update the production branch?

Done :)


CSS background-attachment:fixed not working

This issue is raised before in 2014. https://github.com/adchsm/Slidebars/issues/11
The suggested fix is applying -webkit-backface-visibility: visible;
But this doesn't work out for iOS. Would love to hear if there is another fix/workaround? Because in the current state of Slidebars it's simply not possible to combine it with containers that are fixed with an image.

Hey there,
Thanks for letting me know this is still an issue. I'll look into it.
Thanks,
Adam

I've just testing this on iOS and didn't have an issue, I've simply applied the background image to a class and added the class to the canvas container: https://jsfiddle.net/qqadxy0e/1/
How were you experiencing the issue?

Hello @adchsm sorry to bring this topic up but if you have a  within canvas="container" with a fixed background property, the background seems to be only fixed in Explorer but the not Chrome/Firefox.
Any idea why?


Process exists with code 1 if RDP session closes

Windows Terminal version
1.21.2911.0
Windows build number
Win32NT             10.0.26100.0 Microsoft Windows NT 10.0.26100.0
Other Software
I was RDP'd into my work  PC from home and switched focus to an existing Windows Terminal session running on the remote PC.  The session had open tabs, all running powershell and I used a couple of them to issue commands, leaving them all at the prompt.
I put the home machine to sleep without explicitly closing the RDP session.
When I logged into the work PC at work, I discovered that all windows terminal tabs including one I had not used were showing the error
[process exited with code 1 (0x00000001)]
You can now close this terminal with Ctrl+D, or press Enter to restart.

The screenshot below shows 2 distinct terminal sessions on the same machine.  Every tab within these sessions shows the "process exited" method.

The terminal tab will restart the powershell session if RETURN is pressed....

Steps to reproduce
Still investigating.... possibly abnormal disconnect from RDP
Expected Behavior
Terminals should not exit processes simply because a remote session is lost.
Actual Behavior
Processes were exited

Possibly related
#17999
#16608

Thanks for filing! Could you capture an ETL trace while disconnecting (refer to this guide) /? That should help us debug this further.


Add environment credentials for Nexus, Sonar and Jenkins keys in Ansible playbook

Users have to manually add Nexus, Sonar and Jenkins keys to the Jenkins credential store after the environment is provisioned. Would be nice if the Ansible playbook could do it beforehand so we'd have the lab ready after running vagrant for the first time.

Hi, is there any instruction regarding Jenkins credential for nexus, sonar and jenkins. i.e) credential type, id, etc.

Hi @dwon6! I'm sorry, there's not. This is an old example that I'm afraid has some outdated parts. I don't have the time to get back to it right now. Sorry for that.


Unix-style interoperability with umoci?

Is there some feature(s) or redesign to make these tools interoperable using Unix pipes?
For example, to push:
umoci export myimage:mytag | oras push

and to pull:
oras pull myimage:mytag | umoci import

See also https://github.com/opencontainers/umoci/issues/355

See also https://github.com/opencontainers/umoci/issues/355


jm/hk done some basic search format from json to table including cour…

This pull request closes #56. This branch adds the instructor's column to the search results.

It appears that the main thing holding this back from being mergable is front end testing.  If you'd like some help with that, let me know.


[tool_crash] _CastError: (#0      describeLocale (package:flutter_tools/src/localizations/localizations_utils.dart:219:49))

Command
flutter pub get

Steps to Reproduce

...
...
...

Logs
_CastError: (#0      describeLocale (package:flutter_tools/src/localizations/localizations_utils.dart:219:49))
#0      describeLocale (package:flutter_tools/src/localizations/localizations_utils.dart:219:49)
#1      LocalizationsGenerator._generateBaseClassFile (package:flutter_tools/src/localizations/gen_l10n.dart:1137:34)
#2      LocalizationsGenerator._generateCode (package:flutter_tools/src/localizations/gen_l10n.dart:1238:46)
#3      LocalizationsGenerator.writeOutputFiles (package:flutter_tools/src/localizations/gen_l10n.dart:1313:47)
#4      generateLocalizations (package:flutter_tools/src/localizations/gen_l10n.dart:69:9)
#5      GenerateLocalizationsTarget.build (package:flutter_tools/src/build_system/targets/localizations.dart:56:5)
#6      _BuildInstance._invokeInternal (package:flutter_tools/src/build_system/build_system.dart:839:27)
<asynchronous suspension>
#7      FlutterBuildSystem.build (package:flutter_tools/src/build_system/build_system.dart:606:16)
<asynchronous suspension>
#8      generateLocalizationsSyntheticPackage (package:flutter_tools/src/dart/generate_synthetic_packages.dart:58:30)
<asynchronous suspension>
#9      PackagesGetCommand._runPubGet (package:flutter_tools/src/commands/packages.dart:133:7)
<asynchronous suspension>
#10     PackagesGetCommand.runCommand (package:flutter_tools/src/commands/packages.dart:176:5)
<asynchronous suspension>
#11     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1183:27)
<asynchronous suspension>
#12     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#13     CommandRunner.runCommand (package:args/command_runner.dart:209:13)
<asynchronous suspension>
#14     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:281:9)
<asynchronous suspension>
#15     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)

[✓] Flutter (Channel unknown, 3.0.1, on Microsoft Windows [Version 10.0.22621.608], locale en-US)
    • Flutter version 3.0.1 at C:\src\flutter
    • Upstream repository unknown
    • Framework revision fb57da5f94 (5 months ago), 2022-05-19 15:50:29 -0700
    • Engine revision caaafc5604
    • Dart version 2.17.1
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at C:\Users\ticel\AppData\Local\Android\sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2022 17.2.3)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.2.32526.322
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[✓] VS Code (version 1.72.0)
    • VS Code at C:\Users\ticel\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.50.0

[✓] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22621.608]
    • Chrome (web)      • chrome  • web-javascript • unknown
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 106.0.1370.34

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: unknown
Creation framework version: fb57da5f945d02ef4f98dfd9409a72b7cce74268

@Romanbot4
Thanks for the report! This is a known issue #87851 that has been fixed by PR https://github.com/flutter/flutter/pull/102431 and it's available on stable 3.3.0 onwards.
You will need to upgrade to the latest stable to see the fix. Closing from here as this is already fixed.


[SPARK-32092][ML][PySpark][FOLLOWUP] Fixed CrossValidatorModel.copy() to copy models instead of list

What changes were proposed in this pull request?

Fixed CrossValidatorModel.copy() so that it correctly calls .copy() on the models instead of lists of models.
Why are the changes needed?

copy() was first changed in #29445 . The issue was found in CI of #29524 and fixed. This PR introduces the exact same change so that CrossValidatorModel.copy() and its related tests are aligned in branch master and branch branch-3.0.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Updated test_copy to make sure copy() is called on models instead of lists of models.

Can one of the admins verify this patch?

ok to test

Can one of the admins verify this patch?

Test build #127940 has started for PR 29553 at commit 844fe5c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32566/
Test PASSed.

Test build #127940 has finished for PR 29553 at commit 844fe5c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127940/
Test PASSed.

Merged to master. Thanks!


[e2e]: go push main config-noldflags slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/11789993733
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Trigger: push
Branch: main
Date: Tue Nov 12 03:11:44 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/11809896188
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Trigger: push
Branch: main
Date: Wed Nov 13 03:14:19 UTC 2024
Tests are passing now. Closing this issue.


Add functionality for file system scanning

Hi Nanitor!
Thank you for this contribution!
It would be a great addition to the scanner if the default behavior would be to scan the entire file system on a targeted server. This could of course be an addition parameter as well
This would be beneficial to most users as it eliminates the need to know where .jar and .war are located.

Hi, thank you for this! 🐢
A scanning command has been added to master 🐢🐢🐢


Connection Pool implementation.

We need to implement a connection pooling for db connections etc. Also we need to implement db connect and disconnect features.

issue implemented with feature/2


Adds ability to removeListener when in the same emit loop

Overview
This PR fixes a bug introduces a new feature when trying to remove an event listener immediately when the removeListener  call present in one of the listeners of the stack currently being called.
Bug Example
var e = new EventEmitter();

function first(){
    console.log("first");
    e.removeListener('update', second);
}
function second(){
    console.log("second");
}
function third(){
   console.log("third");
}
e.on('update', first);
e.on('update', second);
e.on('update', third);
e.emit('update');

// should log:
//   first
//   third

Coverage decreased (-0.2%) to 99.796% when pulling 4bc34802d5b29e6d0ab1f0ab49a6ce1030a2b290 on jiborobot:master into ef31a0bd94cc0066b892c409c1f7c15c71cc8b8e on primus:master.

The Node.js EventEmitter has the same behavior. It calls second. I'm not sure if it is a bug.

The use-case for this was creating an update loop that things could subscribe to. If anything is done synchronously in the callbacks to destroy other listeners to the same event loop, it complained.
@lpinca If not a bug fix, would you consider this a feature update? There are already some divergent things from Node's EventEmitter.

Here are a couple of relevant discussions:
https://github.com/nodejs/node-v0.x-archive/issues/7872
https://github.com/nodejs/node/issues/1182
This change might have sense as it is probably the expected behavior. It is a breaking change but the next version will be a major anyway as there are other breaking changes in master.
I would like to hear @3rd-Eden opinion here.

That change makes sense for NodeJS. One of the Node Foundation comments said "Your best bet might be to use an alternative EE implementation". So that's why I'm here. Would love to see this happen.

On vacation atm, will look at it once im back

On Aug 11, 2016, at 6:44 PM, Matt Karl<EMAIL_ADDRESS>wrote:
That change makes sense for NodeJS. One of the Node Foundation comments said "Your best bet might be to use an alternative EE implementation". So that's why I'm here. Would love to see this happen.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@bigtimebuddy can you add docs for this change?

Sure, you bet.

I'm a -1 on this and the reason for that is plain simple. Adding this will break compatibility with Node.js as we are no longer handling events in the same way they are using. I can see the use-case here though but I don't know if this edge case is enough to break compatibility for.

@3rd-Eden Thanks for chiming in. The README lists a bunch of subtle differences between Node and EE3 where changed implementation or API differs slightly.  This doesn't seem like the first breaking-change.
Like you said, this is an edge-case so it will probably not affect many people. It doesn't seem unreasonable to assume that if one removes a listener from within another callback, that should happen immediately not asynchronously.
Any compromises here? Maybe until the next major release, throwing a console.warn or info to let developers know when this happens in their code? Would make it easier for developers to upgrade their code, if this breaking change does, in fact, present issues.

Coverage decreased (-0.2%) to 99.796% when pulling eff8e915ec2db001bfcebe9fab9d06b4ac5a24e6 on jiborobot:master into ef31a0bd94cc0066b892c409c1f7c15c71cc8b8e on primus:master.

I don't know if it makes sense to put this behavior under an option disabled by default.
A fork might also have sense and shouldn't be that hard to maintain (assuming that upstream updates are still wanted).

I have created a fork for this. Thanks for the consideration.


An issue regarding - Include link to note that was active at the moment timer started in the log

Just want to report that there is a corner case where it doesn't work as expected. Here is how I reproduce the issue.

Configure the plugin as shown below

Restart Obsidian
Go to a random note (I name it note 1)
Start the timer and wait for the cycle to complete (I name it cycle 1)
Go to a different note (I name it note 2)
Start the timer and wait for the cycle to complete (I name it cycle 2)
Go to the log file and find the entry for cycle 2. It shows the active note as note 1 instead of note 2

Another observation is that when the cycle 1 is complete, the count-down on the status bar stops as expected but the count-down number is one second past what's it's supposed to be. Maybe it's related to the issue I'm reporting.

Thanks for the bug report! Unfortunately this is linked to something where the best way to fix it would be to do a fairly significant refactor of the code (overdue anyway), which I don't currently have much time for. So I'm not sure when this will get fixed - is it significantly interfering with your workflow? I can try to patch it while I work on the underlying code issues, if so.

I'm on winter break now and finally have time to get to some of the bugs here; should be fixed now, but let me know if there are any further problems.


Navbar

#88

I am unable to remove the double sections .please see to it ..they were not present on the local file.

@frypan01 Please extend this white translucent background to the corner of Drifty icon.

And keep the light and dark mode button as present now -

Please ignore this pull

except logo, is the result fine?

except logo, is the result fine?

@frypan01 I need to see this on my laptop. Shall check and inform you when i am free.

please review! I think all work done?

@frypan01 Please extend this white translucent background to the corner of Drifty icon.
And keep the light and dark mode button as present now -

@frypan01 keep the light and dark mode button as present now -

@frypan01 Please revert these changes -
Before -

After -

@frypan01 Also, the performance has degraded a lot in mobiles and about 1% for desktops -
Before -

After -

Check here:
Before - https://pagespeed.web.dev/report?url=https%3A%2F%2Fsaptarshisarkar12.github.io%2FDrifty%2F&form_factor=mobile
After - https://pagespeed.web.dev/report?url=https%3A%2F%2Fdeploy-preview-106--drifty.netlify.app%2F&form_factor=desktop

Please see!

@frypan01 please fix the below problems.
The menu icon is not available for mobiles, hence can't navigate nor can change the light/dark mode.

The contributor section not loading initially whoch was previously solved.

The demo button comes over another section.

@frypan01 the website seems okay in your phone, but not on my one. What might be the problem? And a solution for this?

https://github.com/SaptarshiSarkar12/Drifty/pull/106#issuecomment-1279205352
The above image is not visible.

I am checking the problem.....but can't we go with more general screen sizes used.....I think it will work fine?

Also @frypan01 , the buttons in all releases section in download needs to be of the same style as the other buttons in that section.

I am sorry this is my first open source project.....I have annoyed you way too much

I am sorry this is my first open source project.....I have annoyed you way too much

@frypan01 It's okay, even I am new to open-source  (just started contributing from 29th May this year). I don't mind that. 😄

well Bangla janen?(informal) please don't mind....I may delete this msg?

well Bangla janen?(informal) please don't mind....I may delete this msg?

Yes

Hey ! this is M. Banerjee!!

Hey ! this is M. Banerjee!!

Ok, I'm Saptarshi Sarkar.

Please review once again?

Please review once again? I think all is set

@frypan01 the menu icon not visible.

Please review once again? I think all is set

@frypan01 the menu icon is not visible.

Sorry, Closed the Pull Request by mistake. @frypan01

I am unable to do it....if you can specify the screen size?

I am unable to do it....if you can specify the screen size? now check....because now its working in all mobile size in google tools... maybe this is happening because icons are too big for such small screen or unable to load

@frypan01 It's still not working on my device.
Please check how the current website automatically sets the screen size width and all the icons are in their proper location.

Please check again if it persists....

Please check again if it persists....

@frypan01 Yes it persists. You can rebase your branch and then , make only the required changes (although it's scary).

If you don't mind......we can create a new issue and ask for help

I messed up!

I messed up!

You can create a new branch and open a PR from that after making the required changes. @frypan01


Auth

Felt like we could start working on user auth and #39 in parallel since they don't depend on each other a lot (the only potential difference is that there will be a bottom app bar when the user is logged in; along with some metadata). I think it's a good idea to separate this work into a new module since we'll likely need to reuse this code.

[ ] Create a new auth module.
[ ] Implement user authentication.
[ ] Display the user's Media List in the Profile path.
[ ] Allow users to log out.

I'm interested in working on this. Is this up for grabs?

Sure is!


Fix some documentation example formatting

Problem:  Help documentation examples are badly formatted.
Solution: Add the appropriate markup.
@chrisbra, maybe you can add this to some batch update if you don't want to add it now. Thanks.

included here: #12790
Thanks!


minesweep-rs: 6.0.50 -> 6.0.52

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/cpcloud/minesweep-rs/releases.
meta.description for minesweep-rs is: Sweep some mines for fun, and probably not for profit
meta.homepage for minesweep-rs is: https://github.com/cpcloud/minesweep-rs
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 6.0.52 with grep in /nix/store/m66f0dhrlmdq9bkwjh4n25412ranycx6-minesweep-rs-6.0.52
found 6.0.52 in filename of file in /nix/store/m66f0dhrlmdq9bkwjh4n25412ranycx6-minesweep-rs-6.0.52

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
minesweep-rs

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/m66f0dhrlmdq9bkwjh4n25412ranycx6-minesweep-rs-6.0.52 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A minesweep-rs https://github.com/r-ryantm/nixpkgs/archive/603b74b87ad51fd4bad42a19a924d19bdb7d6aa6.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/603b74b87ad51fd4bad42a19a924d19bdb7d6aa6#minesweep-rs

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/m66f0dhrlmdq9bkwjh4n25412ranycx6-minesweep-rs-6.0.52
ls -la /nix/store/m66f0dhrlmdq9bkwjh4n25412ranycx6-minesweep-rs-6.0.52/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

minesweep-rs

Maintainer pings
cc @Aleksanaa for testing.

Can we change the auto update policy? This behavior of updating dependencies every day is so annoying.

You may opt-out of the auto update by adding # nixpkgs-update: no auto update

You may opt-out of the auto update by adding # nixpkgs-update: no auto update

Is there anything like "if major version changes"?

You may opt-out of the auto update by adding # nixpkgs-update: no auto update

Is there anything like "if major version changes"?

I'm not aware of any.


[SvgIcon] Fixed Width Icons

Some icon libraries like FontAwesome offer "Fixed Width Icons", an option to scale all icons so that they occupy the full width of their bounding box. This is especially useful for menus, where it creates a sense of vertical alignment.
I've looked for such an option in <Icon> and <SvgIcon> but couldn't find it...

[x] This is a v1.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
import ContentAdd from '@material-ui/icons/Add';

const MyButton = () => (
    <Button>
        <ContentAdd fixedWidth />
        Add
    </Button>
);

@fzaninotto I believe that "Fixed Width Icons" is our default behavior. https://github.com/mui-org/material-ui/blob/4bf97b52113f104174f0cd850bfc2a8fc73c2d99/packages/material-ui/src/Icon/Icon.js#L12

@fzaninotto What's the context of this discussion?

Sorry, I should have given more context.
My use case is a <CardActions> with several <Button> components inside. Because some icons (e.g. the Add icon) don't take the full available width, it looks like the spacing between the icons and the text is irregular, while it's always the same.

Oh, so you are looking for the opposite? I don't think that we can do anything about it for the SVG, maybe for the font icons.

That's what I feared...
The font icons have the inconvenient of being heavier (because I have to load the whole font), so if it's not possible with the SvgIcons, I'll forget about it.

The icons are generated from https://github.com/mui-org/material-ui/tree/master/packages/material-ui-icons here. Basically, we have to scrap https://material.io/tools/icons/?search=add&icon=add&style=baseline. So the source is already too large.


Fixed bug in chatbox.

Please test carefully because I am not sure that this is the solution.

ok. works!


checkout button validate not working with some recent change

###Description
Validation function not working with checkout js
Validate and onclick call back are not getting executed in the most recent version of  checkout.js
Steps to reproduce

go to developer portal
https://developer.paypal.com/demo/checkout/#/pattern/validation

go to customization >validation

click on checkout button

Expected- should not open incontext window
Observed- incontext window opening without going for the validation
##observation
validate function in the checkoutjs is not getting called even once. This issue is observed only from today 16 Feb  12AM PST
Affected browsers
all
checkout error.zip

This appears to be occurring in our production environment as well.

Hi,
Am also facing the same issue . It is working for checkout js versions 4.0.167 and below.

Confirmed, seen in production and sandbox.

@Arvind6353 from your comment it sounds like you've been able to use a URL to an older working version of checkout.js. Could you share here as that might be a viable workaround for some.
I don't think PayPal are aware of this issue yet, the status page, at time of writing, isn't showing this issue: https://www.paypal-status.com/product/production

I've found the same as @Arvind6353 above, 4.0.167 seems to be the last version of checkout.js where validate API hasn't been changed/broken.
The following versioned URL seems to work in my sandbox environment as expected:
https://www.paypalobjects.com/api/checkout.4.0.167.js
All later versions (4.0.168-4.0.175) appear to have broken or changed the way validate works.

Diff between 4.0.167 and 4.0.168, maybe someone can spot the issue: https://github.com/paypal/paypal-checkout/compare/v4.0.167...v4.0.168

@eliotsykes : My guess is around the file hacks.js. Am trying to build the project in local but facing some issue .

All changes from yesterday have been rolled back. Please clear your browser cache and let me know if you still see the issue.

Yes.. Working fine after the rollback
On Feb 16, 2018 11:30 PM, "Daniel Brain"<EMAIL_ADDRESS>wrote:

All changes from yesterday have been rolled back. Please clear your
browser cache and let me know if you still see the issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/paypal/paypal-checkout/issues/606#issuecomment-366311321,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJZ4JDiotLCruwEPRBEvE2LqhgeO_eaRks5tVcI3gaJpZM4SIDsJ
.


DE46356 - Update dateTime.js in Brightspace UI with updated Canadian/Ontarian French date formats

Removing "le" from long date format of fr-ca and fr-fr ("le" remains in fr-on).
Making other elements consistent with formats in LOCALE_CULTURE.

Required changes to two files, so I'm closing this PR in favour of the following:

#98


WolfControl

Another one from MFM:
Please add a way to limit Wolfs per person.
WolfControl:
  #
  # Checks tamed wolfs in defined chunk range and if its above allowed limit then makes them sit down
  # This is limit per player so value of 2-3 is more than enough
  Enabled: true
  # Defines max allowed wolfs per player which can follow him
  # This will be checked on general entity amount check defined belove
  Max: 5

I've decided not to add this to the plugin - I want to keep features focused towards farms, rather than pets or anything else. It's a good idea though and it probably wouldn't be too tricky for someone to whip up a "pet limiter" plugin that's more targeted towards that sort of thing


Shuffle split layer tasks renamed

shuffle-split (or split-shuffle) tasks are special tasks which benefit greatly from data locality and compute extremely fast. It is usually extremely harmful to compute these tasks on different workers than their dependencies. Since the dask.distributed scheduler may make wrong decisions we hard code the task (prefix) name such that the scheduler can make the proper decision more reliably.
In particular we have two places in the dask.distributed code base where this is hard coded
Default task duration
https://github.com/dask/distributed/blob/94254184bb4d81eca914baf374ce0763488d327e/distributed/distributed.yaml#L29-L31
Blacklist for work stealing
https://github.com/dask/distributed/blob/94254184bb4d81eca914baf374ce0763488d327e/distributed/stealing.py#L456
The recent efforts of converting most dask.dataframe graphs to HLGs has caused a regression since the shuffles layers use slightly different naming conventions
https://github.com/dask/dask/blob/364d799e177ad93020d60b4504fb5ab34ab1588f/dask/layers.py#L740-L741
For reference, reversing self.name and the split prefix yields smth like shuffle-0-cbf47d0a7fe114a2badb9f3e7ad7d820-split and would break our key split / prefix mechansim entirely so a more sophisticated str manipulation is required to revert to the old behaviour.
There is currently one PR open to address the work stealing problem and add a test to protect from regression https://github.com/dask/distributed/pull/4964
A similar PR is necessary for the default task durations. Alternatively the dask behaviour can be adapted. Either way, the test for the regression should be carried over.

[ ] Fix work stealing
[ ] Fix default task duration

FYI @rjzamora @madsbk

Closed via https://github.com/dask/distributed/pull/4964 and https://github.com/dask/distributed/pull/4991


[DO NOT MERGE] Split cookies preferences into Analytics and Marketing

Do not merge
We need to agree with the product team on how to release this and further changes that may be needed in Google Tag Manager before releasing this.
Trello card URL

https://trello.com/c/HwgS3j2n

Changes in this PR:
This PR splits the current cookies consent into two separate consents:

For analytics cookies.
For marketing cookies.
Both consents will be set together when answering through the banner with the accept/reject button.

We are redesigning the cookies preferences page and the cookies banner as part of the split.
Any user will have to consent again to cookies. If they had previously consented to the current cookies, analytics cookie preference will be set to "consent" by default.
Screenshots of UI changes:
Banner content/buttons redesign:

Cookies preferences page redesign:

Nice work Marc! This part in CookiesPreferencesController (which is not a change you made in this PR!) took me a while to understand:
  def cookies_preference_set?
    true
  end

I think it is to ensure we don't show a cookies banner to the user while they're viewing their cookies preferences? If so I think we could maybe change the method name to def viewing_cookie_preferences? and add a method like this to the application controller which we would use instead of cookies_preferences_set? to determine whether or not to show the cookies banner:
  def show_cookies_banner
    cookies_preference_set? || viewing_cookies_preferences?
  end


[FIX] Photo deletion issues

Using viewset provides the DELETE action. However, it causes bugs when deleting photos that has faces in them as api/models/face.py on delete sets Photo field to a Person ref.
Changed Face api to cascade the DELETE operation when it's related photo is deleted, consistent with delete missing photos functionality.
Added deletion of photo from local FS when deleting the photo.

The change itself make sense, but I think you could accidentally programmatically delete an image, because the delete function is triggered every time a photo is removed.
For example, we currently have the option to remove missing images from the database.
https://github.com/LibrePhotos/librephotos/blob/ebed2057377e75373fef3851276f0eaf426e6ef2/api/autoalbum.py#L161
When scanning all photos, a photo gets marked as missing when the file is not available. The problem is, that the user could move the pictures back. Now we have a photo that is marked as missing, but the file is available. If we now remove all missing images from the database, this would trigger delete and delete the image on the filesystem.
Deleting images should only happen if the user manually consents to that action.
We can have a delete function, but it should not have anything to do with the django delete function. Call it something like "manually_delete" to make sure it never gets automatically deleted.

True, however I believe if a user wants to move back a particular photo that's missing, their workflow should be copy image to folder -> scan photo. Which should remove the missing mark. However, I do see your point as users may not always have the most logical workflow. I will make the necessary adjustments.

Thanks, now it looks good to me, and thank you for cleaning up the classes :+1:
Yeah, a user even modified/deleted thumbnails once :sweat_smile: Nothing a user can touch should be assumed to be working :laughing:


Switching RGB to BGR during preprocessing?

Hi! My preprocessing of a custom model involved switching image channels from RGB to BGR.
However, it seems when trying to convert to a .ml model, I don't have any parameters that allows switching of channels?
''''tf_converter.convert(tf_model_path = model_path,
mlmodel_path = 'test2.mlmodel',
image_input_names = ['input_1:0'],
output_feature_names = ['output_node0:0'],
input_name_shape_dict = {'input_1:0' : [1, 299, 299, 3]},
image_scale= 2/255.0,
red_bias = -1,
green_bias = -1,
blue_bias = -1)'''
Sorry if I missed something  obvious.
Thank you very much

There is a flag called "is_bgr" that maybe what you need
(https://github.com/tf-coreml/tf-coreml/blob/c9d2052409b1af0232a610fc39ef4ec7ccc45d30/tfcoreml/_tf_coreml_converter.py#L420)


extend_from_slice instead of append

Tiny optimization ...
before
test examples::nnet::nnet_and_gate_train           ... bench: 114,799,087 ns/iter (+/- 2,985,145)

after
test examples::nnet::nnet_and_gate_train           ... bench: 112,627,669 ns/iter (+/- 523,945)

Thanks again.


[CSE-246] Un-/Subscription to last page of epochs

WIP - pls don't merge!
Task: https://issues.serokell.io/issue/CSE-246

Nice work, @sectore :sunglasses:
Will take a detailed look tomorrow, but looks very nice.

I thought about it. We don't need to remember the EpochIndex for the client since the changes on an Epoch are always occurring for the last one - https://github.com/input-output-hk/cardano-sl/pull/1890/files#diff-47bd247d999ad481c628a180a89567aaR47
We simply check if the last Epoch has some new Slot and if it has, we notify.
That should simplify the model a bit.

@ksaric The client does not have any information about the last epoch. Imagine the current last Epoch is 10. When an user is entering a slot page (/epoch/3) the client does not know if epoch 3 is the latest epoch or not. So the client subscribes to SocketBlocksPageUpdated once an user does enter a /epoch/x page. In this case the server has to decide if the client will be notified by SocketBlocksPageUpdated or not. That's why we do need an EpochIndex to know, what the "current" epoch of /epoch/x page at client-side is to compare it with latest epoch on backend-side.

@sectore That can be solved without tracking what Epoch the client want's to listen - it does not require state on the server side. You could simply check if the Epoch the client want's to listen is the latest and if yes, add the subscription. If not, don't add the subscription.
I mean, adding EpochIndex to ClientContext may not seem like a little bit data, but if we have a lot of users it won't be a little bit data. And it would be simpler without tracking the state.
Right?

@ksaric In this case the client have no information that its subscription has not been accepted. Currently  the client stores all its subscriptions at an own state (https://github.com/input-output-hk/cardano-sl/blob/master/explorer/frontend/src/Explorer/Types/State.purs#L59), so that they can be unsubscribed if needed. For example if an user leaves epoch/x page the client will unsubscribe SocketBlocksPageUpdated. This will fire an unsubscription into an empty space, because there was no subscription before. But the backend will try to handle it.
The other thing is, when a client is subscribing to latest epoch (e.g. epoch 10), then it will be notified every time if we have new blocks in epoch 10. But if we don't store EpochIndex all notifications will be sent again and again, even if the latest epoch is 11 and not 10 anymore. That means the client will receive new blocks from epoch 11, but it was interested on epoch 10 only. How would you solve this without storing  an EpochIndex?

This will fire an unsubscription into an empty space, because there was no subscription before.

Well, it's not like this isn't happening right now. I'm not saying it's often, but it does occur.

The other thing is, when a client is subscribing to latest epoch (e.g. epoch 10), then it will be notified every time if we have new blocks in epoch 10. But if we don't store EpochIndex all notifications will be sent again and again, even if the latest epoch is 11 and not 10 anymore. That means the client will receive new blocks from epoch 11, but it was interested on epoch 10 only. How would you solve this without storing an EpochIndex?

The client has subscribed to epoch 10. The epoch switches to 11.

The transitions from one epoch to another are quite a rare event in production and wouldn't be a problem if the client got the subscription from epoch 11 and simply ignore it.
If 1. is problematic, we could simply notice that the epoch that we received is not the one we are after (we want epoch 10, we receive epoch 11) and send an unsubscribe (as in - "oh, I'm not interested in the epoch 11 subscriptions, I just wanted epoch 10 subscriptions".

Seems like I'm making a fuss over some simple state, but the issues we had with socket.io before was exactly because of some simple state and the explosion of possible transitions between them.
If it's not a performance problem, and I don't think it is, let's keep it simple (KISS principle).

Well, it's not like this isn't happening right now. I'm not saying it's often, but it does occur.

If you've seen something like this, please open an YT issue for it.


developerguide.adoc update fix for wrongly placed section

Fix wrongly placed document section

Coverage remained the same at 65.551% when pulling 1bac85664da7d520e8a541ca4173506300d4f3db on zhicaizack:documentfix into 4abcf5d30de161229579ff5626215e12dcdb0775 on CS2113-AY1819S1-T16-1:master.


Pass client to LanguageServer methods by Arc

This PR changes the method signatures for LanguageServer so that client is passed in as Arc<Client> rather than &Client.
I'm not sure if you should merge this but it was easy enough to make the change so I figured I'd put this together rather than creating a separate issue about it first.
The reason I've made this change is because in a language server I am working on which uses this crate, I've found the need to be able to send notifications back to client from a separate thread of control (e.g., a diagnostics collector that runs in the background).
Basically what happens is when I get a textDocument/didOpen or textDocument/didChange, I do some work, then eventually fire a message off to a tokio::sync::watch channel to notify other components of the server that something has changed.
Some of those components might need to send a notification back through client, such as a diagnostic or popup message.
With the current design of tower-lsp, there doesn't seem to be an easy way to do this. I can't send Client along the tokio::sync::watch channel because I only have &Client and Client doesn't implement Clone.
It does seem possible to work around this limitation without using Arc, e.g., by implementing an additional layer of bidirectional messaging between components. But using Arc seems simpler and allows for a cleaner separation of functionality.
What do you think about this change?

Thanks for opening this PR, @darinmorrison! I think this a good idea in principle, but I would rather not break API compatibility like this. I would personally prefer to keep it as &Client but change Client to implement Clone by redefining it to something like this instead:
#[derive(Clone, Debug)]
pub struct Client(Arc<ClientInner>);

What do you think about this? Would this approach also work for you?

Yes, I think that approach should also work. I agree it would be nice not to break the API.

@ebkalderon I re-implemented the PR using a wrapper type like you suggested. Let me know what you think.


[C++] Segfault and terrible error handling when OAuth 2.0 authentication failed

Describe the bug
When configuring C++ client with wrong client secret to make OAuth 2.0 authentication fail, instead of returning any error code, segmentation fault will happen.
To Reproduce
#include <iostream>

#include <pulsar/Client.h>

#include <lib/LogUtils.h>

DECLARE_LOG_OBJECT()

using namespace pulsar;

int main() {
    ParamMap params;
    params["issuer_url"] = "https://dev-kt-aa9ne.us.auth0.com";
    params["client_id"] = "my-client";
    params["client_secret"] = "my-secret";
    params["audience"] = "https://dev-kt-aa9ne.us.auth0.com/api/v2/";

    ClientConfiguration conf;
    conf.setAuth(AuthOauth2::create(params));

    Client client("pulsar://localhost:6650", conf);

    Producer producer;
    Result result = client.createProducer("persistent://public/default/my-topic", producer);
    if (result != ResultOk) {
        LOG_ERROR("Error creating producer: " << result);
        return -1;
    }

    client.close();
}

The output:
2021-10-11 17:47:48.862 ERROR [0x700009313000] AuthOauth2:313 | Response failed for issuerurl https://dev-kt-aa9ne.us.auth0.com. response Code 401 passedin: {
    "grant_type": "client_credentials",
    "client_id": "my-client",
    "client_secret": "my-secret",
    "audience": "https:\/\/dev-kt-aa9ne.us.auth0.com\/api\/v2\/"
}

libc++abi.dylib: terminating with uncaught exception of type std::runtime_error: ExpiresIn in Oauth2TokenResult invalid value: -1
zsh: abort      ./examples/SampleProducer

When I modified issuer_url to an unknown OAuth2 server URL like https://google.com, the output became:
2021-10-11 18:01:28.517 ERROR [0x112d5be00] AuthOauth2:217 | Response failed for getting the well-known configuration https://google.com. response Code 404
...
libc++abi.dylib: terminating with uncaught exception of type std::runtime_error: ExpiresIn in Oauth2TokenResult invalid value: -1

or an invalid URL like my-issuer-url, the output became:
2021-10-11 18:02:59.456 ERROR [0x102eb2e00] AuthOauth2:222 | Response failed for getting the well-known configuration my-issuer-url. Error Code 6
...
libc++abi.dylib: terminating with uncaught exception of type std::runtime_error: ExpiresIn in Oauth2TokenResult invalid value: -1
zsh: abort      ./examples/SampleProducer

Expected behavior
If the authentication failed, the method of Client, like createProducer, should return a ResultConnectError instead of segmentation fault.
Desktop (please complete the following information):

OS: macOS Big Sur 11.2
Apple clang version 12.0.0 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin20.3.0

Additional context
Add any other context about the problem here.

A related issue is when it failed to get token endpoint, the printed log only contains the integer error code, but not the error string.
For example, when the issuer URL is my-issuer-url, the log is:
Response failed for getting the well-known configuration my-issuer-url. Error Code 6

We should print Couldn't resolve host instead of Error Code 6.


Alert popup every time

Hello,
I have added below code, But still alert popup in every time app launch.
I am unable to use this condition: afterAppLaunches: 50
#Need Help
func giveRatingToApp() {
        let ratingsRequest = SwiftyRate.Request(
            afterAppLaunches: 50,
            customAlertTitle: "Rate My App",
            customAlertMessage: "RATE_ALERT_MSG".localized,
            customAlertActionCancel: "Remind me later"

        )
        SwiftyRate.requestReview(ratingsRequest, from: self)
    }

Hey,
Thank you for your comment. I presume you are running an iOS version higher than iOS 10.3? In that case it will show the default apple ratings prompt instead of the custom one. Its the one you can select the stars from 1-5. This alert is managed by apple and will show every time you are in debug mode. Once you release your app to the App Store, it will not display every time.
https://developer.apple.com/documentation/storekit/skstorereviewcontroller/2851536-requestreview
Hope this helps.

Hi @crashoverride777 ,
Thanks for your quick reply. Sorry If I hurt you in my below comment. If you want then I can also delete it later. I am really sorry for that again. :-(
May I know why you added below parameters.
        afterAppLaunches: 50,
        customAlertTitle: "Rate My App",
        customAlertMessage: "RATE_ALERT_MSG".localized,
        customAlertActionCancel: "Remind me later"

@crashoverride777 , You should inform in your readme file in header that:
> For ABOVE IOS 11 users, This is not for you. DO NOT USE THIS.

Please don't waste your time using ,my repo for the users which are using iOS 11 or later

Hey
You are correct, that one line is enough if you are targeting iOS 10.3 and above. I will update the readme to make this clearer.
Thanks again


How to include the library

Hello,
I may sound like a nooby but I'm going for it. How to include your library? I did not understand in your documentation you just say to download it and that's all but I guess there is not that to do. I already have Eigen. I am on Linux.
Thanks!

Hi @NicoBrug , sorry for the lack of documentation.
First, download and unzip it. And provide the directory where you unzipped it with -I option to gcc like following.
$> wget https://github.com/bab2min/EigenRand/archive/refs/tags/v0.3.3.tar.gz
$> tar -zxvf v0.3.3.tar.gz # it will generate the folder `EigenRand-0.3.3`
$> g++ -std=c++11 your_file.cpp -IEigenRand-0.3.3/

Thanks for your answer, to use the library with cmake, you can include in the CMakeLists.txt:
include_directories(lib/EigenRand-0.3.3) link_directories(lib/EigenRand-0.3.3)


Nukie agent requires chemistry hours, rather than general medical hours.

About the PR
Change nukie agent's playtime requirement from 5 hours medical to 5 hours chemistry.

Why / Balance
It seemed odd that nukie agents were expected to make chemicals for use in their hypospray but did not require any chemistry hours. Too often will the agent reportedly "not know how to make chems" which just isn't fun for anyone - the agent will be confused, feel pressured, and their teammates will be a little frustrated.
This change was inspired from the discussion in https://discord.com/channels/310555209753690112/1230539113459875940

Technical details
It's a two line change, from DepartmentTimeRequirement for 18000s Medical to RoleTimeRequirement for 18000s JobChemist

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
Webedit ops, first PR, who knows, but it's a two-line change within the role timer requirement.

Changelog

:cl:

tweak: Nuclear operative agents now require time in Chemistry rather than time in the Medical department.

Pretty sure you need playtime in medical to unlock chem anyways, so this works out perfectly

Pretty sure you need playtime in medical to unlock chem anyways, so this works out perfectly

Yeah it pretty much extends the amount of time you need to spend overall. I was thinking of 3 hours in chem, as this is what you needed to unlock CMO but this is just simpler.

This will need more discussion. It's not gameplay friendly that a singular nukie role could potentially cost 10 hours (or more if you need to play medical to unlock chemistry).

Pretty sure you need playtime in medical to unlock chem anyways, so this works out perfectly

Currently, the nukie agent requires 5 medical hours to unlock while the chemist requires 5 medical hours to unlock... chem takes 6 medical hours to unlock... when you need to make chems as the nukie agent, you should have some time in chemistry so you know what your doing.

After thinking about it, I'm gonna lower the chemistry time requirement to 3 hours. I guess the cumulative time from unlocking chemistry AND playing it for 5 hours is really a lot.

Holy scrap, finally. Hopefully this cuts down on the amount of agents who have never touched chem.

Ah, then it works out really well IMO.

This will need more discussion. It's not gameplay friendly that a singular nukie role could potentially cost 10 hours (or more if you need to play medical to unlock chemistry).

commander takes at minimum 15 hours to unlock

This will need more discussion. It's not gameplay friendly that a singular nukie role could potentially cost 10 hours (or more if you need to play medical to unlock chemistry).

I think it's perfectly fine for agent specifically to have a high hours played requirement, as it is a role that requires a lot of medical knowledge (you are a combat medic, you need to be prepared, and you need to be able to act fast, otherwise your team will die).
Regular nukies are fine to have lower hours - this is what people really want to play, especially those with lower hours. I have seen too many people roll nukie agent and have absolutely no clue how to make medicine, which is the number one thing the role is meant to do in preparation for station assault. If they aren't making meds, they may as well just be another operative rather than agent, and at that point, why even have the Agent role? A few hours of chem is totally reasonable here in my opinion.

personally, i feel this is more than fine, and just makes it so people actually have to understand what the role is actually meant to do. a new player first experience making chems should not be as a nukie medic.

This will need more discussion. It's not gameplay friendly that a singular nukie role could potentially cost 10 hours (or more if you need to play medical to unlock chemistry).

The Nukie Agent role is by design one that needs that playtime as it requires basic competency in Chemistry to function correctly. As well as this, the bar for Nukie Agent is even higher than an actual Chemist would need to function, as they must do jug chem in a ChemMaster instead of use dispensers like normal, which is an extremely obtuse experience unless you're already familiar with how the machine works and which chems make what.
New players without Chem knowledge being thrown into Nukie Agent will simply not have any fun performing the role they signed up for. Agent is extremely obtuse to learn as it lacks QoL in the form of the dispenser (which is basically a Quality of Life machine, in current balancing), being on a time crunch to figure out what you're actually supposed to do, and not having another player to help you learn, like a CMO or second Chemist would.
As such it is incredibly common for the role to just be off-loaded to someone that wasn't selected as the Agent, thus "trading jobs", or just not having an agent altogether, which is even less friendly to gameplay. It is just a role with a very high skill floor relative to the other antagonist roles, and I think it's sensible to have time requirements that reflect that, as without it gameplay often suffers for all involved.

I think the general sentiment from everyone I talk to is that making the time you need to spend to unlock the role actually teach you the basics on how to actually do that role. As it currently is you get nukies that don't understand how to do basic medical and just pawn it off on another member, not to mention when new med comes in this change will be even more needed as from what I've heard, even basic combat meds will, react badly with other chems and could easily lead to the death of an entire team. overall, this is needed now, it was needed months ago, and it will be even more needed when new med comes out. this isn't about making it less friendly for new players, it's about making it so people can actually do their job on a high stress role that drives the round forward. it's not fun for other people to have to do another person's job because they were not given enough time to learn how to play the game, all it does it breed animosity among the nukie team.

Alright I'll give my full thoughts in this message
I can understand why the maintainers don't want excessive role timers - the sooner that players can get eligible for playing the roles they want, the better the experience. However, I think that there are exceptions to be made for certain roles, particularly the command roles and team antag roles. Syndicate agents are fine for anyone to be, a new syndicate agent doesn't really harm anyone, so why not let anyone opt in? But there's a huge problem with having an agent who simply has never touched chemistry in their entire playtime. Operatives are fine at 5 hours of playtime - for a similar reason that syndicate agents are fine to not have locked behind a role timer. Operatives have no particularly special duties or equipment, so they are the most 'basic' of the nukie roles. An agent is very specialized - you have to know how to play operative, plus how medical and chemistry works. Because of this, why would you be able to queue for agent without ever having touched chemistry? Any operative can apply sutures and meshes, so the chemistry part is really what's expected from the agent due to the hypospray.
Anyway, It's an anecdote but I don't think its crazy for me to say that a significant amount of agents that I have played with, upon some asking, reveal to me that they have NO idea how chems work. The most common approach is just saying "okay, look, give me your specialized gear and I'll play as the agent." This, I think, reveals a problem - players are queueing into agent, knowingly or unknowingly expecting to be able to pawn off the duty to someone else. Let's assume that they aren't. A person rolls nukie agent for the very first time without touching chem. They have to prepare and purchase items accordingly with their team, AND learn chemistry at the same time. They will inevitably be under time pressure and pressure from their peers since the nukies will of course want to leave eventually. I think this is the reason that a lot of the times the situation arises where the agent just gives up their role to someone else. The question is, is this fine or should they just have not been able to opt in for agent to begin with and 'take' this antagonist role over the person who DID have at least some experience with chemistry?
This is all to say, I think even when assuming good faith, someone playing nukie agent for the first time with 0 chemist is simply an overwhelming experience and it would be far more constructive if players had at least encountered and messed with chemistry before being able to play agent. I don't expect or want this role timer to be a 'robust player filter', but to make things go a bit more smoothly, as the clueless nukie agent is not fun for anyone, especially since it is arguably THE most important member on the nuclear operative team.

While I think this is a good change, I don't think role timers are enough. We as a community need to make learning tools way more accessible to newcomers. SS14 is a hard game to learn and this would help in all aspects of the game, not just Nukie Agent.
Whether that be more online tutorials, reviving the wiki, or allowing the in-game guidebook to become far more detailed, something needs to happen, or we're going to constantly run into issues exactly like this.

I don't mean to seem rude or impatient but a change like this isn't asking for much and all it does it stop people who don't know how to play the role... from playing the role, and while it may seem like it may hamper a new player, there are both other nukie operatives that can be played and it's not fun for other people that have to pick up the slack of a bad medic.
I emphatically request that this be merged as this has been open for a while now and no negative opinions have made themselves known that have not been given a fair rebuttal and discussion.

merg

heya, do we know what's going on with this?

heya, do we know what's going on with this?

Stop spamming the pr or I'll just close it.

I was just asking as nothing had been said about it for a week, and was wondering what was going on with it. i don't mean to sound inpatient.


Compatibility with .NET Standard

I need to build an application that runs on the Universal Windows and .NET Core runtimes to consume the OData v3 data from SAP B1 web service. When I attempt to install any clients I'm unable to restore the package to my UWP project.

This is correct. Simple.OData.Client uses internall two Microsoft's OData libraries: for OData protocol version 1-3 and for OData protocol version 4. None of them currently support .NET Core. It doesn't look like legacy ODataLib (the one that uses OData V3) will have any major update. AFAIK both libraries should be OK with .NET Standard 2.0, this will require repackaging of our library. It will come as a major version upgrade, I will need to investigate more.

Thanks! Glad you confirmed this is doable!
I got in contact with a Microsoft OData feedback team member as well, to ask about the WCF layer extension for VS 2017. He said they had a work item for it. Not so sure what the hold-up with Microsoft is. Maybe it's in development too.
The core of our business will be resting on SAP data as we move forward, so I'm hoping to do research ahead of time and fulfill the needs for all the platforms, since we'll be on .NET Core with Linux, UWP with Windows 10.
I really like .NET Standard, and it's so nice that when a library is put on it, that the code will run on all devices.

For your information: I just pushed the version 5.0.0-beta2 that supports .NET Standard 2.0 and updated to use ODataLib7.


[CARBONDATA-2391] [Compaction Thread Leak] Thread leak in compaction operation if prefetch is enabled and compaction process is killed

Problem
Thread leak in compaction operation if prefetch is enabled and compaction process is killed
Analysis
During compaction if prefetch is enabled RawResultIterator launches an executor service for prefetching the data.
If compaction fails or the process is killed it can lead to thread leak due to executor service still in running state.
Fix
Close the executor service in task completion listener of compaction
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5341/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4173/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4494/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4554/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5417/

LGTM


Config hydrate objectives not working

Reason for This PR
Config struct Objectives are impossible to encode in JSON format.
I added a test in order to see how Config structure is encoded in JSON and I found out that map keys that have float/float64 types are not possible to encode with error: json: unsupported type: float64.
I suppose if objectives have to be supported in JSON the key should be changed to string/int type.
Description of Changes
For now just the test that demonstrates the issue.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist

[ ] All commits in this PR are signed (git commit -s).
[x] The reason for this PR is clearly provided (issue no. or explanation).
[ ] The description of changes is clear and encompassing.
[ ] Any required documentation changes (code and docs) are included in this PR.
[ ] Any user-facing changes are mentioned in CHANGELOG.md.
[ ] All added/changed functionality is tested.

Summary by CodeRabbit

Tests

Introduced a new test for JSON marshaling of configuration objectives.

Hi @rustatian. Please provide your opinion on this one. Thank you.

Hey @mtamazlicaru 👋
We're using yaml, not JSON. Also, you should use Config plugin to unmarshal configuration.

If yaml is used can you please tell why json tag is used in Config struct?
Also when you say Config plugin, what plugin do you mean? Could you please provide a link to it?
Thank you.


Fixed onClickHandler and onButtonClickHandler event.preventDefault calls

There were brackets missing on the e.preventDefault call on both onClickHandler and onButtonClickHandler.
When used inside a form element, clicking on the button would previously trigger the forms post.

Thanks @thomani :+1:


fix a few instances where the device type is not used as a bit mask

See https://github.com/boostorg/compute/issues/505

I Travis is failing because the compiler goes OOM.

Looks good! Thanks for fixing these!
Could you make the pull-request against the develop branch? After that it should be good to merge. Thanks!


[#3649] feat(client): remove log4j impl from client-java-runtime

What changes were proposed in this pull request?
remove log4j impl from client-java-runtime
Why are the changes needed?
Fix: #3649
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing IT
local spark env

@mchades  some changes about purgeTable, please help to review again

@mchades @jerryshao I will remove the changes about purgeTable in latest commit.

@mchades @jerryshao I will remove the changes about purgeTable in latest commit.

done, please help to review again @jerryshao


"none is not an allowed value" for Hashable field

Although None is Hashable, it fails to validate below. Even stranger, it still fails with the same error if the field is explicitly annotated as Optional[Hashable]
from collections.abc import Hashable
from typing import Optional
from pydantic.dataclasses import dataclass

class Config:
    arbitrary_types_allowed = True

@dataclass(config=Config)
class Model:
    v: Hashable
    # v: Optional[Hashable]

assert isinstance(None, Hashable)

Model(None)

# output:
#
#pydantic.error_wrappers.ValidationError: 1 validation error for Model
#v
#  none is not an allowed value (type=type_error.none.not_allowed)

Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
pydantic version: 1.4
pydantic compiled: True
python version: 3.6.9 (default, Nov  7 2019, 10:44:02)  [GCC 8.3.0]
platform: Linux-4.15.0-76-generic-x86_64-with-Ubuntu-18.04-bionic
optional deps. installed: ['typing-extensions']

Surely better to properly implement a check for the Hashable type?

You mean special-case Hashable instead of the general proper fix isinstance(None, self.type_)  in the PR? Why?

Yes, so we can more generally support Hashable

The PR effectively adds support for Hashable; it just so happens that we get for free a fix for any virtual superclasses of None, current or future ones, not just Hashable.


Yes it can. I fixed the typing and didn’t think about it otherwise

          Yes it can. I fixed the typing and didn’t think about it otherwise

Originally posted by @bdraco in https://github.com/uilibs/uiprotect/pull/173#discussion_r1711028746

Already addressed by https://github.com/uilibs/uiprotect/pull/175


fix traffic accounting in internal statistics / metrics

Scope & Purpose
Backport of https://github.com/arangodb/arangodb/pull/17651
Fix traffic accounting for HTTP/VST in internal statistics / metrics.
Outgoing VST traffic was not accounted for previously.
Additionally, the traffic was not accounted for the request that initiates a protocol change from HTTP/1.1 to HTTP/2.
Finally, the metrics histograms that summed up traffic were not correctly reporting values since 3.10.
For consistency, this PR also adds a new metrics arangodb_http1_connections_total, which counts the number of HTTP/1.1 connections. There were previously only metrics for HTTP/2 and VST connections.

[x] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[x] Tests

[ ] Regression tests
[ ] C++ Unit tests
[x] integration tests
[ ] resilience tests

[x] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[x] Backports

[x] Backport for 3.10: https://github.com/arangodb/arangodb/pull/17652
[x] Backport for 3.9: this PR
[x] Backport for 3.8: https://github.com/arangodb/arangodb/pull/17654

Related Information

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket:
[ ] Design document:

Jenkins run (not automatically picked up): https://jenkins.arangodb.biz/view/PR/job/arangodb-matrix-pr/25934/


MODIFIED convert-json-data-to-html to warn about XSS attacks (english)

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the master branch of freeCodeCamp.
[X] None of my changes are plagiarized from another source without proper attribution.
[X] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[X] My changes do not use shortened URLs or affiliate links.

Related to #36162

@Wocanilo, thank you for adding this note. It will really be helpful to new learners who are unaware of the risks that come with using innerHTML.
It reads very well, I just have a couple of small nitpicks I'll leave as a review comment.

I made the suggested changes here. As well as on the other PR.

@raisedadead Sorry about that.  For some reason lately when running npm run develop, I end up with changes to those files and if I don't forget to revert the changes, they accidentally end up on a commit when I run git add ..  I have reverted the changes to those files.


Add auto set up docker images for WAMR-IDE

add docker images auto check and setup support
fix bug that if user skip install then the code goes on

@loganek @eloparco Could you help review this PR? Thanks.

@loganek I updated the patch according to your comments, could you please help to take a look. Thanks~

@loganek Ning has addressed the comment, shall I merge the PR?


Add adjustable angle to the Bevel

I have the code for this finished, but am currently unable to create a branch, check in changes, or create a PR.  Just simply adding a few rough selections (very shallow, shallow, slightly shallow, even (45), slightly steep, steep, very steep) in a drop-down menu underneath the check box.  Could probably make it show or hide based on the checkbox as well.  Just needed this for my own personal use, but would be happy to include it in the main project for everyone.

Would be best just making a fork with your own changes


Where is the code for opening the onscreen keyboard for iOS?

I’ve been looking, but I can’t find the code for opening the onscreen keyboard for iOS. Does anybody know where it is?

https://github.com/codefrau/SqueakJS/blob/e6ae5249303065094caba172e3752c4ebc0d0724/squeak.js#L736-L751


The annotation layer dimensions must be set before adding some elements (follow-up of #15770)

In order to move the annotations in the DOM to have something which corresponds to the visual order, we need to have their dimensions/positions which means that the parent must have some dimensions.

/botio integrationtest

/botio unittest


Update npm depenency

refactor(npm-dependency): fix Dependency of npm packages
update versions

@azlam-abdulsalam tested the popular commands with profile and pool, and tested majority of the other commands and LGTM


Add unit tests for UserRepository

fixes #1002
Will be consuming this for #908

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7bdc335). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #1004   +/-   ##
=========================================
  Coverage          ?   69.76%
=========================================
  Files             ?       93
  Lines             ?     7057
  Branches          ?        0
=========================================
  Hits              ?     4923
  Misses            ?     1675
  Partials          ?      459

Impacted Files
Coverage Δ

account/user.go
54.66% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bdc335...590c810. Read the comment docs.


Support GPX waypoint type tag

This also introduces an extend feature that should only be used with simple
objects (non-inherited property-value pairs). Also, sym properties are no
longer generated when they are absent from the GPX file.

👍 Thanks!


Add support for Ruby 2.5

Ruby 2.5 runtime has been added to OpenWhisk, this pull request adds support for running it locally with Docker Compose.

thanks @Juice10 !


Fix 'informational' issues (audit recommendations)

There are some very minor things brought up in the audit that we might want to fix. The following checklist only includes the item ID; the description and details can be found by looking at the audit report.

[ ] TYP-01 Confusing Variable Naming
[x] SYS-03 Unnecessary Variable
[ ] STA-02 Lack of Validation for destination_adress on send_payment_to_address()
[ ] STA-01  Code duplication
[x] SRW-01 Usage of hard-coded string
[ ] SRC-01 Unused Methods and Storage
[x] PRO-01 Unhandled Error
[x] PAE-02 Usage of magic numbers
[x] PAE-01 Unnecessary Result<> Return Type
[ ] LIT-04 Reduce using unwrap() and expect() in Production Codebase
[ ] LIT-03 Panic can happen between correlated storage modifications
[ ] LII-01 Inconsistent match expression
[x] LIE-04 Mismatch in variable name and pallet
[ ] LIL-01 Dead Code in execute_replace()
[x] IMP-01 Same Behavior Defined for different conditions
[x] EXC-01 Missing information in logging message
[ ] CLI-03 Incorrect error type thrown
[x] CLI-02 Typos
[ ] CLI-01 Confusion function naming
[ ] 4FC-05 Commented out code
[x] 4FC-04 Logic should be moved to a separate function - refactoring
[x] 4FC-03 Unused errors
[x] 4FC-02 Inconsistent comments

Since the changes are so minor, it's okay to include all of them in one branch and one Pull Request. But each of them should at least be addressed in a separate commit with a proper name, also mentioning the ID in the name so that it's easier to track the changes.

Hey team! Please add your planning poker estimate with Zenhub @b-yap @ebma @TorstenStueber

EXC-01 -  Missing information in logging message
was completed by https://github.com/pendulum-chain/spacewalk/pull/377

4FC-04 Logic should be moved to a separate function - refactoring -> https://github.com/pendulum-chain/spacewalk/pull/388

could not find the ff. in skyharbor.certik:

LIL-01 Dead Code in execute_replace()
LIT-03 Panic can happen between correlated storage modifications

Oh right, that's weird. I also can't find them to be honest 😅
@b-yap can you check and compare the informational issues that are listed on page 46 ff. to the informational issues that are listed in the description of this ticket and add any that's missing? For example, I can see that 'LIH-02 Values Length Not Validated In feed_values Function' is also not included and there might be others. I'll attach the final report here so that it's unambiguous which report we are talking about.
REP-final-20230303T193754Z.pdf

LI5-02 TryFrom CurrencyId implementations Contain Repeated Code
was completed by https://github.com/pendulum-chain/spacewalk/pull/264 (see 4th commit)

https://github.com/pendulum-chain/spacewalk/pull/390 covers:

IMP-01 Same Behavior Defined for different conditions
LIE-04 Mismatch in variable name and pallet
4FC-02 Inconsistent comments
PRO-01 Unhandled Error
LIH-03 Values Length Not Validated in feed_values Function
CLI-01 Confusion function naming
CLI-03 Incorrect error type thrown

@ebma one of the concerns of  4FC-05 Commented out code are
https://github.com/pendulum-chain/spacewalk/blob/ad68c16f55141357d14df66d40717b42d089c96c/clients/vault/src/system.rs#L718-L720
and
https://github.com/pendulum-chain/spacewalk/blob/ad68c16f55141357d14df66d40717b42d089c96c/clients/vault/src/system.rs#L660
Do you know what to do here, or is a separate ticket needed to address this?

4FC-05 Commented out code

some of them do not exist anymore:

https://github.com/pendulum-chain/spacewalk/blob/53050f52be1f941ebe1d56d14088f0d515ada474/clients/vault/src/oracle/agent.rs#L219
https://github.com/pendulum-chain/spacewalk/blob/53050f52be1f941ebe1d56d14088f0d515ada474/clients/runtime/src/types.rs#L77
https://github.com/pendulum-chain/spacewalk/blob/53050f52be1f941ebe1d56d14088f0d515ada474/primitives/src/lib.rs#L697-L700

The related ticket already exists. It's this one. I would keep the comments until we actually implemented the ticket about the faucets. If there is no other commented out code besides these, then there is nothing to do IMO.

LIT-04 Reduce using unwrap() and expect() in Production Codebase
does not exist anymore:

https://github.com/pendulum-chain/spacewalk/blob/b5307e9c1e805bafe4546e661df056c96548a878/pallets/stellar-relay/src/lib.rs#L619
https://github.com/pendulum-chain/spacewalk/blob/b5307e9c1e805bafe4546e661df056c96548a878/pallets/stellar-relay/src/lib.rs#L654

#393 covers:

STA-01 Code duplication
SRC-01 Unused Methods and Storage
4FC-05 Commented out code
LII-01 Inconsistent match expression
LIT-04 Reduce using unwrap() and expect() in Production Codebase
TYP-01 Confusing Variable Naming

GLOBAL-05 Unneceessary Off-Chain User Protection Mechanism

The mechanism described (reported below) in the document Spacewalk Specification (Audit) in the section security_consideration/theft_reporting adds unnecessary off-chain complexity to the bridging protocol that can be avoided without having an impact on the protocol design.
"We also don’t need theft reporting because all cases are covered except for one scenario: the user sends a payment to a vault as part of an issue request, but the vault does not call the executeIssue() extrinsic." "To protect the user in this scenario, we can implement an extra mechanism to the web app that allows the user to register new issue request

@ebma correct me if I'm wrong: the off-chain mechanism mentioned here is:
https://github.com/pendulum-chain/spacewalk/blob/5fc74e08ebdcf334529ee9fb73fd2c29bdc10f7a/pallets/vault-registry/src/lib.rs#L780
?

@b-yap yes, I think it is. I'm curious however, because I think we cannot just remove that line. I think there is no other check for undercollateralized vaults. What I say in the quote about no need for theft reporting is irrelevant here, because
 let call = Call::report_undercollateralized_vault { vault_id: vault };

is not reporting for theft on Stellar, but it's reporting about undercollateralized vaults.
@b-yap can you check whether the current implementation checks and punishes undercollateralized vaults in another place than the line you linked to?

@b-yap pinging you again about the question before, before we close this ticket.

I do not see report_undercollaterized_vault() being called anywhere else besides an unsigned extrinsic call.

Can you share a link to where it's being called?

https://github.com/pendulum-chain/spacewalk/blob/5fc74e08ebdcf334529ee9fb73fd2c29bdc10f7a/pallets/vault-registry/src/lib.rs#L128C6-L151
i meant when validating an extrinsic call.

I still think GLOBAL-05 is reported wrongly and they misunderstood some part of the logic. Referring to what they say in their comment, I think they misunderstand theft reporting as reporting undercollateralized vaults. Theft reporting was about reporting vaults that transfer the assets they hold somewhere else on Stellar. And we don't care about that. But undercollateralized vaults are still important for us. Thus, GLOBAL-05 is nothing we need to change. And since it's the last remaining issue of this ticket, we can close it.


⚠ ClamAV has degraded performance

In 1632ab6, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 437 ms

Resolved: ClamAV performance has improved in 67e4052 after 14 minutes.


Feat/enhance

use resolve module to resolve id just behaviors like webpack
use yarn consistently always, remove package-lock.json

Sorry I don't have Windows computer personally, is there anyone can help to fix the issue on Windows?


Setting accuracy parameter in the pyproj.Transformer class

This is a question about how to set the accuracy parameter in the Transformer class.
I have UK Northing/Easting (EPSG:27700) data held in the variable DATA and would like to project this to WGS 84 (EPSG:4326) to a given level of accuracy using pyproj as set out in the following code snippet:
from pyproj import Transformer, CRS
from shapely.ops import transform
transformer = Transformer.from_crs(DATA.crs, CRS.from_epsg(4326), always_xy=True)

From the API I understand that the Transformer accuracy parameter is in metres and defaults to -1.0. If I wanted to set this accuracy to an arbitrary distance, say, 0.5m, how do I do this?
My naïve attempts to set the value as below fail with a can't set attribute error:
-1.0
>>> transformer.accuracy = 0.5
Traceback (most recent call last):
  AttributeError: can't set attribute
>>> transformer['accuracy'] = 0.5
Traceback (most recent call last):
  AttributeError: can't set attribute

I have looked and couldn't see answer in the usual places.

The accuracy of a transformation is a read-only property of the transformer. It is read in from the database and is informative in nature. Out of curiosity, why do you want to change it?

Good question it is based on two ideas:
First is my wish to understand pyproj better given that it underpins geopandas and a number of other key application. Given this, I was unaware that this is read in from the database and in my case I would have to then ask, what database? But that is probably more due to my lack of knowledge on my part.
Then, the second thought, albeit likely a misunderstanding on my part, is as follows:
I have a dataset that is in Northing/Easting (EPSG:27700) at tolerance of no more that 0.1m, if I transform this to WGS 84 (EPSG:4326) I then under up with points with 15-decimal-places, e.g. POINT (-1.356251776938934, 53.073162191357319). By my calculations something akin to the diameter of an electron.
This has two issues:
The ability to compare equivalence of points. For example, given two points, say POINT (-1.356251776938934, 53.073162191357319) and POINT (-1.356251776938939, 53.073162191357319). These are different at the 15-significant figure level but equal at a rough-hand-wavy five-significant figure POINT (-1.356251, 53.07316) or 1m(ish).
My first question is does an accuracy parameter of say 0.5m address this?
Then about output file-size bloat. I realize this is an interface hygiene issue and is arguably not a pyproj issue at all[*]. If I try to output the data to a text file at this level of accuracy this tends to a 260% increase in file size as a a point at five-significant figures can be represented in a 20-byte file whereas the 15-significant figure representation takes 39-bytes.
Again, this might be my misunderstanding, but would setting the accuracy to say, 0.5m, change this too?
[*] I then have an rather inelegant  kludge to get around this using shapely.transform and round...

I understand your problem much better now. So, the reason for all of those decimal places is because the data type is always going to be a double. It doesn't necessarily mean that all of the decimal places are important. If you wanted to round the decimal places where it makes sense, that would definitely be just fine.
If it is geographic, usually 7 decimal places gives you plenty of accuracy. However, it depends on what your needs are. If it is projected & the units are meters, usually 3-4 decimal places is plenty depending on your needs.
The accuracy of the transformation is dependent on the nature of the transformation calculation itself and/or datum grids. So, the value from the database is just there to let you know that when you transform from one projection to another, this is the error you can expect. Also, the database is in the data directory.

https://www.explainxkcd.com/wiki/index.php/2170:_Coordinate_Precision

Thanks for this.
This then prompts the following questions, and then I'm done:
Does the accuracy parameter change behaviour or is it for information, and if it does what is the mechanism to set this?
More generally within pyproj is there a way to define a precision within which it is possible to define equality or output format?
(I'm kind of interested in national or international rail traffic for which 5m is "good-enough" for to-the-second movement data....)
Thanks again

The accuracy is just for information. So, no behavior change.
numpy can help with the decimal precision: https://numpy.org/devdocs/reference/generated/numpy.around.html#numpy.around


Adding a feedback dialogue

By now we have enough feedback in play store, let's not implement this task yet. Maybe will do later.


Caution : Repository is Singleton

AppDataManager is a singleton.
Is it recommended to keep your class as Singleton?

@ashish-andev It depends on the use-case like:

How frequently we are going to use that object?
How much resource is needed to create the object of that class?


Changed set-certs from external data source

Signed-off-by: Rich Ehrhardt<EMAIL_ADDRESS>

Verification is failing due to hitting the rate limit on the number of certificates that can be generated for a domain per week. Waiting to re-run until Monday.

Looks good to me


SSR not rendering styles

It seems like the server-rendered view has no styles applied to it and flickers from the view below, to the fully rendered & styled client-side one afterwards.
Is this default behavior with Vue perhaps?

Did you run this in production or development mode (npm run start or npm run dev)? In development mode, Webpack creates style tags with javascript to allow hot reloading CSS. In production mode, the CSS should be bundled into its own CSS file.

Dev mode requires JavaScript... obviously. In production mode the CSS doesn't rely on JavaScript.

Ahh ok, I wasn't sure if it was being passed in with the HTML itself and not being parsed correctly.
Makes sense thanks Evan :+1:


DTSPO-16389: reader access of KV containing slack webhook

Jira link (if applicable)
https://tools.hmcts.net/jira/browse/DTSPO-16389
Change description

reader access of KV containing slack webhook

Checklist

[x] commit messages are meaningful and follow good commit message guidelines
[x] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)
[ ] Does this PR introduce a breaking change

Plan Result (prod_app_registrations)
:warning: Resource Deletion will happen :warning:
This plan contains resource delete operation. Please check the plan result very carefully!
Plan: 1 to add, 0 to change, 1 to destroy.

Create

module.this.azurerm_role_assignment.this["WAF Monitoring-Key Vault Secrets User-/subscriptions/1baf5470-1c3e-40d3-a6f7-74bfbce4b348/resourceGroups/core-infra-intsvc-rg/providers/Microsoft.KeyVault/vaults/cftptl-intsvc"]

Delete

module.this.azurerm_role_assignment.this["WAF Monitoring-Reader-/subscriptions/1baf5470-1c3e-40d3-a6f7-74bfbce4b348/resourceGroups/core-infra-intsvc-rg/providers/Microsoft.KeyVault/vaults/cftptl-intsvc"]

Change Result (Click me)

  # module.this.azurerm_role_assignment.this["WAF Monitoring-Key Vault Secrets User-/subscriptions/1baf5470-1c3e-40d3-a6f7-74bfbce4b348/resourceGroups/core-infra-intsvc-rg/providers/Microsoft.KeyVault/vaults/cftptl-intsvc"] will be created
  + resource "azurerm_role_assignment" "this" {
      + id                               = (known after apply)
      + name                             = (known after apply)
      + principal_id                     = "414c87c4-9f5a-4fcf-b630-91d1c282ace0"
      + principal_type                   = (known after apply)
      + role_definition_id               = (known after apply)
      + role_definition_name             = "Key Vault Secrets User"
      + scope                            = "/subscriptions/1baf5470-1c3e-40d3-a6f7-74bfbce4b348/resourceGroups/core-infra-intsvc-rg/providers/Microsoft.KeyVault/vaults/cftptl-intsvc"
      + skip_service_principal_aad_check = (known after apply)
    }

  # module.this.azurerm_role_assignment.this["WAF Monitoring-Reader-/subscriptions/1baf5470-1c3e-40d3-a6f7-74bfbce4b348/resourceGroups/core-infra-intsvc-rg/providers/Microsoft.KeyVault/vaults/cftptl-intsvc"] will be destroyed
  # (because key ["WAF Monitoring-Reader-/subscriptions/1baf5470-1c3e-40d3-a6f7-74bfbce4b348/resourceGroups/core-infra-intsvc-rg/providers/Microsoft.KeyVault/vaults/cftptl-intsvc"] is not in for_each map)
  - resource "azurerm_role_assignment" "this" {
      - id                   = "/subscriptions/1baf5470-1c3e-40d3-a6f7-74bfbce4b348/resourceGroups/core-infra-intsvc-rg/providers/Microsoft.KeyVault/vaults/cftptl-intsvc/providers/Microsoft.Authorization/roleAssignments/291e67f3-0697-46f5-82ac-bd855114e12d" -> null
      - name                 = "291e67f3-0697-46f5-82ac-bd855114e12d" -> null
      - principal_id         = "414c87c4-9f5a-4fcf-b630-91d1c282ace0" -> null
      - principal_type       = "ServicePrincipal" -> null
      - role_definition_id   = "/subscriptions/1baf5470-1c3e-40d3-a6f7-74bfbce4b348/providers/Microsoft.Authorization/roleDefinitions/acdd72a7-3385-48ef-bd42-f606fba81ae7" -> null
      - role_definition_name = "Reader" -> null
      - scope                = "/subscriptions/1baf5470-1c3e-40d3-a6f7-74bfbce4b348/resourceGroups/core-infra-intsvc-rg/providers/Microsoft.KeyVault/vaults/cftptl-intsvc" -> null
    }

Plan: 1 to add, 0 to change, 1 to destroy.


Support for convention-based max length in EF Core

The maximum length is now automatically configured with the use of configurationBuilder.Conventions.AddBaseTypeConventions();.
I exposed the properties of MaxLengthStringAttribute and MinMaxLengthStringAttribute to be able to grab thoses values from inside the convention builder.
The doc has been modified

Hi @adampaquette,
I’m a bit hesitant about the change. I’ll try to give you my reasoning behind that:
Up until now, it’s optional to use the predefined validations in AD.BaseTypes. That means, a library user is free to create his own MaxLengthStringAttribute and everything will continue to work. One possible reason to create your own validations might be to throw custom exceptions with localized error messages.
The implementation of BaseTypeMaxLengthConventions deviates from that principle. The library user has to use the predefined MaxLengthStringAttribute for the convention to work.
I can think of 3 solutions to that problem:

Accept that AD.BaseTypes.EFCore works differently and requires the user to use the predefined attributes.
Define an interface IMaxLengthStringValidation and change the implementation of BaseTypeMaxLengthConventions to check for the interface.
I’m not sure where the best place to put IMaxLengthStringValidation would be, but we could put it in an "EFCore" folder in AD.BaseTypes.Core.
Don’t provide the BaseTypeMaxLengthConventions in the first place and leave it up to the library user to set up the MaxLength accordingly.

I'm preferring solution 2, but what do you think?


Unslicking in Responsive Breakpoint doesn't deactivate the adding of slick-active slick-center

Hello,
This is a branched issue from #1303
That issue outlines the issue with reslicking after it's been unslicked by the responsive breakpoint.
This issue is related but seperate. If you unslick at certain breakpoints this works fine, however if you leave it for a little bit of time you'll find the individual elements start getting the 'slick-active slick-center' classes applied to them one at a time.  So it seems the unslick didn't cancel the timer for the addition of those classes.
Thank you

Here's a fiddle to show it happening.
:sparkles: http://jsfiddle.net/odoqefdq/ :sparkles:


FERPA

Please update page to include comment on Microsoft Teams support of FERPA

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ca579d63-182b-d6f5-8777-79248fa27ed9
Version Independent ID: b4c27d1b-b2f1-41ac-b15c-d12b448a539e
Content: Overview of security and compliance - Microsoft Teams
Content Source: Teams/security-compliance-overview.md
Service: msteams
GitHub Login: @MicrosoftHeidi
Microsoft Alias: heidip

@lysmyers Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@lysmyers thank you for reaching out and helping improve MS Docs. Are you referring to the Family Educational Rights and Privacy Act (FERPA).  Please let me know where you see the comment reflecting this for MS Teams.

@lysmyers  We appreciate any feedback that improves the content in the Microsoft docs but we haven't had any response from you so we are going to close this issue.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


[SPARK-36841][SQL] Add ansi syntax set catalog xxx to change the current catalog

What changes were proposed in this pull request?
1、Add the statement of set catalog xxx to change the current catalog
2、Retain the USE statement to change the current catalog
3、Forcible loading the new catalog when change the new catalog.
Why are the changes needed?
Ansi SQL use SET CATALOG XXX statement to change the catalog.
DISCUSS

Does this PR introduce any user-facing change?
Yes, User can use SET CATALOG XXX to change the current catalog
How was this patch tested?
Add ut testcase

Can one of the admins verify this patch?

@cloud-fan @imback82 Could you take a look ? Thank you.

SET CATALOG is a very simple command that we can just implement as RunnableCommand. Can you follow https://github.com/apache/spark/pull/34128 and simplify this command as well?

SET CATALOG is a very simple command that we can just implement as RunnableCommand. Can you follow #34128 and simplify this command as well?

ok. Thank you for the reminder.

@cloud-fan A little off-topic: I also think SHOW CATALOGS #33175 is a very simple command that we can just implement as RunnableCommand follow #34128. Could I
continue to update after holiday?

Could I continue to update after holiday?

Yes thanks!

thanks, merging to master!


Timeouts

Still get timeouts. All test-beds use 1 to 2 minutes downloading Flarum. However, live test at 000webhost.com(Edge Case Testing) times out randomly. It work 2 times, then fail 5, then works again.
It could be server load, or limited bandwidth, and that increasing php timeout will help.
Also get random 504 timeout return from Ajax call which is not supposed to return anything, however, the call itself initiated what it is supposed to.

Closing for now. Might need another option for this, which will get it's own issue later on.
I am fairly sure I need to tackle this problem completely different, for example download the flarum/flarum install manually, and run install flarum/flarum.
Might have to do a failcheck on create-project command's output and then give user option to download another way... Do not want this though, as it put more stress on keeping things updated.


Please update language-javascript to 0.100.0

See https://github.com/atom/language-javascript/issues/253#issuecomment-154908352

Grammars are automatically updated with each new release of Linguist ;)

This is fixed in master now. We should be cutting a new gem in the next day or so.