OnDeploy Scripts on Cloud Service

Required Information

[ ] Cloud Service
[ ] 4.7.0
[ ] Yes

Although the OnDeploy Scripts show up in the Build Image logs as being executed for Cloud Service deployments, most of the use cases that OnDeploy Scripts would be useful for would be considered as CS anti-patterns. Creating this issue to track the work for marking OnDeploy Scripts as incompatible for Cloud Service and discussing providing an alternative solution that in CS compatible in the future.
@HitmanInWis @davidjgonzalez @justinedelson @badvision @joerghoh @adamcin

Looping in @adamcin

Would it make sense to briefly summarize what is meant by "most of the use cases that OnDeploy Scripts would be used for fall under CS anti-patterns" in order to facilitate the discussion?  Mark Adamcin and I were literally discussing the other day whether On-Deploy Scripts can still be a thing on AEMaaCS, but given the newness of the platform it might make sense to ensure we're all on the same page.

Hi Brett, the biggest anti-pattern is that it will try to update content during a code deployment and since every deployment is a "new" image some of things might not work as expected. For example, if I have a script that runs a query to find all nodes of RT1 and wants to change them to RT2.
I'd recommend using Sling Pipes for above use case in CS. Repoinit is another alternative to do the work that OnDeploy Scripts do.
HTH.

Yep, sounds like we're on the same page then.  One of the most common reasons we've used On-Deploy Scripts is to update node structures to match refactored code - one of the common examples being a refactored component with a new property naming structure.  Given that both the new instance being started up (with the new code) and the existing instance not yet spun down (with the old code) are pointing to the same data source during the blue/green deployment process, we really can't handle this case with a simple JCR content update since the update will break the currently running server, which is still running until the deploy completes, and will remain running (with the updated content that breaks it) if the deployment fails.

Is there a period of time where both the newly spinning up servers (new code) and the old servers (old code) are serving end users at the same time?  Or is it a clean 100% cut from all traffic going to old servers to all traffic going to new servers?

AFAIK, it's a clean 100% cutover. @justinedelson @davidjgonzalez can correct if needed.

are we ok marking it as incompatible for now and maybe figure out if we want to update it for a future release later?

probably the safest bet
Throwing a (potentially bad) idea out there.  If there is truly a 100% cutover (no period of time where both new/old servers are serving users) could we somehow trigger the jobs to run at the point of cutover?  Maybe not a "great" solution, but in an imperfect world it might be fine for many use cases.

Seeing these questions and responses, then what is a recommended approach for updating content? Because just saying this framework wont work doesn't make the usecase invalid? The content might still need to change resource type, so for me OnDeploy Scripts still feel valid?

On 5 Jun 2020, at 18:37, Brett Birschbach<EMAIL_ADDRESS>wrote:
probably the safest bet
Throwing a (potentially bad) idea out there. If there is truly a 100% cutover (no period of time where both new/old servers are serving users) could we somehow trigger the jobs to run at the point of cutover? Maybe not a "great" solution, but in an imperfect world it might be fine for many use cases.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/2324#issuecomment-639617507, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF42TWDBHQKYFKWV3MDKDLRVENN3ANCNFSM4NTBRIRA.

@royteeuwen we should use Sling Pipes for updating content.

How does this change anything? on deploy scripts can also use sling pipes. sling pipes is just another framework to update content based on jcr queries etc

On 5 Jun 2020, at 18:59, kaushalmall<EMAIL_ADDRESS>wrote:
@royteeuwen https://github.com/royteeuwen we should use Sling Pipes for updating content.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/2324#issuecomment-639631880, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF42TUFVGG6XAYM32LM2Y3RVEQA5ANCNFSM4NTBRIRA.

The goal is to not change content as part of the code deployment, Sling Pipes are used on the environment by calling the end point via cURL or similar and not as part of the code deployment. There are also timeouts set in the build image step for CS deployments, if your OnDeploy scripts takes a long time, it will break the build.

I believe the suggested approach would be to use a resource decorator to wrap from an old component model to a new one. This can be in the interim until you can execute a sling pipe to update existing content (or perhaps even use your decorator to trigger you sling pipe asynchronously, you can avoid having to remember to call the sling pipe via curl)

As @shsteimer notes, the suggested approach to perform "(otherwise) breaking content changes" is:
0a) [CODE] Code handles "old" content structure
0b) [CONTENT] Content is using "old" structure

[CODE] Update code to handle BOTH the old content and new content structures and deploy.

Now, the running code handles BOTH old and new, but is running against the "old" content structure.

[CONTENT] Update the old content structure to the new structure (how this happens isn't important for this discussion)
[CODE] If needed, remove the old content support from the code, since all content should be transformed into the "new" structure.

... @shsteimer RD being an example of this high-level approach

created https://github.com/Adobe-Consulting-Services/adobe-consulting-services.github.io/pull/196

Taking that approach @davidjgonzalez means that On-Deploy Scripts could still be used for Step 2, right?  That's assuming it is done in a second release - it needs to be done in a release where the code to support both old and new format is already deployed on the "running" server.

Thought of a new idea today.  Could on-deploy scripts continue to work in Cloud Service if they were triggered to run by a content package?  My understanding is that content packages are installed at the point of traffic cut-over from blue to green in the deployment, meaning that code has already fully completed deployment and the server is fully ready to go.
Current Impl: On-Deploy Scripts run based on presence in code and absence of a status node under /var.
New, Cloud-compatible Impl: On-Deploy Scripts run based on presence in code and presence of a status node under /var where the status is "ready".
As long as developers follow the principal of both content formats (pre-script and post-script) working until a subsequent release, this should work.
And for those that want to run fast and loose (and dont mind the site having errors for a minute or two) they could avoid that precaution and the site will be back in order once the content package installs the status node and the script runs.  Obviously not recommended though :).

@HitmanInWis not sure if this is still anti-pattern. I know for a fact that the usage of /var is being frowned upon now, especially if you are going to replicate that path, but adding code execution as part of the mutable content might be a no no as well. @davidjgonzalez thoughts? maybe Dominik would know, but, I don't know his github handle to tag.


Add collaborators to this repo

Comment below to be added as a collaborator
We will all be using this repository today. Even though it's public right now, you will not be able to make changes until you're given the correct permissions. We've automated this process via the GitHub API. Once you comment, we will add you as a collaborator.
You'll start to receive a lot of emails. (❗) You can slow these down immediately by clicking the Unwatch button at the top of the page and selecting either the Participating and @mentions or Ignore option.

Hello! 👋

Greetings

Good afternoon!

Hi! This is Luz A joining github training today. Thanks Fred.

good afternnon!

Good day!

hi there

Hello

Hello

Hello

Hello

dingerpk57


Bacon.RELEASE artifacts

Following artifacts/apps need to be released as part of Bacon GA release train.

[x] spring-cloud-stream-app-maven-plugin - 1.2.4.RELEASE
[x] spring-cloud-app-starter-metadata-maven-plugin 1.0.0.RELEASE
[x] app starters core - 1.2.0.RELEASE
[x] aggregator-processor - 1.0.0.RELEASE
[x] aggregate-counter-sink - 1.2.0.RELEASE
[x] bridge-processor - 1.2.0.RELEASE
[x] cassandra-sink - 1.2.0.RELEASE
[x] counter-sink - 1.2.0.RELEASE
[x] field-value-counter-sink - 1.2.0.RELEASE
[x] file-source  - 1.2.0.RELEASE
[x] file-sink  - 1.2.0.RELEASE
[x] filter-processor - 1.2.0.RELEASE
[x] ftp-source - 1.2.0.RELEASE
[x] ftp-sink - 1.2.0.RELEASE
[x] gemfire-source  - 1.2.0.RELEASE
[x] gemfire-sink  - 1.2.0.RELEASE
[x] gemfire-cq-source - 1.2.0.RELEASE
[x] gpfdist-sink - 1.2.0.RELEASE
[x] groovy-filter-processor - 1.2.0.RELEASE
[x] groovy-transform-processor - 1.2.0.RELEASE
[x] header-enricher-processor - 1.0.0.RELEASE
[x] hdfs-sink - 1.2.0.RELEASE
[x] hdfs-dataset-sink - 1.2.0.RELEASE
[x] http-source  - 1.2.0.RELEASE
[x] httpclient-processor - 1.2.0.RELEASE
[x] jdbc-source  - 1.2.0.RELEASE
[x] jdbc-sink  - 1.2.0.RELEASE
[x] load-generator-source - 1.2.0.RELEASE
[x] loggregator-source - 1.2.0.RELEASE
[x] log-sink - 1.2.0.RELEASE
[x] mail-source - 1.2.0.RELEASE
[x] mongodb-source - 1.2.0.RELEASE
[x] mongodb-sink - 1.2.0.RELEASE
[x] pgcopy-sink  - 1.2.0.RELEASE
[x] jms-source  - 1.2.0.RELEASE
[x] pmml-processor - 1.2.0.RELEASE
[x] rabbit-source  - 1.2.0.RELEASE
[x] rabbit-sink  - 1.2.0.RELEASE
[x] redis-pubsub-sink - 1.2.0.RELEASE
[x] router-sink - 1.2.0.RELEASE
[x] s3-source  - 1.2.0.RELEASE
[x] s3-sink  - 1.2.0.RELEASE
[x] scriptable-transform-processor - 1.2.0.RELEASE
[x] sftp-source - 1.2.0.RELEASE
[x] sftp-sink - 1.2.0.RELEASE
[x] splitter-processor - 1.2.0.RELEASE
[x] syslog-source   - 1.2.0.RELEASE
[x] task-launcher-cloudfoundry-sink - 1.2.0.RELEASE
[x] task-launcher-local-sink - 1.2.0.RELEASE
[x] task-launcher-yarn-sink - 1.2.0.RELEASE
[x] tasklaunchrequest-transform-processor - 1.2.0.RELEASE
[x] tcp-source   - 1.2.0.RELEASE
[x] tcp-sink   - 1.2.0.RELEASE
[x] tcp-client-source    - 1.2.0.RELEASE
[x] tcp-client-processor    - 1.2.0.RELEASE
[x] throughput-sink - 1.2.0.RELEASE
[x] time-source - 1.2.0.RELEASE
[x] transform-processor   - 1.2.0.RELEASE
[x] trigger-source   - 1.2.0.RELEASE
[x] triggertask-source  - 1.2.0.RELEASE
[x] twitterstream-source  - 1.2.0.RELEASE
[x] websocket-sink - 1.2.0.RELEASE
[x] app starters release - Bacon.RELEASE

All tasks are completed. Here is the release info: https://github.com/spring-cloud-stream-app-starters/app-starters-release/releases/tag/vBacon.RELEASE


Refactor StringValidator class

Improves readability of isNumeric() and isAlphanumeric().
isAlphanumeric() was not totally clear in it's functionality from the code and the minimal impact made by the 'optimisation' of this method probably doesn't warrant that. Human readable code is arguably better here.

Great! Totally agree! Thanks @ed-george!


[Azure] Add retries for Azure client POST

Azure client today doesn't implement any retries for POST requests. Azure GET has retry functionality for ServiceUnavailable errors.  When working with bigger repos, we see (transient) ServiceUnavailable more often for POST requests. This PR adds retries for the standard 500, 502, and 503 errors.

Makes sense, thanks for this 👍

Hi @jurre ,I have pushed another commit. Not sure why all the checks are in pending for a long time. Could you please approve the workflows to trigger the checks.

Hi @jurre @brrygrdn @xlgmokha Can you help review this? Thanks! ,I have pushed another commit. Not sure why all the checks are in pending for a long time. Could you please approve the workflows to trigger the checks?

Tagging @feelepxyz for visibility

Failure in running Nuget tests step. It seems like some other issue, as our code changes will not affect any of the NuGet tests.
@feelepxyz @jurre @brrygrdn @xlgmokha

@AlekhyaYalla a rebase should fix the failing test

Rebased this branch alekhyayalla/retry_azure_post_request with dependabot-core main branch


VSTS | .NET Core Task | Custom command should support feed authentication

I'm trying to run dotnet add via the custom command option of the .NET Core task, however this then fails if the package to add is in a VSTS feed since this custom command option does not support feed authentication. Does it make sense to add support for that?

@sachinma sure. something we're interested in, but not coming in the next few sprints. We're first working on bringing Credential Provider support to dotnet (which gives us the hooks we need to do auth well in the build tasks)

Any progress on this? I need to install a .Net Core Global Tool from my private Azure Artifacts feed as part of a release pipeline, I tried using the custom command to do this, but unlike the restore / push commands, it doesn't appear to support access to the Azure Artifacts feeds? If not, can someone suggest a workaround?

Closing this as WF. In the upcoming quarter, we'll be moving away from the full-featured Artifacts-related tasks (which have many issues like this because they combine authentication with the command you're trying to run) and recommending calling dotnet directly. See the design here for more details.


Add scale BrazilianDuration

see discussion on PR for BrazilianCrux:

https://github.com/OpenBeta/sandbag/pull/158/files#r1388446690
https://github.com/OpenBeta/sandbag/pull/158/files#r1388568954
https://www.cap.com.br/post/sistema-brasileiro-de-graduação-de-vias-de-escalada

This is a new type of scale, so will require some work to identify other possible duration scales and the relations between them.
Related scales:

NCCS commitment grade

@enapupe, you may have opinions on the best name for this one too

Brazilian[Exposure/Duration/General]  sounds good to me! I think the only hard to name was BrazilianCrux 😅


⚠ Bofrost.be has degraded performance

In f245bee, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1377 ms

Resolved: Bofrost.be performance has improved in 7f11540.


Template Render

Please check below  formly JSON  template {{model['Application__c']['First_Name_J__c']}} not rendering.It shows as  text.How can we render this one.
{
"template": "

Employment Information: {{model['Application__c']['First_Name_J__c']}} {{Application__c.Last_Name_J__c}}
",
"className": "input-wrapper inline-section-header",
"data": {
"sectionType": "EP-header_J1"
},
"hideExpression": "!model['Application__c']['First_Joint_Applicant__c']"
}

Awesome, that is exactly what I want, thanks. It works, check here


issue#01: Base fragment implementation has an issue

The app keeps crushing due to  base fragment implementation: look into it

Issue fixed with commit  id : 9cd85a8. Good issue .


SenseCAP Watcher: 3D model available?

First of all, congratulations for making this repository public and releasing the SenseCAP Watcher hardware design under an Open Source license!
Following up to a question I asked on Seeed Studio Forum a few weeks ago, do you also plan to release the 3D models of the Watcher enclosure?
As I explained in my post, as part of our FREISA Robot-Dog project, we plan to design some additional 3D-printable adapters and fixtures for the SenseCAP Watcher - please refer to our post on Hackster for details.
It would be quite helpful if Seeed Studio could share the 3D model of the Watcher enclosure. Any common mechanical CAD 3D model (i.e. SolidWorks, IGES, STEP) could help a lot.
On the other hand, if you do not plan to release the 3D model just let us know.

Hello, SenseCAP Watcher is currently patent pending and we are unable to provide the full STEP file immediately. What kind of requirements do you have, maybe I can apply for a partial (e.g. appearance) STEP for you, and when we have everything ready, we will publish it in full.

https://github.com/Seeed-Studio/OSHW-SenseCAP-Watcher/blob/main/Hardware/SenseCAP_Watcher-3D-Shell_v1.stp


TAJO-1522 NPE making stage history before task scheduler is initialized

trivial

+1
It is possible situation when it killed or failed.
Thanks


Improved SCP activation error handling, and some typo fixes.

Shows a single MessageBox instead of two, with combined messaging.
Adds a helpful user suggestion that should solve this error for most people.
Exits cleanly (non-zero) afterwards, since the error is not recoverable.
Fix "XBox" capitalization typos.

Thanks for the user friendly messagebox, should help some people out who does not know how to setup XKM correctly. Now if you could take a crack at the mouse engines ;)
If you do take a crack at it I appologise for the code it's mostly everywhere in that file, it's mostly a experiment / botch ontop of a notch ontop of a botch.


Critical effect for Sword weapons shows wrong condition

The critical effect for Sword-type weapons says

The target is made off-balance by your attack, becoming flat-footed until the start of your next turn.

https://2e.aonprd.com/WeaponGroups.aspx?ID=15
In Foundry, however, the critical effect shows the Hidden condition instead:

This is due to Monk's Enhanced Journals.


Add getter methods.

Add getter methods like
boolean isPaused()
boolean isPlaying()
Thanks

Its been 3 months already, where are you Mr. Developer.

Hello?


Update UserGuide.md

Add purpose and add tip for new users in the user guide.

Codecov Report

Merging #120 (5b96ad4) into master (6f5bc5f) will decrease coverage by 2.22%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #120      +/-   ##
============================================
- Coverage     65.56%   63.33%   -2.23%
  Complexity      459      459
============================================
  Files            84       88       +4
  Lines          1661     1721      +60
  Branches        176      186      +10
============================================
+ Hits           1089     1090       +1
- Misses          501      560      +59
  Partials         71       71

Impacted Files
Coverage Δ

src/main/java/seedu/address/model/person/Name.java
72.72% <0.00%> (-7.28%)
:arrow_down:

src/main/java/seedu/address/model/Model.java
100.00% <0.00%> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/HustleBook.java
76.19% <0.00%> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
88.67% <0.00%> (ø)

...n/java/seedu/address/model/person/MeetingTime.java
72.72% <0.00%> (ø)

...java/seedu/address/logic/commands/SortCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/MeetCommandParser.java
0.00% <0.00%> (ø)

...model/person/comparators/PersonNameComparator.java
0.00% <0.00%> (ø)

...model/person/comparators/PersonFlagComparator.java
0.00% <0.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5bc5f...5b96ad4. Read the comment docs.


Code release

@chenfengxu714 when can we expect the code to be released , tentative time ?? How similar is the code base with squeezeseg2

@chenfengxu714 when can we expect the code to be released , tentative time ?? How similar is the code base with squeezeseg2

Thanks for your interest, we will release the code in one week.


Adds blockquote tag to main component

Issue https://github.com/basemate/matestack-ui-core/issues/ #62: blockquote tag
Changes

Adds blockquotes to main components

Notes

No notes

Looking good @cameronnorman just minor things to fix and then I'll merge it!


Extension host keeps terminating

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Version: 1.66.0
Commit: e18005f0f1b33c29e81d732535d8c0e47cafb0b5
Date: 2022-04-02T14:00:30.308Z
Electron: 17.4.0
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.17.4-arch1-1
exten.txt
Steps to Reproduce:

Run code - edit files, wait ...

This crash is most likely caused by one of your installed ectensions. All extensions execute together on a single nodejs process, so in order to narrow down the possible problematic extension, please try the following:

run F1 > Help: Start Extension Bisect
(this will restart VS Code with half of your extensions disabled)
try to do the steps which reproduce the problem
if the problem reproduces, click "This is bad" (this narrows down the problematic extension to the half which was enabled)
if the problem does not reproduce, click "Good now" (this narrows down the problematic extension to the half which was disabled)
these steps will repeat until the problematic extension is found

initial
step
final


Mutations cannot define resolvers

When I am using this library in latest graphql, I can see the below error
CreateusersValuesInput.userId field type has a resolve property, but Input Types cannot define resolvers.
at invariant (/home/michael/revisioner-graphql/node_modules/graphql/jsutils/invariant.js:19:11)

but this problem can be eliminated (with possible problems) by falling back to<EMAIL_ADDRESS>I believe this is due to a breaking API change, how do you guys think of it

Please provide some code to reproduce this error.

I am also experiencing this now with:
    "graphql": "^0.11.7",

Here are my logs:
Unhandled rejection Error: createUserInput.id field type has a resolve property, but Input Types cannot define resolvers.
    at invariant (/Users/glavin/Development/HealthForms/packages/api/node_modules/graphql/jsutils/invariant.js:18:11)
    at /Users/glavin/Development/HealthForms/packages/api/node_modules/graphql/type/definition.js:698:58
    at Array.forEach (native)
    at GraphQLInputObjectType._defineFieldMap (/Users/glavin/Development/HealthForms/packages/api/node_modules/graphql/type/definition.js:692:16)
    at GraphQLInputObjectType.getFields (/Users/glavin/Development/HealthForms/packages/api/node_modules/graphql/type/definition.js:681:49)
    at typeMapReducer (/Users/glavin/Development/HealthForms/packages/api/node_modules/graphql/type/schema.js:223:26)
    at typeMapReducer (/Users/glavin/Development/HealthForms/packages/api/node_modules/graphql/type/schema.js:189:12)
    at Array.reduce (native)
    at /Users/glavin/Development/HealthForms/packages/api/node_modules/graphql/type/schema.js:216:36
    at Array.forEach (native)
    at typeMapReducer (/Users/glavin/Development/HealthForms/packages/api/node_modules/graphql/type/schema.js:209:27)
    at Array.reduce (native)
    at new GraphQLSchema (/Users/glavin/Development/HealthForms/packages/api/node_modules/graphql/type/schema.js:97:34)
    at Object.getSchema (/Users/glavin/Development/HealthForms/packages/api/node_modules/graphql-sequelize-crud/lib/index.js:887:10)
    at /Users/glavin/Development/HealthForms/packages/api/dist/index.js:116:43
    at tryCatcher (/Users/glavin/Development/HealthForms/packages/api/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/Users/glavin/Development/HealthForms/packages/api/node_modules/bluebird/js/release/promise.js:512:31)
    at Promise._settlePromise (/Users/glavin/Development/HealthForms/packages/api/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromise0 (/Users/glavin/Development/HealthForms/packages/api/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/Users/glavin/Development/HealthForms/packages/api/node_modules/bluebird/js/release/promise.js:693:18)
    at Async._drainQueue (/Users/glavin/Development/HealthForms/packages/api/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/Users/glavin/Development/HealthForms/packages/api/node_modules/bluebird/js/release/async.js:143:10)

Duplicate of https://github.com/Glavin001/graphql-sequelize-crud/issues/19

Published a big new release, v0.4.2! https://github.com/Glavin001/graphql-sequelize-crud/releases/tag/v0.4.2


dev at deploy data-import:   deleted territory triggers "missing id" messages

When territory is created and deleted,  improper "missing id" alter messages are triggered.
(When just older existing territory is deleted, this is not happening)
See gif

.

It's on BE @jancimertel will solve it.


Suppress Lando crash question

TravisCI waits 10 minutes :(

@acobster Still stalling :(
https://docs.lando.dev/help/data.html#tl-dr
Please advise.

I think this need to be in the global config: config.yml

I think we should just prioritize #119. Lando-in-Travis was incidental complexity to get Cypress working, and we won't need that if we get WP unit tests (which are really integration tests) working. The e2e test suite was always a maintenance pain and run an order of magnitude slower.


SaveConfigCallback: Race condition with ddp.

🐛 Bug

Please reproduce using the BoringModel
While running: pl_examples/basic_examples/autoencoder.py with
python pl_examples/basic_examples/autoencoder.py --trainer.accelerator="ddp" --trainer.gpus=2

It failed there as the config file didn't exist.
https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/utilities/cli.py#L100
  File "/home/thomas/pytorch-lightning/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 165, in start_training
    self._results = trainer.run_stage()
  File "/home/thomas/pytorch-lightning/pytorch_lightning/trainer/trainer.py", line 898, in run_stage
    return self._run_train()
  File "/home/thomas/pytorch-lightning/pytorch_lightning/trainer/trainer.py", line 947, in _run_train
    self.fit_loop.run()
  File "/home/thomas/pytorch-lightning/pytorch_lightning/loops/base.py", line 82, in run
    self.on_run_start(*args, **kwargs)
  File "/home/thomas/pytorch-lightning/pytorch_lightning/loops/fit_loop.py", line 173, in on_run_start
    self.trainer.call_hook("on_train_start")
  File "/home/thomas/pytorch-lightning/pytorch_lightning/trainer/trainer.py", line 1246, in call_hook
    trainer_hook(*args, **kwargs)
  File "/home/thomas/pytorch-lightning/pytorch_lightning/trainer/callback_hook.py", line 152, in on_train_start
    callback.on_train_start(self, self.lightning_module)
  File "/home/thomas/pytorch-lightning/pytorch_lightning/utilities/cli.py", line 102, in on_train_start
    f'{self.__class__.__name__} expected {config_path} to not exist. '

To Reproduce
Use following BoringModel and post here

Expected behavior

Environment
Note: Bugs with code are solved faster ! Colab Notebook should be made public !

IDE: Please, use our python bug_report_model.py template.

Colab Notebook: Please copy and paste the output from our environment collection script (or fill out the checklist below manually).

You can get the script and run it with:
wget https://raw.githubusercontent.com/PyTorchLightning/pytorch-lightning/master/tests/collect_env_details.py
# For security purposes, please check the contents of collect_env_details.py before running it.
python collect_env_details.py

PyTorch Version (e.g., 1.0):
OS (e.g., Linux):
How you installed PyTorch (conda, pip, source):
Build command you used (if compiling from source):
Python version:
CUDA/cuDNN version:
GPU models and configuration:
Any other relevant information:

Additional context

It failed there as the config file didn't exist.

The error is saying "expected to NOT exist" so the file does exist.
This is most likely because a previous run created the config file and by default, the CLI raises this error to avoid overwriting it.

Hey @carmocca,
Interesting, I believe this happen on my first run, but happen due 2 processes running there. Need to be replicated.
However, I believe the error message should be clearer there if the intention is to avoid overwriting it.
Best,
T.C

However, I believe the error message should be clearer there if the intention is to avoid overwriting it.

Done in #8059


python3Packages.importlib-resources: 5.2.2 -> 5.4.0

Motivation for this change
Update to latest upstream release 5.4.0
Change log: https://github.com/python/importlib_resources/blob/main/CHANGES.rst#v540
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build python38Packages.importlib-resources python39Packages.importlib-resources

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 143909 run on x86_64-linux 1

2 packages marked as broken and skipped:

python38Packages.mlflow
python38Packages.optuna

8 packages failed to build and already failed to build on hydra master:

mailman: log was empty
paperless-ng: log was empty
python38Packages.mailman: log was empty
python38Packages.mailman-hyperkitty: log was empty
python38Packages.mayavi: log was empty
python39Packages.mailman: log was empty
python39Packages.mailman-hyperkitty: log was empty
python39Packages.mayavi: log was empty

1 package failed to build and are new build failure:

python38Packages.hydra: log was empty

40 packages built:

apache-airflow (python39Packages.apache-airflow)
matrix-synapse
matrix-synapse-plugins.matrix-synapse-mjolnir-antispam
mycli
ocrmypdf (python39Packages.ocrmypdf)
python38Packages.alembic
python38Packages.apache-airflow
python38Packages.apptools
python38Packages.asdf
python38Packages.batchspawner
python38Packages.bedup
python38Packages.desktop-notifier
python38Packages.dockerspawner
python38Packages.flask_migrate
python38Packages.glasgow
python38Packages.ihatemoney
python38Packages.importlib-resources
python38Packages.jupyterhub
python38Packages.jupyterhub-ldapauthenticator
python38Packages.jupyterhub-systemdspawner
python38Packages.jupyterhub-tmpauthenticator
python38Packages.maestral
python38Packages.nmigen
python38Packages.nmigen-boards
python38Packages.nmigen-soc
python38Packages.oauthenticator
python38Packages.ocrmypdf
python38Packages.oslo-db
python38Packages.pyface
python38Packages.pysaml2
python38Packages.scikit-hep-testdata
python38Packages.subunit2sql
python38Packages.sunpy
python38Packages.traitsui
python38Packages.uproot
python39Packages.apptools
python39Packages.importlib-resources
python39Packages.pyface
python39Packages.pysaml2
python39Packages.traitsui


new release

The leaderboard section is a lot of new features, which did work for my playthrough good. If you waited for me to confirm that before a new release then here I go - it's working, thank you a lot! :)

@benreid24 can you please review/merge https://github.com/benreid24/Stellaru/pull/132 into the new release.
Sadly the only way to setup Stellaru for me (or my friends) is via Ubuntu, checkout that PR, build and run locally. That weirdly doesn't work on windows because it can't find and/or follow new saves (imho fails to watch the folder, or the correct folder, but idk). That leaves out windows users unable to use new leaderboards.
I'm happy to help you with maintaining the repo and releases if you wish. But in that case readme only lacks information how to create and publish a release.

Sorry for the delay, been real busy with life, work, and other projects. Just cut a release!


Move timeline hovers to the side

Fixes #232487
Before:

After - aligns with SCM view and makes hovers with links easier to hover:

Aligning the hover was one aspect, so would be good to use whatever we do there, if not already done.

I agree, but this comes back to the setupManagedHover being very difficult to maintain as it was built totally separate from my code and then had a bunch of people add stuff to it. I don't even understand how some of it works.
I think this is ready to be merged as it's an improvement. I'm planning on continuing to look at overall hover improvements today.


refactor: separate cli from index.js

Use a separate cli.js, should be easier to maintain.

@keithamus rebased.

:tada: This PR is included in version 1.37.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Adding Spotify link buttons to profile and Bitbucket/Twitch link fix

Adding Spotify link/unlink button to profile
Fix for Spotify linking error when user has no profile picture
Fixing Bitbucket/Twitch link & unlink

Thanks. 👍  @mrcb123


Calling function repeatedly in fragment shader causes Godot Engine to crash during shader compilation

Godot version:
3.1.1 win64 (Classical)
OS/device including version:
Windows 10 Pro, Intel i7-4790K, integrated GPU only (Intel HD Graphics 4600), driver igdkmd64.sys version <IP_ADDRESS>58
Issue description:
Working on a large fragment shader (GLES2), I found that inserting a clearly bug-free line inside a certain function and then trying to save or play would cause Godot Engine to crash, I assume during shader compilation (at least, before anything was displayed).  Any extra line would cause a crash, such as adding 0.0 to an already-defined float.  What distinguished this function from others is that it was called frequently, about 150 times throughout the shader.  I have distilled this problem to its essence in the attached minimal reproduction project.  The shader for the ColorRect in the project defines a simple (if somewhat silly) function and then that function is called repeatedly in fragment().  There are 3,000 calls and another 1,000 commented out.  With 3,000 calls, save/play work as expected.  When uncommenting the additional 1,000 calls, making 4,000 total, save/play cause Godot Engine to crash.  The calls are all written explicitly, rather than in a loop, since a loop that repeatedly calls the function once does not seem to cause a crash.
Windows Task Manager does not show any difference in activity between the 3,000 and 4,000 cases -- no memory or GPU memory spike for 4,000, for example.  Godot does not show any errors in the console before crashing and does not leave any log.  I do not know how to do a stack trace to try to figure out what is going on, but it seems that some limit is being reached during shader compilation.  The critical number of function calls -- the smallest number causing the crash -- seems to depend on the complexity of the function.  When I add more arithmetic operations inside the function, for example, the critical number decreases.  In my real shader, the critical number is much lower because the function is more complex than in the minimal reproduction project.
Any help would be greatly appreciated since I have not found a way to avoid calling my desired function more than its critical number of times or to put the calls in a loop. In other words, at present, I cannot use my desired function in Godot because of these crashes.
Steps to reproduce:
Open the attached minimal reproduction project.  There is a ColorRect with a shader material -- open the editor for the shader.  In fragment(), scroll down until you see the commented-out 1,000 function calls, uncomment them and save or play.  When I do this, Godot Engine crashes.  In case the critical number is machine-dependent, and 4,000 works on your machine when testing, try increasing the number of calls by copying and pasting until you get a crash.
Minimal reproduction project:
Godot Bug Report 3.zip

This sounds like you are hitting the maximum instruction count on your hardware. This is a hardware dependent limit and has nothing to do with Godot. For example, I am able to run your test case fine on my Celeron N2840.
Using for loops is a much better approach than copying the same function 3000 times. I'll bet your hardware will be able to run that function in a loop 3000 times with no problem. In general loops like that are slower (the compiler will manually unroll the loop for you if small enough) but in this case its necessary.

Thanks very much for your reply.  This seems like a plausible explanation.  Obviously in my real code I did not copy the same function when it could have simply been in a loop -- instead, the function is called in many separate places in the code.  Anyway, regarding Godot, is there a way to see how many instructions are used in the shader when it compiles?  That would be helpful as a guide to know how effective my attempts are at reducing instruction count.  Also, if Godot crashes because a shader exceeded the instruction count limit, is that recorded in a log anywhere?  Knowing the reason for the crash would save some debugging time.

Unfortunately, no. It would be very helpful to count instructions, i think Unreal engine does that in its shader editor. And due to the nature of the crash its difficult for godot to do anything at all. We can't tell what your instruction limit will be in advance. And the crash is on your graphics driver, not in Godot anywhere. So Godot doesnt really even know why things are crashing.

Thanks again.  I will open a separate issue suggesting a visible instruction count.  It seems Unity does that, not sure about Unreal.


After upgrading to (preview) NixOS 18.03, nix-repl fails

Issue description
I upgrade to the current preview version of NixOS 18.03 and  nix-repl stopped working with the error:

error: Nix database directory ‘/nix/var/nix/db’ is not writable: Permission denied

I've found a related issue #5713 about Zsh, so i tried:
export NIX_REMOTE=daemon

and indeed this fixed nix-repl.
I verified that the variable NIX_REMOTE is not defined in my user environment if i boot into 18.03pre, but it is defined if i boot into 17.09. (Currently i know nothing about what it does and how.)
I am using Bash.
Steps to reproduce
In Bash:
nix-repl
echo $NIX_REMOTE
export NIX_REMOTE=daemon
nix-repl

Technical details
§ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 4.14.29, NixOS, 18.03pre131587.b6ddb9913f2 (Impala)`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.0`
 - channels(alexey): `"nixos-17.03-17.03.1949.78e9665b48f, nixos-17.09-17.09.3205.12512f25e9e"`
 - channels(root): `"nixos-18.03pre131587.b6ddb9913f2"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`

This is expected and is due to upgrading Nix to 2.0 -- the NIX_REMOTE variable is no longer needed.
Nix also now has a repl builtin-- you can access it with nix repl.
Since nix-repl was merged into Nix proper, I'm not sure there's reason to worry about the old nix-repl?

Thanks for the explanation.  Indeed, nix repl works for me.  So, are you saying that nix-repl is not expected to work anymore?  If so, this can be closed.

This confused me too. Currently nix-repl has an explicit dependency on Nix 1:
 nix-repl = callPackage ../tools/package-management/nix-repl { nix = nix1; };
so it is unlikely to work after upgrading to Nix 2.
We should consider dropping the nix-repl package altogether.

@dtzWill Is the documentation out of date here? It still says here that in a multi-user install we're supposed to set that variable.

nix pills no longer include nix-repl examples afaik.


🐛 Fix IMAGE_OS case

Since IMAGE_OS changed to lowercase in Dev_Env in this PR, updates in capm3 hack file are need else it will break the test locally.

/test-v1b1-ubuntu-integration

/assign @fmuyassarov

/cherry-pick release-0.5


Dummy titles (Mail Bart Havermans 22/02/2022)

Tests are grouped under titles. Some generic tests are placed under a dummy title (title without a label). How do we need to send this in FHIR

Now as text a ‘?’ is send. What are options to use an empty title?

To tackle empty titles, we thoroughly use the "hasMember" tag of the Observation member and the Result Reference tag of the DiagnosticReport member to create a logical structure.
Easiest is to explain this with a couple of examples.
Example 1: a test result as the first line of a report, without a subtitle above the test result
For this, we refer to the test (and the following subtitles after this test) at the level of the DiagnosticReport:

"result": [
{                "reference": "Observation/Observation.<IP_ADDRESS>"            },
{                "reference": "Observation/Observation.<IP_ADDRESS>"            },
{                "reference": "Observation/Observation.<IP_ADDRESS>"            },
{                "reference": "Observation/Observation.<IP_ADDRESS>"            },
{                "reference": "Observation/Observation.<IP_ADDRESS>"            },
{                "reference": "Observation/Observation.<IP_ADDRESS>"            },
{                "reference": "Observation/Observation.<IP_ADDRESS>"            }
]

Observation.<IP_ADDRESS> is the test without a title, the other Observations are main titles.
Example 2: a test result with an empty (sub)title
Here, we use the hasMember tag to correctly refer to the position of the test in the tree structure.
"hasMember": [
            {                "reference": "Observation/Observation.<IP_ADDRESS>"            },
            {                "reference": "Observation/Observation.<IP_ADDRESS>"            },
            {                "reference": "Observation/Observation.<IP_ADDRESS>"            },
            {                "reference": "Observation/Observation.<IP_ADDRESS>"            },
            {                "reference": "Observation/Observation.<IP_ADDRESS>"            },
            {                "reference": "Observation/Observation.<IP_ADDRESS>"            },
            {                "reference": "Observation/Observation.<IP_ADDRESS>"            },
            {                "reference": "Observation/Observation.<IP_ADDRESS>"            },
            {                "reference": "Observation/Observation.<IP_ADDRESS>"            },
            {                "reference": "Observation/Observation.<IP_ADDRESS>"            },
            {                "reference": "Observation/Observation.<IP_ADDRESS>"            }
        ]

This "hasMember" refers from the main title "Hematology". Observations <IP_ADDRESS> through <IP_ADDRESS> are tests directly under the main title "Hematology". Observations <IP_ADDRESS> and <IP_ADDRESS> are subtitles (which each also have their own hasMembers).
Observations <IP_ADDRESS> and <IP_ADDRESS> are observatios underneath an empty subtitle, which means we already refer to them from this main title.
The question to ask with empty titles is always to check on which level the empty title should be, and then refer to the tests at that level.

Proposal: we put this in the guidance...


build: Assembles for last IntelliJ version

Successful installation on IntelliJ 223 branch number

Closes https://github.com/VKCOM/modulite/issues/3

The installation completed successfully, but some things do not work as requested in manual. But these are others issues.

The installation completed successfully, but some things do not work as requested in manual. But these are others issues.

Can you tell me what's not working right? 😰

Working only this

Cant create @internal class. Only test command available.

Havent restricted error.

@githubjeka, I checked on 2022.3 and it works for me.

I reset IDE to default setting. Reinstall this plugin. Did not help.
Can you show your compose.json?
{
  "autoload": {
    "psr-4": {
      "ModuleA\\": "src/ModuleA/",
      "ModuleB\\": "src/ModuleB/"
    }
  }
}

and it's normal or something is missing on my computer  ?

@githubjeka, please create a new issue so that we can discuss the problem with you. :)


Property DDS: Minor fixes for TS 5.1

This PR contains surgical fixes for 'property-changeset', 'property-properties', 'property-binder', and 'property-inspector-table' to unblock migration to the TypeScript 5 compiler.

/azp run Build - client packages

Thanks, @taylorsw04 !


Fix retrieve command when using dynamic pod name

What this PR does / why we need it:
The sonobuoy retrieve command currently uses a hard-coded pod name
when attempting to retrieve scan results.  This change uses the same
mechanism as sonobuoy status to look up the sonobuoy master pod by
label.
Which issue(s) this PR fixes

N/A

Special notes for your reviewer:
This is related to this PR that introduced the ability to use dynamic pod names:
https://github.com/heptio/sonobuoy/pull/787
Release note:
N/A
Signed-off-by: Richard Lander<EMAIL_ADDRESS>

@johnSchnake I discovered this morning that the dynamic pod name didn't work for sonobuoy retrieve.  It works for sonobuoy status.

Codecov Report

Merging #790 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
- Coverage   42.65%   42.64%   -0.02%
==========================================
  Files          71       71
  Lines        4192     4193       +1
==========================================
  Hits         1788     1788
- Misses       2297     2298       +1
  Partials      107      107

Impacted Files
Coverage Δ

pkg/client/retrieve.go
5.05% <0%> (-0.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc9e84b...9a24a9b. Read the comment docs.

xref #782


Added Icons

Added icons for Discord PTB, Discord Canary, Sublime Text, OBS Studio, Audacity, and Insomnia.

All icons are from https://simpleicons.org/

All icons are from https://simpleicons.org/

Hi, thank you for your work, I'll merge it soon, I will simply exclude your changes on the pywal colors file & those .DS_Store files.

Hi, thank you for your work, I'll merge it soon, I will simply exclude your changes on the pywal colors file & those .DS_Store files.


fixes a couple of bugs with sharding;

hi @pkdone, I've fixed a couple of bugs with the sharding  - sorry about all the changes - that's my auto formatter kicking in...

Hi mate as per slack can you re-submit using the project's existing style based on PEP 8 but with max line width = 100
eg. alias pycodestyle='pycodestyle --max-line-length=100'

ok, this should be better now

I don't understand the first change (removal of "$") and how it is working for you. Agg Fwk $type operator when provided a field path as the expression for its argument expects a "$" prefix to the field name.
See example from: https://docs.mongodb.com/manual/reference/operator/aggregation/type/
db.coll.aggregate([{
    $project: {
       a : { $type: "$a" }
    }
}])

Can you double check please?

I'm using MongoDB 5.0.3

it also works with the $ sign:

but for some reason it fails on the python script:

then if I change it:

works as expected

Hi Carlos. I'm still struggling to reproduce. I was using 5.0.2 locally but just upgraded to 5.0.5 and I have no change in behaviour I see for the agg pipeline for either mongos or pymongo.
Is your "card_number" field a string field. In which case running $type on a constant "card_number" will of course return a string because it is not returning te type of the card_number field it is returning the type of the string constant "card_number". I tested on sample_mflix.movies for fields title and year with and without $ prefix. With prefix, it returns string for "$titlte" and returns int for "$year". Without the $ prefix it always returns string because it isn't testing a field its looking at a string constant. Therefore you must always use $ prefix for $type to reference a field in a document.
I then build a very small test Python client to see if there is something specific to use of pymongo going on but again I saw behavior expected for both "$title" and "$year".
Here's my python test code which should be put ina file called "gettype.py" made executable and then run:
#!/usr/bin/python3
from pymongo import MongoClient
from pprint import pprint

connection = MongoClient("mongodb://localhost:27017")
db = connection["sample_mflix"]
field = "year"  # try: "title" (string) and "year" (int)

pipeline = [
    {"$limit": 1},
    {"$project": {
        "_id": 0,
        "type": {"$type": f"${field}"},
    }},
]

firstRecord = db["movies"].aggregate(pipeline).next()
pprint(firstRecord)

Can you do me a favour and try this python client in your env for both a text field and then for a number field and see what happens?
Thanks
Paul

Hi Paul,
it works fine for both:

Let's leave the PR for now and I'll show you when we're back next year!

Ok thanks yep let's catch up then. IN meantime I will make the other correction directly to main - thanks for that

As discussed the fix is more substantial which I am making to the code separately from this pull request. Thanks for catching the issue!


Datepicker's firstDay attribute doesn't work

Describe the error in 1 sentence
Datepicker's firstDay attribute doesn't work. I setted it in the $scope.firstDay and in the element firstDay="{{ firstDay }}", but it's doesn't work.

You can see in the documentation that I just pushed how first-day is set, like this: first-day="1".
Valid inputs are 0 (for sunday) or 1 (for monday).


Somehow trim/shift recordings

Maybe explore with #170

no, stick to the plan and use the Arrow of Noise

Enough for now


Add model and function to get the temperature offset of a device

Hey @flipkick , thanks for your contribution!
In order to merge your PR, it must be up-to-date with the main branch. So you must either rebase this PR on the latest main branch, or merge the main branch into your PR.


Feat/report on location

DONE:

[x] test properly in both systems (Android and iOS, the markers are sometimes keeping forever on the iOS map)
[x] check with the design team the cancel icon.
[x] disable onMapPress when pressing on the location marker.
[x] fix crash when press the report here button

This PR includes the request on my location feature adding a marker in the middle of the screen while you drag the map.
Bonus: the header will show the alert coordinates

Looks great!!!! Just one detail, now that we removed onMapPress there's no way to unselect an alert when clicking on the map.

That was on purpose so you won't lose your selected alert unless you click in the same again.

It’s not super clear, I wasn’t able to dismiss the selection 😪. Maybe a good solution is to add the remove button?

Button to cancel selection included!


[BEAM-1544] Java cross-JDK version tests on Jenkins

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify.
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Bring Java JDK versions test to Jenkins as postcommit test.
Currently we have four JDK versions configured on Beam Jenkins:

JDK 1.8 (latest)
JDK 1.7 (latest)
OpenJDK 7 (on Ubuntu only)
OpenJDK 8 (on Ubuntu only)

Since beam_PostCommit_Java_MavenInstall is running on JDK 1.8 (latest), this test will covers the rest of three JDK versions. The same as beam_PostCommit_Java_MavenInstall, it's triggered by merge and send notification to commits@ if build is failed.

Run Seed Job

+R: @jasonkuster @lukecwik

Coverage remained the same at 70.668% when pulling 836274d76bdc3142e5fde9aa526ab5171345b7db on markflyhigh:jdk-version-test into ce00d2466a9495f4eb262b5f7d2afec5788fcfe2 on apache:master.

Run Java JDK Version Test

PTAL @lukecwik

LGTM
@jasonkuster Did you want to review this as well?

LGTM


209 allow compiler to use protobuf transformer

Updating default asconfig to fit the revert of compiler.ts for the protobuf transformer

@julienbrs I don't see the point of this PR anymore.

Previously, we had implemented a custom approach for handling transformers that was compatible with our custom compiler.ts, by using "transformer" in asconfig.
However, the recent changes made to compiler.ts have been reverted to accommodate the more conventional  "transform" approach. So we now need to utilize "transform," which is the standard way to handle transformers.


Harden unwrapping logic for non-compliant files.

Cool! Thanks a lot, @samccone.

Oh I forgot: :dancer:


SSL RMI Binding

Tom Lagodzinski (Bug 63990):
In AWS when using Elastic IP for public IP mapping, it's not possible to use SSL RMI as setting java.rmi.server.hostname when using SSL RMI, it wants to bind to the provided address. This doesn't happen on non SSL setup, which allows remote jmeter master to manage EC2 based jmeter runners.
Seems to be caused in RMIServerSocketFactoryImpl by the createServerSocket override which also provides localAddress.
Security wise, it seems to not matter, as binding to a local address and reporting a remote one requires non standard manual configuration.
Log from binding when using SSL RMI:
Server failed to start: java.rmi.server.ExportException: Listen failed on port: 1099; nested exception is:
java.io.IOException: Could not bind /XXX.XXX.XXX.XXX using port 1099
An error occurred: Listen failed on port: 0; nested exception is:
java.io.IOException: Could not bind to /XXX.XXX.XXX.XXX using port 1099
With -Jserver.rmi.ssl.disable=true it works without a hitch, therefore marking it as regression.
OS: Linux

Hi Tom, I confirm the problem it always present into jmeter 5.5
The only workaround seems to use server.rmi.ssl.disable=true on both side.


Cannot create functions

This is my migration:
exports.up = (pgm) => {
  pgm.createFunction("set_created_at_block", [], {},
    ```
      if NEW._block_created_at is null then
         NEW._block_created_at := NEW._block_modified_at;
      end if;
      return new;
    ```
  )
}

This is the error I'm getting:
> Rolling back attempted migration ...
TypeError: "" is not a function
    at exports.up (<redacted>/database/migrations/1517527975870_create_created_at_function.js:3:7)
    at <redacted>/node_modules/node-pg-migrate/dist/migration.js:88:24
    at new Promise (<anonymous>)
    at Migration._apply (<redacted>/node_modules/node-pg-migrate/dist/migration.js:84:14)
    at Migration.applyUp (<redacted>/node_modules/node-pg-migrate/dist/migration.js:135:19)
    at <redacted>/node_modules/node-pg-migrate/dist/runner.js:196:55
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

Since I'm going to be using this in a trigger, I tried creating a trigger using its function creator optional definition, but get the same error.

Ignore this- my understanding of string templates was lacking...


Update actions/checkout action to v4

This PR contains the following updates:

Package
Type
Update
Change

actions/checkout
action
major
v3 -> v4

Release Notes

actions/checkout (actions/checkout)
v4
Compare Source

Add support for partial checkout filters

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 4.x releases. But if you manually upgrade to 4.x then Renovate will re-enable minor and patch updates automatically.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.


Add risk checks for add and edit doctor commands

Add risk field checks for add and edit doctor commands

Codecov Report

Merging #206 (0a37865) into master (d5a3ad5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #206      +/-   ##
============================================
+ Coverage     80.33%   80.36%   +0.02%
- Complexity      981      983       +2
============================================
  Files           146      146
  Lines          2828     2832       +4
  Branches        332      334       +2
============================================
+ Hits           2272     2276       +4
  Misses          478      478
  Partials         78       78

Impacted Files
Coverage Δ

...in/java/seedu/plannermd/commons/core/Messages.java
0.00% <ø> (ø)

...arser/addcommandparser/AddDoctorCommandParser.java
100.00% <100.00%> (ø)

...ser/editcommandparser/EditDoctorCommandParser.java
93.33% <100.00%> (+0.47%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a3ad5...0a37865. Read the comment docs.


[ENH] Smarter use of dataframe copying

Right now, we're copying entire dataframes to avoid mutating the original in a pyjanitor function. This of course can come with big computational costs depending on the size of the dataframe involved. We've talked about how to mitigate this problem a bit, and for now, we've been going with the "copy everything" option. The possibly unanswered question here, though, is what are we actually trying to preserve with the copy? In some cases, a pyjanitor function only acts on dataframe metadata, and not the data contained within. In such cases, protecting the data through a copy might not be entirely necessary.
I realized that df.copy() has a shallow copy action:
https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.copy.html
I think that there could be a good amount of cases in pyjanitor where what we really want to guarantee preservation of is the structure of the input dataframe. The default copy strategy we've been using unlinks the data between the function's input and output dataframes. Is that really important when you're cleaning the column names? .copy(deep=False) will result in both dataframes pointing to the same underlying data and avoid unnecessary copying.

Hi, I look to this repo for examples of how to use the pandas_flavor, and I've been reading your comments/posts about the inplace vs SQL query mentality. It's difficult to determine how/when to use inplace or create a copy and the behavior is inconsistent. Does pandas_flavor always require a copy/modifying the original dataframe? Is there a way to avoid this in order to save memory? I would simply like to do dataframe.drop_empty_rows() and affect the original dataframe.
import pandas_flavor

# Does not replace original dataframe
@pandas_flavor.register_dataframe_method
def drop_empty_rows(dataframe):
    return dataframe.dropna(axis=0, how='all')

# Should replace original dataframe, but doesn't in my tests.
@pandas_flavor.register_dataframe_method
def drop_empty_rows(dataframe):
    dataframe = dataframe.dropna(axis=0, how='all')
    return dataframe

# Should replace original dataframe -- untested.
@pandas_flavor.register_dataframe_method
def drop_empty_rows(dataframe):
    dataframe_processed = dataframe.copy()
    dataframe_processed = dataframe.dropna(axis=0, how='all')
    return dataframe_processed

@DOH-Manada thanks for pinging in! Indeed, we've gone back and forth on this matter for close to two years now.
There are some intricacies to worry about here. An explicit .copy() of a dataframe may result in badly behaved code w.r.t. memory usage, especially when users have a large dataframe. I think @zbarry wanted .copy() off by default because in his use cases, enforcing copying on all pyjanitor operations would result in pretty bad things.
I think over time, this next idea has crystallized more clearly for me. It starts with making pyjanitor use pandas-native .something() operations wherever possible. In doing so, we never end up with a situation where we use the selector syntax (df[selector]) to directly mutate the dataframe. The added benefit here is that we also end up leveraging all of pandas memory management capabilities, so we never have to worry about it. In some senses, it's the software developer in me reminding myself to heed Bill Gates' advice - to be strategically lazy :smile:.
So if I were in your position, the first code block would be how I would prefer that pyjanitor handles the implementation of drop_empty_rows.

As for your specific questions:

Does pandas_flavor always require a copy/modifying the original dataframe?

Not at all. pandas_flavor does one and only one thing: registering a function as a dataframe method. It doesn't care about how the internal implementation of a function looks.

Is there a way to avoid this in order to save memory?

As mentioned above, if we simply wrap pandas-native methods into higher-order functions/dataframe methods, then we take advantage of how pandas handles memory.

Finally, I think I did see a mistake in the code blocks - hope you don't mind me pointing them out here to discuss. I think the second example shouldn't replace the original dataframe because when we do df = df.dropna(), I think we're overwriting the original df reference with a new object. Definitely correct me if I'm wrong here.
Also, in the third example, I think you intended to do:
# Should replace original dataframe -- untested.
@pandas_flavor.register_dataframe_method
def drop_empty_rows(dataframe):
    dataframe_processed = dataframe.copy()
    dataframe_processed = dataframe_processed.dropna(axis=0, how='all')
    return dataframe_processed

Please let me know if this addressed your question! I'd also encourage you to try out some memory profiling tools to see how memory usage changes with different implementations. That would be the most definitive thing to check memory usage.

@ericmjl Thanks for the quick response. Yes, the third example had a typo. However, in my second example, my intention is to overwrite the original dataframe, which I believe is similar to pyjanitor's implementation.
    """  # noqa: E501
    nanrows = df.index[df.isna().all(axis=1)]
    df = df.drop(index=nanrows).reset_index(drop=True)

    nancols = df.columns[df.isna().all(axis=0)]
    df = df.drop(columns=nancols)

    return

Ultimately I expected dataframe.perform_some_action() to modifies the original dataframe inplace, but if that's not best practice, I'll simply do dataframe = dataframe.perform_some_action()


Re-edit USAGE.md

User Story

So that I can easily follow the user guide, as a data maintainer, I want a we well edited easy to follow USAGE.md.
Instead of the long multipart docuyment we have now. Now that we have added CLI commands we should consider reformatting this doc to make it easier to use. E.g. put CLI and Lambda examples next to each other and organise the page around typical workflow.
Acceptance Criteria

[ ] Given [a pre-condition], when [an event happens], then [an expected outcome occurs]
[ ] Given [a pre-condition], when [an event happens], then [an expected outcome occurs]

Additional context

Tasks

[ ] ...
[ ] ...

Definition of Ready

[ ] This story is ready to work on

[ ] Independent (story is independent of all other tasks)
[ ] Negotiable (team can decide how to design and implement)
[ ] Valuable (from a user perspective)
[ ] Estimate value applied (agreed by team)
[ ] Small (so as to fit within an iteration)
[ ] Testable (in principle, even if there isn't a test for it yet)
[ ] Environments are ready to meet definition of done
[ ] Resources required to implement will be ready
[ ] Everyone understands and agrees with the tasks to complete the story
[ ] Release value (e.g. Iteration 3) applied
[ ] Sprint value (e.g. Aug 1 - Aug 15) applied

Definition of Done

[ ] This story is done:

[ ] Acceptance criteria completed
[ ] Automated tests are passing
[ ] Code is peer reviewed and pushed to master
[ ] Deployed successfully to test environment
[ ] Checked against CODING guidelines
[ ] Relevant new tasks are added to backlog and communicated to the team
[ ] Important decisions recorded in the issue ticket
[ ] Readme/Changelog/Diagrams are updated
[ ] Product Owner has approved acceptance criteria as complete
[ ] Meets non-functional requirements:

[ ] Scalability (data): Can scale to 300TB of data and 100,000,000 files and ability to
increase 10% every year
[ ] Scability (users): Can scale to 100 concurrent users
[ ] Cost: Data can be stored at < 0.5 NZD per GB per year
[ ] Performance: A large dataset (500 GB and 50,000 files - e.g. Akl aerial imagery) can be
validated, imported and stored within 24 hours
[ ] Accessibility: Can be used from LINZ networks and the public internet
[ ] Availability: System available 24 hours a day and 7 days a week, this does not include
maintenance windows < 4 hours and does not include operational support
[ ] Recoverability: RPO of fully imported datasets < 4 hours, RTO of a single 3 TB dataset <
12 hours

CLI and Lambda examples are next to each other in the usage docs already.

Oh you already did this. Great. :) Much more readable now. Closing...


feat: release databend v0.1.5

cc @hantmac , could you write the release note for v0.1.5 if you are available?


feat: karpenter will now respect the --vnet-subnet-id set on the systempool during cluster create

Fixes #199
Description
This pr solves the issue linked above and allows karpenter to tap into a specifed custom vnet + subnet id.
How was this change tested?

ran make az-all with new custom vnet cluster create: ran some scale tests and validated the nics were connecting to the custom subnet specified.

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

Karpenter will now respect the `--vnet-subnet-id` set on the systempool during cluster create

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 2 (50.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.716%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/providers/instance/azure_client.go
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
35592

Relevant Lines:
36424

💛  - Coveralls

Here is another place where subnet id is used:
https://github.com/Azure/karpenter-provider-azure/blob/036940382eea285f9fb51ba8382cddcd2b0f7570/pkg/providers/imagefamily/bootstrap/aksbootstrap.go#L298
Now, I strongly suspect that on the node this affects only azure.json, and I can't think of why this would actually be needed. If this is indeed unused, it (quite possibly with other would be a prime candidate for removing from the contract. (This is very much related to contract discussion here https://github.com/Azure/AgentBaker/pull/4208#discussion_r1538390200, cc @lilypan26)

Here is another place where subnet id is used (currently hardcoded, would need to change):

Fixed this

As a result of moving most of the refactoring into this pr, the subnet per nodeclass pr became much smaller: https://github.com/Azure/karpenter-provider-azure/pull/242

BTW, where did the creation of cluster with custom subnet go? Or az-all-custom-subnet  (mentioned in description)?

I screwed up the rebase maybe idk where it went

Need to run make az-all-custom-vnet still


My game is not rendering properly on some computers.

Godot version
4.0 stable
System information
Windows 11, Vulkan, rx570, amd ryzen 5 2600
Issue description
I'm exporting my game in Godot and sending it to my friends. It works fine for me, but one of my friends who has an RX570 graphics card is not able to render the 3D part of the game properly.

Steps to reproduce
I don't think the problem is caused by my project. Same issue with any 3D export
Minimal reproduction project
N/A

Please provide more detailed information about the system of the computer where the issue happens, the system information on your computer isn't helpful if the error does not happen there.

Oh yes, I'm sorry, I've updated it now, you can take a look.

There isn't enough information here for us to help you. While the image does look janky, we don't know what it is supposed to look like, so visually we can't tell what is broken.
At minimum we need a description of what a working project is like and what exactly is broken. We also need to know what errors are being reported on the broken system. Finally we need an MRP so that interested contributors can try to reproduce and fix the bug.
Without the above, no one is going to help you

There isn't enough information here for us to help you. While the image does look janky, we don't know what it is supposed to look like, so visually we can't tell what is broken.
At minimum we need a description of what a working project is like and what exactly is broken. We also need to know what errors are being reported on the broken system. Finally we need an MRP so that interested contributors can try to reproduce and fix the bug.
Without the above, no one is going to help you

I added as much information as I could. Is it sufficient?

@Eneskp3441 Make sure your friend has their graphics card drivers updated.

My friend checked and confirmed that the graphics card drivers are up to date

@Eneskp3441 Make sure your friend has their graphics card drivers updated.

My friend checked and confirmed that the graphics card drivers are up to date

What Environment features do you have enabled in the project? The artifacts look like something caused by SSAO or SSIL. Try disabling it then exporting the project again.

What Environment features do you have enabled in the project? The artifacts look like something caused by SSAO or SSIL. Try disabling it then exporting the project again.

I have turned off both options, but there is no difference, the result is the same.

Thanks for the report! Consolidating in https://github.com/godotengine/godot/issues/61415.
You can work around this by disabing MSAA and using TAA or FXAA instead.


Update troubleshoot-tcpip-rpc-errors.md

Update to format of PortQry output; correction to target IP in PortQry output (target system is <IP_ADDRESS>, not <IP_ADDRESS>)

Why

Closes #[Issue Number]

Changes

Hi @v-tappelgate - thank you for the contribution, but since you opened this pull request, the article moved over to the support troubleshooting repository: https://learn.microsoft.com/en-us/troubleshoot/windows-client/networking/rpc-errors-troubleshooting
You should be able to resubmit your edit there.
@Deland-Han FYI


Fix server.rb: push option clobbered port

Coverage remained the same at 96.9% when pulling 7bbcc329e238a7e4b05409033f936a14cf03de43 on georgeu2000:fix-server-port into 585d0e817b54ed91cc22d409458896f55ac21d1d on igrigorik:master.


Dynamic page number setting in StarHealth scrapers

We should get the number of pages in each of the StarHealth scrapers dynamically.

Commit debd2870c68f12265cc5d774d92b83f5e7763466


Chinese event description EVT_90907_DESC.

I fixed spelling errors and rephrased a sentence in localisation >nwo_decisions >EVT_90907_DESC. I don't know why it claims that there were 360 additions and 360 deletions, but everything should be exactly the way it was except EVT_90907_DESC.

The 360 del/add looks like an encoding issue besides EVT_90907_DESC.
 Now finally peace may come to China. We celebrate that the forbidden city is once again in safe government hands.;;;;;;;;;;;;;x;;;;


workaround for issue #100

Using link-args, we force the load address for the executable to be higher than
the shadow memory area required by address sanitizer.

@manishearth @nagisa Are either of you familiar with what's going on here? I'm not the best reviewer for this

not entirely. Makes some sense looking at https://github.com/google/sanitizers/issues/837 but I'm not entirely sure this is the right fix.

What this commit does is the following. Usually, the memory map of a rust exe at runtime would looks like this:
[0x00007fff7000-0x10007fff7fff]  shadow memory region for asan
ELF_ET_DYN_BASE + random offset: text segment (contains the executable code)
directly afterwards: data segment (contains global variables etc)
... lots of free address space ...
dynamic libraries (mmap region)

The problem now is that ELF_ET_DYN_BASE is so low that it is in most cases (unless you get lucky with the ASLR offset) is lower than the top end of the shadow memory region, so it collides. The "fix" forces GCC to place the text segment at a fixed, higher address so that it cannot collide with the shadow memory region. With the fix, the memory map would look like this:
[0x00007fff7000-0x10007fff7fff]  shadow memory region for asan
0x200000000000 (not random): text segment (contains the executable code)
directly afterwards: data segment (contains global variables etc)
... lots of free address space ...
dynamic libraries (mmap region)

Note that this means that the code is always loaded at the same address (this makes exploiting buffer overflows etc easier, but it should not be a problem since fuzzing is not run against user data?), but it guarantees that it won't collid with the shadow memory space.
Possible questions:

I didn't find any option to control the data segment. It seems (?) that the data segment is always loaded directly following the text segment, so we are safe if the text segment is placed high enough
Ideally, we would only apply this linker option to the final executable, as I am not sure how it interacts with a dylib crates (they of course cannot be placed at a fixed location). But I couldn't get dylib crates to work with ASan even without this fix, so I cannot test this.

Other possible solutions:

Another solution would be to disable position independent executables, and hope that the default load address of the executable is high enough (which appears to be the case right now). It seems that you can do that with -C relocation-model=dynamic-no-pic. I did not go for this solution though as I think it is less reliable than simply specifying the load address thus ensuring that it can never collide.

I’m generally against such workarounds for several reasons:

It is super easy to forget to remove a workaround when it is not necessary anymore;
I generally consider it to be a great idea to fix issues like these upstream – either in the kernel, if it is a kernel bug (which seems unlikely), or the sanitizer (why is it assuming anything about any addresses??);
It is non-portable for the eventual future when all this stuff works on platforms other than Linux. It also assumes a particular linker which supports this particular operation/flag.

OTOH this comes with benefits as well, such as disablement of ASLR which results in more reproducible runs, so I’m only slightly against.

@nagisa I'm not sure that this can be fixed in the sanitizer / kernel. ASan needs a bit of memory for book keeping, and it appears that hardcoding this location is necessary for performance (upstream mentioned that they did not want to make it configurable because performance would suffer too much). So the only "upstream" that could fix this would be rustc.

Anyone opposed to closing this?

Has the bug been fixed? It's been a long time, I have not kept up with the latest developments in these areas.
However, I guess this particular PR can be closed anyhow, since that's not the approach anybody seems to want to take.


Upgrade gql to version 0.2.0

Upgrade gql to version 0.2.0 to get rid of direct dependency on source_span and for better parsing errors.

Published as https://pub.dev/packages/artemis/versions/1.0.1


-v alias for the -verbose option when the configuration file is set to verbose: false

It would be useful if you could allow -v alias for the -verbose option when the configuration file is set to verbose: false

-v is already used for -view (display using a pager like less).


Not releasing memory

For some reason, my viewController is never deallocating, after setting your awesome pullToRefresh...

How did you solve this issue ? I still have the exact same problem


[Request]: Make collections of which a book is a member available as metadata

Feature Request Checklist

[X] I have searched the existing issues to avoid duplicates

What feature would you like to request?
I thought I'd seen another request that touched on making more metadata available from the import. This request would probably also be served by #41 , but I'm looking to update my template to add tags in the front matter to relate books together. A good solution for me would be if the collections that a book is part of in Apple Books was made available as part of the import metadata.
For example, in Apple Books, I have a collection for "Science Fiction" and another for "Fantasy", and I'm free to put any book I like into either or both of these. If these collections were available as metadata, I'd be able to include them as tags and cluster together the highlights which share common collection entries.
Thanks for considering!
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@banj Thank you for the request.
Making collections available to use in templates would be a great addition, indeed.
I haven't added them initially because they were more like convenience rather than necessity.
The only thing I should mention is that there are two types of collections: default ones (predefined, like Books, PDFs, Finished, etc) and custom ones (created by the user). Each book has several collections assigned depending on its type (like Book, PDF, Audio), state (Want to Read, Finished, etc.) and your custom criteria (user-defined collections). I believe there would be no problem with pulling collections for a particular book, and using them as tags, but these would be unmanageable items, as even if you delete some of them, the list will be updated on each import that affects this particular book.
What do you think? Will this workflow be useful for you?

That’s really useful context! I didn’t know the data model in Books worked like that.
Yes, that definitely sounds very helpful. For my use case the more metadata brought over the better, but collections (both automated and user controlled) are really helpful for clustering the highlights files together


Typing / generic support for useThrelte

I'm working on the next branch getting WebGPU set up. A minor UX issue is that useThrelte always infers the type of renderer as WebGLRenderer.  It's easily fixed with a type assertion (per below), but it could be beneficial to make useThrelte accept generics for applications where the renderer doesn't change. This could also be extended to other useThrelte props if desirable:
// now
import { PerspectiveCamera, WebGPURenderer } from 'three/webgpu';
import { useThrelte } from '@threlte/core';

function useWebGPUThrelte() {
  const context = useThrelte();
  return {
    ...context,
    renderer: context.renderer as WebGPURenderer,
    camera: context.camera as PerspectiveCamera
  };
}

// proposed
const { renderer, camera } = useThrelte<{renderer: WebGPURenderer, camera: PerspectiveCamera>();

This is a bit leaky and wouldn't handle updates well - there may be a better way - but it could be a bit tidier.

Hey @ianjdarrow,
thanks for bringing this up 👍
What do you think about opening up the types of the context to the ambient types? So just as we now do with custom prop types and custom component catalogue types we could allow to override certain parts of the context type:
import { WebGPURenderer } from 'three/webgpu'

declare global {
  namespace Threlte {
    interface Context {
      renderer: WebGPURenderer
    }
  }
}

export {}

const { renderer } = useThrelte()
     // ^? WebGPURenderer

I'm not 100% sure about the implications, since that would mean that every usage of useThrelte in an app would default to WebGPURenderer (could be worked around by different tsconfigs) but it could be a way forward. Looking forward to your input!

That would work well for my use case and seems more idiomatic for Svelte than my suggestion – nice one.
I have a somewhat unusual use case where I don't need to support WebGL fallback so it's a little bit easier for me – might be a good idea to get others' feedback as well; I can get by with // @ts-expect-error for a while :)


Adds only real source files to podspec.

Should close #81

pretty please?
PDFGenerator won't build on XCode 10 using cocoapods without this.
for anyone else with this issue, you can find an updated fork here:
    pod 'PDFGenerator', git: 'https://github.com/GilasBY/PDFGenerator', commit: '11bbcc5d30db78bb200c7049ff6dbdba8b917ec7'

Thank you for submitting PR.
I will further improve upon receiving this PR so please wait for a while. 🙏


Replace resize sensor with resize observer?

First, thank you for such a wonderful plugin! I was curious if you would be willing to replace the resize sensor with a native resize observer? There is a nice polyfill here. I can an add a PR, please let me know.

Resize observer is still new specification and we didn't see many browser support it yet except in Chrome 64 we have no problem in that at all if there's a great polyfill, but resize observer polyfill that you mentioned relies on Mutation Observer with a fallback to Mutation Events for IE 9 and IE 10, at first glance that is so convenient but when we look deeply, Mutation Events is slow and has some performance issues that would be disaster if it implemented on this tool. i appreciate your contribution thanks.
Regards.


Crash when app is using Firebase Performance library.

Steps to reproduce:

Use firebase performance library
Use Kakao 3.2.3

Observed Results:

App crashes when running test with a Firebase perf error, there seems to be some dependency clash maybe?

java.lang.NoSuchMethodError: No static method registerDefaultInstance(Ljava/lang/Class;Lcom/google/protobuf/GeneratedMessageLite;)V in class Lcom/google/protobuf/GeneratedMessageLite; or its super classes (declaration of 'com.google.protobuf.GeneratedMessageLite' appears in /data/app/~~4sKIYTcsfYQtc9JM7hBNvA==/me.mydomain.myapp.test-Im1U7Kqsm8hvB13qvO5VGA==/base.apk)
at com.google.firebase.perf.v1.ApplicationInfo.<clinit>(ApplicationInfo.java:1085)
at com.google.firebase.perf.v1.ApplicationInfo.newBuilder(ApplicationInfo.java:533)
at com.google.firebase.perf.transport.TransportManager.finishInitialization(TransportManager.java:227)
at com.google.firebase.perf.transport.TransportManager.syncInit(TransportManager.java:221)
at com.google.firebase.perf.transport.TransportManager.$r8$lambda$LuAwHBxy50Yf-ziHqcD54KjEPtk(Unknown Source:0)
at com.google.firebase.perf.transport.TransportManager$$ExternalSyntheticLambda1.run(Unknown Source:2)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:920)

This Fix works for me:
Exclude protobuf-lite dependency from Kakao
    androidTestImplementation ("io.github.kakaocup:kakao:3.2.3")
    {
        exclude module: "protobuf-lite"
    }

You may close this just wanted to put it here for others.

+--- androidx.test.espresso:espresso-contrib:3.5.1
...
|    \--- com.google.android.apps.common.testing.accessibility.framework:accessibility-test-framework:3.1.2
|         +--- com.google.protobuf:protobuf-lite:3.0.1

That dependency going from espresso famework and https://mvnrepository.com/artifact/com.google.protobuf/protobuf-lite  with 3.0.1 version. You probably using outdated version 3.0.0 in your project.


feat: vue query panel

Closes #317

will this be added to nuxt devtools?

hi @webfansplz thank you for this integration 💪 please advise how to integrate to nuxt devtools like tree applet?


Evaluation on SPEC2006

Hi,
I tried to evaluate Softbound on SPEC2006, but it showed a significant overhead (for bzip, 5x slower than native run). Is there any extra optimizations that I have to do to reduce the overhead?
Thanks

It is possible that the checks are not getting inlined. Can you check if the checks and softboundcets wrappers are getting inlined?

Thanks, I inlined them, and the runtime overhead for bzip2 is now about 1.7x, is it a fair result?

Thanks, I inlined them, and the runtime overhead for bzip2 is now about 1.7x, is it a fair result?

Hi, I'd like to ask how to inline these checks and softboundcets wrappers ?  Is there any commands that I have to turn on when I compile softboundcets? Thanks.

1.7X with spatial and temporal safety seems to be in right ballpark. That said, I have not updated this code base in 7 years. You may be interested in Tina Jung's work on eliminating bounds check in the SoftBound context; http://www.prog.uni-saarland.de/projects/pico/


Adaptor not called for '2nd level' properties

Description:
I am trying to use an adaptor on an object whose data is effectively:
{ name: 'abc',
  dimensions: {
    height: 123,
    width: 123,
  }}

When I put these properties in the mustache I can see the adaptor 'set' method being called for the {{name}} property.
However, I do not see the adaptor 'set' method called for {{dimensions.height}} nor {{dimensions.width}}
Reproduction:
I've made this up in a fiddle: http://jsfiddle.net/benbeaumont/ATAgH/30/

you will see some input boxes
the calls to the adator 'set' method are logged (in purple)
note that changing the width/height does not cause a new purple message while changing the name does

Versions affected:
Tried with latest (currently v0.8.1)

I'm seeing the same behavior in 0.6.1, 0.7.3 and 0.8.5 which suggests that this might not be a bug but a use case that adaptors wasn't designed for. But I'm not that sure as I personally don't use adaptors that much. I'll let others chime in.

Yes, as originally designed and implemented, adaptors support only the value and its immediate children. There's a planned redesign on adaptors for 0.10 that aims to address this and a few other limitations with adaptors. The next adaptor API is still open for discussion, so I'm going to punt this over to the existing issue: #2512


test CI compile failure

@edrex compile fail messages OK

@edrex test failures look great!
https://github.com/alex-courtis/way-displays/actions/runs/4836898512/jobs/8620384383?pr=95
Question: do we need the push action? On other projects we are just using pull_request...

do we need the push action? On other projects we are just using pull_request

Seems like it comes down to maintainer preference. Merging a branch can combine changes that weren't previously tested together though, so running it on push, at least to the master branch, seems safest. 🤷

do we need the push action? On other projects we are just using pull_request

Seems like it comes down to maintainer preference. Merging a branch can combine changes that weren't previously tested together though, so running it on push, at least to the master branch, seems safest. shrug

That works nicely. Once again many, many thanks for all your work @edrex


Grid type octpusenergy key is called "tariff" but only accepts "product"

Describe the bug
The grid type octopusenergy has the key tariff, but when the tariff code is used an error is displayed in the log. When the product code is used, the configuration works without issues.
Octopus Energy has tariff codes and product codes, which conflicts with how the terminology is used in EVCC. If Octopus Energy  would not have had tariff codes, users would not have been confused and would use product codes as value for tariff. However, given that looking up a Octopus Energy product code will also expose the user to the tariff code, the error is the result of expected configuration changes.
For clarification, this is from the API reference of Octopus Energy.
product_code

    The code of the product to be retrieved, for example VAR-17-01-11.
tariff_code

    The code of the tariff to be retrieved, for example E-1R-VAR-17-01-11-A.

As you can see, the tariff code is made up of the product code with some additional stuff. I believe that EVCC actually obtains the tariff code using the product code.
Steps to reproduce

Configure octopusenergy as grid type
Use the tariff code E-1R-COSY-22-12-08-A as value for tariff

Configuration details
tariffs:
  currency: GBP
  grid:
    type: octopusenergy
    tariff: E-1R-COSY-22-12-08-A # Tariff code
    region: A # optional

Log details
**Log output when using `E-1R-COSY-22-12-08-A` as value for `tariff`:**

[octopus] ERROR 2024/04/17 16:01:59 unexpected status: 404 (Not Found)
[main  ] ERROR 2024/04/17 16:01:59 failed configuring grid tariff: cannot create tariff type 'octopusenergy': unexpected status: 404 (Not Found)

### What type of operating system are you running?

HomeAssistant Add-on

### Version

0.125.0

I think there are two options for a fix:

Clarify in the documentation that tariff in the case of Octopus Energy refers to the product code. I think this is undesirable as it is more of a workaround.
Add an additional more specific key called tariffcode or productcodeand update /tariff/octopus/api.go to reflect this. Tariff can then be deprecated in time. I do not have enough knowledge of the octopus energy api to know whether it makes most sense to ask for the tariffcode or productcode.
Add a key for the Octopus Energy api token and obtain the active tariff code in the background. This is more work, but provides a better user experience as the API key can relatively easily be found in the Octopus Energy account details whereas finding the product or tariff details is more involved.

Is this similar to https://github.com/evcc-io/evcc/pull/11555?

It is - #11555 provides option 3
Tariff and product codes are mightily confusing to pick apart because they're referred to by similar phrases in different places - sorry for any confusion!
I'd suggest we could catch this during parsing of the code (and act appropriately), but option 2 is probably a better move for long term codebase tidiness (alongside option 3)

@duckfullstop would you want to follow up with the PR? Otherwise I'd close here as wontfix.

I'm happy to provide a fix (life permitting), but I'm not sure whether it makes more sense to add it as part of #11555, or as a separate thing?

As you prefer, no strong opinion here.

I have pushed a non-breaking change from tariff to productcode to the branch, ready for review once it's unstaled (unless I broke #11555?)


How many images for data augmentation?

Hi,
Thanks for this implementation.
I know that the dataset is just 30 images, but can I know how many total images you used after performing data augmentation?
Thank you!
Chaitanya.

@ChaitanyaKolluru1 . you can just do save_to_dir = some file path and then check how many gets saved


Prompt output is sometimes empty until VSCode is restarted

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[ ] I'm not able to find an open issue that reports the same bug
[ ] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: Ubuntu 22.04
- Continue: Ollama v0.1.23
- IDE: VSCode 1.86.0

Description
The box where the output is supposed to be doesn't render until I restart the window. This occurs randomly. Sometimes it's fine.
To reproduce
Run the LLM. Often only happens after a few runs.

Reloading the window fixes it.
Log output
No response

@NinjaPerson24119 Last weekend we started using Shiki to render code blocks because it gave syntax highlighting that matches the VS Code theme, but unfortunately it's been causing a handful of bugs like this. Sometimes doesn't render at all, oftentimes renders slowly, and after there are enough code blocks on the screen (e.g. try "write bubble sort in 20 different languages") they fail to be highlighted.
So yesterday I started figuring out how to get syntax highlighting in Monaco: https://github.com/continuedev/continue/commits/nate/monaco-not-shiki/
Almost done with this and may release today or tomorrow. Seems to avoid all of these problems

I'm experiencing the same issue, after a few queries it stops formatting the response and then eventually stops outputting responses altogether.  Using Continue as a connector to LMStudio.

@m-e-conroy @NinjaPerson24119 @uninstallit this is now solved in the latest pre-release (0.9.52).
will close this issue as soon as I get any confirmation that it's working for you

@sestinj Working for me now.  Thanks!

nice! closing, but if others don't see the same feel free to re-open


Electron driver intermittent issues

Note: Issue is for tracking and visibility in-case this is discovered by someone else during my investigation/fix.
When running Electron driver remotely with 'gridURL' defined, tests are executed properly, and correctly, until randomly one test will report an error, then subsequently after that the rest of the tests fail.
First error:

13:42:23.451 [main] ERROR com.frameworkium.listeners.ScreenshotListener - Unable to take screenshot - org.openqa.selenium.remote.SessionNotFoundException: Session ID is null. Using WebDriver after calling quit()?

Subsequent errors after that:

13:43:36.115 [main] ERROR com.frameworkium.listeners.ScreenshotListener - Unable to take screenshot - org.openqa.selenium.WebDriverException: unknown error: cannot get automation extension
from unknown error: page could not be found: chrome-extension://aapnijgdinlhnhlmodcfapnahmbfebeb/_generated_background_page.html

Due to tests working properly before this, It's quite baffling. Looking into it.

I have been investigating this on and off, but manage to have a serious look into this today.
This is not related to Electron driver specifically. I have been seeing this on and off.
I manage to reproduce this by having @Visible fail on purpose (Just put in an erroneous css)
It only fails on the grid only and causes all subsequent test to SKIP because of screenshotlistener error
I believe its a race condition between TestListener setting test as a fail when BasePage: waitForObjectToBeVisible line145 timesout
AND
BaseTest: configureDriverBasedOnParams() resetting browser at a inopportune time when a call by the ScreenshotListener is made while the browser is being reset
I don't have full understanding of it yet, as it it hard to debug on the grid.
I might try to find a way to get listeners to log the events and watch for race conditions

Hey MJ,
I should of updated this issue as I found out the issue with the help of our senior front-end dev. Basically, native electron applications don't allow the support of native chromium plugins. Chromedriver injects a basic screenshot plugin into Chrome on start-up, but when electron is used, it can't do that as the plugin API isn't supported.
I've been working on the code to basically add logic to see whether screenshots are supported in the browser (just electron which isn't ATM), and I'll hopefully be raising a pull request for that today.

Closing this issue due to the opening of the pull request which circumvents these issues.


Remove a space in front of the first password word

When entering an existing wallet, if I put a space in front of the first password word, then after entering the wallet does not show the current balance. Details in the video:
https://user-images.githubusercontent.com/69896204/111512641-a0d33480-8758-11eb-9fea-3ff9897d27bd.mov
Superhero 1472b4c / v.0.5.6

I noticed if additional space appears between the words of the password or at the end, then this bug is also reproduced.


Images with Aspect.Fill on Android are no longer filling after app resume.

Hi first I'd like to say thank you for the time you've put into this package.  The problem I'm having arises after an app resume on android.  I'm using images as a background to some containers on my UI.  It seems as though after a resume some of the backgrounds have taken the shape of other backgrounds using the same image.  Is there a way I could have multiple CachedImages using the same image source with the aspect property set to Aspect.Fill in different sized containers?  I do see that you are using the same instance of Bitmap for each reference to a single image and this might be causing this side effect.

Yes, you can do this. Just use a custom key factory, and assign a different key for each image.
Here's an example:

https://github.com/luberda-molinet/FFImageLoading/blob/master/samples/ImageLoading.Forms.Sample/Shared/Pages/CustomCacheKeyPage.cs#L51-L81
https://github.com/luberda-molinet/FFImageLoading/blob/master/samples/ImageLoading.Forms.Sample/Shared/Pages/CustomCacheKeyPage.cs#L99


Bdb

I'm not sure what I did here, so definitely review ... the first was already pulled, the merge came from I don't know where ... its the BUILD_VERSION commit that I was trying to push
BUILD_VERSION isn't used anywhere in the code
replaced it with APP_VERSION and APP_BUILD_NUMBER, and used those variables in FreeAPS.xcodeproj/project.pbxproj so that you no longer have to edit N occurances in that file, just have to modify the config file itself
Also, you changed AppIcon_BW -> AppIcon, so that its purple instead of black ... changed that to a variable as well, since in our environment ( at least ), we have some that have both Ivan and your apps installed ( while we switch from one to the other ), and having both of them purple would be major confusing ...
Let me know if I have to reset my fork and re-submit this ... I'm still not sued to forking and submitting PRs ...

Ignore this ... figured out "what I did wrong" ... will redo ...


Make multiple blank users rather than just one.

Presently if you make a bunch of sessions with a blank name, they are
all assigned to the same presenter.  This poses a problem if you later
want to change the presenters name.  It would change the name for all
unassigned sessions. This makes one presenter for each unassigned
session. This allows us to set different names at a later time.

Coverage increased (+0.08%) to 52.559% when pulling 15884f7f414b660060070ef186c0ae2ee7113fd1 on new_user into 3d985cb4c9b414f9245b3f7fb15385db5f83b940 on master.