OrbitControls not working properly

Describe the bug
I'm trying to customize the controls property using OrbitControls but when I insert it in my .ts file the viewer is not fluent and then crashes (need to close the page and open it back).
To Reproduce
Steps to reproduce the behavior:

add import { StlModelViewerModule } from 'angular-stl-model-viewer'; to app.module.ts
add THREE module and OrbitControls (import { OrbitControls } from 'three/examples/jsm/controls/OrbitControls') to my component .ts
create a function for the control: getControls(){const controls = new OrbitControls(this.camera, this.renderer.domElement);}
add to the HTML element [controls]="getControls()"
See error

Expected behavior
I guess to see exactly the same controls as the default.
I see in the library that this is the default:
if (this.hasControls && !this.controls) {
    this.controls = new OrbitControls.OrbitControls(this.camera, this.renderer.domElement);
    this.controls.enableZoom = true;
    this.controls.minDistance = 1;
    this.controls.maxDistance = 7;
    this.controls.addEventListener('change', this.render);
}

Of course this is just a test, I need to change other stuff such as this.controls.minDistance = 1; and this.controls.maxDistance = 7; values.

Would bei nice If you could create an Demo in Stackblitz.
And Share The Error you get.
Am 23.01.2021 in 22:05, samuelemarazzita<EMAIL_ADDRESS>schrieb:
Describe the bug
I'm trying to customize the controls property using OrbitControls but when
I insert it in my .ts file the viewer is not fluent and then crashes (need
to close the page and open it back).
To Reproduce
Steps to reproduce the behavior:

add import { StlModelViewerModule } from 'angular-stl-model-viewer';
to app.module.ts
add THREE module and OrbitControls (import { OrbitControls } from
'three/examples/jsm/controls/OrbitControls') to my component .ts
create a function for the control: getControls(){const controls = new
OrbitControls(this.camera, this.renderer.domElement);}
add to the HTML element [controls]="getControls()"
See error

Expected behavior
I guess to see exactly the same controls as the default.
I see in the library that this is the default:
if (this.hasControls && !this.controls) {
this.controls = new OrbitControls.OrbitControls(this.camera,
this.renderer.domElement);
this.controls.enableZoom = true;
this.controls.minDistance = 1;
this.controls.maxDistance = 7;
this.controls.addEventListener('change', this.render);
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/codaline-io/angular-stl-model-viewer/issues/439, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AARI4YGIKDHMVPBVURFXTADS3M2YPANCNFSM4WP7DTMA
.

Would bei nice If you could create an Demo in Stackblitz.
And Share The Error you get.
Am 23.01.2021 in 22:05, samuelemarazzita<EMAIL_ADDRESS>schrieb:
Describe the bug
I'm trying to customize the controls property using OrbitControls but when
I insert it in my .ts file the viewer is not fluent and then crashes (need
to close the page and open it back).
To Reproduce
Steps to reproduce the behavior:

add import { StlModelViewerModule } from 'angular-stl-model-viewer';
to app.module.ts
add THREE module and OrbitControls (import { OrbitControls } from
'three/examples/jsm/controls/OrbitControls') to my component .ts
create a function for the control: getControls(){const controls = new
OrbitControls(this.camera, this.renderer.domElement);}
add to the HTML element [controls]="getControls()"
See error

Expected behavior
I guess to see exactly the same controls as the default.
I see in the library that this is the default:
if (this.hasControls && !this.controls) {
this.controls = new OrbitControls.OrbitControls(this.camera,
this.renderer.domElement);
this.controls.enableZoom = true;
this.controls.minDistance = 1;
this.controls.maxDistance = 7;
this.controls.addEventListener('change', this.render);
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/codaline-io/angular-stl-model-viewer/issues/439, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AARI4YGIKDHMVPBVURFXTADS3M2YPANCNFSM4WP7DTMA
.

I'm not sure if it works, but the code should be all. I can't check if the STL file works because stackblitz is telling me "Starting dev server" since the beginning. If it doesn't work because of that, please feel free to change it: https://stackblitz.com/edit/angular-ivy-qmajfy

I'm not sure if it works, but the code should be all. I can't check if the STL file works because stackblitz is telling me "Starting dev server" since the beginning. If it doesn't work because of that, please feel free to change it: https://stackblitz.com/edit/angular-ivy-qmajfy

your method  getControls is not returning anything.
and a hint: avoid calling functions to set properties.
Each rendering will execute them again and again.

your method  getControls is not returning anything.
and a hint: avoid calling functions to set properties.
Each rendering will execute them again and again.

Thanks, and what may be a better solution than function? And why my getControls is retuning anything if I used OrbitControls as your module does?
Il 24 gen 2021, 14:22 +0100, Bengt Weiße<EMAIL_ADDRESS>ha scritto:

your method getControls is not returning anything.
and a hint: avoid calling functions to set properties.
Each rendering will execute them again and again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks, and what may be a better solution than function? And why my getControls is retuning anything if I used OrbitControls as your module does?
Il 24 gen 2021, 14:22 +0100, Bengt Weiße<EMAIL_ADDRESS>ha scritto:

your method getControls is not returning anything.
and a hint: avoid calling functions to set properties.
Each rendering will execute them again and again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

getControls() {
    const controls = new OrbitControls(this.camera, this.renderer.domElement);
  }

is not returning any value... so when you call it in the template, nothing is returned...

getControls() {
    const controls = new OrbitControls(this.camera, this.renderer.domElement);
  }

is not returning any value... so when you call it in the template, nothing is returned...

I did not test it.. but something like that i would expect:
import { Component } from "@angular/core";
import * as THREE from "three";
import { OrbitControls } from "three/examples/jsm/controls/OrbitControls";

@Component({
  selector: "my-app",
  templateUrl: "./app.component.html",
  styleUrls: ["./app.component.css"]
})
export class AppComponent {
  scene = new THREE.Scene();
  material = new THREE.MeshStandardMaterial({
    color: 0x3781da,
    emissive: 0x0,
    roughness: 1,
    metalness: 0,
    fog: true,
    side: THREE.DoubleSide,
    skinning: false
  });
  renderer = new THREE.WebGLRenderer({ antialias: true });
  controls = null;
  light = new THREE.HemisphereLight(0xffffff, 0x444444);
  camera = new THREE.PerspectiveCamera(45, 4 / 3, 0.01, 1000000);

  defaultMeshOptions = {
    castShadow: true,
    position: new THREE.Vector3(0, 0, 0),
    receiveShadow: true,
    up: new THREE.Vector3(0, 0, 1),
    scale: new THREE.Vector3(0.01, 0.01, 0.01)
  };

  constructor() {
    this.controls = new OrbitControls(this.camera, this.renderer.domElement);

    this.scene.background = new THREE.Color(0xffffff);
    this.scene.fog = new THREE.Fog(0xffffff, 10, 1000);

    this.light.position.set(0, 20, 0);

    this.camera.up = new THREE.Vector3(0, 0, 1);
    this.camera.position.set(-3, -3, 3);
    this.camera.lookAt(0, 0, 0);
  }
}

<stl-model-viewer
  [stlModels]="'http://www.ozeki.hu/attachments/116/Cube_3d_printing_sample.stl'"
  [meshOptions]="[defaultMeshOptions]"
  [camera]="camera"
  [material]="material"
  [scene]="scene"
  [renderer]="renderer"
  [controls]="controls"
  [light]="light"
></stl-model-viewer>

I did not test it.. but something like that i would expect:
import { Component } from "@angular/core";
import * as THREE from "three";
import { OrbitControls } from "three/examples/jsm/controls/OrbitControls";

@Component({
  selector: "my-app",
  templateUrl: "./app.component.html",
  styleUrls: ["./app.component.css"]
})
export class AppComponent {
  scene = new THREE.Scene();
  material = new THREE.MeshStandardMaterial({
    color: 0x3781da,
    emissive: 0x0,
    roughness: 1,
    metalness: 0,
    fog: true,
    side: THREE.DoubleSide,
    skinning: false
  });
  renderer = new THREE.WebGLRenderer({ antialias: true });
  controls = null;
  light = new THREE.HemisphereLight(0xffffff, 0x444444);
  camera = new THREE.PerspectiveCamera(45, 4 / 3, 0.01, 1000000);

  defaultMeshOptions = {
    castShadow: true,
    position: new THREE.Vector3(0, 0, 0),
    receiveShadow: true,
    up: new THREE.Vector3(0, 0, 1),
    scale: new THREE.Vector3(0.01, 0.01, 0.01)
  };

  constructor() {
    this.controls = new OrbitControls(this.camera, this.renderer.domElement);

    this.scene.background = new THREE.Color(0xffffff);
    this.scene.fog = new THREE.Fog(0xffffff, 10, 1000);

    this.light.position.set(0, 20, 0);

    this.camera.up = new THREE.Vector3(0, 0, 1);
    this.camera.position.set(-3, -3, 3);
    this.camera.lookAt(0, 0, 0);
  }
}

<stl-model-viewer
  [stlModels]="'http://www.ozeki.hu/attachments/116/Cube_3d_printing_sample.stl'"
  [meshOptions]="[defaultMeshOptions]"
  [camera]="camera"
  [material]="material"
  [scene]="scene"
  [renderer]="renderer"
  [controls]="controls"
  [light]="light"
></stl-model-viewer>

Thank you, but controls is still not working with your solution.
I moved the controls into the class of the component instead of creating a null value for it and then changing the values into the constructor. Anyway, the camera is not moving anymore now. When I don't use the property [controls]="controls" the default works perfectly.

Thank you, but controls is still not working with your solution.
I moved the controls into the class of the component instead of creating a null value for it and then changing the values into the constructor. Anyway, the camera is not moving anymore now. When I don't use the property [controls]="controls" the default works perfectly.

but do you get some error in your JS-Developer console in the browser?

but do you get some error in your JS-Developer console in the browser?

It doesn't compile anything there, I just can't test it. I'm testing it on my local version.

It doesn't compile anything there, I just can't test it. I'm testing it on my local version.

yeah... but even there you can open js developer console in your browser and check for errors...

yeah... but even there you can open js developer console in your browser and check for errors...

Ok sorry, I was looking at their console that was empty. In this case, the problem is the STL link, looks like it doesn't work. I'll try with another file hosted by me, maybe it's a permission issue.

Ok sorry, I was looking at their console that was empty. In this case, the problem is the STL link, looks like it doesn't work. I'll try with another file hosted by me, maybe it's a permission issue.

Ok, great, made it compile, and now it's giving me this error:
Error in src/app/app.component.html (1:20)
Type 'number' is not assignable to type 'string[]'.

https://stackblitz.com/edit/angular-ivy-qmajfy?file=src/app/app.component.ts
I can't understand what is the field I'm messing up.

Ok, great, made it compile, and now it's giving me this error:
Error in src/app/app.component.html (1:20)
Type 'number' is not assignable to type 'string[]'.

https://stackblitz.com/edit/angular-ivy-qmajfy?file=src/app/app.component.ts
I can't understand what is the field I'm messing up.

Ok, I've made it work now and this is the error:
Error in src/app/app.component.html (1:20)
Type 'string' is not assignable to type 'string[]'.

Ok, I've made it work now and this is the error:
Error in src/app/app.component.html (1:20)
Type 'string' is not assignable to type 'string[]'.

if you get an error it is not "working"... so i guess you are lacking experiences in js and ts....
seems like your are not passing the properties in the correct way. one seems to accept only an array of strings, but you are passing a string.

if you get an error it is not "working"... so i guess you are lacking experiences in js and ts....
seems like your are not passing the properties in the correct way. one seems to accept only an array of strings, but you are passing a string.

i released a new version with a new example in it, how to work with custom controls.
https://codaline-io.github.io/angular-stl-model-viewer/ - check the 3rd model
https://github.com/codaline-io/angular-stl-model-viewer/blob/master/projects/examples/src/app/app.component.ts
https://github.com/codaline-io/angular-stl-model-viewer/blob/master/projects/examples/src/app/app.component.html

i released a new version with a new example in it, how to work with custom controls.
https://codaline-io.github.io/angular-stl-model-viewer/ - check the 3rd model
https://github.com/codaline-io/angular-stl-model-viewer/blob/master/projects/examples/src/app/app.component.ts
https://github.com/codaline-io/angular-stl-model-viewer/blob/master/projects/examples/src/app/app.component.html


Add Logan Foundation to our sponsors

Add The Reva and David Logan Foundation to our sponsors. You should be able to pull their logo off of their site or from Google images (warning: it's low res).

Oops, clicked the wrong button.


"Form CSS" is not included in output.

Whatever styles I add to the form CSS never end up in the HTML of the page (I scanned the entire output, including a referenced stylesheet.)
I am referring to this field (organization):

I am using an IFRAME. I did notice that IFRAME's are handled slightly different, maybe that's the cause?
I need this to make the background transparent, so I can blend the IFRAME login box better into my application UI.
On a side note. The term "Form CSS" is somewhat ambiguous. It's not clear if this is meant to style the form only, or if you can style the entire page. Perhaps "Custom CSS", or something similar is a better term.

@Sjoerd82 fixed in: https://github.com/casdoor/casdoor/commit/bc399837ccde6c459dfc0f411361ca9599dd5cfd
For IFRAME, you can modify the code as belows:

Sorry, not yet getting it.. This means that "Form CSS" cannot be used when in an IFRAME?
Is there a way to influence the style for an IFRAME login page? (Other than providing a full HTML replacement page, which does work, but is a lot more work, plus you probably lose the translation).

@Sjoerd82 why can't you modify the code? Iframe CSS is rarely used. I'm still seeing if other people have same requirement before deciding to support it.
For i18n, yeah it may not work maybe. But I don't have time to check that. Let someone fix it.


type_ptr update

Make type_ptr more safe.
Current implementation contains default copy constructor/assignment which can lead to double free issue (for example #142).

@mloskot @vadz Could you please review and comment?
Current implementation allows following usage https://github.com/snikulov/soci/commit/8d2f10181d1125d7c61ff418511b46452aa79c3c which can produce double free.
Make it non-copyable will break compilation, since C++98 does not allow move semantics.
Since we don't use C++11, I disable compiler defined copy/assign operations.

My question would be, do we need type_ptr<Person> pt3 = pt1; use case?
type_ptr is a kind of shared smart pointer, but it is very very minimal, I guess, such use case and/or move semantics was not considered as required.

@mloskot I just try conform to following guideline "Make interfaces easy to use correctly and hard to use incorrectly" http://www.aristeia.com/Papers/IEEE_Software_JulAug_2004_revised.htm
Current implementation can be used incorrectly, even if we don't want this.

@snikulov  I agree with you and that is a good idea, in general.
My point was that AFAIK, type_ptr is hidden implementation detail in SOCI (it lives in soci::details:: namespace).
It means, we as SOCI developers are sole users of type_ptr.
AFAIU, core developers can take the risk and should know how to use it correctly.
Is there any actual issue to solve, apart from inconveniences coming from limited type_ptr features?

I try reduce number of reasons for possible memory leaks and double free, which still present in issue list.
Because, I suspect, type_ptr not sole use of developers. It leaks into user interface through typedef indirectly.

I'm not sure how does this type "leak" into the public API, but I'd say it's probably a problem if it does.
As for the changes themselves, release() is IMHO completely uncontroversial. I'm much less sure about implementing the custom assignment operator and copy ctor though: if we do it like this, why not just std::auto_ptr<> explicitly, as it seems to become the same thing? At the very least, assignment should IMO be forbidden at all, do we need it anywhere?

@vadz Because auto_ptr is deprecated for modern compilers.
So we just break SOCI for example on MSVC, where we unable to disable c++11 with set of switches.
BTW, I suspect, I have similar issue on MSVC with nothrow for destructor. MSVC will terminate program even if nothrow(false) set for destructor ~once_temp_type() SOCI_ONCE_TEMP_TYPE_NOEXCEPT;.

Sorry, "use auto_ptr" was shorthand for "we should use unique_ptr<> where available (check for __cplusplus and _MSC_VER separately) or auto_ptr otherwise".

@vadz @mloskot So, what's the decision?
Should we remove type_ptr completely?

I'll summary my point:

The proposed addition to soci::details::type_ptr does not make it ideal, less shoot-yourself-in-foot prone.
"std::auto_ptr or std::unique_ptr in C++11 mode", as I mentioned on Gitter
Do we really need assignment? Indeed, I see adding it is not going to solve any issues, so we "ain't gonna need it" :)
If soci::details::type_ptr does not deliver any added feature, comparing to std::auto/unique_ptr, then it is a good idea to replace it with the standard smart pointer(s).


add webdav serve and built-in images browser

rcloneExplorer is a very cool project.
Can add rclone serve webdav function for rcloneExplorer, since many android app support webdav but not http?
Can support a built-in image viewer in rcloneExplorer, browse pictures one by one without opening a third-party photo browser app for every time.

Those look like two different suggestions. Could you split this into two different issues? Thanks.

@kaczmarkiewiczp  ok, thanks,   I closed this issue, and add two new issue.


Answered  ago by  at plan edit

The Answered  ago by snippet under each answer only works when it is updated the text within the tinyMCE component, i.e. for radiobutton, checkbox questions... if only changes the options selected that snippet never get updated.

I don't think this is fixed @jollopre I went into the NERC template to test changes and answered two questions - one radio button and one dropdown. They saved correctly saying they were last edited less than 1 min ago by me. I refreshed the page a few minutes later to test updates but both then recorded as not having been answered, although answers were clearly still recorded.

I went to export to check whether answers are being saved and no format I tried would export. Don't know if this is related or linked to other changes currently being made. Will hold off raising a ticket for now until we're sure

I'm not able to replicate what you are describing.
Regarding the export, it's broken, see issue #364

Just tested again and this is still happening for me. You edit an answer and it records correctly then you refresh the page or navigate away and return and it says not answered yet
Thanks for raising export issue separately

Fixed. Closing out


"Wrong number of args (4) passed to: core$make-array" error in Clojure InstaREPL

In a Clojure Instarepl the following valid code produces the error message "Wrong number of args (4) passed to: core$make-array":
;; Anything you type in here will be executed
;; immediately with the results shown on the
;; right.
(make-array Double/TYPE 3)

Affected version:

Light Table version 0.6.5
Binary version 0.8.4

LightTable is such an awesome piece of software - please keep going!

This bug is still visible in Light Table 0.8.0 running on Mac OS X. You see the same error message for
(clojure.core/make-array Double/TYPE 3)
for any type and for any dimensions.

This issue has moved to https://github.com/LightTable/ClojureInstarepl/issues/5 as the instarepl is now its own plugin

This issue has moved to https://github.com/LightTable/ClojureInstarepl/issues/5 as the instarepl is now its own plugin


Add option to select base repo

Describe what this PR does / why we need it
Adds config option always_select_remote that gives select prompt for base repo when creating a PR.
Does this pull request fix one issue?
Fixes #334

Describe how you did it
I added function to get all configured remotes in the current repo, then I parse it and display it in inputlist and use it as base repo. This only happens if always_select_remote is set to true. Otherwise the behaviour is same as before.
Describe how to verify it
Set always_select_remote to true
:Octo pr create
Prompt with remotes should be displayed
Select a repo from the list
Selected repo should be used as base repo for the PR
Special notes for reviews
My lua skills are pretty basic, so feel free to suggest/make any improvements

Thanks for the PR (and sorry for the late response). The changes look good to me but can you please document the new config option in the README and docs?

I updated the README, but I'm not sure what to update in the docs, since their config entry just points to the README.

Thanks! You are right, in that case, adding that to the README is enough. Thanks for the PR!


Truncated string representation for TreeNode

It would be totally awesome if we could have a way to have a truncated string representation of a tree similar to Pandas DataFrames and numpy arrays.
Right now when I'm debugging and I accidentally display a TreeNode object in iPython, my screen basically explodes and I have to force shutdown my session.
What do you guys think?  This feature would also be nice to have in the BIOM object / Contingency table.
EDIT: This is referring to str(), not ascii_art()

Probably spoke too soon.  Was referring to the Newick string representation.  The Treenode object already has a nice string representation.


Feature: Adding Footer and Navigation Bar

I would like to add a nav bar and footer.

Can you assign this issue to me under hacktoberfest23?

Please give more context about the contents of the nav bar and footer, and you can start working on it

The navbar will include:

Home , Contact Us , about us , login links
And footer will contain the social media profiles and copyright

Alright, you can work on the PR now


[Feature Request]: macOS 13 support for Vanilla Installer itself

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Potential Enhancement
GitHub has released a beta testing image of macOS 13 for all action users where they can test out the newest software in this operating system as macOS 12 is fully functional with our software already.
The source itself for reference,
The issue commenting about it although likely outdated.
How it could be implemented
To make use of it, Test-Swap the "macos-12" statement with "macos-13" in the ci.yml workflow script itself.
Anything else?
When using the macos-13 statement itself, expect issues to happen as the image is unfinished and requires fixes to compile vanilla installer itself properly, another thing to note is that there is no documentation about it at this time meaning we must go in blind for this one at time of writing this """issue""",
And another thing to note is that any image containing -xl at the end of their names indicate the same images but improved ones and that those require a subscription to work in first place.

Update: The README documentation for macOS 13 has been released.


Improve publish script

Add 5 s delay before every crate and some logs
cargo clean at start

It's still not idem-potent, but will probably fix the issue. We'll see! :)
Btw should we mention this in the README? Maybe not.


Great_expectation: incompatible with config version 3.0 due to missing action_list_operator

Describe the bug
When utilizing the great_expectation integration with the newest great_expectation config version, you receive the following error:
DataContextError: No validation operator action_list_operator was found in your project. Please verify this in your great_expectations.yml
Originating from
[...]pandas_profiling/expectations_report.py", line 100, in to_expectation_suite
    results = data_context.run_validation_operator(

To Reproduce
Running example 1 from
https://github.com/pandas-profiling/pandas-profiling/blob/develop/examples/features/great_expectations_example.py
using below versions
Version information:
Python 3.8.2
great_expectations 0.13.19 (with config_version: 3.0)
pandas_profiling 2.11.0
Additional context
Error can be circumvented by adding the following code to great_expectations.yml after init, but this will give a depreciation error when using the new config version of great_expectations:
validation_operators:
  action_list_operator:
    class_name: ActionListValidationOperator
    action_list:
    - name: store_validation_result
      action:
        class_name: StoreValidationResultAction
    - name: store_evaluation_params
      action:
        class_name: StoreEvaluationParametersAction
    - name: update_data_docs
      action:
        class_name: UpdateDataDocsAction

Still an issue for the basic example code in docs:
Version information:
Python 3.9.9
great_expectations 0.13.46
pandas_profiling 3.1.0

The hack mentioned by the OP is still required to get pass this issue!
I'm new to this integration feature so it was quite a serious stumbling block for me - it's reasonable to expect this initial integration example to work without intervention?

This is still an issue in version 0.14.8 of great_expectations and pandas_profiling 3.1.0
The hack mentioned by the OP is still required to get pass this issue

Hi,
sorry not sure if this is the right issue to write into, but I wanted to raise two things:

the documentation tutorial refers to a version of Great Expectations before 1.13.8 (Jan 28, 2021). The sympthom is the one in the title of this issue.
some of the expectations generated by pandas-profiling are incompatbile with the current version of GE si they raise errors when generated.

maybe it would be good to do an upgrade to one of the more recent versions of GE?
M


Using keycloak inside vue router

Hello
I'm new to Vue 3 and I'm trying to integrate this library with my vue application. I'm using vue router and I need access to the keycloak attributes from the useKeycloak() hook. For example:
const routes = [
    {
        path: '/',
        name: 'Dashboard',
        component: Dashboard,
    },
    {
        path: "/:catchAll(.*)",
        redirect: '/'
    }
];

const router = createRouter({
    history: createWebHistory(),
    routes,
});

router.beforeEach((to, from, next) => {
    next();

});
export default router

What I'd like to do is do some additional checks before sending to the actual route. What is the best way to access the keycloak object within the beforeEach? I've tried using the useKeycloak() but the data isn't available.
Any help would be appreciated.

Hi @aminmc,
did you manage to solve this?
I ran to same situation and isAuthenticated value is always false when checked in router.beforeEach()

Hi @aminmc or @1pm ,
Were you able to solve this? Am also stuck on that

Hi @DavidzMwangi,
I solved it by adding before hook and creating custom wrapper for keycloak-js
// Restrict access to non-public routes
router.beforeEach(async to => {
  if (!to.meta.isPublic) {
    await keycloak.login()
  }
})

The key was to properly check whether user is already authenticated before calling kc.login(). I just simply set flag isAuthenticated in onAuthRefreshSuccess and onAuthRefreshError and other available events. Then checks this flag before calling the actual kc.login()


feat: Add C# snippet for Avalonia AttachedProperty, DirectProperty, S…

…tyledProperty and RoutedEvent

Thanks a lot for the PR ❤


Removed old docs, updated Travis params

Pull Request Test Coverage Report for Build 608

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.571%

Totals

Change from base Build 607:
0.0%

Covered Lines:
2503

Relevant Lines:
2619

💛  - Coveralls


.ShouldBeEquivalentTo() with a tree type leads to infinite loop

The following is the simplest sample I could come up with to reproduce.
    public class FluentAssertionsRepro
    {
        [Fact]
        public void ShouldNotEndInEndlessLoop()
        {
            var item = new Item { Child = new Item() };

            item.ShouldBeEquivalentTo(new Item(), _ => _.ExcludingNestedObjects());
        }
    }

    public class Item
    {
        public Item Child {  get; set; }
    }

This leads to an infinite loop, but no stack overflow (at least after letting it run for half a minute).

Seems to be solved already, probably by #194.


call disconnected while it is progress

Reported by @bkl:matrix.org
while we were talking (with @XXX:matrix.org if that matters) call would break without any notification for one side and for other that would be "Call connecting.." status without any progress
https://github.com/matrix-org/riot-android-rageshakes/issues/309

https://github.com/matrix-org/riot-android-rageshakes/issues/354

@bkl:matrix.org : it seems that you tapped on the hang up button in the room activity.


Migrate bullet.sh to docker entrypoint to avoid setup re-running on boot

Thanks for putting this Docker image together – was able to get it hosted on a cloud provider (for personal use) in pretty short order. I did have to make some changes to how the container spins itself up, though.
Motivation
In a stable cloud environment, we need to have the flexibility to take the server down for maintenance, take periodic backups, and switch around data volumes to test isolated mod setups. With the default behavior, bullet.sh runs as the docker CMD out of the box – and since it always copies over server files (including the "delete me" safety file), existing content would both get overwritten and the safety file would need to be removed again.
Proposal

I propose switching from running bullet.sh in the CMD to a standard docker entrypoint, which lets us configure the container before it runs the AKI server through CMD. This way, we can easily run setup tasks only when necessary, and directly run Aki.Server.exe otherwise.
I also propose inverting how the existing safety file works. Currently, a "delete me" file gets copied over on setup and needs to be removed before running the server. Instead, I'd suggest adding a version file that only gets added when the setup step is complete. For future updates (currently not implemented), we can check against the stored version and, if different from what's presently installed, log a warning and prompt the user to remove the version file if they'd like to update.

So in summary, if the version file is not detected when the entrypoint runs, it performs a one-time setup operation and generates this version file (with the tag of the docker image / SIT environment variable as its contents); and in future runs, will skip the setup step and directly run Aki.Server.exe instead.
I also added a .gitignore file so IDE and OS artifacts don't get pulled in by accident, but my default template is pretty verbose so I'm happy to remove some of the fluff if you prefer.

lgtm, 3 minor request:

please cleanup the gitignore file, that file itself is bigger than the complete SIT.Docker repo
add back the echo "Stay In Tarkov Docker" (preferrably shown on every run)
no need to touch delete_me, not used anymore

Done!


Decoding error when watch events arrive

When a Broker is created via the demo chart and steward-cf picks it up, the loop errors with the following error:
E1116 22:32:32.254614       1 streamwatcher.go:109] Unable to decode an event from the watch stream: unable to decode watch event: no kind "Broker" is registered for version "steward.deis.io/v1"
22:32:32 ERROR k8s.broker loop.go:38 the watch channel was closed
22:32:32 CRITC framework.runner runner.go:60 watch closed
22:32:32 CRITC  main.go:35 error running steward-framework: watch closed

I believe the "unable to decode watch event" error is the root cause here. Same issue for Instance and Binding events.

@arschles so far I am actually unable to re-create this issue, although I have submitted the following manifest directly (i.e. I didn't use a Helm chart):
kind: Broker
apiVersion: steward.deis.io/v1
metadata:
  name: rds
  namespace: default
spec:
  url: http://<IP_ADDRESS>
  username: username
  password: password

Is it possible the source of the problem actually lies within the chart?

Note that I did encounter a different issue-- the catalog endpoint never go called on the underlying broker.

Ok... I spoke too soon. This popped up just after my previous comment:
16:23:47 ERROR k8s.broker loop.go:38 the watch channel was closed
16:23:47 CRITC framework.runner runner.go:57 watch closed
16:23:47 CRITC  main.go:35 error running steward-framework: watch closed

Note, however, that the "unable to decode watch event" bit is missing. That might challenge your assumption that that is the root cause... we might be dealing with the intersection of a couple different issues here.

@krancour I think the problem with the broker manifest that you listed above is that it's not in the steward namespace. are you still unable to repro this when installing it to that namespace?

Good catch. After creating this resource in the steward namespace, I am reproducing the exact same issue you reported.

#53 fixes the decoding error; closing.


IMPR/GRID-266 - First pass

@joneit As discussed before merging these breaking changes. We should bump to 1.1.0 instead of 1.0.8

@Dwaynekj We'll need a bullet list for the readme of exactly what breaks.


Add support for the same unique suffix to used in all resource naming

This PR updates the logic for the unique suffix used when naming resources deployed and applies the suffix to the display names of the two AAD app registration created.
Addresses comment by fajterini https://github.com/Azure/ipam/issues/69#issuecomment-1384248970 and acknowledged by DCMattyG
Added

Function New-UniqueIPAMDeployString
Variable $unique and $uniqueSuffix

Removed

Bicep param guid

Updated Flow

The deploy.ps1 script is started by the user
function New-UniqueIPAMDeployString called after initial setup and validation for the script occurs
-- Function creates a unique 13 character string of numbers and lowercase letters and stores in $unique
-- UIAppName and EngineAppName values are updated
-- The value of $unique is returned from the function
Function Deploy-IPAMApplications runs using the updated app name variables
Variable $unique is passed into into function Deploy-Bicep as the value for uniqueSuffix
Bicep Templates use uniqueSuffix value to build string variables for resource names

Deployment example

Hey there @cocallaw, thank you so much for submitting this PR. I will thoroughly review this later today and provide some feedback. I had already been working on a solution for this on my end, so I just want to make sure we take the most holistic approach to solving this problem.

At first glance, I see an issue with a use case where customers may have strict naming conventions for App Registrations and pass in a specific value for EngineAppName or UIAppName and don't want that modified with a uniqueString. Does that make sense @cocallaw?

I see what you are @DCMattyG, checking to see if the suffix could possibly be set somewhere else on the App Registration objects such as internal notes to help with identification if user has deployed multiple times or failure on deployment.

Perhaps a more "simple" solution is to check and see if the values do NOT match the defaults (provided at the top), which means a user has chosen a specific value. However, that doesn't address the other point that even if they do specify a value, what happens if the deploy fails and they need to redo it without creating the same SP's over and over.
In the latter case, maybe we just add a cleanup to remove the created App Registrations if the deployment fails for any reason. ?That may solve the problem outright without needing to append a suffix as the root issue was end users having overlapping App Registrations after many failed deployment attempts.
Thoughts?

The command New-AzADApplication has a -tag parameter that is defined as "Custom strings that can be used to categorize and identify the application" and appears to not be Azure Tags. Testing to see how the value of tag is exposed and options for filtering based on xyz value.
Could possibly store the suffix in tag, allowing users to specify any name they would like for the app registrations. To perform cleanup of the app registrations if the deployment fails, filter the registrations based on the value of tag if it matches the suffix, then require user confirmation before deletion.


Error: Network Error. Check console for details.

I use docker to deploy postman, and there is an error in requesting https://www.baidu.com. I confirm that my docker can access the domain name.

It's not an issue with PW. The endpoint: https://www.baidu.com doesn't allow Postwoman to fetch data. Servers can restrict specific URL based on different criterias such as geography.
Enable Proxy Mode (Settings > Proxy) to access such restricted endpoints. Proxy mode seems to be working.


Iss3

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a75508d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #11   +/-   ##
=========================================
  Coverage          ?   90.44%
  Complexity        ?       60
=========================================
  Files             ?       11
  Lines             ?      157
  Branches          ?       16
=========================================
  Hits              ?      142
  Misses            ?       14
  Partials          ?        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a75508d...28631a0. Read the comment docs.


chore(package): update @types/node to version 7.0.6

https://greenkeeper.io/
Fixes #83

there's a new branch for @types/node-7.0.8, closing this PR


feat: :sparkles: add possibility of providing default maxCount

Codecov Report
Base: 90.86% // Head: 90.86% // No change to project coverage :thumbsup:

Coverage data is based on head (eceddb1) compared to base (d0385d8).
Patch has no changes to coverable lines.

:exclamation: Current head eceddb1 differs from pull request most recent head 28e71c6. Consider uploading reports for the commit 28e71c6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   90.86%   90.86%
=======================================
  Files          27       27
  Lines         372      372
  Branches       50       50
=======================================
  Hits          338      338
  Misses         31       31
  Partials        3        3

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


DCOS-19290: Click to copy buttons should be adjacent to content being copied

In order to make the feature of the copy to clipboard button more visible, we moved the button
closer to the actual text.
CLOSES DCOS-19290
Testing
Launch a service with the following config:
{
  "id": "/nginx",
  "backoffFactor": 1.15,
  "backoffSeconds": 1,
  "container": {
    "portMappings": [
      {
        "containerPort": 8080,
        "servicePort": 10000,
        "name": "http"
      }
    ],
    "type": "MESOS",
    "volumes": [],
    "docker": {
      "image": "nginx",
      "forcePullImage": false,
      "parameters": []
    }
  },
  "cpus": 0.1,
  "disk": 0,
  "instances": 1,
  "maxLaunchDelaySeconds": 300,
  "mem": 128,
  "gpus": 0,
  "networks": [
    {
      "name": "dcos",
      "mode": "container"
    }
  ],
  "requirePorts": false,
  "upgradeStrategy": {
    "maximumOverCapacity": 1,
    "minimumHealthCapacity": 1
  },
  "killSelection": "YOUNGEST_FIRST",
  "unreachableStrategy": {
    "inactiveAfterSeconds": 0,
    "expungeAfterSeconds": 0
  },
  "healthChecks": [],
  "fetch": [],
  "constraints": []
}

Visit: http://localhost:4200/#/services/detail/%2Fnginx/endpoints
Trade-offs
N/A
Dependencies
N/A
Screenshots

:tada: This PR is included in version 2.84.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[DDW-1132] Improve spending password error handling

This PR improves spending password error handling on all screens where spending password needs to be entered.
Screenshots

Screenshot

Testing Checklist

Slack QA thread

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

@DeeJayElly changes look good! Please add a CHANGELOG entry 🙏

Added

@DeeJayElly I will merge it now. Please add a screenshot for Japanese language to the PR description.


Error install in armv7

    I tried install addon with docker command and it showed this:

Step 1/8 : FROM "ghcr.io/home-assistant/armv7-base:3.16"
---> 17155f6eba02
Step 2/8 : RUN apk add --no-cache git npm
---> Using cache
---> 6f939a915873
Step 3/8 : COPY . /
---> bb1bfa9bb8a7
Step 4/8 : RUN chmod a+x /run.sh
---> Running in b5fd5f71752c
Removing intermediate container b5fd5f71752c
---> 2ecd663a9b2c
Step 5/8 : RUN chmod a+x /finish.sh
---> Running in 426296d74b6d
Removing intermediate container 426296d74b6d
---> ece64c3aa5b0
Step 6/8 : RUN cd / && npm install -f
---> Running in c70cf5dc7e1c
using --force Recommended protections disabled.
ERR! code 1
npm ERR! git dep preparation failed
npm ERR! command /usr/bin/node /usr/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/root/.npm --prefer-offline=fa>
npm ERR! npm WARN using --force Recommended protections disabled.
npm ERR! npm WARN skipping integrity check for git dependency<EMAIL_ADDRESS>npm ERR! npm WARN deprecated<EMAIL_ADDRESS>The querystring API is considered Legacy. new code should use the URLSearchPar>
npm ERR! npm WARN deprecated<EMAIL_ADDRESS>Use your platform's native performance.now() and performance.timeOrigin.
npm ERR! npm ERR! code 1
npm ERR! npm ERR! path /root/.npm/_cacache/tmp/git-cloneDPnKgH/node_modules/sharp
npm ERR! npm ERR! command failed
npm ERR! npm ERR! command sh -c (node install/libvips && node install/dll-copy && prebuild-install) || (node install/can-compi>
npm ERR! npm ERR! sharp: Downloading https://github.com/lovell/sharp-libvips/releases/download/v8.12.2/libvips-8.12.2-linuxmus>
npm ERR! npm ERR! sharp: Please see https://sharp.pixelplumbing.com/install for required dependencies
npm ERR! npm ERR! sharp: Installation error: Prebuilt libvips 8.12.2 binaries are not yet available for linuxmusl-armv7
npm ERR!
npm ERR! npm ERR!  A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-12-02T16_30_09_169Z-debug-0.log
Originally posted by @jbr1989 in https://github.com/giuseppecastaldo/ha-addons/issues/3#issuecomment-1335525659

What does means "I tried install addon with docker command and it showed this", don't you have home assistant supervised?

    I tried install addon with docker command and it showed this:

Step 1/8 : FROM "ghcr.io/home-assistant/armv7-base:3.16" ---> 17155f6eba02 Step 2/8 : RUN apk add --no-cache git npm ---> Using cache ---> 6f939a915873 Step 3/8 : COPY . / ---> bb1bfa9bb8a7 Step 4/8 : RUN chmod a+x /run.sh ---> Running in b5fd5f71752c Removing intermediate container b5fd5f71752c ---> 2ecd663a9b2c Step 5/8 : RUN chmod a+x /finish.sh ---> Running in 426296d74b6d Removing intermediate container 426296d74b6d ---> ece64c3aa5b0 Step 6/8 : RUN cd / && npm install -f ---> Running in c70cf5dc7e1c using --force Recommended protections disabled. ERR! code 1 npm ERR! git dep preparation failed npm ERR! command /usr/bin/node /usr/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/root/.npm --prefer-offline=fa> npm ERR! npm WARN using --force Recommended protections disabled. npm ERR! npm WARN skipping integrity check for git dependency<EMAIL_ADDRESS>npm ERR! npm WARN deprecated<EMAIL_ADDRESS>The querystring API is considered Legacy. new code should use the URLSearchPar> npm ERR! npm WARN deprecated<EMAIL_ADDRESS>Use your platform's native performance.now() and performance.timeOrigin. npm ERR! npm ERR! code 1 npm ERR! npm ERR! path /root/.npm/_cacache/tmp/git-cloneDPnKgH/node_modules/sharp npm ERR! npm ERR! command failed npm ERR! npm ERR! command sh -c (node install/libvips && node install/dll-copy && prebuild-install) || (node install/can-compi> npm ERR! npm ERR! sharp: Downloading https://github.com/lovell/sharp-libvips/releases/download/v8.12.2/libvips-8.12.2-linuxmus> npm ERR! npm ERR! sharp: Please see https://sharp.pixelplumbing.com/install for required dependencies npm ERR! npm ERR! sharp: Installation error: Prebuilt libvips 8.12.2 binaries are not yet available for linuxmusl-armv7 npm ERR! npm ERR! npm ERR!  A complete log of this run can be found in: npm ERR! /root/.npm/_logs/2022-12-02T16_30_09_169Z-debug-0.log
Originally posted by @jbr1989 in #3 (comment)

What does means "I tried install addon with docker command and it showed this", don't you have home assistant supervised?

Yes, I have home assistant supervised in one raspberry and It show https://github.com/giuseppecastaldo/ha-addons/issues/3
I tried in other raspberry with home assitant supervised, but I can install docker containers with terminal and I show previous error.
I supose the error is "libvips 8.12.2" dependence who is incompatible with armv7 of raspberry.

Yes, I have home assistant supervised in one raspberry and It show https://github.com/giuseppecastaldo/ha-addons/issues/3
I tried in other raspberry with home assitant supervised, but I can install docker containers with terminal and I show previous error.
I supose the error is "libvips 8.12.2" dependence who is incompatible with armv7 of raspberry.

I tested the add-on on RPi 3 (Raspbian) & RPi 4 (Ubuntu) without problem. Try to downgrade NodeJS version by adding this in Dockerfile:
RUN npm install -g n && n 16.15.0

before this line:
RUN cd / && npm install -f


Support for scroller events

Hi, I'm using your wrapper and needed to bind some behavior to the scroll, in this case the 'scrollend' event (very useful to implement an infinite scroll).
To see how it worked in my solution I added this on the link of the directive;
if(attr.scrollend)
  element.bind('scrollend', function () {
    scope.$apply(attr.scrollend);
  });

and this on the html...
<scrollable scrollend="loadMyObjects()">

It worked like a charm.
Now that we are here, related to this particular event, there is a hack that causes this event to fire twice, maybe you could see if the hack is still needed.
Let me know what you think about this, thanks.

+1


Measures towards making venue more resilient to scraping errors

Setup LogDNA logging at the code level (ref:#146)
Fallback to crawlera triggered by any scraping error (ref:#208)
Points and ranking computations proceed regardless of any scraping error (ref:#208)
Exponential back off in retrying scraping and raise at error at max retries (ref:#208)

I'm looking at the logging right now, and this just doesn't look right:

Over and over "Scraping forum profile started": maybe if you specified the profile number which was scraping it would be more useful. But in fact, I think better would simply say "Starting scraping 7 forum profiles" or something like that so that the log doesn't get so full. I do like the scraping failures, but it should also specify which profile has an issue. And also, did crawlera work or fail? There is no info on that.

@shawnlauzon you can see more info:

About the crawlera, I found an error with the HTTPS and made a PR. And I'm not sure what is the status of the crawlera token.

@alexdashkov I reviewed your latest commits. All good! Thanks for dealing with my mess in the CI config and for improving the scraping tests to use mocks. 👍


Issues with lists of immutable objects after upgrading to the new plugin interface

Branch netbox32-changes
I know @jeremystretch already mentioned that in his PR #128, but since that one is closed I would rather raise a separate issue so it's not forgotten.
As there is currently no supported way to inhibit the edit/delete buttons for objects that can't be edited or deleted, some strange behaviour is taking place in the "Managed Records" list views.

In the "Allen wrench"-submenu on the right side of the table, the Options "Edit" and "Delete" are displayed. However, actually using them leads to an error message that might be really misleading:

/plugins/netbox-dns/records/27/edit/
The requested page does not exist.

or, for "Delete":
 /plugins/netbox-dns/records/27/delete/
The requested page does not exist.

As mentioned by Jeremy, the "Edit" and "Delete" buttons are displayed at the bottom of the table
The checkboxes for selecting items for editing or deletion are displayed although they shouldn't be
The checkboxes for selecting items for editing or deletion are displayed right left to the "Allen wrench" submenu instead of at the beginning of each row
Selecting items and then clicking on the "Edit" or "Delete" button results in a warning "No items were selected" (which is definitely untrue, although better than actually trying to edit/delete)

I expect all of these issues to go away as soon as there is a mechanism that allows to disable the edit/delete functionality in object lists.

Fixed by #133, #129