Optimization for Miller Rabin < 2^81

My reading of the code which calls Miller-Rabin, is that - after a trial division against the smallest primes - it then does 64 M/R rounds with random witnesses against all numbers of 512 bits and smaller.
However, something mentioned at the Wikipedia page for M/R, and is something that I don't see the OpenSSL code doing, is that odd numbers as large as 2^81 can be deterministically proven as prime vs composite with as few as 12 specific witnesses, and there are ranges of numbers below that which can be 100% proven with many fewer witnesses than that.
Wikipedia lists many ranges having the same witness count, so it's probably just as fast to branch only for the largest range at each witness count:
if (n < 18,446,744,073,709,551,616) {
if      n < 2,047, 1 witness a = 2;
else if n < 9,080,191, 2 witnesses a = 31 and 73;
else if n < 4,759,123,141, 3 witnesses a = 2, 7, and 61;
else if n < 1,122,004,669,633, 4 witnesses a = 2, 13, 23, and 1662803;
else if n < 2,152,302,898,747, 5 witnesses a = 2, 3, 5, 7, and 11;
else if n < 3,474,749,660,383, 6 witnesses a = 2, 3, 5, 7, 11, and 13;
else if n < 341,550,071,728,321, 7 witnesses a = 2, 3, 5, 7, 11, 13, and 17.
else if n < 3,825,123,056,546,413,051, 9 witnesses a = 2, 3, 5, 7, 11, 13, 17, 19, and 23.
else if n < 18,446,744,073,709,551,616, 12 witnesses a = 2, 3, 5, 7, 11, 13, 17, 19, 23, 29, 31, and 37.
}
else {
normal call with 64 witnesses
}
Even though this optimization can allow results that are proven prime, not merely probable, I assume it would break fuctionality to change the return code to reflect that.
The existing code does not appear to check whether it's calling the same witnesses again, but the chance of that is extremely small, and is even less likely if the above optimization eliminates random witnesses being used in the smaller ranges.

There is some FIPS related code for RSA that uses ossl_bn_check_generated_prime() internally. This passes a parameter for the number of checks depending on the bitsize.

Primes <2⁶⁴ is pretty small in a cryptographic context.  Even 2⁸¹ is too small for a cryptographicly useful prime.
So, while the optimistaion makes sense in a general purpose long integer mathematics library, it's not particularly relevant for cryptography.
One could argue that OpenSSL's bignum code is a general purpose mathematics library & it certainly has been used as such.  However, changes to introduce things like blinding and timing resistance are detrimental for general purpose use but critical for cryptographic use.
We'd consider a pull request introducing this change, but honestly it's never going to be a high priority item for the project team.

marking as inactive, will be closed at the completion of 3.4 dev without further input


An error occurred: Could not resolve host: security.sensiolabs.org.

An error occurred: Could not resolve host: security.sensiolabs.org

The security.sensiolabs.org endpoint has been shut down. You need to use security.symfony.com now (probably by upgrading the security checker to version 5), see also sensiolabs/security-checker#149.


chore: remove setuptools_rust as runtime dep

https://discord.com/channels/854262008589058058/854268209497767986/1151367560923725844
@jbemmel

See https://github.com/napalm-automation-community/napalm-srlinux/commit/4916f47e5b971e2c13cf086d5d262828e793fdce, I prefer to only remove setuptools_rust first
Not clear why we'd need the 'wheel' package - would like to understand the workflow


I am wondering if version 0.6.0 (Aug. 13, 2017) is available.

Hi
Re: android-ocr
I am wondering if version 0.6.0 (Aug. 13, 2017) is available. I have installed this version on my phone and it works VERY well.
I wanted to set it up for a friend so that he can scan in 2-3 line address labels. That way he won't have to type them in.
But I need to modify the code so that I can automate the process a but more, else I would use what I have as it is.
The version here seems to be V 0.5.14 (May 11, 2014)
Thanks in advance
Robert.

No, I don't plan to release it, because the expansion file code adds some complexity that I don't want to write instructions for or support, and the expansion file itself is too large for Github.
That said, the OCR code is the same in 0.6.0 as in the current version, it just uses tess-two 8.0.0 instead of tess-two 6.0.4. So the current version should meet your needs for the address label scanner I believe.


support both sqlalchemy engines and connections

Fixes #7877

This looks good and would also resolve #7877 I believe.
I think some tests will probably be requested.

@graingert Thanks for working on this!
Certainly look also to the discussion in #7877. At the end there is link to a patch of @tr11 which does something similar.
Some quick thoughts:

indeed, as @artemyk mentions, this needs some tests.
I think this will not work for to_sql and read_sql_table? (how you implemented it now, but is should work for those as well)

@graingert Some of the tests keep on running. I already restarted them a few times, so it seems this is caused by this PR. Did you try to run the tests locally? (only the sql tests is enough)

@jorisvandenbossche I've debugged all the tests.
Once the travis builds pass I'll remove Fix TestXMySQL and increase verbosity so I can see what's going wrong

I think Fix TestXMySQL should probably go in another PR

@jorisvandenbossche @artemyk I can't replicate the issues in  4b2f087...1037144 do you have any ideas?

@artemyk @jorisvandenbossche I'm pretty sure I've got it now.
I'll clean up this PR with a repo tomorrow

When running with two queries at the same time, if one raises a warning and the other doesn't PyMySQL raises a TypeError.
        proc = """DROP PROCEDURE IF EXISTS get_testdb;
         CREATE PROCEDURE get_testdb ()

         BEGIN
             SELECT * FROM test_procedure;
         END"""

The DROP PROCEDURE was raising a warning on Travis because the get_testdb procedure was missing, however on my local machine I was not destroying/rebuilding the database each test run which meant I still had the "get_testdb" procedure.

@graingert Glad you've figured it out. I'm not sure execute necessarily supports multiple statements, for example some DBAPIs (including PyMySQL if I'm not mistaken) have an executemany method for this purpose.

@artemyk executemany is for executing one statement with multiple parameters, not multiple statements.

@graingert Thanks for the updates! some questions:

What was in the "Fix TestXMySQL" commit?
The problem with the stored procedure, this is only with a connection, not with an engine? In that case, maybe good to keep the original test for engine only (skip when connection), in addition to your adapated test.
What was the problem with the pymysql version exactly?

XMySQL is only a problem on my local machine, I've got another PR for that
fix
Using pymysql 0.6.6 this error occurs in whichever test case runs first so
it's fine to run like this on the engine and the connection.
Using pymysql 0.6.3 'has various bug fixes' so I'm not sure what the actual
bug was.
On 29 May 2015 11:06 am, "Joris Van den Bossche"<EMAIL_ADDRESS>wrote:

@graingert https://github.com/graingert Thanks for the updates! some
questions:

What was in the "Fix TestXMySQL" commit?
The problem with the stored procedure, this is only with a
connection, not with an engine? In that case, maybe good to keep the
original test for engine only (skip when connection), in addition to your
adapated test.
What was the problem with the pymysql version exactly?

—
Reply to this email directly or view it on GitHub
https://github.com/pydata/pandas/pull/10105#issuecomment-106763509.

There was a problem before with pymysql 0.6.6, see https://github.com/pydata/pandas/issues/9608 (but could never reproduce this locally)

Not sure what that issue is. This will work on 0.6.3 as well
On 29 May 2015 11:15 am, "Joris Van den Bossche"<EMAIL_ADDRESS>wrote:

There was a problem before with pymysql 0.6.6, see #9608
https://github.com/pydata/pandas/issues/9608 (but could never reproduce
this locally)
—
Reply to this email directly or view it on GitHub
https://github.com/pydata/pandas/pull/10105#issuecomment-106765664.

So if I understand correctly, the problem with the test_read_procedure test is caused by pymysql (it works for me with pymysql 0.6.2, but errors with 0.6.6).
Is there a reason to change the pymysql version on travis? (your second commit) Or can we keep the older version there untill this is fixed on the pymysql side, and then keep the test as it was before.

There's two bugs. One with pymysql 0.6.1 (dodgy cursors) and one with pymysql 0.6.6 (bad multi statement warnings).

Ah, yes, but you said that with 0.6.3 the first one (dodgy cursors) is also solved? Then maybe use 0.6.3 instead of 0.6.6, and then the procedure test does not need to be changed?

@jorisvandenbossche yeah looks like it works fine with 0.6.3

@jorisvandenbossche yeah the Travis tests pass on 0.6.3 what's your thoughts on a merge?

@jorisvandenbossche casual nudge

@graingert Thanks for the nudge :-)
This further needs:

a notice in the whatsnew file (see doc/source/whatsnew)
update to the docs: both all docstrings and the tutorial docs (see doc/source/io.rst)
I think we should put in an explicit test that the desired behaviour works (and keeps working). Now it is only tested that the existing tests also run with passing a Connection, but we should add a test (only for when using Connection) that the example you give in the issue your reported works)

pls rebase on master, some issues have been fixed with the builds

@jorisvandenbossche done @jreback yep, rebase fixed those issues thanks.

@jorisvandenbossche @jreback casual nudge

@jorisvandenbossche @jreback hey guys, I really need this feature in production... can you guys merge this if you think it's useful

@graingert lgtm, but @jorisvandenbossche may have some more comments.
if you are actually running off of master (in production)?, then you can just merge this into your local master. This would be in 0.17.0 which won't be out for prob 2 months.

Sorry for the slow response. But I will look at it this evening, I promise!
Short comment: ideally, I would like to see a test that now fails (so a test that is only run for the test class that uses a connection, and not an engine), to be sure that with a later refactor this ability is not lost again.

@jorisvandenbossche that test is added here: https://github.com/pydata/pandas/pull/10105/files#diff-052a926a9b2c33a84e27d51c8fad3466R1372

Yes, I saw that, but if I understand correctly, this test is ran for both the engine tests as the connection tests?
I was thinking that this enhancement adds something that was not possible now with engines (a use case for which you need the connection, and can't use the engine)? Eg using a temporary table. So it would be useful to have a test with such a use case, so we ensure that such functionality keeps working.

Ah I see what you mean

Ah I see what you mean

Thanks for adding the temp table test! Gave it a last round, see last comments.
Last question: can you squash the commits? Then I will merge when it is green again

fixed, rebased, squashed It's party time: :cake: :sparkles:

@graingert Thanks a lot! (for the contribution, and also for the patience ..)

Woot, thanks very much!


other players facing south when first logging in

Simple fix, players are facing south on the client that just logs in for the first time:
Client 1: player logged in and is facing north
Client 2: player logged in and now on client 2 screen shows client 1 facing south but on client 1 screen client 1 is facing north.

This is how it works on RuneScape, I'm pretty sure..

@ryleykimmel it shouldn't be like that

Pretty sure it is, man.
https://twitter.com/runescape/status/532322387228753920

Client 1 = bob
Client 2 = tom
bob logs in and moved to face north
tom logs in faced south (default)
tom looks at bob who is faced south on his screen
bob is faced north and tom is faced south on his screen.
Is that right? Sounds like when a new client logged in, everyone who is logged in is faced south for that new client even though on their client, they are not.

@ryleykimmel @WizardJesse1
Issue is not you logging in facing south. You see other players that are facing another direction facing south not in accordance to what that player sees on their client.

Right, everyone faces south when you log in, including yourself.
Just logged into RS all facing south by default: http://i.imgur.com/Deq8lap.png

Dammit @ryleykimmel you always have to be right lol

Not an issue.


November 2020 Release Plan (v1.13.0)

Timeline

November 13, 2020: Code freeze
November 16-24, 2020: Release Candidate(s) and testing
November 25, 2020: Full Release

Features
Global

Upgrade to latest Carbon (https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/4272)

Web Components
Features

card-section:  introducing web component versions (#4471)
content-group-cards:  create web component (#4487)
leaving-ibm:  Leaving IBM modal web component (#4453)
content-group-horizontal:  create web component (#4435)
Masthead:  add mobile megamenu (#4443)
megamenu:  megamenu desktop web component (#4384)
cta-section:  web component version (#4338)
callout with media:  web component version (#4343)
content-item-horizontal:  create web component (#4389)
logo-grid:  web component created (#4371)
logo-grid:  web component created (#4287)
content-section:  web-component version (#4275)
image-with-caption:  support responsive image (#4312)
callout-quote:  web-component created  (#4228)
leadspace:  leadspace web component (#4084)
feature-flag:  adding feature flag capability in web components (#4220)

Fixes

modal:  remove close button offset for full-width mode (#4299)
Images:  update FPO images url (#4482)
cta-section:  aligning link list with other text elements (#4461)
feature-card:  fix icon position (#4412)
image-with-caption:  a11y fixes (#4395)
Footer:  update readme (#4409)
content-block:  fix layout (#4397)
styles:  ensure dds-prefix variable is included (#4396)
table-of-contents:  ensure anchor is visible upon jump-to-content (#4297)
button-group:  eliminate duplicate outline (#4350)
button-group:  fixed focus outline going past the buttons on web components (#4348)
quote:  fixed spacing for closing quote (#4288)
feature-card-block-medium:  update web component layout (#4323)
table-of-contents:  fix header space (#4298)
card link:  focus styles (#4318)
quote:  adjust quote grid classes in storybook (#4304)
locale-modal:  ensure input field is cleared on reset (#4296)
masthead-search:  stop toggling active state on focus (#4295)
linklist:  fix linklist focus styles (#4271)
table-of-contents:  support dark theme (#4213)
footer:  ensure IBM logo icon is visible (#4226)
feature-card:  remove redundant flex-wrap (#4176)
masthead-search:  re-apply #3932 (#4227)

React
Features

Masthead:  add search custom events (#4460)
megamenu:  megamenu desktop web component (#4384)
Masthead:  React masthead alternate logo and tooltip options (#4401)
leadspace-with-search:  introducing new pattern (behind feature flag) (#3987)
overflow:  add animation and update snapshots (#4305)
leadspace:  leadspace web component (#4084)
LightboxMediaViewer:  allow user override vid title/desc (#4238)
feature-flag:  adding feature flag capability in web components (#4220)

Fixes

cardgroup:  update sameheight selectors (#4484)
masthead:  add aria-hidden to overflow nav carets (#4489)
Images:  update FPO images url (#4482)
Footer:  update readme (#4409)
masthead:  remove console errors (#4404)
masthead:  overflow tabbing adjusted (#4381)
language-selector:  update language selector to use select (#4335)
masthead:  update overflow scrolling positions (#4333)
feature-card-block-medium:  update web component layout (#4323)
masthead:  selected item accessible to screen reader (#4302)
megamenu:  added protection to fix layout problem (#4290)
lightbox-m-viewer:  adding again autoPlay to video (#4289)
Masthead:  have nav item render with selected styles in mobile nav (#4259)
lightbox-m-viewer:  removing autoplay from VideoPlayer (#4258)
modal:  add primary focus on open (#4242)
table-of-contents:  support dark theme (#4213)
footer:  ensure IBM logo icon is visible (#4226)

Styles
Features

content-group-cards:  create web component (#4487)
content-group-horizontal:  create web component (#4435)
megamenu:  megamenu desktop web component (#4384)
cta-section:  web component version (#4338)
Masthead:  React masthead alternate logo and tooltip options (#4401)
callout with media:  web component version (#4343)
content-item-horizontal:  create web component (#4389)
logo-grid:  web component created (#4371)
leadspace-with-search:  introducing new pattern (behind feature flag) (#3987)
logo-grid:  web component created (#4287)
overflow:  add animation and update snapshots (#4305)
tag:  expressive theme update (#4166)
callout-quote:  web-component created  (#4228)
leadspace:  leadspace web component (#4084)

Fixes

modal:  remove close button offset for full-width mode (#4299)
feature-card:  fix icon position (#4412)
megamenu:  fix scrollbar styles (#4417)
Footer:  fix micro footer button css (#4415)
styles:  ensure dds-prefix variable is included (#4396)
content-item-horizontal:  fix heading styling (#4402)
content-group-mixed:  fix pictogram item row on md breakpoint (#4282)
table-of-contents:  ensure anchor is visible upon jump-to-content (#4297)
language-selector:  update language selector to use select (#4335)
masthead:  update overflow scrolling positions (#4333)
quote:  fixed spacing for closing quote (#4288)
feature-card-block-medium:  update web component layout (#4323)
table-of-contents:  fix header space (#4298)
card link:  focus styles (#4318)
megamenu:  added protection to fix layout problem (#4290)
linklist:  fix linklist focus styles (#4271)
FeatureCard:  remove unused styles (#4243)
Masthead:  have nav item render with selected styles in mobile nav (#4259)
table-of-contents:  support dark theme (#4213)
footer:  ensure IBM logo icon is visible (#4226)
feature-card:  remove redundant flex-wrap (#4176)

Services
Features

Masthead:  React masthead alternate logo and tooltip options (#4401)
locale:  introducing cache busting logic (#4325)
translation:  introduce cache busting logic (#4240)

V1.13.0 has been released


Kyverno Policy Reporter writes extensively on node disk storage in certain ocassions.

We have noticed that the Kyverno Policy Reporter writes extensively on Node's disk storage in certain scenarios and we end up getting the below alert
 The node was low on resource: ephemeral-storage.
We want to identify the steps to debug this scenario of policy reporter writing extensively on node's disk and accordingly decide on the solution ?

Hey, Policy Reporter only writes to disc when it updated its internal SQLite DB, which is file based. It could happen when a large amount of Policy Reports are updated/recreated in a short amount of time. Which leads to reprocessing each PolicyReport and updating the Database.
Do you using it in combination with Kyverno?
If so, which Kyverno version do you using?
Is it a larger cluster where this iossue happens?
On possible solution you can try right now is to use an alternative Database instead of the internal SQLite DB, supported DBs are Postgres, MySQL and MariaDB.

Do you still have issues or any feedback?


SCA scan automation using Dependency Check

IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #[issue number] or Closes #[issue number]
Engineer Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[ ] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app

Code Reviewer Checklist

[ ] I have verified Unit tests have been written for any new feature(s) and edge cases
[ ] I have verified any strings visible on UI components are in the strings.xml file
[ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
[ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
[ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Closing this. Implementation Merged via https://github.com/opensrp/fhircore/pull/2659


rework purge playbook with ceph-disk commands

only for jewel: https://github.com/ceph/ceph/pull/5867

As a note, the purge playbook also doesn't work with the osd directory scenario.

Implemented and part of this playbook now: https://github.com/ceph/ceph-ansible/blob/master/infrastructure-playbooks/shrink-osd.yml


Added more TextField attribute options for ReactiveTextField

Fixes #41

Hi @danvick,
I have release 10.0.0. I have added some missing properties. Please update your version, and then you can contribute with some missing property.
Thanks and best regards


fix channel bug

Codecov Report

Merging #121 into dev will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                dev     #121   +/-   ##
=========================================
  Coverage     16.19%   16.19%
  Complexity      795      795
=========================================
  Files           451      451
  Lines         15187    15187
  Branches       1624     1624
=========================================
  Hits           2460     2460
  Misses        12483    12483
  Partials        244      244

Impacted Files
Coverage Δ
Complexity Δ

.../org/fisco/bcos/sdk/channel/ChannelMsgHandler.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4caf563...bea5929. Read the comment docs.


Refactor

Renaming

ApplicationBinder :arrow_right: SpaceEnroller
AutosleepServiceInstance as SpaceEnrollerConfig
AppStateChecker :arrow_right: ApplicationStopper

Deletion

ApplicationBinding as an application object: information must be available on ApplicationInfo

Groupment
Use three blocks:

Broker and UI as service entry points
Watch part
Database part

Other

Keep full log and full event and not just date
Delete redis

@gberche-orange : do you known why delete service binding request does not contain the application id?


make.go: Can't build reactGen

  $ go run make.go
can't load package: package perkeep.org/vendor/myitcv.io/react/cmd/reactGen: cannot find package "perkeep.org/vendor/myitcv.io/react/cmd/reactGen" in any of:
	/usr/local/Cellar/go/1.10.1/libexec/src/perkeep.org/vendor/myitcv.io/react/cmd/reactGen (from $GOROOT)
	/Volumes/Code/heath-it/camlistore/src/perkeep.org/vendor/myitcv.io/react/cmd/reactGen (from $GOPATH)
Error building reactGen: exit status 1
exit status 1

Looks like it's adding 'perkeep.org' before vendor/ which is causing it to not be able to find the package.

Just to confirm, this is against 951e9a45bf2af51932da39ef05f263b59d55b239?

951e9a45, yep. Looks like make.go now only works if you checkout the repo to $GOPATH/src/perkeep.org (previously I'd not had trouble building elsewhere).

I suspect changing this line to:
return buildBin("./vendor/myitcv.io/react/cmd/reactGen")

will fix that, but:

This suggestion is totally untested :)
cc @mpl as to whether we even want to do this

Looks like make.go now only works if you checkout the repo to $GOPATH/src/perkeep.org (previously I'd not had trouble building elsewhere).

Yeah, that was an unfortunate regression we forgot about when we removed the tmp/buildpath-* cloning.
But I think we'll live with it for now.
Now that there's an implicit $GOPATH at least, we can just make make.go tell the user where the perkeep.org checkout needs to be.


Redirects to my default browser

I made an app "Google search" with the help of command [ nativefier "https://google.com" ], but when I tried to open a website through google search like "Youtube" or "bing" it just redirects to my default browser and opens up the respective website there. Furthermore it is using an older version of chrome.

@akash86167

"when I tried to open a website through google search like "Youtube" or "bing" it just redirects to my default browser"
→ Expected behavior; see --internal-urls flag.
"it is using an older version of chrome"
→ No, the latest Nativefier uses the latest Electron which uses the latest Chrome stable. Feel free to use flag -e to specify the Electron release you want. Note that once a Nativefier app is built, it won't update, unlike Chrome, and you have to re-build. The "having to rebuild" part is intended, but we should do a better job at warning users, see #556.


[CI] update rspec-benchmark

Describe the change
update rspec-benchmark from -> 0.4 to -> 0.6 on supported rubies
Why are we doing this?
fixes a failure on ruby-head
Benefits
How will the library improve?
ci
Drawbacks
rspec-benchmark 0.5 dropped support for Ruby < 2.1. Note that even Ruby 2.4 is already EOL, maybe you should consider removing support for some EOL rubies.
Requirements
Put an X between brackets on each line if you have done the item:
[] Tests written & passing locally?
[] Code style checked?
[] Rebased with master branch?
[] Documentation updated?

Coverage increased (+20.9%) to 98.829% when pulling e395c0956f6cef76628ac30ea0e280dcc9bf5f1b on ahorek:update_rspec_benchmark into d38b5878ea06875e5313a5e144be14a9b8041082 on piotrmurach:master.

Thanks ❤


[Loc] another update to resource-deployment and sql-migration

This PR fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.536%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26115

Relevant Lines:
56987

💛  - Coveralls


Minimap right click option to clear the current path conflicts with the zoom functionality in the Minimap plugin.

Mostly a fyi i suppose:
In the 1.9.0 version of Runelite the standard minimap plugin now support a "Zoom" feature for the minimap. If this feature is used, it will cause a right mouse click on the minimap to reset the map to the default zoom level.
This seems to conflict with the shortest path plugin, as it uses a right click on the minimap to display a context menu allowing the user to reset the current path. (This is still possible from the full world map though).

A workaround to this problem was released in version 1.9.3 which involves an additional right-click Clear Path option on the minimap world map icon button. Restart your client to fetch the update.


net: Prototype a TLS convenience API based on sockets

As discussed during Zephyr Networking Forum meetings, mentioned in https://github.com/zephyrproject-rtos/zephyr/pull/5854 , etc., currently there're not even examples, far less best practices, on using TLS communication over BSD Sockets. (The same applies to DTLS, but this ticket is dedicated to TLS specifically.)
This ticket is intended to bootstrap/track this work, and establish requirements for implementation.

@d3zd3z pointed at:
https://www.openbsd.org/papers/linuxconfau2017-libtls/#slide-0
Something to look at for ideas.

@mbolivar : Comments/criticism welcome.

Thanks! I'd be interested to see the results, but I'm afraid my input isn't likely to be useful.

Thanks! I'd be interested to see the results, but I'm afraid my input isn't likely to be useful.

Ok, I assume that at least means you don't see anything terribly wrong with it ;-).

Keeping in mind the need to accommodate the secure socket offloading, I'd like to share some links which were shared in an earlier internal email thread:

The SimpleLink SDK proposes a secure socket design that I thing is
quite elegant.
All secure connection setup is done via setsockopt() calls, then the
rest of the application logic
is the same as if using unsecured sockets.   The security handshakes occur
"under the covers" during the socket connect() and accept() calls.
See Section 2.2, "Secure Socket Layer",
http://www.ti.com/lit/an/swra509a/swra509a.pdf
For an example application, see:
http://dev.ti.com/tirex/content/simplelink_academy_cc32xxsdk_1_13_00_29/modules/wifi_secure_socket/wifi_secure_socket.html

The TCPClient function at the bottom shows some actual code.

Even if we decide not to use socket-like APIs for TLS setup the way TI does, the main point here is that, though the Zephyr NET_OFFLOAD solution would allow secure socket data transmission to be offloaded, the *setup (at least for SimpleLink) must occur via these setsockopt calls, which would probably need to be hooked from this new proposed "TLS convenience API".
For that reason, I think the connection/configuration APIs should be included in the scope of this proposal, similar to what is done here:
https://www.openbsd.org/papers/linuxconfau2017-libtls/#slide-16

A couple comments on creating a new "stream" API:

First we argue that networking protocols should be based on sockets; now the argument is no, they are to be based on generic stream objects.  And if that's the case, should this also be the new interface for all device drivers?

That's OK, but we should realize, if that's the case, it's a much larger scope than making a "TLS convenience layer" ;-)

The connection aspect:  how would listen, accept: work with streams.   Would UDP or RAW_SOCK work under the stream interface?

Let me quick reply to these so far:

First we argue that networking protocols should be based on sockets; now the argument is no, they are to be based on generic stream objects.

No, we don't argue all that, at once. The arguments are actually layered:

The first argument is that sockets is the de-facto and de-jure (POSIX) API for network programming, used for decades, and that the best approach is to have that as system-level API, to get the benefits of that standardness and history (which includes porting existing application written against Sockets API, which are many).

However, during few recent years, TLS is getting more and more important and prominence, which is above-system-level interface. And the second argument is that applications should be able to deal with either plain or TLS-wrapped protocols with as at least as possible code duplication and separation (i.e. 2 different implementations of the same protocol shouldn't have 2 different implementations - one TLS-enabled and one not). So, we construct appropriate interface, sitting above sockets to achieve that.

A key point is that 1) (sockets API) is "one for everyone out there", while 2) (Zephyr's TLS API-on-top-of-sockets) is a just a particular implementation of a TLS API, among many available. They're layered like that, and sufficiently independent, e.g. someone may use another TLS API, or another socket implementation (e.g. offloaded) with the proposed TLS API.

The connection aspect: how would listen, accept: work with streams.

Simple answer: they won't. The stream interface abstracts bidirectional peer-to-peer communication in terms of bytes (vs e.g. in terms of records). Socket interface is superset of stream interface, but we don't define it. That means that a server will be implemented in terms of plain sockets, and once connection is accepted, only then in will be wrapped with TLS (that's of course how it works anyway, the point is that we don't try to abstract that in any way).

Would UDP or RAW_SOCK work under the stream interface?

Nope, because they aren't "communication in terms of bytes". UDP would be "communication in terms of records (datagrams)", but I'd need to do more homework on DTLS. One concern, as pointed by @d3zd3z is that DTLS-enabled protocols are/seems to have tighter coupling between layers. We may need to define a separate "interface" for UDP/DTLS.
As for RAW_SOCK, IIRC, they allow to send full IP packets (with headers, etc.). How that would map onto (D)TLS is unclear, I never heard about that. If/when someone formulates the requirements how that's supposed to work, it will be yet another, separate usecase.

Sorry, missed to answer this one:

And if that's the case, should this also be the new interface for all device drivers?

Conceptually and semantically yes, more specifically, I think we should follow POSIX I/O model, with read/write operations and their properties (like short read and short write semantics).
However, it apparently would be far-fetched to impose interface outlined here ("streams vtable") on all device drivers. At the very least, besides "stream of bytes" model, there's another model - "stream of records" with its own semantics differences.
Trying to devise "grand unified interface" (implementational interface) for everything will lead us to bloat, e.g. https://en.wikipedia.org/wiki/STREAMS . I hope we go in the opposite direction - reuse existing experiences and best practices to design an interface scaled down for a bare minimum required to implement a specific functionality adequately.

@GAnthony :

need to accommodate the secure socket offloading
All secure connection setup is done via setsockopt() calls

Right, so if TI API allows to create a plain socket and then convert it to TLS via setsockopt() calls, then this proposal covers such an implementation. We probably would need to go further C++ way, and add a bit of RTTI, in the shape of e.g. ->get_type(), to allow different stream types to differentiate each other (for full generality).
The flow this proposals entails is something like:
int sock_fd = socket(...);
stream *sock_stream = make_sock_stream(sock_fd);
stream *tls_stream = make_tls_stream(sock_stream, ...);

mqtt_client(tls_stream, ...);

So, as long as make_tls_stream() recognizes passed-in stream as backed by TLS-offloadable socket, it can configure it as need.

For that reason, I think the connection/configuration APIs should be included in the scope of this proposal, similar to what is done here:
https://www.openbsd.org/papers/linuxconfau2017-libtls/#slide-16

So, as I mentioned during today's discussion (on Linaro side for context), let's keep scope of the current work manageable. Let's remember that our immediate aim of this work is "how to make socket-based protocol implementations which can work with both plain and TLS sockets with as close to 100% code reuse". So, we can and will "prototype" TLS connection/configuration API, but can't "standardize" on all aspects of it (in the timeframe posed, which is to have a working proof of concept in 1 month) - not without close and parallel involvement of security people, but even then I doubt we can "standardize" on all aspects of it (like e.g. offloading handling).

Right, so if TI API allows to create a plain socket and then convert it to TLS via setsockopt() calls,

http://www.ti.com/lit/an/swra509a/swra509a.pdf, section 2.2.6, hints that's possible, but the user must explicitly re-invoke accept() or connect() to upgrade security.  It's not the normal mode of operation.
But why would that be necessary?  Wouldn't the IP protocol normally already know that it intends to deal with a secure socket, and create such a socket from the outset?  (I know there are exceptions to the rule, but why not design for the expected case?).  It seems the client must know it will be a secure socket, because it's calling stream *tls_stream = make_tls_stream(sock_stream, ...);
So, the socket could be created with something like fd = socket(AF_INET, SOCK_STREAM, PROTOCOL_SEC_SOCKET), where 'PROTOCOL_SEC_SOCKET' could be our flag to prepare a secure socket, ready to be configured with subsequent setsockopt() calls.
Note: From the POSIX standard on socket(): "The protocols supported by the system are implementation-defined."

but the user must explicitly re-invoke accept() or connect() to upgrade security.

That's not my reading of that document:

The user must trigger the SSL/TLS handshake explicitly, irrespective of the socket connection (triggered by either sl_connect or sl_accept APIs).

"Irrespective" should give enough hints, but let's call it non-conclusive still. http://www.ti.com/lit/ug/swru455d/swru455d.pdf section 6.5.7 gives more specific information. It's still a bit confusing, because it start with talking about STARTTLS which is application protocol level feature, but following should clarify it:

Calling sl_SetSockOpt with the STARTTLS option triggers the NWP, in client mode, to send the client HELLO message, and in server mode to wait until the client HELLO message is received.

(Assuming "client HELLO" is TLS' ClientHello: https://en.wikipedia.org/wiki/Transport_Layer_Security#Basic_TLS_handshake)
So, TI SimpleLink should support normal socket vs TLS layering (while provides convenience API to do it all in one go).

Wouldn't the IP protocol normally already know that it intends to deal with a secure socket, and create such a socket from the outset?

Responding to that literally, IP protocol doesn't know anything about secure sockets, it just carries opaque data.

It seems the client must know it will be a secure socket, because it's calling stream *tls_stream = make_tls_stream(sock_stream, ...);

Right, so it's the higher(est) level which has (can have) the complete vision of what happens on the lower levels. And yes, we could have stream *tls_stream = make_ti_sl_tls_stream(...);, this proposal exactly allows that. But as mentioned above, such things outside of the primary scope (of the first phase) of this proposal. Because we won't be able to find fully general solution in a month ;-).

Note: From the POSIX standard on socket(): "The protocols supported by the system are implementation-defined."

Yes, but how sockets got popular is that there's common, portable (sub)set of protocol which work on (almost) every system. There's no PROTOCOL_SEC_SOCKET on other systems beyond TI SimpleLink, so it doesn't make sense to base the design base on it. Or we'll really have a contradiction, saying "sockets is standard API, it allows for portability across systems", and as the next step add  non-standard, non-portable thing to its implementation.
As I tried to elaborate above, I propose to clearly split layers: sockets don't belong to us, we just implement them as faithfully as reasonably possible with our constraints. Above sockets, the space belongs to us, and we implement things there to best suit our needs (which are apparently generality and minimal code size).

Result of first iteration on implementation was posted as https://github.com/zephyrproject-rtos/zephyr/pull/5985 , which should give better look&feel of the proposed API.
What was not discussed in this ticket is allocation matters, but of course, they surface in the real usage. The basic is that space for a particular type of stream object is allocated by client, and there's an initializer which takes an allocated pointer. But for server use, we'd need to deal with array of objects. It's tempting to leave that to client still, but would need to see how cumbersome that looks when a server apps is converted, that's next in queue.

The Wikipedia page on TLS has an interesting comment about why this API is hard to do:

TLS and SSL do not fit neatly into any single layer of the OSI model or the TCP/IP model.[7][8] TLS runs "on top of some reliable transport protocol (e.g., TCP),"[9] which would imply that it is above the transport layer. It serves encryption to higher layers, which is normally the function of the presentation layer. However, applications generally use TLS as if it were a transport layer,[7][8] even though applications using TLS must actively control initiating TLS handshakes and handling of exchanged authentication certificates.

In addition, Zephyr is likely to run into additional complexity because certificates and certificate chains are often too heavy to implement in a constrained device, and it is necessary to use other ciphersuites, such as PSK or bare pub/priv keys.

As far as allocation, the underlying cipher, esp the asymmetric algorithms used for certificate management expect there to be an implementation of malloc/free. mbed TLS includes an implementation (that in my experience is significantly better than the tiny one included in Zephyr). Needless to say, though, that determining how much space to give to this is going to be an issue to setting up TLS/DTLS.

Per our recent discussion adding @pfl as an assignee

AFAIK this is already completed.


Issue report mandatory field asterisk isn't themable

Issue Type
Bug
#42351
Description
It looks like the red is the same regardless of theme, maybe the same color as the text would be sufficient to avoid potential conflicts? Maybe just a lighter red in dark themes would suffice?
VS Code Info
VS Code version: Code - Insiders 1.20.0-insider (8cac1acd97466afc75c663dc1626d8562a9a3f3d, 2018-01-30T17:28:33.081Z)
OS version: Linux x64 4.13.0-31-generic

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-1620 v4 @ 3.50GHz (8 x 3491)

Load (avg)
1, 1, 1

Memory (System)
62.83GB (56.57GB free)

Process Argv
/usr/share/code-insiders/code-insiders --unity-launch

Screen Reader
no

VM
0%

Extensions: none
Reproduces only with extensions

Verified that color 'inputValidation.errorBorder' is used


Wrong lastUpdate time due to time change

Seems like time change on Sunday has affected the lastUpdate time, see e.g. Germany https://api.corona-zahlen.org/germany
It is now "lastUpdate":"2021-03-28T23:00:00.000Z" though the data is from today (29.03.)
Is this an error by RKI or can anyone fix this?

lastUpdate is the UTC time. When you actually parse it in your timezone, the correct time is displayed (March 29, 1am). See https://covid.beyerleinf.de in the footer :)

lastUpdate is the UTC time. When you actually parse it in your timezone, the correct time is displayed (March 29, 1am). Look at the footer at https://covid.beyerleinf.de :)

You are right. RKI is updating the data at "01:00:00,000 German time" every night! (bevor and after switching to DST (daylight saving time)
bevor "01:00:00,000 (German Time)" was "(date from today);00:00:00,000Z" (the Z meens "zulu" = 0 =GMT=UTC) because German time was UTC(or GMT)+1
afther switching to DST, "01:00:00,000 (German Time)" is "(date from yesterday);23:00:00,000Z" because German time is now UTC(or GMT)+2
Thats not a error from the API! and not from RKI!
i think this issue can be closed.

I advise to internally only use only UTC time

While I totally get your points with the UTC, I still think this should not be the intended behavior.
This is also highly inconsistent: /districts still shows the "correct" date with "lastUpdate":"2021-03-30T00:00:00.000Z (today) like it used to be before.
Anyway, if the majority says it's ok, we have to deal with it.

While I totally get your points with the UTC, I still think this should not be the intended behavior.
This is also highly inconsistent: /districts still shows the "correct" date with "lastUpdate":"2021-03-30T00:00:00.000Z (today) like it used to be before.
Anyway, if the majority says it's ok, we have to deal with it.

That's still the UTC time, just checked/updated at a different time. You should not treat this like this is the german time for example.
However, why /districts returns a different value I'm not sure and I'll try and debug it

So, just fired up a local instance and I've found some things.

The lastUpdate for /germany currently returns "2021-03-29T23:00:00.000Z" (which would be 30.03. 01:00 in German time) where it should actually return "2021-03-29T22:00:00.000Z" (which would be 30.03. 00:00 in German time). This is because the lastUpdate is taken from the states response which has an hour added to it (for whatever reason). This is the code: https://github.com/marlon360/rki-covid-api/blob/cdb96df94661856da6f79ad77d7dfc11f9d867c7/src/data-requests/states.ts#L35 This could be fixed by removing the added hour for /germany and /states.
/districts however has the wrong value ("2021-03-30T00:00:00.000Z") because there is actually no timezone offset in the docker container. Since the RKI can't provide consistent data, the date string from the response ("30.03.2021, 00:00 Uhr") will be interpreted as it is. The epoch timestamps in the other responses are already in UTC format, hence they are correct.

If you want I can create a PR to fix the date parsing so that every response returns the correct UTC date :)

Any news on this?

fixed


Add SonarQube Action

Description

Add SonarQube action
Motivation and Context

Improve code qualtity
How Has This Been Tested?

No test needed, ony CI
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Currently waiting for @TooTallNate to add the secret.


networking: gateway in network configuration does not set default route

I'm running a pod having the following network defined:
{
    "name": "containers_ipv4",
    "type": "macvlan",
    "master": "enp0s20u1u1",
    "mode": "bridge",
    "ipam": {
            "type": "host-local",
            "subnet": "<IP_ADDRESS>/24",
            "gateway": "<IP_ADDRESS>"
    }
}

I would expect the defined gateway to be the default gateway on that interface, but that is not the case.
What would be the pros and cons of doing so?

@eyakubovich should we move this to cni?

The defined gateway should be the gateway on the <IP_ADDRESS>/24 route, not default. However that doesn't work as well. Moving this to CNI.

@steveeJ My previous comment doesn't make much sense. However the behavior is as designed: ipam.gateway is a somewhat of a wart -- it just says that there is this gateway but it does not say that's the gateway for the default route. The default route has to be specified explicitly:
"ipam": {
    "type": "host-local",
    "subnet": "<IP_ADDRESS>/24",
    "routes": [
        { "dst": "<IP_ADDRESS>/0", "gw": "<IP_ADDRESS>" }
    ]
}

On the other hand, if "gateway" was specified, "gw" can be dropped:
"ipam": {
    "type": "host-local",
    "subnet": "<IP_ADDRESS>/24",
    "gateway": "<IP_ADDRESS>"
    "routes": [
        { "dst": "<IP_ADDRESS>/0" }
    ]
}

Why the complexity? It helps to look at what IPAM plugin returns: "ip", "gateway", and "routes". The main plugin uses "gateway" for things like setting an IP on the bridge (turning it into a gateway), if requested. And it will also use that value if "gw" is missing on the route. In case of "host-local", ipam.gateway configuration value just gets passed back in the result.
I will admit that it is confusing but it does allow for many use cases.

@steveeJ @eyakubovich what's the solution here, better documentation?

any news on this?

This topic is still undecided in CNI. The tendency goes towards a new IPAM boolean attribute named similar to  "gatewayIsDefault". IPAM would then generate the default route and pass it along.

In general the behavior remains as is, but the bridge plugin received a new 'isDefaultGateway' attribute for convenience.


Easy 2 Fix: KafkaJS default ClientID should be a UUID to enforce uniqueness

Describe the bug

Confluent dataflow throws a warning for non-unique ClientIDs of the ConsumerGroup
Expected behavior
The expected behavior would be that in the constructor of the network connection class, a (unique) UUID is assigned to the clientID as a default value. This automatically enforces the uniqueness constraint.
Observed behavior
At the moment 'kafkajs' is the default clientID
https://github.com/tulios/kafkajs/blob/e2f34ffc8e8e37fc0d31ae51202f1147263cf0ed/src/network/connection.js#L45
Environment:

Confluent Standard Cluster
Latest version of KafkaJS

Using a UUID would likely bring a dependency (which KafkaJS so far tries to avoid), and/or complexity for having such code.
Would it maybe suffice to require the user to set the id instead of having a default?
Then again, the Kafka documentation has a known default of "" for the client.id configuration (https://kafka.apache.org/documentation/#client.id), and it seems that the default actually is some simple auto-increment value (consumer-XXXX). See also https://github.com/apache/kafka/pull/7944 for a discussion on changing that default.

An easy fix would be to generate your own unique id, without any  additional dependencies, using the crypto module:
const crypto = require("crypto");
const id = crypto.randomBytes(16).toString("hex");
console.log(id);

This generates cryptographically strong pseudo-random data. It looks better to me given that increments require 'state'.
Alternatively you could require the user to set the id but then you will have introduced a breaking change :)
What do you think?

I think we need to get some clarity on the purpose of the client id before making any such decision. Generating a random value is not particularly hard (though I assume it should still be persistent across re-instantiation of the Connection, so we can't just generate it in the constructor), but the real question is whether or not it should be. Confluent's tooling certainly seems to want it to be unique across instances, but the Kafka documentation  seems to indicate that it should not be:

The purpose of this is to be able to track the source of requests beyond just ip/port by allowing a logical application name to be included in server-side request logging.

If we generate a random clientId per instance, then that defeats the documented purpose.
I would not want to change this before there has been a KIP to explain the rationale. For now, i individual users want to have unique clientIds per instance, they can set it themselves.

In my opinion, given that you know have knowledge of the unforeseen behavior your framework causes for Confluent users given the default settings, it seems logical to me that you should reconsider the static "kafkajs" clientID id. It is true the documentation says:

The purpose of this is to be able to track the source of requests beyond just ip/port by allowing a logical application name to be included in server-side request logging.

I am not sure how a clientID of "kafkajs" helps on this end, but you could also settle for a combination of a serviceName + random appended string (f.e. kafkaJS-15c99ef7-44dd-4f00-887d-19c8982214db).
Anyway I will proceed with manually introducing clientIDs in the meantime, this patches the problem on the Confluent side so that the data flow UI works again (see below). Thanks for the feedback.


⚠ Fetchers has degraded performance

In 3bd7057, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 265 ms

Resolved: Fetchers performance has improved in 10ccdd3.


why my requset say ,Not response many reqsuet ?

I'm blocked when I use bing-translator-API, so I try using a proxy for my server but it uses (got) to send API, and don't have an idea how to set proxy with this (got).

Hi, I think it may be better to expose the proxy option of got. Will do it later.

It's a bit strange that agent doesn't work. I saw you set HttpProxyAgent rather than HttpsProxyAgent as https agent, is it a typo?

Released v2.4.0 on npm.

thank for you
it doesn't work for me so I try this code
const { bootstrap } = require('global-agent');
process.env.GLOBAL_AGENT_HTTP_PROXY = proxyUrl;
process.env.NODE_TLS_REJECT_UNAUTHORIZED = false;
bootstrap();

after that I did write this inside got
    https: {
      rejectUnauthorized: false
    },

now to work.......


Include libiio0-doc in non-minimal packagelist files

There are some unsettled questions regarding whether and how much documentation to include in non-minimal packagelist files. Prior to distro-seed, the TS-7100 and TS-7180 didn't shy away from including documentation packages when development library packages were being included on these boards. This documentation is "cheap" space-wise compared to the other packages, relatively in-sync with whatever is on the board, and maintenance-free. It has been nice to find it there.
The counter-view is that documentation packages should never be included without a compelling reason, even though some man pages and HTML documentation already exist (albeit inadvertently) in distro-seed builds.

Using two products that are still technically in engineering sampling as a basis for what has been included in the history of images to determine what goes in future images is not really a fair starting point when it affects more than just the two platforms.
Historically, we include man and packages install their man pages alongside it. Packages that have a man page in Debian basically have to include them in the package by Debian policy. There is no way to disable them easily without installing and then removing just the man pages, breaking installed packages. Any external package documentation is not normally included.
While it may not take up space, more often than not it will go unused as modern documentation is HTML and there is no way to view that on-device without setting up an HTTP server on the device. e.g. unless you are using a TPC platform with a display, or a command-line web browser, you can't easily view rendered HTML.
The goal of our distributions is to create a minimum viable booting system, with common creature comforts that make using a system more functional out of the box without including the kitchen sink. That is unfortunately a nebulous definition, but development documentation for a package that not every application is going to use, when its easier to look online at the documentation as it wants to be rendered HTML, definitely falls in to kitchen sink territory.

It helps to know or be reminded that HTML documentation (already installed "involuntarily" by packages in the rootfs) is easy to view via the built-in web server, which can be run from a documentation directory with:
python3 -m http.server

So for example, on any Debian 12 distro-seed image today you can do this:
python3 -m http.server -d /usr/share/doc/base-passwd

and then point any web browser that can reach your board at port 8000. This prints the URLs for all interfaces that the board has up:
ip addr show up | sed -En 's/.*inet ([0-9.]+).*/http:\/\/\1:8000/p'

This demonstrates the fact that documentation is in HTML isn't a huge impediment to a developer working directly on a board, and in some cases is better than man pages alone (as was the case with libiio-dev). And a more direct path to version-specific information than the web.
Which leads to another aspect of the "kitchen-sink" concern. If one is already putting toolchains and *-dev packages on a board – especially one where it should be made as seamless as reasonably possible to bring over applications using the packages provided – having the correct documentation for said packages/versions close at hand doesn't sound like a problem.
Requiring any *-doc package available for a *-dev package to be included in any packagelist that includes the *-dev package may well be a "kitchen sink" problem. But should that be taken to mean that -doc packages are excluded in all cases?

It helps to know or be reminded that HTML documentation (already installed "involuntarily" by packages in the rootfs) is easy to view via the built-in web server, which can be run from a documentation directory with:
python3 -m http.server

So for example, on any Debian 12 distro-seed image today you can do this:
python3 -m http.server -d /usr/share/doc/base-passwd

or this:
python3 -m http.server -d /usr/share/doc

and then point any web browser that can reach your board at port 8000. This prints the URLs for all interfaces that the board has up:
ip addr show up | sed -En 's/.*inet ([0-9.]+).*/http:\/\/\1:8000/p'

This demonstrates the fact that documentation is in HTML isn't a huge impediment to a developer working directly on a board, and in some cases is better than man pages alone (as was the case with libiio-dev). And a more direct path to version-specific information than the web.

Yes but this assumes one of two things:

That people have this in their workflow (not something we can predict, and from personal experience both myself and others in similar industries usually refer to the correct version in web documentation because it is quick and easy to have multiple sources of documentation open simultaneously. Including not only documentation but code as well much more easily than just on-unit).
We document this heavily so people know about it and how to use it. Which we do not, and documenting how to view HTML documentation on-unit is out of the scope of our documentation and would muddy existing manuals or require additional maintenance of other pages.

Which leads to another aspect of the "kitchen-sink" concern. If one is already putting toolchains and *-dev packages on a board – especially one where it should be made as seamless as reasonably possible to bring over applications using the packages provided – having the correct documentation for said packages/versions close at hand doesn't sound like a problem.
Requiring any *-doc package available for a *-dev package to be included in any packagelist that includes the *-dev package may well be a "kitchen sink" problem. But should that be taken to mean that -doc packages are excluded in all cases?

This brings up a good point. We shouldn't have -dev packages in our images. We need a few of them for building our utils packages for example, but, those are requirements on the host environment and not the target. However, we cannot predict library needs for end users and even including "obvious" dev packages could easily go completely unused. Trying to predict that is a slippery slope that will lead to immense effort on our side to debate, maintain, document, ensure what is shipped, etc.; while end users will simply just install what they need anyway.
Our images are designed to showcase the features of the hardware and to let the customer hit the ground running. No need to download a huge BSP, no licenses to walk through, here is a console, here is a compiler, connect your preferred workflow to this and go. I would actually like to argue that tools like gdb don't belong in our image, however I can see it being extremely useful to just already have in some situations.
libiio-dev is the only dev package in our images, and should actually be removed. If needed for end application development, it, and the -doc package, can be installed by the end developer.


T in ChainOutput is unused

https://github.com/rogeriochaves/litechain/blob/e8bf61e295b47d62a751816b631ea8688a7ff431/litechain/core/chain.py#L30
The Generic Parameter T is not used. This makes it a bit annoying to define a ChainOutput with a value type because to have to specify some value for T to specify the value of V:
string_output: ChainOutput[Any,str]

indeed, I was planning to remove it already, will get to it soon, thanks for reporting!

fixed in ad9624b24c61bf450c073b192998178b84d15dad :)


Support for Python models in dbt-trino

Describe the feature
Please do look into the following issue.
https://github.com/dbt-labs/dbt-core/issues/6476
Describe alternatives you've considered
No response
Who will benefit?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

@curiosityCursed : Can you elaborate on your use case? Do you just want dataframe support? Do you also need Python UDFs? What exactly are you looking for?

@mdesmet I've set of python classes with methods which parses api response and performs complex transformation and loads to sink. I'm exploring python models to achieve the same using dbt to avoid major changes to the biz. logic while using the existing transformations.

+1 for this feature.


docs(detach): fix example test

The jest functions have been changed

I assume you discovered that all of our examples are using chai, not jest matchers :-)


Update using-typescript-with-svelte

Support is official now. Also removed the Babel-section because it might confuse people and the other option is the recommended one.

Awesome! Thank you!


some statics module files are missing

hi sir,
there are some file regarding to statics modules in the comment, but still some files missing
(domain, units, ....)
thanks for this great work

Could you be a bit more specific as to which stsic files exactly?

Statics folder with example file added


Delay-press to start application

Goal
Avoid accidental launch.
Motivation
At the moment, an application is launched by pressing the name. If you double-click, you'll launch two applications. Since some applications take a minute to appear running, one may accidentally click many times and cause many applications to launch all at once.
Implementation
Implement a press-and-hold type mechanism, such that you press-and-hold on your application for a second or so in order to launch it, along with some visual indicator of how long you need to press and whether you've pressed long enough.

This might be less prone to accidentally happen with this PR: https://github.com/getavalon/launcher/pull/27
It's because the Applications slide into into position briefly before being exactly there. See:

Would that also fix it?


Controller redirect_back method

Checklist

[x] Upgrade Jets: Are you using the latest version of Jets? This allows Jets to fix issues fast. There's a jets upgrade command that makes this a simple task. There's also an Upgrading Guide: http://rubyonjets.com/docs/upgrading/
[x] Reproducibility: Are you reporting a bug others will be able to reproduce and not asking a question. If you're unsure or want to ask a question, do so on https://community.rubyonjets.com
[x] Code sample: Have you put together a code sample to reproduce the issue and make it available?  Code samples help speed up fixes dramatically. If it's an easily reproducible issue, then code samples are not needed. If you're unsure, please include a code sample.

My Environment

Software
Version

Operating System
MacOS 10.14.6

Jets
2.1.1

Ruby
2.5.3

Expected Behaviour
I expect to be able to use the redirect_back method defined in ActionController within a jets controller.
Current Behavior
Calling redirect_back fails with the following NameError:
undefined local variable or method `redirect_back`for MY_CONTROLLER

Step-by-step reproduction instructions
Try calling redirect_back in any controller action.
Code Sample
class PagesController < ApplicationController
  def create
    @page = Page.new(pages_params)

    if @page.save
      redirect_to pages_url
    else
      redirect_back
    end
  end
end

Done in #359


Feature/changes in table

add some functions and tests to table.
fix operations on empty tables.

Codecov Report

Merging #44 (ed399be) into development (9906a42) will decrease coverage by 0.05%.
The diff coverage is 89.47%.

@@               Coverage Diff               @@
##           development      #44      +/-   ##
===============================================
- Coverage        71.35%   71.31%   -0.05%
===============================================
  Files               31       31
  Lines             1365     1377      +12
===============================================
+ Hits               974      982       +8
- Misses             391      395       +4

Flag
Coverage Δ

unit-tests
71.31% <89.47%> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mango/table/pytups_tools.py
98.08% <85.71%> (-1.43%)
:arrow_down:

mango/table/pytups_table.py
93.23% <91.66%> (-0.20%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


fixfix not check udf auth in nereids

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run feut


No system try icon !

Bug description:

No system try icon
Steps to reproduce:

Launch Ferdi,
then close it (without exit),
no system try icon

Expected behavior

It should be a system try icon that appear in system panel - as it was the case before - so that user can use this icon to bring Ferdi window again or use it to exit Ferdi.
Currently, I can not exit Ferdi after I launching it if I click "close" ! This is annoying !
Screenshots

Environment:

Operating System: Fedora Linux 30 X64 Cinnamon edition
Ferdi Version: 5.5.0
Server: Using without an account

Same issue here with Gnome on Archlinux

Duplicate of #437


Formagrid.Airtable version 1.4.5

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

This is an update of the existing Formagrid.Airtable <IP_ADDRESS>. I changed the Publisher field from "Formagrid" to "Airtable" to match the ARP entry. I kept the Formagrid in the Package ID, though.


nowjs not working in opera,

for example see
http://nowjs.com/examples
About Opera
Version information
Version
11.52
Build
1100
Platform
Win32
System
Windows 7

Reproduced. Looking into it

Same on Opera/9.80 (Macintosh; Intel Mac OS X 10.6.8; U; pt-BR) Presto/2.7.62 Version/11.01

Not working here too.
Opera 11.51 (Windows 7)
@ericz have you looked into it?
Thanks in advance :)

Hey Gustavo,
It turns out that this is a known problem with Socket.IO and Opera [1] [2]. WebSockets comes disabled by default in Opera, and Socket.IO is unable to properly fallback to any of the other options, which is why it ends up failing.
It seems like Socket.IO fixed this issue a while back though [3], so try updating your Socket.IO and see if that works. Alternatively, you can try to follow some workarounds people have found [4]. Lastly, if none of those options work, try using one of the other transports instead of WebSockets, which you can easily do when initializing Nowjs:
var nowjs = require("now");
var everyone = nowjs.initialize(yourHttpServer, {
  socketio: {
    transports: ['xhr-polling', 'jsonp-polling']
  }
});

Let me know if any of that works out for you!
Thanks,
Ritik
[1] https://github.com/LearnBoost/socket.io/issues/274
[2] http://stackoverflow.com/questions/7858173/node-js-and-socket-io-problems-in-opera-browser
[3] https://github.com/LearnBoost/socket.io/issues/274#issuecomment-1618730
[4] https://github.com/LearnBoost/socket.io/issues/274#issuecomment-1604875

Have tried this but no results

@ritikm I will see if the update solves this issue.
Thanks for such detailed comment!


Changed LICENSE to MIT

Added LICENSE template generation (will prompts)

@rqc we decided to add lib dir for non bot code.
in this dir one can place code that not extends robot.

@rqc I merged with HEAD and removed lib.

@mosheBelostotsky looks good.


Reload the Squid configuration on a running instance

Hi,
This is a suggestion to revise the method to reload the squid configuration on a running instance.
I have used sameersbn/squid:3.3.8-23 and it work nice until I try to reload the squid configuration on a running instance. I found that after typing docker kill -s HUP squid to my terminal, squid shows the same configuration as before. I try a lot of ways to figure out the problem, but only to find that it was the problem of mounting the squid.conf.
Here is the detail.
I create and run sameersbn/squid:3.3.8-23 following the instruction in README.md:
docker run -d --name squid --restart=always --publish 3128:3128 --volume /etc/squid/squid.conf:/etc/squid3/squid.conf --volume /var/spool/squid3:/var/spool/squid3 sameersbn/squid:3.3.8-23

This works nice, however, when you try to reload squid.conf on the running instance using:
docker kill -s HUP squid

You will find the configuration of squid doesn't change at all. After a lot of miserable reading of docker issues, I found the problem. Docker can not detect the mounted file changes unless you mount the directory. In my situation, I create a new container and mount my squid.conf directory, then HUP works. That is:
docker run -d --name squid --restart=always --publish 3128:3128 --volume /etc/squid/squid.conf:/etc/squid3/squid.conf --volume /etc/squid:/etc/squid3 --volume /var/spool/squid3:/var/spool/squid3 sameersbn/squid:3.3.8-23

The magic is --volume /etc/squid:/etc/squid3
I hope my experience could help new guys like me. 😃

Try mount volume only as directory:
docker run -p 3128:3128  -v /etc/squid:/etc/squid sameersbn/squid:3.5.27-2


How to remove from Azure spot

Please provide info on how to remove a machine from Azure spot.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fb6d504c-6e94-a353-3465-832330efab44
Version Independent ID: 79c70736-63a0-b023-5336-e16cb4f9d217
Content: Use Azure Spot VMs - Azure Virtual Machines
Content Source: articles/virtual-machines/spot-vms.md
Service: virtual-machines
GitHub Login: @cynthn
Microsoft Alias: cynthn

@wUEZRs Thank you for the feedback. We are actively investigating and will get back to you soon.

Hi @wUEZRs ,
Converting a Spot VMs to traditional Azure VMs (taking a VM out of Spot) is currently unsupported officially. That being said you could write your own powershell script to copy all the attributes of a Spot VM and then redeploy them onto a Azure VM (or vise versa). Here is an example of someone doing exactly that in reverse. Does this help answer your question? Thanks.

Hi @AnuragSharma-MSFT ,
I'm closing this issue as I haven't heard back. But don't hesitate to leave a comment below and I'll reopen it. Thanks!

It would be good to have this info in the Docs
fre. 9. okt. 2020 kl. 03:35 skrev Winston Howard<EMAIL_ADDRESS>
Hi @AnuragSharma-MSFT https://github.com/AnuragSharma-MSFT ,
I'm closing this issue as I haven't heard back. But don't hesitate to
leave a comment below and I'll reopen it. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/63863#issuecomment-705916189,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AP5RFBKXTDYGRRXLJCN6CCDSJZSG5ANCNFSM4SFYCN7A
.


Copied address introduces a space in the beginning

When address is copied from Hexa to another wallet, it puts in a space in the beginning.

Duplicate


remove justlooking

Website is down. If it stays down, we should remove it.

Still down. Merging.


fix: twitter share url

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Create 2017-06-22.yaml

@sseidelmann can you make the fixes ?

@sseidelmann any news?

@marcomenzel Sure, if you can take over this PR, that would be great. Thanks.

Closing in favor of #234


feat(Language): get method

Problem
On SDK 2 Lang was a property called language that tells you the current language you are using. On SDK 3 there's not.
Solution
Added get method to Language to retrieve the current language you are using.

My fault to not update the doc! :)


[Help] How to make tray icons grayscale

I would like to desaturate the tray icons. Is it possible through the style.css?

Maybe this is helpful:
#tray > * {
  opacity: 0.5;
}

Thanks, but unfortunately it made the tray icons less bright/transparent but i want them to be black and white

find the source of tray icon and edit  the image to grayscale version

This might eventually become possible via CSS with #2815. GTK4 CSS supports filter attribute (see https://docs.gtk.org/gtk4/css-properties.html), GTK3 does not. Then you might be able to use grayscale() or saturate() filter functions.


Set taskbar buttons to always combine and hide labels AGAIN

Win10 1809, Taskbar combine settings seem to not work. Any change I make results in "display all taskbar icons".  Does any other setting affect this one?

Are you referring to SetTaskbarCombineWhenFull / SetTaskbarCombineNever / SetTaskbarCombineAlways ? Because I've just tried them on 1809, build 17763.107 and they all work as expected. There wasn't a change in these since Windows 7. Can you please describe step by step what are you doing?

I suspect that there might be a confusion of terms. "right side taskbar icons" doesn't make sense - do you have in mind the icons next to the clock (volume, network etc.)? If so, then we're talking about systray or notification area in which case you want to apply HideTrayIcons tweak.

I can't believe I missed something so darn simple, you are correct.
Combine icons when taskbar is full from running programs. (usually starting from the left side)
Notification area icons all showing is what I was referring too.  It's fixed.
Great and helpful responses though! Keep up the excellent work.


cubical.exe does not support {- -} comments

cubical.exe does not apparently support block comments using {- ... -}.   In particular, demo.ctt crashes on a parse error at line 2, but other files seem to load just fine.


Cannot create Postgres migrations for :money_with_currency

Hi @zachdaniel, thank you for your work on this package!
I'm currently trying to install AshMoney and add AshMoney.AshPostgresExtension to the list of installed extensions for Postgres, and am facing some issues. Here are the steps I took to add it:

Add {:ash_money, "~> 0.1.0"} to mix.exs..
Add AshMoney.AshPostgresExtension to the end of the list inside MyApp.Repo.installed_extensions/0

That's it. Then, after running mix ash_postgres.generate_migrations --name add_ash_postgres_money_extension, I get the following error:
Extension Migrations:
** (UndefinedFunctionError) function Money.DDL.create_money_with_currency/0 is undefined (module Money.DDL is not available)
    Money.DDL.create_money_with_currency()
    (ash_money 0.1.0) lib/ash_money/ash_postgres_extension.ex:10: AshMoney.AshPostgresExtension.install/1
    (elixir 1.15.2) lib/enum.ex:1794: anonymous fn/2 in Enum.map_join/3
    (elixir 1.15.2) lib/enum.ex:4369: Enum.map_intersperse_list/3
    (elixir 1.15.2) lib/enum.ex:1794: Enum.map_join/3
    (ash_postgres 1.3.62) lib/migration_generator/migration_generator.ex:240: anonymous fn/2 in AshPostgres.MigrationGenerator.create_extension_migrations/2
    (elixir 1.15.2) lib/enum.ex:1693: Enum."-map/2-lists^map/1-1-"/2
    (ash_postgres 1.3.62) lib/migration_generator/migration_generator.ex:51: AshPostgres.MigrationGenerator.generate/2

The above is fixable by manually adding ex_money_sql to my mix.exs. But then, running the migration command again, I get:
Extension Migrations:
** (UndefinedFunctionError) function AshMoney.AshPostgresExtension.extension/0 is undefined (module AshMoney.AshPostgresExtension is not available)
    AshMoney.AshPostgresExtension.extension()
    (ash_postgres 1.3.63) lib/migration_generator/migration_generator.ex:187: anonymous fn/1 in AshPostgres.MigrationGenerator.create_extension_migrations/2
    (elixir 1.15.2) lib/enum.ex:1693: Enum."-map/2-lists^map/1-1-"/2
    (elixir 1.15.2) lib/enum.ex:1693: Enum."-map/2-lists^map/1-1-"/2
    (ash_postgres 1.3.63) lib/migration_generator/migration_generator.ex:185: anonymous fn/2 in AshPostgres.MigrationGenerator.create_extension_migrations/2
    (elixir 1.15.2) lib/enum.ex:1693: Enum."-map/2-lists^map/1-1-"/2
    (ash_postgres 1.3.63) lib/migration_generator/migration_generator.ex:51: AshPostgres.MigrationGenerator.generate/2
    (mix 1.15.2) lib/mix/task.ex:447: anonymous fn/3 in Mix.Task.run_task/5

and I'm not sure how to fix it this time. It appears from the source that loading AshMoney.AshPostgresExtension requires AshPostgres.CustomExtension to be loaded, but seems like that's not happening, and I'm not sure how to proceed here. Any pointers?

Can you try doing mix deps.compile ash_money --force?

Unfortunately, that didn't fix it; exact same issue. I had originally tried it as well when I was trying to configure :custom_types per the getting started guide. For what it's worth, if I change a field in a schema, say :price from :integer to :money, then the autogenerated migration gets generated just fine, and the field gets modified to :money_with_currency, which I suppose won't work without the extension getting installed first. Here's my full repo.ex, in case it's helpful (it's very barebones):
defmodule MyApp.Repo do
  use AshPostgres.Repo, otp_app: :my_app

  def installed_extensions do
    ["uuid-ossp", "citext", AshMoney.AshPostgresExtension]
  end
end

Can you try the main branch? And also ensure you have ex_money_sql and ash_postgres deps in your mix.exs.

And if that doesn't work, delete your _build directory and do a full compile.

Must be a fix we added in a recent unreleased commit. I'll cut a new release.

release 1.2


TypeScript declaration files for Jasmine not found in Angular 2 project

From @jorgeas80 on October 1, 2016 18:8

VSCode Version: 1.5.3
OS Version: Ubuntu 16.04

Steps to Reproduce:

Install angular-cli
Run ng new myproject
Open the created project with VSCode, and open the spec file (src/app/app.component.spec.ts)

Functions like describe, beforeEach, it and expect are not recognized (see img)

Check list:

<EMAIL_ADDRESS>file exist
this option is included in tsconfig.json

"typeRoots": [
      "../node_modules/@types"
    ]

As tsd is officially deprecated since August and I'm using the last VSCode release, why could be happening?
Copied from original issue: Microsoft/vscode#13125

@jorgeas80 thank you for opening this issue.
@mhegazy can you take a look at this? I have recreated this on my own machine. As far as I can tell everything is setup correctly: tsconfig.json, typings exist in the proper location, etc. Seems like I'm missing a config step though...

From @jorgeas80 on October 2, 2016 11:2
I had to add this to make vscode recognize Jasmine typings.
/// <reference<EMAIL_ADDRESS>/>
It shouldn't be necessary with my version, I think

From @blakehawkins on October 11, 2016 14:37
I have a similar configuration with the same issue - no angular.

vscode 1.5.3
ubuntu 16.04

Steps to reproduce:

npm install @types/es6-shim
Add "compilerOptions": {"typeRoots": ["./node_modules/@types/"]} kv to tsconfig.json
code displays an error at, for example, const features = new Set(arr);

Can also confirm that compiling with tsc succeeds.

@blakehawkins thank you for providing more information. This is a language service issue. Moving to that repo.

I am unable to reproduce this locally on latest. please reopen if you are still experiencing issues.

I have this same issue in a Nativescript with Angular 2 project, Jasmine functions are not recognized

@magar91 can you share a repo that we can reproduce the issue?

I was able to reproduce the above error,but was able to resolve it by adding an explicit typing to my tsconfig.json file

This is based on http://stackoverflow.com/questions/39020022/angular-2-unit-tests-cannot-find-name-describe.


CSLC-S1 Gamma Integration

Description
This branch updates the CSLC-S1 PGE code to integrate with the Gamma delivery of the corresponding SAS. Major changes include adding file naming support for the new "static layers" and "browse" products, and minor updates to the ISO xml metadata.
Affected Issues
Resolves #258
Testing
Existing unit test suite for CSLC-S1 has been updated to test file name application to the new output products.

Thank you @david-inglish and @JimHofman for the prompt review, I have attempted to address your comments regarding the new docstrings.


Cast objc_msgSend before calling it

Calling objc_msgSend with its vararg signature will only work most
of the time, and fail very weirdly when it doesn't. It's weird,
but you're supposed to always cast it to the signature of the
selector you're calling.
I think this is even required when building on Catalina, or for arm64?

Thanks!


CloudFront caching errors

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
d7rx5b5im0en3
Region
eu-central-1
Amplify Console feature
Not applicable
Describe the bug
I'm using Next.js with Incremental Site Regeneration (ISR) on Amplify. I noticed that when accessing a page that isn't built yet I'm getting a 404 error and this error is cached by CloudFront with the Cache-Control header public, max-age=0, s-maxage=2678400, must-revalidate.
I also tried overriding this Cache-Control headers, but that didn't work.
Expected behavior
CloudFront shouldn't cache 404 or any other errors.
Reproduction steps

Deploy a Next.js app with ISR on Amplify.
Try to access an ISR route – like "/news/awesome-post" that isn't built but is already created in the CMS.
Check the headers in the dev tools of your browser.

Build Settings
version: 1
frontend:
  phases:
    preBuild:
      commands:
        - yarn install
    build:
      commands:
        - yarn run build
  artifacts:
    baseDirectory: .next
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*

Additional information
customHTTP.yml:
customHeaders:
  - pattern: '**/*'
    headers:
      - key: Cache-Control
        value: 'public, max-age=0, s-maxage=0, no-cache'
      - key: x-frame-options
        value: DENY
      - key: x-xss-protection
        value: 1; mode=block

Hi,
CloudFront doesn't cache errors anymore. We also just announced several improvements to our cache handling.
Check out the details here: https://aws.amazon.com/blogs/mobile/cdn-caching-improvements-for-better-app-performance-with-aws-amplify-hosting/


Exception documentation

Fixes #91
Just documentation.

Typo on my end in the other PR - can you split these two into separate PRs?


skip flaky gitea test

e2e are not supposed to be always red
Signed-off-by: Chmouel Boudjnah<EMAIL_ADDRESS>Changes

Submitter Checklist

[ ] ♽  Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
[ ] 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
[ ] 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
[ ] 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
[ ] 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

do we have any idea when it is failing?

i dont think it's our beloved issue, it's has to do with some timeout on detecting failures, works for success tho.

/test

pac cluster is done, this could be merged another day :D (and go sleep ;)

/retest

/retest


NSURLConnection deprecation warning in iOS 9

initWithRequest:delegate:startImmediately is deprecated in iOS 9. Need to change to using NSURLSession instead.

@hamchapman I've been thinking about the idea of removing the Pusher REST API wrapper from the library, perhaps extracting to a new library instead. Is there a reason why a client would need to send events this way instead of using socket based events?

I'm sure some people do use it to do that, but with the ability to send client events then there shouldn't be a need to. Extracting interaction with the straight HTTP API into a separate library would also mean that people's app secrets shouldn't need to be included in apps that people build, which is certainly a good idea!
I've let people use the secret in the Swift library but that's really there just for testing so that you don't need to setup an auth endpoint to get things up and running. Ideally you'd never include your secret in an actual app release.
That's a long-winded way of me saying that what you suggested sounds like a great idea! :+1:

+1

Further discussion in #189

#213 has been merged and this is now fixed


WIP: Introduce generator as option for base

This will allow e.g.
apiVersion: porch.kpt.dev/v1alpha1
kind: PackageRevision
metadata:
  namespace: default
  name: "deployment:postgres:v1"
spec:
  packageName: postgres
  revision: v1
  repository: deployment
  tasks:
  - type: clone
    clone:
      generator:
        config:
          apiVersion: fn.kpt.dev/v1alpha1
          kind: RenderHelmChart
          helmCharts:
          - chartArgs:
              name: postgresql
              repo: https://charts.bitnami.com/bitnami
            templateOptions:
              values:
                valuesInline:
                  postgresqlDataDir: /kpt/postgresql/data
  - type: eval
    eval:
      image: gcr.io/kpt-fn/set-labels:v0.1.5
      configMap:
        bucket-label: bucket-label-value
        another-label: another-label-value

I uploaded a bit more in #3041 which shows how we could discover the function for a CRD


master masterClient failed to receive from ip: EOF

Describe the bug
Seaweed cluster communication error.
Only <IP_ADDRESS> I did not start, <IP_ADDRESS> and <IP_ADDRESS> have been started and the network is connected, but this error occurs: master masterClient failed to receive from <IP_ADDRESS>:9334: EOF
master masterClient failed to receive from <IP_ADDRESS>:9334: EOF
System Setup

/opt/seaweedfs_pcap/weed_pcap  master -mdir=/var/log/bd_files/weed_master_data_pcap  -defaultReplication="100" -ip.bind="<IP_ADDRESS>" -ip="<IP_ADDRESS>"  -port=9334 -peers="<IP_ADDRESS>:9334,<IP_ADDRESS>:9334,<IP_ADDRESS>:9334"
/opt/seaweedfs_pcap/weed_pcap  master -mdir=/var/log/bd_files/weed_master_data_pcap  -defaultReplication="100" -ip.bind="<IP_ADDRESS>" -ip="<IP_ADDRESS>" -port=9334  -peers="<IP_ADDRESS>:9334,<IP_ADDRESS>:9334,<IP_ADDRESS>:9334"
debain8
version 8000GB 2.04 bbd0afd linux amd64

Screenshots

Additional context
Add any other context about the problem here.

the first peer needs to be started at least once.

第一个对等方至少需要启动一次。

<IP_ADDRESS> I need to start this machine at least once, so the problem will not appear later?

Yes


Add CSG support

Added "limited" csg support with the least amount of code possible. It works with any csg, but only on the root shapes.
The first modification is detecting all csg shapes.
https://github.com/Frontrider/godot-snappy/blob/godot-3/addons/snappy/snappy.gd#L94-L95
Secondly, CSG lets us get the mesh IF the csg was the root of the shape. This is a heavier limitation, but there is not much that can be done about it. This still lets csg shapes to be used as primitive shapes.
https://github.com/Frontrider/godot-snappy/blob/godot-3/addons/snappy/snappy.gd#L118-L123

Thanks


Gapfilled data

The Renchon dataset #160 has a lot (1/3?) of gap-filled data as well as true observations. Right now the custom code deletes the gap fill information, but it's possible we'd like to retain ...?

No


[SANDBOX] feat: 3873 - full screen camera + viewfinder and carousel with variable heights

Deleted file:

scanner_visor.dart: duplicate with smooth_barcode_scanner_visor.dart, with limited features

Impacted files:

camera_scan_page.dart: moved the viewfinder there, with variable height'ed viewfinder
shared/pubspec.yaml: removed now useless flutter_svg
scan_page.dart: Stack instead of Column, with variable height'ed carousel
scanner_ml_kit.dart: moved the viewfinder elsewhere
scanner_shared.dart: removed file scanner_visor.dart
scanner_zxing.dart: moved the viewfinder elsewhere
smooth_barcode_scanner_visor.dart: fixed the display and made its height variable
user_preferences.dart: added getter/setter for new percentage height parameters
user_preferences_dev_mode.dart: added UI for new percentage height parameters

What

The scanner camera is now full screen (again).
In DEV MODE, we can now change the carousel and the viewfinder heights, as percentages of the page height.
This PR is about the scan page UI/UX only. Once we more or less agree on height settings, there'll be minor refactoring needed (e.g. cornerPadding = 26 and using a scan window).

Screenshot

big viewfinder, big carousel
small viewfinder, small carousel
big viewfinder, small carousel

Part of

#3873

Codecov Report

Merging #3886 (808dc50) into develop (a7f9071) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3886      +/-   ##
===========================================
- Coverage    10.59%   10.53%   -0.07%
===========================================
  Files          270      271       +1
  Lines        13364    13445      +81
===========================================
  Hits          1416     1416
- Misses       11948    12029      +81

Impacted Files
Coverage Δ

...s/smooth_app/lib/data_models/user_preferences.dart
14.28% <0.00%> (-1.42%)
:arrow_down:

...b/pages/preferences/user_preferences_dev_mode.dart
0.00% <0.00%> (ø)

...es/smooth_app/lib/pages/scan/camera_scan_page.dart
1.61% <0.00%> (-0.21%)
:arrow_down:

packages/smooth_app/lib/pages/scan/scan_page.dart
2.81% <0.00%> (-0.27%)
:arrow_down:

...p/lib/pages/scan/smooth_barcode_scanner_visor.dart
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

It looks like we don't need that PR anymore.
Too many conflicts to resolve anyway, so if needed we'd be better off starting from scratch.


Ensure the publish approver is different than the person that queued the build

If you queue a build, you cannot approve it for release.
Should we make this change? @weshaggard @kurtzeborn

Yes!  On the same day we enable this, either you or I should send a broad mail (and teams post) to notify the team of this change.


Doesn't write to the SQL server

Please clearly describe what the SQL Sink is doing incorrectly:
It doesn't write anything into the log table.
List the names and versions of all Serilog packages used in the project:

Serilog: 2.6.0
Serilog.Sinks.MSSqlServer: 5.1.2
Serilog.AspNetCore: 2.1.1

Target framework and operating system:
.NET Core 2.1
OS:
Windows 10.
Code:
public class Program
{
    public static void Main(string[] args)
    {
        Log.Logger = new LoggerConfiguration()
            .MinimumLevel.Debug()
            .MinimumLevel.Override("Microsoft", LogEventLevel.Information)
            .Enrich.FromLogContext()
            .WriteTo.MSSqlServer(
                        @"Server = (localdb)\\MSSQLLocalDB; Integrated Security = true; Initial Catalog = mydatabase; Persist Security Info = True",
                        "Logs",
                        autoCreateSqlTable: true)
            .CreateLogger();

        Log.Information("Starting web Building"); // <-- Doesn't write anything to the database

        try
        {
            CreateWebHostBuilder(args).Build().Run();
            Log.Information("Starting web host"); // <-- Doesn't write anything to the database
        }
        catch (Exception ex)
        {
            Log.Fatal(ex, "Host terminated unexpectedly");
            throw;
        }
        finally
        {
            Log.CloseAndFlush();
        }
    }

    public static IWebHostBuilder CreateWebHostBuilder(string[] args)
    {
        var config = new ConfigurationBuilder()
            .Build();

        return WebHost.CreateDefaultBuilder(args)
            .UseConfiguration(config)
            .UseSerilog()
            .UseStartup<Startup>();
    }
}

`

For starters, try using one of the dev packages, current dev release is:
https://www.nuget.org/packages/Serilog.Sinks.MSSqlServer/5.1.3-dev-00226
I've got a pretty big group of changes in progress and then I'll probably ask Nick to consider a full release (it has been awhile), but for now that's the latest and greatest, and it has changed quite a bit from 5.1.2.
If that doesn't get you going, look for errors by enabling SelfLog and let us know what you're seeing.

Thank you for the quick response.
I actually enabled the SelfLog (to file) and unfortunately got nothing in that log file either (although the process creates the log file, it is empty).
Will try it outside VS and keep you posted. Thanks.

So I installed Serilog.Sinks.MSSqlServer 5.1.3-dev-00226 and now I get the following error from the SelfLog:

2018-10-10T07:59:29.0653732Z Unable to write 6 log events to the database due to following error: A network-related or instance-specific error occurred while establishing a connection to SQL Server. The server was not found or was not accessible. Verify that the instance name is correct and that SQL Server is configured to allow remote connections. (provider: SQL Network Interfaces, error: 50 - Local Database Runtime error occurred. Specified LocalDB instance name is invalid.
)

While it looks like an isolated network/database issue I have to emphasize that the other part of my ASP.NET Core 2 app works fine with the same database connection (using EF Core). The connection string is:

"Server=(localdb)\MSSQLLocalDB;Integrated Security=true;Initial Catalog=myDatabase;Persist Security Info=True"

Does Serilog SQL have a problem with "Windows Authentication" mode (Integrated Security)?

Turns out that it was really a bad connection string issue!! I had to remove one of the backslashes  when I copy/pasted the connection string from appsettings.json into a @"" string in Program.cs. Ouch!

Thanks for following up. I'm making some other changes and I'm going to expand what SelfLog reports, I'll add this situation to the list. The SQL sink fails silently in far too many scenarios for my taste. Glad you're up and running.


Support database transactions

Functions exposed in file named database_psql.go doesn't allow me to send transactions to database as it doesn't have a specific function that deal with pq driver transaction function.
I think we can solve this issue by generating new function that uses pq driver transaction functions.
Thanks in advance

I agree it'd be nice to support transactions explicitly somehow. You can access the driver in the meantime I think.

first thanks for your reply ,
I think transactions is very common and essential  functionality, so it would be nice if it's handled in next release/update.


Gauri development

-I added support for a basic admin page only accessible by url for now. can be reached using the /admin url.
-it will currently work if your username is beckyqiu or gaurijain so try making a fake account with those or try it with other accounts to see how it denies access. Ernesto/Maria I will update it with your usernames shortly, just lmk which names you want me to include!
-lastly I'm trying to figure out the best way to test whether the jsp is outputting the correct thing on the page based on what your username is. What would be the way to do that?
Here are the UI screenshots!

@TF3FAN so thats a good point. Currently what I'm thinking is maybe we add a tab to the toolbar for the admin page but that tab will only show up if an admin logs in. Currently the only way to access the page is to use the link, so if for some bizarre reason a non-admin got ahold of the admin link, we would just deny access. Let me know what you think! This is actually something I was still unsure about design wise as well.
@mrios730 So for now I'm thinking of just making a function that can return the number of users from the UserStore class or the number of conversations from the Conversations class. I have the getSize() working for users and will do conversations soon! Do you have ideas for other things that might be good to include for the MVP? And yeah I'll definitely try to add more tests here as we go. I wasn't sure how to test the super basic page beyond just making sure it reached the webpage, but I should hopefully have more soon.


update CI workflows

use the charmed-kubeflow-workflows/build_and_publish_rock.yaml workflow
remove unused workflows

Because this cannot be tested without having a version of it in main, I'm pushing this without full review and will revisit in a future PR.  This CI and repo are not yet in production use so mistakes wont have severe consequences.


Issues using DynamoEventSource

Describe the bug
Following guide to attach a trigger to DynamoDb throws the following compiler error:.
error TS2345: Argument of type 'import(".../node_modules/@aws-cdk/aws-dynamodb/lib/table").Table' is not assignable to parameter of type 'import(".../node_modules/@aws-cdk/aws-lambda-event-sources/node_modules/@aws-cdk/aws-dynamodb/lib/table").Table'.
Types have separate declarations of a private property 'table'

Doing @ts-ignore on it, throws:
.../node_modules/@aws-cdk/aws-lambda-event-sources/lib/dynamodb.js:17
target.addEventSourceMapping(`DynamoDBEventSource:${this.table.node.uniqueId}`, {
^
TypeError: target.addEventSourceMapping is not a function
at DynamoEventSource.bind (.../node_modules/@aws-cdk/aws-lambda-event-sources/lib/dynamodb.js:17:16)
at Function.addEventSource (.../node_modules/@aws-cdk/aws-lambda/lib/function-base.js:150:16)

To Reproduce
Use fn.addEventSource(new DynamoEventSource(table, { startingPosition: StartingPosition.Latest }));.
Expected behavior
It might work as stated in docs
Version:

OS: Linux
Programming Language: TypeScript
CDK Version: 0.31

Can you please ensure that all your dependencies use the same CDK version and recreate your node_modules

Sure let me rebuild everything

@eladb thanks! you were right, all was about "@aws-cdk/aws-lambda-event-sources": "^0.32.0", and the rest of dependencies pointing to 0.31.0

Yap


Fixed link to bug tracker.

Link to crbug.com corrected, old link was TBD.
Fixes: Broken bug tracker link referenced at bottom of article
Target Live Date: 2018-10-30
Minor editorial fix

[X ] I have run npm test locally and all tests pass.
[X ] I have added the appropriate type-something label.
[ X] I've staged the site and manually verified that my content displays correctly.

CC: @petele

:tada: This has been pushed live to https://developers.google.com/web/


Can't download Youtube Playlist

Trying to download an entire Youtube playlist, around 102 videos in all. Im getting this error when I run it (pic attached)

How to report bugs.


手动安装的pyhanlp无tests.test_utility模组

Describe the feature and the current behavior/state.
自动安装失败，使用手动安装，from pyhanlp import *可以成功调用hanlp
Will this change the current api? How?
但是后续学习遇到了这个代码——from tests.test_utility import ensure_data
Who will benefit with this feature?
提示不存在这个模组，请问如何解决？
Are you willing to contribute it (Yes/No):
yes
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Python version:
HanLP version:

Any other info

[x] I've carefully completed this form.

https://bbs.hankcs.com/