Using tests from test262

Hi!
Here are some changes based on the latest spec changes:

Array operations no longer use ToUint32. Instead, they use ToLength which makes much more sense.
Uncallable predicates must throw even when the array is empty.

The changes to the polyfill have been applied in master:

Array operations no longer use ToUint32. Instead, they use ToLength which makes much more sense.
-- https://github.com/paulmillr/Array.prototype.find/blob/master/implementation.js#L8
Uncallable predicates must throw even when the array is empty.
-- https://github.com/paulmillr/Array.prototype.find/blob/master/implementation.js#L9

@juandopazo would you mind freshly rebasing this on top of master so it can be reconsidered?


Feedback on Networking ressources

HA&DR Patterns in Network connectivity.pdf
Change the footer to 2023 and add 'Public' to the footer

Forwarding DNS requests to multiple On-Prem DNS Servers reference architecture.pdf
Change the footer to Public

Simple deploy guide of Private Dns integration with On-premises.pdf
Change the footer to 2023 and add 'Public'

HA&DR Patterns in Network connectivity.pdf - will fix footer after July 18th . Rest both were fixed and sent for review.


Hides editor when setting Scrollbar to ssHorizontal

Set TBCEditor.Scroll.Bars to ssHorizontal => the editor disappears

Fixed.


Ignore package-lock.json in all repositories

Per discussion in https://github.com/probot/friction/issues/4, we're going to ignore package-lock.json in all probot projects. This should be a relatively easy task for new contributors, and will result in multiple pull requests.
For each repository:

Fork and clone the repository
Create a new branch: git checkout -b ignore-package-lock
git rm --cached package-lock.json
echo "package-lock.json" >> .gitignore
git commit -am 'chore: ignore package-lock.json'
Push to your fork and submit a pull request, and reference this issue in the pull request body with /cc probot/probot#291
Pat your self on the back and wait for your pull request to be reviewed and merged.

TODO:

[x] probot
[x] settings
[x] dco
[ ] stale
[ ] github-app
[ ] create-probot-app
[ ] scheduler
[ ] no-response
[ ] autolabeler
[ ] autoresponder
[ ] metrics
[ ] reminders

Fixes https://github.com/probot/friction/issues/4

working on it....

All done! There are ways to automate commits via bots? I made a script for those changes, will be really useful to automate those kind of improvements/changes

Thanks @dnldsht!

I added a few more repositories to the list that I accidentally left out of the original list:

[ ] template
[ ] linter
[ ] metadata
[ ] commands

@bkeepers done also for the new ones!

All the PRs have been made, so I'm going to close this out. Thanks everyone!

Hi, I am contacting you because one of the repos we use  ( https://github.com/ghsteam/hospice-system ) is reporting incorrect  vulnerabilities.
Alerts from package-lock.json file are being reported, but right now the project is using yarn.lock and composer.lock only, it does not use NPM.
There are also very old branches and i don't know if the file exists there. But it does not exists in master, development or the other branches that we currently use.
Is there a way to narrow the scope of the alerts to composer.lock and  yarn.lock files , and to  master and development branches only ?


FR: Open periodic note in a new pane if it isn't already open

The idea: provide a simple way of opening periodic notes in a new pane, instead of taking over the current pane.
Right now, the options to do so include:

Remember what day it is (ha!) and use the Quick Switcher to type out the filename for the corresponding periodic note, or find it in the file explorer, and open it as a new pane
Open an arbitrary new pane (e.g., open the Quick Switcher and just hit enter on the first result), then invoke the Open [period]'s Note command

Pseudocode:
- Invoke command
- Get the filename for the target note
- Get the open panes
- Check open panes: does one have the filename of the target note?
    - if yes, focus on it
    - if no, open a new pane, then open the target note in the newly opened pane

I think this would be a good addition to the NLDates quickswitcher https://github.com/argenos/nldates-obsidian/issues/9
assigns FR to @argenos

@liamcain do you have the option to transfer the issue to the nldates repo? I might be able to finally ship the date navigator (thinking mid-July) and I might be able to include this.

Hi, just came to post the exact same feature request as Ryan's. :) This would be really helpful, especially if it can be assigned a keyboard shortcut.
I am also using the workaround Ryan suggests (quick switcher to open a random note in a new pane before switching to Today's note).

Adding a note to support the open in new pane request.
In the core Daily Notes plugin, pressing command+enter on the 'open today's daily note' command opens the note in a new pane rather than the focussed pane. It would be great if this plugin also had that functionality.


Guidance required : generate boot.img and boot.sign using yocto project for secure boot

As of now , I was manually making boot.img, signing it using usbboot(https://github.com/raspberrypi/usbboot) tool for my custom yocto based image.
I would like to incorporate above step in yocto toolchain. So that I will get final signed image from yocto itself. The hardware is rpi CM4. Once I have achieved this I would like to enhance this and generate complete chain of trust including rootfs with help of yocto project.
I was not sure how to start with this, I was wondering if someone from the community has already given it a try or know how to proceed with this. If anyone can guide me or would like to contribute that will be really helpful.
Additional information:
My current steps are.

Generate custom linux image using yocto.
Flash the image to compute module 4 using usbboot/rpiboot.
Check content of the boot partition. copy the content to a folder secure boot files.
Generate a boot image using make-boot-image in usbboot.
Sign the boot image using rpi-eeprom-digest of usbboot.
copy paste the boot.img and boot.sign in boot partition of cm4
Now the cm4 boots in secure boot mode using the boot.img and boot.sign

What I want to achieve:

Generate boot.img and boot.sign in yocto itself so that I don't have to do steps 2,3,4,5,6.
The yocto project will generate boot.img , sign the image and place it in boot partition of my linux OS.

Let me know if you have any idea or  if you have already achieved this.

This looks like something useful to have in. We would need to have a way to generate the images that create a signed fat fs image. It shouldn't be that complicated, to be honest. We would need to move things from the boot partition to a filesystem image file with the ability to expose the key for signing. Obviously, the integration of the RPI sign tools will also be needed. This sounds like a variable which would enable the above. How does that sound to you?

Thank You @kraj for your comment.
@agherzan Yes, you understood it correctly  and that's what I am currently working on.
Right now I am trying to achieve it using post-build script in yocto. People have already used postbuild.sh in buildroot to achieve the same. (https://github.com/raspberrypi/usbboot/issues/147)
So my goal is:

copy content of boot partition to specific path.
Use this content to generate the boot.img utilising usbboot make-boot-image.
Sign this image using usbboot rpi-eeprom-digest.
In the end copy this newly generated boot.img and boot.sign into original boot partition
Make the image using this updated boot partition.

I will use the same key (used in point 3) to sign the EEPROM OTP Fuses. Doing this we can achieve a secure root of trust with signed boot and kernel image. I am yet to figure out about signing the rootFS and adding it to the chain of trust. This is something I will do next.
So any inputs regarding post build script or if you know any alternative in yocto that will be also helpful.

my suggestion is to bundle the final artifacts using wic process. Having custom SD card generation scripts or process should be avoided for best results.

@kraj of course. I didn't propose external tooling to wic.
The way I see it right now is the following. When SIGN = 1 (variable name to be defined):

Filter out assets that are meant to be deployed as a signed fat image from IMAGE_BOOT_FILES.
Have wic depend on a recipe:do_deploy (which depends on the recipes providing/deploying all the assets needed in the signed image). This new recipe will generate the signed image by taking the input from the deploy directory and generating the signed image based on a key defined in another variable.
Add the signed file in IMAGE_BOOT_FILES.

As a side note, 1 above can be optional but I don't see why not do this clean and avoid duplication (that has an impact on handling updates for example).


Graphviz generated illegible text

Switching to a PNG format that outputs readable text in the graph.

bump!


Potential New Categories of Response

derive_param_bor and derive_param_confirmed_bor (and maybe others) may need to be updated to handle additional response values above the default set: c("CR", "PR", "SD" , "NON-CR/NON-PD", "PD", "NE", "ND").
I have seen examples in testing of UNDEFINED, there may be more once testing begins, so we need to address this at some point.

@amitjaingsk also raised: some vendors also use 'NA' instead of ND ( no disease)

@rossfarrugia @amitjaingsk This issue is pertinent to todays discussion. Maybe we do need a mechanism to convert AVALC into a numeric sort for determining best response.

@sgorm123 discussed briefly this point with @bundfussr before and the feeling is things like BOR are likely going to need different functions for new response criteria beyond RECIST (where new response values like iCR etc get considered) as trying to make a single function to cover all could end up unimaginably complex to maintain and test. I do feel though improvements like being discussed at https://github.com/pharmaverse/admiralonco/issues/85 could definitely make the simpler functions more robust to work across different response criteria/onco indications.

@rossfarrugia , I would keep the question how we implement different response criteria beyond RECIST 1.1 open. When I got two example specs for other response criteria I was quite surprised by the variety of response values. Unfortunately, the specs did not include any confirmed endpoints. I would like to have a better overview of the different response criteria and try to find out what is common across them and what is different. I think without that it is hard to decide on a good approach.
I am concerned that if we decide now to implement new functions for each response criterion we end up with ten different BOR and ten different confirmed BOR functions. This could be as hard to use, maintain, and test as one complex function covering all.

Yes fair point - no hard decisions needed yet on this front. I think for now we need to go with...

AUG: minor fixes for documentation etc for tester feedback
SEP: CRAN release and then start to share specs around new response criteria/indications and make some proposals on next set of enhancements (along with ADTR)
This of course depends on getting the collaboration agreement finally...

As mentioned in our last call, could you check if you are have come across response value of 'NED' - Now evidence of disease? This seems to be appear in BICR data. @irgsandy I wondered if you have since I understand you work a lot with BICR data? I would appreciate feedback so we can assess approach internally.

No evidence of disease :)

When no target and non-target lesions are identified at baseline, no new lesins are identified on study, the response will be NED. The baseline value is populated as NA, and the TPR is NED.
In our study, some of the data are reviewed by investigator, and some by BICR. They do not cross check each other.

Other response values can be handled by derive_extreme_event() now (see (Creating ADRS (Including Non-standard Endpoints))[https://pharmaverse.github.io/admiralonco/main/articles/adrs.html] for details).
Thus this issue can be closed.


Data or config driven additions

It would be cool if we could add custom blocks to the generator either via a config(preferred) or via a data pack.
something like EXAMPLE
}
}
minecraft:stone
SU threshold #
outputamount:
outputtime:
ect ect that way it could be used for modpacks for greater customization then we could configure blocks and make more expensive blocks take a long time and with low output if we want

In the new beta, included is the option to add generators using a datapack. See for example https://modrinth.com/datapack/create-cobblestone-deepslate-generators.
It only includes the option to add a generator for now but i will be changing this.
Modrinth
Fabric: https://modrinth.com/mod/create-cobblestone/version/1.4.1-beta+fabric-1.20.1-56
Forge: https://modrinth.com/mod/create-cobblestone/version/1.4.1-beta+forge-1.20.1-56

I also got the other stuff working: https://www.youtube.com/watch?v=c_1c3vrQKR8
The config for deepslate i used for showcase is:
{
  "block": "minecraft:deepslate",
  "stress": "1024",
  "ratio": "80000"
}

When a field is not in the json it will take the value from config.

I would appreciate it if you could test if this is what you wanted and check for bugs.
Modrinth
Fabric: https://modrinth.com/mod/create-cobblestone/version/1.4.1-beta-2+fabric-1.20.1-59
Forge: https://modrinth.com/mod/create-cobblestone/version/1.4.1-beta-2+forge-1.20.1-59

Changelog:

empty generator is now the first in creative menu
all generators can now be disabled using datapacks
/datapack enable/disable now automatically updates generator types, allowing the hotswapping of datapacks
fixed crash with create liquid fuel
deepslate generators are now enabled with datapack by default

Downloads
Fabric: https://modrinth.com/mod/create-cobblestone/version/1.4.1-beta-3+fabric-1.20.1-65
Forge: https://modrinth.com/mod/create-cobblestone/version/1.4.1-beta-3+forge-1.20.1-65
Example datapack: https://modrinth.com/datapack/create-cobblestone-deepslate-generators/version/1.4.1+1.20.1

I would appreciate it if you could test if this is what you wanted and check for bugs.

I have a mod adding a volcanic rock and cobble from Terrestria via the new data API, and while it works fine on the integrated client/server, when using a discrete server, the client crashes on the first attempt to view the creative inventory.
The top of the stack looks like this (let me know if you need further info, but I'm guessing this is just a matter of the client mod not getting fully initialized).
java.lang.NullPointerException: Cannot invoke "net.createcobblestone.data.GeneratorType.getId()" because "net.createcobblestone.data.GeneratorType.NONE" is null
	at net.createcobblestone.index.RegistrateDisplayItemsGenerator.accept(RegistrateDisplayItemsGenerator.java:30) ~[createcobblestone-1.4.1-beta-3+fabric-1.20.1-65.jar:?]
	at net.minecraft.class_1761.method_47306(class_1761.java:101) ~[client-intermediary.jar:?]
	at net.minecraft.class_7706.method_47338(class_7706.java:2052) ~[client-intermediary.jar:?]

Could you send the datapack?

Log:  https://mclo.gs/qIp7SiF
The datapack is bundled in a mod.  I'll upload that or commit it to github or something, soon.

GitHub is a pain sometimes.  Datapack is here:  https://github.com/gniftygnome/cross-pollination/tree/main/src/main/resources/data/createcobblestone/generator_types

The fabric version is working now, but you need a github account to download it. i will publish it to modrinth once i get it working.
gh actions link: https://github.com/StickyPiston-development/CreateCobblestone/actions/runs/11709890769

I've confirmed it's fixed.  Thanks!

On fabric it works, forge will not work and will probably break your existing generators.

Released on modrinth:
Fabric: https://modrinth.com/mod/create-cobblestone/version/1.4.1-beta-4+fabric-1.20.1-72
Forge: https://modrinth.com/mod/create-cobblestone/version/1.4.1-beta-3+forge-1.20.1-65

Two weeks have past and no unclosed issues were opened, im going to upload the mod to curseforge and modrinth as release soon!

Released the following on both curseforge and modrinth:
Create Cobblestone 1.4.1
Warning: wipes all deepslate generators without the deepslate generators datapack
all changes from 1.4.1-beta and above:

custom generator types using data packs

all generator types can be disabled using datapacks
generator type datapacks can be hotswapped on both servers and clients using /datapack enable and /datapack disable
deepslate generators are now a seperate datapack (https://modrinth.com/datapack/create-cobblestone-deepslate-generators) but are still configurable in the config screen, this way they are more deeply integrated with the mods generator system and this will hopefully lead to less bugs.
all generator types can now have a custom stress, ratio and storage amount set using datapacks
custom generator types are added to the creative inventory

reordered generators in creative menu
updated the mod icon to the new create icon standard
cleaned up the mods code
fixed a crash on the client when joining a server

Modrinth
Fabric: https://modrinth.com/mod/create-cobblestone/version/1.4.1+fabric-1.20.1-73
Forge: https://modrinth.com/mod/create-cobblestone/version/1.4.1+forge-1.20.1-73
Deepslate generators datapack: https://modrinth.com/datapack/create-cobblestone-deepslate-generators/version/1.4.1+1.20.1
Curseforge
Fabric:  https://www.curseforge.com/minecraft/mc-mods/create-cobblestone/files/5930734
Forge: https://www.curseforge.com/minecraft/mc-mods/create-cobblestone/files/5930737
Deepslate generators datapack: https://legacy.curseforge.com/minecraft/data-packs/create-cobblestone-deepslate-generators/files/5930722

To everyone who helped with testing: Thank you it helped a lot and a lot of bugs are fixed with your help!


hjson

I recommend that Jasonette supports config files in the hjson format ( http://hjson.org/ )
This would demand a parsing of the config file after downloading it before using it as its used today.
Pure JSON would still work, but errors like an  extra , after last element in an array would not spoil it all.
Another plus is that the developer can have comments in the config file and comment whole sections  out (not possible with JSON)
Update: Inspired by http://nshipster.com/javascriptcore/ I have a feeling it could be implemented without much fuzz with JavaScriptCore
let configfileContent = sameWayToFetchFileAsToday();

do {
	let hjsonSrc = try String(contentsOfFile: 'path/to/hjson.js', encoding: NSUTF8StringEncoding)
} catch let error as NSError { print("Error: \(error)")  }

let context = JSContext()

context.evaluateScript("var hjson2json = function(hjson){ return JSON.stringify(Hjson.parse(hjson), null, 4); };")

let hjson2json = context.objectForKeyedSubscript("hjson2json")

let configJson = hjson2json.callWithArguments([configfileContent])

You might want to use the hjson.js file from http://hjson.org/js/hjson.js where its already "browserified".

Thanks for the suggestion! Let me look into HJSON. Will keep you posted.

OK I've looked into HJSON and it won't be much of a problem to implement, especially since Jasonette already makes use of JavascriptCore in some cases.
I actually even started writing code and was almost half done when I started having some questions, so decided to throw them out here first before going forward with this:

Is there any popular server API that returns anything in HJSON format? If not, wouldn't one need to write an HJSON template engine to fill out the data when returning?
Also, do we really need Jasonette to be the one that translates HJSON? How about writing the markup in HJSON, but run it through a HJSON-to-JSON template engine on the server side before returning? (Example)

I guess I'm having these questions because there definitely are overheads for parsing on the client side. I think this on its own is worth it if I didn't have above questions. But if there aren't many HJSON-returning servers out there, I think it may be a better idea to build the HJSON-to-JSON adapter on the server side and let Jasonette deal with pure JSON.
But I'm just a HJSON newbie so please share your thoughts!

my 2cts: we don't need hjson

Is there any popular server API that returns anything in HJSON format? If not, wouldn't one need to write an HJSON template engine to fill out the data when returning?

If you have a templatingengine you can just as well produce JSON

Also, do we really need Jasonette to be the one that translates HJSON? How about writing the markup in HJSON, but run it through a HJSON-to-JSON template engine on the server side before returning? (Example)

Its for the convinience of people who edits things manually. When was the last time you had to edit a multiline field in JSON - it sucks... and tiny aspects about the JSON format as trailing comma makes it harder for new people to get on going.
This is for the onboarding of Jasonette. The overhead is minimal, and people generating JSON will not feel any difference.

Maybe HJSON support should come in the form of "you can use it if you want, but the app only supports JSON" In other words, tooling for using HJSON lives outside JSONETTE, and there's something like a plugin, which can convert those files into regular JSON. keeps the server and app clean, and let's people use what they want.
I assume this must already be possible. Let JSON be the assembly language of JASONETTE :)

@mathiasrw I was going to keep this open for a bit before deciding, but I think we have enough opinions on this and I also came to agree that it's better to do this on the server side.

Its for the convinience of people who edits things manually. When was the last time you had to edit a multiline field in JSON - it sucks... and tiny aspects about the JSON format as trailing comma makes it harder for new people to get on going.

I totally agree with your point, but I think my point was that we may be able to do this server-side, just like @booc0mtaco said. For example a user could write everything in HJSON, and host it on a pastebin service which internally stores it as HJSON but serves it as JSON using the server-side adapter. I already have a json hosting site for Jasonette apps running, and I can imagine supporting HJSON on the jasonbase site in the future.
Actually I have thought about this for the last couple of days and realized some of the actions I already have implemented are relevant to this discussion: https://jasonette.github.io/documentation/actions/#conversion
I wrote them during the early development stages of Jason. And if I think about it now, the $convert.html action is super useful and I think it deserves its place as an api. But I'm rethinking whether $convert.rss and $convert.csv should be in the main API set. Because there are a lot of useful data formats we can convert to JSON, but if we start adding them one by one this will become as bloated as regular web browsers.
Bottom line: Since all web servers can return JSON, I think it's better to write adapters on the server-side that turns whatever data format into JSON. That way it's much more scalable since we don't have to keep adding conversion features to the Jasonette binary every time we need to.
Hope this makes sense!


SMD-822 - Factor out control mappings

Ticket
Factor out control mappings
Change summary

Replacing programme_id_to_project_ids with programme_to_projects
This allows simplification within cross-table validation as we don't need to run lookups.

Using programme names not IDs for bespoke outputs and outcomes lookups
This allows simplification within cross-table validation as we don't need to run lookups.

Removing control mappings dependency from cross-table validation
The original purpose of having a control mappings module was to share functionality across cross-table validation and transformation, and share functionality across functions within those modules too - however, in practice many of the control mappings were used in one single function in either cross-table validation and transformation, which meant the abstraction became more confusing than helpful. In this change, we remove the external dependency on control mappings from cross-table validation, generating mappings within the functions they are used.

Updating docstrings in cross-table validation
Docstrings have been updated so that all include parameter and return type definitions and descriptions. Also transferred duplicate message about adding 1 to cell index to module docstring.

Removing control mappings including transformation dependency
The only place remaining in the code where control mappings are used is transformation, as the dependency in cross-table validation was previously removed. By generating the required mappings in the transformation module, control mappings become redundant and we can remove the module and its corresponding test module.

This all looks and runs good for me, so I'm happy. Feels a lot cleaner. You may want to get another pair of experienced eyes over this though if you want some extra certainty - up to you ...

Thanks @samuelhwilliams - I've just examined the changeset line-by-line and I'm happy to go ahead without secondary review, will merge now


navigate({ search }) TypeScript error in beta.25

Describe the bug
After upgrading to beta.25 all uses of navigate({ search }) now results in the following TS error:
Type 'any' is not assignable to type 'never'.

example:
navigate({
      search: (old) => ({
        ...old,
        resource: newResource,
        selected: undefined,
      }),
      replace: true,
    })

Your Example Website or App
see example above, let me know if you need a StackBlitz
Steps to Reproduce the Bug or Issue

Note this happens both with useNearestMatch() and useMatch(route.id)
Expected behavior
Should not cause TS error
Screenshots or Videos
No response
Platform
"@tanstack/react-router": "0.0.1-beta.25",
Additional context
No response

A stackblitz would be great.

@tannerlinsley Sorry this was my bad, I had an outdated node_modules.
I can still reproduce an issue but only with useNearestMatch() now, which I imagine is the same problem as https://github.com/TanStack/router/issues/372
Here's a stackblitz where search gives a TypeScript error for useNearestMatch()
https://stackblitz.com/edit/tanstack-router-af8ox9?file=src/main.tsx

So can search be empty?

I believe you should have a much better experience now. Give it a shot!


Integrate jsonfield_compat

This commit integrates django-jsonfield-compat which aims to fix #71 .
After using this branch, add
USE_NATIVE_JSONFIELD = True

to your project's settings, and then run python manage.py migrate.
This will update auditlog's LogEntry model to be a native JSONField type. You can switch everything back by changing the above setting to False, just be sure to run migrations afterwards.

At this moment there is an issue with this solution on Python 3.

The package I uploaded to pypi originally was for python2 only. I've updated that now.

Great, it builds now as well :-)
I like to hear when you think it is mergable.

I finally got around to adding a wider range of tests to django-jsonfield-compat, and am now comfortable with this being used a by a wider audience.

While I still am in favor of a compatibility layer I do want to see your particular solution before accepting these changes. You will hear from me soon.

I do not really like the fact that you do some SQL "fixes", can you elaborate a bit more on your implementation?

I chose to use direct DB manipulation so a simple Django setting could be used instead of having to create a migration for every model that used a JSONField.
The register_app call adds a post-migrate handler which may update the column type of all fields defined as jsonfield_compat.JSONField.
First, the column types are determined by this query.
We then check whether the database field type should be TEXT or JSONB depending on the USE_NATIVE_JSONFIELD setting.
If the DB field type needs to change, it runs the update query.
Let me know if you want me to go into more depth.

I do not agree with you on the migrations part, I think having migrations for these kind of things is a good thing. Hacking in SQL should - in my opinion - never be done except in one-time, custom migrations where it is unavoidable.
I do not feel comfortable imposing your solution on the users of this library since I do not feel comfortable with it myself, so I will not merge this pull request.
Still, the issue you try to fix here is somewhat important. Another solution is therefore appreciated, for example just a wrapper around the two classes which imports and returns the right class for the environment.

What user experience would you want for implementers who have already integrated django-auditlog and now want to switch to using the native JSONField implementation?
Assume their projects also include include django_jsonfield via other common libraries (e.g. django-activity-stream and django-geojson), and directly in their custom apps.
There can be no mixing of native with jsonfield, so all apps have to switch at once.
I'm motivated to build support to make this work, as our company is in the situation I mention above.
(We already have custom builds of the three libraries that make this change, but we don't want to maintain a fork forever.)

I think a settings switch is still permissable, but as stated above I am not a fan of executing SQL ALTER statements manually outside of migrations (it might very well be the only practical way though). I realize that creating a migration for an external library is not something you would want to do as well. Maintaining two versions is also not a very good solution. So you could say that I am conflicted.

FWIW, @kbussell PR working for us.  We had been using Postgres native JSONField across the project, and are just bringing in auditlog now, which caused all of our JSON fields to become strings.  Switching to this branch and adding USE_NATIVE_JSONFIELD = True was perfect for us.
However, my 2c: If I had been using TEXT json fields, I'd be pretty furious if adding auditlog had the secret side effect of converting my entire database schema's JSON fields from TEXT to JSONB.  I think it would be nice if auditlog could detect that you're in this bad situation and tell you, and the USE_NATIVE_JSONFIELD switch is fine.  But effecting that migration has to be VERY explicit and very intentional on the part of the user.

@kbussell @jjkester I'm seeing an issue with the diffing of JSON columns, which may be caused by this change.  My JSON is coming up as "changed" but it's just that the keys changed orders. It seems auditlog.diff.get_field_value needs to be special-cased for JSON fields.

Hello people. Is there somebody who can look into this PR again, please? Native JSON fields of Postgres are pretty important nowadays and crucial for many libraries and projects.

Hey @eriktelepovsky , this PR came to a bit of stand-still because of how to proceed with the implementation, the core issue is that if we proceed with this implementation and you switch your database (e.g. sqlite -> postgres), the next time you run python manage.py migrate there would be sql statements run that alter your data to the new format, and could corrupt it or mess it up, and you would have no idea as a developer that it was going to happen.
@jjkester was suggesting that a settings switch like AUDITLOG_USE_NATIVE_JSONFIELD could be added instead so the developer has to make a conscious decision to run the SQL alterations and with the right docs should be able to make a smooth transition from a DB that doesn't support JSON to a DB that does (e.g. Postgres).
We would need to make or modify this PR to be based off the settings switch, and then do some testing where we take a Sqlite3 database using django-jsonfield and convert it to Postgres and see how it goes. We also need to ensure as @ses4j mentioned that the diff algorithm correctly handles both types in a sane manner, and then we need to write good docs about how you transition from a django-jsonfield db column to a native one. So I think due to the large scope, it just hasn't seen forward progress.
If people want to contribute to this issue I can help them along but I don't have the time to work on it right now and it is also not a problem I have in my own use-case for this library at work so I can't justify time at work to fixing it.

Hi @eriktelepovsky,
If you are in a hurry, use my fork:
git+https://github.com/florencioq/django-auditlog.git
It works together with django-jsonfield-compat as a workaround for this issue.
Just replace 'django-auditlog' by 'git+https://github.com/florencioq/django-auditlog.git' in your requirements.txt.
Take care,
José

Thank you @florencioq . Actually, @kbussell already did the same in his commit of his PR. I believe, the best possible solution would be a direct implementation of django-jsonfield-compat into django-jsonfield so any library using JSONField could gain from its purpose.

While this PR continues to stall, I made a v0.4.5 version of this if anyone wants it:
pip install<EMAIL_ADDRESS>

Please consider using models.JSONField since Django 3.1 that can be used on all supported database backends:
https://docs.djangoproject.com/en/3.1/releases/3.1/#jsonfield-for-all-supported-database-backends

Since the minimum supported version is django 3.2, there is no need for this pr.
I vote we close it.
@hramezani


Sentient Artifacts (and maybe other ghost roles?) still show up in the ghost role list after being taken.

Description

Title says it all. Only one player can take the ghost role, though it still shows up on the list.
Reproduction

Seems to happen naturally with artifacts. Unsure of any other ghost roles that do it.
Screenshots

Additional context

Happening on lizard right now


Bad Issue Exception For Issue with Single Label in Except List

For an issue I have it labeled as "wontfix", this is also configured in the "except" labels list in the config.
Despite this, I'm getting the following exception (emphasis mine):

Bad Issue Issue Path Omitted expected to find a single label with either Bug, Feature, Improvement, Question, wontfix or Refactoring.

I can't see why this would be.

The only way I can make it happy is to add a label that is in the include section e.g. "Improvement" the problem with this is that it's an issue that was closed, but shouldn't show in the release notes as nothing was done with it.

ReleaseNotesBuilder -> CheckForValidLabels
private void CheckForValidLabels(Issue issue)
{
    var count = this.configuration.IssueLabelsInclude.Sum(issueLabel => issue.Labels.Count(l => l.Name == issueLabel));

    if (count != 1)
    {
        var allIssueLabels = this.configuration.IssueLabelsInclude.Union(this.configuration.IssueLabelsExclude).ToList();
        var allIssuesExceptLast = allIssueLabels.Take(allIssueLabels.Count() - 1);
        var lastLabel = allIssueLabels.Last();

        var allIssuesExceptLastString = string.Join(", ", allIssuesExceptLast);

        var message = string.Format(CultureInfo.InvariantCulture, "Bad Issue {0} expected to find a single label with either {1} or {2}.", issue.HtmlUrl, allIssuesExceptLastString, lastLabel);
        throw new InvalidOperationException(message);
    }
}

It appears it is indeed only counting the "include" labels to see if the issue has valid labels, yet the message considers both sets of labels in the config.

I've started working on a potential fix locally as I need this to work as part of our evaluation of GitReleaseManager.
My thoughts on behaviour:

If there aren't any labels on an issue - throw
If any labels aren't in either of the lists - throw
If any labels are in both lists - throw
If an issue has at least 1 label in the exclude list (regardless of number of labels in include list), then skip it for the release notes.

Obviously it would be useful for these to be configurable in some fashion.

Thought about point 4 and that doesn't seem right now.
We have a project management system we're trialling for GitHub and it applies labels like "in-progress" etc based on position of an issue through a Kaban board.
Obviously then an issue may be:

Fix Some Bug (Bug, Completed)

With Bug being an include label, and Completed being an exclude, then this needs including.
On the flip of that, if an issue has something like:

Fix this Bug that Only I Can Make Happen (Bug, Cannot-Reproduce)

With Cannot-Reproduce being an exclude, then this needs to not be included.
The best solution to this will probably be to introduce label precedence in the ReleaseManagerConfiguration.yaml (perhaps like the below?)
label-precedence:
 - Cannot-Reproduce
 - wontfix
 - $include
 - $exclude

So that certain exclusions can be considered ultimately important if they're encountered on an issue, and then everything else is processed based on the action that would be taken otherwise.
Could have replacements like $include and $exclude to expand remaining labels
So a config like:
include-labels-list:
 - Bug
 - Improvement
 - Feature
exclude-labels-list:
 - Cannot-Reproduce
 - Complete
 - wontfix
 - Question
 - Refactoring
label-precedence:
 - Cannot-Reproduce
 - wontfix
 - Question
 - Refactoring
 - $include
 - $exclude

Would result in the following overall precedence:

Cannot-Reproduce
wontfix
Question
Refactoring
Bug
Improvement
Feature
Complete

The below table illustrates the behaviour that would be taken given different label combinations.

Label Present
Action

Cannot-Reproduce
Exclude

wontfix
Exclude

Question
Exclude

Bug
Include

Improvement
Include

Feature
Include

Bug, Cannot-Reproduce
Exclude

Improvenent, wontfix
Exclude

Cannot-Reproduce, wontfix
Exclude

Bug, Complete
Include

Bug, Improvement
ERROR

Default behaviour for a config missing this section could be to simply continue using the existing behaviour, so as to not cause any issues with installation out in the wild.

@ckpearson said...
We have a project management system we're trialling for GitHub and it applies labels like "in-progress" etc based on position of an issue through a Kanban board.

Out of interest, what are you using?  I was using a system that did the same, but then I started using ZenHub, which doesn't apply those same labels, which makes things a lot cleaner.

I'm not actually sure of the name, I'll have to find out.
We have issues finding products to use because our corporate IT policy blocks access to so many of these things, we can't even access slack etc.
Sent from my iPhone
On 16 Dec 2015, at 12:50, Gary Ewan Park <notifications<EMAIL_ADDRESS>wrote:
@ckpearsonhttps://github.com/ckpearson said...
We have a project management system we're trialling for GitHub and it applies labels like "in-progress" etc based on position of an issue through a Kanban board.
Out of interest, what are you using? I was using a system that did the same, but then I started using ZenHub, which doesn't apply those same labels, which makes things a lot cleaner.
�
Reply to this email directly or view it on GitHubhttps://github.com/GitTools/GitReleaseManager/issues/65#issuecomment-165095861.
This email has been sent by and on behalf of one or more of KPMG LLP, KPMG Audit plc, KPMG Resource Centre Private Limited or a company under the control of KPMG LLP, including KPMG United Kingdom plc and KPMG UK Limited (together, "KPMG").
This email, and any attachments, is confidential and may be privileged or otherwise protected from disclosure. It is intended solely for the stated addressee(s) and access to it by any other person is unauthorised. If you are not the intended recipient, you must not disclose, copy, circulate or in any other way use or rely on the information contained herein. If you have received this email in error, please inform us immediately and delete all copies of it.
Any communications made with KPMG may be monitored and a record may be kept of any communication.
Any opinion or advice contained herein is subject to the terms and conditions set out in your KPMG LLP client engagement letter.
A list of members of KPMG LLP is open for inspection at KPMG's registered office.
KPMG LLP (registered no. OC301540) is a limited liability partnership registered in England and Wales. Each of KPMG Audit plc (registered no. 03110745), KPMG United Kingdom plc (registered no. 03513178) and KPMG UK Limited (registered no. 03580549) are companies registered in England and Wales. Each entity's registered office is at 15 Canada Square, London, E14 5GL.
For full details of our professional regulation please refer to https://www.kpmg.com/uk/en/about/aboutkpmg/pages/regulatory-information.aspx.

Are you using GitHub.com, or are you running GitHub Enterprise?  Assuming you can hit GitHub.com, then ZenHub might be a good choice for you, as it integrates itself into the GitHub.com experience.

Going to close ahead and close this issue as it hasn't been reported again, and the PR that was raised wasn't responded to.


Cast reconnection issue

Description
When regaining connection to the cast device, the current session does not seem to represent the state of the content on the Cast device. As such, the Cast Videos player state is out of sync with the device.
Reproduction steps

Open the Cast Videos app
Connect to a Cast device
Select a video -> observe that it starts playing on the receiver
Disconnect the client (phone/tablet) from WiFi -> observe video is still playing on the receiver
Connect the client back to WiFi -> observe MediaRouteButton shows as connecting -> wait for the connection to establish
Press the Pause button

Actual behavior

The video is paused on the receiver
A progress spinner is shown on the client in the app
The app shows "Loading..."
The progress/seek bar keeps incrementing
User cannot play the video again
The result of CastContext.getSessionManager().getCurrentCastSession().getRemoteMediaClient().isPlaying() returns true

Expected behavior

The video is paused on the receiver
The play button is shown
The progress/seek bar is stopped in the last position instead of continuously incrementing
The result of CastContext.getSessionManager().getCurrentCastSession().getRemoteMediaClient().isPlaying() returns false

I am pretty sure this is an issue with the Cast SDK v3 and not the Cast Videos app, but I am not sure where I would voice that concern. In either case, it affects the Cast Videos app, so I decided to write this issue. It affects my application as well, so I am hoping to get this resolved quickly.

You can file a bug against the SDK at: https://code.google.com/p/google-cast-sdk/issues/list

Did you ever get a solution to this issue because I'm having the same problem and need help?

@Rcureton I filed an issue on Sept 7 https://code.google.com/p/google-cast-sdk/issues/detail?id=929 On Dec 8 it was marked as fixed - I believe it should be in newer cast libraries.


feat: ParticleRenderer add isAutoplay and blendMode property

Please check if the PR fulfills these requirements

[X] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature: ParticleRenderer add isAutoplay and blendMode property.
Bug fix: texture uv Y flip bug.

What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Other information:

Mm

Please check if the PR fulfills these requirements

[X] The commit message follows our guidelines

[ ] Tests for the changes have been added (for bug fixes / features)

[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature: ParticleRenderer add isAutoplay and blendMode property.

Bug fix: texture uv Y flip bug.

What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Other information:

This PR trigger some bug of github. New PR here：https://github.com/oasis-engine/engine/pull/56


Remove explicit babel-runtime dependency from @iov/ledger-bns

Currently required due to https://github.com/LedgerHQ/ledgerjs/issues/211

Caller code is responsible for creating the transport now. Both @ledgerhq/hw-transport-node-hid and @ledgerhq/hw-transport-webusb need the regenerator-runtime dependency at runtime, which is only a small subset of babel-polyfill.

Close via https://github.com/iov-one/iov-ledger-bns/commit/7c580e583ab9b9091433f7b200158418afd41469.


Create UI design

UI design for the theme needs to be made

Hey @rajivharlalka can I come up with some designs??

Hey @rajivharlalka can I come up with some designs?

Sure you can go ahead

is there any specifiacations??
Also does it need to be responsice//

As such there isn't any specification . Sticking to the same color scheme would be appreciated . Designing of how different components ( eg : Post page can have a contents templated to show the heading in the particular md file) can look is what's needed most.


Following the Pyalgotrading tutorial gives an error

I was following the pyalgotrading tutorial. I copy pasted all the code into strategy_sma_regular_order.py file. When I run the command 'algobulls_connection.create_strategy(StrategySMARegularOrder)' , I get the following error: -
TypeError: Can't instantiate abstract class StrategySMARegularOrder with abstract methods name

Can you please provide more details, specifically -

The exact code you are trying to run
The exact output you are getting

Closing as no response for a long time. Please feel free to re-open this issue if you face any difficulties.


WebSocket can not use send in other threads (Server sides)?

like the title said,
I want to send a msg to websocket client ,and the working thread is not in drogon loop or handNewMessage, but from other work thread, I cached the websocket connection ptr; when I use send ,the client will be closed;
same as some simple codes:
std::future work= std::async(&{
auto client =container.find("123");
client->send("somemsg");
});

you could send messages in any thread.

Did you turn the ping off and waited a while until senging? In that case, the ping was to prevent this exact problem from happening.

thanks, this problem was I had sent some messy codes, and I don't know why the socket will close after receive some messy codes, but this is not a real problem.


Compiling OSX

Hello, it does not look like you have really done anything with this project in 2 years, so not really expecting a response or any help on this. However, I have recently started to work with python and saw this project. I am wondering if I could get a little bit of help with the compiling part, I now have a way to compile it all and an idea of what I need to compile but I am not exactly sure. What files of the client need to be compiled in the final .exe/.sh/.app, Do all of the files in SRC and Data need to be compiled for the game to run on the clients end? Sorry if I sound clueless, I just have very little experience actually compiling things. If you end up reading this want to say you've done an amazing job with this project and it has really helped me with my journey learning python so far. Thanks!

Glad to hear that you've found the project useful!
I haven't played around much with creating executables, but have you checked the tool that I included? I've added a bit of documentation to it here: https://github.com/marcusmoller/pyorpg-client/wiki/Building-executables

Glad to hear that you've found the project useful!
I haven't played around much with creating executables, but have you checked the tool that I included? I've added a bit of documentation to it here: https://github.com/marcusmoller/pyorpg-client/wiki/Building-executables

Ok, I'll check that out soon, however, I know there is a compiler specifically for python on OSX(py2app), however my problem was figuring out which files needed to be compiled and put into the app, because from the looks of it, the Linux compiler that you already have up, does not put every single file into the final product, but only some from the client folder. I could be wrong and the final .app need everything from the client folder, in which case that would be my problem. Either way I will try out the PyInstaller.

Ok, I'll check that out soon, however, I know there is a compiler specifically for python on OSX(py2app), however my problem was figuring out which files needed to be compiled and put into the app, because from the looks of it, the Linux compiler that you already have up, does not put every single file into the final product, but only some from the client folder. I could be wrong and the final .app need everything from the client folder, in which case that would be my problem. Either way I will try out the PyInstaller.


fix: [oadp-1.2] Remove unused code in OADP 1.2

Remove references to 1.3 CRDs in 1.2 branch.

@mateusoliveira43 , should this PR also contain these changes to the CSV generated by executing make bundle?

@rayfordj usually yes, but since those CRDs do not exist on this branch, make bundle does not change bundle folder with entries related to them
One way to assure us that, is the unit test jobs, that check if bundle is up to date

@rayfordj usually yes, but since those CRDs do not exist on this branch, make bundle does not change bundle folder with entries related to them
One way to assure us that, is the unit test jobs, that check if bundle is up to date

:sweat_smile:  Thanks for explanation.  I'm so used to seeing new things and it caught me off that didn't see it change too.
/lgtm
/approve


fix: change SeriesSearch to MissingEpisodeSearch for season requests

Description
This fix changes the behavior of how Overseerr requests series data from Sonarr. Previously, when adding new seasons to a partially available series, Overseerr would initiate a SeriesSearch, causing Sonarr to search for all monitored seasons of the series, including those already available. This behavior is now corrected by executing a MissingEpisodeSearch for the specific seriesId, which results in Sonarr only searching for the seasons that are not already available (including the newly requested seasons).
Screenshot (if UI-related)
To-Dos

[x] Successful build yarn build
-Translation keys yarn i18n:extract
-Database migration (if required)

Issues Fixed or Closed

Fixes: https://github.com/Fallenbagel/jellyseerr/issues/710

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

v2.0.0
GitHub release

Your semantic-release bot :package::rocket:


Balance overview missing

Is your feature request related to a problem?
Currently it is not possible to see how many AEX-9 tokens I own, I can only see how many AE I have in my Superhero Wallet thanks to the extension.
Describe the solution you would like to have.
There should be a way to see the balances. Either when you select the token you want to swap or another modal for balance overview.
Anything else you want us to know?
No response

In my humble opinion,
There might be hundreds or even thousands of tokens. Besides the fact of being too costly to query through all of them, it's a matter of separation of concerns: the scope of Superhero DEX is to provide a decentralized way of exchanging those tokens, not to duplicate the role of other Apps like Superhero Wallet is

Gree with Bogdan here. Its our of scope.


Features/generate list of last updated osc

I just modified the english version

Look good!  Please put the loops and list in an include file codeLastUpdated.html and include it in the English and French

Closes #49


Sprint 1 parimita

Files Changed-

projects/templates/projects/checkProject.html
projects/templates/reports/community_private_view
projects/views.py (def checkProject

merged


LFS: Create enum for all possible errors that can occur in flash_driver.c to group them in certain categories

Enum could go in flash_driver.h where all possible return errors such as FLASH_SPI_TRANSMIT_FAILED, FLASH_SPI_RECIEVE_FAILED, FLASH_TIMEOUT, FLASH_OK ... & more.
This would allow error handling to be more straight forward and meaningful when it comes to telecommands.

This is definitely a very standard/common way of propogating errors (instead of returning random non-zero numbers as we currently do).
However, I think the value-add for this project is rather low; the main reasoning is that the functions that call the flash drivers don't really care what failed, and don't do any conditional logic based on the failure type. That's the main benefit to using this style of return is to enable strict conditional logic for different failure modes.
What we currently do primarily (dare I say, instead) is have logging within each failure check (right before the non-zero return). This is far more valuable for debugging imo. Enabling remotely-accessible logging is another issue (#9, #30), which we'll absolutely do.
An alternative to error enums would be to define the error states in a general error definitions file. This is more like how LittleFS does it. Not sure what the best plan is.
#define ERROR_FLASH_WRITE_ENABLE_LATCH_TIMEOUT 1
#define ERROR_FLASH_READ_TIMEOUT 2

Anyway, low priority overall imo. We already have 95% of the value: non-zero returns, which are checked after every call and propogate upwards.

Based on the LFS_ASSERT trouble in #70, error values returned in the four flash functions (read, write, etc.) whose function pointers are stored in lfs_cfg must be less than or equal to 0.
It's a matter of style, though I do like the idea of an enum declared in flash_driver.h to cover any errors returned by those functions. Like,
enum FLASH_ERRORS {
    FLASH_ERR_OK = 0,
    FLASH_SPI_TRANSMIT_FAILED = -1,
    ...
};

I think that makes sense to do! No objections; should be straightforward to group/categorized the errors if someone wants to

I could get started with making sure that the returned error values are < 0 since that seems like an issue that could affect LittleFS greatly.
While doing this though, I think I can also just work on the categorization as it wouldn't take much longer to add this on

Go for it! Thanks


Trying to add repository annotation to fix deployment issues

Trying to add repository annotation to fix deployment issues
Type of change

[ ] Bug fix
[ ] New feature
[ ] Breaking change

Pull request checklist

[ ] I have added unit tests for new code that I have added
[ ] I have added/updated functional tests where appropriate
[ ] The code follows our coding standards

An exhaustive list of peer review checks can be read here

CI: Security warnings found!


[Typescript] Support Typescript Namespaces

How about supporting namespaces as well as modules?
https://www.typescriptlang.org/docs/handbook/namespaces.html

How should this be implemented? An additional setting where you can set a namespace and all generated classes are in this namespace?

I think it works exactly like module name, it's just a syntax thing:
namespace MyName.Space.Script
{
export class X
{}
}

vs
module MyName.Space.Script
{
export class X
{}
}

Maybe with a boolean flag to choose between namespace and module?
We use the namespace approach to allow us to compile all our typescript files together into a single JS file.

and what if both - the namespace and module - is set?

Sorry. I mean one setting for the name and a flag to choose between
module/namespace.
On 17 August 2016 at 17:17, Rico Suter<EMAIL_ADDRESS>wrote:

and what if both - the namespace and module - is set?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NSwag/NSwag/issues/238#issuecomment-240551465, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AANX6VxeRyhlWfLx73Yd9J40hQl8-cGsks5qg3pigaJpZM4JmB_-
.

Isn't it allowed to have a namespace in a module?

No. Typescript namespaces are what used to be called "internal modules". https://www.typescriptlang.org/docs/handbook/namespaces.html

Ah ok, then this should be a easy thing to do..

Thanks! I will have a look soon.


Extend minikube start command to accept windows os version flag

Extend the minikube start command to accept the --windows-node-version flag for windows node in multi-cluster os.
Windows Node Support in minikube Proposal

Update docs to highlight this change as well

Update docs to highlight this change as well

Not sure if you're aware, but you can update the docs automatically via make generate-docs

Update docs to highlight this change as well

Not sure if you're aware, but you can update the docs automatically via make generate-docs

Thanks for pointing this out! I was not aware of this!


Extend support for streaming datasets that use os.walk

This PR extends the support in streaming mode for datasets that use os.walk, by patching that function.
This PR adds support for streaming mode to datasets:

autshumato
code_x_glue_cd_code_to_text
code_x_glue_tc_nl_code_search_adv
nchlt

CC: @severo

Nice. I'll update the dataset viewer once merged, and test on these four datasets


fix: url containing dots were not correctly normalized with .html extension

Summary
This PR fixes an issue where URLs containing dots were not correctly appended with the .html extension.
/guide/version-0.1
expect:
/guide/version-0.1.html
actual:
/guide/version-0.1

Related Issue

https://github.com/web-infra-dev/rspress/issues/933
Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

if there exits a url like /foo/bar.png, it will be added a .html in current logic? I'm not sure if there is such a scenario, may be we need to know what is the original extension judgment logic for?

if there exists a url like /foo/bar.png, it will be added a .html in current logic? I'm not sure if there is such a scenario, may be we need to know what is the original extension judgment logic for?
@sanyuan0704 any context about this logic?

you are right. We should check all the usages of this function. Or add a flag to control this action.

I have reviewed all the places where the function normalizeHref is used. It appears to be used only for organizing href parameters or handling article links, and there is no case where it handles such as .png suffixes. I will reopen this PR for now, but further confirmation is needed from @sanyuan0704 .


Build fails with sed error in MacOS

Describe the bug
Build fails with sed error in MacOS
Example
============================
==== Fri Apr 29 06:35:03 PDT 2022
============================
Dispatcher image ---> docker.io/aslom/knative-kafka-broker-dispatcher:1728ce5c5b71ef0272b48fc61a5ab0363b72ad6f4049c0d3ed4be118b4502385
Receiver image   ---> docker.io/aslom/knative-kafka-broker-receiver:6b977181a9e1a32b00c8780bebf194d62d4dcd870edce52025ce1bd55a914a87
sed: 1: "eventing-kafka-source.yaml": invalid command code e
ERROR: Failed to set up data plane components
***************************************
***         E2E TEST FAILED         ***
***    Start of information dump    ***
***************************************

Expected behavior
Build works
To Reproduce
On MacOS
 ./hack/run.sh deploy

Knative release version
1.4
Additional context
Add any other context about the problem here such as proposed priority

As suggested @aavarghese the workaround is to deal with differences in sed
https://stackoverflow.com/questions/19456518/error-when-using-sed-with-find-command-on-os-x-invalid-command-code
by changing hack/data-plane.sh
function replace_images() {
  local file=$1
  if [[ $OSTYPE == 'darwin'* ]]; then
    sed -i '' "s|\${KNATIVE_KAFKA_DISPATCHER_IMAGE}|${KNATIVE_KAFKA_DISPATCHER_IMAGE}|g" "${file}" &&
      sed -i '' "s|\${KNATIVE_KAFKA_RECEIVER_IMAGE}|${KNATIVE_KAFKA_RECEIVER_IMAGE}|g" "${file}"
  else
    sed -i "s|\${KNATIVE_KAFKA_DISPATCHER_IMAGE}|${KNATIVE_KAFKA_DISPATCHER_IMAGE}|g" "${file}" &&
      sed -i "s|\${KNATIVE_KAFKA_RECEIVER_IMAGE}|${KNATIVE_KAFKA_RECEIVER_IMAGE}|g" "${file}"
  fi
  return $?
}

yeah, sed is fun on different operating systems

This is a better solution
https://github.com/knative-sandbox/eventing-kafka-broker/blob/47eb7f496f6fbc86599a5a0ce5f7b69196724e8a/test/e2e-common.sh#L29-L33
we should move that into a top-level imported script.

AFAICT gsed need to be installed with brew (or some other way) so we would need to add check that is available? sed is always available AFAIK
https://unix.stackexchange.com/questions/390040/gsed-command-not-found-on-macos-with-homebrew

@pierDipi proposed PR to fix it https://github.com/knative-sandbox/eventing-kafka-broker/pull/2174


Make dependency explicit for purescript-refs in Chapter 9

I'm currently updating everything in the second-edition branch and hope to merge this week. This should be fixed then.


npm run-script assets fails

JFYI, failed installing Demo project.
Step 6: Install the demo data
vagrant@ongr:/var/www$ npm run-script assets

><EMAIL_ADDRESS>assets /var/www
> gulp && app/console assetic:dump

module.js:340
    throw err;
    ^
Error: Cannot find module 'gulp-sass'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/var/www/Gulpfile.js:4:15)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)

npm ERR<EMAIL_ADDRESS>assets: `gulp && app/console assetic:dump`
npm ERR! Exit status 8
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>assets script.
npm ERR! This is most likely a problem with the ongr-sandbox package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp && app/console assetic:dump
npm ERR! You can get their info via:
npm ERR!     npm owner ls ongr-sandbox
npm ERR! There is likely additional logging output above.
npm ERR! System Linux 3.13.0-35-generic
npm ERR! command "/usr/bin/node" "/usr/bin/npm" "run-script" "assets"
npm ERR! cwd /var/www
npm ERR! node -v v0.10.40
npm ERR! npm -v 1.4.28
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /var/www/npm-debug.log
npm ERR! not ok code 0

/var/www/npm-debug.log
0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node', '/usr/bin/npm', 'run-script', 'assets' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose node symlink /usr/bin/node
5 verbose run-script [ 'preassets', 'assets', 'postassets' ]
6 info preassets<EMAIL_ADDRESS>7 info assets<EMAIL_ADDRESS>8 verbose unsafe-perm in lifecycle true
9 info<EMAIL_ADDRESS>Failed to exec assets script
10 error<EMAIL_ADDRESS>assets: `gulp && app/console assetic:dump`
10 error Exit status 8
11 error Failed at the<EMAIL_ADDRESS>assets script.
11 error This is most likely a problem with the ongr-sandbox package,
11 error not with npm itself.
11 error Tell the author that this fails on your system:
11 error     gulp && app/console assetic:dump
11 error You can get their info via:
11 error     npm owner ls ongr-sandbox
11 error There is likely additional logging output above.
12 error System Linux 3.13.0-35-generic
13 error command "/usr/bin/node" "/usr/bin/npm" "run-script" "assets"
14 error cwd /var/www
15 error node -v v0.10.40
16 error npm -v 1.4.28
17 error code ELIFECYCLE
18 verbose exit [ 1, true ]

Some people reporting that this is because of gulp-sass. Can you please rebuild that component with npm?
npm rebuild gulp-sass?

npm install worked

nice.
I'm gonna keep this issue as a holder for docs check when it will be fixed.

for the proggress check: #152


test(notifications): improve router tests

Hey, I just made a Pull Request!
improve the existing router tests for notifications to handle different endpoints.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@mareklibra still missing few endpoints and parameters but this greatly improves the coverage

@Rugvip rebased and fixed the comments!

Ach, there seems to be a conflict.


Constraints broken after upgrading to v0.17.0

The following doesn't seem to work anymore after upgrading from 0.16 to 0.17. Im adding an UIImageView to a UICollectionViewCell.
let image = UIImage(named: "image")
let imageView = UIImageView(image: image)
contentView.addSubview(imageView)

imageView.snp_makeConstraints { make in
    make.top.right.equalTo(contentView).inset(7)
    make.size.equalTo(CGSize(width: 15, height: 15))
}

Using Xcode 7.1, iOS 9.1, swift 2.1

@efremidze are you getting an compiler error, or runtime error? Or is it just not working at all? A bit more info would be very helpful.

0.17 did indeed break CGSize constraints completely. There are no errors and no debug prints, but setting
make.size.equalTo(someCGSize)

does not work whereas
make.width.equalTo(someCGSize.width)
make.height.equalTo(someCGSize.height)

does still work.

No errors, the constraints are missing.

Same issue here with 0.17.

Hey all, I've confirmed this now in 0.17, fix is to use 0.16 until I can get 0.18 out ( later tonight ).

I've pushed 0.18.0 to Cocoapods, it simply reverts all of 0.17.0 but that only removes some debugging info so it should work just as good as it did before you all upgraded to 0.17.0.
Going to leave this open because we will need to resolve it in develop.

I have the same issue
make.size.equalTo(CGSizeMake(LOGO_WIDTH, LOGO_WIDTH))
// not working

This should no longer be an issue. Develop has had these commits removed and is back to normal.


t2 update fails with javascript error

Here is log:
t2 update
INFO Looking for your Tessel...
INFO Connected to josser-tessel.
INFO New firmware version found...0.0.12
INFO Updating josser-tessel to latest version (0.0.12)...
INFO Beginning update download. This could take a couple minutes..
/Users/josser/.nvm/versions/node/v4.4.2/lib/node_modules/t2-cli/node_modules/progress/lib/node-progress.js:131
  complete = Array(completeLength + 1).join(this.chars.complete);
             ^

RangeError: Invalid array length
    at ProgressBar.render (/Users/josser/.nvm/versions/node/v4.4.2/lib/node_modules/t2-cli/node_modules/progress/lib/node-progress.js:131:14)
    at ProgressBar.tick (/Users/josser/.nvm/versions/node/v4.4.2/lib/node_modules/t2-cli/node_modules/progress/lib/node-progress.js:86:8)
    at IncomingMessage.<anonymous> (/Users/josser/.nvm/versions/node/v4.4.2/lib/node_modules/t2-cli/lib/update-fetch.js:126:13)
    at emitOne (events.js:82:20)
    at IncomingMessage.emit (events.js:169:7)
    at IncomingMessage.Readable.read (_stream_readable.js:368:10)
    at flow (_stream_readable.js:751:26)
    at resume_ (_stream_readable.js:731:3)
    at nextTickCallbackWith2Args (node.js:442:9)
    at process._tickCallback (node.js:356:17)

Tried both on 4 and 5 node.

looking into it now...

I think I've fixed it but testing now...

Okay @josser can you give it another try?

Ok, I've found the reason
it trying to download file from
https://builds.tessel.io/t2/firmware/f295bc69dc0aae06fdc14ee4027d2889c30fbbac.tar.gz
But file is missing or access is denied so cloud-front return this:
<?xml version="1.0" encoding="UTF-8"?>
<Error>AccessDenied<Message>Access Denied</Message><RequestId>62067A7AABF1DD9D</RequestId><HostId>i52nVticmXsq1BUUTnvqttFQ0F6LdGgDPrVpjooHovcVcxEH4ZOX8Bm9z3Ha/3y5t3v9uhN1KpI=</HostId></Error>%

and there is no content-length in response headers.
And so, it fails to calculate total length of progress bar because it calculated in that way:
 var len = parseInt(res.headers['content-length'], 10);

and len became NaN.
So two issues actually:

Bad error handling
Missing firmware file.

@josser it's working for me now, can you give it another try?

@johnnyman727 downloading! thank you :dancer:

:+1: Thanks for the help!

@johnnyman727 what was the issue?

I had the wrong filename in the tarball that I manually uploaded 😛
I should really get http://github.com/tessel/t2-release working.


r128gain: 1.0.3 -> 1.0.7

Description of changes
changes: https://github.com/desbma/r128gain/compare/1.0.3...1.0.7
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 239196

x86_64-linux

:white_check_mark: 2 packages built:

r128gain
r128gain.dist


freenet: URI for use with custom Freenet browser

Register a URI handler in the OS for "freenet:" that launches the custom Freenet browser.
Notes
Yes, it's possible to create custom URI schemes on Windows, MacOS, and Linux, and associate them with an application. This allows you to launch that application from a browser or another application using a URI that starts with your custom scheme.
Here's a general idea on how you can do this in each OS:

Windows: You need to add some keys to the Windows registry to create a new protocol. Then, in the command key, specify the command line that should be used to launch your application. You can refer to the Microsoft documentation on Registering an Application to a URI Scheme for more details.

MacOS: It requires you to add some keys to the Info.plist file of your application's bundle, specifically CFBundleURLTypes, CFBundleURLSchemes, and potentially CFBundleURLName. Check out Apple's documentation on Configuring Custom URL Schemes for Your App.

Linux: Linux doesn't have a central mechanism for this, but many desktop environments, like Gnome or KDE, support xdg-open, which delegates to the environment's default browser or file opener. You'll need to add a .desktop file for your app in /usr/share/applications or ~/.local/share/applications, and define a MimeType entry that includes x-scheme-handler/your-uri.

Remember, in all these cases, your application will need to be able to parse the URIs that it is given and take appropriate action. And there's no guarantee that every browser will respect these settings, although the major ones generally do.
Lastly, be aware that creating custom URL schemes can have security implications. Make sure to validate and sanitize all inputs to your application. You may not want to allow any arbitrary URL to be used to launch your app, as this could potentially be exploited by an attacker.

I think that a custom locutus browser would just add more hassle. I would recommend a simpler solution of using the users preferred browser with a custom browser extension, perhaps called locutus buddy, which would isolate locutus tabs from http tabs. It would also integrate jShelter on strict mode to lock down javascript so that it cannot be exploited. Firefox makes this very easy with container tabs, more work will be needed with chrome and its derivatives.


Static folder missing in 1.7.27 release of graphql-playground-react

This issue pertains to the following package(s):

[X] GraphQL Playground React

What OS and OS version are you experiencing the issue(s) on?
Linux
What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?
1.7.27
What is the expected behavior?
<EMAIL_ADDRESS>should contain a /static folder (like the versions before).
What is the actual behavior?
<EMAIL_ADDRESS>does not contain a /static folder
What steps may we take to reproduce the behavior?
<EMAIL_ADDRESS>

Any chance someone can look at this? I'd like to host a private Playground internally & set authentication data using #992, however without a /static folder in 1.7.27 I can't use the global headers feature!

As a stop-gap in the meantime, here's some instructions to build the static folder by-hand (assuming Git & Docker is installed & configured):
$ git clone git@github.com:graphql/graphql-playground
$ cd graphql-playground
$ docker run --rm -it -w /workspace -v $PWD:/workspace node:12 /bin/bash

And within the container:
# yarn
# cd packages/graphql-playground-react
# yarn build

Now ./packages/graphql-playground-react/build will exist & contain a /static folder. Upload that to a static hosting provider of your choice (e.g. S3) and reference in ./index.html appropriately.

It seems like somehow (I am very confused by the versioning of this project :/) a new release was made and this version contains a static folder again:
<EMAIL_ADDRESS>So I am closing this issue.


Feat/ Redis HA fix

Includes the Redis HA fix. This fixes 2 different bugs:
1- https://bugs.launchpad.net/juju/+bug/2063087
2- https://github.com/canonical/discourse-k8s-operator/issues/268
Overview
Started using app databag for Redis hostname. Add tests to test out Redis in HA mode.
Rationale
Previously was not able to use Redis in HA mode
Juju Events Changes

Module Changes

Library Changes

Checklist

[x] The charm style guide was applied
[x] The contributing guide was applied
[x] The changes are compliant with ISD054 - Manging Charm Complexity
[x] The documentation is generated using src-docs
[ ] The documentation for charmhub is updated.
[x] The PR is tagged with appropriate label (urgent, trivial, complex)

One question, what are now the restrictions to integrate with Redis? A specific version?
Should we fallback to the previous functionality if "leader-host" is not there? Otherwise, should we tell the user that this charm requires a Redis charm revision greater than X?

Ok, that is a great question. I did not think of that. I think I should ask @gregory-schiano about this.
I think the fallback to unit data if leader-host doesn't exist is a great idea. What do you think?


Param to name route component during ng g m

Every time I use this sort of syntax:
ng g m board --routing true --module app.module --route board
I find myself renaming the route component I got from schematics.
The part --route board automatically creates a route component that is named exactly as the route, in this case board.component.*. Meanwhile, my practice is to have route components named with page in name, so in this case it would be board-page.component.* It would have its own router outlet where I would display containers (smart components) - one of them would probably be board.component.*
Could be I am not the only one?
Couldn't cli allow a param to name the component as well, say --component pages/board-page
If not supplied, ng g m would behave as it does currently.

This is quite a custom use-case.
I did see some "page" patterns in the past, Typically this however resulted in changing the component suffix type and not actually changing the feature name. Ex: profile-desktop.page.ts.  This is also similar to containers, where they are typically suffixed with .container instead of .component. example, profile-desktop.container.ts.
I don't think that adding another option in the module to pass it down to the component schematic isn't something that we'd like to do, especially considering there isn't really much interest in this from the community since this feature was implemented. This also can be archived by extending the default schematic, which is really the way to go for these sort of custom style-guides.

This is quite a custom use-case.

I bet it is. There is no single right way to work.


formatSourceAndFixImports instead of just format

Fixes #11
Probably we want to add an option to control this to preserve backwards compatibility, this version is just to give an idea of how to fix it

Added an option to control this that defaults to previous behaviour

1.6.3 release and winging it's way to central.

I confirm I was able to download 1.6.3 from central today

Actually there is a little hiccup, see #13


Allow remaining DynamicTypeHandlers into missing-property caches

As @MikeHolman and @obastemur requested, allow the remaining DynamicTypeHandlers into missing-property caches.
I've got a OneCirro run pending; I'll wait for that to finish before I land this.
I'm pretty sure that I've covered all of the subclasses of DynamicTypeHandler, but it's possible that I missed one.  The assert on line 1821 of JavascriptOperators.cpp guards against this, although it's fairly ad hoc.
Questions for reviewers:

Should I allow NullTypeHandlerBase and NullTypeHandler in JavascriptOperators.cpp?  They don't come up in the unit tests, but it should be safe, because adding a property to either of these types causes us to create a new type, so cache invalidation isn't a problem.
Because the assertion is fairly ad hoc, I'm not sure how much value it adds.  Keep it?

Internal testing indicates that I introduced an AV with these changes.  Unfortunately, I don't have time to investigate this further right now, so I'm going to withdraw the PR.  I'll try to get back to this after RS4 feature freeze.


is the getPurchaseHistory() method enough to validate user who has purchased product ?

I am not sure since I'm not currently using it. This could be invested further if there is some use case that may cause an issue.


Null Pointer on Participant.getSummoner

Been working at the Riot API challenge and found null pointer bug. Below is an example (in Scala though, but it translates fine):
val m: Match = //somehow retrieve a match
val participant: Participant = m.getParticipants()(0)
participant.getSummoner // This throws Null pointer

Here is the stack trace:
[error] (run-main-3) java.lang.NullPointerException
java.lang.NullPointerException
	at com.robrua.orianna.type.core.match.Participant.getSummoner(Participant.java:164)
	at RitoAkka$.featurizeParticipant(RitoAkka.scala:84)
	at RitoAkka$$anonfun$5.apply(RitoAkka.scala:49)
	at RitoAkka$$anonfun$5.apply(RitoAkka.scala:49)
	at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:245)
	at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:245)
	at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
	at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48)
	at scala.collection.TraversableLike$class.map(TraversableLike.scala:245)
	at scala.collection.AbstractTraversable.map(Traversable.scala:104)
	at RitoAkka$.extractMatchFeatures(RitoAkka.scala:49)
	at RitoAkka$$anonfun$18.apply(RitoAkka.scala:188)
	at RitoAkka$$anonfun$18.apply(RitoAkka.scala:188)
	at scala.collection.immutable.List.map(List.scala:273)
	at RitoAkka$.main(RitoAkka.scala:188)
	at RitoAkka.main(RitoAkka.scala)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:483)

I am using the most recent snapshot (might give a try to build/compiling master if that would help), but based on that error message, I looked https://github.com/robrua/Orianna/blob/master/src/com/robrua/orianna/type/core/match/Participant.java#L164
The debugger says that getPlayer returns a null value. At this point, I have only briefly looked at the orianna source code so I don't have a good idea what is wrong, but will probably looking at it more later today. Any ideas in the meanwhile?

Hey,
Thanks for the report.
Currently the fact that Riot didn't send identity data for the players in the JSON payload isn't handled correctly here. All that really needs to be added is a check for whether the data is null. I can't fix this right now, but will update it later today.
FYI, the most recent snapshot (if you got it from robrua.com/orianna) is built automatically on repo update, so building from master won't change anything.

Fixed in newest release/build


Split Omnisharp into 2 libraries

Omnisharp.Http is the http server and omnisharp http protocol
Omnisharp is the class library that can be used as an normal
C# API

/cc @nosami

bah, I'm not sure this makes much sense anymore but take a look


[⚡for esl-utils]: cover with unit tests scroll utils (scroll lock module in part.)

As an ESL maintainer, I want to have scroll utils of esl-utils module to be covered by unit tests
Note: the visual, device, and integration tests are out of scope. It is required only parts coverable and reasonable for unit tests

:tada: This issue has been resolved in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Delete and Expunge Feature

I would like to implement delete(uids) as a convenience function to addFlags(uids, '\\Deleted')
Moreover I would expose the expunge() function.
Any tips what to look out for? Can I start?
I am using this in my new application (https://github.com/synox/void-mail). So far i just use connection.imap to access the underlying implementation, but this is not clean. 👍

Hey @synox, thanks for reaching out.
I would expect a method named "delete" to actually delete the messages with the specified uids, without having to call a second expunge() method. Don't you think?
If you are wanting to expose a delete() method, wouldn't it be better to do both addFlags and expunge in the same call?

You are right, i'll do that. :)

Hey guys, thanks for this lib, it really help me. There is any way of use this on fetchOptions? Like:
const fetchOptions = {
            bodies: ['HEADER', 'TEXT'],
            markSeen: true,
            markDeleted: true,
        };

I think we could merge this?


Missing results from rg

If a source code line contains a unicode chars in comment, rg will return something like this:
{"type":"begin","data":{"path":{"text":".\\APP\\app_code\\SC.h"}}}
{"type":"match","data":{"path":{"text":".\\APP\\app_code\\SC.h"},"lines":{                                             "bytes":"xxxxxx"},"line_number":24,"absolute_offset":486,"submatches":[{"match                                             ":{"text":"xxxxxx"},"start":9,"end":23}]}}
{"type":"match","data":{"path":{"text":".\\APP\\app_code\\SC.h"},"lines":{                                             "bytes":"xxxxx"},"line_number":45,"absolute_offset":1751,"submatches":[{"                                             match":{"text":"xxx"},"start":9,"end":23}]}}

and clap will ignore this item.

LeaderF use a different data format for rg, it can show the item as usual.
cmd.exe /c (rg   --no-config --no-ignore-messages --no-heading --with-filename --color never --line-number -S --context-separator=... -e GAP_S)
app_code\SC.h:24:#define GAP_S                  5      // 5s����ȡOCV 2
app_code\SC.h:45:#define GAP_S               10      // 5s����ȡOCV 2

Can you provide the source file and detailed steps to help reproduce it?

1,create a file test.txt with this content:
test_ddd
test_ddd    //こんにちは、世界
test_ddd    //hello

save the file with EUC-JP encoding.
2,cd to the diretory of test.txt
3,move curson to "test_add"
4,Clap! grep ++query= +no-cache
You will get only two results.

Can not reproduce, works for me with set fileencoding=euc-jp.

@liuchengxu Did you save the file after change the file encoding?
I'm using :set fenc=EUC-JP
Reproduce with minimal vimrc:

Ok, reproduced after setting the file encoding and saving the file :w. It's an issue of the Rust binary that only takes cares utf-8 now https://github.com/liuchengxu/vim-clap/blob/81f3444650cb0a07be75cdbbc2efc63447fe9b90/crates/maple_cli/src/tools/rg.rs#L75-L78.
For now, you can directly use the ripgrep CLI by disabling the Rust binary:
diff --git a/autoload/clap/provider/grep.vim b/autoload/clap/provider/grep.vim
index 07e4934..98f9096 100644
--- a/autoload/clap/provider/grep.vim
+++ b/autoload/clap/provider/grep.vim
@@ -136,7 +136,8 @@ function! s:spawn(query) abort

   call clap#rooter#try_set_cwd()

-  if clap#maple#is_available()
+  if 0
     let [grep_opts, query] = s:translate_query_and_opts(a:query)
     " Add ' .' for windows in maple
     call clap#maple#command#start_grep_sync(s:grep_executable.' '.grep_opts, query, s:grep_enable_icon, s:ripgrep_glob)

@zoumi Try #675, should fix this issue.

@liuchengxu I had tested the "multibyte" branch. I can get all results now. Thank you!


ungoogled-chromium: 87.0.4280.141 -> 88.0.4324.104

Unfortunately this requires a crazy hack to support building with
Google's proprietary Widevine DRM technology as that requires fetching
the Google Chrome sources (see also 86ff1e45cec).
The hack is required because ungoogled-chromium doesn't always use tags
that correspond to a Google Chrome release.

Motivation for this change
@squalus I noticed that the latest ungoogled-chromium broke my update script. This PR should work (not tested though) but the implementation sucks... :o Maybe you have a better idea what to do here (feel free to replace my PR)?
Some other approaches I could think of:

Stop supporting DRM for ungoogled-chromium

There are known users of that combination but since Widevine is a proprietary DRM technology from Google it might be for the best to not even allow it. But then again I can understand why people need Widevine... But maybe they could use Chromium for that.
Also: The obligatory fuck DRM (why do we have such stupid shit...):
https://social.primeos.dev/notice/A1r2eAhOl893jAnbNY

Check if it's possible to fetch an official build of Google Chrome 88.0.4324.104
Ignore the first ungoogled-chromium release for a new major version (the rest of the releases seem to match Google Chrome / Chromium stable channel releases)

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Didn't test the DRM part, but nix-build nixos/tests/chromium.nix -A ungoogled succeeds.

Didn't test the DRM part, but nix-build nixos/tests/chromium.nix -A ungoogled succeeds.

I also tried building ungoogled-chromium.override { enableWideVine = true; } and it succeeds. It isn't pretty but let's give it a try for the lack of a better alternative.
@squalus btw I'm considering to handle ungoogled-chromium updates as well to get the security fixes ASAP but I could only test if the NixOS VM test (nix-build nixos/tests/chromium.nix -A ungoogled) succeeds. And I'd backport ungoogled-chromium security updates without additional testing because we're already testing Chromium on the unstable and stable channels as well as ungoogled-chromium on the unstable channel so the risks should be very low. You'd of course still remain the primary maintainer as I could only handle automatic updates that don't break the build. Does that sound good to you or would you rather handle all updates?


Removes references to the App Release Team, updates release notes

I'm going to remove the old Slack user group now, as well.

LGTM, thanks Ash!


Feature/universal

Added Server Side Rendering to your starter kit using hapi.
you can run it by: npm start production

Hey, I really appreciate all of the work you did for this, but unfortunately one of the main goals of this starter kit is to avoid complexity such as this. A couple of months back this project did actually ship with support for rudimentary isomorphic rendering, but that caused fairly significant feature and scope creep. Ultimately, it was decided that we keep our focus more narrow and allow people to extend the repo as it suits them.
That said, it would be awesome to get some documentation in place to explain how one might go about implementing isomorphic rendering, but I don't think we'll ever go back to shipping it out of the box. Thanks again for your work, it's appreciated.

I guess in theory one could keep a branch that has universal rendering, either as an example or even fully fledged. Although I can see why you might not want to maintain that branch personally.
On 14 Dec 2015, at 00:05, David Zukowski<EMAIL_ADDRESS>wrote:

Hey, I really appreciate all of the work you did for this, but unfortunately one of the main goals of this starter kit is to avoid complexity such as this. A couple of months back this project did actually ship with support for rudimentary isomorphic rendering, but that caused fairly significant feature and scope creep. Ultimately, it was decided that we keep our focus more narrow and allow people to extend the repo as it suits them.
That said, it would be awesome to get some documentation in place to explain how one might go about implementing isomorphic rendering, but I don't think we'll ever go back to shipping it out of the box. Thanks again for your work, it's appreciated.
—
Reply to this email directly or view it on GitHub.

+1 Getting some documentation in place to explain how one might go about implementing universal rendering :)

@mtsr I've tried that before but it just gets so incredibly difficult to maintain.

I know. But maybe someone else who wants universal rendering for this starter kit is willing to maintain it?
On 15 Dec 2015, at 20:54, David Zukowski<EMAIL_ADDRESS>wrote:

@mtsr I've tried that before but it just gets so incredibly difficult to maintain.
—
Reply to this email directly or view it on GitHub.


Store package config in DB and use it in result events

TODO:

[x] test after Packit PR gets merged

Related to
Merge after packit/packit#2278
Fixes #1940
RELEASE NOTES BEGIN
N/A
RELEASE NOTES END

I have made few changes, PTAL :pray:


Add arrow navigation to sidebars

The user should be able to navigate the sidebars with arrow up/down and press enter to select the item. I think this can be solved by focusing a hidden  which capture the keydown events and trigger events.
What I tried last time was to do $element.focus() to use the native browser support, but that was pretty hard to do consistently (I gave up), since it then removed the focus from the actual element that the user had pressed tab to. Meaning: If you do "..." to move across the elements in the navbar it will be quite confusing if you suddenly focus an element in the sidebar list.
I've added this to the "reactjs" milestone since I believe it will be easier to do with reactjs - or rather a waste of time fixing it now and then re-doing it in reactjs.

Don't care much about this anymore.


[6.8] [meta] add tests for k8s 1.20 (#1294)

Backports the following commits to 6.8:

[meta] add tests for k8s 1.20 (#1294)

jenkins test this please


Close the source tab when dragging to another window

VSCode Version: Code - Insiders 1.4.0-insider (531a56f772fc33ec88910328b88f4dbd7ae5df43, 2016-07-28T16:52:53.252Z)
OS Version: Linux x64 4.4.0-31-generic, Ubuntu 16.04

Steps to Reproduce:

Open two vscode windows
Open a file tab
Drag the tab to the other window, notice the original file is still open after the drag and drop action

VSCode Version: 1.4.0-insider commit 4656fe3 2016-07-29T05:08:49:671Z
OS Version: Windows 10

-- Sorry for the English, I used Google Translator --
1- Allow files "not saved" - "Untitled-1". They are moved to new windows, not only files and have already been saved.
2- So there is no conflict between the files, remove the number from "Untitled", or automatically rename to new sequence numbers when we moved to a new window that has the "Untitled -'x '."
3- By dragging the tab out of the tab bar to open in a new window. This is not possible.

This may require quite a bit of work to find out that the drop happened outside of the window, I am not sure this can be easily detected but I can give it a quick try.

I could not find a solution to detect that you drop outside of the window other than maybe looking at the X/Y coordinates and then checking if they are within the window, which is super ugly. Given that, I think I would rather not want to add this until there is real support for better cross-window DND.
Also: this does not help with the case where the drop operation was not successful on the target. I think the real solution would be to somehow include the originating window in the dragged URI and in the target window send a IPC message over to the source if the drop was OK and only then close the editor.


Get Storybook to read MDX files

Description
What does this PR do?
How to test
What are the steps to reproduce the issue or verify the changes?
How do I run relevant unit tests?

Closing in favor of #7745


not enough values to unpack in tortuosity_measures.evaluate_window

Hi,
first of all, I really appreciate your work.
In the M3_feature_zone/retipy/create_datasets.py, you expect the function - tortuosity_measures.evaluate_window will return 15 values, but it only produces 13 values. Is it supposed to be like that? What am I missing?
Thanks,
Shvat

Sorry for the late reply and thanks for your interest in this work.
There are certain scripts that haven't been used and updated in the whole pipeline, e.g., the create_datasets.py you referred to. You can check the run.sh file to see which scripts are used in the calculation. BTW, we will clean the unnecessary files (heavily existing in M3 steps) later this year to make it concise.


Compatibility with Dedicated Server?

I'm currently using this mod with dedicated server, but it seems there is a problem for file pathing.
As for normal games, valheim_Data is normal path.
but for dedicated server - valheim_server_Data is normal path!
Can you branch this mod for dedicated server version?
P.S Attaching BepInEx Logs :
[Message:   BepInEx] BepInEx <IP_ADDRESS> - valheim_server (5/25/2022 4:06:41 AM)
[Info   :   BepInEx] Running under Unity vUnknown (post-2017)
[Info   :   BepInEx] CLR runtime version: 4.0.30319.42000
[Info   :   BepInEx] Supports SRE: True
[Info   :   BepInEx] System platform: Bits64, Linux
[Message:   BepInEx] Preloader started
[Info   :   BepInEx] Loaded 1 patcher method from [BepInEx.Preloader <IP_ADDRESS>]
[Info   :   BepInEx] 1 patcher plugin loaded
[Info   :   BepInEx] Patching [UnityEngine.CoreModule] with [BepInEx.Chainloader]
[Message:   BepInEx] Preloader finished
[Info   :   BepInEx] Detected Unity version: v2019.4.31f1
[Message:   BepInEx] Chainloader ready
[Message:   BepInEx] Chainloader started
[Info   :   BepInEx] 7 plugins to load
[Warning:   BepInEx] Skipping [ValheimVRM <IP_ADDRESS>] because of process filters (valheim.exe)
[Info   :   BepInEx] Loading [PlantEverything 1.11.3]
Currently I'm using multiple mods, but It seems it's not root cause of this problem.

this is a client mod because its skin based


[Fix]-[665/666] -  Add Keyboard Shortcut Guide and Custom Scrollbar

PR Fixes:

1 #665
2 #666

Resolves #665
Resolves #666

Implemented a pop-up window to display keyboard shortcuts for the video player.
Included navigation links to important sections of the application.

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I assure there is no similar/duplicate pull request regarding same issue

Please check @devsargam @hkirat , I think this is needful feature

Can u actually create a cmdk key board shortcut?

Yeah, I did that and also attached the screenshot for reference. I just added the working keyboard shortcuts, like during watching lectures some shortcut and some reference link also there just like https://excalidraw.com/

This code is outdated

Ok bhai, let me fix> This code is outdated


Missing security policy

Hi folks! Unfortunately, there is no security policy for this project. This makes it difficult to report security vulnerabilities in case any are discovered in the future.
Adding a simple security policy (basically a secure channel to disclose findings) is not difficult.

I don't know how to setup it, welcome to open a PR to do this. 🙂

Oh, right @sunli829. I'd be happy to help, but in this case, I can't do much :slightly_smiling_face:. What is needed is a file SECURITY.md that describes how a responsible disclosure should be carried out. For example, see Python's security policy.
The sole goal is to provide a way for an outsider of contacting the owners/maintainers responsible for the repository code in a discrete and secure manner. A security policy containing an e-mail address that is read only by trusted owners/maintainers can be enough for the start :)
Having such a policy helps keep the project healthy and should prevent people from using public issues for security issues or not disclosing them because there is no clear way how to do it.

I checked several popular crates to try to replicate one, but none of them had a SECURITY.md file. 😂

Quite unfortunately true, yes. But see e.g. apollo-server.

Alright, I have add it. 😁

Ok, I suppose that's the case closed. :)


NTR: domesticated farm animal

NB: we likely need a "domesticated farm animal" term in the animal_or_plant_population field pick list

We have domesticated animals in the list and so until we have a more specific use case/need we won't add this term.
Internal GRDI Meeting (2023-07-31)