Fix #390 add polyfill to js for example site and fix #397.

Coverage remained the same at 47.123% when pulling 22a8cda63c5eb0c127ce4e98c60dab0b2617200d on pierreneter:master into 6b195da6a242a7f74025ee96ca606314e9c09601 on ory:master.

Coverage remained the same at 47.123% when pulling 93f84b71be8fdfd174156c17404216b54bad4a10 on pierreneter:master into 6b195da6a242a7f74025ee96ca606314e9c09601 on ory:master.

To #409


Add launchType parameter to ECS

Fixes #3551
I also implemented the missing logic for launchType to create_task_set. And I changed the tests I touched to use the should syntax instead of asserts.

Coverage decreased (-0.3%) to 94.295% when pulling 822a173fec77bb70a5ea64e4f9d61e7ea0559840 on gruebel:add-ecs-launch-type into a31599d000688185698c22a6d11d7c23e942c177 on spulec:master.

Coverage decreased (-0.3%) to 94.295% when pulling 822a173fec77bb70a5ea64e4f9d61e7ea0559840 on gruebel:add-ecs-launch-type into a31599d000688185698c22a6d11d7c23e942c177 on spulec:master.


Bump controller-tools to v0.11.1

What type of PR is this?

/kind cleanup
What this PR does / why we need it:
Bumps controller-tools from v0.7.0 to v0.11.1
Does this PR introduce a user-facing change?:

NONE

/ok-to-test

Thanks @lucacome!
/lgtm
/approve


iconColor attribute not working on GoogleAuthButton in AuthButtonStyle.secondary

Hi,
I was tweaking the GoogleAuthButton and I found an incorrect behavior:
The following code works as expected
GoogleAuthButton(
          darkMode: true,
          onPressed: () async {
            // do something
          },
          style: AuthButtonStyle(
                      padding: EdgeInsets.fromLTRB(0, 0, 25, 0),
                      separator: 11,
                      buttonColor: Theme.of(context).cardColor,
                      iconColor: Colors.white,
                      iconBackground: Theme.of(context).cardColor,
                      buttonType: AuthButtonType.icon,
                      borderColor: Theme.of(context).colorScheme.secondary,
                      elevation: 0,
                      textStyle: TextStyle(color: Colors.white)),
        ),

Meanwhile if I select the AuthButtonStyle.secondary attribute instead, the iconColor specified is ignored
GoogleAuthButton(
          darkMode: true,
          onPressed: () async {
            // do something
          },
          style: AuthButtonStyle(
                      padding: EdgeInsets.fromLTRB(0, 0, 25, 0),
                      separator: 11,
                      buttonColor: Theme.of(context).cardColor,
                      iconColor: Colors.white,
                      iconBackground: Theme.of(context).cardColor,
                      buttonType: AuthButtonType.secondary,
                      borderColor: Theme.of(context).colorScheme.secondary,
                      elevation: 0,
                      textStyle: TextStyle(color: Colors.white)),
        ),

The other buttons work as expected

Shouldn't it be customizable?

I forgot to mention that I'm using the latest version: auth_buttons 2.0.4 with flutter 2.8.1

Hi @S0NN1,
Thanks for your issue.
Of course this should be customizable as much as possible, clearly this is a bug which I will fix it as much as possible.

Hi @S0NN1
I have fixed this,
NOTE: Only secondary icons cannot be changed of color.
Thanks agin for you help.


Fix editf bugs, add Phone length constraint and remove Email class

Remove Email and tests related to the class
Phone numbers must be between 3 to 15 digits long
bug documented in #190 is caused by using invalid prefix d/ , will not fix
editf command does not reset the personAllocatedList anymore
personAllocatedList will be reset when users try to edit capacity to be below the number of currently allocated people
UG updated to warn users of the above behavior

fixes #212  fixes #211 fixes #179 closes #190

Codecov Report

Merging #213 (3c724a5) into master (26c09bb) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #213      +/-   ##
============================================
+ Coverage     73.85%   73.97%   +0.11%
+ Complexity      851      850       -1
============================================
  Files           130      129       -1
  Lines          2498     2490       -8
  Branches        291      290       -1
============================================
- Hits           1845     1842       -3
+ Misses          559      556       -3
+ Partials         94       92       -2

Impacted Files
Coverage Δ

...seedu/address/logic/commands/AddMemberCommand.java
100.00% <ø> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
92.55% <ø> (-0.38%)
:arrow_down:

...c/main/java/seedu/address/model/person/Person.java
80.00% <ø> (ø)

...rc/main/java/seedu/address/model/person/Phone.java
80.00% <ø> (ø)

...du/address/logic/commands/EditFacilityCommand.java
93.33% <100.00%> (+0.35%)
:arrow_up:

...in/java/seedu/address/model/facility/Facility.java
88.67% <100.00%> (+2.96%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26c09bb...3c724a5. Read the comment docs.


ActionList.Item using wrong colors and get invisible in high-contrast theme

Description
We're using a <ActionList.Item variant="danger" ... /> and it renders wrong in high-contrast themes (both dark and light) but not on any other theme:

Also wrong on hover:

Interestingly, text color gets fixed on resize (e.g. just opening DevTools) while icon color stays always wrong.
https://github.com/github/github/blob/8d9083549de626e8b3fa9667a2de09840f39642f/app/assets/modules/custom-properties/components/DefinitionsTable.tsx#L74
Steps to reproduce
I'll go with the Monolith Storybook where it's easier:

npm run storybook in a github/github codespace
Once the page opens :6006, click Color scheme and use light_high_contrast
Click on "CustomPropertiesSchemaPage"
Click on the ellipsis button at the right to show the actions menu

Expected: label and icon readable
Actual: icon visible and label transparent, the opposite on mouse hover
Some repro videos on slack.
Version
v35.21.0
Browser
Chrome, Firefox

I've got a fix for this in Rails, but looking at the React code for ActionList I'm not sure how to achieve the same thing. We need to target the hover state.


[Important] The current website is about to enter maintenance mode to aid with v3 launch

TL;DR; At the end of Jan 2021, all tracks will enter v3 staging mode. Updates will no longer sync with the current live website, but instead sync with the staging website. The 05AB1E section of the v3 repo will be extracted and PR'd into this track (if appropriate). Further issues and information will follow over the coming weeks to prepare 05AB1E for the launch of v3.
Over the last 12 months, we've all been hard at work developing Exercism v3. Up until this point, all v3 tracks have been under development in a single repository - the v3 repository. As we get close to launch, it is time for us to explode that monorepo back into the normal track repos. Therefore, at the end of this month (January 2021), we will copy the v3 tracks contents from the v3 repository back to the corresponding track repositories.
As v3 tracks are structured differently than v2 tracks, the current (v2) website cannot work with v3 tracks. To prevent the v2 website from breaking, we'll disable syncing between track repositories and the website. This will effectively put v2 in maintenance mode, where any changes in the track repos won't show up on the website. This will then allow tracks to work on preparing for the Exercism v3 launch.
Where possible, we will script the changes needed to prepare tracks for v3. For any manual changes that need to be happening, we will create issues on the corresponding track repositories. We will be providing lots of extra information about this in the coming weeks.
We're really excited to enter the next phase of building Exercism v3, and to finally get it launched! 🙂

As of today, the website has entered maintenance mode.

As of today, the website has entered maintenance mode.

With Exercism v3 just being released, tracks are no longer in maintenance mode and are active again.
This means that changes made to this track will once again show on the website.
Thanks for being patient with us and enjoy Exercism v3!


wrapPythonProgram: use site.addsitedir instead of PYTHONPATH

Motivation for this change
Consider two applications, "a" and "b". "a" uses Python 2.7 and enum34, which exports enum module. It calls "b" via exec, which uses Python 3.5. In this Python there's its own enum module, but it's overridden by enum34 because it's in PYTHONPATH. As a result enum module doesn't work and there are weird errors.
Real life example: gajim calls qutebrowser to open an URL, which crashes instead.
I don't know any better solution to this problem than the proposed patch. It looks good to me but it can potentially break some workflows which somehow rely on PYTHONPATH postfixes.
Things done

[ ] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

cc @domenkozar

@abbradar I think the problem you describe is basically https://github.com/NixOS/nixpkgs/issues/11423.
https://github.com/NixOS/nixpkgs/issues/11423#issuecomment-238465989 works well for that.
@garbas, you proposed this solution as well, right?

@FRidh I think the problem is somewhat different. The problem that is described there IIUC is that when you put a derivation into propagatedBuildInputs, you get not only its binaries but also its Python modules in your PYTHONPATH. buildEnv works nicely to isolate that. This one is messier -- inside any Python executable PYTHONPATH is set to its dependencies closure, and when it tries to exec another Python executable, the other one prefixes its PYTHONPATH to the first one, and hilarity ensues.

Therefore I think we shouldn't set/prefix PYTHONPATH at all, and use buildEnv with  --set PYTHONHOME. It requires a lot of work though; a solution would have to be found for the checkPhase  and all the code outside python-packages.nix that sets PYTHONPATH would have to use python.buildEnv.
Anyway, until then I think I am fine with this change as I don't add anything to PYTHONPATH.

Oh, I got it now -- yes, it would help. BTW this patch can be a small preparation step -- if anything relies on prefixing PYTHONPATH it would not work with your idea easily, and others who set it can be probably converted into buildEnv much more straightforwardly. This patch would force us to fix the first cases, if any.

On second thought, while I don't set or append/prepend to PYTHONPATH myself, I think it is an important enough feature that we shouldn't break that possibility, and therefore shouldn't use --set PYTHONPATH.

i consider usage of -prefix a bug. some programs will break or behave differently just because somewhere in environment there is a PYTHONPATH defined. i'm strongly about merging this asap.

some programs will break or behave differently just because somewhere in environment there is a PYTHONPATH defined.

Agreed. And therefore we should solve the root of the problem: stop using PYTHONPATH in our wrappers to find Python modules.

we should never allow to extend PYTHONPATH this way

PYTHONPATH is a Python feature. People will want to be able to use it. Using --set completely takes away that possibility.

but provide a way (eg. via buildEnv) to create custom python environments.

We can add an option to buildEnv to modify PYTHONPATH, either on a per-application basis, or for the whole environment. We let buildEnv set or unset PYTHONPATH.

This LGTM and would fix some issues I've had. Agreed that a better solution would be nice.

for me this is a quick improvement over currently (for me) broken way how we handle python binaries. i got bitten by this bug many times and in all my projects i've been using --set instead of --prefix for exactly this reason.
this PR wont fix everything in python but it for sure will make python stuff more reproducible across machines.
i would like to merge this, but i would also like some comments on this subject from @domenkozar and @bennofs

100% agree with this patch. I didn't know it used --prefix before, that seems like madness to me! Python applications' PYTHONPATH should not depend on the environment they run in.

also another thing. is this triggering a mass-rebuild? i think we could easily apply this directly to master. yes quite few packages will need to be rebuilt but nothing than hydra can not handle. @domenkozar you thoughts on this?

I don't see a reason from top of my head where --prefix would be useful, so +1 from me.

I think this breaks
nix-shell -p pythonPackages.ipython pythonPackages.numpy --run "ipython -c 'import numpy'"

because ipython won't be able to find numpy. Testing now.
(Note that I anyway think we should replace this kind of usage with buildEnv)

invoking pytest already fails in checkPhase

Hm, I'll try to test this more extensively and see what happens (I haven't built anything big with this because of lack of CPU time. I don't even remember what exactly, I think maybe pip).

ipython is certainly one case where you wouldn't want an executable to set their own (complete) pythonpath. But it's in the minority for sure... maybe an opt-in pythonpath prefix would be better? It would be simple to make it an option in buildPythonPackage.

Hm, indeed, IPython is a special case. I'm now trying an alternative patch which removes all meddling with $PYTHONPATH at all and instead inserts needed paths to sys.path. This gives us absence of dreaded $PYTHONPATH propagation while not disabling it completely. A downside is further complication of The Magical sed Expression. IPython seems to work with this.

We could also skip using PYTHONPATH and use PYTHONHOME instead. PYTHONHOME would point to what PYTHONPATH currently points to, and then PYTHONPATH could be set at runtime to whatever.
                 local -a wrap_args=("$f"
                                 --set PYTHONHOME':' "$program_PYTHONPATH"
                                 --prefix PATH ':' "$program_PATH:$dir/bin")

I haven't tested this out yet but it seems perhaps promising?

@adnelson and now you've broken buildEnv, because it cannot use --set PYTHONHOME anymore

I thought that PYTHONHOME should be one path which point to Python "home", that is binaries and libraries. @FRidh proposed to build environments with all dependencies and set PYTHONHOME to them but without such an environment I don't think it can be used...

@FRidh I haven't broken anything yet :wink: I didn't realize that's what buildEnv did, good call

BTW to clarify my thoughts towards @FRidh proposition: I like it much more than the current situation, and I think we probably should go there in the long run. However, I experience a broken browser when called from my IM client right now and I suspect that there are more breakages like this in the wild. buildEnv proposition requires a lot of work (grep for PYTHONPATH to get a rough estimate) and we need something to plug the leak now...

I actually think that using PYTHONHOME is not such a bad idea: you could establish the convention that PYTHONHOME is to be used for the "application-dependencies", i.e. things that for example ipython itself depends on. The PYTHONPATH would be used to add any additional dependencies then, like plugins etc.

So couldn't we point PYTHONHOME to a call to buildEnv on the propagatedBuildInputs?
Something (conceptually, cuz I have no idea) along the lines of
mkDerivation {
  postInstall = ''
    for bin_file in $out/bin; do
      makeWrapper $bin_file \
        --set PYTHONHOME ${buildEnv {paths = propagatedBuildInputs;}}
  '';
}

@adnelson and what is that derivation? It cannot be the actual package, it has to be outside of that or it wouldn't be a DAG. Here we're back to my suggestion of https://github.com/NixOS/nixpkgs/pull/16672. It's really easy actually, as you see in the implementation. And we could choose for now to keep wrapPythonPrograms.
@bennofs Do you mean adding to PYTHONPATH with Nix, or outside of Nix?

@FRidh you could do both, doesn't matter.

@bennofs Let's see how that works with @abbradar 's example. Each package would have a PYTHONHOME that points to itself, right. Dependencies would have to be symlinked then in buildPythonPackage.
Now the user wants to add something to PYTHONPATH of application a, say a plugin which depends on enum. b also needs enum but is a different Python version. What will happen?

I've replaced this patch to use sys.path via the sed expression now. This fixes IPython and PYTHONPATH usage in general.

@FRidh that would be part of buildPythonPackage. Since I'm not familiar with buildEnv, here's an idea using symlinks in the derivation's site-packages folder. There are multiple similar ways to do this but the idea is that there is some folder which contains a package's entire python closure, and we set PYTHONHOME to that.
postInstall = ''
  # Symlink everything available from the python path to this folder
  for python_path in $(echo $program_PYTHONPATH | tr : '\n'); do
    for item in $python_path/*; do
      ln -s $item $out/${python.sitePackages}/$(basename $item)
    done
  done

  # Wrap generated binaries
  for bin_file in $out/bin; do
    makeWrapper $bin_file \
      --set PYTHONHOME $out/${python.sitePackages} \
      --prefix PATH : $PATH
  done
'';

@abbradar doesn't the change you made just reproduce the original behavior? Because the program will still inherit an external pythonpath, no?

@adnelson Yes, my intent was not to disable PYTHONPATH completely. The problem was that nested programs inherit PYTHONPATHs because environment is inherited via exec. sys.path, on the other hand, is local to the current running Python program, so each one would get only its individual paths.

@abbradar ah that makes sense. So this is at least an improvement :wink:

@adnelson I actually don't think that we want to disable PYTHONPATH completely -- it's like LD_LIBRARY_PATH and friends and one sets it at his own risk. As we've discovered, IPython for example uses it internally. As long as it's not built up from nested applications like before I think it's fine.

@abbradar gotcha :+1:

@abbradar (so far) I haven't found any issues with the new proposal :+1:

Ironically this doesn't solve my own problem with gajim because it has custom code setting PYTHONPATH. I think of refactoring wrap.sh so that it can be called for individual Python files -- this would allow people to use this patcher in more ways, hopefully avoiding setting anything my themselves. To avoid two mass-rebuilds I'll try to do it this evening so that it can (hopefully) be merged simultaneously.

Pheew. Gajim was not so easy I hoped. This patchset finally fixes it and also fixes https://github.com/NixOS/nixpkgs/issues/16133:

We now use site.addsitedir instead of sys.path -- with this, .pth files are correctly resolved;
I have fixed Sed expression to properly handle Gajim and also scfbuild;
wrapPythonProgram has been split and used for Gajim instead of custom PYTHONPATH prefixing.

There was interest expressed in this patch and we now don't break PYTHONPATH so I want to merge it. Before it, however, it would be nice to get a review of magicalSedExpression changes. Not the expression itself but rather the new inserted preamble -- in particular, is import functools acceptable?

@abbradar I can't think of any issues with the updated proposal. I've tested some Python environments and there I didn't encounter any issues (and I wouldn't expect that either).
Can you squash some of the commits? And update in the Python docs under buildPythonPackage the part about wrapPythonPrograms. Putting in the wrapPython Nix expression a couple of lines what the preamble is for would be nice as well.

Updated and added documentation. Regarding squashing: I'm not sure what to squash. Usually I make a commit per finished change in existing code -- those all seem more or less independent.

that looks awesome, can this fix tox ?
#16591
#15224

Sadly I don't think so (this doesn't affect nix-shell). However, in case of tox I think we can wrap it to unset PYTHONPATH. Because now it has all the dependencies patched in it should work -- I'm not sure this won't break any usecases though.

atm tox is broken because it puts packages from its environment into the virtualenvs at setup time and then isolates them away at the other level
tox would work fine if it was not wrapped by the pythonpath thing

This shouldn't be a problem already I think because there's no PYTHONPATH set for Tox itself now. I was rather talking about case when it's called from nix-shell which sets its own PYTHONPATH.

will this change hit 16-09 ?? - i just did a nix-env -i for tox and it has a wrapper

It should have, a long time ago.

i am on a 16.09 channel, just updated my channels and installed tox

same for unstable channel

 nixpkgs git:(master) ✗ nix-build -A pythonPackages.tox
ca/nix/store/bm5hyq5rhhrjrs85alai3gph1kq1yb53-python2.7-tox-2.3.1
 nixpkgs git:(master) ✗ cat result/bin/tox
#! /nix/store/nyj6xd7s1n1w8c0xdwk5ddhi7bjcyi9x-bash-4.3-p46/bin/bash -e
export PATH=/nix/store/hdny4a03ys50hh56k6z1w3z8sl0hf2ym-python-2.7.12/bin:/nix/store/bm5hyq5rhhrjrs85alai3gph1kq1yb53-python2.7-tox-2.3.1/bin:/nix/store/p5n1lbm3rs3d4bkpq249fg5rs2iw8kp2-python2.7-setuptools-26.1.1/bin:/nix/store/yk4qqqxq91gjd7jp2i114dywh1f2xfaw-python2.7-virtualenv-15.0.3/bin${PATH:+:}$PATH
exec -a "$0" /nix/store/bm5hyq5rhhrjrs85alai3gph1kq1yb53-python2.7-tox-2.3.1/bin/.tox-wrapped "${extraFlagsArray[@]}" "$@"
 nixpkgs git:(master) ✗

So it's in master at least, and given that the change was merged long before release-16.09 fork it should be there, too.

@domenkozar any chance to see this in 16.09?

@RonnyPfannschmidt As I've said it should be in 16.09 already but jsut to be sure I checked:
 nixpkgs git:(release-16.09) ✗ nix-build -A pythonPackages.tox
/nix/store/d1ri3241dnyl17hk2rqcbp3s5s740ng2-python2.7-tox-2.3.1
 nixpkgs git:(release-16.09) ✗ cat result/bin/tox
#! /nix/store/migghb7advw9a6hxi3vhyw2kyyxlyihx-bash-4.3-p46/bin/bash -e
export PATH=/nix/store/1940biik22bz5kc5fv1mnd2nzhc58k6m-python-2.7.12/bin:/nix/store/d1ri3241dnyl17hk2rqcbp3s5s740ng2-python2.7-tox-2.3.1/bin:/nix/store/agx8kbmp982gcbqcsxx3iy4s1n52z8pb-python2.7-setuptools-26.1.1/bin:/nix/store/x32przfwf4cl3wgybm2dpr5dvx588wp9-python2.7-virtualenv-15.0.3/bin${PATH:+:}$PATH
exec -a "$0" /nix/store/d1ri3241dnyl17hk2rqcbp3s5s740ng2-python2.7-tox-2.3.1/bin/.tox-wrapped "${extraFlagsArray[@]}" "$@"
 nixpkgs git:(release-16.09) ✗

@RonnyPfannschmidt does this fix the tox issue for you on master?
@FRidh any reason not to backport this to 16.09? It's quote late for such big python change..

@domenkozar Again, this is already in 16.09 -- see also for example https://github.com/NixOS/nixpkgs/commit/db31282f087f4100e7d7845f34ce888c42ac6fd3 (notice 16.09-beta tag).

nix-channel --update
downloading Nix expressions from ‘https://nixos.org/releases/nixos/16.09/nixos-16.09beta264.aadcffc//nixexprs.tar.xz’...
downloading ‘https://nixos.org/releases/nixos/16.09/nixos-16.09beta264.aadcffc//nixexprs.tar.xz’... [3776/8658 KiB, 3355.2 KiB/s]
downloading Nix expressions from ‘https://nixos.org/releases/nixpkgs/nixpkgs-17.03pre91280.b32252d//nixexprs.tar.xz’...
downloading ‘https://nixos.org/releases/nixpkgs/nixpkgs-17.03pre91280.b32252d//nixexprs.tar.xz’... [3520/7663 KiB, 3355.2 KiB/s]
unpacking channels...

is this perhaps an issue with the channel lagging behind the branch?

Hm, I think you have an old tox in your PATH somehow. Try running nix-build -A pythonPackages.tox '<nixpkgs>' and see what you have in result.

$ git branch
  gnome-online-account-wrapGAppsHook
  gnome-onlineaccoutns-use-wrapGAppsHook
* master
  nixos-unstable
  nixpkgs-unstable
  release-16.03
  wrapGAppsHook
$ nix-build . -A pythonPackages.tox
/nix/store/bm5hyq5rhhrjrs85alai3gph1kq1yb53-python2.7-tox-2.3.1
$ cat result/bin/tox
#! /nix/store/nyj6xd7s1n1w8c0xdwk5ddhi7bjcyi9x-bash-4.3-p46/bin/bash -e
export PATH=/nix/store/hdny4a03ys50hh56k6z1w3z8sl0hf2ym-python-2.7.12/bin:/nix/store/bm5hyq5rhhrjrs85alai3gph1kq1yb53-python2.7-tox-2.3.1/bin:/nix/store/p5n1lbm3rs3d4bkpq249fg5rs2iw8kp2-python2.7-setuptools-26.1.1/bin:/nix/store/yk4qqqxq91gjd7jp2i114dywh1f2xfaw-python2.7-virtualenv-15.0.3/bin${PATH:+:}$PATH
exec -a "$0" /nix/store/bm5hyq5rhhrjrs85alai3gph1kq1yb53-python2.7-tox-2.3.1/bin/.tox-wrapped "${extraFlagsArray[@]}" "$@"
$ git describe
16.09-beta-944-ga0b643e

This already does contain this change (notice absence of PYTHONPATH exports). Maybe the problem is with something else...

nm, i missed that detail
on the 16.09 branch i get the same output - i was confused by the different output path
the behaviour is indeed correct
now for tools like tox it would be nice if they either had no PATH at all or used it differently
but thats something that can change in future
as far as i can tell your change correctly and nicely fixes the 2 issues i posted

oh, wait ,not completely
tox is fixed, PYTHONPATH is still leaking into nix-shell

Can you perhaps submit a PR for this? The workaround should be quite simple -- you need to add --set PYTHONPATH "" to makeWrapperArgs for the tox derivation.

imho there should be a default decision on what nix python programs do wrt inheriting pythonpath
users tend to use it, so its certainly valid - a tool in nix that does filter nix store paths out of env vars in wrappers might be whats helpfull

PYTHONPATH in nix-shell is set with a setup hook, and has a different purpose. I hope with nix use setup hooks won't be run, and PYTHONPATH therefore won't be set.

@FRidh sounds perfect, i'd like to be free of nix-shell, from my POV its a tool for developing nix packages, not using them in develpment environments

Currently we add the following to scripts
preamble = ''
          import sys
          import site
          import functools
          sys.argv[0] = '"'$(readlink -f "$f")'"'
          functools.reduce(lambda k, p: site.addsitedir(p, k), ['"$([ -n "$program_PYTHONPATH" ] && (echo "'$program_PYTHONPATH'" | sed "s|:|','|g") || true)"'], site._init_pathinfo())
        '';

and we also create a wrapper. I don't think we should do both. In case of Python code, we should add this code, and in the case of a non-Python program, we should create a wrapper.
The wrappers can be problematic, e.g. when the program that is wrapped calls itself using python program args instead of ./program args.
I would like to make the following change:

in case of Python code, we patch the shebang and optionally add the preamble. Python applications will be able to find the modules they require if the preamble is added. They can find the interpreter because we patched the shebang, but they cannot find additional scripts provided by the application or dependencies because they're not on PATH. In the long run we might want to get rid of the preamble.
we do not create wrappers in Python package derivations, but, a bit like with KDE, we have a ${name}-${version}-wrapped. Here we use either the wrappers as we have now, or my buildEnv approach. Any manual wrapping would also be done here in the fixupPhase. We add wrapped and unwrapped attributes.

Important is that ${name}-${version}-wrapped doesn't set pythonPath so its site-packages isn't added by the setup-hook.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/terminal-emulator-leaks-environment-variables-to-shell/33673/11


Custom breadcrumbs or context is not sent to sentry.

The code:
Raven.config(
<EMAIL_ADDRESS>
     {
         captureUnhandledRejections: true,
     },
);

Raven.context( () => {
    Raven.captureBreadcrumb({
        message: 'Test breadcrumb',
        category: 'payment',
        data: {
            amount: 312,
        }
    });

    Raven.setContext({
        context: 'someContext'
    });
    throw Error(' in context error 2 ')
});

Sends the error to sentry, but I'm unable to see the additional context anywhere, and the breadcrumbs aren't available either.
I'm using hosted sentry, and with a raven-node version of "^2.2.1" in my package.json. I'm setting up raven-node as shown above.

Hey @GeeWee, there are few things going on here:

you have to call install on Raven object in order to use breadcrumbs (after calling .config)
setContext is as it's name says, setting a whole context – overriding it, and because breadcrumbs are also part of the error context, they are disappearing
use mergeContext if you want to add some additional values without overriding it
Sentry supports only specific context keys, user, tags and extras (which are any arbitrary values really) – please refer to https://docs.sentry.io/learn/context/

To summarize, here's a version of your code that will work:
Raven.config(
<EMAIL_ADDRESS>
     {
         captureUnhandledRejections: true,
     },
).install();

Raven.context( () => {
    Raven.captureBreadcrumb({
        message: 'Test breadcrumb',
        category: 'payment',
        data: {
            amount: 312,
        }
    });

    Raven.mergeContext({
        extras: {
            moreValues: 'someContext'
        }
    });

    throw Error(' in context error 2 ')
});

You're absolutely right. Thanks a bunch. (Although for anyone else reading, it's extra - not extras)
I think the behaviour of the following code is a little strange:
Raven.config(
<EMAIL_ADDRESS>		{
			captureUnhandledRejections: true,
		},
	)
//NOTE NO INSTALL call

Raven.context( () => {
	Raven.captureBreadcrumb({
		message: 'Test breadcrumb',
		category: 'payment',
		data: {
			amount: 312,
		}
	});

	Raven.mergeContext({
		extra: {
			moreValues: 'someContext'
		},
		user: {
			foo: 'bar',
		},
		tags: {tag1: 'tag2',}
	});

	throw Error(' raven error 3')
});

Note that there's only a config call, and no install call.
This flawlessly captures the context and the error, but no breadcrumbs. I think it's a little counterintuitive you can end up in a situation where half of raven works and the other half doesn't. A warning at least would be nice.

Anyways - feel free to close this issue if you'd rather track this in another issue, or this is working as intended.

i have sam error with node 8.6.0

@GeeWee addressed in https://github.com/getsentry/raven-node/pull/402
@israel-viveros what error do you have exactly? Not capturing breadcrumbs without installing raven is intended behaviour for now. If there's anything else that causes issues for you, please open a new ticket. Thanks!


Implement basic CI/CD

The CI should cover linting as well as unit tests at a minimum.

This is another Duplicate of Issue 40. Closing with a Link:
https://app.zenhub.com/workspaces/guardian-618c27c08661c0001461263a/issues/hashgraph/guardian/40

Note: Reopened the issue and changed its focus on implementation of the CI (budges are covered in the #40).
Requirements
CI/CD is a common 'best practice'  to organising software development. This ticket requires the implementation of Github Actions workflow to be triggered every time a commit to main has occurred.
DOD
The workflow described in the Acceptance Criteria section below is executed automatically triggered by the change in the main repo.
Acceptance Criteria
Github Actions workflow exists in the /.github/workflows/ci.yml containing the following logic which gets executed on every commit to MAIN:

Codebase is "linted", i.e. checked and formatted by the lint utility
Repo is tagged
Software artefacts are built and published (where appropriate)
Unit tests are executed and the results are recorded

@danielnorkin @sergmetelin This was just QA Tested and complete, moving to Close.


$this->config->set_item('config_var', 'value') deos not persistent to config file

Currently I found config->set_item function does not persistent new value to config file. This feature is really useful, could it be impletemented?

why should it be useful? i think, the set_item function is for temporary use only.


debug with a profiler in a commandline app i mean

debug with a profiler in a commandline app i mean
Originally posted by @HenryGeorgist in https://github.com/HydrologicEngineeringCenter/fda-model/issues/317#issuecomment-1182550564

        {
            //if (p <= 0) return Double.NegativeInfinity;
            //if (p >= 1) return Double.PositiveInfinity;
            //if (StandardDeviation == 0) return Mean;
            //return invCDFNewton(p, Mean, 1e-10,100);
            int i;
            double x;
            double q;
            double c0 = 2.515517;
            double c1 = .802853;
            double c2 = .010328;
            double d1 = 1.432788;
            double d2 = .189269;
            double d3 = .001308;
            q = p;
            if (q == .5) { return 0.0; }
            if (q <= 0) { q = .000000000000001; }
            if (q >= 1) { q = .999999999999999; }
            if (q < .5) { i = -1; }
            else
            {
                i = 1;
                q = 1 - q;
            }

            double t = Math.Sqrt(Math.Log(1 / (q * q)));
            x = t - ((c2*t+c1)*t + c0)/(((d3*t+d2)*t+d1)*t + 1)
            x = i * x;
            return x;
        }

normal inv cdf logic


Replace Arc::try_unwrap with Arc::unwrap_or_clone where cloning anyway

Extracted from https://github.com/apache/datafusion/pull/12166 + some more new places updated.
Relates to https://github.com/apache/datafusion/pull/12172

thank you @jonahgao for review!

Thanks @findepi  and @jonahgao  -- using the named function is clearly better in my opinion


Release 1.1.9

@rultor release it; tag is 1.1.9.

@rultor release it; tag is 1.1.9.

@rafamizes OK, I will release it now. Please check the progress here

@rultor release it; tag is 1.1.9.

@rafamizes Done! FYI, the full log is here (took me 2min)


Fix example 3

Closes https://github.com/MicrosoftDocs/office-docs-powershell/issues/6722
essentially, the current example removes the object from the ArrayList but to do that, converts it from ArrayList to PSObject and then, the Set-CsAutoattendant is expecting an ArrayList. Fixing this using the Remove() function that maintains the ArrayList.

Docs Build status updates of commit 9c26318:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsAutoAttendant.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 138571a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsAutoAttendant.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

You are welcome
I was able to achieve by using the remove() method instead
$autoAttendant.CallFlows.Remove(($autoAttendant.CallFlows |Where-Object {$_.Id -eq $HolidayCallHandlingAssociation.CallFlowId})) $autoAttendant.Schedules.Remove(($autoAttendant.Schedules |Where-Object {$_.Id -eq $HolidayCallHandlingAssociation.ScheduleId})) $autoAttendant.CallHandlingAssociations.Remove($HolidayCallHandlingAssociation)

@Kateyanne Please merge this PR. Thanks

Docs Build status updates of commit c2d342e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsAutoAttendant.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


"Encrypted credentials not found"

Gettin "Encrypted credentials not found" error when using melcloud-connect to get device list. Any ideas. Running in Home Assistant.

Working fine now. No idea what caused the problem before.


Introduce upgrade recovery image

This update introduces the upgrade recovery image, which is
responsible for writing the upgrade recovery script to the recovery
partition and taking the pre-upgrade backup.
Co-Authored-By: Daniel Mellado<EMAIL_ADDRESS>Co-Authored-By: Yolanda Robla<EMAIL_ADDRESS>Co-Authored-By: Don Penney<EMAIL_ADDRESS>Signed-off-by: Don Penney<EMAIL_ADDRESS>

/hold
This PR depends on merge of https://github.com/openshift-kni/cluster-group-upgrades-operator/pull/125

Note that the current test failures are due to the missing dependency being introduced by #125 ... Once that PR merges, these test should be able to pass.

/retest

/unhold

/retest


Complete Sample App not working

The complete sample app at https://github.com/OfficeDev/microsoft-teams-sample-complete-csharp much of the instructions on even running the app appears very outdated.
The README is using the wrong link to create a bot, because of the migration. Following the instructions, it says: Bot registration is here (open in a new browser tab): https://dev.botframework.com/bots, but using this will not allow us to create our own message endpoint and use ngrok, thereby rendering the instructions in the README virtually useless. Instead we are supposed to use https://dev.botframework.com/bots/new, but while we use this, it will have a warning that we should be migrating to the new bot service.
The manifest file cannot be parsed with the current Teams "upload custom app". The error I get while following the instructions is as follows.
Error: An error occurred while parsing the manifest.json file; Property 'scopes' has not been defined and the schema does not allow additional properties. Path 'composeExtensions[0].scopes', line 150, position 15.

I am yet to be sure as to why this is occurring, and am trying to debug this problem. I don't believe I did anything to change the manifest except for following the instructions and changing the values in <<___>>.
EDIT: Remove the "scopes" parameter in composeExtensions and it will successfully upload. Guess something was updated in parsing the manifest and they removed scopes parsing.

Thanks for letting us know, I've submitted a PR to correct the app manifest and update the link. Yes, the /new link for creating bots is the correct link to create a bot w/o using the Azure portal. You can safely ignore that warning, it doesn't apply to Teams-only bots. You can however migrate your bot to Azure if you choose, or use the Azure portal to create it.


Add sandbox command to contain deploy, invoke, read

What
Add sandbox command to contain the sandbox versions of deploy, invoke, read.
Why
I took a quick look at how a remote deploy command would be added (#41) and it soon became overwhelming thinking about how to have such a command coexist with the code in the sandbox deploy command.
At some point someone had expressed interest in grouping sandbox command under a sandbox super command so as to clearly separate them from commands that invoke remote services. I think it might have been @paulbellamy who had dropped this idea in a doc a long time ago.
We never did it, but I think it will make it easier to implement the following tasks if we have the sandbox variations under sandbox and put the remote variations of the commands under another subcommand such as remote:

#41
#42
#142

This change makes no functional changes and is purely moving code into a directory (so it is in a Rust module under sandbox), and inserting the sandbox command in between them.

I didn't include serve in this change because while I assume it's probably live under sandbox, I didn't want to move the file right now since other people might be working on it.


Provide a mean to reproduce benchmarks results

Hello,
I am the author of criteo/cassandra_exporter and I would like to be able to reproduce your benchmarks in order to understand where are coming from the differences in performance from the other exporters you compare.
On my side, even on a pretty loaded cluster with a lot of keyspaces/tables the scraping time does not take more than 9sec (the machines have big cpus). But even while when I switched from jmx_exporter, I haven't noticed a huge performance drop regarding the scrapping time. So I am a bit concerned on how you end-up with those results.
Can you please provide a mean to reproduce your benchmarks and the config you are running them on ?
Thanks in advance :)

Closing this as I'm migrating issues to the Instaclustr repo.
Issue duplicated at https://github.com/instaclustr/cassandra-exporter/issues/3


HELLO

What article on docs.github.com is affected?

What part(s) of the article would you like to see updated?

Additional information

Hallo

Leave a commet

This issue appears to have been opened accidentally. I'm going to close it now, but feel free to open a new issue or ask any questions in discussions!


nixos/doc/rl-2211: document nsncd option

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[x] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I think the main issue I want to address with this note is why we're switching to this alternate implementation. I know you left a note about glibc's impl not being able to disable caching, but like... I don't know.
I want to give you a clearer suggestion here, but I would like some more info first.
Why did we decide to switch? Are other distributions using this implementation? If not, what justification do we have for being on the bleeding edge by eventually making this the default?
I think that context would help me figure out what to say and how to say it.

I think the main issue I want to address with this note is why we're switching to this alternate implementation. I know you left a note about glibc's impl not being able to disable caching, but like... I don't know.
I want to give you a clearer suggestion here, but I would like some more info first.
Why did we decide to switch? Are other distributions using this implementation? If not, what justification do we have for being on the bleeding edge by eventually making this the default?
I think that context would help me figure out what to say and how to say it.

https://github.com/NixOS/nixpkgs/issues/135888

Admittedly, I don't know a lot about nss. But, just so I understand things:

But when I run any application that resolves the same DNS name in a loop on a clean NixOS system, I observe that DNS packets are not sent on each request, they are only sent after ttl elapses.

Is this not something we want by default, for whatever reason? Why would we want to disobey the TTL (unless the cache is flushed)?
Sorry if this is a really bad question or something 😅

The nscd file socket is about /dispatching/ the NSS request to a daemon on the system, which takes care of dlopen()ing a working NSS module into its own memory.
glibc-nscd also had a generic not-very-smart cache for the requests it previously replied to, which caused various problems. nsncd avoids these by not doing any caching on its own on that layer, and really just acting as a NSS lookup dispatcher.
Regular distros usually don't run nscd or nsncd so binaries load NSS modules directly. I assume these NSS modules still have their own caches, and honor DNS TTL there.
With nsncd in the mix, this inside-each-nss-module kind of caching would still be present.

@winterqt I described the whole situation about why glibc-nscd is problematic over in https://flokli.de/posts/2022-11-18-nsncd/. Let me know what you think of this should still end up in the release notes.
The main intent for the release notes is making people aware of the option to test it, so we can switch the default eventually.

I incorporated some of the proposed rewordings.


update aks spn doc

update aks spn doc to reflect the recent update

@weinong : Thanks for your contribution to the Azure documentation! The author, @neilpeterson, has been notified to review your proposed change.

@weinong - thanks, works good.
@mmacy - once this merges, I will submit a new PR against https://github.com/MicrosoftDocs/azure-docs-pr/pull/28293 to fix up any merge conflicts plus some additional updates.
#sign-off


[Usersnap] Table view of GAs, sorted by most active proposals

Why
For better navigation and usability
What
Have a field/location that contains the most important current proposals or those receiving the highest number of interactions, to draw the attention of Dreps to the priority of importance.
How
Create a table view of GAs

There are other issues from users asking for this feature: https://github.com/IntersectMBO/govtool/issues/847

Should also be considered for the proposals.


[ToggleButtonGroup] Convert to function component

[x] I have followed (at least) the PR section of the contributing guide.

Hey Just a quick question about LAB if you have time(since i see they are in active development)! i know they are "incubator components" but i'm not sure what that means, are the APIs stable? are they post beta? ready for production? I just cant find any thing related to them. thanks in advance!

@jcursoli The lab is released under an "alpha" flag. It means that the API and implementation can drastically change between two versions. We try to always publish production ready code. Moving a lab component to core requires checking different boxes:

[ ] Have we fixed "enough" issues? I don't think that you can do anything right the very first-time try. It takes different iterations to ship high-quality code. Having 10 opened issue for a lab component probably means that we are not here yet, e.g. the SpeedDial. Each issue fix has a probability to require a breaking change.
[ ] Are people using the components? A low usage rate on Google Analytics probably means we should drop it, e.g. the SpeedDial has a low usage rate.
[ ] ?

@oliviertassinari Thanks for the answer, I appreciate it!


Created lccc.txt

Lehigh Carbon Community College

@ronanfitz0 First stage of verification passed, official domain is lccc.edu as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@ronanfitz0 Thank you for your patience while waiting for a review and processing your request. Pull request merged.


[python-package] fix mypy error about pyarrow data

Contributes to #3756.
Contributes to #3867.
Fixes the following error from mypy:
python-package/lightgbm/basic.py:2889: error: Incompatible types in assignment (expression has type "list[float] | list[int] | ndarray[Any, Any] | Any | Any | Any | Any | None", variable has type "ndarray[Any, dtype[Any]]")  [assignment]

Notes for Reviewers
For more details on how typing.TypeGuard helps with this, see #6106.

thanks @borchero !


Handle case: value change and no DOM events emitted

Problem Statement
Periodically, the .value of an input is set directly.  This doesn't always fire input events.  Example, selecting a date on a jquery UI datepicker won't update the input FieldView's value.
Solution
Check to see if inputValue and this.input.value have diverged when calling the fieldView.value.  To be successful, caching must be disabled as we can no longer rely on 'inputValue' alone to calculate the true field value.

If you need to set the value you should be using this module's setValue function, right?  JqueryUI has always been problematic even outside of this particular module and I've often had to do something like set an onSelect or onClose so that I could properly set the value on the actual element.  Also if you don't use setValue the validation will not run again like it would on, say, a blur. I'm not sure this is a correct approach..

I'm overseas on mobile at the moment, but I did try using setValue first.  I seem to recall it causes a recursive lookup on this derived fn.  the call to setValue I'm not sure even provides value in this situation especially in the event that say, jqui sets a specific value, only to have this module feasibly mutate it and provide unexpected results

@cdaringe can you check if jqueryUI emits a change event? It could be we need to change from the input to the blur event in a way that maintains current behavior?

Hey @wraithgar, I (1) looked thru some example source for the datepicker (my probably most common widget), (2) tested with a fiddle, and (3) chatted around on the irc.  Standard DOM event emitting for common actions across widgets does not sound like it can be relied upon from jQ
if you dont open the fiddle, all it does is demonstrate that change events are fired DOM-wise

I just remembered why we don't want change events, consider an email input.  You wouldn't want the validation running every character the user types, because it's not going to be valid till near the end of their typing.  I really think we should document better setValue and give an example in the readme of how to catch an event from something like datepicker to keep this view's data in sync w/ a jquery library.

OK re-reading the docs it looks like the input event only syncs the inputValue and its only on blur that the validation is run. So I may be wrong, switching input to change for the event may be the only thing needed here.  We'd still want to document what happens when a change event doesn't fire (i.e. calling inputChanged manually it looks like is all you'd need to do)

Ok you may want to disregard those last two comments for now, I'm trying to work through the eventing in a chat cause typing as I go in here is not helpful.

haha, no sweat.  we'll get to the bottom of this conundrum im sure

I think, after a long chat w/ @lukekarrys the solution is going to be:

Start listening for change instead of input  This is simply a more proper event to listen for.
Document that external libs (i.e. bootstrap and jquery) that interact w/ input elements will need to have their events listened to at some time so that setValue can be called.  Basically setValue is going to have to be the official way to interact with the inputs outside of a user typing into the dom directly

I still feel like that's incomplete, as the actual myInput.value can differ from the reported.  Can you re-phrase why an implementation as proposed is not acceptable?

Because I don't think we should support the use case of something setting the value on the input element itself, in a nutshell.

Once you've set up an ampersand-input-view that becomes your object.  The setter is through setValue, and through manual input into the input element via rendered DOM.  The getter is .value on the instantiated input-view, not on the input itself)

Respectfully, the presence of setValue as a proxied value setter method I feel is somewhat irrelevant.  I am of the simple opinion that if there's a change, we should try and detect that change.
Why disregard the change if we can sniff for it?

Trying to re-sync the two if they drift whenever something happens to poll for the derived value attribute just doesn't seem right. I don't know that I have the right words to describe why but it's trying to play catchup.  None of the validation is going to run before that point, so you'd have to somehow know the input.value had changed and then poll for the derived value just to get the tests to run again.  It feels like it's a band-aid that goes down a path that will be impossible to properly support in a predictable way.

Remember that the view state is bound to the inputValue too, and it's reasonable to expect that if the input value changes, the view state will too.  This cannot happen if the module misses the change in the input element's value attribute.  Since that's not something it's possible to do 100% of the time we have to then not set an unrealistic expectation that it can do, and thus the setValue approach.

I think what @wraithgar is saying is the right direction to go. We could sniff for it, but since we know we can't reliably detect 100% of cases, we basically have magic that we know will fail sometimes which will lead to confusing bugs in the future.
I think in this case it's better to be explicit and require using setValue than the implicit case of polling the value.
What we can do is make sure documentation is up to date on this and provide examples such as jQuery plugins and how to bind their changes event to setValue.

Certainly can't disagree with either remarks.  When I consider my inputs, I bind all sorts of other things to them. Autocompletes, datepickers, custom sliders, etc etc.  It seems unfortunate that myValue.input doesn't reflect the actual value without additional massaging from other components/libs (and I understand the justification), but it still seems worthwhile to me in the meantime to permit the sloppy detect almost as a fallback in addition to supplementing documentation.  Is there anything we could do feasibly by making the DOM element observable somehow?  To summarize

No proper change events from external components + with sloppy .input change detection === biased/lagging state.  This is an edge-case, but likely a common one outside of my own dev work
Not all forms need the input value for state (mine included), but said form does need an honest value at submission.  myValue.input return value as it stands === misleading myInput.value return/behavior

This PR https://github.com/AmpersandJS/ampersand-input-view/pull/48 attempts to document the approach of using setValue and also switches from blur to change

@wraithgar updated the README with advisement for interacting with ampersand-input-view with external libs.  Please review the example here for simple guidance per the above discussion!


fix parsing of feels like for weathergov

weather.gov API does not seem to consistently provide a feels like value. The API specs mention an apparentTemperature value, which seems to not be provided most of the time in responses. There is a consistent value of windChill and heatIndex, which according to docs, only has a value when the value falls within a certain threshold.
Before this fix, feels like would only be read from heatIndex and it would be coerced to 0 if the value was null, thus showing a consistent feels like temp of 0 celsius/ 32 fahrenheit.
This pull request uses either windChill or heatIndex for feels like temp if one of them is available. If none are available, it will fall back to the current actual temperature.

Thanks for the PR.
Might it be usefull to check first for apparentTemperature so that IF it is provided it is used for the feelsLike value? And if not, then the other values are taken into account?

I think I was actually mistaken with the link I included for the reference. That one only refers to the gridpoints endpoint, but in this case for the current conditions, we're using the observation endpoint. The schema for that is found here and does not reference apparentTemperature at all, only heatIndex and windChill.
I think based on that, the logic should be sufficient as is. Let me know your thoughts.

Thanks for your contribution! My apologies for my slow response. Life got in the way.


Update Editing methods with DATENeRF: README.md

DATENeRF: Depth-Aware Text-based Editing of NeRFs

Hi, thanks for letting me update the Repo :)
Great job


Switch to Rust bootloader

This change will break i686 support as the new bootloader is meant for x86_64 targets.  However, this is a necessary change because it simplifies the workflow and codebase.
TODO
The following items need to be completed before merging:
~* [ ] Fix issue where base pointer is zero after context switching to new process~  This issue is not related to the bootloader. See #61

[x] Store the CR3 register in process context.  Right now, it's just commented out 😃
[ ] Refactor memory module

[x] Create a map function that calls RecursivePageTable.map_to to reduce code duplication
[ ] General cleaning up of code

[x] Update Travis
[x] Update README

[x] No more i686 support
[x] New workflow
[x] General cleanup

Latest commit fixes #61


Gemmakbarlow/xcode 16 library evolution

Whoops - intended to open this on my repo only. I will open something up here once some of the dependency repos have been updated.


iCal feed of events you've RSVP'd to

It would be sick if RSVPbot was able to give me an iCal feed I could plug into my calendar so stuff automatically shows up when I rsvp yes.
Related: #28

Agreed. The google calendar integration does invite the email addresses of folks who've RSVP'd yes to an event, so they show up some people's calendars, but not everyone :/.
If this can be done quickly it might be worth adding to RSVPBot, but RC is currently working on a super awesome unified events system that will include this feature, so in a few months an RSVPBot ical feed might become obsolete.


Display picture

Coverage decreased (-2.4%) to 88.677% when pulling e31252af481c83151aff42ffb4643417137caf71 on tshradheya:DisplayPicture into c9a44328bcca058598f2dcc619a91c444ca6c521 on CS2103AUG2017-W14-B1:master.


tf-next: Adds support for yarn workspaces

Adds support for yarn workspaces to tf-next build command.
ToDo

[x] Make yarn workspace example working
The thing is that we should should not change the original CWD (So entrypoint is always /package.json etc.), instead we should search for a yarn workspace root, and pass it as basedir when it exists.

Fixes #93.

Hmm, https://github.com/dealmore/terraform-aws-next-js/pull/107/checks?check_run_id=2279172762#step:6:810 seems like the failing tests seem related to them resolving to the correct directory but the base being different.

Yeah the issue is that the sub-directory of the package ends up as prefix in the route config. 🙈
So when the Next.js app is in a packages/webapp/ directory, every route gets this prefix, e.g. example.com/packages/webapp/.
Will take another look soon. 😅

Yep, we currently only create /__NEXT_PAGE_LAMBDA_0/{proxy+} routes for the lambdas in the SAM template.
Unfortunately this does not cover the root route /__NEXT_PAGE_LAMBDA_0/ since it has no proxy part.
Created an upstream issue in sammy: https://github.com/dealmore/sammy/issues/3

Okay, sammy is fixed now and now also supports index routes.
The issue itself is fixed when a more current version of next is used (was 9.1.4).

lol, now another test is failing (╯°□°）╯︵ ┻━┻ 😅

Now released in<EMAIL_ADDRESS>


Documentation for amstream is gone

The documentation for amstream.h header has disappeared and now returns 404
Google cache: https://webcache.googleusercontent.com/search?q=cache:09c-XAHDN68J:https://docs.microsoft.com/en-gb/windows/desktop/api/Amstream/+&cd=1&hl=en&ct=clnk&gl=ru
Current page: https://docs.microsoft.com/en-gb/windows/desktop/api/Amstream/
Search comes back with no results: https://docs.microsoft.com/en-gb/search/index?search=amstream

@ginami I am not sure if it is belong to your area. If not, please assign back to me.


Problem: codemirror highlight

I follow the graphiql-webpack example and run the graphiql locally.
with<EMAIL_ADDRESS>React@16 and webpack.
But the editor missing all the coding features like code highlight, auto-complete, or error warning.

How to fix it? Thanks!

here's the latest master build, strange!
https://graphiql-test.netlify.app/webpack/

did you run yarn build at the root first?

Fix it by uninstalling the previous local codemirror package and re-installing the graphiql again.

It supports highlight now, but still missing auto-complete while editing.

what do you see in doc explorer?

Get it. It's not a valid schema structure. Thanks


Enable smart

smartctl -s on "/dev/$disk" || true

Manually or automatically?

Automatically and forcefully, only the smartest disks are allowed here


Add a command to compare the answers from all authoritatives.

The idea is to add a command that is being given a query, i.e., query name and query type, and queries all authoritative servers – i.e., all the servers mentioned in the NS RRset and all the A and AAAA addresses the set resolves into. It then produces a report with all the answers and differences it got.

Moved to https://github.com/NLnetLabs/dnsi/issues/6


Fixes issue #19

This PR checks whether the LDAP-connection shall use SSL or not and
decides based on that which port to use if no port has been set.
This fixes issue #19

Need unit tests

Its needed a test for connect() params too.
Personally I would try to compact all the existing tests around the port feature.

Hey @Maks3w How would you try to compact the existing tests around the port-feature? I might be a bit slow but I don't actually know how to approach that. Thanks for your help!


Graphs: Add Snakes and Ladders problem in Javascript

https://leetcode.com/problems/snakes-and-ladders/

class Solution {
public:
int snakesAndLadders(vector<vector>& board) {
int n = board.size();
vector flattenedBoard(n * n);
int index = 0;
bool leftToRight = true;
for (int i = n - 1; i >= 0; i--) {
if (leftToRight) {
for (int j = 0; j < n; j++) {
flattenedBoard[index++] = board[i][j];
}
} else {
for (int j = n - 1; j >= 0; j--) {
flattenedBoard[index++] = board[i][j];
}
}
leftToRight = !leftToRight;
}
vector dist(n * n, -1);
queue q;
q.push(0);
dist[0] = 0;
while (!q.empty()) {
int curr = q.front();
q.pop();
if (curr == n * n - 1) {
return dist[curr];
}
for (int i = 1; i <= 6; i++) {
int next = curr + i;
if (next >= n * n) {
continue;
}
if (flattenedBoard[next] != -1) {
next = flattenedBoard[next] - 1;
}
if (dist[next] == -1) {
dist[next] = dist[curr] + 1;
q.push(next);
}
}
}
return -1;
}
};

Send a pr explaining your solution line by line, thanks @RSN601KRI

Can i give my solution in javascript with explanation ( commenting)


Awaiting a non-promise doesn't error

I'm kind of expecting this to throw an error:
async function test() {
    await []; // no error
}

I did a mistake of not using Promise.all():
async function test() {
    let promises: Promise<any>[] = [];
    // ...
    await Promise.all(promises); // no error
}

And it would be helpful if TS could help me catch those mistakes.

I agree this is annoying as I've also occasionally put the wrong thing after await and didn't get any compiler errors.
Having said that, awaiting a non-promise is valid under the spec (although it comes under the heading 'debatable syntax'), and it has well-defined semantics. It is actually convenient in some cases (eg awaiting a value of type T|Promise<T>).
I agree it's annoying but I would not wish something that's currently valid in the ECMA proposal, and that is useful at times, to become an error in TypeScript.
If someone could think up a 'best of both worlds' approach, I'd be all for that.

Also, this is a duplicate of #8310, and there's a lot more discussion there.

Yes duplicate of #8310.


Initial display screen

Hi,
Thanks for a great library!
I had a question about the display_screen flag. Even when the flag is turned off, I see a black pygame window (see image attached) pop up. Is there a way to disable it?
Thanks!

Hey! So this pops up by when you initialize PyGame, regardless of its usage with PLE, whether or not you draw anything to the game frame. Currently I don't believe it can be disabled but I am looking into it as I eventually want PLE to run without a display system (headless server etc.).
I usually just minimize the frame or make use of it during testing loops to show me how the agent is performing, so its not completely annoying.

Thanks for the clarification!

@ntasfi @nishithbsk Any chance this could maybe be disabled? I am experimenting with spawning the environment on multiple processes and windows popping all over the screen can get a bit annoying.


🐛  Update best-practices.md to update the spelling of Kubernetes

fixes #2222

Summary
Related issue(s)
Fixes #2222

thanks for the fix - let me have a look

/ok-to-test

A note -- this is fixed in the file on the new website from PR #2229 but that doesn't display at kubestellar.io yet

@rchen-devv the new site was published a few hours ago. Check if this spelling is fixed already. If so, close this PR. You still get credit for the PR!

@rchen-devv the new site was published a few hours ago. Check if this spelling is fixed already. If so, close this PR. You still get credit for the PR!

Note that until the next release triggers a render, the new site can be previewed at https://kproche.github.io/kubestellar/doc-new-v2
And this page in particular is at https://kproche.github.io/kubestellar/doc-new-v2/direct/best-practices/

Just checked out the new site and its look good to me. Will close this PR.


Provide an option to scan and add the hateoas providers for the user

I was too hasty with merging #4, so I forgot that the library now does not search for the providers that the user created to add them to the service collection.
This means that the user would need to do this theirselves, which is not a great user experience:
services.AddScoped<HateoasProvider<SomeModel>>()
I would propose the following:

When you call AddHateoas() (see ServiceCollectionExtensions.cs) , you can pass no parameters OR you can pass a HateoasOptions parameter (or something like that, take a look at other ASP.NET core libraries for popular naming schemes)

Passing no params means that it will search for all IHateoasProvider and IAsyncHateoasProvider in the current assembly and add them to the servicecollection. I know that this is easy with Scrutor, but I am unsure how to do this without Scrutor. A fun challenge!
Inspired by Automapper, a user could also pass a list of assemblies so we can scan in multiple assemblies. This is useful for when the user has their hateoas providers in a different assembly.

Please keep in mind that #15 might still affect this story a little bit!

Closed because the related PR should have implemented this issue.


Fix space typo in wiki link for Standard deviation

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Just typo fix for wiki link to https://en.wikipedia.org/wiki/Standard_deviation

We can't accept a PR that changes the translated files, those are managed through automated pipelines

Heya @ponomarevkonst,
Have you had a chance to revisit ieahleen's review?

I went ahead and removed the changes to the other languages. This should be good to go.

Hi @ponomarevkonst . Congrats on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 📝


Manifest 1.2.1 tags for all components

Description
Adding in tags for all components
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Oops, wrong target


Open Collective oauth installation

Install Open Collective using the oauth flow by way of the OC Metagov Plugin (Requires https://github.com/metagov/gateway/pull/220).
This code attempts to set up webhooks on init using createWebhook mutation but this part doesn't seem to be working. For now we can continue to expose the webhook URL to the user in the PolicyKit Settings page and ask them to add it manually. (https://github.com/policykit/policykit/pull/579/commits/8f8985c186cc803a711b0205f8e5065f018e08f5)
Does NOT include:

Adding "Install to Open Collective" to the Policykit installation page
Adding "Log in with Open Collective" to the Policykit installation page

Looks great, thanks @gigxz!!


Running exe with mimalloc on wine

Hi,
I am trying to run an application that uses mimalloc on wine.
the pre built mimalloc-redirect.dll uses a function called RtlQueryEnvironmentVariable
in ntdll.dll. this function is not implemented under wine.
I wonder what win32 calls created that dependency so I can call wine and ask them for implementation. so it would be helpful if I can compile this code myself.
Alon

Ah, the mimalloc-redirect.dll is very specific for Windows -- I am surprised though RtlQueryEnvironmentVariable is not available as that has been around a long time. The best way is to ask the Wine developers to support this. However, it may still not work as it is quite specific to Windows and ucrtbase.dll. :-(


Add Seti theme

Invalid, wrong branch

Coverage remained the same at 60.873% when pulling eef94af176a5cecbab1caa1f03bfb7e1d0435612 on aeschli/seti-theme into 2bb55b7cff44755bafd03c5d50e22e336360b787 on master.


[Bug] Missing docs on "env" field in Grafana.Deployment.Spec

Describe the bug
I was looking through the docs for Grafana.Deployment.Spec to see if env was supported, and I could only find envFrom. Then I found https://github.com/grafana-operator/grafana-operator/pull/500, which actually implemented it. It would be nice to have this documented in the following places (at least that's where it seems it should be documented)

https://github.com/grafana-operator/grafana-operator/blob/master/documentation/deploy_grafana.md#configuring-the-deployment
https://github.com/grafana-operator/grafana-operator/blob/master/documentation/env_vars.md

Version
v4.8.0
To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/grafana-operator/grafana-operator/blob/master/documentation/deploy_grafana.md#configuring-the-deployment)
See that env is not mentioned, only envFrom

Expected behavior
I expected env to be documented as it was actually implemented in https://github.com/grafana-operator/grafana-operator/pull/500.

@jasaltvik these docs are outdated, we now auto generate the API docs. The env field is described here: https://github.com/grafana-operator/grafana-operator/blob/master/documentation/api.md#grafanaspecdeploymentenvindex

Hi. Maybe database settings can be from secret like this ?
    env:
    - name: DB_VENDOR
      value: "postgres"
    - name: DB_ADDR
      valueFrom: { secretKeyRef: { name: hippo-pguser-hippo, key: host } }
    - name: DB_PORT
      valueFrom: { secretKeyRef: { name: hippo-pguser-hippo, key: port } }

@jasaltvik these docs are outdated, we now auto generate the API docs. The env field is described here: https://github.com/grafana-operator/grafana-operator/blob/master/documentation/api.md#grafanaspecdeploymentenvindex

@pb82 Thanks! I don't know what the plans are for documentation going forward, but you could consider updating the main repo README to make it clearer that the API docs are the preferred docs. Maybe update https://github.com/grafana-operator/grafana-operator#supported-custom-resources.


Training on multi-GPU

Hi dear author,
I would like to train the temos on multi-GPU. As shown in Fig.1, It runs well when using one GPU as default. But, when I try to run it on multi-GPU and set the gpus: 4 in the trainer config file, I meet a Type Error  shown in Fig.2. So, I would like to know how to train temos on multi-GPU well.
One GPU Training:

Four GPUs Training:

Hello @Lucky-Maximize,
I just solved this "pickle problem" with this commit: https://github.com/Mathux/TEMOS/commit/3e0efdd8acc253e7144a819c98e755b9e5c4dc1e
Actually, the current code is not designed for GPU-training and it is not working yet. When I will have more time, I will probably investigate and make it work. I need to redesign a bit the data loading, and the metric computation.


Cannot extend a Glimmer component

Base component:
import Component from '@glint/environment-ember-loose/glimmer-component';

export default class GlimmerComponent extends Component<{}> {}

Child component:
import GlimmerComponent from './glimmer-component';

export default class ChildGlimmerComponent extends GlimmerComponent {}

Both should have an HBS file (empty for example). That leads to:
app/components/child-glimmer-component.ts:3:22 - error TS2417: Class static side 'typeof ChildGlimmerComponent' incorrectly extends base class static side 'typeof GlimmerComponent'.
  Types have separate declarations of a private property ''~template''.

3 export default class ChildGlimmerComponent extends GlimmerComponent {}
                       ~~~~~~~~~~~~~~~~~~~~~

I'm a very strong believer in avoiding component inheritance, but that doesn't mean we should break it 😄


EXE - process message

When the EXE file is run, a black window appears with no message. User experience shows this is confusing as sometimes it takes a minute or more for the UI window to open:
Add a message to tell users that the EXE is working / opening, please wait....

https://pyinstaller.org/en/v4.7/usage.html?highlight=splash#splash-screen-experimental allows you to add a splash screen to pyinstaller but is incompatible with mac os

@stufraser1 We've managed to get a splash screen image showing while the app is loading (non mac only).  We've used a basic loading icon - https://github.com/OasisLMF/OpenDataTransform/blob/feature/splash-screen/splashfile.png but can change this if you have an image you prefer

This has been implemented for non mac uses with the image above.


feat: add a proto & GORM/Gen demo

What type of PR is this?
feat
What this PR does / why we need it (English/Chinese):
English: add a proto & GORM/Gen demo with hertz
中文：新增结合proto&GORM/Gen的hertz框架样例

ci need to solve.

I think it would be clearer to use hertz_gorm_gen instead of hertz_gen and you would need to add it in the readme.

You are right, have changed to a better name

LGTM

LGTM


feat: port AlgebraicTopology.DoldKan.FunctorGamma

[ ] depends on: #3561
[ ] depends on: #3563

This PR/issue depends on:

leanprover-community/mathlib4#3561
leanprover-community/mathlib4#3563
By Dependent Issues (🤖). Happy coding!

bors merge


feat: make de and ser modules public

PR makes the de and ser modules public, specifically so that the Deserializer and Serializer structs can be used directly in edge cases where the existing assert_(*_)tokens utilities do not meet the requirement.

@dtolnay Shameless self-bump 😅

@dtolnay Re-bumping

The serde_assert crate already provides Deserializer and Serializer types for testing. Does that work for your use case? https://docs.rs/serde_assert

It would certainly appear to 😅. Thank you for pointing it out! Apologies for the unnecessary noise


Improve Camera naming and make bevy_ui respect cameras

Consider renaming Camera to something like RenderSurface. There isn't anything camera-like about our Camera component, and I think calling it a RenderSurface is more apt:

It has a size and position (viewport rect) that directly ties to the dimensions of the image you are rendering.
It has a target to render the 2d area to.
It can be ordered with other render surfaces that have the same target.

This is why bevy_picking relies on Camera - because the Camera component really describes the 2d area that Camera2d and Camera3d render to.
Following that first thought, there is a natural one-to-one cardinality between a UI tree and it's RenderSurface (Camera). You can't really show a UI tree on multiple render surfaces, because the size of the UI is dependent on the size of the render surface it is given to lay out into.
This is why, when this came up last time, I suggested that UI trees should be children of a RenderSurface (Camera). It would also, IMO solve some of the DX issues. You aren't spawning a freestanding UI camera, a freestanding UI tree, then linking them with a TargetCamera, it would make way more sense to me if the UI tree used our existing relationship for this: parenting.
If you want to have multiple UI trees on the same image, well, you would have a unique RenderSurface(Camera) at the root of each of these trees. This is nice because the order of these UI's sharing the same render target is explicit.
// Instead of
let ui_camera = commands.spawn(Camera);
commands.spawn((Node, TargetCamera(ui_camera)).with_children(|| /*...*/);
// What happens if two UI roots target the same camera? How are they ordered?
commands.spawn((Node, TargetCamera(ui_camera)).with_children(|| /*...*/);

// Renaming `Camera` to `RenderSurface` to illustrate this is what it really means:
// Two UIs and a 3d camera rendering to the default window, with order specified
// The render surface *is* the root UI node: it sets the viewport that can be drawn
comands.spawn((RenderSurface { order: 0, .. }, Node)).with_children(|| /*...*/);
comands.spawn((RenderSurface { order: 1, .. }, Node)).with_children(|| /*...*/);
comands.spawn((RenderSurface { order: 3 }, Camera3d))

You can also see how the UI/3d/2d can share the same abstractions for viewports, camera order, render targets.
For example, rendering the UIs to the second window, with a particular order, using a different sub viewport:
comands
    .spawn((RenderSurface { order: 0, viewport: Some(viewport_1), target: window_2 }, Node))
    .with_children(|parent| parent.spawn(Node));

comands
    .spawn((RenderSurface { order: 1, viewport: Some(viewport_2, target: window_2 }, Node))
    .with_children(|parent| parent.spawn(Node));

Some relevant comments:

@NthTensor: Oh, as an added benefit: people are constantly annoyed at how cumbersome it is to overlay 3d models on UI currently. This seems like it might be an interesting way to solve that little rough spot.

Cleaning up this area would help us make progress towards https://github.com/bevyengine/bevy/issues/5476.

I fully support this proposal.

Should we rename TargetCamera to match?

In this proposal, TargetCamera no longer exists. The relationship is explicit.

With the new required components stuff, we could preserve some of the existing default behavior by having Node require the "default" RenderSurface, which I guess would be the full main window viewport with order 0.

This is already the case. It appears the cameras already require Camera. We would need to do this for the root node as well. It couldn't be on Node, which is used everywhere in the hierarchy.

Heritable render surfaces for UI (and other objects?) make a ton of sense to me :)

Left some thoughts here https://github.com/bevyengine/bevy/pull/16248#issuecomment-2463322287


Prusaslicer/Orcaslicer integration?

I'm a huge fan of this service and sending data from Cura is essential to my workflow. Any chance this plugin can be translated to more basic post-processing script, or some other way of integrating into the Prusa/Orcaslicer variants? I don't have any experience with Python so unfortunately I can't be any help. Thanks for making my life easier with this plugin.

I attempted it a few years ago, but documentation on that post-processing script was hard to come by. After taking a quick look now though, it seems there is more info out there.
Thanks for the suggestion, I'll put it on my to-do list and I'll see what I can do.


Get Pandas to work with versions

Try to get wrangles (all tests) and any other testing
to work with
pandas version 1.4 and above

The only error came from pandas reindex. It did not allow to use axis, index and columns
The current function sets the value defaults as None but versions before 2 do not accept this.
I added a filter that will will drop any None values and add them to the pd.reindex
    # Adding parameters to dictionary
    params = {"labels": labels, "index": index, "columns": columns, "axis": axis}
    # filter any None values
    params = {k:v for (k, v) in zip(params.keys(), params.values()) if v != None}
    # merge with kwargs
    parameters = {**params, **kwargs}
    df = df.reindex(**parameters)


Add gemfile flag to exec command

What was the end-user problem that led to this PR?
This PR resolves the issue #5924
What was your diagnosis of the problem?

added a gemfile flag in cli.rb
if options[:gemfile] is set I created a SharedHelper method custom_gemfile which used the predefined find_file function to find and set the environment variable with the argument provided

Hi

This needs a test to make sure the feature is behaving as expected and to make sure it will continue to work when new changes are made.

@colby-swandale I'll start working on the test. Will update the pr asap. :wink:

@segiddins Thankyou so much for your comment :smile: I understood what I was doing wrong. I've updated the test now.

Great! Thank you! 🎉
@bundlerbot r+

@colby-swandale I don't understand why the jobs corresponding to the failing tests were canceled. What needs to be done? :thinking:

Thanks! @bundlerbot r+

@budlerbot retry

@bundlerbot retry


Create temporary value to fix expect_response with function name

When function name has not been sent, cor_id should be taken from origin value, but it was rewritten by nil value.
Related to APPLINK-24873
Please review @OHerasym, @okozlovlux, @LevchenkoS, @VProdanov, @dtrunov, @nk0leg

@VVeremjova, reviewed.

@VVeremjova reviewed

@VVeremjova Reviewed

@VVeremjova  Reviewed

Reviewed

Reviewed


can I get access to nofacies_data.csv with the solution

It's here > https://github.com/seg/2016-ml-contest/blob/master/blind_stuart_crawford_core_facies.csv


plugins

hello is there a way we can add plugins like shop and the other stuff we can add on windows ? i was searching on the web and didnt find anything .. so i ask bcz ur an expert in linux maybe u have any idea about that thank u

While I don't doubt FezVrasta is a Linux Guru, I do doubt he wants to spend time coding these plugins by himself. If you are thinking about the same API that I looked at, it does seem like making it for Linux is more of a hassle than necessary.
https://arkserverapi.com/threads/faq.5/

yh np for me it is fine now i rented a windows machine :D thanks for that
reply
On 21 April 2018 at 12:26, Daniel Dahl<EMAIL_ADDRESS>wrote:

While I don't doubt FezVrasta is a Linux Guru, I do doubt he wants to
spend time coding these plugins by himself. If you are thinking about the
same API that I looked at, it does seem like making it for Linux is more of
a hassle than necessary.
https://arkserverapi.com/threads/faq.5/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FezVrasta/ark-server-tools/issues/949#issuecomment-383280751,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AkC9FwxOaU6xUiGUIQYxZfjGkbSOvnUSks5tqvs3gaJpZM4TN3Ml
.


Proposal: Editorial Workflow (v2)

[This is not the first discussion of editorial workflow for the IPFS blog. Previous attempts resulted in explicit, regimented workflows that didn't prove useful. Please think of this proposal as a fresh start.]
As the IPFS project grows, and as our activities widen, we have a choice to make about the editorial approach, and overall "voice" of the blog:
Option 1: Make the blog into a tightly controlled, information source that strictly adheres to the voice of the IPFS project, with a consistent writing style and consistent content emphasis.
Option 2: Treat the blog as a platform that gives visibility to individual IPFS maintainers and IPFS contributors who each have their own interests and writing style.
I prefer option 2. Our recent posts reflect that style. I think we can do even better.
Reference: Common structure in newsrooms
In most newsrooms you have writers, editors, an Editor in Chief, and a publisher. Writers pitch ideas and produce content. Editors figure out which content should be included and are responsible for ensuring quality & consistency. The Editor in  Chief is ultimately responsible for any editorial decisions and for ensuring that editorial policy is followed -- if something bad gets published, the Editor in Chief is responsible for the lapse in quality control. The publisher is not involved in daily operations -- they provide executive-level input (ie. steering the overall focus of coverage) and hold the Editor in Chief accountable.
One key idea is the notion of an editorial staff -- the editors and the editor in chief -- who work together to make sure they put out compelling content with a consistent "editorial voice".  Though individual articles and/or columns might have their own style and their own focus, the overall newspaper/platform adheres to some conventions of writing quality, emphasis, fact checking, technical detail, etc.
Contrast this with a site like Medium, where anyone can publish whatever they want. Any consistency to the content is achieved socially, not through editorial policies.
Proposal

Name a group of editors (@diasdavid, @mishmosh, @flyingzumwalt)
@jbenet has the role of Publisher
Don't have an editor in chief -- let the editors share that responsibility.
Encourage maintainers and contributors to submit their own posts. They must pitch their post to an editor before submitting, to make sure it fits with our roadmap and editorial policies. (people have already been doing this informally)
Blog posts need to be reviewed and approved by 2 editors before getting published.
Add author photos to blog post bylines, to reinforce the idea that the blog is a platform for many voices, with an editorial staff enforcing quality, rather than a unitary voice of "the IPFS".
Editors gradually define the editorial policies through trial and error.

This is a great approach to take the IPFS blog to the next stage. It's fairly close to how we've been operating in recent months. To get publisher, editors, and blog contributors on the same page, I'd like to propose the following addition:
3.5. Editors write a Contributors guide outlining the editorial policies, especially aspects like:

naming the types of posts we want to encourage
framing demos in ways that can be relevant & interesting across fields

Thank you for writing down this proposal, Matt. As @mishmosh pointed out, it is very much like the way we've been operating the blog and what enabled it to have more life. We've been receiving a lot of love for the recent articles.
Shall we consider bringing back the IPFS Newsletter as we design the new Editorial workflow?


Add ap south 1

Changelog
Fill this in and update CHANGELOG.md
Issues fixed or closed
Questions (open the PR then click the check boxes)
Did you update the documentation related to your changes?

[X] Yes
[ ] My changes were not already documented

Did you run make before committing code and opening this PR?

[x] Yes
[ ] I didn't change any code

Did you run porter create-stack and porter sync-stack to verify provisioning
works?

[x] Yes
[ ] N/A

👍

👍


add reducers and actions

In this PR I:

[x] Added Redux Toolkit (npm install react-redux @reduxjs/toolkit).
[x] Created a directory that will contain all my Redux logic (/src/redux)
[x] Configured a Redux store
[x] Defined a slice of state for books
[x] Added a reducer that adds a book
[x] Added a reducer that removes a book
[x] Defined a slice of state for categories that:

Hello dear reviewer.
I'm repeating this week because I somehow accidentally deleted my project last week while I was trying to style it. Please understand that I might even make some silly mistakes in this redo, so if anything is not clear please ask me before you finalize your review. Thank you so much for understanding😊

Hi @Paulinelali,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that is invalid because you have submitted the wrong project “add reducers and actions” instead of “redux in react components”
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


where is build/stats.json

as the title ,where is build/stats.json...
Error: Cannot find module '../../build/stats.json'

You have to build the project once at least before running server
whether npm run hot-dev-server or npm run build

@xZGit Has this fix your problem?

yes！！！thank you very much！！！


Perceptrons

Implementations of the following:

[ ] Perceptron

[ ] Perceptron as AND operator

[ ] Perceptron as NAND operator

[ ] Perceptron as NOR operator

[ ] Perceptron as NOT operator

[ ] Perceptron as OR operator

[ ] Perceptron as XNOR operator

[ ] Perceptron as XOR operator

[ ] Softmax function

[ ] ReLU function

@geekquad Can you assign me Softmax function, ReLU function, Perceptron, and Perceptron as AND operator! Thanks.

Assigning

[x] Softmax Function

[x] ReLU Function

[x] Perceptron

[x]  Perceptron as AND operator

to @friskycodeur.

can you assign me Perceptron as NOT operator, Perceptron as OR operator

Assign me perceptron as NAND operator

Assigning Perceptron as NOT operator and OR operator to @Iampradeepkundra.
Assigning Perceptron as NAND and NOR operator to @akash22022.

I am interested in solving these,

Perceptron as XNOR operator
Perceptron as XOR operator

Can you assign me?

Assigning Perceptron as NOT operator and OR operator to @abhinand5.

Assigning Perceptron as XNOR operator and XOR operator to @Iampradeepkundra.

@geekquad kindly assign the remaining Perceptron as XNOR and XOR operator to me. I can contribute towards them.

Assigning XNOR and XOR perceptron to @A-Pandey20.

@geekquad hey! I was assigned perceptrons XOR operator and have added a pull request for that. Kindly take a note.

@A-Pandey20, you were assigned XOR as well as XNOR. Do you want to opt-out of XNOR?
Also, PR for XOR is already merged.

@A-Pandey20, you were assigned XOR as well as XNOR. Do you want to opt-out of XNOR?
Also, PR for XOR is already merged.

@geekquad i am working on XNOR. XOR was completed so I created a pull request for it.
I will create another pr for XNOR once it is completed.


fix(menu-item): fix font-size (VIV-1589)

@rachelbt I've addressed the comments, please have another look


Add hangClosing option to support flake8 argument

up?

Hi @cbenz, thank you for contributing - Late response, but we have got holidays in Poland . I'll try today (eventually tomorrow) test your code and merge it to source If everything will be working fine.


Fix problems with IE when getting orignal constructor for injecting properties

Fixes issue #12.
However, there is problem with tests coverige, as long as these changes are done in non-exported class, so I'm not able to run separate tests outside of the module.

Coverage decreased (-3.7%) to 90.551% when pulling 082852178b4640d0401842f325e0ce95d9e3e733 on cfmano:master into<PHONE_NUMBER>ee7428e72e269175d174a90250bae3 on thiagobustamante:master.

Hi @cfmano ,
Thanks for you PR. I did not test your code, but I think that your new function hasNamedConstructor should be called by getConstructorFromType.

@thiagobustamante yes you are right. I forgot to push one commit. Now it should be OK.