Autologin doesn't work

Describe the bug
Autologin doesn't work. Every time I open Spot it prompts me to log back in. If I close the login prompt, it refuses to play saying that the player isn't responding. GNOME Keyring is unlocked and the "Spotify Credentials" entry is present.
To Reproduce
Steps to reproduce the behavior:

Open Spot and log in
Close Spot
Open Spot again
See the login prompt
If you close the login prompt without logging in, you can't play any tracks

Expected behavior
Autologin should work.
General information:

Distribution: Artix Linux (+ Sway Wayland compositor)
Installation method: Built from source via AUR package spot-client-git
Version: Commit 4b1209dc97daa5ba57be0178462baf388d014fc5 from development branch
Device used: Desktop

Stack trace:
There's no stack trace, but this is the output when running spot from the terminal (although it doesn't look relevant):
(process:8927): Adwaita-CRITICAL **: 21:43:21.017: adw_leaflet_set_visible_child: assertion 'contains_child' failed

Additional context
I'm not using Flatpak.
On a Fedora installation, it works fine with the latest Flatpak version.

if you're able to test, do you have the issue before 2edca59b622848c5950b00106282c7ed706c68f3 ?

Yes, I compiled the parent commit of the one you linked to (https://github.com/xou816/spot/commit/653aec8c808e8d5edcf051fb5cd2f18fe1859464), the issue is still there.

Running with RUST_LOG="debug" spot gives me the following:
(process:14031): Adwaita-CRITICAL **: 22:53:16.633: adw_leaflet_set_visible_child: assertion 'contains_child' failed
[2023-02-16T21:53:16Z DEBUG isahc::agent] agent_thread; id=0
[2023-02-16T21:53:16Z DEBUG isahc::agent] agent took 152.831µs to start up
[2023-02-16T21:53:16Z INFO  tracing::span] socket reader;
[2023-02-16T21:53:16Z INFO  zbus::connection] {}; obj_server_task_name="ObjectServer task"
[2023-02-16T21:53:16Z DEBUG spot] activate
[2023-02-16T21:53:16Z DEBUG spot::app::models::songs::song_list_model] pos 0, removed 0, added 50
[2023-02-16T21:53:18Z DEBUG spot::app::components::window] saving geometry

ok thanks!! this at least rules a recent change
I'm surprised that it works okay with the flatpak version but doesnt otherwise

@xou816 note that the Flatpak version that works for me is the latest stable version, 0.3.1, not the latest git-commit. The non-Flatpak version is the latest commit, the one that doesn't work. If I get some time in the coming days, I can try to git bisect it and find the offending commit.

I tried running the Flatpak version with RUST_LOG=debug as well, which corretly logs in automatically:
(process:2): Adwaita-CRITICAL **: 16:02:49.410: adw_leaflet_set_visible_child: assertion 'contains_child' failed
[2023-02-17T15:02:49Z DEBUG isahc::agent] agent_thread; id=0
[2023-02-17T15:02:49Z DEBUG isahc::agent] agent took 372.944µs to start up
[2023-02-17T15:02:49Z DEBUG spot] activate
[2023-02-17T15:02:49Z DEBUG hyper::client::connect::dns] resolving host="apresolve.spotify.com"
[2023-02-17T15:02:49Z DEBUG hyper::client::connect::http] connecting to <IP_ADDRESS>:80
[2023-02-17T15:02:49Z DEBUG hyper::client::connect::http] connected to <IP_ADDRESS>:80
[2023-02-17T15:02:49Z DEBUG hyper::proto::h1::io] flushed 47 bytes
[2023-02-17T15:02:49Z DEBUG hyper::proto::h1::io] parsed 5 headers
[2023-02-17T15:02:49Z DEBUG hyper::proto::h1::conn] incoming body is content-length (169 bytes)
[2023-02-17T15:02:49Z DEBUG hyper::proto::h1::conn] incoming body completed
[2023-02-17T15:02:49Z DEBUG hyper::client::pool] pooling idle connection for ("http", apresolve.spotify.com:80)
[2023-02-17T15:02:49Z INFO  librespot_core::session] Connecting to AP "ap-gew4.spotify.com:4070"
[2023-02-17T15:02:49Z DEBUG spot::app::models::songs::song_list_model] pos 0, removed 0, added 50
[2023-02-17T15:02:49Z INFO  librespot_core::session] Authenticated as "username" !
[2023-02-17T15:02:49Z DEBUG librespot_core::session] new Session[0]
[2023-02-17T15:02:49Z INFO  spot::player::player] bitrate: Bitrate320
[2023-02-17T15:02:49Z INFO  librespot_playback::mixer::softmixer] Mixing with softvol and volume control: Log(30.0)
[2023-02-17T15:02:49Z DEBUG librespot_core::session] Session[0] strong=3 weak=1
[2023-02-17T15:02:49Z INFO  librespot_core::session] Country: "DK"
[2023-02-17T15:02:49Z DEBUG librespot_playback::player] new Player[0]
[2023-02-17T15:02:49Z INFO  librespot_playback::convert] Converting with ditherer: tpdf
[2023-02-17T15:02:49Z INFO  spot::player::player] using pulseaudio
[2023-02-17T15:02:49Z INFO  librespot_playback::audio_backend::pulseaudio] Using PulseAudioSink with format: S16
[2023-02-17T15:02:49Z DEBUG isahc::client] send_async; method=GET uri=https://api.spotify.com/v1/me/albums?offset=0&limit=30
[2023-02-17T15:02:49Z DEBUG isahc::handler] handler
[2023-02-17T15:02:49Z DEBUG isahc::handler] handler; id=0
[2023-02-17T15:02:49Z DEBUG isahc::handler]   Trying <IP_ADDRESS>:443...
[2023-02-17T15:02:49Z DEBUG isahc::handler] Connected to api.spotify.com (<IP_ADDRESS>) port 443 (#0)
[2023-02-17T15:02:49Z DEBUG isahc::handler] ALPN, offering h2
[2023-02-17T15:02:49Z DEBUG isahc::handler] ALPN, offering http/1.1
[2023-02-17T15:02:49Z DEBUG isahc::handler]  CAfile: /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem
[2023-02-17T15:02:49Z DEBUG isahc::handler]  CApath: /etc/pki/tls/certs
[2023-02-17T15:02:49Z DEBUG isahc::handler] TLSv1.3 (OUT), TLS handshake, Client hello (1):
[2023-02-17T15:02:49Z DEBUG isahc::handler] TLSv1.3 (IN), TLS handshake, Server hello (2):
[2023-02-17T15:02:49Z DEBUG isahc::handler] TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
[2023-02-17T15:02:49Z DEBUG isahc::handler] TLSv1.3 (IN), TLS handshake, Certificate (11):
[2023-02-17T15:02:49Z DEBUG isahc::handler] TLSv1.3 (IN), TLS handshake, CERT verify (15):
[2023-02-17T15:02:49Z DEBUG isahc::handler] TLSv1.3 (IN), TLS handshake, Finished (20):
[2023-02-17T15:02:49Z DEBUG isahc::handler] TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
[2023-02-17T15:02:49Z DEBUG isahc::handler] TLSv1.3 (OUT), TLS handshake, Finished (20):
[2023-02-17T15:02:49Z DEBUG isahc::handler] SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
[2023-02-17T15:02:49Z DEBUG isahc::handler] ALPN, server accepted to use h2
[2023-02-17T15:02:49Z DEBUG isahc::handler] Server certificate:
[2023-02-17T15:02:49Z DEBUG isahc::handler]  subject: C=SE; L=Stockholm; O=Spotify AB; CN=*.spotify.com
[2023-02-17T15:02:49Z DEBUG isahc::handler]  start date: Apr  6 00:00:00 2022 GMT
[2023-02-17T15:02:49Z DEBUG isahc::handler]  expire date: Apr  6 23:59:59 2023 GMT
[2023-02-17T15:02:49Z DEBUG isahc::handler]  subjectAltName: host "api.spotify.com" matched cert's "*.spotify.com"
[2023-02-17T15:02:49Z DEBUG isahc::handler]  issuer: C=US; O=DigiCert Inc; CN=DigiCert TLS RSA SHA256 2020 CA1
[2023-02-17T15:02:49Z DEBUG isahc::handler]  SSL certificate verify ok.
[2023-02-17T15:02:49Z DEBUG isahc::handler] Using HTTP2, server supports multiplexing
[2023-02-17T15:02:49Z DEBUG isahc::handler] Connection state changed (HTTP/2 confirmed)
[2023-02-17T15:02:49Z DEBUG isahc::handler] Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0
[2023-02-17T15:02:49Z DEBUG isahc::handler] Using Stream ID: 1 (easy handle 0x559391467000)
[2023-02-17T15:02:50Z DEBUG isahc::handler] TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
[2023-02-17T15:02:50Z DEBUG isahc::handler] TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
[2023-02-17T15:02:50Z DEBUG isahc::handler] old SSL session ID is stale, removing
[2023-02-17T15:02:50Z DEBUG isahc::handler] Connection #0 to host api.spotify.com left intact
[2023-02-17T15:02:50Z DEBUG isahc::client] send_async; method=GET uri=https://api.spotify.com/v1/me/playlists?offset=0&limit=30
[2023-02-17T15:02:50Z DEBUG isahc::handler] handler
[2023-02-17T15:02:50Z DEBUG isahc::handler] handler; id=0
[2023-02-17T15:02:50Z DEBUG isahc::handler] Found bundle for host api.spotify.com: 0x7fd090007930 [can multiplex]
[2023-02-17T15:02:50Z DEBUG isahc::handler] Re-using existing connection! (#0) with host api.spotify.com
[2023-02-17T15:02:50Z DEBUG isahc::handler] Connected to api.spotify.com (<IP_ADDRESS>) port 443 (#0)
[2023-02-17T15:02:50Z DEBUG isahc::handler] Using Stream ID: 3 (easy handle 0x559391467000)
[2023-02-17T15:02:50Z DEBUG isahc::handler] Connection #0 to host api.spotify.com left intact
[2023-02-17T15:02:50Z DEBUG isahc::client] send_async; method=GET uri=https://api.spotify.com/v1/me/tracks?offset=0&limit=50
[2023-02-17T15:02:50Z DEBUG isahc::handler] handler
[2023-02-17T15:02:50Z DEBUG isahc::handler] handler; id=0
[2023-02-17T15:02:50Z DEBUG isahc::handler] Found bundle for host api.spotify.com: 0x7fd090007930 [can multiplex]
[2023-02-17T15:02:50Z DEBUG isahc::handler] Re-using existing connection! (#0) with host api.spotify.com
[2023-02-17T15:02:50Z DEBUG isahc::handler] Connected to api.spotify.com (<IP_ADDRESS>) port 443 (#0)
[2023-02-17T15:02:50Z DEBUG isahc::handler] Using Stream ID: 5 (easy handle 0x559391467000)
[2023-02-17T15:02:50Z DEBUG isahc::handler] Connection #0 to host api.spotify.com left intact
[2023-02-17T15:02:50Z DEBUG spot::app::models::songs::song_list_model] pos 0, removed 50, added 50
[2023-02-17T15:04:49Z DEBUG librespot_core::session] Session[0] strong=3 weak=1

I wonder if it's not related somehow to https://github.com/xou816/spot/issues/558 maybe there is a login failure happening for some reason that would wipe your credentials
I'll think about it and push a temporary build with some additional logging maybe

if you're able to add a dbg! like so for instance
diff --git a/src/app/state/login_state.rs b/src/app/state/login_state.rs
index 366458b..3b9cfa7 100644
--- a/src/app/state/login_state.rs
+++ b/src/app/state/login_state.rs
@@ -83,7 +83,7 @@ impl UpdatableState for LoginState {
     type Event = AppEvent;

     fn update_with(&mut self, action: Cow<Self::Action>) -> Vec<Self::Event> {
-        match action.into_owned() {
+        match dbg!(action).into_owned() {
             LoginAction::TryLogin(TryLoginAction::Password { username, password }) => {
                 vec![
                     LoginEvent::LoginStarted(LoginStartedEvent::Password { username, password })

it would help to see if you have a log similar to
[src/app/state/login_state.rs:86] action = TryLogin(
    Token {
        username: "username",
        token: "some token",
    },
)

before you attempt to login manually!

@xou816 there's no such log entry, even after adding dbg().

were you logged in at least once before?
also worth trying: this PR fixes a couple issues with login #598 (handles connectivity issues more gracefully)

were you logged in at least once before?

Yes, I also tried logging in manually, closing the app and repoening.

also worth trying: this PR fixes a couple issues with login https://github.com/xou816/spot/pull/598

I was just about to do that :)

Nope, still not working:
(process:10503): Adwaita-CRITICAL **: 18:12:27.400: adw_leaflet_set_visible_child: assertion 'contains_child' failed
[2023-02-18T17:12:27Z DEBUG isahc::agent] agent_thread; id=0
[2023-02-18T17:12:27Z DEBUG isahc::agent] agent took 127.6µs to start up
[2023-02-18T17:12:27Z INFO  tracing::span] socket reader;
[2023-02-18T17:12:27Z INFO  zbus::connection] {}; obj_server_task_name="ObjectServer task"
[2023-02-18T17:12:27Z DEBUG spot] activate
[2023-02-18T17:12:27Z DEBUG spot::app::models::songs::song_list_model] pos 0, removed 0, added 50
[2023-02-18T17:12:45Z DEBUG spot::app::components::window] saving geometry

I updated one of the dependencies related to credentials management and added some extra logs along with that, its on the development branch if you want to give it a try! (sorry to have you build dozens of different versions...)

It still doesn't work, but now I get this error log:
(process:16790): Adwaita-CRITICAL **: 19:01:04.279: adw_leaflet_set_visible_child: assertion 'contains_child' failed
[2023-02-21T18:01:04Z DEBUG isahc::agent] agent_thread; id=0
[2023-02-21T18:01:04Z DEBUG isahc::agent] agent took 155.213µs to start up
[2023-02-21T18:01:04Z INFO  tracing::span] socket reader;
[2023-02-21T18:01:04Z INFO  zbus::connection] {}; obj_server_task_name="ObjectServer task"
[2023-02-21T18:01:04Z DEBUG spot] activate
[2023-02-21T18:01:04Z INFO  tracing::span] socket reader;
[2023-02-21T18:01:04Z WARN  spot::app::components::login::login_model] Could not retrieve credentials: no secret service provider or dbus session found
[2023-02-21T18:01:04Z DEBUG spot::app::models::songs::song_list_model] pos 0, removed 0, added 50

It seems it can't find the secret service or the DBUS session, even though my DBUS_SESSION_BUS_ADDRESS env var is set, and the secret service is indeed available and accessible by other programs.

Thanks! I do have pretty much the same output.
So DBUS messages are being sent... but something happens on the way back?
Out of curiosity, are the MPRIS features working properly for you?

Yes, MPRIS works fine.

@xou816 I found the cause of the bug!
Turns out, that the JSON deserialization fails if the password contains (what would look like) invalid escape characters. In my case, my randomly generated Spotify password contains the substring \&, which causes this error message:
[src/app/credentials.rs:38] serde_json::from_slice(&item) = Err(
    Error("invalid escape", line: 1, column: 114),
)
[src/app/components/login/login_model.rs:21] Credentials::retrieve().await = Err(
    Unavailable,
)

which I got by adding some dbg!()s. Due to .map_err(|_| Error::Unavailable) in src/app/credentials.rs:38, it incorrectly reports it as an error due to the secret service being unavailable.
Here are the added dbg!()s:
diff --git a/src/app/components/login/login_model.rs b/src/app/components/login/login_model.rs
index 033468f..897ba4d 100644
--- a/src/app/components/login/login_model.rs
+++ b/src/app/components/login/login_model.rs
@@ -18,7 +18,7 @@ impl LoginModel {

     pub fn try_autologin(&self) {
         self.dispatcher.dispatch_async(Box::pin(async {
-            let action = match Credentials::retrieve().await {
+            let action = match dbg!(Credentials::retrieve().await) {
                 Ok(creds) => LoginAction::TryLogin(if creds.token_expired() {
                     TryLoginAction::Password {
                         username: creds.username,
diff --git a/src/app/credentials.rs b/src/app/credentials.rs
index 50867f8..560c313 100644
--- a/src/app/credentials.rs
+++ b/src/app/credentials.rs
@@ -35,7 +35,7 @@ impl Credentials {
         }
         let items = collection.search_items(make_attributes()).await?;
         let item = items.get(0).ok_or(Error::NoResult)?.get_secret().await?;
-        serde_json::from_slice(&item).map_err(|_| Error::Unavailable)
+        dbg!(serde_json::from_slice(&item)).map_err(|_| Error::Unavailable)
     }

     pub async fn logout() -> Result<(), Error> {

I'll try to come up with a way to handle backslashes in the password.

oh wow nice find!! I had not thought it could be an issue with deserialization -- and whatever login and error management I have in place certainly didnt help... thanks a lot, I'll have a look at the PR!

Wait so I'm curious where the issues lies exactly -- I've changed my password so that it starts with "\5..." (I assumed the issue is with the backslash and double quotes too, probably, I don't think \& is anything special, or is it?)
It's properly escaped by serde and ends up stored as {"username":"xou816","password":"\\5..."}
And then properly deserializes it too.
If I apply the additional escaping logic I get a login failure :/
Could you confirm that you don't have the issue with flatpak? That was weird. I'm wondering if it's possible that the issue lies somewhere else (a faulty version of dbus that would mess with escaping?)

Well, mine ends up stored as {"username":"...","password":"...\&..."}, which is why it fails to deserialize. I can check the Flatpak version tomorrow on Fedora, but I was using it two days ago and it didn't have the issue. Though I can see that the DBUS version is the same on both my systems (1.14.6-1).

I don't think \& is anything special, or is it?

Exactly, it isn't, which is why serde fails to deserialize it. Why it doesn't escape the backslash when serializing tho, I can't say.

Great, thanks, I appreciate it if we can run a couple more tests with your setup first! :)

@xou816 still no issues with the Flatpak version (0.3.1), but I noticed that my password is stored as ...\\&... in my keyring on Fedora.

It's worth a try yes! If you don't mind!

@xou816 I just upgraded the Flatpak version to 0.4.0, it correctly escapes and stores the password as {"username":"...","password":"...\\&..."}. I don't know why it fails on Artix.
I haven't yet tried to downgrade to 0.3.1 on Artix, but I tried only downgrading the serde_json dependency to the version used in 0.3.1.

sounds like it's definitely not serde if both 0.3 and 0.4 are okay. I suspect a dbus related dependency on your Artix install but I have no clue which it could be :/

I think we should close it for now yes :/ thanks for taking the time to investigate this and even suggest a fix!!

@xou816 no problem :)
After investigating some more, I noticed that it works fine on my other Artix system. The difference between them turns out to be that the faulty one uses an unencrypted secret service keyring (without password), and the working one uses an encrypted one. When unencrypted, the keyring is stored as a plaintext file, as opposed to an encrypted one which is in binary format.
I tested both encrypted and unencrypted keyrings with secret-tool storing passwords like \n\t\&\\..., and as I suspected, escape characters are interpreted before they're stored ONLY IF the keyring is UNENCRYPTED. If it's encrypted, it stores secrets AS IS, \n like \n, not like an actual line break making the keyring file invalid. I should probably file a bug report with gnome-keyring.


[QUESTION] Failed to allocate heap

Hello, I try to build the so file. This works. But when I try to execute it, it says the following error

2020-11-15 16:33:58 ERROR   aivHeapInit(): Failed to allocate heap with limit size<PHONE_NUMBER>
2020-11-15 16:33:58 ERROR   heapInitialize(): Failed to initialize native heap.
2020-11-15 16:33:58 ERROR   createKinesisVideoClient(): operation returned status code: 0x00000004
2020-11-15 16:33:58 ERROR   semaphoreSetLockInternal(): operation returned status code: 0x00000001
2020-11-15 16:33:58 ERROR   semaphoreWaitUntilClearInternal(): operation returned status code: 0x00000001
Exception in thread "main" java.lang.RuntimeException: com.amazonaws.kinesisvideo.producer.ProducerException: Failed to create Kinesis Video client. StatusCode: 0x4
        at com.amazonaws.kinesisvideo.demoapp.DemoAppMain.main(DemoAppMain.java:59)

Do you have a hint why this happened?
Best regards
Julia

@Julchenwsf you are attaching logs for a Java asset to the CPP repository.
As you can see from the logs it failed to allocate the necessary heap with<PHONE_NUMBER> bytes in size
2020-11-15 16:33:58 ERROR   aivHeapInit(): Failed to allocate heap with limit size<PHONE_NUMBER>
I am guessing you are using the Java demo application. You will need to overwrite the default value of the heap size
https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-java/blob/3fc9f3c70e1d8016598d9c4536d19e36cb72499c/src/main/java/com/amazonaws/kinesisvideo/java/client/KinesisVideoJavaClientFactory.java#L34
which is by mistake is named as 64 MB but actually defaults to 1GB.
Or, alternatively, use the other overloaded method in https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-java/blob/master/src/main/demo/com/amazonaws/kinesisvideo/demoapp/DemoAppMain.java#L42
to specify your own version of DeviceInfo with the right size of heap.
Please resolve this issue if you have no further questions regarding this case.
If you have further questions, please cut them in the Java SDK repository.

Thanks. This solved the problem.


update protobuf lib to v4 and re generate definitions.

Looks like v4 still not ready for prime time (protoc is now supported but not grpcio-tools).
ERROR: Cannot install faucetconfrpc and faucetconfrpc==0.22.39.dev0 because these package versions have conflicting dependencies.
The conflict is caused by:
faucetconfrpc 0.22.39.dev0 depends on protobuf==4.21.1
grpcio-tools 1.47.0 depends on protobuf<4.0dev and >=3.12.0

proto is happy, but pytype is not. working on that.


rolling out<EMAIL_ADDRESS>

Description

Current state: errors during new link checker and linter tests
This PR is part of the DevSite team's effort to roll out a major release<EMAIL_ADDRESS>across all the AdobeDocs repos.
Release Notes - Feature Highlights:

Search Enhancements
Link Checker
Local Linter enhancements
Easing of dependabot PR notifications
Mobile Nav improvements
Github Issues template enhancement

Additionally in this PR:

Reindexed all content for search

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@bohnertchris There are some errors brought up by the new link checker and linter during build. Are you able to review and fix those?

Hello @dmitrymatio
I am not sure what you mean by the linter. In the latest checks I can't find any references to problems with it.
With regard to the the checks marked Latest Pull Request / validate (pull_request), as far as I can tell there are no errors being thrown by the link checker, only warnings.
https://github.com/AdobeDocs/cloudmanager-api-docs/actions/runs/4757414189/jobs/8454204187?pr=239
With regard to the checks marked CI Build / build (pull_request), there is little data, but it looks like GitHub thinks you are somehow using an old .github/workflows/ci.yml file that has ubuntu-18.04 whereas the current version of the file uses ubuntu-latest.
https://github.com/AdobeDocs/cloudmanager-api-docs/actions/runs/4757414187/jobs/8454204213?pr=239
I hope this is helpful. I am not familiar with the inner workings of this tool and am rather just a user.

@bohnertchris I've updated the CI file and the test is passing now.
Regarding the warnings in the Latest Pull Request workflow: the warnings are non blocking but they indicate links that don't resolve due to missing files or wrong paths. This is a new test workflow we introduced to assist with fixing 404s across the site. If possible please check if they can be fixed asap.
on a separate note, I'm struggling to index the src/pages/reference/api.md file due to some permission denial when the redoc-cli commands are invoked. Would you happen to know what could've caused it? due to the non standard nature of this repo I'm struggling to figure out what would do it as this doesn't happen in our templated repos even the really custom ones 😅 my current workaround is to comment out the openAPISpec during indexing but that means there won't be any results for the actual content of the commented file.
Aside from that I think we're good to merge this PR

It is interesting to know that the PR recognizes warnings as an error/failure. However I am also not sure why any of these warnings are generated.
src/pages/guides/api-usage/index.md lists six pages as not existing. However the published page has no broken links. https://developer.adobe.com/experience-cloud/cloud-manager/guides/
src/pages/guides/getting-started/index.md also lists six pages as not existing. However the published page has no broken links. https://developer.adobe.com/experience-cloud/cloud-manager/guides/
src/pages/guides/getting-started/understanding-the-api.md lists two pages as not existing. However the publisher page has no broken links. https://developer.adobe.com/experience-cloud/cloud-manager/guides/getting-started/understanding-the-api
src/pages/index.md lists seven unknown pages but the published page has no broken links. https://developer.adobe.com/experience-cloud/cloud-manager/
src/pages/reference/index.md lists two unknown pages but the published page has no broken links. https://developer.adobe.com/experience-cloud/cloud-manager/reference/
I am sorry, but with regard to your question about the "permission denial when the redoc-cli commands are invoked," as I mentioned previously, I am not the owner of this repo, nor the maintainer. I only use it to publish API documentation and I have no insight into how it is set up or how it works. I regret that I have no insight to offer here.

@bohnertchris Based on your comment, I realized the issue with the links is the formatting.
Although they resolved in the application, the links didn't match the supported formats. See docs here: https://github.com/adobe/aio-theme#internal-links .
I applied reformats and have resolved the link checker complaints however I noticed that some of those links were imported on pages where the relative link format would break. The solution was to use absolute formats for those. Could you help me confirm that those links work on stage https://developer-stage.adobe.com/experience-cloud/cloud-manager/ .
Regarding the permission denial errors, could you tag whoever is more familiar with the setup of this repo? From my conversation with the ADP team this was a custom effort from the experience cloud team we just don't remember who handled this setup.
If all is well on stage please go ahead and merge this PR in. Thank you.

Thank you for looking into the link warnings, @dmitrymatio. It mostly looks good on the staging instance, but the links on this page https://developer-stage.adobe.com/experience-cloud/cloud-manager/guides/ under the API Usage heading do not work. They resolve, but the pages are empty of content. Not sure if this is a problem with the staging instance or an actual issue.
I wish I could provide you with more information on this repository. But once again, I was introduced to this repository as a user in order to author content and publish it. I do not know who set it up or who is more knowledgeable of its inner working. Justin Edelson introduced me to this platform some time ago.

@bohnertchris could you take another look at https://developer-stage.adobe.com/experience-cloud/cloud-manager/guides/ should be fixed now

Yes, @dmitrymatio, the links are working as expected now. However it looks like the checks have now flagged another linting error.

@bohnertchris Glad to hear that. Sounds like we're good to merge and deploy then. The linting errors are rather simple and to do with content. They're non blocking but if you'd like to match the expected formatting of the linter it will make things more consistent. It wasn't able to run before because the link checker would error and stop the tests before the linter (so it's not new issues). Can I leave it up to you to fix the linting errors or not (optional)? I would like to complete the upgrade asap 😅

Changes are complete, @dmitrymatio. Should I merge or does this need to be coordinated somehow with other changes that you are making with regard to the upgrade?


Add adjust_batch or (re_batch) support for tf.data

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template
System information

TensorFlow version (you are using): N/A
Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.
At the moment tf.data has both unbatch() and batch(n) support, where you can either change the output of tf.data from any-batched ones to non-batched ones, or from non-batched ones to n-batched ones.
What is not available is the transformation from m-batched ones to n-batched ones directly.
Indirectly it is possible to achieve the above mentioned m-batched => n-batched through:
dataset = dataset.unbatch().batch(n)

However, in case each record is small in size (e.g., one record only have one float32) then .unbatch().batch(n) could be costly.
It would be great to have a way to shortcut with an adjust_batch or re_batch that achieve the same thing:
dataset = dataset.re_batch(n) # from m-batched to n-batched

Note there is already a RebatchDataset (which archives different goal) so not sure if re_batch(n) could be a good naming.
Will this change the current api? How?
No.
Who will benefit with this feature?
See description above.
Any Other info.

/cc @jsimsa @mrry  I am wondering if the above feature request makes sense? I could create a PR if it makes sense.

Hi @yongtang, do you have evidence that suggests that a fused implementation of unbatch().batch() would be more efficient than the existing one (based on two separate transformations)?
If so, I would be open to implementing this fused kernel and introducing it as a static optimization. In other words, users still write unbatch().batch() and tf.data would automatically rewrite this to fused implementation (similar to how map().batch() is automatically rewritten to the fused one).

Thanks @jsimsa! Static optimization makes much more sense than introducing another op of rebatch. Let me take a look and see if I can create a PR with it.

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.


BufferLayout encoding does not support arrays

While encoding instruction data, I need to use seeds as an argument which is a uint8Array.  It seems like that is not an option offered by the Layout:
`
 const dataLayout = BufferLayout.struct<any>([
     BufferLayout.u8('instruction'),
     BufferLayout.nu64('seeds'), // I don't think this is right; should be [u8; 32] but can't find that
     BufferLayout.u32('number_of_schedules')
   ]);
   const data = Buffer.alloc(dataLayout.span);
   dataLayout.encode(
     {
       instruction: 0, // 0 for create instruction,
       seeds: Uint8Array.of(bump),
       number_of_schedules: new BN(5),
     },
     data
   );

`
It would be great if there was an option to do this.

https://github.com/pabigot/buffer-layout isn't part of this repo.


Vocal separator only outputs into wav or flac.

Only wav or flac output is working, if i select mp3 then it will be a garbled mess of fast clicking and noise.

Would you mind upload your audio so that I can try to check if there are bugs in the codes?

One is from wav to mp3, another is from mp3 to mp3. This happens with all 3 HP models. The files haven't been renamed.
glitched audio.zip

I will fix this issue in the next version.
The export of mp3/m4a/ogg will be by ffmpeg.


cargo-check doesn't wait for children on SIGTERM

This is a possible duplicate of #2343 and #2525. To reproduce issue cargo check in project with several dependencies, with target directory initially removed. As cargo compiles dependencies send SIGTERM to the cargo-check process. On my machine this causes the process to exit to shell with the message [1]    6350 terminated  cargo check, but the messages from dependencies compilation appear, conflicting with the shell prompt. This issue is a plausible cause of the bug neomake/neomake#1216, which results in zombie processes and blocked repository. As I understand it this should not happen, and the parent process should wait for the children to finish, possibly signaling them to abort their work, but correct me if I'm wrong, as I don't know much about cargo's internals.

Thanks for the report! This is, however, intentional. Editors and IDEs that want to kill all of the processes that Cargo spawns should use setsid to place Cargo into its own process group, and then kill the process group (that's the typical way to do this on Unix).
Let me know though if you need assistance with that!


fix: race conditions in tests

Fix the race conditions in test and simplify the use of newServer.

Seems like there's still something funky going on with server teardown, needs more investigation.


explicitly set sideEffect for css and scss files, fixes #3504

make it possible to import css or scss using ES6 import 'file.css'

fixes #3504
Changes
"sideEffects": false, to "sideEffects": ["*.css", "*.scss"],

Checklist

[ ] Added markup tests, or they don't apply here because...
[ ] Updated the changelog at CHANGES.md

@dirkjf Thanks!


#28 - NodeId

#28 - function that Generates NodeId based on SHA1 of public key & cmd command id to print nodeid

@kirill-h5i  @g4s8, thanks for review, please check changes


CI: install sbt

We can no longer rely on sbt being pre-installed in CI envs.
https://eed3si9n.com/setup-sbt/
see broken jobs in https://github.com/apache/pekko-http/pull/618/checks
ubuntu-latest is now ubuntu-24 and as documented in the eed3si9n.com article, that does not have sbt pre-installed
we use a lot of different versions of ubuntu in our builds - change to use ubuntu 22 as a min

sbt should be still available in 22.04 ubuntu images though: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#project-management

Also:
bt/setup-sbt@v1 is not allowed to be used in apache/pekko-http. Actions in this workflow must be: within a repository that belongs to your Enterprise account, created by GitHub, verified in the GitHub Marketplace, or matching the following: */*@[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]+, AdoptOpenJDK/install-jdk@*, JamesIves/github-pages-deploy-action@5dc1d5a192aeb5ab5b7d5a77b7d36aea4a7f5c92, TobKed/label-when-approved-action@*, actions-cool/issues-helper@*, actions-rs/*, al-cheb/configure-pagefile-action@*, amannn/action-semantic-pull-request@*, apache/*, burrunan/gradle-cache-action@*, bytedeco/javacpp-presets/.github/actions/*, chromaui/action@*, codecov/codecov-action@*, conda-incubator/setup-miniconda@*, container-tools/kind-action@*, container-tools/microshift-action@*, dawidd6/action-download-artifact@*, delaguardo/setup-graalvm@*, docker://jekyll/jekyll:*, docker://pandoc/core:2.9, eps1lon/actions-label-merge-conflict@*, gaurav-nelson/github-action-markdown-l...

@samueleresca ASF Infra team approves CI actions on a case by case basis. I will raise a JIRA with them.

ASF Infra have approved the sbt/setup-sbt action


make all sounds have blocks

There are a lot of sounds (see RobotControlViewController) that don't have blocks--> add them!

add them in plist and also in RobotControlViewController

All that remains is to add images to the vehicle noises


Update language support

@Jann-Skotdal : Thanks for your contribution! The author, @v-pawal, has been notified to review your proposed change.

#sign-off

@erhopf: I'm sorry - only the author of this article, @v-pawal, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#sign-off


Spotify won't install

Whenever I try to install with the command this error shows up:

and then it opens the documents folder.
Do you have any idea on how to solve this?
Thanks

Thanks for the feedback, I tried to fix this error.


Progress Indicator (react) : incorrect tooltip padding

This will be Post v10:

[ ] The tooltip currently has 16px padding on all sides. It needs to be pulling what exists for Definition tooltip.

Changes:

[ ] The text for all step labels should be color text-01. Two of these are currently text-02.

[ ] The focus should not be a box anymore. It should be following what Link and Breadcrumb components have which is a 3px link-01.

[ ] Sometimes the active state of the label still has blue text. It should be calling text-01.

note: solution to first issue here involves setting default component usage of <TooltipDefinition> for the tooltip


Add documentation on taking care when setting renewBefore to be close to duration

Signed-off-by: Michael Tsang<EMAIL_ADDRESS>
What this PR does / why we need it:
Some issuers set the notBefore field of their issued X.509 certificates to be before the time of issuance to handle clock-skew issues, for example Let's Encrypt sets it to be one hour before.
In the case of LE, this means that the working duration is actually 89d23h, while the full duration (notAfter - notBefore) remains 90d.
This can cause issues if the renewBefore field of Certificate resources is set to be very close to the full duration, e.g. 89d23h50m, since it will always be in the renewal period and so the controllers will always try to renew it.
I have added a test to demonstrate what happens in this case, and added documentation describing what is happening and to take care when setting renewBefore.
I think this is more appropriate than adding a validation check to prohibit users from setting renewBefore to be too close to the duration, since this could be overly restrictive in cases where the clock-skew handling of issuers is not as conservative as LE's (e.g. Vault only sets it to be 30s before).
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1506
Release note:

NONE

/lgtm
/approve

/cherrypick release-0.8


Update demo app to support latest version

Describe your changes

adjust setting up account instances by adding chainId and cairoVersion in StarknetAccount constructor
update execute to executeV3 while transferring tokens

Linked issues

Closes #176
Breaking changes

[x] This issue contains breaking changes

Accounts' initial balances are equal to 0

Let's not mark this PR as containing breaking changes, as we only change the demo and not the SDK itself


Add all Schema.org Vocabs

Schema.org has a few extended vocabularies such as biblio and auto. Add their namespaces for use in the tool.

Added schema.org, FOAF, DC, Schema.org Bib Ext and Creative Commons vocabularies


#436

I think you are making pushAsset calls here that are redundant because apostrophe-pieces also has them. If you are subclassing a module, and it pushes "foo" as a stylesheet or script, then that file gets pushed for every class in the inheritance tree, in order, so that styles override and scripts can rely upon each other. Has always been this way in A2.

The chooser needs to export decorateManager as self.decorateManager, and
pass it to the manager as such. Otherwise, when subclassing the chooser, it
is not possible to change the way the manager is decorated without
overriding all of launchBrowser and starting from scratch with a new
decorateManager.
If it is self.decorateManager, then you can use the super pattern to neatly
extend what is done to the manager.
On Wed, Feb 24, 2016 at 9:57 AM, Matthew Coppola<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/punkave/apostrophe/pull/445
Commit Summary

added apostrophe-pieces managerBase.html for easy subclassing of
manager.html in apostrophe-images
apostrophe-images manager modal started
edit images working in slideable now, modified attachment populate
method, restyled image gallery view a bit per stu's designs but some more
tweaks to come
merged unstable
fixed bug preventing new schema rendering with [data-apos-form]
selector
Refactor chooserModal from subclass to having the chooser decorate a
manager modal
apostrophe-images manageGridPage template: reordered checkbox/label
stacking order
Merge branch '#436' of https://github.com/punkave/apostrophe into
#436
apostrophe-images: added styles to hide choices panel for chooser
view. clicking element in grid view also checks the checkbox
cleaned up some manager-modal js for selection, working now in the
chooser
position relateive on .apos-areas so the controls appear in the
right place
clean up
fixed bug causing wrong options to be send to /render-widget from
singleton helper, everything blessed
implemented slideshow pager arrows for images-widget. added
subclassing pattern to slideshow widget template for easy overriding access
seperated apostrophe-images manager.less into multiple files
removed logging
setTimeout with no time, restored to setImmediate

File Changes

M lib/modules/apostrophe-areas/lib/helpers.js
https://github.com/punkave/apostrophe/pull/445/files#diff-0 (4)
M lib/modules/apostrophe-areas/public/css/components/structure.less
https://github.com/punkave/apostrophe/pull/445/files#diff-1 (2)
M lib/modules/apostrophe-assets/public/js/vendor/moog.js
https://github.com/punkave/apostrophe/pull/445/files#diff-2 (2)
M lib/modules/apostrophe-attachments/lib/api.js
https://github.com/punkave/apostrophe/pull/445/files#diff-3 (2)
M lib/modules/apostrophe-attachments/public/js/user.js
https://github.com/punkave/apostrophe/pull/445/files#diff-4 (11)
M lib/modules/apostrophe-attachments/views/attachment.html
https://github.com/punkave/apostrophe/pull/445/files#diff-5 (9)
M lib/modules/apostrophe-docs/public/js/chooser.js
https://github.com/punkave/apostrophe/pull/445/files#diff-6 (86)
M lib/modules/apostrophe-docs/public/js/relationship-editor.js
https://github.com/punkave/apostrophe/pull/445/files#diff-7 (2)
M lib/modules/apostrophe-images-widgets/index.js
https://github.com/punkave/apostrophe/pull/445/files#diff-8 (1)
A lib/modules/apostrophe-images-widgets/public/css/arrows.less
https://github.com/punkave/apostrophe/pull/445/files#diff-9 (41)
M lib/modules/apostrophe-images-widgets/views/widget.html
https://github.com/punkave/apostrophe/pull/445/files#diff-10 (27)
A lib/modules/apostrophe-images-widgets/views/widgetBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-11 (36)
M lib/modules/apostrophe-images/index.js
https://github.com/punkave/apostrophe/pull/445/files#diff-12 (6)
A lib/modules/apostrophe-images/public/css/editor.less
https://github.com/punkave/apostrophe/pull/445/files#diff-13 (41)
A lib/modules/apostrophe-images/public/css/grid-item.less
https://github.com/punkave/apostrophe/pull/445/files#diff-14 (142)
A lib/modules/apostrophe-images/public/css/grid-view.less
https://github.com/punkave/apostrophe/pull/445/files#diff-15 (26)
A lib/modules/apostrophe-images/public/css/manage.less
https://github.com/punkave/apostrophe/pull/445/files#diff-16 (29)
A lib/modules/apostrophe-images/public/js/editor-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-17 (4)
A lib/modules/apostrophe-images/public/js/manager-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-18 (47)
M lib/modules/apostrophe-images/public/js/user.js
https://github.com/punkave/apostrophe/pull/445/files#diff-19 (1)
A lib/modules/apostrophe-images/views/editor.html
https://github.com/punkave/apostrophe/pull/445/files#diff-20 (19)
A lib/modules/apostrophe-images/views/manage.html
https://github.com/punkave/apostrophe/pull/445/files#diff-21 (7)
M lib/modules/apostrophe-images/views/manageGridPage.html
https://github.com/punkave/apostrophe/pull/445/files#diff-22 (19)
M lib/modules/apostrophe-images/views/manageGridView.html
https://github.com/punkave/apostrophe/pull/445/files#diff-23 (4)
M lib/modules/apostrophe-modal/public/css/components/modal.less
https://github.com/punkave/apostrophe/pull/445/files#diff-24 (4)
M lib/modules/apostrophe-modal/public/js/modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-25 (16)
M lib/modules/apostrophe-pieces/lib/routes.js
https://github.com/punkave/apostrophe/pull/445/files#diff-26 (2)
M lib/modules/apostrophe-pieces/public/css/manager.less
https://github.com/punkave/apostrophe/pull/445/files#diff-27 (67)
D lib/modules/apostrophe-pieces/public/js/chooser-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-28 (85)
M lib/modules/apostrophe-pieces/public/js/manager-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-29 (9)
D lib/modules/apostrophe-pieces/views/chooser.html
https://github.com/punkave/apostrophe/pull/445/files#diff-30 (1)
A lib/modules/apostrophe-pieces/views/chooserModal.html
https://github.com/punkave/apostrophe/pull/445/files#diff-31 (1)
R lib/modules/apostrophe-pieces/views/chooserModalBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-32 (0)
M lib/modules/apostrophe-pieces/views/editor.html
https://github.com/punkave/apostrophe/pull/445/files#diff-33 (32)
A lib/modules/apostrophe-pieces/views/editorBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-34 (34)
M lib/modules/apostrophe-pieces/views/manage.html
https://github.com/punkave/apostrophe/pull/445/files#diff-35 (37)
A lib/modules/apostrophe-pieces/views/manageBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-36 (36)
M lib/modules/apostrophe-ui/public/css/components/buttons.less
https://github.com/punkave/apostrophe/pull/445/files#diff-37 (8)
M lib/modules/apostrophe-ui/public/css/mixins/utils.less
https://github.com/punkave/apostrophe/pull/445/files#diff-38 (16)
M lib/modules/apostrophe-ui/views/components/buttons.html
https://github.com/punkave/apostrophe/pull/445/files#diff-39 (8)
M lib/modules/apostrophe-utils/lib/helpers.js
https://github.com/punkave/apostrophe/pull/445/files#diff-40 (9)

Patch Links:

https://github.com/punkave/apostrophe/pull/445.patch
https://github.com/punkave/apostrophe/pull/445.diff

—
Reply to this email directly or view it on GitHub
https://github.com/punkave/apostrophe/pull/445.

--
*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

You changed data-apos-form back to data-form in relationship-editor.js...?
On Wed, Feb 24, 2016 at 10:33 AM, Tom Boutell<EMAIL_ADDRESS>wrote:

The chooser needs to export decorateManager as self.decorateManager, and
pass it to the manager as such. Otherwise, when subclassing the chooser, it
is not possible to change the way the manager is decorated without
overriding all of launchBrowser and starting from scratch with a new
decorateManager.
If it is self.decorateManager, then you can use the super pattern to
neatly extend what is done to the manager.
On Wed, Feb 24, 2016 at 9:57 AM, Matthew Coppola<EMAIL_ADDRESS>
wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/punkave/apostrophe/pull/445
Commit Summary

added apostrophe-pieces managerBase.html for easy subclassing of
manager.html in apostrophe-images
apostrophe-images manager modal started
edit images working in slideable now, modified attachment populate
method, restyled image gallery view a bit per stu's designs but some more
tweaks to come
merged unstable
fixed bug preventing new schema rendering with [data-apos-form]
selector
Refactor chooserModal from subclass to having the chooser decorate
a manager modal
apostrophe-images manageGridPage template: reordered checkbox/label
stacking order
Merge branch '#436' of https://github.com/punkave/apostrophe into
#436
apostrophe-images: added styles to hide choices panel for chooser
view. clicking element in grid view also checks the checkbox
cleaned up some manager-modal js for selection, working now in the
chooser
position relateive on .apos-areas so the controls appear in the
right place
clean up
fixed bug causing wrong options to be send to /render-widget from
singleton helper, everything blessed
implemented slideshow pager arrows for images-widget. added
subclassing pattern to slideshow widget template for easy overriding access
seperated apostrophe-images manager.less into multiple files
removed logging
setTimeout with no time, restored to setImmediate

File Changes

M lib/modules/apostrophe-areas/lib/helpers.js
https://github.com/punkave/apostrophe/pull/445/files#diff-0 (4)
M
lib/modules/apostrophe-areas/public/css/components/structure.less
https://github.com/punkave/apostrophe/pull/445/files#diff-1 (2)
M lib/modules/apostrophe-assets/public/js/vendor/moog.js
https://github.com/punkave/apostrophe/pull/445/files#diff-2 (2)
M lib/modules/apostrophe-attachments/lib/api.js
https://github.com/punkave/apostrophe/pull/445/files#diff-3 (2)
M lib/modules/apostrophe-attachments/public/js/user.js
https://github.com/punkave/apostrophe/pull/445/files#diff-4 (11)
M lib/modules/apostrophe-attachments/views/attachment.html
https://github.com/punkave/apostrophe/pull/445/files#diff-5 (9)
M lib/modules/apostrophe-docs/public/js/chooser.js
https://github.com/punkave/apostrophe/pull/445/files#diff-6 (86)
M lib/modules/apostrophe-docs/public/js/relationship-editor.js
https://github.com/punkave/apostrophe/pull/445/files#diff-7 (2)
M lib/modules/apostrophe-images-widgets/index.js
https://github.com/punkave/apostrophe/pull/445/files#diff-8 (1)
A lib/modules/apostrophe-images-widgets/public/css/arrows.less
https://github.com/punkave/apostrophe/pull/445/files#diff-9 (41)
M lib/modules/apostrophe-images-widgets/views/widget.html
https://github.com/punkave/apostrophe/pull/445/files#diff-10 (27)
A lib/modules/apostrophe-images-widgets/views/widgetBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-11 (36)
M lib/modules/apostrophe-images/index.js
https://github.com/punkave/apostrophe/pull/445/files#diff-12 (6)
A lib/modules/apostrophe-images/public/css/editor.less
https://github.com/punkave/apostrophe/pull/445/files#diff-13 (41)
A lib/modules/apostrophe-images/public/css/grid-item.less
https://github.com/punkave/apostrophe/pull/445/files#diff-14 (142)
A lib/modules/apostrophe-images/public/css/grid-view.less
https://github.com/punkave/apostrophe/pull/445/files#diff-15 (26)
A lib/modules/apostrophe-images/public/css/manage.less
https://github.com/punkave/apostrophe/pull/445/files#diff-16 (29)
A lib/modules/apostrophe-images/public/js/editor-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-17 (4)
A lib/modules/apostrophe-images/public/js/manager-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-18 (47)
M lib/modules/apostrophe-images/public/js/user.js
https://github.com/punkave/apostrophe/pull/445/files#diff-19 (1)
A lib/modules/apostrophe-images/views/editor.html
https://github.com/punkave/apostrophe/pull/445/files#diff-20 (19)
A lib/modules/apostrophe-images/views/manage.html
https://github.com/punkave/apostrophe/pull/445/files#diff-21 (7)
M lib/modules/apostrophe-images/views/manageGridPage.html
https://github.com/punkave/apostrophe/pull/445/files#diff-22 (19)
M lib/modules/apostrophe-images/views/manageGridView.html
https://github.com/punkave/apostrophe/pull/445/files#diff-23 (4)
M lib/modules/apostrophe-modal/public/css/components/modal.less
https://github.com/punkave/apostrophe/pull/445/files#diff-24 (4)
M lib/modules/apostrophe-modal/public/js/modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-25 (16)
M lib/modules/apostrophe-pieces/lib/routes.js
https://github.com/punkave/apostrophe/pull/445/files#diff-26 (2)
M lib/modules/apostrophe-pieces/public/css/manager.less
https://github.com/punkave/apostrophe/pull/445/files#diff-27 (67)
D lib/modules/apostrophe-pieces/public/js/chooser-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-28 (85)
M lib/modules/apostrophe-pieces/public/js/manager-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-29 (9)
D lib/modules/apostrophe-pieces/views/chooser.html
https://github.com/punkave/apostrophe/pull/445/files#diff-30 (1)
A lib/modules/apostrophe-pieces/views/chooserModal.html
https://github.com/punkave/apostrophe/pull/445/files#diff-31 (1)
R lib/modules/apostrophe-pieces/views/chooserModalBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-32 (0)
M lib/modules/apostrophe-pieces/views/editor.html
https://github.com/punkave/apostrophe/pull/445/files#diff-33 (32)
A lib/modules/apostrophe-pieces/views/editorBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-34 (34)
M lib/modules/apostrophe-pieces/views/manage.html
https://github.com/punkave/apostrophe/pull/445/files#diff-35 (37)
A lib/modules/apostrophe-pieces/views/manageBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-36 (36)
M lib/modules/apostrophe-ui/public/css/components/buttons.less
https://github.com/punkave/apostrophe/pull/445/files#diff-37 (8)
M lib/modules/apostrophe-ui/public/css/mixins/utils.less
https://github.com/punkave/apostrophe/pull/445/files#diff-38 (16)
M lib/modules/apostrophe-ui/views/components/buttons.html
https://github.com/punkave/apostrophe/pull/445/files#diff-39 (8)
M lib/modules/apostrophe-utils/lib/helpers.js
https://github.com/punkave/apostrophe/pull/445/files#diff-40 (9)

Patch Links:

https://github.com/punkave/apostrophe/pull/445.patch
https://github.com/punkave/apostrophe/pull/445.diff

—
Reply to this email directly or view it on GitHub
https://github.com/punkave/apostrophe/pull/445.

--
*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

--
*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

You are pushing "arrows" as a stylesheet. So far I believe the convention
has been to push one stylesheet per scene, e.g. "always", and use imports
there as you see fit.
On Wed, Feb 24, 2016 at 10:35 AM, Tom Boutell<EMAIL_ADDRESS>wrote:

You changed data-apos-form back to data-form in relationship-editor.js...?
On Wed, Feb 24, 2016 at 10:33 AM, Tom Boutell<EMAIL_ADDRESS>wrote:

The chooser needs to export decorateManager as self.decorateManager, and
pass it to the manager as such. Otherwise, when subclassing the chooser, it
is not possible to change the way the manager is decorated without
overriding all of launchBrowser and starting from scratch with a new
decorateManager.
If it is self.decorateManager, then you can use the super pattern to
neatly extend what is done to the manager.
On Wed, Feb 24, 2016 at 9:57 AM, Matthew Coppola <
<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/punkave/apostrophe/pull/445
Commit Summary

added apostrophe-pieces managerBase.html for easy subclassing of
manager.html in apostrophe-images
apostrophe-images manager modal started
edit images working in slideable now, modified attachment populate
method, restyled image gallery view a bit per stu's designs but some more
tweaks to come
merged unstable
fixed bug preventing new schema rendering with [data-apos-form]
selector
Refactor chooserModal from subclass to having the chooser decorate
a manager modal
apostrophe-images manageGridPage template: reordered
checkbox/label stacking order
Merge branch '#436' of https://github.com/punkave/apostrophe into
#436
apostrophe-images: added styles to hide choices panel for chooser
view. clicking element in grid view also checks the checkbox
cleaned up some manager-modal js for selection, working now in the
chooser
position relateive on .apos-areas so the controls appear in the
right place
clean up
fixed bug causing wrong options to be send to /render-widget from
singleton helper, everything blessed
implemented slideshow pager arrows for images-widget. added
subclassing pattern to slideshow widget template for easy overriding access
seperated apostrophe-images manager.less into multiple files
removed logging
setTimeout with no time, restored to setImmediate

File Changes

M lib/modules/apostrophe-areas/lib/helpers.js
https://github.com/punkave/apostrophe/pull/445/files#diff-0 (4)
M
lib/modules/apostrophe-areas/public/css/components/structure.less
https://github.com/punkave/apostrophe/pull/445/files#diff-1 (2)
M lib/modules/apostrophe-assets/public/js/vendor/moog.js
https://github.com/punkave/apostrophe/pull/445/files#diff-2 (2)
M lib/modules/apostrophe-attachments/lib/api.js
https://github.com/punkave/apostrophe/pull/445/files#diff-3 (2)
M lib/modules/apostrophe-attachments/public/js/user.js
https://github.com/punkave/apostrophe/pull/445/files#diff-4 (11)
M lib/modules/apostrophe-attachments/views/attachment.html
https://github.com/punkave/apostrophe/pull/445/files#diff-5 (9)
M lib/modules/apostrophe-docs/public/js/chooser.js
https://github.com/punkave/apostrophe/pull/445/files#diff-6 (86)
M lib/modules/apostrophe-docs/public/js/relationship-editor.js
https://github.com/punkave/apostrophe/pull/445/files#diff-7 (2)
M lib/modules/apostrophe-images-widgets/index.js
https://github.com/punkave/apostrophe/pull/445/files#diff-8 (1)
A lib/modules/apostrophe-images-widgets/public/css/arrows.less
https://github.com/punkave/apostrophe/pull/445/files#diff-9 (41)
M lib/modules/apostrophe-images-widgets/views/widget.html
https://github.com/punkave/apostrophe/pull/445/files#diff-10 (27)
A lib/modules/apostrophe-images-widgets/views/widgetBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-11 (36)
M lib/modules/apostrophe-images/index.js
https://github.com/punkave/apostrophe/pull/445/files#diff-12 (6)
A lib/modules/apostrophe-images/public/css/editor.less
https://github.com/punkave/apostrophe/pull/445/files#diff-13 (41)
A lib/modules/apostrophe-images/public/css/grid-item.less
https://github.com/punkave/apostrophe/pull/445/files#diff-14 (142)
A lib/modules/apostrophe-images/public/css/grid-view.less
https://github.com/punkave/apostrophe/pull/445/files#diff-15 (26)
A lib/modules/apostrophe-images/public/css/manage.less
https://github.com/punkave/apostrophe/pull/445/files#diff-16 (29)
A lib/modules/apostrophe-images/public/js/editor-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-17 (4)
A lib/modules/apostrophe-images/public/js/manager-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-18 (47)
M lib/modules/apostrophe-images/public/js/user.js
https://github.com/punkave/apostrophe/pull/445/files#diff-19 (1)
A lib/modules/apostrophe-images/views/editor.html
https://github.com/punkave/apostrophe/pull/445/files#diff-20 (19)
A lib/modules/apostrophe-images/views/manage.html
https://github.com/punkave/apostrophe/pull/445/files#diff-21 (7)
M lib/modules/apostrophe-images/views/manageGridPage.html
https://github.com/punkave/apostrophe/pull/445/files#diff-22 (19)
M lib/modules/apostrophe-images/views/manageGridView.html
https://github.com/punkave/apostrophe/pull/445/files#diff-23 (4)
M lib/modules/apostrophe-modal/public/css/components/modal.less
https://github.com/punkave/apostrophe/pull/445/files#diff-24 (4)
M lib/modules/apostrophe-modal/public/js/modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-25 (16)
M lib/modules/apostrophe-pieces/lib/routes.js
https://github.com/punkave/apostrophe/pull/445/files#diff-26 (2)
M lib/modules/apostrophe-pieces/public/css/manager.less
https://github.com/punkave/apostrophe/pull/445/files#diff-27 (67)
D lib/modules/apostrophe-pieces/public/js/chooser-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-28 (85)
M lib/modules/apostrophe-pieces/public/js/manager-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-29 (9)
D lib/modules/apostrophe-pieces/views/chooser.html
https://github.com/punkave/apostrophe/pull/445/files#diff-30 (1)
A lib/modules/apostrophe-pieces/views/chooserModal.html
https://github.com/punkave/apostrophe/pull/445/files#diff-31 (1)
R lib/modules/apostrophe-pieces/views/chooserModalBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-32 (0)
M lib/modules/apostrophe-pieces/views/editor.html
https://github.com/punkave/apostrophe/pull/445/files#diff-33 (32)
A lib/modules/apostrophe-pieces/views/editorBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-34 (34)
M lib/modules/apostrophe-pieces/views/manage.html
https://github.com/punkave/apostrophe/pull/445/files#diff-35 (37)
A lib/modules/apostrophe-pieces/views/manageBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-36 (36)
M lib/modules/apostrophe-ui/public/css/components/buttons.less
https://github.com/punkave/apostrophe/pull/445/files#diff-37 (8)
M lib/modules/apostrophe-ui/public/css/mixins/utils.less
https://github.com/punkave/apostrophe/pull/445/files#diff-38 (16)
M lib/modules/apostrophe-ui/views/components/buttons.html
https://github.com/punkave/apostrophe/pull/445/files#diff-39 (8)
M lib/modules/apostrophe-utils/lib/helpers.js
https://github.com/punkave/apostrophe/pull/445/files#diff-40 (9)

Patch Links:

https://github.com/punkave/apostrophe/pull/445.patch
https://github.com/punkave/apostrophe/pull/445.diff

—
Reply to this email directly or view it on GitHub
https://github.com/punkave/apostrophe/pull/445.

--
*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

--
*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

--
*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

Really nice refactoring re: use of Base templates with blocks.
On Wed, Feb 24, 2016 at 10:35 AM, Tom Boutell<EMAIL_ADDRESS>wrote:

You are pushing "arrows" as a stylesheet. So far I believe the convention
has been to push one stylesheet per scene, e.g. "always", and use imports
there as you see fit.
On Wed, Feb 24, 2016 at 10:35 AM, Tom Boutell<EMAIL_ADDRESS>wrote:

You changed data-apos-form back to data-form in relationship-editor.js...?
On Wed, Feb 24, 2016 at 10:33 AM, Tom Boutell<EMAIL_ADDRESS>wrote:

The chooser needs to export decorateManager as self.decorateManager, and
pass it to the manager as such. Otherwise, when subclassing the chooser, it
is not possible to change the way the manager is decorated without
overriding all of launchBrowser and starting from scratch with a new
decorateManager.
If it is self.decorateManager, then you can use the super pattern to
neatly extend what is done to the manager.
On Wed, Feb 24, 2016 at 9:57 AM, Matthew Coppola <
<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/punkave/apostrophe/pull/445
Commit Summary

added apostrophe-pieces managerBase.html for easy subclassing of
manager.html in apostrophe-images
apostrophe-images manager modal started
edit images working in slideable now, modified attachment
populate method, restyled image gallery view a bit per stu's designs but
some more tweaks to come
merged unstable
fixed bug preventing new schema rendering with [data-apos-form]
selector
Refactor chooserModal from subclass to having the chooser
decorate a manager modal
apostrophe-images manageGridPage template: reordered
checkbox/label stacking order
Merge branch '#436' of https://github.com/punkave/apostrophe into
#436
apostrophe-images: added styles to hide choices panel for chooser
view. clicking element in grid view also checks the checkbox
cleaned up some manager-modal js for selection, working now in
the chooser
position relateive on .apos-areas so the controls appear in the
right place
clean up
fixed bug causing wrong options to be send to /render-widget from
singleton helper, everything blessed
implemented slideshow pager arrows for images-widget. added
subclassing pattern to slideshow widget template for easy overriding access
seperated apostrophe-images manager.less into multiple files
removed logging
setTimeout with no time, restored to setImmediate

File Changes

M lib/modules/apostrophe-areas/lib/helpers.js
https://github.com/punkave/apostrophe/pull/445/files#diff-0 (4)
M
lib/modules/apostrophe-areas/public/css/components/structure.less
https://github.com/punkave/apostrophe/pull/445/files#diff-1 (2)
M lib/modules/apostrophe-assets/public/js/vendor/moog.js
https://github.com/punkave/apostrophe/pull/445/files#diff-2 (2)
M lib/modules/apostrophe-attachments/lib/api.js
https://github.com/punkave/apostrophe/pull/445/files#diff-3 (2)
M lib/modules/apostrophe-attachments/public/js/user.js
https://github.com/punkave/apostrophe/pull/445/files#diff-4 (11)
M lib/modules/apostrophe-attachments/views/attachment.html
https://github.com/punkave/apostrophe/pull/445/files#diff-5 (9)
M lib/modules/apostrophe-docs/public/js/chooser.js
https://github.com/punkave/apostrophe/pull/445/files#diff-6 (86)
M lib/modules/apostrophe-docs/public/js/relationship-editor.js
https://github.com/punkave/apostrophe/pull/445/files#diff-7 (2)
M lib/modules/apostrophe-images-widgets/index.js
https://github.com/punkave/apostrophe/pull/445/files#diff-8 (1)
A lib/modules/apostrophe-images-widgets/public/css/arrows.less
https://github.com/punkave/apostrophe/pull/445/files#diff-9 (41)
M lib/modules/apostrophe-images-widgets/views/widget.html
https://github.com/punkave/apostrophe/pull/445/files#diff-10 (27)
A lib/modules/apostrophe-images-widgets/views/widgetBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-11 (36)
M lib/modules/apostrophe-images/index.js
https://github.com/punkave/apostrophe/pull/445/files#diff-12 (6)
A lib/modules/apostrophe-images/public/css/editor.less
https://github.com/punkave/apostrophe/pull/445/files#diff-13 (41)
A lib/modules/apostrophe-images/public/css/grid-item.less
https://github.com/punkave/apostrophe/pull/445/files#diff-14
(142)
A lib/modules/apostrophe-images/public/css/grid-view.less
https://github.com/punkave/apostrophe/pull/445/files#diff-15 (26)
A lib/modules/apostrophe-images/public/css/manage.less
https://github.com/punkave/apostrophe/pull/445/files#diff-16 (29)
A lib/modules/apostrophe-images/public/js/editor-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-17 (4)
A lib/modules/apostrophe-images/public/js/manager-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-18 (47)
M lib/modules/apostrophe-images/public/js/user.js
https://github.com/punkave/apostrophe/pull/445/files#diff-19 (1)
A lib/modules/apostrophe-images/views/editor.html
https://github.com/punkave/apostrophe/pull/445/files#diff-20 (19)
A lib/modules/apostrophe-images/views/manage.html
https://github.com/punkave/apostrophe/pull/445/files#diff-21 (7)
M lib/modules/apostrophe-images/views/manageGridPage.html
https://github.com/punkave/apostrophe/pull/445/files#diff-22 (19)
M lib/modules/apostrophe-images/views/manageGridView.html
https://github.com/punkave/apostrophe/pull/445/files#diff-23 (4)
M lib/modules/apostrophe-modal/public/css/components/modal.less
https://github.com/punkave/apostrophe/pull/445/files#diff-24 (4)
M lib/modules/apostrophe-modal/public/js/modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-25 (16)
M lib/modules/apostrophe-pieces/lib/routes.js
https://github.com/punkave/apostrophe/pull/445/files#diff-26 (2)
M lib/modules/apostrophe-pieces/public/css/manager.less
https://github.com/punkave/apostrophe/pull/445/files#diff-27 (67)
D lib/modules/apostrophe-pieces/public/js/chooser-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-28 (85)
M lib/modules/apostrophe-pieces/public/js/manager-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-29 (9)
D lib/modules/apostrophe-pieces/views/chooser.html
https://github.com/punkave/apostrophe/pull/445/files#diff-30 (1)
A lib/modules/apostrophe-pieces/views/chooserModal.html
https://github.com/punkave/apostrophe/pull/445/files#diff-31 (1)
R lib/modules/apostrophe-pieces/views/chooserModalBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-32 (0)
M lib/modules/apostrophe-pieces/views/editor.html
https://github.com/punkave/apostrophe/pull/445/files#diff-33 (32)
A lib/modules/apostrophe-pieces/views/editorBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-34 (34)
M lib/modules/apostrophe-pieces/views/manage.html
https://github.com/punkave/apostrophe/pull/445/files#diff-35 (37)
A lib/modules/apostrophe-pieces/views/manageBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-36 (36)
M lib/modules/apostrophe-ui/public/css/components/buttons.less
https://github.com/punkave/apostrophe/pull/445/files#diff-37 (8)
M lib/modules/apostrophe-ui/public/css/mixins/utils.less
https://github.com/punkave/apostrophe/pull/445/files#diff-38 (16)
M lib/modules/apostrophe-ui/views/components/buttons.html
https://github.com/punkave/apostrophe/pull/445/files#diff-39 (8)
M lib/modules/apostrophe-utils/lib/helpers.js
https://github.com/punkave/apostrophe/pull/445/files#diff-40 (9)

Patch Links:

https://github.com/punkave/apostrophe/pull/445.patch
https://github.com/punkave/apostrophe/pull/445.diff

—
Reply to this email directly or view it on GitHub
https://github.com/punkave/apostrophe/pull/445.

--
*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

--
*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

--
*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

--
*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

filterOut should be called "reject" to match lodash, and it should use
_.reject
On Wed, Feb 24, 2016 at 10:36 AM, Tom Boutell<EMAIL_ADDRESS>wrote:

Really nice refactoring re: use of Base templates with blocks.
On Wed, Feb 24, 2016 at 10:35 AM, Tom Boutell<EMAIL_ADDRESS>wrote:

You are pushing "arrows" as a stylesheet. So far I believe the convention
has been to push one stylesheet per scene, e.g. "always", and use imports
there as you see fit.
On Wed, Feb 24, 2016 at 10:35 AM, Tom Boutell<EMAIL_ADDRESS>wrote:

You changed data-apos-form back to data-form in
relationship-editor.js...?
On Wed, Feb 24, 2016 at 10:33 AM, Tom Boutell<EMAIL_ADDRESS>wrote:

The chooser needs to export decorateManager as self.decorateManager,
and pass it to the manager as such. Otherwise, when subclassing the
chooser, it is not possible to change the way the manager is decorated
without overriding all of launchBrowser and starting from scratch with a
new decorateManager.
If it is self.decorateManager, then you can use the super pattern to
neatly extend what is done to the manager.
On Wed, Feb 24, 2016 at 9:57 AM, Matthew Coppola <
<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/punkave/apostrophe/pull/445
Commit Summary

added apostrophe-pieces managerBase.html for easy subclassing of
manager.html in apostrophe-images
apostrophe-images manager modal started
edit images working in slideable now, modified attachment
populate method, restyled image gallery view a bit per stu's designs but
some more tweaks to come
merged unstable
fixed bug preventing new schema rendering with [data-apos-form]
selector
Refactor chooserModal from subclass to having the chooser
decorate a manager modal
apostrophe-images manageGridPage template: reordered
checkbox/label stacking order
Merge branch '#436' of https://github.com/punkave/apostrophe
into #436
apostrophe-images: added styles to hide choices panel for
chooser view. clicking element in grid view also checks the checkbox
cleaned up some manager-modal js for selection, working now in
the chooser
position relateive on .apos-areas so the controls appear in the
right place
clean up
fixed bug causing wrong options to be send to /render-widget
from singleton helper, everything blessed
implemented slideshow pager arrows for images-widget. added
subclassing pattern to slideshow widget template for easy overriding access
seperated apostrophe-images manager.less into multiple files
removed logging
setTimeout with no time, restored to setImmediate

File Changes

M lib/modules/apostrophe-areas/lib/helpers.js
https://github.com/punkave/apostrophe/pull/445/files#diff-0 (4)
M
lib/modules/apostrophe-areas/public/css/components/structure.less
https://github.com/punkave/apostrophe/pull/445/files#diff-1 (2)
M lib/modules/apostrophe-assets/public/js/vendor/moog.js
https://github.com/punkave/apostrophe/pull/445/files#diff-2 (2)
M lib/modules/apostrophe-attachments/lib/api.js
https://github.com/punkave/apostrophe/pull/445/files#diff-3 (2)
M lib/modules/apostrophe-attachments/public/js/user.js
https://github.com/punkave/apostrophe/pull/445/files#diff-4 (11)
M lib/modules/apostrophe-attachments/views/attachment.html
https://github.com/punkave/apostrophe/pull/445/files#diff-5 (9)
M lib/modules/apostrophe-docs/public/js/chooser.js
https://github.com/punkave/apostrophe/pull/445/files#diff-6 (86)
M lib/modules/apostrophe-docs/public/js/relationship-editor.js
https://github.com/punkave/apostrophe/pull/445/files#diff-7 (2)
M lib/modules/apostrophe-images-widgets/index.js
https://github.com/punkave/apostrophe/pull/445/files#diff-8 (1)
A lib/modules/apostrophe-images-widgets/public/css/arrows.less
https://github.com/punkave/apostrophe/pull/445/files#diff-9 (41)
M lib/modules/apostrophe-images-widgets/views/widget.html
https://github.com/punkave/apostrophe/pull/445/files#diff-10
(27)
A lib/modules/apostrophe-images-widgets/views/widgetBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-11
(36)
M lib/modules/apostrophe-images/index.js
https://github.com/punkave/apostrophe/pull/445/files#diff-12 (6)
A lib/modules/apostrophe-images/public/css/editor.less
https://github.com/punkave/apostrophe/pull/445/files#diff-13
(41)
A lib/modules/apostrophe-images/public/css/grid-item.less
https://github.com/punkave/apostrophe/pull/445/files#diff-14
(142)
A lib/modules/apostrophe-images/public/css/grid-view.less
https://github.com/punkave/apostrophe/pull/445/files#diff-15
(26)
A lib/modules/apostrophe-images/public/css/manage.less
https://github.com/punkave/apostrophe/pull/445/files#diff-16
(29)
A lib/modules/apostrophe-images/public/js/editor-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-17 (4)
A lib/modules/apostrophe-images/public/js/manager-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-18
(47)
M lib/modules/apostrophe-images/public/js/user.js
https://github.com/punkave/apostrophe/pull/445/files#diff-19 (1)
A lib/modules/apostrophe-images/views/editor.html
https://github.com/punkave/apostrophe/pull/445/files#diff-20
(19)
A lib/modules/apostrophe-images/views/manage.html
https://github.com/punkave/apostrophe/pull/445/files#diff-21 (7)
M lib/modules/apostrophe-images/views/manageGridPage.html
https://github.com/punkave/apostrophe/pull/445/files#diff-22
(19)
M lib/modules/apostrophe-images/views/manageGridView.html
https://github.com/punkave/apostrophe/pull/445/files#diff-23 (4)
M lib/modules/apostrophe-modal/public/css/components/modal.less
https://github.com/punkave/apostrophe/pull/445/files#diff-24 (4)
M lib/modules/apostrophe-modal/public/js/modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-25
(16)
M lib/modules/apostrophe-pieces/lib/routes.js
https://github.com/punkave/apostrophe/pull/445/files#diff-26 (2)
M lib/modules/apostrophe-pieces/public/css/manager.less
https://github.com/punkave/apostrophe/pull/445/files#diff-27
(67)
D lib/modules/apostrophe-pieces/public/js/chooser-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-28
(85)
M lib/modules/apostrophe-pieces/public/js/manager-modal.js
https://github.com/punkave/apostrophe/pull/445/files#diff-29 (9)
D lib/modules/apostrophe-pieces/views/chooser.html
https://github.com/punkave/apostrophe/pull/445/files#diff-30 (1)
A lib/modules/apostrophe-pieces/views/chooserModal.html
https://github.com/punkave/apostrophe/pull/445/files#diff-31 (1)
R lib/modules/apostrophe-pieces/views/chooserModalBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-32 (0)
M lib/modules/apostrophe-pieces/views/editor.html
https://github.com/punkave/apostrophe/pull/445/files#diff-33
(32)
A lib/modules/apostrophe-pieces/views/editorBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-34
(34)
M lib/modules/apostrophe-pieces/views/manage.html
https://github.com/punkave/apostrophe/pull/445/files#diff-35
(37)
A lib/modules/apostrophe-pieces/views/manageBase.html
https://github.com/punkave/apostrophe/pull/445/files#diff-36
(36)
M lib/modules/apostrophe-ui/public/css/components/buttons.less
https://github.com/punkave/apostrophe/pull/445/files#diff-37 (8)
M lib/modules/apostrophe-ui/public/css/mixins/utils.less
https://github.com/punkave/apostrophe/pull/445/files#diff-38
(16)
M lib/modules/apostrophe-ui/views/components/buttons.html
https://github.com/punkave/apostrophe/pull/445/files#diff-39 (8)
M lib/modules/apostrophe-utils/lib/helpers.js
https://github.com/punkave/apostrophe/pull/445/files#diff-40 (9)

Patch Links:

https://github.com/punkave/apostrophe/pull/445.patch
https://github.com/punkave/apostrophe/pull/445.diff

—
Reply to this email directly or view it on GitHub
https://github.com/punkave/apostrophe/pull/445.

--
*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

--
*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

--
*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

--
*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

--
*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com

@boutell made the changes as suggested, thanks for looking over!


push_front and push_back should return dropped element

Hallo,
it would be very handy if the push_front() and it's corresponding push_back() method return the dropped element.
I have some logic which needs to clean up other stuff in the case an element gets dropped from a CircularBuffer:
let mut revisions = CircularBuffer::new()

...

if let Err(revision) = revisions.try_push_front(revision) {
    if let Some(oldest_revision) = revisions.pop_back() {
        self.store.remove(oldest_revision.hash());
    }
    revisions.try_push_front(revision)
        .expect("After removing the oldest revision, the buffer should now have space to push a new revision.")
}

A fn push_front(&mut self, item: T) -> Option<T> method would reduce the code above to:
if let Some(oldest_revision) = revisions.push_front(revision) {
    self.store.remove(oldest_revision.hash());
}

Hi, this feature was already contributed in #3. Because this is a backward-incompatible change, I could not release it in 0.1.x, so I'm holding it off until a future 0.2.x release. I plan to make such 0.2.x release within the next 2-3 months, so stay tuned!

Thank you! Sounds great. That in combination with #8 would be awesome!

Yes, that's coming too in the same release.
On Mon, Jan 29, 2024, 00:54 Elmar Schug @.***> wrote:

Thank you! Sounds great. That in combination with #8
https://github.com/andreacorbellini/rust-circular-buffer/pull/8 would
be awesome!
—
Reply to this email directly, view it on GitHub
https://github.com/andreacorbellini/rust-circular-buffer/issues/12#issuecomment-1914234062,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACOKLR4BHF75V4N5OI2JZ3YQ5PUVAVCNFSM6AAAAABCK2PHBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJUGIZTIMBWGI
.
You are receiving this because you commented.Message ID:
@.***>

@andreacorbellini any chance for a 0.2.0 release of this change?

Yeah, sorry about that. I'll try to get it out this weekend.
On Tue, Dec 10, 2024 at 8:02 AM Vincent Esche @.***>
wrote:

@andreacorbellini https://github.com/andreacorbellini any chance for a
0.2.0 release of this change?
—
Reply to this email directly, view it on GitHub
https://github.com/andreacorbellini/rust-circular-buffer/issues/12#issuecomment-2532151010,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACOKLSQDYCJFNLDHDS6XJD2E4GBRAVCNFSM6AAAAABTLQCRA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZSGE2TCMBRGA
.
You are receiving this because you were mentioned.Message ID:
@.***>


fix serializable bug in metrics exporter

Bug from v0.3b release for metrics exporter.
Addresses https://github.com/microsoft/opentelemetry-azure-monitor-python/issues/91

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   91.98%   91.98%
=======================================
  Files          18       18
  Lines        1048     1048
  Branches      141      142    +1
=======================================
  Hits          964      964
  Misses         74       74
  Partials       10       10

Impacted Files
Coverage Δ

...nitor/src/azure_monitor/export/metrics/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e557961...f2f86ec. Read the comment docs.


Disable DWM: No such option or property

Microsoft Windows [Version 10.0.18363.720]
No such option or property
There's no such property or option as described by the last section in the article:

Note, however, that the DWM is not guaranteed to be enabled. The graphics card might not support the DWM system requirements, and users can disable the DWM through the System Properties control panel. That means your program should not rely on the repainting behavior of the DWM. Test your program with DWM disabled to make sure that it repaints correctly.

Link to article:

Docs: The Desktop Window Manager
_https://docs.microsoft.com/en-us/windows/win32/learnwin32/the-desktop-window-manager?source=docs_
Github: the-desktop-window-manager
_https://github.com/MicrosoftDocs/win32/blob/docs/desktop-src/LearnWin32/the-desktop-window-manager.md_

/cc @mcleans


sabnzbd error

hello mate. loving the script. been using it sometime now. just downloaded your new files. and now am getting this error on sabnzbd, i have installed the requirements.txt just in case mate.  but i keep getting this error.
File "/opt/appdata/sickbeard_mp4/SABPostProcess.py", line 5, in <module>
from autoprocess import autoProcessTV, autoProcessMovie, autoProcessTVSR, sonarr, radarr
File "/opt/appdata/sickbeard_mp4/autoprocess/autoProcessMovie.py", line 11, in <module>
import requests
File "/usr/local/lib/python3.6/dist-packages/requests/__init__.py", line 113, in <module>
from . import packages
File "/usr/local/lib/python3.6/dist-packages/requests/packages.py", line 7, in <module>
locals()[package] = __import__(package)
ModuleNotFoundError: No module named 'idna'```

Did you check and make sure idna is installed? That should be included as part of requests but that's why its failing so try installed that manually and see if it works for you
And make sure you're using the correct python environment through SAB

pip install idna
Requirement already satisfied: idna in /usr/local/lib/python3.6/dist-packages (2.9)
that is what i get when i try to install it mate. and sabnzbd is using python3.6 i looked mate

Something with IDNA is messed up then, its not a package I import its something requests is importing so I'd try removing and reinstalling or maybe do some debugging on the requests package

just an update mate. i found a few of your python scripts have #!/usr/bin/env python3 on them. so i have to change them to #!/usr/binpython3.6 and testing now.

@mdhiggins  just an update mate. sabs won't work. i and i don't get log file to see either. so i ran manual.py and i keep getting this.
/usr/lib/python3/dist-packages/requests/__init__.py:80: RequestsDependencyWarning: urllib3 (1.25.8) or chardet (3.0.4) doesn't match a supported version!   RequestsDependencyWarning) Manual processor started. Python 64-bit 3.6.9 (default, Nov  7 2019, 10:44:02) [GCC 8.3.0]. Guessit version: 3.1.0. /usr/bin/python3 Loading config file /opt/appdata/sickbeard_mp4/config/autoProcess.ini.
but when i change it to #!/usr/bin python3 i get -bash: ./manual.py: /usr/bin: bad interpreter: Permission denied for some reason. this has never happened before.

Something definitely going on with your python environment
You shouldn't have to change the shebang. You could also just point to your python executable you want to use followed by the script as a shell script to ensure the environment is correct

defo something going of mate. in sabs all i get is Exit(-1) Cannot run script /opt/appdata/sickbeard_mp4/SABPostProcess.py i even changed it back to #!/usr/bin/env python3
still don't work. but manual.py will work lol. it was all working fine until i grab the new files.

Its probably the transition to python 3 that's creating issues somewhere. The logs won't show anything if it crashes before it does its imports and its clearly crashing during importing. The new shebang is probably causing things to execute in some other python environment you have installed that's missing or has a corrupt dependency.  Unfortunately these environment errors you kind of have to debug on your own since it specific to your machine but that's what's happening

well your older files are working fine. but your new/updated files on python3 just won't work on sabs. al stick with your older files for time being. i am no good at debugin stuff mate.

I gave you one avenue, make a quick shell script and point it to the correct python executable instead of relying on sab to execute the script directly. You're free to use an older version but eventually the libraries this script depends on are gonna start to break python2, lots of them have dropped official support already


Spurious use of Sleep?

obj/crypto/hashing/testsha256.c:34:3: warning: implicit declaration of function 'Sleep' [-Wimplicit-function-declaration]
   Sleep(200);  // Sleep for 200ms

On Linux:
NAME
       sleep - sleep for a specified number of seconds

SYNOPSIS
       #include <unistd.h>

Worth an #ifdef?

The containing function is actually dead code.  Easier fix is to delete it.


Update RxJava to 1.1.9.

ref: https://github.com/ReactiveX/RxJava/releases/tag/v1.1.9

Thanks!! 😃

LGTM!


Groupby Count

How do I get this using the library? Which is use the count in the select and order by the count
SELECT actor_login, count(*) as Count FROM [github.dotnet]
WHERE type = "PullRequestEvent"
group by actor_login
order by Count desc
limit 100

I tried this but the
var pr = "PullRequestEvent";
var basequery = From<dotnet>().Where(d => d.type == pr)
.Select(e => new { e.actor_login, e.repo_name })
.GroupBy(e => new { e.actor_login, e.repo_name})
.Limit(100)
.RunDry()
.Dump();

The query it output from the linq is
SELECT
  [actor_login],
  [repo_name]
FROM
  [github-data-1163:github.dotnet]
WHERE
  ([type] = 'PullRequestEvent')
GROUP BY
  [actor_login],
  [repo_name]
LIMIT 100

All BigQuery's function under BqFunc.
You can write
.Select(e => new { count = BqFunc.Count(), e.actor_login, e.repo_name })
or
.Select(e => new { count = Count(), e.actor_login, e.repo_name })

Thanks for the support. Could I do a PR for the README with all the things I learn trying to use this?


fix(urllib3): supporting non-kwargs

:tada: This PR is included in version 1.31.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Make guestbook-go example use slaves

The original PHP guestbook example sets up a single redis master and a set of redis slaves that mirror the master.  The guestbook web site then uses the slaves for read operations and the master only for writes.  In the port to Go the use of the slaves was inadvertently dropped.  This change restores their use in a manner similar to the PHP version.

Thanks for fixing this!
One minor nit but otherwise LGTM. I can rebuild the docker images for guestbook-go once this is merged.

done.

Thanks Jason. Can you squash your two commits and then I'll merge.

done.  Thanks for the help!

Will merge on green.


TS-4665: Http2 not terminating stream with short chunked response.

The key fix was added with TS-4729.   This is the additional check on is_done around line 529 of Http2Stream.cc.
To make the fix stable required some additional changes to avoid sending write updates on shutdown when the client is already down and converting some direct handleEvent calls to sending events to avoid deleting the SM on the stack.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/573/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/469/ for details.

Reviewed quickly. Looks ok, but I'm not sure about this change. +0 from me.

Looks good to me.

Hi,
TS-4665 says this is backported to 6.2.1, but does not seem like it is. What is the plan to pull this to 6.2.1?
Thanks,
jay

@jaaju Unfortunately, this hasn't backported to 6.x yet, and it wouldn't be in 6.2.1 because the release is almost there (RC0 passed a voting).
I'm going to try to backport in a couple of days, and hopefully, it will be in 6.2.2.
Thank you for your patience.


CS:1.6 Server - generated configfiles are not used

recently (in july 2016) i created a cs:1.6 from scratch (on an ubuntu 14.04 LTS server).
lsgm generated a cfg folder with the 3 .cfg files (cs-server.cfg, lsgm-default.cfg and server.cfg).
but these .cfg files are not used.
the server.cfg file in the parent cstrike folder is used

We need to investigate, maybe gold source doesn't accept (anymore) forced cfg files.

Just tested it. CS1.6 isn't using a /serverfiles/cstrike/cfg directory for configs like CS:GO or CS:S. They are directly in /serverfiles/cstrike. Should be a easy fix? We just need to adjust the path in the main script.

Fixed in 220a720790d71477da8a9abd38ccae0eba339069


Update sbt, scripted-plugin to 1.10.7

About this PR
📦 Updates

org.scala-sbt:sbt
org.scala-sbt:scripted-plugin

from 1.10.6 to 1.10.7
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-sbt" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, version-scheme:early-semver, commit-count:1

test failure is not related to this PR. It is solved in https://github.com/scala/scalatest-example.g8/pull/96.


installed Soundflower 2.02b2 but its not in application folder

Hi...new to all this, but with El Capitan breaking Soundflower, I am here.
I uninstalled the old version and rebooted.
downloaded 2.02b2 package and install seemed to go smoothly. Screen said it installed successfully.
However, the soundflower icon is not in application folder as expected per the "read me".
The 2ch & 64 ch options appear in the sound preferences, but clicking them mutes the sound.
Any ideas?
thanks
Rick

I'm having the exact same problem. Install goes well, says it worked.  Soundflower shows up in the sound preferences, but there's no application installed (SoundFlowerbed) to allow me to use them so I can't control where the sound goes. (which right now is nowhere.)  Uninstalled for the moment till someone knows a fix or one is applied to the package.

Soundflowerbed is too flaky to continue support but you can do most of it anyway with a multi-output device.  read this thread: https://github.com/RogueAmoeba/Soundflower-Original/issues/44
i should have a new app soon that will hopefully make all of this much more easy.

thanks Matt,
can you reply when you new app is ready?
Thanks for letting me know.
Rick
On Nov 18, 2015, at 12:37 PM, Matt Ingalls<EMAIL_ADDRESS>wrote:

Soundflowerbed is too flaky to continue support but you can do most of it anyway with a multi-output device. read this thread: #44 https://github.com/RogueAmoeba/Soundflower-Original/issues/44
i should have a new app soon that will hopefully make all of this much more easy.
—
Reply to this email directly or view it on GitHub https://github.com/RogueAmoeba/Soundflower-Original/issues/45#issuecomment-157792332.

You can get the app by manually building and copying the output Soundflowerbed app into /Applications and use it.

Hello.
Any idea when the app/menu bar support will be available? Soundflower works great but making adjustments in the sound preferences isn't ideal. Thanks in advance!

brew cask install soundflower soundflowerbed

hello @timotei    Can you explain "manually building and copying the output ... into /Applications" to a non technical person like me?      I have soundflower installed and working, but I do not see it in applications folder on my mac.    I do not find soundflower foler anywhere. When I search my mac, in only shows the .pkg file, but no foler.

Hey guys, you need to go to system prefrences-sound-output/input. There's no actual application for soundflower i'm pretty sure

@Rev117 check @abramclark 's comment, I believe the core app and GUI is 2 apps and soundflowerbed installs the GUI. At least I tested on mine and found soundflower adds the options in sound pref and soundflowerbed adds the GUI app in Launchpad.

brew cask install soundflower soundflowerbed

Works!

I've installed is using brew cask install soundflower soundflowerbed, i see the app but nothing happens when I open it. I'm using Mojave 10.14.16. Any clue, anyone?

I've installed is using brew cask install soundflower soundflowerbed, i see the app but nothing happens when I open it. I'm using Mojave 10.14.16. Any clue, anyone?

No clue why, but can confirm same behavior on my 10.14.6 (which is I assume what @bernardodev meant) system. No devices present in Sound setting either.


vTaskDelay in a global constructor causes: Guru Meditation Error: Core  0 panic'ed (LoadProhibited). (IDFGH-13727)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.3 and
v5.3.1-244-g4d0db7045d
Espressif SoC revision.
ESP32-WROVER (With ESP_PROG)
Operating System used.
Windows
How did you build your project?
Eclipse IDE
If you are using Windows, please specify command line type.
None
Development Kit.

Power Supply used.
USB
What is the expected behavior?
Call the constructor in the global region and continues with the program
What is the actual behavior?
The device is continuous restarting:
Guru Meditation Error: Core  0 panic'ed (LoadProhibited). Exception was unhandled.
Steps to reproduce.

Create a constructor with the function vTaskDelay inside the constructor.
Call the constructor as global.
The constructor are created before the main and after enter in the vTaskDelay crash: Guru Meditation Error: Core  0 panic'ed (LoadProhibited). Exception was unhandled.

Debugger stops on before crash:

Debug Logs.
More Information.
In the version 4.3 this configurations works well.

No response

Hi @mmirad, It maybe possible that the constructor is called even before the scheduler has started. This would mean that several kernel objects may not have been created yet and it could result in the error that you see. Could you provide some information about where or how is the constructor getting called in your application?

Here is a small sample of my code with the parts that affect this.
ADC adc1(k_adc1_instance);
void my_main (void)
{
	// my code
	adc1.init()
	adc1.init_chanel();

	while(1)
	{
		// rest of the code
	}
}

#include <stdio.h>
#include "freertos/FreeRTOS.h"
#include "freertos/task.h"
#include "my_main.h"
void app_main(void)
{
    my_main();

    // This code should never be reached
    while (1)
    {
        vTaskDelay(1000 / portTICK_PERIOD_MS);
    }
}

ADC::ADC(uint8_t adc_instance) : m_supported(false), m_initialized(false), m_channels_num(0)
{

    printf("ADC#%hhu: CONSTRUCTOR\r\n", adc_instance);
    vTaskDelay(pdMS_TO_TICKS(ms));
	// set channels....
}

Just remember that the same code for version 4.3 works correctly, what could be the reason?

@mmirad Thanks for the code snippet. The issue arrises because the vTaskDelay() is called outside of a task context and before the full RTOS environment is setup. The FreeRTOS kernel can't handle this scenario. FreeRTOS can only delay tasks but cannot deal with a constructor getting "delayed" outside of a task scope. The same would happen if you call vTaskDelay() from an ISR context. I haven't looked at why the call worked in 4.3 yet but it could have been a coincidence that it worked.
Nevertheless, maybe you could consider a design where you avoid calling FreeRTOS APIs in global constructors. Perhaps, you could do part of the initialization once the code reaches app_main()?

Add some extra logs v5.3:
[0;32mI (1795) spi_flash: detected chip: generic
[0;32mI (1798) spi_flash: flash io: dio
ADC#1: CONSTRUCTOR
[0;32mI (1805) coexist: coex firmware version: dab85ae96
[0;32mI (1810) main_task: Started on CPU0
[0;32mI (1814) main_task: Calling app_main()
logs v4.3:
[0;32mI (2237) spi_flash: detected chip: generic
[0;32mI (2240) spi_flash: flash io: dio
ADC#1: CONSTRUCTOR
[0;32mI (2247) cpu_start: Starting scheduler on PRO CPU.
[0;32mI (0) cpu_start: Starting scheduler on APP CPU.

Not using vTaskDelay() in the global constructor would be a solution. Since there isn't any change that we can make currently for this issue, I'll close it for now. In case you need more support, please feel free to re-open this ticket or open a new one for us. Thanks!