Added mingw as a rez build_system for cmake.

Barely a pull request, but I wanted the option to use mingw in addition to nmake on windows.
rez-build                      # still defaults to nmake
rez-build --bs mingw   # uses mingw32-make

# ~/.rezconfig can set either as cmake's build_system.

Thanks very much for rez!

tl;dr
If all you're trying to do is get rez working with cmake on windows, I wrote out instructions on how I was able to get it to work at the bottom of this issue: #348
If you can get away with it though, I found mingw to be faster, since it doesn't need to run vcvarsall.bat 3x separate times for each build/install. If you're using all python source though, I'd probably just write something for bez. You'll have a faster turnaround. Alternatively, I noticed another pull request where someone was adding support for setup.py , which will likely turn out to be faster on windows.
# test with cmakefile that copied a single, emptyfile.txt
# not compiling anything using:    ``rez-build --install``

# =============    ================  ======================
# Build System:    First Rez-Build   Subsequent Rez-Builds
# =============    ================  ======================
NMake                 38s                36s    ## most time spent running vcvarsall.bar
MinGW                 28s                5s     ## first-build, cmake spends time testing that installed/works
Bez                   2s                 2s     ## most time spent setting up rez-envs

answering your question:
Full disclaimer, I'm entirely new to compiling software on windows, and I'm pretty new to Cpp/compilers in general.
If i'm understanding it correctly though, NMake is still using visual-studio to do the compile.  It gets installed with the microsoft-build-tools under 'C:\\Program Files (x86)\\Microsoft Visual Studio\\<year>\\BuildTools\\VC\\<version>\.... At a glance, the Makefile that it spits out looks very similar to a gnu-make Makefile.
CMake can also generate Visual Studio projects, targeting specific years, or versions. It creates what I'm guessing is a Visual Studio Project that can be opened in the Visual Studio IDE. These can still be compiled on the commandline using MSBuild .
https://cmake.org/cmake/help/v3.0/generator/Visual Studio 10 2010.html?highlight=visual studio
non-rez NMake Workflow
cd $your_project/build

cmd.exe                        # open cmd.exe within your powershell (reqd for vcvarsall.bat)
vcvarsall.bat x64              # set environment variables for compiling for x64 windows

cmake -G "NMake Makefiles" ..  # generate makefile
nmake                          # compile project
nmake install                  # install compiled project

exit                           # return to powershell

non-rez visual studio cli Workflow
cd $your_project/build

cmd.exe                     # open cmd.exe within your powershell (reqd for vcvarsall.bat)
vcvarsall.bat x64           # set environment variables for compiling for x64 windows

cmake ..                    # generate makefile
MSBuild BUILD_ALL.vcxproj   # compile project
MSBuild INSTALL.vcxproj     # install project

exit                        # return to powershell

Why rez cmake builds don't work out-of-the-gate on windows
The reason that the default of 'NMake Makefiles' is not working out of the gate on windows could be because of one of the following:

Visual Studio needs to set up a bunch of environment variables before compiling. ( https://msdn.microsoft.com/en-us/library/f2ccy3wt.aspx )
According to my reading of other issues on here (I think one of your threads, actually) rez-envs do not inherit the environment of the shell it is invoked in. So even if you run vcvarsall.bat to set your environment, they are not set in the rez-env used for the build.
A Makefile provides instructions to build a project. CMake is a scripting language to generate makefiles that work on a variety of platforms, and for a variety of compilers. Cmake itself doesn't actually compile or install your files, that is done by gnu-make, Nmake, or another build-system. Even if your project is entirely python, and requires no compilation at all CMake still needs to be pointed at something it can generate a Makefile for, that will be made responsible for copying your python source code from A to B.

Just a clarification on:
rez-envs do not inherit the environment of the shell it is invoked in. So
even if you run vcvarsall.bat to set your environment, they are not set in
the rez-env used for the build.
Rez envs DO inherit the original env, however any env-var appends/prepends
done in any of the resolved packages will OVERWRITE that env-var. Case in
point is PYTHONPATH - if it remained intact and was just added to, you
could easily end up with a PYTHONPATH that references existing packages
that might be in conflict with the newly resolved env.
Now having said that, something that's been on the cards for a long time is
more fine-grained control of this behaviour. I'll cite a problem - PATH.
There's something of a hack in place at the moment, which treats PATH as a
special case - otherwise, any append to PATH overwrites it completely, and
suddenly you lose your standard tools like ls, cd etc (which is... a little
problematic!).
I would prefer to have default behaviour which:

Remembers the pre-rev-env value of a var;
Applies currently behaviour (overwrite on first append/prepend);
However, also appends the original pre-rez value back again at the end
(perhaps avoid dups at the same time).

There are some more complexities to this that I won't go into here, but
this is the general idea.
Thx
A
On Sat, Apr 7, 2018 at 8:16 AM, Will Pittman<EMAIL_ADDRESS>wrote:

tl;dr
If all you're trying to do is get rez working with cmake on windows, I
wrote out instructions on how I was able to get it to work at the bottom
of this issue: #348 https://github.com/nerdvegas/rez/issues/348
If you can get away with it though, I found mingw to be faster, since it
doesn't need to run vcvarsall.bat 3x separate times for each
build/install. If you're using all python source though, I'd probably just
write something for bez. You'll have a faster turnaround. Alternatively, I
noticed another pull request where someone was adding support for setup.py
, which will likely turn out to be faster on windows.
test with cmakefile that copied a single, emptyfile.txt# not compiling anything using:    rez-build --install
=============    ================  ======================# Build System:    First Rez-Build   Subsequent Rez-Builds# =============    ================  ======================
NMake                 38s                36s    ## most time spent running vcvarsall.bar
MinGW                 28s                5s     ## first-build, cmake spends time testing that installed/works
Bez                   2s                 2s     ## most time spent setting up rez-envs
answering your question:
Full disclaimer, I'm entirely new to compiling software on windows, and
I'm pretty new to Cpp/compilers in general.
If i'm understanding it correctly though, NMake is still using
visual-studio to do the compile. It gets installed with the
microsoft-build-tools under 'C:\Program Files (x86)\Microsoft Visual
Studio\\BuildTools\VC\.... At a glance, the Makefile
that it spits out looks very similar to a gnu-make Makefile.
CMake can also generate Visual Studio projects, targeting specific years,
or versions. It creates what I'm guessing is a Visual Studio Project that
can be opened in the Visual Studio IDE. These can still be compiled on the
commandline using MSBuild .
https://cmake.org/cmake/help/v3.0/generator/Visual%
20Studio%2010%202010.html?highlight=visual%20studio
non-rez NMake Workflow
cd $your_project/build
cmd.exe                        # open cmd.exe within your powershell (reqd for vcvarsall.bat)vcvarsall.bat x64              # set environment variables for compiling for x64 windows
cmake -G "NMake Makefiles" ..  # generate makefile
nmake                          # compile project
nmake install                  # install compiled project
exit                           # return to powershell
non-rez visual studio cli Workflow
cd $your_project/build
cmd.exe                     # open cmd.exe within your powershell (reqd for vcvarsall.bat)vcvarsall.bat x64           # set environment variables for compiling for x64 windows
cmake ..                    # generate makefile
MSBuild BUILD_ALL.vcxproj   # compile project
MSBuild INSTALL.vcxproj     # install project
exit                        # return to powershell
Why rez cmake builds don't work out-of-the-gate on windows
The reason that the default of 'NMake Makefiles' is not working out of the
gate on windows could be because of one of the following:

Visual Studio needs to set up a bunch of environment variables
before compiling. ( https://msdn.microsoft.com/en-
us/library/f2ccy3wt.aspx )
According to my reading of other issues on here (I think one of your
threads, actually) rez-envs do not inherit the environment of the shell it
is invoked in. So even if you run vcvarsall.bat to set your environment,
they are not set in the rez-env used for the build.
A Makefile provides instructions to build a project. CMake is a
scripting language to generate makefiles that work on a variety of
platforms, and for a variety of compilers. Cmake itself doesn't actually
compile or install your files, that is done by gnu-make, Nmake, or another
build-system. Even if your project is entirely python, and requires no
compilation at all CMake still needs to be pointed at something it can
generate a Makefile for, that will be made responsible for copying your
python source code from A to B.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nerdvegas/rez/pull/501#issuecomment-379399342, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABjqSl4dfLpdEESuiKYD4V1qfTGvQ3lIks5tl-kjgaJpZM4THPft
.

For reference i posted an example of the setup i currently have in the issue below. I need to be able to properly drive cmake msvc builds with support for switching both versions and platform targets.
https://github.com/nerdvegas/rez/issues/431

Thanks for your help @willjp and @instinct-vfx I'm going to go read through #348 , but before that, I wanted to make one small correction to your suggested cmake workflow on windows.  It's true that cmake creates a visual studio project, and you can call MSBuild to compile that project.  However, cmake understands most (all?) generators that it creates. So the more generic workflow is this:
cmake .. -G "Visual Studio 14 2015 Win64"
cmake.exe --build . --config Release

I'm not sure about the install step, but it probably exists as well.

Thanks again @nerdvegas and @instinct-vfx ! I can see how changing the PATH/PYTHONPATH can very quickly get complicated. You have me curious now, time for me to do some more code-spelunking :) .
@assumptionsoup - oh! not necessarily faster, only faster with the way that I've been using it. I created a rez package for visual-studio that ran vsvarsall.bat in package.py's commands() . So it was running vcvarsall.bat 3x times during a rez-build --install .  I'm looking forwards to trying out something more similar to instinct-vfx's setup in #431 , in addition to seeing if I can rig something up so that it only needs to run once.  I'm just starting out, trying to decide on a workflow.

Newer plugin setups are based on  build_command actually. And i also added a custom argument "-g", "--generate" which only generates but does not trigger a build. This is what i use when i start work on something: I clone the repo, and don't need a build of the last release, i just want to start looking into code. So i run with -g and build from VS and only build through rez-build/rez-release for testing and releasing.
For simplicity i am still using rezbuild.py though but call it through build_command like this:
build_command = "python {root}/rezbuild.py {install}"
in rez_build i first run cmake to generate:
 subprocess.call(["cmake", "-G", vs_version, source_path], cwd=build_path)
and then check if --generate was used, and if it was used i simply return_
    if int(os.environ["__PARSE_ARG_GENERATE"]):
        # Return if --generate was given as we only want to generate solution and project files.
        log.info(
            "Solution and project files have been generated in the build folder ("
            + build_path + ")")
        return

If not, i actually build using something like this:
    # Build binaries
    subprocess.call(
        ["cmake", "--build", ".", "--config", "Release"], cwd=build_path)

I am still copying my artifacts manually if release is used as it feels a tad more flexible than having it in cmake thought that could be done easily.
My parse_build_args.py looks as follows for reference:
parser.add_argument("-g", "--generate", action="store_true", help="Generate solution files only (=do not build or install)")
Cheers,
Thorsten

Just reading up on this thread folks. Would it help to have rez-build run vcvarsall.bat x64 when appropriate and before cmake is invoked?


Allow CorrelationFilter with custom properties

Hi,
The documentation for the Python SDK forwards to the Service Bus filtering doc which indicates that CorrelationFilter works with CorrelationID, but also some other system properties and custom properties.
This is true in DotNet.
But in Python, unfortunately, this filter only works with the CorrelationID field. Our only solution is to use SqlFilter, which is apparently much less efficient.
Can you please implement in Python the ability to use CorrelationFilter with other properties ?

Hey K3UL,
First let me apologize that this sat for so long.
Second, I did some digging into the azure-mgmt-servicebus SDK, and it appears that you can create a custom correlationfilter via ServiceBusManagementClient.rules.create_or_update(rg, namespace, topic, subscription, rule_name, parameters), see here
Might I assume from this that you were leveraging the control_client ServiceBusService within the core azure-servicebus package when you hit this blocker?
If so I'd recommend using the mgmt package if at all possible; the control_client code was initially maintained for backcompat of a prior SDK revision, and is in the process of being modernized/brought into the pending GA release (currently in preview, although this code is not present as of b2, likely will appear in the b3 or b4 releases).
Don't hesitate to shout if I'm off base with any of this or if any clarification/questions are needed.

Hi @KieranBrantnerMagee, thank you for your answer.
Indeed I am using control_client.ServiceBusService for the subscription and rule creation, as azure.servicebus.ServiceBusClient does not offer these capabilities.
I do use the new SDK for the other operations (publishing and fetching messages).
I had seen that the management package can do something like this but I have two probles with it compared to the old client :

A big lack of documentation. There is zero doc on how to use it, only an auto-generated one of the classes, without any context.
From the little doc aforementioned, I can see you need Azure AD credentials to use the client. I suspect this is because the management package has capabilities beyond the sole subscription to a topic/queue, management ones.

I think subscribing and filtering is part of what any client wants to do when connecting to a topic/queue and is not management per-se. The old SDK only requires the connection string to do this, and I really do not want to start adding Azure AD credentials and things like that.

The old SDK only requires the connection string to do this, and I really do not want to start adding Azure AD credentials and things like that.

It's a very apt time for you to mention this, since we've heard similar responses from other users, reinforcing the aformentioned decision to modernize the management tooling within the core library enabled by SAS/connection string.
In that vein, as hinted at previously, we'll likely have the capabilities you want within the next 1-2 preview releases.  Shout if this is a more urgent need/if a combination of sql filters and the mgmt lib don't provide sufficient workarounds in the interim; but that would otherwise be where I'd recommend to keep an eye out as we roll these features out.
(In terms of insufficient long-form docs for the mgmt lib, 100% know where you're coming from.  I'll both bubble this up to our docs folks, and see if we can take any action within the SB world to give breadcrumbs or samples in leiu of that.)

That sounds great thank you ! I think it is fine to wait for a couple months and keep using the SqlFilter, it is good to know you guys are working on the management library towards this, because it is a lib I wanted to use beside the Azure AD neeed :)
As for the docs, I think they should at the very minimum point to the samples/test in the Github repos, this is usually how I find the information. But the right repo/file is not always easy to find and I know my coworkers don't necessarily think about that. For example https://github.com/Azure-Samples/service-bus-dotnet-management or https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/servicebus/azure-mgmt-servicebus/tests

Great to hear.
Wanted to follow up and mention that I've given the feedback to the mgmt docs owners, and they'll be looking to bolster that section.  In the interim, I've added a small snippet to our README; let me know if you find that this would have given you enough breadcrumbs as you mention above, or if a different location/details would have been more enlightening; feel free to either comment there or here.  (Bikesheddy debate that I should have just added you as a reviewer but figured context would be useful :) )

The docs are the main breadcrumb we need but anything helps and I think indeed having it in the Readme helps having a place to look in, without having to search all over the place. For sure it would have saved me some time. Thank you !


[auto-merge] branch-22.06 to branch-22.08 [skip ci] [bot]

auto-merge triggered by github actions on branch-22.06 to create a PR keeping branch-22.08 up-to-date. If this PR is unable to be merged due to conflicts, it will remain open until manually fix.

FAILURE - Unable to auto-merge. Manual operation is required.
{'message': 'Pull Request is not mergeable', 'documentation_url': 'https://docs.github.com/rest/reference/pulls#merge-a-pull-request'}

Please use the following steps to fix the merge conflicts manually:
# Assume upstream is NVIDIA/spark-rapids remote
git fetch upstream branch-22.06 branch-22.08
git checkout -b fix-auto-merge-conflict-5752 upstream/branch-22.08
git merge upstream/branch-22.06
# Fix any merge conflicts caused by this merge
git commit -am "Merge branch-22.06 into branch-22.08"
git push <personal fork> fix-auto-merge-conflict-5752
# Open a PR targets NVIDIA/spark-rapids branch-22.08

IMPORTANT: Before merging this PR, be sure to change the merging strategy to Create a merge commit (repo admin only).
Once this PR is merged, the auto-merge PR should automatically be closed since it contains the same commit hashes


Pusher_2d.xml does not exist

Hi there, I'm trying to use Pusher2d-ImageReach-v0 env by creating a pusher2d/0.py config.
params = {
    'type': 'MBPO',
    'universe': 'gym',
    'domain': 'Pusher2d',
    'task': 'ImageReach-v0',

    'log_dir': '~/ray_mbpo/',
    'exp_name': 'defaults',

    'kwargs': {
        'epoch_length': 1000,
        'train_every_n_steps': 1,
        'n_train_repeat': 20,
        'eval_render_mode': None,
        'eval_n_episodes': 1,
        'eval_deterministic': True,

        'discount': 0.99,
        'tau': 5e-3,
        'reward_scale': 1.0,

        'model_train_freq': 1000,
        'model_retain_epochs': 5,
        'rollout_batch_size': 100e3,
        'deterministic': False,
        'num_networks': 7,
        'num_elites': 5,
        'real_ratio': 0.05,
        'target_entropy': -2,
        'max_model_t': None,
        'rollout_schedule': [20, 300, 1, 20],
        'hidden_dim': 400,
    }
}

However, I got this error:
Traceback (most recent call last):
  File "/home/lab/anaconda3/envs/mbpo/lib/python3.6/site-packages/ray/tune/trial_runner.py", line 389, in _process_events
    result = self.trial_executor.fetch_result(trial)
  File "/home/lab/anaconda3/envs/mbpo/lib/python3.6/site-packages/ray/tune/ray_trial_executor.py", line 252, in fetch_result
    result = ray.get(trial_future[0])
  File "/home/lab/anaconda3/envs/mbpo/lib/python3.6/site-packages/ray/worker.py", line 2288, in get
    raise value
ray.exceptions.RayTaskError: ray_ExperimentRunner:train() (pid=8159, host=lab-server)
  File "/home/lab/anaconda3/envs/mbpo/lib/python3.6/site-packages/ray/tune/trainable.py", line 150, in train
    result = self._train()
  File "/home/lab/Github/TendonTrack/ipk_mbpo/examples/development/main.py", line 98, in _train
    self._build()
  File "/home/lab/Github/TendonTrack/ipk_mbpo/examples/development/main.py", line 48, in _build
    get_environment_from_params(environment_params['training']))
  File "/home/lab/Github/TendonTrack/ipk_mbpo/softlearning/environments/utils.py", line 34, in get_environment_from_params
    return get_environment(universe, domain, task, environment_kwargs)
  File "/home/lab/Github/TendonTrack/ipk_mbpo/softlearning/environments/utils.py", line 24, in get_environment
    env = ADAPTERS[universe](domain, task, **environment_params)
  File "/home/lab/Github/TendonTrack/ipk_mbpo/softlearning/environments/adapters/gym_adapter.py", line 68, in __init__
    env = gym.envs.make(env_id, **kwargs)
  File "/home/lab/anaconda3/envs/mbpo/lib/python3.6/site-packages/gym/envs/registration.py", line 156, in make
    return registry.make(id, **kwargs)
  File "/home/lab/anaconda3/envs/mbpo/lib/python3.6/site-packages/gym/envs/registration.py", line 101, in make
    env = spec.make(**kwargs)
  File "/home/lab/anaconda3/envs/mbpo/lib/python3.6/site-packages/gym/envs/registration.py", line 73, in make
    env = cls(**_kwargs)
  File "/home/lab/Github/TendonTrack/ipk_mbpo/softlearning/environments/gym/mujoco/image_pusher_2d.py", line 57, in __init__
    super(ImageForkReacher2dEnv, self).__init__(*args, **kwargs)
  File "/home/lab/Github/TendonTrack/ipk_mbpo/softlearning/environments/gym/mujoco/image_pusher_2d.py", line 11, in __init__
    Pusher2dEnv.__init__(self, *args, **kwargs)
  File "/home/lab/Github/TendonTrack/ipk_mbpo/softlearning/environments/gym/mujoco/pusher_2d.py", line 58, in __init__
    MujocoEnv.__init__(self, model_path=self.MODEL_PATH, frame_skip=5)
  File "/home/lab/anaconda3/envs/mbpo/lib/python3.6/site-packages/gym/envs/mujoco/mujoco_env.py", line 45, in __init__
    raise IOError("File %s does not exist" % fullpath)
OSError: File /home/lab/Github/TendonTrack/ipk_mbpo/models/pusher_2d.xml does not exist

Is there actually no model about it in your repository?
Furthermore, the reason why I want to test this environment is trying to figure out the preprocessing method of image observation. Do you have any suggestions about that?

After downloading the pusher_2d.xml from https://github.com/rail-berkeley/softlearning/blob/master/models/pusher_2d.xml, the issue solved.

Is this issue resolved?
Since Pusher2d-ImageReach is not a standard gym environment, I think the solution you found (copying the xml manually to models/) is the right one.

Yeah, it's solved.


issue 7909 fixed

clicking on the stream hides the search box and the issue seems to be fixed. :)

@Redarcher9 can you explain why this change is correct?  We're not interested in PRs that don't explain the reasoning.  I'm closing this; if you'd like to do this, please submit a new PR :)
Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages


SolverLookup.get(..).solve() does not update the model's status

from cpmpy import *
m = Model()
SolverLookup.get("ortools",m).solve()
print(m.status())                                # expected "ExitStatus.OPTIMAL" got "ExitStatus.NOT_RUN"

This is very unintuitive behaviour indeed.
I'll add this to the documentation.
A solver object does not store the model (nor CPMpy constraints) when called, so when calling solve() on the Solver object, the status of the model should not change.
Note that in general, it should suffice to only use m.solve(solver="ortools"). Explicitly creating a solver interface is only usefull when relying on solver-specifc features (for example here)

@IgnaceBleukx did you add this to the documentation. I can't find it. Can you post a link to it here and close the question ?

I did now


App Authentication issue

I have redirect my domain to public by using .htaccess file in root folder

# That was ONLY to protect you from 500 errors
# if your server did not have mod_rewrite enabled
RewriteEngine On
RewriteBase /
NOT needed unless you're using mod_alias to redirect
RewriteCond %{REQUEST_URI} !/public
RewriteRule ^(.*)$ public/$1 [L]
Direct all requests to /public folder

But now when I have installed my app it gives authentication error.

Kindly provide the solution.
Thanks

@yogeshausp so you have this issue still as #1190 shows your app working.

Yes. I have still this issue when I install the app on dev store.

Can you provide more information on how to replicate?  Does it happen all the time or only sometimes?

Actually I have develop the custom app on this partner account first time. The server used is linux server.  But when I have installed the app on development store it gives the error.

It sounds like an issue somewhere on the server side potentially. Does the app work locally?

Yes

If it works locally, you have an issue somewhere on your server setup - we can't really help with the devops side as there's a lot of variation from server to server.


Update Jenkins agent

https://sonatype.slack.com/archives/CCAKJBTA6/p1687876134069099

gem is also referenced here: https://github.com/sonatype/docker-nexus3/blob/main/Jenkinsfile
And feature builds have already run here: https://jenkins.ci.sonatype.dev/job/integrations/job/cloud/job/docker-nexus3-feature/job/bnr-update-agent/

gem is also referenced here: https://github.com/sonatype/docker-nexus3/blob/main/Jenkinsfile

Removed together with the Rspec file: 80f5920

And feature builds have already run here: https://jenkins.ci.sonatype.dev/job/integrations/job/cloud/job/docker-nexus3-feature/job/bnr-update-agent/

Build and Test stage are green, just failing at IQ Policy Evaluation due to previous violations.
I don't understand why two out of three test expectation are coloured red in Jenkins log, but the stage is still marked green. I tried making those two use the same commands as the third one, but it didn't seem to change anything. Anything I may have missed or misinterpreted?
https://jenkins.ci.sonatype.dev/blue/organizations/jenkins/integrations%2Fcloud%2Fdocker-nexus3-feature/detail/bnr-update-agent/5/pipeline


Add google login and save projects in google drive

Currently the app has only local database.
Adding google account login functionality for the app makes the user to upload saved projects and apks into google cloud and retrieve them on different mobiles

I am going to work on this issue

@ShailyTyagi  I want to work on this issue. Waiting for opticod's confirmation. Please find some other issue

Okay!

@nikhilchowdary Update your progress on this one!

Is this issue resolved else i want to work on this

@singhania1408 @anuradhagupta345  I am still working on this  issue and waiting for reply from maintainers.I will let you know if I need any help

Its a nice feature to have it. Thanks for reporting this.

I have already sent a PR for this.Please review and merge it


Unable to switch focus between Chrome tabs.

Hi there,
I am unable to switch focus between tabs in Chrome, Where as control can be shifted between the tabs using "browser.switchTo().window( handles[1] )".
Scenario: I am dealing with 3 tabs, currently 3rd tab is in focus. With the above snippet I can switch the control to 2nd tab. Once I switch the control to the 2nd tab, I am unable to perform some actions like selecting an option from dropdown, it is throwing "No such element available error". If I am able to switch the focus I can perform all actions without any issues. But there is no function available in Protractor to switch the focus between tabs.
Additional Info:
Protractor Version: 3.1,
Chrome Version: 54.
Regards,
Charvaka.

I see the same issue - here's the ChromeDriver bug tracking this: https://bugs.chromium.org/p/chromedriver/issues/detail?id=1315
From the team response, it sounds like changing tab focus is out of scope, but theoretically commands should work the same on the window whether it is focused or not.
It sounds like the root problem for you is that the option dropdowns are not available when not focused. This is working properly on my machine, so it's possible that it's a system issue. Here is  my test case:
  it('should interact with a new tab', function() {
    browser.ignoreSynchronization = true;
    browser.get('http://www.protractortest.org/testapp/');

    browser.sleep(500);

    browser.actions().keyDown(protractor.Key.COMMAND).perform();

    element(by.css('a')).click();

    browser.sleep(2000);

    browser.getAllWindowHandles().then(function(handles) {
      browser.switchTo().window(handles[1]);
      browser.sleep(2000);

      element(by.css('select')).click();
      element.all(by.css('option')).get(2).click();

      browser.sleep(2000);
    });
  });

Can you see if that works on your machine, and if not, open up an issue with Chromedriver?

Any progress on this ?!


Bug: no CI test for overlapping symbols

[x] no CI test for overlapping token symbols. For this curated list, we should require unique symbols
[ ] assuming CI doesn't run against master, so two open PRs against master could be passing CI and merged that violate the above constraint

There are already tests for it


Serial port preparation

In case that port is not set to 115200 baud.

Can you rebase this PR please?

@jckuester it's up to date with your master after merging #16

Any chance that this PR and #18 will get merged soon and a new release will be published?

@jckuester any chance to get it merged?

@martinhoefling sorry for neglecting your PR.


help needed in word2vec_gen.py.

How TorchCBOW supports sampling or sample_radius?

Dear Prashant Gupta,
The sample sentences are generated by replacing individual words for the most similar words. The radius is not well defined, but you can use the measure of similarity as sample_radius.
I also recommend to use GensimCBOW is much faster than TorchCBOW.
Anything, I am available.
Best,
Tiago


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v4.14.256",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=bb6ed2e05eb6e8619b30fa854f9becd50c11723f"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "bb6ed2e05eb6e8619b30fa854f9becd50c11723f",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "usb: host: ohci-tmio: check return value after calling platform_get_resource()\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.14.256 by commit bb6ed2e05eb6e8619b30fa854f9becd50c11723f. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1002240


Causing 500.50 Rewrite Module Error on IIS with iisnode

Using this web.config:
<?xml version="1.0" encoding="utf-8"?> <configuration>     <system.web>     <sessionState cookieless="true" timeout="10" />   </system.web>     <system.webServer>         <modules runAllManagedModulesForAllRequests="false" />     <iisnode watchedFiles="web.config;*.js;config.json"/>         <handlers>       <clear />       <add name="iisnode" path="/server.js" verb="*" modules="iisnode" />    </handlers>       <security>       <requestFiltering removeServerHeader="true">         <hiddenSegments>           <remove segment="bin" />           <add segment="node_modules" />         </hiddenSegments>        </requestFiltering>     </security>     <rewrite>       <rules>         <clear />         <rule name="node">           <action type="Rewrite" url="/server.js" />         </rule>       </rules>     </rewrite>   </system.webServer> </configuration>
When the website is started it throws a 500.50 with the following output.
`
HTTP Error 500.50 - URL Rewrite Module Error.
The page cannot be displayed because an internal server error has occurred.
 `
Website is hosted in Azure under an S2 tier.
Repro Steps:

Create a simple website
2, add the web.config as above
add the site extension
turn on diagnostic logs
start website and inspect log stream

It looks like something is using   and I had blocked  in the xdt transform because I was afraid it would allow someone to accidentally remove the redirection.  Something recently changed, though, and I had to remove locking of attributes to make the extension start working again.  Can you try upgrading to the latest version of this extension and see what happens now?


Treat MacOS .app as a folder

A minor inconvenience, but I cannot open a MacOS .app's binary in Binary Ninja using the File>Open or File>Open with Options. When I try it, the file chooser won't drill deeper in to the .app folder.

I’ll +1 this, having drag and drop from a .app is kind of frustrating

I think if you add the same filters as #1322 this issue might be fixed.
QDir::AllEntries | QDir::Hidden | QDir::System

@psifertex While I understand the decision not to implement anything custom, wouldn't it be fairly easy to load MacOS/AppName when opening an app? That's what IDA does, and there's no need to maintain custom file picker functionality, although I'm sure this problem will be removed with the 3.1 release supporting container formats it may be a nice QoL workaround, it'd also work with .kexts too


Avoid unnecessary update when tfjob is complete

Updating status is unnecessary when the tfjob is done and no status is updated indeed. But it will introduce overhead by writing etcd. The commit is to avoid such operation.

This change is

Coverage remained the same at 76.744% when pulling d8d3809fb261423d4ad34028711b8c58fe13cb01 on cheyang:avoid_unnecessary_update_when_tfjob_is_complete into 7ccfeafcd3305b7aaf63f7567f5877244f09b704 on kubeflow:master.

/retest

/lgtm

/retest

/ping @ChanYiLin

/ping @wackxu @gaocegege @ChanYiLin @richardsliu

Comment is here: https://github.com/kubeflow/tf-operator/pull/1051#discussion_r309977943

Same here https://github.com/kubeflow/tf-operator/pull/1051/files#diff-1aec8fe4a85f4edd97b4cdeb92ffa027L466
Sorry for the careless review.
After the change, I think we could merge it.
Thanks for your contribution! :tada: :+1:

/lgtm
/approve
Thanks for your contribution

Thank you, @gaocegege


Autel RTMP Streaming: not enough bits

Which version are you using?
v1.5.0
Which operating system are you using?

[ ] Linux amd64 standard
[x] Linux amd64 Docker
[ ] Linux arm64 standard
[ ] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[ ] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue
In relation to the question 2829 (https://github.com/bluenviron/mediamtx/discussions/2829), when an autel drone streams in rtmp, the following error appears:
closed: not enough bits
Describe how to replicate the issue

start the server
publish with Autel EVO II - Remote Controller V3
read with --

Did you attach the server logs?

yes
Did you attach a network dump?

yes
[Autel-log_pcap.zip](httpAutel-log_pcap(1).zip

The dump you provided doesn't contain any valid RTMP packet, just acknowledges without any payload:

Please provide another dump. The dump is needed in order to run a simulator that allows to replicate the bug. If the bug cannot be replicated, the issue cannot be solved.

The problem has been resolved with version 1.8.0 and an update to the altar application.


Adding map_roles prevents worker nodes from joining cluster

I have issues
I'm submitting a...

[x] bug report
[ ] feature request
[ ] support request
[ ] kudos, thank you, warm fuzzy

What is the current behavior?
Adding map_roles to the module configuration prevents worker nodes from joining cluster
If this is a bug, how to reproduce? Please include a code sample if relevant.
map_roles = [
    {
      role_arn = "arn:aws:iam::123456789:role/EKSManagement"
      username = "external-access:{{AccountID}}"
      group    = "system:masters"
    }
  ]

What's the expected behavior?
Adding roles should only add additional roles, not overwrite the required roles the nodes are using
Are you able to fix this problem and submit a PR? Link here if you have already.
Environment details

Affected module version:
OS: Linux
Terraform version: 0.12.7

Any other relevant info
I am seeing errors in the API server logs in cloudwatch to indicate the role the nodes are using is not mapped. This is the same issue as described in #206

I am also experiencing the same issue. I believe this is also related to #534
In my case I use Jenkins to run Terraform to create an EKS cluster. I provided map_roles like above, and the module created the aws-auth ConfigMap and Terraform says that it's successfully applied to the cluster. However the nodes weren't able to join the cluster and I wasn't able to join the cluster.
To workaround, I had to explicitly define the Configmap as a local variable:
locals {
  config_map_aws_auth = <<CONFIGMAPAWSAUTH
apiVersion: v1
kind: ConfigMap
metadata:
  name: aws-auth
  namespace: kube-system
data:
  mapRoles: |
    - rolearn: ${module.eks_cluster.cluster_iam_role_arn}
      username: system:node:{{EC2PrivateDNSName}}
      groups:
        - system:bootstrappers
        - system:nodes
    - rolearn: ${module.eks_admin_role.this_iam_role_arn}
      username: KubernetesAdmin
      groups:
        - system:masters
CONFIGMAPAWSAUTH
}

And apply it using local-exec like this so Jenkins can apply it for me.
resource "null_resource" "cluster" {
  triggers = {
    configmap_trigger = local.config_map_aws_auth
  }

  provisioner "local-exec" {
    command = "kubectl --kubeconfig ./kubeconfig_${module.eks_cluster.cluster_id} apply -f -<<EOF\n${local.config_map_aws_auth}\nEOF"
  }
}

Please someone look into this. Thanks.

However the nodes weren't able to join the cluster

Why not?

However the nodes weren't able to join the cluster

Why not?

It's because the aws-auth ConfigMap wasn't applied, even though Terraform says that it is :(

Please review https://github.com/terraform-aws-modules/terraform-aws-eks/pull/606

I think it could be the 2 empty lines that's breaking it?

It's YAML so empty lines shouldn't make any difference.

@uyenle57 - can you maybe post the output (with sensitive data removed) of kubectl get cm aws-auth -n kube-system -o yaml
I also discovered a bug (will probably file a bug report here).  If you do not specify any worker groups, the aws-auth file has a syntax error |2 (see below).    I dont think spaces are the problem however.  I removed the 2 and kept the spaces and recreated this file, and it worked.
kubectl get cm aws-auth -n kube-system -o yaml
apiVersion: v1
data:
  mapRoles: |2

    - "groups":
      - "system:authenticated"
      "rolearn": "arn:aws:iam::(edited)"
      "username": "'{{SessionName}}'"

kind: ConfigMap
metadata:
  creationTimestamp: "(edited)"
  name: aws-auth
  namespace: kube-system


Release of version <IP_ADDRESS> of AuditPolicyDsc

Releasing version <IP_ADDRESS>

This change is

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3ed8995). Click here to learn what that means.
The diff coverage is 100%.

@@          Coverage Diff           @@
##             master   #44   +/-   ##
======================================
  Coverage          ?   85%
======================================
  Files             ?     4
  Lines             ?   160
  Branches          ?     0
======================================
  Hits              ?   136
  Misses            ?    24
  Partials          ?     0

Impacted Files
Coverage Δ

...PolicySubcategory/MSFT_AuditPolicySubcategory.psm1
85.71% <100%> (ø)

...MSFT_AuditPolicyOption/MSFT_AuditPolicyOption.psm1
95.83% <100%> (ø)

...urces/MSFT_AuditPolicyCsv/MSFT_AuditPolicyCsv.psm1
86.79% <100%> (ø)

...olicyResourceHelper/AuditPolicyResourceHelper.psm1
75.6% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed8995...2eba634. Read the comment docs.


Add 'last updated' banner to internal and externally version controlled docs

This PR removes the old "last reviewed on" banner from the bottom of the internally hosted docs. In their place - and as a new feature for the externally hosted docs - there's now a "Last updated" banner at the top of each doc. The date is clickable and links to the commit SHA on GitHub so that the changes can be viewed easily.
"Last updated" on internal docs:

"Last updated" on external docs:

This is phase 1 of removing Daniel the Manual Spaniel. Once the 'last reviewed' date is no longer surfaced visually, there's no point in keeping it - we'll remove the 'last_reviewed' and 'review_in' properties from files and discontinue the spaniel.
Trello: https://trello.com/c/OMBV5qM4/198-retire-daniel-the-manual-spaniel

Hmmm we've run into a curious bug 🤔  All of the local pages have the same 'last updated' value of 28 Oct 2020, and point to the merge commit for this PR.
My local setup works great:

And I've checked the commit_helpers_spec test, and the behaviour seems to work as it should:
source_file(current_page)
=> "source/index.html.erb"

The example source/index.html.erb file was last updated in 2019, with the commit b081338b0a11cb561df200124e82e2533ed32728 - and that seems to work locally:
Git.open(".").log.path(source_file(current_page)).first.sha
=> "b081338b0a11cb561df200124e82e2533ed32728"

Git.open(".").log.path(source_file(current_page)).first.date
=> 2019-09-13 15:28:27 +0100

So it looks as though current_path isn't set. If I pretend it doesn't exist, source_file would return "source/", which gives us the latest commit for the whole folder - which appears to be what is happening on https://docs.publishing.service.gov.uk:
Git.open(".").log.path("source/").first.date
=> 2020-10-28 08:18:33 +0000

I need to figure out why current_page doesn't exist when GitHub Actions compiles the project. 😞

Oh yes, I see what you mean 😬. Thanks for spotting! I'm afraid I don't have any suggestions at the moment, although we may want to consider reverting this soonish, to avoid confusing people.


test: behaviors-message_on_lock_failure (2024-02-05 23:02:19.683692+00:00)

automatic test cleanup


.is-exiting on firefox problem

On firefox page exit animation plays then the elements come back to their original position.
The issue is not there when i test it on local, when i upload it to the server if i press back button or use a link in navigation the page exit animation plays then positions back.
The issue is not there in the smoothstate.js demo website so im not sure where im going wrong even adding -moz- prefix to alternate-reverse does not seem to fix it.
any tips on the fix will be really appreciated.
Chrome has no such issues, i have added chrome prefix.
Great job with the plugin, really good.
EDIT : managed to fix it, added page cache that is some how fixing it.
had to upload to a server to test since on local it does not fire .is-exiting just gives a white flash.

This is a real issue.
I'm having the exact same problem since yesterday, it look's like Firefox reload mid animation (I've change my animation time to 2s) and the class "is-exiting" is removed after 1 second and the animation flick to 0%.
Thanks for the caching solution I will give it a try.

duplicate #125


Error in jsonld parse

Hey there,
how can I prevent this error thrown by jsonld-parser.js?
The input html code has no jsonld, this why w-a-e is throwing the error.
Maybe, w-a-e should try if json-ld is present, because the error message is wrong at the moment if now json-ld is in the html - right?
Error in jsonld parse - SyntaxError: Unexpected end of JSON input
POST /detailpage 200 4729.179 ms - 678
POST /detailpage 200 5661.727 ms - 2388
Error in jsonld parse - SyntaxError: Unexpected end of JSON input
POST /detailpage 200 4616.781 ms - 664
Error in jsonld parse - SyntaxError: Unexpected end of JSON input                                                                 POST /detailpage 200 4659.136 ms - 1339

@floflock Can you include a code snippet to reproduce this issue?

Sure, here is the code:

const html = '<html></html>'

const wae = require('web-auto-extractor').default

wae().parse(html)

Maybe you try this page: https://search.google.com/structured-data/testing-tool/u/0/#url=https%3A%2F%2Fwww.docmorris.de%2Fmelissaphosphorus-compmischung%2F01632860

Throwing is better, so you know your input isn't in the expected format.

Try/catch isn't possible, because it is a `console.log()``
try {
      return wae().parse(html)
} catch (e) {
      //
}

@floflock Okay so the error isn't thrown, it is just a log statement; it should be ignorable.

FWIW I'm working on this now and expected it to throw. I do get the log message, but that's not as explicit as throwing and handling a specific case.
Alternative designs:

explicitly declare this operation throws -- that should feel normal to JS developers since anybody who has ever used JSON.parse has had to consider that case (whether they knew it or not)
populate an errors property on the instance I can inspect manually

Hi @paambaati, I trust that you're all quite busy so I don't mean to come off with any undue urgency.
I'm curious to know what you would advise regarding https://github.com/indix/web-auto-extractor/pull/25
Is Indix open to contributions on this project? Given your estimation on time available to review submissions, do you recommend I work off a fork for a while?

@paambaati would you be so kind to give short feedback on that topic?
As far as I can see, @paambaati wants to add additional features.
I will prepare the package for exnext-ready syntax (Class, etc.)...

@TheDahv @floflock First off, apologies for the silence; we've been busy for the past few months. To answer your questions, yes, please go ahead with your fork. I'll carve out some time to review it.

@paambaati thanks for your feedback. I use your package in a certain project. I've made a fork and will try to improve some things.


Added new fields to Database schema

Updated database schema to reflect latest ingredient details

❓ Would we need to update the version?
❓ Also for the other functions like addItem, updateItem, etc. Would it throw errors if we pass parameters there but don't display it on frontend? Maybe in a follow-up PR we can add parameter passing and just stub the actual variable.
ex:
foo(x,y,z):
x = null
From there I think Benjamin and others can use the variables they need and assign them accordingly.
CC: @Ckalia11 @BenjaminLuo
LGTM otherwise. Thanks 🙌

⚠  Will also require a follow-up PR also to remove references to obsolete database attributes. Can do that later as you suggested.


Disable binlog during restore

What
Enabling binlog output during restoration slows down the process.
It is better to disable binlog during the restore and enable binlog after the restore is complete.
How
Disable binlog during restoration and re-enable binlog after the restoration completes.
Consider the following parameters for further optimization.
skip-innodb_doublewrite
innodb_flush_log_at_trx_commit = 0
innodb_flush_method = O_DIRECT_NO_FSYNC

Checklist

[ ] Finish implementation of the issue
[ ] Test all functions
[ ] Have enough logs to trace activities
[ ] Notify developers of necessary actions

While reading restore.go, I noticed that the option -skipBinlog=true was included.
Thus, binlog was disabled during the restore.
https://github.com/cybozu-go/moco/blob/539a90d2e329589f4d05612080584a30820b32b3/pkg/bkop/restore.go#L36


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/ux-writers
/assign knative-sandbox/ux-writers
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping k8s.io/apimachinery 2f881bd...c278689:
  > c278689 Merge pull request # 100952 from saschagrunert/automated-cherry-pick-of-# 99839-upstream-release-1.20
  > 2d51b86 Merge pull request # 101326 from joelsmith/automated-cherry-pick-of-# 101306-upstream-release-1.20
  > e3b7810 Cleanup portforward streams after their usage
  > b6e7048 Additional CVE-2021-3121 fix
  > 640a627 Merge pull request # 100501 from joelsmith/automated-cherry-pick-of-# 98477-upstream-release-1.20
  > 653e41b update gogo/protobuf to v1.3.2
  > 2641dba Merge pull request # 99038 from apelisse/update-smd-1.20
  > 1a42446 Update sigs.k8s.io/structured-merge-diff to v4.0.3
  > dd12c7a Merge pull request # 99171 from jkh52/release-1.20
  > 70e9d54 Bump konnectivity-client to v0.0.15 in release-1.20
  > 2456ebd Merge pull request # 95981 from caesarxuchao/http2-healthcheck
  > 859536f Merge pull request # 96317 from Jefftree/test-ssa
  > 5ff8662 allow configuring ReadIdelTimeout and PingTimeout via env var
  > e8cd3b1 Update kube-openapi
  > f364803 configure the ReadIdleTimeout and PingTimeout of the h2 transport
  > 65a627a Merge pull request # 96425 from bobbypage/vendor-cadvisor-v0.38
  > bd89392 vendor: cadvisor v0.38.4
  > 3231570 Merge pull request # 96549 from caesarxuchao/net-sys-dep-update
  > 88452b9 update golang.org/x/net and golang.org/x/sys
  > 671277b Merge pull request # 94866 from smarterclayton/scheduling_metrics
  > ea81dfb quantity: Allow quantity to be converted to float64
  > 000b5f4 Merge pull request # 96331 from mithuns/fix-lint-runtime-serializer-protobuf
  > dd0b9a0 Merge pull request # 95908 from chenk008/fix_quantity_string
  > 5a2beb9 Fix go lint on folder apimachinery/pkg/runtime/serializer/protobuf
  > 2afe1df Merge pull request # 96323 from msscaroso/fix-lint-runtime-serializer-json
  > 0a90637 fix all Sting method not check nil in "k8s.io/apimachinery"
  > a787aaf Merge pull request # 95954 from sttts/sttts-go-openapi
  > fc267ee Fix go lint on folder apimachinery/pkg/runtime/serializer/json
  > 8f768e7 bump(k8s.io/kube-openapi)
  > d67967d Merge pull request # 96020 from deads2k/dynamiclist
  > 79ef3cb Merge pull request # 96154 from rf232/update_klog
  > 53dac37 remove dead negotiation methods
  > dc3e230 Update Klog dependency
  > 1aed267 Merge pull request # 95961 from KnicKnic/set_condition
  > a876aa5 Merge pull request # 90355 from gaurav1086/apimachinery_remove_map_exists
  > 9338bf8 SetCondtion updates generation
  > 8046191 Merge pull request # 96108 from liggitt/revert-sys
  > a35bab0 [apimachinery] map delete key remove exists check
  > b6980d0 Merge pull request # 93859 from habibrosyad/patch-92402-2
  > e69fc57 Revert "Updated golang/x/net. Also updated golang.org/x/sys"
  > ff4a23d Merge pull request # 94480 from wojtek-t/remove_conversion_fields
  > 4d3fd53 fix vendor/k8s.io/apimachinery/pkg/api/meta staticcheck
  > 3a3fc75 Merge pull request # 96076 from caesarxuchao/update-deps
  > 95cb56f Remove FieldMatchingFlags
  > 8b0d589 Updated golang/x/net. Also updated golang.org/x/sys, as required by
  > d10b9c3 Merge pull request # 95874 from tkashem/webhook-handle-error
  > ab98f4d dual stack services (# 91824)
  > 82ec183 Webhook: handle error when calling wait.ExponentialBackoff
  > 3c73e5f Merge pull request # 95836 from nodo/yaml-unmarshal-number
  > 09e0b8e Merge pull request # 95821 from markusthoemmes/optimize-nn-string
  > d49a39e Add yaml util to unmarshal numbers into int/float
  > 4617138 Optimize string building for NamespacedName
  > 554eef9 Merge pull request # 95692 from markusthoemmes/bump-azure-adal
  > 00bf20f Fix dependency linting
  > 3c07e78 Bump github.com/Azure/go-autorest/autorest/adal to 0.9.5
  > d4f471b Merge pull request # 89482 from renatoviana12/master
  > 44d2359 Merge pull request # 95179 from stevenshuang/master
  > 7a27181 Fixed percentage behavior in instr
  > 6a8da43 Replace AreLabelsInWhiteList with isSubset
  > 10b3882 Merge pull request # 93901 from jpbetz/atomic-structs
  > a3b564b Tag LabelSelector with +structType=atomic
  > 3aab1ee Bump to latest kube-openapi and SMD to pick up structType=atomic support
  > 829ed19 Merge pull request # 94170 from awly/spdy-pings
  > 5b968b2 Merge pull request # 94501 from ialidzhikov/nit/labels-staticcheck
  > 5f0d6cf spdy: add optional periodic Pings on the connection
  > 714f113 Merge pull request # 93214 from trashhalo/prefer-error
  > dd92ff6 Fix staging/src/k8s.io/apimachinery/pkg/labels golint findings
  > 2f44a17 Merge pull request # 93027 from ialidzhikov/enh/label-funcs
  > f2eff94 prefer NoError/Error over Nil/NotNil
  > 1173d23 Merge pull request # 93785 from SataQiu/fix-comment-20200807
  > 97afc01 Add metav1.SetMetaDataLabel func
  > d8e5c2b Merge pull request # 94476 from habibrosyad/patch-92402-12
  > 7913322 fix incorrect comment in runtime ObjectKind interface
  > e57c6de Merge pull request # 94491 from dashpole/consistent_quoting
  > 5dbc7bc fix vendor/k8s.io/apimachinery/pkg/runtime/serializer/versioning staticcheck
  > 2e9dd8b consistently use double quotes in proto files
  > 1eef857 Merge pull request # 94460 from wojtek-t/remove_default_conversions
  > f663465 Remove default conversions
  > 6084ad0 Merge pull request # 94387 from habibrosyad/patch-92402-9
  > fc49b38 Merge pull request # 94182 from mattfenwick/issue-94088
  > f58c7c2 fix vendor/k8s.io/apimachinery/pkg/conversion staticcheck
  > 22a90f1 modify DNS-1123 error messages to indicate that RFC 1123 is not followed exactly
  > ba0f2f0 Merge pull request # 93108 from lixiaobing1/lxb-HandleCrash2
  > c643b8b Merge pull request # 94317 from kevindelgado/draft/fix-fakeclock-reset
  > 6e7cb7c fix HandleCrash() order
  > 5e0d80e Fix FakeClock::Reset to always succeed
  > 94222d0 Merge pull request # 93250 from liggitt/unstructured-int-float
  > c43a9f0 Merge pull request # 93291 from dixudx/codecfactory_serializers
  > 88f29bb Handle int -> float conversion in FromUnstructured
  > 598f878 Merge pull request # 92987 from nikhita/cleanup-owners-apimachinery
  > 7976cfa remove serializers from codec factory
  > cde3cec Merge pull request # 92637 from phinphing/master
  > 89eaa6d apimachinery: remove inactive members from OWNERS
  > 65d7dbf Merge pull request # 92491 from BenTheElder/fuzz-only-test
  > 5dca623 fix typo in runtime/interfaces.go
  > f9108ab Merge pull request # 91602 from sxllwx/lock_free_broadcaster
  > 08191f1 disable goffuzz in binaries
  > f3a77ab Merge pull request # 94100 from habibrosyad/patch-92402-8
  > 289560e lock-free broadcaster, use chan to ensure thread safety
  > 1b2290d Merge pull request # 93809 from Howie66/chore-Correct-words
  > 683e506 fix vendor/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured/unstructuredscheme staticcheck
  > 8dfb339 Merge pull request # 93960 from habibrosyad/patch-92402-5
  > 43d5521 Format Codes
  > 61bb6d1 Merge pull request # 93871 from habibrosyad/patch-92402-4
  > 658f890 fix vendor/k8s.io/apimachinery/pkg/util/framer staticcheck
  > 2a67c66 Merge pull request # 93860 from habibrosyad/patch-92402-3
  > edb5786 fix vendor/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured staticcheck
  > 1bdd76d Merge pull request # 92823 from AliMirlou/patch-1
  > ebebea5 fix vendor/k8s.io/apimachinery/pkg/labels staticcheck
  > 9254095 Merge pull request # 94147 from liggitt/json-patch
  > 2bfbee4 Fix a typo in comment
  > 0cfc30a Update json-patch to v4.9.0 tagged release
  > 2c6e837 Merge pull request # 93867 from apelisse/update-smd
  > e75ffe4 Update SMD to v4.0.1 and kube-openapi
  > da970ee Merge pull request # 93810 from liggitt/json-patch-4.8.0
  > c3261aa Merge pull request # 93797 from liggitt/unwrap-net-errors
  > 5bab0c8 Update to json-patch 4.8.0
  > b8eb6aa [go1.15] Use errors.As to unwrap net errors
  > 945d4eb Merge pull request # 93264 from justaugustus/go115
  > 06799a5 generated: hack/update-vendor.sh
  > 71c5b9e [go1.15] go.mod: update to go1.15
  > 5a17a77 [go1.15] apimachinery/pkg/util/proxy: Drop identity transfer-encoding
  > b84716e Merge pull request # 93410 from nikhita/apimachinery-triage-labels
  > 4948a58 Revert "Merge pull request # 93156 from logicalhan/triage-api-machinery"
  > 3f0ac6a Merge pull request # 93156 from logicalhan/triage-api-machinery
  > 296e520 automatically assign triage labels to api-machinery tagged PRs
  > cc2fa4f Merge pull request # 92941 from tallclair/invalid-redirect
  > 8e7d6bb Merge pull request # 92919 from dashpole/update_cadvisor
  > a76b711 Don't return proxied redirects to the client
  > 8e13431 Merge pull request # 92768 from deads2k/security-contacts
  > a8c4c9d update cAdvisor to v0.37.0
  > 9894919 Merge pull request # 92661 from jpbetz/smd-bump-field-unsetting
  > 6047e48 update security contacts for apimachinery repos
bumping knative.dev/client 935c2a5...a54abbd:
  > a54abbd Update community files (# 1347)
  > e23b4d6 Update k8s dependencies to v0.20.7  (# 1344)

@psschwei could you test locally if its safe to merge this PR?

works locally
$ git checkout -b update-test
Switched to a new branch 'update-test'
$ git fetch upstream pull/29/head:update-deps-main
remote: Enumerating objects: 31, done.
remote: Counting objects: 100% (31/31), done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 16 (delta 8), reused 16 (delta 8), pack-reused 0
Unpacking objects: 100% (16/16), 21.71 KiB | 555.00 KiB/s, done.
From github.com:knative-sandbox/kn-plugin-quickstart
 * [new ref]         refs/pull/29/head -> update-deps-main
$ git rebase update-deps-main
Successfully rebased and updated refs/heads/update-test.
$ ./hack/build.sh
🚒 Update
go: downloading knative.dev/client v0.23.1-0.20210618090750-a54abbdfa1a2
go: downloading k8s.io/apimachinery v0.20.7
go: downloading knative.dev/pkg v0.0.0-20210614053220-ed09cd052101
go: downloading knative.dev/serving v0.23.1-0.20210614141420-380a090c2039
go: downloading k8s.io/api v0.20.7
go: downloading sigs.k8s.io/structured-merge-diff/v4 v4.0.3
go: downloading github.com/json-iterator/go v1.1.11
go: downloading k8s.io/client-go v0.20.7
go: downloading golang.org/x/sys v0.0.0-20210603125802-9665404d3644
go: downloading knative.dev/networking v0.0.0-20210614195820-29c1fb2f824d
go: downloading go.uber.org/atomic v1.8.0
go: downloading github.com/google/go-containerregistry v0.5.2-0.20210609162550-f0ce2270b3b4
go: downloading google.golang.org/genproto v0.0.0-20210602131652-f16073e35f0c
go: downloading github.com/prometheus/client_golang v1.11.0
go: downloading cloud.google.com/go v0.83.0
go: downloading google.golang.org/api v0.47.0
go: downloading github.com/prometheus/common v0.26.0
go: downloading github.com/sirupsen/logrus v1.8.1
🧽 Format
⚖ License
🚧 Compile
🧪 Test
────────────────────────────────────────────
Version:      v20210622-local-9882d1d
Build Date:   2021-06-22 16:11:13
Git Revision: 9882d1d
$ ./kn-quickstart kind
Running Knative Quickstart using Kind
Kind version is: kind v0.11.0 go1.15.13 linux/amd64
knative
Knative Cluster kind-knative already installed.
Delete and recreate [y/N]: y
deleting cluster...
Creating Kind cluster...
    Waiting on cluster to be ready...
Cluster created
Starting Knative Serving install...
    CRDs installed...
    Core installed...
Finished installing Knative Serving
Starting Networking layer install...
    Kourier installed...
    Ingress patched...
    Kourier service installed...
    Domain DNS set up...
Finished installing Networking layer
Starting Knative Eventing install...
    CRDs installed...
    Core installed...
    In-memory channel installed...
    Mt-channel broker installed...

/approve
/lgtm


jsx extension vs js

Hi,
Your components are with jsx extensions.
I would recommend to change it to normal js extensions due to the fact that jsx is now another transpiled feature of the new js (such as many more of es2015, es 2016 etc.).

Why?

It's a matter of convention. jsx today is just part of js and Facebook also recommended that js extension will be the convention also for jsx files.

Yes, truth is I'm writing no jsx extension anymore. Doing it tonight!

Ah, the ever changing practices :)

It's Facebook, so that's gonna happen quite often sadly

@javivelasco I think we can close this issue since its implemented in 0cb8d8bdb2f7587f2d4a4770c10346a9d2ef43ad

Yep, thanks!


github: workflows: Add a Bluetooth observer test case

Add a new Bluetooth Observer role test case, and at the same time consolidate the various test & platform options into a single twister invocation. The observer test is useful since it doesn't enable SMP, and would have helped catch a regression for EFR32 platforms.
https://github.com/zephyrproject-rtos/zephyr/issues/82569
https://github.com/zephyrproject-rtos/zephyr/pull/82575

Note: merging this should make the nightly build fail, but from where I stand that's a good thing since it'll show us when the issue has been fixed, e.g. when https://github.com/zephyrproject-rtos/zephyr/pull/82575 has been merged and our west.yml updated to include the fix.


Do a blog

It's pretty much ready for some demonstration.
We still need to get gradient and ImpW done first, but it'll be pretty quick.
However, dont know how to start with all this stuff... seriously need some help

Done


Eb dev

This just adds the code.  Let me know if the location is bad.
I didn't look carefully at how you're building the code.  I guess you're more familiar.  Avi suggested we have two targets for dealing with cascading or cascading 2 (this was built against cascading wip-2.0 from Wensel's ivy).  Can I talk one of you into updating the build?

can you update your commit range to merge into "kevinweil:eb-dev"?

Ok so this won't build if we don't add the cascading jars (or set up ivy. or maven). Cascading 1 being GPL, seems like we shouldn't... we should split up elephant-bird-gpl and elephant-bird.


Correcting Example 3

https://github.com/MicrosoftDocs/office-docs-powershell/issues/4894

Docs Build status updates of commit 513a1f0:
:clock10: Full build: the average full build time is 12 min(s) 9 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 513a1f0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOExternalUser.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit c1ca041:
:clock10: Full build: the average full build time is 12 min(s) 9 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit c1ca041:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOExternalUser.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9ea07b8:
:clock10: Full build: the average full build time is 12 min(s) 9 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 9ea07b8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOExternalUser.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


refine Window Executor Test

What problem does this PR solve?
Issue Number: close #5465
Problem Summary:
What is changed and how it works?

move WindowExecutorTest from dbms/src/WindowFunctions/tests to dbms/src/Flash/tests/
add test cases that executing window function concurrently.

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-unit-test

/merge

/rebuild

/run-integration-test


Shorten PPP

Codecov Report

Merging #271 (bcff5ee) into master (9dd7637) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #271   +/-   ##
=========================================
  Coverage     70.12%   70.12%
  Complexity      639      639
=========================================
  Files            95       95
  Lines          1968     1968
  Branches        266      266
=========================================
  Hits           1380     1380
  Misses          482      482
  Partials        106      106

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix Dart2 Types

Without this fix the method is failing silently and the stream never receives any value

@mravn-google done, PTAL

LGTM, thanks! Awaiting CI.

Published.


Voice language

Hi! I'm having issues with /voice command. When it works, it works great, but sometimes it not just transcribe, but also translate. For example I talk in english all the time, it properly transcribe it, but then also translate either to Russian or Ukranian 😅 In the logs it looks like:

USER В английско, искам, че да добавите поддержка за екстензията на пайтен файла на листата на дефолтната екстензия, която ще бъде процесирана.
To add support for Python files, we need to modify the cmd/code_compressor.py file. Specifically, we need to add '.py' to the list of default file types to process.

The last phase is accurate, but why it translated it...

Yes I have noticed this too. It would probably help to add a config option to set the language.

I added 2 things which should really help this:

The recent conversation is sent to Whisper as a "prompt". This will both give it a sense of the language you are using, but also show it some of the specific keywords and identifiers that you've been taking about.
I added --voice-language that lets you specify the language you want to use with an ISO 639-1 code.

This is available in the main branch. You can get it by installing the latest version from github:
python -m pip install git+https://github.com/paul-gauthier/aider.git

If you have a chance to try it, let me know if it works better for you.

I'm going to close this issue for now, but feel free to re-open or file a new issue any time.


Corrected action variable in PolicyAccessControl Debug impl

Current behavior

Proposed changes

Checks

[x] All commits in this Pull Request are signed and Verified by Github.
[ ] All commits in this Pull Request follow the Ockam commit message convention.
[X] There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
[X] I have read and accept the Ockam Community Code of Conduct.
[X] I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@younes-io Could you please accept the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@SanjoDeundiak why would I add you to the list of Contributors ? Also, I don't have your email, if that's required o;O
Sorry I'm confused... Should I add YOUR details or mine ?

@SanjoDeundiak why would I add you to the list of Contributors ? Also, I don't have your email, if that's required o;O
Sorry I'm confused... Should I add YOUR details or mine ?

Sorry, you need to add your details)

@SanjoDeundiak why would I add you to the list of Contributors ? Also, I don't have your email, if that's required o;O
Sorry I'm confused... Should I add YOUR details or mine ?

Sorry, you need to add your details)

Done. cf. https://github.com/build-trust/ockam/pull/7244

@younes-io thank you! I fixed the commit message to align with our convention, now we can land the PR

@younes-io thank you! I fixed the commit message to align with our convention, now we can land the PR

Sorry for that.. I didn't pay attention until I pushed xD but I tried to stick to that in the other PRs lol
thank you


Adds Docker deployment support to Raneto

This lets you simply:
docker build -t raneto .
docker run -d -e VIRTUALHOST=kb.mydomain.com -e PORT=3000 raneto

The configeration above is only an example and uses
autodock-paas
Otherwise just: docker run -d -p 3000:3000 raneto and hit http://<ip_of_docker_host>:3000/

Thank you for this,
In testing, I get it running with the following commands, ports appear to be forwarded, but localhost:3000 doesn't respond.
Can you help diagnose so I can verify and merge this in?
$ docker-machine create --driver virtualbox dev
$ eval "$(docker-machine env dev)"
$ docker build -t raneto .
$ docker run -d -p 3000 raneto
$ docker ps
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS                     NAMES
a66505f299c1        raneto              "npm start"         34 seconds ago      Up 21 seconds       <IP_ADDRESS>:32768->3000/tcp   thirsty_hoover

Oh you're on OS X with a virtualized/remote Docker Engine :) You'll have to use http://a.b.c.d:3000/ where a.b.c.d is the remote ip. I think docker-machine ip <machine_name> will give you that.

Ok, got the IP with your exact command.
Still empty reply from server though :/

Oh I'm sorry! I'm so used to my autodock-pass infrastructure :)
Try: docker run -d -p 3000:3000 raneto
Looks like I fubared that up!

Bingo, thanks for the quick assistance.
I should probably spend some time figuring out what I'm doing :)
If you'd like, update the docs as you see fit for the regular Docker and your autodock version
Merging

Okay sure! I'll do that with a follow up PR. I've already found Raneto quite useful and very easy to setup! The only feature it's missing is protected views; my intention was to spin up a private Raneto instance for internal use only via authenticated viewers :)

We might have that protected internal-only feature already, with config.js
Or does that not accomplish what you're looking to do?
Here's the combo and I'll update documentation to make it easier because it is confusing.
// Set to true to enable the web editor
allow_editing : true,

// Set to true to enable HTTP Basic Authentication
authentication : true,
credentials    : {
    username : 'admin',
    password : 'password'
}

I did this but it still lets unauthenticated users view the content; I'll
try again in an incognito session in case it was some silly cache thing :)
James Mills / prologic
E<EMAIL_ADDRESS>W: prologic.shortcircuit.net.au
On Sun, Jun 5, 2016 at 12:48 PM, Ryan Lelek<EMAIL_ADDRESS>wrote:

We might have that protected internal-only feature already, with config.js
Or does that not accomplish what you're looking to do?
Here's the combo and I'll update documentation to make it easier because
it is confusing.
// Set to true to enable the web editor
allow_editing : true,
// Set to true to enable HTTP Basic Authentication
authentication : true,
credentials    : {
username : 'admin',
password : 'password'
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gilbitron/Raneto/pull/124#issuecomment-223833433, or mute
the thread
https://github.com/notifications/unsubscribe/ABOv-iMViE7YT0TkutnBJTCwW3jciSogks5qIyfygaJpZM4IuIQ0
.

Ah yes, you're right.
Please see #106 and #112

Ahhh thanks :)
James Mills / prologic
E<EMAIL_ADDRESS>W: prologic.shortcircuit.net.au
On Sun, Jun 5, 2016 at 12:58 PM, Ryan Lelek<EMAIL_ADDRESS>wrote:

Ah yes, you're right.
Please see #106 https://github.com/gilbitron/Raneto/issues/106 and #112
https://github.com/gilbitron/Raneto/issues/112
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gilbitron/Raneto/pull/124#issuecomment-223834030, or mute
the thread
https://github.com/notifications/unsubscribe/ABOv-gf1t11Td1YA_QaJYYnn9UxrspTVks5qIyp6gaJpZM4IuIQ0
.


Bugifx: Index out of bounds in Server#extract_conn_info

WHAT is this pull request doing?
When we try to autodetect proxy protocol version we sometimes get a Index ouf of bounds because there isn't enough data on the socket for IO::Buffered#peek to read, so our peek[x,y] call raises.
This will add an overload #peek(size) to IO::Buffered which will ensure the buffer contains at least size bytes.
Maybe we'll get something similar in the stdlib in the future: crystal-lang/crystal#15075
HOW can this pull request be tested?
Run specs to verify #peek(size)…

Oups, forgot to run spec after list second fix.

When i try so send an MQTT ping without doing a proper connect first, i get stuck in peek and my client times out.
before, the connection factory was able to try and connect, and then send a connack letting the client know its not allowed.

also these look different now
2024-10-11T14:50:37.650125Z   INFO - lmq.server: Listening on [::1]:62815
2024-10-11T14:50:37.650135Z   INFO - lmq.server: Listening on [::1]:62814

When i try so send an MQTT ping without doing a proper connect first, i get stuck in peek and my client times out. before, the connection factory was able to try and connect, and then send a connack letting the client know its not allowed.

Probably related to read timeout in lavinmq.
I wonder if that spec is passing but for the wrong reason. I need to investigate that. I think the socket has been closed because of the bug this PR is trying to fix, not because the wrong mqtt packet was sent.

also these look different now
2024-10-11T14:50:37.650125Z   INFO - lmq.server: Listening on [::1]:62815
2024-10-11T14:50:37.650135Z   INFO - lmq.server: Listening on [::1]:62814

Different how? :)

also these look different now

2024-10-11T14:50:37.650125Z   INFO - lmq.server: Listening on [::1]:62815

2024-10-11T14:50:37.650135Z   INFO - lmq.server: Listening on [::1]:62814

Different how? :)

The [::1]:62815 i think... but maybe its just my spec 😅

The [::1]:62815 i think... but maybe its just my spec 😅

I think it's related to other changes, like the uniformed logging.

I would probably just check the length of the peek buffer to avoid the indexerror. I dont know when only part of the Proxy protocol header would be sent, so if the buffer isnt long enough we can be certain that it isnt a a proxy protocol at least

Actually, just use Slice#[]?, https://devdocs.io/crystal/slice#[]%3F(start%3AInt%2Ccount%3AInt)%3ASlice(T)|Nil-instance-method

Yeah, but I thought it maybe could be a contribution to the stdlib.


Extension failed to load but works in debug without issue

Category

[x] Question
[ ] Typo
[ ] Additional article idea

Question
I have a an app package that has several web parts and an application extension. When running in development/debug mode it works fine. When I bundle the app and deploy I get:
Uncaught (in promise) Error: Failed to create application customizer 'ClientSideExtension.ApplicationCustomizer.a319c905-0c40-478b-9866-895c6e7e09d3'. Error information is 'Extension failed to load for componentId "a319c905-0c40-478b-9866-895c6e7e09d3".'.
    at sp-pages-assembly_en-us_3a7c8205e7e2b619a5038473c7f52b6d.js:1
    at async Promise.all (index 0)

This error is not giving me an indication as to what the actual error is. When I run gulp serve and access the extension via ?debugManifestsFile=..... It works without issues. How can I figure out what is going on?
Environment details (development & target environment)
This is running SPFX 1.11 in SharePoint online.

I've got the same Problem.
I tried to setup the spfx-announcements webpart. In gulp serve everything is working as expected. Once the solution is packaged and deployed, the error occurs:
sp-pages-assembly_de-de_017c1eaa45854b943ce72ed2f66bbe51.js:65 Uncaught (in promise) Error: Failed to create application customizer 'ClientSideExtension.ApplicationCustomizer.21f58d40-a86a-419a-9478-84f78b2bf638'. Error information is 'Extension failed to load for componentId "21f58d40-a86a-419a-9478-84f78b2bf638".'.     at sp-pages-assembly_de-de_017c1eaa45854b943ce72ed2f66bbe51.js:65     at async Promise.all (index 0)

I have the same error message when I deploy an application customizer package

same error in my side... SPFX 1.11.0 node 10.24.1 LTS.
Since one month...
Any news on that?

Ultimately I just  kept rebuilding, cleaning, npm install all packages Until it worked. No specific solution sorry.

On my side the problem was caused by react and reactdom dependencies. I moved them to the dev dependencies and rebuild…
That solved my issue.

This one is similar to #7564.
@theitfactor - could you check if you're using @microsoft/sp-http or some other modules without installing them (or maybe you install them as devDependencies when they should be a part of the bundle)?


在kb_chat.py中加入reranker，会在向量数据库查询过程中崩溃

问题描述 / Problem Description
在kb_chat.py中加入reranker，实际只引用了sentence_transformers里面的CrossEncoder
from sentence_transformers import CrossEncoder
就会在RAG查询中报错如下：

2024-08-01 17:31:16,555 httpx        12943 INFO     HTTP Request: POST http://<IP_ADDRESS>:3000/v1/embeddings "HTTP/1.1 200 OK"
2024-08-01 17:31:16.564 Uncaught app exception
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/httpx/_transports/default.py", line 69, in map_httpcore_exceptions
yield
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/httpx/_transports/default.py", line 113, in iter
for part in self._httpcore_stream:
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/httpcore/_sync/connection_pool.py", line 367, in iter
raise exc from None
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/httpcore/_sync/connection_pool.py", line 363, in iter
for part in self._stream:
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/httpcore/_sync/http11.py", line 349, in iter
raise exc
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/httpcore/_sync/http11.py", line 341, in iter
for chunk in self._connection._receive_response_body(**kwargs):
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/httpcore/_sync/http11.py", line 210, in _receive_response_body
event = self._receive_event(timeout=timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/httpcore/_sync/http11.py", line 220, in _receive_event
with map_exceptions({h11.RemoteProtocolError: RemoteProtocolError}):
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/contextlib.py", line 158, in exit
self.gen.throw(typ, value, traceback)
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/httpcore/_exceptions.py", line 14, in map_exceptions
raise to_exc(exc) from exc
httpcore.RemoteProtocolError: peer closed connection without sending complete message body (incomplete chunked read)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/Users/wenchang/Desktop/langchain/Langchain-Chatchat/libs/chatchat-server/chatchat/webui_pages/kb_chat.py", line 225, in kb_chat
for d in client.chat.completions.create(messages=messages, model=llm_model, stream=True, extra_body=extra_body):
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/openai/_streaming.py", line 46, in iter
for item in self._iterator:
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/openai/_streaming.py", line 58, in stream
for sse in iterator:
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/openai/_streaming.py", line 50, in _iter_events
yield from self._decoder.iter_bytes(self.response.iter_bytes())
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/openai/_streaming.py", line 280, in iter_bytes
for chunk in self._iter_chunks(iterator):
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/openai/_streaming.py", line 291, in _iter_chunks
for chunk in iterator:
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/httpx/_models.py", line 829, in iter_bytes
for raw_bytes in self.iter_raw():
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/httpx/_models.py", line 883, in iter_raw
for raw_stream_bytes in self.stream:
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/httpx/_client.py", line 126, in iter
for chunk in self._stream:
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/httpx/_transports/default.py", line 112, in iter
with map_httpcore_exceptions():
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/contextlib.py", line 158, in exit
self.gen.throw(typ, value, traceback)
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/httpx/_transports/default.py", line 86, in map_httpcore_exceptions
raise mapped_exc(message) from exc
httpx.RemoteProtocolError: peer closed connection without sending complete message body (incomplete chunked read)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 600, in _run_script
exec(code, module.dict)
File "/Users/wenchang/Desktop/langchain/Langchain-Chatchat/libs/chatchat-server/chatchat/webui.py", line 71, in
kb_chat(api=api)
File "/Users/wenchang/Desktop/langchain/Langchain-Chatchat/libs/chatchat-server/chatchat/webui_pages/kb_chat.py", line 236, in kb_chat
st.error(e.body)
^^^^^^
AttributeError: 'RemoteProtocolError' object has no attribute 'body'

复现问题的步骤 / Steps to Reproduce

我在Mac电脑上源码安装了chatchat与one-api
想打开reranker，自己写的单元测试或者直接将注释的reranker部分打开，都会出上边的错误

预期的结果 / Expected Result
可以使用reranker
实际结果 / Actual Result
发生错误
环境信息 / Environment Information

Langchain-Chatchat 版本 / commit 号：master分支
部署方式：源码部署
使用的模型推理框架（Xinference / Ollama / OpenAI API 等）：Xinference / Model serve method（Xinference / Ollama / OpenAI API, etc.): Xinference
使用的 LLM 模型：one-api的GLM
使用的 Embedding 模型（bge-large-zh-v1.5 / m3e-base 等）：GLM的embedding2
使用的向量库类型 ：faiss
操作系统及版本 / Operating system and version: MacOS
Python 版本 / Python version: 3.8
推理使用的硬件（GPU / CPU / MPS / NPU 等） / Inference hardware (GPU / CPU / MPS / NPU, etc.): CPU
其他相关环境信息 / Other relevant environment information:

附加信息 / Additional Information

reranker 已经重新添加，方便的话可以再测试一下。


azure-cli azure-cli-core version bump

This is for the next release

View a preview at https://prompt.ws/r/Azure/azure-cli/5534
This is an experimental preview for @microsoft users.


[Enhancement] multi node BERT pre-training with horovod

Description
This PR introduces run_pretraining_hvd.py which uses horovd for multi-gpu/multi-host training. With synthetic data (bs=24, seq_len=512), the training speedup is 58x using 64 GPUs (p3dn.24xlarge instances).
This PR also

refactors the exiting run_pretraining.py script.
added more script tests

Checklist
Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[ ] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Job PR-665/5 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-665/5/index.html

Job PR-665/6 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-665/6/index.html

Job PR-665/8 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-665/8/index.html

Job PR-665/9 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-665/9/index.html

Follow up tasks: #673 #674 #675

Job PR-665/10 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-665/10/index.html


random seed

Hello, I would also like to ask again if the random_seed for the data in this article uses 7580? The results I got from the 7580 don't meet the article's metrics.

Hi
I remember the random number was generated randomly, and the 7580 was from the R2GenCMN work.
Best regards


Add test for negative nanos overflow to Time::at

Followup to https://github.com/artichoke/artichoke/pull/1142.
cc @michaeltaras

Thanks for cleaning this up @lopopolo.  I like the idea of very clearly explaining all the math in there.


🎉 Use hyper-latest.now.sh

Shiny new https://hyper-latest.now.sh
https://github.com/zeit/hyper-latest
This won't happen again https://github.com/zeit/hyper/pull/1679

Should https://hyper-news.now.sh/current use this URL https://hyper-latest.now.sh/release?

Don't think that's needed 🤔


[FEAT] Remove prebuilt aapt binaries

Is your feature request related to a problem? Please describe.
Apktool has prebuilt aapt binaries for compiling resources. Those are not used by ReVanced Manager and unnecessarily increases the total APK size.
Describe the solution you'd like
Remove prebuilt aapt binaries from source code (without breaking patcher) or find a way to not include binaries in manager.

This is directly caused by apktool version controlling the binaries. The CLI needs them, while the mamager ships it's own binaries, ideally the CLI ships it's own too instead of apktools prebuild binaries.

This is directly caused by apktool version controlling the binaries. The CLI needs them, while the mamager ships it's own binaries, ideally the CLI ships it's own too instead of apktools prebuild binaries.

Why not just use the patched builds in both.

Android handles binaries differently than Java, they have to be shipped how Android specifies to, while for Java you can ship them via the resources.

Solved by manually excluding binaries in build script.


NIFI-10358 Update CaptureChangeMySQL to use SSL JDBC properties

Summary
NIFI-10358 Updates the CaptureChangeMySQL Processor apply SSL Mode and SSL Context Service configuration settings to the enrichment JDBC connection.
In addition to the primary binary log connection, the CaptureChangeMySQL Processor maintains a secondary JDBC connection to the MySQL server when configured with a Distributed Map Cache Client to provide schema information.
Recent versions of the MySQL Connector for Java attempt to negotiate a TLS connection in the default configuration, based on MySQL server support for TLS. MySQL JDBC Driver versions prior to 8.0.28 have TLS 1.0 and TLS 1.1 enabled, which can result in connection attempts throwing an SSLException when running Apache NiFi on versions of Java that disable those deprecated TLS protocol versions.
In addition to TLS protocol negotiation issues, the CaptureChangeMySQL Processor does not support the option to configure JDBC connection properties. Updating the Processor to set MySQL JDBC connection properties based on the SSL Mode selected provides a more intuitive configuration and improves support for TLS negotiation using certificates issued by private certificate authorities.
The implementation leverages several MySQL Connector Security Properties that have been deprecated, but remain supported. This approach enables compatibility with a wide range of MySQL JDBC Driver versions.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[X] Apache NiFi Jira issue created

Pull Request Tracking

[X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[X] Pull Request based on current revision of the main branch
[X] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[X] Build completed using mvn clean install -P contrib-check

[X] JDK 8
[X] JDK 11
[X] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

+1 LGTM, thanks for the improvement! Merging to main


add first unit test

Add our first ever unit test function from useful_functions.py
This function used to test split_DATE() function

Test function can now be used with our CI

Solved one of the test function in #44