HBASE-28064:Implement truncate_region command

HBASE-28064:Implement truncate_region command to truncate region directly from FS
Implemented truncate_region command and added unit/system tests.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m  8s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 44s
master passed

+1 :green_heart:
compile
4m 36s
master passed

+1 :green_heart:
checkstyle
1m 35s
master passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
5m 22s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 38s
the patch passed

+1 :green_heart:
compile
4m 35s
the patch passed

+1 :green_heart:
cc
4m 35s
the patch passed

+1 :green_heart:
javac
4m 35s
the patch passed

-0 :warning:
checkstyle
0m 16s
hbase-client: The patch generated 8 new + 4 unchanged - 0 fixed = 12 total (was 4)

-0 :warning:
checkstyle
0m 35s
hbase-server: The patch generated 2 new + 7 unchanged - 0 fixed = 9 total (was 7)

-0 :warning:
rubocop
0m 10s
The patch generated 8 new + 766 unchanged - 0 fixed = 774 total (was 766)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
9m 13s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
hbaseprotoc
1m 55s
the patch passed

-1 :x:
spotless
0m 19s
patch has 63 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
5m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 48s
The patch does not generate ASF License warnings.

49m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux 74972bea0cfb 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 391dfda6ad

Default Java
Eclipse Adoptium-11.0.17+8

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

rubocop
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
80 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 47s
master passed

+1 :green_heart:
compile
2m 26s
master passed

+1 :green_heart:
shadedjars
4m 52s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 34s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s
the patch passed

+1 :green_heart:
compile
2m 25s
the patch passed

+1 :green_heart:
javac
2m 25s
the patch passed

+1 :green_heart:
shadedjars
4m 50s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 38s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 29s
hbase-client in the patch passed.

-1 :x:
unit
225m  2s
hbase-server in the patch failed.

+1 :green_heart:
unit
8m 46s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m  4s
hbase-shell in the patch passed.

272m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4de732e8260b 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 391dfda6ad

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/testReport/

Max. process+thread count
4271 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 41s
master passed

+1 :green_heart:
compile
4m 34s
master passed

+1 :green_heart:
checkstyle
1m 34s
master passed

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
5m 22s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 34s
the patch passed

+1 :green_heart:
compile
4m 35s
the patch passed

+1 :green_heart:
cc
4m 35s
the patch passed

+1 :green_heart:
javac
4m 35s
the patch passed

+1 :green_heart:
checkstyle
1m 33s
the patch passed

-0 :warning:
rubocop
0m 11s
The patch generated 8 new + 766 unchanged - 0 fixed = 774 total (was 766)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
9m  8s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
hbaseprotoc
1m 54s
the patch passed

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
5m 56s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 47s
The patch does not generate ASF License warnings.

49m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux ecff407a0924 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 391dfda6ad

Default Java
Eclipse Adoptium-11.0.17+8

rubocop
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
80 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 14s
master passed

+1 :green_heart:
compile
1m 47s
master passed

+1 :green_heart:
shadedjars
5m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  8s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 14s
the patch passed

+1 :green_heart:
compile
1m 47s
the patch passed

+1 :green_heart:
javac
1m 47s
the patch passed

+1 :green_heart:
shadedjars
5m  8s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 25s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 21s
hbase-client in the patch passed.

-1 :x:
unit
217m 47s
hbase-server in the patch failed.

+1 :green_heart:
unit
6m 33s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 42s
hbase-shell in the patch passed.

260m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5128cba3b006 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 391dfda6ad

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/testReport/

Max. process+thread count
4595 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 48s
master passed

+1 :green_heart:
compile
2m 25s
master passed

+1 :green_heart:
shadedjars
4m 53s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 36s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 40s
the patch passed

+1 :green_heart:
compile
2m 26s
the patch passed

+1 :green_heart:
javac
2m 26s
the patch passed

+1 :green_heart:
shadedjars
4m 49s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 38s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 33s
hbase-client in the patch passed.

-1 :x:
unit
224m 18s
hbase-server in the patch failed.

+1 :green_heart:
unit
8m 30s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 44s
hbase-shell in the patch passed.

272m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f5705fc5cb1b 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 391dfda6ad

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/testReport/

Max. process+thread count
4594 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 52s
master passed

+1 :green_heart:
compile
5m 36s
master passed

+1 :green_heart:
checkstyle
1m 32s
master passed

+1 :green_heart:
spotless
0m 56s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
7m 13s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  5s
the patch passed

+1 :green_heart:
compile
7m 46s
the patch passed

+1 :green_heart:
cc
7m 46s
the patch passed

+1 :green_heart:
javac
7m 46s
the patch passed

+1 :green_heart:
checkstyle
2m 30s
the patch passed

-0 :warning:
rubocop
0m 18s
The patch generated 8 new + 766 unchanged - 0 fixed = 774 total (was 766)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
14m 16s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
hbaseprotoc
3m  3s
the patch passed

+1 :green_heart:
spotless
1m 17s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
9m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 59s
The patch does not generate ASF License warnings.

72m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux a6ba8bf3d82b 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 391dfda6ad

Default Java
Eclipse Adoptium-11.0.17+8

rubocop
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
80 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 37s
master passed

+1 :green_heart:
compile
2m 23s
master passed

+1 :green_heart:
shadedjars
4m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 33s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 40s
the patch passed

+1 :green_heart:
compile
2m 24s
the patch passed

+1 :green_heart:
javac
2m 24s
the patch passed

+1 :green_heart:
shadedjars
4m 48s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 38s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 29s
hbase-client in the patch passed.

-1 :x:
unit
218m 43s
hbase-server in the patch failed.

+1 :green_heart:
unit
8m 34s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m  4s
hbase-shell in the patch passed.

265m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1b5f3089cbd8 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 391dfda6ad

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/testReport/

Max. process+thread count
4248 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 49s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 43s
master passed

+1 :green_heart:
compile
2m 16s
master passed

+1 :green_heart:
shadedjars
6m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 40s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 44s
the patch passed

+1 :green_heart:
compile
2m 13s
the patch passed

+1 :green_heart:
javac
2m 13s
the patch passed

+1 :green_heart:
shadedjars
5m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 24s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 27s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 28s
hbase-client in the patch passed.

-1 :x:
unit
223m 21s
hbase-server in the patch failed.

+1 :green_heart:
unit
6m 37s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 41s
hbase-shell in the patch passed.

271m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6d9597def5b8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 391dfda6ad

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/testReport/

Max. process+thread count
4632 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

recheck

The failed tests is not looking related to my changes. Not sure if its a transient issue.

Thanks for submitting this PR, looks like a great idea. I have a few questions/comments after an initial review. Please reply on those so that we can get this progressing. Thanks, Wellington.

Thanks for submitting this PR, looks like a great idea. I have a few questions/comments after an initial review. Please reply on those so that we can get this progressing. Thanks, Wellington.

Thanks @wchevreuil for reviewing this. I have incorporated most of the review comments and answered the questions inline. Can you please check?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  1s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 38s
master passed

+1 :green_heart:
compile
4m 35s
master passed

+1 :green_heart:
checkstyle
1m 31s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
5m 23s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 33s
the patch passed

+1 :green_heart:
compile
4m 35s
the patch passed

+1 :green_heart:
cc
4m 35s
the patch passed

+1 :green_heart:
javac
4m 35s
the patch passed

+1 :green_heart:
checkstyle
1m 27s
the patch passed

-0 :warning:
rubocop
0m 11s
The patch generated 8 new + 766 unchanged - 0 fixed = 774 total (was 766)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
9m  6s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
hbaseprotoc
1m 54s
the patch passed

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
5m 54s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 47s
The patch does not generate ASF License warnings.

49m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux b9e338718004 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 391dfda6ad

Default Java
Eclipse Adoptium-11.0.17+8

rubocop
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
82 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 36s
master passed

+1 :green_heart:
compile
2m 24s
master passed

+1 :green_heart:
shadedjars
4m 49s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 32s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 33s
the patch passed

+1 :green_heart:
compile
2m 24s
the patch passed

+1 :green_heart:
javac
2m 24s
the patch passed

+1 :green_heart:
shadedjars
4m 48s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 39s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 28s
hbase-client in the patch passed.

-1 :x:
unit
224m 43s
hbase-server in the patch failed.

+1 :green_heart:
unit
8m 35s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m  5s
hbase-shell in the patch passed.

271m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d76a42a61e05 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 391dfda6ad

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/testReport/

Max. process+thread count
4226 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 47s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 24s
master passed

+1 :green_heart:
compile
2m 46s
master passed

+1 :green_heart:
shadedjars
7m  4s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 18s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 14s
the patch passed

+1 :green_heart:
compile
2m 40s
the patch passed

+1 :green_heart:
javac
2m 40s
the patch passed

+1 :green_heart:
shadedjars
7m  0s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 43s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 51s
hbase-client in the patch passed.

-1 :x:
unit
276m 59s
hbase-server in the patch failed.

+1 :green_heart:
unit
7m  2s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 44s
hbase-shell in the patch passed.

329m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6da886e71ad5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 391dfda6ad

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/testReport/

Max. process+thread count
4619 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks @vaijosh for working on this. Sorry for late review. I have added a few comments/suggestions. Please check.

Thanks @vaijosh for working on this. Sorry for late review. I have added a few comments/suggestions. Please check.
Thanks @NihalJain for the suggestions.
Yes I will address your few review comments in the next commit. I have replied to some of the review comments, which I felt are not addressable. Can you please take a look and let me know if I am missing some thing?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 28s
master passed

+1 :green_heart:
compile
6m 58s
master passed

+1 :green_heart:
checkstyle
1m 49s
master passed

+1 :green_heart:
spotless
0m 48s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
6m 46s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
compile
6m 11s
the patch passed

+1 :green_heart:
cc
6m 11s
the patch passed

+1 :green_heart:
javac
6m 11s
the patch passed

-0 :warning:
checkstyle
0m 43s
hbase-server: The patch generated 10 new + 8 unchanged - 0 fixed = 18 total (was 8)

-0 :warning:
rubocop
0m 15s
The patch generated 8 new + 766 unchanged - 0 fixed = 774 total (was 766)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 26s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
hbaseprotoc
2m  7s
the patch passed

-1 :x:
spotless
0m 44s
patch has 63 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
7m 24s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 41s
The patch does not generate ASF License warnings.

64m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux 418b9a22cf39 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dde504ce48

Default Java
Eclipse Adoptium-11.0.17+8

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

rubocop
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
81 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Skimmed latest push and updated comments. Looks fine high level.
Also one suggestion, please avoid force push and keep just 1 commit. It's very hard to review what all changed. We anyways squash and merge, so should be fine to have several commits.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 10s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 38s
master passed

+1 :green_heart:
compile
2m 49s
master passed

+1 :green_heart:
shadedjars
5m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 32s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 54s
the patch passed

+1 :green_heart:
compile
3m  2s
the patch passed

+1 :green_heart:
javac
3m  2s
the patch passed

+1 :green_heart:
shadedjars
6m  1s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 38s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 56s
hbase-client in the patch passed.

-1 :x:
unit
242m 57s
hbase-server in the patch failed.

+1 :green_heart:
unit
6m 59s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
9m 19s
hbase-shell in the patch passed.

293m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 17d1141db998 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dde504ce48

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/testReport/

Max. process+thread count
4706 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 45s
master passed

+1 :green_heart:
compile
2m 18s
master passed

+1 :green_heart:
shadedjars
6m  3s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  9s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 11s
the patch passed

+1 :green_heart:
compile
1m 52s
the patch passed

+1 :green_heart:
javac
1m 52s
the patch passed

+1 :green_heart:
shadedjars
6m 13s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 30s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 38s
hbase-client in the patch passed.

-1 :x:
unit
248m 24s
hbase-server in the patch failed.

+1 :green_heart:
unit
7m  5s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
8m  9s
hbase-shell in the patch passed.

295m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a9827d1d7e0e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dde504ce48

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/testReport/

Max. process+thread count
4492 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 46s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 28s
master passed

+1 :green_heart:
compile
5m 24s
master passed

+1 :green_heart:
checkstyle
1m 46s
master passed

+1 :green_heart:
spotless
0m 53s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
6m 29s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 20s
the patch passed

+1 :green_heart:
compile
5m 41s
the patch passed

+1 :green_heart:
cc
5m 41s
the patch passed

+1 :green_heart:
javac
5m 41s
the patch passed

+1 :green_heart:
checkstyle
1m 38s
the patch passed

-0 :warning:
rubocop
0m 15s
The patch generated 8 new + 766 unchanged - 0 fixed = 774 total (was 766)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
10m 18s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
hbaseprotoc
2m  7s
the patch passed

+1 :green_heart:
spotless
0m 52s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
7m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 43s
The patch does not generate ASF License warnings.

58m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux 733700d6b4c7 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dde504ce48

Default Java
Eclipse Adoptium-11.0.17+8

rubocop
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
87 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 44s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 58s
master passed

+1 :green_heart:
compile
2m 16s
master passed

+1 :green_heart:
shadedjars
5m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 28s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 34s
the patch passed

+1 :green_heart:
compile
2m 14s
the patch passed

+1 :green_heart:
javac
2m 14s
the patch passed

+1 :green_heart:
shadedjars
6m 20s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 33s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 39s
hbase-client in the patch passed.

-1 :x:
unit
235m 56s
hbase-server in the patch failed.

+1 :green_heart:
unit
7m  6s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 48s
hbase-shell in the patch passed.

284m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7ddefd07bc91 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dde504ce48

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/testReport/

Max. process+thread count
4510 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  2s
master passed

+1 :green_heart:
compile
2m 37s
master passed

+1 :green_heart:
shadedjars
5m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 34s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 11s
the patch passed

+1 :green_heart:
compile
2m 30s
the patch passed

+1 :green_heart:
javac
2m 30s
the patch passed

+1 :green_heart:
shadedjars
5m 55s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 41s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 55s
hbase-client in the patch passed.

+1 :green_heart:
unit
243m  8s
hbase-server in the patch passed.

+1 :green_heart:
unit
6m 45s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 53s
hbase-shell in the patch passed.

292m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b4bc7777d386 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dde504ce48

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/testReport/

Max. process+thread count
4715 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Skimmed latest push and updated comments. Looks fine high level.
Also one suggestion, please avoid force push and keep just 1 commit. It's very hard to review what all changed. We anyways squash and merge, so should be fine to have several commits.

Thanks @NihalJain for the suggestion.
I was more following "amend commit" workflow (similar to Gerrit). I was under impression that recent changes can be checked using compare link next to commit e.g. this.
But if this is not convenient, next time onwards I can do separate commits, and we can squash commits in the end.

But if this is not convenient, next time onwards I can do separate commits, and we can squash commits in the end.
Yes it is a little inconvenient to compare across previous commits. And thanks for considering this.

I have approved the PR. Looks good to me, please check once on users field comment before commit.

Hi @NihalJain
Thanks a lot for approving the PR.

please check once on users field comment before commit.
Yes this was valid concern. But I have simulated and tested crash scenario and checked that we don't get NPE.
1.Started Hbase in debug mode
2.Kept breakpoint in TRUNCATE_REGION_MAKE_OFFLINE block.
3.Executed truncate_region command.
4.When breakpoint was hit, killed the hbase processes using kill -9 command.
5.Kept break points in AbstractStateMachineRegionProcedure.deserializeStateData and AbstractStateMachineTableProcedure constructor.
6.Started hbase in debugger mode and attached debugger. Verified that breakpoints were hit and "region" and "user" fields were populated correctly. Also verified that truncate operation was resumed from the state and eventually it was successful.

Awesome thanks for the due diligence and again thanks for working on this one. :)

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 39s
master passed

+1 :green_heart:
compile
4m 35s
master passed

+1 :green_heart:
checkstyle
1m 36s
master passed

-1 :x:
spotless
0m 42s
branch has 1 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
5m 23s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
4m 37s
the patch passed

+1 :green_heart:
cc
4m 37s
the patch passed

+1 :green_heart:
javac
4m 37s
the patch passed

+1 :green_heart:
checkstyle
1m 32s
the patch passed

-0 :warning:
rubocop
0m 11s
The patch generated 8 new + 766 unchanged - 0 fixed = 774 total (was 766)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
9m 13s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
hbaseprotoc
1m 55s
the patch passed

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
5m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 44s
The patch does not generate ASF License warnings.

50m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux d91bc9c9f138 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4b70e59697

Default Java
Eclipse Adoptium-11.0.17+8

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/artifact/yetus-general-check/output/branch-spotless.txt

rubocop
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
81 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 29s
master passed

+1 :green_heart:
compile
1m 47s
master passed

+1 :green_heart:
shadedjars
5m 14s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  8s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 17s
the patch passed

+1 :green_heart:
compile
1m 47s
the patch passed

+1 :green_heart:
javac
1m 47s
the patch passed

+1 :green_heart:
shadedjars
5m 11s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 25s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 21s
hbase-client in the patch passed.

-1 :x:
unit
221m 11s
hbase-server in the patch failed.

+1 :green_heart:
unit
6m 52s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 43s
hbase-shell in the patch passed.

264m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux fd2daff02679 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4b70e59697

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/testReport/

Max. process+thread count
4611 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 45s
master passed

+1 :green_heart:
compile
2m 26s
master passed

+1 :green_heart:
shadedjars
4m 53s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 36s
the patch passed

+1 :green_heart:
compile
2m 22s
the patch passed

+1 :green_heart:
javac
2m 22s
the patch passed

+1 :green_heart:
shadedjars
5m 18s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 47s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 44s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
2m 11s
hbase-client in the patch passed.

+1 :green_heart:
unit
261m  5s
hbase-server in the patch passed.

+1 :green_heart:
unit
8m 50s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 17s
hbase-shell in the patch passed.

310m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5462

JIRA Issue
HBASE-28064

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7c7fdad00c13 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4b70e59697

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/testReport/

Max. process+thread count
4293 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Support linux sh post deployment scripts

Kudu supports cmd bat and ps1 scripts for post deployment.
See Kudu.Core/Helpers/PostDeploymentHelper.cs
            // Find all post action scripts and order file alphabetically for each folder
            return Directory.GetFiles(postDeploymentPath, "*", SearchOption.TopDirectoryOnly)
                                    .Where(f => f.EndsWith(".cmd", StringComparison.OrdinalIgnoreCase)
                                        || f.EndsWith(".bat", StringComparison.OrdinalIgnoreCase)
                                        || f.EndsWith(".ps1", StringComparison.OrdinalIgnoreCase))
                                    .OrderBy(n => n);

Can Linux scripts be supported for Linux containers on Azure ?
For a Python / Django webapp I want to be able to either move an sqlite dabatase to /tmp or change the permissions on a site folder as the database appears locked,

Here is an example of a script called mvdb.sh that needs to be run post deployment:
#/bin/bash

# Copy the database to /tmp due to permissions issues
cp /home/site/wwwroot/db.sqlite3 /tmp

This has been handled in https://github.com/Azure-App-Service/KuduLite/pull/30.

Hi
If the problem persists and is related to running it on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


HTMLField not working in custom plugin

Using the HTMLField in a custom plugin raises the error:
TypeError: from_db_value() missing 1 required positional argument: 'context'

Changing the from_db_value method to the below definition fixes the issue.
def from_db_value(self, value, expression, connection, context=None):

See https://github.com/divio/djangocms-text-ckeditor/pull/510

Ah thanks! I must have got too excited with djangocms release yesterday adding support for Django 3. http://docs.django-cms.org/en/latest/upgrade/3.7.2.html

This issue blocks to upgrade to 3.7.2 for me.

Please help i have SAME ISSUE !!!! PLEASE URGENT !!! Many thanks for help !!!

Looks like is fixed on this commit https://github.com/divio/djangocms-text-ckeditor/commit/48fc9522f612d41e70d6a844fd53dd1026318654

@alvaromlg correct
It's been fixed in 3.9.1
Closing the issue


No module named 'telegram'

After performing all the steps up to the requirements installing, when attempting to execute the bot, this error occurs:
root:~/TweetBot# python3.6 TweetBot/main.py
Traceback (most recent call last):
  File "TweetBot/main.py", line 1, in <module>
    import telegram
ModuleNotFoundError: No module named 'telegram'

This is the produced log whilst installing the requirements:
https://www.toptal.com/developers/hastebin/ikaqisetok.apache
Wish to seek your advice in resolving the issue

Update:
In case if needed, here are the slightly modified steps used, whilst trying to resolve that issue:
cd TweetBot
python3 -m venv telegramtwitterenv

. telegramtwitterenv/bin/activate

pip install -r requirements.txt
pip install telegram

python3.6 main.py

Looks like your pip is using an older version of python you have check it by running
ls -l which pip`` to confirm. You can just run python3.6 -m pip install -r requirements.txt and run main.py again.

That resolved that error, thanks!
Unfortunately, there's another snag now
Retrieved the channel ID via @getidsbot, and neither of the variations below seem to be working:
export CHAT_ID="-1001720436594"

export CHAT_ID=-1001720436594

export CHAT_ID="1720436594"

An attempt has also been made to use the human readable form of the public channel's link to no avail.
Error displayed is:
Traceback (most recent call last):
  File "TweetBot/main.py", line 6, in <module>
    import tweet_scrape as ts
  File "/root/Telegram_TweetBot/TweetBot/tweet_scrape.py", line 13, in <module>
    chatid = int(os.getenv("CHAT_ID"))
TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'


Add: Kubernetes recommanded labels

Pull Request Motivation
When we used a policies manager as Kyverno, it's usefull to be able to add a common labels on all resources created by the chart in order to respect the policy.
Kind
feature
Release Note

Helm: Added a new parameter `commonLabels` which gives you the capability to add the same label on all the resource deployed by the chart.

Thank you for the PR and interest in cert-manager project!
At the moment all resources created by this Helm char should labelled by app: cert-manager. Is this common label not sufficient?

No, i want to set personal named labels (as team, service, env, vertical, group, product ...) to respect internal policies set up with Kyverno

I second the use case explained by @thib-mary.
@irbekrm, any chance to see this change merged in the main branch? That'd avoid us the need for forking this chart internally just to add a couple of labels...

@irbekrm
Can I have feedback on this request?

@thib-mary please take a look at #5277, it is a duplicate of this PR, but I think putting this option under the global field in Values makes more sense?

/ok-to-test

/retest

@thib-mary please take a look at #5277, it is a duplicate of this PR, but I think putting this option under the global field in Values makes more sense?

It's already the case no ?

EDIT: Needs some extra research:

does it conflict with other label fields? => Normaly no.

do resolver pods also get these labels? => What do you mean, i don't understand.

@inteon

Note: the resources that are created dynamically by cert-manager will not have these labels set.
eg. podTemplate/ ingressTemplate in ACMEChallengeSolverHTTP01Ingress
https://cert-manager.io/docs/reference/api-docs/#acme.cert-manager.io/v1.ACMEChallengeSolverHTTP01Ingress
eg. secretTemplate in CertificateSpec
https://cert-manager.io/docs/reference/api-docs/#cert-manager.io/v1.CertificateSpec

Thank for pointing that out, it's ok, we can manage these special cases @inteon

/approve
/lgtm


Toolbar icons

Made toolbar have login/logout, import/export icons when screen is small
Made the class search resize to fit on small screens
Added scrollbar if the class search can't fit the filters (I know we have disliked scroll bars in the past, so if this looks terrible we should remove it, it's the last commit)

I'm too tired, and this is noncritical for MVP, sorry... I do appreciate it though and will take a look later.

don't merge this yet something is wrong with it

This should be ready to merge now

The search bar is no longer set with the right side of the screen. Is this intentional, and if so, why?

Not intentional - thought it was at the right side last night but I’ll take a look later today

oh, dammit, sorry I didn't catch that. thanks for noticing.
I just tried the simple solution of adding a <v-spacer> and that wasn't sufficient fyi

This is what it looks like for me

I think you have to zoom out a bit.

I think this is because of the resizing of said searchbar on small screens that I added.  Will look into this

This is now fixed, for the record


Write blog post outlining Salt release - rationale, narrative, roadmap

Initially for internal publication, prior to development of longer term public blogging solution. Must align with Salt release.

Draft content for this is nearly complete and signed-off.
Blog is Wordpress driven, correct? Who has access to post - so we can schedule this to coincide to release. @james-nash @rufcha ?

Hi @shinytoyrobots, Yes, we use WordPress. Paul and I usually publish the posts. Once Tanya/Mitch have signed it off, I'm happy to do a final review to check for styling etc, and then create the post.

12 Dec - pending review by content and comms

@pseys - we should schedule this to go live (or send live manually) to coincide with the site going live.


Usings of missing 'because' parameters added to ShouldThrowExactly method

That's weird. I would expect a missing unit test for this.

@pavbsu any plans with this PR?

@dennisdoomen yes, i am going to write/update unit tests for this soon.

Done. There are no special tests for 'because' parameters of ShouldThrow method, therefore existing tests for ShouldThrowExactly were updated.


Have you tried it?

Hey, I've been thinking about doing the same. Have you tried it ? Can you share some pros and cons ?

I've never actually used it in production. Event sourcing is cool, but today I think it would slow me down.


Have cut_release handle "config/default" and generate cops doc.

task cut_release will replace the string "<<next_version>>" in the default.yml file with the version being cut (matching is permissive: quoted or unquoted, with "-" or "_", etc.)
task generate_cops_documentation now does nothing and only prints out that doc generation is now automatic
processing code moved to new task update_cops_documentation (no public description) that is triggered by cut_release
new cop generator uses this by default instead of the next minor version

Did I forget anything?

<<next_version>>

I think we can shorten this to <<next>>. That would simply the matching a regexp a bit.

Did I forget anything?

I don't think so.

Changed to <<next>> 👍


Change "Remove as background" to "Detach from background"

Summary

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

Add an image
Set as background
Verify that the button that was previously "Remove as background" now says "Detach from background"

Fixes #1915

Don't think we need additional QA for such a simple fix. I just tested it and it works as expected 👍

Didn't any tests (unit or karma) refer to this button by text or accessible name? Well, that's clearly a missed opportunity for testing there - I guess I only tested setting background in a few files - never using this detach button.

Apparently no, there were no tests related to the text. I actually just assumed that something else was used for testing this button. Should have double-checked!


arch_atomic: nx only use atomic_long_xxx function

Summary
Modify the kernel to use only the long type atomic interfaces, avoiding the use of sizeof or typeof to determine the type of atomic operations, thereby simplifying the kernel's atomic interface operations.
Impact
atomic function
Testing
./tools/configure.sh sim:citest pass
sabre-6qaud:smp pass

[Experimental Bot, please feedback here]
No, this PR description does not adequately meet the NuttX requirements. While it provides a basic summary of the change, it lacks crucial details and context. Here's a breakdown of what's missing and how it can be improved:
Summary:

Insufficient Detail:  "Modify the kernel to use only the long type atomic interfaces" is vague.  Which atomic interfaces are being modified?  Are all atomic operations now using long, or just a specific subset?  What was the previous behavior?  Be specific.  For example: "Replace the use of atomic_add() with size-specific variants (e.g., atomic_add_long()) throughout the kernel to avoid ambiguity and improve type safety."
Missing Rationale: Why is this change necessary? What problem does it solve?  Does it improve performance, portability, or code clarity?  For example: "Using sizeof or typeof to determine atomic operation types can lead to subtle errors when porting to different architectures or when dealing with complex data structures.  This change enforces the use of explicit type specifiers, improving code maintainability and preventing potential portability issues."

Impact:

Too Brief: "atomic function" is not helpful.  Address all impact categories explicitly, even if the answer is "NO."  Provide explanations where needed.

User Impact: Likely NO. But explain why.  "No direct user impact is expected. This change is internal to the kernel and should not affect application behavior."
Build Impact: Possibly YES.  If the change affects header files or build configurations, describe the impact.  If NO, state so explicitly.
Hardware Impact: Possibly YES if this affects architecture-specific code. Specify which architectures are affected and how. If NO, explain why.
Documentation Impact:  Possibly YES if any documentation needs updating to reflect the API changes.
Security Impact: Possibly YES or NO.  Justify your answer. Does this change address any potential vulnerabilities or introduce new ones?
Compatibility Impact: Possibly YES or NO.  Does this break any existing code or drivers? Does it affect compatibility with different NuttX versions?

Testing:

Insufficient Detail: Provide more context. What does "sim:citest pass" mean? Which tests were run?  "sabre-6qaud:smp pass" is also insufficient. Which SMP tests specifically?
Missing Before/After Logs:  Include actual log snippets demonstrating the change in behavior or performance, if applicable.  Even if there's no visible functional change in the logs, provide some evidence that the code is functioning as expected (e.g., kernel boot log snippets).
Expand on Test Setup: What specific configuration options were used for the build? What commands were used to run the tests? This information allows others to reproduce your results.  Mention the NuttX version you tested against.

Example of an improved summary:
This PR refactors the kernel's atomic operations to exclusively use long type interfaces (e.g., atomic_add_long()).  Previously, the code relied on sizeof and typeof to determine the appropriate atomic operation type, which could lead to portability issues and subtle errors when dealing with complex data structures.  This change enforces the use of explicit type specifiers, improving code clarity, maintainability, and portability across different architectures. This change addresses issue #[insert issue number].
By providing more detail and context in each section, you make it easier for reviewers to understand the purpose, impact, and correctness of your changes, which significantly increases the chances of your PR being accepted.

it seems a bit wasteful to mechanically replace short with long to me. especially where structure fields are arranged for a short.
why long? i suspect it's simpler to use a fixed sized type like int32_t given the current usage in our tree.

it seems a bit wasteful to mechanically replace short with long to me. especially where structure fields are arranged for a short.
why long? i suspect it's simpler to use a fixed sized type like int32_t given the current usage in our tree.

Hi, yamt, we will implement an interface similar to linux/atomic/atomic-instrumented.h for use by the NuttX kernel. What are your suggestions?

it seems a bit wasteful to mechanically replace short with long to me. especially where structure fields are arranged for a short.
why long? i suspect it's simpler to use a fixed sized type like int32_t given the current usage in our tree.

Hi, yamt, we will implement an interface similar to linux/atomic/atomic-instrumented.h for use by the NuttX kernel. What are your suggestions?

similar in which sense?
instrumentation?
types? (atomic_t/atomic64_t/atomic_long_t)
something else?

similar in which sense?
instrumentation?
types? (atomic_t/atomic64_t/atomic_long_t)
something else?

@yamt only support int32_t atomic type and interface.

it seems a bit wasteful to mechanically replace short with long to me. especially where structure fields are arranged for a short.

why long? i suspect it's simpler to use a fixed sized type like int32_t given the current usage in our tree.

Some architectures do not support subword atomics without involving libatomic (RISC-V is one). As a fallback, the current code we have invokes the nx_atomic functions which use spin locks internally to guarantee data integrity which causes a huge performance impact. I already see this after this patch https://github.com/apache/nuttx/pull/14465.
If the data type size needs to be optimized, please make it possible for the user to force use of lock free versions (i.e. toolchain optimized versions) of the atomic_ procedures, as people who use them most likely want performance rather than size optimization.

similar in which sense?
instrumentation?
types? (atomic_t/atomic64_t/atomic_long_t)
something else?

@yamt only support int32_t atomic type and interface.

i have a bit concern about the size increase from "short", especially where it doesn't really need to be atomic. (eg. non-SMP)


Normab.ipynb example notebook is not working with an updated version of cpa

I'm trying to re-run the example notebook Norman.ipynb, and it throws an error because the format of cpa.CPA.setup_anndata() has been changed. Could you, please, update the Normab.ipynb as well, so that it'd work with the new version of the package?

@Naghipourfar


Revise the whole terminology one more time

I still don't like e.g. GENA_USE_SAMPLE, GENA_USE_ENTITY and so on, as they're not intuitive.
The new approach to defining a terminology should be next:

avoid homonyms;
prepare an initial list of words that can be used, then select from them by considering intuitivity;
... (I'll think about it later, now I'm slightly discouraged).

Style fix required: first brace must be at the same line.
https://github.com/cher-nov/Gena/blob/b9cf7ac50898a2298ab0eb1db7dd8c6723f055c5/genvector/genvector.c#L17-L18


117 ensure fresh install works even if ifadv missing

ifadv is currently hosted only in GitHub. Due to license incompatibility, we cannot just add this dataset to our package. Moreover, CRAN doesn't allow dependencies that live outside of CRAN, so we have no choice but to access it in a less elegant way.

Context
Dear @mdingemanse, after wrestling with the ifadv problem for a while, I found the following solution:

Loading data from a .csv is, oddly enough, significantly easier than from R's native format .rda. This is particularly true when your data is located on a URL (if you feel curiosity, compare the rda version with the csv one
So I pushed a .csv copy of the dataset to elpaco-escience/ifadv, it is redundant, I know, so I kind of hid it in its own branch.

Request
The tests and vignettes keep running. The snapshots didn't change. But I consider this a potentially critical change in the dataset at its very origin, so it will be great if you can check the results still make sense.

Yes I quite agree that it would be lovely to redistribute; I remember us spending too much time early 2023 discussing the licensing constraints, and I think the IFADV makers would be scratching their heads about it. I think the current solution works around it in the most CRAN-ready way, which is our proximate goal here so approving

I went ahead and merged, let me know if you prefer me to leave this to you as PR author next time


fix(hmr): only invalidate importers if the invalidated module is not a HMR boundary

Description
Try to fix #3033 while pair programming with @underfin.

Additional context
We are fixing some react HMR issues in Rspack and found that Vite has a similar issue. After https://github.com/web-infra-dev/rspack/pull/2714, I start to investigate the issue of Vite, which turns out the issue has a different cause than Rspack. After a hard coding with @underfin, we locate the issue, which is caused by cycle dependency.
We came out of this fix, not sure it breaks other things.

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[ ] Read the Contributing Guidelines.
[ ] Read the Pull Request Guidelines and follow the PR Title Convention.
[ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

Thanks a lot for porting the fix to Vite @hyf0 and @underfin! It is highly appreciated ❤

/ecosystem-ci run


fix: always fetch immutable ef bootstrap version

🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #5923.
We had an issue where Deno cached an old version of edge-functions-bootstrap locally. On the next run, Deno re-fetched some of the assets but not others. Since it assumes URLs to be immutable, this shouldn't have made a difference - but because we were using the https://edge.netlify.com endpoint to parse Edge Functions config, the contents changed. This broke some customers trying to deploy edge functions locally. I have a hunch that this only affected some versions of Deno and not others.
Anyways, this PR fixes the issue by injecting a deploy-scoped Bootstrap URL into netlify/build (and by extension, into netlify/edge-bundler). Deploy-scoped URLs are immutable, so they should fix this bug.

For us to review and ship your PR efficiently, please perform the following steps:

[ ] Open a bug/issue before writing your code 🧑💻. This ensures we can discuss the changes and get feedback from everyone that should be involved.
[ ] Read the contribution guidelines 📖. This ensures your code follows our style guide and
passes our tests.
[ ] Update or add tests (if any source code was changed or added) 🧪
[ ] Update or add documentation (if features were changed or added) 📝
[ ] Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

I'd say let's ship this PR, and ship the other addition in a follow-up.

As long as you're tracking it, sounds good to me!


SecurityError: when cookies are deactivated in browser

an uncatched error is thrown when the user deactivates cookies in the browser, resulting in a crash of the whole angular app. There was the same issue with angular-translate #629. The getSavedConfig() is throwing this error first. A try/catch block would fix it, but I would personally prefer a fallback to storing the data just in a JavaScript object. What do you think about that?
The line throwing this error is actually this one:
        if $window.localStorage

I've got a similar note to share for others. When localStorage is disabled — most notably, in using a Private Window in Safari on Mac or iOS — it produces a QuotaExceededError: DOM Exception 22.
It's also worth noting that, when using this module, on any $http-powered request your application makes, ng-auth-token checks the contents of the response and tries to re-save the credentials, if they're included: https://github.com/lynndylanhurley/ng-token-auth/blob/d3ef20d738d05aca7a91c814f1fe288df269a063/dist/ng-token-auth.js#L647
I don't cite this as a bug in ng-token-auth, since it's just doing as advertised (and building some kind of system of checks and fallbacks could get messy in a hurry, I'm sure), but it might be worth adding a note in the docs to call out this limitation.


Description on signup page

It would be nice if people understood who should be signing up for an account instead of having is ambiguous without a description.


assets in subfolders

For better organization it would be good to put images of a sub-site into its own assets folder. For example,
contents
          sub-folder1/index.md
          sub-folder1/assets/image1.png, image2.png, ....
          sub-folder2/index.md
          sub-folder2/assets/image1.png, image2.png, ....

Is it possible? How?

Please refer to Pico's user docs, http://picocms.org/docs/#creating-content
There's a distinct assets/ folder you can and should use. You can use whatever structure you prefer inside this folder. Your content/ folder isn't accessible from the outside for security reasons.

I'm finding myself in the same situation where I use Image Paste for Sublime Text, that writes the image from the clipboard into a markdown file as link. The image is saved relatively to the document.
blogpost-12345.md
blogpost-12345/blogpost-123451.png
blogpost-12345/blogpost-123452.png
etc.
This makes it quite easy to create articles and not jumping between folders, copy filenames etc.
Given, this is a very specific case, there are probably other Markdown editors that simplify the process in a different way or one can optimize the process of creating documents with images by oneself.
At the end, it's easy to get around the restriction and just tweak the .htaccess to allow access to the content folder (with all security implications) and rewrite paths to the images in a plugin.
RewriteRule ^(config|content|content-sample|lib|vendor)(/|$) index.php [L]

So I guess, Pico should indeed stick to their concept of separating assets and content.
(just my 2cents)


The terminal session is not displayed on safari

This issue comes from Peter Vogt, he can't manage to display the terminal. When he start sepal the terminal tab leads to a black screen as here:

Of course the problem is desapearing when he lanches sepal on other browsers (firefox and chrome have been tested)
set up
Safari: 14.0.3
OS: macOS Big Sur 11.2.1

Confirm, this issue still exists on macOS 11.2.3, Safari 14.0.3 and no extensions active, also Safari -> Settings for this website... everything is allowed, still plain black. Chrome works fine.

This is weird. I'm running same versions of MacOS and Safari, without any custom settings.
There must be something interfering.

Problem solved. This issue could be tracked down to our corporate proxy setup. Accessing the site with a regular internet connection works fine.


kube-enforcer service-account name hardcoded

https://github.com/aquasecurity/aqua-helm/blob/076934b11e879e4ec623a243313699c5b0f76f0c/kube-enforcer/templates/service-account.yaml#L5
This should probably reference the provided value:
 name: {{ .Values.serviceAccount.name }}

Noticed in both the 5.3 branch and 6.0 (referenced above)

Thanks for addressing the issue, fixed in https://github.com/aquasecurity/aqua-helm/pull/268


Compatibility issue with newest grpcio-tools and protobuf

Hello.
During installation of robotframework-browser, a compatibility message is shown:
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
robotframework-browser 14.1.0 requires grpcio-tools==1.48.1, but you have grpcio-tools 1.49.1 which is incompatible.
robotframework-browser 14.1.0 requires protobuf==3.20.1, but you have protobuf 4.21.7 which is incompatible.
grpcio-tools and protobuf were updated during update of rpaframework-google package.
Would it be then possible to release a robotframework-browser version (or workaround) to make it compatible with the newest grpcio-tools and protobuf?
Thanks

@allcontributors please @axiom41 for bugs.
This is fixed in  ##2393

@allcontributors please add @axiom41 for bugs.


ui: Stream colors

Display stream colors where appropriate.

api reference

See color in https://zulip.com/api/get-subscriptions#response

zulip-mobile

getStreamColorForNarrow in https://github.com/zulip/zulip-mobile/blob/main/src/subscriptions/subscriptionSelectors.js
getStatusBarColor in https://github.com/zulip/zulip-mobile/blob/main/src/common/ZulipStatusBar.js

web

get_recipient_bar_color in https://github.com/zulip/zulip/blob/main/web/src/stream_color.ts

Stream colors were implemented in the API binding in 9c1128eb9555dd8bfe053275cc30b63a88ef9eee and shown in recipient headers since 63760a90ebd057a7ffac2889ad612b69f9b2c240, in the first few days of the prototype.
The complex ways that the colors are mixed and lightened for different contexts were implemented more recently, in StreamColorSwatch, as part of work on the inbox screen.


cimg: 3.3.5 -> 3.3.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/cimg/versions.
meta.description for cimg is: A small, open source, C++ toolkit for image processing
meta.homepage for cimg is: http://cimg.eu/
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact
Checks done

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 3.3.6 in filename of file in /nix/store/yig4ysqi529kz2hwcvfjbwrgnahzdva2-cimg-3.3.6

Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

12 package rebuild(s)

First fifty rebuilds by attrpath

ansel
cimg
darktable
gimp-with-plugins
gimpPlugins.gmic
gmic
gmic-qt
imgcat
openroad
phash
photoprism

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/yig4ysqi529kz2hwcvfjbwrgnahzdva2-cimg-3.3.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cimg https://github.com/r-ryantm/nixpkgs/archive/61cbfeca919d1efa3dcc5ad29836523a6ca32768.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/61cbfeca919d1efa3dcc5ad29836523a6ca32768#cimg

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/yig4ysqi529kz2hwcvfjbwrgnahzdva2-cimg-3.3.6
ls -la /nix/store/yig4ysqi529kz2hwcvfjbwrgnahzdva2-cimg-3.3.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

15 packages built:

ansel
cimg
cimg.doc
darktable
gimp-with-plugins
gimpPlugins.gmic
gmic
gmic-qt
gmic.dev
gmic.lib
gmic.man
imgcat
openroad
phash
photoprism

Maintainer pings
cc @AndersonTorres @lilyinstarlight for testing.

Result of nixpkgs-review pr 312344 run on x86_64-linux 1

15 packages built:

ansel
cimg
cimg.doc
darktable
gimp-with-plugins
gimpPlugins.gmic
gmic
gmic-qt
gmic.dev
gmic.lib
gmic.man
imgcat
openroad
phash
photoprism


unable to build wasm binary

I'm trying to create a wasm for loading npz files. To do so, I'm using npyz crate. Here is code to load npz file.
// generate WAI glue code
wai_bindgen_rust::export!("npy.wai");

use std::{fs::File, io};
use zip;
use npyz::{npz, NpyFile};
struct Npy;

impl crate::npy::Npy for Npy {
    fn load(path: String) -> Vec<u8> {
        // read the file
        let file = io::BufReader::new(File::open(path).unwrap());
        let mut zip = zip::ZipArchive::new(file).unwrap();

        // load array with name "quant_map"
        let file = zip.by_name("quant_map.npy").unwrap();
        let reader = NpyFile::new(file).unwrap();

        // convert into vector
        let output = reader.into_vec::<u16>().unwrap();

        serde_json::ser::to_vec(&output).unwrap()
    }
}

npy.wai looks like this:
// npy.wai

/// It's being used to load a npz file.

load: func(path: string) -> list<u8>

These are the dependencies that I'm using in the cargo.toml file:
[dependencies]
npyz = {version = "0.7.2", features =  ["npz"]}
wai-bindgen-rust = "0.2.1"
zip = "0.6.3"
serde_json = "1.0.91"

When I'm running cargo wapm --dry-run, I'm getting this error:
(base) avataar@avataars-MacBook-Pro npz_loader % cargo wapm --dry-run
2023-01-04T05:22:32.368010Z  INFO publish: cargo_wapm::publish: Publishing dry_run=true pkg="npz_loader"
The following warnings were emitted during compilation:

error: failed to run custom build command for `zstd-sys v2.0.4+zstd.1.5.2`

Caused by:
  process didn't exit successfully: `/Users/avataar/Documents/avataar/npz_loader/target/release/build/zstd-sys-107330d4ef477849/build-script-build` (exit status: 1)
  --- stdout
  cargo:rustc-cfg=feature="std"
  cargo:rerun-if-changed=wasm-shim/stdlib.h
  cargo:rerun-if-changed=wasm-shim/string.h
  TARGET = Some("wasm32-unknown-unknown")
  OPT_LEVEL = Some("3")
  HOST = Some("aarch64-apple-darwin")
  cargo:rerun-if-env-changed=CC_wasm32-unknown-unknown
  CC_wasm32-unknown-unknown = None
  cargo:rerun-if-env-changed=CC_wasm32_unknown_unknown
  CC_wasm32_unknown_unknown = None
  cargo:rerun-if-env-changed=TARGET_CC
  TARGET_CC = None
  cargo:rerun-if-env-changed=CC
  CC = None
  cargo:rerun-if-env-changed=CFLAGS_wasm32-unknown-unknown
  CFLAGS_wasm32-unknown-unknown = None
  cargo:rerun-if-env-changed=CFLAGS_wasm32_unknown_unknown
  CFLAGS_wasm32_unknown_unknown = None
  cargo:rerun-if-env-changed=TARGET_CFLAGS
  TARGET_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("false")
  running: "clang" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=wasm32-unknown-unknown" "-I" "wasm-shim/" "-I" "zstd/lib/" "-I" "zstd/lib/common" "-I" "zstd/lib/legacy" "-fvisibility=hidden" "-DXXH_STATIC_ASSERT=0" "-DZSTD_LIB_DEPRECATED=0" "-DXXH_PRIVATE_API=" "-DZSTDLIB_VISIBILITY=" "-DZDICTLIB_VISIBILITY=" "-DZSTDERRORLIB_VISIBILITY=" "-DZSTD_LEGACY_SUPPORT=1" "-o" "/Users/avataar/Documents/avataar/npz_loader/target/wasm32-unknown-unknown/release/build/zstd-sys-7289b47fe786577f/out/zstd/lib/common/debug.o" "-c" "zstd/lib/common/debug.c"
  cargo:warning=error: unable to create target: 'No available targets are compatible with triple "wasm32-unknown-unknown"'
  cargo:warning=1 error generated.
  exit status: 1
  running: "clang" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=wasm32-unknown-unknown" "-I" "wasm-shim/" "-I" "zstd/lib/" "-I" "zstd/lib/common" "-I" "zstd/lib/legacy" "-fvisibility=hidden" "-DXXH_STATIC_ASSERT=0" "-DZSTD_LIB_DEPRECATED=0" "-DXXH_PRIVATE_API=" "-DZSTDLIB_VISIBILITY=" "-DZDICTLIB_VISIBILITY=" "-DZSTDERRORLIB_VISIBILITY=" "-DZSTD_LEGACY_SUPPORT=1" "-o" "/Users/avataar/Documents/avataar/npz_loader/target/wasm32-unknown-unknown/release/build/zstd-sys-7289b47fe786577f/out/zstd/lib/common/entropy_common.o" "-c" "zstd/lib/common/entropy_common.c"
  cargo:warning=error: unable to create target: 'No available targets are compatible with triple "wasm32-unknown-unknown"'
  cargo:warning=1 error generated.
  exit status: 1

  --- stderr

  error occurred: Command "clang" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=wasm32-unknown-unknown" "-I" "wasm-shim/" "-I" "zstd/lib/" "-I" "zstd/lib/common" "-I" "zstd/lib/legacy" "-fvisibility=hidden" "-DXXH_STATIC_ASSERT=0" "-DZSTD_LIB_DEPRECATED=0" "-DXXH_PRIVATE_API=" "-DZSTDLIB_VISIBILITY=" "-DZDICTLIB_VISIBILITY=" "-DZSTDERRORLIB_VISIBILITY=" "-DZSTD_LEGACY_SUPPORT=1" "-o" "/Users/avataar/Documents/avataar/npz_loader/target/wasm32-unknown-unknown/release/build/zstd-sys-7289b47fe786577f/out/zstd/lib/common/debug.o" "-c" "zstd/lib/common/debug.c" with args "clang" did not execute successfully (status code exit status: 1).

The following warnings were emitted during compilation:

error: failed to run custom build command for `bzip2-sys v0.1.11+1.0.8`

Caused by:
  process didn't exit successfully: `/Users/avataar/Documents/avataar/npz_loader/target/release/build/bzip2-sys-c95068356d02d48e/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-env-changed=BZIP2_NO_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_ALLOW_CROSS_wasm32-unknown-unknown
  cargo:rerun-if-env-changed=PKG_CONFIG_ALLOW_CROSS_wasm32_unknown_unknown
  cargo:rerun-if-env-changed=TARGET_PKG_CONFIG_ALLOW_CROSS
  cargo:rerun-if-env-changed=PKG_CONFIG_ALLOW_CROSS
  cargo:rerun-if-env-changed=PKG_CONFIG_wasm32-unknown-unknown
  cargo:rerun-if-env-changed=PKG_CONFIG_wasm32_unknown_unknown
  cargo:rerun-if-env-changed=TARGET_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_wasm32-unknown-unknown
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_wasm32_unknown_unknown
  cargo:rerun-if-env-changed=TARGET_PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
  TARGET = Some("wasm32-unknown-unknown")
  OPT_LEVEL = Some("3")
  HOST = Some("aarch64-apple-darwin")
  cargo:rerun-if-env-changed=CC_wasm32-unknown-unknown
  CC_wasm32-unknown-unknown = None
  cargo:rerun-if-env-changed=CC_wasm32_unknown_unknown
  CC_wasm32_unknown_unknown = None
  cargo:rerun-if-env-changed=TARGET_CC
  TARGET_CC = None
  cargo:rerun-if-env-changed=CC
  CC = None
  cargo:rerun-if-env-changed=CFLAGS_wasm32-unknown-unknown
  CFLAGS_wasm32-unknown-unknown = None
  cargo:rerun-if-env-changed=CFLAGS_wasm32_unknown_unknown
  CFLAGS_wasm32_unknown_unknown = None
  cargo:rerun-if-env-changed=TARGET_CFLAGS
  TARGET_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("false")
  running: "clang" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=wasm32-unknown-unknown" "-I" "bzip2-1.0.8" "-D_FILE_OFFSET_BITS=64" "-DBZ_NO_STDIO" "-o" "/Users/avataar/Documents/avataar/npz_loader/target/wasm32-unknown-unknown/release/build/bzip2-sys-aa3294c2a6448e19/out/lib/bzip2-1.0.8/blocksort.o" "-c" "bzip2-1.0.8/blocksort.c"
  cargo:warning=In file included from bzip2-1.0.8/blocksort.c:22:
  cargo:warning=bzip2-1.0.8/bzlib_private.h:25:10: fatal error: 'stdlib.h' file not found
  cargo:warning=#include <stdlib.h>
  cargo:warning=         ^~~~~~~~~~
  cargo:warning=1 error generated.
  exit status: 1
  running: "clang" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=wasm32-unknown-unknown" "-I" "bzip2-1.0.8" "-D_FILE_OFFSET_BITS=64" "-DBZ_NO_STDIO" "-o" "/Users/avataar/Documents/avataar/npz_loader/target/wasm32-unknown-unknown/release/build/bzip2-sys-aa3294c2a6448e19/out/lib/bzip2-1.0.8/huffman.o" "-c" "bzip2-1.0.8/huffman.c"
  cargo:warning=In file included from bzip2-1.0.8/huffman.c:22:
  cargo:warning=bzip2-1.0.8/bzlib_private.h:25:10: fatal error: 'stdlib.h' file not found
  cargo:warning=#include <stdlib.h>
  cargo:warning=         ^~~~~~~~~~
  cargo:warning=1 error generated.
  exit status: 1

  --- stderr

  error occurred: Command "clang" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=wasm32-unknown-unknown" "-I" "bzip2-1.0.8" "-D_FILE_OFFSET_BITS=64" "-DBZ_NO_STDIO" "-o" "/Users/avataar/Documents/avataar/npz_loader/target/wasm32-unknown-unknown/release/build/bzip2-sys-aa3294c2a6448e19/out/lib/bzip2-1.0.8/blocksort.o" "-c" "bzip2-1.0.8/blocksort.c" with args "clang" did not execute successfully (status code exit status: 1).

Error: Unable to publish "npz_loader"

Caused by:
    Cargo exited unsuccessfully with exit code 101

I'm closing this issue as this is not related to wai. This is being caused by a dependency which can't be compile to wasm32-unknown-unknown


Remove TLS configuration specialisation

This was present in the past because Go shipped with RC4 enabled.
It no longer does this, and it has a much more sensible default
configuration in go1.6, so we can just use that.

:+1:  I assume tiny-ask-proxy already runs on go1.6, right?

yep.


Fix whatsapp logo

It's not appearing since no style is available for before:

@harshitbudhraja

By looking at the font-awesome css stylesheet, I got the access number for whatsapp's icon. But even after using it, does'nt work....
fa-whatsapp:before { 	content: "\f232"; }
@rhnvrm ....Should I look for and try some other way ?

There are two duplicate rules in the file, did you change them both?


Parse Permit Url

Resolves #526

QA: https://github.com/Sadaf-A/ubiquibot/issues/1

@whilefoo I'm not able to setup the bot after following the documentation what should i do

what's the issue

@whilefoo I'm not able to setup the bot after following the documentation what should i do

what's the issue

It isn't replying to comments it is saying bot is not installed on the repository but it is


[Question]: cloud storage like s3

Describe your problem
Minio is good enough for individual use but in business scenario we want a more flexible file storage service like s3 or any other. This may not be the one of the main targets of ragflow, so I want to know where to start to contribute, thanks.
Great job BTW, hope API docs coming soon.

S3 and minio basically share the same api.
Just add another utility in rag/util instead of using minio.

Minio is compatible with S3 protocol.


[Plan] Support group hosts, group vars and group combination in inventory file(hosts file)

Inventory file demo:
# This is a hosts inventory file for gossh

# no group hosts
alias_name_node1 host=node1.sre.im
node100.sre.im

# hosts group
[webserver]
alias_name_node2 host=<IP_ADDRESS> port=8022 user=vagrant password=123456 keys=~/.ssh/id_dsa,~/.ssh/id_rsa passphrase=xxx
node[06-07].sre.im port=9022 user=lisi password=654321
node08.sre.im

# host vars for group webserver
[webserver:vars]
port=8033
user=wangwu

[dbserver]
<IP_ADDRESS>

[dbserver:vars]
user=vagrant2
password=abcdefg

# hosts group project1 has hosts that defined in group dbserver and group webserver
[project1:children]
dbserver
webserver


Change “portability” string in WGPU Haddocks

Now supports Windows too.

WIP in the linux branch: https://github.com/lancelet/wgpu-hs/tree/linux

Done.


Horcrux should be README.lint compliant.

https://github.com/strangelove-ventures/readme-dot-lint?tab=readme-ov-file#-why-use-readmelint

Test failure appears spurious. Can I get a review?

yea this is just a flakey test You can re-run TestDownedSigners2of3 if you press on details then "Re=Run failed test"


Fix issue#188:https://github.com/web3p/web3.php/issues/188, support t…

Fix issue#188:https://github.com/web3p/web3.php/issues/188, support the tuple[] type.

Fix issue#188:https://github.com/web3p/web3.php/issues/188, support the tuple[] type.

I tried this code and found that it doen't work propertly with a dynamic tuple ( a tuple with dynamic parameters like string ). Not dynamyc type work fine.
Have checked dynamic tuples on own side?