Git open repositories order differ from UI

Issue Type: Bug
VS Code version: Code - Insiders 1.42.0-insider (705f01577dd37d6f17eaa683ab89b0c392fa1a7c, 2020-02-03T13:59:34.701Z)
OS version: Darwin x64 19.2.0
I have a multiple root workspace with VS Code repo and a small git repo, the workspace file is like below
        "folders": [
                {
                        "path": "vscode"
                },
                {
                        "path": "prototype/notebook-test"
                }
        ],

When the workspace is loaded and the current view container is not SCM, vscode is the active repository (based on the info from status bar).
However git extensions API gives GHPR an ordered list of repositories which are all unselected. The order is
[
  prototype/notebook-test, unselected
  vscode, unselected
]

From above list, we can't figure out which repository is the active repository in the workspace. The order of repositories is not the same as the UI due to the fact that we don't await for repository registration https://github.com/microsoft/vscode/blob/1d71d49864791541a5d18c1190da3c310b22dc7c/extensions/git/src/model.ts#L134 (not sure if this is intentional for performance), so we can't simply choose the first one as the active one.
Once SCM view container is opened, vscode shows before notebook-test and triggers a selection change event and from that moment, git extensions can provide information about active repository.

I think the order should not matter, since the user can easily reorder them in the view.
But the selected attribute should be properly set... checking...

Oh I see... currently the selected attribute matches to which repository is visible in the SCM view. Until the viewlet renders, no repository is visible, so none is selected.
The status bar state matches the focus attribute, which we do not expose in the UI...

@rebornix After looking at this once again, I've decided not to do anything.
The right fix here would be to open up another proposed API representing the state of the active repository in the status bar, which differs from the selected repositories in the SCM viewlet. We'd then need to propagate this over to the git extension API. I don't think it's worthwhile tackling this since it was never my goal to have a single repository active in the status bar but rather an affordance which would accommodate every repository.
The other change we can do here is make sure the order is correct, that way you can always pick the first one if no one is selected. Mind you that the status bar can still show a repository which is not selected, if the user opens a file within that repository. But let's leave it at that.

@rebornix After investigating I can't seem to get the wrong order like you do. Do you still repro this? I don't remember if I fixed this already.


Is there a limit on the number of work items that are pulled into Delivery Plans?

[Enter feedback here]
It appears that certain features are not displayed on the delivery plan and when i reduce the number of items brought for delivery plan by remvoing stories , it appears to display all the features.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f3b97a42-36e5-7023-a48f-d97c8ef71482
Version Independent ID: b8ec620f-e9f0-6f5b-d1e6-9877310c3403
Content: Frequently asked questions (FAQs) about Delivery Plans - Azure Boards
Content Source: docs/boards/plans/faqs.yml
Product: devops
Technology: devops-agile
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@amitamorakhia - Thank you for your inquiry. There isn't a limit to the number of work items displayed in the delivery plan.  When you say -- "certain features are not displayed on the delivery plan" - what specific features are you referring to?
Please review the information provided Review team delivery plans in Azure Boards, Prerequisites to ensure you have configured everything as required.
Otherwise, if you continue to see problems, please post your issue on our Community page with as much detail as possible.


Update providers.json

I made a fix to the upstream, so I'm just updating it here.

@10by10pixel thank you, your code has a little problem with coding style. Could you fix that?

@ndaidong It passed the CI code analysis. Can you clarify what you mean by code quality?

@10by10pixel I found that the CI didn't pass. The process is stopped after linting and does not touch on the test scripts yet.
https://github.com/ndaidong/oembed-parser/pull/88/checks?check_run_id=1922804837

@ndaidong I fixed some bugs. CI tests are all passing now

@10by10pixel thank you, I will merge it now.


Update documentation if running on Windows command line to use double quote " instead of single quote ' for database url

What steps will reproduce the bug?

Download msi binaries for Windows and install
run command using single quote ' as per documentation
run the command again using double quotes " for database url

What happens?
What's not working
C:\Program Files\rsql_cli\bin>rsql --url 'mysql://root:secrets!@<IP_ADDRESS>:3306/mysql' -- "SELECT version();"
Error: relative URL without a base
What's working
C:\Program Files\rsql_cli\bin>rsql --url "mysql://root:secrets!@<IP_ADDRESS>:3306/mysql" -- "SELECT version();"
version()
8.0.39-community
1 row (1.7841ms)
What did you expect to happen instead?
version()
8.0.39-community
1 row (1.7841ms)
How did you install rsql?
Via Github release msi installer for Windows
Information about your environment

rsql version: rsql/0.13.11 Windows/10.0.22631/x86_64
Database and version: MySQL 8.0.39
Operating system: Windows 11

@yrfu thank you for reporting the issue.  This should be addressed by #187


IGAPP-654: Move pois

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.

Where can I test pois again?

Where can I test pois again?

TBH I don't know which cities have the pois flag set to true. As a workaround you can just remove the check in the CityContentSwitcher disabling the pois route if the flag is set to false.


Trying to do an exact rebuild

Hi, I'm trying to modify a XML file and rebuilding it, avoiding any mismatch. So I'm parsing it using:
{
  explicitRoot: false,
  preserveChildrenOrder: true,
  explicitChildren: true
}

This way, I'm getting the exact representation of the original XML, but I cannot rebuild it this way with the default builder. How can I achieve this?
Thanks!

This would be interesting for me as well. Do you plan to release an update that supports building of an object that was parsed using these settings soon?

No plans at the moment. I am doubting that adding XML output was a good idea to start with.

Thats a pity. I need this feature. I'm trying to implement it and if I succeed I will contribute it.

#307
The pull req is created. I copied all builder unit tests to ensure having the expected result when building an xml.

@Leonidas-from-XIV currently you are trying to create an exact JSON object with preserved order but you have never checked how the XML will look that is built from an exact object. So how do you make sure that your object built with explicitChildren and preserveOrder contains everything necessary?
My tests are covering this and the pull request also contains fixes for building this object.
Unfortunately your recent commits are conflicting with my changes.
I don't have time to fix the merge conflicts because its implemented once for a project of a client.
If you are willing to merge the pull request I would resolve the conflicts once. Otherwise I will abandon my fork.


Makes minor documentation changes for tilegrid fuzzer

Starting to look at improving some of the documentation of Project X-Ray.

Thank you for contributing!
(PS @PaulSchulz feel free to join us on the #symbiflow IRC channel if you want to ask questions.)


[SPARK-44524][BUILD] Add a new test group for pyspark-pandas-slow-connect module

What changes were proposed in this pull request?
The pr aims to
1.split pyspark-pandas-slow-connect GA test group into 3 groups, namely pyspark-pandas-connect-part-1, pyspark-pandas-connect-part-2 and pyspark-pandas-connect-part-3, reduce the testing pressure of the pyspark-pandas-slow-connect group.
2.disable run_python_packaging_tests, make the GA testing related to PySpark to pass temporarily.
Why are the changes needed?
Avoiding No space left on device issues, eg:
https://github.com/apache/spark/actions/runs/5632266470/job/15260065769
https://github.com/panbingkun/spark/actions/runs/5636590985/job/15273567033

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Should monitor GA.

It seems that splitting the test task is useful. Do we have to split it into 3?

cc @HyukjinKwon @zhengruifeng FYI

If so, I suggest we'd better find better names for the groups (let's also take existing pyspark_pandas_connect into account), maybe pyspark_pandas_connect_part_xxx

Ok, let me try again.

I think it is fine to split pyspark-pandas-slow-connect which is slow.
not sure whether they are due to the same cause, but I also see pyspark-sql, pyspark-pandas-slow failed for some reason (e.g. https://github.com/apache/spark/actions/runs/5651977344/job/15310946651)
It's kind of dangerous, since the GA recognized them as skip and made CI succeeded.

It's kind of dangerous, since the GA recognized them as skip and made CI succeeded.

...

pyspark-pandas-connect-part-3 failed to run in the final stage with the following error message:

cc @HyukjinKwon does it mean the packaging test itself fails for some reason

Let's try to disable run_python_packaging_tests.

It succeeded.

@panbingkun yes, it seems the python packaging test is the blocker,  please hold on this PR, let's fix it in https://github.com/apache/spark/pull/42146 first.

@panbingkun after we disable packaging tests in pyspark-pandas-connect and pyspark-pandas-slow-connect, the pyspark-pandas-connect took 1h, and pyspark-pandas-slow-connect took 2h.
I think it is not worthwhile to split pyspark-pandas-slow-connect any more, instead I suggest rebalancing them by moving some tests from pyspark-pandas-slow-connect to pyspark-pandas-connect.

@panbingkun after we disable packaging tests in pyspark-pandas-connect and pyspark-pandas-slow-connect, in https://github.com/zhengruifeng/spark/actions/runs/5664781463/job/15348941550 , the pyspark-pandas-connect took 1h, and pyspark-pandas-slow-connect took 2h. I think it is not worthwhile to split pyspark-pandas-slow-connect any more, instead I suggest rebalancing them by moving some tests from pyspark-pandas-slow-connect to pyspark-pandas-connect.

Ok,  let me turn this PR into the logic of rebalancing? 😄

@panbingkun after we disable packaging tests in pyspark-pandas-connect and pyspark-pandas-slow-connect, in https://github.com/zhengruifeng/spark/actions/runs/5664781463/job/15348941550 , the pyspark-pandas-connect took 1h, and pyspark-pandas-slow-connect took 2h. I think it is not worthwhile to split pyspark-pandas-slow-connect any more, instead I suggest rebalancing them by moving some tests from pyspark-pandas-slow-connect to pyspark-pandas-connect.

Ok, let me turn this PR into the logic of rebalancing? 😄

yeah, many thanks!

@HyukjinKwon @zhengruifeng @LuciferYang
In addition, there may be a potential fix point needed in run_python_packaging_tests  testing, as it may affect the final release as 2023-09-26 time approaches.
Are we submitting a PR separately? Or did you just make it on this PR?
I prefer a separate PR because it may require backport to branch-3.3 & branch-3.4.

@panbingkun I see, what about fixing it after 3.5 is released?

@panbingkun I see, what about fixing it after 3.5 is released?

Okay, fine to me.

please update this PR to latest master, since we just enabled > 100 test cases in https://github.com/apache/spark/commit/9b40c0cdc5cf8e24e66f7ee8e122702d3f157291 and https://github.com/apache/spark/commit/185a0a5a23958676e4236eaf9e4d78cdfd2dd2d7

please update this PR to latest master, since we just enabled > 100 test cases in 9b40c0c and 185a0a5

Okay, done.

@zhengruifeng
After this modification, the testing time of pyspark-pandas-connect and pyspark-pandas-slow-connect has been basically balanced.
1.pyspark-pandas-connect

2.pyspark-pandas-slow-connect

Let me double check the testing time this time, it looks quite balanced:
1.pyspark-pandas-connect

2.pyspark-pandas-slow-connect

Third run cost:
1.pyspark-pandas-connect

2.pyspark-pandas-slow-connect

thanks, merged to master


Privacy/content policy for GDPR

New data protection law means we need a privacy policy and stuff. This can probably be achieved through the Pages app, so code might not need be written

Privacy and Content Policies are written and people were emailed in advance so have been fully put in place. Just need to be linked to on registration page and footer.

Completed in fixes branch.


fix: move form state update before fields update

Description
Move formState update before fields update. This permit the correct update of the fields on form.

Closed for https://github.com/arkemishub/form/pull/12 refactor


Use "bin" in package.json to create node_modules/.bin symlinks

R: @gauntface
In addition to creating symlinks, this also cleans up the markdown in the README a bit, since it wasn't rendering as expected on GitHub.

Thanks for doing this @jeffposnick
LGTM, can you just squash your commits

I've squashed and merged via the GitHub UI. I think anyone with write access to the repo can do it now, actually.


Translations for Sea Creatures

@danilo-barboza added sea creatures for us! It would be radical to add support for our other languages.

Count on me for the Spanish translation!

Japanese translations are up as a PR!

Spanish translation is ready (https://github.com/SawyerHood/animal-crossing-catch/pull/42)


Update Turbosms.php

Change private to protected access for fields

Thank you!

amazing fast, thank you


Add ping iDRAC IP feature after update firmware to make sure iDRAC re…

This PR is to fix ODR895 and ODR878.
For ODR878 it is found immediate power cycle after transferring iDRAC firmware to Dell iDRAC will cause BIOS-iDRAC connection failure during update, thus a 5 seconds delay is added between image transferring-done and power cycle the server.
For ODR895 it is found with latest iDRAC firmware, iDRAC IP/password/usename will be lost during iDRAC firmware update. A "ping" like feature is added in Dell updateFirmware function so that after iDRAC start update firmware, RackHD will first try to ping iDRAC. Only after RackHD can ping the iDRAC IP successfully that we will continue following steps.

@RackHD/corecommitters please review.

@RackHD/corecommitters @cgx027 @linlynn

@pengz1  who you want to @ is  @iceiilin , not @linlynn :-)

:+1:


IpTraceable listener is not documented

Hello. I'm building my Symfony 5 application, but I can't find how to configure a listener for IpTraceable. Searched far and wide both in IpTraceable docs and Symfony 4 docs, but there is nothing related.

Any news on this or a reference link to know how to configure ipTraceable?

Huh, I'm surprised it was never integrated into the Symfony bundle. (Ref: https://github.com/stof/StofDoctrineExtensionsBundle/pull/233)
Metadata aside, you just need to have Symfony call IpTraceableListener::setIpValue() at some point with the current IP address. The "Code of subscriber class" example in the IP Traceable docs shows an example. You can also use the Symfony bundle's Blameable implementation as another example.


prometheus scaler add option to ignore null value

Provide a description of what has been changed
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Tests have been added
[N/A] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[x] A PR is opened to update the documentation on (repo) (if applicable)
[x] Changelog has been updated and is aligned with our changelog requirements

Relates to https://github.com/kedacore/keda/issues/3065
Relates to https://github.com/kedacore/keda/issues/3064
Relates to https://github.com/kedacore/keda-docs/pull/769 (docs)

The change looks good in general. Thanks for this improvement Some nits to be addressed:

There is a test failing TestPrometheusScalerCortexHeader
Open a PR in keda-docs updating the doc about prometheus scaler (only in the latest version)
Inline comment in changelog

Apart from that, IDK if it makes sense adding another e2e test to check this new behaviour, WDYT?

The change looks good in general. Thanks for this improvement Some nits to be addressed:

There is a test failing TestPrometheusScalerCortexHeader
Open a PR in keda-docs updating the doc about prometheus scaler (only in the latest version)
Inline comment in changelog

Apart from that, IDK if it makes sense adding another e2e test to check this new behaviour, WDYT?

The changelog and TestPrometheusScalerCortexHeader already updated.
I will update the keda-doc these days.
I think it unnecessary to do e2e in this case, cause I already cover this one in test file by mocking the prometheus return data, which will be the same thing in e2e.

The PR related to keda-doc: https://github.com/kedacore/keda-docs/pull/769

/run-e2e prometheus*

Static check fails as well: https://github.com/kedacore/keda/runs/6652557343?check_suite_focus=true#step:6:84

/run-e2e prometheus*


Add maxline attribute support

hope to be added in order to limit the maxLines

Thanks for the suggestion, but I don't come up with an use case where the maxLines attribute is useful. Like what use case do you expect that attribute?

First issue I had when I tried FlexBoxLayout. It would be helpful if we had this attribute. In my case I have a FlexBoxLayout on top of a RecyclerView. The FlexBoxLayout shows the names of the selected elements in the list. In my case I don't want it to be more than two lines (otherwise the FlexBox would cover the screen if I select many elements), I would show a label "+N" for the rest of the selected items.

what about this functionality?

So, no progress with this?

It would be useful in my case too.
Could you please provide any ETA for this issue?

Same problem, i only need one line in header of RecyclerView

I wanted to be careful for adding a feature that the original Flexbox doesn't have, but it looks like this is going to be useful for a lot of developers.
I'll add this feature on my TODO list.

Same problem, not only and
add enqueue child view to pop old child view also limit flexboxlayout max lines

Also looking for this feature.  I noticed that this issue is closed but it references another issue which is also closed and referenced this issue.  Maybe you should leave this one open since it hasn't been implemented yet.

can FlexboxLayoutManager specify the maximum number of lines?

manager.setMaxLine(1) is useless for FlexboxLayoutManager.
`private static class OnViewGlobalLayoutListener implements ViewTreeObserver.OnGlobalLayoutListener {
private final static int maxHeight = 130;
private View view;
public OnViewGlobalLayoutListener(View view) {
    this.view = view;
}

@Override
public void onGlobalLayout() {
    if (view.getHeight() > maxHeight)
        view.getLayoutParams().height = maxHeight;
}

}add listener to RecyclerView:view.getViewTreeObserver()
.addOnGlobalLayoutListener(new OnViewGlobalLayoutListener(view));`

@thagikura It should be maxVisibleLines, not maxLines

How do I use maxLine whilst preserving item widths? I am essentially trying to achieve the above; add all items to wrap but only show the first line but setting maxLine squishes all items onto 1 line


Provide a better message if testLog detects an unexpected log level

There have been a couple intermittent failures of this test, and it would be nice to have better data.
http://brontes.lab.eng.brq.redhat.com/project.html?projectId=WildFlyCore_PullRequest&buildTypeId=&tab=testDetails&testNameId=-785501276856468694&order=TEST_STATUS_DESC&branch_WildFlyCore_PullRequest=__all_branches__&itemsCount=50

@jamezp FYI


Beta test: Haptics Playground 1.1.1 Android app

The Android version of the Haptics Playground app is ready for beta testing.  The previous (alpha) test was completed, and a couple of the issues were addressed.  I have provided @KatieWoe with a Samsung Android tablet that supports haptic vibration, so she should be able to test on that device for this round of testing.
As was noted in the previous testing issue, this testing is intended to be fairly light since this is not expected to be a widely used app for PhET.  It is being published for potential use by the community of designers who are working to add multi-modal capabilities to educational apps.  The bottom line is that we're not looking for perfect behavior, but rather something that can be used by motivated designers.  Testing should focus on making sure that the app doesn't crash, that the primary functions appear to work correctly, and that there isn't anything that is terribly confusing about how the UI works.
Testers must be signed in with their pre-registered Google accounts, and can install the app from https://play.google.com/apps/internaltest/4701271652165855719.  Please contact @jbphet if other testers need to be added.
Issues should be logged at https://github.com/phetsims/quake/issues.
Issues to verify:

[x] Only 1 or 9 clicks available

Assigning to @KatieWoe and @kathy-phet for prioritization.

I've noticed that, turning on sound, the sound may be off the first time something is played. This is either after first turned on, or not having been used for awhile. For instance, the first buzz of a set may not play or buzzes may run together. The actual haptics don't seem to be impacted.

QA spot check is done. Checked on one device (the haptics capable tablet in the office). Check was fairly quick/light.

I've noticed that, turning on sound, the sound may be off the first time something is played. This is either after first turned on, or not having been used for awhile. For instance, the first buzz of a set may not play or buzzes may run together. The actual haptics don't seem to be impacted.

I've seem similar behavior on our sims on all manner of devices.  I think that devices often turn off the amplifier that drives the speakers in order to save power when they are not being used, and it takes a bit of time for it to come on when sound is produced after a long idle time.  If my supposition is correct here, there isn't much the code can do about it.

Thanks for the testing QA team!  I'll close this issue and move forward with the next steps.


what in the world is the bracket syntax used for when posting an event?

if i try to post a message:
post "menuPick" with tPickedName
i will get an error when the line executes regarding the type:
LCB Error	No matching handler for arguments with types (<type: livecode.lang.string>,<type: livecode.lang.string>) - possible handlers (MCEngineExecPostWithArguments)

so I look in the language reference, but I don't see any discussion
so I look in the code, and I find this:
post "editField" with [formatRectAsString(pElement["rect"]), pElement["number"]]
Does that mean that I have to post a list?

This works:
post "menuPick" with  [ tItemName ]

that's exactly what it means. if you read the post dictionary entry it does say that the return value is a list of arguments


dist-info django version typo

Hi,
I'm using Django 3.0.1 and I would like to use django-tenants (v. 2.2.3), but while installing it my Django version is downgraded to 2.2.9. As it is in setup.py Django 3.0.1 should be supported:
install_requires=[
        'Django >= 2.1,<3.1',
        'psycopg2',
    ],

When trying to install django-tenats I'm getting ERROR: django-tenants 2.2.3 has requirement Django<3.0,>=2.0, but you'll have django 3.0.1 which is incompatible..
I noticed that METADATA file in dist-info has: Requires-Dist: Django (<3.0,>=2.0). Is this a typo?

This is because I haven't released the Django 3 compatible version yet. I am working on it. You can try and use the dev version if you like however it hasn't been tested


Unclear guidance in Step 8: Web Dev Quiz Project

Describe the Issue
Step 8 of the responsive-web-design/learn-accessibility-by-building-a-quiz/ course is a little unclear about how the max() function  works.
I originally assumed it was a typo where:

In the example img {width: max(250px, 25vw);} img elements will have a minimum width of 250px.

should have said

In the example img {width: max(250px, 25vw);} img elements will have a maximum width of 250px.

@huyenltnguyen explained in this comment that "The max() function: Compares the values it receives: 250px and 25vw and Chooses the largest between the two and uses it as the width" which I did not understand at all from the lesson (which is also very much because of how new I am to front end dev!!)
Affected Page
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-8
Your code
#logo {
  width: max(100px, 18vw);
}

Expected behavior
The logo to be resized.
Screenshots
No response
System

Device: Laptop
OS: MacOS Ventura 13.6
Browser: Firefox
Version: 123.0.1

Additional context
It would have been really helpful to understand the context of the max () function more.
I got confused when the instructions talked about how the max function would select the largest "value" from the list, but then it stated that 250px would be the minimum size.

It is correct that 250px is the minimum size. 25vw in pixels depends on the width of the viewport, if the viewport is less than 1000px wide, than 25vw is less than 250px and the value selected by the max function between 250px and 25vw is 250px. If the viewport is wider than 1000px, than 25vw is bigger than 250px and the value selected is 25vw. All together, the value is 250px for viewports 1000px or narrower, and 25vw for viewports bigger than 1000px, so 250px is the minimum value

I think @ilenia-magoni's understanding of how the max() function works in CSS is correct. It ensures that for viewports narrower than 1000px, the size will be at least 250px and for viewports wider than 1000px, the size adjusts according to the viewport width, maintaining responsiveness. The explanation clarifies the usage and behaviour of the max() function in responsive design contexts.

I think most of the challenges assume we're working on a desktop device, which makes the current version, with 250px being the minimum, correct.
Though perhaps we need to update the description to include some clarification or explanation as to how the maximum value is determined. And maybe we would want to remove the word "minimum", too, as it might cause some confusion.

I sort of agree with @huyenltnguyen opinion. But in my opinion we should not make use of the "minimum" or "maximum" values at all. Instead we should use it in the context of "largest value".
My proposal:
img {
  width: max(250px, 25vw);
}

In the above example, the width of the image will be 250px if the viewport width is less than 1000px. If the viewport width is greater than 1000px, the width of the image will be 25vw. This is because 25vw is equal to 25% of the viewport width.
We could make it a little less detailed .

Yes, there is no particular need to use backticks for the values that are used by the example. That means that "1000px" does not need backticks.

I am going ahead with putting a help wanted label on this with the following requested changes:
In the above example, the width of the image will be 250px if the viewport width is less than 1000 pixels. If the viewport width is greater than 1000 pixels, the width of the image will be 25vw. This is because 25vw is equal to 25% of the viewport width.

@huyenltnguyen no worries!
I think it had a resolution with changing the phrasing to differentiate the "largest" value as you'd suggested :) Overall it makes sense and I can see why I tripped up on it when reading the step.
Thank you everyone for the discussion!


Using Augeas

Hi,
I thought I'd open an issue here to discuss whether and how to use Augeas for managing postgresql.conf and pg_hba.conf.
Augeas 1.0.0 has been released recently and I know that packages are available at least for Ubuntu from @raphink's PPA (https://launchpad.net/~raphink/+archive/augeas). Ubuntu 13.04 will have official Augeas 1.0.0 packages. I don't know how support looks on RHEL or other systems.
Augeas 1.0.0 now has extended lenses for both postgresql.conf and pg_hba.conf which look pretty good to me, but I have yet to test them thoroughly with Puppet. So I wonder: is it worthwhile to pursue using Augeas to manage these important files, or are people happier with the current template-based approach and the ideas for postgresql.conf discussed in issue #26 (I wanted to take a crack at this, but haven't had the time yet, unfortunately)?
The advantages or Augeas are, in my opinion, clear: no need for complex template constructs, we get syntax checks and support for all settings in postgresql.conf and also for all kinds of ACLs in pg_hba.conf without having to expose specific ACL types to the user and hiding or not supporting others (ipv4acls/ipv6acls vs unixacls, see PR #72). Using Augeas from within Puppet is easy enough, although in the end there might again be need for some kind of template/eruby hackery.
One thing to consider is that Augeas 1.0.0 will probably not be available on most systems for quite some time so Augeas support in this module should only be used if facter augeasversion >= 1.0.0. For earlier versions the template approach for pg_hba.conf and file_line for postgresql.conf (issue #26) will remain the only option.
Another thing to consider is that Augeas can significantly slow down a Puppet run if it manages many configuration settings.
And of course, as @jhoblitt has pointed out in PR #72 Augeas only manages specified settings, so manual edits to the configuration are, by design, still possible and not caught by Puppet.
So it might be necessary for the module user to be able to decide whether he wants to use Augeas or not.
One or two new types will probably have to be defined, such as postgresql::server::conf (manages a setting in postgresql.conf) and postgresql::server::hba (manages an ACL in pg_hba.conf).
This could lead to something like this:
postgresql::server::conf {
  'listen_addresses': value => '*';
  'port':             value => '5432';
  'max_connections':  value => '500';
}

And for pg_hba.conf the @camptocamp guys have already defined an IMHO reasonable type for ACLs, which would look somewhat like this:
postgresl::server::hba { 'access to some database for alice':
  ensure => present,
  type => 'host',
  database => 'some',
  user => 'alice',
  address => '<IP_ADDRESS>/16',
  method => 'md5',
}

But there would probably have to be a way to abstract and hide these declarations, or they would clutter up the user's manifests since they are a bit more verbose (and thus ugly) than the current config_hash approach.
Sorry for this lengthy braindump. Maybe someone has some comments or ideas, I'd love to hear them. I hope I find the time to test and experiment with this myself in the coming weeks.

Hello! We are doing some house keeping and noticed that this issue has been open for a long time.
We're going to close it but please do raise another issue if the issue still persists. 😄


Referencing interface in derived class

I face an issue when I use tree-like structures containing an interface and its implementations. In an implementation could be also properties of this interface.
    public interface INode : IEntity
    {
        string NodeName { get; set; }
    }
    public class Leaf : Entity, INode
    {
        public string NodeName { get; set; }
    }
    public class Branch : Entity, INode
    {
        public string NodeName { get; set; }
        public INode NodeLeft { get; set; }
        public INode NodeRight { get; set; }
    }

    public class TreeTest
    {
        private const string NodesCollectionName = "Nodes";

        private BsonMapper _bsonMapperMain;

        public BsonMapper InitMapper()
        {
            _bsonMapperMain = new CustomMapper();
            _bsonMapperMain
                .Entity<INode>()
                .Id(n => n.Id);
            _bsonMapperMain
                .Entity<Leaf>()
                .Id(leaf => leaf.Id);
            _bsonMapperMain
                .Entity<Branch>()
                .Id(branch => branch.Id)
                .DbRef(branch => branch.NodeLeft)
                .DbRef(branch => branch.NodeRight);
            return _bsonMapperMain;
        }

        public void Do()
        {
            Leaf leaf1 = new Leaf { NodeName = "Leaf 1" };
            Leaf leaf2 = new Leaf { NodeName = "Leaf 2" };
            Leaf leaf3 = new Leaf { NodeName = "Leaf 3" };

            Branch branch1 = new Branch { NodeName = "Branch 1" };
            Branch branch2 = new Branch { NodeName = "Branch 2" };

            branch1.NodeLeft = leaf1;
            branch1.NodeRight = branch2;

            branch2.NodeLeft = leaf2;
            branch2.NodeRight = leaf3;

            var mapper = InitMapper();

            using (var ms = new MemoryStream())
            {
                var liteRepo = new LiteRepository(ms, mapper);
                liteRepo.Insert(leaf1, NodesCollectionName);
                liteRepo.Insert(leaf2, NodesCollectionName);
                liteRepo.Insert(leaf3, NodesCollectionName);
                liteRepo.Insert(branch1, NodesCollectionName);
                liteRepo.Insert(branch2, NodesCollectionName);

                var liteRepo2 = new LiteRepository(ms, mapper);
                var nodes = liteRepo2.Database.GetCollection<INode>(NodesCollectionName)
                    .IncludeAll()// IncludeAll() deserialize all the objects marked as DbRef
                    .FindAll()
                    .ToList();

                Debug.WriteLine($"first node = {nodes.FirstOrDefault()?.NodeName}");
            }
        }
    }

It can serialize objects, but on deserializing fails with an exception
Failed to create instance for type 'LiteDBIssues.INode' from assembly 'LiteDBIssues.INode, LiteDBIssues, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'. Checks if the class has a public constructor with no parameters.
A compilable solution with the example could be found here
https://github.com/pylnik/LiteDB_Issues/blob/master/LiteDBIssues/LiteDBIssues/TreeTest.cs

litedb collection do not support 'interface'/'abstract class'


Remove event listener touchstart after adding it.

Issue: when you start drawing by mouse and change to drawing by touch , the mouse button stay triggered. causing the undesired drawing on the canvas.

Fix: Remove event listener touchstart after adding it.

Explanation: After changing from this.ontouchstart to this.addEventListener('touchstart'). we should replace this.ontouchstart = null; by this.removeEventListener('touchstart', touchStartProcedure)

@mockdeep I am very bad at naming functions, please review function touchStartProcedure name. and change it to what you see fit.
Thanks

@hassaanalansary thanks for following up on this!

@hassaanalansary you resolved the conversation above, but it doesn't look like you pushed any code changes. Is there more to be done on this?

No, i believe not.
Sorry for the bad follow up. It has been crazy with me.
You can accept the pull request and close it if you please.
Thanks

No, i believe not.
Sorry for the bad follow up. It has been crazy with me.
You can accept the pull request and close it if you please.
Thanks

@mockdeep can you review the change so it can be merged.
I know it has been very long since I start the PR.
Better late than never. :)

@hassaanalansary I unresolved one comment. It would be good to still rename the function. @olivertitze are you able to have another look as well?

@olivertitze fixed that

I reviewed and tested this request. This disables the "Draw it" option by adding the line 366: this.removeEventListener('touchstart', startTouchDrawing), and the issue is real. the switching between mouse and touch is not working. when i use touch pad to draw and then want to use the touch screen, it is not working the same at reverse.

@ehsanmohebbi Did you test this on a Desktop or mobile device? and which browser?
Are you sure the issue is because of this PR or this one
https://github.com/thread-pond/signature-pad/pull/203

@hassaanalansary I tested it on Windows 10 touch screen device using google chrome browser.

@ehsanmohebbi so this fixes the issue for you? When you say "This disables the "Draw it" option" do you mean it is introducing a new bug?

Okay, I'm going to go ahead and merge this. Feel free to open a new issue or PR if things are still broken.


Add support for picking up variables from .env file

It would be great to have support for picking up environment variables from the .env file (I tried it's not working).
Also, I sourced the env variables in my terminal session but they are also not getting picked. I'm not sure what am I doing wrong.
I don't want to add env variables in the yaml file to avoid committing it to git

This is my yaml
description: "My first eval"

prompts:
  - "Write a tweet about {{topic}}"
  - "Write a very concise, funny tweet about {{topic}}"

providers:
  - id: azureopenai:chat:gpt-35-16k
    config:
      apiHost: https://<endpoint>.openai.azure.com
      temperature: 0.4
      apiVersion: 2024-02-15-preview
  - id: openai:gpt-4
    config:
      temperature: 0.4

tests:
  - vars:
      topic: bananas

  - vars:
      topic: avocado toast
    assert:
      # For more information on assertions, see https://promptfoo.dev/docs/configuration/expected-outputs
      - type: icontains
        value: avocado
      - type: javascript
        value: 1 / (output.length + 1) # prefer shorter outputs

  - vars:
      topic: new york city
    assert:
      # For more information on model-graded evals, see https://promptfoo.dev/docs/configuration/expected-outputs/model-graded
      - type: llm-rubric
        value: ensure that the output is funny

I have seen mentions of export OPENAI_API_KEY=your_api_key_here in the docs, so it should work.
I'm using Turbo repo and this is my path /Documents/projects/cool-ai-project/packages/prompts. If it helps investigating the issue.
For now, I'll hardcode API keys in yaml but not commit anything.

This was actually just added in #602!  It'll be in the next published release (probably published within the next 12 hours)

This change is released in 0.50.0.  Thanks!

Hello, thanks for adding this.  Is it possible to pass a non-standard path to an .env file to the CLI?  While our npm scripts are run from the repo root, we prefer not to have any number of .env files cluttering it up, so they tend to go in package-specific sub-directories along with config files (such as promptfooconfig.yaml).


How to share only one file per time?

How to share only one file per time?
I cannot use react-native-share share file to QQ or wechat, because QQ or wechat only receive one file per time.
when I remove below codes in node_modules\react-native-share\index.js,It works.
static open(options: Options | MultipleOptions): Promise {
return new Promise((resolve, reject) => {
requireAndAskPermissions(options)
.then(() => {
// if (options.url && !options.urls) {
//   // Backward compatibility with { Share } from react-native
//   const url = options.url;
//   delete options.url;
//
//   options.urls = [url];
//
//   if (options.filename && !options.filenames) {
//     options.filenames = [options.filename];
//     delete options.filename;
//   }
// }
Possible Implementations
Hope react-native-share provide an option or a new method to do so, QQ/wechat is the most popular social application in china, many people need this feature.

Hi @reallijie , your problem is that whenever you try to share a file to QQ/Wechat you are unable because of the following snippet?
Would you mind sharing which version are you using? 😃

step1: npx react-native init testShare
step2: cd testShare
step3: npm install react-native-share
step4: npx react-active run-android
App.js
import React, {Component} from 'react';
import {Button} from 'react-native';
import Share from 'react-native-share';
export default class App extends Component {
render() {
return (
<Button
title="test share"
onPress={() => {
this.shareFile();
}}
/>
);
}
async shareFile() {
try {
const options = {
url: 'file:///storage/emulated/0/Download/table.pdf',
type: 'application/pdf',
};
await Share.open(options);
} catch (e) {
console.log(e);
}
}
}
package.json
{
"name": "testShare",
"version": "0.0.1",
"private": true,
"scripts": {
"android": "react-native run-android",
"ios": "react-native run-ios",
"start": "react-native start",
"test": "jest",
"lint": "eslint ."
},
"dependencies": {
"react": "16.11.0",
"react-native": "0.62.0",
"react-native-share": "^3.1.2"
},
"devDependencies": {
"@babel/core": "^7.6.2",
"@babel/runtime": "^7.6.2",
"@react-native-community/eslint-config": "^0.0.5",
"babel-jest": "^24.9.0",
"eslint": "^6.5.1",
"jest": "^24.9.0",
"metro-react-native-babel-preset": "^0.58.0",
"react-test-renderer": "16.11.0"
},
"jest": {
"preset": "react-native"
}
}

remove below codes in node_modules\react-native-share\index.js or not.
static open(options: Options | MultipleOptions): Promise {
return new Promise((resolve, reject) => {
requireAndAskPermissions(options)
.then(() => {
// if (options.url && !options.urls) {
// // Backward compatibility with { Share } from react-native
// const url = options.url;
// delete options.url;
//
// options.urls = [url];
//
// if (options.filename && !options.filenames) {
// options.filenames = [options.filename];
// delete options.filename;
// }
// }
[

](url)

Backward compatibility with { Share } from react-native. transform options.url to options.urls is the reason. wechat/qq dont receive file array.

Backward compatibility with { Share } from react-native. transform options.url to options.urls is the reason. wechat/qq dont receive file array.

Do you know any way we can handle these url or urls to these applications? Maybe sharing the Share scheme from both would help us to find a solution.
Also, you meant that calling the Share from react-native works for you?

Share from react-native dose not work in another way.
Provide an option like 'transfromUrlToUrls'/'transformToArray'/'forceToAarry' maybe a solution, user dicide how to use it.

Share from react-native dose not work in another way.
Provide an option like 'transfromUrlToUrls'/'transformToArray'/'forceToAarry' maybe a solution, user dicide how to use it.

What do you think about using Promise.all or Promise.settled? This should be a bit complex, but I remember to use a similar workaround on a project.

I think it is best to be loyal to the user's intention. When user pass a single file, share a single file, when user passes multiple files, share multiple files. In order to be compatible with share, provide a compatibility option, and in order to consider current users, the compatibility option is enabled by default.
As for using promise.all, applications that accept multiple files may face some unpredictable problems.

Is there any progress on this requirement?@MateusAndrade


Update About section of Handbook

[ ] #24
[ ] #32
[ ] Update Architecture to reference dimensional layer and tech radar

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."


fix: Patch asset's lineage

For the UpsertPatchAsset RPC, when no upstreams and downstreams are specified in the request, skip overwriting the asset's lineage unless OverwriteLineage flag is set to true.
Bump up the proton commit in Makefile to pull in changes from https://github.com/odpf/proton/pull/238 + generate protos.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

31 of 42 (73.81%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 86.055%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/server/v1beta1/asset.go
19
30
63.33%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
4980

Relevant Lines:
5787

💛  - Coveralls


Windows installer unexpected behavior

Received reports that the Windows installer:

Defaults the installation directory as AppData\Local\Programs\Canutin instead of the more common Program Files (x86)\Canutin
Progress bar moves forward, but then suddenly goes back half way through the installation.

Defaults the installation directory as AppData\Local\Programs\Canutin instead of the more common Program Files (x86)\Canutin

Looks like AppData\Local\Programs\Canutin is the default path for all Electron apps.

Progress bar moves forward, but then suddenly goes back half way through the installation.

I'm not 100% sure but I would bet each time it goes back is just tracking another dependency it needs to install


Need dep attrs>=19.2

It appears that fastscape depends on 'attrs>=19.2'.  (There was a backward-incompatible change in attrs at that version.)

This has to be fixed in xarray-simlab. Are you referring to this issue https://github.com/benbovy/xarray-simlab/issues/66?

I guess it's the same issue.  Was moving quickly, but when I encountered the error, noted that in a previous case, adding an 'attrs' version constraint would solve the problem.


[request] does the rate/feedback notification really have to appear more than once?

I've played around with your app a bit.
On a random start of the app a "please rate the app" notification came up and I answered with "no, thanks" (or something, but definitely not with "Later").
Several app starts later, the same message came up a second time.
Now I kindly wanted to ask if you please could ensure that the message doesn't come up anymore if the user (like me) don't want to see it again, please?
I don't know, but did not ask your great app "Obsqr" such a question only on the first start of the app, not randomly? If so, this would be a perfect behavior for this app, too.

Fixed in the fork by @smichel17 and my version as well :)

I built an APK including this fix and some more config options: https://github.com/xerus2000/talalarmo/releases/tag/4.0

@xerus2000 I have a couple suggestions for your changes:

Instead of a setting for the offset, segment "tap here to set alarm" into a couple of presets: +1 / +20 / +90 (or make them FABs or buttons on the bottom, there's a couple ways to do it while still keeping  the "turn on" action to one tap.
Instead of a setting for recurrence, allow two alarms to be set at the same time.

They use the same UI
Switch between them with a menu item in the top bar (right side)

Or maybe move the bottom menu up there and put it in the lower right.

Know which one you're on by changing the title "Talalarmo | Once" or "Talalarmo | Daily" and maybe the icon of the swap button
Nice intermediary step for implementation: add the toggle but not the multiple alarms bit (ie, just move it out of the settings and into the UI)

@smichel17 sure that could be done, but it works well for me this way and I have many other projects I'd rather work on ;)
Feel free to pick up my changes in your repo, enable issues, and maybe I will contribute again at some point :slightly_smiling_face:


Added link to Barclays ePDQ driver

This driver is now in production, so adding for others to use.

Thank you, @coatesap


how can i see version to version document diff

how can i know what has changed in the documentation since the last version?
I checked the branches names and commits names. couldn't find any way to figure out version to version changes . for example, asp.net core 2.1 to 2.2 documentation had a lot of changes, but it's not visible atm. it's impossible on every release I go to all pages in the documentation to see what is deprecated and what is not or what is new. so I am looking for a way to get a version to version diff. unfortunately, current branching and tagging don't support this.
I was thinking something like this should be possible with the power of git. I should be able to compare the commit or branch of different releases and get all the changes summary. so, I can update my knowledge only in those areas. in this way, I don't need to go through all the pages and read the whole documentation again and again on each new version release.

2.1 to 2.2 documentation had a lot of changes

Release 2.2 isn't out yet and very little content for 2.2 has been produced (18 open; 1 closed): https://github.com/aspnet/Docs/issues?q=is%3Aopen+is%3Aissue+label%3A2.2 ... Did you mean 2.0 vs. 2.1? There's a migration guide for that set of changes: https://docs.microsoft.com/aspnet/core/migration/20_21
Version-to-version changes are covered by the Migration topics and the Release Notes.
With regard to the work we did on the repo, you could use our issue labels, but it might be a bit of a rough experience. For example, for the 2.1 closed issues ... https://github.com/aspnet/Docs/issues?q=is%3Aissue+label%3A2.1+is%3Aclosed
You're correct about the doc branches ... they don't coincide with engineering releases. We work on a rolling basis and have versioning capabilities for content. Therefore, we can work on any release at any time.

Thanks for contacting us. We believe that the question you've raised have been answered. If you still feel a need to continue the discussion, feel free to reopen it and add your comments.


Deployment issue

Repro steps:

Action: appService.Deploy
Error type: Error
Error Message: Failed to get status of deployment.
Version: 0.15.0
OS: win32
Product: Visual Studio Code
Product Version: 1.36.1
Language: en

Call Stack
Object.<anonymous> extension.bundle.js:332:350604
a extension.bundle.js:332:350244
process._tickCallback next_tick.js:68:7

Hi @sharafu7799
Thanks for reporting.  This happens every once and a while with Azure.  Is it happening consistently?


Making sidebar open automatically with URL

I'm trying to build a sidebar launcher where for example you go to https://name.com/index.php?launchsidebar=2 and then it triggers that sidebar to open automatically instead of the user having to click on the button is that possible with javascript/php? thanks

@jackttcoms you can use the following for JS only approach:
document.addEventListener('ready', function(){   let hash = location.hash;   let id = hash.replace('#', '');   if(id!=null){     let sidebar = document.getElementById(id);     if(sidebar.length>0) $(hash).sidebar('toggle');   } });
URL will be: https://example.com/#sidebar
where "#sidebar" is the element ID
If you want to achieve the same results using PHP, you can use:
document.addEventListener('ready', function(){   $('<?php echo $sidebar_selector; ?>').sidebar('toggle'); });
where "$sidebar_selector" contains either the ID or class of the sidebar element, which you can get from $_GET variable.

Thankyou for your quick reply and answer i also forgot to mention that currently the way to launch the sidebar content is done dynamically by fetching the content via ID so do you know a method that will allow me to do what twitter do where they load the modal window with that exact tweet in it so for example https://name.com/#sidebar18 and then it loads the sidebar as well as the data-href="modal/getcontent.php?id=18"
thanks very much
View Product
`  $(".toc").click(function() {
var dataURL = $(this).attr('data-href');
$('.modal-body').load(dataURL,function(){
  });
   });`

you mean something like this?

yes but instead of a sidebar its now a modal window and the content that i want to automatically load is dynamic so if you want to load product 1 info in modal then link will be https://name.com/?product=1 or https://name.com/#product1 is that possible?
thanks

@jackttcoms yes, you can use the same onShow callback to load the content in your modal window

ok thanks very much but how would i convert this to modal thanks sorry for inconvienience https://jsfiddle.net/hkm5maxe/

@jackttcoms check this example

that didnt work :(
I need it to not open always open. What im trying to achieve is where i have a link on another website then you click it and its like https://name.com/modal/#embed[id] and then it opens and loads the content for whatever the ID is but if there is just a link like https://name.com/modal/ then i dont want the modal to open
`
$(".toc").click(function() {
var dataURL = $(this).attr('data-href');
$('.modal-body').load(dataURL,function(){
});
});
`
thanks for your help

almost where you can load the modal externally so you enter the link
http://www.website.com/page.php?id=[id]#modal
and then when you go to the site the modal will be loaded in automatically and no button needs to be clicked to launch it?
thanks

@jackttcoms you need to check conditions using JS for that.


'name' is missing in type 'Component'

Argument of type 'Component' is not assignable to parameter of type 'INoFloNodeJSComponent'.
Property 'name' is missing in type 'Component' but required in type 'INoFloNodeJSComponent'.ts(2345)
when using getComponent()
its type is
export type ComponentFactory = (metadata?: import("fbp-graph/lib/Types").GraphNodeMetadata) => import("./Component").Component;
export type ModuleComponent = {
    getComponent: ComponentFactory;
};

and that type is just
export namespace Component {
    const description: string;
    const icon: any;
}

or
export class Component extends EventEmitter {
    /**
     * @param {ComponentOptions} [options]
     */
    constructor(options?: ComponentOptions);
    inPorts: InPorts;
    outPorts: OutPorts;
    icon: string;
    description: string;
    /** @type {string|null} */
    componentName: string | null;

I'm not sure ts use which, but both of them don't have name field, required by https://github.com/flowhub/the-graph/issues/622

Ugly workaround
componentDefinitionRaw.getComponent() as unknown as INoFloNodeJSComponent

see https://github.com/noflo/noflo/issues/1035#issuecomment-1631164094 for full type


1144 handle case when group size is equal to 0 for the LCT model

Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:

Catch case where the subpopulation size is zero.
This can happen e.g. if all individuals in the subpopulation die. If this is not handled, we get NaNs in the simulation.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author

[x] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
[x] New code adheres to coding guidelines
[x] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
[x] Tests are added for new functionality and a local test run was successful (with and without OpenMP)
[x] Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
[x] Proper attention to licenses, especially no new third-party software with conflicting license has been added
[ ] (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

[ ] Corresponding issue(s) is/are linked and addressed
[ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
[ ] Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
[ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
[ ] On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1144.

I don't know what happened to the project coverage. Codecov marked an abm file, but that was not changed here.


AAS Agent Bridge (Release)

Benefit Hypothesis
The AAS Binding Agent will translate SPARQL queries formulated over an RDF model into AAS 3.0 API calls.
This means that any AAS registry/server/submodel facility can be federated via the KA approach.
It will finish the prototype work done in #307
Beneficiaries
any participant already deploying AAS technolgy and wanting to participate in Knowledge Agent/Semantic Web Technology
any application based on KA
any use case based on KA
Acceptance Criteria
AAS agent interfaces AAS 3.0 (server + submodel, Part1)
AAS agent interfaces implements AAS 3.0 (registry Part2)
AAS agent can be published to EDC
Estimation
30 SP

Closed by NSC because no progress. Please reopen and assign an upcoming release if needed.


Gallery bug

Trello
Video

I can't really find anything wrong in the code. The swiper repo has over 300 open issues, and a lot of them seems somehow related to orientation.


fanuc: 0.3.2-1 in 'hydro/distribution.yaml' [bloom]

Increasing version of package(s) in repository fanuc to 0.3.2-1:

upstream repository: https://github.com/ros-industrial/fanuc.git
release repository: https://github.com/ros-industrial-release/fanuc-release.git
distro file: hydro/distribution.yaml
bloom version: 0.5.20
previous version for package: 0.3.2-0

fanuc
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_assets
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_driver
* abort on missing J23_factor param (#152 <https://github.com/ros-industrial/fanuc/issues/152>).
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_lrmate200ic5h_moveit_config
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_lrmate200ic5l_moveit_config
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_lrmate200ic_moveit_config
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_lrmate200ic_moveit_plugins
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_lrmate200ic_support
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_m10ia_moveit_config
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_m10ia_moveit_plugins
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_m10ia_support
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_m16ib20_moveit_config
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_m16ib_moveit_plugins
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_m16ib_support
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_m20ia10l_moveit_config
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_m20ia_moveit_config
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_m20ia_moveit_plugins
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_m20ia_support
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_m430ia2f_moveit_config
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_m430ia2p_moveit_config
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_m430ia_moveit_plugins
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_m430ia_support
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

fanuc_resources
* add readmes to all packages (#153 <https://github.com/ros-industrial/fanuc/issues/153>).
* for a complete list of changes see the commit log for 0.3.2 <https://github.com/ros-industrial/fanuc/compare/0.3.1...0.3.2>

Thanks

a nice list of robots, I need to check them out :)

:). Some of the more common models, yes.
All only convex hulls as meshes though, so don't expect any nice visualisation :/ (IP issues).

well, for the IP, have you looked into degraded the mesh quality ? We thought about doing it for NAO: we had the CAD models but did not want to give them away so we simplified the resolution to something that's definitely nice visually (and we also created collision meshes by sampling them even more). In the end, we are distributing the official ones but with a license file. If you are interested in the scripts for that, just let me know
(think about it: if somebody creates the FANUC meshes from scratch, you could get the same results but they might not look cool so it's better for FANUC to keep control of what people use)

Thanks for the comments. We're currently looking into a couple options. For general public release, using convex hulls is at the moment 'the best we can do'. Users of the pkgs that can 'prove' that they have access to the more detailed models themselves (Fanuc does give those out, just not publicly) can get more detailed / textured models from me.
re: scripts: yeah, certainly. Perhaps this issue is not the best place to discuss this ;).

ok, you can send me a personal email, Aldebaran was exactly in the same situation and I can explain the decision we took (which works legally).
The scripts are here: https://github.com/ros-naoqi/naoqi_bridge/tree/master/naoqi_tools/scripts
Basically, it calls blender with good parameters and converts the different mesh formats to work properly with URDF.
If you download the ros-*-nao-description package, you will see the collision meshes it produces in there.


Pr3tori4n/fix sort with extra children 1690

Summary
Related Issue: #1690
I added a new test fixture and test to verify the bug I'm seeing when using .sort method and the sortable instance has a child that doesn't match the draggable selector.
Test is failing with existing code.
New code replaces a call to .children() with a nodeList that queries using the draggable selector. Might need a fallback in the event draggable is null.

More I think about it - this will probably need more work to support other use cases. This works when the extra elements are at the top of the nested children. But due to the sort method removing the elements then appending them, there would be undesirable behavior if there was a non-sortable element in the middle of sortable elements (probably an edge case but could happen with the filtered option) or if they are at the bottom. Will need more robust Dom manipulation logic to properly handle these cases.


branch-2.0 fix coredump for MULTI_MATCH_ANY (#37959)

pick https://github.com/apache/doris/pull/37959
[INVALID_ARGUMENT][E33] Compile regexp expression failed. got Embedded start anchors not supported.. some expressions may be illegal

run buildall

run buildall


Uncaught Error: Cannot read property 'object' of undefinedTypeError: Cannot read property 'objec...

[Enter steps to reproduce:]

...
...

Atom: 1.17.0 x64
Electron: 1.3.15
OS: Microsoft Windows 10 Pro
Thrown From: Atom Core
Stack Trace
Uncaught Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
at ObjectsRegistry.get (C:\Users\D\AppData\Local\atom\app-1.17.0\resources\electron.asar\browser\objects-registry.js:41:28)
at EventEmitter. (C:\Users\D\AppData\Local\atom\app-1.17.0\resources\electron.asar\browser\rpc-server.js:306:31)
at emitMany (events.js:127:13)
at EventEmitter.emit (events.js:201:7)
at WebContents. (C:\Users\D\AppData\Local\atom\app-1.17.0\resources\electron.asar\browser\api\web-contents.js:222:13)
at emitTwo (events.js:106:13)
at WebContents.emit (events.js:191:7)
At C:\Users\D\AppData\Local\atom\app-1.17.0\resources\electron.asar\renderer\api\remote.js:217

Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
    at ObjectsRegistry.get (~/AppData/Local/atom/app-1.17.0/resources/electron.asar/browser/objects-registry.js:41:28)
    at EventEmitter.<anonymous> (~/AppData/Local/atom/app-1.17.0/resources/electron.asar/browser/rpc-server.js:306:31)
    at emitMany (events.js:127:13)
    at EventEmitter.emit (events.js:201:7)
    at WebContents.<anonymous> (~/AppData/Local/atom/app-1.17.0/resources/electron.asar/browser/api/web-contents.js:222:13)
    at emitTwo (events.js:106:13)
    at WebContents.emit (events.js:191:7)
    at metaToValue (~/AppData/Local/atom/app-1.17.0/resources/electron.asar/renderer/api/remote.js:217:13)
    at undefined.remoteMemberFunction (~/AppData/Local/atom/app-1.17.0/resources/electron.asar/renderer/api/remote.js:113:18)
    at AtomEnvironment.module.exports.AtomEnvironment.getWindowDimensions (~/AppData/Local/atom/app-1.17.0/resources/app/src/atom-environment.js:663:1)
    at AtomEnvironment.module.exports.AtomEnvironment.storeWindowDimensions (~/AppData/Local/atom/app-1.17.0/resources/app/src/atom-environment.js:697:1)
    at WindowEventHandler.module.exports.WindowEventHandler.handleWindowBlur (~/AppData/Local/atom/app-1.17.0/resources/app/src/window-event-handler.js:184:1)
    at ~/AppData/Local/atom/app-1.17.0/resources/app/src/window-event-handler.js:3:1

Commands
     -1:52 core:move-up (input.hidden-input)
  3x -1:51.5.0 core:move-left (input.hidden-input)
     -1:50.3.0 core:move-right (input.hidden-input)
     -1:49.4.0 core:backspace (input.hidden-input)
     -1:48.1.0 core:save (input.hidden-input)
     -1:33.9.0 core:backspace (input.hidden-input)
     -1:32.9.0 core:move-down (input.hidden-input)
     -1:32.4.0 core:move-right (input.hidden-input)
     -1:27.8.0 core:backspace (input.hidden-input)
     -1:24.5.0 core:save (input.hidden-input)
  3x -1:00.9.0 core:backspace (input.hidden-input)
     -0:51.3.0 core:save (input.hidden-input)
     -0:38.7.0 autocomplete-plus:confirm (input.hidden-input)
     -0:38.7.0 autocomplete-plus:activate (atom-text-editor.editor.is-focused)
     -0:35.6.0 autocomplete-plus:confirm (input.hidden-input)
     -0:34 core:save (input.hidden-input)

Non-Core Packages

Thanks for taking the time to contribute!
We noticed that this is a duplicate of #11692. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


File structure

After discussing, @liuyenting and I prefer the file structure using root-level directorys.
Please refer to http://docs.meteor.com/#/full/structuringyourapp

Method 1: Root-Level Folders
Since the special client, server, and lib directories work if they are anywhere in the path, you can use top-level folders to organize code into modules:
apples/lib/               # code for apple-related features
apples/client/
apples/server/
oranges/lib/              # code for orange-related features
oranges/client/
oranges/server/

For the dependency problem, please @liuyenting do some further explain.
Also can @liuyenting detail how this file structure benifit the version control and update management?

Actually, my original intent for the file structure is:
root/
root/mods/

root/mods/DEPENDENCIES.db

root/mods/apples/
root/mods/apples/client/
root/mods/apples/server/
root/mods/apples/lib/

root/mods/oranges/
root/mods/oranges/client/
root/mods/oranges/server/
root/mods/oranges/lib/

All the package is managed under mods folder, which means the scanner can implicitly know where to scan the package, and the folder names under the mods folder is directly the installed package, so it's easy to catch-up current mods status.
As for the version controlling and updater script, by replacing the entire folder, and have the main system rescan for module anomalies, module replacement can easily be achieved. And, yup, it also means that we have to abandon the on-the-fly add-on swapping thingy.


Provides support for latest memory initialization annotations

MemoryArrayInitAnnotation, MemoryRandomInitAnnotation, MemoryScalarInitAnnotation

Execution engine has new method referenceTargetToSymbols

Finds all symbols descrived by a reference target

Add code to initialize memory based on these annotations in Memory.scala
Add new test function to demonstrate initialization
Allow for partial paths in reference
Expanded tests to handle the partial paths

Build Dependencies
Build with: git-clone firrtl https://github.com/freechipsproject/firrtl.git master

Do you think you could also add support for the Preset annotation (if you haven't done so yet)?
It essentially does the same thing as the memory init annotation, but for registers (and the init value is just the reset value).
https://github.com/freechipsproject/firrtl/blob/5c0c0018d812d57270035a9d3bd82e2289acf4ec/src/main/scala/firrtl/annotations/PresetAnnotations.scala

PresetAnnotationSpec: https://github.com/freechipsproject/firrtl/blob/ba1f24345ac5ab20c669c73b871920001ac3a8ed/src/test/scala/firrtlTests/PresetSpec.scala

I have just used this feature. Very cool!


Update metrics-core to 4.1.22

Updates io.dropwizard.metrics:metrics-core from 4.1.18 to 4.1.22.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.dropwizard.metrics", artifactId = "metrics-core" } ]

labels: test-library-update, semver-patch

Superseded by #135.


Ensure last breadcrumb doesn't have an href so that it can have aria-disabled="true"

Description
Removed href on last breadcrump in a group so that we can use aria-disabled on it while retaining validity of the HTML.
How has this been tested?

Ran axe-core against build
Validated rendered HTML in W3C Nu Validator
Inspected rendered DOM

Documentation changes
[Do the changes include any API documentation changes?]

[ ] Yes, this change contains documentation changes.
[X] No.

Related Links
AWSUI-18939

Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness

[X] Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
[X]  Changes do not include unsupported browser features, see CONTRIBUTING.md.
[X]  Changes were manually tested for accessibility, see accessibility guidelines.

Security

[ ] If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

[ ] Changes are covered with new/existing unit tests?
[ ] Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

PR title is a bit misleading and does not represent what the code is technically doing. The code is removing the href from the last breadcrumb which just happens to be the disabled.

Apologies, I'm not sure I follow this. The reason we are removing the href IS that the last one has aria-disabled, it doesn't just happen to be disabled. The recommended resolution for AWSUI-18939 is to remove href on crumbs with aria-disabled="true" to prevent invalid HTML from the combination of the two attributes. Were aria-disabled not present there would be no need to remove the href.

Apologies, I'm not sure I follow this. The reason we are removing the href IS that the last one has aria-disabled, it doesn't just happen to be disabled. The recommended resolution for AWSUI-18939 is to remove href on crumbs with aria-disabled="true" to prevent invalid HTML from the combination of the two attributes. Were aria-disabled not present there would be no need to remove the href.

The misleading part is the title currently suggests that any breadcrumb that it will remove the href of any breadcrumb that has aria-disabled=true but that is not the case.

I see, thank you for the explanation @michaeldowseza . I've updated the PR title and unit test logic.


CLOUDP-61290: Validate base url

Proposed changes
Jira ticket: CLOUDP-61290
Checklist

[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added any necessary documentation (if appropriate)
[x] I have run make fmt and formatted my code

Further comments
This is a breaking change, users will need to update their base url to include a trailing slash

something seems broken in the e2e test. Do you think it is related to this changeset?

@andreaangiolillo yes I need to change a setting in drone but since you have a PR I'm waiting for that as the change would break you instead

@andreaangiolillo fix


Feature/in memory test db

For #5.
While I was at it:

super lightweight quick start in README
Added a couple tests for existing db assumptions

NOTE: This adds a dependency on Test::Exception

@jmacdotorg would you mind taking another glance? I updated image directory logic to work with transient databases & want to be sure I didn't miss anything important before merging.

Looks great! Just one more tiny request: Could you please add a comment to Core.pm explaining the purpose of $TRANSIENT_DB? I know with certainty that in a few months I'll have no idea (at a glance) what it's doing there.


[Bug][Spark]: Neo4j2GraphAr change the type

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

The former data type is Long in neo4j. But after importer, it becomes string when there is a null.
Just like this.
Expected Behavior
Fix it.
Minimal Reproducible Example
Maybe this.
Environment

Operating system: ubuntu
GraphAr version: latest

Link to GraphAr Logs
No response
Further Information
No response

When do import, the first warnning log maybe a key infomation as the image shows.

Maybe we can use the APOC procedure, but it only available in
enterprise edition

And anther solution is change the option schema.flatten.limit to 1(default is 10). I change the code
https://github.com/alibaba/GraphAr/blob/fe4ebb9b2dbcf30e63cd3895a51d4d614fe80df3/spark/src/main/scala/com/alibaba/graphar/example/Neo4j2GraphAr.scala#L75-L78
to
    val person_df = spark.read
      .format("org.neo4j.spark.DataSource")
      .option("schema.flatten.limit", 1)
      .option("query", "MATCH (n:Person) RETURN n.name AS name, n.born as born")
      .load()

and it work, the schema of person_df turns to be
root
 |-- name: string (nullable = true)
 |-- born: long (nullable = true)

And I think this is not the bug of GraphAr, so I change the title and label to improvement.


Bucket 3: Posts

Summary
Updating File Attachment
Updating Single Image title
Ticket Link
https://mattermost.atlassian.net/browse/MM-22842
https://mattermost.atlassian.net/browse/MM-22848
Screenshots

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-5282.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Looks great, minor things for UX to consider:

Should corner rounding should be increased slightly to match single image previews?

How can we handle other themes better? Can we be clever about the color choice for the icons so it's compatible with various center pane BG colors (without needing a white background)?

Example:

Should we consider decreasing the vertical height and icon size even more? Example comparison:

Adding @andrewbrown00 given he did the mobile design and would have best knowledge about how best to adapt for webapp ^

They are both 4px right now.
Yeah, that's one thing I was also thinking about.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Test server creation failed. See the logs for more information.

@esethna @asaadmahmood @andrewbrown00 to address themes, I think all we need to brighten the colors a bit. I did a quick test with the colors below. This should work with any theme

Excel: 1CA660
PDF: E81023
Text: 999999
PPT: D95431
Word/Others: 1976F2
As for the size of the icons, I think going down to 40px in height would work. I'll defer to @andrewbrown00 though since it sounds like he designed the original icons

Also, can we update the download icon for this PR (and remove the circle and update to the new hover style you used with the other PRs you've been working on)? Or should that be a separate effort?

Thanks for all the feedback here and I'm 5/5 good

Also, can we update the download icon for this PR (and remove the circle and update to the new hover style you used with the other PRs you've been working on)? Or should that be a separate effort? See the screenshot below (this also shows a smaller attachment icon for reference)

I really like this design with the updated download icon button and reducing the overall attachment icon size to 40px.
Exploring color options to increase contrast and using one color to cover all themes. Matt's proposal is solid, we're quickly exploring tweaking some colors to hit accessibility contrast across all themes.

+1 on the above. If we want to go a set further for cleanliness we can probably only have the download button appear when hovering over the attachment. ie doing a part implementation of this ticket: https://mattermost.atlassian.net/browse/MM-22841
cc// @asaadmahmood on all the above

Also if we are reducing the icon height should we also consider reducing the height of the container?

@esethna Will have a look at this tomorrow.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 583fbccd21644ae5dd8c701b56678d30f4c4f4ae.
Access here: https://mattermost-webapp-pr-5282.test.mattermost.cloud

@andrewbrown00 Is doing some modifications to the icons, so I'll update this PR with that.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 8afdda78851c9b45b304cadb71054f105883ccf6.
Access here: https://mattermost-webapp-pr-5282.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Test server creation failed. See the logs for more information.

Mattermost test server updated with git commit 7845eb3b75789f34d17fd384c0fb0d1e4b78e083.
Access here: https://mattermost-webapp-pr-5282.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 9bec35cc896a67bef6dd2b38a15901d507210a61.
Access here: https://mattermost-webapp-pr-5282.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit f7dd3a9ce29daa1ff449ffb9ba14885aa24f7635.
Access here: https://mattermost-webapp-pr-5282.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 3e42eee29258a7c9ce714652f7e764d907553a37.
Access here: https://mattermost-webapp-pr-5282.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 8a6c01cffb451b65a683656f4c74d7dc4b19b1f2.
Access here: https://mattermost-webapp-pr-5282.test.mattermost.cloud

Looks great!

Thanks guys. @andrewbrown00 @asaadmahmood, regarding the zoom in cursor, maybe it makes sense for images that are previewed in the post list like this:

But for the file attachments it feels off in my opinion, given some are previewable and other aren't, and if it does

Also for the draft state, do we want to tweak the alignment of the "x" button to move it to the same position as the download button? Or are we okay with it floating in the corner? 0/5

@esethna We do offer a way to open up the file in a modal, which has additional options (even if the preview for that is not available), so the zoom does identify some functionality, so I'll be inclined to keep it.
And regarding the x button, I would like to keep it location at the top right, as that what we usually do the x icon.
I also don't want to make it as prominent as the download button by increasing the size or placing it in the same place, as it is quite a different action.

@asaadmahmood @andrewbrown00 I have never seen that type of a cursor used before for file type attachments. Check out gmail as an example. Even Slack only shows the zoom in cursor on images (or some things they can preview), if there's no preview they show the normal hand cursor.
I'm 4/5 that someone will report this as a bug within a week of it getting on community-daily.

@esethna maybe we can take a quick pole on Monday's call and see which cursor feels right.
I did check out a few other products and it seems like most use the pointer cursor for attachments, but I'm 0/5 if it's based on research or defaulting to using the pointer cursor for all actionable elements /which I'm 4/5 is wrong/. In this context, clicking the image or the attachment /based on type/ does open a preview /larger or zoomed view/ for almost all attachments the zoom-in cursor feels like the right affordance.
I do agree that if we can't /or don't currently/ show an actual preview we should use the pointer cursor; and also consider making download the primary action for non-preview-able attachments.
Slack does use the zoom-in cursor for images and preview-able attachments. They don't for text/code files and .zips and instead use the pointer cursor, but the primary action is either to download or open (for text/code files) in the RHS.

@esethna @andrewbrown00 I don't mind the pointer, as that's just very common behaviour, while zoom based on my experience has been quite seldom.
@andrewbrown00 I don't want a different behaviour for different type of attachments, as that would just look inconsistent. You decided we should have the download button hidden because it was not the primary action. So I'm supposing that some file types will have the download button visible (if that's their primary action), while on others it would be hidden, which would be quite weird, and may even seem like a bug. As there are various file extensions that do have a preview that are not images, like code files, pdf etc.
I would prefer if we are consistent.

I would suggest keeping the download button hidden, irrespective of primary/secondly action, and use either the zoom in pointer, or the cursor pointer (I lean more towards the cursor) for all file attachments.
The file attachments in the draft area can have a normal cursor the way it is right now.

@asaadmahmood @andrewbrown00 since the goal of this PR is UI reskin, I'd propose if we want to make changes to UX we should create separate tickets and pass them through review.
So I'd propose in this PR to keep it moving we:

Make no to changes to primary actions (ie clicking the attachment should open the preview window as it's done always)
Keep the pointer cursor on hover, and
Have the download button hidden unless hovering on the attachment

If there's strong feels against that we can discuss on Monday?

I'm fine with that, or keeping the zoom in cursor the way it is right now.
Visually or functionally, I don't want the thumbnails to behave differently depending on whether the preview modal shows an actual preview or not.

Going to review the PR but just wanted to throw out one piece of feedback: I prefer the larger thumbnail for images. Sometimes the extra few pixels make a big difference. Can we keep the thumbnail "bleed" to the edge?

@andrewbrown00, @asaadmahmood, I agree with @esethna on the cursor. I understand the idea behind it, but I don't think there is a mental model for that kind of cursor change for attachments. It doesn't feel quite right to me. I think we should stick with the standard click pointer cursor.
Also, I get what @bradjcoughlin is saying. I miss having a larger preview of the image attachments.  I know we discussed this idea, but in order to keep things aligned, we would have to do something like the below if we want to go with the larger full-bleed attachment image:

@matthewbirtch I was already in favour of the cursor, so that sounds good to me.
And I also miss the larger thumbnail, but I'm guessing we both don't really like the border for the icons.

We chatted about the cursors on Monday's call and decided to be consistent and use the pointer cursor for all images and attachments.
We have historical feedback that added more context to why/how we handle image previews and why the download-only action causes friction for users since it makes previewing batch uploads confusing since we'd omit the download-only attachments from the preview.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit df7726b3e5453161b6603763aa3ff38cfc9398b6.
Access here: https://mattermost-webapp-pr-5282.test.mattermost.cloud

@bradjcoughlin We'll be taking in the changes right now, we're going to see how this feels. I also personally prefer the larger thumbnails. We may end up increasing the size and figure out a workaround if it feels off to others too.

@nevyangelova @lindy65 ready for dev and QA review

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 0e8ec79bff684b96340748a0bf3aca1257bad171.
Access here: https://mattermost-webapp-pr-5282.test.mattermost.cloud

LGMT minus the lint error :)

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 21bb7a0bce1fef07328c53b386332dff174582e4.
Access here: https://mattermost-webapp-pr-5282.test.mattermost.cloud

@saturninoabril We can show it on that size. I'll fix that.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Test server destroyed


Enable YAML stages

Resolves https://github.com/aspnet/AspNetCore/issues/11924 and https://github.com/dotnet/arcade/blob/master/Documentation/CorePackages/YamlStagesPublishing.md for EFCore. @dougbu @JunTaoLuo should I port this to any of the release branches (once I have it working)?
@JohnTortugo @bricelam PTAL

I'll spin up a private internal build w/ these changes after Tactics

##[error]Metadata\Conventions\NonNullableConventionBase.cs(62,53): error CS0246: The type or namespace name 'MaybeNullAttribute' could not be found (are you missing a using directive or an assembly reference?)

Looks like one of the issues we saw in the standup yesterday @JunTaoLuo @dougbu, do we know what the fix is for this one yet?

Internal build is looking good as far as Stages goes: https://dev.azure.com/dnceng/internal/_build/results?buildId=300828

Closing in favor of https://github.com/aspnet/EntityFrameworkCore/pull/17040

@wtgodbe don't try to make this change in 'master' as that branch is broken and our team consistently makes changes in 'release/3.0' first then uses the merge bot's PRs to get things to 'master'.


don't listen to events when not shown

Currently, scrolling performance can be degraded when lots of popper instances are used on a single page.
Here are two animation frames triggered from scroll events:

This change disables popper's event listeners when they are not shown. Here are two animation frames triggered from scroll events after this change:

@indirectlylit thanks


Fix small chunk finaliser premature re-use bug

Prior to this commit, if a small chunk was partially used after GC
and had finalisers to be run for the freed slots, the execution of
the finaliser could end up reusing the slots for which finalisers
were being run. If this occurred, it would lead to unpredictable
results (a segfault in my case).
This commit changes the order of operations to ensure that all the
finalisers are run prior to the chunk being added back to the
available list ensuring that the execution of the finaliser cannot
allocate slots that are still to be finalised.

Thanks @dipinhora!


⚠ Bofrost.nl has degraded performance

In e2c00e1, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1180 ms

Resolved: Bofrost.nl performance has improved in 6648633.


[KOGITO-610] Adding persistence=required to image labels

See:
https://issues.jboss.org/browse/KOGITO-610
A final image_metadata.json with persistence enabled will look like this:
{
  "labels" : [ {
    "org.kie/onboarding" : "process",
    "prometheus.io/path" : "/metrics",
    "prometheus.io/scheme" : "http",
    "prometheus.io/port" : "8080",
    "prometheus.io/scrape" : "true",
    "org.kie/persistence/proto/onboarding.onboarding.proto" : "H4sIAAAAAAAAAM1WTW8TMRA9d3/FKCeoYEvT8qUqEhUtUg5AReHAqZrEw2LitS17UmWL+t8Zb7yBltIDGCknT8aTN2PP2zeOnWVcwQRGPjh249ERVB7nC2wIXGjqhaZ64RrNrqYVtt5QrJ2dOQxK2+ZuUyB0611gGK3/+lhbRau6zzA6ur3JnRfQYdN51s7Ceu+idYpMqu79Bv23GK1SwJ2VSGy1twuvpik/Kdjdg6qlGNPpjpUKYsJ3qHYy4De8xIvh9AnzLy9A0u6ktG80GfUgsgsJ7jyt9efT80eAFk13lZzHayu5H/bl5VrQQOQgWDDX3EngvtxqQVC3tBwS7rgorixELKEHRWGvtH8tTJDYQ8G9/mNPT6U/riPa3qYOrMO8FmtsPs4JMsFMB/7aW6X7+0WHyO+wpeItNrgBPiwK7CnE9HuaZOLpvfT5KTLbS6B8KkUeA7dkubg2UIvalGPO5pukwShNnQG473BZ8uiBNOUgWwluKEjss7K4mcQTeF4G9wy74IwBn9cJvCg8K5CXSQFf/hNsIE8ider2c2X95ugfEPVZcHO5nqmVnHZOb4kR/E1fL8VP/nslnyKFjxgXN0pZZmdfw/69EjU0ZWv16dc5JMxJCpUnUSGVUm45MwTyav1QdMJpywdjuMQ5JscJdjEL1XX1A2Y4D7QlCwAA",
    "org.kie/persistence/required" : "true"
  } ]
}

We will remove the "proto" labels soon, so having this new one will help Operator to find out when we need persistence for Kogito Runtime Services.

Sonar is complaining about the lack of tests on PersistenceGenerator.java file. I think we should consider adding a test for it, or refactor it into small pieces.

Few minor comments but looks good overall

Fixed, thanks. IDE was mocking with me... I'm getting used with IntelliJ


Bluetooth: controller: Fix empty_pkt_us_get for 2M phy.

An empty packet on 2M phy is one more byte compared to 1M phy because
of the preamble.
The empty packet is then 11 bytes, which takes 44 us to transmit.

FYI @cvinayak


Disable SSL cert checking

Hi is this possible ? I'm running against a dev server and can't get a valid cert until we go to prod.

Ignore that - found it.

@carlskii
Could you share the answer to your question.
Might be useful in case someone else encounters the same problem. Thanks!

I just added the following:
var proxy = proxyMiddleware('/api', {
  target: 'https://xxx.xxx.xxx.xxx',
  changeOrigin: true,    // for vhosted sites, changes host header to match to target's host
  secure: false
 // headers: {'content-type': 'application/json'}
});

Just added the secure: false option

Great. Thanks!


[ch24676] [etools-data-table] Replace CSS mixins with CSS Shadow Parts

[ch24676] [etools-data-table] Replace CSS mixins with CSS Shadow Parts

TODO
handle mixins that are not documented in README, like:
--row-width
--hover-setting

TODO - create major version


A bug in tf.maximum

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
tf 2.14.0
Custom code
Yes
OS platform and distribution
windows colab
Mobile device
No response
Python version
3.10
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
According to tf.maximum doc, the two inputs of tf.maximum must have the same type. In following code, when first input is float type, second input is int type, tf.maximum outputs a tensor. While when first input is int type, second input is float type, tf.maximum throws error. IMO, If tf.maximum(epsilon, x) is working I think tf.maximum(x, epsilon) should also work and generate same output. Actually, I have a model crash when training due to this small difference.
Standalone code to reproduce the issue
import tensorflow as tf
x=5
epsilon = 1e-12
print(tf.maximum(epsilon, x))
print(tf.maximum(x, epsilon))

Relevant log output
tf.Tensor(5.0, shape=(), dtype=float32)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-4-095832aa68e6> in <cell line: 5>()
      3 epsilon = 1e-12
      4 print(tf.maximum(epsilon, x))
----> 5 print(tf.maximum(x, epsilon))
      6
      7 #tf.Tensor(5.0, shape=(), dtype=float32)

/usr/local/lib/python3.10/dist-packages/tensorflow/python/ops/gen_math_ops.py in maximum(x, y, name)
   6339   if tld.is_eager:
   6340     try:
-> 6341       _result = pywrap_tfe.TFE_Py_FastPathExecute(
   6342         _ctx, "Maximum", name, x, y)
   6343       return _result

TypeError: Cannot convert 1e-12 to EagerTensor of dtype int32

Hi,
For the first instance, the casting is performed by default internally which casts both the inputs based on the first input dtype, which is float.
In second case, this can nlt be performed since epsilon value can not be converted to int.
You need to perform the explicit tf.cast to a desired dtype to continue with the operation.


Suggestion.

How could I remove the bold in the objects?
Could you add a button that allows you to reset them without having to disconnect?

Not possible currently, as the bold object is a visual representation of an object with the metadata loaded
But if you really want to completely remove the bold visual option, you can create a fork, and edit src/gui/controls/DBHTreeControl.cpp, changing every line with nodeTextBoldM = true; to nodeTextBoldM = false;
If you change in your repo in the main branch github Action will build the setup for you :)
Also, you can do an better work and create a configurable option to enable/disable this visual hint, and pull a merge request for us 👍

Ok


How to see elapsed time in rendering view

Normally, Rails writes logs like
Completed 200 OK in 40ms (Views: 7.3ms | ActiveRecord: 0.0ms)

in development.log.
However, when using grape, it doesn't. How can I see elapsed time?

This is something you can do with a middleware. There're a few in the logging section of http://www.ruby-grape.org/projects, but you'll probably will have to write one to achieve exactly this. Other possibly better long term solutions are things like newrelic.
I'm going to close this, please use the mailing list for questions.


Preview image being added to the page instead of the full image.

Reported from discord see: https://discord.com/channels/835168149439643678/835172431836479508/1035926478585593937
PR that caused the issue: https://github.com/tinacms/tinacms/pull/3284

Fixed with https://github.com/tinacms/tinacms/pull/3347


Improvements for sample based AOVs.

Sorry for the conflicts!

No prob. It wasn't much.

What's the use case for on_sample_begin() / on_same_end() and especially max_spp?

What's the use case for on_sample_begin() / on_same_end() and especially max_spp?

AOVs that work with samples, for example AOVs that output deep images, cryptomatte or the denoiser outputs.
Passing max_spp to on_tile_begin allows preallocating memory for all samples in a tile.


My User Changes

[x] Backend: Implement my user changes in auth service (https://github.com/caos/zitadel/pull/318)
[ ] Frontend: my user changes from auth service on personal information

additional method in backend can called after https://github.com/caos/zitadel/pull/318 is merged

@peintnermax backend is done