ConfirmationDialog sends an unexpected dismiss when presenting the second one

Demo.zip

Demo.zip contains a bit more than minimal reproducible stuff, so I recommend to use code below to reproduce the issue

// the code below is updated, so if u use Demo.zip, just paste it to ContentView.swift

import SwiftUI
import ComposableArchitecture

struct SomeState: Equatable {
  var dialog1: ConfirmationDialogState<DialogActions1>?
  var dialog2: ConfirmationDialogState<DialogActions2>?
}

enum SomeAction: Equatable {
  case present1
  case present2
  case dialog1(DialogActions1)
  case dialog2(DialogActions2)
}

enum DialogActions1: Equatable {
  case ok
  case cancel
  case dismiss
}

enum DialogActions2: Equatable {
  case ok
  case cancel
  case dismiss
}

let reducer = Reducer<
  SomeState,
  SomeAction,
  Void
> { state, action, environment in
  switch action {
  case .present1:
    state.dialog1 = ConfirmationDialogState(
      title: TextState("Title 1"),
      message: nil,
      buttons: [
        .default(TextState("OK"), action: .send(.ok)),
        .cancel(TextState("Cancel"), action: .send(.cancel))
      ]
    )
    return .none

  case .present2:
    state.dialog2 = ConfirmationDialogState(
      title: TextState("Title 2"),
      message: nil,
      buttons: [
        .default(TextState("OK"), action: .send(.ok)),
        .cancel(TextState("Cancel"), action: .send(.cancel))
      ]
    )
    return .none

  case .dialog1(.ok):
    return Effect(value: .present2)

  case .dialog1:
    state.dialog1 = nil
    return .none

  case .dialog2:
    state.dialog2 = nil
    return .none
  }
}.debug()

let store = Store(
  initialState: SomeState(),
  reducer: reducer,
  environment: ()
)

public struct ContentView: View {
  public var body: some View {
    WithViewStore(store) { viewStore in
      Button("Tap") {
        viewStore.send(.present1)
      }
    }
    .background(
      ZStack {
        Color.clear
          .confirmationDialog(store.scope(state: \.dialog1, action: SomeAction.dialog1), dismiss: .dismiss)
        Color.clear
          .confirmationDialog(store.scope(state: \.dialog2, action: SomeAction.dialog2), dismiss: .dismiss)
      }
    )
  }
}

Expected behavior
Do not send .dismiss on present 🌚
Environment

swift-composable-architecture [main (#15c39e5)]
Xcode [12.5.1]
Swift [5.4.2]
OS: [iPhone 12 Pro simulator (iOS 14.5)]

Also, I'm not sure if you are able to dismiss the alert without a .cancel by nilling out the state 🤔

@maximkrouk Can you explain more of what you think the problem is? Running this code behaves as I would expect it to:

Tapping "tap" sets dialog1 state.
Tapping "OK" dismisses dialog1 and sends dismiss before sending ok immediately after, which presents dialog2

@maximkrouk or possibly do you have an example in Vanilla SwiftUI with the expected behaviour?

Also, I'm not sure if you are able to dismiss an alert without a .cancel button by nilling out the state

It is possible to dismiss presentations by nilling out the state in the reducer.

I'll take a look here again this week 🙂

@maximkrouk Were you able to confirm if this still seems like a bug to you?

Yep.
Reducer logs:
received action:
  SomeAction.present1
  SomeState(
-   dialog1: nil,
+   dialog1: ConfirmationDialogState(
+     title: "Title 1",
+     message: nil,
+     buttons: [
+       [0]: AlertState.Button.default(
+         "OK",
+         action: AlertState.ButtonAction.send(DialogActions1.ok)
+       ),
+       [1]: AlertState.Button.cancel(
+         "Cancel",
+         action: AlertState.ButtonAction.send(DialogActions1.cancel)
+       )
+     ]
+   ),
    dialog2: nil
  )

received action:
  SomeAction.dialog1(DialogActions1.dismiss)
  SomeState(
-   dialog1: ConfirmationDialogState(
-     title: "Title 1",
-     message: nil,
-     buttons: [
-       [0]: AlertState.Button.default(
-         "OK",
-         action: AlertState.ButtonAction.send(DialogActions1.ok)
-       ),
-       [1]: AlertState.Button.cancel(
-         "Cancel",
-         action: AlertState.ButtonAction.send(DialogActions1.cancel)
-       )
-     ]
-   ),
+   dialog1: nil,
    dialog2: nil
  )

received action:
  SomeAction.dialog1(DialogActions1.ok)
  (No state changes)

received action:
  SomeAction.present2
  SomeState(
    dialog1: nil,
-   dialog2: nil
+   dialog2: ConfirmationDialogState(
+     title: "Title 2",
+     message: nil,
+     buttons: [
+       [0]: AlertState.Button.default(
+         "OK",
+         action: AlertState.ButtonAction.send(DialogActions2.ok)
+       )
+     ]
+   )
  )

received action:
  SomeAction.dialog2(DialogActions2.dismiss)
  SomeState(
    dialog1: nil,
-   dialog2: ConfirmationDialogState(
-     title: "Title 2",
-     message: nil,
-     buttons: [
-       [0]: AlertState.Button.default(
-         "OK",
-         action: AlertState.ButtonAction.send(DialogActions2.ok)
-       )
-     ]
-   )
+   dialog2: nil
  )

received action:
  SomeAction.dialog2(DialogActions2.dismiss)
  (No state changes)

received action:
  SomeAction.dialog2(DialogActions2.ok)
  (No state changes)

Short version:

UI: Tap "Tap"
Store: .present1
UI: Show the first dialog

UI: Tap "OK"
Store: .dismiss1 // yep, I don't expect it to be recieived before the action, but it's not a big issue
UI: Hide the first dialog
Store: .ok1
Store: .present2
UI: Show the second dialog

Store: .dismiss2 // it was sent automatically and the state is nil now, but the dialog is on the screen and waiting for input
UI: Tap "OK"
Store: .dismiss2 // but state is already nil
UI: Hide the second dialog
Store: .ok2

@maximkrouk I can't reproduce using the code you provide in the original post.
I'm on Xcode 13.2 (on an M1, so can't use Xcode 12) running an iOS 15 simulator. Can check to see if this problem can be pinpointed to a specific version of Xcode and SwiftUI? That is, can you reproduce the problem in Xcode 12 but things are fine for you in Xcode 13.2?
Here are my logs for the same actions. Note only a single DialogActions2 .dismiss:
received action:
  SomeAction.present1
  SomeState(
-   dialog1: nil,
+   dialog1: ConfirmationDialogState(
+     title: "Title 1",
+     message: nil,
+     buttons: [
+       [0]: AlertState.Button.default(
+         "OK",
+         action: AlertState.ButtonAction.send(DialogActions1.ok)
+       ),
+       [1]: AlertState.Button.cancel(
+         "Cancel",
+         action: AlertState.ButtonAction.send(DialogActions1.cancel)
+       )
+     ]
+   ),
    dialog2: nil
  )

objc[46295]: Class _PathPoint is implemented in both /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/UIKitCore.framework/UIKitCore (0x128732bb8) and /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/TextInputUI.framework/TextInputUI (0x139185210). One of the two will be used. Which one is undefined.
objc[46295]: Class _PointQueue is implemented in both /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/UIKitCore.framework/UIKitCore (0x128732b90) and /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRoot/System/Library/PrivateFrameworks/TextInputUI.framework/TextInputUI (0x139185238). One of the two will be used. Which one is undefined.
received action:
  SomeAction.dialog1(DialogActions1.dismiss)
  SomeState(
-   dialog1: ConfirmationDialogState(
-     title: "Title 1",
-     message: nil,
-     buttons: [
-       [0]: AlertState.Button.default(
-         "OK",
-         action: AlertState.ButtonAction.send(DialogActions1.ok)
-       ),
-       [1]: AlertState.Button.cancel(
-         "Cancel",
-         action: AlertState.ButtonAction.send(DialogActions1.cancel)
-       )
-     ]
-   ),
+   dialog1: nil,
    dialog2: nil
  )

received action:
  SomeAction.dialog1(DialogActions1.ok)
  (No state changes)

received action:
  SomeAction.present2
  SomeState(
    dialog1: nil,
-   dialog2: nil
+   dialog2: ConfirmationDialogState(
+     title: "Title 2",
+     message: nil,
+     buttons: [
+       [0]: AlertState.Button.default(
+         "OK",
+         action: AlertState.ButtonAction.send(DialogActions2.ok)
+       ),
+       [1]: AlertState.Button.cancel(
+         "Cancel",
+         action: AlertState.ButtonAction.send(DialogActions2.cancel)
+       )
+     ]
+   )
  )

received action:
  SomeAction.dialog2(DialogActions2.dismiss)
  SomeState(
    dialog1: nil,
-   dialog2: ConfirmationDialogState(
-     title: "Title 2",
-     message: nil,
-     buttons: [
-       [0]: AlertState.Button.default(
-         "OK",
-         action: AlertState.ButtonAction.send(DialogActions2.ok)
-       ),
-       [1]: AlertState.Button.cancel(
-         "Cancel",
-         action: AlertState.ButtonAction.send(DialogActions2.cancel)
-       )
-     ]
-   )
+   dialog2: nil
  )

received action:
  SomeAction.dialog2(DialogActions2.ok)
  (No state changes)

(This might be an issue with SwiftUI 1/2's .alert view modifier vs. SwiftUI 3's, which has changed significantly. I wonder if it's a bug in the previous version of .alert that has been fixed. There were a few known issues with that view modifier.
We'd definitely be interested in a workaround if so.)

@stephencelis I've been able to reproduce. It's to do with OldConfirmationDialogModifier and .actionSheet. I'll have a go at fixing later today.

I've been able to achieve the same behaviour without TCA. This seems like more of an .actionSheet issue.
A possible workaround could be to defer the presentation of dialog2 in the reducer. eg:
  case .dialog1(.ok):
    return Effect(value: .present2)
      .deferred(for: 0, scheduler: environment.mainQueue)

Sending the sheet actions via DispatchQueue.main.async would also work, however, incorporating that into the library doesn't seem right.
Here's the Vanilla version demonstrating the same issue:

VanillaContentView.swift

struct Dialog: Identifiable {
  public let id = UUID()
  var title: String
}

struct VanillaContentView: View {
  @State var dialog1: Dialog? = nil
  @State var dialog2: Dialog? = nil

  var body: some View {
    Button("Tap", action: present1)
      .background(
        ZStack {
          Color.clear
            .actionSheet(item: $dialog1.didSet(perform: dismiss1)) { dialog in
              ActionSheet(
                title: Text(dialog.title),
                buttons: [
                  .default(Text("OK"), action: present2),
                  .cancel(Text("Cancel"), action: dismiss1),
                ]
              )
            }

          Color.clear
            .actionSheet(item: $dialog2.didSet(perform: dismiss2)) { dialog in
              ActionSheet(
                title: Text(dialog.title),
                buttons: [
                  .default(Text("OK"), action: {}),
                  .cancel(Text("Cancel"), action: dismiss2),
                ]
              )
            }
        }
      )
  }

  func present1() {
    print("present1")
    self.dialog1 = Dialog(title: "Title 1")
  }

  func dismiss1() {
    print("dismiss1")
    self.dialog1 = nil
  }

  func present2() {
    print("present2")
//    DispatchQueue.main.async {
    self.dialog2 = Dialog(title: "Title 2")
//    }
  }

  func dismiss2() {
    print("dismiss2")
    self.dialog2 = nil
  }
}

extension Binding {
  func didSet(perform action: @escaping () -> Void) -> Self {
    .init(
      get: { wrappedValue },
      set: { wrappedValue = $0; action() }
    )
  }
}

Happy to explore this further but will wait for some feedback.

I'll check the defer workaround soon, but I can confirm, that as @stephencelis mentioned - the issue is no longer reproducible on Xcode13.2-beta and iOS15 (currently I use Xcode12.5 and actually the issue is not critical for me since I'm using UIKit)

Well, I guess it's not a library-level problem and the defer workaround works even with UIScheduler.shared, so I'm closing the issue 🙂


Any event that atribute to constraint length?

Hello!
I couldn't find any info on the internet, except your old reply that implies that this is possible:

How may I check the length of the constraint to then "cut" it?  I have a bunch of bodies with two constraints attached to each. I want to check every tick if constraint is more than the N limit of length and then 'cut' it.
Here's what I've already done:
Matter.Events.on(engine, "afterUpdate", () => {

                Matter.Composite.allConstraints(world).forEach(constraint => {
                    // constraint.length += 1
                    console.log(constraint)
                    // if (constraint.length > 50) {
                    //     Matter.Composite.remove(world, constraint)
                    // }
                })
            })

Any ideas or maybe events that will get me straight to the point?
Thanks ahead!

By calculating the Euclidean distance between the two glued points?

The property constraint.length is the rest length, what you also need is the current length:
const currentLength = Vector.magnitude(Vector.sub(Constraint.pointAWorld(constraint), Constraint.pointBWorld(constraint))); (thinking I might add a function for that!)
Then you can check currentLength / constraint.length > threshold and decide if to remove the constraint.


Preserve new lines after directives in babylon

It's annoying that the line after "use strict"; gets eaten away on babylon. This fixes it :)
Fixes #216

Cool, thanks!
It would be nice if we could automatically run all the tests with both flow and babylon. Some tests weren't working before under babylon, but we're probably a lot closer now for that. We should try it at some point.


[Documentation] DoR - Add a checklist specifics for Spark in the documentation

@turolopezsanabria could you please clarify what "DoR" means in this context?


[Backend] Add collect shape for pp-trt backend

PR types

New features
PR changes

APIs
Describe

Add collect shape for pp-trt backend

Windows测试

Windows测试

done


don't truncate text columns that contain nul bytes

If a text column in sqlite contains a nul byte, the string returned by rusqlite is silently truncated at the first nul byte, instead of the text either being returned in full or an error raised. This patch alters the code to use the blob interface to retrieve the text, which is nul-safe.
I benched the change, and there doesn't seem to be a significant difference in performance:
    #[bench]
    fn bench_string_column(b: &mut Bencher) {
        let db = Connection::open_in_memory().unwrap();
        db.execute_batch("create table tbl(val text);").unwrap();
        db.execute("insert into tbl values (?)", params!["a".repeat(256)])
            .unwrap();

        db.query_row("select val from tbl", params![], |row| {
            b.iter(|| {
                let s: String = row.get(0).unwrap();
            });
            Ok(())
        })
        .unwrap()
    }

with bytes:
test bench::bench_string_column ... bench:         152 ns/iter (+/- 8)

with old string code:
test bench::bench_string_column ... bench:         150 ns/iter (+/- 7)

Without this change, it should still be possible to retrieve the full value by casting the text to a blob in the SQL query, but given that the current behaviour can result in silent data corruption when a value is read and then written back, I thought it might be better solved in rusqlite. Thoughts?

Thanks!

@thomcc
I am not sure but I am afraid we have lost the conversion from utf-16 to utf-8 !


Dependent PostCSS line return parsing error

Bug report
PostCSS line return parsing error
https://github.com/advisories/GHSA-7fh5-64p2-3v2j
Actual Behavior
It has dependency of "postcss": "^8.4.29", which is <8.4.31 according to
https://github.com/advisories/GHSA-7fh5-64p2-3v2j
An issue was discovered in PostCSS before 8.4.31. It affects linters using PostCSS to parse external Cascading Style Sheets (CSS). There may be \r discrepancies, as demonstrated by @font-face{ font:(\r/*);} in a rule.
This vulnerability affects linters using PostCSS to parse external untrusted CSS. An attacker can prepare CSS in such a way that it will contains parts parsed by PostCSS as a CSS comment. After processing by PostCSS, it will be included in the PostCSS output in CSS nodes (rules, properties) despite being originally included in a comment.
Expected Behavior
Update the dependency of "postcss": "^8.4.29",  to  "^8.4.31"
How Do We Reproduce?
It already has a vulnerability
CVE-2023-44270
Please paste the results of npx webpack info here, and mention other relevant information

Hello, you can update deps locally, we have postcss in peerDependencies to support v7 and v8 and we use ^ to allow installing new versions with fixes, so plese update your deps locally, thank you, feel free to feedback


Read Azure SDK Success status

Azure SDKs have more involved rules to determine whether the HTTP span  is successful (see https://github.com/Azure/azure-sdk-for-net/pull/20064)
This change delegates the decision to the activity producer instead of being hard coded in the listener logic.

cc @TimothyMothra

/AzurePipelines run

/AzurePipelines run

/AzurePipelines run


Apply Johan Tibell (hindent) style

In response to issue #17, this proposal seeks to apply John Tibell (hindent) style formatting, manually, with a line length of 80 but with a tab width of 4. However, I have deliberately not reordered imports or introduced explicit imports in accordance with the style.

Thanks Mike, this looks fine to me, but could you make the indent size 2? That's what I (and many other Haskellers) use nowadays, and it appears to be the default for hindent as well.

@feuerbach I have now applied a tab width of 2 throughout. In returning to this, I have now also applied the style as regards the ordering and grouping of imports and added explicit imports for the few examples of modules outside the package where they were missing. The latter involved something a little subtle at lines 79 to 82 of Foreign.hs because of existing lines 92 to 95 of that module.
For reasons I do not understand, AppVeyor has failed and Travis CI will not start (after > 45 mins) the stack 7.10.3 build (all the others started and passed, quickly).

I triggered a rebuild by closing and reopening the pull request, and all checks pass now. Merging.


Name resource inside group

Hi,
Are you guys able to change the handling of named resource when inside a route group
$router->group(['prefix' => 'some/other/uri'], function($router)
{
    $route = 'myroute';

    $router->resource('orders', 'OrdersController', ['as' => "{$route}"]);

    $router->get('/', ['as' => "{$route}", 'uses' => 'HomeController@index']);
});

At the moment a resource will take on the naming of the prefix -
some/other/uri/orders => myroute.some.other.uri.orders.index
some/other/uri/orders/create => myroute.some.other.uri.orders.create
...

So as soon as I change the prefix my named resource routes will break unless i use the names array to set every single method.
Making a small change to the following will solve this issue.
class ResourceRegistrar...

protected function getResourceName($resource, $method, $options)
{
    if (isset($options['names'][$method])) return $options['names'][$method];

    // If a global prefix has been assigned to all names for this resource, we will
    // grab that so we can prepend it onto the name when we create this name for
    // the resource action. Otherwise we'll just use an empty string for here.
    $prefix = isset($options['as']) ? $options['as'].'.' : '';

-   if ( ! $this->router->hasGroupStack())
+   if ( ! $this->router->hasGroupStack() OR ! empty($prefix))
    {
        return $prefix.$resource.'.'.$method;
    }

    return $this->getGroupResourceName($prefix, $resource, $method);
}

This way any named resource inside a route group will follow the named convention.

Please don't create issues for this sort of thing. Pull requests are far more useful.


AbsoluteTargetLaneOffset not working

Hi SR Team,
Thank you for adding support for OSC LaneOffsetAction.
I have tried creating scenarios with this tag but AbsoluteTargetLaneOffset is not working as expexted.
vehicle achieves the given offset and returns to default offset 0.0. but it is supose to continue with the given offset.
<LaneOffsetAction continuous="true">
    <LaneOffsetActionDynamics dynamicsShape="linear" maxLateralAcc="1" />
    <LaneOffsetTarget>
        <AbsoluteTargetLaneOffset value="1.2"/>
    </LaneOffsetTarget>
</LaneOffsetAction>

Desktop :

OS: Ubuntu 20.04
CARLA Version : CARLA 0.9.11
Python version :3.8
SR: master

Hey @sagar-g-v, Is your code based on the example at PR #702 (Added support for LaneOffsetAction)? I just tried that XOSC scenario and its variations (absolute and relative positions), and it seems to be working fine by me. If not, could you send me your XOSC file? Also, note that if the offset is high enough to make the vehicle exit its lane, the action will most likely break

Hi @glopezdiest I have made some changes to example at PR #702 to show my use case.
LaneOffsetActionTest.zip
In this case obsolute lane offset is used immediately after lane change
Sorry i forgot to mention that I have modified SR and local_planner little bit before running this example but it was not working without the modification due to issue #727
also i made sure lanechange ends at 25 meters after entering target lane by changing distance_other_lane=25
https://github.com/carla-simulator/scenario_runner/blob/e735586789ea28b4a76ce8cb6a54fa3c28a7d7f7/srunner/tools/openscenario_parser.py#L1042

Okay, I'll take a look to both this problem and #727  and report back

After some tests, I am indeed seeing your problem but it isn't related to the LaneOffset but rather a mix between the controller and the LaneChange. As such, I'll explain in depth what I found in issue #727.


New Courses

Student View
Teacher View

Assign Courses mostly, and supplemental Playlist.
Show up in Assignment tab and first lesson/playlist shows up in Review tab
making active makes other thing not active per Course


list-files does not work with subdirectories

$ retz-client list-files -id 4 --path results
[main] INFO io.github.retz.cli.CommandListFiles - Listing files in results of a job(id=4)
[main] INFO io.github.retz.cli.CommandListFiles - gid  mode       uid    mtime               size path
[main] INFO io.github.retz.cli.CommandListFiles - 1000 -rw-r--r-- myuser 2016-33-08 02:33:15 919  output.log
[main] INFO io.github.retz.cli.CommandListFiles - 1000 -rw-r--r-- myuser 2016-33-08 02:33:15 311  ps.txt

$ retz-client list-files -id 4 --path results/ps.txt
[main] INFO io.github.retz.cli.CommandListFiles - Listing files in results/ps.txt of a job(id=4)
[main] ERROR io.github.retz.cli.CommandListFiles - Error: java.io.FileNotFoundException: http://mesos3:9090/job/4/path/results/ps.txt

$ retz-client list-files -id 4 --path results%2Fps.txt
[main] INFO io.github.retz.cli.CommandListFiles - Listing files in results%2Fps.txt of a job(id=4)
[main] ERROR io.github.retz.cli.CommandListFiles - Error: java.io.IOException: Server returned HTTP response code: 401 for URL: http://mesos3:9090/job/4/path/results%2Fps.txt

Yep, sorry for the duplicate, will close this issue. This is a bit important for us, though, as we store all task results in a subfolder of the sandbox...


Use LLVM 17 in Nix CI

There's an open PR against Nixpkgs that will fix this issue once it's merged.

We're now only blocked on the next merge of Nixpkgs staging into master; this should happen in the next few weeks I think.

Superseded by #961


Extract max_plate_nesting in linearize call to prevent seeding issue with  NMCLogPredictiveLikelihood

See https://github.com/BasisResearch/chirho/pull/408#issuecomment-1843684611

Resolved by #473


phrasendrescher: 1.0 -> 1.2.2b

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from phrasendrescher.
meta.description for phrasendrescher is: '"Cracking tool that finds passphrases of SSH keys"'.

Checks done (click to expand)

built on NixOS
/nix/store/2dzzjx5fkh6cd1gg81gg286zj03w9hq5-phrasendrescher-1.2.2b/bin/pd passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 1.2.2b with grep in /nix/store/2dzzjx5fkh6cd1gg81gg286zj03w9hq5-phrasendrescher-1.2.2b
directory tree listing: https://gist.github.com/2e518f16564e0bcdfa5ee388e28acf4a
du listing: https://gist.github.com/803a16f2c3a114165a388f1afbc33397

Instructions to test this update (click to expand)

One-time optional setup to skip building using Cachix:

Install cachix from https://cachix.org/
Use r-ryantm's cache:cachix use r-ryantm

Test this update by entering a nix shell, seeing what is inside the
result, and if applicable, running some binaries:
nix-shell --pure -I nixpkgs=https://github.com/r-ryantm/nixpkgs/archive/d76c4c138d04708f8cb2a1557c6995ccd58df2bf.tar.gz -p phrasendrescher
ls -la /nix/store/2dzzjx5fkh6cd1gg81gg286zj03w9hq5-phrasendrescher-1.2.2b

cc @bjornfor for testing.

Success on x86_64-linux (full log)
Attempted: phrasendrescher
Partial log (click to expand)
make[1]: Leaving directory '/build/phrasendrescher-1.2.2b'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2dzzjx5fkh6cd1gg81gg286zj03w9hq5-phrasendrescher-1.2.2b
shrinking /nix/store/2dzzjx5fkh6cd1gg81gg286zj03w9hq5-phrasendrescher-1.2.2b/bin/pd
gzipping man pages under /nix/store/2dzzjx5fkh6cd1gg81gg286zj03w9hq5-phrasendrescher-1.2.2b/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2dzzjx5fkh6cd1gg81gg286zj03w9hq5-phrasendrescher-1.2.2b/bin
patching script interpreter paths in /nix/store/2dzzjx5fkh6cd1gg81gg286zj03w9hq5-phrasendrescher-1.2.2b
checking for references to /build in /nix/store/2dzzjx5fkh6cd1gg81gg286zj03w9hq5-phrasendrescher-1.2.2b...
/nix/store/2dzzjx5fkh6cd1gg81gg286zj03w9hq5-phrasendrescher-1.2.2b

Success on x86_64-darwin (full log)
Attempted: phrasendrescher
Partial log (click to expand)
test -z "/nix/store/5fbvm1bsdy8jc4g8wqr6hz4ka2pix8h0-phrasendrescher-1.2.2b/share/man/man1" || /nix/store/zkfqg7icazgz0kj7rff6zdfbcf3v79sa-coreutils-8.29/bin/mkdir -p "/nix/store/5fbvm1bsdy8jc4g8wqr6hz4ka2pix8h0-phrasendrescher-1.2.2b/share/man/man1"
 /nix/store/zkfqg7icazgz0kj7rff6zdfbcf3v79sa-coreutils-8.29/bin/install -c -m 644 'man/pd.1' '/nix/store/5fbvm1bsdy8jc4g8wqr6hz4ka2pix8h0-phrasendrescher-1.2.2b/share/man/man1/pd.1'
make[2]: Leaving directory '/private/tmp/nix-build-phrasendrescher-1.2.2b.drv-0/phrasendrescher-1.2.2b'
make[1]: Leaving directory '/private/tmp/nix-build-phrasendrescher-1.2.2b.drv-0/phrasendrescher-1.2.2b'
post-installation fixup
gzipping man pages under /nix/store/5fbvm1bsdy8jc4g8wqr6hz4ka2pix8h0-phrasendrescher-1.2.2b/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/5fbvm1bsdy8jc4g8wqr6hz4ka2pix8h0-phrasendrescher-1.2.2b/bin
patching script interpreter paths in /nix/store/5fbvm1bsdy8jc4g8wqr6hz4ka2pix8h0-phrasendrescher-1.2.2b
/nix/store/5fbvm1bsdy8jc4g8wqr6hz4ka2pix8h0-phrasendrescher-1.2.2b

Success on aarch64-linux (full log)
Attempted: phrasendrescher
Partial log (click to expand)
make[1]: Leaving directory '/build/phrasendrescher-1.2.2b'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ghmix9fxrd7ihf5y9lgz15v18bsm36f8-phrasendrescher-1.2.2b
shrinking /nix/store/ghmix9fxrd7ihf5y9lgz15v18bsm36f8-phrasendrescher-1.2.2b/bin/pd
gzipping man pages under /nix/store/ghmix9fxrd7ihf5y9lgz15v18bsm36f8-phrasendrescher-1.2.2b/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ghmix9fxrd7ihf5y9lgz15v18bsm36f8-phrasendrescher-1.2.2b/bin
patching script interpreter paths in /nix/store/ghmix9fxrd7ihf5y9lgz15v18bsm36f8-phrasendrescher-1.2.2b
checking for references to /build in /nix/store/ghmix9fxrd7ihf5y9lgz15v18bsm36f8-phrasendrescher-1.2.2b...
/nix/store/ghmix9fxrd7ihf5y9lgz15v18bsm36f8-phrasendrescher-1.2.2b

phrasendrescher 1.2.2c is out too: http://www.leidecker.info/projects/phrasendrescher/index.shtml.

And now it works on all platforms :tada:


sqlite: Don't use multiple handles to the same file

Part of: https://github.com/bpfkorea/agora/issues/836

Tested, works!


Update package.json with aspnetcorerazor code

Not sure if correct, first commit on outside project.

Fixes #IssueNumber
#1771
Changes proposed:

[x] Add
[ ] Delete
[ ] Fix
[ ] Prepare

@Guar1, sorry but this PR doesn't make any sense and hence it cannot be accepted as it is.
Here you are the steps you should be following for this PR to be accepted:

Revert the changes to the package.json file
Go to this line and let's modified it.
Take ln 147 as an  example. You'll have to add a new language id called aspnetcorerazor to line 157.
That's all! :wink:

Waiting for your refactor!
Thanks for your contribution!

Not sure how to "revert". Is it prerequisite?

Just undo what you did. Don't worry about reverting the commit. In the end we will squish it so it won't be a problem.

Closing in favour of #1799


Next Release/Release Cycle?

Heya!
I was looking for information about the release cycle of this library. This is a motivated question, as I'd love a release with this commit available, but in general I was curious if there was a set release cycle, and if not, could some guideline be established in one of the doc files? I want to avoid asking this sort of question if I can find the information myself, so as not to pester maintainers.
Thank you for your attention! Cheers!

Hi @nathanielford !
For a release cycle / guideline, there is none. I'm currently the sole maintainer of this project and so far there is no interest I'm aware of from 3rd parties to support / take over the maintainership.
Looks like I'll continue doing the releases whenever I feel like it or otherwise need to for my own work.
P.S. You'll be happy to hear I've just released<EMAIL_ADDRESS>! :)

Thanks for the response! I totally get the single-dev burden! And I also wicked appreciate the release! Thanks again!


Unable to install MSIX package

Brief description of your issue
We package our application as MSIX on windows, whenever user tries to install the application through this MSIX package file it fails with error.
Error : App Installer failed to connect to the winget source for external package dependencies. Please report at https://aka.ms/winget-cli
When did it begin and how often does it occur?
It started on 9/25 Monday evening , it occurs every time user tries to install the MSIX package .
What errors do you see?
Reason : App Installer failed to connect to the winget source for external package dependencies. Please report at https://aka.ms/winget-cli
What's the environment and are there recent changes?
Windows 10 20H2
What have you tried to troubleshoot this?
PowerShell script works : Add-AppPackage -path "msix package path"
Investigation:
We identified the external dependencies responsible for causing errors with the latest version of winget-cli(winget-cli v1.6.2721). Also we are able to replicate the same issue within a sample MAUI application(MAUITestApp.zip) msix package.
The external dependency in question is "Microsoft.WebView2," and you can find it specified in the following location within the MAUITestApp.zip)\Platforms\Windows\Package.appxmanifest:

<win32dependencies:ExternalDependency
Name="Microsoft.WebView2"
Publisher="CN=Microsoft Windows, O=Microsoft Corporation, L=Redmond, S=Washington, C=US"
MinVersion="<IP_ADDRESS>"
Optional="false"/>

To reproduce the issue, please follow these steps:

Upgrade to winget-cli v1.6.2721
Install  the development certificate, MAUITestApp_TemporaryKey.zip password = 'test', to enable the installation process.
Install the sample program by using the MAUITestApp_<IP_ADDRESS>_x64.msix package.

Downgrading to winget-cli v1.5.2201 fixes the issue on my machine.
Furthermore we are able reproduce the issue with any external dependency(other than Microsoft.WebView2) using sample test program : MAUITestApp.zip)\Platforms\Windows\Package.appxmanifest:

<win32dependencies:ExternalDependency
Name="Microsoft.WinJS.1.0"
Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US"
MinVersion="<IP_ADDRESS>"
Optional="false"/>

Steps to reproduce
To reproduce the issue, please follow these steps:

Upgrade to winget-cli v1.6.2721
Install  the development certificate, MAUITestApp_TemporaryKey.zip password = test, to enable the installation process.
Install the sample program by using the MAUITestApp_<IP_ADDRESS>_x64.msix package.

Downgrading to winget-cli v1.5.2201 fixes the issue on my machine.
Expected behavior
MSIX package installer should install the application successfully
Actual behavior
MSIX package installer is erroring out

Environment
Windows Package Manager v1.6.2721
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19042.2965
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.21.2721.0

Reopened for tracking.
Fix is merged. Will close the issue until fix is released.

This fix for this has been released in https://github.com/microsoft/winget-cli/releases/tag/v1.6.2771


start http and html skelleton

ground work for router and templating setup.
TODO:

[x] tests (98ca4f8)
[x] i18n
[x] embedded assets (css, js, etc.)
[x] sqlite
[x] basic auth as a stub for sign-in with ssb

Nearly done. Will add logged in? template helper tomorrow to show a log out button conditionally on the users state. Then it should be good to merge.

Okay. This should be it.
One missing step is creating the database on the first run. I will tackle this in a follow-up because this is already too big.
The workaround is basically sqlite3 $HOME/.ssb-go-room/roomdb < $src/admindb/sqlite/schema-v1.sql.


MSAL Doesn't Redirect on Safari

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.32.1
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
2.1.2
Public or Confidential Client?
Public
Description
User tying to redirect to the login page from the application on safari mobile and the msal does not respond to the request. works with Chrome IOS and Android.
We only see this issue sometimes but we have users complaining they are not able to log into the application.
We were not able to see any errors in our logs to detect anything related to this issue. We would like to get more information about the situation and monitoring to tackle this issue. any help would be appreciated.
Error Message
No response
Msal Logs
No response
MSAL Configuration
auth: {
        clientId: clientId,
        authority: "B2C_1A_SIGNUP_SIGNIN",
        redirectUri: '/',
        navigateToLoginRequestUrl: false
    },
    cache: {
        cacheLocation: "LocalStoarage",
        storeAuthStateInCookie: false
    }

Relevant Code Snippets
extraParameters = {
        ...extraParameters
        device_id: deviceId
      };

      // set the redirection flag
      this.storage.setDeviceHasRedirectedToLogin(deviceId);

      const redirect = this.msalService.loginRedirect({
        scopes:[`https://${environment.activeDirectory.domain}/${environment.activeDirectory.tenantId}/access_as_user`],
        extraQueryParameters: extraParameters
      });

      return redirect;

Reproduction Steps

Access the Application
Press the login button
Nothing happens

Expected Behavior
Needs to redirect to the login page.
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
Safari
Regression
No response
Source
External (Customer)

@HansakaSS could you please elaborate on the issue? It's hard to determine what's going on without logs or a reproducible scenario. Is the failure happening after the user logs in and the login page redirects back to the application? Or is the issue happening when MSAL first redirects to the login page?
My initial assumption if the problem is happening on the redirect back from the login screen is that there could be a race condition where the hash is being cleared by the apps routing logic before MSAL has a chance to parse the auth code.

@hectormmg  we were able to see following error on audits for users when they having the issue.
The provided grant   has expired. Please re-authenticate and try again. Current time:<PHONE_NUMBER>,   Grant issued time:<PHONE_NUMBER>, Grant expiration time:<PHONE_NUMBER>
users were not able to redirect to the login page.

@HansakaSS , it looks like, from your posted, the request is taking 118 seconds from the time you got the grant time to the time you used it in the above log, your 57 seconds over the allowed exp of the token.

@mlhamatms thanks for the response.
I understand the token expiration issue.
I would like to know how to increase this expiration time.
Some users seems to have this problem continuously on the same device, even after clearing cache. but they were able to login on other devices without a problem. Some users were able log in on chrome but not in Safari.
Also in case of this problem is there a way to let know the users know something went wrong or redirect to a another page to let user know more information about the problem ?

@HansakaSS that error should cause MSAL to return an InteractionRequired error. The correct usage pattern is to call acquireTokenRedirect or acquireTokenPopup for the user to reauthenticate. As far as changing the access token lifetime, that is not something you can do from MSAL, I would suggest looking at the AAD docs and your portal configuration.

we have applied the acquireTokenRedirect solution to out application but we still see some users still having the login problems.
we were able to see the Acquire Token Error. Unexpected Error. Error message: BrowserAuthError: no_account_error: No account object provided to acquireTokenSilent and no active account has been set. Please call setActiveAccount or provide an account on the request in our logs

@HansakaSS The error message tells you exactly what is wrong and how to fix it. Did you have specific questions about this?

@tnorling  i understand that. but this is happening right after user login to the system. i wanted to prevent this from happening, is there a reason for this kind of behaviour ?

@HansakaSS i think we are seeing similar issues in Safari using MSAL, it may be related to Safari's lack of look regex lookbehind, ours is erroring out in the MSAL function CredentialEntity.getCredentialType calling 'f (key.toLowerCase().search("(?<=" + separator + domainRe + ")" + separator + credVal + separator) !== -1) {' can you confirm if yours is failing there?  If so I believe MSFT will need to change the search function to support Safari's lack of regex look behind

What you've described is fine, although our recommended best-practice approach is to check if a user is signed in prior to calling acquireTokenSilent and invoking interaction if not.

@tnorling I understand now, Thank you for the support.


Re-run the Benchmarking process for PyAF 5.0

Following #45
Need to run a benchmarking process to review the current state of PyAF 5.0 against previous versions..
Previous versions logs are available under https://github.com/antoinecarme/PyAF_Benchmarks

Final benchmark report summarizing all performance indicators evolution from PyAF-1.0 to PyAF-5.0 :
https://github.com/antoinecarme/PyAF_Benchmarks/blob/master/reporting/PyAF_Performance_Evolution.ipynb


add support for running in read-only mode

Right now, running in read-only mode displays a banner stating that links can be resolved but not created or updated, as well as actively blocking requests to modify links.
Update #118
Updates tailscale/corp#18849

(still need to add some tests)


ESMAtlas api access: Rate limit?

Hi,
I would like to automatically retrieve structures from ESMAtlas. Basically I have a list of MGinfy IDs that I want to retrieve.
I do that using the following:
def get_esm_pdb_file(mgnify_id, out_dir):
    url = f'https://api.esmatlas.com/fetchPredictedStructure/{mgnify_id}.pdb'
    response = requests.get(url, stream=True)
    if response.status_code == 200:
        pdb_file = os.path.join(out_dir,f'{mgnify_id}.pdb')
        with open(pdb_file, 'w') as f:
            f.write(response.text)
    else:
        print(mgnify_id, response.status_code)
        print(response.text)

To speed it up, I parallelize it over my list using a ProcessPool. For some IDs I then get the following:
MGYP000547115894 403
{"message":"Forbidden"}
MGYP000526977164 403
{"message":"Forbidden"}
MGYP003555372774 403
{"message":"Forbidden"}

Could you provide some details if/what rate limiting is in place for querying ESMAtlas, or if there is another way to retrieve structure files?
Thanks!

Hi @fteufel please refer to https://github.com/facebookresearch/esm/blob/main/scripts/atlas/README.md for bulk download of structures. These APIs are for infrequent requests and they are rate limited accordingly.

Hi,
so according to the README, it's either download the full DB, or be rate limited?

Hi @fteufel, correct we set it up to be exactly this: small volume of individual queries (typically used to display in the webapp), or bulk download. The reason being that the DB is 617M small files, which is suboptimal from a systems perspective in almost all cases (617M S3 queries, your typical HPC cluster will also break if you try to write too many small files to NFS).
We didn't exactly envision that there's a useful way to query certain subsets of the database except by searching against the DB in bulk.
But as I'm typing this I guess there's an obvious usecase for downloading subset, which is sequence search, then download the structures for the IDs returned by search. Is your use case something like this?

Hi @tomsercu that's exactly what happened. I had a search result and wanted to download all the hit structures.
Note that AF DB doesn't support batched requests either as far as I know, but the rate limit there seems more generous, so I never had any issues with this use case.

This makes a lot of sense, we'll increase rate limits for all GET requests which just fetch data from the atlas.

How about rate limits for predictions of relatively small datasets of short proteins?
In our case it is about 2500 protein sequences of 25 amino acids each.
Do you prefer setting a daily limit or should we rather use sleep() to send small batches of requests in regular time intervals?
Many thanks,
Vasilis

2500 protein sequences of 25 amino acids each.

@vprobon  We don't have control at such a granular level. All bulk folding should be done by running the code directly, eg a good start is to do this via the colabfold or huggingface notebooks which are easily scripted to iterate over a set of proteins.

@tomsercu Thank you!

Hi @fteufel we've just updated the rate limiter to support up to 100 rps per user for the /fetch* endpoints. I hope that covers your case.

Hi @nikitos9000 I just ran the same code again, using one search result for which to download all structures - all that changed for me is that it now looks like
MGYP003385626744 429
Too Many Requests
MGYP003385626744 429
Too Many Requests

Anything I should take care of from my side to avoid it? I'm trying running 20 workers in parallel, and expect that I hit the limit in some calls because I'm not having any checks in place to avoid sending more than 100 at a time.
But still, the total speed (with retrying) seems the same as before right now.

Nevermind, I ran a few more test cases and I'm sure it goes faster now.


Changes to support registry modification in containers

Signed-off-by: Sandeep Bansal<EMAIL_ADDRESS>Replaces closed #259 @jterry75

Rebased on top of v0.6-dev

LGTM


GUI: "Pending" for coins being received.

We currently don't display unconfirmed deposit tx on the Home screen. This is debatable for some users, but good practice as a not confirmed tx does not belong to the user yet, and could never make it.
That said, the user can CPFP. The coin is therefore displayed in the "Coins" section. It currently does NOT show this coin as unconfirmed, which is pretty critical IMHO.
This issue is to add a "Pending inclusion in a block", and maybe even an infotip about CPFP for the users in coin selection.

@kloaec what do you think? I think it's one of the most pressing imperfections to tackle.


write the presentation and share the link

making notes as to what everyone needs to say. just rehearse it in your own time to make sure we all know what we're saying. Avoid reading from the presentation at all costs. the slides themself have little information on it. We need to elaborate on the points made.


Experiment: create conda-build_config.yaml.

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

This is an experiment to see if the CI works - broke in an interesting Git way on #118

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Interesting: looks like this doesn't suffer from the same problems. I don't know if that's due to the content of #118, or just because #118 was submitted during the time when there were problems?


[google_maps_flutter] Make google_maps_flutter_web work with latest plugins

google_maps_flutter_web NNBD migration is currently blocked, but this is an attempt to make a non-NNBD version that's uses the NNBD version of all dependencies for compatibility with the latest versions of other plugins.
Pre-launch Checklist

[ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I signed the CLA.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

We should update scripts/nnbd.sh to remove this from the conflict list (and fix the fact that I forgot to move extension_google_sign_in_as_googleapis_auth up to the NNBD list)

@googlebot I consent. Jeez.

And because every version of extension_google_sign_in_as_googleapis_auth from path depends on googleapis_auth ^1.0.0 which depends on crypto ^3.0.0, integration_test from path is incompatible with extension_google_sign_in_as_googleapis_auth from path. Womp womp, reverting...

Published https://pub.dev/packages/google_maps_flutter_web/versions/0.2.0


Release 3.20.0

Todo

[x] https://github.com/gnosis/safe-react/issues/3559

Features

feat: desktop pairing (#3354)

Design

style: enhance multiple txs visualisation (#3538)

General bug fixes

fix: Only run createNewSafe if user wallet is connected (#3548)
Fix: use recommended nonce in the nonce warning (#3530)
Fix: throw when WC rejects a created tx + on-chain signing with a Safe signer via WC (#3546)
fix: use global replace instead of replaceAll (#3550)
fix: hash approval errors + return txHash (#3545)
fix: transaction remain pending (#3525)
fix: Remove defaultChecked attribute from exec tx checkbox (#3547)
fix: Link execute tx checkbox state to component (#3541)
fix: init Safe Apps providers per chainId (#3503)
fix: add redirection for settings section (#3533)
Fix: undefined address in reverse ENS lookup (#3512)
fix: Redirect user to next available safe after removing current safe (#3424)
fix: stringify parameter value arrays (#3549)
fix: always reset wallet on disconnect event (#3562)

Chores

Build(deps): Bump url-parse from 1.5.3 to 1.5.7 (#3536)
refactor: rely on Onboard for provider watching (#3364)
test: Create tests for TxSender class (#3544)
Update README.md (#3534)
refactor: useEstimateTransactionGas hook (#3500)

found issues:

[x] https://github.com/gnosis/safe-react/issues/3557
[x] https://github.com/gnosis/safe-react/issues/3564
[x] https://github.com/gnosis/safe-react/issues/3568
[x] https://github.com/gnosis/safe-react/issues/3569
[x] https://github.com/gnosis/safe-react/issues/3580
[x] https://github.com/gnosis/safe-react/issues/3581
[ ] https://github.com/gnosis/safe-react/issues/3589

The ticket #3549 is not working.
Just making the comment instead of creating a bug because maybe the ticket was not merged

The ticket #3549 is not working. Just making the comment instead of creating a bug because maybe the ticket was not merged

@francovenica It is in the release deployment now, I've just tested it. The deployment containing that fix was blocked but it is fine now.

The PR works fine, but I'm seeing some errors that I've never seen before. These are not causing troubles in the sense that tx go on just fine, but I'd like to know where they come from.
Creating a tx in the Gnosis chain, this error pops up when estimating the tx gas limit/price:

This one showed up when creating a safe in arbitrum. Once again when the estimation is being done:

These are not errors, but I have this safe-wc log popping up. I'm not connected with WC, and I made sure to disconnect and connect with the MM chrome extension (so I assume any type of "lingering" connection should be closed by now)

I think that https://github.com/gnosis/safe-react/issues/3589 will spoil the desktop pairing feature. What was changed? On Thursday there was no such problem with QR code generation


Login failed

The password I'm testing has some special characters (#!$) and the tool fails to login properly.
A workaround is to use single quotes (') instead of double quotes (").

Repo archived


Added "Create package" button in "+Offline" #567

For #567.

Thanks, merging
there is also a lcx_cancel exception that sometime is used, but for now it will work

Thanks for the suggestions Lars.


m_count should use volatile ?

semaphore.cpp
struct SemaphoreInternal
{
....
#elif BX_PLATFORM_POSIX
		pthread_mutex_t m_mutex;
		pthread_cond_t m_cond;
		int32_t m_count;
...
}

do you think 'int32_t m_count;' should be "volatile int32_t m_count;"  in multi-thread ?
Thanks in advance.

No.


Switch AssertHttpSpan to MockZipkinCollector

All ASP.NET related tests go through these, so switching them to MockZipkinCollector.

I think for this to fully take effect you need the IIS helper to specify the zipkin api type via env vars.

I'm incorporating this one on the next PR since this was very small.


Nested team as reviewer not tagged

Looking at the documentation it seems possible to tag teams as reviewers in PRs. That feature does, however, not seem to work for nested teams.
For example:
Our team is organized as follows GetFeedback > platform > platform-java
My configuration file is as follows:
version: 2
updates:
  - package-ecosystem: "gradle"
    directory: "/"
    schedule:
      interval: "daily"
    labels:
      - "Dependencies"
    reviewers:
      - "GetFeedback/platform-java"
...

But whenever a PR is opened by Dependabot, this team is not tagged (but labels are added, everything else seems to work). GetFeedback/platform-java is the value that is displayed at the team page and also works in manually tagging that team.
Let me end by saying your tool is an amazing asset to the development community, thank you for all the efforts!
Package manager/ecosystem
All
Manifest contents prior to update
Irrelevant
Updated dependency
Irrelevant
What you expected to see, versus what you actually saw
Nested team should be tagged while it is not
Images of the diff or a link to the PR, issue or logs

Thanks for following up here @frankkoornstra, I appreciate it.
Sorry that you got radio silence on this bug report, it was unfortunately filed during a time when the team was quite overwhelmed transitioning to new infra at GitHub, and then simply got lost.
If you do hit issues in the future, please file a ticket and we'll try to respond in a more timely manner next time.


Show loading animation while getting repos after login

Clear and concise description of the problem
The login is quite slow in some cases: #2502 and also for Gitlab after we added more requests in #3308
While Woodpecker is getting all the repos, the redirect site of the forge is shown which looks like we are stuck:

Suggested solution
The web UI should return a loading page immediately, maybe even with a progress indicator.
Alternative
No response
Additional context
No response
Validations

[X] Checked that the feature isn't part of the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

I would actually suggest to either do the update in the background in a go function or somehow decouple it from login in general.


Vault Detail - Redirect to Scan

Acceptance Criteria: On clicking VaultID user should redirect to defiscan_live
Android:

[ ] Loans > Your vaults > Click VaultID > User should redirect to defiscan_live

iOS:

[ ] Loans > Your vaults > Click VaultID > User should redirect to defiscan_live


Add require-corp embedder policy header to service worker

Upstream a recommended header that enforces CORS.
Documentation for the header: https://html.spec.whatwg.org/multipage/origin.html#coep
I tested this using the configurator page and a relatively complex demo. However I'm not certain that this is an appropriate test for a modification to the service worker.
https://user-images.githubusercontent.com/15080861/194410336-8bb12c31-fa45-469d-bdf0-7d8f6ad95901.mov

On further testing this change would be breaking. For example, we often use resources from another origin for demonstrating example images. Any image elements without the crossorigin attribute would break. E.g.:

Two proposed options:

Make this opt-in (if possible).
Revert this change and keep this as an internal only change.


Modifying the code does not produce new cache files

When I was coding, I found that the '.happypack' folder would add new cache files but not deleting old ones. So I want to know why not just overwrite the old files which already expired?
@amireh

Current coverage is 90.56% (diff: 100%)

Merging #115 into master will decrease coverage by 0.01%

@@             master       #115   diff @@
==========================================
  Files            22         22
  Lines           775        774     -1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            702        701     -1
  Misses           73         73
  Partials          0          0

Powered by Codecov. Last update 6b60e14...d1f034b

So I've taken to introducing a new option that allows us to tune the cache file name (in order to accommodate the use case in #92 and to not cause regressions everywhere else) but it's complicating things even more and I'm not sure it's warranted.
While your fix works, it's still a band-aid. Gonna take some more time to think about this.
Again, thanks for the contribution! And if you have any thoughts, I'm all ears.

Gonna merge this until I get some time to provide a real fix for the mentioned problem. Thanks!


HDP priors?

Heya @gdalle! Was wondering if you had been thinking about implementing the "Infinite Hidden Markov Model"? I was planning on adding this modeling structure to StateSpaceDynamics.jl soon, but since collaboration seems imminent, if this wasn't already a direction you had, I might try implementing this into HiddenMarkovModels.jl in the near-ish future.

Hi @rsenne, thank you for the suggestion.
I had never read that paper before. I took a quick look and it seems to employ very different estimation algorithms (not exact but approximate), which means the overlap with HiddenMarkovModels.jl is rather low. I think this would make more sense in a separate package like InfiniteHiddenMarkovModels.jl, which could of course depend on mine for anything it needs.


Investigate Existing VPC Module

I believe the use case for SWF is specific enough that we need our own VPC module.  SWF's VPC will use specific routing tables, security groups, and VPC endpoints that will be easier to maintain in its own repo.


Can't find react-virtualized Grid layout implementation

Hi Guys, I've searched many examples of react-sortable-hoc integration with react-virtualized Grid layout, but can't find any good example.
Maybe someone have a good example or smth. ?

Duplicate of #295
check the example https://github.com/clauderic/react-sortable-hoc/issues/295#issuecomment-344070823

I build a example, react-virtualized grid + sortable hoc, feel free to take it.
https://github.com/clauderic/react-sortable-hoc/issues/337


Fix panic when enable titan

Issue Number: close tikv/tikv#13038
Signed-off-by: Wenbo Zhang<EMAIL_ADDRESS>
What is changed and how it works?

Tests

Manual test

sysbench prepare

Side effects

Performance regression

None

Breaking backward compatibility

None

Release note
None

Please fix test in test_titan to use multi batch write.

Please fix test in test_titan to use multi batch write.

Sure

Please fix test in test_titan to use multi batch write.

@tabokie I suddenly realized that multi batch write is enabled by default, and I make sure it at IDC without this PR.

Need a case to cover titan write. Maybe enable titan in test_raftstore integration tests

@Connor1996 @tabokie Add a write wb test in test_titan, as only more than one wb  will call multi_batch_write directly,  otherwise it will call write_opt, that's why existing titan tests are not painic with enable_multi_write_batch enabled.

/run-tests

/run-tests

/run-tests retry=6

Why not change the index>0 to use support_multi_batch_write? And eventually we can remove the flag in RocksDB.

Because write_opt receives WriteBatch as a parameter, and multi_write_batch receives an vec, I think it is more straightforward to judge which interface to use by index. (As when we call db.put, db.put will also call write and use flag to judge which write impl to use).
If use support_multi_batch_write, the as_inner need changed to:
pub fn as_inner(&self) -> &[RawWriteBatch] {
    if self.index > 0 {
        &self.wbs[0..self.index]
    } else {
         &[self.wbs[0]]
    }
}

Write once, judge twice

@ethercflow It's always &self.wbs[0..=self.index]. No need to add an if.

@ethercflow It's always &self.wbs[0..=self.index]. No need to add an if.

@tabokie &self.wbs[0..0] will return an empty [].

@ethercflow It's &self.wbs[0..=0], please check.

@ethercflow It's &self.wbs[0..=0], please check.

Oh, you're right, I left = :(

Why not change the index>0 to use support_multi_batch_write? And eventually we can remove the flag in RocksDB.

@tabokie changed to support_write_batch_vec, PTAL again, thanks!


Linktree added in readme

#31 readme updated

hey harshita ..can you generalize the link tree . This doesn't look like a clone but a linktree about ur own details.U can just put links for insta and all not ur own profile

The link which is in the readme is an example of a link tree, the code which I have uploaded doesn't have my links. They are only available here for demo purposes.

oh then using the code try to create a demo linktree and add that link in readme

Okay

This branch is 2 commits ahead, 9 commits behind Rayman-Sodhi:main.

kindly perform a git pull and then make the pr

Sure , done

Also can you merge my code also as its not merged yet #31


Removing http schemes

I noticed that the http schemes are being stripped when using version 3.X for csp. Why was this change made? It would help if this is also mentioned in the upgrade path since any tests that check the csp header value will break based on this change.

This is likely due to preserve_schemes: false being the default now. If you change that to true, I suspect things will go back to what you expect.

This change was made because the need to preserve schemes implies that you have mixed content. A source without a scheme defaults to the current scheme and allows "upgrades". "Mixed was a mistake" which is why the default is to not support it. As @reedloden mentions, true will add the schemes back.
Added to the upgrade doc: https://github.com/twitter/secureheaders/commit/e8f51038759fd4ad71cf4a3815ac4a68105b9e8e

Got it. Thank you for the explanation.


[full-ci][test-only] Start tracking vendor directory [go mod vendor]

Part of: https://github.com/owncloud/ocis/issues/3962
with this pr:

start tracking vendor dir to bundle all the external dependencies with the code
vendor dir generated using go mod vendor

Closes: https://github.com/owncloud/ocis/issues/3937

closing on behalf of https://github.com/owncloud/ocis/pull/4032#issuecomment-1167269143


Tighter particle spawning

Currently, if tightParticleSpawning is true 2 particles will spawn evenly spaced across one block's size.
Maybe make it 3 or 4 particles for every block.
current implementation

Is this project is ongoing? Let me know further (DOCS) to contribute on it as "good first issue".


Possibility to use without the dependency to file io and streams to use in intel sgx enclaves

includes some macros to be defined for using without file io.

Coverage remained the same at 99.982% when pulling 1a1381f071156cffdc8f3d90d413e721ea6467a7 on theShmoo:without-io into 7126d88803eeb9d28cc10621f01a58813d50d078 on nlohmann:develop.

Sorry for the inactivity. I have one question left: you write in #2728 that the headers for I/O do not exist. But in your change you seem not to exclude any headers if JSON_NO_IO is defined.

Ah that is true!
The headers exist in Intels SGX implementation of the standard library. But they are empty:
for example in iostream: https://github.com/intel/linux-sgx/blob/master/sdk/tlibcxx/include/iostream
Should I remove the includes so that it also usable for other applications?

Yes, please. The use case may be still quite special, but at lease it would not assume include included headers are empty. I could imagine that that flag may be usable for some if they want to reduce compile times if they do not use I/O in their project.

Does the build pipeline fail because of me or is this an error in the pipeline?

This seems to be an issue in the pipeline. I need to investigate.

Please update the branch - I just merged #2817 to fix the CI.

Thank you very much for your support and your review!

Thanks!


Issue tracking: PS! edition

I am working with Nineage to start thinking about creating an issue tracking system for PS! that would allow the average user to easily and effectively report bugs pertaining to relevant parts of PS!.  Here's the basics of what I was thinking along the lines of for the architecture:
>user does /reportbug
The client sends the user a popup with a form asking for information pertaining to the bug, such as...

Title
Description
Category
Evidence

After the user fills that information out, it will send this to the server, where the database of issues are stored. (TSV database like the existing local ladder system...?)
>user does /viewbugs

A popup is displayed with all of the submitted bug reports.  The user has a drop down to sort by category.
The user also has the option here to 'star' important and valid bug reports.
Bug reports that have the most stars are sorted at the top of the list

And of course, there will be a certain rank that is able to delete reports based on the report number with /deletereport [report number]
This is just a rough sketch on my idea of a issue tracking system, what does everyone else think?

Do we currently support popup forms? I'd guess no. Imagine a popup form asking for someone's password... such phishing...

Command-based just isn't a very good system...

Mandatory xkcd: https://imgs.xkcd.com/comics/standards.png

tbh, we do need some sort of issue tracker... the biggest issue with existing ones is probably that they cost money, and I don't trust them not to have glaring vulnerabilities.

Is it possible that this kind of form could only work client-sided?  That way, other servers cannot try to do another kind of popup form server-side?

We could, but at that point we might want to write it entirely separate from PS or something.
One idea would be to host it outside of the main server, so vulnerabilities are less of an issue. My only issue with that is that moderation/trolls could be an issue if it's disconnected from the PS login system.

This is semi off topic, but did PS's old forums use PS login credentials?  I'm wondering if those could be optimized for bug reports...
Did those have a 'liking' or 'staring' feature by chance? (I don't remember)

(I want to reemphasize how useful sorting reports by categories could also be very helpful)

Yes, PS's old forums did. PS's old forums were also hacked. That's kind of why I said I don't really trust most third-party software these days.

bugzilla works fine for mozilla. No idea how well it works from a end-user perspective though.

Now that we have #2367, we can just put approved mechanics bugs there. I'm fine with the current system for everything else.


support isolated namespace for integration test

Context: https://github.com/istio/installer/issues/99
@costinm @howardjohn PTAL

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: morvencao
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
c086494ba2c819c23df901f569bd881791c9b4f2
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
c086494ba2c819c23df901f569bd881791c9b4f2
link
/test istio-integ-k8s-tests

prow/release-test.sh
c086494ba2c819c23df901f569bd881791c9b4f2
link
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
93be1270556e8354abef52988adc0050a448e402
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
8dcf797e8cd5a857416097898c4db7192f0ad7e3
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
8dcf797e8cd5a857416097898c4db7192f0ad7e3
link
/test istio-integ-k8s-tests

prow/release-test.sh
8dcf797e8cd5a857416097898c4db7192f0ad7e3
link
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-test

/test istio-integ-k8s-tests

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
8dcf797e8cd5a857416097898c4db7192f0ad7e3
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn, morvencao
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Depending on which is merged first, we need to update https://github.com/istio/istio/pull/13706/files as well

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, linsun, morvencao
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [linsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


QMCGenerators v1.1.0 Release

@JuliaRegistrator register()

@JuliaRegistrator register again

Registration pull request updated: JuliaRegistries/General/86079
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.1.0 -m "<description of version>" 9cbfd12bd8412846eb46f9e75d1591463d3d3fd5
git push origin v1.1.0


Nothing is being displayed on screen after merging the dev branch into feature/frontend-catalgoue

My features and the application as a whole wes working before this merge, but after, only a white screen is ever displayed. Was there a change in the dev branch that I need to be incorporated into the pages I altered?

Jorden's working branch was merged with it's remote version accidentally, which was merged with the latest remote develop branch. This caused syntax errors when resolving conflicts during the merge with develop. The commit merge with develop has been reverted to go back to Jorden's working version.

I found that the error was coming from my Home.jsx page where we import CSSBaseline.
Moving CSSBaseline above Box import solves the issue:
From:
import Box from "@mui/material/Box";
import CssBaseline from "@mui/material/CssBaseline";
To:
import CssBaseline from "@mui/material/CssBaseline";
import Box from "@mui/material/Box";
https://stackoverflow.com/questions/74542488/react-material-ui-createtheme-default-is-not-a-function


docs: Remove the unsupported object and field from Scheduler API doc

Close: #3629
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?

Issue Number: #3629
What is the new behavior?
The requestBody in the RESTAddress should be removed, because we have moved it to the content field in IntervalAction.
MQTTAddress is unsupported, so it should be removed.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

New Imports

[ ] Yes
[x] No

Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information

Codecov Report

Merging #3634 (894ca44) into main (7434bca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3634   +/-   ##
=======================================
  Coverage   47.29%   47.29%
=======================================
  Files         112      112
  Lines        9174     9174
=======================================
  Hits         4339     4339
  Misses       4462     4462
  Partials      373      373

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7434bca...894ca44. Read the comment docs.


Check whether the task finishes before deferring the task for RedshiftSQLOperatorAsync

Like the SnowflakeOperatorAsync, we try to verify if the submitted job has already completed before deferring it to prevent unnecessary deferring. This way, we can skip deferring the task if it has already been finished.


Pedestrian volumes has an error

Its showing a pretty unexpected zig-zag pattern sometimes, this can't be right need to hand check some numbers/ data processing.

Fixed with v1.8.3


[core] Add integrity hashes to yarn.lock

Field was added in<EMAIL_ADDRESS>See yarnpkg/yarn#5042 for more information.

Tested this on windows in the basic cmd shell on<EMAIL_ADDRESS>just to be sure this is backwards compatible and causes no regeneration of the lockfile. Seems all good 👍


Fix postgresql persistent helm chart

This pull request fixed postgresql-persistent helm chart.
Also helm chart packages are updated.

[test]

[test]

[test]

[test]


Use String#includes instead of indexOf

Looks like String.prototype.includes() works in Chrome 41+, so that should be safe now. :+1:


Close socket without GOODBYE if RESET fails.

This is considered a protocol violation.

This fix still sends RESET before closing the connection.


Error into permissions view

Error when open view permissions.
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'hasOwnProperty')
at module.exports (init-query.js:7:46)
at Proxy.created (v-client-table.js:91:27)
at callWithErrorHandling (runtime-core.esm-bundler.js:173:36)
at callWithAsyncErrorHandling (runtime-core.esm-bundler.js:182:21)
at callHook (runtime-core.esm-bundler.js:3608:5)
at applyOptions (runtime-core.esm-bundler.js:3510:9)
at finishComponentSetup (runtime-core.esm-bundler.js:7387:9)
at setupStatefulComponent (runtime-core.esm-bundler.js:7298:9)
at setupComponent (runtime-core.esm-bundler.js:7220:11)
at mountComponent (runtime-core.esm-bundler.js:5542:13)
Uncaught (in promise) TypeError: Cannot read properties of null (reading 'emitsOptions')
at shouldUpdateComponent (runtime-core.esm-bundler.js:1108:29)
at updateComponent (runtime-core.esm-bundler.js:5567:13)
at processComponent (runtime-core.esm-bundler.js:5521:13)
at patch (runtime-core.esm-bundler.js:5119:21)
at patchBlockChildren (runtime-core.esm-bundler.js:5424:13)
at patchElement (runtime-core.esm-bundler.js:5332:13)
at processElement (runtime-core.esm-bundler.js:5199:13)
at patch (runtime-core.esm-bundler.js:5116:21)
at ReactiveEffect.componentUpdateFn [as fn] (runtime-core.esm-bundler.js:5729:17)
at ReactiveEffect.run (reactivity.esm-bundler.js:190:25)
Dont load the table and crash the frontend. Thanks to helpme

Need to weed it


Deleting a reconciliation service fires of a reconciliation attempt against it.

To Reproduce
Steps to reproduce the behavior:

First, select Start Reconciling to bring up the Reconciliation dialog
Then, click the [x] to remove a reconciliation service
Finally, notice that instead of simply removing the service it tries to reconcile against it and you have to quit that operation.

This is a minor nit since canceling the run is easy enough.  I just thought it worth reporting.
Current Results
Reconciliation runs when removing a service.
Expected Behavior
Expect service to simply disappear from the list of options and potentially wait for you to choose one of the remaining options.  Alternatively simply close the dialog when a service is deleted.
Screenshots

Versions

Operating System: iOS
Browser Version: Firefox 84.0.1
JRE or JDK Version: java version "1.8.0_281" (I'm not sure this is the version used by OpenRefine...)
OpenRefine: 3.4.1

I think I remember seeing a fix for this, so it probably has been resolved on master but the fix has not been released yet.

FWIW, I did try to search through the issues first before posting.  I didn't see it mentioned.

Already fixed on master.


Case sensitive file systems make trouble

The ncurses package contains two files that share the same name in different capitalizations (at least on Linux).
Users using docker on macOS have a problem (https://github.com/prefix-dev/pixi/discussions/594#discussioncomment-7951695) because linking fails.
I think we should fix this in rattler so that one of the two files "wins" and the other one is ignored.

related https://github.com/conda-forge/ncurses-feedstock/issues/73


fix: add project color for the website template project settings

I noticed an error while applying the website template:
Error loading settings [
  {
    message: `Validation failed for field "project_color". Value can't be null.`,
    extensions: {
      code: 'FAILED_VALIDATION',
      field: 'project_color',
      type: 'nnull'
    }
  }

Looking at the Agency OS template I made the assumption that it would be better to define a value here, so I have set it to the default Directus color. Tested locally, the import error is gone (works on my machine).

@joggienl Were you trying to apply AgencyOS against 10.7.0?
I believe that project_color validation was added in the most recent version which wasn't out when we extracted the template for the AgencyOS instance.

Nevermind. Saw it was the website template. 👍

Thanks @bryantgillespie!


XPand ModellEditor VS 2022 Extension

𝗤𝘂𝗲𝘀𝘁𝗶𝗼𝗻
Hello dear support,
Im struggling with getting the XpandModelEditor to get running.
I just created a new 23.1 XAF solution with VS 2022.
Than I was adding the ModelMapper´Module to the platform independend Module.
Than I was compiling the whole solution and at the very end i selctede Xpand ModelEditor from the Extension Menu of VS 2022.
Now for a short period a empty window (i guess for selection of Models) gets shown, but it closes immedeately and a notification 'Parse projects' appears. Than nothing more happens.
Can you give me a hint what i make wrong ?
Yours Thomas
𝗛𝗼𝘄 𝘄𝗲 𝗽𝗿𝗶𝗼𝗿𝗶𝘁𝗶𝘇𝗲 𝗶𝘀𝘀𝘂𝗲𝘀
We will try to answer all questions that do not require research within 24hr.
To prioritize cases that require research we use the following labels in order.

❇ Exclusive-Services
❤ Bronze Sponsor
❤ Sponsor
❤ Backer
Installation
ShowStopper
Nuget
Contribution
BreakingChange
ReproSample
Deployment
Must-Have

For all other issues the posting time is respected.

Hi
Cannot tell at least parsing works fine on my side even for 23.2

the source is online though u can run the project your side and debug the problem
Xpand.XAF.ModelEditor.WinDesktop.csproj

Thank you for your hint. It seemed that I hadn't installed all .NET SDK which were neccessary.
Now XPandModelEditor starts.

I am having the exact same issue. I get a flash on the screen and the the Parsing Notification, then nothing. Any assistance appreciated.

Closing issue for age. Feel free to reopen it at any time.
.Thank you for your contribution.


onesupport: Extend for priv. escalation via sudo on remote nodes

Description
onesupport tool, which is part of Enterprise Edition, gathers all valuable information from the remote hypervisors hosts to help support understand the customers' environment. It tries to login remote hosts under root and if fails fallbacks to oneadmin. Under it oneadmin gathers only a minimum it expects it can access. But, some environments disable remote root login, but give oneadmin full control over the machine over sudo (despite this is not recommended in general!).
Goal is to introduce 3rd way to get into the data over remote oneadmin user with sudo (i.e., ssh oneadmin@$HOST sudo ....).
Use case
Flawless UX. Try as many common options to get as much information possible.
Additional Context
https://github.com/OpenNebula/infra/issues/118

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

With the revamp of the onesupport tool, I think this is no need, we currently get the needed information. So, I'm going to close it and if needed we can reopen it in the future.


Improvement of dev-experience, when working with Swidgets

The developer-experience, when developing a swidget is anything but good.
We should identify real life painpoints from past and ongoing projects and try to improve the setup based on the results.
Opinions, suggestions and questions welcome here ;)

Acting on behalf of Daimler TSS GmbH.

Will be considered after decision, if we should switch to Webpack Module Federation


The method 'someMethod' isn't defined for the class 'invalid-type'

The error message The method 'someMethod' isn't defined for the class 'invalid-type'. is misleading.
$ cat -n t.dart
     1	main() {
     2	  Foo foo;
     3	  foo.someMethod();
     4	}
$ ./pkg/front_end/tool/fasta compile --strong t.dart
t.dart:2:3: Error: 'Foo' isn't a type.
  Foo foo;
  ^^^
t.dart:3:7: Error: The method 'someMethod' isn't defined for the class 'invalid-type'.
Try correcting the name to the name of an existing method, or defining a method named 'someMethod'.
  foo.someMethod();
      ^

Errors on invalid types are now silent.


git-signs async doesnt jump until motion registered

some issue with the function being async. Visible when the next changed chunk is outside of the screen.

cannot reproduce anymore after recent update


Link to content data from admin dashboard

Adds a link to the content-data app in each environment.
Includes basic tracking.
Possibly there will be further PRs to improve the tracking.

 (2) Add main link to Content Data from Whitehall


Make MTU 4-byte aligned

Fixed in a different way in https://github.com/sctplab/usrsctp/commit/46a0fd5dcf888f5bc52b42959b61faab43be8c5a.


Support official self-archive data format

Twitter offers a way to archive your own account, so look into how the data is saved for that and figure out if we can parse it to be compatible with this project.

[ ] Potentially and hopefully allow merging of self-archived data with scraped data for a more complete data set.
[ ] Look into how and if it backs up media, and how and if we can use that to save unnecessary download traffic on #26

BREAKING ISSUE:
Self-archive data does not include data on any users other than the main user.
Options:

Write a scraper to only scraper users based on a list compiled from the archive data
Still require original scraper and only use the archive data for supplementation
Adjust code to allow for "anonymous" tweets if only archive data is provided.
Only support original scraper and ignore the archive data.

Note:
All media is archived with a filename format we can reconstruct, [tweet_id]-[media_id].[filetype_extension], so we could at least use that for a confirmed full media backup of an account.


Cannot start up as root although I specify an alternate user data directory with the --user-data-dir in Ubuntu docker container

VSCode Version: 1.36.1-1562627527 (insiders 1.37.0-1564378337)
OS Version: Ubuntu 18.04 in Docker container

Steps to Reproduce:

code . produces the following error:
You are trying to start vscode as a super user which is not recommended. If you really want to, you must specify an alternate user data directory using the --user-data-dir argument.
code . --user-data-dir="."  does nothing

Notes:

Does this issue occur when all extensions are disabled?: Yes;
insiders build has the same behaviour;
similar issue suggestions (#7243, #52732) did not help

Does does nothing mean it never returns... or it returns immediately? If you add --verbose, is there an error?

Here is what I see after running code . --user-data-dir="." --verbose:
[41952:0730/131625.898665:ERROR:bus.cc(394)] Failed to connect to the bus: Failed to connect to socket /var/run/dbus/system_bus_socket: No such file or directory                                                                                [41980:0730/131625.932839:ERROR:gl_surface_glx.cc(429)] GLX 1.3 or later is required.                                                                [41980:0730/131625.932879:ERROR:gl_initializer_x11.cc(157)] GLSurfaceGLX::InitializeOneOff failed.                                                   [41980:0730/131625.940820:ERROR:viz_main_impl.cc(236)] Exiting GPU process due to errors during initialization
[main 2019-07-30T13:16:26.053Z] Starting VS Code
[main 2019-07-30T13:16:26.054Z] from: /usr/share/code/resources/app
[main 2019-07-30T13:16:26.054Z] args: { _: [ '/desktop' ],                                                                                diff: false,
add: false,
goto: false,
'new-window': false,
'reuse-window': false,
wait: false,
version: false,
help: false,
'list-extensions': false,
'show-versions': false,
verbose: true,
status: false,
'prof-startup': false,
'disable-extensions': false,
'disable-gpu': false,                                                                                logExtensionHostCommunication: false,                                                                                'skip-getting-started': false,
'skip-release-notes': false,
'sticky-quickopen': false,
'disable-restore-windows': false,                                                                                'disable-telemetry': false,
'disable-updates': false,
'disable-crash-reporter': false,
'skip-add-to-recently-opened': false,                                                                                'unity-launch': false,
'open-url': false,
nolazy: false,
issue: false,
'file-write': false,
'file-chmod': false,
'driver-verbose': false,
force: false,
'prof-code-loading': false,
'user-data-dir': '.' }
[main 2019-07-30T13:16:26.056Z] Resolving machine identifier...
[main 2019-07-30T13:16:26.056Z] Resolved machine identifier: 7996181d-5c89-4324-b33f-b482bd7df2ed
[main 2019-07-30T13:16:26.075Z] update#setState idle
[main 2019-07-30T13:16:26.078Z] [storage state.vscdb] open(/desktop/User/globalStorage/state.vscdb, retryOnBusy: true)
[main 2019-07-30T13:16:26.079Z] lifecycle (main): phase changed (value: 2)
[main 2019-07-30T13:16:26.080Z] windowsManager#open
[41952:0730/131626.129046:ERROR:browser_main_parts.cc(137)] X IO error received (X server probably went away)

Just a clarification note, I'm able to run Firefox, PyCharm and everything else that I need.

Does the /desktop/User path exist in your system?

Yes, it does. /desktop/User contains globalStorage and workspaceStorage, both directories are empty

Got it. I think your issue is this:
[41952:0730/131626.129046:ERROR:browser_main_parts.cc(137)] X IO error received (X server probably went away)

Do you have an X server in the container?

No, I don't have X server in the container.
X server is only installed on my actual Windows machine

So... how do you want to launch Code?

I run X on my Win machine, set up DISPLAY variable in the container and run whatever I need to run

Can you run vanilla Electron that way?


Ignore trailing commas

Temporary fix for issue with black
https://github.com/psf/black/issues/1288


[Question] regarding docker image tags and updates

Hi,
First of all - this is not an issue but two questions on information I can't find and maybe knowledge about docker images I don't have 😃
I am currently using the linuxserver-sonarr:preview and linuxserver-radarr:latest. I saw that your docker images are depending on those from linuxserver (which makes migration quite easy :+1:)
These are the two questions I have:

Are your tags equivalent to those from linuxsever. E.g. if I want to use the preview image of sonarr do I have to choose the preview tag? (I think so - but just to clarify)

If any of the underlying linuxsever image is updated - is there any policy that yours will be updated too? (And I guess yours will be updated more often also containing the updates from your repo?)

Thanks!

Yes
Yes*

docker hub automatically triggers a build if the parent container is updated. It does not trigger a build everytime I update this repo, only the sonarr-sma/radarr-sma repos. I do manually build after any major changes and usually any minor changes too. There's the option to enable SMA_UPDATE to force the script to do a git pull on restart to ensure the script is the most up to date without needing a container rebuild. Its in the readme.

Excellent - thank's a lot! 👋


oci: Set artifactType in all cases

The documentation in 0 states we can set the artifactType in all cases, do it to simplify the logic.
See https://github.com/inspektor-gadget/inspektor-gadget/pull/2572#discussion_r1752171717
Discussion
I still don't think application/vnd.gadget.ebpf.program.v1+binary is right. IMO it should be something like application/vnd.gadget+binary as the manifest refers to the whole gadget, not a single layer.
See previous discussion on https://github.com/inspektor-gadget/inspektor-gadget/pull/2177#discussion_r1370713366 too.

Updated.

The new artifactType application/vnd.gadget.v1+binary should be documented in docs/spec/oci.md.


Update DOI UI app to use NPM package

@eddiesarevalo removes the old search code and will add the npm package version of the search code.

The change is done and @eddiesarevalo is now testing.

@tloubrieu-jpl After some more testing I did discover some bugs.

Hovering over status will crash the app. A popup is supposed to show but something must be causing an error.
Going to the search page will cause the app bar to become white. There must be some sort of styling issue.

@tloubrieu-jpl Will put this ticket in review and create a new one for bug fixes.

Fixed the known bugs will continue to test before closing this one.

@eddiesarevalo you should have created a pull request in the nasa-pds/doi-ui repository to formalize the update and enable the review of the changes.

@eddiesarevalo are the changes in pds-wds-install branch ?

@jordanpadams @tloubrieu-jpl How can I verify this is done in B12.1?

@gxtchen just updated this to skip I&T


join mailbox status to mailbox locations on map

to start, can be client side join based on outlet identifier. that should scale to a few thousand entries.

no longer joining, pulling from geojson in API endpoint


Separate classloaders or use Module Layers

There should be three classloaders:

Platform + all TestEngine implementation classes
Main classes
Test classes

From @rfscholte in #4

I created one a long time ago with @britter at ApacheCon, I think he still has it somewhere. Right now everything is one 1 classpath, which means that "main" code can access the testclasses and engine, which is not desired. Same counts for "test" code: it should not be able to access engine code.
I use the word "access" on purpose, because maven scopes prevent you from doing this during compilation, but it is still possible via reflection.

When running in strict modular test mode, shouldn't the Java module system prohibt such reflections? I do think so, but might be wrong.

Adding an integration test for each scenario: using 1 classloader for white-box and black-box testing.
Assumption: reflections work when in white-box and fail when in black-box testing mode.

My assumption was wrong. I was quite shocked to see this kind of reflection just work:
module foo
module foo { exports foo; } contains foo.internal.InternalPublic
module bar
open module bar { requires foo; requires org.junit.jupiter.api; }
  @Test
  void reflectInternalPublicClass() throws Exception {
    loader.loadClass("foo.internal.InternalPublic");
  }

Remi, it should be either separe classloaders or module layers. Right now everything is just put on 1 classpath/modulepath. This is one of the main reasons why with Maven there's only 1 artifact version for all scopes, you cannot specify a different version for test compared to compile.

Some of my faith was restored. Using such a loaded classes throws the expected IllegalAccessException.
  @Test
  void reflectInternalPublicClass() throws Exception {
    Class<?> internal = loader.loadClass("foo.internal.InternalPublic");
    internal.getConstructor().newInstance();
  }

Yields
[ERROR] .
[ERROR] '-- JUnit Jupiter [OK]
[ERROR]   +-- BarTests [OK]
[ERROR]   | +-- accessModuleBar() [OK]
[ERROR]   | '-- accessModuleFoo() [OK]
[ERROR]   '-- ReflectionBlackBoxTests [OK]
[ERROR]     +-- reflectFooClass() [OK]
[ERROR]     +-- reflectClassThatDoesNotExist() [OK]
[ERROR]     '-- reflectInternalPublicClass() [X] class bar.ReflectionBlackBoxTests (in module bar) cannot access class foo.internal.InternalPublic (in module foo) because module foo does not export foo.internal to module bar
[ERROR]
[ERROR] Failures (1):
[ERROR]   JUnit Jupiter:ReflectionBlackBoxTests:reflectInternalPublicClass()
[ERROR]     MethodSource [className = 'bar.ReflectionBlackBoxTests', methodName = 'reflectInternalPublicClass', methodParameterTypes = '']
[ERROR]     => java.lang.IllegalAccessException: class bar.ReflectionBlackBoxTests (in module bar) cannot access class foo.internal.InternalPublic (in module foo) because module foo does not export foo.internal to module bar
[ERROR]        java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:361)
[ERROR]        java.base/java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:591)
[ERROR]        java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
[ERROR]        bar/bar.ReflectionBlackBoxTests.reflectInternalPublicClass(ReflectionBlackBoxTests.java:21)
...

@rfscholte / @forax -- that isolation issue only applies to only the two test run modes?

CLASSIC: no Java modules involved, everything's on the class-path
Here a ClassLoader hierarchy is needed for isolation.
MODULAR: two modules with different names
Here ModuleLayers help isolating the different actors: test infrastructure, main module and test module

When patching (either at compile or test runtime) the isolation is broken-by-design, right?
Here, there's a) no need and b) no chance to separate things as they are logically merged into a single module anyway.

Just to be 100% sure:

JPMS encapsulation does not limit visibility (you can load internal classes, get private methods, etc.)

This also holds true when you launch a plain Java program using the --module-path? Meaning, when you know/scan/guess the internals of a module you may you may see everything? Ergo, no change compared the the classpath world?

[...] Same counts for "test" code: it should not be able to access engine code.
I use the word "access" on purpose, because maven scopes prevent you from doing this during compilation, but it is still possible via reflection.

Seeing engine code from tests at runtime is possible, but invoking engine code is not possible.
I can live with that.

Project outlining the shared classloader issue: https://github.com/britter/junit-cl

How would such a classloader stack look like?

foundation classes
platform/engines
test classes + test dependencies (Jupiter API, AssertJ, Mockito)
main classes + main dependencies (other 3rd-party libraries)

Reading it out aloud:

main classes only see main deps
test classes see test deps and main classes and main deps
platform/engines see test classes+deps and main classes+deps
foundation classes ... are loaded by a class loader acting as the common root for loaders created here


Made Love theme for examples.

I have added my theme to the buttons list and have added a theme into the listextender.js file.

Looks great, thanks for the contribution! 🚀


VHD size cannot be a decimal number.

After hours of troubleshooting why my VHD (converted from VHDX) was not able to convert to a disk resource I found that this was caused by it having a decimal size. After expanding the disk to a non-decimal size it all started working. Please add this as a requirement in this article.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1b9c0d7a-bbf5-eccc-f2ca-a825bf42c82f
Version Independent ID: 58aa93af-4030-1541-a14c-c66c683ccf7c
Content: Prepare a Windows VHD to upload to Azure
Content Source: articles/virtual-machines/windows/prepare-for-upload-vhd-image.md
Service: virtual-machines-windows
GitHub Login: @glimoli
Microsoft Alias: genli

@kempd Thanks for the feedback on the issue. I am assigning the issue to the author for updating the document as required.

@genlin Can you please add your comments to the issue and update the document as requested.

Hi @kempd thanks for your feedback, that was already on my notes to have the size of the VHD aligned to 1Mb. I'll update the document shortly.

@kempd We have updated the article. Thanks for helping to improve the article. I will process to close this issue. Feel free to reopen it if there is any feedback or comment about this matter.
#please-close