Devboard drivers cleanup

@kisvegabor Seems /drivers/stm32f429_disco duplicates a lot of files, already available in PIO. When board defined in config, that include appropriate HAL drivers + board-specific BSP drivers. Could you remove c/h pairs one-by-one an check if app build still works on hardware?
Candidates to remove - everything with ST copyright info.

I can take a look tomorrow.

I've checked it but found only the HAL driver in .pio/build/stm32f429_disco/FrameworkHALDriver but can't find the board specific files.
Do you know where are they?

See root point  ~/.platformio/packages/framework-stm32cube/.
Then, inside ./f4/Drivers/BSP/STM32F429I-Discovery and so on

Ah, thanks.
Still struggling with

How to include files from framework. Only the absolute path worked so far.
How to add the BSP files to the build. HAL is built but e.g. stm32f429i_discovery.c doesn't.

Problem consists of several parts. Prior to start, please read https://community.platformio.org/t/how-in-include-disco-f429zi-headers/7001/13?u=vit

I removed copies of common BSP drivers https://github.com/lvgl/lv_platformio/commits/drop-files (in branch). Build is ok, but not tested on hardware
stm32f429i_discovery.* right now can not be included, because they still no fixed config (see topic above)

reported https://github.com/platformio/platform-ststm32/issues/413, let's postpone this

Pending:

Seems stm32f4_it.* can be dropped (+ move SysTick_Handler to driver.c
system_stm32f4xx.c - if not modified - drop it.

Also see https://github.com/platformio/platform-ststm32/blob/develop/builder/frameworks/stm32cube.py. All magic about directories happens here.

Thanks!
The drop-files branch workes fine. I removed strm32f4_it.* and system_stm32f4xx.c.
AFAIK SystemClock_Config is required. It seems the "blink" example runs with a default (very slow) clock.
My board has an 8MHz quartz so HSE_VALUE should be 8M. I don't know why was it 12M. (If SystemClock_Config thinks the quartz has a greater value it sets the PLL multiplier to a smaller number and the MCU will run slower.)
All these are updated in deaa864

My board has an 8MHz quartz so HSE_VALUE should be 8M.

This line was added by you. My quesion is, should it eхists there at all? It has defaults in hal headers.
Is it possible to just drop this line or something become broken?

Do you have reasons to change default env or it was not intended?

When complete, could you squash everything (including my changes) into single commit? Something like "stm: drivers cleanup"

This line was added by you.

I don't know why. Maybe just a typo.

My quesion is, should it eхists there at all? It has defaults in hal headers.

The default value is 25M.

Do you have reasons to change default env or it was not intended?

No intended. I'll change it back.

When complete, could you squash everything (including my changes) into single commit? Something like "stm: drivers cleanup"

Sure, no problem.

All clean to me. Thanks for info.

https://github.com/lvgl/lv_platformio/blob/master/platformio.ini#L59 - please set to 8000000 and add comment above # header's default is 25MHz, but board uses 8MHz crystal
Squash everything in that branch to single commit.

I think this can be landed. Will create new issue when PIO will fix board headers include.

Done, merged to master.


some public functions return private types

Hi,
I've noticed that the settable function in PropertyInterface accepts an object of type PropertyInputHandler, which is seemingly private; it cannot be accessed by user code.  To avoid warnings, a user must be quite verbose when calling settable():
myNode.advertise("foo").settable(
  std::function<bool (const HomieRange &, const String &)>([] (const HomieRange &range,
    const String &value) {
    // stuff
  }));

Should PropertyInputHandler (and other similar classes) be public?

Actually, it's not private, but inside the HomieInternals:: namespace, so you can access it. But PropertyInputHandler is the same type as std::function<bool(const HomieRange& range, const String& value)>, so just like #227, I think it's a CLion issue. I am saying this, because if you try to compile your sketch with a verbose output, you'll see some homie-esp8266 warnings, but it does not complain about types not being compatible. So I don't see why CLion would flag this as a warning.

Yeah, I'm seeing what you're saying.  It doesn't affect compilation (obviously it's a warning of some sort), but it's unclear where this is coming from in CLion.  Usually with their inspections, you can get more information, but none is available.  I bet it's a CMake thing.

Alright, so there are a handful of bugs around this issue in JetBrains' YouTrack.  Unfortunately, I don't know how to disable them (just started using CLion, but as I wrote above, this is especially strange behavior).  I'm going to close this and #227--and probably just use Atom w/ PlatformIO for now.  😝


broker: applications refactoring and fixes

This is a first step toward a more modular design of the application. It also makes thing clearer regarding the different entities of the broker application:

main Tornado application used as the global controller of the broker service: it's in charge of managing clients/nodes sockets and can control the CoAP node manager (this design is subject to change)
Added a CoAP manager class to interact using CoAP with nodes: makes nodes management easier, all CoAP code being grouped in a single module.
Removed data and utils modules that became useless

This PR also fixes a bug at installation and a remaining occurrence of iot-kit.


Question about the embedding space of contrastive learning and clustering?

Hi, thanks for your excellent work. I was wondering why implementing prototype classification and representation learning in two embedding spaces, i.e., bottleneck_dim $\neq$ in_dim (if I didn't misunderstand the code), would it be helpful if representation learning and clustering are in the same embedding space?
Also, in your case, the dim of contrastive (representation) learning is 256 (bottleneck_dim in your code), while 65536 (out_dim in GCD code) in GCD paper, it is a huge difference, how does the projection dim influence the results?
Thanks!

Hi @msj17thu,
Thanks for your attention to our work. Regarding your question on the selection of the representation space, this is actually an important topic discussed in our paper, please refer to Sec. 3.2 (arXiv v2) or Sec. 3.3 (arXiv v1).
Regarding the dimension of the last layer of the projector (MLP part in the DINOHead), 256 is a common choice in the self-supervised learning community, and it also holds true for DINO, the paper that GCD follows. The last_layer that contains 65536 components is a special design for prototypical contrastive learning, which should be dropped if one only intends to perform vanilla contrastive learning between images, as the text of GCD paper states, and we believe keeping the last_layer is an unintended behaviour of the GCD authors. As for performance, the difference is quite negligible, and GCD's implementation might produce small gains though.

Okay, I figured it out! Thank you for your solid analysis and patient response. 😄 👍


SageCardStack: Add spacer: "form" modifier

Description
Adds a spacing modifier that accepts a value of "form" to SageCardStack rails Sage component. This adds support for form element spacing.
Slack conversation context:
https://kajabi.slack.com/archives/CU5JG6N2E/p1611864458032400
Screenshots

before
after

Test notes
n/a
Related
BUILD-693

@philschanely I can take on the React component 💯 I have a few things to get landed today, will look soon.

@philschanely I can take on the React component 💯 I have a few things to get landed today, will look soon.


docs(remix-server-runtime): mention Netlify Edge runtime

👋🏼 This README lists supported server runtimes, but the Netlify Edge Functions runtime wasn't listed.

Thank you for the PR - but we list out all the third party/community adapters in the docs and we've got Netlify Edge included there so I think we're ok there.


gb build doesn't support -tags

Seems like an important flag for conditional compilation
Is there an alternative.

Dup of #81
Yes, I absolutely want to add these. It's on the roadmap.

@davecheney also, gb test -tags= should work?

Not yet I'm afraid, there is no -tag support yet.

On 17 Sep 2015, at 19:29, Sergey Kamardin<EMAIL_ADDRESS>wrote:
@davecheney also, gb test -tags= should work?
—
Reply to this email directly or view it on GitHub.

:disappointed:
Is it planned to support this?

Yes, build tags are very much in the roadmap.

On 17 Sep 2015, at 20:03, Sergey Kamardin<EMAIL_ADDRESS>wrote:
Is it planned to support this?
—
Reply to this email directly or view it on GitHub.

Cool.
Also, just as an idea: in the Rust ecosystem, there are three types of tests:

unit
doc (exmaples)
and integration

For the integration tests there are special dir tests on the same level as src. In Go, I wanted to use -tags to separate unit-tests from integration-tests. So, since GB makes some rules to directory structure of project, it will be a good tool to split test code this way.
If you find this make sense =)

@davecheney what do u think about comment above?

You can do that now with gb as we have -tags support.
On Thu, Oct 8, 2015 at 12:35 AM, Sergey Kamardin<EMAIL_ADDRESS>wrote:

@davecheney https://github.com/davecheney what do u think about comment
above?
—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/226#issuecomment-146198095.

@davecheney thats cool, but what about tests dir?

So you're asking for $PROJECT/tests, not $PROJECT/src/tests ?
On Thu, Oct 8, 2015 at 12:38 AM, Sergey Kamardin<EMAIL_ADDRESS>wrote:

@davecheney https://github.com/davecheney thats cool, but what about
tests dir?
—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/226#issuecomment-146198733.

Yes, about $PROJECT/tests =)

Apart from putting things in different boxes, what would be the advantage
given that $PROJECT/src/tests would work today with no change.
On Thu, Oct 8, 2015 at 12:41 AM, Sergey Kamardin<EMAIL_ADDRESS>wrote:

Yes, about $PROJECT/tests =)
—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/226#issuecomment-146199356.

What will u do if you will have package tests, that's not for integration tests?

I'm not keen on adding a special top level directory $PROJECT/tests just so
that there can be some go code that does not exist within the existing two
project/src and project/vendor/src directories.
You're going to have to make a stronger argument that this code is special.
On Thu, Oct 8, 2015 at 12:44 AM, Sergey Kamardin<EMAIL_ADDRESS>wrote:

What will u do if you will have package tests, that's not for integration
tests?
—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/226#issuecomment-146200145.

Also, about tags – how could I use them?
> gb test -tags=abcd all
flag provided but not defined: -tags
Usage of /var/folders/g2/xmqjypqx3wn6h3nvq4yw9vr00000gp/T/gb182840264/xxx.test:
...

I am sorry, it is likely that gb test doesn't handle -tags correctly yet --
it has a lot of limitations. Please raise a new bug.
On Thu, Oct 8, 2015 at 12:56 AM, Sergey Kamardin<EMAIL_ADDRESS>wrote:

Also, about tags – how could I use them?

gb test -tags=abcd all
flag provided but not defined: -tags
Usage of /var/folders/g2/xmqjypqx3wn6h3nvq4yw9vr00000gp/T/gb182840264/xxx.test:
...

—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/226#issuecomment-146202972.


Agent sends empty heartbeats, because of new mechanism of PGP keys generation in management.

There was changes in GPG key generation in Subutai Management.
Agent does not support keys generated by Bouncy Castle and cannot encrypt message with this public key.
We need to investigate this problem to find a way to solve this problem.

Fixed in commit #22


Link to graph broken when using path in server URL

Noticed the Datasources > Link to Graph in Prometheus button link is broken if you use a path in the server url.
My server URL is http://dash.example.com/prom/
The link that button opens in a new tab is http://dash.mapgets.com/promgraph#<fragment>
It seems to strip the last fwd slash from the path + "graph". I dunno why without path it would work if it strips the first slash, that would become http://dash.mapgets.comgraph#<fragment> so there must be some special check for it.

/cc @stuartnelson3 Since I am having trouble getting the JS tests that should cover this (https://github.com/prometheus/promdash/blob/master/spec/javascripts/angular/services/url_generator_spec.js) to run on my machine (but can reproduce the problem manually), let's have a look at this tomorrow.

:+1:


Bugfix: Routes respect spoofed methods

Description
By default the loaded route collection uses REQUEST_METHOD directly from $_SERVER:
$this->HTTPVerb = strtolower($_SERVER['REQUEST_METHOD'] ?? 'cli');
This means when Router->checkRoutes() matches its collection it uses the actual request method instead of the spoofed method from the Request object. This PR injects the proper HTTP verb prior to instantiating the router with $routes->setHTTPVerb(), though alternatively RouteCollection's constructor could be changed instead.
To recreate the bug, create a resource route to a non-autorouted controller:
$routes->resource('foo', ['controller' =>'MyNamespace\Controllers\Foo']); And then try to access one of the non-POST supported methods by spoofing: Routing ignores the PUT routes and attempts to autoroute:Controller or its method is not found: App\Controllers\Foo`
Checklist:

[X] Securely signed commits
[X] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[X] Conforms to style guide

Hmm this is failing for CLI, should've thought of that. Let me think about the best way around this.


How to Inject pipeline variable into bash environment?

Hello,
I can't see a complete example of how to use a pipeline variable within a bash script. There is some piece of examples but insufficient for beginners.
I defined a variable in a pipeline, and I am trying to use it in a script that is run by yaml. The variable is always empty when it's printed within a bash script.
In Pipeline variables:
VARIABLE_NAME: 1234
In yaml
restore:
     commands:
     - !!defaultcommand
       name: 'Restore SDK'
       command: '.pipelines/restore.sh'

In .pipelines/restore.sh:
echo "VARIABLE_NAME: $VARIABLE_NAME"
VARIABLE_NAME is always empty. How can I make this work?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dd7e0bd3-1f7d-d7b6-cc72-5ef63c31b46a
Version Independent ID: dae87abd-b73d-9120-bcdb-6097d4b40f2a
Content: Define variables - Azure Pipelines
Content Source: docs/pipelines/process/variables.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: juliakm

you can access it by
echo "VARIABLE_NAME: $(VARIABLE_NAME)"


add max-in-flight

Setting these higher. The kube-apiserver appears to be fine with more load.

/retest

I certainly have no objection, but this should be tested downscale too (smaller cluster with heavy object load).

/lgtm

/retest


Create script to distribute cases between investigators

Requires 2 private files: cases currently under investigation, and
volunteer investigators.
Check
https://datasciencebr.com/o-que-atualmente-acontece-com-denúncias-feitas-na-operação-serenata-de-amor-49d75c01b509
for more information about the investigation process (in Portuguese).

I don't have much experience documenting Python scripts. @cuducos could use some of your guidance or at least a review here.

Another idea: use argparse to show the big description as the output for --help:
$ python src/distribute_cases.py --help

This script requires the existence of 3 files:
    * `data/volunteers.csv`. Private, containing emails of investigators.
        e.g.
        "Email (é por ele que iremos manter contato)"
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>    * Spreadsheet hosted at Google Drive. Private, containing cases.
        e.g.
        document_id,case,investigators,investigators_working
        1000,1,"john@example.com,michael@example.com,hannah<EMAIL_ADDRESS>        1001,1,"john@example.com,michael@example.com,hannah<EMAIL_ADDRESS>        1002,1,"john@example.com,michael@example.com,hannah<EMAIL_ADDRESS>        1050,2,"barbara<EMAIL_ADDRESS>    * `~/.gdrive_private`. Needed to access your Google Drive documents.
        Check the following link for further instructions.
        https://github.com/maybelinot/df2gspread#access-credentials

Closing this issue as we tend to not use this strategy anymore.


firebase problem

 auth.js:45 Uncaught  O {code: "auth/popup-closed-by-user", message: "The popup has been closed by the user before finalizing the operation."} code : "auth/popup-closed-by-user" message : "The popup has been closed by the user before finalizing the operation." __proto__ : Error
my issues are not getting resolved
please help

@dicer3 you need to provide more information such as the code snippet and how you trigger this error so we can help. Thanks

Closing this due to inactivity


Fixes #857 - Close Main Navigation Menu with Back button

This fix allows to close the main menu by clicking on the back button
When navigating in the Preferences Activities, clicking on the "Home" button (which appears with a left arrow) acts the same as clicking on the back button : It unpops each Activity.

Thanks @JeanGarf


Language server not activated for eelixir filetype

Describe the bug
When I load a .html.heex file, i.e. the Elixir template files that are used in Phoenix projects, the language server does not get activated.
The filetype that gets set for these files is eelixir, which should be something that is already supported through the passing of this server table...:
https://github.com/luckasRanarison/tailwind-tools.nvim/blob/0f2f03d535578d16042cd601e85c9236bd469456/lua/tailwind-tools/filetypes.lua#L27-L33
...through get_server_map...:
https://github.com/luckasRanarison/tailwind-tools.nvim/blob/0f2f03d535578d16042cd601e85c9236bd469456/lua/tailwind-tools/filetypes.lua#L47
...as the value for the includeLanguages key in the settings table that the language server gets initialized with:
https://github.com/luckasRanarison/tailwind-tools.nvim/blob/0f2f03d535578d16042cd601e85c9236bd469456/lua/tailwind-tools/lsp.lua#L137
To reproduce
Steps to reproduce the behavior:

Open up a .html.heex file
Write class="lime" (replace lime with something else that Tailwind has suggestions for)

Expected behavior
I should be able getting completions.
Environment

Operating system: Linux, Arch
Neovim version or commit: v0.10.1
Nvim-treesitter commit: 929ca9c76ee20bb27cffbde4ee9053b6c54d616
tailwind-language-server version: 0.0.24

Problem circumvention
Something I tried that "solves" the problem (although I'm not sure whether you think that it's an adequate solution) is extending the filetypes list with eelixir, right underneath this line:
https://github.com/luckasRanarison/tailwind-tools.nvim/blob/0f2f03d535578d16042cd601e85c9236bd469456/lua/tailwind-tools/filetypes.lua#L17
This makes the server initiate as expected.
I noticed that nvim-lspconfig adds eelixir to their filetypes list as can be seen here:
https://github.com/neovim/nvim-lspconfig/blob/dd329912c8d446240584a2dbcd3802af3a19105a/lua/lspconfig/server_configurations/tailwindcss.lua#L17
I don't understand why the includeLanguages map does not do the trick, as it's my understanding that it should be sufficient.

My bad, I forgot to add eelixir to supported filetypes through treesitter. But I'm also using v0.10 and *.html.heex files are set to heex, I'm not an elixir user but what's the difference?

Actually, only languages from the treesitter and luapattern map affects the language server startup.

Fixed

Thanks for the very quick resolution!


Submit to Coveralls

Codecov Report

Merging #12 into master will increase coverage by 0.18%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #12      +/-   ##
=======================================
+ Coverage   94.81%   95%   +0.18%
=======================================
  Files           4     4
  Lines         212   180      -32
=======================================
- Hits          201   171      -30
+ Misses         11     9       -2

Impacted Files
Coverage Δ

src/lcov.jl
93.18% <0%> (-2.9%)
:arrow_down:

src/memalloc.jl
95.65% <0%> (-0.35%)
:arrow_down:

src/parser.jl
79.16% <0%> (-0.15%)
:arrow_down:

src/CoverageCore.jl
100% <0%> (+1.86%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6281ba...c9098d9. Read the comment docs.


Strange Behavior on 3.1.5

Tried updating to 3.1.5 today in my next 15 project and noticed some strange behaviors.
Some things I noticed right away:

My tables were no longer taking up full width by default.
Dialogs were flashing while closing. (It would close and then you’d see a quick dark flash).
Site felt slower (maybe placebo?)

Reverting back to 3.1.4 fixed the issues.
Anyone else seeing this? Thanks!

<ScrollArea>'s first child also now longer has the min-width: 100% value set, so it shrink's down the content's size and offsets all the content in the ScrollAreas.
Reverting back to 3.1.4 now as well.

Seeing the same issue. ^ the <ScrollArea> width needs to be reverted.  Moving to 3.1.4 is the answer for now.

I am facing the same issues in 3.1.6 .
For table full width you can try adding this in globals.css:
[data-radix-scroll-area-content] {
    min-width: 100% !important;
}

Dialog issue fixed in https://github.com/radix-ui/themes/pull/649. Feel free to open another more specific issue if there's anything else.


Confusion with rspec-json_api_matchers gem

I am planning to use this gem, but I am got confused due to the fact that the readme is poiting to rspec-json_api_matchers, turns out this gem also points to this repo, is this a readme issue?

I probably just need to update the links in the README. rspec-resembles_json_matchers is the canonical gem name.


LibreOffice Writer Spellcheck Does Not Work

Issue description
When editing a document in Writer, the spellchecker does not catch any mistakes.  Even with hunspell installed.
Steps to reproduce

Open LibreOffice Writer.
Start typing misspelled words.
Observe that there are no squiggly red underline for the misspelled words.
Hit F7 or click on Tools -> Spelling and Grammar...
Observe a popup that says "The spellcheck is complete.", click "OK" and observe that no misspellings are detected.
Install hunspell and hunspellDicts.en-us, repeat the above steps and observe that the problem still exists.

Technical details

system: "x86_64-linux"
host os: Linux 4.9.73, NixOS, 18.03pre124015.f59a0f7f1a6 (Impala)
multi-user?: yes
sandbox: no
version: nix-env (Nix) 1.11.16
channels(root): "nixos-18.03pre125130.3a763b91963"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs

Solved by installing a dictionary extension:
https://extensions.libreoffice.org/extensions/english-dictionaries
This isn't very apparent, and definitely takes away from the out-of-the-box experience.  Spell and grammar check are now basic expectations of a word processor, perhaps some work on packaging can simplify this process.

The real issue is that it is impossible to quickly try changes to LibreOffice packaging (and I have no plan how to solve this)


[BUG] Iskcon events page not responsive.

I want to introduce responsiveness for this screen size in Iskcon events page. Please assign this issue to me under SWOC .

@yashi-15  Can you provide the link of the page which is not response.?

@yashi-15
Can you describe the issue a bit more?
When mobile view mode is switched on then it looks like it is responsive.
Screenshots attached

@yashi-15 Can you describe the issue a bit more? When mobile view mode is switched on then it looks like it is responsive. Screenshots attached

For mobile size only, it is responsive...but for other screen sizes it's not responsive (like for the one showed in the screenshot in my previous comment)

For example, if I switch the Dimensions to "Surface Pro 7" the orientation of the cards is not responsive:

Also, when it is switched to "Surface Duo" the orientation of the cards is not proper i.e. aligned towards left but not at the center.

go for it!

@akshitagupta15june I am interested to work on this issue!


fix: fix the rotation issue when undo/redo for a flipped image (#393)

Thanks for fixing this issue.


type of the battery

hi marcberliner,
I wanna ask, is this open source petlion only for lithium-ion batteries? can other types of batteries such as lithium-polymer use this petlion?

PETLION only supports lithium-ion, not lithium-polymer.

even though the electrodes from Li-Po are the same as lithium ion, namely using LCO, can it still not be used for lithium polymer battery models?

Can you share a paper with the PDEs describing lithium-polymer dynamics?


refactor Catalog creation and dependencies

closes #17
This PR does:

move .utils.catalog.py to .db.catalog.py
refactor catalog.py

remove non PG functions
object -> callable

create TableParams dependency to fetch table metadata

cc @bitner

Codecov Report

Merging #24 into master will increase coverage by 2.94%.
The diff coverage is 39.47%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   68.28%   71.23%   +2.94%
==========================================
  Files          20       20
  Lines         309      292      -17
==========================================
- Hits          211      208       -3
+ Misses         98       84      -14

Impacted Files
Coverage Δ

timvt/endpoints/index.py
87.50% <0.00%> (ø)

timvt/errors.py
0.00% <0.00%> (ø)

timvt/utils/dependencies.py
50.00% <23.07%> (-28.58%)
:arrow_down:

timvt/endpoints/tiles.py
35.29% <33.33%> (+1.36%)
:arrow_up:

timvt/db/catalog.py
55.55% <55.55%> (ø)

timvt/endpoints/demo.py
64.70% <60.00%> (+9.15%)
:arrow_up:

timvt/app.py
88.46% <66.66%> (+3.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abc15a4...7a85207. Read the comment docs.


Search for keywords in the player

Request
It would be awesome to be able to search through one or many recordings for certain keywords and jump to that video at the correct timestamp where it appears.
e.g. I use a tool with a certain keyword nmap hostname and want to search for this hostname in all of my terminal logs to find the occurrences and the commands output.
Technical Background
I'm currently running https://github.com/H8to/cLoggy in order to record my sessions and output them into a log folder all together.
From a technical perspective it looks like this:
logfile=$logdir/tmux_$(date +%F_%T)_PID$$.html
tmux pipe-pane "exec cat - | ansifilter --html --font monospace >> $logfile"

However, tmux pipe-panes and the html output do not work that well for interactive applications like less, vim etc. which is why I'd like to migrate to this awesome project and have my logs asciinemized :D
Edit:
I just found out there is no "startAt" parameter for the command CLI yet. But there is your timestamp in each file so a search could be easily implemented externally if there was a startAt parameter that accepts the internal timecode (seconds.fraction)

Related: https://github.com/asciinema/asciinema-server/issues/111


Add Span to Tokens, AST nodes

I'd like to use this library for some refactoring and analysis tools. It would be very helpful to have source line/column information available on the AST nodes, something along the lines of Span from syn. (https://docs.rs/syn/1.0.17/syn/spanned/trait.Spanned.html)
I see that line/column is already tracked in the tokenizer. I'm thinking something along the lines of:
struct LineColumn {
    pub line: usize,
    pub column: usize,
}

struct Span {
  pub start: LineColumn,
  pub end: LineColumn,
}

struct TokenOccurence {
  pub token: Token,
  pub span: Span
}

struct Query {
  pub span: Span,
  pub ctes: Vec<Cte>,
 ...
}

The main objection I can think of is that it some bulk to Tokens, and to each AST node. This could be alleviated, if desired, by hiding them behind a feature flag. I looked at syn to see how they do it; the approach there is very similar. Afict, their feature flagging doesn't actually affect the node representation / token representation. They just carry it all the time.
Since the implementation here doesn't appear to be hyper-optimized, and since it's good enough for syn, it seems like this approach should be okay.
If I submitted a PR along these lines, would you consider accepting it?
Related work:

[ ] https://github.com/sqlparser-rs/sqlparser-rs/issues/757
[ ] https://github.com/sqlparser-rs/sqlparser-rs/pull/839

If I submitted a PR along these lines, would you consider accepting it?

I hope @andygrove and @benesch would comment.
As I'm also interested in analysis, I'd love something like this implemented.
Do you think this can be implemented without adding too much boilerplate? (In the tests, in particular, they're rather verbose as it is.)
A tangentially related issue I've been mulling over is the "AST" types we have now and how can they support dialects. For a while now I wanted to experiment with adopting the rust-analyzer's design of having a separate untyped/homogenous syntax tree (similar to your Spans, but with additional "type tag" and some structure), and a (generated) strongly typed API for accessing it. The first layer solves the problem you brought up, and the expected results can be more compact than ours.

Do you think this can be implemented without adding too much boilerplate? (In the tests, in particular, they're rather verbose as it is.)
I don't think it'll be to bad. I've hacked on this a little, and the initial approach I took was to exclude span fields from equality / hash computation, as they pretty clearly count as 'metadata' and not the data itself. But I haven't gotten as far as updating the test cases yet.

A tangentially related issue I've been mulling over is the "AST" types we have now and how can they support dialects. For a while now I wanted to experiment with adopting the rust-analyzer's design of having a separate untyped/homogenous syntax tree (similar to your Spans, but with additional "type tag" and some structure), and a (generated) strongly typed API for accessing it. The first layer solves the problem you brought up, and the expected results can be more compact than ours.

Their design goal of 'Syntax trees are lossless, or full fidelity. All comments and whitespace are preserved.' is what I actually want in the end. With Span information, on both the token stream and the AST, I should be able to reverse out comment / ast node associations. But having an intermediate homogeneous tree (CST?) would be a much better option.

I've pushed up a 'span' branch on my fork that implements a small slice of this, to serve as discussion fodder: https://github.com/mullr/sqlparser-rs/commits/span
Adding Spans to the tokenizer out put was very easy. Getting them into the guts of the parser was a bit more, but straightforward. I added it to a single AST node (Ident), and I think I arrived at a pattern that isn't too disruptive, especially to the tests.

Sorry, I probably won't have time to look at this until the weekend, but I will review this.

The tests aren't affected, because of the #[derivative(PartialEq = "ignore")] on the new span member of Ident, right? Nice!
A few quick thoughts:

The changes introducing TokenOccurrence to the parser turn out to be more involved than I expected, in particular having to match on TokenOccurrence { token: Token::Word(ref k), .. } is unfortunate, but I don't have any ideas on how to improve it off-hand.
I now wonder what is the rule to determine if a span must be stored for a given bit of the AST. Take pub order_by: Vec<OrderByExpr> in Query. Would it be enough for the spans to be added only to existing nodes (Query and OrderByExpr)? What about pub rows: OffsetRows in Offset? pub asc: Option<bool> in OrderByExpr?
It seems that passing the spans explicitly throughout the parser would be the biggest pain, not the tests.

The changes introducing TokenOccurrence to the parser turn out to be more involved than I expected, in particular having to match on TokenOccurrence { token: Token::Word(ref k), .. } is unfortunate, but I don't have any ideas on how to improve it off-hand.

Yeah, it felt pretty bad writing that, but I don't have a better idea either.

I now wonder what is the rule to determine if a span must be stored for a given bit of the AST. Take pub order_by: Vec in Query. Would it be enough for the spans to be added only to existing nodes (Query and OrderByExpr)? What about pub rows: OffsetRows in Offset? pub asc: Option in OrderByExpr?

It's a tricky question, especially because the AST here is especially abstract. I would probably put it in places where there's already a struct that clearly corresponds to a piece of syntax, but wouldn't create new pieces of structure just to staple a Span on to.
In your examples: OrderByExpr, yes. Query, yes. Query.offset: yes, but because it's an Expr, and that would get a span. asc field of OrderByExpr: No.
A truly convincing answer to the question would probably require an intermediate representation, as discussed above.

It seems that passing the spans explicitly throughout the parser would be the biggest pain, not the tests.

Yep, that's likely where the bulk of the work is. "A pain" is a good way to describe it, as it should be fairly rote.

One thing to note: only leaf AST nodes actually require the span to be attached to them as a field. Intermediate nodes can have an implementation if the Spanned trait which computes their span based on their children.

Intermediate nodes can have an implementation if the Spanned trait which computes their span based on their children.

I think that would only work for the rowan-like design, where concatenating the leaf nodes' text returns the original source. Coming back to the OrderByExpr example, it represents the ORDER BY <expr> ASC/DESC string in the source, but the only "leaf" node under it is Expr. So it seems like it needs a span too, and that logic applies to pretty much every node, no?

I think that would only work for the rowan-like design, where concatenating the leaf nodes' text returns the original source. Coming back to the OrderByExpr example, it represents the ORDER BY  ASC/DESC string in the source, but the only "leaf" node under it is Expr. So it seems like it needs a span too, and that logic applies to pretty much every node, no?

You're absolutely right, I hadn't thought of it that way.

Some way of accessing spans would also enable better error reporting in e.g. LocustDB since it makes it possible to point to specific spans within the original query string.

I wanted to propose an approach that may be verbose but could help at least in testing and in deriving a way to output SQL from AST per #18 (which I think would require spans to tokens implement).  My goal is to read how each portion of SQL is parsed and eventually rewritten, and to choose how any comments are maintained or removed during the rewrite. I'd like to be able to visualize them in a git diff like view comparing the old to new, just stored within the AST somehow, and giving me the opportunity to omit unnecessary extra comments if needed.

Keep the entire line to be parsed as input (comment included) and, repeat it only when moving to the next statement in the AST, flag as retain-original-sql
Optionally keep the line or line(s) before and after the line being parsed as input, flag as retain-prior-lines and retain-next-lines
Specify whether retain only the comment portion of those lines, flag as retain-comments-only or retain-all
When writing back out the SQL, include the line that was parsed as input directly above the statement a newly written version would have, just commented out
If the lines being parsed contains a trailing comment, give it four dashes ---- instead of two -- to help distinguish what was a historical comment, same approach similar to /*/* instead of /*/* for multi-line comments, two fags retain-flag-prefix-single='--' retain-flag-prefix-multi='/*'` allowing users to specify their own method of distinguishing old comments from ones they may add manually when they open the generated script
A list of strings or regex patterns to find in comments that you wish to omit in the output retain-no-output=['completed issue num','commenter id char']

@alamb I saw you stepped up as a maintainer of the library and that you showed interest in getting https://github.com/sqlparser-rs/sqlparser-rs/pull/189 restarted. I'm not sure I'll have time to resurrect that PR, but just in case: is this issue still relevant to the project? And has anyone else worked on it since that PR?

Thanks @aochagavia  -- The issue is definitely still relevant. It is an often requested feature
It came up recently here, in fact: https://github.com/sqlparser-rs/sqlparser-rs/pull/839#issuecomment-1996879328

I started collecting related work / tickets in the description of this ticket so we can track it more easily

I'm also interested in being able to provide better/pretty errors like with https://lib.rs/crates/ariadne or https://github.com/zkat/miette.
Adding text spans to:
pub struct Location {
    /// Line number, starting from 1
    pub line: u64,
    /// Line column, starting from 1
    pub column: u64,

   pub start:u64,
   pub end:u64,
}

Is probably a first step.

We are trying to provide better error messages at least, so I forked and added:
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum ParserError {
    TokenizerError(String),
    ParserError(String),
    ParserErrorWithToken {
        msg: String,
        token: TokenWithLocation,
    },
    RecursionLimitExceeded,
}

Then I override the major parser methods and now I could do something like:
Error: SQL parser error: unsupported binary operator LIKE
   ╭─[SQL:1:1]
   │
 1 │ SELECT * WHERE a LIKE 1
   │                  ──┬─
   │                    ╰─── Error here
───╯

I think if the pr is split into 2 steps will make things simpler:

Things that allow to pretty print errors
Things that allow to build sophisticated analysis

Hi! I am looking to pick this up and I can see that there is at least 2 PRs with an attempt at implementing this #839 and #790 and @mamcx fork. Is there any opinions on which approach is most likely to make it in and which would make most sense as a starting point?

Is there any opinions on which approach is most likely to make it in and which would make most sense as a starting point?

Thank you @Nyrox  -- we certainly need a hero to make this happen
The key in my mind is to find a way to incrementally introduce this feature over a few releases so downstream users have time to integrate / update the changes and we minimize disruption

@alamb would you be open to collaborate on how we should approach this if we take on the dev task and workload (@Nyrox and team)? We just want to ensure changes can and will be upstreamed

The key in my mind is to find a way to incrementally introduce this feature over a few releases so downstream users have time to integrate / update the changes and we minimize disruption

I think this is a good idea. I have implemented in my fork source locations for a good subset of AST nodes in a way which minimally breaks downstream (essentially by avoiding the WithSpan<T> approach of the other PRs and only adding fields instead). This does not yield perfect results, i.e. for a lot of constructs the span will be slightly wrong due to missing information, but this way it can be refined in later PRs.
@alamb should I open a draft PR where we can discuss details?


Project WinRT enum Microsoft.UI.Xaml.Interop.NotifyCollectionChangedAction to System.Collections.Specialized.NotifyCollectionChangedAction

In WinUI Preview 3, we plan to introduce a new enum, Microsoft.UI.Xaml.Interop.NotifyCollectionChangedAction, to replace our existing usage of Windows.UI.Xaml.Interop.NotifyCollectionChangedAction.  Their definitions are identical outside of the namepace:
namespace Microsoft.UI.Xaml.Interop
{
    public enum NotifyCollectionChangedAction
    {
        Add = 0,
        Remove = 1,
        Replace = 2,
        Move = 3,
        Reset = 4,
    }
}

We would like to have projection support for this new type in lieu of the old Windows.UI.Xaml type, so that Microsoft.UI.Xaml.Interop.NotifyCollectionChangedAction projects to System.Collections.Specialized.NotifyCollectionChangedAction.
The Microsoft.UI.Xaml.Interop.NotifyCollectionChangedEventArgs.Action property would also have its type updated from Windows.UI.Xaml.Interop.NotifyCollectionChangedAction to Microsoft.UI.Xaml.Interop.NotifyCollectionChangedAction, so its projection to System.Collections.Specialized.NotifyCollectionChangedEventArgs may need to be updated as well.

(@Scottj1s - this is what we had talked about today)

@RealTommyKlein we already provide this projection (search code for NotifyCollectionChangedAction). Is it not working correctly?

@Scottj1s - thanks for the response!  Turns out there are some other unrelated issues which are preventing us from validating it works correctly.  Once those are resolved, I will test the existing projection support.

closing this issue as there's nothing actionable atm - please open a new issue if necessary (i.e., if there's a bug in the NotifyCollectionChangedAction projection)


Refactored rtable CIDR/static implementation.

Changes are backward compatible, except for load/save format for "static" routes (no longer binary -> and thereby decoupled from the actual code).

common code moved to src/rtable/csp_rtable.c
use same format for storing table (text) - no binary format for static (no pointers saved).
added csp_rtable_route_t holds route entry.
support for simple format without mask, e.g. "20 CAN" (instead of 20/5 CAN)

csp_rtable_route_t will be used in optimizing route look up, to avoid double lookup when using MAC (via) address.

I can see the diff seems big, perhaps I can move some code around to make it smaller.
Let me know, if that is prefered.

What this does, is really adopting the CIDR notation for both static and CIDR cases. So now the difference is just wether it's stores in a linked list or written out into a full static routing table. I like it.


Changed groupId and artifactId. Fixes #3 (master)

@m0mus do implementation projects also need to change their artifactId? e.g. com.sun.activation:javax.activation to com.sun.activation:jakarta.activation

No

Closing as it was it was implemented already.


[BUG]: Next 15 not supported

Describe the bug
When I try to install alongside next 15 an error is raised including
npm error Conflicting peer dependency<EMAIL_ADDRESS>npm error node_modules/next
npm error   peer<EMAIL_ADDRESS>|| ^10.2.1 || ^11.1.0 || ^12.1.0 || ^13.0.0 || ^14.0.0" from<EMAIL_ADDRESS>npm error   node_modules/next-safe
npm error<EMAIL_ADDRESS>from the root project

Steps To Reproduce

Create new Next.js app
Setup next-safe:npm add next-safe

Start app
See error

Version
v3.x.x
Relevant log output
❯ npm add next-safe
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving<EMAIL_ADDRESS>npm error Found<EMAIL_ADDRESS>npm error node_modules/next
npm error<EMAIL_ADDRESS>from the root project
npm error
npm error Could not resolve dependency:
npm error peer<EMAIL_ADDRESS>|| ^10.2.1 || ^11.1.0 || ^12.1.0 || ^13.0.0 || ^14.0.0" from<EMAIL_ADDRESS>npm error node_modules/next-safe
npm error   next-safe@"*" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This would be great, especially if this project is still maintained

The issue is that React 15 relies on React 19, which uses a new (and very different) reconciler.
This comment provides more context on my plans for the library.

We ended up building a new library because this one seems unmaintained: https://blog.arcjet.com/nosecone-a-library-for-setting-security-headers-in-next-js-sveltekit-node-js-bun-and-deno/


Low walls not being treated as stairs

The logic for handling small stairs seems to be something that is missing from _handle_collision().
The controller seems to be getting stuck and treating even the tiniest stair like a wall.
https://github.com/ratmarrow/GoldGdt/assets/50188474/477ec993-f603-4ee5-b277-0a4a0faffda3

Currently the character doesn't have stair detection yet. Once I wrap up what I am doing, I will get right on it.

Closing this, since it got fixed by @ratmarrow !


customMapStyle

Hi. I need add custom style for map. I add options
_options: IMapOptions = {
disableBirdseye: false,
disableStreetside: false,
navigationBarMode: 1,
zoom: 6,
customMapStyle = {
"elements": {
"water": { "fillColor": "#a1e0ff" },
"waterPoint": { "iconColor": "#a1e0ff" },
"transportation": { "strokeColor": "#aa6de0" },
"road": { "fillColor": "#b892db" },
"railway": { "strokeColor": "#a495b2" },
"structure": { "fillColor": "#ffffff" },
"runway": { "fillColor": "#ff7fed" },
"area": { "fillColor": "#f39ebd" },
"political": { "borderStrokeColor": "#fe6850", "borderOutlineColor": "#55ffff" },
"point": { "iconColor": "#ffffff", "fillColor": "#FF6FA0", "strokeColor": "#DB4680" },
"transit": { "fillColor": "#AA6DE0" }
},
"version": "1.0"
};
};
but get error in console " 'customMapStyle' does not exist in type 'IMapOption' ".

Hi, currently, the customMapStyle is not supported by angular-maps. However, you can easily add it. Simply fork, adjust the create a new interface ICustomMapStyle with the various attributes, add an customMapStyle property to the Imap-options. In addition, you will need to update BingConversions to include 'customMapsStyle' in hte _mapOptionsAttributes array.
After you've done that, test it in your local branch and then submit a pull request and I'll incorporate it...
If you feel up to it, you can also provide a Google Maps implementation by creating a transformation into the appropriate Google options in GoogleConversions.


Making logging level an env var.

Changed the env var that controls logging to pass in the explicit level that is desired, defaulted to DEBUG for the bot.yml file.  Also changed the formatting of the logging to print the level and the date.
How to Test
Run it locally and change the LOG_LEVEL from DEBUG to INFO to see different levels of logging.
export SLACK_TOKEN=xoxb-18316206129-DnZvMWcZPc53nx0NS5Y7S8S5
export LOG_LEVEL=DEBUG; python rtmbot.py

Works like a snake charmer. :+1:


Introduce a WindowWrapper to extend the lifetime of the window when using pipelined rendering

Objective
A RawWindowHandle is only valid as long as the window it was retrieved from is alive. Extend the lifetime of the window, so that the RawWindowHandle doesn't outlive it, and bevy doesn't crash when closing a window a pipelined renderer is drawing to.

Fix #11236
Fix #11150
Fix #11734
Alternative to / Closes #12524

Solution
Introduce a WindowWrapper that takes ownership of the window. Require it to be used when constructing a RawHandleWrapper. This forces windowing backends to store their window in this wrapper.
The WindowWrapper is implemented by storing the window in an Arc<dyn Any + Send + Sync>.
We use dynamic dispatch here because we later want the RawHandleWrapper to be able dynamically hold a reference to any windowing backend's window.
But alas, the WindowWrapper itself is still practically invisible to windowing backends, because it implements Deref to the underlying window, by storing its type in a PhantomData.

Changelog
Added

Added WindowWrapper, which windowing backends are now required to use to store their underlying window.

Fixed

Fixed a safety problem which caused crashes when closing bevy windows when using pipelined rendering.

Migration Guide

Windowing backends now need to store their window in the new WindowWrapper.

That Android CI failure is an oversight of mine. I've fixed it, so that it now compiles and runs successfully on my phone.


Update Project.toml

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on lpawela-patch-1 at 87.571%

Totals

Change from base Build<PHONE_NUMBER>:
87.6%

Covered Lines:
155

Relevant Lines:
177

💛  - Coveralls


can't build with swift4.1

install with the lib using pod . The version is 1.0. And can't build with newest swift version( swift 4.1).
Using TextAttributes (1.0)

Same issue happens. Please update it to swift 4.1

I have submitted a PR https://github.com/delba/TextAttributes/pull/28 that adds Swift 4 support.  It has migrated all the source code and all project targets (iOS, MacOS, watch and tvOS) to Swift 4.
@delba : Could add the label hacktoberfest to this issue so that this would qualify for the Hacktoberfest contest and give some credits?

+1 to merge this one soon

Hi @qiushuitian, the lib has been updated to the latest Swift version.


Add Option to Log SSL Session Keys for Wireshark Compatibility

Currently, we can inspect SSL traffic to the proxy by instructing it to use ciphers without perfect forward secrecy only. As far as I know, inspecting the upstream connection is hard possibly without manual intervention. To debug issues like https://github.com/mitmproxy/mitmproxy/issues/472, it would be nice to have a command line option to dump the SSL keys for Wireshark.
There are two complications:

We should log keys if renegotation during the session occurs (see https://github.com/mitmproxy/mitmproxy/issues/472), not just after the handshake. I hope we can use the pyOpenSSL equivalent of SSL_CTX_set_info_callback for this?
Writing to a file from different connection threads requires synchronization.

The following works for single-threaded code:
def dump_creds(sock):
    crand = sock.client_random().encode("hex")
    masterkey = sock.master_key().encode("hex")
    with open("keys","ab") as f:
        f.write("CLIENT_RANDOM {} {}\r\n".format(crand, masterkey))

We should probably use the SSLKEYLOGFILE environment variable as well. :-)

Done! We can now set either MITPROXY_SSLKEYLOGFILE or SSLKEYLOGFILE.


[BUG] Can no longer run transform jobs that contain a script within an aggregation

What is the bug?
I currently have a transform job that I run periodically that used to run just fine on v2.7. Since upgrading to v2.11, the transform now fails with an error I have never seen before. I’ve had no issues running the transform aggregation without a proper field and only a script prior. If I add a bogus field to the aggregation, it runs just fine, but obviously without aggregating on the return value of the script. The aggregation still runs just fine outside of a transform in a normal search query.
How can one reproduce the bug?
See here for configuration and current output error.
What is the expected behavior?
Expect the transform job to run using the return value of the script as the field to aggregate on.
What is your host/environment?

Version v 2.11.0

Looks like a possible regression, were you able to narrow this down further @Bit-64 ?
Catch All Triage - 1 2 3 4 5


Serve Client statically

Client should be built into the target static folder, not the source one.

Its done brent


GH-30863: [JS] Use a singleton StructRow proxy handler

Rationale for this change
Fixes #30863 by using a singleton proxy handler in StructRow's constructor. Since the handler is stateless, there is no need to create a new instance for each row.
What changes are included in this PR?
Refactoring StructRow's constructor to extract the proxy handler.
Are these changes tested?
No additional tests since this is an internal refactoring, but yarn test runs successfully.
Are there any user-facing changes?
No.

GitHub Issue: #30863

I am not sure if:

https://github.com/apache/arrow/issues/44294

Is related but the failures seem to be around JS integration and this is the only commit that has been introduced lately (the commit doesn't seem like has anything to do with the failures to be honest but worth pointing out)

All the ci checks passed in this pull request so shouldn't this indicate that this change is not the culprit and since it's the last change from js that the issue is somewhere else?

Arrow's CI is quite extended and, for example, integration tests are not run on normal CI but as nightly jobs so sometimes things are merged and they break on the nightlies. It's not ideal but a compromise as resources for GH are limited and we struggled in the past with extreme queues.
This job has started failing in the last nightlies. I do not think this PR is the culprit but the integration jobs fail on Ubuntu and in general always around JS (either producing or consuming)

I see. Thanks for the additional context. I don't have cycles to debug the ci right now and we didn't make any changes to js recently besides this change.


CANT LOAD LOCAL FILES TO PLAY

Im stuck with this for almost a week, tried with file:///storage/emulated/0/Download/music/music.mp3 and file:///storage/emulated/0/Download/music/music.mp3  in the emulator and it doesnt work, heres the code:
  componentDidMount() {
        this.init_player();
    }

    init_player = async () => {

        let track = [{
            id: "1",
            url: "file:///storage/emulated/0/Download/music/Yummy.mp3",
            title: "Yummy",
            artist: "Justin Bieber"
        }]

        await TrackPlayer.setupPlayer();
        await TrackPlayer.add(track);
        await TrackPlayer.play();
}

Im stuck with this for almost a week, tried with file:///storage/emulated/0/Download/music/music.mp3 and file:///storage/emulated/0/Download/music/music.mp3 in the emulator and it doesnt work, heres the code:
  componentDidMount() {
        this.init_player();
    }

    init_player = async () => {

        let track = [{
            id: "1",
            url: "file:///storage/emulated/0/Download/music/Yummy.mp3",
            title: "Yummy",
            artist: "Justin Bieber"
        }]

        await TrackPlayer.setupPlayer();
        await TrackPlayer.add(track);
        await TrackPlayer.play();
}

resolve, if you are using this in Android X you need to add in AndroidManifest.xml in  android:requestLegacyExternalStorage="true"

hi @ShumGG  you can load local file IOS


Code reformatting adds white spaces in special construction

With special construction ({if} condition with inner html inside span tag) code reformat (CDM+ALT+L) adds white spaces around "{else}" statement:

	{if true}
		TRUE
	{else}
		FALSE
	{/if}

This issue occured on PhpStorm 8, 9 and 10.

Not sure I understand, but I think, it is fixed in 0.2

Hey @matej21, many thanks for new plugin version! But for me this bug was not fixed.
Try this steps:

Make new blank latte file
Copy & paste my short code snippet from https://github.com/JanTvrdik/intellij-latte/issues/14#issue-132632357
Hit "Code -> Reformat Code" from PhpStorm main menu (on OSX it is on ALT+CMD+L key shortcut)

When I do code reformat on code from step 2. (https://github.com/JanTvrdik/intellij-latte/issues/14#issue-132632357)

	{if true}
		TRUE

				{else}

		FALSE
	{/if}

Do you see how "{else}" moves?

I am not able to reproduce it. which phpstorm version are you using? are you sure *.latte files are associated with a latte plugin (Settings/Editor/File types)?

For me reformatting of latte doesn't work at all. It formats only the html tags.

Could you please check Block structure using this Psi viewer https://www.jetbrains.com/phpstorm/help/viewing-psi-structure.html ?
It should look like this:

I don't know how to show the block structure. I can show you jsut the psi structure.

It is integrated psi viewer in idea/phpstorm, but you need to enable it. See the article from my previous comment.

But it is indented ok, isn't it? (content under if/else is intended). Or what did you mean by "reformatting of latte"?

@semisedlak you are using smarty, not latte.

	{if true}TRUE
	{else}
	FALSE
	{/if}

do nothing
`
	{if true}
	TRUE
	{else}
	FALSE
	{/if}

do

	{if true}
		TRUE
	{else}
	FALSE
	{/if}

@hrach it is caused by enabled option Editor/Code style/Html/Other/Keep white spaces. But I will try to fix it anyway

I have this option disabled.

@hrach oh, I was using stable PhpStorm 10.0. Now I switched to the newest EAP and it is really broken. Not sure if it is a bug or the behaviour was changed intentionally.

I'm using stable too :D

@matej21 yes, it was my bad. I had *.latte extension registered for Smarty (Preferences -> Editor -> File Types). Now my status is exactly the same as @hrach has written.

Oh, it is also affected by "Keep white spacces inside". If you remove "span" it should work. Not sure if I can bypass this..


Open quake mode terminal in current directory

Description of the new feature/enhancement
Currently, when the startingDirectory option is set to ".", a terminal in quake mode is still opened in the default directory. It would be a nice QoL feature to have this terminal window open in the current directory if the current foreground window is an explorer window.
I made a quick PoC:
Proposed technical implementation details (optional)
The implementation would be relatively simple:

Find the current foreground window
Get all open ShellWindows and find the foreground window as described here

If the current foreground window is not an explorer window, simply open the terminal window in the default starting directory.

Is this not the same request as #10202?

Yea this sounds like /dup #10202


Make sure lines are not joined together.

Description

Make sure lines are not joined together per guidance in https://github.com/opendatahub-io/ai-edge/issues/81#issuecomment-1724745570..
Fixes https://github.com/opendatahub-io/ai-edge/issues/81.
How Has This Been Tested?

I looked at https://github.com/adelton/opendatahub-ai-edge/tree/issue-81.
Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

Note: I still fail to understand if a full cluster registration (for example Import cluster per https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.8/html-single/clusters/index#importing-managed-cluster-console) is needed, or if the https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.8/html/applications/managing-applications takes a fine grained approach of only making some resources available across cluster boundaries (in which case the "Register the clusters" is wrong).

Thanks, @piotrpdev. What is the process in this repo? With this approval, should I just push to main (provided I have permissions :-) ) or will someone else do that?


Changed the setbackground command

To avoid spaghetti code and allow easy customizability without changing code i made it so the command would read from the shop.json file. This way adding backgrounds are going to be very easy (for the setbackground command at least)
Note: This change hasnt been fully tested yet.

Wouldn't work. Indexing at background[0] would just make it use the first item in the array and not from actual user input.


Add mode as a column in Analysis Grid

This change allows you to search explicitly for cromwell (or other modes) in the Analysis Grid UI.
Also fixes a bug where missing hail batch URLs caused errors

Codecov Report
Patch and project coverage have no change.

Comparison is base (85ea673) 69.05% compared to head (8cdf335) 69.05%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #496   +/-   ##
=======================================
  Coverage   69.05%   69.05%
=======================================
  Files          67       67
  Lines        6240     6240
=======================================
  Hits         4309     4309
  Misses       1931     1931

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


First row full of barbarians

Barbarians seem to have united to form the vanguard

😂😂fixed it in the morning, was getting 3 blank responses everytime from the database, thats why the barbarians😂


failOnError = false not working in Sync Service

Due to nested transactions, the Sync Service with failOnError = false is not working.
After the first Doctrine Exception, the next Transaction is always marked for rollback only.
So a commit for the next successful payload causes this Exception:
"Transaction commit failed because the transaction has been marked for rollback only."
When i remove the calls to beginTransaction(), rollBack() and  commit() from the sync function of the sync service
everything works fine.
The EntityWriteGateway calls the transactional function, where the closure is already executed in a transaction.
So no need for nested ones here...

Hi MrMDeluxe,
thank you for bring this up. This Issue is known and a fix is on its way.

That sounds good! Thanks.


CLS support missing

I would like to add cls-bluebird. I was thinking about passing an optional namespace like so:
myCache                = require('cluster-node-cache')(cluster,{},namespace);

Added in 08b071f621fa2bfaa8c84257f8722d9499fa31e4


MSID: 97085 Version: 2 DOI: 10.1101/2<IP_ADDRESS>8607

MSID: 97085
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>8607
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=97085
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>8607

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/97085v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>8607
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/97085/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Hi @KJT08 should this be moved across?

Hi @acollings sorry yes it should have been moved (I've moved it now), I'll go through the 18th/19th to make sure I've moved all of those just in case I've missed another one

Thanks @KJT08! I don't think there are others


npmScript command not properly called

the npmScript is supposed to let us use a custom script for the build (in my case, use the --debug flag). However, the action will call yarn <custom script name> build when it should just call yarn <custom script name>
I think it comes from https://github.com/tauri-apps/tauri-action/blob/aabd090c49c7ae9bfc3d7128b51ef6e2d4a2304d/packages/core/index.ts#L208

Of course in my case i should use includeDebug - but I think the issue stands


Align device names to the left so they remain visible with many screenshots

I am generating around 50 screenshots so the device name was off the screen.

Thanks :+1:


some tests are failing, as they cannot unzip the large file storage data

Example here: https://github.com/allfed/pytradeshifts/actions/runs/7708019080/job/21006268800


autoCompletionView Top Line Color

Hello @dzenbot I would like to know if it possible to change top line of autoCompletion view?

@dzenbot  But it is possible to change it ?

It's ok, I can modify the API.
_autoCompletionHairline.tintColor = [UIColor redColor];
did not helped
@dzenbot


Added Librewolf support

Librewolf is a fork of Firefox, so I went and added support for it. It's just some simple path changes and calling a different executable.

Thank you for the addition!


Fix for standardisation test error

Summary of changes
This fixes the test failure in test_standardise_obs_openghg that was being caused by the same file being processed previously. I've added a new function clear_test_store which I've used to clear the test store before this test is run so the file can be standardised properly. This function just clears the store that's specified instead of deleting all three test stores.

The issue number in the branch name is wrong sorry. This closes #935.

Please check if the PR fulfills these requirements

[x] Closes #935
[x] Tests added and passed if fixing a bug or adding a new feature
[x] All code checks passing - black --line-length 110 run over code, mypy and flake8 not showing any errors

Should we merged this into devel so this can go into 0.7.1 release and then can be merged into new_object_store?

Should this fix be merged into devel directly so this can go into 0.7.1 release and then can be merged from devel into new_object_store?

Running the tests again on devel and new_object_store this doesn't seem to be affecting devel - so merging this into new_object_store directly seems fine.


Crashes when marking a section and pressing tab. Happens inside a class definition.

Issue Report Checklist

[ ] Searched the issues page for similar reports
[ ] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[ ] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[ ] Tried basic troubleshooting (if a bug/error)

[ ] Restarted Spyder
[ ] Reset preferences with spyder --reset
[ ] Reinstalled the latest version of Anaconda
[ ] Tried the other applicable steps from the Troubleshooting Guide

[ ] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
What steps reproduce the problem?

What is the expected output? What do you see instead?
Paste Traceback/Error Below (if applicable)

PASTE TRACEBACK HERE

Versions

Spyder version:
Python version:
Qt version:
PyQt version:
Operating System name/version:

Dependencies

PASTE DEPENDENCIES HERE

Hi @JonathanBlixt, thanks for reporting this issue. However, the information that you provide is not enough to reproduce your issue, please provide the information required on the issue report checklist, as well a set of steps or a GIF to reproduce this case

I'm closing this one, due to a lack of response during the last seven days


v6 chatbot - Go through and tokenize/adopt styles from Kayla's Figma

We want to use tokenized CSS values from https://www.figma.com/design/MSr6kVEOuAxmPOkjg7x8PO/branch/gJNtCzWwiLzJZ2iAwSg6GF/P[…]-%26-Extensions?m=auto&node-id=3280-27257&t=s9hbJsqAncEwNICc-1 where possible.

We'll address other things that come up with individual tickets.


Adapt Font color depending on new API info

The font color is now set in the Orga server depending on the background color either black or white.
Please re-use the same color as in the schedule of the server. Follow up with the orga team about the API implementation and use color defined.

@mariobehling I'm working on this.

@geekyd I have already started working on this. Discussed it in the chat. :smile:

Okay go ahead :smile:


including orchestratorVersion and provisioning state for agent pool

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[x] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[x] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-go

Automation for azure-sdk-for-js

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-python

Including @ravbhatnagar for ARM review of new API version.

Automation for azure-sdk-for-java

@xizhamsft  Kindly take care of the merge conflicts.

@xizhamsft Kindly take care of the merge conflicts in the branch

@praries880, all comments resolved. Ready to merge. Thanks.


Broken link

Link to article:
https://docs.microsoft.com/en-us/windows/desktop/api/_automat/
Problem:
The link under "For programming guidance for this technology" is https://docs.microsoft.com/en-us/windows/desktop/api/_automat/ and does not work.

@GrantMeStrength Can you please take a look at this issue?

Very old topic - did the best I could to avoid confusion with other automation tech.

Hey @GrantMeStrength, there were no changes made on the help page and the link remains broken. Please fix. PS: what do you mean 'very old topic'? COM automation is still an active product.


[3pt]  - Add all items counter on the Homepage - Student A

Even if the API gives you the number of items, you will create a specific function to calculate it.
Make sure that the correct number is displayed on the Homepgae.

https://github.com/mikemtzp/PokemonAPI/pull/27


"Store Message" duplicates human messages, but only on API call (not Playground)

Bug Description
When I invoke a flow using "Store Messages" components, I am getting duplicate Human messages in the database, but only when I invoke via API call. The database messages are correct when I invoke from the Playground.
Reproduction
Reference flow https://raw.githubusercontent.com/AI-Phil/langflow-demo-flows/3b1afde4d590c5670e44417322dce580627353b1/flows/AstraMemoryChatbot.json
Note this flow has implemented fix for https://github.com/langflow-ai/langflow/pull/3024
when I invoke via Postman http://<IP_ADDRESS>:7861/api/v1/run/astra-memory-chatbot?stream=false
{"input_value": "what is my name?",
 "output_type": "chat",
 "input_type": "chat",
 "session_id": "1932f591-0a43-4546-8869-9f545503b5f3"
}

In both cases, there are two Langsmith entries: one for "OpenAI" and another for "Astra Memory Chatbot". I am not sure why there is not a single entry...
Versus when I invoke via the Playground, I have two different sorts of results.

On the API invocation, the Human message is double-entered into the "Store Message"
The order in Langsmith is different: on the Playground entry, the "OpenAI" is logged first, and the "Astra Memory Chatbot" is logged second.  On the API call, the order is reversed.

Expected behavior

There should be only one Human message in the database
There should be only one Langsmith entry for the invocation (maybe a separate issue?)

Who can help?
No response
Operating System
Windows 11
Langflow Version
1.0.13
Python Version
3.10
Screenshot
No response
Flow File
https://raw.githubusercontent.com/AI-Phil/langflow-demo-flows/3b1afde4d590c5670e44417322dce580627353b1/flows/AstraMemoryChatbot.json

Hey @mieslep for the duplicated messages, I sent out a fix in #3062
For Langsmith, the duplicate comes from the fact that Langchain tracing is also enabled and the ChatOpenAI component is sending his own tracing.
Since the same key LANGCHAIN_API_KEY is used both by langflow and langchain, they both think they need to trace.
To demonstrate that, you can remove the variable LANGCHAIN_PROJECT.
Default project for langflow is "Langflow", for langchain is "default". You will see the traces going in different projects.
This can't be avoided currently.
As follow up, I've created this issue for the wrong latencies #3064


add test for getJettonData getWalletData getMaxPunishment

This PR is for https://github.com/HipoFinance/contract/issues/3
My telegram ID: MK_dir98

I tried to fix them as much as I could. Please check it again and tell me if it has problem

Good job. Thanks.


chore: bump latest solc test

Motivation
bump test to latest solc and add new modelchecker field

Solution

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

#2414 :^)

ah forgot I looked at this...


Text wraping splits words separated by commas and points

VSCode Version: Code 1.18.1 (929bacba01ef658b873545e26034d1a8067445e9, 2017-11-16T18:34:22.110Z)
OS Version: Linux x64 4.9.0-4-amd64
Extensions:

Extension
Author (truncated)
Version

latex-workshop
Jam
3.8.0

spellright
ban
2.0.14

jupyter
don
1.1.4

python
ms-
0.8.0

unicode-latex
oij
1.1.0

pdf
tom
0.2.0

(1 theme extensions excluded)
I usually use vscode to write latex and I have text wraping en. There is a behaviour that I find very annoying.
If I have a text at of the line separated by a comma of a point, such as "these,words", vscode splits them as
"this,
words".
I would expect that it would keep them together and wrap them to the next line. Would it be possible to add the option to only split words if they are separated by an space?
Reproduces without extensions: Yes
PS: sorry for my English

Another example from #52178:
Currently:

Should be only like:

or


DTDL V3

Purpose
Update models to DTDL V3

Merging pull request in preparation to publish the ADT doc updates for DTDL v3


[Site feature] Twitter does not have copy description

Twitter does not have a copy description button because I could not figure out how to cleanly interact with the DOM.

Need to figure out how to select the current tweet.


 This is the expected behavior of the build system.

OPS Build status updates of commit 946e985:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Bug/change image on hover

This PR should eventually fix choosing different images of symbols depending on the state of the underlying feature.
I added a simple mapping struct ImageStoreInfo analogous to PrimitiveInfo to allow retaining indices of stored images and keep a consistent mapping between images in use and the corresponding image in store. Current main branch seems to have issues with mapping between the images in store and the images as used by symbols as images are removed from the store regardless of whether other symbols are still using them leading to indices into the image store being wrong (i.e. suddenly all marker render a different image instead of just one).
To demonstrate the bug and a use-case, I added an example showing highlighting of features (map pins) on mouse hover.
The implementation of the example currently iterates through all layer features and resets their state and afterwards only sets the state for those in proximity of mouse; this seems inefficient, but I did not know how to do it differently.
PR is still draft, as even with the fixes I applied to image store, hovering a pin sometimes completely removes another, or even toggles the wrong feature/image. If you have any suggestions on how to fix the issue, let me know.
You can see the original behavior on main by simply checking out both the example and the green-pin.png from this pr's branch and run the example normally (you should see all pins highlighted when hovering just one)

Ok, so I found the culprit with changes to image symbols and tried to fix it. As far as I understand the code, on changes to features, the corresponding renderprimitives are being removed and in case of images their images (and potentially the used image texture) are also. However, images within TesselatingRenderBundle was just a simple array, and PrimitiveInfo just kept an index into this array. So when an image is removed, these indices were all off.
I added the same strategy as with the image textures images_store, with ImageInfo which can either contain an image (with vertices and the index of the stored texture) or be vacant.
This fixes the problems with disappearing or wrongly changed images on hover (see the example). However, I still have to reuse vacant slots to avoid indefinitely growing list of images...

ok, vacant image slots are now reused.
Let me know if I should change the implementation, but I think this should work and not introduce a lot of overhead (I might be wrong though!)

Something like StableVec or something?..

good guess, I'd say, there is stable-vec which does what we currently implement manually, although the crate docs also refer to the more popular slab crate (by tokio-rs) which might be a more reasonable choice (although I haven't yet used any of them nor read the docs in-depth).
So I would lean towards using slab (haven't checked the deps of it yet).

also, do you think this pr should already introduce the external crate, or should that be an additional PR? in case of the latter I'd first fix the parts you commented on, to get this merged.


Circle CI/CD broken

Push local image to AWS ECR, the task run success. However, the image deployed on AWS by CircleCI was broken.

Fixed CI/CD deployments to staging. Currently unable to resolve issue with CI/CD to production. Will reschedule to work on that at a later time.

Resolved.


Pick "enhance Print the oss request id for each error s3 request #32499"

Proposed changes
Issue Number: close #xxx
same as master #32499

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Optimize view paths for module views in theme folder

Currently views from modules can be overridden in resources/views/layouts//resources/views/modules/
This override removes the duplicated "resources/views" part.
in igaster/laravel-theme a PR has been created but is not yet merged. This is considered a workaround until PR is merged into laravel-theme package

Nice job


Merge backends

The indexing and public backend app become more dependend the further we get into real editing. To avoid complexity merge both backends into one. If we need to keep 2 separate JVMs we can still run 2 instances and expose only parts if needed

See also https://github.com/Sp2000/colplus-backend/issues/228


Process builder that returns error code should fail plugins and return proper value

Now we simply do not create test result in case process builde (pb) failed to execute the command

Actually, we have completely forgot, that usually when a static analyzer discovers issues with code, it returns non-zero code. And now we act as if the process crashed. We should change this logic.


Converting project from 3.x to 4.x using OpenGL 3 doesn’t seem to work

Godot version
4.0rc6
System information
Windows 10
Issue description
When I tried to convert my project to godot 4 it said I couldn’t because the pc doesn’t support vulkan. So then I opened it using the command it says to use and the project crashed with a “memory” error. I may be doing something wrong but there doesn’t seem to be any information about how to convert a project but use OpenGL
Steps to reproduce
When using the command the error gives. I noticed that it was trying to open my project in vulkan or forward+ even after running the command. I suppose it is hard to get this issue if you don’t have a pc that doesn’t support vulkan.
Minimal reproduction project
I cannot provide a example project at the moment sorry.

The project converter does not specify the output renderer, which means it defaults to forward_plus (Vulkan). There's currently no way to make a project use OpenGL without opening it first.
In the meantime, edit project.godot to add the following at the end of the file while the editor is closed:
[rendering]

renderer/rendering_method="gl_compatibility"


Add keep flag

Purpose of the PR

Add --keep flag

Fixes https://github.com/Azure/acr-cli/issues/69

Hi
@Wwwsylvia
I've just raised a support ticket<PHONE_NUMBER>00556
Which covers a bug in the API I've encountered with this.
Some images are not respecting pagination, and just return the same page, this only occurs when sortby and last are set.
This is causing an infinite loop on those images, I can put a hack in which passes in the previous last tag and if its the same as the new last tag then exit the loop.
But just wanted feedback first on what the correct approach is.
All details are in the ticket, including the registry it's occurring on and working and non working images
Thanks

Hi
@Wwwsylvia
I've just raised a support ticket<PHONE_NUMBER>00556
Which covers a bug in the API I've encountered with this.
Some images are not respecting pagination, and just return the same page, this only occurs when sortby and last are set.
This is causing an infinite loop on those images, I can put a hack in which passes in the previous last tag and if its the same as the new last tag then exit the loop.
But just wanted feedback first on what the correct approach is.
All details are in the ticket, including the registry it's occurring on and working and non working images
Thanks

Hi @timja, thanks for the PR and the bug report, we will check it and get back to you.

Hi @timja, not sure how you set the last parameter, did you grab the url from the returned Link header?
For example, in below case, the last tag of the first page is 12.04.
To get the next page, we should query /acr/v1/library/ubuntu/_tags?last=8586163895140836946%2612.04&n=3&orderby=timedesc, which is encoded in the Link header. (Notice that the last parameter here is<PHONE_NUMBER>140836946%2612.04, not 12.04.)
$ curl -s -u ***:*** 'https://myregistry.azurecr.io/acr/v1/library/ubuntu/_tags?orderby=timedesc&last=&n=3' -v | jq .
...
< Link: </acr/v1/library/ubuntu/_tags?last=8586163895140836946%2612.04&n=3&orderby=timedesc>; rel="next"
...
<
{ [1030 bytes data]
* Connection #0 to host myregistry.azurecr.io left intact
{
  "registry": "myregistry.azurecr.io",
  "imageName": "library/ubuntu",
  "tags": [
    {
      "name": "14.04.1",
      "digest": "sha256:2eb231f768446001a7cf9024ec9724cec23f6768e9ccb4e61499718d34621fbe",
      "createdTime": "2020-03-26T10:09:34.7419234Z",
      "lastUpdateTime": "2020-03-26T10:09:34.7419234Z",
      "signed": false,
      "changeableAttributes": {
        "deleteEnabled": true,
        "writeEnabled": true,
        "readEnabled": true,
        "listEnabled": true
      }
    },
    {
      "name": "xenial-20160217.2",
      "digest": "sha256:c1e33b4b41531cbfc2b6d7c591c9cb228eb6b4cf265b07d9fd1a4b4a0e3d0623",
      "createdTime": "2020-03-26T10:09:32.1301199Z",
      "lastUpdateTime": "2020-03-26T10:09:32.1301199Z",
      "signed": false,
      "changeableAttributes": {
        "deleteEnabled": true,
        "writeEnabled": true,
        "readEnabled": true,
        "listEnabled": true
      }
    },
    {
      "name": "12.04",
      "digest": "sha256:18305429afa14ea462f810146ba44d4363ae76e4c8dfc38288cf73aa07485005",
      "createdTime": "2020-03-26T10:09:31.3938861Z",
      "lastUpdateTime": "2020-03-26T10:09:31.3938861Z",
      "signed": false,
      "changeableAttributes": {
        "deleteEnabled": true,
        "writeEnabled": true,
        "readEnabled": true,
        "listEnabled": true
      }
    }
  ]
}

You may refer to the sample script in our doc: https://github.com/Azure/acr/blob/master/docs/AAD-OAuth.md#pagination-1

@Wwwsylvia
I'm reusing the existing code:
https://github.com/Azure/acr-cli/blob/e45d021fab521318c2cdd67f59e082667de63414/cmd/acr/purge.go#L278
Let me take a look at the Link header
thanks

@Wwwsylvia that seems to work, but will need some refactoring here to use pagination correctly. As the code here is just figuring out the last value itself rather than respecting the last parameter

@Wwwsylvia
I'm reusing the existing code:
https://github.com/Azure/acr-cli/blob/e45d021fab521318c2cdd67f59e082667de63414/cmd/acr/purge.go#L278
Let me take a look at the Link header
thanks

Okay... this is interesting...
Per the Docker v2 spec,

Compliant client implementations should always use the Link header value when proceeding through results linearly.

So yeah we need to refactor the code.
BTW would you close the support ticket<PHONE_NUMBER>00556 if no further questions there?

@Wwwsylvia Is this something that is planned in the short term? As it blocks this being merged I assumed, otherwise we'll have to see if it's something we can do.
Thanks

@timja Yes let me fix the pagination part these days :)

Hi @timja, per our latest discussion the refactoring is not planned in a short term. :(
We may have to put this aside for a while, if you mind could you try to include the refactoring in a separate PR? Thanks!

Hi @timja , the refactor PR is merged. Could you double confirm if this PR has any conflicts?

Hi @timja , the refactor PR is merged. Could you double confirm if this PR has any conflicts?

@Wwwsylvia I have merged main after resolving conflicts.

@Wwwsylvia I have addressed all your comments. Please have a look.

@adusumillipraveen  Hi the code looks good, but I still have some concerns on the descriptions... Could you improve those? Thanks!

@adusumillipraveen Hi the code looks good, but I still have some concerns on the descriptions... Could you improve those? Thanks!

Done. hopefully you will find them better this time :)

Thanks!


Promisse then and reject

I am trying to use swal so I have the code:
 swal({         title: 'Success!',         text: 'test',         type: 'success',     })    .then(function() {console.log('test'); } });
My problem is if the user clicks outside swal the then part will not be executed, so I have to do:
 swal({         title: 'Success!',         text: 'test',         type: 'success',     })    .then(function() {console.log('test'); }, function() {console.log('test');}) });
So now I have duplicated code. I would have to create a function to be called in the success and dismiss event. Is there anyway to avoid that?

clicks outside !== confirm button click, so it can't be handled in one place.
Outside click is the dismissal, handling dismissals.

@limonte  This is not a confirmation tho, it's just a success message.

You can use finally polyfill for Promise, jsfiddle

Thanks!

You're welcome :)
Don't forget to include the finally polyfill to be able to use it: https://cdn.jsdelivr.net/promise.prototype.finally/1.0.1/finally.js


New emmet(HTML) does not work with pure number value

VSCode Version: 1.14.0
OS Version: macOS Sierra 10.12.5

Steps to Reproduce:
1.open a HTML file
2.type div[custom-attr=123] then press Tab
It does not work.
Text abbreviation like div{123} does not work either.

Reproduces without extensions: Yes

@easykid

Can you share the version of the Insiders build you are using?
Do you have emmet.useNewEmmet set to true or false ?

Using the Emmet: Expand Abbreviation command in the examples you have shown work as expected.
The suggestion list doesn't show the emmet expansion when emmet.useNewEmmet is set to true in you cases.
Can you confirm?

@ramya-rao-a
I have emmet.useNewEmmet set to true.
I'm not sure about the version of the Insiders, I just downloaded the latest stable version this morning.
Using Emmet: Expand Abbreviation command work as expected, but not with tab.

When the value is mixed with non-numeric characters, like div{1a} or div[attr=a1], tab works fine.

I am assuming when you say tab you mean the tabbing to choose the first item in the suggestion list.
This is happening because typing pure numbers doesn't trigger the completion provider
@jrieken I believe the reason is that ab12 is treated as a word but 12 isn't.
Can you confirm?

@jrieken I believe the reason is that ab12 is treated as a word but 12 isn't.
Can you confirm?

Ultimately it depends on the language specific word definition but in general "yes", numbers aren't considered words, IntelliSense needs to be invoked manually, e.g by pressing Ctrl+Space

Thanks @jrieken
@easykid @bestvow I am closing this as this is how the completion triggering works.
Workaround is to manually trigger the completion (Ctrl+Space)


Search finds resources in the disabled space

3.0.0-rc.3+9945dad64
7.0.0-rc.36
Steps:

create project space with folder "test"
disable space
try to find by "test"

Expected: search doesn't find folder "test"
Actual: search finds resource in the disabled space
https://github.com/owncloud/ocis/assets/84779829/6caa6287-292b-4ccf-be95-8d9b865f9827
https://github.com/owncloud/enterprise/issues/5705#issuecomment-1545298325

re-tested on RC4.


Adding AWS Guard Duty detection

Fixes #
Proposed Changes

@Ronmarsiano @Amitbergman  to make you aware this query had multiple issues.
They weren't flagged as all the checks were breaking.
I have fixed them in: https://github.com/Azure/Azure-Sentinel/pull/3471


NIFI-9482 Upgrade Log4j 2 from 2.15.0 to 2.16.0

Description of PR
NIFI-9482 Upgrades Log4j 2 transitive dependencies from 2.15.0 to 2.16.0 in order to leverage additional security measures, such as disabling JNDI lookups by default as described in LOG4J2-3208.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[X] Has your PR been rebased against the latest commit within the target branch (typically main)?

[X] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

building.  if good will merge shortly

Hey folks!  Thanks for the work getting this out promptly.
Using the Docker nifi image, is there a recommended way to pass environment to set log4j options?  For example, I would LIKE to do this but the start scripts don't pass it through:
docker run --env 'JAVA_OPTS=-Dlog4j2.formatMsgNoLookups=true' -it --rm docker.io/apache/nifi:1.13.2

Thanks!

Hey folks! Thanks for the work getting this out promptly.

Thanks for the feedback @mnp, but please do not comment on closed pull requests unless it relates directly to a problem with the associated code changes.  The Apache NiFi Slack channel or the users mailing list provide options for requesting help.


Broken links in README

The "Install Desktops" link in the configuration section points to a 404 : https://osc.github.io/ood-documentation/master/install-desktops.html

No problem!

On Sep 24, 2018, at 1:22 PM, MorganRodgers<EMAIL_ADDRESS>wrote:
Thanks for pointing that out @mancoast!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Functionality to embed component schemas inside other component schemas

A current hiccup in many workflows is when one component uses another. This is solved from the template side, as a hero component can use {% bookshop button bind=button %} in its template. This is not solved from the TOML side yet, and thus the following needs to be written:
# button.bookshop.toml
[props]
link = "/"
text = "Click"

# hero.bookshop.toml
[props]
title = "Hello World"
[props.button]
link = "/"
text = "Click"

This is an undesirable duplication of schema and will cause components to lose parity in a way that can't be caught automatically. Ideally we would write something like the following:
# button.bookshop.toml
[props]
link = "/"
text = "Click"

# hero.bookshop.toml
[props]
title = "Hello World"
button = "{button}" # <-- something that embeds the button component here

This would necessitate a change in architecture where the plugin that builds structures (cloudcannon-structures) has access to all TOML files, rather than processing them in isolation like it does currently.

Implemented!


New Email Templates

New designs of email templates implemented
Details can be found on https://confluence.catena-x.net/display/CORE/E-Mail+Templates

@fatihayyildiz @vsamarora  could you please review and merge this PR? In the afternoon we'll merge our default branch in the main branch from the catenax tractusx repo, no PR should be open at that point.


Your template is not updating as its missing the terms of service block

https://github.com/Usercentrics/gtm-templates-usercentrics-cmp/blob/2e4db7f3c34243878f3705b598b09cc6d8179f21/template.tpl#L1
Looking at the latest sync status i see that the terms of service section of the TPL file is not present.
https://tagmanager.google.com/gallery/#/template/Usercentrics/gtm-templates-usercentrics-cmp/status
For more info see the help center article. https://developers.google.com/tag-platform/tag-manager/templates/gallery#terms_of_service

Issue has been fixed within this commit. Please re-check.

Issue has been fixed.


Fix projects user display

Some users that are not displayed in the Users list were available for selection in the Projects dashboard. They were archived users and, obviously, should not find their way to those dropdowns.

Users who were no longer in the project and didn't show up (but still had the old membership) were included in the billable/nonbillable counter in the Project tab. They no longer are.

minor corrections found by the linter

JIRA: https://netguru.atlassian.net/browse/PEOPLE-35

LGTM :+1: :smile:


ConditionalIconItem changes in response to comments.

Changes
Made a couple of small changes in response to comments made after the ConditionalIconItem PR had merged.
Testing
Unit tests and interactive test app.

https://github.com/iTwin/appui/pull/376