Terminal doesn't close after FreeConsole()

Windows Terminal version
1.17.11461.0
Windows build number
10.0.19045.0
Other Software
ImHex 1.31.0
Steps to reproduce
Set Windows Terminal to be the standard console app
Start ImHex via explorer
Expected Behavior
As ImHex calls FreeConsole() right before launching the GUI executable, the console window should close.
This works with the "standard" console host.
Actual Behavior
The Console Window stays open.
Occasionally it minimizes.

I don't quite get what the purpose of the imhex.exe executable is when imhex-gui.exe also allocates a console. Now, whenever you launch imhex.exe from Explorer, it launches 2 console instances that are instantly closed. A better approach for this would be to:

Make imhex-gui.exe a /SUBSYSTEM:WINDOWS application
Launch imhex-gui.exe when imhex.exe runs, but then wait for the child process to exit
Pass an environment variable along, like _started_from_console
When it sees that env variable, imhex-gui.exe should call AttachConsole()

This is the same approach that mpv uses for its mpv.com wrapper:

https://github.com/mpv-player/mpv/blob/056072bf958ffeaadd2f5a69e37f3079f18d4ead/osdep/win32-console-wrapper.c#L86
https://github.com/mpv-player/mpv/blob/056072bf958ffeaadd2f5a69e37f3079f18d4ead/osdep/terminal-win.c#L398

Would you like to report this to ImHex?

The above aside, I'm unable to reproduce the issue. Does it still happen if you update to the latest Windows Terminal (1.18)?

Can I somehow force the app to update to 1.18? The Store won't distribute it to me. (However during dicussions with other users on the Discord someone metioned having the same Issue with WT 1.18)
I tested it with the 1.19 Preview Version and it behaves identically.

You can always grab the latest releases straight off our https://github.com/microsoft/terminal/releases page. Double-click installing the .msixbundle should update the current package you have (and leave it linked to the Store, for future updates)

Good to know Thanks!
WT 1.18.2822.0 behaves identical though

Maybe I'm doing something wrong... I'm setting Windows Terminal 1.18 as my default terminal and then launch either imhex.exe or imhex-gui.exe. Neither reproes the issue for me. I'm thus marking this issue as needs-repro.
@EXTREMEGABEL When testing this, please make sure to have tried it without any extra software running. That is, applications like ExplorerPatcher, PowerToys, Winaero, Discord, etc., all of them should be disabled or shut down (check Task Manager to be sure). Just because I don't use any of these on my work machine right now and one of them might indirectly cause issues, even if it's an issue on our side.

Sorry for reporting something that aparrently noone here seems to be able to reproduce :D
That being said:
I tried this on my Win 11 machine (22621.2428) since that has way less other stuff running on it installed WT 1.18.2822.0 and sure enough Terminal doesn't close.
Can I put WT into some sort of advanced logging mode or something?

A screen recording that shows the bug might help.

Thanks so much for doing this!
We had a look at the video and the code over in imhex, as well as grabbed a trace of process startup. Here's what's happening.

imhex is a console subsystem application
imhex closes its console handle (correctly), and the Terminal tab disappears
imhex calls CreateProcess on imhex-gui.exe
imhex-gui.exe is ALSO a console subsystem application
Because imhex destroyed its console handle before CreateProcess, imhex-gui is allocated a new console host.
The tab remains open, because imhex closed its console but did not prevent imhex-gui from spawning another console window.

This is why the repro video shows an ImHex tab that disappears before another one shows up.
C:\..\ImHex $ dumpbin /headers .\imhex-gui.exe | sls subsystem

            7.00 subsystem version
               3 subsystem (Windows CUI) <--- here

imhex-gui should not be a console subsystem application.
Also, for user ergonomics... the shortcut from Windows Explorer could point directly to the GUI version. Once the subsystem bit is fixed, this will remove the intermediate console completely.

(Also, I love ImHex! If you file a bug over on their end, would you mind linking it here?)

Out of curiosity:
Your description of what happens implies to me that in actuality the standard Windows Console host behaves "incorrectly".
I thought they were supposed to behave identically.

Hey, thanks for looking into this!
So what would be the best course of action for me? Is making imhex-gui.exe use the WINDOWS subsystem enough to fix the issue or is there more to it?
The reason all of this is necessary to begin with is because calling FreeConsole() in the main application causes crashes on older Windows versions because the console handles are closed improperly by it. That's why we moved that part to the forwarder and just attach to the real process's console.
Ultimately I need ImHex to work like a console application when launched from the console and like a regular gui application when run from the explorer

Your description of what happens implies to me that in actuality the standard Windows Console host behaves "incorrectly".
I thought they were supposed to behave identically.

I believe this difference is due to this fundamentally being a race condition. Windows Terminal makes it obvious, because it takes a lot longer to start and handle console API requests.

So what would be the best course of action for me? Is making imhex-gui.exe use the WINDOWS subsystem enough to fix the issue or is there more to it?

Yes, I think doing that would be best.

Ultimately I need ImHex to work like a console application when launched from the console and like a regular gui application when run from the explorer

This will be very difficult to achieve on Windows, because while a /SUBSYSTEM:WINDOWS application can attach itself to an existing console via AttachConsole, on Windows it behaves as if you wrote imhex-gui & to run it asynchronously. We're tracking that issue at #7335.
My recommendation would be to do it similar to how mpv does it: https://github.com/microsoft/terminal/issues/16174#issuecomment-1764409020
I believe that this approach is the best trade-off you can get right now on Windows, until we get to address #7335. If you'd like to deviate a bit from that, you could opt into calling AttachConsole inside imhex-gui.exe at all times, and not just when you see that flag. That way you could always see its terminal output if its being run from inside a terminal, with the minor caveat that it behaves like imhex-gui &. After all, people can just call imhex.exe instead to get the proper blocking behavior.
All in all, this issue is really unfortunate IMO, because it's sort of on us to fix, but what we need to fix is the fundamental problem of /SUBSYSTEM:WINDOWS behaving weirdly inside terminals. 😟


Failed to Import d3 in vue script

vue init webpack my-project
...
npm install d3 --save

in Hello.vue
<script>
import d3 from 'd3'
console.log(d3) //undefined
</scrip>

The only way to get d3 is to set it in plugins
plugins: [
        new webpack.ProvidePlugin({
            "d3": "d3",
        })
    ]

but I don't want to set it global, how to use it by import
当我自己写了一个简单的demo的时候, import是能拿到d3的, 但是用了这个手脚架, 就import不进去了, 不知道哪里的设置问题, 能帮忙看下吗? 谢谢, 很简单的流程, 就只是这点代码量

You have to import like that:
import * as d3 from 'd3';

@hekigan Thanks, it works. But it was very strange. I write a simple webpack script, and using import d3 from 'd3', it works, but failed to work in the vue cli project, anyway, thanks for your help

@Awakening-j : basically, if you look at the D3 package.json in the node_modules folder, you would see which file is being called as 'main'.
I am not 100% sure, but it looks like depending if you are using ES5 or ES6, you have to use either import * as d3 from 'd3'; or import d3 from 'd3';
So I don't think it is related to Vue cli   :)

you can import specific d3 module like this: import {csv} form 'd3-request', instead of import all d3 package with: import * as d3 from 'd3'.  d3 is too large, I always use what i need~~


[zh] fix broken links in install kubectl windows page

It seems the same issue #29570 exist in this localization as well.
/language zh

Deploy preview of the modified page https://deploy-preview-29573--kubernetes-io-main-staging.netlify.app/zh/docs/tasks/tools/install-kubectl-windows/

/lgtm

thanks for your pr, could you update the all link in /zh? @niteshseram
/hold
see

Hi @tanjunchen, I believe you are asking me to update all the links like I did in /en. But I am think the /zh content is not exactly similar to /en and some links are missing.But I did update all the links that were present in /zh.

@niteshseram   I have seen the translation of ko and updated the all links. The zh/  fullversion parameter should not affect the download url. /cc @tengqm could you help me confirm it? thanks.

This PR is incomplete. We are supposed to fix all links on the page.

Closing due to lack of response from author. Will propose a complete sync soon.
Thanks anyway.
/close


Added link to the society contributing guidlines

Thanks for your changes @KieranRobson. These will be merged now.


feat: group parallel identity

3 groups for parallel identity tokens as per https://github.com/sismo-core/sismo-hub/issues/1446
@MartinGbz in the group-generators/generators/parallel-identity-holders-sanctions-safe/index.ts file - I'm using the JSON RPC to query isSafeSanctions.
I haven't used it in the group generator before, is this correct instantiation for eth mainnet?
    const rpcProvider = new dataProviders.JsonRpcProvider(
      process.env.JSON_RPC_URL
    );

It's working for my local client using ethers and Alchemy SDK, let me know if any issues

@MartinGbz  sorry for closing this PR, I had issues with Git.
I updated the Alchemy Provider so that

getOwnersByTokenIds is public and can receive multiple tokenids
getMetadataFromNftTokenIds is private and used internally


Error : not found

Hi!
I have this problem and I do not know why...

Thanks!

same here

Duplicate of #109


Provide an example ecosystem component

We should provide an example annotated ecosystem component

The current Rulebook is one example.


jsonpath for length of an array

Is there a way to get length of an array?
Example:
- name: active_values_count
  type: object
  path<EMAIL_ADDRESS>== "ACTIVE").length()

Hi, I think the path defines element selection for the filter. The length or the array does not help you with element selection. You have it in inappropriate place.
Maybe you can use in label or value.

Is this still an issue? It seems solved.

It is still an issue and it won't be resolved unless the collector is re-written to use a jsonpath module that supports the .length() method, or if kubernetes implements it (since we use their jsonpath module):
https://github.com/prometheus-community/json_exporter/blob/1614ee8d771f89a8c6093aee9985609c69b37532/exporter/collector.go#L23

This is also an issue for accessing specific elements. I can't do
<EMAIL_ADDRESS>- 2)]
for instance


PT-1358 | Disallow enrolling when it has not begun

Description :sparkles:
Hide enrolment button until enrolling has begun.
Instead show test that describes when enrolment will begin.
Tests fixed in: https://github.com/City-of-Helsinki/palvelutarjotin-ui/pull/189
Issues :bug:
Closes :no_good_woman:
PT-1358:
Testing :alembic:
Automated tests :gear:
Added a test case to check that the button does not exist if enrolment has not begun. A lot of tests already so I was a bit hesitant whether I should add to the maintenance load. In the end I thought that this behaviour is worth testing as it has a big enough impact on UX and could be easy to break because there's a lot of boolean logic where this button is declared. Can be dropped if not.
Manual testing :construction_worker_man:
Screenshots :camera_flash:

Additional notes :spiral_notepad:

Codecov Report

Merging #188 (8a577cb) into master (c209942) will increase coverage by 0.37%.
The diff coverage is 91.52%.

:exclamation: Current head 8a577cb differs from pull request most recent head 899e75e. Consider uploading reports for the commit 899e75e to get more accurate results

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   83.76%   84.13%   +0.37%
==========================================
  Files         113      115       +2
  Lines        3388     3398      +10
  Branches      772      725      -47
==========================================
+ Hits         2838     2859      +21
+ Misses        542      531      -11
  Partials        8        8

Impacted Files
Coverage Δ

...c/domain/event/occurrences/EnrolmentButtonCell.tsx
0.00% <0.00%> (ø)

...in/event/occurrences/OccurrenceEnrolmentButton.tsx
97.61% <97.61%> (ø)

src/domain/event/occurrences/EnrolmentError.tsx
100.00% <100.00%> (ø)

src/domain/event/occurrences/OccurrenceInfo.tsx
88.23% <100.00%> (-2.47%)
:arrow_down:

src/domain/event/occurrences/OccurrencesTable.tsx
96.72% <100.00%> (+0.50%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c209942...899e75e. Read the comment docs.


Support 64x64 LED Matrix and Add HomeAssistant Binding

Hi @fspoettel,
Thanks for making this project, it made it very easy to get a LED Matrix setup with Spotify, and I've enjoyed using it!
For me the 32x32 panel was too small, so I got mine setup on a 64x64. This code will add support for using either size of panel, by specifying the size when creating the matrix_factory
I saw this feature requested in issue https://github.com/fspoettel/thirtytwopixels/issues/4 as well.
Recently I've started using MusicAssistant integrated with HomeAssistant for most of my music, so this will also add support for setting up this binding for those using a similar setup

Hi @thordy, thanks for the PR! :heart: It's been a while since I looked at this project, please give me some time to review it properly.
The HomeAssistant binding sounds exciting.

Thanks again @thordy 🫡


flip book like mode (user project modification)

Hi, I have a project based on PDFjs to flip pdf pages like a book. Would you like to add it to Gallery of user projects and modifications if someone can be interested.
https://raffaelemorganti.github.io/pdf-viewer/
https://github.com/RaffaeleMorganti/pdf-viewer/

Done; thank you!


Crash on startup

Please use the search functionality before reporting an issue. Also take a look at the closed issues!
Issue description:
Hey guys, decided to update my mek version. was running Mekanism-1.12.1-<IP_ADDRESS>6, MekanismGenerators-1.12.1-<IP_ADDRESS>6 & MekanismTools-1.12.1-<IP_ADDRESS>6 for MC 1.12.2 and updated to Mekanism-1.12.2-<IP_ADDRESS>8, MekanismGenerators-1.12.2-<IP_ADDRESS>8 & MekanismTools-1.12.2-<IP_ADDRESS>8. according to my logs the Mekanism Generators is erroring and crashing Minecraft. I also tried MekanismAll-1.12.2-<IP_ADDRESS>3eecc3 which @thiakil gave me and it crashes for the generators module.
https://gist.github.com/Moobien/a80ca24eeafa02808784fd460a505418

Also with the previous version I was running the energized smelter wouldn't smelt "Steel Blend"

Does nobody search? This has been duplicated 7 times already. #4827

Has the steel blend issue been duped also?

Does the steel blend work in a normal furnace? (I want you to actually test that, not just to say it normally does)

Tested just then.
Energized Smelter: Can't shift click the TE Steel Blend in, but can manually place - does not smelt
Vanilla Furnace: same as Energized smelter
TE Induction Smelter: shift clicks in, smelts when sand also in the machine.
I don't know why but the TE Steel Blend is overriding the Mekanism Steel Dust.  I talked to KingLemming about this last night and he said that the output is ore dictionarying on your end but not inputting.
https://imgur.com/a/aTZYZ
I run iron ingot through to Metallurgic infusers but the output of the 2nd one outputs steel blend instead of steel dust.

From memory the steel blend isnt supposed to work in a standard furnace but i could be wtong

I talked to KingLemming about this last night and he said that the output is ore dictionarying on your end but not inputting.

He's right about what is happening, but not where. The Infuser recipes are ItemStack based; there is no oredict on our end. Something else is attempting to unify.

only possibilities then would be UniDict-1.12.2-1.2 or LibVulpes-1.12.2-0.2.6-12-universal  would these need to go?

Testing now with UniDict removed, seems Advanced rocketry needs libvulpes

tried with all 3 removed and no change.

this is my modlist
ActuallyAdditions-1.12.2-r124.jar
AdvancedRocketry-1.12.2-1.2.5a-23.jar
animania-1.12.2-1.4.2.jar
ArmorStandGUI-1.12-1.0.4.jar
autoplant-1.12-1.0.0.jar
backpacks 1.12.2 - 3.4.2.jar
base-1.12-3.4.2.jar
BetterBuildersWands-1.12-<IP_ADDRESS>+69d0d70.jar
BetterFoliage-MC1.12-2.1.10.jar
BiblioCraft[v2.4.3][MC1.12.0].jar
BowInfinityFix-1.11.x-1.12.x-rv5.jar
buildcraft-7.99.12.jar
Chameleon-1.12-4.1.3.jar
ChickenChunks-1.12-<IP_ADDRESS>-universal.jar
Chisel-MC1.12-<IP_ADDRESS>.jar
chiselsandbits-14.9.jar
Chunk Pregenerator V1.12-1.5.jar
Clumps-3.0.0.jar
CodeChickenLib-1.12-<IP_ADDRESS>3-universal.jar
CoFHCore-1.12-<IP_ADDRESS>-universal.jar
CoFHWorld-1.12-<IP_ADDRESS>-universal.jar
CoralReef-2.2-1.12.2.jar
CraftStudio-<IP_ADDRESS>-mc1.12-alpha.jar
CraftTweaker2-1.12-4.0.10.jar
CTM-MC1.12-<IP_ADDRESS>.jar
davincisvessels-1.12-6.340-full.jar
Decocraft-2.5.2_1.12.2.jar
EnchantingTable-1.12-1.1.2.jar
extrautils2-1.12-1.6.7.jar
ExtremeReactors-1.12-<IP_ADDRESS>.jar
FastLeafDecay-v14.jar
FTBLib-4.2.3.jar
Futurepack-1.12.1-26.2.27.jar
HoloInventory-1.12.2-<IP_ADDRESS>.jar
InventoryTweaks-1.63.jar
IronBackpacks-1.12.2-3.0.1-2.jar
ironchest-1.12.2-<IP_ADDRESS>0.jar
IronMan-Beta-1.12-1.0.1.jar
jei_1.12.2-<IP_ADDRESS>.jar
journeymap-1.12.2-5.5.2.jar
LC 0.0.1.jar
LibVulpes-1.12.2-0.2.6-12-universal.jar
list.txt
lostcities-1.12-1.0.2.jar
LucraftCore-1.12-1.2.3.jar
Mantle-1.12-<IP_ADDRESS>.jar
MCA-1.12.x-5.3.1-universal.jar
mcjtylib-1.12-2.4.5.jar
MCMultiPart-2.3.3.jar
Mekanism-1.12.1-<IP_ADDRESS>6.jar
MekanismGenerators-1.12.1-<IP_ADDRESS>6.jar
MekanismTools-1.12.1-<IP_ADDRESS>6.jar
minecolonies-universal-1.12.2-0.8.5743.jar
modeltrains-1.2.2.jar
mods.txt
movingworld-1.12-6.342-full.jar
natura-1.12-<IP_ADDRESS>.jar
NotEnoughItems-1.12-<IP_ADDRESS>-universal.jar
omlib-1.12.2-3.0.0-131.jar
openmodularturrets-1.12.2-3.0.0-227.jar
OptiFine_1.12.2_HD_U_C6.jar
platforms-1.12.0-1.4.1.jar
RadixCore-1.12.x-2.2.1-universal.jar
railsplus-1.0.1.jar
realms_persistence.json
RebornCore-1.12.2-<IP_ADDRESS>-universal.jar
RebornStorage-1.12.2-<IP_ADDRESS>.jar
RedstoneFlux-1.12-<IP_ADDRESS>-universal.jar
refinedstorage-1.5.23.jar
rflux-1.12-0.1.2.jar
rftools-1.12-7.13.jar
Roads-1.12.2-1.0.1.jar
shetiphiancore-1.12.0-3.5.4.jar
Signals-1.12.2-1.0.0-universal.jar
SpacePackExtended-1.12-2.2.4-alpha.jar
SpawnTemple-v.2.1-mc1.12.jar
StevesCarts-1.12.2-<IP_ADDRESS>.jar
StorageDrawers-1.12.1-5.3.3.jar
switchbow-1.5-1.12.2.jar
TConstruct-1.12-<IP_ADDRESS>.jar
ThermalCultivation-1.12-<IP_ADDRESS>-universal.jar
ThermalDynamics-1.12-<IP_ADDRESS>-universal.jar
ThermalExpansion-1.12-<IP_ADDRESS>-universal.jar
ThermalFoundation-1.12-<IP_ADDRESS>-universal.jar
tombstone-1.6.0-1.12.jar
torohealth-1.12.2-11.jar
TreeChopper-1.12.2-1.2.4.jar
VeinMiner-1.12-<IP_ADDRESS>9+134fb1e.jar
VillageNames-1.12.2-2.0.jar
WanionLib-1.12.2-1.2.jar
wolfarmor-1.12.2-<IP_ADDRESS>-RELEASE.jar
YABBA-1.0.10.jar
zerocore-1.12-<IP_ADDRESS>.jar

This is a pack level issue. Take it up with your pack maker if it is a pre-made one, or solve it yourself if it is something you put together.

its one I did myself. Thanks for your help though Thiakil, go enjoy the rest of your sunday afternoon :)


fatal: --author is not 'Name ' and matches no existing author

Hey Łukasz, thanks for taking the time to build this and make it available! I was excited when I saw it existed!
Having a problem, and I'm feeling silly that I'm not sure how to deal with it, so, sorry if it's got an obvious solution that I've missed somehow.
I've set up the action like I have with other GitHub Actions in the past (in .github/workflows/, with a .yml file like specified in your README). I've run the workflow, and it keeps failing witt the following:
fatal: --author 'theJoshMuller' is not 'Name <email>' and matches no existing author
Error: Process completed with exit code 128.

Looks like it's coming from something going on here, as ${{ github.actor }} would be my username, theJoshMuller.
Should I be passing a different author variable, or adding my username as an author in a config somehow?
Or, do you have any other tips as to why this might not be working for me?
Thanks for the help!

Hi Josh!
Thanks for letting me know.
This is strange and I haven't seen this happening. I'll check what's up and get back to you.

I released v2.4.1 that should fix the problem. Please try running the action and let me know if that helps.
To be honest though, I haven't seen this issue popping up in my test setups (even though the error is in line with Git's documented behavior. GitHub action runners are strange beasts).

GitHub action runners are strange beasts indeed.
Still getting an error, but it's a different error, so... progress? 😅
remote: Permission to theJoshMuller/theJoshMuller.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/theJoshMuller/theJoshMuller/': The requested URL returned error: 403
Error: Process completed with exit code 128.

Good to know!
About this other error: go to your repo settings, select Actions > General, look forWorkflow permissions and see if you have Read and write permissions selected.

🤦🏻♂ yup! That did it! Thanks so much! Sorry, still getting the hang of GitHub actions. This one seems obvious in retrospect.😅
Might be something valuable to add to the README.
Thanks again!

I'm glad it helped! And don't worry, we all start somewhere. If I can be of any more help, let me know.

Might be something valuable to add to the README.

Good point, I'll do it soon.


Cannot Uninstall Extension because another extension depends on it

🚨 The issue tracker is not for questions 🚨
If you have a question, please ask it on https://stackoverflow.com/questions/tagged/visual-studio-code.

I've installed an extension pack called "Web Builder Essentials" for VS Code. There are two extensions in it which I want to uninstall but it says Cannot uninstall extension because Web Builder Essentials depends on it.

You will need to uninstall Web Build Essentials first. 🤷♂

Is there any way to remove the dependencies of "Web Development Essentials" without uninstalling it.

/causedByExtension
Not if "Web Development Essentials" has them as dependencies. If "Web Development Essentials" listed them as part of an extension pack, then yes. Best to file this as a request for "Web Development Essentials": https://github.com/jamesqquick/Web-Development-Essentials-Extension-Pack/issues/new
They might want to check out: https://code.visualstudio.com/blogs/2017/03/07/extension-pack-roundup


A tiny bit of documentation for KeyboardEvent

Might help people get over their initial confusion when not finding the keyCode function.

This is great, thanks!


how can i put a image as the greeting.

I have question related to jQuery Terminal
I cant seem to set a image as the greeting in jquery, heres what my code looks like
greetings: '',
when i do the whole webpage is a white screen which is what usaly happens to me when there is a error. is this feature even possible? also didnt know if i should have marked this as a bug/error or a question so please change the catergory accordingly. thanks

jQuery Terminal doesn't allow raw HTML by default for security reasons. You can use Terminal formatting syntax for images:
term.echo('[[@;;;;https://placekitten.com/300/300]]');

or by adding XML Formatter that allows using images.
You can also add this formatter:
$.terminal.new_formatter([
    //g, '[[@;;;;$1]]'
]);

but with XML Formatter you can also have an alt attribute, and it allows other XML-like tags inside Terminal, that is easier than Terminal formatting syntax.


setting uri using service external IP

Hi
According to https://aws.amazon.com/blogs/containers/integrate-amazon-api-gateway-with-amazon-eks/
we should aws cli to set the apigateway uri
In my helm chart I define a service that uses aws lb
I also define an apigateway and would like to use the service fqdn (erternal-ip) to set the uri
Any idea how to do it in the same chart?
service definition
kind: Service
metadata:
  name: {{.Release.Name}}-{{.Chart.Name}}-collector
  annotations:
    service.beta.kubernetes.io/aws-load-balancer-type: external
    service.beta.kubernetes.io/aws-load-balancer-nlb-target-type: ip
spec:
  ports:
    - port: {{ .Values.collector.config.ports.http }}
      targetPort: {{ .Values.collector.config.ports.http }}
      protocol: TCP
  type: LoadBalancer
  selector:
    app: {{.Release.Name}}-{{.Chart.Name}}-collector

api gateway v2 definition
apiVersion: apigatewayv2.services.k8s.aws/v1alpha1
kind: API
metadata:
  name: saas-apigwv2-nlb
spec:
  body: '{
            "openapi": "3.0.1",
              "info": {
                "title": "saas-apigwv2-nlb",
                "version": "v1"
              },
              "paths": {
              "/\$default": {
                "x-amazon-apigateway-any-method" : {
                "isDefaultRoute" : true,
                "x-amazon-apigateway-integration" : {
                "payloadFormatVersion" : "1.0",
                "connectionId" : " {{ required "vpc ID required" .Values.apiGatewayV2.vpcID }} ",
                "type" : "http_proxy",
                "httpMethod" : "POST",
                "uri" : "$(aws elbv2 describe-listeners --load-balancer-arn $(aws elbv2 describe-load-balancers --region $AGW_AWS_REGION --query "LoadBalancers[?contains(DNSName, '$(kubectl get service authorservice -o jsonpath="{.status.loadBalancer.ingress[].hostname}")')].LoadBalancerArn" --output text) --region $AGW_AWS_REGION --query "Listeners[0].ListenerArn" --output text)",
                "connectionType" : "VPC_LINK"
                  }
                }
              },
              "components": {}
          }'

Hey @oxeye-schmil,
This seems like an interesting proposition, and I can totally see value in a dynamic interaction between the two controllers. From what I understand, you would essentially like to inject the URI created by the ELB controller into the body of the APIGW API object within the same chart?
ACK controllers don't currently support something like that. I imagine this would be supported in the form of ConfigMap values, or something of that sort. For the moment, we expect that each spec field is statically defined, however. One suggestion I might make is that you install the ALB controller and your service annotations in one chart, and the ACK APIGWv2 controller and API in another chart. You can then set the body field of your API object from a Helm chart value, which can be modified at apply-time (eg. helm install --set body.uri=$(...) ...).
Hope that answers your question.

I did separate the charts for the moment
but it causes dependency between charts that causes devops issues
Can we tag it as a feature request?

@oxeye-schmil , Please correct me if my understanding below is incorrect.
You want to create a helm chart which has a k8s service(LoadBalancerType) and this k8s service's external IP will be used as uri in API resource.
The issue that you may be seeing are that API Gateway resource is not waiting for k8s service to be created and you'd like to have a dependency relation between them.
If above is correct, then we have a similar issue#545 that we will work on in the future to handle resource relationship.
But Note that resource relationship being handled there will be between different resources managed by same ACK controller. Ex: VpcId and API resource.
So I am not sure if we can take this up as a feature request to support relationship between resources not managed by same controller. And this is completely from a technical viewpoint because to establish relationship you need to add informers & watchers in controller.

By the way is possible to have the API resource run in "default" stage wihtout creating a stage resource?

No, you'll need to create the stage resource for invocation. It is possible to create the stage with name "$default", which will allow you to skip stage-name in invocation url.


feat(log): bump log module from 1.4.0 to 6.3.1

Intent
Update to the latest version
Approach
Sinon couldn't wrap the warning function in the log module when I updated log to the latest version. So I created an object to decorate the underlying log module.
This means that technically the logger API has changed.
Reasoning
I didn't want to change the tests because, to me, they represent the agreed upon public API. So my thought is that if the tests pass, the probability of breaking a dependent is low.
#1492

👋 if we're already replacing a logger module would be nice to go with something that supports structured logging like https://www.npmjs.com/package/pino

So. I’m already questioning myself suggesting replacing logging with this PR. Questions like:
Is now the time to make such a big move? And not at least bump to a minor version release?
is this even a big move?
What minimum version of Node.is does this support?
what minimum version should Hubot support?
I’m unfamiliar with pino, but structured logging seems like a common requirement “nowadays”.
what are you’re thoughts?

Lots of change has come in lately which is good, but too much can be a problem.
PR description currently doesn't say why were making this change, it describes a problem which occurred. I think "Sinon couldn't wrap the warning function in the log module when I updated log to the latest version." means "some test coverage stopped working", which might suggest replacing the logger (but are there other options like fixing tests? it helps to document why not that approach).
Considering a structured logger is also a good idea and that would be a feature change I think, since it would change one of Hubot's interfaces (for the better). Again I'd like to see the why of it in the issue/PR rather than just the change proposed. Tedious, I know :)
Sidebar: If we had semantic-release configured (#965?) it would put onus on us to stop the "chore" commit message here (docs, since "chore" says "nothing to see here" and this is a feature version change IMO?

Apologies.
Great points. I'll update the title and description to include the why and add my thought process.
I've reverted the change back to "just update the log version" and try an approach that will pass the tests so we can consider moving forward with just that change and create a different PR to discuss replacing log with Pino for the structured logging aspects.

Yeah, all above makes sense. Sorry for bringing the discussion into PR.
One thing to consider is that newer version of the same log package can also have breaking changes and can break stuff on users' side.

what minimum node version should Hubot support?

I think we should align with https://endoflife.date/nodejs, so currently it would be 16+ (of course we should bump major when we change this requirement)

All good @levenleven - thanks for proposing!
@joeyguerra yep if it's just upgrading existing logging component then chore is probably right; if we swapped loggers and Hubot's log output changed, that might impact folks who are parsing it, and therefore I'd argue it's worth some more significant signifier. Which is what I was trying to say - that once those commits have "real world impact" (ie firing semantic-release), it puts the requirement on us to consider and describe what we changed, which is hopefully for the better.
All very theoretical until we wire that up again 😁

API is one primary interface of Hubot, but log output is also (IMO) an interface (albeit secondary), and chat responses are another primary interface, etc.

Based on this thought, "log output is also an interface", I'm going to change the PR title to feat(log) because I can't say for sure that the log output has NOT changed. I also feel like since we're going from a 1.x to a 3.x version of log, that the probability the output has changed is high.
Therefore, I'd like to get the other PRs merged first so that we can do another release. Then consider merging this one after that for a more impactful release.

Gosh, "feat" feels like a lot now! Sorry 😄 but all good. We are surely going to hit a feat release with all the change that's come in anyway.
@joeyguerra just want to check you realise that -

👻  semantic-release uses commit messages not issue titles to determine the significance of changes in a new release, and
you can change existing commit messages using git rebase or git commit --amend

(I promised somewhere to show you how that was done, and haven't yet done this.)

@xurizaemon I'm trying to figure out how to resolve your review. I made the changes so it should be good.

Weird, sorry if that left it blocked! It looked like the relevant changes were made but maybe needed further approval after that?

No worries. Yes, I think as a reviewer, you have to go back and click “approved” somewhere. Thank you. Gonna smerge.

Welp. No I’m not. I had to remove node 14 from the action but this PR page thinks it’s still a check. Perhaps it’s a cache invalidation problem?

@levenleven @technicalpickles I need help with merging this PR. I removed building with node_version: 14.x in this PR because the build is failing for node version 14 with
npm ci
npm WARN prepare removing existing node_modules/ before installation
npm ERR! Cannot read property 'async' of undefined

Since we're trying to follow the Node.js release cycle, removing building with 14 seems like the right direction. But now that check is still expected but won't pass because it's essentially been removed from the workflow file.
Any suggestions on how to move forward?


gPINN with RAR

Thank you for sharing this incredible repository. For gPINN improved with RAR, is it obligatory to have true values of response variables? what if we do not have any knowledge of true solutions within the domain? (I mean, just the initial/boundary conditions are known)

Also works.


Updated two sites in programming playground

Added Flexbox Froggy and Flexbox Defense in Programming Playground English section of HTML and CSS.
What does this PR do?
Add resource(s)
Why is this valuable (or not)?
By playing the game one can learn the use of Flex in css.
How do we know it's really free?
I have myself played it.
For book lists, is it a book? For course lists, is it a course? etc.
It is a game to learn CSS flex .

Sorry, Nothing to add after resolve conflicts


Fixed abstain votes for unclocking

#8695866a2

Task linked: CU-8695866a2 Android. No unlock period for available unlocks


Add filtering based on tool type

Would be nice if users can filter which types of tools get displayed.
Kicking off some idea:

Add clickable icons that dim when inactive (or with adjacent toggle switch) for tool types (API, CI, CLI, etc...) to top left of header. As user scrolls, they can show/hide different types of tools. Will this be a good experience? How would we handle mobile?

Will love to hear more opinions 💬

I actually expected this in the current UI. I instinctively clicked on the icons to try and filter to the kind of tool I wanted.


Gh 696 map generator

Codecov Report

Merging #711 into develop will increase coverage by 0.1%.
The diff coverage is 81.25%.

@@             Coverage Diff              @@
##             develop     #711     +/-   ##
============================================
+ Coverage      60.63%   60.74%   +0.1%
- Complexity      2699     2709     +10
============================================
  Files            394      395      +1
  Lines          12109    12155     +46
  Branches        1382     1386      +4
============================================
+ Hits            7342     7383     +41
- Misses          4192     4196      +4
- Partials         575      576      +1

Impacted Files
Coverage Δ
Complexity Δ

...ain/java/uk/gov/gchq/gaffer/data/element/Edge.java
88.31% <ø> (+1.13%)
24 <ø> (ø)
:x:

...n/java/uk/gov/gchq/gaffer/data/element/Entity.java
87.5% <ø> (+7.01%)
16 <ø> (+1)
:white_check_mark:

...k/gov/gchq/gaffer/data/generator/MapGenerator.java
81.25% <81.25%> (ø)
9 <9> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c137c86...5a3c594. Read the comment docs.


Feature: Sourcemaps

Add gulp-sourcemaps to create a CSS sourcemap.
This might be helpful for debugging.
Unfortunately gulp-closure-compiler-service does not support the usage of sourcemaps.
Maybe you could switch to gulp-uglify which does support it and is more active in development.
Using gulp-uglify is a bit less efficient (35 bytes) but I think it is worth it to support sourcemaps.
What do you think Lea?

Sure, but you'd have to make that change too then :)
Thanks!

@LeaVerou Done!
To sum it up:

add Sourcemaps for CSS and JavaScript files
replace gulp-closure-compiler-service with gulp-uglify

Awesome, thanks!!

@LeaVerou You are very welcome. I have to thank you for this awesome library 😄 🎉


Automate scraping

Every time the schedule is updated, we need to re-run the parser. Doing this manually is tedious and during the event there won't be any time for this.
The schedule is in this document: https://docs.google.com/spreadsheets/d/1QeAyxbEc1fP9h5_kGQh-EVrx5RaYgbKFJBE9wUjIdvc/edit#gid=1847379562
The worksheet "Versioning" contains the list of tracks and the column GID indicates which worksheet contains the session for that track. With every update a value in GID changes & we need to re-run the scraper. The changed files need to be pushed to Github.
Likely approach is using event triggers in AppScript (see https://developers.google.com/apps-script/guides/triggers/events). Scraper could be deployed to Heroku so we can invoke it via URL.

@joerx
I will like to work to work on this issue. My plan of action on the heroku server is as follows -

For the first time, I will clone this repo on the server
Then with each spreadsheet update, a script will run which will -
Pull changes from this repo to server's copy.
Run the script scraper.py
Push the changed files back to repo

However I have a concern.

Free dyno has a 6 hour sleep time. If the spreadsheet is updated very regularly, like every 30 mins then the server will go offline for 6 hrs.

@aviaryan - Great, thanks! Few questions:

How are you planning to detect changes to the sheet?
How will the job be triggered?
Does your approach definitely require Heroku, or can we deploy it somewhere else if needed?

How are you planning to detect changes to the sheet? How will the job be triggered?

I haven't used Google apps script first hand but quick google searches show that setting an event for speadsheet change and calling an external url are both possible . If for some reason that doesn't work, I know for sure that IFTTT can help me set a trigger that will invoke on spreadsheet change and will call any url I want.

Does your approach definitely require Heroku, or can we deploy it somewhere else if needed?

Any server should work fine. The main requirement is that it should run python, bash and have git installed. Heroku is the simplest you can get in this case.

@joerx I tried to look into this. I had a suggestion, though not sure if it's the ideal one. So, How about this-:
We can execute the script, that does the scraping, from another script every 'n' number of hours (which we can decide) programmatically, on days, when some 'event' is not there, which we can first detect from the new script (by simply searching) , which will execute the scraping script.
Now, on the days of some 'event', we can reduce the number 'n' (which I mentioned above) to like, every hour, the script gets executed or so.
Because, we can't surely keep the script running 24x7, that keeps checking for changes in the Google Spreadsheet, because that will eventually put a lot of load on the server and maybe also crash it. I maybe wrong here, but that's what I thought eventually.
Or, in case if we want the changes to reflect in real-time, then we can first export the existing entries in the google apps script to a database, and then offer some 'Secure' web utility to the people for adding events, which directly saves the entries in the database, and then the changes can be reflected in real-time, by simply searching through the database.
I am not sure which is the ideal option. I would request you to give me views on the 2 alternatives and build on the same, so that we could work and fix this issue collaboratively. @joerx
Thanks! :smile:

Because, we can't surely keep the script running 24x7, that keeps checking for changes in the Google Spreadsheet, because that will eventually put a lot of load on the server and maybe also crash it. I maybe wrong here, but that's what I thought eventually.

Script is not checking for changes in Google spreadsheet. The latter calls it when it is changed. So there is no load.
@joerx Assuming that the spreadsheet is not changed in a span of 6 hours or so (in night time maybe) or not changed very regularly like every 30 mins, the heroku server should work just fine. I will test the server on a fork of this repo (my account) first and let you know how it goes.

Have you investigated AppScript? It seems to be similar to VBScript in MSOffice, except it's JS based. It should allow us to respond to changes as they happend w/o needing to schedule anything.
Having a cronjob is not the best solution since we'd need to host it somewhere (Heroku won't work with a free Dyno)
https://developers.google.com/apps-script/

Have you investigated AppScript? It seems to be similar to VBScript in MSOffice, except it's JS based. It should allow us to respond to changes as they happend w/o needing to schedule anything.

I have used AppsScript a bit. Yes it will allow us to set a trigger/do-something but the main thing is running the python script and then git. We will require a server for that. What do you suggest then, @joerx ? Can we get a paid heroku server ? or something else ..
btw, I have got a cheeky solution to run a heroku server straight for 24 hours in free mode. I will try implementing that and testing it on my repo.

@aviaryan So, then how do we detect changes in the google spreadsheet? As, in then how will the latter call the scraping script when the Google Spreadsheet is changed?
Sorry. I didn't understand. Hence, thought I must ask about the same.
@joerx Yes, that seems to be a good idea. We can try that out.

@aviaryan So, then how do we detect changes in the google spreadsheet? As, in then how will the latter call the scraping script when the Google Spreadsheet is changed?

Google does it. When it sees that the spreadsheet has changed, it looks through all hooks (urls) attached to that event and calls them .
@joerx I am starting working on the apps-script and the server code now. It shouldn't take more than few hours.

Free dynos need to sleep 6 hours in every 24hr period. That should do for just running the scraper. The instance can hibernate most of the time and will only need to wake up when we update the schedule.

@joerx Almost everything is done. Here is an automatically done commit. https://github.com/aviaryan/open-event-scraper/commit/27c7c405d309959ba112107fb5b2eb962a605cd3
I am sending a PR for it. Please check the output before merging.
Some finishing touches are left after which the bot will be completely ready. Then we can use it for this repo. :smile:

Good work! Let's aim at getting it set up tomorrow.

The work is complete. Unfortunately I am not able to test it because of issue #15.

Hi. Where are you on this issue ? The bot is now working perfectly. https://github.com/aviaryan/open-event-scraper/commits/master

hi,
is it still relevant issue?
if it is -  please comment the exact help needed.


Value and Range Mappings defined for specific metrics

In need of some way to define the same range of values for two different metrics and convert them to different Text on the Mappings tab of the panel.

+1


Remove * from allowed_urls

Closes #175

let s bump this in the  track/0.1 if the problem is also there


Next.js default for anchors

Next has a standard component for anchors which is more performant and it practically forces you to use it.
Example:
Home
<Link href="./">Home</Link>

Já estou a trabalhar nessa issue
@aoscode


implementing anchor autputs by default

Duer that we are new, we can implement Anchor Outputs  by default on lampo

I'd like to take up this issue. What do I need to know here?


JsonWebSignature2020: Nimbus library bug

Hi,
Nimbus library has a bug which makes the JsonWebSignature2020 impl. not working correctly. I have submitted the bug here, have a look for more info:
https://bitbucket.org/connect2id/nimbus-jose-jwt/issues/500/bug-unencoded-jws-payloads-rfc-7797-losing
This issue can be closed as soon as they repair the bug.

Closing the issue as JsonWebSignature2020 implementation is not included.


[Performance] Chat switching hermes profiling

What performance issue do we need to solve?
Use hermes profile to find slow javascript code during chat switching.
What is the impact of this on end-users?
Switching chat needs to be as fast as possible.
List any benchmarks that show the severity of the issue
Here's the profile:

getLastVisibleAction is slow because it creates JS date objects for each messages.
Proposed solution (if any)
Do not use date objects to sort report actions.
List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Version Number: 1.3.87-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
View all open jobs on Upwork

I will take this one on as well from the performance room, adding it to the project

will be merged soon

This is ready for payment $500 to @rushatgabhane now need for checklist as this was a performance improvement

$500 payment approved for @rushatgabhane based on comment above.

Thanks guys


Update active-directory-saas-amazon-web-service.md

Changed attribute from 'mail' to 'userprincipalname' which is the actual field you should be integrating against as it is the primary user identifier. Utilising 'mail' will not always result in a successful integration depending on the AAD fields populated for the user.

Hi @sjwaight, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

Reviewing w/Markus

Still waiting on review

Third ping. Will close if no response.


Abnormal behaviors caused by fullscreen shortcut

Describe the bug
As the title
To Reproduce
Steps to reproduce the behavior:

Press 'F' to enter fullscreen mode
Click on 'info' or anything which can change isInputting/isOnFocus state
See error

Desktop (please complete the following information):

OS: macOS
Browser: Edge 90.0.818.56
Slidev version: 0.15.0

Reason:
Pressing F makes magicKeys.f to be true (keydown event is fired), and causes the page to be full screen, but keyup event will be ignored by Chromium (Firefox is ok).
When isInputting/isOnFocus changes, fullscreen shortcut callback will be triggered again.
Reference:
https://stackoverflow.com/questions/44496707#answer-44496764


Hostmster is not starting

After running docker-compose up I got the following error
ERROR: for hostmaster  Cannot start service hostmaster: failed to create endpoint aegirdockerfile_hostmaster_1 on network aegirdockerfile_default: Error starting userland proxy: listen tcp <IP_ADDRESS>:80: listen: address already in use
ERROR: Encountered errors while bringing up the project.

Then something else is running on port 80 already... another container? or a webserver on your host OS?

Thanks @helmo It true.
I actually solved this by changing the port to 81.


fix: Add missing type to vite.ts

Added missing type to fix error while disabling auto import

sorry that this had gone unnoticed for long
thanks for the pr

thanks


Feature Requests

I'm liking this component, easy to use and pretty slick, what I was looking for.. Just had a couple little issues.  One is I'm using it in a scaffold with a FloatingActionButton, and when the panel comes up, the FAB sticks to the top, even when all the way up.  While that would be a neat effect in some cases, it's undesirable for most uses.  Wondering if there's a way for it to slide above the FAB?
Also would like to see the canvas behind the stopper fade with a transparent color overlay, and prevent interaction with the screen in back of it.  I believe that's what most would expect to see with this kind of UI.  Other than that, looking forward to implementing this in a few places in my app.  Thanks.

Thank you for your comments. I agree with both issues. I have investigated them and both of them are possible to implement. These limitations are caused by the way bottom sheets are shown, and by overriding the bottom layer we can overcome them.  This approach is used by the rounded_modal plugin.
You can try to use Stopper with it, although it looks like it's limited to modal popups. I am planning on incorporating similar functionality in the Stopper plugin sometime next week. I'll keep you posted.


Automated Package Upgrade

:tada: This PR is included in version 5.0.107 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Planning: add the open space algorithm documents

Please locally squash the commits into one. You could use "git amend" in your future commit fixing to avoid multiple commits


Update docs for missing_ok to fix error

The docs previously had some conficting information, on one line saying:

missing_ok=Bool (optional) shorthand syntax for expects="0+"

And on another:

#@overlay/match missing_ok=True: expects to find 0 or 1 matching nodes on the “left”

After testing it, I determined that the actual behaviour is equivalent to expects=[0,1]

Closed per the CLA instructions as a VMware employee and re-opened here: https://github.com/vmware-tanzu/carvel.dev/pull/111


[Test] Changed gcc-7 to gcc-8

Bumping gcc 7 to 8 to workaround the ongoing gcc segfault problem when building Protobuf C++. Currently Foundational C++ requires gcc 7 so this is a temporary measure to make the test green. We need to either make a decision to change the minimum version of gcc in the Foundational C++ or find a way to support gcc 7 without gcc segfault soon.

This breaks the Bazel RBE Non-Bazel Tests completely by not updating
https://github.com/grpc/grpc/blob/98704e7e4d5167fa2497e76fb28b88fc39be709a/tools/bazelify_tests/test/portability_tests.bzl#L56


docker load failures after upgrading to 1.4.

Describe the bug
After upgrading from 1.3.x to 1.4.x we now see an error when trying to build images with bazel and load them.
One of the Bazel rules generates a shell script to perform a docker load of an OCI tarball
On Friday, I upgraded to 1.4.0, and started getting the following error:
Error response from daemon: handle request: write request: write unix @->/var/run/docker.sock: write: broken pipe
I then downgraded to 1.3.0, and the error went away.
This morning, I upgraded to 1.4.1, and started getting the following error:
lsetxattr com.apple.provenance /manifest.json: operation not supported
This can be reproduced by using the following command line from the following Git repository: https://github.com/bazel-contrib/rules_oci
bazel run //examples/empty_base:tarball
To Reproduce

Install bazel via bazelisk: brew install bazelisk
git clone https://github.com/bazel-contrib/rules_oci
cd rules_oci
bazel build //examples/empty_base:tarball
docker load < bazel-bin/examples/empty_base/tarball/tarball.tar

The last output should say: lsetxattr com.apple.provenance /manifest.json: operation not supported
Interestingly it seems to work fine with other images like busybox:

docker pull busybox
docker save -o busybox.tar busybox
docker load < busybox.tar

Expected behavior
No response
Diagnostic report (REQUIRED)
OrbStack info:
Version: 1.4.1
Commit: 402f6cfcd5a2b2debef3e36929540c3c6f79ece3 (v1.4.1)
System info:
macOS: 14.3 (23D56)
CPU: arm64, 10 cores
CPU model: Apple M1 Pro
Model: MacBookPro18,1
Memory: 32 GiB
Full report: https://orbstack.dev/_admin/diag/orbstack-diagreport_2024-02-05T17-34-41.109625Z.zip

Screenshots and additional context (optional)
No response

Fixed for the next version.

Released in v1.4.2.


Release instead master?

Is there a reason why pristine builds from master? Shouldn't we build from release, instead?
https://www.chromium.org/developers/how-tos/get-the-code/working-with-release-branches
https://chromium.googlesource.com/external/webrtc/+log/branch-heads/48
Due to my understanding, everything goes into master, if it properly works or not, and only a few handpicked commits make it into release. Or do I understand this wrong?

I would like to know the answer too :)

@kolencherry Can somebody of you guys comment on this please. We're confused why you're building from master.

Your understanding is correct. This was just our use case when we open sourced the scripts. We pull very frequently to ensure that any conflicts caused by our changes to the source code are caught early. We have not had the bandwidth to add specific functionality to build release branches. This would not be difficult though, so feel free to submit a PR.


Housekeeping: Remove beartype warnings

This PR updates typing.List imports to not generate the red warnings on import.
Also one non-functional change to the stack example, could not help myself.

Yep, noticed those warnings as well. Good catch, thank you!
It's been published: https://pypi.org/project/pglet/#history


OCPBUGS-6033: Helm: propagate the rbac image values to the charts

Despite reading the environment variable to set the image, we don't use it so the operator always deploy the default one.

/retest

Failures related to the bfd flake and namespace assignement that is being investigated.
Kuberbac proxy image now being overridden with the quay/origin one.
/override ci/prow/metallb-e2e-metal-ipi-ovn

/override ci/prow/metallb-e2e-metal-ipi

/lgtm

/override ci/prow/ci-index-upgrade-bundle

/override ci/prow/ci-index-upgrade-bundle

/override ci/prow/operator-e2e-upgrade

/cherry-pick release 4.12

/cherry-pick release-4.12


Add details to requirement for port 445 on Azure File Share.

Found it impossible to mount this on my mac on my home machine - and I believe I know why.
You have a point here:
"Ensure port 445 is open: SMB communicates over TCP port 445. On your client machine (the Mac), check to make sure your firewall is not blocking TCP port 445."
I don't block it, but guess who does.. my ISP, to protect me from open file shares. I assume this is common, and I recommend reflecting in that point that your ISP commonly blocks file sharing ports such as 445 and you may find it impossible to mount an azure drive on MacOS (and other OS's would be the same I imagine - you may want to document this on the linux/win pages too)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eb2cee16-c6e9-1758-5078-aa224ee12085
Version Independent ID: c1028f61-f7d9-a568-d01c-57d50afbc33e
Content: Mount SMB Azure file share on macOS
Content Source: articles/storage/files/storage-how-to-use-files-mac.md
Service: storage
Sub-service: files
GitHub Login: @roygara
Microsoft Alias: rogarana

#reassign: @khdownie

#please-close


Elixir 1.15 support

Prerequisite: I have installed the latest version (0.6.1) of mix_gleam.
My .tool-versions:
erlang 26.0.2
elixir 1.15.4-otp-26

Run mix test:
** (Mix) The task "compile.gleam" could not be found. Did you mean "compile.erlang"?

When I change the Elixir version to 1.14.5-otp-26, everything works fine, including the function calling gleam_stdlib in IEx.

Tagging @gleam-lang/elixir-team 🙏

@lpil I found that in the Elixir 1.15 environment, after using mix archive.install hex mix_gleam, adding mix_gleam to the deps, and running mix deps.get, it is possible to compile Gleam code and libraries normally in the 1.15 environment. For 1.14, there is no need to add mix_gleam as a dependency.

@Hentioe, please see try adding prune_code_paths: false to your mix.exs and doing a clean build.

@tynanbe In the Elixir 1.16.0-rc.0 environment, install the latest version of mix_gleam (0.6.2), add the prune_code_paths: false configuration, use mix_gleam perfectly without needing to add it to deps, thanks for your contribution!


CircleManager.create(json) Documentation Question

Two questions where the documentation seems lacking (or maybe I'm missing something basic):

I am working with the nativescript-mapbox plugin to bring it in line with Mapbox Android Native 7.1.2.

I am attempting to use the annotations plugin to draw a circle that resizes as the map is zoomed (using stops) and capture click events.
I noticed the create(json) method.
It says:

Circles are going to be created only for features with a matching geometry.
You can inspect a full list of supported feature properties in CircleOptions.fromFeature(Feature).

Is the JSON parameter it accepts a Mapbox style or just a geojson document? (the comment about feature properties is what is making me wonder.)
Is there an example somewhere?
When I call create() with either a mapbox style that works in mapbox-gl-js or with a simple geojson geometry I get no error but it returns an empty array and nothing is drawn on the map. I suspect I am missing something basic.
The style I've been using that works in mapbox-gl-js.
{       "id": 'testCircle',       "type": 'circle',       "circle-radius": 250,       "source": {         "type": 'geojson',         "data": {           "type": "Feature",           "geometry": {             "type": "Point",             "coordinates": [ -76.947041, 39.007846 ]           }         }       },        "paint": {         "circle-radius": {           "stops": [             [0, 0],             [20, 6000 ]           ],           "base": 2         },         'circle-opacity': 0.05,         'circle-color': '#ed6498',         'circle-stroke-width': 2,         'circle-stroke-color': '#ed6498'       }
I wasn't able to find an example of how this is supposed to work in the demos.

Is it possible to create a layer using the Circle layer and somehow capture click events on it using the Annotations plugin? The reason I ask is that the mention of ID_GEOJSON_LAYER seems to imply that maybe that's possible?

Hey @Yermo, thanks for reaching out!
The String that is accepted by the CircleManager#create method should be a simple geojson, for example this test file, with properties that define the options otherwise found in the CircleOptions builder (see the full list). Unfortunately, as Expressions are not considered per symbol, but rather per layer, those cannot be set from a JSON and can only be applied at the CircleManager level.
Under the hood, every manager has its own layer (that you pointed to) and exposes click listeners that are invoked after processing the return value of the MapboxMap#queryRenderedFeatures. You cannot route any external Layer click through the annotation manager, you'd have to implement this logic yourself.
Also, I'm now noticing that our API reference docs are not listing the possible properties because they come from a package-private method. We should probably move the list to the public method's javadoc. Keeping the ticket open until that's resolved.

Thank you for the prompt reply!
I have gotten the JSON you provided working. Excellent.
Is there support for 'stops' on the circle radius? I see a withCircleRadius() method that accepts a float.
With the Circle layer support I was able to use stops to resize the circle proportional to the zoom level. I don't see how that is done with the Annotations.

Unfortunately, annotation plugin doesn't support Expressions yet, https://github.com/mapbox/mapbox-plugins-android/issues/736 is tracking that.

Ok. Thank you again for the prompt reply.

One last quick question, what is the format of the argument to withLinePattern()? I see it's a string but there's no mention. I am guessing this is something similar to the dash-array feature of a LineLayer?
Thank you again for all your help.

Just a note for the documentation. It should probably mention that create( JSON ) requires the geoJSON to be a FeatureCollection. Passing it a single Feature does not seem to work (although it does not generate an error message, just an empty return value).

Yes, this is something we should improve as a takeaway from this ticket.
When it comes to the withLinePattern, you can read more about the argument in the style specification.

ah. Thank you.


UI improvement

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
UI Improved for Dark More make it more Generalize
Fixes:  #970
Description
Dark Mode UI Improved.
Improved the UI for "Testimonial" Section and "Personalize Recommendation" Section
This PR resolves Issue #970
[Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.]

Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]

Checklist:

[x] I have made this change from my own.
[x] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

I have made under the contribution of GSSOC-ext and HacktoberFest 2024

@OmmDevgoswami

Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


Throw an "No record exists with this ID" if no record can be found for a given ID

Especially data model of storage-type SQL should throw an error, if there is no persistent record for the input argument ID (<idAttribtue>).

This check, and possible error generation, should happen in the model layer. For generic models add a remark in the function comment (JSDoc) that such an error must be thrown if no record for the argument ID is found. Thus the programmer knows or is reminded to implement it in that way.

Done. Commit #4d47afb


make a bunch of tests look more like how they did before rustfmt

@bors r+

:pushpin: Commit 5aeba7f86bb099c079c079e5381a3d976e6f5fdc has been approved by RalfJung

:hourglass: Testing commit 5aeba7f86bb099c079c079e5381a3d976e6f5fdc with merge 4e67b63ad30683731c2bd0c2cea671641d1750fe...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 4e67b63ad30683731c2bd0c2cea671641d1750fe to master...


How to set the Point id?

How to set the Point id,or can I set the properties?

but how can I find the Point ? by 'x' and 'y' ?

These instructions appeared to work https://gis.stackexchange.com/a/317319/194831
from shapely import geometry

p = geometry.Point(0, 0)
p.uid = 'unique point'
print(p.uid)  # prints: 'unique point'

Thanks @sgillies, I'll try that out. I was also thinking I might concatenate the x and y positions into an index that can be re-created on the fly from the set of filtered points.

I was wondering, if we cannot set custom attr such as id to a point, how can we put points with attr into a STRtree and query those points to get the attr. It'll be very inconvient(if not possible) to implement such trick, which I used a lot to implement my algorithm unfortunately.
Is there way to get around?

we can use id() function in python.
points = [point0, point1, ...]
#createing a id map for poins
...
pointsMap = {id(point0): 'point0', id(point1): 'point1', ....}

points = STRtree(points).query(polygon)
for point in points:
    print(pointsMap[id(point)])  # --> this will print 'pointX'


Google fonts are imported, break HTTPs when protocol relative

Google fonts @import are resolved. Anyway it works when imported. The problem is, you can not keep URLs as protocol relative.
Consider:
echo "@import url(//fonts.googleapis.com/css?family=Lato:400,700,400italic);" | cleancss

which output:
@font-face {
    font-family: Lato;
    font-style: normal;
    font-weight: 400;
    src: local('Lato Regular'), local('Lato-Regular'), url(http://fonts.gstatic.com/s/lato/v11/v0SdcGFAl2aezM9Vq_aFTQ.ttf) format('truetype')
}
@font-face {
    font-family: Lato;
    font-style: normal;
    font-weight: 700;
    src: local('Lato Bold'), local('Lato-Bold'), url(http://fonts.gstatic.com/s/lato/v11/DvlFBScY1r-FMtZSYIYoYw.ttf) format('truetype')
}
@font-face {
    font-family: Lato;
    font-style: italic;
    font-weight: 400;
    src: local('Lato Italic'), local('Lato-Italic'), url(http://fonts.gstatic.com/s/lato/v11/LqowQDslGv4DmUBAfWa2Vw.ttf) format('truetype')
}

You notice that src url is in HTTP. It obviously break application when hosted in production, under HTTPs.
My question:

Is there a way to blacklist some URL in order to not import them ?
It will keep my url with protocol relative.

Thanks for response and thanks to contributors for this so useful module!

That's a good point indeed. The only way to stop it (so far) is to use --skip-import switch.

My workaround for now is to set HTTPs for loading font. So on font-face contains https link and it does not break production code.
Obviously I don't think that a good idea to resolve Google font import. Location of the files may changes.
Possible solution:

Add option for skipping remote import. It will disable fetching of remote @import and keep it intact. ?
Add option for defining exclusion mask ?

By searching in the repository I found https://github.com/petetak/clean-css/blob/698efdc1a387706ebfb36178677e539280e8abc4/test/unit-test.js#L770 . I don't find theses tests in the current code base. I am new to this project.
Thanks

I'll think of the best approach here, it could be even a combination of those.
Re that unit test, it's from an old version of clean-css when there was no remote importing at all, so all such URLs were kept intact.
Stay tuned for updates!

I found out the reason you see URLs changed from //fonts.gstatic... into http://fonts.gstatic... is due to Google rewriting them on the fly, e.g. curl "http://fonts.googleapis.com/css?family=Lato:400,700,400italic"
I added two features you suggested on a branch https://github.com/jakubpawlowicz/clean-css/tree/632-remote-import which will likely make to master. The syntax is as follows:
API: new CleanCSS({ processRemoteImport: ['!fonts.googleapis.com'] })
CLI: cleancss --skip-remote-import fonts.googleapis.com
To skip all remote imports:
API: new CleanCSS({ processRemoteImport: false })
CLI: cleancss --skip-remote-import all
Does it makes sense?
Any feedback is more than welcome!

Thanks for your work!
processRemoteImport will fix the issue! But I was thinking that it can be expand to all @import processing. It makes sense to skip import, regardless it is remote or not.
We can reuse the option processImport and use it as an array like processRemoteImport. An array is truely and so it will maybe not involve lot of modification.
Anyway processRemoteImport: false make sense too for allowing user to globally disable remote import.
API:
  new CleanCSS({
    processImport: [
      '!fonts.googleapis.com',
      '!./some/local/file.css'
    ]
  })

I think you have a fair point. How about adding some special keywords, like !local or !remote?

@LoicMahieu what's more, we'd need to go with an extra option, e.g. --skip-import-from / processImportFrom: ... as we can't overload CLI's --skip-import without a major version bump, something I am reluctant to do. This is a commander.js limitation which does not allow list arguments to be optional.
I would keep processImport as is and add an extra one now, and unify these two in the next major version.

I have just merged this change to master. The API is as you suggested with the exception of processImportFrom vs processImport option.

It's just been released with clean-css 3.4. :fireworks:
Thanks @LoicMahieu for all valuable input!

Awesome ! Thanks @jakubpawlowicz


[FEATURE] Skandha needs to capture TTP metrics

Is your feature request related to a problem? Please describe.
Presently skandha doesn't capture time-to-process (TTP) metrics for each UserOp submitted to it.
Describe the solution you'd like
Skandha will need to capture TTP metrics i.e the time taken between a UserOp being submitted to the RPC endpoint to the time it is relayed to the blockchain and the time that the UserOp is processed on-chain.

https://github.com/etherspot/skandha/pull/150


#1845 - Fixes issue with ComponentErrorHandler OSGi component never b…

…eing satisfied due to incorrect dependency on ModeUtil
OSGi console showing active now...

Here's the snapshot build..
acs-aem-commons-content-4.1.1-SNAPSHOT-min.zip
/cc @maurerstefan

Pull Request Test Coverage Report for Build 4337

2 of 5 (40.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.004%) to 52.15%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bundle/src/main/java/com/adobe/acs/commons/wcm/impl/ComponentErrorHandlerImpl.java
2
5
40.0%

Files with Coverage Reduction
New Missed Lines
%

bundle/src/main/java/com/adobe/acs/commons/mcp/impl/ProcessErrorReportExcelServlet.java
1
66.22%

Totals

Change from base Build 4335:
-0.004%

Covered Lines:
13087

Relevant Lines:
25095

💛  - Coveralls


meta(invariants): tracking issue for improvements to invariant testing

Component
Forge
Describe the feature you would like
This issue tracks invariant-testing specific improvements. General fuzzer improvements are in #4433.
Items are roughly ordered by my opinion of priority, both at the header-level and the bullet-level. I say "roughly ordered" because some items are much bigger scope than others so having a strict ordering doesn't make much sense.
High Priority
These would all give a big improvement to invariant testing UX and performance, and should not be too hard to implement
UX/Features

https://github.com/foundry-rs/foundry/issues/3005
https://github.com/foundry-rs/foundry/issues/4718
https://github.com/foundry-rs/foundry/issues/2985
https://github.com/foundry-rs/foundry/issues/2986
https://github.com/foundry-rs/foundry/issues/4352

Bugs

https://github.com/foundry-rs/foundry/issues/2962
https://github.com/foundry-rs/foundry/issues/4178
https://github.com/foundry-rs/foundry/issues/4287
https://github.com/foundry-rs/foundry/issues/4163
https://github.com/foundry-rs/foundry/issues/4381
https://github.com/foundry-rs/foundry/issues/4245

Misc

https://github.com/foundry-rs/foundry/issues/4162 — The terms we use are misleading so this worth clarifying / maybe renaming things a bit

Medium Priority

https://github.com/foundry-rs/foundry/issues/4951
https://github.com/foundry-rs/foundry/issues/585
https://github.com/foundry-rs/foundry/issues/4190
https://github.com/foundry-rs/foundry/issues/1578 — More thought is needed around how to detect reentrancy issues, so this one is likely more work than all of the above, but it could be very useful. Related is https://github.com/foundry-rs/foundry/issues/4245

Low Priority

https://github.com/foundry-rs/foundry/issues/4834
https://github.com/foundry-rs/foundry/issues/4300 — Listed as low because you can replicate this by calling functions at the end of each test
https://github.com/foundry-rs/foundry/issues/3452 — Needs more thought, but could be powerful
https://github.com/foundry-rs/foundry/issues/3607 — An invariantCallSummary test and similar approaches are decent workarounds, though this still would be valuable

Additional context
No response

Noticing a bit of flakyness with invariant tests recently, for example see: https://github.com/foundry-rs/foundry/actions/runs/10298801797/job/28504775878 / https://github.com/foundry-rs/foundry/actions/runs/10286582825/job/28467603861
cc @grandizzy

Noticing a bit of flakyness with invariant tests recently in the CI, for example see: https://github.com/foundry-rs/foundry/actions/runs/10298801797/job/28504775878 / https://github.com/foundry-rs/foundry/actions/runs/10286582825/job/28467603861
cc @grandizzy

yep, this should make it faster and avoid flakyness :crossed_fingers:  https://github.com/foundry-rs/foundry/pull/8634


upgrade to webpack4

The webpack has been upgrade to version 4.9.1.
All other dependencies have been upgrade to the last versions.
Add the support of sass-loader and less-loader.
The template has been tested under ubuntu 18.04LTS, node 8.10.0, npm 3.5.2
This pull resolves #593

@Haixing-Hu @SimulatedGREG I tried testing this on Windows, but I'm afraid I get this error:
`D:\Users\me\Desktop\f\desktop\node_modules\uglifyjs-webpack-plugin\node_modules\source-map\lib\source-map-consumer.js:20
return sourceMap.sections != null
^
TypeError: Cannot read property 'sections' of null
at new SourceMapConsumer (D:\Users\me\Desktop\f\desktop\node_modules\uglifyjs-webpack-plugin\node_modules\source-map\lib\source-map-consumer.js:20:20)
at UglifyJsPlugin.buildError (D:\Users\me\Desktop\f\desktop\node_modules\uglifyjs-webpack-plugin\dist\index.js:116:23)
at D:\Users\me\Desktop\f\desktop\node_modules\uglifyjs-webpack-plugin\dist\index.js:275:45
at Array.forEach ()
at D:\Users\me\Desktop\f\desktop\node_modules\uglifyjs-webpack-plugin\dist\index.js:259:19
at step (D:\Users\me\Desktop\f\desktop\node_modules\uglifyjs-webpack-plugin\dist\uglify\index.js:90:11)
at done (D:\Users\me\Desktop\f\desktop\node_modules\uglifyjs-webpack-plugin\dist\uglify\index.js:99:22)
at D:\Users\me\Desktop\f\desktop\node_modules\uglifyjs-webpack-plugin\dist\uglify\index.js:105:15
at D:\Users\me\Desktop\f\desktop\node_modules\worker-farm\lib\farm.js:191:19
at _combinedTickCallback (internal/process/next_tick.js:131:7)
at process._tickCallback (internal/process/next_tick.js:180:9)
error Command failed with exit code 1.`
During the npm run dev process.

Tried on macOS 10.13.5, node v10.2.1,
Same thing happened as @RomanScott

@RomanScott  @simon300000
Have you tried to delete node_modules AND package-lock.json, then npm install again?
Or simply delete yarn-lock.json and yarn again.
I recommend yarn since it's better at resolving dependency conflicts.

@Haixing-Hu
Yes, I tried running the install process, with both npm and yarn, multiple times on clean versions of your pull request (ones without a package-lock.json or a node_module.) I don't think the issue is dependency based, could it be operating system based since you were able to get it working on Ubuntu?

@Haixing-Hu
I used vue init to create a new project with your fork, so there should not be any problem with node_modules.
and used yarn, yarn run dev.

I had to change .electron-vue/dev-runner.js as well since webpack4 uses a new tap interface instead of pluginbasically I had to change all the compiler.plugin entries to compiler.hooks.compilation.tap also had to add a mode option to the configs after this webpack4 worked for me

@erikkallen Maybe you could push your modified to a fork and also pull request to @Haixing-Hu ?

@simon300000 I made the pull request you requested https://github.com/Haixing-Hu/electron-vue/pull/1

This works now for me. Thank you @erikkallen

You must also incorporate the mode property as described in the Webpack4 docs:
Change the following in both and at the bottom of the file:
/**
 * Adjust rendererConfig for development settings
 */
if (process.env.NODE_ENV !== 'production') {
    rendererConfig.mode = 'development'
    //...
}

/...

/**
 * Adjust rendererConfig for production settings
 */
if (process.env.NODE_ENV === 'production') {
     rendererConfig.mode = 'production'
    //...
}

That is indeed included in my pull request

From: Dov Benyomin Sohacheski<EMAIL_ADDRESS>Sent: Thursday, May 31, 2018 5:14:54 PM
To: SimulatedGREG/electron-vue
Cc: Erik Kallen; Mention
Subject: Re: [SimulatedGREG/electron-vue] upgrade to webpack4 (#620)
You must also incorporate the mode property as described in the Webpack4 docs:
Change the following in both and at the bottom of the file:
/**

Adjust rendererConfig for development settings
*/
if (process.env.NODE_ENV !== 'production') {
rendererConfig.mode = 'development'
//...
}

/...
/**

Adjust rendererConfig for production settings
*/
if (process.env.NODE_ENV === 'production') {
rendererConfig.mode = 'production'
//...
}

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SimulatedGREG/electron-vue/pull/620#issuecomment-393564263, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAff5LQtz97XKAQ5erdmvMyS7VIELYtHks5t4AjugaJpZM4UPUiJ.

Just tested this also on windows 10 with Node 8.11.1 & NPM 6.1.0 installed (through command prompt. Will attempt on WSL, usually I can get it mostly working via the --no-bin-links command. Powershell usually has no issues.
I installed every option I could and used eletron-builder.
Installation Screenshot:

npm run dev screenshot:

Vue Dev Tools shows up and is properly detected. Normal electron security warning. Haven't fully tested this yet, but at first run down everything is functional. I'll move some code into this and see if everything combines nicely.
Great work guys!!

I think eslint isn't working

After this update is there still a need for the full babel stack? babel-preset-env has been archived, and with the new version of Chrome 61 and Electron 2.0, the majority of translation has become obsolete.

https://github.com/SimulatedGREG/electron-vue/pull/625 has all changes (including optional removal of node-sass and sass-loader) in it, while this PR still lacks the changes @erikkallen submitted.

#625 has now been merged which updated to webpack 4.
This PR can now be closed @SimulatedGREG


cksum: generate CRC table in a const fn

This PR removes the build.rs file and simply generates the CRC table in a const fn.  The functions require Rust 1.33 (which I believe we are bumping to in #1724), but since const fn support wasn't that great until Rust 1.46, I had to implement a hacky macro that just unrolls the loops.  if statements are also not supported by Rust 1.33, so I had to work around that as well.  The code with both while loops and if statements is commented out, so once we switch to Rust 1.46 we can simply remove the workarounds and uncomment the code.

Could you please fix the "unnecessary trailing semicolon" ?

Should be fixed now.


Add OBH09's file

I have created a branch, mcreated a file nand made a commit, and opened a pull request

There is an issue with the change - try to make a new change.


Training and validation loss becomes NaN

While training the model, the ELBO of the training data or validation data or both sometimes becomes nan as it progresses, as shown below:
Epoch 99 (10.4 s):
    Evaluating model.
    Training set (3.42 s): ELBO: -1709.1, ENRE: -1692.1, KL: 16.986.
    Validation set (840 ms): ELBO: nan, ENRE: -inf, KL: 17.461.
    Saving model parameters.
    Model parameters saved (434 ms).

Step 4658 (213 ms): -1675.1.
Step 4662 (222 ms): -1843.4.
Step 4667 (216 ms): -1464.6.
Step 4672 (215 ms): -1736.6.
Step 4677 (219 ms): -1577.7.
Step 4681 (220 ms): -1729.2.
Step 4686 (221 ms): -1591.9.
Step 4691 (221 ms): -1784.
Step 4695 (217 ms): -1624.3.
Step 4700 (118 ms): -1770.2.

Epoch 100 (10.5 s):
    Evaluating model.
    Training set (3.4 s): ELBO: nan, ENRE: -inf, KL: 17.066.
    Validation set (858 ms): ELBO: nan, ENRE: -inf, KL: 17.572.
    Saving model parameters.

Due to this, the evaluation step also fails mostly as the ELBO of the test set goes to nan.
Best-model evaluation
---------------------

Evaluating trained model for run 13 on original values.
    Test set (1.36 s):  ELBO: nan, ENRE: -inf, KL: 20.367.
/usr/local/lib/python3.6/dist-packages/scvae/data/data_set.py:537: RuntimeWarning: invalid value encountered in true_divide
  self.normalised_count_sum = self.count_sum / self.count_sum.max()

Data set        mean   std. dev.   dispersion   minimum    maximum   sparsity
original       0.6013     25.922     1117.5     0            15631        0.87985
reconstructed  inf        nan        nan        3.3546e-10   inf          0.92008

and the following error shows up:
ValueError: supplied range of [3.3546437849807376e-10, inf] is not finite
I am currently trying to increase/decrease the number of epochs to bypass this issue. Otherwise, is there any other way?
I would also like to know if scVAE, when implemented on Google Colab, automatically makes use of GPU or we have to manually change it. I get a Colab warning that GPU is not utilised while training and it recommends to connect to local runtime.

This usually happens when the chosen reconstruction distribution (likelihood function) is not fit for the data set. Have you another distribution? Right now, the training will only be aborted if the ELBO for a batch becomes indefinite during training. I have added additional checks for the training and validation sets in the next version. So you should be able to evaluate the model afterwards.
I have not used Google Colab, so I'm not familiar with it. When I use scVAE on a local machine, TensorFlow use all available resources unless I limit it.

I am currently using ZINB distribution and I have not tried other distributions. Thanks for adding the additional checks!

This usually happens when the chosen reconstruction distribution (likelihood function) is not fit for the data set. Have you another distribution? Right now, the training will only be aborted if the ELBO for a batch becomes indefinite during training. I have added additional checks for the training and validation sets in the next version. So you should be able to evaluate the model afterwards.
I have not used Google Colab, so I'm not familiar with it. When I use scVAE on a local machine, TensorFlow use all available resources unless I limit it.

Sorry, I am using scvae version 2.1.4, but when I run it, I notice that it is still running on the CPU.
For example, in the code snippet at https://github.com/scvae/scvae/blob/d6148efabfb12eda8bd1b895e1bb72f592e39ab0/scvae/cli.py#L629C9-L629C9, if I want to run it on the GPU, I usually specify model = model.to(device). In TensorFlow, I might use with tf.device('/gpu:0'), but I haven't found a similar option here. The entire training process is happening on the CPU. If I am mistaken, please point out my error and let me know how to train on the GPU. If my understanding is correct, would it be possible to add an option like scvae train --gpu-id 0?


Player not Playering :(

Type
Player
Page URL
https://www.youtube.com/watch?v=hGlyFc79BUE
Branch
main
Version
0.7.1
A brief description
I've got a problem. When i click on any video possible ( also on the channel ) its just not working and there is no player. I got newest chrome btw
Screenshots or videos

Console output
No console output

no answer?


Implement inventory and program change logic for MP reporting frequency and eval status

Context

Add inventory status log table
Create a procedure that will execute logic to handle MP reporting frequency and eval status based on records inserted into the table

The logic will need to be collected from Mark

This ticket will need to be tested asa part of the CDC changes.  Only those with direct access to the database can test this

Testing is blocked by https://github.com/US-EPA-CAMD/easey-ui/issues/5997


☣ Issue dispatching hcom for sigma types

When messing around with some ideas that @cangiuli had regarding records, I came across the following crash:
import prelude
import hlevel

-- Equivalences.
def fiber (A : type) (B : type)  (f : A → B) (b : B) : type := (a : A) × path B {f a} b

def is-equiv (A : type) (B : type) (f : A → B) : type := (b : B) → is-contr {fiber A B f b}

def equiv (A : type) (B : type) : type := (f : A → B) × is-equiv A B f

def equiv/id (A : type) : equiv A A :=
  [ x => x,
    x => [
      [ x , i => x ],
      fib i =>
        let aux : 𝕀 → A := j =>
	  hcom A 1 j {∂ i} {j _ => [
	    | j=1 ∨ i=0 => x
	    | i=1 => {snd fib} j
	    ]
	  }
        in [ aux 0, aux ]
    ]
  ]

#normalize {equiv/id {(x : type) × x}}

This crashes with:
[DEBUG] dispatch_rigid_hcom: lam[clo[lam[<anon>, el/out[ap[ap[var[2], var[1]], var[0]]]] ; [
[
] ; [ <let-sym> ]]]]
Core.Semantics.NbeFailed("Invalid arguments to dispatch_rigid_hcom")

I suspect that there's something fishy going on here with hcom_sg... It's worth noting this is fine for say, (x : type) × nat

Here's a more minimal repo:
def test : (x : type) × x :=
  hcom {(x : type) × x} 0 1 ⊥ {j _ =>  [ j=0 => [ nat, 4 ] ] }

After a bit of poking around, it seems that the crash happens when we try to evaluate the cap of the Box by test...

could it be caused by #288 ? LOL

Oh that could totally be it!


Progressively enhance school search with autocomplete

To make the user experience smoother and easier for claimants, we want to offer autocompleting school search in the claim process.

This change adds autocomplete to both school searches, with the following caveats:

If JavaScript doesn't load, we fallback to the existing search functionality.
If no option is selected from the autocomplete menu, we fallback to the existing search functionality.
If the user edits the field, we fallback to the existing search functionality.

It also turns on selecting inputs by their labels. This is needed because  the headless_chrome Capybara driver doesn't detect the inputs styled as they are by the GOV.UK frontend.
Search term length validation has been moved to the model instead of the controller to support reuse.

 School search enhancement: autocomplete

@robbiepaul Ready for another look. Also, did you capture the modal dialog issue?

@erbridge I'll have a look now.
I just wrote a card in the dev backlog for it: https://trello.com/c/MASVTXgH

@robbiepaul Could you give this another once over, please. The rebase was a little involved, and I realized that I wasn't handling the case where the user returns from checking their answers.


CodeActAgent to delegate to BrowsingAgent

Let CodeActAgent delegate to BrowsingAgent for browsing tasks. With this PR, CodeActAgent could also pass the test test_browse_internet - which it couldn't before because that test requires locating a button and clicking on it.
Closes #1945

👍👍👍👍 Expecting this feature for a long time. Firstly I want to confirm, if this means when running CodeActAgent should not lauch a browser env? Only BrowsingAgent does this after all browse action modified to this delegate agent mode. @li-boxuan

if this means when running CodeActAgent should not lauch a browser env?

@assertion No it has nothing to do with browser env. At the moment, a browser env is always launched regardless of the agent.

No it has nothing to do with browser env. At the moment, a browser env is always launched regardless of the agent.

Yes, this is true right now. I mean if browse action delegated to BrowsingAgent, starting a browserEnv for other agents like CodeActAgent is not reasonable.

No it has nothing to do with browser env. At the moment, a browser env is always launched regardless of the agent.

Yes, this is true right now. I mean if browse action delegated to BrowsingAgent after this pr, starting a browserEnv for other agents like CodeActAgent is not reasonable.
Well, this is actually an optimization that can reduce the number of started processes during agent running.

I mean if browse action delegated to BrowsingAgent, starting a browserEnv for other agents like CodeActAgent is not reasonable.

That's a good point. We probably could refactor how runtime and agents interact. A similar problem is AgentSkills are always installed even though not every agent uses it. Let me create a thread on slack so that we could discuss this more.

I mean if browse action delegated to BrowsingAgent, starting a browserEnv for other agents like CodeActAgent is not reasonable.

That's a good point. We probably could refactor how runtime and agents interact. ~A similar problem is AgentSkills are always installed even though not every agent uses it.~ Let me create a thread on slack so that we could discuss this more.
UPDATE: I quickly checked AgentSkills code and seems it's only installed for CodeActAgent. UPDATE2: Created https://opendevin.slack.com/archives/C06QKSD9UBA/p1716952778225289

Love this, making it optional can save a lot of resources.

This is exciting!

I am putting this PR on hold so that it doesn't affect current evaluations.

Discussed with @xingyaoww offline and we will put the second issue on hold:

when it finishes, the frontend will repeat the message (one from the Browsing Agent, one from the delegator), It even got a little empty box in the middle

I don't have a good way to solve it right now. If browsing action is just a subtask of the original big task, then user won't feel any redundancy, but if the user simply gives a browsing task, then indeed they would feel the agent is repeating itself. We might need to think about the interactive design better to not confuse users.

Hello @li-boxuan
this looks like an issue right now for failing integration tests:
https://github.com/OpenDevin/OpenDevin/blame/45ce09d70ec9e46ded03df3b168f684e030c6dee/tests/integration/mock/CodeActAgent/test_browse_internet/prompt_003.log#L121
Diff:
--- /home/runner/work/OpenDevin/OpenDevin/tests/integration/mock/CodeActAgent/test_browse_internet/prompt_003.log	2024-06-07 09:06:47.574055654 +0000
+++ /tmp/tmpezug6yc1	2024-06-07 09:17:54.012024643 +0000
@@ -118,14 +118,13 @@
 	[8] heading 'The Ultimate Answer'
 	[9] paragraph ''
 		StaticText 'Click the button to reveal the answer to life, the universe, and everything.'
-	[10] button 'Click me'
+	[10] button 'Click me', clickable


How to detect which component where the current element comes from?

What problem does this feature solve?
wanna find current element belong which component when I click some element
What does the proposed API look like?
maybe mix with synthetic event?

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server or StackOverflow.


Problem with inner scheduler

I have several batch jobs (*.sh scripts) to pull data from mssql server. It seems like schedules I`ve cobfigured are not working. I have one job set to "schedule" : "* 0/10 * ? * *" and another with "schedule" : "* * * ? * *" . Both call stored procedures on SQL side wich logging themselfs to the log-table. And I see this two batches running every 6-7 sec regardless of schedule settings

May be ... UP?


Combination of HDU and save=True arguments to radiometric calibration

If an HDU is passed instead of a str containing a path, the code will attempt fitsHdu[-5:] + '_rc.fits'. Which is an issue that should be checked somewhere. This is likely an issue if a list is passed too.

This has been fixed by getting the filename from the astropy fits object and not a string. It was a very hacky approach to be fair.


ISPN-15060 Provide a proxable Cache API to get create queries

https://issues.redhat.com/browse/ISPN-15060
Draft => Before to finish the implementation, I need to double-check with @tristantarrant if this was the idea he described on the chat. done!

Nice. I think we should deprecate the SearchFactory hinting at the "new" way. Please also work on the docs

Thanks for the review!
I applied the changes and also simplified the solution a little (I removed QueryProvider(s)).
About the deprecation I deprecated QueryFactory#create(queryString), I don't know if we can deprecate the Search#getQueryFactorys since they contain other methods we're not replacing with the new API.

@fax4ever anything else needed ? docs only ?

@fax4ever anything else needed ? docs only ?

Yes. We need a feedback on the doc update only and I think that we can merge it.

@fax4ever @domiborges do you have some time to review this or may we open a follow up jira for query docs ?

Hi! I'll check it in the afternoon

Hi! I'll check it in the afternoon

Thank you @domiborges

wow 3 approvals :)

Thank you @karesti


Xnero: Watch fixmyprinteroffline.com

Xnero requests the watch of the watch_keyword fixmyprinteroffline\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

fixmyprinteroffline\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


Big cleanup

A lot of issues piled up. Before we even get to tech debt (we will!), let's fix a collection of small annoyances that got left behind.
Below are all the easily-fixable issues that were still relevant. The others are either ongoing or closed now due to being obsolete.
Fixes #172: allow codegen to output nil for empty slices.
Fixes #228: improve TLA+ Go library naming, mostly by removing TLA when you'll call that thing tla.Thing anyway
Fixes #223: remove the last "maker"

@shayanh I think this is ready to merge now.
Last item would be to rename master to main; we can do that right after maybe.


Text Generation Stream not cleaning up properly on AbortSignal

System Info
Running the publicly available image on GHCR on an ubuntu host:
sudo docker run --name llmserver --gpus all --shm-size 1g -p 8080:80 -e CARGO_LOG="debug" -v /home/user/data:/data ghcr.io/huggingface/text-generation-inference:1.3 --model-id <model_id_here>  --quantize awq --max-batch-prefill-tokens 1500 --max-total-tokens 1300 --max-input-length 1200 --max-batch-total-tokens 1500

Information

[X] Docker
[ ] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction
Follow up to https://github.com/huggingface/text-generation-inference/issues/1130. We use streaming for text generation and I implemented an AbortSignal to drop the request under custom stopping criteria.
However, I noticed a few things:

The INFO log doesn't show up for the aborted stream.
I don't think Prometheus metrics (e.g. tgi_request_count) are updated either.
Most importantly, after a couple of aborted requests, we see these two errors consistently for the following stream requests:

Out of available cache blocks error: https://gist.github.com/swarupsrini/325355eb512a83b848122a7ade09e15b
CUDA out of memory error: https://gist.github.com/swarupsrini/08e5e818274d5cbc7a3fbd922503fc5b

Expected behavior
Semantically, I understand that an aborted connection seems like an incomplete request, but for our use case it is complete. I think there's no alternative for us right now if we want custom stopping logic (even regex would suffice but the server doesn't seem to support that).
I think most important are the errors we see consistently after a couple of aborted requests. My suspicion is that perhaps the proper clean-up process after each completed request was not done for any stream requests that were aborted, so I'm filing this issue in that case.
Happy to hear any thoughts/suggestions!

Bumping this since I think it's still a bug in the latest version. I think the issue could be in the generate_stream method - I'm suspect that parts of the clean up code aren't triggered during an abort signal.
https://github.com/huggingface/text-generation-inference/blob/ec6d4592d59c136ea1d2cac3b4e2a7ea004a0ce3/router/src/server.rs#L333

We ran a script that submitted 50 requests of 1600 tokens each and aborts mid-way, but this didn't cause any errors. However, when we deploy to production, we see these errors for most incoming requests after an unpredictable amount of time (~5 min - 4 hrs).

@OlivierDehaene tagging since you worked on this portion the most. Sorry for the ping, but I did do a lot of testing and think this is a bug in the code so would appreciate your thoughts here!

Just ran some more tests, and got this error after a couple of streams with abort signal sent.

Do you get the same error when not aborting?
I don't think aborting is the issue as the cleanup code is exactly the same when aborting or not. It's possible that the issue comes from a miscalculation of the total free memory at warmup.
Can you try with MEMORY_FRACTION=0.8 for example?
What model is it? Can you share the output of --env?

Do you get the same error when not aborting?

Not at all. We had our model deployed for ~2 months now without any errors and day I tried to use abort signals again, I saw this error after ~10 minutes. So I'd be quite surprised if this is not related to the aborting.
I did notice that we don't see the SUCCESS log for any of the aborted requests, and it shows up as a failed 'dropped' request in the metrics, so I'm wondering if a lot of these aborted requests is causing any memory leaks.

Can you try with MEMORY_FRACTION=0.8 for example?

I set MEMORY_FRACTION=0.9 this morning and turned aborts back on, and we haven't seen any issues yet. Will report back if any issues! So your miscalculation theory makes sense, but it is strange since the warmup calculation should be independent of aborted requests.

What model is it? Can you share the output of --env?

https://gist.github.com/swarupsrini/10aec0163ed8e44359c254f691c87e32

Maybe when you abort you increase the concurrency?
The code when filtering a batch because requests went to completion vs the code filtering a batch because some requests were dropped trigger the same cleanup logic.


Update code-snippets.md - fix example code

The sql.json file needs an open brace at the top of the file and a closing brace at the bottom to be a properly formed json file.
Once I added the braces, the sample works great when you select all and delete the content in the original sql.json file.

@billramo : Thanks for your contribution! The author, @stevestein, has been notified to review your proposed change.

@yualan can you please review.

Approved