[REQ] Compatibility

Acknowledgement of preliminary instructions

[x] I have read and acknowledged the preliminary instructions.

What idea do you have?
add Compatibility to prefered lighting technology

not possible

why?

because its just not

why?

There isn't a way to externally enable it unlike the other lighting modes.


User - Nav - Change Sign in with Github to Upload Game

Background
Users who are coming to Game Box to host/play games do not need to sign in to Github. In order to eliminate confusion, it was requested that we remove the Github sign-in link from the navigation.  The purpose of this ticket is to revert the link back to Upload Game and have a sign in page that you are directed to when you're not logged in if you attempt to go to the Upload Game screen.
Scenario: Change Sign in with Github to Upload Game
Given I am a user

[x] When I am viewing the nav
[x] Then Sign in with Github is removed
[x] And I see Upload Game

Scenario: Upload Game goes to Sign in with Github
Given I am a user

[x] When I click Upload Game
[x] Then I am take to the Sign In page
[x] And I see the following instructions:

[x] To upload a game, you must first sign in through Github. Click the link below to authorize GameBox.

[x] And I can click a link to Sign in with Github

done with #85


UV tool feature request

[x] move all (maybe just squares?) faces to the 0,0, 0,1, 1,0, 1,1 corner

[x] optimize space by rounding uvs, to single digits

seems like we already have a round UVs function, and implemented the move all UV coordinates to the 0-1 square for space optimizations.


Exclude Unity's *_DoNotShip directory when uploading to Steam

Context
Unity builds include a folder which you're not supposed to publish to players, maybe with debugging symbols or what not. The folder is suffixed with "_DoNotShip".
A straightforward game.ci pipeline which builds and then deploys will result in that folder being deployed to Steam.
I think it'd be good for this action to automatically exclude it as it's something that, AFAIK, should never be included and can be handled automatically (just like the "*.pdb" exclusion that's already hardcoded in here).
Suggested solution
I think using Steamwork's FileExclusion thingo that's very briefly described here is the way to go but I personally couldn't get it working - dunno what I'm doing wrong. Maybe more eyes on the problem can figure it out?
Two exclusions I tried (separately) were:
  "FileExclusion" "./$currentDepotPath/${currentDepotPath}_BurstDebugInformation_DoNotShip*"
  "FileExclusion" "${currentDepotPath}_BurstDebugInformation_DoNotShip*"

This evaluated to:
  "FileExclusion" "./StandaloneWindows64/StandaloneWindows64_BurstDebugInformation_DoNotShip*"
  "FileExclusion" "StandaloneWindows64_BurstDebugInformation_DoNotShip*"

and this exactly matches the name from what I see after downloading the game in Steam... Not sure why it's not working.
Considered alternatives
If we can't get FileExclusion working then we could go more hacky and move the folder out, do the upload, and then replace it?
Additional details
Nothing further to add.

I did a more extensive test of FileExclusion stuff and one of all these actually did the job:
  "FileExclusion" "${currentDepotPath}_BurstDebugInformation_DoNotShip*"
  "FileExclusion" "./${currentDepotPath}_BurstDebugInformation_DoNotShip*"
  "FileExclusion" ".\${currentDepotPath}_BurstDebugInformation_DoNotShip*"
  "FileExclusion" "./$currentDepotPath/${currentDepotPath}_BurstDebugInformation_DoNotShip*"
  "FileExclusion" ".\$currentDepotPath\${currentDepotPath}_BurstDebugInformation_DoNotShip*"
  "FileExclusion" "$currentDepotPath/${currentDepotPath}_BurstDebugInformation_DoNotShip*"
  "FileExclusion" "$currentDepotPath\${currentDepotPath}_BurstDebugInformation_DoNotShip*"

Now to figure out which one 😆 But yeah, this can work.

If I can figure out which one, is this something you'd like me to make a PR for, or are there any other concerns to be addressed first?

As far as I can see there wouldn't be anyone who'd want to ship this. I think it would be worth documenting which paths are excluded. Probably paths for UE will also need to be added in the future, so a section about it would be good i think.
Already deleting the folder in a previous step, like in builder for example, also wouldn't make much sense I think, as artifacts might not be exclusively used for deployment, but also for debugging and maybe other purposes as well.

We will soon find out which one works 😛

Ok I'll add an Excluded Files section to the README and make a PR for this.


Support more Literal types in JSON::Serializable's use_json_discriminator macro

This PR supports the following Literal types as keys for hashes passed to use_json_discriminator:

StringLiteral
NumberLiteral
BoolLiteral
Path

This allows more types to be expected from a discriminator value. Previously, use_json_discriminator was hard-coded to expect a string value. String, boolean, and integer values are now supported. An example:
require "json"

enum Shapes
  Point
  Circle
end

class Shape
  include JSON::Serializable

  use_json_discriminator "type", {Shapes::Point => Point, Shapes::Circle => Circle}
end

class Point < Shape
end

class Point < Circle
end

Shape.from_json %({"type": 0}) # a Point
Shape.from_json %({"type": 1}) # a Circle

Thank you!
Do you have an example API in mind where this can be useful?

@asterite My specific use case is discriminating Channel objects from Discord's API into their respective types. Discord uses integer enums explicitly to describe object types. I tried implementing an enum similar to the example I give in the original comment, but the old implementation expects a string over an integer for the field value.
Implementing Path and NumberLiteral fixes this, but I also added BoolLiteral as it's easy to support, and perhaps one day there'll be some API that decides discriminating object types by a boolean field is necessary!

Strange, I think enum should support deserialization from int and string, instead of this PR.

The main issue is that previously discriminator_value was always fetched by pull.read_string, but the value is not always a string.

Oooooh... got it! Sorry, I should have looked at the link you sent, I was on mobile.
Yeah, it makes perfect sense then. 🙏

pardon my asking @bcardiff, but is this going in 1.0.0?

Probably should do this for YAML too no?

Probably. Didn't think of it/need it when I opened this PR. I may get around to it in some time.


auto_moderation_action_executed.json

Summary
It is missing the user_id field.
How it should be?
It should have the user_id field under rule_trigger_type.
What file is it?
auto_moderation_action_executed.json

Fixed in e2cdf991ab906424e6d4e5e52d7b6e931a4a39f3 😅


Proposed crypto_box encryption.

Signed-off-by: Daira Hopwood<EMAIL_ADDRESS>

I wouldn't count this as a review, but I think it this looks great. :)

(Minus missing citation.)

Closing this to retarget it to master.


Chrisda to Main

Docs Build status updates of commit 0fb4c3f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-online-powershell-v2.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 90a4dae:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-online-powershell-v2.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/New-AntiPhishRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/New-HostedContentFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/New-MalwareFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/New-SafeAttachmentRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/New-SafeLinksRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-AntiPhishRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-HostedContentFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-MalwareFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-SafeAttachmentRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-SafeLinksRule.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 1569f33:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-online-powershell-v2.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/New-AntiPhishRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/New-HostedContentFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/New-MalwareFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/New-SafeAttachmentRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/New-SafeLinksRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-AntiPhishRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-HostedContentFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-MalwareFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-SafeAttachmentRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-SafeLinksRule.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add demo3 for KPI Inference Model

This PR resolves #94 and adds a modified version of demo1-create-tables.ipynb to push demo 2 prediction results CSV into trino.
The raw data from the csv is now ingested to Trino.

Pipeline run to ensure demo3 notebook also runs in automation:
http://ml-pipeline-ui-kubeflow.apps.odh-cl1.apps.os-climate.org/pipeline/#/runs/details/b1a77585-1938-4cf9-b729-dd369b1ef377

@Shreyanand and @chauhankaranraj, we have resolved all your comments. Please take a look :)

Also added a pipeline file for demo 3 to ensure that the notebook runs in automation.

Updated table on Trino:


Can't access wordpress through IPV4

Description
Ninja, 2.3.0-alpha6
I can't access the WordPress instance through the IPV4, while I can do that normally through the yggdrasil.
ssh: connect to host <IP_ADDRESS> port 22: Connection timed out

A clear description of the bug, including relevant identifiers like:
Twin ID: 7189
Node ID: 492
Farm ID: 15
Contract ID: 145655
Steps to reproduce

Navigate to the Dashboard.
Connect your wallet.
Navigate to Applications.
Select Wordpress.
Turn on IPV4 from the Network tab.
Select a Node and a domain.
Deploy.

Out of tokens, I'm blocked on #2287

@A-Harby

tested on node 342 and it works fine
Screencast from 11-02-24 15:03:00.webm

I was able to deploy and ssh to WordPress through Ygg.

Will wait for the release on other networks for a free ipv4.

verified on devnet
version : 5c12959
made a wordpress deployment using public ip and mycelium and yggdrasil

could connect to it using the 3 ips

wordpress deployment


Render Expr2::InvalidLookup with red underline

Also add visible flag to UnderlineStart to be able to hide erros when the user is typing.

Editor is no longer being worked on, and has been removed from the repo. Closing.


Cannot find Child addon: 253171 Version <IP_ADDRESS>

I get to about 130/180 mods installed and that message pops up everytime. I have tried 5 times to install the modpack and the error "cannot find child addon: 253171" comes up each time. I dont think its at the same mod each time, but i cannot be 100% sure about that. Any help would be great, this mod pack looks really fun and id love you play it.

I had looked but i did not see the same issue.  Curse was taken over and Twitch replaced the launcher. Ill go look at the other post.

May want to try using portablejim's tool. It works for windows, iirc.
It's a curse/twitch issue with the manifest, though. It happens off and on due to something on their end, unfortunately.

I will go ahead and try on the Twitch launcher again, if it doesnt ill for sure try Portablejim's tool.

Ok may be really easy to find, But im not finding portablejim's tool. Im a major noob i guess.

Googling "portablejim curse downloader" should pop it up.


openssl pkcs12: convert pass phrase to UTF-8 when exporting

To create standard compliant PKCS#12 objects at all times, we must
ensure that the pass phrase is UTF-8 encoded.  This relies on locale
(or the code page on Windows) being set to match the input method.

Should this be backported to 1.1.0 as well?

As for backport to 1.1.0. Hmmmm... tricky one. It's all about balance between what is expected to work and what can get broken. Well, on Unix it doesn't matter much. In sense that you're unlikely to break more expectations. It's rather about Windows... A bit of history. OPENSSL_WIN32_UTF8 is an opt-in option, right? But I originally suggested to make it opt-out. It was argued against. Unfortunately I don't recall the counter argument. But whatever it was one can wonder how does it affect this suggestion. For example is it appreciated that it's possible to create non-compliant PKCS#12 on Windows? One that can be used even with 1.0.x? Specifically on Windows that is. If so, is it appropriate to change that in minor release? Since I think that OPENSSL_WIN32_UTF8 should have been opt-out, I feel kind of biased. I mean I would tend to say that it would be appropriate to backport, but I can't be sure that my judgement is unaffected.

Regarding backport, please note that this affects pass phrases for the creation of PKCS#12 objects only, while OPENSSL_WIN32_UTF8 affects all console input, such as pass phrases for decryption. That's a huge difference.
I assume you have already noted that this PR does not force UTF-8 on decryption. That's intentional.

I chose to set the label 1.1.0 as well, because I think we need to stop producing PKCS#12 objects exported with non-compliant pass phrases, and we need to do that immediately wherever possible.
This doesn't stop anyone reading non-compliant PKCS#12 objects, and doesn't change libcrypto.

Red cross from appveyor is relevant.

BTW, regarding remark in #6341 about mbstowcs producing different results on different systems. Seems real. For example on Mac OS X it work with any non-UTF-8 locale as if it was iso-8859-1 :-( I have no option to check Solaris, as my VM has only C and UTF-8 locales...

Yeah, I saw that remark. Looks like we may need to play with iconv, which I hope is OK in the app...

I am strongly against added iconv as a dependency and will force a vote if it gets included.

Awright, I've had it.
How about you tell me how to do locale->UTF-8 conversion in a manner that doesn't ruffle your feathers!

Don't try to do it.

So we should continue to produce non-compliant PKCS#12 objects in case of locales that aren't ISO-8859-1 or UTF-8? Or should we refuse to produce such objects in those locales?

Sometimes the cure is worse than the disease.
If we can determine the locale, in a low-effort and portable way, we can output a warning.

I really don't understand the objection to iconv, which is basically required for fixing things properly. You can always make it optional and emit warnings if it was needed and isn't present.

Note Linux != glibc

Right. You can't do this properly without handling encodings correctly. We have had enough of magical thinking.
Anyone suggesting otherwise should be required to provide a full example of what every application would need to do to "Get It Right" in a world where OpenSSL continues to wilfully bury its head in the sand. And of course the openssl(1) applications should also Get It Right.

Note Linux != glibc

If it's remark to suggestion to use || defined(__linux), and implicit suggestion is to use || (defined(__GLIBC__) && __GLIBC__>=2 instead, then it's fair point. If not, then you have to elaborate.

I would much rather use iconv than create another mess of special cases...

As if iconv by itself is not a mess of special cases. That's by the way why I would suggest run-time detection :-)

and if we restrict things to just Windows and Linux, what about the rest?

What about it? :-) :-) :-) But on serious note one has to keep in mind that as long as input method is UTF-8 everything just works. If input method is not UTF-8, then system doesn't interoperate with anything else but itself(*). I'd say it's fair limitation.
(*) One can say that it could interoperate with another non-UTF-8 system, but one can as well just choose to not leave that kind of guarantee.

Anyone suggesting otherwise should be required to provide a full example of what every application would need to do to "Get It Right".

This is unreasonable requirement. Because those who don't suggest otherwise would have as hard time doing it right. Thing is that there is no general solution and you're bound to solve separate platform-specific and a number of corner cases.

To summarize. I would suggest to a) fix appveyor problem; b) complement __STDC_VERSION__ check with __GLIBC__>=2; b) make mbstowcs conversion dependent on __GLIBC__>=2; d) detect if locale is UTF-8 and display a warning if it's not(*). iconv would have to be separate request in either case...
(*) Note that warning would precede password prompt, which is the best spot to have it.

b) make mbstowcs conversion dependent on GLIBC>=2; d) detect if locale is UTF-8

One can naturally flip the two. That is first detect if locale is UTF-8, and if it's not, call mbstowcs on __GLIBC__>=2 platform or display a warning...

My short answer is that I agree with @dot-asm's points he just made.

In particular, this point, 10,000%

as long as input method is UTF-8 everything just works. If input method is not UTF-8, then system doesn't interoperate with anything else but itself. I'd say it's fair limitation.

So you're still saying that it's perfectly OK to produce broken files.

In particular, this point, 10,000%

as long as input method is UTF-8 everything just works. If input method is not UTF-8, then system doesn't interoperate with anything else but itself. I'd say it's fair limitation.

I want to remind that this was said in context of "what about the rest" question! I meant that it would be fair limitation for the rest. One also has to keep in mind that there always will be some rest! We can only control how large this rest is, but we just have to accept that there will be systems that wouldn't interoperate with anything but themselves [unless they provide UTF-8 input method].

So you're still saying that it's perfectly OK to produce broken files.

If you are going to phrase it that way, yes.  If you would phrase it more properly, "if the system doesn't have UTF8 input" then even more strongly yes.

Having read up a bit, I think that if possible, iconv can be used as a last resort.  For systems where we know that wchar_t is UCS-x, just use it and do the conversion to UTF-8 internally.
I'm putting this back as WIP for the moment.  Among others, I want to experiment with dynamically checking for the existence of nl_langinfo and iconv ...

@richsalz, as for our dispute, I'd rather side with not producing a PKCS#12 object at all rather than producing a broken one.  In other words, if for some reason we cannot ensure in apps/pkcs12.c that the pass phrase is encoded in UTF-8, we bail out.  How does that sound to you?

I'm backing away from the idea of dynamic check, at least with regards to nl_langinfo, for the simple reason that I see no guarantee that CODESET has the same value across systems, so we need to include the appropriate headers anyway, and i think that renders the idea of dynamically checking for them a moot point...  (also, should someone choose to configure to link with a static libiconv, I'm thinking the result will be disappointing)

As for not producing a PKCS#12 object at all. I'd say that at the very least we can't make that drastic change in minor release. But I for one would argue that it would be unsuitable even for major release. Because it's just a storage, and more importantly private one. I mean storage per se is not exclusively about interoperability with other systems, even less so private. I mean the rationale behind suggestion to not produce PKCS#12 is interoperability, right? But that kind of data is less likely to be even moved from system, i.e. it doesn't have to be interoperable.

Another thing. I've already expressed reluctance about backporting original version to 1.1.0. But if we start throwing in iconv, it would be even less right, i.e. wrong.

@dot-asm, just reading the RFC indicates that PKCS#12 is meant to be an interchange format for personal information.  So I would say that interoperability is a central part here, i.e. it's meant to be a bag of stuff you can transfer from one personal system to another.

Travis and Appveyor faults noted, seemed like pretty simple stuff to correct

Are there any reasons why one would use PKCS#12 instead of PEM files with PKCS#1/PKCS#8 objects, that don't involve interoperability either with other computer systems or with potentially standards-compliant software running on the same system?

RFC indicates that PKCS#12 is meant to be an interchange format for personal information.

Is it prohibited to be used as private key storage? I mean is it actually so that if you create PKCS#12 object, then you have to take it to another system?

RFC indicates that PKCS#12 is meant to be an interchange format for personal information.

Is it prohibited to be used as private key storage? I mean is it actually so that if you create PKCS#12 object, then you have to take it to another system?

Counter question: is it prohibited to be used as interchange format?  Come on!
We don't have control over what the user will do, so adhering to standards is better than giving flippant arguments.
That being said, it's easy to add a flag -nointerop, to allow non-interoperable objects.

Ah, yeah, thanks, good idea...  and that probably narrows everything down quite a bit

Re current Travis issue, is iconv a standard system library on Mac OS/X?  In that case, I don't see a problem with having -liconv in our darwin configs

If -liconv makes its way into any config, I'll ask for a vote.
The idea of saying "no non-ascii unless you do -unport" (or some other new flag) is a good one.

It turns out that VMS doesn't have Unicode as inner wchar_t storage.
(lucky for me then, VMS has iconv built into the standard C RTL)

The idea of saying "no non-ascii unless you do -unport" (or some other new flag) is a good one.

Sure, as last resort.
Let's remember that we ask of others to ensure UTF-8.  Others often look into our code for examples on how to do things (hell, I did, back in the days...).  Giving them the example "let's avoid anything that's not ASCII" is a pretty shite example, if you ask me.  I'd like to raise the bar where I can.

The idea of saying "no non-ascii unless you do -unport" (or some other new flag) is a good one.

Is the -noimport flag good enough for you?

You could add another flag that says 'the bytestring you get is utf8'

In practice, -noimport does exactly that.

This could do with test cases. In particular I think the case of -passin on the command line on Windows with OPENSSL_WIN32_UTF8 set is going to get it wrong.

This could do with test cases. In particular I think the case of -passin on the command line on Windows with OPENSSL_WIN32_UTF8 set is going to get it wrong.

Defining that envvar is, for intents and purposes, like setting the locale to xx_XX.utf8.  The only difference here is that we know that input from cmd won't be UTF-8, so we have this input method to correct that case specifically.
On Unix, you're just as screwed if you have the locale xx_XX.utf8 and your pass phrase source isn't encoded accordingly.  I don't think there's an easy fix for that, and trying to solve it is beyond the ambition of this PR (which is already ambitious).

Yeah, on Unix if your input isn't actually in the encoding indicated by the locale, all bets are off. We shouldn't waste time on that one. Windows is different though because Windows does still use the legacy 8-bit locales for all its non-wchar functions including main().
Given that you are doing this conversion within openssl(1) surely you can know whether the passphrase came from the PEM callback or from the command line, and convert it appropriately? That bypass for OPENSSL_WIN32_UTF8 should only happen in the former case, surely?

You seem to be confusing things. OPENSSL_WIN32_UTF8 tells openssl(1) and lib crypto to convert exactly two things from CP_ACP to CP_UTF8: pass phrase prompting and command line arguments, both of which are expected to be typed in in cmd. Everything else (such as the contents of a file that's passed as argument to -passin) is expected to be properly UTF-8 encoded.

Right, it was the command line arguments I'd missed — I didn't think we were doing the conversion on -passin:pass:♥. Thanks for confirming that we are indeed doing that.
Do we also get -passin:file:♥ right?

I have no idea re the latter. That would be a matter for a different PR

Rebased and fixed up (they were waaaay too many fixup commits at this point)

... and out of WIP.

There's one last question that needs dealing with...  iconv availability.  The safe method would be to make that opt-in, i.e. any config target where we want to use it would need to define OPENSSL_USE_ICONV or something like that.  I hate that this would make everyone else ASCII only, but I think this is the way forward, and that makes it possible to calmly add the functionality to each config target when they're ready for it.

As promised, "-1" because this adds iconv library.
I think two flags are needed.  One to say "treat this bytestring as utf8 I know what I am doing" and another to say "I don't care if this has random locale-specific data"  The implementation of both flags is identical, but I think explicitly identifying the two different uses is helpful to users.  It is also more future-proof, in that the second case could eventually be automatically handled by locale conversion.
If neither flag is specified, it is an error for any non-ascii character to be given.
Or, if that's too much of a compatibility issue, then the first case is "check for non-ascii" and the "I know what I am doing, treat this as utf8" becomes the default.

Is this an aversion to iconv specifically? If it is, I would like an explanation, 'cause I don't get it.

It is also more future-proof, in that the second case could eventually be automatically handled by locale conversion.

I'm not sure how that differs from what this PR implements already.

Both cases are implemented the same way.  But they really mean two different things, or should, to the user.  For example, the "this is utf8" could take a hex-encoded value.  The "in my locale" flag could eventually convert to utf8.  Does that help?

I am suggesting two flags that currently have the same behavior but might diverge in the future, and because it (IMO) it's more clear to the user.  In the absence of either flag, only ASCII input is allowed.
The "password as hex" should not be interpreted at all.  It should just take those hex bytes and use them.

Richard Levitte wrote:

This could do with test cases. In particular I think the case of -passin on the command line on Windows with OPENSSL_WIN32_UTF8 set is going to get it wrong.
Defining that envvar is, for intents and purposes, like setting the locale to xx_XX.utf8.
Hmm,
So I have to remember how cmd console works.

First setlocale is not supported properly on non-posix platform like
Microsoft Windows.
In console window "code page" is important for user input.

The only difference here is that we know that input from cmd won't be UTF-8, so we have this input method to correct that case specifically.
First there is concept of OEM code page. For instance for Cyrillic it is
IBM866(OEM866 ?) or IBM855(OEM855).
In OEM "codepage" you could use either A or W function. I mean
ReadConsole().
If is used A function you could use MultiByteToWideChar with argument
CP_OEM and then like for W function to produce UTF-8 -
WideCharToMultiByte(CP_UTF8, .... .

chcp 65001
On Microsoft Windows (unless is fixed in recent versions) this codepage
is "third category citizen".
For instance read from stdio fails if user input types non-ascii
characters.
I expect ReadConsoleA to fail and so only usable method remains
ReadConsoleW. W function should work.

On Unix, you're just as screwed if you have the locale xx_XX.utf8 and your pass phrase source isn't encoded accordingly.  I don't think there's an easy fix for that, and trying to solve it is beyond the ambition of this PR (which is already ambitious).

I think that UI method for Microsoft Windows should be separate issue:

if codepage is 65001 use W function;
otherwise use either A or W (depend from environment variable).

Regards,
Roumen Petrov

The "password as hex" should not be interpreted at all. It should just take those hex bytes and use them.

If the application UTF-8 encodes it naïvely, PKCS12_create will decode it back to the exact same values. Otherwise, if the hex stuff happens to contain a byte sequence with something that looks like a UTF-8 multibyte character, PKCS12_create will read it as such, and therefore end up with a different value sequence than the one specified.

Then that should be a fatal error I suppose.

Wait, what should be a fatal error?

if the hex stuff happens to contain a byte sequence with something that looks like a UTF-8 multibyte character, PKCS12_create will read it as such, an

If detecting that is possible, great.  If not, oh well.

Probably better to add an API that just takes BMPString in uint16_t form, rather than a magic hex string interpretation.

if the hex stuff happens to contain a byte sequence with something that looks like a UTF-8 multibyte character, PKCS12_create will read it as such, an

If detecting that is possible, great.  If not, oh well.

Well, it's a tad hard to distinguish what's meant to be from a byte sequence that, for all intents and purposes, looks like a valid UTF-8 encoded string.

Probably better to add an API that just takes BMPString in uint16_t form, rather than a magic hex string interpretation.

Well, the command line argument would be a hex string anyway, as I understand it.
But most of all, could we please remember that we're late into the beta phase for the moment? Adding a new API for 1.1.1 is out of scope.

BTW, I'm not sure that specifying a UCS-2 input is gonna help much. I can see all kinds of ways for applications to get it wrong. Oh, and let's not forget som use UTF-16 instead (surrogate pairs). Another level of yikes...

  Some other time, maybe someone can come up with a more workable solution.


Liveview Axum Integration + Example updates

I like Axum, and wanted to try to make a Liveview toy app. I have implemented a connector in the same style as the warp connector (it is pretty much copy paste).
I have also changed the examples to suppress VScode IDE errors when having dioxus open in the same workspace as a seperate application (I moved the cfg statement inside the main function so that VScode wouldn't complain that there was no main function).
I have also added the menu element to Dioxus html

Looks great - thank you so much! LiveView is pretty slick and I'm excited to get axum support.
When checks pass I will merge it as is.


Add uli; remove jcarman, jani, and kmcgrail

leave mattmann and rubys for now for transitional purposes

+1 to merge

merged


bug: Modal does not work with a dialog element

What version of daisyUI are you using?
3.3.3
Describe your issue
When I use dialog element, code literally copied from the documentation:

<button class="btn" on:click={showModal}>open modal</button>
<dialog id="my_modal_1" class="modal">

Hello!

Press ESC key or click the button below to close

      <form method="dialog">

        <button class="btn">Close</button>
      </form>

</dialog>

I can only see the overlay but the modal itself is invisible if I disable components styling the modal starts working. When the dialogue element is changed to div the modal works also OK.
Is this a bug, am I missing something?
What browsers are you seeing the problem on?
Safari, Firefox
Reproduction URL
stackblitz.com/edit/vitejs-vite-reh2q4

Update daisyUI to the latest version: npm i -D daisyui@latest
That stackblitz link is using an older version (2.x)
I will update the dependencies for that example project soon.

Ah...


+K argument in vm.args doesn't  work, Help

When I use rebar generate to package , and add "+K true" to vm.args ,start application ,but the argument doesn't work.  When I watch the process in terminal, "+K true " in vm.args become "-K true". Why?

Why do you think it doesn't work? If what you're seeing is the following, then it's normal behavior, and does not mean kernel-poll is disabled:
$ erl +Ktrue
$ ps a|grep Ktrue|grep -v grep
[...] bin/beam.smp -Ktrue -- -root [...]

But when connect vm using remote_console , I see "kernel-poll:false"

What does the VM (same executable) welcome header say if you run erl +Ktrue interactively on the same host?

kernel-poll:true . system  is ubuntu server 12.04

I've successfully created a demo release with a dummy app and +K true in vm.args:
[...]
$ rel/demo/bin/demo console
[...]
> erlang:system_info(kernel_poll).
true

Can you share rel/reltool.config and rel/files/* or more information?

The information you see with the remote_console is the information of the remote console, not the system you connect to.
It's printed that way because the node boots locally, but spawns its evaluator on the remote node. Not a bug.


chore(main): release 0.0.38

:robot: I have created a release beep boop
0.0.38 (2024-03-14)
Features

support pubkey secret creation for oci signature verification (#240) (0a77ed3)

Other

bump validator plugin versions (#243) (2987021)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/spectrocloud-labs/validator/releases/tag/v0.0.38 :sunflower:


 This pull request removes it.
Issue: https://github.com/codemirror/CodeMirror/issues/4206

Thanks. Merged as 2f814b2


environment “PORT” setting not work in 0.3.4 docker image

It works in 0.3.3 docker image if i change the service port from default ‘3000’, but I found it doesn’t work in 0.3.4, the listening port won’t change to the port as setting in environment, it only listening on 3000 as default.

Should be fixed in 0.3.5


fix: improve error messages for target width validator

The error message isn't quite correct, so I improved it a little.

I've rebased this onto main after the .js changes


Application Command Support

Additional context
https://blog.discord.com/slash-commands-are-here-8db0a385d9e6
Blocked by Serenity to implement easier slash command handling.

https://github.com/kangalioo/poise seems to be a legitimate option although it is pretty new.


Add gzip compresssion, items truncation pre serialization

This PR amends three things to improve response time:

Adds compression library to automatically gzip all responses.
Adds _source.excludes param to search and fetchById resources calls to exclude unnecessary source fields in ES response
Truncates bib items to 10 in a search context. Seems front-end is only displaying first now anyway. (Will need to build way to paginate through nested items in future after indexing them as nested datatype.)

I think this PR may mitigate some of the issues with many-item bibs slowing down some searches. For your consideration @nodanaonlyzuul

Okay! I'll take a look and so some very unscientific benchmarking.
Phone. Brevity. Typos.
On Jul 21, 2017 5:41 PM, "Paul Beaudoin"<EMAIL_ADDRESS>wrote:

I think this PR may mitigate some of the issues with many-item bibs
slowing down some searches. For your consideration @nodanaonlyzuul
https://github.com/nodanaonlyzuul
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NYPL-discovery/discovery-api/pull/54#issuecomment-317118919,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAiG5Gx30Z2KszpOZe7zNK3G7cs6TWdks5sQRr1gaJpZM4OUj2h
.

Great to add gzip. I'm a little concerned that the API Gateway might not support it, but I'm pretty sure it does now.
Also, it might be better to let Nginx handle the gzipping as I think that's best practice. We'd have to update the Beanstalk configuration. Maybe something like: https://gist.github.com/omidfi/aaae08617729d26fce52024cafb59e12

I agree with Kevin. I'm going to open an issue about letting nginx handle gzip.
I'm going to keep this PR open for the other functionality and maybe we can remove gzip from this feature branch.

Removed app level gzip compression

The useful parts of this have been folded into https://github.com/NYPL-discovery/discovery-api/pull/99


Release 1.5.0.Beta5

Summary
Releases 1.5.0.Beta5. See release notes for changes.
Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[x] Release
[ ] Refactoring
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[x] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[x] Example scenarios has been updated / added
[x] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

run tests


D-Pad remapping issue

Hello, I'm a user who plays Tekken 7 with GP2040.  I got an issue, where the lever is mapped to the D-Pad suddenly changed to the left analog stick during the gameplay, and I was able to confirm that both inputs were changed even by accessing the web settings.  Upon confirmation, other buttons remain the same, only the binding of the lever has been changed.
The environment used is Windows 10 Pro 21H1, x64 environment, XInput mode is being used, and the game being played is Tekken 7.
The same symptom is happening quite often, and the board I'm using is a Raspberry pi pico board.

Hi @y3eah ,
We would need to know which version of the firmware you have loaded and also get some images of your setup.  This reads like there may be an issue with always held buttons that are activating the shortcuts in the firmware.
As a note - This project is no longer maintained.  Please check out the Community Edition project and post your issue there if it continues.  The Community Edition issues section can be found here: https://github.com/OpenStickFoundation/GP2040-CE/issues


refactor: deprecate and remove react-spring

This PR resolves []
Description

PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

deprecate and remove react-spring - gkartalis

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Dev changes (deprecate and remove react-spring - gkartalis)

  Generated by :no_entry_sign: dangerJS against ab9f32ae04199dd35b3fd827b63fefea81d49e49


Client re-use

Depends on #2
Re-using the same blocking client instead of creating new ones.

This is a weird situation, since you share the same code as other PRs, so there are conflicts...

irrelevant to the PR, but as I was testing I encountered chimu having an internal error, lol
21:10:42 [INFO] Got a link! https://osu.ppy.sh/beatmaps/965543
21:10:43 [INFO] Got redirected!! https://osu.ppy.sh/beatmapsets/450015#osu/965543
21:10:43 [INFO]     Attempting to download from chimu.moe - https://api.chimu.moe/v1/download/450015
21:10:43 [ERROR]     Failed to download from chimu.moe - 500 Internal Server Error
21:10:43 [INFO]     Attempting to download from kitsu.moe - https://kitsu.moe/api/d/450015
21:10:46 [INFO]     Successfully downloaded beatmap from kitsu.moe!
21:10:46 [INFO] Saved the beatmap to: "C:\\Users\\Arjix\\AppData\\Local\\osu!directer-beatmaps\\450015_kitsu.osz"
21:10:46 [INFO] Launching osu! at "C:\\Users\\Arjix\\AppData\\Local\\osu!/osu!.exe"

thank god I have added a second mirror


update https://spring.io/docs to remove grails docs

please remove grails docs, they are 404'ing anyway

done by removing the grails project from the projects admin.


Noel doesn't give lodge tour

as the title says

Details
the objective to talk to noel and the quest marker above her shows up, you go talk to her about the "place to stay", the objective 'talk to noel' is completed, but she stays in place and never walks you around the lodge
Game Version
<IP_ADDRESS>
Language
English (EN)
New Game
Yes
Reproduction Steps
just start a new game and play until the point you reach the lodge

there's a discussion on reddit about this bug too
https://www.reddit.com/r/Starfield/comments/166yzc3/did_noel_just_give_up_on_the_tour_for_anyone_else/


Status of project?

Hi I'm interested in this project. I would like to know if you are using this at your work, or if this is just experimental?
I like the idea of using the same tools to test that we are familiar with, rather than learn a new tool like Appium. Also it seems like it closer to using the native tools and would be easy to customise if we needed particular features of either XCTest or Espresso.
However I'm hesitant to start using it, as I would be asking QA team to help write the tests and they don't have android experience. What would you recommend?

Hi. I am not using it currently, hopefully at a point where I have more time for my apps that I am writing.
I would treat the project as under development, awaiting some eager users that would feel comfortable to contribut to it, maybe co-own it if they want.
I checked some amount of test cases when developing it, but of course more changes can pop-up. And XCTests and Espresso are still evolving, so there may be some additions needed.
Long story short - if you are looking for something stable and mature, not here yet.
If you want to risk it and invest in it, to still save some time for your QA team, and potentially help improving the project - that would be great.

Thanks for the info. I would love to try to use it, but I think it could be difficult to sell it to our QA team. Maybe I'll try to use it as the developer's test platform, in conjunction with QA's Appium tests.

I notice that the current code doesn't work on xcode 12. Would you like me to submit a pr to use XCFrameworks and upgrade gradle version?

@CarsonRedeye if you have time for it, feel free :) I may be busy till the end of the week, but would try to find time to review and test it.


Fix: Specify class name relative to root namespace

This PR

[x] specifies a class name relative to the root namespace

Follows https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/2466.

:+1: (but CS is off now ;) )

why only for this file? do we do it in other files?

updated

Thank you @localheinz.

Thank you, @keradus, and apologies for being late here, I've got a cold at the moment. 🛌

not need to apologize ;) get well soon !


Different behavior in datafusion 35.0.0 in reading hive-partitioned parquet data

Describe the bug
pip recently switched to installing datafusion with version string '35.0.0'. Compared to a previous installation of version '34.0.0', creating an external table from hive-partitioned parquet data following the [https://arrow.apache.org/datafusion/user-guide/sql/ddl.html](documented instructions) does not work. While all the partition columns show up as columns of the table, the columns from the parquet data  themselves do not appear.
To Reproduce
# prepare fake data
import pyarrow as pa
import pyarrow.parquet as pq
import pandas as pd
data = pd.DataFrame(data={'col1': [1, 2], 'col2': [3, 4]})
table = pa.Table.from_pandas(data)
import os
os.mkdir("fake=0")
pq.write_table(table,"./fake=0/data.parquet")

# load into datafusion
import datafusion as df
ctx = df.SessionContext()
ctx.sql("""
CREATE EXTERNAL TABLE data
STORED AS PARQUET
PARTITIONED BY (fake)
LOCATION './*/data.parquet'
""")

The loaded data is missing col1 and col2:
>>> ctx.sql("SELECT * FROM data")
DataFrame()
+------+
| fake |
+------+
| 0    |
| 0    |
+------+
>>> ctx.sql("SELECT table_name, column_name FROM information_schema.columns")
DataFrame()
+------------+-------------+
| table_name | column_name |
+------------+-------------+
| data       | fake        |
+------------+-------------+

Expected behavior
The same steps with DataFusion 34.0.0 produce the following output:
>>> ctx.sql("SELECT * FROM data");
DataFrame()
+------+------+------+
| col1 | col2 | fake |
+------+------+------+
| 1    | 3    | 0    |
| 2    | 4    | 0    |
+------+------+------+
>>> ctx.sql("SELECT table_name, column_name FROM information_schema.columns")
DataFrame()
+------------+-------------+
| table_name | column_name |
+------------+-------------+
| data       | col1        |
| data       | col2        |
| data       | fake        |
+------------+-------------+

Additional context
Operating system: Rocky 8
Python version: 3.10.11
DataFusion version: 35.0.0, recently installed via pip
pyarrow version: 15.0.0

This issue reproduces using the newest datafusion release, 43.1.0.

I realize now this issue might instead belong in https://github.com/apache/datafusion/issues and will move it there if so.

This is probably a duplicate of https://github.com/apache/datafusion-python/issues/957


Lightweight Git-based package system

Add a lightweight package system, built by implementing packages as small, well-formed Git repositories, alongside a central database listing each of these packages, along with their meta-data, realised as a Git repository. Basically using the same approach that Julia uses to implement its own package management system.

Majority of package structure implemented. Need to add dependency handling and bootstrapping of built-in packages, before constructing central repository.

No longer an issue as of the changes made since the release of Julia 0.4.


Only start InjectDLL32 if not already running

Helps prevent injected processes from crashing due to multiple InjectDLL32 processes created after calling process crashes or stops unexpectedly.

Thanks!


Get old tweets not working

For some reason today when I was searching for past tweets, the program wouldn't find any and can only find tweets from about a week ago. Yesterday it was working fine, but as of right now it's not working.

A proxy will instantly fix the issue. This is the most common problem reported, so there should probably be some mention in the README.
One of the classes you use has a default param for adding a proxy. You'll have to find which one it is as I don't remember.

You have been IP blocked. Use a proxy to fix this issue. There is support for a proxy with the getTweets function.

I am having the same problem. Can anyone explain how to set up a proxy within the getTweets function?


[Designer-> Element Properties]: Incorrect name is defined for 'Remove' button under 'Element Properties' pane.

https://microsoft.visualstudio.com/OS/_workitems/edit/33898617

This issue is not repro, hence closing this issue.
Snippet:


--http-timeout option to the CLI

Description
Allows configuration of the HTTP client timeout via the CLI.
Checklist

[ ] Add tests
[x] Add docs
[x] Update CHANGELOG

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.04%. Comparing base (170bbc3) to head (63e26b3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   85.01%   85.04%   +0.02%
==========================================
  Files          16       16
  Lines        1048     1050       +2
==========================================
+ Hits          891      893       +2
  Misses        157      157

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


chore(main): release 1.2.5

:robot: I have created a release 🏷
1.2.5 (2023-10-11)
🐛问题修复

修复箭头显示错误、范围选择器年份点击错误 (7019b8f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/LIjiAngChen8/datepicker-pro-vue/releases/tag/v1.2.5 :sunflower:


sct_apply_transfo doesn't work in certain cases

Description
Coming from https://github.com/neuropoly/spinalcordtoolbox/pull/1948#issuecomment-407284405
sct_apply_transfo can't seem work (no displacement observed) in unit tests using fixed/moving (straight/curved) images of certain orientations, which is strange:
Orientations OK: RAI RAS RPI RPS LAI LAS LPI LPS RIA RIP LIA LIP PLI PLS PIR PIL ILP SLP IAL IPL
Orientations NG: RSA RSP LSA LSP ARI ARS ALI ALS PRI PRS AIR AIL ASR ASL PSR PSL IRA IRP ILA SRA SRP SLA IAR IPR SAR SAL SPR SPL
This can be worked around, but we'd need to figure it out at some point.
Steps to Reproduce

Install SCT branch cJ/more-image

pytest unit_testing/test_transfo.py -vv --capture=no -k test_transfo_exhaustive_wrt_orientations

Expected behavior: can transform from any orientation
Actual behavior: some (many) orientations fail

Can't reproduce o_O.
That must have been on older WIP.
Orientations OK: RAI RAS RPI RPS LAI LAS LPI LPS RIA RIP RSA RSP LIA LIP LSA LSP ARI ARS ALI ALS PRI PRS PLI PLS AIR AIL ASR ASL PIR PIL PSR PSL IRA IRP ILA ILP SRA SRP SLA SLP IAR IAL IPR IPL SAR SAL SPR SPL
Orientations NG:
Orientations DK:

Added a test that tests different orientations between source and reference images and it also passes.


k-navbar - Universal design problem / VoiceOver

Check that this is really a bug

[X] I confirm

Reproduction link
App mypostnord
Bug description
When the html code for k-navbar is generated, an extra div is added at the top of the code that is printed. This is marked below, and begins with the class absolute.

…
Because of this, the return link does not work when you use voice over on the phone. It only reads out the title.
Expected Behavior
Navigation elements should be clickable when the phone is using VoiceOver mode on mobile phone
Actual Behavior
Not possible to click on navigation links in VoiceOver mode on mobile phone
Konsta UI version
v0.11.1
Platform/Target and Browser Versions
iOS
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Konsta UI issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

Is it possible to pay to have this issue solved?

Can you give an example of how the HTML should be modified that would work correctly?

On a phone with voice over, the title was the only element that was read. It was not possible to click an svg link element used as a back link. We solved this by making the back link to a back button.
On voice over, a button is always read as an button. A link need a href to be read as a link.
Thomas Ekdahl
Privat
Mobile: +47 911 43 630

On 5 Sep 2022, at 10:53, Vladimir Kharlampidi @.***> wrote:
Can you give an example of how the HTML should be modified that would work correctly?
—
Reply to this email directly, view it on GitHub https://github.com/konstaui/konsta/issues/68#issuecomment-1236719533, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGG2DR2JYT3IFPQ2HGLNZPDV4WYKNANCNFSM554I5MTQ.
You are receiving this because you authored the thread.


Manifest getstarted fix

Fixes 3266
This just copies previously reviewed sentences to another place, so I don't think it needs a review.

Docs Build status updates of commit 201694d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/manifest/getstarted.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Nuxt CLI warning about extension when an included js file in plugins contain a .js.map file

Versions

nuxt: v2.15.8
node: v12.22.6

Reproduction

Additional Details

Steps to reproduce
Include a script file that has an associated map file in plugins config like below:
plugins: [     { src<EMAIL_ADDRESS>mode: 'client' },   ],
What is Expected?
No warning
What is actually happening?
WARN  Found 2 plugins that match the configuration, suggest to specify extension:    00:12:56

<EMAIL_ADDRESS><EMAIL_ADDRESS>

Duplicate: https://github.com/nuxt/nuxt.js/issues/9121, so closing.


[enhancement] Sort album/folder screen by most recent additions

Hey there, just wanted to say that this app is incredible - hands down the prettiest gallery app on Android! I was wondering if you'd consider implementing a new sort option so that albums/folders that have most recently had a photo added to them appear at the top of the list (similar to how Google Photos alters its album quick-list). Basically sorting by most recent additions so albums that haven't had anything added to them for a long time also end up appearing on the bottom.
I know you get a tonne of feature requests so completely fair if you don't want to add it, but it'd be an awesome feature to have.
Thank you! 😄

Sure!

https://github.com/kollerlukas/Camera-Roll-Android-App/commit/49b782163810256114e52a5f038ceda4b6d9771f

Thanks so much!


Question: How to implement CreateValueBufferFactory in QuerySqlGenerator in Core 3.0

**Already had opened case #19169  Please don't be in so much hurry to close it it's painful to open issue for each reply **
I had looked SQLServer design and breaking changes. DB2 provider requires Datareader, Parameter value and RowNumberPaging..
Without these many scenario will fail.
Now my simple question is how can we get DataReader object in select flow. Earlier using CreateValueBufferFactory(..) we were able to achieve it.
Similarly for ParameterValues ?

You don't create ValueBuffers from database values in EF Core 3.0

I would totally blame this on one of the customer to present it to me recently. Please refer to XY problem.
EF Core 3.x query pipeline stopped using ValueBuffers altogether. Hence there is no way to implement CreateValueBufferFactory. In order for us to help you out, you need to describe what actual issue you are trying to solve. A lot of functionality in previous query pipeline has been reworked to implement it differently. So for many cases, you cannot solve the problem using same solution.
For row number paging, the SqlServer version which required it went out of support hence we dropped support for it and we are not planning to add it either. You would have to implement it by yourself. I am not sure what would be the complexity of it.

Actually for boolean type we have to edit one of property in DB2DataReader class.. Earlier via ValueBuffer we were able to get hold of DataReader and editing overrideReturnTypes=True
Now since ValueBuffer is removed, somehow we need to get hold of DataReader object otherwise our many scenario will fail..
for example: context.TestTabs.All(i => i.ID > 1)
sample Code which we may need to be injected:
if (colTypes.Contains(Type.GetType("System.Boolean")) || colTypes.Contains(Type.GetType("System.Nullable`1[System.Boolean]")))
{
int colNum = 0;
            foreach (Type colType in colTypes)
            {

                if (colType.FullName.Contains("System.Boolean"))
                //if (colType.FullName.ToString() == "System.Boolean")
                {

                    if (_overrideColumnReturnTypes == null)
                    {
                        _overrideColumnReturnTypes = new Dictionary<int, TypeCode>();
                    }
                    _overrideColumnReturnTypes.Add(colNum, TypeCode.Boolean);

                }
                colNum++;
            }

            ((DB2DataReader)dataReader).OverrideColumnReturnTypes= _overrideColumnReturnTypes;

        }

@archanasoni This should be handled by type mappings. That is, the properties should get different type mappings depending on whether they are conceptually boolean or not. The type mapping then has a mechanism to use a custom data reader expression as needed.
I suspect attempting to pre-modify the data reader in the way you show won't be successful without making extensive hacks to the internals, which is something providers should avoid.

@ajcvickers  DB2 handles boolean in different way, and is not that straight forward.
for example, when valuebuffer can have boolean type we need to update OverrideColumnReturnTypes property of Db2Datareader. Basically for query using All method(context.TestTabs.All(i => i.ID > 1)),  EF expects result as boolean but DB2 doesn't support it fully so to make it work we have to update property.
Type mapper wouldn't help here...

@archanasoni Maybe it's just the case that DB2 is too different from other relational providers to make it a candidate to use the relational provider infrastructure. In this case, I suggest you abandon using the relational provider infrastructure and use your own implementation. This will free you from the constraints in the way EF using ADO.NET.

Thanks @ajcvickers , will close the issue as Vacation time :)
Once I'm back will open it if needed..


koord-manager: fix not compatible with ElasticQuota associated by namespace

Ⅰ. Describe what this PR does
When users create parent ElasticQuota in namespace and the pod in the namespace cannot be created.
As mentioned in the original design proposal , if the Pod does not specify a QuotaName, use the Namespace as the QuotaName to find the ElasticQuota, and if there is none, use the default ElasticQuota.

Ⅱ. Does this pull request fix one issue?
fix #1100

Ⅲ. Describe how to verify it
According to the reproduction method of issue #1100, the correct result expected by users can be achieved.
Ⅳ. Special notes for reviews
V. Checklist

[x] I have written necessary docs and comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in make test

/lgtm


missing parent for kinase regulator activity

Hi
There are inconsistencies between the parents for kinase regulator terms and protein kinase regulator terms. I have listed the edits required for the kinase terms which would align these 2 ontologies.
please could this relationship be added:
GO:0019207 kinase regulator activity
should have the part_of parent term
GO:0043549    regulation of kinase activity
AS GO:0019887 protein kinase regulator activity
has the part_of parent
GO:0045859 regulation of protein kinase activity
Plus
GO:0019209   kinase activator activity
Should have the part_of parent
NEW GO Term: activation of kinase activity
with the is_a parent GO:0033674 positive regulation of kinase activity
Alternatively just create the part_of parent
GO:0033674 positive regulation of kinase activity
AS GO:0030295   protein kinase activator activity
has the part of parent
GO:0032147   activation of protein kinase activity (although I am not sure that this term is needed?)
which has the is_a parent
GO:0045860   positive regulation of protein kinase activity
I will open a separate ticket for the kinase inhibitor which looks worse
thanks

Hi @RLovering
Do we really need the processes here 'NEW GO Term: activation of kinase activity'? I think this is clearly a MF. I think there was a ticket to remove these 'activation of activity' BPs (I cannot find the ticket - @ukemi do you remember that ?)
Thanks, Pascale

Ok
if the new term is not required then GO:0032147 activation of protein kinase activity should be removed.
But we still need a connection between
GO:0019209 kinase activator activity
and GO:0033674 positive regulation of kinase activity
Thanks
Ruth


Add api docs for internal api

Initial rundown of internal API that the Auth App will expose
Uses API blueprint spec:

http://apiary.io/blueprint
https://github.com/apiaryio/api-blueprint/blob/master/API Blueprint Specification.md

Looks great, nice one @ansonK :+1:
Want me to merge?

@chriscarter90 :+1:


Link pecl-pq

Coverage remained the same at 75.976% when pulling 2bf534f2118370fa37ac0f8ace380431ad6a7074 on uasan:patch-1 into 7578aa3445a55221d2816a4f3939d1bf82d4aab1 on amphp:master.

See #4.


Introduce "Groups"

This is what's going to be Paket 2.0
Basic feature description
This new feature will allow us to organize our dependencies in groups and also allows easier conflict resolutions. Let's consider a small sample:
paket.dependencies
source https://nuget.org/api/v2

nuget Newtonsoft.Json
nuget UnionArgParser
nuget FSharp.Core

github forki/FsUnit FsUnit.fs
github fsharp/FAKE src/app/FakeLib/Globbing/Globbing.fs
github fsprojects/Chessie src/Chessie/ErrorHandling.fs

group Build
    source https://nuget.org/api/v2

    nuget FAKE
    nuget FSharp.Formatting
    nuget ILRepack

    github fsharp/FAKE modules/Octokit/Octokit.fsx

group Test
    source https://nuget.org/api/v2

    nuget NUnit.Runners
    nuget NUnit

As you can see we have 3 different groups. The first one is the default group (currently called "Main") and represents the backwards-compatible case. So the main group is what you currently have in Paket 1.x. The other two groups contain dependencies that are used for Build and Test.
Notice the indentation in groups is optional.
After paket update the corresponding lock file looks the following:
paket.lock
NUGET
  remote: https://nuget.org/api/v2
  specs:
    FSharp.Core (<IP_ADDRESS>)
    Newtonsoft.Json (7.0.1)
    UnionArgParser (0.6.3)
GITHUB
  remote: forki/FsUnit
  specs:
    FsUnit.fs (81d27fd09575a32c4ed52eadb2eeac5f365b8348)
  remote: fsharp/FAKE
  specs:
    src/app/FakeLib/Globbing/Globbing.fs (991bea743c5d5e8eec0defc7338a89281ed3f51a)
  remote: fsprojects/Chessie
  specs:
    src/Chessie/ErrorHandling.fs (1f23b1caeb1f87e750abc96a25109376771dd090)

GROUP Build
NUGET
  remote: https://nuget.org/api/v2
  specs:
    FAKE (4.3.1)
    FSharp.Compiler.Service (<IP_ADDRESS>)
    FSharp.Formatting (2.10.0)
      FSharp.Compiler.Service (>= 0.0.87)
      FSharpVSPowerTools.Core (1.8.0)
    FSharpVSPowerTools.Core (1.8.0)
      FSharp.Compiler.Service (>= 0.0.87)
    ILRepack (2.0.5)
    Microsoft.Bcl (1.1.10)
      Microsoft.Bcl.Build (>= 1.0.14)
    Microsoft.Bcl.Build (1.0.21)
    Microsoft.Net.Http (2.2.29)
      Microsoft.Bcl (>= 1.1.10)
      Microsoft.Bcl.Build (>= 1.0.14)
    Octokit (0.14.0)
      Microsoft.Net.Http
GITHUB
  remote: fsharp/FAKE
  specs:
    modules/Octokit/Octokit.fsx (991bea743c5d5e8eec0defc7338a89281ed3f51a)
      Octokit

GROUP Test
NUGET
  remote: https://nuget.org/api/v2
  specs:
    NUnit (2.6.4)
    NUnit.Runners (2.6.4)

As you can see every group is listed separately and we still have the backwards-compatible case for the "Main" group.
If you want to reference dependencies from projects you can do this via the following syntax in references files:
paket.references
File:FsUnit.fs .
FSharp.Core

group Test
  NUnit
  NUnit.Runners

New ways for conflict resolution
We got many requests to support multiple versions of the same package with Paket. This was not possible since we had no way to discriminate these.
Now we can support that by using multiple groups:
source https://nuget.org/api/v2

nuget Newtonsoft.Json

group Legacy
    source https://nuget.org/api/v2

    nuget Newtonsoft.Json ~> 6

Every group will be resolved independently so that we get:
NUGET
  remote: https://nuget.org/api/v2
  specs:
    Newtonsoft.Json (7.0.1)

GROUP Legacy
NUGET
  remote: https://nuget.org/api/v2
  specs:
    Newtonsoft.Json (6.0.8)

Paket is downloading both version. We will get packages/Newtonsoft.Json with version 7.0.1 and packages/legacy/Newtonsoft.Json with the 6.0.8 bits.
In your references files you can now decide which version you want to use:
group Legacy
Newtonsoft.Json

Open stuff
This is currently early alpha and definetly not production ready. But I will update this PR frequently and

[ ] - Create group specific commands like paket restore group Test
[ ] - Documentation
[ ] - Testing
[ ] - https://github.com/fsprojects/Paket/pull/1014 is not merged - @mrinaldi could you try to merge and send a PR against the groupsbranch?

Organizational remarks

Please send all Paket 2.0 PRs against the groups branch. I will start to release alpha versions from this branch.
Please continue to send all bugfix PR's against master branch.

Hi,
First of all, I like this feature very much - it's somehow similar to NPM with it's "normal" dependencies and "dev" dependencies but is pushing idea even further with custom group definitions. Big :+1: for this feature.
My only remark right now - paket.dependencies and paket.references file don't seems clear and readable and for me with this syntax. My suggestion would be to introduce indentation for (non-main) groups. It would allow to have backward compatibility for main group and clearer syntax for custom groups.

Just throwing in my +1 too.

Another :+1: here with a question: is there any thought of paket restore gaining the ability to only restore specified group(s) of packages? Could be useful for when a CI server really only needs a subset of the referenced dependencies for what it's building, or when a dev is trying to get started on project X in a solution and doesn't really want to grab the libs needed for tests or whatever just yet.

Yes that is planned, but not implemented yet
On Aug 27, 2015 6:35 PM, "Anthony Perez"<EMAIL_ADDRESS>wrote:

Another [image: :+1:] here with a question: is there any thought of paket
restore gaining the ability to only restore specified group(s) of
packages? Could be useful for when a CI server really only needs a subset
of the referenced dependencies for what it's building, or when a dev is
trying to get started on project X in a solution and doesn't really want to
grab the libs needed for tests or whatever just yet.
—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket/pull/1018#issuecomment-135486770.

@Krzysztof-Cieslak 515c47c shows that optional indentation is already working

Amazing :) IMO, looks better

+1 From me. This looks like a great way to solve the problem with multiple versions!

Very nice. I just throw my +1 in the round.
Will start testing ASAP

Very nice indeed, +1.

yay. current paket 2.0 alpha can dogfood https://github.com/fsprojects/Paket/blob/groups/paket.dependencies

I very much like the idea! :+1:
Will it be possible to omit the group in paket.references when a dependency is defined in a single group only? Just thinking about the single-version case and that you DRY w.r.t. the group name.

One quick thought - would it make sense to allow specifying just the group in paket.references? If you have group with unit testing references, you would just say:
group Test

... and you would get references for nunit, FsUnit, FsCheck and whatever is in the group. This would save you whole 3 lines, so it's not really big deal, but it might make things even easier.

Don't agree with Tomas' suggestion - it would make people declare "project" groups and use one liners "group references" in every paket.references. Don't think it would be good practice.

@gross and @tpetricek I thought about your ideas and I think I don't want to implement this right now. I might have a different idea for some future version. So let's wait a bit with that. At the moment I think it's ok to be explicit in ref files.

Being explicit sounds good to me - and I think @Krzysztof-Cieslak is right in that it might make people use this in a different/unexpected way.

@amazingant paket restore group Test works now.

paket restore group --without Test would be useful as well (e. g. to exclude development dependencies)
Alex
Alexander Groß
Tiny phone, tiny mail
On Fri, Aug 28, 2015 at 3:07 PM, Steffen Forkmann
<EMAIL_ADDRESS>wrote:

@amazingant paket restore group Test works now.
Reply to this email directly or view it on GitHub:
https://github.com/fsprojects/Paket/pull/1018#issuecomment-135769629

@agross yes that sounds useful.
@eiriktsarpalis is it possible to have something like paket restore groups Test Build references-files file1 file2?  it seems I can only have one parameter with multiple things.

first draft of docs is at  http://fsprojects.github.io/Paket/groups.html

I started testing this (alpha012) on RazorEngine and get:
source https://nuget.org/api/v2

nuget Microsoft.AspNet.Razor ~> 3.0

group Net40
  source https://nuget.org/api/v2
  framework: net40

  nuget Microsoft.AspNet.Razor ~> 2.0

group Razor4
  source https://nuget.org/api/v2
  nuget Microsoft.AspNet.Razor ~> 4.0.0-beta1

$.paket/paket.exe update
Paket version <IP_ADDRESS>
Resolving packages for group Main:
 - Microsoft.AspNet.Razor 3.2.3
Resolving packages for group Net40:
Paket failed with:
        Could not find compatible versions for top level dependency:
     "Microsoft.AspNet.Razor >= 3.0 < 4.0 (from c:\Projects\RazorEngine\paket.dependencies)"
   Available versions:
     - 4.0.0-beta6
     - 4.0.0-beta5
     - 4.0.0-beta4
     - 4.0.0-beta3
     - 4.0.0-beta2
     - 4.0.0-beta1
     - 3.2.3
     - 3.2.3-beta1
     - 3.2.2
     - 3.2.2-rc
     - 3.2.0
     - 3.2.0-rc
     - 3.1.2
     - 3.1.1
     - 3.1.0
     - 3.1.0-rc1
     - 3.0.0
     - 3.0.0-rc1
     - 3.0.0-beta2
     - 3.0.0-beta1
     - 2.0.30506
     - 2.0.20715
     - 2.0.20710
     - 2.0.20505
     - 1.0.20105.408
   Try to relax the dependency or allow prereleases.

Notice that the following works (which is actually what I wanted to use anyway):
source https://nuget.org/api/v2

nuget Microsoft.AspNet.Razor

group Net40
  source https://nuget.org/api/v2
  framework: net40

  nuget Microsoft.AspNet.Razor ~> 2.0

group Razor4
  source https://nuget.org/api/v2
  nuget Microsoft.AspNet.Razor ~> 4.0.0-beta1

The difference is the "~>" restriction in the "Main" group. Was it wrong to expect the groups to be completely independent?

good catch - will try to fix

Here is possibly another one: It seems like content from different groups (not referenced via 'paket.references') is added to projects. Repro is here https://gist.github.com/matthid/6a1d5f17f176d14d79b7
After
paket.bootstrapper.exe prerelease
paket.exe update

git diff shows that files from Yaaf.AdvancedBuilding were added to the project files, but paket.references only lists FSharp.Core
Further testing reveals that adding content: none doesn't help either (tried adding it to both "Main" and "Build")

I think you all accidentally added me to your project (my username is gross). Please remove me.
Thanks,
garrett ross ceo /<EMAIL_ADDRESS><EMAIL_ADDRESS>/<PHONE_NUMBER> / mobelux.com http://www.mobelux.com/

On Aug 28, 2015, at 12:09 PM, Matthias Dittrich<EMAIL_ADDRESS>wrote:
Here is possibly another one: It seems like content from different groups (not referenced via 'paket.references') is added to projects. Repro is here https://gist.github.com/matthid/6a1d5f17f176d14d79b7 https://gist.github.com/matthid/6a1d5f17f176d14d79b7
After
paket.bootstrapper.exe prerelease
paket.exe update
git diff shows that files from Yaaf.AdvancedBuilding were added to the project files, but paket.references only lists FSharp.Core
Further testing reveals that adding content: none doesn't help either (tried adding it to both "Main" and "Build")
—
Reply to this email directly or view it on GitHub https://github.com/fsprojects/Paket/pull/1018#issuecomment-135819315.

@gross If you open the page for this issue (https://github.com/fsprojects/Paket/pull/1018) and click the "Unsubscribe" button on the right, that should do it. Your name got typo'd earlier because @agross is pretty similar.

@matthid first one is fixed

@forki Nice, thanks!
Ok I did some more tests and was really impressed to get NO error after specifying
Microsoft.AspNet.Razor

group Net40
  Microsoft.AspNet.Razor

group Razor4
  Microsoft.AspNet.Razor

in paket.references. I think what paket does is correct even considering that the resulting csproj will not compile.
the first two are fine because one is net45-only and the other one is net40-only. But the third one is net45 only as well.. This means I need some way to specify which one to take at build time (I don't want to use two references to the same nuget package on a single compilation).
One suggestion would be to allow something like
group Main if NET45
  Microsoft.AspNet.Razor

group Net40
  Microsoft.AspNet.Razor

group Razor4 if RAZOR4
  Microsoft.AspNet.Razor

in paket.reference (or even paket.dependencies, not sure right now) and then add a condition to the msbuild references like Condition="$(RAZOR4) == 'True':
<When Condition="$(RAZOR4) == 'True' And $(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.5' Or $(TargetFrameworkVersion) == 'v4.5.1' Or $(TargetFrameworkVersion) == 'v4.5.2' Or $(TargetFrameworkVersion) == 'v4.5.3' Or $(TargetFrameworkVersion) == 'v4.6')">

This is a feature request, but imho one that would make the group feature more useful.
Is this a scenario you want to tackle with the new group feature?

@matthid  second one fixed.

Yes all that works now :) You are way too fast ;)
Specifying a group named "Main" is also interesting: I thought it might be a way to get a main directory within the packages folder. But it seems to be a way to kind of break paket:
paket.dependencies
group Main
  source https://nuget.org/api/v2

  nuget FSharp.Core

group Build
  source https://nuget.org/api/v2

  nuget Yaaf.AdvancedBuilding

yields
paket.lock

GROUP Build
NUGET
  remote: https://nuget.org/api/v2
  specs:
    FAKE (4.0.2)
    FSharp.Compiler.Service (<IP_ADDRESS>)
    FSharp.Formatting (2.10.0)
      FSharp.Compiler.Service (>= 0.0.87)
      FSharpVSPowerTools.Core (1.8.0)
    FSharpVSPowerTools.Core (1.8.0)
      FSharp.Compiler.Service (>= 0.0.87)
    Yaaf.AdvancedBuilding (0.8.0)
      FAKE (4.0.2)
      FSharp.Formatting (2.10.0)
      FSharpVSPowerTools.Core (1.8.0)

@matthid I don't really understand https://github.com/fsprojects/Paket/pull/1018#issuecomment-135829321 - could you please create a new issue for discussion
I will take a look at the explizit main group case.
for further bugs please create separate issues. that makes it easier to handle for me.

explicit main group should work now, but it will not create a main directory. it will just put stuff in the main group.

we now support groups in paket add and paket remove


Find better icon similar to the logo

We have finally added a logo, but I'm not fond of the icon much. If anyone can find a similar icon but more flat then please add a link under this request. (This issue does not require a pull request but you will still be added as a contributor).
If someone also has better ideas for the logo as well, please share with us!

https://drive.google.com/file/d/1UD0Yhs097r590XIFBIZ0Z992_EyBczAB/view?usp=sharing
Tried to make a better logo :) Check it out @shahednasser

I like that @icoderharshit but do you think it will look good in the navbar? Also, would it look good with both light and dark mode?
If we use it we also would need a version of it where the background is white and the text is colored to use it in the header of the website (since the background of the header is blue). Let me know what you think about all of this.

Yes, it will. Being a Graphics Designer, I can tell you that it'll suit and adjust according to the background color of the header and stuff...I shared a mockup with you, if you assign me...I'll try to give it a final look and check if that goes well on Navbar as well..and with that dark mode too.

We have finally added a logo, but I'm not fond of the icon much. If anyone can find a similar icon but more flat then please add a link under this request. (This issue does not require a pull request but you will still be added as a contributor).
If someone also has better ideas for the logo as well, please share with us!

and yes...I just checked my name in the list of Contributors, it is redirecting to my sourcerer profile..please update it by replacing with either github.com/icoderharshit or icoderharshit.github.io/Portfolio

Yes, it will. Being a Graphics Designer, I can tell you that it'll suit and adjust according to the background color of the header and stuff...I shared a mockup with you, if you assign me...I'll try to give it a final look and check if that goes well on Navbar as well..and with that dark mode too.

Ok I will be assigning you. Please submit a PR so I can see how it will end up looking like.

We have finally added a logo, but I'm not fond of the icon much. If anyone can find a similar icon but more flat then please add a link under this request. (This issue does not require a pull request but you will still be added as a contributor).
If someone also has better ideas for the logo as well, please share with us!

and yes...I just checked my name in the list of Contributors, it is redirecting to my sourcerer profile..please update it by replacing with either github.com/icoderharshit or icoderharshit.github.io/Portfolio

Unfortunately this is done automatically by all-contributors but I'll look into it.

@icoderharshit When you add your logo, make sure to credit yourself in the footer instead of the current credit for the icon in the logo.

Sure, if I needed assistance in this footer thing, I'll tell you @shahednasser

@shahednasser , I created a PR for the same and updated the website with a new logo for Header and Navbar sections (compatible both with Light and Dark mode), Please Check it out.

Looking towards having this PR merged :) I'll look into the favicon part tomorrow morning. Please check this out @shahednasser

Logo Updated,  and credits given in the Footer, Readme ! Check it out @shahednasser :)

Logo and credits mentioned in the Readme file :) Please, Check @shahednasser .

when will this issue get close ? :-p , anyways Thank you so much if you liked the work. Looking for that favicon issue, there are developers excitedly waiting to work over that.

Hi @icoderharshit can you provide me with a good quality of the logo icon which we use for favicon?

Yeah, here you go @shahednasser :)

Thank you but I need it bigger if possible (I'm using it to create a gitub organization)

Alright, let me just do it for you ! Give me some time :)

Here, it is @shahednasser
favicon.zip
Uploaded a .zip file because GitHub doesn't allow sharing .svg directly here, there's a SVG file for the favicon in the ZIP.

Thank you @icoderharshit but the svg is empty for some reason

No, @shahednasser You may have encountered a system error, please checking it once again. It's opening and working completely fine on my desktop.

My mistake it's working well. Thank you!


feat: publish docker image to DockerHub

What is the feature you would like to implement?
Publish a Docker image to DockerHub and write a guide on how to run Hubble on AWS using Docker.
Why is this feature important?
Make it easy for people who want to run Hubble as an image.
Will the protocol spec need to be updated??
No

I started writing a Dockerfile and a docker-compose.yml but if you plan to publish an official image I will wait yours.  My goal (if I find enough spare time) is to also write terraform scripts to facilitate the creation, installation and execution on DO droplets without much effort. just insert your DO token and launch terraform apply.  that's it.

terraform for DO would be awesome.
tagging @sds -- does it make sense for alor to work on the dockerfile or is this already in progress?

imho is cleaner if I just write the terraform script that pulls from your official docker image on docker hub.

We have a Dockerfile already (unless I'm misunderstanding what we're talking about).
If the ask is to publish that image to Docker Hub, we need to decide which Docker Hub org to publish under. Would be ideal to have this be done automatically every time we tag a release for Hubble.

We now publish a Docker image at https://hub.docker.com/r/farcasterxyz/hubble
You can pull the latest image using docker pull farcasterxyz/hubble:latest.


[FEATURE] Add kop event manager stats for prometheus metrics

Fixes #739
Motivation
At present, we have not done some indicator collection work on kopEventManager, it will be very useful to add corresponding monitoring metrics
Modifications
Add the following three metrics to monitor kopEventManager stats
KOP_EVENT_QUEUE_SIZE Represents the current number of events in kopEventQueue
KOP_EVENT_QUEUED_LATENCY Indicates the delay time for the event to wait in the queue to be formally processed
KOP_EVENT_LATENCY The time it takes for the event to be processed from the beginning to the completion of the processing

ping @BewareMyPower @Demogorgon314 :)

This change LGTM, but you may need add docs in docs/reference-metrics.md.

Thanks for your review. I have added docs. PTAL

@Huanli-Meng Please take a look. thanks.


add steps to install weave-net on EKS

Adding the Weave-net installaton steps on EKS as noted in https://github.com/weaveworks/weave/issues/3335#issuecomment-441522517

can you also take a look at https://github.com/istio/istio/issues/16434 , the istio gateways never get installed when weaver net on eks is used

@anupash147 we really can't track something on a closed issue from months ago in a different repo.  Please open a new issue here stating all the symptoms you are concerned about.


Error on Vite after building

I'm using vite and after bulding the app and preview (production build), I try to load the component and got the following error:
ReferenceError: require is not defined
    at xw (index-18e2662a.js:formatted:29683)
    at IE (index-18e2662a.js:formatted:30605)
    at z0 (index-18e2662a.js:formatted:4725)
    at XC (index-18e2662a.js:formatted:8465)
    at QC (index-18e2662a.js:formatted:8101)
    at dL (index-18e2662a.js:formatted:8094)
    at Ud (index-18e2662a.js:formatted:8077)
    at av (index-18e2662a.js:formatted:7761)
    at jS (index-18e2662a.js:formatted:7830)
    at $o (index-18e2662a.js:formatted:3648)

Looks like Vite doesn't support require statements, How could I solve this?

Updated to v1.4.2 and solved the issue


Fix coin text

Change Loan Office cost text to "-$5" (this PR fixes #132).
Add "coin"/"coins" word for landmark cost, Tech Startup text.

@kvnhykw You'd make a great manager!


Fix for https://github.com/aws/pg_tle/issues/171

Issue #171
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Can you add a test? Maybe with a mostly empty extension with \echo located in this repo


fix: LEAP-508: Add rel=noopener to external links

HTML links that open in a new tab or window allow the target page to access the DOM of the origin page using window.opener unless link type noopener or noreferrer is specified. This is a potential security risk. Our links lead to slack, github or our docs, but that's a good practice to use noopener anyway. We need referrer for analytics in some places, so noreferrer is not a choice.
This fixes https://github.com/HumanSignal/label-studio/security/code-scanning/769 and possible similar security issues.
PR fulfills these requirements

[ ] Tests for the changes have been added/updated
[ ] Docs have been added/updated
[x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[x] Self-reviewed and ran all changes on a local instance

This change affects (describe how if yes)

[ ] Performance
[x] Security
[x] UX — some external links are opened in new tab now

Does this PR introduce a breaking change?

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[x] No
[ ] Not sure (briefly explain the situation below)

noopener is not needed, but noreferrer is very recommended, so it's handled by another PR: https://github.com/HumanSignal/label-studio/pull/5632


Gh 475 java io file refs

Addresses #475
Not yet ready for merge

Ready for review.  Builds fine locally.  Changelog updated.

Added name/info to sub tasks


Add Digdag metrics

Digdag 0.10.0 minimum required. And make it a ConfigMap resource.
Need to bump chart minor version.
Ref http://docs.digdag.io/metrics.html

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.


Feature requests

Hi,
I gave it another try and reinstalled it and compared the my-harmony-card with the madmicio's one.
The advantage for me using your card is that most of the buttons already contain the action belonging to the activity and for madmicio's remote I had to write several scripts for the action. Nevertheless it has the abillty to override buttons and offer some more flexibility in that way.
The great disadvatnage of madmicio's remote is there is only 1 workin buttonrow and hope you are able to offer more in future.
Here my resultsof testing
I would like to have same color settings like madmacio has.
The OK and Up button didn't work for me with setupbox (TV kijken)
Volume down does the same as volumeup with TV kijken
I would like to have an optons to use icons for the extra buttonsrow(s)

On the remote underneath I also have upperleft a button with a popup card with all my favorite TV channels and have such button also (not in this remote) for radio stations as well

I hope this all helps or is possible for future enhancements
keep up the good work !!!
My madmicio's remote:

colorscheme i used:
colors:
active-background-button-color: '#0080ff'
deactive-background-button-color: '#f2f0fa'
button-border-standard: rgba(0, 128, 255, .5)
state-icon-active-color: '#0080ff'
buttons: '#363538'
text: white
background: black
Extra sources I have on my remote for mediabox
sources:
- name: Netflix
icon: mdi:netflix
- name: Disney+
icon: disney
- name: Prime Video
icon: si:amazonaws
- name: Viaplay info
icon: si:v
- name: Menu
icon: mdi:menu
- name: Teletekst
icon: mdi:format-text
- name: TV Guide
icon: mdi:television-guide
- name: DVR
icon: mdi:video
and this is the popup I use for TV channels

Hi,
first thank you for your Feedback!

More Buttons:
I thought already about it. My idea: Add a new row  and make it able to give a individual command and a individual device_id too
Icons for Buttons:
Must see how much effort, I will check it when I work on 1.
OK Button:
you can easy remap in the Syntax: OK: <new command> for each separate activity
Up Button
Actual no remapping possible. Which button do you mean? ChUp or DirectionUp?
VolumeUp / Down
Don't understand. You can switch VolumeUp and Down easily to a different device in your current activity by using volume_device_id
PopUp
Actual no idea how to implement. Madmicio is using for that the BrowserMod Service. I am unhappy with the behavior of the BrowserMod Service in general. Because of that, it is not implemented. To be honest, I thought about during development to implement the media_player as a card. But for the same reason (an I have no different idea to implement) this function was not released.
If somebody else has a good idea how to implement without browsermod, I will think about it. :)

However, if the are still bugs in the card (or doc) I am willing to fix it, new feature will come in autumn or winter, because of my family ;-)

Hi,
Your welcome, hopefully it can helps

More Buttons:
2.Icons for Buttons:
maybe the code from madmicio could help in the right direction for this works for me properly.
I can share my cardcode how I have configured it to give you an impression
3.OK Button:
gave it a try but no luck sofar with the syntax
Up Button
it's the DirectionUp which is not working
the VolumeDown does the same as VolumeUp for the mediabox and adressed volume_device_id to the proper deviceid

PopUp
I use indeed BrowserMod Service and sofar never had issues The only thing I have configured is using 1 button to get the popup.

I understand new features are no priority. Family is most important :-)
Here is the code I use with the madmicio to give you an impression:
card:
type: vertical-stack
cards:
- type: media-control
entity: media_player.woonkamer_4
- type: media-control
entity: media_player.mediabox
- type: custom:lg-remote-control
entity: media_player.mediabox
dimensions: null
scale: 0.8
border_width: 2px
name: ZiggoNext
colors:
active-background-button-color: '#0080ff'
deactive-background-button-color: '#f2f0fa'
button-border-standard: rgba(0, 128, 255, .5)
state-icon-active-color: '#0080ff'
buttons: '#363538'
text: white
background: black
sources:
- name: Netflix
icon: mdi:netflix
- name: Disney+
icon: disney
- name: Prime Video
icon: si:amazonaws
- name: Viaplay info
icon: si:v
- name: Menu
icon: mdi:menu
- name: Teletekst
icon: mdi:format-text
- name: TV Guide
icon: mdi:television-guide
- name: DVR
icon: mdi:video
color_buttons: true
keys:
'1':
service: media_player.play_media
data:
entity_id: media_player.mediabox
media_content_id: NPO 1
media_content_type: app
'2':
service: script.mediabox_bronselecteren_npo2
data:
entity_id: null
'3':
service: script.mediabox_bronselecteren_npo3
data:
entity_id: null
'4':
service: script.mediabox_bronselecteren_rtl4
data:
entity_id: null
'5':
service: script.mediabox_bronselecteren_rtl5
data:
entity_id: null
'6':
service: script.mediabox_bronselecteren_sbs6
data:
entity_id: null
'7':
service: script.mediabox_bronselecteren_rtl7
data:
entity_id: null
'8':
service: script.mediabox_bronselecteren_veronica
data:
entity_id: null
'9':
service: script.mediabox_bronselecteren_net5
data:
entity_id: null
RED:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: MediaTopMenu
Menu:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: Menu
color_buttons: true
optional_buttons: true
GREEN:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: Teletext
YELLOW:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: Guide
BLUE:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: DVR
POWER:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: Power
UP:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: ArrowUp
DOWN:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: ArrowDown
LEFT:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: ArrowLeft
RIGHT:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: ArrowRight
ENTER:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: Enter
BACK:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: Escape
EXIT:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: Exit
VOLUME_UP:
service: script.harmony_ziggo_next_volumeup
VOLUME_DOWN:
service: script.harmony_ziggo_next_volumedown
MUTE:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: Mute
CHANNELUP:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: ChannelUp
CHANNELDOWN:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: ChannelDown
HOME:
service: script.harmony_ziggo_next_menu
data:
entity_id: null
INFO:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: Info
PLAY:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: Play
PAUSE:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: Pause
STOP:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: Stop
RECORD:
service: lghorizon.record
data:
entity_id: media_player.mediabox
REWIND:
service: lghorizon.rewind
data:
entity_id: media_player.mediabox
FAST_FOWARD:
service: lghorizon.fast_forward
data:
entity_id: media_player.mediabox
av_receiver_family: yamaha
ampli_entity: ''
channels:
- image: /local/Pictures/npo1.png
number: '1'
- image: /local/Pictures/npo2.png
number: '2'
- image: /local/Pictures/npo3.png
number: '3'
- image: /local/Pictures/rtl4.jpeg
number: '4'
- image: /local/Pictures/rtl5.jpeg
number: '5'
- image: /local/Pictures/sbs6nw.jpeg
number: '6'
- image: /local/Pictures/rtl7.png
number: '7'
- image: /local/Pictures/veronica_tv.png
number: '8'
- image: /local/Pictures/net5.png
number: '9'
- image: /local/Pictures/rtl8.png
number: '10'
- image: /local/Pictures/starchannel.png
number: '11'
- image: /local/Pictures/ziggosport.png
number: '12'
- image: /local/Pictures/comedycentral.png
number: '13'
- image: /local/Pictures/sbs9nw.png
number: '14'
- image: /local/Pictures/vrt1.png
number: '15'
- image: /local/Pictures/vrtcanvas.png
number: '16'
- image: /local/Pictures/ketnet.png
number: '17'
- image: /local/Pictures/npo1extra.png
number: '18'
- image: /local/Pictures/omroepgelderland.png
number: '19'
- image: /local/Pictures/omroepwest.png
number: '20'
- image: /local/Pictures/espn.png
number: '21'

Hi,
you are right, there was a mistake inside DirectionUp. Corrected. We'll find it in new Release.
Regarding OK Button, see bottom of Readme. There is described, how to debug, which command is sent if button is pressed. I did a test on my system, I can remap the "OK" button.
For the future, please do me a favor: If you have feature requests, please try to add one request for each issue. Otherwise I will loose overview in the future :-/
Anyway: Thank you for your support and your Ideas

could you please help me on this one, I can not get configured the OK button with Enter command
debugging did not give a clue
what wrong with my code:
type: custom:my-harmony-card
name: Harmony
entity: remote.woonkamer
tooltip: true
activities:
PowerOff:
name: Poweroff
device_id: -1
TV kijken:
name: '41379770'
device_id: '65398896'
player_name: media_player.mediabox
OK:
command: Enter
device_id: '65398896'
Button1:
name: MNu
command: Menu
tooltip: Menu
Button2:
name: Txt
command: Teletext
tooltip: Teletext
Button3:
name: Gui
command: Guide
tooltip: Guide
Button4:
name: DVR
command: DVR
tooltip: DVR
volume_device_id: '65398896'
Radio luisteren DAB:
name: '41379771'
device_id: '65398893'
volume_device_id: '65398893'
player_name: media_player.room1
Button1:
name: prv
command: PresetPrev
tooltip: PresetPrev
Button2:
name: nxt
command: PresetNext
tooltip: PresetNext
Button3: null
Button4: null
dimensions:
scale: '0.99'
border_width: 2px

Please Try OK: Enter

I already tried that without succes.
Strangely enough when I compare it with mamicio's remote the command is the same and works.
ENTER:
service: lghorizon.remote_key_press
data:
entity_id: media_player.mediabox
remote_key: Enter

Normally it can not be. In my installation ist is working. I do not see you indentation, maybe there is something wrong.
Here a part of your config as code. Please check:
type: custom:my-harmony-card
name: Harmony
entity: remote.woonkamer
tooltip: true
activities:
    PowerOff:
        name: Poweroff
        device_id: -1
    TV kijken:
        name: '41379770'
        device_id: '65398896'
        player_name: media_player.mediabox
        OK: Enter
        device_id: '65398896'  <-- why they are to device_id for TV kijken?!
        Button1:
            name: MNu`

device_id was extra attempt to get it worked but changed that with no succes thru:
TV kijken:
name: '41379770'
device_id: '65398896'
volume_device_id: '65398894'
player_name: media_player.mediabox
OK: Enter
Button1:
name: MNu
command: Menu
tooltip: Menu

is this what you're looking for ?

{var t,e;return this._button(null!==(e=null===(t=this.config.activities[this._current_activity])||void 0===t?void 0:t.OK)&&void 0!==e?e:"OK")}}>
                     OK

I'm terribely sorry for I found it out and it workes well.
OK in combination with the deviceid had to be 'Select' instead of 'Enter'
If it's OK by you this feature request/bug report can be closed and I make separate feature request instead.

made seperate feature requets for open items
this can be closed


64 | Minimum Path Sum | C++

Minimum Path Sum -
New Issue(solution) -
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] C++

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

I'd like to work on this problem

I want to work on this

I want this