Fixes to the resample docs

[x] Passes black . && mypy . && flake8
[ ] Fully documented, including whats-new.rst for all changes and api.rst for new API

The docs of resample fail to mention that resampling only works with datetime-like coords: the only part where one could get this from is the examples (the pandas docs are much more explicit). I'm not sure whether it would be good to also point this out in the function description. Thoughts?

Great, thanks @keewis

I'm not sure whether it would be good to also point this out in the function description. Thoughts?

Yes, I think that would be a welcome addition, if you want to add that too?

I was thinking about something like this:

Handles both downsampling and upsampling. The resampled dimension must be a datetime-like coordinate. If any intervals contain no values from the original object, they will be given the value NaN.

Is there something that works like this, but with non-datetime dimensions?

there is no label-aware function. coarsen is similar

I think reindex or interp / interpolate_na might help, but to reproduce this there is more work to do. I was hoping to link to the docs of a hypothetical other method that does the same for non-datetime coords.

@crusaderky The minimum versions CI thing is failing:
##[section]Starting: minimum versions policy
==============================================================================
Task         : Bash
Description  : Run a Bash script on macOS, Linux, or Windows
Version      : 3.151.3
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/bash
==============================================================================
Generating script.
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/6c2d03fe-5ca8-4c5b-ac96-dfc834f9dd00.sh
Collecting package metadata (current_repodata.json): ...working... done
Solving environment: ...working... done

## Package Plan ##

  environment location: /usr/share/miniconda

  added / updated specs:
    - pyyaml

The following packages will be downloaded:

    package                    |            build
    ---------------------------|-----------------
    ca-certificates-2019.8.28  |                0         132 KB
    certifi-2019.9.11          |           py37_0         154 KB
    conda-4.7.12               |           py37_0         3.0 MB
    openssl-1.1.1d             |       h7b6447c_2         2.5 MB
    pyyaml-5.1.2               |   py37h7b6447c_0         179 KB
    ------------------------------------------------------------
                                           Total:         6.0 MB

The following NEW packages will be INSTALLED:

  pyyaml             pkgs/main/linux-64::pyyaml-5.1.2-py37h7b6447c_0

The following packages will be UPDATED:

  ca-certificates                               2019.5.15-0 --> 2019.8.28-0
  certifi                                  2019.6.16-py37_0 --> 2019.9.11-py37_0
  conda                                       4.7.10-py37_0 --> 4.7.12-py37_0
  openssl                                 1.1.1c-h7b6447c_1 --> 1.1.1d-h7b6447c_2

Downloading and Extracting Packages

openssl-1.1.1d       | 2.5 MB    |            |   0%
openssl-1.1.1d       | 2.5 MB    | ########## | 100%

ca-certificates-2019 | 132 KB    |            |   0%
ca-certificates-2019 | 132 KB    | ########## | 100%

certifi-2019.9.11    | 154 KB    |            |   0%
certifi-2019.9.11    | 154 KB    | ########## | 100%

conda-4.7.12         | 3.0 MB    |            |   0%
conda-4.7.12         | 3.0 MB    | ########## | 100%

pyyaml-5.1.2         | 179 KB    |            |   0%
pyyaml-5.1.2         | 179 KB    | ########## | 100%
Preparing transaction: ...working... done
Verifying transaction: ...working... done
Executing transaction: ...working... done
Analyzing python...
Analyzing numpy...
Analyzing pandas...
Package       Required          Policy            Status
------------- ----------------- ----------------- ------
python        3.6  (2016-12-23) 3.6  (2016-12-23) =
numpy         1.14 (2018-01-09) 1.14 (2018-01-09) =
pandas        0.24 (2019-01-25) 0.24 (2019-01-25) =

# >>>>>>>>>>>>>>>>>>>>>> ERROR REPORT <<<<<<<<<<<<<<<<<<<<<<

    Traceback (most recent call last):
      File "/usr/share/miniconda/lib/python3.7/site-packages/conda/exceptions.py", line 1074, in __call__
        return func(*args, **kwargs)
      File "/usr/share/miniconda/lib/python3.7/site-packages/conda/cli/main.py", line 84, in _main
        exit_code = do_call(args, p)
      File "/usr/share/miniconda/lib/python3.7/site-packages/conda/cli/conda_argparse.py", line 82, in do_call
        exit_code = getattr(module, func_name)(args, parser)
      File "/usr/share/miniconda/lib/python3.7/site-packages/conda/cli/main_search.py", line 73, in execute
        matches = sorted(SubdirData.query_all(spec, channel_urls, subdirs),
      File "/usr/share/miniconda/lib/python3.7/site-packages/conda/core/subdir_data.py", line 97, in query_all
        result = tuple(concat(executor.map(subdir_query, channel_urls)))
      File "/usr/share/miniconda/lib/python3.7/concurrent/futures/_base.py", line 586, in result_iterator
        yield fs.pop().result()
      File "/usr/share/miniconda/lib/python3.7/concurrent/futures/_base.py", line 432, in result
        return self.__get_result()
      File "/usr/share/miniconda/lib/python3.7/concurrent/futures/_base.py", line 384, in __get_result
        raise self._exception
      File "/usr/share/miniconda/lib/python3.7/concurrent/futures/thread.py", line 57, in run
        result = self.fn(*self.args, **self.kwargs)
      File "/usr/share/miniconda/lib/python3.7/site-packages/conda/core/subdir_data.py", line 90, in <lambda>
        package_ref_or_match_spec))
      File "/usr/share/miniconda/lib/python3.7/site-packages/conda/core/subdir_data.py", line 110, in query
        if param.match(prec):
      File "/usr/share/miniconda/lib/python3.7/site-packages/conda/models/match_spec.py", line 237, in match
        if not self._match_individual(rec, field_name, v):
      File "/usr/share/miniconda/lib/python3.7/site-packages/conda/models/match_spec.py", line 242, in _match_individual
        val = getattr(record, field_name)
    AttributeError: 'str' object has no attribute 'name'

`$ /usr/share/miniconda/bin/conda search numpy --info -c defaults -c conda-forge`

  environment variables:
BUILD_REPOSITORY_LOCALPATH=/home/vsts/work/1/s
                 CIO_TEST=<not set>
                    CONDA=/usr/share/miniconda
               CONDA_ROOT=/usr/share/miniconda
                     PATH=/usr/share/miniconda/bin:/usr/share/rust/.cargo/bin:/usr/local/sbin:/u
                          sr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin
       REQUESTS_CA_BUNDLE=<not set>
            SSL_CERT_FILE=<not set>

     active environment : None
       user config file : /home/vsts/.condarc
 populated config files :
          conda version : 4.7.12
    conda-build version : not installed
         python version : 3.7.3.final.0
       virtual packages :
       base environment : /usr/share/miniconda  (writable)
           channel URLs : https://repo.anaconda.com/pkgs/main/linux-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/linux-64
                          https://repo.anaconda.com/pkgs/r/noarch
                          https://conda.anaconda.org/conda-forge/linux-64
                          https://conda.anaconda.org/conda-forge/noarch
          package cache : /usr/share/miniconda/pkgs
                          /home/vsts/.conda/pkgs
       envs directories : /usr/share/miniconda/envs
                          /home/vsts/.conda/envs
               platform : linux-64
             user-agent : conda/4.7.12 requests/2.22.0 CPython/3.7.3 Linux/4.15.0-1059-azure ubuntu/16.04.6 glibc/2.23
                UID:GID : 1001:117
             netrc file : None
           offline mode : False

An unexpected error has occurred. Conda has prepared the above report.

Analyzing python...
Analyzing boto3...
Analyzing bottleneck...
Analyzing cartopy...
Analyzing cdms2...
Analyzing cfgrib...
Analyzing cftime...
Analyzing dask...
Analyzing distributed...
Analyzing h5netcdf...
Analyzing h5py...
Analyzing hdf5...
Analyzing iris...
Analyzing lxml...
Analyzing matplotlib...
Analyzing nc-time-axis...
Analyzing netcdf4...
Analyzing numba...
Analyzing numpy...
Analyzing pandas...
Analyzing pseudonetcdf...
Analyzing pydap...
Analyzing pynio...
Analyzing rasterio...
Analyzing scipy...
Analyzing seaborn...
Analyzing toolz...
Analyzing zarr...
Traceback (most recent call last):
  File "ci/min_deps_check.py", line 187, in <module>
    main()
  File "ci/min_deps_check.py", line 175, in main
    rows = [f.result() for f in futures]
  File "ci/min_deps_check.py", line 175, in <listcomp>
    rows = [f.result() for f in futures]
  File "/usr/share/miniconda/lib/python3.7/concurrent/futures/_base.py", line 432, in result
    return self.__get_result()
  File "/usr/share/miniconda/lib/python3.7/concurrent/futures/_base.py", line 384, in __get_result
    raise self._exception
  File "/usr/share/miniconda/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "ci/min_deps_check.py", line 127, in process_pkg
    versions = query_conda(pkg)
  File "ci/min_deps_check.py", line 72, in query_conda
    ["conda", "search", pkg, "--info", "-c", "defaults", "-c", "conda-forge"]
  File "/usr/share/miniconda/lib/python3.7/subprocess.py", line 395, in check_output
    **kwargs).stdout
  File "/usr/share/miniconda/lib/python3.7/subprocess.py", line 487, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['conda', 'search', 'numpy', '--info', '-c', 'defaults', '-c', 'conda-forge']' returned non-zero exit status 1.
##[error]Bash exited with code '1'.
##[section]Finishing: minimum versions policy

I'm not sure why, but this seems to be a random error: with the new commit it passes

weird. the docstring looks good to me. Feel free to give yourself credit in whats-new I'll merge after that's done.

Thanks!

@dcherian that's not my script's fault. It's the bash command conda search numpy --info -c defaults -c conda-forge.
I've never seen that error... let me know if it happens again.

Thanks @keewis !


Wrong parsing of lines with query result info

After upgrading pgbadger from 10.3 to 11.4 I see in "Top" section entries looks like (some info anonymized):

but at same time some queries looks normally

(I think that queries returns no rows)
Log parameters of my database are:

I have not found any similar cases, so what to do?

I think you have not just upgraded pgbadger but also change the log_line_prefix. Please use -p to set the log line prefix accordingly to your log_line_prefix value. Some statements are well reported because there is some queries with the old format in your log.

Thank you for answer, but no.
I made pure case. I extracted one line from log file as it is and added its copy without info about rows and size. I attach this example here as pgsql_log_test.log
Then I got my log_line_prefix from test DB:
-bash-4.4$ psql -c 'show log_line_prefix'
              log_line_prefix
--------------------------------------------
 %t [%p]: [%l-1] us=%u,db=%d,app=%a,cli=%h

And ran pgbadger with these options:
/usr/bin/pgbadger -f stderr --prefix '%t [%p]: [%l-1] us=%u,db=%d,app=%a,cli=%h' ./pgsql_log_test.log -o ./pgbadger-test.html
pgsql_log_test.log
Result on screenshot.

What is the version of PostgreSQL? Looks like this is not an official version, where did you get it?

Yes, it's PostgresPro 11 Enterprise.
But it's strange that old version of pgbadger (as I remember it was 10.3) worked properly with these logs, observed effect began after upgrade to 11.4

Ok, commit 2273d73 add compatibility with the PostgresPro log file. This is a quick fix to parse correctly the lines that have the additional rows and size information, but @postgrespro it could be interesting to have additional reports like "Top most returning rows" and  "Top most size" statement.

Great! It works! Thank you so much for support.


VScode freezes upon trying to move a file

VSCode Version: 1.28
OS Version: OSX 10.12.6

Steps to Reproduce:

Try to move a file or a folder
My whole session in VSCode freezes.  I can to things from the dropdown menus, but I can't click anything and the keyboard shortcuts all stop working.  This has arisen since I upgraded to 1.28 just a few hours ago.  It also appears that the same bug on my end is happening in VSCode Insiders.

Any thoughts or ideas?

Does this issue occur when all extensions are disabled?: Yes/No

I have similar issue, although it freezes just by trying to use auto-complete in TS file.

Apparently I also can't move tabs around.  Same behavior results.  My ability to type or click things with the mouse breaks.  I can access dropdown menus, and even select options in them...

I just traced it down to ms-vscode.typescript-javascript-grammar extension, disabling of which solved the issue. Do you have that installed and does disabling it help?

@burtek Even restarting the program with extensions disabled doesn't fix it for me. Not sure what it might be.   I don't think I have any typescript extensions installed either.

Can you please follow the steps in https://github.com/Microsoft/vscode/wiki/Native-Crash-Issues to get at more details around the crash and attach the result here? Thanks!


Set version to 0.2.0, remove Django 1.7 from requirements and testing

As discussed in #433 and #420, removing out-of-support Django 1.7 from latest branch. Setting version to 0.2.0.
I suggest merging this one in, then any other milestone 0.2 PRs. Then making a 0.2.0 official release and tag it (possibly on a new 0.2 branch for further development?).

Did we go through all the old PRs? We should merge anything else small before we branch for 0.2 and merge this one.

Current coverage is 49.79% (diff: 100%)

Merging #436 into master will increase coverage by 4.21%

@@             master       #436   diff @@
==========================================
  Files            31         31
  Lines          2975       4171   +1196
  Methods           0          0
  Messages          0          0
  Branches        475        881    +406
==========================================
+ Hits           1356       2077    +721
- Misses         1514       1929    +415
- Partials        105        165     +60

Powered by Codecov. Last update 5e34033...3c8169a

I just checked the other PRs and @flinz had already given a helpful push forwards to any that were in a position to make progress. The others are waiting either for a response from contributor or for a 0.2 brach to move to! :)

I failed to notice that #438 was based on the branch you started here, and so, mistakenly thinking I'd merged this already due to the lack of conflicts, I merged #438 first and thus your commits were added via that PR instead of this one. 😳 My sincere apologies for the out-of-order screw up! 🙇

First of all I should apologize for doing strange things sometimes in PR --my fault. However, I don't recall having #438 base on this one (I remember messing a little bit, from lazyness, on #374, which is based on #438, but #438 was intended to be based on master).
I was checking and master seems to not have the 0.2 changes yet. So this branch can be merged, I think.

Nothing to apologize for @alexbarcelo, it's entirely my fault! I was doubly mistaken, but thanks to your correction I think I found the root error: somehow I managed to swap the ID numbers used as branch names for the PRs I was pulling to local while testing what order to merge them in. 😩

Sorry again for complicating a simple merge, my apologies for all the noise, and thanks for all your efforts! 😅


#444 leeway implementation

@Andrew-Chen-Wang thanks for the suggestion

Thanks for implementing the tests!


UX improvements

[ ] hide the less important table properties and display them on demand (using a collapsible block)
[x] remove the switches for pipelines and outputs in the left panel, unify them with the output boxes in the right panel (the switch will be just a small button available at the related output box)
[x] integrate the pipeline switches with pipeline setttings: e.g. add a small cogwheel at the top of the output box

[ ] Get rid of the horizontal scrollbar 😁 (if it's not too hard to do)

@tuetschek Can you attach a screenshot where you have it? I see it only for the tables which do not fit the screen horizontally (and I think it's good to have it in these cases).

@kasnerz sure – here it is :-)

Not sure what the problem is, maybe it's OS-related? I can see the scrollbar both in Firefox and Chrome.

@tuetschek Fixed in<PHONE_NUMBER>d7d588c94f632eb70e22a4cd575430

@kasnerz awesome, thank you 😍!


Control other RF Blinds

Describe you new feature you'd like
It colud be possible to extend this project for normal RF Blinds? it is really complicate to set a normal RF blind in ESP, you need to cipher the code to copy it and reproduce the RAW code after... and the way it calculate the position is really bad, this project would be the solution for many users that have non Somfy blinds
It wold be nice to make it as easy as is to add a somfy blind for any RF motorized blinds

What is meant by a 'normal' RF blind? It may be difficult to determine without a precise specification due to the numerous radio protocols available. Additionally, the frequency range presents a unique challenge as Somfy operates on 433.42 MHz, which differs from the more common 433.92 MHz used by other 433 MHz applications. This makes the parallel operation of Somfy and other radio receivers a particular challenge...

Oh no i dont mean to control both at same time, i just mean use this easy and nice gui way to also config other blinds, remote controled rf blinds.
To make it easy to copy the rf signal from the remote and make it as a time based covers, just to make it user friendly asi it is right now for somfy, maybe the user can set up the frecuancy as the specs of the remote and then make it a easier way to configure than the code based esphome that you have to cipher the whole dump to see what to use of the raw data...

Did you know that many of the 433.92 motors are actually already supported by changing the base frequency to 433.92 then using the RTW or RTV protocol?  However, the transceiver can only be set to one base frequency and it must conform to either a 56 bit or 80 bit transmission packet.   Not all motors conform to this.

No i didnt ok i will try that, thanks, i tried to read a remote signal,  setting the frecuency at 433.92 but didnt work, but i will try again to see if i can make it work

I am closing this for now and assume you got this sorted.


refactor(swamp/tests)skip tests

Overview

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #2802 (a1c46b5) into main (20c7476) will increase coverage by 0.15%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2802      +/-   ##
==========================================
+ Coverage   51.81%   51.97%   +0.15%
==========================================
  Files         161      161
  Lines       10827    10827
==========================================
+ Hits         5610     5627      +17
+ Misses       4721     4707      -14
+ Partials      496      493       -3

see 7 files with indirect coverage changes

==================
[88](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:89)
WARNING: DATA RACE
[89](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:90)
Write at 0x00c00f2abe40 by goroutine 5541:
[90](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:91)
  sync/atomic.StoreInt64()
[91](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:92)
      /opt/hostedtoolcache/go/1.21.1/x64/src/runtime/race_amd64.s:237 +0xb
[92](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:93)
  sync/atomic.StorePointer()
[93](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:94)
      /opt/hostedtoolcache/go/1.21.1/x64/src/runtime/atomic_pointer.go:82 +0x44
[94](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:95)
  github.com/celestiaorg/celestia-node/share/p2p/peers.(*Manager).newPeer.(*Manager).doneFunc.func1()
[95](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:96)
      /home/runner/work/celestia-node/celestia-node/share/p2p/peers/manager.go:280 +0x32a
[96](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:97)
  github.com/celestiaorg/celestia-node/share/getters.(*ShrexGetter).GetEDS()
[97](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:98)
      /home/runner/work/celestia-node/celestia-node/share/getters/shrex.go:159 +0x9a1
[98](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:99)
  github.com/celestiaorg/celestia-node/share/getters.(*CascadeGetter).GetEDS.func1()
[99](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:100)
      /home/runner/work/celestia-node/celestia-node/share/getters/cascade.go:61 +0x56
[100](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:101)
  github.com/celestiaorg/celestia-node/share/getters.cascadeGetters[go.shape.*uint8]()
[101](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:102)
      /home/runner/work/celestia-node/celestia-node/share/getters/cascade.go:124 +0x7ca
[102](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:103)
  github.com/celestiaorg/celestia-node/share/getters.(*CascadeGetter).GetEDS()
[103](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:104)
      /home/runner/work/celestia-node/celestia-node/share/getters/cascade.go:64 +0x17b
[104](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:105)
  github.com/celestiaorg/celestia-node/share/availability/full.(*ShareAvailability).SharesAvailable()
[105](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:106)
      /home/runner/work/celestia-node/celestia-node/share/availability/full/availability.go:82 +0x2d2
[106](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:107)
  github.com/celestiaorg/celestia-node/das.(*DASer).sample()
[107](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:108)
      /home/runner/work/celestia-node/celestia-node/das/daser.go:150 +0xd2
[108](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:109)
  github.com/celestiaorg/celestia-node/das.(*DASer).sample-fm()
[109](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:110)
      <autogenerated>:1 +0x55
[110](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:111)
  github.com/celestiaorg/celestia-node/das.(*worker).sample()
[111](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:112)
      /home/runner/work/celestia-node/celestia-node/das/worker.go:114 +0x13e
[112](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:113)
  github.com/celestiaorg/celestia-node/das.(*worker).run()
[113](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:114)
      /home/runner/work/celestia-node/celestia-node/das/worker.go:79 +0x244
[114](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:115)
  github.com/celestiaorg/celestia-node/das.(*samplingCoordinator).runWorker.func1()
[115](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:116)
      /home/runner/work/celestia-node/celestia-node/das/coordinator.go:112 +0x113
[116](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:117)

[117](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:118)
Previous read at 0x00c00f2abe40 by goroutine 5542:
[118](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:119)
  github.com/celestiaorg/celestia-node/share/p2p/peers.(*Manager).Peer()
[119](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:120)
      /home/runner/work/celestia-node/celestia-node/share/p2p/peers/manager.go:226 +0x204
[120](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:121)
  github.com/celestiaorg/celestia-node/share/getters.(*ShrexGetter).GetEDS()
[121](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:122)
      /home/runner/work/celestia-node/celestia-node/share/getters/shrex.go:143 +0x324
[122](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:123)
  github.com/celestiaorg/celestia-node/share/getters.(*CascadeGetter).GetEDS.func1()
[123](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:124)
      /home/runner/work/celestia-node/celestia-node/share/getters/cascade.go:61 +0x56
[124](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:125)
  github.com/celestiaorg/celestia-node/share/getters.cascadeGetters[go.shape.*uint8]()
[125](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:126)
      /home/runner/work/celestia-node/celestia-node/share/getters/cascade.go:124 +0x7ca
[126](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:127)
  github.com/celestiaorg/celestia-node/share/getters.(*CascadeGetter).GetEDS()
[127](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:128)
      /home/runner/work/celestia-node/celestia-node/share/getters/cascade.go:64 +0x17b
[128](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:129)
  github.com/celestiaorg/celestia-node/share/availability/full.(*ShareAvailability).SharesAvailable()
[129](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:130)
      /home/runner/work/celestia-node/celestia-node/share/availability/full/availability.go:82 +0x2d2
[130](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:131)
  github.com/celestiaorg/celestia-node/das.(*DASer).sample()
[131](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:132)
      /home/runner/work/celestia-node/celestia-node/das/daser.go:150 +0xd2
[132](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:133)
  github.com/celestiaorg/celestia-node/das.(*DASer).sample-fm()
[133](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:134)
      <autogenerated>:1 +0x55
[134](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:135)
  github.com/celestiaorg/celestia-node/das.(*worker).sample()
[135](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:136)
      /home/runner/work/celestia-node/celestia-node/das/worker.go:114 +0x13e
[136](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:137)
  github.com/celestiaorg/celestia-node/das.(*worker).run()
[137](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:138)
      /home/runner/work/celestia-node/celestia-node/das/worker.go:79 +0x244
[138](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:139)
  github.com/celestiaorg/celestia-node/das.(*samplingCoordinator).runWorker.func1()
[139](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:140)
      /home/runner/work/celestia-node/celestia-node/das/coordinator.go:112 +0x113
[140](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:141)

[141](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:142)
Goroutine 5541 (running) created at:
[142](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:143)
  github.com/celestiaorg/celestia-node/das.(*samplingCoordinator).runWorker()
[143](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:144)
      /home/runner/work/celestia-node/celestia-node/das/coordinator.go:110 +0x484
[144](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:145)
  github.com/celestiaorg/celestia-node/das.(*samplingCoordinator).run()
[145](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:146)
      /home/runner/work/celestia-node/celestia-node/das/coordinator.go:85 +0x7e7
[146](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:147)
  github.com/celestiaorg/celestia-node/das.(*DASer).Start.func1()
[147](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:148)
      /home/runner/work/celestia-node/celestia-node/das/daser.go:110 +0xb3
[148](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:149)

[149](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:150)
Goroutine 5542 (running) created at:
[150](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:151)
  github.com/celestiaorg/celestia-node/das.(*samplingCoordinator).runWorker()
[151](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:152)
      /home/runner/work/celestia-node/celestia-node/das/coordinator.go:110 +0x484
[152](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:153)
  github.com/celestiaorg/celestia-node/das.(*samplingCoordinator).run()
[153](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:154)
      /home/runner/work/celestia-node/celestia-node/das/coordinator.go:78 +0x8e6
[154](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:155)
  github.com/celestiaorg/celestia-node/das.(*DASer).Start.func1()
[155](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:156)
      /home/runner/work/celestia-node/celestia-node/das/daser.go:110 +0xb3
[156](https://github.com/celestiaorg/celestia-node/actions/runs/6391985820/job/17348326468?pr=2802#step:5:157)
==================

with -race flag
--- FAIL: TestSyncAgainstBridge_NonEmptyChain (17.79s)
https://github.com/celestiaorg/celestia-node/actions/runs/6393679580/job/17353406273?pr=2802#step:5:227
    swamp.go:107:
https://github.com/celestiaorg/celestia-node/actions/runs/6393679580/job/17353406273?pr=2802#step:5:228
        	Error Trace:	/home/runner/work/celestia-node/celestia-node/nodebuilder/tests/swamp/swamp.go:107
https://github.com/celestiaorg/celestia-node/actions/runs/6393679580/job/17353406273?pr=2802#step:5:229
        	            				/home/runner/go/pkg/mod/golang.org/x/exp@v0.0.0-20230817173708-d852ddb80c63/maps/maps.go:90
https://github.com/celestiaorg/celestia-node/actions/runs/6393679580/job/17353406273?pr=2802#step:5:230
        	            				/home/runner/work/celestia-node/celestia-node/nodebuilder/tests/swamp/swamp.go:106
https://github.com/celestiaorg/celestia-node/actions/runs/6393679580/job/17353406273?pr=2802#step:5:231
        	            				/opt/hostedtoolcache/go/1.21.1/x64/src/testing/testing.go:1169
https://github.com/celestiaorg/celestia-node/actions/runs/6393679580/job/17353406273?pr=2802#step:5:232
        	            				/opt/hostedtoolcache/go/1.21.1/x64/src/testing/testing.go:1347
https://github.com/celestiaorg/celestia-node/actions/runs/6393679580/job/17353406273?pr=2802#step:5:233
        	            				/opt/hostedtoolcache/go/1.21.1/x64/src/testing/testing.go:1589
https://github.com/celestiaorg/celestia-node/actions/runs/6393679580/job/17353406273?pr=2802#step:5:234
        	Error:      	Received unexpected error:
https://github.com/celestiaorg/celestia-node/actions/runs/6393679580/job/17353406273?pr=2802#step:5:235
        	            	node: failed to stop within timeout(2m0s): context deadline exceeded
https://github.com/celestiaorg/celestia-node/actions/runs/6393679580/job/17353406273?pr=2802#step:5:236
        	Test:       	TestSyncAgainstBridge_NonEmptyChain

--- FAIL: TestShrexNDFromLights (10.95s)
https://github.com/celestiaorg/celestia-node/actions/runs/6393884735/job/17354064855?pr=2802#step:5:726
    full_node.go:181: tearing down testnode
https://github.com/celestiaorg/celestia-node/actions/runs/6393884735/job/17354064855?pr=2802#step:5:727
    testing.go:1465: race detected during execution of test

--- FAIL: TestSyncLightWithTrustedPeers (25.79s)
https://github.com/celestiaorg/celestia-node/actions/runs/6393884735/job/17354064855?pr=2802#step:5:5885)
    swamp.go:107:
https://github.com/celestiaorg/celestia-node/actions/runs/6393884735/job/17354064855?pr=2802#step:5:5886)
        	Error Trace:	/home/runner/work/celestia-node/celestia-node/nodebuilder/tests/swamp/swamp.go:107
https://github.com/celestiaorg/celestia-node/actions/runs/6393884735/job/17354064855?pr=2802#step:5:5887)
        	            				/home/runner/go/pkg/mod/golang.org/x/exp@v0.0.0-20230817173708-d852ddb80c63/maps/maps.go:90
https://github.com/celestiaorg/celestia-node/actions/runs/6393884735/job/17354064855?pr=2802#step:5:5888)
        	            				/home/runner/work/celestia-node/celestia-node/nodebuilder/tests/swamp/swamp.go:106
https://github.com/celestiaorg/celestia-node/actions/runs/6393884735/job/17354064855?pr=2802#step:5:5889)
        	            				/opt/hostedtoolcache/go/1.21.1/x64/src/testing/testing.go:1169
https://github.com/celestiaorg/celestia-node/actions/runs/6393884735/job/17354064855?pr=2802#step:5:5890)
        	            				/opt/hostedtoolcache/go/1.21.1/x64/src/testing/testing.go:1347
https://github.com/celestiaorg/celestia-node/actions/runs/6393884735/job/17354064855?pr=2802#step:5:5891)
        	            				/opt/hostedtoolcache/go/1.21.1/x64/src/testing/testing.go:1589
https://github.com/celestiaorg/celestia-node/actions/runs/6393884735/job/17354064855?pr=2802#step:5:5892)
        	Error:      	Received unexpected error:
https://github.com/celestiaorg/celestia-node/actions/runs/6393884735/job/17354064855?pr=2802#step:5:5893
        	            	node: failed to stop within timeout(2m0s): context deadline exceeded
https://github.com/celestiaorg/celestia-node/actions/runs/6393884735/job/17354064855?pr=2802#step:5:5894
        	Test:       	TestSyncLightWithTrustedPeers
https://github.com/celestiaorg/celestia-node/actions/runs/6393884735/job/17354064855?pr=2802#step:5:5895
    full_node.go:181: tearing down testnode
https://github.com/celestiaorg/celestia-node/actions/runs/6393884735/job/17354064855?pr=2802#step:5:5896
    testing.go:1465: race detected during execution of test

--- FAIL: TestSyncStartStopLightWithBridge (14.26s)
[4762](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:4763)
    swamp.go:107:
[4763](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:4764)
        	Error Trace:	/home/runner/work/celestia-node/celestia-node/nodebuilder/tests/swamp/swamp.go:107
[4764](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:4765)
        	            				/home/runner/go/pkg/mod/golang.org/x/exp@v0.0.0-20230817173708-d852ddb80c63/maps/maps.go:90
[4765](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:4766)
        	            				/home/runner/work/celestia-node/celestia-node/nodebuilder/tests/swamp/swamp.go:106
[4766](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:4767)
        	            				/opt/hostedtoolcache/go/1.21.1/x64/src/testing/testing.go:1169
[4767](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:4768)
        	            				/opt/hostedtoolcache/go/1.21.1/x64/src/testing/testing.go:1347
[4768](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:4769)
        	            				/opt/hostedtoolcache/go/1.21.1/x64/src/testing/testing.go:1589
[4769](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:4770)
        	Error:      	Received unexpected error:
[4770](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:4771)
        	            	node: failed to stop within timeout(2m0s): context deadline exceeded
[4771](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:4772)
        	Test:       	TestSyncStartStopLightWithBridge
[4772](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:4773)
    full_node.go:181: tearing down testnode
[4773](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:4774)
    testing.go:1465: race detected during execution of test

--- FAIL: TestSyncLightAgainstFull (16.87s)
[5451](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:5452)
    swamp.go:107:
[5452](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:5453)
        	Error Trace:	/home/runner/work/celestia-node/celestia-node/nodebuilder/tests/swamp/swamp.go:107
[5453](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:5454)
        	            				/home/runner/go/pkg/mod/golang.org/x/exp@v0.0.0-20230817173708-d852ddb80c63/maps/maps.go:90
[5454](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:5455)
        	            				/home/runner/work/celestia-node/celestia-node/nodebuilder/tests/swamp/swamp.go:106
[5455](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:5456)
        	            				/opt/hostedtoolcache/go/1.21.1/x64/src/testing/testing.go:1169
[5456](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:5457)
        	            				/opt/hostedtoolcache/go/1.21.1/x64/src/testing/testing.go:1347
[5457](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:5458)
        	            				/opt/hostedtoolcache/go/1.21.1/x64/src/testing/testing.go:1589
[5458](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:5459)
        	Error:      	Received unexpected error:
[5459](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:5460)
        	            	node: failed to stop within timeout(2m0s): context deadline exceeded
[5460](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:5461)
        	Test:       	TestSyncLightAgainstFull
[5461](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:5462)
    full_node.go:181: tearing down testnode
[5462](https://github.com/celestiaorg/celestia-node/actions/runs/6394231754/job/17355184018?pr=2802#step:5:5463)
    testing.go:1465: race detected during execution of test

--- FAIL: TestBridgeNodeAsBootstrapper (5.88s)
[1356](https://github.com/celestiaorg/celestia-node/actions/runs/6394494464/job/17356459336#step:5:1357)
    full_node.go:181: tearing down testnode
[1357](https://github.com/celestiaorg/celestia-node/actions/runs/6394494464/job/17356459336#step:5:1358)
    testing.go:1465: race detected during execution of test

@vgonkivs going to close this one and pick up where you got to in another branch with current set of work on trying to clean up flakiness etc


Upgrade to bootstrap 5.2.0

Mazer v2.0 will be released after these features implemented:

Upgrade to Bootstrap v5.2.0
Adding pages for components (popovers, offcanvas, toasts, etc)

hey 🙋♂ can you add me

@zuramai

I also want to contribute to this project

Hi @bagussatoto @Harixomxsingh, you can read the CONTRIBUTING.md and create a pull request.

ok I am working on it, when my work is done then I create a PR

Closed as ed73f6de771e464d5d74e4c8ece213e419830bfe


Feat/GitHub workflow

What does your PR address?
This adds a github workflow that runs vitest, pnmp lint and pnpm check on every pull request and push to dev
I disabled all currently violated eslint rules, and autofixed those that could be autofixed.
pnpm check still reports errors so it should probably be disabled for now. (or kept as a reminder to fix it soon)
Also I hope that the workflow really works, because the only way to really test a github workflow is to submit a pull request that runs it.

@niktek tagging you to review this as well.
@christophsturm We have a guidelines that non-trivial updates require prior discussion, per:
https://www.skeleton.dev/docs/contributions/requirements
This saves everyone time if we decide the the work is not something we wish to move on yet. I see you asked in Discord, but did not follow Dominik's instruction to reach out in #contributors (again for prior discussion), and never got a proper thumbs up from Nik or myself (core maintainers).
First things first, I need to know more about how this works:

When a user submits a PR that fails one of these tests, how are they informed of failure?
Does this block the PR from being submitted altogether?
What about a commit to a PR already present? Will it fail if there's a missing semicolon, etc?

General idea is we use draft PRs a lot, and those aren't always in a complete and production-ready shape. They're not always ready for linting or tests to be run against them. We might be testing a proposed change and failure messages or anything blocking that process would be more detrimental than useful.

@endigo9740 I did read the guidelines, I just made this pr anyway because I had the workflow file in one of my private projects already, so I thought I make a PR to just show the general idea.
now to your questions, they all are not really specific to this workflow, but are more generally about github ci workflows

When a user submits a PR that fails one of these tests, how are they informed of failure?
Does this block the PR from being submitted altogether?
What about a commit to a PR already present? Will it fail if there's a missing semicolon, etc?

@christophsturm First off we appreciate the attempt to help, but unfortunately I don't think this is something we're going to be able to accept. There's a number of flaws in execution here:

Acknowledging but failing to follow our contribution guidelines, especially prior discussion
Disabling, rather than resolving, linting issues
Plus this is an inherently flawed way to go about this, it's occuring post-commit rather than pre-commit

We've had some internal discussion about introducing Husky Hooks, which would allow for these sorts of checks in a pre-commit stage. I think that'll be MUCH more valuable and much easier for folks to act on, given they get the immediate feedback and we're not deploying code that doesn't met a certain threshold of expectations.
If you wish to help with this effort, I might suggest you sync with @ryceg on Discord (he's an Aussie, so mind the timezones) and let's discuss this upfront and decide on a plan to act. Thanks!

no problem, i just wanted to show how I would do it. this was basically the start of the "discussion" step

Disabling, rather than resolving, linting issues

I disabled them because I did not want to do everything in one PR. They are not meant to stay disabled

Plus this is an inherently flawed way to go about this, it's occuring post-commit rather than pre-commit

This is meant to run in addition to checks that the users run pre commit. It is for checking pull requests before they are merged.

All good - even closed we can still reference and learn from this PR. The core team and I are discussing some ideas for this but no conclusions yet. Basically we're still in flux about where and how these checks are going to be implemented. Once we can wrap our head around that we can start figuring out some actionable goals.


not compulsory questions

if i have qestions which are not mandatory then how to handle this

Same problem here. I would love to be able to "skip" some multiple options questions without any option selected.
e.g. minMultiSelect: 0, which currently throws an error for me.


CouncilmeetingManagePage

Coverage decreased (-3.4%) to 66.949% when pulling f1bde7ec9081328d788d7dbdb863e2cf588f3c9a on Jakousa:grappa1_components into 84a6ad8dcd6cf0bf3412eac5aa819a332ed094a3 on OhtuGrappa2:grappa1.


smoothcc is not in milliseconds and should allow > 100

Smoothcc should smooth the controller with a setting in milliseconds.
This is great for adding character to instrument control, it is not uncommon to see values of smoothcc > 1000.
Currently it is limited of 100, any greater and it resets to 0 (@jpcima edit), and it is not clear if the value is in milliseconds. Testing a value of 100 does not look like it is in milliseconds from measuring the resultant smoothing.

In the exponential model (cakewalk, old sfizz), it's an asymptotic time constant expressed in ms.
In linear, it's an exact time constant, but gets a full reset each CC that arrives, which is Aria behavior.
The deeper problem is duplicated with another issue, see also
https://github.com/sfztools/sfizz/issues/704#issuecomment-802729086


Bracket colorization for markdown links with mismatched parenthesizes

issue surfaced when testing: https://github.com/microsoft/vscode/issues/188867
It correctly displays with <> but the rightmost parenthesis is still highlighted red. Likely the bracket pair colorization isn't working properly in this case.

I am not sure if this is a problem with vs code or the language service, but I'm assuming it is the language service. Apologies in advance if I'm wrong.
The following snippet works fine, and the code highlighting in the editor works fine too, except when I wrap the type parameter.
snippet
export const mapResponse = {
  blogPost: <I extends { created: string; updated: string; }>(input: I) => {
    return {
      ...input,
      created: DateTime.fromISO(input.created),
      updated: DateTime.fromISO(input.updated)
    };
  }
};

return keyword is correctly identified as a keyword

return keyword is incorrectly identified as a type(?)

I have a similar issue. I am unsure if this is a related problem, or a separate one. Apologies in advance if I'm wrong.
The following snippet works fine, and the code highlighting in the editor works fine too, except when I wrap the type parameter.
snippet
export const mapResponse = {
  blogPost: <I extends { created: string; updated: string; }>(input: I) => {
    return {
      ...input,
      created: DateTime.fromISO(input.created),
      updated: DateTime.fromISO(input.updated)
    };
  }
};

return keyword is correctly identified as a keyword

return keyword is incorrectly identified as a type(?)


Setting the background mode to canvas in a WorldEnvironment node turns godot interface unusable (DisplayServer regression)

Godot version
v4.0.dev.20211117.official [175690957]
System information
Windows 10, Vulkan, NVIDIA GeForce GTX 970
Issue description
Adding a WorldEnvironment node to a scene and changing the Background mode to canvas make godot interface unusable.
All appearing items (the dropdown, windows, ...) appears the same color.

Steps to reproduce

Create a 2D scene
Add a WorldEnvironment node to the scene
Change Background mode to Canvas

Also, be aware that by changing the background mode to canvas in the "default_env.tres" the problem does not appear.
Minimal reproduction project
Black.zip

Duplicate of https://github.com/godotengine/godot/issues/52467.


GitHub part 2: repositories

This is the GitHub tutorial part 2. I'm starting this as a draft since I still need to add some images.

Closing, since this material has been added to #192.


Proposal to improve error message for Bad state: No element error by providing missing element details

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Use case
When requesting a field that does not exist from a Map, for example FirebaseDocument.data(). The error throws de following:
The following StateError was thrown building
InsuranceInOutPrivateCard-[<'HXuXEZJ6P6Bptn1Ju47a'>](dirty, state:
_InsuranceInOutPrivateCardState#48be0):
Bad state: No element

Which is good.
Proposal
However, it would be greater if the error message showed which "element" is requested. For example:
Bad state: no element at ....  and then the field that was requested.

@LauDijksterhuis thank you for filing this. However, Maps are implemented in the Dart SDK itself, so I would suggest filing this feature request at https://github.com/dart-lang/sdk/issues.

hi @christopherfujino
Thank you for your response, I will create a new issue over there.


update main branch to 'main' from 'master'

Need to coordinate with whatever is building/deploying the site.

@dontlaugh ?

raku.org is deployed on trinity.raku.org.
We can proceed with this change, I'll fix the deployment soon after that.

This change has been made. "main" is the default branch now.


Exception

These exceptions keep occurring when running the plugin. I don't know why. I'm not active in the GUI when these occur.
https://pastebin.com/dkd3Bd7k

how often does it occur?

this should be fixed in the latest update, let me know if it isnt as this is very hard to reproduce


Update remote debugging logic to use new status apis from app service

This issue is tracking the work for updating remote debugging logic to use new status apis from app service to get a more reliable status when remote debugging is enabled.

This work is already done several releases ago, so I'm closing this.


Populate changelog for the Hosting Image

Please edit this file: https://github.com/wedeploy/wedeploy.com/edit/master/node/electric/src/pages/updates/services/hosting/index.md

Fixed #337


"Struct as mapping key" chapter is no longer relevant

Or, at least, can be heavily simplified - we can now just #[derive(Hash)] on the struct and it can be used as a mapping key

Thanks for pointing this. It is indeed no longer relevant...


Fix oauth2 token refresh

It looks like #77 attempted to get this working, but didn't cover the case i've been running into.
Here is the documentation for the error response from google drive: https://developers.google.com/drive/v3/web/handle-errors#401_invalid_credentials
If the failed 401 (or 403) request includes the error in the response body, it gets parsed by the transporter and passed back as an error to the callback. This prevents the token from being refreshed based on the current conditional logic.
I've fixed this by adding an exception for these errors. I've also added tests for OAuth2Client#request() based on the ones for JWT#request() and made sure to cover this case with a failing test before adding the fix.
Let me know if you need anything else.

Coverage increased (+1.4%) to 94.038% when pulling e06ec2c15d078717c227d5b714000c91805e4ee1 on ianmetcalf:fix-oauth2-token-refresh into 968bf1ca81ce626fb303ef1e392fd74033364d74 on google:master.

Hey @ianmetcalf,
Would this PR solve my issue on https://github.com/google/google-auth-library-nodejs/issues/111? Can you have a look? What do you think?

Thanks @ianmetcalf


Split separate projects into their own packages

This is required to package the client side setup wizard and backup into executables for anyone to execute without having nodejs installed.

Checklist for this issue:
[ ] Convert repository into a Monorepo of server and setup packages
[ ] Fix type errors that show up from monorepo conversion
[ ] Add the pkg utility to package the setup wizards into executable files
[ ] Add a github action to auto-package the setup wizard on release

Closed by #9


Support multiple data models in the same process task

Description
We should start supporting multiple data models. Currently we only support one, and the logic is as follows:

If using layout-sets (or if stateless, as stateless apps require layout-sets), we use the data type defined for the current layout-set (in v4 we also make sure that data type is registered in applicationmetadata)
Otherwise, pick the first data type in applicationmetadata with a classRef and a taskId matching the current task ID.

In the future we should support multiple data models. That would have to include:

Supporting an array (or object mapping) of data models in layout-sets, not just one
Support in Studio for binding components to any of multiple data models
A mechanism for selecting which data model each component should bind to. Either by explicitly choosing the data model per binding, or by automatically selecting the matching data model using schema lookups.

Additional Information

#1175
#1485
#151 (maybe not relevant?)

Some thoughts on this:

I think its probably best to explicitly choose the data model when binding a component. Otherwise there are potential pit-falls if multiple data-models have fields with the same paths. I don't think we should impose a restriction of uniqueness to all data-model paths between all data models in the same step as this will be a headache for developers. This would probably be a breaking change, but it should be fixable with an upgrade script at least in data model bindings and expressions. For custom code, I am not sure how this will affect existing logic, but I don't think this choice will make a difference here anyway.
Schema validation:
Currently when validating against the data model schema, we validate the whole thing and each node picks out errors that have a matching data path to one of its data model bindings. This is rather inefficient for single field / few field validation, and would get even worse when having to validate x number of data models as well for large apps. There is a better way however. It is possible to specify a path in the schema to validate the data against, and that way, we can validate a subset of the form data against a subset of the schema, meaning we could validate fields individually which means we can choose to validate only the fields that have changed instead of everything all of the time. To do this however, we need to know the path in the schema that applies to a given data path. Luckily for us, the schema traversal code allowing us to see the schema for a given binding can likely easily be extended to also give you the path. What i'm thinking is that this information should be stored in the node item or something, so it only needs to be computed when the node is initialized.

I think its probably best to explicitly choose the data model when binding a component. Otherwise there are potential pit-falls if multiple data-models have fields with the same paths. I don't think we should impose a restriction of uniqueness to all data-model paths between all data models in the same step as this will be a headache for developers.

Yes, me and @RonnyB71 discussed the same thing just now. I've been thinking that it's the quickest way to something that works, and configuration-wise it would be compatible with all existing apps (that only use one data model). I've always thought that if two (or more) data models have the same path, we need to disable the component and produce an error in some way so that the app developer knows they need to specify the data model to use.
But at the same time, if every binding was explicit about which data model to use (along with all text resources with variables, and all expressions that are doing lookups in the data model), and if locking each data element is added as an optional system task in the BPMN process (and pointing to which data type(s) to lock), we could remove the configuration options tying every data model to a specific process task (in both layout-sets.json and applicationmetadata). I'm not sure we'll get there in time for v4, though - so maybe v5? 🤔

Schema validation
Agree 💯! A very good suggestion! Let each node handle their own validations, and call on them to provide changes once they happen. This might depend on #1182 to be implemented first, in order to make the whole node tree a bit more stable (right now all node object are garbage collected and re-created much too often).

A very relevant discussion regarding the specifics in this issue, including pros/cons of different approaches:

https://altinndevops.slack.com/archives/C045EB3JA9X/p1699534481187189


Port important files to fish

I have ported

activate.sh (important)
coverage.sh
build_inplace.sh (important)
build_variables.sh
build_dependencies_unix.sh (very important)

to fish, and also added a README for it (at run_me.sh and run_me.fish). activate.fish doesn't behave the same as activate.sh but I don't think anyone cares.

I don't want to duplicate all of the shell scripts. Why not just improve the existing scripts if there are changes to be made?
Alternatively if the shell scripts are not compatible with fish then perhaps migrate them to Python instead.
Longer term it would be better to move away from most of these scripts but the way to do that is first to change build system #52. The reason that I haven't done much to improve these scripts is just because they should really be commands that call into a build system i.e. most of this code should really be in meson files.

Ah, sorry for that. Yes, my main intent was just to make it compatible with both bash and fish, or more precisely just pushing the translations I have made.
Translating to Python would work, but I will have to look into it, I am not extremely familiar with it. As for new build systems, I will leave it for others.
I will close this for now then :)

Adding activate.fish is fine but for example we don't want a duplicate of build_variables.sh because that defines the versions that are used for the build which should only be defined in one place. Also build_dependencies_unix.sh is the script that is tested and used in CI and so we don't want to duplicate that and have to maintain two copies (with one not being tested).
Apart from activate.fish can you not just do bash bin/build_dependencies.sh to run the build under fish?
Python scripts would be better than a shell scripts though because it is better to avoid using shell scripts for anything more than just putting together a few commands. Anyone looking to build python-flint needs to have Python installed anyway so it is not an issue in that sense.
We would not have had this bug if Python was being used instead of shell scripts: #57

Oh yes, you are correct :facepalm: For a Python script, would something like this script I wrote suffice? Not sure if that is what you mean for a Python installation script? I am inexperienced with these things but I can try :D

For a Python script, would something like this script I wrote suffice

Yes, that's the sort of thing I was thinking.
I think that print statements are fine but I would use argparse to add command line options for all things.
It should support all of the things that are currently supported by bin/build_dependencies.sh and should then be used instead of bin/build_dependencies.sh in all relevant places:
$ git grep build_dependencies
bin/build_mingw64_wheel.sh:#bin/build_dependencies_unix.sh
bin/build_wheel.sh:# build_dependencies_unix.sh (which should be run first).
bin/cibw.sh:# bin/build_dependencies_unix.sh places headers and shared libraries under .local
bin/cibw_before_all_linux.sh:bin/build_dependencies_unix.sh\
bin/cibw_before_all_macosx_arm64.sh:bin/build_dependencies_unix.sh\
bin/cibw_before_all_macosx_x86_64.sh:bin/build_dependencies_unix.sh\
bin/cibw_before_all_windows.sh:bin/build_dependencies_unix.sh --use-gmp-github-mirror
doc/source/setup.rst:    bin/build_dependencies_unix.sh
doc/source/setup.rst:the ``build_dependencies_unix.sh`` script to work. After running the script,

The script also needs to be able to run on Linux, OSX and Windows in the msys2 shell.
If the script has non-stdlib dependencies (e.g. requests) then their should be instructions for installing those somewhere or a requirements.txt if there are many.

Okay! I will work on it.

The build_variables.sh file could also be removed and the versions could be set at the top of the new Python script.


travis-ci fix coverity build

This should make it easier to catch when it stops working.

Working again. https://travis-ci.org/PX4/Firmware/jobs/305661186


Joystick commands not received

I cannot receive Joystick commands: the callback that should receive the joystick values (Created in joystick_telemetry_init, in joystick_telemetry.cpp) has msgid 69 (MAVLINK_MSG_ID_MANUAL_CONTROL), but I'm only receiving messages with msgid 82 (MAVLINK_MSG_ID_SET_ATTITUDE_TARGET). Changing the value of msgid in joystick_telemetry_init did not solve the issue

Which version of QGroundControl are you using?
I believe in some of the version you can choose the type of messages sent by QGC for the joystick. Make sure that you choose the manual control type on the joystick toolbox.

I'm using version 2.7.1, and yes, this was the issue, I changed it to manual and it worked. Thank you


Add MD browser components, backed by Polymer

This is still pretty rough, but it was a working (not very well whitespaced) DetailView, with MD toolbars with all the various actions.
It comes with a basic demo port of the Chrome APIs app from FOAM 1, which is very, very incomplete.

PTAL

Conflicts repaired. PTAL.

LGTM.
I think we should add a TODO to try to eliminate explicit usage of the context when Elements support .start(SomeModel, args)


Feature Request: Add iOS Notification Service Extension to enable rich media pushes

The service extension needs to be added through expo plugins the way it is explained on the Marketing Cloud documentation.
I've done this locally for my project but would love to see it as part of this project instead. If there is support for this I can work on getting a PR in place.

I think it would be great if we could get a PR going on this. I'd be willing to test it out on my end.


Kubectl independence: Walking/Reading/Writing to Unstructured types with OpenAPI

It'd be nice to be able to use Unstructured types as easily as actual Go types.
We could give some thoughts to use OpenAPI to provide a nice framework to find fields, read values, and changes some fields.
This issue will track these efforts.
This is also orthogonal to fixing the union types in the kubernetes API (issue #?).

I'm working on this, but if anybody wants to help, I'd be more than happy to share some of the work. I'll probably come-up with a more detailed plan.

@apelisse hi, is this still wip, anything I could help here ?

Hi @shiywang, yeah I'm still working on this. If you need help finding something useful to do, I think we could talk on slack!

/remove-lifecycle stale
/lifecycle frozen

This should be possible currently with dynamic client and Unstructured type.
/close


Html terminal

This is the first working attempt to have a web version of oddly satisfying too.

Merging the tested code of the oddly satisfying, including the web edition mode.


Display errored test/file on genz test comparison

Tested on my PR
genz: === ☶ - Running test in examples/3_tests/tests/1_1_getter ===
running test in examples/3_tests/tests/1_1_getter
genz: generating template for type Car
genz: generated buffer (75 bytes)
genz: gofmt-ing buffer
genz: wrote car.gen.go (66 bytes)
genz: Comparing expected.go and examples/3_tests/tests/1_1_getter/car.gen.go
genz: No difference between expected.go and examples/3_tests/tests/1_1_getter/car.gen.go
genz: Running go test in examples/3_tests/tests/1_1_getter
=== RUN   TestCarGetModel
--- PASS: TestCarGetModel (0.00s)
PASS
ok  	github.com/Joffref/genz/examples/3_tests/tests/1_1_getter	(cached)
genz: All tests passed in examples/3_tests/tests/1_1_getter
genz: === ✔ - End of test in examples/3_tests/tests/1_1_getter without error ===

genz: Difference between expected.go and examples/1_validator/test/human_validator.gen.go:
  (
  	"""
  	... // 22 identical lines
  		// WORK IN PROGRESS

- 		// map[_0:+>18 _1:<99]
+ 		// map[_0:+>18 _1:<99]

  		return nil
  	... // 2 identical lines
  	"""
  )

Now, there is only the genz: === ✔ around the native go tests, without value added. I expected genz: === ✔ - End of test in examples/3_tests/tests/1_1_getter without error === to appear after the comparison test and thus, failing because comparison does not match.

There is confusion on your side, as visible in your capture it seems that the output has been truncated.

I think I get what you mean. It is due to the error return at the end of the Run method in cmd. We should avoid returning errors here.


USSD public - initial functionality

add functionality up to the change menu state

@gsvr plz review

:+1:

@NicolaasDieBaas Please review.

:+1: when travis is happy


⚠ Bofrost.at has degraded performance

In 124155a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2191 ms

Resolved: Bofrost.at performance has improved in 6a4a2aa.


Refactor: Client.socket now returns a ZManaged

Fixes #1245
Client now returns a ZManaged instead of a ZIO this makes sure that it's clear that a socket is a resource, and that it should be used within a "scope".

Codecov Report

Merging #1259 (ff0779b) into main (3dd3cb5) will decrease coverage by 0.09%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #1259      +/-   ##
==========================================
- Coverage   59.23%   59.14%   -0.10%
==========================================
  Files          74       74
  Lines        2495     2499       +4
  Branches       70       65       -5
==========================================
  Hits         1478     1478
- Misses       1017     1021       +4

Impacted Files
Coverage Δ

zio-http/src/main/scala/zhttp/socket/Socket.scala
68.42% <ø> (ø)

...o-http/src/main/scala/zhttp/socket/SocketApp.scala
42.85% <ø> (ø)

zio-http/src/main/scala/zhttp/http/Response.scala
84.28% <75.00%> (-0.79%)
:arrow_down:

zio-http/src/main/scala/zhttp/service/Client.scala
91.07% <100.00%> (+0.16%)
:arrow_up:

...la/zhttp/service/client/ClientInboundHandler.scala
71.42% <100.00%> (ø)

...p/src/main/scala/zhttp/socket/WebSocketFrame.scala
19.35% <0.00%> (-16.13%)
:arrow_down:

...main/scala/zhttp/service/WebSocketAppHandler.scala
45.83% <0.00%> (-12.50%)
:arrow_down:

zio-http/src/main/scala/zhttp/http/HttpData.scala
83.33% <0.00%> (+1.51%)
:arrow_up:

...ain/scala/zhttp/service/ServerResponseWriter.scala
92.85% <0.00%> (+2.38%)
:arrow_up:

...http/service/server/ServerChannelInitializer.scala
94.73% <0.00%> (+5.26%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dd3cb5...ff0779b. Read the comment docs.


Request for help

Hey sorry to bother you on your repository but there's no other way to contact github users, I saw on other threads that you managed to setup a 1.5 inch oled rgb i2c module from Waveshare on your raspberry pi. I have the same module and am trying to get it to work but having issues. If you're free and can help, shoot me an email please<EMAIL_ADDRESS>

Hi, no problem. Please wait a few days because I'm slightly busy with work.
Essentially, I used the example code linked in the weaveshare wiki and followed their tutorial + a website about raspberry pi pins. I also used their own display driver (test code works well) to write my own animations.
I will take some photos for the pins.

Some of the libraries are outdated and unsupported, I can't get i2cdetect
to find the module, so I'm thinking maybe I wired it wrong? Sure send a pic
of the pin wiring whenever you can thanks.
On Thu, Mar 12, 2020 at 6:20 AM Querela<EMAIL_ADDRESS>wrote:

Hi, no problem. Please wait a few days because I'm slightly busy with work.
Essentially, I used the example code linked in the weaveshare wiki and
followed their tutorial + a website about raspberry pi pins. I also used
their own display driver (test code works well) to write my own animations.
I will take some photos for the pins.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Querela/termux-usb-python/issues/1#issuecomment-598110685,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH52ZXA7A7N7AB77J5WKWFLRHCZPTANCNFSM4LFYQQGQ
.

https://www.waveshare.com/wiki/1.5inch_RGB_OLED_Module

Demo Code Download (contains driver library + examples)
User Manual

connection as described in manual, (page 7) bcm mode 23, 24, power ground were nearby on my rpi3b+
for pinout lookup use this: https://de.pinout.xyz/pinout/pin18_gpio24

https://www.waveshare.com/wiki/Libraries_Installation_for_RPi

I installed wiringPi, and the Python libs, like RPi.GPIO, and bcm2835 c libs
enabled the interfaces, like i2c, serial, spi with raspi-config

Photos still in work ... Will clean this up later but those were my references. I still have my setup readme on my rpi but it is still offline and stowed away.

Hey thanks for the response. In the time since we last spoke I managed to
get it to work, so it's all good now. Thank you for the help!
On Mon, Mar 16, 2020 at 1:42 PM Querela<EMAIL_ADDRESS>wrote:

https://www.waveshare.com/wiki/1.5inch_RGB_OLED_Module

Demo Code Download (contains driver library + examples)
User Manual

connection as described in manual, (page 7) bcm mode 23, 24,
power ground were nearby on my rpi3b+
for pinout lookup use this:
https://de.pinout.xyz/pinout/pin18_gpio24

https://www.waveshare.com/wiki/Libraries_Installation_for_RPi

I installed wiringPi, and the Python libs, like RPi.GPIO, and
bcm2835 c libs
enabled the interfaces, like i2c, serial, spi with raspi-config

Photos still in work ... Will clean this up later but those were my
references. I still have my setup readme on my rpi but it is still offline
and stowed away.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Querela/termux-usb-python/issues/1#issuecomment-599672438,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH52ZXH5LF4LEKP4IRWMSWLRHZQJLANCNFSM4LFYQQGQ
.

Ok, no problem. And grats. :-)
Sorry, but I was/am still somewhat swamped with work...
Will close for now.
And will see about adding some easier direct contact options.


Suggestions

Add /fly , /repair , /vanish , /god , command for teleport (/tpa , /tpahere , /tpaccept , /tpdeny)

I'll be sure to add those commands when I have time :)

Also /gmsp would be appreciated.
You can probably find code for inspiration of it here: https://github.com/poggit-orphanage/EssentialsPE

Added /gmspec (spectator mode)


lib.cli: Add escapeBashArg{,s}

These utilities are like escapeShellArg{,s} except that they will leave the string undisturbed if it doesn't need to be quoted (because it doesn't have any special characters).  This can help generate nicer-looking command lines.
Description of changes

Things done

Built on platform(s)

[x] aarch64-darwin

[x] Tested, as applicable:

or, for functions and "core" functionality, tests in lib/tests or pkgs/test

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Oh this is nice!
I don't think we need a separate function for this actually. While the existing ones have Shell in their name, they actually specify bash in the description:

escapeShellArg: Quote string to be used safely within the Bourne shell.

And even if we assume escapeShellArg to be POSIX shell specific, it's likely that almost (if not exactly) the same characters need escaping as with bash.

Also a minor nit for the commit message: This function is not in lib.cli but rather lib.strings (though it really should be in the former).

I'll get to your feedback soon.  Also, just to clarify: are you saying it's okay to make this the new behavior of escapeShellArg?

I'll get to your feedback soon. Also, just to clarify: are you saying it's okay to make this the new behavior of escapeShellArg?

Yes I think that would be okay :)

This would need to target staging now due to all the rebuilds.

Alright, I think this is ready for re-review (and rebased against staging)

@emilazy: I typically squash merge (and clean up the commit message in the process of doing so)

This breaks the generation of meson cross file: https://github.com/NixOS/nixpkgs/pull/336718#issuecomment-2307887576

Hard to say if there’ll be any Hyrum’s law type breakage

There we go :)
I’ll look at the Meson thing.

@NickCao Please try https://github.com/NixOS/nixpkgs/pull/336890.

This also caused a regression in the dokuwiki module.

escapeShellArg was not at all correct for PHP even before this, so the DokuWiki module should be fixed.

Another Hyrum’s law issue: https://github.com/LnL7/nix-darwin/pull/1068.
(I don’t think it was necessarily wrong to do the PR this way or anything; just feel it is interesting/useful have a reference for the kinds of ways semantics‐preserving changes like this can result in downstream users breaking.)

Yeah, this is why my original change didn't make this behavior the default.

Hard to say if there’ll be any Hyrum’s law type breakage

Yup: https://github.com/NixOS/nixpkgs/issues/367288

Sorry for not pushing back harder on repurposing the name here. I think it’s pointless to revert at this point now that it’s in a stable release though.


Growing /tmp directory

What happened?
When trying to upgrade the operator from v1.13.0 to v1.15.0 we started having problems with the growing /tmp directory. In the earlier version of the operator, directories from /tmp/pulumi-working/pulumi-kubernetes-operator/ were deleted after reconciliation. After change in PR-490 the .pulumi directory, which weighs about 800 MB in our instance, remains in each stack. With about 200 stacks we have, we need over 100 GB of extra space, which is not the best option.
Example
Thu Mar 14 09:03:20 UTC 2024
Filesystem      Size  Used Avail Use% Mounted on
/dev/root       124G   71G   53G  58% /tmp
Thu Mar 14 09:04:20 UTC 2024
Filesystem      Size  Used Avail Use% Mounted on
/dev/root       124G   79G   46G  64% /tmp
Thu Mar 14 09:05:20 UTC 2024
Filesystem      Size  Used Avail Use% Mounted on
/dev/root       124G   86G   39G  70% /tmp
Thu Mar 14 09:06:20 UTC 2024
Filesystem      Size  Used Avail Use% Mounted on
/dev/root       124G   93G   32G  75% /tmp
Thu Mar 14 09:07:20 UTC 2024
Filesystem      Size  Used Avail Use% Mounted on
/dev/root       124G  100G   24G  81% /tmp

Output of pulumi about
CLI
Version      3.109.0
Go Version   go1.22.0
Go Compiler  gc

Host
OS       debian
Version  11.9
Arch     x86_64

Backend
Name           pulumi.com
URL            https://app.pulumi.com
User           Unknown
Organizations
Token type     personal

Pulumi locates its logs in /tmp by default

Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Thanks for filing this issue @Anumrati; it looks like we need a way to either separate the credentials configuration from the pulumi home dir (https://github.com/pulumi/pulumi/issues/13919) as an alternate solution for #483 or support some sort of reuse/hardlinking of the pulumi binaries when using multiple pulumi home dirs.

Added to epic https://github.com/pulumi/pulumi-kubernetes-operator/issues/586

Good news everyone, we just release a preview of Pulumi Kubernetes Operator v2. This new release has a whole-new architecture that uses pods as the execution environment. The pod is replaced whenever the source code changes, and so disk usage will be proportional to the number of stacks but not ever-growing.
Please read the announcement blog post for more information:
https://www.pulumi.com/blog/pulumi-kubernetes-operator-2-0/
Would love to hear your feedback!  Feel free to engage with us on the #kubernetes channel of the Pulumi Slack workspace.
cc @Anumrati @zawistowskipiotr @romanglogowski-kmd


Regenerate systemd patches

systemd-nspawn just merged in my PR to make --bind recursive. It's the new default so the only thing left to do is regenerate the patches we carry against systemd to pick this up.

@eyakubovich I don't understand what you mean here, we don't carry any patches against systemd. Are you just saying we need to bump to the latest source?

AFAIU when we bump systemd to v226 we'll get this.
We could add your patch to the stage1 from src builds but it's probably not worth it, you can use from_src/{master,v226} if you want it.

@jonboulle I guess we don't any more. But we used to: https://github.com/coreos/rkt/commit/bc4fe59e54ad6ab806bbe1009cac7b29ff8e1d23
Anywawy, we'll pick up the support for it soon but if we want usr_from_src to work with older versions we have to carry patches again.

Is this waiting on systemd 229?

@jonboulle yes. The patch is in systemd-v226 but because of other bugs, we are waiting for systemd-v229.

Closed by https://github.com/coreos/rkt/pull/2514


Example with Riverpod state management

Description
Riverpod is one of the top 3 most popular state management packages. I suggest creating an example of using Riverpod providers to manage state when moving between sheets.
Please tell us the problem you are running into that led to you wanting a new feature.
I was developing an app for a client and decided to use the Wolt Modal Sheets package because it looks cool and works out of the box. The only problem is, that I need to dig deep into the example code and translate it from Provider to Riverpod state management which takes quite some time.

Hi, the full stack flutter conference is today!
Here is the demo app. In this commit I show how I convert the imperative call to showing modal sheet to declarative call.
Also, full demo app with provider is here:  https://github.com/woltapp/wolt_modal_sheet/pull/217

I am struggling to get the data from each page to the other using riverpod. Any simple code example for reference would be great.

I am struggling to get the data from each page to the other using riverpod. Any simple code example for reference would be great.

It's been a while since I opened this issue. In the end, I decided to go with a simple PageView widget to be able to use Riverpod instead of using Wolt Modal Sheets.

I am struggling to get the data from each page to the other using riverpod. Any simple code example for reference would be great.

You can do this by using the decorator field. All you need to do is to provide a ChangeNotifierProvider or some other notifiers using this field. By doing so, the decorator widget wraps the entire subtree of the modal, and you can manage your data inside the  decorator widget.
The coffee maker app is an example to this use case. Please check this example.

I am struggling to get the data from each page to the other using riverpod. Any simple code example for reference would be great.

It's been a while since I opened this issue. In the end, I decided to go with a simple PageView widget to be able to use Riverpod instead of using Wolt Modal Sheets.

Have you had any chance to check the demo app? I really would like to make it easy to understand regardless of the state management package. Maybe I can improve the Readme if you can provide feedback about what is confusing.

I quickly looked at the demo app with the decorator field. I need some time to play with it to see if it works well with Riverpod. Anyway, I miss the option to make the modals reactive in the "native" flutter way (using widgets) with the WMS.


Unity build support

Added support for unity/jumbo/combi builds in Visual Studio

Hi,
Sorry for the lack of comments. We are in major repo ownership changes. We will take a look at your changes eventually.
Thanks for your understanding.

cool, I'd just look for the unity build support, the ninja support that's also added here was a mistake and should be a different pull request (it's also still in development)

could you remove everything related to ninja from this?

@jspelletier
This PR has been resolved.
https://github.com/ubisoft/Sharpmake/pull/307


[KYUUBI #4622][UI] Session api use admin api for security

Why are the changes needed?

Close #4622
Currently, we don't have a login for the UI, so we can't differentiate between users.
So, we currently maintain a cautious attitude towards the kyuubi ui open API(especially the ability to delete resources) and choose AdminResource, which helps us filter non-Admin requests (although the current strategy is not perfect, it is a safe and quick step).
Change api api/v1/XXX => api/v1/admin/XXX
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #4631 (3a61189) into master (3815bc4) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4631      +/-   ##
============================================
- Coverage     53.55%   53.54%   -0.01%
  Complexity       13       13
============================================
  Files           579      579
  Lines         31781    31781
  Branches       4253     4253
============================================
- Hits          17019    17016       -3
- Misses        13172    13176       +4
+ Partials       1590     1589       -1

see 4 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

The fixing issue https://github.com/apache/kyuubi/issues/4622 provides no details of proposed feature or improvement. Can you explain more about what to fix and how to achieve that?

The fixing issue #4622 provides not enough details of proposed feature or improvement. Can you explain more about what to fix and how to achieve that?

Sure, thanks for reminder. Added to the both PR and issue description.

Thanks, merged to master


Ant Design 5: Upgrade Space component

Please refer to SIP-139 https://github.com/apache/superset/issues/29268.
The Space component should be upgraded to Ant Design version 5.
Similar work has been completed here.
When upgrading the component to Ant Design 5, please ensure to include:

Proper RTL test coverage if not present yet.
A Storybook file (if not present) or all necessary changes.
Include all relevant component options in the Storybook.
Clean up unnecessary custom styles.

When opening a PR:

Name your PR refactor({Component}): Upgrade {component} to Ant Design 5
Add screenshots of BEFORE/AFTER in your PR.
Update the project tracker when your PR is merged.
Make sure you or a committer has labeled your PR with frontend:refactor:antd5.

🎉 Preset Bounty Available: $100 USD 🎉
To claim this bounty, please carefully follow the steps below.

📋 Steps to Participate

Review Guidelines:
Read through the Preset Bounty Program Contribution Guide for complete details on bounty requirements.

Show Your Interest:
Complete the Preset Bounty Program Survey and comment this issue to express your interest.

Join the Slack Channel:
After completing the survey, you’ll receive an invitation to the dedicated Apache Superset Slack channel.

Get Assigned:
To officially start, ensure a Bounty Program Manager has assigned you to this issue.

Submit Your Solution:
When ready, submit your solution with the Fixes #{issue_number} notation in your Pull Request description.

Claim Your Bounty:
Sign up at GitPay.me and submit your solution via: https://gitpay.me/#/task/1033

💡 Additional Notes

Only developers assigned by a Bounty Program Manager should start working on this issue to win the bounty.
Be sure to follow the guide closely to avoid any delays in payment. Please, allow a few days after your PR has been merged for the bounty to be released.

Good luck, and happy coding! 🎉

@geido Hey, can i take this?


Fix KUBE_VERSION variable in quick_install.sh file

What this PR does / why we need it:

correctly populate KUBE_VERSION variable in quick_install.sh file by grepping the server version line, instead of relying on line numbers.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #2661

Type of changes
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing:

Crossed checked KUBE_VERSION variable on my machine with Kubernetes Server Version: v1.25.3 and Kubernetes Server Version: v1.22

ajaynagar@LJD43D kserve % kubectl version --short=true | grep "Server Version" | awk -F '.' '{print $2}'
25

Special notes for your reviewer:

Flag --short has been deprecated and will be removed in the future. The --short output will become the default. Contributors will need to update this again when the --short flag is completely deprecated in next releases. Contributors will also need to consider the fact if kubernetes keeps the output backward compatible or not.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

@nagar-ajay can you help sign off the commit ?

@nagar-ajay can you help sign off the commit?

@yuzisun Done

Thanks @nagar-ajay !
/lgtm
/approve


Issues with downloading new server version - suggested fix

This is a proposed fix for https://github.com/itzg/docker-minecraft-bedrock-server/issues/123.
It makes 3 small changes:

sort existing server binaries via 'reverse version' order - to get true latest release
tries 3 times to locate each of the searched-for data attributes to try and tolerate transient network errors
logs output of restify.err in case of download failure but with existing binary, for future diag

It seems to be very reliable compared to my other containers (which use the standard image). The fixed one has not failed to start at latest version whereas the others are wrong most days. Maybe something weird with my network reliability but at least this fix seems to deal with it.
I've put the retries inside the data-attribute iteration. We could equally do it the other way around.

Latest image now includes this change

Latest image now includes this change


meet fatal error when install mecab-python 3==1.0.5

Installing melotts, it required mecab-python3 == 1.0.5. However, I cannot install the version of mecab-python3, which is very weird, even my Windows has a vs2022 build tool. Does anyone meet the same issue?
I noticed that the dev-group of mecab released mecab-python3 == 1.0.9. I can install 1.0.9 without any problem. Can you update your required independencies?

I'm experiencing the same issue. Please upgrade mecab-python3 to 1.0.9. @Zengyi-Qin


rm unsupported handler calls

Summary
Our testnet should only support liquid staking.
Test plan

closing in favor of WL approach


Broken auction link on homepage hero

Clicking this auction on the homepage's hero carousel results in a 404.

@kanaabe This one might actually be something to address?
Current link is:
https://www.artsy.net/auction/finarte-modern-and-contemporary-art-1
Working link is:
https://www.artsy.net/auction/finarte-modern-and-contemporary-art-1

Oh yes! Good call, I'll notify the internal team that manages this. Thanks for the find!

Updated!


Problem with complex restrictions

Looks like that restrictions that stretch over more than three nodes does not work properly. Both, the contracted and non contracted RouterDb calculates wrong paths.
Looking into the code I can't figure out the logic used to process restrictions. However, it looks that it is not a bug, but something conceptual.
To reproduce:
Using http://data.osm-hr.org/slovenia/slovenia.osm.pbf
var route1 = router.Calculate(Vehicle.Car.Fastest(), new Coordinate(46.05798f, 14.50605f), new Coordinate(46.05786f, 14.50615f));

OSMR - correct
https://www.openstreetmap.org/directions?engine=osrm_car&route=46.05798%2C14.50603%3B46.05787%2C14.50615#map=19/46.05744/14.50469
Itinero contracted - wrong
http://geojson.io/#id=gist:anonymous/5fc4c65629c9503d5456d7d3e9f79c52&map=18/46.05669/14.50588

var route2 = router.Calculate(Vehicle.Car.Fastest(), new Coordinate(46.05763f, 14.50568f), new Coordinate(46.05807f, 14.50624f));

OSMR - correct
https://www.openstreetmap.org/directions?engine=osrm_car&route=46.05765%2C14.50564%3B46.05818%2C14.50627#map=19/46.05789/14.50597
Itinero contracted - wrong
http://geojson.io/#id=gist:anonymous/3aae2d57ca2a4a34c0b2e42fc6aa0aac&map=18/46.05674/14.50690

Non contracted RouterDb simply ignores complex restrictions. Here is a result for non contracted version of route1 http://geojson.io/#id=gist:anonymous/8f14d3e434895c7ecd84d6fe890e2f52&map=19/46.05779/14.50602

@amarinsek could you share your workaround about the non contracted restrictions?
Thanks

It is a quick and dirty workaround! Please, make a diff with attached modified files and take into account your version from the January 6.
I hope it will help...
modifications.zip

@amarinsek I'll take a look at your workaround.
many many thanks.

Closing this as this is on the roadmap for Itinero 2.0:
https://docs.itinero.tech/docs/itinero/development/index.html#version-20-and-beyond


Discussion forum, reCAPTCHA not set up

Hi, it seems it's currently impossible to register to the discuss.rosflight.org
The reCAPTCHA has not been setup so one cannot finish the registration for now.
Screenshot:

Haha!  It looks like recaptcha.net is down.
Unfortunately, the only way to register is with google.  Does it work now?

Yeah, works fine with Google :)


fix CRLF issue on Windows

Autopxd will produce error "... pycparser.plyparser.ParseError: :1:14: invalid #line directive" on Microsoft Windows 7 / 10 + mingw-w64, while the same header file works correctly on Linux & MacOS.
The difference between windows and unix-like os is that function "preprocess" (autopxd __init__.py) returns an output containing CRLF on Windows.
Replacing CRLF with LF in function "preprocess" will fix the issue on Windows.

Looks like Travis CI is broken on master, pypy isn't installing correctly anymore for the macOS target, so the build failure isn't related to your changeset. I plan to address that, merge this PR, and issue a new release sometime in the next couple of days. Thanks for your contribution!


TDR-2241 Implement Card Component

Most the css was taken from the original nhs frontend card, slightly modified so it doens't require JavaScript

Hey Thanh, (I haven't managed to review this properly but) I think instead of JS, you can just hyperlink the card i.e. just put the card's html in the a tag

Hey Thanh, (I haven't managed to review this properly but) I think instead of JS, you can just hyperlink the card i.e. just put the card's html in the a tag

Ah that's a good shout. For some reason I thought we couldn't do that :/
Just need to make some changes with the CSS. Thanks :+1:

I have added $govuk-link-colour to the main.scss file. I had to change the colour of the username to white as it was now turning blue whilst keeping it as a  tag to keep the styling.
Added the line height and font size as suggested
Added the css hover psuedo class as suggested for the heading


Boyer–Moore Majority Vote Algorithm

💥 Proposal
In Boyer–Moore Majority Vote Algorithm, majority element is calculated where, majority element appears more than n/2 time in the array where n is the size of the array
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign


Container not reachable after logout

I have installed Docker Desktop on a Windows Server 2016. I have used the official docker installer. Everything works fine until I log out of my windows user. If I log out none of my docker container can be reached anymore (via the published ports). If I log in again the container are still not reachable. Docker also can't download new images from the internet then. I have to restart the docker service manually. Then every thing works fine until I log out again.
Any ideas?

Same Problem on Windows Server 2019

Hi,
will it be possible to get it fixed in near future?
or
any workaround to run it as system service and logout from user account?

Closing, this is the wrong repository to open this issue in. Please open an issue in https://github.com/docker/for-win


Set openapi/graphql schemas and connection string on nodejs services

This covers also the nodejs services starting with scripts

@ShogunPanda I think this will create a duplication with something like meta.connectionString. Can you help @marcopiraccini to refactor this or in another PR to store the connection string in one place?

@ShogunPanda I think this will create a duplication with something like meta.connectionString. Can you help @marcopiraccini to refactor this or in another PR to store the connection string in one place?

This is for the connection string set by nodejs process.
So not sure what you mean, it's on the same place (so in meta) for platformaticDB and nodejs.

This is for the connection string set by nodejs process.
So not sure what you mean, it's on the same place (so in meta) for platformaticDB and nodejs.

If I call the globalThis.platformatic.setConnectionString for the platformatic service stackable will it set it in the stackable metakeys?

This is for the connection string set by nodejs process.
So not sure what you mean, it's on the same place (so in meta) for platformaticDB and nodejs.

If I call the globalThis.platformatic.setConnectionString for the platformatic service stackable will it set it in the stackable metakeys?

Will set the property in the BaseStackable. The meta depends on the the getMeta implementation, I guess. Currently we have different overriden getMeta(s) depending on the type of the stackable. So you are asking to refactor this? This is probably out of the scope for this PR (Which goals is basically allow settings schemas and connections string also for script started nodejs services).

@marcopiraccini

add the setConnectionString and getConnectionString methods to the the ServiceStackable
add the setConnectionString and getConnectionString to the default stackable implementation
add the setConnectionString and getConnectionString to the StackableInterface
for the DbStackable use a config value as a default value for the connection string

You can do it in this PR or in another. It doens't matter.


can't create pvc for hostpath with 2.7.0

Error Message:
create Pod nginx-0 in StatefulSet nginx failed error: failed to create PVC www-nginx-0: Internal error occurred: failed calling webhook "admission-webhook.openebs.io": Post "https://admission-server-svc.openebs.svc:443/validate?timeout=5s": context deadline exceeded
Env: Rancher k8s 1.19.8

https://github.com/openebs/openebs/issues/3046


Mocked model for integration testing Ollama into other tools and environments

We are locking for a model or a functionality of Ollama that allows us to mock requests and responses without changing the Ollama binary. Basically we want to define a map of requests to responses, e.g. when "Foo" comes in as a request, we want to define that "Bar" should be returned by the model.
This allows us to do integration testing of Ollama for the DevQualityEval (an evaluation benchmark to evolve the quality of code generation). We need deterministic mocking definition, to allow for deterministic testing.

I was also looking to do some basic integration testing, and I can't figure out what is the best approach.
@bauersimon, did you find any simple integrated way to do it? I don't know if the "simplest way" it is going to be create our own "model" that simply echoes back the tokens it receives

We still just use qwen:0.5b and assert that some text is returned. Better than nothing but not ideal.