Use push events for Agents List

This switches the Agents list to update when it gets a push event. It also adjusts the automatic refresh interval to 15 seconds, and will only fetch once per 5-second window.
Fixes https://3.basecamp.com/3453178/buckets/1445180/todos/353039886, and partially addresses #139

So just looking at the code, is that "it'll update every 15 seconds, or when we receive a "pusher change count" - which ever comes first?"

That’s right, yeah!


feat(ESM): Updating package.json to support both CommonJS & ESM

:tada: This PR is included in version 5.3.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Remove httpd config for embedded ansible

Ivanchuk backport details:
$ git log -1
commit d33c81013a181c791645a8d73f75a5fc4be7410c
Author: Jason Frey<EMAIL_ADDRESS>Date:   Thu Jul 25 14:10:50 2019 -0400

    Merge pull request #246 from carbonin/remove_embedded_ansible_stuff

    Remove httpd config for embedded ansible

    (cherry picked from commit b80275f009deeff529d6e64fdd83e7ee6d3859e9)


SDXS-1024 Release?

I like open source, but because I am no longer a Ph.D. student, based on commercial considerations, this may not be a simple matter. I will do my best to provide more, including more pretrained weights and training code.

I like open source, but because I am no longer a Ph.D. student, based on commercial considerations, this may not be a simple matter. I will do my best to provide more, including more pretrained weights and training code.

It would be best to provide a version of the training code for the sdxl model. Too many repos now are based on sd1.5.

I like open source, but because I am no longer a Ph.D. student, based on commercial considerations, this may not be a simple matter. I will do my best to provide more, including more pretrained weights and training code.

I am very concerned about the latest model progress. If the code can be provided, maybe I will place an order for Xiaomi su7. HHHHH

https://huggingface.co/spaces/ameerazam08/SDXS-GPU-Demo
@IDKiro let me know if anything need to change in this I have created ite running on A Series GPU

I hope comfyui will support sdxs soon

Yes I am also mostly interested in the 1024 version also.
Can you provide more detail on the 1024 holdup? I know you mentioned commercial reasons. Is this because of stability ai license? I always thought training and releasing was fine for projects like these,  but maybe there's something I don't know.

Yes I am also mostly interested in the 1024 version also.
Can you provide more detail on the 1024 holdup? I know you mentioned commercial reasons. Is this because of stability ai license? I always thought training and releasing was fine for projects like these, but maybe there's something I don't know.

xiaomi company

Yes I am also mostly interested in the 1024 version also.
Can you provide more detail on the 1024 holdup? I know you mentioned commercial reasons. Is this because of stability ai license? I always thought training and releasing was fine for projects like these, but maybe there's something I don't know.

This is just a research project and the related technology may not land on Xiaomi's products. However, it's not up to me to make the relevant technology public to peer companies, so I'd say it's not a simple matter.

Yes I am also mostly interested in the 1024 version also.
Can you provide more detail on the 1024 holdup? I know you mentioned commercial reasons. Is this because of stability ai license? I always thought training and releasing was fine for projects like these, but maybe there's something I don't know.

You can try OpenDMD https://github.com/Zeqiang-Lai/OpenDMD，I will try it in this week.

Yes I am also mostly interested in the 1024 version also.
Can you provide more detail on the 1024 holdup? I know you mentioned commercial reasons. Is this because of stability ai license? I always thought training and releasing was fine for projects like these, but maybe there's something I don't know.

This is just a research project and the related technology may not land on Xiaomi's products. However, it's not up to me to make the relevant technology public to peer companies, so I'd say it's not a simple matter.

If you can release the training code, it will be better.

Yes I am also mostly interested in the 1024 version also.
Can you provide more detail on the 1024 holdup? I know you mentioned commercial reasons. Is this because of stability ai license? I always thought training and releasing was fine for projects like these, but maybe there's something I don't know.

You can try OpenDMD https://github.com/Zeqiang-Lai/OpenDMD，I will try it in this week.

Nice repo, I'll refer to it as well.

Yes I am also mostly interested in the 1024 version also.
Can you provide more detail on the 1024 holdup? I know you mentioned commercial reasons. Is this because of stability ai license? I always thought training and releasing was fine for projects like these, but maybe there's something I don't know.

You can try OpenDMD https://github.com/Zeqiang-Lai/OpenDMD，I will try it in this week.

I just read this paper, which has a one-step model training method that is closer to the idea of this paper, and it looks like I need to add it as a citation in the revised version of the paper. It seems that people always think similarly in some aspects.

The subsequent open source program has been terminated by the Company. I'll reopen these issues if there are subsequent progress.


Cirq's QASM parser throws an exception for a classical register called measure

Description of the issue
Qiskit has a verification module that allows one to automatically generate quantum volume circuits. I want to to translate those circuits to Cirq. The problem is that the circuits generated from this module names measure as it's classical register which Cirq's QASM parser can't translate.
How to reproduce the issue
Install Qiskit on your system then run.
import qiskit.ignis.verification.quantum_volume as qv

from cirq.contrib.qasm_import import circuit_from_qasm
from qiskit.compiler import transpile

rand_circ = qv.qv_circuits([[0,1]])[0][0][0]

t_rand_circ = transpile(rand_circ, basis_gates=['u1','u2','u3','cx'])
print(t_rand_circ.qasm())
# prints
# OPENQASM 2.0;
# include "qelib1.inc";
# qreg q[2];
# creg measure[2];
# u3(0.95275496,-0.40048302,2.3396091) q[0];
# u3(1.4710132,1.4238801,-0.9022253) q[1];
# cx q[0],q[1];
# u3(0.7076726,-pi/2,-pi/2) q[0];
# u3(2.1567055,2.5482935,0.68681294) q[1];
# cx q[0],q[1];
# u3(0.28381753,-pi,pi/2) q[0];
# u3(1.0477967,0.64780817,-2.5581967) q[1];
# cx q[0],q[1];
# u3(1.4541338,-0.35391366,-1.7202243) q[0];
# u3(1.9771718,0.44431931,-0.27642371) q[1];
# barrier q[0],q[1];
# measure q[0] -> measure[0];
# measure q[1] -> measure[1];

qasm = t_rand_circ .qasm()

circuit_from_qasm(qasm)

Throws
QasmException: Syntax error: 'measure'
...creg measure[2];
u3(1.6718223,1.6527282,0.40326598) q[0];
u3(0.18482523,-2.950664,-0.51830493) q[1];
cx q[0],q[1];
u3(0.81029954,-pi/2,-pi/2) q[0];
u3(2.295253,2.7452754,1.007595) q[1];
cx q[0],q[1];
u3(0.57912606,-pi,pi/2) q[0];
u3(1.0477967,0.64780817,-2.5581967) q[1];
cx q[0],q[1];
u3(1.2627735,-0.0088513472,-0.77602329) q[0];
u3(1.0159967,3.1110487,1.918677) q[1];
barrier q[0],q[1];
measure q[0] -> measure[0];
measure q[1] -> measure[1];
        ^
at line 4, column 6

Cirq version
Master version

I think in _parser.py we need
    def p_name(self, p):
        """name : ID
        | MEASURE""" # plus some other reserved words from `_lexer.py`
        p[0] = p[1]
        p.set_lineno(0, p.lineno(1))

Then update a few parser rules to use name instead of ID.

The qiskit library in question has been superseded: https://github.com/Qiskit/qiskit-ignis, in favor or https://github.com/Qiskit/qiskit-experiments.
measure is also an invalid creg name in OPENQASM 2.0 (or at least it doesn't parse on their playground website).
@vtomole can you check if the replacement library has the same issue, and/or whether qiskit can parse its own output? (It looks like the underlying issue, if still there, may be in https://qiskit.org/documentation/_modules/qiskit/circuit/quantumcircuit.html#QuantumCircuit.measure_active, which seems like it should be a bug on the quiskit repo itself.)

Bug already filled https://github.com/Qiskit/qiskit-terra/issues/7866

Good find. This is Qiskit bug. Qiskit is returning incorrect QASM. This isn't the first time Qiskit's QASM writer has gotten me in trouble: https://github.com/Qiskit/qiskit-terra/issues/8090. I've transferred this issue into a comment in your linked qiskit-terra issue. That's enough to close this.


Exported project fails to start when UID is saved in project settings

Tested versions

Reproducible in Godot master (c2e4ae782a399adf42c664d3d21d8defe49ba8e5)

System information
Windows 10
Issue description
If you set the main scene through the project manager dialog Godot now saves the UID in the project file:
config_version=5

[application]

config/name="test-export"
run/main_scene="uid://dg450amr7gaby"
config/features=PackedStringArray("4.4", "GL Compatibility")
config/icon="res://icon.svg"

This works fine in the editor but after exporting your project, Godot can no longer run the project:
PS C:\projects\export> Godot Engine v4.4.dev.custom_build.c2e4ae782 (2024-12-11 17:48:18 UTC) - https://godotengine.org
OpenGL API 3.3.0 NVIDIA 566.03 - Compatibility - Using Device: NVIDIA - NVIDIA GeForce RTX 4070 Ti

ERROR: No loader found for resource: res://uid:/dg450amr7gaby (expected type: )
   at: (core\io\resource_loader.cpp:327)
ERROR: Failed loading scene: res://uid:/dg450amr7gaby.
   at: (main\main.cpp:4214)

The fault is caused by this line of code:
editor_node.cpp:3973 if (!p_force_open_imported && FileAccess::exists(p_scene + ".import")) {

It attempts to load the file res://uid:/dg450amr7gaby.import which does not exist.
Steps to reproduce

Create a new project
Create a scene, add some stuff to it
Save the scene
Select the scene as your main scene in the project manager (IMPORTANT, If you run your scene and select "use current scene" it will save the proper file path and work)
Export your project

Minimal reproduction project (MRP)
test-export.zip

The fault is caused by this line of code:
editor_node.cpp:3973 if (!p_force_open_imported && FileAccess::exists(p_scene + ".import")) {

How can it cause the bug if it's editor code?

Then the error would appear during export, but it's not the case.
There are two issues here and the description is mixed up. The quoted line causes error on editor startup, if no scene was restored (so it tries to open main scene)

Owh that last bit might be a fluke of testing on my end, I might have run it with a dev/editor build to try and trap the error as with a runtime build it just quits silently.

The bottom line is:

exporting the project with the UIDs in the project.godot file -> exported project fails to load and just quits
editing the project.godot to add proper paths (or select "use current scene" when running a project) -> exported project works

Just to rule out there is an issue with my custom build. Just reproduced this with Godot 4.4 dev 6 with the following steps:

Download Godot 4.4 dev 6 and run
Create a new project
Download export templats
Create a new scene, add DirectionalLight3D, WorldEnvironment, Camera3D and MeshInstance3D with a BoxMesh to create the most basic scene possible
Save this scene
Open project manager, select Run, set the main scene to the scene you just saved
Press run button in toolbar to test, project works
Open export window
Add Windows Desktop export preset
Press Export Project and save the project in a new folder
Run the exported project, project fails to load.

Just a detail, this seems to be a duplicate of #100084 but this one has more detail, maybe is good consolidate everything here or at least keep an eye to close both when the fix is done.

I ran into this issue today as well.
Not sure if related at all, but I had a similar problem with the splash screen: when set via the project dialogue it entered the uid which then failed to resolve at start in the exported version. Changed it manually in the project.godot file to the path and it works now.
Thought I'd mention it here, because it looks similar in cause & behaviour for someone unfamiliar with the code, but might be totally unrelated or even simple user error.

The splash screen was fixed recently.

Hi everyone ! I've just encountered the same issue as @BastiaanOlij. Glad to see that this issue is being addressed !

And this issue does occur in Godot 4.4dev6


Add iCloud to macOS.gitignore

Pull Request
Thank you for contributing to @toptal/gitignore and https://www.gitignore.io.
New or update
Select the appropriate check box for this pull request. This helps when merging to ensure there are no conflicts with other templates or misunderstandings of how thee template list works.
New

[ ] Template - New .gitignore template
[ ] Composition - Template made from smaller templates
[ ] Inheritance - Template similar to an existing template
[ ] Patch - Template extending functionality of existing template

Update

[X] Template - Update existing .gitignore template

Details
Adds the .icloud extension to the macOS.gitignore file for those who use iCloud to store git repositories. It's not advised to do so but some people, me included, use iCloud to sync git on different devices.
I might have lost the Icon must end with two \r, I couldn't figure out hot to keep them in the file

fixed the returns

@shawnthompson macOS template is coming from github/gitignore. You would need to use a .patch for your changes not to be overridden on the next sync with github/gitignore

@konstrybakov I'm not sure how .patch works but I'd like to learn. I looked online and wasn't sure I understood. Do you have any references you can suggest for me to learn how it works?

Hello @shawnthompson
Basically you just have to apply the changes you want to be made in templates/macOS.patch instead of templates/macOS.gitignore. If the file doesn't exist you can create one

Hey @shawnthompson are you still planning to make the change?

Yeah sorry I forgot. I'll do it sometime this week.

Finally I think I got it right!
Those darn returns \r.


Add parameter name to validation results when missing

The IObjectValidator interface accepts only one input argument which is the object that we have to validate. However, when one of the web service method arguments is null we don't know which one we have the problem with. (Assuming you have more than one nullable typed object in your arguments).
From now on, the code always adds that information to the validationresults whenever it was not already there.
Extra:
Also changed the namespaces to make it easy to recognize which fork of the library is used.

@ejustice I left some comments and pushed some changes. Can you check, please?

@ejustice are you alive? 😄

@ejustice I merged master into this branch due to a bugfix, can you give your final approval on the changes?


Fix #3924, don't let Git hang at password prompt on clone/fetch

Closes: #3924
What's Changed
Add GIT_TERMINAL_PROMPT=0 environment variable to clone_from() and fetch() calls.
I don't fully understand why this wasn't an issue on celery-worker git clone/git fetch calls, only on nautobot-server startup-time git clone/git fetch calls but I can verify that this works and prevents server startup from hanging:
Before:
Performing database migrations...
Operations to perform:
  Apply all migrations: admin, auth, circuits, contenttypes, database, dcim, django_celery_beat, django_rq, example_plugin, extras, ipam, sessions, social_django, taggit, tenancy, users, virtualization
Running migrations:
  No migrations to apply.
<hangs indefinitely>

After, with no existing clone server-side:
  Apply all migrations: admin, auth, circuits, contenttypes, database, dcim, django_celery_beat, django_rq, example_plugin, extras, ipam, sessions, social_django, taggit, tenancy, users, virtualization
Running migrations:
  No migrations to apply.
13:46:06.664 DEBUG   nautobot.utilities.git git.py                                __init__() :
  Cloning git repository to /opt/nautobot/git/test...
13:46:07.391 ERROR   nautobot.jobs        git.py                   ensure_git_repository() :
  Cmd('git') failed due to: exit code(128)
  cmdline: git clone -v -- https://<elided> /opt/nautobot/git/test
  stderr: 'Cloning into '/opt/nautobot/git/test'...
fatal: could not read Username for 'https://<elided>': terminal prompts disabled
'
Cmd('git') failed due to: exit code(128)
  cmdline: git clone -v -- https://<elided> /opt/nautobot/git/test
  stderr: 'Cloning into '/opt/nautobot/git/test'...
fatal: could not read Username for 'https://<elided>': terminal prompts disabled
'
13:46:07.391 ERROR   nautobot.jobs        jobs.py                  _get_job_source_paths() :
  Error during local clone of Git repository test: Cmd('git') failed due to: exit code(128)
  cmdline: git clone -v -- https://<elided> /opt/nautobot/git/test
  stderr: 'Cloning into '/opt/nautobot/git/test'...
fatal: could not read Username for '<elided>': terminal prompts disabled
'
Error during local clone of Git repository test: Cmd('git') failed due to: exit code(128)
  cmdline: git clone -v -- https://<elided> /opt/nautobot/git/test
  stderr: 'Cloning into '/opt/nautobot/git/test'...
fatal: could not read Username for 'https://<elided>': terminal prompts disabled
'

<startup continues>

After, with existing but not yet resynced clone server-side:
Performing database migrations...
Operations to perform:
  Apply all migrations: admin, auth, circuits, contenttypes, database, dcim, django_celery_beat, django_rq, example_plugin, extras, ipam, sessions, social_django, taggit, tenancy, users, virtualization
Running migrations:
  No migrations to apply.
13:45:11.549 ERROR   nautobot.jobs        git.py                   ensure_git_repository() :
  Cmd('git') failed due to: exit code(128)
  cmdline: git fetch -v -- origin
  stderr: 'fatal: could not read Username for 'https://<elided>': terminal prompts disabled'
Cmd('git') failed due to: exit code(128)
  cmdline: git fetch -v -- origin
  stderr: 'fatal: could not read Username for 'https://<elided>': terminal prompts disabled'
13:45:11.550 ERROR   nautobot.jobs        jobs.py                  _get_job_source_paths() :
  Error during local clone of Git repository test: Cmd('git') failed due to: exit code(128)
  cmdline: git fetch -v -- origin
  stderr: 'fatal: could not read Username for 'https://<elided>': terminal prompts disabled'
Error during local clone of Git repository test: Cmd('git') failed due to: exit code(128)
  cmdline: git fetch -v -- origin
  stderr: 'fatal: could not read Username for 'https://<elided>': terminal prompts disabled'

<startup continues>

TODO

[x] Explanation of Change(s)
[x] Added change log fragment(s) (for more information see the documentation)
[x] Attached Screenshots, Payload Example
n/a Unit, Integration Tests
n/a Documentation Updates (when adding/changing features)
n/a Example Plugin Updates (when adding/changing features)
[x] Outline Remaining Work, Constraints from Design

Link to the docs for GIT_TERMINAL_PROMPT


Possible improvement in nav animation on mobile

It's about indicator from left side when entering from / to e.g. /todo or /storage

improvement in #95


Fix a few bugs in layout causing the text to overflow or disappear

While testing #98 I noticed a few layouting issues. These issues are in the main branch too.
One issue was in BiDi text, sometimes there was an overflow like the word "Left" in this picture:

This issue sometimes causes the last word to repeat or to disappear.
Another issue was in the LTR-only lines (or RTL-only), the space before the last word would disappear if the linewidth was a specific size. Like in the image below:

In this PR I fix these issues by changing the layout algorithm a little. Previously we used to create word_ranges and later put them together in a visual_line but now the visual_line is created while iterating over the words. This simplifies the algorithm and fixes the issue mentioned above.
This PR supersedes #98. I tried to apply these changes to @geieredgar 's PR, but the algorithm they used for detecting trailing spaces would not work in specific situations in BiDi. So, I decided to open a new PR.

@hojjatabdollahi Thank you again for your explanation, it helped me to clear up some misconceptions I had. Unfortunately; I cannot mark conversations as resolved, so it would be nice if you could do that to remove the clutter from already addressed comments.

@geieredgar Thanks for your review. I tested your suggested changes and I didn't see any regression, it fixed a potential bug and it also made congruent and incongruent more consistent. Thank you very much.

All tests passed, looks good to me


size -row Header show brower Safari different size-row in f12 debug

I use Safari see size -row of Thead on brower is 49px, and have a space between Thead and Tbody is 9px.

Chrome, IE, FireFox haven't space.

Demo: http://jsfiddle.net/TaNoBi/hsxpj0qo/12/
Help me, please!
Thank you very much!

Sorry, safari is not supported by this plugin. Also, I couldnt reproduce your issue in my safari.
few suggestions:
you have 2 window.onload functions that do the same thing in your code, this is probably causing issues.
you can try initializing floatThead like this
$('#tbOPB').floatThead({useAbsolutePositioning:false});

@mkoryak , I deleted one window.onload, and added $('#tbOPB').floatThead({useAbsolutePositioning:false}); but didn't success :(.

Sorry, I cant help you, both because I cannot reproduce it locally and because I don't have time or desire to support safari.

Ok @mkoryak , I'll try. Thank you

Hi @mkoryak I fixed error :). I subtraction 9 for height on funtion:
function setHeaderHeight(){
var headerHeight = 0;
$header.find("tr:visible").each(function(){
headerHeight += $(this).outerHeight(true);
});
    $sizerRow.outerHeight(headerHeight - 9);
    //console.log(headerHeight + 'abc' + $sizerRow)
    $sizerCells.outerHeight(headerHeight - 9);
    //console.log(headerHeight )
  }

why 9? sounds like a magic number that only works for your table :)
You should try the latest code in master - I made some changes to that function that might solve your problem

Hi @mkoryak , I tried your lastest code, It fixed my error, but have new error.

When I start move scroll, have space

yeah - that fix is no good. I need a new fix, but not sure when ill get to it.

I hope you fix error soon. Thank you :)

commited some code. hopefully this fixed it for you


Manager - Review Applicants disabled until poster closes

Description
Hiring managers should not be able to access the information of any candidates until the job poster closes.

Completed in #736


No introduction on "Introducing Influx OSS" page

I want to know what the difference between "InfluxDB" and "InfluxDB OSS" is.  This page purports to be an introduction to "InfluxDB OSS" but completely fails to mention what OSS means.  Please fix.
URL for relevant page?
https://docs.influxdata.com/influxdb/v1.7/introduction/
What products and version are you using?
influxdb
Where did you look before opening the issue?
google

InfluxDB -- generically is a time series database.
There are multiple editions.
OSS is the Open Source Software.
Enterprise is the commercial closed source, high availability and horizontal scale-out edition.
Cloud is our managed SaaS offering.


astro check reports that a used function is not used

What version of astro are you using?
1.9.2
Are you using an SSR adapter? If so, which one?
Node
What package manager are you using?
pnpm
What operating system are you using?
Linux
Describe the Bug
Running astro check on:
---
function noSuchRecipe(): Response {
  return new Response("
No such recipe
", {
    status: 404,
    statusText: "No such recipe",
    headers: {'content-type': 'text/html'},
  });
}

// Grab this recipe.
const { username, slug } = Astro.params;
if (!slug || !username) {
  return noSuchRecipe();
}
---

Returns:
/home/projects/github-urvrsi/src/pages/index.astro:2:10 Hint: 'noSuchRecipe' is declared but its value is never read.

but running the file actually shows the "No such recipe" output.
Link to Minimal Reproducible Example
https://stackblitz.com/edit/github-urvrsi?file=src/pages/index.astro
Participation

[ ] I am willing to submit a pull request for this issue.

This is unfortunately a huge amount of work. We need to change the shape of the TSX output, which implies changing mappings, which tends to imply changing some manual mappings in completions / code actions as well.
If you're interested in tackling this, I can give further information, but it's a fair amount of work, in multiple programming language and with also a fair amount of background needed 😅

Ok, so for now I will leave it, I will start with something minor 😅

A non-technical alternative would be to create a proposal for this to be changed to a throw, instead of a return. You could create a proposal here for this: https://github.com/withastro/roadmap/discussions
Even it does look weird to throw things like that, it's actually a common pattern when wanting to top-level react to things and would be more valid JavaScript.

Would this be easier to solve if we had script tags instead of frontmatter?

Would this be easier to solve if we had script tags instead of frontmatter?

Nope, same problem. From the editor tooling perspective, it being a script tag or a frontmatter doesn't really change much

I see. Apart from throwing or exposing some sort of main function to be called (which both seem awkward), I can see only one solution: Astro.response should be of type ResponseInit | Response so you could do:
if (!slug || !username) {
  Astro.response = noSuchRecipe();
  return
}

since the frontmatter is technically at the top level

Or perhaps that's the root problem? Couldn't this be transparently fixed by astro by wrapping the frontmatter in a function (e.g. an Immediately Invoked Function Expression)?

Yes and no, for two reasons:

You can have exports, so you need to hoist them out of the function (which we do in Astro itself, but it's a different idea here since it's types being exported)
You need to access a local type in the final function signature. You can't export it through a property of the IIFE because TypeScript will consider that you're using a private type outside of its scope.

Okay, not sure I understood that 100% as I'm not familiar with the .astro compiler... (I was thinking of a hack to work on the string before it even is parsed into any AST... basically splitting the front-matter string after the imports, then wrapping the second part in a IIFE)
But anyway, if it's not doable, then I vote for Astro.response being assignable... perhaps using a proxy?

Just chiming in to say I've also encountered this, and it is very odd. In my case, I was able to suppress the TS error in the IDE (in VSCode at least) by re-assigning the import:
import someResponse from "../someFile"
const fancyResponse = someResponse
...
return fancyResponse()

It's more than a little clunky, but keeps the editor happy. However, astro check will still think fancyResponse is declared but never read.
I've not spent a huge amount of time with Astro, but so far I'm liking it - this is the first real ickiness I've encountered ❤

This is happening to me with astro check:
dist/_worker.js/chunks/pages/index_DliSBx1j.mjs:24:25 - warning ts(6133): 'receiver' is declared but its value is never read.

24       get(target, name, receiver) {
                           ~~~~~~~~

With other 13 hints more.

@OrlandoBricenoB I believe in your case astro check goes through the built code in the dist folder, which is a separate issue

If you're open to a simple (hacky) heuristic that might be less work to implement, we could add a compiler step that takes any return x (that is not in a nested function scope) and turns it into const HASH123 = x; HASH123; return HASH123;.

A non-technical alternative would be to create a proposal for this to be changed to a throw, instead of a return. You could create a proposal here for this: https://github.com/withastro/roadmap/discussions

I see there is already a proposal for this: https://github.com/withastro/roadmap/discussions/830

Same problem here. I had to remove astro check from build process because otherwise, it always fails.

I'm using this workaround until there's a fix. It's a little bit of extra code but allows me to keep astro check in place.
I create a function that I can pass the function that astro check is flagging to. Doing so means that the checker now believed the function to be used
export function avoidAstroTypeCheckBug(_: unknown) {
  // See https://github.com/withastro/language-tools/issues/476 for more context.
  return;
}

// In a .astro file
import { avoidAstroTypeCheckBug } from './avoidAstroTypeCheckBug';
import { createNotFoundResponse } from './createNotFoundResponse';

if (!someValue) {
  avoidAstroTypeCheckBug(createNotFoundResponse);
  return createNotFoundResponse();
}

I had someting very similar to OP:
function noSuchRecipe(): Response {
  return new Response("
No such recipe
", {
    status: 404,
    statusText: "No such recipe",
    headers: {'content-type': 'text/html'},
  });
}

// Grab this recipe.
const { username, slug } = Astro.params;
if (!slug || !username) {
  return noSuchRecipe();
}

My workaround for now was to rename noSuchRecipe to _noSuchRecipe to silence the warning.

I'm using this workaround until there's a fix. It's a little bit of extra code but allows me to keep astro check in place.
I create a function that I can pass the function that astro check is flagging to. Doing so means that the checker now believes the function to be used.
export function avoidAstroTypeCheckBug(_: unknown) {
  // See https://github.com/withastro/language-tools/issues/476 for more context.
  return;
}

// In a .astro file
import { avoidAstroTypeCheckBug } from './avoidAstroTypeCheckBug';
import { createNotFoundResponse } from './createNotFoundResponse';

if (!someValue) {
  avoidAstroTypeCheckBug(createNotFoundResponse);
  return createNotFoundResponse();
}

You could just do:
createNotFoundResponse;
return createNotFoundResponse();

I'm working on a fix here https://github.com/withastro/compiler/pull/1028

@Princesseuh Amazing! I guess that means throw syntax will also be explicitly supported? I've been using that since a few weeks with my own middleware and I haven't run into any difficulties. Would be nice to have it natively supported ❤

@Princesseuh Amazing! I guess that means throw syntax will also be explicitly supported? I've been using that since a few weeks with my own middleware and I haven't run into any difficulties. Would be nice to have it natively supported ❤

No, I'm only working on making it so top-level returns don't trigger an error in editor tooling + astro check, no changes to Astro itself.

:tada: thanks @Princesseuh!

My workaround for now was to rename noSuchRecipe to _noSuchRecipe to silence the warning.

Good idea! Works for me too.
-const { userId, redirectToSignIn } = Astro.locals.auth()
+const { userId, redirectToSignIn: _redirectToSignIn } = Astro.locals.auth()
 if (!userId) {
-  return redirectToSignIn()
+  return _redirectToSignIn()
 }

I'm not sure if that's the same problem (for me it seems like it), but this also breaks for variables, not only functions:
---
  const path = dynamicallyGeneratePath() // <-- TS Error here: `'path' is declared but its value is never read.`

  return Astro.redirect(`https://example.com/${path}`, 302)
---


Tutorial Issue

Hi.
I got a error while going through official tutorial (https://angular.io/docs/ts/latest/tutorial/toh-pt5.html)
Paragraph "Move content out of the component file", where refactoring for HeroDetailComponent is described.
Tutorial says:
"Set the moduleId property to module.id so that templateUrl and styleUrls are relative to the component."
When I add moduleId: module.Id to component file, I receive a error "uri.match is not a function".
Exception thrown from this method:
	  /**
	   * Splits a URI into its component parts.
	   *
	   * Each component can be accessed via the component indices; for example:
	   * <pre>
	   * goog.uri.utils.split(someStr)[goog.uri.utils.CompontentIndex.QUERY_DATA];
	   * </pre>
	   *
	   * @param uri The URI string to examine.
	   * @return Each component still URI-encoded.
	   *     Each component that is present will contain the encoded value, whereas
	   *     components that are not present will be undefined or empty, depending
	   *     on the browser's regular expression implementation.  Never null, since
	   *     arbitrary strings may still look like path names.
	   */
	  function _split(uri) {
	      return uri.match(_splitRe);
	  }

Error thrown because module.Id is a number, hence there is no match method.

is module.id and not module.Id, lowercase.

Uh, it's erratum. I have lowercase in my code.

Can you show me your code?

Sorry for late answer.
Here is my component:
import { Component }     from '@angular/core';
import { OnInit }        from '@angular/core';
import { Router }        from '@angular/router';

import { Animal }        from './animal';
import { AnimalService } from './animal.service';

@Component({
    //will raise an error without coercing to string
    moduleId    : ''+module.id,
    selector    : 'my-animals',
    templateUrl : 'html/animals.component.html',
    styleUrls   : ['css/animals.component.css'],

})
export class AnimalsComponent implements OnInit {

    constructor(
        private animalService : AnimalService,
        private router        : Router
    ){}

    animals       : Animal[];
    currentAnimal : Animal;

    ngOnInit(): void {
        this.getAnimals();
    }

    getAnimals(): void {
        this.animalService.getAnimals().then(animals => this.animals = animals);
    }

    onSelect(animal: Animal): void {
        this.currentAnimal = animal;
    }

    goToDetail(): void {
        this.router.navigate(['/details',this.currentAnimal.id])
    }

};

moduleId is not a string.
What error are you getting?

uri.match is not a function
I described details in initial message. May this error occure because I use webpack for build?
And is this option required for webpack builds?
Thank you.

Yes, webpack doesn't have that and you don't need it.
Check the webpack guide to see how we load templates with it.
Also, questions are better for stackoverflow.


(PDB-4141) Fix jdk-support-status regexes

Both to account for the version change for newer jdks (e.g. 10 instead
of 1.10), and to fix bugs.

Test PASSed

Test PASSed


Fix bug setting target stretched grid lat/lon from restart file

Description
Stretched grid target latitude and longitude are incorrectly assigned when setting them from restart file metadata. Target lat is set to lon, and lon is set to lat. This bug only impacts running with stretched grid using target latitude and longitude from restart file metadata.
Related Issue

https://github.com/geoschem/GCHP/issues/246
Motivation and Context

This fix uses the correct restart file metadata to set stretched grid target latitude and longitude.
How Has This Been Tested?

This has been tested in GCHP 14.0.0 using MAPL 2.18.3.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)

Checklist:

[ ] I have tested this change with a run of GEOSgcm (if non-trivial)
[x] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[x] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

The changes look reasonable. Thanks for catching the bug

Indeed, even I can see this is a good fix.
@lizziel I'm assuming you'll want a release with this fix?

@mathomp4, I am putting this fix into our MAPL fork and am not waiting for a MAPL release for it.


[Security] Fix CVE 2020 28469

Description
This PR fixes #
CVE-2020-28469
Notes for Reviewers
https://github.com/advisories/GHSA-ww39-953v-wcq6
Signed commits

[x] Yes, I signed my commits.

Codecov Report

Merging #4588 (4be3767) into master (182acbf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4588   +/-   ##
=======================================
  Coverage   33.28%   33.28%
=======================================
  Files          60       60
  Lines        5053     5053
=======================================
  Hits         1682     1682
  Misses       2935     2935
  Partials      436      436

Flag
Coverage Δ

gointegrationtests
9.69% <ø> (ø)

integrationtests
∅ <ø> (?)

unittests
26.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d43bd16...4be3767. Read the comment docs.


needs 'Add all to Cart'

Originally reported by: lisa ballard (Bitbucket: basilleaf, GitHub: basilleaf)

Mark and user Michael both requested this, quick and dirty benchmark says it's not as slow as I'd thought it would be!

Bitbucket: https://bitbucket.org/ringsnode/opus2/issue/137

this is actually ready on branch "builk_add" but holding it until dev server is ready for testing it out on full production-sized database.

addall is implemented in the API, but still needs to be invoked by a button on the browse tab.

Meeting today: Put a checkbox at the top of the cart column in the table view. Put an entry in the hamburger menu. Both should only be available on the browse tab.

Also change styling on hamburger menu to have much less vertical padding between items


Terraform apply breaks communications between workers and masters

I have issues
Described below
I'm submitting a...

[X] bug report
[ ] feature request
[ ] support request - read the FAQ first!
[ ] kudos, thank you, warm fuzzy

What is the current behavior?
Every time I execute a terraform apply, it tries to make the following changes
  # module.eks-cluster.kubernetes_config_map.aws_auth[0] will be updated in-place
  ~ resource "kubernetes_config_map" "aws_auth" {
        binary_data = {}
      ~ data        = {
            "mapAccounts" = jsonencode([])
          ~ "mapRoles"    = <<~EOT
              - - groups:
              -   - system:bootstrappers
              -   - system:nodes
              -   rolearn: arn:aws:iam::1234567890:role/mytests-managed-node-groups
              -   username: system:node:{{EC2PrivateDNSName}}
              +
              +
            EOT
            "mapUsers"    = jsonencode([])
        }
        id          = "kube-system/aws-auth"

        metadata {
            annotations      = {}
            generation       = 0
            labels           = {}
            name             = "aws-auth"
            namespace        = "kube-system"
            resource_version = "35037"
            self_link        = "/api/v1/namespaces/kube-system/configmaps/aws-auth"
            uid              = "781f4175-1b42-11ea-b157-02d81c51517c"
        }
    }

after that,  the node becomes 'NotReady'.
NAME                                         STATUS     ROLES    AGE   VERSION
ip-10-10-10-180.eu-west-1.compute.internal   NotReady   <none>   55m   v1.14.7-eks-1861c5

When looking into the managed node logs at /var/log/messages:
Dec 10 17:32:49 ip-10-10-10-180 kubelet: E1210 17:32:49.651699    3821 reflector.go:126] k8s.io/kubernetes/pkg/kubelet/kubelet.go:442: Failed to list *v1.Service: Unauthorized
Dec 10 17:32:50 ip-10-10-10-180 kubelet: E1210 17:32:50.130065    3821 reflector.go:126] k8s.io/kubernetes/pkg/kubelet/kubelet.go:451: Failed to list *v1.Node: Unauthorized
Dec 10 17:32:50 ip-10-10-10-180 kubelet: E1210 17:32:50.506744    3821 reflector.go:126] k8s.io/kubernetes/pkg/kubelet/config/apiserver.go:47: Failed to list *v1.Pod: Unauthorized
Dec 10 17:32:50 ip-10-10-10-180 kubelet: E1210 17:32:50.780769    3821 reflector.go:126] k8s.io/client-go/informers/factory.go:133: Failed to list *v1beta1.CSIDriver: Unauthorized

I fix it by re-applying the aws-auth config map with the following:
apiVersion: v1
kind: ConfigMap
metadata:
  name: aws-auth
  namespace: kube-system
data:
  mapRoles: |
    - rolearn: arn:aws:iam::1234567890:role/mytests-managed-node-groups
      username: system:node:{{EC2PrivateDNSName}}
      groups:
        - system:bootstrappers
        - system:nodes

If this is a bug, how to reproduce? Please include a code sample if relevant.
module "eks-cluster" {
  source = "github.com/terraform-aws-modules/terraform-aws-eks"
  cluster_name = "mytests"
  subnets      = data.terraform_remote_state.networking.outputs.private_subnets
  vpc_id       = data.terraform_remote_state.networking.outputs.vpc_id

  node_groups = [
    {
      name = "mytest_node_groups"
      instance_type = "t3.large"
      asg_max_size  = 2
      autoscaling_enabled = true
      public_ip = false
      key_name = "XXXXXX"
      tags = [{
        key                 = "foo"
        value               = "bar"
        propagate_at_launch = true
      }]
      worker_additional_security_group_ids = [
        aws_security_group.EFS_client
      ]
    }
  ]

  tags = {
    environment = "test"
  }
}

resource "aws_security_group" "EFS_client" {
  name        = "EFS_client"
  description = "Allow EFS outbound traffic"
  vpc_id      = data.terraform_remote_state.networking.outputs.vpc_id
}

What's the expected behavior?
Applying terraform should push working configuration to ensure Workers can access to the master layer.
Are you able to fix this problem and submit a PR? Link here if you have already.
No
Environment details

Affected module version: current master branch
OS: MacOS Laters version
Terraform version: Terraform v0.12.16

Any other relevant info
It may have been caused by using Terraform Helm 3  provider to deploy the efs-provider module. Not sure, still, I fall back into a loop where applying this module, breaks the connection between master and workers.

I believe this is an issue with the role generated by the managed_node_group not being added to the aws-auth config map here. I'm testing a fix locally but won't be able to PR for a few days, so someone else should take a shot if they have time.

Seeing this as well


FAI-14421 - Remove newlines on airbyte logs so that they are each log is treated as a single message

Description

Provide description here

Type of change

[ ] Bug fix
[ ] New feature
[ ] Breaking change

Related issues

Fix #1

Migration notes

Describe migration notes if any

Extra info

Add any additional information

@dbruno21 This should fix the incomplete log messages you informed me about earlier this month.


Add optional foreign key override

I found a "sort-of" bug in the foreign key name resolving. In our projects database we call the table something separate to our model class name.
EG. Our class is called "PUIN" with filename "PUIN.php" is called "uin" in our database.
When resolving foreign key names for table relations it comes out as table.p_u_i_n_id. This is because of the snake case function.
I know you can set the foreign key name on the relationship but it would be nice if you could set it on the model itself if is to never change; then it would strip out a lot of un-needed paramaters when creating relationship functions.
EG. In our relationship functions in related models.
return $this->hasMany(User::class, 'foreign_key_id');
... becomes.
return $this->hasMany(User::class);
PS. Apologies for previous pull request I made. I selected wrong base.

Override the method to customize the key.


fix: shadowMode cannot apply to i3dm tileset.

I tried to create a Cesium.Cesium3DTileset with the shadowMode: Cesium.ShadowMode.CAST_ONLY. The tileset contains many trees with i3dm format. But It looks like that shadowMode cannot apply to the tree Model. They will always receive shadow.
I finally find the reason: the shadowMode did not pass to the Model.

Thanks for the pull request @JiaoJianing!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

Thanks @JiaoJianing - this seems like a pretty straightforward fix. Do you have a sample 3D Tileset you can share that we can use to test this?
Easiest way to share it would be to upload it to your Cesium ion account (https://cesium.com/ion/) and share a Sandcastle link here.

Hi~ @OmarShehata
I shared a Sandcastle link below, please check it!
https://sandcastle.cesium.com/#c=jVNdc9o4FP0rd3hozUxGDqHpJg3JbAIMYyaGJHjb0vGLIosgLCSvJOM4nfz3SpZhszttZ59k6Z5z7rkfDkOYKCwMDKlm5Xa6AEwI1RqMhFqWCpgUgLWmRqfCY1AkBcroCpfcXDfgROZUwCWkHVpP148TwuZsGv31EvVmLNKReDglw+hjlBdfPw+n58iC/s4muQNt40lcxckDmy2OPyy/jKvb5P5kNnoy8yQ+nQ2Pe9+SWT5PprmN9ZebJ3Y7nBbfrFi8yT/Eo9yKzzaP/RtO6ujjF5uc9COHEct6mjns8us9m2/GvXkS9eMN6c82N+doUm1mVUXyHVuexid/3I+f11m5u5vcjZO7s3x1nJS6l+yKh2V1lnYuUpGKHVawY7SiypYpaNW2C31u3oK0Q5r7UAqDmaAq7RzBd73Gmaz0JzCqpK/dg5BhnNqGWiUviTShgqJCsS0zbEc1wlkWpALeZvJHf5R4cvDdxQFKxT/BP3N5oNoOjVC0UnJ77cYWZUGvd3ZyfN498owwNGumoTUHmaRavDdQYD90s6awYgJziGVGOYKFBGaAYAeqpMqBSKWo4TXyeocqWxeL5u7IaBQtrm9uxyMHfO2mwregLR8pirP6zvpkmjoEsqlFsCoFMW7pgi60NbZdepFym8igpXstXxBcFwWvG+vtXoI2NafAVs47fWbarW+jZftPn43C2rZ/76TZb+SfLzzOMgP/BfvCrLQdbRZ4XBfevfstANki/hdo/y8tnOWuhx9qh4NJX9Hlr3aiYf9Sta3qdT8J221p26Uq2/s3LadKSXXITaTQklPE5VMbufB8e3SOOoPG0ZV7+pNtC6mM28YAodDQbcGxoTp8LEluvROtHWkQ7imDjO2AZZc/+XGAcDsPG1mVnC/YC007V4PQ4v9F4xJnTDzNd1RxXFuIszFY965ufQAhNAjt1SX9L9dIyR+xeqP7Aw

@OmarShehata
I also found that shadows state of i3dm cannot update dynamic. So I added the update logic in ModelInstanceCollection.prototype.update() to update the _model.shadows.

@JiaoJianing @OmarShehata it looks like this was actually just fixed in https://github.com/CesiumGS/cesium/pull/8981. Back face culling, wireframe, and shadows all had the same problem.
This sandcastle should work in master:
http://localhost:8080/Apps/Sandcastle/index.html#c=jVNhU9s4EP0rO/lQnBlGJqT0oATuIMlknMEOEF/bdPxFyEqiWJF8khxjOvz3ky0nx9zRzn2ypX37dvftk+/DRGFhYEg1K7bTOWBCqNZgJFSyUMCkAKw1NToRDoMCKVBKl7jg5qYBxzKjAq4g6dBqun6aEDZj0+DPl6AXsUAH4vGMDINPQZZ/+zKcXiAL+iudZDVoG07CMowfWTQ/+bj4Oi7v4ofTaLQyszg8i4Ynve9xlM3iaWZj/cVmxe6G0/y7JQs32cdwlFnyaPPUv+WkCj59tcVJP6gxYlFN0xq7+PbAZptxbxYH/XBD+tHm9gJNyk1UliTbscVZePrbw/h5nRa7+8n9OL4/z5YncaF78S5/XJTnSecyEYnYYQU7Rkuq7JiClq1c6Etz5yUd0pyHUhjMBFVJ5xh+6DVOZak/g1EFfe0eiAzj1ApqmRwl0oQKinLFtsywHdUIp6mXCHhbyX36o9glez/qOECh+Gf4Zy+PVNulEYqWSm5v6rUFqdfrnZ+eXHSPXYbvmzXT0DYHqaRaHBnIsVu6WVNYMoE5bGVKOYK5BGaA4BpUSpUBkUpRYniFHOFhzLaNeXMObTYaBfOb27vxqAa+dhPhNGjnR4ritLq3jTJNawSytYW3LAQxteu8LrRDtjK9SLmNpdemOy43EdzkOa+a3ltjgjYVp8CWdfP0menavw2XXQB9Ngprq/++k8bgyF1fOpzN9Nwf7Aez1Ha3qedwXfjw4ZcAZIf4X6D9Y5rXLXcd/DA7HJp0E139zBRN9k9Z26le95uwaksrlyqt9m8kp0pJdahNpNCSU8Tlqo1cuvxG+jkWKcHaWID1ayxXK05vC2Ok8I5aTxwdwxJzTe2nLeGRNSUZTdsah9laN15BG4ff37HTOGrcBL+ymm3N9tc57gwava73Kv7BtrlUpn4wHkK+oducY0O1/1TYegYRrfciDfy3qYOU7YClV++8cSDcOsdGlgXnc/ZCk871wLf4/6RyiVMmVrMdVRxXNWzdu75zlwihgW+P72caKfkTVv9i/hs

@lilleyse @OmarShehata
OK! So I will close this PR.


Pinning Copilot for non-licensed users

Type of issue
Typo
Feedback
Cx is looking for public information of current documentation for pinning Copilot in Teams to be updated.
We know that Copilot will not appear as pinned for users who don't have a Copilot license, as this was changed earlier in the year based on customer requests.
However, we also know that as per Wave2 Copilot enhancements the tenant setting will honor the pinning of Copilot icon to Teams and other M365 apps. Cx followed this article and wants the information that pinning will not happen for non-licensed users to be added, as this is not made clear:
https://learn.microsoft.com/en-us/copilot/microsoft-365/pin-copilot
Page URL
https://learn.microsoft.com/en-us/copilot/microsoft-365/pin-copilot
Content source URL
https://github.com/MicrosoftDocs/microsoft-365-docs/blob/public/copilot/pin-copilot.md
Author
@surbhigupta
Document Id
4bbe9beb-233f-cfd5-097b-f280aab5fde8

@KurupatiC - Thank you for bringing this to our attention! We will get the document updated to add above mentioned point.

Hello!
Do we have an ETA for when the article will be adjusted?
Customer is looking for one - what can we share with them?
Thank you!

@Meghana-MSFT can you please let us know the article will be change? Although a minor change, customer is counting on this and since it is regarding Copilot, please prioritize. We need to provide an significant updato to customer - can you  please help us with this?

We are checking this internally, we will get back to you.


Adding value pair series

One can add multiple value pair series, e.g. to show original points of a linear regression. So called "value pair series" can be removed or cleared for further usage.

Hi. I used your nice addon for one of my projects and thought it would be nice to add some functionality that I was searching for in my project. Maybe you will consider my addition.
It's my first time contributing to another ones project, I hope I followed the right process haha.
I tried to follow your coding practices.

Hi, I'm glad you like this plugin.
I'm also new to PR. I'll take a look at your code over the next few days, and keep you posted.

I've been looking at the new feature that displays points. One question: how do you add new points to a chart for which you've just deleted the pairs series with clear_value_pair_series()?
In my implementation, I have add_point() and add_points() functions which allow me to add new values to an existing plot.
It's useful to have this function, otherwise you can't update a curve created with add_value_pairs_series().
It's a detail, but I suggest a shorter name like add_scatter() instead of add_value_pairs_series(); see  Matplotlib which served as the basis for my implementation of this addon.
Otherwise, thank you for sharing your experience with this plugin, which I hope will be useful to the community.

Thanks for your thoughts. While implementing the changes I realized, that I mainly copied your code and changed some names.
I then realized, that everything is already there and one could just implement a scatter flag to add_curve() and changing plot_2ds  draw function to draw circles instead of a polyline when the scatter flag is true. This would be like 5 lines of code :D
Please tell me if you would like this addition or if a seperated plotting system would be prefered. :)

Use add_curve() with a flag is a good solution; the simplest is always the best.

Okay, I now changed everything to using a scatter plot flag. I dont know why I didn't realize sooner :D
Thanks for your understanding. I think it could be a fine addition to your addon :)

That's fine by me. I'm merging with the master branch
Thanks again
Note : I think I'll add this scatter option in the plugin for Godot 4 (https://github.com/LD2Studio/godot4-graph2d)


Use the assembly name to derive the DI extension method name

Motivation
Using the name AddApis for an extension method will cause a lot of
confusion for consumers adding multiple Yardarm generated SDKs.
Modifications
Derive the name AddXXXApis for the extension method from the generated
assembly name. For example, Project.Client becomes
AddProjectClientApis.

/merge


Mui5?

Hey these MUI theme generator seems to be the best one. Is this project still maintained? Are you planning on deploying a MUIv5 version?

Hi @dwjohnston, in case you haven't seen it, someone forked this project and updated that fork to work with MUIv5. The person who did that shared a link to the fork in the following comment: https://github.com/bareynol/mui-theme-creator/issues/8#issuecomment-1091326287


Add PostHTML/SugarML icon

hi, first thx for this awesome package, really appreciated.
Whats the appropriated path for adding/request adding an icon to file-icons. i read the CONTRIBUTING guide but not sure a to proceed.
We made a 'sugar syntax' (jade-ish) for posthtml, posthtml if unknown is similiar to want postcss is for css. The logo is in .svg.
Are there restrictions in terms of accepting new icons related to popularity of the tool?

Hrm, I'm not sure. @DanBrooker should answer this question.
As for the format, what file extension does your precompiler use?

@Alhadis you're fast :)

what file extension does your precompiler use?

You mean .ai or .ink etc? Why does this matter? Anyways i need to ask the creator :).

@Alhadis is this a question of how we determine what icons to add? Is there a performance or maintenance cost we need to be considering.

No performance or maintenance cost, mate. Just curious if there's a criteria for notability, if any. =) Just realised I hadn't thought about it until now, haha.
@michael-ciniawsky It matters because if the extension conflicts with a "well-known" filetype, adding the icon won't do much good unless users configure their stylesheets to display the icon.

BTW, there is a slight performance concern with the Less-controlled approach we have now, but v2 will pretty much eradicate those issues.

Hmm well my main motivation for this package was to help differentiate file types, so I think if an icon adds clarity then thats good, and bad if it makes things less clear.
So, I would think if people want less well known file extensions added then maybe submitting a PR should be a minimum.

@Alhadis the file extension would be  .phtml (html with posthtml), .sml(html with sugarml-parser) and  .smg(svg with sugarml-parser). To my knowledge none is used by other languages

maybe submitting a PR should be a minimum.

@DanBrooker  Sure, but i need to get to it first

.sml is used by Standard ML, and there are 101,697 results for that extension on GitHub. .smg seems okay, though.
.phtml is generally used for PHP templates, and there're over 4 million results with that extension.

😟 that's bad news thx for looking that up, ```.ssml``? is used approximately 2000 times, seems to be some other xml dialect

Hrm, why not use .posthtml?

it's an awfully long name :). the normal html5 icon is absolutely fine for plain posthtml html files, but the more urgent one is an icon for different syntax which should be visually recognizable somehow
uhh.. the naming nightmare 😄

.smu maybe, thats 113 existing then, i have more html related on my machine :)

Honestly, I'd avoid any three-letter extension if it can be helped. Being specific protects your format from conflicts, even if it does look harder to type. Then again, the same criticism can be applied to any safe password, heh.
Even if there aren't many .smu files out in the wild now, you don't know if that's going to change in future...

@Alhadis sry for the delay i'm currently asking in the community what options we have and agree upon. Yeah you're definitely right. if it bothers you close the issue for now i file a new one when we agreed on the matter. Otherwise i came back here as soon as possible. Thanks for your patience until now 👍

All good, mate. =)


fix(mempool): Fix data race when rechecking with async ABCI client

Fixes #2225 and #1827
(#2225 is now fixed in a separate PR, #2894)
The bug: during rechecking, when the CheckTxAsync request for the last transaction fails, then the resCbRecheck callback on the response is not called, and the recheck variables end up in a wrong state (recheckCursor != nil, meaning that recheck has not finished). This will cause a panic next time a new transaction arrives, and the CheckTx response finds that rechecking hasn't finished.
This problem only happens when using the async ABCI client, where CheckTx responses may arrive late or never, so the response won't be processed by the callback. We have two options to fix this.

When we call CheckTxAsync, block waiting for a response. If the response never arrives, it will block Update forever.
After sending all recheck requests, we flush the app connection and set a timer to wait for late recheck responses. After the timer expires, we finalise rechecking properly. If a CheckTx response arrives late, we consider that it is safe to ignore it.

This PR implements option 2, as we cannot allow the risk to block the node forever waiting for a response.
With the proposed changes, now when we reach the end of the rechecking process, all requests and responses will be processed or discared, and recheckCursor will always be nil.
This PR also:

refactors all recheck logic to put it into a separate recheck struct. The fix to the bug described above is the only change in the recheck logic.
adds 4 new tests.

PR checklist

[x] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments
[x] Title follows the Conventional Commits spec

thank you

@hvanz ready for review?


Unable to set api : Getting Timeout

I am using Windows 7, I had downloaded the latest version of both cf and cf_edge, and here are the versions of each of them:
C:\Users\pradipta>cf --version
cf version 6.22.1+6b7af9c-2016-09-24
C:\Users\pradipta>cf_edge --version
cf version 6.22.1+13769fc-2016-09-30
As suggested I ran the following:
1)
C:\Windows\system32>curl -vvv https://api.springcloudeureka.com

Rebuilt URL to: https://api.springcloudeureka.com/
Trying <IP_ADDRESS>...
connect to <IP_ADDRESS> port 443 failed: Timed out
Failed to connect to api.springcloudeureka.com port 443: Timed out
Closing connection 0
curl: (7) Failed to connect to api.springcloudeureka.com port 443: Timed out

And had set the CF_DIAL_TIMEOUT to 20

However, I am still stuck with the same problem:
C:\Users\pradipta>cf_edge api https://api.springcloudeureka.com
Setting api endpoint to https://api.springcloudeureka.com...
FAILED
Error performing request: Get https://api.springcloudeureka.com/v2/info: dial tcp <IP_ADDRESS>:443: i/o timeout
TIP: If you are behind a firewall and require an HTTP proxy, verify the https_proxy environment variable is correctly set. Else, check your network connection.
I am new to CF, so could have missed any thing, please do let me know.

@pmaitra This is likely not an issue with the CLI. The fact that you can't run curl  https://api.springcloudeureka.com suggests that there's something wrong with your CF deployment, specifically your networking and DNS setup. For starters, I've noticed that your domain, api.springcloudeureka.com, does not resolve. Start by making sure that your DNS is set up correctly -- you should be able to run nslookup api.springcloudeureka.com.
Please also answer the following questions so I can help you figure out what's going on:

What IaaS is your CF deployment running on? (AWS, Openstack, Google, vSphere, etc.)
Please post your deployment manifest. Be sure to remove any passwords or other sensitive information.

@dsabeti

I tried using IBM Bluemix to Build and Deploy my Code, after creating the ORG (QTS) and SPACE (dev).
After that, I could use the CF CLI to login using the API endpoint: cf login -a api.ng.bluemix.net
I could then create the user provided service using the cf cups command: cf cups springcloudeureka -p '{"uri":"http://springcloudeureka.mybluemix.net/eureka/"}'
Next I could see my service at the dashboard and also could run the app http://springcloudeureka.mybluemix.net/

I had followed information available on the internet and all these went fine using the IBM Bluemix.
However, I would like to know, If I were to use CF CLI for the API end Point creation and then login and deploying my app, what are the steps required? Do I have to own a domain before hand? I had tried to follow the information available on the internet, however, it seems there is some gap which is causing me this trouble. In case you are in a position to help, please be kind enough. Thanks

@pmaitra I think I understand now: you want to push your app to a Cloud Foundry (in this case, Bluemix), but you'd like to use your own custom domain springcloudeureka.com instead of their default *.mybluemix.net. If that's what you'd like to, indeed you need to own the domain before hand. There's some additional work involved once you own the domain as well -- most likely, setting up DNS records so that your custom domain resolves to the Bluemix routers. You'll have to ask Bluemix support for specific instructions for that, but a quick Google search found this to help you get started.
Hope that helps!


WIP: Stagger pusher

Closes https://github.com/api3dao/signed-api/issues/50 (if this is the implementation we want to go with).
I pushed a docker image on my personal account with this change so it can be tested on AWS https://hub.docker.com/layers/siegrift/api3-pusher-testonly-clone/wip-stagger/images/sha256-45ec5db658f5f1e268ecbb9e1a693d6823b415a49272b49064d9647d5408586c?context=explore

There are no more timeouts on low cloud resources, it works smoothly.

Thanks. Do you have access to these graphs  ? I'd be interested if the memory and CPU consumption changed somehow.

@Siegrift

Thanks, I see that the memory usage dropped significantly (by ~50%) which I don't have explanation for 🤔


With multiple languages, tessedit_do_invert=0 only works for the first one

Hi everyone,
I'm not sure this is the default behavior or not, but I found that  tessedit_do_invert=0 only works for the first one with multiple languages?
Environment
tesseract 4.1.1
leptonica-1.78.0
libgif 5.2.1 : libjpeg 6b (libjpeg-turbo 1.2.1) : libpng 1.2.49 : libtiff 3.9.4 : zlib 1.2.3
Found AVX
Found SSE
Linux xian 2.6.32-754.el6.x86_64 #1 SMP Tue Jun 19 21:26:04 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Current Behavior:
Here is the testing image:

If I run  time tesseract original.png stdout -l eng --oem 1 --psm 1 -c tessedit_do_invert=1

India and China went to war in 1962 over the same Himalayan region where at least
20 soldiers were killed Monday night in a bloody confrontation between the two
sides. A little under six decades ago, one month of combat resulted in a Chinese
military victory, with Beijing declaring a cease-fire after securing de facto control of
Aksai Chin, an area claimed by both countries. The month-long battle claimed the
lives of around 700 Chinese troops and approximately double that on the Indian side.
But the militaries that face off in the Himalayas today are far different from those
that fought 58 years ago.
tesseract original.png stdout -l eng --oem 1 --psm 1 -c tessedit_do_invert=1  6.41s user 0.78s system 98% cpu 7.281 total

Then I run  time tesseract original.png stdout -l eng --oem 1 --psm 1 -c tessedit_do_invert=0

India and China went to war in 1962 over the same Himalayan region where at least
20 soldiers were killed Monday night in a bloody confrontation between the two
sides. A little under six decades ago, one month of combat resulted in a Chinese
military victory, with Beijing declaring a cease-fire after securing de facto control of
Aksai Chin, an area claimed by both countries. The month-long battle claimed the
lives of around 700 Chinese troops and approximately double that on the Indian side.
But the militaries that face off in the Himalayas today are far different from those
that fought 58 years ago.
tesseract original.png stdout -l eng --oem 1 --psm 1 -c tessedit_do_invert=0  4.55s user 0.53s system 98% cpu 5.132 total

Clearly tesseract run faster.
 A little under six decades ago, one month of combat resulted in a Chinese
military victory, with Beijing declaring a cease-fire after securing de facto control of
Aksai Chin, an area claimed by both countries. The month-long battle claimed the
lives of around 700 Chinese troops and approximately double that on the Indian side.
But the militaries that face off in the Himalayas today are far different from those
that fought 58 years ago.
tesseract inverted1.png stdout -l chi_tra+eng --oem 1 --psm 1 -c   10.08s user 1.34s system 98% cpu 11.545 total

The result is correct!!!
Then I test time tesseract inverted1.png stdout -l eng+chi_tra --oem 1 --psm 1 -c tessedit_do_invert=0

India and China wentto war in 1962 overthe same Himalayan region where at least
20 soldiers were killed Monday nightinabloody confrontation between thetwo
sides. Alittle under six decades ago, one month of combat resulted inaChinese
military victory with Beijing declaring a cease-fire after securing de facto control of
PE 二 Ca 加 三 ELEE 三 上
lives of around 700 Chinese troops and approximately double that on the Indian side.
Butthe militaries that face offin the Himalayas today are far different from those
that fought 58 years ago.
tesseract inverted1.png stdout -l eng+chi_tra --oem 1 --psm 1 -c   22.35s user 3.22s system 96% cpu 26.538 total

So it seems that tessedit_do_invert=0 only works for the first language?
If the answer is yes, I can't get "full benefit" from tessedit_do_invert for the image with multiple languages...
For example:

If I run  tesseract inverted1.png stdout -l eng+chi_tra --oem 1 --psm 1 -c tessedit_do_invert=0, only English model will not check inverted text.
Expected Behavior:
If I set tessedit_do_invert=0, it means that I'm sure the image has no inverted text, so all languages should not check inverted text.

I am afraid that none of the parameters in class Tesseract is currently set for the second language, so this issue not only affects tessedit_do_invert (see full list in tesseractclass.h).


Bump Node v12 to v16

Addresses #70

Quick regression test successful in https://github.com/klardotsh/zulip-gha-playground/actions/runs/3581955562, going to do a quick reword of your commit message and merge this momentarily (but not yet tagging a new version - I need to chat with @alexmv and/or @timabbott in the morning about process and plans for a @v1.1 with just this change, or whether this gets rolled into whatever version eventually contains #69).
Thanks for your contribution!


ERROR: The Compose file './docker-compose.yml' is invalid because

when I try to run this command I get following issue.
sudo docker-compose build osm-poi osm-parquetizer

ERROR: The Compose file './docker-compose.yml' is invalid because:
Unsupported config option for services.admin-boundaries: 'profiles'
Unsupported config option for services.database-importer: 'profiles'
Unsupported config option for services.database-transformer: 'profiles'
Unsupported config option for services.google-poi-api: 'profiles'
Unsupported config option for services.google-poi-pipeline: 'profiles'
Unsupported config option for services.google-trends: 'profiles'
Unsupported config option for services.jupyter: 'profiles'
Unsupported config option for services.osm-parquetizer: 'profiles'
Unsupported config option for services.osm-poi: 'profiles'
Unsupported config option for services.population-density: 'profiles'
Unsupported config option for services.postgres: 'profiles'
Unsupported config option for services.torproxy: 'profiles'

However it runs successfully if I comment out profile and its subitems in .yml file.
Is it right to do so? Would it create a problem ahead?

Hi @patilauminfi! Removing the profile attribute in the .yml file would indeed cause issues and break things in the pipelines as they sometimes depend on each other.
I could not reproduce the error but my guess would be that your docker-compose version might not be the latest. Are you running docker-compose v2? We had people on Windows running into that so we've added the hint to the documentation.


[6.x] Ability to use firstOrNew without passing the $attributes parameter

This pull request is to make firstOrNew easy to read and works as first do, e.g.
$post = Post::where('something', 1)->firstOrNew();
$post->user()->associate(auth()->user());
$post->save();

This would need to go to master.

Feel free to send this to master!

@driesvints Done #30092


Add comma as a way to list statements

All these cause syntax errors:
Example 1
ask { 1, 2 }
// returns 2

Example 2
ask {
  1, 2
}
// returns 2

Example 3
for(let i = 0; i < arr:size; i = i + 1, sum = sum + arr:at(i)) { }

Hello, I want to contribute to these issue.
Can you please guide me and specify in which files I have to make this change?
@mhagmajer

Hello @hunarjain! The parser definitions are stored in https://github.com/xFAANG/askql/tree/master/src/askscript/parser. @czerwinskilukasz1 is the owner of that part of the codebase

Hello @czerwinskilukasz1  I am really interested in resolving this issue can you please guide me as to what type of changes I have to make in the parser files mentioned by @mhagmajer.

Hello @hunarjain , I am very happy you volunteer to do this task - it would be a useful syntax structure.
You will need to edit a grammar file (https://github.com/xFAANG/askql/blob/master/src/askscript/parser/askscript.grammar.pegjs) to:
step 1) make pegjs accept expression with a comma-separated list of statements.  I would try adding a new definition to nonArithmNoMethodsExpression .  Please read more about PegJS if needed from their site: https://pegjs.org/
step 2) write appropriate code in https://github.com/xFAANG/askql/blob/master/src/askscript/parser/askscript.grammar.pegjs.classes.ts, which will handle this and translate to mhagmajer's structures - please consult with him what's the most convenient way. Likely you will produce a code block for the comma-separated list of statements (and the last one will be treated as a return value for the whole block just out-of-the-box).

Hello @czerwinskilukasz1 ,
Please help me by guiding how to run the above mentioned file on my system to check errors and debug them. I am trying for first time so if you could guide me, it would be a great help to get a start.
Thanks

Hello @khushboo97  you can use the playground
https://cli.askql.org/


Fix sampling and Kafka reporter conflicting.

@peng-yongsheng reported this conflict. As they used to extend the same core service, when both of them are active, which could happen, they can't work together.
But, from the design perspective, I notice, ignore plugin actually is just a sampling service. It used ContextManagerExtendService extension, just because only sampling service API doesn't provide the operation name.
In this PR, I changed the sampling service API, and move TraceIgnoreExtendService to extend it. So conflict goes away.

This commit makes TraceIgnoreExtendService overrides SamplingService, so sample count or trace prefix only pick one?

It used to be in either, not both. This is fixing other bugs. TraceIgnoreExtendService technically is a sampling mechanism, but base on rules.

I understand what's your means.And we are already cherry-picked this commit to our 8.1.0 to solve conflict, I mean for functionaly, filter trace by operation name and limit by count should be both.
I'm trying write a new SamplingService to override it, but I still hope these two function could be original.

I'm trying write a new SamplingService to override it, but I still hope these two function could be original.

You could simply contribute this to the ignore plugin, which could just call super#doSampling. We are welcome to contribute to this feature.


Restart Kubernetes from Azure Portal, then SpinApp couldn't run anymore

I followed the guidance in the README file. It worked very well.
However, one issue that has happened to me is that if I stop the AKS cluster and restart it again, SpinApp (deployment) will be in spending status forever. See below

The logs:
104s        Normal    Scheduled                 pod/simple-spinapp-84c9b4885b-bf682                               Successfully assigned default/simple-spinapp-84c9b4885b-bf682 to aks-nodepool1-18815957-vmss000001
12s         Warning   FailedCreatePodSandBox    pod/simple-spinapp-84c9b4885b-bf682                               Failed to create pod sandbox: rpc error: code = Unknown desc = failed to get sandbox runtime: no runtime for "spin" is configured
I tried to delete it by using:
kubectl delete -f https://raw.githubusercontent.com/spinkube/spin-operator/main/config/samples/simple.yaml

And
kubectl apply -f https://raw.githubusercontent.com/spinkube/spin-operator/main/config/samples/simple.yaml

It was still not working.
The only way to make it work again is to use helm delete spinkube, and re-install it again on the AKS cluster.

interesting, were you able to ssh into the cluster node and check if the spin shim binary still exists in PATH or the contaienrd's config.toml still have the CRI config for the spin shim?

I'm seeing the same behavior.  Indeed, when the (new?) node comes back up after the AKS stop/restart, it is missing the spin chim CRI config -- thus the SpinApp pods are stuck in ContainerCreating with failed to get sandbox runtime: no runtime for "spin" is configured).
The current quick fix is to re-annotate node(s) (eg kubectl annotate node --all kwasm.sh/kwasm-node=true).  But the best resolution would be for AKS to preserve the containerd configuration through the stop/restart cycle.

I will reach out to the AKS team to find out the configuration issue

I will reach out to the AKS team to find out the configuration issue

Thanks, @Mossaka @vdice for acting on it. I'm waiting for it.

This issue also affects Kubernetes clusters outside of Azure that have capabilities like horizontal cluster auto-scaling or scheduled node upgrades.
As an intermediate solution, I created a small DaemonSet that starts a Job to annotate the current Kubernetes node.
Although the solution isn't ideal, It guarantees that new nodes will be annotated with kwasm.sh/kwasm-node=true.
@Mossaka I'm happy to polish my workaround and publish it on GitHub so that others will have a solution for this.


Hiding in Modal-events breaks Modal

There is some problem when calling Modal.hide() in the event-listener at least for shown.bs.modal and the Modal is already hidden.
var overwritten = {};
function showModal(modal, notimer) {
    overwritten[modal] = notimer || false;
    if (!modal.Modal) {
        new Modal(modal);
        modal.addEventListener('hide.bs.modal', function (evt) {
            overwritten[modal] = true;
        });
        modal.addEventListener('shown.bs.modal', function (evt) {
            setTimeout(function () {
                if (!overwritten[modal]) {
                    modal.Modal.hide();
                }
            }, 1500);
        });
    }
    modal.Modal.show();
}

Without the workaround with overwritten and the additional event listener for hide.bs.modal, at the next Modal.show(), the dialog shows up very short and will disappear immediately and the body-class stays set. So the UI is broken, because half of the Modal is left and you can not close the Modal anymore.
This happens when the Modal got hidden by some other call (e.g. escape key) before and the timeout-function is running and calling Modal.hide() afterwards.
There are no JS errors in console.
I've no tested if the problem is with hiding a hidden Modal or with the timeout-event or both in combination.

Give me a pen or fiddle so I can understand what you mean ;)

I have the same problem; When trying to hide a openend modal, the backdrop is still active while the modal is not.

@kolbma and @Vuurvlieg, what version of the library are you using? I had what I believe is the same problem on v2.0.19 but upgrading to v2.0.26 resolved the issue.

I'm at v2.0.26

@thednp  @jhunschejones I am using the latest release, which is version 2.0.26.
I created a example and also video recorded. It is important to note that closing the modal often works perfectly, but in like 30% of the times the Modal bug appears.

With this modified pen https://codepen.io/anon/pen/QPVPZo I've it always on the 2nd button click.

This seems to be the perfect test case to make it bulletproof. I will have a look at it asap.

@Vuurvlieg @kolbma your examples are very very hard to make it work. It almost feels like an unfair challenge when in my mind this component was meant to be a good alternative to the original jQuery plugin with light and fast code execution.
In the long run this would eventually get fixed as I know something like a setImediate or setTimeout alternative will come forward to come in handy solving this. Right now, a "gated" setup on each step of the execution could probably solve the issue, but I'm also open to any solution you might come with.

@thednp
Some previous versions ago this bug did not occur. I think this bug was introduced in
https://github.com/thednp/bootstrap.native/issues/266.  I believe before this we were using SetTimeout which was working fine for me.

but I will need your help in testing and validating the proposed code changed to come.

No problem. Just let me know when you are ready and I will test as much as needed.

Currently working on something that seems to make sense.

@Vuurvlieg @kolbma and anyone else, please test the latest master with your hardest test and let me know how it goes asap.
Keep in mind:

wait for animations to complete
or force actions while animation is running
want to know any suggestion on how to improve the code and the best on how to manage this case you've showcased above

@thednp  Please dont close this issue as its not fixed yet.
I'd love to test your solution but unfortunately I ran into a new issue, which is a HTML form can not be submitted inside a Modal. Before may 28 did this work perfectly.
See https://codepen.io/anon/pen/qGvWGY: open the modal and try to submit the form. Nothing happend.

It was closed automatically as referenced in my commit.

Let's take this step by step. First I need to know if our original issue is fixed. Then we can handle the new one ok?

@Vuurvlieg solved, check master code.

@thednp  Thanks, submitting the form does work again!
So I've tested your solution from https://github.com/thednp/bootstrap.native/issues/281#issuecomment-497927542 and it seems to work for the example given by @kolbma. However, it does not work for the codepen example given by me earlier. Once I open a second model when the first modal is still openend, the backdrop is being removed completely.
Im not sure but my suggestion is to get rid of all SetTimeOut events and implement the transitionend_event functions. So I mean, when the Modal uses (fade) animation, the bootstrap events shown.bs.modal & hide.bs.modal should  be fired, only if the transitionend_event does occur.
Let me clarify this by some code. (Again I'm not sure if this ever would work but it might be a solution to put inside the core of the Bootstrap native Modal component with some tweaking)
const el = document.querySelector('.modal.fade');

el.addEventListener('transitionstart', function() {
  // fire the "show.bs.modal" event
});`

el.addEventListener('transitioncancel', function() {
  // fire the "hide.bs.modal" event
});

el.addEventListener('transitionend', function() {
  // fire the "shown.bs.modal" or "hidden.bs.modal" event, depending on modal state
});

@Vuurvlieg why use a native script as it was jQuery? Why initialize modal inside the handler of another button click event? You are creating more and more memory addresses, meaning you use more memory, you mess up the private constants and variables, it's inconsistent, it's not good development practice.
Why not initialize modal, attach events, whatever, all before adding the click handler to only do the show() method?
Try and brake this re-written example in less than 100 times.

@thednp

Why add even more event handlers on every click? You are creating more and more memory addresses, meaning you use more memory, you mess up the component private constants and variables, you are constantly bloating the DOM with new handlers (yes you set to once: true, but GC happens when it happens),

I'm sorry but I do not agree with this. Indeed I do use once: true, and if Bootstrap Native does work correctly and follow the correct standards, every handler should be removed (from DOM) when closing the Modal. I have tested this in my website and indeed every handler is removed when the Modal is closed. It does not have any performance issues doing it this way. Everything runs very smooth and fast as long the handlers are being removed from DOM when needed.
Anyway, the only problem I have right now with the latest master is that the backdrop is removed when I open the second modal while the first modal is still being open. Check this example.
I think once this backdrop issue is fixed, the modal is working as it should.

I put a lot of effort in solving this, tried everything I know, even if it doesn't affect me or a larger portion of the community, I was expecting you would confirm.
As I said, this library doesn't do jQuery, it doesn't replace original library functionality word for word, if you want to use it, you use it the way I show you working on my modified version of your example because unfortunately I don't have anything else to help you.
Meanwhile I'm going to close this until we have a solution or at least someone else struggling with the same situation.

For the missing backdrop there is a very easy fix.
Inside the this.show = function() {} of the Modal component
if (document.querySelector('.modal-backdrop')) {
   removeOverlay();
}

Working example, adjustment is done in JS at line #1244

Will check that asap.

That's not a good resolution for some reasons:

we already have removeOverlay() queued for the above part closing currently open modal;
the demo already showcases opening a modal from another modal on V3 and main site, working perfect, and I tested it successfully with and without the fade class.

I suggest you fork the project and use your "fix".

the demo already showcases opening a modal from another modal on V3 and main site, working perfect, and I tested it successfully with and without the fade class.

Well, then you should test it again carefully because the showcase doesn't work either. Same problem at other level.
I digged into the core code and its very logical that the backdrop is not shown. Its all about the timeouts with its intervals: When a second modal is being opened while the first one is already open, the current code executes the this.show() function first, then the this.hide() function, which hides the first model AND sets too late modalOverlay to zero, which results in the backdrop of the second modal is never created.
Simply adding a setInterval in the this.show() function of the Modal component solves this problem. For anybody with the same problem, take a look at this quick crafted working example, at JS line #1245.

@kolbma is your original issue solved in the master please?

@kolbma and @Vuurvlieg I've updated the wiki in regards to this issue.
https://github.com/thednp/bootstrap.native/wiki/FAQs#does-it-support-jquery-style-instance-hooks

I'm getting this issue too.

@tamb what is your use case?


ISPN-8860 Lazy start counter's caches

https://issues.jboss.org/browse/ISPN-8860

@ryanemerson of course. I'm fetching the async operations executor to start the cache :+1:

@pruivo don't know if related but there are 2 counter failures 😢
org.infinispan.counter.StrongCounterTest.testCompareAndSetConcurrent
org.infinispan.counter.RemoveCounterTest.testCounterManagerNonExistingRemoveWithBounded

@karesti I'm aware. The fist is being tracked in another JIRA and the second should be fixed now. I have a third related to cluster listener that I need to fix :)

@pruivo let me know when is good from you side and I merge!

@karesti let CI run first :)

org.infinispan.counter.WeakCounterNotificationTest.testMultipleListeners failed but another issue has been merged that should correct it.
Let's rebase, let CI pass and merge! 💃


Npcap support

WinPcap Has Ceased Development
The WinPcap project has ceased development and WinPcap and WinDump are no longer maintained. We recommend using Npcap instead.
but actually  ptunnel-ng  does not work with  npcap

It should actually work with the npcap WinPcap compatibility mode. But I did not test npcap. I will work on this issue ASAP.


Fix small typo

There was a missing closing paren in this code snippet.
Fixes #2113

@CTNicolas Feel free to merge this PR yourself after approving!


[Task]: Change of onboarding point to start creating application behind feature flag

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks

Change the creation of application flow : Choose between template or scratch
Fix the test cases if failing or support if for A/B test false value.
Notion doc : https://www.notion.so/appsmith/By-improving-the-templates-discoverability-we-ll-increase-the-of-users-who-start-from-a-template--5f219f72c5d74466a31662b9d928b01d

Designs: https://www.figma.com/file/kbU9xPv44neCfv1FFo9Ndu/User-Activation?type=design&node-id=2338-29522&mode=design&t=yFOm2Xh625BLfr41-0

from the test party: we need to fix one bug before shipping https://www.notion.so/appsmith/06a556f6c8984125a292f231647bacc5?v=fbaffbe2830b4cb7b5f6a573cb4630ef&p=9437501105a8458489640065dcb41a51&pm=s


Why vander_generic is slower for Float32 than Float64

There was the question on day 1 why vander_generic is slower for Float32 than for Float64 and and using the Float64 variant even for Float32 seems to be beneficial:
https://github.com/crstnbr/JuliaNRW21/blob/337eacb40950ea37c5e0de485fe7ecb9192efb68/Day1/5_generic_programming.ipynb#L197
Comparing the assembly shows that calls to an out-of-bounds check (jl_bounds_error_ints) appear more often in the Float32 version than the Float64 version. This seems to be the reason for the slowdown. Telling Julia that all indices are within range of the vectors/matrices significantly speeds up the routine:
Data:
x = rand(Float64, 100)
y = rand(Float32, 100)

Original:
@btime vander_generic($x)
  6.579 μs (2 allocations: 78.20 KiB)
@btime vander_generic($y)
  8.125 μs (2 allocations: 39.14 KiB)

Modified:
@btime vander_generic($x)
  4.098 μs (2 allocations: 78.20 KiB)
@btime vander_generic($y)
  2.615 μs (2 allocations: 39.14 KiB)

Modified code:
function vander_generic(x::AbstractVector{T}) where T
    m = length(x)
    V = Matrix{T}(undef, m, m)
    for j = 1:m
        @inbounds V[j,1] = one(T)
    end
    for i= 2:m
        for j = 1:m
            @inbounds V[j,i] = x[j] * V[j,i-1]
        end
    end
    return V
end

Maybe something for the Performance Gotchas session tomorrow?

Good catch. However, it's still not clear why the Float32 version without @inbounds is slower, i.e. why there are more out-of-bounds checks in this case than for Float64. Or am I missing something?

Actually, on my machine the @inbounds doesn't solve the issue:
julia> function vander_generic(x::AbstractVector{T}) where T
           m = length(x)
           V = Matrix{T}(undef, m, m)
           for j = 1:m
               @inbounds V[j,1] = one(T)
           end
           for i= 2:m
               for j = 1:m
                   @inbounds V[j,i] = x[j] * V[j,i-1]
               end
           end
           return V
       end
vander_generic (generic function with 1 method)

julia> x = rand(Float64, 100);

julia> y = rand(Float32, 100);

julia> @btime vander_generic($x);
  4.513 μs (2 allocations: 78.20 KiB)

julia> @btime vander_generic($y);
  13.734 μs (2 allocations: 39.14 KiB)

However, it's still not clear why the Float32 version without @inbounds is slower, i.e. why there are more out-of-bounds checks in this case than for Float64. Or am I missing something?

That part is also unclear to me. I did not really try to understand the assembly, I just noticed that there is an additional block in there calling that function.

Actually, on my machine the @inbounds doesn't solve the issue:

That's interesting. So still some mysteries left...

A guess is that this is a cache alignment effect. That could also explain why it is machine dependent. But this is above my pay grade :)

A comment by Chris Elrod on the Julia Slack regarding alignment:

With 100x100 and 256-bit vectors, Float64 would be perfectly aligned, while only every other column of V will be aligned with Float32, so if you did SIMD the cartesian loops, you'd be at one of the peaks for Float64 but not for Float32 in that matrix_vector_ops link.

I also found a machine where I could reproduce your results. I already tried increasing the size to multiples of 256 bits but that did not make a difference. Also Julia and LLVM versions and the operating systems don't seem make a difference. But you found the reason in the subnormals! They will occur much more frequently with Float32 than with Float64. And I can reproduce your results when setting set_zero_subnormals(true). That way, subnormals will just be set to 0. Looks like the performance impact is very hardware dependent.
Also see https://software.intel.com/content/www/us/en/develop/documentation/cpp-compiler-developer-guide-and-reference/top/compiler-reference/floating-point-operations/understanding-floating-point-operations/denormal-numbers.html
Fascinating! Thanks for sticking with me here :slightly_smiling_face:

But don't ask me what set_zero_subnormals does exactly :)

Operating on subnormal numbers are very slow (but just how much slower is architecture dependent).
Your
Your CPU can either be slow, or has an option to instead treat them as 0.
Subnormal number's exponent bits are all 0:
julia> bitstring(1e-308)[1:12]
"000000000000"

julia> bitstring(1e-307)[1:12]
"000000000011"

Note that they're actually set to 0, just treated as 0:
julia> 1e-308
0.0

julia> bitstring(ans)
"0000000000000111001100001101011001111000000110011110100011010010"

Most CPUs have flags that determine how they handle subnormal numbers.
The default in Julia is to be correct but slow.
set_zero_subnormals lets the CPU instead treat them as 0/flush them to 0 which is fast.

Great that we could find an answer! Let's close this.


Forward and Rotate functions should call ExecuteBasePath in mobilebase

Title says it all.

Fixed in #126.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/63238

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/95879

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/117364

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/118189

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/120643


⚠ Bofrost.at has degraded performance

In ea08b7e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1218 ms

Resolved: Bofrost.at performance has improved in 7c47284 after 30 minutes.


FAILED: Build did NOT complete successfully

centos7:
Linux tv3-istio-b4384dc4 3.10.0-693.el7.x86_64 #1 SMP Tue Aug 22 21:09:27 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
bazel:
Build label: 4.2.1
Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Mon Aug 30 15:17:47 2021<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>
gcc:
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/lto-wrapper
Target: x86_64-redhat-linux
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-linker-hash-style=gnu --enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto --enable-plugin --enable-initfini-array --disable-libgcj --with-isl=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/isl-install --with-cloog=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/cloog-install --enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64 --build=x86_64-redhat-linux
Thread model: posix
gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) (GCC)
envoy branch:
release/v1.17
bazel build //source/exe:envoy-static -c dbg
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
INFO: Repository com_google_googleapis instantiated at:
/usr/istio/envoy/v1.17/WORKSPACE:9:23: in
/usr/istio/envoy/v1.17/bazel/api_repositories.bzl:4:21: in envoy_api_dependencies
/root/.cache/bazel/_bazel_root/7a3031017b7945b14972093896e6d879/external/envoy_api/bazel/repositories.bzl:22:26: in api_dependencies
/root/.cache/bazel/_bazel_root/7a3031017b7945b14972093896e6d879/external/envoy_api/bazel/repositories.bzl:9:23: in external_http_archive
/root/.cache/bazel/_bazel_root/7a3031017b7945b14972093896e6d879/external/envoy_api/bazel/envoy_http_archive.bzl:16:17: in envoy_http_archive
Repository rule http_archive defined at:
/root/.cache/bazel/_bazel_root/7a3031017b7945b14972093896e6d879/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in
WARNING: Download from https://github.com/googleapis/googleapis/archive/82944da21578a53b74e547774cf62ed31a05b841.tar.gz failed: class java.io.IOException connect timed out
ERROR: An error occurred during the fetch of repository 'com_google_googleapis':
Traceback (most recent call last):
File "/root/.cache/bazel/_bazel_root/7a3031017b7945b14972093896e6d879/external/bazel_tools/tools/build_defs/repo/http.bzl", line 111, column 45, in _http_archive_impl
download_info = ctx.download_and_extract(
Error in download_and_extract: java.io.IOException: Error downloading [https://github.com/googleapis/googleapis/archive/82944da21578a53b74e547774cf62ed31a05b841.tar.gz] to /root/.cache/bazel/_bazel_root/7a3031017b7945b14972093896e6d879/external/com_google_googleapis/temp13834435892062543968/82944da21578a53b74e547774cf62ed31a05b841.tar.gz: connect timed out
ERROR: Error fetching repository: Traceback (most recent call last):
File "/root/.cache/bazel/_bazel_root/7a3031017b7945b14972093896e6d879/external/bazel_tools/tools/build_defs/repo/http.bzl", line 111, column 45, in _http_archive_impl
download_info = ctx.download_and_extract(
Error in download_and_extract: java.io.IOException: Error downloading [https://github.com/googleapis/googleapis/archive/82944da21578a53b74e547774cf62ed31a05b841.tar.gz] to /root/.cache/bazel/_bazel_root/7a3031017b7945b14972093896e6d879/external/com_google_googleapis/temp13834435892062543968/82944da21578a53b74e547774cf62ed31a05b841.tar.gz: connect timed out
ERROR: no such package '@com_google_googleapis//': java.io.IOException: Error downloading [https://github.com/googleapis/googleapis/archive/82944da21578a53b74e547774cf62ed31a05b841.tar.gz] to /root/.cache/bazel/_bazel_root/7a3031017b7945b14972093896e6d879/external/com_google_googleapis/temp13834435892062543968/82944da21578a53b74e547774cf62ed31a05b841.tar.gz: connect timed out
INFO: Elapsed time: 94.725s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)

Looks like a download timeout. Assuming you're online and not blocking that domain you should retry

@Webster-Yang I'm replying here about all your various issues:

https://github.com/envoyproxy/envoy/issues/24528: this should be fixed, make sure you're using bazelisk so that you're pulling the correct version of bazel. Again on this issue there's a timeout that would likely cause a build failure later, is your network blocking things?
https://github.com/envoyproxy/envoy/issues/24507 + https://github.com/envoyproxy/envoy/issues/24510 looks like the wrong version of bazel, make sure you're using bazelisk
https://github.com/envoyproxy/envoy/issues/23646#issuecomment-1352848030 + https://github.com/envoyproxy/envoy/issues/24509 + https://github.com/envoyproxy/envoy/issues/24504 + https://github.com/envoyproxy/envoy/issues/24502 all appear to me to be compiler incompatibilities. Can you try building with clang instead? https://github.com/envoyproxy/envoy/blob/main/bazel/README.md#linux

@Webster-Yang please use this issue for any new problems.

https://github.com/envoyproxy/envoy/issues/24576 looks like this is the same as my clang comment above
https://github.com/envoyproxy/envoy/issues/24577#issuecomment-1354175191 are you manually enabling --copt="-Werror=range-loop-construct"? it looks like that's causing the failure here.


Mapping of umlauts broken

Hi all,
previous versions of Limax mapped German umlauts to the proper counterpart (e.g. ü will become ue). With the change in #44 and 4.0 unfortunately this breaks, and ü will now be mapped to a simple u which would be considered “less correct” in German.
Also, trying to fix it via a custom mapping will not help, as the _.deburr replacement happens without considering the given mappings. Our current workaround replaces them before applying limax:
  const fixedMapping = {
    ä: 'ae',
    Ä: 'Ae',
    ö: 'oe',
    Ö: 'Oe',
    ü: 'ue',
    Ü: 'Ue'
  };
  let fixedInput = input;
  for (const mapping of Object.entries(fixedMapping)) {
    fixedInput = fixedInput.replaceAll(mapping[0], mapping[1]);
  }

Thanks for reporting, as I mentioned in https://github.com/lovell/limax/issues/49#issuecomment-1642683049 it's probably a good time to vendor the upstream speakingurl and patch all the known bugs, which should allow us to drop the deburr dependency.
Happy to accept a PR to directly add the source code of https://github.com/pid/speakingurl/blob/master/lib/speakingurl.js (with the BSD-3-Clause licence added as a comment/header) instead of using it as a dependency.

Thank you for the feedback - I'll see if I find the time to come up with a MR during the next week 👍