Almost File By Version /2

Internal review URL
Intermediate step to File By Version (FBV)
Versions < 6 were too much work to split out
:::moniker range=">= aspnetcore-7.0"
:::moniker range="= aspnetcore-6.0"
:::moniker range=">= aspnetcore-3.1 < aspnetcore-6.0"   // 3.1 & 5
:::moniker range=">= aspnetcore-5.0 < aspnetcore-6.0"  // 5
:::moniker range=">= aspnetcore-3.0 < aspnetcore-6.0"  // 3.0, 3.1 & 5

No more tedious and error prone moniker prep, no more tedious and error prone moving moniker sections at GA. ~What we do loose is a diff file showing what has changed, but on most updates, that's not useful anyway.~
Losing the diff is optional, can use the old moniker version prep approach and then you don't lose that.

@tdykstra  no need to review the changes other than this new approach to using includes.

Is this what their guidance says to do? If so, I'm utterly shocked by it. Version by File was ... I thought ... based on the version as a URL segment that reflects the version and with the files being in version-named folders (e.g., "3.1", "5.0", "6.0", "7.0", etc.).

Is this what their guidance says to do? If so, I'm utterly shocked by it. Version by File was ... I thought ... based on the version as a URL segment that reflects the version and with the files being in version-named folders (e.g., "3.1", "5.0", "6.0", "7.0", etc.).

No, this is just to make it easier for FBV move, that's why I call it IFBV, intermediate or include File by version.

Oh, I see ... gotcha 👍

A great creative solution for getting this a step closer to the goal!  Thanks!
Resource versioning
I think it would be good to call out what is happening with resources the .md file is using in addition to the include.  To get a distinct version we don't have to sort out later, I would expect the app samples and screenshot/art resources to be clearly identified with a version somehow.  That would mean in some cases copying them, however when needed to a new version id of some sort and would increase the size of the repo.  On the other hand, later, when archiving, which would significantly reduce the size of the repo we would not have previous resource versions as a dependency for newer ones.  Thoughts?

A great creative solution for getting this a step closer to the goal!  Thanks!
Resource versioning
As a matter of applying this to all topics: I think it would be good to call out what is happening with resources the .md file is using in addition to the include.  To get a distinct version we don't have to sort out later, I would expect the app samples and screenshot/art resources to be clearly identified with a version somehow.  That would mean in some cases copying them, however when needed to a new version id of some sort and would increase the size of the repo.  On the other hand, later, when archiving, which would significantly reduce the size of the repo we would not have previous resource versions as a dependency for newer ones.  Thoughts?

To get a distinct version we don't have to sort out later, I would expect the app samples and screenshot/art resources to be clearly identified with a version somehow.

Why, we don't do that now. No reason to start.

That would mean in some cases copying them, however when needed to a new version id of some sort.

The worst thing we could do would be making duplicate images.

On the more immediate downside that would increase the size of the repo. Longer term however, archiving old versions would significantly reduce the size of the repo and we would not have previous resource versions as a dependency for newer ones to sort out. Thoughts?

archiving old versions would significantly reduce the size of the repo

That doesn't reduce the size, it increases it. Deleting images doesn't reduce the size as the image is always in the history.

Image history:  I am referring to the download size of the repo.  That would be smaller.  Yes, good point it would still be in history.
Why do .md resource versioning now? (we have not in the past):  So archiving and sorting out versions in the future is not messy.  We would start that now going forward to updated topics as we go to start reducing that spaghetti of dependencies.

Image history:  I am referring to the download size of the repo.  That would be smaller.  Yes, good point it would still be in history.
Why do .md resource versioning now (we have not in the past):  So archiving and sorting out versions in the future is not messy.  We would start that now going forward to updated topics as we go to start reducing that spaghetti of dependencies.
I guess if we didn't version dependent resources, we could automate by tracing each file, find its dependency and copy it to an archive repo at some point to get a clean version.

I would think this would all work for localizing, etc, but it might be good to run by the localization team just in case?  Or run it through that system once with a few examples before we change everything as we go?  Just a thought.

Why do .md resource versioning now (we have not in the past): So archiving and sorting out versions in the future is not messy. We would start that now going forward to updated topics as we go to start reducing that spaghetti of dependencies.
I guess if we didn't version dependent resources, we could automate by tracing each file, find its dependency and copy it to an archive repo at some point to get a clean version. So maybe that would be the answer for that case.

That has nothing to do with FBV or IFBV.

So archiving and sorting out versions in the future is not messy.

red herring, we aren't archiving and there is no version issue. That's not something we would prioritize.

, but it might be good to mention to localization team just in case?

Yes, I'm working with them.


fix(standoffLinks): One hasStandoffLinkToValue per standoffLink given in the text (DSP-1254)

resolves DSP-1254

Looks good, thanks!

Thanks for the review!

Looks good, thanks!

Thanks for the review!


Prepare release 3.4.0.CR1

@vsevel I've confirmed this works in 3.5.2. I pinned the dependency to 3.4.0.CR1 for quarkus-vault, quarkus-vault-model & quarkus-vault-deployment in Gradle and all passed.


[p4-symbolic] Extend SAI module with packet-in headers and metadata.

Keyword Check:
~/sonic-buildimage/src/sonic-p4rt/sonic-pins$ ~/tools/keyword_checks.sh .
Keyword check Passed.
Build Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Analyzed 598 targets (0 packages loaded, 0 targets configured).
INFO: Found 598 targets...
INFO: From Compiling p4_symbolic/sai/parser.cc:
p4_symbolic/sai/parser.cc: In function 'absl::lts_20230802::StatusOr<std::vectorz3::expr > p4_symbolic::EvaluateSaiParser(const SymbolicPerPacketState&)':
p4_symbolic/sai/parser.cc:93:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
93 |   constraints.push_back(icmp.valid == (ipv4.valid && ipv4.protocol == 0x01 ||
|                                        ~^~~~~~~~~~~~~~
p4_symbolic/sai/parser.cc:95:50: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
95 |   constraints.push_back(tcp.valid == (ipv4.valid && ipv4.protocol == 0x06 ||
|                                       ~^~~~~~~~~~~~~~
p4_symbolic/sai/parser.cc:97:50: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
97 |   constraints.push_back(udp.valid == (ipv4.valid && ipv4.protocol == 0x11 ||
|                                       ~^~~~~~~~~~~~~~
INFO: From Compiling p4_symbolic/sai/parser.cc [for host]:
p4_symbolic/sai/parser.cc: In function 'absl::lts_20230802::StatusOr<std::vectorz3::expr > p4_symbolic::EvaluateSaiParser(const SymbolicPerPacketState&)':
p4_symbolic/sai/parser.cc:93:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
93 |   constraints.push_back(icmp.valid == (ipv4.valid && ipv4.protocol == 0x01 ||
|                                        ~^~~~~~~~~~~~~~
p4_symbolic/sai/parser.cc:95:50: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
95 |   constraints.push_back(tcp.valid == (ipv4.valid && ipv4.protocol == 0x06 ||
|                                       ~^~~~~~~~~~~~~~
p4_symbolic/sai/parser.cc:97:50: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
97 |   constraints.push_back(udp.valid == (ipv4.valid && ipv4.protocol == 0x11 ||
|                                       ~^~~~~~~~~~~~~~
INFO: From Executing genrule //p4_symbolic/symbolic:port_hardcoded_test_test_runner:
Finding packet for table tbl_hardcoded55 and row -1
Dropped = 0
standard_metadata.ingress_port = #b000000000
standard_metadata.egress_spec = #b000000001
Finding packet for table tbl_hardcoded57 and row -1
Dropped = 0
standard_metadata.ingress_port = #b000000001
standard_metadata.egress_spec = #b000000000
Finding packet for table MyIngress.ipv4_lpm and row 2
Dropped = 0
standard_metadata.ingress_port = #b000000000
standard_metadata.egress_spec = #b000000001
ipv4.srcAddr = #x00000000
ipv4.dstAddr = #x0a8a0000
ethernet.dstAddr = #x00000000000a
Finding packet for table MyIngress.ipv4_lpm and row 3
Dropped = 0
standard_metadata.ingress_port = #b000000000
standard_metadata.egress_spec = #b000000001
ipv4.srcAddr = #x00000000
ipv4.dstAddr = #x14140000
ethernet.dstAddr = #x160000000016
INFO: From Executing genrule //p4_symbolic/symbolic:reflector_test_test_runner:
Finding packet for table tbl_reflector54 and row -1
Dropped = 0
standard_metadata.ingress_port = #b000000001
standard_metadata.egress_spec = #b000000001
INFO: Elapsed time: 7.791s, Critical Path: 7.03s
INFO: 27 processes: 4 internal, 23 linux-sandbox.
INFO: Build completed successfully, 27 total actions
Test Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
INFO: Analyzed 598 targets (0 packages loaded, 0 targets configured).
INFO: Found 402 targets and 196 test targets...
INFO: Elapsed time: 259.412s, Critical Path: 126.19s
INFO: 250 processes: 296 linux-sandbox, 18 local.
INFO: Build completed successfully, 250 total actions
//dvaas:port_id_map_test                                                 PASSED in 0.6s
//dvaas:test_vector_stats_diff_test                                      PASSED in 0.1s
//dvaas:test_vector_stats_test                                           PASSED in 0.0s
//dvaas:test_vector_test                                                 PASSED in 1.1s
//gutil:collections_test                                                 PASSED in 0.6s
//gutil:io_test                                                          PASSED in 0.5s
//gutil:proto_matchers_test                                              PASSED in 0.8s
//gutil:proto_ordering_test                                              PASSED in 0.6s
//gutil:proto_test                                                       PASSED in 0.6s
//gutil:status_matchers_test                                             PASSED in 0.7s
//gutil:test_artifact_writer_test                                        PASSED in 1.7s
//gutil:testing_test                                                     PASSED in 0.7s
//sai_p4/instantiations/google:fabric_border_router_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:middleblock_p4info_up_to_date_test        PASSED in 0.1s
//sai_p4/instantiations/google:sai_nonstandard_platforms_build_test      PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_cc_test         PASSED in 0.7s
//sai_p4/instantiations/google:sai_p4info_fetcher_test                   PASSED in 0.7s
//sai_p4/instantiations/google:sai_p4info_test                           PASSED in 1.2s
//sai_p4/instantiations/google:sai_pd_proto_test                         PASSED in 0.0s
//sai_p4/instantiations/google:sai_pd_util_test                          PASSED in 1.8s
//sai_p4/instantiations/google:tor_p4info_up_to_date_test                PASSED in 0.0s
//sai_p4/instantiations/google:union_p4info_up_to_date_test              PASSED in 0.1s
//sai_p4/instantiations/google:wbb_p4info_up_to_date_test                PASSED in 0.0s
//sai_p4/instantiations/google/test_tools:table_entry_generator_helper_test PASSED in 3.3s
//sai_p4/instantiations/google/test_tools:test_entries_test              PASSED in 0.9s
//sai_p4/instantiations/google/tests:p4_fuzzer_integration_test          PASSED in 3.7s
//sai_p4/tools:p4info_tools_test                                         PASSED in 0.6s
//sai_p4/tools:packetio_tools_test                                       PASSED in 0.8s
//tests:thinkit_gnmi_interface_util_tests                                PASSED in 1.1s
//tests/qos:gnmi_parsers_test                                            PASSED in 0.1s
//tests/qos:gnmi_parsers_test_runner                                     PASSED in 0.0s
//thinkit:bazel_test_environment_test                                    PASSED in 0.9s
//thinkit:generic_testbed_test                                           PASSED in 1.3s
//thinkit:mock_control_device_test                                       PASSED in 0.7s
//thinkit:mock_generic_testbed_test                                      PASSED in 1.1s
//thinkit:mock_mirror_testbed_test                                       PASSED in 0.8s
//thinkit:mock_ssh_client_test                                           PASSED in 0.0s
//thinkit:mock_switch_test                                               PASSED in 0.7s
//thinkit:mock_test_environment_test                                     PASSED in 0.1s
//thinkit:switch_test                                                    PASSED in 1.0s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test     PASSED in 1.9s
Stats over 5 runs: max = 1.9s, min = 0.9s, avg = 1.4s, dev = 0.4s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test     PASSED in 45.9s
Stats over 50 runs: max = 45.9s, min = 0.8s, avg = 5.7s, dev = 13.1s
Executed 196 out of 196 tests: 196 tests pass.
INFO: Build completed successfully, 250 total actions

Co-authored-by: Srikishen Pondicherry Shanmugam<EMAIL_ADDRESS>


Custom folder to put SMS/Call log into

I looked through the FAQ and the issues (open and closed) and might have missed it. So I am happy if I am pointed into the right direction.
I tried to set a parent IMAP folder for the SMS and Call log, but could not find the place where to do it. Is this possible at all? If not, please consider this as a feature request. Thanks.
BTW thanks for your wonderful app!!!
Please specify the following:

Android version 8.1.0
SMS Backup+ version installed 1.5.11
Messaging app QKSMS

You can specify any IMAP path, not just a single level. Gmail seemingly supports both . and / as separators, but I would stick with the former as it's strongly recommended by RFC-3501.
So you can specify folders as My Phone.SMS and My Phone.Call log.

For example, I use

Phone.SMS.name_of_device`
Phone.Calls.name_of_device`

I periodically move all the messages from that folder into one that is named for the phone number of the SIM that's currently in that device, as I move them around each time I go roaming. (Strangely enough, I haven't done that for several months.)
I'm hoping to make a change to allow SMS Backup+ to include this automatically.

Thanks @kurahaupo! That's what I was hoping for, but I was not sure if it would work and I did not want to risk to loose my text messages. Maybe it's worth to be included into the FAQ?
Your periodically performed tasks would call for placeholders in SMS Backup+'s  IMAP path …

Well, I feel really stupid: Where in SMS Backup+ exactly do I set the IMAP folder?

Backup Settings → Gmail label / IMAP folder
Backup Settings → Call log settings → Call log label

YES! It worked. Thanks!
But it is not the obvious place... What you named "Gmail label / IMAP folder" is called "Gmail label assigned to SMS" and "Call log label" "Gmail label assigned to call log". There is absolutely no hint, that this is the IMAP folder where to put the text messages and call logs. I would suggest to rename the settings accordingly, that's why I leave this issue open for now.

@sphh  I've raised proposal #1021 that sjpi;should resolve this for future users.


Convert test_kernels.py to pytest

Separate big test in test_kernels.py to several smaller tests
Use automatic converter to convert to pytest.
Add some fixtures to simplify the code.

Note that this pull request is really two pull requests combined into one.
#1) I wanted to break up test_kernels into smaller tests.  Since tests can be run individually, this vastly simplifies dealing with errors.  There is very little change between the original file and this file: just the addition of some def test_xxx() lines.
#2) I found a tool that converts Unittests into pytest.  I took the results of (1), ran this tool on it, and then made some small changes to it.  This pretty much changes every line from its unittest form to its pytest form.
If you think I should just do #1 and skip #2, or do it as a separate push, let me know.

I think this is fine to do together, and a very useful change in general. The only reason I haven't approved it is you didn't send it out for review yet.

Not sure.  I thought I sent it as a pull request rather than a preview.  In any case, it seems to be a pull request now.

It's a pull request, you just didn't ask for a review from anyone so I was waiting to see if you had more work to do.

Ah, I forgot about that part.


CI: Test on 3.8-dev, remove 3.6-dev and 3.7-dev

Fixes #286.
Changes proposed in this pull request:

Add 3.8-dev
Remove 3.7-dev
Remove 3.6-dev

There's been no change since https://github.com/pylast/pylast/pull/279, July 2018:

3.6-dev is 3.6.5+, but 3.6.7 is the latest
3.7-dev is 3.7.0a4+, but 3.7.1 is the latest

PR failed due to https://github.com/pylast/pylast/issues/171 but passed on my fork:
https://travis-ci.org/hugovk/pylast/builds/459959866


Get rid of String#substr

You may want to consider using String#substring or String#slice instead of the non-standard String#substr.

I've never met a browser not understanding String.substr() properly. I've been using this method for 5+ years without any problems what so ever?!

There may not be problems with it in current browsers, but if there’s a standard, fully specced method (and there are several options here) why not use that one?

https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/String/substr says substr() has been around since Javascript 1.0, although no ECMA specification. I wonder if this really is an issue :/

I don't disagree. I find it interesting, though, that both standardized methods slice() and substring() take an index as the end-point, rather then number of characters to read (like substr() in any other language I know does…). weird.


Samples/Printing bugs

Reported by @neoxeo :
FIXED    "Print Preview" : why there is 32000 for number page
Reported by general.loki::
Printing sample is strange. The overall functionality of the demo should be investigated.

This issue is fixed in 0.9.404


Rancher does not allow editing/upgrading prometheus parameters

I'd like to edit the statefulset for prometheus, but rancher doesn't allow me to do it.
After editing it from the UI, I can see the service got redeployed, but the yaml file just got reverted.
Also, I'd like to upgrade prometheus to a newer version, but I don't want to upgrade rancher yet. Simply changing the image in the yaml file doesn't work. The service got redeployed, then reverted back to v2.18.2.
My rancher version: 2.5.2
kubernetes version: 1.19.4

I assume you have to edit the prometheuses.monitoring.coreos.com rancher-monitoring-prometheus CRD object or the helm values. AFAIK the prometheus statefulset is created and maintained by the prometheus operator based on the CRD.

@Martin-Weiss
Thanks updating through helm worked. Since I created my cluster with terraform rancher2 provider, I added "prometheus.image.tag" = "v2.22.0" in cluster_monitoring_input. I was trying to upgrade prometheus in order to fix https://github.com/prometheus/prometheus/issues/7955


Saleor 4421/3.1/extend orderfulfill mutation by new flag to allow stock exceeded

Port changes from #8126.
In addition:

added new flag into mutation (approveFulfillment) that does not exist on 3.0 branch
resolved conflicts with added migration

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-4421 Extend OrderFulfill mutation by new flag to allow fulfill lines without stocks


Feature Request

Removed dead code
Added a method to obtain the next scheduled time

The reason for this change is to help debugging issues with timing

Hey @Depado ,
Would you know if this would be merged anytime soon?
Sean.

@MovieStoreGuy I have no idea sorry


ppwater: Watch cheapskatesguide.org

ppwater requests the watch of the watch_keyword cheapskatesguide\.org. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

cheapskatesguide\.org has been seen in 3 true positives, 0 false positives, and 2 NAAs.

cheapskatesguide\.org has been seen in 3 true positives, 0 false positives, and 2 NAAs.

Approved by Spevacus in Charcoal HQ

Approved by Spevacus in Charcoal HQ


Upgrading matplotlib to 1.5.0 seems to break plottlng from psctb.utils

After upgrading matplotlib to 1.5.0:
>>> plt = psctb.utils.plotting.Data2D(mod,['TR','ccJR2_R2'],mod.scan_res).plot()

---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-126-f438e74a5f8d> in <module>()
----> 1 plt = psctb.utils.plotting.Data2D(mod,['TR','ccJR2_R2'],mod.scan_res).plot()
      2 #plt.ax.semilogx()
      3 #plt.toggle_category('Control Coefficients',True)
      4 #plt.toggle_category('ccJR2_R2',True)
      5 #plt.interact()

/usr/local/lib/python2.7/dist-packages/psctb/utils/plotting/_plotting.pyc in plot(self)
    411                            working_dir=path.join(self._working_dir,
    412                                            self.plot_data.scan_in,),
--> 413                            base_name=base_name,)
    414         return scan_fig
    415

/usr/local/lib/python2.7/dist-packages/psctb/utils/plotting/_plotting.pyc in __init__(self, line_data_list, category_classes, fig_properties, ax_properties, base_name, working_dir)
    535         cmap = plt.get_cmap('Set1')(
    536             linspace(0, 1.0, len(line_data_list)))
--> 537         self.ax.set_color_cycle(cmap)
    538
    539         if category_classes:

/usr/local/lib/python2.7/dist-packages/matplotlib/axes/_base.pyc in set_color_cycle(self, clist)
   1124         cbook.warn_deprecated(
   1125                 '1.5', name='set_color_cycle', alternative='set_prop_cycle')
-> 1126         self.set_prop_cycle('color', clist)
   1127
   1128     def ishold(self):

/usr/local/lib/python2.7/dist-packages/matplotlib/axes/_base.pyc in set_prop_cycle(self, *args, **kwargs)
   1110             prop_cycle = None
   1111         else:
-> 1112             prop_cycle = cycler(*args, **kwargs)
   1113         self._get_lines.set_prop_cycle(prop_cycle)
   1114         self._get_patches_for_fill.set_prop_cycle(prop_cycle)

/usr/local/lib/python2.7/dist-packages/matplotlib/rcsetup.pyc in cycler(*args, **kwargs)
    718         if validator is None:
    719             raise TypeError("Unknown artist property: %s" % prop)
--> 720         vals = validator(vals)
    721         # We will normalize the property names as well to reduce
    722         # the amount of alias handling code elsewhere.

/usr/local/lib/python2.7/dist-packages/matplotlib/rcsetup.pyc in f(s)
     88         else:
     89             msg = "'s' must be of type [ string | list | tuple ]"
---> 90             raise ValueError(msg)
     91     f.__doc__ = scalar_validator.__doc__
     92     return f

ValueError: 's' must be of type [ string | list | tuple ]

Other info:

python 2.7.6 on 64-bit Linux
In [7]: pysces.version
Out[7]: '0.9.1'
In [8]: scipy.version
Out[8]: '0.14.0'
In [9]: numpy.version
Out[9]: '1.8.2'

The latest commit should fix this issue. I explain the fix in the commit message. I've tested it with both the new and an older version of matplotlib and it seems to be working. Johann, if you can confirm that it works and that you're happy, I will close the issue.

Solves the issue, thanks!
BTW is this the recommended way of dealing with this change? I.e. is there no backward compatible way? It seems a bit clunky to have to check for the MPL version. (I have not looked further into this, though).

As far as I can see, they don't mention anything regarding porting to the new version. This is the only information I can find (4 lines of text) http://matplotlib.org/devdocs/users/whats_new.html#added-axes-prop-cycle-key-to-rcparams


RBD mirror daemon count validation

RBD mirror daemon count was defaulted to 1 with no min or max limit.
This could be problematic if users set unexpected values. So, this
commit adds a minimum of 0 and maximum of 1 as valid values and retains
the default value of 1.

/test ocs-operator-bundle-e2e-aws

/test ocs-operator-bundle-e2e-aws

/cherry-pick release-4.15

/retest

/cherry-pick release-4.15

/test ocs-operator-bundle-e2e-aws


D400: false positive and bad autofix

I'm using ruff version 0.0.205
The following code triggers D400 with the message "First line should end with a period":
def list_contains_round(rounds: list[int], number: int) -> bool:
    """
    :param rounds: list - rounds played.
    :param number: int - round number.
    :return:  bool - was the round played?
    """
    return number in rounds

The first line already ends with a period, so this is a false positive. Additionally, the autofix that it applies is bad:
def list_contains_round(rounds: list[int], number: int) -> bool:
    """
    :param rounds: list - rounds played.
    :param number: int - round number.
    :return:  bool - was the round played?.
    """
    return number in rounds

it adds a period after the question mark on the third line. Ruff must think that the third line is actually the first line, but even if that was the case, the autofix shouldn't add the period after a question mark. I'm not sure what the right autofix to have instead would be though.

This smaller piece of code triggers the same bug for me. It might help with finding the problem.
def lis():
    """
    played.
    played?
    """
    pass

Thanks for reporting this. Looks like pydocstyle doesn't error here, so we shouldn't either. Will fix, should be easy.

Looking back at the code... Now I'm not so sure. First-line punctuation is really intended for summary lines. Here's an example from PEP 257:
def complex(real=0.0, imag=0.0):
    """Form a complex number.

    Keyword arguments:
    real -- the real part (default 0.0)
    imag -- the imaginary part (default 0.0)
    """
    if imag == 0.0 and real == 0.0:
        return complex_zero
    ...

Notice how, if we respected the rule in your case, we'd then get this case wrong, which would be equally "valid":
def list_contains_round(rounds: bool, number: int) -> None:
    """
    :param rounds: list - was the round played?
    :param number: int - round number.
    """
    return number in rounds

The logic as it exists today looks for the first logical line, i.e., it's sort of looking for the first line-break, and taking the lines that precede it as the "first line".
It helps get some other cases right, like:
def list_contains_round(rounds: list[int], number: int) -> bool:
    """Here's a summary line,
    but it continues onto the next line.

    :param rounds: list - rounds played.
    :param number: int - round number.
    :return:  bool - was the round played?
    """
    return number in rounds

I could probably special-case to avoid enforcing this rule at all for lines that look like a section (:param), but I doubt I can enforce that the params end in a period.

I know that the docstrings are nonstandard (they weren't written by me) but I figured that having an unusual docstring like one without a summary line still shouldn't cause ruff to autofix wrong and report an error that at least seems incorrect by the message that it gives.
If it's intended behavior (or undefined behavior or something like that) that ruff might not play nice with usual docstrings like this, then I can just close the issue and turn off D autofixes for myself in cases like this. It's not too big of a problem.
I don't know how cases like this are handled by other linters because I'm actually pretty new to linters.

Looking back at the code... Now I'm not so sure. First-line punctuation is really intended for summary lines. Here's an example from PEP 257:
def complex(real=0.0, imag=0.0):
    """Form a complex number.

    Keyword arguments:
    real -- the real part (default 0.0)
    imag -- the imaginary part (default 0.0)
    """
    if imag == 0.0 and real == 0.0:
        return complex_zero
    ...

Notice how, if we respected the rule in your case (at the end of individual parameter definitions), we'd then get this case wrong, which would be equally "valid":
def list_contains_round(rounds: bool, number: int) -> None:
    """
    :param rounds: bool - was the round played?
    :param number: int - round number.
    """
    return number in rounds

Actually if I'm understanding you right, shouldn't that case not be valid? The lint says "First line should end with a period". A question mark isn't a period, so doesn't that mean that it's still wrong? If that's not what the lint is intended to be for, then maybe the message should be changed somehow.

I think I understand now. I took the message of D400 literally. It says "First line should end with a period" so I thought that, regardless of what it is, the first line of a docstring (where there's first text), should end in a period. It sounds like what's it's actually meant to mean is "Summary line should end with a period", but it just checks for the first line because it assumes that they're the same. So if there's no summary line, then the assumption that first and summary line are the same doesn't work. Is that what's going on here?

Actually if I'm understanding you right, shouldn't that case not be valid? The lint says "First line should end with a period". A question mark isn't a period, so doesn't that mean that it's still wrong? If that's not what the lint is intended to be for, then maybe the message should be changed somehow.

Yeah sorry -- I was making a confusing point here, which is that the period at the end of the parameter description feels like a false-negative given the intention of the rule. I wasn't being very clear.

I think I understand now. I took the message of D400 literally. It says "First line should end with a period" so I thought that, regardless of what it is, the first line of a docstring (where there's first text), should end in a period. It sounds like what's it's actually meant to mean is "Summary line should end with a period", but it just checks for the first line because it assumes that they're the same. So if there's no summary line, then the assumption that first and summary line are the same doesn't work. Is that what's going on here?
Yeah that's right. We could probably do a better job of detecting that the first line in your case isn't a summary line.

I'll try to make a few improvements on that front. For example, we could ignore lines with :param, ignore sections like Args:, etc.


How to use MaTeX in WSL

I have a Windows machine, which don't have LaTeX installed, but I have install TeX in windows subsystem in Linux, so how to config MaTeX to use LaTeX installed in WSL?

I don't know if this is possible. Currently I do not have access to a
Windows system with WSL.
MaTeX uses RunProcess[] under the hood, so the question is whether RunProcess
can interact with WSL. If you can figure this out, let me know, and we'll
see what can be done.
P.S. This month I'm away and generally slow to respond.
On Fri, 22 Nov 2019, 12:27 Yuqiang Zheng<EMAIL_ADDRESS>wrote:

I have a Windows machine, which don't have LaTeX installed, but I have
install TeX in windows subsystem in Linux, so how to config MaTeX to use
LaTeX installed in WSL?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/szhorvat/MaTeX/issues/31?email_source=notifications&email_token=AAJIDR5HIAAGWROQNQXQQQLQU5NRZA5CNFSM4JQLSEK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3JCR2Q,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJIDRYZLQ7JZYBWGDRWQGLQU5NRZANCNFSM4JQLSEKQ
.

Ok, maybe replace it with RunProcess[{"wsl","pdflatex"}, args___] etc.(a way to call wsl function in windows) will work.

Thanks for the hint. I'll look into it when I'm back home in a couple of
weeks.
On Sat, 23 Nov 2019, 18:32 Yuqiang Zheng<EMAIL_ADDRESS>wrote:

Ok, maybe replace it with RunProcess[{"wsl","pdflatex"}, args___] etc.(a
way to call wsl function in windows) will work.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/szhorvat/MaTeX/issues/31?email_source=notifications&email_token=AAJIDR6MCR4SVJXXB5XGWGTQVEBFXA5CNFSM4JQLSEK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE7SJUA#issuecomment-557786320,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJIDR4HXHN7UYZRGGALRGLQVEBFXANCNFSM4JQLSEKQ
.

I looked into this briefly. While this is certainly a reasonable request, it does not seem to be trivial to implement in a robust way. Things to consider:

There may be more than one Linux environment. There should be a way to select which one to use.
Paths need to be converted. wslpath can do this.

Ideally, the entire WSL interface would be wrapped into a script, and this script could be used instead of pdflatex. The problem is that RunProcess won't run a script or a .cmd file. It requires an executable.  As a workaround it may be possible to convert a batch file to an executable, but I have not tried this.
For the moment I'll have to put this aside because of lack of time.


Blank Web Console screen - Uncaught Runtime error

Description of the bug:
I followed the steps in this youtube video: https://www.youtube.com/watch?v=Qk3K7JdIebw (cloned the repo, created an env.local file, entered my API key, ran npm install, ran start,  and all looked well and in compiled successfully. However when I start the program, I get a blank web console screen. Just before  the screen goes blank, an error flashes on the webpage. The error says "Uncaught Runtime error". See attached screenshot. Also there is a type-o in the error. it says "set REACT_GEMINI_APIK_KEY in .env" not sure if that matters et all.

Actual vs expected behavior:
No response
Any other information you'd like to share?
No response

Try to put your API key in the .env file instead.

Thanks. What is the name of the .env file supposed to be? I had to create the env.local myself.


blank scene on navigator.pop() (RN 0.29.2)

I have an issue where I am getting a completely blank scene when I use navigator.pop() to go up the the only scene in the stack.
It seems to happen when a state change occurs that affects both the parent scene (the blank one) and the child scene (the one thats getting popped).
The blank scene is a ListView, and swiping it seems to force it to display correctly.
Any idea what could be causing this?

see if removeClippedSubviews={false} helps.
refer: https://github.com/facebook/react-native/issues/8607 & https://github.com/facebook/react-native/issues/1831

Many thanks.


[WIP] Builder archetype (work)

The initial update for using builder instead of bolt as the executable. #47
@ryan-roemer

@chaseadamsio -- Few comments, rest LGTM. Haven't tested anything out though...

Considering going ahead and bumping babel to @6.x.x since this is going to be a major breaking release. Thoughts? cc @baer @ryan-roemer

@boygirl @exogen @kenwheeler @alexlande -- Are we ready for babel6 yet in our victory repos?
@chaseadamsio -- I think best bet is "just focus on the scaffolding" to isolate the feature. Then separately we tackle upgrades.

Fair point. No need for unneeded extra complexity!

I'm going to go through this commit one more time in the morning and double check, but I tested this in a project and everything seemed to work as it should.


A helm chart new release that modifies the build config change does not start a new build

Describe the bug
Releasing a new Helm Chart version that contains a change in the build section does not automatically trigger a new build.
To Reproduce
Steps to reproduce the behavior:
Deploy an application using Helm Chart and then modify the list of Galleon layers.
Expected behavior
If I'm not doing something wrong, I would expect a new build execution, to build my application with the new desired list of galleon layers.
Component Versions(please complete the following information):

Helm version ($ helm version)

version.BuildInfo{Version:"v3.7.1", GitCommit:"1d11fcb5d3f3bf00dbe6fe31b8412839a96b3dc4", GitTreeState:"clean", GoVersion:"go1.17.2"}

OpenShift or Kubernetes version ($ oc version or $ kubectl version)

oc version
Client Version: 4.8.4
Server Version: 4.9.15
Kubernetes Version: v1.22.3+e790d7f

Additional context
The OpenShift documentation contains the following note about this:
"Configuration change triggers currently only work when creating a new BuildConfig. In a future release, configuration change triggers will also be able to launch a build whenever a BuildConfig is updated."
So, although not intuitively, this behavior could be the expected one, in that case, we could use this issue as a kind of documentation. The workaround is to kick off the build manually:
oc start-build bc/<helm-release>-build-artifacts

Thanks for reporting this issue.
It seems to me that this is not a bug in our Helm Chart but just the way OpenShift works at the moment and this will eventually be changed in a future release.
I agree with you that this is not intuitive and we should definitely add a note about in the https://github.com/wildfly/wildfly-charts/blob/main/charts/wildfly/templates/NOTES.txt that is displayed to the user after helm install and helm  upgrade commands


Doesn't work in PyCharm 2022.1.2 Community Edition

I've installed the plugin from here (v0.0.5). The latest available jsonnet language server 0.7.2 has been successfully downloaded. On the status bar at the bottom of the window I see that the language server is running, but features like autocomplete, jump to definition and others do not work for both *.jsonnet and *.libsonnet files. The only thing that works is syntax highlighting. I also haven't noticed any errors.
Maybe I'm missing something obvious, not sure.

Regarding autocomplete, the language server currently only supports autocomplete for the stdlib. However, there are several autocomplete issues on the roadmap.
For jump-to-definiton, how are you invoking the action? I tested this and found ^ + click (⌘ + click for macOS) works but other methods (e.g. ^ + B, Navigate->Declaration or Usages, via Right Click menu, etc) don't work and return an error popup with Cannot find declaration to go to. I'm thinking this may be a quirk with the lsp4intellij framework used by the plugin. They only mention the use of ^ + click in their README for navigating to definition.
If ^ + click doesn't work for you (or stdlib autocomplete isn't working), I'd be interested in your Timeouts view for the language server (green/red dot in bottom left):

I'm using MacOS and does indeed works with ⌘ + click. That's great. This is functionality is already good enough to continue using the plugin.
Normally I use ⌘ + B for the same functionality, so I was surprised that it doesn't work. None of the actions in the Right Click menu works as well.
Thanks a lot! Even though it still doesn't work as I'm used to, it's enough for now to benefit from it. Closing the ticket, since the issue title doesn't seem to be correct.

For posterity, the lack of other methods for "Go To Definition" is a known issue for the framework: https://github.com/ballerina-platform/lsp4intellij/issues/183 . If there's a need, I could look into resolving that issue upstream.


Can't make Megillah 17

I try to make Megillah 17, but the file appears and then disappears without any error. Very strange! Note that Megillah 17 is a new perek.

This seemed to be a problem with iCloud and Monterey. I've seen this happen to other files. Reboot seems to fix it.


InputfieldOpeningHours: A value was not a valid time string so it was deleted

Hi @juergenweb
Firstly thanks for this plugin, its very helpful!
For some reason today I'm getting this error:
InputfieldOpeningHours: A value was not a valid time string so it was deleted
I've not made any changes to the times and they were fine yesterday. As far as I can see they're valid times.
Not sure what the problem is
Thanks

Hello ShadowMoses36
The times on your image are correct. Did you have entered an invalid time on Sunday or Holiday.  This is the code responsible for the message:
// 2) Set inputs as a string and check if it is in a valid time format(H:i) - otherwise get rid of them         $cleanedValues = [];         foreach ($timeInputs as $key=>$value) {             $value = strval($value);             if ($value) {                 //check if value has valid time format (fe 08:00)                 if (OpeningHours::isTimeValid($value)) {                     $cleanedValues[$key] = $value;                 } else {                     $cleanedValues[$key] = '';                     $this->error($this->_('A value was not a valid time string so it was deleted.'));                 }             } else {                 //empty value                 $cleanedValues[$key] = '';             }         }
So if there was an invalid time inside an inputfield, it will be deleted and not more visible. The input values above are all visible and therefore not responsible for this error message.
I dont know, where it comes from, but if your times are saved correctly please ignore this error message.
Best regards

@juergenweb thank you for the response, I will take a further look into the error this evening. It's a strange one, as it was okay the day before and I made a lot of edits to that page and others.
Perhaps it's conflicting with something else? I'll update you if I find a solution or the cause, for future reference.
Thank you


Blank output on chrome incognito

Hi,
ive been using the library successfully for the past few days.. but recently ive started using incognito mode on google chrome..
when i use incognito mode, the pdf shows fine for the first time output but if i repeat the process for other records, it shows a blank page.. no errors in inspect tool, no issues whatsoever but the window is blank..
on the other hand using simple browser mode never have this issue
can anyone please confirm if this is common or is it just me? and how to solve it?
my output code is:
$filename = 'invoice-' . $orderId . '.pdf';
file_put_contents('downloads/' . $filename, $pdf->Output('S'));
return $filename;

Hey @mpixelz, I have never experienced this issue. However, it doesn't sound like a problem with FPDF, and instead, an issue with caching or how you handle your response.

@crabbly
thanks for getting back to me on this..
as i mentioned above this is how output of the pdf is done.. it saves the file and then open it on a new window.
would you rather recommend some other method?
i want to be able to save the pdf and then open on new window. (it works for the first one and then nothing - probably it is about cache but not sure.)

Try setting up your HTTP response headers before sending the file out.
https://laravel.com/docs/5.8/responses#file-responses

Closing this since it looks like the issue is not directly related to this lib. Feel free to reopen if necessary.


How do i implement conditional rendering in Nextjs using Shadcn form component?

I'm using Nextjs 13(typescript, tailwind css) I'm implementing a form in which I have shadcn select component with 3 options A, B, and C. I want to render different formfield for each option.
Conditons:

Code:
# IMPORTS

"use client"

import Link from "next/link"
import { zodResolver } from "@hookform/resolvers/zod"
import { useFieldArray, useForm } from "react-hook-form"
import * as z from "zod"

import { cn } from "@/lib/utils"
import { Button } from "@/registry/new-york/ui/button"
import {
  Form,
  FormControl,
  FormDescription,
  FormField,
  FormItem,
  FormLabel,
  FormMessage,
} from "@/registry/new-york/ui/form"
import { Input } from "@/registry/new-york/ui/input"
import {
  Select,
  SelectContent,
  SelectItem,
  SelectTrigger,
  SelectValue,
} from "@/registry/new-york/ui/select"
import { Textarea } from "@/registry/new-york/ui/textarea"
import { toast } from "@/registry/new-york/ui/use-toast"

# ZOD SCHEMA

const profileFormSchema = z.object({
  options: z
    .string({
      required_error: "Please select A or B or C.",
    })
   ,

})

type ProfileFormValues = z.infer<typeof profileFormSchema>

# MAIN FUNCTION
export function ProfileForm() {
  const form = useForm<ProfileFormValues>({
    resolver: zodResolver(profileFormSchema),
    mode: "onChange",
  })

  function onSubmit(data: ProfileFormValues) {
    toast({
      title: "You submitted the following values:",
      description: (

          {JSON.stringify(data, null, 2)}

      ),
    })
  }

  return (

# Here--->

        <FormField
          control={form.control}
          name="options"
          render={({ field }) => (
            <FormItem>
              <FormLabel>OPTIONS</FormLabel>
              <Select onValueChange={field.onChange} defaultValue={field.value}>
                <FormControl>
                  <SelectTrigger>
                    <SelectValue placeholder="Select A or B or C" />
                  </SelectTrigger>
                </FormControl>
                <SelectContent>
                  <SelectItem value="A">A</SelectItem>
                  <SelectItem value="B">B</SelectItem>
                  <SelectItem value="C">C</SelectItem>
                </SelectContent>
              </Select>
            </FormItem>
          )}
        />
        <Button type="submit">submit</Button>
      </form>
    </Form>
  )
}

This doesn't seem like an issue with the library. Rather your implementation. Consider using a state to keep track of what is selected and conditionally render said component  ?

This doesn't seem like an issue with the library. Rather your implementation. Consider using a state to keep track of what is selected and conditionally render said component ?

I totally agree. This is definitly not an shadcn-ui related issue.
As the form is based on react-hook-form, you @Amith-AG  should get familiar with watch/useWatch and filter your datasets according to detected form field changs.
https://www.react-hook-form.com/api/useform/watch/
https://www.react-hook-form.com/api/usewatch/

Thank you so much for sharing, @kaiiiiiiiii . watch and useWatch are new concepts for me, and the documentation you provided was awesome and incredibly helpful. I'm new to React and still have a long way to go in my learning journey.


file open/save widget entry - support directories

Allow for the selection of directories, not just files. Probably a option for the file dialog

https://github.com/pothosware/pothos-gui/commit/e7ce59e92aed34ffb0a425259c04265ec394cdda


Deconz/Conbee and homebridge-hue on to different raspberrys

Is it possible to install deconz and hue on two different systems?

Sure, why not?

because i couldn't find a manuel where it's described. How can i configure it? Thanks for your help

See the README.


Fix "gravity" is read-only

Description

Fix "gravity" is read-only
Issue Ticket Number
Fixes [Issue #29 ]

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
[x] I have created an issue ticket for this PR
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change?
[x] I have performed a self-review of my own code
[x] I have run tests locally to ensure they all pass
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes needed to the documentation

hi @codingis4noobs2  thanks for the PR but this issue was already assigned to someone else inside https://github.com/colbyfayock/next-cloudinary/issues/29
they're already working on it in a separate PR https://github.com/colbyfayock/next-cloudinary/pull/31

@colbyfayock i know, but he hasn't submitted it yet that's why i made a pull request 🙏

hey @codingis4noobs2 change works, can you please add a quick test for this and we can get it moved in?
you'll need to create a new test file under next-cloudinary/tests/plugins/cropping.spec.js

@colbyfayock Sure, i'll give it a shot 😀

try using this as an example for writing a test https://github.com/colbyfayock/next-cloudinary/blob/main/next-cloudinary/tests/plugins/raw-transformations.spec.js
additionally note the filename convention

@colbyfayock pls have a look now!!

@colbyfayock ig there are no instructions for running this locally, if you could provide it, It would be great

check out the project
run yarn install at the root of the project
navigate into next-cloudinary
run yarn test

@colbyfayock ok thx 😀

It will work now :)

awesome 💪  thanks for the patience. i gtta update the contributing / working locally docs

thanks @codingis4noobs2 nice work
email me at<EMAIL_ADDRESS>where i'll send you a form to claim for free swag https://spacejelly.dev/hacktoberfest/

@all-contributors please add @codingis4noobs2 for code, test


Compact view feature Dev

same as #164

@zsviczian any chance you could have a look? This looks really useful for taking a quick look.


Add compatibility for older IE versions

We came across this error in our application while using the quill-paste-smart package inside an Outlook Add-In. Outlook still forces the use of Internet Explorer in some cases.
In some versions of IE, the clipboardData is attached to window, not to the event. This change checks for those cases. If the event has the right attribute, it will still proceed with the current implementation.

Hi @kevin-hendel,
Thank you for the contribution. Though I'm not a fan of IE nor of Outlook, I still think it's a good idea to have a reasonable broad support (at least for Outlook).
One thing I've noticed, You're getting the plain text value by text = window.clipboardData.getData('Text');, but not the html?
Is there no equivalent to e.clipboardData.getData('text/html'); ?

Hi @Artem-Schander,
Thank you for the quick reply. I neither am a fan of IE as it requires workarounds like this one...
The clipboardData-API of IE only supports plain text. The implementation just makes sure the plugin is not breaking when used with cross-browser applications. It skips the main part of your plugin, but at least it prevents the Null Pointer Exception when event.clipboardData is null and trying to access getData of it.
It skips the smart part of the plugin and falls back to pasting the plain text.

I see.
I'll merge your PR and craft a patch release today evening.

Thanks again. Your changes are published. v.1.4.8

Thank you for the quick response and the release. It was a pleasure


Possible rename to autodiscovery

Isn't this guesser name a bit weird?
/cc @ddeboer

At least for the package. HttpAdapterGuesser could be HttpAdapterFactory, but MessageFactoryFactory sounds weird again.
php-http/autodiscovery for package name?


QUESTION: Block previous dates in datepicker element

Is there currently a way for us to block out previous dates in the datepicker block element?
I searched the documentation but only found the "initial date" argument, which doesn't block out the previous dates.
I did find this after a few google searches, so it looks like it is possible, but not fully available? Wondering if that is still the case
https://github.com/slackapi/java-slack-sdk/issues/1045

I have submitted this feature request internally!


Fix editor lock (again)

Checklist

[x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[x] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
[x] The description lists all applicable issues this PR seeks to resolve
[na] The description lists any configuration setting(s) that differ from the default settings
[ ] All tests and CI builds passing

Description
Requires https://github.com/ibi-group/datatools-server/pull/477
Fix #175, Fix #179
Redo of #815. This PR improves the editor locking feature as follows, in both Chrome and Firefox:

Clicking "Re-lock feed" immediately enables the GTFS editor without the need to reload the page (one fewer click than before).
Reloading an active editor tab/window no longer triggers the re-lock notice.
The re-lock notice appears immediately after switching focus to a tab that doesn’t own the editor lock.

Other behavior that #815 broke and I hope have handled this time:

Starting the GTFS editor after loading the first zip/feed version should work as usual (e2e tests for initially loading the editor should pass).
Using “back to feed” or “home” in the GTFS editor should not trigger the "Relock feed" prompt in the feed version manager, even if the lock was "stolen" by another editor.
Closing the “relock feed” modal then clicking “relock feed” later (e.g. by reactivating the affected browser tab) should work correctly.

Closing in favor of #824 (branch conflict).


Documentation source request

Is it possible to release the source of the documentation page under a folder or a separate repository? Some sections and functions need update, also for correcting typos. It may be deployed as github pages or as a read the docs page
@hodeware (or whoever is maintaining this repo)

https://github.com/jspreadsheet/ce-docs

We are working to improve that. But this is currently how the docs are contructed.

Thank you @hodeware


Kubernetes Deployment

My main use-case for this is to run this proxy on Kubernetes for our Logstash instances before they hit the ip-api api's. I am going to be creating a helm chart for the deployment of this with the Container that can now be built. Generally, within the helm community a helm chart lives in the repo of the code example: https://github.com/kubernetes/ingress-nginx/tree/master/charts/ingress-nginx
This would mean however that we would have to host the tar bundled charts someway so that people could use them.
Would this helm chart be something that you would like to have within this repo? I am more than happy to help maintain the chart.

I've created https://github.com/ChiefAlexander/ip-api-proxy-helm as a placeholder for this helm chart.


(#247) support basic rego file handling

yeah, no tests here though so will merge and get some manual tests done.


Coq backend: support tuple field projection

The following piece of code:
fn test(x: (u8, u8)) -> u8 {
    x.1
}

does not extract with the Coq backend.
The error is: [expr] node app global vcar projector tuple.

Should be fixed in #160 .

@cmester0 does this get fixed with #987 ?


Implement frame fragmentation

Is this to implement more sensible message sizes in FramedWriter? Currently there is no splitting, and it fails above Integer.MAX_VALUE which matches protocol.md. We already recompose in FramedReader.

I believe the intent here is frame fragmentation at the ReactiveSocket level, above any transport DuplexConnection fragmentation.  Because http/2 and tcp can break a large serialized frame into smaller payloads, we are currently not forced to fragment anything less than 2GB.
But really we want fragmentation to support two other cases

not needing to hold an IOBuf with gigs of data while reading off the network.
being able to to interleave streams with smaller data sizes and avoid head of line blocking.

Frame fragmentation feature is already added.


Should be inserted as a hint. Could Potentially be mistaken as an error.

This string is wrong in case if variables are used in there.
Had to add an "$", so it should be:
using (HttpResponseMessage response = client.GetAsync(
$"https://dev.azure.com/{organization}/{project}/_apis/build/builds?api-version=5.0").Result)
when using variables. Note the "$" introduced at the beginning of the string.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2bfea574-db69-a5fd-37fe-64ecfdac502a
Version Independent ID: 4037d475-f194-2ac9-ffd6-70530fc3140a
Content: Authenticate with personal access tokens - Azure DevOps
Content Source: docs/organizations/accounts/use-personal-access-tokens-to-authenticate.md
Product: devops
Technology: devops-security
GitHub Login: @chcomley
Microsoft Alias: chcomley

Hi @holbizmetrics, Thanks for your input. I'm updating the article today.


⚠ Fortnite has degraded performance

In b399fb2, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1594 ms

Resolved: Fortnite performance has improved in 34607db.


Heat load chart breaks if you update geothermal number of units

In this scenario

Changing the NoU in the heat source list and clicking 'save and view LES' makes the model break.

This appears to be because the list of must-run profiles doesn't get populated and is already fixed on beta. I've corrected the profile for this LES, but it will break again if further edits are made.
I suggest a deploy in the new year as it's been some time since we pushed changes to production.

I suggest a deploy in the new year as it's been some time since we pushed changes to production.

I agree. But because our external client would like to work on his LESses, could we cherry-pick this fix to production perhaps?

But because our external client would like to work on his LESses, could we cherry-pick this fix to production perhaps?

@grdw and myself did this already.


Blueprints Type of List inside Type of List (Not Working)

I thought i would add this to Issues, as either a future enhancement or a bug fix.
I am trying to add a List type inside a List type
testimonials:
  type: section
  underline: true
  title: Testimonials
  fields:
    header.testimonial:
      type: list
      label: Testimonial
      name: testimonials
      fields:
        .title:
          type: text
          name: title2
          label: Name
        .content:
          type: textarea
          name: testimonial
          label: Testimonial
        .soundbite:
          type: list
          label: Soundbite
          name: soundbite
            .item:
              type: text
              name: soundbiteItem
              label: Soundbite

Thanks,
Shawn

This is something we are working on already :)

It works but has issues thanks to garv-admin js that does the adding. please fix this

Working on it

Will be possible in Admin 1.1


Create Python frozen requirements file

We need to create Python frozen requirements file: this may need a specific convention as a requirements file is not your typical lockfile-only format. We likely want to use using pip freeze.

For info, the lockfile is named requirements.depslock

As suggested by @pombredanne, use pip inspect instead of pip freeze. https://github.com/nexB/dependency-inspector/pull/25

pip freeze does not include the relationship between dependencies. Instead, use pip inspect to get the JSON report of the Python environment, which includes the dependency relationships, and store it in the pip-inspect.deplock file.


Support Landscape orientation for Assurance screens

Actual Behaviour
Assurance 3.x UI currently switches to portrait mode irrespective of the current orientation and then switches back to the original orientation of the host app.  This was done because majority of the usage is in portrait mode and designing the UI to be adaptive for both portrait and landscape modes did not align with 3.x release.
Expected Behaviour
Display the Assurance screens in the host screen orientation.
Steps to Reproduce
Switch to landscape mode on a device and launch Assurance. Notice that the Assurance screen orientation is in portrait mode.
Platform and Version
Assurance 3.x, all devices.
Logs taken while reproducing problem
N/A

cc : @emdobrin


fix(e2e): Run each test in test suite in different namespace

All test cases in subscription suite shares the same test namespace.
In some cases, the resource cleanup which doesn't work properly from
previous test causes failure on subsequent test.
This commit will create new namespace for each test so it can be run
in insolation.
Signed-off-by: Vu Dinh<EMAIL_ADDRESS>
Description of the change:
Motivation for the change:
Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Docs updated or added to /doc
[ ] Commit messages sensible and descriptive

It looks like this PR is fairly out-of-date at this point, and has a couple of conflicts that need to be resolved, so I'm going to close this out in the meantime. The overall test pollution is still an issue, but it's been watered down recently by breaking down the overall e2e suite into individual clusters that are responsible for running a set of jobs, and filtering out common flaky e2e tests into their own workflow.


Not is compability with androidx

...\VideoPlayerPlugin.java:10: error: package android.support.annotation does not exist
No can build project with this error.
My project uses sdk 29 and with androidx on.

Yeah this is a common issue. Afaik the author of this package doesn't support this package anymore. But there is a fork which does. He you go: https://github.com/mertcankirtay/videoPlayerWithHeader

FYI here is how you add the fork mentioned by @Letalus to your pubspec.yaml
video_player_header:
(space) git:
(spacex2) url: git://github.com/mertcankirtay/videoPlayerWithHeader.git


openttd fails to build on 10.11.2

==> ./configure --prefix-dir=/usr/local/Cellar/openttd/1.5.1
==> make bundle
Last 15 lines from /Users/slava/Library/Logs/Homebrew/openttd/02.make:
[SRC] Compiling music/cocoa_m.cpp
[SRC] Compiling music/extmidi.cpp
[SRC] Compiling music/null_m.cpp
[SRC] Compiling music/qtmidi.cpp
[SRC] Compiling music_gui.cpp
/private/tmp/openttd20151219-1731-lbal8q/openttd-1.5.1/src/music/cocoa_m.cpp:76:4: error: no matching function for call to 'AUGraphNodeInfo'
                        AUGraphNodeInfo(graph, node, &desc, &unit);
                        ^~~~~~~~~~~~~~~
/System/Library/Frameworks/AudioToolbox.framework/Headers/AUGraph.h:179:1: note: candidate function not viable: no known conversion from 'ComponentDescription *' to 'AudioComponentDescription * _Nullable' (aka 'AudioComponentDescription *') for 3rd argument
AUGraphNodeInfo(        AUGraph                                                                 inGraph,
^
1 error generated.
make[1]: *** [music/cocoa_m.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 1

➜  ~  brew doctor
Your system is ready to brew.

same issue

Please read the troubleshooting guide, follow the steps there, and post the output of brew gist-logs openttd. Thanks!

Ping

latest version of openttd 1.5.3_1 works well for me now (but this time installation were using binary (?) files, without building from source)

whoever compiled it has 10.8SDK installed.  If you're on OS X El Capitan and want to build OpenTTD from source in anyway (as of July 31, 2016), you need to use 10.8 SDK.
go to https://developer.apple.com, sign in, download Xcode 5.1.1 DMG, mount it
copy the SDK: sudo cp -a /Volumes/Xcode/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk \   /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs
when building, include the 10.8 SDK path in CFLAGS:
./configure --enable-static --without-liblzo2 --without-osx-sysroot CFLAGS="-isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk" LDFLAGS="-stdlib=libstdc++"
You may be able to omit -enable-static, -without-liblzo2, etc. In addition you may be able to get away without stdlib=libstdc++ since i think thats on by default now
make
to test locally ./bin/openttd
enjoy

I think we need a better solution now that 10.12 is out and OpenTTD still won't build using XCode8.

@shatteringlass brew install openttd builds from source without any issue on my 10.12 machine. It has the latest Xcode 8.0 installed. If you still have a problem, please open a new issue following the steps in the troubleshooting guide. Thanks!


Change from CMAKE_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR on top-level cmake file to allow camke reference from client side

After changing from CMAKE_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR, client user could use add_subdirectory(azure-sdk-for-cpp) to reference the project.

/check-enforcer reset

@JasonYang-MSFT The CI is stuck.

/check-enforcer reset

/check-enforcer evaluate

/check-enforcer reset
/check-enforcer evaluate

/check-enforcer reset

/check-enforcer evaluate

@danieljurek , Can you help to check why check-enforcer stocked? Is their a configuration related to CMake files?

/azp run c - core - ci

@danieljurek Daniel Jurek FTE , Can you help to check why check-enforcer stocked? Is their a configuration related to CMake files?

Pipelines in the C++ repo are set up to run on a per-service basis. They're filtered by the service folder under sdk/<service> since the CMakeLists.txt file is not under one of those folders the pipelines did not kick off.
Since /CMakeLists.txt is part of the build system for all services I've opened a PR to expand triggers to explicitly include this path: https://github.com/Azure/azure-sdk-for-cpp/pull/314/files
The /azp run command I sent in a comment a few minutes ago also resulted in no builds. This is because /azp run also uses the same trigger criteria to evaluate whether a pipeline should run.

/check-enforcer reset

@damirault , This CI issue is still not addressed.
Your PR https://github.com/Azure/azure-sdk-for-cpp/pull/314 has added sdk/core/CMakeLists.txt and sdk/storage/CMakeLists.txt to CI. But the change is in root folder, /CMakeLists.txt.

/check-enforcer reset

/azp run c -core - ci

/azp run

/check-enforcer reset

/check-enforcer evaluate

/check-enforcer reset

/azp run

@danieljurek @Azure/azure-sdk-eng Can eng sys team review and merge this pr?

This change looks good to me. Changes to the cmake build system are best judged by the SDK team: @RickWinter -- any objections to this cmake change?

@gilbertw Can  you approve and merge this PR?


[BUG] Instaloader no longer works after a few pictures

Describe the bug
Instaloader no longer works after a few pictures. You can restore your account via the Challange, but that does not solve the problem. Unfortunately, this pretty much breaks the application.
To Reproduce
import instaloader

L = instaloader.Instaloader()
L.login(username,pwd)
profile = instaloader.Profile.from_username(L.context, username)
for post in profile.get_posts():
   L.post(post, target=profile.username)

Expected behavior
Instaloader downloads all things as planned
Error messages and tracebacks
Traceback (most recent call last):
  File "C:\Nextcloud\code\insta.py", line 79, in <module>
    insta_user_download(L=instag(), username="xxx")
  File "C:\Nextcloud\code\insta.py", line 50, in insta_user_download
    L = instag()
        ^^^^^^^^
  File "C:\Nextcloud\code\insta.py", line 28, in instag
    L.login(get_insta_user()[0], get_insta_user()[1])
  File "C:\Users\xxx\AppData\Local\Programs\Python\Python311\Lib\site-packages\instaloader\instaloader.py", line 634, in login
    self.context.login(user, passwd)
  File "C:\Users\xxx\AppData\Local\Programs\Python\Python311\Lib\site-packages\instaloader\instaloadercontext.py", line 239, in login
    raise ConnectionException("Login: Checkpoint required. Point your browser to "
instaloader.exceptions.ConnectionException: Login: Checkpoint required. Point your browser to https://www.instagram.com/challenge/action/AXGm...d2dF/ - follow the instructions, then retry.

Instaloader version
Version: 4.9.5
Additional context
Add any other context about the problem here.

The given Python code does what it is supposed to do. The problem is more with the app itself. Username and password are correct and belong to a normal account.

Looks like duplicate of #1787.

Looks like duplicate of #1787.

Actually, it doesn't seem to be a duplicate of the issue you flagged.
Even if it is a duplicate, it is a pity that there is no attempt to solve an old problem :'(

@Showmaster3000
Apparently the script works much better if you don't log in. However, I do not know why.
import instaloader

# Create an instance of Instaloader
L = instaloader.Instaloader()

# Define the username of the public profile
username = "example_username"

# Download the public profile
profile = instaloader.Profile.from_username(L.context, username)

# Iterate through all the posts in the profile
for post in profile.get_posts():
    # Download the picture or video
    L.download_post(post, profile)

# Close the Instaloader session
L.context.session.close()

Redirected to login page. Use --login.```

Redirected to login page. Use --login.

The message is clear: you have to login to proceed. Anonymous access is very limited, usually the first 12 posts, but often less.

As this and other issues show us, doing the Challanges doesn't help one bit. It is clear what it says, but it would be better if it said something that would solve the problem.
Since this issue is unlikely to be resolved, I will close it. Maybe the problem will be fixed in a patch at some point. Then you could refer to the issue.

can you please remove the login mechanism to download posts ? Anonymous access is very limited, can you increase more than 12 posts.. please


feat(retain): support retention of workflows.argoproj.io fields

Read the code comments for caveats.

Thanks
/lgtm


WIP: Feature/cms content

Related issues
https://github.com/DivanteLtd/vue-storefront/issues/1987
https://github.com/DivanteLtd/vue-storefront/issues/1894
Short description and why it's useful
This PR adds functionality for using CMS content from Elasticsearch with supporting SSR
It uses dynamic routes for CMS pages
For CMS block usage example please check demo page Vue file
src/themes/default/pages/CmsBlockDemoPageSsr.vue
Data structure
For CMS pages uses elasticsearch index entity type 'cms_page':
`id`
`title`
`meta_keywords`
`meta_description`
`identifier`
`content_heading`
`content`
`creation_time`
`update_time`
`active`

For CMS blocks uses elasticsearch index entity type 'cms_block':
`id`
`title`
`identifier`
`content`
`creation_time`
`update_time`

Announcement
Later will be provided functionality for page hierarchy
Magento support
Data migration tools for Magento 1 and Magento 2 will be updated accordingly very soon with correspond PRs

@pkarw  I hope to finish all changes today

@yuriboyko  - perfect! Thanks

@yuriboyko can you please let us know when its ready ?

@filrak
At this moment all possible changes are done and commited.
As i mentioned before regarding moving queries to module level it will be separate PR
Regarding using SSR for blocks and do not using preload i already talked to Piotr
and i think for now would be better to not use SSR for blocks, as to use it we need to preload all blocks to solve issues with not accessible props, but unfortunately it is also not possible to read cachestorage on the asyncData level. This means even if we would use SSR with load all blocks and saving them to cachestorage next time with page load there will be not way to verify if blocks are loaded to cachestorage (as cachestoarge  not acessible) so blocks loads will happen again which is not good. So for now i suggest to not change anything and then if we find some other solution for blocks SSR it will be another PR.
So for now i think current state is ready for approve PR to have this CMS functionality. if you see some other issues let  me know

@pkarw if everything is fine from your side can you approve ?


Tag helpers generating invalid markup.

Consider the following:
  <link asp-fallback-href="~/vendor/lightbox2/css/lightbox.min.css"
  asp-fallback-test-class="lightbox"
  asp-fallback-test-property="position"
  asp-fallback-test-value="absolute"
  href="https://cdnjs.cloudflare.com/ajax/libs/lightbox2/2.8.2/css/lightbox.min.css"
  rel="stylesheet" />

The following meta tag is generated by asp:
  <meta name="x-stylesheet-fallback-test" class="lightbox" />

If I try and validate this using the HTML5 validator I receive the following error:
Validator.nu (Public): Element “meta” is missing one or more of the following attributes: “content”, “property”.

Duplicate of https://github.com/aspnet/Mvc/issues/3449. This is fixed in RC2.


Module parse error when importing react/media-store in Nextjs (v11)

Attempting to load the react/media-store provider/hooks into a Next 11 app and getting a module parse error looks like it's trying to pull in typescript files?
../../node_modules/media-chrome/dist/react/media-store.tsx
Module parse failed: Unexpected token (2:12)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| import { createContext, useContext, useEffect, useMemo } from 'react';
> import type { Context, ReactNode } from 'react';
| import React from 'react';
| import { useSyncExternalStoreWithSelector } from './useSyncExternalStoreWithSelector';

Hey @rssfrncs thanks for checking out media store! I'll take a look and see if we can get a fix out asap.

Hey no problem i love the (redux-esque) design of it!

looks like an artifact somehow made it into our dist from an interim state<EMAIL_ADDRESS>running the build locally doesn't produce that. I'll have to do some digging into our ci/cd crud.
Your build env may yell at you, but just in case it doesn't, in the interim, can you try importing the non-tsx module directly, e.g.:
import { MediaProvider } from 'media-chrome/dist/react/media-store.js';

?

Aside - i wondered why you opted to export the MediaEvent types but not provide a typesafe way for the details property (and save having to refer back to the docsite)?
Either purely in typescript with a union like,
type MediaEvent = { type: 'mediaseekrequest'; details: number; } |  { type: 'mediatogglesubtitlesrequest'; details: boolean }

Or support js with event creators as in,
{
  MEDIA_SEEK_REQUEST: (details: number) => ({ type: 'mediaseekrequest', details }),
  // ...other events
}

// usage
dispatch(MediaActionTypes.MEDIA_SEEK_REQUEST(100);

With respect to the former option (full typescript event/action types), this is because of the pre-existing codebase that Media Store was extricated from. We're likely migrating the entire Media Chrome codebase over to TypeScript soon (currently we rely on JSDoc-declared types), so this will be much easier at that point.
With respect to the latter, it's really just because that "newer" approach to state updates can always be built on top of the "more primitive" implementation I went with. If enough folks want the "pre-canned methods" as part of the API for convenience, we can always add it.

media-chrome/dist/react/media-store.js'

I get a bit further but looks like the js file is attempting to import the ts version of the sync external store hook?
../../node_modules/media-chrome/dist/react/useSyncExternalStoreWithSelector.ts
Module parse failed: Unexpected token (25:21)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|  * https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is
|  */
> function isPolyfill(x: any, y: any) {
|   return (
|     (x === y && (x !== 0 || 1 / x === 1 / y)) || (x !== x && y !== y) // eslint-disable-line no-self-compare

whatever the root cause, we should probably try to fix it regardless. Have you tried with any of the more new-fangled nextjs versions?

Oh useSyncExternalStore is React 18+ right? This project is still on 17 so that will be an issue regardless. But it's still odd it is importing typescript files from dist i suppose?

re: useSyncExternalStore, yeah unfortunately we have a hard React v18+ dependency (though iirc you can upgrade to react 18 + next 11 and it should be fine?)
re: types crud - yeah if you take a look at the jsdelivr link I posted above, which is just the npm package version directory, you'll see that somehow our package dist ended up with some src artifacts in it. Since the imports don't specify an extension, different build tools will "default" to different modules. That's the crux of your pain, but it's based on something that should have never ended up in the package's dist in the first place.

ok kicked out a release (v3.2.2) that should fix it (🤞)! Whenever you get a chance, mind trying it out?

Will try it out tomorrow thanks! Any chance of supporting <17 with https://www.npmjs.com/package/use-sync-external-store?

That fixed the issues thanks. But using the standard custom elements for now as we are stuck on 17 atm.

@rssfrncs good to know. Given the dependency on useSyncExternalStore, it may be tricky to get backwards compatibility to React v17. When I get some spare cycles, I'll peep under the hood on the react side and on react-redux, just in case there are some fallback strategies that wouldn't require too much code or too much increase in complexity.

Yeah libraries have been using the official polyfill use-sync-external-store

Hey, sorry for reviving this old(-ish) issue, but I get a similar error when importing media-store (I'm using next v14.1.3 and React v18.2.0):

The weird thing is that this file that it seemingly can't find, is located right there on the disk 🤔

Would you have an idea of what's going on here? Thx!


Handle null ZNRecord in realtime segment manager

Handle null ZNRecords in realtime segment manager instead of
throwing NPE. Add documentation as to why this can happen and how it
is handled.

Current coverage is 64.33% (diff: 0.00%)

Merging #719 into master will decrease coverage by 0.07%

@@             master       #719   diff @@
==========================================
  Files           730        730
  Lines         34205      34213     +8
  Methods           0          0
  Messages          0          0
  Branches       5235       5238     +3
==========================================
- Hits          22030      22011    -19
- Misses        10624      10649    +25
- Partials       1551       1553     +2

Powered by Codecov. Last update f95bc35...3a56e3f


Design System > Compare all components with design link

Design System > Compare all components with design link
Staging : https://stage-react.raaghu.ai/
Design URL : https://www.figma.com/design/vziFLZAgMFi8wA5SlikLh5/Raaghu-Design-System?node-id=683-4188&node-type=canvas&t=kBvYc2evQCf2arjG-0

this task is completed in last month bugs are added in GitHub


Test (and fix) memory leaks with logger

The logger seems to be running out of memory

Make tests to make sure this doesn't happen again.
Work in progress

Are you sure this is occuring in your logging code? If you're using Nim 2.0, then you should know that Jester's underlying server (httpbeast) hasn't been updated for it and leaks memory under ORC (Nim's new memory management system). You would need to use jesterfork that uses httpbeastfork in order for it to work properly. I think Jester/Httpbeast's developer has sort of given up on Nim, he isn't very active with it anymore. I'd recommend you to check out prologue as well.


Save some preferences in LocalStorage

It would be cool to have some preferences saving into LocalStorage, so regular users don't need to keep applying their setup. Maybe:

Base currency
Coins to show

am trying to work on this but i am in the of CMC aoi key


⚠ Bofrost.lu has degraded performance

In dc9571a, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1146 ms

Resolved: Bofrost.lu performance has improved in 81ca14b after 6 minutes.


Missing part in supervised learning

Hi, in the Adaptive boosting part, there is a statement Known as Adaboost.
However, this statement is missing from the translation file.

Thanks for your message and for seeing this. Could you please add this statement at the very end of the translation file and fill it as well? Thanks!

@shervinea Sure, Because I am working on the zh-tw translation, I will add it to the file and reference back here.


Update resource-limits-vcore-single-databases.md

Max log size (GB) is incorrect int tables for Standard-series (Gen5), provisioned and serverless (All with max available Data size)  BusinessCritical Edition with BC_Gen5 sku and
GeneralPurpose Edition with GP_Gen5 sku
8 vCores 614.4 GB LOG SPACE ALLOCATED
10 vCores 614.4 GB LOG SPACE ALLOCATED
12 vCores 1 TB LOG SPACE ALLOCATED
14 vCores 1 TB LOG SPACE ALLOCATED
16 vCores 1 TB LOG SPACE ALLOCATED
...
80 vCores 1 TB LOG SPACE ALLOCATED
Cheers,
Zoran Barac

Learn Build status updates of commit bbd8342:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azure-sql/database/resource-limits-vcore-single-databases.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@baraczof thank you for reporting incorrect maximum log size in documentation. This will be fixed shortly.
Note that for databases with the maximum data size is 3072 GB, maximum log size is 922 GB (30% of maximum data size as mentioned here), rather than 1 TB.

@dimitri-furman - let us know if you'd like to move forward with this PR or if it should be closed.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Thanks @dimitri-furman
Yes, you are absolutely right for max data size 3072GB is 922GB for log. So only 8 and 10 vCores should be corrected to 614. I was doing some testing on 8 and 10 vCores when I noticed this.
I trusted Azure Portal for the rest of the sizes without checking sys.database_files.

Cheers,
Zoran

A different PR will fix this.
#please-close


Add finance to planning.budget and update doc and changelog

I didn't find any relevant section in the 2014/24/EU directive. The funding is mentioned in the annexes related to the information to include in forms.

See also https://github.com/open-contracting-extensions/european-union/issues/67


Verify Page Query Parameter is a number

In the below code, verify that the 'prov' or provided value, is in fact a valid number, returning either as a string or integer.
Then feel free to remove the 'TODO'
https://github.com/confused-Techie/atom-community-server-backend-JS/blob/156ed2c85aed5f73717d945425a39a0357c9a606/src/query.js#L9-L21

On my website I would generally use parseInt.
But this kind of javascript is very new to me, I don't even know if methods of the browsers window object are available, neither I know a way to test it.
If prov is not undefined, I'd parse it with parseInt and if the result is not NaN, I return the number.
function page(req) {
  let def = 1;
  let prov = req.query.page;

  if (prov === undefined) {
    return def;
  }

  let num = parseInt(prov, 10);

  return (isNaN(num)) ? def : num;
}

If parseInt is not an option, we could cast the value in a string and use a regex match to make sure it's a number.
Something like
function page(req) {
  let def = 1;

  if (req.query.page === undefined) {
    return def;
  }

  let prov = `${req.query.page}`;

  return (prov.match(/^\d+$/) !== null) ? prov : def;
}

If we are sure the parameter is string or undefined, the cast is even unneded.
Some questions. Why "undefined"? I just use undefined, it's a primitive type in javascript, don't need to wrap in a string.
Why let is not used for local variables?

We had a misunderstanding. typeof on an undefined variable/property returns a string which its content is "undefined".
But it's not needed to use typeof, you can directly check against undefined.


Change order of animations?

Very cool tool, nice work!
I would find this much more powerful if it was possible to change the order of animations. Currently it is based on the order of created objects in excalidraw - but if manual re-ordering of objects was possible it would be easy to create "visual tutorials" using excalidraw and I would love this.

Thanks for the feedback.
What you can do now is to change the layer in the excalidraw app.
I know it's not very handy, but it may work in a small use case.

As I wrote in the other issue, this tool is not going to be an authoring tool.
For such purpose, we would like to extend excalidraw-claymate.
Changing the order of animations can be done with changing the order (layer) in Excalidraw. So, let me close this.
I know it's very hard with complex objects.
My another experimental tool to visualize layers is excalidraw-layers.


Broken since new release (3.6.1-1) when using dtale

Description
The server gives an error when a connection to dtale is not possible and shuts down the server completely. In the earlier version it just filed a javascript error, but I was able to work with the files. Now if I open a notebook that had a dtale connection open in a previous run I just get a connection error and cannot work with my files.

Reproduce

Start jlab
Install Dtale and numpy
Create a notebook and start a dtale connection:

import numpy as np
import dtale
test = np.random.rand(16,200)
dtale.show(test)

Save and close
Start jlab again and open file

Expected behavior
It should show an error message (as in previous builds), but should not completly dissallow further usage with the fullscreen error.
Context

Operating System and version: Manjaro-Linux Kernel 5.15.89-1
JupyterLab-Desktop version: 3.6.1-1
Installer: AUR jupyterlab-desktop-bin (uses the .deb file)

The important part from the log:

[2023-02-13 09:57:11.101] [warn]  Unsatisfied version 6.0.1 of shared singleton module @jupyter-widgets/base (required ^2.0.0 || ^3.0.0 || ^4.0.0)
[2023-02-13 09:57:12.491] [verbose] Starting application in workspace: "default"
[2023-02-13 09:57:14.795] [error] (node:10843) electron: Failed to load URL: http://linuxtowerdom:40000/dtale/iframe/2 with error: ERR_CONNECTION_REFUSED
(Use `jlab --trace-warnings ...` to show where the warning was created)
[2023-02-13 09:57:14.832] [error] (node:10843) electron: Failed to load URL: http://linuxtowerdom:40001/dtale/iframe/6 with error: ERR_CONNECTION_REFUSED

@Schmetzler thanks for reporting this. dtale is creating an iframe and that is failing to load the next time the notebook is opened. app is not handling this case properly, we will fix it.

I have the same issue with the new release using snakeviz.


Curl 404 error downloading lamda.zip artifact

Describe the Bug
From yesterday, we are getting this error:
Error: failed to execute "curl": curl: (22) The requested URL returned error: 404

  on .terraform/modules/lambda-elasticsearch-logs-cleanup.artifact/main.tf line 1, in data "external" "curl":
   1: data "external" "curl" {

If we enable TF_LOG=DEBUG we can see this:
2021/11/17 12:00:29 [DEBUG] ReferenceTransformer: "module.lambda-elasticsearch-logs-cleanup[0].module.artifact.data.template_file.url[0]" references: []
2021/11/17 12:00:29 [WARN] Provider "registry.terraform.io/hashicorp/template" produced an unexpected new value for module.lambda-elasticsearch-logs-cleanup[0].module.artifact.data.template_file.url[0].
      - .rendered: was cty.StringVal("https://artifacts.cloudposse.com/terraform-aws-lambda-elasticsearch-cleanup/20f9b1fd94e4b5f808d9ed51fec5a60094fce49b/lambda.zip"), but now cty.StringVal("https://artifacts.cloudposse.com/terraform-aws-lambda-elasticsearch-cleanup/5b2d34b7a97d386cdf76691b5952c30b31c9a39e/lambda.zip")
      - .id: was cty.StringVal("ab6aa662215a10b692c7a657849e815b43d07d9fdc0324927c75004323d96e7e"), but now cty.StringVal("22dd58a23ba0d8516e44975edf035e16fd8eb7876b81977de63fc182e4b42de1")

This URL:
https://artifacts.cloudposse.com/terraform-aws-lambda-elasticsearch-cleanup/5b2d34b7a97d386cdf76691b5952c30b31c9a39e/lambda.zip

returns 404.
We are using 0.12.3 module version. We tried to upgrade to the last recent release (0.12.4) but we are getting the same error.
Steps to Reproduce
Simply run a terraform plan
Environment (please complete the following information):

Terraform 0.14.10
Module version 0.12.3 and 0.12.4

Additional Context
This problem started just yesterday. Maybe some thing is broken with the latest release?

We've found a workaround.
Instead of pinning the module version using:
version = "~> 0.12.3"
We've pinned the exact version:
version = "0.12.3"
Now ti works.


support array_distinct

What type of PR is this：

[ ] bug
[x] feature
[ ] enhancement
[ ] others

Which issues of this PR fixes ：

for #648
Problem Summary(Required) ：

usage
mysql> select * from m5;
+------+---------------+
| c1   | c2            |
+------+---------------+
|    1 | [1,1,2]       |
|    2 | [1,null,null] |
|    3 | NULL          |
|    4 | [null]        |
+------+---------------+
4 rows in set (0.01 sec)

mysql> select c1, array_distinct(c2) from m5;
+------+----------------------+
| c1   | array_distinct(`c2`) |
+------+----------------------+
|    1 | [2,1]                |
|    2 | [null,1]             |
|    3 | NULL                 |
|    4 | [null]               |
+------+----------------------+
4 rows in set (0.01 sec)

Some implement have performance problems, ignore them first, and optimize them later

Please add UT for array_distinct function.

Please add UT for array_distinct function.

has already add to: https://github.com/StarRocks/StarRocksTest/pull/111


Add Ranjithkumarns file

this pull request adds  Ranjithkumarns file to the _posts folder.

this pull request adds Ranjithkumarns file to the _posts folder.


[Feature] make openfaas as an addon

Is your feature request related to a problem? Please describe.
There's a repo for making an addon : https://github.com/openfaas/faas
Describe the solution you'd like
make some demos of components, such as function in golang, function in java, function in python, function in node.js, function in javascript, and so on.

/assign


[Feature]: Request for adding the feature of customizing the MAC address of the virtual machine

Is your proposal related to a problem?
Unable to customize the MAC address of Windows
Describe the solution you'd like.
Add the feature  of customizing the mac address of windows
Describe alternatives you've considered.
I used the function of customizing the MAC address in docker-compose and found that the fixed one is the MAC address of the container, not the virtual address of Windows.
Additional context
No response

Thank you so much! It works!


Test loading large number of keys from AWS secrets manager

Test Web3Signer with large number keys to see if there are any performance issues.
Tasks

Create 10,000 keys in AWS secrets manager
Time how long it takes for Web3Signer to load all the keys
Monitor resource usage as it is loading the keys i.e. CPU, memory, threads

Closing due to opened in incorrect project


Nick: Watch inkedshop.com

Nick requests the watch of the watch_keyword inkedshop\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

inkedshop\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Consensus plugin interface should follow the Actor model

After discussions with @jeffgarratt and @corecode, it has become apparent that the current consensus consensus.Consenter interface is interfering with the Actor model with which the rest of the fabric was designed.
In particular, the RecvMessage is intuitively implemented as an execution entrypoint, in which, the consensus plugin analyzes the message and takes appropriate action.  This implementation has a two-fold problem.  First, RecvMessage is not guaranteed to be called non-concurrently, and so some sort of locking scheme must usually be introduced.  Secondly, consuming the message thread for analysis and action stalls other messages from that same handler from being processed.  This is described in issue #919 .  It is not necessarily intuitive that an execution path derived from the go routine servicing a request from peer 'vp1' will deadlock if it decides to wait for a block to be retrieved from 'vp1'.
Issue #919 implements a simple modification to prevent the deadlock scenario described above, but does not complete the transition to an Actor model.  To transition to an Actor model, the consensus API should be modified such that the consenter is receiving messages from a channel on its own thread or threads, rather than relying on a thread provided to it from the outside.
For the obcpbft consensus plugin, this API change should clean up many aspects of the code which currently attempt to work around the inflexibility of the previous API.  One of the more egregious examples is the view change timer operation.  Presently, when the view change timer expires, it must first attempt to acquire a lock on the PBFT state before executing.  It is possible however, that a message arrives or is currently being processed which already has this lock.  In this case, that message processing may reset the view change timer as progress is being made.  To work around this issue, a lock count and reset count is kept, so that the view timer can determine whether its expiration was 'canceled' before it could acquire the lock.  This convoluted logic can be entirely removed by simply adding the timer into the main select, and can additionally remove the view change go routine.
A more detailed description of the new consenter API will follow, but creating this issue now for tracking purposes.

This is behind #919 and may overlap in implementation.

This can be considered implemented with #1325


feat(config): support TLS options

What this PR does / why we need it:
Support TLS options
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @your-reviewer

Release note:

NONE

/assign @zjj2wry

/lgtm

/approve


Incorrect error message  when calling main from inside main

At 0deff82fdbb595cf4fbe0c46c1ea5600a95e3b60
class CallToMainClass {
    public static void main(String[] args) {
        main(null);
    }
}

error: non-static method 'main' cannot be referenced from a static context
   |
 3 |         main(null);
   |         ^^^^

error: cannot call static method 'main'
   |
 3 |         main(null);
   |         ^^^^

Compilation aborted due to 2 errors

The first error is incorrect because main is in fact static.
A fix should turn above code into a regression test (CLI) and include ref #106 in the commit message

fixed in #240


Registering Service Worker causes NO INTERNET chrome page on default install

Describe the bug
Run a brand new create react app project and register a service worker. Build your app using yarn build and serve it using serve -s build. Open a new chrome tab in incognito mode. While the page will serve normally for the first 10 seconds, when the service worker activates, the page suddenly breaks with an appear offline message.
Did you try recovering your dependencies?
This can be reproduced using a brand new project.
Which terms did you search for in User Guide?
None of the troubleshooting tips in https://create-react-app.dev/docs/troubleshooting/ are helpful.
Environment
node -v
v16.11.1
npx -v
6.14.8

Steps to reproduce
First install a fresh project
npx<EMAIL_ADDRESS>my-app --template cra-template-pwa-typescript
cd my-app
yarn install

then apply this patch
diff --git a/src/index.tsx b/src/index.tsx
index e459b13..4a7b0ba 100644
--- a/src/index.tsx
+++ b/src/index.tsx
@@ -15,7 +15,7 @@ ReactDOM.render(
 // If you want your app to work offline and load faster, you can change
 // unregister() to register() below. Note this comes with some pitfalls.
 // Learn more about service workers: https://cra.link/PWA
-serviceWorkerRegistration.unregister();
+serviceWorkerRegistration.register();

 // If you want to start measuring performance in your app, pass a function
 // to log results (for example: reportWebVitals(console.log))

And finally build and serve
yarn build
serve -s build

Actual behavior
Try to open an incognito page on Google Chrome (v97 or above). The page will load for a few seconds. If you refresh the page and show the inspector and go to the Application tab, it displays the dinosaur.

Expected behavior
It should display the create react app homepage

Reproducible demo
See steps to reproduce.

same here


searches failing with 500s on hosted chef

Chef Server Version
14.0.24
Platform Details
Hosted Chef
Configuration
Hosted Chef :)
Scenario:
Searches are failing for certain orgs, e.g.
knife search node "*:*"

Results in 500s on a Hosted Chef organization that has 18,000 nodes
Steps to Reproduce:
Expected Result:
Successful results returned
Actual Result:
ERROR: Server returned error 500 for https://api.chef.io/organizations/ORGNAME/search/node?q=*:*&start=10000&rows=1000, retrying 1/5 in 4s

@joshbrand to add further detail

Some added context: the 500s appear to be coming from elasticsearch itself, the first few pages of results appear to succeed, it's only at this 10k+ mark that things begin to fail.

@joshbrand I believe 10,000 mark is the point at which ES stops allowing pagination

Is it possible we need to set https://www.elastic.co/guide/en/elasticsearch/reference/current/index-modules.html#index-max-result-window on ES in Hosted?

@stevendanna i think @joshbrand tried that in preprod already. we've seen that before in onprem deployments and usually it just limits the result set to 10k instead of erroring with 500, but maybe something's changed