Two form types with two different data classes

Hi,
I have a form type
class CategoryChooserForm extends AbstractType
{

    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder->add("businessCategory", ChoiceType::class,
            [
                'required' => true,
                'choices' => [
                    'Cat1' => null,
                    'Yes' => true,
                    'No' => false,
                ]
            ]);
    }

    public function configureOptions(OptionsResolver $resolver)
    {
        $resolver->setDefaults(['data_class' => CategoryChooserFormDataClass::class]);
    }
}

and
class BusinessNameForm extends AbstractType
{

    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder->add("businessName", TextType::class, ['required' => true])
            ->add("useName", CheckboxType::class, ['mapped' => false]);
    }

    /**
     * @param OptionsResolver $resolver
     * @throws \Symfony\Component\OptionsResolver\Exception\AccessException
     */

    public function configureOptions(OptionsResolver $resolver)
    {
        $resolver->setDefaults(['data_class' => BusinessNameFormDataClass::class]);
    }
}

Data Classes
class BusinessNameFormDataClass
{

    private $businessName;

    /**
     * @return mixed
     */
    public function getBusinessName()
    {
        return $this->businessName;
    }

    /**
     * @param mixed $businessName
     */
    public function setBusinessName($businessName)
    {
        $this->businessName = $businessName;
    }

}

and
class CategoryChooserFormDataClass
{

    private $businessCategory;

    /**
     * @return mixed
     */
    public function getBusinessCategory()
    {
        return $this->businessCategory;
    }

    /**
     * @param mixed $businessCategory
     */
    public function setBusinessCategory($businessCategory)
    {
        $this->businessCategory = $businessCategory;
    }

}

Flow class
class PostBusinessSignUpFlowService extends FormFlow
{

    protected function loadStepsConfig()
    {
        return [
            [
                'label' => 'Choose Category',
                'form_type' => CategoryChooserForm::class,
            ],
            [
                'label' => 'Business Name',
                'form_type' => BusinessNameForm::class,

            ],
        ];
    }

}

Controller

class PostSignUpWizardController extends Controller
{

    /**
     * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     * @throws \InvalidArgumentException
     * @throws \LogicException
     */
    public function wizardAction()
    {

        $flow = $this->get('business_main.service.sign_up_wizard'); // must match the flow's service id
        $formData = new CategoryChooserFormDataClass(); // Your form data class. Has to be an object, won't work properly with an array.

        $flow->bind($formData);

        // form of the current step
        $form = $flow->createForm();
        if ($flow->isValid($form)) {
            $flow->saveCurrentStepData($form);

            if ($flow->nextStep()) {
                // form for the next step
                $form = $flow->createForm();
            } else {
                // flow finished
                $em = $this->getDoctrine()->getManager();
                $em->persist($formData);
                $em->flush();

                $flow->reset(); // remove step data from the session

                return $this->redirect($this->generateUrl('home')); // redirect when done
            }
        }

        return<EMAIL_ADDRESS>[
            'form' => $form->createView(),
            'flow' => $flow,
        ]);
    }

}

Step 1 render goes fine
But upon pressing next , I get the error
The form's view data is expected to be an instance of class Business\MainBundle\Form\DataClass\BusinessNameFormDataClass, but is an instance of class Business\MainBundle\Form\DataClass\CategoryChooserFormDataClass. You can avoid this error by setting the "data_class" option to null or by adding a view transformer that transforms an instance of class Business\MainBundle\Form\DataClass\CategoryChooserFormDataClass to an instance of Business\MainBundle\Form\DataClass\BusinessNameFormDataClass.
So my question is how to configure flow/controller in order to make use of two forms with different data_class? Thanks

FYI... suggestion
Having the setFormData($formData) method in the FormFlow class solved the problem. I was able to create the form data of next step.

is there any solution for that? i have the same problem...

I think you should use one DTO and remove your 'data_class' keys.

@progzy is right. See #28.


[fix][client] Java Client's Seek Logic Not Threadsafe #1

Fixes #19671
Motivation
To resolve the thread-safety issue around Java client's seek logic identified by apache/pulsar#19671.
Modifications

Made ConsumerImpl immediately log, cancel future and then return if duringSeek flag is not false.

by canceling the seekFuture, the client ensures that the current operation does not interfere with the ongoing seek operation and avoids any errors or inconsistencies that might otherwise occur.

Verifying this change

[ ] Make sure that the change passes the CI checks.

I am not sure if my PR went through the intended CI checks...?
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/JooHyukKim/pulsar/pull/1

Could you add a test for your changes?

@JooHyukKim BTW, edit comment won't send notification, I suggest you create new comment when you'd like to notify reviewers.

I'd appreciate it if you can provide a timing diagram to prove the fix. You may refer to https://github.com/apache/curator/pull/430 as a typical description.

How to verify your changes?
You can set true for the duringSeek flag, and then call the seek method, you got a canceled future.

tool

Generally, I just write in text :D
It's about:

Define the actors.
Describe at T_N, what actor takes what action
The order of T_N
What actions cause race condition

But any tool you searched is acceptable as long as the diagram is clear (with text, reviewers manually dump to diagram).

@JooHyukKim Please fix style violation by yourself. You can use CI workflow in your personal fork to verify. Or the command should be:
mvn -B -T 8 -ntp initialize apache-rat:check license:check
mvn -B -T 8 -ntp initialize checkstyle:check

Ping me once CI passed in your personal fork.

personal fork is not running CI

Yes.
You may take https://github.com/lhotari/pulsar/pull/145 as an example. IIRC GitHub sometimes stuck on turning on Actions..I don't have too much suggestions here but I can follow the instructions in Actions tab to add a sample workflow and then GitHub turn on Actions.

Codecov Report

Merging #20242 (4075a39) into master (9841364) will decrease coverage by 0.02%.
The diff coverage is 51.42%.

@@             Coverage Diff              @@
##             master   #20242      +/-   ##
============================================
- Coverage     72.87%   72.86%   -0.02%
+ Complexity    31943     3601   -28342
============================================
  Files          1868     1868
  Lines        138594   138597       +3
  Branches      15246    15247       +1
============================================
- Hits         101003   100991      -12
- Misses        29547    29557      +10
- Partials       8044     8049       +5

Flag
Coverage Δ

inttests
24.21% <22.85%> (-0.05%)
:arrow_down:

systests
24.78% <20.00%> (-0.15%)
:arrow_down:

unittests
72.18% <51.42%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...va/org/apache/pulsar/client/impl/ConsumerImpl.java
76.40% <51.42%> (-0.03%)
:arrow_down:

... and 64 files with indirect coverage changes

Merging...
Thanks for your contribution!

Never mind. I can edit the commit message before merging :D

@tisonkun
For this patch, maybe you forget to set the milestone. and there are some modifications not related to the issue

@Technoboy- Thanks for setting up the milestone.

not related to the issue

Yep. I'm investigating some tools to unify whitespace so that we don't ask for aligning again and again.


Ensure AIX test machines are able to run X11 tests

Should be possible using Xvfb (Virtual X11 server) from the X11.vfb package, but we need to verify if it's available and working ("working" can be checked on a non-adoptopenjdk machine if needed) as @smlambert reminded me today that we apparently still have the x11 tests disabled.
Possibly a good one for @Haroon-Khel to look into as most people won't have a way of running stuff on AIX systems :-)
Related: https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/211 (macos) and an old general issue on the virtual display topic at https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/267

Both jdk_awt and jdk_swing tests require DISPLAY to be set.
jdk_awt tests are only running on x86 architectures (and not osx), though I see that jdk_swing tests are only disabled on osx, which means they are running weekly on AIX, and it seems there are issues, example: https://ci.adoptopenjdk.net/view/Test_openjdk_weekly/job/Test_openjdk11_hs_extended.openjdk_ppc64_aix/6/testReport/sanity_client_SwingSet_src_TabbedPaneDemoTest/java/TabbedPaneDemoTest/
I am going to presume that we need to do something different then we do currently.  Jenkins xvfb plugin likely is not working to setup the display on AIX, or at least we should try to run the plugin for that platform and see what happens, it currently is only invoked for linux x86 platform (https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/buildenv/jenkins/JenkinsfileBase#L395).

jdk_awt tests are only running on x86 architectures (and not osx

Hmmm to clarify - they aren't running on the other LInux architectures then (ppcle/ss390x/aarch64/armv7l)? Is that our choice?

Should be possible using Xvfb (Virtual X11 server) from the X11.vfb package, but we need to verify if it's available and working ("working" can be checked on a non-adoptopenjdk machine if needed)

Ive managed to run some X11 tests on an aix machine with X11.vfb installed. The tests passed, so this confirms that its available and working

@smlambert correct me if im wrong but, according to https://github.com/AdoptOpenJDK/openjdk-tests/blob/565191efde062aa5337befdd943611c75aff6d42/buildenv/jenkins/JenkinsfileBase#L566, It seems that for AIX machines, only if the BUILD_LIST includes jck will an xvfb server start and the DISPLAY variable be set. This needs to be changed to include for when the BUILD_LIST includes openjdk, as the jdk_awt and jdk_swing tests are part of that BUILD_LIST.
Am I on the right track here? If so, ill put in a pr to fix this

Yes, right track for sure.  Looks like we need to do some cleanup there...  https://github.com/AdoptOpenJDK/openjdk-tests/blob/565191efde062aa5337befdd943611c75aff6d42/buildenv/jenkins/JenkinsfileBase#L541-L576
Both openjdk and jck test groups contain tests that require DISPLAY to be set.  In fact, not clear to me why do not merely have an
if ((env.BUILD_LIST.contains('openjdk') || (env.BUILD_LIST.startsWith('jck')){...
or also thinking whether we should just set up the DISPLAY in all cases even if it will not be used (not sure of the overhead of this, doubt its much, and it would reduce complexity of the groovy script).

The overhead of starting up a virtual X server shouldn't be much at all - a few seconds at most. Assuming it would be started/stopped once per job (as opposed to for each individual test!) that might not be a problem. I'd only be concerned about whether we make it harder for anyone else running our test scripts to run the tests if they don't have the virtual server up - if it just fails the tests then I'd say that's perfectly acceptable :-)

Yes, that is the behaviour if no virtual server is up, tests fail (with error msg that says failed to set x11 display... or something similar).
@Haroon-Khel has a good start on a PR to address this, just need to debug the breakage of the linux story (which should be something fairly straight-forward).

Ive made some final changes on that pr. I kicked off grinders, running both jdk_awt and jdk_swing, on linux and aix. All tests run without any previously occuring DISPLAY error, which is great, depsite not all of the tests passing.
Grinders:
Linux: jdk_awt, jdk_swing
Aix: jdk_awt, jdk_swing
Are there any further tests that should be run?

Sounds good - feel free to close this :-)


Organization switch option is not available for the sub-org admins invited from the parent org when root org "view organizations" permission is assigned via groups

Describe the issue:
Organization switch option is only available in the root organization's console for the sub-org admins that are invited from parent org when root org "view organizations" permission is directly assigned to that user via a role. If the same role is assigned to a user via a group, the organization switch option is not available for that user in the root organization's console.
How to reproduce:

Create an admin role from the "Console Settings" section and assign 'Organization view' permission under 'Root Organization Permissions' to the role.
Create two users. Assign the above created role to one user via a group. Assign the role directly to the other user.
Create a sub organization and switch to it.
Go to 'Console Settings' in the sub-org and invite the above created 2 users as sub-org admins (Assign sub-org level admin access via a role accordingly). The two users will get email invitations to join the sub-org.
Accept the invitations.
Log in to the root org console using the credentials of the 2 users.

When logged in with the user who got organization view permission assigned via a group cannot see the organization switch option for the invited sub-org.
When logged in with the user who got organization view permission assigned directly via the role can see the organization switch option for the invited sub-org.

For the user who got assigned the 'organization view' permission directly by assigning the role

For the user who got assigned the 'organization view' permission indirectly via a group

Expected behavior:
Both the users should be able to switch to the sub-organization using the organization switch option in the root organization console.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: IS 7.0.0 RC5

This issue has been resolved, as both users can now switch to the sub-organization using the organization switch option in the root organization console.
However, in step 04 of reproducing the issue, the user assigned to the admin role via the group, cannot be directly invited to join as a sub-org level admin.
The following error is shown when invited:

Therefore, the following issue is opened: https://github.com/wso2/product-is/issues/20377


Additional Content-Type when capturing credentials

Hi,
I'm currently developing a phislet and the login request containing credentials uses Content-Type: text/plain instead of the regular application/x-www-form-urlencode.
I see the POST request in debug logs, but credentials aren't captured and linked to the user's session due to the MIME mismatch.
 If you need a service and you cant pay for it you beg for it all this blackmail wont help you.

**Hi 👽 ! If you are interested in ⚙Advanced Phishing⚙ and the ✨Evilginx3✨ tool then I offer you Google Gmail and Custom Phishlets with a ✅Free Tutorial✅ which arrives if the 📈Telegram reaches 50 Subscribers📈
⏳ GOOGLE GMAIL PHISHLET 2024 WITH PROOF ⏳
->
⛔https://www.youtube.com/watch?v=nA47UknIE6A⛔
🔓 Ask your questions and a free tutorial from 50 subs on telegram !!!
->
📩https://t.me/Noremorse1011📩**


Current page data is not available to plugins per documentation

From https://respondcms.com/documentation/creating-plugins :
CURRENT PAGE DATA
The following data is passed into the page array passed to your plugin. It contains information about the current page.
SETTING	DESCRIPTION
title	The title of the page.
description	The description of the page.
keywords	Keywords for the page.
...etc...
These settings are in fact not passed to the plugin.
It doesn't look like it would be too hard to fix this.  We'd simply have to add an additional $page parameter to the injectPluginHTML() function in Publish.php, and pass an appropriate object to it.

Fixed in master.


App tagline is displayed in English when the language is set to Hindi in Home

Summary:
Though we have tagline translation in Hindi which is well displayed in splash activity, it is being displayed in English in Home when the app language is set to Hindi.
Screenshots:

fixed


Introduce Custom Tileset Data Tags

Summary
Right now, there is no builtin way that allows users to specify additional data layers for a Tileset. It would be nice if there was a convenient was to specify data tags for groups of tiles.
Workaround

Users can already specify additional data in an array and index it using the tile index.
This, however, is not very usable.

Analysis

Add an additional TilesetEditorMode where any number of custom data layers can be specified.
Each layer, when selected, allows the user to specify a tag object in the Object Inspector.
For each layer, the tileset view allows to specify all the tiles that will be tagged.
The TilesetCompiler will generate one output layer for each input layer.
A Tileset should specify API for conveniently retrieving tags for a tile, or all tiles of a certain tag layer.
Note: It might be a good idea to specify that target API first in this case.

Tried adding such a property editor but how do I make it actually uses it? Just setting the type doesnt seem to do it.

I'm not in the right context to grasp the big picture of your questions right now, but I'll answer them individually hoping it helps:

Also I dont think I can get the object instance from the MemberInfo alone.

Yep, MemberInfo just describes a type member, not tied to any concrete instance. To get the (Remember: Multi selection!) object instances of a PropertyEditor, use this.GetValue() like here, here or here.

EDIT2: now it seems to be locked to readonly and setting that to false doesnt work??

PropertyEditors are generated recursively. The root editor has a Getter and Setter assigned that retrieve the grids selection directly, and each editor either allows to edit that value directly (primitives, colors, etc.) or generates child editors to edit specific subsets of that value (like properties, fields of an object), which are assigned an anonymous Getter and Setter to retrieve that specific value, or set it. Whenever a PropertyEditor doesn't have a Setter assigned, it is forced to be readonly - for example when there's a property without a setter implemented.
Take a look at how PropertyEditors construct child editors. For example, the GameObjectOverviewPropertyEditor generates the shared GameObject "header" editor, and a list of Component editors.


GET /v2/apps/{app_id}/tasks should return service ports too

From the documentation, it looks like the only way to get the service port associated with a given task is to use the text/plain response when querying /v2/apps/{app_id}/tasks:

At the very least, full port information should be returned in the application/json response.
Similar to #1609 and related to #670.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-3348. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


Package request: Nekoray

Project description
This is a QT GUI for using V2ray or Sing-box backend proxies, and it is very useful for circumventing internet censorship.
Metadata

homepage URL: https://github.com/MatsuriDayo/nekoray
source URL: https://github.com/MatsuriDayo/nekoray
license: GPL-3.0
platforms: Linux

dupe of #244451


Add/refine Robot Destruction Support

Honestly, the Robot Destruction UI seems functional enough given that the gamemode appears to have been temporarily abandoned.


Lockup when using fair unlocks.

I was benchmarking parking lot against my own crate and found a lock up bug  https://github.com/sstewartgallus/parkinglotbug
The benchmark uses parking lot to implement an event semaphore and then uses the event semaphore to implement a lock.
Run cargo bench to get a lockup.
My platform is a 2 core x86-64 Linux machine.

I'm getting a segfault instead of a lockup on that test.

OK, I've fixed the segfault and can see the lockup now.

Sorry that this took a while, I've been busy lately. It should be fixed now.

Thank you.


FIX Extensions inherited from parent classes should be retained when removing subclass extensions

The test added in this PR shows the bug is valid. From my testing I could see that by the time the delta config change is applied to the subclass to remove some extension, the inherited list of extensions including parent extensions has been merged and normalised on the class config. This means that when we only ask for the uninherited extensions in remove_extension() and set the new config array back again, we overwrite any parent extensions.
Fixes #8613

cc @silverstripe/core-team

Does this relate to #8465 / #8581 at all? i.e. is it a better fix for the underlying issue? Or are we just coincidentally addressing 2 extension bugs at the same time? ;-)
My main concern with this change is that it only works as intended if Config::modify() has been called prior to Object::remove_extension(). This is potentially the case in the entirety of the test system, but not the entirety of all SS runtimes.
The question is: is Config::modify() clear about whether it should be passed extra / inherited values or not?
The implementation of MemoryConfigCollection suggests that set() should be passed the entire value, factoring in the effects of any config middleware (which is how inheritance and extra extensions are provided). So this fix would be correct.
However, I wonder if we need to make this explicit in the MutableConfigCollectionInterface docs, and maybe add some tests to ensure that this behaviour is retained in MemoryConfigCollection (this would be a silverstripe/config change).
I think that treating this as a but in MemoryConfigCollection, while it would arguably be more intuitive for developers, would lead us down a config-complicating rabbit-hole, and so locking in the current behaviour (with docs and tests) is probably best.
@tractorcow or @micmania1 may have a view, they built a lot of this...

Yeah would be good to get weigh in from others.
This can be replicated in app/_config.php as well, without mutating config manifests (voluntarily). I guess adding and removing extensions with PHP will do that behind the scenes though.
As for whether this is the same issue as the other one we discussed, my gut feeling is that it's coincidental - this bug exists in all 4.x release lines, but I'll certainly run some tests on the other one tomorrow =)

It's on the OS Peer Review board. We just didn't get a chance to look at it yet. I'll try to have a look at it this afternoon.

This seems to be attempting to resolve an inconsistency by explicitly allowing it to remain inconsistent. As an analogy, this is similar to trying to remove an inherited method from a subclass, without removing it from the parent class.
If an extension is added to a parent class, and you attempt to remove it from a subclass, it should be an error IMO. Otherwise you run the risk of an inconsistent application.
That aside there are other issues in the code.

@sminnee as far as I recall, using Extension::add/remove is always as destructive to config cache as config::modify() directly. We should really be encouraging YML based solutions instead of PHP.

@robbieaverill Are you planning to peer review this?

@chillu yeah I want to but haven't had time yet. Will get back to it as soon as I can

@tractorcow:

as far as I recall, using Extension::add/remove is always as destructive to config cache as config::modify() directly. We should really be encouraging YML based solutions instead of PHP.

Do you think we should deprecate the PHP methods instead, update docs and not fix this bug?

We can't really deprecate based on performance alone, but we should build a better yml mutation system that users can use instead. A custom transformer would be a good idea; One that takes specific commands (provided by yml) and can do things like lookup and remove / replace values by keys and nested values.

Sure, I'll close this for now


Mooring update

NOT ready to merge.
Update mooring line diameter so min breaking load greater than max tension at max thrust.

Hi @fzahle, after doing some analysis on the mooring lines and their minimum breaking load, I think the original mooring system was okay, and I will end up closing this PR without making any changes.  I mostly opened it to keep better track of what I was changing, so I apologize for the extra confusion this caused.


Exploit seems to be failing

Trying this on a tryhackme box https://tryhackme.com/room/hackernote that should be vulnerable but it fails with the following message.
exploit: dl-call-libc-early-init.c:37: _dl_call_libc_early_init: Assertion `sym != NULL' failed.
Aborted (core dumped)

This isn't an issue with the exploit itself, but rather how it's been linked.
In order to help, I'd need information about the system you compiled it on and the system you're running it on, including the glibc version on both. My guess is that the system you're trying to run it on has a newer version of glibc and the linker expects this symbol (_dl_call_libc_early_init) now.
The easiest solution might be to build it on the same system you're trying to run it on, but you could try building a dynamically-linked binary instead (e.g. with make LDFLAGS=).

oh there is a lot of errors. when compile.


Allow MySQLConfiguration to be updated

Addresses issue: https://github.com/vapor/fluent-mysql-driver/issues/211
This allows the MySQLConfiguration to be edited after it has been instantiated, for example setting a TLSConfiguration

Original comment:
Probably a better approach would be to create a whole new MySQLConfiguration object with the new values and keep them immutable but since this was requested here it is.
Maintainers of this repo can decide if they want this change or take the alternative approach described above. Also, I've never worked with swift nor do I have a way to test this so please test this on your end.

These changes are now available in 4.5.1


Poor Performance about 'dualbev-4d-r50-cbgs'

Great work!
I have re-implemented the dualbev-4d-r50-cbgs using 4 RTX 3090 GPUs, but get poor performance. The only change in cfgs is that I reduce the original learning rate by half, as my total batch size is 8 * 4=32. I also observe that the model converges by the 15th epoch. Could you give me some suggestions?
Here are my re-implementation results:
epoch 12: NDS: 48.90, mAP: 37.31
epoch 13: NDS: 49.14, mAP: 37.33
epoch 14: NDS: 49.37, mAP: 37.63
epoch 15: NDS: 49.67, mAP: 37.71
epoch 16: NDS: 49.54, mAP: 37.96
epoch 17: NDS: 49.61, mAP: 37.81
epoch 18: NDS: 49.66, mAP: 37.83
epoch 19: NDS: 49.54, mAP: 37.80
epoch 20: NDS: 49.45, mAP: 37.81

Sorry we have not test with 4 GPUs, can you reproduce the result with our checkpoint?

Sorry we have not test with 4 GPUs, can you reproduce the result with our checkpoint?

Thanks for your reply! I can reproduce the results with the released checkpoint, and I have gotten similar results (NDS:50.61 mAP:38.32) when using a larger learning rate (2e-4) under 4 GPUs.


Add a BigInt build target

Now that we've migrated to JSBI, we should make it possible for users to build a version of ion-js that uses BigInts instead of JSBI values.

Hi @omichowdhury, this is not in active development.
If we produce a BigInt build target, it will use the same source code but will produce a second version of the library that uses BigInt. Currently, ion-js's test suite is in TypeScript. We would probably need to compile the test suite to JavaScript to be able to run it against both build targets' output (JS using JSBI and JS using BigInt).
BigInt is now pervasive enough that we may be able to consider a major version bump that migrates from JSBI to BigInt. Can you tell me about your platform and use case?

Hey @zslayton
We're using QLDB in a typescript/lambda (node v14) environment.
We use SST (framework on top of CDK), which uses esbuild for transpilation & bundling, and use @swc/jest for transpiling and running our unit & integration tests.
Happy to jump on a call if you want more details


actionmailer: Add ActionMailer::Base#default_i18n_subject and #headers

refs:

https://api.rubyonrails.org/classes/ActionMailer/Base.html#method-i-default_i18n_subject
https://api.rubyonrails.org/classes/ActionMailer/Base.html#method-i-headers

APPROVE

/merge


Supersonic Data Channel Duplicates

In our project we use the:
supersonic.data.channel('channel').subscribe() and
supersonic.data.channel('channel').publish() alot for communication between views.
Now with the latest update to supersonic 1.7.6 all "publish" calls the method or twice:
supersonic.data.channel('test').subscribe(function()
{
    console.log("Test got called");
});
supersonic.data.channel('test').publish();

And the log says:
(2) Test got called

Not sure how long ago this occured, but I updated from 1.5.* some version to 1.7.6 and this has started to occur now.
This kind of screws up alot of methods since we use it for communicating with servers. We have one global object that registers all "subscriptions" ONCE (checked so it only does this once).
Doesn't matter which view I put it in (only add this test in one view per time) it gets called twice either way. Sometimes, it has been called alot of times (think due to livereload?).

Investigated further and it seems not to be relative to the supersonic component but rather the Steroids update. Maybe a move if possible. Gonna look through the code. But, changing from Steroids version 3.5.14 to 3.5.12 makes this disappear.

Thanks for the report. Most likely related to this issue.

How do I downgrade steroids so I can get the pubsub to stop publishing twice?

I downgraded from 3.5.14 and 3.5.15 to 3.5.12. I searched as well, but had it in my gitrep so I copied an earlier version. In case you can't find it: http://s000.tinyupload.com/index.php?file_id=23582669098752936651

@thedeukalion Thanks

I use message IDs with the source and a timestamp when emitting, which I record by all subs and only execute once (put them in an array and use indexOf).
Interestingly, I don't experience his in any webviews except the one emitting the event (if its also a subscriber)

There's a known issue currently that the sending WebView will get the message twice.

@pre This issue has been around for quite some time now. Any updates on when a fix is coming?

This should now be fixed with Steroids.js 3.5.18 onwards. Please reply here if issues still occur.


Overview summary of 2.4.6 doesn't match the meaning of the success criterion

What the summary of 2.4.6 on the overview page says
On the overview page, the summary of Success Criterion 2.4.6 currently tells readers to "provide headings and labels":

Provide headings and form labels that will help people find content and complete tasks.

What the official phrasing of 2.4.6 says
But in fact, WCAG SC 2.4.6 doesn't require headings and labels to be provided (that's covered by 1.3.1 and 1.4.2). It only says that headings and labels that are provided must accurately describe topic or purpose:

2.4.6 Headings and Labels: Headings and labels describe topic or purpose. (Level AA)

So, not using labels or headings is not a violation of 2.4.6. What is a violation of 2.4.6 is using labels or headings that don't correctly describe the topic of their associated section or input.
The summary of 2.4.6 on the 'All requirements' page is correct
The summary of 2.4.6 in the 'All requirements' page gets that right:

Headings must indicate the topic or purpose of the content in that section of the page, and labels must indicate the purpose of the field they relate to.

Provide headings and labels that describe the topic or purpose of the page


Humble feature list

Conveniece enchancement feature requests

View options for automatic centering on selected objects

The view box should align the view to selected plane like in blender or unity

maybe even some shortcut for aligning the view

assets viewer should have some hierarchy for project, something like different folders for organisation sake.

also some different tabs for materials, meshes, and textures

sometimes the list view for managing a lot of assets would be nice

view or select the material from the mesh inspector - sometimes finding the material on big scene is tedious.

prefab system, for creating reusable assets for multiple projects and or sharing the ready made tools and extensions rather than copying from examples.

there is maybe a bug that doesnt allow the background from cubemap to update after change - it stays black but after reloading the scene it updates.
will update during my work with the editor.

Hello
Thanks a lot for this list, i think all of these should be implemented in the editor.
It actually partially matches my notebook list of tasks.
This last few days i have been working on a side project that i also want to integrate here in nunuStudio for node based code and node based shader editting. (https://tentone.github.io/escher.js/)
Once again thanks a lot for this list. Will try to work on it soon.
Cheers

WHOA, do You take donations? Im seriously thinking about using nunu studio for a big project so I could boost the development of the editor.


Issue With Logging In to Remote Server. Does not seem to send PASS Command

FTP OS: Unix / Windows / Embedded
FTP Server: Windows NT
Computer OS: ?
Trying to Connect remote server errors with 530 response. Log files seems to indicate that PASS command is not sent . Response is from connect method using template test code.
Status:   Connecting to <IP_ADDRESS>:21
Response: 220 iVan FTP server VAL2 [24341] (version 4.0.6970.30143) ready.
Command:  AUTH TLS
Response: 234 Switching control channel to Tls, Tls11, Tls12
Status:   FTPS Authentication Successful
Status:   Time to activate encryption: 0h 0m 3s.  Total Seconds: 3.303464.
Command:  USER hretail
Response: 530 Please login with USER and PASS.
Exception thrown: 'FluentFTP.FtpCommandException' in FluentFTP.dll
An unhandled exception of type 'FluentFTP.FtpCommandException' occurred in FluentFTP.dll
Please login with USER and PASS.

code running..
var creds = new NetworkCredential("hretail", mypass);
			// begin connecting to the server
client.EncryptionMode = FtpEncryptionMode.Explicit;
client.SslProtocols = SslProtocols.Tls;
client.DataConnectionType = FtpDataConnectionType.PASV;
client.ValidateCertificate += OnValidateCertificate;
client.Connect();

When Connectiing via CuteFtp client trace is
*** CuteFTP 9.0 - build Jun 25 2013 ***

STATUS:>  	[01/02/2019 16:15:33] Getting listing ""...
STATUS:>  	[01/02/2019 16:15:33] Resolving host name wwwtest.myvan.descartes.com...
STATUS:>  	[01/02/2019 16:15:33] Host name wwwtest.myvan.descartes.com resolved: ip = <IP_ADDRESS>.
STATUS:>  	[01/02/2019 16:15:33] Connecting to FTP server... wwwtest.myvan.descartes.com:990 (ip = <IP_ADDRESS>)...
STATUS:>  	[01/02/2019 16:15:33] Socket connected. Waiting for welcome message...
STATUS:>  	[01/02/2019 16:15:33] Connected. Exchanging encryption keys...
		Session Cipher: 0 bit
STATUS:>  	[01/02/2019 16:15:34] SSL Connect time: 535 ms.
STATUS:>  	[01/02/2019 16:15:34] SSL encrypted session established.
		[01/02/2019 16:15:34] 220 iVan FTP server VAL2 [23375] (version 4.0.6970.30143) ready.
STATUS:>  	[01/02/2019 16:15:34] Connected. Authenticating...
COMMAND:>	[01/02/2019 16:15:34] USER hretail
		[01/02/2019 16:15:34] 331 Password Required for hretail.
COMMAND:>	[01/02/2019 16:15:34] PASS *****
		[01/02/2019 16:15:34] 230 User hretail logged in.
STATUS:>  	[01/02/2019 16:15:34] Login successful.
COMMAND:>	[01/02/2019 16:15:34] SYST
		[01/02/2019 16:15:35] 215 Windows_NT
STATUS:>  	[01/02/2019 16:15:35] Host type detected: Windows NT.
COMMAND:>	[01/02/2019 16:15:35] PWD
		[01/02/2019 16:15:35] 257 "/" is current directory.
STATUS:>  	[01/02/2019 16:15:35] Home directory: /
COMMAND:>	[01/02/2019 16:15:35] FEAT
		[01/02/2019 16:15:35] Informational Message Only:
		211-Extensions supported:
		 AUTH TLS
		 AUTH SSL
		 PBSZ
		 PROT
		 CCC
		211 End
STATUS:>  	[01/02/2019 16:15:35] This site supports features.
STATUS:>  	[01/02/2019 16:15:35] Setting up character encoding.
COMMAND:>	[01/02/2019 16:15:35] OPTS UTF8 on
		[01/02/2019 16:15:35] 501 option not supported
STATUS:>  	[01/02/2019 16:15:35] Using local encoding.
COMMAND:>	[01/02/2019 16:15:35] REST 100
		[01/02/2019 16:15:35] 554 Restart not supported
STATUS:>  	[01/02/2019 16:15:35] This site cannot resume broken downloads.
COMMAND:>	[01/02/2019 16:15:35] PBSZ 0
		[01/02/2019 16:15:36] 200 Protection Buffer Size 0 accepted
COMMAND:>	[01/02/2019 16:15:36] PROT P
		[01/02/2019 16:15:36] 200 data connection will be secure
COMMAND:>	[01/02/2019 16:15:36] PASV
		[01/02/2019 16:15:36] 227 Entering Passive Mode (192,250,28,189,222,186).
COMMAND:>	[01/02/2019 16:15:36] LIST
STATUS:>  	[01/02/2019 16:15:36] Connecting FTP data socket... <IP_ADDRESS>:57018...
		[01/02/2019 16:15:36] 150 ASCII data.
STATUS:>  	[01/02/2019 16:15:36] Connected. Exchanging encryption keys...
		Session Cipher: 0 bit
STATUS:>  	[01/02/2019 16:15:37] SSL Connect time: 562 ms.
STATUS:>  	[01/02/2019 16:15:37] SSL encrypted session established.
		[01/02/2019 16:15:37] 226 Transfer complete.
STATUS:>  	[01/02/2019 16:15:37] Directory listing completed.

Logs :
Status:   Connecting to <IP_ADDRESS>:21
Response: 220 iVan FTP server VAL2 [24341] (version 4.0.6970.30143) ready.
Command:  AUTH TLS
Response: 234 Switching control channel to Tls, Tls11, Tls12
Status:   FTPS Authentication Successful
Status:   Time to activate encryption: 0h 0m 3s.  Total Seconds: 3.303464.
Command:  USER hretail
Response: 530 Please login with USER and PASS.
Exception thrown: 'FluentFTP.FtpCommandException' in FluentFTP.dll
An unhandled exception of type 'FluentFTP.FtpCommandException' occurred in FluentFTP.dll
Please login with USER and PASS.

What is mypass? Is it blank?
On Fri, Feb 1, 2019, 10:56 PM brucemcmillan<EMAIL_ADDRESS>wrote:

FTP OS: Unix / Windows / Embedded
FTP Server: Windows NT
Computer OS: ?
Trying to Connect remote server errors with 530 response. Log files seems
to indicate that PASS command is not sent . Response is from connect method
using template test code.
Status: Connecting to <IP_ADDRESS>:21
Response: 220 iVan FTP server VAL2 [24341] (version 4.0.6970.30143) ready.
Command: AUTH TLS
Response: 234 Switching control channel to Tls, Tls11, Tls12
Status: FTPS Authentication Successful
Status: Time to activate encryption: 0h 0m 3s. Total Seconds: 3.303464.
Command: USER hretail
Response: 530 Please login with USER and PASS.
Exception thrown: 'FluentFTP.FtpCommandException' in FluentFTP.dll
An unhandled exception of type 'FluentFTP.FtpCommandException' occurred in
FluentFTP.dll
Please login with USER and PASS.
code running..
var creds = new NetworkCredential("hretail", mypass);
// begin connecting to the server
client.EncryptionMode = FtpEncryptionMode.Explicit;
client.SslProtocols = SslProtocols.Tls;
client.DataConnectionType = FtpDataConnectionType.PASV;
client.ValidateCertificate += OnValidateCertificate;
client.Connect();
When Connectiing via CuteFtp client trace is
*** CuteFTP 9.0 - build Jun 25 2013 ***
STATUS:> [01/02/2019 16:15:33] Getting listing ""...
STATUS:> [01/02/2019 16:15:33] Resolving host name
wwwtest.myvan.descartes.com...
STATUS:> [01/02/2019 16:15:33] Host name wwwtest.myvan.descartes.com
resolved: ip = <IP_ADDRESS>.
STATUS:> [01/02/2019 16:15:33] Connecting to FTP server...
wwwtest.myvan.descartes.com:990 (ip = <IP_ADDRESS>)...
STATUS:> [01/02/2019 16:15:33] Socket connected. Waiting for welcome
message...
STATUS:> [01/02/2019 16:15:33] Connected. Exchanging encryption keys...
Session Cipher: 0 bit
STATUS:> [01/02/2019 16:15:34] SSL Connect time: 535 ms.
STATUS:> [01/02/2019 16:15:34] SSL encrypted session established.
[01/02/2019 16:15:34] 220 iVan FTP server VAL2 [23375] (version
4.0.6970.30143) ready.
STATUS:> [01/02/2019 16:15:34] Connected. Authenticating...
COMMAND:> [01/02/2019 16:15:34] USER hretail
[01/02/2019 16:15:34] 331 Password Required for hretail.
COMMAND:> [01/02/2019 16:15:34] PASS *****
[01/02/2019 16:15:34] 230 User hretail logged in.
STATUS:> [01/02/2019 16:15:34] Login successful.
COMMAND:> [01/02/2019 16:15:34] SYST
[01/02/2019 16:15:35] 215 Windows_NT
STATUS:> [01/02/2019 16:15:35] Host type detected: Windows NT.
COMMAND:> [01/02/2019 16:15:35] PWD
[01/02/2019 16:15:35] 257 "/" is current directory.
STATUS:> [01/02/2019 16:15:35] Home directory: /
COMMAND:> [01/02/2019 16:15:35] FEAT
[01/02/2019 16:15:35] Informational Message Only:
211-Extensions supported:
AUTH TLS
AUTH SSL
PBSZ
PROT
CCC
211 End
STATUS:> [01/02/2019 16:15:35] This site supports features.
STATUS:> [01/02/2019 16:15:35] Setting up character encoding.
COMMAND:> [01/02/2019 16:15:35] OPTS UTF8 on
[01/02/2019 16:15:35] 501 option not supported
STATUS:> [01/02/2019 16:15:35] Using local encoding.
COMMAND:> [01/02/2019 16:15:35] REST 100
[01/02/2019 16:15:35] 554 Restart not supported
STATUS:> [01/02/2019 16:15:35] This site cannot resume broken downloads.
COMMAND:> [01/02/2019 16:15:35] PBSZ 0
[01/02/2019 16:15:36] 200 Protection Buffer Size 0 accepted
COMMAND:> [01/02/2019 16:15:36] PROT P
[01/02/2019 16:15:36] 200 data connection will be secure
COMMAND:> [01/02/2019 16:15:36] PASV
[01/02/2019 16:15:36] 227 Entering Passive Mode (192,250,28,189,222,186).
COMMAND:> [01/02/2019 16:15:36] LIST
STATUS:> [01/02/2019 16:15:36] Connecting FTP data socket...
<IP_ADDRESS>:57018...
[01/02/2019 16:15:36] 150 ASCII data.
STATUS:> [01/02/2019 16:15:36] Connected. Exchanging encryption keys...
Session Cipher: 0 bit
STATUS:> [01/02/2019 16:15:37] SSL Connect time: 562 ms.
STATUS:> [01/02/2019 16:15:37] SSL encrypted session established.
[01/02/2019 16:15:37] 226 Transfer complete.
STATUS:> [01/02/2019 16:15:37] Directory listing completed.
Logs :
Status:   Connecting to <IP_ADDRESS>:21
Response: 220 iVan FTP server VAL2 [24341] (version 4.0.6970.30143) ready.
Command:  AUTH TLS
Response: 234 Switching control channel to Tls, Tls11, Tls12
Status:   FTPS Authentication Successful
Status:   Time to activate encryption: 0h 0m 3s.  Total Seconds: 3.303464.
Command:  USER hretail
Response: 530 Please login with USER and PASS.
Exception thrown: 'FluentFTP.FtpCommandException' in FluentFTP.dll
An unhandled exception of type 'FluentFTP.FtpCommandException' occurred in FluentFTP.dll
Please login with USER and PASS.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/robinrodricks/FluentFTP/issues/365, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AGe6KhsQTcafy2efFYozK3s-y6yT_jtNks5vJHjSgaJpZM4aev2d
.

Hi, thanks for getting back to me..
The password is not blank, but I appear to have resolved it
For this server i have now used
client.EncryptionMode = FtpEncryptionMode.Implicit;
client.SslProtocols = SslProtocols.Tls12;
client.Encoding = Encoding.UTF8;
client.DataConnectionType = FtpDataConnectionType.PASV;
Which has allowed me to connect...
There are a few differences in the settings, not sure which setting makes the difference, I tried to copy the ones returned by the cuteftp responses and it seemed to work
it is interesting ? that each setting made the server send a different response ?
I guess you can close the issue ?
Thanks so much for responding..

Maybe..

This is a good idea.
What if a made an AutoConnect() method that tried all the permutations and combinations, and printed out the code that you could use to connect to the server?
Would that work?

Settings we could flip:

EncryptionMode
SslProtocols
Encoding
DataConnectionType

Done in 26.0.0!
See this FAQ entry for details : https://github.com/robinrodricks/FluentFTP#faq_autodetect
Release notes:

New: Automatic FTP connection negotiation using AutoConnect()
New: Automatic detection of working FTP connection settings using AutoDetect()
New: C# code generation of working connection settings using FtpProfile.ToCode


Added "Created At" field in user-story

Issue Number
fixes #111

Describe the changes you've made
I have added the createdAt field in the GraphQL API call and this returns the date when a story was created. The date is then displayed in the list of stories and in the story description, as Created At field.
Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

NA
Additional context (OPTIONAL)

NA
Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

Provide a Deployed link of route/page that needs to review
In the story list:

In the story description:

@kailash360 can we place it below the story title instead? in the description page.
In the story list i think we don't need it. It's taking too much space

@kailash360 can you check in https://userstory.eosdesignsystem.com/? I can't see the date in the home page  in the list of open issues:
The expectation:

What I see:

@kailash360 can we place it below the story title instead? in the description page.
In the story list i think we don't need it. It's taking too much space

@cyntss
Based on the discussion here, I had removed it


Changelog on GitHub and on website are not synced

Hello,
I see that here you have the updated version of changeling file: https://github.com/airbnb/react-sketchapp/blob/master/CHANGELOG.md (it contains v3.1.1)
But on the website http://airbnb.io/react-sketchapp/CHANGELOG.html it's mention only for Version 3.0.1.
Looks that your build mechanism is broken and website pages are not updated from GitHub. Hope that this will help to keep your project better.

forgot to publish the docs. Should be fine now

forgot to publish the docs. Should be fine now

Can you setup GitHub actions to do it automatically for you? It will make your life easier, and developers life happier.
Have a good day!

The master isn’t necessarily what is published so we need to be careful about automatic deployment

Then create a “release” branch to have a stable code that is pushed to the public

then it's as much work as running npm run docs:deploy :)


Folder to exclude doesn't be excluded

Hello,
Thanks for the addon, it helps me a lot!
Recently I've just found an issue even if I've set the folders under the 'Folder to exclude' under 'update' and 'created' function settings, it's still be added the corresponding 'front matter' in the excluded files.
Basically, all the excluded folders I set are the folders that contain the template files, and each time they've been added the 'update' and 'created' front matters is the time it's been imported by triggering the template function in Obsidian. In addition, the 'created' time will remain the time it's been first imported and added to the 'created' front matter.

I'm having this same issue, reinstalling doesn't seem to help. any insights?

Not much insight, but a tip for usage. Try to type something in a new created file first and import the needed template after the auto timestamp has been made.

I, too, have excluded my Templates folder – to no effect.
The folder is buried under "3-Resources/Templates" but the plugin allows "Example: folder1/folder2"
Nevertheless, updated and created Properties are created.
Any resolution?

I can't reproduce the issue, since I'm myself using this plugin, with a folder that is excluded deeply nested and I don't have any issues.
A reproduction vault is welcomed so that I can actually see the issue

beaussan,  it works on some folders but not others. As we've seen here, others are having the same problem with their Templates folder.
I'm wondering: does it have a hard time with pre-existing folders (created before installing the plugin) but work with subsequently created folders?
If so, might one the Template folder, recreate a new Templates folder, then migrate old Template files into the new folder? Admittedly, this is after editing all the Template files with an editor external to Obsidian to remove the created/updated metadata.

Alas, no. I tried moving all the Templates out of the Template folder, edited each one in Visual Studio Code to remove the created/updated lines, and then moved them back into the Template folder. They still come in to a note with created/updated lines.

I was having the same issue, and was able to resolve it by closing other instances of Obsidian that I had open at the same time (specifically, Obsidian was open on my laptop while I was working on my Desktop). Once I closed the laptop Obsidian, the "exclude" folders are indeed now excluded from updates.
So it seems that if you add an exclusion while Obsidian is also open on a different machine (or phone, presumably) then it generates some kind of race/conflict.


Extend Robyn cli

With the release of v0.28.0 - robyn has a create function.
Extend it to add

Docker config
nginx/caddy config
suggest more ideas.

@sansyrox on it....😍


Missing JSON imports; bad test; BERT reset_model is no-op; Electra global misused

I read through these examples and really appreciate the material :clap:
After studying it a bit 'by eye' I cloned the repo and ran some linting on it, which allowed me to use flake8 to check code quality (without a bunch of stylistic warnings), and it did flag up a basic undefined name bug in the following modules
./examples/flair/_wsgi.py:38:18: F821 undefined name 'json'
./examples/huggingface/_wsgi.py:38:18: F821 undefined name 'json'
./examples/mmdetection/_wsgi.py:38:18: F821 undefined name 'json'
./examples/the_simplest_backend/_wsgi.py:37:18: F821 undefined name 'json'
./examples/dummy_model/_wsgi.py:38:18: F821 undefined name 'json'
./examples/bert/_wsgi.py:38:18: F821 undefined name 'json'
./examples/nemo/_wsgi.py:38:18: F821 undefined name 'json'
./examples/substring_matching/_wsgi.py:38:18: F821 undefined name 'json'
./examples/tensorflow/_wsgi.py:38:18: F821 undefined name 'json'
./examples/simple_text_classifier/_wsgi.py:38:18: F821 undefined name 'json'
./examples/pytorch_transfer_learning/_wsgi.py:38:18: F821 undefined name 'json'
./examples/ner/_wsgi.py:38:18: F821 undefined name 'json'
./examples/electra/_wsgi.py:38:18: F821 undefined name 'json'
./examples/tesseract/_wsgi.py:38:18: F821 undefined name 'json'

This can be fixed on Linux by running:
find . -name "_wsgi.py" -exec sed -i '1i import json' {} +

or on Mac by running:
find . -name "_wsgi.py" -execf sed -i '1i import json' {} +

Additionally the flake8 linter picked up a reassigned name in label_studio_ml/tests/test_basic.py at line 75, which appears to be a mistakenly pasted test (there are already setup tests for both the_simplest_backend and simple_text_classifier). The fix for this is to delete these lines (note also the mismatch in ML_BACKEND and reason in the pytest skipif decorator).
@pytest.mark.second
@pytest.mark.skipif(
    ML_BACKEND != "the_simplest_backend", reason="Test for simple_text_classifier"
)
def test_setup_the_simplest_backend():
    data = {
        "project": "1.1654592272",
        "schema": '<View><Text name="text" value="$transcript"/><View style="box-shadow: 2px 2px 5px #999;                padding: 20px; margin-top: 2em;                border-radius: 5px;"><Header value="Choose text sentiment"/><Choices name="sentiment" toName="text" choice="single" showInLine="true"><Choice value="Positive"/><Choice value="Negative"/><Choice value="Neutral"/></Choices></View></View>',
        "hostname": "http://localhost:8080",
        "access_token": "1234567890123456789012345678901234567890",
    }
    response = requests.post("http://<IP_ADDRESS>:9090/setup", json=data)
    assert response.status_code == 200

Another thing I'm pretty sure must be a bug is that the reset_model method of the bert example backend does not reassign self.model, it returns the model, but when it is called nothing is done with the return value.
https://github.com/heartexlabs/label-studio-ml-backend/blob/da749151ca59b2d60b23cf3b60864592d7df50d7/label_studio_ml/examples/bert/bert_classifier.py#L54-L56
I'm still in the midst of figuring out how this should work as a cohesive application but this is surely a futile computation, which may mean it's not a good example to use as a template.

Additionally (again minor nit) noticed the Electra model does not use the hardcoded MODEL_FILE to load from after checking if the path exists.
https://github.com/heartexlabs/label-studio-ml-backend/blob/da749151ca59b2d60b23cf3b60864592d7df50d7/label_studio_ml/examples/electra/electra.py#L31-L32
Should be
        if os.path.exists(MODEL_FILE):
            self.model = ElectraForSequenceClassification.from_pretrained(MODEL_FILE)

@lmmx thanks for your report! Could you please create a PR?

Sure can!

PR in at #139 :wrench:


Adding version check on NamedExpressionIf

Encountered this while I was working on the scope stuff. I think for version specific stuff like the := operator, we should specify the version of the test.

Sorry to ask for more, but if you can, there's another one to add in HoverTests.AssignmentExpressions, then there are two NamedExpr tests in LintUndefinedVarsTests which should use Required_Python38X and not Python38_x64.
If you can't do it now, I can merge this and do those myself.

No problem very simple to do. Also in AssignmentTests, even with my scope changes it doesn't seem to pass because declaration of the variable in named expression doesn't occur outside the current scope. I'll let you handle that.


Fix code styling

Hi, in my opinion just cut this commit in three parts (.gitignore, use env file to provide default user in the makefile, and the code style). Other than that LGTM.

Good call. I've split this into two PRs, this one and #7

Going to update bash style in a new release.


Respect the new core.telemetryConsent configuration option

Description
In Atom v1.11.0-beta0 a new Telemetry Consent system was introduced. The user's decision is stored at core.telemetryConsent. The three possible values are undecided, no and limited. The intent is that consent is given if and only if limited is chosen. The atom-beautify package should respect this decision also.
Expected Results
When core.telemetryConsent is set to undecided or no, atom-beautify does not collect any data on the user's behavior or use of the package.
Checklist

N/A - I have tried uninstalling and reinstalling Atom Beautify to ensure it installed properly
N/A - I have reloaded (or restarted) Atom to ensure it is not a caching issue
[X] Searched for existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues
so I know this is not a duplicate issue
N/A - Generated debugging information and added link for debug.md Gist to this issue

Glad to see this built-in to Atom! If someone does not submit a Pull Request by this upcoming weekend, I'll implement it and publish a release. Thanks for letting me know!

Published to v0.29.23


Object within the List is not observable

To reproduce
  MyClass(this.likes);
  int likes;
}
class MyController extends GetxController {
  var mm = List<MyClass>().obs..addAll([MyClass(2), MyClass(3)]);
}
class MyPage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Container(
      child: GetX<MyController>(
              init: MyController(),
              builder: (_) => RaisedButton(
                child: Text(_.mm[0].likes.toString()),
                onPressed: () {
                  _.mm[0].likes++;
                  print(_.mm[0].likes.toString());
                },
              ),
            ),
    );
  }
}```

like count is not incrementing with this approach, but when i use GetBuilder approach screen gets updated.
**Flutter Version:**
Flutter 1.20.0 • channel beta

**Getx Version:"3.10.2"**

Hi, Like is not List, and is not observable.
The lists are completely observable, so adding or removing an item will cause the screen to update.
Objects within the list must be observable for this change to occur.

Can you tell me how to create a list of myclass as observable so that when I change the like the screen must be updated?

List<Rx> list = <Rx>[].obs
list.update((yourClasse){
yourClass.likes = 35;
})


Append incremental n to duplicate cols recursively

FIxes #1119 (hopefully)
I added:

One function rename_duplicate_columns which recursively appends _n to duplicated column names.
Added a flag to sanitize_dataframe_columns_names which can be ['warn', 'drop', 'rename'] will either leave the DF along, delete all but the first duplicated columns, or append a number to the duplicated column.
Added some tests in athena_test.py to test this functionality. I'm not exactly sure this is the right place but other column sanitizers were there.
Exported rename_duplicate_columns
Imported warnings.

I'm not sure if I followed how you handle warnings as I saw different syntax in other parts but it should be easy to modify if I was wrong.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: e3df7380cfd170e3de84006a74989c4dd9abb3d5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Static checking has failed. Excerpt from the build logs:
ERROR: /codebuild/output/src093804598/src/github.com/awslabs/aws-data-wrangler/awswrangler/catalog/_utils.py Imports are incorrectly sorted and/or formatted.
ERROR: /codebuild/output/src093804598/src/github.com/awslabs/aws-data-wrangler/awswrangler/catalog/__init__.py Imports are incorrectly sorted and/or formatted.

Please run fix.sh (or isort .) to fix

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 80ba39f7231c1f0e456c7a77d2b83808deb0a17a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 4ea366287f125da91f4324e0af43ddea8b238292
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: f7a72657b2686ac4d24f42d39a5f7937a17e0b0f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 8a6e177caf3825aca79dfe4f68fe40f5b6c61e60
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 656e908d13c5186be0d2b5350b880f37e5abaa3b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 97396ce399f6ca521a822eb1f49cda64d2b02fa2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Warning:com.firebase.ui.auth.util.ui.FlowUtils

When in try to run in release mode it is showing below error's and warning. How to solve this problem?
Warning:com.firebase.ui.auth.ui.email.RegisterEmailFragment: can't find referenced method 'android.content.Context requireContext()' in program class com.firebase.ui.auth.ui.email.RegisterEmailFragment
   Warning:The `android.dexOptions.incremental` property is deprecated and it has no effect on the build process.
   Warning:com.afollestad.materialdialogs.DialogInit: can't find referenced class me.zhanghai.android.materialprogressbar.IndeterminateProgressDrawable
   Warning:com.firebase.ui.auth.ui.email.CheckEmailFragment: can't find referenced method 'android.content.Context requireContext()' in program class com.firebase.ui.auth.ui.email.CheckEmailFragment
   Warning:com.firebase.ui.auth.ui.phone.CheckPhoneNumberFragment: can't find referenced method 'android.support.v4.app.FragmentActivity requireActivity()' in program class com.firebase.ui.auth.ui.phone.CheckPhoneNumberFragment
   Warning:com.firebase.ui.auth.ui.email.RegisterEmailFragment: can't find referenced method 'android.support.v4.app.FragmentActivity requireActivity()' in program class com.firebase.ui.auth.ui.email.RegisterEmailFragment
   Warning:com.firebase.ui.auth.ui.phone.CheckPhoneNumberFragment: can't find referenced method 'android.content.Context requireContext()' in program class com.firebase.ui.auth.ui.phone.CheckPhoneNumberFragment
   Warning:com.firebase.ui.auth.ui.phone.SubmitConfirmationCodeFragment: can't find referenced method 'android.support.v4.app.FragmentActivity requireActivity()' in program class com.firebase.ui.auth.ui.phone.SubmitConfirmationCodeFragment
   Warning:com.firebase.ui.auth.ui.phone.SubmitConfirmationCodeFragment: can't find referenced method 'android.content.Context requireContext()' in program class com.firebase.ui.auth.ui.phone.SubmitConfirmationCodeFragment
   Warning:com.firebase.ui.auth.util.ui.FlowUtils: can't find referenced method 'android.support.v4.app.FragmentActivity requireActivity()' in program class com.firebase.ui.auth.ui.FragmentBase
   Warning:there were 8 unresolved references to program class members.
   Warning:there were 4 unresolved references to classes or interfaces.
   Warning:Exception while processing task java.io.IOException: Please correct the above warnings first.
   Error:Execution failed for task ':app:transformClassesAndResourcesWithProguardForRelease'.
   > Job failed, see logs for details

I am using implementation 'com.firebaseui:firebase-ui-auth:+'

@Midhilaj a few things:

It's never a good idea to use 'com.firebaseui:firebase-ui-auth:+', try using a specific version like 'com.firebaseui:firebase-ui-auth:4.2.0'
The requireContext() method comes form the Android Support library so I would guess there is a problem with your dependencies, could you show your app's dependencies?

Note: looks similar to
https://stackoverflow.com/questions/49289281/android-support-library-27-1-0-new-methods-requireactivity-requirecontext

Hasn't been a response in ~2 weeks so I assume you found your solution.  Let me know if not!


Error with Option<Cow> element when single tag

Case
XML source file can contain element <Element/> or <Element>text</Element> or not contain the span.
The type for it should be defined as:

#[derive(Debug, PartialEq, XmlRead, XmlWrite)]
#[xml(tag = "Parent")]
pub struct Parent<'a> {
    #[xml(child = "Element")]
    pub element: Option<Element<'a>>,
}

#[derive(Debug, PartialEq, XmlRead, XmlWrite)]
#[xml(tag = "Element")]
pub struct Element<'a> {
    #[xml(text)]
    pub content: Option<Cow<'a, str>>,
}

Expected behavior

<Element>text<Element/> => text is loaded into the instance
<Element/> => parent->element->content should be None
not specified => parent->element should be None

Or in case of defining the Element with flatten_text the case 2 and 3 can either have the same outcome or parent-element->text should be an empty/default value (empty string) for case 2.
Actual behavior
Case 1 and 3 work as expected. With case 2, however, I'm getting the following error:
UnexpectedToken { token: "ElementEnd { end: Empty, span: StrSpan(\"/>\" 2005..2007) }" }'

Same thing when using flatten_text.
Related issue
Having
#[derive(Debug, PartialEq, XmlRead, XmlWrite)]
#[xml(tag = "Element")]
pub struct Element<'a> {
    #[xml(text)]
    pub content: Option<Cow<'a, str>>,
}

Has error
   | #[derive(Debug, PartialEq, XmlRead, XmlWrite)]
   |                                     ^^^^^^^^ expected `str`, found reference
   |
   = note: expected reference `&str`
              found reference `&&std::option::Option<std::borrow::Cow<'_, str>>`

Although it says that Option<Cow<str>> should be supported. I can implement the XmlWrite myself, but that results in the issue mentioned above.

Thanks for reporting this and apologize for the delay in replying. #[xml(text)] doesn't support Option<Cow<str>> now. As a workaround, you can use Cow<str> directly, it will fall back to empty string if text element is not present.
I'm going to implement this in the next couple of days.


add translations for plugins

Hi,
We have a plugin in our app that has needs several resources to be in the strings file in the android values directory.
It would be nice if it was possible to add multiple strings to the resource file have a base resource file that will be appended by your plugin. Because if we add them to the i18n file the postfix will be added to the names and they will not be recognized by our plugin.
Thanks in advance

Simple keys matching ^[_a-zA-Z]\w*$ are no longer being encoded in the last version of the plugin. The regular expression could be further tuned to match any valid iOS and Android key but I won't do it myself. Anyway, it may be enough for your use case.


adding automation hub specific tags

adding 2 specific tags for the next release to increase search driven results. (if the tags don't fit, feel free to remove but if we can get 1 of the ones listed below, that would be awesome!)
cloud
linux
networking
storage
security
windows
infrastructure
monitoring
tools
database
application

I think we can add even more tags -- cloud, linux and security (perhaps monitoring too) should be a good match for the roles included in this collection 😄

@alessfg happy to edit the PR with whichever ones you all want to save work

Sure, let's go ahead then with adding the cloud, linux, security and monitoring tags then. Thanks!

@alessfg done, apologies for the delay.


Unable to set custom theme

[ x ] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
I want to add some custom colors as primary for theme.
Current Behavior
Updating theme with custom color not possible. New object is updated with new color but theme property not get updated.
Steps to Reproduce (for bugs)
I call createMuiTheme method and pass object const default_theme_obj = {     fontFamily: "Roboto, sans-serif",     palette: {         primary: "#fff", -> "example"     }, };  but when i pass it as theme={default_theme_obj} to MuiThemeProvider nothing happen, it still have default MUI theme colors. This is exacly how it was worked it v0.19.
Context
I expect that theme is updated with new color set as primary.
My app have several different theme depend on user role. When user is on login page default should be applied with color from DEFAULT_THEME object and when user get access he also get theme from DB which is applied to MUI. It was working really well in v0.19 but when i switch MuiProvider is never updated.
Your Environment

Tech
Version

Material-UI
1.0.0-beta.20

React
16.1.1

browser
all

Have a closer look at the documentation and the warnings in your console. The theme colors with Material-UI are rich objects containing hues (#xxxxxxx).
Follow #8075 for a better story on this end.

It doesn't help. So even if i define hue my theme is same, default MUI,...only no error in console.


what is!

I don't understand, I cannot run this ai generated mod which has invalid byte code!

I can believe you, This is my first time coding.


TPMv2 support

Creating this RFE issue as a place to hang some implementation notes about TPMv2 support.
Firstly, please don't add any new user interface for this. Keys wrapped by TPMv2 come in the form of a PEM file which we should just detect and use automatically.
As a nudge in that general direction, I've implemented the detection in my pending PKCS#11 series (hard to untangle since the context includes the checks for pkcs11: URIs). https://github.com/aws/rolesanywhere-credential-helper/commit/fe7e06f219628d2d854223c3d2fac412f92ba2f0
As for the implementation... I'm not sure what the state of TPM support in Go is.
https://github.com/google/go-tpm/ is probably the place to start? That's just the low-level TPM API support. Then there's https://github.com/google/go-tpm-tools which provides higher level interfaces, and I think it includes a Signer. I've filed https://github.com/google/go-tpm-tools/issues/316 to request support for the standard PEM form; if we want to do this right then we might end up implementing that for them.
As noted in that RFE, we can use my OpenConnect C implementation as something to crib from.

I implemented this: https://github.com/dwmw2/rolesanywhere-credential-helper/tree/tpm#tpmv2-integration


core: release v0.6.1

Trying again to see if I fixed it.

:tada: This PR is included in version 0.6.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Automated Package Upgrade

:tada: This PR is included in version 25.3.92 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Slope error checking in data processing

We catch trials which have a slope of exactly zero, but  a trial with only a few data points but zeros for the rest will not be caught as the slope is not exactly zero. Update this to catch this occasional issue.

from Slack:
Lisa Ferguson
9:53 AM
@channel
I have a quick question about one of the error checks in the data processing. The check that looks for flat conditions, or looks for a slope of 0, looks at the frame position data. So it goes through the frame position data for a condition and if the frame position never changes (so the difference between one data point and the next is 0 throughout the entire condition), it tosses the condition as bad.
It seems to me that if a condition was meant to be entirely static (so the pattern never moves), it would get tossed out by this check. I'm wondering if anyone does or has done experiments with static conditions like that? And if so did you have trouble with the data processing removing them?
I'm not talking about pre/inter/post trials, this check is not applied to those, only to main conditions. I think I am going to allow the user to opt out of this check in case anyone ever wants static conditions in their main block, but I thought I should check with you all and see if you have ever had a problem with this.
Michael Reiser
9:57 AM
hi
@taylorl
— I think I agree with you that this is a ‘mostly, but not always’ reasonable thing to check for. The more general error check would be to see if the recorded position data matches the expected (in the position function). Can you think of a way to implement that (with some small threshold for allowable differences)?
Lisa Ferguson
10:03 AM
Yes, I could implement that. Do you want to just replace the slope checking function with it, since it would be a more specific check? It wouldn't apply to conditions that don't have a position function, but the slope check is so rarely triggered that I don't think replacing it would cause an increase in bad data even if it leaves frame position unchecked in some modes.
Michael Reiser
10:08 AM
yes, I think this is a more general version that the slope check, for all trial types with a position function. something like the average of abs value of difference between expected position and actual position (and then threshold could either be in frame index (say 1) or percentage of max frame count (e.g. 1%).  You might need to do some unwrapping, since the errors could be big when the pattern turns over, even if it’s only a 1 frame error in that case. It may make sense to make these things warning vs. errors (and then pass on index, or flag so we could subsequently throw out trials?). This is something we could discuss with Laura, others to make it most useful.
Lisa Ferguson
10:16 AM
I can set it to only remove the condition if there was never a change in position function and there should have been (which is the check we've already been doing). If that's not the case, I can then just provide a warning if the recorded frame position varies too much from what's expected and give some info about where to look in the warning. I imagine there may be a slight delay between when a change is expected and when it's actually displayed and recorded, so we'd want to give a buffer in two directions - in the actual frame index (plus/minus 1) and in the timing of the change (frame updates within so many ms of when it's expected to). I can get the framework for that built and we can discuss what the most useful output would be, and if you want the buffers customizable.
@Sanna Koskela
@burnettl
if you have ideas on what would be most beneficial, let me know! (edited)
Michael Reiser
10:19 AM
sure. but for the timing thing, didn’t we implement the cross-correlation check? if so we can use that to align the position function (expected) with the recorded data, and only consider the errors for the temporally aligned version
10:20
for a totally flat trial (either on purpose or as an error), no correlation offset will make any sense! so would need to treat that case separately
Lisa Ferguson
10:26 AM
Yes but the cross correlation compares the different repetitions of a condition to each other. It doesn't compare to the expected position function, so if there was a delay or something that was consistent, it may not be picked up. The cross correlation, as it is, only picks up if a repetition is too different from the other repetitions of the same condition. At no point does it look at the expected position data
Lisa Ferguson
11:17 AM
I see what you mean, if there's a consistent delay between sending the frame and the frame changing, then yes, aligning the data will be enough and we can just check the frame value. I guess I was thinking if there's an out of the ordinary delay in the frame changing.  Differentiating between the screen simply displaying the wrong frame (or nothing) versus it displaying the right thing but delayed more than expected. And you're right, that would be picked up by the cross correlation so it would not be necessary to do here.
Michael Reiser
11:21 AM
yes. sorry, i forgot we did the cross-correlation between repetitions. So if you also did the similar xcorr between the position function (expected positions) and the recorded ones, you’d get an offset you could use to align the two and look for max differences. In nearly all cases, we can handle a 20-30 ms lag in when the pattern starts, so long as the sequence, once started has the right ‘shape’, so I think this combo (xcorr for max alignment followed by point-by-point comparison) would confirm all open loop trials are played back correctly. This seems like the most robust check to catch all the important errors
Lisa Ferguson
11:37 AM
Yes, that makes sense!

completed with commit c28ac5b36e7168a2aad973a864b691d3be47391d


Add CUDA caching allocator

The allocator can be enabled by setting the environment variable THC_CACHING_ALLOCATOR=1
cc @wickedfoo

Regarding C++11, I've tested this with GCC 4.4.7 which has pretty limited C++11 support. If we don't use any C++11 here, the problem is that we'll have to do platform-specific mutexes (pthread and windows).

Woohoo! Can you add to the README how to enable this in cutorch?

I believe the use of C++11 in this PR has stopped the Torch distro from building properly for me. This is what I see in my output:
In file included from /usr/include/c++/4.8/mutex:35:0,
                 from /root/torch/extra/cutorch/lib/THC/THCCachingAllocator.cpp:6:
/usr/include/c++/4.8/bits/c++0x_warning.h:32:2: error: #error This file requires compiler and library support for the ISO C++ 2011 standard. This support is currently experimental, and must be enabled with the -std=c++11 or -std=gnu++11 compiler options.
 #error This file requires compiler and library support for the \
  ^

I'm guessing that the use of C++11 is now going to trip up a bunch of people depending on which compiler version they use (I'm using gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4).
My personal opinion is similar to @wickedfoo in that I believe staying away from C++11 would be nice. However, failing that, it might be necessary to add more compiler flags to the build process?

@anibali try SET(CMAKE_CXX_FLAGS "-std=c++11 ${CMAKE_CXX_FLAGS}")

@anibali fixed now via https://github.com/torch/cutorch/commit/684659238eab7ed3a817fcf04099c8393ea68f60

@soumith I just gave your fix a try and it works like a charm. Thanks a lot!


Feature/update participants

Did some simplification of the code and DTO's. Instead of using the AzureAdUserDto, we re-used an existing dto for creating participoants. Also removed a bug when adding users, it adde the user to db even though it existed

Looks good!


hack fix at FormatException from user's login text

actually....... yea, not a good idea.

In a root-ed Android device, after installed sftp-server, I've checked the exception reason.
The command result of "id -u" and "id -g" shows "uid=0(root) gid=0(root) groups=0(root) context=kernel\n". It's a string!
To work around this exception, I've changed the commands as follows:
"busybox id -u", "busybox id -g", and "busybox df -Pk  {0}".
It works for me, but it is not general solution.


Settings crash when dragging color formats in the Color Selector

ℹ Computer information

PowerToys version: v0.29.0
PowerToy Utility: Color Picker
Running PowerToys as Admin: Yes
Windows build number: 19042.685

📝 Provide detailed reproduction steps (if any)

Open PowerToys Settings on the Color picker page;
Scroll down to the color format list;
Drag an item up or down the list;
Crash.

✔ Expected result
Changing the order of the color format that appears in the Color Picker UI.
❌ Actual result
Crash.
📷 Screenshots
Can't screenshot the crash, doesn't throw any errors, just closes.

@martinchrzan
I thought this is fixed? Thoughts?

@msbrunoalves
this is already tracked in https://github.com/microsoft/PowerToys/issues/8317 please add you comments there.


feat: consolidate identities into single model, simplify matching strategy relationships (resolves #1092)

Resolves #1092.

[x] Add unified Identity model, grouped using IdentityCluster enum, to replace AgeBracket, AreaType, Constituency, DisabilityType, EthnoracialIdentity, GenderIdentity, IndigenousIdentity, and LivedExperience
[x] Update Individual "groups you can connect to" editing for Community Connectors (resolves #739)
[x] Update Individual "groups you can connect to" viewing for Community Connectors
[x] Update Organization "groups your organization represents/serves and supports" editing (resolves #947)
[x] Update Organization "groups your organization represents/serves and supports" viewing
[x] Update MatchingStrategy to have direct many to many relationship with Identity models instead of through Criterion/criteriable morph
[x] Update Engagement "participant selection criteria" editing
[x] Update Engagement "participant selection criteria" viewing
[x] Update project disability and Deaf groups scope and all projects page filtering
[x] Remove AgeBracket, AreaType, Constituency, DisabilityType, EthnoracialIdentity, GenderIdentity, IndigenousIdentity, and LivedExperience
[x] Remove Criterion

Prerequisites
If this PR changes PHP code or dependencies:

[x] I've run composer format and fixed any code formatting issues.
[x] I've run composer analyze and addressed any static analysis issues.
[x] I've run php artisan test and ensured that all tests pass.
[x] I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

[x] I've run npm run lint and fixed any linting issues.
[x] I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

@jobara The individual updates are done. I encountered an error that we fixed before but the old fix doesn't seem to be working this time— namely, if you specify gender/sexuality identities, check a couple and save, then uncheck all of them and save again, you will get the validation error as expected but the ones you unchecked will show as checked on the page. I thought using mergeIfMissing would pass back an empty array to the old() helper but it doesn't seem to be… If you have any ideas I would be very grateful!

@jobara The individual updates are done. I'll be trying to finish up the organization and engagement changes tomorrow and Monday. I encountered an error that we fixed before but the old fix doesn't seem to be working this time— namely, if you specify gender/sexuality identities, check a couple and save, then uncheck all of them and save again, you will get the validation error as expected but the ones you unchecked will show as checked on the page. I thought using mergeIfMissing would pass back an empty array to the old() helper but it doesn't seem to be… If you have any ideas I would be very grateful!

I wonder if it's related to that change or request() to this? Perhaps we need to do both, with the former being returned for the old value, and the latter being used by validation.

@greatislander I'm getting an error when trying to visit the "Groups you can connect to" page while creating an individual user's public page.
Cannot assign null to property Hearth\Components\Checkbox::$checked of type bool

Unknown Property
Did you mean Hearth\Components\Checkbox::$checked ?

From: resources / views / individuals / edit / groups-you-can-connect-to.blade.php : 165
<x-hearth-checkbox name="nb_gnc_fluid_identity" :checked="old(

    'nb_gnc_fluid_identity',

    $individual->hasConnections('genderDiverseConnections'),

)" />

For an individual user setting up their public page, some of the identities they can connect to are "No" by default. Is that correct?

While there is an error message at the top of the page when "Can you connect to people with disabilities and Deaf people, their supporters, or both?" has no selection, there is no error styling or error message on the inputs/fieldset.

I hit an error trying to add a new "status" identity.
SQLSTATE[HY000]: General error: 1364 Field 'clusters' doesn't have a default value

insert into `identities` (`name`, `description`, `updated_at`, `created_at`) values ({"en":"Visa Student","fr":"Foreign Student"}, {"fr":null}, 2022-12-07 14:14:31, 2022-12-07 14:14:31)/*controller='HttpConnectionHandler',action='__invoke',url='%2Flivewire%2Fmessage%2Fapp.filament.resources.identity-resource.pages.create-identity',route='livewire.message',user_id='1',user_email='info%2Badmin%40accessibilityexchange.ca'*/;

From: app / Http / Middleware / VerifyCsrfToken.php : 20

While there is an error message at the top of the page when "Can you connect to people with disabilities and Deaf people, their supporters, or both?" has no selection, there is no error styling or error message on the inputs/fieldset.

Resolved in 3789a35c.

@greatislander found an issue with the old values for the public pages of organizations and individuals. The first question for the communities that can be connected to.
Steps to reproduce:

Create the public page for an individual or community organization
Go to the communities step
save the page without adding any input
check only "People with disabilities and/or Deaf people" for the first question and save
Notice that when the page reloads that the checkboxes are all unchecked and the follow up question is visible

@greatislander another validation error for Community Orgs.
If you only select "Supporters" for the question "Does your organization specifically serve and support people with disabilities and Deaf people, their supporters, or both? (required)*", validation error is returned saying "You must select at least one option for "Do you specifically serve and support people with disabilities, Deaf persons, and/or their supporters?"".


s3 setup - after craft upgrade to 3

Am i right in saying that imager scales and uploads resized images to amazon s3, using the options set in the imager.php config file? Images are being resized to the local imager folder, but the s3 one is empty.  The site can upload to AS3 ok.  What am i doing wrong?
Here is my config:
    'cacheEnabled' => true,
    'imagerSystemPath' => '@webroot/imager/',
    'imagerUrl' => 'https://BLAH.s3.amazonaws.com/imager',
    'storages' => ['aws'],
    'storageConfig' => [
      'aws'  => [
        'accessKey' => 'BLAH',
        'secretAccessKey' => 'BLAH',
        'region' => 'eu-east-1',
        'bucket' => 'BLAH',
        'folder' => 'imager',
        'requestHeaders' => array(),
        'storageType' => 'standard',
      ]
    ]

Investigating the log files and thrown up this error:
2019-06-06 03:09:28 [-][1][d37c3b5e43b91b63fcfb482b04c057e4][error][aelvan\imager\externalstorage\AwsStorage::upload] An error occured while uploading to Amazon S3: Error executing "PutObject" on "https://BLAH.s3.eu-east-1.amazonaws.com/imager/team/6171/testimage_3528d8f03267e09edcc0a2e088a20b9c.jpg"; AWS HTTP error: cURL error 6: Could not resolve host: BLAH.s3.eu-east-1.amazonaws.com (see http://curl.haxx.se/libcurl/c/libcurl-errors.html)
I have the correct bucket, and the correct region (which is US East N. Virigina, us-east-1).
Im at a loss as to how to resolve this, any help would be appreciated.

Your region says eu-east-1, not us-east-1?

Im such an idiot!!!! thanks!


NumberInput aria-label does not match displayed text

NumperInput Increment/Decrement buttons have an aria-label that does not contain / match the svgs displayed text resulting in a DAP violation.
Environment

Operating system

macOS 10.13.3 (17D47)

Browser

Chrome Version 73.0.3683.75 (Official Build) (64-bit)

Automated testing tool and ruleset

IBM Accessibility February 2019

Assistive technology used to verify

DAP Dynamic assessment plugin
Detailed description
For NumberInput, the up and down buttons need to have an aria-label that contains or matches the svg's title text. For example the NumberInput renders the below html:
<div class="bx--number__controls">
  <button class="bx--number__control-btn up-icon" type="button" title="Increment number" aria-label="Increment number" aria-live="polite" aria-atomic="true">
    <svg class="up-icon" fill-rule="evenodd" height="5" role="img" viewBox="0 0 10 5" width="10" aria-label="choose a number" alt="choose a number">
    <title>choose a number</title>
    <path d="M0 5L5 .002 10 5z"></path>
    </svg>
  </button>

  <button class="bx--number__control-btn down-icon" type="button" title="Decrement number" aria-label="Decrement number" aria-live="polite" aria-atomic="true">
    <svg class="down-icon" fill-rule="evenodd" height="5" role="img" viewBox="0 0 10 5" width="10" aria-label="choose a number" alt="choose a number">
      <title>choose a number</title>
      <path d="M0 0l5 4.998L10 0z"></path>
    </svg>
  </button>
</div>

Both the increment and decrement buttons aria-label need to contain or match the displayed text of choose a number from the svgs title.
So the buttons aria-label should look like aria-label="choose a number" to match the svg's title.

What version of the Carbon Design System are you using?

        "carbon-components": "9.84.14",
        "carbon-components-react": "6.108.0",
        "carbon-icons": "7.0.7",

What did you expect to happen?

aria-label to match svg's title text for accessibility.

What happened instead?

the aria-labels does not contain or match the svgs title text resulting in a DAP accessibility violation

What WCAG 2.1 checkpoint does the issue violate?

Accessible name does not contain the visible text label
IBM 2.5.3 Label in Name
Steps to reproduce the issue

Render NumberInput and run DAP against it

not stale ⚡


Show error in UI if call to backend service fails

Checked for duplicates
No - I haven't checked
Is this a regression?
No - This is a new bug
Version
1.6.2
Describe the bug
During the Clipper thread test I saw several cases where the user's authentication token would expire and Aerie would start to behave strangely because all the calls to the backend were failing. But there was no error visible in the UI. If a backend service were failing or offline the UI should also show an error, of course.
Reproduction
Open Aerie in two browser windows. Logout in one of them. Try to use Aerie in the other browser (to simulate an expired auth token). Or just shutdown the backend service containers and try to use the webapp.
Logs
No response
System Info
Chrome

Severity
Moderate

So hopefully for the auth expiration case in the latest version https://github.com/NASA-AMMOS/aerie-ui/pull/729 should prevent this all together (redirects to login if token expires).
More generally to this issues point, I do think we need to do a survey and make sure we are logging/alerting if the backend is offline.

If the version was 1.6.2, I'm a little confused as to how the auth token could've been expired, as there is no auth in that version. Could you confirm the version?

@Mythicaeda We did have auth in 1.6.2, we just did not have authorization or a JWT yet. It was just a session token from CAM, and could suffer from expirations.

I believe all known instances of the "logged-out" user problem have been solved with these related issues & PRs:

https://github.com/NASA-AMMOS/aerie-ui/pull/729
https://github.com/NASA-AMMOS/aerie-ui/issues/888
https://github.com/NASA-AMMOS/aerie-ui/issues/931
https://github.com/NASA-AMMOS/aerie-ui/pull/975

The frontend now redirects users to the login page when a response fails due to expired JWT token (#729) and the frontend also redirects pre-emptively when the token expires (#975). Closing this issue, please let us know if you see any more instances of this problem @parkerabercrombie . Thanks!


NeumorphicButton throws error with version flutter_neumorphic 3.0.1

════════ Exception caught by widgets library ═══════════════════════════════════════════════════════
The following NoSuchMethodError was thrown building _BodyBuilder:
The getter 'current' was called on null.
Receiver: null
Tried calling: current
The relevant error-causing widget was:
Scaffold file:///home/krishnakumar/Flutter_Projects/dhwark/lib/screens/home_screen.dart:34:12
When the exception was thrown, this was the stack:
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:53:5)
#1      _NeumorphicButtonState.updateInitialStyle (package:flutter_neumorphic/src/widget/button.dart:95:49)
#2      _NeumorphicButtonState.didChangeDependencies (package:flutter_neumorphic/src/widget/button.dart:110:5)
#3      StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:4661:12)
#4      ComponentElement.mount (package:flutter/src/widgets/framework.dart:4476:5)
...
════════════════════════════════════════════════════════════════════════════════════════════════════
I/flutter (10924): Another exception was thrown: NoSuchMethodError: The getter 'current' was called on null.
I/flutter (10924): Another exception was thrown: Each child must be laid out exactly once.
I/flutter (10924): Another exception was thrown: NoSuchMethodError: The getter 'current' was called on null.
I/flutter (10924): Another exception was thrown: Each child must be laid out exactly once.
I/flutter (10924): Another exception was thrown: NoSuchMethodError: The getter 'current' was called on null.
I/flutter (10924): Another exception was thrown: Each child must be laid out exactly once.
I/flutter (10924): Another exception was thrown: NoSuchMethodError: The getter 'current' was called on null.
I/flutter (10924): Another exception was thrown: Each child must be laid out exactly once.
I/flutter (10924): Another exception was thrown: NoSuchMethodError: The getter 'current' was called on null.
I/flutter (10924): Another exception was thrown: Each child must be laid out exactly once.
I/flutter (10924): Another exception was thrown: NoSuchMethodError: The getter 'current' was called on null.
I/flutter (10924): Another exception was thrown: Each child must be laid out exactly once.
════════ Exception caught by rendering library ═════════════════════════════════════════════════════
Each child must be laid out exactly once.
The relevant error-causing widget was:
Scaffold file:///home/krishnakumar/Flutter_Projects/dhwark/lib/screens/home_screen.dart:34:12
I/flutter (10924): Another exception was thrown: NoSuchMethodError: The getter 'current' was called on null.
════════════════════════════════════════════════════════════════════════════════════════════════════
I/flutter (10924): Another exception was thrown: Each child must be laid out exactly once.
════════ Exception caught by widgets library ═══════════════════════════════════════════════════════
The following NoSuchMethodError was thrown building _BodyBuilder:
The getter 'current' was called on null.
Receiver: null
Tried calling: current
The relevant error-causing widget was:
Scaffold file:///home/krishnakumar/Flutter_Projects/dhwark/lib/screens/home_screen.dart:34:12
When the exception was thrown, this was the stack:
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:53:5)
#1      _NeumorphicButtonState.updateInitialStyle (package:flutter_neumorphic/src/widget/button.dart:95:49)
#2      _NeumorphicButtonState.didChangeDependencies (package:flutter_neumorphic/src/widget/button.dart:110:5)
#3      StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:4661:12)
#4      ComponentElement.mount (package:flutter/src/widgets/framework.dart:4476:5)
...
════════════════════════════════════════════════════════════════════════════════════════════════════
I/flutter (10924): Another exception was thrown: NoSuchMethodError: The getter 'current' was called on null.
I/flutter (10924): Another exception was thrown: Each child must be laid out exactly once.
I/flutter (10924): Another exception was thrown: NoSuchMethodError: The getter 'current' was called on null.
I/flutter (10924): Another exception was thrown: Each child must be laid out exactly once.
I/flutter (10924): Another exception was thrown: NoSuchMethodError: The getter 'current' was called on null.
I/flutter (10924): Another exception was thrown: Each child must be laid out exactly once.
I/flutter (10924): Another exception was thrown: NoSuchMethodError: The getter 'current' was called on null.
I/flutter (10924): Another exception was thrown: Each child must be laid out exactly once.
I/flutter (10924): Another exception was thrown: NoSuchMethodError: The getter 'current' was called on null.
I/flutter (10924): Another exception was thrown: Each child must be laid out exactly once.
I/flutter (10924): Another exception was thrown: NoSuchMethodError: The getter 'current' was called on null.
I/flutter (10924): Another exception was thrown: Each child must be laid out exactly once.
════════ Exception caught by rendering library ═════════════════════════════════════════════════════
Each child must be laid out exactly once.
The relevant error-causing widget was:
Scaffold file:///home/krishnakumar/Flutter_Projects/dhwark/lib/screens/home_screen.dart:34:12
════════════════════════════════════════════════════════════════════════════════════════════════════
I/flutter (10924): Another exception was thrown: NoSuchMethodError: The getter 'current' was called on null.
I/flutter (10924): Another exception was thrown: Each child must be laid out exactly once.

Same here
`══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following NoSuchMethodError was thrown building DefaultTextStyle(debugLabel: ((((englishLike
body1 2014).merge(blackMountainView bodyText2)).apply).copyWith).copyWith, inherit: false, color:
Color(0xff40494f), family: Signika_regular, familyFallback: [Signika], size: 14.0, weight: 400,
baseline: alphabetic, decoration: TextDecoration.none, softWrap: wrapping at box width, overflow:
clip):
The getter 'current' was called on null.
Receiver: null
Tried calling: current
The relevant error-causing widget was:
Material
lib\widgets\GamesAction.dart:25
When the exception was thrown, this was the stack:
#0      Object.noSuchMethod  (dart:core-patch/object_patch.dart:51:5)
#1      _NeumorphicButtonState.updateInitialStyle  (package:flutter_neumorphic/src/widget/button.dart:95:49)
#2      _NeumorphicButtonState.didChangeDependencies  (package:flutter_neumorphic/src/widget/button.dart:110:5)`

The same for me
`════════ Exception caught by widgets library ═══════════════════════════════════
The following NoSuchMethodError was thrown building Container(center, bg: BoxDecoration(color: Color(0xffffffff), borderRadius: BorderRadius.circular(20.0)), constraints: BoxConstraints(w=350.0, h=350.0)):
The getter 'current' was called on null.
Receiver: null
Tried calling: current
The relevant error-causing widget was
Container
lib/…/home/home.dart:14
When the exception was thrown, this was the stack
#0      Object.noSuchMethod  (dart:core-patch/object_patch.dart:53:5)
#1      _NeumorphicButtonState.updateInitialStyle
package:flutter_neumorphic/…/widget/button.dart:95
#2      _NeumorphicButtonState.didChangeDependencies
package:flutter_neumorphic/…/widget/button.dart:110
#3      StatefulElement._firstBuild
package:flutter/…/widgets/framework.dart:4661
#4      ComponentElement.mount
package:flutter/…/widgets/framework.dart:4476
...
════════════════════════════════════════════════════════════════════════════════`

+1

The same for me... ;)
+1

Same

+1


'sandbox' CSP directive ommitted when now allow-* are specified

NWebsec does not enable CSP's Sandbox unless at least one Allow* method is called on the IFluentCspSandboxDirective
owin.UseCsp(
   opt => opt.DefaultSources( src => src.None() ).Sandbox( c => { } ) );

Actual Header:

content-security-policy default-src 'none'

Expected Header:

content-security-policy	default-src 'none'; sandbox

Ugh, that sounds like an undisputable bug. I'll take a look. Thanks for reporting this.