current zip archiv not working with Roundcube 1.1.4

Hi,
I downloaded the current master as zip to install it to my roundcube 1.1.4 installation.
I enabled the plugin, but all I see is this on the logfiles:
Feb  2 11:42:14 mail1 roundcube: <t14eq19t> PHP Error: Failed to load plugin file /var/www/webmail/plugins/thunderbird_labels/thunderbird_labels.php in /var/www/roundcubemail-1.1.4/program/lib/Roundcube/rcube_plugin_api.php on line 198 (GET /webmail/?_task=mail&_caps=pdf%3D1%2Cflash%3D1%2Ctif%3D0&_uid=4840&_mbox=Sent&_action=show)
Feb  2 11:42:14 mail1 roundcube: <t14eq19t> PHP Error: Failed to load plugin file /var/www/webmail/plugins/thunderbird_labels/thunderbird_labels.php in /var/www/roundcubemail-1.1.4/program/lib/Roundcube/rcube_plugin_api.php on line 198 (GET /webmail/?_task=addressbook&_action=photo&_email=x.x%40comp.com)
Feb  2 11:42:14 mail1 roundcube: <t14eq19t> PHP Error: Failed to load plugin file /var/www/webmail/plugins/thunderbird_labels/thunderbird_labels.php in /var/www/roundcubemail-1.1.4/program/lib/Roundcube/rcube_plugin_api.php on line 198 (GET /webmail/)
Feb  2 11:42:14 mail1 roundcube: <t14eq19t> PHP Error: Failed to load plugin file /var/www/webmail/plugins/thunderbird_labels/thunderbird_labels.php in /var/www/roundcubemail-1.1.4/program/lib/Roundcube/rcube_plugin_api.php on line 198 (GET /webmail/?_task=mail&_uid=4840&_mbox=Sent&_remote=1&_unlock=loading1454409736980&_action=pagenav&_=1454409736680)
Feb  2 11:42:14 mail1 roundcube: <t14eq19t> PHP Error: Failed to load plugin file /var/www/webmail/plugins/thunderbird_labels/thunderbird_labels.php in /var/www/roundcubemail-1.1.4/program/lib/Roundcube/rcube_plugin_api.php on line 198 (GET /webmail/?_task=mail&_remote=1&_unlock=0&_action=getunread&_=1454409736681)

any idea?
Thanks,
Thomas

Check directory and file permissions of thunderbird_labels/thunderbird_labels.php.
Is thunderbird_labels/thunderbird_labels.php readable by your http server user?

Doesn't work. Can you tell me someone when should be correct package for version 1.1.4 please?

@ThomasCr , do you tried again with version 1.2.0 ? For me, works fine.
You can use one of this link:
https://github.com/mike-kfed/rcmail-thunderbird-labels/archive/master.zip
https://github.com/mike-kfed/rcmail-thunderbird-labels/archive/master.tar.gz


Make buffer completion responsive for large files

Since buffer completion processes the current buffer everytime user types something, it will degrade the experience for large files.
This change adds a timeout to buffer completor function. Processing current buffer is cut short when timeout is exceeded. Setting timeout to 0 will revert back to existing behaviour.
Default is set to 100 ms, good for scanning 6000 lines on M1 macbook.
It is possible to get fancy by scanning locality of cursor first but such complication may not be worth the complexity.
Tested on >20k line files (I have to open these large C files filled with hw specs occasionally).
M  autoload/lsp/completion.vim
M  autoload/lsp/options.vim
M  doc/lsp.txt

Would searchpos() be more appropriate since it has timeout option? It also searches around cursor position which is more relevant than searching top-to-bottom.


Placeholder author "Godette" in Create/Edit Plugin page

Tested versions
v4.3.rc.2.official [afc82bc08]
System information
Redot v4.3.rc.2 - Windows 10.0.19045 - GLES3 (Compatibility) - Intel(R) Iris(R) Xe Graphics (Intel Corporation; <IP_ADDRESS>0) - 12th Gen Intel(R) Core(TM) i5-1240P (16 Threads)
Issue description
When creating / editing a plugin, if the Author field is empty, it will display "Godette" as a placeholder. We might want to rebrand it to "Redot-chan" or something.

Steps to reproduce

Go to Project > Project Settings > Plugins > Create New Plugin.
See that the Author is displaying "Godette" as its placeholder.

Minimal reproduction project (MRP)
N/A

On a slightly related note, there might be other mentions of "Godette" somewhere else in the engine too.

./bin/redot.linuxbsd.editor.dev.x86_64
./bin/redot.linuxbsd.editor.x86_64
./platform/web/api/web_tools_editor_plugin.cpp
./doc/translations/zh_CN.po
./doc/translations/ga.po
./doc/classes/HTTPRequest.xml
./modules/libmodule_gltf.linuxbsd.editor.x86_64.a
./modules/libmodule_gltf.linuxbsd.editor.dev.x86_64.a
./modules/gltf/editor/editor_scene_exporter_gltf_settings.linuxbsd.editor.x86_64.o
./modules/gltf/editor/editor_scene_exporter_gltf_settings.cpp
./modules/gltf/editor/editor_scene_exporter_gltf_settings.linuxbsd.editor.dev.x86_64.o
./editor/libeditor.linuxbsd.editor.x86_64.a
./editor/libeditor.linuxbsd.editor.dev.x86_64.a
./editor/plugins/plugin_config_dialog.linuxbsd.editor.dev.x86_64.o
./editor/plugins/plugin_config_dialog.linuxbsd.editor.x86_64.o
./editor/plugins/plugin_config_dialog.cpp

Changes added to #858


Python: Change to shorter nox session names.

This mirrors a change @dhermes made to the manual layer noxfiles awhile back, and will cause future APIs not to bork up @duggelz's testing framework for new runtimes.

Codecov Report

Merging #1770 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1770   +/-   ##
=========================================
  Coverage     84.92%   84.92%
  Complexity     4496     4496
=========================================
  Files           432      432
  Lines         17848    17848
  Branches       1880     1880
=========================================
  Hits          15157    15157
  Misses         2032     2032
  Partials        659      659

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b28fd0...16516e5. Read the comment docs.


cpp_client_telemetry fails to build with gcc13

Describe your environment.
Ubuntu Linux 24.04 with gcc 13
Steps to reproduce.
./build.sh
There are files which reference types and don't include necessary header files. It is likely that these header files were being inherited through other included headers and now they must be included explicitly in the project.
The first few encountered:
Enums.hpp: uint64_t requires <cstdint>
EventFilterCollection.cpp: std::invalid_argument requires <stdexcept>
The fix is to just go through building the repo repeatedly and adding missing include directives.

The following patch fixes the build for the current commit.
[
gcc13build.patch
](url)


Document Kapacitor subscriptions and replicating data between data centers

We need better documentation on Kapacitor subscriptions. Included here are links to a blog posting and various tidbits of information in the InfluxDB documentation.
Multiple Data Center Replication with InfluxDB

written by @dp1140a
includes steps on replicating data between clusters using subscriptions

InfluxDB Enterprise clustering features

This "Subscriptions" section includes only the following (this is the entire section):
"Subscriptions used by Kapacitor work in a cluster. Writes to any node will be forwarded to subscribers across all supported subscription protocols."

IFQL subscription-related commands

CREATE SUBSCRIPTION
DROP SUBSCRIPTION
SHOW SUBSCRIPTION

subscription-protocol setting (kapacitor.conf)
Kapacitor and InfluxDB HTTPS

This section has two Kapacitor configuration examples that use the subscription-protocol setting:

subscription-protocol – to declare the correct protocol for subscription communications. For example if Kapacitor is to run on HTTP then this should be set to "http", however if Kapacitor is to run on “HTTPS” then this should be set to "https".
Securing Kapacitor Enterprise

Includes a section on "Kapacitor Enterprise over TLS" that briefly mentions subscription-protocol settings

reference #1319 and close both when complete

Closing #613 as a dup of this, but make sure to verify UDP/TCP discussion in that is covered here.

Note question on Kapacitor subscriptions and clusters here: https://github.com/influxdata/kapacitor/issues/2002

Closing as Scott documented the subscription behavior. MDCR can be skipped for now -- not high-demand for this.


Fix missing autocompletion when entering a new password

Hello and admiration for the project!
This is a fix for a tiny issue that I noticed while signing up for the platform.
Motivation and context
Password managers or some browsers' built-in password features can generate and save passwords for you when they detect you're entering a new password - e.g. when you're registering, changing your password, etc.
They use the attribute autocomplete to do that. When it's set to current-password, they suggest existing stored passwords for you. When it's set to new-password they suggest generating and saving a new password.
Mozilla docs on the subject
In this project currently, all authentication forms use a default PasswordField component, which sets autocomplete to current-password.
This PR allows to override this default prop and overrides it to new-password in the appropriate places.
Screenshots:
Here's a preview using 1Password

Before
After

Podkrepi BG signup form before.webm
Podkrepi BG signup form after.webm

Testing
I tested the changed forms manually.

I've noticed something similar, but related with the Login page. My Password Manager (LastPass) can't auto-fill my email/password as it usually do in the other websites. For some reason it doesn't identify these fields at all.
Is there any referenced issue already logged or you went directly to fix it within this PR?

@kachar
It doesn't make much sense to update the login forms, since they appropriately have their autocomplete attributes set to current-password, which is set by the PasswordField component by default if you don't override it. So there's no benefit except being more explicit.

@valkirilov
1Password fills in my details in the login form as usual. Tested on Firefox's built-in password manager - it also works. Are you sure it's not a LastPass configuration issue?

@antonmihaylov I was referring to the email field on the LoginForms, it lacks the autoComplete attribute in both places. I guess the browsers are smart enough to pick it up from attributes like name="email" and label="Email".
We may also extract it as a separate component EmailField, just like PasswordField, and reuse it.
I'm okay we don't do it, just sharing ideas here.

@antonmihaylov I was referring to the email field on the LoginForms, it lacks the autoComplete attribute in both places. I guess the browsers are smart enough to pick it up from attributes like name="email" and label="Email".
We may also extract it as a separate component EmailField, just like PasswordField, and reuse it.
I'm okay we don't do it, just sharing ideas here.

Ah didn't think about the email fields at all, since they indeed seem to get picked up implicitly.
But yeah, makes sense to add them too.
I now notice that they have type=text. Is this on purpose to avoid the default validation?
While we're at it, I suggest adding type="email" and, if it's required to avoid the browser's default validation - to add novalidate. This would improve mobile experience a bit since you'd get a specific keyboard layout for entering emails.

@antonmihaylov Let's await the update and then merge this PR.
If you prefer otherwise please let me know so we can split the login issues as a separate task.

@antonmihaylov I was referring to the email field on the LoginForms, it lacks the autoComplete attribute in both places. I guess the browsers are smart enough to pick it up from attributes like name="email" and label="Email".
We may also extract it as a separate component EmailField, just like PasswordField, and reuse it.
I'm okay we don't do it, just sharing ideas here.

Ah didn't think about the email fields at all, since they indeed seem to get picked up implicitly. But yeah, makes sense to add them too.
I now notice that they have type=text. Is this on purpose to avoid the default validation?
While we're at it, I suggest adding type="email" and, if it's required to avoid the browser's default validation - to add novalidate. This would improve mobile experience a bit since you'd get a specific keyboard layout for entering emails.

I'm personally using NordPass and the email field works for me. But generally it would be an amazing addition!


🚧 Feat(web-react): Introduce UNSTABLE_Toggle component #DS-1346

Description

Additional context

Issue reference

coverage: 73.332% (-4.6%) from 77.951%
when pulling 53f9fe595e3144d9663001fc20baa9597eeab3b0 on feat/ds-1346-unstable-toggle-react
into 7177732ccd082756dff2465d055d76fb335fa1d5 on feat/web-toggle.

Add the component to /packages/web-react/scripts/entryPoints.js


-v must interpret escape sequences

Hi, @benhoyt.
-v must interpret escape sequences. I hate this spec of awk, but anyway, reality is what it is. ☹
$ goawk -v VAR='\t' 'BEGIN{printf VAR}' | hexdump -C
00000000  5c 74                                             |\t|

$ mawk -v VAR='\t' 'BEGIN{printf VAR}' | hexdump -C
00000000  09                                                |.|

$ gawk -v VAR='\t' 'BEGIN{printf VAR}' | hexdump -C
00000000  09                                                |.|

Hi @ko1nksm, thanks for your recent bug reports. This is an interesting one. I'll take a look at these in the next few days.
Out of interest, what are you using GoAWK for? Are you using it as a Go library or via the goawk command line tool?

I am testing if goawk (command line tool) can be used as an implementation of awk that shdotenv uses internally.
If you are interested, you can perform the test by following the steps below.
$ printf "FOO='ABC'" | SHDOTENV_AWK=goawk ./src/shdotenv --no-allexport -e -
FOO='ABC'

# or run all tests
$ shellspec -e AWK=goawk

Thanks for that. I've fixed this via PR #132 (also for the other var=value form).


plugins/cilium-cni: add Interface index to the CNI result

Signed-off-by: Salvatore Mazzarino<EMAIL_ADDRESS>Please ensure your pull request adheres to the following guidelines:

[x] For first time contributors, read Submitting a pull request
[x] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[x] Provide a title or release-note blurb suitable for the release notes.
[x] Thanks for contributing!

This adds the corresponding Interface index to the CNI result.
CNI plugins like tc-redirect-tap expect this field to be filled.
add Interface index to the CNI result

Slack thread: https://cilium.slack.com/archives/C1MATJ5U5/p1596013346482600

Coverage increased (+0.006%) to 36.691% when pulling 4570736d1d2a02e3ad0c017a163b1edb287dabd5 on mazzy89:plugins/add-interface-index into 3de518a79c968c0e11964c5726dd9f7bb4fed9fc on cilium:master.

test-me-please

several tests failed but at a quick glance not clear at the moment if it is due for this change. need to check deeper.

several tests failed but at a quick glance not clear at the moment if it is due for this change. need to check deeper.

GKE is failing across the board at the moment, so it looks like this PR has passed CI.

Thank you guys to pushing this out so quickly.


LS Unit tests fix

commit f356370 added tests for linking lr to ls.
However, it failed to cleanup the LR and LS. Re-running the test
failed. Hence, this patch cleans up entities that failed to cleanup.

Thanks


Attach license to repo prior to making it public.

@georgeslabreche is thinking MIT License because it's the most permissive one.

I'm not really good with license but I have no problem in making it very permissive yes!


Do not create tables when in read-only mode

If db was opened with flag='r', check if tablename exists, if not raise RuntimeError.
Closes #127

I included a basic test.

I included a basic test.

Good work @hholst80 ! Thank you for your contribution.

Good work @hholst80 ! Thank you for your contribution.


How will a data curator know which info is extracted based on PID?

Describe the improvement
Currently, metadata is filled based on the DOI from DataCite, after which a user can further complete and/or edit the metadata. How can a data curator know which of the metadata fields were automatically extracted and therefore should not be changed.

Need to rethink this with import flows. Will reopen / refer to this when we tackle it, as this became stale. Currently impossible because of the way it works underlying, which means we cannot implement this practically.


[Consent] Listed issues based on review

Review on https://developer-stage.adobe.com/client-sdk/documentation/consent-for-edge-network/
index.md

Broken links:

First link to Edge Network extension
Migrate to swift link under Download and import the Consent extension -> ACP 2.x

Formatting/indentations in tabs - numbered lists followed by code snippets show incorrectly. Can the number be indentation as the text below or should we remove numbers?

Header underline shows incorrectly for long header names

Left nav

Should show Release notes first, then API reference

All of these have been fixed in #120!
3 seems to be an issue with the developer site itself, so I'll file a ticket in their JIRA. As for release notes, I think we've put it at the end for all the other ones, so I'll be leaving it there.


[grpc] update to 1.60.0

Library name
grpc
New version number
1.60.0
Other information that may be useful (release notes, etc...)
Current version (1.51.1) is more than a year old.
Thank you.

@Adela0814  I have started to work on this. Already added utf8-range as a new dependency to vcpkg which is a requirement of the updated upb. However, my work on updating upb has been slow due to the massive patch required to get it to work, now I am running into what seems like ODR violations too.

Hello,
the current version is now 1.62.0 so please skip 1.60.0 if we can get it working ;)

I manually compiled the library. I won't need it anymore. Thank you anyway.


More Auth Options

I am writing a Google Sheets Add-On, but I cannot use your awesome package because of how you have limited auth to JWT only. I use oAuth to do operations on my users behalf.
A better solution might be to pull the google-auth-library out of your package, make it a peerDependency, and then let users pass in whatever auth instance they want to. All your package would need to accept in the constructor is a spreadsheetId and auth instance.

Hi, @vlucas !
Thank you for your feedback and for using Holysheets!
I understand your concern regarding the limitation of authentication to JWT only. Your suggestion to pull out google-auth-library and make it a peerDependency, allowing users to pass their own auth instance, is a great idea. This would indeed provide more flexibility for users who need to use OAuth for their Google Sheets operations.
I will create a task to implement this feature. Your suggestion will help improve the package for everyone.
Best regards

Enhancement: Allow Custom Auth Instances for Google Sheets
Current Behavior:
The current implementation of Holysheets limits authentication to JWT only, using google-auth-library directly.
Proposed Improvement:
Pull google-auth-library out of the package and make it a peerDependency. Allow users to pass their own authentication instance to the Holysheets constructor. This change will enable the use of OAuth and other authentication methods, providing more flexibility for users who need to perform operations on behalf of their users.
New Constructor Parameters:

spreadsheetId: The ID of the Google Spreadsheet.
auth: The authentication instance provided by the user.

Example Usage:
const { google } = require('googleapis');
const Holysheets = require('holysheets');

const auth = new google.auth.OAuth2(
  YOUR_CLIENT_ID,
  YOUR_CLIENT_SECRET,
  YOUR_REDIRECT_URL
);

// After obtaining the OAuth2 tokens
auth.setCredentials({
  access_token: ACCESS_TOKEN,
  refresh_token: REFRESH_TOKEN,
  scope: SCOPES,
  token_type: TOKEN_TYPE,
  expiry_date: EXPIRY_DATE
});

const sheets = new Holysheets({
  spreadsheetId: 'your-spreadsheet-id',
  auth: auth
});

// Use the `sheets` instance as usual

Benefits:

Flexibility to use different authentication methods.
Enables the use of OAuth for operations on behalf of users.
Improves the package's usability for Google Sheets Add-Ons.

Yes, this is how it would look exactly! 👍

Hey @vlucas!
I'm happy to let you know that I've just launched version 2.0.0 of HolySheets, and it now supports OAuth2!
Here’s what’s new:

OAuth2 Support: Now you can authenticate and perform operations on behalf of your users using OAuth2.
Peer Dependency for google-auth-library: I moved google-auth-library to a peer dependency, so you can pass in your own auth instances easily.

Check It Out

Example Usage: Take a look at how to implement OAuth2 with HolySheets in our OAuth Example.
Updated Documentation: All the details you need are right here: OAuth2 Documentation.

Could you give the new version a spin and let me know if everything’s working smoothly for you? Your input would be super helpful!
Thanks again for helping improve HolySheets! 🚀


Problem with androidx

{"kind":"error","text":"Program type already present: androidx.core.graphics.PathSegment","sources":[{}],"tool":"D8"}

OK I find solution>
implementation ('com.reddit:indicator-fast-scroll:1.0.1') {
exclude group: 'androidx.core'
}
and I implement 'androidx.core:core-ktx:1.0.1'

Appreciate the report! Working on a fix.

Version 1.1.0-beta1 is released, which uses AndroidX. Going forward, releases of the library will likely only support AndroidX. Version 1.0.1 can still be used in projects not AndroidX. If a dependency issue arises from a project including a different version of KTX, the workaround you mentioned above will help.


Size checking of example programs

Added a script which checks the example programs binary size (both with symbols and stripped) and outputs the statistics of symbols which contribute the most to the size of the stripped binary.
Resolves: #850

Maybe we should just leave out the link time optimization setting?

Done.

How do I see the results?


Search Editor tab icon is incorrect

VSCode: 1.49.0 on macOS
Unfancy: 3.10.0
I see this was added to this theme at some point in the past, but it doesn't seem to be working...
Unfancy Codicons:

SETI icons:

Good catch! I'll try to fix it.
Interesting, the magnifier icon is displayed for the search saved to a file.

Should be fixed in v3.12.0. It would be great if you confirm it's fixed for you.

It's fixed, but would it be too much to ask for basically any other color besides green? Maybe just gray, or perhaps cyan?

I think it could be changed to tha grey color. Btw, what's wrong with the green color?

Apologies, I should've been clear about that. Since green is source files, the majority of my open tabs are already that color, making it hard to visually distinguish.

Since green is source files, the majority of my open tabs are already that color, making it hard to visually distinguish.

That makes the sense. I will change the color to gray in the next version.

@swrobel I've published v3.12.1 which includes gray color for the search icon.


Update major-mode mapping (add haskell)

textobjects for haskell has been merged in #48

Ahh, thanks.


fix pylint warnings

Codecov Report
Patch and project coverage have no change.

Comparison is base (3781a7e) 79.02% compared to head (0cb2cc3) 79.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   79.02%   79.02%
=======================================
  Files          26       26
  Lines        1969     1969
=======================================
  Hits         1556     1556
  Misses        413      413

Flag
Coverage Δ

unittests
79.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Local pull request success status testing

Docs Build status updates of commit 3447791:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

E2E_DocsBranch_Prod_Dynamic/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Guidance on what to do about porches and decks?

Instructions would benefit from guidance on what to consider part of the "building footprint" with regard to things like porches and decks.
Software is brilliant, by the way, just reviewed 100 sets, and thanks for supporting OpenStreetMap.

Thanks for the comment. Ignore porches and decks. Eaves make the best footprint outlines.
I'll see about adding that info to the instructions.

Fixed by de57b1cb

Looks great. Thank you!


shared use of node-fetch by app and resource-detector-gcp can result in https module not getting instrumented

What version of OpenTelemetry are you using?
{
    "@opentelemetry/api": "^1.9.0",
    "@opentelemetry/auto-instrumentations-node": "^0.50.0",
    "dotenv": "^16.4.5",
    "express": "^4.21.0",
    "node-fetch": "^2.7.0"
}

What version of Node are you using?
v20.16.0
What did you do?
Tried to get auto-instrumented metrics out of uses of node-fetch@v2.
Basic express app setup that doesn't work:
https://gist.github.com/sjparkinson/3cd2061c1c8c7257787f15a66b5e574c/12075e305e88b53ae1556a5ea5b4cdcb96810b04
What did you expect to see?
Traces and metrics from instrumentation-http for uses of node-fetch.
What did you see instead?
Only traces from instrumentation-net for uses of node-fetch.
Additional context

https://github.com/Financial-Times/dotcom-reliability-kit/issues/1191#issuecomment-2360487655
https://cloud-native.slack.com/archives/C01NL1GRPQR/p1726764253015149?thread_ts=1726738909.597679&cid=C01NL1GRPQR

As reported by Trent in the CNCF Slack, it looks to be an issue with resource-detector-gcp requiring gaxios which requires the two Node.js http/https modules before they are instrumented.

--require @opentelemetry/auto-instrumentations-node/register loads auto-instrumentations-node, which indirectly loads gaxios, which has require('node-fetch').  node-fetch requires http and https.
Then later, the OTel HTTP instrumentation is initialized: adding the hooks so that when http and https are next required, they will be instrumented.
Then your app.js starts. When it runs require('node-fetch') it gets the cached module from require.cache, so there is no require('https') that results from that call.
Notably express does not require('https'). It does require('http').

So, require('https') does not happen after the OTel SDK is started and hence it is not
instrumented.

Re-stating the issue. The application use OTel via:
node --require @opentelemetry/auto-instrumentations-node/register app.js

The application is using node-fetch to make an https call:
const fetch = require('node-fetch');
// ...
    fetch('https://httpbin.org/post', ...)

Problem: there is no HTTP client span for the outgoing https://httpbin.org/post request.
the issue
The require-in-the-middle hook to instrument https does not get called, so the use of https.request(...) in the node-fetch module isn't instrumented.
Both OTel and the app are using the same node_modules/node-fetch installation:
% npm ls node-fetch
<EMAIL_ADDRESS>/Users/trentm/tmp/oteljs-node-fetch-q
├─┬<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   └─┬<EMAIL_ADDRESS>│     └─┬<EMAIL_ADDRESS>│       └──<EMAIL_ADDRESS>deduped
└──<EMAIL_ADDRESS>
The node-fetch module gets required (and cached) before the HttpInstrumentation is initialized, because it is loaded by @opentelemetry/auto-instrumentations-node. If nothing else in the application code does require('https'), then the require-in-the-middle hook doesn't get called.
A workaround is for the application code manually require('https') to trigger the require-in-the-middle hook, but that is too obtuse.
The general issue. Assuming OTel bootstrapping (e.g. via auto-instrumentations-node/register or otherwise) is done first (via --require or --import), then the general issue is: If any of the OTel bootstrap code uses a module (like node-fetch) that (a) indirectly uses a module (like https in this case) that will be instrumented and (b) is also used by the application, then there is a potential for that instrumention hook to not happen.
Practically speaking, I don't expect there to be any or many other occurrences of this.
fix options
I'm discussing options for fixing the specific issue with node-fetch, not the "general issue".

Explicitly have instrumentation-http trigger the hook for http and https modules when it is initialized.
Re-write resource-detector-gcp to not use gcp-metadata -> gaxios -> node-fetch.  Perhaps feels a little extreme, but FWIW, I vaguely recall that the detector isn't that involved.
Somehow ensure resource-detector-gcp uses a private install of node-fetch, so there isn't a shared usage with application code. One way to do this would be to bundle gcp-metadata, e.g. with esbuild, and install that.

... or other options I haven't thought of.

FYI: discussed this a bit on the OTel JS SIG today: https://docs.google.com/document/d/1tCyoQK49WVcE-x8oryZOTTToFm7sIeUhxFPm9g-qL1k/edit#heading=h.rg479jqq3jo5
No obvious option came out. It is a bit of a hard problem.

Explicitly have instrumentation-http trigger the hook for http and https modules when it is initialized.
Re-write resource-detector-gcp to not use gcp-metadata -> gaxios -> node-fetch.  Perhaps feels a little extreme, but FWIW, I vaguely recall that the detector isn't that involved.
Somehow ensure resource-detector-gcp uses a private install of node-fetch, so there isn't a shared usage with application code. One way to do this would be to bundle gcp-metadata, e.g. with esbuild, and install that.

@trentm beat me to it with the comment but clicking comment anyway for posterity:
Changing gcp detector is possible, but the same problem can come up in other detectors including custom detectors.

... or other options I haven't thought of.

If I'm not wrong we had a similar situation with grpc and solved it by doing lazy load of the modules.
ref: https://github.com/open-telemetry/opentelemetry-js/pull/4432
node-fetch is only needed when detect process starts so we could require the module within the function. At that moment the instrumentation is already instantiated and the hook will work as expected. Maybe this (lazy load of modules) could be a rule of thumb for detectors and similar components.


update deployment instructions

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   78.42%   78.42%
=======================================
  Files          11       11
  Lines         774      774
  Branches      159      159
=======================================
  Hits          607      607
  Misses        138      138
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd73ac...a5d6dab. Read the comment docs.


On modal submit, view event not listen to

(Describe your issue and goal here)
When a user clicks the submit button in a modal view and tries to listen to it on app.view( callback_id,fn) event not listen to
Reproducible in:
The Slack SDK version
3.12.2
(Paste the output of
npm ls | grep -o "\S\+@\S\+$" | tr @ ' ' | awk -v q='"' '{print q$1q": "q"^"$2q","}' | grep slack

or refer to your package.json)
Node.js runtime version
(Paste the output of node --version)
OS info
(Paste the output of sw_vers && uname -v on macOS/Linux or ver on Windows OS)
Steps to reproduce:
(Share the commands to run, source code, and project settings)

Expected result:
(Tell what you expected to happen)
Actual result:
    app.command('/command', async ({ client, ack, say, body , command}) => {
    try {
      await ack();
      const install = await getUserInstall(command);
      const Client = install.token && install.OrgId
        ? await createClient(install.token, install.orgId)
        : null;
        if (!client) {
          throw new Error("orgId and token not found");
        }
        const commandArg = command.text.trim()
        if (commandArg === 'list'){
          // handle list command
          await listDataset(Client, say);
          return;
        }

        if (commandArg === "query"){
          const result = await client.views.open({
            trigger_id: body.trigger_id,
            callback_id: QUERY_VIEW_CALLBACK_ID,
            view: {
              type: "modal",
              title: {
                type: "plain_text",
                text: "Query dataset"
              },
              callback_id: QUERY_VIEW_CALLBACK_ID,
              blocks: queryInput(QUERY_ACTION).blocks,
              submit: {
                type: "plain_text",
                text: "Query",
                emoji: true,
              },
            }
          })

          console.log({ result })
          console.log({ md: result.response_metadata })
          return;
        }

        say(defaultMsg);

    }catch(err){
      console.log({err}, '-----');
    }
  })

on the view I have this
  app.view(QUERY_VIEW_CALLBACK_ID, async ({ ack, client, context,view }) => {
        console.log("called view")
        const query = view.state.values;
        console.log({ query })
        await ack();
    })

but on submit nothing happens, only the loader keep moving
(Tell what actually happened with logs, screenshots)
Requirements
For general questions/issues about Slack API platform or its server-side, could you submit questions at https://my.slack.com/help/requests/new instead. :bow:
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

Hi, @Bensigo! Thanks for submitting this question!
On quick glance at your code - have you tried moving the ack() call to the beginning of the view handler?
Also, are you seeing any of the console statements logging when submitting the view?

I tried that, not getting any logs or anything

@Bensigo have you verified that you are referencing the correct callback ID for the modal in your views listener?

@Bensigo are you using Socket Mode?

@Bensigo Just looked over your views.open input payload, can you remove the first-level callback_id param you're passing in and only keep the callback_id inside the views object and tell me if that works? Should be something like this:
const result = await client.views.open({
            trigger_id: body.trigger_id,
            view: {
              type: "modal",
              title: {
                type: "plain_text",
                text: "Query dataset"
              },
              callback_id: QUERY_VIEW_CALLBACK_ID,
              blocks: queryInput(QUERY_ACTION).blocks,
              submit: {
                type: "plain_text",
                text: "Query",
                emoji: true,
              },
            }
          })

@Bensigo Just found this comment - can you hop into your app configuration page + verify that the request URL under Interactivity and Shortcuts is set to /slack/events?

Thanks, this works


I can not make migration file

Subject: django 4.0/python 3.8
Problem
I can not create first migration.
When I looked at error logs, It seems to me that django dose not recognise django-redshift-backend.
I have database setting as following.

Procedure to reproduce the problem
python3 manage.py makemigrations my_project
Error logs / results
django.core.exceptions.ImproperlyConfigured: 'django_redshift_backend' isn't an available database backend or couldn't be imported. Check the above exception. To use one of the built-in backends, use 'django.db.backends.XXX', where XXX is one of:
    'mysql', 'oracle', 'postgresql', 'sqlite3'

Expected results
Migration is created.
Environment info

OS: Amazon Linux 2
Python version: 3.8
Django version: 4.0
Django-Redshift-Backend version:3.0

Do you have any suggestion for this?
Regards.

@soseki-angfa I'm sorry for the late reply.
Please check to see if the django-redshift-backend installation was successful.
$ pip show django-redshift-backend
...(information are shown if it is installed)...

$ python
Python 3.10.14 (main, May 14 2024, 08:39:53) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import django_redshift_backend
>>> django_redshift_backend.__version__
'3.0.0'

I'm closing this issue, but if the issue still hasn't been resolved, please reopen it.

Thanks


Create ids data

This PR updates the create subcommand to create the IDS profiles from the Imas input location specified in jetto settings from the template directory. I modified the config with more suitable example operations as discussed in #58.
Closes #61
Todo:

[x] Implement add / multiply operations
[x] Write new IDS profiles
[ ] Documentation
[ ] Refactor inner loop that applies the operation

This seems to be working now. If I take this config:
# config.yaml
workspace: ./workspace
create:
  template: template_model
  data:
    db: jet
    run_in_start_at: 7000
    run_out_start_at: 8000
  matrix:
    - ids: zeff
      operator: add
      values: [1, 2, 3]
    - ids: t_i_average
      operator: multiply
      values: [1.1, 1.2, 1.3]

and run duqtools create config.yaml, it will take all combinations of zeff and t_i_average (Cartesian product) and write the new data files to the given location.
All basic numpy arithmetic operations are supported, i.e. 'add', 'multiply', 'divide', 'power', 'subtract', 'floor_divide', 'mod', and 'remainder'.
For the moment, this works on imas.DBEntry.get('core_profiles').profiles1d[0].{ids}, where we can set ids from the config.


Confused by the workflow of KivyUnitTest

Hello,
Thanks for this module (I'm having troubles finding nice ways to test Kiby, now that InteractiveLauncher is deprecated). But I don't understand the principles of KivyUnitTest.
From my understanding, in a GUI engine like Kivy, everything runs synchronously in a single main thread.
So in your readme example excerpt below, run_test(), having been schedule on the Clock, should run entirely as a scheduled callback, before any other event can be processed by the main loop.
Thus, if it ends with app.stop() , the application will stop immediately, before any other scheduled event (like pause()) has a chance to be executed. So it shouldn't be possible to test, with this system, long operations with frame refreshes and user interactions.
What am I missing ? There is no "preemptive interrupts" or "greenlets" in Kivy here, is there ? Interrupting the python function runtest() right in the middle to play other events would be fragile, wouldn't it?
class Test(unittest.TestCase):
    def pause(*args):
        time.sleep(0.000001)

    def run_test(self, app, *args):
        Clock.schedule_interval(self.pause, 0.000001)
        # Do stuffs
        app.stop()

def test_example(self):
        app = My()
        p = partial(self.run_test, app)
        Clock.schedule_once(p, 0.000001)
        app.run()

Just in case - I'm investigating a different approach using Gevent; with such microthreads all running in main thread, tests and app can run concurrently.
One probably still needs 1 process per test though, to avoid conflicts between Kivy contexts.
import gevent
from gevent import monkey; monkey.patch_all()

def test_example(self):
        ...
        gevent.spawn(app.run)
        self.run_test(app)


feat: #472753: top parents adjustment

Handle the new data coming from the addon processing that includes top parent data for the changed elements. Updated test.

@pmconne, yes, running this test with the old addon will fail. Is that a problem?

@pmconne, yes, running this test with the old addon will fail. Is that a problem?

In future please follow this process to ensure the imodel02 branch and the imodel02 repository are kept in sync. I began producing a new addon build after you committed your native changes but before you submitted this PR for TypeScript; that's exactly the situation we want to avoid.


Siri 'Not Finding' WeMo Switches

I have tonight added a second WeMo switch to Homebridge, which is recognised within HomeKit Apps on iOS (Insteon+ App) and i can toggle manually etc.
When i say to Siri "Turn on the Lamp in the lounge" however, it turns the switch on, but the Siri response is "Sorry, i couldn't find any lights in the lounge".
It works flawlessly with my other WeMo switch in the dining room (again acting as a lamp within HomeKit), but this Siri doesn't seem to like this second switch, despite actually triggering the action.
Any known issues with multiple WeMo switches?

Make sure the WeMo device type is set as a Light Bulb in Insteon.

@barryjarvis may I know how you connect WeMo with HomeKit and Insteon+?

@rudders ^^^


Create PrintNumbersFrom1ToN.java

Closes #ISSUE_NUMBER #5215
I've written a simple and understandable code to print 1 to n numbers.

Check out my new changes to the code here.
04d9d0eaf3175ddb5bb9086af45dbcc16376e0cd


introduce optional cache duration for non-optimized files

We had the same problem as in #96 and so we added a second cache duration config setting for non-optimized files.

Great, thanks for contributing! :)


Chore | fix: update llms and requirements. Clear syntax warning.

The issues #3 #4 #5 have been resolved.

The langchain-community module has been added to the requirements.txt file.
The llms have been changed to gpt-4o-mini and gpt-4o.
The syntax error in line 65 of 'examples/person_lookup.py' has been fixed.

Nice! Heads up that while gpt-4o is the better model, it is better at resisting generating phishing emails, etc.

Thanks @sshh12! I appreciate your insight, and letting me contribute to your project. 👍


A user should be able to delete a survey point.

Most likely they entered the point by accident and no images are associated. If images are associated with the survey point then all images can be moved to a "general" survey point named Default (or something similar).

@drewjgray in what field would we want this to happen? It is quite easy for those with access to the database to do it upon request for now.
@avalmas-programize can you just make sure that we set null on deletes?

We want this to be available as a feature to the users, not for DB admins. Can we put a minus sign next to a survey point in the dropdown menu?

It will be a bit tricky since it's not a standard UI at all but we can try.
I definitely think this should be a functionality for users as well but I was seeing that as more of a post mvp feature that comes on a dedicated page with other admin edit features for surveys / reefs
If you would like us to investigate the first option, how about:

we try to add a x or a garbage can at the end of every row in the drop down
add a confirmation message on click: Are you sure that you would like to delete "survey point" for all your surveys?

That looks good to me. I think it is important for MVP because the first time I tried to use it, I wanted to delete a point, and the first time John tried to use it, he tried to delete point - seems like a thing people are going to do.

Note - As we work on this, let's improve website/src/common/SurveyForm/index.tsx and:

move it out of common
use classes to style components instead of inline styling


Check that there if there is datasets to add from here:

https://aclanthology.org/2023.nodalida-1.61/

Valid options include:

NoCoLA, language learners
Additional written form parallel from the machine translations
NoRec_Fine (a fine-grained version of norec)

The might be two datasets here (polarity, intensity)


Non-atomic syncing of Package/BundleMetadata/CatalogMetadata resources for a particular catalog.

When the resources (Package+BundleMetadata / CatalogMetadata) are being synced for one catalog, if an error is encountered in the middle of an operation, eg in the middle of a loop where existing Packages are being deleted, the cluster ends up in a state where some of the resources have been operated on, while the remaining resources are in the previous/stale state. This gives an incorrect view of the world to the clients.
Instead, operations should be atomic. Either An operation succeeds wholly in operating on all of the resources it was supposed to be operating on, or : none of the resources are updated at all + an error is surfaced about the failure in operating on the resources.

Based on the new route of storing catalog contents via a filesystem and serving them via HTTP is this issue still relevant?

Don't think so.


Rsoiffer/circuit api

Rewrote the pure circuit API, and fixed issues from previous PRs

@rsoiffer Did you actually add the check to make sure that all qubits for the pure circuits you are handing off are distinct? I don't think I've seen it.


Startupdate not working on reconnect using the extension

Hey guys,
Great job on the API. I initially grabbed the original project and heavily modified to make it work on my side in March 2015. When I saw your code I decided to switch as I like your API much more (has support for API 21).
However I ran into an issue that took me a couple of hours to figure out. If the connection is lost, the code below will re-establish the connection with the device. However setCharacteristicNotification() will fail hence resulting StartUpdates() for the Charactrastics to not work.
Assume a IDevice ID is saved. In my case it is a preferred device set by users which is meant be auto-connected to.
Here is the sample code:
var device = await Adapter.DiscoverSpecificDeviceAsync (SOME_DEVICE_ID);
var connectedDevice = await Adapter.ConnectAsync (device);
var service = await connectedDevice.GetServiceAsync (SOME_GATT_SERVICE_ID);
_sampleCharacteristic = await service.GetCharacteristicAsync (SOME_GATT_CHAR_ID)
_sampleCharacteristic .StartUpdates();
_sampleCharacteristic .StartUpdates() returns false since the DiscoveredDevices list is not cleared hence Adapter.DiscoverSpecificDeviceAsync returns the stored IDevice and Gatt object. Java code behind returns false since mClienIf or mService are null.
Not sure if this is intentional or not. To fix this in my code, I listen to ConnectionLost event and clear out the DiscoveredDevices list.

Thanks for pointing that out :). We'll investigate the issue as soon as possible and release it with 1.0.

Thanks! This is where I got to figure out my issue, under GattCallback.cs of the Droid project:
if (DeviceOperationRegistry.TryGetValue(gatt.Device.Address, out device))
{
Mvx.Trace("Disconnected by user");
                    //Found so we can remove it
                    DeviceOperationRegistry.Remove(gatt.Device.Address);
                    ConnectedDeviceRegistry.Remove(gatt.Device.Address);
                    gatt.Close();

                    DeviceDisconnected(this, new DeviceConnectionEventArgs { Device = device });
                    break;
                }

                //connection must have been lost, bacause our device was not found in the registry but was still connected
                if (ConnectedDeviceRegistry.TryGetValue(gatt.Device.Address, out device))
                {
                    Mvx.Trace("Disconnected by lost connection");

                    ConnectedDeviceRegistry.Remove(gatt.Device.Address);
                    gatt.Close();

                    DeviceConnectionLost(this, new DeviceConnectionEventArgs() { Device = device });
                    break;
                }

User disconnect clears out both connected and discovered devices while lost connection only clears out the connected devices. Again, thanks for looking into it


DBZ-6173 Support for upgrading UI build to use Debezium 2.2

There are few things which could still be polished and moved from UI codebase here.
Just wanted to get it out ASAP so that it can be tested.
It works-on-my-machine (tm), however I'm running MacOS so it should be tried on linux as well.

Nice improvements. Added @ani-sha as reviewer for awareness of the changes.

Also DBZ-6173 has been released in CR1, so we need a new Jira for this one. Can you please create a new ticket and change it accordingly @jcechace? Thanks.

@ani-sha  yes, the TODO should be added on tom of these changes. I will create the ticket and finish things here.
@rk3rn3r  Before I do this, I need somebody to test these change on Linux machine. Just build this locally and try the changes in https://github.com/debezium/debezium-ui/pull/700

Superseded by #4473


Cannot control ZNCZ04LM

I am not able to control Mi Smart Plug (Zigbee) (ZNCZ04LM) on Gateway 3 (ZDMWG02LM) with firmware 1.4.6_0043. The status, power consumption and total power are shown correctly.
I know it is not fully supported on this firmware, but would like to report it anyway so this can be corrected in the future (hopefully) and other people with the same issue have a reference for a known issue.

This is very buggy firmware. I have many this plug on 0012. They always works fine


shaka-bot improvements for PR.

Is it possible for shaka-bot to automatically test PRs when a mention is made?
Is it possible that in each new commit in the PR, a build (linter, misspelling, externs, etc.) is passed automatically?

This is something I've given some thought to.  So long as we're running tests on our private build server, we need to have human review first.  Otherwise we could open ourselves up to security issues where someone could run arbitrary code on that server through a PR.  Even without root access, that could be bad.
If we migrate most of our testing to GitHub Actions, then we could have PRs tested automatically on GitHub's temporary containers without any serious risk.  This is something I've been looking into in the past couple days.
For now, please accept our apologies for delays in review and testing.


TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX with docker-compose.yml

Hi,
I am using a docker-compose.yml for my tests:
version: '3.4'

services:
  elastic:
    image: elasticsearch:7.9.2
[...]

and try to use a private docker registry when running the tests:
export TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX=<my registry>
./gradlew clean test

Nevertheless, it seems that my default registry is not picked up for the images defined in  docker-compose.yml (but it is for the ones used internally by testcontainer such  as testcontainers/ryuk.
I went to this conclusion by checking docker image ls which doesn't return the images prefixed by the private registry.
Do I miss something or does TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX not work with docker-compose.yaml?
I'm using org.testcontainers:testcontainers:1.15.3

Same thing.


All 2.10.2 ROCKs

This PR contains all the rockctaft specs and sanity tests for the following Harbor images:

docker.io/goharbor/nginx-photon:v2.10.2
docker.io/goharbor/harbor-portal:v2.10.2
docker.io/goharbor/harbor-core:v2.10.2
docker.io/goharbor/harbor-jobservice:v2.10.2
docker.io/goharbor/registry-photon:v2.10.2
docker.io/goharbor/harbor-registryctl:v2.10.2
docker.io/goharbor/trivy-adapter-photon:v2.10.2
docker.io/goharbor/harbor-db:v2.10.2
docker.io/goharbor/redis-photon:v2.10.2
docker.io/goharbor/harbor-exporter:v2.10.2

Sanity tests all pass on my fork.
Loose ends are:

changing the k8s-test-hardness repo URL to point to the upstream one once this merges: https://github.com/canonical/k8s-test-harness/pull/5
adding the integration tests (currently completely missing)

Merging as only the upload fails (because of external contributor)


Failed to install Web RTC in my project. How do i resolve this issue

Using Visual Studio 2017
Severity	Code	Description	Project	File	Line	Suppression State
Error		Could not install package 'WebRtc 1.54.2'. You are trying to install this package into a project that targets '.NETFramework,Version=v4.6.2', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.			0

I have no idea what WebRtc is. Please provide more context

I'm not sure how this is related to BMVC. An unrelated package is failing
to install...
On Tue, Aug 15, 2017, 12:33 TapiwaMushipe<EMAIL_ADDRESS>wrote:

its a framework in that enable Real Time Communications like videos,
audios. So i am trying to implement the framework in my project for a video
chat app but its saying package does not contain any assembly references
and have changed my .NETFramework version to v4.6.2 till v4.7 but it still
refuses to install
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/DmitryEfimenko/TwitterBootstrapMvc/issues/456#issuecomment-322443931,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACAD_94_nrlikVSuJttOhjKq2NctUw-uks5sYYHwgaJpZM4O2KCi
.


Comment order issue

Describe your problem(s)
When I add a comment it's added to the bottom. But once I refresh, it comes to the top.  The former has to be fixed.

Duplicate https://github.com/wso2/product-apim/issues/10732
Fixed with https://github.com/wso2/carbon-apimgt/pull/10226


Linux Discord Server

What is your username and discriminator?
thatlizarddude#2353
Why did you join Discord Linux?
To discuss Linux distributions.
Where did you hear about Discord Linux?
In another Discord server.
What is the passphrase that was assigned to you by the bot?
N/A

From simonizor#0420 :
The passphrase you have entered is not correct.  Please check the message that mentions you in the welcome channel to find your passphrase.


[BEAM-158] add support for bounded sources in streaming

Apart from a few improvements, this PR introduces bounded sources in streaming. The BoundedSource wrapper (SourceInputFormat) is the same as for the batch part of the runner. The translator assigns ingestion time watermarks and processing time timestamps upon reading from the source. We could make this more flexible in terms of watermark generation if we had an UnboundedSource wrapper for a BoundedSource.
Perhaps we could have common utility for runners to deal with serialization of PipelineOptions. At some point, they have to be shipped. I had to change the serialization code because I was experiencing a serialization bug which led to a serialization loop. Debugging this was almost impossible because the stack trace doesn't show all serialization calls due to some magic in the VM. I didn't find any cyclic references between the PipelineOptions and Flink components. I'm assuming this is a bug and the workaround using byte array serialization of the options is fair enough. See SourceInputFormat.

I suggest R=@dhalperi for a second pair of eyes on the I/O bits, and perhaps ideas from @lukecwik on the pipeline options.

Incorporated the suggestions. Would like to merge later on.

LGTM. I left one comment, but merge as you see fit!

(And a gentle reminder to squash CLs as appropriate)

Hi @mxm, just a ping that (AFAIK) this is ready for you to merge.

Hi @mxm, just a ping that this is ready for you to rebase and merge.

Hi @dhalperi, I was completely knocked out for a week. Will merge this later on.

Rebased and merged accordingly.

Hope you're feel better!

Thanks, much better :)


deck.gl port

@OmarShehata by any chance would you have any knowledge in deck.gl ?
I am struggling to port your outline pass to deck.gl
They have an effects/pass system which should allow me to get the normalBuffer but i am not seeing how to do it :s
Thought it was worth asking.
Thanks

Hey @farfromrefug , I have worked a bit with Deck.gl. Can you push what you have so far to a repo/codesandbox/Glitch etc? I can try and take a look sometime this week.

@OmarShehata first thanks a lot for answering!
I set up a repo here https://github.com/farfromrefug/3dmap_webgl with what i have so far.
So after looking a lot at the deck.gl codes and at your three js version i felt like "copying" the deck.gl pass for shadow was the right way to start. It was using a depthBuffer which was necessary for my port.
So i kind of put all in place but then i am pretty much stuck:

dont know how to setup the normalBuffer
feels like i have what i want in outline.js but not sure how to have the readDepth glsl function working. Should i use a projection matrix like it is done in the shadow pass here

I am kind of new to all that webgl stuff and i am learning as i go :D
Hope i did enough for you to take a look at it.
Again thanks a lot for even looking at this!

Thanks for putting your code up @farfromrefug ! I wasn't able to run it because it looks like I need some local elevation data (http://localhost:8080/data/BDALTIV2_75M_rvb) ? I just see a white screen with lines & labels.
But seeing this helps. I think porting to Deck.gl will be a bit tricky. The normal buffer is the hardest part of this effect because it's not a standard thing engines typically support. To do this you'll need a way to render to texture (looks like Deck.gl doesn't officially support this? https://github.com/visgl/deck.gl/issues/3313) You need this because you need to re-render the scene, but instead of using a default material, you'll create a custom material that colors the terrain using the normals.
If the engine doesn't support custom materials, that step will be tricky too. This isn't supported directly by CesiumJS either, but I have a forum post here describing how to change the terrain shader to render the normals (https://community.cesium.com/t/forcing-a-low-poly-look-on-cesium3dtileset/9344/4?u=omar). So if you were doing it in CesiumJS you'd create a uniform boolean that is passed to that shader, so you render the scene once normally, then once with the normals, and save that to the texture, and that's your normal buffer.
For what it's worth, in CesiumJS the globe materials here are the closest thing that combines all the pieces you need: https://sandcastle.cesium.com/?src=Globe Materials.html. These effects are created as shaders that have access to the terrain's normal and aspect. So the easiest route there would be modifying one of those built-in shaders.

I would definitely love to see more geospatial engines support creating effects like this more easily, have you posted your question in the Unfolded community (https://unfolded.page.link/slack-signup) ? Perhaps that'll help generate some interest to support some of these fundamental pieces (render to texture, custom materials) similar to how PlayCanvas and ThreeJS do.

@OmarShehata First thanks a lot for looking into this and taking the time to answer!
I also would love to be able to do that in all the geo libs around. recently i also discovered iTowns which is pretty good too.
Now in my use case i need a very "slim" one because i run it in a special environment (kind of like React Native with direct bindings from JS to OpenGL, except it is not ReactNative but Nativescript :))

Three.js: amazingly slim but quite hard to get the all geo spatial thing running smoothly
deck.gl: Pretty amazing result but missing oultine support(not possible yet) like you explained
cesium: A bit bigger and still missing outline support, though as you explained it would be easier to implement. I am also not sure about rendering  the labels like i do (on screen see screenshot below).
itown: much bigger. Post processing seems quite easy. not sure about normals yet.

I am on the deck.gl slack. Will ask there pointing to this discussion as i find it very interesting and self explanatory.
https://user-images.githubusercontent.com/655344/116363136-1bd14580-a803-11eb-9a3e-6f2273206e13.mp4

itown: much bigger. Post processing seems quite easy. not sure about normals yet.

iTowns is ThreeJS based so this should be the easiest one to get working! In fact it should "just work" with the current code if it's using the latest version of ThreeJS. I would:

Look for any iTowns examples using EffectComposer, which will allow you to render all the different passes you need for this effect, like here: https://github.com/OmarShehata/webgl-outlines/blob/9a7d67298346a64252ba2c1c0be89400316cecbb/threejs/src/index.js#L45
Otherwise, you may need to look for something like renderer.render( scene, camera ); if that's handled internally by iTowns, you'll need to override that (because that needs to be replaced by the effect composer, which handles rendering all the layers)
If you can get a reference to the ThreeJS scene in iTowns, you can set the overrideMaterial, which is how this effect draws the normal buffer (it renders the scene with everything using this special material): https://github.com/OmarShehata/webgl-outlines/blob/9a7d67298346a64252ba2c1c0be89400316cecbb/threejs/src/CustomOutlinePass.js#L61

Best of luck! I'd be very interested if you're able to get this working with any of the libraries, if you're able to share the technique/code publicly. I think it'd be very useful for others.

@OmarShehata yes i will try to get it to work for as many libraries as possible. I ll make PRs here if i get it.
also today i discovered this https://github.com/tentone/geo-three And it is pretty cool for my need.
Very slim and also has a very nice feature: height computed through GPU!
I need to try and port your code so that it work with it.

geo-three looks very cool, thanks for sharing! I hadn't encountered it before.

@OmarShehata kind of got what i want with geo-three
I might need your help on something i want to change.
In the gif below we can see that "terrain" get accentuated as you further a way from them.
I would like the contrary. The reason is that if you look very far away it almost all white and hard to "understand" the terrain. I am thinking that if i manage to inverse the effect i would get a better result. I tried to play with multiplierParameters but i could not find where i could inverse the effect. Do you have any idea if this would be possible? not sure you even get what i mean...

@farfromrefug I get what you mean. I think what's happening here is that differences in depth further away from the camera are smaller, due to less precision. So if the shader says "color anything white as long as the depth difference between it and the closest pixel is bigger than 0.1", that may represent a smaller distance close to camera than further.
If that is the case (and I would corroborate this by confirming this effect is coming from the depth diff. Try setting normalMultiplier to 0. If you still see the same behavior then it is indeed the depth issue), then the real solution is a reverse depth buffer or logarithmic depth buffer (see https://gamedev.stackexchange.com/questions/117995/why-does-reverse-depth-buffering-provide-more-precision-with-dxgi-format-d24-u and https://outerra.blogspot.com/2009/08/logarithmic-z-buffer.html) or multiple frustums, both of which are more of an engine change.
The easier option is just instead of using a constant:

"color anything white as long as the depth difference between it and the closest pixel is bigger than 0.1"

Tweak that value based on how far away this pixel is from the camera (which is the depth value itself)

"color anything white as long as the depth difference between it and the closest pixel is bigger than 0.1 x current_depth"

The other alternative is a geometry-based outlines algorithm, which would look the same regardless of distance (as opposed to this screen-spaced based one), which I've been wanting to find the time to look into.

@OmarShehata Thank you so much for your insight on all of this . It is pretty awesome and it is what i figured. I also that the same thing happens with normals diffs and actually seem to have a bigger effect.
I tweaked the multipliers here and ended up with this for now which i am already happy with (looks better when you open the browser dev settings and simulate a mobile phone)
https://farfromrefug.github.io/geo-three/examples/
I already tried your idea of taking into account the depth to color the value. But i had a side effect of "losing" major outlines (between the terrain and the sky) at distance. Need to push this further
Thank you!

Very cool, thanks for sharing your progress here! It definitely makes me curious about exploring other techniques that may be more suitable for the geo context. I know Mapbox for example has a layer that bakes in these lines one way to generate lines that are consistent and look good (do it offline) https://docs.mapbox.com/studio-manual/examples/hillshade/


⚠ ClamAV has degraded performance

In 3229261, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 199 ms

Resolved: ClamAV performance has improved in 7d84b1f.


RHIDP-4264

Description
Please explain the changes you made here.
Which issue(s) does this PR fix

Fixes #?

PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

/test-e2e

/test-e2e

/test all

/test all

/test all

/test all

/test all

/test all

/test all


Turkish characters all missing

These are Turkish characters and missing . For more information you can find in here https://www.ascii-codes.com/cp857.html . In extended character set.

Hi, thanks for reporting this. The site has been updated. Could you please check if the issue still exists and let us know your response.
Regards!

Closing this issue for now. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this or open a new one. We'll gladly take a look again!


Can we use hls js for parsing the url to play on shaka player?

hls.js and Shaka Player are parallel projects.  It would not make sense to use them together.  It's not clear what you mean about "parsing the URL to play".  In Shaka Player, you pass the master playlist URL to player.load().  There's no parsing to be done for that.
Does this help?

yes . Thank you


add cacheSearchTerm option

Add cacheSearchTerm option (defaults to true, the same behavior as before) to mitigate https://github.com/oferh/ng2-completer/issues/168
To fix the issue set cacheSearchTerm attribute of the ng2-completer to true.
Also add index.ts file, so ng2-completer could be installed from github like this: "yarn add yarn add https://github.com/oferh/ng2-completer

thanks for the PR.
there is already an index.ts under src

Top-level index.ts is a copy of src one, with "src/" added to all import paths
Without this top-level index.ts it isn't possible to simply install the ng2-completer from the github via yarn or npm (it is possible if you edit your source to import from ng2-completer/src instead of ng2-completer).
If you don't like it you could remove it, but then I'd have to use my fork where there is ./index.ts .

can you split it to 2 PR's?
I think that changing typings path in package.json should be the solution for the location of index.ts.

Ok, removed index.ts for now (but left that commit unchanged because I already depend on it in my project), will do something about index.ts or typings in the next PR

can you change it so that CompleterData can pass a resetDataSource flag that will trigger the term reset?

can you add a description to the README?

version 1.5.4 now includes dataSourceChange event in CompleterData when it is fired CtrList will clear the cached term.

@oferh do you know when this PR will be merged? I am using cacheSearchTerm in my fork, but I am waiting to revert to your repository as a dependency in my project. Thanks.


vegeta: 12.11.0 -> 12.11.1

Signed-off-by: Muhammad Falak R Wani<EMAIL_ADDRESS>Description of changes
Diff: https://github.com/tsenart/vegeta/compare/v12.11.0...v12.11.1
Changelog: https://github.com/tsenart/vegeta/releases/tag/v12.11.1

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2711


Add deps badge to README

Hi Akash,
this PR pitches my latest project for the Elixir community:

This badge shows you an analysis for your dependencies. Behind the badge works a CI service written in Elixir which can notify you whenever important updates for your Hex packages are released. This is still in its infancy, and I want to basically invite you to join the beta to test-drive this.
I really believe that we can create a great service for the community with this. That said, I can imagine several reasons why you would not want to have this in your README. So don't feel any obligation, just tell me what you think!

Hi @rrrene, your project looks very nice, thank you for all the great work!
I think this will serve the community a lot to avoid the dependency hell we see in many ecosystems (Haskell is at the top of my list :sweat:)
I am very sure we can merge this, but I will leave open so @HashNuke can take a look at your project :smile:

@rrrene Thank you for the work on HexFaktor and for sending this PR. Being able to track deps is nice.
Merging it right away.


Editing index.html does not trigger a reload

I'd say this is pretty minor, but I noticed when I updated my index.html <title> it did not trigger a browser reload. I did however see it on manual refresh.
I also noticed that I wasn't exactly clear on how index.html maps to index.js, when I started digging through webpack.config.dev.js. I saw a few comments in there, while looking through it briefly to see if I could resolve this locally and perhaps send a PR. I'm extremely new to webpack, so I don't dig around in here too much yet (and I don't eject really either).
Thanks!

I also noticed that this is happening. Weird though, because react-scripts seems to use html-webpack-plugin when using that package, it takes care of the live-reloading. Also interesting is that when saving index.html, it does re-compile.

Debugged this a little further; because hot modus is enabled, webpack-dev-server doesn't perform a page reload itself, but passes the hot update through to the window so the bundle can perform a XHR request to get the hot updates. However, and I don't know why, it should fall back to the reloading the page if it can't find the hot update.

@SpaceK33z I am seeing the same issue when editing any of the JS files with this configuration - is this the same issue:
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

@SpaceK33z I am seeing the same issue when editing any of the JS files with this configuration - is this the same issue:

If edits to JS don’t reload the page, please check https://webpack.github.io/docs/troubleshooting.html#watching.
In particular, “safe write” option in some IDEs might cause this: https://webpack.github.io/docs/webpack-dev-server.html#working-with-editors-ides-supporting-safe-write

Please help beta test the new version that includes this change!
https://github.com/facebookincubator/create-react-app/issues/2172