Sorts s_center to improve search

Note: this PR builds upon the work by @amarzot-yesware  to allow the use of custom objects, as well as my other PR  in which point_search was fixed.

Adds a new parameter that defaults to true which controls whether the result is sorted or not, resulting in faster query speeds  when set to false.
s_center is sorted in divide_intervals as to increase the speed of the point_search method. Specs and search methods modified accordingly.
Linted code and removed duplicate method calls

I decided to benchmark this PR's approach for searching the node. I did this by constructing a node with some number of overlapping intervals (as they would be constructed in the tree) and trying different searching algorithms.
Context
Algorithms Benchmarked

search_node refers to the current implementation
search_node_sorted refers to the implementation from this PR
search_node_bsearch is my attempt at a faster searching algortihm

Timing
Here is an explanation of the types of timings in the output (user, system, etc.) https://gist.github.com/anildigital/1229896
Types of Queries
left query, centered query, and right query refer to how the query interval relates to the x_center of the node. left queries are entirely to the left of the center, centered queries overlap, and right queries are entirely to the right.
                                        x_center
                                            |
|---left query---|      |--centered query---|--|             |---right query---|
                                        |---|--centered query--|
                                            |

I ran the benchmarks with different numbers of intervals in s_center (from 1..10) and with each type of query. Each time is the result of calling the respective function 1,000,000 times. In addition to defining the type of query I also benchmarked with 'benchmark-ips' and random queries to get a better feel.
Results
The results are as follows (with analysis and code afterwards):

Benchmark Query Types
RUBY_VERSION => "3.0.0"
>>> Intervals: 1 ***************************************************************
                           user     system      total        real
>> left query --------------------------------------------------------
search_node        :   0.294283   0.000423   0.294706 (  0.295249)
search_node_sorted :   0.321450   0.000893   0.322343 (  0.323031)
search_node_bsearch:   0.344577   0.000515   0.345092 (  0.345597)
>> centered query ----------------------------------------------------
search_node        :   0.271940   0.000380   0.272320 (  0.273070)
search_node_sorted :   0.318535   0.000614   0.319149 (  0.319852)
search_node_bsearch:   0.367545   0.000615   0.368160 (  0.368673)
>> right query -------------------------------------------------------
search_node        :   0.275326   0.000611   0.275937 (  0.276416)
search_node_sorted :   0.318272   0.000717   0.318989 (  0.319567)
search_node_bsearch:   0.492927   0.000730   0.493657 (  0.494747)
>>> Intervals: 2 ***************************************************************
                           user     system      total        real
>> left query --------------------------------------------------------
search_node        :   0.345919   0.000590   0.346509 (  0.347349)
search_node_sorted :   0.478631   0.000768   0.479399 (  0.480321)
search_node_bsearch:   0.477955   0.000700   0.478655 (  0.479515)
>> centered query ----------------------------------------------------
search_node        :   0.404176   0.000944   0.405120 (  0.406228)
search_node_sorted :   0.497447   0.000973   0.498420 (  0.499066)
search_node_bsearch:   0.366595   0.000562   0.367157 (  0.367870)
>> right query -------------------------------------------------------
search_node        :   0.397719   0.000684   0.398403 (  0.398869)
search_node_sorted :   0.494382   0.000784   0.495166 (  0.495986)
search_node_bsearch:   0.501929   0.000716   0.502645 (  0.503245)
>>> Intervals: 3 ***************************************************************
                           user     system      total        real
>> left query --------------------------------------------------------
search_node        :   0.469805   0.000498   0.470303 (  0.471141)
search_node_sorted :   0.648218   0.001123   0.649341 (  0.650667)
search_node_bsearch:   0.502000   0.000781   0.502781 (  0.503568)
>> centered query ----------------------------------------------------
search_node        :   0.509840   0.000565   0.510405 (  0.510967)
search_node_sorted :   0.644760   0.000841   0.645601 (  0.646534)
search_node_bsearch:   0.368921   0.000554   0.369475 (  0.369940)
>> right query -------------------------------------------------------
search_node        :   0.523597   0.000866   0.524463 (  0.525806)
search_node_sorted :   0.651550   0.000698   0.652248 (  0.652764)
search_node_bsearch:   0.571649   0.000815   0.572464 (  0.573079)
>>> Intervals: 4 ***************************************************************
                           user     system      total        real
>> left query --------------------------------------------------------
search_node        :   0.662972   0.001529   0.664501 (  0.666598)
search_node_sorted :   0.823046   0.001221   0.824267 (  0.825586)
search_node_bsearch:   0.464917   0.000611   0.465528 (  0.466402)
>> centered query ----------------------------------------------------
search_node        :   0.657194   0.001182   0.658376 (  0.659535)
search_node_sorted :   0.831549   0.001223   0.832772 (  0.834295)
search_node_bsearch:   0.377436   0.000624   0.378060 (  0.378636)
>> right query -------------------------------------------------------
search_node        :   0.639606   0.000872   0.640478 (  0.641647)
search_node_sorted :   0.794061   0.001227   0.795288 (  0.796666)
search_node_bsearch:   0.640082   0.001056   0.641138 (  0.642146)
>>> Intervals: 5 ***************************************************************
                           user     system      total        real
>> left query --------------------------------------------------------
search_node        :   0.769376   0.001229   0.770605 (  0.771601)
search_node_sorted :   1.004979   0.001338   1.006317 (  1.008085)
search_node_bsearch:   0.428967   0.000775   0.429742 (  0.430589)
>> centered query ----------------------------------------------------
search_node        :   0.749577   0.001233   0.750810 (  0.751987)
search_node_sorted :   1.047059   0.001725   1.048784 (  1.050457)
search_node_bsearch:   0.388979   0.000700   0.389679 (  0.390126)
>> right query -------------------------------------------------------
search_node        :   0.761358   0.001011   0.762369 (  0.763245)
search_node_sorted :   1.005419   0.001159   1.006578 (  1.007741)
search_node_bsearch:   0.581907   0.001079   0.582986 (  0.583866)
>>> Intervals: 6 ***************************************************************
                           user     system      total        real
>> left query --------------------------------------------------------
search_node        :   0.791082   0.000830   0.791912 (  0.793027)
search_node_sorted :   1.134816   0.001724   1.136540 (  1.137947)
search_node_bsearch:   0.569002   0.000991   0.569993 (  0.571081)
>> centered query ----------------------------------------------------
search_node        :   0.891427   0.001421   0.892848 (  0.894489)
search_node_sorted :   1.231044   0.002040   1.233084 (  1.234685)
search_node_bsearch:   0.390488   0.000711   0.391199 (  0.391803)
>> right query -------------------------------------------------------
search_node        :   0.855732   0.001264   0.856996 (  0.858243)
search_node_sorted :   1.206386   0.001371   1.207757 (  1.208807)
search_node_bsearch:   0.587420   0.000684   0.588104 (  0.588948)
>>> Intervals: 7 ***************************************************************
                           user     system      total        real
>> left query --------------------------------------------------------
search_node        :   0.938393   0.001617   0.940010 (  0.941799)
search_node_sorted :   1.414355   0.001930   1.416285 (  1.418304)
search_node_bsearch:   0.573533   0.000826   0.574359 (  0.575299)
>> centered query ----------------------------------------------------
search_node        :   0.967661   0.001419   0.969080 (  0.970986)
search_node_sorted :   1.425753   0.002027   1.427780 (  1.429500)
search_node_bsearch:   0.384979   0.000723   0.385702 (  0.386714)
>> right query -------------------------------------------------------
search_node        :   0.985602   0.001275   0.986877 (  0.988527)
search_node_sorted :   1.423696   0.001781   1.425477 (  1.427529)
search_node_bsearch:   0.667344   0.000931   0.668275 (  0.669350)
>>> Intervals: 8 ***************************************************************
                           user     system      total        real
>> left query --------------------------------------------------------
search_node        :   1.096039   0.001490   1.097529 (  1.099284)
search_node_sorted :   1.629541   0.002240   1.631781 (  1.634775)
search_node_bsearch:   0.530544   0.000905   0.531449 (  0.532137)
>> centered query ----------------------------------------------------
search_node        :   1.091209   0.001074   1.092283 (  1.093627)
search_node_sorted :   1.602735   0.002120   1.604855 (  1.606814)
search_node_bsearch:   0.393407   0.000901   0.394308 (  0.395315)
>> right query -------------------------------------------------------
search_node        :   1.121127   0.001515   1.122642 (  1.124060)
search_node_sorted :   1.622824   0.002044   1.624868 (  1.626561)
search_node_bsearch:   0.671208   0.001137   0.672345 (  0.673149)
>>> Intervals: 9 ***************************************************************
                           user     system      total        real
>> left query --------------------------------------------------------
search_node        :   1.123871   0.001629   1.125500 (  1.127536)
search_node_sorted :   1.617628   0.001970   1.619598 (  1.622036)
search_node_bsearch:   0.565249   0.000585   0.565834 (  0.566251)
>> centered query ----------------------------------------------------
search_node        :   1.204953   0.001744   1.206697 (  1.208608)
search_node_sorted :   1.778111   0.002461   1.780572 (  1.782756)
search_node_bsearch:   0.423217   0.000658   0.423875 (  0.424780)
>> right query -------------------------------------------------------
search_node        :   1.275738   0.001736   1.277474 (  1.279188)
search_node_sorted :   1.784942   0.002243   1.787185 (  1.788962)
search_node_bsearch:   0.835533   0.001431   0.836964 (  0.839916)
>>> Intervals: 10 **************************************************************
                           user     system      total        real
>> left query --------------------------------------------------------
search_node        :   1.294349   0.001877   1.296226 (  1.297781)
search_node_sorted :   1.792679   0.002953   1.795632 (  1.801279)
search_node_bsearch:   0.576735   0.000672   0.577407 (  0.577920)
>> centered query ----------------------------------------------------
search_node        :   1.368983   0.002562   1.371545 (  1.377482)
search_node_sorted :   1.930898   0.002259   1.933157 (  1.934894)
search_node_bsearch:   0.392094   0.000681   0.392775 (  0.393237)
>> right query -------------------------------------------------------
search_node        :   1.346151   0.001161   1.347312 (  1.348517)
search_node_sorted :   1.927809   0.002533   1.930342 (  1.933438)
search_node_bsearch:   0.760859   0.001203   0.762062 (  0.763728)

Benchmark IPS
>>> Intervals: 1 ***************************************************************
Warming up --------------------------------------
search_node        :   105.392k i/100ms
search_node_sorted :   101.250k i/100ms
search_node_bsearch:    93.668k i/100ms
Calculating -------------------------------------
search_node        :      1.023M (± 4.7%) i/s -      5.164M in   5.057773s
search_node_sorted :    998.401k (± 2.1%) i/s -      5.062M in   5.072925s
search_node_bsearch:    917.404k (± 2.1%) i/s -      4.590M in   5.005239s
>>> Intervals: 2 ***************************************************************
Warming up --------------------------------------
search_node        :    91.874k i/100ms
search_node_sorted :    84.642k i/100ms
search_node_bsearch:    91.686k i/100ms
Calculating -------------------------------------
search_node        :    902.519k (± 5.0%) i/s -      4.502M in   5.002602s
search_node_sorted :    831.617k (± 3.6%) i/s -      4.232M in   5.095898s
search_node_bsearch:    882.119k (± 3.9%) i/s -      4.493M in   5.101410s
>>> Intervals: 3 ***************************************************************
Warming up --------------------------------------
search_node        :    82.912k i/100ms
search_node_sorted :    71.660k i/100ms
search_node_bsearch:    82.199k i/100ms
Calculating -------------------------------------
search_node        :    818.151k (± 2.8%) i/s -      4.146M in   5.071190s
search_node_sorted :    739.639k (± 3.2%) i/s -      3.726M in   5.043409s
search_node_bsearch:    859.761k (± 3.2%) i/s -      4.357M in   5.072533s
>>> Intervals: 4 ***************************************************************
Warming up --------------------------------------
search_node        :    76.066k i/100ms
search_node_sorted :    66.578k i/100ms
search_node_bsearch:    86.782k i/100ms
Calculating -------------------------------------
search_node        :    751.632k (± 2.3%) i/s -      3.803M in   5.062856s
search_node_sorted :    660.350k (± 4.7%) i/s -      3.329M in   5.054221s
search_node_bsearch:    865.556k (± 2.5%) i/s -      4.339M in   5.016253s
>>> Intervals: 5 ***************************************************************
Warming up --------------------------------------
search_node        :    68.025k i/100ms
search_node_sorted :    59.840k i/100ms
search_node_bsearch:    86.743k i/100ms
Calculating -------------------------------------
search_node        :    685.046k (± 2.5%) i/s -      3.469M in   5.067622s
search_node_sorted :    589.422k (± 4.1%) i/s -      2.992M in   5.086056s
search_node_bsearch:    856.151k (± 4.0%) i/s -      4.337M in   5.074753s
>>> Intervals: 6 ***************************************************************
Warming up --------------------------------------
search_node        :    65.648k i/100ms
search_node_sorted :    50.798k i/100ms
search_node_bsearch:    86.379k i/100ms
Calculating -------------------------------------
search_node        :    636.683k (± 2.7%) i/s -      3.217M in   5.056001s
search_node_sorted :    527.625k (± 4.5%) i/s -      2.641M in   5.017275s
search_node_bsearch:    836.447k (± 3.7%) i/s -      4.233M in   5.067301s
>>> Intervals: 7 ***************************************************************
Warming up --------------------------------------
search_node        :    58.337k i/100ms
search_node_sorted :    49.168k i/100ms
search_node_bsearch:    84.843k i/100ms
Calculating -------------------------------------
search_node        :    596.302k (± 2.8%) i/s -      3.034M in   5.091405s
search_node_sorted :    496.595k (± 3.8%) i/s -      2.508M in   5.057162s
search_node_bsearch:    814.451k (± 4.8%) i/s -      4.072M in   5.012782s
>>> Intervals: 8 ***************************************************************
Warming up --------------------------------------
search_node        :    54.488k i/100ms
search_node_sorted :    46.428k i/100ms
search_node_bsearch:    83.828k i/100ms
Calculating -------------------------------------
search_node        :    545.984k (± 3.7%) i/s -      2.779M in   5.096794s
search_node_sorted :    458.736k (± 4.0%) i/s -      2.321M in   5.068991s
search_node_bsearch:    816.489k (± 3.4%) i/s -      4.108M in   5.036792s
>>> Intervals: 9 ***************************************************************
Warming up --------------------------------------
search_node        :    50.337k i/100ms
search_node_sorted :    43.065k i/100ms
search_node_bsearch:    82.861k i/100ms
Calculating -------------------------------------
search_node        :    500.379k (± 4.0%) i/s -      2.517M in   5.038098s
search_node_sorted :    418.650k (± 3.8%) i/s -      2.110M in   5.048243s
search_node_bsearch:    803.520k (± 3.6%) i/s -      4.060M in   5.059793s
>>> Intervals: 10 **************************************************************
Warming up --------------------------------------
search_node        :    47.949k i/100ms
search_node_sorted :    40.537k i/100ms
search_node_bsearch:    83.422k i/100ms
Calculating -------------------------------------
search_node        :    478.889k (± 3.8%) i/s -      2.397M in   5.013619s
search_node_sorted :    396.956k (± 3.8%) i/s -      1.986M in   5.011312s
search_node_bsearch:    803.695k (± 3.8%) i/s -      4.088M in   5.093751s

Analysis
There are a few main points I'd like to highlight.

search_node_sorted is slower than search_node for all interval counts tested. Because of this I think that this PR should not include this implementation. As to why it's slower I think it's because each is slow, but I'm not sure.
search_node_bsearch is faster on average when s_center has 3 intervals or more (and faster for all query types at 4 intervals or more). I would have a discussion and see what people think about this option and whether (if at all) we should bring it in.
These are certainly not the only algorithms (nor the only ways to implement them), so improvements should be suggested

Benchmark Script & Code: https://gist.github.com/amarzot-yesware/dc8aea0e9970e92c86cb35389254c8a9
Branch on my fork: https://github.com/amarzot-yesware/interval-tree/tree/faster_node_search

I was just re-reading the interval tree wikipedia page and it describes exactly the approach I implemented in my branch.

Hi @amarzot-yesware, thanks for your in-depth benchmarking and explanation.
I would imagine that in most applications, having 4 or more intervals is the norm, so I believe it would be reasonable to bring in your approach instead of the current one.
From this PR I would suggest keeping the :sort option, though. A sorted output is not always needed and can slow things down in larger data sets especially when called repeatedly in a loop, which is what I'm encountering in one of my projects right now.

I would imagine that in most applications, having 4 or more intervals is the norm,

The trick is having 4 or more intervals per node, but maybe that it what you meant, and maybe that too is the norm (i'd imagine it is).

The approach from this PR should be faster for point searches.

As you recommended on my gist, I'll do some benchmarking to confirm and post results.

As you recommended on my gist, I'll do some benchmarking to confirm and post results.

Thank you, much appreciated.

The requested changes and feedback were taken into account in the last push. The sorted parameter was removed since s_center is being sorted when dividing intervals in this PR, so ordering it at the end again may have been unnecessary. I think this was responsible for making this implementation slower than the current one.
The unique parameter was left as true to conform with the current implementation, but we should consider leaving it off per default  since uniq is pretty slow.
Linting changes with Rubocop were kept separate in another commit, as well as the removal of duplicate method calls that Reek was complaining about. Personally I think it affects readability negatively, but it may be worth it in case it makes the code more efficient. I also checked the code with Fasterer and it did not report the use of each over for as an issue.
The previous benchmarks did not take point searches in account. It would be interesting to see a comparison between the approaches in this regard, the impact of uniq, and the last few changes. (I tried running the benchmarking code but haven't gotten it to work yet)

Hi,
the latest commit improves the speed of stabbing queries by further 55% by taking the maximum interval end within the node into account. In total, the the speed gains amount to 70%. Below are the benchmarking results:

Benchmarks

Generating 10000 intervals starting in range [0...100000]
Generating 100000 queries
Recursive implementation with one list per node, using average (s_center not sorted)
Total elapsed time: 5.6156
Recursive implementation with one list per node, using median (s_center not sorted)
Total elapsed time: 5.8209
Iterative implementation with one list per node using average (s_center sorted), not taking maximum interval end into account [Previous version]
Total elapsed time: 2.6065
Iterative implementation with one list per node using average (s_center sorted), taking maximum interval end into account [Pushed version]
Total elapsed time: 1.1675
Iterative implementation with one list per node using median (s_center sorted), taking maximum interval end into account
Total elapsed time: 1.1841
Iterative implementation with two lists per node, using average (s_center sorted)
Total elapsed time: 1.6631
Iterative implementation with two lists per node, using median (s_center sorted)
Total elapsed time: 1.6696
Iterative implementation with two lists per node, using average (s_center sorted), taking maximum interval end into account
Total elapsed time: 7.0531
Using average (s_center sorted), taking maximum interval end into account, no rationals
Total elapsed time: 1.0983
Using median (s_center sorted), taking maximum interval end into account, no rationals
Total elapsed time: 1.1264

Code is available here.
I've played around with centering the intervals using the median of the values instead of the mean but this wasn't faster, even though it should result in more balanced trees. Storing two lists per node was also not quicker.
By not casting to rationals the performance improves a bit, but then the time ranges stop working.
Any updates on #13 being merged?

@danielpetri1 wrote:

Any updates on #13 being merged?

Unfortunately we (the GreenSync team) are finding that we do not have the resources to actively maintain this gem. We are also no longer using it ourselves which makes it difficult to make decisions about what direction to take development in.
With that in mind, we are looking for a new maintainer. Seeing as you've been active in making PRs against interval-tree recently, is this a role you would consider taking on?

I'd be interested, yes, although @amarzot-yesware seems to have quite a few good ideas here besides being quite experienced. If they're not interested I could give it a shot.

@maddymarkovitz @danielpetri1 I appreciate the offer! I would certainly be interested, but I'm not sure I have the bandwidth to be a full time maintainer. If @danielpetri1 would be up for it, I would join them as a co-maintainer. Another thing to note is that this is my work account. If I were to be a maintainer, I'd prefer to use my personal account @amarzot

@danielpetri1 @amarzot-yesware we're still looking for maintainers if you guys are interested :)


PLAT-62228: Set a 5way key mode when pressing a key to focus an item

Issue Resolved / Feature Added
If pressing a page up or down key over the item in a VirtualList with a pointer mode, VirtualList could give focus to the item to move because Spotlight.focus() don't work in a pointer mode.
Resolution
As we did in a VirtualList with the #1778, I forced to call Spotlight.setPointerMode(false)  when pressing a key.
Additional Considerations
I found we also tried to move focus between ScrollButtons when pressing a key. So I also fixed it for this case.
Links
PLAT-62228
Comments
Enact-DCO-1.0-Signed-off-by: YB Sung<EMAIL_ADDRESS>

I created this PR incorrectly. I'd like to create it again.


documentation issue

If you add {% include 'partials/aboutme.html.twig' %} to a page, all you see on the page when viewed is  {% include 'partials/aboutme.html.twig' %}
It took me two hours to figure out that I had to turn on TWIG processing in the page config to get that statement above to work.
For experienced GRAV users this is probably obvious, but this is my first time using GRAV and I didn't know you had to turn on TWIG processing for the plugin to work. Please update the documentation with beginners in mind, thanks!

Hello there,
This is not really an issue, what you did is applicable to every plugin you'll use that uses templates.
Basically this plugin is designed to be used in a template of your theme, of course you can use it in a single page as you did, but activating the TWIG functionality doesn't depend on this plugin or any other for that matter.
Activating TWIG in pages is a Grav functionality, you can find some explanation in the official documentation, specifically how yo activate TWIG in a page https://learn.getgrav.org/admin-panel/page-advanced#overrides

To sum up there is no need to add this in the documentation for this plugin as it's not specific to this plugin.


Remove package-info.java from impl packages

There's no need for package-info.java files in implementation packages, this PR will remove them.

API changes have been detected in com.azure.spring:spring-cloud-azure-core. You can review API changes here

API changes have been detected in com.azure.spring:spring-cloud-azure-service. You can review API changes here

API changes have been detected in com.azure.spring:spring-cloud-azure-resourcemanager. You can review API changes here

API changes have been detected in com.azure.spring:spring-cloud-azure-trace-sleuth. You can review API changes here
API changes
- package com.azure.spring.tracing.sleuth {
-     public class SleuthHttpPolicy implements HttpPipelinePolicy {
-         public SleuthHttpPolicy(Tracer tracer, Propagator propagator)
-         @Override public Mono<HttpResponse> process(HttpPipelineCallContext context, HttpPipelineNextPolicy next)
+ package com.azure.spring.cloud.trace.sleuth {
+     public class SleuthHttpPolicy implements HttpPipelinePolicy {
+         public SleuthHttpPolicy(Tracer tracer)
+         @Override public Mono<HttpResponse> process(HttpPipelineCallContext context, HttpPipelineNextPolicy next)

API changes have been detected in com.azure.spring:spring-messaging-azure. You can review API changes here

API changes have been detected in com.azure.spring:spring-messaging-azure-eventhubs. You can review API changes here

API changes have been detected in com.azure.spring:spring-messaging-azure-servicebus. You can review API changes here

API changes have been detected in com.azure.spring:spring-integration-azure-core. You can review API changes here

API changes have been detected in com.azure.spring:spring-integration-azure-servicebus. You can review API changes here

API changes have been detected in com.azure.spring:spring-cloud-azure-autoconfigure. You can review API changes here

API changes have been detected in com.azure.spring:spring-cloud-azure-actuator. You can review API changes here

/azp run java - spring - ci


variable reference in dependent module

root

mod1
mod2

I only want to run mod2 if there is an output from mod1.
I have declared this in mod2. How do I reference "public_firewall_management_ip" in the .tf file in mod2? I keep getting invalid reference. What is the correct syntax?
dependency "azureInfr" {
config_path = "../azureInfr"
mock_outputs = {
public_firewall_management_ip = "dummy"
public_firewall_management_fqdn = "dummy"
}
}
inputs = {
public_firewall_management_ip = dependency.azureInfr.outputs.public_firewall_management_ip
public_firewall_management_fqdn = dependency.azureInfr.outputs.public_firewall_management_fqdn
}

To reference public_firewall_management_ip in the .tf file, you need to declare a variable block. terragrunt passes on each key value pair in the inputs map as a variable input. This is basically the same as setting each variable using a tfvars file.

Closing as stale. If there is still an issue here, please open a new ticket with the updated context. Thanks!


Emulator Label

SteamDatabase FileDetectionRuleSets links to a few pull requests using this
https://github.com/SteamDatabase/FileDetectionRuleSets/pull/521
Brief explanation of the change
Add a label for Emulator pull requests.

required by 765


Tests fail on most *BSD systems

See subject. An overview of test reports on CPAN Testers: http://matrix.cpantesters.org/?dist=PEF-Front-WebSocket 0.05

I have no idea what wrong on *BSD is. I successfully tested it on Windows and Linux.


Remove IsPromise brand check.

Fixes #41.
(Pending further discussion in #41)

Does this change have any tests?

I’ll need to put up a test262 PR to incorporate these spec changes.


Fix VM Agent RBAC warnings

Recent changes for K8s Node cause VM Agent RBAC warnings regarding service and node. These warnings will flood VM Agent logs.
This change fixes the issue by only initializing the related components for K8s Node case.
Signed-off-by: Mengdie Song<EMAIL_ADDRESS>

I'm not sure which kind of interface you mean and how the implementations will look like as I don't see many things can be abstracted in the run func. I feel it may be doable to have separate runXXX funcs for the two case to sperate the code path. For example:
func run(o *Options) error {
	klog.InfoS("Starting Antrea agent", "version", version.GetFullVersion())
        // Common code
	...
        //
        if o.nodeType == config.K8sNode {
                return runK8sNode(...)
        } else {
                return runExternalNode(...)
        }
}

It looks good to to me to use two separate funcs for the different scenarios.

The commit is not signed

@tnqn I have signed the commit, thanks.

/test-all


Descending rack numbering & space calculation

For version 1.7.0
When adding a device to a rack, the GUI says "The lowest-numbered unit occupied by the device" but it makes more sense for the user to enter the (physical) lowest position.
For racks with descending numbering, this will be the highest rack number, for racks with ascending numbering it will be the lowest rack number.
A little bit more complexity in the code for a more consistent user experience.

I don't see that it makes much difference to be honest, but I'm happy to keep this issue open if you're interested in submitting a pull request.

It doesn't matter to me either way, but I figured I'd chime in to remind whoever does the PR that converting a rack from one type to the other needs to have some extra logic to account for this if it does change.

Closing due to lack of activity.


🐞 - Multiple input in table

Which @taiga-ui/* package(s) are the source of the bug?
cdk
Please provide a link to a minimal reproduction of the bug
No response
Is this issue blocking you?
Blocking
Description
When I am trying to access multiple input fields, the last one is only focusable and all the other inputs before this are not targetable. Acting as they do not exist.
I tried to inspect and examine the behavior of the last input element compared to the other ones. Noticed no differences.
Came to the conclusion that the autofill class or something is the issue. But can't target it either in html or css. (Tui table).

Notice that the last input field is only targetable. The previous ones are ignored.
Angular version
14.2
Taiga UI version
Latest
Which browsers have you used?

[X] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[ ] macOS
[X] Windows
[ ] Linux
[ ] iOS
[ ] Android

@alexKefa Could you please add stackbtliz example?

Unfortunately, I can't reproduce the case on Stackblitz, hence the requests and the scenario seems to be unique.

I am pretty sure it's table.less file on the :before: , :after: pseudo elements. I inspect the DOM and that's what actually triggers. Any tip there?

before/after elements in table are supposed to have pointer-events: none as they are just cosmetic. Can you maybe create a GitHub repo, if it's not possible to reproduce on StackBlitz?

Also before/after elements are part of appearance="table" which is enabled in tuiTable component for inputs, but on your screenshot inputs look like regular textfields.

@alexKefa any change you can create a GitHub repo? Otherwise I don't think we will be able to help.

I guess this issue is stale and can be closed. Feel free to let us know if you still need help.


UI improvement in About Page

Description
Current about page doesn't seem to meet the standard of the website. Please assign this task to me.

Made some changes. Please review my PR

Hi @hs05june we are planning to remove the about page. here is the link for the issue - https://github.com/rohitdasu/projectmate/issues/190
closing the current issue.


ABC iView Unsupported URL UPDATE (Can be deleted)

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.11.07. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.11.07

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[x] Question
[ ] Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
youtube-dl -v "https://iview.abc.net.au/show/spicks-and-specks-reunion-special"
[debug] System config: []
[debug] User config: [u'-o', u'~/Desktop/%(title)s.%(ext)s']
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://iview.abc.net.au/show/spicks-and-specks-reunion-special']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.11.07
[debug] Python version 2.7.10 (CPython) - Darwin-18.2.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg N-92374-gd96ae9d5ea-tessus, ffprobe N-92374-gd96ae9d5ea-tessus
[debug] Proxy map: {}
[generic] spicks-and-specks-reunion-special: Requesting header
WARNING: Falling back on generic information extractor.
[generic] spicks-and-specks-reunion-special: Downloading webpage
[generic] spicks-and-specks-reunion-special: Extracting information
ERROR: Unsupported URL: https://iview.abc.net.au/show/spicks-and-specks-reunion-special
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2324, in _real_extract
    doc = compat_etree_fromstring(webpage.encode('utf-8'))
  File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2542, in compat_etree_fromstring
    doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
  File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2531, in _XML
    parser.feed(text)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed
    self._raiseerror(v)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
    raise err
ParseError: not well-formed (invalid token): line 6, column 634
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 792, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 508, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 3298, in _real_extract
    raise UnsupportedError(url)
UnsupportedError: Unsupported URL: https://iview.abc.net.au/show/spicks-and-specks-reunion-special
...
<end of log>

Description of your issue, suggested solution and other information
The link "https://iview.abc.net.au/show/spicks-and-specks-reunion-special" doesn't work on Youtube-DL, i got the link from ABC iView > Share > Copy Link, and it still has an error?
How can i get the direct link?
UPDATE
After looking at the page source and searching for "Video" it gave me the direct link "https://iview.abc.net.au/video/LE1802V001S00" this link doesn't work in a browser but downloads and works in youtube-dl.

Duplicate of #16868.


1 stop interactive command for initial setup in a guild

No longer needed, various reasons mostly slash command permissions.


Move health checks to a separate function in bats test file

Now, regarding to the template file, we have to write checks twice:

In @test "install from directory"
And in @test "install from release" - the same lines.

Will be good to move that to a separate function, to not have two places to manage them.
So, I've created a function health_checks() that contains only a single instance of checks.
And have moved it to the top, because it will be edited more frequiently, than test functions.

Hmm, the tests are running well locally:

Will check what are the difference with the pipeline.

Seems bats doesn't support functions with all commented lines, so I've just added one real line there and it starts working:


[formControl] binding not working on Switch element

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

CLI: 4.2.4
Cross-platform modules: 4.2.1
Android Runtime: 4.2.0
iOS Runtime: 4.2.0
NativeScript-Angular: 6.1.0
Angular: 6.1.10

Describe the bug
Switch doesn't appear to support binding formControl to it as it doesn't set the default value of true, as well as it doesn't respond to changes to the value. It does however change the checked attribute.
I looked here and you said you had implemented this, although you only show an example with ngModel: https://github.com/NativeScript/nativescript-angular/issues/72
To Reproduce
Add the NativeScriptFormsModule and ReactiveFormsModule to AppModule:
@NgModule({
imports: [
NativeScriptModule,
NativeScriptFormsModule,
ReactiveFormsModule,
AppRoutingModule
],
exports: [
NativeScriptModule
],
declarations: [
AppComponent
],
providers: [],
bootstrap: [AppComponent],
schemas: [NO_ERRORS_SCHEMA]
})
export class AppModule {}
Then create a form using FormBuilder:
public form = this.fb.group({
    ongoing: this.fb.group({
      checked: [true]
    })
  });

Then try to bind the formControl to the Switch:
<Switch class="ongoing" [formControl]="form.get('ongoing.checked')"></Switch>
You will see that the value is still false and if you listen to valueChanges it doesn't emit when you change the value.
Expected behavior
I expect the formControl value to be bound to the checked state when binding formControl to it.

Duplicate of https://github.com/NativeScript/nativescript-angular/issues/1362


Unable to boot into developer mode.

Hello, I've recently removed developer mode from my chromebook, now I wish to re-enable it.
When I try ESC + REFRESH + POWER I am presented with no screen, so I opened a issue.
Thanks!

What model Chromebook?

Acer Chromebook C720.

And what do you see when you hold down ESC when pressing refresh/power?

Literally nothing.

You should probably e-mail the chromebook support forums...

.I've tried. They couldn't help.


zephyr shell : net ping doesn't print any ping duration if CONFIG_FPU is true but CONFIG_NEWLIB_LIBC_FLOAT_PRINTF isn't.

The bug
It seems that net ping use the float format string even when it's not supported by snprintf.
When calling net ping command with CONFIG_FPU=y we get the follwoing output :
PING fe80:0:0:0:b062:a814:2bf5:e9ff
8 bytes from fe80::b062:a814:2bf5:e9ff to fe80::947f:ebce:7e66:909c: icmp_seq=1 ttl=64 rssi=-174 time= ms
8 bytes from fe80::b062:a814:2bf5:e9ff to fe80::947f:ebce:7e66:909c: icmp_seq=2 ttl=64 rssi=-174 time= ms
8 bytes from fe80::b062:a814:2bf5:e9ff to fe80::947f:ebce:7e66:909c: icmp_seq=3 ttl=64 rssi=-174 time= ms

Looking at the code in zephyr\subsys\net\ip\net_shell.c, we see that the float format string is gated behind the CONFIG_FPU config.
But that config doesnt guarenty that float format strings are supported.
Adding
CONFIG_NEWLIB_LIBC=y
CONFIG_NEWLIB_LIBC_FLOAT_PRINTF=y

to the config fix the problem but I'm unsure that CONFIG_NEWLIB_LIBC_FLOAT_PRINTF is the right way to check.
To Reproduce
Steps to reproduce the behavior:

Open the nrf OpenThread CLI sample (or any other zephyr shell app)
Add CONFIG_NET_SHELL=y to the config
Flash it to a board
ping a valid ICMP target

Expected behavior
The ping command should display a value for time no matter the configuration.
Impact
Annoyance
Environment

OS: Windows
Toolchain : nRF Connect SDK v2.5.1
Zephyr 3.4

@matt-leg-8798 not sure if this will work in zephyr v3.4, but please try it

The change works on my nRF52840 but it sems that it would block some boards with no floating point support to use the net-shell.
Wouldn't it be preferable to change the #ifdef in the net-shell.c to use CONFIG_CBPRINTF_FP_SUPPORT and CONFIG_NEWLIB_LIBC_FLOAT_PRINTF?
- #ifdef CONFIG_FPU
+ #if defined(CONFIG_CBPRINTF_FP_SUPPORT) || defined(CONFIG_NEWLIB_LIBC_FLOAT_PRINTF)
			 "time=%.2f ms",
			 (double)((uint32_t)k_cyc_to_ns_floor64(cycles) / 1000000.f)
#else
			 "time=%d ms",
			 ((uint32_t)k_cyc_to_ns_floor64(cycles) / 1000000)
#endif

IMO that doesn't scale well, the proposal seems to cover minimal libc and newlib, but what about others (picolib, external libc impelemtnations).

The change works on my nRF52840 but it sems that it would block some boards with no floating point support to use the net-shell.

How exactly? If there's no FPU support on the board, software FP can be used.
But TBH, if we're concerned about FP usage here, I'd personally just remove that ifdef and stick to integer computations (we could even rewrite the integer variat to have this decimal part of ms for better accuracy).

You can set CONFIG_REQUIRES_FLOAT_PRINTF to ensure that floating point is supported in printf, but there's no current libc independent mechanism to detect if it happens to be enabled. For picolibc, that doesn't actually use do floating point computation, so enabling that won't pull in the soft float emulation code.


update(plugins): link to new tailwind-caret-color fork

Name
Link

tailwind-caret-color
https://github.com/Naoray/tailwind-caret-color

tailwind-caret-color
https://github.com/GraxMonzo/tailwind-caret-color

The original plugin is no longer maintained. New fork adds support for Tailwind 2.0 and custom variants

[x] My item is in the right category
[x] My item is logically grouped below similar items
[x] My item's name and description respects the conventions of the list
[x] My item is awesome
[x] I have read and followed the contribution guidelines

Thank you!

Thank you!


Add git(1) to command reference

Adds the git(1) man page to the main reference index at https://git-scm.com/docs.
Setup and Config felt like the most appropriate subsection out of the existing ones, since that section already contains git-help(1), but happy to shift this around if it's felt that there is a better fit elsewhere.
Related to #918, which fixes the command lists within this man page.

Thanks, with the link text fixup this looks good. I agree that Setup and Config is probably the most sensible place to put it.


0.17 series & dataframe non-commutability

import pandas as pd
import numpy as np
index = pd.date_range('1-Jan-2016',periods=12,freq='MS')
a = pd.DataFrame(np.ones((12,5)),index)
b = pd.Series(4.,index)
print a.multiply(b,axis=0)
out:
0  1  2  3  4
2016-01-01  4  4  4  4  4
2016-02-01  4  4  4  4  4
2016-03-01  4  4  4  4  4
2016-04-01  4  4  4  4  4
2016-05-01  4  4  4  4  4
2016-06-01  4  4  4  4  4
2016-07-01  4  4  4  4  4
2016-08-01  4  4  4  4  4
2016-09-01  4  4  4  4  4
2016-10-01  4  4  4  4  4
2016-11-01  4  4  4  4  4
2016-12-01  4  4  4  4  4
print b.multiply(a,axis=0)
out: ValueError: operands could not be broadcast together with shapes (12,) (12,5)

INSTALLED VERSIONS
commit: None
python: 2.7.10.final.0
python-bits: 64
OS: Windows
OS-release: 7
machine: AMD64
processor: Intel64 Family 6 Model 26 Stepping 5, GenuineIntel
byteorder: little
LC_ALL: None
LANG: en_GB
pandas: 0.17.0
nose: 1.3.4
pip: 7.1.2
setuptools: 18.5
Cython: 0.22
numpy: 1.10.1
scipy: 0.14.0
statsmodels: None
IPython: 3.2.0
sphinx: 1.3
patsy: 0.3.0
dateutil: 2.4.2
pytz: 2015.7
blosc: None
bottleneck: 0.8.0
tables: 3.1.1
numexpr: 2.3.1
matplotlib: 1.4.3
openpyxl: 1.8.5
xlrd: 0.9.3
xlwt: 0.7.5
xlsxwriter: 0.6.7
lxml: 3.4.2
bs4: 4.3.2
html5lib: 0.999
httplib2: None
apiclient: None
sqlalchemy: 1.0.8
pymysql: None
psycopg2: None

This is has never been supported. It could be, but would require a bit of effort. pull-requests are welcome.
In [45]: b.multiply?
Signature: b.multiply(other, level=None, fill_value=None, axis=0)
Docstring:
Multiplication of series and other, element-wise (binary operator `mul`).

Equivalent to ``series * other``, but with support to substitute a fill_value for
missing data in one of the inputs.

Parameters
----------
other: Series or scalar value
fill_value : None or float value, default None (NaN)
    Fill missing (NaN) values with this value. If both Series are
    missing, the result will be missing
level : int or name
    Broadcast across a level, matching Index values on the
    passed MultiIndex level

Returns
-------
result : Series

See also
--------
Series.rmul
File:      ~/pandas/pandas/core/ops.py
Type:      instancemethod

Seems there hasn't been much traction or activity to add this feature so closing


Setting the "Created" Timestamp

Currently, nix2container does not set the Created timestamp. Is there a way to enable nix2conatiner to set the timestamp?
I am asking because GitLabs cleanup policies utilize the created timestamp to decide which containers to keep. In our case, this results in no Images being cleaned up, as Gitlab eternally interprets this as "Published just now".

We could implement the same thing than in nixpkgs.dockerTools: the buildImage function could have the additional argument created which default to the epoch time. This argument could take a date or now. When the value is now, the date would be set at build time.
Note we would have to add a big warning in the documentation, since now would break the build reproducibility :confused:
(Another approach would be to set now in the image JSON file and set the date a push time: the build iwould be reproducible but the "push" would not be, which can be pretty annoying in practice)

That sounds reasonable. Can this be done solely in the nix code or does it require adjustments to the Go Programs? I could take this on, does this plan look reasonable?

add created param to the config of buildImage which gets passed to nix2container here
add handle the created timestamp in here?

You would need to add an optional argument to nix2container to be able to specify the created date and propagate this value to this function.
Then, you could add an argument to the buildImage Nix function to support the now value and set the nix2container binary created argument.

If we use created = builtins.substring 0 8 lastModifiedDate; where lastModifierDate is self.lastModifiedDate from flake.nix, it's reproducible, right?

@bbigras If the date comes from the flake.nix or flake.lock files then, yes it is reproducible (and you would have to manually run something to update this date).

Thank you @mrBliss for your code!
This issue was causing huge issues for me because of how my NAS runs docker. It runs some kind of automatic update checker with no way to disable it. That checker crashes when it inspects an image with no "created" metadata, and when that happens it also decides to just restart docker and all running containers.
Your change works perfectly for me (especially when plumbing in the flake's lastModifiedDate to exactly match last commit date as suggested above).

I came up with this "solution":
created = "${builtins.substring 0 4 self.lastModifiedDate}-${builtins.substring 4 2 self.lastModifiedDate}-${builtins.substring 6 2 self.lastModifiedDate}T${builtins.substring 8 2 self.lastModifiedDate}:${builtins.substring 10 2 self.lastModifiedDate}:${builtins.substring 12 2 self.lastModifiedDate}Z";

Wasn't a pleasure to write but it behaves like docker build now. A "now" shorthand would be awesome.


Now that you have pageable all the ..SinglePage apis should be removed.  SinglePage was only necessary before Pageable was available.

Now that you have pageable all the ..SinglePage apis should be removed.  SinglePage was only necessary before Pageable was available.
Originally posted by @RickWinter in https://github.com/Azure/azure-sdk-for-cpp/pull/2144#discussion_r620450386

This needs to be done before GA.  It can happen in May release if time allows.


update callback-setter

Cleanup-request
Description
The callbacks for stream and standalone messages at the moment should be set in the controller. This makes problems, if different connections should trigger different callbacks. This have to be changed.

removed the callback-setter for stream- and standalone-messages to make the code cleaner, but have to be set for each session separatelly, which gives more control.
Accidentally pushed directly into master...


added section on outgoing data requests

included brief description of outgoing data requests process, may be expanded later

Resolves #235
https://github.com/idea-analytics/r_and_a_manual/blob/18621607182da7dd292b3f566711e9263f048648/05a-Projects.Rmd#L386-L390


Almayer is now fallback map, added Almayer to default map pool

About the PR

Added fallback: true to Almayer proto
Removed fallback: true from Saltern proto
Added Almayer to Default Map Pool
Changed minPlayers from 0 to 90 on Almayer

I tried making savannah fallback, setting savannah min pop to 50 to force almayer to be picked but it still falls back to savannah so something must be wrong with almayer

???

it might just be because almayer is secretly savannah and I'm getting gaslit so I'll try more tests

That should be enough info for smug to look into it at least


Change allows ember-cli-rails to work under jruby-<IP_ADDRESS>

There may be a better fix for this. I doubt that this change should be merged as it is.
Without this change, I get an error after running app.rb line 44:
@pid = exec(cmd, method: :spawn)
Using ruby-2.2.2 there is no problem. With 'rvm use jruby-<IP_ADDRESS>' the error is as follows :
Java::JavaLang::ArrayIndexOutOfBoundsException (-2):
org.jruby.util.io.PopenExecutor.run_exec_dup2(PopenExecutor.java:789)
org.jruby.util.io.PopenExecutor.execargRunOptions(PopenExecutor.java:986)
org.jruby.util.io.PopenExecutor.spawnProcess(PopenExecutor.java:113)
org.jruby.util.io.PopenExecutor.spawn(PopenExecutor.java:75)
org.jruby.RubyProcess.spawn(RubyProcess.java:1296)
org.jruby.RubyKernel.spawn(RubyKernel.java:1509)
...

@softwareanimal thanks for the contribution!
Keep in mind, App#exec isn't the same as Kernel.exec.
Invoking App#exec usually runs system, but it can be configured to run spawn.
Could you verify which invocation of App#exec is causing the issue?

app.rb near line 342 is the changed line, and where the error happens :
Kernel.public_send(method_name, env_hash, cmd, err: :out)
The 'method_name' variable  prints out as 'spawn' and 'method: :spawn' is passed in from app.rb near line 52 (not app.rb line 44 as I stated before):
@pid = exec(cmd, method: :spawn)
Not sure if this is related to the question.
Again, I am not sure that you want to merge a change to support jruby-<IP_ADDRESS>. Also not sure what change you would merge. I just opened this pull request to report what worked under this environment and what does not work.

@softwareanimal thanks for the context. I'll try looking into this and I'll ping you if I need more info.

:+1:

@softwareanimal thank you so much for bringing this to our attention.
A fix is being tracked in https://github.com/thoughtbot/ember-cli-rails/pull/288.
Closing in favor of #288

@softwareanimal @nadavshatz could you please checkout the branch on #288 and give it a shot?


Let's restrict the interface of claims-context.tsx so that other parts of the code can't break the data invariants.

Let's restrict the interface of claims-context.tsx so that other parts of the code can't break the data invariants.

Miscellaneous todo:

Rename zeroth-order to constraint
Go through parser and use "never" to get type checker to verify that cases are exhaustive.

Bug: The color doesn't seem to be responding to changes in validText on the first blur event, it takes a second one to change.

TODO for future branches:

Rename zeroth-order to constraint
Go through parsing files and use "never" to get type checker to verify that cases are exhaustive.

Let's merge!


Updated Arch to latest version and added source-generator.

Theres an "warning" or "error" with nullable due to the generated code. However the code is still working and running, can it still be merged?

you should use
#nullable enable
...
#nullable restore

in your generated code in case your users have strict rules like me just in case (I had the same issue on an other project >_<)


Theme

Issue Type: Bug
cannot select theme clicking in cog
VS Code version: Code 1.42.0 (ae08d5460b5a45169385ff3fd44208f431992451, 2020-02-06T10:51:34.058Z)
OS version: Windows_NT x64 10.0.19559

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz (4 x 2712)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.87GB (1.89GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

bracket-pair-colorizer-2
Coe
0.0.29

dart-code
Dar
3.8.1

flutter
Dar
3.8.1

gitlens
eam
10.2.0

flutter-mobx
Flu
0.0.5

adb-interface-vscode
vin
0.14.0

Oops, the bot was overzealous there. I can't reproduce it -- can you provide more details?

Displaying the Release Notes page, when clicking on the cog it is not possible to select the theme change

I can now reproduce it -- so a webview need to be the active editor, and then you will see the quick pick for the color theme flash and disappear.

@keldju Why did you close this one?

I'm not able to reproduce:

Open release notes
Click on the gear, color theme
Picker opens and I can use cursor keys, mouse, keyboard to select a theme


Update Japanese message catalogue of core nodes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

This PR updates Japanese message catalogue of nodes.
Proposed changes

Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage increased (+0.04%) to 76.632% when pulling 7828af591e624da87dceb066db3703bd596d7695 on node-red-hitachi:update-node-messages-jp into d432dba726e307dc74c6aca942ea1dec06ffc26e on node-red:dev.


Push search and map routes to the root stack

Is your feature request related to a problem? Please describe.
Reasoning can be found in #420 .
Describe the solution you'd like
We discussed this and decided it makes sense to push routes to the root navigation stack in the search and map tabs.
Additional context
#420

Fixed in commit https://github.com/digitalfabrik/entitlementcard/commit/dcad66ef372ea4e9ba4b52193a25396b128d71e3


[Wave8] [Simplified Collect] Fetch collect workspace data when opening settings

Part of wave8 cc @luacmartins @trjExpensify
Problem
At the moment, we load category or tags data for a policy either:

on app start for your primary policy
or when workspace chat, expense report or transaction thread are open in OpenReport

This leaves us with with case when user can navigate to settings of a workspace they are admin of after signing i without navigating to any open report that would load the categories or tags. Since opening the category workspace page for example at the moment does not call any API command, we do not load the categories and for the user it looks like as if the workspace had no categories
Solution
Possible solution:
Create OpenWorkspaceCategoryPage and OpenWorkspaceTagsPage commands (similarly for other policy pages), that will be READ API commands fetching the workspace categories or tags respectively. These API commands would take policyID as param

Thanks for creating this! Seems like the proposed solution is the way to go here. Is there any other ongoing discussion?

Not in Slack, but I think it stemmed from this PR https://github.com/Expensify/App/pull/36324 and testing

What are the next steps here?

@luacmartins can we get going on this with tags out the door?

Yes, we got the PR to do this for tags merged yesterday. I'll get started on the other ones.

👋 Confirming we need to pay @s77rt for this PR review here do we?

Yes! Assigned them to the issue

Offer sent!

Accepted! Thanks!

Paid!


Code update Field Mode enable setting

/xyz/openbmc_project/software
{
    "FieldModeEnabled": 0
}

@anoo1  Whats the use case for this attribute in software..

This issue is the same thing as https://github.com/openbmc/openbmc-test-automation/issues/1032. I should have probably just commented with a list of things to do in this one. Can we close this one since the other as the point estimate?


Keras Weighted Cross Entropy (Binary)

I am trying to implement weighted cross entropy from TF in Keras.
Documentation from TF site : https://www.tensorflow.org/api_docs/python/tf/nn/weighted_cross_entropy_with_logits
This is what I do :
import tensorflow as tf
from keras import backend as K

# Create the custom loss function
def weighted_binary_crossentropy(weights):
    def w_binary_crossentropy(y_true, y_pred):
        return K.mean(tf.nn.weighted_cross_entropy_with_logits(
            y_true,
            y_pred,
            weights,
            name=None
        ), axis=-1)
    return w_binary_crossentropy

# Optimizers, Loss and Compile
adam = Adam(lr=0.0001)
weighted_loss = weighted_binary_crossentropy(weights=1)
model.compile(optimizer=adam, loss=weighted_loss, metrics=['accuracy'])

Traning started but Loss is not getting updated/stuck. My expectation is if I set the weight to 1, then the result will be the same as standard cross entropy loss.
Did I missed something?

Hii @IronLady I guess in such a case tweaking your neural network architechture and changing certain parameters might help or maybe the machine might be expecting a different loss function.

I am trying to implement weighted cross entropy from TF in Keras.
Documentation from TF site : https://www.tensorflow.org/api_docs/python/tf/nn/weighted_cross_entropy_with_logits
This is what I do :
import tensorflow as tf
from keras import backend as K

# Create the custom loss function
def weighted_binary_crossentropy(weights):
    def w_binary_crossentropy(y_true, y_pred):
        return K.mean(tf.nn.weighted_cross_entropy_with_logits(
            y_true,
            y_pred,
            weights,
            name=None
        ), axis=-1)
    return w_binary_crossentropy

# Optimizers, Loss and Compile
adam = Adam(lr=0.0001)
weighted_loss = weighted_binary_crossentropy(weights=1)
model.compile(optimizer=adam, loss=weighted_loss, metrics=['accuracy'])

Traning started but Loss is not getting updated/stuck. My expectation is if I set the weight to 1, then the result will be the same as standard cross entropy loss.
Did I missed something?

Hi @IronLady , did you manage to make this work? I have the same problem, and I need this loss for a very unbalanced semantic segmentation problem.

@opengeostat
def weighted_binary_crossentropy(weights):
    def w_binary_crossentropy(target, output):
        epsilon_ = tf.convert_to_tensor(K.epsilon(), output.dtype.base_dtype)
        output = clip_ops.clip_by_value(output, epsilon_, 1 - epsilon_)
        output = math_ops.log(output / (1 - output))

        return K.mean(tf.nn.weighted_cross_entropy_with_logits(targets=target, logits=output, pos_weight=weights), axis=-1)

    return w_binary_crossentropy```

I can't really remember the correct code.
Maybe this. Please try.


Update MATURITY

Why are the changes needed?

For now, we have 6 different release managers and 8 new committers.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

cc @yaooqinn

Codecov Report

Merging #3174 (1471f1e) into master (c6caeb8) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3174      +/-   ##
============================================
- Coverage     51.44%   51.39%   -0.06%
  Complexity        6        6
============================================
  Files           456      456
  Lines         25422    25422
  Branches       3540     3540
============================================
- Hits          13078    13065      -13
- Misses        11088    11095       +7
- Partials       1256     1262       +6

Impacted Files
Coverage Δ

.../kyuubi/server/mysql/constant/MySQLErrorCode.scala
13.84% <0.00%> (-6.16%)
:arrow_down:

...ache/kyuubi/server/mysql/MySQLCommandHandler.scala
76.13% <0.00%> (-3.41%)
:arrow_down:

...ache/kyuubi/server/mysql/MySQLGenericPackets.scala
76.59% <0.00%> (-2.13%)
:arrow_down:

...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala
78.00% <0.00%> (-2.00%)
:arrow_down:

...ache/kyuubi/operation/KyuubiOperationManager.scala
80.82% <0.00%> (-1.37%)
:arrow_down:

.../engine/spark/session/SparkSQLSessionManager.scala
78.48% <0.00%> (-1.27%)
:arrow_down:

...ain/scala/org/apache/kyuubi/engine/EngineRef.scala
75.23% <0.00%> (-0.96%)
:arrow_down:

...a/org/apache/kyuubi/service/TFrontendService.scala
91.17% <0.00%> (-0.30%)
:arrow_down:

...in/scala/org/apache/kyuubi/config/KyuubiConf.scala
97.25% <0.00%> (-0.10%)
:arrow_down:

...che/kyuubi/server/KyuubiTHttpFrontendService.scala
64.96% <0.00%> (ø)

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

can we also update C30, CO50, CS10?

please also add the ids in the pr title

thank you @yaooqinn , merging to master


ENUNU on OpenUtau won't render past 03:34.6 per part

Acknowledgement

[X] I have read Getting-Started and FAQ

🐛 Describe the bug
When using ENUNU voicebanks on OpenUtau, parts that exceed approximately 03:34.6 will not render.

134 BPM

134 BPM

120 BPM

Explains how to reproduce the bug

Create USTX file
Try to go past 03:34.6

enunu-no-render.ustx

OS & Version
Windows 10
Logs
log20220821.txt

Fixed in b2c5b15


better glob handling

https://cloud.google.com/storage/docs/gsutil/addlhelp/WildcardNames

seems too complicated


Merge Master to stable/pike in support of branding changes (SCRD-6925)

The branding changes will require IBS to be updated with a new node_modules.tar.bz2 file reflecting the changes to package.json. In order to get the update for Devel:Cloud:8:Staging, the merge upstream (here in git) needs to have taken place.
No new code changes, just merged from master and resolved one trivial conflict (the renderFooterButtons method in src/pages/AddServers/DeployAddServers.js was added on master and for some reason was seen as a conflict in stable/pike, though the conflicting code was empty)

Branding changes are a no-go on maintained branches. Why are we doing this?

Branding changes are a no-go on maintained branches. Why are we doing this?

I was unaware of that, though thinking about it I suppose it makes sense
It will be difficult to deliver any of the late-arriving Day2 UI functionality back into Cloud 8 separate from the branding changes due to the pervasive nature of the branding updates.

Probably need some guidance from T.R. about whether its still desired to deliver additional Day2 work back into Cloud 8 at this timeframe... I see 2 options:

Stop backporting Day2 deliveries to Cloud 8, advertise what we have now as a tech preview of whats coming in Cloud 9
Continue to backport the changes to keep the functionality equivalent, at the cost of having some branding changes land in Cloud8

I'm fine with either. I'll email TR (who I believe is out for another week) and CC @dirkmueller

@jeremy-moffitt It should be possible to use git revert on this branch to revert the branding commits. There were only 2 or 3 of them.

@eapodaca that would likely work in the short term, but the merge conflicts going forward would likely get more and more complex... its worth evaluating at least whether there is value in continuing to backport to Cloud8 before deciding

@jeremy-moffit do not backport non bugfixes to stable/pike anymore.


Allow private attributes in schema.xml

I'd like to do the following:

-- or --

As you can see apiType is not an officially supported attribute. Yet I'd like to be able to use my own attributes, that I can read through the Table (rsp. Entity) model class.

Just a idea: in html5 custom attributes are notated by prepending data-. Maybe we could do something similar

I used x- as I've recently seen it in jsonapi (x = extension here), using data- is basically identical. Which API? What about:
$table->getData($field, $defaultValue = null);
$table->setData($field, $value);

I'm open for such change, but won't hold it as official issue/todo. So, if you want to provide a pull-request for this change, we'd very appreciate it.

Just talked with @marj that's what the <vendor> is for rsp. can be used as.


replace_text fails every time with Could not parse ToUnicodeCMap: Error!

The replace_text function of the Document struct is not working.
Example code:
use lopdf::Document;

fn main() {
	let mut doc = Document::load("document.pdf").unwrap();

	if let Err(error) = doc.replace_text(1, "Hello World", "Goodbye world") {
		println!("{error}");
	}

	doc.save("modified.pdf").unwrap();
}

Gives the following output:
ToUnicode CMap error: Could not parse ToUnicodeCMap: Error!

Happens even with a simple PDF document created by libre office (see below):
document.pdf
document.odt

This is not directly using indexmap -- perhaps you meant to file an issue on lopdf?
https://github.com/J-F-Liu/lopdf

Feel free to re-open if lopdf investigation comes back to a bug in indexmap.

Bruh, misclicked. Was meant for lopdf, I'm sorry!


Invoker fails to build due to new Go version

Due to the recent update in the Go version (from 1.18 to 1.21), Invoker fails to build when running make invoker in vSwarm/tools/invoker.
Error message:
        --go_out=. \
        --go_opt="paths=source_relative" \
        proto/helloworld.proto
protoc \
        --go-grpc_out=. \
        --go-grpc_opt="paths=source_relative" \
        proto/helloworld.proto
go mod tidy
go: go.mod file indicates go 1.21, but maximum version supported by tidy is 1.18
make: *** [Makefile:2: invoker] Error 1```

You have to install upgrade go to version 1.21 and then try again.
https://go.dev/doc/install
# Install new
 rm -rf /usr/local/go && tar -C /usr/local -xzf go1.21.4.linux-amd64.tar.gz
export PATH=$PATH:/usr/local/go/bin


Update react-redux dependency range to include v5 prereleases

v5 is centered around the connect() rewrite described in this PR: https://github.com/reactjs/react-redux/pull/416
The changes expands the API and rewrites all of the internals but preserves existing functionality, so it’s really non-breaking (reference). It also solves bugs related to nested connected components’ subscriptions getting triggered our of order for our app (which was actually the original motivation for the PR, see https://github.com/reactjs/react-redux/pull/416#issuecomment-250885794 and https://github.com/reactjs/react-redux/pull/416#issuecomment-250892326), so we’re switching over.

Current coverage is 100% (diff: 100%)

Merging #1903 into master will not change coverage

@@           master   #1903   diff @@
=====================================
  Files          53      53
  Lines        1188    1188
  Methods         0       0
  Messages        0       0
  Branches        0       0
=====================================
  Hits         1188    1188
  Misses          0       0
  Partials        0       0

Powered by Codecov. Last update 428e9f0...90278af


Added onLoadingStart/onLoadingFinish/onLoadingError props to Image component

Intended to provide loading states for network image sources. Updated the Image component example in the UIExplorer app to demonstrate how they can be used to fade in a network image (using the Animation API). Fixes #98.

This is awesome! Thanks for doing this! @a2, @nicklockwood can you review?

:+1: this would be incredibly useful!

:+1: That's awesome!

Do we want to stay close to the web here and naming them onLoad, onError, and, uh, I guess onLoading for when loading starts?

Sorry about the review delay, if you rename the event names i'll pull it in :)

This is awesome. One further suggestion, I think it would be better with documentation updated all at once :)

Sure not a problem, I can update docs/Image.md along with the other suggestions. Thanks!

Any update on this one? I'd like to use these features
cc @a2 @vjeux

:thumbsup::thumbsup:  i need it

@jordanna maybe you miss RCT_EXPORT_MODULE() in the RCTNetworkImageViewManager.m

This is now implemented.


Claim Initiative, Test Typings, and Baze Malbus Implementation

Initiative claiming functional
claiming initiative now properly flags the player as "passed", simply had it call pass after it finishes, and the button to claim initiative is removed for the rest of the phase. Added an event window on claiming initiative, but nothing specifically tests it yet.
server and test build changes
I reorganized the build process somewhat. The server build is now output to ./build/server by default, and test builds to ./build/test. server and test build independently of each other but test is still aware of server. JS/TS files under ./tests can now reference '../server' instead of '../build' as the folders are in the same relative position, which provides better typing support and more intuitive require(...) paths.
There is a now a npm script npm run test-fast that can be used the same as npm test. This will only rebuild the test folder rather than both the server and test folders, unless it detects that the server hasn't been built yet, at which point it just does a full rebuild. Might make re-running a single test file a little faster but shouldn't be used if you're also changing server code.
npm test can build both the server and test folders in parallel now.
Added a sub-folder for custom npm scripts, ./scripts. These just are for doing npm commands with a little more complexity. Not absolutely required, but felt it was handy to have.
the new eslint configs messed with building TS files in the test folder, so I kinda just hit it with a hammer until it stopped complaining. Will probably need a refactor from someone who has a better understanding of it.
Test changes
hasInitiative can now be flagged in the setupTest options player object. This will properly setup the given player has having the initiative at the start of the game.
While digging into that, I also changed a few arrays calls, some functions were sorting the array's in-place which was throwing off some testing. Changed all calls to use .concat() first to create an array copy to then sort, and separately fixed a check or two to properly sort.
General typing improvements
I've added an IntegrationsHelper.d.ts file. Trying to convert the JS file to TS wasn't worth the hassle due to heavy usage of this and other side-effects caused by integration. Custom Matchers have been added so they should now show up in intellisense for tests when using exact(). There are typings for the options object and the some of the game objects, but require using a new test context object to get typing/intellisense for.
limited TS support and test context
With the test folder structure changes, we can now create TS specs. However, it's not feasible to make this type safe as-is (better to just rewrite in vitest). As a workaround it's now possible to pass a contextRef in with the integration function call ala integration(function(contextRef) { ... }). This has a context object which contains the exact same fields that are accessible via this with some additional typings, using reference sorcery.
 }). In a given it(...) block, you can destructure the contextRef to get the context specific to that test, const { context } = contextRef, and use context as if you were using this. This gives much stronger typing and intellisense support.
contextRef is entirely optional, and this inside of tests functions exactly the same as before.
NOTE: This doesn't take into account any cards defined under the player objects, so the context has a general purpose "any" accessor. No type safety but at the very least it's no worse than before.
See the specs for examples.
Oh right, Implemented Baze Malbus, Temple Guardian
Dude's implemented.

@AMMayberry1 Smacked the linter hard enough, seems to be working now. Got the requested changes in, lmk if anything else crops up.


Fixed NullRederenceException in the Activities page

⏱ Before you start

[x] Have you checked if a similar PR has already been requested?
[x] Have you built and ran the app?

↗ Related/Fixed issues

No related issues.
📄 Description

Now, activities is shown on page.
💭 Motivation and Context

I added initialization for properties, where it should be.
Fixed null exceptions, when getting activites.
📸 Assets (if appropriate):

Before:

After:

@hunterlan This PR should close #210?

@hunterlan This PR should close #210?

No, IT shouldn't. You said, you'll take it, so, I started to discover the source code and fixed bug (and will fix others, if they exist).

Got it. When I fixed activities page totally, publish new version and tell you.

By the way, Mergeable?

Should be. GitHub says, it's ready to merge

I thought for a second that this is gonna fix #210

But I was wrong

I thought for a second that this is gonna fix #210

No, but this is also important fix.

Thank you! @hunterlan

Thank you! @hunterlan

You're welcome :)


insight,server: support tracing

Logger can have things like traceStart, traceEnd.
Server should be able to producte a Server-Timing header

No concrete use cases yet. If you come across a this ticket and have a usecase like this, please open a new issue.


Simple harvester for OETH

Simple Harvester
This PR aims to deploy a simple harvester for the OETH AMO to replace the current.
This new harvester is simpler, as it will only harvest reward and send it to the strategist.
Note: strategist and operator addresses are set to the deployer address but must be changed.
Code Change Checklist
To be completed before internal review begins:

[ ]  The contract code is complete
[ ]  Executable deployment file
[ ]  Fork tests that test after the deployment file runs
[ ]  Unit tests *if needed
[ ]  The owner has done a full checklist review of the code + tests

Internal review:

[ ] Two approvals by internal reviewers

Deploy checklist
Two reviewers complete the following checklist:
- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@clement-ux can you refresh my memory why the harvester functions are no longer free to be called by anyone and are now locked under the operator account?

@clement-ux can you refresh my memory why the harvester functions are no longer free to be called by anyone and are now locked under the operator account?

Indeed, that is something that I've added in comparison with the current Harvester. But it doesn't make sense to restrict it, so I'll remove the operator role 👍

I'll take a pass through this with a checklist tomorrow, but otherwise looks good.


Image Gallery - Higher resolution of image should be loaded on tap to expand

What

In the Image Gallery , Higher resolution of image should be loaded on tap to expand, especially for the all photos

Steps to reproduce the behavior

Go to Edit mode
Click on Images
Tap on an image
See low resolution image

So here @VaiTon could you help with that?

Can assign this issue to me please? :)

Sure @WildOrangutan 👍🏻

This should be the method that downloads the images:
https://github.com/openfoodfacts/smooth-app/blob/602b659f86bcc78fe7281423774d000b9b2a0325/packages/smooth_app/lib/pages/product/product_image_gallery_view.dart#L229


Update to latest code styles

i turned off automerge so i could approve the PR while also giving you a chance to change the date if you think it's important enough


[2.1] Update jquery to 3.4.1

Note there is no Bootstrapv4 in 2.1

Marking as blocked as the decision about which release this should go into hasn't yet been made.


Remove name, Email and website from 'New Comment' section when user is signed in

Name, Email and website input fields should not appear on the comment section when the user has already signed in. This information is already given in the user profile.

This new comment section comes directly from Mezzanine code. This issue is part of issues detailed in #186 which I am currently working on to address as the first phase of implementation for issue #186. @mauriel133 Let me know if you have other ideas in mind for addressing this issue.

This was at the end of a longer list of things that Mauriel was working on. He was done with everything else in that list, so we moved this one to a new issue. It overlaps with #186. So, I'm closing this one.


send_keys types only first symbol from string

Hello!
Thank you for your attention :)
I trying out WinAppDriver with an UWP application which is built on Xamarin. I am using the modified Python sample. Here is the test code:
  def test_login(self):
        login_text_field = self.driver.find_element_by_accessibility_id('LoginViewLoginEntry')
        sleep(5)
        login_text_field.clear()
        sleep(5)
        login_text_field.send_keys('testtest')
        sleep(50)
        pass

When calling send_keys, I see only "t" printed in the text box.
Here is driver log:

POST /session/EF300C52-DD66-4263-A328-386385F22368/element/42.10422808.2.10/value HTTP/1.1
Accept: application/json
Accept-Encoding: identity
Connection: close
Content-Length: 150
Content-Type: application/json;charset=UTF-8
Host: <IP_ADDRESS>:4723
User-Agent: Python http auth
{"text": "testtest", "value": ["t", "e", "s", "t", "t", "e", "s", "t"], "id": "42.10422808.2.10", "sessionId": "EF300C52-DD66-4263-A328-386385F22368"}
HTTP/1.1 200 OK
Content-Length: 63
Content-Type: application/json
{"sessionId":"EF300C52-DD66-4263-A328-386385F22368","status":0}

As you can see, whole string was sent, but only first item was written.
Is it something Xamarin-related? Or am I wrong somewhere?
Thank you for answering,
Have a nice day!

Hi @andreypeshko,
This is interesting. The JSON wire protocol payload seems correct to me. Are you using the WinAppDriver v1.0 release?
One possible issue if for the textbox to somehow loose focus after one key is typed. Can you try sending just 2 keys such as "te" and see if that makes a difference?

Hi @timotiusmargo ,
You are right, my bad, seems like old version was installed.
I re-installed the WinAppDriver v1.0 and it worked.
Thank you!

Hi,
Same thing happened to me recently. I'm using v1.1.1 and python client on a x64 win10 PC.
As a workaround, I have to make a for loop to send characters one by one. = =


Index Statistics does not support multi-column index

PR #275 Skipped Statistics for multi-column index to avoid bugs.
But we still need to fix bugs and enable it.

Fixed in #284


Release 3.2 missing jvmrun and entities.xml file

Going through the setup process today with "the latest" files/firmware and the jvm run and eitities.xml files seem to be missing from the .zip package.

Hi @scottwstevens,
I have just released an update, Version 3.2.1, to GitHub. It includes a patch to our release script which creates the GitHub release. I have ensured that the mentioned files, as well as other required files, are now included.
Please respond back if you find that this issue is still not resolved.
V2.3.1: https://github.com/hms-networks/flexy-thingworx-connector/releases/tag/v3.2.1


refactor: replace react with a flask-only version

Fixes #77.

Pull request checklist

[x] I have linked my PR to an issue
[x] I’ve used conventional commits
[x] My branch is up-to-date with ~main~ dev
[ ] Where appropriate, I have added or updated tests
[x] Where appropriate, I have updated documentation to reflect my changes

I know this hasn’t been reviewed and approved yet, but I’m going to merge this into dev so that I can attempt to bring #76 inline with this. Then the work here can be reviewed in a PR from dev to main.


docs: updated contributing with active discord url

Minor docs update
The current discord invite in the contributing guidelines was inactive/outdated.
Updating to the same invited used on twitch.

@all-contributors please add @Hexnaught  for docs


Filter records when paging

I have a Grid with multiple pages.
I am using remote AJAX against a PHP datasource.
I try paging through the records to find the one that I want.
I have no success, so I enter a column filter.
By default, Gijgo sends the following parameters to the Server:
page | 3
limit | 15
c_common | login
By default, the server will attempt to return Records 30 to 45 with filter "login" applied. Result! No Records. The page paramameter must be reset to 0 (zero). I can do this on the Server but this is wrong, because if the Recordset had contained more than 15 records I would never be able to reach the second and subsequent pages without some instruction from Gijgo Grid as to when and when not to reset the pager.
Obviously and at this moment. I know that this "feature" exists and whenever I need to apply a filter, I must return to Page 0 before applying it.
As far as I remember, from writing my own Pagination in the past, it is necessary to maintain state for the three elements - paging, filter and sort - in such a way that the correct combinations can be sent to the server as required.
In addition, I have a problem with the naming of the parameters. Using "page" and "limit" is Ok and can be changed anyway. But using the name of the field on which to filter, is not. How can the Server know that this is a Filter? I have worked out my own solution by parsing the REQUEST and omitting page, limit and sort etc., assuming that anything must be filter.
I believe that the correct approach would be to send an array:
page | 3
limit | 15
filter | {c_common | login}
And of course, dealing with sort or orderby in a similar way.
I hope my explanation makes sense, that I have not overlooked some setting in the Configuration that would correct this situation. I look forward to hearing from you.
I congratulate you on your hard work and effort.

Hello and thanks a lot for the feedback.
I will improve the reload method in future versions to reset the page to 1 , because a lot of people complain about it.
I don't want to move all the filters in separate array, because this is going to be a huge change for all the users that are using the grid right now and I want to avoid such inconveniences for them.

So did you modify the reload method to reset the page number to 1 when searching ?

If it's still relevant, I use $('[data-role=page-first]').click(); Just on here hoping someone reported pagination, guess no new updates. Would be nice to have a nice clear way to set current page index when filtering/searching the dataset.
But hey, I got a way around it and loving the grid ;)


controller: timing error and processing time consideration in ble_ll_conn_can_send_next_pdu()

Hi ~
The function ble_ll_conn_can_send_next_pdu() in ble_ll_conn.c  is used by the Central to decide wether to reply the Peripheral so that the Peripheral can send more data packets.
Since the Central does not know how many data needs to be transmitted, it always assume the Peripheral to send a maximum length data.
I am using a older version of NimBLE and the time of the maximum length is connsm->eff_max_rx_time is 2120 us.
Since we do not use the MIC field, we modified it to 2088 us to fully utilize the connection event.
It seems that connsm->ota_max_rx_time in the lastest version already remove the MIC field.
However, because of the timing error and the processing time, the Central may miss the reply packet from the Peripheral.
Specifically, if the end transmission time of the Peripheral reply is very close to the start time of the connection event, the reply packet will not be processed even it has been received.
For example, in our experiment, the ticks in ble_ll_conn.c Line 1698 is 150 (i.e., 4577 us).
usec is 2468 us, including an empty PDU, a full PDU without MIC (2088us), IFS, and MSS.
The added_usec is 2106 us.
Therefore, the next event start is only 3 us after the reply packet transmission.
Because of the timing error and the processing time, the reply can not be fully processed before the start of the next event.
The Peripheral has to retransmit the reply in the next connection event.
The most straigeforward way is adding a redundancy time considering the timing error and processing time.
If we still set the connsm->eff_max_rx_time to 2120 us, the Centeral choose not to transmit an extra empty packet since the Peripheral does not uses the MIC field, it acutall brings 32 us redundancy time.

there's BLE_LL_CONN_EVENT_END_MARGIN syscfg added exactly for this purpose

there's BLE_LL_CONN_EVENT_END_MARGIN syscfg added exactly for this purpose

Oh, BLE_LL_CONN_EVENT_END_MARGIN  seems to be a new feature in the later version.
I check the latest ble_ll_conn_get_next_sched_time() function and I think wether it is necessary to consider the  BLE_LL_CONN_EVENT_END_MARGIN after the Line 953 ce_end = next_sched_time;?
Since the issue I find is that the reply packet receiving is interruptted by the connection event of other connections. We should reserve the time for timing error and processing.

value assigned to ce_end in line 953 is the start time of next scheduled item which is different than current connection so it does not interfere with current connection event, i.e. even if we tx/rx packet at the very end of connection event, it can be processed while next scheduled item is being handled
ce_end calculations done before that for actual connection event end are adjusted for BLE_LL_CONN_EVENT_END_MARGIN because after tx/rx of last packet in connection event we need some time to reschedule for next connection event

I still believe the start of the connection event of another connection can interrupt the current recepition.
Assume because of the timing error, the rx_end_isr is issued a little bit late after the start of the next scheduled item of anther connection.
In ble_ll_sched_execute_item() function (Line 976 in ble_ll_sched.c), it always disable the physical layer first, which disable the interrupt.
After that, even the rx_end_isr is issued and the it will not pass the check at Line 1490 in ble_phy.c.
Therefore, once the next scheduled item of another connection is being handled, the reply packet can not be processed


combine sra downloading with chunking; find a way to use pbgzip and online splitting instead of fastq-dump --gzip --split-fastq

done! :)


Relax sentencepiece dependency.

This commit relaxes sentencepiece dependency. On windows there are no pre-built wheels for sentencepiece satisfying the current version constraints for recent versions of python, and building from a source distribution is unreliable.

Inference script runs as expected with sentencepiece==0.2.0.


in progress

Background
As a user, by default when I navigate to a single repository I land on the code tab. Here I can see the folders and files found in the root directory of the repo and the name of the root branch. I can also see the repo’s readme file below the folder tree.
Acceptance

[x] Branch button with icon, name of root branch, and dropdown arrow (does not need to show other branches yet)
[x] show root folder directories and files (relates to issue for folder navigation)

Tests are failing, kindly resolve those


Swap Jettifier to full dependency

Is your feature request related to a problem? Please describe.
As it's used in a postinstall, jettify needs to be a full dep, not a devDep. That way we can do npm i --production

there is no need for it as rnv uses dep react-native which in turn uses jetifier. npx jetify should work out of the box.
this covers both npm and yarn.
on top of that rnv runs jetifier after every node_modules invalidation.
this makes rnv run -p android working straight away for new rnv projects without the need for postinstall.
also every project varies and developers can choose how to deal with jetifying in variety of custom ways which is outside of the scope of rnv itself


NuGet Package Supports .NET Core?

Hello,
Seems the current Cake Build uses .NET Core when we set up a new project by default, but the current Cake.WebDeploy NuGet package does not support .NET core. Would you please update it?
Thanks!

It depends on Microsoft.Web.Deployment, which is a net45 dependency.
Any alternative for the future?


Revert "Mark Various Functions, And Enums Public For On-Chain Price Calculations"

Reverts project-serum/serum-dex#106

sorry, I want to know why revet this merged? by the way, how can I get bids/asks list? (like critbit.rs traverse function)


prioritize global transaction scanner #1227

Ⅰ. Describe what this PR did
prioritize global transaction scanner
Ⅱ. Does this pull request fix one issue?

fix #1227
Ⅲ. Why don't you add test cases (unit test/integration test)?
ensure order of bean initialization by BeanFactoryPostProcessor & PriorityOrdered is already verified.
Ⅳ. Describe how to verify it
Bean annotated with TwoPhaseBusinessAction is a part of a TCC transaction.
Ⅴ. Special notes for reviews

Codecov Report

Merging #1230 into develop will increase coverage by 0.02%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             develop    #1230      +/-   ##
=============================================
+ Coverage      43.94%   43.96%   +0.02%
  Complexity      1451     1451
=============================================
  Files            253      253
  Lines          10272    10274       +2
  Branches        1335     1335
=============================================
+ Hits            4514     4517       +3
- Misses          5175     5176       +1
+ Partials         583      581       -2

Impacted Files
Coverage Δ
Complexity Δ

...ta/spring/annotation/GlobalTransactionScanner.java
55.55% <0%> (-1.15%)
17 <0> (ø)

...very/registry/zk/ZookeeperRegisterServiceImpl.java
63.77% <0%> (-0.79%)
24% <0%> (ø)

...server/store/file/FileTransactionStoreManager.java
47.38% <0%> (+1.39%)
19% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c4a95d...3d1f3f5. Read the comment docs.


copying 7 volumes server's data to one master with POST

We have 2 masters with 3 volumes and 4 volumes each with version 76. We are now going to start a new master with version 90. and start recording on it.
Beside recording from live cameras, we are going to use POST method to copy a file from the old master and move it to the new master with the same directory structure.
My question is: Can seaweedfs single master v90 can bear 1000 requests per second?

depends on your requests. there are no performance change in terms of serving traffic.


ktorrent: fix build with CMake 3.11

Motivation for this change
KTorrent 5.1.0 fails to build with CMake 3.11. This PR backports a fix from upstream.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Failure on x86_64-linux (full log)
Attempted: ktorrent
Partial log (click to expand)
copying path '/nix/store/zyhmkj36x9652h9qm3va22jisflmd4cm-libktorrent-2.1-dev' from 'https://cache.nixos.org'...
building '/nix/store/d052ld3drpll69yysmqzgih874dl8qwv-?id=672c5076de7e3a526d9bdbb484a69e9386bc49f8.drv'...

trying https://cgit.kde.org/ktorrent.git/patch/?id=672c5076de7e3a526d9bdbb484a69e9386bc49f8
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   999    0   999    0     0    903      0 --:--:--  0:00:01 --:--:--   903
fixed-output derivation produced path '/nix/store/dn9w2hdcwcihwdj62ymwprxfn0nq73li-?id=672c5076de7e3a526d9bdbb484a69e9386bc49f8' with sha256 hash '1cn4rnbhadrsxqx50fawpd747azskavbjraygr6s11rh1wbfrxid' instead of the expected hash '10pvs8wnlv1f1bgd3zys40a6lrrw2m0swancv7gj4pwpb9p28qwy'
cannot build derivation '/nix/store/hmw1qjg2p3b68h6nc62ras606i76y46j-ktorrent-5.1.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/hmw1qjg2p3b68h6nc62ras606i76y46j-ktorrent-5.1.0.drv' failed

Fixed. Didn't know nix-prefetch-url doesn't work with fetchpatch.

@GrahamcOfBorg build ktorrent

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: ktorrent
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Failure on x86_64-linux (full log)
Attempted: ktorrent
Partial log (click to expand)
patching script interpreter paths in /nix/store/24hvf7gcb47ia42fzpw6siq7b89y8x88-libktorrent-2.1
checking for references to /build in /nix/store/24hvf7gcb47ia42fzpw6siq7b89y8x88-libktorrent-2.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/qnw6nlcasjzgciazb2cswvvf7i1mrbx1-libktorrent-2.1-dev
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qnw6nlcasjzgciazb2cswvvf7i1mrbx1-libktorrent-2.1-dev/lib
patching script interpreter paths in /nix/store/qnw6nlcasjzgciazb2cswvvf7i1mrbx1-libktorrent-2.1-dev
checking for references to /build in /nix/store/qnw6nlcasjzgciazb2cswvvf7i1mrbx1-libktorrent-2.1-dev...
postPatchMkspecs
cannot build derivation '/nix/store/b7a98mapimcbqpa7vjms9z638cnrwpzx-ktorrent-5.1.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/b7a98mapimcbqpa7vjms9z638cnrwpzx-ktorrent-5.1.0.drv' failed

Now libktorrent seems to be broken?

Failure on aarch64-linux (full log)
Attempted: ktorrent
Partial log (click to expand)
cannot build derivation '/nix/store/73xqkwk7ghzgkm0ajhjwsxn4mp2i0j3n-kwallet-5.46.0.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/v06pzl762axf1gkkqfamxy3d03w5301y-kio-5.46.0.drv': 23 dependencies couldn't be built
cannot build derivation '/nix/store/dkm8asklig84v2rqh1xc85a6pqfs5iga-kdeclarative-5.46.0.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/ir33mn9v27rc7k1w2kx40h0lrkqzhgwh-knotifyconfig-5.46.0.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/4awyzljliqv77hnlzh64zx80fd7kx7q4-kparts-5.46.0.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/5am0hw8j6p7yyvm9fgsav17p9fp33rwm-libktorrent-2.1.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/kxkns6rvzc6y50yhwgc2377687kwdd81-kcmutils-5.46.0.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/7axpgq3w7xh0yn1d25pmpf21qpf43fn0-kross-5.46.0.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/yklp843imlk6cgxxjcsv63qpqihn5kx3-ktorrent-5.1.0.drv': 15 dependencies couldn't be built
error: build of '/nix/store/yklp843imlk6cgxxjcsv63qpqihn5kx3-ktorrent-5.1.0.drv' failed

That's strange, libktorrent does build successfully with recent master 54ea1cd58aefde76f7ab2f63e955b9c622c70d1f on my machine. However, ktorrent is now broken again after the Qt update from 5.10 to 5.11. Added a new PR: #42071.


Always go full width in PR view

This is an alternative solution to #22824
and would also close #22781
This makes the PR diff view always full width.
It makes sense to make use of that screen real estate. If you want a more narrow view you can always resize your browser.
It also avoids cluttering the UI with another button + the database with another column for the setting.
This is also how github and gitlab do it.

This is an alternative solution to #22824 and would also close #22781
This makes the PR diff view always full width. It makes sense to make use of that screen real estate. If you want a more narrow view you can always resize your browser. It also avoids cluttering the UI with another button + the database with another column for the setting.
This is also how github and gitlab do it.

Could you post a screenshot?

Added some screenshots before/after

🎺 🤖