Vagrant integration

The issue is that my source and xdebug (along with php, apache) is in my Vagrant box. I've exposed port 9000 on my vagrant however, when I try to browse the application, the debugger isn't breaking in my code.

Adapter logfile (from setting "log": true in launch.json):
            <- launchResponse
            Response {
                seq: 0,
                type: 'response',
                request_seq: 2,
                command: 'launch',
                success: true
             }
             -> disconnectRequest
              {
                 command: 'disconnect',
                 arguments: { restart: false },
                 type: 'request',
                 seq: 3
                }

Code snippet to reproduce:
         <?php
        /**
           * @copyright  Copyright (C) 2012 - 2013 Open Source Matters, Inc. All rights reserved.
           * @license    GNU General Public License version 2 or later; see LICENSE.txt
         */

          // Define required paths
          define('JPATH_ROOT',          dirname(__DIR__));
          define('JPATH_CONFIGURATION', JPATH_ROOT . '/App/Config');
          define('JPATH_SETUP',         JPATH_ROOT . '/App/Setup');
          define('JPATH_TEMPLATES',     JPATH_ROOT . '/App/Templates');

          // Load the Composer autoloader
          require JPATH_ROOT . '/vendor/autoload.php';

           $container = new \Joomla\DI\Container;

           $container->registerServiceProvider(new         \App\Service\ConfigServiceProvider(JPATH_CONFIGURATION . '/config.json'))
	     ->registerServiceProvider(new \App\Service\DatabaseServiceProvider);

            // Instantiate the application.
            $application = new \App\App($container);

             // Execute the application.
             $application->execute();

I need the XDebug log

+1

Try xdebug.remote_connect_back = 1

I have the same issue and "xdebug.remote_connect_back = 1" didn't help either

FWIW, I found that passing the parameter XDEBUG_SESSION_START=vscode seems to get the ball rolling. From that point on it just started working for me (for that session).

@tedmasterweb how are you passing that parameter?

As a query string param, e.g.: http://localhost/myproject/?XDEBUG_SESSION_START=vscode
I've even managed to get it to break when using ScotchBox as the server (remote debugging) but I had to modify the json for vscode a bit (but I also have my doubts about how necessary that was).

Figured I could add to this, I'm having trouble getting it to break on breakpoints in vagrant as well.  It seems as though it's connecting to xdebug, but when I load a page that has a breakpoint in it it doesn't break, or do much of anything.
PHP version: 5.6
XDebug version: 2.5.1
launch.json:
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Listen for XDebug",
            "type": "php",
            "request": "launch",
            "port": 9001,
            "localSourceRoot": "/usr/src/projects/home/code/",
            "serverSourceRoot": "/code/",
            "log": true
        },
        {
            "name": "Launch currently open script",
            "type": "php",
            "request": "launch",
            "program": "${file}",
            "cwd": "${fileDirname}",
            "port": 9000
        }
    ]
}

Xdebug .ini config:
[XDebug]
xdebug.default_enable=1
xdebug.remote_enable = 1
xdebug.remote_autostart = 1
xdebug.remote_port=9001
xdebug.remote_connect_back=1
xdebug.remote_host=<IP_ADDRESS>
xdebug.remote_handler=dbgp
xdebug.remote_mode=req
zend_extension = /usr/lib/php5/20131226/xdebug.so
xdebug.remote_log = /tmp/xdebug.log

Xdebug log:
Log opened at 2017-03-27 21:10:48
I: Checking remote connect back address.
I: Checking header 'HTTP_X_FORWARDED_FOR'.
I: Checking header 'REMOTE_ADDR'.
W: Remote address not found, connecting to configured address/port: <IP_ADDRESS>:9001. :-|
I: Connected to client. :-)
-> <init xmlns="urn:debugger_protocol_v1" xmlns:xdebug="http://xdebug.org/dbgp/xdebug" fileuri="file:///code/scripts/work" language="PHP" xdebug:language_version="5.6.14-1+deb.sury.org~precise+1" protocol_version="1.0" appid="4977"><engine version="2.5.1"><![CDATA[Xdebug]]></engine><author><![CDATA[Derick Rethans]]></author><url><![CDATA[http://xdebug.org]]></url><copyright><![CDATA[Copyright (c) 2002-2017 by Derick Rethans]]></copyright></init>

<- breakpoint_list -i 1
-> <response xmlns="urn:debugger_protocol_v1" xmlns:xdebug="http://xdebug.org/dbgp/xdebug" command="breakpoint_list" transaction_id="1"></response>

<- breakpoint_set -i 2 -t line -f file:///code/src/App/Action/Admin/ReportBuilder.php -n 12
-> <response xmlns="urn:debugger_protocol_v1" xmlns:xdebug="http://xdebug.org/dbgp/xdebug" command="breakpoint_set" transaction_id="2" id="49770001"></response>

<- breakpoint_list -i 3
-> <response xmlns="urn:debugger_protocol_v1" xmlns:xdebug="http://xdebug.org/dbgp/xdebug" command="breakpoint_list" transaction_id="3"><breakpoint type="line" filename="file:///code/src/App/Action/Admin/ReportBuilder.php" lineno="12" state="enabled" hit_count="0" hit_value="0" id="49770001"></breakpoint></response>

<- breakpoint_list -i 4
-> <response xmlns="urn:debugger_protocol_v1" xmlns:xdebug="http://xdebug.org/dbgp/xdebug" command="breakpoint_list" transaction_id="4"><breakpoint type="line" filename="file:///code/src/App/Action/Admin/ReportBuilder.php" lineno="12" state="enabled" hit_count="0" hit_value="0" id="49770001"></breakpoint></response>

<- breakpoint_set -i 5 -t exception -x *
-> <response xmlns="urn:debugger_protocol_v1" xmlns:xdebug="http://xdebug.org/dbgp/xdebug" command="breakpoint_set" transaction_id="5" id="49770002"></response>

<- run -i 6
-> <response xmlns="urn:debugger_protocol_v1" xmlns:xdebug="http://xdebug.org/dbgp/xdebug" command="run" transaction_id="6" status="stopping" reason="ok"></response>

-> <response xmlns="urn:debugger_protocol_v1" xmlns:xdebug="http://xdebug.org/dbgp/xdebug" command="run" transaction_id="6" status="stopping" reason="ok"></response>

Log closed at 2017-03-27 21:21:51

Adapter logfile:
<- launchResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 2,
  command: 'launch',
  success: true }
new connection 1
<- threadEvent
ThreadEvent {
  seq: 0,
  type: 'event',
  event: 'thread',
  body: { reason: 'started', threadId: 1 } }
<- initializedEvent
InitializedEvent { seq: 0, type: 'event', event: 'initialized' }
-> threadsRequest
{ command: 'threads', type: 'request', seq: 3 }
<- threadsResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 3,
  command: 'threads',
  success: true,
  body: { threads: [ Thread { id: 1, name: 'Request 1 (5:31:01 PM)' } ] } }
-> setBreakpointsRequest
{ command: 'setBreakpoints',
  arguments:
   { source:
      { path: '/usr/src/projects/home/code/src/App/Action/Admin/ReportBuilder.php',
        name: 'ReportBuilder.php' },
     lines: [ 12 ],
     breakpoints: [ { line: 12 } ],
     sourceModified: false },
  type: 'request',
  seq: 4 }
<- setBreakpointsResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 4,
  command: 'setBreakpoints',
  success: true,
  body: { breakpoints: [ { verified: true, line: 12 } ] } }
-> setFunctionBreakpointsRequest
{ command: 'setFunctionBreakpoints',
  arguments: { breakpoints: [] },
  type: 'request',
  seq: 5 }
<- setFunctionBreakpointsResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 5,
  command: 'setFunctionBreakpoints',
  success: true,
  body: { breakpoints: [] } }
-> setExceptionBreakpointsRequest
{ command: 'setExceptionBreakpoints',
  arguments: { filters: [ '*' ] },
  type: 'request',
  seq: 6 }
<- setExceptionBreakpointsResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 6,
  command: 'setExceptionBreakpoints',
  success: true }
-> configurationDoneRequest
{ command: 'configurationDone', type: 'request', seq: 7 }

The code to reproduce is just any php code in my project, nothing will break any time I load a page in my browser.  It's code for the company I work for though so I can't post it.

I can verify that with these settings for homestead (vagrant), I was able to get breakpoints working:
{
    "version": "0.2.0",
    "configurations": [

        {
            "name": "Listen for XDebug",
            "type": "php",
            "request": "launch",
            "port": 9000,
            "serverSourceRoot": "/home/vagrant/[PROJECT_ROOT]",
            "localSourceRoot": "/Users/[MYUSERNAME]/social-native/workspaces/[PROJECT_ROOT]"
        }
    ]
}

Please note that your localSourceRoot and serverSourceRoot may be different depending on how you set up your mappings.
I'll start Listen for XDebug, then go to any page with the query ?XDEBUG_SESSION_START=vscode, and then I'm able to get breakpoints to work (both with the red dot breakpoint and xdebug_break().
When I start listening but don't do the above XDEBUG_SESSION_START, I'm only able to pause on exceptions. Hope this helps.

Something the issue reporter has confused, port 9000 is on the localhost where VSCODE is running, not the vagrant guest. XDEBUG in Vagrant needs to connect to host machine, not the other way around. The ip address <IP_ADDRESS> in vagrant (Virtual Box) will connect to the host machine.   https://stackoverflow.com/a/1262143/637783

@jbtule I've always suspected this to be true and yet I'm able to get it to work without specifying the IP address. Could possibly provide an example of your config files to help us understand? TIA.

@tedmasterweb  sure.
This is a working config from one of my projects using (XDebug 2.4.1 in my vagrant guest). BTW if the localSourceRoot, and serverSourceRoot aren't correct, XDebug will connect, but the the breakpoints will never break.
VSCode config
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Listen for XDebug",
            "type": "php",
            "request": "launch",
            "port": 9000,
            "localSourceRoot": "${workspaceRoot}/src",
            "serverSourceRoot": "/my/mapped/directory/in/vagrant/"
        }
    ]
}

Relevant XDebug Config
xdebug.remote_enable = 1
xdebug.remote_autostart = 1
xdebug.remote_connect_back = 0
xdebug.remote_host = <IP_ADDRESS>

It sounds like this is just an XDebug configuration issue and not a bug/feature request in the adapter. Any objection to close this?

Could a delta be adding more documentation to the readme specifically about setting up with vagrant?

Sure, feel free to do a PR

Hi, I'd like to reopen the issue.
I tried my best to configure VS/Xdebug with Homestead/Laravel vagrant box, however the success is partial.
The debugger stops only on xdebug_break() but not on manually set breakpoint in the editor.
This is my config directive:
    {
                "name": "Listen for XDebug on Homestead",
                "type": "php",
                "request": "launch",
                "port": 9000,
                "pathMappings": {
                    "/home/vagrant/code": "${workspaceRoot}"
                },
                "log" :true

        },

vagrant's xdebug .ini file holds both remote_host and remote_connect_back directives
zend_extension=xdebug.so
xdebug.remote_enable=1
xdebug.remote_autostart=1
xdebug.remote_port = 9000
xdebug.max_nesting_level=500
xdebug.remote_host=<IP_ADDRESS>
xdebug.remote_connect_back=1

tried to stick to this
https://tighten.co/blog/debugging-configure-xdebug-and-laravel-homestead-and-vs-code-and-phpunit
anyways. Why is it that the breakpoints don't work and xdebug_ directive does


Fix command struct pool

Description:
There is a race condition in the current command pool implementation, as it considers any zeroed command to be free, yet the agent also zeroes out commands before assigning them. This replaces the semaphore and zero checks of the command pool with a queue; commands are obtained by receiving a pointer from the queue, and released by adding the pointer back.
Also fixes a bug in the subscription manager that incorrectly reported status with > 1 subscription

Your problem was TOCTOU so let's address that in a simple way. Using a queue here makes things more complicated, and I'm not sure that queue error conditions (queue full/empty) are handled correctly here. I'd suggest a simple array of binary semaphores for each command. If you can take the semaphore, you have the command. To release, simply give that semaphore back. Also, timeout should be moved up one level to the caller or you can introduce a helper routine for this, e.g.:

Took your suggestion and replaced the queue with a semaphore array


Request throttling

I just Implemented a very simple throttling of API calls to 1 per second: https://github.com/cyraxx/pogobuf/commit/15ca4ff45d5d3c9132b5d1d3bc703aeb3d14f696
This gets rid of the code 52 errors for now but I think you can actually do a little more than 1 per second.
One idea would be to don't do any preemptive throttling and instead retry requests (for a maximum of, say, 5 times) with a little delay whenever a status 52 response is received. That would be a little more robust as it would also handle the occasional 52 you get when the servers are overloaded.

I'm currently delaying them (with bluebird delay) with 300ms by default.

Encounter Pokemon has delay of 2000ms
Catching Pokemon has a delay between 300ms and 1200ms.

If result 4 while hit (out of ball) delay of 600ms (animation)

Moving item from inventory has delay of 900ms
Using item for capture has delay of 2000ms
Using incubator has delay of 3000ms

This works exceptionally well (put here for reference / others).
These are made-up numbers based on how slow the UI feels for me. It may be a nice idea to use throttling besides real-human throttling. As you cannot activate 3 incubators at once within 1 second for example. Same for throwing balls at a Pokemon after it came out of the ball.
Just queue'n them and delaying; 300ms would be enough AFAIK.

I'd recommend implementing retry with bluebird-retry, and exposing those as options you can pass to the client object. It has a very nice backoff strategy and I've used it in some production AWS code to great success.
Regarding the throttling; I'd love to see this changed to be a client option. Adding an options object to the client constructor might additionally be a little future proof for other options that might want to be added.

I saw on reddit people saying over 3req/s you will get the error 52.

I've increased the throttled rate to 2/second and that seems to still work fine. Forgot to mention, it can be turned off with client.enableThrottling(false).
I will look into bluebird-retry, thanks for the pointer!
"Human-like" throttling based on how long it would take a user to trigger the individual actions however is not something that I'll include in the client - the client's goal is simply to provide a way of calling API functions without getting errors. Whether you use those to perfectly mimic human behavior or do something that is obvious botting is up to you.
I could see logic for "realistic" delays as a separate class or maybe a client subclass if someone wants to contribute that, but that would be outside the scope of this issue.

What I'm currently doing is disabling throttling, and then doing my own throttling to 3/sec. Being able to control the throttling via a parameter (even if you just exposed a setThrottleRate(timeMS) function) would be more convenient.

I agree that it should be configurable. I just put something in right now to avoid getting error 52 all the time, it's not final at all. I'll spend some more time on this later.

Throttle delay can now be configured (setThrottleDelay(0) to turn it off).
This is still temporary though and might change.

While the current solution throttles if RPC calls are made one at a time, it does not throttle batch calls being made in one RPC call. At this point, I am unable to get consistent data with the batch functions but I get the info needed when I do one call at a time. It may be good to re-think the batch function and have them just do individual RPC calls. I would be more than happy to take this on.

Are you saying the limit of ~3/s applies to the actual (sub-)requests? I had always just assumed it applied to the number of RPC envelopes. If it's the request messages then that does make things complicated for batch mode.
If possible I'd like to keep the batch mode as a single RPC request, that's basically the whole point of it now.

I've just implemented something using bluebird-retry. The approach is really simple: Whenever a request fails (that includes code 52), retry it up to 4 more times, with increasing delay.
I've run some test, including batch calls that have a whole bunch of requests, and it seems to work fine. There's the occasional error 52 as expected, but it just tries again and it works. Sometimes there's no 52 at all, in that case there's no time wasted with unnecessary delays.
The beauty of this is that it handles both the "rate limit" 52s as well as the "server busy" 52s, and even the HTTP 502 we sometimes get when the servers are overloaded.
I think this is the way to go. And of course you'll still be able to turn it off if you want to handle it yourself.

Sounds good, looking forward to it. The 502 randomness is pretty annoying currently. Love the exponential backoff approach on the retry's. That's a nice take on it.

Pushed it now. Let me know how it works for you!

Been inspecting the real client for a while now and it seems to ditch the whole batch if one of it failed and resend the whole batch again. It continues doing so until it has full response. This especially can be found in the start-up fase, where as sometimes not all requests receive a response.
Currently hitting the 5 times max easy, while the original app just keeps trying. But always in a batch. Mmm.

Weird that you're hitting the max easily, I've never seen more than one, maybe two retries. With the retry settings (300 ms base delay, backoff factor of 2) the delay between try 4 and 5 will be almost 5 seconds, I'd have thought that should be more than enough to reset the rate limit.
By retrying the whole batch do you mean multiple RPC envelopes or just one envelope containing multiple requests (i.e. what pogobuf's batch mode does)? Because if you're using batch mode and that RPC request fails we also retry the whole thing.

It was ERR 502 when I hit it easy. AFAIK that happens when the server is too busy. So it is not a big problem (if I'm correct), it doesn't hit easy on the 52 anymore.
I had it run overnight to make sure it was OK and besides some max 5's on 502 (I re-log in such case), it eventually crashed on;
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: socket hang up
    at TLSSocket.onHangUp (_tls_wrap.js:1087:19)
    at TLSSocket.g (events.js:286:16)
    at emitNone (events.js:91:20)
    at TLSSocket.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:926:12)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9)

I didn't search yet exactly what TLSSocket that is (could also be Google's for re-auth). Anyone else ran into this?

TLSSocket is the internal node class for doing HTTPS, that's all.
I've run into this occasionally. Your right that it's related to server load, I think. My little script would crash and restarting it would work fine... Haven't tried anything long running yet. But my script never runs fur more that a few seconds, so it can't be auth related in my case.

Understood, but within pogobuf request is being used. Something initializes a TLS connection without listening on the error event. Thats the reason it crashes fully instead of nicely throwing the error. I assume it cannot be request lib, but I may be wrong there of course.

Request uses node's http classes internally, so that doesn't surprise me.
As for the error handling, it's probably a small bug with pogobuf. Maybe open a new issue?

request is supposed to send all errors to our callback, so if it is caused by a request request (heh) then it would actually be a bug in request. Maybe it is somewhere in the Google auth instead?
Anyway, pretty sure that would be a separate issue. The request throttling seems to be dealt with, right? So we can close here and push the new version to npm?

Yup, request throttling is OK. 👍  Changed everything into batch anyway, so I'm personally not even hitting limits without it anymore anyway :)


Remove rc dependency

Would you want to want to switch to maintained forks like run-con?

Thanks for taking the initiative. Note that in the context of prebuild-install, the fork doesn't fix known bugs and rc has no open vulnerabilities. I'm aware though of GHSA-g2q5-5433-rhrf. I doubt that moving ownership from one person to another single person is the long-term solution to protect against supply chain attacks. Switching dependencies here could be good for the short term, were it not for the fact that rc is not essential here. If we're gonna spend any time on this (prebuild-install itself has a replacement) it should be to just remove rc.

+1 for removing rc altogether


Error when adding a basic richText field

Bug Report
I added a basic richText field to a collection using an example from the docs.
  {       name: 'defaultRichText',       type: 'richText',       label: 'Default Rich Text',       required: true,     },
Expected Behavior
I expected to be able to create a new item in this collection with a rich text fields.
Current Behavior
Create mode is not loading. Not able to perform any actions on object with rich test. Here is the console read:
`
index.js:46 Uncaught TypeError: Cannot read properties of undefined (reading 'labels')
at index.js:46
at mountState (react-dom.development.js:15626)
at Object.useState (react-dom.development.js:16248)
at useState (react.development.js:1508)
at UploadButton (index.js:44)
at renderWithHooks (react-dom.development.js:14985)
at mountIndeterminateComponent (react-dom.development.js:17811)
at beginWork (react-dom.development.js:19049)
at HTMLUnknownElement.callCallback (react-dom.development.js:3945)
at Object.invokeGuardedCallbackDev (react-dom.development.js:3994)
(anonymous) @ index.js:46
mountState @ react-dom.development.js:15626
useState @ react-dom.development.js:16248
useState @ react.development.js:1508
UploadButton @ index.js:44
renderWithHooks @ react-dom.development.js:14985
mountIndeterminateComponent @ react-dom.development.js:17811
beginWork @ react-dom.development.js:19049
callCallback @ react-dom.development.js:3945
invokeGuardedCallbackDev @ react-dom.development.js:3994
invokeGuardedCallback @ react-dom.development.js:4056
beginWork$1 @ react-dom.development.js:23964
performUnitOfWork @ react-dom.development.js:22776
workLoopSync @ react-dom.development.js:22707
renderRootSync @ react-dom.development.js:22670
performSyncWorkOnRoot @ react-dom.development.js:22293
(anonymous) @ react-dom.development.js:11327
unstable_runWithPriority @ scheduler.development.js:468
runWithPriority$1 @ react-dom.development.js:11276
flushSyncCallbackQueueImpl @ react-dom.development.js:11322
flushSyncCallbackQueue @ react-dom.development.js:11309
scheduleUpdateOnFiber @ react-dom.development.js:21893
dispatchAction @ react-dom.development.js:16139
(anonymous) @ useDebounce.js:8
setTimeout (async)
(anonymous) @ useDebounce.js:7
invokePassiveEffectCreate @ react-dom.development.js:23487
callCallback @ react-dom.development.js:3945
invokeGuardedCallbackDev @ react-dom.development.js:3994
invokeGuardedCallback @ react-dom.development.js:4056
flushPassiveEffectsImpl @ react-dom.development.js:23574
unstable_runWithPriority @ scheduler.development.js:468
runWithPriority$1 @ react-dom.development.js:11276
flushPassiveEffects @ react-dom.development.js:23447
performSyncWorkOnRoot @ react-dom.development.js:22269
(anonymous) @ react-dom.development.js:11327
unstable_runWithPriority @ scheduler.development.js:468
runWithPriority$1 @ react-dom.development.js:11276
flushSyncCallbackQueueImpl @ react-dom.development.js:11322
flushSyncCallbackQueue @ react-dom.development.js:11309
flushPassiveEffectsImpl @ react-dom.development.js:23620
unstable_runWithPriority @ scheduler.development.js:468
runWithPriority$1 @ react-dom.development.js:11276
flushPassiveEffects @ react-dom.development.js:23447
(anonymous) @ react-dom.development.js:23324
workLoop @ scheduler.development.js:417
flushWork @ scheduler.development.js:390
performWorkUntilDeadline @ scheduler.development.js:157
react_devtools_backend.js:2526 The above error occurred in the  component:
at UploadButton (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_forms_field-types_RichText_RichText_js.js:2532:25)
at div
at div
at Slate (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_forms_field-types_RichText_RichText_js.js:8445:5)
at div
at div
at RichText (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_forms_field-types_RichText_RichText_js.js:1420:19)
at CheckForCondition (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_forms_Error_index_js-node_modules_payload_-3dc2c9.js:2475:49)
at Suspense
at RichTextField
at RenderCustomComponent (http://localhost:3000/admin/main.js:15392:13)
at div
at RenderFields (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_forms_field-types_index_js.js:3546:13)
at div
at div
at form
at Form (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_forms_Error_index_js-node_modules_payload_-3dc2c9.js:1974:13)
at div
at DefaultEditView (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_views_collections_Edit_index_js.js:289:100)
at RenderCustomComponent (http://localhost:3000/admin/main.js:15392:13)
at NegativeFieldGutterProvider (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_forms_field-types_index_js.js:3475:40)
at DocumentInfoProvider (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_elements_PreviewButton_index_js-node_modul-c1e32a.js:125:13)
at EditView (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_views_collections_Edit_index_js.js:408:13)
at Route (http://localhost:3000/admin/main.js:49828:29)
at Switch (http://localhost:3000/admin/main.js:50030:29)
at div
at StepNavProvider (http://localhost:3000/admin/main.js:14102:28)
at div
at Default (http://localhost:3000/admin/main.js:15113:20)
at Route (http://localhost:3000/admin/main.js:49828:29)
at Switch (http://localhost:3000/admin/main.js:50030:29)
at Route (http://localhost:3000/admin/main.js:49828:29)
at Suspense
at Routes (http://localhost:3000/admin/main.js:12850:90)
at C (http://localhost:3000/admin/main.js:50085:37)
at LocaleProvider (http://localhost:3000/admin/main.js:15186:27)
at SearchParamsProvider (http://localhost:3000/admin/main.js:15423:33)
at PreferencesProvider (http://localhost:3000/admin/main.js:15335:32)
at t.AuthProvider (http://localhost:3000/admin/main.js:3243:12361)
at ModalProvider (http://localhost:3000/admin/main.js:2256:33)
at Router (http://localhost:3000/admin/main.js:49459:30)
at BrowserRouter (http://localhost:3000/admin/main.js:49076:35)
at ScrollInfoProvider (http://localhost:3000/admin/main.js:2772:28)
at WindowInfoProvider (http://localhost:3000/admin/main.js:3043:28)
at t.ConfigProvider (http://localhost:3000/admin/main.js:3243:16012)
at Index

Consider adding an error boundary to your tree to customize error handling behavior.
 This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
at Relationship (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_forms_field-types_index_js.js:4178:13)
at CheckForCondition (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_forms_Error_index_js-node_modules_payload_-3dc2c9.js:2475:49)
at RenderCustomComponent (http://localhost:3000/admin/main.js:15392:13)
at div
at RenderFields (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_forms_field-types_index_js.js:3546:13)
at div
at div
at form
at Form (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_forms_Error_index_js-node_modules_payload_-3dc2c9.js:1974:13)
at div
at DefaultEditView (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_views_collections_Edit_index_js.js:289:100)
at RenderCustomComponent (http://localhost:3000/admin/main.js:15392:13)
at NegativeFieldGutterProvider (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_forms_field-types_index_js.js:3475:40)
at DocumentInfoProvider (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_elements_PreviewButton_index_js-node_modul-c1e32a.js:125:13)
at EditView (http://localhost:3000/adminvendors-node_modules_payload_dist_admin_components_views_collections_Edit_index_js.js:408:13)
at Route (http://localhost:3000/admin/main.js:49828:29)
at Switch (http://localhost:3000/admin/main.js:50030:29)
at div
at StepNavProvider (http://localhost:3000/admin/main.js:14102:28)
at div
at Default (http://localhost:3000/admin/main.js:15113:20)
at Route (http://localhost:3000/admin/main.js:49828:29)
at Switch (http://localhost:3000/admin/main.js:50030:29)
at Route (http://localhost:3000/admin/main.js:49828:29)
at Suspense
at Routes (http://localhost:3000/admin/main.js:12850:90)
at C (http://localhost:3000/admin/main.js:50085:37)
at LocaleProvider (http://localhost:3000/admin/main.js:15186:27)
at SearchParamsProvider (http://localhost:3000/admin/main.js:15423:33)
at PreferencesProvider (http://localhost:3000/admin/main.js:15335:32)
at t.AuthProvider (http://localhost:3000/admin/main.js:3243:12361)
at ModalProvider (http://localhost:3000/admin/main.js:2256:33)
at Router (http://localhost:3000/admin/main.js:49459:30)
at BrowserRouter (http://localhost:3000/admin/main.js:49076:35)
at ScrollInfoProvider (http://localhost:3000/admin/main.js:2772:28)
at WindowInfoProvider (http://localhost:3000/admin/main.js:3043:28)
at t.ConfigProvider (http://localhost:3000/admin/main.js:3243:16012)
at Index
overrideMethod @ react_devtools_backend.js:2526
printWarning @ react-dom.development.js:67
error @ react-dom.development.js:43
warnAboutUpdateOnUnmountedFiberInDEV @ react-dom.development.js:23914
scheduleUpdateOnFiber @ react-dom.development.js:21840
dispatchAction @ react-dom.development.js:16139
(anonymous) @ index.js:40
getFirstResults @ index.js:199
async function (async)
getFirstResults @ index.js:196
(anonymous) @ index.js:235
invokePassiveEffectCreate @ react-dom.development.js:23487
callCallback @ react-dom.development.js:3945
invokeGuardedCallbackDev @ react-dom.development.js:3994
invokeGuardedCallback @ react-dom.development.js:4056
flushPassiveEffectsImpl @ react-dom.development.js:23574
unstable_runWithPriority @ scheduler.development.js:468
runWithPriority$1 @ react-dom.development.js:11276
flushPassiveEffects @ react-dom.development.js:23447
performSyncWorkOnRoot @ react-dom.development.js:22269
(anonymous) @ react-dom.development.js:11327
unstable_runWithPriority @ scheduler.development.js:468
runWithPriority$1 @ react-dom.development.js:11276
flushSyncCallbackQueueImpl @ react-dom.development.js:11322
flushSyncCallbackQueue @ react-dom.development.js:11309
flushPassiveEffectsImpl @ react-dom.development.js:23620
unstable_runWithPriority @ scheduler.development.js:468
runWithPriority$1 @ react-dom.development.js:11276
flushPassiveEffects @ react-dom.development.js:23447
(anonymous) @ react-dom.development.js:23324
workLoop @ scheduler.development.js:417
flushWork @ scheduler.development.js:390
performWorkUntilDeadline @ scheduler.development.js:157
`
Possible Solution

Steps to Reproduce

Add richText field to collection
Try to access collection

Weird. Config looks fine. I just popped it into one of the projects my team is working on now and it booted right up.
Note, I had to remove the Users and Institution relationship fields to get it to work, because I don't have those collections to relate to, but ... hmm.

If you remove that one rich text field, everything goes back to working? Am I understanding right?
What version of Payload are you on?

Yep you are correct. I'm using the latest version. Just created the project today.
  "dependencies": {
    "payload": "^0.10.11",
    "dotenv": "^8.2.0",
    "express": "^4.17.1"
  },


chore: clean up

Description
This PR

removes unused compatibility, categories dirs in catalog/
moves index.html for meshery.io/catalog from catalog/ to pages/catalog/

Notes for Reviewers
Signed commits

[ ] Yes, I signed my commits.

next merging https://github.com/meshery/meshery/pull/12182


Add name label to manager deployment template

A name label in the manager deployment template would simplify the identification to identify the operator pod.

This improvement will be included in v1.0.11


Update session.go

Can this change be added safely?

Hi @hashneo - That file is actually in the docker repository, which we include as a git submodule.  You'll want to open a PR over there.
...unless this is actually an issue with Garden.  If so, could you let us know what you're trying to accomplish?


Add box2d

Adds the box2d physics library

I think the checks fail because cmake on linux, macosx and mingw tries to always copy the install/include folder, but box2d doesn't create one.
https://github.com/xmake-io/xmake/blob/master/xmake/modules/package/tools/cmake.lua#L150

I think the checks fail because cmake on linux, macosx and mingw tries to always copy the install/include folder, but box2d doesn't create one.
https://github.com/xmake-io/xmake/blob/master/xmake/modules/package/tools/cmake.lua#L150

There is no make install command in the makefile generated by cmake

Or you can run os.runv("cmake", {...}) command or call build.sh/build.bat script to build it.

I have updated xmake/dev to add cmake.build interface. you can try
        if xmake.version():ge("2.3.7") then
            import("package.tools.cmake").build(package, config, {buildir = "build"})
        elseif is_plat("windows") then
            os.vrun("./build.bat")
        else
            os.vrun("./build.sh")
        end
        os.trycp("build/src/*.a", package:installdir("lib"))
        os.trycp("build/src/*.lib", package:installdir("lib"))
        os.cp("include", package:installdir())

linux doesn't have any links or linkdirs.
finding box2d from xmake ..
{
  version = "2.4.0",
  includedirs = {
    "/home/runner/.xmake/packages/b/box2d/2.4.0/77c75344736c4bf88a4590c6c3fa9639/include",
  },
}

linux doesn't have any links or linkdirs.
finding box2d from xmake ..
{
  version = "2.4.0",
  includedirs = {
    "/home/runner/.xmake/packages/b/box2d/2.4.0/77c75344736c4bf88a4590c6c3fa9639/include",
  },
}

The .a library was not found in the installdir/lib directory.

MinGW has got undefined references even though he finds the library and links to it.
> /usr/local/opt/mingw-w64/bin/x86_64-w64-mingw32-gcc -c -std=c++11 -I/Users/runner/.xmake/packages/b/box2d/2.4.0/76c2909639c24ff4861d24045fb57525/include -m64 -o /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/.xmake501/200903/_8979D576C76D43108C49F08F59B69120.o /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/.xmake501/200903/_98586F2EBB95431086C0AAEA237AD320.cpp
> /usr/local/opt/mingw-w64/bin/x86_64-w64-mingw32-g++ -o /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/.xmake501/200903/_2DC128E8AB25421084163782E4600820.b /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/.xmake501/200903/_8979D576C76D43108C49F08F59B69120.o -L/Users/runner/.xmake/packages/b/box2d/2.4.0/76c2909639c24ff4861d24045fb57525/lib -lbox2d -m64
> checking for the c++ includes(box2d/box2d.h)
> checking for the c++ links(box2d)
> checking for the c++ snippet(test)
checkinfo: ...gramdir/core/sandbox/modules/import/core/tool/linker.lua:91: @programdir/core/sandbox/modules/os.lua:258: /usr/local/Cellar/mingw-w64/7.0.0_2/toolchain-x86_64/bin/x86_64-w64-mingw32-ld: /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/.xmake501/200903/_8979D576C76D43108C49F08F59B69120.o:_98586F2EBB95431086C0AAEA237AD320.cpp:(.text+0x4d): undefined reference to `b2World::b2World(b2Vec2 const&)'
/usr/local/Cellar/mingw-w64/7.0.0_2/toolchain-x86_64/bin/x86_64-w64-mingw32-ld: /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/.xmake501/200903/_8979D576C76D43108C49F08F59B69120.o:_98586F2EBB95431086C0AAEA237AD320.cpp:(.text+0x59): undefined reference to `b2World::~b2World()'
collect2: error: ld returned 1 exit status

On the master version, I have passed mingw/iphoneos/android toolchain information to cmake. Therefore, in the next version, we can call cmake through xmake in on_install to support the compilation of mingw/android/iphoneos library


Expose event props onFocus and onOpen from the PhoneInput

We want to track several user actions performed on the PhoneInput, but it is impossible with the current API.

send an event when prefix select is opened
send an event when the input field is focused

As a solution, I think we should expose three props to stay consistent:

onPrefixFocus - when prefix select is focused
onPrefixOpen - when the prefix select is open
onInputFocus

The agreed API is:
<PhoneInput
        menuPortalTarget={document.body}
        inputProps={{
          onFocus: ()=> {}
        }}
        selectListProps={{
          onFocus: () => {
        }}}
      />

Where everything from the inputProps is passed to the phone input and everything from the selectListProps to the prefix list


[C++][Parquet] Improve quality of error message for zero-length files, otherwise corrupted files

Currently, the error looks like, even for zero-size files:

    if (file_size < FOOTER_SIZE) {
      throw ParquetException("Corrupted file, smaller than file footer");
    }

Reporter: Wes McKinney / @wesm
Assignee: Wes McKinney](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=wesm) / @wesm
PRs and other links:

GitHub Pull Request #4240

Note: This issue was originally created as PARQUET-1243. Please see the migration documentation for further details.

Wes McKinney / @wesm:
Issue resolved by pull request 4240
https://github.com/apache/arrow/pull/4240


Update for hiding password in target.

Coverage remained the same at 54.995% when pulling 559011ce9368859d8aedd4038d53ed175572cb73 on wknet123:master-new into d8a0e01214cac72519a54a521e8463fcf860935b on vmware:master.


I want to install manimgl

Describe the error
Hi, I am trying to install new version of Manim called ManimGL using this guide: https://3b1b.github.io/manim/getting_started/installation.html
And I am using this command
Code and Error
Code:
pip install manimgl
But with this error during istallation:
Error:
ERROR: Complete output from command python setup.py egg_info:
    ERROR: Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/cc/xvb27tps0pnfm2016lfhg0l40000gn/T/pip-install-sZu51G/moderngl/setup.py", line 13, in <module>
        raise Exception('Python 2 is not supported!')
    Exception: Python 2 is not supported!
    ----------------------------------------
ERROR: Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/cc/xvb27tps0pnfm2016lfhg0l40000gn/T/pip-install-sZu51G/moderngl/

Environment
OS System: macOS 11.2.3 Big Sur
manim version: master v0.5.0
python version: 3.9.4

Exception: Python 2 is not supported!
Maybe pip in your computer is a version of python 2.
Try pip3 insteadl?

Exception: Python 2 is not supported!
Maybe pip in your computer is a version of python 2.
Try pip3 insteadl?

Thank you. This helps me.


JS Certificate projects: Allow semantic element for result output

Describe the Issue
We should not require the result to be inside a div element. If we absolutely must require an element type, I would suggest we require a semantic text element.
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/build-a-palindrome-checker-project/build-a-palindrome-checker
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/build-a-roman-numeral-converter-project/build-a-roman-numeral-converter
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/build-a-cash-register-project/build-a-cash-register
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/build-a-telephone-number-validator-project/build-a-telephone-number-validator
Your code

Expected behavior
Allow any element type, or require a semantic text element.
Screenshots
No response
System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
No response

I would be fine with allowing a subset of valid elements, e.g. div, span, p?

I updated the title as this is something that affects all the projects. I didn't check all the tests but I assume we are asserting the element type in all of them (the div is at least in the requirements).

I am good with @naomi-lgbt's suggestion. Adding the help wanted label so we can review and merge the PR that is open.

Hi, can I work on this issue?


Overload toDataFrame for basic types to avoid surprising results

Without overloads Iterable.toDataFrame produces unexpected result
val string = listOf("aaa", "aa", null)
string.toDataFrame()

=>
length
0    3
1    2
2 null
I think it will be more reasonable to create a dataframe with a single column for all basic types (numbers, strings, char, boolean), and do reflection scan for everything else

I agree we need to take care of primitives. A list of strings gives me a dataframe of string lengths without the new overloads haha. However, do all of these need to be overloads for toDataFrame? Or can these just be moved to createDataFrameImpl?

I don't think so. At east we'll lose the ability to return this typed dataframe

Of course! You're right :)

The rest looks good! Btw, maybe we should also add overloads for (primitive) arrays toDataFrame, since they aren't iterables

Not sure, so let's return to it later c: I'll merge this


adding support for filters to TransformStep

Issue #, if available:
Adding support for input_filter, output_filter and join_source to TransformStep
Description of changes:
This is to add the support for the items listed above as they are already supported in the airflow transform_config API. (https://sagemaker.readthedocs.io/en/stable/airflow/sagemaker.workflow.airflow.html#transform-config)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: StepFunctionsPythonSDK-integtests
Commit ID: e330a1b99ae36ddf89dec44873703193270ffd1e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: StepFunctionsPythonSDK-integtests
Commit ID: fb8efdecc4c12e969d30d0a4e5fb5b1160c3af29
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Thanks for the contribution! @wmlba


Bump html-escape to 0.2.13 re css escape bug

Description
Fixes #3129
Relevant part of html-escape 0.2.13 changelog

Checklist

👍 I have reviewed my own code
😬 I have added tests

Could you please add a test so that it makes sure that it doesn't happen again in the future?

This hasn't been updated in a while so I added the test case myself

Closing this as this PR does not solve the issue


How can we SFT Qwen2-VL on videos ?

Thanks for the awesome works.
We noticed that  the script for supervised finetuning Qwen2-VL with LLaMA-Factory are provide. However, will the training script support video input in the future?

We have supported video finetuning https://github.com/hiyouga/LLaMA-Factory/tree/main/data#multimodal-video-dataset-1

one alternative is https://github.com/zhangfaen/finetune-Qwen2-VL  fyi


Angular 4 support

Do you have a branch which I can use for my angular 4 code. I do see that the tag you have in description says "angular4". Or if you can suggest how I can modify this to work with Angular 4, that would be great!

I'm sorry, I forgot to change the meta tags.
I'm not sure it's easy.
Do you have difficulty passing on angular 5?
You can try to take over the project with the configuration of a 0.4.x release.


Use navigate where possible for fairs routing #trivial

The type of this PR is: Enhancement
Description
This is part of a series of PRs that will update fairs routing to support the new fair view.
Fairs routing is inherently confusing because:

Externally (i.e. search results, from web), fairs are linked to via a URL that looks like /:profileSlug. This means that for any fair view, we need to be able to support this top-level URL.
Internally within eigen, we currently use a combination of that top-level URL and routes that are scoped like /fair/:fairID.

What this PR does:

Gets rid of SwitchBoard.presentFairViewController in favor of our new navigate helper. (I'm guessing/assuming this is desired from a general ecosystem perspective!)
Adds a new route to our routes file: /fair/:fairID, which will route to the main Fair screen. (Previously, the only way to get to this screen was via the vanity URL).
Updates as many places as I could find to, internally, route us to /fair/:fairID instead of the vanity URL.

Why?

In future PRs, I need to add the following logic:

As a user, if I have a Feature flag enabled or the fair I'm looking at is not part of a specified list of fair slugs, take me to the new fair view. Else, take me to the old one.

I've already dug into that ☝ implementation, and it is especially difficult given how many places and ways we render and route to the fair view. The goal of this PR is to simplify the logic in preparation for adding on the additional complexity.

Note: the changes are pretty innocuous, but I'm having difficulty testing every place as city guide does not work with Xcode 12 😭!
PR Checklist (tick all before merging)

[ ] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[ ] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added an app state migration, or my changes do not require one. (What are migrations?)
[ ] I have added a CHANGELOG.yml entry or my changes do not require one.

I verified locally and it seems to be 👍 on all of the city guide views I could find!


Can't add signatures to a Maven publication

I've tried for a long time to get signatures working, but it doesn't work

The signing plugin either adds tasks too late or too early, so it misses artifacts or adds the signatures too late to be included in the publication
The signing plugin's API for generating signatures is not easy to use. It randomly generates tasks, or causes errors because nothing it produces is serializable and so Gradle crashes
The API for adding signatures manually is internal. Why?? https://github.com/gradle/gradle/blob/016b7d517de858ba8b2567b026872a32651256f2/subprojects/publish/src/main/java/org/gradle/api/publish/internal/PublicationInternal.java#L60
There's no option to add signature files to a MavenPublication.
If I try and add signatures then I'll randomly get Cannot publish module metadata where component artifacts are modified. I don't know why. There's no useful information.

Please re-implement the Signing plugin so it's possible to add a signature.
See also

https://github.com/gradle/gradle/issues/13470

Expected Behavior

Current Behavior

Context

Steps to Reproduce

Your Environment

Build scan URL:

Would you please provide a sample that reproduces the issue?
It is clear you have issues with signing, however, it is not clear what do you do to make them appear.

@vlsi Here's a demo project https://github.com/aSemy/examples-gradle-signing-bugged

Sorry for the late reply.
@aSemy Could you please try with the latest version of Gradle?

Hi @ov7a, unfortunately I don't have the time or resources to update the reproducer I provided. Please could you do it? I would appreciate it.

Hey, @aSemy. It's unclear to me if this problem is caused by Gradle, KMP, or some misconfiguration. Since this issue is no longer relevant to you, I'm closing this.

@ov7a , the issue is relevant in context of sigstore (see https://github.com/gradle/gradle/issues/21715)
The current sigstore plugin uses a bunch of internal APIs, and I would love to have a public replacements for them.
Would you please reopen the issue?
See:

https://github.com/sigstore/sigstore-java/blob/68498f295f5bc29d1da92c65d305de048e90ee64/sigstore-gradle/sigstore-gradle-sign-base-plugin/src/main/kotlin/dev/sigstore/sign/SigstoreSignExtension.kt#L91-L94
https://github.com/sigstore/sigstore-java/blob/68498f295f5bc29d1da92c65d305de048e90ee64/sigstore-gradle/sigstore-gradle-sign-base-plugin/src/main/kotlin/dev/sigstore/sign/SigstoreSignExtension.kt#L28C40-L28C59
https://github.com/sigstore/sigstore-java/blob/68498f295f5bc29d1da92c65d305de048e90ee64/sigstore-gradle/sigstore-gradle-sign-base-plugin/src/main/kotlin/dev/sigstore/sign/DefaultDerivedArtifactFile.kt#L32

@vlsi Thanks for providing the context. Do I understand correctly that your comment is mostly about 3rd point of the original post?

You are right. However, I'm not quite sure if addDerivedArtifact is the intended API at all.
I guess, sigstore-gradle-plugin is the only plugin that generates Sigstore signatures, and I modeled the plugin after Gradle's signing plugin.
I have no explicit requirements for addDerivedArtifact method. What I need is the ability to add signatures that would sign artifacts (==subject of the current issue) and I wish the signatures to be published to the same repositories as the artifacts

In other words, the description of the current issue looks more like "someone struggles to add a signature", however, it would probably be better to rephrase it as "a need for API for adding signatures". WDYT?

Honestly, I think it would be better to open a separate issue for that with a proper description. Since you are having a great knowledge of this area and the context, I'd appreciate it if you do it.

I've created https://github.com/gradle/gradle/issues/26760

Thank you!


Persistent TensorBoard process

Discussed in https://github.com/microsoft/vscode-python/discussions/15658

Originally posted by joyceerhl March 12, 2021
Originally requested in https://github.com/microsoft/vscode-python/issues/15476
Integrated TensorBoard sessions in VS Code are terminated when the panel in VS Code is closed, with the intent of providing convenient lifecycle management.
That being said, we've gotten a request to provide a way to reuse the underlying TensorBoard process between VS Code session restarts. Is this something that users would find helpful?

Thank you to everyone who upvoted this issue! Since the community showed interest in this feature request we will leave this issue open as something to consider implementing at some point in the future.
We do encourage people to continue 👍 this issue as it helps us prioritize our work based on what the community seems to want the most.


Add pypi workflow

Codecov Report
Patch and project coverage have no change.

Comparison is base (bf7af7e) 100.00% compared to head (bb85e01) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines          228       228
  Branches        46        46
=========================================
  Hits           228       228

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Translate game languege to english

I think that changing the language (or adding language options) will facilitate access to the project.

I want to be assigned to this


Pound option is not coming while creating a manual invoice.

Issue raised by
@mohitsharma-22
Describe the bug
While creating invoices manually from the portal the user earlier used to get the EUR option in the currency dropdown. Due to some recent deployments, this option is now not visible to the user due to which we are not able to set the correct currency to the invoice amount of the clients that are in different currencies like a Euro.
Due to this currently, we have to correct the currency directly from the database which is not preferred.
To Reproduce
Steps to reproduce the behavior:

Go to the invoice page from the finance menu
Click on add invoice
Click on the currency dropdown
Only INR and USD are available. EUR is not available.

Expected behavior

[ ] We should be able to see EUR option in the dropdown
[ ] After saving the invoice the correct currency should be shown in the created invoice details

Screenshots
In this EUR is not present

Environment where error occurred*

Environment: Production, Staging and local
OS: All
Browser: All

This has been fixed. The country data was removed from the database due to which the pound symbol was also not getting displayed in the currency dropdown.


how to connect to azure devops server?

on adding TFS Server screen - how to add azure server?  tried several things but nothing works:

Put the full url of your Azure DevOps organisation in the first field, eg. https://dev.azure.com/MyCompany/ .


dep2nix: init at 0.0.1

Motivation for this change
cc @qknight
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Attempted: dep2nix
Partial log (click to expand)
shrinking /nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin/bin/dep2nix
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin
checking for references to /build in /nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/9b2aw47sp96wlg0fz0pn51ijsv6mqq1b-dep2nix-0.0.1
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/9b2aw47sp96wlg0fz0pn51ijsv6mqq1b-dep2nix-0.0.1
checking for references to /build in /nix/store/9b2aw47sp96wlg0fz0pn51ijsv6mqq1b-dep2nix-0.0.1...
/nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin

Success on x86_64-darwin (full log)
Attempted: dep2nix
Partial log (click to expand)
installing
/private/tmp/nix-build-dep2nix-0.0.1.drv-0/go /private/tmp/nix-build-dep2nix-0.0.1.drv-0
/private/tmp/nix-build-dep2nix-0.0.1.drv-0
post-installation fixup
strip is /nix/store/r5mcn9vqq80v5pfqp45d7290cis7dwp4-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/h9k7w3jqvzlg5afljhc88yfd22y8hgcb-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/h9k7w3jqvzlg5afljhc88yfd22y8hgcb-dep2nix-0.0.1-bin
strip is /nix/store/r5mcn9vqq80v5pfqp45d7290cis7dwp4-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/i2ld2sx1m1cvnndzf6gxz7g7a789ba9n-dep2nix-0.0.1
/nix/store/h9k7w3jqvzlg5afljhc88yfd22y8hgcb-dep2nix-0.0.1-bin

Success on aarch64-linux (full log)
Attempted: dep2nix
Partial log (click to expand)
shrinking /nix/store/zdhh865w86q0wandqvcyz6pn9ambdhj0-dep2nix-0.0.1-bin/bin/dep2nix
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zdhh865w86q0wandqvcyz6pn9ambdhj0-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/zdhh865w86q0wandqvcyz6pn9ambdhj0-dep2nix-0.0.1-bin
checking for references to /build in /nix/store/zdhh865w86q0wandqvcyz6pn9ambdhj0-dep2nix-0.0.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/fz2j6cq4v8fbbnzxp8haxmgf6gy0mrpb-dep2nix-0.0.1
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/fz2j6cq4v8fbbnzxp8haxmgf6gy0mrpb-dep2nix-0.0.1
checking for references to /build in /nix/store/fz2j6cq4v8fbbnzxp8haxmgf6gy0mrpb-dep2nix-0.0.1...
/nix/store/zdhh865w86q0wandqvcyz6pn9ambdhj0-dep2nix-0.0.1-bin

Success on aarch64-linux (full log)
Attempted: dep2nix
Partial log (click to expand)
/nix/store/zdhh865w86q0wandqvcyz6pn9ambdhj0-dep2nix-0.0.1-bin

Success on x86_64-darwin (full log)
Attempted: dep2nix
Partial log (click to expand)
/nix/store/h9k7w3jqvzlg5afljhc88yfd22y8hgcb-dep2nix-0.0.1-bin

Success on x86_64-linux (full log)
Attempted: dep2nix
Partial log (click to expand)
shrinking /nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin/bin/dep2nix
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin
checking for references to /build in /nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/9b2aw47sp96wlg0fz0pn51ijsv6mqq1b-dep2nix-0.0.1
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/9b2aw47sp96wlg0fz0pn51ijsv6mqq1b-dep2nix-0.0.1
checking for references to /build in /nix/store/9b2aw47sp96wlg0fz0pn51ijsv6mqq1b-dep2nix-0.0.1...
/nix/store/450vmlwrvw6q91c26xd9lwqf5gim3ci3-dep2nix-0.0.1-bin

Success on x86_64-linux (full log)
Attempted: dep2nix
Partial log (click to expand)
shrinking /nix/store/sqn4jn7lw4l4p8cgsqyg4akcjgpbzfds-dep2nix-0.0.1-bin/bin/dep2nix
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sqn4jn7lw4l4p8cgsqyg4akcjgpbzfds-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/sqn4jn7lw4l4p8cgsqyg4akcjgpbzfds-dep2nix-0.0.1-bin
checking for references to /build in /nix/store/sqn4jn7lw4l4p8cgsqyg4akcjgpbzfds-dep2nix-0.0.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/0rcggmgf0fs0c55kh4ijki0g0ljvxpi2-dep2nix-0.0.1
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/0rcggmgf0fs0c55kh4ijki0g0ljvxpi2-dep2nix-0.0.1
checking for references to /build in /nix/store/0rcggmgf0fs0c55kh4ijki0g0ljvxpi2-dep2nix-0.0.1...
/nix/store/sqn4jn7lw4l4p8cgsqyg4akcjgpbzfds-dep2nix-0.0.1-bin

Success on x86_64-darwin (full log)
Attempted: dep2nix
Partial log (click to expand)
installing
/private/tmp/nix-build-dep2nix-0.0.1.drv-0/go /private/tmp/nix-build-dep2nix-0.0.1.drv-0
/private/tmp/nix-build-dep2nix-0.0.1.drv-0
post-installation fixup
strip is /nix/store/r5mcn9vqq80v5pfqp45d7290cis7dwp4-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/j47c7sqjsscvjl1c4wqays1zh973k0jz-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/j47c7sqjsscvjl1c4wqays1zh973k0jz-dep2nix-0.0.1-bin
strip is /nix/store/r5mcn9vqq80v5pfqp45d7290cis7dwp4-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/xgrs8r61ccqx33d4fy8fdxcdwwrx872a-dep2nix-0.0.1
/nix/store/j47c7sqjsscvjl1c4wqays1zh973k0jz-dep2nix-0.0.1-bin

Success on aarch64-linux (full log)
Attempted: dep2nix
Partial log (click to expand)
shrinking /nix/store/2kj5wpcdpl5xfcw671cjr17h88bxdgma-dep2nix-0.0.1-bin/bin/dep2nix
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2kj5wpcdpl5xfcw671cjr17h88bxdgma-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/2kj5wpcdpl5xfcw671cjr17h88bxdgma-dep2nix-0.0.1-bin
checking for references to /build in /nix/store/2kj5wpcdpl5xfcw671cjr17h88bxdgma-dep2nix-0.0.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/w5cqhwyvia438k33amhzaqa7zlnyf7sv-dep2nix-0.0.1
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/w5cqhwyvia438k33amhzaqa7zlnyf7sv-dep2nix-0.0.1
checking for references to /build in /nix/store/w5cqhwyvia438k33amhzaqa7zlnyf7sv-dep2nix-0.0.1...
/nix/store/2kj5wpcdpl5xfcw671cjr17h88bxdgma-dep2nix-0.0.1-bin

Success on x86_64-linux (full log)
Attempted: dep2nix
Partial log (click to expand)
shrinking /nix/store/ir3kq375kp8rqn4ii081xfwqpcj5sp5s-dep2nix-0.0.1-bin/bin/dep2nix
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ir3kq375kp8rqn4ii081xfwqpcj5sp5s-dep2nix-0.0.1-bin/bin
patching script interpreter paths in /nix/store/ir3kq375kp8rqn4ii081xfwqpcj5sp5s-dep2nix-0.0.1-bin
checking for references to /build in /nix/store/ir3kq375kp8rqn4ii081xfwqpcj5sp5s-dep2nix-0.0.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/322d05arj3ms385hcy8b4s3h1gzln6h6-dep2nix-0.0.1
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/322d05arj3ms385hcy8b4s3h1gzln6h6-dep2nix-0.0.1
checking for references to /build in /nix/store/322d05arj3ms385hcy8b4s3h1gzln6h6-dep2nix-0.0.1...
/nix/store/ir3kq375kp8rqn4ii081xfwqpcj5sp5s-dep2nix-0.0.1-bin

Failure on x86_64-darwin (full log)
Attempted: dep2nix
Partial log (click to expand)
    + set -o pipefail
    ++ nix eval '(builtins.anotherNull)' --option setting-set true --option plugin-files /private/tmp/nix-build-nix-2.0.4.drv-0/nix-2.0.4/tests/plugins/libplugintest.dylib
    error: opening lock file '/private/tmp/nix-test/var/nix/db/big-lock': Permission denied
    + res=
48 out of 51 tests failed
make: *** [mk/tests.mk:12: installcheck] Error 1
builder for '/nix/store/hbv0sai8kdsv4rc009jd3jypzqpblyap-nix-2.0.4.drv' failed with exit code 2
cannot build derivation '/nix/store/y89wiz0ykdp6hcvg7b0ppp04cbwh93ls-nix-prefetch-git.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/72np7kwgv2yganm97ccb1ac6nsam3jb5-dep2nix-0.0.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/72np7kwgv2yganm97ccb1ac6nsam3jb5-dep2nix-0.0.1.drv' failed


Conform scanning across mediums

This series of commits creates a new PwoDiscoverer class and conforms the different discoverers to this one interface.

Looking slick! And the plot thickens as we approach the vaunted uniform scanner. LGTM.


Allow to select an example on the front page

Marking this as "needs work" as I will to rebase this once we agree on #1775

Alrighty, finally thanks to the minimal solution in #1775 this should be ready.

First: Diff looks great! Thanks for not giving up.
Dropdown looks a bit weird for me, any idea why?

Okay, I think we can fix this by providing our own selector symbol from FontAwesome.
However, there are still UI differences:
Chrom(ium):

Firefox:

Alright, but why is that necessary? Why isn't the browser rendering the arrow?

Alright, but why is that necessary? Why isn't the browser rendering the arrow?

 If we exclude that block from having its color and background color set, it should use the native styling... with the downside that it will look a little weird to people who have their browsers set to have a light-on-dark color theme by default. I don't think we need to worry about that, as long as the website is not unusable to them.

I guess either way works, but if possible, I think it would be better to not rely on font-awesome for the front page.

If we exclude that block from having its color and background color set, it should use the native styling... with the downside that it will look a little weird to people who have their browsers set to have a light-on-dark color theme by default. I don't think we need to worry about that, as long as the website is not unusable to them.

That wouldn't look good:

I actually tried to be close to styling of the "Install X" boxes.

I guess either way works, but if possible, I think it would be better to not rely on font-awesome for the front page.

FWIW we already rely on it:

AFAICT it's the only way to ensure a consistent experience across different browsers.

That wouldn't look good:

No, that's not right. You're trying to undo the background rule with another background rule, right? That's not going to work. There must be no background rule in effect at all.

FWIW we already rely on it:

Ah, that's right.

Seb do you want to try the no-CSS approach or should we go forward with the current FontAwesome version?

Seb do you want to try the no-CSS approach or should we go forward with the current FontAwesome version?

Hmm, the no-CSS approach would look like this:

or should we go forward with the current FontAwesome version?

I am fine with both ways (slight preference on FontAwesome because it keeps the styling consistent).

Needs some tweaking for mobile:

Needs some tweaking for mobile:

Thanks. I came to the conclusion that tip box hasn't been used much over the last years and especially users on their phone most likely won't post an example, so imho the best solution is also the simplest here: hiding the tip box on devices with a narrow layout.

Still broken for very narrow widths:

Still broken for very narrow widths:

I can't really reproduce this in Chrome or FF, but I added max-width: 100% which should fix things even for these tiny layouts:

@CyberShadow does it work for you now?

@CyberShadow does it work for you now?

Looks perfect, thanks!

tip box hasn't been used much over the last years

Forgot to post this earlier, but I think you simply found a bug in the forum search (or SQLite indexing). I know I fixed one yesterday (regarding deleted posts), but that search and its variations is producing inconsistent results with some variations of it (for one, the query needs to search the subject, not body).


Company logo missing

There are several company logos that are missing. Check all the six opportunity pages and fix the issue.

I would like to work on this issue

Go ahead @boorah

@saisumanthkumar sure

@akanksha-raghav please add hacktoberfest topic to this repo

@akanksha-raghav it's eligible for codesee but inorder to eligible for hacktoberfest you have to add hacktoberfest topic to your repo
hacktoberfest-guideline for maintainers :- https://hacktoberfest.digitalocean.com/resources/maintainers


Make a store type an option

Dynamo is currently the only store type, but adding a flag/env variable for using a different value store will make adding additional store types easier

Would a git repo make sense as a backing store?

@wstrange Yes


LaTeX Rendering Fails with File Not Found Error on Non-Host

Describe what happened:
While working on a .tex file, I can build and render it on the host workstation, however, building and rendering the file on the "connected" workstation fails with a File Not Found error.
What was your system configuration?
OS Version[macOS/Windows]: macOS 10.14.6
Live Share Extension Version: 1.0.1510
Target Platform or Language [e.g. Node.js]: LaTeX
Excerpt from VSCode About Menu:
VS Code
Version: 1.41.1
Commit: 26076a4de974ead31f97692a0d32f90d735645c0
Date: 2019-12-18T14:57:51.166Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 18.7.0

Steps to Reproduce / Scenario:

Start a LiveShare session and open a .tex file.
Build and render successfully on host
See that it fails to build and render on "connected" station

Attached are the logs from the "connected" workstation.
Logs.zip

Thanks for reporting this @alichtman! I'm curious if you use a type of extension in VS Code for .tex files to syntactically work?

So this is what is probably happening: the extension that allows you to interpret LaTex syntax in VS Code implements it in a way such that it assumes the guest has a local LaTex file as well. So when using Live Share there is no guest side local file and it doesn't get remoted.
So unfortunately, this scenario is not supported currently by Live Share. Thanks for reporting it.