Setting "trusted hash" to older header breaks pruner and prevents startup

Celestia Node version
Commit: 7af07bd08f4eed66fbc9eee47762fd2c3365c89f
OS
MacOS
Install tools
No response
Others
No response
Steps to reproduce it

Set TrustedHash to a new header
start and sync the node
stop the node
set TrustedHash to an older header

Expected result
Node should sync the headers in between the newly set TrustedHash and the oldest stored header
Actual result
2024-12-11T16:53:11.668-0500	ERROR	pruner/service	pruner/service.go:107	failed to get last pruned header	{"height": 1, "err": "header: not found"}
2024-12-11T16:53:11.668-0500	WARN	pruner/service	pruner/service.go:109	exiting pruner service!
2024-12-11T16:53:12.300-0500	INFO	canonical-log	swarm/swarm_dial.go:620	CANONICAL_PEER_STATUS: peer=12D3KooWAAzkuwRBps6qar4Js54E37usSzW57N5QFeDdAVjxt6F1 addr=/ip4/<IP_ADDRESS>/tcp/2121 sample_rate=100 connection_status="established" dir="outbound"
panic: invalid type received %!s(<nil>)

goroutine 349 [running]:
github.com/celestiaorg/go-header/p2p.(*subscription[...]).NextHeader(0x10804cc00?, {0x10806e830, 0x140014e0cd0?})
	/Users/redacted/go/pkg/mod/github.com/celestiaorg/go-header@v0.6.3/p2p/subscription.go:47 +0x2ac
github.com/celestiaorg/celestia-node/share/shwap/p2p/shrex/peers.(*Manager).subscribeHeader(0x1400173a6e0, {0x10806e830, 0x140014e0cd0}, {0x10804c790, 0x14001ba5908})
	/Users/redacted/celestia-node/share/shwap/p2p/shrex/peers/manager.go:302 +0xac
created by github.com/celestiaorg/celestia-node/share/shwap/p2p/shrex/peers.(*Manager).Start in goroutine 198
	/Users/redacted/celestia-node/share/shwap/p2p/shrex/peers/manager.go:166 +0x3e8

Relevant log output
No response
Is the node "stuck"? Has it stopped syncing?
No response
Notes
No response

Might not be related to pruner, I noticed that warning seems to be there even after I nuked .celestia-light and started fresh

Hey @S1nus. Thanks for reporting. The fix is here with additional details.

Yeah, I though the issue was in the panic, that we have to fix anyway independently


Add battery indicator for outdoor sensors

https://user-images.githubusercontent.com/791721/224515192-eca07b14-e96e-4ad1-a160-feba6db6ab45.mp4


Cards not loading properly on Internet Explorer

The cards feature of Wing does not load properly on Internet Explorer (any version). The text ends up overlapping and it unreadable.

Not only cards. Pretty much everything on official website is broken in my IE11

@kbrsh

Do you have browser prefix? IE does not fully support flexbox without prefix.
https://caniuse.com/#feat=flexbox


slow response from private network

Hi,
I have an annoying behavior for a community server 8.5, docker setup. As long as i keep this instance connected to the internet, everything is going smoothly. After the server is no longer connected to the internet, all apps begin to respond slowly, about 10 seconds between choosing to change the context (seems to be a timeout), from 'documents' section to 'mail' section, for example. During the installation I'm using a public ip address for the host server and when I disconnect i'm using a private class of addresses.

Looking more carefully I realised that the browser is waiting for responses to some opened tcp connections with other external sites. Is there any way fix this?

Sorry for the delay of the reply.
The issue is in Docker. Please use m,y instruction below to fix it.
Docker specifies Google DNS servers by default. If your server is not going to have access to the Internet, we recommend that you change the default Docker DNS address to the address of your local DNS server. To do that go to the /etc/default/docker file and change the IP address in the following line to the IP address of a DNS server in your local network:
docker_OPTS="--dns <IP_ADDRESS>"
After it please open the files /var/www/onlyoffice/WebStudio/web.appsettings.config and specify if there is a parameter <add key="web.help-center" ?


Have test case for showing that plan-all swallows error messages

When running terragrunt plan-all any errors in terraform are swallowed.  This is in contrast to running terraform plan in the offending subdir.
This pull doesn't actually fix the behavior, but does add an integration test to demonstrate the issue.  Do you agree that this is change worth pursuing?  If so, any tips on where best to look to make the more specific change would be appreciated.

Ooh, nice, love the TDD!
Definitely worth fixing. Looks like #251 mentioned the same thing. #74 also mentions the need to save those logs to file, as reading them all in the console for a large number of modules being deployed in parallel is overwhelming.
I'm not sure where the bug is. Some likely starting points:

There is logic here to capture error streams and summarize them: https://github.com/gruntwork-io/terragrunt/blob/master/configstack/stack.go#L33-L38. Probably something is broken with this logic here.

Modules are executed here: https://github.com/gruntwork-io/terragrunt/blob/master/configstack/running_module.go#L187

TerragruntOptions, which contains the logger, is cloned here: https://github.com/gruntwork-io/terragrunt/blob/master/configstack/module.go#L81

I like the idea of having distinct files for the different streams, and I think I know how it could be tackled now, but this fix is a fair amount easier. There was just an if condition that resulted in errors not being printed if there was a very particular error message.

Ah, that fix makes sense. Do all the tests pass now?

All the other tests pass.  Not the new one I created though.  Something about how stderr + logger are interacting in the tests that I haven't fully worked out yet.  I'll have to punt a bit on that part for now, but will hopefully get back to that this week.

@brikis98 I would love to get this merged in before I start having more people using terragrunt , but the fact that my added test failed is preventing me from doing so in good conscience.  The problem is that I spent a couple of hours trying to manipulate stdout/stderr from the tests and just had to throw up my hands.  Is there another way of verifying this behavior, or perhaps you fixed it in another way (the part where plan-all would swallow error messages).

output := stdout.String()
errOutput := stderr.String()

What do those contain when you run your new test?

See output here
https://asciinema.org/a/xscN5iWx8Rcr1VNujBPtKRR4v

See output here https://asciinema.org/a/xscN5iWx8Rcr1VNujBPtKRR4v

Hm, the stdout/stderr flashes by before I can actually see it in that video. Could you paste it into a GitHub gist?

https://gist.github.com/jmahowald/1431cc274ad982ad005c0ae9c0f626cb
It's the capturing of stderr in the test that is not working correctly.

Ah, I see. I think what might be happening is that TerragruntOptions sets its Logger field via a call to util.CreateLogger here and here. The CreateLogger function always logs to os.Stderr, rather than whatever other Writer you may have specified. I think you fix that method to take in a Writer and set it to TerragruntOptions.ErrWriter, you'll be all set.

Thanks.  I had updated the Clone method and added in a CreateLoggerWithWriter function it was using.
I've checked that in, along with some other parts I can back out of when it's all working.
Still no dice, as I'm not sure how to get it in during the New call.  I'm not yet seeing the relationship between the App which does get an errWriter and the TerragruntOptions, but I'm suspecting that if I can figure that out/ a way to pass that errWriter into the options creation that it would be good.
Thanks

Looks like you're on the right track! Note my original message:

Ah, I see. I think what might be happening is that TerragruntOptions sets its Logger field via a call to util.CreateLogger here and here.

I think you only updated one of those two locations with your new CreateLoggerWithWriter function!

All clear now.  Thanks for al the help (and the great tool)

Removed the binary, there is one in master though BTW.
I had indeed missed a test, but have fixed with one more minor refactoring.  All tests now pass.
$ go test ./...
?       github.com/gruntwork-io/terragrunt      [no test files]
?       github.com/gruntwork-io/terragrunt/aws_helper   [no test files]
ok      github.com/gruntwork-io/terragrunt/cli  12.991s
ok      github.com/gruntwork-io/terragrunt/config       0.023s
ok      github.com/gruntwork-io/terragrunt/configstack  0.028s
ok      github.com/gruntwork-io/terragrunt/dynamodb     21.271s
?       github.com/gruntwork-io/terragrunt/errors       [no test files]
?       github.com/gruntwork-io/terragrunt/options      [no test files]
ok      github.com/gruntwork-io/terragrunt/remote       0.018s
ok      github.com/gruntwork-io/terragrunt/shell        6.555s
ok      github.com/gruntwork-io/terragrunt/test 185.592s
?       github.com/gruntwork-io/terragrunt/test/helpers [no test files]
ok      github.com/gruntwork-io/terragrunt/util 0.020s

Removed the binary, there is one in master though BTW.

Huh. So there is. Not sure when that happened, but thanks :)

I had indeed missed a test, but have fixed with one more minor refactoring. All tests now pass.

Fantastic. Thank you! Merging now.

@brikis98 Can you let me know when your next planned release is?  Trying to decide how much to jerry-rig in terms of creating my own build for our workstation pipeline.  If it's days, probably not, if it's weeks maybe so
Thanks

That's totally my bad. I meant to release this immediately, but just lost track of it. New release here: https://github.com/gruntwork-io/terragrunt/releases/tag/v0.13.3

(binaries are building now)


tabs?

on dmenu tabs are view as a box containing a cross. I think this is a dmenu 'problem', so its possible a 'solution' outside of dmenu source code. Say, we count the tabs on the clipboard text, then we eliminate them (for visualization) them we add them back (when text is selected). Wondering if clipmenu code would allow to do this and, is it even possible?

Hmm, why not just ask dmenu folks to add rendering, or add a patch yourself? clipmenu seems like the wrong place to do this.

I don't plan on patching and i doubt suckless guys will patch something other than memory leaks.
What I'm asking is if you could give me some hints on scripting, is it possible at all? I only see tabs on my clipboard and would probably keep trying to get around this on my fork, but still haven't found anything yet.
Anyway thanks for the program!

It's certainly possible, but it requires fixing on both the producer and consumer end.
To be honest I'm not hugely against the idea of printing special characters with backslash escapes, I'll think about it.

@explosion-mental if it helps, rofi doesn't have this rendering problem with tabs

It's certainly possible, but it requires fixing on both the producer and consumer end.
To be honest I'm not hugely against the idea of printing special characters with backslash escapes, I'll think about it.

If you're thinking of simple search and replace <TAB> => \t, then that's going to break when the input contains a literal "\t".
Perhaps some shenanigans can be done with invalid unicode codepoints, but I think that'll just bring back the issue of those codepoints getting rendered as "boxes with cross" on dmenu, no?


Autocomplete of Vuetify CSS utilities not working in Phpstorm

I'm using:

PhpStorm v2023.2
Pnpm v8.6.12
Dependencies:

@xanxuz
Maybe you can add Uno Preset to UnoCSS configiguration and use it instead Vuetify CSS Utilities, you can also install this plugin (community):
https://plugins.jetbrains.com/plugin/22204-unocss
I don't use Vuetify CSS Utilities, and so I have no idea if the problem is with the IDE or Vuetify.

Ok, I'm currently using the Uno preset and the IDE plugin (although it also has some problem with autocomplete too 😅)
Should I keep the issue open in case you solve it? There could be devs that relies on the Vuetify CSS utilities instead of Uno or Tailwind.


Hide the Models section of the generated Swagger UI

Hi, I am struggling trying to hide the Models section located at the bottom of the generated Swagger UI.
Is it possible to do that?
I have tried adjusting these 'spec' attributes with no success:
model_filter =  lambda tag: False
definition_filter =  lambda tag: False
All other "spec" settings work like a charm.
Any clue?
pd: I've already googled and reviewed the code and issues section of this repository but I can't find a solution.
thanks in advance

@ayanezeclac
I've solved this by doing the trick from #583.

@vuhuycto
Thank you very much. It Works!
specs= [
{
"title": "My API",
"description": "Welcome to My API without Model section. ",
"version": "1.0.0",
"endpoint": 'apispec_1',
`}


Header recommendation

I think it would be good to have a header before "The following table explains the types of consistency, and the conditions when they occur." to show more clearly that the table applies to both Windows and Linux VMs - as is it seems to belong to the Linux section.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2bdbfa0f-4305-1b2f-2dd9-a8c23e789a78
Version Independent ID: 7ceb2658-7fa8-3fbb-a9a6-81ddd40f4dd3
Content: Planning your VM backup infrastructure in Azure
Content Source: articles/backup/backup-azure-vms-introduction.md
Service: backup
GitHub Login: @markgalioto
Microsoft Alias: markgal

@dcbrown16 Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.


cln plugin config file

Core lightning needs to be restarted in order to update the peerswap configuration. This can be of a problem if a node has lots of channels and needs some significant amount of time to start up.
This PR introduces a alternate config file that can be used to configure peerswap. This way it is enough to only restart peerswap instead of the whole core lightning node.

A listconfig command is still missing, will add this soon.

Added command peerswap-listconfig

I need your opinions. I think it is too confusing to have two separate ways of configuring this. Meanwhile CLN won't fix the underlying problem soon.
How do people feel about removing the CLN config method entirely and instead use the config file?
Does it have a default path to look for its own config file? Same as the policy.conf path?
Being able to specify a different config file path from CLN config seems like a good idea except it has the same problem of confusing behavior where it behaves differently between CLN startup and plugin dynamic start. We can eliminate the confusion entirely by having it look for its own config file at a default path relative to HOME. Is this a good plan though?

Hmm I think having a separate config file might be confusing at first only because every other CLN plugin that has configurable options uses the CLN config file already and that is what people are accustomed to.
I haven't come across a plugin that has its own config file so I think it's a question of whether it's worth it to break away from that convention. IMO it should be fine to do so given CLN's userbase is relatively small and we already kind of break that convention with the policy.conf file. The best path might be to have both methods of configuring until there is a concrete timeline for CLN being able to reload its config while running.
That way people can have a separate file if they plan on modifying their config + reloading frequently.

Biggest problem is peerswap-config-path can't work due to the same reason we wanted a separate config file to begin with. https://github.com/ElementsProject/lightning/issues/5294 CLN behaves differently during startup than if the plugin is started later. CLN is currently incapable of passing config options to plugins during dynamic plugin start.
clightning_config.go contains ...
        if policyPath == "" {
                wd, err := os.Getwd()
                if err != nil {
                        return nil, err
                }
                policyPath = filepath.Join(wd, "peerswap", "policy.conf")
        }

Sadly I think our only choice now is to entirely drop getting options from CLN. It would be the least confusing if peerswap-plugin similarly detected the path from working directory.

[ ] CLN chooses the working directory for the plugin process so we don't need to hard-code default paths ourselves. (Fact check?)
[ ] It should log during peerswap initialization like Using peerswap datadir: /home/btc/.lightning/bitcoin/peerswap.
[ ] Note: Blank or missing peerswap.conf is valid. It is possible to use CLN peerswap without config at all if everything including the bitcoind/elementsd .cookie files are at default paths.
[ ] Let's also consider removing the option for policypath? The plugin needs write access to the datadir due to the policy.conf and swaps database. Let's instead use the working directory handed to us by CLN and read peerswap.conf in that same directory if it exists. There's no good reason to support arbitrary other pathnames?

@wtogami You suggested if no config is given (blank or no file) peerswap should try to connect to bitcoind AND elementsd with the default .cookie, if found at the default location.
Up until now the behavior was: If no bitcoin rpc config is given, we connect to the bitcoind that core-lightning is using, therefore we retrieve the bitcoin config from core-lightning.
For elementsd we also did not use the .cookie file but rather just tried the default port on localhost, no user, no password (that should fail). That way operators have to actively enable liquid instead of peerswap trying to connect to liquid without an operator approving.
Any thoughts?

For elementsd we also did not use the .cookie file but rather just tried the default port on localhost, no user, no password (that should fail). That way operators have to actively enable liquid instead of peerswap trying to connect to liquid without an operator approving.

I have never provided any PeerSwap config options via the CLN config. It currently uses elementsd automatically. Please keep it that way.

cmd/peerswap-plugin/main.go

You're correct it didn't read the cookie for bitcoind but it did for elementsd. Please keep this current behavior.

You are correct! Actually this is still part of the code (getElementsClient in main) and working. I'll move this to the config parser to make it more explicit what is going on.

I added some tests for cookie authentication.
This should be good to go now.

@grubles please test
Don't merge yet until the CLI syntax changes are also ready to merge. That way we break things only once. I'll handle the documentation and release.

@wtogami see #162

Running with a blank peerswap.conf file does not work. It appears to pull the config from CLN but if CLN uses a cookie file for bitcoind, then it by default tries port 0 which is incorrect:
plugin-peerswap-plugin: Starting bitcoin client with chain:signet, rpcuser:__cookie__, rpcpassword:be6c9bdcfe376eefc2464447c64dce19d2ee1655fdde66c1cd4bca53b7732802, rpchost:http://<IP_ADDRESS>, rpcport:0
2023-01-23T17:11:58.573Z INFO    plugin-peerswap-plugin: Exited with error: Post \"http://<IP_ADDRESS>:0\": dial tcp <IP_ADDRESS>:0: connect: connection refused

The minimum config file for getting both BTC and L-BTC swaps working was this:
[Bitcoin]
rpcuser=xxx
rpcpassword=xxx
rpcport=xxx

[Liquid]
rpcport=xxx
rpcwallet=xxx
rpcport=18884
enabled=true

@grubles I will have a look at this.

Please rebase.
Please also add code that exits with a warning if it detects old CLN PeerSwap config options. We don't want both to coexist because that will confuse people.

Exiting...

peerswap-plugin currently works with zero peerswap* options in CLN config. It should behave identically after this change with a blank or missing peerswap.conf where it tries defaults for that chain. CLN does tell plugins what chain?

@wtogami Yes, we get this information from the listconfigs command, the bcli plugin holds a field network.

[ ] Let's also consider removing the option for policypath? The plugin needs write access to the datadir due to the policy.conf and swaps database. Let's instead use the working directory handed to us by CLN and read peerswap.conf in that same directory if it exists. There's no good reason to support arbitrary other pathnames?

I don't see why we should not allow for a different location, but I am happy to remove the option If you think otherwise. If we remove this option, how about the db path?

Sorry for the messy PR. I got really annoyed by the way we handled the config before and reworked it into some kind of pipes and filter pattern which hopefully will be easier to maintain and to find bugs.
@wtogami @grubles Does auto load from the elementsd cookie file now work for you?

With a missing CLN peerswap.conf, only Bitcoin swaps are enabled. With a bare minimum LND peerswap.conf (with cert + macaroon paths), only Bitcoin swaps are enabled as well.

Oh is it because the default is to try port 7041?
plugin-peerswap-plugin: Starting with config: {\"DataDir\":\"/home/user/.lightning/signet\",\"DbPath\":\"/home/user/.lightnin
g/signet/peerswap\",\"PolicyPath\":\"/home/user/.lightning/signet/policy.conf\",\"Bitcoin\":{\"RpcUser\":\"__cookie__\",\"RpcPassword\":\"7184b487cf71af0d053b
bb0d97527588bb7744a32fbcf5a96fbd05ea6a49504d\",\"RpcPasswordFile\":\"/home/user/.bitcoin/signet/.cookie\",\"RpcHost\":\"http://<IP_ADDRESS>\",\"RpcPort\":38332,\
"Network\":\"signet\",\"DataDir\":\"/home/user/.bitcoin\"},\"Liquid\":{\"RpcUser\":\"\",\"RpcPassword\":\"\",\"RpcPasswordFile\":\"/home/user/.elements/testne
t/.cookie\",\"RpcHost\":\"http://<IP_ADDRESS>\",\"RpcPort\":7041,\"RpcWallet\":\"peerswap\",\"Network\":\"testnet\",\"DataDir\":\"/home/user/.elements\",\"Enable
d\":false}}

Yes @grubles the „liquid“ default port is assumed. If I remember correctly, the elements and bitcoin signet/testnet/regtest default ports are the same.

Do you mean to say that the ports do not change between the different networks? Each has its own specific default port.

Do you mean to say that the ports do not change between the different networks? Each has its own specific default port.

What I meant is, that elementsd and bitcoind both have the same default ports for the different networks (each).
Shall we assume liquidtestnet with 18884 or liquid with 7041 as default chain if an empty config is given (elementsd defaults to 7041 according to elementsd --help)?

Based on my log above, it appears like peerswap is able to detect I'm running on Liquid testnet but seems to be using the wrong directory for the .cookie file (/home/.elements/testnet, should be /home/.elements/liquidtestnet).
If we're able to detect the Elements chain, can we set the appropriate port automatically?

Based on my log above, it appears like peerswap is able to detect I'm running on Liquid testnet but seems to be using the wrong directory for the .cookie file (/home/.elements/testnet, should be /home/.elements/liquidtestnet).
If we're able to detect the Elements chain, can we set the appropriate port automatically?

Sure! Is there a default port for liquidregtest that I can assume? Or do we just fallback to 18884 if the chain is not liquid?
Dir detection is not a problem either I would expand to differentiate between liquid liquidregtest and liquidtestnet.

Let's use these ports:
liquidv1: 7041
liquidtestnet: 18891 (from https://liquidtestnet.com/)
regtest: 18443 (from elementsd --help)

Now with a minimal peerswap.conf with:
[Liquid]
enabled=true

...both BTC and L-BTC swaps are enabled for CLN.
2023-02-17T16:23:44.031Z INFO    plugin-peerswap-plugin: Cln synced, continue...
2023-02-17T16:23:44.031Z INFO    plugin-peerswap-plugin: Starting elements client with rpcuser: __cookie__, rpcpassword: 54117b81d494db02941d45adb9d84fa147172ece5259974b5818e2a8ed84c184, rpccookie: /home/user/.elements/liquidtestnet/.cookie, rpcport: 18891, rpchost: http://<IP_ADDRESS>
2023-02-17T16:23:44.053Z INFO    plugin-peerswap-plugin: Liquid swaps enabled
2023-02-17T16:23:44.054Z INFO    plugin-peerswap-plugin: Starting bitcoin client with chain:signet, rpcuser:__cookie__, rpcpassword:7184b487cf71af0d053bbb0d97527588bb7744a32fbcf5a96fbd05ea6a49504d, rpchost:http://<IP_ADDRESS>, rpcport:38332
2023-02-17T16:23:44.054Z INFO    plugin-peerswap-plugin: Bitcoin swaps enabled
2023-02-17T16:23:44.054Z INFO    plugin-peerswap-plugin: Using gbitcoind estimator
2023-02-17T16:23:44.055Z INFO    plugin-peerswap-plugin: using policy:
2023-02-17T16:23:44.055Z INFO    plugin-peerswap-plugin: allow_new_swaps: true
2023-02-17T16:23:44.055Z INFO    plugin-peerswap-plugin: min_swap_amount_msat: 100000000
2023-02-17T16:23:44.055Z INFO    plugin-peerswap-plugin: reserve_onchain_msat: 0
2023-02-17T16:23:44.055Z INFO    plugin-peerswap-plugin: allowlisted_peers: [035ca2fe4793a5e789ce846062eb4834f573c060d9200ce77544a29b48a0aa5923]
2023-02-17T16:23:44.055Z INFO    plugin-peerswap-plugin: accept_all_peers: false
2023-02-17T16:23:44.055Z INFO    plugin-peerswap-plugin: suspicious_peers: []
2023-02-17T16:23:44.055Z INFO    plugin-peerswap-plugin:
2023-02-17T16:23:44.121Z DEBUG   035ca2fe4793a5e789ce846062eb4834f573c060d9200ce77544a29b48a0aa5923-connectd: peer_out INVALID 42085
2023-02-17T16:23:44.126Z INFO    plugin-peerswap-plugin: peerswap initialized

The new listconfig command works:
$ lightning-cli --signet peerswap-listconfig
{
   "dbpath": "/home/user/.lightning/signet/peerswap",
   "bitcoin.rpcuser": "__cookie__",
   "bitcoin.rpcpassword": "7184b487cf71af0d053bbb0d97527588bb7744a32fbcf5a96fbd05ea6a49504d",
   "bitcoin.rpcpasswordfile": "/home/user/.bitcoin/signet/.cookie",
   "bitcoin.rpchost": "http://<IP_ADDRESS>",
   "bitcoin.rpcport": 38332,
   "bitcoin.rpccookiefilepath": "/home/user/.bitcoin/signet/.cookie",
   "liquid.rpcuser": "__cookie__",
   "liquid.rpcpassword": "54117b81d494db02941d45adb9d84fa147172ece5259974b5818e2a8ed84c184",
   "liquid.rpcpasswordfile": "/home/user/.elements/liquidtestnet/.cookie",
   "liquid.rpchost": "http://<IP_ADDRESS>",
   "liquid.rpcport": 18891,
   "liquid.rpcwallet": "peerswap",
   "liquid.enabled": true,
   "policypath": "/home/user/.lightning/signet/policy.conf",
   "ConfigFilePath": "/home/user/.lightning/signet/peerswap.conf"
}

Is the intended default behavior such that the user needs to explicitly enable Liquid swaps or is that supposed to be automatically enabled if Peerswap detects a running elementsd? In the PR's current state, I have to create a peerswap.conf file with:
[Liquid]
enabled=true

to get L-BTC swaps working.

We always had the enabled flag so I assumed that it has to be true to activate l-btc swaps, while we have no flag for btc swaps to enable/disable them. If l-btc should be enabled by default if an elementsd installation is detected we would have to change to a disabled flag as the default boolean value if non is given is false.

The current code works with L-BTC swaps enabled with no config options at all. If it detects elementsd it uses it. Please keep it that way.

Okay, then I don't see the reason for an enabled flag altogether. Shall we change it to a disabled flag to provide a way to disable L-BTC swaps?

Yes

Rebased to include the ci fix.

Can add that if you like, currently it only logs if the disabled option is set.

2023-03-15T15:40:08.912Z INFO    plugin-peerswap-plugin: Cln synced, continue...
2023-03-15T15:40:08.912Z INFO    plugin-peerswap-plugin: Liquid swpas disabled
2023-03-15T15:40:08.912Z INFO    plugin-peerswap-plugin: Starting bitcoin client with chain:signet, rpcuser:__cookie__, rpcpassword:401d998cd06fae00bcdfeabea405ca2bc84dac3fa0c55783a15b438a61a5040b, rpchost:http://<IP_ADDRESS>, rpcport:38332

TY. Message is back but there's a typo "swpas".

My mainnet deployment has bitcoind, lightningd, and elementsd running with default pathnames within the same non-root user.
bitcoind: ~/.bitcoin/
lightnind: ~/.lightning/
elementsd: ~/.elements/
CLN's ~/.lightning/config contains zero peerswap-* options. I expect peerswap after this PR to behave the same with auto-detected defaults from the environment but it doesn't.
2023-03-17T19:48:06.830Z INFO    plugin-peerswap: PeerSwap starting up with commit 9b4e55b04d804fb6a393bd9cf1504c3e831ab3d1
2023-03-17T19:48:06.830Z INFO    plugin-peerswap: DB version: v0.2, Protocol version: 3
2023-03-17T19:48:06.830Z INFO    plugin-peerswap: Using data dir: /home/bitcoin/.lightning/bitcoin
2023-03-17T19:48:06.853Z INFO    plugin-peerswap: Could not read config: can not get network dir for bitcoin network: bitcoin
2023-03-17T19:48:06.853Z INFO    plugin-peerswap: Exited with error: can not get network dir for bitcoin network: bitcoin

We never had anything in our datadir named mainnet.
I did a search and replace /s/mainnet/bitcoin/g within clightning/config.go and it got a little further.
2023-03-17T20:43:39.812Z INFO    plugin-peerswap: PeerSwap starting up with commit 9b4e55b04d804fb6a393bd9cf1504c3e831ab3d1
2023-03-17T20:43:39.812Z INFO    plugin-peerswap: DB version: v0.2, Protocol version: 3
2023-03-17T20:43:39.812Z INFO    plugin-peerswap: Using data dir: /home/bitcoin/.lightning/bitcoin
2023-03-17T20:43:39.847Z INFO    plugin-peerswap: Could not read from bitcoin cookie: /home/btc/.bitcoin/bitcoin/.cookie
2023-03-17T20:43:39.877Z INFO    plugin-peerswap: Using core-lightning version v23.02.2
2023-03-17T20:43:39.877Z INFO    plugin-peerswap: Waiting for cln to be synced...
2023-03-17T20:43:49.923Z INFO    plugin-peerswap: Cln synced, continue...
2023-03-17T20:43:49.923Z INFO    plugin-peerswap: Starting elements client with rpcuser: __cookie__, rpcpassword: REDACTED, rpccookie: /home/bitcoin/.elements/liquidv1/.cookie, rpcport: 7041, rpchost: http://<IP_ADDRESS>
2023-03-17T20:43:50.013Z INFO    plugin-peerswap: Liquid swaps enabled
2023-03-17T20:43:50.014Z INFO    plugin-peerswap: Exited with error: unknown bitcoin network

/home/bitcoin/.bitcoin/bitcoin/.cookie isn't the default path where the .cookie file is written. By default it is created at ~/.bitcoin/.cookie

As an ugly hack I got it to start by renaming s/mainnet/bitcoin/ in clightning/config.go and that one spot in cmd/peerswap-plugin/main.go. Then I removed netdir from the pathname before .cookie.
But this isn't the solution because the peerswap spec calls it mainnet.
I then discovered a new problem. Previous peerswap would put its database and policy.conf in ~/.lightning/bitcoin/peerswap/ but now it's putting it in ~/.lightning/bitcoin/. Not 100% sure if that happened as the result of my temporary hacks. Please check.
Are we currently hard coding the netdir based upon the network name? CLN provides plugins the directory to use for writing as the cwd or current working directory. We shouldn't second guess that. This way peerswap would work automatically with any non-default specified --lightning-dir=.
Tasks

[ ] Special case pathname "bitcoin" while keeping peerswap's network name as "mainnet".
[ ] Investigate where bitcoind puts the .cookie file for mainnet, it may differ with $HOME default vs specified -datadir. Default is ~/.bitcoin/.cookie.
[ ] Ensure peerswap/ directory is used within the CLN provided working directory.
[ ] Get rid of peerswap-db-path. Is there a good reason to use it?

We have a possible alternative of asking CLN how it is accessing bitcoind. However maybe we don't want to use this because peerswap isn't guaranteed to be using bcli. There exist a few drop-in replacements including block explorer lookup.
lightning-cli listconfigs
      {
         "path": "/home/bitcoin/libexec/c-lightning/plugins/bcli",
         "name": "bcli",
         "options": {
            "bitcoin-datadir": null,
            "bitcoin-cli": null,
            "bitcoin-rpcuser": null,
            "bitcoin-rpcpassword": null,
            "bitcoin-rpcconnect": null,
            "bitcoin-rpcport": null,
            "bitcoin-retry-timeout": null,
            "commit-fee": null
         }
      },

Something weird is happening with using elementsd via RPC too:
2023-03-17T21:44:19.977Z INFO    plugin-peerswap: Could not read config: can not get liquid network dir for bitcoin network: bitcoin
2023-03-17T21:44:19.977Z INFO    plugin-peerswap: Exited with error: can not get liquid network dir for bitcoin network: bitcoin

@wtogami Thanks for testing and reporting!

Indeed,  core-lightning reports the network bitcoin when using main/mainnet chain that messed up with the path finding and Is the reason for your first error and also @grubles latest report.
I can also confirm the default path to the cookie file is /$HOME/.bitcoin/.cookie for empty config. I guess this is what we should support for the default case then. If people are using --datadir the cookie file is inside of the datadir (with optional network subdir), e.g. someone using -datadir="$HOME/.bitcoin/mydir results in the cookie file path $HOME/.bitcoin/mydir/<optional-network>/.cookie. So IF we get the datadir e.g. by core-lightnings listconfigs command, we can assume the cookie file at this place. Otherwise the user needs to set peerswap config to point to the location of the cookie file. The cookie file gets wiped on shut down of bitcoind so we don't have to care about old state.
Elements default dir (empty config) is $HOME/.elements/liquidv1 which is where the cookie file is located.
About the peerswap database file location: We get the peerswap datadir from the cwd that core-lightning sets for the peerswap child process. That is the lightning-dir. I was in believe that we said we want a flat directory structure and do not want to create a  lightning-dir/peerswap directory anymore to store peerswap related data as the peerswap.conf was located next to lightning relevant files inside of the lightning-dir. We could however place all peerswap related data (db, policy.conf) in a peerswap subdir.

I agree that we can get rid of the peerswap-db-path. People can just move their db file if the assumed location changes instead of setting an option pointing to the file.

@wtogami About the peerswap dir inside of the `lightning-dir. Shall this dir contain all peerswap related files? That would be:

config peerswap.conf
policy policy.conf
db peerswap

Correct?

Yes

Add PeerswapDir to config

When I suggested removing the peerswap datadir option it was because I suggested it always create a "peerswap" directory in the current working directory handed it to the plugin by CLN, as was the default behavior prior to this PR.
Why make this configurable? I don't feel strongly about this but if there isn't a good reason I'd prefer we don't have an option.

I was in believe that we said we want a flat directory structure and do not want to create a lightning-dir/peerswap directory anymore

I don't recall this discussion. It is a valid design choice but now it has a switching cost for existing deployments. Is there a good reason in the long-term to not have all the peerswap config, policy and state in its own child directory?

Using a fresh CLN datadir and using CLN v23.02.2 on signet:

Peerswap sub diretory created
BTC swaps automatically enabled. bitcoind .cookie file detected.
BTC and L-BTC swaps automatically enabled. Both bitcoind and elementsd .cookie files detected when elementsd is running.
All working without a peerswap.conf file

Although on mainnet, the plugin exits:
2023-04-10T19:43:47.270Z INFO    plugin-peerswap: Exited with error: unknown bitcoin network

please test that blank config file is equal to missing.
What peerswap calls mainnet internally is different from CLN. We can't rename it in peerswap because it's in the wire protocol. So we need to hatdcode substitution in peerswap.

Tested with a blank peerswap.conf at:
~/.lightning/signet/peerswap/peerswap.conf
Both BTC and L-BTC swaps were enabled.

Testing newest commits against CLN v23.02.2 and LND v0.16.1-beta:

Peerswap subdirectory is created, swap database and policy file are created there
Automatically finds bitcoind and elementsd signet cookie files, enables BTC and L-BTC swaps.
Blank and missing peerswap.conf work
Peerswap detects Bitcoin mainnet successfully, finds bitcoind / elementsd cookie files
Tested signet BTC and L-BTC swaps with both CLN and LND as swap initiators


Server error for regl-camera

URL<EMAIL_ADDRESS>Error:
ENOENT: no such file or directory, stat '/var/app/current/.tmp/2623c0b9d4d77b74809816caf99130166322fc1b/package.tgz'

I can confirm that the URL was working approx. 10 days ago.

It's working on my side. I invalided the URL in the CDN, could you please retry?

Yup, it's working again. Thanks!


Add missing columns in table_azure_servicebus_namespace

Reference link: https://github.com/Azure/azure-sdk-for-go/tree/main/services/preview/servicebus/mgmt/2021-06-01-preview/servicebus

Closing this since the issue is not on priority.


US 1583733 Add missing language IDs - 60

US 1583733 - Fix CATS P1 issues by adding missing language IDs to code blocks.

Used "sql" for all Entity SQL syntax and code examples.

Contributes to #2192

@Youssef1313 Thanks. I made your suggested changes.

@mairaw Thanks. I made the suggested changes.


Release V0.0.2

Features

[x] Dependency Injection System
[x] Modular System
[x] Mono-repo

Temporarily close this PR to prevent unnecessary workflow runs.


Realm v5.0.0: reference binding to null pointer of type 'realm::Transaction'

Xcode Version 11.4.1 (11E503a)
RealmSwift (5.0.0) installed by Cocoapods

At startup, the following message is output on Xcode:
[1m/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3931:17: runtime error: reference binding to null pointer of type 'std::__1::shared_ptr<realm::Transaction>::element_type' (aka 'realm::Transaction')
/iOS/Pods/Realm/Realm/ObjectStore/src/impl/realm_coordinator.cpp:910:52: runtime error: reference binding to null pointer of type 'realm::Transaction'
/iOS/Pods/Realm/Realm/ObjectStore/src/impl/realm_coordinator.cpp:795:12: runtime error: reference binding to null pointer of type 'realm::Transaction'

@aplusm Can you please fill out the entire issue template? Especially about how to reproduce this.
Thanks!

Sorry, the issue is not clear on my side. Will close this and reopen when things will be clearer.


Moviesmanager to ViewState and no storyboard

Codecov Report

Merging #167 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   61.09%   61.14%   +0.05%
==========================================
  Files         139      139
  Lines        2714     2718       +4
==========================================
+ Hits         1658     1662       +4
  Misses       1056     1056

Impacted Files
Coverage Δ

...Movies/Manager/MoviesManagerDefaultPresenter.swift
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 980bcff...25d6ae7. Read the comment docs.


Question about filtering

How does filter query works? Specifically:

What filter conditions are supported?
Is filtering done before or after similarity calculation?

Thanks

1、filter conditions support  field range filter,  but the field should be indexed when creating tables.
2、filtering is done before similarity calculation in order to avoid unnecessary calculation.


Remove advanced_modules_enabled from example

Since #1001, the plugins.security.advanced_modules_enabled configuration setting has been deprecated, so this PR removes this setting from the example configuration to avoid confusion and deprecation warnings.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks for the contribution @wjordan I'll take a more detailed look tomorrow.


"pip install path.py" failure

Hi, i have the following output when I try to instal the package (it seems that pip doesn't work properly)
Thank you in advance for any suggestion.
$ pip install path.py
Collecting path.py
Exception:
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/pip/basecommand.py", line 209, in main
status = self.run(options, args)
File "/usr/lib/python2.7/dist-packages/pip/commands/install.py", line 328, in run
wb.build(autobuilding=True)
File "/usr/lib/python2.7/dist-packages/pip/wheel.py", line 748, in build
self.requirement_set.prepare_files(self.finder)
File "/usr/lib/python2.7/dist-packages/pip/req/req_set.py", line 360, in prepare_files
ignore_dependencies=self.ignore_dependencies))
File "/usr/lib/python2.7/dist-packages/pip/req/req_set.py", line 512, in _prepare_file
finder, self.upgrade, require_hashes)
File "/usr/lib/python2.7/dist-packages/pip/req/req_install.py", line 273, in populate_link
self.link = finder.find_requirement(self, upgrade)
File "/usr/lib/python2.7/dist-packages/pip/index.py", line 442, in find_requirement
all_candidates = self.find_all_candidates(req.name)
File "/usr/lib/python2.7/dist-packages/pip/index.py", line 400, in find_all_candidates
for page in self._get_pages(url_locations, project_name):
File "/usr/lib/python2.7/dist-packages/pip/index.py", line 545, in _get_pages
page = self._get_page(location)
File "/usr/lib/python2.7/dist-packages/pip/index.py", line 648, in _get_page
return HTMLPage.get_page(link, session=self.session)
File "/usr/lib/python2.7/dist-packages/pip/index.py", line 757, in get_page
"Cache-Control": "max-age=600",
File "/usr/share/python-wheels/requests-2.9.1-py2.py3-none-any.whl/requests/sessions.py", line 480, in get
return self.request('GET', url, **kwargs)
File "/usr/lib/python2.7/dist-packages/pip/download.py", line 378, in request
return super(PipSession, self).request(method, url, *args, **kwargs)
File "/usr/share/python-wheels/requests-2.9.1-py2.py3-none-any.whl/requests/sessions.py", line 468, in request
resp = self.send(prep, **send_kwargs)
File "/usr/share/python-wheels/requests-2.9.1-py2.py3-none-any.whl/requests/sessions.py", line 576, in send
r = adapter.send(request, **kwargs)
File "/usr/share/python-wheels/CacheControl-0.11.5-py2.py3-none-any.whl/cachecontrol/adapter.py", line 46, in send
resp = super(CacheControlAdapter, self).send(request, **kw)
File "/usr/share/python-wheels/requests-2.9.1-py2.py3-none-any.whl/requests/adapters.py", line 376, in send
timeout=timeout
File "/usr/share/python-wheels/urllib3-1.13.1-py2.py3-none-any.whl/urllib3/connectionpool.py", line 610, in urlopen
_stacktrace=sys.exc_info()[2])
File "/usr/share/python-wheels/urllib3-1.13.1-py2.py3-none-any.whl/urllib3/util/retry.py", line 228, in increment
total -= 1
TypeError: unsupported operand type(s) for -=: 'Retry' and 'int'

It looks like you’ve stumbled on a bug in urllib3 or requests or pip. Do you only get this error when installing path.py? I recommend reporting this issue with pip, especially if you can repeat the failure.

Yes, I have just this error.


[CLI] keyserver timeout when downloading PGP key

When downloading your PGP key as explained in the README, I got the following error:
$ gpg --keyserver pgp.mit.edu --recv-keys 22598A94
<...snip...>
gpg: requesting key 22598A94 from hkp server pgp.mit.edu
gpg: keyserver timed out
gpg: keyserver receive failed: keyserver error

I tried this suggestion, which worked.
$ gpg --keyserver hkp://pgp.mit.edu:80 --recv-keys 22598A94
gpg: requesting key 22598A94 from hkp server pgp.mit.edu
gpg: /home/ubuntu/.gnupg/trustdb.gpg: trustdb created
gpg: key 22598A94: public key "SANS Investigative Forensic Toolkit<EMAIL_ADDRESS>imported
gpg: Total number processed: 1
gpg:               imported: 1

I recommend you update the README to specify the full domain:port hkp://pgp.mit.edu:80

For me, as of today, the original README syntax is what is what worked for me, while the suggested syntax is not working. ; )


Jinxin

This merge contains:

database APIs for ensemble and distributed data type
fix in the schema
fix in the signal testing module

Because the complex history of this pull request brings in (see discussions here), we need to merge this pull request and has the exception issue as well as documentations fixed later.

Because the complex history of this pull request brings in (see discussions here), we need to merge this pull request and has the exception issue as well as documentations fixed later.


Add sprint report for Sprint 21

Looks good:+1:
Once you fixed the few typos and updated the image links, we can merge this.

@bgeuken, could you re-review it :smile_cat:

Great!
Let's ship it


Writer: replace add_scalars with add_scalar

Both functions show the logged values in Tensorboard, however 'add_scalar' is much cleaner:
Previously add_scalars would create a new run folder for each tag, and the description would contain the key twice (e.g. key='eval/reward' results in description: run/eval/reward/eval/reward). This resulted in Tensorboard showing multiple runs while actually only doing a single run with different tags.
The new method can be combined with the old method since both will still write to the same summaryboard.

Good find, thank you!


Possible merger with ddnsc

ddnsc is a similar project, however it supports multiple dns providers. I think it would make sense to merge this project with ddnsc so there can be one package that supports many providers, especially since they are both already written in python.

Feel free to fork this repo and do the merger ddnsc.  I no longer have time or interest to do it myself.  Thanks.


fix: redirect user to accounts page if changed wallet while on an account

Description
Redirecting users to the accounts page if they switched the connect wallet while visiting an account page (/accounts/:accountId/:assetId?), since these pages are related to the connected wallet there will be the necessity to select another account of the connected wallet.
Notice
Before submitting a pull request, please make sure you have answered the following:

[ x] Have you followed the guidelines in our Contributing guide?
[ x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ x] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
closes #978
Testing
Please outline all testing steps

Pull branch locally and run yarn to install new deps
Connect to a wallet and go to the accounts page
Click on an account
Switch connected wallet
You should be redirected to the accounts page

Screenshots (if applicable)

@Neverwas-dev can you plz QA this fleek build link at the bottom of the PR as you are the original sponsor of this bounty?

@stackedq thanks for fixing up the PR title - can you please do git commit --allow-empty -m "chore: trigger ci" && git push to push an empty commit and it will rerun with the new title?

@Neverwas-dev can you plz QA this fleek build link at the bottom of the PR as you are the original sponsor of this bounty?

Yep np


fix: fetching operator schema from backend

https://github.com/bcgov/cas-cif/issues/1475

The "Changes Saved" indicator moved under the header instead of in-line on the right


QEWD - MDT - Service / team data is not populated

http://prntscr.com/fhc79t - comes as an empty value from middleware - should be sorted out on marand / ethercis level;

Please log as qewd-ripple related issue then
T
On 14 June 2017 at 12:51, dkryvosheya<EMAIL_ADDRESS>wrote:

http://prntscr.com/fhc79t - comes as an empty value from middleware -
should be sorted out on marand / ethercis level;
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/RippleOSI/Ripple-Qewd/issues/37, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5X3Kn_vgXuSRV29xmb-Zii4tIk8otcks5sD8lagaJpZM4N5xXV
.

MDT is now working.  Included in build 2.27 installer.  Installed and working on dev and demo machines

Thanks @robtweed , working my side too.


Fix overflow check of convertStringToInt

Fixes https://github.com/facebookincubator/velox/issues/9442.

Hi @kgpai @Yuhta, would you like to take a review? Thanks!

Hi @mbasmanova, could you help review this fix? Thank you.

@kgpai Appreciate your help.


dialog sizes don't fit, can't see buttons

That interface really needs to be created into more steps - it's not a good UI flow.
It is scrollable though.

On that one only the grayed out interface scroll down. I completely agree
it need better flow like keeping the password shown when account creation
operation is done.
On Sun, Jun 3, 2018, 00:46 Aaron Cox<EMAIL_ADDRESS>wrote:

That interface really needs to be created into more steps - it's not a
good UI flow.
It is scrollable though.
[image: scrollabl]
https://user-images.githubusercontent.com/677686/40883315-9a077882-66c7-11e8-9d73-d4ffcb9c56da.gif
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aaroncox/vessel/issues/95#issuecomment-394134903, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAXubNvCEF0Y9imaXk7076d9ItnsZiAJks5t42o_gaJpZM4UXz8s
.


stage1: rkt dir lock is not retained in stage1 when compiled in "src" flavor

Issue
When stage1 is built in "src" flavor rkt tool considers container as "exited" despite of the fact that it's running.
How to reproduce

Compile the stage1 with "src" flavor
Launch any container using "rkt" tool using stage1 built with src flavor
Execute rkt list command

Expected results
rkt tool should display "running"
Actual results
rkt tool displays "exited"

Fixed by #754


fix timing bug in serializer tests

Fixes issue #152
The issue was not waiting for the open event on the new writable
stream before attempting to verify the file was there and contained
anything that was recently written to it.

@dmajda this should fix the problem from now on, wasn't easy since the open event business is not documented anywhere in the node fs module documentation. I figured things out when I read a stackoverflow article over here: http://stackoverflow.com/a/12906805/1364656
I was hitting this when running in a loop like so:
while [ $? == 0 ]; do mocha test/adapters/serializers; done

within a minute and now ran for over 5 minutes without any issues so it was just simply the issue of not waiting for the stream to open (ie exist) before proceeding.

Looks good to me.

@rlgomes Thanks!


docs(FormGroup): incorrect icon in description slot example

🔗 Linked issue
❓ Type of change

[x] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
docs: fix - typo fix in /components/form-group#description  - aligned code example with visual render
ui.nuxt.com/components/form-group#description
The code snippet Icon name was not aligned with the displayed example - this PR fixes it
📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Thanks 😊


NPE when dispose

Describe the bug
NPE when calling dispose. I am not so sure but It seems the animationTimer is still running after the canvas disposed. Or dispose() is not threadsafe
To Reproduce
canvas = new GLCanvas(executor, profile, flipY, msaa, true);
canvas.setAnimator(animator);
canvas.dispose();

On my machines it happened sometimes, not always. Need some good lucks, I guess :)
Screenshots

Environment:

OS: Windows 11
openglfx version: 4.0.5

Check the new release 4.1.0.
If the problem is not solved, then reopen the issue


Runs are not being sorted in Dataset Single page

Steps to Reproduce

Click on Browse all data
Click on a Dataset
Locate Runs table
Click on "Runs"

Expected Results
Runs should be sorted
Evidence
https://github.com/chanzuckerberg/cryoet-data-portal/assets/63799148/252eba09-05cf-4716-8556-a96f68774fe8

@lauramarcos i didn't see the drop down arrow that indicates there's sorting. do you still see it on your side?


⚠ Bofrost.be has degraded performance

In 3fea341, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1032 ms

Resolved: Bofrost.be performance has improved in 38f58b0.


Automatically register the codecs for CqlVectorType in CachingCodecRegistry

This is probably a useful idea for a future Java driver release but it is not required to add support for the vector type to dsbulk.  See this PR for an example of how we can support the vector type in dsbulk using only a stock Java driver.

for reference:
https://github.com/datastax/pulsar-sink/pull/59

This issue has been addressed by changes in #1666.  If there's something else we need to consider please re-open and add a comment!


Raise the timeout in quic_client_test.c

Recently the Coveralls CI run started failing
because it times out in this test.
Outside of Coveralls it runs fine so assuming that this is caused by slow execution under Coveralls.

This pull request is ready to merge

Merged to the master branch. Thank you for the reviews.


Fix PassClient.updateObject handling of null values

This pr makes sure that PassClient.updateObject correctly serializes null values into the JSON API document for the patch request. Before attributes and relationships with null values were not included in the serialization which prevented those values from being deleted when doing an update.
Handling the to one relationships was a bit awkward, but it seems to work. Handling the too many relationships required making sure that the lists holding the references are never null.
In order to test do a mvn clean verify.

Oh, you merged this PR already.  I guess you can take a look at my comments and do them in a separate PR if needed.

Also, I was surprised you were able to merge this PR without at least one approval?  Is the main branch not protected?


use new Kilt >= 0.2 syntax, add mention in readme for clarity

Since Kilt >= 0.2 (now v0.3.0), there's a simpler Kilt.render method to embed to a String directly.
Also, some templating engines take other arguments therefore that's now possible with the args splat.
I've added a mention in the README so that people understand a little better why the kilt dependency.

:+1:

Thanks a lot :+1: I'll release Kemal 0.9.2 with these changes.


Autorest Regen Preview to 3.0.0-alpha.20240304.10 by Dapeng Zhang from refs/pull/4306/merge

Triggered from https://github.com/Azure/autorest.csharp/pull/4306

API change check
API changes are not detected in this pull request.


5.2.2. Xpack config

I've copied the following docker config from the elastic website and cannot get the xpack monitoring to stop reporting errors
FROM docker.elastic.co/logstash/logstash:5.2.2
RUN rm -f /usr/share/logstash/pipeline/logstash.conf
ADD pipeline/ /usr/share/logstash/pipeline/
ADD config/ /usr/share/logstash/config/
config/logstash.yml
xpack.monitoring.enabled: false
If I run the 5.2.2-env everything works as expected but I don't see why following the instructions from the website and adding my own logstash.yml config file does not work. I've exec'd into the container and can see my changes in logstash.yml but they seem to be ignored although creating a deliberate syntax error stops the container from running which is expected.

Hi @dbroadhurst. I can't seem to reproduce this, sorry.
Here's my attempt:
#!/bin/bash

mkdir -p config
cat > config/logstash.yml <<EOF
xpack.monitoring.enabled: false
EOF

mkdir -p pipeline
cat > pipeline/logstash.conf <<EOF
input{
  heartbeat{
    interval => 10
    message => "Greetings, Human!"
  }
}

output{
  stdout{
    codec => rubydebug
  }
}
EOF

cat > Dockerfile <<EOF
FROM docker.elastic.co/logstash/logstash:5.2.2
RUN rm -f /usr/share/logstash/pipeline/logstash.conf
ADD pipeline/ /usr/share/logstash/pipeline/
ADD config/ /usr/share/logstash/config/
EOF

docker build -t issue6 .
docker run --rm -it issue6

When run, it outputs this, which seems fine to me:
Sending build context to Docker daemon 6.656 kB
Step 1/4 : FROM docker.elastic.co/logstash/logstash:5.2.2
 ---> eb145c1bfb1d
Step 2/4 : RUN rm -f /usr/share/logstash/pipeline/logstash.conf
 ---> Using cache
 ---> 698183e91236
Step 3/4 : ADD pipeline/ /usr/share/logstash/pipeline/
 ---> 90c470815c06
Removing intermediate container 537d7e3ba2b8
Step 4/4 : ADD config/ /usr/share/logstash/config/
 ---> 4b7956317c29
Removing intermediate container 566e14457424
Successfully built 4b7956317c29
Sending Logstash's logs to /usr/share/logstash/logs which is now configured via log4j2.properties
[2017-03-17T01:56:50,976][INFO ][logstash.setting.writabledirectory] Creating directory {:setting=>"path.queue", :path=>"/usr/share/logstash/data/queue"}
[2017-03-17T01:56:50,995][INFO ][logstash.agent           ] No persistent UUID file found. Generating new UUID {:uuid=>"c22089f8-0e3e-41c2-826d-e8580b0fe54d", :path=>"/usr/share/logstash/data/uuid"}
[2017-03-17T01:56:51,212][INFO ][logstash.pipeline        ] Starting pipeline {"id"=>"main", "pipeline.workers"=>2, "pipeline.batch.size"=>125, "pipeline.batch.delay"=>5, "pipeline.max_inflight"=>250}
[2017-03-17T01:56:51,221][INFO ][logstash.pipeline        ] Pipeline main started
{
    "@timestamp" => 2017-03-17T01:56:51.281Z,
          "host" => "9ae9e357229f",
      "@version" => "1",
       "message" => "Greetings, Human!"
}
[2017-03-17T01:56:51,338][INFO ][logstash.agent           ] Successfully started Logstash API endpoint {:port=>9600}
{
    "@timestamp" => 2017-03-17T01:57:01.236Z,
          "host" => "9ae9e357229f",
      "@version" => "1",
       "message" => "Greetings, Human!"
}

Would you mind running my script in an empty directory to see if you get different results? Thanks.

Hey Toby,
thanks this script works.
I'm not 100% why my version didn't work but this helps me move forward.

Great! Glad I could help.


Search box - advanced search collapsed (even after features are used)

Hi,
When I use the general search box on the website, I often use the advanced search for a particular content type. This advanced search box is collapsed by default, which is fine. But after you've hit 'enter' and it loads the results page, the advanced search box is back to being collapsed again.
My example: http://landportal.info/search/all/%2522Administraci%25C3%25B3n%2520de%2520la%2520Comunidad%2520Aut%25C3%25B3noma%2520de%2520Euskadi%2522?f[0]=bundle%3Aorganization

Is there any way that the page can remember if you uncollapsed that before and keep it that way when it shows search results? I often find myself uncollapsing it again to make sure the filter was actually applied.

new search deployed.
I am closing this as it was more related to a usability issue which is now solved.
We will re-open search, advanced search, improving filters (on the side) in time. (maybe we can already open a ticket to have the select/dropdown option+search for countries and landvoc concepts).


fix: special http header with org name

Description
If user have is attached to several organizations with different settings, it may cause unpredictable behaviour. This PR set a special HTTP header, that is used in identification on server side.
Checklist

[ ] Tests added and all succeed
[ ] Linted
[ ] CHANGELOG.md updated
[ ] README.md updated, if user-facing

Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


binary get-set behavior bug

I solved this by adding ServerEnd to the exceptions to retry.
See https://github.com/evan/memcached/pull/79
$ diff /tmp/x memcached-1.0.6/lib/memcached/memcached.rb
46a47

    Memcached::ServerEnd,


[Feature Request] TRPC 11 support (not released yet)

yes! I want to use react query v5. But react query v5 is not compatible with trpc v10. So I need to use trpc v11... which is not compatible with zenstack v1.5! Any plans for when we might see this available?

yes! I want to use react query v5. But react query v5 is not compatible with trpc v10. So I need to use trpc v11... which is not compatible with zenstack v1.5! Any plans for when we might see this available?

Hi @DawidWraga , I haven't tried V11 yet, so not sure how much change is needed. Have you already upgraded your project? What are the main differences that you notice?

Having a conversation with trpc maintainers here: https://discord.com/channels/867764511159091230/1200854658915242004

Hi! has there been any update on this feature request? Is this fixed in v2?

Not yet. It was blocked by a typing breaking change on tRPC side. Let me check with their folks and see if it's resolved.

Created a new thread on trpc's dicord: https://discord.com/channels/867764511159091230/1266837300235735070

Fixed in 2.5.0


Bug: Bots do not perform "shot" action

Hi
I am running the game only among bots with the following command
MESA_GL_VERSION_OVERRIDE=3.2 MESA_GLSL_VERSION_OVERRIDE=150 python3 -m gfootball.play_game --home_players=bot --away_players=bot
What I have noticed is that, when a bot has the ball and is within the shooting range defined in bot.py, the shot action gets returned by the function _get_action but the player does not actually shoot and most of the time it just keeps running towards the goal.
Is this a known issue? How can I fix this?

Here you go (I had to add the .txt extension as GitHub does not allow for .dump files to be sent)
shutdown_20190718-145905363324.dump.txt
I ran the game with a bot in the home team and a lazy in the away team, just so that the bot will try to shoot more frequently.
In this example you can see that the player sometime runs towards the goal (or even diagonally outside of the pitch) without shooting. There is also a case where the player actually shoots and from what I can see is when it receives the ball in the shot range (i.e. it does not have it before entering it).

Thanks for your report Alessandro. The reason why bot doesn't shot sometimes is that it doesn't deactivate pressure action when shooting. Pressure action prevents shooting. You can quickly try this out by changing this line:
https://github.com/google-research/football/blob/master/gfootball/env/players/bot.py#L178
We have a fix to the bot, will release it with the next release.

Thanks for your answer!
What should I change that line to?

On option is for example to replace:

if self._observation['ball_owned_team'] == (1 if is_active_left else 0):
if self._last_action == football_action_set.action_pressure:
return football_action_set.action_sprint
return football_action_set.action_pressure
with:
if self._observation['ball_owned_team'] == (1 if is_active_left else 0):
return football_action_set.action_pressure
if self._last_action == football_action_set.action_pressure:
return football_action_set.action_release_pressure
That will release pressure when owning the ball before trying to shot.

I have just pushed a new version with the workaround to the problem, so alternatively you can just sync to head.

Thank you so much, it works perfectly now!


Add multiselect

The multiselect used on cf.gov should be added to https://cfpb.github.io/design-system/components/dropdowns-and-multi-selects#multiselects-1

PR --> https://github.com/cfpb/design-system/pull/1096


Request DataMirror being able to reflect more things

Type of issue: feature request
Impact: API addition (no impact on existing code)
Development Phase: request
What is the use case for changing the behavior?
DataMirror currently have APIs below:
    def widthOf(target: Data): Width
    def specifiedDirectionOf(target: Data): SpecifiedDirection
    def directionOf(target: Data): ActualDirection
    def checkTypeEquivalence(x: Data, y: Data): Boolean
    def modulePorts(target: BaseModule): Seq[(String, Data)]
    def fullModulePorts(target: BaseModule): Seq[(String, Data)]

It can check:
direction, width, typeEquivalence from Data,
Ports from BaseModule
However chisel can provide more reflections from Builder, for example:

Hardware Type(from Data.topBindingOpt)
instance, reg, mem in a specific module.(like what chisel3.aop.Select did, but reflect during runtime.)

This can help library writer to provide more magic to users.

For (2) You actually can use Select during elaboration (as long as the module is closed), eg. https://scastie.scala-lang.org/dmcju9ljTa2EQNaE3Hczrg
You can use this to implement (1), it'll work even though it's a little hacky. We probably should add (1) as a first-class API to DataMirror using some new sealed trait (we should not expose actual binding objects in the public API here).


board.GetLegalMoves() possibly not returning all legal moves

Hi, I coded a simple Negamax and Evaluation and a function that writes calculated values of all possible moves to console and tried playing against it. I was looking at this position, bot's move b7b5 doesn't seem that bad. However, from what I can see, the bot doesn't even evaluate that move and that is really weird.

This is my Think function and it is the only place where it writes to Console.

I don't see how would a move disappear. I'm amateur programmer so it is completely possible that i just missed something, but i checked it very carefully and I don't see how could that be my fault.
I used challenge version 1.13 and i used chess.com to confirm that the b7b5 move is actually possible.
I hope it gets resolved and I wish a nice day to everyone reading this :)

The move b7b5 is in the legalMoves and gets output in the console of your screenshot. It is the 5th Line from the bottom with score -300. Everything is working fine

I see it now lol
I sould rest


Error occurred while executing RemoveMSAdministrativeUnitMember

I tried to use the command Remove-AzureADMSAdministrativeUnitMember -Id "xx-xx-xx-xx-xx" -MemberId yy-yy-yy-yy-yy and I got this error
Remove-AzureADMSAdministrativeUnitMember : Error occurred while executing RemoveMSAdministrativeUnitMember
Code: Request_ResourceNotFound
Message: Resource 'xx-xx-xx-xx-xx"' does not exist or one of its queried reference-property objects are not present.
InnerError:
RequestId: zz-zz-zz-zz-zz-zz
DateTimeStamp: Wed, 21 Sep 2022 21:21:10 GMT
HttpStatusCode: NotFound
HttpStatusDescription: Not Found
HttpResponseStatus: Completed
At line:1 char:1

Remove-AzureADMSAdministrativeUnitMember -Id "xx-xx-xx-xx-xx"

  + CategoryInfo          : NotSpecified: (:) [Remove-AzureADMSAdministrativeUnitMember], ApiException
  + FullyQualifiedErrorId : Microsoft.Open.MSGraphV10.Client.ApiException,Microsoft.Open.MSGraphV10.PowerShell.RemoveMSAdministrativeUnitMember

the two parameters are correct. I was able to remove the user from the web interface and from graph explorer.

Hi @mdurini-swisscom, I have run this cmdlet successfully.
From the error returned, the administrative unit or the member is not found. To confirm this please run;
Get-AzureADMSAdministrativeUnit to get the actual id of the administrative unit.
Then run:
Get-AzureADMSAdministrativeUnitMember -Id $AdministrativeUnitID to get the members of the unit.
You can then use Remove-AzureADMSAdministrativeUnitMember -Id $AdministrativeUnitID -MemberID $UserID


tree visualization for merkle proof working

Got the merkle visualization working! I think I'm doing the hashing incorrectly, but it looks pretty cool haha. You can see it by clicking through to the tx details page

lgtm!


Add docker compose to support local development

the fastapi bit relates to different triples from a different project, but I think we can include the docker compose as a way to spin up fuseki and then we see how we populate it with the knowledge graph.


Update: HottaStudio.TowerofFantasy version <IP_ADDRESS>5

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Does your manifest conform to the 1.1 schema?

Tower of Fantasy doesn't write a DisplayVersion, but this is the version that is shown in the launcher:

Microsoft Reviewers: Open in CodeFlow

/azp run


Add a broken link checker tool

Description:
Need to add a broken link checker tool to the MI doc space.

Closing as duplicate; will be tracked via https://github.com/wso2/docs-mi/issues/810.

@DinithiDiaz usual practice is to keep the old issue while closing the latest issue when it comes to duplicates. Hence re-opening this one.

@anupama-pathirage & @DinithiDiaz The current mi-docs site doesn't have the meta tags (<meta name="robots" content="index"> and <meta name="googlebot" content="index">) and a robots.txt which allows the crawlers to find the sitemap and crawl through the URLs listed there. This is a major impact on SEO as well.
I've written, and tested a crawler which worked well with the ballerina.io in which we have implemented all of the above.

@anupama-pathirage & @DinithiDiaz The current mi-docs site doesn't have the meta tags (<meta name="robots" content="index"> and <meta name="googlebot" content="index">) and a robots.txt which allows the crawlers to find the sitemap and crawl through the URLs listed there. This is a major impact on SEO as well.
I've written, and tested a crawler which worked well with the ballerina.io in which we have implemented all of the above.

Hi all,
I did a bit of research on this sometime back, and from what I understood, since this is a MkDocs site, we can use the <robots> property in the base.html file of our documentation sites instead of having a separate robots.txt file.
Reference:
MkDocs Material documentation
According to below resources we only need to add the <robots> meta tag if we want to specifically request noindex and nofollow. Otherwise, it's not necessary to include them.
Reference:
Google Search Central
Semrush Blog


update the SYMFONY_VERSION constant to the latest release number

hi,
just a minor fix in context with #354
cheers :v:

@connorhu @verfriemelt-dot-org  it should be 1.5.20-dev, as 1.5.19 has been tagged few days ago :)

@thePanz Are we here already? Time flies (and version numbers)

i updated it to 1.5.20 :) i think this was at some time done automatically via https://github.com/FriendsOfSymfony1/symfony1/blob/master/data/bin/release.php#L85
maybe a simple version file would be a simple solution.
something like this in the release pipeline:
$ git describe --tags > version

and just reading in that file from the lib-root instead of replacing that token in the php file.
with that we could just leave the version at main or 1.5.x-dev :thinking:

[...]with that we could just leave the version at main or 1.5.x-dev 🤔

Having '1.5.x-dev' would be nice, we might also want to rename the 'main' branch to be '1.5.x' too, to simplify the management of -dev aliases (loke we have I for swiftmailer)
Wdyt?


Should we ignore subsequent alert messages?

@embbnux @u9520107
When the message content is empty and I try to click the 'Send' button for several times, the alert messages will show up for several times looks like below

Should we ignore subsequent alert message so that it shows only one before it is dismissed?

We do have this feature already. Notice the allowDuplicate parameter in the alert function, passing false would make the alert module check if the same message is already in display.
 @proxify
  async alert({
    message,
    payload,
    level = alertLevels.info,
    ttl = this._ttl,
    allowDuplicates = true,
  }) {

Looks good. Let's close this.


Ability to add secrets available to specific users and or groups

@aktech and I spoke about the importance of keeping the qhub-ops-config.yaml as the central source of truth for reproducibility. We ended up having a talk about a general way to support adding secrest to users. This is very much up for change but something like this is along the idea of what is going to be implemented.
We would leverage terraform to auto generate the gcp/aws credentials they may need. These secrets will then be mounted with the nfs server into the users home directory or in the shared group directoires.
security:
  users:
    costrouc:
      uid: 10000
      primary_group: users
      secrets:
        - name: gcp_credentials
          type: gcp
          permissions:
            - read
            - write
        - name: mysecret1
          type: b64secret
          value: "ASDFASDFQWEFAFASVASDFQWER"
        - name: mysecret2
          type: secret
          secret_name: "apitoken"

  groups:
    users:
      gid: 20000
      secrets:
        - name: gcp_credentials
          type: gcp
          permissions:
            - read
            - write
        - name: mysecret
          type: secret
          value: "base64 encoded secret"

Closing in favor of https://github.com/Quansight/qhub-ops/issues/73


add params for AsyncClient

In my case, I needed a trace_configs from aiohttp.ClientSession params. May be useful.

thanks @Jafte


GE: Can't add farm administrators in SDK

I tried to add Guido Neumann as an administrator on our farms. However, there does not to be a "submit" button, and hitting enter doesn't do anything.

Seems you are trying to fill his name in the filter field, at the top right there is a button add new administrator which would show a popup to add the new administrator

Nothing happens when you click it

On 23 May 2020, at 12:56 AM, Jo De Boeck<EMAIL_ADDRESS>wrote:

Seems you are trying to fill his name in the filter field, at the top right there is a button add new administrator which would show a popup to add the new administrator
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

fixed on commit : https://github.com/threefoldtech/jumpscaleX_threebot/commit/a9aca99fb37d0d9e866731d9f3dca06f98cb96b8

Is there a way for me to get a hot fix for this? Where can I run a git pull?

On 26 May 2020, at 09:35, Mahmoud Ayoub<EMAIL_ADDRESS>wrote:
fixed on commit : a9aca99 https://github.com/threefoldtech/jumpscaleX_threebot/commit/a9aca99fb37d0d9e866731d9f3dca06f98cb96b8
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/threefoldtech/jumpscaleX_threebot/issues/720#issuecomment-633861124, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJREDWCNMX5WXYQHD63Y7LRTNWMRANCNFSM4NH334MQ.

@joefoxton it's ported to master. please update jumpscalex_threebot repo :)

Did a git pull in jumpscalex_threebot  and restarted the SDK… same result, I’m afraid!

On 26 May 2020, at 11:32, Reem Khamis<EMAIL_ADDRESS>wrote:
@joefoxton https://github.com/joefoxton it's ported to master. please update jumpscalex_threebot repo :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/threefoldtech/jumpscaleX_threebot/issues/720#issuecomment-633917511, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJREDUWFTQY5SKDOPWGW53RTOED5ANCNFSM4NH334MQ.

pushed again. @joefoxton please let me know if it's not working

Confirmed - it works!

On 26 May 2020, at 13:28, dinaabdo<EMAIL_ADDRESS>wrote:
Closed #720 https://github.com/threefoldtech/jumpscaleX_threebot/issues/720.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/threefoldtech/jumpscaleX_threebot/issues/720#event-3373104243, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJREDRCLPAGVCUUTSIZUSTRTORWXANCNFSM4NH334MQ.


Zap Desktop crashes when requesting anything below <1 satoshi

Description
When requesting less than 1 satoshi (eg 0.1 sat), Zap Desktop freezes upon entering the first digit beyond the point. It only shows the black screen. When restarting Zap I encounter a 'Deadline Exceeded' error. Waiting for a while resolves this.
Expected Behavior
I enter 0.1 Satoshi into the field 'amount'. I expect to either

be prevented from entering any amount smaller than 1 satoshi
getting an error message when clicking 'request'
be able to request sub-satoshi amounts

Actual Behavior
The screen freezes upon entering the first digit beyond the dot.
Upon restarting Zap I'm unable to get back into my node ("Unable to connect to host: Deadline Exceeded")
Possible Fix

Steps to Reproduce

Start Zap

Click on "Request"

Change ticker to 'satoshi'

Enter 0.1

Context
I was unaware the ticker was set to satoshi, I attempted to request, a sub-bitcoin amount.
Your Environment

Zap Desktop version: ZapDesktop-linux-amd64-v0.2.1-beta
Operating System and version: Ubuntu 16.04

Hi @Liongrass This issue has been resolved in the master branch already and the fix will be included in the upcoming 0.2.2. release.
See https://github.com/LN-Zap/zap-desktop/pull/705


Rails 7 has removed ActiveSupport::Dependencies. How should reloading be done now?

https://github.com/ruby-grape/grape/issues/358
https://github.com/ruby-grape/grape#reloading-api-changes-in-development
We have:
 ActiveSupport::Dependencies.explicitly_unloadable_constants += [
    'GrapeAPI::V1::RootEndpoint',
    'GrapeAPI::RootEndpoint'
  ]

Any updates on this?

Any updates on this?

No updates.

i am stuck here. any help?
NoMethodError: undefined method explicitly_unloadable_constants' for ActiveSupport::Dependencies:Module`

It sounds like it's time to move away from grape to something like pure API with VueJS, or Turbo from Hotwire

It sounds like it's time to move away from grape to something like pure API with VueJS, or Turbo from Hotwire

We'll miss you, @blshkv!

The method ActiveSupport::Dependencies.explicitly_unloadable_constants has been removed in Rails 7, which is why you're seeing a NoMethodError. This method was part of Rails' older autoloading system, but Rails 7 fully relies on the Zeitwerk autoloader, which does not use manually unloadable constants.
To fix this, you need to migrate away from explicitly_unloadable_constants and rely on Zeitwerk’s autoloading, which handles reloading of constants automatically


Ignore models in large folder

Stop tracking .fbx files inside large folder

Good idea thanks for this!


[bug] Pochven systems are assigned their pre-trig region/security

Ala specifically, might be more?

Did you build your eve_universe from the eve_universe.sql.zip file? I have noticed that if you patch an existing database using the pochven/trailblazer patch then some systems can be wrong, but they should be correct in the full db dump.

Restoring the db as described fixed it, thanks. Sorry for the slow response. :)


Bugfix/whitelist

Added the white list of establishing connection and removing the white list of being connected

Lack of unit test case coverage


[Enhancement] Remove netty codec threads for better performance

Before Creating the Enhancement Request

[X] I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary
In the current implementation, a codec thread pool is set up for Netty, which is used to perform tasks such as encoding/decoding, and statistics.
We found that removing the codec thread pool and directly assigning these computational tasks to the NIO selector threads results in performance improvement.
Since these tasks do not involve IO operations, they will not block the NIO selector threads.
Motivation
Our stress test results show that removing the codec thread pool can achieve higher TPS (5% increase) and also reduce CPU usage (4% reduction).
[TPS Comparison] Before:

[TPS Comparison] After:

[CPU Comparison] Before:

[CPU Comparison] After:

Describe the Solution You'd Like
Remove the codec thread pool NettyRemotingServer #defaultEventExecutorGroup
Describe Alternatives You've Considered
No
Additional Context
No response

A switch has already been added.
Close issue


ClusterLoader: Replace glog with klog

Cluster loader should use klog instead glog, to be coherent with kubernetes logging.

[ ] Fix: initializing klog, so klog logs become visible.
[ ] Replcing glog with klog

/assign


Not able to make an object of class Swimmer

Describe the bug
After importing Swimmer class from scranking, while instantiating an error pops up.
To Reproduce
Steps to reproduce the behavior:

Install the package: pip install scranking
Open Python Shell
Import the package: from scranking import Swimmer
Make an object of class Swimmer: swimmer = Swimmer("url")
see error

Expected behavior
The class should be Instantiated without any error.
Screenshots

Desktop (please complete the following information):

OS: MacOS
Version: 13.3.1 (a)

Thank you for catching this issue!


[CARBONDATA-3791] Updated configuration-parameters.md and removed unused configuration

Why is this PR needed?
Updated configuration-parameters.md and removed unused configuration
What changes were proposed in this PR?
Updated configuration-parameters.md and removed unused configuration
Does this PR introduce any user interface change?

No

Is any new testcase added?

No

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2935/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1217/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2943/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1225/

LGTM

LGTM


Migrate away from JFrog Bintray

Hi there,
we are hosting some repositories on Bintray [1]. Now that JFrog is sunsetting this service [2], we have to think about where/how/when to move on. Starting with May 1st, 2021, Bintray services will no longer be available. However, starting with March 31st, 2021, no more submissions will be accepted to JCenter.

To streamline the productivity of the JFrog Platform we will be sunsetting Bintray (including JCenter), GoCenter, and ChartCenter services on May 1st, 2021. Users of these services will need to migrate to the respective canonical repository, and we will continue to offer both free and paid JFrog Platform cloud subscriptions that can serve other binary distribution needs.

With kind regards,
Andreas.
P.S.: This is just a canonical issue to discuss this topic. Of course it will also apply to the other artifacts referenced at [2]. We might also want to take the chance to apply some housekeeping, if applicable.
[1] https://bintray.com/crate/crate
[2] https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/
cc @seut, @mfussenegger, @mkleen, @WalBeh, @juanpardo, @SStorm, @dobe

Users of these services will need to migrate to the respective canonical repository, and we will continue to offer both free and paid JFrog Platform cloud subscriptions that can serve other binary distribution needs.

So, in the best case, we will just need to get such a free subscription and update some upload URL?

Should we consider GitHub Package Hosting? It is free for Open Source repos.

Should we consider GitHub Package Hosting? It is free for Open Source repos.

Good idea, like that as well.

The most important thing on this migration is that it does not get more complicated for users/developers to consume the packages. As far as @seut researched into that topic, staging packages to GitHub will also transitively upload them to Maven Central, which is the way it should be done.


add device_uri for found network printers

This is necessary if the organization has many identical printers

I don't know. my decision was "quick" because in our network showed four identical printers.

ок in this example i add "title" and i see tooltip if mouse over printer name. Good?
<LABEL FOR="{device_uri}{?device_make_and_model!Unknown?|{device_make_and_model}:}" title="{device_uri}">{device_info} {?device_make_and_model!Unknown?({device_make_and_model}):} </LABEL><BR>

Hi @Pro-pra ,
thank you for the PR! It would be great if you squashed your commits and updated the code with your idea from yesterday - I or Mike will try to review this in the future and see whether some more changes will be needed to make.


Added dev requirement mistune 2.0.0rc1

This PR ...
fixes CI/CD due to broken requirement mistune 2.0.0.

Codecov Report

Merging #19 (2478e63) into main (f9a530c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   89.58%   89.58%
=======================================
  Files          55       55
  Lines         701      701
=======================================
  Hits          628      628
  Misses         73       73

Flag
Coverage Δ

pytest
89.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a530c...2478e63. Read the comment docs.


Enable -Werror, this should work soon because of a new SodaqOne base

Sodaq has reported they are about to release an update, that should make it possible to use -Werror. WIth this PR we can check on travis-ci when it works again

Closing for the moment, will reopen at the moment sodaq has released a new version


Avoid InMemoryCache store/load serialization/deserialization

Closes #697.
Simply storing the Module in the cache, and cloning it when loading.
@webmaster128, would this be enough? A Module is composed of a Store and an Artifact. All of these are ultimately wrapped into Arcs; so, I assume this simple strategy works.
Creating as Draft in case some modifications / extensions are needed.

"instantiate from memory": 54µs 🎉

"instantiate from memory": 54µs 🎉

Can you rebase this on top of latest master and do the renaming? Then good to merge

Can you rebase this on top of latest master and do the renaming? Then good to merge

Ah, and a CHANGELOG entry describing the change would be nice

Ah, and a CHANGELOG entry describing the change would be nice


oscap: rename policy to profile in the UX

Policy and profiles seemed to be two interchangeable terms for us. But it turns out there might be some difference between the two. We've been asked to not call the Oscap policies policies in the UX. This commit does exactly this.

Looks good! :sparkles: There's just one small linter error.

Looks good! ✨ There's just one small linter error.

Thanks for checking on it this morning. It's updated now.

/retest

/retest


Cache completion item -> request to minimize completion payload.

Added a CompletionRequestContextCache and instead of storing host document and projected uri's along with language server kinds on completion items we now store them in the cahce to be retrieved at resolve time.
Updated the languageserver client project to target latest C# lang version to use records!!

Added IsExternalInit to enable this.

Added new tests for request context cache.
Updated existing tests to validate the new behavior.

Part of dotnet/aspnetcore#29619

Merging this at Taylor's request.

Great feedback everyone! I'll get out a PR with the reactions to all this


just disable the irq tud_task call, and succeed on all prevent/allow cmds

Keeps stdio working to allow debugging printf's.
macOS doesn't send start/stop unload when prevent cmd fails.

Ejecting now also works on OSX.


Rename Day01.kt to Day25.kt for keeping an template for the whole AoC

I always forget to copy the solutions file to the next day before writing my solution. If the template would be Day25.kt, I'd be remebered every day, since filling in Day25.kt can only be done on the last day.

I've created a live template in IntelliJ so that I can create an empty Day##.kt and then fill it with the template main() function including the correct name for the input files based on the Kotlin filename (template function fileNameWithoutExtension())

I have added a File Template to the project with a193b69:


Update tests for collections publisher

The slug for /topics has changed to /specialist-sector-pages so the
e-2-e tests need to be changed accordingly.

I'm seeing an error in some of my PRs:
07:13:03   1) Publishing a parent and child topic on Collections Publisher Publishing a parent and child topic
07:13:03      Failure/Error: fill_in "Slug", with: slug
07:13:03
07:13:03      Capybara::ElementNotFound:
07:13:03        Unable to find field "Slug"
07:13:03      # /usr/local/bundle/gems/capybara-3.7.2/lib/capybara/node/finders.rb:295:in `block in synced_resolve'
07:13:03      # /usr/local/bundle/gems/capybara-3.7.2/lib/capybara/node/base.rb:82:in `synchronize'
07:13:03      # /usr/local/bundle/gems/capybara-3.7.2/lib/capybara/node/finders.rb:286:in `synced_resolve'
07:13:03      # /usr/local/bundle/gems/capybara-3.7.2/lib/capybara/node/finders.rb:33:in `find'
07:13:03      # /usr/local/bundle/gems/capybara-3.7.2/lib/capybara/node/actions.rb:87:in `fill_in'
07:13:03      # /usr/local/bundle/gems/capybara-3.7.2/lib/capybara/session.rb:728:in `block (2 levels) in <class:Session>'
07:13:03      # /usr/local/bundle/gems/capybara-3.7.2/lib/capybara/dsl.rb:51:in `block (2 levels) in <module:DSL>'
07:13:03      # ./spec/support/collections_publisher_helpers.rb:9:in `fill_in_topic_form'
07:13:03      # ./spec/collections_publisher/publishing_parent_and_child_topic_spec.rb:32:in `create_topic'
07:13:03      # ./spec/collections_publisher/publishing_parent_and_child_topic_spec.rb:25:in `given_i_have_a_published_topic'
07:13:03      # ./spec/collections_publisher/publishing_parent_and_child_topic_spec.rb:12:in `block (2 levels) in <top (required)>'

Would that be fixed by this PR?

Yep! I forgot to merge it yesterday before the all staff, sorry!


code references out-of-date subdirectory names

The code references directories like /content/
Actual files in data/train (or test or dev)

The code was executed in Google Colab so the notebook follows that repository structure. You will have to change the directory structure as per you local setup.


SMAP authentication issues

I have recently learned SMAP data can be subsetted and will provide files only if there is data in the Colorado domain. This is great however I'm having authentication issues and there are about 630 subsetted data files I can download.  I'll have to look into this further because I don't want to download files manually.

I should the one good news is that I do have global SMAP data. I would just prefer the subset version so I know there is actual data that could potentially overlap a landslide.

Aha! The authentication is working! I am now downloading the subsetted SMAP data successfully.


build(deps): bump cross-spawn

Bumps the npm_and_yarn group with 1 update in the /Contentful-Schema directory: cross-spawn.
Updates cross-spawn from 7.0.3 to 7.0.6

Changelog
Commits

updated-dependencies:

dependency-name: cross-spawn dependency-type: indirect dependency-group: npm_and_yarn ...

:tada: This PR is included in version 3.11.0-next.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Support Custom Loaders for File Extensions in@angular-devkit/build-angular:browser-esbuild

Command
build, config, serve
Description
I'm using the @angular-devkit/build-angular:browser-esbuild builder for my Angular project and attempting to convert from the @angular-builders/custom-webpack:browser
builder. During this process, I've encountered a limitation when trying to handle custom file extensions, such as .less, within the ESBuild configuration. Currently, the browser-esbuild builder doesn't seem to support the configuration of custom loaders directly for specific file extensions, which restricts the ability to manage styles or other non-standard assets that require preprocessing. This limitation makes the transition from custom-webpack to browser-esbuild challenging, as it complicates the handling of various assets that were previously managed through custom Webpack configurations.
Describe the solution you'd like
Like to add loaders option as available in @angular-devkit/build-angular:application
Describe alternatives you've considered
I attempted to use @angular-devkit/build-angular
for my hybrid app, but it required extensive modifications and customizations across multiple files. This approach isn't practical, especially considering the large number of apps we already have configured with @angular-builders/custom-webpack

The browser-esbuild builder is a compatibility builder, allowing users to switch between webpack and esbuild-based builders. Therefore, it must offers the same options.
The application builder, is the recommended option if you want to use new features and options. New features and options are exclusively added to the application builder as it is the preferred choice if you want to use specific esbuild features.


No way of setting a "base" unique key for usePaginatedQuery, so that it conditionally lags data

Describe the bug
Hi, I have a use case where I only want usePaginatedQuery to return lagged data some of the time:

in the app, we have a separate page for each 'client' entity
on each 'client' page you can paginate and search through that client's transactions, so we want lagged transactions data to be displayed while paginating.
However, when the user goes to a different client's page, we don't want the previous client's transactions to be displayed while the new client's transactions are being loaded

So we want data to be lagged within a client page, but not between client pages.
I had assumed that usePaginatedQuery used the first item in the key list as a unique identifier to 'scope' the pagination, so I tried adding the client's ID to that (it was already in the argument list as the second item) but it didn't work - lagging was still happening between client pages.
So, is there a way to 'scope' usePaginatedQuery so that it knows when to lag data and when to treat the query as a separate one?
Thanks!
Expected behavior
I expect this to show lagged data whenever the clientId or page changes:
usePaginatedQuery(
    ["transactions", { clientId, page }],
    getTransactions)

But I hoped that this wouldn't show lagged data when the clientId changes, because  the query key 'root' (first item in the list) changes when the clientId changes:
usePaginatedQuery(
   [`transactions-${clientId}`, { clientId, page }],
   getTransactions)

Desktop (please complete the following information):

OS: MacOS, Windows
Browser: all main browsers
Version: 2.26.4

The one thing that comes to mind right now is having a useEffect that runs when the clientId changes and removes that entry from the cache, but yeah, this is not a very elegant solution I admit...

Ye I was thinking of something like that, was hoping for something more idiomatic but that will do! Thanks

It would also mean that when the user returns to a previously viewed client, that client's data won't be in the cache, as all data is wiped every time you change the client :/

Hmmm. You know, if you were to use v3 with keepPreviousData, you can actually lag data conditionally like so:
function useDidChange(deps) {
  const depsRef = React.useRef(deps)

  let changed = false

  if (
    depsRef.current.length !== deps.length ||
    deps.some((dep, index) => depsRef.current[index] !== dep)
  ) {
    changed = true
  }

  React.useEffect(() => {
    depsRef.current = deps
  }, [])

  return changed
}

function App() {
  const clientDidChange = useDidChange([clientId])

  const query = useQuery(key, fn, {
    keepPreviousData: !clientDidChange,
  })
}

That code is untested, but I've done it before without problems, so let me know if it needs any fixing.

That's great thanks, works like a charm! Small correction to the useDidChange hook - the effect that updates the ref value should have deps in it's own dependency list:

Good catch. I wrote it in the Github comment box... so 🤷♂ 😄

I honestly think that's my goto suggestion now for this issue. I'm going to close it, but it would be awesome to see a PR to document how to build that utility where you think it would be most useful.


Allow standby instances to pull updates on demand

Added a button on the status page so any code privileged users can click "Pull" and the instance will pull updates from GH.
Client side code is already implemented.

@thesecretmaster Didn't know that, fixed.


Show "decades" in album year navigation

Currently you can view older album releases by year. But really, anything over 10 years ago we should just reduce to the decade instead of a single year.
ie.

2000's
1990's
1980's
1970's

This should be resolved in upcoming design w/ infinite scrolling and manual date selection UI.


Using in Pycharm

I fight for two days, I pumped out a few gigabytes of info, but I could not get the library to work. All the time dependency errors.
Do you have any instructions on how to install the library in Pycharm?

I fight for two days, I pumped out a few gigabytes of info, but I could not get the library to work. All the time dependency errors. Do you have any instructions on how to install the library in Pycharm?

Resolved:
conda create -n extractnet python=3.8
conda activate extractnet
pip install extractnet

Hi @Vponed the issue should be resolved in the latest 2.0.4 version. The root cause was a installation problem


new dir structure idea

using suggested dir structure from hee: https://medium.com/heuristics/c-application-development-part-1-project-structure-454b00f9eddc

moved .pl to /web and sample data to /test
renamed files to avoid the .out extension

i DID NOT attempt to update any file paths in any .bat or .pl files. those are likely "broken". since all the .pl files were geared towards the "old" website and the new website is likely quite different in its API or layout I have mostly ignored those.

structure is as follows
.
├── .gitignore
├── BUILDING.MD
├── CMakeLists.txt
├── HISTORY.TXT
├── LICENSE
├── NOTES.TXT
├── README.TXT
├── run.bat
├── src
│   ├── bmai.cpp
│   ├── bmai.h
│   ├── bmai_ai.cpp
│   ├── bmai_ai.h
│   └── bmai_player.cpp
├── test
│   ├── bmai_in.txt
│   ├── bmsim_in.txt
│   ├── bmsim_out.txt
│   ├── test_in.txt
│   └── test_out.txt
└── web
    ├── bmai.pl
    ├── bmai_run.pl
    ├── bmai_test.pl
    ├── dp_lib.pl
    └── stats.pl

marked as DRAFT PR because this is very likely not ready to merge, but at least ready to discuss

The structure seems fine.

The structure seems fine.

i have worked this structure on windows, mac, linux. a handful of different IDEs, some automated infrastructure. so if your ok with this structure you are welcome to merge it. i will use this structure in my fork of this repo

merged


pass breaksTracking bool on all incremental updates

@keybase/react-hackers is this what you had in mind?  happy to tweak as you need it...

@keybase/react-hackers, hold off a few things to fix...

Ok, ready for a look...

let's try it :+1: