Compat with ultraliser 0.4.0

The command here does not work at all with latest module of ultraliser:
https://github.com/BlueBrain/atlas-placement-hints/blob/main/atlas_placement_hints/distances/create_watertight_mesh.py#L113
@marwan-abdellah , I'm not even sure ( I couldn't find changelog) on how to map the old/new options, could you give me a mapping? thanks!

With 0.3.0 it works, but I get a
	Computing Edges
	* Progress │▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒│ (100.00 %)
	* Time     | 0.0307088 Seconds

	Removing Vertices
	* Progress │▒▒                                                │ (4.62 %)Some polygons are NOT closed: @[9672]

With 0.4.0 and playing with parameters, I get a seg fault straight away

Just replace tyour code with this please:
if Path(volume_path).suffix:
        raise ValueError(
            "[ultra_volume_2_mesh] "
            f"The provided option 'volume_path' {volume_path} has a non-empty file extension. "
            f"The program ultraVolume2mesh expects a filepath without extension."
        )
    subprocess.check_output(
        [
            ultra_volume_2_mesh_path,
            "--volume-path",
            volume_path,
            "--iso-value",
            str(iso_value),
            "--export-obj-mesh",
            "--optimize-mesh",
            "--smooth-iterations",
            str(smooth_iterations),
            "--output-directory",
            output_directory,
        ]
    )

@arnaudon If you're trying to update atlas-placement-hints to use ultraliser v0.4.0, the main difficulty might be updating the tests so that they pass. The current tests are hardcoded to use a very old version of ultraliser here: https://github.com/BlueBrain/atlas-placement-hints/blob/main/tests/distances/test_create_watertight_mesh.py#L20-L22


Using "--test-meta" doesn't take the tests with meta from fixtures

Hello,
What is your Test Scenario?
    fixture('Fixture 1')
      .meta({
        type: "smoke"
      })
      .page('https://devexpress.github.io/testcafe/example/');

    test
      .meta({
        foo: 'bar'
      })('Text 1', async (t) => {
      await t.expect(true).eql(true);
    });

    test
      .meta({
        type: 'regression'
      })('Text 2', async (t) => {
      await t.expect(true).eql(true);
    });

What is the Current behavior?
If I want to launch all the tests of type "smoke" (so, using the meta "type=smoke"),
I use the CLI command:
testcafe chromium:headless tests/test.js --test-meta type=smoke
It fails with:
ERROR No tests to run. Either the test files contain no tests or the filter function is too restrictive.
If I launch the command using "--fixture-meta type=smoke", it runs successfully the two tests: but that's not what I want because the second test have "type=regression".
What is the Expected behavior?
Regarding the doc :

All metadata entries specified for a fixture are applied to tests included in this fixture.

But it seems to not works with the CLI arguments, the meta are not inherited.
Your Environment details:

testcafe version:                   1.3.1
node.js version:                    10.6.0
command-line arguments:  testcafe chromium:headless tests/test.js --test-meta type=smoke
browser name and version: chromium:headless (65)
platform and version:          Linux Ubuntu 14.04
other:                                   /

Thank you for the detailed description. This behavior seems strange. Our team will research it and find a suitable solution.

Hi @blaryjp
It's a documentation mistake. There are two separate flags to filter tests by meta information: test-meta and fixture-meta.
@VasilyStrelyaev
Please do the following:

remove the 'All metadata entries specified for a fixture are applied to tests included in this fixture' sentence from the Specify testing metadata paragraph.
remove the example that shows how to override meta information. It's wrong because the fixture's meta doesn't override the test meta.

Hello @miherlosev ,
Thank you for your response.
I understand. For my use case, can we maybe create a parameter like "--meta", to run tests for both?

Hello @blaryjp,
We are not planning to create a parameter like --meta. We split meta information in two parts: the fixture and test. Command line parameters (--test-meta, --fixture-meta) have simple logic and check only key/value pairs. If you need more complex filtering logic (or, and, contains conditions, etc.) use the programming interface. See the example below:
const createTestCafe = require('testcafe');
let testcafe         = null;

createTestCafe('localhost', 1337, 1338)
    .then(tc => {
        testcafe     = tc;
        const runner = testcafe.createRunner();

        return runner
            .src(['tests/fixture1.js', 'tests/func/fixture3.js'])
            .filter((testName, fixtureName, fixturePath, testMeta, fixtureMeta) => testMeta.type === 'smoke' || fixtureMeta.type ===  'smoke')
            .browsers(['chrome', 'safari'])
            .run();
    })
    .then(failedCount => {
        console.log('Tests failed: ' + failedCount);
        testcafe.close();
    });


[Addition]: Another EU Packet Forwarder

Hotspot b58 Addresses
11mJVQVNdzG3Npy2ebBjDoSZDdSuCbeKJai4XvAg3fZ71vD6qg9
Discord Handle
No response
Reason(s)
He has a whole wallet of high earners, 1+ hnt per day. He is packet forwarding.

Please stop reporting things. This is a complete legit HS placed on a radio tower. Your only making a mess here


Misc doc changes

List of changes:

Fix typo
Fix spdx license id
Use common source url
Remove api reference page since there is only one module
Add changelog to html doc page
Set readme as main html page
Adjust code example indentation
Update gitignore rules
Add changelog link to hex info page
Badges and more badges!
Add license section

@ericentin Any updates on this?


Adds support for handling j1939 and GM Extended frame ids

The current handling of the VFrameFormat I believe to be incorrect, This is not the "protocol", it is
a specifier on how the frame id has been formatted. The protocol lies in the ProtocolType attribute, this attribute defines the protocol used on top of CAN which would be the Transport layer (layer 4) of the OSI model. It is a way to know how to handle the data contained within the data section of the frame. An example would be setting the ProtocolType to OBD2. This instructs a user/application that the data contained is going to be as follows.
byte 0: number of data bytes (not including this byte). Because the OBD2 standard will always have a DLC of 8 any of the unused bytes will be populated with 0x0
byte 1: mode or service identifier, a response frame will be the mode id + 0x40
bytes 2-7: data
I have added the property frame_format to the Message class which now returns the set VFrameFormat for a message if this attribute has been set in the DBC file. I have changed the protocol property so it will no longer return the frame format and instead it will return the ProtocolType attribute if there is one in the DBC file.
GMLAN has a special way of handling the frame id just like the j1939 frame format does. in order to properly decode the frame id for GMLAN there is a special attribute that needs to get set to a 1, this attribute is UseGMParameterIDs. When using the get_message_by_frame_id I check to see if the supplied frame id is present in the stored message, if it is I return it. Then I check each message contained in the database and see if the message has the UseGMParameterIDs attribute and if it does I check to see if it is set to a 1, If it has been set to a 1 I then alter the supplied frame id so it is GMLAN compliant and check if it matches the message, if it does I return the message.py
for the j1939 frame format it functions almost identical to the GMLAN except it checks the message to see if the VFrameFormat attribute is set and if it starts with J1936
The handling of attributes has also been changed so that global attributes are available to access in a node, message and signal, If a global attribute is changed in a node, message or signal it does not change the global attribute, instead it creates an attribute specific to that object. If a global attribute needs to be changed it needs to be done at the database level.
I still need to work out changing a global attribute and having it also change in all of the objects in the database.

I prefer the assert the other way around, even if actual and expected are swapped.
Why did you change the file path handling? Everything should run just fine when you run the tests from the project root folder.

If the tests get run from inside of an IDE like PyCharm the tests will not run because of the file path. Also having the asserts backwards produces output that is incorrect and when doing comparisons of the output it is backwards. Most developers will develop in an IDE like PyCharm and if things are not working properly inside of the IDE because of things like file paths and test output it makes it extremely difficult to produce code that is going to function properly and also test properly. It is much easier to be able to develop in a single environment then to have to keep jumping back and forth between a shell window and an IDE and copying and pasting output into the IDE to get comparisons. Doing that is an enormous headache.

Developers prefer different tools. I like Emacs, many like Visual Code, many Vim, etc. It might be that your changes makes many of them happy, but right now these changes are not acceptable, sorry.


switch mstest projects to use xunit

Fixes #207

@kayle,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@kayle, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

Tagging @vancem for final acceptance.

LGTM


fp8 moe configs. Mixtral-8x(7B,22B) TP=1,2,4,8

fp8 moe configs for Mixtral-8x7B and 8x22B for TP=1,2,4,8
These configs were tuned using the "fixed" upstream script (left for another PR)

LGTM, thank you!


Add publication pages (inside TermInfo)

From @dosumis on November 15, 2017 18:33
@dosumis commented on Tue Jun 16 2015
This page to be used for links from pubmed/PMC using their linkout mechanisms.
Content:

Pub metadata:  Keep this minimal and rely on linking(?)

But how minimal? Is miniref really enough, and if not where do we pull data from?

Links to anatomical structures

Based on refs in ontology?
From annotations

Also display details of annotation?

@jefferis commented on Tue Jun 16 2015
Hi @dosumis Could you clarify what page you are referring to here?

@dosumis commented on Tue Jun 16 2015
We don't have pages for pubs yet, but it is not unreasonable to have them - presenting data associated with a particular pub.  Useful in its own right, but the immediate demand for these comes from wanting a page to link to from pubs on pubmed and PMC (see linked ticket).  It could also provide a good way for authors/community to see how we've annotated.  Coupled with comment threads, they could give feedback if they disagree.
Copied from original issue: VirtualFlyBrain/geppetto-vfb#110

This issue was moved to VirtualFlyBrain/VFB2#76


New plugin: lt-lint

{:name "lt-lint"
:version "0.0.1"
:author "Brendan Bates"
:source "https://github.com/bbbates/lt-lint"
:desc "Base plugin for enabling editor linter addons for LightTable"
:behaviors "lt_lint.behaviors"}

Pulling this for now - found a severe bug that prevents eval on clj editors.


Skip amount input on create payment request

The user should be able to create an invoice without entering an amount.

This is already done as far as I could see in the app. Can we close this @holzeis ?
Note that an invoice without an amount will lead to an error when using the faucet (which is expected I suppose).

This has been done


BUG/HELP : App saying no available stream when stream are online

did i do something wrong ?

Also it say there is no drop when there is ?

Please see #245, as the same explanation applies here as well.


Creating a TLD?

Can I spin this up and actually create a private TLD that doesn't currently exist, like .nyame or .kofi, while managing it myself?
I trying to understand the implications behind this technology.

You sure can, however, it will not resolve on the global Internet. You'd
run your own DNS, populated from Nomulus, and then set up your other
computers to use that DNS server.
However, unless you plan on emulating private registrars too, it's simpler
to just skip straight to running your own DNS which you populate manually.
On Wed, Nov 8, 2017, 17:25 Aton B<EMAIL_ADDRESS>wrote:

Can I spin this up and actually create a private TLD that doesn't
currently exist, like .nyame or .kofi, while managing it myself?
I trying to understand the implications behind this technology.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/nomulus/issues/69, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABOxDiS3hnqWoz54M7a6MORyk0Gkjs1Hks5s0eQFgaJpZM4QWvlT
.

Hello, you need to wait for the next ICANN new gTLD application round to create an official TLD. This should be open within a few years period of time. I do a follow up with news on the subject here: http://www.gtld.club/p/newsletter.html

IF you create test TLD(s), use .example - or you might be safe to prefix
the TLDs that you're testing with xx-- so as to avoid contributing to
namespace collision.  Alternatively, create 'TLDs' as subdomains of
existing domain names (ie if you own bar.foo, create TLD.bar.foo as your
"TLD")
Jothan Frakes
+1.206-355-0230 tel
+1.206-201-6881 fax
On Wed, Nov 8, 2017 at 9:57 AM, Jean Guillon<EMAIL_ADDRESS>wrote:

Hello, you need to wait for the next ICANN new gTLD application round to
create an official TLD. This should be open within a few years period of
time. I do a follow up with news on the subject here:
http://www.gtld.club/p/newsletter.html
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/nomulus/issues/69#issuecomment-342901171, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAUJpVxD06qEBvoPyN-FhXmZnTDm7XFOks5s0euMgaJpZM4QWvlT
.

Will do @dnsguru.
Excellent resource, @nolliug; subscribing.
Great insights, @CydeWeys.  When you say "resolve", that means others couldn't simply type the address in their brower's address bar?  If not, how can they get the TLD that's been created?

ICANN will need to delegate the TLD created to your designated nameservers for it to resolve. You can create a whole hierarchy of domain names that mimics the internet itself, but unless the root nameservers actually point to it, it is isolated from the internet that everyone uses.
As @nolliug pointed out, when ICANN does the next round of gTLD expansion, newly created TLDs will be delegated.
Note that Nomulus supports multi-part TLDs, so if you do own domains like bar.foo, you can use Nomulus to manage subdomains under it. But I agree with @CydeWeys that it is probably easier to just maintain the DNS yourself. The main purpose of Nomulus is to manage EPP communications between registries and registrars. If bar.foo is not open for registration, there's no point running a full registry platform like Nomulus.

It's important to point out that there's a long elaborate process involved in getting a TLD delegated to you, as well as a startup cost of something on the order of $200K (if no one else wants that TLD) plus $25K per year, all paid to ICANN.  So how badly do you want .nyame or .kofi?

@jianglai and @CydeWeys, can you quickly explain what you mean by "running/maintaining the DNS yourself"?

There's a large variety of software applications that can be used to run DNS, with BIND being the most well known.  You can run your own DNS using this software, then configure your other computers to use it.  Then you'll be able to do whatever you want with domain name resolution.

Got it @CydeWeys.  Thanks!


Mark @backstage/backend-common as deprecated package

Context
This is part of the New Backend System 1.0 rollout plan.
Description
Ensure that are no monorepo packages or plugins are dependent on the soon-to-be-deleted @backstage/backend-common package. Also add a deprecated message in the README file (see example here).

User settings PR: https://github.com/backstage/backstage/pull/26049


Disc Dpad for Tekken

Preview

Example Video
Skin File

Archive: gamepad-disc_tekken.zip
Single File: disc_tekken.compressed.mpskin.txt

This is a recolour customization for the disc dpad skin. I am not using the traditional button mapping so I don't think this will be interesting to general users, but I am uploading it as an example of sharing a custom skin. Also it used drawImageInPolygon instruction for the first time.

And I will close any 'issues' after I confirm it's seemingly working.
I believe the owner can always edit their issue for updates and even reopen if it's needed.


is_authorized_partial should allow unknown entity for resource

Category
User level API changes
Describe the feature you'd like to request
I'd like to be able to make is_authorized_partial requests where principal, action, and context are known but resource is unknown. The intent is to have a guard in front of list operations so I can short-circuit actually going through the list of resources if the principal isn't allowed to list anything.
From: @aaronjeline :

It looks like the public versions of is_authorized and is_authorized_partial both take the same Request object, which doesn't have an option for having the resource be unknown.

Describe the solution you'd like
I think my ideal solution would be if I could call
Request::new(Some(EntityUid), Some(EntityUid), None, Context)

or
Request::new(Some(EntityUid), Some(EntityUid), UnknownEntity, Context)

where UnknownEntity is provided for the exact purpose of encapsulating an ast::EntityUIDEntry::Unknown. Support seems to exist already in Request for handling the ast::EntityUIDEntry::Unknown case:
https://github.com/cedar-policy/cedar/blob/d9201161d8ce45e015c8bcb1cd4191c11039709a/cedar-policy/src/api.rs#L2055-L2061
Describe alternatives you've considered
I've tried constructing requests with None and that didn't seem to work.
I've also tried accessing ast::EntityUIDEntry::Unknown from my code but it's not exposed.
Additional context
This may conflict with #72 depending on the implementation.
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request
[X] ⚠ This feature might incur a breaking change

Thanks for the issue, we'll discuss internally and get back to you.

Update: We're going to put the partial evaluation APIs behind the experimental feature flag in the next patch. Releasing them as non-experimental was an oversight because we don't yet have a formal model of them. We'll plan to implement this behind the experimental flag as well and then make it non-experimental once a formal model is completed and we've differentially tested the Rust vs the model.

Update: this issue was resolved by #244. On the main branch, you can now create a request with unknowns using RequestBuilder::build(). This interface is hidden behind the "partial-eval" flag (like the rest of the partial evaluation APIs) and we expect it will be included in the next release.


Add layer of compatibility with 2.x

If full compatibility is impossible try to achieve a minimum of mandatory changes

New library version has different package name and can be easily used with 2.x


Accept Qemu options from commandline

Accept additional Qemu options from commandline. Sample usage:
fakemachine --qemuopts="-display sdl,gl=on -vga virtio -serial mon:stdio"
Signed-off-by: Lakshmipathi.G<EMAIL_ADDRESS>

@Lakshmipathi the git history for this PR is rather weird? Looks like you did a merge commit at some point. Could you clean it up and resubmit?

@sjoerdsimons okay, please ignore this PR, will send a clean/new PR.

okay, updated this PR

Will send a new PR , closing this.


fix URL address popup won’t show when hovered on terms/privacy links on about page

Details
replace Text with TextLink which is already used in other pages
Fixed Issues
$ https://github.com/Expensify/App/issues/12238
PROPOSAL: https://github.com/Expensify/App/issues/12238#issuecomment-1297615577
Tests

Login to any account on web chrome browser
Go to Settings -> About page
Hover over the ‘terms of service’ and ‘privacy policy’ links at the bottom of the page.
Verify that the url address shows at the bottom left corner of the website.

[x] Verify that no errors appear in the JS console

QA Steps

Login to any account on web chrome browser
Go to Settings -> About page
Hover over the ‘terms of service’ and ‘privacy policy’ links at the bottom of the page.
Verify that the url address shows at the bottom left corner of the website.

[ ] Verify that no errors appear in the JS console

PR Review Checklist
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots
Web
https://user-images.githubusercontent.com/97473779/199789156-531055d9-e9fa-4c84-9099-b08f7a24c7f4.mov
Mobile Web - Chrome
https://user-images.githubusercontent.com/97473779/199788712-c465b42f-f5f2-4830-a7d2-0aebfec5efa4.mp4
Mobile Web - Safari
https://user-images.githubusercontent.com/97473779/199789027-a16ee966-9f0a-4e3e-a885-6fbee62d0632.mp4
Desktop
https://user-images.githubusercontent.com/97473779/199788571-5bf1ccb4-8634-4398-bbb6-03604c780973.mov
iOS
https://user-images.githubusercontent.com/97473779/199788634-588a0f48-2024-4671-8b65-a93f21561a3a.mp4
Android
https://user-images.githubusercontent.com/97473779/199788450-4661bbc3-c4a2-4298-a590-a845441d4846.mp4

@eVoloshchak I know you've been pretty busy recently, do you have time to review this or should I go ahead?

@eVoloshchak I know you've been pretty busy recently, do you have time to review this or should I go ahead?

I have the time, going to start reviewing this soon, thanks!

Screenshots
Web
https://user-images.githubusercontent.com/9059945/200351213-aee253c2-a07a-4457-b422-2d27a7a0461c.mov
Mobile Web - Chrome
https://user-images.githubusercontent.com/9059945/200351294-d8b4de2d-cec2-4f16-b0b0-37c6da4407ff.mp4
Mobile Web - Safari
https://user-images.githubusercontent.com/9059945/200351325-0b788b16-7ae6-473f-bbfb-ea95aef1508c.mov
Desktop
https://user-images.githubusercontent.com/9059945/200351342-37aa4b04-fb86-49b9-9566-7375c26ef3e7.mov
iOS
https://user-images.githubusercontent.com/9059945/200351368-c60b711b-7388-40e3-8f0c-5c548fc8b8bb.mov
Android
https://user-images.githubusercontent.com/9059945/200351404-100424f3-2ece-4c79-95df-e3386dfaeb81.mp4

PR Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Saw screenshots & approved checklists so I didn't notice tests weren't all passing 🙃

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @Beamanator in version: 1.2.25-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @yuwenmemon in version: 1.2.25-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


trigger doIn() only once per element

Is there any way to remove onScreen from a specific element?
For example, my page is divided into sections and they all have the same class 'log_entered_viewport'. What I want is that only the first time they enter the viewport that onScreen will be triggered and I will log the event. If the users scrolls up and down the page and the particular section enters the viewport, then I only want it to be triggered once.

That was quick :) Solved it by adding a 'logged' class to the element and then checking for the class.
In other words, it's like the 'toggleClass' option, except that the class is removed.
doIn: function() {
   		$e = $(this);

		if ( !$e.hasClass('logged') ){

			// -- code to log that the element has entered the viewport

                            // add the class the mark that the element has been logged
			$e.addClass('logged');

		}

   }

heh, I was going to suggest something along those lines


Few questions about training

Hello @ttengwang ,
I am trying to train your model from scratch (just for learning purpose). However I am facing few issues:

the train_caption_file or val_caption_file does not have labels, which is being used in video_dataset.py (also in class loss). Am I using some wrong file?
I tried with labels from action_proposal dataset (with captioning related part removed), but the loss_ce doesn't decrease at all, both in train and val (did you face any issues like this?). Also the loss_ce is coming in ranges of 300-400.
How many epochs you trained before getting decent captions?

Since we consider localization as a binary classification, so all action_labels is set to 0 (0 for foreground, 1 for background). If you want to perform multi-class classification, add annotations of action_labels in train_caption_file and val_caption_file.
I tried to train ActivityNet Captions with the captioning head removed, and the loss and performance are reasonable. The configs are at https://github.com/ttengwang/PDVC/blob/main/cfgs/anet_c3d_props.yml
5 epochs for readable captions, and 10-25 epochs for best performance (It depends on different video features)

Thank you for your reply,
Can you please provide the file with action labels in it

The Activitynet Captions datasets were labeled by different annotators with ActivityNet 1.3. So there are no official annotations of action labels for Activitynet Captions. Sorry that I didn't train the model on ActivityNet 1.3, so you may prepare a new train_caption_file by yourself.

Hey, I tried with your given anet_c3d_props.yml config, It is now training better and train losses are decreasing steadily.
However val losses are almost constant, can you suggest what parameters I should check or tweak (given that I am training for 200 classes)

Also, try to set  bbox_loss_coef >0.

Ok thank you,
Keeping bbox_loss_coef = 0 means you are not using it?,
This are the current parameters:
batch_size = 16
lr = 1e-4
lr_drop = 200
weight_decay = 1e-4

num_classes = 200
num_queries = 100
d_model = 512

cls_loss_coef = 1
counter_loss_coef = 2
bbox_loss_coef = 5
giou_loss_coef = 2
self_iou_loss_coef = 2
mask_prediction_coef = 2
eos_coef = 0.1

matcher.cost_class = 1
matcher.cost_segment = 5
matcher.cost_giou = 2
matcher.cost_alpha = 0.25
matcher.cost_gamma = 2.0

# Deformable Detr
num_heads = 8
num_feature_levels = 4
dec_n_points = 4
enc_n_points = 4
enc_layers = 6
dec_layers = 6
transformer_ff_dim = 2048

Result:


Allow specifying list of credentials and vault in 3.3

Connect #404
This is actually leap-frogging the development in Tower and AWX, which is possible because we neglected vault-credential support on launch up until now.
If you had Tower 3.2, you weren't able to specify a vault credential on launch. With this PR, it will remain that way (although with a nice error message). If you have AWX, however, this will let you specify vault credential, or multiple --credential="cred1" --credential="cred2" directly.

Coverage decreased (-0.2%) to 90.487% when pulling cc328dfad9e927352b37914213c87a148009cde0 on AlanCoding:new_credentials into 1a662f51f900b089dd2d74956fd1d90b466da2f3 on ansible:master.

On second thought, the leap-frog might not be a good idea. It's probably better to just pass vault_credential as vault_credential if it's given.


[Documentation]: Add SDK 6.2.4

Description of errors

Attach any links, screenshots, or additional evidence you think will be helpful.
No response

Hi @johnnynunez. Internal ticket has been created to update docs. Thanks!


Updated VHDL syntax file with PSL keywords and more VHDL-2008 unresolved types.

@danielkho thanks!


Fixed a bug in sync_toManyRelationship referencing the wrong entity.

The entity in sync_toManyRelationship was referencing the parent entity instead of the destination entity. This is was the reason for the uncaught exception as referenced in the following open issues:
https://github.com/hyperoslo/Sync/issues/272
https://github.com/hyperoslo/Sync/issues/280
https://github.com/hyperoslo/Sync/issues/285

I performed the changes locally in my project and this fixes #280 for me.

@kikanny fantastic work! I verified and this fixes the issues.
You find a test case and a fix for the Swift 3 branch here.
https://github.com/hyperoslo/Sync/pull/290


Replace unsafeCoerce with coerce for classes, d and path

Partially fixes #14.
Replaces unsafeCoerce with coerce for attributes classes, d and path. For d and path, a function is provided in Halogen.Svg.Attributes.Path to avoid having to export the constructor for PathCommand.
Three uses of unsafeCoerce remain in Halogen.Svg.Core.element, Halogen.Svg.Elements.element and Halogen.Svg.Attributes.attr. I'll put further discussion of how to remove those in #14.

Thanks!


Including full error range in TSC output

From https://github.com/Microsoft/vscode/issues/70465
Repo

For the TS code with strict enabled:
const obj = {
    prop: Date.now() ? 'str' : undefined
}

obj.prop.toLowerCase();

Run a tsc task in VS Code to see reported errors (make sure to close the ts file as well)

Problem
We currently only report the potential undefined access error on obj in the line obj.prop.toLowerCase();. The correct range should span obj.prop.
The root cause of this is that VS Code's problem matcher does not have the full range of the error from tsc, only the start line and column. Here's the tsc output:
src/index.ts:7:1 - error TS2532: Object is possibly 'undefined'.

7 obj.prop.toLowerCase();
  ~~~~~~~~

With the current tsc output, there is also no way to extract the full range of the error.
Request
Somewhere in the line src/index.ts:7:1 - error TS2532: Object is possibly 'undefined'. , add the end position as well so that tooling can properly highlight it. We would want to do this in a way that doesn't detract from the error's human readability. This needs some thought

@mjbvz How would you feel about a --formatter json command line option for providing diagnostics in a machine readable format from the command line tools? Or is that too far and away from the current problem matcher infrastructure to be useful?

Hmm, needs some thought. It would definitely be easier to parse but I have a few concerns:

We expose the raw output of the running tsc command to users. I personally find it helpful to see the entire list of task errors in the console sometimes. Json output on its own would be much less helpful

We would have to make sure that --formatter json is passed in to any tasks running on newer TS versions. I think this should generally be ok since our tasks generate the command line script to run, but I need to double check. It's possible there are many configured tasks in workspace that hard code running tsc directly and applying our standard problem matcher. They would not benefit from any new flags.

@mjbvz The other thing I was thinking might work without changing how the output looks to humans is something like:
src/index.ts:7:1:7:9\b\b\b\b - error TS2532: Object is possibly 'undefined'.

7 obj.prop.toLowerCase();
  ~~~~~~~~

where \b is the actual backspace character escape code, thus hopefully hiding the extraneous information from rendered output (provided the renderer supports the control character), but still providing the info to match on. That's real hacky-feeling, though, which is why I think I'd much prefer to see a dedicated json-formatted output that can be as rich as we'd like, rather than trying to serve humans and machines with the same output.

Lots of times, JSON output is useful for connecting various build tools.
Right now it's already possible to use Regex to parse out error messages:
/^(.*)\((\d+),(\d+)\): (.*) (TS\d+): (.*)$/gm
// with named capture groups
/^(?<filepath>.*)\((?<line>\d+),(?<column>\d+)\): (?<category>.*) (?<type>TS\d+): (?<message>.*)$/gm

However, this isn't very portable, it'd be much nicer if you could specify a way to emit errors/warnings as JSON.
tsc --noEmit --json # or whatever flag

interface TSCError {
  filepath: string
  line: number
  column: number
  category: "error" | "warning"
  type: "TS0000" | "TS0001" | ...,
  message: string
}

interface TSCJSONOutput {
  errors: TSCError[]
}

Other output can be printed to stderr, but stdout should be pipe-able as valid JSON.
tsc --noEmit --json | jq .errors

Any progress here?

👍  Another advantage of this flag would be that we could leverage other tools to gather information about errors in a project; for example, jq could be used to construct a cli command to show only errors in a certain directory or with a certain type, without needing any additional tooling on the part of tsc.


Fix pr_draft? GitHub Method

Description
This PR resolves #1338
My best guess is that there was a change in GitHub's API functionality and the mergeable state now doesn't return "draft" when the PR is a PR. In fact, now there's this dedicated API, so we should just be using it anyway 😊
Tests
Dangerfile:
if defined?(github) and github.pr_draft?
  message("Test: skipping early")
  return
else
if defined?(github)
  is_github_defined = true
else
  is_github_defined = false
end
if is_github_defined
  is_draft_pr = github.pr_draft?
  if github.pr_json['draft']
      message("github.pr_json['draft'] = true")
  end
end
message("Test: not skipping. is_github_defined  = #{is_github_defined}, is_draft_pr = #{is_draft_pr}")
message("#{github.pr_json['draft']}")
message("#{github.pr_json.inspect}")

Before

After

Perfect answer IMO


Use classic FileUpdateChecker instead of watcher-based implementation

There seems to be a bug in Docker for Mac (and probably also for Windows) which prevents file system events to propagate into containers. As a result, Rails doesn’t automatically reload changed source files in the development environment.
It’s a known issue and a fix should land in the near future. For the meantime, it’d be nice if we could use the classic FileSystemChecker which doesn’t rely on file system events. I’ve subscribed to updates on the issues mentioned and will revert that change once the bug has been fixed.

I was also noticing my file watcher for React (Hot Module Reloading) was not picking up changes, even with gRPC fuse off, I was running latest edge (<IP_ADDRESS>), and had to downgrade to be able to develop on my workflow... is this an issue w/ the latest edge?

Hi @kylepeeler, unfortunately, I can’t help with this as we’re working on a Ruby project and I don't have the latest edge build installed. You might want to have a look at the relevant issue in the docker repository (or ask your question there):
https://github.com/docker/for-mac/issues/4962

Yeah I posted here since it said in that issue it was fixed, but didn't seem to be the case for me... followed up in there as well! 😎

@tillprochaska @kylepeeler a service similar to @dependabot would be great, which automatically reverts a commit that was marked as #auto-revert: https://github.com/docker/for-mac/issues/4962 as soon as the referenced issue is closed.
We have plenty of FIXME and TODO.

@phoeinx @mattwr18 on my Linux machine, changes are propagated to the container, so no objections from my side. Could sb. of you who is on Mac review this PR?

For some reason, the fix suggested in the linked issue (disabling the gfuse file system) seems to have solved that problem on my machine. Not sure what made the difference. In case anyone’s having issues, feel free to reopen the PR.


Login failed for user error on MacOS 13.1

Description
I am running DBeaver Version <IP_ADDRESS>301060755 on MacOS 13.1 (M1 Pro)
I am running the same DBeaver Version on my Windows Machine.
When I try to establish a connection to an AZURE SQL Server instance, the MacOS DBeaver fails to login, the Windows DBeaver does it perfectly.
Error message on MacOS is: Login failed for user '*********'. ClientConnectionId:79f5a76c-261d-46d7-88d9-f04b3539358b (the ClientConnectionId naturaly changes every time)
DBeaver Version
<IP_ADDRESS>301060755
Operating System
MacOS 13.1 (M1 Pro)
Database and driver

Azure MSSQL Server
Microsoft JDBC Driver for SQL Server (MSSQL)
com.microsoft.sqlserver:mssql-jdbc:RELEASE 11.2.2.jre17

Steps to reproduce
No response
Additional context
No tunnels, no custom driver settings, factory settings

Hello @CRudde,
What authentication method are you using?

What authentication method are you using?
SQL Server Authentication

The error seems to be in the driver version... i looked into the docs and changed the driver version to 11.2.3.jre17. Now everything works like a charm.

Thanks for the clarification.
We need to update the preferred driver version on our side.


⚠ Bofrost.be has degraded performance

In 7838864, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 947 ms

Resolved: Bofrost.be performance has improved in d86332e after 13 minutes.


bazel: linkstatic always.

I've had a few reports of obscure link issues with our static prebuilts when not linking tests and
binaries static, so let's just default to this. We can leave it to the future to optimize this when
we have stability in Bazel land.

@hennna

Thanks was going to ask for this to be done today. Seeing same issues.


ScrollView keyboardShouldPersistTaps

Could you add an attribute keyboardShouldPersistTaps="handled" ? or maybe add that props to carousel component.
Because sometimes inside the carousel we use component with TextField
https://facebook.github.io/react-native/docs/scrollview#keyboardshouldpersisttaps

Any update?

@VitalyKozhemyaka just work my repo, i fixed it =)
https://github.com/Gazfay/react-native-looped-carousel


Error response when getting the task list count.

Describe the bug
The get_tasks_count method is returning this response.
{
   "error":{
      "code":"UnknownError",
      "innerError":{
         "client-request-id":"643b6c85-ddd3-4dcf-bd58-475528608f9c",
         "date":"2023-09-26T02:27:35",
         "request-id":"643b6c85-ddd3-4dcf-bd58-475528608f9c"
      },
      "message":""
   }
}

I think this may be an issue with Microsoft Graph or the API version you're calling, I think a request header has to be set, refer to this for more information:
https://devblogs.microsoft.com/microsoft365dev/build-advanced-queries-with-count-filter-search-and-orderby/
To Reproduce
Steps to reproduce the behavior:

Call the method using the following API.

client.me().todo().list(task_list_id).tasks().get_tasks_count().send().await?;

Expected behavior
Return the count for the specified list.
Desktop (please complete the following information):

OS: Fedora 40

@edfloreshz Thanks for the report.
It does look like on these the ConsistencyLevel header is required. I'll have to dig into the open api metadata to see whether they are including that header as required so its implementation can be automated.
But for now, if you want to use that endpoint you can add the header yourself to the request by doing:
client.me().todo().list(task_list_id).tasks().get_tasks_count()
.header(HeaderName::from_str("ConsistencyLevel").unwrap(), HeaderValue::from_str("eventual").unwrap())
.send().await?;

Thanks

Neat! I'll try that today.
Thanks 🙂


fix: export useContractKit

Overview
While going over the list of checks for v4.0, I noticed I couldn't use useContractKit .
I got the error:  Module '"@celo/react-celo"' has no exported member 'useContractKit'.ts(2305)
Adding it to the export in react-celo/src/index.ts fixed it.

good catch on that

Codecov Report

Merging #215 (3a8c829) into master (18ac469) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   45.42%   45.42%
=======================================
  Files          51       51
  Lines        1376     1376
  Branches      182      182
=======================================
  Hits          625      625
  Misses        593      593
  Partials      158      158

Impacted Files
Coverage Δ

packages/react-celo/src/index.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18ac469...3a8c829. Read the comment docs.


[jtag_dmi_reg] Correctly handle a confusing situation where TCK is much faster than the main clock

This fixes issue #21517. The first two three commits have no functional change, but make the code a bit easier to read.
Following that is a change to the frontdoor sequence. This tweak ensures that we send an extra JTAG transaction just after doing a DMI request. Doing so ensures that we get truthful tracking of DmiOpInProgress afterwards.
Finally, there's a change to the monitor to avoid it believing that the DUT has suddenly become busy without being asked to do an operation (which is very confusing to debug!)

Private CI complains in the smoke tests that ERROR: [dvsim] Errors were encountered in this run. Although it doesn't give any details on that, so I'm not sure how to resolve those.


Fix #464, story table row matches on wrong trigger var when there's

only one row for the relevant variable. Closes #464.
Also

enhance reports about the problem.
avoids trigger var check entirely when it's not from a story
table

Need to resolve merge conflicts, so going to have to make a duplicate branch for this.


[8.x] Renamed 'salutation' to 'valediction' in the mail notifications

This is a simple pull request that just replaces all occurrences of salutation to valediction in the mail notifications.
My reasoning for this is that a salutation is usually the opening part of a letter/email and the valediction is at the end (or at least that's my understanding). I got a little bit confused while trying to modify a mail message and had to start delving into the mail template to find out how to update the valediction in the message. I'm guessing other people might have had the same issue?
I've added this a breaking change because all occurrences of ->salutation() will need to be updated to ->valediction() in the notifications. Any existing mail templates that have been published will likely also need to be updated to match this change as well.
Hopefully, this is all okay?

Thanks for the PR but honestly I don't think this is worth the breaking changes.

No problem, I had a feeling you were going to say something along those lines. It was worth a shot :smile:


Incorrect Syntax Highlighting for CSS Properties and Values API

When using the CSS Properties and Values API in a CSS file, I'm running into issues with incorrect syntax highlighting that seems to stem from an unknown rule warning for @property.  Below is a screenshot of my CSS file, with the warning displayed:

My current version of Visual Studio Code is 1.62.3, my OS is Windows 11, and the theme is Monokai Dimmed.  However, I did try switching between a number of the built-in themes and experienced the same results.
Here is a link to the corresponding rule definition in MDN: https://developer.mozilla.org/en-US/docs/Web/CSS/@property

HI @alexr00 - yes, but that's where I was a bit confused, because according to the MDN documentation the CSS above is correct.  But I'll follow the upstream issue and see what I can do to help get this resolved.  Thank you!


Properly check if uri.getScheme is not null and merge some other PR

This PR is related to #167, but also merges https://github.com/entria/react-native-share master to  https://github.com/EstebanFuentealba/react-native-share master and closes #131
At Entria, we've already tested on production and it's working.

@EstebanFuentealba could you review this one, please? Thanks a lot 😄

Hello, I check it today, greetings and thanks for contributing 👍 :D


Materialize.js is loaded but not getting applied to html pages loaded in angular's ui-view.

Here is on stack overflow I have explained the issue in detailed.
http://stackoverflow.com/q/42456586/1936024
Sorry for not explaining it here. I am writing from mobile.
Thanks.

In this kind of issue, a live example (codepen) provide us a way to experiment exactly that you're facing and play with it to try get a solution at the same time.
Closed due inactivity, feel free to reopen it if it is still necessary.


Consolidate Azure Functions Node defs into one with a build arg

This PR consolidates the azure-functions-node-10 and azure-functions-node-12 into one definition with a build arg in devcontainer.json
For Node 10:
"args": { "VARIANT": "10" }

For Node 12:
"args": { "VARIANT": "12" }

This will reduce maintenance as new versions come out if the image tag remains the same. We're doing this with other definitions as well.
//cc: @anthonychu @TsuyoshiUshio for input on the approach.

Sounds good to me. And just in time for Node 14 coming in a couple months. 🙂


Check either Branch is enabled or not before usage

Description
LEARNER-2626

Codecov Report

Merging #1011 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1011      +/-   ##
==========================================
- Coverage   45.76%   45.76%   -0.01%
==========================================
  Files         409      409
  Lines       27117    27119       +2
==========================================
  Hits        12410    12410
- Misses      14707    14709       +2

Impacted Files
Coverage Δ

Source/OEXAppDelegate.m
13.88% <0%> (-0.27%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb2403...58a2911. Read the comment docs.


Percentile list tests are added for uihandler

uihandler test file is created, percentile tests and some other methods tests are written.

ping :-)

reopened to find the manuals steps as #204 can't be opened
git checkout -b olimpias-uihandler-test master
git pull https://github.com/olimpias/fortio.git uihandler-test

Step 2: Merge the changes and update on GitHub.
git checkout master
git merge --no-ff olimpias-uihandler-test
git push origin master

sgtm, thx!


Various lost in limbo fixes

The conflict panel is still getting called on the main thread in -[FSActions renameFile:withName:]. 😃
Why not force it to the main thread in QSFileConflictPanel itself so the one calling it doesn’t have to remember?

Added some commits so we can get a release out @tiennou. Let me know what you think.
As for the panel getting detached from the interface, it seems to happen only if I build on 10.10 and run on 10.12. Running QS on the same machine I build from always seems to work.
On that subject… Is there any reason to keep building on 10.10? We’re going to disable ATS. Were there any other reasons? (Also, since we require 10.10 now, I’m going to update the deployment target and fix the OS version code in another pull request.)

One more commit, but this isn’t ready. Even if you choose to replace the destination, it fails because it already exists.

The problem with replacing files seems to be from very old code.
https://github.com/quicksilver/Quicksilver/blob/master/Quicksilver/PlugIns-Main/QSCorePlugIn/Code/QSActionProvider_EmbeddedProviders.m#L669
Doesn’t that mean the files will never be replaced, even when you explicitly approve it? What am I missing?
Anyway, no need to hold this up for that issue.


I/flutter (18471): Unable to access server

I/flutter (18471): email-auth >> Remote server is not available -- using test server --
I/flutter (18471): email-auth >> ❗ Warning this is not reliable on production
I/flutter (18471): --- Package Error ---
I/flutter (18471): Unable to access server. 😑
I/flutter (18471): --- End Package Error ---
I/flutter (18471): Failed to send the verification code
I followed every step from https://saran-surya.github.io/email-auth-node/
Do I only add server and serverKey from env file?
is serverKey indication the randomly generated SERVER_API_KEY in config.env ?
If so, I am still getting this error

Don't we have to add Config Vars in Heroku's settings? I don't think it's ever mentioned in the instruction. Even after I did, I am not receiving OTP when I sent the verification code although it says that the code is sent successfully. So I tried sending again, and again, but it says it's failed to send AND unable to connect to remote server eventually.

I have resolved the issue. I am closing it.

Thankyou for your time. Please mention what was your issue, It might help other people.


[cinder-csi-plugin] btrfs-volumes not mountable by cinder-csi-plugin

What this PR does / why we need it:
This PR adds the necessary binaries (via the corresponding deb-package) to be able to mount volumes containing btrfs. ( see issue #1934 and this comment ).
Which issue this PR fixes(if applicable):
fixes #1934
Release note:
[cinder-csi-plugin] added capability to mount btrfs volumes.

/ok-to-test

/test openstack-cloud-csi-cinder-e2e-test

/lgtm
/approve


187121440 materials bulk upload

Pivotal Tracker Link

What this PR does:

This pull request fixes|implements (pick one...) ______.
Include screenshots, videos, etc.
Who authored this PR?

How should this PR be tested?

Is there a deploy we can view?
What do the specs/features test?
Are there edge cases to watch out for?

Are there any complications to deploying this?

Checklist:

[ ] Has this been deployed to a staging environment or reviewed by a customer?
[ ] Tag someone for code review (either a coach / team member)
[ ] I have renamed the branch to match PivotTracker's suggested one (necessary for BlueJay)

Would it be possible to write a few tests that checks the csv is working


Processing images with more than 256 cells

Hi,
I'm curious whether Usiigaci can be applied to some images of ours that contain many cells (usually around 100 but up to 300), which sometimes exceeds the 8-bit limit on the labels.
I read here that you have a new implementation that supports more cells. Is this something you are planning on releasing soon? If not, I'm curious where the limitation is. Is it only the tracker? I had a quick look through the training and inference code and couldn't find anything that would indicate an 8 bit limit there, so if I just want to see how well images are segmented, can I use a 16-bit image for the labels?
Thanks!

Hi yes, like you said this version is limited to 8 bit.
It is related to the mask rcnn matterport part not the tracker part.
This version of tracker should be able to deal with 16 bit without problem. the problem was at segmentation.
we are working on new implementation on pytorch which is 16 bit.. but currently not yet ready to release. If you're good at modifying maskrcnn matterport or if you use maskrcnn benchmark to do segmentation, you should be able to get 16bit results to handle cell number up to 65000ish

Ah good to know thank you. I think I'll patiently wait on the pytorch implementation, in the meantime we can make do with chopping up the images to ensure < 256 cells are visible in each one.


Export unique variants from a clinical group

Is there a way to export all the unique variants from a clinical group. For example, in the below laml object, how to export the mutations only presented in the FAB_classification=='M1'?
library(maftools)
#path to TCGA LAML MAF file
laml.maf = system.file('extdata', 'tcga_laml.maf.gz', package = 'maftools')
#clinical information containing survival information and histology. This is optional
laml.clin = system.file('extdata', 'tcga_laml_annot.tsv', package = 'maftools')

laml = read.maf(maf = laml.maf, clinicalData = laml.clin)
<EMAIL_ADDRESS>     Tumor_Sample_Barcode FAB_classification days_to_last_followup
  1:         TCGA-AB-2802                 M4                   365
  2:         TCGA-AB-2803                 M3                   792
  3:         TCGA-AB-2804                 M3                  2557
  4:         TCGA-AB-2805                 M0                   577
  5:         TCGA-AB-2806                 M1                   945
 ---
189:         TCGA-AB-3007                 M3                  1581
190:         TCGA-AB-3008                 M1                   822
191:         TCGA-AB-3009                 M4                   577
192:         TCGA-AB-3011                 M1                  1885
193:         TCGA-AB-3012                 M3                  1887
     Overall_Survival_Status
  1:                       1
  2:                       1
  3:                       0
  4:                       1
  5:                       1
 ---
189:                       0
190:                       1
191:                       1
192:                       0
193:                       0

Hi,
You could use subsetMaf
> subsetMaf(maf = laml, clinQuery = "FAB_classification %in% 'M1'")
-subsetting by clinical data..
--44 samples meet the clinical query
-Processing clinical data
An object of class  MAF
                   ID          summary   Mean Median
 1:        NCBI_Build               37     NA     NA
 2:            Center genome.wustl.edu     NA     NA
 3:           Samples               43     NA     NA
 4:            nGenes              349     NA     NA
 5:   Frame_Shift_Del                7  0.163      0
 6:   Frame_Shift_Ins               27  0.628      0
 7:      In_Frame_Del                5  0.116      0
 8:      In_Frame_Ins               11  0.256      0
 9: Missense_Mutation              347  8.070      8
10: Nonsense_Mutation               29  0.674      0
11:       Splice_Site               27  0.628      0
12:             total              453 10.535     11

Thank you for your reply. If I understand correctly, this is a subset of mutations in the M1 class but might be not exclusive. A mutation in this subset might also present in other groups especially when there are large number of samples. What I am trying to get are mutations only occur in this subset but not in the rest. Does it make sense?

Hi,
There is no direct way of achieving this but it can still be done. setdiffMaf might be a good option here,
# M1 samples
m1 = subsetMaf(maf = laml, clinQuery = "FAB_classification %in% 'M1'")

# Non M1 samples
rest = subsetMaf(maf = laml, clinQuery = "!FAB_classification %in% 'M1'")

# M1 specific
m1_sp = setdiffMAF(x = m1, y = rest)

Hope this helps. Let me know if you still find any differences.

Hi Thank you for your reply. This solved my problem.

I am trying to get non-syn only with `includeSyn = FALSE' but got an error
setdiffMAF(x=maf_resp, y=maf_resp_c, includeSyn =  FALSE)
Error in subsetMaf(x, mafObj = FALSE, ...) :
Please provide sample names or genes or a query or ranges to subset by.

Hi,
Sorry, this should have been handled properly. I will fix it with the proper error message.
Meanwhile, if you want just the non-syn variants, you could grab all variants from the data slot of the resulting MAF object.
m1_sp = setdiffMAF(x = m1, y = rest)

# non-syn variants
m1_sp@data


feat(storage): helper functions for new lifecycle action

A new helper function to avoid typos. Also add the snippet for this
feature.
Fixes #8690

This change is

/FYI: @BrennaEpp @shaffeeullah

Looks good! Thanks @coryan ! Note we're not officially supporting samples for this, but doesn't hurt to have it.


Added Gemfile.lock to gitignore file

I added Gemfile.lock back to gitignore file, because of Gemfile.lock file I am unable to use rails5.0 though I have rails5.0 installed on my system.

Gemfile.lock should only be used when developing camaleon-cms itself. How is it affecting your project?

Not to mention, there is still a Gemfile.lock in the repo...

Hi, I am getting this issue when I am using cloned copy of camaleon_cms using my Gemfile as below.
gem 'camaleon_cms', '2.3.6', path: 'vendor/plugins/camaleon-cms'

What is the issue?


add sending output format strings and templates lab

The Log4J developers prior to CVE-2021-44228 allowed uses to load arbitrary variables (and code) from a remote JNDI server using the logging templates. This example comes from the patch for CVE-2021-44228, and is part of the fix for that vulnerability which restricts which JNDI server host one can load variables from.

@david-a-wheeler can you review Jason's submission please?

I'm really sorry I didn't respond earlier, I somehow missed this.
Thanks so much for taking a stab at this! I also like the approach of using a known CVE, I think that can be helpful.
However, I don't think this lab best illustrates the ponit. This lab focuses on "Restrict the JNDI hostnames from which variables can be loaded." That's a lab on restricting the inputs that are allowed, and we already have a lab on that topic.
What we need is a lab that mirrors Format Strings and Templates. Now the weird thing is that we DO use this specific vulnerability as an example of the problem. However, what I meant when referring to this CVE is that if an attacker can cause any reaction simply by causing text of the form ${jndi:ldap://...} to trigger loading of external code, that's a problem. You're absolutely right that restricting the access to localhost greatly reduces the impact of the vulnerability, but really, allowing attackers to trigger random jndi at all is a problem, and the intent was to focus on that.
Can you modify the material so it's clearer that allowing an attacker to trigger any unexpected code execution, just via data that's output or logged, is a problem? Perhaps log4shell is not the clearest example, sorry about that.


compressWithList sometimes gives null error

compressWithList function sometimes gives the following error:
Unhandled Exception: type 'Null' is not a subtype of type 'FutureOr<Uint8List>'

I have tried calling this function with the same bytes that are read from the same picture selected with image picker library in a loop. The result is the function sometimes compresses the picture successfully and sometimes gives the error above.
Relevant code is below:
final ImagePicker _picker = ImagePicker();

void _selectImage() async {
  // select image from gallery
  XFile? image = await _picker.pickImage(
    source: ImageSource.gallery,
  );
  print(image);
  if (image != null) {
    // compress the image
    Uint8List imageBytes = await File(image.path).readAsBytes();
    print(imageBytes.length);
    Uint8List compressed = await compressChatImage(imageBytes);
    print(compressed.length);
  }
}

const PIC_QUALITY = 25;
const PIC_WIDTH = 400;
const PIC_HEIGHT = 400;

Future<Uint8List> compressChatImage(Uint8List bytes) async {
  while (true) {
    try {
      return await FlutterImageCompress.compressWithList(
        bytes,
        quality: PIC_QUALITY,
        format: CompressFormat.png,
        minWidth: PIC_WIDTH,
        minHeight: PIC_HEIGHT,
      );
    } catch (err) {
      print(err);
    }
  }
}

Output:
Instance of 'XFile'
4322440
type 'Null' is not a subtype of type 'FutureOr<Uint8List>'
type 'Null' is not a subtype of type 'FutureOr<Uint8List>'
type 'Null' is not a subtype of type 'FutureOr<Uint8List>'
type 'Null' is not a subtype of type 'FutureOr<Uint8List>'
346085

I'm getting this error constantly, any update on this?

I'm getting this error constantly, too.

any updates ?

Sadly no one is attending this issue. I have the same issue. Just started using this library but can't compress any image.


Comparing against the wrong base (master) commit

The action compares a commit of a branch to the where it branched off master. Github seems to merge this commit with master head, so unit tests include master head and should compared against that (at least in pull_request_target). This has happened here. Make sure to compare to the master commit that is part of the merge, not master head, as master could have moved further while the action is running.
What if that commit cannot be merged into master? On which commit does GitHub actions run then?

This has happened there because it ran on pull_request_target event, which points to master head. That way we always build and test master head. This is a duplicate of #45.


Error at simulator setup when running catkin_make

I receive an error about the file 'localisation', inside folder 'msg' that seems to be incorrecly named. CMAKE expects that file to be called 'localisation.msg', as of what I can see by analysing the error text.

Fixed the issue with the latest commit.
Thank you for pointing it out!


Added Eirene in Frameworks and Libs section

Added link and description for Eirene.jl, produced and maintained by Gregory Henselman-Petrusek<EMAIL_ADDRESS><EMAIL_ADDRESS>

I added. Thanks.


no case handled if more than one window with the games name is found

What reason is there to have 2 ESO instances?

no i mean if there is a window with the same name, not necessarily 2 game instances, like lets say a folder named "Elder Scrolls Online" open


Add fast-scheduler extension

Co-authored with @helloworld
Description
Fast Scheduler is a utility for quickly scheduling Google Calendar events by simply typing a description like "lunch with jerry at noon at a poke restaurant downtown" or "date night with millie every thursday evening". Fast Scheduler supports multiple guests, automatic location lookup conversion across timezones, and recurring events. At the moment, Fast Scheduler integrates with Google Calendar with plans to support more calendar applications in the future.
Screencast
https://www.loom.com/share/32d9a1f6ec18492196730374535f6e84
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi 👋
I'm currently looking into this PR. I like the idea, but the warning screen from Google is something that really scares away users, which might be a roadblock.
We're discussing this internally. I'll get back to you with more information soon 🙂

Thanks @pernielsentikaer, are you referring to the Oauth permissions screen?

When you want to get your extension verified by Google, it's almost impossible.

How do we proceed from here? Are you trying to verify the scopes used here?
Without that, it might be hard for users to use this extension.

There is also #10354 and #10524 in the queue which also is about Google Calendar, it would be awesome to unite into one - not sure how the best approach would be though

Are you still available @tigershen23


call(string) Deprecation

I just recently started experiencing these warnings with a fresh node_modules install.
DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal
in Sass 4.0. Use call(get-function("color")) instead.

DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal
in Sass 4.0. Use call(get-function("size")) instead.

That comes from a change in Sass 3.5+, and is being fixed: https://github.com/oddbird/accoutrement-color/commit/483ffa7c0a3c9761b9739d457403e97814b8f303#commitcomment-28323266

Sweet. Thank you! Just making sure it was on the radar.


Do not hard code namespace when checking pod logs

I think it's better to let user specify the namespace, rather than hard code it with the one passed as a flag, since it's not mandatory for the user to pass the namespace flag.
Other functions in the kube_checks.go file are actually either allowing passing namespace or directly using the pod or deployment reference.

/hold since this function is currently used by Eventing project.

why hold? eventing has vendored it in and will get the update when pkg is updated.
/lgtm
/approve


Migrate to inkdrop 4

Hi. Inkdrop author here.
Seems like the original author has already quitted Inkdrop.
@charygao, would you like to transfer the ownership of the plugin to @libeanim?


Prevent null ID values in the ReciprocalRelationship__c field when deleting Contacts.

Critical Changes
Changes

Fixed an error that prevented Contacts from being deleted, even after deleting Relationship records associated with the Contact.

Issues Closed
Fixes #458

@lianeyee Since this is a small fix, I don't think it requires a description in the release note, what do you think?

@davidjray Since it was an internal-reported minor bug, I agree. Could we clarify the issue description, though? If this is accurate: "Prevent null ID values in the ReciprocalRelationship__c field when deleting Contacts."

@xinnanlisf @davidjray How's this for the release note? "Fixed an error that prevented Contacts from being deleted, even after deleting Relationship records associated with the Contact."

Thanks, @lianeyee!


Stop bots from running codecov upload step in CI

Description
This is just adding conditionals on the execution of the codecov upload step in CI to stop bots running that step, because they don't seem (or at least codecov doesn't) to have access to the required secrets, unlike PRs from actual repo members.
Fixes #589
Type of change

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[x] Bug fix (non-breaking change which fixes an issue)

Key checklist

[ ] Make sure you've run the pre-commit checks: $ pre-commit run -a
[ ] All tests pass: $ poetry run pytest

Further checks

[ ] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works
[ ] Relevant documentation reviewed and updated

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.09%. Comparing base (bb1211c) to head (4f501b6).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #590   +/-   ##
========================================
  Coverage    95.09%   95.09%
========================================
  Files           74       74
  Lines         4302     4302
========================================
  Hits          4091     4091
  Misses         211      211

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Ha! To be honest I was expecting:

the YAML syntax to fail or
the codecov job not to run here, where it should.

Lets see if the rebased dependabot merges run!


Describe the bug
eststs
Steps to reproduce

sdfgdfh
Error messages or log output
nasdfg

Browser
Firefox
Operating system
Linux
Additional context
addf

Test successful, closing this issue


Handle special characters correctly

Hi,
I discovered that #117 did not fix errors with special characters entirely. I am refering to your answer here
I had a Ü in a directory name and always got an "URI is malformed" exception, but when I renamed that directory the exception was gone.
Please make sure to handle Üü Ää Öö ß properly ;)
Thank you for your work ;)

Do you have a stack trace?
Maybe you could create a failing test case?

This is the stack trace:

-> stackTraceRequest
{ command: 'stackTrace',
arguments: { threadId: 1, startFrame: 0, levels: 20 },
type: 'request',
seq: 13 }
<- stackTraceResponse
Response {
seq: 0,
type: 'response',
request_seq: 13,
command: 'stackTrace',
success: false,
message: 'URI malformed',
body: { error: { id: 0, format: 'URI malformed', showUser: true } } }

The path of the project I debug is C:\Users\jvb\VB Cloud\GRÜNE JUGEND\GRÜNE JUGEND Bundesverband\Meisterei des Netzes\webspace\wordpress\wp-content\plugins\gjmf
I use IIS as a local webserver.
I hope this helps!


All UI tests failing with AmbiguousViewMatcherException

When UI tests are run the following error occurs:
androidx.test.espresso.AmbiguousViewMatcherException: 'with id is <com.google.android.gnd:id/map_crosshairs>' matches multiple views in the hierarchy.
There's a chance this could be only on my local branch as I'm in the middle of some changes. Need to verify.

Verified. This is a legitimate bug. Thanks to @shobhitagarwal1612.


omekasy: init at 1.2.3

Description of changes
Small command line tool that can convert between unicode "font styles" (not sure what the correct Unicode lingo is): 𝐚 𝑎 𝒂 𝖺 𝗮 𝘢 𝙖 𝒶 𝓪 𝔞 𝖆 𝚊 𝕒 🇦
$ omekasy --font italic-sans NixOS
𝘕𝘪𝘹𝘖𝘚

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build omekasy


[feature] Transfer-List component added

Fixes Issue🛠 :333
Description👨💻
The transfer list component  is created and added in the Transfer Lists folder
Type of change📄

[*] New feature (non-breaking change which adds functionality)

How this has been tested✅

Checklist✅

[*] My code follows the style guidelines of this project
[*] I have performed a self-review of my own code
[*] I have commented my code, particularly in hard-to-understand areas
[*] I have added demonstration in the form of GIF/video file
[*] I am an Open Source Contributor

Screenshots/GIF📷

@Rakesh9100 let me know for further

Good, Merged!! Congrats on getting your PR merged to this repo under SWOC S4 🎉🎉 @EAGLEARCHER


Missing migration for refresh_tokens plural related_name

The following commit changed the related_name of RefreshToken.user but the accompanying migration file is missing
https://github.com/flavors/django-graphql-jwt/commit/6f38e892d2820f99b5dd5374376970eae82abb00
So when using version 0.2.1 Django complains there are pending changes to the model

Thanks @mobiware and I'm sorry for the delay in my response.
Fixed!


lightbox: Fix text overflow of translated user interface.

Fixes #7469.

Awesome, thanks for fixing this @synicalsyntax!


Kill bluetooth LE scanning gracefully when asked to shut down.

Description:
When systemd (or anything else) asks hass to stop, it can now also ask pygatt to stop gracefully with SIGINT, avoiding leaving orphan processes and the bluetooth adapter in a bad state. The new version of pygatt also includes many other fixes.
Related issue (if applicable): fixes #19760, #19592, #17118; may relate to #16698
Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

The only BT tracker component that works without problems for me on RPi3 is https://github.com/kevjs1982/hass-components/blob/master/custom_components/device_tracker/bluetooth_le_tracker.py


drivers: rtc: mc146818: fix y2k bug

That's correct. We are still fixing the Y2K bug in 2023 \o/

write century to RAM register 0x32
ensure year register is in [0,99] (inclusive)

Aside from that, there were a few other errors in the driver.

translate epoch-centric RTC API year to begin at 1900
fix off-by-one error with month limit
fix off-by-one error with wday
fix off-by-one-hundred error with year limit
adjust timeptr values in rtc_mc146818_validate_time()
adjust timeptr values in rtc_mc146818_validate_alarm()

With the above, the testsuite passes!
Fixes #59387
west build -p auto -b qemu_x86_64 -t run tests/drivers/rtc/rtc_api
...
*** Booting Zephyr OS build v3.4.0-167-g327eb119b6bc ***
Running TESTSUITE rtc_api
===================================================================
START - test_set_get_time
 PASS - test_set_get_time in 0.002 seconds
===================================================================
START - test_time_counting
 PASS - test_time_counting in 10.197 seconds
===================================================================
TESTSUITE rtc_api succeeded

------ TESTSUITE SUMMARY START ------

SUITE PASS - 100.00% [rtc_api]: pass = 2, fail = 0, skip = 0, total = 2 duration = 10.199 seconds
 - PASS - [rtc_api.test_set_get_time] duration = 0.002 seconds
 - PASS - [rtc_api.test_time_counting] duration = 10.197 seconds

------ TESTSUITE SUMMARY END ------

===================================================================
PROJECT EXECUTION SUCCESSFUL

One  additional modification

adjust timeptr values in rtc_mc146818_validate_alarm()

I haven't yet tested rolling over from 1999 to 2000 - should we?? What if something terrible were to happen?? 😬

Nice work!
If you want to test rolling over from 1999 to 2000, change this define to 946684795UL and rebuild the test suite :)

Let me add a y2k testcase. Any others we should add currently? 2038?

We can add 1999 to 2000 to the test suite, but that should probably go into its own its own PR :)

We can add 1999 to 2000 to the test suite, but that should probably go into its own its own PR :)

It's practically done already - I might as well add it here. Plus The Zephyr Way is to add tests along with bugfixes, when possible.

2038 is not relevant since RTCs don't track time using integers, that would have to be part of some counter test suite to be relevant i think :)

True, yea.

Hmm... should have put a DNM on this.


As a CIF administrator, I want to define the list or RFP calls for a given funding streams, so that I can start a new RFP call

Description:
As a CIF administrator, I want to define the list or RFP calls for a given funding streams, so that I can start a new RFP call

This card only describes the add functionality (not the edit or delete)
UI design can be kept simple and revised later: Funding stream dropdown on the top, and a list with a header underneath (we can reuse the table styles we have). The input / submit button can be below all that and generated by rjsf.

Acceptance Criteria:
Given that I am a CIF administrator
When I see the dashboard
Then I can see a card called Administration containing a link called "RFP Calls"
And that link points to the RFP call list page.
Given that I am a CIF administrator
When I am looking at the RFP call list view
Then I can select a funding stream from a dropdown
Given that I am a CIF administrator
When I want to associate a new RFP call to a funding stream
Then I can add an RFP call by entering the name into an input field and hit submit
Given that I am a CIF administrator
When I enter a new RFP call name for an existing funding stream
And I hit 'Submit'
Then the list is updated with the freshly entered call name.
Development Checklist:

[ ] create rfp_call table with reference to funding stream
[ ] create RFP call list view
[ ] the view has a dropdown of all funding streams
[ ] the view has a list showing all RFP Calls associated with the currently selected funding stream
[ ] the view has an input field and a submit button that adds a new RFP call record to the rfp_call table with an association to the selected funding stream
[ ] the view has a 'Manage RFP Calls' title
[ ] Meets the DOD

Notes:

Personas:

Program Development Team
Operations Team

Hey team! Please add your planning poker estimate with ZenHub @BCerki @dleard @gurjmatharu @matthieu-foucault @mikevespi


Upgrade ego to v1.2

Our go-support-preview branch uses currently the ego v1.0 compiler to build the FPC chaincode for SGX.
This issue is about upgrading ego to the most recent version.

I will take this task :)

ego v1.3 has been released https://github.com/edgelesssys/ego/releases/tag/v1.3.0

instead of upgrading to v1.2 we upgrade to v1.3


VoicingManager.announc() has no guard on initialized

While working on https://github.com/phetsims/utterance-queue/issues/14#issuecomment-893094034.
I see that this could fire even when not initialized. @jessegreenberg is that as intended, or should we have a guard?
https://github.com/phetsims/scenery/blob/6a74364bde3c7953e019ef805bd89f372d2fa24b/js/accessibility/voicing/voicingManager.js#L199-L222

The guard is made in speak so it isn't really necessary now but maybe it will cover things in the future if announce gets more complicated. I don't think there is nay harm in adding it and it will save us an unecessary merge.

Done in the above commit, I tested a few usages to make sure it was OK. Feel free to reopen if you wish @zepumph


SECOAUTH-175: Introduced OAuth2AuthenticationFailureHandler

Updates for https://jira.springsource.org/browse/SECOAUTH-175

Patch applied thanks.


Refactor SCSS to use CSS variables

This pull request organizes and cleans up the scss files in preparation for css variable based theming (as proposed in https://github.com/silverbulletmd/silverbullet/discussions/58 and https://github.com/silverbulletmd/silverbullet/issues/127)
At the moment i just refactored the existing theme to use css variables and am quite sure not everything has a variable yet.
Also the customStyles should need less !important markers, as i moved the style tag below the main.css.
My idea going forward is the following:

create a css variable for almost everything. Make it quite verbose, so you can color your editor to look lika a rainbow if you wanted to.
Create a basic palette of colors which are assigned to all these verbose variables, but summarize common colors (like all subtle colors will use the --subtle-color var).

This should allow for fast creation of basic themes, but still leaves room for deep customization if desired. Also the verbose variables can change more frequently while basic themes may not break as fast if the variables names are chosen somewhat smart. If someone has any idea on what this basic theme should include (or if this is a good idea at all), please let me know.

Thank you so much for taking initiative on this. Do you consider this ready to go? I probably have to do some testing to see if there's no visual regressions, it's hard to judge from the massive diff. Any risky areas/changes I should pay attention to?

The current changes should be ready to go as a refactor of the existing themes. I tried to change as little as possible in the light theme apart from merging really similar colors like rgb(72, 72, 72) and rgb(74, 74, 74) into the same color. I included my dark mode fixes from my comment on https://github.com/silverbulletmd/silverbullet/issues/127.
Things that we should talk about before we can really call this a theming system are:

I only considered color in this PR, do we want to allow other things as well? Like font style and border style/width for example.
Variable naming. I mostly just went for the first thing that came to mind while naming everything. Maybe the scoping (--editor-xyz vs --ui-xyz) needs more thought?

But this can be implemented in a later PR in my opinion.
Considering Testing:
Most of the changes are just dividing the css into a color.scss which colors things, and the editor.scss which does all other stuff like paddings and layout. I tried to remove all !important rules I could find and merged a few selectors I deemed redundant. That mostly applies to modals and the autocomplete dropdown, but as these are fairly obvious if broken I dont think there are any risky areas i did not check.
I tested everything with the website space included in the repo and mostly looked at the SilverBullet and Directive/Query Pages. There I added basic things like blockquotes and admonitions.
Two selectors i didnt check as i could not figure out how to create a state where they would appear: .sb-line-comment and .sb-fenced-code-hide.

Ok, played a bit with this. I can see no regressions. Awesome work. Merging this!


Audi e-tron 55 Integration Issue

Integration Version: v1.10.4
Home Assistant Version: v2024.12.3
Issue:
The Audi e-tron 55 integration successfully initializes after an integration restart, but no data is retrieved from the API.
Observations:
•	Audi’s official app is functioning correctly and retrieves data without issues.
•	The problem persists despite multiple restarts of Home Assistant.
Steps Taken:
1.	Verified credentials used in the integration.
2.	Confirmed that the Audi app continues to receive data, ruling out account-related issues.
Expected Behavior:
The integration should fetch and display data from the Audi API after initialization.
Ask:
Assistance in diagnosing and resolving this issue to ensure the integration works as expected.

Integration Version: v1.10.4
Home Assistant Version: v2024.12.3
Issue: same issue and observations as described above. Waiting for a solution. Integration was working before update
ing HA.


Drunken Python

Before jumping into Pr first comment for assign.All Problem from Edabit. Link is mandatory to add
Problem statement:Python got drunk and the built-in functions str() and int() are acting odd:
Problem Link:https://edabit.com/challenge/pfn6QRn6eiTHEPpSs

Before submitting a PR please Check some details.Check Edabit for problem task

[ ] fileName formet should be in camelcase
example- returnTheNextNumber.py
[ ]  Add label for Problem
[ ]  In file there should be problem statement and link to probelm
example -

'''
    Probem Task : This program will add two numbers
    Problem Link : https://edabit.com/challenge/SFzHtm63XT6EYNHWY
'''
*/
def main():
    return a + b

This repository is vaild for HacktoberFest2020
Read before making PR - How to contribute on Github
Good Luck,

Please Please Please assign me this task please

Could you assing this issue to me please?

could I contribute here, I will give it a try.

#3 Already completed


TST: remove pypy

It takes ~5x longer to run, and burns up minutes that we could use for better purposes.
I considered adding macOS, but at a 10x premium, that means we have 200 minutes of tests per month.  And that's just macOS, and not including the other 3 platforms.

Codecov Report
Base: 83.54% // Head: 83.54% // No change to project coverage :thumbsup:

Coverage data is based on head (911feef) compared to base (912be47).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage   83.54%   83.54%
=======================================
  Files          21       21
  Lines        1361     1361
  Branches      274      274
=======================================
  Hits         1137     1137
  Misses        175      175
  Partials       49       49

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.