Stack was not created: DockerReadyWaitCondition

Hi!
Spotty sounds like an excellent idea and I'm eager to try it out. I'm following this article step-by-step.
At the first step of model training, I'm running into an error after running spotty start (for the extended log, see bottom):
Stack "spotty-instance-tacotron-i1" was not created.
Please, see CloudFormation logs for the details.

CloudFormation is showing:
CREATE_FAILED | The following resource(s) failed to create: [DockerReadyWaitCondition].
Received FAILURE signal with UniqueId i-0a62be66c83b8b65d

I can run spotty run ssh, but this shows a tmux session with the message Pane is dead. I can close the window using ctrl-b x and execute commands from there. However, running spotty run <script> or spotty run -r <scripts> gives me the same dead tmux session and the script is not being executed. If possible, I'd like to run Spotty commands from my local machine as advertised. What's going on here and how can I solve it?
Thanks!
$ spotty start
Instance is already running. Are you sure you want to restart it?
Type "y" to confirm: y
Terminating the instance...
fskkSyncing the project with S3 bucket...
Preparing CloudFormation template...
  - volume "tacotron-i1-workspace" (vol-xxxx) will be attached
  - volume "tacotron-i1-docker" (vol-yyyy) will be attached
  - availability zone: eu-west-1c
  - maximum Spot Instance price: on-demand
  - AMI: "Deep Learning Base AMI (Ubuntu) Version 19.1" (ami-06c961cd3240cfd7c)
  - Docker data will be stored on the "docker" volume

Volumes:
+-----------+---------------+------------+-----------------+
| Name      | Container Dir | Type       | Deletion Policy |
+===========+===============+============+=================+
| workspace | /workspace    | EBS volume | Retain Volume   |
+-----------+---------------+------------+-----------------+
| docker    | -             | EBS volume | Retain Volume   |
+-----------+---------------+------------+-----------------+

Waiting for the stack to be deleted...
Waiting for the stack to be created...
  - launching the instance...
  - waiting for the Docker container to be ready...
Error:
------
Stack "spotty-instance-tacotron-i1" was not created.
Please, see CloudFormation logs for the details.

Hi @benjaminvdb,
For some reason, your container failed to start. Please, check the logs on the running instance: see the "The instance is failed to start. Where can I find the logs? question in FAQ.

@apls777 Thank you for the incredibly fast reply!
 I copied the requirements.txt file to docker without renaming to requirements-spotty.txt... Everything is working fine now! Thanks for your help.
Would it be possible to show logs from the Docker container on the local machine easily? The Heroku CLI has real-time tailing with heroku logs --tail, which is incredibly useful. This idea could work for Spotty as well using a similar approach (display a log file within a container using the tail command).

There already was a similar feature request (#52), but maybe it's a better idea of how to pull the logs. Thanks!
Glad it's working for you now, I'm then closing the issue.


Query params truncated

If I send multiple params in my query string, only the first one appears in event.queryStringParameters.
Example Curl:
curl http://<IP_ADDRESS>:3000/client_reports/search_activity/USA_142687?start_date=2018-01-01&end_date=2018-01-05

The event sent to my lambda:
{
   "httpMethod":"GET",
   "body":"",
   "resource":"/client_reports/search_activity/USA_142687",
   "requestContext":{
      "resourcePath":"/client_reports/search_activity/USA_142687",
      "httpMethod":"GET",
      "stage":"prod",
      "identity":{
         "sourceIp":"<IP_ADDRESS>:57470"
      }
   },
   "queryStringParameters":{
      "start_date":"2018-01-01"
   },
   "headers":{
      "Accept":"*/*",
      "User-Agent":"curl/7.54.0"
   },
   "pathParameters":{
      "gmaid":"USA_142687",
      "report":"search_activity"
   },
   "stageVariables":null,
   "path":"/client_reports/search_activity/USA_142687"
}

Note this:
 "queryStringParameters":{
      "start_date":"2018-01-01"
   },

is missing the second param in the query string.
Note also that on a real API Gateway on AWS, the query string is correct:
    "queryStringParameters": {
        "end_date": "2018-01-05",
        "start_date": "2018-01-01"
    },

This is fixed as of release 0.3.0. Closing


Issues with Rails built-in cache counter

belongs_to :order, :counter_cache => :contributors_count
contributors_count is null in the response, but 1 in the model
Next request. It's 1 in the response and 2 in the model.
I've resorted to callbacks for this for now. But really like this out of the box.
Basically the attribute isn't set when the response is sent.

Hey :)
I am able to reproduce you problem, but this is not a problem of acts_as_api but of the Rails counter_cache implementation.
The same behaviour appears when you use the common rendering methods of Rails:
class ItemsController < ApplicationController

  def create
    @user = User.find(params[:user_id])
    @item = @user.items.build(params[:item])

    respond_to do |format|
      if @item.save
        format.xml  { render :xml => @user, :status => :created }
      else
        format.xml  { render :xml => @item.errors, :status => :unprocessable_entity }
      end
    end
  end

end

I think the problem is that @item.save will modify the user model in the after_create callback but ActiveRecord won't know its instances of the user are dirty now (@user.changed? returns false). If you reload the @user instance in the case above, it will show the correct count.


能否也提供一个Gradle的build脚本

欢迎贡献一个gradle example ：）

We had added in these samples:
https://github.com/apache/incubator-servicecomb-java-chassis/tree/master/samples/bmi
https://github.com/apache/incubator-servicecomb-java-chassis/tree/master/samples/codefirst-sample


Support a config field for adding/updating link to build-triggering commit

This PR adds support for a configuration field that'll cause the screwdrivercd_version utility to add/update the link to the current build's associated commit using said commit's SHA hash in the package's metadata.
Description
Defined a new field named link_to_commit and leveraged existing functions to read the value of the field from the config file. Generated the link to the associated commit using Screwdriver's environment variables, SCM_URL and SD_BUILD_SHA.
Related Issue

https://github.com/yahoo/python-screwdrivercd/issues/43
Motivation and Context

This adds the link to the associated commit to the metadata for every new package version for improved tracking and visibility.
How Has This Been Tested?

Unit tests have been added to tests/test_versioners.py.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.

License
I confirm that this contribution is made under a Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@dwighthubbard, let me know if this is what you had in mind.


negative HPWL

The following design crashes replace (I just copied it in place of the gcd demo; I know that some other tool is going to choke on the missing clk signal later in the toolchain, but replace seems to have another problem):
module gcd(
input[3:0] encoded,
output reg[6:0] decoded
);
always @(*) begin
case (encoded)
4'd0: decoded <= 7'b1110111;
4'd1: decoded <= 7'b0100100;
4'd2: decoded <= 7'b1011101;
4'd3: decoded <= 7'b1101101;
4'd4: decoded <= 7'b0101110;
4'd5: decoded <= 7'b1101011;
4'd6: decoded <= 7'b1111011;
4'd7: decoded <= 7'b0100101;
4'd8: decoded <= 7'b1111111;
4'd9: decoded <= 7'b1101111;
4'd10: decoded <= 7'b0111111;
4'd11: decoded <= 7'b1111010;
4'd12: decoded <= 7'b1010011;
4'd13: decoded <= 7'b1111100;
4'd14: decoded <= 7'b1011011;
4'd15: decoded <= 7'b0011011;
default: decoded <= 0;
endcase
end
endmodule
At some point, this outputs:
[INFO] Nesterov: 10 OverFlow: 0.5945 ScaledHpwl: 5583.1606
... (repeated many times, but the OverFlow and ScaledHpwl values don't change)
[INFO] Nesterov: 2100 OverFlow: 0.5945 ScaledHpwl: 5583.1606
[INFO] Timing: WNS = 1e+30
[INFO] Timing: TNS = 0
[INFO] Nesterov: 2110 OverFlow: 0.4528 ScaledHpwl: -40109.2656
... (repeated many times, but the OverFlow and ScaledHpwl values don't change)
[INFO] Nesterov: 2500 OverFlow: 0.4528 ScaledHpwl: -40109.2656
[INFO] Timing: WNS = 1e+30
[INFO] Timing: TNS = 0
NEGATIVE HPWL ERROR! 00 72.0000 587.4428
NEGATIVE HPWL ERROR! 00 79.2643 592.2643
NEGATIVE HPWL ERROR!
00-80.1800 -79.8000
I have seen a commit that mentions the "negative HPWL" error, but the commit is stuck in the alpha2.1 branch. Is that commit relevant to the error I'm getting, and is the commit planned to be merged at some point in the future?

That's a divergence problem in the previous RePlAce. Usually, very small designs like gcd are not converged well. The RePlAce engine recommends having at least 1K instances to place cells. I think you could tune the "-bin_grid_count" as higher(64, 128), or tune the -init_density_penalty(or -init_lambda_coeff in previous replace) parameter as higher(0.01, 0.1).

Thanks for your quick reply. I suspected this to be a problem with small designs, but then couldn't reproduce that reliably. I'll try something larger for experiments instead.

"-bin_grid_count 64" did the job. Thanks again!


Added CMake changes to support ROCm

Added changes to CMake to work on ROCm
Added AMD copyright.

This looks good - do you mind also setting up a Travis CI target?

MIOpen is not released yet, once it gets released, I'll change Travis build files to get required rocm packages.

Got it, thanks - importing.

@adityaatluri - I sent an email follow-up about the CLA logistics, could you ping me again when it is figured out?

Sure.

Thank you for your contribution! PyTorch and Caffe2 are now officially merged with the PyTorch 1.0 preview release. Please submit on https://github.com/pytorch/pytorch if this is still an issue over there.


we need option to choose different versions of lyrics/sites to get lyrics from, or/and compatibility with plugins like "japanese romaji lyrics"

I love listening to vocaloid songs, but im not very good at japanese so i love to sing along reading romaji version of lyrics, which is sometimes might be present on genius.com, but sometimes its on fandom wiki or something like that, plus some songs might not have their lyrics on genius

Will look into this. give me time.


todo.yml:12: Add Github integration for lazylead with the...

The puzzle DEV-b03280fb from #DEV has to be resolved:
https://github.com/dgroup/lazylead/blob/37c35874b93f82ac20f4c96ec8add5bd15f9c593/todo.yml#L12-L12
The puzzle was created by Yurii Dubinka on 06-Jun-20.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle DEV-b03280fb has disappeared from the source code, that's why I closed this issue.


Path based branch name fix seperator

I looks like using # as a separator between the repo name and the branch name was a bad idea. In bash, the # sign is considered as the beginning of a line comment. So, I it is better to use : (colon) as a separator.

I don't think this requires changing the delimiter, You can use quotation marks to solve this problem.
$ caz "nm#typescript" demo


Update repository files endpoint for APIv4

New path for all endpoints is repository/files/:file_path (instead of passing file_path as a parameter)

That should do it! :)

Thanks! 👍


Update config to new parameters

Support for upcoming 0.9.9 config, https://community.bistudio.com/wiki/Arma_Reforger:Server_Hosting

This should now be released, https://reforger.armaplatform.com/news/update-july-20

Why wasn't this merged yet?


[WIP] use woom colors

custom colors to theme it around our brand

my bad. clicked around the wrong button 🤦🏽♂


is Split-Collection.ps1 necessary anymore?

This is similar to the previous question:
No references are made to this function anymore and if it's necessary, it should be migrated to the new naming convention.
If it is not, we should remove it. It may have a key function but no longer needed?

The answer is yes, it's still required per @favvojohan


CCDB GE/029 - Section 2.5.3

Comment:
In the SFR FPT_PHP.3 you claim resistance against abnormal Voltage. Abnormal Voltage should be clearly specified in the Supporting document. E.g. Voltage Glitches can be also considered as abnormal Voltage. The equipment is not sophisticated and a proficient is capable to use such an equipment.
Proposal:
Clarify what is expected to be tested.
Priority: 1

Look at splitting Test 2 into a separate set of tests, one for temperature and one for power/voltage, then add more details to the power/voltage test.
Before adding more tests though, evaluate the AP for adding it based on the overall AP for the cPP.
v1.1


ENH: Translate complex valued hyp2f1 to C++ and make improvements

Reference issue

Closes #8083
What does this implement/fix?

This PR translates hyp2f1 into CUDA compatible C++, including both the parts from written in Cython in hyp2f1.pxd and the parts written in Fortran in specfun.f. Improvements have been made by

Choosing better domains for using the different linear transformations as suggested by @FormerPhysicist in #8151 (though I've not used the same domains he used).
Using tolerance EPS = 1e-15 throughout and increasing the maximum number of iterations. (Zhang and Jin used a lower tolerance of EPS = 1e-8 for cases their implementation could not handle well. The improvements made here make this unnecessary.
Fix the case where a - b is an integer and the smaller of c - a or c - b is a positive integer. A different limiting formula is needed in this case due to a singularity in a digamma function appearing in the terms of a series.

Additional information

Here is a table comparing percentiles for relative error in this PR and main over 3,003,855 test cases generated by the script https://github.com/scipy/scipy/blob/main/scipy/special/_precompute/hyp2f1_data.py, using default arguments, with the exception that parameter group 9 is excluded, and excluding cases where the true result is $\infty$ which both main and this PR branch get right in all cases. These tests were run with gcc 11.4 on Linux.
The improvement is substantial, although note that there are still some cases where the new implementation fails. Fixing these cases will require implementing argument reduction of a, b, and c using Miller's Recurrence Algorithm.

-
30%
40%
50%
60%
70%
80%
90%
max

main
1.06e-15
3.70e-15
9.02e-13
8.02e-11
8.69e-10
5.20e-09
3.99e-08
inf

PR
5.25e-16
8.06e-16
1.27e-15
2.25e-15
5.19e-15
2.73e-14
2.81e-12
2.02+44

Here's a breakdown of the highest percentiles.

-
91%
92%
93%
94%
95%
96%
97%
98%
99%

main
5.94e-08
9.49e-08
1.72e-07
3.66e-07
9.61e-07
3.74e-06
3.27e-05
0.0016
15.74

PR
6.75e-12
1.83e-11
5.77e-11
2.23e-10
1.16e-09
9.40e-09
1.85e-07
2.47e-05
0.22

Update: I've rounded to two significant figures and cut out some of the percentiles in order to get the tables to fit properly. The results for the 10th and 20th percentiles are comparable between main and this PR. (slightly better for this PR).
The example hyp2f1(1, 1, 4, 3 + 4j) from https://github.com/scipy/scipy/issues/1561 is now computed accurately.
from mpmath import mp
from scipy.special import hyp2f1

hyp2f1(1, 1, 4, 3 + 4j)
# (0.49234384000963594+0.6051340616612398j)

mp.hyp2f1(1, 1, 4, 3 + 4j)
# mpc(real='0.49234384000963544', imag='0.60513406166123973')

and has been added to the tests. This case was broken in Zhang and Jin because they did not account for the need to use a a different limiting formula in the case where both a - b is an integer and the smaller of c - a and c - b is a positive integer. The need for this was noted by @gertingold in https://github.com/scipy/scipy/issues/1561. I don't think this this is enough to close that issue, since other inaccuracies are mentioned there. Closing that will have to wait until argument reduction is implemented.
I have implemented series evaluators in scipy/special/special/tools.h which are used in this implementation. These evaluators take generators for the terms of a series as input, and using them has streamlined the implementation. I've confirmed that everything I've done here works on CuPy.
I'm pretty confident in the mathematical correctness due to the large set of test cases in https://github.com/scipy/scipy/blob/main/scipy/special/_precompute/hyp2f1_data.py, and the extreme care I've taken.
cc @izaid

Huh, those tables looked nice in the preview, but are unreadable in the actual post.

closing the 4th oldest issue - not bad 😉

Things are finally coming together 😃

The failing test case is new to this PR and just needs a tolerance bump. It’s not a regression.

I've also translated the real valued hyp2f1 from cephes into C++, which I can either add here, or do in a follow-up. I think that will need to go in before we can add hyp2f1 to CuPy.
https://github.com/steppi/scipy/blob/hyp2f1_cephes/scipy/special/special/cephes/hyp2f1.h

@izaid, I think I've addressed everything. Thanks for the suggestions!

Thanks @steppi! Looks good to me.

Thanks @steppi! Looks good to me.

Thanks @izaid!

Thanks @rlucas7. Good catch. I'll update the comments.

@steppi it looks like there's one failing test. To me it seems unrelated, something to do with array_api compatibility. Can you confirm that's unrelated? If so I can merge. I'm not super familiar with the tests in that module though:
https://github.com/scipy/scipy/actions/runs/8616963915/job/23615829427?pr=20089#step:3:2989

@rlucas7. It’s unrelated. It’s failing everywhere.

@rlucas7. It’s unrelated. It’s failing everywhere.

Ah yeah I see one now over here in an unrelated PR with a much smaller change surface.
https://github.com/scipy/scipy/actions/runs/8623028347/job/23636209805?pr=20432#step:3:2986
I'll cancel the job and merge this PR. No sense wasting the resources to let the job run when we expect it to fail.

@steppi merged. Keep them coming

Awesome! Thanks @rlucas7!

A small comment about series_eval for @steppi : instead of accepting a Generator,  have you considered accepting an Iterator? I come across this when writing the continued fraction evaluator for iv_ratio.
Both Generator and Iterator will do the job, but Iterator has some benefits:

Runs faster if the first term of the series is computed differently from the rest (though a strong enough compiler might unroll the first Generate call to achieve the same effect).
Offers the possibility to visit the series in backward or random order (if needed).
More flexible; e.g. readily works with a plain array of input.
More C++ style and works more smoothly with the rest C++ infrastructure.

For the caller, making an Iterator requires about two more lines of code than making a Generator.
I’ll make a PR for iv_ratio with an example of an Iterator-based continued fraction evaluator as a proof of concept.

Thanks for the suggestions @fancidev.

A small comment about series_eval for @steppi : instead of accepting a Generator, have you considered accepting an Iterator? I come across this when writing the continued fraction evaluator for iv_ratio.

That means iterating over a chunk of memory right? I wrote some like that in early drafts, but since we want these functions to be usable as CUDA kernels, we want to avoid memory allocations. Generating the terms in a lazy way when possible is helpful for this. We're actually hoping to be able to cut down on existing memory allocations in specfun for this reason.

Runs faster if the first term of the series is computed differently from the rest (though a strong enough compiler might unroll the first Generate call to achieve the same effect).

I've written these so that the first term is an argument of the series evaluator, not something that comes out the generator.

Offers the possibility to visit the series in backward or random order (if needed).

Funnily enough, the next thing I'm planning to do for hyp2f1 is write a series evaluator which sums the terms forwards until convergence, and then re-sums them backwards from smallest to largest. This approach was suggested to me by Cephes author Stephen Moshier. I'm doing this by accepting generators which allow moving forwards and backwards. I want to try something like this for continued fractions too, using forward evaluation to assess the number of iterations needed, and then re-evaluating with more numerically stable backwards evaluation.

I’ll make a PR for iv_ratio with an example of an Iterator-based continued fraction evaluator as a proof of concept.

I'd be happy to see the PR. Also, I've been planning to follow up on your work with iv_ratio and have just been a bit delayed due to feeling sick over the past week.

Thanks for the quick response @steppi .
The Iterator way is also “lazy”, and no memory allocation is incurred. Basically, instead of calling g() to get the current element and (implicitly) advance to the next item, call *g to get the current item and ++g to advance to the next item.
By the “first term” I mean (a[1], b[1]). While it’s possible to manually “unroll” the continued fraction so that (a[2], b[2]) becomes the “first term”, it alters the convergence condition (based on relative tolerance) and therefore may complicate things.
The forward-backward approach is a good idea! For the Iterator way, it’s as simple as calling --g.
I’ll make the iv_ratio (draft) PR tomorrow!

@fancidev. Ah, I see what you mean. That does sound like a good idea. Thanks.

I come across this line; wonder if it’s a typo? The comment wants u > v, but that lines makes u < v.

Actually I mean the code appears to have a typo. Because u, v, w, x are passed to four_gamma_lanczos; but in that function it is expected that u > v and w > x, and makes this assumption to do some scaling (so to speak).

Ah, you're absolutely right. I didn't check carefully just now.
Somehow I'd flipped the sign when translating to C++, and I think any loss of accuracy due to this went unnoticed because there were many other changes which improved accuracy.
https://github.com/scipy/scipy/blob/f133c27843a36c8fe1c2979b3a072ac4f5a00624/scipy/special/_hyp2f1.pxd#L322-L326
Do you want to submit a PR with the fix?


Kapacitor only loading first TICKScript in Load directory

I'm trying to use the Load Directory feature with the Kapacitor Helm Chart sideload functionality.
I have several .tick files in the tasks folder but Kapacitor only picks up the first file it finds and skips the rest. I have tried renaming the files and they are ordered and processed alphabetically, which is expected. There are no errors in the logs.
Helm values.yaml:
kapacitor:
  influxURL: 'http://influxdb:8086'
  sidecar:
    sideload:
      enabled: true
      label: kapacitor_sideload
      folder: /var/lib/kapacitor/sideload/tasks
  envVars:
    KAPACITOR_LOAD_ENABLED: true
    KAPACITOR_LOAD_DIR: /var/lib/kapacitor/sideload

Kapacitor container logs:
ts=2020-12-14T10:37:10.414Z lvl=debug msg=“loading templates” service=load
ts=2020-12-14T10:37:10.414Z lvl=debug msg=“loading tasks” service=load
ts=2020-12-14T10:37:10.414Z lvl=debug msg=“loading object from file” service=load object=task file=/var/lib/kapacitor/sideload/tasks/a_prod_error_count.tick
ts=2020-12-14T10:37:10.420Z lvl=info msg=“Starting target manager…” service=scraper
ts=2020-12-14T10:37:10.457Z lvl=debug msg=“starting task” service=kapacitor task_master=main task=a_prod_error_count
ts=2020-12-14T10:37:10.457Z lvl=info msg=“started task” service=kapacitor task_master=main task=a_prod_error_count
ts=2020-12-14T10:37:10.457Z lvl=debug msg=“listing dot” service=kapacitor task_master=main dot=“digraph a_prod_error_count {\nstream0 -> from1;\nfrom1 -> window2;\nwindow2 -> sum3;\nsum3 -> alert4;\n}”
ts=2020-12-14T10:37:10.479Z lvl=debug msg=“loading handlers” service=load

The script a_prod_error_count.tick is processed and I would expect to see logs for the other other scripts. Using the CLI kapacitor list tasks only shows the one task processed above.
I have created Kapacitor Tasks using the same .tick scripts via the CLI without problem, so the issue appears to be with the Load Directory functionality.

Kapacitor version 1.5.7-alpine
Sidecar version kiwigrid/k8s-sidecar:0.1.116
Helm Chart version influxdata/kapacitor:1.3.1
k8s version v1.18.9-eks

@philbo can you show me the kapacitor conf?

/ # cat /etc/kapacitor/kapacitor.conf
data_dir = "/var/lib/kapacitor"

[replay]
  dir = "/var/lib/kapacitor/replay"

[storage]
  boltdb = "/var/lib/kapacitor/kapacitor.db"

any progress on this? i seem to be having the same issue

the interesting thing for my issue is that i see the logs saying its loading the tasks but nothing shows up on chronograf, until i go into my container and do a manual cli command, thats when it will work

any progress on this? i seem to be having the same issue

No progress. Had a look at the source code but couldn't spot anything obvious.


Subdomains is not being identified correctly

For example:
I'm using postman to simulate a subdomain: gap.tenancy.com.br
The subdomain returned is tenancy, where the correct subdomain should be gap.
I have edited my etc/hosts to something like this:
<IP_ADDRESS>       gap.tenancy.com.br
https://github.com/needle-innovision/nestjs-tenancy/blob/117280bb2ce508a0f1a4336715c78ffe093522ec/lib/tenancy-core.module.ts#L176

Hi @gapinto
Did you try setting the configuration isTenantFromSubdomain like below when you are using subdomain based tenant
TenancyModule.forRootAsync({
      imports: [TenantModule],
      useFactory: async (cfs: ConfigService, tVal: CustomTenantValidator) => {
        return {
          // To identify tenant information from the url
          isTenantFromSubdomain: true,
          options: () => {},
          uri: (tenantId: string) => `mongodb://localhost/test-tenant-${tenantId}`,
          // Custom validator to check if the tenant exist in common database
          validator: (tenantId: string) => tVal.setTenantId(tenantId),
        }
      },
      inject: [ConfigService, CustomTenantValidator],
    }),

@gapinto i have published a new version v1.0.9 with a small fix for multi-level subdomains. Please let me know if that fixes your issue.

@gapinto can you confirm if this is working for you so that i can close this issue pls?

Closing this issue as there was no followup. Hope the new version addresses the fix.


Issue with fluid tanks

Describe the Bug
When you put tea in a fluid tank and the game tries to render it, the "saving" dirt screen appears and it instantly crashes.

Additional Context
I think that sodium causes the issue.
Also the version of the mod is the latest build (506)

I can't reproduce this. Can you test on the latest build? Related code has been changed.

It still happens with the latest build

Try remove mods about entity/block entity rendering(ex. cem)

please test build #532

Yep build532 fixes the issue

Don't know if this is relevant enough to not warrant opening another issue, but running colormatic  + sodium iris + the latest create build makes custom liquid render invisible in tanks, and crashes the game when custom liquids move through a pipe or when you ponder on the liquid tank item.

@azridere same issue in my game

This has been tracked down to an issue with colormatic, which has been reported.


Feature request: ability to run by default in CWD

Would be awesome to be able to run this via command line with no destination url, but use the CWD package instead
does this make sense?

When you do gpm -i ., that will create the node_modules by reading the package.json file. I'm not sure what you mean: what is currently happening and what would you like to happen instead? :thought_balloon:


Files and folders are not at the same indent level

So this is the root level of my repository:

The .gitignore, circle.yml etc files are in the directory root, not inside the theme folder.
This gets really annoying when I open up folders:

Things just keep looking like they're in the wrong folder when they're not :(
Any idea what's causing this?
Thanks!

Yeah, sorry about this. It's because of previous versions of ST that don't support icons. You can immediately fix this by setting you theme to "theme": "predawn-DEV.sublime-theme", but I hope to merge those two versions in the near future.

Ahhh - that did the trick :) I hadn't realized I had a dev build of Sublime Text.
Thanks!


Update Trim Section

Intro
The slit does not always cover the whole detector and this can create problems in the processes that follow, that's why we have decided to do a trimming according to the slit coverage on the detector. I've been doing some tests and detecting such limits is an easy task, what might be a problem is that those values are not constant and in principle you might think that it will vary with the slit but that is not True.
In fact is not clear at all. The plot bellow shows all the flat files taken during a single night and their respective "slit profile". 200 columns where averaged using median starting in the middle towards the red part of the spectrum.

I don't quite understand the different plots. You will have to explain
this graph to us in the Friday meeting.
Cesar
On 4/26/17 6:45 PM, Simon Torres wrote:

Intro
The slit does not always cover the whole detector and this can create
problems in the processes that follow, that's why we have decided to
do a trimming according to the slit coverage on the detector. I've
been doing some tests and detecting such limits is an easy task, what
might be a problem is that those values are not constant and in
principle you might think that it will vary with the slit but that is
not True.
In fact is not clear at all. The plot bellow shows all the flat files
taken during a single night and their respective "slit profile". 200
columns where averaged using median starting in the middle towards the
red part of the spectrum.
slit_coverage
https://cloud.githubusercontent.com/assets/3878895/25458413/2cb4bb7c-2ab0-11e7-8e2d-bbe87897d916.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/soar-telescope/goodman/issues/57, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AWURSpOKIToruZIr7EeRvSFp0WdE7vNUks5rz7r6gaJpZM4NJdxq.

--

César Briceño                               *

AURA/CTIO                                   *
Observatorio Interamericano de Cerro Tololo *
Casilla 603                                 *
La Serena, Chile                            *
Email<EMAIL_ADDRESS>             *

<EMAIL_ADDRESS>             *

The simplest interpretation for the plot is that The slit-illuminated region is not fixed and does not depend on the grating and slit alone. So my solution was to implement the slit trimming section (commit 468463ccd82eac0b21ac46705a6c8945ee1cbb96) additional to the inital trimming. I left the initial trimming for completness. There are some cases when the slit trimming sections can't be found so for those cases the initial trimming should suffice.
I have tested it and so far it works fine.


[1.1x-0.0.9] Cascading Worldgen Issue

https://pastebin.com/mjjBQViZ
Seeing that in my client console. I'm using the preset that makes the entire world a city when I get this error, then the game locks up and becomes unresponsive.

I'll check it out

Should be fixed next release

It still comes up, but far less than before, and doesn't seem to scale out of control anymore. Running through different presets seems to confirm it's waaaaay better.


docs(aws-sam): reference related modules in README

Add references to reference documentation of related CDK modules.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Thanks for this change!


[Performance]:  The accept rate of typical acceptance sampling

Proposal to improve performance
No response
Report of performance regression
I tested the accept length ( number of tokens per step) withtypical acceptance sampling. The accept length is even smaller than default reject sampling method.
Here is my experimental details:

The dataset I used was mt_bench.
Speculative decoding model's setup:
llama3.1 8b as target model and Qwama-0.5B-Instruct as a draft model (num of speculative tokens is 2)
llama3.1 8b as target model with MLP-speculator.
3 Temperature was set as 0.9
4 posterior_threshold and posterior_alpha were set as default values.

Do you have some experimental results on this? Or do I need to tune some parameters for typical acceptance sampling? Thanks a lot!
Misc discussion on performance
No response
Your current environment (if you think it is necessary)
The output of `python collect_env.py`

Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

Hi, thanks for the question! I did some quick benchmark for typical acceptance:
Settings:
Model: lmsys/vicuna-7b-v1.3
Draft model: abhigoyal/vllm-medusa-vicuna-7b-v1.3
Hardware: 1xH100
Dataset: ShareGPT
vllm version: v0.6.1.post2
Request rate: 1 req/s
Sampling method: greedy decoding
Results

w/o SD
SD with rejection sampling
SD with typical acceptance before #8562
SD with typical acceptance after #8562

median TTFT (ms)
13.30
12.79
13.46
12.97

median TPOT (ms)
6.97
5.43
7.81
5.53

median End to end (s)
1.10
0.83
1.17
0.84

I also check the token acceptance rate for rejection sampling:
SD with rejection sampling: Draft acceptance rate: 0.287, System efficiency: 0.422
SD with typical acceptance before #8562: Draft acceptance rate: 0.283, System efficiency: 0.317
SD with typical acceptance after #8562:Draft acceptance rate: 0.293, System efficiency: 0.427
Notice in the results above, typical acceptance (after #8562) has similar performance to rejection sampling because we are doing greedy decoding.
Some comments here:

After merging this PR (https://github.com/vllm-project/vllm/pull/8562), the acceptance rate should be higher because we accept one more 'recover' token.
I check the default values of  posterior_threshold = 0.09 and posterior_alpha = 0.3, they are already small. You can further reduce the value to see if you can get any benefits, but that might affect the generation quality. I have not tested this thoroughly here, feel free to take a try and share the result here.


KAFKA-4630: Implement RecordTooLargeException when communicating with pre-KIP-74 brokers

Thanks for the review.  I have prepared a test for the RecordTooLargeException behavior in CompatibilityTest, but I have to get KAFKA-4548 merged first.  If this JIRA gets merged first, I will add the RecordTooLargeException in KAFKA-4548; otherwise, I will do it in a follow-on

I added a unit test inside FetcherTest.  There is also a ducktape test coming after the CompatibilityTest JIRA is merged.

Running the client system tests here: https://jenkins.confluent.io/job/system-test-kafka-branch-builder-2/

I fixed the merge conflicts and minor style issues and ran the system tests again:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder-2/184/console
They passed, so LGTM. Merged to trunk and 0.10.2 branches.


Correction for raw affiliation CIRAD, UMR Qualisud, F-498 Montpellier, France

Correction needed for raw affiliation CIRAD, UMR Qualisud, F-498 Montpellier, France
raw_affiliation_name: CIRAD, UMR Qualisud, F-498 Montpellier, France
new_rors: 05kpkpg04;01nfvkq89
previous_rors: 05kpkpg04
works_examples: W2914957998
contact: 1f36b7098d216fbb6cc5bcdebdc2429e:2dce79270e139d5fc9c2e987fbd5aa0e36 @ supagro.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


.vscode/extensions/TimonVS.ReactSnippetsStandard-1.1.0]: Unknown language in contributes.snippets.language. Provided value: jsx

I get this when I run my vscode. I don't think jsx is a language in vscode.

Do you always get this when you open VS Code? Or did you just get this error once?

please update marketplace version, I always got this error
thanks

I will publish a new version once I'm back from my holiday :)

@TimonVS still waiting for you to publish a new version.

@TimonVS I am taking your snippets and putting them into my standard.js snippets package. Waiting 2 months for a publish? Unacceptable.

@capaj I have actually not updated this plugin in a while because I have no need for it anymore. That's why I have decided to deprecate the plugin, please refer to the readme for a detailed description on how to migrate to alternatives (https://github.com/TimonVS/vscode-react-standard/blob/master/README.md).


UF-320: Adding counters for roles, groups and users on admin page

Added counters for roles, groups and users on admin page on kie-wb-webapp and kie-drools-wb-webapp.

+1

An interesting use of lamdas and anonymous inner classes :-) perhaps try to stay consistent either way ;-)

@manstis Good point :). I'll change it now.
@csadilek Thanks for the review. Please wait for my change before merging it. I'll change it on the Uberfire PR as well.

Changed.

Agreed, looks cleaner now ;).


feat: add dynamic scraper on docs

As title says.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.70%. Comparing base (a3c9eea) to head (83dc407).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   59.70%   59.70%
=======================================
  Files          21       21
  Lines         675      675
=======================================
  Hits          403      403
  Misses        272      272

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


search issue

A search for the Contains Operator in doc search doesn’t show the operator help page.
https://help.sumologic.com/docs/search/search-query-language/search-operators/contains/
Slack Message

Search does return the contains page, so closing this.


Doesn't work on Linux

Hello, Nick! Your framework is extremely great, thank you for that! But I have a problem on Astra Linux (Debian-based OS) even in your example.

I have the same problem in my application . Have you got any ideas how to fix it?

Do you use wayland or X11? I think it might have some problems on wayland. Anyways, I'll take a look, but it might take me a bit of time. Regards.

No, I don't use any of it. I just launched the demo project as it was. I figured out that problem is in "TransparencyLevelHint" which seems just doesn't work on that OS. Maybe instead of creating new windows, just toggle #PART_OverlayWindowHolder (grid) visibility?

I'll try to take a look on Sunday

I'll try to take a look on Sunday

Thanks!

Thanks

X11

cool, thx

I am using the transparent windows for displaying compass, and it seems that on Linux they are not positioned correctly. I asked the question to Avalonia platforms guru and hopefully, he'll be able to help. Will keep you informed.

The same here.
Kubuntu (Ubuntu + KDE) 22.10, X11
compiled using dotnet7

Hello! Any updates?

Not yet, sorry. But I am working on it whenever I can
On Saturday, September 9, 2023 at 10:42:52 AM EDT, Dmitry Romanov @.***> wrote:
Hello! Any updates?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

The new version of UniDock at NP.Ava.UniDock works on Linux - dragging out not 100% but otherwise works fine.


Cannot delete NetworkIdentity from my asset

I used to have a class inheriting from NetworkBehaviour and now I changed it and inherits from MonoBehaviour. The problem that I have now is that I cannot delete the NetworkIdentity component. when I try to do it, The following appears on mi console: "Creating missing NetworkIdentity component for Player in Player. UnityEditor.EditorApplication:Internal_CallUpdateFunctions ()"
Wherever I add this script component to a gameobject, a network identity is being created. What should I do in order to be able to use this script component without unity adding the NetworkIdentity?

What Mirror version are you using, what Unity version. Have you tried with different versions?

I used to have a class inheriting from NetworkBehaviour and now I changed it and inherits from MonoBehaviour. The problem that I have now is that I cannot delete the NetworkIdentity component. when I try to do it, The following appears on mi console: "Creating missing NetworkIdentity component for Player in Player. UnityEditor.EditorApplication:Internal_CallUpdateFunctions ()" Wherever I add this script component to a gameobject, a network identity is being created. What should I do in order to be able to use this script component without unity adding the NetworkIdentity?

What Mirror version are you using, what Unity version. Have you tried with different versions?

Closing as this was a Unity bug where it was picking up requirements from other scripts of the same name, especially those that were in Mirror's examples.  Name your script something else, or remove the examples.


Revert "FEATURE: MPNT-112 Temporary allow trigger CI pipeline manually"

Reverts gooddata/gooddata-public-demos#32

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/gooddata-public-demos/job/gooddata-public-demos-validation/72/ : SUCCESS in 7s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-oss-check/83/ : SUCCESS in 6s

LGTM

Sonar scan result

No issue found. Congratulations!

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-public-demos-gate-PR33
To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/gooddata-public-demos/job/gooddata-public-demos-validation/73/ : SUCCESS in 7s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-merge-compliance-check/32/ : SUCCESS in 19s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-sonarqube-scan-zuul-gate/30/ : SUCCESS in 35s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-fossa-scanning-zuul-el7/30/ : SUCCESS in 49s (non-voting)


Nn/spark 31620

Upstream SPARK-31620 ticket and PR link (if not applicable, explain)
https://github.com/apache/spark/pull/28496 for bug fix
https://github.com/apache/spark/pull/27368 for abstraction needed to apply bug fix
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.

@rshkv this is the change we talked about earlier this week

When cherry-picking, we're trying to rebase cherry-picks like this one. And have each commit resemble an upstream change as closely as possible. Makes it easy to reconstruct which upstream changes we have and which we don't.

Would you mind taking the full set of changes, even if apparently unrelated?
If there are merge conflicts, would you mind resolving them in the same commit?

On the failing tests: Tests are quite flaky so it's worth re-running once or twice (sorry about that). On quick glance the failures don't seem related but not sure.


Test Limelight

Make sure the limelight has a well-defined image of the shooter goal and isn't affected by the room lights.

We are having issues with accidentally targeting white walls, and reflections. Please fix this


Add the option to generate Xcode schemes

This commit adds the option to generate Xcode schemes. Prior, it was
enabled by default.

why opened then closed?


make dashboard display "Inactive" for Hardware crypto instead of empty string when not in use

[x] Redmine Issue: https://redmine.pfsense.org/issues/12714
[x] Ready for review

Very small patch that just makes the Dashboard display for Hardware crypto a bit friendlier (imo) when there are no actively loaded crypto modules. Instead of a blank row, it will show "Inactive" in line with other sections e.g. Kernel PTI etc.
without patch:

with patch:

Ditto on this one, any issues found?


Bag verifier should support big files. Really big files. Enormous files. >160GB files.

At some point, the storage service will start getting MXF files from the A/V workflows, and these are pretty big – the largest I've seen is 166GB, but others are likely bigger.
Trying to verify a file that large will be unreliable, and at some point may hit the limit of what you can do with a single GetObject request – we should switch to using the LargeReader that we use in the bag unpacker.

Or, better, we shunt that into the scala-storage and make it available for everyone!

One of the things that makes the bag unpacker slow is that it has to write every byte it reads back out to S3, potentially split over many PutObject calls if there are lots of small objects. The verifier just has to read and then immediately discard the bytes, so it might be more reliable.
This change would have a non-trivial impact on the number of GetObject calls we need to make, so let's hold fire on deploying it until we're sure we need it.

It seems to do this pretty well already! Closing until we know there's more to do.


updated setStatus not to rely on current state

see this for reference (even variables are the same)

awesome, thanks!


Update Gradle 5

Allow using Gradle properties as well as ENV variables

@thegreystone Do we really care about 9 or move it to 11 compat?
To make it easier in the IDE I wonder if the code should be in two subprojects?

It was in JDK 9 that the API changes we need to cater for were implemented. That said, I can't imagine anyone running JDK 9 or 10, so it probably wouldn't make much of a difference. Then again, it doesn't hurt to support them.
That said, I don't mind if testing only happens on one pre-JDK 9 (Oracle JDK) platform and OpenJDK 11.

To make it easier in the IDE I wonder if the code should be in two subprojects?

It's so tiny amounts of code though (especially in the opentracing-0.32.0 branch). Personally I don't mind leaving it as it is. At some point the world will all be on 11 (let's pray to his Noodliness that this will happen before retirement) and we can just move a few classes and drop JDK 7 and 8 compatibility. :)


Failed to copy artifacts from build-scripts/release/create_installer_windows

jdk11u-windows-x64-openj9-windowsXL
https://ci.adoptopenjdk.net/view/Failing Builds/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-windows-x64-openj9-windowsXL/371/console
Execution error: Failed to copy artifacts from build-scripts/release/create_installer_windows with filter: wix/ReleaseDir/OpenJDK*jdk_*_windows*.msi

FYI - @M-Davies

Dup of https://github.com/AdoptOpenJDK/openjdk-build/issues/1834


Be clear about non-colour opts given to bemenu

It would be nice to either not include -i -l 20 or be clear about what it does.
(Optional, since there is a --help option for bemenu-run that explains it well.)

Hi !,
Thanks for opening the issue !, discussing with the community about changing more things than the color palette when porting an app, we reach to the conclusion that we should stick to the colors when creating a theme for an application.
Following that, I have removed those parameters from the port.
Thanks a lot !

Hi !,
Thanks for opening the issue !, discussing with the community about changing more things than the color palette when porting an app, we reach to the conclusion that we should stick to the colors when creating a theme for an application.
Following that, I have removed those parameters from the port.
Thanks a lot !


Problems executing FOC MOTOR CONTROL APP

Hello! I have purchased the Kria KD240 Starter Kit with the Motor Accesory Pack and am trying to have the default application working but am having some problems.
I am following the steps mentioned in the README.md here very cautiously but when I get to the last step (executing the app) I get the message "start_motor_dashboard: command not found".
I have attached below the logs I am getting. I have also installed the latest boot firmware following the instructions mentioned here and had to install the CXX compiler using the command sudo apt-get update && sudo apt-get install build-essential.
Can someone help me find the problem so that I can get my kit working as soon as possible, please? Thank you!
LOGS:
putty_logs.log

Hello!
Thank you for reporting this. The issue is due to a known typo in the README regarding the installation path. Please update the path from /opt/xilinx/xlnx-app-kd240-foc-motor-ctr/bin to /opt/xilinx/xlnx-app-kd240-foc-motor-ctrl/bin to get the start_motor_dashboard command working properly. The README will be updated in the next release.
You can refer the documentation here for more details - https://xilinx.github.io/kria-apps-docs/kd240/build/html/docs/foc-motor-ctrl/src/app_deployment.html#run-the-motor-control-dashboard-application


WDIO tests are failing for Terra-Clinical-Data-Grid

Issue Description
WDIO tests are failing for Terra-Clinical-Data-Grid due to below accessibility violations
[medium] DataGrid with pinned columns and overflow columns with initial rendering [#pinned-and-overflow] is accessible and is within the mismatch tolerance:
expected no accessibility violations but got:
	{
  "description": "Ensures aria-hidden elements do not contain focusable elements",
  "help": "ARIA hidden element must not contain focusable elements",
  "helpUrl": "https://dequeuniversity.com/rules/axe/3.2/aria-hidden-focus?application=axeAPI",
  "id": "aria-hidden-focus",
  "impact": "serious",
  "nodes": [
    {
      "all": [
        {
          "data": null,
          "id": "focusable-not-tabbable",
          "impact": "serious",
          "message": "Focusable content should have tabindex='-1' or be removed from the DOM",
          "relatedNodes": [
            {
              "html": "

",
              "target": [
                ".DataGrid-module__leading-focus-anchor___2JPRS"
              ]
            }
          ]
        }
      ],
      "any": [],
      "failureSummary": "Fix all of the following:\n  Focusable content should have tabindex='-1' or be removed from the DOM",
      "html": "

",
      "impact": "serious",
      "none": [],
      "target": [
        ".DataGrid-module__leading-focus-anchor___2JPRS"
      ]
    },

Recently New axe rules : wcag2a', 'wcag21aa' were added to toolkit and relased with toolkit version 5.1.0 .
New rules are catching this accessibility violations of clinical-data-grid, which were not caught before with previous axe rules : ['wcag2aa', 'section508'] .
Additional Context / Screenshots
Travis Build job of Terra-clinical(master) :  https://travis-ci.com/cerner/terra-clinical/jobs/210876148

The following PR resolve the issue: https://github.com/cerner/terra-clinical/pull/522
We are waiting for translations to before we merge the PR.
We should have translations back this Friday.

I am closing this issue since #522 resolved it.


Narcolepsy Treatment

About the PR
This PR adds a new ReagentEffect to desoxyephedrine and ephedrine that resets the time between narcolepsy incidents. The preview video has an altered example in which the ReagentEffect resets the timer to 10. As soon as desoxyephedrine drops below 5, the entity will fall asleep 10 seconds later. In actual gameplay, the ReagentEffect will reset the timer to 600 (10 minutes).
This is my first time coding in C#, so please tell me if I need to change or fix anything.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

https://user-images.githubusercontent.com/91828755/211708018-5e330ad7-92a9-4b40-a3e8-e2985f1a3339.mp4
Changelog

:cl:

add: Narcolepsy can now be treated.

You'll need to remove the curly brackets also and shift everything one indentation level to the left.

You'll need to remove the curly brackets also and shift everything one indentation level to the left.

where? i don't know which curly brackets you're asking me to delete as (i think) everything lines up


Question: Where does the QnA action take the input from?

When I add a QnA action, the tutorial shows that by adding an unknown intent trigger. That works fine, but I would like to have an explicit QnA call in my bot, read: I would like to ask my QnA service using a variable as input.
What kind of  input does the QnA action use? There seems to be nothing I can use as an input in the QnA action itself, so I believe it uses a predefined input variable.
By the way, this would be an excellent addition to the Bot Framework Composer Docs.

Hi @eluchsinger - you can add a QnAAction anywhere inside a flow (see above), but I don't think thats what you're asking about.
As far as what gets sent as input to the action, it's the user's utterance and the knowledge base looks to resolve the utterance to a key in the knowledge-base. You cannot change this value before it gets sent to the knowledgebase.
We're actively making a change to how QnAMaker fits into Composer, allowing a more integrated experience along with language data (.lu).

@cwhitten It's really interesting, as I've now changed the QnA Action to be inside the flow. Now I found out, it somehow clears the dialog's variables ☹.

I have now embedded the QnA Action into the flow and am getting a really interesting behavior. As you can see in the screenshots below, I first read a question and save it into the dialog.question variable. Then I print the variable once before and once after the QnA action and I get the wrong output and the variable is null during the second print.

@vishwacsena @Stevenic does running the QnaMaker dialog blow away the calling dialog's dialog memory scope?

This is a bug. QnA action should not alter dialog in any way. @pchoudhari can you have someone take a look? Will transfer to dotnet repo.


Scala 2.13.0-M3

Pull Request Checklist

[ ] I agree to licence my contributions under the MIT licence
[ ] I have added copyright headers to new files
[ ] I have added tests for any changed functionality

Purpose

Update build to include 2.13.0-M3
Update version of specs2 (except for Scala 2.10 build)

Hi, I've added the MR template back.
Could you have a look at my comments please, and acknowledge the checklist for the MR if you are happy with it?


736 add a duplicate feature for plugins

Closes #736. Added a "duplicate" feature to quickly create a deep copy of a plugin including all its configurations. Current methods for creating a duplicate:

Right click on the plugin to duplicate and select the "duplicate" option in the drop down
Select the plugin to duplicate and press the "Ctrl+d" hotkey

https://user-images.githubusercontent.com/33141599/120910447-b9126b80-c644-11eb-82f6-048480bb7eb5.mp4

Looks pretty useful at first glance. I need to look at the temp file code, that seems a little odd.

There might be a more efficient way, but I was trying to use the existing plugin interface. I didn't initially see a super easy way to go from YAML::Emitter to YAML::Node directly. I did however see a way to go from YAML::Node to YAML::Emitter easily. It would be nice if the MapvizPlugin::SaveConfig interface took in a YAML::Node directly and then let the user decide how to save that since it's not actually saving to a file in any of the implementations I've looked at.
Changing the existing MapvizPlugin interface or adding another pure virtual method to the MapvizPlugin class would break all existing plugins. Avoiding that was my primary objective for doing something kinda quick and dirty. I can look around in yaml-cpp to see if there is a more efficient way to do that conversion in case I'm just missing something.

@danthony06 I found a better way to save/load the config for the plugin to be duplicated that does not require using a temp file. I've tested locally on melodic. The CI seems to be failing because it can't find catkin tools, so It didn't even make it to the build.


Upgrade to bugsnag-js 7.x (latest)

This PR gets us running on the latest bugsnag-js! 🎉
💥Breaking change💥
Upgrading

Rename notifyReleaseStages/BUGSNAG_NOTIFY_RELEASE to enabledReleaseStages/BUGSNAG_ENABLED_RELEASE - (in sync with bugsnag-js)

endpoint/ BUGSNAG_ENDPOINT => endpoints/BUGSNAG_ENDPOINTS  - both are now required in bugsnag-js 7.x

Rename getMetaData =>  getMetadata in app/utills/bugsnag.js (in sync with bugsnag-js)

note: Bugsnag will use the current client when you use the default import  import Bugsnag from 'bugsnag' - This is how bugsnag-js now works.
So usage is simplified due to no longer having to worry about the current client.
Let me know if I can make any changes! Thanks!

hey @jderr-mx I know you must be super busy! I was wondering what you thought of this PR?

hey @jderr-mx I know you must be super busy! I was wondering what you thought of this PR?

Hi @pdud My apologies for the delay. Looks like I need to make sure I get notifications when PRs are opened.
I'll take a look and assuming all is well I'll release it as 3.0.0 since there are breaking changes.

Thanks for reviewing @jderr-mx! I've added a section to the readme as requested. Let me know if there is any changes you'd like to see.

Awesome thank you!


Better error message for corrupt .git/index

A user received this error when they had a bad index.
Information {"Message":"System.ArgumentOutOfRangeException: Non-negative number required.\r\nParameter name: dstOffset\r\n   at System.Buffer.BlockCopy(Array src, Int32 srcOffset, Array dst, Int32 dstOffset, Int32 count)\r\n   at GVFS.Virtualization.Projection.GitIndexProjection.GitIndexParser.ReadPath(GitIndexEntry indexEntryData, Int32 replaceIndex, Int32 byteCount)\r\n   at GVFS.Virtualization.Projection.GitIndexProjection.GitIndexParser.ParseIndex(ITracer tracer, Stream indexStream, GitIndexEntry resuableParsedIndexEntry, Func2 entryAction)\r\n   at GVFS.Virtualization.Projection.GitIndexProjection.GitIndexParser.RebuildProjection(ITracer tracer, Stream indexStream)\r\n   at GVFS.Virtualization.Projection.GitIndexProjection.BuildProjectionFromPath(ITracer tracer, String indexPath)\r\n   at GVFS.RepairJobs.RepairJob.TryParseIndex(String path, List1 messages) in
Could it be more beneficial to run 'git ls-files' in and print out the error?
Can we handle this better?
@kewillford  @wilbaker @jamill  @derrickstolee  for everyone's thoughts.

I think we have a copy of the corrupted index, so maybe we could try and understand what is wrong with it, and where VFS4G had trouble?
We should be able to do better than an ArgumentOutOfRangeException - even if it just indicating that we encountered a corrupt index and exiting the mount. If there was some guidance on what a user's next step might be to self mitigate, that could also be interesting... but I am not sure what the next step would nbe.

I think this is a good place to try/catch and throw an application exception (new GVFSException?) with a message to run the gvfs repair which will fix the corrupt index.

I think in this specific case, even gvfs repair failed with the same error. @jeschu1 do you remember? I think we ended up deleting the .git/index file an repairing after that.

Yeah our parsing code right now doesn't handle corruption in the extensions.  I thought we had an issue for that but maybe that was just in my head.

@derrickstolee is correct we had to delete the index, we then ran repair i believe to recreate it.
If we fail to parse the index could we catch that and try to run 'git ls-files' showing the results?  I was thinking that would prove the index was corrupt and where.


avoid head to head collisions

improved, but not entirely fixed, in 79c784ea

fixed in f5bdb6f

i lied, it didn't work

this is mostly fixed as a result of cb6a9c45.
head-to-head collisions still occur occasionally, but they're in difficult enough positions to solve that i don't mind it.


ICA arguments confusion

The ICA object takes three arguments that are somehow related to the number of components:

n_components
max_pca_components
n_pca_components

Every time I use ICA in MNE I get confused. Why are there three seemingly related arguments? The only thing I ever needed to do is to reduce the number of PCA components prior to ICA (e.g. for average-referenced data the number of PCA components should be set to the number of channels minus one). Now since PCA is the first step in any ICA algorithm, I thought that n_components would set this value. But from the docs, it looks like this is really done by max_pca_components - or is it? And when do I need n_pca_components? I'm curious which use cases require these three arguments.
BTW, both EEGLAB's runica and scikit-learn's FastICA functions/objects only have n_components arguments.
Related to this question: what does the noise_cov argument do? Is the purpose to whiten the data if noise_cov is some covariance matrix or not whiten (i.e. only decorrelate) if noise_cov=None? If so, wouldn't it make more sense to introduce a boolean whiten argument instead? Here, it seems like MNE's ICA does not whiten by default, whereas EEGLAB and scikit-learn do whiten by default.

Migrating from #5054 ...
Like @cbrnr, I have issues with the ICA API and would appreciate a quick check on my intuition about it:
My current understanding is:

calculate PCA on data X
retain max_pca_components and project X to X_reduced
at this point, probably n_components is doing something ... but what?
Using X_reduced, we compute an ICA and have X_reduced_ica
From X_reduced_ica, we retain/reject components
We back-project X_reduced_ica using the ICA weights and have X_reduced'

( the ' indicating that some components were rejected in the ICA ... but the dimensions are the same)

X_reduced' can now be back-projected to X' using the PCA weights of dimension max_pca_components

(It would be X' instead of the original X because of two reasons: (a) some ICA components were missing (rejected) to get the same X_reduced and (b) X_reduced does not contain all pca components so we cannot recover all the data)

Here, at step 7., n_pca_components comes into play by using more than just max_pca_components to construct X' from X_reduced'
Is my intuition about the procedure correct? Given that yes, ... are there any references that suggest that step 8. (concerning max_pca_components) is sensible? And I still don't know what n_components is doing ... but for now, I will not do any dimension reduction anyway and leave the arguments at None.

Furthermore, given the discussion about PCA before ICA, there is a recent paper that warns about performing dimension reduction prior to ICA
Maybe we should include a warning that performing dimensionality reduction (even only by 1% variance) before ICA can lead to unreliable results? Just as @cbrnr has pointed out in #5054 we can mention the case that dimension reduction is necessary in the case of e.g., the average reference. That information might fit well next to the warning note about filters, wouldn't it? :-)

Hi,
I have just made some comments to this #5114 docstring commit, after having dived through the ICA code the whole day in order to get a more profound understanding of what is going on with the different component-settings. What actually provoked this undertaking were two mistakes in the specification of the pca_components_-shape in the doc.
@cbrnr, maybe you could review and consider it? See here: https://github.com/mne-tools/mne-python/commit/1a09859c6e5a7749b25a6c78403c0f02b225f0f5
(I am not sure, if this is the right way to contribute anything to this issue; if not, please let me know the most proper way.)

@jeythekey can you make a PR to fix the problems you've identified?

OK, done so (my first one ;):  #5620

Closing as (optimistically!) fixed, @sappelhoff or others if it's not, feel free to reopen

That's indeed optimistic 😄 - when I have more time I'll come back to this.

That's indeed optimistic smile - when I have more time I'll come back to this.

+1, same here :-)
... at the latest the next time I want to use it. Fair enough to close it for now.

I don't think that I'm the person you guys are intending to copy on this
thread.
On Tue, Nov 13, 2018 at 2:39 AM Stefan Appelhoff<EMAIL_ADDRESS>wrote:

That's indeed optimistic smile - when I have more time I'll come back to
this.
+1, same here :-)
... at the latest the next time I want to use it. Fair enough to close it
for now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/issues/4856#issuecomment-438166669,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAaDyd978ie6iNejhlZ_nlE50N0H_DHmks5uundAgaJpZM4RX9Zb
.

Ahh yes sorry for the noise @cbrunner, we meant to tag @cbrnr -- you should be able to follow the "mute this thread" link in your email to disable notifications (or do so via the GitHub web interface)


BUG: Fix SetBlockColor argument casting.

Fix vtk::CompositeDataDisplayAttributes::SetBlockColor first argument
type by explicitly casting to vtkDataObject*.

Looks like there is a conflict...

Sorry @lorensen  looks like I started off from an old master branch in both the VTKExample and VTK itself, and hence I got the build error due to a different definition of the method.
The master is fine. So closing the PR.


[core-client] Clean up serviceClient.ts by moving code

This PR makes no actual code changes, but moves some code out of serviceClient.ts to make the file a little less sprawling.

Can we ensure this gets merged after https://github.com/Azure/azure-sdk-for-js/pull/13691 so that all net changes in git history appear after the version number was incremented?

Can we ensure this gets merged after #13691 so that all net changes in git history appear after the version number was incremented?

Yep! I just approved that one so we can get it merged first. :)

Yep! I just approved that one so we can get it merged first. :)

Yay! And with that you get awarded with a merge conflict! Congratulations!

Yay! And with that you get awarded with a merge conflict! Congratulations!

I will treasure it, thank you. 😉

/check-enforcer reset

/check-enforcer evaluate


Tracking Issue: Parser fuzzing

Problem
It would be great if we fuzzed the parser for semantic errors.
Solution
There are quite a few resources on parser fuzzing:

https://arzg.github.io/lang/20/
https://crates.io/crates/fuzzcheck
https://crates.io/crates/honggfuzz

Alternatives considered

Additional context

Closing this as fuzzing related topics have been moved to https://github.com/noir-lang/parser-fuzzer


Get rid of Google Fonts

I have major privacy concerns about using Google Fonts.
I do what I can not to be tracked online by as many GAFAM as I can, and having to check if my slides aren't tracking me is just ridiculous.
A simple solution would be to download the fonts and place them in an assets folder.

There was a discussion about that. You may be interested in instruction how to use (Google) fonts locally - #194.

Hi and thanks for the info @szpak.
I still have great concerns about this, even more considering this is absolutely not necessary and harmful to the user. Plus Remark's maintainers might want to remove the "Note that you need remark.js alongside this html file, but no internet connection." in the example, as Remark actually does need an Internet connection.

Google fonts are simply used in the boilerplate example and have nothing to do with remark as such, If you don't want to use them, you can simply leave them out.
And regarding the quote about offline usage, remark does not require an internet connection. If you reference assets that are offline, like if you use the boilerplate example, loading of the fonts will fail, but this has nothing to do with remark and will simply fallback to other, available fonts.


Update fceux from v2.6.4 to v2.6.6.

The current v2.6.4 fails to build on master because of the GCC 13 change. That version is from 2022, so it seems like it would be a good thing to upgrade unstable anyway.
Description of changes
Upgrades fceux from its current version 2.6.4 to the latest release version 2.6.6.
CC maintainers @sbruder @scubed2

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I am interested in keeping this!

I made the suggested changes. Thanks for your help. I'm new to contributing to nixpkgs.

Well, I did something at https://github.com/NixOS/nixpkgs/pull/282424
I decided to step-up the updates. Instead of jumping from 2.6.4 to 2.6.6 I "fixed" the underlying 2.6.5.
With this, now Nixpkgs builds all possible versions!
The scubed2 fork was updated 4 years ago. I believe I should fill for abandonment.
The latest from sbruder was harder to find:
https://github.com/NixOS/nixpkgs/commit/f9910b39bd3115a72630b1dd102f536faac324fc
https://github.com/NixOS/nixpkgs/pull/226426
I will wait for them.


Revert "Revert "object3d scaling should multiply, not add to graph input""

Reverts vizorvr/vizor#1575

lgtm


Access denied ..

Sorry, guys .. I seem to lost the ability to make changes to this repository; no idea why.  There are changes in half a dozen files that I cannot commit.

Looks like the changes went in even though authentication was rejected multiple times .. grrr


Profiler: Show "truly-in-use" memory usage line

This would handle a common pitfall for users when looking at profiles: Users see the memory usage only go up, and assume that the program is leaking memory. In reality the instances that are accumulating are probably invalid, and would be removed by Legion if it actually got squeezed for memory.
IMHO what the user truly wants to know is how much "breathing room" they have on the memory at any given time.
We would need the profiler to be told when instances become valid and invalid, so it can draw a line of the "truly-in-use" memory usage, which only includes valid instances (possibly in addition to the "technically correct" utilization that we show today, where invalid instances are also included).
Assigning @lightsighter to give an estimate on the work, maybe make sub-tasks to assign.

I was looking at this some yesterday. I realized that there's a bit of a discrepancy between how we currently visualize instance lifetimes and what we probably want to visualized for understanding out of memory conditions. There are actually two different timelines that matter for instances: one at the mapping stage of the pipeline and one for the execution stage of the pipeline.
At the mapping stage of the pipeline, the timeline looks like the following:

Legion calls Realm to create the instance (this is the "creation" time of the instance in Realm's profiling)
The instance becomes valid when Legion issues copies to make it valid
The instance becomes invalid when something else writes to the logical region and maps to a different instance (2 and 3 can repeat an arbitrary number of times)
Legion invokes the destroy operation on the instance to make it eligible for deferred allocations

At the execution stage of the pipeline, the timeline looks like the following:

The instance is actually granted its allocation and Realm triggers the ready event for the instance (this is the "ready" time for the instance in Realm's profiling) to indicate that the instance can be used.
Tasks and copies use the instance
The precondition for the instance to be deleted is triggered and Realm reclaims the space for the instance (this is the "destroy" time for the instance in Realm's profiling)

What we render in the profiler today is the execution stage of the pipeline. It shows the actual memory usage by instances during execution so that it aligns with what the tasks and copies are actually doing (e.g., if a task or a copy is running, you can see that the instances that it is using are alive at the same time). This makes sense if all we care about is seeing memory usage by the actual execution.
If we're actually trying to debug OOM conditions though, we don't actually care about the execution stage of the pipeline; instead we care about the mapping stage of the pipeline because we want to see what instances are valid and which have done deferred deletions so that they are eligible for deferred allocations. Unfortunately, you can't just overlay the mapping stage timeline on top of the execution stage of the pipeline because they are almost completely decoupled from each other. For example, if Legion is mapping ahead, you could have the instance be created, go through several cycles of becoming valid/invalid, and then have the destroy method invoked (with a precondition) all before the instance even becomes "ready" during the execution stage of the pipeline. In most cases though the two timelines will overlap but will be kind of unrelated to each other, e.g. the cycles of becoming valid/invalid won't be correlated with when tasks/copies are actually using the instance.
This creates a conundrum: do we want to visualize the mapping stage of instance lifetimes and if so how do we want to render it? I suspect that the answer is that we do want to visualize it, but I also don't think we want to overlay the mapping and execution stages on top of each other as I think it will be confusing. Do we want to have a separate timeline in the profiler for the mapping lifetime of instances? Should it be on by default or maybe should users be able to toggle the memories from the mapping stage to the execution stage and back? Other ideas?
@manopapad @elliottslaughter What do you guys think?

Right, so perhaps that deserves a different visualization, perhaps one with matplotlib or something that generates a static visualization of all the instances and where they are in memory and how much memory they take up so you can see the holes and the fragmentation and what instances are currently valid (uncollectable). Let's start a separate issue for that since I think we probably do want to keep this issue as well because I do think users will want to see which instances are actually in use and not being used since, as you pointed out, some users get confused by our lazy garbage collection. We might actually be able to do that without any new logging statements, but just using the instance use information that we have for tasks and copies to mark when instances are currently in use.

We can't run the profiler after OOM anyway (unless the mapper handles the error and falls back to some other memory, in which case it's not clear what to show), so unless we're fixing that along the way, we wouldn't be able to use Legion Prof anyway.

I have the beginnings of fixing this in the grandrefactor branch, although it will be a little bit before Legion shuts down cleanly so we can actually realize this.

I do think having an execution timeline that is more accurate to what's actually being used would be desirable. E.g., you can take your largest case (that still fits), run it through, and at least observe whether memory usage is growing and what is using what.

I agree with should maintain the current timeline because it accurately aligns with which instances are live at the time when tasks and copies are actually running.

And execution is relevant here, because even though the decisions happen at mapping time, the lifetimes are ultimately correlated to some tasks.

This is actually one thing missing from the critical path analysis today, because we don't analyze which instances had to be freed up allow for an allocation to succeed. We could actually technically do this analysis given we know the offsets and sizes of all instances in each memory. We could then align the allocation being ready with when the prior instances using the same space in memory were freed.

In contrast, it's not clear if a mapper-based timeline is useful because the mapping timeline is tied to the duration of specific mapper calls (that in general you'd expect to be uncorrelated with actual execution times).

Right, it's really only relevant at the point that you can't do an allocation and you need to understand what it is that caused that. The history might be relevant in case you wanted to see if fragmentation was growing worse over time, but I agree the timing is definitely decoupled from the execution stage of the pipeline and therefore a bit hard to grasp.

I also think an OOM-time live dump is potentially also useful.

I think this is the plan in #1797. There will be a mapper runtime call like:
void MapperRuntime::dump_memory_state(Memory m, const char *filename);

Legion will dump out the mapper runtime state and then there will be a post-processing tool that will parse the log file and either give you text output or present a visualization. You can call that though as many times as you want and make as many dumps as you want so you don't have to wait until OOM to call it, although it will eagerly dump to the file and might be a bit expensive.


Added "watchers" metric and "about/summary" section from Github

• Replacing "stars" with "watchers" to get more accurate assessment of the popularity of a project
• Utilizing the about/summary section from Github for the summary section of the dashboard

Closing temporarily to make changes. It may be cleaner to instead get the "watchers" attribute straight from the criticality project rather than generating it here.


Feature/csh/exp cluster

Description

A new cluster environment has been added! (testnet-exp)

Thanks for reviews! Now merging


Create separate section for docker image and architecture

This part is versioned

Actually, do we need the architecture?


Use shields.io for the coveralls badge

Coverage remained the same at 100.0% when pulling 0a9263aaec6bada181e6a2e2d9c7b05f6c03c0e3 on next into 78ecb57480f127f705566d269b2b148ad10b6a57 on master.


GEOWAVE-614 - Added multi-threading to Geowave Ingest

Reviewed.  Looks good to me.  +1 for helpful comments throughout!


Attachment functions running while I don't have any attach in my emails

If a bug, what happened?
When I Called '$imap->getMessagesByCriteria('ALL', 5, 1);' to get messages (or search), I get this Error Message: Uncaught Error: Cannot use object of type stdClass as array that it solved by Issue #93 solution.
After Solving this Problem I get another error in Attachment functions while I don't have any attach in my emails:
Message: Undefined property: stdClass::$value, Filename: ImapClient.php, Line Number: 1380, Function: getAttachments
Backtrace:
Line: 1353
Function: getAttachments
----
Line: 825
Function: getAttachments
----
Line: 574
Function: formatMessage
----
Line: 89
Function: getMessagesByCriteria (This function called my own PHP file in line 89)
AND other error inside it (about Attachments):
Type: ImapClientException Message: Your attachments do not have a name. This should NOT be happening, Filename: ImapClient.php, Line Number: 1188, Function: attachments2name
Please notice that I don't have any attach in my emails.
Please help me to solve. Thanks a lot.

Any chance you can say what code you're using to produce the error?

Hello hhdivil,
I just edited ImapClient class in order to solve problem said in #93 .
Then I called $imap->getMessagesByCriteria('ALL', 5, 1); to get first 5 email.
After opening my php file I get this Error:
Undefined property: stdClass::$value
Filename: ImapClient.php
Line Number: 1380
Function: getAttachments
AND
Type: ImapClientException
Message: Your attachments do not have a name. This should NOT be happening
Filename: ImapClient.php
Line Number: 1188
Function: attachments2name

Nevermind I got it.  Line 1381 of ImapClient class:
"name"        => $parameters->value,

You must have some weird attachments on that e-mail - maybe it's an image embedded in the signature?
You could always do this between lines 1379 and 1380 and let us know what you get
var_dump($parameters);exit;

After var_dump($parameters) I get this result:
object(stdClass)[105]
  public 'attribute' => string 'charset' (length=7)
  public 'value' => string 'us-ascii' (length=8)

ah drop the exit, it'll be the last one in the loop.  sorry my bad

can you give me the var_dump($part); as well?  might be some interesting info in there - i edited my comment above

I realized your edit.
This is result (I wrote "//--Error" when Error occurred and I Removed file path).
\ImapClient.php:1379:
object(stdClass)[104]
  public 'type' => int 0
  public 'encoding' => int 0
  public 'ifsubtype' => int 1
  public 'subtype' => string 'PLAIN' (length=5)
  public 'ifdescription' => int 0
  public 'ifid' => int 0
  public 'lines' => int 9
  public 'bytes' => int 417
  public 'ifdisposition' => int 0
  public 'ifdparameters' => int 0
  public 'ifparameters' => int 1
  public 'parameters' =>
    array (size=1)
      0 =>
        object(stdClass)[105]
          public 'attribute' => string 'charset' (length=7)
          public 'value' => string 'us-ascii' (length=8)
  public 'disposition' => string 'attachment' (length=10)

\ImapClient.php:1379:
object(stdClass)[105]
  public 'attribute' => string 'charset' (length=7)
  public 'value' => string 'us-ascii' (length=8)

\ImapClient.php:1379:
object(stdClass)[102]
  public 'type' => int 2
  public 'encoding' => int 0
  public 'ifsubtype' => int 1
  public 'subtype' => string 'DELIVERY-STATUS' (length=15)
  public 'ifdescription' => int 0
  public 'ifid' => int 0
  public 'bytes' => int 228
  public 'ifdisposition' => int 0
  public 'ifdparameters' => int 0
  public 'ifparameters' => int 0
  public 'parameters' =>
    object(stdClass)[103]
  public 'disposition' => string 'attachment' (length=10)

\ImapClient.php:1379:
object(stdClass)[103]
//--Error

\ImapClient.php:1379:
object(stdClass)[96]
  public 'type' => int 0
  public 'encoding' => int 1
  public 'ifsubtype' => int 1
  public 'subtype' => string 'PLAIN' (length=5)
  public 'ifdescription' => int 0
  public 'ifid' => int 0
  public 'lines' => int 11
  public 'bytes' => int 844
  public 'ifdisposition' => int 0
  public 'ifdparameters' => int 0
  public 'ifparameters' => int 1
  public 'parameters' =>
    array (size=1)
      0 =>
        object(stdClass)[97]
          public 'attribute' => string 'charset' (length=7)
          public 'value' => string 'UTF-8' (length=5)
  public 'disposition' => string 'attachment' (length=10)

\ImapClient.php:1379:
object(stdClass)[97]
  public 'attribute' => string 'charset' (length=7)
  public 'value' => string 'UTF-8' (length=5)

\ImapClient.php:1379:
object(stdClass)[94]
  public 'type' => int 0
  public 'encoding' => int 1
  public 'ifsubtype' => int 1
  public 'subtype' => string 'HTML' (length=4)
  public 'ifdescription' => int 0
  public 'ifid' => int 0
  public 'lines' => int 272
  public 'bytes' => int 28201
  public 'ifdisposition' => int 0
  public 'ifdparameters' => int 0
  public 'ifparameters' => int 1
  public 'parameters' =>
    array (size=1)
      0 =>
        object(stdClass)[95]
          public 'attribute' => string 'charset' (length=7)
          public 'value' => string 'UTF-8' (length=5)
  public 'disposition' => string 'attachment' (length=10)

\ImapClient.php:1379:
object(stdClass)[95]
  public 'attribute' => string 'charset' (length=7)
  public 'value' => string 'UTF-8' (length=5)
//--Error

getMessagesByCriteria() method now does not work correctly, it has not yet been rewritten. Therefore, you have mistakes.

Now, how can I search in mails? @sergey144010

It uses an outdated method $this->formatMessage($id, $withbody, $embed_images);
It must be replaced by $this->getMessage($id);

@SSilence Please solve this problem.

Wait for replacement or use imap_serch()
http://php.net/manual/en/function.imap-search.php

make the method private if it does not work?
On 7 Apr 2017 18:40, "sergey144010"<EMAIL_ADDRESS>wrote:

Wait for replacement or use imap_serch()
http://php.net/manual/en/function.imap-search.php
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SSilence/php-imap-client/issues/124#issuecomment-292603383,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AX9sN8GziFZvBML0eL1_pOdU_SEfCuUzks5rtnUQgaJpZM4M3Hur
.

It uses an outdated method $this->formatMessage($id, $withbody, $embed_images);
It must be replaced by $this->getMessage($id);

Thanks @sergey144010
I must do this replace in getMessagesByCriteria() function?

Try this
public function getMessagesByCriteria($criteria = '', $number = 0, $start = 0, $order = 'DESC', $withbody = FALSE, $embed_images = FALSE)
    {
        $emails = array();
        $result = imap_search($this->imap, $criteria);
        if ($number == 0)
        {
            $number = count($result);
        }
        if ($result)
        {
            $ids = array();
            foreach ($result as $k => $i)
            {
                $ids[] = $i;
            }
            $ids = array_chunk($ids, $number);
            $ids = array_slice($ids[0], $start, $number);
            $emails = array();
            foreach ($ids as $id)
            {
                $emails[] =  $this->getMessage($id);
            }
        }
        if ($order == 'DESC')
        {
            $emails = array_reverse($emails);
        }
        return $emails;
    }

And write works or not.

Thanks a lot @sergey144010
It Worked.
Now I noticed When I get a list of emails by getMessagesByCriteria() or getMessages() the result not said me that this email is in 'Unread' or 'Read' state.

Letters are considered read.

Soon I will fix this code.

Your mean is in getMessagesByCriteria('ALL') function only read state email returned?
When I get emails with this function, I see Unseen in header. This specific 'Unread' or 'Read' state?
Another problem: when call getMessagesByCriteria('ALL'), all 'unread' emails marked as 'read' without allow.

OK I will think about it.

We corrected, update and try a new version.

Thanks @sergey144010
Now, what I must do? Download again?

if you use composer just type composer update
On 8 Apr 2017 11:35, "Mahdi Sinor"<EMAIL_ADDRESS>wrote:

Thanks @sergey144010 https://github.com/sergey144010
Now, what I must do? Download again?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SSilence/php-imap-client/issues/124#issuecomment-292709584,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AX9sNzbH7ytlvVR2P3bGZb3RKmCH6Dgnks5rt2MAgaJpZM4M3Hur
.

@MSAyrese is this still an issue?

I think can close the topic.

Yeah.. No response and we have fixed the issue

Problem Solved.


M4 Kick-off

Motivation
Discuss & decide the role & structure of  the Finaliser pallet, as well as the Representative role
Please, add diagrams and comments relevant to the discussion to this issue, instead of creating a new one (For now).
Representative role summary

To be discussed:

[x] Representative role extent
[x] Representative Election process
[x] Representative actions in the FS system(Tenants metadata modifications, Tenant status(to be established), etc...)

Pallet_Finaliser

To be discussed:

[x] Notary role extent
[x] Notary selection process
[x] Notary actions in the FS system
[x] Relation between Bidding and Finaliser pallets

Additional topics

Tenants registry needed for M4?
Which pallet will manage potential_Tenants-Representative-Asset operations?
Which pallet will manage Final_tenants-Asset-Landlords operations?

After our first call we discussed the workflow of the requirements of M4.
Finalizer:
This feature is fulfilled in the real world by someone that has authority to pass housing titles and file them in the land titles registry. This is usually done by a notary and they have their own specific way of working. We don’t want to change that process, what we do require is a proof of documents / proof of passing when they come-up with a verdict.
Requirements:

Has it's own role notary
Provides a proof linking to the verdict ( this will be further clarified in the future )
The asset that is has to review should be in  Onboarded state and should have an investors list reserved.

The sale cannot take place without the notary finalising the sale.
The Status Finalizing is applied when the reserved list of investors and the asset is being finalized.
When the status is finalizing we don't want to bidding-pallet to reserve a new investors list. The asset should essentially be locked.

The notary may decide a couple of things

Accept the sale, which means the bidding-pallet can continue with the happy flow and start the exchange. This would change the status to purchased of the asset. We can let this transition happen by introducing a new status to the asset or adding a new variable for the acceptation so its finalizing + verified --> purchased.
Decline the sale to happen for various reasons such as something wrong with the asset or they identified fraudulent behaviour etc. The rejection has two degrees.
If there is any behaviour that is fraudulent and the proposal is to be destroyed. The investors would get their allocation in the asset unreserved. If it's the asset the asset should get a new status REJECTED or Slashed depending on the severity.
If there is something found about on or more investors, the housing status should be demoted to Onboarded and the investors should get their allocation unreserved. So there is a new round again. This would mean that the investor that is found to be fraudulent would not be able to participate in the next round. So we would need to give investors also a status. [Verified, Under-Review, Rejected] ?

Owners-vote:
This feature is fulfilled in the real world by a vote of the owners of the building. We want to owners (shareholders) to be able to vote on anything regarding governance of the asset. This is can be Maintainance, Deciding if a tentant should be allowed, Selecting a representative.
One of their duties is selecting a representative, why we want to have a representative role ? As the representative is the first point of contact for the owners and the tenant. More on this in the the next section. This part is about allowing the owners to govern their asset on chain.
Requirements:

Using the democracy pallet voting and tallying mechanism while relying on the assets-pallets shares for a specific unique asset.
The first feature is appointRepresentative which allows the owners to appoint a representative. This is a one time action and you can't select multiple representatives.
The asset should be in Purchased state.

Structure:

Integrated in voting pallet, with a prefix of owners
Hide the democracy pallet from the UI/polkadot.js if possible (nice to have)

Representative:
The representative is the first point of contact for the owners and the tenant.

The Representative  has a role representative and has a unique identifier for the unique asset it's representing.
Add to the unique asset a representative field, which is a AccountId
The representative might need to accept the role after appointRepresentative is called.


Use existing endpoints onfiguration when loading new model via PUT request

Proposed changes:

use existing endpoints onfiguration when loading new model via PUT request

This PR solves #3634.
Status (please check what you already did):

[ ] made PR ready for code review
[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog
[ ] reformat files using black (please check Readme for instructions)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.