Removing strict warnings when using icc

The Intel C compiler, with strict warnings enabled, produces a warning when a default label is not included if there are potential argument values that don't have a corresponding case label.  This change adds these defaults as required.
This is built on top of pull requests

https://github.com/openssl/openssl/pull/4249 so I could test on Solaris and
https://github.com/openssl/openssl/pull/4250 without which I could not test on Linux

How did you go about adding the default case?  Did you search for every switch statement and add a default case on all of them?  I'm asking because some of them seem unnecessary.  One example is the change in opt_rand in apps/app_rand.c, where all the cases cover all the possibilities given by enum r_range.  Did icc actually warn about that one?  If it did, then it seems to be flawed...

I'm sorry if I came out harsh...  thing is, we intentionally left out the default case in quite a number of switch statements so compilers would detect if there are cases we forget to check (in the case where we do use enums)

Yes my Jenkins(+travis YML plugin) build system has "--strict-warnings" flag enabled so it will not go ahead with the build due to these problems. As I ran the job, it broke down in those files and showed those line numbers where the build is broken so I have manually added default clause in those files one by one. Took me one day. In the end my build went through. I do not know why it fails on your travis CI system.
Whatever you guys decide on this patch is fine with me.

The failure on Travis is unrelated to this change, so don't worry about that one.
What worries me is that icc seems to warn about the lack of default case when all possible cases in an enum have been covered...  if I understand you correctly.

Side note: if you rebase on top of a fresh master, the commits coming from the other PRs will disappear.

I'd argue against this. Reason is already mentioned by Richard. If it's so important to push strict-warnings build through icc, it would be more appropriate to suppress specific warning through command line than to try to accommodate specific compiler. Or simply not using --strict-warnings with icc...

I will test these enums and get back to you.

That would be super, thanks for making the effort!

Here is a sample; there should be no warnings:
enum a { a1, a2 };
void foo(enum a x);
void foo(enum a x)
{
   switch (x) {
   case a1: case a2: break;
   }
}

I'm with @dot-asm here.  A command line option to suppress the warning in question makes sense.  Either via a command line addition or through Configure.

Or have icc-dev-warnings likewe have for gcc and clang

@levitte  without default case patch in apps/app_rand.c, build fails as shown below
icc  -I. -Iinclude -Iapps -DDSO_DLFCN -DHAVE_DLFCN_H -DNDEBUG -DOPENSSL_THREADS -DOPENSSL_NO_STATIC_ENGINE -DOPENSSL_PIC -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_MONT5 -DOPENSSL_BN_ASM_GF2m -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DRC4_ASM -DMD5_ASM -DAES_ASM -DVPAES_ASM -DBSAES_ASM -DGHASH_ASM -DECP_NISTZ256_ASM -DPADLOCK_ASM -DPOLY1305_ASM -DOPENSSLDIR=""/usr/local/ssl"" -DENGINESDIR=""/usr/local/lib64/engines-1.1"" -Wall -O3 -pthread -m64 -DL_ENDIAN  -DDEBUG_UNUSED -Wswitch -DPEDANTIC -pedantic -Wno-long-long -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wsign-compare -Wmissing-prototypes -Wshadow -Wformat -Wtype-limits -Wundef -Werror -Wa,--noexecstack  -MMD -MF apps/app_rand.d.tmp -MT apps/app_rand.o -c -o apps/app_rand.o apps/app_rand.c
apps/app_rand.c(81): error #2338: this switch statement does not have a default clause
switch ((enum r_range)opt) {
^
compilation aborted for apps/app_rand.c (code 2)
Here is the code I tested
enum r_range { OPT_R_ENUM };

int opt_rand(int opt)
{
    switch ((enum r_range)opt) {
    case OPT_R__FIRST:
    case OPT_R__LAST:
        break;
    case OPT_R_RAND:
        return loadfiles(opt_arg());
        break;
    case OPT_R_WRITERAND:
        OPENSSL_free(save_rand_file);
        save_rand_file = OPENSSL_strdup(opt_arg());
        break;
    }
    return 1;
}

So that seems to be a flaw in the compiler, or a false positive, because OPT_R_ENUM is defined like this in apps/apps.h:
# define OPT_R_ENUM \
        OPT_R__FIRST=1500, OPT_R_RAND, OPT_R_WRITERAND, OPT_R__LAST

As you can see for yourself, all cases are covered, default shouldn't be needed.
I believe the relevant warning switch (you can see the whole collection here) is -Wswitch.  It might be useful to check its documentation, maybe it has a different meaning for gcc?

@levitte - As of now I do not see Wswitch in icc documentation. But let me double check and get back to you.

I found this page mentioning that some gcc options are implemented even though not documented in the icc manual.  So it seems that they have implemented -Wswitch, but have done a bad job...

Shall I add a patch similar to this?
$git diff
diff --git a/Configure b/Configure
index 60dc1f4..6c4cb08 100755
--- a/Configure
+++ b/Configure
@@ -132,6 +132,16 @@ my $gcc_devteam_warn = "-DDEBUG_UNUSED"
         . " -Werror"
         ;

+my $icc_devteam_warn = "-DDEBUG_UNUSED"
+        . " -DPEDANTIC -pedantic -Wno-long-long"
+        . " -Wno-unused-parameter"
+        . " -Wsign-compare"
+        . " -Wmissing-prototypes"
+        . " -Wshadow"
+        . " -Werror"
+        ;
+
+
 # These are used in addition to $gcc_devteam_warn when the compiler is clang.
 # TODO(openssl-team): fix problems and investigate if (at least) the
 # following warnings can also be enabled:
@@ -1325,6 +1335,13 @@ if ($strict_warnings)
        my $wopt;
        die "ERROR --strict-warnings requires gcc, clang or icc"
             unless $ecc eq 'gcc' || $ecc eq 'clang' || $ecc eq 'icc';
+       if ($ecc eq "icc")
+               {
+               foreach $wopt (split /\s+/, $icc_devteam_warn)
+                       {
+                       $config{cflags} .= " $wopt" unless ($config{cflags} =~ /(?:^|\s)$wopt(?:\s|$)/)
+                       }
+               }
        foreach $wopt (split /\s+/, $gcc_devteam_warn)
                {
                $config{cflags} .= " $wopt" unless ($config{cflags} =~ /(?:^|\s)$wopt(?:\s|$)/)

Yes, something like that.  @levitte can comment on the perl aspect.

That patch is a good start, but not quite right.  The for loop that follows will always be run for all compilers.
Actually, the way this is constructed in Configure is cumbersome...  hold on, I'll make a PR that makes it easier to manage.

#4275 should make it muuuuch easier to add additional icc flags.

Let me close this and open a new pull request then as these code changes are no longer needed.

Original counter-argument was that lack of default is conscious choice that guards us from overlooking cases in switch(enum). It should be noted that this is what gcc -Wswitch is documented to do. While icc seems to interpret is as equivalent of gcc's -Wswitch-default. It should be noted that gcc offers even -Wswitch-enum, and one might argue that it would be appropriate to switch to that one. This way we keep gcc warning for us as originally intended, but without exposing flag to icc for mis-interpretation. For reference, icc does complain about ignoring unknown option '-Wswitch-enum'...


Improve (again) Signal handling.

Before this patch, premature stopping could only be achieved by enabling the interactive signal handler. The user now can prematurely stop algorithms by just pressing specific key combinations without passing through the handler.

Just restarted the build. The patch looks good and IMO we can merge it :)

How can we make examples to show this kind of stuff to users?


How do I add a card or control INSIDE my EditForm?

I have a simple screen with an EditForm which contains two text cards. One needs to be converted to a DropDown Y/N. I don't think I can CHANGE the card type like you can in Access, so the only path I see is to delete it and add a new one. But when I try to add a new Control of type DropDown, it adds it to the base EditScreen, NOT INSIDE the EditForm.
Any help would be appreciated.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0f886011-a79a-8fa9-bb7c-f0adbb61b8d3
Version Independent ID: 997f29d5-e836-fc31-647e-eb6a916afae4
Content: Understand data cards - PowerApps
Content Source: powerapps-docs/maker/canvas-apps/working-with-cards.md
Service: powerapps
GitHub Login: @gregli-msft
Microsoft Alias: gregli

I found that if you click on the main form that surrounds all the cards, then look on the Properties tab on the right hand side and there will be an option under "Data Source" called "Fields".  To the right of that option is a command "Edit Fields".  Click on that, then click on "Add Field".  This will allow you to add other missing fields from your data source as cards to your form.

Thanks, @pamjustice! @ToddChitt, please reopen this issue if it didn't answer your question.


Increment version for communication releases

Increment package version after release of Azure.Communication.CallAutomation

/check-enforcer override


Blocked loading mixed active on https website for youtube video

Hello
I am trying to use colorbox for youtube video but this is what on my https website. Can you please help me out ? This is a bit urgent.  Thanks

You should be able to link to https://youtube.com instead of http://youtube.com, or use the protocol-relative path.  For example:
Example

Hello
I did that yet still it is not showing the video. In the Href i first use https but it did not so i removed the https:// and replaced it with // but it is still not working.
Please visit this page and tell me why is it not working
https://holyunions.com/pages-all.php?id=14
I now get the followiing error
Load denied by X-Frame-Options: https://www.youtube.com/watch?v=jmtO65_oUtQ&feature=youtu.be does not permit cross-origin framing.

You should use the embed link like so :

You can get this link on the share part of the video by clicking on the embed "tab".

@binaryannie  thks


Owner: Create dishes

As an Owner.
In order to describe my dishes.
I need to be able to create dishes and add them to a category(Starter, Main course, Dessert).

These are two big, separate features. I would say you want to be able to create dishes, and then a separate user story is about sorting them logically, so you want to add them to a category.


Question/Feature: Does this work with latest version macOS 13.1 to 13.5

Hi All,
Hope all is well. Thanks in advance for looking into this. Much appreciated.
Describe the solution you'd like
Nudge Minimum OSVersion 13.4.1 and below to upgrade to the latest macOS version 13.5.
Best, RL

@RLNY88:
Will you please restate your request?
(We’re prompting users to upgrade to macOS 13.5.)

@dan-snelson
Thanks for the quick reply. Sorry, let me rephrase...
I changed "requiredMinimumOSVersion" key and set it to 13.99 (see below). And it doesn't seem to detect Required OS Version (see screenshot below). I hope you can point me to the right direction.
<key>requiredInstallationDate</key>
        <date>2023-01-28T00:00:00Z</date>
        <key>requiredMinimumOSVersion</key>
        <string>13.99</string>

@RLNY88:
From your screenshot, you're executing Nudge in Demo Mode.
If you haven't already, please join the 1,600+ Mac Admins on the #nudge-jamf Channel.
Closing.


Shift operators require typed registers

Implementing the >> and << at the end of chapter 3 requires use of a single byte register. I skipped ahead to see how register types would fit into the data model so I didn't have to refactor all that when I got there and ended up with this temporary hack:
  (define operand->string
    (match-lambda
      ; typed register. There is only one for now so we can support shifts
      [`(reg CX 1 ,_) "%cl"]
      ; untyped registers
      [`(reg AX ,_) "%eax"]
      [`(reg CX ,_) "%ecx"]
      ...

A pointer about how typed registers will be handled would be helpful at the end of chapter 3.

This is a good point. I think there may be one or two other extra credit features that would benefit from hints about how thing are handled later. (The other case I'm thinking of is that in compound assignment operators like a += b, a must only be evaluated once - which means ways of rewriting the AST that seem workable become a problem once you implement more complex lvalues like a[i] or a.member in Part II.)
It's too late to update the chapters, but maybe the web page should include an "Extra Credit Hints" section.

Added to the webpage: https://norasandler.com/book/#tips-on-extra-credit-features. Does that cover it?
(It's possible that I'd be able to add this to the book itself in the next reprint)

That looks great!


Automated building completions based on NG comment blocks in source

To keep this plugin version agnostic we'll need to have a dict for each 1.x release. It will be much easier keeping things up-to-date
[in progress]
Related issues: https://github.com/angular-ui/AngularJS-sublime-package/issues/77 https://github.com/angular-ui/AngularJS-sublime-package/issues/74 https://github.com/angular-ui/AngularJS-sublime-package/issues/64

With Angular 1.4 out there, I am really looking forward to this!
Do you need any help? I am somewhat tight on time but should be able to help with some guidance.

Yes, I'm eager to get this finished as well. I've the bulk of the parsing completed which produces a new data structure to work with. So, most that's left is just reworking the internals of the plugin to handle the structure of the new data.


Fixed RxSwipeRefreshLayoutTest test

After examining RxSwipeRefreshLayoutTest, it seems that the automatically ran .setRefresh(false) (which performs stopping the refresh animation) could happen to be called between the swipe release and the actual loading/refreshing animation, causing the animation to stop and listener never to be called, thus not recorded.
So the solution I did was to post refresh stop 2 seconds after the first touch on a view happens (which is enough time for the swipe - 1500ms and the recorder to catch up the listener). This should avoid flakyness in this test.
Fixes #72.

Nice work. This looks good. I just have potential improvement and then let's get this merged.

Thanks!


[Feature Proposal] Support disabled variant for inputs and buttons

Hello!
A variant for disabled inputs and buttons working like the current hover and active variants would be much appreciated.

I don't know about future plans about it, whether it will ever be
officially addressed or what, however I think that a plugin could be a good
temporary or even long-term solution.
I've not explored the plugin system myself yet though, so I may be really
wrong about it.
I'll let you know.
On Mon, Mar 26, 2018, 9:58 AM William Perkola<EMAIL_ADDRESS>wrote:

Hello!
A variant for disabled inputs and buttons working like the current hover
and active variants would be much appreciated.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tailwindcss/tailwindcss/issues/434, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AUJkjnZsAESiBpYlrRAG_Fn6Ji6ktlA4ks5tiJ-HgaJpZM4S6q49
.

Ok. I gave a look at the plugin system and no, it doesn't feet your needs. It allows you to create components, not to create variants.
You have three solutions at the moment: either hard code your components, add variant logic by yourself or wait for someone to do it.
If you are interested in what has been said about supporting this and several other variants so far, I'd suggest you to give #136 a read.

Thank you for looking into it! I have it hard coded at the moment. If I have time I might try out creating a variant logic for it and maybe submit a PR.


Apply Crites-Komlo-Maller improvement

This PR implements the improvement during the signing phase from Crites, Komlo and Maller in https://eprint.iacr.org/2021/1375. This yields a reduction of the partial signing phase of around 85% for a set of signers in the hundreds (the reduction increases with the threshold).
closes #36

Closing for now because of the concerns in https://github.com/Toposware/frost/issues/36#issuecomment-1184906568.


How to create file "warmup_k_path"?

Thank you for this repo is really awesome. But I have a small question:
how is the "warmup_k_path" file created, what is it used for in the deblur process.

Hi, thanks for your interest.
If you mean the "warmup_k.pth", it is a random kernel extracted by the kernel extractor. Before doing image deblurring, we initialize the blur kernel with a random kernel to stabilize the optimization process.
To generate a warmup_k.pth, you can modify the "data_augmentation.py"., for example, add `torch.save("kernel.pth", kernel) before  L119.


How do the benchmarks work?

I'm interested in the benchmarks presented. It is a bit unclear to me what is actually compared.
How come Euneus is faster even though it in theory does more work than Thoas? Are the benchmarks including the new Euneus encoders or not?

Hi, @eproxus!
You are right, things are unclear at the moment. Improve documentation, add specs, and embed benchmarks are on the Euneus roadmap. I'm busy now, but I will open a PR to explain what you asked as soon as possible.
Thanks for this issue!

In a nutshell, organizing the Thoas code and inlining some functions have improved the performance.
About the new encoders... yes, the new encoders option is implemented and considered in the benchmarks.

I integrated benchmarks into the project.
About the optimization, rewriting Thoas allowed me to see some non-optimized code, and I believe there is more to optimize.
As I said before, the optimization comes from code organization and inlining some functions. There is no magic here :)
English is not my best, so docs may contain unclear things.
Feel free to test and bring suggestions/feedback o/

In theory, Euneus does not do more work than Thoas.
Compare Thoas vs Euneus implementation of the value encoding. Both are just calling a function.

There are a lot of updates since my last comments.
Please see the README file and let me know if you have any doubts or suggestions :slightly_smiling_face:


Adding Illuminance Measurement yaml tests

Test Script Added
Adding YAML test script Test_TC_ILL_1_1
Generated script files
Testing
Executed Test yaml scripts and CI

Fast tracking given this is adding tests.


Scrolling code blocks can trigger swipe gestures

When scrolling left or right in a message that has a code block can cause the swipe gestures to activate and open either the Settings or Conversations dialog.

Fixed in V3.1.3
Moved swipe gestures to trigger when swiping only on the bottom input area instead of anywhere on the screen.


GivenWhenThen doesn't print when async operations are invoked in test

import org.scalatest.GivenWhenThen
import org.scalatest.flatspec.AnyFlatSpecLike
import org.scalatest.matchers.should.Matchers

import scala.concurrent.{Await, Future}

class SimpleSpec extends AnyFlatSpecLike with Matchers with GivenWhenThen {

  it should "do it with scala future" in {
    //Given
    Given("Given this")
    runFuture()

    //When
    When("that!")
    runFuture()

    //Then
    Then("ooop!")
    true shouldBe true
  }

  private def runFuture():Unit = {
    import scala.language.postfixOps
    import scala.concurrent.duration._
    import scala.concurrent.ExecutionContext.Implicits.global
    val future = Future {
      Thread.sleep(1000)
    }
    Await.result(future, 2 seconds)
  }
}

Running snippet above will print out:
testOnly *.SimpleSpec
[info] SimpleSpec:
[info] ScalaTest
[info] Run completed in 2 seconds, 339 milliseconds.
[info] Total number of tests run: 1
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[info] Passed: Total 1, Failed 0, Errors 0, Passed 1
[success] Total time: 3 s, completed Aug 17, 2020, 4:55:29 PM

So the GivenWhenThen hints are missing. What is strange when runFuture is called once it behaves ok.

Actually event calling thread sleep twice will cause the same
import org.scalatest.flatspec.AnyFlatSpecLike
import org.scalatest.matchers.should.Matchers

class SimpleSpec extends AnyFlatSpecLike with Matchers with GivenWhenThen {

  it should "do it with scala future" in {
    //Given
    Given("Given this")
    Thread.sleep(1000)

    //When
    When("that!")
    Thread.sleep(1000)

    //Then
    Then("ooop!")
    true shouldBe true
  }
}```

It was broken between 3.1.2 (works fine) and 3.1.3 (doesn't)

Got the same problem in sttp, using 3.2.1. I've got an AsyncFlatSpecLike (I can't use AsyncFlatSpec directly because of some dotty issues, but that's another story), and most of the time only some of the test results are shown on the console.
The test count is correct (in my case it's 6 tests), but only the first two or three are usually shown. The problem is when one of the subsequent test fails, as there's no way to find out what went wrong.
For example:
[info] AsyncHttpClientMonixWebSocketTest:
[info] - should send and receive three messages
[info] - should send and receive two messages (unsafe)
[info] Run completed in 1 minute, 5 seconds.
[info] Total number of tests run: 6
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 5, failed 1, canceled 0, ignored 0, pending 0
[info] *** 1 TEST FAILED ***
[error] Failed tests:
[error] 	sttp.client.asynchttpclient.monix.AsyncHttpClientMonixWebSocketTest

@adamw I just released a 3.2.2-M2, do you mind to try to see if it fixes your problem?
Cheers.

@cheeseng Yes, works fine now, thanks! That was quick :)

Version 3.2.2 resolved this for me.


docs: Add docs for AKV backed KBS deployment

Eventually I can envision the docs section has following hierarchy
docs

overview
projects

kata
guest components
kbs
caa

tutorials

kbs with akv
using encrypted container images with coco
...

concepts

Did you mean to create a sub-section called Azure under KBS docs? Because the URL and the breadcrumb on the docs don't match. There is no sub-section azure on the docs.

Did you mean to create a sub-section called Azure under KBS docs? Because the URL and the breadcrumb on the docs don't match. There is no sub-section azure on the docs. For this to happen we need one _index.md file there.

ah, no. I don't think that level of nesting is required. I moved it directly into kbs. eventually we might want to re-organize the hierarchy anyway.


[API] Support "go test"

Register test user w/o auths,
Register team/gameserver/match by test user, and delete them.

https://github.com/FlowingSPDG/get5-web-go/tree/feat/testing

Gameserver and some resources needs userid and other auths for register.
creating match and cancel match is not difficult(imo), but creating gameserver is... :/


Rhmap 11889 shared mongo connections

Motive
At the moment, fh-forms will create new mongodb connections for every environment database. Because of how mongodb connection works (it is in fact a connection pool), we are seeing excessive amount of mongodb connections created in production.
Changes
Allow set shared mongodb  connection for fh-forms to use. It the shared mongodb connections are set, they will be used (so that no new connections will be created). Otherwise it will continue to work as before.
JIRA
https://issues.jboss.org/browse/RHMAP-11889
ping @nialldonnellyfh @pb82 @sedroche

SonarQube analysis reported 5 issues:

 1 blocker
 4 minor

Watch the comments in this conversation to review them.

SonarQube analysis reported 5 issues:

 1 blocker
 4 minor

Watch the comments in this conversation to review them.

SonarQube analysis reported 1 issue:

 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Move this trailing comment on the previous empty line.

Just review this commit: e86c94611e19e2a921db36817523a3e76588de61. The other one is to fix eslint errors.

LGTM

SonarQube analysis reported 1 issue:

 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Move this trailing comment on the previous empty line.

SonarQube analysis reported 1 issue:

 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Move this trailing comment on the previous empty line.

SonarQube analysis reported 1 issue:

 1 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Move this trailing comment on the previous empty line.

published to npm:
+<EMAIL_ADDRESS>


tf.linalg.eigh yields invalid eigensystem when used inside a decorated tf.function with jitcompile=True flag

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
Yes

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Linux Ubuntu 20.04 host using docker image tensorflow/tensorflow:2.5.0-gpu

Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
N/A

TensorFlow installed from (source or binary):
docker image tag 2.5.0-gpu

TensorFlow version (use command below):
v2.5.0-rc3-213-ga4dfb8d1a71 2.5.0

Python version:
3.6.9

Bazel version (if compiling from source):
N/A

GCC/Compiler version (if compiling from source):
N/A

CUDA/cuDNN version:
/usr/local/cuda-11.2/targets/x86_64-linux/lib/libcudart.so.11.2.152
/usr/local/cuda-11.2/targets/x86_64-linux/lib/libcudart_static.a

GPU model and memory:
NVIDIA RTX 2070 8 GB

Describe the current behavior
Using the jitcompile=True flag for a decorated function that uses tf.linalg.eigh returns an incorrect solution. Removing the flag yields a correct solution. Note that this did work in TF 2.4.1 using the same code with experimentalcompile=True. It also fails for when CUDA_VISIBLE_DEVICES=-1 is to disable GPU evaluation.
Describe the expected behavior
The code snippet pasted below, which tests that the eigen system is a valid solution, should not raise an error.
Contributing - Do you
want to contribute a PR? (yes/no): - Briefly describe your candidate solution
(if contributing):
Possibly, if I can get some guidance on where the issue might be. As it stands I wouldn't know where to begin.
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
# fails both with and without this environment variable set to disable GPU evaluation
# import os
# os.environ["CUDA_VISIBLE_DEVICES"] = "-1"
import numpy as np
import tensorflow as tf

a_mat = np.array([
    [0., -1., -1.,  1.],
    [-1.,  0.,  1., -1.],
    [-1.,  1.,  0., -1.],
    [1., -1., -1.,  0.]], dtype=np.float32)

@tf.function(input_signature=[
    tf.TensorSpec(None, dtype=tf.float32)],
    jit_compile=False)
def eigh_uncompiled(arg):
    return tf.linalg.eigh(arg)

@tf.function(input_signature=[
    tf.TensorSpec(None, dtype=tf.float32)],
    jit_compile=True)
def eigh_compiled(arg):
    return tf.linalg.eigh(arg)

for eigh in [np.linalg.eigh, eigh_uncompiled, eigh_compiled]:
    val, vec = eigh(a_mat)
    # assert A.x = lambda x for eigen system
    print(tf.linalg.matmul(a_mat, vec) - val[tf.newaxis] * vec)
    if not np.allclose(tf.linalg.matmul(a_mat, vec), val[tf.newaxis] * vec, atol=1e-6):
        raise AssertionError(f'Test fails for function {eigh.__name__}')

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
N/A. Should be easy to reproduce with the above code snippet.

I was able to reproduce the issue in tf v2.5,v2.4 and nightly.Please find the gist here

As a followup, this particular test matrix seems to be a corner case but one that is actually encountered in my application. The test actually passes when the matrix under test is a randomly generated self-adjoint matrix.
For example,
g_mat = np.random.normal(0, 1, (4, 4)).astype(np.float32)
a_mat = g_mat*g_mat.T

It fails again, however, if the diagonal of the random test matrix is set to all zeros, which might be a clue:
g_mat = np.random.normal(0, 1, (4, 4)).astype(np.float32)
a_mat = g_mat*g_mat.T
for n in range(4):
    a_mat[n, n] = 0.

Hi everyone,
Just jumping in to point out this bug is not present in TF 2.4 (jit_compile is not a valid option for tf.function in TF 2.4):
import numpy as np
import tensorflow as tf

a_mat = np.array([
    [0., -1., -1.,  1.],
    [-1.,  0.,  1., -1.],
    [-1.,  1.,  0., -1.],
    [1., -1., -1.,  0.]], dtype=np.float32)

@tf.function(input_signature=[
    tf.TensorSpec(None, dtype=tf.float32)],
    experimental_compile=False)
def eigh_uncompiled(arg):
    return tf.linalg.eigh(arg)

@tf.function(input_signature=[
    tf.TensorSpec(None, dtype=tf.float32)],
    experimental_compile=True)
def eigh_compiled(arg):
    return tf.linalg.eigh(arg)

for eigh in [np.linalg.eigh, eigh_uncompiled, eigh_compiled]:
    val, vec = eigh(a_mat)
    # assert A.x = lambda x for eigen system
    print(tf.linalg.matmul(a_mat, vec) - val[tf.newaxis] * vec)
    if not np.allclose(tf.linalg.matmul(a_mat, vec), val[tf.newaxis] * vec, atol=1e-6):
        raise AssertionError(f'Test fails for function {eigh.__name__}')

tf.Tensor(
[[ 0.0000000e+00  0.0000000e+00  0.0000000e+00  0.0000000e+00]
 [-2.9802322e-08  0.0000000e+00  0.0000000e+00  0.0000000e+00]
 [-5.9604645e-08  0.0000000e+00  0.0000000e+00  0.0000000e+00]
 [ 0.0000000e+00  0.0000000e+00  0.0000000e+00  0.0000000e+00]], shape=(4, 4), dtype=float32)
tf.Tensor(
[[ 1.7881393e-07 -1.4901161e-08  0.0000000e+00 -2.3841858e-07]
 [-1.7881393e-07  0.0000000e+00 -1.4901161e-08  2.3841858e-07]
 [-1.4901161e-07  0.0000000e+00  0.0000000e+00  2.3841858e-07]
 [ 0.0000000e+00  0.0000000e+00  0.0000000e+00  4.7683716e-07]], shape=(4, 4), dtype=float32)
tf.Tensor(
[[ 8.9406967e-08 -1.1920929e-07 -1.1920929e-07  2.3841858e-07]
 [-8.9406967e-08  1.1920929e-07 -1.1920929e-07 -2.3841858e-07]
 [-1.1920929e-07 -5.9604645e-08  0.0000000e+00 -1.1920929e-07]
 [ 1.1920929e-07 -5.9604645e-08  0.0000000e+00  1.1920929e-07]], shape=(4, 4), dtype=float32)

Based on the fact that jit_compile is an XLA thing, the issue probably somewhere in the eigh kernel generated by XLA? Though, the issue is not present in JAX:
from jax import jit
import jax.numpy as jnp
import numpy as np

a_mat = np.array([
    [0., -1., -1.,  1.],
    [-1.,  0.,  1., -1.],
    [-1.,  1.,  0., -1.],
    [1., -1., -1.,  0.]], dtype=np.float32)

@jit
def eigh_jit(arg):
  return jnp.linalg.eigh(arg)

val, vec = eigh_jit(a_mat)
print(jnp.matmul(a_mat, vec) - jnp.expand_dims(val, axis=0) * vec)
if not np.allclose(jnp.matmul(a_mat, vec), jnp.expand_dims(val, axis=0) * vec, atol=1e-6):
  raise AssertionError(f'Test fails for JAX')

But I believe JAX uses a Custom Call for it's eigh implementation rather than something else.
Is it possible this issue is related to the addition of eigh_expander.h by @hawkinsp in March (https://github.com/tensorflow/tensorflow/commits/master/tensorflow/compiler/xla/service/eigh_expander.h)?

I agree, this is a bug. I will look into it. Something looks off about the 2x2 Jacobi rotations generated for this special case.
Note that this code path isn't a particularly good one to be using on CPU or GPU, so even if I fix this issue, you should not expect good performance from it on those platforms. TF needs to do the same thing JAX does here (call into an optimized kernel).

This should now be fixed at head.


Refering to an empy package cpprestsdk

The link to cpprestsdk is stale.
Package revoked by creator and it no longer contains any information.
Refered files mentioned on this page are missing in the package.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c7064d86-7de7-1a58-393b-39a5281a9617
Version Independent ID: 8efa557b-8b1e-6320-4640-5226b8983832
Content: Creating Native NuGet Packages
Content Source: docs/guides/Native-Packages.md
Product: nuget
GitHub Login: @JonDouglas
Microsoft Alias: jodou

Yes, it appears that the package has been unlisted by the owner on NuGet.org. @JonDouglas, @clairernovotny (author and recent editor) -- do we know if there is an alternative to this package? No deprecation status is set on the package so it's hard for users to find an alternative.

The current page points to WebView2, is this issue still unresolved?
https://github.com/NuGet/docs.microsoft.com-nuget/blob/main/docs/guides/Native-Packages.md

Looks like it it workable now. It needs any visitor to pay attention to the details and look in the new versions tab.


Update to most recent array-api commit

Closing as addressed in https://github.com/data-apis/array-api-tests/pull/213, which uses the work here—thanks again @jakevdp and let me know if this sorts out https://github.com/data-apis/array-api/issues/631


Bugfix for PF as start of identifier name

Can you add some tests? A test in LexerForIdentifiersShould that tests that e.g. PF2-KEY is lexed as identifier would make sure that we don't break the fix in the future :)


How to set PM time

Hello again, I want to simulate scenario start time which takes place in afternoon/night (PM time). However if I enter this time after -t attribute in 24-hour format (e.g. 16:00), I got error message that max. value is 12:00. Is there some way, how to specify, that we want AM or PM time?
Thank you!

Use -T option.

Great, thanks!!

Hello, I've been trying to download the gps-sdr-sim.zip file but it's missing from the release link. Could someone please send me the file? I've tried everywhere to try to find the file but with no luck!
My email is<EMAIL_ADDRESS>If someone can send me the files I would be very greatful! Or if someone could point me to where the files are to download that would be helpful too!


feat(primitives): add is_empty to Withdrawals

the struct already implements Deref, why do we need this?

It's already got that from Deref


Compile dependency on actual stack images

The dependency that this buildpack provides (MRI) is compiled on an image that isn't actually the stack image. This could result in subtle bugs - like features not being enabled or enabled features not being available at run-time - due to differences in configuration and available libraries. We should compile the dependency on the actual stack base image rather than a similar image.

Since you specifically call out feature availability at run-time, I assume you want the dependency compiled on a stack run image?
Separately, the Ruby buildpack can run on the Base stack, but even the Base stack build image doesn't have all of the packages we install for compilation. This means we have to compile against the Full stack image, even though this dependency should in theory work on the Base stack. Thoughts?

No, it has to be the build image because we need the compilers and headers etc, and the run image doesn't have those (by design).
And yes I agree that it probably has to be the full stack to ensure we compile against all the libraries.

We could also explore supporting multiple versions of Ruby - one compiled against the base stack and one against the full stack. But that's a lot of extra surface area so I'd want to ensure that this would provide enough value to be worth the effort.

Makes sense, thank you for the context!

I'd say we should also test against the stack image for completeness

I think #453 is sufficient to close this out.


Split systests from go-spacemesh node

Motivation
Separates system tests from go-spacemesh node code.
Changes

systests is now its own module that depends on github.com/spacemeshos/go-spacemesh
the dependency to the node is replaced to always point at the node code of the same commit (otherwise we would need to keep go.mod in systests updated with every commit to the repository)

Test Plan
existing tests pass
TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed
[x] Update changelog as needed

bors try

bors try

bors try

what is the advantage of splitting?

Mostly a smaller list of dependencies for the node code and clearer separation of what are system tests and what is node code.
We could use libraries in system tests that don't support windows and mac is probably the biggest advantage (although not needed at the moment).

I found the PR that originally merged the two modules into one:
https://github.com/spacemeshos/go-spacemesh/pull/3260
It looks like the reason they were merged was to be able to use go-spacemesh code in system tests (without constantly needing to update a dependency). This can also be achieved with a replace statement.

using replace is suboptimal. to me this is a change of workflow without clear benefit....

so my workflow is that i'll build a image for go-sm A and a image for systest A
but as i progress with development, go-sm image will keeping changing (B, C, D...) but will continue to use systest A.

so my workflow is that i'll build a image for go-sm A and a image for systest A but as i progress with development, go-sm image will keeping changing (B, C, D...) but will continue to use systest A.

While I think that this should also be possible with splitting the codebase into two modules, I'll close the issue for now. There are no immediate benefits to make the change.

@countvonzero
Why is using replace suboptimal? It doesn't require any action on developer side.
@fasmat Wouldn't go workspace help here?

Go workspaces would help for local development, such that the system tests are always compiled with the local version of go-spacemesh rather than the version specified in go.mod - they essentially auto-add replace between modules referenced in the workspace automagically.
go.work and go.work.sum however in my opinion do not belong into the repository, since they are only intended for local workspaces. I think that a single replace here is correct. This should not break the workflow @countvonzero is describing: building the system tests once and rebuilding the node code multiple times after.
It guarantees that systest is always built with go-spacemesh of the same commit (same as it is now). Additionally it would prevent using systest code outside the systest module (would introduce a cyclic dependency) which I think would be a small benefit of splitting the two.


Improved accept header for swagger request.

Outsourced code for swagger creation, so that duplicate code is
reduced.
Changed path annotations of getListingJson and getListingYaml and a
new methods that supports swagger with .yaml or .json at the end.
Through this swagger now supports 3 ways to request the documentation.
/swagger , /swagger.json & /swagger.yaml This way URL-based negotiation
(http://docs.jboss.org/resteasy/docs/2.3.7.Final/userguide/html/JAX-RS_Content_Negotiation.html#media_mappings)
of RESTeasy works, if a media type mapping from .json to
application/json is configured.

@MarvGilb - unfortunately the build is failing. Can you have a look?


[WIP] ITE SuperIO fan control

Mostly working fan control for ITE SuperIOs

There are some issues however.

I can't figure out how to add the F#Md key without messing up all the SMC fan keys. For this reason it's commented out and it's not possible to restore automatic fan control by motherboard unless you reboot.
Hardcoded RPM ranges.
Control index doesn't always match the tachometer index which you can see in my screenshot (Fan Main uses control of Fan 2).
Possible issues with code structure/style

So far it's only been tested on my Gigabyte B75M-D3H (IT8728F) but it should work on most ITE SuperIOs. I've used LibreHardwareMonitor's code to as a reference for the registers, etc.
I'm also looking for suggestions of how to expose configuration (rpm/pwm curve, correcting index, hiding fans, etc). Currently planning on doing something similar to how it's done for EC Device

Are you sure you add the SMC keys in ASCII sorted order? This is a documented requirement. I think x goes before d, thus adding keys in the wrong order corrupts VSMC.

As for configuration, I think your best is injecting device properties into the EC device. Could you please outline the suggestions you have in mind, and I guess we can handle it.

@vit9696

Are you sure you add the SMC keys in ASCII sorted order? This is a documented requirement. I think x goes before d, thus adding keys in the wrong order corrupts VSMC.

That worked thanks, finally fixed it and can restore system fan control.

As for configuration, I think your best is injecting device properties into the EC device. Could you please outline the suggestions you have in mind, and I guess we can handle it.

Here is my suggestion. # will be the fan index.

fan#-pwm: RPM corresponding to PWM value (0 to 255) separated by semicolon. Example 900,0;1200,130;1600,255. Default value will be 0,0;3200,255 which will function identical to the current state of it. It could be possible to automatically generate this if manually entering a few values doesn't give enough precision.
fan#-control: Index of control this fan will use, if not set it will default to the fan index.
fan#-hide: Hides this fan if present.

That sounds about right, I am not sure whether this should be just fan to avoid conflicts, but we can rename later if needed. What approximation formula do you plan to use for value interpolation?

@vit9696 Hi I was able to successfully implement everything I said

I'm just using linear interpolation for figuring out the PWM values, works good just need to pre-compute them before to reduce overhead from nested loop every time value is set.
uint8_t getCurveValue(uint8_t index, uint16_t rpm) {
   for (int i = 0; i < 256; ++i) {
	if (_pwmCurve[index][i] < rpm || _pwmCurve[index][i] == UINT16_MAX)
	  continue;

	for (int j = i - 1; j >= 0 ; --j) {
	  if (_pwmCurve[index][j] > rpm || _pwmCurve[index][j] == UINT16_MAX)
		continue;

	  return (((double)(rpm - _pwmCurve[index][j]) / (double)(_pwmCurve[index][i] - _pwmCurve[index][j])) * (i - j)) + j;
	}
	return 0;
  }
  return 255;
}

You can probably see in my screenshot that PWM/RPM curve of the fan isn't exactly linear so the values are off, need to add more values to the fan#-pwm so that it's correct. Can probably make a program that automatically generates these curves.
Shouldn't some of this code be shared in SuperIODevice though ? So that's it's easier to implement PWM curve for other SuperIOs

Even when using a manually created 8 point curve it's quite accurate.

Probably will add a tool to automatically generate the PWM/RPM curves

A tool might make some sense I guess, yeah.

@vit9696 I plan on making it into an external tool like smcread etc. Having generation of rpm/pwm curve built into the driver is a bad idea yeah and I don't plan on doing that.

I've added fanpwmgen which will generate fan#-pwm curves, not the most accurate atm due to lack of averaging but works good enough. Also fixed issues with SMCWrite in smc command while doing it.
VirtualSMC fan#-pwm generation tool
Usage:
./fanpwmgen [options]
    -f <num>   : the fan number to use
    -s <steps> : number of steps to use when generating curve, default 16 and max 256
    -t <time>  : time to wait before going to next step, default 2 seconds
    -h         : help

Probably need to move the fan#-pwm stuff out of ITEDevice so if anyone wants to implement for Nuvoton they can use it. And write also docs for this (could be an optional post install step too once it's polished enough)

I was also considering adding voltage reading because it's easy to read raw voltages. But every motherboard uses different input resistance, reference resistance and reference voltage.
LibreHardwareMonitor has a list of them for many motherboards though https://github.com/rikroe/LibreHardwareMonitor/blob/master/LibreHardwareMonitorLib/Hardware/Motherboard/SuperIOHardware.cs
It would probably be too much configuration to expose with DeviceProperties so instead would need to use a .plist "SuperIO layout" which could also contain fan hide/control layout. So I dropped that idea because it would be alot of effort to expose the configuration.

For voltages we thought of going the tool way. I.e. we built a database here: https://github.com/CloverHackyColor/HWMonitorSMC2/tree/master/LPC

HWMonitorSMC2 does work for me, have to make configuration for it though. But it seems like the project is dead as PRs are no longer being answered and last update is from 2020.

That's a difficult question, perhaps somebody needs to take over.

@xCuri0 can you make this work for Nuvoton chips as well?

@Lorys89 If I do upgrade to a newer motherboard with Nuvoton chip yes.
You should try looking at the LibreHardwareMonitor source it's not too hard to adapt it here.

Working fan control for ITE SuperIOs

There are some issues however.

~I can't figure out how to add the F#Md key without messing up all the SMC fan keys. For this reason it's commented out and it's not possible to restore automatic fan control by motherboard unless you reboot.~
~Hardcoded RPM ranges.~
~Control index doesn't always match the tachometer index which you can see in my screenshot (Fan Main uses control of Fan 2).~
Possible issues with code structure/style

So far it's only been tested on my Gigabyte B75M-D3H (IT8728F) but it should work on most ITE SuperIOs. I've used LibreHardwareMonitor's code to as a reference for the registers, etc.
~I'm also looking for suggestions of how to expose configuration (rpm/pwm curve, correcting index, hiding fans, etc). Currently planning on doing something similar to how it's done for EC Device~.
Configurable through fan#-hide (hide fan), fan#-control (set control index) and fan#-pwm (pwm curve)

can add fan#-pwm to ECDeviceGeneric for fixing max RPM and Min RPM ?
Just for beter filling

@xCuri0 Hello, sorry for bothering you. I have a Razer Blade 15 2018 Advanced Laptop and it has a SuperIO ITE IT8390E chip (I use HWInfo64 software on Windows to see it). I tried based on your commit to add the SuperIO ITE IT8390E chip but I failed. Even though I added it to ITEDevices.cpp, add SMCSuperIO/Resources/IT8721F.plist. I read through LibreHardwareMonit and saw that Razer seems to use a different Controller to control the fans. Was wondering if you could add it or pick me up any tips or instructions so I can add my device to SMCSuperIO. or I did something wrong or am missing something, please let me know. Thank you very much.


unable to update

Microsoft PowerToys version
0.70.1
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
Installer
Steps to reproduce
Problem description: It seems that the software update cannot be performed properly using the Chinese network. It will prompt “尝试安装此更新时出错”, which means "Error attempting to install this update" in English. Unfortunately, I may not be able to upload images or logs due to network issues
I come from China and I am not sure if it is due to network issues that the update cannot be updated. I have enabled an accelerator (network proxy tool) for GitHub only, but it has not had any practical effect. Due to Chinese laws and regulations, I cannot use a VPN tool that can accelerate all applications.
So, I hope to solve network issues in some regions or other bugs in the program that prevent updates, or to inform me how to solve this problem
THANKS!
✔ Expected Behavior
Can update the program normally
❌ Actual Behavior
Always prompt that the download is in progress or that it cannot be downloaded. In fact, after being measured by network measurement tools, the download did not occupy any of my network, or the speed was very slow (in rare cases)
Other Software
No response

I have seen previous questions regarding this issue, including the title of "CDN". But I did not understand the content commented by the relevant personnel. Using "winget install XP89DCGQ3K6VLD" cannot be installed and will report an error “找不到可用的升级。
配置的源中没有可用的较新的包版本。”English is
Unable to find an available upgrade.
There are no newer package versions available in the configured source

winget install XP89DCGQ3K6VLD links to the store. Can you try the winget install flow proposed in this doc:
https://github.com/microsoft/PowerToys#via-winget

/needsinfo


Open hyperlinks in new tab

Closes #3467
PR Checklist

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Fixes
Issue Number: #3467
What is the current behavior?
Hyperlinks in markdown (markdown files, content description, about page) open in same tab
What is the new behavior?
Hyperlinks in markdown open in new tab
Other information

Thanks for this. Sorry it was left for so long. Just finished up with a desktop release


Labels statistics for bugs and enhancements

Label statistics for bugs and enhancements
Introduced /labels/bugs and /labels/enhancements endpoints to produce labels stats for bugs and enhancements in csv format
issues.html enhanced with JS code to read csv data from endpoints and present them using DataTables (https://datatables.net/)
Bootstrap 4 and Semantic UI variant of the table are present in the PR (please checkout 9625c73 or
3261c67). I like Bootstrap 4 variant more, Semantic UI is already used by quarkus-status so I prepared that variant too.
csv_to_html_table.js taken from https://github.com/derekeder/csv-to-html-table, csv-to-html-table is the main inspiration, but I didn't want to use the legacy bits from there.

semanticui

Bootstrap 4 (nicer sort arrows, grey/white rows in the table, smaller search field)

@gsmet PR updated, semanticui based, using grey/white rows in the table, .min variants ensured on js files

@gsmet any comments regarding the PR?

Does the label link point to the opened issues? I will merge anyway but I think we need a link to the opened issues. If it's already the case then perfect :).

OK, I just saw it's pointing to the open issues. Perfect.
I pushed the new version to production.


upd README : remove double word

Quite a good joke, right after recursively, but not neccessarily needed here.

Great, thanks a lot!
Kjetil


self_accessor caused broken replacement

With PHP CS Fixer 2.14.1 Sunrise by Fabien Potencier and Dariusz Ruminski (2e82abd)

   1) /Users/glen/scm/eventum/eventum/lib/eventum/class.project.php (self_accessor)

diff --git a/lib/eventum/class.project.php b/lib/eventum/class.project.php
index bfd2ac0ff..6fe26fec4 100644
--- a/lib/eventum/class.project.php
+++ b/lib/eventum/class.project.php
@@ -1088,6 +1088,6 @@ class Project

         return $repo
             ?: $repo = Doctrine::getEntityManager()
-                ->getRepository(Entity\Project::class);
+                ->getRepository(Entityself::class);
     }
 }

basically class in root namespace:

use Eventum\Model\Entity;

class Project {
}

referenced Entity\Project::class which got replaced with Entityself::class.

i'm sorry, in what version this is supposed to be fixed? still broken with 2.14.2

The last phar releases are from 17 Feb., this fix is from after that I think. So it is fixed in all supported branches, but no releases have been made from these for a while.


ModuleNotFoundError: No module named 'MalmoPython'; pip install python 3.7 macOS Mojave

Thanks for your work on malmo! I am trying to do a clean install with pip using python 3.7 on macOS Mojave. I am following these instructions.
When attempting to run the example script, I encounter the following error:
ModuleNotFoundError: No module named 'MalmoPython'
Here are steps to reproduce what I am seeing after doing the prerequisites.
Toms-MacBook-Pro-3:phd tom$ mkdir minecraft_clean
Toms-MacBook-Pro-3:phd tom$ cd minecraft_clean/
Toms-MacBook-Pro-3:minecraft_clean tom$ pyenv local 3.7.0
Toms-MacBook-Pro-3:minecraft_clean tom$ virtualenv venv --no-site-packages
Using base prefix '/Users/tom/.pyenv/versions/3.7.0'
New python executable in /Users/tom/phd/minecraft_clean/venv/bin/python3.7
Also creating executable in /Users/tom/phd/minecraft_clean/venv/bin/python
Installing setuptools, pip, wheel...
done.
Toms-MacBook-Pro-3:minecraft_clean tom$ source venv/bin/activate
(venv) Toms-MacBook-Pro-3:minecraft_clean tom$ pip install malmo
Collecting malmo
  Using cached https://files.pythonhosted.org/packages/a5/12/71cfbf665a6b4c98e329691d738884721412072d08006e71367e3963dc4b/malmo-<IP_ADDRESS>-cp37-cp37m-macosx_10_13_x86_64.whl
Installing collected packages: malmo
Successfully installed malmo-<IP_ADDRESS>
(venv) Toms-MacBook-Pro-3:minecraft_clean tom$ python -c 'import malmo.minecraftbootstrap; malmo.minecraftbootstrap.download()'
Cloning into 'MalmoPlatform'...
remote: Enumerating objects: 44, done.
remote: Counting objects: 100% (44/44), done.
remote: Compressing objects: 100% (29/29), done.
remote: Total 15280 (delta 18), reused 34 (delta 15), pack-reused 15236
Receiving objects: 100% (15280/15280), 28.14 MiB | 9.85 MiB/s, done.
Resolving deltas: 100% (9888/9888), done.
Please make sure you set the MALMO_XSD_PATH environment variable to "/Users/tom/phd/minecraft_clean/MalmoPlatform/Schemas"!
(venv) Toms-MacBook-Pro-3:minecraft_clean tom$ export MALMO_XSD_PATH=/Users/tom/phd/minecraft_clean/MalmoPlatform/Schemas
(venv) Toms-MacBook-Pro-3:minecraft_clean tom$ python -c 'import malmo.minecraftbootstrap; malmo.minecraftbootstrap.launch_minecraft()'
Nothing is listening on port 10000 - will attempt to launch Minecraft from a new terminal.
Giving Minecraft some time to launch...
(venv) Toms-MacBook-Pro-3:minecraft_clean tom$ python -c 'from malmo.run_mission import run; run()'
Traceback (most recent call last):
  File "/Users/tom/phd/minecraft_clean/venv/lib/python3.7/site-packages/malmo/run_mission.py", line 32, in <module>
    import MalmoPython
ModuleNotFoundError: No module named 'MalmoPython'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/tom/phd/minecraft_clean/venv/lib/python3.7/site-packages/malmo/run_mission.py", line 35, in <module>
    import malmo.MalmoPython as MalmoPython
ImportError: dlopen(/Users/tom/phd/minecraft_clean/venv/lib/python3.7/site-packages/malmo/MalmoPython.so, 2): Library not loaded: /usr/local/opt/boost-python3/lib/libboost_python37-mt.dylib
  Referenced from: /Users/tom/phd/minecraft_clean/venv/lib/python3.7/site-packages/malmo/MalmoPython.so
  Reason: image not found

I understand from the documentation that this error can occur when attempting to build from source, but I am not -- I am installing with pip.
Thanks for your help!

I recently built a new binary release which may work for you: https://github.com/microsoft/malmo/releases/download/0.37.0/Malmo-0.37.0-Mac-64bit_withBoost_Python3.7.zip. The wheel seems to no longer find dependencies that used to be installed with boost.

Thanks! I am making do with malmoenv for now. It would be good to put a note in the documentation in case others try to pip install malmo in the meantime.

There's a new native wheel for MacOS for Python 3.7. It may work for you - if not some investigation of missing dependencies (boost python most likely), for example running ldd on MalmoPython.so would be helpful.

I'm closing this due to inactivity - if there is still an issue that needs resolving, please reopen and provide more details, thanks!


If MQTT broker disconnects, we are not reconnected

These messages appear in the log:
[ERROR] PublishAttributes: the Client has not yet connected to the Server

We should try to reconnect MQTT if the connection breaks.

This now has a workaround.
Leaving this open until Hautomo's homeassistant library fixes this. As a bonus when importing fix we'll import the library instead of ad-hoc copying it like we've done now.


Popover trigger="outsideClick" not closes popover when clicking on bs.dropdown

Bug description:
I'm using a uib-popover with outsideClick trigger. The popover outsideClick trigger works just fine until you click dropdown element. So the problem is then you open a popover and try to click dropdown element popover should disappear and now its not.
Link to minimally-working plunker that reproduces the issue:
plnkr
Steps to reproduce the issue:
Click link to open a popover
Click dropdown button
Popover should disappear and now its not.
Version of Angular, UIBS, and Bootstrap
Angular: 1.6.3
UIBS: 2.5.0
Bootstrap: 3.3.7

popup catches the event.
You can solve this by doing something like...
  $scope.clickPopupClickOutside = function() {
    angular.element(document).click();
  }

        <button ng-click="clickPopupClickOutside()" class="btn btn-default dropdown-toggle" type="button" data-toggle="dropdown">Dropdown


OSD-5885 Introduce daemonset config image customization

This is a prod equivalent PR for #4352 which has been successfully trialled in staging.
Refs OSD-5885.

Just putting a hold on to ensure it doesn't get accidentally merged until openshift-ansible-private has changes applied to its prod branch.
/hold

Just putting a hold on to ensure it doesn't get accidentally merged until openshift-ansible-private has changes applied to its prod branch.
/hold

@mwoodson :+1: #4352

@mwoodson :+1: #4352

/hold cancel

/hold cancel


CNF-15570: Refactor pool fetcher and handler

This moves certain parts of the resource pool fetcher into the handler so that it comparable to the structure/relationship between between the resource fetcher/handler.  This is to facilitate using both handlers directly from the new resource server implementation without needing to add an adaptation layer over them.

/lgtm
/approve


ENH/DOC: Speed up deconvolve

Generating zeros array and changing the first value to 1 is faster than generating ones array and changing all but the first to zero.
Also note that this uses inverse filtering technique

Agreed, thanks.
It's good either way, but have you experienced some practical advantage with this change? Maybe using one very long signal and one short one, or doing lots of deconvolutions?

No, I just noticed it and thought it was odd.

Merged, thanks!


cherry-pick fix array_apply function return wrong result (#28133)

Proposed changes
pick from master #28133
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Need skip for a certificate check in notifications

I try use notifications hook with self-signed certificate, but when an event triggered registry service throw the error
 x509: certificatesigned by unknown authority, retrying"

I tried use add certificate to trusted and update it with update-certificate-ca but it's no effect. Error still occur.
# update-certificate-ca
Warning! Cannot copy to bundle: /usr/local/share/ca-certificates/extra
WARNING: ca-cert-users.pem does not contain exactly one certificate or CRL: skipping
WARNING: ca-certificates.crt does not contain exactly one certificate or CRL: skipping

This is my config for notifications
notifications:
  events:
    includereferences: true
  endpoints:
    - name: my-notifier
      disabled: false
      url: https://notification-service/events
      headers:
        Authorization: [Basic YWRtaW46c3VwZXItc2VjcmV0] # 'admin:super-secret' base64 encoded string
      timeout: 1s
      threshold: 5
      backoff: 3s
      ignoredmediatypes:
        - application/octet-stream
      ignore:
        mediatypes:
          - application/octet-stream

In spite of this push/pull and login works without problems.
How can I skip security check for self-signed certificates in notifications?
Use docker image registry:v2 registry version="v2.8.1"

The problem not in registry, but base image OS (Debian) of registry. I was should add my self-signed certificate to trusted CA.
I tried add in to  /usr/local/share/ca-certificates/extra and then do update-certificate-ca but get error described above.
The same issue discussed in this issue and fixes with this:
put the certificate directly in /usr/local/share/ca-certificates (no sub directory).
After that i restarted registry container and issue gone.
I think it isn't good way, because require action inside a container each time after one created.
Better way will add some insecure_skips option  for notifications sink or will add option for add a certificate to CA pool in HTTPS client (which will allow override default transport).


add formula for Domoticz

As mentioned in PR #36789 on Homebrew/homebrew, by lack of release
tarballs this formula belongs in Homebrew/homebrew-head-only.
Feedback on the original PR has been fixed.

Looks like @BrewTestBot got stuck on this one. (But I'm not versed in the ways of the Brew test bot.)

@BrewTestBot test this please

Some other things the bot highlighted need fixing as well:
==> brew style domoticz

1 file inspected, no offenses detected
Error: 3 problems in 1 formula

==> audit problems
homebrew/head-only/domoticz:
 * Formula should have a desc (Description).
 * 17: Trailing whitespace was found
 * 18: Trailing whitespace was found

==> brew test --verbose Homebrew/head-only/domoticz			 FAILED
Testing homebrew/head-only/domoticz
==> /usr/local/Cellar/domoticz/HEAD/opt/domoticz/domoticz -h
libc++abi.dylib: terminating with uncaught exception of type boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::lock_error> >: boost: mutex lock failed in pthread_mutex_lock: Invalid argument
Error: homebrew/head-only/domoticz: failed
<0> expected but was
<nil>.

Closing as dead. Please open a new updated PR if you'd like to.

Just if someone is trying to build domoticz manually or with the formula which was started here. Have a look at http://domoticz.com/wiki/Mac_OS_X#Homebrew , there is more up to date information


Add command to support registering the Kubernetes tentacle as an Octopus worker

Background
We would like to support running the Kubernetes Agent as a worker. This PR embodies the proposed solution in this Tentacle RFC.
[sc-82021]
Associated PRs

Helm chart
Octopus.Client (dependency)

Results

Introduces a RegisterKubernetesWorkerCommand, following a similar pattern to how the agent is currently registered as a deployment target
Deprecates the existing RegisterKubernetesClusterCommand and rebrands it as RegisterKubernetesDeploymentTargetCommand as we want to be clear in the distinction between the two (the functionality is preserved)
Modified configure-and-run.sh script for the Kubernetes agent to optionally select from either worker or deployment target (but not both)

The Octopus E2E tests that cover this change are in this PR
Teamcity test results
The tests cover both usage as worker (new feature) and deployment target (regression testing).


undeploy tools version of website to avoid confusion

tools.wmflabs.org/wigi/ now redirects to http://wigi.wmflabs.org/


Split commands for optimizing time

Questions
Answers

Description?
Split commands for optimizing time

Type?
improvement

BC breaks?
no

Deprecations?
no

Fixed ticket?
N/A

Sponsor company
@PrestaShopCorp

How to test?
N/A

Thanks @Progi1984


.idea folder

It appears we are not really using it in our workflow in a way that it needs to be shared under version control, right? If so, let's remove it.

The folder is listed in gitignore, do you mean it is not being properly ignored?

Keeping the folder on the repo but ignoring it in version control


Linux? (Question)

I use linux and was wondering if there will be a version that works for linux gamers/users?
I tried to use wine but that just breaks things and doesn't work at all and leaves me to making a windows10 VM JUST to use gibbed.
If developing a version for linux as a project isn't going to happen..Do you or anyone else know of an alternative?
(that either works with wine or just works with linux. (I use manjaro/arch).
(off topic)
PS: I'd play BL3 but that game just feels worse than BL2 and BL1. I like feeling like a badass vaulthunter looking for loot on planets, etc. Not some side character in a bigger story that honestly feels meh.  So that's why I am asking this question and why I'm back to BL2.

Hi, I just got it working with wine. The clue is that you need to install dotnet40 into your wine prefix via winetricks.
Here's what I did to get it to run:

WINEARCH=win32 WINEPREFIX=/home/YOURUSER/Downloads/bl2-gibbed/winePrefixBL2Gibbed wine /home/YOURUSER/Downloads/bl2-gibbed/Gibbed.Borderlands2.SaveEdit.exe    (command perhaps not needed, I just use it to create the prefix)
WINEARCH=win32 WINEPREFIX=/home/YOURUSER/Downloads/bl2-gibbed/winePrefixBL2Gibbed winetricks dotnet40
WINEARCH=win32 WINEPREFIX=/home/YOURUSER/Downloads/bl2-gibbed/winePrefixBL2Gibbed wine /home/YOURUSER/Downloads/bl2-gibbed/Gibbed.Borderlands2.SaveEdit.exe

Hope this helps you. Of course you need to change the paths to your liking. I like to put the wine prefix next to the application.
I would also recommend creating a symbolic link or mount to your '/steamapps/compatdata/49520/pfx/drive_c/users/steamuser/My Documents/my games/borderlands 2/willowgame/' in the Documents, so that you can access it easily.

I did a quick test too and concluded that WPF seems to be the problem. At least at first glance and I did not look any deeper.
Steps to reproduce:
run it with mono
mono Gibbed.Borderlands2.SaveEdit.exe

Unhandled Exception:
System.IO.FileNotFoundException: Could not load file or assembly 'PresentationFramework, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies.
File name: 'PresentationFramework, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
[ERROR] FATAL UNHANDLED EXCEPTION: System.IO.FileNotFoundException: Could not load file or assembly 'PresentationFramework, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies.
File name: 'PresentationFramework, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'

Not sure if this is any help for non-steam users, but GE Proton seems to be able to run Gibbed.Borderlands2.SaveEdit.exe just fine right out of the zip archive. For steam users, just add that .exe as a non-steam game and set compatibility to GE-proton.


[Bug] CWD option escaped improperly on Windows

When CWD is not present, a general warning says that Warning: c:devMyPath: No such file or directory. As you can see, no slashes are present.
Setting "cwd": "C:/dev/My/Path" or "cwd": "C:\\dev\\My\\Path" produces the same message. However, setting it to "cwd": "C:/dev/My/Path/" (note trailing slash) ends up as
Failed to run command `environment-directory "C:\dev\My\Path\"`: Problem parsing arguments: environment-directory "C:\dev\My\Path\"
An error occured: Problem parsing arguments: environment-directory "C:\dev\My\Path\"

Not fluent enough in TypeScript to fix it I'm afraid.

I suppose setting it to "cwd": "C:\\\\dev\\\\My\\\\Path" works though, right? Because GDB/MI probably has escaped strings and i just pass what the json gives me. Replacing \ with \ should fix it already in the code

Yes, that is correct.
Perhaps offtopic, but what difference should environment-directory do?

good question, i think it doesn't do anything. Its just implemented so gdb will show you if you have an invalid cwd

Should be fixed


problems registry 2.0 with S3 backend and IAM instance profiles

According to a comment in the S3 driver, instance profiles should work, but this I'm having problems with it.
The driver config and environment variable overrides are pretty finicky, but  I managed to get it working if I set the access/secret keys in REGISTRY_STORAGE_S3_SECRETKEY and REGISTRY_STORAGE_S3_ACCESSKEY. Finicky because it looks like for s3 to work, bucket and region must be set with the config file only (env variable override doesn't seem to work fully).
Anyways, the goal is to use instance profiles, so I tried not setting access and secret key in a variety of ways:

Setting REGISTRY_STORAGE_S3_SECRETKEY and REGISTRY_STORAGE_S3_ACCESSKEY variables to empty
Setting accesskey and secretkey to empty in the config file
Unsetting REGISTRY_STORAGE_S3_ACCESSKEY and REGISTRY_STORAGE_S3_ACCESSKEY. Ie, removing them from the environment.

In cases 1 and 2 I get this error:
panic: The AWS Access Key Id you provided does not exist in our records.

In case 3 I get:
panic: Access Denied

This is the bash history for each of these cases.
Thanks :)

@tiadobatima The correct configuration for this is to not set the environment variables or the configuration values. Either way, if they are empty, they will be resolved through the instance credentials. These are checked on startup with a round trip to the backend, which is why we see a panic.
I would recommend that you check to ensure the instance profiles are accessible from the registry. The code that resolves this is GetInstanceProfiles. If that seems normal, double check your s3 configuration and access keys in another tool to see if they are working correctly.
cc @BrianBland @AndreyKostov

Hey guys, so this line:
https://github.com/docker/distribution/blob/master/registry/storage/driver/s3/s3.go#L202
should properly get an auth token if either the secret key or the access key is empty.
Here's the GetAuth code that does this
https://github.com/AdRoll/goamz/blob/b0a456ecbd5367f922900045462906715ca794a5/aws/aws.go#L346
if you look at it, you'll notice that it has to reach that line and it will do so if either access key or secret key are empty strings. My guess then is that in the s3 driver code, the secret key and access key parameter are somehow not empty strings, even when you go out of your way not to set them. Maybe trace the code for how they get there see what they are at the s3 driver level in debug mode?

It's possible that setting the access key and secret key as empty config variables or environment variables makes them nil valued in the driver parameters map. On this line, they would then be converted to the string value "<nil>", so we might want to handle nil more gracefully.
Given your scenario 3, I'd definitely recommend validating that the instance has valid role credentials.
The following command should output the role name associated with the instance (if any):
curl http://<IP_ADDRESS>/latest/meta-data/iam/security-credentials/

And to retrieve a credentials pair, you can then hit the endpoint for that role name:
curl http://<IP_ADDRESS>/latest/meta-data/iam/security-credentials/<role_name>

Thanks guys!
From the 3 scenarios I described just 1 and 2 are actually valid (and related). As @BrianBland mentioned, it indeed looks like a nil type of problem... python loads empty yaml dict keys as None, so I imagine go must do something similar.
It would be more user friendly to fallback to IAM instance credentials if the environment variables or the config keys exist but are empty. Or at least update the docs for now.
The 3rd scenario was a problem with my IAM instance profile policies (I was just giving list permissions to the folder).
Regarding the problem with overriding the default config with the environment variables, it looks like I'm not the only one:
REGISTRY_STORAGE_S3_BUCKET and REGISTRY_STORAGE_S3_REGION don't seem to be overriding the config, and we have to end up mounting a config file for S3 to work.
Thank you very much for looking into this guys.

To diagnose this environment variable issue, I added the following line to the very beginning of s3.FromParameters():
fmt.Printf("Params: %+v\n", parameters)

Then, I tweaked the default config file so that the storage section is:
storage:
    cache:
        blobdescriptor: redis
    s3:
        rootdirectory: /var/lib/registry
        bucket: bad
        region: us-west-2
    maintenance:
        uploadpurging:
            enabled: false

With no provided environment variables, I see the parameters as defined in the config file:
$ ./bin/registry cmd/registry/config.yml
Params: map[region:us-west-2 rootdirectory:/var/lib/registry bucket:bad]

I then added the bucket and region environment variables:
$ REGISTRY_STORAGE_S3_BUCKET=bukkit REGISTRY_STORAGE_S3_REGION=us-east-1 ./bin/registry cmd/registry/config.yml
Params: map[rootdirectory:/var/lib/registry bucket:bukkit region:us-east-1]

tl;dr I can't reproduce this, but I'd like to fix it if you can give me an example repro.

Good documentation here. Never used go before, and was able to test this in just over half an hour!
Anyways... As @BrianBland demonstrated, it works just fine when the storage is already set to s3 in the config.
But the storage in the default config (cmd/registry/config.yml) is filesystem, so in order to override that to s3, we must set REGISTRY_STORAGE=s3, as well as the other keys underneath it (ie REGISTRY_STORAGE_S3_BUCKET, REGISTRY_STORAGE_S3_REGION...)
I did read the note in the registry docs, but to me it kindda sounds like by specifying the full nested env variable (eg REGISTRY_STORAGE_S3_BUCKET), the storage dictionary would be automatically overridden
Note: If an environment variable changes a map value into a string, such as replacing the storage driver type with REGISTRY_STORAGE=filesystem, then all sub-fields will be erased. As such, specifying the storage type in the environment will remove all parameters related to the old storage configuration.

Maybe the doc should be more explicit... I imagine most people use S3 as backend. In any case, it's nice that we don't have to do mounts to get this going.
Thank you very much for the help!
g.

@tiadobatima Generally, we don't recommend configuring the entire instance with environment variables. The configuration is hierarchical and the mapping to environment variables is flaky. Effectively, there is no way "delete" the filesytem driver which is default. If you're running in production, it's worth the small amount of time it takes to define a Dockerfile with a different configuration file. It will save a lot of headache. We may make this easier, but it is a low priority.
From your last message, it sounds like we can close this. Let us know if you have further issues.

Good to know that @stevvooe
I'm trying to get saltstack formula for docker in a better state, and the environment variables are sure a nice way of configuring it. But if they aren't to be trusted, maybe we should mount the generated config file onto the path of the default config (cmd/registry/config.yml).
What do you think of this solution?
Thanks! :)

@tiadobatima I understand the desire to use env variables but the current configuration system is designed to use these to tweak a mostly complete configuration rather than replace the default.
Mounting is a sufficient solution.
Thanks for your understanding!


Cleanup code

trailing closure
Eliminate meaningless self-use
Eliminate meaningless associated values parameter of enum

@ParkGwangBeom Hi, great work! It looks much cleaner now.
However, I have a plan to make these clean-up works in 5.0. I am also already in progress of that major release. So it would be not easy to merge these changes. Could you instead check whether you could do them from the 5.0 branch and send the PR there if you'd like?
https://github.com/onevcat/Kingfisher/tree/5.0
Thanks!

@onevcat #1021 5.0 Based on PR


Multiplayer extension updates

Moves all extension blocks to the "Multiplayer" category
Makes "Player" an object (no longer a number)
Adds handler block for controller events: connected/disconnected
Adds "get player from sprite" block

Shoot, I used git mv to rename mp.ts to player.ts, but the PR still sees them as different files. 😤

Test target: https://arcade.makecode.com/app/623272af2d34999e0057c30e0f7ec087557935cc-ea04783fc3

Can mp_multiplayerstate be "score" and "life" instead of "Score" & "Lives"

Also can we have player from slot api to be consistent along with following? Or combine them to one?

Can mp_multiplayerstate be "score" and "life" instead of "Score" & "Lives"

These are "kinds" in the multiplayer extension. Uppercase is consistent with how we name "kinds" elsewhere. Do you want to introduce this inconsistency?

Using number now:

The latest getters:


(Minor) Default profile given by name is currently recognized to be a mismatch in preview v1.1.1671.0

According to the schema file, only a valid guid is now accepted for the "defaultProfile"; when a profile name is given, the mismatch is detected. This feature is still working and appealing though.

Environment
Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows Terminal version (if applicable):

Any other software?

Steps to reproduce

Expected behavior

Actual behavior

Yeah, this is ... unfortunate. It's because we only have one schema link :smile:
For your preview settings, can you change your $schema to https://raw.githubusercontent.com/microsoft/terminal/master/doc/cascadia/profiles.schema.json? That will make sure that you're always using the most up to date schema (instead of the one from 1.0)
We'll be better about this in the future.


Fix Resolve-Path -Relative with path starting with period

PR Summary
Original code has a check if the resolved path for local location already started with a period to determine if it should add ./ in front.  However, this meant that files/folders that start with a period didn't get returned as relative.  The change is to check if the resolved path starts with a period and directory separator.
PR Context
Fix https://github.com/PowerShell/PowerShell/issues/21144
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

I tried this fix locally and noticed it will also put .\ on parent paths, which is valid but is different from before in case that matters.
Repro steps:
Out-File testdot
Out-File .testdot
md dir-testdot
cd dir-testdot
Resolve-Path ..\*testdot -Relative

Previous output (before fix):
..\dir-testdot
..\.testdot
..\testdot

New output (after fix):
.\..\dir-testdot
.\..\.testdot
.\..\testdot


Proposal - mergin enums with spread operator

Consider enums with such syntax:
enum GoodMusic {
  RockAndRoll,
  Country,
}

enum BadMusic {
  Rap,
  DnB,
}

enum AllTheMusic {
  ...GoodMusic,
  ...BadMusic,
}

As enums are known at compile time compiler could detect conflicts

You can just write type AllTheMusic = GoodMusic | BadMusic.

@weswigham But then there would be conflicts, because they both use 0 to represent RockAndRoll / Rap.

I suppose you could write a lint rule for tslint which checks if a union contains enums whose values overlap.

You could also approach the problem "backwards":
enum AllTheMusic {
    // good
    RockAndRoll,
    Country,

    // bad
    Rap,
    DnB,
}

type GoodMusic = AllMusic.RockAndRoll | AllMusic.Country;
type BadMusic = AllMusic.Rap | AllMusic.DnB;

This has the advantage of ensuring that every GoodMusic value is a valid AllTheMusic value, whereas if you concatted two enums that were both using 0 in different ways, you would need different conversion functions to convert GoodMusic -> AllTheMusic or BadMusic -> AllTheMusic.

@andy-ms yup, but then - AllTheMusic needs to be aware of 'implementation' of 'sub-modules' and that lowers 'encapsulation'.

It would need to be "aware" of their implementation in order to issue an
error about conflicting members, anyway.
On Mon, Jul 10, 2017, 12:15 PM Adam Pietrasiak<EMAIL_ADDRESS>wrote:

@andy-ms https://github.com/andy-ms yup, but then - AllTheMusic needs
to be aware of 'implementation' of 'sub-modules' and that lowers
'encapsulation'.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/issues/17059#issuecomment-314206290,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACzAMsuyFWl1Gw-Qk8-CQWwsrQ7KBWsyks5sMng9gaJpZM4OTDHh
.

Not sure i see how feasible this is, and more importantly, the use case this solves.

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


Remove usize and isize from Serializer, Deserializer, Visitor

Why do we need usize and isize as types in our data model? Can we get away with just the specific bit width types? For the most part data formats just treat these as u64 and i64 right?

That would probably be better. Apparently we will never (for reasonable definitions of "never") get a usize that is bigger than 64 bits

@oli-obk how would you feel about squeezing this into 0.9?
One thing we still need to settle is the convention for deserializing enum variants by index, which currently uses usize. I guess visit_u32?


Today's batch

Few ESO images.

Today's lead image: https://worldwidetelescope.org/@eso/659d64df293f0a5746370a30


not by passing ad.fly

Domain
adly
Link
http://neexulro.net/ad/locked?rweasy=1&user_id=63984&_adflyurl_=https%3A%2Fgoplay.ml%2Fdownloadcode%2F&folder_id=&dl=ZzHNdsdSO%2F0IYRUxcXlwOlJh4wxxZBMr6wrPIziEcyvaoGWlX6iyVEb5FUYkPX7GkQ8E9fpBPD4pUrdj4N17XtKUMgkylDKO8hrUkfpKsno%3D&rndad=1626999353-1666768687&url=https%3A%2F%2Fgoplay.ml%2Fdownloadcode%2F%3Fdl%3DZzHNdsdSO%2F0IYRUxcXlwOlJh4wxxZBMr6wrPIziEcyvaoGWlX6iyVEb5FUYkPX7GkQ8E9fpBPD4pUrdj4N17XtKUMgkylDKO8hrUkfpKsno%3D&t=e&subid=63984&h=1
Version
0.0.0
What browsers are you seeing the problem on?
Brave
What OS are you seeing the problem on?
MacOS
Anything else?
not skipping

You probably have a broken link, has it returned 404;


Implement a Script to create Train and Test Sets for our Dataset

AIM
Implement a Script to create Train and Test Sets for our Dataset
Details

Download the Kaggle Dataset
Load the Images from the Disk and scale them.
Assign Binary Values to them and dump them to save Pre-Processing Time every time we load the Dataset.
Split the Dataset into Training and Testing Sets.

I would like to work on this.

I would like to work on this!!

I would like to work on this.

I would like to work on this

I would like to work o this

I have assigned the Issue to you @priyanka2109
You have 7 Days to make a PR on this Issue 🤗🙌

Can I start working on this issue in my branch?

I would like to work on this

@ankit3699 and @sahanabalappa Issues are served on "First Come, First Serve" basis. If @priyanka2109 is not able to resolve this, other people in the thread would be assigned the Issue

@HarshCasper I would like to work on this issue.

@amandp13 as commented by Harsh above the issues are assigned on FCFS basis. Although if the assigned person is unable to complete the work in 7 days you can request for it again. In the meantime be on the lookout for new issues or you can also create your own issue and we can approve them.

Yes..I am available
@BALaka-18


Update frontend render

What does this PR do?

Add alert-box styles
Fix markdown render when <code> isn't in a supported SDKs languages

How should this be manually tested?

Snippets tests reports


cardMedia component should be optional

Hello, I'm trying to put the card headers in at beginning of the margin but I find a problem doing it:

We are not using the card media component and it is still being rendering, for this reason it is giving "left padding"  that can't be avoided.
A solution is deleting it, but it should be optional, I think.
Thanks.

@SalahAdDin It's true, fixing it now

Published version 1.0.4 that should fix it


Performance comparison link (readme)

It seems that this link does not work anymore.
Cheers.

Looks like it has been accidentally deleted, sorry for that. On the other side, this library is going to be deprecated & abandoned soon, as PHP ^7.0 makes it irrevelant and PHP 5.6 is on its way towards EOM.


Correct proper web link in footer for web icon

replace https://www.ibm.com/industries/travel-transportation with federal link

2551:


Added slight translucency for better look of flat buttons in dark style

Before

After

Perhaps the fix is too dark? Here is a second alternative which I think look better. But in this case I have also altered the background color, not only alpha.

#19CCCCCC

What did I do on the snackbar?  I remember making sure it looked good in dark mode...might be good to find parity...

:+1: thanks!


Download EC2 Instance User Data technique does request userdata properly

What is not working?
Download EC2 Instance User Data technique does send userdata properly.

generates only one DescribeAccountAttributes CloudTrail event instead of 15
requestParameters is empty

"requestParameters": {
"accountAttributeNameSet": {},
"filterSet": {}
},
What OS are you using?
Ubuntu
What is your Stratus Red Team version?
2.5.3

Related code: https://github.com/DataDog/stratus-red-team/blob/main/v2/internal/attacktechniques/aws/discovery/ec2-get-user-data/main.go

Tested it and it seems to be working properly:

And the requestParameters looks fine to me:

Can you share the full output and a full CloudTrail log sample?

Hi Christophe,
Here is the screenshot of the output. And I've also attached an export of CloudTrail for the AWS user to execute the technique.
I've redacted the account id, access key, and IP address.
@.***
From: Christophe Tafani-Dereeper @.>
Sent: Thursday, May 4, 2023 4:06 AM
To: DataDog/stratus-red-team @.>
Cc: Alex Groyz @.>; Author @.>
Subject: Re: [DataDog/stratus-red-team] Download EC2 Instance User Data technique does request userdata properly (Issue #353)
Tested it and it seems to be working properly:
[image]https://user-images.githubusercontent.com/136675/236145633-a1bf32bb-dc88-4fb4-8e20-e458087bd373.png
[image]https://user-images.githubusercontent.com/136675/236145685-def2a1a0-b118-4f29-b809-6d847045b2b0.png
And the requestParameters looks fine to me:
[image]https://user-images.githubusercontent.com/136675/236145790-2237d205-3bf1-4fb2-ba90-3a0e4fbed716.png
Can you share the full output and a full CloudTrail log sample?

Reply to this email directly, view it on GitHubhttps://github.com/DataDog/stratus-red-team/issues/353#issuecomment-1534261540, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVWDMEKZHTZWEP3Y5WUSN6LXENPNHANCNFSM6AAAAAAXU3VKEU.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

Thanks, can you share your full Stratus Red Team output? Make sure the technique is clean first:
stratus cleanup --force aws.discovery.ec2-download-user-data

./stratus detonate aws.discovery.ec2-download-user-data
2023/05/04 21:55:48 Checking your authentication against AWS
2023/05/04 21:55:49 Warming up aws.discovery.ec2-download-user-data
2023/05/04 21:55:49 Initializing Terraform to spin up technique prerequisites
2023/05/04 21:55:51 Applying Terraform to spin up technique prerequisites
2023/05/04 21:55:56 Running ec2:DescribeInstanceAttribute to retrieve userData on i-a5af9dd3
2023/05/04 21:55:56 Running ec2:DescribeInstanceAttribute to retrieve userData on i-4fcc7797
2023/05/04 21:55:56 Running ec2:DescribeInstanceAttribute to retrieve userData on i-d53553b6
2023/05/04 21:55:56 Running ec2:DescribeInstanceAttribute to retrieve userData on i-70167988
2023/05/04 21:55:56 Running ec2:DescribeInstanceAttribute to retrieve userData on i-f6ed2bf8
2023/05/04 21:55:56 Running ec2:DescribeInstanceAttribute to retrieve userData on i-4bd0bfe3
2023/05/04 21:55:56 Running ec2:DescribeInstanceAttribute to retrieve userData on i-9b3dfb7a
2023/05/04 21:55:56 Running ec2:DescribeInstanceAttribute to retrieve userData on i-bdd25338
2023/05/04 21:55:56 Running ec2:DescribeInstanceAttribute to retrieve userData on i-e17fc89a
2023/05/04 21:55:56 Running ec2:DescribeInstanceAttribute to retrieve userData on i-e88e6bd3
2023/05/04 21:55:56 Running ec2:DescribeInstanceAttribute to retrieve userData on i-12c2d31b
2023/05/04 21:55:56 Running ec2:DescribeInstanceAttribute to retrieve userData on i-688eb774
2023/05/04 21:55:56 Running ec2:DescribeInstanceAttribute to retrieve userData on i-a5a278e4
2023/05/04 21:55:56 Running ec2:DescribeInstanceAttribute to retrieve userData on i-6afbf690
2023/05/04 21:55:56 Running ec2:DescribeInstanceAttribute to retrieve userData on i-14ab6de4

This looks correct, what makes you think that "It looks like IAM user fails to assume the role"?

From my understanding, the Download EC2 Instance User Data technique uses the initial IAM user, Download-EC2-Instance-User-Data-0504, to execute the technique to create a 'stratus-red-team-get-usr-data-role' role and then assume it.  Then makes, 15  DescribeInstanceAttribute API calls.
This is what I see when I look for the events in CloudTrail event history for Download-EC2-Instance-User-Data-0504 user.

So when I look though the events, I see access denied for all AssumeRole events.
And when I run query on event name DescribeInstanceAttribute.
I get no results back.
Perhaps I'm missing something.

Can you paste here the whole CSV, or show the whole user agent field? Thanks

Here is screenshot of the user agent field.

Hi, I wanted to follow up on this ticket. Are there any local logs I can check? We have a detection that this technique should trigger. So it would be great if I could get this to work. Thanks

Hello,
I'm not sure why this fails in your account, to be frank! Can you share the IAM policy attached to the identity you're using to run Stratus Red Team?

I understand what the issue is. It looks like the code, in general, does not assume roles correctly and always gets Access Denied.
I found two techniques that assume roles—this one and aws.credential-access.ec2-get-password-data.
When I run the aws.credential-access.ec2-get-password-data technique, I get the same Access Denied error when trying to assume stratus-red-team-ec2-get-password-data-role
I have run these techniques on Ubuntu, windows, and my college ran it on a Mac. And all have the same issue.
aws.discovery.ec2-download-user-data

aws.credential-access.ec2-get-password-data

Hello,
I have the same issue. The role is created correctly "stratus-red-team-get-usr-data-role".  However, the role cannot be assumed by Stratus and in the CloudTrail logs you get "AccessDenied" on the AssumeRole events.  I can assume the role manually with aws cli using the same IAM user that Stratus is using "aws sts assume-role --role-arn arn:aws:iam::123456789101:role/stratus-red-team-get-usr-data-role --role-session-name stratus --profile stratus"
I am using an Intel Mac and used brew to install Stratus.

Looks like this is due to the eventual consistency of AWS. When the role is created, it cannot be assumed right away

PR coming with initial retries to assume the AWS role. Will create a few access denied events on the role created, does that seem acceptable? Given eventual consistency of AWS IAM, I don't think we can do much better

@bmp-dot @agroyz Can you give https://github.com/DataDog/stratus-red-team/pull/358 a try? You can use make to create the Stratus binary in bin/

Ok. Now that I understand the issue, I have a workaround for my tests. Up to now, I've scripted to trigger all the techniques using detonate without warmup. But now I've changed it to warm up first, wait n seconds, and then detonate. This approach solved the issue. Thanks for your help.

Good to know! Are you able to give #358 a try to confirm it fixes the issue, even without waiting manually?

Thanks for testing! Did you have any errors? I just added debug output to the PR, could you try compiling and giving another try? Appreciate your help!
FWIW this is what I see:

I will assume that #358 fixes your issue - please let me know otherwise and I'll be happy to revisit


Fix/image methods mock in jest setup

Summary:
Context

Since RN 0.73, in the jest.setup file, methods of the Image module (Image.getSize, Image.resolveAssetSource...) are mocked on the JS side (introduced in https://github.com/facebook/react-native/pull/36996)
It causes issues like https://github.com/facebook/react-native/issues/41907 : Image.resolveAssetSource returns nothing in test env with the new JS mock, when some test relies on it.
On my project, it broke the snapshots : the URL of images disappeared. I use react-native-fast-image which uses Image.resolveAssetSource to compute URLs.
I first opened a PR to fix exclusively Image.resolveAssetSource: https://github.com/facebook/react-native/pull/41957. I will close it to focus on this new one.
As suggested by @ryancat and @idrissakhi, it should be better to return to the previous mock, where no method is mocked on the JS side, and we can trust the actual JS to work in test.

This is what this PR intends to do.
Content
Along fixing the Image module mock in jest.setup, this PR :

adds unit test on each one of the methods, ensuring they have a consistent behavior even when the module is mocked.
adds 3 missing native mocks for NativeImageLoader: prefetchImageWithMetadata, getSizeWithHeaders & queryCache. After this PR, no method from NativeImageLoader remains unmocked.

Changelog:
[GENERAL][FIXED] - fix jest setup for Image methods (resolveAssetSource, getSize, prefetch, queryCache)
Test Plan:
See exhaustive unit tests in PR.
You can re-use the mock with all the methods mocked and see how the new unit tests fail.
I also patched those changes on my project: my snapshot did have their URL back (see demonstrative screenshots in my original PR: https://github.com/facebook/react-native/pull/41957 - NB; fixed mock was different but result was the same -> those screenshots cover only two cases, but anyway they illustrate well the case!)

Thanks for adding the additional tests in this PR!


fix(slo, burn_alert, client) missing resources shouldn't error but be recreated

v0.19.0's client re-write introduced new client error handling but mishandled the classic "re-create when missing remotely" behaviour that Terraform in known -- and loved -- for.
Initially reported as a bug via Honeycomb Support.

Currently missing a test to prove this out automatically, but verified with manual testing.


Update japanese translation

Update Japanese Translation

Description 🗒
This pull request completes the Japanese translation progress to 100%.

Examples 📸

Related Issues 🔗
#175

 Expand for Help

Have questions about the review or deployment process? View our contributing docs
Need additional help and want to chat in real time? Join our community Discord

By submitting this pull request, you agree to our code of conduct

.deploy to development

@root309 checkout the development deployment and let us know if everything looks okay! 🇯🇵

I've checked the development deployment of the tarkov-dev, and I can confirm that everything looks okay with the changes I made. There are no issues to report!

@Shebuka I executed a script to fix the order of keys in each JSON file!

.deploy

@Shebuka
I noticed that the translation.json file does not contain the newly added translation keys.
Since the translation.json file does not seem to contain some of the new translation keys I have added, please refrain from merging pull requests at this time. I will work on resolving this issue and update the file accordingly.

@Shebuka
I revised the script for fixing the key order and ran it again. It seems that the latest commit has preserved the original key order of the translation.json file, and all the changes I made in the translation have been successfully added.

.deploy

.unlock production

.deploy production

.unlock production


[Feature] Adjust timeout when using Remote Play

Device
Desktop
Suggestion
I can understand having a short timeout when playing with public servers, but when streaming from my own xbox, the timeout seems very short like 5 minutes before it asks me if I am still there. Anyway to adjust this?

This feature had been implemented a long time ago and it's still working for me.


RR-895 - Cache prisonerSummary and hold on res.locals

@lynnette-orr and I have had a couple of mini pairing sessions on this, so that I could walk through and explain the changes in the PR. (I am not expecting anyone to be able to review a PR with 156 changed files without some kind of explanation and walk through of what and why the changes are! 😁 )
All happy and Lynnette has approved, so I'm going to merge this


SAK-47208 Profile: Character limit can be exceeded if you paste a copied text

SAK-47208
Used maxlength attr.
Extra fix: "clear status" button was showing on first load even if there wasn't any status setted.

Well done Vicent @V100X


[GHE Integration] Integration server name

We need to come up with the name of Github integration service.
For now the suggestions are:

Bark (Zally's mascot is a dog, so it barks on bad PR's)
Octodog (Octo from Github's mascot Octocat)
OctoZally

1 :+1:

How about zAllyMon like pokemon ? (Mon for Monitor)

Forgive me my ignorance - can you explain me the three suggestions?

I've added some explanation of the suggestions.
Feel free to suggest more options.

1 👍

+1 for zallyMon
and here goes mascot:
https://s-media-cache-ak0.pinimg.com/originals/b1/72/b9/b172b97a5ecd719c6049bd3de90d3223.jpg
since dog and git hook.. =)

1

GallyHally
Jokes aside, I vote for 1

Also GEIL = Github Enterprise Integration Layer

1 is fine 👍

@vecmezoni should we close the issue?

So the "bark" won!