Rename weapon type enum & add missing attack styles

Supersedes/Closes #11626

I propose the following additions and changes:
AttackStyle.java

ACCURATE_RANGING("Accurate Ranging", Skill.RANGED) to
ACCURATE_RANGING("Accurate", Skill.RANGED)
RANGING("Ranging", Skill.RANGED) to
RAPID("Rapid", Skill.RANGED) (or RAPID("Rapid Ranging", Skill.RANGED))
ACCURATE_CASTING("Accurate Casting", Skill.MAGIC)
LONGRANGE_CASTING("Longrange Casting", Skill.MAGIC, Skill.DEFENCE)

WeaponType.java

RANGING to
RAPID
STAFF_POWERED(CASTING, CASTING, null, DEFENSIVE_CASTING) to
STAFF_POWERED(ACCURATE_CASTING, ACCURATE_CASTING, null, LONGRANGE_CASTING)

If we end up strictly following RuneScape terminology and are worried about confusion for Accurate when using a ranged weapon and a melee weapon then I propose adding the appropriate sprites for the skills that you will gain experience in into the infobox.

If we end up strictly following RuneScape terminology and are worried about confusion for Accurate when using a ranged weapon and a melee weapon then I propose adding the appropriate sprites for the skills that you will gain experience in into the infobox.

When the plugin was first created the descriptors of the attack styles were primarily to indicate what experience you might gain if you were to attack. A large reason this plugin exists is for pures or other "restricted" accounts to monitor and prevent gaining experience in unwanted styles.
I agree differentiating between Accurate and Rapid for Ranging would be nice, I think the name Defensive Casting serves a purpose, although I guess Longrange Casting could be a useful descriptor depending on why the person is using the plugin.
Accurate Casting serves no purpose. You're either "Accurate" i.e. Casting or "Longrange" i.e. Defensive/Longrange Casting. There is no Rapid Casting as far as I know.
There was even a discussion as to whether the enum should even be called WeaponType back in the day 😂 Naming is hard.

Accurate Casting serves no purpose. You're either "Accurate" i.e. Casting or "Longrange" i.e. Defensive/Longrange Casting. There is no Rapid Casting as far as I know.

I disagree. According to Bitterkoekje (source) powered staves have a stance bonus that normal staves do not have:

Magic attack:
• Accurate +3 (trident only)
• Long range +1 (trident only)

This means that there is a difference between "Casting" and "Accurate Casting", though it is not visible to the player unless you do the accuracy calculations. As for "Rapid Casting" this could be used for the Harmonised nightmare staff which can attack with 4 instead of 5 tick speed, but this is not straight forward as it only applies to standard spellbook spells.
I my opinion there is no conflict in having this plugin both correctly show weapon types / attack styles and serving as an indicator for what experience you will gain. If the latter is harder to understand with the more precise naming I again refer to my previous suggestion to add skill sprites.

I disagree. According to Bitterkoekje (source) powered staves have a stance bonus that normal staves do not have:

I don't think this relates to my point that Rapid Casting does not exist as an Attack Style. The stance bonus is from selecting either Accurate or Longrange, not from changing from the first "Accurate" style to the second "Accurate" style. i.e. both these "Accurate" options on a powered staff are identical.

The plugin already distinguishes between the two stances available to powered staves by referring to the first two "Accurate" options as "Casting" and the "Longrange" option as "Defensive Casting".

In addition, I believe powered staves always attack with 4 tick speed VS 5 tick speed for standard "Casting".

It is correct that powered staves have a 4 tick attack speed whereas autocasting spells from a staff is typically 5 tick. Are you suggesting we should look to indicate attack speed on weapons? An abyssal whip and dharok's greataxe both have what we refer to as an "Accurate" (i.e. attack experience granting) attack style but have an attack speed difference of 3 ticks that we don't currently indicate.

This means that there is a difference between "Casting" and "Accurate Casting", though it is not visible to the player unless you do the accuracy calculations.

I'm not sure I follow this at all. You're either Casting (indicated by "Casting" - whether you want to call this something else is up for debate I guess), or Longrange Casting (indicated by "Defensive Casting"/"Longrange Casting"), or not Casting at all (indicated by whatever Attack Style you're using instead).

As for "Rapid Casting" this could be used for the Harmonised nightmare staff which does not have the invisible stance bonus of the powered staves and can attack with 4 instead of 5 tick speed, but this is not straight forward as it only applies to standard spellbook spells.

Perhaps there's an argument for calling the regular autocast style of the Harmonised staff "Rapid Casting" but it's not like the player can actually change the attack speed of the staff like they can on ranged weapons. I don't think it's a particularly useful distinction to make outside of exposing players to game knowledge they made not already have - "Hey this weapon autocasts regular spells 1 tick faster!".

Let's forget about the "Rapid Casting" as I think we both don't want that, am I right?

The stance bonus is from selecting either Accurate or Longrange, not from changing from the first "Accurate" style to the second "Accurate" style. i.e. both these "Accurate" options on a powered staff are identical.

I am aware of this. I am only concerned with the following distinction:

The skill(s) that gains experience is the same on both sides, the only difference is the stance bonus. If we don't rename "Casting" to "Accurate Casting" and "Defensive Casting" to "Longrange Casting" for the case of powered staves only we have no way to distinguish what is shown on the left and right in the above image, which is useful for a plugin that both serves to indicate/warn you what skill you will gain experience in AND imply if and what kind of stance bonus is currently active.
I do not want to rename or remove CASTING, I want to add additional versions of CASTING that are called ACCURATE_CASTING and LONGRANGE_CASTING because when you account for stance bonus there are 4 types of spellcasting: CASTING, ACCURATE_CASTING, LONGRANGE_CASTING and DEFENSIVE_CASTING.


Page to short, if alert and form are shown

If the alert "No registry found. [...]" is shown and you open a from to create a new team or add an namespace, the height of the <section> is bigger than the body.

I cannot reproduce this. Could you give us more info ?

New setup with the warning "No registry found"
Have a browser with a small height or fill the page with so many entries, that you get a scrollbar
Open the from to add a new entry
You should see the same issue

Ok, now I see, but note that this only happens in Chrome. It works fine in Firefox.
@cyntss can you look into this ?

Fixed in f4ee398a2bb96eb85d78d7883ba278b81ba8a672


ROCm 5.7 CI update

Move dockerfiles, benchmark and performance tests to ROCm 5.7

You need to disable the cppcoreguidelines-avoid-capture-default-when-capturing-this check.

Looks like perf needs an update here too. Adding skipbotchecks till I can add piece for GPU_TARGETS there too


TO golang endpoint to assign deliveryservice_request

Need to add this endpoint to assign a deliveryservice_request:
PUT /api/1.3/deliveryservice_requests/:id/assign { assigneeId: 50|null } <-- to assign / unassign

and disable updating assignment in PUT /api/1.3/deliveryservice_requests/:id

This was part of #1685


pytorch weight file

I'm trying to run 'ssn_test.py'.
I get the arguments in the example script below, but where can I get TRAINING_CHECKPOINT?
python ssn_test.py DATASET MODALITY TRAINING_CHECKPOINT RESULT_PICKL
There is no way to download 'the trained pytorch weights file' from authors.

no need to manually download.
See here on how to test the reference models:
https://github.com/yjxiong/action-detection#using-reference-models-for-evaluation


Could anyone tell me why use HttpClient and Controller instead of call Backend Service directly?

If it's server side only then there is no need.

thanks a lot.

This workshop uses Blazor web assembly which runs directly in the browser. So there's no ability to call into the database directly because you're running on some users' computer somewhere.


Small update to the read me file to test the web hook.

Why did you close the pull?
(In case you didn't know, you can keep making changes inside the branch without closing the pull. Any further changes will be included when you finally complete the pull.)

https://github.com/bcgov/GDX-Analytics-Looker/pull/3
That is the correct pull.  I don't think I did it correctly so I did another one.

In cases like this, leave the pull request open.
If you are on the same branch, you should use the same pull request.
You can continue to make changes to a branch without closing the request.

It's much easier to follow if it's all in one request.


dotnet core install via official script not working

Browse to https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-install-script
Download script https://dot.net/v1/dotnet-install.ps1
Run script
Expected:
Would download zip and install .net core sdk
Actual:
Getting 404
Other info:
Get one of the urls and paste into browser
Get the following:

BlobNotFound

The specified blob does not exist. RequestId:ea148153-001e-00df-075c-9cf99f000000 Time:2018-02-02T19:28:52.4221024Z

Wondering if this was some temporary glitch. The script seems to be there for me now.

the script is there, thats not the problem. Its the urls in the script that give back 404

Also was trying to run with -Version stable.
Changed to run with no parameters just to check if that worked.
It tries to download Downloading link: https://dotnetcli.azureedge.net/dotnet/Sdk/1.1.5/dotnet-sdk-1.1.5-win-x64.zip
Current SDK is v2.1.4 I believe

Issue moved to dotnet/cli #8651 via ZenHub


Set chromosome length axis

Hi
Would it be possible to set the chromosome size axis as standard for all chromosomes i.e. 80 Mb. THe reason I am asking is that I have many genome comparisons, and would need to plot each chromosome individually due to the number of comparisons, however because the chromosome length is determined by the max length in the set, the x-axis is inconsistent. This causes scaling issues for plots even when height and width are set.
Any help would be appreciated.
Kind regards

Sorry for a very delayed reply. I guess, it would not be helpful for you anymore, but might help future readers.
Natively, plotsr does not have this option, but I think one can use the --reg option to set the chromosome length.

Hi @mnshgl0110 , I actually managed by editing line 1379 of the func.py file as following:
ax.set_xlim(minl, maxl)
ax.xaxis.grid(True, which='both', linestyle='--')

TO:
ax.set_xlim(minl, 85000000) #####
ax.xaxis.grid(True, which='both', linestyle='-', linewidth=0.5)

So all the x-axis printed to the same max size I wanted, so when I made single chromosome plots the scaling wasn't an issue. I just pasted them all to have the same size and cropped to the appropriate length after.
may I ask on a different note, what would be the appropriate manner to calculate percentage of SV type contribution to the comparisson. Would you e.g. take the total size of inversions and divide it by 1) the length of the genome it is found in, 2)the length of the reference genome, 3)the total length of all variants in the query genome.
The last option is not the same as the first because I have found the total length may be longer than the assembly size.

Hi @annerilotter. Setting the maxl value is a good idea. In the current setup, you might need to manually reset and recompile plotsr if you need to use different values. But, I guess, this can be parameterised as well. I would consider this option for future updates.
Regarding the SV length, the total length is often longer than assembly length because some SVs overlap. The normalisation strategy depends on the comparison that you would like to describe, as such I do not think that any strategy is more appropriate than the other. Although, do note that, if you used syri for inversion identification, then the inversion would most probably have different lengths in the reference vs query genomes, as they often have different indels within inverted regions. You might need to consider than for the analysis.


[google_maps_flutter] XCUITest failing on master

Sometime in the last few days, while the flutter/plugins tree was red due to an out-of-band Android failures, we picked up an out-of-band iOS failure, also on master, in google_maps_flutter/google_maps_flutter's XCUITests:
2021-11-09 07:23:58.445405-0800 RunnerUITests-Runner[7419:57891] Attributes: Application, pid: 7423, label: 'google_maps_flutter_example'
Element subtree:
 →Application, 0x600000310460, pid: 7423, label: 'google_maps_flutter_example'
    Window (Main), 0x600000310700, {{0.0, 0.0}, {414.0, 896.0}}
      Other, 0x600000310620, {{0.0, 0.0}, {414.0, 896.0}}
        Other, 0x6000003107e0, {{0.0, 0.0}, {414.0, 896.0}}
Path to element:
 →Application, 0x600000310460, pid: 7423, label: 'google_maps_flutter_example'
Query chain:
 →Find: Target Application 'dev.flutter.plugins.googleMobileMapsExample'
  Output: {
    Application, pid: 7423, label: 'google_maps_flutter_example'
  }
/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/packages/google_maps_flutter/google_maps_flutter/example/ios/RunnerUITests/GoogleMapsUITests.m:56: error: -[GoogleMapsUITests testUserInterface] : failed - Failed due to not able to find platform view
    t =    36.36s Tear Down
Test Case '-[GoogleMapsUITests testUserInterface]' failed (36.570 seconds).

Example failure: https://api.cirrus-ci.com/v1/task/4519418760790016/logs/native_test.log
I can reproduce locally, and it appears that what's happening is that running with master, the handler added with addUIInterruptionMonitorWithDescription is never firing, so it get stuck at the permission prompt. Running exactly the same test with the same version of Xcode, etc. but on stable, the test works and the breakpoints that I set in that handler fire.
Looking at engine commits, https://github.com/flutter/engine/pull/29531 seems suspicious based on timing and topic, but I don't have any specific evidence that it's the cause yet. (I don't have a remotely recent engine build, so it would take forever for me to verify locally.)
/cc @jmagman @cyanglaz

Bisecting to this engine roll: https://github.com/flutter/flutter/commit/4172c7dc005e18c7faec1ea0108cbb4de85ad4a8
Going to bisect the engine commits.

Suspecting based on looking at code changes, this might be the cause: https://github.com/flutter/engine/pull/29566
cc @dnfield

Lower to P2 as it is not blocking the tree anymore.

I'm not sure I fully understand what the test is doing, but my change made it so that when a system dialog comes up, we hide all the a11y elements from the OS (and thus from the test here) that Flutter would be producing in its view. This is to avoid having a situation where Flutter can unexpectedly grab back a11y focus from the system dialog.
I suspect this breakage is specific to the way the test is implemented though, rather than to actually breaking behavior/functionality of the plugin...

The test shows a permission popup. addUIInterruptionMonitorWithDescription is a method to interrupt the popup.
When the popup shows, I believe the application is resigned.
It seems that when the application is resigned, disabling the view's accessibility caused the the addUIInterruptionMonitorWithDescription to not show.

I suspect this breakage is specific to the way the test is implemented though

This is how permission popups are handled in XCUITests. Breaking it with engine behavior would render a variety of plugins untestable by xCUITest, which is a serious problem.

It looks like there are 4 other callsites using this method and those tests are passing. Trying to see what might be different.

Shortly afer writing that comment I realized some of those are disabled too. Sounds like we need to revert the engine change. There should be another way to fix the bug I was working on there by not sending updates about a11y when we resign active, rather than hiding the elements.
It seems really strange that this would break that test though. This seems like exactly the case where you want to hide a11y elements. But then, it also seems really weird that iOS doesn't handle this better anyway, since a UIView that's in a resigned active application shouldn't be able to grab focus away from a view that is active...

Hm. One of them skips here: https://github.com/flutter/plugins/blob/master/packages/image_picker/image_picker/example/ios/RunnerUITests/ImagePickerFromLimitedGalleryUITests.m#L81 and was skipped a while ago now.
The other one does not skip and seems to pass: https://github.com/flutter/plugins/blob/master/packages/image_picker/image_picker/example/ios/RunnerUITests/ImagePickerFromGalleryUITests.m#L26
Any idea what's different about these?

Any idea what's different about these?

I also was looking at this and doesn't seem to be an obvious difference. The only thing I noticed was that there was a workaround in the image picker test for similar issues, as I mentioned here. However, as my comment, the same workaround didn't work for google map.
Other differences potentially affecting this are:

Google map contains platform view, which has some custom handling on the a11y. However, I can't tell how the platform view a11y code would affect top level.
The permissions are different.(location permission vs image access permission) There might be some code in the location permission popup that causes a deadlock when the a11y elements are disabled. (This can be easily tested with an iOS app)
google_maps_flutter's location permission was handled in the GMap sdk, image picker's permission was handled in the plugin code. There might be something in the GMap SDK that is not compatible with disabling the a11y. (Unlikely, but still, it can be easily tested with an iOS app with gmap)

Our next step could be updating the test to show a different google map page that doesn't require location permission. This way, even we can't test the location permission popup, we can still test the googlemap itself.

I'm trying to understand if we need to revert the engine change or not, and the scope of what it might be breaking. Was this test relying on undefined behavior or have we actually broken something?

The test wasn't relying on undefined behavior. The test was broken in the sense of it is not able to trigger the notification for alert popup.
Disabling the a11y when the app goes to the background doesn't seem like something an iOS app would do. I am a little worried about it as we don't know how iOS would handle such cases. For example, does iOS actually rely on the main view's accessibilityElement to do something when there's an alert view?
Preferably, we should find a new way to fix the original bug without disabling the accessibilityElement, but looks like it was a semi-blocker for customer:money. Maybe we don't revert the engine change (unless there's a bigger regression discovered in non-test environment), and re-open https://github.com/flutter/flutter/issues/93030 to find a better solution?

Maybe we don't revert the engine change (unless there's a bigger regression discovered in non-test environment)

My main concern here is that we don't understand the extent of the breakage. Per my comment above if all permission prompt handling were broken, that would be really bad, even though it's test-only. If there's something weird about this one test, and most still work, that's probably okay. But right now we only have two data points so it's hard to know how much this will impact testing in the ecosystem.

We have one test that still passes and one that fails. Another was previously skipped due to being flaky.
I'm good with an alternative approach without revert.  If something else comes up I will be happy to approve revert.
The method being used specifically says in the docs that it's appropriate for use when covered by other ui elements, which is what is happening when we resign active in this case....

Lower priority to p4 as other google maps plugin tests are re-enabled. We still need to work on permission popups in tests.

The other one does not skip and seems to pass: https://github.com/flutter/plugins/blob/master/packages/image_picker/image_picker/example/ios/RunnerUITests/ImagePickerFromGalleryUITests.m#L26

That test target isn't set up correctly, and when I fixed it (https://github.com/flutter/plugins/pull/4501) and ran it locally, it fails with the permission dialog up.
I don't understand how it seems to be passing in CI. From the full logs in https://cirrus-ci.com/task/5628046456651776
https://api.cirrus-ci.com/v1/task/5628046456651776/logs/native_test.log
Test Case '-[ImagePickerFromGalleryUITests testPickingFromGallery]' passed (11.848 seconds).

Lower priority to p4 as other google maps plugin tests are re-enabled.

Which other plugin tests?  I don't see one that's locally passing with addUIInterruptionMonitorWithDescription

Which other plugin tests? I don't see one that's locally passing with addUIInterruptionMonitorWithDescription

The ones that I added in https://github.com/flutter/plugins/pull/4496 are passing, these do not require permission popups. At least with these tests, we have some coverage instead of 0. (The first test that requires permission popups is still skipped)

Let's split this into two bugs then.
One engine bug tracking that Flutter apps on top of https://github.com/flutter/engine/pull/29566 can no longer use addUIInterruptionMonitorWithDescription in XCUITests https://github.com/flutter/flutter/issues/93504.
And this one can track making sure the testUserInterface test gets turned back on when that's fixed.


[SMALLFIX] Removed explicit type argument in StorageTierView

Removed an explicit type argument in the StorageTierView class.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9859/
Test PASSed.

LGTM


Adjust breakpoints to allow 4 columns

Look at https://landscape.cncf.io/embed.html while widening and narrowing the window. It jumps from 3 columns to 5. Also, after 5, the cards stay the same size and there is extra grey space on the right.
Instead, adjust breakpoints so that 4 columns are shown at the appropriate width, and that the width of cards widens to make use of any extra space.
Cc @ZeusTheTrueGod

@dankohn the embedded version has no filters column, that's why the layout becomes different
@ZeusTheTrueGod I need some special class added to the body element for embedded version to write rules for it

Sounds good, but you could go ahead and do the other part, which is to have the cards get wider to cover empty space like happens for 1 to 3 columns, but at higher column numbers as well.

Done, I've added the 'embed' class to the body in the embedded mode. I've pushed this directly to the master.

@alexkontsevoy


Use rename bif instead of exec

https://docs.zeek.org/en/stable/scripts/base/bif/bro.bif.bro.html#id-rename

Thanks for the PR Justin! Merged.


Integration of tests from Packages in their own repo

Tests from their own repo will be cloned into openwhisk from a .sh script. A "tests/" folder should be included in packages in their own repo.  One idea for test integration into openwhisk is to have the build.xml copy the tests to openWhisk/tests/src/package directory. @rabbah @csantanapr what are your thoughts?

@nwspeete-ibm why the need to copy into tests/src/package ?
Why not just leave the source code for the tests in place catalog/wsk-pkg-pushnotifications/tests/ and configure gradle to resolve dependencies and run the tests.

@csantanapr leaving the tests in catalog/wsk-pkg-pushnotifications/tests/ is a valid option.  @rabbah can we all agree on this option?

We all agreed on leaving the tests in catalog/wsk-pkg-pushnotifications/tests/ . Will work on a way to configure gradle to resolve dependencies and run the tests.

VCAP_SERVICES property must be set in open ,  or set this property in whisk.propeties;
vcap.services.file=

Tests integrated into blue for push.


Rename to register_offense for adding offenses method

ref: https://github.com/bbatsov/rubocop/pull/3822#discussion_r93826280

Before submitting the PR make sure the following are checked:

[ ] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[ ] Used the same coding conventions as the rest of the project.
[ ] Feature branch is up-to-date with master (if not - rebase it).
[ ] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[ ] All tests are passing.
[ ] The new code doesn't generate RuboCop offenses.
[ ] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[ ] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

👍


Use marked library and mermaid in memo display.

In order to do this:

I didn't saw it would conflict with https://github.com/usememos/memos/pull/1562. I don't know what I should do. Should i wait for the other PR to be merged before doing this ?

whoops I didn't saw that I breaked the Todo buttons. Sorry !

Okay it's fixed now.
I hope I have forgot nothin more.

marked? a big change.

@Jbbouille Any idea to display empty lines with marked?

@boojack based on this you have to make two or more space at the end of a line.

🤔 I think the PR breaks the compatibility, which is hard to accept.

@CorrectRoadH can you tell me what it brokes, and I will correct it.

@CorrectRoadH can you tell me what it brokes, I will fix it.

the render effect:
the same text
How to learn CSS?
- test 1
- test 2
Conclusion

in old

in the PR

@CorrectRoadH for the style it is fixed.
But for the "Conclusion" item which is not in the list, I don't know what is desirable.
If we want to display markdown or even common markdown, I think this is the right render, but if we want to display some custom language like markdown I should fix it.
In the memos website it is advertise that it's Plain text with Markdown.
What should I do ?

The PR is OK for me. I think marked can reduce the cost of maintenance. But there are different opinions in the team, so we are still discussing. 👀

Hi, I'm using this branch of memos and I've noticed several issues. I've attached a patch for them.
First, memos is overly optimistic / aggressive about what types of text it will convert to hash tags. This is actually also a problem in the main branch but it breaks more stuff in this branch. For example, in this branch apostrophes (') are not displayed correctly in any memo because the underlying code of this branch replaces them with a numeric HTML entity (') and numeric HTML entities are incorrectly translated into hash tags which breaks their rendering. (The problem with the rendering of numeric HTML entities is also in the main branch but the main branch does replace apostrophes with them.)
Here are a few examples of some text that in my opinion should not be converted into hash tags but are anyway breaking rendering or the likely intent of the user:

Rule #1: You don't talk about ...
#2
https://example.com/#header3
First rate A#1 quality
!

I've solved this problem by using a much stricter regex to find tags:
(?<=^|\p{White_Space})#(([\p{L}_][\p{L}\p{N}_]*)|(\p{N}+\p{L}[\p{L}\p{N}_]*))
This means that in order to be matched tags must follow one of these two formats:

<1 letter or underscore><0 or more letters, numerals or underscores>
or <1 or more numerals><1 letter><0 or more letters, numerals or underscores>

In both cases the tag must be preceded by the beginning of the line or a whitespace in order to work around some of the rendering issues above.
Nevertheless the regex still matches every tag I had in some markdown files I've collected.
I'm using unicode-aware metacharacters in the regex so that it should work properly in every language even those for which the regular regex metacharacters don't work.
Another issue with this branch is that it does not always properly render tags or set the proper tag filter when they're clicked. The following lines demonstrate the problem:
#tag
#tag2
#tag_3

The second and third tags do not render properly and when clicked do not set the proper filter. I've rewritten and simplified the paragraph() function in web/src/labs/render.ts to correct the logic. It should also be much faster.
With this patch this branch seems pretty usable to me now (though I haven't tested very long).
memos-use-marked-library-20230522-cet.patch.gz

@clipcarl Thanks for the comment, I have hadded your patch on this merge request.

Hi, thanks for looking at my patch so quickly and getting it in! :-)
I notice that one change I made didn't seem to make it in. Right now LINE_BREAK_REG is:
export const LINE_BREAK_REG = /\n|\r|\r\n/g;
but I think it should be:
export const LINE_BREAK_REG = /\r\n|\n|\r/g;
This is because if I'm not while regexes are in general greedy, regex alternation is opportunistic; the first left to right match wins. So with the first form \r\n will never be matched.

Thank you @clipcarl I didn't knew that.

Hi @boojack . Will the the new gomark plugin support tables? That's a feature that I absolutely need!
Is there any architecture documentation or notes on how gomark will be implemented in memos to make it easier for people to jump in and contribute? In general I feel that memos could use better source documentation.
Thanks!

Pinging @Jbbouille about possibly resurrecting this again as it seems table support is not forthcoming.


Try using deprecated Travis trusty 2017q4 images

We've been getting various weird Travis build failures in the last few days.
This PR tries to use the legacy images, using the approach documented here:
https://github.com/travis-ci/travis-ci/issues/8870
This could be a temporary workaround until we figure out why the builds are failing.
Changes

Pin TravisCI infrastructure version.

Testing

Open this PR to see if it works!

Notes
One big downside of doing this (using sudo: required) means we can't use container-based infrastructure, which increases boot time from 1-6 seconds to 20-40 seconds.
Checklist

[X] PR has an informative and human-readable title
[X] Changes are limited to a single goal (no scope creep)
[X] Code can be automatically merged (no conflicts)
[X] Code follows the standards laid out in the development playbook
[X] Passes all existing automated tests
[X] Reviewers requested with the Reviewer tool :arrow_right:

This fixes the frontend tests but the backend tests fail now with a boto-related error.

Closing as this has been resolved by #3668.


Bug: Satellite Service fails under Windows 7

Describe the bug
I can't activate the Satellite Service, I already reinstalled the service, Hass.Agent, .NET 3.1.25, 5.0.17, 6.0.5, 7.0.0-preview.4 and nothing worked.
I've run it as administrator and the problem persists.
Screenshots
Misc info (please complete the following information):

Windows build (ideally screenshot/info of winver.exe output): Windows 7 Profissional - Version 6.1 (Compilation 7601: Service Pack 1)

Windows' UI language: PT-BR (Português - Brasil)

HASS.Agent version: 2022.11.4

.NET:

Please check what's applicable (multiple answers possible):

[x] Installed via installer
[ ] Installed manually
[ ] Problem occurs in HASS.Agent
[x] Problem occurs in Satellite Service

Logs

[2022-06-09] HASS.Agent_service_enabled_20220609.log
[2022-06-09] HASS.Agent_service_reinstall_20220609.log
[2022-06-09] HASS.Agent_20220609.log
[2022-06-08] HASS.Agent_20220608.log

Hi @Otanar1,
Thanks for the detailed reports :)
I haven't actually tested hass.agent or the satellite service under windows 7. Give me some time to setup a Win7 environment so I can see if I can get it to work!

Hi @Otanar1,
So I've been playing with it, but I can't even get HASS.Agent to work at all on Windows 7 heh. So it's odd that you can, but that's fine.
I did however find a way for you to run the Satellite Service, if you want. Open an elevated command prompt, and type these commands:
sc.exe create "HASS.Agent Satellite Service" binPath= "C:\Program Files (x86)\LAB02 Research\HASS.Agent Satellite Service\HASS.Agent.Satellite.Service.exe"
sc.exe failure "HASS.Agent Satellite Service" reset= 86400 actions= restart/60000/restart/60000//1000
sc.exe config "HASS.Agent Satellite Service" start= auto
sc.exe start "HASS.Agent Satellite Service"
The service should now be installed and started. I'll also fix it for the next release.

Hi @Otanar1,
So I've been playing with it, but I can't even get HASS.Agent to work at all on Windows 7 heh. So it's odd that you can, but that's fine.
I did however find a way for you to run the Satellite Service, if you want. Open an elevated command prompt, and copy/paste these commands:
sc.exe create "HASS.Agent Satellite Service" binPath= "C:\Program Files (x86)\LAB02 Research\HASS.Agent Satellite Service\HASS.Agent.Satellite.Service.exe"
sc.exe failure "HASS.Agent Satellite Service" reset= 86400 actions= restart/60000/restart/60000//1000
sc.exe config "HASS.Agent Satellite Service" start= auto
sc.exe start "HASS.Agent Satellite Service"
The service should now be installed and started. I'll also fix it for the next release.

Thanks for the feedback @LAB02-Admin .
Version 2022.11.4 works on Windows 7, 2022.12.0 does not.
What you gave me worked, now the service is working.

Thanks for the excellent work.
Now I just need to solve the problem with the version 2022.12.0, for now I will not update.

Hey @Otanar1,
I've been trying a few options, but the requirement of the latest Windows SDK prevents HASS.Agent from starting. I've installed the SDK on W7 (as a 'why not' attempt), but didn't help.
So I'm sorry, but it looks like 2022.11.4 is the last version that's supported on Windows 7 :(
Closing this now, if you ever come across a potential solution let me know and I'll test it.
For the record, this is the error Visual Studio gave:
Exception thrown: 'System.TypeInitializationException' in Microsoft.Windows.SDK.NET.dll

Hello @LAB02-Admin
I see, I knew that one day I would have to migrate to a newer windows, is that 7 still works so well 😢
Next week I'll test a few more things, any news I'll let you know.
The notifications don't work here either, I'll install Hass.agent on the other PC I have here with windows 10 and test if the problem is with windows 7 or something else on my network.
Thank you for the feedback and congratulations for the excellent work and dedication.

I don't manage to get it working in Windows 7 either. I did download the latest version. Not able to upgrade that computer to 10 sadly. But I do understand that there's no Windows 7 support

Hey @Otanar1 and @jocke92, thanks to the fix suggested in ticket #113, I have HASS.Agent working under Windows 7 (the mediaplayer functionality will be disabled though).
It'll be in the next beta

Hello @LAB02-Admin
Amazing, I wasn't already happy with the current functioning, expanding it will be phenomenal.
I'm looking forward to the fix.
Thank you for the dedication and congratulations for the excellent work and dedication.

You can try the latest beta: https://github.com/LAB02-Research/HASS.Agent/releases/tag/2022.13.0-beta2

You can try the latest beta: https://github.com/LAB02-Research/HASS.Agent/releases/tag/2022.13.0-beta2

Hello @LAB02-Admin
I've installed it and it's in testing.
I still don't get notifications, even with everything set up.
I noticed that the web view is not dynamic so it doesn't adjust things to the window size.
I noticed that it is asking for login every time I restart HASS AGENT, which is a nuisance, especially for those who have 2-factor security.
Thank you for your dedication.

I still don't get notifications, even with everything set up.

Looks like notifications won't work as-is, because HASS.Agent uses Windows' notifications system. I am planning to implement my own system, because there are a lot of limitations in the Windows one, so when that's done it should work on W7 as well.

I noticed that the web view is not dynamic so it doesn't adjust things to the window size.

You mean resize the content of the webpage to the size of the window? Interesting, I'll see if that can be done and if so, make it a setting.

I noticed that it is asking for login every time I restart HASS AGENT, which is a nuisance, especially for those who have 2-factor security.

With a webview? That shouldn't happen, it has cookies enabled and is basically like a regular browser. Is the clear cache every x days setting still on 0 days? It's available under config -> local storage -> bottom webview section.

I still don't get notifications, even with everything set up.

Looks like notifications won't work as-is on W7, because HASS.Agent uses Windows' notifications system. I am planning to implement my own system, because there are a lot of limitations in the Windows one, so when that's done it should work on W7 as well.

Great news, I will eagerly await this update

I noticed that the web view is not dynamic so it doesn't adjust things to the window size.

You mean resize the content of the webpage to the size of the window? Interesting, I'll see if that can be done and if so, make it a setting.

That, automatic resizing.
The HASS Workstation Service has this.
https://github.com/sleevezipper/hass-workstation-service

I noticed that it is asking for login every time I restart HASS AGENT, which is a nuisance, especially for those who have 2-factor security.

With a webview? That shouldn't happen, it has cookies enabled and is basically like a regular browser. Is the clear cache every x days setting still on 0 days? It's available under config -> local storage -> bottom webview section.

I found it strange too. The webview cache clearing is at 0 days. But every time I restart HASS.Agent it is asking to login again


generate keys #192

#192 close

thanks, just some minor nitpicks:

commit message should be along the lines of "Add note about generating keys from the WordPress API"
this PR description itself should contain more info than just "#192 close"
PR title should also reflect the commit message

i also think the change made to README should be dropped. see inline note above

@retlehs Sorry about that

Thanks!


Felix should log its configuration on startup

This would make it easier to debug what the config actually looks like internally, especially if we do not have the config file available.
Not hugely high value, but 30 seconds to fix.

Done, I think.


fix typo in Shapes/Path docs

When I was going through the docs I found a typo in documentation of Path. PR fix it.

I have signed the CLA!

I have signed the CLA!


Which toCharSet should we use going forward?

The reason we added RegexpContext.toCharSet was performance (see #148). Since #317, this is no longer a problem. All character-related regexp-ast-analysis functions are now cached automatically.
This leaves us in a kinda awkward situation: Which toCharSet should we use?
Also, shouldn't we remove this rule?
@ota-meshi

I think we should use regexp-ast-analysis.toCharSet :+1:.


Question : Is there an option to set the page Thumbnail image independently of the header image?

Hopefully a quick one ...
I know you can set the image in the header fairly easily, but a lot of the pages I'm transforming have BOTH the PublishingPageImage and the RollupImage specified (i.e. one for the page header, and another for the thumbnail)

Yes, in publishing pages page layouts mapping, under meta data you can set the thumbnail field to something other than the header image, something I do quite often, if you add the mapping to the metadata section:
<Field Name="PublishingPageImage" TargetFieldName="BannerImageUrl" Functions="ToPreviewImageUrl({PublishingPageImage})" />

This will give you control over the image to place in the thumbnail.

Urgh .. I feel so dumb! Thanks @pkbullock

Thanks for answering @pkbullock , closing the issue now


How to import completions?

I'd like to import pre-annotated tasks (with completions).
When I import tasks from a JSON file with completions, the imported tasks have an attached completion, but the list of completions is still empty: I can't train a ML model with them. I have to open every task and click either 'Update' or 'Set Ground Truth' on the completion.
To reproduce the issue:

create a new project
import a sample task
add a completion
export to JSON
delete all tasks
import tasks from the exported JSON file
The import status messages will say: 1 task and 1 completion created
go to Tasks page: you'll see 1 task and 0 completions

but the list of completions is still empty

Where is it empty?

In the Tasks page, it says '0 completions'
When I try to train a model, I get the error "No completions found"
The API /api/projects/1/completions_ids/ returns an empty list

Can you check release/0.7.5 branch? I've fixed this issue there.

It's fixed now. Thanks!


qovery-cli: 0.65.1 -> 0.66.1

Diff: https://github.com/Qovery/qovery-cli/compare/refs/tags/v0.65.1...v0.66.1
Changelog: https://github.com/Qovery/qovery-cli/releases/tag/v0.66.1
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.


Crash when assigning a Rust instance to a variable with a type

Rust version: rustc 1.62.0 (a8314ef7d 2022-06-27)
Godot version: Godot Engine v3.4.4.stable.official.419e713a2
godot-rust version: 0.10.0
Platform: Windows 11 (x86_64-pc-windows-msvc)
I ran into what looks like a segfault when interacting with a GDNative class created in godot-rust from a GDScript class. I did my best to narrow down the problem as much as possible, but it seems like it's still a pretty niche set of conditions. Here's the Rust source:
use gdnative::prelude::*;

godot_init!(init);

fn init(handle: InitHandle) {
    handle.add_class::<HelloWorld>();
}

#[derive(NativeClass)]
#[inherit(Node)]
pub struct HelloWorld;

impl HelloWorld {
    fn new(_owner: &Node) -> Self {
        godot_print!("[HelloWorld] new");
        HelloWorld
    }
}

#[methods]
impl HelloWorld {
    #[export]
    fn make_another(&self, _owner: &Node) -> Instance<Self, Unique> {
        let result = HelloWorld.emplace();
        godot_print!("[HelloWorld] make_another");
        result
    }
}

Here's the GDScript source:
extends Node

const HelloWorld = preload("res://HelloWorld.gdns")

var hello: HelloWorld

func _ready():
	print("[Example] _ready: Start")
	var new_hello_world: HelloWorld = HelloWorld.new()
	print("[Example] _ready: Created new_hello_world")
	var hello: HelloWorld = new_hello_world.make_another() # <-- Crash here
	print("[Example] _ready: Called make_another")

Here's a full example project with this setup: GodotRustEmplacePoc.zip
When I attach the above GDScript file to a node, the project crashes when assigning to the hello member variable. No error is included in the output, the process just exits with a bad exit code. I'm able to reproduce this consistently when trying to assign the result of a godot-rust method that returns Instance<_, _> to a GDScript variable with a type annotation that matches that instance type. Either using a supertype like Node or removing the type annotation from the hello variable seems to fix the crash.
Is this a bug, or is this violating some constraint I'm not aware of with Instance<_, _> or .emplace()? If this is a bug, is it a bug in godot-rust, or is it an upstream bug in Godot?

Hello!
GDNative types have unfortunately had a 2nd-class-citizen status in GDScript for quite a while. Last time I checked, these things were not fully supported:

Type hints in variable, parameter and export declarations
get_class() + is_class() (although this problem exists also for GDScript classes)
is operator
usage as EditorNode
auto-completion in GDScript (listing methods of custom types)

I searched extensively for an official issue regarding the type-hint situation, but didn't find one. I'm actually surprised that "most" of your code in the project works at all; I had the situation in the past where GDNative parameter types in GDScript would just be passed as null. Possibly some of the issues were addressed in the meantime, but not fully.
Thanks for providing the example project -- I could reproduce the crash.
I also modified the GDScript code a bit and noticed something interesting:
extends Node

const HelloWorld = preload("res://HelloWorld.gdns")

func _ready():
	print("[Example] _ready: Start")

	# Context information: 'HelloWorld' is mostly an instance of NativeScript
	print("HelloWorld: ", HelloWorld)
	print("typeof:     ", typeof(HelloWorld))
	print("get_class:  ", HelloWorld.get_class())
	print()

	var new_hello_world = HelloWorld.new()
	print("[Example] _ready: Created new_hello_world: ", new_hello_world)

	var hello = new_hello_world.make_another()
	print("[Example] _ready: Called make_another: ", hello)

	var hello2: HelloWorld = hello
	print("[Example] _ready: Assigned GDScript var: ", hello2)

	# Exit afterwards; should return exit code 0 if no crash
	get_tree().quit()

Invocation from command line (Windows 10, Cmder terminal):
λ godot
Godot Engine v3.4.4.stable.official.419e713a2 - https://godotengine.org
OpenGL ES 3.0 Renderer: NVIDIA GeForce GTX 1650 with Max-Q Design/PCIe/SSE2
OpenGL ES Batching: ON

[Example] _ready: Start
HelloWorld: [NativeScript:1233]
typeof:     17
get_class:  NativeScript

[HelloWorld] new
[Example] _ready: Created new_hello_world: [Node:1246]
[HelloWorld] make_another
[Example] _ready: Called make_another: [Node:1248]

λ echo %errorlevel%
-1073741819

As you see, the Assigned GDScript var statement is not printed, and the exit code is something undefined, i.e. the engine crashed. Since the crash occurs in a pure GDScript line (assigning one var to another), it seems likely that the problem is not directly related to godot-rust; especially because the hello variable itself was printed successfully before.
I think for now, the best workaround is to use the "most-derived Godot class" as a type, i.e. Node in your case. If you find something regarding the official type-hint status in Godot, let me know!
By the way, these things should all be fixed in Godot 4, since GDExtension is a much more robust and better-integrated way of registering custom classes. You will also not need .gdns files anymore.

Given the above, I'm not sure if godot-rust can do anything to fix this. Does someone know if godot-cpp has the same issue?
If there are no more ideas on the topic, I am probably going to close the issue.

Given the discussion above, this is probably better reconsidered as a documentation issue. We could add a "known limitations" section to the FAQ, where we collect information about things outside our control like this, or the "abstract class" problem.

Great idea! I created the issue https://github.com/godot-rust/book/issues/86, which also links to the "abstract class" issue.
Feel free to add more suggestions there.
Do we also want to mention this in the API docs, maybe under #[derive(NativeClass)]? We could link to the book page.
If not, there is nothing left to do in this repo and we can close this issue.


windows-2022 support

:wave: hello!
It looks like GitHub is rolling out windows-2022 as the new default windows-latest according to this changelog post. I've seen some builds on windows-latest start to fail recently, like this one, on the setup-beam step because the ImageOS env var is set to win22 which is not yet mapped.
 If you're using a self-hosted runner, you should set 'env': 'ImageOS': ... to one of the following: ['ubuntu18', 'ubuntu20', 'win19']
2022-02-14T15:05:34.5748197Z Post job cleanup.
2022-02-14T15:05:36.9350557Z [command]"C:\Program Files\Git\bin\git.exe" version
2022-02-14T15:05:36.9595925Z git version 2.35.1.windows.2
2022-02-14T15:05:36.9662090Z [command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp core\.sshCommand
2022-02-14T15:05:36.9954046Z [command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
2022-02-14T15:05:37.6290467Z [command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2022-02-14T15:05:37.6527605Z http.https://github.com/.extraheader
2022-02-14T15:05:37.6569561Z [command]"C:\Program Files\Git\bin\git.exe" config --local --unset-all http.https://github.com/.extraheader
2022-02-14T15:05:37.6845500Z [command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
2022-02-14T15:05:38.4291335Z Cleaning up orphan processes

Maybe it's as easy as treating win22 the same as win19?

This is now available in v1.11.0.


When changing view position, y_rot is updated to the nearest multiple of 2*Pi instead of 0, reducing spinning

Extensions to other viewing modes would need to be made as well, as shifting to a side view will still cause spinning.

Related #11619

Your PR contains lots of unrelated commits, you likely did a wrong operation when trying to rebase on the master branch. See http://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html for git usage tips :)

Yeah, I noticed that and was worried I had done something wrong. I'll read through this. Sorry about the hassle.

It seems a bit hacky to me, I'd expect the x and y rotations for those pre-defined views to always be in [0; 2PI[ and not to change based on the preview context. Surely there should be another way to prevent spinning in such cases?

The two possible ways of fixing this that I could see were:
1, Modifying the view interpolation code to account for the real angle, not an unbounded number (the cause of the spinning)
2, Modifying the pre-defined view to calculate the nearest required rotation.
1 was preferred, but I couldn't see anything wrong with 2. My logic was that rotating the camera takes you out of that [0:2PI] range anyway, and doing it this way I wouldn't risk interfering with anything else. It is slightly hacky but the logic is there.
I wasn't aware of the stepify function, thank you for that. That makes things easier.


About object detection training

Dear authors
Thank you for the great paper and its model architecture.
I have some questions related to the object detections in your paper.
In Section 4.2 (Object Detection), it is written as the following:

We validate PiT through object detection on COCO dataset [24] in Deformable-DETR [44]. ... Since the original image resolution is too large for transformer-based backbones, we halve the image resolution for training and test of all backbones.

So, my questions are

Is PiT for object detection trained with a fixed size of 667 by 400 (half of 1333 and 800)? If so, were the images zero padded in case where the resized images were smaller than the size (667 by 400)?
For object detection, it is clear that the input data size are different than the data for image classification. Then, does patch size of PiT changes? or the number of patches changes?
If number of patches for detection were kept the same as for the image classification, than does the patch embedding (conv_embedding) has larger kernel sizes?

Thank you in advance.

Hi @louis624
Thank you for your interest in our paper.
Here are my answers.
1. Is PiT for object detection trained with a fixed size of 667 by 400 (half of 1333 and 800)? If so, were the images zero padded in case where the resized images were smaller than the size (667 by 400)?
I'm sorry for make confusion. I will explain our detection setting in detail.
We changed these lines from the official Deformable-DETR code.
https://github.com/fundamentalvision/Deformable-DETR/blob/11169a60c33333af00a4849f1808023eba96a931/datasets/coco.py#L132-L152
Original
    scales = [480, 512, 544, 576, 608, 640, 672, 704, 736, 768, 800]

    if image_set == 'train':
        return T.Compose([
            T.RandomHorizontalFlip(),
            T.RandomSelect(
                T.RandomResize(scales, max_size=1333),
                T.Compose([
                    T.RandomResize([400, 500, 600]),
                    T.RandomSizeCrop(384, 600),
                    T.RandomResize(scales, max_size=1333),
                ])
            ),
            normalize,
        ])

    if image_set == 'val':
        return T.Compose([
            T.RandomResize([800], max_size=1333),
            normalize,
        ])

Ours
    scales = [400 - i * 16 for i in range(11)]

    if image_set == 'train':
        return T.Compose([
            T.RandomHorizontalFlip(),
            T.RandomSelect(
                T.RandomResize(scales, max_size=666),
                T.Compose([
                    T.RandomResize([200, 250, 300]),
                    T.RandomSizeCrop(192, 300),
                    T.RandomResize(scales, max_size=666),
                ])
            ),
            normalize,
        ])

    if image_set == 'val':
        return T.Compose([
            T.RandomResize([400], max_size=666),
            normalize,
        ])

So, it is not the fixed size setting and we didn't use extra code for zero padding.
2. For object detection, it is clear that the input data size are different than the data for image classification. Then, does patch size of PiT changes? or the number of patches changes?
3. If number of patches for detection were kept the same as for the image classification, than does the patch embedding (conv_embedding) has larger kernel sizes?
When the input size changes, PiT uses a different number of patches.
We didn't change the kernel size of patch_embedding for object detection.
I think PiT code used for Deformable-DETR can be a clear answer to this question.
We use features instead of cls_token in image classification.
We also interpolate pos_embed when the network processes a different input size.
But, we didn't change the kernel_size of patch_embedding
class PoolingTransformer(nn.Module):
    def __init__(self, image_size, patch_size, stride,
                 num_classes, base_dims, depth, heads, mlp_ratio, in_chans=3,
                 attn_drop_rate=.0, drop_rate=.0, drop_path_rate=.0,
                 replace_stride_with_dilation=None):
        super(PoolingTransformer, self).__init__()

        total_block = sum(depth)
        padding = 0
        block_idx = 0

        if replace_stride_with_dilation is None:
            replace_stride_with_dilation = [False, False]
        self.dilation = 1

        width = math.floor(
            (image_size + 2 * padding - patch_size) / stride + 1)

        self.base_dims = base_dims
        self.heads = heads
        self.num_classes = num_classes

        self.patch_size = patch_size
        self.pos_embed = nn.Parameter(
            torch.randn(1, base_dims[0] * heads[0], width, width),
            requires_grad=True)
        self.patch_embed = conv_embedding(in_chans, base_dims[0] * heads[0],
                                          patch_size, stride, padding)

        self.cls_token = nn.Parameter(
            torch.randn(1, 1, base_dims[0] * heads[0]),
            requires_grad=True)
        self.pos_drop = nn.Dropout(p=drop_rate)

        self.transformers = nn.ModuleList([])
        self.pools = nn.ModuleList([])

        for stage in range(len(depth)):
            drop_path_prob = [drop_path_rate * i / total_block
                              for i in
                              range(block_idx, block_idx + depth[stage])]
            block_idx += depth[stage]

            self.transformers.append(
                Transformer(base_dims[stage], depth[stage], heads[stage],
                            mlp_ratio,
                            drop_rate, attn_drop_rate, drop_path_prob)
            )
            if stage < len(heads) - 1:
                stride = 2
                if replace_stride_with_dilation[stage]:
                    self.dilation *= stride
                    stride = 1
                self.pools.append(
                    conv_head_pooling(base_dims[stage] * heads[stage],
                                      base_dims[stage + 1] * heads[stage + 1],
                                      stride=stride,
                                      dilation=self.dilation)
                )

        self.norm = nn.LayerNorm(base_dims[-1] * heads[-1], eps=1e-6)

        # Classifier head
        self.head = nn.Linear(base_dims[-1] * heads[-1],
                              num_classes) if num_classes > 0 else nn.Identity()

        trunc_normal_(self.pos_embed, std=.02)
        trunc_normal_(self.cls_token, std=.02)
        self.apply(self._init_weights)

    def _init_weights(self, m):
        if isinstance(m, nn.LayerNorm):
            nn.init.constant_(m.bias, 0)
            nn.init.constant_(m.weight, 1.0)

    @torch.jit.ignore
    def no_weight_decay(self):
        return {'pos_embed', 'cls_token'}

    def get_classifier(self):
        return self.head

    def reset_classifier(self, num_classes, global_pool=''):
        self.num_classes = num_classes
        self.head = nn.Linear(self.embed_dim,
                              num_classes) if num_classes > 0 else nn.Identity()

    def no_grad_head(self):
        self.head.weight.requires_grad_(False)
        self.head.bias.requires_grad_(False)
        self.norm.weight.requires_grad_(False)
        self.norm.bias.requires_grad_(False)

    def change_resolution(self, h, w):
        self.pos_embed = nn.Parameter(
            F.interpolate(self.pos_embed.data, (h, w), mode='bicubic'),
            requires_grad=True
        )

    def forward_features(self, x):
        x = self.patch_embed(x)

        if x.shape[2:4] == self.pos_embed.shape[2:4]:
            pos_embed = self.pos_embed
        else:
            pos_embed = F.interpolate(self.pos_embed, x.shape[2:4],
                                      mode='bicubic')

        x = self.pos_drop(x + pos_embed)
        cls_tokens = self.cls_token.expand(x.shape[0], -1, -1)

        features = []

        for stage in range(len(self.pools)):
            x, cls_tokens = self.transformers[stage](x, cls_tokens)
            features.append(x)
            x, cls_tokens = self.pools[stage](x, cls_tokens)
        x, cls_tokens = self.transformers[-1](x, cls_tokens)

        features.append(x)

        return features, cls_tokens

    def forward(self, x):
        features, cls_tokens = self.forward_features(x)
        return features

I hope my answers solve your questions about our detection setting.
Please let me know if you have any further questions.
Best

Thank you for the detailed explanation about my questions!!!
Just one more question about the architecture.
In the architecture that you have shared, there is dilation argument for conv_head_pooling which does not exist conv_head_poling class.
self.pools.append(
                    conv_head_pooling(base_dims[stage] * heads[stage],
                        base_dims[stage + 1] * heads[stage + 1], stride=stride, dilation=self.dilation)
                )

In this case, since self.dilation is just 1, which is the default value of torch.nn.Conv2d, can I just ignore the dilation?
Thank you!

Yes. you can ignore the dilation option.
Because Deformable-DETR supports the dilation option for backbone network, I implemented it for PiT.
But, I didn't use it for experiments. So, you can simply ignore it.

Great! Thank you for the detailed explanations!!


Nit: Remove py.typed file that makes Pyright incessant

Pyright is incredibly incessant about symbols not being exported due to the presence of the py.typed file but not following the rules on imports denoted here
https://microsoft.github.io/pyright/#/typed-libraries?id=library-interface
Solutions

either adhere to the rules, meaning employ redundant imports like from dlt.common.configuration.accessors import config as config

use __all__ in files where names are being exported, especially in dlt/__init__.py

remove the py.typed file

I have done the latter. The static type checkers used in LSPs (like pyright, which majority use) are very incessant otherwise and I end up with this ugly bit all over my code type: ignore[import] just to silence errors.
If you prefer using __all__ we can do that too

Mypy still needs py.typed, or has that changed?
In that case dlt+mypy users will get missing import errors.
So I'd say rather use all.
Does this issue affect pyright users importing dlt in their own projects?

Yes any pyright user importing dlt gets LSP errors (not even warnings, but actual errors) when using common dlt components @steinitzu
I can post screenshot too

So I'd say rather use all.

Ok got it

Yes any pyright user importing dlt gets LSP errors (not even warnings, but actual errors) when using common dlt components @steinitzu I can post screenshot too

Got you, wasn't clear whether it's just when working in the dlt codebase.  Then definitely we should fix this imo.
Enabling F401 in flake8 helps catch this too, currently ignored in our config.

@z3z1ma is this a lot of work to add all? @steinitzu feel free to help here ie. by enabling linting and fixing imports. I'd rather keep py.typed.

Started adding __all__ here, good opportunity to remove unused imports at the same time. But it's a lot of busywork ...

Started adding __all__ here, good opportunity to remove unused imports at the same time. But it's a lot of busywork ...

that can be done automatically. let's do all whenever necessary and then merge this. at least this is my take :)

LGTM @rudolfix
Before

After

Thx @steinitzu


GetSymbolsAsync fails

GetExchangeInfoAsync is responding with a new JSON structure - more entries in the "filters" array. Method fails trying to get LOT_SIZE properties because its not at index 1 any more.
I've got a  fix for this already, do you guys accept push requests?

@bobby-coinstorm, thanks for mentioning this issue. I have been working on other changes so I started looking into this too. I would be interested in seeing your fix (btw, there are no "guys", it's just me).
So far I have found this to be significantly more than just changing indexes since they also broke the existing "PRICE_FILTER" by not including the actual values. I have a potential fix to keep the related validation working, but there are aspects that are probably unfinished or incorrect and certainly not to my liking. Regardless, there is probably no rush to release this since it has apparently been broken since 11-13....

Thanks for the quick response on this. My "fix" is very to what you have - actually you seem to handle the case even better so I'm going to use that in my tests for now until the package update is out. So far so good, I'll let you know if I find any issues.

@bobby-coinstorm, let me know if you find any issues with 0.2.0-beta9. Thanks.


Add CodeSandbox as example deployment to documentation

CodeSandbox now has a CLI that will allow you to deploy your create-react-app projects to CodeSandbox. I added this as documentation in the user-guide. I thought that the deployment section comes most close to what I'm trying to document, but I'm open to suggestions if you know a better place!
Related issue: https://github.com/facebookincubator/create-react-app/issues/169.

Sorry this never merged, I'm not sure if we already have this in the docs.
If it's still missing I'd be more than happy to take a fresh one!
Then again, I'm not sure if we want to suggest deploying to an "example" deployment over typical deployments.
If we add it, can we toss it to the bottom of the list?


bug in leaflet-heatmap if layer is not enabled by default

Say you do not add the heatmap layer to the list of layers on map creation but rather as an optional overlay that is not shown by default.
If you then select the layer in the selection control, onAdd() never gets called which means _heatmap is not initialized and the code fails on line 125 in _update:
this._heatmap.setData(generatedData);
The workaround is to add the layer to the layers list on map creation, but then immediately remove it again. Then showing/hiding the layer with the layers control works as expected.
Working off develop branch

Fixed and will be part of the next tagged version :)


Run Oracle as arbitrary user in Openshift

Is it possible to run gvenzl/oracle-xe:18-slim as an arbitrary user in OpenShift/Kubernetes?
If I try to run it, with modified Image with:
RUN chgrp -R 0 $ORACLE_BASE &&            chmod -R g+rwX $ORACLE_BASE
which is mentioned in OpenShift documentary: https://docs.openshift.com/container-platform/3.11/creating_images/guidelines.html#openshift-specific-guidelines
Iam getting following failing startup process:
#############
#Log Start#####
#############
CONTAINER: starting up...
CONTAINER: database already initialized.
CONTAINER: starting up Oracle Database...
LSNRCTL for Linux: Version <IP_ADDRESS>.0 - Production on 07-OCT-2022 17:05:34
Copyright (c) 1991, 2018, Oracle.  All rights reserved.
Starting /opt/oracle/product/18c/dbhomeXE/bin/tnslsnr: please wait...
TNSLSNR for Linux: Version <IP_ADDRESS>.0 - Production
System parameter file is /opt/oracle/product/18c/dbhomeXE/network/admin/listener.ora
Log messages written to /opt/oracle/diag/tnslsnr/oracle-keycloak-int-0/listener/alert/log.xml
Listening on: (DESCRIPTION=(ADDRESS=(PROTOCOL=ipc)(KEY=EXTPROC_FOR_XE)))
Listening on: (DESCRIPTION=(ADDRESS=(PROTOCOL=tcp)(HOST=<IP_ADDRESS>)(PORT=1521)))
Connecting to (DESCRIPTION=(ADDRESS=(PROTOCOL=IPC)(KEY=EXTPROC_FOR_XE)))
STATUS of the LISTENER
Alias                     LISTENER
Version                   TNSLSNR for Linux: Version <IP_ADDRESS>.0 - Production
Start Date                07-OCT-2022 17:05:34
Uptime                    0 days 0 hr. 0 min. 0 sec
Trace Level               off
Security                  ON: Local OS Authentication
SNMP                      OFF
Default Service           XE
Listener Parameter File   /opt/oracle/product/18c/dbhomeXE/network/admin/listener.ora
Listener Log File         /opt/oracle/diag/tnslsnr/oracle-keycloak-int-0/listener/alert/log.xml
Listening Endpoints Summary...
(DESCRIPTION=(ADDRESS=(PROTOCOL=ipc)(KEY=EXTPROC_FOR_XE)))
(DESCRIPTION=(ADDRESS=(PROTOCOL=tcp)(HOST=<IP_ADDRESS>)(PORT=1521)))
The listener supports no services
The command completed successfully
ERROR:
ORA-12547: TNS:lost contact
SP2-0306: Invalid option.
Usage: CONN[ECT] [{logon|/|proxy} [AS {SYSDBA|SYSOPER|SYSASM|SYSBACKUP|SYSDG|SYSKM|SYSRAC}] [edition=value]]
where  ::= [/][@<connect_identifier>]
 ::= [][/][@<connect_identifier>]
SP2-0306: Invalid option.
Usage: CONN[ECT] [{logon|/|proxy} [AS {SYSDBA|SYSOPER|SYSASM|SYSBACKUP|SYSDG|SYSKM|SYSRAC}] [edition=value]]
where  ::= [/][@<connect_identifier>]
 ::= [][/][@<connect_identifier>]
SP2-0157: unable to CONNECT to ORACLE after 3 attempts, exiting SQL*Plus`
#############
#Log End######
#############
I guess the issue appears when "lsnrctl start" is executed in line 349 of the container-entrypoint.sh script.
It is not possible to know the user id, when building the image. It is a randomly assinged id on container startup in OpenShift.

It's certainly a territory that I haven't moved myself on yet so I cannot provide much insight into how much or if this works. What I do know is that the user starting the Oracle Database has to be in the dba group, that's the group that is linked to the SYSDBA system privilege.
I just managed to start up the database with a new user test that I have created and added to dba:
bash-4.4# useradd test
bash-4.4# id test
uid=54322(test) gid=54331(test) groups=54331(test)
bash-4.4# usermod -a -G dba test
bash-4.4# id test
uid=54322(test) gid=54331(test) groups=54331(test),54322(dba)
bash-4.4# chown -R test:test /opt/oracle
bash-4.4# chmod -R g+rwX /opt/oracle

[test@3e9adf69d463 oracle]$ id
uid=54322(test) gid=54331(test) groups=54331(test),54322(dba)
[test@3e9adf69d463 oracle]$ sqlplus / as sysdba

SQL*Plus: Release <IP_ADDRESS>.0 - Production on Sun Oct 9 16:54:58 2022
Version <IP_ADDRESS>.0

Copyright (c) 1982, 2021, Oracle.  All rights reserved.

Connected to an idle instance.

SQL> startup;
ORACLE instance started.

Total System Global Area<PHONE_NUMBER> bytes
Fixed Size		    9685328 bytes
Variable Size		  318767104 bytes
Database Buffers	  905969664 bytes
Redo Buffers		    7090176 bytes
Database mounted.
Database opened.
SQL>

But again, how supported/wise this is, I do not know.

Hi @teceP,
As @mprins pointed out, XE can be used in production but it does have the outlined constraints that you should be aware of!
I'll close this question for now, if you have any more, feel free to open it again.

Thank you for investing your time!
What do you mean with outlined constraints?

What @mprins has said above, be aware that Oracle XE is unsupported: https://www.oracle.com/database/technologies/appdev/xe/faq.html#prod


google charts examples added in iruby notebook

Adding all charts examples present in https://developers.google.com/chart/interactive/docs/gallery

geo charts :  http://nbviewer.jupyter.org/github/shekharrajak/daru-view/blob/examples/spec/dummy_iruby/Google Charts | Geo Charts examples.ipynb
scatter charts : http://nbviewer.jupyter.org/github/shekharrajak/daru-view/blob/examples/spec/dummy_iruby/Google Charts | Scatter Chart.ipynb

This is beautiful! You should surely document all of it in a blog post with lots of pictures of the output. I'm sure people will love it.
Also this makes for some great talk presentations too :)


feature request: run as service with auto-reconnect.

Have ability to run as a service. If the connection drops it will automatically reconnect.

I don't have any issues providing an upstart/system d script for this. Would you expect the installer to prompt and ask if you want to install the service and then ask which "flavor" of service to install?

yeah some kind of prompt to configure the default settings like tcp/udp and what server you want would be nice. Maybe a conf file somewhere to edit it if you ever need to change the settings... This would be awesome for my use case.

Yeah changing the settings after the fact is the trickier part since the non-interactive mode is currently all flag based. The service script would need the output of a "dry-run" to be contained within it...
Maybe there's something like a --service -s flag that will output the file to stdout if run without elevated privilege and put the file in place if run with sudo. It could optionally take a name which would default to proxpn so multiple services could be created if needed?

Bleh, automating this could prove tricky for UX... maybe it would be better to provide service template files in the repo and document how to use them and folks could directly paste the dry run commands into them?

I have to admit i'm not sure I've never made a service before :/
What i've ended up doing so far is I made a crontab
if ps -ef | grep -v grep | grep openvpn ; then
exit 0
else
/usr/local/bin/proxpn -p udp -r SanJose
fi
The problem with my crontab that i've run into so far is that loosing connection does not always terminate openvpn. So every other day or so I have to go manually "killall openvpn" to get the connection working again.

yeah the crontab option will kind of work but really you probably want to use upstart or systemd with a respawn directive.
I was under the impression that the resolv-retry option https://github.com/MattSurabian/proxpn-bash-client/blob/master/proxpn.ovpn#L9-L10 would terminate the script on connection drop if it wasn't able to reconnect after 30 seconds. If that's not happening we might need a self termination thing setup on -down. Once the script has terminated the service controller (upstart/systemd) should trigger respawn immediately.

Development here is delayed because I wanted to come up with an automated test harness that would close the network connection and confirm functionality but haven't had the time.

Hey just realized I never got back to you on this. This is how I ended up solving it. Crontab run every 5 mins.
if ping google.com -c 1 ; then
exit 0
else
/usr/local/bin/proxpn -p udp -r NYC
fi
I've setup firewall rules so that the machine can only get internet traffic if the connection it up. Otherwise the ping fails.
I thought I would leave this here incase it helps others.


Fix build artifact download for publish

Pull Request Test Coverage Report for Build ccb2f3e88c5ac44a5fbdf55c94db91e4fbac8767-PR-1032

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.957%

Totals

Change from base Build 4e3d8dcb62e16afabd3afeb32a23d1ec39d682b4:
0.0%

Covered Lines:
1147

Relevant Lines:
1739

💛  - Coveralls


User GUI annotation interface

[x] save annotations in project
[x] color annotations in table viewer
[x] generate yaml from annotations
[x] improve annotation colors (selection border black, type border matched to type)
[x] create a generic table component to support yaml, annotation, and other modes
[x] add file tree support for switching between annotations/yamls
[x] enable editing and deleting existing annotation blocks
[x] handle switching between annotation / preview mode

broken down in more detail in dedicated project board: https://github.com/usc-isi-i2/t2wml/projects/3

part 1 is done as of version 2.6.0
additional issues from the project board/elsewhere consolidated in issue #322

part 1 is done as of version 2.6.0
additional issues from the project board/elsewhere consolidated in issue #322


Correct composer.json package

This should solve https://github.com/MicrosoftDocs/azure-docs/issues/29028
The previous version of this part of the tutorial had the package "microsoft/azure-storage" which composer complains is abandoned, but even worse is that the following PHP code snippets in the tutorial also wont work until you install the correct package "microsoft/windowsazure".

#sign-off

@axisc: I'm sorry - only the author of this article, @spelluru, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#sign-off


redirect to dash

OK to avoid issues with Heroku I'll just change the Readme and leave everything else in place for now.


Failed to build in debug mode

When I build this in debug mode with cxx flag -rdynamic, I got undefined reference issue
libsdptransform-src/test/parse.test.cpp:550: undefined reference to `sdptransform::parse(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&)'

We don't know what the -rdynamic flag means and honestly we don't have time to investigate it.


Window.FullscreenIsBorderlessWindow is ignored and causes "Could not recreate all objects."

Release Type: nuget
Version: <IP_ADDRESS>4
Platform(s): Windows
Describe the bug
When you go full screen using Alt-Enter on the following sample, you get "Could not recreate all objects."
Furthermore, the app resolution in full screen doesn't even match desktop resolution.
To Reproduce
using Stride.Core.Mathematics;
using Stride.Engine;
using Stride.Games;
using Stride.Input;

namespace StrideTest;

internal class Game1 : Game
{
    protected override void Update(GameTime gameTime)
    {
        if (Input.IsKeyPressed(Keys.Escape))
            Exit();

        base.Update(gameTime);
    }

    protected override Task LoadContent()
    {
        Window.AllowUserResizing = true;
        Window.FullscreenIsBorderlessWindow = true;
        return base.LoadContent();
    }

    protected override void Draw(GameTime gameTime)
    {
        var color = new Color4((float)(gameTime.Total.TotalSeconds % 1.0f), 0, 0);

        GraphicsContext.CommandList.Clear(GraphicsContext.CommandList.RenderTarget, color);

        base.Draw(gameTime);
    }
}

callstack.txt
System.InvalidOperationException
  HResult=0x80131509
  Message=Could not recreate all objects.
  Source=Stride.Graphics
  StackTrace:
   at Stride.Graphics.ResumeManager.OnRecreate()
   at Stride.Games.GraphicsDeviceManager.CreateDevice(GraphicsDeviceInformation newInfo)
   at Stride.Games.GraphicsDeviceManager.ChangeOrCreateDevice(Boolean forceCreate)
   at Stride.Games.GraphicsDeviceManager.Window_ClientSizeChanged(Object sender, EventArgs e)
   at Stride.Games.GameWindow.OnClientSizeChanged(Object source, EventArgs e)
   at Stride.Games.GameFormSDL.GameForm_ResizeEndActions(WindowEvent e)
   at Stride.Graphics.SDL.Window.ProcessEvent(Event e)
   at Stride.Graphics.SDL.Application.ProcessEvent(Event e)
   at Stride.Games.SDLMessageLoop.NextFrame()
   at Stride.Games.SDLMessageLoop.Run(Window form, RenderCallback renderCallback)
   at Stride.Games.GameWindowSDL.Run()
   at Stride.Games.GameBase.Run(GameContext gameContext)
   at StrideTest.Program.Main(String[] args) in C:\Users\aybe\Documents\Stride Projects\MyGame\StrideTest\Program.cs:line 11

Related to #1493

I found a temporary workaround, setting the preferred full screen size makes the error vanish actually:
using Stride.Core.Mathematics;
using Stride.Engine;
using Stride.Games;
using Stride.Input;

namespace StrideTest;

internal class Game1 : Game
{
    protected override void Update(GameTime gameTime)
    {
        if (Input.IsKeyPressed(Keys.Escape))
            Exit();

        base.Update(gameTime);
    }

    protected override Task LoadContent()
    {
        var w = GraphicsDevice.Adapter.Outputs[0].CurrentDisplayMode.Width;
        var h = GraphicsDevice.Adapter.Outputs[0].CurrentDisplayMode.Height;
        Window.PreferredFullscreenSize = new Int2(w, h);
        Window.AllowUserResizing = true;
        Window.FullscreenIsBorderlessWindow = true;
        return base.LoadContent();
    }

    protected override void Draw(GameTime gameTime)
    {
        var color = new Color4((float)(gameTime.Total.TotalSeconds % 1.0f), 0, 0);

        GraphicsContext.CommandList.Clear(GraphicsContext.CommandList.RenderTarget, color);

        base.Draw(gameTime);
    }
}

I am also interested in the problem because it also occurs in OpenGL on Linux.
Interestingly, if you set FullscreenIsBorderlessWindow to true, it is possible to set fullscreen mode but you can no longer exit it.

Here is result of trying to exit fullscreen mode.
Unhandled exception. System.Exception: Depth buffer is not the same size as the render target
   at Stride.Graphics.CommandList.SetRenderTargetsImpl(Texture depthStencilBuffer, Int32 renderTargetCount, Texture[] renderTargets)
   at Stride.Graphics.CommandList.SetRenderTargets(Texture depthStencilView, Int32 renderTargetViewCount, Texture[] renderTargetViews)
   at Stride.Rendering.Compositing.ForwardRenderer.ResolveDepthAsSRV(RenderDrawContext context) in ...stride/sources/engine/Stride.Engine/Rendering/Compositing/ForwardRenderer.cs:line 821

Looks like FullScreenSize is hardcoded, that's really bad


add new test spec for smart contract dual state scenarios

add new test spec for smart contract dual state scenarios
fix issue with signed tx failing by explicitly sending gas price and nonce
change solc version to 0.4.21 as 0.5.0 is causing issue when calling one contract from another contract (byte code differences)

This PR https://github.com/jpmorganchase/quorum/pull/592 will fix the issue with Solc 0.5.0


Defer loading zxcvbn

Defer loading zxcvbn.js until we actually need it. Greys out the password strength bar until the zxcvbn is loaded.
Fixes https://github.com/zulip/zulip/issues/263.

Automated message from Dropbox CLA bot
@porterjamesj, it looks like you've already signed the Dropbox CLA. Thanks!

@porterjamesj this looks awesome!

Have you tested that registering with password and password reset confirm still works?
How much does this decrease the total page weight?

@timabbott

yep
I'm not sure! I'm not familiar enough with frontend tooling to know how to measure this :)

The test failures are because master was broken; can you rebase (actually would wait ?
I think the only other TODO thing for this is figuring out why we couldn't see it being downloaded in development before your patch.

@timabbott I figured this out. zxcvbn only gets loaded if page_params.password_auth_enabled !== false, which isn't normally the case. Turning it on shows page weight decreasing from 3.4MB to 2.7MB in dev.

(also rebased)

Ahh, yeah, that makes a lot of sense!  Glad we got to the bottom of it.
I'll review and hopefully merge tomorrow.

Travis CI reports two test failures:

The linter (run as part of the backend tests) fails on a whitespace issue
The Casper frontend tests fail on the password change form, which I'm pretty sure is caused by this change.  I think you can fix it by adding a wait for the "change password" button to become active before clicking it.

@porterjamesj just wanted to check in on whether you need any help debugging the Casper issue here.

bah, sorry—i have not had time to get to it, been busy. i can't imagine it will be difficult, just need to find the time 😕

@timabbott ok, finally have a bit of time to spend on this—when i run ./tools/test-js-with-casper 05-settings.js, it hangs forever at Waiting for test server........ and just continues printing dots.

That probably means the server is failing to start.  Check out frontend_tests/casper_tests/server.log.  I bet you need to reprovision your dev environment.

server.log is full of
[22/Jun/2016 16:47:25]"GET /accounts/home HTTP/1.0" 500 59
Traceback (most recent call last):
  File "/usr/lib/python2.7/wsgiref/handlers.py", line 85, in run
    self.result = application(self.environ, self.start_response)
  File "/srv/zulip-venv-cache/0227edfb963fd4df12824323e220dc488bc913d4/zulip-venv/local/lib/python2.7/site-packages/django/core/handlers/wsgi.py", line 170, in __call__
    self.load_middleware()
  File "/srv/zulip-venv-cache/0227edfb963fd4df12824323e220dc488bc913d4/zulip-venv/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 52, in load_middleware
    mw_instance = mw_class()
  File "/srv/zulip-venv-cache/0227edfb963fd4df12824323e220dc488bc913d4/zulip-venv/local/lib/python2.7/site-packages/django/middleware/locale.py", line 24, in __init__
    for url_pattern in get_resolver(None).url_patterns:
  File "/srv/zulip-venv-cache/0227edfb963fd4df12824323e220dc488bc913d4/zulip-venv/local/lib/python2.7/site-packages/django/core/urlresolvers.py", line 402, in url_patterns
    patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
  File "/srv/zulip-venv-cache/0227edfb963fd4df12824323e220dc488bc913d4/zulip-venv/local/lib/python2.7/site-packages/django/core/urlresolvers.py", line 396, in urlconf_module
    self._urlconf_module = import_module(self.urlconf_name)
  File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/srv/zulip/zproject/urls.py", line 7, in <module>
    import zerver.forms
  File "/srv/zulip/zerver/forms.py", line 16, in <module>
    from zerver.lib.actions import do_change_password, is_inactive
  File "/srv/zulip/zerver/lib/actions.py", line 63, in <module>
    from zerver.lib.push_notifications import num_push_devices_for_user, \
  File "/srv/zulip/zerver/lib/push_notifications.py", line 9, in <module>
    from apnsclient.apns import Connection
ImportError: cannot import name Connection

even running python provision.py

I seem to have somehow ended up with a newer version of apns-client than the one specified in requirements.txt manually uninstalling and reinstalling the correct one appears to have done the trick.

Yeah, we downgraded that package in development, because it didn't match the version used in production.
In theory, rerunning provision.py should have fixed this.  Oh, I bet you maybe needed to reactive the virtualenv after doing so, and I left that out of the instructions.

@timabbott OK, fixed style/tests, I think this is good to go now.

Looks great!  I fixed the indentation on the Casper test to preserving 4 spaces, and did some tweaks to the commit message (including adding Fixes: #263 to make it auto-close the original issue), and merged this.  Thanks @porterjamesj!


GUACAMOLE-252: Ensure display container is explicitly sized to cover the vertical area of its container.

It seems MS Edge does not always stretch display: table-cell elements to fit the vertical space of their display: table parents. This seems like a layout bug to me, but I can't find any confirmation from standards one way or the other.
In any case, explicitly specifying height: 100% makes things work as expected across the board.

Glad the fix was simple! :shipit:


Specify properties for serialized behavior

I'd like to create an AWS::S3::BucketNotification resource to fix a longstanding problem in CloudFormation. And when I do, I'd like to enable individual notification configuration items to be managed separately. But because the API only supports updating the entire notification configuration, I need to serialize access to the notification configuration for a given bucket. I plan to do with a resource provider that relies on a user-account-side mechanism involving an SQS FIFO queue. It would be great if, in my schema, I could specify a property or set of properties that would cause all resources with the same values for those properties to have their requests serialized (but resources with different values for those properties could be processed in parallel).

I like this concept, it's going to take some thinking on how to support this in the service.

Adding DynamoDB tables as a use case (from the docs):

AWS CloudFormation typically creates DynamoDB tables in parallel. However, if your template includes multiple DynamoDB tables with indexes, you must declare dependencies so that the tables are created sequentially. Amazon DynamoDB limits the number of tables with secondary indexes that are in the creating state. If you create multiple tables with indexes at the same time, DynamoDB returns an error and the stack operation fails.

Adding DynamoDB tables as a use case

This might be a separate request, as it is a global concurrency limit (possibly soft), rather than a strict serialization based on the value of a property or set of properties. I'm tempted to say such a concurrency limit belongs in the registry API rather than the schema.

This might be a separate request
You're right. In cases where ordering doesn't matter Concurrency: 1 could also solve the serialization (if it can be currently solved with DependsOn).

@rjlohan If i create a new ticket for that, should it go in the Coverage Roadmap?

This might be a separate request

You're right. In cases where ordering doesn't matter Concurrency: 1 could also solve the serialization (if it can be currently solved with DependsOn).
@rjlohan If i create a new ticket for that, should it go in the Coverage Roadmap?

Yeah put it there. It'll require at least some service side changes to understand the directive whether it comes from template or type schemas.


Disable zippered catalyst builds again

This patch does two things. One, zippers the Onone support library that I missed in the first pass.
Two, disables the catalyst build again. The open-source SwiftC appears to be missing something for catalyst, which would result in a miscompile situration.
The failing test:
SILGen/availability_query_maccatalyst_zippered_canonical_versions.swift
if #available(OSX 10.16, iOS 51.1.2, *) {
}

The expectation is that we check for both macOS and iOS version numbers in a catalyst build;
// CHECK: [[MACOS_MAJOR:%.*]] = integer_literal $Builtin.Word, 10
// CHECK: [[MACOS_MINOR:%.*]] = integer_literal $Builtin.Word, 16
// CHECK: [[MACOS_PATCH:%.*]] = integer_literal $Builtin.Word, 0
// CHECK: [[IOS_MAJOR:%.*]] = integer_literal $Builtin.Word, 51
// CHECK: [[IOS_MINOR:%.*]] = integer_literal $Builtin.Word, 1
// CHECK: [[IOS_PATCH:%.*]] = integer_literal $Builtin.Word, 2
// CHECK: [[FUNC:%.*]] = function_ref @$ss042_stdlib_isOSVersionAtLeastOrVariantVersiondE0yBi1_Bw_BwBwBwBwBwtF : $@convention(thin) (Builtin.Word, Builtin.Word, Builtin.Word, Builtin.Word, Builtin.Word, Builtin.Word) -> Builtin.Int1
// CHECK: [[QUERY_RESULT:%.*]] = apply [[FUNC]]([[MACOS_MAJOR]], [[MACOS_MINOR]], [[MACOS_PATCH]], [[IOS_MAJOR]], [[IOS_MINOR]], [[IOS_PATCH]]) : $@convention(thin) (Builtin.Word, Builtin.Word, Builtin.Word, Builtin.Word, Builtin.Word, Builtin.Word) -> Builtin.Int1

Currently, the OSS Swiftc is only emitting checks for macOS. I don't have time at the moment to dig further than that.
The build system should be in a place to handle catalyst builds, but it looks like the compiler is not.

@swift-ci please test

CC: @mikepinkerton
I gave turning on the zippered builds a shot. I don't have time at the moment to dig through the miscompile. Just letting you know that we're turning it back off for the time being.


Add client_credentials grant type support

Fixes gh-51

Hey @jgrandja, I still have a couple of to-dos:

[ ] Support basic auth for client id / secret
[ ] Update sample app to use JWK to sign the token. This should allow to put together an end-to-end demo

With that in mind, feel free to provide any initial feedback you have.

@alek-sys
Regarding

Support basic auth for client id / secret

This is already implemented in ClientSecretBasicAuthenticationConverter

Thanks for feedback @jgrandja! I'm now re-working this PR based on your comments.

Updated based on your comments.
Also, the spec states:

If the issued access token scope is different from the one requested by the client, the authorization server MUST include the "scope" response parameter to inform the client of the actual scope granted.

But currently Token Endpoint always returns scope in the response. Shoud l I fix it in this PR or create a separate story for this (unless there is one already)?

The returned scope will come into play in #42 at a later point. No need to address it in this PR. But feel free to add notes to #42.

Thanks @jgrandja, I've updated this PR. Now there is much better split between converted and provider.

Great thanks @alek-sys. I will review this tomorrow.

@jgrandja updated based on your latest comments. Also, see my comment regarding OAuth2ScopeParser - I think it has some value as it validates scope parameter to be compliant with RFC.

@alek-sys Can you please update the test methods to following the naming convention **methodName**When**Condition**Then**Result**. Take a look at OAuth2TokenEndpointFilterTests and OAuth2AuthorizationCodeAuthenticationProviderTests for examples.
Also, please add integration tests in OAuth2ClientCredentailsGrantTests (new). See OAuth2AuthorizationCodeGrantTests for example.

@jgrandja done. Actually there was OAuth2ClientCredentialsGrantTests class with an integration test already. I updated it a bit to make it more like OAuth2AuthorizationCodeGrantTests. I also changed security configuration for it to be more realistic by overriding authentication entry point to return 401 when client is not authenticated and client_credentials grant is used.

All updated based on your review @jgrandja. I only didn't add @Nullable since scope field is never null. Also, I noticed there is no logging anywhere in the project. Is that intentional or should I add at least debug logging to some of the components?

Thanks for adding this feature @alek-sys !
FYI, I followed up with a polish commit as some changes were needed and I wanted to get this merged.
Let me know if you have any questions regarding the changes in the polish commit.


Do not convert metacharacters to literal characters

This will exclude metacharacters when converting regexps to xpath.
Fixes #729

Pull Request Test Coverage Report for Build 1777

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
54 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.05%) to 96.719%

Files with Coverage Reduction
New Missed Lines
%

lib/watir/capabilities.rb
12
82.93%

spec/watirspec/browser_spec.rb
42
99.68%

Totals

Change from base Build 1776:
-0.05%

Covered Lines:
10437

Relevant Lines:
10791

💛  - Coveralls

Pull Request Test Coverage Report for Build 1777

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
54 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.05%) to 96.719%

Files with Coverage Reduction
New Missed Lines
%

lib/watir/capabilities.rb
12
82.93%

spec/watirspec/browser_spec.rb
42
99.68%

Totals

Change from base Build 1776:
-0.05%

Covered Lines:
10437

Relevant Lines:
10791

💛  - Coveralls


Model save erroneously sends unchanged attributes to API

Issue summary
There are a number of issues coming from the shopify gem erroneously sending the entire object when saving as outlined here almost 6 months ago: https://github.com/Shopify/shopify-api-ruby/issues/1037
The gem should only send the changed attributes to the API, but it sends all fields, leading to API errors.
Changing/Saving any part of a Customer created without an email (phone number only) through the checkout will return
{"email_marketing_consent"=>["An email address is required when setting the email marketing consent."]}
Changing/Saving any part of a Customer with a nil email_marketing_consent.opt_in_level will return
{"email_marketing_consent"=>["Opt in level must exist"]}
Changing/Saving any part of an Order (maybe from POS?) without a shipping address will return
{"shipping_address"=>[": Enter a last name."]}

shopify_api version: 12.3.0
Ruby version: 2.7.2
Operating system: All

Expected behavior
The gem should only send the changed attributes on save, as outlined in https://github.com/Shopify/shopify-api-ruby/issues/1037
Actual behavior
The gem sends all attributes leading to api errors.
Steps to reproduce the problem
see  https://github.com/Shopify/shopify-api-ruby/issues/1037

Still an issue in 12.5.0

Hoping for this week at some point :)

@nelsonwittwer Any chance this could be released by itself in a 12.x?


Deploying and linking libraries in Web3 context

This is an attempt to resolve #37.
Note: Even though it deploys and links the library, the bytecode in the UI does not update. (It still has the unlinked version.)

I think #63 is the right way to handle tryTillResponse(). What do you think?

Re: #63, that seems like a great update for tryTillFinished. The purpose of this PR is to remedy #37.

Absolutely. You did change where tryTrillFinished is used, hence my comment. If it gets merged, you'll need to update this PR though.

The squirrel with no name is ready.
On Monday, June 6, 2016, Alex Beregszaszi<EMAIL_ADDRESS>wrote:

Absolutely. You did change where tryTrillFinished is used, hence my
comment. If it gets merged, you'll need to update this PR though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ethereum/browser-solidity/pull/43#issuecomment-224018396,
or mute the thread
https://github.com/notifications/unsubscribe/AAAJ0AgQ4pwvAgJkAcPevLC8a-AYO06fks5qJFBigaJpZM4IrC2j
.

Did not work 100% for me, but probably still better than nothing. Also it would be good to get same feedback about how many libraries still need to be deployed.

@chriseth @redsquirrel I think merging this is breaking after web3 was moved to the context. tryTillResponse references an invalid this now?

@axic you're right, this should be self.