bathymetry plugin ready to review

Error occurred with the original bathy_dave_plugin branch due to large bathymetry source file inside committed stacks.
Large bathymetry source files are removed from plugin source codes. (Still, 40 MB-ish meshlab portable is included)
This new branch is ready to review. Please check following the tutorial wiki page. (Be warned, following tutorial may take almost two hours)
Bathymetry plugin tutorial link

@caguero
Conversion process
tif bathymetry (downloaded from NOAA) -> convert to ply format (gdal/pdal) -> convert to obj format (meshlab portable) -> generate mesh sdfs with objs (mkbathy.sh)

@caguero
Conversion process :
.tif bathymetry (downloaded from NOAA, this example case 200MB) -> convert to .ply format (gdal/pdal) -> convert to .obj format (meshlab portable) -> generate separated mesh model .sdf with objs (mkbathy.sh)

Thanks! As I said before, if the 1.5 hour prerequisite is a showstopper, I'd suggest to test if you can load directly the DEM into Gazebo without doing any conversion. Otherwise it looks like a valid way to load the elevation.

@caguero
I just understood that tiff is DEM! Not sure why the original code had a complex conversion process. Will ask Michael Jakuba before proceeding forward.  Thank you!

@caguero
I just understood that tiff is DEM! Not sure why the original code had a complex conversion process. Will ask Michael Jakuba before proceeding forward. Thank you!

Correct, DEM is the generic name and tiff is a specific format to capture a DEM but not the only format. gdal deals with most of the known formats.

The notes in this project might be useful as well.
https://github.com/osrf/uav_testing

According to the last week's discussions, the PR is updated to exclude data conversion to a separate standalone repository.
In this PR, it only includes bathymetry tiles that are already been converted with overlapping regions and namings just to reproduce the video clip on the tutorial wiki.
This is ready to merge. 👍

According to the last week's discussions, the PR is updated to exclude data conversion to a separate standalone repository.
In this PR, it only includes bathymetry tiles that are already been converted with overlapping regions and namings just to reproduce the video clip on the tutorial wiki.
This is ready to merge. 👍

Thank you! I will try to review this today.

Getting error msg launching with roslaunch nps_uw_sensors_gazebo depth_camera_sonar_basic.launch
process[depth_and_normals_to_sonar-5]: started with pid [4391]
/usr/bin/env: ‘python\r’: No such file or directory
process[rqt_image_view_image_beams-6]: started with pid [4392]
[depth_and_normals_to_sonar-5] process has died [pid 4391, exit code 127, cmd /home/eric/uuv_ws/src/nps_uw_sensors_gazebo/scripts/sonar_ros.py __name:=depth_and_normals_to_sonar __log:=/home/eric/.ros/log/8a5c2930-fba5-11ea-9dd5-bcee7b8ddb04/depth_and_normals_to_sonar-5.log].
log file: /home/eric/.ros/log/8a5c2930-fba5-11ea-9dd5-bcee7b8ddb04/depth_and_normals_to_sonar-5*.log

according to this thread
The problem are your line ending characters. Your file was created or edited on a Windows system and uses Windows/DOS-style line endings (CR+LF), whereas Linux systems like Ubuntu require Unix-style line endings (LF).
using package dos2unix with command dos2unix *.py fixed the problem which is installed with sudo apt install dos2unix

@woensug-choi  After I launch and unpause the simulation, the environment remains gray and blank. I get a message saying:
[Dbg] [bathy_plugin.cc:140] Loading bathymetry plugin for rexrov...
[Dbg] [bathy_plugin.cc:209] Update bathy!
[Dbg] [bathy_plugin.cc:317] lonc/col: -70.675/2 latc/row: 41.519/1
[Dbg] [bathy_plugin.cc:331] Inserted model: ncei19.R_-70.675_-70.663_41.519_41.529
[Wrn] [ModelDatabase.cc:340] Getting models from[http://models.gazebosim.org/]. This may take a few seconds.
[Msg] Waiting for model database update to complete...

Then it pauses for a while. Next, get some warnings and errors:
[Wrn] [FuelModelDatabase.cc:248] [Wrn] [FuelModelDatabase.cc:248] URI not supported by Fuel [model://ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987/meshes/ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987.objURI not supported by Fuel [URI not supported by Fuel [URI not supported by Fuel [model://ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987/meshes/ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987.obj]
[Wrn] [SystemPaths.cc:464] File or path does not exist [[Wrn] [SystemPaths.cc:464] File or path does not exist [[Wrn] [SystemPaths.cc:464] ""[1;"] [33mmodel://ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987/meshes/ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987.obj"][1;] [33mmodel://ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987/meshes/ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987.obj
[1;]33m
[Err] [Visual.cc:3043] o mesh specified
[Err] [MeshShape.cc:60] 31mNo mesh specified
[Wrn] [FuelModelDatabase.cc:248] URI not supported by Fuel [model://ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987/meshes/ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987.obj]
[Wrn] [SystemPaths.cc:464] File or path does not exist [""] [model://ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987/meshes/ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987.obj]
[Err] [Visual.cc:3043] No mesh specified
[Wrn] [FuelModelDatabase.cc:248] URI not supported by Fuel [model://ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987/meshes/ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987.obj]
[Wrn] [SystemPaths.cc:464] File or path does not exist [""] [model://ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987/meshes/ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987.obj]
[Wrn] [FuelModelDatabase.cc:248] URI not supported by Fuel [model://ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987/meshes/ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987.obj]
[Wrn] [SystemPaths.cc:464] File or path does not exist [""] [model://ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987/meshes/ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987.obj]
[Err] [Visual.cc:3043] No mesh specified
[Wrn] [FuelModelDatabase.cc:248] URI not supported by Fuel [model://ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987/meshes/ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987.obj]
[Wrn] [SystemPaths.cc:464] File or path does not exist [""] [model://ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987/meshes/ncei19.R_-70.675_-70.663_41.519_41.529.epsg26987.obj]
[Dbg] [bathy_plugin.cc:209] Update bathy!

I'm running in a Docker container; not sure whether that might have an effect. Let me know if there's anything I can do to provide more information.

Thank you for the review. It took me forever to find out what the problem is.
The dave project's .gitignore had obj files to be excluded in the commit. Changed .gitignore and added demo obj files.

Great, thanks. This is running now. I'll review it.

"cracks" on tiles are originated from NOAA tiff files. Can't find where exactly I saw the same issues but seen that somewhere else. In order to smooth and sweep those holes out, delicate work should be performed on Meshlab to hand-stitch them. Only if needed.
If we were to generate some sort of interpolation sweeping methods, it should be on separated 'Bathymetry Converter' repository. I don't think it should be covered in the dave project.
Leaving this PR left for you to click the merge button so that you can read this last comment.

Leaving this PR left for you to click the merge button so that you can read this last comment.

@woensug-choi Got it. Thanks. Merging.

Not yet deleting branch as it is relevant to issue Field-Robotics-Lab/Bathymetry_Converter#1


add more entities to generic plots

I want the issues, because when we do a release I review all isues and can add Hints to the release notes

see https://github.com/Open-MSS/MSS/issues/1826

I have now several times seen a failing test on that port.
HTTPConnectionPool(host='<IP_ADDRESS>', port=25484)

Link? These changes should not cause any problems.

Link? These changes should not cause any problems.

not now, I restarted the test. I currently note which ports are showing up when it gets into a timeout.


New package: Hashicorp.Terraform.RC version 1.8.0-rc1

Pull request has been created with komac v2.1.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-03-26 23:03:56.573 [CLI ] ShellExecute installer failed: 127
2024-03-26 23:03:28.573 [CLI ] ShellExecute installer failed: 127

(Automated response - build 876.)

What seems to be the problem here? i'm not sure about the error message

Verify:


Filer fails silently

Describe the bug
The filer exits without any apparent error.
System Setup

weed filer -s3 -s3.config=/etc/seaweedfs/s3.json -s3.port=8333
podman
seaweedfs:3.59

Expected behavior
Show configuration errors
Filer logs
I1207 11:11:25.754039 s3.go:203 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I1207 11:11:26.754777 s3.go:203 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I1207 11:11:27.755641 s3.go:203 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I1207 11:11:28.756711 s3.go:203 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I1207 11:11:29.758423 s3.go:203 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I1207 11:11:30.760357 s3.go:203 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
W1207 11:11:30.811510 filer_server.go:145 skipping default store dir in ./filerldb2
I1207 11:11:30.812183 leveldb2_store.go:42 filer store leveldb2 dir: /data/filerldb2
I1207 11:11:30.812354 file_util.go:27 Folder /data/filerldb2 Permission: -rwxr-xr-x
I1207 11:11:30.908586 filer.go:164 create filer.store.id to 783465370
I1207 11:11:30.908621 configuration.go:28 configured filer store to leveldb2
I1207 11:11:30.909789 master_client.go:20 the cluster has 2 filer
I1207 11:11:30.909815 filer_server.go:172 <IP_ADDRESS>:8888 bootstrap from peers [node_type:"filer"  address:"<IP_ADDRESS>:8888"  is_add:true  created_at_ns:1701947487536575552 node_type:"filer"  address:"<IP_ADDRESS>:8888"  is_add:true  created_at_ns:1701947490817280670]
I1207 11:11:30.909865 filer.go:92 bootstrap from <IP_ADDRESS>:8888 clientId:1768513691
F1207 11:11:30.910647 filer_server.go:174 <IP_ADDRESS>:8888 bootstrap from [node_type:"filer"  address:"<IP_ADDRESS>:8888"  is_add:true  created_at_ns:1701947487536575552 node_type:"filer"  address:"<IP_ADDRESS>:8888"  is_add:true  created_at_ns:1701947490817280670]

unluckily the error was not logged. Added in https://github.com/seaweedfs/seaweedfs/commit/5fe4c04a1a629d3d32b1d639cb28f9df4c7ae697


Can,t Set WordPress Post Tags

Im trying to send a Wordpress post by Simple browser, everything works great! but when I get the tags field by id or name and set the value to the field value is set in Browser but when I publish the post my post published without tags. I tried many ways to do this (eg: get element by tag name, name, value, id, set attribute etc.) but the results are the same! the post published without any tags. Thanks for your help!
The Tags field element :
<input data-wp-taxonomy="download_tag" type="text" id="new-tag-download_tag" name="newtag[download_tag]" class="newtag form-input-tip ui-autocomplete-input" size="16" autocomplete="off" aria-describedby="new-tag-download_tag-desc" value="" role="combobox" aria-autocomplete="list" aria-expanded="false" aria-owns="ui-id-1">
My code Like this:
//Ttitle
b.Find("input", FindBy.Id, "title").Value = "TestPost";
//Discreption
var a = b.FindAll("textarea");
foreach (var item in a)
{
a.Value = "Test";
}
//Select Category
var c = b.Select(".selectit input[type='checkbox']");
foreach (var item in c)
{
if (item.XElement.Parent.Value.Contains("Article"))
{
item.Checked = true;
}
}
//Set Tags (This part is not working)
var tin = b.Find("input", FindBy.Id,"new-tag-download_tag");
foreach (var item in tin)
{
item.Value = "test1,test2,test3";
}
b.Find("publish").Click();

What you have looks like it should work. I would have to look at it to diagnose it more. Is this input tag on a publicly available site?


Typo - charcter -> character

There is a type in a charcter field name - it should be a character. Unfortunately I'm not able to issue a PR :(

Fixed, thanks for the report.


Paths with grape-swagger-rails 0.9

With previous applications running 0.7.2, I would initialise with
GrapeSwaggerRails.options.url      = '/swagger_doc.json'
However, with v 0.9, had to replace that with
GrapeSwaggerRails.options.url      = '/swagger_doc'
and remove the .json to get things to work

That is correct, and documented in Grape's UPGRADING.


Failed to build blosc:x86-windows-v140

CMake Error at ports/blosc/portfile.cmake:41 (file):
  file RENAME failed to rename

    C:/Users/TesX/apps/vcpkg/packages/blosc_x86-windows-v140/debug/lib/blosc.dll

  to

    C:/Users/TesX/apps/vcpkg/packages/blosc_x86-windows-v140/debug/bin/blosc.dll

  because: File exists

Call Stack (most recent call first):
  scripts/ports.cmake:72 (include)

Error: Building package blosc:x86-windows-v140 failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: blosc:x86-windows-v140
  Vcpkg version: 0.0.113-nohash

This is the x86-windows-v140 triplet:
set(VCPKG_TARGET_ARCHITECTURE x86)
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE dynamic)
set(VCPKG_PLATFORM_TOOLSET v140)
set(VCPKG_BUILD_TYPE release)

Hi @tesfabpel, thanks for posting this issue. The PR has been merged to the master. This issue should be fixed now.


DSpace 7: Page jumps during submission

Describe the bug
During submission, the page sometimes "jumps" and users have to navigate back to where they were before the jump (scroll up/down). We noticed the page jumps occur when DSpace caches the submission (the caching is visible at the bottom of the page).
To Reproduce
Steps to reproduce the behavior:
Start a submission and fill in the fields. At some point when DSpace caches, the page "jumps". It may be that there are additional factors which need to be in place for the page to jump. We have heard from other institutions that face the same problem and do not have a solution for this issue so far.
Expected behavior
When DSpace caches a submission, the page does not "jump".
Related work
Link to any related tickets or PRs here.

Oh yeah, this jumpiness is the minor issue. The major issue is that when it jumps, the previously selected values are cleared. It is very reproducible for me on DSpace 7.6.1 in Firefox:
Screencast from 2024-01-30 11-38-39.webm
You can see me skip to the third "Describe" step and try to select values in some drop downs. When I move back to the second step the autosave kicks in and clears the field, jumping sometimes and others not.

I have tested this again and while we have the jumps, I didn't find any cleared values.

@f-rapp I did some more testing with the DSpace theme on our repository to make sure it's not something in my custom theme. What I find is that it happens when I interact with inputs of type dropdown that are using value pairs, for example:
        <field>
            <dc-schema>cg</dc-schema>
            <dc-element>coverage</dc-element>
            <dc-qualifier>country</dc-qualifier>
            <repeatable>true</repeatable>
            <label>Country</label>
            <input-type value-pairs-name="countrylist">dropdown</input-type>
            <hint>Select a country or countries within the scope of the item.</hint>
            <required></required>
        </field>

It doesn't happen for oneboxes.

I'm testing again and the "cleared values" bug is actually a side-effect of recently merged #2733. It is not related to the jumping submission form in this issue.

Hi @alanorth, does the patch above also solve the jumping issue?

Hi @f-rapp. No that patch does not fix the jumping...


Large PDF base64string not loading embed in Blazor app

Describe the bug
Large PDF base64string not loading in embed tag inside Blazor application. Small size PDF showing perfectly. If the pdf size is 10 MB or more it is not showing.
To Reproduce

Convert large pdf to bytes,
Byte[] bytes = File.ReadAllBytes("specify large pdf path");
Convert bytes to base64string
base64Str = Convert.ToBase64String(bytes, 0, bytes.Length);
base64Pdf = "data:application/pdf;base64," + base64Str;
Update base64string in embed tag
embed style="width: 700px; height: 700px;" src="@base64Pdf" type="application/pdf"

Further technical details
Small size PDF showing perfectly. If the pdf size is 10 MB or more it is not showing.
I have checked with 10 MB pdf it is not showing. Are there any settings like maxRequestLength?

@ajai1109 Thanks for contacting us.
I think you might be running into limitations with how big data-urls can be in the browser?

@javiercn I have added a sample project in the below link for your reference. Please let me know if any more info needed.
https://github.com/ajai1109/blazorpdfupload.git

@ajai1109 thanks for the repro.
At the very least, this is a very bad idea, as its allocating a huge string in memory. When I tried this on plain HTML this doesn't work on most browsers, so I'm concluding this is a browser limitation and not a Blazor specific issue.
See below how firefox is the only one capable of producing some output.


CSV upload in IE (9 and earlier) doesn't always work

Upload a CSV in Internet Explorer version 9 or earlier. The file is not always recognized by the application.
This must have something to do with the Dojo Uploader we're using and its Flash dependency when using a non-HTML5 browser like IE9.

Since we wont be updating this app we will just treat this as a known issue.


what is idiomatic way to handle one to many relationship?

I did not see an example like this in the documentation.  If I have a Business struct that contains multiple Location structs, what would be the idiomatic gorp way to handle selecting a business then selecting all of the locations?
type Business struct {
Id int
Name string
Locations []Location
}
type Location struct {
Id int
Address string
}

We would like to handle this first-class (in fact, I've done it once in a fork, but it was done quickly without testing because we needed it ASAP ... the logic is complex enough that just bringing it in is quite a bit of work), but for now, your best bet is probably to make a mapping struct to select join queries into:
type Foo struct {
    ID int `db:"id"`
}

type Bar struct {
    ID int `db:"id"`
    FooID int `db:"foo_id"`
}

type FooBar struct {
    Foo
    BarID int `db:"bar_id"`
}

func FooBars() ([]FooBar, error) {
    var results []FooBar
    _, err := dbmap.Select(&results, "select foo.id, bar.id as bar_id from foo left join bar on foo.id = bar.foo_id")
    return results, err
}

If possible, would I be able to take a look at that forked code ?


feat(index.ts): Parse the first 10 lines of each file for flow pragma

Flow itself only checks the first 10 lines when looking for the @flow pragma. This commit mimicks
that behavior. Fixes https://github.com/withspectrum/danger-plugin-flow/issues/3
This commit also adds test files for future validation.

Yesss, thank you so much! 💜

Of course! Thanks for having me. :)


/cards list shows ids of rarities and not display-names

Describe the bug
/cards list shows ids and not display-names
To Reproduce
Steps to reproduce the behavior:
/cards list
Expected behavior
Display names to be shown in /cards list,
Error Logs
n/a
Screenshots
https://i.imgur.com/NL0WeWA.png
Server & Plugin Versions:

Server Version:  Purpur version git-Purpur-1336
Minecraft: 1.17.1
XenTradingCards: 5.4.0-SNAPSHOT

Fixed in #27


Inquiry about Generating the "discord_app" Folder in the Instructions

This project is very interesting. I have a question regarding the step involving "cd discord_app". Which program should I use to generate it? I followed the instructions and was able to ingest the docs, but the discord_app folder has not appeared yet.

I found the location.
The full path is wandb/src/wandbot/.
Please disregard my previous message.


[TOPIC] Maximise the Value of Your Salesforce Data

Inspiration: https://fivetran.com/blog/how-to-maximise-the-value-of-your-salesforce-data

Draft: https://docs.google.com/document/d/1MnP3BrTkyBNOLNyLrYmGFbkksjIYKQ0UWftOnwUqkRU/edit?usp=sharing

The goal was to show in each point how you can leverage Airbyte to make the most of Salesforce data...
None of the 5 steps make use of Airbyte.
Also you want the paragraph title to be self-explanatory, so a reader can understand what it is about, and read only the sections that make sense to them....as in the article mentioned as inspiration.
As is, this article can't be leveraged at all.

@johnlafleur Thanks for checking that out! I totally agree with you. The example article from Fivetran does give concrete examples of how to use Fivetran for Salesforce data.
At the same time, I feel like we need to be more explicit about what we expect from an article. Unfortunately, a title and an inspiration article don't seem to be enough.


Web canvas expects to be in the top left corner, if not, causes a mouse click offset bug

Describe the bug
Embedding the canvas or offsetting the canvas causes the mouse click not to be registered appropriately. In the following demo I've embedded the Ava div out in an Angular app and added a couple of
 elements before the div out element. As you can see the mouse click events are then not registered properly. It seems that the canvas looks at the mouse position from the top left corner of the viewport and not the canvas.

<!doctype html>

  <meta charset="utf-8">
  <title>AngularAvalonia</title>
  <base href="/">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <link rel="icon" type="image/x-icon" href="favicon.ico">

  <link rel="modulepreload" type="application/javascript" href="./AppBundle/main.js" />
  <link rel="modulepreload" type="application/javascript" href="./AppBundle/dotnet.js" />
  <link rel="modulepreload" type="application/javascript" href="./AppBundle/avalonia.js" />
  <link rel="stylesheet" href="./AppBundle/app.css" />

                Loading...

  <app-root></app-root>

To Reproduce
Embed the Avalonia app with additional margin or  before the element. Not setting the margin to 0 on the body has a similar effect but just less recognizable.
Expected behavior
Track mouse position from the left top canvas corner.
Desktop (please complete the following information):

OS: browser
Version: 11.0.4

Additional context
I'm trying to figure out how to approach embedding Avalonia pages/elements in an Angular application for a page by page basis transition from Angular to Avalonia. Ideally speaking I would like to embed Avalonia pages in any div I want to have full control over the pages look, feel and position.
Spawned from conversation on how to approach Avalonia application embedding in other web apps, https://github.com/AvaloniaUI/Avalonia/discussions/12755.

It took me a while, but after trying to fix this issue, I found that it works as it should.
The problem with your specific use case is that you missed position:absolute on the out element (relative should also work). The reason is that child controls inside of the out element use position:absolute relatively to the parent element that also has to be either absolute or relative (or flex as I believe).


fix(Input): use activatedStyle from props when value is provided

Overview

PR Checklist

[ ] Related to designs:
[x] Related to JIRA ticket: FLOW-554
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change
[ ] This PR includes testing instructions tests for the code change
[ ] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Login to an account without a subscription
Navigate to the /checkout page
Validate that the border around the recurly input(s) initializes with a text-disabled color border
Validate that once a valid input is typed into the input the color border updates to currentColor
Validate that other inputs that don't pass in activated behave as expected. (text-disabled border color until touched, currentColor border after a valid input is provided)

PR Links and Envs

Repository
PR Link
PR Env

Monolith
Monolith PR
Monolith Env

Portal
Portal Link
Portal Env

Another Repo
Another Link
Another Env

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

📬Published Alpha Packages:@codecademy/gamut@55.4.3-alpha.e012be.0@codecademy/gamut-kit@0.6.345-alpha.e012be.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://650b6e014f8ffb5fd8a24daf--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut@55.5.1-alpha.02aaad.0@codecademy/gamut-kit@0.6.346-alpha.02aaad.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://650cbf7245bec6112851baa2--gamut-preview.netlify.appDeploy Logs


the second homework in the morning

the second homework in the morning

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Mobile support

Hello! (And thanks for adding the reply feature)
I just tested out the bot, works like a charm on computer. However, I then switched to my iphone on the latest version of discord to test it there.
However, it either A. did literally nothing, except blast the message to my computer, or B. when my computer was closed, it just got stuck with the bot eternally saying "sending command".
Any idea on how to fix this? Thanks!

Sadly, it didn't work for me, and is giving the same behavior as before.
Sorry for the late responses by the way! You work faster than I can keep up with lol


Remove Unused variable

Hi
I found Unused Variable in AuthorizationServerClientCredentialsPasswordValidXmlTests Class.
So I've removed it.
Thank you. :)

@kiyoung-Lee Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@kiyoung-Lee Thank you for signing the Contributor License Agreement!


Rarity

Hello,
Great script. Is it possible to assign rarity amounts for each item specifically? Instead of rare, common, legendary.

hi! Can you provide a little more details and an example of how it might work. It's possible, but I'd need a little more information on your suggestion

I'm not sure how to provide more detail on it. It would be good if you added a "weight"/rarity amount for each individual .PNG layer/trait.

Hello sir, thank you for the beautiful script. It really helped me to complete the work. I only have a question, how can I update the metadata hash after uploading the images, because according to what I understood, after the task of creating the images is finished, I upload it to a pinata, and then I take the hash and put it in a file nft dot py and restart the file again, but how can I update the jason files without reproducing the images again, because in this case I used 1500px X 1500px images, and it produced about 10,000 and took me about two days of work.. I mean, it needs the same period Just for the sake of updating the jason files, the question is how can I update the jason files without reproducing the images. Thank you, sorry for the length.


Help in understanding breakpoint measurements with mobile phones.

Description
(I don't think this is a bug but it's not a feature request either)
windowWidth, and thus breakpoints, for iPhone 7 nearly identical to Pixel 6 Pro
Steps to reproduce
We're working through a complete rewrite of our app with nativebase to take advantage of many of its benefits, but the main reason is the responsive breakpoints.
I'm testing on an old, small iPhone 7, a new high-density Pixel 6 Pro, and a new iPad.
I fully expected the iPhone and the Pixel to be completely different breakpoints.

iPhone 7
750 x 1334 pixels, 16:9 ratio (~326 ppi density)
Pixel 6 Pro
1440 x 3120 pixels, 19.5:9 ratio (~512 ppi density)

After looking at the source, I saw
const windowWidth = useWindowDimensions()?.width;
is used to determine the widths.
Here are the results from each phone.
iPhone:
NativeBase breakpoint ==> base
windowWidth ==> 375

Android
NativeBase breakpoint ==> base
windowWidth ==> 411

Both of these phones break at base. And more surprisingly, they are very close to one another in windowWidth.
So, it's challenging to correctly size things with the breakpoint because things show up significantly larger on the lower density iPhone 7.
How should we approach this? I realize we could make the sm  breakpoint between 375 and 411 to break the phones into different breakpoints, but I'm not confident that's a good solution.
Hoping someone on the NativeBase team can help us think through how to work with significantly different density phones when it seems they are actually very close together from a windowWidth perspective.
Thanks!
NativeBase Version
3.4.1
Platform

[X] Android
[ ] CRA
[ ] Expo
[X] iOS
[ ] Next

Other Platform
No response
Additional Information
No response

Hey @GollyJer , NativeBase provides these default breakpoints and you can update by using extendTheme.
const theme = extendTheme({
    breakpoints: {
      base: 0,
      sm: 400,
      md: 700,
    },
  });

Here you can read more about it

Hi @ankit-tailor. Thanks for the help.
I've read the documentation and the source code thoroughly.
The real point of my question is how these two phones can measure so closely together?
NativeBase is using windowWidth to determine breakpoints.
iPhone 7
750 x 1334 pixels (326 PPI density)
windowWidth  ==> 375 👈

Pixel 6 Pro
1440 x 3120 pixels (512 PPI density)
windowWidth  ==> 411 👈

These phones are 7 years apart, and the Pixel is nearly twice the screen density as the iPhone but measures only ~10% larger in windowWidth.
How do you guys handle breakpoints for this situation? Is this typical?

OK, so digging into this more, I understand now that
const windowWidth = useWindowDimensions()?.width is returning the DP, aka Density-Independent Pixels.
so really it's more like...
const dp = useWindowDimensions()?.width
For those playing along...

Good summary of pixel density for ios, android, web
How do dp, dip, dpi, ppi, pixels and inches relate?

So I'm thinking the answer is to use tighter breakpoints to scale down to smaller phones.
These are the default breakpoints...
https://github.com/GeekyAnts/NativeBase/blob/2af374e586034366dcefce9a0f23983836a7901f/src/theme/base/breakpoints.ts
const breakpoints = {
  'base': 0,
  'sm': 480,
  'md': 768,
  'lg': 992,
  'xl': 1280,
  '2xl': 1536,
};

breakpoints: {
    base: 0,
    sm: 376, // 👈 for small DP phones.
    md: 480,
    lg: 768,
    xl: 992,
    '2xl': 1280,
    '3xl': 1536,
  },

My previous idea of creating and renaming breakpoints is a BAD idea.
In testing... simply just renaming breakpoints caused weird things to happen, like the app rerendering randomly.
In the end we had to settle for just changing the sizes of the default breakpoints.
export const ExtendedNativeBaseTheme = extendTheme({
  breakpoints: {
    base: 0, // 0-374 dp
    sm: 376, // 375-479 dp
    md: 481, // 480-767 dp
    lg: 769, // 768-991 dp
    xl: 993, // 992-1279 dp
    '2xl': 1281, // 1280 dp and up
  },

I want to set styles only on the base screen. How can I do that? Your example applies to all 3 screens: direction={['column', 'column', 'row']}

I think you may have posted in the wrong thread.

native base measure responsiveness with respect to width . what if we want to measure it with respect to height of device ? how would that work ? what if I want to add breakpoints according to device height ?


Update README.md

Added getting started instructions to README.md

Please add more details, for example: a section to explain editing the config.js file, a section explaining npm commands etc
and anything else that you could come up with.
Also maybe change the getting started command to explain better where to write the name of the project example: gatsby new yourbusinessname https://github.com/v4iv/gatsby-starter-business seems a bit confusing currently


3 focus score tool

The reason I marked the PR as a draft is because I caught two bugs while doing further testing. One of them I've already resolved, but I'm still working on the last bug.
I've been capturing images in 640x480 using both OpenCV and PiCamera due to the PiTFT resolution as well as performance concerns. For the OpenCV script, I've had significant performance and color issues capturing at 1080 and then resizing it down so I can display it on the PiTFT. As for PiCamera, ideally, it would be best to move from using tkinter's update() method to using the after() method because update forces the updating of the display. However, this would involve figuring out how to get around the for loop of the current capture_continuous method. Also, update can lead to unpredictable behavior or looping. After solving that issue, there remains 2 performance concerns: how PiCamera is capturing images and the color conversion using numpy.dot. As we discussed, I could import OpenCV's color conversion method. However, would that defeat the purpose of having a SciPy version of the tool? As for PiCamera's capturing of images, capturing a single image using the capture method and storing the data in buffer is possible but performance is impacted when capturing at 1080p. A better approach would be to use a capture method that utilizes the video port parameter since it would capture images from the video port (which tend to have a grainy appearance), but as far as I know, capture_continuous is the only method that is suitable for this task. Having said that, to use this method, you need to use a for loop. This kind of defeats the purpose of the after method since it won't be called because the capture_continuous method is infinite. Though, a work around would be to just run through the loop once and break from it, then use the after method and repeat the process again. What do you think?

Makes total sense to capture at the PiTFT native resolution. The only thing that might change that is if in the focus tool we wanted to zoom in (digitally) as we are doing with the preview window in the current dencam.py.  But let's not worry about that for now.
I haven't gotten my head fully into the details you go through above but the workaround you've thought of sounds kind of clunky. But I would also say that what I understood was the result of our foray into trying to do variance of the Laplacian without using OpenCV was 1) that there were a lot of compelling reasons to stick with OpenCV (including that the grayscale conversion was faster as you mention) and that we could even use cv.VideoCapture to capture directly from the picamera and 2) that the scope of implementing a focus score feature in the main DenCam code was getting to be more than this feature is currently worth to us.
As we talked about yesterday, I think we should push off trying to integrate this feature into the main DenCam code because of the degree of re-architecting that system that would be required to facilitation that integration but just capture the work you've done on this feature into these two scripts for future use and until we decide to revisit it.  So I think we should merge this PR without closing the bigger issue whenever you have resolved the remaining bug you have.
Very glad to hear you are doing testing and catching bugs!
To check: examine_focus_w_grid.py is the faster of the two scripts at this stage, right?

Correct, examine_focus_w_grid.py is the faster of the two scripts at this stage.


MessageBus only sends to myself, not other players

The messageBus is only working to send messages to myself, but other players aren't getting those messages
I created a very simple scene to test this out:
All the code in the scene:
import utils from '../node_modules/decentraland-ecs-utils/index'
import * as ui from '../node_modules/@dcl/ui-utils/index'

let sceneMessageBus = new MessageBus()

let box = utils.addTestCube(
  { position: new Vector3(8, 0, 8) },
  () => {
    sceneMessageBus.emit('boom', {})
  },
  'BOOM'
)

sceneMessageBus.on('boom', () => {
  ui.displayAnnouncement('BOOM')
})

https://app.zenhub.com/files/220994476/ba349636-06a7-4a8f-92fa-957cf0cfe68b/download
When I try this locally, I see the "BOOM" message in the UI when I click the cube. But if I open a second tab, the two players see themselves, but each only sees the "BOOM" from his own clicks, not from the other player.
I deployed this scene to a parcel I own myself, and the same happens in-world. If I open a second tab in Firefox, the players see each other, but each only sees the UI messages from their own clicks, not from the other player.
https://play.decentraland.org/?position=-133%2C-42&realm=fenrir-amber
Comms are working fine, if I go with my two tabs to another older scene that uses the message bus, it seems to work fine. Maybe the SDK broke something in one of the latest releases?

Turns out that this code fragment

let box = utils.addTestCube(
{ position: new Vector3(8, 0, 8) },
() => {
sceneMessageBus.emit('boom', {})
},
'BOOM'
)

generates a race condition that ends up in an unhandled exception while resolving module CommunicationsController

Turns out that this code fragment

let box = utils.addTestCube(
{ position: new Vector3(8, 0, 8) },
() => {
sceneMessageBus.emit('boom', {})
},
'BOOM'
)

generates a race condition that ends up in an unhandled exception while resolving module CommunicationsController


Not working on Cygwin

Hi,
I'm trying to run Ammonite under Cygwin but it complains and it doesn't work.
This is my setup:

Ammonite 1.2.1 for Scala 2.12
Latest updates of Cygwin
Windows 10 (no, I don't want to use the Windows Subsystem for Linux for several reasons)
Scala 2.12.6

$ scala -version
Scala code runner version 2.12.6 -- Copyright 2002-2018, LAMP/EPFL and Lightbend, Inc.

Java 1.8.0

$ java -version
java version "1.8.0_171"
Java(TM) SE Runtime Environment (build 1.8.0_171-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.171-b11, mixed mode)

On first installation:
$ sh -c '(echo "#!/usr/bin/env sh" && curl -L https://github.com/lihaoyi/Ammonite/releases/download/1.2.1/2.12-1.2.1) > /usr/local/bin/amm && chmod +x /usr/local/bin/amm' && amm
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   600    0   600    0     0    884      0 --:--:-- --:--:-- --:--:--   884
100 26.4M  100 26.4M    0     0   948k      0  0:00:28  0:00:28 --:--:-- 1920k
Error: Could not find or load main class ammonite.Main

When running on the command line:
$ amm
Error: Could not find or load main class ammonite.Main

I spent a whole day trying to fix the issue, googling around and experimenting, but no luck.
Can you help, please?

Why don't you try using it as amm.bat? There are some issues, but most of the stuff regarding Scala works.

@sake92 because the documentation is not clear about how to install and run Ammonite. amm.bat is mentioned once in the "unstable version" section and right before it I found how to make it work for Cygwin (http://ammonite.io/#UnstableVersions)
I think documentation should be improved with a good "Installation" section

This is now fixed, documentation issue.


Add support for 10.0.17746.1000

This id the rs5

termsrv.zip

termsrv.zip

https://github.com/sebaxakerhtc/rdpwrap.ini/commit/4385be5d77de59f9a999e7a332acd6b836ae4390


relocate method in BufferAggregator.

Fixes https://github.com/druid-io/druid/issues/4026.
This pr introduces a new method relocate in BufferAggregator to allow relocation of any cached object.
@gianm @cheddar @himanshug

:+1:

@gianm regarding your questions about the contract.  I agree that what you did in groupBy v2 is totally valid and 100%, totally according to contract.
The basic contract is really simply described by the function signatures and that is "you get a ByteBuffer and a position, use the position on the ByteBuffer and your bytes will be there".  There is then the other one of "an area of memory is always initialized before being aggregated into", that one isn't called out in the docs as well.

@leventov @akashdw I'm sorry to see such an argument between two people that clearly have strong feelings about Druid!
My vote is to defer to @akashdw's choice for 0.10.0 assuming it is acceptable to committers that are using DataSketches in production (like @himanshug, @cheddar). But I would also like to open an issue for the future to clarify the BufferAggregator contract — it sounds like it's pretty confusing what it allows and doesn't allow — and then use that clarified contract to optimize SketchBufferAggregator more after 0.10.0.

@akashdw @himanshug this is BDUF. Possible redesign of BufferGrouper which won't include "rehash" will make relocate() obsolete as well, so rework of SketchBufferAggregator will be needed anyway.

I don't think it's BDUF, since Query and BufferAggregator are both valid extension points for Druid extensions, and we can't assume we can control all possible implementations. We need the interfaces to be clear about what is allowed and disallowed, and we shouldn't write code that violates them, or else users' site specific custom Queries and Aggregators might not work properly.
Even future code written as part of Druid might not work properly, after we all put this behind us and forget that SketchBufferAggregator doesn't quite follow the contract 100%. This is actually how we got into this situation in the first place! When I wrote groupBy v2, I used BufferAggregator interface in a way that other queries hadn't done before, which I thought satisfied the contract, but broke SketchBufferAggregator. Arguably, the old version of SketchBufferAggregator didn't follow the contract, but it was "OK" until the change to groupBy.
So, I think the maps are useful and it's valid choice to be a little "flexible" until the BufferAggregator interface is clarified.

@leventov I understand this patch may not be perfect but do you see show-stopper issues that we cannot resolve in future releases?

@gianm testing this patch in one of the production environment, will let you know once done with the testing.

Thanks @akashdw, please keep us posted.

@gianm  tested this patch in one of our environment and I don't see relocate issue with GroupByV2 anymore.

Spoke with @leventov offline. I'll merge this since it has +1s from me and @himanshug.


Please add asiancollege.edu.ph domain

A page on the official website where a long-term (>1 year) IT related course is offered by the university:

BS in Computer Engineering
BS in Computer Science
BS in Electronics Technology
BS in Information Technology

A page on the official website showing that the university recognizes the domain which you are submitting as an official email domain for the enrolled students:

Contact email of the school<EMAIL_ADDRESS>

@jmrecodes First stage of verification passed, official domain is asiancollege.edu.ph as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@jmrecodes Thank you for your patience while waiting for a review and processing your request. Pull request merged.


warning messages in up-left corner of the screen dissapear some time ago

i don't remember when i lost these alert messages https://puu.sh/GJAR5/51f62bc537.png  these messages appeared when something appeared in Alerts tab of ltn manager. Now i don't receive them so i don't see Alerts when it happens and can't react. Every single alert must be solved asap before problem multiplies but i need manually open ltn manager alert tab to see if it's empty. it's me changed something or why these so usefull warning indication dissapeared? i dozen times check every single setting of ltn and ltn manager but can't return these warnings.

i find these Version: 0.3.0 Date: 2020-09-17    Changes:     - Removed alert popups in favor of LTN's new built-in notifications
you can't configure these built-in notification to show alerts. these notifications means exactly nothing and not connected with alerts that i need to show asap. for example https://puu.sh/GJBHW/b47028f414.jpg
there i need to solve alerts problem while notifications show me some useless info about lack of trains. please return these old school poppups that exists since ltn tracker. these popups is usefull key feature that prevent me to manually open alert tab every 5mins while ltn built-in notifications is just useless flashing thing that shows nothing and turned off 99% time.

i experiment a bit and what i find:
manager alerts shows:

delivery timeout - super usefull. 99% it's traffic jam
wrong delivery - super usefull - need to be solved asap.

ltn '1: errors&warnings' console setting shows:

delivery timeout
lack of trains - i don't care. it's strategic info - i don't need to  react to it asap
lack of stations that provides goods - i don't care. it's strategic info - i don't need to  react to it asap

ltn inbuild flashing indication shows:

lack of trains
wrong delivery

so oldschool alert popups shows me exactly what i need to react
ltn console messages don't show me 'wrong delivery'
ltn inbuild flashing indication don't show me delivery timeouts
thats why i want to have these old popup messages...

I removed the LTNM alerts because the LTN alerts do, in fact, show everything that they did. I will think about solutions for this for a future version, but not until after the main GUI rewrite.

I'm not going to be re-adding custom notifications. Sorry.
I do have tentative plans to write an advanced notifications mod, and if I do that, I will integrate LTNM.


AWS NTP server as the default

Story
-As a cluster admin, I want the system clock to be synced for all private cluster nodes in order to have a well behaved functioning cluster.
Background
Currently, our CAPA Ubuntu images use the default NTP servers. These are not accessible in a private environment with no Internet access.
A few components which run on CAPA machines require the clocks to be synced:

etcd stops working if the clocks drift;
net-exporter is trying to access public NTP servers;

AWS provides the Amazon Time Sync Service via NTP which is locally accessible at <IP_ADDRESS>. More details are available in the following blog post.
Tasks

[ ] Configure the default system NTP server to be <IP_ADDRESS>
[ ] Configure net-exporter to query Amazon's NTP server: <IP_ADDRESS>

Resources

Amazon Time Sync Service blog post;

https://github.com/giantswarm/cluster-aws/pull/189
https://github.com/giantswarm/config/pull/1466
https://github.com/giantswarm/config/pull/1467


My account country filed should improve

Describe the issue:
My account country filed can add custom value as well. Gave successful message and when updating and filed is not update with given custom value.
https://user-images.githubusercontent.com/39077751/180901875-f0620255-1b31-4877-b760-dbf5d36b9ab7.mov
How to reproduce:

Login to my account and navigate to the personal infor
Select country filed and add text value (invalid country) without selecting from the drop down
Click save

Expected behavior:
Since no result from the entered text it should not give the profile update success message.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: https://wso2.org/jenkins/job/products/job/product-is/4174/
OS: Mac
Database: MSSQL
Userstore: JDBC

Optional Fields
Related issues:

Suggested labels:

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


totals file vs cantonal files

Thanks for aggregating these data. We are using the file
https://github.com/openZH/covid_19/blob/master/COVID19_Cases_Cantons_CH_total.csv
to feed data into neherlab.org/covid19/
However, it seems the file we are using is not in sync with the files in
https://github.com/openZH/covid_19/tree/master/fallzahlen_kanton_total_csv
please advise as to files we should be using and what is kept up-to-date.
Our parser is here:
https://github.com/neherlab/covid19_scenarios_data/blob/master/parsers/switzerland.py

I think @tlorusso is currently working on creating the CH dataset from the individual canton datasets automatically upon every change in one of the canton datasets.
Currently people probably update the canton dataset more often (my 5 cents).

@rneher we're working on it! We want to automatically generate Swiss-file whenever a csv for a single canton is updated. I'll let you know as soon as we've news in this regard.

Great! that would save us work!

resolved by #178 / #181
The new (hopefully) automated merged file is available here:
https://github.com/openZH/covid_19/blob/master/COVID19_Fallzahlen_CH_total.csv


library code

can we add some features to generate library code that will be compatible with enterprise software?
cat something.yaml | naml codify --library --license=apache > library.go

closed


Stop backfilling ProgrammeJunction/SubmissionDim for reporting rounds

https://dluhcdigital.atlassian.net/browse/FPASF-494
Change description
We are removing the old reporting round columns on these tables, so they won't be available for backfilling lookups any more. All of our deployed and local data has already been migrated, so this is no longer required.

[ ] Unit tests and other appropriate tests added or updated
[ ] README and other documentation has been updated / added (if needed)
[ ] Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test
If manual testing is needed, give suggested testing steps
Screenshots of UI changes (if applicable)

yeah, I think that data migration probably should've been a separate command - migrate-reporting-rounds or something. Now we know for the future :)


Update cats-laws, cats-testkit to 1.6.1

Updates

org.typelevel:cats-laws
org.typelevel:cats-testkit

from 1.6.0 to 1.6.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "org.typelevel" }]

labels: semver-patch

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   44.63%   44.63%
=======================================
  Files          31       31
  Lines         289      289
=======================================
  Hits          129      129
  Misses        160      160

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89da880...a1e2974. Read the comment docs.


python3Packages.pywick: mark broken due to missing dependencies

Description of changes
pywick is broken due to missing dependencies but somehow wasn't marked as such when  #189209 was merged.
@SuperSandro2000
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Why not try adding the dependencies?

If I remember, albumentations has added even more dependencies since the stale PR adding it (#165715).
I have a PR to add prodict in #189748 but it was never reviewed.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1755


Apple Silicon Support

Awesome project. Apple Silicon support would be great to see!

WAITT there's 17 upvotes for Apple Silicon support??? Oh my

WAITT there's 17 upvotes for Apple Silicon support???  Ok ok this definitely is a very good indication that people want Apple + MLX support :)) I will have to readjust my engineering roadmap :)

1+ This would be absolutely awesome!

@danielhanchen I have an M3 Max Macbook Pro with 128GB Unified RAM. Happy to help you port this great project to Apple Silicon 😃 If it's any helpful, I can spin up a VM and give you SSH access. IIRC macOS VM's on AS have direct GPU access and can run Metal with near native performance.

Would also love to see Apple Silicon support in the future!

Ill see but sadly I'm not a Mac user :(

Please support Apple Mac silicon M2、M3 series chips！！ It would be perfect！！！ pls！

Oh my yikes ok this is ballooning!

Waiting for the good news for supporting Apple Mac silicon!

Oh interesting if Pytorch already has been on MPS, hmm I'll see what I can do! (Once I get a Mac :))

Here's an interesting article arguing that any speedup from MLX over PyTorch's MPS is due to a small optimization mistake that could be easily fixed. The article is from a few months ago so that optimization issue might even be fixed by now: https://medium.com/@koypish/mps-or-mlx-for-domestic-ai-the-answer-will-surprise-you-df4b111de8a0
It does seem like PyTorch's MPS implementation is the move 👀, I agree with everyone above that Unsloth on Apple Silicon would be heavenly 🙏

Oh interesting article! I don't disagree itll be very cool :)

@danielhanchen  Another Mac user, chugging along on my M1. So don't forget us when people talk about newer chips, please.
Now as to what you need to do this work: what about renting a Mac? Here's a simple google search result: https://www.google.com/search?client=safari&rls=en&q=rent+apple+silicon&ie=UTF-8&oe=UTF-8 I note one of them is even pay as you go. You could probably raise enough money of a short term rental just from the people on this thread. Check it out, give us a budget, and let the magic happen.

Sorry on the delay - just relocated to SF!
It isn't the issue of renting - it's more I'm not used to it :( I'll try getting one in the following weeks :)

Hey, I wanted to throw out a lesser stepping-stone sort of request -- can there at a minimum be mac wheels with stubs?
For example, my team develops on macs but runs experiments and deploys models onto linux, with cuda GPUs. However, developing on mac when the unsloth package cannot be installed in a local environment means that e.g. IDEs cannot tab-complete to suggest class or method names, linters/checkers cannot flag when you misspelled a keyword argument, etc.
To me it's acceptable that to run an experiment, I need to provision a GPU instance. Even if it 'can' work on my laptop, it's likely faster and worthwhile for me to run it on a more powerful instance. But running a GPU instance just be able to install the package and discover (as a runtime error) that I accidentally passed warm_up_ratio=0.1 in UnslothTrainingArguments when actually it needs to be warmup_ratio ... seems like a waste of both human time and machine time. That's the kind of thing that a linter could have caught locally, if only I were able to install (but not run) unsloth in my mac development environment.

Oh interesting - ie just unsloth as a pure python package on Mac, but temporarily disable the fast code paths?

Yeah, so far as I'm concerned, if it throws "NotImplemented" errors, but
has the class/method signatures, that would be a meaningful step forward
from my point of view. Roughly, developers and CI environments would be
able to set up an environment that lets them check/lint even if they can't
run the full functionality. If that gives you an incremental path to
eventually provide that full behavior, that's great!
On Fri, Jul 5, 2024, 20:26 Daniel Han @.***> wrote:

Oh interesting - ie just unsloth as a pure python package on Mac, but
temporarily disable the fast code paths?
—
Reply to this email directly, view it on GitHub
https://github.com/unslothai/unsloth/issues/4#issuecomment-2211612297,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABD6MWW37OFEV5DHPFBE23ZK5PV5AVCNFSM6AAAAABADU7SJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRGYYTEMRZG4
.
You are receiving this because you commented.Message ID:
@.***>

I just need to develop/test chat templates w/o burning through GPU hours.  Any pointers on how you develop them without incurring the same costs?

The more upvotes this gets will equal to the priority!! If it's a big must - I'll try my best to implement it!

125 now.. Any news on progress

I guess the main problem right now is Apple's ability to support Triton and other Unsloth reliance's. Making Triton work for Apple GPUs is a lot of work and Apple hasn't reached out as far as we're aware of.
It is however possible for us to support Apple but with less optimizations (basically with no Triton optimizations) than what is currently available for NVIDIA GPUs. Is that what you guys want?

Hey, I'm jumping in here. I discovered unsloth recently, and I am quite enthusiastic about the project. It seems very promising.
On my side, I don't want any optimization when running on Apple silicon. I just want to be able to write code and run it to debug. The proper computation would run on a server where unsloth and its optimization can be installed.

HI boss,
is there any progress

:(

I can't use unsloth without GPU on my M1 chip! :(

I know this is a heavy popular request - apologies :(

In fact, an optimisation for Apple Silicon would be very interesting, because it is currently the cheapest way to have large amounts of VRAM. You can even have 64GB of memory in a laptop.

Hey guys, any updates? Just for MPS inference?

I guess the main problem right now is Apple's ability to support Triton and other Unsloth reliance's. Making Triton work for Apple GPUs is a lot of work and Apple hasn't reached out as far as we're aware of.
It is however possible for us to support Apple but with less optimizations (basically with no Triton optimizations) than what is currently available for NVIDIA GPUs. Is that what you guys want?

Yes— mac support with no optimization would be a great start!

Reference: https://github.com/apple/ml-ane-transformers

Apple Silicon is currently the cheapest option by far for training that requires a lot of VRAM. It would be great to support these use cases and the smaller developers who don't have access to dedicated hardware.

You can also use Apple Silicon on AWS.

Actually just got a Mac as a gift from someone - might be able to start on Silicon support :)

Great stuff! @danielhanchen
Even just some basic support initially without major optimizations would be amazing for debuggin, local testing & IDE feedback before we can run it on the cloud.

Actually just got a Mac as a gift from someone - might be able to start on Silicon support :)

Any updates?

No support for now, I guess. Try out MLX-ML and MLX-VLM. It supports fine-tuning, too

Oh yes please!!! This would be just AMAZING! @danielhanchen we are with you! 🚀

Great stuff! @danielhanchen
Even just some basic support initially without major optimizations would be amazing for debugging, local testing & IDE feedback before we can run it on the cloud.

I second this. I'm running unsloth on a Linux server, but I do my local development on MacOS. So just being able to install it and get IDE support would be amazing.

+1 for apple silicon

lets make this happen, unified memory is the way to go! Keep up the good work : )

Just use MLX— this doesn't seem to be a priority.

Just use MLX— this doesn't seem to be a priority.

Definitely is a priority. Unfortunately the team is still Daniel and I (Michael) so we firstly need to support all models first before working on this. And supporting Apple is more complicated than we anticipated.
One reason for the delay is because we have never used Mac devices before but now we have one but it will take a lot of time to understand how Apple training operates.

M4 Mac mini was on black Friday sale on Amazon just sayin 😁

@nicosuave  howd you train on MLX
@shimmyshimmer @danielhanchen I just got a new mac specifically to train loras please this would be the best holiday gift!

Part 7: Understanding LoRA Training with MLX


Html inlined markdown converted as text with 3.3 (strange case)

Conversion of following (simplified) markdown has changed in 3.3.0.
#Test

**Bold text**

3.2.2:

Test

Bold text

3.3.0 (same with 3.3.1, 3.3.2 and 3.3.3):

Test

**Bold text**

Note: inlined markdown is not rendered correctly even in 3.2.2 if the heading is absent or followed by a return.
We noticed this change in a MkDocs static website with a default configuration (no md_in_html extension). It's working as expected in 3.3 with md_in_html extension and markdown="1" attribute.
Probably more a fyi than a bug. Or at least incorrect usage on our end.

Yup this is expected. The old parser had a lot of buggy quirks and was re-written. In your specific case, prior to 3.3.0, the div wasn't handled like an HTML block tag because there was no blank line before it. The new parser will now handle it like a block tag even though there is no blank line in front of it. This now matches other parsers. So this behavior is known and is expected and, yes, different.
In 3.3.0+, block tags, if they are at the start of the line, will be handled like block tags, and the content will not be parsed as Markdown unless you are using the md_in_html extension and have added the markdown="1" attribute the tag.

As the rules explain:

Note that Markdown formatting syntax is not processed within block-level HTML tags. E.g., you can’t use Markdown-style *emphasis* inside an HTML block.

Therefore, the behavior in 3.2.2 was a bug, which we fixed.


[SHIRO-804] - Avoid conflicts with spring boot aop

#268
I found the problem related to the resolution order of Configuration. The ProxyCreator automatically created by Spring AOP is implemented through AopAutoConfiguration.
There are two cases:

First parse AopAutoConfiguration, will create a ProxyCreator, then parse ShiroAnnotationProcessorAutoConfiguration, judge @ConditionalOnMissBean, ProxyCreator already exists, no more ProxyCreator will be created. (good case)
First parse ShiroAnnotationProcessorAutoConfiguration, judge @ConditionalOnMissBean, there is no ProxyCreator, will create a ProxyCreator, then parse AopAutoConfiguration, will create the ProxyCreator again. (two ProxyCreators exist in the IOC, incorrect case!)

My version is:
shiro-spring-boot-starter:1.8.0
spring-boot-starter-aop:2.3.1.RELEASE
So, to be on the safe side, add @AutoConfigureAfter(AopAutoConfiguration.class) to the ShiroAnnotationProcessorAutoConfiguration.

@markixy thanks for your contribution!


Docs for Autofac outdated

Samples given on https://github.com/MassTransit/MassTransit/blob/master/doc/source/usage/containers/autofac.rst contain unknown references and generally do not compile. For example, IRabbitMqReceiveEndpointConfigurator has no method LoadFrom.

OK, I found out that I need to reference MassTransit.Autofac. Shouldn't this be mentioned too?

Yeah, I suppose adding the names of the NuGet packages for each feature would be a good idea.

Referencing MassTransit.Autofac helps but there are certainly still some compilation errors even so.


Recent messages not shown in "all messages" tab while in all other streams it is shown

In the all messages tab, the page doesn't go directly to recent messages instead we are required to scroll all the way down to view new message. While on the other hand, in all other streams, the messages shown are recent ones and there is not need to scroll down.

Solution:
Will add the same feature of streams to show recent messages in the all messages tab.

@zulipbot claim

@rutvi18 thanks for your feedback! I understand how you would be confused by this behaviour.
Zulip lands user on the first unread message in the narrow (= streams, all messages tab etc) compared to some other chat applications which land user on the most recent message.
Your conclusion about other narrows landing on the latest message is wrong. This behaviour is consistent across all narrows.


mwc-icon outlined icons missing

mwc-icon doesn't support the new icon themes (including outlined icons).

Should just need to rev the material-components-web version.

This should just be a matter of loading the Material+Icons+Outlined font in mwc-icon-font.ts, then specifying Material Icons Outlined as the --mdc-icon-font. Before PRing this, it'd be good to reconcile this idea with #195. This is a good argument for letting users load their own Material Icon sets.

Anyone out there looking at this ticket and wondering why their <mwc-icon> elements stopped working after an upgrade, add the following import.
import<EMAIL_ADDRESS>

We're actually now recommending just loading the font in your application HTML file. See https://github.com/material-components/material-components-web-components#fonts. We may remove the mwc-icon-font.js file in an upcoming breaking change release.

Aha, gotcha. Thanks for the heads up, I'll use that method. It might be on your radar, but just in case, the README.md for mwc-icon could use some of these updates.

Is this working for you now?

@dfreedm do you mind documenting this process in mwc-icon

Yeah I can do that

Will this be fixed in material 3?  And will it use Material Symbols instead of icons?

Fixed in M3, see icon docs for usage on loading outlined icons


fix: fix Save & Exit text variant

This PR resolves []
Description

The "Save & Exit" text was too small, it has to be sm
PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

fix Save & Exit text variant on the submission flow top navigation component -daria

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (fix Save & Exit text variant on the submission flow top navigation component -daria)

  Generated by :no_entry_sign: dangerJS against 0bfa9d2424423af5c326f41536737411d7f89d85


LHN - The employee's LHN account is displayed instead of the room name

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Preconditions:
Configure the OldDot administrator account and invite the employee to the policy https://sites.google.com/applausemail.com/applause-expensifyproject/wiki-guides/newdot-categories?authuser=0
Steps:

Open https://staging.new.expensify.com/
Log in with the account of the employee added to the policy
Navigate to the group policy chat room

Expected Result:
The Group Policy chat should display correctly and have its name in the LHN, just as it is displayed in the chat header itself
Actual Result:
The Group Policy Room chat of an employee is not displayed correctly in the LHN. The employee name is displayed instead of the policy name.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/86966588-9ad6-4783-a64a-33c8aff3aed3

View all open jobs on GitHub

Appears to be fixed in one of those issues


Updating images for stopped containers

Is it possible to explicitly update specific images, not currently running containers?
The use case is docker container being used as a cron task and not running all the time.

Currently this is not possible. What would like to achieve? Would you like to have stopped container to be recreated with the updated images and just leave it stopped?

That or simply pulling newer images would be fine.

It would be great if this worked not only for stopped containers, but all images returned by docker images.

Another use case is when your package manager fails silently and an app with a missing dependency gets deployed. Now the container is dead because its command won't run. Even after rebuilding and creating a new, healthy image, watchtower won't restart the stopped container with the new image.
If it instead pulled the newer image and restarted the container with it, the dead host would suddenly come back to life.

I can see this having a lot of hidden odd corner cases that needs to be addressed for it to work properly, especially to not make it interfer with the normal happy path. As such, it would likely require some groundwork beforehand. If you got the time and would like to have a stab at it, feel free. I'm currently preoccupied with getting the backlog back to some kind of manageable state.
Thanks for creating an issue though! 🙏


fix: Fixing the S3 bucket policy custodian applies

The S3 policy as it was would block the AWS Log Delivery service from writing logs to any buckets the policy was applied to.  By changing the Principle: * to a NotPrinciple: AWS: "arn:aws:iam::858827067514:root" that fixes this issue as that is the arn of AWS's Log Delivery Service account.  I have tested and verified this is working and allows logs to be written and blocks both console and sdk public object attempts

@kapilt ready for review

Do you know what the pricinples for those other services are?  I wasn't aware they were different for different services, thought it was just a general logging group account.


Request: PayPal provider

Hi @jerriepelser any plans for integrating PayPal login with http://t.co/mBMAkmZImF?— Taiseer Joudeh (@TJoudeh) March 25, 2015

https://developer.paypal.com/webapps/developer/docs/integration/direct/paypal-oauth2/

+1


Update UI to display TA tracker

Codecov Report
Base: 72.75% // Head: 72.75% // No change to project coverage :thumbsup:

Coverage data is based on head (5e46c34) compared to base (583ce84).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #87   +/-   ##
=========================================
  Coverage     72.75%   72.75%
  Complexity      443      443
=========================================
  Files            76       76
  Lines          1406     1406
  Branches        153      153
=========================================
  Hits           1023     1023
  Misses          336      336
  Partials         47       47

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Switch from <experimental/coroutine> to <coroutine>

This needs to be merged concurrently with managarm/cxxshim#10 and managarm/managarm#465.

Rebased on current master.


Check email server procedures

It seems sign up confirmation emails are not sent. Need to be fixed.

Problem is solved without any code change on the project. The cause was that the email server applies strong security measures, I let them to permit to our servers.
@kirbiyik @atifemreyuksel If you have any further inquiries, don't hesitate contacting.


ApplePay Crash

Hi, I'm experiencing an inconsistent crashes that occurs after confirming an Apple payment (wheither, it's Face ID or PassCode) and this crash happens from time to time
I'm using Sentry and here's the following error that i'm getting

Since this crash relates to memory issues, would it be somehow related to this package since it happens on ApplePay
Would appreciate your feedback 🙏
package.json:
"react-native": "0.74.5",
"@rnw-community/react-native-payments": "0.74.0",

P.S.

Hermes is enabled on iOS
New arch is turned off

Thanks for the report @Abdulmalick-Dimnang , to help you we need a reproduction repository/fork,
also please check example app if you will have the same

@Abdulmalick-Dimnang Have you tried? Otherwise I will close this issue

hey @vitalyiegorov
Honestly, it's really hard to replicate it since it never happened to me once but I see it happened to a lot of users through Sentry and other reports from end users
So I decided to not use the package unfortunately and instead I had to write a custom module to handle only ApplePay and that worked out so far

@Abdulmalick-Dimnang Thanks for the feedback, i will try to analyze the error you have provided during the swift migration.

Please try https://github.com/rnw-community/rnw-community/releases/tag/v0.77.0


Cypress/E2E: Fix guest experience ui spec

Summary

Use apiAddUserToTeam instead of old externalAddUserToTeam
Update comments
Remove externalAddUserToTeam

Ticket Link
None -  master and v5.28

Thanks Joseph! The tests you've improved are passing on my local but I'm constantly getting the following failure (in a different test in the same spec). Wondering if the test should also be demoted for a week to see if there is any other instability?

Thanks @josephbaylon! The tests you've improved are passing on my local but I'm constantly getting the following failure (in a different test in the same spec). Wondering if the test should also be demoted for a week to see if there is any other instability?

Hi @prapti, sure, we can demote it but can you try running the test from a clean slate first and see if it still fails for you?
Get latest from
mattermost-server
mattermost-redux
enterprise

then run server,
make nuke
make test-data
make run

then try to run test again. Let me know. Thanks.

Still failing with a clean run @josephbaylon.

@prapti Thanks for trying locally. I demoted the test.

Cherry pick is scheduled.


fix(schematron): handle Schematron context with href and select

Issue #547 is about a Schematron validation context that uses the select attribute with embedded XML content. The problem was fixed in #549 by wrapping the selection in a document node, if possible.
An analogous problem occurs when the context uses the select attribute with href. This pull request adds a scenario in issue-547.xspec to reproduce that problem, and then provides an analogous fix.

Cc: @vincentml


Break apart "repo" pillar into "branch" and "repo"

See also:
https://github.com/caktus/margarita/pull/127
https://github.com/caktus/django-project-template/pull/251/

:+1:


Settings don't save

change something, relaunch the game, settings revert to ultra

I've noticed this happen after a macOS update. It usually sorts itself out after a few restarts.

I've noticed this happen after a macOS update. It usually sorts itself out after a few restarts.

i just delete settings_v0.ini and redo my settings and they save


Move dig chunk creation from physics_process to _process

Digging was called in the player's physics process which typically gets called 60 times a second.  Moving it to _process massively decreases lag.  Maybe there is a better way to do this?  This solution is significantly more performant and even works on web.
Tangentially related.  I recently used this in a game jam - https://gregry.itch.io/save-the-animals-calm-before-the-storm.  I have a few other improvements I will create pull requests for.

Just confirmed the performance increase, appreciated friend.


Convert to internal trait from tag

This PR updates how EnumShapes are converted from strings with the deprecated @enum trait by adding the @internal trait to the resulting Enum shape member when when the source enum value was tagged with internal.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

We should document this behavior too. I think add javadoc to relevant methods in EnumShape, ModelTransformer.
I also noticed we have ChangeStringEnumsToEnumShapes but it is not documented in https://smithy.io/2.0/guides/building-models/build-config.html#transforms - it should be added there and this behavior documented there - this one can be separate PR.

I also noticed we have ChangeStringEnumsToEnumShapes but it is not documented in https://smithy.io/2.0/guides/building-models/build-config.html#transforms - it should be added there and this behavior documented there - this one can be separate PR.

Added separate PR in https://github.com/awslabs/smithy/pull/1740


b-form-select unexpected applied class in select element

One of the nice things about BootstrapVue (w/ Vue 2) is/was its "out of the box" good look.
Moving to bootstrap-vue-next (w/ Vue 3) has resulted in a lot of unexpected differences.
Using the b-form-select component  without applying any explicit class looks now rather ugly compared to "before":

Inspecting the applied class in the select element I see that before the custom-select class was applied while with BootstrapVue the form-select class is applied.
(If I apply the form-control Bootstrap class to a select element, it looks also good.)
Am I missing something? Is there a way to make it look as it was without having each time to add a class?

I think you're missing the required css files. You should review the documentation and try again.

Thanks for your answer. I'm still trying to figure this out: I tried to follow each step of the installation instructions and I simply don't understand where the problem comes from.
If I compare a b-form-select element from the doc to such an element in my project I can see that in both cases the form-select class is being applied to the select element but the corresponding style is missing in my project. Does someone have an idea why that might be?

I beg your pardon for the confusion, since I did some back-and-forth version installs I forgot to re-update the Boostrap version to 5. That solved the issue.


App detects wrong region

The flipper ios app occasionally detects the wrong region for firmware.

The issue was on our geo-ip server, should be fixed by now

Yep, seems good. Thanks!


Create function should work with function references

Describe what's missing
For code like this:
[1, 2, 3].forEach(print);

the extension only provides the Create Variable action for print. Instead, it would be nice to be able to create a function out of this too.
How would it work
I guess for the general case we'd need the infered types (#3).
Perhaps we could introduce a special case for forEach functions until then.
For functions called forEach we'd generate a function signature that takes 1 parameter and returns void.
This could work with map and filter as well.
Expected behavior
The extension provide the Create Function action to create a matching function if executed on a function reference used as a function parameter.
Additional information

Version of the extension used: v1.2.0

Hey, thanks for reporting but it's been a while since I updated this extension and I'm not planning to do this in the foreseeable future. I'm archiving the extension 👍


Ubuntu 18.04 docker image not building successfully

Mine is 18.04 as well, but it didn't work for me. I tried the #3 with creating the 99fixbadproxy file and
copying the pull request in #3 but it still gave me the following error:
E: Failed to fetch http://archive.lambdalabs.com/ubuntu/pool/main/n/nvidia-cuda-toolkit/libnppif10.0_10.0.130-0lambda3_amd64.deb  Undetermined Error [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://archive.lambdalabs.com/ubuntu/pool/main/n/nvidia-cudnn/libcudnn-dev_7.5.1-0lambda1_amd64.deb  Undetermined Error [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://archive.lambdalabs.com/ubuntu/pool/main/n/nvidia-cuda-toolkit-9.0/libaccinj64-9.0_<IP_ADDRESS>-0lambda1_amd64.deb  Undetermined Error [IP: <IP_ADDRESS> 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
I am behind companies proxy. Anything else that I can try @jenkinsadmin

Support for bionic 18.04 was removed in https://github.com/lambdal/lambda-stack-dockerfiles/commit/461d601d16e4a32915cb3bd4aecb67d0bae9f95e


Standardize "requires a subcommand" error message

Closes #298

This version passes the tests. I don't feel strongly about having a failing test that this PR fixes since it's mostly about wording and the code gets executed by the tests.  Thanks!

released as 2.19.2

Thank you!


Update index.md to check societal first delivery

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Dashboards with variables in variables doesn't load until

Steps to reproduce:
List the minimal actions needed to reproduce the behavior.
variable in variable query example (typical v.bucket set as variable1):
v1.measurementTagValues(bucket: v.bucket, measurement: "premier_league", tag: "Name")

Set dashboard to variables that will load correctly
Click out of the dashboard to another part of the UI
Return to dashboard where your variables were correctly set
Second variable doesn't load -- select another dropdown in first variable then return to correct variable

Expected behavior:
View all variables on first dashboard load.
Actual behavior:
List of second variables don't load when open dashboard. In example, need to click to another bucket/variable then return to correct variable
Environment info:

System info: Darwin 19.5.0 x86_64
InfluxDB version: Cloud
Other relevant environment details: Container runtime, disk info, etc

CPU Dashboard:

Cell query:
from(bucket: v.bucket)
  |> range(start: v.timeRangeStart, stop: v.timeRangeStop)
  |> filter(fn: (r) => r["_measurement"] == "cpu")
  |> filter(fn: (r) => r.Name == v.cpu)
  |> aggregateWindow(every: v.windowPeriod, fn: mean, createEmpty: false)
  |> yield(name: "mean")

Variable Bucket
buckets()
  |> filter(fn: (r) => r.name !~ /^_/)
  |> rename(columns: {name: "_value"})
  |> keep(columns: ["_value"])

Variable tag=cpu
import "influxdata/influxdb/v1"

v1.measurementTagValues(bucket: v.bucket, measurement: "cpu", tag: "cpu")


Replace docopt usage with urfave/cli

It looks like https://cli.urfave.org/v2/ has a fair bit of functionality like completion etc, and Olaf mentioned that commands without = fail with cryptic errors.
$ scip convert --from index.scip --to dump.lsif

panic: interface conversion: interface {} is nil, not string

goroutine 1 [running]:
main.convertMain(0x1552c60?)
	/Users/olafurpg/dev/sourcegraph/scip/cmd/convert.go:15 +0x474

I suppose this error could be fixed by removing the = in the docopt text, but it's not intuitive that a space is not accepted, and the error message for the crash is also not helpful.

Panic fixed in https://github.com/sourcegraph/scip/pull/26


Add new short name for "ExitCode" - "$?"

Hi @ddworken,
Thank you very much for such an awesome project! I used to save history between different machine in git repository which is neither secure, nor convenient. And I additionally thankful for ability to self-host it, even knowing that I don't have to trust the server and everything is encrypted (which is amazing), I still feel better self-hosting it.
Now, about the PR.
I have not so much space in my terminal usually, and want to see as much of the command line as I can. At the same time, it's nice to be able to see other columns as well.
This PR is aimed to save some space making the "Exit Code" column be able to have "$?" or "EC" names.
By default the column takes a lot of space, while all the values are just 1-3 digits, that's why I'd like to request this column to be shorter (maybe even by default, if you'd like to).

Awesome, thank you so much for the positive feedback and for the PR/detailed explanation. This change LGTM and makes perfect sense. I'm inclined to stick with the current default since I think it is a bit clearer, but I think this is a positive change to support.


useFeatureFlag hook for getting feature flag value in webview

This is not used by anything yet, but it will be used by another future PR for the prompt selector (using the prompts in the prompt library).
Test plan
Run in vscode and web and console.log the values.

this is causing some issues when the App component is torn down. need to look into it. code review otherwise is appreciated.


frist try, getting trade events

I need your help :( Reading through all the future and stream documentation takes forever.
With this code, I am trying to just parse the Trade events+eventstatus using streams. This would be great, as it would allow me to set invalidity dates for settled orders.
But I am getting these error messages:
`from_generator::GenFuture<[static generator@LogFilterBuilder::<T>::stream::{closure#0} for<'r, 's> {ResumeTy, &'r web3::Web3<DynTransport>, web3::Web3<DynTransport>, EthFilter<DynTransport>, &'s FilterBuilder, FilterBuilder, web3::types::Filter, CreateFilter<DynTransport, web3::types::Log>, ()}]>` cannot be unpinned
  --> orderbook/src/on_chain_state.rs:65:33
   |
65 |         while let Some(chunk) = events.next().await {
   |                                 ^^^^^^^^^^^^^^^^^^^ within `futures_util::future::try_future::try_flatten::_::__TryFlatten<'_, impl futures::Future, futures::stream::MapErr<FilterStream<DynTransport, web3::types::Log>, fn(web3::Error) -> ExecutionError {<ExecutionError as From<web3::Error>>::from}>>`, the trait `Unpin` is not implemented for `from_generator::GenFuture<[static generator@LogFilterBuilder::<T>::stream::{closure#0} for<'r, 's> {ResumeTy, &'r web3::Web3<DynTransport>, web3::Web3<DynTransport>, EthFilter<DynTransport>, &'s FilterBuilder, FilterBuilder, web3::types::Filter, CreateFilter<DynTransport, web3::types::Log>, ()}]>`

Alex and I having a call about this atm


Documentation insufficient / samples fail to build

Hi,
I tried to run the the IFrame sample component following these steps (and the install steps before) but I failed.
First, the install steps were insufficient and I failed at the step msbuild /t:restore because I had no msbuild. I installed VSCode and not Studio - I guess it comes with Studio. So after a while I found that I could install the build tools w\o Studio. I now have msbuild (but only via the Power Shell for VS 2019 ...).
Aight, so let's move on.

Navigate to the folder on your computer where you have downloaded the sample components, and extract the .zip file.

done

navigate to the sample component folder in the extracted folder that you want to see it in runtime

F:\PowerApps-Samples-master\component-framework\TS_IFrameControl

npm install

no problem

Create a new folder using the command mkdir  inside the sample component folder and navigate into the folder using the command cd

mkdir mytest
cd mytest

pac solution init --publisher-name  --publisher-prefix

pac solution init --publisher-name me --publisher-prefix pfx

pac solution add-reference --path

The sample component is the iframe thing, so pac solution add-reference --path ../. Am I missing something? The doc could be more explicit and say "in this case that's the parent directory" or something like that.

To generate a zip file from your solution project, you need to cd into your solution project directory and build the project using the following command: msbuild /t:restore

Wait, what's the "solution project directory"? Isn't this where we are right now? So no cding needed.
Alright, let's do this: msbuild /t:restore
Everything is green, seems legit.

Again, run the command "msbuild".

That should be easy:
  npm run build -- --noColor --buildMode development --outDir "F:\PowerApps-Samples-master\component-framework\TS_IFrameControl\out\controls" --buildSource MSBuild

  ><EMAIL_ADDRESS>build F:\PowerApps-Samples-master\component-framework\TS_IFrameControl
  > pcf-scripts build "--noColor" "--buildMode" "development" "--outDir" "F:\PowerApps-Samples-master\component-framework\TS_IFrameControl\out\controls" "--buildSource"
   "MSBuild"

  Der Befehl "pcf-scripts" ist entweder falsch geschrieben oder
  konnte nicht gefunden werden.
  npm ERR! code ELIFECYCLE
  npm ERR! errno 1
  npm ERR<EMAIL_ADDRESS>build: `pcf-scripts build "--noColor" "--buildMode" "development" "--outDir" "F:\PowerApps-Samples-master\component-framework\TS_IFrameCont
  rol\out\controls" "--buildSource" "MSBuild"`
  npm ERR! Exit status 1
  npm ERR!
  npm ERR! Failed at the<EMAIL_ADDRESS>build script.
  npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

  npm ERR!      C:\Users\xxx\AppData\Roaming\npm-cache\_logs\2020-07-14T08_32_40_761Z-debug.log

Nope. There is a pcf-scripts inside TS_IFrameControl/node_modules/.bin but msbuild does not seem to recognize this.
So, what am I missing here?

Also it seems like the folder TS_IFrameControl/TSIFrameControl has gone ...

Some additional information:
node v14.5.0
npm 6.14.5
Win10 Pro 19041.329

Hey @Nkrb any news on this? It's a real blocker for us right now.

@black-snow Please raise the issue here, our development team will help you solve the problem.

@black-snow Please raise the issue here, our development team will help you solve the problem.

https://powerusers.microsoft.com/t5/Power-Apps-Pro-Dev-ISV/Cannot-build-sample-components/m-p/632175#M3012

I finally figured it out. While node_modules/.bin was populated all the scripts inside it were empty (for whatever reason). Deleting and npm i again didn't recreate .bin but a complete wipe of node_muldes and a reinstall did the trick. I was then able to follow the last steps to create the zip.


Support for contact point and point constraints

Hi,
this PR adds supports for contact points and point constraints (position of a point). In particular this does:

creates a new contact-point class
creates a task-point-equality class
exposes the new classes in python and rename the current ContactPythonVisitor to Contact6DPythonVisitor
fixes a bug in contact-6d.cpp, where the constraint was defined too small and thereby the normal force constraint got lost

The contact-point and task-point-equality work in the world frame. For this, I've added a new RobotWrapper::frameJacobianLocalWorldOriented.
So far, I've tested the implementation on a quadruped demo. If the PR looks good overall, I would add a quadruped URDF model and write a basic test using the point contacts.

Hi @jviereck
I'm testing this PR. Do you have a python script to test the new features using the quadruped URDF model that you have committed?

I've seen you've used some C++11 features in the tests. So far the library has been compatible with C++98. We may consider moving to C++11, but I don't know if this is the right place to start this discussion. @jcarpent what is the policy of Pinocchio on this matter?

Concerning LAAS, the policy is to sick with C++98 for compatibility (HRP-2 notably).
Concerning Pinocchio, it is both C++98, C++11 and C++14 compliant.

@jviereck could you please grant me write access to your fork of TSID? So I can push some changes I've just implemented.

@andreadelprete

I'm testing this PR. Do you have a python script to test the new features using the quadruped URDF model that you have committed?

Not yet. I can add this if you want.

@jviereck could you please grant me write access to your fork of TSID? So I can push some changes I've just implemented.

I've added you as a collaborator to the jviereck/tsid repo. Let me know if it doesn't work.

I'm testing this PR. Do you have a python script to test the new features using the quadruped URDF model that you have committed?

I start working on this now.

@andreadelprete, I pushed a commit with a demo_quadruped.py. The demo shows how to push-up the com_z of the quadruped.

Hi @jviereck , thanks for the help. I've added some stuff and pushed everything to master. The main change I've introduced is to let the user specify not only the priority, but also the weight for the motion task (before you were using the same weight for motion and force regularization task, which didn't seem a good idea to me). Moreover, to be coherent with the way weights are specified for Tasks, now the weights associated to a Contact are specified when calling addRigidContact, instead of specifying them when creating the Contact object. The code should be backward compatible though, I've just marked some methods as deprecated and I've added some prints to warn the user to use the new methods.
Next I'm gonna work on the pin-v2 version.

Hi @andreadelprete, thanks for making the final edits, your help along the way for this PR and landing it!

Moreover, to be coherent with the way weights are specified for Tasks, now the weights associated to a Contact are specified when calling addRigidContact, instead of specifying them when creating the Contact object. The code should be backward compatible though, I've just marked some methods as deprecated and I've added some prints to warn the user to use the new methods.

This sounds good.

I've just merged this PR also in the branch pinocchio-v2, in case anybody is interested!


Rounding not applied properly when instantiating on ndarray of values that will overflow

I have an ndarray that overflowed from another operation to -7.70371978e-34 and upcasted itself to another dtype due to some arithmetic
If I then call Fxp(...) on this object I would expect the new value to be set to the min of whatever dtype is chosen. It looks like it tries to do this but this last step clear everything to zero (line ~600 of objects.py)
            if val_dtype == object:
                # convert each element to int
                new_val = np.array(list(map(int, new_val.flatten()))).reshape(new_val.shape)

If I rewrite this as the following it seems to fix the issue but haven't tested thoroughly beyond that it seems to have the proper rounded values.
            if val_dtype == object:
                # convert each element to int
                new_val = np.array(list(new_val.flatten())).reshape(new_val.shape)

Is there a reason they all need to be mapped to integers?  Seems like it should be something else.

Thanks for the issue!
It would be good if you could write an example to reproduce the error.
The integer mapping is because Numpy. If the Fxp has more than 64 bits, Numpy rise error in some cases because can't allocate more than 64 bits for np.int or (more dangerous) use float and rounds values using that precision. For that reason, it's necessary to use int python objects in those cases (object dtype for Numpy).
Maybe something useful for you is callbacks, to call a function when an overflow or underflow occurs. You can find and example in examples/v0_4_0_new_functionalities.ipynb. I'm going to copy part of it next:
from fxpmath.callbacks import Callback

def print_over_underflow_msg(self):
    print('Something is going wrong, some value is outside limits for this Fxp!')

my_callback = Callback()
my_callback.on_status_overflow = print_over_underflow_msg
my_callback.on_status_underflow = print_over_underflow_msg

x = Fxp(dtype='fxp-s16/4', callbacks=[my_callback])

Closing the issue due lack of answer. Feel free to reopen it if you consider it necessary.

Hey @francof2a , just wanted to say thanks for pointing out the callbacks that is pretty much what I was looking for - just a global exception configurable to a warning to be thrown on overflow.
This might be worth adding into the module, or for someone reading this thread later.  I have wrapper functions like this:
def gen_fxp_handler(type):
    def msg_printer(self):
        pprint(self.__dict__)
        assert False, f"Fxp {type}"
    return msg_printer

fxp_callback = Callback()
fxp_callback.on_status_overflow = gen_fxp_handler("overflow")
fxp_callback.on_status_underflow = gen_fxp_handler("underflow")

def to_fixed(float_num, total_bits, fraction_bits):
    return Fxp(float_num, signed=True, n_word=total_bits, n_frac=fraction_bits, callbacks=[fxp_callback],
        rounding='trunc', overflow='saturate')

def to_float(fixed_num):
    ret = fixed_num.get_val()
    ret = ret.astype(np.float64)
    return ret

this way it gets easier to keep the same parameters to the whole application and not have to know there's an Fxp object running around.  IMO it'd be nice if there was some global config that could be applied to Fxp in the current scope for configuring whether overflow/underflow is an error/warning/nothing in addition to the other parameters.
This is a very useful library, thanks!

Hi @nfrancque ,
Thanks for the code snippet!
It's glad to hear about fxpmath is useful for you.
The automatic error/warning/nothing behavior is a very good idea. It's pretty sure that I'll include it in next release.
Thanks!


Fix bad link in Fairing Docs

Fix bad link in Fairing Docs

Checked deploy preview. Looks fine. Thanks.

/cc   @animeshsingh @Bobgy