Reifying function lifts -- was: Bad effect lift

On commit f58a574fad9559ab7846876cfe995780209f9ddd, in examples/tactics/Printers.fst, making mk_print_binder a Tot function instead of Tac typechecks but fails at tactic runtime:
/home/guido/r/fstar/ulib/FStar.Tactics.Effect.fst(18,19-18,20): (Warning 265) Not an embedded tactic result: (match (match (match (match (match (match (reify (Meta_quoted "(print_Prims_int x)") "(((proofstate)))") with
	| (Success #.uu___#362 (Mktuple2 #.uu___#358 #.uu___#359 a#12469 q#12470))  -> (match (tracepoint q@0:(Tm_fvar: proofstate)) with
	| ()  -> ((fun uu___ -> (reify let  uu___#869  : (list term) = (map mk_print_binder (Cons () (Nil )))
in
(Cons uu___@1:(Tm_name: 'b) uu___@0:(Tm_delayed-resolved)))) a@1:(Tm_bvar: a@7) (decr_depth q@0:(Tm_fvar: proofstate))))
	|(Failed #.uu___#990 (Mktuple2 #.uu___#986 #.uu___#987 msg#12471 q#12472))  -> (Failed (Mktuple2 msg@1:(Tm_fvar: string) q@0:(Tm_fvar: proofstate)))) with
	| (Success #.uu___#362 (Mktuple2 #.uu___#358 #.uu___#359 a#12473 q#12474))  -> (match (tracepoint q@0:(Tm_fvar: proofstate)) with
	| ()  -> ((fun uu___ -> (reify (Cons (Meta_quoted ""Printers.A"") uu___@0:(Tm_delayed-resolved)))) a@1:(Tm_bvar: a@7) (decr_depth q@0:(Tm_fvar: proofstate))))
	|(Failed #.uu___#990 (Mktuple2 #.uu___#986 #.uu___#987 msg#12475 q#12476))  -> (Failed (Mktuple2 msg@1:(Tm_fvar: string) q@0:(Tm_fvar: proofstate)))) with
	| (Success #.uu___#362 (Mktuple2 #.uu___#358 #.uu___#359 a#12477 q#12478))  -> (match (tracepoint q@0:(Tm_fvar: proofstate)) with
	| ()  -> ((fun uu___ -> (reify (mk_concat (mk_stringlit " ") uu___@0:(Tm_delayed-resolved)))) a@1:(Tm_bvar: a@7) (decr_depth q@0:(Tm_fvar: proofstate))))
	|(Failed #.uu___#990 (Mktuple2 #.uu___#986 #.uu___#987 msg#12479 q#12480))  -> (Failed (Mktuple2 msg@1:(Tm_fvar: string) q@0:(Tm_fvar: proofstate)))) with
	| (Success #.uu___#362 (Mktuple2 #.uu___#358 #.uu___#359 a#12481 q#12482))  -> (match (tracepoint q@0:(Tm_fvar: proofstate)) with
	| ()  -> ((fun bod -> (reify let  bod#9255  : term = (match (Cons (Meta_quoted "int") (Cons (Meta_quoted "int") (Nil ))) with
	| (Nil #.uu___#6125)  -> bod@0:(Tm_fvar: term)
	|_  -> (paren bod@1:(Tm_fvar: term)))
in
(Mktuple2 (Pat_Cons (pack_fv (Cons "Printers" (Cons "A" (Nil )))) (Cons (Pat_Var ()) (Cons (Pat_Var ()) (Nil )))) bod@0:(Tm_delayed-resolved)))) a@1:(Tm_bvar: a@7) (decr_depth q@0:(Tm_fvar: proofstate))))
	|(Failed #.uu___#990 (Mktuple2 #.uu___#986 #.uu___#987 msg#12483 q#12484))  -> (Failed (Mktuple2 msg@1:(Tm_fvar: string) q@0:(Tm_fvar: proofstate)))) with
	| (Success #.uu___#362 (Mktuple2 #.uu___#358 #.uu___#359 a#12485 q#12486))  -> (match (tracepoint q@0:(Tm_fvar: proofstate)) with
	| ()  -> ((fun uu___ -> (reify let  uu___#869  : (list branch) = (map (fun ctor -> (match ctor@0:(Tm_delayed-resolved) with
	| (Ctor name#9239 t#9240)  -> let  pn#9241  : string = (concat "." name@1:(Tm_fvar: name))
in
let  uu___#9242  : (tuple2 (list typ) comp) = (collect_arr t@1:(Tm_fvar: typ))
in
(match uu___@0:(Tm_delayed-resolved) with
	| (Mktuple2 #.uu___#2101 #.uu___#2102 t_args#9243 _)  -> let  bv_pats#9245  : (list (tuple2 binder pattern)) = (map (fun ti -> let  b#9247  : binder = (fresh_binder ti@0:(Tm_delayed-resolved))
in
(Mktuple2 b@0:(Tm_fvar: binder) (Pat_Var b@0:(Tm_fvar: binder)))) t_args@1:(Tm_delayed-resolved))
in
let  uu___#9248  : (tuple2 (list binder) (list pattern)) = (split bv_pats@0:(Tm_delayed-resolved))
in
(match uu___@0:(Tm_delayed-resolved) with
	| (Mktuple2 #.uu___#3848 #.uu___#3849 bvs#9249 pats#9250)  -> let  head#9251  : term = (pack (Tv_Const (C_String pn@7:(Tm_fvar: string))))
in
let  bod#9252  : term = let  uu___#9253  : (list term) = let  uu___#9254  : (list term) = (map mk_print_binder bvs@2:(Tm_delayed-resolved))
in
(Cons head@1:(Tm_fvar: term) uu___@0:(Tm_delayed-resolved))
in
(mk_concat (mk_stringlit " ") uu___@0:(Tm_delayed-resolved))
in
let  bod#9255  : term = (match t_args@7:(Tm_delayed-resolved) with
	| (Nil #.uu___#6125)  -> bod@0:(Tm_fvar: term)
	|_  -> (paren bod@1:(Tm_fvar: term)))
in
(Mktuple2 (Pat_Cons (pack_fv name@12:(Tm_fvar: name)) pats@3:(Tm_delayed-resolved)) bod@0:(Tm_delayed-resolved)))))) (Cons (Ctor (Cons "Printers" (Cons "B" (Nil ))) (Meta_quoted "(_0:string -> Tot t1)")) (Cons (Ctor (Cons "Printers" (Cons "C" (Nil ))) (Meta_quoted "t1")) (Nil ))))
in
(Cons uu___@1:(Tm_name: 'b) uu___@0:(Tm_delayed-resolved)))) a@1:(Tm_bvar: a@7) (decr_depth q@0:(Tm_fvar: proofstate))))
	|(Failed #.uu___#990 (Mktuple2 #.uu___#986 #.uu___#987 msg#12487 q#12488))  -> (Failed (Mktuple2 msg@1:(Tm_fvar: string) q@0:(Tm_fvar: proofstate)))) with
	| (Success #.uu___#362 (Mktuple2 #.uu___#358 #.uu___#359 a#12489 q#12490))  -> (match (tracepoint q@0:(Tm_fvar: proofstate)) with
	| ()  -> ((fun branches -> (reify let  m#9258  : term = (pack (Tv_Match (pack (Tv_Var ())) branches@0:(Tm_delayed-resolved)))
in
let  uu___#9259  : unit = (exact_guard m@0:(Tm_fvar: term))
in
(smt ()))) a@1:(Tm_bvar: a@7) (decr_depth q@0:(Tm_fvar: proofstate))))
	|(Failed #.uu___#990 (Mktuple2 #.uu___#986 #.uu___#987 msg#12491 q#12492))  -> (Failed (Mktuple2 msg@1:(Tm_fvar: string) q@0:(Tm_fvar: proofstate)))) (see also /home/guido/r/fstar/ulib/FStar.Tactics.Effect.fst(17,17-17,18))
examples/tactics/Printers.fst(61,30-61,53): (Error 170) Tactic got stuck! Please file a bug report with a minimal reproduction of this issue.
(match (match (match (match (match (match (reify (Meta_quoted "(print_Prims_int x)") "(((proofstate)))") with
	| (Success #.uu___#362 (Mktuple2 #.uu___#358 #.uu___#359 a#12469 q#12470))  -> (match (tracepoint q@0:(Tm_fvar: proofstate)) with
	| ()  -> ((fun uu___ -> (reify let  uu___#869  : (list term) = (map mk_print_binder (Cons () (Nil )))
in
(Cons uu___@1:(Tm_name: 'b) uu___@0:(Tm_delayed-resolved)))) a@1:(Tm_bvar: a@7) (decr_depth q@0:(Tm_fvar: proofstate))))
	|(Failed #.uu___#990 (Mktuple2 #.uu___#986 #.uu___#987 msg#12471 q#12472))  -> (Failed (Mktuple2 msg@1:(Tm_fvar: string) q@0:(Tm_fvar: proofstate)))) with
	| (Success #.uu___#362 (Mktuple2 #.uu___#358 #.uu___#359 a#12473 q#12474))  -> (match (tracepoint q@0:(Tm_fvar: proofstate)) with
	| ()  -> ((fun uu___ -> (reify (Cons (Meta_quoted ""Printers.A"") uu___@0:(Tm_delayed-resolved)))) a@1:(Tm_bvar: a@7) (decr_depth q@0:(Tm_fvar: proofstate))))
	|(Failed #.uu___#990 (Mktuple2 #.uu___#986 #.uu___#987 msg#12475 q#12476))  -> (Failed (Mktuple2 msg@1:(Tm_fvar: string) q@0:(Tm_fvar: proofstate)))) with
	| (Success #.uu___#362 (Mktuple2 #.uu___#358 #.uu___#359 a#12477 q#12478))  -> (match (tracepoint q@0:(Tm_fvar: proofstate)) with
	| ()  -> ((fun uu___ -> (reify (mk_concat (mk_stringlit " ") uu___@0:(Tm_delayed-resolved)))) a@1:(Tm_bvar: a@7) (decr_depth q@0:(Tm_fvar: proofstate))))
	|(Failed #.uu___#990 (Mktuple2 #.uu___#986 #.uu___#987 msg#12479 q#12480))  -> (Failed (Mktuple2 msg@1:(Tm_fvar: string) q@0:(Tm_fvar: proofstate)))) with
	| (Success #.uu___#362 (Mktuple2 #.uu___#358 #.uu___#359 a#12481 q#12482))  -> (match (tracepoint q@0:(Tm_fvar: proofstate)) with
	| ()  -> ((fun bod -> (reify let  bod#9255  : term = (match (Cons (Meta_quoted "int") (Cons (Meta_quoted "int") (Nil ))) with
	| (Nil #.uu___#6125)  -> bod@0:(Tm_fvar: term)
	|_  -> (paren bod@1:(Tm_fvar: term)))
in
(Mktuple2 (Pat_Cons (pack_fv (Cons "Printers" (Cons "A" (Nil )))) (Cons (Pat_Var ()) (Cons (Pat_Var ()) (Nil )))) bod@0:(Tm_delayed-resolved)))) a@1:(Tm_bvar: a@7) (decr_depth q@0:(Tm_fvar: proofstate))))
	|(Failed #.uu___#990 (Mktuple2 #.uu___#986 #.uu___#987 msg#12483 q#12484))  -> (Failed (Mktuple2 msg@1:(Tm_fvar: string) q@0:(Tm_fvar: proofstate)))) with
	| (Success #.uu___#362 (Mktuple2 #.uu___#358 #.uu___#359 a#12485 q#12486))  -> (match (tracepoint q@0:(Tm_fvar: proofstate)) with
	| ()  -> ((fun uu___ -> (reify let  uu___#869  : (list branch) = (map (fun ctor -> (match ctor@0:(Tm_delayed-resolved) with
	| (Ctor name#9239 t#9240)  -> let  pn#9241  : string = (concat "." name@1:(Tm_fvar: name))
in
let  uu___#9242  : (tuple2 (list typ) comp) = (collect_arr t@1:(Tm_fvar: typ))
in
(match uu___@0:(Tm_delayed-resolved) with
	| (Mktuple2 #.uu___#2101 #.uu___#2102 t_args#9243 _)  -> let  bv_pats#9245  : (list (tuple2 binder pattern)) = (map (fun ti -> let  b#9247  : binder = (fresh_binder ti@0:(Tm_delayed-resolved))
in
(Mktuple2 b@0:(Tm_fvar: binder) (Pat_Var b@0:(Tm_fvar: binder)))) t_args@1:(Tm_delayed-resolved))
in
let  uu___#9248  : (tuple2 (list binder) (list pattern)) = (split bv_pats@0:(Tm_delayed-resolved))
in
(match uu___@0:(Tm_delayed-resolved) with
	| (Mktuple2 #.uu___#3848 #.uu___#3849 bvs#9249 pats#9250)  -> let  head#9251  : term = (pack (Tv_Const (C_String pn@7:(Tm_fvar: string))))
in
let  bod#9252  : term = let  uu___#9253  : (list term) = let  uu___#9254  : (list term) = (map mk_print_binder bvs@2:(Tm_delayed-resolved))
in
(Cons head@1:(Tm_fvar: term) uu___@0:(Tm_delayed-resolved))
in
(mk_concat (mk_stringlit " ") uu___@0:(Tm_delayed-resolved))
in
let  bod#9255  : term = (match t_args@7:(Tm_delayed-resolved) with
	| (Nil #.uu___#6125)  -> bod@0:(Tm_fvar: term)
	|_  -> (paren bod@1:(Tm_fvar: term)))
in
(Mktuple2 (Pat_Cons (pack_fv name@12:(Tm_fvar: name)) pats@3:(Tm_delayed-resolved)) bod@0:(Tm_delayed-resolved)))))) (Cons (Ctor (Cons "Printers" (Cons "B" (Nil ))) (Meta_quoted "(_0:string -> Tot t1)")) (Cons (Ctor (Cons "Printers" (Cons "C" (Nil ))) (Meta_quoted "t1")) (Nil ))))
in
(Cons uu___@1:(Tm_name: 'b) uu___@0:(Tm_delayed-resolved)))) a@1:(Tm_bvar: a@7) (decr_depth q@0:(Tm_fvar: proofstate))))
	|(Failed #.uu___#990 (Mktuple2 #.uu___#986 #.uu___#987 msg#12487 q#12488))  -> (Failed (Mktuple2 msg@1:(Tm_fvar: string) q@0:(Tm_fvar: proofstate)))) with
	| (Success #.uu___#362 (Mktuple2 #.uu___#358 #.uu___#359 a#12489 q#12490))  -> (match (tracepoint q@0:(Tm_fvar: proofstate)) with
	| ()  -> ((fun branches -> (reify let  m#9258  : term = (pack (Tv_Match (pack (Tv_Var ())) branches@0:(Tm_delayed-resolved)))
in
let  uu___#9259  : unit = (exact_guard m@0:(Tm_fvar: term))
in
(smt ()))) a@1:(Tm_bvar: a@7) (decr_depth q@0:(Tm_fvar: proofstate))))
	|(Failed #.uu___#990 (Mktuple2 #.uu___#986 #.uu___#987 msg#12491 q#12492))  -> (Failed (Mktuple2 msg@1:(Tm_fvar: string) q@0:(Tm_fvar: proofstate))))
1 error was reported (see above)

Just making a Tac for now, but we should fix this.

Another repro from @catalin-hritcu.
let is_const (t:term) : Tac bool = Tv_Const? (inspect t)

this was getting stuck inside of the bigger deep canonizer. It is probably related to matches and their special handling w.r.t monadic anotations: all of these examples pattern-match or apply a discriminator or something.

Another. All of the examples look somewhat like this. Something to do with subeffecting of functions I imagine.
let f (x : int) : Tot int = x + 1

let _ = assert_by_tactic True
            (fun () -> let l = map f [1] in
                       ())

Another repro from @Kachoc
open FStar.Tactics

let rec list_sum (l:list nat) : nat =
  match l with
  | [] -> 0
  | n :: l' ->
    n + (list_sum l')

let recursive_norm () : Tac unit =
  let ctrl (t : term) = (true, 0) in // GM: This is the offending line
  topdown_rewrite ctrl trefl

let list_sum_lem () : Lemma (list_sum [1;2;3;4;5] = 15) =
  assert(list_sum [1;2;3;4;5] = 15)
    by (recursive_norm ())

So I never wrote down the actual issue here.
The problem is subeffecting from Tot (or anything else) into Tac. When we have x:Tot t and need a Tac t, the typechecker will internally wrap x with a Meta_monadic_lift which explicitly marks the place where the subeffecting happened. This marker is then used by the normalizer when reifying tactics to insert the elaboration of the lift.
The unifier, however, when called on a problem of the shape a -> Tot b <: a -> Tac b will just solve it, no questions asked. So when we apply such a function, we get a Tac b that is internally a Tot b without the lift, causing the normalizer to get stuck, or go nuts.
There's a tension between considering Tot and Tac as subeffects/subtypes, and needing to have an explicit marker. We might want to talk about it next meeting @aseemr @nikswamy.

These are now rejected early by a patch that prevents the use of subeffecting for reifiable computations under arrows (thanks Nik and Aseem for the suggestion), so this won't explode in the user's face. We should still find a way to make the subeffecting work though.


Preserving contractions

Is there any to preserve contractions when using TextBlob?
For example I'd like to do something like:
text = 'I don't like it."
TextBlob.words

and have ['I', "don't", 'like', 'it'] instead of ['I', 'do', "n't", 'like', 'it]
I'm not aware of any tokenisers that will do this and I don't feel anything I can hack together will be good enough.

You could resort to post-processing the tokens and join together any
contiguous ["do", "n't"] pair if nothing else can be done.
On Thu, Apr 20, 2017 at 9:04 AM, Tom Carrick<EMAIL_ADDRESS>wrote:

Is there any to preserve contractions when using TextBlob?
For example I'd like to do something like:
text = 'I don't like it."
TextBlob.words
and have ['I', "don't", 'like', 'it'] instead of `['I', 'do', "n't",
'like', 'it]
I'm not aware of any tokenisers that will do this and I don't feel
anything I can hack together will be good enough.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sloria/TextBlob/issues/158, or mute the thread
https://github.com/notifications/unsubscribe-auth/AE_2rLWnZTpyE-O7Z897XENB720tpqtzks5rx4ITgaJpZM4NDPmp
.

The regular expression is hardcoded in the nltk.tokenize.treebank.TreebankWordTokenizer class.
`    ENDING_QUOTES = [
(re.compile(r'"'), " '' "),
(re.compile(r'(\S)('')'), r'\1 \2 '),
    (re.compile(r"([^' ])('[sS]|'[mM]|'[dD]|') "), r"\1 \2 "),
    **# (re.compile(r"([^' ])('ll|'LL|'re|'RE|'ve|'VE|n't|N'T) "), r"\1 \2 "),`**

i commented out that line for laughs and giggles and got this:
╰─$ python mypy.py ['i', "don't", 'like', 'it']

I ended up making a Tokenizer that looks like this, and then using .tokens instead of .words:
import re

from nltk.tokenize.treebank import TreebankWordTokenizer
from textblob.utils import strip_punc

class ContractionPreservingTokenizer(TreebankWordTokenizer):
    ENDING_QUOTES = [
        (re.compile(r'"'), " '' "),
        (re.compile(r'(\S)(\'\')'), r'\1 \2 '),
    ]

    def tokenize(self, text):
        tokens = super().tokenize(text)
        return [word if word.startswith("'") else strip_punc(word, all=False)
                for word in tokens if strip_punc(word, all=False)]

It seems this is probably the best solution with the current codebase.


provide a CHANGELOG

I'm trying to debug a problem that appears to cropped up when module-deps was upgraded from 3.7.3 to 3.9.1. It would help me narrow down on the issue faster if there was a CHANGELOG or HISTORY.md, as is common for many projects. Would you please consider this?

Agreed, but it comes down a bandwidth problem – we're all doing this on our free time. All I can offer now is that the commit messages are usually pretty good, and github gives you an easy way to compare across revs (https://github.com/substack/module-deps/compare/3.7.3...v3.9.1).


Properly bundles package before publishing to npm. fix #8

Issue number: #8
Summary
It looks like the current publish process does not build before packaging, so all the .js files are missing (see #8)
Changes
Adds the npm i and npm run build steps before npm publish in the npm-publish.yml workflow
User experience
n/d
Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] I have performed a self-review of this change
[ ] Changes have been tested (hard to test actions :/ )
[x] Changes are documented

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Thank you @lmammino for the PR.
Indeed, I missed that. I recently migrated to github actions from manual publish to NPM and it seems like I missed that.

Awesome, thanks for reviewing and merging this so quickly! I was actually thinking the build step could be removed entirely, since we are effectively re-building again in the following step so it's a bit of a useless duplication of work!
Are you planning to do a new release with this fix?


Sash broken when extension editor is open

Create two columns, open the extension editor on one side and try to resize the vertical sash with the mouse.
When releasing the mouse button the sash jumps back

/duplicate #52150


Make tomee run with a read-only root file system

fixes #104

The buildpack should start tomee to be able to run with a readonly root filesystem..
Summary

Adding empty openejb.xml so it does not have to be created
For tiny stack, do not set java.io.tmpdir and rely on the default /tmp
For other stacks it will set CATALINA_TMPDIR to /tmp

Use Cases

With that change, it is possible to mount a read-only file system as long as you have a writeable /tmp.
Checklist

[X] I have viewed, signed, and submitted the Contributor License Agreement.
[X] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[X] I have added an integration test, if necessary.
[X] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Taking additional user input (e.g. TMPDIR) into account

Also, what was the decision regarding TMPDIR? I don't think this PR would allow a user to set TMPDIR and have it impact where Tomee writes its temp files. Is that still desired or is that out of scope for this PR?
Thanks

Taking additional user input (e.g. TMPDIR) into account

Also, what was the decision regarding TMPDIR? I don't think this PR would allow a user to set TMPDIR and have it impact where Tomee writes its temp files. Is that still desired or is that out of scope for this PR?
Thanks

Making use of TMPDIR environment variable is a bigger change than expected initially, and we decided that as a first step we would like to align tomee and tomcat (https://github.com/paketo-buildpacks/apache-tomcat/pull/282) in terms of java.io.tmpdir and CATALINA_TMPDIR variables.

@dmikusa I just looked for this in releases and realised that the last apache-tome release is over 20 days old. Does that repo not participate in the usual release cadence of Paketo's Java language family buildpacks?


Cannot use public-resolvers locally

I have downloaded public-resolvers.md from upstream, then I configured dnscrypt-proxy.toml to make the main app use it locally. However I get the following message when I try to install the service:
D:\dnscrypt-proxy-win64>.\dnscrypt-proxy.exe -service install
[2018-02-25 00:53:31] [NOTICE] System DNS configuration not usable yet, exceptionally resolving [] using fallback resolver [<IP_ADDRESS>:53]
[2018-02-25 00:53:31] [CRITICAL] Unable use source [local-resolvers]: [No IP found for []]
[2018-02-25 00:53:31] [FATAL] No servers configured

D:\dnscrypt-proxy-win64>.\dnscrypt-proxy.exe -service start
[2018-02-25 00:53:31] [NOTICE] System DNS configuration not usable yet, exceptionally resolving [] using fallback resolver [<IP_ADDRESS>:53]
[2018-02-25 00:53:32] [CRITICAL] Unable use source [local-resolvers]: [No IP found for []]
[2018-02-25 00:53:32] [FATAL] No servers configured
""
Thank you for using dnscrypt-proxy! Hit [RETURN] to finish

So what's wrong with me? Please check.
dnscrypt-proxy.toml.zip

Hi,
Before doing something very custom, I'd recommend starting with a standard configuration as documented and as everybody else.
Remove the service (-service uninstall) and delete whatever files you downloaded manually. These will be downloaded automatically.
Then, make sure that your computer is configured normally, and can access the internet. Do not change the DNS settings to <IP_ADDRESS> yet, just have a working configuration.
Save a copy of the example configuration file as dnscrypt-proxy.toml. Do not change anything to it yet. Then, start the proxy without installing the service.
If it works, tweak the configuration file the way you want. Every time you change something, check that the proxy can still be started (not as a service yet).
Eventually, when you get to something that fits you needs and works, install it as a service and change your DNS settings.

Closing, because after looking at your configuration file, you will find your mistake by following the process above. I promise.

I know what's wrong with me. If I missed public-resolvers.md.minisig, then the resolver list become illegal, but when I get minisig from remote server, it works.

Althrough I get both md and minisig files, they works for me only one day, then I've to reconfigure and redownload the resolver list in the next day, that's weird. Anyway I'll try 2.0.6 to see what will happen.

That's expected. Cache files expire according to what you set the refresh_delay value to.

Thank you very much.

The problem appearing to me again even if I set refresh_delay=65536.


making pages for buildings

Pages still to be done:

[ ] R87 - Ridgeway House,  link to website
[ ] R116 - SCD, make SCD page and link to it
[ ] R34 -
[ ] R56 - Logistics could get rid off
[ ] R79 - Diamond_BID_ISIS
[ ] R12 - Technology
[ ] R76 -
[ ] R63 - Technology
[ ] R65 - Technology
[ ] R66 - Technology
[ ] R52 -
[ ] R68 - Estates-Technology-RAL space, don't link to estates just put it in the name
[ ] R104 - BID
[ ] R25 - Technology-RAL space
[ ] R1 - HR-Legal-CLF-Technology-Finance-PPD-BID: only use Technology, PPD, BID, don't link to hr, legal, finance just put them in the name
[ ] R8 - ISIS
[ ] R9 - Technology
[ ] R10 - Estates don't link
[ ] R11 - RFI
[ ] R79 - Diamond-BID-ISIS
[ ] R56 - Logistics could get rid of
[ ] R75 - Reception doesn't need page
[ ] R92 - Harwell Research Council
[ ] I14 -
[ ] R98/I13 -

Please put your name next to any pages you are doing.


This should be waived under CC0

Copyright legislation is tricky, obviously this repo is intended to be be used as base for a project with any license. But copyright law does not say that. The best way to make it clear right now is waiving it to the public domain with CC0.
I think it's a good practice, what do you think?
By the way, I did a setup.sh file for this project, I don't know if it's ready for merging, check it out here: https://git.hackware.cl/omnipay-skeleton

#4


Lazy loading module with material dependencies also includes typings

Bug, feature request, or proposal:
Bug
What is the expected behavior?
No typings dependencies would be included for a prod build
What is the current behavior?
the @angular/material/typings/index.ngfactory.ts is included in a prod build when using lazy loaded modules
What are the steps to reproduce?
convert the angular app to use lazy loaded modules like:
export const APP_ROUTES: Routes = [
  { path: '', component: AppComponent},
  { path: 'lazy', loadChildren: '../map/overview-ap.module#OverviewMapModule' }
];

And do a prod cli build with sourcemaps:
ng build --prod --sourcemaps

and then inspect with source map explorer:

What is the use-case or motivation for changing an existing behavior?
We don't want unnecessary files in the prod build
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
angular-cli - 1.2.0
angular 4.2.6
angular-material 2.0.0-beta.8
typescript 2.2.2

+1 I am seeing this too. any way around this?

It's not typing information, it's the generated code from AoT for the whole library.
Tracked via #4137

So, is it correct, that in final bundle for each material module we have *.es5.js and *typings/index.ngfactory.js files?


Sorting grid column 3 times

Three consecutive double clicks on a column's header produce 3 different results. Is this the expected behavior? Looks like Ascending, Descending orders first and second and then the column's values are scattered randomly on the third click. Does it mean they are returned to the original order?

Yes. Ascending, then descending, then original. The current sorting order is indicated by an up/down arrow next to the column name, no arrow means original order.

Thank you for the clarification! To set the original row order one should call grid.setRowOrder([0,1,2,3,...])?
Also will it be possible to potentially add an method to Grid to check if a column is currently sorted or has the original order? For example isSorted(bAscending : boolean) or isOriginalRowOrder() or getRowOrder() ?


MRG: Better error message for morph

Gives a more informative error message when users request a grade that can't be constructed for a subject. Previously they would get an error about vertices needing to be in ascending order, now they get a more informative message like "Cannot use icosahedral grade 6 with subject sample, mapping 40962 vertices onto the high-resolution mesh yields repeated vertices".
Apparently @nfoti is hitting a lot of corner cases for us :)
Ready for review/merge from my end.

[Current coverage][cc-pull] is 86.23%

Merging [#3323][cc-pull] into [master][cc-base-branch] will decrease coverage by <.01%

@@             master      #3323   diff @@
==========================================
  Files           336        336
  Lines         57298      57302     +4
  Methods           0          0
  Messages          0          0
  Branches       8717       8719     +2
==========================================
  Hits          49414      49414
- Misses         5214       5220     +6
+ Partials       2670       2668     -2

[][cc-pull]

Powered by Codecov. Last updated by [61885e6...2a285da][cc-compare]
[cc-base-branch]: https://codecov.io/gh/mne-tools/mne-python/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/mne-tools/mne-python/compare/61885e6c5db39b1147dd9450ebc0922b2aa77c0b...2a285da551d52a31e296f8f66785d770ed5fd7f9
[cc-pull]: https://codecov.io/gh/mne-tools/mne-python/pull/3323?src=pr

Comments addressed

thx @Eric89GXL


Example simple_writer.py returns success even when it's failed.

When the example fails to post it still prints out "Successfully posted".

Should hopefully be fixed in bba562e
Suspect it was down to the way the write function only returns one value on a successful post, but three on an unsuccessful post.


undefined reference to `mbedtls_debug_set_threshold' when MBEDTLS_DEBUG is enabled

Describe the bug
Cannot enable debugging of MBEDTLS.  Something is rotten in the state of Denmark. (C) Shakespeare
To Reproduce
Steps to reproduce the behavior:

in #14632, enable MBEDTLS_DEBUG
build
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots or console output
/opt/zephyr-sdk/i586-zephyr-elf/bin/../lib/gcc/i586-zephyr-elf/8.3.0/../../../../i586-zephyr-elf/bin/ld: libzephyr.a(sockets_tls.c.obj): in function `tls_init':
/home/laperie/workspace/zephyr/zephyr/subsys/net/lib/sockets/sockets_tls.c:289: undefined reference to `mbedtls_debug_set_threshold'
collect2: error: ld returned 1 exit status
zephyr/CMakeFiles/zephyr_prebuilt.dir/build.make:99: recipe for target 'zephyr/zephyr_prebuilt.elf' failed
make[2]: *** [zephyr/zephyr_prebuilt.elf] Error 1

Environment (please complete the following information):
Linux
0.10.0 SDK

Hi @laperie, I've seen this issue before. It seems that make does not rebuild mbedTLS in case Zephyr configuration is changed (in this case mbedTLS debug enabled). When I used make, I forced it to rebuild entire project with make clean && make after changing mbedTLS configuration.
Apparently this is not an issue when using ninja - it seems to understand better what needs to be rebuilt.

Hi @laperie, I've seen this issue before. It seems that make does not rebuild mbedTLS in case Zephyr configuration is changed (in this case mbedTLS debug enabled). When I used make, I forced it to rebuild entire project with make clean && make after changing mbedTLS configuration.

Cannot confirm that, sorry -- same symptoms no matter what you use to build the sample.  Problem is likely elsewhere...

I have not used public server like in the example as I do not have direct internet access from my test host. So I used simple python https server with self certified certificate, could that self cert be the culprit here?

@jukkar I suppose the above comment reffered to #14632?

Ah, sorry, I seemed to have commented wrong issue :)

I just tried this and did not see any issues -> closing.

Adding the mysterious CONFIG_MBEDTLS_DEBUG_C fixes it for me.


BQN Support

Language
BQN is a modern, powerful language created by @mlochbaum centered on Ken Iverson's array programming paradigm.
It supports:

A simple, consistent, and stable array programming language
A low-dependency C implementation using bytecode compilation: installation
System functions for math, files, and I/O (including a C FFI)
Documentation with examples, visuals, explanations, and rationale for features

Additional resources
There is a userscript for highlighting BQN in a browser already written by @dzaima info, who is also the maintainer of the officially-recommended implementation.
While I'm sure the code in the userscript will need modifying for use in PrismJS, a large part of the work is already therefore done.
Other Links:
BQN Homepage
Official Page Recommending the Above Userscript

Closed by #3515.


[Add-ins] (browsers) Include link to ProPlus update history page

Helps address #1772

Docs Build status updates of commit 1f292a7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/concepts/browsers-used-by-office-web-add-ins.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


IntelliSense does not work in table.fields part

When I want to use IntelliSense anywhere inside fields part (root, field, trigger level) of table (or tableextension) object to select properties, variables type, or anything else, it stucks on Loading... text.
When I write Rec. and use IntelliSense after that, it works. Also there is no problem outside of fields part.
AL Language: v12.1.883011 - but I have already had the issue in v11.x
VSCode: v1.83.1

At first, one note: as I wrote, it happens inside table and tableextension objects, not page.
And yes, it happens in all of them.The project is a workspace with couple of apps.
I will do more tests on my environment - I will try a new project; I will try to disable extensions (I did not want to do it because of mix of many active and disabled ones), and so on...I let you know.

Hard to reproduce.
I have found out that it works for a while, but in some moment it stops and I need to reload window (and it works again after that).
I do not know when "the moment" is. After couple of (or specific) pre-compiler errors, or.....

Considering that this is a hard to reproduce bug, there's not much we can do on our end. If we can get a consistent repro we can revisit this, but for now I will close the issue.


Swift 3.0 compatibility

Swift version 3.0-dev (LLVM 752e1430fc, Clang 3987718dae, Swift 36739f7b57)
XXX/Packages/C7-0.2.0/Sources/AsyncStream.swift:4:18: warning: extraneous duplicate parameter name; 'length' already has an argument label
    func receive(length length: Int, result: (Void throws -> Data) -> Void)
                 ^~~~~~~

XXX/Packages/C7-0.2.0/Sources/AsyncStream.swift:5:15: warning: extraneous duplicate parameter name; 'data' already has an argument label
    func send(data data: Data, result: (Void throws -> Void) -> Void)
              ^~~~~

XXX/Packages/C7-0.2.0/Sources/Data.swift:34:26: error: method 'replaceSubrange(subRange:with:)' has different argument names from those required by protocol 'RangeReplaceableCollection' ('replaceSubrange(_:with:)')
    public mutating func replaceSubrange<C : Collection where C.Iterator.Element == Byte>(subRange: Range<Int>, with newElements: C) {
                         ^
                                                                                _
Swift.RangeReplaceableCollection:16:26: note: requirement 'replaceSubrange(_:with:)' declared here
    public mutating func replaceSubrange<C : Collection where C.Iterator.Element == Iterator.Element>(_ subRange: Range<Self.Index>, with newElements: C)
                         ^
XXX/Packages/C7-0.2.0/Sources/Data.swift:34:26: error: method 'replaceSubrange(subRange:with:)' has different argument names from those required by protocol 'RangeReplaceableCollection' ('replaceSubrange(_:with:)')
    public mutating func replaceSubrange<C : Collection where C.Iterator.Element == Byte>(subRange: Range<Int>, with newElements: C) {
                         ^
                                                                                _
Swift.RangeReplaceableCollection:16:26: note: requirement 'replaceSubrange(_:with:)' declared here
    public mutating func replaceSubrange<C : Collection where C.Iterator.Element == Iterator.Element>(_ subRange: Range<Self.Index>, with newElements: C)
                         ^
<unknown>:0: error: build had 1 command failures

Changes will be merged today @rtsisyk. So expect C7 working and well later today in a new minor using Swift 04-12

Closed by https://github.com/open-swift/C7/commit/c37442c82d4adfb2dab2f5298b25fe2e7b497424


Bar on side of itemlist component

All of the item lists have a bar on the side which indents them, but when making items into buttons (like in a drawer) it looks really stupid. Could you possibly add the option of taking this out? I understand that it works fine for the standard white design, but if you use any other design and want to highlight buttons like the current route it just looks super awkward having that bar there.
You can fix it using margins but it would be better if you could just not have an unneccessary indent there with another option. Like
<ListItem  noIntent> .... </ListItem>

Even the indent is fine if it's also styled by the listitem, because it would mean the awkward bar of none-listitem color wouldn't be there.

Fix for this is to set items as itemDivider such as below
<ListItem itemDividier style={{backgroundColor: "#000000"}}>
....
</ListItem>

You can setup background color for each item and it spans the entire length of the actual list

Fixed with 2.4.4


Mas i1775 ttaaesafety

Bug fixes and improvements to TTAAE full-sync

https://github.com/basho/riak_test/compare/develop-3.0...mas-i1775-ttaaesafety

Not sure if this comment is entirely relevant but including it just in case.
As part of system tuning, it's recommended to set the disks to noatime mounts https://www.tiot.jp/riak-docs/riak/kv/2.2.6/using/performance/#mounts
I know the question in https://postriak.slack.com/archives/C6R0LPH4N/p1607107910139900 uses "last_modified_date" and that noatime is only relevent for "last accessed" but thought I should mention it in case there is any potential for people to  tune Riak and, in doing so, inadvertently break functions.

@Bob-The-Marauder - last modified time is the time on an individual object (which comes from the OS system time), and not related to times on files etc.  So this won't be an issue.


Invalid link in https://ribir.org/docs/get_started/quick_start#closure-and-fn_widget

Creating an application does not exist.

Thanks for the report!
The Creating an Application is renamed to Try Ribir.
I fixed the link in the next version of the documentation.


CONJUGATE Gradient

Issue Description
Task request
A new Gradient Based Optimizer needs to be implemented (Conjugate Gradient):
e.g. https://en.wikipedia.org/wiki/Conjugate_gradient_method

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[x] 1. Is it tagged with a type: defect or task?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[x] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

Closure checklist passed. Closure approved via PR #1045


Error on first download/dependency cache (API Timeout?)

I am working on adding a Dockerfile for development/hosting of bots using this template, and I ran into an issue.
[09:23 PM] => {"type":"requestManagerFetching","data":{"method":"get","url":"https://discord.com/api/v7/gateway/bot","retryCount":0}}
[09:23 PM] => {"type":"requestManagerFetched","data":{"method":"get","url":"https://discord.com/api/v7/gateway/bot","retryCount":0,"response":{"_bodySource":{},"_stream":null,"url":"https://discord.com/api/v7/gateway/bot","statusText":"Unauthorized","status":401,"headers":{},"redirected":false,"type":"default"}}}
[09:23 PM] => {"_bodySource":{},"_stream":null,"url":"https://discord.com/api/v7/gateway/bot","statusText":"Unauthorized","status":401,"headers":{},"redirected":false,"type":"default"}
[09:23 PM] => {"type":"requestManagerFailed","data":{"method":"get","url":"https://discord.com/api/v7/gateway/bot","retryCount":0}}

I believe that this might be an API timeout or something similar, as it doesn't happen if you rerun it with the majority of the modules already cached. The issue also occurs without docker; it is just less of a problem then.
Normally this would be okay, as you just run it again, and it will finish and start the bot. The problem is that docker only saves a layer if it is successful, which this is not and it completely erases and restarts the deno cache mod.ts layer.
I'm not sure whether this is an issue with the template or the main module, so I'll move it if this is wrong.

 Sorry for this 😭


send_packet failed

Hi, I want to scan IPv4 space with the udp module. But I fund the error.

I run zmap on vps of 2G memory.  I changed the kernel buffer. But it didn't work. What  is the root cause? Please help me.

The VPS likely has an IPsec configuration that is incompatible with ZMap, as it is attempting to create one socket per, see https://serverfault.com/questions/614453/no-buffer-space-available-on-connect.

@Changliting-letty What hosting provider are you using?

@Changliting-letty What hosting provider are you using?

Thank you for your help. It's  DMIT.

@dadrian  Hi,Have you tried to dump the DNS packets ? I tried to dump the DNS packet to pcap file.I found that this  will made a little influence on  the numer of open DNS resolvers.   Do you think this phenomenon is normal？   Is it possible to dump packets without affecting the number of ODNS?


chore: miscellaneous fixes and documentation updates

update German translation for media library folders
update some old links to staticcms.org
update documentation for Commit Message Templates and move from beta to configuration page (after prolonged usage, some testing and a look at the code I consider it as stable), will close #230
fix some method name on customization pages
fix example for media in custom previews
add example for media library usage in markdown shortcodes

@KaneFreeman Thank you for all the work :)
I heavily rely on Static CMS and I'm happy to contribute if I can.


NonDet handler throws storage assertion

Env and LocalEnv point to different Storages.
If you passed LocalEnv to a different thread and tried to create an unlifting function there, it's not allowed. You need to create it in the thread of the effect handler.
CallStack (from HasCallStack):
 error, called at src/Effectful/Dispatch/Dynamic.hs:1114:40 in effectful-core-<IP_ADDRESS>-1Y97Z0HsCQhKZtcRsL9K4V:Effectful.Dispatch.Dynamic
 requireMatchingStorages, called at src/Effectful/Dispatch/Dynamic.hs:750:3 in effectful-core-<IP_ADDRESS>-1Y97Z0HsCQhKZtcRsL9K4V:Effectful.Dispatch.Dynamic
 localSeqUnlift, called at src/Effectful/NonDet.hs:87:5 in effectful-core-<IP_ADDRESS>-1Y97Z0HsCQhKZtcRsL9K4V:Effectful.NonDet
 handler, called at src/Effectful/Dispatch/Dynamic.hs:461:77 in effectful-core-<IP_ADDRESS>-1Y97Z0HsCQhKZtcRsL9K4V:Effectful.Dispatch.Dynamic
 send, called at src/Effectful/Internal/Monad.hs:302:13 in effectful-core-<IP_ADDRESS>-1Y97Z0HsCQhKZtcRsL9K4V:Effectful.Internal.Monad

I don't have a small reproducer, but when trying to upgrade to 2.4 we see this error. It doesn't look like it's anything to do with our code, but rather something to do with NonDet. The unlifting function in question is created inside the handler of NonDet, and is then only called within that handler. But there is some shennanigans with backing up and restoring environments, perhaps that can trigger this?

Can you give me the code of your handler?

I'm not sure which bit you want? We're not handling NonDet, that's the handler defined in effectful that's throwing.

I'm not sure which bit you want? We're not handling NonDet, that's the handler defined in effectful that's throwing.

Right. That's what I get for reading stuff on my phone :sweat_smile:
Is this the same place #243 throws in? You mentioned there that the bug disappeared when you switched to NonDetKeep, but this is NonDetRollback. Did you switch back?

FWIW I think it's the same thing as #243, just manifesting earlier due to the new sanity check.

Btw, are you using interpose or impose anywhere?

Nope, we don't use either (well, we have one use of impose in CircuitHub, but not in this project or any of its deps)

You mentioned there that the bug disappeared when you switched to NonDetKeep, but this is NonDetRollback. Did you switch back?

No, it's in a different place where apparently I decided to use OnEmptyRollback for some reason... I can see if it goes away if we turn it into OnEmptyKeep, which I think will be safe.

Btw, the call stack from the first message is relatively useless because it ends inside the call to <|>. I added df06ee3834e7ef18f267e1877c86d7c1652e7340 which adds plusEff which if used instead of <|> will give useful call stack with the location in your code.
Is this problem at least reliably reproducible for you now that the new sanity check is in place?
If so, I'd like to see the surrounding code of the offending call site. Generally speaking I need to see something. I need a reproducer, doesn't have to be small, because so far me playing a playing a guessing game unfortunately hasn't got us anywhere near the solution. effectful gives much better call stacks now than before, but that's it :disappointed:
I'd like to get to the bottom of this because I find this problem concerning, but I can't do much if you don't show me any code.

Ok, I think I got a reproducer.
I did this:
diff --git a/effectful-core/src/Effectful/Internal/Monad.hs b/effectful-core/src/Effectful/Internal/Monad.hs
index 1ac5f79..d1822bb 100644
--- a/effectful-core/src/Effectful/Internal/Monad.hs
+++ b/effectful-core/src/Effectful/Internal/Monad.hs
@@ -553,6 +553,8 @@ send
   -> Eff es a
 send op = unsafeEff $ \es -> do
   Handler handlerEs handler <- getEnv es
+  when (envStorage handlerEs /= envStorage es) $ do
+    error "wtf"
   -- Prevent internal functions that rebind the effect handler from polluting
   -- its call stack by freezing it. Note that functions 'interpret',
   -- 'reinterpret', 'interpose' and 'impose' need to thaw it so that useful

And I'm getting wtfs in NonEmptyRollback tests. I'll have a look tomorrow.

Can you check #256? It should fix this.

Confirmed that this fixes it!

@arybczak Do you plan to release a minor version with this bug fix, or should we just run with HEAD?

You can run with HEAD for a moment, I plan to merge the overhaul of Effectful.Exception and release <IP_ADDRESS> in a week or so.


refactor: misc flake improvements

refactor(flake): rename utils to flake-utils
refactor(flake): make nix-eval-jobs's flake-utils follow ours

Thanks!


Android-Kotlin : 09.17 Top App Bar in Android (Kotlin)

Description 📜

Give a step-by-step tutorial of Top App Bar in Android (Kotlin).
Required Documentation or Video or Audio.

Domain of Contribution 📊

[x] Android Dev (Flutter, Java, Kotlin)

References :

https://github.com/material-components/material-components-android/blob/master/docs/components/TopAppBar.md

Please Read it Carefully Before Contributing

Changes should be made in Android_Development_With_Kotlin/ directory under Android_Development_With_Kotlin branch.
Inside Android_Development_With_Kotlin/ directory creates a directory and names it according to the topic ( for this issue 09. Dynamic User Interface)
Inside 09. Dynamic User Interface/ directory add your task with subtopic number and name and make changes accordingly.
You have to push your PR to the Android_Development_With_Kotlin branch only.
You can take help to the references but don't simply try to copy it. Just explain in your own word.
This issue is for GWOC'21 contributors only.
You need to push in a single commit. If there exists more than one commit then you need to squash your commits into one commit.
Will assign you on a first come first serve basis.
Please try to complete your assigned task within 7 days. If you need some more time then, please inform mentors and supervisors.
If you have two previously assigned issues on Android-Kotlin pending then please first complete them.

Supervisor @rahulsain

Happy Contributing. Best of Luck.💖

@rahulsain I would like to work on this issue. Please assign me


cmd/go: go get failed showing unrecognised import path

I am trying to build a websocket-based signaling server in Go called in Collider .
I followed the guide in github/webrtc/apprtc/collider
The command go get collidermain doesn't work and shows that:
package collidermain: unrecognized import path "collidermain"

I tried the methods others come up with in stack overflow but they didn't work.
Thanks in advance for you help.

This is something for the mailing list, but you probably need to run 'go get github.com/webrtc/apprtc/collider/collidermain'. The full url is required for go get to work.

Please ask questions on the mailing list<EMAIL_ADDRESS>not in the issue tracker.  Thanks.

use full path to do ln, eg.
ln -s /home/apprtc/src/collider/collider $GOPATH/src/
this will solve the issue.


Cross-version persistence tests

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

Add cross-version persistence tests. These tests pip install a pinned minimum version of chroma -> "0.3.20" and the latest version from pypi into separate directories. We then load into a separate python process the old version, add hypothesis generated data and persist it. Afterwards, in the main process, we use the local working copy of chroma, load the persisted data from an older version, and verify it matches the hypothesis generations.

Test plan
These are tests, however I did manually introduce a bug into my local copy of chroma and verified the tests caught the break in the invariants checking the current version for chroma.
Documentation Changes
None.

Could you post a snippet of the bug you introduced to test?

This is the bug introduced to test cross-version breakage


Rubocop-0.51.0 deprecated arguments format

Getting lots of these warnings with rubocop-0.51.0:
/myproject/vendor/bundle/ruby/2.2.0/gems/rubocop-thread_safety-0.3.3/lib/rubocop/cop/thread_safety/instance_variable_in_class_method.rb:24
Warning: The usage of positional location, message, and severity
parameters to Cop#add_offense is deprecated.
Please use keyword arguments instead.

The positional arguments version of Cop#add_offense will be removed in
RuboCop 0.52

Thanks for reporting this! I'll look into it soon.

Let me know if 0.3.4 doesn't resolve this for you.
Thanks!

Yep, looks good, thanks!


Flaky test: Upgrade tests-1.0.1

https://gubernator.k8s.io/build/istio-prow/pr-logs/pull/istio-releases_pipeline/294/release-upgrade-tests-1.0.1/321
It looks like the test is indicating success, but the job is failing.

> 4 <= 4.09048 , 4.04524 , 100.00, 3
# target 50% 0.0043878
# target 75% 0.00615641
# target 90% 0.00962549
# target 99% 0.04627
# target 99.9% 2.85771
Sockets used: 180 (for perfect keepalive, would be 32)
Code 200 : 4889 (97.9 %)
Code 503 : 103 (2.1 %)
Response Header Sizes : count 4992 avg 233.31691 +/- 33.97 min 0 max 241 sum 1164718
Response Body/Total Sizes : count 4992 avg 433.11238 +/- 35.68 min 175 max 441 sum 2162097
All done 4992 calls (plus 32 warmup) 15.151 ms avg, 10.0 qps
=== Errors found in internal traffic is within 85% threshold ===
# RUNNING popd
/home/prow/go/src/istio.io/istio
+ cleanup
+ [[ True == \T\r\u\e ]]
+ unsetup_clusters
+ PILOT_CLUSTER=gke_istio-boskos-79_us-west1-b_gke-020819-8w1c92cvwp
+ unset IFS

Compare to output from a healthy test:
Code  -1 : 22 (0.4 %)
Code 200 : 4932 (98.8 %)
Code 503 : 38 (0.8 %)
Response Header Sizes : count 4992 avg 236.05789 +/- 26.14 min 0 max 241 sum 1178401
Response Body/Total Sizes : count 4992 avg 435.16647 +/- 35.89 min 0 max 441 sum 2172351
All done 4992 calls (plus 32 warmup) 53.487 ms avg, 10.0 qps
=== Errors found in internal traffic is within 85% threshold ===
# RUNNING popd
/home/prow/go/src/istio.io/istio
SUCCESS
+ cleanup
+ [[ True == \T\r\u\e ]]

I also noticed that 1.0.1 and 1.0.2 tests panes in testgrid seems to be reporting same things:
https://k8s-testgrid.appspot.com/istio-release#upgrade-tests-1.0.1
https://k8s-testgrid.appspot.com/istio-release#upgrade-tests-1.0.2

More failures over the weekend.
https://gubernator.k8s.io/build/istio-prow/pr-logs/pull/istio-releases_pipeline/302/release-upgrade-tests-1.0.1/336
All done 4992 calls (plus 32 warmup) 276.119 ms avg, 10.0 qps
Succeeded.
=== Errors found in external traffic exceeded 85% threshold ===
Fortio 1.3.2-pre running at 10 queries per second, 2->2 procs, for 8m20s: http://echosrv.test.svc.cluster.local:8080/echo?size=200
10:16:54 I httprunner.go:82> Starting http test for http://echosrv.test.svc.cluster.local:8080/echo?size=200 with 32 threads at 10.0 qps
Starting at 10 qps with 32 thread(s) [gomax 2] for 8m20s : 156 calls each (total 4992)
10:17:56 I http_client.go:648> Closing dead sock

Since upgrade with the old installer is back - this become real P0, as well as extending it to cover other cases.

This has been green for quite a while, and a few changes related to it got merged in, so it seems this is resolved https://testgrid.k8s.io/istio_release-pipeline#upgrade-tests_pipeline


remove axis-chart's intermediate points

In the example chart there are intermediate points.
Site page: [http://docs.d2bjs.org/vue-d2b/#/]
Your points:
{x: 1, y: 25},
{x: 2, y: 38},
<...>

But the chart also displays point x: 1.5 and others.
This happens, the value of x points can be reduced to a number.
How can I remove these intermediate points?

You can accomplish this by specifying custom d3.axis tickValues Here is a fiddle example: https://jsfiddle.net/mabt8dv5/2/

Another option if you just want to specify how many ticks you want on the axis https://jsfiddle.net/mabt8dv5/3/


Update server.js

Codecov Report

Merging #12 (9e22639) into development (19a1b56) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development      #12   +/-   ##
============================================
  Coverage        47.22%   47.22%
============================================
  Files                1        1
  Lines               36       36
  Branches             5        5
============================================
  Hits                17       17
  Misses              15       15
  Partials             4        4

Impacted Files
Coverage Δ

server.js
47.22% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


remove unused %s in errors.Wrap

As title, %s here is not used.

Coverage remained the same at 95.0% when pulling 50828690e429489ecad074da693e38f19545acd7 on itchyny:fix-errors-wrap into 2d0d7368742069d6619605e1bd7b2b8e8c988fb2 on Songmu:master.


Crashed The Game

Hello, I'm currently making a modpack and just added mythic metals to it, everything was working for a short time then it crashed the game, I have the crash report, I'm still new to using mods and making packs so I don't fully know how to read these to figure out what the issue is sorry.
crash-2022-04-14_00.51.43-client.txt

This issue has been fixed in Alloy-Forgery 2.0.12, please update to this version


CSS/Form Render Issue & Authorization/Authentication

Cross-posts please close here:
https://github.com/StackStorm/st2web/issues/333
https://github.com/StackStorm/hubot-stackstorm/issues/128

Closing,
because there are 2 well-documented issues in st2web and hubot-stackstorm


Update tr-064 to 4.3.0

Please update my adapter ioBroker.tr-064 to version 4.3.0.
This pull request was created by https://www.iobroker.dev c0726ff.

RE-CHECK!


Investgate using DotNetty (Netty port)

Leaving this here as a reminder for later. https://github.com/Azure/DotNetty

I haven't explored this yet. My goal for a version 1.0 release of this library is to be fully compliant with RFC 7252. after that I will focus on performance improvements


DO NOT MERGE - NativeLayoutInfo, RuntimeMethodHandle

Exact method instantiations table, GVM tables.
Bug: unable to find exact method instantiation at runtime. hashcode issue?
Debugging hack
Parsing refactoring from PN.
Simple GVM test working (if exact method instantiation found)
Fixed native layout token placement bugs
Fixed issue with interface implementation on base Type
Added generic type instantiations hashtable
Fixed interface GVM entries
Fixed unplaced vertexes in native layout token nodes
Fixed and enabled GVM resolution tracing
API refactoring
Safe guard to avoid adding entries to hashtables after saving them
Conditional dependency analysis to enable GVMs on derived types.
Explicit interface implementations still not working (in progress).
Fix merge break
Fix build breaks after merge
New MethodLdtokenNode.
GVMs working on classes and structs.
Interface GVMs supported, with variance.
Unit test complete
Fix some merge issues.
Refactor some node names (NativeLayoutOffsetNode and NativeLayoutSignatureNode)
Refactoring based on CR feedback
cr

@fadimounir Is this still useful, or can it be closed?


Fix RayCast not updating when debugging collissions

Fixes #4224

What about the other collision shapes that you mentioned in https://github.com/godotengine/godot/issues/4224#issuecomment-205447885 ?

@akien-mga That was beyond my level when I checked. I will try again next week.

Thanks. Should we open an issue about it then?

Yes. I just opened it: #4260


Fusion Reactor won´t ignite

have built 2 different Reactors and loading up the Lasers to 2TRF and launch it with a button, but the reactor will not start. the reactor i built exactly the same as a different players with same settings and same fuel input. his will start everytime and mine will never start.
Glitch?

Did you put in a loaded Hohlraum?

Yes i did! everything is good, i have 12 Ultimate tank as backup for every fuel source and i let the lasers load up til 2 GRF

Unless it's changed, default requirement is 400 MJ. Also remember to set your injection rate prior to firing or you won't get a reaction.
You can set the minimum joules required to fire in the laser amp (400 000 000, 400 MJ remember) and walk away while it charges. Setting the min also acts as a failsafe to prevent you firing prematurely.

The Issue isnt that i dont let the amplifier be charged! it can only get so full! it dosent matter if its half full och fully! it will not ignite.

Like I said, check your setup. Make sure it's correct. Make a creative instance and test your setup and tweak it until it works. If other players are having no problems, then it must be your setup. Not setting the injection rate prior to detonation is a common mistake. Forgetting to put in a charge Hohlraum, also. Not igniting with 400 MJ, etc. Just experiment in a single player creative instance until you figure it out. There are plenty of tutorials and videos to use for research.
"This pen is not writing for me, but other people can write with their pens" leads to diagnostic questions. If your just going to reply "It's not the problem" then this treasure hunt is pointless. You'll have to figure it out on your own.

just build a exact copy in creative and it works like a charm! Wonder if its server issues?

I also can't get the reactor to ignite ever since the server I play on updated to 1.5.1. I did as you suggested and did the exact same thing in creative, and it works. There definitely seems to be a problem with multiplayer servers preventing ignition.

i have a solution now !
The Issue is to many output ports! just have 3 input for fuel and then check the "heat" tab it should say 300YRF then it will start, try adding output one at a time. if the "300" dissapears it wont start!

Post screenshots of your setup, this sounds entirely user error.

Mine works like a charm now!
it was an issue with output ports.
When i added ports the reactor lost its pre-heat and wouldnt start on ignition.
removed them ports and it works great

I am experiencing a similar anomaly. I have build plenty of reactors in the past (all on 1.7.10), however, now that I have switched to 1.10.2, I can't get my reactor to ignite. I have run through all of the steps mentioned above and even tried reducing the number of ports (though I don't know why that would work) to no avail. There is one difference that I have noticed, however. The heat gauge is displaying the heat in YK. I don't know if this is a change in the mod or a glitch. I would be grateful for any additional suggestions and would be glad to provide more information about my build if it would help.


⚠ Api has degraded performance

In e511946, Api (https://mesirve.app/api/client/v1/business) experienced degraded performance:

HTTP code: 200
Response time: 210 ms

Resolved: Api performance has improved in 9f976c1.


Code execution nice to have

closed because this only does javascript... to align with rubeshs nice to have it needs to be able to support different languages so relying on judge0/rapidapi


chore(deps): bump all deps

This also removes some unneeded dependencies from the BLS NIF

Blocked by https://github.com/rusterlium/rustler/issues/588


purplet build command

closes #10
closes #4

closes #10 btw

not ready to merge but at this point the build system is functional. probably want to make the following other adapters to prove the concept

[ ] express/middleware interaction handler
[ ] cloudflare workers
[ ] Bun.serve

also these notes:

[ ] fix AdapterData input resolving, putting purplet/path/to/file should resolve (internally we're using @rollup/plugin-url)
[ ] built in system for adding external packages, so we can move some stuff out of purplet/internal. like import "@purplet/rest" shouldn't cause a resolve error
[ ] adapter in config


m3u playlist file uses non-sanitized song names

System OS
Windows
Python Version
3.9 (CPython)
Install Source
pip / PyPi
Install version / commit hash
v3.7.1
Expected Behavior vs Actual Behavior
m3u file created with sanitized file names
it actually includes the ? etc. in the m3u file leading to errors
Steps to reproduce
spotdl https://open.spotify.com/playlist/6I39La6JYW1tVKM24Ro2py?si=9b7488ba63834868
Actual behaviour:

whereas lines 1 and 2 shouldn't have ? in filename
Traceback
N/A

Other details
No response

Fixed in 3.7.2


Please keep read_only and JSON for the Catalog around

Just a little feedback here: Facette looks fantastic and I'm very excited to roll it out once support for InfluxDB 0.9 makes it into a release.
I'm opening this issue just to raise awareness for a use case that unfortunately gets overlooked in a lot of similar software: config management.
We manage three datacenter locations and will be deploying Facette at each one. Even with templates, I don't want to worry about keeping the three instances in sync. We use BundleWrap to manage all our other configuration (backup, monitoring etc.) and it is pretty important to me that we can automatically add new hosts to Facette.
Currently, we can do that by setting read_only in the global config and then generate JSON files to put in /var/lib/facette. The UUID filenames make it a bit harder, but that's OK.
So I'm just hoping that you won't introduce changes that complicate this, like storing some data in an SQL database, as Grafana does. If you could even add documentation for the contents of the JSON files for graphs etc. that would be awesome, but I understand that it might be too much hassle.
Feel free to close this issue immediately, just wanted to let you guys know how we're using Facette. Keep up the great work :)

Just saw that #227 is basically about the same thing, closing.

Hi Torsten,
We do not plan to remove the read-only feature :smile:
That being said, we are looking and started to work on moving to a SQL-based backend. But the the other hand we plan to provide a way to dump/restore Facette's library through the facettectl utility.


If we have enough data, what will the model achieve for hard SQL?

We are afraid that the hard SQL like TABLE JOIN is the limit for industrial application.
Thank you very much.

I personally think the limitation is not only in the amount of data, but also how to correctly combine the database with the natural language, and how to generate SQL in real sense, instead of generate SQL word by word use LSTM, which is not in accordance with the way humans write code.


Double the Buffer Deposit value shown on the User's Profile

A user's total stream buffer for each of their parcels is made up of two parts:

The "virtual" amount that is deducted from their wallet's available ETHx balance
The ETHx that is explicitly transferred to the parcel smart contract to serve as it's buffer

The profile table currently only accounts for one-half of this total buffer. We need to double this calculation for each Buffer value in the table (as we did for the buffer calc in Transaction Summary within https://github.com/Geo-Web-Project/cadastre/pull/291).

Also as part of https://github.com/Geo-Web-Project/cadastre/pull/291, we discovered that there is a difference between the "theoretical" buffer and the actual collected due to bit clipping (https://github.com/superfluid-finance/protocol-monorepo/wiki/About-Real-Time-Balance). The diff is typically quite small (beyond the 8 decimal places that we show), so for performance reasons, we can continue to calculate the theoretical buffer rather than querying the actual value.


QoL dev improvements

See commit messages for details

bors r+

Seems like just fund takes quite a while; is there a way to make sure it only happens on first run?

I hear you.  The explicit recipe is just a convenience

another alternative would be to move the fund process to the background with &.
overall, I don't think it changes much in the picture compared to the generation of FRB, or actually rebuilding the app (on mac, this takes ages ;/)
feel free to define your own ones ;D
as for naming: I would prefer having all having it all, otherwise the name makes little sense.


Flaui 1.6.6r requires pythonnet>=2.5.2

Pythonnet released a new 3.0.0 which results in errors. Can you update release 1.6.6 to require exactly pythonnet 2.5.2 please?

Version 1.6.6 can't be used because it's pinned by this version. You have to upgrade to version 2.0.0 which is already uploaded by PyPi. Version 1.X is old 2.5.2 Python.Net usage and new major version 2.0.0 is Python.Net 3.0.

Edit Release does not work?

You can not redeploy any pypi packages from python and this is not intended by a clean release management. 1.6.6 only supports and is tested by Python.Net 2.5.2.
This major changes from library usages should be guarantee an consistent behavior usage by this library and automated tests and would break up any changes if i do that. So a major upgrade from 1.6.6 to 2.0.0 is needed and required to use the latest robotframework-flaui.
1.6.6 is an very old release version you should migrate to 1.7.3 or to 2.0.0.
Here is a fully list from all changes between 1.6.6 to 2.0.0
https://github.com/GDATASoftwareAG/robotframework-flaui/compare/1.6.6...2.0.0


Add appraisal gem

Summary:
Introduces Appraisal and updates activesupport to require version >= 4.2.2.
A description of Appraisal and it's purpose:

Appraisal integrates with bundler and rake to test your library against different versions of dependencies in repeatable scenarios called "appraisals." Appraisal is designed to make it easy to check for regressions in your library without interfering with day-to-day development using Bundler.

Version bump for ActiveSupport:
ActiveSupport version4.2.2 includes two important security vulnerability fixes. ActiveSupport 4.1.11 also includes the same vulnerability fixes. We could support 4.1.11 but since 4.2.2 has been available since June 16, 2015, it seems reasonable to increase the required version to 4.2.2 instead of spending additional time ensuring this library supports older versions.

@cbisnett @adimichele When you have time, I'd like your thoughts on dropping support for ActiveSupport  < 4.2.2.

Sounds good to me! Would love thoughts from @cbisnett though


Fix connection leaks on failed web socket upgrades.

Closes: https://github.com/square/okhttp/issues/4258

Given this fix, the forWebSocket instance variable is spurious now, yes?


Machete file syntax highlighting

For now, for simplicity all generated files are commited but in future Gradle Gramma-Kit plugin should be used.
Syntax parsing and highlighting was added.
Gramma-Kit IntelliJ plugin is used to generation of grammar and flex code (Machete.bnf and machete.flex files)
When running IntelliJ instance with loaded our plugin then PsiViewer IntelliJ plugin can be helpful to see parsing result on machete file

@micpiotrowski good job!
Pls list the recommended plugins in README.md under Development->Prerequisites (I guess Grammar-Kit and PsiViewer?)


Broken rendering in examples on intel graphics

Bevy version
v0.10.0
[Optional] Relevant system information
The system is a Dell XPS 13 7390 2-in-1 running windows.
2023-03-11T05:22:43.409198Z  INFO bevy_winit::system: Creating new window "Bevy App" (0v0)
2023-03-11T05:22:44.121756Z  INFO bevy_render::renderer: AdapterInfo { name: "Intel(R) Iris(R) Plus Graphics", vendor: 32902, device: 35410, device_type: IntegratedGpu, driver: "Intel Corporation", driver_info: "Intel driver", backend: Vulkan }
2023-03-11T05:22:45.181282Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "Windows 11 Home", kernel: "22621", cpu: "Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz", core_count: "4", memory: "7.8 GiB" }

What you did
Ran cargo run --example breakout.
Also occurs with other examples, and in release builds, but the breakout one seems to be the most interesting broken output.
What went wrong
The blocks, paddle, and ball don't render, but the score does. The game plays as normal, with score going up and with correct sound.
A few other examples i've tried only render a grey screen, but some seem to work

Additional Information
Possibly related to #6746 ? Am happy to try and debug on my end by running tools etc.
Additionally, a simple game I was testing/building on my own computer seems to render correctly

The same issue presents on my machine.
Running sprite and breakout on 0.9 looks normal, but on 0.10 everything I think is a sprite is just gone.
Game logic still seems to be fine, sounds play and the score counter increments.
In my own game project, egui-based menus are rendering fine, but sprites aren't, regardless of if they have textures or not.
HP Elitebook 840 G8
i5-1145G7
Intel Iris Xe Graphics

Some images for comparing 0.9 and 0.10 behaviour

Bevy 0.10 breakout: https://user-images.githubusercontent.com/4976122/224508322-50e96e0b-ff4f-4cff-8787-8c734383dbcf.PNG

Bevy 0.10 sprite: https://user-images.githubusercontent.com/4976122/224508323-2ad6d212-cc2a-48e6-b936-bc9e469d2a14.PNG

Bevy 0.9 breakout: https://user-images.githubusercontent.com/4976122/224508324-49cb497a-a327-4412-a9ca-8c11280da577.PNG

Bevy 0.10 sprite: https://user-images.githubusercontent.com/4976122/224508325-92dd6d56-7b8d-4676-a226-a72ad5e4055c.PNG

Played around with it more. Changing to the Dx12 backend via $Env:WGPU_BACKEND="dx12" fixes the breakout example, and gets visuals in all other examples I tested.
Sometimes they're a bit broken, though:
Odd shadows in shapes example

Should I report this upstream to wgpu?

Updating graphics drivers fixed the issue. Apologies.

I disagree with the closing of this issue. If something worked for a specific version of a graphics driver in 0.9, and it doesn't work in 0.10, that's a regression, and something that can bother players of our games that don't necessarily know how to update their drivers. If there was a way for bevy to work for these driver versions on 0.9, there will be a way for bevy to work for these driver versions on 0.10.

I also had this issue and I agree it shouldn't be closed for the same reasons @ZeeQyu states.
I narrowed the regression down to the commit bfd1d4b0a7731cf96e430d54397e7078e06c65e9 where it updates wgpu from 0.14.0 to 0.15.0
But the issue isn't with wgpu, as I can run wgpu's examples with no problems in both versions (using Vulkan backend).
Though I don't know why the commit breaks wgpu's rendering while using an older intel graphics driver.
After updating my graphics drivers, the problem was fixed.

Agree, I shouldn't have closed it
There's something very wrong with shadowing on the intel drivers, which perhaps is related. Even though the sprite base examples work, shadows don't in the vulkan backend in the 3d_shapes and shadow_biases examples. In the dx12 backend the shadows seem very corrupted
In 0.9.0, the shadows worked in the vulkan backend, but had the same corruption in dx12

I'm staying on old intel drivers to allow reproducing and testing fixes, I am here and ready to help if someone with a better understanding of the problem and the libraries than I have needs hardware.

Unlike @TheoDulka , on my computer there's a difference between wgpu versions.
In wgpu 0.14.2, the boids example is running with frame times of about 16.6 ms.
In wgpu 0.15.0, 0.15.1 and 0.15.2, the boids example is running with frame times of about 1.3 ms, 10 times faster. The boids are moving faster in a way that seems similar to the speedup.
Clearly, something that affects at least my computer changed between these releases, since the contents of the example folder is almost the same, and if I change them to be exactly the same, there is still the same difference in behaviour between versions.
Next step is probably creating a ticket at wgpu, and I will unless someone does it before me. For now I'll dump my testing results here, cause while it is still on the wrong repo, it's at least better here than locally on my computer.
wgpu 0.14.2 vs wgpu 0.15.1 examples comparison:

boids: 16.6 ms frametimes on 14.2, 1.3 ms framtimes on 0.15.1
bunnymark: Same frametime diff as in boids, both versions only have a blank fillcolor, and the icon in the screenshot does not appear in either version.
capture: Behaviour seems to be the same on both, example finishes without error, but no png is created.
conservative-raster: Same frame time diff as boids, otherwise the same.
cube: Same frame time diff.
hello: On 0.14.2, a bunch of adapter info is printed. On 0.15.1, there is no output.
hello-compute: Same output on both.
hello-triangle; Same red triangle on green background on both.
hello-windows: Same set of windows on both.
mipmap: 0.14.2 fails due to features "WRITE_TIMESTAMP_INSIDE_PASSES" not enabled on device. 0.15.1 works and looks like the included screenshot, although with 1.3ish ms frame times.
msaa-line: Same output, but same frame time diff.
shadow: 0.14.2 looks like the included screenshot. 0.15.1 is missing all the cubes and all the shadows.
skybox: Looks the same on both. Same frame time diff.
texture-arrays: Looks the same on both. Similar frame time diff, though 3ms instead of 1.3 ms
water: Looks the same on both, Similar frame time diff, though 3ms instead of 1.3 ms.

Just reproduced this on current bevy main d6e95e9570ed86e248d1e5f25d4f25d97977a1ab
Is probably a duplicate of https://github.com/bevyengine/bevy/issues/8395
Bisect pointed to upgrading to wgpu 0.15: https://github.com/bevyengine/bevy/issues/8395#issuecomment-1510054960

I have the same issue on bevy 0.11.3, but I didn't have it on bevy 0.9.1
SystemInfo { os: "Windows 10 Home", kernel: "19045", cpu: "11th Gen Intel(R) Core(TM) i5-11500 @ 2.70GHz", core_count: "6", memory: "31.8 GiB" }
AdapterInfo { name: "Intel(R) UHD Graphics 750", vendor: 32902, device: 19594, device_type: IntegratedGpu, driver: "Intel Corporation", driver_info: "Intel driver", backend: Vulkan }

I am using Intel Arc a750 gpu, driver <IP_ADDRESS>52 (2023/10/31), and this problem still exists.

I believe this should be fixed in bevy 0.13. Could people with intel GPUs effected by this test to see if it's fixed?

Tried it on the same machine I mentioned above. 0.9.0 works, 0.10.0 is broken, 0.12.0 is broken, 0.13.0 works. Since I retested the 0.9.0 and 0.10.0 it seems unlikely I've had any driver updates that could invalidate the result.
So yes, it strongly looks like 0.12->0.13 fixed the issue, at least for my specific hardware!

(To be specific, I only tested the breakout example.)


Add documentation to test component with behaviors and POROs as input

What are you trying to accomplish?
Currently in the docs there's a handy way to test component with behaviors leveraging the previews through system specs. This method works well for components without arguments or taking simple inputs such as strings and numbers.
If we want to test components taking ActiveRecord objects as input, we can pass the IDs in the URL and then find those records in the preview, but this causes tight coupling between the specs and the preview class, forcing developers to tweak multiple files at a time.
However, this method breaks if we want to pass in POROs, or other generic objects in these preview URLs.
Here's an example of how I implemented a rough solution to this problem using RSpec and Capybara:
class OrderSummaryComponent < ApplicationComponent
  def initialize(order:)
    @order = order
  end
end

class OrderSummaryComponentPreview < ApplicationPreview
  # The default preview is not needed to make this work, we can have a empty class as well
  def default
    render(OrderSummaryComponent.new(order: Order.complete.last))
  end
end

module Helpers
  module ViewComponentSystemSpecHelpers
    def with_spec_preview(&preview_proc)
      preview_class.define_method(:spec, &preview_proc)
    end
  end
end

RSpec.describe OrderSummaryComponent do
  it 'is expandable by clicking on the button' do
    order = create(:order)
    # not saving the record intentionally to prove we display non-persisted data
    order.shipment_total = 24
    with_spec_preview do
      render(described_class.new(order: order))
    end
    visit "/rails/view_components/#{described_class.to_s.underscore}/spec"

    expect(page).to have_text("Order Summary")
    expect(page).not_to have_text("Shipping: $24.00")

    click_button "Order Summary"

    expect(page).to have_text("Shipping: $24.00")
  end
end

What approach did you choose and why?
For now I'm adding this as documentation. I'll try to submit other commits or a different PR to implement such a test helper if the team feels is useful.
Anything you want to highlight for special attention from reviewers?

@joelhawksley closing this. Thanks for your feedback!


Eureka server unavailable-replicas issue

Describe the bug
Please provide details of the problem, including the version of Spring Cloud that you
are using.
Spring boot : 2.2.2.RESLEASE
Srping cloud : Hoxton.SR1
Anyone can help me? I am running 2 Eureka Servers, all servers are up, but the Eureka Server's Dashboard displaying the replicas in the unavailable-replicas section.  I don't know, why replicas displaying in the unavailable-replicas section?
my eureka server1 application.yml
server:
port: 7001
eureka:
instance:
hostname: eureka7001.com
client:
fetch-registry: false
register-with-eureka: false
service-url:
defaulZone: http://eureka7002.com:7002/eureka/
my eureka server2 application.yml
server:
port: 7002
eureka:
instance:
hostname: eureka7002.com
client:
fetch-registry: false
register-with-eureka: false
service-url:
defaulZone: http://eureka7001.com:7001/eureka/
My hosts file (windows)
<IP_ADDRESS>  eureka7001.com
<IP_ADDRESS>  eureka7002.com
Thanks

Please learn how to properly format code and logs.
why do you have register-with-eureka: false and fetch-registry: false?

Please learn how to properly format code and logs.
why do you have register-with-eureka: false and fetch-registry: false?

Thanks for your reply.
I am try update the value of fetch-registry to true, but the STS‘ s console will have the error :

com.sun.jersey.api.client.ClientHandlerException: java.net.ConnectException: Connection refused: connect

I already config the hostname and port for the eureka server, Why it's the default endpoint?

BTW, should i set the value of register-with-eureka is true?  it means  the eureka server register  itself?

my eureka server1 main class
@SpringBootApplication
@EnableEurekaServer
public class EurekaServer {

	public static void main(String[] args) {
		SpringApplication.run(EurekaServer.class, args);
	}
}

my eureka server2 main class
@SpringBootApplication
@EnableEurekaServer
public class EurekaServer2 {

	public static void main(String[] args) {
		SpringApplication.run(EurekaServer2.class, args);
	}
}

my eureka server1 pom
<dependencies>
		<dependency>
			<groupId>org.springframework.cloud</groupId>
			<artifactId>spring-cloud-starter-netflix-eureka-server</artifactId>
		</dependency>
		<dependency>
			<groupId>org.springframework.boot</groupId>
			<artifactId>spring-boot-starter-web</artifactId>
		</dependency>
        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-actuator</artifactId>
        </dependency>
		<dependency>
			<groupId>junit</groupId>
			<artifactId>junit</artifactId>
			<scope>test</scope>
		</dependency>
	</dependencies>

my eureka server2 pom
   <dependencies>
   	<dependency>
   		<groupId>org.springframework.cloud</groupId>
   		<artifactId>spring-cloud-starter-netflix-eureka-server</artifactId>
   	</dependency>
   	<dependency>
   		<groupId>org.springframework.boot</groupId>
   		<artifactId>spring-boot-starter-web</artifactId>
   	</dependency>
   	<dependency>
   		<groupId>org.springframework.boot</groupId>
   		<artifactId>spring-boot-starter-actuator</artifactId>
   	</dependency>
   	<dependency>
   		<groupId>junit</groupId>
   		<artifactId>junit</artifactId>
   		<scope>test</scope>
   	</dependency>

   </dependencies>

When i run the  eureka server, the console of STS will show these logs:
2020-04-28 11:35:40.650  INFO 2372 --- [           main] c.n.eureka.DefaultEurekaServerContext    : Initializing ...
2020-04-28 11:35:40.652  INFO 2372 --- [           main] c.n.eureka.cluster.PeerEurekaNodes       : Adding new peer nodes [http://localhost:8761/eureka/]
2020-04-28 11:35:41.119  INFO 2372 --- [           main] c.n.d.provider.DiscoveryJerseyProvider   : Using JSON encoding codec LegacyJacksonJson
2020-04-28 11:35:41.119  INFO 2372 --- [           main] c.n.d.provider.DiscoveryJerseyProvider   : Using JSON decoding codec LegacyJacksonJson
2020-04-28 11:35:41.119  INFO 2372 --- [           main] c.n.d.provider.DiscoveryJerseyProvider   : Using XML encoding codec XStreamXml
2020-04-28 11:35:41.119  INFO 2372 --- [           main] c.n.d.provider.DiscoveryJerseyProvider   : Using XML decoding codec XStreamXml
2020-04-28 11:35:41.234  INFO 2372 --- [           main] c.n.eureka.cluster.PeerEurekaNodes       : Replica node URL:  http://localhost:8761/eureka/

I am already modify the defaultZone  such as my eureka server1 application.yml , i don't konw why the replica node is the default endpoint.

Please learn how to properly format code and logs.
why do you have register-with-eureka: false and fetch-registry: false?

It's my spelling mistake. it should be defaultZone in the applycation.yml file, not be defaulZone. Thank you very much.


fix #198 str_replace() expects at least 3 parameters, 2 given

fix #198

Also fix #203

Solve problem 'Undefined index: cause' en Entity.php
https://github.com/pablorsk/dx-php/commit/63f342cc320e01844a38dffd8a1f7a895bd6bfa1


Bio Weekly - Table 2 Updates

Please make the following edits to Table 2.

Remove the middle column ("No Blood Collections but had an Appointment")
Update table title (see mock-up below)
Update column title (see mock-up below)

Requestor(s): Biospecimen Team
Table or Figure title: Table 2: Baseline Blood Collection Status Among Baseline Collections by Site
Metrics to be updated or created: Update Table 2
Variables needed (include variable name and Concept ID):

BioRec_CollectFinal_v1r0 (410912345)
BioFin_BaseBloodCol_v1r0 (878865966)
RcrtES_Site_v1r0 (214456996)

Specify numerator and denominator by variable name where applicable:

Denominator = participants with finalized collection (410912345 = 1)
Numerator = any baseline blood collected (878865966 = 1); no baseline blood collected (878865966 = 0)

Mock-up table if applicable:

Notes: N/A
Approved by: Domonique

@KELSEYDOWLING7 Looks good, thank you. This table update can go into the next weekly report (8/21).


No PMKIDs received

I am not able to capture correctly, only receive EAPOL return will be that the nearby routers do not transmit the keys
07:33:48  10 8cf71074495c b0be76d1f37c G3 [EAPOL:M3M4ZEROED EAPOLTIME:1270 RC:2 KDV:2]
07:35:41  10 6432a81c4440 b0be76d1f37c G3 [EAPOL:M1M2 EAPOLTIME:2035 RC:1 KDV:2]
07:35:41  10 6432a81c4440 b0be76d1f37c G3 [EAPOL:M2M3 EAPOLTIME:2458 RC:2 KDV:2]
07:36:22   6 b499baf97863 e01954e0bf46 G1 [EAPOL:M1M2 EAPOLTIME:19056 RC:1 KDV:2]
07:36:22   6 b499baf97863 e01954e0bf46 G1 [EAPOL:M2M3 EAPOLTIME:13381 RC:2 KDV:2]
07:37:19   6 b499baf97863 e01954e0bf46 G******* 1 [EAPOL:M1M2 EAPOLTIME:13512 RC:1 KDV:2]
07:37:19   6 b499baf97863 e01954e0bf46 G*******1 [EAPOL:M2M3 EAPOLTIME:60 RC:2 KDV:2]
07:37:33  10 6432a81c4440 b0be76d1f37c G3 [EAPOL:M1M2 EAPOLTIME:1947 RC:1 KDV:2]
07:37:38  11 e85a8b27b8b6 b0be76d1f37c G********3 [EAPOL:M1M2ROGUE EAPOLTIME:3169 RC:61939 KDV:2]

└─# sudo hcxdumptool -i wlan0 --check_driver
initialization...
starting driver test...
driver tests passed...
all required ioctl() system calls are supported by driver
terminating...

└─# sudo hcxdumptool -i wlan0 --check_injection                                                                 1 ⨯
initialization...
starting antenna test and packet injection test (that can take up to two minutes)...
available channels: 1,2,3,4,5,6,7,8,9,10,11,12,13,14
packet injection is working on 2.4GHz!
injection ratio: 7% (BEACON: 90 PROBERESPONSE: 7)
your injection ratio is poor - improve your equipment and/or get closer to the target
antenna ratio: 100% (NETWORK: 2 PROBERESPONSE: 2)
your antenna ratio is huge - say kids what time is it?
terminating...

I'm not sure what you mean with "nearby routers do not transmit the keys".
If you mean PMKID:
The ACCESS POINTs in range don't transmit a PMKID. In that case you will not receive only M1 and M3 EAPOL frames from them.
In addition you will recevie M2 and M4 EAPOL frames from connected CLIENTs and M2 EAPOL frames from not connected CLIENTs.
That is not an hcxdumptool issue.

I recommend to read som background information about 802.11i, 802.11r and OKC:
https://en.wikipedia.org/wiki/IEEE_802.11r-2008
https://community.arubanetworks.com/community-home/digestviewer/viewthread?MID=4386
https://documentation.meraki.com/MR/Other_Topics/PMKID_Vulnerability_FAQ_-_WPA%2F%2FWPA2-PSK_and_802.11r

that's right, that's what I meant, that the nearby routers didn't transmit PMKID
so most likely my settings are correct,
I will read the websites you indicated, thank you very much for your attention

BTW:
Your injection ratio is fantastic and the response time (e.g.: EAPOLTIME:60) is pretty good.
There are many older routers. Usually they don't transmit PMKIDs.
On some newer routers, PMKID caching is disabled. So they also don't transmit a PMKID.
But I noticed that a CLIENT tried to connect to hcxdumptool:
07:37:38 11 e85a8b27b8b6 b0be76d1f37c G********3 [EAPOL:M1M2ROGUE EAPOLTIME:3169 RC:61939 KDV:2]
Maybe this CLIENT will transmit the PSK. In that case, hcxpcapngtool -E will extract the key.
An example is here:
https://github.com/evilsocket/pwnagotchi/issues/835#issuecomment-598597214

Closed this issue report, because we are not able to force an AP to transmit a PMKID if this feature is not implemented in its firmware or if it is deactived by default / by user, but you can still ask your questions here
or here:
https://hashcat.net/forum/thread-6661.html


AKV private endpoint still in preview?

[Enter feedback here]
The screenshots in this page still have "preview" but I think it's GA already.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 191d0067-67ee-212d-77f6-ffb1db64582f
Version Independent ID: 71d5a250-17e6-8500-b6a3-3c46401a255c
Content: Integrate with Azure Private Link Service
Content Source: articles/key-vault/general/private-link-service.md
Service: key-vault
Sub-service: general
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@kamsumlee-ms  Thank you for your feedback . We will investigate and update the thread further.

@kamsumlee-ms Yes, Azure Portal doesn't show it under preview any more. I will assign it to the author to update the screenshots.

Thank you @kamsumlee-ms. We have updated the screenshots. #please-close

Please update announcement with General Availability statement here - https://azure.microsoft.com/en-us/updates/key-vault-private-endpoint/ Thanks.


Added missing_values_found rule

Everything should be straightforward. I added a new how-to, finding the mandatory columns for a table.

Hmm. We may need a conversation on this one, and I may need to correct or clarify what I've said before. I am going to add @mathew-thomson, @il43 and @jeandavidt to this PR.
The most common scenario for missing data is that the user will forget or omit to include a value for a mandatory field. This means the most common missing data will be ``. What may also be common is NA.
The missingness set will likely be used during database management or by analysts during the data cleaning process when they receive data from a data creator. In this situation, someone cleaning the data will coerce `` to one of the missingness values, such as nr "A value could have been recorded, however, it was not."
I don't think we need a part for an empty field, but we need a validation rule.
What this means for this rule is that we need to check there isn't a blank entry AND that the entry isn't one of the missingness values in the missingness list. In practical terms, we need to use both the Cereberus 'nullable' and also 'forbidden'.

As an aside, we may want (or will probably want) to create a process to clean data. It occurred to me that this data cleaning is part of the Cereberus package in the 'coerse' function. We'd probably want this as a separate function and Cereberus schema. Not sure.
An example of the course or data clean function would be to mutate mandatory fields that have `` to nr. There would be a report and mutated data would be returned.

@DougManuel I've updated this spec based on our talk yesterday. Can you take a look?

@DougManuel I've updated the PR


Update release.yaml

Integrate per-chart changelog generation

Sounds very nice. What has been your approach to testing this? Is there a way to preview what the result will be?

Sorry, wanted to add pull request in forked repository but ended up here

I'm testing it in a fork but it's hard since fork has no releases/tag.
You can check it out here: https://github.com/sudocovik/minecraft-server-charts


Subscriptions are ignored when running app via  tag

Relevant code https://github.com/hyperapp/hyperapp/blob/master/app.js#L81.
Ping @dodekeract.
Resources

http://stackoverflow.com/questions/16643232/how-to-know-if-document-has-loaded

Something like this would do.
	ready(function () {
		for (var sub in subs) {
			subs[sub](model, msg, hooks.onError)
		}
	})

	function ready(cb) {
		document.readyState === "complete"
			? cb()
			: document.addEventListener("DOMContentLoaded", cb)
	}

@dodekeract Is there any reason why we can't just treat "render app()" as the first sub?

Interesting question. That way you wouldn't even need to detect DOMContentLoaded yourself.

I think it's not the right thing to do, because that smells like magic.

Document ready, etc. Ugh! It's complicated. Here's what I came up with to deal with the mess. Handles situations where the document is already ready for different browsers since they can't decide on how to let us now this so unimportant and insignificant condition ;-P:
function ready(callback) {
  const readyRE = /complete|loaded|interactive/;

  if (readyRE.test(document.readyState) && document.body) {
    callback.call(callback);
  } else {
    document.addEventListener("DOMContentLoaded", function() {
      return callback.call(callback);
    });
  }
}

I don't think it should be in the app/framework side. I believe it would be better to expose .start method or just such. So user will "start" the app when he want. That's why I exposed .start() in gibon router - before calling start it does not listen on any events.

I agree with @tunnckoCore. Instead of a clunky .start() method, however, you already have a function, app, which you can call when you are ready.
Thanks @rbiggs! I'm almost done implementing this.
I'll push in a while with a few other minor improvements.

@tunnckoCore Having a .start() method would just lead to my initial question once again. Which event should that be attached to so that subs don't break?

Hi @dodekeract, this is now fixed in the master branch. Subscriptions (not subs anymore) will work even when you run app(...) inside DOMContentLoaded.
See https://github.com/hyperapp/hyperapp/blob/master/app.js#L8

@jbucaran thanks, will open another issue if it doesn't work, but looks good.

@dodekeract Thanks, I'll keep this open. Test it out and please close when, and if, the previous behavior is fixed.

@jbucaran I can still reproduce this when using yarn add<EMAIL_ADDRESS>node_modules/hyperapp/app.js also seems to be the current version.

@dodekeract You're using the wrong bundle in broken.html, it should be bundle.onload.js.

Not broken.html
Not broken.root.html

@dodekeract

@jbucaran Of course I'm using index.js in both index.html and broken.html. That's why one is called broken, because it doesn't reliably work with the normal way to include hyperapp.
Only thing I'll change is that onload.html should actually have the script in the head, but that doesn't make any difference.
index.js -> index.html + broken.html
index.root.js -> broken.root.html
index.onload.js -> onload.html

@dodekeract Why?

@jbucaran Because the repo demonstrates the different ways to include hyperapp and every html called broken is a demo of a way that doesn't work?

In that case, the title of this issue is misleading. Subscriptions now work when running the app via <head>.

@jbucaran It still crashes in both broken.html and broken.root.html.

@dodekeract Are you using window.addEventListener("load") or document.addEventListener("DOMContentLoaded") to run the app?

@jbucaran In onload.html I'm using that, yes. That's the point of having multiple slightly different files.
Is it required now to use window.addEventListener to make this work?

@dodekeract We now understand each other.
At the moment, yes, it's required because when embedding hyperapp in the <head>, hyperapp's render/patch functions will fail.
The question is, should we make hyperapp aware of this out of the box?
@tunnckoCore @terkelg @tzellman

@jbucaran No matter what the decision is, the behavior should be documented. 🙂

@jbucaran Issue can be closed then. I'd suggest to open a new one with docs/question if this should work without window.addEventListener or not.

@dodekeract That sounds like the right thing to do. Can you take care of opening it?


net/http, x/net/http2: update RFC numbers used as normative references

The documentation in x/net/http and x/net/http2 packages still contains the obsolete RFC 2616 as a normative reference. I think it's better to replace the reference to RFC 2616 with a series of RFCs 7230 through 7235 for avoiding unnecessary confusion.
When we see some inconsistency, for example, RFC 2616 vs. RFC 723x, in the current implementation, that should be addressed as another issue. So this should be a documentation issue.

Here are the inconsistencies with RFC-7230 i have found in net/http so far:
The handling of "hop-by-hop" Headers is defined differently:

Exactly when "close" connection options have to be sent has been
clarified.  Also, "hop-by-hop" header fields are required to appear
in the Connection header field; just because they're defined as hop-
by-hop in this specification doesn't exempt them.  (Section 6.1)

However the current behavior has to be kept to maintain compatibility.
Other than that RFC 7230 defines more forbidden trailer headers for chunked transfers (see section 4.1.2) than currently implemented.
Note that i only looked in the places where rfc 2616 was referenced explicitly , so its hard to tell if there are other non obvious inconsistencies.

Is there a convention for referring to RFCs?

There's no convention, but the document should look like a document, not a side note writing to the back of a paper napkin.  I'm fine with either RFC NNNN, the section X of RFC NNN or URL.

I uploaded a first patch with the documentation changes. It includes todos for inconsistencies.
However, i think these inconsistencies should be cleared up first, before the documentation change is submitted.

Thanks for tackling this issue.

these inconsistencies should be cleared up first

Please open a new issue for shooting such inconsistencies, for getting more eyeballs. I think that leaving TODOs and issues is fine for now because the transition from H1 to H2 is a bit complicated work and probably takes a bit long time.

I have created an issue for the incorrect handling of Trailer headers : #23908
The handling of relative Location URIs in Redirect responses seem to be okay, but could use some addittional tests to ensure that fragments ar not thrown away. However im not sure if path.Clean should be called for absolute urls too. I will open another issue for discussion (or at least for additional tests) on this too.


Update Dyn info to show they support TFA, and link to the docs

Dyn now supports TFA, and I updated their info accordingly

seems like they also support SMS.

Oh whoops I didn't realize there was a separate variable for sms. I'll update the commit.


devpreview tags for year 2018

In year 2017 naming convention for devpreview was microsoft/dynamics-nav:devpreview--
What is naming convention for year 2018 as month names are starting to get duplicated?
Thank you!

We will probably only have one or two public preview builds, then Tenerife will be released and will be available.
After this, preview bits will be available through MS Collaborate from a private repository.
and... - even if we would run into name clashes, the new would just overwrite the old.

So what is the name of latest devpreview release image?

it is always microsoft/dynamics-nav:devpreview

What  about naming with month number ? microsoft/dynamics-nav:devpreview-january is unavailable

Because it has not been created yet.
you can specify a specific tag to get an older image.
newest will always be what I wrote.


[Bug] Cannot install 4.12.2 on ruby:3.0.0-alpine

Description
I can't install the latest appoptics_apm gem on ruby 3 alpine image.
How to reproduce or use case
$ bundle install # Gemfile includes appoptics_apm
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

current directory:
/vendor/ruby/3.0.0/gems/appoptics_apm-4.12.2/ext/oboe_metal
/usr/local/bin/ruby -I /usr/local/lib/ruby/3.0.0 -r
./siteconf20210325-1-7tva1e.rb extconf.rb
checking for oboe_config_get_revision() in -loboe... yes
creating Makefile

current directory: /vendor/ruby/3.0.0/gems/appoptics_apm-4.12.2/ext/oboe_metal
make "DESTDIR=" clean

current directory: /vendor/ruby/3.0.0/gems/appoptics_apm-4.12.2/ext/oboe_metal
make "DESTDIR="
compiling src/init_appoptics_apm.cc
compiling src/oboe_api.cpp
compiling src/oboe_swig_wrap.cc
In file included from /usr/local/include/ruby-3.0.0/ruby/ruby.h:39,
                 from /usr/local/include/ruby-3.0.0/ruby.h:38,
                 from src/oboe_swig_wrap.cc:880:
/usr/local/include/ruby-3.0.0/ruby/internal/memory.h:275:16: error: conflicting
declaration of 'void* ruby_nonempty_memcpy(void*, const void*, size_t)' with 'C'
linkage
  275 | #define memcpy ruby_nonempty_memcpy
      |                ^~~~~~~~~~~~~~~~~~~~
/usr/local/include/ruby-3.0.0/ruby/internal/memory.h:265:1: note: previous
declaration with 'C++' linkage
  265 | ruby_nonempty_memcpy(void *dest, const void *src, size_t n)
      | ^~~~~~~~~~~~~~~~~~~~
make: *** [Makefile:213: oboe_swig_wrap.o] Error 1

make failed, exit code 2

Gem files will remain installed in /vendor/ruby/3.0.0/gems/appoptics_apm-4.12.2
for inspection.
Results logged to
/vendor/ruby/3.0.0/extensions/x86_64-linux-musl/3.0.0/appoptics_apm-4.12.2/gem_make.out

An error occurred while installing appoptics_apm (4.12.2), and Bundler cannot
continue.
Make sure that `gem install appoptics_apm -v '4.12.2' --source
'https://rubygems.org/'` succeeds before bundling.

In Gemfile:
  appoptics_apm

OS, Ruby version, Gemfile, Gemfile.lock, log message ... (if relevant)
OS: ruby:3.0.0-alpine (Docker image)
Ruby version: 3.0.0p0
appoptics_apm: 4.12.2

this is a tricky one, only happens with Ruby 3 on alpine
I can fix it by modifying the ruby memory.h file, haven't found anything in the code of the appoptics_gem that would fix it
Need to see if there is another solution before I file a bug with Ruby, because it is very specific for alpine

Filed an issue with Ruby https://bugs.ruby-lang.org/issues/17788

@aliismayilov
The Ruby team provided a patch https://bugs.ruby-lang.org/attachments/8821
Does that work for you?
I hope they will fix the code for the next release

closing - thanks for your help @aliismayilov