checkboxes should return JSON true/false

in the case of false (unchecked) it doesn't need to return anything as if(variable) will have the same behavior with null as with false. the 'false' case works. the 'true' case doesn't work.

will return
"exemption": {
	"enabled": "true"
},

where as it should return
"exemption": {
	"enabled": true
},

code fix:
case 'checkbox':
if (fieldNode.checked){
if(fieldNode.value === "true"){return true;}
return fieldNode.value;
}
break;
in function: 	function getFieldValue(fieldNode)

sorry, i'm still a git noob, so i didn't fork / pull-req

Fixed with 985a3f3214303e2c51d032590ec0b9fb15e51b63

I think that your code would be greatly simplified if it used jquery... pulling all of the objects with a name field is 1 line of code.
some of the code i wrote for my js2form implementation could be used to simplify transforming field names into objects and putting values in them.
it's not a big deal for me, though, because i'm using templates for this type of stuff now.


Linking libraries to ejected project

Hi, I'm trying to link libraries like react-native-billing and react-native-fcm to ejected project. I'm getting the following error:
test/node_modules/react-native-billing/android/src/main/java/com/idehub/Billing/InAppBillingBridge.java:410: error: method does not override or implement a method from a supertype
  @Override
   ^

InAppBillingBridge class looks like that:
public class InAppBillingBridge extends ReactContextBaseJavaModule {
...
    @Override  <- this is the method that causes the error
   public void onNewIntent(Intent intent){
...

This should work on react-native >0.30, Is it possible https://github.com/expo/react-native/archive/sdk-15.0.0.tar.gz was not updated?

Can you please open a new issue and fill out the issue template with information about what exact steps you took to get there and the version information? Thanks!

Sure, sorry.


Admin Dashboard Configs

@shankari Admin dashboard configs have been added to the stage configs.

@swastis10 FYI


evdi 1.8 module not loading in 5.4 kernel?

Initially please make sure the problem hasn't been already addressed:

[X] Are you using the latest driver? YES
(https://www.displaylink.com/downloads/ubuntu)
[X] Are you using the latest EVDI version? YES
(https://github.com/DisplayLink/evdi/releases)
[X] If you are using a DisplayLink device, have you checked 'troubleshooting'
on DisplayLink's website? YES
(https://support.displaylink.com/knowledgebase/topics/103927-troubleshooting-ubuntu)
[X] Is this issue related to evdi/kernel? YES
(if it is rather connected to DisplayLinkManager please take a look at support
https://support.displaylink.com or forum https://www.displaylink.org/forum/)

Some information for baseline would help a lot:

Linux distribution and its version: archlinux
Linux kernel version: 5.4.57-1-lts
Xorg version (if used): 1.20.8
Desktop environment in use: (i3)

$ dmesg | grep -i evdi
[   11.340401] evdi: loading out-of-tree module taints kernel.
[   11.340463] evdi: module verification failed: signature and/or required key missing - tainting kernel
[   11.342528] evdi: [I] Initialising logging on level 5
[   11.342529] evdi: [I] Atomic driver:yes

Is this something that should be adressed from evdi-side, or something that I should solve specifically on my machine?
There are some comments on archlinux-AUR-evdi page on this.
Cheers,
Dan

It looks like it is loading.  The message you are quoting is just an informational message that we all get when running evdi.
Run this lsmod | grep evdi.  You should see that the evdi module running.
For example:
evdi                   65536  4
drm_kms_helper        249856  3 evdi,amdgpu,i915
drm                   618496  19 gpu_sched,drm_kms_helper,evdi,amdgpu,i915,ttm

I believe that in order to use evdi 1.8.0, we are waiting on a new release of the DisplayLink driver (https://www.displaylink.com/downloads/ubuntu).

Ok, thank you. You're right about loading.
I will switch back to 1.7.0 and wait for the next release of the displaylink driver.

Any information about release date?

New release date?

Don't want to be rude, but some people are required to use this piece of... software. To make USB-C in any kind a useable standard we NEED working software as a minimun.

Hi guys, any news ?

The DLM on the website (5.3.1) should be working with kernel 5.4, it actually should be compatible with kernel 5.6.
As in the description - EVDI module is loaded.
@technoo10201, what is the problem you are seeing? Can you show dmesg | grep evdi and DLM logs?
/var/log/displaylink/DisplayLinkManager.log

The DLM on the website (5.3.1) contains EVDI v1.7.0 which should be working up to kernel 5.8 (included).
5.9 will indeed need some modifications, but we are currently on v5.9-rc6 so we have around 2 weeks before v5.9 will actually happen. At the moment there is no need to upgrade EVDI to 1.8.0 for DLM :)

The DLM on the website (5.3.1) contains EVDI v1.7.0 which should be working up to kernel 5.8 (included).
5.9 will indeed need some modifications, but we are currently on v5.9-rc6 so we have around 2 weeks before v5.9 will actually happen. At the moment there is no need to upgrade EVDI to 1.8.0 for DLM :)

Hi ! Thanks for your fast reply, i appreciate. I'm trying to install DLM 5.3.1 but i have this error message :
' sudo LANG=C ./displaylink-driver-<IP_ADDRESS>.run
Verifying archive integrity...  100%   All good.
Uncompressing DisplayLink Linux Driver <IP_ADDRESS>  100%
DisplayLink Linux Software <IP_ADDRESS> install script called:
Distribution discovered: "Manjaro Linux"
Unsatisfied dependencies. Missing component: libdrm.
This is a fatal error, cannot install DisplayLink Linux Software.
'
Do you have a work around to fix this issue ?
Thanks in advance !

I've found this topic
https://forum.manjaro.org/t/displaylink-driver-installation-issue/22176
Which describes the same problem. There is AUR package with
DisplayLinkManager 5.3.1 (it's maintained by community).
I'm not familiar with manjaro but it seems it's enough to just call
pamac build displaylink


Mixed mode assembly error in interactive mode

This error happens in interactive mode only, not when using he --render option:

TrifleJS.exe
Unhandled Exception: System.IO.FileLoadException: Mixed mode assembly is built against version 'v2.0.50727' of the runtime and cannot be loaded in the 4.0 runtime without additional configuration information.
at TrifleJS.Program.Interactive()
at TrifleJS.Program.Main(String[] args) in c:...\trifleJS\Program.cs:line 88

I'm using Visual Studio 2013, the project was converted automatically. The .Net target for the solution is 4. I couldn't figure out which assembly has been compiled for .Net 2.

This was caused by Noesis.Javascript and Newtonsoft.Json

Hi @juliensobrier.
Thanks for the bug report and related info. I'm trying to remove dependency on local installation of VC++ 2008 runtime (see #25), so I bundled dependencies for Noesis.Javascript but in doing so might have ended up causing other issues too.
BTW this could also be related to the platform target. I'm always targetting x86 to make sure that I can have one set of binaries and dependencies working in x64 and x86. I had a similar error to yours when combining dependencies from x64 and x86 on the same project I think.

Also, you have a wider selection of downloads for Noesis.Javascript (.Net 3.5 and 4 vs x64 and x86) if you are building TrifleJS against a specific .NET version. You can download the DLLs in this link.

I'll be adding some more info on this topic to the wiki. Its bound to come up again.

I'm not very familiar with .Net, but is there a way to get npm to pull the dependencies automatically? This is how I got the right version for the 2 libraries.


can't build on android studio

it says could not find those plugins i've set google repo instead of jcenter
Could not find org.greenrobot:greendao-gradle-plugin:3.2.2.
Searched in the following locations:
https://dl.google.com/dl/android/maven2/org/greenrobot/greendao-gradle-plugin/3.2.2/greendao-gradle-plugin-3.2.2.pom
https://dl.google.com/dl/android/maven2/org/greenrobot/greendao-gradle-plugin/3.2.2/greendao-gradle-plugin-3.2.2.jar
Required by:
project :

Hello,
The google maven repo only contains google artifacts as you can see here: https://dl.google.com/dl/android/maven2/index.html
If you remove the jcenter repository, you may not be able to retrieve some dependencies. You should not remove it.
In any case, the greendao-gradle-plugin is available from these repos:

http://central.maven.org/maven2/org/greenrobot/greendao-gradle-plugin/3.2.2/
https://jcenter.bintray.com/org/greenrobot/greendao-gradle-plugin/3.2.2/


Add stack to store game moves

Description
This pull request adds a stack data structure to store game moves in the  program. The stack keeps track of the order of moves made during the game.
Changes

Implemented a stack to store and manage game moves.
Updated the code to use the new stack for move tracking.

issue
I believe placing the stack in a global variable might not be the best practice. Therefore, I would like to inquire whether the following approach is feasible. I intend to modify the existing functions by extending their parameters.

get_input

Please let me know if this approach is acceptable or if there are alternative suggestions.

Close in favor of #5


Complete class aliases whose targets do not exist

This commit adds support and a test for the following case:
use Some\Namespace\ClassWhichDoesNotExist;

ClassWhichDoesN| // Completes to ClassWhichDoesNotExist

This is primarily useful in cases where the target class is not indexed for some reason.
This PR is based on #599 so it cannot be merged before that and only the last commit f5b1256 contains new changes.

Is this still relevant?


Fix source and browse utilities to be able to use out of the box

fix https://github.com/com-lihaoyi/Ammonite/issues/1254
This PR enables Ammonite-REPL to use browse and source built-in utilities out of the box.

browse

As @ches mentioned in https://github.com/com-lihaoyi/Ammonite/issues/1254, browse takes implicit pprint.PPrinter that is not in the REPL scope by default.
fixed by giving a default argument https://github.com/com-lihaoyi/Ammonite/commit/05e295855b79a2cd3e861a5b7c81553caa30678a

source

define browseSourceCommand that is called from macro (looks like forgotten to port in https://github.com/com-lihaoyi/Ammonite/commit/ba57f10ab8ca1c5b8c1e2041c9c338d44d1cb885)
Added repl.codeColorsImplicit to predefImport, (is this ok?)
Add pprint.PPrinter as default parameters (in a wired way)

default argument doesn't work for macro definition
import implicit pprint.PPrinter to REPL scope may change the behavior of other commands (like grep, browse) because they also receive implicit pprint.PPrinter (but it would be better to use different printer instance?)

None of this version works in my system:
$ scala-cli repl --ammonite-version 2.4.0 --ammonite --scala 2.13.5
...
$ scala-cli repl --ammonite-version 2.5.1 --ammonite --scala 2.13.7
...
$ scala-cli repl --ammonite-version 2.5.4 --ammonite --scala 2.13.8
Welcome to the Ammonite Repl 2.5.4 (Scala 2.13.8 Java 11.0.16)
@ source(scala.collection.mutable.Buffer)
cmd0.sc:1: could not find implicit value for parameter pprinter: pprint.PPrinter
val res0 = source(scala.collection.mutable.Buffer)
                 ^
Compilation Failed

This works like expected:
~$ scala-cli repl --ammonite-version 2.3.8 --ammonite --scala 2.13.5
Welcome to the Ammonite Repl 2.3.8 (Scala 2.13.3 Java 11.0.16)
@ source(scala.collection.mutable.Buffer)
//shows it as expected

This change isn't included in 2.5.4, will be available in the next release (or the latest build as you tested :+1:)


Fix default windows interceptor list

Summary of the Pull Request
What is this about?
PR Checklist

[ ] Applies to work item: #xxx
[ ] CLA signed. If not, go over here and sign the CLI.
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?

Codecov Report

Merging #3549 (2482a0a) into main (78f9049) will decrease coverage by 0.62%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #3549      +/-   ##
==========================================
- Coverage   39.03%   38.41%   -0.62%
==========================================
  Files         301      273      -28
  Lines       36845    31838    -5007
==========================================
- Hits        14383    12232    -2151
+ Misses      22462    19606    -2856

Files
Coverage Δ

src/agent/coverage/src/allowlist.rs
88.77% <100.00%> (-1.95%)
:arrow_down:

src/agent/coverage/src/allowlist/tests.rs
100.00% <100.00%> (ø)

...c/agent/onefuzz-task/src/tasks/coverage/generic.rs
85.12% <0.00%> (-2.69%)
:arrow_down:

... and 55 files with indirect coverage changes


Add sequence similarity columns and filters for RNA and proteins

Do once https://github.com/KarrLab/datanator_rest_api/issues/38 is completed

Use end point '/proteins/similar_protein/refseq/?uniprot_id={}&identity={}' to get similar proteins.

Closing. As we discussed, this suggestion doesn't make sense because ortholog groups don't have a well-defined sequence. Consequently, the concept of a distance from an RNA/protein sequence to that of an ortholog group is ill-defined.


Metrics not following Prometheus best practices

Bug Report

What did you do?
I ran promlint accross all metrics exposed in OpenShift and noticed that some metrics from OLM were not following Prometheus best practices.
What did you expect to see?
What did you see instead? Under which circumstances?
The following OLM metrics were reported by promlint:
catalog_source_count:
  - non-histogram and non-summary metrics should not have "_count" suffix
install_plan_count:
  - non-histogram and non-summary metrics should not have "_count" suffix
subscription_count:
  - non-histogram and non-summary metrics should not have "_count" suffix
csv_count:
  - non-histogram and non-summary metrics should not have "_count" suffix
csv_upgrade_count:
  - non-histogram and non-summary metrics should not have "_count" suffix
  - counter metrics should have "_total" suffix

Environment

operator-lifecycle-manager version: master

Possible Solution
The reported metrics should be renamed in order to follow the best practices.
Gauge
Gauge metrics should not have a "_count" suffix as it is reserved for histograms and summaries. Instead of that, we tend to suffix the plural of the measured data. Thus, I would suggest the following changes:
catalog_source_count --> catalog_sources
install_plan_count --> install_plans
subscription_count --> subscriptions
csv_count --> cluster_service_versions
Counter
As promlint reported, counter metrics should have a "_total" suffix
csv_upgrade_count --> cluster_service_version_upgrades_total

Thank you for raising this issue.
We have a monitoring team that can assist here. Pinging @awgreene as well.

Stale issue. Closed. Feel free to reopen if needed.


Point2Voxel generated coordinates out of range?

I'm using VoxelGenerator.point_to_voxel(), to get the voxelized points. But I fond the return value of coordinates out of range. Did I miss some procedure or wrong understanding the function? Please let me understand, thank you. Here's my code.
import numpy as np
from skimage import transform
from pcdet.models.backbones_3d.spconv_backbone import VoxelBackBone8x
import torch
import torchvision
import spconv
tv = None
try:
    import cumm.tensorview as tv
except:
    pass
class voxelgenerator():
    def __init__(self,vsize_xyz, coors_range_xyz, num_point_features, max_num_points_per_voxel, max_num_voxels):
        print(vsize_xyz, coors_range_xyz, num_point_features, max_num_points_per_voxel, max_num_voxels)
        try:
            from spconv.utils import VoxelGeneratorV2 as VoxelGenerator
            self.spconv_ver = 1
        except:
            try:
                from spconv.utils import VoxelGenerator
                self.spconv_ver = 1
            except:
                from spconv.utils import Point2VoxelCPU3d as VoxelGenerator
                self.spconv_ver = 2

        if self.spconv_ver == 1:
            self._voxel_generator = VoxelGenerator(
                voxel_size=vsize_xyz,
                point_cloud_range=coors_range_xyz,
                max_num_points=max_num_points_per_voxel,
                max_voxels=max_num_voxels
            )
        else:
            self._voxel_generator = VoxelGenerator(
                vsize_xyz=vsize_xyz,
                coors_range_xyz=coors_range_xyz,
                num_point_features=num_point_features,
                max_num_points_per_voxel=max_num_points_per_voxel,
                max_num_voxels=max_num_voxels
            )

    def generate(self, points):
        if self.spconv_ver == 1:
            voxel_output = self._voxel_generator.generate(points)
            if isinstance(voxel_output, dict):
                voxels, coordinates, num_points = \
                    voxel_output['voxels'], voxel_output['coordinates'], voxel_output['num_points_per_voxel']
            else:
                voxels, coordinates, num_points = voxel_output
        else:
            assert tv is not None, f"Unexpected error, library: 'cumm' wasn't imported properly."
            voxel_output = self._voxel_generator.point_to_voxel(tv.from_numpy(points))
            tv_voxels, tv_coordinates, tv_num_points = voxel_output
            # make copy with numpy(), since numpy_view() will disappear as soon as the generator is deleted
            voxels = tv_voxels.numpy()
            coordinates = tv_coordinates.numpy()
            num_points = tv_num_points.numpy()
        return voxels, coordinates, num_points

    def meanVFE(self,voxel_features, voxel_num_points):
        points_mean = voxel_features[:, :, :].sum(dim=1, keepdim=False) # Use sum() instead of _sum()
        normalizer = torch.clamp_min(voxel_num_points.view(-1, 1), min=1.0).type_as(voxel_features)
        points_mean = points_mean / normalizer
        return points_mean.contiguous()

voxel_size = dataset_processor_cfg[2].VOXEL_SIZE
points_range = cfg.DATA_CONFIG.POINT_CLOUD_RANGE
num_point_features = cfg.DATA_CONFIG.DATA_AUGMENTOR.AUG_CONFIG_LIST[0].NUM_POINT_FEATURES
max_number_per_voxel = dataset_processor_cfg[2].MAX_POINTS_PER_VOXEL
max_number_of_voxels = dataset_processor_cfg[2].MAX_NUMBER_OF_VOXELS['train']
#grid_size = cfg.MODEL.ROI_HEAD.ROI_GRID_POOL.GRID_SIZE

grid_size = points_range[3:6] - points_range[0:3] / np.array(voxel_size)
grid_size = np.round(grid_size).astype(np.int64)
print(grid_size)

voxel_generator = voxelgenerator(voxel_size, points_range, num_point_features, max_number_per_voxel, max_number_of_voxels)
points = np.fromfile(data_path, dtype=np.float32).reshape(-1, 4)
# only use the points in points range
# print('origin', len(points))
# points = points[(points[:, 0] >= points_range[0]) & (points[:, 0] < points_range[3]) &
#                 (points[:, 1] >= points_range[1]) & (points[:, 1] < points_range[4]) &
#                 (points[:, 2] >= points_range[2]) & (points[:, 2] < points_range[5])]
# print('after', len(points))

voxels, coordinates, num_points = voxel_generator.generate(points)

voxels = torch.from_numpy(voxels)
coordinates = torch.from_numpy(coordinates)
num_points = torch.from_numpy(num_points)

# print max of coordinates
print(coordinates.max(0), coordinates.min(0))

mean_voxel = voxel_generator.meanVFE(voxels, num_points)
print(mean_voxel.shape, coordinates.shape, num_points.shape)

# 2. load the voxelbackbone
backbone = VoxelBackBone8x(model_cfg=cfg, input_channels=num_point_features, grid_size=grid_size)
# [batch_idx, z_idx, y_idx, x_idx]
coordinates = torch.cat([torch.zeros_like(coordinates[:, :1]), coordinates], dim=1)
for i in range(len(coordinates)):
    coordinates[i, 0] = i

# mean_voxels, coordinates, num_points to cuda
os.environ["CUDA_VISIBLE_DEVICES"] = "0"
torch.cuda.set_device(0)
mean_voxel = mean_voxel.to(0)
coordinates = coordinates.to(0)
num_points = num_points.to(0)

sp_input_res = backbone.get_input_layer_result(voxel_features=mean_voxel, voxel_coords=coordinates,batch_size=1)

And the input parameters of voxelgenerator are [0.05, 0.05, 0.1] [-70.4, -40, -3, 70.4, 40, 1] 4 5 16000, grid size is [1478  840   31]. But the max and min of coordinates are
print(max(indices[:,1]), min(indices[:,1])) # 39 0
print(max(indices[:,2]), min(indices[:,2])) # 1599 0
print(max(indices[:,3]), min(indices[:,3])) # 2813 0

I thought the max of indices should less than grid size.

Please explain me why, thank u 🥺


Add more examples

Hello,
can you please provide examples for Flat Deployment for auto and manual setup? And maybe a part where you explain how to add cdi extensions like deltaspikes extensions?

Hello,
have you tried looking at the test suite in the repository?
The auto setup for instance is quite extensively tested/shown here.
The "manual" approach can then be seen in other packages here.
To add another library (e.g. DS) you will probably have to have discovery enabled and make sure the DS file is on the classpath. I don't think we allow to add another JAR at the moment. If it is your own extension you are adding, then one way is to provide org.jboss.weld.environment.se.Weld yourself and on it there is the addExtension() method. Although with enabled discovery, standard service loader mechanism kicks in and loads all extensions registered that way as well.

Hello,
thx for clarification.
I managed to get the deltaspike classes in the weld test container by using discovery enabled.
@ExtendWith(WeldJunit5Extension.class)
public class Test(){

    @WeldSetup
    public WeldInitiator weld = WeldInitiator.from(WeldInitiator.createWeld()
                                                                .enableDiscovery())
                                             .activate(RequestScoped.class, SessionScoped.class)
                                             .build();
}

Is this also possible with the auto setup? I didnt find anything about it.
If I want to override a bean in the test container with a mocked bean by using the addBeans method I get an deployment exception org.jboss.weld.exceptions.DeploymentException: WELD-001409: Ambiguous dependencies.
Is it possible to override a bean in the test container with my current setup like it is described in the auto setup with the @OverrideBean annotation?

Is this also possible with the auto setup? I didnt find anything about it.

It's not directly possible. Auto setup was designed to be used for simple cases when most of the logic can be deduced from the test class itself. And ultimately it creates a synthetic archive from the classes you use in your test plus annotation. Yours is more of a case for the 'manual' approach. You could try and cheat it via @AddPackage annotation where you specify some DS class but I would bet this won't work :)

If I want to override a bean in the test container with a mocked bean by using the addBeans method

You should be able to do that, take a look at org.jboss.weld.junit5.bean.AlternativeMockBeanTest for instance. If you want a more "standard" CDI approach, you can always simply define an @Alternative with @Priority and add it to Weld deployment.

I tried your suggestion from the org.jboss.weld.junit5.bean.AlternativeMockBeanTest in a small example project under:
https://github.com/JavaTesting1/weldtesting
In the test class de.stga.weldtesting.alternative.ManualWeldcontainer the mock wont override the class in the weldcontainer.
In the test class de.stga.weldtesting.alternative.AutoWeldcontainer  the mock overrides the class in the weldcontainer, but there is the problem that in the auto setup I can`t enable the automatic discovery of beans in order to add the deltaspike libraries to the container.
Would it be possible to add maybe another annotation which enables the automatic discovery for the auto mode?
Would it be possible to improve the automatic discovery with features like springs  @ComponentScan (https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/context/annotation/ComponentScan.html) where you can specify in which base packages the beans are searched and it also adds the possibility of exclude and includefilters.
My final goal would be to use this library for unit testing and lightweight integration testing of classes where I need to load some deltaspike libraries and to overwrite some classes in the container with mocks which are configured on a per test basis.

In the test class de.stga.weldtesting.alternative.ManualWeldcontainer the mock wont override the class in the weldcontainer.

In this class, the declaration doesn't include @Produces and @OverrideBean while the AutoWeldcontainer has it. Any reason for that?

In my understanding the @OverrideBean annotation is only used in the auto setup. See org.jboss.weld.junit5.auto.WeldJunit5AutoExtension at Line 56 weld.addAlternativeStereotype(OverrideBean.class);. Maybe I am missing something. Additionally I tried to add these annotations and removed the addBeans part in my test class ManualWeldcontainer but it still doesnt work.

Would it be possible to improve the automatic discovery with features like springs @componentscan

Is @AddPackages annotation what you are looking for? https://github.com/weld/weld-junit/blob/master/junit5/README.md#addpackages

Not really I am looking for something where I could pass for example a string as parameter e.g. "org.apache.deltaspike.core" because with @AddPackages in my understanding I have to provide a class in this package in order to get all classes in this package and its subpackages but if you look at the package structure of e.g. the deltaspike projects (e.g. deltaspike-core, deltaspike-security etc.) then you would have to add a ton of classes in order to get the library loaded into the weld container. And with every update of the library you would have to double check if new packages where added. But I will try your suggestion.

Not really I am looking for something where I could pass for example a string as parameter e.g. ...

I think your case is better suited for the manual approach as you actually need to specify a lot of things.
Note that you could have a abstract predecessor class where you define how Weld object looks like and then reuse it (or modify and reuse perhaps?).

In my understanding the @OverrideBean annotation is only used in the auto setup.

Ah sorry, you are right, it was added alongside auto setup.
You could use either this approach or simply define an alternative that you enable and add to the deployment. Based on how much different the mock is from actual bean.

Reading over our conversation again, I think for now you should be able to use the manual approach and could prepare Weld (or WeldInitiator) instance beforehand, or have a util method, and then modify it slightly for each test using it.
The alternative problem can be approached like I suggested above and is solvable in both approaches.
I agree that we should enrich annotation based approach with @EnableDiscovery. This is missing compared to declarative approach where you can either pass in a configured Weld instance with discovery, or you could use WeldInitiator.performDefaultDiscovery().
As a side note - with your setup, adding different libraries and all, you are sort of going more into integration tests rather than unit tests and for that something like Arquillian might be a better fit.

I think for now you should be able to use the manual approach and could prepare Weld (or WeldInitiator) instance beforehand

Hi you are right the manual approach seems the way to go. But I still cant get it to work. I added another test class de.stga.weldtesting.alternative.ManualWeldcontainer2. It also uses the manual approach but it is closer to the second example you provided from https://github.com/weld/weld-junit/tree/master/junit5#adding-mock-beans. I have to use the WeldInitiator.from(WeldInitiator.createWeld().enableDiscovery()) in order to get my deltaspike libraries. So the Fish.class is already in the container. Then I try to provide an alternative with
static Bean<?> createFishBean() {
    return MockBean.builder().types(Fish.class).scope(SessionScoped.class).selectedAlternative(Fish.class)
               .creating(Mockito.when(Mockito.mock(Fish.class).numberOfLegs()).thenReturn(400).getMock()).build();
}

but it seems that the selectedAlternative is ignored. Either the bean construction I am using isnt right or I am missing something else?

Checking on your repo, it looks like the problem is not the alternative, but the fact that no injection at all works in your tests (you are getting NPEs trying to use fields that should have been injected). Perhaps some misconfig?

It worked on my machine ;) But I also found some improvements for the setup and commited them. But if its already running with failing assertions then you wouldnt need it.

Well it seems to be some issue with having a discovery (which creates several bean archives based on what it finds on CP) + creating the synthetic archive on top. Maybe the alternative is enabled only in the synthetic archive (e.g. as if it was enabled via beans.xml) but the test and FishTank belongs to actual discovered archive.
So the alternative cannot be seen from there... I'll try to look into it some more, have some ideas to play around with. I'll keep you posted.

I think it also needs examples of how to use setPersistenceUnitFactory().

@edpichler it's simple mock, you provide a function that based on an InjectionPoint parameter retruns an Object. This allows the function to inspect the IP (type, class in which it is etc.) and return appropriate EntityManager/EntityManagerFactory. How you create the EM/EMF is enterily up to you. Weld-JUnit API merely allows you to plug that in.

@JavaTesting1 after some digging I think the issue is indeed that there are several archives and MockBean only allows to create and alternative inside the synthetic bean archive created for testing (whereas the actual beans are detected/used outside).
This cannot be remedied so long as we want to maintain CDI 1.2 compatibility. If we dropped that, MockBean could implement Prioritized interface hence making it globally enabled alternative across all archives and your manual approach should then work. Theoretically, we could consider creating a 2.0 version that will be CDI 2 focused allowing us to solve this (and other similar) issue.
I am still a bit puzzled about why archive isolation doesn't work here and need to investigate it some more though.

I am still a bit puzzled about why archive isolation doesn't work here and need to investigate it some more though.

@manovotn So the problem is that if you don't add any bean class to the synthetic bean archive Weld does not create the synthetic bean archive at all - see also https://github.com/weld/core/blob/master/environments/se/core/src/main/java/org/jboss/weld/environment/se/Weld.java#L962. As a side effect, the mock alternative bean is ignored - no synthetic bean archive means no beans.xml that could be merged when isolation is disabled. Maybe we could add a dummy bean class if a mock alternative bean is added.

Thanks Martin!
So at this point @JavaTesting1 could use a workaround of manually registering a dummy bean (simple Object would do) to make his test pass. It would look like this -> https://github.com/manovotn/weldtesting/commit/585f9133f450fb616f78c5cfb759ee30ac1229c9
And we should probably do similar thing automatically when we detect that an alternative is added into synthetic archive. That would mean here.

@JavaTesting1 let me know if that workaround fixes it for your case, please.
Similar fix is now merged in master so the next release should allow for your use case with discovery and disabled isolation.


Cookie handling on login

Just a suggestion: The client sends cookies: false in login request, if cookies are disabled. So the server could just give an error and the user stays at the login form (if guests are enabled). This prevents the user of thinking he is logged in (See issue #2654 ).
@normanjaeckel (and others): Whats you opinion?

and the user stays at the login form (if guests are enabled).and the user stays at the login form (if guests are enabled).

Do you mean if guests are disabled?


Prev/Next not responding

On my device, android 4.1.2, I touch on Prev/Next and nothing happened. Please fix.

Thanks @SWORDBASEDGOD I used your code, but I made some improvement, at least for me this solved a little better my problem, so at the same lines I put:
$prev.on("touchstart click", function (e) { base.previous(); });  $next.on("touchstart click", function (e) { base.next(); }); $prev.on("touchend", function (e) {e.stopPropagation();  }); $next.on("touchend", function (e) {e.stopPropagation();});
'Cause without stopping touchend propagation, next and prev buttons were just working if I keep my finger pressed until the slide change. At the beginning I thought that it would disable swipe gestures, but it doesn't, so I guess it's a good workaround


gradlew can't be runned on bash in windows subsystem for linux (WSL)

Expected Behavior
When running ./gradlew tasks in a project dir, under the ubuntu bash shell in windows subsystem for linux, I expect it to run the task.
Current Behavior
ylm@wsl:~/myproject$ ./gradlew tasks
./gradlew: line 2: $'\r': command not found
./gradlew: line 8: $'\r': command not found
./gradlew: line 11: $'\r': command not found
./gradlew: line 14: $'\r': command not found
./gradlew: line 17: $'\r': command not found
./gradlew: line 18: syntax error near unexpected token `$'{\r''
'/gradlew: line 18: `warn ( ) {
ylm@wsl:~/myproject$ ./gradlew.bat tasks
./gradlew.bat: line 1: @if: command not found
./gradlew.bat: line 2: @rem: command not found
./gradlew.bat: line 3: $'@rem\r': command not found
./gradlew.bat: line 4: @rem: command not found
./gradlew.bat: line 5: $'@rem\r': command not found
./gradlew.bat: line 6: @rem: command not found
./gradlew.bat: line 7: $'\r': command not found
./gradlew.bat: line 8: @rem: command not found
./gradlew.bat: line 88: unexpected EOF while looking for matching `"'
./gradlew.bat: line 91: syntax error: unexpected end of file
ylm@wsl:~/myproject$

Context
ubuntu bash shell in windows subsystem
Steps to Reproduce (for bugs)
Install windows creator fall update through insider program
Install windows subsystem for linux
Install ubuntu bash shell through windows store.
cd in a project directory
run gradlew

Ok, it's not you.... It's git....
When git checkout is configured with  core.autocrlf=true, it replace gradlew carriage return with CRLF.
Therefore, the script wont run.

You can fix your gradlew file like: https://askubuntu.com/questions/803162/how-to-change-windows-line-ending-to-unix-version


[MXNET-13453] [Clojure] - Add Spec Validations to the Optimizer namespace

Description
add some spec validations to the optimizer namespace
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ x] Changes are complete (i.e. I finished coding on this PR)
[ x] All changes have test coverage:

Changes

updated optimizer.clj with specs
added throw exception checks in optimizer_test.clj

Thanks @hellonico so much for your contribution! 😸 I'll take a closer look tomorrow. Don't worry about the failure on the Travis side, there have been some issues with it lately.

@mxnet-label-bot add [Clojure, pr-awaiting-review]

I kicked off the Jenkins CI again - when it passes this is good to merge.

@hellonico - Can you change the PR to be against master ? Right now it against 1.3.0 - thanks!

@hellonico I was able to change the base in the PR, but I think you will need to rebase your commits against master to make it all clean :)

Thanks @hellonico !!


Does colly support incremental crawling?

I have two questions:

Does colly support incremental crawling?
How does colly's distributed crawler accomplish the removal of duplicate URL requests?

Looking forward to your reply.Thanks!

Use a persistent storage backend like redis. This way both incremental crawling and distributed URL deduplication is possible if all the crawler instances are using the same storage backend.
example: http://go-colly.org/docs/examples/redis_backend/

Also, in most cases the network traffic is the bottleneck of a scraping job, so it's enough to distribute only the network part of the scraping, where a simple proxy rotation and some ssh tunnels can handle the load: http://go-colly.org/docs/examples/proxy_switcher/ .

Thank you very much!


how we can reduce the tremble from the mediapipe hand detection

Hi @sujilal, Could you please elaborate your query with complete details. Thanks!

@sgowroji:  The mediapipe hand detection model after taking the frame getting tremble, you can check the example which mediapipe published. if I load any image using the mediapipe model, the image starts to tremble

Hi @sujilal, On which platform are you facing the above error. Can you provide a video reference of the above observation and any error logs to investigate it for further. Thanks!

@sujilal     Have you solved the problem yet?


jsx: "react" being ignored

No matter how much I try, the bundle it generates (using an electron target) doesn't transform react constructs (e.g. <div/>). It seems as if the jsx: "react" option is being forced to being off.
const release = false;

  const baseFuseConfig = (target) => {
    const cfg = {
      ensureTsConfig: true,
      homeDir: "src",
      target: `${target}@es6`,
      hash: false,
      cache: !release,
      sourceMaps: { project: !release, vendor: false },
      plugins: []
    };
    return cfg;
  };

  const fuseApp = FuseBox.init({
    output: `${dist}/app/$name.js`,
    ...baseFuseConfig("electron")
  });

  fuseApp.bundle("app").instructions(">[app/appIndex.tsx]");
  fuseApp.run();

tsconfig
{
  "include": ["src/**/*"],
  "compilerOptions": {
    "target": "es6",
    "module": "commonjs",
    "lib": ["es2016", "dom", "dom.iterable", "es2017.object", "esnext.asynciterable"],
    "jsx": "react",
    "downlevelIteration": true,
    "strict": true,

    "noImplicitReturns": true,
    "noFallthroughCasesInSwitch": true,

    "moduleResolution": "node",

    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,

    "suppressImplicitAnyIndexErrors": false,
    "forceConsistentCasingInFileNames": true,
    "noEmitOnError": false,

    "noEmit": true, // only run type checks
    "rootDir": "src",
    "baseUrl": "./",
    "inlineSourceMap": false,
    "inlineSources": true,
    "sourceMap": true,
    "outDir": "./dist-ts" // ignored by fusebox
  }
}

I tried 3.5 and next

@xaviergonz ok, outDir  will be ignored, of course. Since there is a separate output config in FuseBox.init
What's the actual tsconfig file that FuseBox picks up? It should be in the logs. React should work. For example in this example https://github.com/fuse-box/fuse-react-demo

it says "/tsconfig.json", it does work in the demo, and that's what really puzzles me.
I tried moving it inside src, right where the fuse.js file is, etc, but nothing.
The very same code seems to bundle ok in parcel and webpack 4

I even tried manually setting tsConfig to an absolute path btw

@xaviergonz can you reproduce it?

No, the demo works without problems, it seems to only happen in my project which is what confuses me.

@xaviergonz could you comment out tsconfig options, it seems like there are lot of them, and see it any of them breaks it. (Dont' forget to clean the cache each time)

Closing due to inactivity


[GLUTEN-7746] Reduce the thread local cost when calling the hdfs read

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested.

@FelixYBW Yes. https://github.com/facebookincubator/velox/pull/11580

closing as it's already picked in oap/velox


Device discovery isn't working?

I have a Lumen 8 Wifi enabled smart bulb on my network, and my iOS app picks it up just fine. However, test.js isn't picking up anything. Have you tried this lately?

@JwJason this library only supports Lumen Bluetooth Low Energy bulbs. I've update the read me accordingly in https://github.com/sandeepmistry/node-lumen/commit/4d1afd4319e3a5ba895988889293128501cbfffd.


Introduce a log text formatter that prefixes the binary name to the log entry

Gives you logs that look like below:
[infrastructure-deployer] INFO[2020-08-19T11:23:08-05:00]   ami-builder
[infrastructure-deployer] INFO[2020-08-19T11:23:08-05:00]       build-packer-artifact
[infrastructure-deployer] INFO[2020-08-19T11:23:08-05:00]   docker-image-builder
[infrastructure-deployer] INFO[2020-08-19T11:23:08-05:00]       build-docker-image
[infrastructure-deployer] INFO[2020-08-19T11:23:08-05:00]   terraform-applier
[infrastructure-deployer] INFO[2020-08-19T11:23:08-05:00]       infrastructure-deploy-script
[infrastructure-deployer] INFO[2020-08-19T11:23:08-05:00]       terraform-update-variable
[infrastructure-deployer] INFO[2020-08-19T11:23:08-05:00]   terraform-planner
[infrastructure-deployer] INFO[2020-08-19T11:23:08-05:00]       infrastructure-deploy-script

Thanks for review! Going to merge this in now.


Bonelab Application Compatibility

Per the resolution in https://github.com/mbucchia/VirtualDesktop-OpenXR/issues/46, the status of support is now "working in future release". If this fits with how you are categorizing it, an update to the compatibility list would be much appreciated!
Thank you,
Yewnyx

Thank you, I updated the page as you requested.


REFACTOR set SlideImage upload size limit via config

Current coverage is 93.67% (diff: 100%)

No coverage report found for master at 6a0974d.

Powered by Codecov. Last update 6a0974d...c446d14


Stop & start the Linux agent will return "Cannot configure the agent because it is already configured"

[Enter feedback here]
I've successfully configured the Azure Devops agent with a self-hosted container.
During the initial boot of the container everything works as expected. However, if the container is stopped and started again, the following error will show

Cannot configure the agent because it is already configured. To reconfigure the agent, run 'config.cmd remove or './config.sh remove' first.

I modified start.sh to run config.sh remove ahead of the default configuration command. but that makes the agent request the config parameters from standard input instead of using the docker ENV variables.
I'd say that start.sh script could be made to not run the config command if already found locally.
That would allow us to stop and restart containers (like it could happen during a host reboot)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b31d4f6c-d16d-2ba1-1294-6aa94e328046
Version Independent ID: 88aec599-4410-697d-1002-1c41b1c17bb6
Content: Run a self-hosted agent in Docker - Azure Pipelines
Content Source: docs/pipelines/agents/docker.md
Product: devops
Technology: devops-cicd-agents
GitHub Login: @steved0x
Microsoft Alias: sdanie

@jsancho - Thanks for your question. It looks like you're working through an issue with your scenario or implementation, rather than an issue with the documentation. Please consider these resources:

Azure DevOps Services
Azure DevOps Support Bot
Azure DevOps on Stack Overflow

Also, you might search for the error at the developer community.
If there are doc changes we need to make around this, we can reopen this issue.

I'm having the same problem. The scripts from the doc's are working perfectly, but after a reboot it tries to run the config setup again and fails.

This could be a product issue. Consider filing a bug here.


Question: getting documents with highest proportion of a topic from HDPModel

I'm using HDPModel on 14,000 documents. The resulting topics and their frequency across the corpus are good based on domain knowledge. But I'm struggling to get documents that are representative of a topic, where representative means the documents have highest proportion of tokens from that topic.
Borrowing from https://github.com/bab2min/tomotopy/issues/74, I tried this:
hdp = tp.HDPModel(tw=tp.TermWeight.IDF, min_df=6, rm_top=0, gamma=0.5,
                  alpha=0.1, initial_k=10, seed=100)
[hdp.add_doc(words) for words in texts]
hdp.burn_in = 100
hdp.train(1400)

ldamodel, _ = hdp.convert_to_lda(topic_threshold=0.02)
topic_term_dists = np.stack([ldamodel.get_topic_word_dist(k) for k in range(ldamodel.k)])
doc_topic_dists = np.stack([doc.get_topic_dist() for doc in ldamodel.docs])
doc_lengths = np.array([len(doc.words) for doc in ldamodel.docs])
vocab = list(ldamodel.used_vocabs)
term_frequency = ldamodel.used_vocab_freq

# Then I try to find the top 2 documents representative of a topic:
top_n_documents = 2
topic_index = 0
print ("For topic %d, representative documents are:"
       % topic_index, [i for i, j in hdp.get_topic_words(topic_index, 4)])
sorted_tuples = sorted(enumerate(doc_topic_dists[:, topic_index]), key=lambda a:a[1], reverse=True)
for tup in sorted_tuples[0:top_n_documents]:
  print(texts[tup[0]], "\n") # all entries in |texts| are passed to hdp.add_doc in line 3 above

But no matter which topic_index I use, the top documents are subjectively unrelated to the topic that they supposedly belong to.
Am I misunderstanding something? Is there a better way to get representative documents for a topic?

Ok, this is great info. I didn't realize that the words from the topics with weight < 0.02 were randomly reassigned. I though they were dropped, somehow.
I found that my "top 2 documents representative of a topic" code worked when I trained LDAModel from the beginning, which let me avoid convert_to_lda. So I'm sticking with LDAModel, at least for now, because LDAModel gave results as good as or maybe even better than HDPModel. But I like your suggestion of more training after calling convert_to_lda, that seems like maybe the best of both HDP and LDA.
Your answer indicates that maybe I wasn't training HDPModel long enough. When I increased HDPModel iterations about 2-3x that of LDAModel (2000 to 5000) the results of HDPModel didn't change much and were still not as good as LDAModel . Have you ever seen a case that needed an even higher multiplier to see more improvement? Like 20x?
Thanks for the library. Thanks for the guidance.

@davidsgrogan
I think that since HDPModel constantly searches for an appropriate k value, it generally takes much more iterations to converge that LDA, and its result is often unstable. Thus, with a fixed k value, LDAModel outperforms HDPModel in many situations. So if you can choose an appropriate k value manually, LDAModel is a better choice. HDP is better than LDA only in that it can automatically detect k value.


DO NOT MERGE - Alexa adapter

@cleemullins @Stevenic @drub0y I am raising this PR so that we can get the current code reviewed whilst I am finalising some testing.
In place now and ready for review;

Alexa adapter - including helper library for validating incoming requests (this gets called automatically by the integration layer and can be disabled via the integration options for testing purposes)
Alexa middleware - transforming incoming IntentRequest messages into MessageActivities - @Stevenic it would be great to get your eye on this to see if this is what you had in mind based on our offline conversation.
Alexa context extensions - three extensions for managing Alexa Session Attributes (Alexa skills way of managing state across turns), sending progressive messages (again as discussed with @Stevenic) and providing ease of access to the original request (stored in Channeldata)
Integration layer for WebApi and Core - @drub0y I have based these on your integration libraries for bot framework.  Ideally at some point when we align the adapters we can consolidate these into a single integration layer regardless of the adapter, but for now I believe we need these so would be good to get your eye on them.
Adapters solution folder - as discussed with @cleemullins I have added a solution folder for Adapters as we will have Google Actions adapter following shortly

Outstanding actions;
* I have tested the WebApi integration, but I still need to make a couple of amends to the Core integration and test
* Test some updates to the middleware I have made recently
* Add unit tests
If you guys can review and I can make changes as I go as per your comments.
Thanks!

@cleemullins @tomlm Just to let you know I have updated this PR to track against master. Would be great to catch up about this soon, possibly post Ignite.

I don't think it directly relevant at this point in time. I believe this PR should be pulled out to dedicated repo and offered as a sample and/or library.

I am super hyped to use this! Is there a place where I can follow the progress of the Alexa adapter? Is there going to be more work done on this?

This will now be made available in the Bot Builder Community repo in the next few days. Keep an eye on the dotnet repo at https://github.com/BotBuilderCommunity
Get Outlook for Androidhttps://aka.ms/ghei36

From: Martijn Steenbergen<EMAIL_ADDRESS>Sent: Thursday, November 1, 2018 12:14:55 PM
To: Microsoft/botbuilder-dotnet
Cc: Gary Pretty; Author
Subject: Re: [Microsoft/botbuilder-dotnet] DO NOT MERGE - Alexa adapter (#453)
I am super hyped to use this! Is there a place where I can follow the progress of the Alexa adapter? Is there going to be more work done on this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/botbuilder-dotnet/pull/453#issuecomment-435022572, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADuE6Q5Jt3sWB9bcLw80qh2811H61KFhks5uquW_gaJpZM4TaRur.

Ok. Thanks!


smtp-starttls: test logging of smtp txn after startssl

Requires Suricata PR: https://github.com/OISF/suricata/pull/6598.
For ticket https://redmine.openinfosecfoundation.org/issues/4817.

Merged into master.


chore:updated otel dependencies

Coverage remained the same at 96.97% when pulling 59c4b4d7fce5121ed415c5ab0a689e8b390bbd07 on pnaik1:update into c1eea1dc2d755d7b30c5fef8e6e6638466c9532b on nodeshift-starters:main.


ModifyEntryPlugin issue

Hi!
I have encountered an issue when calling  withModuleFederationPlugin with eager loading set to true:
TypeError: Cannot read properties of undefined (reading 'import')
    at D:\Projects\SomeProject\libs\mf\src\utils\modify-entry-plugin.ts:20:20
    at mergeEntry (D:\Projects\SomeProject\libs\mf\src\utils\modify-entry-plugin.ts:10:11)
    at cfgOrRemove (D:\Projects\SomeProject\libs\mf\src\utils\modify-entry-plugin.ts:13:22)
    at D:\Projects\SomeProject\libs\mf\src\utils\modify-entry-plugin.ts:18:12
    at Array.forEach (<anonymous>)
    at ModifyEntryPlugin.apply (D:\Projects\SomeProject\libs\mf\src\utils\modify-entry-plugin.ts:16:30)
    at createCompiler (D:\Projects\SomeProject\node_modules\webpack\lib\webpack.js:76:12)
    at create (D:\Projects\SomeProject\node_modules\webpack\lib\webpack.js:143:16)
    at webpack (D:\Projects\SomeProject\node_modules\webpack\lib\webpack.js:167:32)
    at Object.f [as webpackFactory] (D:\Projects\SomeProject\node_modules\webpack\lib\index.js:72:16)

I could figure it out that ModifyEntryPlugin cannot find 'style' entry in compiler.options.entry which is set in the createModifyEntryPlugin method in .\libs\mf\src\utils\with-mf-plugin.ts.
export class ModifyEntryPlugin {
  ....
  apply(compiler) {
    ...
   const mergeEntry = (keyFn, key) => [
      ...(keyFn(this.config[key]) || []),
      ...(keyFn(compiler.options.entry[key]) || []),        //<---------- Passes undefined if key is missing in compiler.options.entry
    ];
    const cfgOrRemove = (objFn, valueFn, key) => {
      const values = mergeEntry(valueFn, key);
      return values.length > 0 ? objFn(values) : {};
    };
    Object.keys(this.config).forEach((key) => {
      compiler.options.entry[key] = {        //<---------- No check if there is an entry for the key
        ...cfgOrRemove(
          (v) => ({ import: v }),
          (c) => c.import,                           //<---------- Error: Cannot read properties of undefined (reading 'import'). c is undefined
          key
        ),
        ...cfgOrRemove(
          (v) => ({ dependOn: v }),
          (c) => c.dependOn,
          key
        ),
      };
    });
    ......
}

Is it my project specifiic issue (some ts, compiler options) or does the ModifyEntryPlugin plugin need to be fixed to add key exists check ?
Thank you!

Seems the issue is originally caused by using nx builder @nx/angular:webpack-browser which removes 'styles' compilation option entry. Does it make sense to prepare a  fix to check if styles key exists as mentioned above?

The same for me in v15. As you said in this issue it's related to eager: true.
In my project there isn't @nx/angular:webpack-browser.

The same for me in v15. As you said in this issue it's related to eager: true. In my project there isn't @nx/angular:webpack-browser.

yes it could be it is valid only for ngx-build-plus builder. Anyway the provided fix handles it.

I removed ngx-build-plus builder and actually I'm using @angular-devkit/build-angular

Hi! Any news about bug fix?

@manfredsteyer any news about this? Thanks

@angular-builders/custom-webpack:browser have been using this to extend webpack and got the same issue.
It may work with ngx-build-plus - but it's outdated and does not support angular 18.


No need to convert string to string

Since uuid4() returns a string, we do not need to convert its return value to a string again.

good catch! :+1:


feat: allow optional idp arg into auth to allow provided auth role or authenticated identity

Description of changes

allow optional identity pool to be passed into auth transformer

this supports iam auth backed by a cognito identity pool (through amplify cli) this keeps all other authenticated identities with different arns to still be constricted to the same rules as private.

updated unit and e2e

Description of how you validated changes

[x] unit test
[x] local testing
[ ] e2e

Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #8609 (999d806) into master (4adb237) will increase coverage by 0.03%.
The diff coverage is 78.18%.

@@            Coverage Diff             @@
##           master    #8609      +/-   ##
==========================================
+ Coverage   57.14%   57.18%   +0.03%
==========================================
  Files         728      728
  Lines       41195    41219      +24
  Branches     8444     8449       +5
==========================================
+ Hits        23542    23572      +30
+ Misses      16841    16835       -6
  Partials      812      812

Impacted Files
Coverage Δ

...-graphql-auth-transformer/src/utils/definitions.ts
100.00% <ø> (ø)

...awscloudformation/src/graphql-transformer/utils.ts
32.60% <28.57%> (-0.36%)
:arrow_down:

...fy-graphql-auth-transformer/src/resolvers/query.ts
59.18% <50.00%> (ø)

...rc/graphql-transformer/transform-graphql-schema.ts
15.89% <50.00%> (-0.07%)
:arrow_down:

...-auth-transformer/src/resolvers/mutation.update.ts
84.61% <80.00%> (-0.72%)
:arrow_down:

...-auth-transformer/src/resolvers/mutation.create.ts
84.61% <83.33%> (-0.72%)
:arrow_down:

...-auth-transformer/src/resolvers/mutation.delete.ts
88.23% <83.33%> (-1.00%)
:arrow_down:

...y-graphql-auth-transformer/src/resolvers/search.ts
69.79% <83.33%> (-0.11%)
:arrow_down:

...l-auth-transformer/src/graphql-auth-transformer.ts
88.30% <100.00%> (+2.92%)
:arrow_up:

...fy-graphql-auth-transformer/src/resolvers/field.ts
73.91% <100.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4adb237...999d806. Read the comment docs.


Feature/brians first corrections

README made more exact about what we can expect from an output
train.py shortened (cut the universal section) and modified so that --overwrite_model will work
train.py flags changed names
notebook updated to import from deepuq

looks good to me.


Canal readiness probe failed with statuscode 503 for k8s 1.15

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
Create aws cluster with default options in Rancher 2.3.0
Result:
Once the cluster has been created, navigate to the System project, then click on Canal under the kube-system namespace.  Click on one of the canal pods then open up the Events tab.  Observe the Unhealthy warning for the readiness probe.  Screenshot pasted below of this behavior.

Logs from the calico-node container:
2019-10-14 18:44:22.732 [INFO][8] startup.go 256: Early log level set to info
2019-10-14 18:44:22.732 [INFO][8] startup.go 272: Using NODENAME environment for node name
2019-10-14 18:44:22.732 [INFO][8] startup.go 284: Determined node name: aws3
2019-10-14 18:44:22.734 [INFO][8] k8s.go 228: Using Calico IPAM
2019-10-14 18:44:22.734 [INFO][8] startup.go 316: Checking datastore connection
2019-10-14 18:44:22.744 [INFO][8] startup.go 340: Datastore connection verified
2019-10-14 18:44:22.744 [INFO][8] startup.go 95: Datastore is ready
2019-10-14 18:44:22.772 [INFO][8] startup.go 530: FELIX_IPV6SUPPORT is false through environment variable
2019-10-14 18:44:22.778 [INFO][8] startup.go 181: Using node name: aws3
2019-10-14 18:44:22.809 [INFO][15] k8s.go 228: Using Calico IPAM
CALICO_NETWORKING_BACKEND is none - no BGP daemon running
Calico node started successfully
2019-10-14 18:44:24.038 [WARNING][33] int_dataplane.go 354: Failed to query VXLAN device error=Link not found
2019-10-14 18:44:24.074 [WARNING][33] int_dataplane.go 384: Failed to cleanup preexisting XDP state error=failed to load XDP program (/tmp/felix-xdp-563577510): stat /sys/fs/bpf/calico/xdp/prefilter_v1_calico_tmp_A: no such file or directory
libbpf: failed to get EHDR from /tmp/felix-xdp-563577510
Error: failed to open object file
2019-10-14 18:44:44.432 [WARNING][33] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf614e671242a664, ext:20426272735, loc:(*time.Location)(0x2b08080)}}
2019-10-14 18:45:10.016 [WARNING][33] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf614e6d698916e9, ext:45816765016, loc:(*time.Location)(0x2b08080)}}
2019-10-14 18:47:04.432 [WARNING][33] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf614e8a10a0555d, ext:160398857927, loc:(*time.Location)(0x2b08080)}}
2019-10-14 18:47:24.432 [WARNING][33] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf614e8f04b5ad88, ext:180198930154, loc:(*time.Location)(0x2b08080)}}
2019-10-14 18:47:50.016 [WARNING][33] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf614e9568781150, ext:205798872324, loc:(*time.Location)(0x2b08080)}}
2019-10-14 18:49:44.432 [WARNING][33] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf614eb2118552ef, ext:320413865069, loc:(*time.Location)(0x2b08080)}}
2019-10-14 18:50:04.432 [WARNING][33] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf614eb704b6187f, ext:340198957640, loc:(*time.Location)(0x2b08080)}}
2019-10-14 18:50:30.017 [WARNING][33] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf614ebd687a5ed0, ext:365799023174, loc:(*time.Location)(0x2b08080)}}
2019-10-14 18:52:24.432 [WARNING][33] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf614eda118b4aee, ext:480414256219, loc:(*time.Location)(0x2b08080)}}
2019-10-14 18:52:44.432 [WARNING][33] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf614edf04b5d5b4, ext:500198940515, loc:(*time.Location)(0x2b08080)}}
2019-10-14 18:53:10.016 [WARNING][33] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf614ee568774cab, ext:525798821911, loc:(*time.Location)(0x2b08080)}}
2019-10-14 18:55:04.432 [WARNING][33] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf614f0210ad7f44, ext:640399720623, loc:(*time.Location)(0x2b08080)}}
2019-10-14 18:55:24.432 [WARNING][33] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf614f0705adeec1, ext:660215199869, loc:(*time.Location)(0x2b08080)}}
2019-10-14 18:55:50.017 [WARNING][33] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf614f0d687ee33d, ext:685799319221, loc:(*time.Location)(0x2b08080)}}

Other details that may be helpful:
This does not happen in Rancher v2.2.8
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): Rancher v2.3.0
Installation option (single install/HA): HA

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): AWS
Machine type (cloud/VM/metal) and specifications (CPU/memory): VM, t2.large
Kubernetes version (use kubectl version): 1.14.6

I hit this issue on my HA cluster after I upgrade rancher from v2.2.8 to v2.3.0. Kubernetes version 1.15.4. The cluster was deployed on bare metal.
kube-system | Warning | Unhealthy | canal-n82dt | Readiness probe failed: HTTP probe failed with statuscode: 503 | a minute ago
kube-system | Warning | Unhealthy | canal-sljs9 | Readiness probe failed: HTTP probe failed with statuscode: 503 | 2 minutes ago
kube-system | Warning | Unhealthy | canal-mdxhh | Readiness probe failed: HTTP probe failed with statuscode: 503 | 2 minutes ago
kube-system | Warning | Unhealthy | canal-w78sk | Readiness probe failed: HTTP probe failed with statuscode: 503 | 3 minutes ago
kube-system | Warning | Unhealthy | canal-wtgcq | Readiness probe failed: HTTP probe failed with statuscode: 503 | 3 minutes ago

I meet the same bug when I add a new node. The other node is not occured.

Please let me know if this solves the issue while we investigate further:
Save the following in crd.yml and execute kubectl create -f crd.yml in the cluster
---
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  name: ipamblocks.crd.projectcalico.org
spec:
  scope: Cluster
  group: crd.projectcalico.org
  version: v1
  names:
    kind: IPAMBlock
    plural: ipamblocks
    singular: ipamblock
---
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  name: networksets.crd.projectcalico.org
spec:
  scope: Namespaced
  group: crd.projectcalico.org
  version: v1
  names:
    kind: NetworkSet
    plural: networksets
    singular: networkset

I had the same bug with a fresh 2.3.0 install and kubernetes v1.15.4.
Creating the two CRDs seems to have fixed it
thanks!

It works for me.

I got these events on the one cluster, another cluster works well.
kube-system | Warning | Unhealthy | canal-cd924 | Liveness probe failed: Get http://localhost:9099/liveness: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers) | 3 minutes ago
kube-system | Warning | Unhealthy | canal-cd924 | Readiness probe failed: Get http://localhost:9099/readiness: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers) | 3 minutes ago
kube-system | Warning | Unhealthy | canal-tz42g | Readiness probe failed: Get http://localhost:9099/readiness: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers) | 8 minutes ago
kube-system | Warning | Unhealthy | canal-tz42g | Liveness probe failed: Get http://localhost:9099/liveness: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers) | 8 minutes ago
kube-system | Warning | Unhealthy | canal-8grhd | Liveness probe failed: Get http://localhost:9099/liveness: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers) | 21 minutes ago
kube-system | Warning | Unhealthy | canal-8grhd | Readiness probe failed: Get http://localhost:9099/readiness: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers) | 21 minutes ago
kube-system | Warning | Unhealthy | canal-68m67 | Liveness probe failed: Get http://localhost:9099/liveness: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers) | 34 minutes ago

The fix for this is patching the canal DaemonSet and creating the NetworkSet CRD (this will recreate Canal pods), this is use at your own risk until it gets verified and released (test envs only):
kubectl -n kube-system patch daemonset/canal -p '{"spec": {"template": {"spec": {"containers": [{"name": "calico-node", "env": [{"name": "USE_POD_CIDR", "value": "true"}]}]}}}}'

Save the following as crd.yml and run kubectl create -f crd.yml in the cluster:
---
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  name: networksets.crd.projectcalico.org
spec:
  scope: Namespaced
  group: crd.projectcalico.org
  version: v1
  names:
    kind: NetworkSet
    plural: networksets
    singular: networkset

@deniseschannon once verified and closed, we should release note the fact that the canal pods will get recreated in upgraded setups, on cluster edit.

The bug is reproduced in a cluster with k8s v1.15.5 in Rancher:v2.3.1
Once the cluster has been created, navigate to the System project, then click on Canal under the kube-system namespace. Click on one of the canal pods then open up the Events tab. Observe the Unhealthy warning for the readiness probe

Logs from the calico-node container:
2019-10-21 21:32:39.889 [WARNING][34] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf63a6dde84835bb, ext:102914726961, loc:(*time.Location)(0x2b08080)}}
2019-10-21 21:32:59.221 [WARNING][34] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf63a6e2b42d88f0, ext:122114305408, loc:(*time.Location)(0x2b08080)}}
2019-10-21 21:35:19.889 [WARNING][34] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf63a705e84342c5, ext:262914402646, loc:(*time.Location)(0x2b08080)}}
2019-10-21 21:35:39.221 [WARNING][34] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf63a70ab42df417, ext:282114332769, loc:(*time.Location)(0x2b08080)}}
2019-10-21 21:37:59.889 [WARNING][34] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf63a72de8418b71, ext:422914290197, loc:(*time.Location)(0x2b08080)}}
2019-10-21 21:38:19.221 [WARNING][34] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf63a732b42b3445, ext:442114152597, loc:(*time.Location)(0x2b08080)}}
2019-10-21 21:40:39.889 [WARNING][34] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf63a755e8461c18, ext:582914589332, loc:(*time.Location)(0x2b08080)}}
2019-10-21 21:40:59.221 [WARNING][34] health.go 190: Reporter failed readiness checks name="async_calc_graph" reporter-state=&health.reporterState{name:"async_calc_graph", reports:health.HealthReport{Live:true, Ready:true}, timeout:20000000000, latest:health.HealthReport{Live:true, Ready:false}, timestamp:time.Time{wall:0xbf63a75ab42dd4a5, ext:602114324717, loc:(*time.Location)(0x2b08080)}}```

The bug fix is validated in Rancher:v2.3-head 8d57a1c with the metadata from dev branch
add a cluster with k8s v1.15.5 with Canal
Results:

no unhealthy warning in the event of the pod canal
no [WARNING][34] in the logs of the container calico-node

For this issue, I can only reproduce it in k8s 1.15 cluster, although it is reported in 1.14 cluster originally.
@alena commented a cluster edit on an upgraded setup would trigger pods to be recreated. I did not upgrade Rancher but changed the metadata to dev, then I edited the cluster to trigger a rke up, but the pods were not recreated and the issue still existed.
So the issue is reopened for more investigation

Same here, I just updated the underlying cluster for Rancher to k82 v1.15.4. Rancher itself is still on 2.2.8

@roycec  Do you mean you upgrade the local cluster when installing Rancher in HA mode? This bug is about Rancher-provisioned clusters.
Also, the fix is in Rancher's metadata, so the only way to fix it is to upgrade Rancher and then upgrade the cluster.

The bug fix is validated in v2.3-head 6d40dad33 upgraded from v2.3.1
Steps:

run rancher v2.3.1
add an ec2 cluster with k8s v1.15.5 with Canal
see the readiness errors
upgrade Rancher to v2.3-head
notice the rke-metadata-config uses branch dev
edit the above cluster to upgrade it
the readiness error is gone

Hi Guys,
I just installed a new cluster with canal via rke and ran into this exact same bug using "latest" helm chart.
I just tried the "solution" which @superseb has kindly shared and can confirm this resolves the issue.
I have pasted the events log below for confirmation.
kube-system | Normal | Created | canal-wg6pv | Created container calico-node | 5 minutes ago
-- | -- | -- | -- | -- | --
kube-system | Normal | Started | canal-wg6pv | Started container calico-node | 5 minutes ago
kube-system | Normal | Pulled | canal-wg6pv | Container image "rancher/coreos-flannel:v0.11.0" already present on machine | 5 minutes ago
kube-system | Normal | Created | canal-wg6pv | Created container kube-flannel | 5 minutes ago
kube-system | Normal | Started | canal-wg6pv | Started container kube-flannel | 5 minutes ago
kube-system | Normal | Started | canal-wg6pv | Started container install-cni | 5 minutes ago
kube-system | Normal | Pulled | canal-wg6pv | Container image "rancher/calico-node:v3.7.4" already present on machine | 5 minutes ago
kube-system | Normal | Pulled | canal-wg6pv | Container image "rancher/calico-cni:v3.7.4" already present on machine | 5 minutes ago
kube-system | Normal | Created | canal-wg6pv | Created container install-cni | 5 minutes ago
kube-system | Normal | Scheduled | canal-wg6pv | Successfully assigned kube-system/canal-wg6pv to rmgr03 | 5 minutes ago
kube-system | Normal | Killing | canal-x2npx | Stopping container calico-node | 5 minutes ago
kube-system | Normal | Killing | canal-x2npx | Stopping container kube-flannel | 5 minutes ago
kube-system | Normal | SuccessfulDelete | canal | Deleted pod: canal-x2npx | 5 minutes ago
kube-system | Normal | SuccessfulCreate | canal | Created pod: canal-wg6pv | 5 minutes ago
kube-system | Normal | Created | canal-rw55m | Created container calico-node | 5 minutes ago
kube-system | Normal | Started | canal-rw55m | Started container calico-node | 5 minutes ago
kube-system | Normal | Pulled | canal-rw55m | Container image "rancher/coreos-flannel:v0.11.0" already present on machine | 5 minutes ago
kube-system | Normal | Created | canal-rw55m | Created container kube-flannel | 5 minutes ago
kube-system | Normal | Started | canal-rw55m | Started container kube-flannel | 5 minutes ago
kube-system | Normal | Pulled | canal-rw55m | Container image "rancher/calico-node:v3.7.4" already present on machine | 5 minutes ago
kube-system | Normal | Pulled | canal-rw55m | Container image "rancher/calico-cni:v3.7.4" already present on machine | 5 minutes ago
kube-system | Normal | Created | canal-rw55m | Created container install-cni | 5 minutes ago
kube-system | Normal | Started | canal-rw55m | Started container install-cni | 5 minutes ago
kube-system | Normal | Killing | canal-6xkx6 | Stopping container calico-node | 5 minutes ago
kube-system | Normal | Scheduled | canal-rw55m | Successfully assigned kube-system/canal-rw55m to rmgr01 | 5 minutes ago
kube-system | Normal | SuccessfulDelete | canal | Deleted pod: canal-6xkx6 | 5 minutes ago
kube-system | Normal | SuccessfulCreate | canal | Created pod: canal-rw55m | 5 minutes ago
kube-system | Normal | Started | canal-gsvht | Started container calico-node | 5 minutes ago
kube-system | Normal | Pulled | canal-gsvht | Container image "rancher/coreos-flannel:v0.11.0" already present on machine | 5 minutes ago
kube-system | Normal | Created | canal-gsvht | Created container kube-flannel | 5 minutes ago
kube-system | Normal | Started | canal-gsvht | Started container kube-flannel | 5 minutes ago
kube-system | Normal | Started | canal-gsvht | Started container install-cni | 5 minutes ago
kube-system | Normal | Pulled | canal-gsvht | Container image "rancher/calico-node:v3.7.4" already present on machine | 5 minutes ago
kube-system | Normal | Created | canal-gsvht | Created container calico-node | 5 minutes ago
kube-system | Normal | Pulled | canal-gsvht | Container image "rancher/calico-cni:v3.7.4" already present on machine | 5 minutes ago
kube-system | Normal | Created | canal-gsvht | Created container install-cni | 5 minutes ago
kube-system | Normal | Scheduled | canal-gsvht | Successfully assigned kube-system/canal-gsvht to rmgr02 | 5 minutes ago
kube-system | Normal | Killing | canal-lrzpb | Stopping container kube-flannel | 5 minutes ago
kube-system | Normal | SuccessfulDelete | canal | Deleted pod: canal-lrzpb | 5 minutes ago
kube-system | Normal | SuccessfulCreate | canal | Created pod: canal-gsvht | 5 minutes ago
kube-system | Warning | Unhealthy | canal-6xkx6 | Readiness probe failed: HTTP probe failed with statuscode: 503 | 6 minutes ago
kube-system | Warning | Unhealthy | canal-x2npx | Readiness probe failed: HTTP probe failed with statuscode: 503 | 6 minutes ago
kube-system | Warning | Unhealthy | canal-lrzpb | Readiness probe failed: HTTP probe failed with statuscode: 503 | 6 minutes ago
cattle-system | Normal | Pulled | cattle-cluster-agent-5768f46d46-l8v5w | Successfully pulled image "rancher/rancher-agent:v2.3.1" | 12 minutes ago
cattle-system | Normal | Created | cattle-cluster-agent-5768f46d46-l8v5w | Created container cluster-register | 12 minutes ago
cattle-system | Normal | Started | cattle-cluster-agent-5768f46d46-l8v5w | Started container cluster-register | 12 minutes ago
cattle-system | Normal | Created | cattle-node-agent-wf2w8 | Created container agent | 12 minutes ago
cattle-system | Normal | Started | cattle-node-agent-wf2w8 | Started container agent | 12 minutes ago
cattle-system | Normal | Created | cattle-node-agent-kljlt | Created container agent | 12 minutes ago
cattle-system | Normal | Started | cattle-node-agent-kljlt | Started container agent | 12 minutes ago

@jiaqiluo: I understand what you mean; I've an Rancher 2.2.8 HA installation and upgraded the RKE cluster (if the term is correct) to kubernetes 1.15.4 and got the same error than the original poster, but for the 'local' cluster. Should I open a new issue then?

@roycec sure, be free to open a new issue for it, and it looks like the rke: v0.3.2-rc2( https://github.com/rancher/rke/releases/tag/v0.3.2-rc2) should have the fix.


Align the cards showing preview of the books

Description:
There are cards on the homepage that have previews of books on them. Some are placed higher than the others. I would like to correct this issue. Kindly assign this to me @Karamraj under hacktoberfest and hacktoberfest-accepted labels.

@sp9324 Assigned.
Make sure to join the discord server of all contributors of this repo - https://discord.gg/7Ja25e3w

hii @Karamraj plz assign this issue to me,i would love to contribute on this issue


Update requires when file renamed

We should support automatically updating relevant requires when a file has been moved / renamed

Coming from other IDE's you typically have the option to specify whether or not you want to update imports after renaming/moving a file, is there a way to accomplish this via VSCode's API? Or would we simply introduce a setting to toggle this on/off?

Yeah, I have also seen this, but I'm not sure how it's done. I know the typescript extension does it.
The main thing is it needs to be asynchronous - we should not block the whole LSP loop whilst waiting for the user to pick whether they want to update or not.
Note there is a window/showMessageRequest request: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showMessageRequest which can be sent on textDocument/didRenameFiles, and we can send a workspace/applyEdit request for changes.
There is also textDocument/willRenameFiles where the server can respond with text edits immediately instead, but if we wait on user input this will be blocking

For detecting files where we need to update the rename, note that Luau has a Frontend::markDirty method (https://github.com/Roblox/luau/blob/edb445392441582b722026dbfabed86706d6750d/Analysis/src/Frontend.cpp#L778) which populates a vector with the reverse deps/dependees that were also marked dirty (i.e. the files that required this file)
If we mark dirty the old module name (before rename), we can get this list. An important note however is that it only resolves reverse deps that the type checker has indexed and knows about (i.e. frontend.check was called on that module). By default, we do not do this except when computing workspace diagnostics, so we would need to make sure everything is indexed before computing reverse deps

Turns out this problem is more difficult than expected, due to the race condition between a file being renamed and the sourcemap being updated. We need the sourcemap to be updated before we receive the rename event to be able to track what the new path to the file should be


Sometimes depth stream blocked on single-frame pipe

Required Info

Camera Model
{ D400 }

Operating System & Version
{Ubuntu 20}

Issue Description
A simple code of this kind sometimes (perhaps after hundreds or thousands of iterations) blocks the depth stream and prevents new frames from being received
//config enabled only depth stream
pipe->start(*config);
pipe->wait_for_frames();
pipe->stop();

In realsense viewer, if you enable the display of depth frames, you will see the message "No frames recieved"
The only thing that helps is the physical plugging of the wire.
I checked on several different sensors and wires.
Is there any way to avoid this behavior?

How does it behave if you use a frames variable with wait_for_frames() and then use the keep() instruction to store the frames in the computer's memory?
//config enabled only depth stream
pipe->start(*config);
frames = pipe->wait_for_frames();
frames->keep();
pipe->stop();

Hi @reuksv How does it behave if you use a frames variable with wait_for_frames() and then use the keep() instruction to store the frames in the computer's memory?
//config enabled only depth stream
pipe->start(*config);
frames = pipe->wait_for_frames();
frames->keep();
pipe->stop();

Hello @MartyG-RealSense
No changes have occurred.

I would next recommend using an Ubuntu system monitoring tool such as htop to monitor the available memory on the computer whilst the program is running and see whether it is progressively declining over time as the program repeatedly iterates.  Such a reduction is known as a memory leak and can result in a program becoming unstable or crashing once the free memory becomes low enough.

Does the issue still occur if you put a value in the brackets of the wait_for_frames instruction such as 1000?
pipe->wait_for_frames(1000);

The problem still remains

How does the program behave if the stop instruction is commented out and the pipeline is permitted to run continuously without multiple start-stops?

Works good

If your project requires repeated start-stop cycles instead of running continuously then you could try putting a short sleep command before the pipe start line to see whether a small time wait before starting the pipeline also helps to reduce the likelihood of a problem occurring.

The problem still remains

Next, please try placing a camera reset instruction before the pipe start line in your script using the Python code below.  This should have the same effect as performing an unplug-replug of the USB cable.
ctx = rs.context()
devices = ctx.query_devices()
for dev in devices:
dev.hardware_reset()

Hi @reuksv  Do you require further assistance with this case, please?  Thanks!

@MartyG-RealSense Unfortunately, I haven't had time to check the last tip yet. Please do not close the ticket yet

It's no problem at all to keep it open.  Thanks very much for the update!

Hi @reuksv  Do you require further assistance with this case, please?  Thanks!

Thank you. I think hardware reset should help, but I managed to test it only in the realsense viewer interface. You can close the ticket.


How to change cursor on feature hover

I'm trying to change cursor on feature hover but I didn´t find the way. This is my code, but doesn´t work:
$scope.$on('openlayers.map.pointermove', function (e, data) {
            $scope.$apply(function () {
                OlData.getMap().then(function (map) {
                    var pixel = map.getEventPixel(data.event);
                    var hit = map.hasFeatureAtPixel(pixel);

                    map.getTarget().style.cursor = hit ? 'pointer' : '';
                });
            });
        });

Has someone face this problem?

Just checking - did you make sure to register the event? Observing the event doesn't do anything unless you have a matching event listing in your scope:

events: {
    map: [ 'pointermove', 'singleclick' ]
}

Check the examples - in the repo not the io site - any of the ###-events-*.html examples might help.

Yeah, I've got them registered:
events: {
                map: ['pointermove', 'mousemove'],
                layers: ['mousemove', 'click'],
                markers: []
            }

...but not working

Finally I've got it. The problem is that var 'hit' return only as true or as undefined. I copy part of the code, maybe it  could help somebody:
$scope.$on('openlayers.map.pointermove', function (e, data) {
            $scope.$apply(function () {
                OlData.getMap().then(function (map) {
                    var pixel = map.getEventPixel(data.event.originalEvent);
                    var hit = map.forEachFeatureAtPixel(pixel, function (feature, layer) {
                        map.getTarget().style.cursor = 'pointer';
                        /// here you can do things like showing a popup on feature hover
                        return true;
                    });

                    if (typeof hit === 'undefined') {
                        map.getTarget().style.cursor = 'move';
                        return;
                    }
                });
            });
        });

this.map.on('pointermove', (e) => {
  const pixel = this.map.getEventPixel(e.originalEvent);
  const hit = this.map.hasFeatureAtPixel(pixel);
  document.getElementById('map').style.cursor = hit ? 'pointer' : '';
});

}


Add orElse

Add an orElse function for chaining together a series of Result-producing functions when you want the first Ok.
See "orThen for Result / Maybe" on elm-discuss:
https://groups.google.com/forum/?fromgroups#!topic/elm-discuss/Qj5WQ47TS3c

I have the same criticism here as for the corresponding proposal in Maybe.Extra: https://github.com/elm-community/maybe-extra/pull/20#issuecomment-241694733.

Alternative proposal: https://github.com/elm-community/result-extra/pull/12.

Merged the alternative proposal for consistency with maybe-extra.


Changes to Add names of Datasets "to be Downloaded" instead of "Not to be downloaded"

Instead of giving the input of what all datasets we don't want to download, we can give a simple input of what datasets we want to download. Below is the changes in the code I have made. Below code snippets are from dashboard_script.py (Explanation included as comments in the snippets)

This is basically a test script, correct?
This will enable you test few dataset and mark them as working or not.
Have you looked into the Postgres spatial dataset testing

Thank you for the contribution @RishikaBhatia17. We are closing this since we have some new developments on the project.


YellowBox warning from TabView/Pager component during tests

Current behaviour

The library appears to work as expected on an emulator.  However, during tests, there is YellowBox error (which I know how to solve) and two YellowBox warnings that get thrown from the Pager component:

I think this is caused by the interaction between those components and react-native-reanimated's mock, but I haven't been able to solve the problem.
Expected behaviour

I'd like for these warnings/errors to not appear during the testing process.

Code sample
For Syntax Highlighting check this link
App.js
import React, {useState} from 'react';
import {View, Dimensions} from 'react-native';

import {TabView, SceneMap, TabBar} from 'react-native-tab-view';

const FirstRoute = () => (
  <View style={{ backgroundColor: '#ff4081' }} flex={1} />
);

const SecondRoute = () => (
  <View style={{ backgroundColor: '#673ab7' }} flex={1} />
);

const App = () => {
  const [index, setIndex] = useState(0);
  const [routes] = useState([
    { key: 'first', title: 'First' },
    { key: 'second', title: 'Second' },
  ]);

  const renderScene = SceneMap({
    first: FirstRoute,
    second: SecondRoute,
  });

  const navigationState = {index, routes};

  const initialLayout = { width: Dimensions.get('window').width };

  return (
    <View flex={1}>
      <TabView
        renderScene={renderScene}
        initialLayout={initialLayout}
        navigationState={navigationState}
        onIndexChange={setIndex}
        renderTabBar={props => ( // unnecessary, this is the default implementation
          <TabBar {...props} />
        )}
      />
    </View>
  );
}

export {App};

package.json
{
  "name": "reactNativeTabViewIssue",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "android": "react-native run-android",
    "ios": "react-native run-ios --port 3000 --simulator 'iPhone 8 Plus'",
    "start": "react-native start --port 3000",
    "test": "jest",
    "lint": "eslint .",
    "postinstall": "react-native-port-patcher --new-port 3000 --path node_modules/react-native"
  },
  "dependencies": {
    "react": "16.9.0",
    "react-native": "0.61.5",
    "react-native-gesture-handler": "^1.6.0",
    "react-native-port-patcher": "^1.0.4",
    "react-native-reanimated": "^1.7.0",
    "react-native-tab-view": "^2.13.0",
    "typescript": "^3.7.5"
  },
  "devDependencies": {
    "@babel/core": "^7.6.2",
    "@babel/runtime": "^7.6.2",
    "@react-native-community/eslint-config": "^0.0.5",
    "@testing-library/react-native": "^5.0.3",
    "babel-jest": "^24.9.0",
    "eslint": "^5.16.0",
    "jest": "^24.9.0",
    "metro-react-native-babel-preset": "^0.56.0",
    "react-test-renderer": "16.9.0"
  },
  "jest": {
    "preset": "@testing-library/react-native",
    "setupFiles": [
      "react-native-gesture-handler/jestSetup.js",
      "./setupTests.js"
    ]
  }
}

setupTests.js
// in the react-native-reanimated docs as the recommended way to mock this module.  Has to be done,
// otherwise other modules in the project fail spectacularly during tests.
jest.mock('react-native-reanimated', () => require('react-native-reanimated/mock'));

tests/App-test.js
/**
 * @format
 */

import 'react-native';
import React from 'react';
import {App} from '../App';

// Note: test renderer must be required after react-native.
import {render} from '@testing-library/react-native';

it('renders correctly', () => {
  render(<App />);
});

Then npm test causes the error/warning output in the above screenshots.

https://github.com/frantjc/react-native-tab-view-issue
Screenshots (if applicable)

What have you tried

I've tried to parse the Pager/TabView components' source to find where the source is using the mocked modules in a way that causes the issues and changing the mock implementations to no avail.
Your Environment

software
version

ios or android
both

react-native
0.61.5

react-native-tab-view
2.13.0

react-native-gesture-handler
1.5.3

react-native-reanimated
1.7.0

node
10.19.0

npm or yarn
npm 6.13.7

I was able to mock this:
import React from 'react';
import { View } from 'react-native';

const MockPager = ({ children }: any) => {
  return children({
    position: 0,
    addListener: jest.fn(),
    removeListener: jest.fn(),
    jumpTo: jest.fn(),
    render: (children: any) => <View>{children}</View>,
  });
};

const getPager = (props: any) => <MockPager {...props} />;

export default getPager;

@doomsower Thanks!! I'll give this a shot and report back here about how it works/any changes I need to make to it.

@doomsower How did you solve this issue?

I was able to mock this:
import React from 'react';
import { View } from 'react-native';

const MockPager = ({ children }: any) => {
  return children({
    position: 0,
    addListener: jest.fn(),
    removeListener: jest.fn(),
    jumpTo: jest.fn(),
    render: (children: any) => <View>{children}</View>,
  });
};

const getPager = (props: any) => <MockPager {...props} />;

export default getPager;

Thanks for the mock @doomsower !  How did you implement the mock?  I'm stuck on the same error and am not sure where to include the mock

Thanks for the mock @doomsower ! How did you implement the mock? I'm stuck on the same error and am not sure where to include the mock

MyTabs is multi-tab form to be tested.
./MyTabs.tsx:
import getPager from './getPager';

//...

const MyTabs = () => {
  return (
    <Tab.Navigator
      {...props}
      pager={getPager}>
         {/*Whatever*/}
    </Tab.Navigator>
  );
};

./getPager.tsx (real pager):
import { TabViewProps } from 'react-native-tab-view';

const getPager: TabViewProps<any>['renderPager'] | undefined = undefined;

export default getPager;

./__mocks__/getPager.tsx (mock pager):
import React from 'react';
import { View } from 'react-native';

const MockPager = ({ children }: any) => {
  return children({
    position: 0,
    addListener: jest.fn(),
    removeListener: jest.fn(),
    jumpTo: jest.fn(),
    render: (childrn: any) => <View>{childrn}</View>,
  });
};

const getPager = (props: any) => <MockPager {...props} />;

export default getPager;

./__tests__/form.tsx:
jest.mock('../getPager');

// tests that render MyTabs

This should fix it: https://github.com/satya164/react-native-tab-view/pull/1081


Abort callback

Provide option to pass callback function which will be called just like the stream callback to abort the translation if true returned and keep it if false returned

You can pass an optional callback as an argument to Translator::batch_translate, etc. If the callback returns an error, the translation will be aborted. I think it’s better than returning a boolean value because callbacks can use ?.

You can pass an optional callback as an argument to Translator::batch_translate, etc. If the callback returns an error, the translation will be aborted. I think it’s better than returning a boolean value because callbacks can use ?.

Thanks! I didn't know it was possible to return an error; that sounds even better.
By the way, have you considered using bindgen for the bindings? I'm not an expert in that field, but using bindgen along with creating a ctranslate2-rs-sys crate seems cleaner. I was inspired by whisper-rs.

I tried bindgen, but if I’m not mistaken, it aims to integrate C libraries rather than C++ libraries. It looks like whisper.cpp provides C interface, so bindgen is a good option, while CTranslate2 provides only C++ interface. In this case, I think cxx works better.

I tried bindgen, but if I’m not mistaken, it aims to integrate C libraries rather than C++ libraries. It looks like whisper.cpp provides C interface, so bindgen is a good option, while CTranslate2 provides only C++ interface. In this case, I think cxx works better.

Bindgen works with cpp as well, as the project I mentioned whisper-rs is a bindings to whisper.cpp
Maybe using bindgen in long term in this project will help, I don't have much experience with it but look more promising.

The problem I encountered when I tried to use bindgen was that it didn’t support template classes in C++ yet (see also https://rust-lang.github.io/rust-bindgen/cpp.html#unsupported-features). CTranslate2 uses them. For example, Translator::translate_batch (https://github.com/OpenNMT/CTranslate2/blob/master/include/ctranslate2/translator.h) takes std::vector<std::vector<std::string>>, which is incompatible with bindgen so far, so we have to write a wrapper manually.
Once bindgen adds support for template classes, it might be easier to use.

I believe the question regarding the callback has been resolved, so I would like to close this issue.


The hash has been set but an error is still reported

{"detailMessage":"Transaction simulation failed: Blockhash not found","stackTrace":[]}