Prototype for Mimick-based memory recording

There are several parts in this change, which when combined, yield a better mechanism for memory measurements than we're currently using in this package.
Here's a breakdown of the components:

MimickMemoryManager - This class implements the benchmark::MemoryManager interface by using Mimick to stub out malloc, realloc, and free. Since Mimick is making changes that affect the whole executable, it should be noted that you should NEVER try to use more than one instance of this class at the same time. Internally, Mimick is using un-stubbed variants of these allocation functions it refers to as "vital". The MimickMemoryManager uses these same functions to do the actual allocation operations before recording the relevant statistics.
It should be noted that we are not currently using the benchmark::MemoryManager model for memory tracking in this package. We're collecting statistics in the test fixture and adding the results as "user counters". One of the biggest advantages of taking the approach presented here is that memory instrumentation isn't active during timing runs, whereas our current approach is impacting allocation performance during timing runs quite substantially.
MimickPerformanceTest - Unlike the currently used PerformanceTest fixture, this fixture isn't responsible for performing any memory recording. Instead, it's used to ensure that the MimickMemoryManager gets registered and unregistered for a particular run. From what I can tell, the Benchmark API makes it look like we're supposed to register the benchmark::MemoryManager before any of the tests run, meaning that all tests, whether they use fixtures or not, would have memory measurements enabled. This fixture essentially bends the API to act the way we're currently expecting memory measurements to be enabled.
Honestly, because this new implementation should work on all of our supported platforms, I'm tempted to instead introduce a custom version of libbenchmark_main.so that registers MimickMemoryManager for all of the tests, so everything always gets memory measurements and we don't have to use a fixture to turn it on. Unfortunately that's not possible at the moment because the benchmark main library needs to be SHARED, and libmimick.a was specifically compiled STATIC without PIC. We'd need a change to Mimick for sure, but it might be doable.
MemoryAwareConsoleReporter - The benchmark::ConsoleReporter implementation doesn't display any of the memory statistics. This isn't an enormous problem because the JSON reporter DOES include the memory statistics, so they'll get displayed in Jenkins anyway, but I think that seeing the statistics on the console is really important to local development. This implementation augments the run data, and if memory statistics are present, it fakes those statistics as user counters, which ARE displayed by benchmark::ConsoleReporter.
memory_aware_benchmark_main - The only way I could find to inject the MemoryAwareConsoleReporter was to re-implement BENCHMARK_MAIN manually. I don't see too much of a problem doing this, since the process is very straightforward, but there is a downside: the command line arguments include modifiers for the behavior of benchmark::ConsoleReporter, and the flags that get parsed from those arguments aren't exposed in the Benchmark API. Since I'm instantiating my custom reporter class manually, and I don't have the flags that Benchmark parsed, I can't communicate them to the reporter. This isn't a big deal because the flags only seem to affect formatting, and we haven't used them in the past. I'm pretty sure we don't actually have a way to affect those command line arguments without hard-coding them into ament_cmake_google_benchmark anyway.
mimick_utils - There are two things here that are used to improve Mimick's abilities. They might be candidates for cleanup and submission upstream.

mmk_wrapper and mmk_stub_create_wrapped are used to create a non-member function that uses a class instance passed through the Mimick stub's context to invoke a public member function on the instance. There is some pretty thick template code here, but I used it as a learning exercise to generalize the concept I had originally implemented manually for each of the three functions we needed to stub.
mmk_allocator is a simple C++ allocator that should redirect allocation operations directly to the Mimick "vital" allocation methods, thereby ensuring that those operations aren't redirected to stub functions. I'm using this to make sure that the pointer map that's used for allocation size tracking doesn't affect the memory statistics when it grows.

benchmark_malloc_realloc_mimick - This is really just a proof-of-concept to show that everything mentioned above is working, and measure the performance to compare with our current solution. Since it isn't using the add_performance_test macro, it's running on all platforms. It's mostly a copy/paste from benchmark_malloc_realloc, but I modified it to run a third test where the memory measurements are forced on, so that we can see how much overhead MimickMemoryManager is causing. Keep in mind that registering a benchmark::MemoryManager is not the same as starting it. Normally, the Benchmark test runner specifically starts the benchmark::MemoryManager to do a small number of runs that are not timed. In this "forced" test, I'm turning them on explicitly. That should never happen during typical use, but I wanted to see the performance.

I think we need to do two things before we can move forward here:

We need to decide whether we want to push for an upstream change to benchmark::ConsoleReporter to show the memory statistics or if we're OK with the current solution based on MemoryAwareConsoleReporter and memory_aware_benchmark_main.
We need to decide whether we want to continue using a fixture to enable/disable memory recording. If we opt to go down the path that benchmark::MemoryManager seems to be designed to do, where the memory statistics are always collected, we'll need to figure out how to get Mimick to play nice with SHARED libraries. The fixture-based approach doesn't strictly require that because unlike the libbenchmark_main replacement which must be SHARED, the fixture can be STATIC, but it might be nice to build the fixture as SHARED anyway.

Linux
Linux-aarch64
macOS
Windows

I had to drop the lock_guards because it appears that Microsoft's implementation performs heap allocation in the constructor or something, without any API for changing to the custom allocator. None of these function should be throwing exceptions anyway, so I just switched it to plain ol' lock()/unlock().
Also, the Microsoft implementation of std::map performs a heap allocation in the constructor (where the GNU implementation does not), and this happens long before Start() is ever called, so I needed to perform a Mimick operation just to get it to initialize it's "vital" functions. It would be nice if an explicit method existed to do this.
I'm still having issues with aborts in Windows in my local builds, but ci.ros2.org seems to show that it's working as expected in both Release and Debug modes. Maybe we need to update Visual Studio on icecube.

I also don't have any good feedback to provide about the two main questions you are seeking answers to. Unfortunately.
Tagging @hidmic to get his eyes on this PR to see if he had any general recommendations.

It might be helpful to run a benchmark with thousands of allocations to match creating/destroying a node to see if the pointer map is prohibitively expensive.

Good idea, I'll look into that. I'm not sure I have an alternative if it isn't - I don't see any other way to track the high water mark memory usage without it (unless I'm missing something obvious).

I don't see any other way to track the high water mark memory usage without it (unless I'm missing something obvious).

What about allocating sizeof(size_t) + size and using part of the allocated space for the highwater mark tracking? Then the on_malloc/on_realloc would just return ptr + sizeof(size_t)

Tagging @hidmic to get his eyes on this PR to see if he had any general recommendations.

There are four Mimick or mimick_vendor changes that would benefit this effort:

Ability to build a SHARED library. Mimick is explicitly STATIC, which I don't really care about, but it doesn't build with PIC, so it forces downstream artifacts to also be STATIC (again, unless I'm missing something obvious). Maybe it's a technical limitation that it needs to be static - I'm not sure.
Explicit initialization function. I need the "vial" functions to be initialized for the mmk_allocator to work. What I have right now is hacky - it would be nice if mmk_init was callable.
There are symbols getting defined when you include mimick.h. You can reproduce this by creating two empty cpp files that both #include "mimick.h" and try to compile them into the same executable or library. There is a symbol collision (only C++ - C works just fine).
The headers getting installed don't appear to have the right hierarchy. I would expect /opt/ros/rolling/include/mimick.h and /opt/ros/rolling/include/mimick/<others>.h so that I could compile the Mimick sample as-is. Right now, we're doing #include "mimick/mimick.h", where the sample makes it look like we should just #include <mimick.h>.

What about allocating sizeof(size_t) + size and using part of the allocated space for the highwater mark tracking? Then the on_malloc/on_realloc would just return ptr + sizeof(size_t)

We'd have to reverse it, but maybe. If we allocated sizeof(size_t) + ptr and stored the size BEFORE the allocation, and then whenever we get a free we subtract size_t from the pointer to figure how much memory we're about to free, we could do it without the map.
There's one huge catch though - if ANY memory is freed during the test that wasn't allocated during the test, we'll probably segfault. Which is really not ideal.

@brawner - we'd have to make explicit implementations for each platform, but this may be an option for getting rid of the map: https://stackoverflow.com/a/1281720
If you think about it though, our high water mark statistic is still going to get messed up if you try to free something that wasn't allocated when timing was enabled. The whole "pause recording" think could make it even worse. I'm not sure we can avoid at least maintaining a list of what allocations were performed while recording is enabled...

That's a pretty good concern I didn't fully think through. I agree that it gets tricky during paused recording. It might still have to allocate the space and just set the memory size to 0 so we know it's an untracked pointer. That doesn't solve the allocate before tracking and free during issue.
I'm not expecting std::map to be a problem for something less that 10,000 items though, just thought it would be good to get a rough handle on impact.

Another thing to think about is that we've talked about the need to filter memory recording based on which thread is performing the operation. Depending on exactly which way we implement this (i.e. allow-list or block-list of thread IDs), we'll probably have a std:;set that will need to be protected as well.

Hmm, not sure I follow you here. I can see #include "mimick/mimick.h" in the sample. This is something we did to please cpplint.

I didn't know we'd forked Mimick. I was looking at the upstream: https://github.com/Snaipe/Mimick/blob/87e9898ebc9f1644c00df74dc1b34bf20391661b/sample/strdup/test.c#L1-L2

I didn't know we'd forked Mimick.

Oh, yes. We did.
I should spend time submitting our changes upstream though...

After switching:

Linux
Linux-aarch64
macOS
Windows

Alright, this isn't working out to be quite as easy as I thought it would. In the main test case, stubbing the four memory functions works just fine, but it doesn't appear to work in all cases. I tried running the downstream benchmarks for other packages with this change, and the stubbing fails with -ENOENT. It appears to do this across all platforms.
I tried a rather contrived change to iterate over each of the loaded libraries and specifically tried stubbing the memory functions in each one, but that seemed to be a little TOO aggressive. I had to specifically skip libstdc++.so to avoid failing memory operations. Additionally, there are failing alignment assertions coming out of Fast-DDS somewhere - I expect that there was a special allocation function that got stubbed and re-routed to the real allocation function that wasn't imposing the same constraints.
I'm not really sure where to go from here. Maybe Mimick isn't suited to do what we want it to here.


Remove tab control on demo form

Remove the Tab control with pages for "Default approach" and "Special approaches".
The special approaches are no longer valid and have been removed.

Released with version 4.07.05


Don't load the entire file into memory to hash it

The hash_file function could stream the file into the hasher rather than reading the entire file into memory first.

Need TODO

[ ] fs::read need support Rust Async

Currently,new version published, please use try_async_digest function replace of hash_file  function.
sha256 = "1.2.0"

@LoganDark Thx .


VM bug: Storage change not saved

I discovered a strange behaviour in this code:
contract EtherTokenContract {

    mapping (address => uint256) balances;
    mapping (address => mapping (address => uint256)) allowed;

    function buyTokens(address buyer, uint amount) returns (bool) {
        balances[buyer] += amount;
        return true;
    }

    function transferFails(address from, address to, uint256 value) returns (bool) {
        // Protect against wrapping UINTs.
        if (balances[from] >= value && (balances[to] + value) > balances[to]) {
            balances[from] -= value;
            balances[to] += value;
            return true;
        }
        return false;
    }

    function transferWorks(address from, address to, uint256 value) returns (bool) {
        if (balances[from] >= value) {
            balances[from] -= value;
            balances[to] += value;
            return true;
        }
        return false;
    }

    function approve(address owner, address spender, uint256 value) returns (bool success) {
        allowed[owner][spender] = value;
        return true;
    }

    function balanceOf(address owner) constant returns (uint256 balance) {
        return balances[owner];
    }
}

When executing transferWorks and transferFails both return True but only TransferWroks changes storage:
        self.bug_contract.buyTokens(1, 100)
        self.assertEqual(self.bug_contract.balanceOf(1), 100)
        # transfer works
        self.bug_contract.approve(1, 2, 100)
        self.assertEqual(self.bug_contract.transferWorks(1, 2, 100), True)
        self.assertEqual(self.bug_contract.balanceOf(1), 0)
        self.assertEqual(self.bug_contract.balanceOf(2), 100)
        # transfer fails
        self.bug_contract.approve(2, 1, 100)
        self.assertEqual(self.bug_contract.transferFails(2, 1, 100), True)
        print self.bug_contract.balanceOf(1) # Bug: still == 0
        print self.bug_contract.balanceOf(2) # Bug: still == 100
        self.assertEqual(self.bug_contract.balanceOf(1), 100)
        self.assertEqual(self.bug_contract.balanceOf(2), 0)

Code was tested in the JS VM. It works in the JS VM.

I found out that this error is not in PyEthereum but in the Solidity optimizer. This code cannot work in PyEthreum, because the Solidity wrapper always uses the optimizer.


[Feature Request] Mastodon-compatible social link for verification

According to the official Mastodon docs, you can verify a given website link is yours by adding the rel="me" flag to a link directly back to your Mastodon profile. I feel that this should be either the default or a toggleable option, since it seems rather straightforward to implement and would be a pretty nice thing to work out-of-the-box.

it already does this... i think i have brain damage
sorry


Support for Stable Diffusion 3.5 Large

I tried updating the hf repo to 3.5 Large but its not working.
Error: cannot find tensor text_encoders.clip_l.transformer.text_model.embeddings.token_embedding.weight

See #2578

This is working on A100. Takes too much memory for RTX4000 with 20GB.
I see there is a quantized gguf
https://huggingface.co/city96/stable-diffusion-3.5-large-gguf
is it possible currently to use this gguf quantized model?
also is it possible to use safetensors style quantized models..
thanks.

I see in the readme of SD3 there is a benchmark running a RTX 3090 Ti. how much memory does that card have. seams like 35 takes 40 plus GB to run in candle...

I made a few tweaks in #2581 and #2582 and with that it seems to use 20.9GB of memory, fwiw a 3090 Ti has 24GB so it should run there.

great work.
its running so great on the A100.
there seams to be a memory spike when it loads the T5 into F32 which pushes it over the limit for the 20GB RTX4000 on my desktop.

I've pushed some further changes in #2589 so that the f32 conversion is done on the flight rather than upfront so that we can benefit from the reduced memory usage while retaining full precision. After this, the memory usage I get from nsys during the text encoding step is done to ~10.5GB. That said, I still see the memory usage getting to ~20GB while running the mmdit so not that likely to fit on a 20GB gpu.

Amazing how much space is saved with the F16 on the T5. And it's only using 17GB during the sampling!
And im happy to report that it is working on RTX4000 with with 20GB.
Sampling done. 28 steps. 79.60s. Average rate: 0.35 iter/s
It's also working on M3. though very slow. Same image takes around 20 Minutes on M3 with 36GB
Rad work! thanks.


How to write tests for app using webchat and rasa

I would like to find a way to write test scripts to test the functioning of a story when interacting through webchat. Does anyone have any hints?
Thanks

You should check seleniun webdriver


[Hacktoberfest] Java | Single and Ready to Mingle #175

Language
C# .Netcore
Challenge
Single and Ready to Mingle #175

Sorry for the delay this should be good now.


Add Swedish Translations

Hello! Bjorkan from Sweden here!
Added
This PR adds Swedish Translation to the mod! I was told to only post here and not on the fabric one aswell :)
Other info
I have tested building it and everything seemed to render just fine! Great work you guys are doing! Keep it up!
Wish you all the best!
/Bjorkan

Thanks for your contribution!


Add models file to start project generator

#5

I don't think the model should actually be defined though. How about just having a comment with
# Create your models here. Documentation can be found here:
# https://brinkframework.github.io/brink/models.html

The model included in the pull request is commented out. Only the two imports of Model and fields are actual code so I don't think sync-db would trigger anything. But do you think we should omit the imports as well?
I do think that your suggestion for comment is good though.

Right sorry, didn't see that. It's a doc comment so probably not appropriate for this purpose, use # instead in that case. But again I vote for just referencing the docs.

@e0 please fix this if you want me to merge the PR.

I will close this, and make a new PR since I have push access now.


Implement proper logging

As well as creating text files with the list of missing items for each recipe.

Is there any indication of when you'll have time to do the "list of missing items for each recipe" if we could get a list saved then we can come up with our own method of taking that list and getting the items on there.


Provide a shared library

Please add a target into the Makefile to compile a shared library object.

Thanks in advance for any reply.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 9 Aug 2011 at 12:57

Thanks for your suggestion quadris! Do you have a patch to make this happen or
would you be interested in making one?

Original comment by<EMAIL_ADDRESS>on 10 Aug 2011 at 9:11

Thanks for the quick reply!

OK, I'll prepare a patch ASAP, it should be ready within few days.

As an aside, I've uploaded leveldb to Debian unstable and now waiting to see it
joining sid, check this URL for more information about the status:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636695

Original comment by<EMAIL_ADDRESS>on 10 Aug 2011 at 10:41

It would be great if this patch was to be committed. For what it's worth, it's
being shipped with OpenBSD's leveldb port.

Original comment by<EMAIL_ADDRESS>on 1 Nov 2011 at 8:32

Hi,

sorry for the delay.

You find the patch attached, it's written against the most recent snapshot:
36a5f8e

Original comment by<EMAIL_ADDRESS>on 8 Nov 2011 at 2:04
Attachments:

0010-shared_object.patch

Hi there - apologies for having let this issue linger so long.

I've reached out to quadris for a new patch based on a more recent LevelDB
version, and for the CLA so we can patch this in.

Gabor

Original comment by<EMAIL_ADDRESS>on 1 Nov 2011 at 6:50

Changed state: Accepted

A patch is attached. Please note it might need some testing.

Original comment by<EMAIL_ADDRESS>on 11 Aug 2011 at 7:49
Attachments:

1001-buildsystem.patch

Also, I'm willing to rework this patch. Two things that suck:
SHARED_INSTALL_PATH could probably be INSTALL_PATH and I was not able to figure
out how to pass along the SHARED_MAJOR and SHARED_LIBRARY variables to
build_detect_platform script, so there is some duplication.

Original comment by<EMAIL_ADDRESS>on 15 Jan 2012 at 8:42

Here's an updated version of the patch. Two changes occured.

1) -f has been added to the ln commands that create the shared library
symlinks. Without this, users were prevented from rebuilding the shard library
with all without first running clean.

2) SHARED_INSTALL_PATH has been renamed to INSTALL_PATH. It's still not ideal,
but I can't recall what the typical convention is for this.

Original comment by<EMAIL_ADDRESS>on 16 Jan 2012 at 11:17
Attachments:

shared_library.patch

Hi quadris, your patch to not override CFLAGS, etc. has been landed.

The code to build a shared library isn't portable (wouldn't work on Mac OS X
for example), so I did not commit it. We need to figure out a portable way to
do this.

Original comment by<EMAIL_ADDRESS>on 14 Nov 2011 at 5:25

Hi, I've rigged up the shared library patch to work on OS X and Linux and
attached it here. I don't have a Sun or FreeBSD machine to test it on.

There a CLA I need to sign or some such? (I freely give over my rights to this
code, in case there isn't a CLA.)

Original comment by<EMAIL_ADDRESS>on 15 Jan 2012 at 8:39
Attachments:

shared_library.patch

Here's another version with the recent changes to build_detect_platform merged
in, and an install target added.

Original comment by<EMAIL_ADDRESS>on 11 Feb 2012 at 5:04
Attachments:

shared_library.patch

Here's an updated version of the patch against the latest HEAD. It also adds
passing LDFLAGS when building the shared lib, otherwise linking against snappy
would fail.

Original comment by<EMAIL_ADDRESS>on 17 Mar 2012 at 8:32
Attachments:

shared_library.patch

The attached patch fixes the SONAME, which should not include any path.

Original comment by<EMAIL_ADDRESS>on 13 Apr 2012 at 9:44
Attachments:

0111-soname_fix.patch

Updated again against master. This is a much cleaner version thanks to the
recent changes in build_detect_platform.

It also includes Kim's addition of LDFLAGS to the shared library target. I hope
I didn't miss any other changes.

Original comment by<EMAIL_ADDRESS>on 25 Mar 2012 at 3:09
Attachments:

shared_library.patch

Is there anything that prevents this from being merged upstream? Bindings
authors (such as myself) would appreciate.

Original comment by<EMAIL_ADDRESS>on 17 Mar 2012 at 5:53

Please apply the as-needed patch attached to issue #57 too.

Original comment by<EMAIL_ADDRESS>on 13 Apr 2012 at 9:45

Moreover, this adds an 'install' target to the Makefile.
Thanks for considering.

Original comment by<EMAIL_ADDRESS>on 13 Apr 2012 at 9:49
Attachments:

0112-makefile_install.patch

Explain the removal of the INSTALL_PATH for me, please? Without it, I'm unable
to build and use the library in place on OS X.

dyld: Library not loaded: libleveldb.dylib.1
  Referenced from: /var/folders/r_/64kn6_z15s580w27scg2z1lw0000gn/T/go-build810548351/github.com/jmhodges/levigo/_test/levigo.test
  Reason: image not found

Original comment by<EMAIL_ADDRESS>on 22 Sep 2012 at 6:01

A future release will fix the SONAME problem. Thanks.

We explicitly decided not to put installation support in Makefile since it
can vary widely across different platforms/users and we don't want the
Makefile to get cluttered with confusing/conditional/customizable rules for
installation.

Original comment by<EMAIL_ADDRESS>on 17 Apr 2012 at 9:22

That should be `install_name_tool -id ${INSTALL_PATH}/libleveldb.dylib.1
libleveldb.dylib.1`, of course.

Original comment by<EMAIL_ADDRESS>on 22 Sep 2012 at 6:48

We can leave it out, but OS X needs `PLATFORM_SHARED_LDFLAGS="-dynamiclib
-Wl,-headerpad_max_install_names,-install_name,"` set in build_detect_platform
and an install target to call  out to `install_name_tool -id
/Users/jhodges/projects/leveldb/libleveldb.dylib.1 libleveldb.dylib.1`

That or we special case OS X to get the INSTALL_PATH and added it to
PLATFORM_SHARED_LDFLAGS and include it in build_detect_platform. Currently,
INSTALL_PATH is not visible to build_detect_platfrom.

Original comment by<EMAIL_ADDRESS>on 22 Sep 2012 at 6:23

Fixed in 1.7.0.

Original comment by<EMAIL_ADDRESS>on 16 Oct 2012 at 11:32

Changed state: Fixed


When proxy connections to HTTPS backend, nginx-ingress cannot pick up new certificate

Bug description:
Configured the ingress following this demo, and it worked for a period of time https://release-v0-11.docs.openservicemesh.io/docs/demos/ingress_k8s_nginx/.
After 24-25 Hrs, Error similar below in nginx logs can be seen
37#37: *2025387 SSL_do_handshake() failed (SSL: error:14094415:SSL routines:ssl3_read_bytes:sslv3 alert certificate expired:SSL alert number 45) while SSL handshaking to upstream, client: <IP_ADDRESS>, server: name1.example.com, request: "GET /httpbin/get HTTP/2.0", upstream: "https://<IP_ADDRESS>:14001/get", host: "name1.example.com"
Affected area (please mark with X where applicable):

Install                    [ ]
SMI Traffic Access Policy  [ ]
SMI Traffic Specs Policy   [ ]
SMI Traffic Split Policy   [ ]
Permissive Traffic Policy  [ ]
Ingress                    [X ]
Egress                     [ ]
Envoy Control Plane        [ ]
CLI Tool                   [ ]
Metrics                    [ ]
Certificate Management     [ ]
Sidecar Injection          [ ]
Logging                    [ ]
Debugging                  [ ]
Tests                      [ ]
Demo                       [ ]
CI System                  [ ]

Expected behavior:
nginx proxy the traffic as usual
Steps to reproduce the bug (as precisely as possible):
Just follow the demo page
How was OSM installed?:
AKS add on
Anything else we need to know?:
Bug report archive:

Environment:

OSM version (use osm version): 0.11.1
Kubernetes version (use kubectl version): 1.20.7
Size of cluster (number of worker nodes in the cluster):
Others:
tested with nginx-ingress 0.42.0, 0.50.0, and 1.1.0

Hi @ksooner, I have been chasing this same problem and just filed this GitHub Issue: #4394
@ksooner, if you have a cluster on which you can repro this - would you be so kind to perform the following:

save the mTLS secret locally
delete the mTLS secret from the cluster
reapply the same secret (which we saved locally in 1) back - without any modifications.

Here is a script to do this:
#!/bin/bash

FN=osm-nginx-client-cert.temp.crt
kubectl get secrets -n ingress-nginx osm-nginx-client-cert -o yaml > $FN
kubectl delete secrets -n ingress-nginx osm-nginx-client-cert
kubectl apply -f $FN

The script assumes the k8s secret is in namespace ingress-nginx and is called osm-nginx-client-cert - please change these to match your setup.
Here is an issue we filed against NGINX Ingress Controller on this issue:  https://github.com/kubernetes/ingress-nginx/issues/5608

This is an issue in Nginx ingress controller that is now addressed, see https://github.com/kubernetes/ingress-nginx/issues/5608.
There is an open issue (https://github.com/openservicemesh/osm/issues/4394) to work around this in OSM.
Closing this one as it's a combination of the 2 issues listed above, both of which are tracked.


"Nișcov", "Săsenii Noi", "Săsenii pe Vale", "Săsenii Vechi" and "Zorești" are listed in the drop-down menu

Description:
"Nișcov", "Săsenii Noi", "Săsenii pe Vale", "Săsenii Vechi" and "Zorești" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Nișcov" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Nișcov, BUZĂU (Vernești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Săsenii Noi" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Săsenii Noi, BUZĂU (Vernești)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Săsenii pe Vale" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Săsenii pe Vale, BUZĂU (Vernești)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Type "Săsenii Vechi" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Săsenii Vechi, BUZĂU (Vernești)".

Step 8
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 9
Type "Zorești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Zorești, BUZĂU (Vernești)".


Mb.py Bug fix

https://github.com/meower-community/MeowerBot.py/releases/tag/2.4.6

outdated https://github.com/meower-community/MeowerBot.py/releases/tag/2.5.0


App Crash when press "take a picture"

App Crash without error when press "take a picture". Using latest version of the library in react native version 0.61.5. I'm using the sample code given in readme.

Found issue


Add runtime_events to the list of libraries bundled with OCaml

Otherwise, you get errors like this:
WARNING: can't find opam package providing "runtime_events"!
eio.opam: changes needed:
  "runtime_events" {>= "0"}                [from lib_eio/runtime_events]

Thanks.


Feature request: Volume and recording with the remote command

Is it possible to add volume control during playback with the romote command?
I would like to control phiola a bit from my app. This also applies to the smooth change between playing and recording.
Then I could replace the entire Mediactrl in my app with phiola.

Hi!
In v2.2.8 you can change the currently played track's volume level, e.g. to set 50% volume:
phiola remote volume 50

Thank you very much. Setting the volume works well.

Is there something else here to do?

This also applies to the smooth change between playing and recording.

I'm not sure I understand what you mean by that.

In order to control phiola from another app, you would need to be able to call up certain functions remotely. This includes adjusting the volume (done), changing the playback position and switching from playing to playing and recording, as well as stopping the recording without interrupting playback.
I could also possibly record via a second task.

changing the playback position

This can be done.

switching from playing to playing and recording

In this case it's just better to start a new process for recording and control it separately.  Turning phiola's remote command into a complete client-server would require too much work for a low advantage.  Instead, I can add a new option for setting a system pipe name (so that the remote commands for 2 processes don't overlap).

This can be done.

Thanks a lot.

So in other words you want to switch between two modes by some remote command without breaking the output sound?
Something like this, only in the same process:
phiola play STREAM
and
phiola play STREAM -tee FILE
Is this correct?

Yes, that's exactly what I mean.

I'ts possible to also change the stream adress in the same process?
Currently I kill phiola and start a new process. It works, but it is more cumbersome.

I'ts possible to also change the stream adress or file in the same process?

phiola remote start URL should work -- did you try it?

Honestly, no. I just tried it and it works, thanks.
Are the options -connect_timeout and -recv_timeout inherited  the main process? I can't use it with the remote command.

changing the playback position

I added remote seek forward and remote seek back commands that will seek by 5 second interval.  These commands could be expanded, e.g. seek 1:00 to seek to the exact time.  Let me know what you think.  Initially I thought it's a good idea to use +5 or -5 notation, but that won't work because I can't use minus sign - as it is reserved for command-line options.

Are the options -connect_timeout and -recv_timeout inherited the main process?

No, currently they are silently ignored because CLI and "remote" are two separate modules.  I don't have a solution at the moment on how to pass all CLI options to "remote" so that they operate as a single unit.

Thanks for adding seek.

remote seek forward

and

remote seek back

work well, but

remote seek 1:00

doesn't work for me. Nothing happens.

I don't have a solution at the moment on how to pass all CLI options to "remote" so that they operate as a single unit.

Okay, that's not quite so tragic. Usually, loading does not take that long or an error is detected.
If I can completely replace the MediaCtrl with phiola in my program, then at least there is no longer any dependency between my timer for the MediaCtrl and phiola.
Perhaps pausing while playing via remote would be advantageous. But this could also be avoided with stop and play with seek.

I tested seek again on windows 10. Unfortunately, 'remote seek' doesn't work there at all.

It works fine on my box -- both commands phiola remote seek forward and phiola remote seek back change playback position by 5 seconds.  Are you sure you're using v2.3-beta2 and running the phiola playback instance with -remote switch?  These commands worked for you before, so I guess now you're doing something wrong...

That's the downside of working on different computers. I thought I had the latest version installed there too, but check again.
It would be great if seek worked with a timing requirement.

Yes, you are right. I really still had the old version.
Please excuse my false alarm.


Overflow wrap long text for state description

This resolves and issue with long contiguous strings of text would cause table contents to extend outside their container.

You can test by replacing the contents of state-descriptions with an exceedingly long string. Here is the one that initially caused the break for testing:
Error creating machine: Error in driver during machine creation: compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="OperationNotAllowed" Message="Operation could not be completed as it results in exceeding approved Total Regional Cores quota. Additional details - Deployment Model: Resource Manager, Location: centralus, Current Limit: 10, Current Usage: 10, Additional Required: 2, (Minimum) New Limit Required: 12. Submit a request for Quota increase at https://aka.ms/ProdportalCRP/#blade/Microsoft_Azure_Capacity/UsageAndQuota.ReactView/Parameters/%7B%22subscriptionId%22:%2214a619f7-a887-4635-8647-d8f46f92eaac%22,%22command%22:%22openQuotaApprovalBlade%22,%22quotas%22:[%7B%22location%22:%22centralus%22,%22providerId%22:%22Microsoft.Compute%22,%22resourceName%22:%22cores%22,%22quotaRequest%22:%7B%22properties%22:%7B%22limit%22:12,%22unit%22:%22Count%22,%22name%22:%7B%22value%22:%22cores%22%7D%7D%7D%7D]%7D by specifying parameters listed in the ‘Details’ section for deployment to succeed. Please read more about quota limits at https://docs.microsoft.com/en-us/azure/azure-supportability/regional-quota-requests"

Before

After

@rak-phillip Tested - I went ahead and merged for QA to test


README needs instructions for setting up ansible-builder and ansible-navigator in venv

Since ansible-builder and ansible-navigator are loose dependencies, instructions for setting up a venv should be included in the README.

Closed by #13


Question on intuition of "attention sink" and "alibi PE"

Hi,
Thanks for the amazing work on streaming-llm. While reading the paper, I came up with this question on why applying "attention sink" also works with models with alibi position embedding.
One observation from alibi based models is that the added alibi relative bias results in very small attention scores for the tokens at the beginning of a sequence given a long sequence since the attention score follows an ~exponential decay with sequence length. Is there any explanation you can provide behind this observation as to why attention sink works under this scenario? Maybe I've missed some things from the paper, thanks very much.

Hi,
Thank you for your kind words and thoughtful question on StreamingLLM.
Let's address the question you have. Even though models trained with ALiBi position embeddings have an exponential decay in attention scores for the initial tokens in long sequences, they still manifest the "attention sink" phenomenon. This means that the model still dumps attention scores to these initial tokens despite the influence of the ALiBi bias diminishing their importance.
This observation underscores an insight: the attention sink phenomenon isn't solely because of a specific positional encoding method employed. Instead, it's rooted in the intrinsic nature of autoregressive language modeling and the utilization of SoftMax in attention mechanisms.
Interestingly, our group published a paper three years ago titled "Spatten" (link). In this paper, we observed a similar attention sink phenomenon in GPT-2 model, which utilizes learned absolute positional embeddings. But we didn't further explore it at that time :).

I hope this clarifies the mechanism behind the attention sink in models with ALiBi embeddings.
Guangxuan

This phenomenon of scores accumulating in the first few tokens is quite intriguing.
I attempted to draw a connection to the paper "Vision Transformers Need Registers" (ViT).
In the case of ViT, certain unimportant tokens are automatically designated as a repository for global information, leading to their high norms. Removing these tokens would result in the loss of global information. However, if you were to remove the initial tokens at the beginning of the figure, I believe it wouldn't have a significant impact. This presents an interesting comparison with LLM.
In the case of LLM in streamingLLM, the initial tokens are automatically assigned as the primary features for future tokens. This phenomenon becomes more evident, especially in the deeper attention blocks. My hypothesis is that deeper blocks capture more global information, making it challenging to capture local information for the subsequent token predictions. Consequently, LLM automatically designates certain tokens as the collection of main features. The reason the first few tokens are chosen may be based on autoregression.
It appears that both of these papers share a common approach, where specific tokens are automatically assigned roles with distinct functions – for ViT, a collection for global information, and for LLM, a main-feature collection.


Monitor and print acceptance rate information

This seems to work, but might be a bit ugly, with triples being passed around and so on. I'll let you decide and/or choose another way.
Would it be considered bad Haskell style to rewrite all the functions so they take a Sampler as the first argument and return a Sampler, even if they only do things with a subset of the sampler fields? i.e., an "object-oriented" style.

Huh I apparently forgot to reply to this.  That's perfectly good style. 😄
The very Haskelly way to do it (though hardly necessary) is to encapsulate the stateful component of the algorithm in a state monad.  In my own mcmc libs I rely on a little mcmc-types library that contains a 'Transition' type, which is a state monad transformer over a probability monad.  The stateful stuff that needs to obey the Markov property is then handled in the state layer, and you can tell which functions need access to it just by looking at their type.


Update contributors.spec.js

Overview
Taking into account the changes coming from Bhaggya on Issue #538, update the testing for the Contributors page (Organizations page).
Action Items

[x] Update tests of showing grandparent, parent, child organizations at /organizations/all
[ ] Add tests that use the search feature of the Organizations page

Resources/Instructions
See PR #652

Progress: 50%
Blockers: None
Availability: Evenings / weekends
ETA: 6/20

Progress: Still at 50%
Blockers: #664, #668
Availability: Evenings / weekends
ETA: 7/8

@kevinashworth is still working on it.

Progress: Still at 50%
Blockers: #664 ?
Availability: Evenings / weekends
ETA: 8/9

@kevinashworth Please provide update

Progress
Blockers
Availability
ETA


Fix linting errors

This PR fixes some linting errors and removes unnecessary mutable borrows.

That said, after addressing the drop changes, I'll merge it regardless if separating the mut stuff into another PR is too much effort.

I think it's not worth separating the mut changes into a different PR (they are also some kind of linting errors, aren't they?).

[...] the mut changes [...] (they are also some kind of linting errors, aren't they?).

No, they're also semantic changes, not just pure stylistic changes from the clippy lints. However, if it's too much effort to separate them, I can still merge as is.

Thanks.


Missing step for Migrating RichTextFields to StreamField

This generated block of code needs to stay or else there will be an error while running ./manage.py migrate. It is misleading that it is not included in this tutorial.
Thanks for contributing to Wagtail! 🎉
Before submitting, please review the contributor guidelines http://docs.wagtail.io/en/latest/contributing/index.html and check the following:

Do the tests still pass? (http://docs.wagtail.io/en/latest/contributing/developing.html#testing)
Does the code comply with the style guide? (Run make lint from the Wagtail root)
For Python changes: Have you added tests to cover the new/fixed behaviour?
For front-end changes: Did you test on all of Wagtail’s supported browsers? Please list the exact versions you tested.
For new features: Has the documentation been updated accordingly?

Looks like this is the issue I was concerned about re putting schema and data changes in one migration: https://docs.djangoproject.com/en/2.2/ref/migration-operations/#runpython

On databases that do support DDL transactions (SQLite and PostgreSQL), RunPython operations do not have any transactions automatically added besides the transactions created for each migration. Thus, on PostgreSQL, for example, you should avoid combining schema changes and RunPython operations in the same migration or you may hit errors like OperationalError: cannot ALTER TABLE "mytable" because it has pending trigger events.

Since the AlterField doesn't actually change anything at the database level (both RichTextField and StreamField use a text field internally), I believe we should be fine in this case.

Merged in 942979fc4ef9dd5fedcc33aadd024d796a03d0ba - thanks!


Peer feedback from Nash Makhija

Hi Team,
Very interesting topic for this project and you have done a great job of deeply diving into it! Below are some minor points of feedback that I hope you find useful.
EDA report - Great use of various chart types and colours, very visually appealing! The Correlation Matrix and the Numeric data analysis sections felt a bit repetitive, especially since there was not a lot of correlation between your features, you might consider removing the correlation plot completely if the message can be delivered through the data analysis plots or vice-versa.
Final report - Good amount of details and easy to follow, however the 'Feature selection & hyperparameter tuning section' and Table 3 might need a relook. You mention top 18 and then top 19 features in the same paragraph after Table 2. Is this a typo or is there a reason for this? Also, might be worth mentioning why you're only reporting 18 features (seems specific? Alternatively, you could report top 10 or 20). You could also convert this table into a barplot to make it more visually appealing and attention grabbing, though the long feature names might make this a challenge...
Code - The scripts look good, and are easy to follow with good documentation throughout the scripts. I did not try running them as some dependencies are missing in the README. Hopefully, this will be fixed this week through the Dockerfile creation!
Nice job so far and good luck for the rest of this project and block!
Best,
Nash

Thank you Nash for the feedback - we appreciate it :) We will try our best to address them!

Thank you very much for reading through our project thoroughly and providing your feedback!

Thank you very much for the review, Nash!

Nash thank you for the review and for taking the time of reading our reports, we´ll take them into consideration before the final release.


Android: Debug mode is broken

Description:
I think my debug mode for android is kinda broken. I cannot open the debug menu, event though I have yellow-orange boxes for warnings on my device (which tells that i'm running the app on debug mode). No chrome tab opens with a debugger when i run a react-native run-android.
The metro bundler doesn't seem to bundle anything by the way. I used to have a green progress bar but now nothing, even though my app does start on my device.

react-native log-android gives me logs from the app, as if I was looking a the console.
adb shell input keyevent 82 doesn't do anything.
React Native version:
    System:
      OS: Windows 10
      CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU
@ 2.20GHz
      Memory: 6.96 GB / 19.74 GB
    Binaries:
      Yarn: 1.17.3 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
      npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
    IDEs:
      Android Studio: Version  <IP_ADDRESS> AI-191.8<IP_ADDRESS>10548

    "react": "16.8.3",
    "react-native": "0.59.9",

Expected Results
I would like to have my debug menu back.

I am not sure this belongs on this repository. Can you provide a list of steps to reproduce this on the latest version? Feel free to submit a new issue with this information.


Stuck on Searching for devices ...

Initialized project using natal init FutureApp --interface om-next
After that I opened the created dir and tried connecting to repl using natal repl, but I am stack with:
➜  future-app  natal repl
Starting REPL

Searching for devices ...

Nothing seems to be happening, even after 5 minutes or so.

This may be helpful: https://github.com/omcljs/ambly/wiki/Connectivity

Forgot to mention, went through this Connectivity wiki. WebDav directory is not being mounted, tried to mount one myself using the app name, still the same problem.
The weird this is  natal listdevices kinda shows all the available devices, but the REPL does not seem to be able to make connection. Not sure what else I could try.

Conversation with glosoli on IRC at http://irc.fikesfarm.com/log/clojurescript/2015-11-02.txt

I am having this problem  with one of my laptops but not the other. I noticed that the one that works has mDNSResponder running

Hey Jearvon,
For your laptop that’s not working, it it running OS X 10.10 less than or equal to 10.10.3?

Mike

On Nov 3, 2015, at 1:26 AM, Jearvon Dharrie<EMAIL_ADDRESS>wrote:
I am having this problem with one of my laptops but not the other. I noticed that the one that works has mDNSResponder running
—
Reply to this email directly or view it on GitHub https://github.com/dmotz/natal/issues/21#issuecomment-153257682.

Just to add more info: I have mDNSResponder running on my computer just fine.

@zilvinasu Which version of Java are you using?

@mfikes
java version "1.8.0_65"
Java(TM) SE Runtime Environment (build 1.8.0_65-b17)
Java HotSpot(TM) 64-Bit Server VM (build 25.65-b01, mixed mod

@zilvinasu Is there any possibility of other computers on your network running 10.10–10.10.3?

@mfikes  no

Seems like I managed to fix my problem. It was related to my /private/etc/hosts having my computer name next to localhost <IP_ADDRESS>	localhost mycomputername removing it made everything work just fine.

Interesting. Perhaps that somehow affects mDNS. Or alternatively it causes a situation Ambly is somehow mishandling it.

Moved to Ambly.


Blockgroup and block level editing broken on some maps

We received multiple emails over the weekend from users explaining that they got a "Something went wrong, please try again" error when trying to select blocks or blockgroups and add them to a district. I'm seeing a 403 error in my browser. Example of a map with this error (copy it into your account then test):
https://app.districtbuilder.org/projects/a24b009d-0999-455d-ad79-b7d73b5e1f26
Interestingly, it doesn't appear to be happening on all maps.

We have implemented a fix and blockgroup and block editing appear to be working again. We will monitor and further test for a couple of days.


lcov report visualization incorrect

Expected Behavior
Lines that are covered should not appear in red.
Observed Behavior
Lines that are covered sometimes appear in red.
Bonus Points! Code (or Repository) that Reproduces Issue
a.js
import React from 'react';

class A extends React.Component {
  a() {
    const b = 1;
  }
  render() {
    return
Blah
;
  }
}
export default A;

a_spec.js
import React from 'react';
import ReactTestUtils from 'react-addons-test-utils';

import A from './a';

describe.only('', () => {
  it('renders', () => {
    const renderer = ReactTestUtils.createRenderer();
    renderer.render();
  });
});

package.json
{
  "babel": {
    "presets": [
      "es2015",
      "react"
    ]
  },
  "description": "Testing an issue with the coverage output",
  "dependencies": {
    "babel-preset-es2015": "^6.22.0",
    "babel-preset-react": "^6.22.0",
    "babel-register": "^6.22.0",
    "mocha": "^3.2.0",
    "nyc": "^10.1.2",
    "react": "^15.4.2",
    "react-addons-test-utils": "^15.4.2",
    "react-dom": "^15.4.2"
  },
  "license": "UNLICENSED",
  "name": "coverage_test",
  "nyc": {
    "reporter": [
      "lcov",
      "text"
    ]
  },
  "repository": "gist:8a2bd8d15cf49b9d770f3fcde222c779",
  "scripts": {
    "test": "nyc mocha --compilers js:babel-register a_spec.js"
  }
}

Running npm test after installing the above files produces the following visualization for the coverage of a.js:

Note that the render function is definitely called and the visualization even shows line 8 as being executed 1 time. I'm not sure if this is a problem directly with nyc, or istanbul, or with an external library, but I figured I'd start here. Below are the contents of the text-lcov output when I run ./node_modules/.bin/nyc report --reporter=text-lcov
TN:
SF:/Users/bboe/Desktop/nyc/a.js
FNF:0
FNH:0
DA:1,1
DA:5,0
DA:8,1
LF:3
LH:2
BRF:0
BRH:0
end_of_record
TN:
SF:/Users/bboe/Desktop/nyc/a_spec.js
FN:6,(anonymous_1)
FN:7,(anonymous_2)
FNF:2
FNH:2
FNDA:1,(anonymous_1)
FNDA:1,(anonymous_2)
DA:1,1
DA:2,1
DA:4,1
DA:6,1
DA:7,1
DA:8,1
DA:9,1
LF:7
LH:7
BRF:0
BRH:0
end_of_record

Note: If I replace const b = 1; with some other statements like return; then the problem goes away.
Forensic Information
Operating System: Mac OS Sierra
Environment Information:
v6.2.1
3.10.4
https://gist.github.com/bboe/5ae951b6cf213ba3b1458f5573244edb

Looks to me like you're missing babel-plugin-istanbul. Could you try installing and configuring it as documented, and hopefully you'll be in better place? :)

@JaKXz that solved it. Thanks! It's incredible how close to accurate it was without that plugin.

@bboe I'd love for it to be 100% accurate without the plugin, but we've never quite nailed the source-map remapping -- not quite sure where in the stack the lines get shuffled.


Nfdiv 2898 js send letter joint

Change description
send letter package to both applicants for joint JS
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/NFDIV-2898
Before merging a pull request make sure that:

[X] tests have been updated / new tests has been added (if needed)
[X] README and other documentation has been updated / added (if needed)

After reviewing this PR, it has been done incorrectly as the ticket linked is for solicitor journey. Also ticket AC has changed as document link was incorrect. It will be easier to start a new PR for this ticket, so I am closing this one. Ticket has been moved back to TODO for now.


Unable to build with no ozone, but X11 only?

OS/Platform
Debian, Ubuntu, and derivatives
Installed
Compiled from source
Version
115.0.5790.99
Have you tested that this is not an upstream issue or an issue with your configuration?

[ ] I have tried reproducing this issue in Chrome and it could not be reproduced there
[ ] I have tried reproducing this issue in vanilla Chromium and it could not be reproduced there
[ ] I have tried reproducing this issue in ungoogled-chromium with a new and empty profile using --user-data-dir command line argument and it could not be reproduced there

Description
Setting use_ozone to false causes build failure.
How to Reproduce?

Put use_ozone=false into flags.gn.
Build.

Actual behaviour
Error message:
ERROR at //ui/platform_window/common/BUILD.gn:8:1: Assertion failed.
assert(use_ozone)
^-----
See //ui/aura/BUILD.gn:260:15: which caused the file to be included.
    deps += [ "//ui/platform_window/common" ]
              ^----------------------------

Expected behaviour
Build without ozone, using X11 only, without a middle layer.
Relevant log output
ERROR at //ui/platform_window/common/BUILD.gn:8:1: Assertion failed.
assert(use_ozone)
^-----
See //ui/aura/BUILD.gn:260:15: which caused the file to be included.
    deps += [ "//ui/platform_window/common" ]
              ^----------------------------
ninja: Entering directory `out/Release'
ninja: error: loading 'build.ninja': No such file or directory

Additional context
No response

Build without ozone, using X11 only, without a middle layer.

Not possible.


textCodeBlock.background workbench theme key

Closes #155
Added the textCodeBlock.background workbench theme key that is used by VS Code features like the IntelliSense quick info to style the background color of code blocks in the documentation text. By default this uses a very dark color.
This PR changes the color to use nord3 instead.

LGTM — thanks!


add CS fixer workflow

It is a manual workflow.

Hello Viktor,
thank you for your collaboration. As you can see, integration is in very early stage, any help is welcome.


⚠ Samsung has degraded performance

In 1bd39bf, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2544 ms

Resolved: Samsung performance has improved in 78c06d5.


LaunchTemplate UserData Patching/Transforming Not Working

What problem are you facing?
I am having issues with LaunchTemplates and patching/transforming the user-data within Compositions.
More specifically, I would like to include some details generated by other resources that are created in the Composition (for example, EKS Cluster server endpoint etc).
So this would involve:

Combining and formatting the various elements from status.*
Base64 encoding the above and giving it to the user data field

I cannot seem to get that to work. The status shows no errors, just the userdata remaining blank. If I choose a more simple operation, I can place a string into userdata (which it will then obviously complain it isn't base64 encoded).
How could Crossplane help solve your problem?
I am finding it hard to get any examples similar to mine above that involve both manipulating outputs from other resources AND encoding it before populating the field which requires the encoding.
I can't imagine this is a unique scenario to perform so having that documented would be useful. Any pointers to where this info would be, if I missed it, please feel free to correct me.

I eventually solved this but took much longer than it should have. I think maybe extended examples of sharing values across resources in Compositions would be valuable.

Patch and transforms are a feature of core Crossplane itself which lives in its own repo: https://github.com/crossplane/crossplane. The providers itself do not contain such logic and only expose resource information in the status field.
You might also want to check out the Crossplane docs that provide more insights on how to write patch and tranforms: https://docs.crossplane.io.


[lit-next] Refine controller/directive API

Description

rename connnected/disconnectedCallback to connected/disconnected for both controllers and directives.
add interface for a ControllerHost so that Controllers can accept a host argument that is typed to ControllerHost. This interface implements addController and requestUpdate.
consider making a hooks example for React that uses controllers to validate the design

Acceptance criteria
PR landed with changes.

@justinfagnani Can you confirm that https://github.com/Polymer/lit-html/pull/1522 resolves this issue and close it if so? Thanks!

@justinfagnani Can you confirm that https://github.com/Polymer/lit-html/pull/1522 resolves this issue and close it if so? Thanks!

#1522 addresses everything except a React Hooks adapter. That should be in a separate issue.

#1522 addresses everything except a React Hooks adapter. That should be in a separate issue.


% JsonNode operator cast true and false literal value to 1 and 0

import karax / [jjson, kajax, karax]

var option* = %*{
    "backgroundColor": "#404a59",
    "title": {
        "text": "",
        "left": "center",
        "textStyle": {
            "color": "#fff"
        }
    },
    "tooltip": {
        "trigger": "item",
        "formatter": formatter,
        "textStyle": {
            "color": "#fff",
            "fontSize": 12,
            "fontWeight": "normal"
        },
        "padding": [10, 15],
    },
    "geo": {
        "map": "world",
        "label": {
            "emphasis": {
                "show": true,
                "color": "#fff"
            }
        },
        "roam": defaults["roam"],
        "zoom": defaults["zoom"],
        "center": defaults["center"],
        "itemStyle": {
            "normal": {
                "areaColor": "#323c48",
                "borderColor": "#404a59"
            },
            "emphasis": {
                "areaColor": "#2a333d"
            }
        }
    },
    "series": []
}

In many scenes, bool literal value is expected rather than 1 or 0.
Have to set bool value manually as
option["geo"]["label"]["emphasis"]["show"] = true

Have to set boolean values manually, x["a"]=true, y["a"]=false
import karax / [jjson, kajax, karax]

proc log*[T](x: T) {.importc: "console.log", varargs.}

var x = %*{"a":true}
var y = newJsonNode({cstring"a": %false})
log x
log y
x["a"] = true
y["a"] = false
log x
log y

{ a: 1 }
{ a: 0 }
{ a: true }
{ a: false }

Is it related to https://github.com/nim-lang/Nim/issues/7375?

I think that this is a solution:
import karax / [jjson, kajax, karax]
import jsffi
var option* = %*{
  "test": true
}
var option2* = js{
  "test": true
}
include karax/prelude
proc render(): VNode =
  buildHtml(tdiv):
    kout option
    kout option2
    kout option2["test"]
setRenderer render

And the output in the console looks like:
{test: 1} //from jjson
{test: true} //from jsffi
true //getting value by key from jsffi

So, use jsffi instead of jjson. Both of them should have similar performance characteristics, but jsffi is part of stdlib now (not sure if existed back when this issue was created) so I would recommend it over jjson. I've successfully used jsffi to create a similar options js object for an external library.
One thing to be careful of though when using it with karax is that
var option2* = js{
  "test": true,
  "test2": "hey now"
} # bad

var option2* = js{
  "test": true,
  "test2": kstring"hey now"
} # good

If you use the first one, then the string is interpreted as a nim string which means it becomes an array of numbers, whereas with the second one it is treated correctly on both the js and the c backends.


wont migrate; django error

Hi I have set up everything and trying to run: manage.py migrate, but get a long error message ending in:
"base.py line 21, in complain raise ImproperlyConfigured("settings.DATABASES is improperly configured. "
django.core.exceptations.ImproperlyConfigured: settings.DATABASES is improperly configured. Please supply the ENGINE value. Check settings documentation for more details.

HI @kristerfl try either of the following settings for settings.DATABASE.  The former requires postgres, the latter will run off of your file system.
#postgres

DATABASES = {
    'default': {
        'ENGINE': 'django.db.backends.postgresql_psycopg2',  # Add 'postgresql_psycopg2', 'mysql', 'sqlite3' or 'oracle'.
        'NAME': 'trader',                      # Or path to database file if using sqlite3.
        # The following settings are not used with sqlite3:
        'USER': 'trader',
        'PASSWORD': '<pw>',
        'HOST': '<IP_ADDRESS>',  # '<IP_ADDRESS>',                      # Empty for localhost through domain sockets or '<IP_ADDRESS>' for localhost through TCP.
        'PORT': '',  # '5124',                      # Set to empty string for default.
        'ATOMIC_REQUESTS': True,
    },
}

#sqllite

import os
BASE_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))

_DATABASES = {
    'default': {
        'ENGINE': 'django.db.backends.sqlite3',
        'NAME': os.path.join(BASE_DIR, 'db.sqlite3'),
    }
}

feel free to reopen if you still have issues.

I have all that in that file. Could be I'm using wrong version for some of the reqs but not django and i still get the "django.core.exceptions.ImproperlyConfigured: settings.DATABASES is improperly configured. Please supply the ENGINE value. Check settings documentation for more details." on a fresh install..

i tried some tinkering and now have:
Traceback (most recent call last):
File "./manage.py", line 8, in
from django.core.management import execute_from_command_line
File "/home/syntacs/.local/lib/python2.7/site-packages/django/init.py", line 1, in
from django.utils.version import get_version
File "/home/syntacs/.local/lib/python2.7/site-packages/django/utils/version.py", line 5, in
import subprocess
File "/usr/local/lib/python2.7/subprocess.py", line 429, in
import select
ImportError: /usr/local/lib/python2.7/lib-dynload/select.so: undefined symbol: _PyInt_AsInt


Pick "(enhancement)[fe] Add isMaster() check for FrontendService (#24412)"

In FrontendServiceImpl service, the api which need to write editlog need add isMaster() check

run buildall


setup with dropbox, box, and google

I think this is more code than the actual passport libraries.

@ekump well it would be


Updating to Angular 12.0.0-next.9 causes 100% reproducible WebWorker failure

🐞 bug report
Affected Package

 The issue is caused by package @angular/....
Not yet. I updated using ng update
Is this a regression?
Yes

 Yes, the previous version in which this bug was not present was: `12.0.0-next.8`
Description
 A clear and concise description of the problem...
Run the sample repository. After doing nothing but updating package.json dependencies and re-building, web-workers stop working.
Project was created using:
ng generate web-worker app

The application was then updated to the latest version of Angular pre-release build.
git clone https://github.com/lincolnthree/example-webworker-broken-angular
cd example-webworker-broken-angular
npm i
ng serve

Then open the console and observe the error message.

Not that I know of. Fails on both latest Chrome and Safari.

Version 12 now contains a breaking change related to Web workers due to the upgrade to use Webpack 5 internally.  For details on the breaking change, please see the release notes for the latest prerelease here: https://github.com/angular/angular-cli/releases/tag/v12.0.0-next.9
Essentially, Webpack 5 requires the structure of the parameters for the Worker constructor to change as follows:
new Worker('./app.worker', ...) --> new Worker(new URL('./app.worker', import.meta.url), ...).
A migration will automatically execute for users upgrading from version 11 or earlier.
The migration can also be manually execute via ng update @angular/cli --migrate-only update-web-workers-webpack-5

@clydin Interesting, thank you for the pointer/solution/missing info! This helps a TON. It looks like this was omitted from the primary release notes BREAKING CHANGES section:
https://github.com/angular/angular/blob/master/CHANGELOG.md#breaking-changes
Seems like something the Angular folks might want to add there! Shout out! Thanks again :)

@lincolnthree, it’s listed in the e breaking changes here: https://github.com/angular/angular-cli/releases/tag/v12.0.0-next.9

@alan-agius4 Yeah I found it there, just not in the primary release notes that are supposed to aggregate the release notes from all the projects afaik.

https://github.com/angular/angular/blob/master/CHANGELOG.md only contains the framework changes.

@alan-agius4 Oh, interesting, then am I misunderstanding the package naming for compiler-cli build and language-service?

@clydin  Thanks again for the reply. The issue I've encountered appears to be an incompatibility between Webpack 5/the new Angular build, and the observable-webworker library: https://github.com/cloudnc/observable-webworker/issues/67 (Issue I opened on that project with details of the failures, and another code repro branch if you want to see what's happening.)
Simply updating the syntax does not fix the issue, rather exposes a different error, and depending on the flavor of syntax used, actually causes a silent failure where nothing happens whatsoever.
I'm not sure if you feel like this needs to be addressed or even investigated by the Angular team, but I figured you'd want to know that this is indeed causing library-level incompatibilities.
I don't know enough about Webpack to understand where the fix needs to happen -- so just trying to provide helpful information.

@clydin Seems the new minification process is stripping workers of their content when they are executed using @Annotation/decorator hooks rather than directly via a function call in the source js.
The annotation is not enough to keep the minifier from consuming them. See related issue in observable-webworker above.

In the case of this issue, the decorator from the library is attempting to internally cause a global side effect at runtime.  However, since the class is not referenced within the code, the class appears unused and is removed.  This situation may have unintentionally worked previously inside worker code.  However, now that Webpack 5 Web worker support is used, the full compilation pipeline is leveraged for worker code.  The important aspect of this is that worker code is now optimized equivalently to the main application code wherein a decorator such as used here would also not function. Adding the following to the worker file instead of the decorator will cause the code function:
ObservableWorker()(ExampleWorker);

Since the class is now referenced within the call expression, it will be retained in the optimized output.

@clydin Thanks for the update. This indeed was the issue, makes sense now that you've laid it all out. Again, I really appreciate the attention/followup on this one. It was strange and I am by no means an expert in all this!
Your workaround works, but for anyone else finding this issue, just omit the annotation entirely and use the runWorker(ExampleWorker) method provided by observable-webworker.
(WARNING: If you use both the @ObservableWebworker() annotation AND the runWorker(...) method, your workers will be executed twice per message, which is likely not a good thing.


can you help me find the config file on osx 10.11.4?

Hi,
can you please help me find the config file of youtube-dl on osx 10.11.4?
Thanks a million in advance

You must write it with a text editor (like TextEdit, vim, emacs ...) and save it as ~/.config/youtube-dl/config, you may need to create the folders. Most editors will expand the ~, but you can replace it with /Users/<username> (example: /Users/endaer).

Erm... OSX does not allow me to create any folders with .config saying that the foldernames starting with a dot are restricted for system, no users can create such folders regardless of my access rights. :/


Fix sequencer summary table

There is a bug in the pretty_print function. Check e.g. run 9793 (which has broken event table).
It should print:
Start AgRW1S2
Stop AgRW1S1

or something similar (showing that these are not correct/complete dumps with start and stops).

Fixed in #18


Can't have multiple directives on page

I am trying to use the directive on more than one headline on a page.
It will resize the first, but not the second.
Any recommendations?

Are you getting any console errors?
The demo shows multiple being used on a page. Can't be much help unless you can replicate the issue in a Plnkr or something...

No errors.
I am using the attribute method:
data-fittext data-fittext-max="90" data-fittext-min="40"

You'll have to replicate the issue: http://jsfiddle.net/
If you are sticking any other directives on the element, try removing them / putting them on another element wrapper etc


Is project order not alphabetical in CT4IJ?

https://code.google.com/p/android/issues/detail?id=220470

Any fix should be cherry picked into Android Studio

it is alphabetical


通过cmake生成makefile时报错install TARGETS given no LIBRARY DESTINATION for shared library target   "nacos-cli".

具体报错内容如下：
CMake Error at CMakeLists.txt:57 (install):
install TARGETS given no LIBRARY DESTINATION for shared library target
"nacos-cli".
CMake Error at CMakeLists.txt:64 (install):
install TARGETS given no LIBRARY DESTINATION for shared library target
"nacos-cli".
-- Configuring incomplete, errors occurred!
See also "/root/nacos-sdk-cpp/CMakeFiles/CMakeOutput.log".
See also "/root/nacos-sdk-cpp/CMakeFiles/CMakeError.log".

你好 @sucaiji
我已经修复cmakeList：
https://github.com/nacos-group/nacos-sdk-cpp
如果仍有问题，请继续联系我，谢谢！


build: use secure grpc when it is not bundled

Signed-off-by: Lorenzo Fontana<EMAIL_ADDRESS>What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #959
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: fntlnz
If they are not already assigned, you can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: b54bd9fe8515df1700751fb0d4b3ed50a72e9e84

/hold

/hold cancel


Update to cryptography

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Please review this pull request for exchanging pycrypto to cryptography.  This is to address the following vulnerability flagged by safety:
| REPORT                                                                       |
| checked 72 packages, using local DB                                          |
+============================+===========+==========================+==========+
| package                    | installed | affected                 | ID       |
+============================+===========+==========================+==========+
| pycrypto                   | 2.6.1     | <=2.6.1                  | 35015    |
+==============================================================================+
| Heap-based buffer overflow in the ALGnew function in block_templace.c in     |
| Python Cryptography Toolkit (aka pycrypto) 2.6.1 allows remote attackers to  |
| execute arbitrary code as demonstrated by a crafted iv parameter to          |
| cryptmsg.py.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Elevation of new development areas

FloodAdapt version checks

[X] I have checked that this issue has not already been reported.
[X] I have checked that this bug exists on the latest version of FloodAdapt.

Reproducible Example
When a new development area is added the ground elevation is 0 there.
Current behaviour
Right now, ground elevation is assumed 0 at new developments areas.
Desired behaviour
The elevation of the new developement areas should be derived from the DEM file.
Task list

[ ] Add the functionality in hydromt-FIAT
[ ] Change fiat integrator accordingly

Additional context
No response

This can be added here: https://github.com/Deltares/hydromt_fiat/blob/807d0b179b6d8014817e17ca0a4ace24096cac81/hydromt_fiat/workflows/exposure_vector.py#L808

Mario worked on this. Should be merged soon.


Cannot properly utilize oneOf

Hi, all.
According to previous issues, for OpenAPI 3.0, anyOf and oneOf are not supported in the @definitions.
If they were supported in @definitions, I would have something like this:
    BaseCondition: {
      type: "object",
      properties: {
        jsonPath: { type: "string" },
        conditionalOn: { type: "object" }
      },
      required: ["jsonPath", "conditionalOn"]
    },
    CompositeCondition: {
      type: "object",
      properties: {
        type: { type: 'string', enum: ['AND', 'OR']},
        conditions: {
          type: 'array',
          items: {
            oneOf: [
              {$ref: '#/components/schemas/BaseCondition'},
              {$ref: '#/components/schemas/CompositeCondition'}
            ]
          }
        }
      },
      required: ['type', 'conditions']
    },

But because oneOf is not supported there, I need to put it in the components/schema. However, since swagger-autogen is using its own format in that section (for example, required keys are prepended with $), I cannot put it there.)
I am sure that I am doing something wrong here. This seems like a pretty simple case. Please let me know any doc which can point me in the right direction.

Hi @aorlowskiddm! Thank you for opening the issue.
As you are using components/schemas, you could use @schema to put the OpenAPI specification by yourself, that is, that way our lib won't do rederization. Take a look at schemas-and-components#schemas. There will be an example about it.
Let me know if it doesn't work in your case.

@davibaltar Thank you for the prompt reply.
I added the schema to the @schemas per your directive, but the Swagger page is rendering it incorrectly.
components: {
    schemas: {
       RuleMappingCreateContext: {
          condition: { $ref: '#/components/schemas/Condition' },
        },
    },
    '@schemas': {
      CompositeCondition: {
        type: "object",
        properties: {
          type: { type: 'string', enum: ['AND', 'OR']},
          conditions: {
            type: 'array',
            items: {
              oneOf: [
                {$ref: '#/components/schemas/BaseCondition'},
                {$ref: '#/components/schemas/CompositeCondition'}
              ]
            }
          }
        },
        required: ['type', 'conditions']
      }
    },
    Condition: {
        oneOf: [
          {$ref: '#/components/schemas/BaseCondition'},
          {$ref: '#/components/schemas/CompositeCondition'}
        ]
      }
  },

It is not showing anything for it at all in Swagger for RuleMappingCreateContext:

Just to test it out, if I change the condition of the RuleMappingCreateContext to #/components/schemas/CompositeCondition instead, everything renders correctly on Swagger's end except for the oneOf part of the schema. It simply shows an empty list :

If it helps, I am instantiating swagger-autogen in this way:
const swaggerAutogen = require('swagger-autogen')({openapi: '3.0.0'})

After closing the laptop for a bit, I've come to realize that there's a 99% certainty that this issue is being caused by the package I am using to serve Swagger, (swagger-ui-koa), and nothing to do with swagger-autogen.

Yes, I was correct. I replaced swagger-ui-koa with koa2-swagger-ui and it is rendering identically to the Swagger editor now.
Thanks @davibaltar for your comment which gave me confidence that I was correctly inputting to swagger-autogen.

No worries @aorlowskiddm. And it's good to know! anyone who might be facing the same problem, your comments will help them. Thanks!


Test pool garbage collection.

Issue Number
#2019
Overview
This PR tests that the chain-following code is correctly invoking the pool garbage collector by calling the removeRetiredPools operation at appropriate points in time.
Since the effects of the garbage collector are not visible through the API, the integration test framework cannot use the API to discover whether garbage collection has taken place.
This PR takes a novel approach of adding a decorator to the pool DB layer that records garbage collection events and makes them visible to the integration test layer.
Since the removeRetiredPools operation is already covered by property tests, the correctness of this operation is outside the scope of this PR.
Details
This PR:

[x] Adjusts the chain-following code to garbage collect pools even if there are no new certificates. This makes it possible to see the effects of garbage collection in the context of an integration test, where all certificates are issued at the start of time.
[x] Limits pool garbage collection to exactly once per epoch, and no more.
[x] Introduces the concept of a pool database decorator, which makes it possible to add instrumentation or monitoring to a pool database layer object.
[x] Uses a pool database decorator to monitor garbage collection events from the integration test framework.
[x] Adds an integration test to check that retired pools are garbage collected on schedule.

 No pools were removed from the database.
[cardano-wallet.integration:Notice:758] [2020-09-21 09:05:36.02 UTC] Intercepted pool garbage collection event for epoch 2. No pools were removed from the database.
[cardano-wallet.integration:Notice:758] [2020-09-21 09:06:16.01 UTC] Intercepted pool garbage collection event for epoch 3. The following pools were removed from the database: PoolRetirementCertificate {poolId = PoolId {getPoolId = "\ESC=\193\156j\184\158\175\252\133\SOH\243u\187\ETX\193\ESC\248\237]\CAN76\177\216\EOT\DC3\214"}, retirementEpoch = EpochNo {unEpochNo = 3}}
[cardano-wallet.integration:Notice:758] [2020-09-21 09:06:56.03 UTC] Intercepted pool garbage collection event for epoch 4. No pools were removed from the database.
[cardano-wallet.integration:Notice:758] [2020-09-21 09:07:36.02 UTC] Intercepted pool garbage collection event for epoch 5. No pools were removed from the database.
[cardano-wallet.integration:Notice:758] [2020-09-21 09:08:16.03 UTC] Intercepted pool garbage collection event for epoch 6. No pools were removed from the database.
[cardano-wallet.integration:Notice:758] [2020-09-21 09:08:56.01 UTC] Intercepted pool garbage collection event for epoch 7. No pools were removed from the database.
[cardano-wallet.integration:Notice:758] [2020-09-21 09:09:36.02 UTC] Intercepted pool garbage collection event for epoch 8. No pools were removed from the database.

@jonathanknowles it seems that all tables are garbage collected on epoch 5 except pool_metadata:

@jonathanknowles it seems that all tables are garbage collected on epoch 5 except pool_metadata:

Well spotted! This appears to be a problem with the removePools database operation.
The SQLite implementation of removePools is:
removePools = mapM_ $ \pool -> do
    liftIO $ traceWith trace $ MsgRemovingPool pool
    deleteWhere [ PoolProductionPoolId ==. pool ]
    deleteWhere [ PoolOwnerPoolId ==. pool ]
    deleteWhere [ PoolRegistrationPoolId ==. pool ]
    deleteWhere [ PoolRetirementPoolId ==. pool ]
    deleteWhere [ StakeDistributionPoolId ==. pool ]

This is correct, in that it removes all rows where pool_id is the given pool. However, it's incomplete, since the pool_metadata table is indexed by metadata_hash, rather than by pool_id.
I'll create an issue for this, as I think it's outside the context of this PR (which is to check that the chain-following code is correctly calling removeRetiredPools).

bors r+

This was maybe merged a bit too fast...

How so?
The PR was created yesterday morning, and approved yesterday afternoon. It was merged today, in accordance with our process.
There was a long discussion about potential solutions here: https://input-output-rnd.slack.com/archives/GBT05825V/p1600328272058800. At the time of the discussion, there were alternative solutions put forward, but each alternative had its own issues. In the end, we had to make a choice to proceed with one of the solutions. The benefits of this solution:

no API alterations required.
low memory footprint (as there are very few garbage collection events).
all historical garbage collection events are available for inspection (and not just those that occur during the test).
we were able to implement it within a reasonably short period of time, which is important, given our other priorities.

@Anviking put forward a suggestion for a more general solution involving log filtering and subscription here and here. I agree with his point of view. However, it's not clear to me how we would implement such a system right now, at least without further engineering effort.
Though I'd be very happy to see a working proposal, as I'm quite interested in improving on this.


Add a pod YAML file for the submit-queue.

@ixdy @zmerlynn can I get a quick review?

@ixdy comments addressed, please take another look.
Thanks!
--brendan


my_delete_warc_after_extraction

my_delete_warc_after_extraction within the example configuration was not used actively. I tried to add its (hopefully intended) usage by keeping the command-line logic same as before.

thanks a lot!


Socket exception issue

Describe the bug
Even the server pod is running in the background flutter showing socket exception error
To Reproduce
Steps to reproduce the behavior:

Go to pod server side and run the server
run the flutter app
call the api for the server folder
SocketException: Network is unreachable (OS Error: Network is unreachable, errno = 101), address = localhost, port = 42354

Where are you running the flutter app and what platform?
If you are running on a physical device or an Android emulator you cannot use localhost as the address. You can find your IP address with ifconfig on linux/macos or ipconfig on windows. And a physical device has to be connected to the same local network as your computer (I.E. same wifi).
If you are running on an Android emulator you can use the address, <IP_ADDRESS>.


Indention error

VSCode Version: 1.36.1
OS Version: Deepin 15.11

Steps to Reproduce:

Open a cpp file
Set the tab width to 4 spaces
Press ctrl+shift+i to indent the code
The indentation is set to 2 automatically

Does this issue occur when all extensions are disabled?: Yes

Report to https://github.com/microsoft/vscode-cpptools.


Update resource-manager-template-walkthrough.md

Fixed a typo.

Hi @alexandair, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, AZPRBOT;

Merging - thanks!


Added hook for callback in case of failure to load Image/texture

Hi,
We've found that we need to be able to hook up some function in case the texture fails to load. In our case it's an API which can return a application/json in case there is no image which kicks off functions hooked up to the onerror property of the image.
I'm not sure that this is the best solution, or even that it works since I haven't hooked up our application to my local version of geom which I should probably do. But it's an outline. How do you think it looks?
I'll try hooking up our project against my local version of geom tomorrow.
See: http://stackoverflow.com/a/9815854/501017

thanks so much @Rovanion!


Add a setting to maximize new windows

Currently when opening a new window, I almost always maximize it. So I don't see any reason why it shouldn't be maximized from the beginning.
In the rare case that I want a non-maximized window, I can just unmaximize or drag it.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Create Word List Extension

As a user, I want to see a  nice list of words showing how often various words occur in my current context.
For this first iteration, just show words in the current chapter of a project.  Future iterations will eventually work our way towards the functionality of the P9 Wordlist.
Counts based on current chapter for now.
Add a toggle with a word cloud view:

https://www.npmjs.com/package/react-wordcloud
https://react-wordcloud.netlify.app/
Resizeable demo https://codesandbox.io/s/55sb8

(Heavily edited by Glenn - this really isn't TJ's comment anymore...)

@GlennPruitt Should it show the frequency of words in your whole project? Just the currently-selected chapter? Whatever is easiest to implement with what we have (this one is my preference hehe)? Other?

What if it created a list of words instead of a cloud?  Start with displaying the currently selected chapter.  Then later it could be a configurable scope.  Sort the words from most used to least used, then alphabetically.  Instead of the Word Cloud we could call it the Word List...

Whatever you'd like to do is fine! But a word cloud would honestly probably be just about as easy because of the library I linked in the description of this issue. Your call :) I can adjust the issue as instructed.

FWIW, there is a demo Paratext plugin that creates a word cloud from the USFM text: https://github.com/ubsicap/paratext_demo_plugins/tree/master/ChapterWordle

PR is here


Values block - BE and FE

Link to FE Ticket
Link to BE Ticket
Description of Changes Made
Adds the values block needed on the About us page - note we are using the service page type for this page.
How to Test
In the pattern library: http://localhost:8000/pattern-library/render-pattern/patterns/molecules/streamfield/blocks/values_block.html
Or edit a service page in your local build, and choose to add a 'values' block
Note that I have not used desaturation for the images in this block.
Screenshots

Expand to see more
Page editor:

MR Checklist

[x] Add a description of your pull request and instructions for the reviewer to verify your work.
[x] If your pull request is for a specific ticket, link to it in the description.
[x] Stay on point and keep it small so the merge request can be easily reviewed.
[x] Tests and linting passes.

Unit tests

[ ] Added
[x] Not required

Documentation

[ ] Updated build docs
[ ] Updated editor guidelines (https://docs.google.com/document/d/1PAWccdQ4tfaZsrEWmpDhvP3GH5RRmBOARFVp4b-kje8/edit?usp=sharing)
[x] Not required

Browser testing

[x] I have tested in the following browsers and environments (edit the list as required)

Latest version of Chrome on mac
Latest version of Firefox on mac
Latest version of Safari on mac
Safari on last two versions of iOS
Chrome on last two versions of Android

[x] Not required

Data protection

[x] Not relevant
[ ] This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Accessibility

[x] Automated WCAG 2.1 tests pass
[x] Manual WCAG 2.1 tests completed
[x] I have tested in a screen reader
[x] I have tested in high-contrast mode
[ ] Any animations removed for prefers-reduced-motion
[ ] Not required

Sustainability

[x] Images are optimised and lazy-loading used where appropriate
[ ] SVGs have been optimised
[x] Perfomance and transfer of data considered
[ ] If JavaScript is needed alternatives have been considered
[ ] Not required

Pattern library

[x] The pattern library component for this template displays correctly, and does not break parent templates
[x] The styleguide is updated if relevant
[ ] Changes are not relevant the pattern library

FE look good to me - nice one @helenb : )


Community Board Links

The Community Board website and email links are empty. Need to give these real data.

Hmmm @kerrygathers is there data for this? Sorry if I missed it, I know you posted some things in Slack. Thanks.

Closed by #182


BadgedControl should have controllable visibility on just the badge

Is your feature request related to a problem? Please describe.
Typically a badge only shows when there is new information or updates. The badged control doesn't appear to have a method to disappear when the value is 0. Visibility controls the child control as well so that doesn't work to hide just the badge.
Describe the solution you'd like
A property such as BadgeVisibility that can be bound to would be great.

Hi @240026763 ,
it will disappear if you set your property to null instead of 0. You can use int? MyBadge {get; set;} for Binding

Happy coding
Tim

Thanks, this seems to work fine. I had to put in a value converter to basically make anything 0 or less return null.


Update Anakin, add Anakin_UniqueCardList

Update Anakin class with all deck-level operations and card-level operations
Implement all methods in Anakin_ModelManager
Update Anakin_VersionedAnakin, Anakin_UniqueDeckList

Pull Request Test Coverage Report for Build 83

0 of 166 (0.0%)  changed or added relevant lines in 6 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-7.5%) to 79.086%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/model/Anakin_Model.java
0
1
0.0%

src/main/java/seedu/address/model/Anakin_VersionedAnakin.java
0
29
0.0%

src/main/java/seedu/address/model/Anakin.java
0
31
0.0%

src/main/java/seedu/address/model/Anakin_deck/Anakin_UniqueCardList.java
0
34
0.0%

src/main/java/seedu/address/model/Anakin_deck/Anakin_UniqueDeckList.java
0
34
0.0%

src/main/java/seedu/address/model/Anakin_ModelManager.java
0
37
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/seedu/address/model/Anakin.java
1
0.0%

src/main/java/seedu/address/model/Anakin_ModelManager.java
6
0.0%

Totals

Change from base Build 80:
-7.5%

Covered Lines:
1437

Relevant Lines:
1817

💛  - Coveralls


[Bug]: Incorrect process identification when pino v7+ transports are used

Problem Description
When the @instana/collector is loaded into a Node.js application, but that application also uses pino v7+ transports, then the Node.js process is sometimes identified as thread-stream instead of using the actual application name. The reproduction also includes a scenario where the same transport is used as a pino destination (omit the MODE env variable), in such cases the process is correctly identified.
Note: I cannot reliable reproduce the problem, sometimes the process is correctly identified even when pino transports are used. The problem may have something to do with the fact that pino transports work by using worker threads, but that is as far as my knowledge of the problem goes.
Short, Self Contained Example
See reproduction repository
Node.js Version
See reproduction
package.json
See reproduction

package-lock.json
See reproduction

Hi there!
Thanks for providing the reproduction repository :)
I cannot reproduce the problem you are running into 🤔
In your example you are using logger.info.
Instana collector does not trace info logs, only warn, error or fatal level.
If you change this line to logger.warn or logger.error it should report the spans correctly.
I tested your example and it's working for me fine and shows: instana-pino-transport v1.0.0

Instana collector does not trace info logs, only warn, error or fatal level.

Yeah, logging collection seems to be working fine, it at the process identification where I am running into the problem described, but again I cannot reliably reproduce it either.
Thanks for checking.

Thank you.

We were now able to reproduce this. This only happens when the process is instrumented via NODE_OPTIONS="--require @instana/collector/src/immediate or via the Kubernetes autotrace webhook (which uses the same mechanism behind the scenes). Worker threads inherit the env, including NODE_OPTIONS which introduced some unexpected behavior, including the symptoms around changing the name you noticed.
A fix (#517) will be included in one of the next few releases.

Awesome, thank you.

The fix got merged and will be released next week 👍


Create sample.txt

sample doc

5 Points are assured. No Errors found by AI system, you must be really good in writing uipath code. An expert need to review your code and it will be done before next sunrise :)

@ancila-pulipaka
Welcome to Vajrang Organization! Begin your RPA journey with us by completing tasks daily.
Please create pull requests (PR) in GitHub and update the PR numbers in the tracker Excel


Remove old code

Purpose
EVM PR https://github.com/Taraxa-project/taraxa-evm/pull/160
How does the solution address the problem

Changes made

prnet cleaned-up successfully


Wait until the User Agent is retrieved by Commanders Act

Description
This PR enables a Commanders Act opt-in that ensures User Agent retrieval before sending events. This should avoid inconsistent User Agents from being forwarded to Mapp.
Changes made
Self-explanatory.

Maybe update Commanders Act from version 5.4.4 to 5.4.9 and test it.


Enhance String Diff representation in wave diffs

Before the diff window for text waves showed the full string in hexadecimal format if the entry is different in both waves.
With this change the window will only show the start of the difference and up to a maximum of 10 characters left and right. All normal letters in ASCII are shown as normal and the other letters are shown in readable notation (the name of the letter or hexadecimal form).
The window will also show which line, column and position in the full string where the first difference happen. There is no special handling of string that are only one line.
This commit also includes an example project in "internal_dev/TestTextWaveDiff".
Closing #274.

Am 19.10.2022 um 10:09 schrieb Max Brauer:

@.**** commented on this pull request.

In procedures/unit-testing-utils.ipf
https://github.com/byte-physics/igor-unit-testing-framework/pull/275#discussion_r999089314:

	return i

endif

endfor

return -1
+End

+static Function DetectEndOfLine(str, start, marker)

variable start
string str, &marker

variable i

for(i = start; i < strlen(str); i += 1)

if (!CmpStr(str[i], "\r"))

	if (!CmpStr(str[i + 1], "\n"))

This was an intended use of the Igor Feature. In other programming
languages i would check the length of the string first to not read
beyond its length.
I can add this check but its kind of duplicate because of the Igor behavior.

Good reasoning. You can't know that we don't want to exploit this Igor
behaviour. I've created
https://github.com/byte-physics/igor-pro-coding-conventions/issues/24 to
metion that in our coding conventions.

I have removed my changed version of Various.pxp from the commit.


Don't stop propagation of click events on the draggable.

I see no need to stop the propagation of click events.

See also #51, which suggests removing the click handler (and thus the dnd-selected callback) entirely.

when is this going to be merged?
stopPropagation is bad practice and hold back other functionality i need to implement

Agreed! I also need to have this merged in for work I am doing.

In the case of nested lists stopPropagation is needed, otherwise the dndSelected callback of the parent element would be fired as well. What we could do though is to only call stopPropagation if dndSelected is actually set.

In my case, I was having a problem where I was using drag-and-drop-lists on a child element of an element I was using BootstrapUI, and the stopPropogation was stopping the method I needed on BootstrapUI from being called. I needed other events on the parent element to be fired.

@marceljuenemann So stopPropagation() is needed to make dndSelected work on nested lists? That seems to strengthen the argument for just removing dndSelected altogether (see #51), because it is not actually needed for the drag and drop functionality.
The argument being that stopping the propagation on click events does cause issues and does prevent users of this lib from implementing certain features, in particular when the draggable items are only draggable by a handle (see #31). The dndSelected callback on the other hand does not really provide any value, and the selection model should be left to the user or a separate dedicated library (such as https://jtrussell.github.io/angular-selection-model/).

this is so annoying. prevent default can be used instead of stopPropagation, and then in the bubbled event one can check isDefaultPrevented()
this is an old issue that needs resolving - is anyone looking into this?