complete refactoring to respect streams and to avoid command-line argument

no hard coded values (uses Config object)
does not start a new child process
TODO: tests! ;-)

fixes koemei/gulp-node-inspector#4
fixes koemei/gulp-node-inspector#5

All right, the third commit should do the trick. gulp-karma was a good example. I'm pretty satisfied with the result, but I'm still wondering how to trigger the 'close' event. Did I missed somewhere a button in the DevTools?

see https://github.com/node-inspector/node-inspector/issues/547

lgtm, merging


Android builds loses .env in gradle step, breaking build

Build/Submit details page URL
https://expo.dev/accounts/derk-jan/projects/issue-eas-env/builds/fefe4947-a8fc-418b-8172-d9e7736fc2e4
note: this was a fresh project using nxp create-expo-app. Even when doctor issues are resolved, problem persists. It doesn't matter if it's app.config.json, app.config.js, app.config.ts. Function export, or object export. It can even be app.json, and still show up as undefined after build succeeds
Summary
TL;DR this used to work in SDK 46 / 4 months ago. .env doesn't load in native build step.

When using .env to inject values, it breaks the all the builds (including iOS), because at the final step, the env values are no longer available, where they were available before.
In the build log above you should see app.config.js ENV foo which indicates the ENV is loaded correctly. You should see this in the expo-doctor step and the prebuild steps.
Finally, gradlew breaks. You can make it not break by removing the throw in app.config.js, but then the app builds and shows undefined.

Minimal repo with barely any code provided below
note: this works fine in web
Managed or bare?
Managed
Environment
  expo-env-info 1.0.5 environment info:
    System:
      OS: Windows 10 10.0.22621
    Binaries:
      Node: 16.19.0 - ~\scoop\apps\nvm\current\nodejs\nodejs\node.EXE
      Yarn: 3.5.1 - ~\scoop\apps\nvm\current\nodejs\nodejs\yarn.CMD
      npm: 8.19.3 - ~\scoop\apps\nvm\current\nodejs\nodejs\npm.CMD
    npmPackages:
      @expo/webpack-config: ^18.0.4 => 18.0.4
      expo: ^48.0.17 => 48.0.17
      react: 18.2.0 => 18.2.0
      react-dom: 18.2.0 => 18.2.0
      react-native: 0.71.8 => 0.71.8
      react-native-web: ~0.18.12 => 0.18.12
    Expo Workflow: managed

Error output
No response
Reproducible demo or steps to reproduce from a blank project
Repro: https://github.com/XPBytes/issue-expo-eas-env

Make .env
MY_TEST_VALUE="foo"

and load it in a file, so you know it works / is broken. In this case App.tsx text can be replaced.
// App.tsx
{process.env.MY_TEST_VALUE}

Use 'transform-inline-environment-variables' for babel
Now make any build
eas build --platform android

Workaround
eas secret:push --scope project --env-file .env

Then go to the secrets page and delete anything that had an empty value. Now it doesn't use your pushed .env anymore, but instead uses the secrets. It's not optimal, but it works!

I suspect when app config is resolved during gradle build the cwd is not set to the root of the project, so .env file is not found.
If I'm right sth like
require('dotenv').config({ path: path.join(__dirname, '.env') })

should work for you

I will try this out on the linked repro and report back here.
Do note that this used to work and recently broke.

The build https://expo.dev/accounts/derk-jan/projects/issue-eas-env/builds/84b68050-7585-41c2-9b44-ac671272bf2a succeeded. I will do an APK build to verify it does still have the .env values.
In this case, probably want to update the relevant section in the docs and perhaps add it to this one.
Also note that using direnv isn't documented here other than redirecting to their docs with no example or implementation guide and that also didn't work for me.

In this case, probably want to update the relevant section in the docs and perhaps add it to this one.

First link you posted (https://docs.expo.dev/guides/environment-variables/) describes how to use env variables in expo project, it does not say anything about EAS Build, but at the beginning of that page there is a note with a link to a page about configuring env variables with EAS (the second link you posted)
We provide to ways of passing env variables to the build "env" field in eas.json and EAS Secrets. dotenv,direnv and other solution can probably by used but they are not considered to be "recommended" way of building on EAS, We of course want those approaches to work, but also we don't want to be responsible to maintain compatibility with those tools or explain how to use them.

unfortunately it "works" but it doesn't. The value is replaced with undefined.

From what I see in the gradle phase correct value is printed, so value in app.config.js seems to be resolved correctly in that step.
I never used babel plugin to inline vars in the code, but reading the docs from https://docs.expo.dev/guides/environment-variables/#using-babel-to-inline-environment-variables-during-build-time I interpret that this plugin should take variables from it's environment, but when you add that dotenv part in your app.config.js it's setting env variables in that js script. I don't see anything that would give an expectation that setting env variables in app.config.js would affect env variables visible to babel.
To be honest I'm not really sure if this is a bug or intended behavior, but regardless this is not an EAS issue, it would also happen if you run prebuild and try to build if from e.g. Android Studio. If you disagree with that explanation and still believe this is a bug, you can open an issue in github.com/expo/expo

@wkozyra95 I understand you not wanting to take responsibility for this.
However, there isn't a single issue template in expo/expo that matches this problem. It is a problem in the EAS build pipeline that did not exist before. We have been using the exact same build steps for over a year using EAS, using dotenv, that now suddenly is broken.
It's listed in the documentation, but by saying "yeah it should maybe work but also don't do it because it's not the recommended way" doesn't really help anyone. Either remove it from the docs or help us keep it working.
Using the "env" key in eas.json does not allow dynamic injection, forcing us to completely have to rewrite all CI. It also is incredibly shitty DX, which is sorta mentioned on the same page. This may be nice in theory, but in reality, whilst it may work, this feature (dotenv working as before) now no longer working without that being a purposeful change has already cost us several weeks of dev time.
I have read the docs many times over, and I created the repro to show that what is written in the docs just doesn't work any more. I don't know what else can be expected of a paying user of this service trying to help debug an issue.

It is a problem in the EAS build pipeline that did not exist before

No, this is not an issue with EAS Build, nothing changed there that would affect this case. Also, as I mentioned, if you would run npx expo prebuild and build resulting project in android studio you would get the same issue.

We have been using the exact same build steps for over a year using EAS, using dotenv, that now suddenly is broken.

Nothing changed on EAS related to that, EAS just runs appropriate gradlew commands there. If sth changed it's a result of changes in your projects (maybe react native upgrade, maybe upgrade of some core expo packages).

so I think it's a structural problem with ENV not being forwarded to the gradle process; the same issue happens on iOS builds.

No envs were ever passed to the gradle process if you used flow that you have in a repro repo. If it worked before then it worked because app.config.js was evaluated in the same process as babel, which might have changed (just guessing).

I have read the docs many times over, and I created the repro to show that what is written in the docs just doesn't work any more.

No EAS docs even mentioned direnv or dotenv usage. https://docs.expo.dev/build-reference/variables/ documents how to use envs on EAS Build.

If you run the built apk you can see that the value is undefined

I'm not claiming there is no issue(but I'm not convinced there is one either). When app.config.js was evaluated on EAS it resolved the correct value, so it's not an issue with passing those values to the build, but the issue is with project configuration to use those envs.

Happy to try to have someone else "fix" this, but I don't know which issue template I should pick or how I should go about it, so any pointers would be appreciated.

If this is really a regression then it would be caused by either a change in react-native or versioned expo cli. I would recommend using CLI template for the issue.
I can't help you with making your current flow  work, I'm not convinced based on docs that it even supposed to work, but if you just want to fix passing envs to the build, then you can either:

stop using babel transform. You know from logs on the last build you linked that env value in app.config.js was resolved correctly, so you can use extra field to pass it to the js bundle. https://docs.expo.dev/guides/environment-variables/#using-the-extra-field
define your env variables in eas.json + EAS Secrets. Values set there are visible during entire build process, so this way you would be sure that whenever babel is executed those envs are present.

I think your guesses (either it being processed in the same process or something changing in expo's cli) are good pointers and only supported by the fact that I was able to make an old commit build just fine on EAS.
I have spoken at length with Brent about this and the upcoming SDK 49+ changes to .env strategies matches what the build process we had for the past year (which was broken but likely not because of EAS CLI) was trying to accomplish.
In the meanwhile, using EAS Secrets is exactly what we've been using to make it pass temporarily, which is meh because it starts obfuscating those values in the log even when they are not secrets, but it's good enough for now.
Thanks for the time.


Improve task timeout handling

Now the task timeout is controlled by the time argument passed
to the wait() method. This allows some tasks, such as db backups
can take longer to run.

Coverage increased (+0.7%) to 99.068% when pulling b4ab7bfddb5ed893324cadf82b095419d45e16ca on wait-timeout into 278c43b0ca8a435a381d5997be8ce40f73a31e8e on master.


Fix Dashboard and Heapster and HostNetwork Tests for k8s

Fix the three failed tests, tested on version v1.1.0-dev5-rc5

LGTM


⚠ Roblox Site has degraded performance

In 377eaeb, Roblox Site (https://roblox.com/) experienced degraded performance:

HTTP code: 503
Response time: 1279 ms

Resolved: Roblox Site performance has improved in 1c503c5 after 10 minutes.


Rails 4.2 + Globalize 5.0.1: translate_inputs only displays last field

using the example ActiveAdmin form:
form do |f|
  f.translate_inputs do |t|
    t.input :title
    t.input :description
  end
end

with Globalize 5.0.1, the translate_inputs helper will only display the :description input in the tabbed UI.  (whatever line is last in the block is the only thing displayed.)  hence, the hidden field for :locale is not returned either.
p.s. using the Rails 4.0-compatible branch at https://github.com/twintags/activeadmin-translate

Try following:
form do |f|
f.inputs do
f.translate_inputs do |t|
t.input :title
t.input :description
end
end
end

:+1:

Works for me!
Don't forget to add
  # ...
  f.actions
end

at the end of your form for submit options.

You guys are gods!!!


Docs sidebar UI bug 650

Description
Fix bug on docs site with sidebar going askew - see issue below.
Enhancement added: user can hide/show the docs sidebar
Related Issues

Fixes #...
Closes #...
Resolves #650

Additional Context

PR is against master branch.  Should I have used devel instead?

LGTM!


Move recipe registration and all recipes will be catalog types.

Moves the SmeltingRecipe and CraftingRecipe registration to the GameRegistryEvent.Register event.
CraftingRecipes must be reloadable, because they are loaded from json files in resource (data) packs.
Turn SmeltingRecipe (Recipe) into a CatalogType, it's only a matter of time before smelting recipes are also loaded from json files, better prepare for this. This also makes it consistent with the crafting recipes which are already CatalogTypes.

~wip

~wip


subprocess.call() —> call() to avoid NameError

>>> from subprocess import call
>>> call('ls')  # this works
>>> subprocess.call('ls')  # but this raises a NameError because subprocess was not installed
Traceback (most recent call last):
  File "<string>", line 1, in <module>
NameError: name 'subprocess' is not defined

Kicking myself over these kind of errors, thanks for the fix  👍


Add Milestones

Project
C4GT - Sunbird ED
Changes
Milestones
Notes
If there are any further notes.

There is nothing to mention in the learnings as there was a blocker
On Mon, Aug 28, 2023, 1:34 PM Shubhangi Gupta @.***>
wrote:

@.**** requested changes on this pull request.
In docs/2023/Sunbird ED/content detail page as
widget/updates/2023-08-25.md
https://github.com/Code4GovTech/c4gt-milestones/pull/786#discussion_r1307083991
:

@@ -4,10 +4,7 @@ author: Shivam Chaturvedi

Milestones
-- [ ] Give the description about Milestone 1
-- [ ] Give the description about Milestone 2
-- [ ] Give the description about Milestone 3
-- [ ] Give the description about Milestone 4
+- [x] Due to the unavailability of the server's content the widget was not tested in the portal.
Screenshots / Videos
Please add learnings.
—
Reply to this email directly, view it on GitHub
https://github.com/Code4GovTech/c4gt-milestones/pull/786#pullrequestreview-1597740292,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYH6NWZ7R6ATON7FIUPZOD3XXRGIHANCNFSM6AAAAAA4ARIZSQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


x/website: tests failing on Android builders

Two tests seem to be consistently failing on the android-*-emu builders (https://build.golang.org/log/2b88b2f804799f9e5780270b06f07542b8c400ab):
-- FAIL: TestWeb (2.41s)
    godoc_test.go:48: Building godoc: exit status 1
FAIL
exitcode=1FAIL	golang.org/x/website/cmd/golangorg	68.529s
?   	golang.org/x/website/cmd/googlegolangorg	[no test files]
--- FAIL: TestStaticIsUpToDate (0.01s)
    gen_test.go:23: error while generating static.go: open analysis/call3.png: no such file or directory
    gen_test.go:27: static.go is stale.  Run:
          $ go generate golang.org/x/website/content/static
          $ git diff
        to see the differences.
FAIL
exitcode=1FAIL	golang.org/x/website/content/static	66.472s

We should either fix those tests, or (given that we're unlikely to be hosting golang.org on a mobile device any time soon) skip the x/mobile tests on those builders.
CC @toothrot @dmitshur @andybons

TestStaticIsUpToDate is failing on that builder likely because it doesn't have local filesystem access. The test is passing on linux/amd64.
TestWeb is also failing on aix and illumos because it's unable to build or is missing the compiler.
I think it's reasonable to skip all these architectures for x/website tests.

TestWeb is also failing on aix and illumos because it's unable to build or is missing the compiler.

If we disable the tests, these failures will become invisible. These seem fixable, so I'll leave them alone for now.

Something that's odd is that buildGodoc is supposed to skip TestWeb when runtime.GOOS == "android". Is GOOS not "android" on android-*-emu builders?


Type checking does not works for indexable type with number keys OR string keys

Try with newest TypeScript
TypeScript Version: 3.7.0-dev.20191018
Result: has not been fixed.
Search Terms:
typescript indexable type string keys or number keys
Code
enum PROPERTIES_TYPES {
  NUMBER = "NUMBER",
  STRING = "STRING"
  // ETC.
}

interface IStringPropertySpecification {
  type: PROPERTIES_TYPES.STRING;
  required: boolean;
  nullable?: boolean;
  newName?: string;
  emptyStringIsAllowed: boolean;
  allowedValues?: Array<string>;
  invalidValueSubstitution: string;
  defaultValue?: string;
}

interface IObjectDataSpecification__StringKeys {
  nameForLogging: string;
  properties: {
    [propertyName: string]: IStringPropertySpecification;
  };
}

interface IObjectDataSpecification__NumberKeys {
  nameForLogging: string;
  properties: {
    [propertyName: number]: IStringPropertySpecification;
  };
}

type ObjectDataSpecification = IObjectDataSpecification__StringKeys | IObjectDataSpecification__NumberKeys;

const dataSpecification: ObjectDataSpecification = {
  nameForLogging: "Test",
  properties: {
    foo: "asdfsadffsd" // Valid!!! No type errors!
  }
};

Expected behavior:
The error occurrence. I suppose, it must be:
TS2322 Type 'string' is not assignable to type ObjectDataSpecification
Actual behavior:
TypeScript ignores this error. However, my PhpStorm knows right autocompletes:

Playground Link: https://jsfiddle.net/pfg1mq96/
Why I need so strange type as ObjectDataSpecification?
The ObjectDataSpecification has been created for external data validation. It's known in advance, which type external data SHOULD be, but it's unknown in advance, which data ACTUALLY WILL BE. If data satisfies ObjectDataSpecification, it will be cast as below:
const validData: IValidData = rawData as IValidData;

In above case, IValidData will be:
interface IValidData { foo: string; }

Normally, programmers should not create type like:
type ConfusingType {
  1: string;
  foo: number;
}

However I can't hope for high-quality API in the team work, The API team could define ANYTHING includes strange structure like above ConfusingType . Even it happens, I must to describe the ConfusingType with my ObjectDataSpecification. It will be:
const dataSpecification: ObjectDataSpecification = {
  nameForLogging: "ConfusingType ",
  properties: {
    1: {
      type: PROPERTIES_TYPES.STRING,
      required: true,
      emptyStringIsAllowed: false,
      invalidValueSubstitution: "---"
    },
    foo: {
      type: PROPERTIES_TYPES.NUMBER,
      required: true,
      numberType: NUMBER_TYPES.NATURAL_NUMBER,
      invalidValueSubstitution: 1
    }
  }
};

Then, my library validates external data according to dataSpecification.

A simpler repro, that has less going on:
interface IValue {
  value: string
}

interface StringKeys {
    [propertyName: string]: IValue;
};

interface NumberKeys {
    [propertyName: number]: IValue;
}

type ObjectDataSpecification = StringKeys | NumberKeys;

const dataSpecification: ObjectDataSpecification = {
    foo: "asdfsadffsd" // Valid!!! No type errors!
};

Play

Is it just me or has the OR type just become f*cking broken in TypeScript 3? I don't know which version it started happening, but TypeScript 2 just felt like the best balance in providing helpful type checking without being overly anal.
For example, error messages like these have caused me to constantly rage at Typescript because of clearly not following what "OR" is supposed to mean.
TypeScript error in /home/thakker/Documents/GitHub/crqcentral/src/Models/helpers.ts(34,64):
Property 'then' does not exist on type 'Promise<GraphQLResult> | Observable<object>'.
  Property 'then' does not exist on type 'Observable<object>'.  TS2339

This is clearly TypeScript's fault because one of the possible return types is clearly listed as a Promise, and yet it doesn't allow me to use .then() because it picks the other type to be anal about. It treats OR as AND.

@selipso please file a separate bug if you think you've found a bug

@ahejlsberg I think you have a PR in progress for this?

Even simpler repros:
const obj1: { [x: string]: number } | { [x: number]: number } = { a: 'abc' };  // No error!
const obj2: { [x: string]: number } | { a: number } = { a: 5, c: 'abc' };  // No error!

Both assignments above should be errors, but neither are. The issue is that our excess property logic doesn't properly handle union types with constituents that have index signatures.

@ahejlsberg Thank you for the fixing!
In which version this fix will be available?


fix(ndt5/c2s): start upload when connection is ready

Continuation of https://github.com/m-lab/ndt-server/pull/170
Code uses the same pattern as found in https://github.com/m-lab/ndt-server/blob/master/testdata/unittest_client.js#L250-L291
FYI: @ryanrolds

This change is

Pull Request Test Coverage Report for Build 923

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.813%

Totals

Change from base Build 911:
0.0%

Covered Lines:
1446

Relevant Lines:
1959

💛  - Coveralls


CE-810 - Refactor Prevention and Education Form and Details View

Description
Refactoring the Prevention and Education form and details view.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Manually Tested
[x] Ran/confirmed cypress tests ran without errors

Checklist

[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Further comments

Fixing issues with this PR. Submitted from fork by accident.


Remove place.flush from global scope

Was added to both place and the global scope by accident in #4141.

whoops


nixos/clevis: add support for parent encrypted zfs datasets

Description of changes
Fix for https://github.com/NixOS/nixpkgs/pull/257525#discussion_r1635409876

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg test installer.clevisZfs installer.clevisZfsParentDataset installer-systemd-stage-1.clevisZfs installer-systemd-stage-1.clevisZfsParentDataset

My only comment would be that the lines you changed are getting pretty difficult to read and comprehend

I've tried running it through nixpkgs-fmt, but it didn't do anything (I've opened https://github.com/nix-community/nixpkgs-fmt/issues/331).
If there's "recommended" way of splitting long lines of nix code I'll be happy to apply it here.

Will this fix be backported?

Will this fix be backported?

It's not a breaking change afaik, so it should be acceptable


Nit: Update to<EMAIL_ADDRESS>

How to categorize this PR?

/kind task
/priority normal
What this PR does / why we need it:
@ThormaehlenFred recently asked to update to<EMAIL_ADDRESS>Ref https://groups.google.com/d/msg/golang-announce/f2c5bqrGH_g/GnH6k56AAAAJ
Release note:

NONE

/lgtm


rename repo to r2-opds-swift

creating this issue as a reminder for myself

We can re-open that discussion but basically:

the OPDS parser is useful, even outside of the context of R2 itself (for example, an app based on FolioReader could still benefit from using this parser)
in terms of dependency, it's only tied to r2-shared-swift

That's the main reason why this repo isn't prefixed with r2-*.

I thought about that as well and fully agree. but we can discuss this and why i thought of renaming.


updated wacom-tablet (6.3.15-2)

Same as https://github.com/caskroom/homebrew-cask/pull/15334

Merged as 97251057df86d7aea1e5a014d96db18f8b7c4487.


the msg with _ The underline is not shown

if i send a msg like 'user_name is eric', show  username is eric the _ underline is not shown

Which external module is it?

https://github.com/mattmezza/msgdown

fixed


Zsh completions doesn't display list of available commands when pressing tab

Expected behaviour

Pressing <TAB> should display a list of commands
Example with gem:

When typing a command and there's only one possible option, it should complete the whole command
Example with gem:
gem ins<TAB>

# completes the command
gem install

Actual behaviour

Pressing <TAB> DOES NOT display a list of commands
Example:
rbenv <TAB>

# it shows three dots `...` for like 0.3s and then does nothing
rbenv

When typing a command and there's only one possible option, it DOES complete the whole command
Example:
rbenv  ins<TAB>

# completes the command
rbenv install

Some extra info

rbenv version
OS
Shell
Shell config

1.2.0-87-ge8b7a27
Linux x86_64
zsh
zsh4humans

The only thing related to rbenv in my .zshrc is this:
eval "$(~/.rbenv/bin/rbenv init - zsh)"

Hi, thanks for reporting. It looks like your zsh shell has lots of customizations. Could it be that one of these customizations is affecting the behavior of typing rbenv <TAB>?
Here is what I get when I press Tab:
$ rbenv
--version           global              install             root                version             version-name        which
commands            help                local               shell               version-file        version-origin
completions         hooks               prefix              shims               version-file-read   versions
exec                init                rehash              uninstall           version-file-write  whence

My ~/.zshrc:
autoload -U compinit
compinit -i

autoload colors
colors

It does have a lots of customization, mainly because of zsh4humans (sort of a zsh framework). Until now I've never experienced issues with completions, until now.
My guess is that rbenv use the old completion system for zsh, compctl and until now I have used - rather the programs I use, handle completions with - the 'new' system (completions are managed by underscore files, like _rbenv and are in the fpath).
Also, in my zsh I don't declare autoload -U compinit anywhere, this is manged my zsh4humans as far as I know.
I guess this is mainly a problem with my zsh config (zsh4humans).
So I will reach with them ans see if I can fix this. Thanks.

My ~/.zshrc:
autoload -U compinit
compinit -i
autoload colors
colors

I tried this with no avail.

Correction, zsh4humans does have the autoload line, in particular this one: autoload -Uz +X compinit || return.

With the help of this, and editing the completion file rbenv.zsh accordingly:
@@ -2,11 +2,10 @@ if [[ ! -o interactive ]]; then
     return
 fi

-compctl -K _rbenv rbenv
+autoload -U compinit
+compdef _rbenv rbenv

 _rbenv() {
-  local words completions
-  read -cA words

   emulate -L zsh

@@ -16,5 +15,5 @@ _rbenv() {
     completions="$(rbenv completions ${words[2,-2]})"
   fi

-  reply=("${(ps:\n:)completions}")
+  compadd - "${(ps:\n:)completions}"
 }

I got it working

I don't know if this will broke someone else completions, but maybe you can test it and if everything works it could be a potential fix for other people with this problem.

It's true that we still use the outdated compctl system and that we could potentially migrate to the new completion system, especially to make use of features like autoloading and descriptions.
However, the point that I was making is that even with the compctl-based approach, rbenv zsh completions should work, as evident by them working for me in zsh 5.9 with a very minimal zsh setup. In fact, I've just verified it again: I've started an instance of zsh with no startup files (no zprofile or zshrc), loaded our (legacy) completion script, and it just works. I do not know why it doesn't work for you.

I've just verified it again: I've started an instance of zsh with no startup files (no zprofile or zshrc), loaded our (legacy) completion script, and it just works. I do not know why it doesn't work for you.

You're right, I tried this as well and it didn't work for me for some reason

Could you run zmodload to check if zsh/compctl is listed?

It is listed, it's the first one to appear.

Well, that is really weird.
You're welcome to submit a PR with your changes that transition to compsys! I was hoping to explore improving zsh completions anyway by adding descriptions to completed commands.

Thanks for taking your tome to reply btw!
I will submit a PR with those little changes mentioned above that transition to compsys. However it doesn't have descriptions.
I'm actually working in that version (with descriptions), when I finish it (or at least most of it) I will submit another PR.

Thanks a lot!
I also had a code spike locally for adding descriptions, so I have added it to your PR. Please take a look before you spend time implementing the same! Of course, simpler approaches than mine are aways welcome.

Fixed in #1569


Implement well-defined handling of unrecoverable errors

Implemented now as __builtin_trap() for GCC/Clang and __debugbreak() for MSVC, which are the recommended means of stopping a program on an unrecoverable situation.
Some  _TRAP-suffixed error macros added so this can be reused plus removing the need of double checks. GENERATE_TRAP is implemented as well.
Plus transient avoidance of the flood of warnings emitted by Clang when checking this for NULL.
Plus removal of the pointless while(0) loop in some error macros.
Fixes #8754.

Great! Why don't we call it assert?

Since all these ERR_FAIL_* functions are "inverse asserts" and they decided
on that naming, I just picked something that would follow.
El 27 may. 2017 8:24 p. m., "Ignacio Etcheverry"<EMAIL_ADDRESS>escribió:

Great! Why don't we call it assert?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/8943#issuecomment-304468587,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALQCtqB5I5yTipXH17YCqLbRIxhCKEzoks5r-GpLgaJpZM4NoI3V
.

I think it would be better to use the ERR_FAIL_ prefix for functions that fail by returning to the caller and the ASSERT_ prefix in this case. IMO it's clearer and less verbose this way.

I like the idea of making the name shorter.
But I insist in the fact that they have an inverted logic compared to asserts, so ASSERT_ would be misleading. What do you think about something like SEVERE_FAIL_(COND/INDEX) or even CRASH_(COND/INDEX)? And for the plain trap used when the code reaches an unexpected point, SEVERE_FAIL or CONTROLLED_CRASH.
This could open an interesting debate: is it good that Godot-style asserts check for error conditions instead of the standard practice of checking for some invariant to be met?

Well, the index variants are indeed readable as positive conditions, but you get my point.

Sorry for spamming. This is my proposal:
CRASH_COND(wrong_condition)
CRASH_BAD_INDEX(index, size)
CONTROLLED_CRASH()

What do you mean they have inverted logic compared to asserts?

AIUI, asserts see a problem if the value is false, while Godot's ERR_ macros see a problem if the value is true. I believe that's the inverted logic @RandomShaper is talking about (correct me if I'm wrong).

Yes, that's what I mean.

Oh, I see. Then, in my opinion, we should make it crash when the condition is false and name it ASSERT.

I've updated the description of this PR (and pushed some changes).
I think it would be more convenient to postpone the idea about inverting the logic of the assertions so this one can be considered finished ASAP.
Maybe an issue to discuss that could be opened.

Pushed.

That's probably the case.
I've switched to VS 2017 and I haven't been able yet to educate it about
not adding them.
I'll fix it ASAP.
El 24/06/2017 a las 23:33, Rémi Verschelde escribió:

@akien-mga commented on this pull request.

In core/error_macros.h
https://github.com/godotengine/godot/pull/8943#discussion_r123885911:

@@ -1,4 +1,4 @@
-//
+//

Did you add a BOM by any chance?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/8943#pullrequestreview-46134200,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALQCtpJ5hwTgrY-PtpntC0apLmahnE8Kks5sHYCggaJpZM4NoI3V.

BOM removed.

do-while(0) constructs added back to the index error macros with a note about why.
I'm still not convinced, though. Anyway, one day someone will be able to implement them as true functions so we all are happy. :)


Unit test failure of the TestAsynchronousExecutionPolicy

The failure happens when running the unittest suite on a local machine (laptop) with 2 Codes - 4 Threads. The failure is the following:
FAIL: test_kbd_interrupt_in_wait_with_limited_concurrency (unittests.test_policies.TestAsynchronousExecutionPolicy)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/manitart/reframe_dev_local/unittests/test_policies.py", line 310, in test_kbd_interrupt_in_wait_with_limited_concurrency
    self._run_checks(checks, 2)
  File "/home/manitart/reframe_dev_local/unittests/test_policies.py", line 289, in _run_checks
    self.assertEqual(4, self.runner.stats.num_cases())
AssertionError: 4 != 3

Internal issue: https://madra.cscs.ch/scs/reframe/issues/582

This happens sporadically and appeared also once during running by Travis CI.

This has become recurring. We should address it asap.

I spotted the problem and it appears to be caused by the (wrong) assumption the unit tests make that none of the submitted tasks would finish at the time when the partition task limit is reached. When this limit is reached, all the currently running tasks are polled. If any of them has finished (in this case the KeyboardInterruptCheck), it will be waited for, and this is where the KeyboardInterrupt is raised. At this point not all of the tasks may have been submitted leading to this unit test failure. Here is a bit of code to always trigger the failure:
diff --git a/reframe/frontend/executors/policies.py b/reframe/frontend/executors/policies.py
index 3f4d4a7..e8bc481 100644
--- a/reframe/frontend/executors/policies.py
+++ b/reframe/frontend/executors/policies.py
@@ -189,6 +189,9 @@ class AsynchronousExecutionPolicy(ExecutionPolicy, TaskEventListener):

             self._failall(e)
             raise
+        finally:
+            import time
+            time.sleep(.5)

     def _poll_tasks(self):
         """Update the counts of running checks per partition."""

This seems not to be fixed entirely. It still happens from time to time on Travis CI. Perhaps we need to increase the sleep time of the KeyboardInterruptCheck.

The problem currently is a bit different. The failure we get is the following:
======================================================================
FAIL: test_kbd_interrupt_in_wait_with_concurrency (unittests.test_policies.TestAsynchronousExecutionPolicy)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/eth-cscs/reframe/unittests/test_policies.py", line 299, in test_kbd_interrupt_in_wait_with_concurrency
    self._run_checks(checks, 4)
  File "/home/travis/build/eth-cscs/reframe/unittests/test_policies.py", line 289, in _run_checks
    self.assertEqual(4, self.runner.stats.num_failures())
AssertionError: 4 != 3

It seems that at the time the KeyboardInterruptCheck fails, one of the SleepChecks has already finished. This is likely to happen, because all of the tests have now the same runtime more or less (1s). I think that increasing the sleep time of the SleepChecks in this test to 1.5s-2s will allow it to pass safely.
The general idea for this test is to allow enough time for all the four checks to be submitted and at the same time we need the KeyboardInterruptCheck to finish first, so as to make the framework kill the remaining three.

Fixed by #154.


Allow to have the app set late for FlaskTracing.

Addresses #22

Hey @denisdubovitskiy does this looks fine to you? Does this solve your needs? Let me know ;)

@carlosalberto seems better enough ;-). But what if you need to initialize a tracer by configuring it from the app.config (I mean host, port, service name, etc?

Init_app approach actually allows you to defer actual object creation/initialization. It means that if I call FlaskTracer() without any args and then pass an app in init_app() - the tracer will be initialized using app.conf vars during app creation, not on any other level. As an example you can see how other useful modules provide such a functionality. To get an idea, I recommend you to look into the sources of FlaskRedis or FlaskSQLAlchemy - most widely used ones

I see. I'm going to rename the name to init_app to make it more Flask-esque.
About the configuration being taken from app.conf I will cook later some another PR, as this would be needed on the base case as well (that is, Flask(app=app), and consume both the passed arguments and the ones in app.conf, if any).

Hi there! Is there a timeline for when this will be merged into master? This functionality is definitely super handy!

@etmitchell @carlosalberto Yeah! We're also waiting for this PR to be merged!

Any changes?

Did this ever get merged? Seems like it passes checks, code is complete, etc.

This package is no longer being maintained, users should migrate to the opentelemetry-api package.
Closing.


Add editor setting for spin slider sensibility

This PR adds an editor setting "Float Drag Speed" to control the base speed of dragging EditorSpinSlider nodes. It is applied directly to grabbing_spinner_dist_cache which means that all the other logic (pressing shift to slow down; pressing control to snap to integers; and always being a multiple of step) works flawlessly with the new speed. The initial value for the setting is 5.0 to increase the base speed.
Closes godotengine/godot-proposals/issues/3017
Probably also makes godotengine/godot-proposals/issues/2760 obsolete. That proposal requests a key to increase the drag speed. With this PR it would instead have an increased base speed, using the existing shift modifier to slow the speed down if needed. This is in line with other applications like blender that use a similar approach.

I think the setting should influence the speed of dragging both floating-point and integer values.

it does already influence the integer values, as those are calculated based on this floating point value

Rebased on current master and adjusted to use EDITOR_SETTING macro like all other settings in master. Therefore this cannot be easily cherry-picked for 3.x anymore. Should I make a second PR for 3.x once this is accepted?

Updated to work with current master. From my side this is ready now.

And now the CI should be happy too :crossed_fingers:

It crashes when generating the documentation, instantiating EditorSpinSlider while probably EditorSettings doesn't exist as a singleton. From the CI logs:
 editor/gui/editor_spin_slider.cpp:709:63: runtime error: member access within null pointer of type 'struct EditorSettings'
core/object/object.cpp:311:6: runtime error: member access within null pointer of type 'const struct Object'

================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.1.dev.custom_build (67caeac3de2cb07e1907fbac65cb4e99d19a8914)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] ./bin/godot.linuxbsd.editor.dev.double.x86_64.san(+0x3ae94384) [0x55b998cc9384] (??:?)
[2] /lib/x86_64-linux-gnu/libc.so.6(+0x43090) [0x7f91b19f2090] (??:0)
[3] Object::get(StringName const&, bool*) const (??:?)
[4] EditorSpinSlider::EditorSpinSlider() (??:?)
[5] Object* ClassDB::creator<EditorSpinSlider>() (??:?)
[6] ClassDB::instantiate(StringName const&) (??:?)
[7] ClassDB::class_get_default_property_value(StringName const&, StringName const&, bool*) (??:?)
[8] ./bin/godot.linuxbsd.editor.dev.double.x86_64.san(+0x44e43d37) [0x55b9a2c78d37] (??:?)
[9] DocTools::generate(bool) (??:?)
[10] EditorHelp::generate_doc(bool) (??:?)
[11] EditorNode::EditorNode() (??:?)
[12] Main::start() (??:?)
[13] ./bin/godot.linuxbsd.editor.dev.double.x86_64.san(main+0x3da) [0x55b998cc8a83] (??:?)
[14] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3) [0x7f91b19d3083] (??:0)
[15] ./bin/godot.linuxbsd.editor.dev.double.x86_64.san(_start+0x2e) [0x55b998cc85ee] (??:?)
-- END OF BACKTRACE --
================================================================

Thanks!


--include-extensionless has no effect

The --include-extensionless option appears to be broken: in _parse_command_line(), it's never forwarded the actual Query object.

Fixed here: https://github.com/facebook/codemod/commit/86789e10e0ae2b236129620d2d9f139afa04d9c4

Thanks! Sorry for not closing this sooner.


[Swift] Fix new test for review feedback [4.2]

Description: This is a follow-up to https://github.com/apple/swift-lldb/pull/738. @adrian-prantl pointed out that the test was using an idiom that would prevent it from failing if the wrong output was produced.

Risk: None, this PR just updates the test.

Reviewed by: @adrian-prantl

@swift-ci Please test


Fix TF-Probability module name for Normal distribution latent

Currently Normal distribution latent mode does not work due to a typo in the use of imported module (should be tfd instead of tfp). This can be quickly checked by:
python dreamerv3/train.py --logdir ~/logdir/$(date "+%Y%m%d-%H%M%S") --configs dmc_vision --rssm.classes 0

This PR fixes that.

Thanks!


Compile current openssl version with VS 2017 failed

I tried to compile the current openssl distribution with VS 2017 and it failed with the following error message:
c:\download\openssl-1.1.0f\openssl-1.1.0f>nmake

Microsoft (R) Program Maintenance Utility, Version 14.10.25019.0
Copyright (C) Microsoft Corporation. Alle Rechte vorbehalten.

        "C:\Perl64\bin\perl.exe" "-I." -Mconfigdata "util\dofile.pl"  "-omakefile" "crypto\include\internal\bn_conf.h.in" > crypto\include\internal\bn_conf.h
        "C:\Perl64\bin\perl.exe" "-I." -Mconfigdata "util\dofile.pl"  "-omakefile" "crypto\include\internal\dso_conf.h.in" > crypto\include\internal\dso_conf.h
        "C:\Perl64\bin\perl.exe" "-I." -Mconfigdata "util\dofile.pl"  "-omakefile" "include\openssl\opensslconf.h.in" > include\openssl\opensslconf.h
        "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\nmake.exe" depend && "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\nmake.exe" _all

Microsoft (R) Program Maintenance Utility, Version 14.10.25019.0
Copyright (C) Microsoft Corporation. Alle Rechte vorbehalten.

Microsoft (R) Program Maintenance Utility, Version 14.10.25019.0
Copyright (C) Microsoft Corporation. Alle Rechte vorbehalten.

        "C:\Perl64\bin\perl.exe" "util\mkbuildinf.pl" ""cl" """ ""VC-WIN64A"" > crypto\buildinf.h
        cl  /I "." /I "crypto\include" /I "include" /I "crypto" -DOPENSSL_USE_APPLINK -DDSO_WIN32 -DOPENSSL_THREADS -DOPENSSL_NO_STATIC_ENGINE -DOPENSSL_PIC -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_MONT5 -DOPENSSL_BN_ASM_GF2m -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DRC4_ASM -DMD5_ASM -DAES_ASM -DVPAES_ASM -DBSAES_ASM -DGHASH_ASM -DECP_NISTZ256_ASM -DPADLOCK_ASM -DPOLY1305_ASM -DOPENSSL_API_COMPAT=0x10100000L "-DENGINESDIR=\"C:\\download\\openssl-1.1.0f\\bin\\lib\\engines-1_1\"" "-DOPENSSLDIR=\"C:\\Program Files\\Common Files\\SSL\"" -W3 -wd4090 -Gs0 -GF -Gy -nologo -DOPENSSL_SYS_WIN32 -DWIN32_LEAN_AND_MEAN -DL_ENDIAN -D_CRT_SECURE_NO_DEPRECATE -DUNICODE -D_UNICODE /MDd /Od -DDEBUG -D_DEBUG /Zi /Fdossl_static -c /Focrypto\cversion.obj "crypto\cversion.c"
cversion.c
        "C:\Perl64\bin\perl.exe" "util\mkdef.pl" "crypto" 32 > libcrypto-1_1-x64.def
        "C:\Perl64\bin\perl.exe" -i.tmp -pe "s|^LIBRARY\s+crypto32|LIBRARY libcrypto-1_1-x64|;" libcrypto-1_1-x64.def
        DEL libcrypto-1_1-x64.def.tmp
        "C:\Perl64\bin\perl.exe" "util\mkrc.pl" libcrypto-1_1-x64.dll > libcrypto-1_1-x64.rc
        rc /folibcrypto-1_1-x64.res libcrypto-1_1-x64.rc
Microsoft (R) Windows (R) Resource Compiler Version 10.0.10011.16384
Copyright (C) Microsoft Corporation.  All rights reserved.

        IF EXIST libcrypto-1_1-x64.dll.manifest DEL /F /Q libcrypto-1_1-x64.dll.manifest
        link /nologo /debug /dll  /implib:libcrypto.lib /out:libcrypto-1_1-x64.dll /def:libcrypto-1_1-x64.def @C:\Users\twolf10\AppData\Local\Temp\nmDCA9.tmp || (DEL /Q libcrypto.* libcrypto-1_1-x64.* && EXIT 1)
crypto\aes\aes_cfb.obj : fatal error LNK1112: Modul-Computertyp "X86" steht in Konflikt mit dem Zielcomputertyp "x64".
NMAKE : fatal error U1077: "link": Rückgabe-Code "0x1"
Stop.
NMAKE : fatal error U1077: ""C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\nmake.exe"": Rückgabe-Code "0x2"
Stop.

c:\download\openssl-1.1.0f\openssl-1.1.0f>

Does the bittedness of your visual studio developers console match the bittedness (32 vs 64) of your openssl configure target?  The "X86" makes me think that your console is targetting 32-bit mode, but the log shows openssl trying to build 64-bit code.

I did the following steps:

installed 64-bit Perl, http://www.activestate.com/ActivePerl.
installed 64-bit NASM, available from http://www.nasm.us,
opened VS2017 x64 Cross (and Native 2. try) Tools Command Prompt

perl Configure VC-WIN64A --prefix=c:\download\openssl-1.1.0f\bin --debug enable-ssl-trace enable-crypto-mdebug no-deprecated
nmake
nmake install
All these steps were working with VS 2012 and I think 2015!

As I understand it, that is supposed to work.  But I don't have a windows system handy at the moment; maybe someone else on the team who does could take a look.

nmake clean or start from fresh.

Issue ist still existing, just tested with a fresh the master zip file download. Same error!

I note that the issue is currently in the 'closed' state.
You should provide a more detailed log of what you did, starting from the fresh zip download, in order for reopining the issue to be justified.

I think the issue comes with the parameters I`m using.

dot-asm closed this 4 days ago

which apparently was at the same time as the "nmake clean or start from fresh" comment.
@dot-asm do you have access to VS2017?

@dot-asm do you have access to VS2017?

It would be a mistake to assume that I would have closed the issue without having tried to reproduce it. In other words, yes, I do have access to VS2017 (community version), and yes, I did try to reproduce it, obviously unsuccessfully.

What does where cl return and what does cl (without arguments) print. Mine prints
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

That last "for x64" is the keyword.

C:\download\openssl\openssl-master>where cl
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x86\cl.exe
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\cl.exe

I mean that if your target is VC-WIN64A, then cl should print "for x64". Not more, but more importantly not less either. How you get there, or how things are or should be called in start menu, or if it's native or cross compiler, is not an OpenSSL problem. I.e. something for user to figure out. However, if you indeed invoked "x64_x86 Cross Tools", then yes, it would be wrong. It's 64-bit compiler executable that generates 32-bit code. Compiler executable's bitness doesn't matter, what counts is what it generates. If assertion is that it worked with previous VS version, I don't believe it.

Ok now its working, thank you very much for your suppport. I wrote down a note for VS2012 and I was sure I was using x64_x86 Cross Tools Command Prompt at that time. I dont have VS2012 right now on my maschine to prove it.


How do I properly close down a connection?

The official driver has 'close', see http://www.rethinkdb.com/api/javascript/close/
I can't find a corresponding API to close down all connections in the pool and exit on completion.

r.getPoolMaster().drain();

See https://github.com/neumino/rethinkdbdash/blob/master/README.md

Thanks!


Runtime error (TypeErrorException): init() got an unexpected keyword argument 'pose'

Describe the bug
Inverse kinematics returns an error once a tool is attached. The tool components were copied/pasted from a different robot environment (IRB 6700); there it works perfectly well with the same setup (with the obvious exception of the Dockerfile).
To Reproduce
Steps to reproduce the behavior:

Pull the crb15000_fabrication_control repository
Compose-up the local docker file
Run /rhino/crb15000_env.3dm and /rhino/crb15000_moveit_control.ghx
Load the clients and the robot (use ROS Robot model) and go to "Plan cartesian motion". IK should be calculated smoothly.
Now attach a tool and try again. You should receive the following error message:

Runtime error (TypeErrorException): __init__() got an unexpected keyword argument 'pose'

Traceback:
  line 45, in plan_cartesian_motion, "C:\Users\julia\AppData\Roaming\McNeel\Rhinoceros\7.0\scripts\compas_fab\backends\ros\planner.py"
  line 35, in plan_cartesian_motion, "C:\Users\julia\AppData\Roaming\McNeel\Rhinoceros\7.0\scripts\compas_fab\backends\interfaces\client.py"
  line 136, in await_callback, "C:\Users\julia\AppData\Roaming\McNeel\Rhinoceros\7.0\scripts\compas\utilities\azync.py"
  line 103, in plan_cartesian_motion, "C:\Users\julia\AppData\Roaming\McNeel\Rhinoceros\7.0\scripts\compas_fab\backends\ros\backend_features\move_it_plan_cartesian_motion.py"
  line 133, in __call__, "C:\Users\julia\AppData\Roaming\McNeel\Rhinoceros\7.0\scripts\compas_fab\backends\interfaces\backend_features.py"
  line 1474, in plan_cartesian_motion, "C:\Users\julia\AppData\Roaming\McNeel\Rhinoceros\7.0\scripts\compas_fab\robots\robot.py"
  line 46, in script

Expected behavior
Calculate the IK
Desktop (please complete the following information):

Windows 10
Python 3.10.4
Compas 1.15.1
Compas_Fab 0.22.0

@JulianTrummer could you please check again using an install from source? This should be fixed by this: https://github.com/compas-dev/compas_fab/pull/366


Molang queries table not formatted correctly

The table in the molang queries page is not formatted correctly, leading to it looking like a jumbled mess of words

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 39e2f3cb-b70a-1f3b-b399-de78d15dd487
Version Independent ID: 8955263e-956f-7ecf-d86b-5acdd6bf5fd6
Content: Molang Documentation - Query Functions
Content Source: creator/Reference/Content/MolangReference/Examples/MolangConcepts/QueryFunctions.md
Product: gaming
GitHub Login: @iconicNurdle
Microsoft Alias: mikeam

It has been fixed. Thanks!


omnifunc complete does not work with syntaxcomplete#Complete

Hi,
I just found that there is an issue when using omnifunc complete with syntaxcomplete#Complete. When opening Gemfile in Rails project, somehow this file's omnifunc is set to syntaxcomplete#Complete.
When typing gem ", everytime I type " I got this error:

Tried to check the source code, it looks the it is failed at autoload/vimcomplete/omnifunc.vim:44, but I don't know how to fix that.
Could you please help to fix this issue? Thanks.

Let me look into it.

My Vim automatically sets omnifunc in Gemfile to rubycomplete#Complete. Maybe try this.

My Vim automatically sets omnifunc for Gemfile to rubycomplete#Complete. Maybe try unsetting it in your .vimrc and let Vim set it.
Also, I cannot reproduce the problem with syntaxcomplete#Complete
Disable Lsp.

Tried to set its omnifunc to rubycomplete#Complete, it works fine. I did not use Lsp by the way. Thanks.
It seems that syntaxcomplete#Complete also does not work with other completion plugins. Previously, I tried to set this in my vimrc
" after/ftplugin/ruby.vim
if exists('&omnifunc') && &omnifunc ==# 'syntaxcomplete#Complete'
    setlocal omnifunc=
endif

Thanks for your support.


allow codegen to emit nullable properties

After https://github.com/MemberJunction/MJ/commit/c071fc0578b20c9f87917bcea17f31ddb59f5d10 This is the result of running codegen

no longer needed with https://github.com/MemberJunction/MJ/compare/main...fix/return-null-in-packagesql?expand=1


UI Update for the Login Page

I want to update hte ui for the login page as currently the ui is not very good.

make sure to add the labels...
thanks:)

Right Now We are accepting, only backend issues
Thanks for issuing but we are not proceeding towards !


Fix Beat Script Bugs

Purpose
Extension to #6737
Changes

Add missed field to ExternalAccount
Ensure SELECT'd user_id's belong to OSFUser objects

Side effects
None Expected
Ticket
#OSF-7335

Test failures are unrelated to this PR, and have since been fixed on develop.


chore: Publish to NPM with provenance

The release process in this repository is already automated via GitHub Actions, which is a great first step toward creating trust in the supply chain. Recently, NPM has started to support publishing with the --provenance flag. This flag creates a link between the GitHub Actions run that created the release and the final artifact on NPM. This linkage further ensures that package installs can be traced back to a specific code revision.
For more information on publishing with provenance, please refer to: https://github.blog/2023-04-19-introducing-npm-package-provenance/

Thank you, this is excellent.

https://docs.npmjs.com/generating-provenance-statements has more docs on this


Added support for lifecycles

Depends on https://github.com/MattHodge/go-octopusdeploy/pull/33

Please vendor the latest changes from MattHodge/go-octopusdeploy#33 and you should be good to go :)


ldap search not working

I am trying to do ldap_search but it is not working
error i recieve is
PHP Warning – yii\base\ErrorException
ldap_search(): Search: No such object
I have tried using normal php ldap and the plugin https://github.com/ccottet/ldap

How does this realted to Yii?
Most probably you haven't installed 'LDAP' PHP extension.

yes it is intalled because i am trying to ugrade yii1.x application which uses the same code and works


Ansible 2.8 requires the python multiprocessing module

We don't install this by default.

Ansible 2.8 requires multiprocessing module which may not be installed
by default.
In additon to adding this to the dependencies, add a new Makefile
target, ansible-setup, which will install all required dependencies.
For now these dependencies are duplicated in the Makefile and in
roles/conduit/defaults/main.yml:ansible_depends.
Also move SSH_ARGS to Makefile and pass in environment to avoid
duplication.


Desktop Notifications

Heyo,
What's the effort involved in getting the desktop notifications API lined up to pass through toasts to the host OS?
Would love to finally replace the janky chrome hangouts app once and for all.

+1

Hi, what is the specific issue you're having with the notification? I believe clicking the notification will bring you back to the app if it is minimised?

I'm not getting any notifications whatsoever and assumed that meant they were unsupported, is that not the case? How are they supported currently?

Electron just supports them out of the box! If you're using facebook messenger you have to go into the messenger settings to turn on the desktop notifications.
Could you provide me with the following:

Version of Nativefier (run $ nativefier --version)
Version of Node.js (run $ node --version)
Command line parameters
OS and architecture you are running Nativefier from
Stack trace from the error message (if any)
Instructions to reproduce the issue

Same Problem, cant show notifications...
Example:

Notify me!

Same problem here. No desktop notifications (Inbox & Pivotal Tracker) and verified that they're turned on from within the app.

Are you sure you have the latest version of nativefier? I've tried to nativefy http://www.bennish.net/web-notifications.html, whatsapp web, facebook messenger and it appears to work. Could you check to see if this is specific to the site you are using?

Not Works ;(

Same issue for me. I just installed nativefier 6.10.1 using npm 5.5.0 on latest Mac OS X El Capitan. I've got no notifications for http://hangouts.google.com.
I haven't tried other websites.

@felipead Could you try it on http://www.bennish.net/web-notifications.html
It appears to work for me on windows 10 and OSX11.2 as well...

Not works on Windows 8 :(

Notifications are not working for "hangouts.google.com" but work for "http://www.bennish.net/web-notifications.html"
OS X El Capitan: 10.11.5
Nodejs: v5.4.0
Nativefier: 7.0.1
Architecture: x64
Electron v1.1.3
I realized I'm running an older version of Node so I completely reinstalled Node to get to v6.2.2.
Same results.
I hear the notification sound for the hangouts app, but no alert popup.

@tseven I don't really use Hangouts, does it send a notification if we access it from chrome directly? Or are there certain settings you have to turn on for the desktop notifications, I believe this is the case for messenger.com

Alternatively you can use https://github.com/yakyak/yakyak The same Electron build especially for hangouts.

I'm not getting notifications from gmail

The http://www.bennish.net/web-notifications.html isn't showing notifications on Windows 8 for me when Nativefiering it. It says notification permission has been granted, but neither showing it immediately nor showing it after 5 seconds does anything. Works fine in Chrome.

I'm having trouble with getting any kind of mentions working for Windows 10 on the https://www.bennish.net/web-notifications.html site. Could someone share his/her configuration, command line arguments, and any changes to Windows (if any)? Attached is my configuration.
Version of Nativefier: 7.5.4
Version of Node.js: v6.11.2
Command line parameters: nativefier https://www.bennish.net/web-notifications.html
OS and architecture you are running Nativefier from: Windows 10
Stack trace from the error message (if any): None
Instructions to reproduce the issue: Build then try to trigger a notification

Exactly the same issue as @JiDoan on Windows 10 with nativefier 7.5.4 but works fine on Windows 7... :(

I figured out how to get notifications to work again on Windows 10 (Build 1709) thanks to the help in the electron repo. In a nutshell, you need to register you Nativefier "app" for notifications using the Windows API (sample code). Once you have your app registered, you need to add _electron.app.setAppUserModelId("<Your app name>"); in your resources\app\lib\main.js file and things will work.
Perhaps Nativefier can add a flag for Windows App ID so you don't have to edit the main.js file yourself?

Just tried on latest MacOSX with nativefier v7.6.1 - it doesn't allow to enable push notifications.
I used this page as an example: https://gauntface.github.io/simple-push-demo/

@JiDoan On windows 10, installing an app with Inno Setup. In the setup script, just make sure the AppUserModelID matches what gets put in resources\app\lib\main.js. That worked like a charm for me. to boot, Inno Setup is free.

@jidoan i cant get this to work. Maybe you can describe what you did exactly ._.

Hello all,
I have created a fork which implements the --app-user-model-id flag to Nativefier. using @mentofa123 and @JiDoan solutions. I have also created the app ShorcutCreator.exe to create the shortcut with the AppUserModelId parameter. The only thing missing is integrating this exe with the nativefying process of an app.
The fork and more details can be found at: https://github.com/rdcvnh/nativefier
@mentofa123 and @JiDoan , I can add your names to the Credits section. Let me know if it's OK for you.

Sure I don't mind @rdcvnh, but I wouldn't have figured it out without @NicolasConstant's post in the electron repo.

@rdcvnh any plans to merge that in to the main repository?

@JacobDB I would like to first have the ShortcutCreator.exe integrated into the build process as described on my README.md (I haven't figured out how to do so). Otherwise I think it wouldn't make sense to submit a solution that still requires some manual work.

@rdcvnh Maybe this could be helpful to figure it out https://github.com/KochiyaOcean/windows-shortcuts

@pseudonymcp It seems promising. I will take a look at it. Thank you!

I got the notifications to work with @rdcvnh's method. I just want them to be able to persist and when the icon is in the system tray, have that notification open the app
is there a way to do that?

@artistro08 maybe this PR #640?

Is this fix in the final release? I just created a Skype native and am getting no notifications.

Hi all. Sorry, I haven't had much time to look into it. If someone is interested in picking up where I left, you're more than welcome:
https://github.com/rdcvnh/nativefier
The fork should be a bit outdated by now, but the additional code should be portable to the newer versions of nativefier.
We could also get the attention of the contributors to get this implemented in original code.

Hopefully this will get resolved soon™ with #955. 🤞


SECURITY FIX

Related issue: #9

#9

Thanks for the pull-request, I will fix it by adding the "files" to the package.json


fix(api): gateway response dropping on update api

Description of changes
This PR will fix the rest api dropping gateway response on update api issue.
With this change, we will assign a new logical id to the gateway response resources on each push so it would be treated as deleting the old one and creating a new one instead of updating the existing one.
(I'll add an E2E test once we complete the major version bump with the CLI)
Issue #, if available
Fixes #30
Description of how you validated changes

manual test
e2e test

Checklist

[x] PR description included
[x] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #764 (e9f99c2) into main (6a7b9f3) will increase coverage by 0.34%.
The diff coverage is 91.17%.

@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
+ Coverage   63.14%   63.48%   +0.34%
==========================================
  Files         278      278
  Lines       18125    18197      +72
  Branches     4375     4399      +24
==========================================
+ Hits        11445    11553     +108
+ Misses       6093     6056      -37
- Partials      587      588       +1

Impacted Files
Coverage Δ

...plify-graphql-auth-transformer/src/utils/schema.ts
94.69% <ø> (ø)

...searchable-transformer/src/cdk/create-cfnOutput.ts
100.00% <ø> (ø)

...graphql-elasticsearch-transformer/src/resources.ts
100.00% <ø> (ø)

...fy-graphql-auth-transformer/src/resolvers/field.ts
71.42% <33.33%> (+2.04%)
:arrow_up:

...l-transformer-core/src/transformation/transform.ts
16.26% <50.00%> (-0.05%)
:arrow_down:

...amplify-graphql-index-transformer/src/resolvers.ts
95.92% <71.42%> (-2.86%)
:arrow_down:

...earchable-transformer/src/generate-resolver-vtl.ts
85.00% <71.42%> (ø)

...fy-graphql-auth-transformer/src/resolvers/query.ts
90.43% <75.00%> (-0.09%)
:arrow_down:

...-graphql-searchable-transformer/src/definitions.ts
76.00% <81.57%> (ø)

...formation/cdk-stack-builder/apigw-stack-builder.ts
63.91% <83.33%> (+2.30%)
:arrow_up:

... and 38 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


1st run time good but 2nd attempts always fail

Could you please help me out on this issue?
1st run time good:
(venv) PS C:\Users\zhang\Downloads\codeinterpreter-api\examples> python show_ethereum_chart.py
AI:  Here is the Ethereum price chart for the year-to-date 2023. The x-axis represents the date and the y-axis represents the price in USD. Please note that the data is subject to the availability from the source.
Exception ignored in: <function LocalBox.del at 0x00000266905C4860>
Traceback (most recent call last):
File "C:\Users\zhang\Downloads\codeinterpreter-api\venv\Lib\site-packages\codeboxapi\box\localbox.py", line 567, in del
File "C:\Users\zhang\Downloads\codeinterpreter-api\venv\Lib\site-packages\codeboxapi\box\localbox.py", line 517, in stop
OSError: [WinError 87] Parameter error.。
But I still got the exact chart from this command(python show_ethereum_chart.py) somehow.
But my 2nd attempt always failed even with SAME command line.
(venv) PS C:\Users\zhang\Downloads\codeinterpreter-api\examples> python show_ethereum_chart.py
Traceback (most recent call last):
File "C:\Users\zhang\Downloads\codeinterpreter-api\examples\show_ethereum_chart.py", line 19, in
main()
File "C:\Users\zhang\Downloads\codeinterpreter-api\examples\show_ethereum_chart.py", line 7, in main
with CodeInterpreterSession(local=True) as session:
File "C:\Users\zhang\Downloads\codeinterpreter-api\venv\Lib\site-packages\codeinterpreterapi\session.py", line 471, in enter
self.start()
File "C:\Users\zhang\Downloads\codeinterpreter-api\venv\Lib\site-packages\codeinterpreterapi\session.py", line 82, in start
status = SessionStatus.from_codebox_status(self.codebox.start())
^^^^^^^^^^^^^^^^^^^^
File "C:\Users\zhang\Downloads\codeinterpreter-api\venv\Lib\site-packages\codeboxapi\box\localbox.py", line 107, in start
self._connect()
File "C:\Users\zhang\Downloads\codeinterpreter-api\venv\Lib\site-packages\codeboxapi\box\localbox.py", line 120, in _connect
self.ws = ws_connect_sync(f"{self.ws_url}/kernels/{self.kernel_id}/channels")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\zhang\Downloads\codeinterpreter-api\venv\Lib\site-packages\websockets\sync\client.py", line 289, in connect
connection.handshake(
File "C:\Users\zhang\Downloads\codeinterpreter-api\venv\Lib\site-packages\websockets\sync\client.py", line 85, in handshake
raise TimeoutError("timed out during handshake")
TimeoutError: timed out during handshake
Exception ignored in: <function LocalBox.del at 0x000001545F734860>
Traceback (most recent call last):
File "C:\Users\zhang\Downloads\codeinterpreter-api\venv\Lib\site-packages\codeboxapi\box\localbox.py", line 567, in del
File "C:\Users\zhang\Downloads\codeinterpreter-api\venv\Lib\site-packages\codeboxapi\box\localbox.py", line 514, in stop
OSError: [WinError 6] Invalid handle
Thank you for your help in advance.

I have the same problem on Windows

Same Issue using Windows 11, but I was never able to get it to work.

I also encountered the same problem on Win11.


Merge feature-branch-opflex

Cool !!!

On Sep 11, 2015, at 6:41 PM, Amit Bose<EMAIL_ADDRESS>wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/noironetworks/apic-ml2-driver/pull/4
Commit Summary
Opflex agent integration
Rpc for opflex agent
Fixed typo in Opflex RPC
add ml2 vlan configuration to the mechanism driver
Add app-profile to gbp details
Push scoped tenant on GBP details for opflex agents
Add support for NAT
Fix pep8 errors
override create_router to move gw operation out of transaction
change create_router override on l3 service to reflect neutron changes
Fix entry-point names of drivers
Use preexisting APIC external networks
Avoid scoping for preexisting APIC external networks
Use pre_existing name mapping for preexisting L3Out
Avoid unwanted external contract deletion
use EPG tenant when pushin static path configuration for a port
Single manager in same Neutron controller
Avoid unwanted creation of port path for external gateway ifaces
Merge pull request #1 from noironetworks/feature-branch-opflex_sync
Remove check migration from pep8 tests
Port update causes path deletion if needed
Fix external gateway related UTs
Merge pull request #2 from noironetworks/feature-branch-opflex_sync
Add topology agents and LLDP movable hosts
Fix mechanism callback API version to match agent notifier
Avoid pushing void segments to APIC during host discovery
Call path deletion with host config on integrated topology service
Auto move to work with VPC properly
Wrap dupicate DB entry error into info LOG for topology svc
Merge pull request #3 from noironetworks/feature-branch-opflex_sync
Add files for creating RPM and Debian packages
Fix names of service files
Add debian changelog file and minor versioning changes
Change name of LLDP package that we depend on (lldpd -> lldpad)
Add oslo concurrency as package dependency
Add console script entries
Add missing call to setup RPC
Use mapped-names for NAT related objects
Fix get_gbp_details() to use mapped names
Disable NAT-ing if use_vmm is False
Remove extraneous parameter 'scope'
More fixes to use of pre-existing L3 for NAT
Add opflexagent to requirements.txt
File Changes
M MANIFEST.in (5)
M apic_ml2/neutron/plugins/ml2/drivers/cisco/apic/apic_topology.py (129)
M apic_ml2/neutron/plugins/ml2/drivers/cisco/apic/config.py (3)
M apic_ml2/neutron/plugins/ml2/drivers/cisco/apic/mechanism_apic.py (467)
A apic_ml2/neutron/plugins/ml2/drivers/cisco/apic/rpc.py (206)
M apic_ml2/neutron/services/l3_router/l3_apic.py (59)
M apic_ml2/neutron/tests/unit/ml2/drivers/cisco/apic/test_cisco_apic_common.py (138)
M apic_ml2/neutron/tests/unit/ml2/drivers/cisco/apic/test_cisco_apic_mechanism_driver.py (532)
M apic_ml2/neutron/tests/unit/ml2/drivers/cisco/apic/test_cisco_apic_topology_agent.py (2)
M apic_ml2/neutron/tests/unit/services/l3_router/test_l3_apic_plugin.py (32)
A debian/.gitignore (5)
A debian/build-deb.sh (21)
A debian/changelog.in (5)
A debian/compat (1)
A debian/control (14)
A debian/copyright (21)
A debian/neutron-cisco-apic-host-agent.conf (19)
A debian/neutron-cisco-apic-service-agent.conf (19)
A debian/neutron-ml2-driver-apic.install (2)
A debian/rules (21)
A debian/source/format (2)
M etc/neutron/plugins/ml2/ml2_conf_cisco_apic.ini (5)
M requirements.txt (5)
A rpm/build-rpm.sh (11)
A rpm/neutron-cisco-apic-host-agent.service (15)
A rpm/neutron-cisco-apic-service-agent.service (15)
A rpm/neutron-ml2-driver-apic.spec.in (95)
M setup.cfg (11)
M setup.py (1)
M test-requirements.txt (22)
M tox.ini (1)
Patch Links:
https://github.com/noironetworks/apic-ml2-driver/pull/4.patch
https://github.com/noironetworks/apic-ml2-driver/pull/4.diff
—
Reply to this email directly or view it on GitHub.


UUID with less than 8000 fails with NoneType

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
We had been using some 'dummy' UUID values, which are valid UUID4, as per https://www.freecodeformat.com/validate-uuid-guid.php for example, but pydantic does not seem to like them, we get a NoneType error.
I've attached an example script which passes 2 UUIDs to a test, first as str, which works, then as UUID, and this one fails:
00000000-7fff-4000-7fff-000000000000
When we run in our application, we get them from the DB layer and they come up as UUID() type, which was then failing.
It seems if the 2nd and 4th sections are less than 8000, the parsing fails, so 7fff fails but 8000 works.
The output we get is like this:
> python pydantic-test.py
id='00000000-8000-4000-8000-000000000000' type is <class 'str'>
DemoModel(uuid_field = UUID('00000000-8000-4000-8000-000000000000'))
id='00000000-7fff-4000-7fff-000000000000' type is <class 'str'>
DemoModel(uuid_field = UUID('00000000-7fff-4000-7fff-000000000000'))
id=UUID('00000000-8000-4000-8000-000000000000') type is <class 'uuid.UUID'>
DemoModel(uuid_field = UUID('00000000-8000-4000-8000-000000000000'))
id=UUID('00000000-7fff-4000-7fff-000000000000') type is <class 'uuid.UUID'>
Traceback (most recent call last):
  File "/Users/dkeverne/Desktop/Python/oss-play/pydantic-test.py", line 25, in <module>
    test(UUID('00000000-7fff-4000-7fff-000000000000'))
  File "/Users/dkeverne/Desktop/Python/oss-play/pydantic-test.py", line 13, in test
    object = DemoModel(
  File "/Users/dkeverne/Desktop/Python/oss-play/.venv/lib/python3.10/site-packages/pydantic/main.py", line 165, in __init__
    __pydantic_self__.__pydantic_validator__.validate_python(data, self_instance=__pydantic_self__)
TypeError: 'NoneType' object cannot be interpreted as an integer

Example Code
from pydantic import BaseModel, UUID4
from uuid import UUID

class DemoModel(BaseModel):
    uuid_field: UUID4

    def __str__(self):
        return f'DemoModel(uuid_field = {self.uuid_field!r})'

def test(id: UUID4):
    print(f'{id=} type is {type(id)}')

    object = DemoModel(
        uuid_field = id
    )

    print(object)

test('00000000-8000-4000-8000-000000000000')
test('00000000-7fff-4000-7fff-000000000000')

test(UUID('00000000-8000-4000-8000-000000000000'))
test(UUID('00000000-7fff-4000-7fff-000000000000'))

Python, Pydantic & OS Version
pydantic version: 2.3.0
        pydantic-core version: 2.6.3
          pydantic-core build: profile=release pgo=false
                 install path: /Users/username/Desktop/Python/oss-play/.venv/lib/python3.10/site-packages/pydantic
               python version: 3.10.12 (main, Jun 20 2023, 19:43:52) [Clang 14.0.3 (clang-14<IP_ADDRESS>.1)]
                     platform: macOS-13.5.1-arm64-arm-64bit
     optional deps. installed: ['typing-extensions']

I think pydantic-core uses the UUID.version property:
impl BuildValidator for UuidValidator {
    const EXPECTED_TYPE: &'static str = "uuid";

    fn build(
        schema: &PyDict,
        config: Option<&PyDict>,
        _definitions: &mut DefinitionsBuilder<CombinedValidator>,
    ) -> PyResult<CombinedValidator> {
        let py = schema.py();
        let version = schema.get_as::<u8>(intern!(py, "version"))?.map(Version::from);

which only returns a value if the variant is RFC 4122 (returns None otherwise):
    @property
    def version(self):
        # The version bits are only meaningful for RFC 4122 UUIDs.
        if self.variant == RFC_4122:
            return int((self.int >> 76) & 0xf)

So maybe depending on the uuid value, self.variant (which is also a property computed from the uuid value) doesn't evaluates to RFC_4122, hence the unhandled exception.

Thanks for reporting, sorry for the slow reply, I'll look at this today.

Just to clarify, your model requires UUID4 but the value '00000000-7fff-4000-7fff-000000000000' is not UUID version 4.
Indeed, the uuid Pyhton module thinks the same.
>>> from uuid import UUID
>>> uid = UUID('00000000-7fff-4000-7fff-000000000000')
>>> repr(uid.version)
'None'

Modifying your example to ignore UUID version in the type check passes your tests.
from uuid import UUID

from pydantic import BaseModel

class DemoModel(BaseModel):
    uuid_field: UUID

    def __str__(self):
        return f'DemoModel(uuid_field = {self.uuid_field!r})'

def test(id: str | UUID):
    print(f'{id=} type is {type(id)}')

    object = DemoModel(uuid_field=id)

    print(object)

test('00000000-8000-4000-8000-000000000000')
test('00000000-7fff-4000-7fff-000000000000')

test(UUID('00000000-8000-4000-8000-000000000000'))
test(UUID('00000000-7fff-4000-7fff-000000000000'))

id='00000000-8000-4000-8000-000000000000' type is <class 'str'>
DemoModel(uuid_field = UUID('00000000-8000-4000-8000-000000000000'))
id='00000000-7fff-4000-7fff-000000000000' type is <class 'str'>
DemoModel(uuid_field = UUID('00000000-7fff-4000-7fff-000000000000'))
id=UUID('00000000-8000-4000-8000-000000000000') type is <class 'uuid.UUID'>
DemoModel(uuid_field = UUID('00000000-8000-4000-8000-000000000000'))
id=UUID('00000000-7fff-4000-7fff-000000000000') type is <class 'uuid.UUID'>
DemoModel(uuid_field = UUID('00000000-7fff-4000-7fff-000000000000'))

However, this doesn't mean that there is no bug in Pydantic. Pydantic should provide meaningful error message that reflects the version check correctly.


Why better than ShortGuid

ShortGuid generate smaller values (21 char), normal?
Why better?

Yes, that's a very fair question to ask!
The answer's all about readability: ShortGuid compresses to 22 by also including numbers and two special characters ('_' and '-') - this leads to complicated-looking identifiers like _-9g5YdI9A27c_a-2FC00ebQ2.
MiniGuid in comparison always outputs a blob of letters - all in the same character class, and without strange pepperings of underscores etc. It's a trade-off, I suppose - four more characters, but more regular and digestable QxLKubVCxzzuTSKvxxizlZfyyg
Also (not insignificantly) MiniGuid is nicely hosted on GitHub, nicely packaged with implicit conversions etc, and (drumroll) is .NET Standard compatible.

Thanks for asking the question - I've now updated the readme!


debug logging

DO NOT MERGE.
throwaway debug code.

@bw-solana this is ready for review.
@joeaba Pending Brennan's sign-off, this is the code we would want to deploy for today's long ping issue. thanks.

LGTM

I will do more local testing on this tomorrow (6/26). Please hold off on kicking off the next step.

updated to target v1.18.18.


refactor: handle home/end presses through key manager

Based on top of #19834, changes the places where we were handling home/end to go through the key manager.
Also allows withHomeAndEnd to be turned off, similarly to what we're doing with the other methods.
cc @vanessanschmitt

@crisbeto Seems like this PR has some merge conflicts

Rebased.


[Feature request] Add "boxed" variant to the Testimonial

Hi PB Team!
I have noticed a few pages that have testimonials that have a boxed wrapper around them:
Single Testimonial:
https://github.com/features/actions
https://github.com/features/issues

Two Testimonials:
https://github.com/features/codespaces
https://github.com/features/code-search

Can we consider adding a "boxed" variant to the Testimonial component to support these use cases?
The Single Testimonial page examples have a somewhat transparent background with a blur which should probably exist at the implementation level. However, it would be nice to have the spacing defined in the PB library to have future testimonials share the same spacing.
CC @simmonsjenna CC @jesussandreas
Thank you for your help!

Thanks for opening this feature request @seangolo ❤
A couple of options here:

Add a Storybook example for your team to reference as the design can be achieved using the Box component today
Add a variant prop to the Testimonial component to add first-class support

My preference would be the latter (option 2) assuming Site Design plan to continue using this design approach in future.
There's a lot of detail here that would be difficult to expect users to implement on their own each time. E.g. responsive paddings, responsive filter effects, etc.
I think it's reasonable to add first-class support to Testimonial for this using the variant prop.
E.g. of new API
type TesimonialProps {
  variant?: 'default' | 'minimal' | 'frost'
}

Like the Card component, 'minimal' would be the correspond to the current version of the Testimonial and be made default to avoid a breaking change. 'default' value would be inclusive of a background color and padded, and frost being the same with a background filter applied.
Final API will likely differ, but I'll bring this to other maintainers and provide an update here when that's available.

@rezrah Thank you for your feedback! ❤
Depending on the priority of this issue for the SWP team, we may build this internally and potentially port over to the PB API if/when it becomes available.
For full transparency, this feature request is to support the flex template. In an ideal world, the flex template leverages the built in features from PB and has as few bespoke features built as possible. This should make the template easier to adopt and should make the communication around feature support more clear.

@seangolob - thanks for your patience. Sorry for the delay in responding to you.
Update:

Testimonial will support the 'boxed' version as an additional variant alongside minimal
We'll separately ship a GlassEffect component that handles the filter visual effect.
Timeline is ~3 weeks for building and shipping these, so you're welcome to find a workaround if you need these sooner.

Update:

All requested features have shipped in 0.45.0 (release tracking issue)
'Boxed' testimonials example here
Frosted glass effect testimonial: Light and Dark

Feel free to reopen if there's anything that was missed.


CLoses #39 #10 Add a way to specify the position of child components.

Closes issue #39 and issue #10.

Implemented the approach to handle children components "HTML and Text node" the same way as adding to children list of parent node to preserve order
All HTML structure parsing is done via Stack, the code is simplified (node_depth is no longer required)
Removed RootParser.children, replaced it with root_node reference
Fixed issue #10 of reversing text nodes order

@sansyrox Please review.
Also, I have a question...
Does the default of   accepts just one root node, or there are possibilities of it having several root nodes? Ex.
<pyml>
html node 1
     text node t1
html node 2
     text node t2
html node 1 from second root
     text node t1 from second root
html node 2 from second root
     text node t2 from second root      </pyml>
Would this even happen, or by default it's just one root?

@sansyrox Please review.
Also, I have a question...
Does the default of   accepts just one root node, or there are possibilities of it having several root nodes? Ex.

Would this even happen, or by default it's just one root?

Hey @SuelenKarbivnychyy 👋
Great work as always!
Can you please explain what was the purpose of removing self.children and depth. i.e. can you please provide an overview of the new algorithm?

Would this ever happen,

Yes. But we can introduce a concept of fragments(https://legacy.reactjs.org/docs/fragments.html) to make things simpler for us.
Let me know what you think.

Yes. But we can introduce a concept of fragments(https://legacy.reactjs.org/docs/fragments.html) to make things simpler for us.

Nice. I'm looking into that.

Hey @SuelenKarbivnychyy :wave:
I was going through your PR but looks like we cannot generate a new html file on build.
Steps to reproduce:

Delete test_application/build and test_application/dist
Run ./build.sh

Can you please have a look?

I was going through your PR but looks like we cannot generate a new html file on build.

@sansyrox Hey, Thank you for that.
Shouldn't the hmtl file generated on dist folder? And the build folder for the Python files?
For me, The html file is being generated on dist folder.
Please let me know.

@sansyrox Hey, Thank you for that. Shouldn't the hmtl file generated on dist folder? And the build folder for the Python files? For me, The html file is being generated on dist folder. Please let me know.

Weird. Because what I mean with the above statement is that I am not getting any html files in the dist folder when running the build script. :(

Hey @SuelenKarbivnychyy 👋
You just have one final merge conflict 😅


Does not work at all

Command: pptx2md -o redme.md -i images infile.pptx
Output:
processing slide 1...
Traceback (most recent call last):
File "/home/tangarora/.local/bin/pptx2md", line 8, in
sys.exit(main())
File "/home/tangarora/.local/lib/python3.9/site-packages/pptx2md/main.py", line 117, in main
parse(prs, out)
File "/home/tangarora/.local/lib/python3.9/site-packages/pptx2md/parser.py", line 176, in parse
process_picture(shape)
File "/home/tangarora/.local/lib/python3.9/site-packages/pptx2md/parser.py", line 130, in process_picture
common_path = os.path.commonpath([g.out_path, g.img_path])
File "/usr/lib/python3.9/posixpath.py", line 510, in commonpath
raise ValueError("Can't mix absolute and relative paths") from None
ValueError: Can't mix absolute and relative paths

no potions work

Options sorry

Bug fixed, upgrade with pip install --upgrade pptx2md==0.7.9 and try again.


New line Added upon Save File

Hello guys,
First I need to thank you for the great Editor.
It seems like the App it's adding a new line in the bottom of the file each time I save the document.
I use it for PHP/WEB applications and it is annoying, mostly when you need to call variables/values from file_content, when during the fact that Atom adds new lines in the bottom, the PHP interprets it as space behind the value and throws Fatal Errors.
If I edit the file outside the Atom and remove that spare line, everything goes well.
I tried looking for an option in this matter in the Settings of Atom and couldn't find any concludent, so if you thing this report comes in an error manner (mine especially), please feel free to announce me in any way.
Thank you guys.

This is controlled by the whitespace package. Go to the Packages screen and click on the Settings button (or the panel itself) for the whitespace package. There you'll see these options

Thank you very much.
Probably I had to take more time to read about it before jump... :+1:


Cou custom table buttons

closes #901
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Hi @matthoward366 can you take a look at this approach and see if it makes sense? I still have to make some changes around manually setting the buttons disabled state and unit tests. You can find the examples in structuretable_paramDef.json under the Tables section

The code looks pretty good.  I don't see any concerns with the approach.


#163684121 Edit party

What does this PR do?

Builds the endpoint to edit a party detail
Description of Task to be completed?

[x] Write a unit test for the edit endpoint
[x] Build out necessary functions to perform the edit

How should this be manually tested?
After cloning the repository to your local machine - check README.md for instructions checkout to ft-edit-party-163684121 branch. Install the requirements and launch the flask server check here for instructions. Using Postman open create a POST request with this header
Key Content-Type: application/json.
Put this in the json body
{
	"party_name": "Actionated Party",
	"hq_address": "Mountain View 23"
}

Change the details you want for the party by making a PUT request e.g
{
	"party_name": "Actionated",
	"hq_address": "Mountain 23"
}

What are the relevant pivotal tracker stories?
#163684121
Postman Documentation.
Postman Docs
Screenshots.
PUT /parties/<party_id>/edit

Coverage remained the same at 100.0% when pulling 122b608e8e5d28e569e3e6cde92d9dee708e26b7 on ft-edit-party-163684121 into 683b13afb7dcb7956e037f604ec426baf26106d6 on develop.


Print skipped test reasoning by default with tox

Description
Resolves https://github.com/Azure/azure-sdk-for-python/issues/31200. Most tests that are skipped throughout the SDK include an explanatory message, but this reason doesn't get printed with test output. Adding the -rsfE flag to our default pytest args in tox.ini will make test summaries include skipped test reasoning (-rfE is the default value, which only adds summaries for failed and errored tests).
@scbedd
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

Example of the test summary output from CI:
=========================== short test summary info ============================
SKIPPED [1] tests/test_rest_stream_responses.py:84: We've gotten rid of iter_text for now
SKIPPED [1] tests/test_rest_stream_responses.py:94: We've gotten rid of iter_lines for now
SKIPPED [12] ../../conftest.py:44: live test only
SKIPPED [22] .tox/mindependency/lib/python3.10/site-packages/_pytest/python.py:184: async def function and no async plugin installed (see warnings)
SKIPPED [1] tests/async_tests/test_rest_stream_responses_async.py:74: We've gotten rid of iter_text for now
SKIPPED [1] tests/async_tests/test_rest_stream_responses_async.py:86: We've gotten rid of iter_lines for now
=============== 1327 passed, 38 skipped, 108 warnings in 48.62s ================


Error in check for incompatible types in super interfaces

When a generic interface (Using a template type) extends two other generic interfaces containing the same compatible methods then the closure compiler (v20150126) complains about incompatible types. Here is a short example:
/**
 * @template T
 * @interface
 * @extends B.<T>
 * @extends C.<T>
 */
function A() {}

/**
 * @template T
 * @interface
 */
function B() {}

/** @return {T} */
B.prototype.getValue = function() {};

/**
 * @template T
 * @interface
 */
function C() {}

/** @return {T} */
C.prototype.getValue = function() {};

And here is the compiler output:
$ jscc test.js -W VERBOSE
test.js:7: WARNING - Interface A has a property getValue with incompatible types in its super interfaces B and C
function A() {}
^

0 error(s), 1 warning(s), 100.0% typed

The check works correctly with the new type inference but because of other problems with the new type inference I'm currently still using the default type inference so I hope this bug could be fixed there, too.

It is unlikely to be fixed in the old type inference as we would prefer to invest in the new type inference.


[APIM 4.0.0] Supporting user-claims cache

Problem
Creating this issue to get the support for enabling backend JWT claims cache for the opaque tokens.
Solution
Enabling backend JWT claims cache for the opaque tokens.
Affected Component
APIM
Version
4.0.0
Implementation
No response
Related Issues
No response
Suggested Labels
No response

Hi Team,
I found that you have provided the following ETA on GOTYMEPHILSUB-501
Best Case Estimate: 2024-04-29
Most Likely Estimate: 2024-05-10
Worst Case Estimate: 2024-05-17
The account has been escalated and war-room opened. So this is not acceptable for the customer. Please provide an ETA in early April.
Best, Buddhika

Hi all,
Closing this public issue as the fix has been included in the latest API-M release (4.3.0). Please use the APIM internal for further discussions, if required.
Thank you
Avishka


initial commit for license change

PR Checklist
Please check if your PR fulfills the following requirements

[x] The title follows our guidelines
[ ] Tests for the changes have been added (for bugfixes/features), they use let helpers and before blocks
[x] For all UI changes, there is cucumber coverage
[ ] Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, reasoning is documented in PR and code
[ ] Any endpoint modified in the PR only responds to the expected MIME types.
[ ] For all scripts or rake tasks, how to run it is documented on both the PR and in the code
[x] There are no inline styles added
[ ] There are no inline javascript added
[ ] There is no hard coded text added/updated in helpers/views/Javascript. New/updated translation strings do not include markup/styles, unless there is supporting documentation
[ ] Code does not use .html_safe
[ ] All images added/updated have alt text
[ ] Doesn’t bypass rubocop rules in any way

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature (requires Feature flag)
[ ] Data fix or migration (inert code, no impact until run)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] CI related changes
[ ] Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?
Ticket:
A brief description of the changes
Current behavior:
New behavior:
Feature Flag
For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and which client(s) it applies to.
Variable name:

[ ] DC
[ ] ME

Additional Context
Include any additional context that may be relevant to the peer review process.
AppScan CodeSweep Failure
In the event of a failed check on the AppScan CodeSweep step of our GitHub Actions workflow, please review the False Positive protocol outlined here: appscan_codesweep/CODESWEEP_FALSE_POSITIVES_README.MD
Add all required notes to this section if the failure is a suspected false positive.

Task linked: CU-868a73vx9 update readme to change license to lgpl


[BEAM-13574] Large Wordcount

Adds a more complex example pipeline demonstrating a more production oriented worcount.

Uses the SDF based textio read
Sorts the output as long as keys fit in a single machine's memory
Shards the output based on the output spec (or based on shard configuration.)
Uses the Filesystem abstraction for "atomic" renames.
Uses Map Side inputs.
Tests the pipeline with passert & metrics querying.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @youngoli @riteshghorse @jrmccluskey
PTAL Any comments, oddities questions etc are much appreciated.

LGTM. I found the example easy to understand and the comments are helpful in that process.


Add files for Parking Pro connector

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[X] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[X] I attest that the connector works and I verified by deploying and testing all the operations.
[X] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[X] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[X] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[X] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

@microsoft-github-policy-service agree [company="Witivio"]

@microsoft-github-policy-service agree company="Witivio"

Hello @dieonar,
Thank you so much for your new submission with us.
As we ask all partner to register their new connectors, may I ask you please to register your connector by filling out our registration form.
Please let me know if you have any questions.
Thank you so much.

Hello @dieonar,
Thank you so much for your new submission with us.
As we ask all partner to register their new connectors, may I ask you please to register your connector by filling out our registration form.
Please let me know if you have any questions.
Thank you so much.

Hello !
It is done. I replied to the form

Hello @dieonar,
I hope you are doing well.
Congratulations, your pull request is approved and merged. Please submit the files to ISV Studio or update your submission using your latest commit ID, please allow us up to 1-2 weeks to review your submission, and our Engineers will notify you in the “Activity Control” area in ISV Studio. Please make sure that the icon meets all the requirements, that it’s size is 230x230, icon background is not white or transparent and it matches the iconBrandColor property in apiProperties.json file.
After making the submission in ISV Studio, please attach an intro.md file in the activity control section. This file is required and it's different from readme.md. You can find an example of intro.md file on this page at step 6.
Please Create an environment in the Preview region. You will use this environment later to test your connector after Microsoft is done with the functional verification for your connector.
We expect all tests to be completed within 1-2 weeks.
If your connector passes all tests, the deployment process begins, and it typically takes up to 3 to 4 weeks to deploy your connector to all of our regions.
Please let me know if you have any questions or run into any problems while creating or updating your submission.
Thank you very much for working with us.