fix: race condition while cleaning up database on sqlx::test macro for postgres

Issue

As described in this issue, the #[sqlx::test] macro is occasionally failing to connect to the created database.

Solution

Fix the race condition around current time acquisition across threads, getting the current time twice:

the first one before the AtomicBool swap (DO_CLEANUP), and the second one only after it
so we eliminate the case where one thread may be the first one to perform the swap but its time was greater (more recent) than some other thread.

to ensure postgres has the time synchronized with the application, I also changed the databases.created_at field to always be informed instead of calculated in the database.

Examples
Current issue:

thread A gets the current time (value = 1)
thread B gets the current time (value = 2)
thread B is the first one to acquire the DO_CLEANUP permit, swapping the value to false
thread B has a current time greater than thread A, but B will be the one to perform the cleanup, dropping the database from thread A

Solution

thread A gets the current time (value = 1)
thread B gets the current time (value = 2)
thread B is the first one to acquire the DO_CLEANUP permit, swapping the value to false
thread A gets the current time again (value >=2) before inserting the new database (after the DO_CLEANUP permit)
thread B gets the current time again (value >=2) before inserting the new database (after the DO_CLEANUP permit)

Tests
I tested this fix hundreds of times in sequence and I couldn't get the issue anymore! It seems to be fixed.
PS: I didn't fix the issue for mysql, but I can do that if needed.
PS2: the created_at field is being inserted with precision of seconds instead of millis as before. Is it a problem? It wasn't easy to insert a date considering the millis without using chrono or time crate.

I just run a second sequence of tests, and at try 471 it failed :/
So the issue is not fix with these changes yet.


chore(main): release 1.8.8

:robot: I have created a release beep boop
1.8.8 (2023-10-20)
Bug Fixes

🚀 修复 macOS 简单关闭应用重新打开时报错的问题 (4b259c3)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/viarotel-org/escrcpy/releases/tag/v1.8.8 :sunflower:


Enabling apps to work in public shares.

I extended the scope checking to make it possible to use Apps (and the App Provider) in public shares.
I don't quite like this solution but we also haven't found a better alternative yet. Public share scopes work as long as the requests are path based but that is not always the case.
Maybe we need to rethink this scope implementation. It feels a bit to hacky and unflexible.
This solution is by far not pretty. But this is the smallest change I
could find to support apps in public shares without completely rewriting
the scopes code.
If we want to use any app in a public share the app needs an
authenticated context to access the files in the share. This is working
fine since we can authenticate using the share token. But the resulting
JWT contains a scope refering to the shared resource. That means for a
folder share it contains the resource ID of the shared folder. But if
the app wants to access a specific file in the share it will request
that file by ID. Because of that the old way of the public scope checker
doesn't work because it would compare or requested ID with the ID of
the shared folder and this would fail.
For this reason I added two additional Stat requests so that I
can check if the requested file is inside the shared folder.
This is the reva part of the required changes. The ocis part can be found in this PR: https://github.com/owncloud/ocis/pull/2536

@C0rby please take a look at https://github.com/C0rby/reva/pull/209
@wkloucek can you please check that apps still work after this? My tests seem to pass


vscode占用的cpu太高

VSCode Version: Code 1.12.1 (f6868fce3eeb16663840eb82123369dec6077a9b, 2017-05-04T21:18:32.269Z)
OS Version: Darwin x64 16.5.0
Extensions: the listing exceeds the lower minimum of browsers' URL characters limit

Cannot act on this issue given the above steps. please provide more detailed steps as described in Submitting-Bugs-and-Suggestions.


drivers: usb: device: usb_dc_stm32 Isochronous endpoint issue USB dri…

Isochronous endpoint issue with USB drivers on STM32G491 Ticket buzilla 165576

drivers: usb: device: usb_dc_stm32 issue USB drivers

Isochronous endpoint issue with USB drivers on STM32G491
we setup an isochronous endpoint and are having an issue
where every other frame sends the desired data sandwiched
between garbage data.

@Desvauxm-st Let's also use as a first step to get more info into the project, which IP in which specific configuration is used for different STM32 SoC variants. Please describe the controller and controller configuration used in the STM32G491.

@Desvauxm-st Let's also use as a first step to get more info into the project, which IP in which specific configuration is used for different STM32 SoC variants.

Giving the full list of USB IP used across STM32 SoCs is not directly related to current issue. You can raise a specific issue about this if this information is required for other purpose.

@Desvauxm-st Let's also use as a first step to get more info into the project, which IP in which specific configuration is used for different STM32 SoC variants.

@jfischer-no Giving the full list of USB IP used across STM32 SoCs is not directly related to current issue. You can raise a specific issue about this if this information is required for other purpose.

Perhaps, that is why I asked for STM32G491.

@Desvauxm-st Let's also use as a first step to get more info into the project, which IP in which specific configuration is used for different STM32 SoC variants. Please describe the controller and controller configuration used in the STM32G491.

:arrow_down:
:arrow_right: Please describe the controller and controller configuration used in the STM32G491. :arrow_left:
:arrow_up:

here the link for RM0440
https://www.st.com/resource/en/reference_manual/rm0440-stm32g4-series-advanced-armbased-32bit-mcus-stmicroelectronics.pdf

For isochronous the parameter ep_kind into the fonction :
HAL_PCDEx_PMAConfig(PCD_HandleTypeDef *hpcd, uint16_t ep_addr,
uint16_t ep_kind, uint32_t pmaadress) must be PCD_DBL_BUF.
The parameter pmaadress (EP address in The PMA) is like that:
EP address in The PMA: In case of single buffer endpoint
this parameter is 16-bit value providing the address
in PMA allocated to endpoint.
In case of double buffer endpoint this parameter
is a 32-bit value providing the endpoint buffer 0 address
in the LSB part of 32-bit value and endpoint buffer 1 address
in the MSB part of 32-bit value.

Here we can see how different the controllers covered by this shim driver are and how difficult it is to understand and fix the problems. And the controller whose configuration is to be fixed is actually a relatively simple one (a bit like a controller on the Kinetis platform, but with dedicated SRAM and 16-bit registers). Too bad we do not have a native driver for it, which would give us easier maintenance, better performance, and less RAM and flash usage. This needs to change.


code lacks a proper project structure

The current code layout is pretty confusing with everything living in one directory.
Would it be useful refactor it so that this repository becomes a more standard python project?
Something like:
Chemprop/
|   demo/
|   |-- data/
|   |   |-- ___.csv
|   |--demo_runner.py
|
|-- chemprop/
|   |-- test/
|   |   |-- __init__.py
|   |   |-- test_todo.py
|   |
|   |-- __init__.py
|   |-- mpn.py
|   |-- runers.py
|   |-- utils.py
|   |-- io.py
|
|-- setup.py
|-- README
|-- LICENCE

I'm happy to help out.

Thanks for the suggestion! The repo certainly has gotten a little messy as we've added more and more scripts. I just reorganized the code in roughly the structure you suggested. Please let me know how it looks and whether there's any other way we can improve it!


extensions/v1beta1 is used >> deployment on k8s v1.16+ not possible

With Kubernetescluster running  v1.16 and later it is not possible to deploy OSBA with Helm on Kubernetes:
helm install osba azure/open-service-broker-azure
  --namespace osba
  --set azure.subscriptionId=$AZURE_SUBSCRIPTION_ID
  --set azure.tenantId=$env:AZURE_TENANT_ID
  --set azure.clientId=$env:AZURE_CLIENT_ID
  --set azure.clientSecret=$env:AZURE_CLIENT_SECRET
  --version 1.8.4

Error: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "Deployment" in version "extensions/v1beta1"
"extensions/v1beta1" was removed with v1.16

DaemonSet, Deployment, StatefulSet, and ReplicaSet (in the extensions/v1beta1 and apps/v1beta2 API groups)
Migrate to use the apps/v1 API, available since v1.9. Existing persisted data can be retrieved/updated via the apps/v1 API

Please update your helm chart

Any updates on this? Is OSBA helm chart to be maintained and continued to be developed further? It would be great to get an idea if the chart is going to be actively maintained, and if so, when can we expect the updated helm chart for k8s 1.16+.

@Herr-Sepp probably you need to edit the service port value to use the latest external redis. It's working fine with the following values (you need to adjust this to your setup):
# partial config of values.yaml for helm chart

redis:
    embedded: false
    enableTls: false
    host: osba-redis-master # this shoud point to your external redis service
    port: 6379 # in case the default chart is used, this port should point to the service port number as osba chart has default for 6380
    redisPassword: <password>

In case someone want to use repo chart with k8s 1.16 and helm v3 and do not want to fork it, following script can be used as a helm port renderer to replace extensions/v1beta1 to apiVersion: apps/v1
# osba_upgrade.sh

#!/usr/bin/env bash
set -e

awk '/kind: Deployment/{sub(/extensions\/v1beta1/, "apps/v1", last)} NR>1{print last} {last=$0} END {print last}'

and install could be done with the next command:
helm upgrade --install osba azure/open-service-broker-azure --namespace <namespace> --values <values to override the defaults> --post-renderer <script location>/osba_upgrade.sh


Document stdin input

This would be useful for using wtype for things like passmenu where you would automatically fake type in a stored password via wtype instead of copying it to the clipboard.
Currently it'd need to be passed via argv which means leaking it to the process list.

This has been added in #11. It is not yet documented in the manpage though.

Oh thanks, missed that!

When I execute echo "hello" | wtype -, I expect hello to be typed and be equivalent to wtype hello. Instead, using stdin results in an extra RETURN key to be used after the input ends, equivalent to wtype hello -P RETURN. Is this intended?


Allow configuration to use temporary console

This would have to come from vscode-powershell first... and then this could leverage it.

This is already a thing using a vscode-powershell configuration:
powershell.debugging.createTemporaryIntegratedConsole


Edit All frames.

resolves #13
currently does not re-render page when all frames are changed, however frame data in frames object is correct. This is something that needs some feedback, as i am not sure about how to force the frames page to re-render.

That is not how the javascript % operator works, unfortunately. You can
read more about the issue here:
https://web.archive.org/web/20090717035140if_/javascript.about.com/od/problemsolving/a/modulobug.htm
On Tue, Feb 20, 2024 at 12:42 PM Ferrin Benjamin Katz <
@.***> wrote:

@.**** commented on this pull request.
In ts/Studio.ts
https://github.com/scottanderson/railroad.studio/pull/132#discussion_r1496244227
:

               frame.rotation.pitch = (frame.rotation.pitch + rotationOffset.pitch) % 180;

               frame.rotation.roll = (frame.rotation.roll + rotationOffset.roll) % 180;

               frame.rotation.yaw = (frame.rotation.yaw + rotationOffset.yaw) % 180;

Mod 180 works if the data is actually stored as -180 to 180. Mod handles
negatives.
—
Reply to this email directly, view it on GitHub
https://github.com/scottanderson/railroad.studio/pull/132#discussion_r1496244227,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFBWNJEICT44BPOXG5MP2LYUTOB5AVCNFSM6AAAAABDQEBOXCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOJRGA4DKNJZGA
.
You are receiving this because you commented.Message ID:
@.***>

Is there anything else that needs to be done?


Change MTU?

I have a pi4b connected via Ethernet to a T-Mobile home internet gateway, ie Trashcan.
Things were terrible during the day and usable in the wee hours of the morning. Mid February things really improved.
I have read that the wireless carriers really need the MTU to be less than the normal 1500.  I think T-Mobile needs 1430.  Is it as simple as sudo ifconfig eth0 mtu 1430?
I also wonder about ookla vs fast.com vs Google open Speedtest.
I really appreciate your posting this project.

Isn't the MTU something that the router automatically changes to optimise performance? And if to be changed manually, I would have expected that you only need to change the MTU in the router setting. But tbh, I have no idea.
Are there tools out there that check your line performance based on different MTUs?
In regard to the difference between ookla and others, please check discussion on issue #341.

"Google open Speedtest", are you referring to openspeedtest.com or something else?
OpenSpeedTest.com looks interesting. Should be easy to switch if required.

Yep, that is the one… Also look at fast.com http://fast.com/. The speeds I see with both of them are higher than with ookla.
…

Not a surprise that you see higher speeds with fast.com. It's provided by Netflix and only tests the speed to their servers, which usually are the co-located servers at your ISP (Internet Service Provider) or the closest IX (Internet Exchange). But I guess it can be a good test, if you're mostly interested in your streaming performance. Google and the likes, probably have co-located servers in the same locations.


Fixes for using cardano-api in Plutus

A few things I ran into when using cardano-api in Plutus.

bors mrege

bors merge


Fix/q sphere black vectors

Summary
Fix to avoid black vectors on the interactive Qsphere.
Details and comments
Closes #844

Thanks for identifying the bug and for the fix, @filemaster ! :+1:


Bluetooth: controller: Reuse get_entropy_isr API

Replace the use of private entropy_nrf_get_entropy_isr with the public entropy_get_entropy_isr interface. and remove the private function and associated header file in includes/drivers/entropy/nrf5_entropy.h

already fixed (according to @carlescufi at least :)


postgresql: enable pie

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 124188 at 0ba0fda6 run on x86_64-linux 1

576 packages marked as broken and skipped:

aqemu
bareos
clickshare-csc1
gnuradio3_7
gnuradio3_7Packages.ais
gnuradio3_7Packages.gnuradio
gnuradio3_7Packages.gsm
gnuradio3_7Packages.limesdr
gnuradio3_7Packages.nacl
gnuradio3_7Packages.osmosdr
...

1930 packages skipped due to time constraints:

AusweisApp2
OSCAR
acoustidFingerprinter
adminer
adwaita-qt
aj-snapshot
ajour
albert
aliza
amarok (amarok-kf5)
...

10 packages built successfully:

alerta-server
inspircd
movine
postgresql (postgresql_11)
postgresqlPackages.pgvector (postgresql11Packages.pgvector)
postgresql_10
python38Packages.psycopg2
rubyPackages_3_0.pg
rubyPackages_3_0.sequel_pg
teamspeak_server

2 suggestions:

warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/nix/store/35pnk5kwi26m3ph2bc7dxwjnavpzl8cn-gcc-wrapper-10.3.0/bin/ld' doesn't match anything in file '/nix/store/gg0g4dd4swpcc78gg5nhb7l39h525c5z-postgresql-11.11/lib/pgxs/src/Makefile.global'
Near pkgs/servers/sql/postgresql/default.nix:160:0:
    |
160 |       description = "A powerful, open source object-relational database system";
    | ^

warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/nix/store/35pnk5kwi26m3ph2bc7dxwjnavpzl8cn-gcc-wrapper-10.3.0/bin/ld' doesn't match anything in file '/nix/store/gh953ba0kbmhhvas8zzb6rwiw61vxy5w-postgresql-10.16/lib/pgxs/src/Makefile.global'
Near pkgs/servers/sql/postgresql/default.nix:160:0:
    |
160 |       description = "A powerful, open source object-relational database system";
    | ^

/rebase staging


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-24-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 832

Questions ?
Please refer to the Backport tool documentation


feat(api): add update-my-about endpoint

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #50331

Couldn't create a failing test because of the nature of the validation type, and we don't have validation in the old api as well.
It is always successes when it's called

Couldn't create a failing test because of the nature of the validation type, and we don't have validation in the old api as well.

What does this mean? We don't want to jump the gun on this.

What does this mean? We don't want to jump the gun on this.

👍, the nature of string on JavaScript that it can be anything, I can technically create a test, but it won't test anything because it will never fail.

We should test if the endpoint works correctly, also if the user is unauthenticated.

We should test if the endpoint works correctly, also if the user is unauthenticated.

If we do so, we will have to add that test for every test, and if we do that then we are testing what is auth user do not if setting is working, this can be moved to its own scope, so it doesn't meddle with the current test and keep the context of tests small and coherent as possible.

Yes we can move the unauthenticated test to for exampleauth.test.ts and check if the endpoint works correctly with some test data.

Let's discuss this in the meeting tomorrow.

It's fine to move the requires or does not require auth checks to a separate suite, but let's do that in a separate PR.

see how the tests are made in the original endpoint, mimic it
check if the value change
check if the value is string, if possilbe

There is no tests in the old api, based on this commit https://github.com/freeCodeCamp/freeCodeCamp/pull/50334/commits/46c519a3549f8844ab814a3d8068b5123f114dae


Implement SubmitProposalModal

Features

Implemented govAPI
Implemented SubmitProposalForm and Modal
Safe guard disconnected user and prompt them to connect to wallet if not done so before submitting proposal
Extracted queryClient into a standalone provider
Temporary fetches minimal deposit param directly from chain, will handle when working on GovParamPanel

Screenshots

Desktop
Mobile

based on #82
refs #66

plz rebase 🙏

rebased

also, we might want to introduce a util to display any caught errors?

the toast already reflects error state, do you want it to show the exact error message as well?

the toast already reflects error state, do you want it to show the exact error message as well?

nvm then


Switch windowing library from SDL2 to another

SDL2 is nice, but its CMake build system seems to be buggy and it doesn't use GitHub, so I cannot integrate it as a subtree. GLFW is an alternative with none of those restrictions.

If this is persued, then it will cause an issue if we switch to the BGFX library for rendering. Closing.


fix(chat): fix marketplace counter (Issue #2326)

Description:
Hide the counter in all places in marketplace
Issues:

Issue #2326

UI changes

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review

/deploy-review


[chip-test, SiVal] Tick configuration

Test point name
tick_configuration_test
Host side component
None
OpenTitanTool infrastructure implemented
None
Silicon Validation (SiVal)
Yes
Emulation Targets

[ ] None
[x] CW310
[x] Hyperdebug + CW310

Contact person
matutem
Checklist
Please fill out this checklist as items are completed. Link to PRs and issues as appropriate.

[ ] Check if existing test covers most or all of this testpoint (if so, either extend said test to cover all points, or skip the next 3 checkboxes)
[ ] Device-side (C) component developed
[ ] Bazel build rules developed
[ ] Host-side component developed
[ ] HJSON test plan updated with test name (so it shows up in the dashboard)
[ ] Test added to dvsim nightly regression (and passing at time of checking)
[ ] For SiVal test cases, test is running relevant FPGA or silicon regression

estimate 2


Bump safer-golangci-lint.yml to 1.42

[x] Certify the Developer's Certificate of Origin 1.1
(see next section).

Certify the Developer's Certificate of Origin 1.1

[x] By marking this item as completed, I certify
the Developer Certificate of Origin 1.1.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
660 York Street, Suite 102,
San Francisco, CA 94110 USA

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Nice, thanks!


Unhandled JS Exception: Unexpected token '{'. import call expects exactly one argument.  no stack

Everything's work fine until I build my project on Xcode to see my app on real device...
Everything is build fine with no errors, yarn start and Xcode Play button (for build)

$ react-native info
info
  React Native Environment Info:
    System:
      OS: macOS 10.14.1
      CPU: (8) x64 Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz
      Memory: 170.70 MB / 8.00 GB
      Shell: 3.2.57 - /bin/bash
    Binaries:
      Node: 11.10.0 - /usr/local/bin/node
      Yarn: 1.13.0 - /usr/local/bin/yarn
      npm: 6.7.0 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
    IDEs:
      Xcode: 10.1/10B61 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.8.3 => 16.8.3
      react-native: 0.59.0 => 0.59.0

Can you provide a minimal reproducible example for this? That would help us narrow down the issue better.

Seems like a error in your code. Can you provide a screenshot of console with Debug JS Remotely?

Hey @steffi3rd, I suspect that there's actually an issue in your project's code. I think if you look at Metro, you'll see a build-time error.
A few tips:

Try resetting all of the caches with:

 watchman watch-del-all && rm -rf $TMPDIR/react-native-packager-cache-* && rm -rf $TMPDIR/metro-bundler-cache-* && rm -rf node_modules/ && npm cache clean --force && npm install && npm start -- --reset-cache

Go ahead and upgrade to 0.59.1

Without a repository of your source, it's hard to give specific advice. This seems like an environment issue, but please do follow up with more detail if my pointers above don't help.

I did
watchman watch-del-all && rm -rf $TMPDIR/react-native-packager-cache-* && rm -rf $TMPDIR/metro-bundler-cache-* && rm -rf node_modules/ && npm cache clean --force && npm install && npm start -- --reset-cache

Now the error has changed but similar.
I don't any details on "Extra Info"

It works very well on Simulator.
Metro bundler is build fine
Xcode project build success

Having the same issue.. Cant see whats causing this nonsense.. Metro running fine, everything compiles.. Upon app launch this error comes up with no indication.. Nothing in the console either..

Got the same error. Renaming root index.js to index.ios.js did the trick for me. But I'm not sure what is the real issue here

Upgrading to these versions seems to have fixed this issue for me on react-native v0.59.8
package.json
   "devDependencies": {
-    "@babel/core": "^7.4.4",
-    "@babel/runtime": "^7.4.4",
+    "@babel/core": "^7.4.5",
+    "@babel/runtime": "^7.4.5",
@@ -101,7 +101,7 @@
-    "metro-react-native-babel-preset": "^0.54.0",
+    "metro-react-native-babel-preset": "^0.54.1",

I'm closing this issue since no repro was provided.

I'm having the same issue after upgrading to RN 0.59.9. The error message gives basically no clue what's wrong...

I had a similar issue with error Unhandled JS Exception: Unexpected identifier 'App'. import call expects exactly one argument. no stack
So the problem is apparently import App from './App';
I had several code blocks and reminders commented out above it, removing all these comments then the build is successful. So I suggest you to check your import methods.
Also, be careful when comment out code in RN in general, especially within render function. Hope it's helpful.

UPDATE
OK here is the digest of a few good hours spent:
In your index.js, there is something like this:
import { name as appName } from './app.json';
AppRegistry.registerComponent(appName, () => App);

Which import the name from app.json
{
  "name": "yourAppName",
  "displayName": "yourAppName"
}

To get rid of this error, just change index.js to:
AppRegistry.registerComponent('yourAppName', () => App);

and stop importing that json file.
You can keep all your present settings in devDependencies

same issue

Windows 10 - Android

info   React Native Environment Info:     System:       OS: Windows 10       CPU: (8) x64 Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz       Memory: 1.19 GB / 7.91 GB     Binaries:       Node: 10.16.3 - C:\kafka\setting\node\node.EXE       Yarn: 1.19.1 - C:\kafka\setting\yarn\bin\yarn.CMD       npm: 6.9.0 - C:\kafka\setting\node\npm.CMD
same issue

I fixed this problem by deleting the entire babel.config.js for the time being and letting react-native handle babel

If this helps anyone I had the same issue and this helped me solve it. https://github.com/facebook/react-native/issues/21530#issuecomment-427577349


Clashing binding poses

Hello,
I have been looking into the CDK2 test set and I ended up having some numerical issues related to high clashes between some of the ligands (1h1s, 28 and 29). I have attached an example picture for reference:

One of the protein hydrogen atoms is in very close proximity to one of the ligand oxygen atoms. Is this a known issue with this part of the test set? It might make sense to change the input coordinates because as it stands some of the systems are not possible to run "out of the box". Any suggestions will be appreciated.
Many thanks.

@jchodera, @dfhahn any ideas what might be going on here? Has this input not been used for a whole benchmark run?

I agree that looks funky. This may be what was actually run, though; in general there’s a lot of inherited stuff here that is only gradually getting filtered out. For example, in some of the earlier benchmarking work from others that this built on, there were missing loops and residues in some of the protein structures, varied handling of water across targets, etc. etc. In other words — all kinds of issues. HOWEVER, free energy calculations often gave reasonable results anyway. We (as a community) are beginning to get some of those problems removed, curated out, etc., but there’s likely still a not more to be done.

I'll leave it to @dfhahn and @ldamore to comment specifically.

Hi @msuruzhon, @ppxasjsm thanks for raising this issue. It is indeed not an ideal starting pose and originates presumably from aligning the core of the ligands to the crystal structure ligands.
This was the structure used for the previous benchmark runs, the reason for it being in here as well. An energy minimization, at least in the Gromacs/pmx workflow resolved the clash.
As @davidlmobley pointed out, there are still many inherited issues in this set which need to be removed.

I am struggling to see how this is a benchmark dataset then if we can't use the inputs as benchmarks. I can understand that there may be some inherited issues, but steric clashes that don't easily resolve in a minimization doesn't really seem like a sensible dataset to push in the first place. Why not used the minimized/equilibrated structures that work with Gromacs? Is there anyone from OpenFF working on this at the moment? Does OpenFF not run automated bechmarks at the moment?

I believe we normally start with an energy minimization.

I agree, but what if the minimisation doesn’t resolve the clashes?

That would be a problem, but all of these ARE successfully used for our binding free energy benchmarking. I'm also surprised by the clash, and I suppose it could be resolved by depositing the minimized structure instead, but is that what we want? I'm not sure.

I see! Is all the information needed to reproduce your benchmarks successfully in the repo? What would be the approach to propose alternative input used, that worked in a different set of benchmarks. Would it be helpful to have the input and successfully run protocols and final outputs (not trajectories) available in this case?

All steric clashes which are present were easily resolved by energy minimization. But I agree it would be more sensible to provide the minimized structures. Although that could lead to less aligned ligand sets and could (presumably only slightly) break compatibility with previously run benchmarks.

What would be the approach to propose alternative input used, that worked in a different set of benchmarks.

I guess we want to only have one input, not alternative ones as this might be confusing. I would suggest to create PRs with better structures which will go into next releases. Then you can point to the release used when reporting results.

Would it be helpful to have the input and successfully run protocols and final outputs (not trajectories) available in this case?

What do you mean with having successfully run protocols? Just name it or link to a repo with the protocol? Having the output could be an option, but does it add value? Will people use it for something?

Hi,
Just to follow on from Miro's post. We have found that some clashes for CDK2 were not resolvable and we tried minimising with a few different protocols including GMX-2021 on a cpu. The image shows a clash that goes through a lysine side-chain. We are using standard and well tested setting for minimisation.
There were various other clashes for a few other systems that caused us to want to adjust the inputs to our minimisations. This seems like it would make reproducibility and good comparisons more difficult. Removing these clashes will make these files more useable as at the moment some who encounter the same problems as us would have to make up their own alternative inputs.

Closing this out may be dependent on resolving #20 first, but we can still find a solution to the clashing problem in the meantime before writing out new sets of structure files in a PR.


Bug: Incorrect number filtering when attribute value is equal to 0

I'm trying to filter out elements whose play count is > 0 (played elements).
My filter is thus :
filters:
  plays.lt: 1

However, this does not seem to work. I traced the issue down to the function check_filters in builder.py
                elif modifier in [".gt", ".gte", ".lt", ".lte"]:
                    divider = 60000 if filter_attr == "duration" else 1
                    test_number = getattr(item, filter_actual)
                    if not test_number:
                        return False
                    if util.is_number_filter(test_number / divider, modifier, filter_data):
                        return False

The if not test_number returns True whenever test_number is 0, which filters out the element.
I assume that the test should rather be if (not test_number and test_number != 0):
This works on my side.

should be fixed in develop


Configure versioning without fields area in Entity yaml configuration

Problem: https://github.com/FriendsOfSymfony/FOSUserBundle/issues/1357
using:
UserBundle\Entity\User:
    type:  entity
    table: fos_user
    gedmo:
        loggable: true
        versioned:
            fields:
                - email
                - username
        soft_deleteable:
            field_name: deleted
            time_aware: false
    id:
        id:
            type: integer
            generator:
                strategy: AUTO
    fields:
        name:
          type: string
          length: 255
          nullable: true
          gedmo:
             - versioned
        created:
          type: datetime
          gedmo:
            timestampable:
              on: create
        updated:
          type: datetime
          gedmo:
            timestampable:
              on: update
        deleted:
            type: datetime
            nullable: true

it is possible to add annotations in protected properties if you extend the base class which is explained in the PR related to your referenced issue. DoctrineExtensions is a library and it will not add options to make it convenient for integration with other frameworks. most of the extensions would need similar changes which does the same thing, but differently. all those options confuse people, there are too many already. I actually never use such frameworks like fos bundles, but that is up to you, if it does not get into your way in every step.
My point is that doctrine extensions requires you to manage your entity mapping, and that is it.
Have you tried putting these mappings into app/Resources/FOSUserBundle/config/doctrine..orm.yml ? I think symfony framework allows you to override resources if file locator is used.


[feature] Add VEX Hub support

Is your feature request related to a problem? Please describe.
This was mentioned by Lukas Hoehl in Slack. VEX statements aren't always easy to find. VEX Hub automatically collects VEX statements and makes them easily discoverable.
Describe the solution you'd like
A certifier that queries VEX Hub for VEX statements affecting pURLs found in GUAC data.
Describe alternatives you've considered
Directly incorporating vexhub-crawler or similar into GUAC to fetch the VEX statements directly.
Additional context
This was the subject of a conversation at KubeCon today. It should be relatively simple to create a certifier for this, it "just" needs someone with the time to write the code.

From my undestandment there is not THE VEX hub.
I think the certifier should conform to the VEX Repo Spec.
Another question in place is how the certifier would discover those repositories. I guess a configuration option?

We're interested in this definitely! @knqyf263 would you be able to give us an overview and maybe have a discussion of integrations on one of our GUAC maintainer calls?

@lumjjb Sure. This is a blog from @itaysk. Also, my presentation.
As @hown3d pointed out, any VEX repositories that conform to the spec should be worked with GUAC. For example, both Aqua VEX Hub and Rancher VEX Hub work with Trivy, which implements the spec. We'll give you an overview in a call.


Cannot use Intervention\Image\Facades\Image as Image because the name is already in use

Laravel Version: 5.6
Voyager Version: 1.1
PHP Version: 7.0.9
Database Driver & Version:

Description:
when i select multiple image in voyager  and then add the voyager show this error:
"Cannot use Intervention\Image\Facades\Image as Image because the name is already in use".
please let me know what is the problem behind it and how i can fix this..

Please share the full stacktrace for that error.  It's likely something we have to fix in the package, not something you can fix yourself

I think it should be the same like here
Gonna create a PR soon.

@emptynick you did this for Image.php but i have problem in multiple image.. my image works fine.. but the problem is in MultipleImage.php .. multiple image is not working.

Yes, thats why I said it should be the same as in Image.php because there it works, and in MultipleImages not


Feature/email recovery UI

What is this PR doing?
How can these changes be manually tested?
Does this PR resolve or contribute to any issues?
Checklist

[ ] I have manually tested these changes
[ ] Post a link to the PR in the group chat

Guidelines

If your PR is not ready, mark it as a draft
The resolve conversation button is for reviewers, not authors

(But add a 'done' comment or similar)

@Rohan-cp is this still needed or can it be closed?


introduce MCMCCHain and MCMCStep datastructures and clean up

Should be cleaned up first, but then we can continue developing the pre-dev-branch

@MSRudolph  Yeah sure! I'm just merging it for now since we don't have any conflicts as such and we can always clean it up!


Allow option to show .bicepparam example rather than JSON parameters

Is your feature request related to a problem? Please describe.
We have switched over to using .bicep templates and .bicepparam files for parameters and gotten away from ARM/JSON. However, when the README.md file is generated, it only provides the JSON parameters file example.
Describe the solution you'd like
We would like PSDocs to provide a .bicepparam example instead of JSON when .bicepparam files are present or when a switch is passed.
Describe alternatives you've considered
We have tried to get the Set-ModuleReadMe.ps1 tool that is used in the CARML, but we don't seem to be able to get it to work at the moment.

Is this repository no longer maintained?


Policydefinition Enable diagnostics for resources does not have param for keyvault metrics

The policy definition Enable diagnostics for resources uses the built-in policy Deploy Diagnostic Settings for Key Vault to Log Analytics workspace. This policy has parameters logsEnabled (default value: true) and metricsEnabled (default value:false!)
Unfortunately it is not possible to set metricsEnabled to true via the policy initiative. We would like to have key vault metrics enabled.

Yes I can imagine the amount of work since 2 extra parameters for 64 policies. But I probably would advise to do it because at this moment we notice inconsistent behaviour. All the custom Enterprise Scale policies that deploy diagnostic settings have the metricsEnabled parameter default on true whilst the built-in policies have the metricsEnabled parameter default on false.
Besides we also have to use the ISO-27001 initiative because of compliance and regulation which contains the AuditDiagnosticSettings. This policy works different as well: it audits a parameter array containing a list of provided resources and for all those resources it uses a single logsEnabled and metricsEnabled parameter to inspect. So at this moment are key-vaults are compliant according to 'ISO-27001' but they non-compliant according to 'Enable diagnostics for resources'.

Could you please provide an update on this one?

Hey @neok-g,
We are awaiting to review and merge PR #1022 before working on these. We hope to review and merge this PR this week.

Trigger ADO Sync 1

Trigger ADO Sync 2

@neok-g I have received a response from the Monitor team that this is by design as this is not the recommended way to ingest metrics at scale in Azure due to performance limitations. Metric API or use the new batch API can be used and there are plans to  enhance the metrics explorer https://learn.microsoft.com/en-us/azure/azure-monitor/essentials/metrics-getting-started but no timelines currently.


Added some details in skeleton docs.

Workaround for #19551.
What is the use of get_bone_transform() for BTW?

Thanks!
Note that empty lines should not be used in the <description> tags, each line is considered a <p> (there are no "simple" line breaks). I'll merge as is anyway as I've seen quite a few other places with empty lines in the doc, I'll fix them all at once.

What is the use of get_bone_transform() for BTW?

No idea :| git blame shows the original GODOT IS OPEN SOURCE commit by @reduz so git history doesn't tell us much here about the intended use case. What's true is that nothing uses the method internally, so it might actually be unnecessary if it doesn't have a real use case in scripting.

@mysticfall I can't see anything specific about get_bone_transform on that page. But I filled in the documentation for that function in this PR based on what I saw in the source file skeleton.cpp.
So I know what it does, I just don't understand how it's useful at all.

I see. In my case, I'm using the method to emulate so called 'root motion' which involves reading a relative position of the 'position bone' to the skeleton in each frame, and applying the delta to the character itself.
But I don't know if the same feature could have been better implemented by using one of the ohter methods.

Oh, OK, maybe you can expand on the docs about it then.
It definitely needs to be renamed though because the current name doesn't convey the information that "it's the 'delta' transform between the pose and the rest, written in the skeleton reference frame"!

Oh, sorry for the confusion. What I meant was I'm storing the value of get_bone_transform to calculate the delta per each frame, rather than the API itself provides that info.
I was just worried if an API I'm currently using might be deemed redundant and removed. And also I wanted to know if the functionality provided by the method could be perfectly replaced by some other API, if in case it proved to be redundant indeed.

It's just "global" pose (which is accessible through the current API) times inverse of "global" rest (which is not exposed but exposing this makes more sense to me, compared to get_bone_transform) so it'd a essentially be a one-liner.

I don't mind changing my code to use some other API, if such an alternative would be provided before removing get_bone_transform.

Cherry-picked into 3.0.4.


Update NestJS from v5.x to v6.x

Update to the latest version of NestJS.
NestJS v6.0.0 release March of 2019: https://github.com/nestjs/nest/releases/tag/v6.0.0

Closed with PR #29


Emit SDE when a type calculator attempts to use an undefined type.

This lays down the infrastructure which allows the DPath
interperator to lookup type calculators at compile time,
which will allow us to make their return type dependent on
the calculator they are using, instead of their functin name.
DAFFODIL-2148

rebased


[BUG] Blank Screen when displaying DeviceInfo interface

Describe the bug
Trying to open the PnP Interfaces page, I got a blank screen and some errors in devtools.
I'm using the latest version 0.10.17
To Reproduce
Steps to reproduce the behavior:
I created a  PnP device following the PnP tutorials
Find the device, and try to open the PnP interface.
Expected behavior
I can inspect the interface
Screenshots

Desktop (please complete the following information):

OS: [e.g. Windows, Linux, OSX]
OS Version: Windows 10
App version 0.10.17

Additional context
TypeError: Cannot read property 'displayName' of undefined
    at t.n.renderInterfaceInfoDetail (main.3d47384f790dcc3aa741.js:1)
    at t.n.renderInterfaceInfo (main.3d47384f790dcc3aa741.js:1)
    at main.3d47384f790dcc3aa741.js:1
    at _a (npm.react-dom.3d47384f790dcc3aa741.js:9)
    at Fi (npm.react-dom.3d47384f790dcc3aa741.js:9)
    at Li (npm.react-dom.3d47384f790dcc3aa741.js:9)
    at Eo (npm.react-dom.3d47384f790dcc3aa741.js:9)
    at To (npm.react-dom.3d47384f790dcc3aa741.js:9)
    at No (npm.react-dom.3d47384f790dcc3aa741.js:9)
    at Nn (npm.react-dom.3d47384f790dcc3aa741.js:9)
ni @ npm.react-dom.3d47384f790dcc3aa741.js:9
npm.react-dom.3d47384f790dcc3aa741.js:9 Uncaught TypeError: Cannot read property 'displayName' of undefined
    at t.n.renderInterfaceInfoDetail (main.3d47384f790dcc3aa741.js:1)
    at t.n.renderInterfaceInfo (main.3d47384f790dcc3aa741.js:1)
    at main.3d47384f790dcc3aa741.js:1
    at _a (npm.react-dom.3d47384f790dcc3aa741.js:9)
    at Fi (npm.react-dom.3d47384f790dcc3aa741.js:9)
    at Li (npm.react-dom.3d47384f790dcc3aa741.js:9)
    at Eo (npm.react-dom.3d47384f790dcc3aa741.js:9)
    at To (npm.react-dom.3d47384f790dcc3aa741.js:9)
    at No (npm.react-dom.3d47384f790dcc3aa741.js:9)
    at Nn (npm.react-dom.3d47384f790dcc3aa741.js:9)

The pr is merged but not released. Reopening the issue, will close after release.

https://github.com/Azure/azure-iot-explorer/releases/tag/v0.10.18
Latest release has been published to address this issue.
Closing.


Create MiniCard component

https://gatsby-theme-carbon.vercel.app/components/MiniCard

Hey team! Please add your planning poker estimate with ZenHub @andreancardona @francinelucca @jdharvey-ibm


RS-116 set MatCard as popup body

[x] set popup for markers
[x] set popup for item without markers

@markolaban / @Sam-Boyes-l33t can you have a quick look of the changes ? added screenshots of the result of this popup in https://l33tsystems.atlassian.net/browse/RS-116?atlOrigin=eyJpIjoiYWYwYjc3YTAzMGI3NDgzODg2ZDI2MGU5ZGQxNjU2MmUiLCJwIjoiaiJ9


Use safe variance epsilon for float16 layer_norm

The original epsilon value (1e-12) is too small for float16 and can
cause NaNs in the output when the variance is small.
This commit also adds float16 and float32 cases to LayerNormTest and
improves the numerical robustness of the test logic.

I believe this is one of (but not all of) the reasons that NaNs are observed during fp16 training of the BERT model as noted here: https://github.com/google-research/bert/pull/255#issuecomment-450591507

**import/copybara ** — An error happened while migrating the change
Required

@rthadur any idea what this means / how to retrigger?


I think there should not import classes in log4j

https://github.com/spring-cloud/spring-cloud-gateway/blob/6f5513052bad284a7032bc6251d9020251808cca/spring-cloud-gateway-core/src/main/java/org/springframework/cloud/gateway/support/ipresolver/XForwardedRemoteAddressResolver.java#L24
Hi team:
How do you think about this?

You are correct, of?


python-include-tests: fix errors when setuptools-check-hook is used

no-python-tests also fired when a package uses setuptools-check-hook,
which is the default for format = "setuptools".
This change also makes the test more robust. Checks in Python packages
are actuall install checks, however buildPythonPackage also accepts
doCheck/checkInputs, which are then used to set
doInstallCheck/installCheckInputs. Consequently, it is also valid for
a derivation to use doInstallCheck/installCheckInputs instead.
To complicate matters, we cannot just check derivation arguments,
since buildPythonPackage also sets doInstallCheck/installCheckInputs
when the project format is setuptools.
This change updates the test to look for check hooks in the
nativeBuildInputs of the final derivation. As well as checking
whether install checks are enabled.

Sounds right. Could you also add the old test case as a negative test (in run_tests.py)?

Perhaps this is complex enough that we should add the the python3Packages.somajo expression as a test?

somajo is basically the old test case.

Though with this change it will basically not match anything so I wonder why did we introduce this in the first place. Maybe the issue was that setuptools deprecated test command (https://github.com/pypa/setuptools/issues/1684)?

somajo is basically the old test case.

Indeed. I can add that as a negative test case.

Though with this change it will basically not match anything so I wonder why did we introduce this in the first place. Maybe the issue was that setuptools deprecated test command (pypa/setuptools#1684)?

It still fires when format != "setuptools" and there is no checkPhase, hook, or pythonImportsCheck`.

It still fires when format != "setuptools" and there is no checkPhase, hook, or pythonImportsCheck.

Yeah, I meant that 90 % of expressions have format = "setuptools".

It still fires when format != "setuptools" and there is no checkPhase, hook, or pythonImportsCheck.

Yeah, I meant that 90 % of expressions have format = "setuptools".

Ah, yes. As far as I understand, there is currently not a good solution. Since now this lint fires for derivations which have proper tests that are executed. On the other hand, there are probably many derivations that run zero tests through setuptoolsCheckHook. The buildPythonPackage source code suggests that setuptoolsCheckHook should probably no be added automatically in the future. Maybe now that there is tooling like nixpkgs-hammering, it's time to make that switch?

setuptoolsCheckHook

That phase will soonish no longer be called by default.

setuptoolsCheckHook

That phase will soonish no longer be called by default.

What's the timeline? Do you have a reference?

I was a bit confused about this when I tried to add a new package to nixpkgs and it got flagged. Maybe there should be a line about this in the explanation file for python-include-tests, regardless of how this issue is settled in the end?

@jtojnar: Anything to do here from your perspective before merging?

This check is still confusing to me so the explanation should be made clearer and maybe some comments explaining the status of setuptoolsCheckHook could be added. But given that it was confusing even before, this PR is probably not a place for that.
Thanks for your contribution and sorry for the delay.


[Task]: Research on available GraphQL parsers

Connector Name
other (None Listed Above)
Task Description
GraphQL parser is needed to generate the basic structure for the Ballerina syntax tree. Research for GraphQL parsers currently available.

Closing the issue as this task is completed. A Summarized research findings can be found here.


[Bug]: adding stlib call in the prompt step

📜 Description
Currently the prompt step doesn't support calling of the stdlib calls. Instead we have to define a separate evaluate step to get the stdlib functionalities and then [ass it as a variable in the prompt step.
👟 Reproduction steps

- prompt:
  - role: system
    content: >-
        You are a highly capable financial assistant named FinanceGPT. Your purpose is to provide insightful and concise analysis to help users make informed financial decisions.

        When a user asks a question, follow these steps:
        1. Identify the relevant financial data needed to answer the query.
        2. Use the available tools to retrieve the necessary data, such as stock financials, news, or aggregate data.
        3. Analyze the retrieved data and any generated charts to extract key insights and trends.
        4. Formulate a concise response that directly addresses the user's question, focusing on the most important findings from your analysis.

        Remember:
        - Today's date is {{datetime.datetime.now().isoformat()}}.
        - Avoid simply regurgitating the raw data from the tools. Instead, provide a thoughtful interpretation and summary.
        - If the query cannot be satisfactorily answered using the available tools, kindly inform the user and suggest alternative resources or information they may need.

        Your ultimate goal is to empower users with clear, actionable insights to navigate the financial landscape effectively.

        Remember your goal is to answer the users query and provide a clear, actionable answer.

👍 Expected behavior
The prompt step failed
"message": "'datetime' is undefined",

👎 Actual Behavior with Screenshots
No response
💻 Operating system
None
What browsers are you seeing the problem on?
No response
📃 Provide any additional context for the Bug.
No response
📖 Relevant log output
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🔗 Are you willing to submit PR?
None
🧑⚖ Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hey @Vedantsahai18 can you give some more details about the changes?
Which files are supposed to be reffered here ?

Solved


chore(examples): updates auth example to 3.0

Description
NOTE: This PR is waiting on a new beta release (expected 3.0.0-beta.24). Do not merge until a new version has been installed.
Updates the Auth Example to use Payload 3.0 (integrated Payload + Next.js App Router). This PR:

Installs 3.0 beta into the payload dir and builds an integrated Next.js app using the Local API for auth

Migrates from a server-side fetch to calling the payload.auth operation directly via initPage

Establishes a pattern for the remaining examples, i.e.:

How to continue to showcase other frameworks alongside Payload 3.0 (which ships with its own Next.js front-end)
Moves initial database seed function to an official migration script
Migration from yarn to pnpm (not required, but our examples will now default to pnpm)
Updated READMEs

[x] I have read and understand the CONTRIBUTING.md document in this repository.

Hello! I'm sorry, just asking because I'm doing auth now and want to know a better way, is there a specific reason why here  https://github.com/payloadcms/payload/blob/6699040b2944261eb4cc20cdf4e26b9e6cb1e22f/examples/auth/payload-next/src/app/(app)/_utilities/getMeUser.ts you are using rest api instead of payload.auth? you just need to pass headers to it from Next js.
is this because you want to execute read field access as well? (meOperation finds user with overrideAccess: false so it makes sense)

Hey @r1tsuu it's no problem, happy to provide some context here. You're right in that we can lean into the Local API now instead of REST. That will definitely happen, just one step at a time. Right now we're mainly concerned with getting a new pattern for our Examples Directly so that we can continue to demonstrate traditional headless setups as well as alternative frameworks, on top of the new 3.0 paradigm. Stay tuned into this PR for a full glimpse into exactly how we suggest you setup auth in your own apps going forward.

Hey @r1tsuu just following up here. Check out the latest code where we use the initPage function to send headers, cookies, etc. to the payload.auth operation similar to as you've described. This is the same utility used in the admin panel itself.

Yeah that's nice, I've done a simillar thing which basically the same but provides the props directly to the component
import configPromise from '@payload-config';
import { headers } from 'next/headers';
import { initPage } from 'node_modules/@payloadcms/next/dist/utilities/initPage';
import type { InitPageResult } from 'payload/types';
import React from 'react';

type ServerComponentProps = {
  params?: Record<string, string>;
  searchParams?: Record<string, string | string[]>;
};

export type WithPayloadComponentProps = InitPageResult & ServerComponentProps;

export const withPayload = (Component: React.FC<InitPageResult & ServerComponentProps>) => {
  const ComponentWithPayload = async ({ params, searchParams }: ServerComponentProps) => {
    const initPageResult = await initPage({
      config: configPromise,
      route: '/home',
      searchParams: searchParams ?? {},
    });

    return <Component {...initPageResult} params={params} searchParams={searchParams} />;
  };

  return ComponentWithPayload;
};

async function Page(props: WithPayloadComponentProps) {
  console.log(props.req.user);
  const data = await props.req.payload.find({ collection: 'admins' });

  return <div>{data.totalDocs}</div>;
}

export default withPayload(Page);

I'm not a huge fan of the HOC pattern here tbh simply because you still need to thread through custom args for each page, i.e. the config and the route. This adds an extra layer of complexity imo.

I'm not a huge fan of the HOC pattern here tbh simply because you still need to thread through custom args for each page, i.e. the config and the route. This adds an extra layer of complexity imo.

that's just example you can pass route to withPayload function (i forgot about this as i just tested how it can work), but i agree that simple function call is simpler here to use.

@r1tsuu after some deliberation I've went ahead and moved away from initPage altogether in favor of using the payload.auth operation directly. Here's an example:
    import { headers as getHeaders } from 'next/headers.js'
    import { getPayloadHMR } from '@payloadcms/next'
    import config from '../../payload.config'

    export default async function AccountPage({ searchParams }) {
      const headers = getHeaders()
      const payload = await getPayloadHMR({ config: configPromise })
      const { permissions, user } = await payload.auth({ headers })

      if (!user) {
        redirect(
          `/login?error=${encodeURIComponent('You must be logged in to access your account.')}&redirect=/account`,
        )
      }

      return ...
    }

I've outlined this in the README as well.


Create ad-unit

added glossary term for ads: ad unit
Description of the change:
Reason for the change:
Link to original source:

Closes #

Hello @negarzipan,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


Small cleanup. Avoids duplication of these arrays in program memory

Small cleanup. Avoids duplication of these arrays in program memory


STYLE: Move static BaseComponent member functions to Conversion class

@mstaring With this pull request, I moved all the helper functions to convert parameters to string to "elastix/Core/Install/elxConversion.h" (+ ".cxx"). Is that OK to you? Or would you prefer a different directory for those two source files?

@mstaring With this pull request, I moved all the helper functions to convert parameters to string to "elastix/Core/Install/elxConversion.h" (+ ".cxx"). Is that OK to you? Or would you prefer a different directory for those two source files?

this looks like a great reorganization to me

this looks like a great reorganization to me

this looks like a great reorganization to me

The pull request itself is simple. In the last few months I had placed some value-to-string utility functions that I needed for the Transform classes in elx::BaseComponent. They did not really belong there. It was just because I did not know where else to put them.
Now that there are ten of such conversion helper functions, I think it's clearer to group them together in an elx::Conversion class. OK?

this looks like a great reorganization to me

The pull request itself is simple. In the last few months I had placed some value-to-string utility functions that I needed for the Transform classes in elx::BaseComponent. They did not really belong there. It was just because I did not know where else to put them.
Now that there are ten of such conversion helper functions, I think it's clearer to group them together in an elx::Conversion class. OK?


Fix patching page preview causing core plugins to be cleared

Resolves #232, #227
Enclosed the patching part inside app.workspace.onLayoutReady.
@Quorafind Can you please test it to see if it fixes the problem?

Okay. I will look into this on this weekend.


Fix default batching in variational algorithms

Summary
Fixes #8926.
Details and comments
As we motivate users to use the runtime primitives over runtime programs, it is important that the code remains as efficient as possible. With the variational algorithms released in 0.22.0 however, there's a significant slowdown if hardware is used (also with Sessions), as we didn't include batching of energy evaluations. This PR fixes that performance issue by adding default batching in case the user didn't specify any, which is the same behavior users previously had with the runtime programs.
For the 0.23 release we're planning to update how batching works and then these hardcoded limits can be removed, but we probably don't want to wait 3 months to fix this slowdown of a factor of ~2 🙂
I'm not sure if it's ok to change the default of the internal _max_evals_grouped (@mtreinish @jakelishman what do you think?) but I couldn't find another way to check if the user set the _max_evals_grouped manually. If that change blocks inlcuding this as a bugfix, we could also not fix this behavior and add a very big textbox in the docs that says users really have to enable batching themselves manually. Until they discover that note, however, they likely already complained about slow runtimes... 😄

When we first put such function in Aqua it was a simple boolean to turn on batching or not - the optimizer could send as many as it wanted when enabled. People wanted better performance and we were looking to leverage Aer parallel capability. What transpired was that the performance consideration was in regard of running bigger systems - larger operator and more pauli terms/groups. What happened was it would run out of memory with the circuits very easily. Hence we dropped to max_evals_grouped as a more controlled setting and defaulted it off - here the number of points (evals) could be defined, with it defaulting to 1 which is normal non-batched behavior.
Could something be more specifically done around SPSA that is being used for real hardware - detect that and set the batch level to 2 for your default case. I guess that does not cover the calibration where we can batch all those points at once. If that's needed then enough to cater to that too. Hopefully whatever we do then with some remote device, whether via the runtime or via say these backend wrappers we do not hit memory issues.  I guess if that would happen then setting the max grouped evals explicitly on SPSA to some smaller number for a user would be a solution should this be a problem. This way hopefully it performs by default well, compared to the original runtime VQE etc, and there is some fallback, which the code in this PR already caters too in terms of an explicit setting. Since the runtime devices are all real/qasm sim (not statevector) maybe limiting this to SPSA might be ok - though I believe you had a concern over the gradient descent too but maybe that can be included too so its more selective about the optimizer as to when its enabled and maybe the values set can be chosen accordingly.

After talking with @jyu00 and running a test with 1000 circuits on the primitives (which failed) maybe reducing the number of grouped evals specific to SPSA would be the best approach for now. Until the primitives handle chopping the jobs into sizes that the memory on the devices can handle, we cannot just "turn on" the batching as we still have the same problem @woodsp-ibm describes above. I'll adjust it 👍🏻

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

24 of 26 (92.31%)  changed or added relevant lines in 6 files are covered.
40 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.07%) to 84.456%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/algorithms/eigensolvers/vqd.py
3
4
75.0%

qiskit/algorithms/minimum_eigensolvers/sampling_vqe.py
3
4
75.0%

Files with Coverage Reduction
New Missed Lines
%

qiskit/primitives/backend_sampler.py
3
96.25%

qiskit/primitives/backend_estimator.py
9
95.71%

qiskit/transpiler/passes/layout/vf2_post_layout.py
11
88.17%

qiskit/transpiler/target.py
17
94.7%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
62211

Relevant Lines:
73661

💛  - Coveralls


Update LP favicon

Lonely Planet's favicon is the older logo, it should reflect the current one, found here: https://company-98919.frontify.com/d/zA3SDMNUX4s8/style-guide#/basics/logo.
Per Andy, use the favicon found here: lp_favicon.ico.zip

A bit confused here, I don't think that the ENTIRE LP Logo is going to fit inside a Favicon...

I think we need an actual designed Favicon, here's the issue, you can't just squish our logo down to Favicon size...
This is what it would look like...

Which looks pretty awful by comparison...

@chrissysievers ^^

@andycarmstrong I know you were once working on a style guide for .com...were any alt logos developed? Specifically favicons? Check out the issue above and the hurdles JC is running into. We need some UX advice.

@jcreamer898 @chrissysievers I recreated one for the Korean website a few months ago. Try this out:
lp_favicon.ico.zip

@WunderBart is this one that you could try out?

Sure! Lemme take care of it.

@andycarmstrong the favicon is looking pretty cramped. The devs will go ahead and push this live, but they flagged some concerns about it's readability.
Does LP have any kind of logomark? (or is the old "lp" favicon it?)

@WunderBart I spoke with @andycarmstrong and @bpotterbaum this morning. They agree the full logo isn't good, but apparently the alternative "lp" favicon we currently use has already been discussed and not approved by the brand team. Because of that we technically need to move forward with updating this to the full logo and the UX team should have more discussions with the Brand team on updating this: https://company-98919.frontify.com/d/zA3SDMNUX4s8/style-guide#/basics/logo to include a better favicon.
cc: @laserchicken


flash: catch exceptions while fetching state

This patch catches (DAPLink) probe timeouts while waiting for a flash operation. These timeouts can occur on targets that are stalled for a long time. It also reverts my previous attempt to fix the issue, which is unnecessary now and might cause other timeouts.

/azp run


Support clearing previous notification

Hello,
I'm a new user of this library. Thanks a lot for this simple to use notification library for Windows !
I have a specific use case in my application where I want to raise a notification under certain conditions, but if theses conditions are no longer meet, I want to be able to clear the previous notification that was raised.
e.g.:
If connection to remote server cannot be established, then I raise a notification
..
When connection to remote server is restored, I want to clear the notification.
Looking at Windows API. Is seams to be possible to update or clear notification by defining tag and/or group.
My expectations

the function notify() should allow defining custom tag and custom group
a new function remove(tag, group) should be defined to clear notification identified by tag and group.

+1 I also need this.
Lets say my app is doing Step1, then it finished it so it showed user the toast (he did not close it).
Now user starts doing Step2, i want to clear all toasts.

@Radexito This is now supported by calling clear_toast(app_id=APP_ID, tag=notification_id, group='default').
But I did not update the README with an example.


Ability to delete Lists, Tags etc.

Also I can not add manga's to my list while doing set_standart_lists [2021 Reading Challenge] it does as [2021 Reading Challenge] as different lists.

I delete manually my own.

After updating the new version I cant get work mangadb
I get integration errors.
.py", line 72, in upgrade
c.execute(f"UPDATE {bridge_table} SET {fk_name} = ? WHERE {fk_name} IN "
qlite3.IntegrityError: UNIQUE constraint failed: BookArtist.book_id, BookArtist
artist_id
0:31:48 - INFO - <IP_ADDRESS> - - [25/Feb/2021 00:31:48] "←[35m←[1mGET / HTTP/1.1←
0m" 500 -

Which version are you using (standalone windows etc. and if you're using the source version which python version and so on)?

Standalone windows

Should be fixed with v0.25.1

Yes it works now, thanks!


2022101301

Closes #6818
Closes #6820
Closes #6821
Closes #6822
Closes #6823
Closes #6824
Closes #6825
Closes #6826
Closes #6827
Closes #6828
Closes #6829
Closes #6830
Closes #6833
Closes #6834
Closes #6835
Closes #6836
Closes #6837
Closes #6838
Closes #6839
Closes #6841
Closes #6842
Closes #6843
Closes #6844
Closes #6845
Closes #6846
Closes #6850
Closes #6851
Closes #6852
Closes #6853
Closes #6854
Closes #6855
Closes #7190
Closes #7340
Closes #7595
Closes #7758
Closes #7759
Closes #7760
Closes #7761
Closes #7762
Closes #7800
Closes #7801
Closes #7802
Closes #7803
Closes #7805
Closes #7806
Closes #7807
Closes #7808

https://github.com/helium/denylist/issues/7962
https://github.com/helium/denylist/issues/7963
https://github.com/helium/denylist/issues/7964
https://github.com/helium/denylist/issues/7965
https://github.com/helium/denylist/issues/7967
https://github.com/helium/denylist/issues/7968
https://github.com/helium/denylist/issues/7984
Please put these together, it is very clear that cheating, device owners can only rely on slander to try to avoid being banned

https://github.com/helium/denylist/issues/8031
The dispute is very serious. We hope you can verify and reply us

#8031 争议很严重。希望您能核实并回复我们

作弊的人还奢望有第二次机会，这个人用中国大陆的ip，热点却在台湾，这是怎么操作的哦。

#8031 争议很严重。希望您能核实并回复我们

作弊的人还奢望有第二次机会，这个人用中国大陆的ip，热点却在台湾，这是怎么操作的哦。

Just because you don't have friends doesn't mean others don't. Taiwan is part of China. Can't I go? Photo devices are provided, if my device is not there, how do I get the photos? So you are Chinese, how do you know about helium project? Because I turned in your equipment? You want revenge? But you can't find a flaw in my evidence, so you have to use this argument?

#8031 争议很严重。希望您能核实并回复我们

作弊的人还奢望有第二次机会，这个人用中国大陆的ip，热点却在台湾，这是怎么操作的哦。

你没有朋友，不代表别人没有。台湾是中国的一部分。我不能去吗？提供了拍照设备，如果我的设备不在那里，如何获取照片？那么你是中国人，你是怎么知道氦项目的？因为我上交了你的设备你想复仇吗但是你在我的证据中找不到破绽，就非要用这个论点？

台湾是，但是你这个垃圾不是


Is the pretrained parameters for the neural network for cifar100? Why the size of full connection weight is 512×1000？

No description provided.

1000 class must be the imagenet pretrained model.All cifar100 pretrained models are in pretrained_models/resnetforcifar/.


Add support for "expected" failures

Expected failures are known failures that you want to write a testcase for before having an actual fix. The desired behaviour is that the test exist successfully to signal "everything is ok" until the bug is actually fixed, in which case the test exits with a failure to signal "you need to update the test to stop expecting a failure".
Dejagnu uses X prefix for expected failures, as in "xcheck(...)" or "xcheck_equals(...)", and outputs XFAIL for expected failures (everything ok) and XPASS for unexpected successes (need to update the test).
For mocha I've been thinking this could be implemented in terms of an .expected attributes attached to the exception passed to the "done" function, so that you could write a test like:
try {
assert.ok(thisShouldBeTrue);
} catch (e) {
e.expected = true;
throw e;
}
Or, even better, some extension to the assertion class to do this automatically (but that'd be outside the scope of mocha)

@tj it would be really great to have the xfail test tag. I use it all the time in pytest as a better skip.
http://doc.pytest.org/en/latest/skipping.html#mark-a-test-function-as-expected-to-fail

I say this as I recently forgot to unskip some tests that now pass.

@tj I also had to implement the feature in a half-assed way here: https://github.com/cst/cst/pull/146/files#diff-34468083d0a6e7b743e38f7c1f5783d0R39


Add to job log if job is orphaned

Fixes #860
Todo

[x] Add Tests

Changes

When a job is orphaned, a message is added saying such and if it is successfully retried, another message is added giving the new job id

Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

Please be sure to add me as an assignee whenever gears are involved.
Looks like CI is red.

Codecov Report

Merging #983 into master will decrease coverage by 0.02%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
- Coverage   90.04%   90.01%   -0.03%
==========================================
  Files          49       49
  Lines        6641     6643       +2
==========================================
  Hits         5980     5980
- Misses        661      663       +2

LGTM2


Nested query with bool doesn't work when there is only one MUST condition.

$bool = new BoolQuery();
$bool->add(new MatchQuery('some.field', 'someValue'), BoolQuery::MUST);

$nested = new NestedQuery('urls', $bool);

Will produce:
{
  "nested": {
    "path": "urls",
    "query": {
      "bool": {
        "match": {
          "some.field": {
            "query": "someValue"
          }
        }
      }
    }
  }
}

Missing must condition inside bool...

I fixed this bug and added more 2 test-cases also. Please take a look on this.


build(container-loader): Convert to node16 module resolution

Updates the container-loader project to use node16 module resolution by inheriting from the newly added tsconfigs. In addition, to ensure that the ESM output works properly in node, I converted the project to use tsc-multi as was first explored in https://github.com/microsoft/FluidFramework/pull/18224.
This change required some code changes, likely because of bugs that the new module resolution addresses. I made some simple changes, but I don't know that they're the best fixes.

/azp run Build - client packages


Allow user to input lin scale argument

I am not sure whether the linear scale works at all (it has a zero frequency bin that the others haven't), that's why it has not been exposed in the examples.

no problem - thought it was just a typo since it's mentioned in the doc.


error: Build input files cannot be found:

When I try to build the BunPuro scheme, I get this error:
error: Build input files cannot be found: '.../BunPro/Dependencies/ProcedureKit/Sources/ProcedureKit/Result.swift', '.../BunPro/Dependencies/ProcedureKit/Sources/ProcedureKit/SignpostObserver.swift', '.../BunPro/Dependencies/ProcedureKit/Sources/ProcedureKit/Encode.swift', '.../BunPro/Dependencies/ProcedureKit/Sources/ProcedureKit/Decode.swift'

If it's still building for you, @Rion-Kaneshiro , then you probably somehow didn't commit them? In any case, fixing #4 would also fix this issue along the way.

Fixed via 6767732eb6dc8e7bb676c71e454a46c4797a01d1.


Add EmailAsAlternateId to Staged Rollout options

Opening a new issue as instructed in #489.
Staged Rollout support for EmailAsAlternateId was added in AzureADPreview <IP_ADDRESS>.

Hi @calvinlui
I have opened a work item for this so that engineering can take a look and possibly address this. Unfortunately, these examples are coded in the source and generated automatically, so any updates would get overwritten once we update this again. We need to get engineering to change this in the code. At this point, I am going to go ahead and close this issue and will post any update I have here.
But any issue you run in to, keep these coming because the more work items I open, the quicker we are to getting a fix.
Thanks!
Bill


.NET - Remove C# Tests in favor of Spec based tests

Remove all Test projects, leaving only the Spec based test runner
Add Spec with DateTime SplitDateAndTime
Add Spanish Holiday Spec
Include DecimalAndThousandsSeparators and Number ParserFactory tests (helpers not covered by Specs)

The Code Coverage with the Spec based approach is the same as with the older tests.

With the new French timex, this PR needs to be modified.

Hi @tellarin ,
Merge conflicts were resolved. New French DateTime tests were re-created as Spec files


When hazelcast is disconnected, how to give up retry after several retries

When hazelcast is disconnected, how to give up retry after several retries,The com.hazelcast.client.config.connectionretryconfig configuration is set but has no effect. The version of hazelcast is 4.2

`final ClientConfig clientConfig = new ClientConfig();
clientConfig.getNetworkConfig().addAddress(hazelcastConnection);
final var connectionRetryConfig =
    clientConfig.getConnectionStrategyConfig().getConnectionRetryConfig();
connectionRetryConfig.setClusterConnectTimeoutMillis(
    Duration.parse(hazelcastConnectionTimeout).toMillis());

LOG.info("Connecting to Hazelcast '{}'", hazelcastConnection);

final HazelcastInstance hazelcast = HazelcastClient.newHazelcastClient(clientConfig);

LOG.info("Importing records from Hazelcast...");
closeable = importService.importFrom(hazelcast);`

`zeebe:
client:
broker.contactPoint: localhost:26500
security.plaintext: true
worker:
  hazelcast:
    connection: localhost:5701
    connectionTimeout: PT30S`

The com.hazelcast.client.config.connectionretryconfig configuration is set but has no effect

zeebe:   client:     broker.contactPoint: localhost:26500     security.plaintext: true     worker:       hazelcast:         connection: localhost:5701         connectionTimeout: PT30S
 final ClientConfig clientConfig = new ClientConfig();     clientConfig.getNetworkConfig().addAddress(hazelcastConnection);     final var connectionRetryConfig = clientConfig.getConnectionStrategyConfig().getConnectionRetryConfig();     connectionRetryConfig.setClusterConnectTimeoutMillis(     Duration.parse(hazelcastConnectionTimeout).toMillis());     LOG.info("Connecting to Hazelcast '{}'", hazelcastConnection);     final HazelcastInstance hazelcast = HazelcastClient.newHazelcastClient(clientConfig);     LOG.info("Importing records from Hazelcast...");     closeable = importService.importFrom(hazelcast);

Crazy output of error logs like this will not stop if the program does not shut down forcibly

@bugbugmaker which version of the simple monitor do you use?

2.0.0-SNAPSHOT

@bugbugmaker which version of the simple monitor do you use?
2.0.0-SNAPSHOT，What causes it?

The issue is a duplicate of #274. It is already fixed with version 2.1.0 :rocket:


Create GitHub Action Workflow to build and test

We need to set up a GitHub Actions workflow to automate the build and test process for our Java application and TypeScript/React UI. This will ensure that the builds/compiles do not fail and that all tests pass.
Set Up GitHub Actions Workflow

[x] Create a new GitHub Actions workflow file in .github/workflows/ directory
[x] Define the workflow triggers (e.g., push, pull_request)

Build Java Application

[x] Set up JDK environment
[x] Cache Maven dependencies
[x] Run mvn clean install to build the Java application
[x] Run tests and ensure they pass

Compile TypeScript/React UI

[x] Set up Node.js environment
[x] Cache npm dependencies
[x] Run npm ci to clean install dependencies
[x] Compile the TypeScript/React UI using npm run build
[x] Run frontend tests and ensure they pass

Complete with GH-4 and GH-5.

Ensured workflow is passing and posting results to Codecov


Use reserved domain for the example URL on page "Live Preview"

Even though .url isn't a top-level domain yet, it can be potentially dangerous to have a random URL as an example that isn't reserved for examples.
I recommend replacing [this is a link](https://to.some.url) with [this is a link](https://example.org) on the page Live Preview.

Yep, thanks, fixed!


Feature Request:  dependency on other

Description
<link data-trunk> is fetching the data which is existing before building of Rust resources. If Rust compilation creates the assets like stylesheet (for example, this is done by stylers, which is static stylesheet generator), they are not correctly loaded by Trunk as non-existent file, or fetching old one which is made by the last build, which cause the version mismatch.
error from build pipeline

Caused by:
    0: error getting canonical path for "/the-proj-dir/target/stylers/main.css"
    1: No such file or directory (os error 2)

Stylers officially offers the way for this by adding following post_build script, but this is intended for <link rel=stylesheet> without data-trunk, which is not tracked by Trunk and loaded dynamically. It's problematic. Cache wouldn't be busted in local development/production, and optimization is not done by Trunk.
[[hooks]]
stage = "post_build"
command = "sh"
command_arguments = ["-c", "cp ./target/stylers/main.css $TRUNK_STAGING_DIR/"]

The full entrypoint html is like following:
<!DOCTYPE html>

    <link data-trunk rel="rust" data-bin="leptos" />
    <link data-trunk rel="css" href="target/stylers/main.css" />

Expected feature
I want the feature to specify the dependency of them, or just wait all asset fetching after Rust resources' builds.
First idea would look like following:
<!DOCTYPE html>

    <link data-trunk rel="rust" data-bin="leptos" id="main" />
    <link data-trunk rel="css" href="target/stylers/main.css" data-depends="main" />

Not sure how can we treat that if there're multiple dependencies.
Second idea is simple, but not extensible.

I agree that having a chain of internal build dependencies makes sense. However, this will be a bigger task, as trunk currently has no idea, other than the hard coded order of running processors.
I think it makes sense adding this to a more long-term roadmap. And I think the idea to represent this with the link element makes sense. I'd definitely like to consider this for a post 0.21.x release.


Cancelling a file upload will not allow you to re-open the upload files dialog

This is a bug introduced by the way we approached https://github.com/mozilla/brackets/pull/621.
Specifically, this is the bug: https://github.com/mozilla/brackets/pull/621#issuecomment-286286626
With the same approach that that PR takes, what we really need to do is to listen for the "cancel" event on the <input type-"file">, but apparently that is impossible (after doing some research).
The right solution but just be to change our approach of how we handle the closing/opening logic of the dialog but we still need to figure that out.

I might not understand, but why can we not "always clean up" when someone picks the upload option? We don't really need to listen for a cancel, our UI just needs to make sure that when a user takes an action that opens file-upload-UI, it makes that happen. If an old upload instance can get in the way, then the solution would appear to be to destroy it at the time it would become a problem

@Pomax
is this what you are saying?
UploadFilesDialog.js#L143
Replacing .hide() with .destroy()?
If so, destroying the file-upload-UI when they choose upload from computer, causes it to not upload any file.

Yes: if we're hiding it already anyway and it doesn't come back on a file selection, then we might as well destroy it immediately so that the next time a user clicks "upload", a completely new manager is created.

@gideonthomas @Pomax
We cannot call destroy() because it contains this.fileInput.remove(); and it ignores the uploaded file.
However, If we call _uploadDialog = null; after UploadFilesDialog.js#L143 every thing is working fine. It fixes this issue.
Is this good to go? If so I'll create a PR.

Absolutely, if that fixes the issue, file a PR and we can test to verify!


"az network bastion create" throws error when "scale-units" parameter is not given

According to the docs the required parameters of the az network bastion create command are --name, --public-ip-address, --resource-group and --vnet-name. However, running the command with just these four parameters results in the following error:
'<' not supported between instances of 'NoneType' and 'int'
This can apparently be resolved by adding the optional parameter --scale-units.
Azure CLI version 2.30.0

@diongerritzen Thanks for the feedback. We're investigating this and will get back to you shortly.

@diongerritzen Thank you for bringing this to our attention. I'm able to reproduce the error you're seeing.
This is certainly not the expected behavior though. I've created a bug report with the Azure/azure-cli repository so our Azure CLI Engineering Team can take a look and fix. Please follow further updates to this issue on the same thread. Updates to docs would follow accordingly. Thanks again for the feedback.

I see this issue is closed but still getting same error "'<' not supported between instances of 'NoneType' and 'int'". And this error is confusing and misleading.
Once I provide --scale-units which is an optional param, it works.

@UmarMohamedUsman This was indeed fixed and released as part of the latest version of Azure CLI available today, i.e., version 2.31.0 (release notes here). Not sure of the version you are seeing this with, but do try upgrading to the latest version and check if the issue persists.
If you still run into issues, please try commenting your findings here or open a new issue with the Azure/azure-cli repository with the detailed error logs.


Exclude non-locatable sites from ordering

Context
When we calculate the nearest site for a course we want to exclude sites
that have insufficient address data as they cannot be accurately
geocoded.
Changes proposed in this pull request
Add a where clause that only includes sites if they have an address1 or
postcode value when building the sites with distance Arel table.
Guidance to review
Checklist

[ ] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

 Ignore sites with no address in location searches


added demo for using Windows PowerShell modules

@SteveL-MSFT  Please resolve the conflicts on .spelling file.

@joeyaiello @HemantMahawar Please have a look at this.

@joeyaiello  @HemantMahawar  ping..

@joeyaiello you feedback has been addressed, can you review again?


Fix range-loop-analysis warning

Compiling on MacOS with Apple Clang 12 gives this warning:
FAILED: hazelcast/test/src/CMakeFiles/clientTest_SHARED_64.dir/HazelcastTests1.cpp.o
/Library/Developer/CommandLineTools/usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_CHRONO_DYN_LINK -DBOOST_NO_AUTO_PTR -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_VERSION=5 -DELPP_DISABLE_ASSERT -DELPP_WINSOCK2 -DHAZELCAST_GIT_COMMIT_DATE="Wed Oct 28 15:12:43 2020 +0300" -DHAZELCAST_GIT_COMMIT_ID=46cf6982 -DHAZELCAST_VERSION=\"4.0-SNAPSHOT\" -DWIN32_LEAN_AND_MEAN -I../hazelcast/include -I../hazelcast/generated-sources/src -I/usr/local/opt/thrift/include -I../hazelcast/test/src -I../hazelcast/test/googletest/googletest/include -isystem /Users/yunus/.local/include -isystem hazelcast/test/googletest-src/googletest/include -isystem hazelcast/test/googletest-src/googletest -g -g -Wall -Werror -fsanitize=address -fno-omit-frame-pointer -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -std=gnu++11 -MD -MT hazelcast/test/src/CMakeFiles/clientTest_SHARED_64.dir/HazelcastTests1.cpp.o -MF hazelcast/test/src/CMakeFiles/clientTest_SHARED_64.dir/HazelcastTests1.cpp.o.d -o hazelcast/test/src/CMakeFiles/clientTest_SHARED_64.dir/HazelcastTests1.cpp.o -c ../hazelcast/test/src/HazelcastTests1.cpp
In file included from ../hazelcast/test/src/HazelcastTests1.cpp:16:
In file included from ../hazelcast/test/src/HazelcastServerFactory.h:28:
In file included from ../hazelcast/include/hazelcast/client/Address.h:19:
In file included from ../hazelcast/include/hazelcast/client/serialization/serialization.h:30:
../hazelcast/include/hazelcast/client/serialization/pimpl/DataOutput.h:235:42: error: loop variable 'item' is always a copy because the range of type 'const std::__1::vector<bool, std::__1::allocator<bool> >' does not return a reference [-Werror,-Wrange-loop-analysis]
                        for (auto const &item : value) {
                                         ^
../hazelcast/include/hazelcast/client/serialization/pimpl/DataOutput.h:258:21: note: in instantiation of function template specialization 'hazelcast::client::serialization::pimpl::DataOutput::write<std::__1::vector<bool, std::__1::allocator<bool> > >' requested here
                    write(*value);
                    ^
../hazelcast/test/src/HazelcastTests1.cpp:2851:32: note: in instantiation of function template specialization 'hazelcast::client::serialization::pimpl::DataOutput::write<std::__1::vector<bool, std::__1::allocator<bool> > >' requested here
                    dataOutput.write<std::vector<bool>>(&actualValues);
                               ^
../hazelcast/include/hazelcast/client/serialization/pimpl/DataOutput.h:235:30: note: use non-reference type 'std::__1::__bit_const_reference<std::__1::vector<bool, std::__1::allocator<bool> > >'
                        for (auto const &item : value) {

Linux test PASSed.

Windows test PASSed.

Linux test PASSed.

Windows test PASSed.


Remove related object edit option from radio select

Ref: https://code.djangoproject.com/ticket/34624
Before
Current situation: There is only one pencil and eye, and they are disabled.
Expected: A pencil and eye for each item, and enabled OR no pencils and eyes.
In the code I found the comment: # XXX: The UX does not support multiple selected values.. But radio select was not excluded. I went for the solution to remove the pencils and eyes to make radio select behave the same as multi-select.

After

I'd like to know if this approach is acceptable. If so, I'll update the PR with tests.

I'd like to know if this approach is acceptable. If so, I'll update the PR with tests.

Hello, thank you for your contribution! I took a quick look, and I'm not sure the proposal fixes the ticket. The goal for proposal 2 is to make the RelatedFieldWidgetWrapper to actually allow for editing/inspecting the selected item, not to remove the disabled buttons.
Did you consider/try to work towards that solution? Did you find any blocker?

In the Django tracker ticket the suggestion is made to remove the RadioSelect on the SitesAdmin. To me, that hides the issue, not solve it. So I initially set out to only enable the single pencil and eye. I've discovered some things:

The pencil/eye should probably be on each option, not only the last one.
The WidgetWrapper wraps the widget, not individual options.
The WidgetWrapper is never intended to work with multi-select. See the comment # XXX: The UX does not support multiple selected values..

I think, the original author(s) never intended to support a flat list of options. Maybe they just forgot to handle the radio select scenario? Maybe they just where not aware the JS also applies to radio selects?
With the knowledge I have now, I believe that enabling the single pencil and eye is not a solution. It does not make sense to be able to edit one option.
I think adding pencils and eyes to both multi-select and radio select is an valid option. But this is a big change. We can't reuse any of the current wrapper widget, JS, and tests. As we need to target individual options. This is way more work then I'd like to do.
Removing a broken pencil/eye seems a valid solution. If the multi-select was never supported, why would we implement this for radio selects?

Yes, I suggested to go for option 2.
In the Django tracker ticket the suggestion is made to remove the RadioSelect on the SitesAdmin. To me, that hides the issue, not solve it.

I agree!

So I initially set out to only enable the single pencil and eye. I've discovered some things:
1. The pencil/eye should probably be on each option, not only the last one.

I sort of agree. Arguably the edit/view option could be only on the selected row, right? That would be similar to the behavior for the select widget.

2. The WidgetWrapper wraps the widget, not individual options.

3. The WidgetWrapper is never intended to work with multi-select. See the comment `# XXX: The UX does not support multiple selected values.`.

Right, though please note that the radio select does not allow for multiple selected values.

I think, the original author(s) never intended to support a flat list of options. Maybe they just forgot to handle the radio select scenario? Maybe they just where not aware the JS also applies to radio selects?
With the knowledge I have now, I believe that enabling the single pencil and eye is not a solution. It does not make sense to be able to edit one option.
I think adding pencils and eyes to both multi-select options and radio select option is an valid solutions. But this is a lot of work. We can't reuse any of the current wrapper widget, JS, and tests. As we need to target individual options. This is way more work then I'd like to do.
Removing a broken pencil/eye seems a valid solution. If the multi-select was never supported, why would we implement this for radio selects?

Well, radio selects do not allow for a multi-selection of values, right? What do you think about enabling the edit and show actions only for the selected option?

@thibaudcolas Would you any anu advice from the usability POV?

I wonder: did the radio select widget ever had a working edit related object button? I took a dive.
Django 1.1.3 (May 17, 2010)
Is the oldest Django installable via PyPi.
It already had the add plus below the radio select.
No edit pencil.

Django 1.7.11 (Nov 24, 2015)
The last version with only the add plus.

Django 1.8 (Apr 1, 2015)
Introduces the edit pencil.
The pencil doesn't work.
Note, I selected the option.

Django 1.8.19 (Mar 6, 2018)
Some alignment issues.
The pencil still doesn't work.

Django 1.9 (Dec 2, 2015)
Icons appear behind the last option.
The pencil still doesn't work.

I also tried, Django 1.11, 2.2.28, 3.2, latest. Same story.
🤔

The pencil on radio select was dead on arrival.
The pencil on radio select never worked.
This might not be intentionally. Just a unnoticed side-effect of the pencil implementation? Maybe the authors never considered radio select?
You'd need to install django.contrib.redirects to encounter a radio select in the admin. This app is not enabled by default. Only this app specifies the radio select widget.
For admin users, there is little use for editing site objects when creating redirects. Site objects are probably created beforehand, and hardly ever change.
It seems uncommon to specify the radio select widget in the admin.
I can understand why there are no complaints about the broken pencil in decades.

Adding the pencil feature to radio select could be a nice addition to Django, but it is more work then I'd like to do. Especially because the JS implementation is how it is. And because it is a feature nobody uses.
So, I'm willing to push forward with the removal of the pencil. If another direction is desired, I'd leave it to others to do the work.
My main take-away: By removing the broken pencil from radio select, we remove something that never worked, and nobody misses.

👍 the rationale makes a lot of sense to me, particularly since as @allcaps mentions:

For admin users, there is little use for editing site objects when creating redirects

Thank you Thibaud for your advise! In order to push this forward, @allcaps we should add at least a test covering the changed logic. Would you have time to work on that? Thanks!

Closing due to inactivity. @allcaps please reopen if you find any time to work on this, thanks!

Reopening following conversations in #17418

Keeping you posted. I've took anther stab at this. Adding an item won't update the radio select list with the newly created option. So, I've got to give this some more time.

Keeping you posted. I've took anther stab at this. Adding an item won't update the radio select list with the newly created option. So, I've got to give this some more time.

Thank you for the update! No worries if you take your time.

Hello @allcaps, would you have time to keep working on this? If yes, could you please rebase onto latest main and fix tests? Thank you!

Closing due to inactivity.