Simplify eggspressions

This ~is a DRAFT of using~ uses egg to tackle #208.
TODO:

[x] Incorporate egg in a private module to do Expression::simplify
[x] Pass current test suite + more
[x] Handle the "(neg <number>)" edge case in simplification, not with if let Ok(number) = … workaround†
[x] Actual error handling, no panic! or expect!
[x] Documentation

†~I haven't figured out how to manage this one; any help from reviewers would be much appreciated.~ Fixed in d4f7fbf

Thanks, @kalzoo! Re:

I'd be interested in simple benchmarks to track performance. I'm not too worried about regression here but would be good to know, given how often it's invoked elsewhere.

What did you have in mind? A criterion bench with a randomly-generated-of-a-fixed-sized Expression to simplify?

Thanks, @kalzoo! Re:

I'd be interested in simple benchmarks to track performance. I'm not too worried about regression here but would be good to know, given how often it's invoked elsewhere.

What did you have in mind? A criterion bench with a randomly-generated-of-a-fixed-sized Expression to simplify?

That could work, so long as it's only randomly generated once and then committed - maybe a few of them for good measure. We'd want benchmark inputs to be static so that they can provide meaningful feedback to development.

Sure, it is a little funny to simplify via stringification,

This would be easier if egg exposed some of the internals of RecExpr, specifically parsing from Sexps. I think I'll steal this, actually, rather than rely on the stringification.

@kalzoo re: generating random expressions to benchmark simplifying, I've tried adding rand as a dependency and the following main.rs to generate a static file of them, but it looks like the Expression ⇒ String ⇒ Expression roundtrip doesn't quite work:
thread 'main' panicked at
'pi/cis(sin(sin(-%owlhhqxriv^cos(%mghfxnbixn)))) => error while parsing:
at line 1, column 28 (OPERATOR(^)): expected RParenthesis, found OPERATOR(^)', src/main.rs:83:23

main.rs
use quil_rs::{
    expression::{Expression, ExpressionFunction, InfixOperator, PrefixOperator},
    instruction::MemoryReference,
};
use rand::{rngs::StdRng, Rng, SeedableRng};
use std::{fs::File, io::Write, str::FromStr};

// rand::dists::Alphanumeric isn't what we need
fn rand_string(rng: &mut impl Rng) -> String {
    (0..10).map(|_| rng.gen_range('a'..'z')).collect()
}

fn rand_expr(rng: &mut impl Rng, max_depth: usize) -> Expression {
    if max_depth == 0 {
        Expression::PiConstant
    } else {
        match rng.gen_range(0..7) {
            0 => {
                let name = rand_string(rng);
                let index = rng.gen();
                Expression::Address(MemoryReference { name, index })
            }
            1 => {
                let function = match rng.gen_range(0..5) {
                    0 => ExpressionFunction::Cis,
                    1 => ExpressionFunction::Cosine,
                    2 => ExpressionFunction::Exponent,
                    3 => ExpressionFunction::Sine,
                    _ => ExpressionFunction::SquareRoot,
                };
                let expression = Box::new(rand_expr(rng, max_depth / 2));
                Expression::FunctionCall {
                    function,
                    expression,
                }
            }
            2 => {
                let left = Box::new(rand_expr(rng, max_depth / 2));
                let operator = match rng.gen_range(0..5) {
                    0 => InfixOperator::Caret,
                    1 => InfixOperator::Plus,
                    2 => InfixOperator::Minus,
                    3 => InfixOperator::Slash,
                    _ => InfixOperator::Star,
                };
                let right = Box::new(rand_expr(rng, max_depth / 2));
                Expression::Infix {
                    left,
                    operator,
                    right,
                }
            }
            3 => {
                let re = rng.gen::<f64>();
                let im = rng.gen::<f64>();
                Expression::Number(num_complex::Complex64 { re, im })
            }
            4 => Expression::PiConstant,
            5 => {
                let operator = if rng.gen() {
                    PrefixOperator::Plus
                } else {
                    PrefixOperator::Minus
                };
                let expression = Box::new(rand_expr(rng, max_depth / 2));
                Expression::Prefix {
                    operator,
                    expression,
                }
            }
            _ => Expression::Variable(rand_string(rng)),
        }
    }
}

fn main() {
    let mut rng = StdRng::seed_from_u64(8675309);
    let mut out = File::create("expressions.txt").expect("We should be able to create a file.");
    for _ in 0..1_000 {
        let expression = rand_expr(&mut rng, 256);
        match Expression::from_str(&expression.to_string()) {
            Ok(_) => write!(out, "{}", expression).expect("We should be able to write to the file"),
            Err(e) => panic!("{expression} => {e}"),
        }
    }
}

Further proptest play lead to another expression that fails to round trip: "cis(AA[0]^a0[428])"

Just merged in master in 7d9f1d5.

Adding because the two are intertwined:
Closes #215

The latest issue is a mix of operator precedence and formatting/parsing complex numbers. I think, essentially, that x^1-2i is supposed to be parsed as X ^ (1-2i), but is instead being parsed as (X^1) - (2i).

The latest issue is a mix of operator precedence and formatting/parsing complex numbers. I think, essentially, that x^1-2i is supposed to be parsed as X ^ (1-2i), but is instead being parsed as (X^1) - (2i).

This appears to be a bug in the parser. The Quil grammar specifies that ^/POWER is right-associative, so I think you are right that X ^ (1-2i) is the correct parsing

The latest issue is a mix of operator precedence and formatting/parsing complex numbers. I think, essentially, that x^1-2i is supposed to be parsed as X ^ (1-2i), but is instead being parsed as (X^1) - (2i).

This appears to be a bug in the parser. The Quil grammar specifies that ^/POWER is right-associative, so I think you are right that X ^ (1-2i) is the correct parsing

Thanks @Shadow53! With local testing, I may have moved past this to a different and new error, but I’ll write a more concrete test case when next at my computer.

Ok! This now passes all my local testing and is about where I think it should be. Pinging folks for re-reviews.
In order to get round-tripping to go (#215), I've added the fn parenthesized(expression: &Expression) -> String in the testing module. Unused elsewhere, but it ensures unambiguous behavior for our tests.

Even simpler now; I removed the ordered-float dependency that I originally added, plus made the custom Complex type just a wrapper for num_complex::Complex64 implementing the various traits we need.

good simplification in https://github.com/rigetti/quil-rs/pull/210/commits/c3f363f40c3be2572631db43b2c037197f3a87a6, @genos
can you catch up to main and then we can merge?

good simplification in c3f363f, @genos
can you catch up to main and then we can merge?

Thanks @kalzoo! Fixed merge conflicts with main, but the Deny task is still failing. It looks like proptest and criterion are pulling two different versions of regex_syntax. Any thoughts on fixing that?

Perhaps related: we still have Cargo.lock in our .gitignore, but it's in the repo.

the Deny task is still failing. It looks like proptest and criterion are pulling two different versions of regex_syntax. Any thoughts on fixing that?

I'm not too worried about that, both of the warnings are safely ignorable at the moment, even if they add noise to CI results. We can fix them off main.

Perhaps related: we still have Cargo.lock in our .gitignore, but it's in the repo.

Ah good point, can you rm that here?

🚨 Squashing and merging 🚨

🚨 Squashing and merging 🚨

Thanks for your great work on this @genos ! This is both more thorough and more maintainable than we would have made any simplification rules by hand. And now we're using egg in production!


Revert "Add randomized order of atomic writes and thread activations"

This reverts commit a2db612da472ba18c1d12e27ead711534eb3cd06 (#22).
It turns out that randomizing the full exploration is sub optimal with
regards to minimizing the exploration space.

Rolling this in with #28.


Element is not currently visible and may not be manipulated bug fix

In submitting the form, appearance (Element is not currently visible and may not be manipulated) error. Found to be caused by the page size. Would like to add the page size of the code in session.js years, as the initialization parameters.
page = _decorateNewWindow(require("webpage").create());
page.viewportSize = {width: 1024,height: 768};

1366x768 is the new default viewportSize.


Remove flag to not generate RSA keys automatically

Automatic generation of the RSA keys is not that useful, and make the verification of the wallet initialisation more complicated for no valid reasons. If the user wants to use RSA keys he backed up, he can simply overwrite the generated files.

Done in #142


Minor code cleanup: Remove references to BTE, XMLUI and JSPUI

Description
While finishing 7.0 Documentation, I stumbled on some remaining references to BTE, XMLUI and JSPUI within our codebase (mostly in comments).  This PR cleans those up (with one exception: org.dspace.app.util.SyndicationFeed still has variables for UI Type, but it is scheduled to be cleaned up as part of #2864 )
Cleans up the following:

Removes unused options related to BTE from "./dspace import" script
Removes mentions of BTE, XMLUI or JSPUI in any comments (including in config files)
Removes XMLUI or JSPUI based paths from test resources or example configs (e.g. OAI, RDF)
Deleted outdated docs on Importer Framework. These docs already exist on our Wiki and there's no need to maintain/update in two separate places.

Almost all these changes are comments. There are a few minor code changes, but they should be very easy to review.

Merging immediately with one approval (thanks @mwoodiupui)!


[forwardport] When initially adding a group to Istio access with Github auth enabled, the member type shows as 'group' instead of 'Organization'

Forwardport of rancher/rancher#23264.

Available in latest2

rancher/rancher:master-head a3677e35c
When adding a group to Istio access, it's type is Organization.


[BUG] Concise Description of the Issue

Is it possible to manually add devices? I have all my devices on a separate vlan, thus auto discovery won't work unless I manually add the devices IP address.

This feature is not within the scope of the plugin. The plugin does search on all available subnets.  If that doesn't work on your system then you may have to move your devices off the vlan or use tom's MagicHome plugin. I believe his allows manual configuration.


FFI refactoring to support client-detected network changes

Chatting with @thomaseizinger to optimize reconnects, we can improve reliability and simplify state management in the clients with some refactoring around how we handle state:

[ ] Add a new command (in addition to Session.connect and Session.disconnect) the clients can call from the app side: update(dns: [String], internet?: boolean) that is called whenever the OS detects a network interface change
[ ] Collapse all of the onTunnelReady onSetInterfaceConfig etc states into a single onTunnelStateChange(state: ...) callback that passes the tunnel state, including whether it's "connecting", "reconnecting", or "disconnected".

With the changes above, connlib now manages tunnel state. When it receives a "command" (connect/disconnect/update) it reacts accordingly and then passes the state object back to the app. The app can then update UI and its state accordingly.

Session.connect(...): Long
Session.update(dns: [String]): Long
Session.disconnect(): Long
onTunnelStateChange(state: struct): Int?

Scenarios to handle (can happen in any order at any frequency)

Peer network partition
Portal network partition
Client network changes (DNS, interface address, etc)

With the changes above, connlib now manages tunnel state. When it receives a "command" (connect/disconnect/update) it reacts accordingly and then passes the state object back to the app. The app can then update UI and its state accordingly.

Disclaimer: I've not looked at the client code much so take this with a grain of salt :blush:
What I'd like to add here is that the clients should code their UI as a pure function of the state returned by connlib very much like MVC with the following "mapping":

model == connlib
controller == FFI-handle to connlib
view == state returned from connlib

This would have the advantage that the clients don't need to keep additional state but can "just" render something based on what connlib returns. Consequences of this design are:

connlib becomes more like a kind of daemon or server that runs in the background.
connlib will have to "debounce" incoming commands and not be too eager / naive in how it applies them. For example, connlib should take the message from the clients in regards to network changes as mere "hints" because they can be quite spammy. @jamilbk and I tested this on the MacOS client and it flips back and forth between "connected" and "disconnected" as MacOS is switching over the traffic from e.g. Ethernet to WiFi. Tearing down the entire tunnel because of this would not be a good user experience.
connlib will have to start sharing more state updates as it is doing things. Instead of just saying "connected" and "disconnected", we should also send updates such as "we have connectivity issues" when we e.g. detect that keep-alives are not longer coming through or when we perform an ICE restart. Otherwise the clients cannot render an appropriate UI.

I thought some more about this and what impact it may have. I realized that using this pattern, we can also solve a lot of awkwardness around device initialization on the various platforms:

The callbacks for on_add_route and on_remove_route will go away with the design mentioned in this issue. Instead, issuing a state update to the clients will have the list of routes that we want. It is a client's responsibility to "make that happen".
With those callbacks removed, the Android client will not be able to return a new file descriptor from those functions. Instead, we can add a new FFI command: set_device_file_descriptor. Similar to disconnect, that is a function that the Android client can call on the Session.
Whenever the Android client receives a state update and detects that the list of routes has changed, it can invoke Session::set_device_file_descriptor to set the new FD.

This greatly simplifies the control-flow in connlib because we only need to initialize a new device based on an FD. In fact, that API can be cfg(android)^1 because it will only be called from the crate that bridges the Android client code with connlib.

list of routes does sound nice. Then the only diffing is in the client, or they could blow up the routing and re-do it as a simpler implementation. Adding 1 route takes less than 1 ms on my laptop

We can table the major refactoring for later, but the primary point of this issue is to handle client-detected network changes and propagate this to connlib to react appropriately.

After chatting more with @conectado just now, we devised the minimum set of changes required to get network updates working reliably across all clients:

Add a Session.update(dnsServers: [String]) command call. This will only be called during an active connlib Session. This is called when:

A client's network settings has changed
The new network settings have different DNS servers than the old settings

Remove the get_system_default_resolvers() callback on all clients. This is no longer needed with the change above.
On the Linux client, where there is no API to receive network change events, we can just poll every 5 seconds for DNS default resolver changes, and issue the Session.update then.
Each client should be able to handle multiple onSetInterfaceConfig and then onTunnelReady calls during the lifetime of the Session. These will be called by connlib in response to the Session.update command, similar to how it already responds to Session.connect. This means that the period of time between Session.update and onTunnelReady, the client's UI state should show the tunnel in Connecting or Reconnecting state.

I'll take a stab at knocking out the Apple and Android side of this. @ReactorScram -- when that's done, it can be used as an example implementation to replicate for the Windows and Linux clients.
@conectado will be starting on the connlib side to handle this within a few days.

Closing due to discussion being settled on 3/12

#3429


Fix HTTP 500 when topic specified for private message edit.

The assert statements still remain for readability, but I've moved the data validation logic toghether.
Testing: Added automated tests.
Fixes: #18604

@PIG208 what are your thoughts on this refactor?  It undoes some of what we'd merged in preparation for https://github.com/zulip/zulip/pull/17927, but it might be simple enough to just call the new validation function as well?

I think this is a clean refactor.
But I don't think it's necessary to extract part of the validation out log check_update_message. Perhaps we can instead have check_update_message calling the new validation function.

Yeah, having check_update_message call the new function might be cleanest, so it's callers don't have to worry about it.

@PIG208 @timabbott This is ready for another review. check_update_message now calls the new validation function, so this builds on top of 7150fe5dc5bedac5c337ea542264df9398cbf637 instead of undoing it 🙂
I also added a doc-string for the new function as suggested in https://github.com/zulip/zulip/pull/18606#discussion_r640019799

I merged this after addressing the potential bug noted above.
I think we probably should be able to delete that bit in a further cleanup, depending how we do the embedded bots / outgoing webhooks implementations of message editing.
(Another idea is perhaps we should just be doing truncate_topic + stripping earlier rather than having multiple phases here).


SM-T533 "Protocol initialisation failed"

Hi, thanks much for this software,
Mac OSX (10.8.5) here.
Yesterday I've compiled heimdall and heimdall-frontend from master and tried downloading the SM-T533's pit file, but I still get an error (heimdall-frontend output right below).
Initialising connection...
Detecting device...
Claiming interface...
Setting up interface...

Initialising protocol...
ERROR: Protocol initialisation failed!

Releasing device interface...

Any help would be appreciated.
And if you need more infos, I'll be glad to provide.
For now I've used Odin in a VM to do the task at hand.

Please provide --verbose --usb-log-level debug output in a gist.

Here you are:
sm-t533 heimdall error
I should add that the error I got for debugging is not the same as the one I initially reported.

That's a different error than you got last time. I suggest you try a different USB port and/or cable.

i tried with every usb port I had available, which amounts to 2, and the cable is a stock, brand new one from samsung. I also tried with a camera usb cable, and got the same error.


Automated cherry pick of #1551: add without_user_meta filter

Cherry pick of #1551 on release/2.10.0.
#1551: add without_user_meta filter

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@631ea33). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release/2.10.0   #1560   +/-   ##
================================================
  Coverage                  ?   7.71%
================================================
  Files                     ?     409
  Lines                     ?   62272
  Branches                  ?       0
================================================
  Hits                      ?    4804
  Misses                    ?   57058
  Partials                  ?     410

Flag
Coverage Δ

#aFlag
7.71% <0%> (?)

Impacted Files
Coverage Δ

pkg/mcclient/options/servers.go
0% <ø> (ø)

pkg/cloudcommon/db/metadata.go
11.76% <0%> (ø)

pkg/cloudcommon/db/standalone.go
0.92% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 631ea33...50ba836. Read the comment docs.

/lgtm
/approve


Loading from attributes & other perf related things

Renamed branch to have a consistent branch naming across repos for release build.


Image upload error redux

This should make the errors appear in our redux logger. Also cleaned up redux to get rid of unused code.

ah, nice cleanup. last time i went into that list of methods i cringed a bit.


Consider converting all Linode ips into an object mapping ip to object

Also add type information (public ipv4, global ipv6, etc) that would be lost in the conversion.

Found a way around this with my updateIP helper function. No longer needed.


Use ramda's always() in favor of manually creating provider function

In https://github.com/Comandeer/hello-world/blob/fa35c8cb56d7835d10bb2c3343643b611834311a/src/index.js#L1-L3, we manually create a function returning a constant value, which would lead to code duplication if we add another function, for example to say goodbye.
Description of proposed changes:

This PR introduces usage of ramda's R.always(), which returns a function always returning the given value.

Actually I don't want any dependencies for this super simple repository as it's intended to be just a simple example of how BEMQuery boilerplate could be used.
Additionally I honestly think that using rambda instead of "pure" JS is not increasing readability or easen the maintenance of the code.


Improve app start log

This is confusing. People open wrong port.

Telling user hot reload server is not necessary. Or, since hot reload server is "Hot server", refer to app server as "App server". "Hot server" is not a good name anyway...

What about this:
App server with hot reload started
Api is available at http://localhost:8000/api/v1
App is available at http://localhost:8000

We over at react-boilerplate have gotten positive comments for our logging repeatedly. YMMV, but this is what we log when you start the application:

This is the relevant code: https://github.com/mxstbr/react-boilerplate/blob/master/server/logger.js#L27-L35
Hope that helps a bit!

Okay so what I want:

local testing: localhost:port#
LAN testing: LANIP:port#
API path
Tunnel URI (optional)
Exit command

Maybe even a QR code for mobile testing :laughing:

Maybe even a QR code for mobile testing 😆

Well, this exists… https://github.com/gtanner/qrcode-terminal

It's... maybe a bit too big for our purpose? considering default window sizes for popular terminal emulators. I guess a commandline option for it and another line after exit command to document. (feature creep XD)

While I find the QR code to be a really nice idea, I think like @louy2.
A easy way to handle such features is by writing some recipes (like "if you want this, add this line here in this file and install this package").
My take on how we could happily deal with #854 too ;)

@louy2 Wanna help open source with that?


Remove unsupported jf build step from freestyle projects

[x] This pull request is created in the jfrog/jenkins-jfrog-plugin repository.

jf commands as a freestyle build step is not supported.
Remove to avoid confusion.

This is causing the multi-branch pipeline to crash.
Need to fix this.

was fixed due https://github.com/jfrog/jenkins-jfrog-plugin/pull/113


add rel='noopener noreferrer' in links

Added rel='noopener noreferrer' in HTML links as best practice to avoid any vulnerabilities.
More info: https://cheatsheetseries.owasp.org/cheatsheets/HTML5_Security_Cheat_Sheet.html#tabnabbing

hey I don't think you need this for links that have target='_blank' as it opens a net new page...?

hey I don't think you need this for links that have target='_blank' as it opens a net new page...?

This works only when you have target=’_blank’ and new page that opens in new tab could be used to change content on main page.
This is a proof of concept although vulnerable page has target='_blank' rel='opener' in this case:
vulnerable.html:
<!DOCTYPE html>

Victim Site

<a href="http://<IP_ADDRESS>:8000/malicious.html" target="_blank" rel="opener">Controlled by the attacker

malicious.html:
<!DOCTYPE html>

malicious_redir.html:
<!DOCTYPE html>

New Malicious Site

Create the following pages in a folder and run a web server with python3 -m http.server. Then, access http://<IP_ADDRESS>:8000/vulnerable.html, click on the link and note how the original website URL changes.
If you remove the rel="opener" attribute, the default behavior will depend on the browser. In some cases, the new browsing context will still be considered related to the original one, while in others it may not. So the best practice to avoid vulnerability is to add rel="noopener noreferrer".
rel="noopener" prevents the new page from being able to access the window.opener property and ensures it runs in a separate process. rel="noreferrer" has the same effect but also prevents the Referer header from being sent to the new page.

https://user-images.githubusercontent.com/94559964/210490940-04b1b030-c4cf-4457-af56-b5fb9d53b692.mp4

ACK - Code changes reviewed. Please accept PR.
Basically these keywords prevent the browser from passing info from the page a user is navigating from to the new tab they opened about where it was opened from. Not just that, but if the site is malicious, it has access to Astral's window object, meaning potentially stolen keys from window.localStorage.keys and access to window.nostr if they are using a browser extension to manage keys. If I am wrong about access to localStorage, there is definitely access to window.location which opens the user to a phishing attack of a site that looks like Astral saying "oops, something went wrong, please paste in your private key again".
While this was fixed in a spec change in 2018 so that modern browsers only pass this info on when a link specifies the opener keyword, you should not assume that all users have updated browsers and you should ALWAYS include them with target="_blank" for user privacy and security.
See MDN noreferrer & MDN noopener. Here is another explainer.

ok thank you for explaining this to me more in depth. and thanks for the pr @1440000bytes


Breadcrumb section dark mode only?

Steps to reproduce
Link to live example: (required)
https://mui.com/material-ui/react-breadcrumbs/
Steps:
1.
2.
3.
Current behavior
switching alone to dark mode and no possibility to switch that unless use chrome extension
Expected behavior
like the rest of the website light and dark mode
Context
I was reading navigation section documentations
Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: UI Bug

Can you provide screenshots of what you see? How are you switching to dark mode? Are you using the settings panel?

@mnajdova maybe I got the same bug here:
https://github.com/user-attachments/assets/92b48ff7-ec4f-4505-8897-4dd9b1dea8a7

I'm seeing this as well. Haven't noticed this happening on any other page.

Wait, now that page is working fine for me.


sls logs not working for packaged actions

I used sls logs command to successfully monitor my ibm cloud functions.
However, when I packaged the action using name attribute and my own package defined in resources. I cannot seem to be able to access the logs using this command.
The command sls logs -tf myfunc does not give any error (like it does when you give it a action name that does not exist) but it does not show any log output either.

Hello @arpin.
Can you paste me your serverless.yml? I'll ensure I reproduce the issue properly and then can fix it in the next release.

Here. It works if I comment out name: testpack/hello.
service: hellotest

provider:
  name: openwhisk

functions:
  hello:
    handler: src/hello.hello
    name: testpack/hello
    events:
      - http: GET /hello

plugins:
  - serverless-openwhisk

resources:
  packages:
    testpack:
      parameters:
        hello: world


bind vs bind-value

Instructions use bind, but apparently that's been changed and now must be "bind-value"

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 23f2cad2-31f9-d5d1-671c-5613fb812b19
Version Independent ID: 23f2cad2-31f9-d5d1-671c-5613fb812b19
Content: Build a Blazor todo list app
Content Source: aspnetcore/blazor/tutorials/build-a-blazor-app.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @JTNichols ... I'm not sure how you reached that conclusion. It's not correct. Please provide additional information if you ran into an error, and I'll re-open or refer you to the product unit for support, if needed.

Following the directions on a blazor webassembly app, this works:
<InputCheckbox @bind-Value="todo.IsDone" />
<InputText @bind-Value="todo.Title" />
This doesn't:
<InputCheckbox @bind="todo.IsDone" />
<InputText @bind="todo.Title" />

The tutorial doesn't have you use a InputCheckbox. It merely directs you to use <input> elements that are bound to those properties.
The InputCheckbox is covered at ...
https://learn.microsoft.com/aspnet/core/blazor/forms-and-input-components
... and there you will see that for the built-in forms components @bind-Value is described and shown.


add highwayhash + test

Add highwayhash package w/ commit taken from tensorflow
https://github.com/tensorflow/tensorflow/blob/7f84d88d39f236e5c0cea492a2248782e696c972/tensorflow/contrib/cmake/external/highwayhash.cmake#L18-L19
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/cmake/external/highwayhash.cmake
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/cmake/patches/highwayhash/CMakeLists.txt

Testing:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.2711
https://travis-ci.org/ingenue/hunter/builds/299725874?utm_source=github_status&utm_medium=notification

Uploading:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.2722
https://travis-ci.org/ingenue/hunter/builds/299895979?utm_source=github_status&utm_medium=notification

Thanks

Follow-up: https://github.com/ruslo/hunter/commit/38a255d5b5db1af8d10d558fc10b8e2238263e43
Released: https://github.com/ruslo/hunter/releases/tag/v0.19.145


Fileserver GUI - Progress Bar

No progress bar status when upload by Filserver GUI.

could you be more specific on what works and what not..screenshots e.g.


Visualization Lectures

Only covering matplotlib and cartopy. I think holoviews is a different level from matplotlib and it doesn't make much sense to have them in the same lecture.

The test failed but not because of a file I changed.

@jukent,
Just checking ... are these notebooks ready or are you still working on them?

They are ready!


Add language toggler

This PR adds a language toggler that can accommodate > 2 languages

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign lucperkins
You can assign the PR to them by writing /assign @lucperkins in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Is the style of the dropdown item (and its text) what we want?
It is different from the one used by the header menu items.

Same on mobile devices.

/hold

I can improve it later but let’s just merge this now so we can get the Japanese translation published:

/hold cancel
Gotcha, agree!
On Tue, 24 Mar 2020 at 00:21, Luc Perkins<EMAIL_ADDRESS>wrote:

I can improve it later but let’s just merge this now so we can get the
Japanese translation published:
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/falcosecurity/falco-website/pull/173#issuecomment-602910737,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA5J4ZWKRIT2XDVQWHWQMDRI7VHJANCNFSM4LSBI4JQ
.

--
L.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 996507e6b86c085f0731c0da07d8ec9a89452746


Can't fetch Pull Requests

I finished setting up the extension and connecting it to github, but sadly it can't fetch any PRs:
It fails with:
[Info] GitHubRepository> Fetching all pull requests failed: Only absolute URLs are supported

Can anybody give me a hint what I can do here? The error message is not that descriptive...

@jacksbox Hmm, this looks like a node fetch error. This is with the latest version of the extension (0.6.0)? Are you using GitHub enterprise? Can you try changing the githubPullRequests.logLevel setting to debug/check the dev console by running the Developer: Toggle Developer Tools command?

@RMacfarlane  I'm using the version 0.6.0, after setting the logLevel to debug, the output is
[Debug 12350s 274ms] Looking for git repository
[Debug 12350s 274ms] Git repository found, initializing review manager and pr tree view.
[Debug 12350s 277ms] PullRequestManager> update repositories
[Debug 12350s 278ms] PullRequestManager> Displaying origin remote
[Debug 12350s 433ms] Found GitHub remote

there isn't any new output when I click on refresh in the GitHubPullRequest Section (neither in the integrated output console, nor in the Developer Tools).

Is there anything special about your network configuration? What OS is this on?

macOS 10.14.3, no special network configuration.
I tried unintall and reinstall the extension, and the output changed slightly.
[Debug 154897s 843ms] Looking for git repository
[Debug 154897s 843ms] Git repository found, initializing review manager and pr tree view.
[Debug 154897s 846ms] PullRequestManager> update repositories
[Debug 154897s 849ms] PullRequestManager> Displaying all github remotes
[Debug 154897s 849ms] PullRequestGitHelper> Get user created remotes - start
[Debug 154898s 299ms] PullRequestGitHelper> Get user created remotes - end
[Debug 154898s 313ms] No GitHub remotes found
[Debug 154898s 330ms] Review> no matching pull request metadata found for current branch SAEFRNT-275_interactive-rating-form
[Debug 154898s 330ms] PullRequestManager> update repositories
[Debug 154898s 331ms] PullRequestManager> Displaying origin remote
[Debug 154898s 376ms] Found GitHub remote

If I click the + button in the PullRequest panel, following error shows up in the dev tools.
[[object Object]]<file> has no GitHub remotes

Maybe as further information, the normal git commit, pull, push integration works perfectly.

@jacksbox Does this reproduce with the newest version of the extension, 0.7.0? (Note that it requires the latest VS Code, 1.34.0)

jep, still the same behaviour

oh, I figured it out 😄
using GitHub Pull Requests: Sign out of GitHub and GitHub Pull Requests: Sign in to GitHub with some window reloads worked.
Guess I could have done that earlier, but the debug messages did not hint in this direction... also the Source Control tab worked normally.

I still have this issue with Mac OS 10.13.6 and GHE 2.15 Fetching all pull requests failed: HttpError: Only absolute URLs are supported

I am having the same issue. Mac OS 10.14.6 + GHE 2.18.1. Github Pull Request Extension is in the 0.11.2 version.
Fetching pull requests failed: Only absolute URLs are supported

Auth has changed, so closing as fixed. If you're still seeing this please feel free to ping this issue.


LESYMAP Compilation Failure (Mac OS 10.15.6, R version 4.0.3)

I keep getting the error below when I try to compile LESYMAP from GitHub. I've tried all three methods to no avail. Compliation of ANTsR, ANTsRCore and ITKR work fine.
In file included from /Library/Frameworks/R.framework/Versions/4.0/Resources/library/RcppArmadillo/include/armadillo:21: /Library/Frameworks/R.framework/Versions/4.0/Resources/library/RcppArmadillo/include/armadillo_bits/compiler_check.hpp:50:4: error: "*** C++11 compiler required; enable C++11 mode in your compiler, or use an earlier version of Armadillo"   #error "*** C++11 compiler required; enable C++11 mode in your compiler, or use an earlier version of Armadillo"
I believe the issue is that this command
clang++ -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.0/Resources/library/Rcpp/include' -I'/Library/Frameworks/R.framework/Versions/4.0/Resources/library/RcppArmadillo/include' -I/usr/local/include   -fPIC  -Wall -g -O2  -c BMfast.cpp -o BMfast.o
needs to start with clang ++ -std=c++11 but I don't know how to do that
Any help would be very appreciated! Thank you

This is not something I am familiar with  because I am not a Mac user. But from what I see online, RcppArmadillow just changed the minimum requirements to C++11, see here. You are also using R version 4, which is not brand new but I am not sure if it has something to do with it.
The first thing to try is the instructions on how to set up RcppArmadillo here. These probably refer to the same issue you are encountering, and is also mentioned in the issues RcppArmadillo itself.
Then, I see three other potential solutions:

Get Lesymap locally, and edit src/Makevars to add the std flag you mention, as shown here. Then do the manual local installation with R CMD INSTALL LESYMAP from the parent folder.
Uninstall RcppArmadillo and install an older version that does not have the C11 requirement.
Try installing an an older R like v3.6.X rather than the R v4.X.

Hopefully the very first instructions will have the help you need.
Let me know if you manage to fix it, and how.

YES!!!!!!
I went with 1.
Downloaded the master from GitHub and edited MakeVars. Then used devtool install_local in R and pointed to the local directory. Ran into one more issue later in the compilation where I was missing gfortran but that was an easy fix. Thanks a ton


ledgerjs-hw-app-sui not compiling in pnpm

Steps to Reproduce Issue
An error occurs when executing pnpm wallet start because ledgerjs-hw-app-sui is not included in package.json.
https://github.com/MystenLabs/sui/blob/main/package.json
Expected Result
Add the following line to package.json to link ledgerjs-hw-app-sui.
    "ledgerjs-hw-app-sui": "pnpm --filter ./sdk/ledgerjs-hw-app-sui",

Actual Result
  TS2307: Cannot find module '@mysten/ledgerjs-hw-app-sui' or its corresponding type declarations.

System Information

OS: Mac 13.2.1
Compiler: pnpm 7.26.0

Resolved this issue on main


CMS fix the indexes - row numbers

we need to pull the changes on hati repository after fixing it

This was a bug on hati afterall.


Run in browser

please make it that the main function gets executed automatically and the result been show in the browser
export function main():int{
    return fib(42);
}

Yes, I will plan to implement this, as well as saving and import gists from github. But unfortunately I'm pretty busy right now on other commercial projects


SOC calculated incorrectly with multiple batteries

Describe the bug
If multiple batteries with different capacities are configured in the system, it's impossible to calculate the real overall SOC.
Currently it's calculated as the average SOC over all batteries, which is only correct if all batteries have the same capacity,
See calculation of variable socs in function sitePower() in core/site.go
Example:
Battery 1, capacity 10kWh, SOC 10%
Battery 2, capacity 30kWh, SOC 20%
Resulting SOC on UI: 15%, Real SOC: (1+6)/(10+20) = 23,3%
Possible solution:

Add parameter "Capacity" to Battery meters and extend battery API accordingly
Calculate correct SOC using the actual capacities

Steps to reproduce

Configure a system with 2 batteries and different SOC
Check SOC on the UI. It will show the average SOC.

Configuration details
meters:
- type: template
  template: e3dc
  usage: battery
  host: s10
  port: 502
  name: battery1
- type: template
  template: victron-energy
  usage: battery
  host: multiplus
  port: 502
  name: battery2

Log details
n/a

What type of operating system are you running?
Linux
Version
evcc version 0.109.2

This is by design to keep it simple.

I see. It's simpler indeed.
However, showing a wrong SOC is not nice and using this wrong value with parameters like bufferSoC and prioritySoC makes these kind of useless, or at least sketchy in such a scenario.

How do you control that your batteries charge and discarge with power exactly linear to their capacity ?
The whole SoC thing is a huge guess and because of this and because the cases where multiple batteries at all or even multiple batteries with different capacities used are more than rare and there is only one SoC display we decided to keep it as simple as possible.
Maybe https://github.com/evcc-io/evcc/pull/5497 will help you?
Even if we would provide an capacity input option for the users users would tend to enter wrong (to nice) values from marketing etc. It's the same with the vehicle batteries where we have this config option to set a startup value (just) for estimator initialization.

How do you control that your batteries charge and discarge with power exactly linear to their capacity ?

The battery controller (a BMS or ESS system) gives me a SoC. This SoC is per definition related to the remaining capacity, since it's simply RemainingCapacity/TotalCapacity * 100
A good battery controller is able to count the energy going into and out of the battery, so the SoC is quite accurate.
(But I agree that in many cases it is not)

The whole SoC thing is a huge guess

I'd say that depends. Using values from a cheap BMS is probably worse than guessing, but e.g. a Victron SmartShunt is quite accurate.

and because of this and because the cases where multiple batteries at all or even multiple batteries with different capacities used are more than rare

Ok, that's probably true

and there is only one SoC display we decided to keep it as simple as possible.

Here I strongly disagree. If multiple batteries are supported, the functionaly should work correctly, at least in theory.
The input possibly being wrong, is no excuse for adding another layer of "wrongness".
Especially if the result of the calcualtion is itself an input for another functionality.

Maybe #5497 will help you?

Thanks for the hint. My problem is not so much the display, it's the bufferSoC and prioritySoC  not working correctly due to the wrong calculation. I know the individual data quite well and don't use evcc as a data source for the batteries.

Even if we would provide an capacity input option for the users users would tend to enter wrong (to nice) values from marketing etc. It's the same with the vehicle batteries where we have this config option to set a startup value (just) for estimator initialization.

It might happen, agreed. But then it's the user's responsibility. However, the current implementation does not even allow me, as an informed user, to achieve the correct result, which is my whole point.
And I guess you shouldn't underestimate your users. Probably most of them are enthusiasts in the one or other way who know quite a lot about their systems. Regarding car batteries, it's indeed often unclear what the capacity really is, but for PV-Batteries this can be different.
However, to shorten the discussion (which I appreciate, by the way)
Would a fix to this be accepted or shouldn't I bother, because the design decision would lead to a rejection of a respective pull request anyway?

I like the idea to have an optional parameter capacity like we have it in the cars. at the end it is the same without wheels :-)

Agreed this can be improved, but not a priority. Happy to look at a PR.

Agreed this can be improved, but not a priority. Happy to look at a PR.

Hey Andi,
magst du mir mal 1 bis 2 einstiegspunkte nennen? Dann gucke ich mir das mal an.
Ich habe eine Victron Battery am laufen und würde mich durch den "schönen" go sourcecode hangeln.
In der Theorie müsste das ja sehr einfach gehen, wenn man nicht gerade C++ verliebt ist.

We would need something like:

api.Battery, maybe api.BatteryCapacity
this needs be (optional) part of all meters, maybe similar to vehicle.embed (embed.go)
then site.go would look if api.BatteryCapacity is available and- if yes- use those values for better calculation results

Just an idea, depends more insights when prototyping.


Snapshots are different between different systems

Hi,
I tried to make a snapshot of a bigger part, about 300x200 pixels big. On both, the development system and CI systems (both Windows), the size differs. So I made a snapshot of a smaller part (about 44x36 pixels) and disabled scaling:     compareSnapshotCommand({ scale: false });. Now the size is equal but the snapshot taken at our CI server shows some pixels (about 7%) that are not equal to the snapshot taken on my development machine.
an example:

Do you know if this is normal and forces us to use always a higher threshold than 0.0?

This is normal. Different versions of the same OS can render fonts differently. I'm surprised that the tests are failing though, since https://github.com/mapbox/pixelmatch has anti-aliasing detection on by default: https://github.com/mapbox/pixelmatch/blob/38b395747e583e6932a13f80d17d4cb7a606c742/index.js#L7
https://github.com/mapbox/pixelmatch/issues/57
If you'd like me to take a look at it, I'll need to be able to recreate the issue. Want to create a PR with a test that highlights the issue?

@mjhea0  I will try to create a test for this if I find some time. Until then I use a threshold of 20%

one solution could be to run cypress headless inside a docker container, same approach as https://loki.js.org/

one solution could be to run cypress headless inside a docker container, same approach as https://loki.js.org/

Do you mean for both generating the base snapshots and generating actuals?  This is what I'm thinking of doing now.  Running into the same issue where macbook generated base images aren't matched when the cypress tests run in CI.

Yeah, that's how I currently do it to prevent this sort of thing.  The tests are ran out of a docker container so you could mimic how I set up my tests / project.
Going forward, I wonder if I detail how to do this easier and warn people about snaptshot diffs being different on different systems in the README?

@mjhea0 that would be very helpful. I don't know exactly how I use Cypress in Docker with my local create-creact-app project.

Coming back to this...  I ended up implementing the same.  If somebody on the team wants to run visual snapshots locally, that needs to be run inside docker. We have a shell script for local docker cypress test run and a separate one for retaking the snapshots using cypress in docker.  The script to retake snapshots has the path to the snapshots folder mounted as a volume.
Otherwise tests are run locally outside of docker.

@JonFranchi would you be able to share scripts? This is the exact setup I need.

Closing due to lack of activity.... feel free to reopen


Modals with dimmer: false throw an exception in 0.78.3

Steps

Add modal with these props:

  dimmer: false

Expected Result
No exception will be thrown when the modal is shown.
Actual Result
An exception is thrown, likely due to the changes made in #2407 (the exception happens after upgrading to 0.78.3):
Uncaught DOMException: Failed to execute 'add' on 'DOMTokenList': The token provided ('function wrapper() {
    var length = arguments.length,
        args = Array(length),
        index = length;

    while (index--) {
      args[index] = arguments[index];
    }
    if (isCurried) {
      var placeholder = getHolder(wrapper),
          holdersCount = countHolders(args, placeholder);
    }
    if (partials) {
      args = composeArgs(args, partials, holders, isCurried);
    }
    if (partialsRight) {
      args = composeArgsRight(args, partialsRight, holdersRight, isCurried);
    }
    length -= holdersCount;
    if (isCurried && length < arity) {
      var newHolders = replaceHolders(args, placeholder);
      return createRecurry(
        func, bitmask, createHybrid, wrapper.placeholder, thisArg,
        args, newHolders, argPos, ary, arity - length
      );
    }
    var thisBinding = isBind ? thisArg : this,
        fn = isBindKey ? thisBinding[func] : func;

    length = args.length;
    if (argPos) {
      args = reorder(args, argPos);
    } else if (isFlip && length > 1) {
      args.reverse();
    }
    if (isAry && ary < length) {
      args.length = ary;
    }
    if (this && this !== root && this instanceof wrapper) {
      fn = Ctor || createCtor(fn);
    }
    return fn.apply(thisBinding, args);
  }') contains HTML space characters, which are not valid in tokens.
    at eval (webpack-internal:///../../node_modules/semantic-ui-react/dist/es/addons/MountNode/lib/handleClassNamesChange.js:26:27)
    at arrayEach (webpack-internal:///1165:15:9)
    at forEach (webpack-internal:///418:38:10)
    at handleClassNamesChange (webpack-internal:///../../node_modules/semantic-ui-react/dist/es/addons/MountNode/lib/handleClassNamesChange.js:25:56)
    at NodeRegistry.emit (webpack-internal:///../../node_modules/semantic-ui-react/dist/es/addons/MountNode/lib/NodeRegistry.js:36:5)
    at MountNode.componentWillMount (webpack-internal:///../../node_modules/semantic-ui-react/dist/es/addons/MountNode/MountNode.js:61:22)
    at callComponentWillMount (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:6370:14)
    at mountClassInstance (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:6435:7)
    at updateClassComponent (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:7840:9)
    at beginWork (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:8225:16)

Version
0.78.3
Testcase
(will add a pen later today when I get time)
(cc @mbestwick)

Unable to reproduce, see codesandbox.
Please add a repro case and I'll reopen issue.

@layershifter apologies, i just tried creating a repro in the sandbox using the exact <Modal> invocation we're using but was unable to reproduce the issue; adding dimmer={false} back to our app brings back the exception though... i guess this means it's a more complex interaction than i thought; possibly due to a containing element or some other library :(

I've found the issue on my side - @beaugunderson I would advice to check if you used LodashModuleReplacementPlugin. In my case this was plugin that broke something for split import of lodash/fp

@bytasv ah, thank you! we do use LodashModuleReplacementPlugin and have encountered issues like this from time to time, usually fixed by enabling whichever flag in LodashModuleReplacementPlugin fixes it... but since this is the third or fourth time this plugin has broken something maybe it's time for us to get rid of it :)


Correlation and indexing vectors when evaluating objective functions

Is your improvement request related to a problem? Please describe.
When optimizing model with cyclical output, such as rockdrills, it is often useful to time-shift signals before comparing / matching. For example if I want to calculate an objective function based on the similarity of two piston location vectors. This could be done using Matlab etc by locating the time shfit using correlation, and then index the vectors appropriately. An (currently unsolvable?) issue arises when one wants to include such time shifts in an optimization in Hopsan.
Describe the solution you'd like
Either HCOM functionality to enable indexing of vectors, generating new vector based on indeces (such as A= B[10342:82739]). Or possibly by re-enabling the Python scripting environment, which I believe had such capabilities?
Describe alternatives you've considered
Currently, my best option is to add a time-shift parameter as an optimization parameter, letting it move the compared generation using a lookup table, and hoping for the best that Hopsan finds a good time shift value. This is much more computationally heavy than simply matching the signals before obj-function evaluation, and complicates the optimization.
Additional context

I think we can add both a subvector function and a time shift function to HCOM. Perhaps subvec(vector, start, end) and tshift(vector, dt)?

If possible, stealing some well known syntaxt would be nice. Such as matlab A(13:25) or numpy B[13:25].
But I'm guessing that's much more work to implement?

Hmm, for time shifting, I think that this should already work, in plots you can add time shifts, that then affect all plot variables using that time vector in the same generation. But maybe its not possible to do so from HCOM, or maybe it only affects the plots.
The following (needlessly complicated) command would shift the time vector by 5, for all time-domain variables with that particular Time variable. But I am not sure if that what was desired, or only to shift time for one particular variable ?
Time = Time + ones(size(Time)) * 5
@robbr48 oddly, the expression Time = Time + 5 * ones(size(Time)) does not evaluate. Did not debug, maybe a Symhop thing?

Implementing new operators such as () and [] will take some time, parenthesis are used in functions so brackets would be better.
Quicker to do subvec solution first. In this case for time-domain and frequency-domain, a new subvec of the time or frequency vector would also have to be created.
@robbr48  When you say tshift(vector, dt) does that mean to shift the data left or right or change the underlying time data.
I assume its the former, so that we do not affect all variables using that time vector?

I think a time shift operator would need some consideration. When starting
to change time sync for individual signals it is easy to screw things up,
so I think manual indexing of vectors is sufficient for now. Time vectors
can be created manually anyway.
Den tis 18 aug. 2020 kl 21:46 skrev Peter Nordin<EMAIL_ADDRESS>
Implementing new operators such as () and [] will take some time,
parenthesis are used in functions so brackets would be better.
Quicker to do subvec solution first. In this case for time-domain and
frequency-domain, a new subvec of the time or frequency vector would also
have to be created.
@robbr48 https://github.com/robbr48 When you say tshift(vector, dt)
does that mean to shift the data left or right or change the underlying
time data.
I assume its the former, so that we do not affect all variables using that
time vector?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Hopsan/hopsan/issues/1970#issuecomment-675677112, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABRS3W6RBECJI4UB77PBECTSBLK7RANCNFSM4QBQFM2A
.

@peterNordin Yes, we must of course not modify the time vector variable. Only the specified variable must be changed. I think a positive value of dt means shift to the right, but I'm not sure.
@mrejster Operators would be nice, but is very non-HCOM. Compare e.g. with peek(vector,15) which equals vector[15].


fix: Lattice Tx display of pubkey and signature

Pull Request Test Coverage Report for Build 89

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.4%) to 62.191%

Files with Coverage Reduction
New Missed Lines
%

index.js
1
62.19%

Totals

Change from base Build 81:
0.4%

Covered Lines:
166

Relevant Lines:
253

💛  - Coveralls


fix: can't save picture for flac file

I created #211 with the same changes but with a signed commit. Thanks for reporting this.


Export HTML as rendered in editor

It would be great if we could export the HTML and styling as it's rendered in the editor workspace.

@ccaum  I agree with you.

@ccaum @MoreMeng Please try v.2.0.2.


Conformance AKS: wait for cilium-test namespace deletion during uninstallation

Add the wait flag to cilium uninstall in Conformance AKS, so that we ensure that the cilium-test namespace gets effectively deleted before uninstalling and reinstalling Cilium. This ensures that the connectivity tests can then be started correctly (i.e., that the namespace can be created) and prevents Cilium errors such as:

msg="Cannot create CEP" error="... forbidden: unable to create new content  in namespace cilium-test because it is being terminated"

Finally, it brings also consistency with what we already do in the other workflows.

/ci-aks

@brlbil Gentle ping :-)

Reviews are in, and changes are trivial and affect a single GHA workflow, which is green. Marking as ready to merge without running the full CI suite.

/test


Patch Release V6.6.2

v6.6.2
Added

Adds new CMRIncompleteError exception, raised by search methods when CMR returns an incomplete page

Fixed

Fixes bug in search_generator() causing results to sometimes wrongly be marked as incomplete

Changed

stack_from_id() now raises if results are incomplete, before checking if reference was found

Codecov Report

Merging #217 (8134fe8) into stable (330efdd) will decrease coverage by 0.13%.
Report is 1 commits behind head on stable.
The diff coverage is 97.56%.

@@            Coverage Diff             @@
##           stable     #217      +/-   ##
==========================================
- Coverage   89.86%   89.73%   -0.13%
==========================================
  Files          52       52
  Lines        1964     1959       -5
==========================================
- Hits         1765     1758       -7
- Misses        199      201       +2

Flag
Coverage Δ

unittests
89.73% <97.56%> (-0.13%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

asf_search/search/search_generator.py
94.78% <97.29%> (-1.12%)
:arrow_down:

asf_search/exceptions.py
100.00% <100.00%> (ø)

asf_search/search/baseline_search.py
94.23% <100.00%> (-1.85%)
:arrow_down:

asf_search/search/search_count.py
100.00% <100.00%> (ø)


Support registries that use token-based auth

Is your feature request related to a problem? Please describe.
Using our RM extension to browse or pushing/pulling from a registry configured with token based auth is not supported.
Describe the solution you'd like
Support this use case.

Details for this ticket:
providing the stack repo URL of the kind<EMAIL_ADDRESS>resulting the following log record:
11:29:17 http error: Invalid request payload (err=Invalid external templates URL. Must correspond to a valid URL format)
Kinda strange that this request is invalidated by portainer despite it's a completely valid one, but this really should be fixed.

Has this been solved by https://github.com/portainer/portainer/issues/1926?


specify explicit version to jenv which command

I'd love to be able to specify an explicit version to jenv which, something like this:
jenv which --version 1.6 javac

I'm still trying to understand the code enough to make a pull request to do this, but I'm curious if something like this is feasible, and would be desirable or at least acceptable to others.
Thanks much.
-DB

And I just realized that JENV_VERSION=1.6 jenv which javac does exactly this...

So adapting the documentation is enough ?

A section on environment variables somewhere near the top of the command reference (or maybe even before command reference altogether) would have helped, but it doesn't take too long to figure this out as the docs are now.


add ‘Browse “Panorama/”’ to maps’ @parallax_name

The Map → ... → Properties → @parallax_name needs a ‘Browse’ button.
(This is already available in the 11720 event command, so hopefully it’s not difficult to add?)

Should be fixed in cf178be.


performance test batch fails with ./bootstrap.sh: line 13: pip3: command not found

./bootstrap.sh: line 13: pip3: command not found

@qxmips any fix to this, I'm getting the same error


Fixed small type

Fixed small type of extra bracket that wasn't needed.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Thanks!


Fixed KeepPriority Error

Fixed 'Expression is not an integer constant expression' compile error.

You replaced contents of KeepTypes.m with the contents of KeepTypes.h?
By the way, this compilation error has been fixed one year ago.

My bad, messed up the PR and didn't know it had been fixed. Sorry.


[FEATURE] Front-end Create Sign in page

Is your feature request related to a problem? Please describe.
Prepare a Sign in page for the Web App
Describe the solution you'd like
Client need to be able to sign in
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Is your feature request related to a problem? Please describe.
Prepare a Sign in page for the Web App
Describe the solution you'd like
Client need to be able to sign in
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.


Converted all activations except heaviside function

References to other Issues or PRs or Relevant literature

Fixes #60
Brief description of what is fixed or changed
Created Softmax, Softsign, Elu, and Swish classes with activation and derivative methods.

@Abjcodes, please fix some issues, detected by Travis-CI, follow the PEP-8 format for syntax writing.

Hey @kwanit1142 , Can you review the PR?

Hey @kwanit1142 , Can you review the PR?

@Abjcodes kindly run the tests python3 -m pytest --doctest-modules --cov=./ --cov-report=html. Also add tests as well.

@Abjcodes kindly run the tests python3 -m pytest --doctest-modules --cov=./ --cov-report=html. Also add tests as well.

@Abjcodes kindly run the tests python3 -m pytest --doctest-modules --cov=./ --cov-report=html. Also add tests as well. There are errors.

I will look into it.

@Abjcodes kindly run the tests python3 -m pytest --doctest-modules --cov=./ --cov-report=html. Also add tests as well. There are errors.

I will look into it.

@kwanit1142 I have solved merge conflict, will be merging after tests pass!! Rest this pr LGTM.


Correct or potentially to be cleaned?

During the short time that I have been helping here, I have noticed that we divide the data into 3 categories:
A) Cleaned
B) Correct
C) Potentially to be cleaned
Determining whether it is option A is very easy because it is a difference in datasets. However deciding whether it is option B or C is no longer so simple. Therefore, I think that we should be able to mark if the data is correct. It would be nice to add another parameter, for example done (True, False), so that we and potential new contributors don't have to deal with already correct data.
Thanks to this, we will increase the speed and overview of the data itself. We will also see our progress. At the end, of course, we delete that variable.
Either we can incorporate it into the already created GUI or do something else. It would be nice if we could vote there whether it is OK or not yet. Let it not be the decision of only one person. I believe that most people understand me :)

I was thinking about cloud database too. For me it is the best solution for this kind of problem because of access.
In terms of instruction structure I would replace variable Number of reviews with actual contributors, people who have already contributed to this repository - better transparency I guess. Those are people who were, are and I hope still will be willing to help. Those people won't spam the database (finger crossed). Based on that database should also have a list of eligible people who could curate the database.

I can start this process by hooking up the GUI to a local SQLite db

I think adding a DB into the mix might complicate things unnecessarily, as we already have a DB inside the repo (json files) and coordination through Issues/PRs.
We can add an ID field to each prompt, and have another "meta" json document which keeps track of the aforementioned prompt status, then our coordination mechanism simply remains PRs and Issues and python scripts to manage the simple relationships and state.
Another field status I am thinking about is "needs improvement", as I notice a good number of these prompts are too bland or not high-dimensionality enough to expand the base-model's capabilities. These things appear to perform better when given an esteemed character to roleplay, or out of spite, or pitting two simulated characters against each other collaboratively vs just asking it a simple question in a basic manner. (boomer prompts)
I can continue helping to clean/improve this data, but I might have ideas which are too contrary to others working in this space currently. I will most likely create additional datasets either as separate files in this repo to expand the "newly refactored alpaca replication" (as I understand the purpose of this repo, please correct if wrong), or in my own to move quickly in certain directions.
Also, I think we should avoid the patching strategy, and just have different files people can pick and choose to include in whole batch or iterative training rounds. (10k base prompts, then 20k instruction following, then 15k roleplay, etc.)

After thinking about it, I'm in agreement with @claysauruswrecks.  We already have a way to coordinate work here on github through Issues/PRs, so creating an online db would in some way be duplicating that effort.
Having said that, I'm not against putting some work into a local db or JSON metadata that perhaps can be used to flag instructions that need further looking into, or marking instructions that have been reviewed. I do prefer a simpler approach suggested by @claysauruswrecks of having a 'meta' json document that maintains state, with a python script that would maintain the relationship between the dataset and metadata.

I will most likely create additional datasets either as separate files in this repo to expand the "newly refactored alpaca replication" (as I understand the purpose of this repo, please correct if wrong)

The goal of this repo is to provide a clean (base) alpaca dataset. Once we have a clean base, it would be nice to create optional 'extensions' to the base, that users could choose to include.


Investigate our testing setup

We do have an automatic testing framework set up as part of our Git workflow which is working quite fine. However, this framework does currently contain only two test-files which might indicate, that our code coverage is not quite as good as it could be.
Therefore an investigation shall be made to see in how far our current testing framework can be improved.
Acceptance Criteria

Investigations have been made in how far our testing framework can be improved.
(Larger) possible improvements have been brought up so that items can be created for them.
Optional: Smaller possible improvements have been implemented directly (instead of documenting them) where this makes sense.

Testing improvements:
Pipeline:

Is tested

Steps:

analyze_emails (easy)

Can be unit tested as there is no API call
Create test file with certain names and emails
Test that correct columns are created
Test that combinations of domains and names are correctly processed

analyze_reviews (difficult)

Fetches reviews from database => might be hard to mock
Potential call to GPT API

google_places_detailed and google_places (difficult)

The whole logic depends on the google API call => hard to mock and isolate

gpt_summarizer (difficult)

The whole logic depends on GPT API call

hash_generator (easy)

No API calls
Create testing data and pregenerate ground truth hashes
Compare hashes generated by the step and ground truth data

preprocess_phonenumbers (moderate)

No API calls
Could create testing data with ground truth outputs like country, area, some invalid, etc.
Tested data could grow large if we want to be thorough
Would be testing mostly the phonenumbers package we use and not our logic
Might still be good to ensure that we get expected data from the package

regionalatlas  (difficult)

Theoretically depends on API but we downloaded the data it uses
Could create some testing data and then get ground truth from the file we use
Tests might need to be adjusted when the merged_geojson file is updated
Seems tedious to create testing and ground truth data

scrape_address (difficult)

Depends on the websites to not change
Could set-up example websites that are only live during the test and are scraped. There would then either contain the searched data or not ensuring that certain patterns can be recognised by our code.
A lot of work but doable

search_offenregister (difficult)

Logic fully depends on API call

social_mdeia_api (difficult)

Fully depends on API call
Not really used by us as we abandoned Facebook as a source => might want to remove this step

Repository classes:

Local repository

Seems unit testable
Would need to create specific test input files and inject them into the class
Call certain method and ensure the file is created (on save methods) or that data has been loaded (on load methods). Possibly extend this to also investigate the contents of the saved/loaded data

S3 repository

Harder to test as it is fully intertwined with the connection to the S3 repository
Needs access key just for testing with certain rights
Would probably need to set up a testing bucket
Populate with certain data and check if files have been created/ downloaded
Possibly extend to check file contents

Console utils:

Testable if we can mock user input (which should be fairly easy, unit test module provides possibility to mock this)
Very straight forward

Demos:

Perhaps a test of the form if input assert output (in string form, this seems like it gives little value)

Pipeline utils:

Testable
Create test json pipeline configs and load them
Assert that the resulting Pipeline has all requested steps

EVP:

Could test constructor; I.e. if requested model X the predictor is actually model X => error on unsupported model
Testing correct training and prediction seems hard. We could have a dummy dataset and ensure that training runs at all if the data is present. Not sure how much value this gives.

Logger:

Does not seem like we need to test this

Preprocessing:

Could create input data and ensure that certain values are converted correctly
Could help ensure that edge cases are correct
Might take a lot of effort

Very nice and comprehensive list 👍


JEP 407, remove Activation

JEP 407 removes RMI Activation, while we don't depend on the implementation of Activation, we do depend on some API's for Phoenix and Activatable services.
I'll grab the activation API classes from Apache Harmony and add them to the JGDMS Activation Platform Module.
java.rmi.activation.ActivationID appears to have the largest impact, as it's one of the arguments in a two argument constructor.
We also need to consider the impact of JEP 411.

This will impact Phoenix, but only slightly.
Might as well go ahead and remove JRMP Exporter as this has dependencies on RMI Activation.

jtreg tests still depend on rmid, need to replace with Phoenix

Currently Activatable services require an Activation constructor, one of the constructor parameters is an instance of MarshalledObject, which contains a String[] array of arguments.  Instead of using MarshalledObject, why not just an array of String[] arguments?

The advantage of using an String[] array argument is that it doesn't require de-serialization, all services currently use a String[] for their configuration arguments.


data to props

This is incompatible with newer hyperapp versions since 0.12.0 I think, because the vdom changed the name of the data property of a vnode to props. In hyperapp -- but not yet in picodom
So the steps to fix this are:
[ ] replace all .data with .props in picodom
[ ] replace all .data with .props in hyperapp-transitions

Fixed


Update to flare-publishing-plugins 1.0.0

Black Duck Security Report
Merging #32 into master will not change security risk.
Click here to see full report


SSH FS

What this PR does / why we need it:
This is the extraction of sshiofs and its usage from #1316. It's needed to isolate unrelated functionality developed during main driving force of #1316 (CABundle handling).
Does this PR introduce a user-facing change?:

NONE

/retest


Make summary graphs by taking filled-in geometric averages also over run params

Previously, for graphs run over different run params (eg. computer,
branch) the averaging was simple arithmetic mean without fill-in of
missing values. This introduces spurious spikes in the summary graphs,
which is now avoided using the same geom-mean code for run and benchmark
parameters.
Should address gh-309

:+1:


add modal card

I'm adding modal card

Thanks for the PR. It has been merged.


Update set-up-backup-server-for-azure-vmware-solution.md

Corrected VMware product names. Updated MABS Capacity Planner link with specific URL.

@rvandenbedem : Thanks for your contribution! The author(s) have been notified to review your proposed change.


DigitalOcean Challenge 404 error

Running into this issue when processing the challenge for digitalocean (domain polluxis.me, *.polluxis.me):
1 controller.go:207] challenges controller: Re-queuing item "default/polluxisme-2801170174-0" due to error processing: POST https://api.digitalocean.com/v2/domains/_acme-challenge.polluxis.me/records: 404 The resource you were accessing could not be found.
Not quite sure how to debug further...
Environment details::

Kubernetes version (e.g. v1.10.2): v1.13.1
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): Digitalocean
cert-manager version 0.6
Install method (e.g. helm or static manifests): Helm

/kind bug

v0.6.1 has been released which includes https://github.com/jetstack/cert-manager/pull/1266 - could you try the new version and report here whether it's helped your problems?


Opening a song

Describe your bug here.
I open the song and this is what I get:
flixel/graphics/frames/FlxAtlasFrames.hx (line 246)
Character.hx (line 164)
PlayState.hx (line 1007)
flixel/FlxGame.hx (line 637)
flixel/FlxGame.hx (line 724)
flixel/FlxGame.hx (line 677)
flixel/FlxGame.hx (line 545)
openfl/events/EventDispatcher.hx (line 402)
openfl/display/DisplayObject.hx (line 1399)
Uncaught Error: Null Object Reference
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build?


Cannot pass custom settings to custom control

Issue description:
I'm creating  a custom control that displays a dropdown of posts to be chosen just like this.
<?php
if ( class_exists( 'WP_Customize_Control' ) ) :
	add_action( 'customize_register', function( $wp_customize ) {

		class Martin_Customize_Dropdown_Posts_Control extends WP_Customize_Control {
			public $type = 'dropdown_posts';

			public $post_type = 'post';

			public function render_content() {

				$latest = new WP_Query( array(
					'post_type'   => $this->post_type,
					'post_status' => 'publish',
					'orderby'     => 'date',
					'order'       => 'DESC',
				) );
				?>

					<?php echo esc_html( $this->label ); ?>
					<select <?php $this->link(); ?>>
						<option selected> --- </option>
						<?php
						while ( $latest->have_posts() ) {
							$latest->the_post();
							echo '<option ' . selected( $this->value(), get_the_ID() ) . " value='" . get_the_ID() . "'>" . the_title( '', '', false ) . '</option>';
						}
						?>
					</select>

				<?php
			}
		}
		// Register our custom control with Kirki
		add_filter( 'kirki/control_types', function( $controls ) {
			$controls['dropdown_posts'] = 'Martin_Customize_Dropdown_Posts_Control';
			return $controls;
		} );
	});
endif;

but trying to overwrite the post_type (or any other arg that I come up with), it simply doens't work
$field_id   = $section_id . '-posts-id';
Martin_Kirki::add_field( 'post', array(
	'type'        => 'dropdown_posts',
	'settings'    => str_replace( '-', '_', $field_id ),
	'label'       => __( 'Select a post', 'martin' ),
	'section'     => $section_id,
	'post_type'   => 'page',
	'default'     => 'none',
	'priority'    => 10,
) );

Version used:
(Did you try using the develop branch from github? There's a chance your issue has already been adressed there)
3.0.5
Using theme_mods or options?
theme_mods
Maybe I'm just missing something...

digging a bit more, it might be something related to these lines
(Kirki_Field class, __construct, line 349)
		// Set the class properties using the parsed args.
		foreach ( $args as $key => $value ) {
			$this->$key = $value;
		}

(Kirki_field class, set_field, line 410)
		// Get all arguments with their values.
		$args = get_class_vars( __CLASS__ );
		foreach ( $args as $key => $default_value ) {
			$args[ $key ] = $this->$key;
		}

as get_class_varsonly gets the class vars defined by default, not the ones added later (with 			$this->$key = $value;)
might be pure speculation though..I'm a js dev.. I'm not that familiarized with PHP/WP
I'll keep digging...

👍 Thanks!
The only reason I haven't dealt with this one yet is because there were other bugs that were a bit more urgent. As version 3 solidifies and bugs are fixed, I'm starting to deal with the "less urgent" issues. Not that this is any less important than others, just not as widely used.
I'll deal with any outstanding issues later today and push another update.

No problem :)
Did you se I left a PR related to this?

Yep, I just merged it, thanks! 👍
It will be included in the next release later today.


⚠ Bofrost.fr has degraded performance

In e0ead6b, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1150 ms

Resolved: Bofrost.fr performance has improved in f23b53a after 1 hour, 7 minutes.


Holofoil Speaker Stickers

I'll arrange them

I know some companies that use Sticker Mule and they are happy with the quality. Maybe you have seen some of these stickers at Devoxx...


Add between operator

Purpose
#56
Approach
Reading the doc and reading drivers in others langages
Research
r.minval and r.maxval doesn't work

Tests pass locally can't reproduce

Can we create a new issue for r.minval and r.maxval so we have a reference for future?

Yes this constants doesn't work currently this must be an issue

@Th3Mouk I am planning to merge this now, do you agree?


Google Play In-App Review Feature Request

Feature Request:
Are there any plans to update the package to include the In App Review feature for Android? Currently the RequestReview() method works for iOS but not Android, and it appears that Google now has an API for it. Thank you!
https://developer.android.com/guide/playcore/in-app-review
https://developer.android.com/guide/playcore/in-app-review/kotlin-java#java

Fancy! Will look for sure :)

@jamesmontemagno  please add it!

https://github.com/jamesmontemagno/StoreReviewPlugin/pull/7

@skyapps-co @darrabam the v3.0 beta has this feature. It was released 30 minutes ago

@saamerm Thanks!  Works fine with iOS.
using the latest XF: 4.8, Essentials:<IP_ADDRESS>, StoreReview: v3-beta
Note that I'm getting the following message in the output window:
09-24 09:37:37.442 I/PlayCore(21922): UID: [10107]  PID: [21922] ReviewService : requestInAppReview (MY_APP_NAME)
09-24 09:37:37.495 I/PlayCore(21922): UID: [10107]  PID: [21922] ReviewService : Initiate binding to the service.
09-24 09:37:37.496 I/PlayCore(21922): UID: [10107]  PID: [21922] ReviewService : Failed to bind to the service.

@darrabam you can only see the UI if you have downloaded the app from the Google Play store. The easiest way is to upload it onto "Internal App Sharing"

Hello, just now I tried this feature in Google Play alpha distribution and I can't display review request popup.

Hello! I tried this feature just now, without success. As expected on simulator there is an error message mentioned above, but when I try in beta  app on the real device (installed from Play Store alpha distribution) the popup window dans't appear (but there is no error message in logs as well).

@RadoslawKubas did you do ‘RequestReview(false)’ or did you set it to true?

@saamerm I tested both in case, when is true, just as expected nothing happened (no exception). When is false, I got exception. One maybe important info, I'm using Link All and profiled AOT with custom AOT profile.

The linker is likely the issue, as you can see it says that it’s not able to find the function. @RadoslawKubas

@saamerm I tried just now without linker (or exactly Sdk Only) and same exception. Build configuration is

2020-09-27T17:02:23.8197740Z     ANDROID;
2020-09-27T17:02:23.8198070Z     false
2020-09-27T17:02:23.8198420Z     portable
2020-09-27T17:02:23.8198740Z     true
2020-09-27T17:02:23.8199040Z     bin\Release
2020-09-27T17:02:23.8199320Z     prompt
2020-09-27T17:02:23.8199630Z     4
2020-09-27T17:02:23.8199960Z     true
2020-09-27T17:02:23.8200320Z     false
2020-09-27T17:02:23.8200700Z     true
2020-09-27T17:02:23.8201470Z     armeabi-v7a;arm64-v8a
2020-09-27T17:02:23.8201930Z     false
2020-09-27T17:02:23.8202310Z     true
2020-09-27T17:02:23.8202610Z     False
2020-09-27T17:02:23.8202980Z     false
2020-09-27T17:02:23.8203330Z     d8
2020-09-27T17:02:23.8203630Z     SdkOnly
2020-09-27T17:02:23.8204020Z     true
2020-09-27T17:02:23.8204350Z     False
2020-09-27T17:02:23.8205150Z     no-write-symbols,nodebug
2020-09-27T17:02:23.8205590Z     False
2020-09-27T17:02:23.8205900Z     False
2020-09-27T17:02:23.8206310Z     false
2020-09-27T17:02:23.8206650Z
2020-09-27T17:02:23.8206960Z     True
2020-09-27T17:02:23.8207310Z     r8
2020-09-27T17:02:23.8207620Z     aab
2020-09-27T17:02:23.8207940Z

Switch the Android link tool from r8 to pro guard and inside your project, add these to a proguard.cfg file set to the proguard build config:
-keep com.google.android.play.core.review
-keep com.google.android.play.core.tasked

I will add an API check for API 21+  and then document that for proguard as well :)

An error like
Java.Lang.NoSuchMethodError: no non-static method "Lcom/google/android/play/core/review/c;.requestReviewFlow()Lcom/google/android/play/core/tasks/Task;"

after shrinking an app with R8 is typically caused by the missing keep rules for reflection used by the app. If the keep rules cited in https://github.com/jamesmontemagno/StoreReviewPlugin/issues/6#issuecomment-699691779 fixes the issue it would be worthwhile to look closer into the generated code to see the concrete reflection being used to limit the scope of the keep rules and keep the app smaller. Could it be that some reflection is used when compiling await from C# to android code?
(for the record, I work on the R8 team)

Thanks for all the advice. It takes more time to see if it really works due to an unexpected long publication time on the Play Store. I had to wait a few days to see the application in the internal channel. Anyway, it helped to resolve the first exception, but now I'm seeing a new exception:
java.lang.RuntimeException: Unable to instantiate activity ComponentInfo{com.appwithkiss.tipcalculator/com.google.android.play.core.common.PlayCoreDialogWrapperActivity}: java.lang.InstantiationException: java.lang.Class<com.google.android.play.core.common.PlayCoreDialogWrapperActivity> cannot be instantiated
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3228)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3443)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:83)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2040)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:221)
at android.app.ActivityThread.main(ActivityThread.java:7520)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:539)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:950)
Caused by: java.lang.InstantiationException: java.lang.Class<com.google.android.play.core.common.PlayCoreDialogWrapperActivity> cannot be instantiated
at java.lang.Class.newInstance(Native Method)
at android.app.AppComponentFactory.instantiateActivity(AppComponentFactory.java:95)
at androidx.core.app.CoreComponentFactory.instantiateActivity(Unknown Source:0)
at android.app.Instrumentation.newActivity(Instrumentation.java:1251)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3216)

Adding one more rule
-keep class com.google.android.play.core.common.PlayCoreDialogWrapperActivity
solved the problem, everything seems to be fine now.

@RadoslawKubas ah thank you! I was trying to figure that one out. We are trying to fix the play core bindings library, so that this nuget works without these issues!!

Hello, im using linking sdk only without code shrinker, the app is published on Google play in public but i dont see anything when i run this code:
var task = Task.Run(() => RequestReview());
                task.GetAwaiter().GetResult();
...
private static void RequestReview()
        {
            MainThread.BeginInvokeOnMainThread(async () =>
            {
                await CrossStoreReview.Current.RequestReview(false).ConfigureAwait(false);
                Preferences.Set(Settings.ReviewClickedOrIgnoredKey, true);
            });
        }

@CDrosos have tried just using:
CrossStoreReview.Current.RequestReview(false); without the await-async?

im publishing now with that and letting you know the results, thank you

@saamerm i have just tried and nothing happens when i run the code: CrossStoreReview.Current.RequestReview(false) ;
Why we dont get any exceptions or something like that?

I appreciate your patience 😄

What Android OS is installed on the device and what device is it?
Did you add the proguard correctly as per the README?
You don’t need to publish the app to the Play Store, you can just upload it to the “Internal App Sharing” and then download it from the link the Play store will provide.
Try to Change the linker and shrinker settings and see if you’re able to make it work.

@saamerm ok i have create this issue

... is there an eta when this will make it out of beta?


Add GitLab versions 11 and 10.X for testing

This will update the testing steps to be more compliant to the latest version of GitLab.
Signed-off-by: solidnerd<EMAIL_ADDRESS>

Coverage remained the same at ?% when pulling cecafb6e5ab44874f708600a9403e6029fdf73a7 on update-tests into f4052c2595083c1352d4674a33772f5ab165990b on master.


Support per file test_file_prefix

It would nice if it would be setup individual test_file_prefix per each file.
My use case is that I have multiple apps in a mono repository where each app has it's own directory and since all off them require same environment I do run tests for each of them in a single github job, as result I have 5 junit xml files but they are all prefixed with local relative path so in order to get annotations to show up properly I have to setup publish-unit-test-result-action  5 times like:
      - name: Publish RSpec Results (APP 1)
        uses: EnricoMi/publish-unit-test-result-action@v2
        if: always()
        with:
          check_name: 'RSpec / APP 1'
          comment_mode: errors
          test_file_prefix: "+app_1/"
          files: |
            test-results/rspec/app_1.xml

      - name: Publish RSpec Results (APP 2)
        uses: EnricoMi/publish-unit-test-result-action@v2
        if: always()
        with:
          check_name: 'RSpec / APP 2'
          comment_mode: errors
          test_file_prefix: "+app_2/"
          files: |
            test-results/rspec/app_2.xml
# ... and so on

This works but not optimal, and I have 5 annotations instead of one.
I also tried to change how my junit reporter (formatter) works but it was not something it's easy achievable there (ruby, rspec + rspec_junit_formatter)

I've found a better solution - it appears all references to the files in xml start with file=". and as such it was easier to replace the paths in xml file with sed:
sed -i -E "s/(file=\")\./\1app1/g" test-results/rspec/app1.xml

replacing . after file=" with the folder name I needed


Allow the use of the Arduino Leonardo

The Arduino Leonardo (atmega32u4) does not have an UART0 but only UART1.
I have used the same syntax has the official Arduino IDE.
Another solution is to change it inside the method like here

I chose the other solution, see commits 152751f9715ce5fd6f272c0f9ce2c8aeab7dbbe9 and 08f085379f8cc53c7104d0d180dae48d2df8c5bb, they should fix your issue.

Ok, nice approach, so it should work on atmega8 that have a single uart and use TXEN register.


Remove pycache directories in make clean-pyc

😄

Current coverage is 100% (diff: 100%)

Merging #849 into master will not change coverage

@@           master   #849   diff @@
====================================
  Files          16     16
  Lines         657    657
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
  Hits          657    657
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update ceafa1d...0f93383

:tada:

Thank you @michaeljoseph! 🍪


SASS-9176: ESBA changes for Remove claims page

I think you need to make some changes to  EsbaSummary, for remove button to be visible in the UI


How use router regular expression

the router function is very simple. Do you consider enhancing it?
Supports * symbols or regular expressions？

View the code, you can find Atreugo use fasthttp/router
savsgio is one of the authors of fasthttp/router.
fasthttp/router currently should not support regular, but support * symbols.

Hi @sanqi,
Atreugo use fasthttp/router, as @imxxiv says, so at now regular expressions it's not supported, and i can't say you exactly when it will be available.
But it's an interesting functionality to adds.

Hi @sanqi,
What kind of regex do you mean?

just like nginx regex?
Maybe simple rules to check numbers or a-z?

Hi @sanqi,
I've been upgrade router package in Atreugo to support regex in the url parameters.
Soon i will release the version v11.0.0, because the new way to declare parameters breaks the backward compatibility.
Thanks for your patience.


Algorithm or Data Structure name | Language

Title - Lucky Number
what will change - This program will check if the number provided is lucky or not . Prints true if number is lucky. Otherwise prints false.
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] C++

Self Check

Ask for issue assignment before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Happy Coding!

Can you please assign this to me?

For Python!! ✋🏻


RFC: Add support for getting next extended grapheme cluster break

Checklist

Please ensure the following tasks are completed before submitting a feature request.

[X] Read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.
[X] The issue name begins with RFC:.

Description

Description of the feature request.

This RFC proposes to add support for getting next extended grapheme cluster break in a string after a specified position.
Package: @stdlib/string/next-grapheme-cluster-break
Alias: nextGraphemeClusterBreak
Function prototype: nextGraphemeClusterBreak( str[, fromIndex] )
Related Issues

Does this feature request have any related issues?

No.
Questions

Any questions for reviewers?

No.
Other

Any other information relevant to this feature request? This may include screenshots, references, sample output, and/or implementation notes.

No.

@kgryte I am wondering what the best way of implementing @stdlib/string/prev-grapheme-cluster-break would be. We can have duplicate code like should_break.js etc. in both the packages or use @stdlib/string/next-grapheme-cluster-break directly to implement @stdlib/string/prev-grapheme-cluster-break.

@ShraddheyaS That is a good question. I am not sure the best approach here. I don't see an easy way to make the interface for should_break user friendly. Meaning, not clear to me how to make this a "public" package for general consumption.
And not clear to me what kind of abstraction layer we could use to wrap should_break to make it a general utility.


⚠ Bofrost.es has degraded performance

In b62fed7, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1454 ms

Resolved: Bofrost.es performance has improved in 3408a19 after 13 minutes.


Onboarding 2: Run Canvas CTK on Innovation Hub experimental cluster

Description
Once issue #121 is complete and you have an experimental cluster: Run the Canvas CTK at compliance-test-kit to validate the Canvas is operating as expected.
Use tools like kubectl k9s or the GKE dashboard (use the Object Browser and click on the oda.tmforum.org API Group to see Component and API resources) to see what is going on behind the scenes when you deploy a component.
For troubleshooting, check the Troubleshooting-Guide

Hint for others:
The release name of the product-catalog deployment has to be "ctk"
helm upgrade --install ctk -n components oda-canvas/compliance-test-kit/BDD-and-TDD/testData/productcatalog-v1beta2

if running inside the cluster, the keycloak-ip can be set to cluster-local service name:
export KEYCLOAK_BASE_URL=http://canvas-keycloak.canvas.svc.cluster.local:8083/auth/


AU-954:  Liikunnan yleisavustus 56

AU-954

Add Liikunta yleisavustus form.
What was done

This thing was fixed

How to install

Make sure your instance is up and running on correct branch.

git checkout UHF-0000_insert_correct_branch
make fresh

Run make drush-cr

How to test

[ ] Check that this feature works
[ ] Check that code follows our standards

Designers review

[ ] This PR does not need designers review
[ ] This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

Link to other PR

Korjataan starttiavustus kun saadaan valmiiks, mergetään nyt noille testiin.


space-Travellers

Hi Code Reviewer.
Below is the link to our GitHub project.

We are two people in this project

https://github.com/Umuhan/space-Travellers/projects?type=classic

Changes Required ♻
Hi @,
Nice job, you are almost there.

(Changes Required) Aspects to improve: ♻

[ ] As per this requirement, Please make sure that all Kanban cards are assigned to team members, for example there are cards meant to team member A and others meant to team member B and for group tasks you can assign both of you to it.

This is your cards:

and this is how suppose to be:

[ ] For a team with two people, the number of cards in Backlog should be equal to 17, not 15 as you did, Please add the 2 missing cards.

[Optional] suggestions:

Nothing to mention.

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi @Umuhan and @hamzaw9,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
STATUS: REQUIRE CHANGES 🔴

Highlights

N/A

Required Changes ♻

[ ] Please follow the things properly, as your previous code reviewer already mentioned that you are a team of two people and your Kanban board should contain a 17 task instead of 15, which means you are supposed to add 2 missing cards. But it seems like, you only implemented the one change and did not add the the missing cards. Kindly add the two missing cards in order to get the approval for the project setup.

The two missing cards are related to fetching the mission and rockets. Please take a look at the below screenshot

Check the comments under the review.
Cheers, and Happy coding!👏👏👏
Have any doubt ❓
Please, remember to tag @skyv26 in your question so I can receive the notification. You can also follow me on the below platforms

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

STATUS: APPROVED 🟢
Hi :wave:  team,

Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
(Highlights) Good Points: :+1:

You documented your work professionally. ✔
Well done adding the missing cards. 🎉 🎉 🎉 ✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Include highway network

As link and node table? Is there a GMNS editor? As an Aequilibrae object?

I think the way to do this is to:

Export link and node tables as csv
Use Aequilibrae to edit and correct network.
Save Aequilibrae data object as GMNS