Broken PR feature "[MM-25748]Allow access to managed resources #1311"

I confirm (by marking "x" in the [ ] below: [x]):

[x] This is not a troubleshooting question. Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/.
[x] This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[x] I have read contributing guidelines.

Summary
Managed resources feature was implemented by me in June 2020. Released 2 weeks ago in Mattermost Desktop. It used to work in June. Now looks like something has changed and click on URL which used to work gives this:

Expected was that Mattermost Desktop app opens popup window, not in same window.
I can provide test credentials and test server for this.
Link to PR: https://github.com/mattermost/desktop/pull/1311
Environment

Operating System: Linux
Mattermost Desktop App version: 4.6.1
Mattermost Server version: 5.28.0

now that I see the error, shouldn't the url path be managed by the proxy before going to the server? that's a server response, so it is searching for the path as if it were a team.

It is managed by Nginx.

Click on link gives error
Open link in new tab, works ok

On Thu, Oct 29, 2020 at 10:06 AM Guillermo Vayá<EMAIL_ADDRESS>wrote:

now that I see the error, shouldn't the url path be managed by the proxy
before going to the server? that's a server response, so it is searching
for the path as if it were a team.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mattermost/desktop/issues/1401#issuecomment-718508892,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACUTPKU37FQTMB6JN6UDLLSNEWALANCNFSM4TDNGOQQ
.

@dpanic i updated my original comment as I forgot a second option, which seems to be what you describe

@dpanic i updated my original comment as I forgot a second possibility, which seems to be what you describe

Ok so looks like now is clear where and what is the issue?

i've created a jira ticket

Hi @dpanic. To confirm something, was the link that you clicked in a post that someone made?

Also, is this something that worked before, or is it something you want to make work?
Unfortunately, when we first started including the team name in the URL path, we didn't think to include a /teams prefix so everything directly under / outside of some special cases like /api and /plugins is considered as the name of a team, so that's what's causing the problem here.

Hi @dpanic. To confirm something, was the link that you clicked in a post that someone made?

It was created by modified Jitsi plugin

Also, is this something that worked before, or is it something you want to make work?
Unfortunately, when we first started including the team name in the URL path, we didn't think to include a /teams prefix so everything directly under / outside of some special cases like /api and /plugins is considered as the name of a team, so that's what's causing the problem here.

This is something @Willyfrog and I made work 3 months ago. I submited PR for this

So the reason this broke is because we changed how we detect internal vs external links in posts in the web/desktop app. Anything internal is opened in the app or browser tab, and everything external is opened outside of that. Before, we only treated a few cases as internal (like /<team>/channels/<channel>), but we kept running into issues because people would want to link to different things like the System Console or to some plugin-provided pages. We decided to change it to explicitly list things in the server that needed to be treated as external because anything unrecognized as internal because something like /foo could be part of a team named foo. If we had thought to make teams live under /teams/<team>, none of this would've happened.
So, ideally, we'd keep it this way to prevent future issues with people wanting to link to new pages within Mattermost, but obviously that screws up your case. As it stands, even if we revert the changesfor 5.29, you still won't be able to use 5.28.
@Willyfrog mentioned you're running a custom build of the desktop app for this. Are you perhaps also running a custom build of the web app? I could point you to the spot to change the internal/external link handling to add your any URLs to be treated as external.

So the reason this broke is because we changed how we detect internal vs external links in posts in the web/desktop app. Anything internal is opened in the app or browser tab, and everything external is opened outside of that. Before, we only treated a few cases as internal (like /<team>/channels/<channel>), but we kept running into issues because people would want to link to different things like the System Console or to some plugin-provided pages. We decided to change it to explicitly list things in the server that needed to be treated as external because anything unrecognized as internal because something like /foo could be part of a team named foo. If we had thought to make teams live under /teams/<team>, none of this would've happened.
So, ideally, we'd keep it this way to prevent future issues with people wanting to link to new pages within Mattermost, but obviously that screws up your case. As it stands, even if we revert the changesfor 5.29, you still won't be able to use 5.28.
@Willyfrog mentioned you're running a custom build of the desktop app for this. Are you perhaps also running a custom build of the web app? I could point you to the spot to change the internal/external link handling to add your any URLs to be treated as external.

Hey, If I wanted to run custom build, than I would not submit PR to you. I will not wait 3-4 months for PR to be released :-)
I am pretty sure we can find a solution for this. As there is ONLY one url which needs to be whitelisted, /trusted
Perhaps @jespino can jump in, as he is aware of the feature https://github.com/mattermost/mattermost-server/issues/15136

Any updates on this?

Apologies. @Willyfrog and I discussed the followup for this yesterday, and I updated the Jira ticket on this, but I forgot to put those changes here. I saw you chatted about that with him though about it.
Since the web app can't get the values configured in the desktop app, we had to add a separate server setting for this that can be configured to have the web app treat those links as external when appearing in a post or anywhere else that supports Markdown. The setting takes a comma-separated list, but I tried to have it otherwise take values in the same format.
There's a few PRs involved in this, but the main one to watch for this fix is this one: https://github.com/mattermost/mattermost-webapp/pull/7024
I think I understand the feature now, but just to make sure, I'm going to leave a comment on some of the unit tests in that PR if you could confirm that it behaves how you'd expect with the new setting enabled.

Apologies. @Willyfrog and I discussed the followup for this yesterday, and I updated the Jira ticket on this, but I forgot to put those changes here. I saw you chatted about that with him though about it.
Since the web app can't get the values configured in the desktop app, we had to add a separate server setting for this that can be configured to have the web app treat those links as external when appearing in a post or anywhere else that supports Markdown. The setting takes a comma-separated list, but I tried to have it otherwise take values in the same format.
There's a few PRs involved in this, but the main one to watch for this fix is this one: mattermost/mattermost-webapp#7024
I think I understand the feature now, but just to make sure, I'm going to leave a comment on some of the unit tests in that PR if you could confirm that it behaves how you'd expect with the new setting enabled.

Saw it, and commented there. Thanks

Closing as this has been fixed in the webapp.


Faster JobCallbackRequestMakerTest

This test used to take ~5s. Now it's ~0.3s.
Remaining slowest test is azkaban.execapp.JobRunnerTest: 2.513s.
All enabled tests now run in ~5s \o/

@HappyRay, could you check this please?

Excellent. Thanks!
LGTM. Could you update the branch or do you mind that I update the branch so that we can merge?
It appears that you shortened the various Jetty timeout values. It would be great if you can describe what you did to speed up the tests.

Updated branch.
How this was speeded up: This test was being run using the default timeout values. In the test the normal request time is so short that we can set lower timeouts in test props and still test the timeout scenarios reliably.

Thanks!


PartialViews or API

I've been really impressed with what you guys have done w/ Blogifier. I spent some time creating my own theme using angular material, and so far so good.
The biggest limitation I'm running into is that angular really shines in single-page apps. However, there's really not a good way to asynchronously request posts for the home page, single page, categories, authors, and search. This could be easily solved by adding PartialView results to controllers in Blogifier.Core. Even if your "standard" and "custom" themes don't support these views, it would allow others to create their own themes to take advantage of them. Another option would be to add api access. There is an API right now, but only for authenticated users - adding an anonymous api (something that preferably returns json or xml) would be an alternative solution.
If you guys are busy, I'd be happy to add either partial views or an API and create a pull request. I'd just like to know if that's something that you'd be interested in adding, and if so, which method you would prefer.
BTW, I only spent a few hours on this, but here's a version of your blog that runs on "stock" angular with angular material. I'd be much better with transitions, but I need a way of loading things async for that. I didn't need to modify anything in Blogifier.Core to make it work.
http://bloodforge.azurewebsites.net/blog

That seems reasonable, if you just do pull request implementing single partial view with minimum functionality I can review it and we discuss if this fits overall design. I think it can be done without adding too much complexity, but if this is too messy I'd rather keep it as a fork with specific Angular feature.
Just keep in mind we update code sometimes almost hourly, so please do pull latest before submitting request.

Ok, it took me 2 min to make the change, but 2 hours to figure out how to commit it. I think I figured it out.
Also, let me know if you want me to change the approach. I simply added a new parameter which would result in a PartialView instead of a View to the method in the Controller.

Although it looks like a small change, down the road people will have no idea why this code in the controller and will break it without even knowing it, making it a maintenance issue. So I'd rather avoid partial views.
What you can do is add API controllers in the "parent" application. For example, home controller in the sample application (WebApp) can use code like this:
`using Blogifier.Core.Data.Interfaces;
IUnitOfWork _db;
public HomeController(IUnitOfWork db)
{
_db = db;
}`
So you can in your code isolate public API and, if this works fine without changing anything else, we can pull it into Core under /Controllers/Api/Public.
Let me know if you see issues here or have any suggestions.

I saw this right after I got my theme using PartialViews.... :)
I'll switch it over to an API sometime this weekend.

I changed everything over to an API. I'll do a pull request on the files so you can take a look at them. You can see the end result here: http://bloodforge.azurewebsites.net/blog.
I have a few concerns:

The API returns basically the same data as the standard controller, which means that nearly identical code is in two files now. If you guys decide on including an API, it might make sense to refactor the files so that the logic to get a post or posts by author, etc, all happens in a single place.

The BlogPostDetailModel appears to have looping references. It failed serialization until I altered the following:
services.AddMvc();
to:
services.AddMvc().AddJsonOptions(options => options.SerializerSettings.ReferenceLoopHandling = Newtonsoft.Json.ReferenceLoopHandling.Ignore);
This code is in the Startup.cs file of my web app.

 The purpose is to return posts, and ideally it would all happen from a single "Posts" controller. I tried to follow what was happening for the View controllers, so I ended up with multiple files, but I'm not sure if that's the correct approach. I'm sure that if you guys decide to include an API, you'll have your own opinions on how that should be done, so I'll just leave that decision for you.

Actually, instead of polluting your repository w/ my crappy commits, you can see them in my branch:
https://github.com/murst/Blogifier.Core/commit/358c04ac52a29422ce1c271efda78bb75196e645

I'll be looking into it when we closer to release, so I don't have to maintain 2 sets of APIs while we keep making changes to controllers.

Makes sense. I'll adapt to whatever you guys make when its ready.
In the meantime, I'll maintain my own version in a way that makes sense to me, instead of trying to match the current state of the blog. I moved all APIs that get posts (or a single post) into a single controller and trimmed them down a little, so that the most complex model that is returned is the BlogPostModel (stuff like categories, disqus, etc, don't need to be there IMO if we're just requesting the posts - however, I didn't do an IEnumerable because I wanted the Pager).
I now retrieve posts like so:

All posts (for home page):
blogifier/api/public/posts
blogifier/api/public/posts?page={page}

Posts by author:
blogifier/api/public/posts/author/{author}
blogifier/api/public/posts/author/{author}?page={page}

Posts by category:
blogifier/api/public/posts/category/{cat}
blogifier/api/public/posts/category/{cat}?page={page}

Search:
blogifier/api/public/posts/search/{term}
blogifier/api/public/posts/search/{term}?page={page}

Single Post:
blogifier/api/public/posts/post/{slug}

I did run into an issue. After creating a few different web services (I ended up with controllers for Posts, Authors, and Categories), I started getting the following error:

a second operation started on this context before a previous operation completed

My services were being accessed pretty much at the same time. It probably also doesn't help that my database is not local.
I'm not very familiar w/ the IUnitOfWork pattern and how its being used here using dependency injection. I'm probably not using it right (although my code seems pretty much identical to the other controller constructors). I was able to fix my problem by changing the IUnitOfWork injection from a singleton to scoped: services.AddScoped<IUnitOfWork, UnitOfWork>(); , although I don't really understand enough about this to know if that is the appropriate solution to the problem, or if I should have accessed the data in a different way.

Usually to get around this issue I would do collection.ToList() which frees DbContext right away , but scoped seems to make sense here:
Scoped lifetime services are created once per request within the scope. It is equivalent to Singleton in the current scope. eg. in MVC it creates 1 instance per each http request but uses the same instance in the other calls within the same web request. (from here).

Actually, about public APIs - I think there should be no duplicates at all. Every time Blogifier needs to use any of "get" in your list internally, it can use public. No need to have separate near identical call in both places. I'll try to pull your public folder and see if it can be used internally.

Any update on the public APIs? My theme won't work without a way to get the data asynchronously.
:(

With 1.0 out of the gate, I can focus on this now, no worries. Just didn't want it to block release.

I pushed update with public post APIs included to dev branch. Check this out, you'll need to make some adjustments because some things changed, for example posts by category require author slug etc. In general, I added data service that sits in between repository and controllers and can be reused by private and public APIs, you just need to set "pub" indicator when calling this service to true to have fields sanitized for public view.

The only thing I ran into so far was that I got a looping reference error when serializing a BlogPostDetailModel. I'll look into this some more tomorrow and try to figure out what's causing it.
I noticed is that in GetPostBySlug, the BlogPostDetailModel populates a profile twice:
BlogPostDetailModel.Profile
BlogPostDetailModel.BlogPost.Profile

Each of these profiles is populated in a different call to the database. Without changing too much of the code, you could probably change
vm.Profile = _db.Profiles.Single(b => b.Id == vm.BlogPost.ProfileId);
to
vm.Profile = vm.BlogPost.Profile;
Thanks for working on the API! :)

I've added that "ReferenceLoopHandling.Ignore" to fix circular reference between post and profile.

I put in a few changes for you to review:

I added support for category listing when in single-blog mode. Passing an empty string for "auth" into DataService.GetPostsByCategory will return all posts in the category, regardless of who the author is. Some changes were required in BlogCategoryModel since certain properties assumed a Profile, and in this case the Profile would be null.

I added ordering to PostRepository.ByCategory. I think this was unintentionally omitted.

I updated a few comments in the public API.

You can preview the changes here:
https://github.com/murst/Blogifier.Core/commit/a1a814c1331fdc9bb442f625b098aa2cefeae720

One minor thing - we not generating documentation from XML comments, so I'm not using them anywhere in the code, at least not intentionally. Just use regular "//" instead.
The nulls in profile can be major, it needs to be tested for different scenarios, not just single blog.

Sorry, the comment thing is almost a reflex for me. I'll try using double slashes instead.
The effect of having a null profile will certainly need to be addressed. I looked at the latest 'Custom" theme from github, and while there is a Category page, I can't find a way to get to that page from either the blog homepage or from a post. The existing Category page does require an author slug in the code.
The theme probably needs to be updated to support two Category options. One for single-blog where no profile is expected, and one for Author+Category. The BlogController should also have a method for Category where no author slug is expected.
I recall something like this being in there in the past, but it was removed. There used to be two different methods: Category and AuthorCategory, I think.

I think it safe to close, if I"m still missing something we can open new issue.


Navbar covers upper part of memo after scroll

Describe the bug
After editing and saving memo, UI scrolls to memo but navbar covers upper part of memo. Maybe we need to add offset to scroll
Steps to reproduce

Write memos so much that you have to scroll to them
Edit one of earlier memos and click save
UI scrolls to memo to take you back to it
Memo gets aligned to top of screen, but navbar covers upper part of it

Screenshots or additional context

Fixed in the recent version.


Genie was deleted from AUR and i can't find any mirrors to it

Does anyone have a backup of it?

Thx. I'll close the issue.


Bluetooth: L2CAP: Minor fixes in L2CAP Connection Result definitions

Codecov Report

Merging #6799 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6799      +/-   ##
==========================================
- Coverage   54.64%   54.64%   -0.01%
==========================================
  Files         447      447
  Lines       42587    42587
  Branches     8040     8040
==========================================
- Hits        23273    23271       -2
- Misses      16083    16084       +1
- Partials     3231     3232       +1

Impacted Files
Coverage Δ

boards/posix/native_posix/timer_model.c
98.21% <0%> (-1.79%)
:arrow_down:

kernel/posix/pthread.c
69.5% <0%> (-0.5%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3892d9...8c83e11. Read the comment docs.


How to build qt shared library ?

How to build qt shared library ?
My project
the app works perfectly if I build it as an app.
TEMPLATE = app
If I create a shared lib with same code the code not gives result.
I changed TEMPLATE = app to TEMPLATE = lib and I compile the same code. But , the result comes an error.
code not give result as a qt shared lib
wifimouse app fully build with qt.
Source code of wifimouse server application
I install and run wifimouse app in my computer it works perfectly and all the options are works smoothly.
But, If I compile the same code as a shared lib in my computer it not works properly.
For example ; In wifimouse application there is an option for brightness controling
Brightness code

error comes like this. But , it works smoothly as a TEMPLATE = app.
Problem with qt in getting outputs.
My project
I want to get the cpu usage , ram usage ,process list and app list with qt.
In Windows

I am getting ram usage from this code.
But app list , cpu usage and process outputs are not showed.
In linux

In linux the cpu usage output not showed.
In Mac

In mac the app list output not showed.
All the code works perfectly if I build it as an app.
Why this problem occured ?

My apologies but I think your question would be better answered in the Qt Forum. This repository is for sample code of the ArcGIS Runtime SDK for Qt and it does not appear that you're using the SDK anywhere in your project.

thanks for your reply!!!


Fix fluentd-elasticsearch doc

What this PR does / why we need it:
Impossible to read the config table
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): None
Special notes for your reviewer:

Thanks for your pr! I believe the circleci build is failing, because you need to bump the version to 0.6.1 in Chart.yaml. Its a bit confusing, but even documentation fixes require bumping the version number.

Already fixed with: https://github.com/kubernetes/charts/pull/6067/


Operator token unrecognized when right-hand side is on new line

Open this file in Nu: https://github.com/bryanedds/Nu/blob/master/Nu/Nu/World.fs#L39
Try to over over the operator with its right-hand argument on a new line:

Try to reproduce it on https://github.com/Microsoft/visualfsharp/pull/2298

Fixed in https://github.com/Microsoft/visualfsharp/pull/2298


feat(injector): set k8s.pod.uid and k8s.container.name ootb

Well I honestly did not expect the PR to go green on the first attempt.


qt5 packages debug versions incorrectly packaged on windows

If one builds qt5-base and qt5-declarative with the x64-windows-static triplet the packages will build successfully, however the cmake packaging files incorrectly refer to release versions of several Qt libraries and dependencies instead of the debug versions resulting in linker errors.
After examining a build.ninja file for a project that attempts to link against qt5 in debug mode several paths and filenames are incorrect:
x64-windows-static\qml (incorrect) vs x64-windows-static\debug\qml (correct)
x64-windows-static\lib (incorrect) vs x64-windows-static\debug\lib (correct)

(incorrect)
Qt5QmlWorkerScript.lib
Qt5QuickControls2.lib
lmdb.lib
Qt5QuickTemplates2.lib
Qt5Quick.lib
Qt5QmlModels.lib
Qt5Qml.lib
Qt5Gui.lib
freetype.lib
bz2.lib
libpng16.lib
zlib.lib
Qt5Network.lib
Qt5Core.lib
icuin.lib
icuuc.lib
icudt.lib
pcre2-16.lib
libEGL.lib
libGLESv2.lib
translator.lib
preprocessor.lib
icutu.lib
icuio.lib
zstd_static.lib
Qt5Widgets.lib

(correct)
Qt5QmlWorkerScriptd.lib
Qt5QuickControls2d.lib
lmdbd.lib
Qt5QuickTemplates2d.lib
Qt5Quickd.lib
Qt5QmlModelsd.lib
Qt5Qmld.lib
Qt5Guid.lib
freetyped.lib
bz2d.lib
libpng16d.lib
zlibd.lib
Qt5Networkd.lib
Qt5Cored.lib
icuind.lib
icuucd.lib
icudtd.lib
pcre2-16d.lib
libEGLd.lib
libGLESv2d.lib
translatord.lib
preprocessord.lib
icutud.lib
icuiod.lib
zstd_staticd.lib
Qt5Widgetsd.lib

It's a cmake project:
find_package(QT REQUIRED NAMES Qt6 Qt5 )
find_package(Qt${QT_VERSION_MAJOR} COMPONENTS Core Gui Qml REQUIRED)

...

target_link_libraries(my_target PUBLIC Qt::Core)

When I compile using the qt6 ports then both release and debug versions are correct, the problem only happens when using the qt5 ports.

Related PR https://github.com/microsoft/vcpkg/pull/35931.


1.3.2 dependencies tracked elsewhere

Entire list: https://github.com/bithyve/internal-docs/issues?q=assignee%3AAliMeer+is%3Aopen+label%3A1.3.2

@AliMeer - we don't understand how to close this one. You will have to close this.

These were tasks for 1.3.2 release, which have been completed. Closing.


Un-mute not working correctly

When Spotifree detects that the ad has finished, the volume goes back up but only to about 15%, which is almost unhearable.
This is only started happening recently (maybe due to a Spotify update?). I already tried updating Spotifree to the latest version

The next update is completely rewritten. I think it will fix this.
Just wait until it gets published.

Hmm this is weird. I completely removed spotifree and spotify using Appcleaner. Rebooted. Installed spotify. Played a couple of songs and suddenly the ads get muted, out of nowhere. No spotifree app or service running, it's uninstalled

Have you already tried terminating every Spotifree process using the Activity Monitor?

Indeed, removed every trace and rebooted and checked activity monitor. Will check it out some more tonight. Strange wizardry. Any things I can check to see if spotifree is still involved, besides checking the process?
ps aux | grep spotifree shows that there are no processes running, and still spotify gets muted.

So my ads still get muted 😐Summary of the things I did:

Removed Spotify and Spotifree (including every trace in /Library, using Appcleaner app)
Rebooted a dozen times. Did a fresh install of Spotify.
Checked activitymonitor for suspicious processes, none are spotify or spotifree related. Don't see anything with ps aux | grep spotifree too.
Did a sudo find / -name '*spotifree*' and sudo find / -name '*eneas*' to find files left on my hdd, none found.
Never tried any other mute app (do other mute apps exist?).

Is there some way that I can check if the 0.3s polling is still done, to find the cause which "thing" is dispatching the mute spotify action? Could it be a Spotify bug?

Haven't heard of any such bugs or features in Spotify, unfortunately.
Can we look at your process list? Something must be hiding there. ps aux output would do.

Ok I figured out the issue. I have a mac mini at my parent's place with spotify installed and logged into my account. Spotifree was running there too.
So when I play spotify music at work on my macbook pro without spotifree installed, the ads would get muted by the Spotifree app running at my parents place on the mac mini.
Thanks man, I'll wait until the next update of Spotifree to fix this volume issue that is set to 1/5 after un-mute. :-)


Generalize the item geometry type on the Sqlalchemy backend

Problem
I ran into some trouble when ingesting STAC items that do not have a simple Polygon geometry through the sqlalchemy backend.
The geometry field is required to be a Polygon, although the STAC Item spec specifies the field as the more general GeoJSON Geometry, which includes other types such as MultiPolygon.
Example STAC Item with MultiPolygon
I came across this problem when trying to ingest STAC Item data from the usgs-landsat public bucket.
In this catalog, there are some items that have the MultiPolygon type. For instance, Landsat scenes at the edge of the WGS84 projection are split into two. Here is a link to an example:
s3://usgs-landsat/collection02/level-2/standard/etm/2021/092/013/LE07_L2SP_092013_20211007_20211104_02_T2/LE07_L2SP_092013_20211007_20211104_02_T2_SR_stac.json
Proposed solution
I would like to propose to change the geometry field to MultiPolygon or even GeometryCollection. This would still be matching the STAC spec.
This would presumably require a change in the field definition, an additional migration, and maybe a data-migration if the field content needs to be altered after this change. For instance, converting existing Polygon data to MultiPolygon.
Related
The change of the field type was previously proposed, but the PR was mixed with a few other changes that were unrelated, so I am opening the discussion again. See https://github.com/stac-utils/stac-fastapi/pull/184

I agree that the geometry type used by sqlalchemy backend needs to better align with the spec.  GeometryCollection type would probably be best because it gives the most flexibility.  My one concern is I'm not sure if there are performance drawbacks to using a GeometryCollection type over a more explicit type like MultiPolygon or Polygon (currently); that might be worth exploring before we make a change.
For what its worth, stac-pydantic recently added support for specifying GeometryCollection in search requests (https://github.com/stac-utils/stac-pydantic/pull/102), this change will be shipped in the next stac-pydantic release.

If I understood correctly the STAC spec and the geoalchemy2 code, the only correct way of implementing this would be to have a geoalchemy2.types.Geometry that defaults to geometry_type='GEOMETRY'. That Geometry can hold any of the seven valid types for Geometry.
If we chose Polygon, MultiPolygon or even GeometryCollection, the implementation will be offending the specification, so even if it is a performance detriment, a reference implementation should offer all the accepted types.

Closed with #299


feat: added nix shell declaration

Please follow this template, if applicable.
Description
Added a nix shell declaration. This allows anybody using nixos or nix on their system to just cd into the directory and be ready to go.
Usage
cd eww
nix-shell

rustup install nightly  # optional, this is why I didn't do the entire declaration
cargo build --release

This is a "nice to have" addition for anybody on nixos who would have to worry about the build inputs.
Checklist
Please make sure you can check all the boxes that apply to this PR.

[-] All widgets I've added are correctly documented.
[-] The documentation in the docs/content/main directory has been adjusted to reflect my changes.
[-] I used cargo fmt to automatically format all code before committing

All "not applicable"?

While i find this feature pretty useful, having to still manually install rustup, rustc-nightly through rustup is not how nix-shell is supposed to work.
You should make the nix expression pull in rust-nightly for the user, so that

it's reproducible - nightly gets updated quite often, it should be pinned.
your average nixos joe (does he even exist lol) doesn't have to install rust
it also works with nix-shell --pure
you can use mozilla's nixpkgs colllection for that: https://github.com/mozilla/nixpkgs-mozilla, they offer a rust nightly tarball.

Does he even exist lol
No he does not

Have replaced rustup with the mozilla nightly overlay rust

node is also a dependency for updating the docs, not sure how that should be handled as it's optional for 90% of people.

node is also a dependency for updating the docs, not sure how that should be handled as it's optional for 90% of people.

it is fine to add nodejs in nativeBuildInputs

For people who don't care about getting a development environment but instead want a package, use the NUR, with the package attribute nur.repos.fortuneteller2k.impure.eww.

This is the nix-shell i've been using for the pass weeks:
with import <nixpkgs> { };

let
  moz_overlay = import (builtins.fetchTarball
    "https://github.com/mozilla/nixpkgs-mozilla/archive/master.tar.gz");
  nixpkgs = import <nixpkgs> { overlays = [ moz_overlay ]; };
in mkShell rec {
  name = "eww";

  buildInputs = [
    glib
    cairo
    atk
    gdk-pixbuf
    pango
    gtk3
    nixpkgs.latest.rustChannels.nightly.rust
    zola
    nodejs
  ];
  nativeBuildInputs = [ pkgconfig wrapGAppsHook ];

  RUST_SRC_PATH = "${nixpkgs.rust.packages.stable.rustPlatform.rustLibSrc}";
}

(sort of also putting this here, that if i reclone i can still find my shell.nix version, and it incorporates some of the requested changes)

it is fine to add nodejs in nativeBuildInputs
newest version uses deno anyways

Sorry, I've had terrible pain in my hands for a couple of months. I'll get to it in the next week or so.

@legendofmiracles incorporated your final nix declaration. My hands are currently pretty useless owing to inflammation so I won't be able to make many more changes in the immediate future.

this has now been implemented in #205 instead! Still, absolutely appreciate the time investment here! Thanks a ton!


Failed to import diffusers.loaders.unet because of the following error (look up to see its traceback):

Traceback (most recent call last):
File "F:\ComfyUI\ComfyUI\nodes.py", line 2035, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "F:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-BrushNet_init.py", line 1, in
from .brushnet_nodes import BrushNetLoader, BrushNet, BlendInpaint, PowerPaintCLIPLoader, PowerPaint, CutForInpaint
File "F:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-BrushNet\brushnet_nodes.py", line 15, in
from .brushnet.brushnet import BrushNetModel
File "F:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-BrushNet\brushnet\brushnet.py", line 20, in
from .unet_2d_blocks import (
File "F:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-BrushNet\brushnet\unet_2d_blocks.py", line 36, in
from diffusers.models.transformers.dual_transformer_2d import DualTransformer2DModel
File "F:\ComfyUI\python_embeded\Lib\site-packages\diffusers\models\transformers_init_.py", line 13, in
from .prior_transformer import PriorTransformer
File "F:\ComfyUI\python_embeded\Lib\site-packages\diffusers\models\transformers\prior_transformer.py", line 9, in
from ...loaders import PeftAdapterMixin, UNet2DConditionLoadersMixin
File "", line 1229, in _handle_fromlist
File "F:\ComfyUI\python_embeded\Lib\site-packages\diffusers\utils\import_utils.py", line 843, in getattr
module = self._get_module(self._class_to_module[name])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "F:\ComfyUI\python_embeded\Lib\site-packages\diffusers\utils\import_utils.py", line 855, in _get_module
raise RuntimeError(
RuntimeError: Failed to import diffusers.loaders.unet because of the following error (look up to see its traceback):
cannot import name 'shard_checkpoint' from 'transformers.modeling_utils' (F:\ComfyUI\python_embeded\Lib\site-packages\transformers\modeling_utils.py)
Cannot import F:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-BrushNet module for custom nodes: Failed to import diffusers.loaders.unet because of the following error (look up to see its traceback):
cannot import name 'shard_checkpoint' from 'transformers.modeling_utils' (F:\ComfyUI\python_embeded\Lib\site-packages\transformers\modeling_utils.py)

after update hunyuan video reequipment, error show.
accelerate >= 1.2.1
diffusers >= 0.31.0
transformers >= 4.47.0
jax >= 0.4.28


NodeFlags Needs Expansion

As per https://github.com/Microsoft/TypeScript/pull/7952#discussion_r58987334, we have almost exhausted all possible node flags. While I believe @rbuckton is shifting them around for transforms, I don't know the extent to which using/reusing would be a breaking change.

Is this still an issue? It looks like the NodeFlags enum is changed and the largest is 1 << 18.
So I think this one can be closed?

Yep, Anders refactored these out a while ago. Thanks for pointing it out - one fewer open issue 😄


command: Prevent re-writing settings in case of local option

This is a follow-up of #3042.

LGTM. I'd also suggest a small refactoring of SetGlobalOptionNative() as a follow-up: deal with local at the beginning and be done with it, before dealing with global:
if local {
	MainTab().CurPane().Buf.SetOptionNative(option, nativeValue)
	return nil
}

Upon a fresh look, it's also kinda weird that we check (and "properly handle") a local option inside a function named SetGlobalOptionNative(), as a special case, rather than checking that in the caller function. Or are we checking that both here and in the caller function? (I'm afraid that's what we actually do, and also I'm afraid that we cannot simply remove this redundancy, as it would break something.)
But that's just a lyrical note.

But that's just a lyrical note.

What about renaming SetGlobalOption() into SetOption(), but still exporting it as SetGlobalOption() via Lua for the plugins?
Then the call can be moved to the calling function and would fit there more. The native value can be obtained with the help of config.DefaultCommonSettings() as it's done in ResetCmd().
The only problem and most probably breaking compatibility then is the fact that the exported plugin function SetGlobalOptionNative() doesn't check for locals any longer.
So the problem was to export it as "Global" with the reference as with > set, while > set can be used to change locals too. :(
Sh**, sometimes it could be easier...


Newly created migration file

Laravel Version: 7.10.2
PHP Version: 7.4.4
Database Driver & Version:
mariadb-10.4.12-winx64

Description:
After using php artisan make:migration migration_name --create='new_migration' --table='new_migration' file gets generated within content such below:
function up()
{
Schema::create(''new_migration'', ...
means that the argument contains PHP string related syntax error
Steps To Reproduce:
Probably at the file content writing stage user provided quote signs should be ignored and proper code generated quotes should be used to prevent additional quote appearing.

As far as I know Windows does not support single quotes in command line, you should use double quotes.

Here is what I mean and yes I'm using Windows 10:
https://youtu.be/hcIg2aRaYQk


Create dim_purchaseable model

Description/Context

As part of https://github.com/mitodl/ol-data-platform/issues/1325, we need a dimensional table to Include information about elements of content and
services that can be sold for >=$0 (e.g. programs, course runs, bootcamps,
subscriptions, etc.)
Plan/Design

Create a dim_purchaseable/product model including the following fields:
id - hashed primary key
product_readable_id
product_name
product_type
product_price
more attributes?
The data sources will include MITx Online, xPro for now

@blarghmatey Kate and I discussed product_price in this table. @KatelynGit thinks the price should go to tfact_purchase since it's numeric and measurable. I think it should go to dim_purchaseable/product table since it is an attribute of a product, especially since the price is the same across users' transactions. That way we would avoid redundancy and can easily query the products with no purchase history. I just wanted us to be on the same page. What do you think?

I think that it should go in both places, treating the dim_purchaseable as a type 2 SCD, since price isn't static.

I think that it should go in both places, treating the dim_purchaseable as a type 2 SCD, since price isn't static.

That makes sense. We can create dim_purchaseable as Slowly Changing Dimension Type 2 to keep the changes. Currently, the table is loaded as a full refresh in airbyte. Do we need to modify the staging table to capture the changes in dbt instead? The price isn't changed that often as far as I can tell though


Issue: Search bar is not responsive in small screens

I have noticed this issue in all small screen devices. Could you please fix it.

If u need to fix this feel free to assign me. I will start to work.
Thanks! Cheers🥂
Happy coding

sure ,
make sure you star repo and follow me on github

@basavarajakj please assign issue to me


[FEATURE] Weights of DINO fine-tuned on Imagenet?

Currently, only headless weights are available for DINO ViTs. It'd be good if the weights of a version fine-tuned for Imagenet was also added. I don't know if Facebook actually published these weights, but they do have experiments on Imagenet DINO in their paper.

Meta released a linear projection head for the DINOv2. We will be able to load it if we modify the safetensor weights.

if we modify the safetensor weights.

What do you mean?

The official DINOv2 ships the weight of backbone and head separately. We need to concat them into one weights.

Similar Issues:

[FEATURE] DINOv2 pretrained vit weights

Are there weights for ViT-B that was only trained on ImageNet1k?

[FEATURE] Model requests on dino_vit

ImageNet 1K pretrained weights


Cannot create user: artemis_admin

Describe the bug
When I run at first time project, this show error below
Caused by: org.springframework.web.client.HttpClientErrorException$Forbidden: 403 Forbidden: "{"servlet":"Stapler","message":"No valid crumb was included in the request","url":"/securityRealm/createAccountByAdmin","status":"403"}"
To Reproduce

Go to '...'
Click on '...'
Scroll down to '...'
See error

Expected behavior
this must be successfuly and can login successfuly
Screenshots

Which version of Artemis are you seeing the problem on?
6.7.0
What browsers are you seeing the problem on?
Other (specify in "Additional context")
Additional context
No response
Relevant log output
No response

I am fixed.
I was config incorrect secret-push-token in continuous-integration config


Dart 2.4.0 Debug broken

Connecting to the observatory's websocket requires the secret key (randomly generated):
Observatory listening on http://<IP_ADDRESS>:16702/gO1rif8XI7g=/
I'm on Dart 2.4.0 and building the plugin has been... an adventure in failure. Editing the js directly to a built string (e.g. ws://<IP_ADDRESS>:16702/gO1rif8XI7g=/ws) was enough to restore debugging.

Hey John, this plugin isn't actively maintained anymore; I've updated the readme to reflect that: https://github.com/dart-atom/dart/blob/master/README.md#note.

Sounds good (but sad). I'm usually 100% in Vim with the dart-language-server and Nate's lsc plugins, but windows is a PITA :)


Bosch C Harness

[x]  which car is this for? 2023 Honda Pilot, 2023 CR-V, 2023 Accord
[x]  schematic - Push to neo repo once confirmed working
[x]  beta sent to tester
[ ]  in shop
[ ]  Added to openpilot docs

Reported on Discord by user "Kevmaninc". Unknown connector part number. Will have to grab wiring diagram from Honda Techinfo. Unknown camera module. No marking on underside of camera. Will assign proper harness name once more information is obtained.

This is what the connector looks like.

@Kevmaninc Can you please provide more clear photos of both front and back of the connector? Usually you can see markings in the plastic that can help determine the part number.

This TE connectivity connector looks like it may be a close match, https://www.digikey.com/en/products/detail/te-connectivity-amp-connectors/1318386-2/9925408

This TE connectivity connector looks like it may be a close match, https://www.digikey.com/en/products/detail/te-connectivity-amp-connectors/1318386-2/9925408

It’s close but when you take a closer look, the distance between the top and bottom pin holes is a bit further apart.

I think I found the number you need for the part. See the pics

Here is a link to Chinese site I found for that connector.
https://www.yixiandianzi.com/lianjieqi/309.html

GT25-16DS-HU

Yes, this appears to be the correct part number. This connector can be purchased on Mouser, no need for a Chinese clone.

OK so what you are saying is that I just need a male and female version of this and I should wire them up myself? I noticed that the old pilot connector has 11 wires while the new one has only 6. I guess I just have to wire them up to the correct slots and it should work?

Sharing @Kevmaninc 's picture of the camera from discord for documentation

@Kevmaninc i also own a 2023 Pilot Touring, I was wondering if you’ve found something (adapter) to help me connect my comma 3 to my vehicle. I currently also have the Nidec harness that isn’t a proper fit.

So yeah we actually got the connector made and working, however the software is having issues so we are still working on figuring this out.Sent from my iPhoneOn Jul 14, 2023, at 8:08 PM, Mr-Peter-Ng @.***> wrote:
@Kevmaninc i also own a 2023 Pilot Touring, I was wondering if you’ve found something (adapter) to help me connect my comma 3 to my vehicle. I currently also have the Nidec harness that isn’t a proper fit.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Would you be kind enough to share a link on where I could get the correct connector & possibly some photos of your current wiring so I’d be able to rig it up myself. Unless you have an extra I could purchase that’s already pre wired. Sent from my iPhoneOn Jul 15, 2023, at 4:54 AM, Kevmaninc @.> wrote:
So yeah we actually got the connector made and working, however the software is having issues so we are still working on figuring this out.Sent from my iPhoneOn Jul 14, 2023, at 8:08 PM, Mr-Peter-Ng @.> wrote:
@Kevmaninc i also own a 2023 Pilot Touring, I was wondering if you’ve found something (adapter) to help me connect my comma 3 to my vehicle. I currently also have the Nidec harness that isn’t a proper fit.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

The wire is not available for purchase yet because there is no official support. If you want to join the testing team to see if we can get this thing running maybe vanillagorilla from the comma team can send you the wire and see if between my pilot and your pilot we can get things running. Do you have comma 3?Sent from my iPhoneOn Jul 15, 2023, at 9:10 AM, Mr-Peter-Ng @.> wrote:
Would you be kind enough to share a link on where I could get the correct connector & possibly some photos of your current wiring so I’d be able to rig it up myself. Unless you have an extra I could purchase that’s already pre wired. Sent from my iPhoneOn Jul 15, 2023, at 4:54 AM, Kevmaninc @.> wrote:
So yeah we actually got the connector made and working, however the software is having issues so we are still working on figuring this out.Sent from my iPhoneOn Jul 14, 2023, at 8:08 PM, Mr-Peter-Ng @.***> wrote:
@Kevmaninc i also own a 2023 Pilot Touring, I was wondering if you’ve found something (adapter) to help me connect my comma 3 to my vehicle. I currently also have the Nidec harness that isn’t a proper fit.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Yes I’ll reach out to vanillagorilla Also yes I have the comma 3Sent from my iPhoneOn Jul 15, 2023, at 11:55 AM, Kevmaninc @.> wrote:
The wire is not available for purchase yet because there is no official support. If you want to join the testing team to see if we can get this thing running maybe vanillagorilla from the comma team can send you the wire and see if between my pilot and your pilot we can get things running. Do you have comma 3?Sent from my iPhoneOn Jul 15, 2023, at 9:10 AM, Mr-Peter-Ng @.> wrote:
Would you be kind enough to share a link on where I could get the correct connector & possibly some photos of your current wiring so I’d be able to rig it up myself. Unless you have an extra I could purchase that’s already pre wired. Sent from my iPhoneOn Jul 15, 2023, at 4:54 AM, Kevmaninc @.***> wrote:
So yeah we actually got the connector made and working, however the software is having issues so we are still working on figuring this out.Sent from my iPhoneOn Jul 14, 2023, at 8:08 PM, Mr-Peter-Ng @.***> wrote:
@Kevmaninc i also own a 2023 Pilot Touring, I was wondering if you’ve found something (adapter) to help me connect my comma 3 to my vehicle. I currently also have the Nidec harness that isn’t a proper fit.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

Hopefully between our two Hondas and the comma team we can get it running.Sent from my iPhoneOn Jul 15, 2023, at 3:33 PM, Mr-Peter-Ng @.> wrote:
Yes I’ll reach out to vanillagorilla Also yes I have the comma 3Sent from my iPhoneOn Jul 15, 2023, at 11:55 AM, Kevmaninc @.> wrote:
The wire is not available for purchase yet because there is no official support. If you want to join the testing team to see if we can get this thing running maybe vanillagorilla from the comma team can send you the wire and see if between my pilot and your pilot we can get things running. Do you have comma 3?Sent from my iPhoneOn Jul 15, 2023, at 9:10 AM, Mr-Peter-Ng @.***> wrote:
Would you be kind enough to share a link on where I could get the correct connector & possibly some photos of your current wiring so I’d be able to rig it up myself. Unless you have an extra I could purchase that’s already pre wired. Sent from my iPhoneOn Jul 15, 2023, at 4:54 AM, Kevmaninc @.***> wrote:
So yeah we actually got the connector made and working, however the software is having issues so we are still working on figuring this out.Sent from my iPhoneOn Jul 14, 2023, at 8:08 PM, Mr-Peter-Ng @.***> wrote:
@Kevmaninc i also own a 2023 Pilot Touring, I was wondering if you’ve found something (adapter) to help me connect my comma 3 to my vehicle. I currently also have the Nidec harness that isn’t a proper fit.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

@vanillagorillaa hello, my name is Peter I’m interested with getting into contact to possibly joining the comma beta testing group to help provide feedback for the comma 3 on my 2023 Honda Pilot Elite. But first I’m looking at acquiring the proper harness/adapter.

Peter please join the DISCORD channels and friend me on Discord: @Kevmaninc

hey hey - any update on this? thinking of buying a ‘23 accord for Openpilot

As of now COMMA is not prioritizing this and it is their lowest priority.
At this point it is unknown as to when or if they can get this up and
running.
On Thu, Sep 7, 2023 at 5:32 PM Omar @.***> wrote:

hey hey - any update on this? thinking of buying a ‘23 accord for Openpilot
—
Reply to this email directly, view it on GitHub
https://github.com/commaai/openpilot/issues/28061#issuecomment-1710795521,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7QMZB3Y7S7PMV7LNFMHOI3XZI4PRANCNFSM6AAAAAAXPQGWLA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Is anyone working on the port for these vehicles? Are there any routes with rlogs I can take a look at?

Is anyone working on the port for these vehicles? Are there any routes with rlogs I can take a look at?

Sent you routes via DM a while ago

See discussion about the port here: https://github.com/commaai/openpilot/discussions/29825

are you needing any one else to test it on a 2023 honda accord? I have one and I would love to test it at my own risk and help out with the process. I have a background in both automotive and tech. I would love to help if you would allow me the opportunity. I am very hardware savy.

Let me know if anyone needs testing done or support for the 2023 CR-V Hybrid Touring, I am more than happy to help in any way I can to get this car ported and supported.

I’m not quite sure testing is the issue, I think we just need to find more people to help solve the software and figure out what’s wrong with the code & why it’s continually being rejected by the vehicle, & all the dashboard error lights. Until this is solved, I don’t think having more vehicles will make a difference. I will say the new refreshed 2022 civic has the same interior steering wheel & was updated to the new body style by Honda & currently that is the only known vehicle to work with the newest Hondas. Of the new refreshed/redesigned generations of pilots, accords & crv’s, Civic is the only known vehicle to work with openpilot.

I, too, just got a new car. I was driving a 2016 Civic and loved this add-on, and I just got an Accord 2024; if you need any testers, please feel free to let me know. I'm happy to test.

I too have a 2023 honda accord hybrid touring, and a comma 3x, would really love to help crack the code get this one running if someone can catch me up to speed

Logs from a test user show that Honda is now using CAN-FD on the radar bus. This will mean that either a Red Panda is needed (if using a comma 3), or a 3X will be needed.
This resolves the unknown cause of the vehicle dashboard alerts. I will move this new harness into production and will have on the shop for purchase in the coming weeks.

@vanillagorillaa
Is the plan to still add the harness to production or is this still being worked?  Thanks

I'm getting a CR-V 2024 and will test out the 3X on that soon.

i'm getting a stepwgn 2022 use new Bosch camera , how can i get the cable?

I'm getting a CR-V 2024 and will test out the 3X on that soon.

@akshat-ja Were you able to get it to work?

For everyone following along at home, I don't forsee the bosch-c being added to the shop in the near future but we have made some fun discoveries and several people have successfully built their own harness and got the 11th gen accord running with the bosch-c harness. It seems the pilot is also functional.
I documented some things like how to build the harness here https://github.com/commaai/openpilot/wiki/Honda-Bosch‐C
I am selling some of the connectors I built on the comma discord @Bensoncheong626 and whoever else is interested though I am not sure if your car is actually using the newest bosch setup.

hell yeah brother!! I will have to build my own harnesss then if someone
can point me in the right direction with any parts I may need or any
instructions if available, I would love to get my 2023 honda accord hybrid
touring up and running!! my comma x has been sitting mounted in the car
since i got it in august last year...havent fully completed the install due
to no harness. If anyone can give me a few pointers I will be eternally
grateful!!!
thank you!!
Jonathan Willemain
@.***
On Sun, May 5, 2024, 02:32 tomngu96 @.***> wrote:

For everyone following along at home, I don't forsee the bosch-c being
added to the shop in the near future but we have made some fun discoveries
and several people have successfully built their own harness and got the
11th gen accord running with the bosch-c harness. It seems the pilot is
also functional.
I documented some things like how to build the harness here
https://github.com/commaai/openpilot/wiki/Honda-Bosch‐C
I am selling some of the connectors I built on the comma discord
@Bensoncheong626 https://github.com/Bensoncheong626 and whoever else is
interested though I am not sure if your car is actually using the newest
bosch setup.
—
Reply to this email directly, view it on GitHub
https://github.com/commaai/openpilot/issues/28061#issuecomment-2094651023,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDDDIRC7XGBD7RJO77XRMT3ZAXG6JAVCNFSM6AAAAAAXPQGWLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUGY2TCMBSGM
.
You are receiving this because you commented.Message ID:
@.***>

@tomngu96 How much are you selling for? I am not on the discord but I am interested for making comma work on my 2023 CR-V

@Jgw868 Here's the guide I created with pictures, videos, and a parts/tools list so that anyone can make their own if they want https://github.com/commaai/openpilot/wiki/Honda-Bosch‐C
@shahrk I've emailed you so as to not have an unrelated and long discussion on this issue. The synopsis is $100 to match comma's price. I'll give steep discounts to people who've donated to the cart port before today or who have contributed to comma/op

@tomngu96 Awesome, thanks for the info! I think I donated $100 to the
gofundme for the port and i think it's worth every penny
On Sun, May 5, 2024, 05:04 tomngu96 @.***> wrote:

@Jgw868 https://github.com/Jgw868 Here's the guide I created with
pictures, videos, and a parts/tools list so that anyone can make their own
if they want
https://github.com/commaai/openpilot/wiki/Honda-Bosch‐C
@shahrk https://github.com/shahrk I've emailed you so as to not have an
unrelated and long discussion on this issue. The synopsis is $100 to match
comma's price. I'll give steep discounts to people who've donated to the
cart port before today or who have contributed to comma/op
—
Reply to this email directly, view it on GitHub
https://github.com/commaai/openpilot/issues/28061#issuecomment-2094697081,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDDDIREETYFRVSQN6GISG3TZAXY2JAVCNFSM6AAAAAAXPQGWLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUGY4TOMBYGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

For everyone following along at home, I don't forsee the bosch-c being added to the shop in the near future but we have made some fun discoveries and several people have successfully built their own harness and got the 11th gen accord running with the bosch-c harness. It seems the pilot is also functional.
I documented some things like how to build the harness here https://github.com/commaai/openpilot/wiki/Honda-Bosch‐C
I am selling some of the connectors I built on the comma discord @Bensoncheong626 and whoever else is interested though I am not sure if your car is actually using the newest bosch setup.

Is there any still available?
I'm looking for hardness for my Honda Odyssey 2024
I'm not on discord.

I believe the odyssey is not bosch c yet but could be wrong. I believe at
least the 23 odyssey is a bosch A from chatting with someone on discord
Here's an odyssey thread
https://github.com/commaai/openpilot/discussions/2349?sort=new#discussioncomment-8248688
You can send pictures of your harness to me on discord or via email and I
can try to help steer you in the right direction. I prefer discord as thats
also where you'll likely find people with odysseys
My email is my github name @gmail.com
On Mon, Jul 8, 2024 at 10:07 AM EfrB @.***> wrote:

For everyone following along at home, I don't forsee the bosch-c being
added to the shop in the near future but we have made some fun discoveries
and several people have successfully built their own harness and got the
11th gen accord running with the bosch-c harness. It seems the pilot is
also functional.
I documented some things like how to build the harness here
https://github.com/commaai/openpilot/wiki/Honda-Bosch‐C
I am selling some of the connectors I built on the comma discord
@Bensoncheong626 https://github.com/Bensoncheong626 and whoever else is
interested though I am not sure if your car is actually using the newest
bosch setup.
Is there any still available?
I'm looking for hardness for my Honda Odyssey 2024
I'm not on discord.
—
Reply to this email directly, view it on GitHub
https://github.com/commaai/openpilot/issues/28061#issuecomment-2214729476,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BHX2HW3XODONOL7423FAQVLZLLBMZAVCNFSM6AAAAAAXPQGWLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUG4ZDSNBXGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

I believe the odyssey is not bosch c yet but could be wrong. I believe at
least the 23 odyssey is a bosch A from chatting with someone on discord
Here's an odyssey thread
https://github.com/commaai/openpilot/discussions/2349?sort=new#discussioncomment-8248688
You can send pictures of your harness to me on discord or via email and I
can try to help steer you in the right direction. I prefer discord as thats
also where you'll likely find people with odysseys
My email is my github name @gmail.com
On Mon, Jul 8, 2024 at 10:07 AM EfrB @.***> wrote:

For everyone following along at home, I don't forsee the bosch-c being
added to the shop in the near future but we have made some fun discoveries
and several people have successfully built their own harness and got the
11th gen accord running with the bosch-c harness. It seems the pilot is
also functional.
I documented some things like how to build the harness here
https://github.com/commaai/openpilot/wiki/Honda-Bosch‐C
I am selling some of the connectors I built on the comma discord
@Bensoncheong626 https://github.com/Bensoncheong626 and whoever else is
interested though I am not sure if your car is actually using the newest
bosch setup.
Is there any still available?
I'm looking for hardness for my Honda Odyssey 2024
I'm not on discord.
—
Reply to this email directly, view it on GitHub
https://github.com/commaai/openpilot/issues/28061#issuecomment-2214729476,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BHX2HW3XODONOL7423FAQVLZLLBMZAVCNFSM6AAAAAAXPQGWLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUG4ZDSNBXGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

You're right. It will need the Bosch A with some software adjustments.


[feat] Add Reentrancy mechanism

More details can be found https://github.com/Tochemey/goakt/discussions/320

closing this issue for the meantime. I can reopen it when the current feature cannot really cater for this use case.


Ron comments

You can find the corrections for my comments, please review @shaharke

Merged. Closing this PR.


Makefile: add target for release tarball

Add a target to automatically create the vendor tarball and the extra
files. This can only be used on a version which has not the -dev suffix
to prevent user errors.

@mheon @baude PTAL


SASS partials are compiled on make

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:
When using sass partials electron-forge start works properly but electron-forge make prints some errors as it seems to try to compile the partials as well as the main files.
Note: the make process finish successfully althought the errors appear.

Console output when you run electron-forge with the environment variable DEBUG=electron-forge:*. (Instructions on how to do so here). Please include the stack trace if one exists.
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
  electron-forge:lifecycle Process Started: Checking your system +0ms
  electron-forge:lifecycle Process Succeeded: Checking your system +20ms
  electron-forge:runtime-config setting key: verbose to value: false +11ms
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
  electron-forge:lifecycle Process Started: Resolving Forge Config +0ms
  electron-forge:project-resolver searching for project in: /Users/adria/Desktop/test +2ms
  electron-forge:project-resolver electron-forge compatible package.json found in /Users/adria/Desktop/test/package.json +7ms
  electron-forge:lifecycle Process Succeeded: Resolving Forge Config +6ms
We need to package your application before we can make it
  electron-forge:lifecycle Process Started: Preparing to Package Application for arch: x64 +2ms
  electron-forge:project-resolver searching for project in: /Users/adria/Desktop/test +0ms
  electron-forge:project-resolver electron-forge compatible package.json found in /Users/adria/Desktop/test/package.json +0ms
  electron-forge:packager packaging with options { asar: false,
  overwrite: true,
  afterCopy: [ [Function], [Function], [Function], [Function] ],
  afterExtract: [],
  dir: '/Users/adria/Desktop/test',
  arch: 'x64',
  platform: 'darwin',
  out: '/Users/adria/Desktop/test/out',
  electronVersion: '1.6.2',
  quiet: true } +3ms
  electron-forge:lifecycle Process Succeeded: Preparing to Package Application for arch: x64 +7s
  electron-forge:lifecycle Process Started: Compiling Application +3ms
Failed to compile file: /var/folders/k1/m83wbd_x1vl_0wxjdh_bpm7m0000gn/T/electron-packager/darwin-x64/test-darwin-x64/Electron.app/Contents/Resources/app/src/_otherfile.scss
Error: Undefined variable: "$someColor".
        on line 2 of /stdin
>>   background-color: $someColor;
   --------------------^

  electron-forge:lifecycle Process Succeeded: Compiling Application +2s
  electron-forge:lifecycle Process Started: Preparing native dependencies +1ms
  electron-forge:lifecycle Process Succeeded: Preparing native dependencies +68ms
  electron-forge:lifecycle Process Started: Packaging Application +0ms
  electron-forge:lifecycle Process Succeeded: Packaging Application +6s
Making for the following targets:
  electron-forge:lifecycle Process Started: Making for target: zip - On platform: darwin - For arch: x64 +4ms
  electron-forge:require-search searching [ '../makers/darwin/zip.js',
  '../makers/generic/zip.js',
  'electron-forge-maker-zip',
  'zip',
  '/Users/adria/Desktop/test/zip',
  '/usr/local/lib/node_modules/electron-forge/dist/makers/darwin/zip.js',
  '/usr/local/lib/node_modules/electron-forge/dist/makers/generic/zip.js',
  '/usr/local/lib/node_modules/electron-forge/dist/api/electron-forge-maker-zip',
  '/usr/local/lib/node_modules/electron-forge/dist/api/zip',
  '/Users/adria/Desktop/test/zip',
  '/usr/local/lib/node_modules/electron-forge/dist/api/makers/darwin/zip.js',
  '/usr/local/lib/node_modules/electron-forge/dist/api/makers/generic/zip.js',
  '/usr/local/lib/node_modules/electron-forge/dist/api/node_modules/electron-forge-maker-zip',
  '/usr/local/lib/node_modules/electron-forge/dist/api/node_modules/zip',
  '/Users/adria/Desktop/test/zip' ] relative to /usr/local/lib/node_modules/electron-forge/dist/api +0ms
  electron-forge:require-search testing ../makers/darwin/zip.js +2ms
  electron-forge:require-search testing ../makers/generic/zip.js +1ms
  electron-forge:lifecycle Process Succeeded: Making for target: zip - On platform: darwin - For arch: x64 +8s

What command line arguments are you passing?
This is what I'm running:
DEBUG=electron-forge:* electron-forge make

What does your config.forge data in package.json look like?
Default, I haven't changed anything.
 "config": {
    "forge": {
      "make_targets": {
        "win32": [
          "squirrel"
        ],
        "darwin": [
          "zip"
        ],
        "linux": [
          "deb",
          "rpm"
        ]
      },
      "electronPackagerConfig": {},
      "electronWinstallerConfig": {
        "name": "test"
      },
      "electronInstallerDebian": {},
      "electronInstallerRedhat": {},
      "github_repository": {
        "owner": "",
        "name": ""
      },
      "windowsStoreConfig": {
        "packageName": "",
        "name": "test"
      }
    }
  }

Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem. Using electron-forge init is a good starting point, if that is not the
source of your problem.
Here is a fresh project where electron-forge start works well but electron-forge make prints the error.
Thanks for your time

What happens when you use relative paths for @import?

I've just tried and the same thing happens

Any progress on this?

This issue should be raised upstream at electron-compile.  As of electron-forge 6.0.0 electron-compile is not enabled by default 👍


Add start-index and stop-index assertion for SubqueryExpressionSegment

Hi, we are glad you can fix this issue to become a contributor to Apache Sharding Sphere.
Welcome! 😃
By doing this assignment, you can learn more about how a query SQL is parsed and how to verify the parsing result of a SQL in Apache ShardingSphere.
This issue is to add the parsing assertion for SubqueryExpressionSegment by adding the start-index and stop-index attributes in parsing-result.xml.
It is not difficult, and the following comment also gives you the detailed instruction. BTW, if you need any help, please be free to reply to this one.

How to find the targets to be fixed?

Open class ExpressionAssert and clear the comment of SQLSegmentAssert.assertIs(assertContext, actual, expected) in assertSubqueryExpression.
run SQLParserParameterizedTest
All the SQL cases which have the error assertion results are our targets to be fixed.

How to fix the above assertion results?

Look at the exception log and find the corresponding SQL Case ID and SQL.
Find out the parsing result of this SQL Case ID in ./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml
Calculate the correct start-index and stop-index of and-subquery-expression, between-subquery-expression and subquery-expression segment of this SQL.
Add the calculated start-index and stop-index labels of and-subquery-expression, between-subquery-expression and subquery-expression segment to parsing result of this SQL Case ID, like

            <subquery-expression  start-index="10" stop-index="11" />

Add the correct literal-start-index and literal-stop-index of and-subquery-expression, between-subquery-expression and subquery-expression segment to parsing result of this SQL Case ID when it is necessary, like

            <subquery-expression  literal-start-index="10" literal-stop-index="11" />

Run SQLParserParameterizedTest again to check whether this SQL Case ID does not stay in the list of SQL with  bad assertion result.

Note

What are the definitions of and-subquery-expression, between-subquery-expression, and subquery-expression?
subquery-expression means an expression that contains another query.

For instance, here is a SQL,

SELECT * FROM t_order WHERE user_id = (SELECT user_id FROM t_order_item WHERE id = 10)

The query of SELECT user_id FROM t_order_item WHERE id = 10 is a subquery-expression.

SELECT * FROM t_order WHERE user_id between (select user_id from t_order_item where order_id = 10) and (select user_id from t_order_item where order_id = 12)

This example shows the value of select user_id from t_order_item where order_id = 10 is a between-subquery-expression, on the other hand, select user_id from t_order_item where order_id = 12 is and-subquery-expression.

What is the difference between literal-start-index and start-index?

When a SQL does not contain parameter maker, i.e.,?, this SQL only has one form; Otherwise, you will see two forms of this SQL, i.e, a SQL form filled with parameter and a SQL form only with parameter marks. For instance,
Case1 One SQL without parameter mark,
select * from table where id = 1;

Case2 One SQL with parameter mark,
Original SQL: select * from table where id = ?;
SQL filled with Parameter: select * from table where id = 1;

Replace the parameter mark with the actual parameter will change the position of the segment. Therefore we need to add start-index to represent the start position of a segment for Original SQL, and literal-start-index is used to represent the start position of a segment for SQL filled with Parameter.

This issue is much easier than anyone of this series. :)

i will fix it .


Add --single-file to package command

This allows the package command to produce
a single file for all the packaged assets instead
of an output directory.

Codecov Report

Merging #261 into package will decrease coverage by 0.17%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           package     #261      +/-   ##
===========================================
- Coverage    82.91%   82.73%   -0.18%
===========================================
  Files           17       17
  Lines         1539     1558      +19
  Branches       193      196       +3
===========================================
+ Hits          1276     1289      +13
- Misses         212      218       +6
  Partials        51       51

Impacted Files
Coverage Δ

chalice/utils.py
84.84% <100%> (+5.68%)
:arrow_up:

chalice/cli/__init__.py
55.05% <41.66%> (-0.9%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a5ca14...7f44e86. Read the comment docs.

Working on the codecov now.

@kyleknap I believe I've incorporated all the feedback.


Added option to switch coupling convention

Added feature to switch the convention in JHUGenLexicon

@jdavis36 Please split commit fe19a6f from the rest. I am guessing that the later commits are attempting to fix a CircleCi issue while the first one is actually the only one you are proposing. The later commits add ~1200 files to the repository, which I also find unacceptable. At this point, I would expect us to move to a dedicated storage, where the grids are downloaded instead of being checked out through github. For this reason, I am closing this PR to allow you time to make the modifications without having to notify the full Watchers list.

Hi Ulascan,
Jeff committed the grids to github at my suggestion.  Based on circleci policy changes, the grids can't be generated on the fly anymore because it takes too much time, and the options are basically to either (a) pay >=$15 a month for extra run time, (b) switch to another CI system, or (c) generate the grids once and keep them.  Actually, (c) was the option I originally implemented using the caches, but that got ruined when they changed the cache storage length to basically make them useless.  (b) might have to happen at some point, since circleci is slowly becoming stricter and stricter for free users, but I definitely don't want to spend time on that now, Jeff doesn't, and you probably don't either.
Keeping the files separately from the repo is not a good idea.  We kind of had this in the past, where the reference files were saved as artifacts from a previous build until they changed the storage length for that, but it becomes not maintainable - there needs to be a well defined mapping between the repo version and the reference file version, and that doesn't really exist when the reference files are saved separately.  You can try to hack it, but it doesn't work well.
1200 small files is not that much (although I think we can trim it down a bit, I didn't fully look at the logic but the .lhe, .log, and .dat may not be needed).  The problem really comes when you start committing large files.  I tested, and adding O(1000) small files for a total of 43 MB does not slow down the repo performance.  O(100000) files probably would.
For comparison - in the JHUGenMELA/MELA/test/reference we have 503 files totaling 21 MB.  In the project I'm currently working on, we have 6031 data and reference files for a total of 14 GB, which does slow things down when first checking out the repo or when those files are updated, but is still what we found to be the best option for our use case.  Even there, it doesn't really affect normal git usage not involving those files.
Heshy

Given the new mode of operation with CircleCI, we need to minimize the number of PR and have the reference files included in Git directly, or turn CircleCI checks completely off. Neither is ideal, but we have to move forward with the approach which is least problematic, and so far the proposal from Heshy and Jeff is the best, at the current activity rate. Do we have any alternative practical approach which is somebody is ready to implement on a scale of a ~day. We can also discuss options on the long-term timescale, but this is separate from the immediate needs to make this PR happen.

@hroskes @gritsan We keep discussing CircleCi implementations for several years now. I suggest moving into another provider. It makes a difference when the files are internal (CircleCi grids) vs also for user consumption (MELA references). CircleCi has been giving us too much trouble, and I deem it unusable at this point, also given that all of these discussions revolve around lack of manpower etc.

Regardless of circleci or another provider, keeping the reference files together with the code is the more sustainable option.  I say this having had experience with both protocols, with multiple providers, and despite having huge reference files.

@hroskes Then perhaps a better solution is to make another (perhaps private) repo. to be checked out separately when the checks are run on CircleCi.

Lets give it 72 hours, and in 72 hours we will move forward with the best practical proposal on the table which somebody is ready to implement on a ~day timescale. If we do not have an agreement, we will have a Zoom chat on Monday, which is in 72 hours. In case we need a Zoom chat, we will make it at 3pm EST / noon PST on January 10, 2022.

We will use this Zoom room for our chat. We can start at 3pm EST today, and have the second opportunity at 3pm EST tomorrow (Tuesday, Jan.11,2022), for those who cannot make it today:
https://zoom.us/j/98706947918?pwd=ZVFmZ2VTRGo3MEdyUlYvOS9lc2VOQT09

We have the second and the last meeting on this topic on Zoom right now.


I'm geting an Undefined local variable or method 'env' error Redmine  4.0.4.devel

Current user: anonymous
Completed 500 Internal Server Error in 1187ms (ActiveRecord: 1.6ms)
NameError (undefined local variable or method `env' for #<RedmineSocialSignInCallbacksController:0x00005643b5a147e0>):
plugins/redmine_social_sign_in/app/controllers/redmine_social_sign_in_callbacks_controller.rb:6:in `social_sign_in_callback'

Further info:
Environment:
Redmine version                4.0.4.devel
Ruby version                   2.5.1-p57 (2018-03-29) [x86_64-linux-gnu]
Rails version                  5.2.3
Environment                    production
Database adapter               Mysql2
Mailer queue                   ActiveJob::QueueAdapters::AsyncAdapter
Mailer delivery                smtp
SCM:
Git                            2.17.1
Filesystem
Redmine plugins:
redmine_issue_dynamic_edit     0.6.7
redmine_social_sign_in         1.0.2

Getting same error on callback. Providing static values to insert user method runs the login correctly.
'env' variable is not accessible here. can anyone help?

Hello, I am going to fix it, thank you for your feedback

hi @easy-petr , thanks for replying, May I know the closing date of the issue?
Would really appreciate if it is done in few days as I will use it in my redmine instance for auth

I will release new verion on Thursday or Friday

Fixed, you can download a new code.


Not able to Message

Hey Can you please help me with this error, the bot is getting stuck again and again. I don't know what is the reason but I think the UI of my instagram is a bit different from what I saw in screenshots. Please help

Exception in thread Thread-4 (_start_messages):
Traceback (most recent call last):
File "C:\Users\dashi\AppData\Local\Programs\Python\Python312\Lib\threading.py", line 1073, in _bootstrap_inner
self.run()
File "C:\Users\dashi\AppData\Local\Programs\Python\Python312\Lib\threading.py", line 1010, in run
self._target(self._args, **self._kwargs)
File "C:\Users\dashi\OneDrive\Documents\GitHub\MR.DM\src\ui\progressscreen\progressscreen.py", line 241, in _start_messages
self.start_message_loop()
File "C:\Users\dashi\OneDrive\Documents\GitHub\MR.DM\src\ui\progressscreen\progressscreen.py", line 252, in start_message_loop
self.find_element(SELECTORS["new_dm_btn"]).click()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\dashi\OneDrive\Documents\GitHub\MR.DM\src\ui\progressscreen\progressscreen.py", line 307, in find_element
return self.session.driver.find_element(By.XPATH, XPATH)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\dashi\AppData\Local\Programs\Python\Python312\Lib\site-packages\selenium\webdriver\remote\webdriver.py", line 742, in find_element
return self.execute(Command.FIND_ELEMENT, {"using": by, "value": value})["value"]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\dashi\AppData\Local\Programs\Python\Python312\Lib\site-packages\selenium\webdriver\remote\webdriver.py", line 348, in execute
self.error_handler.check_response(response)
File "C:\Users\dashi\AppData\Local\Programs\Python\Python312\Lib\site-packages\selenium\webdriver\remote\errorhandler.py", line 229, in check_response
raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.NoSuchElementException: Message: no such element: Unable to locate element: {"method":"xpath","selector":"//div[@role= 'button'][.//div////*[text()='New message']]"}
(Session info: chrome=120.0.6099.217); For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
Stacktrace:
GetHandleVerifier [0x00007FF7EEFF2142+3514994]
(No symbol) [0x00007FF7EEC10CE2]
(No symbol) [0x00007FF7EEAB76AA]
(No symbol) [0x00007FF7EEB01860]
(No symbol) [0x00007FF7EEB0197C]
(No symbol) [0x00007FF7EEB44EE7]
(No symbol) [0x00007FF7EEB2602F]
(No symbol) [0x00007FF7EEB428F6]
(No symbol) [0x00007FF7EEB25D93]
(No symbol) [0x00007FF7EEAF4BDC]
(No symbol) [0x00007FF7EEAF5C64]
GetHandleVerifier [0x00007FF7EF01E16B+3695259]
GetHandleVerifier [0x00007FF7EF076737+4057191]
GetHandleVerifier [0x00007FF7EF06E4E3+4023827]
GetHandleVerifier [0x00007FF7EED404F9+689705]
(No symbol) [0x00007FF7EEC1C048]
(No symbol) [0x00007FF7EEC18044]
(No symbol) [0x00007FF7EEC181C9]
(No symbol) [0x00007FF7EEC088C4]
BaseThreadInitThunk [0x00007FFBC7D2257D+29]
RtlUserThreadStart [0x00007FFBC9ACAA58+40]

Hello, It seems I had lost a line when I was resolving a merge conflict. The issue was in the code and not with a difference in Insta accounts. The latest commit has fixed this issue. Please clone the repo and try again


Remove leading spaces

Changes:
Every line below line 8 was preceded by 2 spaces, causing an alignment problem.  I just removed them.

Can you make the same changes for the other languages' files as well? Thanks.

Can you make the same changes for the other languages' files as well? Thanks.

Done!

thanks @esayles!


Cetificates are not being mined...

Created 3 certificates, worked fine on ALL of them. Not sure what the issue you were having is @av80r .


Backend greetings

✔ I Create a new Rails API app called 'hello-rails-back-end'.
✔I Initialize your project with Git.
✔I Make sure that your project has a Postgres database set up.
✔I Create a table for storing your messages and create 5 different greetings.
✔I Create an API endpoint that selects a random greeting from your table (you will need a controller with an action and rails route).

Hello Hope you doing good My linters are passing in my Vscode I have provided the screenshot above


Initial solution needs to be smarter about moving dumps

You currently need to make sure you supply the problem with enough trucks to solve the problem with each truck ONLY make one run to the dump. For example: if you have 1559 containers and 750 containers to fill a truck then the maximum containers that can be services is 1500 and 59 are silently dropped off the problem. Maybe we should add this to the Check() function.
Regardless, it is bad to silently change the problem or supply an incomplete solution because the user expects a solution to the problem given and not a partial solution or a complete solution that is not the problem requested.

That initial solution doesn't move dumps. There are other initial solutions available like:
https://github.com/woodbri/vehicle-routing-problems/blob/develop/src/trash-prob/initTrash/truckManyVisitsDump.cpp   (half tested, at least the idea is there).

Ok, definitely should revisit this one. I might be interesting is we can estimate which solution would work better for a given problem and then use that, but I'm not sure if this is possible or has any benefits.


API v1: Update providers to source

The catalog API version 1 refers to provider as source. The change has been made across query parameters, endpoints and response object keys. Most of the changes would be adopted automatically when all the other issues pertaining to the migration to the new API version are solved. But, in order to make things consistent both for the developers and the users, we should modify both the code and UI.
The following list is updated as new required changes are found.

[ ] Update the data structure names.
[ ] Update the function and argument names.
[ ] UI changes

[ ] Update the filter dropdown name.
[ ] Update provider references in the options page.
[ ] Update provider references in the info-popup.

Special care should be taken as far as this issue is concerned as a lot of things will break simultaneously if not handled properly.

Blocked by https://github.com/creativecommons/cccatalog-api/issues/421


Console Warnings in Bluekit Example

When I launch the Bluekit Example (and also with my app) I get the following console warnings. Should I be concern?
warning.js:36 Warning: Unknown prop 'styles' on <div> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
    in div (created by PropsTable)
    in div (created by PropsTable)
    in div (created by PropsTable)
    in PropsTable (created by PropsSidebar)
    in div (created by PropsSidebar)
    in div (created by PropsSidebar)
    in PropsSidebar (created by Page)
    in div (created by Page)
    in div (created by StyleRoot)
    in StyleRoot (created by Page)
    in Page (created by Content)
    in div (created by Content)
    in Content (created by Page)
    in div (created by Page)
    in div (created by StyleRoot)
    in StyleRoot (created by Page)
    in Page (created by StateProvider)
    in StateProvider (created by App)
    in App printWarning @ warning.js:36

warning.js:36 Warning: Failed prop type: Invalid prop 'name' of type 'string' supplied to 'SourceCode', expected 'object'.
    in SourceCode (created by Preview)
    in Preview (created by Page)
    in div (created by Page)
    in div (created by StyleRoot)
    in StyleRoot (created by Page)
    in Page (created by Content)
    in div (created by Content)
    in Content (created by Page)
    in div (created by Page)
    in div (created by StyleRoot)
    in StyleRoot (created by Page)
    in Page (created by StateProvider)
    in StateProvider (created by App)
    in App printWarning @ warning.js:36

@andrerecinto These warnings are directly in BlueKit or BlueKit example components. So you shouldn't be concerned. We hope to get rid of them next week in a new release. Thanks for the feedback!

Ok good to know. Thank you.


Modif SQLSegmentsExtractorEngine.extract() method

Fixes #2670.
Changes proposed in this pull request:

Reduce the number of parameters of the method.
Modify the caller "SQLParseEngine.parse()"

Pull Request Test Coverage Report for Build 8750

0 of 3 (0.0%)  changed or added relevant lines in 2 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 61.626%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/SQLParseEngine.java
0
1
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/extractor/SQLSegmentsExtractorEngine.java
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java
3
76.0%

Totals

Change from base Build 84:
0.0%

Covered Lines:
8457

Relevant Lines:
13723

💛  - Coveralls


No output during pod installation - exits early

My Gemfile.lock shows that I am using motion-cocoapods 1.7.4. When I run bundle exec rake pod:install I see the output of "updating spec repo", then I see the message that CocoaPods 0.39.0 is available. Then it exits. The pods are not being installed. I launch my app and I get method missing errors on classes that should exist from my installed pods.

Hello, can you provide a sample app that reprocuces this error?

Actually, I think the problem is that there is no output when all of the pods are installed. I made a change to my list of pods and rake bundle exec rake pod:install again and was able to see the pods install successfully. When I ran it again, the output was blank. However, it seems that "re-installing" fixed my method missing errors. I think the solution to this problem is to display a message that all of the pods have been installed, or that the dependencies are up to date, similar to running bundle check.

Please update motion-cocoapods & CocoaPods to latest.
I'm guessing that this issue is related to older CocoaPods.


Add Google Analytics

Contributes to #1517 by adding partials containing the Google-recommended snippet (obtained from the GA app)
Just before this is merged, I'll remove the corresponding Netlify snippet injection
Adds our own partial to handle GA (UA and GA4). Once I can confirm that it is all working, I'll consider looking into using Hugo's support for GA.

Notes:

We won't be able to see the GA script in the preview build, we'll have to wait until it's published to the production server.
The added layout includes the GA4 measurement ID but doesn't use it yet.

Out-of-band, @austinlparker wrote:

if the template analytics are better than the injected stuff then we should swap over

So I'm going to merge now so that I can test it during the day today. @austinlparker - your feedback is still welcome.


[Core][MINOR] Remove redundant set master in OutputCommitCoordinatorIntegrationSuite

What changes were proposed in this pull request?
Remove redundant set master in OutputCommitCoordinatorIntegrationSuite, as we are already setting it in SparkContext below on line 43.
How was this patch tested?
existing tests

Test build #58769 has started for PR 13168 at commit 30424f4.

Can you check for other instances of this in other tests?

@srowen I checked this is only instance of .set("master" in the whole code

Test build #58769 has finished for PR 13168 at commit 30424f4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58769/
Test PASSed.

Merged build finished. Test PASSed.

ping @srowen

Merged to master


Files for test description and text instructions

The speech/movement tests name, description, and short/long text instructions are still missing.

I'm currently working on the spanish instructions. There are some sample instructions for english and german as well, but someone else should check those.


Calculated Column Formulas #723

Provided features:

enter a formula only once via the field catalog (instead of providing/repeating the formula in all lines of the internal table), whatever the formula is of the form TblFlights[[#This Row],[Airfare]]+100 or D2+100
provide a demo program of formulas with BIND_TABLE
produce an Excel file where the user can have the calculated formulas automatically replicated when he/she resizes the table
produce an Excel file where the cell errors can be hidden

line 5393,
IF is_formula_shareable( ip_formula = lv_value ).
doesnt work on 702, it should be
IF is_formula_shareable( ip_formula = lv_value ) = abap_true.
note: I do not intend to review this PR, just trying to help with the linter issues

Thanks. Any idea what means "expected ENDMETHOD", how to correct it?

its a bad error message description, it will disappear when the IF statement is fixed :)


added new api endpoint to proxy oauth requests

Calling this endpoint proxies an Oauth request through Almond cloud and redirects back to the original url

By the way, do you have a branch/PR for the almond-server side of this? It would be nice to test everything together before we merge it.

Here is the PR for almond-server side: https://github.com/stanford-oval/almond-server/pull/80. Also, the Oauth flow breaks if redirect_uri isn't set to the almond cloud endpoint or set_state is set to true in the device. Is this a problem?

Let's merge this so we can end-to-end test it.

Closing this one.