[Improve]: update FE dependencies, use pnpm

What changes were proposed in this pull request
Issue Number: close #xxx

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

Dependencies (does it add or upgrade a dependency): (yes)

Upgrade front-end dependencies to latest, test compilation deployment(Except for the sql-formatter dependency)

eslint code

Post-Deployment Interface

@wolfboys The front-end dependency upgrade is complete, help test if there are any problems after the overall compilation and deployment

@wangsizhu0504  When executing the ./build.sh script, the following error occurred:
[INFO] --- frontend-maven-plugin:1.12.1:pnpm (build) @ streampark-console-service ---
[INFO] Running 'pnpm run build:no-cache' in /Users/bytedance/IdeaProjects/incubator-streampark/streampark-console/streampark-console-service/../streampark-console-webapp
[INFO]
[INFO] ><EMAIL_ADDRESS>build:no-cache /Users/bytedance/IdeaProjects/incubator-streampark/streampark-console/streampark-console-webapp
[INFO] > npm run clean:cache && npm run build
[INFO]
[INFO]
[INFO] ><EMAIL_ADDRESS>clean:cache
[INFO] > rimraf node_modules/.cache/ && rimraf node_modules/.vite
[INFO]
[INFO]
[INFO] ><EMAIL_ADDRESS>build
[INFO] > cross-env NODE_ENV=production NODE_OPTIONS=--max-old-space-size=8192 pnpm vite build
[INFO]
[INFO] node:events:505
[INFO]       throw er; // Unhandled 'error' event
[INFO]       ^
[INFO]
[INFO] Error: spawn pnpm ENOENT
[INFO]     at Process.ChildProcess._handle.onexit (node:internal/child_process:283:19)
[INFO]     at onErrorNT (node:internal/child_process:478:16)
[INFO]     at processTicksAndRejections (node:internal/process/task_queues:83:21)
[INFO] Emitted 'error' event on ChildProcess instance at:
[INFO]     at Process.ChildProcess._handle.onexit (node:internal/child_process:289:12)
[INFO]     at onErrorNT (node:internal/child_process:478:16)
[INFO]     at processTicksAndRejections (node:internal/process/task_queues:83:21) {
[INFO]   errno: -2,
[INFO]   code: 'ENOENT',
[INFO]   syscall: 'spawn pnpm',
[INFO]   path: 'pnpm',
[INFO]   spawnargs: [ 'vite', 'build' ]
[INFO] }
[INFO]  ELIFECYCLE  Command failed with exit code 1.
[INFO] ------------------------------------------------------------------------

[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.12.1:pnpm (build) on project streampark-console-service: Failed to run task: 'pnpm run build:no-cache' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :streampark-console-service

@wangsizhu0504 When executing the ./build.sh script, the following error occurred:
[INFO] --- frontend-maven-plugin:1.12.1:pnpm (build) @ streampark-console-service ---
[INFO] Running 'pnpm run build:no-cache' in /Users/bytedance/IdeaProjects/incubator-streampark/streampark-console/streampark-console-service/../streampark-console-webapp
[INFO]
[INFO] ><EMAIL_ADDRESS>build:no-cache /Users/bytedance/IdeaProjects/incubator-streampark/streampark-console/streampark-console-webapp
[INFO] > npm run clean:cache && npm run build
[INFO]
[INFO]
[INFO] ><EMAIL_ADDRESS>clean:cache
[INFO] > rimraf node_modules/.cache/ && rimraf node_modules/.vite
[INFO]
[INFO]
[INFO] ><EMAIL_ADDRESS>build
[INFO] > cross-env NODE_ENV=production NODE_OPTIONS=--max-old-space-size=8192 pnpm vite build
[INFO]
[INFO] node:events:505
[INFO]       throw er; // Unhandled 'error' event
[INFO]       ^
[INFO]
[INFO] Error: spawn pnpm ENOENT
[INFO]     at Process.ChildProcess._handle.onexit (node:internal/child_process:283:19)
[INFO]     at onErrorNT (node:internal/child_process:478:16)
[INFO]     at processTicksAndRejections (node:internal/process/task_queues:83:21)
[INFO] Emitted 'error' event on ChildProcess instance at:
[INFO]     at Process.ChildProcess._handle.onexit (node:internal/child_process:289:12)
[INFO]     at onErrorNT (node:internal/child_process:478:16)
[INFO]     at processTicksAndRejections (node:internal/process/task_queues:83:21) {
[INFO]   errno: -2,
[INFO]   code: 'ENOENT',
[INFO]   syscall: 'spawn pnpm',
[INFO]   path: 'pnpm',
[INFO]   spawnargs: [ 'vite', 'build' ]
[INFO] }
[INFO]  ELIFECYCLE  Command failed with exit code 1.
[INFO] ------------------------------------------------------------------------

[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.12.1:pnpm (build) on project streampark-console-service: Failed to run task: 'pnpm run build:no-cache' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :streampark-console-service

mac? Go to the streampark-console-webapp directory and run npm run build to try it out.

➜  streampark-console-webapp git:(dev) npm run build

><EMAIL_ADDRESS>build
> cross-env NODE_ENV=production NODE_OPTIONS=--max-old-space-size=8192 pnpm vite build

node:events:491
      throw er; // Unhandled 'error' event
      ^

Error: spawn pnpm ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:283:19)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
Emitted 'error' event on ChildProcess instance at:
    at ChildProcess._handle.onexit (node:internal/child_process:289:12)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn pnpm',
  path: 'pnpm',
  spawnargs: [ 'vite', 'build' ]
}

Node.js v18.9.0

mac
➜  streampark-console-webapp git:(dev) npm run build

><EMAIL_ADDRESS>build
> cross-env NODE_ENV=production NODE_OPTIONS=--max-old-space-size=8192 pnpm vite build

node:events:491
      throw er; // Unhandled 'error' event
      ^

Error: spawn pnpm ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:283:19)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
Emitted 'error' event on ChildProcess instance at:
    at ChildProcess._handle.onexit (node:internal/child_process:289:12)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn pnpm',
  path: 'pnpm',
  spawnargs: [ 'vite', 'build' ]
}

Node.js v18.9.0

Go to the webapp directory and edit the package.json file.
Modify the build command under scripts
"build": "vite build",

then run npm run build

mac
➜  streampark-console-webapp git:(dev) npm run build

><EMAIL_ADDRESS>build
> cross-env NODE_ENV=production NODE_OPTIONS=--max-old-space-size=8192 pnpm vite build

node:events:491
      throw er; // Unhandled 'error' event
      ^

Error: spawn pnpm ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:283:19)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
Emitted 'error' event on ChildProcess instance at:
    at ChildProcess._handle.onexit (node:internal/child_process:289:12)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn pnpm',
  path: 'pnpm',
  spawnargs: [ 'vite', 'build' ]
}

Node.js v18.9.0

Go to the webapp directory and edit the package.json file.
Modify the build command under scripts
"build": "vite build",

then run npm run build

It works , thanks.


Implement github repo ingestion

Creates github repo node in ground with a node version for each commit
Still need to pull in the latest code for looking up tags so that commits/versions can link. I could instead store the nodeId and the commit hash together in the python script, but that might cause performance problems in repos with a large commit history.
This PR addresses: #9

I'll remove the github webhook model.
What if I replace the github webhook resource with a kakfa resource? You could POST a topic name and key and it will publish to ground's kakfa cluster?
curl -X POST -d <githubwebhookpayload> "http://localhost:9090/kafka/?topic=github&key=ground-context"

A kafka endpoint would be more useful in the future to integrate other plugins.

I think that makes a lot of sense. It also gives us a very general framework for async communication with almost no overhead.

A couple questions:

is the Docker build the full Dockerfile for Ground?
is the Swagger API documentation complete?

If so, awesome! Let's make sure we get those issues resolved as well.

Swagger is implemented. When ground is running you can just go to http://localhost:9090/swagger and it will have the docs. We should add more descriptions to each path for more clarity, but other than that it works.
The docker file creates an image with only ground in it. I have it interacting with other the other docker containers (kafka, neo4j, zookeeper) so I'll write up instructions for that. I haven't worked on having it connect to a hive container yet though, that might be more complicated.

Great. If you think this is ready, let's get this merged and resolve #16 and #13 resolved in other PRs.

this is working and ready to be merged

Left some minor code cleanup feedback. I'll merge once we get those resolved.

I cleaned up the code, let me know if there is anything else that needs to be changed


Can we upload to a hidden repo?

Hi there,
It seems we can upload artifacts only to releases or snapshots although in our config we have two more hidden repos and no snapshots actually.
Thanks

Well, the dashboard is not perfect, I'll try to investigate this issue this weekend.

Thank you.
On Fri, Feb 19, 2021 at 11:57 AM Dzikoysk<EMAIL_ADDRESS>wrote:

Well, the dashboard is not perfect, I'll try to investigate this issue
this weekend.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dzikoysk/reposilite/issues/367#issuecomment-782202553,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAICCI5RQUMZGJPKB3OT7ATS72KADANCNFSM4X4TOE2Q
.

I've just reviewed this issue and it looks fine:

Do you use token that has access to these private repositories?

Yes, I use an 'm' token. And our list of repos is defines this way:
repositories [
releases
.libs-release-local
.libs-snapshot-local
]
On Sat, Feb 20, 2021 at 4:57 PM Dzikoysk<EMAIL_ADDRESS>wrote:

I've just reviewed this issue and it looks fine:
[image: image]
https://user-images.githubusercontent.com/4235722/108609516-ae520480-73ce-11eb-8ef0-4dacbfb938f9.png
Do you use token that has access to these private repositories?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dzikoysk/reposilite/issues/367#issuecomment-782755342,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAICCI6NZNZEOQW4J5F7XATTAAV4NANCNFSM4X4TOE2Q
.

I'm not able to reproduce it, could you provide more details about the token (associated path) and your setup (Reposilite version, reverse proxy, custom base path)? And to clarify the issue, you can't see these hidden repositories in the Upload tab in the dashboard, but you're able to push artifacts through the standard maven goal?

Yes, that is correct:

you can't see these hidden repositories in the Upload tab in the
dashboard, but you're able to push artifacts through the standard maven
goal?

Just went to check again and I see the upload repos correctly now.
Sorry, I am not sure how they did not show on the day I filed the ticket. I
guess this ticket can be closed.
On Sun, Feb 21, 2021 at 7:42 PM Dzikoysk<EMAIL_ADDRESS>wrote:

I'm not able to reproduce it, could you provide more details about the
token (associated path) and your setup (Reposilite version, reverse proxy,
custom base path)? And to clarify the issue, you can't see these hidden
repositories in the Upload tab in the dashboard, but you're able to push
artifacts through the standard maven goal?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dzikoysk/reposilite/issues/367#issuecomment-782967584,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAICCI2BYUKZ7FDSRWELT4LTAGR7NANCNFSM4X4TOE2Q
.

Good to know! Maybe some kind of browser caching affected the response 🤔 Let me know if this issue will occur once again.


Patch4 dev

Overview
Sometimes the target is too far away to make the cursor too small to see,and sometimes we want the cursor size to remain the same.
So I modified the Cursor. cs, added a bool variable 'IsCameraCursorDistance', and renamed the 'SurfaceCursorDistance' to 'CursorDistance', the 'IsCameraCursorDistance' control the 'CursorDistance' means the distance is from the Cursor to hit or  camera,the former retain the original function, and the latter can keep the Cursor size unchanged.
Then in the method UpdateCursorTransform(),I will calculate the cursor position based on 'IsCameraCursorDistance' and 'CursorDistance'.
Changes

Fixes: #.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: 67688FEA sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

To resubmit

To resubmit


Revert "build(deps): bump github.com/norwoodj/helm-docs from 1.12.0 to 1.13.0 in /tools/src/helm-docs"

Reverts envoyproxy/gateway#2697
The toolchain instruction added in go.mod in this change seems to break docs generation, e.g. here: https://github.com/envoyproxy/gateway/actions/runs/8072567519/job/22054604017?pr=2715
go: errors parsing go.mod:
/home/runner/work/gateway/gateway/tools/src/helm-docs/go.mod:5: unknown directive: toolchain

sorry, force pushed to fix sign-off on auto-generated PR

/retest


include alias in pretty print

What current issue(s) does this address, or what feature is it adding?

resubmitting https://github.com/ixje/neo-python/pull/18
addresses https://github.com/CityOfZion/neo-python/pull/934#issuecomment-496112560

How did you solve this problem?

if an alias exists for the address, print the alias
updated tests

NOTE: Right now there is no ability within neo-python to update/delete the alias once it is set. I think this should be a future feature update.
How did you make sure your solution works?
manual testing initially and make test after tests were updated
Are there any special changes in the code that we should be aware of?
no
Please check the following, if applicable:

[x] Did you add any tests? (updated)
[x] Did you run make lint?
[x] Did you run make test?
[x] Are you making a PR to a feature branch or development rather than master?
[x] Did you add an entry to CHANGELOG.rst? (if not, please do)

Coverage increased (+0.01%) to 85.066% when pulling d5cfa511ed26b57e2514d39a2b3df5439e2cf745 on jseagrave21:pretty-print-alias-2 into c95fec661eeb876e82ce014abf72056e95f955e0 on CityOfZion:development.

I could not resolve the conflict via Github web. For some reason it won't load completely so I can't update the CHANGELOG. You'll have to do it 🤷♂

@ixje okay, it should be good now

I changed the log entry to
Include address aliases in ``wallet`` command output

because your entry described the internal change that requires "inside" knowledge. This describes the impact for the user

I changed the log entry to
Include address aliases in ``wallet`` command output

because your entry described the internal change that requires "inside" knowledge. This describes the impact for the user

Thank you! I will try to keep that in mind for future Changelog entries.

50 points

https://neoscan.io/transaction/589328c622e101065f6717d61a332f93aac71cc68b665e194ef8c874a7e26669


QR decomposition via Givens roation vs Householder transform?

Hi,
Thanks for your excellent work.
In your works, you use the householder transform to perform QR decomposition. While in MSCKF related literatures, they usually use Givens rotation.
After some search, I realize that they have the same level of accuracy (both are better than Schmidt orthogonalization). So why you use householder transform instead of Givens rotation. Is Householder transform really faster than Givens rotation?
Best,
Deshun

Thanks for your interest.
I don't have any great theoretical insights, but I agree that I would also expect the same accuracy from Givens rotations and Householder refelections for computing the QR.
I haven't compared number of operations. The main advantage of Householder reflections in my mind is that you can zero out a whole column of matrix elements, where Givens rotations zero our elements one at a time. So maybe computing and applying Householder reflections is better suited to (automatic) vectorization in the CPU. Householder reflections are also more compact to store (in a way that is efficient to apply). In Eigen you can do a Householder QR decomposition in-place, storing the householder vectors in the columns that would otherwise be zero. Storage overhead is only 1 scalar per column. Storing Given's rotations (at least with the Eigen::JacobiRotation class), you have 1 extra scalar per zero element.
In rootba we actually use both. For initial marginalization in the landmark blocks there are both variants as perform_qr_givens() and perform_qr_householder(), and to apply and remove damping, we always use Givens rotations in set_landmark_damping().
For the former, you can experiment yourself about the runtime difference by setting the solver. use_householder_marginalization option. For the marginalization we found it only makes a small difference (Householder is a little faster) and since typically landmark marginalization is a small fraction of overall runtime, I don't think the difference is really noticeable for total runtime.

Thanks for your very quick response. Your answer is very appreciated. And I will try to do experiments with both operations.
Have a nice day,
Deshun


Leetcode Question Number 204

Leetcode Question Number 204 soultion needs to be added in the repo .
The link for the question is this.
Accepted Languages C++ / JAVA .
You Only need to add the  class Solution in the file.
Make Sure you have read the contributions guidelines before creating an PR.

Assign me


Notebook SageMaker_SSH_Notebook.ipynb fails due to docker-compose

The notebook SageMaker_SSH_Notebook.ipynb throws an error related to docker compose:

INFO:sagemaker.local.image:docker command: docker-compose -f /tmp/tmpxkrcbq9c/docker-compose.yaml up --build --abort-on-container-exit

time="2023-11-14T20:11:59Z" level=warning msg="a network with name sagemaker-local exists but was not created by compose.\nSet `external: true` to use an existing network"
network sagemaker-local was found but has incorrect label com.docker.compose.network set to ""

---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
File ~/anaconda3/envs/python3/lib/python3.10/site-packages/sagemaker/local/image.py:296, in _SageMakerContainer.train(self, input_data_config, output_data_config, hyperparameters, environment, job_name)
    295 try:
--> 296     _stream_output(process)
    297 except RuntimeError as e:
    298     # _stream_output() doesn't have the command line. We will handle the exception
    299     # which contains the exit code and append the command line to it.

File ~/anaconda3/envs/python3/lib/python3.10/site-packages/sagemaker/local/image.py:984, in _stream_output(process)
    983 if exit_code != 0:
--> 984     raise RuntimeError("Process exited with code: %s" % exit_code)
    986 return exit_code

RuntimeError: Process exited with code: 1

Not sure what is causing the error. I was able to run the same notebook content just three months ago. Any hint or suggestion will be greatly appreciated.

Hi, @djmarti , thanks for bringing up this important observation. The issue is probably rooted in the recent changes of docker-compose: https://github.com/docker/compose/issues/10797 .
Please, downgrade the version as a workaround:
sudo curl -L "https://github.com/docker/compose/releases/download/v2.18.1/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose

There's nothing that we can do on the SageMaker SSH Helper side, I'll keep this issue open until SageMaker Notebooks will get an update.

Thanks Ivan for your prompt response and for the workaround.  I think I gave a misleading hint. I am still unable to run the notebook after downgrading docker-compose to version 2.18.1. I checked that the version of docker-compose is the expected one:
$ whereis docker-compose
docker-compose: /usr/local/bin/docker-compose
$ docker-compose -v
Docker Compose version v2.18.1

But I get an error that smells like a permission error:
e13eeylbz4-algo-1-c64ep  | 2023-11-17 01:34:50,818 sagemaker_pytorch_container.training INFO     Invoking user training script.
e13eeylbz4-algo-1-c64ep  | 2023-11-17 01:34:50,875 botocore.credentials INFO     Found credentials from IAM Role: BaseNotebookInstanceEc2InstanceRole
e13eeylbz4-algo-1-c64ep  | 2023-11-17 01:34:51,010 sagemaker-training-toolkit ERROR    Reporting training FAILURE
e13eeylbz4-algo-1-c64ep  | 2023-11-17 01:34:51,010 sagemaker-training-toolkit ERROR    Framework Error:
e13eeylbz4-algo-1-c64ep  | Traceback (most recent call last):
e13eeylbz4-algo-1-c64ep  |   File "/opt/conda/lib/python3.9/site-packages/sagemaker_training/trainer.py", line 88, in train
e13eeylbz4-algo-1-c64ep  |     entrypoint()
e13eeylbz4-algo-1-c64ep  |   File "/opt/conda/lib/python3.9/site-packages/sagemaker_pytorch_container/training.py", line 153, in main
e13eeylbz4-algo-1-c64ep  |     train(environment.Environment())
e13eeylbz4-algo-1-c64ep  |   File "/opt/conda/lib/python3.9/site-packages/sagemaker_pytorch_container/training.py", line 100, in train
e13eeylbz4-algo-1-c64ep  |     entry_point.run(uri=training_environment.module_dir,
e13eeylbz4-algo-1-c64ep  |   File "/opt/conda/lib/python3.9/site-packages/sagemaker_training/entry_point.py", line 92, in run
e13eeylbz4-algo-1-c64ep  |     files.download_and_extract(uri=uri, path=environment.code_dir)
e13eeylbz4-algo-1-c64ep  |   File "/opt/conda/lib/python3.9/site-packages/sagemaker_training/files.py", line 138, in download_and_extract
e13eeylbz4-algo-1-c64ep  |     s3_download(uri, dst)
e13eeylbz4-algo-1-c64ep  |   File "/opt/conda/lib/python3.9/site-packages/sagemaker_training/files.py", line 174, in s3_download
e13eeylbz4-algo-1-c64ep  |     s3.Bucket(bucket).download_file(key, dst)
e13eeylbz4-algo-1-c64ep  |   File "/opt/conda/lib/python3.9/site-packages/boto3/s3/inject.py", line 277, in bucket_download_file
e13eeylbz4-algo-1-c64ep  |     return self.meta.client.download_file(
e13eeylbz4-algo-1-c64ep  |   File "/opt/conda/lib/python3.9/site-packages/boto3/s3/inject.py", line 190, in download_file
e13eeylbz4-algo-1-c64ep  |     return transfer.download_file(
e13eeylbz4-algo-1-c64ep  |   File "/opt/conda/lib/python3.9/site-packages/boto3/s3/transfer.py", line 326, in download_file
e13eeylbz4-algo-1-c64ep  |     future.result()
e13eeylbz4-algo-1-c64ep  |   File "/opt/conda/lib/python3.9/site-packages/s3transfer/futures.py", line 103, in result
e13eeylbz4-algo-1-c64ep  |     return self._coordinator.result()
e13eeylbz4-algo-1-c64ep  |   File "/opt/conda/lib/python3.9/site-packages/s3transfer/futures.py", line 266, in result
e13eeylbz4-algo-1-c64ep  |     raise self._exception
e13eeylbz4-algo-1-c64ep  |   File "/opt/conda/lib/python3.9/site-packages/s3transfer/tasks.py", line 269, in _main
e13eeylbz4-algo-1-c64ep  |     self._submit(transfer_future=transfer_future, **kwargs)
e13eeylbz4-algo-1-c64ep  |   File "/opt/conda/lib/python3.9/site-packages/s3transfer/download.py", line 354, in _submit
e13eeylbz4-algo-1-c64ep  |     response = client.head_object(
e13eeylbz4-algo-1-c64ep  |   File "/opt/conda/lib/python3.9/site-packages/botocore/client.py", line 530, in _api_call
e13eeylbz4-algo-1-c64ep  |     return self._make_api_call(operation_name, kwargs)
e13eeylbz4-algo-1-c64ep  |   File "/opt/conda/lib/python3.9/site-packages/botocore/client.py", line 960, in _make_api_call
e13eeylbz4-algo-1-c64ep  |     raise error_class(parsed_response, operation_name)
e13eeylbz4-algo-1-c64ep  | botocore.exceptions.ClientError: An error occurred (403) when calling the HeadObject operation: Forbidden
e13eeylbz4-algo-1-c64ep  |
e13eeylbz4-algo-1-c64ep  | An error occurred (403) when calling the HeadObject operation: Forbidden
e13eeylbz4-algo-1-c64ep  | 2023-11-17 01:34:51,011 sagemaker-training-toolkit ERROR    Encountered exit_code 1

A permission error is surprising because I didn't have issues before and there haven't been changes in my setup.

Looking into exception stack trace, I see that it's again something related to SageMaker itself rather than to SSH Helper. It's downloading the code from S3, most likely from the default bucket that looks like s3://sagemaker-eu-west-1-555555555555/ . Could you check that this bucket exists, you can access this bucket from your notebook instance (e.g. by running aws s3 cp command from the Terminal) and it's located in the same region as your notebook?
If the above steps don't help, please, raise a support case:
https://docs.aws.amazon.com/awssupport/latest/user/case-management.html

Apologies for the long delay. I retried with the exact same code and the problem is gone, which is consistent with your suggestion that this was something related to SageMaker. Everything works as expected, closing the ticket.

I've faced the similar message with HeadObject, but it looks like the notebook instance was running for a very long time.  I've stopped and started this instance again and the issue is gone.


fix(libscap): fix debug mode asserts

Signed-off-by: Luca Guerra<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-udig

/area libscap

/area libsinsp

/area tests

/area proposals

What this PR does / why we need it:
There are a few ASSERT()s that cannot build and would generate compiler errors in debug mode. This fixes them or removes them.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

Hi @LucaGuerra. Thanks for your PR.
I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 70de8c3781ebc13faec673c26abe5ec184738215

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Dependencies

@jawadsahil  Because every version of flutter_test from sdk depends on async 2.6.1 and pdf_viewer_jk >=2.1.3 depends on async ^2.7.0, flutter_test from sdk is incompatible with pdf_viewer_jk >=2.1.3.

You need to resolve the issue yourself. pdf_viewer_jk  already use a greater version of async. Use latest version of flutter_test or use an older version of pdf_viewer_jk .


Feat: update contributors

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface
/kind content

/kind translation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area videos

What this PR does / why we need it:
Extract contributors data to separate file. Add partial/contributors, layout/contributors, add related links
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bullet03, Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: c59268f5fbe12c7f239ae97663057079101609da


Walkthrough

Hi, I have a NoteStore.sqlite file from an old laptop. However, I am not tech savvy enough to get through all the steps and get the data. I always get stuck at some point and I don't know how to do it.
Could someone walk me through while in chat with me to help me recover data? That would be very helpful to me. Thank you in advance.

Copy the NoteStore.sqlite and any linked NoteStore.journal or NoteStore.wal files to a windows system. By linked, I mean the files that are present in the same folder as the main database.
Download the latest mac_apt windows release and extract mac_apt_artifact_only.exe from the zip.
In a Command Prompt (cmd window), browse to the folder where the exe resides, then run the following command:
mac_apt_artifact_only.exe -i C:\temp\Notestore.sqlite -o C:\temp -x NOTES
The above command assumes that your original files are copied to the C:\temp folder. If not replace that path with the location of wherever you copied them.


Create Today I Learned “configuring-gatsby-source-drupal-to-only-import-referenced-images”

Automatically generated by Netlify CMS

Maybe this should really be a post? And maybe it should reference the Bounteous blog post.
Make sure this is tagged with Drupal and syndicated to Drupal planet.

Maybe this should really be a post? And maybe it should reference the Bounteous blog post.
Make sure this is tagged with Drupal and syndicated to Drupal planet.

Update the summary here.


Wrong coordinates in request-url

In the function definition of forecast--get-forecast in the string request-url the coordinates are truncated. This causes darksky to return the forecast for the wrong coordinates (e.g 40,-3 instead of 40.414,-3.685 which are about 74 km apart).
This can be fixed by using %f instead of %d in the format control string.
diff -u ~/.emacs.d/elpa/forecast-0.6.3/forecast.el ~/.emacs.d/elpa/forecast-0.6.3/forecast.el.old
--- ~/.emacs.d/elpa/forecast-0.6.3/forecast.el.old	2017-09-23 19:13:38.296314068 +0200
+++ ~/.emacs.d/elpa/forecast-0.6.3/forecast.el	2017-09-23 19:19:19.939077588 +0200
@@ -412,7 +412,7 @@
               (string-empty-p forecast-api-key))
       (user-error "Forecast: `forecast-api-key' not set"))
     (setf request-url
-          (format "%s/forecast/%s/%d,%d?%s"
+          (format "%s/forecast/%s/%f,%f?%s"
                   forecast-api-url
                   forecast-api-key
                   la lo

Diff finished.  Sat Sep 23 19:26:13 2017

Hi @dnbarbato,
thanks a lot, I've installed and pushed your patch, and made a bugfix
release with it.  Sorry for the silly bug, weird that it went unnoticed
all this time...
--
İ. Göktuğ Kayaalp              http://www.gkayaalp.com/index.html
<EMAIL_ADDRESS>  🎀            PGP = 024C 30DD 597D 142B 49AC
Plaintext please!  {UTF8}  Fingerprint   40EB 465C D949 B101 2427


New date search in date of birth resets to first option when search term is removed, search also does not have 'no result found'

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Open settings
Open profile
Open personal details
Open date of birth
Click on date field
Click on year
Observe that by default when there is no search term, it displays current selected year
Search anything
Remove that search term and observe that search now displays very first selectable year

Expected Result:
Search should display current selected year when search is emptied like it does when year search is first opened, search should also have no result found when searched parameter is not found
Actual Result:
Search resets to first option available to select when search term is removed
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.2.89-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/227811612-dc23037c-f58a-4b9e-a765-8691fef765a0.mp4
https://user-images.githubusercontent.com/43996225/227811617-9775e06b-dc63-403c-845b-de27ecd6f70b.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679842686260429
View all open jobs on GitHub

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

There are a few recent DOB GHs.
I think this can be part of this job - https://github.com/Expensify/App/issues/16514
@roryabraham what do you think? Can these jobs be consolidated into one?

following - https://github.com/Expensify/App/issues/16514

@Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Search should display current selected year when search is emptied like it does when year search is first opened

This doesn't look like a bug to me, cc: @roryabraham @mountiny

search should also have no result found when searched parameter is not found

This is fixed separately here

I dont think this is a bug, the year is still selected it just does not scroll down to it which feels expected to me

Hi @mountiny , @Santhosh-Sellavel , issue no 16713 seems to raised after this bug but I had mentioned 'no results found' issue already in this bug. Can you check that and let me know if I could be the first reporter of that bug?


Testing framework

Hi,
I think you did a great work here, you really saved me!
the only thing that I was missing is a testing framework, fortunately it was pretty easy to add Mocha and chai - so easy I was sure it's not going to work, I have already made to many changes to run a pull request but if you want to add it to the project I can help - I am also added nyc to get a code coverage report - (the only issue I have is that it's hard to see failing the tests when running lerna run test- but I think it's an issue with Lerna )

Hey @zamirdan, with this repo I only intend to provide the basic structure of a monorepo and let others add whatever they want on top. Never say never, but right now I don't want to turn this into a starter kit by including opinionated tools.


Don't deploy book to Github Pages on pull requests

Fixes https://github.com/Synphonyte/leptos-use/actions/runs/7803407302/job/21283109692

Awesome, thanks! Wanted to do this for a while but never found the time.


install-docker scripts failing when passing -useDHCP due to deprecated dependency

the problem
On Windows Server 2022, the install-docker-ce.ps1 and install-containers-runtime.ps1 scripts will fail at the step Creating container network (Transparent)... as that depends on the New-ContainerNetwork cmdlet. That cmdlet is part of Docker PowerShell which is deprecated.
To Reproduce
On a Windows Server 2022 machine, with Hyper-V Role and Containers feature enabled, download the scripts, open an Administrator Windows PowerShell session and run ./install-docker-ce.ps1 -useDHCP.
It will start fine, and then will fail:
PS C:\Users\[user]\Downloads> .\install-docker-ce.ps1 -useDHCP
Querying status of Windows feature: Containers...
Feature Containers is already enabled.
Waiting for Hyper-V Management...
Enabling container networking...
Creating container network (Transparent)...
C:\Users\[user]\Downloads\install-docker-ce.ps1 : The term 'New-ContainerNetwork' is not recognized as the name of a
cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify
that the path is correct and try again.
At line:1 char:1
+ .\install-docker-ce.ps1 -useDHCP
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
    + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,install-docker-ce.ps1

Expected behavior
Docker should be installed, with Transparent networking.
Configuration:

Edition: Windows Server 2022
Base Image being used: Not applicable
Container engine: Not applicable
Container Engine version: Not applicable

Additional context
Fresh install, just Windows and .NET8, nothing else.

@ritikaguptams has been tackling this Issue and put out a PR. We'll be reviewing that shortly and updating this Issue as soon as we can.

@rholdorf  We have updated the scripts to use supported commands to create a transparent network to unblock the users! Cheers!

@rholdorf We have updated the scripts to use supported commands to create a transparent network to unblock the users! Cheers!

Great! The script worked beautifully. Thank you!


The game won't start

when I open the game, only the cmd window appears and closes immediately

same problem

Game has updated today, so you'll have to wait until it's fixed

Same issue here, still on proper version 2.20


Can custom sections be added to conda recipe foir whl2conda?

Determine if sections can be added to a conda recipe for use by whl2conda
without breaking conda build.

I added a whl2conda top-level section to a conda recipe
and conda build simply ignored it so it seems it is ok.
It should definitely be allowed to add stuff to the extra
section, but that would be expected to end up in the
metadata.


[python] A registration path fails with non-standard obs/var index names

tiledbsoma.io.from_anndata_appends_on_experiment doesn't pass through non-standard obs_id_field_name and var_id_field_name as other methods do

[sc-42824]


Agario patched anyfix :(

Currently no fix at the moment, although I am trying to get in touch with Lucky or NeeL to check if they have the fix. Sorry.

They switched to an asm compiled javascript with some protocol changes,
we're on it but it might be a lot harder to fix this time..
Le sam. 7 mai 2016 01:39, Hazardous16<EMAIL_ADDRESS>a écrit :

Currently no fix at the moment, although I am trying to get in touch with
Lucky or NeeL to check if they have the fix. Sorry.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/pulviscriptor/agario-client/issues/191#issuecomment-217588094

Ah, I see, thanks NeeL, is there any way we could maby get in touch?

Protocol 13 is super easy compared to protocol 11


Comprehensive examples

Pomp looks like a nice and simple design - I'm going to give it a try while migrating an existing Scrapy project to Python 3.
However, I would really like to see some more comprehensive examples in the documentation or the repository.
For instance, a larger project would:

Use requests middleware for auth, proxies, etc
Use asyncio with some kind of queue
Export to a database
Run as a daemon or a scheduled job

These things can be rolled together by any competent Python dev, but I think demonstrating one or more ways to build a full-scale production deployment might help gain a few users.

I agree.
In plans build demo project in separate repo under docker containers via docker-compose
Were would be:

postgres as database (preferred by me)
django admin panel to view data
export data to the database via django models with detection new data (bulk insert or import csv)
centralized queue on redis
pomp worker builded on top of requests or aiohttp with lxml, where item extracting would be paralleled (ConcurrentCrawler)

This example show how use Pomp to build distributed robust app.
Do you know what web resource would be the best target for that?
And allow legal scraping.
Sorry for my poor English

That sounds great. I'm using Django models also, but haven't worked out how to handle queuing yet... Another idea for an example is throttling speed by domain.
Here are some data ideas:

Crawl Ratebeer or BeerAdvocate to create a database of beers and their styles.
Crawl Github for top projects & contributors
Scrape every city in Craigslist for a specific search term, to get an idea of what market prices for used items are.

I had an additional question after reading through the code: is using pomp.core.item.Item and pomp.core.item.Field required, or can the crawlers just return dictionaries instead? If not required, maybe they should go in contrib? (I was looking into using voluptuous or marshmallow for schema.)

maybe they should go in contrib? (I was looking into using voluptuous or marshmallow for schema.)
Yes! It must be placed in contrib and do not restrict users.
Thanks!

pomp.core.item moved to pomp.contrib.item without backward compatibility
Item interface necessary for developing plugged pipelines like pomp.contrib.pipelines.CsvPipeline where order of fields required.

big example - Craigslist crawler
Soon I will publish screencast.
But this example much more about how build cluster of web crawlers and less about pomp features and it internals.

screencast without audio of craigslist crawler
and don`t know when I will write more detailed description and publish it on reddit or others resources

Awesome, thanks!


Fix JSHint Warnings / Errors and remove two "bad" test cases in FetchSpec.

Hi there,
Thanks for contributing!
In the future, please try to separate different things into different PRs.
I do not agree with the code style changes. Point taken though, I should replace .hshintrc with an .eslintrc.json, I haven't used JSHint in a while which explains why it's config is out of date.
Why remove the testcases? What's wrong with them?

Those tests are failing when using Sinon 1.17.4.
And it is probably correct as well, should a 404 be treated as an error?
I agree that this could be multiple PRs but they do fix warnings / errors for gulp and npm test that is why I went with a single PR.

Yes. I will add the eslint config file and update the sinon version asap.

Done

"sinon": "^1.17.3" => "sinon": "1.17.3" version 1.17.4 is broken.
Remove JSHint preprocessor from karma.conf.js.

We should probably use ESLint from karma? Let me know if you want me to look into this one.

Yes! If you know how to do it, any PRs would be appreciated! Otherwise I can look into it!


[Bug] Pod reconciliation fails if worker pod name is supplied

Why are these changes needed?
Deploy a RayCluster with a worker group with replicas >= 2 and supply a name in the pod template. The operator will fail to generate multiple worker replicas and will show an error creating the second pod. See this commit for more details. The following instructions can reproduce this bug.
# Step1: Clone my Kuberay repo (kevin85421/kuberay), and check out to the `replicate-worker-name-control-group` branch.
git clone git@github.com:kevin85421/kuberay.git
git checkout replicate-worker-name-control-group

# Step2: Install kuberay-operator
cd helm-chart/kuberay-operator
helm install kuberay-operator .

# Step3: Install ray-cluster
cd helm-chart/ray-cluster
helm install ray-cluster .

[Solution]: Set ObjectMeta.Name to an empty string, and use GenerateName to prevent name conflicts.
[Note]: Relationship between Name and GenerateName (Link)

Related issue number
Closes #582

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[x] Manual tests
[ ] This PR is not tested :(

I tested this PR with the same config for ray-cluster in https://github.com/kevin85421/kuberay/commit/fe80c7513e7345a968d2f43965e3d29105385033, but used the new image for kuberay-operator. As shown in the screenshot, two workers are created successfully.

Looks good. This is the correct action here. Could you add a unit test?
And then it would be great to mention in the Ray docs here https://docs.ray.io/en/latest/cluster/kubernetes/user-guides/config.html#pod-templates that metadata.name and metadata.generate_name are ignored.

Looks good. This is the correct action here. Could you add a unit test?
And then it would be great to mention in the Ray docs here https://docs.ray.io/en/latest/cluster/kubernetes/user-guides/config.html#pod-templates that metadata.name and metadata.generateName are ignored.

I added a unit test. I opened an issue to update the document in the ray repository.


How to disable Spotify?

Buletooth and Airplay are enough for me? How to disable spotify?

You can disable services in balena device dashboard or either comment proper parts in docker-compose.yml. Maybe there are more elegant way to do it but these 2 are straight forward

@wangjunwei87 Baryczka is right. We recommend deleting the spotify entry in the docker-compose.yml file. Closing.

@Baryczka @AlexProgrammerDE Yes,  it will work, but everytime balena-sound updates, I will have to do it again. Is it possible to add some env variable like DISALBE_MULTI_ROOM (eg: DISABLE_SPOTIFY ) to disable spotify?


March 2019 Endgame

This is the endgame schedule for March 2019 Iteration.
Schedule

End game master: @weinand / Zurich
End game buddy: @octref / Redmond
03/25 Code freeze for the endgame
03/29 Endgame done
04/04 Expected release date (this may change)

Note: The Insiders build needs to be in the wild for 24 hours before we can enter the last phase of the endgame.

Monday 03/25

[x] Run OSS tool @weinand

The LCA review of the ThirdPartyNotices.txt files is not needed anymore

[x] Code freeze at 5pm PT
[x] Ensure we have a green build on all platforms at 5pm PT
[x] All test items contain test meta data by 5pm PT and sufficiently comprehensive test descriptions by 8am CET
[x] Update your availability for testing here - https://vscode-tools.azurewebsites.net/

Tuesday 03/26

[x] Test plan items assigned (using https://vscode-tools.azurewebsites.net/)

Run the tool multiple times to balance load if test items come in later and assignments are already made

[x] All closed feature-requests either have a verification-needed or on-testplan tag
[x] Test build starts at 7am CET
[x] Test plan ready by 8am CET
[x] Testing
[x] Verification needed

Wednesday 03/27

[x] Testing
[x] Remind team members to assign issues that they intend to fix to the current milestone
[x] Fixing (self-assigned, milestone assigned)
[x] Verification

Thursday 03/28

[x] Fixing (scrutiny sets in - major bugs only - to be discussed in stand-up meeting, labeled as candidate)
[x] Verification
[x] Run OSS tool and pass list of changed OSS usage (https://github.com/Microsoft/vscode-build-tools/blob/master/distro-tools/license/third_party_1.nn.0_diff.txt) to @isidorn for verification @weinand

Friday 03/29

[x] Pause scheduled insider builds @weinand
Satellite modules/npm packages ready, version updated, smoke tested

[x] vscode @bpasero
[x] yo generator @aeschli
[x] vsce @joaomoreno
[x] node debug @weinand
[x] node debug2 @roblourens
[x] node debugadapter node @weinand
[x] debug-adapter-protocol @weinand

[x] All issues verified
[x] Fixing (only critical bugs - no string changes)
Smoketest (⚠ MUST run with --stable-build argument ⚠ )

[x] Windows - @dbaeumer
[x] OS X - @alexandrudima
[x] Linux - @aeschli

[ ] All release notes updated

release notes are collected in a file named Month_Year.md in this repo directory. ⚠We are now doing release notes via Git LFS. Please read what this means here: https://github.com/Microsoft/vscode-docs/blob/vnext/README.md#git-lfs-setup⚠
[x] @aeschli
[x] @alexandrudima
[x] @alexr00
[x] @bpasero
[x] @chrmarti
[x] @dbaeumer
[ ] @egamma
[x] @isidorn
[x] @joaomoreno
[x] @jrieken
[ ] @kieferrm
[ ] @mjbvz
[x] @octref
[ ] @rebornix
[x] @rmacfarlane
[ ] @roblourens
[x] @sandy081
[ ] @sbatten
[x] @tyriar
[x] @weinand

[ ] Acknowledge pull requests in release notes. We acknowledge PRs from outside the team. Use the thankyou tool to generate the initial contents of the section. owner

[x] vscode @weinand
[x] vscode-node-debug @weinand
[ ] vscode-node-debug2 @roblourens
[x] vscode-debugadapter-node @weinand
[x] debug-adapter-protocol @weinand
[x] vscode-languageserver-node @dbaeumer
[x] language-server-protocol @dbaeumer
[x] vscode-textmate @alexandrudima
[x] vscode-loader @alexandrudima
[x] vscode-generator-code @aeschli
[x] vscode-vsce @joaomoreno
[ ] vscode-docs @gregvanl
[x] vscode-css-languageservice @aeschli
[x] vscode-json-languageservice @aeschli
[x] vscode-html-languageservice @aeschli
[x] jsonc-parser @aeschli
[ ] vscode-jscs @chrisdias
[ ] vscode-tslint @egamma
[x] vscode-eslint @dbaeumer
[x] vscode-jshint @rmacfarlane
[ ] vscode-recipes @auchenberg
[x] localization @shawndon
[x] vscode-github-issues-prs @chrmarti
[x] inno-updater @joaomoreno

[x] Review pull requests acknowledgements with NOT MERGED - PLS REVIEW. @weinand
[x] Acknowledge issue trackers from the community @chrmarti
[x] Add notable fixes to the release notes all
When done fixing/verifying and there are changes since last build at the end of day PT

[x] Trigger new insider build and publish it manually @weinand

Friday/Monday

[x] Branch code to `release/<x.y> @weinand
[x] Bump up the version in package.json - @weinand
[x] Announce master is open for business @weinand
[x] Polish release notes redmond

Monday - Wednesday

[x] Polish release notes redmond
[x] Cherry-pick hand-picked and reviewed changes to release/<x.y> @weinand
[x] Build Insider from release/<x.y> @weinand
[x] Manually release Insider @weinand
[x] Build stable for all platforms as new candidate issues come in @weinand
[ ] Documentation updated

[x] @aeschli
[x] @alexandrudima
[x] @alexr00
[x] @bpasero
[x] @chrmarti
[x] @dbaeumer
[ ] @egamma
[ ] @isidorn
[x] @joaomoreno
[x] @jrieken
[ ] @kieferrm
[ ] @mjbvz
[x] @octref
[ ] @rebornix
[x] @rmacfarlane
[ ] @roblourens
[x] @sandy081
[ ] @sbatten
[ ] @tyriar
[x] @weinand

Note: The Insiders build needs to be in the wild for 24 hours before we can enter the last phase of the endgame.

Wednesday/Thursday

[x] Build stable for all platforms @weinand
[x] Make rpm signing request @RMacfarlane
[x] Sanity check of installable bits

[x] Windows

[x] signed installer 32-bit @roblourens
[x] signed installer 64-bit @octref
[x] signed user installer 32-bit @roblourens
[x] signed user installer 64-bit @octref
[x] zip 32-bit @roblourens
[x] zip 64-bit @octref

[x] OS X - @octref
[x] Linux

[x] deb package 32-bit @RMacfarlane
[x] deb package 64-bit @sbatten
[x] rpm package 64-bit @RMacfarlane
[x] rpm package 32-bit @RMacfarlane
[x] archive 32-bit @RMacfarlane
[x] archive 64-bit @RMacfarlane

[x] Publish website @gregvanl
[x] Publish Localization language pack @shawndon
[x] Publish to stable @weinand
[x] Add a git tag to HEAD of release/<x.y> in format x.y.z (for vscode.d.ts download)  @weinand
[x] Publish<EMAIL_ADDRESS>@octref
[x] Publish rpm to repository manually @RMacfarlane
[x] Enable scheduled insider builds @weinand
[x] Twitter announcement @auchenberg

What is happening with the last two releases, both are delayed?

@dzienisz no, we are always shipping the release in the week after the endgame.
You can always find the expected release date in the first comment of the endgame (above).

04/04 Expected release date (this may change)

March released shipped!

@weinand thanks for the answer!


Include option to use static libraries

It would be nice to offer the option to use static libraries rather than dynamic ones, especially on Windows.

Solved by your PR.


Allow self-reference to deploy-time constants such as name and id

@marcre mentioned that this can simplify resource definitions for certain resource types such as load balancer.

I think this is a duplicate of #565


Cannot clear the MA Specific Conversation Agent

What version of Music Assistant has the issue?
NA
What version of the Home Assistant Integration have you got installed?
2024.6.2
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
If you setup a MA specific Conversation Agent per the instructions you cannot clear it. If you select a different agent and hit submit it works. But if you select None and hit submit there is no change. The issue is at this line that provides as the default the current selected agent. If you select None it will use the default value.
I had to manually edit the core.config_entries file to clear it.
How to reproduce

In the configure options of the integration select a MA specific Conversation Agent and hit submit
Go to configure options again, select None for the agent and hit submit. The agent won't clear.

Music Providers
NA
Player Providers
NA
Full log output
No response
Additional information
No response
What version of Home Assistant Core are your running
2024.7.0
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Generic x86-64 (e.g. Intel NUC)

Closing since you have PR'ed the fix.


[core] Fix failing CI steps

[ ] I have followed (at least) the PR section of the contributing guide.

@Janpot should the branch option be next actually? I think this may be the problem. Let me open a PR with just this change.

should the branch option be next actually?

Yes, I was trying back and forth between master and next and diffed the wrong change 🤦

Yes, I was trying back and forth locally between master and next and diffed the wrong change 🤦. --branch next is what I meant.

But even that doesn't fail https://github.com/mui/material-ui/pull/41637, probably we need to do something else as well.
Note, on this PR, I also pushed some changes I got when running pnpm install, I wonder why those weren't picked up either. cc @michaldudak maybe you can shed some light :)

Do we need to modify this line to use next instead of master?

Do we need to modify this line to use next instead of master?

Yes, I think so. Ideally we just add a global $BASE_BRANCH variable to centralize the logic

I will push the changes in https://github.com/mui/material-ui/pull/41637 to validate if it works.
On https://github.com/mui/material-ui/pull/41637 pnpm run prettier does not create any changes, but I kind of feel that is incorrect since we have files committed that do not have semicolons. Locally adding semicolons also passes. I may be misunderstanding how this branch option should behave.

I will merge this branch to unblock the release. Let's continue the discussion in https://github.com/mui/material-ui/pull/41637

Note, on this PR, I also pushed some changes I got when running pnpm install, I wonder why those weren't picked up either

@mnajdova This doesn't look right. It seems that Base UI was somehow downgraded from 5.0.0-beta.40 to 5.0.0-beta.30

The pnpm install --no-frozen-lockfile succeeds when pnpm install would update the lockfile. This looks like a bug in pnpm. I've created an issue: https://github.com/pnpm/pnpm/issues/7823


DEBUG output

There's a line that prints DEBUG output in csvstream.h

fixed
On Fri, Oct 14, 2016 at 1:04 PM, jamesjuett<EMAIL_ADDRESS>wrote:

There's a line that prints DEBUG output in csvstream.h
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/awdeorio/csvstream/issues/5, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHJ8nU-WGFQmOc7TY49WhOEiDJNpMmdgks5qz7YKgaJpZM4KXOs5
.


Broken API integration

In our pipeline, I am trying to get a list of products through the API, but got the error. We are using Python for our scripts. On 2.13.1 version all was fine.
Steps to reproduce
Steps to reproduce the behavior:

Install DD Python API packages.
Run dd.list_products() command
Got the error.

Expected behavior
I get list of products through API.
Deployment method (select with an X)

[ ] Docker Compose
[ X] Kubernetes
[ ] GoDojo

Environment information

Operating System: [debian:buster-slim]
DefectDojo version: [2.14.3]

Logs
The above exception was the direct cause of the following exception:
Error
2022-09-23 11:53:20.065 EEST{}
Error
2022-09-23 11:53:20.065 EESTTraceback (most recent call last): File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 506, in dispatch response = handler(request, *args, **kwargs) File "/usr/local/lib/python3.8/site-packages/django/utils/decorators.py", line 43, in _wrapper return bound_method(*args, **kwargs) File "/app/./dojo/api_v2/prefetch/mixins.py", line 13, in list queryset = self.paginate_queryset(queryset) File "/usr/local/lib/python3.8/site-packages/rest_framework/generics.py", line 171, in paginate_queryset return self.paginator.paginate_queryset(queryset, self.request, view=self) File "/usr/local/lib/python3.8/site-packages/rest_framework/pagination.py", line 387, in paginate_queryset self.count = self.get_count(queryset) File "/usr/local/lib/python3.8/site-packages/rest_framework/pagination.py", line 525, in get_count return queryset.count() File "/usr/local/lib/python3.8/site-packages/django/db/models/query.py", line 412, in count return self.query.get_count(using=self.db) File "/usr/local/lib/python3.8/site-packages/django/db/models/sql/query.py", line 528, in get_count number = obj.get_aggregation(using, ['__count'])['__count'] File "/usr/local/lib/python3.8/site-packages/django/db/models/sql/query.py", line 513, in get_aggregation result = compiler.execute_sql(SINGLE) File "/usr/local/lib/python3.8/site-packages/django/db/models/sql/compiler.py", line 1175, in execute_sql cursor.execute(sql, params) File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 66, in execute return self._execute_with_wrappers(sql, params, many=False, executor=self._execute) File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 75, in _execute_with_wrappers return executor(sql, params, many, context) File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 84, in _execute return self.cursor.execute(sql, params) File "/usr/local/lib/python3.8/site-packages/django/db/utils.py", line 90, in exit raise dj_exc_value.with_traceback(traceback) from exc_value File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 84, in _execute return self.cursor.execute(sql, params) File "/usr/local/lib/python3.8/site-packages/django_prometheus/db/common.py", line 71, in execute return super().execute(*args, **kwargs) django.db.utils.ProgrammingError: column dojo_product.sla_configuration_id does not exist
Error
2022-09-23 11:53:20.065 EESTLINE 1: ...pe_id" AS Col8, "dojo_product"."updated" AS Col9, "dojo_prod...
Error
2022-09-23 11:53:20.065 EEST ^
Error
2022-09-23 11:53:20.065 EEST{}
Error
2022-09-23 11:53:20.075 EEST[23/Sep/2022 08:53:20] ERROR [django.request:224] Internal Server Error: /api/v2/products/
Info
2022-09-23 11:53:20.075 EEST<IP_ADDRESS> - - [23/Sep/2022:08:53:20 +0000] "GET /api/v2/products/?limit=200 HTTP/1.1" 500 59

Installing from source might work.
https://github.com/DefectDojo/defectdojo_api#this-api-wrapper-is-no-longer-maintained-it-may-or-may-not-work

I guess this can be closed @mtesauro as this is quite old.


Expected version ">=8.9.4"

Hi, there!
Come here on my way to find some lightweight alternative for yeoman, and your project looks quite suitable for this.
No offense, but what is a real reason to depend on a node above v8.9.4? Sorry if this information is already given somewhere.

plop version 1.x supported node 4.0 and greater but one of plop's main dependencies (inquirer.js) dropped node 4 support and went to node 6. When that happened, I decided to make plop depend on what was (at the time) the current LTS version of node. That's how plop 2.x came to require node 8.9.4 :slightly_smiling_face:.
Is the dependency on 8.x a problem for you? plop should (in theory) work fine on 6+.

Thanks for quick reply! Our project is "quite conservative", so we were ought to use node 8.3.0 until recent time. So namely this version was set as default one on our development environment. As a consequence attempt to install plop was failed.
So it might be better to depend on more older version, to prevent such issues for some users.
But, btw, thanks to this issue we arranged some time and upgraded to 8.11.3:)


Adding RStudio

Adds RStudio installed from rstudio.org. It looks like it can access R packages installed via Conda.

@ocefpaf This may be an older version of RStudio.
It might also be worth getting an R person to take a look to see if the Conda packages are loading correctly.

It might also be worth getting an R person to take a look to see if the Conda packages are loading correctly.

The version may not be ideal but it is better than no RStudio. Let's merge it so we can test and, if it can see the conda installed packages, even better!


Polyfill: Object.assign()

The browser support for Object.assign is very poor right now.
We can polyfill it using object-assign.

Or we could just use es5-shim + es6-shim, instead?

I don't have any experience with es6-shim. Is the overhead low?

I'm not sure. We should look into it though, as long as we're throwing the idea of polyfills around. =)

Minified es6-shim is 34.833 kb. :0

We could forget the shim and just do the whole project in ES6 and transpile... thoughts?

https://cdn.polyfill.io/v1/docs/ made my day ;)

This project is going to use ES6 with Babel and core-js.


expose JS_GetModuleNamespace (or rebase on upstream)

Upstream decided to expose JS_GetModuleNamespace as an API to get the exports of a ESModule, see here:
https://github.com/bellard/quickjs/blob/2c793e50979e64a51178c1048071c97722eb1bf1/quickjs.h#L879
My library supports both upstream and quickjs-ng, so currently I need to patch in JS_GetModuleNamespace in my vendored copy of quickjs-ng

We added an equivalente before 😔 https://github.com/quickjs-ng/quickjs/commit/6868fb9e2516fde4a7a3fcef113a6bb1e5ecc957

I know you added some custom C APIs for this purpose, but it would be great to pick up the official API from upstream

Yep, will do.

Thanks


Improve connection handling

Two optimizations:

drain connections before closing to ensure they can be reused. See docs for the Body field https://golang.org/pkg/net/http/#Response.

Eagerly close connection before requesting a refreshed auth token so that the same connection can be potentially used for that.

I believe Go already does this for you

It's weird that this is not documented on the Response type. Updated the code, thanks.

True... I only discovered it because I've never seen the "drain before close" and it made me curious


Java <-> Ruby timestamp convert incorrect value in milli precision.

Follow-up: https://github.com/embulk/embulk-output-bigquery/issues/76

expect value: 2015-07-13 00:00:00.100000 +00:00
actual value: 2015-07-13 00:00:00.000100 +00:00

Ref: https://github.com/hiroyuki-sato/embulk-support/blob/master/output-bigquery_076_milli_sec/00README.md
Reproduce code.
in:
  type: file
  parser:
    type: csv
    charset: UTF-8
    newline: LF
    delimiter: ','
    quote: '"'
    escape: '"'
    trim_if_not_quoted: false
    skip_header_lines: 1
    allow_extra_columns: false
    allow_optional_columns: false
    columns:
    - {name: date, type: timestamp, format: '%Y-%m-%d'}
    - {name: timestamp, type: timestamp, format: '%Y-%m-%d %H:%M:%S.%N'}
    - {name: 'null', type: string}
    - {name: long, type: long}
    - {name: string, type: string}
    - {name: double, type: double}
    - {name: boolean, type: boolean}
  path_prefix: example.csv
filters:
  - type: insert
    columns:
    - timestamp_format:
  - type: ruby_proc
    columns:
    - name: timestamp_format
      skip_nil: false
      proc: |
        ->(_,record) do
          if t = record["timestamp"]
            t.strftime("%Y-%m-%d %H:%M:%S.%6N %:z")
          else
            nil
          end
        end
  - type: column
    columns:
    - { name: timestamp_format }

out: {type: stdout}

input data.
date,timestamp,"null",long,string,double,boolean
2015-07-13,2015-07-13 00:00:00.100000,,90,l6lTsvxd,903.4,true
2015-07-13,2015-07-13 00:00:00.100000,,91,XoALSEQg,394.5,true
2015-07-13,2015-07-13 00:00:00.100000,,92,0hgDRI_m,810.9,true
2015-07-13,2015-07-13 00:00:00.100000,,93,KjCRAc-A,477.4,true
2015-07-13,2015-07-13 00:00:00.100000,,94,fyQVGlT8,725.3,true
2015-07-13,2015-07-13 00:00:00.100000,,95,FpBYRPWK,316.6,true
2015-07-13,2015-07-13 00:00:00.100000,,96,9ikvnUqp,369.5,true
2015-07-13,2015-07-13 00:00:00.100000,,97,RRNYDAzK,506.5,true
2015-07-13,2015-07-13 00:00:00.100000,,90,l6lTsvxd,903.4,false
2015-07-13,2015-07-13 00:00:00.100000,,91,XoALSEQg,394.5,false
2015-07-13,2015-07-13 00:00:00.100000,,92,0hgDRI_m,810.9,false
2015-07-13,2015-07-13 00:00:00.100000,,93,KjCRAc-A,477.4,false
2015-07-13,2015-07-13 00:00:00.100000,,94,fyQVGlT8,725.3,false
2015-07-13,2015-07-13 00:00:00.100000,,95,FpBYRPWK,316.6,false
2015-07-13,2015-07-13 00:00:00.100000,,96,9ikvnUqp,369.5,false
2015-07-13,2015-07-13 00:00:00.100000,,97,RRNYDAzK,506.5,false

result
2015-07-13 00:00:00.000100 +00:00
2015-07-13 00:00:00.000100 +00:00
2015-07-13 00:00:00.000100 +00:00
2015-07-13 00:00:00.000100 +00:00
2015-07-13 00:00:00.000100 +00:00
2015-07-13 00:00:00.000100 +00:00
2015-07-13 00:00:00.000100 +00:00
2015-07-13 00:00:00.000100 +00:00
2015-07-13 00:00:00.000100 +00:00
2015-07-13 00:00:00.000100 +00:00
2015-07-13 00:00:00.000100 +00:00
2015-07-13 00:00:00.000100 +00:00
2015-07-13 00:00:00.000100 +00:00
2015-07-13 00:00:00.000100 +00:00
2015-07-13 00:00:00.000100 +00:00
2015-07-13 00:00:00.000100 +00:00

Thanks for reporting the issue!
(As chatted out of GitHub) It looks coming from our misunderstanding of JRuby's RubyTime#setNSec, or nsec in RubyTime.newTime represents 4 to 9 decimal places, not entire the fractional parts. It means that rubyTime.setNSec(345678) sets the fraction part like .000345678, not .345678000. That behavior is not documented, though...
Since it's a problem just when creating RubyTime, it affects only Ruby plugins, not Java plugins. Will fix this in the next release (v0.9.6).
The code causing this issue is at: https://github.com/embulk/embulk/blob/v0.9.5/embulk-core/src/main/ruby/embulk/schema.rb#L42

Submitted a pull request for Javadoc in JRuby, then. https://github.com/jruby/jruby/pull/5130

Confirmed #1000 fixes it. For @hiroyuki-sato's configuration above, it output:
2015-07-13 00:00:00.100000 +00:00
2015-07-13 00:00:00.100000 +00:00
2015-07-13 00:00:00.100000 +00:00
2015-07-13 00:00:00.100000 +00:00
2015-07-13 00:00:00.100000 +00:00
2015-07-13 00:00:00.100000 +00:00
2015-07-13 00:00:00.100000 +00:00
2015-07-13 00:00:00.100000 +00:00
2015-07-13 00:00:00.100000 +00:00
2015-07-13 00:00:00.100000 +00:00
2015-07-13 00:00:00.100000 +00:00
2015-07-13 00:00:00.100000 +00:00
2015-07-13 00:00:00.100000 +00:00
2015-07-13 00:00:00.100000 +00:00
2015-07-13 00:00:00.100000 +00:00
2015-07-13 00:00:00.100000 +00:00


"settings-expand-bar" does not refresh upon navigation Up the settings bar

clicking down the settings bar icons refreshes the content in the expanded area. however clicking the icons up the settings bar does not refresh the content.
steps to reproduce:

click the last icon on the settings bar => you will see pink expanded area with six text on it.
click one icon before the last => nothing changes on the expanded area (expected => blue expanded area with text five)

working as expected after separating the ui for each tab


Use runtime loop or memset for AggregateKind::Array

For example miniz_oxide has
impl Default for HashBuffers {
    fn default() -> HashBuffers {
        HashBuffers {
            dict: [0; LZ_DICT_FULL_SIZE],
            next: [0; LZ_DICT_SIZE],
            hash: [0; LZ_DICT_SIZE],
        }
    }
}

Where LZ_DICT_FULL_SIZE is 32_768 + 258 and LZ_DIST_SIZE is 32_768. This currently results in 591427 lines of clif code. Using memset would be much faster in this case and in general a runtime loop is much better.

miniz_oxide is now down from ~3.5s on CI to ~230ms.


Add new content to section Contribution in README.md

Fixed #43 .
Signed-off-by: Jiahao XU<EMAIL_ADDRESS>

This change is


issue attribute 'required' inside  tag

Before filing issues, please check the following points first:

[x] Have a look at https://github.com/wycats/handlebars.js/blob/master/CONTRIBUTING.md
[x] Read the FAQ at https://github.com/wycats/handlebars.js/blob/master/FAQ.md
[x] Use the jsfiddle-template at https://jsfiddle.net/9D88g/47/ to reproduce problems or bugs

This will probably help you to get a solution faster.
For bugs, it would be great to have a PR with a failing test-case.
I receive an error at runtime when use 'required' attribute inside  tag.
This is the error:

XML Parsing Error: not well-formed
Location: http://www.restful.com/template/create_products.hbs
Line Number 19, Column 77:

and this is the line:
<input type='text' name='name' class='form-control' required/>

Closing due to inactivity. If this is still important to you, please provide a jsFiddle to reproduce the issue.


Log service

Add a log service to handle logging.
Requirements:

Output logs to both a file and the terminal.
Organise logs based on: single file, daily rotation, or none (i.e. discard logs).

Commit 150db0a17958c14a3f060015d52879d3e0a3cab0


dspace-api: allow overriding ImageMagick density

Allow users to override ImageMagick's default density of 72 DPI for creating PDF thumbnails. In this case a density of 144 will perform a "2x" supersample, which greatly increases the quality and accuracy of the resulting images:

There is a performance impact to this change:

Roughly two times longer execution time, for example: from 200ms to 400ms for one PDF (measured with time).
Roughly three to four times as much memory allocated, for example: from 20MiB to 60MiB for one PDF (measured with Valgrind and Massif).

I've made a microsite with detailed technical discussion and visual comparisons for a handful of real PDF bitstreams from our institutional repository here: https://alanorth.github.io/improved-dspace-thumbnails/
References

Fixes: https://github.com/DSpace/DSpace/issues/8514
Obsoletes: https://github.com/DSpace/DSpace/issues/8515

Instructions for Reviewers
List of changes in this PR:

Add a new optional configuration property to dspace.cfg: org.dspace.app.mediafilter.ImageMagickThumbnailFilter.density
Modify ImageMagickThumbnailFilter.java to use this new property if present

Include guidance for how to test or review your PR.
Force generation of thumbnails for a few bitstreams containing PDFs, ie:
$ dspace filter-media -p 'ImageMagick PDF Thumbnail' -v -f -i 10568/120157

Then check the resulting thumbnail before and after.
Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[x] My PR passes Checkstyle validation based on the Code Style Guide.
[x] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.

Added documentation: https://wiki.lyrasis.org/display/DSDOC7x/ImageMagick+Media+Filters#ImageMagickMediaFilters-OverrideImageMagickDefaultDensity


Intersection Point of Y shaped LinkedList

Have you read the Contributing Guidelines on Pull Requests?
(Write your answer here.)
Description
(As I was suggested to make one PR for one issue at a time. So I have made this new PR.
I have made this program user interactive with a suitable interface.
Also, the input is based on the user and how they want to intersect to which point for cross-validation.
Please review it and let me know if any changes needed.)
Checklist

[X] I've read the contribution guidelines.
[X] I've checked the issue list before deciding what to submit.
[X] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(#495 )

@plazzy99, I have made new PR having only one issue, do review this.

Great work @Rishikeshrajrxl
your code flows like documentation and it has a high level of readability
Impressive

Thanks @plazzy99 , it means a lot.

@Kajol-Kumari
@Abhijit2505
Please review this assigned work.

@siddharth25pandey, it has been a long time and I have got 2 approval and still waiting for one more.
please review it and kindly merge it.

@Kajol-Kumari
waiting for your review.

@siddharth25pandey, it has been a long time and I have got 2 approval and still waiting for one more.
please review it and kindly merge it.

@Rishikeshrajrxl Already mentor were assigned. They will review it shortly

@atarax665
Needed your last review, please do this and merge it.


Docs: More information into "Opting into #[may_dangle] and the dropck_eyepatch" section of MaybeDangling

This section of the documentation seems a little sparse to me (someone not familiar with dropck and its subtleties). I'd like to add these links to the text:

The nomicon section
The section from std::ops::Drop
The dropck_eyepatch RFC

and maybe add a sentence along the lines of:

Even though the Drop implementation of MaybeDangling does not access any potentially dangling pointers stored inside, without #[may_dangle] dropck will still fail compilation, since it doesn't know the internal implementation of Drop.

I was also contemplating adding an example, though this might be too much. Also I couldn't come up with a better one than replacing Inspector with MaybeDangling from the nomicon example.
Thoughts?

@jofas yeah I admit I was quite laconic in that section, so improving this to make it more user-friendly would be great! Also mentioning this other nomicon section would be useful. If you have the time then it would be nice for you to submit a PR with the doc improvements, and then I'll probably make rewording suggestions there, that way we should end up with a text fitting two Rust programmer profiles 🙂


[SPARK-46586][SQL][TESTS][FOLLOWUP] Replace appended with :+

What changes were proposed in this pull request?
The pr is following up https://github.com/apache/spark/pull/44591.
Why are the changes needed?
Fix issues in comments.

Does this PR introduce any user-facing change?
No.
How was this patch tested?

Pass GA.
Manually test.

Was this patch authored or co-authored using generative AI tooling?
No.

cc @cloud-fan

LGTM since the PR is already open tho

Merged into master. Thanks @panbingkun @cloud-fan


New account setup not properly registering with BCO API

Describe the bug
When setting up a new account, registration wasn't happening with the BCO API because of a race condition.  This is now fixed in 4.0.0
This also fixed the issue with the BCO API not showing up for a new user under accounts.

Branch 4.0.0 has the fix that correctly handles the promises to allow for both accounts in the userdb and the bco api as required.


add pandas.read_text for complex text/log parsing

Current method is using read_table/read_csv and placing logic in sep field is a bruteforce way to process log files, but isn't clean as you will get two padded columns of NaN at the start and end and does not handle parameter of regex for column names.
Code Sample, a copy-pastable example if possible
df = pd.read_table("file.log",
sep=r'^(?P[\d-]+? [\d:]+?) (?P.+?) [(?P.+?)] ((?P.+?):(?P\d+?)) - (?P.*?)$',
)
df currently would produce...
| 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7
-------|-------|-------|-------|-------|-------|-------|-------|-------
0 | NaN | 2015-01-01 00:00:00 | INFO | main | main.java | 10 | Hello World | NaN
1 | NaN | 2015-01-01 00:00:00 | ERROR | main | main.java | 11 | Ouch! | NaN
Expected Output
|datetime | level | name | filename | lineno | message
-------|------|-------|-------|-------|-------|-------
0|2015-01-01 00:00:00 | INFO | main | main.java | 10 | Hello World
1|2015-01-01 00:00:00 | ERROR | main | main.java | 11 | Ouch!
output of pd.show_versions()
INSTALLED VERSIONS
commit: None
python: 3.5.1.final.0
python-bits: 64
OS: Windows
OS-release: 7
machine: AMD64
processor: Intel64 Family 6 Model 63 Stepping 2, GenuineIntel
byteorder: little
LC_ALL: None
LANG: None
pandas: 0.18.0
nose: 1.3.7
pip: 8.1.0
setuptools: 20.2.2
Cython: 0.23.4
numpy: 1.10.4
scipy: 0.17.0
statsmodels: 0.6.1
xarray: 0.7.1
IPython: 4.1.1
sphinx: 1.3.1
patsy: 0.4.0
dateutil: 2.5.0
pytz: 2016.1
blosc: None
bottleneck: 1.0.0
tables: 3.2.2
numexpr: 2.5
matplotlib: 1.5.1
openpyxl: 2.3.3
xlrd: 0.9.4
xlwt: 1.0.0
xlsxwriter: 0.8.2
lxml: 3.5.0
bs4: 4.4.1
html5lib: 0.9999999
httplib2: 0.9.2
apiclient: None
sqlalchemy: 1.0.12
pymysql: 0.7.1.None
psycopg2: None
jinja2: 2.8
boto: 2.39.0

how is this any different that passing to read_csv?
exactly what would your function do that the 50+ options in read_csv cannot?

read_csv, read_table can do this, however you're hooking into sep field, which serves for how to seperate the values, however some log files do not use a common separator and hence you are injecting regular expression logic on how to read a file and it doesn't handle parameters from a regex.

Wouldn't it be better to write a generator expression to extract the fields from a file object, and then construct a DataFrame from that? What would the advantage of having a dedicated method be?

@AbsoluteMSTR you would have to show a sample file (small sample), and how a better API would help here.

@TomAugspurger, It's entirely possible to utilize a generator as an alternative to read_csv, read_table, but the question becomes if pandas should be able to provide api support toward complex text files like a log file.
@jreback a generic example can be an access.log file generated by Apache HTTPd
<IP_ADDRESS> - - [13/Sep/2013:01:38:09 -0400] "GET / HTTP/1.1" 200 - "-" "-"
<IP_ADDRESS> - - [13/Sep/2013:01:38:09 -0400] "GET /testing HTTP/1.1" 200 - "-" "-"
<IP_ADDRESS> - - [13/Sep/2013:01:38:10 -0400] "GET /index.html HTTP/1.1" 200 - "-" "-"

@AbsoluteMSTR this parses really easily, and will be WAY more performant that using a regex.


Scala Common Enrich: reify the bad row types

In order to expose a common self-desc BadRow type

Handled by #4106


8 new actions Implemented

Did some corrections in utils_js.dart to make sure readContract, readContracts  & getChains work. (No idea why this was broken)
Also  implemented
getChains
disconnect
switchAccount
switchChain
verifyMessage
waitForTransactionReceipt
watchAccount
watchConnections
@Chralu Requesting you to kindly review these and merge this if everything looks ok.

Hello. we have just merged PR https://github.com/archethic-foundation/wagmi_flutter_web/pull/42 in same time of your PR... Could you rebase this PR please

Rebased . Please check - @redDwarf03  & @Chralu

I don't understand why in "files changed" https://github.com/archethic-foundation/wagmi_flutter_web/pull/51/files#diff-72fd825ad17ce7800a2078e06f0dff1e12836ee59760465e78d9a5d222cebd15. I have the PR changes on the wagmiContext?

Hi @redDwarf03, I am sorry but i am unable to understand. Can you please point Me to What happened?

I don't understand why your PR isn't just the difference between the main branch and your work. In your PR there are the additions of the PR on wagmiContext.

@redDwarf03 Kindly hold off this PR for few hours, Let me reset my branch, add the respective files again and reopen a new PR. Also please avoid new commits to the main branch till then.

resolved via #54


optimize: grpc methodName & http router

Optimization 1:
When a micrologic uses grpc service, the external service accesses the methodName through the dapr sidecar http port. We found that when the first character of the methodName is /, an error of not found will be exposed; if the route is to use /+methodName, a error will appear. // is obviously unreasonable;
Optimization 2:
When the router is / or the methodName is /, I think this is meaningless, and the route or methodName should not have obvious meaning; so the router and methodName strings are controlled
Demo:

/cc @yaron2 @daixiang0

/cc @daixiang0 @yaron2 @artursouza


Cannot send email with binary attachment on python3

Noticed when creating an issue via email and attaching an image (I think).
Simple fix it seems:
diff --git a/helpdesk/lib.py b/helpdesk/lib.py
index 4f0ded3..d96a427 100644
--- a/helpdesk/lib.py
+++ b/helpdesk/lib.py
@@ -117,7 +117,7 @@ def send_templated_mail(template_name,

     if files:
         for filename, filefield in files:
-            msg.attach(filename, open(filefield.path).read())
+            msg.attach(filename, open(filefield.path, 'rb').read())

     return msg.send(fail_silently)

Up against it so haven't made a PR yet (cause I assumed you'd want test cases).
Needs tests and a decision on what files / filetypes should be supported and passed through. Or if that's the job of this project or the destination email client/service.
Edit:
A bit more context: open in python3 tries decoding the file as unicode text and fails loudly if that fails. This change forces python to read the file as 'raw bytes'. It sounds as though (from the docs) that files with an extension that results in a mimetype starting with text/ will still be decoded as unicode text by Django, and fallback if that fails. So unicode messages shouldn't actually be affected by this. However I believe it's worth setting up some comprehensive tests for this.

I think we're still working to expand test coverage. Some more tests with example emails that include various attachments is probably necessary to see if this fixes it without regressions, but offhand it makes sense to me.

Hi @willstott101 and @gwasser
This fixing will not work for text files in test-cases.
so better fixing is to replace:
msg.attach(filename, open(filefield.path).read())
with
msg.attach_file(filefield.path)
Thanks

I don't see why it wouldn't work with unicode files other than for guessing the incorrect mimetype.
However that file path has no guarantees that it will have the correct extension anyway, right? So the mimetype will still be wrong.
And we need to retain the passed in filename, which we lose with attach_file (and incidentally is what attach uses to guess the mimetype).
Once considering all that... all the attachments should be received by the server with mimetypes shouldn't they? Either via forms or email attachments. Maybe they ought to be passed all the way through to here and included explicitly. There are plenty of mimetypes that Django wont guess right, and passing through whatever we received would be a better bet? Unless that's a security concern? As email clients will probably be set to trust everything coming from helpdesk... maybe that's for another github issue. Worth thinking about though, should we provide an option to exclude attachments from emails and provide links instead (for emails to staff / selected accounts)?

Oh oh oh, it just occurred to me from your discussion above that you were reporting sent emails. Oops. I thought you meant the get_email script had trouble parsing incoming email, because I know that was a problem in the past.
Probably ideally, everyone would just receive a notification and could log into helpdesk to see the attachment, to prevent potentially malicious things being sent around via email. However, our public portal needs some work before that can happen.

@pprolancer is correct that the fix in question fails the case as described, and caught, by our tests. unfortunately, the fix he recommends, where is the technically correct one I am I've been waiting to use where wer is that all me the correct one is the correct one once we can drop support for Django 181.8 it's a issue I have document it many times in about jangles not using not using the standard life  libraries email processing module after they moved to python three now that 1.11 has been released we are technically within our church cleaned

Damn ios dictation!

In brief while on my mobile: we want to use the case @pprolancer mentions but it fails for 1.8 on py2 iirc, which we can drop support for now that dj 1.11 has been released. Sorry for the nonsense mispost, last time i try to use dictation on my phone! 😊

Recently merged #532 merges in your proposed changes with some updates. I'll close the ticket but reopen or file a new one if there's still trouble. Thanks!

LGTM, thanks for the update.


Populate requestParameters when creating a method

This PR ensures request parameters are correctly created in API Gateway. This allows caching to be correctly used and should have no impact if a developer doesn't want to use caching.
Addresses the bug in issue #65.

hi, please add unit tests for both the extractor method and the change to rebuildWebApi. You can find the existing tests in the specs folder. to filter tests when running, so you don't have to run everything, you can use npm test -- filter="part of name", for example:
npm test -- filter="rebuildWebApi creates request parameters`

i'll close this due to lack of activity. if anyone wants to pick it up later, please reopen the issue.


Cannot change cluster selection strategy for class

OrientDB Version, operating system, or hardware.

v2.2.12-SNAPSHOT

Operating System

[x ] MacOSX

Expected behavior and actual behavior
Expected: according to documentation, the cluster selection strategy for a class in distributed mode should be set to local.
Actual: cluster selection strategy is set to round-robin, and cannot be changed. This leads to error when doing insert, as every X:th insert will fail since it is targeted at a cluster that the current node does not own.
Steps to reproduce the problem

Download v2.2.12, unzip
Run bin/dserver.sh
Login with console application:  connect remote:localhost/GratefulDeadConcerts root password
Try changing cluster selection strategy for class sung_by

orientdb {db=GratefulDeadConcerts}> info class sung_by

CLASS 'sung_by'

Records..............: 501
Super classes........: [E]
Default cluster......: sung_by (id=41)
Supported clusters...: sung_by(41), sung_by_1(42), sung_by_2(43), sung_by_3(44), sung_by_4(45), sung_by_5(46), sung_by_6(47), sung_by_7(48)
Cluster selection....: round-robin
Oversize.............: 0.0
orientdb {db=GratefulDeadConcerts}> alter class sung_by clusterselection local

Class updated successfully.

orientdb {db=GratefulDeadConcerts}> info class sung_by

CLASS 'sung_by'

Records..............: 501
Super classes........: [E]
Default cluster......: sung_by (id=41)
Supported clusters...: sung_by(41), sung_by_1(42), sung_by_2(43), sung_by_3(44), sung_by_4(45), sung_by_5(46), sung_by_6(47), sung_by_7(48)
Cluster selection....: round-robin
Oversize.............: 0.0

Additional info: inserts work fine until a node is restarted:
http://stackoverflow.com/questions/40506577/inserts-javaapi-fail-after-restarting-node-in-distributed-orientdb-cluster

@mxns we have the same issue reported elsewhere. I'm working on it.

Ok, thanks for the update @lvca. And your work :) If you wanna point me to a relevant github issue that I can follow and close this one, that's fine.

@mxns Thanks for reporting it. It's fixed in 2.2.x branch. Please could you check it? NP, I'm going to take care of the related issues.

Yup, the issue that I described in this stackoverflow entry is fixed on 2.2.x, nice work @lvca.
The cluster selection strategy is still round-robin though, so it seems I misunderstood the underlying problem? Anyway, thanks!

If you dump the name is round-robin, but it's wrapped in the Local strategy wrapper.


Figure out whether it is possible to get a "download all files" button

Sometimes, especially less-experienced people, are confused by the fact some files open in their browser. This could be mitigated with a download all button when they call helpdesk again.

I would indeed opt to force a download to disk (with Content-Disposition: attachment) to avoid that confusion.
And then hope that they've seen it (not all browsers show a popup).
About the "download all": that requires a (live) zip download (which may be slow and memory intensive to generate), or rather a list of downloads in sequence (which is often blocked by a browser as seen as "adds")?


revise: MiniMessageTranslator #972

This PR is based on the original PR #972 . The original PR was not merged due to several review comments, and the original author is no longer making updates. To continue the development and integration of this feature, I have revised and improved the initial submission.

The original PR is waiting on virtual components for named arguments (i.e. <name> instead of <arg:1>).


Support CID embeds

Problem
For Symfony projects I've switched from Mailtrap to Mailcrab, and I've just noticed that images embedded with CID are not being displayed in Mailcrab's formatted view.
Raw (truncated email example)
MIME-Version: 1.0
Date: Sat, 27 May 2023 14:45:54 +0200
Content-Type: multipart/related; boundary=VALLHhYX

--VALLHhYX
Content-Type: multipart/alternative; boundary=1mS-w7PU

--1mS-w7PU
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

--1mS-w7PU
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

--1mS-w7PU--

--VALLHhYX
Content-ID: <03487338a9ba70e29f37dd06781f9a95@symfony>
Content-Type: image/png; name="03487338a9ba70e29f37dd06781f9a95@symfony"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
 name="03487338a9ba70e29f37dd06781f9a95@symfony";
<EMAIL_ADDRESS>
<base64-string-here>
--VALLHhYX--

As you can see in the raw example above, the image src with cid 03487338a9ba70e29f37dd06781f9a95@symfony is available, which contains a base64 encoded string of the image file. But the image itself is available in the email as an attachment instead of being embedded.

So it just shows the broken image icon in the formatted view.

Proposal
Support for CID embeds.

On Sat, May 27, 2023 at 06:14:12AM -0700, ToshY wrote:

... I've just noticed that images embedded with CID
are not being displayed in Mailcrab's formatted view.

...

Proposal

I spell feature request differently   :-)

Support for CID embeds.

Advice for Toshy:
Make reproducing the inconvenience possible

@stappersg I'm somewhat confused on what more you would want to see exactly. The raw example response is what I got from the Raw tab in Mailcrab and I removed unncessary html bloat (while keeping content type headers) to show that both the image tag  and Content-ID: <03487338a9ba70e29f37dd06781f9a95@symfony> are in there, but Mailcrab evaluates this as an attachment instead of displaying the embedded image in the Formatted view.
I'm not sure if the issue statement is unclear or the definiton of CID embeds? Here's an SO post explaining how they work, showing a similiar response as the example I've provided.
If you insist on having a reproduction case, I can make one in Symfony 6.x (PHP 8.1) even though that has nothing to do with the issue, as the same email gets handled correctly by other mail clients (Mailtrap/Gmail/etc.).

As this library is inspired by Mailhog, you can find the same issue there as well: https://github.com/mailhog/MailHog/issues/27

Thanks for reporting this @ToshY. This should be fixed - I'll try to implement it soon.

This is fixed in v0.19.0 :+1:


blockbook: fix build on aarch64-linux

Motivation for this change
This PR fixes the build failure on aarch64-linux. For some reason the aarch64 build does not seem to be able to find the latest libstdc++, so we help a little with adding -L${stdenv.cc.cc.lib}/lib explicitly to the CGO_LDFLAGS.
Plus I cleaned up the package a little bit
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build blockbook


Create Systems Data

Definition of Ready

[x] Does this meet the INVEST criteria?
[x] Does this have a clearly defined user?
[x] Does this have an estimate?
[x] Does this have acceptance criteria?
[x] Does this have sufficient context (wireframes, business rules, etc.)?
[x] Is this traceable to a feature, epic, or PI?

As a user, I want to create Systems data so that I can add new systems
Acceptance Criteria:
Given the user has selected Systems in the section field
When the user selects Add
Then the system displays the edit modal
and the user can create systems data
System ID: text, required
System Designation: drop down, required
System Type: drop down, required
Fuel Type: drop down, required
Start Date: date picker, required, format mm/dd/yyyy
Start Time: Text, required, format hh
End Date: date picker, required, format mm/dd/yyyy
End Time: Text, required, format hh
Refer to page 50 for values
Given the user has added systems data
When the user chooses to save and close
Then the data is saved
And the modal closes
And the user is returned to the methods table
Does this Story require 508 Testing?

[x] Implementing a new authoring tool that will produce code / content for the application
[ ] Implementing a 3rd party widget that will be part of the application
[ ] Adding new / updating custom functionality
[ ] Adding new / updating a page template
[ ] Adding new / replacing existing functionality (unless the replacement has already passed 508 testing)
[ ] Full Site Review prior to a scheduled EPA 508 review
[ ] Planning a video that will appear on the application
[ ] Producing a video that will appear on the application
[ ] Producing Training materials
[ ] Producing documents

Context
Design Wiki
Testing
Test Case: TC359
Tester: @mosesdeeCVP
Definition of Done

[x] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[x] Has the code been unit tested and peer reviewed?
[x] Have the functional tests been executed?
[x] Have all defects been reviewed and dispositioned, resolved, or deferred?
[x] Has the user story been accepted by the Product Owner?
[x] Is the user story ready to be deployed to the test/staging environments?

Test Passed