Last node edges are misplaced after saving into mongodb and load them on pageload using autolayout

What platform were you using when you found the bug?

React Flow / Svelte Flow version:  "@xyflow/react": "^12.0.4",
Browser and version: chrome Latest version
OS and version: window 10

Live code example
No response
Describe the Bug
Hello I am new to this . can anyone help me how to fix this issue the I'm using autolayout pro example and when i save the edges in db on page load everything works perfect but the last node redered in wrong place It should appear after sub category 2 please help
i'm saving the edges as it is in the db but i dont know why its not working
Steps to reproduce the bug or issue
save the autolayout pro example edges in db and retrive on page load and add them in the xyflow the last nodes will misplace
Expected behavior
It should render all nodes in the correct position
Screenshots or Videos

Additional context
No response

We will look into this!

Hello I've issue with the reactflow when I remove the edges and nodes from
react flow and add new node the edges get bends seems like the
reactflow persist the presence of the nodes and edge i'm using autolayout
PRO
so I dont know how to solve this issue
On Wed, Aug 28, 2024 at 5:33 PM Moritz Klack @.***>
wrote:

Please re-open with a codesandbox. It's hard to understand what's
happening here and is probably an implementation issue rather than an issue
with the library.
If you are a pro subscriber with a pro or enterprise plan, please reach
out via mail.
—
Reply to this email directly, view it on GitHub
https://github.com/xyflow/xyflow/issues/4588#issuecomment-2315198431,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALXBOMTXLTHZROB6BAHHNMTZTW7SJAVCNFSM6AAAAABNBWRCJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJVGE4TQNBTGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

https://github.com/xyflow/xyflow/issues/4627 here is the link of github
issue
On Wed, Sep 4, 2024 at 12:34 AM Afnan @.***> wrote:

Hello I've issue with the reactflow when I remove the edges and nodes from
react flow and add new node the edges get bends seems like the
reactflow persist the presence of the nodes and edge i'm using autolayout
PRO
so I dont know how to solve this issue
On Wed, Aug 28, 2024 at 5:33 PM Moritz Klack @.***>
wrote:

Please re-open with a codesandbox. It's hard to understand what's
happening here and is probably an implementation issue rather than an issue
with the library.
If you are a pro subscriber with a pro or enterprise plan, please reach
out via mail.
—
Reply to this email directly, view it on GitHub
https://github.com/xyflow/xyflow/issues/4588#issuecomment-2315198431,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALXBOMTXLTHZROB6BAHHNMTZTW7SJAVCNFSM6AAAAABNBWRCJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJVGE4TQNBTGE
.
You are receiving this because you authored the thread.Message ID:
@.***>


General questions.

for First/Last ID it shows 2/xxxx will that change once its done to avoid double downloading?
if i ctrl+c (hot key to cancel any operation in terminal) will the progress be saved (except the one its currently downloading so if it got down downloading 1500 files and is on 1501 would it pick up from 1501 (redownloading that file obviouslly) and then continue on forward to the last message? is that how it works normally if auto update is on also? I didnt see anything about it in the guides on how it functions.

Edit: Went ahead and closed the program and re-opened it: I had to grab the message id manually and set it manually as auto kept moving it back to 2 out of 6000+.
Whenever I re start the program it makes me enter in the hash id & phone number along with the group id as well. isn't it already saved when pressing "save settings"
one last question is about the filters, for multi extention: trying to exclude mp4/videos from being downloaded for a video channel that share videos. as its the same video being forwarded from another video channel that im already downloading. but cant figure out the filters or how to set them to only download images on one channel and videos and images on the other.
images = .jpg and vides = .mp4

Thank you for your questions.
Check here: Guide for filters settings

Update for new version.
Fixed store First ID. Wait a little.

Can you show me an example of a channel what you mean?
Where should this option be displayed?

Every video, image, or file uploaded to Telegram can have a optional text description.
Can you add an option to save it?

I could not find any reference to description or text at TgDownloader/Core/TgDownloader/Helpers/TgClientHelper.cs ...

Unfortunately, this is one of the open questions - there is no documentation:

User's Guide;
Administrator's Guide;
Developer's Guide.


ErrorHandler and script context

We're using php-redis to connect to redis. It returns various errors (E_WARNING, E_USER_ERROR, etc). We want to track these, but only really need to know what servers are having issues and how often.
The solution we're using is to log these failures to InfluxDB so we can do a nice graph of error rates. I wrote a handler (too custom (ie, hacked together) for sharing just yet) for sending these errors to Influx, but since it's an extension library that sends them, I have to catch them through an error handler - so I opted to use Monolog\ErrorHandler instead of reinventing the wheel.
The problem is, I need to know context from the script (primarily redis server ip) for the data I'm logging.  Monolog\ErrorHandler ignores context in handleError (other than to pass it along).  I overrode ErrorHandler to write my own version that injects the context so that my InfluxDB handler can extract the stuff it needs.
The problem is ErrorHandler doesn't really like to be overridden, and that seems to be by design. But I basically have to make overridden copies of $logger, and the defaultErrorLevelMap() and codeToString() methods in order for it to work.  I think this is still better than rolling my own, since it'd basically be the same thing anyway, but...
Why is overriding ErrorHandler so verboten? Could those private things be protected to make them friendlier to custom error handlers? Or, could handleError have some option to send along more context data?
I've tried finding a way to do this without the ErrorHandler with various Processors and whatnot, but since this lib is directly throwing errors, I don't think there's a good way to inject that data without doing it this way.  But maybe I'm missing something obvious?

Why not add the context data using a processor? You could pass a custom Logger instance to the ErrorHandler that is fitted with extra processors for this purpose.


Support initFileFn in Fusty-flow

We use ng-flow a lot and have set our own custom file bootstrap function initFileFn in options to extend the file object with some method of ours.
I can see from the source code that Fusty's bootstrap function does not simply check for the existence of an initFileFn.
It it purposeful? Or can I just PR to add the same logic from flow.js?
Current
    bootstrap: function () {
      this.abort(true);
      this.finished = false;
      this.error = false;
},

Desired

    bootstrap: function () {
      if (typeof this.flowObj.opts.initFileFn === "function") {
        this.flowObj.opts.initFileFn(this);
      }

      this.abort(true);
      this.finished = false;
      this.error = false;
},

This fixes #21

I'm not 200% familiar with GitHub, but obviously this PR is tight to #21
Now it has become a duplicate 😆


Logs lost on update to OPNsense 22.7 - Settings default to /var/log RAM disk enabled

I was recently upgrading the system to OPNsense 22.7 and noticed that all the logs stored in /var/logs are gone.
Upon investigation and some searching around I have found that
/var/log RAM disk | Use memory file system for /var/log was enabled (by default) under System -> Settings -> Miscellaneous
I was wondering if this is an oversight or intentional and what would be the workaround to prevent this from happening on the next upgrade. To clarify this hasn't happened in the past with any other minor or major upgrades and I haven't enabled the memory file system.

This is enabled if you had previously had /var MFS enabled on a version prior to 22.7. Same thing really, except that /var scope was a bit wider.
Cheers,
Franco

Hi @fichtner and thanks for replying,
As I have said I don't remember turning this and also had done multiple minor and major upgrades to the system without this ever happening. So I guess it wouldn't be the same thing, more of a breaking change if anything?

As you can see from https://github.com/opnsense/core/commit/dc33b3ab4e5 we don't change the read/write of config.xml values so I can only conclude it was indeed enabled manually at some point except this was a Nano image where the option is set by default.

I was actually looking at that after I posted on the /src repo ( thanks for moving it here where it belongs) but I still need to read a bit more to get the gist. Perhaps it was enabled for /tmp only but definitely not for the /logs folder. Would that have the same results?

No, /tmp and /var MFS have always been separate. Now there is /tmp and /var/log MFS but both operate on the same enable/disable as before. There were no similar reports in the past of this not working (if you don't count the many issue people have had with wanting /var contents to be persistent while also having /var MFS enabled). ;)

I didn't had this problem in the past either, it's the first time I'm seeing it too :)

Is there any specific log that you have in mind here. The subtlety of this is that prior to 22.7 some plugins had persistent log storage in the volatile location (as little sense as that makes).

Yes, Mailtrail logs missing gave me the shivers before I found out what's happening

Long story short I think you either want to disable /var/log MFS or send your logs to an external syslog server for storage.
Cheers,
Franco

Yup, I did disable it as soon as I've found the little bugger, questions is, will it come back in the future or act normally as it should?
External syslog is indeed a better approach but I kept delaying it indefinitely as this was working fine for my needs.

It worked normally before, it will work normally now. The collateral damage here were 3 plugins trying to store persistent logs which was not originally intended (mailtrail, netdata and munin-node). No other components are affected.

Understood. Shall I close this now, or maybe leave it for further reference?

Can be closed if you agree. We do not embed extended plugin changes into our release notes and it was documented as:
https://github.com/opnsense/changelog/blob/a86d40e492aa892514d65e2640dbfc91cc9a11bc/community/22.7/22.7#L148
Maybe the working could have been a bit more explicit that we brutally enforce this now on 22.7 but the scope seemed too small for said 3 plugins alone.


fw-5360, fw-5361, fw-5362, fw-5324, search refactoring and tests

Description of Changes

convert all indexes to use IndexManagers, with tests
convert all indexing signals and tasks to call IndexManager methods, with tests
update disconnect_signals and reconnect_signals methods to use a single list of signals

Checklist

[ ] README / documentation has been updated if needed
[x] PR title / commit messages contain Jira ticket number if applicable
[x] Tests have been updated / created if applicable
[ ] Admin Panel has been updated if models have been added or modified
[ ] Migrations have been updated and committed if applicable
[ ] Team Postman workspace has been updated if applicable

Reviewers Should Do The Following:

[ ] Review the code changes here
[ ] Pull the branch and test locally

Additional Notes
N/A

Also wanted to mention, I tested it locally after the update, and the rebuild_index command works as expected after removing the --site flag.


Introduce static analysis + fixes

Hello!
This is PHPStan for Timber and some fixes.
Try running vendor/bin/phpstan analyze -l 1 (Level 1) if you want to discover more errors.
Level 2 is minimum suggested, but robust code can be reached on Level 7.
Current Level 1 errors:
 ------ --------------------------------------------------------------------
  Line   Comment.php
 ------ --------------------------------------------------------------------
  209    Access to an undefined property Timber\Comment::$comment_approved.
  275    Access to an undefined property Timber\Comment::$comment_parent.
 ------ --------------------------------------------------------------------

 ------ ------------------------------------------------------------
  Line   Core.php
 ------ ------------------------------------------------------------
  126    Call to an undefined method Timber\Core::get_meta_field().
 ------ ------------------------------------------------------------

 ------ --------------------------------------------------------------------------------
  Line   Image.php
 ------ --------------------------------------------------------------------------------
  99     Timber\Image::__construct() does not call parent constructor from Timber\Post.
 ------ --------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------
  Line   ImageHelper.php
 ------ -------------------------------------------------------------------
  152    Variable $file_path in isset() always exists and is not nullable.
 ------ -------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------
  Line   Integrations/CoAuthorsPlusUser.php
 ------ ---------------------------------------------------------------------------------
  40     Access to an undefined property Timber\Integrations\CoAuthorsPlusUser::$avatar.
 ------ ---------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------
  Line   MenuItem.php
 ------ --------------------------------------------------------------------
  79     Access to an undefined property Timber\MenuItem::$name.
  301    Access to an undefined property Timber\MenuItem::$_menu_item_type.
 ------ --------------------------------------------------------------------

 ------ ---------------------------------------------------------
  Line   Site.php
 ------ ---------------------------------------------------------
  180    Access to an undefined property Timber\Site::$pingback.
 ------ ---------------------------------------------------------

 ------ -----------------------------------------------------
  Line   User.php
 ------ -----------------------------------------------------
  154    Access to an undefined property Timber\User::$name.
 ------ -----------------------------------------------------

szepeviktor/phpstan-wordpress 0.1.1 requires php ~7.1 -> your PHP version (5.6.30) does not satisfy that requirement.

Static analysis does not run on PHP 5. Maybe moving from composer.json to composer require command in the CI would solve it.

Coverage remained the same at 94.262% when pulling 4d6ae5d8644e45858740d597648b90a6259f6bb4 on szepeviktor:static-analysis into baaa1960193cffb5fa7c43c09114d6831764eede on timber:master.

Coverage remained the same at 94.262% when pulling 4d6ae5d8644e45858740d597648b90a6259f6bb4 on szepeviktor:static-analysis into baaa1960193cffb5fa7c43c09114d6831764eede on timber:master.

@szepeviktor thanks for the PR and running this tool. It caught some stuff we should def. fix. Here's what I think we should do here:

Resubmit this as a PR against 2.x. The package requires PHP 7 anyway, so you'd avoid the PHP 5 issues we see here. I think we still will want to do some thinking about adding another tool in the build process (which could perhaps slow down test setup and running), but that will be a better place to consider.
Submit a new PR against master with just the fixes themselves. We'll still need to be mindful of potential merge conflicts with 2.x (we're avoiding big codebase sweeps for spacing, etc.) — but there are a lot of good catches here that would be nice to be caught up on

I agree with @jarednova. I’m interested in having a tool like PHPStan available in Timber, even if it’s only available as a Composer script.
@szepeviktor Would you mind adding a separate pull request with the all the necessary files to run PHPStan, but without any fixes applied? And could you do that against the 2.x branch?

Closing in favor of #2149


A pricing page displaying a license activation form with only the field's have email and license key inputs.

Preview UI
Here is the Vue code for the pricing page displaying a license activation form with email and license key inputs:


Fixed undefined usage of right-shift (shifting by 64), which resulted…

The rotation was failing in some cases because right-shift was being called with a shift of 64, where it was assumed the result would be 0, but is actually undefined according to the spec (the shift value has to be strictly smaller than the size in bits of the variable type).
Also fixed the iterator to access the tables, which did not work properly (dereferencing the first time always returns 0 because J1F/J1N is never called, and trying to iterate through an empty table caused an infinite loop).

Can you split this up into separate commits?

Can you also create some tests for the 3 iterator changes? (The right shift is clearly a bug.)

Actually, don't worry about writing any unit tests. I've gone ahead and done that in #19 already. I'm going to cherry-pick that single line into a separate commit. I also emailed you privately about the author email address. Please let me know if correcting that is alright.

My other email bounced, so I'll just update it directly. This commit contained an email pointing to an EC2 host<EMAIL_ADDRESS>I've changed that to an email address which you've published in this repository: https://github.com/eyvindn/darkphoton-engine. However, that email address appears to bounce as well. Considering their both not valid email addresses, I'm just going to leave it with the version that I've changed.
I'm closing this in favor of #20 which I've slightly modified from your original.

That's odd, apologies for that and for the late reply, I've been away the past few days.
I'm not sure which email you found in the other repository, but my email is eyvind.niklasson [at] gmail.com if it's still relevant.


Add height attribute

Otherwise, in FireFox, the  and  elements take just as much height as is needed for the content, i.e. the unordered list of questions. So the image appears not at the bottom of the browser window, but the bottom of the  element, which is surprising when you follow the tutorial.
Please test in your environment as well.

I see the issue you describe in Firefox but not in Chrome. Unfortunately, adding height: 100%; adds a scrollbar which doesn't look so nice. Maybe a solution could be to remove "right bottom" from the CSS and modify the sentence that follows to say, "you should see the background loaded in the top left of the screen."

Ha! I failed to notice that scrollbar!
I like your alternative to circumvent the issue alltogether as it's not relevant to what is explained in the tutorial.
Yet another solution seems this: html {height: 100%}; instead of adding the height to body.
Finally, I could sort of reproduce the error in Chrome by adding  to the .html.


22 typos

% codespell  # https://pypi.org/project/codespell
./src/sshd/README.md:80: seciton ==> section
./src/sshd/NOTES.md:60: seciton ==> section
./src/github-cli/install.sh:37: locaiton ==> location
./src/desktop-lite/install.sh:179: strech ==> stretch
./src/desktop-lite/install.sh:368: runnning ==> running
./src/common-utils/main.sh:295: independant ==> independent
./src/dotnet/install.sh:319: dependecies ==> dependencies
./src/dotnet/install.sh:320: dependecies ==> dependencies
./src/ruby/install.sh:81: locaiton ==> location
./src/nix/nix-entrypoint.sh:18: configuraiton ==> configuration
./src/nix/utils.sh:94: locaiton ==> location
./src/nix/install.sh:15: securly ==> securely
./src/git-lfs/install.sh:68: locaiton ==> location
./src/terraform/install.sh:55: locaiton ==> location
./src/git/install.sh:37: locaiton ==> location
./src/docker-in-docker/install.sh:140: suppported ==> supported
./src/docker-in-docker/install.sh:308: doesnt ==> doesn't, does not
./src/python/install.sh:88: locaiton ==> location
./src/go/install.sh:147: locaiton ==> location
./src/docker-outside-of-docker/install.sh:129: suppported ==> supported
./src/docker-outside-of-docker/install.sh:212: runns ==> runs
./src/docker-outside-of-docker/install.sh:263: doesnt ==> doesn't, does not

Wow! codespell is such a neat tool.
@cclauss Thanks for reporting the typos, much appreciated.


[#96986300] Smoke tests to on alert demo environment issue

Refactor of how smoketests are defined:

create unified smoketest job template, with parametrized name, deploy environment, target platform, cron triggers and email address for notifications
use this new template to define all smoketests:

smoketest-ci-aws
smoketest-ci-gce
smoketest-demo-aws
smoketest-demo-gce

set demo smoketest run periodicity to 2 minutes, so that jobs run often and issue notification delay is minimised

How to deploy on Jenkins
Because these jobs have different names that the current smoketest-aws and smoketest-gce, these two old jobs need to be removed manually. You would also need to remove the default dsl job, because it would re-create these smoketest jobs on ansible run. After you have removed these 3 jobs, subsequent ansible run will create a new default dsl job which will in turn create all the new smoketest jobs.

The code looks :+1: but I haven't been able to test this and I'm not able to do the deployment right now. Could someone else merge and see it out?

Added the demo job back in.


add IBC transfer timeout

Summary
Add ibc transfer timeout that is relative to the current LC height. Previously, we were timing out IBC transfers at 1_000_000 blocks, which is obviously wrong (we just added this as a stopgap before we could easily pull the LC height!). Concretely,

Timeout at a relative block height in hooks.go
Add DefaultIbcTimeoutBlocks param

Open questions

How stale could the LC be when this is called? The "real" timeout is the timeout - staleness, so the LC is 20 min stale, the "real" timeout will happen 10 min after the transfer is called. Should we raise the timeout so that this is safer? Higher timeouts don't really matter to Stride

Test plan
TODO: run integration tests

LGTM! Please run integration tests before merging


Display momentary black-out

Microsoft PowerToys version
0.76.2
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
General
Steps to reproduce
2023-12-18.txt
✔ Expected Behavior
No response
❌ Actual Behavior
Display flickered, seemed like a gpu glitch or crash at the time it happened.
Other Software
No response

Hello and thanks for your message. Can you tell what happened before the issue? Was it at the start-up of PowerToys, or a specific module, or..?

Hello, thanks for the reply.
Nothing was happening before, PowerToys was idle at the system tray, I have it running on startup.
So no specific module that I can tell.
It actually occured again after a system reboot. The log was appended.
2023-12-18.txt

Error from the report
System.Runtime.InteropServices.COMException: {Desktop composition is disabled} The operation could not be completed because desktop composition is disabled. (0x80263001)
   Source: PresentationFramework
   TargetAssembly: PresentationFramework, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35
   TargetModule: PresentationFramework.dll
   TargetSite: Void DwmExtendFrameIntoClientArea(IntPtr, Standard.MARGINS ByRef)
   at Standard.NativeMethods.DwmExtendFrameIntoClientArea(IntPtr hwnd, MARGINS& pMarInset)
   at System.Windows.Shell.WindowChromeWorker._ExtendGlassFrame()
   at System.Windows.Shell.WindowChromeWorker._UpdateFrameState(Boolean force)
   at System.Windows.Shell.WindowChromeWorker._HandleDwmCompositionChanged(WM uMsg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at System.Windows.Shell.WindowChromeWorker._WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at System.Windows.Interop.HwndSource.PublicHooksFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

Looked a bit into this error and it's kinda weird.
References:

https://learn.microsoft.com/en-us/windows/win32/api/dwmapi/nf-dwmapi-dwmiscompositionenabled
https://learn.microsoft.com/en-us/windows/win32/dwm/wm-dwmcompositionchanged
https://github.com/dotnet/wpf/blob/v8.0.0/src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Shell/WindowChromeWorker.cs

Desktop composition should be always enabled from Windows 8 and we should never receive WM_DWMCOMPOSITIONCHANGED.
Also note that the code that handle the message double check if composition is enabled.

@Salim-F8 Does this still happen? Could you try updating your graphic card driver if it's not up to date? /needinfo

@crutkas prio-0 but also closed?

FYI Discussion moved here https://github.com/microsoft/PowerToys/issues/31226

@Salim-F8 Does this still happen? Could you try updating your graphic card driver if it's not up to date? /needinfo

Soon after the issue disappeared. Dunno want triggered it to be frank, but I didn't update my GPU drivers in the meantime for sure.
Sorry for the belated feedback.

/
Is this still an issue with the latest version? /needinfo

@ethanfangg Do you know what the actual status of this issue is, at the moment?

@ethanfangg Do you know what the actual status of this issue is, at the moment?

Hi @Jay-o-Way , no one in the team managed to repro. Idea is try to merge https://github.com/microsoft/PowerToys/pull/32118 and see if that brings reports down. Looks a bit worse, but it's better than a crash.

I'm experiencing the same issue, but I'm running PowerToys v<IP_ADDRESS>, which is the latest version at the time of this writing.
I opened an issue for it the other day, but then I found this one, so I closed my issue and I'm now subscribing to this one.

Windows (not the OS, but the windows of any program like Notepad, vscode, etc.) freeze. Do not respond to clicks anymore. Mouse does still work when the screen is about to crash to black.
I have this issue happening every 2 hrs-ish. Not only when using the hotkey to open up PowerToys Run.
I also noticed that the run window has no content when opening it just after a full crash.
Events in order:

no interactions with windows possible, mouse movement works
screen goes to black
screen comes back with content of programs being redrawn. Except for Freecad, which gets stuck.
PowerToys run shows no content in window 1st time
PowerToys run shows content in window 2nd time

Graphics card is a ASRock AMD Radeon RX6750 XT 12GB with version from Device Manager properties: 30.0.15021.11005
Any tracing I can turn on to find out more? Due to the multiple crashes a day, I can have a relatively fast turnaround.

I was AFK and had this error log when I came back to my PC.
Version: <IP_ADDRESS> OS Version: Microsoft Windows NT 10.0.19045.0 IntPtr Length: 8 x64: True Date: 2024-07-01 7:50:16 PM Exception: System.Runtime.InteropServices.COMException (0x80263001): {Desktop composition is disabled} The operation could not be completed because desktop composition is disabled. (0x80263001)    at Standard.NativeMethods.DwmExtendFrameIntoClientArea(IntPtr hwnd, MARGINS& pMarInset)    at System.Windows.Shell.WindowChromeWorker._ExtendGlassFrame()    at System.Windows.Shell.WindowChromeWorker._UpdateFrameState(Boolean force)    at System.Windows.Shell.WindowChromeWorker._HandleDwmCompositionChanged(WM uMsg, IntPtr wParam, IntPtr lParam, Boolean& handled)    at System.Windows.Shell.WindowChromeWorker._WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)    at System.Windows.Interop.HwndSource.PublicHooksFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)    at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)    at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

received same error on 0.82.1

This is /dup #31226 . De-duping against that one since more recent discussion is in that one.


[Discussion] Azure Functions Runtime release 3.1.0

Discussion issue for the Azure Functions runtime release 3.1.0: https://github.com/Azure/azure-functions-host/releases/tag/v3.1.0

Is the change from version 3.0.x to 3.1.x because of compatibility implications? Or was it just a change in versioning conventions?

When will this release go live? Looking at older release announcements it seems that most are deployed in a few days at most. I tried to create new function apps in multiple different regions (centralus, westeurope, uksouth, germanywestcentral), but all of them launched with runtime version "3.0.15885.0". Do I have to opt in somehow?

cc @yojagad @fabiocav  @pgombar
@shibayan - Regarding

Is the change from version 3.0.x to 3.1.x because of compatibility implications? Or was it just a change in versioning conventions?

This is a change in versioning conventions no compatibility implications.
@ietz - We found a blocking issue with release 3.1.0 - https://github.com/Azure/azure-functions-host/issues/7537 - we are in the process of patching and releasing a new version soon.
Closing this issue for now.


Add the gitlens.hovers.avatars configuration option

This setting allows disabling/enabling showing avatars in hovers. We already have settings for the explorer and blame gutter, so it makes sense to also have one for the hovers.

Awesome -- thank you for the contribution! It looks great!


Incorrect request format when exchanging authorization_code for tokens

Per OIDC spec <IP_ADDRESS> the Client Id and Secret must be encoded into the Authorization header.
http://openid.net/specs/openid-connect-basic-1_0.html#TokenRequest
I have a PR that might fix the bug, but I can't get the source to build. (version '2.1.0-preview3-26413-05' was not found.) Too much hassle to get this built. Installed VS 15.7 and latest available 2.1 preview and still errors.
I also have a much more tedious workaround for our actual application that involves implementing my own RedeemAuthorizationCodeAsync at the app level.

FYI, this was already discussed here: https://github.com/aspnet/Security/issues/1032.

Yup, this is dup of #1032. Closing.


Module not found error

I have installed xWebAdministration v <IP_ADDRESS> on my source server using Install-Module command. Then I copied the folder <IP_ADDRESS> folder from my source server to target node under C:\Program Files\WindowsPowerShell\Modules\xWebAdministration folder.
When I try to run a DSC configuration which is referencing resources from this module, I get not found error, Unable to load module 'xWebAdministration': module not found.
On my target node, if I execute this statement, $m = Get-Module -ListAvailable xwebadministration then $m is null. However, $m is returned with valid object on my source server.
P.S. My source server is running WMF5.0 RTM and my target is 2012R2 (POSH 4.0)
Am I missing something?
Thanks!

@sameer-kumar WMF/PowerShell 4.0 doesn't like the version folder. Copy the contents of the <IP_ADDRESS> folder one level up into the C:\Program Files\WindowsPowerShell\Modules\xWebAdministration folder and then delete the <IP_ADDRESS> folder.

Hey @sameer-kumar - as we haven't heard from you in a while I'm going to close this issue, if you are still having an issue please feel free to reopen this.


Authentication fail on some private registry

Hello,
I am in the process of migrating rules_docker to rules_oci.
I'm having a few problems when pulling some images from a private registry.
With rules_docker it worked.
But with rules_oci, I get 401 error.
I need to use the credential_helper feature to succeed at pull, by exchanging tokens  by hand using a basic auth:
username="nologin"
password="..."

input=$(cat)
uri=$(jq -r ".uri" <<< $input)
authh=$(curl -v "$uri" 2>&1 /dev/null|grep "www-authenticate:")
authuri=$(echo $authh | sed 's/.*realm="\([^"]*\)".*/\1/')
authhost=$(echo $authuri | sed 's/^https:\/\/\(.*\)/\1/')
authservice=$(echo $authh | sed 's/.*service="\([^"]*\)".*/\1/')
authscope=$(echo $authh | sed 's/.*scope="\([^"]*\)".*/\1/')

res=$(curl -fsSL "https://$username:$password@$authhost?service=$authservice&scope=$authscope")
echo "$res" | jq '{headers:{"Authorization": [("Bearer " + .token)]}}'

It works, but it doesn't look very pretty to me (I'm not sure if this will work if the scope changes)
Is there any particular reason why this no longer works?

This is due to limitation in Bazel where rules_oci can't see what headers the server has sent, therefore can't perform the WWW-Authenticate challenge unless the challenge unless it is listed here https://github.com/bazel-contrib/rules_oci/blob/e4ceef02ad9f03551c7473c17482a39776ce4e24/oci/private/authn.bzl#L10
This worked in rules_docker because it did not use Bazels Http Downloader for pulling images, for better or worse.
May i ask why are you using a credential helper? You should be able to use existing docker auth mechanisms.

When I do a docker login to generate the "auths" entry in .docker/config.json, I get an error 401 when pulling from my registry. I will try to patch rules_oci to add an entry in _WWW_AUTH en see if this work.
Thank you

Closing this in favor of https://github.com/bazel-contrib/rules_oci/issues/126


Fixing build on Android SDK 24.3.4.

SDK now depends on platform tools revision 23 or later. (We cannot build with 21 anymore.)
addon-google_apis-google-19 has been changed by Google to addon-google_apis-google-19-1

The addon has not been renamed on a clean install

Can you make a new PR with only the android.sdk.platform change so I can merge that one.

The addon has not been renamed on a clean install

You're right. I can confirm this after a complete re-install of the SDK. Now the directory is named “addon-google_apis-google-19” here as well.
Thanks for the feedback.

Can you make a new PR with only the android.sdk.platform change so I can merge that one?

I think I changed the pull request now. (Sorry, I am not that used to github.com yet.)

Can you squash ?

I guess I did. ;-) Thanks for the patience.

Thank you for your PR


Drag and drop file loading

This feature will be available on all screens of the app, not just the intro screen.
There should be some kind of drop indicator, but we shouldn't worry too much about the specific design yet.

I'll be taking this one. Likely going to make a web component out of it, that accepts drops and does all the magic... innit.

Unexpected Paul Kinlan in bagging area.

I'm a sucker for dragndrop.... silos innit

also, I need to learn typescript and preact and stuff.

@jakearchibald @surma do we use ShadowDOM and slots etc?

How I see <file-drop> working:
Applies a class to itself once it detects file(s) over it.
Fires enter and exit events.
Fires drop event. That event should have a files property.
The web component shouldn't have any design. Users should use the change in class name to apply visual changes.
Avoid shadow DOM. We're sticking to the stuff that can be easily pollyfilled.

ok cool..
So I was thinking something like
Note will change to 'file-drop' more explicit.
 <drop-target
    bindTo='some dom select'
    fileType='image/*'
  >
    <some content that will appear as an overlay />
  </drop-target>

I wouldn't bother with bindTo. The element itself is the drop target.
Instead of fileType go with accepts and try to be compatible with https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file#Limiting_accepted_file_types.

Applies a class to itself once it detects file(s) over it.

Not an attribute? (also why is :drop still not implemented anywhere?)

You know, we could just make the  100% of the screen size and just use the default system drop target for file inputs...

@PaulKinlan that would catch clicks too, which we don't want

@surma

Not an attribute?

Attributes aren't really used for state. In a perfect world we would define a pseudo-class for this (which part will eventually give us), so a class feels like the next best thing.

true.

re: bindTo - I was thinking of having the element watch for events on developer defined targets vs this element ultimately being a fullscreen (documentElement), that being said, I'm going to start simple.

@PaulKinlan I went the same way initially, but events can be easily used to change the appearance of the different element.
For Squoosh, I imagine <drop-target> will be the root element, with everything else inside it.

Issues so far before I even get to testing my code....

Unable to build the codecs it seems - that it's error with autoconf 'configure.ac:23: error: possibly undefined macro: AC_PROG_LIBTOOL
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.'  cc @surma
Unable to get webpack to, well, pack via npm run build. It just comes back with a 'Couldn't parse bundle asset "/home/paulkinlan/squoosh/build/main.08649.js".' @developit

If you are on master, you shouldn’t need to build the codecs, the build artifacts are commited, as mozjpeg is non-trivial to build (and I haven’t put everything into docker yet).
npm i && npm run build is all you need.

hmm - @jakearchibald said to fork from Options branch ;)

I'll bring in the master branch...

Combine the two 😄

Well, alternatively just pull the .js and the .wasm from master and remove npm run build:codecs or whatever from the build steps 😄

It turns out npm run start - starts, and seems to have Js, but it errors on the CLI like crazy about being unable to compile.


Gerbers for v0.3c ?

Hi!
First off, many thanks for making this amazing PCB!
I had purchased a set of these PCBs from your Tindie store and had received the boards with the date 04/15/2020 v.3c printed on the silkscreen. I was looking for the corresponding gerber files in this repo but only found the ones for v3(indvidual) and v3b (panelized). Any chance you could upload the ones for the version I have ?
I think it would be immensely useful if you could tag specific commits as releases and/or populate a CHANGES file to let others know what's changed, fixed or improved. I am curious if there are any specific issues with the v3 and v3b that are fixed in v3c ?
Thanks

Thank you for pointing it out to me and I really need to improve my documentation. I can't really remember from 9 months ago but I think just the mounting holes in the middle were added. I just added the newest gerber/eagle files and will have a change log going forward.

Thank you for pointing it out to me and I really need to improve my documentation. I can't really remember from 9 months ago but I think just the mounting holes in the middle were added. I just added the newest gerber/eagle files and will have a change log going forward.


[SPARK-7548][SQL] Add explode function for DataFrames

Add an explode function for dataframes and modify the analyzer so that single table generating functions can be present in a select clause along with other expressions.   There are currently the following restrictions:

only top level TGFs are allowed (i.e. no select(explode('list) + 1))
only one may be present in a single select to avoid potentially confusing implicit Cartesian products.

TODO:

[ ] Python

Merged build triggered.

Merged build started.

Test build #32581 has started for   PR 6107 at commit 52ca0dc.

Test build #32581 has finished for   PR 6107 at commit 52ca0dc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32581/
Test PASSed.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #32665 has started for   PR 6107 at commit e710fe4.

Test build #32665 has finished for   PR 6107 at commit e710fe4.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32665/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #32671 has started for   PR 6107 at commit f9e1e3e.

Do we need to handle conflicts expr ids when there is a self join in the query? (#6114 reminds me about it)

Test build #32671 has finished for   PR 6107 at commit f9e1e3e.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
final class DummySerializerInstance extends SerializerInstance
final class PackedRecordPointer
final class SpillInfo
final class UnsafeShuffleExternalSorter
final class UnsafeShuffleInMemorySorter
 public static final class UnsafeShuffleSorterIterator
final class UnsafeShuffleSortDataFormat extends SortDataFormat<PackedRecordPointer, long[]>
public class UnsafeShuffleWriter<K, V> extends ShuffleWriter<K, V>
public final class TimeTrackingOutputStream extends OutputStream

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32671/
Test PASSed.

@rxin Could you file JIRA issues for cases like this where we should add support in SparkR data frames as well ? It would be good to get it in the same PR here but if not we should at least track it.

Merged build triggered.

Merged build started.

Test build #32683 has started for   PR 6107 at commit d3faa05.

Test build #32683 has finished for   PR 6107 at commit d3faa05.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32683/
Test FAILed.

Merged build finished. Test FAILed.

@yhuai, good catch.  fixed and added test.

Merged build triggered.

Merged build started.

Test build #32684 has started for   PR 6107 at commit 81b5da3.

Merged build triggered.

Merged build started.

Test build #32693 has started for   PR 6107 at commit c176c89.

Test build #32684 has finished for   PR 6107 at commit 81b5da3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32684/
Test FAILed.

Test build #32693 has finished for   PR 6107 at commit c176c89.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32693/
Test PASSed.

Merged build triggered.

Merged build started.

The Python part looks good to me, thanks!

Test build #32746 has started for   PR 6107 at commit 6f80ba3.

Test build #32746 has finished for   PR 6107 at commit 6f80ba3.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32746/
Test FAILed.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #32748 has started for   PR 6107 at commit 7ee2c87.

Test build #32748 has finished for   PR 6107 at commit 7ee2c87.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32748/
Test PASSed.


Explain what has become of separate-front-target-dir

The change in #216 did not explain enough and contradicted the way the option was documented in the README.
See #203 and #217.

Thank you for contributing


Removing a debug log breaks circuit

This issue was identified on branch #10486, which is soon to be merged into master.
Possibly related to this: https://github.com/noir-lang/noir/issues/5771

https://aztecprotocol.slack.com/archives/C04PUD9AA4W/p1733747881614369
Commands, for future reference:
Start the txe:
cd yarn-project/txe
LOG_LEVEL=debug yarn start
Wait 5 seconds.
Run the test:
cd ../noir-projects/noir-contracts
(Update the local path to be yours in the command below:)
NARGO_FOREIGN_CALL_TIMEOUT=300000 /mnt/user-data/mike/aztec-packages/noir/noir-repo/target/release/nargo test --silence-warnings --oracle-resolver http://localhost:8080 --show-output --package nft_contract transfer_in_private_on_behalf_of_other
(And if you want to make quick changes to just the NFT contract, or its dependencies, you can run ./scripts/bootstrap_just_one_contract.sh nft_contract NFT to get the codebase ready for another test run)
(Some other NFT tests would also fail, without the debug log).

@iAmMichaelConnor does this end up failing inside noir or in external code. if you can get this to fail inside of noir then we can mock the oracle calls which will make it much easier to debug.

It's failing inside noir, iiuc.


Incremental cache: fuzzbug: subtract underflow

OSS-Fuzz produced the following crashing testcase for the cranelift-icache fuzz target with the following base64 encoding:
/////wAAARQAAAAAAAAAgADu

(cat that into base64 -d to decode)
The crash is a panic with the message "attempt to subtract with overflow". The stackframe in the oss-fuzz report is fairly useless (line 0 in cranelift-icache.rs?) but hopefully the above reproduces easily.
cc @bnjbvr to diagnose?

So I haven't managed to reproduce:
base64 -d /tmp/encoded.txt > /tmp/decoded.txt gives me what looks like a binary file,
Then I've run
cargo +nightly fuzz run -O --no-default-features cranelift-icache /tmp/decoded
and it runs the binary input without problems (i.e. no crash). I've ran it many times, just to make sure there wasn't any non-determinism. Am I missing something?
I'll post a PR with what could be a fix in the fuzz target itself, though.

Can one of the people who have access to the oss-fuzz infra confirm whether the linked PR fixed this, please?

Ah, thanks for checking. Yes, oss-fuzz confirmed this fixed a few days ago: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=50398


Auto Select Coins on Connection

Hey, can you maybe add to the Panel after a Bot is connected what coins are the best for GPU VRAM Size?

Well the web panel doesn't know how much VRAM the GPU has, and even then there isn't really a "best" coin, it all depends on preference and they all have their own pros and cons. For example, many mine ETC on 8GB cards because it uses less resources (VRAM in this case) so it will impact the user experience less and thus cause less user detections. And mining the new support Ubiq could technically be the most worth since it only uses 1.6GB of VRAM, while it's less profitable overall it could in practice be the most profitable to mine due to longevity and being able to mine on nearly all GPUs (though older ones will have lower hashrate obviously).

Yes but i basically mean for example if the gpu has 8gb it will mining ETH that you can setup it in a config if gpu has 4gb then mining ETC and 6gb+ = ETH and for other coins that you can setup for the gpu ram size


Test YaoBlocks

Needed to check that #426 doesn't break integration with YaoBlocks

LLVM ERROR: Program used external function 'sincos' which could not be resolved!

ah dammit, we are aware of this error. apparently macos x64 libc doesn't export math symbols. it's the reason why we don't test some numeric ops on macos x64.
should be fixed now by skipping the test on that platform

eventually we can fix that by manually exporting a sincos ourselves

eventually we can fix that by manually exporting a sincos ourselves

we could do it by adding a file to the build conditionally, but the question again is if we really want to support macOS x64

eventually we can fix that by manually exporting a sincos ourselves

we could do it by adding a file to the build conditionally, but the question again is if we really want to support macOS x64

At minimum because selfishly my personal laptop is an Intel Mac it would be nice. But also I can fix that problem in another way too xD

At minimum because selfishly my personal laptop is an Intel Mac it would be nice. But also I can fix that problem in another way too xD

ahh ups jajajaj
okay then, how could we export those symbols? i don't understand why those symbols are missing in the first place.
do we need to reimplement them manually or it's just that the symbol filtering on mac is filtering too much?
if it's the symbol filter, then #421 should fix it because it refactors the filter to just stop exporting symbols that match the glob pattern *llvm*


Remove the "I" prefix from interfaces' names

We decided to keep all the names of our interfaces without the "I" prefix.
So, we need to remove it from the existing interfaces.

Already done


Approximate numeric comparison

I used to use https://github.com/ospalh/anki-addons/blob/develop/scalar.py, but I modified it to use different pass factors for different values. Anki stopped being compatible with it. Your add-on seems like the place for the feature.

That seems like it should be possible to add. Let me look into it.

I added a config option for approximate numeric comparisons. You can find the documentation here. Please let me know if there's any issues!

I think it should be specific to decks, note types, or tags. I was using Scalar.py for age, so it was 1.5 for 1-15, 3 for 15-21, 5 for 21-60, 7 for 60-75, 10 for 75-90, 12 for >90. This precision with photos is probably impossible, but the variability applies only to those cards. Of course, when I get around to adding it to my copy, I will probably find a way to make it depend on the note type.

I'm not too familiar with how Anki works apart from how I use it personally, so I'm not completely sure how that would work, or how it would integrate with the existing configuration options.


Adapt installation instructions for .NET interactive + vscode

see title

https://csbiology.github.io/BIO-BTE-06-L-7/ contains now updated instructions for .NET interactive + vscode


Missing a=ice-options attribute in answer sdp

createAnswer doesn't set a=ice-options:trickle in the sdp.

@fippo
For this issue is following a potential solution?
Adding following check at https://github.com/twilio/rtcpeerconnection-shim/blob/master/rtcpeerconnection.js#L1308
if(pc._canTrickleIceCandidates) {
  sdp += 'a=ice-options:trickle\r\n';
}

it looks like ice-options is declarative, see discussion in https://mozilla.logbot.info/media/20180905#c15270769
i'll have a patch shortly.

cherry-picked into the 1.2.14 patch release


Remove Http2ConnectionState::continued_buffer

continued_buffer haven't been used since Aug. 2015 (00ce2f1113baa9485262695a66ee67a08fc5d121).
This is just a cleanup and backporting is not mandatory.

@zwoop It’s up to you. I think it would make future backporting a bit easier (less conflicts).

Cherry-picked to 8.0.x

@maskit This doesn't cherry-0pick cleanly to 7.1.x, can you please make a PR against that branch for v7.1.5

I’m kind of offline. @masaori335 can you make the PR?

Sure


Bot still not working

Traceback (most recent call last):
File "./main.py", line 147, in
r = run()
File "./main.py", line 47, in init
self.init()
File "./main.py", line 105, in init
number_botnet = json.loads(self.b._botnetInfo())
AttributeError: run instance has no attribute 'b'

work now ? redownload please

working now

Great :)


Keep an eye on DWF for possible future inclusion

Keep an eye on the Distributed Weakness Filing project. At some point, it may be desirable to expand DependencyCheck to use it in addition to NVD.

The DWF appears to be assisting in CVE assignments. It does not appear to be a unique vulnerability list. As such, there is no need to include it into ODC.


Global batch size question

Hi!
Thanks again for the awesome repo. I have a small question regarding the global batch size of DPO training reported in the paper vs used in the code base.
In the paper, it mentions that, for DPO, "We train all models with a global batch size of 32". This is consistent to the the hyperparam of HuggingFaceH4/zephyr-7b-beta.
In the codebase, we are suggested to use 8 GPUs to reproduce zephyr-7b-beta here.

You will require 8 GPUs (80GB of VRAM) to train the full model.

Since per_device_train_batch_size=8 in the recipes/zephyr-7b-beta/dpo/config_full.yaml, this means that the global batch size is 64, and not 32, when using 8 GPUs. While this is different from the paper, the global batchsize = 64 setting is consistent with the hyperparam in alignment-handbook/zephyr-7b-dpo-full.
My guess is that global batchsize = 32 or 64 would give similar performance, say, on MT-bench? Could you confirm it? Many thanks! I am about to launch some experiments, and I wish to get the details correct so as to reproduce the results from the paper as closely as possible 🙏.

Yeah, I was thinking the same, should be per_device_train_batch_size: 4  instead of 8 since the assumption is 8 GPUs here.
However, I think the mistake kind of propagated in their own replication: https://huggingface.co/alignment-handbook/zephyr-7b-dpo-full
For the official model released, as you mentioned , the DPO batch params seem to contradict their replication based on this repo.
Also the official model link does not have any details on the SFT part, so I have no idea yet on whether is it LoRA or Full finetuning that the HF team decided to release as the official model.

anyways, I am running an experiment for the DPO based on 4 GPUs, leaving the batch to be 8. If the loss is the same then I can confirm it official release is using the ....-sft-full model and batch size is correct.

Hi!
I re-ran MT-bench to compare the two public DPO-trained zephyr-7b checkpoints:

HuggingFaceH4/zephyr-7b-beta, and
alignment-handbook/zephyr-7b-dpo-full

The MT-bench score of HuggingFaceH4/zephyr-7b-beta (blue curves above) closely reproduces the number reported in the paper. The number is 7.34 in the paper (Table 1), and the score from my re-run is 7.37.
But the MT-bench score of alignment-handbook/zephyr-7b-dpo-full (yellow curves above) was worse overall. The score is 7.09.
There could be multiple reasons, such as:

the randomness of GPT4 evaluation used in MT-bench (if anyone has the resources to rerun MT-bench multiple times, that'll be great)
the difference in the SFT step (the two models used different SFT checkpoints)
the difference in the DPO step (e.g., the global batch size difference that I mentioned; I am not sure if this is the only difference).

I am wondering if you have any insights @lewtun. It would be great if we can use the recipe to reproduce the stronger HuggingFaceH4/zephyr-7b-beta with a MT-bench score of 7.37. 🙏

@liutianlin0121  I do not think it's the issue with the replication of the model (as we go about re-training along the recipes provided). It seems that even the officially released hugging face model score has degraded.

@liutianlin0121 I do not think it's the issue with the replication of the model (as we go about re-training along the recipes provided). It seems that even the officially released hugging face model score has degraded.

Yeah my objective is to reproduce the original model HuggingFaceH4/zephyr-7b-beta. Using the existing code base, I suppose I can reproduce the handbook model alignment-handbook/zephyr-7b-dpo-full, but the latter is somehow weaker in MT-bench compared to the former.

@timothylimyl Yes. I was able to reproduce the MT-Bench score for the official model. But I ran the MT-bench evaluation a few weeks ago. To debug, perhaps it would be useful to take a look at the GPT4-generated judgement at data/mt_bench/model_judgment/gpt-4_single.jsonl. Do they appear reasonable?
In one of my early MT-Bench runs, I used too many concurrent-api-call with
python gen_judgment.py --model-list [LIST-OF-MODEL-ID] --parallel A_LARGE_NUMBER_LIKE_8_or_16
This caused some errors in the GPT4 model judgements at data/mt_bench/model_judgment/gpt-4_single.jsonl. Specifically, some score fields were populated with $error, and these $error were automatically omitted when computing the mean scores. After that, I only use a single concurrent api call, and the evaluation speed is not much slower. Not sure if this is the case for your evaluation, but perhaps it would be helpful to manually look at several model judgement.


Add destroy action to applications endpoint

I thought it was odd that the views had delete/remove links without the implementation. I'm not very efficient with rspec yet so I left an unfinished test to verify child records are destroyed with the application.

You can create a factory for each related record:
Factory(:access_grant, :application => application)
And then check if the related records were destroyed.

You'll probably want to destroy all related access_tokens, not only the authorized ones. I'd do this adding a new relation to the Application model, and removing the :dependent => :destroy from the authorized_tokens relation:
has_many :access_tokens, :dependent => :destroy

@jaimeiniesta you're right, the :authorized_tokens relation will only destroy those who are not revoked.

OK, @davidfrey I can help with this if you want.

Please, go ahead if you have time. I'm overwhelmed with other things at the moment.


Unable to compile to target wasm in v0.9.2 with cw-multi-test v0.19.0

I am using sylvia v0.9.2 which has a dependency on cw-multi-test v0.19.0.
When trying to build the contracts with a wasm as target (using rust-optimizer), the following error occurs:
error[E0432]: unresolved import `cosmwasm_std::testing`
 --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/cw-multi-test-0.19.0/src/addons/api/bech32.rs:2:19
  |
2 | use cosmwasm_std::testing::MockApi;
  |                   ^^^^^^^ could not find `testing` in `cosmwasm_std`

error[E0432]: unresolved import `cosmwasm_std::testing`
  --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/cw-multi-test-0.19.0/src/app.rs:12:19
   |
12 | use cosmwasm_std::testing::{MockApi, MockStorage};
   |                   ^^^^^^^ could not find `testing` in `cosmwasm_std`

error[E0432]: unresolved import `cosmwasm_std::testing`
 --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/cw-multi-test-0.19.0/src/app_builder.rs:7:19
  |
7 | use cosmwasm_std::testing::{mock_env, MockApi, MockStorage};
  |                   ^^^^^^^ could not find `testing` in `cosmwasm_std`

error[E0432]: unresolved import `cosmwasm_std::testing`
 --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/cw-multi-test-0.19.0/src/wasm.rs:9:19
  |
9 | use cosmwasm_std::testing::mock_wasmd_attr;
  |                   ^^^^^^^ could not find `testing` in `cosmwasm_std`

As a result, I am unable to build the contracts. Perhaps we can only have cw-multi-test as dependency on dev / test.

Hi @whalelephant please upgrade to sylvia 0.9.3.
cw-multi-test was unnecessarily enabled when cosmwasm_1_x features were enabled and is not anymore.


Compiler – Semi colon is required when should be optional

Bug Report
🔎 Search Terms
"typescript left side of comma operator is unused and has no side effects"
"typescript property  does not exist on type 'void'"

🕗 Version & Regression Information
Not sure, just tried to write a unit-test and stubled upon it. Here's the unit-test:
fdescribe('interceptor.utils', () => {
  describe('isAssetUrl', () => {
    [
      ['https://domain.com/base-uri', 'https://domain.com', '/base-uri'],
      ['https://domain.com/base-uri/something/assets', 'https://domain.com', '/base-uri'],
      ['https://domain.com/something/assets', 'https://domain.com', '/'],
    ].forEach(([url, origin, baseUri]) => {
      it(`should return false for '${url}'`, () => {
        expect(isAssetUrl(url, origin, baseUri)).toBeFalse()
      })
    })

    [
      ['https://domain.com/assets', 'https://domain.com', '/'],
      ['https://domain.com/assets', 'https://domain.com', ''],
      ['https://domain.com/base-uri/assets/something', 'https://domain.com', '/base-uri'],
    ].forEach(([url, origin, baseUri]) => {
      it(`should return true for '${url}'`, () => {
        expect(isAssetUrl(url, origin, baseUri)).toBeTrue()
      })
    })
  })
})

⏯ Playground Link
Playground link with relevant code
💻 Code
[1,2,3].forEach(console.log) // 🙂

 // 🙁
[1,2,3].forEach(console.log)
[1,2,3].forEach(console.log)

// 🙂
[1,2,3].forEach(console.log);
[1,2,3].forEach(console.log)

🙁 Actual behavior

Element implicitly has an 'any' type because expression of type '3' can't be used to index type 'void'.
Property '3' does not exist on type 'void'.
Left side of comma operator is unused and has no side effects.
Left side of comma operator is unused and has no side effects.

🙂 Expected behavior
To run the code as expected because semi-colons are optional

But the error is correct. The semi-colon is required there, because of JavaScripts ASI behaviour (automatic semicolon insertion).
Take this exampe:
[1]
[0]

This will print 1, because the [0] is used to index access the [1] value.

If you want to enforce semi-free style, the recommended practice (and what's practiced by Prettier) is to put a leading semicolon before any ( or [ at the very beginning of a line:
;[1,2,3].forEach(console.log)
;[1,2,3].forEach(console.log)

;(() => {
  console.log("foo")
})()

I guess I wasn't aware that those statements were affected by ASI ¯_(ツ)_/¯

In my editor I did not 🤔

Maybe an auto backslash insertion hazard?

I guess I wasn't aware that those statements were affected by ASI

IIRC the general rule is, if the statement can be parsed successfully without adding a semicolon, the parser doesn't add one.


Fix Antimony

Motivation for this change
Fix for #45960
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change (none)
[x] Tested the program
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build antimony

Success on x86_64-linux (full log)
Attempted: antimony
Partial log (click to expand)
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17
shrinking /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17/bin/antimony
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17/bin
patching script interpreter paths in /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17
checking for references to /build in /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17...
postPatchMkspecs
/nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17

Success on aarch64-linux (full log)
Attempted: antimony
Partial log (click to expand)
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2pi46k637avr5cq2lckmf9lbz8pnvlx9-antimony-2018-07-17
shrinking /nix/store/2pi46k637avr5cq2lckmf9lbz8pnvlx9-antimony-2018-07-17/bin/antimony
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2pi46k637avr5cq2lckmf9lbz8pnvlx9-antimony-2018-07-17/bin
patching script interpreter paths in /nix/store/2pi46k637avr5cq2lckmf9lbz8pnvlx9-antimony-2018-07-17
checking for references to /build in /nix/store/2pi46k637avr5cq2lckmf9lbz8pnvlx9-antimony-2018-07-17...
postPatchMkspecs
/nix/store/2pi46k637avr5cq2lckmf9lbz8pnvlx9-antimony-2018-07-17

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: antimony
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on aarch64-linux (full log)
Attempted: antimony
Partial log (click to expand)
/nix/store/2pi46k637avr5cq2lckmf9lbz8pnvlx9-antimony-2018-07-17

Success on x86_64-linux (full log)
Attempted: antimony
Partial log (click to expand)
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17
shrinking /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17/bin/antimony
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17/bin
patching script interpreter paths in /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17
checking for references to /build in /nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17...
postPatchMkspecs
/nix/store/adsds6nk6ab9g5nfkx0nrsrhwgbd99cy-antimony-2018-07-17

backported: d164d7eb897


Ray tracing

v.1.0  (2.2.5 beta)
New Features:

Added the basic configurations and modifications needed for ray traced lighting to be utilized while rendering the VirtualHome environment.

Optimized lighting parameters for objects used for illumination.

Converted the project to the HD Render Pipeline.

Performance:

Current ray-tracing performance and ray-traced lighting/shadow quality is not optimal (working to fix this performance issue for v1.1).

NVIDIA GPUs with dedicated Ray Tracing hardware is required to run this environment. The following GPUs recommended for v1.0 is the A6000 or the RTX series 3090, 3080ti, 3080, 3070ti, 3070, 2080ti.

Currently only Windows 10 and 11 is supported to take advantage of ray-tracing features due to DXR integration. (Linux support will come soon!)

Bugs:

Multiple modalities, such as semantic segmentation, depth, instance segmentation, and optical flow are not rendered while raytracing is enabled. (currently working to fix this bug for v1.1).

Certain assets were unable to be used for raytracing (currently working to fix this bug for v1.1).

Here are some images with RT on vs RT off:


Theme customizations, Badge support, and more

resolves #91
This is a huge update pull request here, so feel free to discuss how you want to approach it. This primarily focuses on a few things:

Added Themes and customization support
Added Badge tracking
Added various features like colorbars for move types, and +/- nature labels
Fixing all of the bugs mentioned in previous other Pull Requests here:

#83
#84
#88
#89

There is quite a bit to go over here. The theme stuff is summarized in the #91  issue, though the final release looks a tad bit different. You can see this over on my releases page.

Merged conflicts from updated main into this theme PR. It should be good now, let me know if otherwise.


unless-stopped restart condition error

I think I'm getting the following error:
Traceback (most recent call last):
  File "/home/wibble/docker_compose_swarm_mode.py", line 321, in <module>
    main()
  File "/home/wibble/docker_compose_swarm_mode.py", line 297, in main
    getattr(docker_compose, args.command)()
  File "/home/wibble/docker_compose_swarm_mode.py", line 179, in up
    locals().get(parameter, unsupported)()
  File "/home/wibble/docker_compose_swarm_mode.py", line 105, in restart
    cmd.extend(['--restart-condition', {'always': 'any'}[value], '\\\n'])
KeyError: 'unless-stopped'

because we have the following in our compose files:
restart: unless-stopped

OK - sorry, I see docker swarm service create doesn't support unless-stopped.
I see I have loads of work ahead to convert our compose file, to something suitable to use with docker swarm :-(

Moreover there is no stop command for docker service.
What I do to "stop" the service is scale it to zero replicas. In this case restart "unless-stopped" and "always" would logically do the same so you can just change it to "always" in your configs.


Some feedback

Hi Tanner!  Taking a moment here to provide feedback on this repo, and how it's organized.
I've been developing in RN for three years now, maintaining and developing a variety of projects for a customer.  I'm maintaining legacy RN, and creating new apps used on mobile (with Expo) and browser apps as well.
Given the above, I hope to find a better way to handle queries because man, I wish our mix of legacy and new projects could standardize on something.
React-query looks phenomenal.  But right now, I can't really tell, and finding out is going to be laborious.  Here's why.
I'm having a lot of trouble distinguishing what this repo strictly provides, and the substantial scaffolding surrounding the examples.
In other words, the examples appear good, but they are all a bridge too far because of the external scaffolding required to support all these examples in a common way.
My Suggestion:  this repo needs one or two dead-simple, elementary, stand-alone examples.    No scaffolding, no common conveyance framework.  just one or two dead-simple, trivial examples.
For example, show one get; I don't care what it is, it just needs to be over http(s).  Show one post request, don't care what it is.  Call out to placekitten or something.  Dump what comes back in a <View /> or something.  Dead simple.
I look at the examples and I'm dumbfounded.  This repo's examples imports fetch from four-folders deep, which imports isomorphic-unfetch which is nominally fine, except is that demo scaffolding, or is that critical to react-query?  A dead-simple demo would tell us.
I suppose what I'm saying is, it's hard to distinguish signal from noise here, and it looks like it might cost me a focused day to find out.  This ought to be simple.

Sure, some of the examples have some cruft I would also love to remove. TBH, I took most of them right out of zeit's SWR examples and adapted them for RQ without many changes. IMO, a simple fetch or even just using axios would get the job done. In the sandbox example, we don't even do that and just mock the calls in the same file. This is among many other things that could be simplified.
All in all, I'm sorry if the existing examples are too noisy. I spent WAY more time developing the docs than the examples and I know it shows. I would happily accept any and all PRs to create new examples that are better or improve the existing ones to be more straightforward.
In the future, we are going to have a few example apps on display that use existing apis and simple structure to show how it scales both down to small sandboxes and up to large apps.


Kaibocai/eastasia stage

get private build for test.

Thank you for your contribution! We will review the pull request and get back to you soon.


Error Qualification

A nice feature of the library is that allows you to use floating point precision (instead of double) if you want the extra bits of speed. The cost is accuracy. This shows up in our tests but I want to make a tool that qualifies it for a set of parameters. It's different for different robots - big ones suffer more from accuracy problems.

It's probably overkill to use anything but double. I just wanted the option to use this in things like gpgpu programming.
In my tests (found in open prs) I have seen:
Fk float vs double: 0.2 vs 0.5 us.
Ik float vs double: 1.5 vs 3 us.


P2P sync update for 0.13.2 hashing scheme

I don''t think I fully understand what is happening in this PR. We have a migration which is only responsible for storing p2p hashes but i don't fully understand what would happen if someone where to sync from an empty DB.
Can you please explain the work flow of this PR?

Migration
This migration consists of 2 steps:

Save post-0.13.2 hashes for pre-0.13.2 blocks. This is done in any case, even for empty db, because we need these hashes to validate blocks using post-0.13.2 algorithms.
Update block commitments for pre-0.13.2 blocks we have in db.

Hash calculation
The blockHash function now returns a hash and commitments. The version of these hashes matches the version of the block. Commitments must be post-0.13.2 if possible (there are some exceptions for deprecated networks and tests for them)


VPN Connectivity tab not available

Seems the VPN connectivity tab is no longer visible. Has the functionality been discontinued?
Multiple tenants checked while signed in as GA.

https://github.com/MicrosoftDocs/windowsserverdocs/blob/main/WindowsServerDocs/remote/remote-access/how-to-aovpn-conditional-access.md#conditional-access-for-vpn-connectivity-using-microsoft-entra-id:~:text=To create root,Select Create.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9c54ec64-15b2-ba84-ea00-27dde4334911
Version Independent ID: 9c54ec64-15b2-ba84-ea00-27dde4334911
Content: Configure conditional access for VPN connectivity using Microsoft Entra ID
Content Source: WindowsServerDocs/remote/remote-access/how-to-aovpn-conditional-access.md
Service: windows-server
Sub-service: remote
GitHub Login: @anaharris-ms
Microsoft Alias: wscontent

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


[BUG] Some incompatibility with upgrading from Cython 0.29.36 to Cython 3.0

Describe the bug
Earlier today, I encountered an error about "No suitable method found" when compiling our codebase using Cython 3.0. I think this is probably due to some updates to Cython 0.29.x
Unfortunately, the code is a bit large for me to create a MWE. As the library we work on is Open source, so I will try and point out the relevant lines of code below. Hopefully, this would give reasonable idea of what we are trying to do.
We have an object defined in c++ code
    using data_reader = pyException (*)(void *, TileDimensions<CTYPE>,
                                        std::vector<RTYPE> &);

In Cython, this is wrapped in the following way here
        ctypedef pyException (*data_reader_d) (void*, TileDimensions[double], vector[double]&)
        ctypedef pyException (*data_reader_f) (void*, TileDimensions[float], vector[float]&)
        ctypedef pyException (*data_reader_f_i) (void*, TileDimensions[float], vector[uint32_t]&)
        ctypedef pyException (*data_reader_d_i) (void*, TileDimensions[double], vector[uint32_t]&)
        ctypedef pyException (*data_reader_f_byt) (void*, TileDimensions[float], vector[uint8_t]&)
        ctypedef pyException (*data_reader_d_byt) (void*, TileDimensions[double], vector[uint8_t]&)

        pyFileHandler(data_reader_f py_f, void* py_class, string filename) nogil except +
        pyFileHandler(data_reader_d py_f, void* py_class, string filename) nogil except +
        pyFileHandler(data_reader_f_i py_f, void* py_class, string filename) nogil except +
        pyFileHandler(data_reader_d_i py_f, void* py_class, string filename) nogil except +
        pyFileHandler(data_reader_f_byt py_f, void* py_class, string filename) nogil except +
        pyFileHandler(data_reader_d_byt py_f, void* py_class, string filename) nogil except +

and here
ctypedef pyException (*data_reader_f) (void*, TileDimensions[float], vector[float]&)
ctypedef pyException (*data_reader_f_i) (void*, TileDimensions[float], vector[uint32_t]&)
ctypedef pyException (*data_reader_f_byt) (void*, TileDimensions[float], vector[uint8_t]&)
ctypedef pyException (*data_reader_d) (void*, TileDimensions[double], vector[double]&)
ctypedef pyException (*data_reader_d_i) (void*, TileDimensions[double], vector[uint32_t]&)
ctypedef pyException (*data_reader_d_byt) (void*, TileDimensions[double], vector[uint8_t]&)

This is called in the cython code base here
                self.thisptr.reset(new pyFileHandler[{{x_type}}, {{x_type}}](
                    <data_reader_{{x_name}}> PyCapsule_GetPointer(self.func_capsule, "setDataFunction"),
                    <void*> PyCapsule_GetPointer(self.cls_capsule, "DataFileHandler"),
                    <string> "".encode('utf-8')))

I am not sure if this is the best way to do this wrapping in Cython. I believe the error happens because of multiple declarations for different types which causes Cython parser to throw strange errors. Though, this has been working fine with Cython 0.29.x, it seems this is not acceptable in Cython 3.0, so, any information on why this is not working or what is an appropriate way to approach would be helpful.
Code to reproduce the behaviour:
# example code

Expected behaviour
No response
OS
linux
Python version
3.10.x
Cython version
3.0.0
Additional context
No response

^ Seconding that this should be the resolution. I had a similar problem that took ...a while to figure out yesterday.
Both cython cdef functions and any ctypedef function pointers you define in Cython will now have except * in the signature by default. They will not be compatible with any extern ctypedef function pointer types from C files (and vice-versa). Use the noexcept keyword everywhere to omit this and regain the old types. Details here: https://cython.readthedocs.io/en/latest/src/userguide/migrating_to_cy30.html#exception-values-and-noexcept
You can also disable this exception handling change globally with a compiler directive.

Thank you for this comment. I spent the whole day trying to figure out why the code doesn't compile with the new Cython release. I read the section about exceptions but thought nothing of it as it stated:

The behaviour for cdef functions that are also extern is unchanged as extern functions are less likely to raise Python exceptions and rather tend to be plain C functions.

But I kept getting the Function signature does not match previous declaration errors and couldn't understand where was it coming from. Turns out the functions that were throwing this error were indeed extern (from a C header file) but they were declared with __attribute__((weak)) and had to be defined in .pyx file. This created the difference between declarations in .pxd file (extern so I assume with implicit noexcept) and definitions in .pyx file (with the new default except * signature).
To fix this issue I had to add noexcept to declarations (.pxd) and definitions (.pyx) of the functions raising the errors.
Hope that would be useful to someone experiencing similar issue.


pull request for e2e test at 02/05/2017 13:56:06

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Cannot log in procurment

DebugInfo.txt

Procurement 1.9.9 has been released, please retest and reopen your issue if your error persists:
https://github.com/Stickymaddness/Procurement/releases/tag/1.9.9

DebugInfo.log

Hi, @tanvirulislam427, thanks for the report.  In the future, please open a new issue instead of updating a closed one if it is not directly related.
The server is giving a 404 error (page not found) when trying to fetch your initial hardcore league stash tab.  This might be a transient error on GGG's part, but we could use more information.  Is this your first time using Procurement?  Has it been able to download that tab before?  Do you have any characters in the hardcore league?
If you do not need that league's stash tabs, you can disable fetching them.  Uncheck "Refresh on Login" on the login page, then go to the settings tab, enable "Download Only Selected Leagues", and uncheck the Hardcore league.


Make IsHTTPError return HTTPStatusCodeError

Makes IsHTTPError return status code as mentioned in #47.

Coverage remained the same at 86.12% when pulling 943edf5df92d14c6b7a2fb6ce8883d0cadbf25c6 on jpeeler:IsHTTPError into bc5d4ac17be7f9af33683fe4ee3cb44ee89ac667 on pmorie:master.

Changes Unknown when pulling c78e64f63950e50733ef3abdffef299b9cde0f7e on jpeeler:IsHTTPError into ** on pmorie:master**.

I'm still not really sure what the benefit of returning the boolean is at this point since the pointer being nil or not functions the same way as checking the boolean variable.

I'm still not really sure what the benefit of returning the boolean is at this point since the pointer being nil or not functions the same way as checking the boolean variable.

There is no advantage one way or another, purely stylistic preference.

Coverage increased (+0.1%) to 86.721% when pulling 8500fb1cd46773421f236f55815e64ca14bdbde4 on jpeeler:IsHTTPError into c46649fc84234bdda3ca2d12e88bcd0ede1924f4 on pmorie:master.


chore: update localization settings

Just some nitpicks from XCode. This update localization settings (which we don't really use. But they WERE out of date). Gets rid of the deprecated language for development and adds a static analyzer for missing translations

Thank you! Localization is something we should look into... eventually...


Ethereum mainnet's native token icon is used as Rinkeby native token icon

Seems to happen after switching back from mainnet. The balance looks correct (i.e. it is Rinekby's). Something like:

Enable testnet
Pull down in Wallet tab
Enable mainnet
Pull down in Wallet tab
Enable testnet
Pull down in Wallet tab

The Ethereum mainnet's native token's icon (sometimes?) is shown:

@justindg looks like we're seeing the fallback/default icon here. It could due to either an old process loading the wrong tokenIcon, or tokenIcon aborting.
Also, is this 0x007 ?? - be careful with having this wallet on your phone, don't accidentally send any eth to it, it's got sweep bots watching the balance.

Either way, I wasn't able to reproduce it, you might have more luck.

I have seen this now. Will attempt to fix.


Transitions to/from SVG elements get borked during scroll...

...because we're using position: fixed (for the main SVG element). Should probably invalidate-and-recalculate on scroll events for those cases.

I managed to get into state where I have two animations happening one after the another while scrolling during transition from SVG element to another; as if there were two of the same animations running.
Another issue I've noticed that the animation may suddenly go at double speed after scrolling during SVG element transition, which seems like a slightly different issue.
All this happened on the ramjet homepage and on Firefox.

position: fixed issue is fixed


Login error with {"code":"UNIMPLEMENTED"}

Hello, for the following code below:
`const FACEBOOK_PERMISSIONS = ['email'];
Plugins.FacebookLogin.login({permissions: FACEBOOK_PERMISSIONS}).then((response:FacebookLoginResponse)=> {
console.log('Login successful');
console.log(JSON.stringify(response));
            }).catch((error)=>{
                console.log('Login error');
                console.log(JSON.stringify(error));
            });`

I get following error in XCode when I run on simulator. I didn't test on a device. (with browser - ionic serve - the login works)
⚡  [log] - Login error
⚡  [log] - {"code":"UNIMPLEMENTED"}
I was following the sample here:
https://enappd.com/blog/facebook-login-in-capacitor-apps-with-ionic-angular/128/
What can be the reason of this error message?
Thanks.

It seems, I was following the Capacitor v3 instructions. Then I realized the README for Capacitor v2. I followed the instructions there. It works now.


Fix normalization regarding percent-encoded chars

Fix syntax-based normalization to percent-decode unreserved characters only, leaving all other percent-encoded characters unchanged.
This commit resolves issue #70.

LGTM -- I'll let @glynos have a look and merge when he's ready.

Done. In order to remove the decode_encoded_chars function, I had to make the same fix for path normalization.

LGTM. Thanks for your contribution.


POST API not working

POST API with content of my config gives back the response as "is required".
What is required here? I tried all different options for almost a day now.

It's working, tested and has working samples. Please don't post C# questions to this tracker, those are not related anyhow.

This is not a C# question. It is not working with simple HTML Post as well.


Return NULL for several cases when related objects are not found.

Description of your changes
Return NULL for several cases when related objects are not found.
Resolves #90
I have:

[x] Read and followed Upbound's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested
Just ran make and make reviewable.

@negz this is one possible solution to the linked issue (#90). It simply returns NULL (GraphQL response) when the related object was not found instead of failing the whole GraphQL query. Alternative might be to return an union that is either the success object or an error type.

@negz I was thinking the same thing. I think I will just go ahead and make that change here.


Changing /blog dir to /

Hi there,
I'd like to move my current weblog to tailwind-nextjs-starter-blog preserving URL structure. The problem that I need [website]/[id] instead of [website]/blog/[id]. For example:
http://localhost:3000/guide-to-using-images-in-nextjs
As I am a newbie in Next.js, I don't know what should I change exactly in source code. Can you help me? Thanks.

Hi, I would probably recommend redirecting your existing routes to the new ones. You can see an example of that on my blog.

thanks a lot for the solution!


Backend service for Curve healthy Juice bot does not seem to work correctly.

https://etherscan.io/tx/0x694ef89a123a11b3ccf882a05184c177116676ca933f9a14095411dc3cb1ae8a
https://etherscan.io/tx/0xec5b9ecd84fb8e4ec69c4e805f3f32ef8562b92d03fc415df3a0cc7042a023da
I tried to test Curve healthy juice bot and created 2 bots.
I set the profit taking as 1% with 6x leverage so when the BTC price raises 0.2%, the repay should be triggered but it didn't yet.
And on my bot page, the health shows 0%. I don't think it is correct.
Furthermore, it shows the health shows 0% and health threshold is 3% so it should trigger repay but it does not.
Please fix these issues. Otherwise we can not use this Curve Healthy Juice bot.

@rootedbox The backend api doesn't return the health value for the Curve Healthy bot. So users show 0% of bot health. Please add the health value to the API results for the Curve Healthy bot, just like Levearge and Juice(Squeeze) bots.

Multiple bots with same bug...
https://github.com/VolumeFi/curve-healthy-juicebot/pull/16
https://github.com/VolumeFi/llamalend-leverage-lending-bot-/pull/5
https://github.com/VolumeFi/curve-noob-leverage-lending-bot/pull/8
this seems to have resolved the issues.

May 14 21:09:08 bots-server start.sh[384164]: executeWithdraw(withdraws) []
May 14 21:09:10 bots-server start.sh[384164]: processWithdrawEvents(withdrawn_events)
May 14 21:09:10 bots-server start.sh[384164]: cycleDeposits [{"id":828,"deposit_id":0,"token0":"0x2260FAC5E5542a773Aa44fBCfeDf7C193bc2C599","token1":"0xf939e0a03fb07f59a7>
May 14 21:09:10 bots-server start.sh[384164]: Health updated successfully.
May 14 21:09:10 bots-server start.sh[384164]: id health health_threshold:<PHONE_NUMBER>366478517 300
May 14 21:09:10 bots-server start.sh[384164]: id health profit_taking:<PHONE_NUMBER>366478517 null
May 14 21:09:10 bots-server start.sh[384164]: Health updated successfully.
May 14 21:09:11 bots-server start.sh[384164]: id health health_threshold:<PHONE_NUMBER>617408416 300
May 14 21:09:11 bots-server start.sh[384164]: id health profit_taking:<PHONE_NUMBER>617408416 null
May 14 21:09:11 bots-server start.sh[384164]: executeWithdraw(withdraws) []


[Suggestion] Could you please publish it to public maven repo?

For integration test it will be really useful to have it published to maven central.
Ideally will be to have a maven plugin for it.
Thanks in advance

Already there: http://search.maven.org/#artifactdetails|com.scireum|s3ninja|2.3.1|jar

Great, thank you


Can't seem to get sessions working in aspnet core 2.0

I've seen so much information on this it's unreal and it looks dead simple but this weekend I figured I would try converting one of our existing aspnet 4.6 apps over.
Here's what I have in startup ...
using Core.Cryptos;
using Core.Objects;
using Core.Objects.Dtos;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Routing;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection;

namespace ShellCore
{
    public class Startup
    {
        static IConfiguration config;

        public Startup(IConfiguration configuration)
        {
            config = configuration;
        }

        public void ConfigureServices(IServiceCollection services)
        {
            services.AddSingleton(config);
            services.AddSingleton<ICrypto<Signature>>(new AesCrypto<Signature>());
            services.AddSingleton<ICache<PageCacheItem>>(new Cache<PageCacheItem>());
            services.AddDistributedMemoryCache();
            services.AddSession();
            services.AddMvc();
        }

        public void Configure(IApplicationBuilder app, IHostingEnvironment env)
        {
            app.UseSession();

            if (env.IsDevelopment())
            {
                app.UseBrowserLink();
                app.UseDeveloperExceptionPage();
            }
            else
                app.UseExceptionHandler("/Home/Error");

            app.UseStaticFiles();
            app.UseResponseCaching();
            app.UseMvc(routes =>
            {
                routes.MapRoute("default", "{*path}", new { controller = "Home", action = "Index" });
                routes.MapRoute("page", "{*path}");
            });
        }
    }
}

... as soon as I do this in a controller action I get an exception ...
HttpContext.Session...
... The exception reads ...

System.InvalidOperationException: 'Session has not been configured for this application or request.'

... what have i done wrong?

That's odd, the code looks fine. Is there anything odd in the application logs?

Ok so it gets more peculiar ...
Today I opened up the same project on my work pc and without making a single change I built and ran the code without a hitch.
My work machine has had VS 2017 installed on top of win 10 for some time and I always try to take the updates VS comes with when they arrive in the notification.
My home machine that's experiencing this problem is a week old clean install of windows 10 + VS 2017 patched up as needed from the latest installer direct from vs online.
Both are running the enterprise edition so i'm pretty sure it's not a version diff ...
Which made me think there's some sort of missing dependency in a clean install that's missing or something.
Then i copied the project back to my home machine after deleting the copy I already had there.
I did a clean on the solution then a full rebuild and run ... the problem is gone.
I'm totally confused and have no idea what fixed it.
Having tried several cleans and rebuilds before moving the project to my work pc I was confident that those steps alone would not fix the problem so I'm baffled as to what it was.


Got unresolved dependency for the plugins

[warn] 		  +- default:pdffigures2-build:0.1.0-SNAPSHOT (scalaVersion=2.12, sbtVersion=1.0)
[error] sbt.librarymanagement.ResolveException: unresolved dependency: org.allenai.plugins#allenai-sbt-plugins;1.5.0: not found
[error] unresolved dependency: com.eed3si9n#sbt-assembly;0.14.3: not found
[error] unresolved dependency: com.jsuereth#sbt-pgp;1.0.1: not found
[error] 	at sbt.internal.librarymanagement.IvyActions$.resolveAndRetrieve(IvyActions.scala:332)
[error] 	at sbt.internal.librarymanagement.IvyActions$.$anonfun$updateEither$1(IvyActions.scala:208)
[error] 	at sbt.internal.librarymanagement.IvySbt$Module.$anonfun$withModule$1(Ivy.scala:239)
[error] 	at sbt.internal.librarymanagement.IvySbt.$anonfun$withIvy$1(Ivy.scala:204)
[error] 	at sbt.internal.librarymanagement.IvySbt.sbt$internal$librarymanagement$IvySbt$$action$1(Ivy.scala:70)
[error] 	at sbt.internal.librarymanagement.IvySbt$$anon$3.call(Ivy.scala:77)
what should I do?

It seems that I can access these packages on Bintray website (with password and username).


Performance / 100% CPU issue

Hi
Thanks for providing this proxy so it's possible to scroll to specific items on iOS13 as well.
I noticed a problem when I added it to my app - as soon as I included it in a view and did the
ScrollView { proxy in ....  the CPU usage went to 100% while just having the view loaded on screen. (without using the proxy for anyting)
Since all the code is in one file, I copied it in (instead of doing a fork) and fixed the issue with the following if sentence in the .introspectScrollView.
I haven't found anything not working after that if has been added😅
                .introspectScrollView {
                    if self.proxy.coordinator.scrollView != $0 {
                        self.proxy.coordinator.scrollView = $0
                        self.proxy.offset = $0.offsetPublisher
                    }
                }

It still feels a bit scary that the introspectScrollView is being executed constantly, but at least this if-guard ensures that the rest of the app-state doesn't have to update.

Hey, thanks! I think I created this issue with the offsetPublisher. I fixed it.

Hey, thanks! I think I created this issue with the offsetPublisher. I fixed it.

Hey, thanks!

Hey, thanks!


Preserve object prototypes when cloning (v2)

This is a backport of #7381, fixing #7340 for v2. Test was modified to support ES5.

I'm working on upgrading to 3.0, I figured this could go in the next bugfix release on 2.9, but didn't realize such a release wasn't in the plans.


sol2 how to get variadic args from lua ?

Latestly, i use sol2 to bind lua in C++, but i have a problem to use it like this . Can someone help me, sorry for my pool english.
I have a variadic template function :
template <typename ... Args>
DBQuery & insert_into(const std::string & tbName ,const Args & ... args)
{
// do some thing with args...
}
how can i use it in lua?

You need to bind the function with the arguments hammered out.  As such, you need to explicitly instantiate each template, and then bind them explicitly:
lua.set_function( "insert_into_number", &DBQuery::insert_into<double> );
lua.set_function( "insert_into_number_number", &DBQuery::insert_into<double, double> );
lua.set_function( "insert_into_string", &DBQuery::insert_into<string> );

"Wow, that's really terrible!", I hear you say. To which I say: Yes, yes it is terrible! But there's no other choice, unless you have a runtime processor you can hook this up to.
sol's natural Overloading Support makes this somewhat better:
lua.set_function( "insert_into", sol::overload(
&DBQuery::insert_into<double>,
&DBQuery::insert_into<double, double>,
&DBQuery::insert_into<std::string>,
&DBQuery::insert_into<double, std::string>
/* etc... */
) );

With the second, you can write insert_into( db, 1 ) or insert_into( db, "wee" ) and it'll automatically pick the right function. But you HAVE to specify all the ones you want in advance. That, or use sol::variadic_args and do your processing at runtime, switching on types and creating a thing you can insert into the DB.
But that's left as an exercise for the reader.

thanks for reply me ! Thats sovle my problem.  But use sol::variadic_args, you must also define different type of functions to use when switch on types. Am i  right?

@ThePhD

You switch on the .get_type(); or use .is<T>(); for the objects.

did you mean that :
lua["f"] = [](sol::variadic_args args) {             for ( auto v : args)             {                 auto type = v.get_type();                 switch (type) { 			    case sol::type::lightuserdata: 			    case sol::type::lua_nil: 				    break; 			    case sol::type::number: 				    // but how i know what the number is int32 or float in C++, so i can convert it to int32 or float 				    break; 			    default: 			    }             } 		});

Did you mean that:

Yes.
v.is<int32_t>(); and v.is<double>(); can differentiate when you have the number classification.

OK  thanks！