[INTEL MKL] Enabling MKL support for FusedBatchNormV3

Adding Intel MKL support for FusedBatchNormV3

Made the changes to the PR as suggested!
Thanks
From: Penporn Koanantakool<EMAIL_ADDRESS>Sent: Tuesday, July 9, 2019 5:41 PM
To: tensorflow/tensorflow<EMAIL_ADDRESS>Cc: Varghese, Jojimon<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [tensorflow/tensorflow] [INTEL MKL] Enabling MKL support for FusedBatchNormV3 (#30386)
@penpornk requested changes on this pull request.
Thank you for your PR!

In tensorflow/core/graph/mkl_layout_pass.cchttps://github.com/tensorflow/tensorflow/pull/30386#discussion_r301346550:

@@ -453,6 +455,18 @@ class MklLayoutRewritePass : public GraphOptimizationPass {

      mkl_op_registry::GetMklOpName(csinfo_.fused_batch_norm_grad_v2),

      CopyAttrsFusedBatchNormV2, AlwaysRewrite,

      kRewriteForLayoutPropagation});

rinfo_.push_back(

   {csinfo_.fused_batch_norm_v3,

    mkl_op_registry::GetMklOpName(csinfo_.fused_batch_norm_v3),

    CopyAttrsFusedBatchNormV3, AlwaysRewrite,

I think you can just call V2's attribute copier here to avoid creating just a wrapper. Please also add a comment here that V3 doesn't have any extra attributes to copy.
⬇ Suggested change

    CopyAttrsFusedBatchNormV3, AlwaysRewrite,

    CopyAttrsFusedBatchNormV2, AlwaysRewrite,

In tensorflow/core/graph/mkl_layout_pass.cchttps://github.com/tensorflow/tensorflow/pull/30386#discussion_r301346782:

@@ -2961,6 +2979,14 @@ void MklLayoutRewritePass::CopyAttrsFusedBatchNormV2(const Node* orig_node,

nb->Attr("U", U);
}
+// Calls corresp api of FBNV2, for V3 on CPU, as there are no additional
+// attributes.
+void MklLayoutRewritePass::CopyAttrsFusedBatchNormV3(const Node* orig_node,
Since this doesn't make any change, let's just use V2 and delete this wrapper.

In tensorflow/core/graph/mkl_layout_pass_test.cchttps://github.com/tensorflow/tensorflow/pull/30386#discussion_r301348420:

InitGraph(

 "node { name: 'A' op: 'Input'}"

 "node { name: 'B' op: 'Input'}"

 "node { name: 'C' op: 'Input'}"

 "node { name: 'D' op: 'Input'}"

 "node { name: 'E' op: 'Input'}"

 "node { name: 'F' op: 'FusedBatchNorm'"

 " attr { key: 'T'            value { type: DT_FLOAT } }"

 " attr { key: 'U'            value { type: DT_FLOAT } }"

 " attr { key: 'data_format'  value { s: 'NCHW' } }"

 " attr { key: 'epsilon'      value { f: 0.0001 } }"

 " attr { key: 'is_training'  value { b: true } }"

 " input: ['A', 'B', 'C', 'D', 'E'] }"

 "node { name: 'G' op: 'Zeta' attr { key: 'T' value { type: DT_FLOAT } }"

 " input: ['A', 'F'] }",

 kCPUDevice);

Is kCPUDevice supposed to be kGPUDevice and is F in EXPECT_EQ actually FusedBatchNormV3 instead of _MklFusedBatchNormV3?
⬇ Suggested change

 kCPUDevice);

 kGPUDevice);

In tensorflow/core/kernels/mkl_fused_batch_norm_op.cchttps://github.com/tensorflow/tensorflow/pull/30386#discussion_r301840518:

@@ -818,10 +829,29 @@ class MklFusedBatchNormOp : public OpKernel {

 // set NAN variance value in case of empty input tensor

 auto saved_variance_data = (*saved_variance_tensor)->flat<U>().data();

 std::fill_n(saved_variance_data, num_elements, static_cast<U>(NAN));

// Changes to support reserved_space_3 parameter in FusedBatchNormV3.

// TODO: This parameter functionality is not implemented on CPU.

//       It is used to hold intermediate results. So the allocated

//       memory is filled with NANs.

if (reserved_space) {

 DCHECK(reserved_space_tensor != nullptr);

 MklDnnShape mkl_shape_reserved_space;

 mkl_shape_reserved_space.SetMklTensor(false);

 AllocateOutputSetMklShape(context, kReservedSpaceIndex,

                           reserved_space_tensor, tf_shape_scale,

                           mkl_shape_reserved_space);

 DCHECK((*reserved_space_tensor) != nullptr);

 // set NAN variance value in case of empty input tensor

This is not variance value, please correct the description.
Nit: Please also capitalize the first letter of the sentence.

In tensorflow/core/kernels/mkl_fused_batch_norm_op.cchttps://github.com/tensorflow/tensorflow/pull/30386#discussion_r301843273:

@@ -843,13 +873,17 @@ class MklFusedBatchNormGradOp : public OpKernel {

   const size_t kScaleIndex = 2;     // index of scale tensor

   const size_t kMeanIndex = 3;      // index of saved_mean tensor

   const size_t kVarianceIndex = 4;  // index of saved_variance tensor

 const size_t kReSpaceIndex = 5;   // index of reserved space 3 tensor

Please type the name in full for readability.
⬇ Suggested change

 const size_t kReSpaceIndex = 5;   // index of reserved space 3 tensor

 const size_t kReservedSpaceIndex = 5;   // index of reserved space 3 tensor

In tensorflow/core/kernels/mkl_fused_batch_norm_op.cchttps://github.com/tensorflow/tensorflow/pull/30386#discussion_r301843594:

   const Tensor& diff_dst_tensor = MklGetInput(context, kDiffDstIndex);

   const Tensor& src_tensor = MklGetInput(context, kSrcIndex);

   const Tensor& scale_tensor = MklGetInput(context, kScaleIndex);

   const Tensor& saved_mean_tensor = MklGetInput(context, kMeanIndex);

   const Tensor& saved_variance_tensor =

       MklGetInput(context, kVarianceIndex);

 const Tensor temp;

 const Tensor& reserved_space_tensor =

     (reserved_space) ? MklGetInput(context, kReSpaceIndex) : temp;

Can we replace temp with Tensor()?
⬇ Suggested change

     (reserved_space) ? MklGetInput(context, kReSpaceIndex) : temp;

     (reserved_space) ? MklGetInput(context, kReSpaceIndex) : Tensor();

In tensorflow/core/kernels/mkl_fused_batch_norm_op.cchttps://github.com/tensorflow/tensorflow/pull/30386#discussion_r301844464:

@@ -1014,9 +1048,16 @@ class MklFusedBatchNormGradOp : public OpKernel {

   U* weights_data = weights_data_tf;

   T* diff_src_data = static_cast<T*>(diff_src_tensor->flat<T>().data());

   U* diff_weights_data = static_cast<U*>(diff_weights.GetAllocatedBuffer());

 U* res_space_data = nullptr;

You can make this a constant using the ternary clause.
const U* res_space_data = (reserved_space)? casting_of_actual_pointer : nullptr;
In general, if any variable is not modified in its lifetime, it should be a constant.

In tensorflow/core/ops/mkl_nn_ops.cchttps://github.com/tensorflow/tensorflow/pull/30386#discussion_r301845649:

.Input("mkl_offset: uint8")

.Input("mkl_mean: uint8")

.Input("mkl_variance: uint8")

.Output("y: T")

.Output("batch_mean: U")

.Output("batch_variance: U")

.Output("reserve_space_1: U")

.Output("reserve_space_2: U")

.Output("reserve_space_3: U")

.Output("mkl_y: uint8")

.Output("mkl_batch_mean: uint8")

.Output("mkl_batch_variance: uint8")

.Output("mkl_reserve_space_1: uint8")

.Output("mkl_reserve_space_2: uint8")

.Output("mkl_reserve_space_3: uint8")

.Attr("T: {bfloat16, float}")

The normal TF version also supports T = half. Do you need to check for half during graph rewrite? Same for the grad op.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/tensorflow/tensorflow/pull/30386?email_source=notifications&email_token=ADSAJKIDHHN4FOMUGHNQ4LLP6UV2NA5CNFSM4H5PDXN2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5ZUASI#pullrequestreview-259211337, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADSAJKJPBZ3ETVZ2AN6OTQDP6UV2NANCNFSM4H5PDXNQ.


Similar Project Question

I was working on something similar before I found your project. My latency from prompt end to response start is 1.5-2 sec:
https://github.com/rangersdesktop/TileProjectV1
I have a demo of an older version of the code and a writeup of the project on my website:
https://rangersdesk.top
I'm running a "Faster-whisper, Ooba API EXL2 model, and XTTS" stack with a 4080 and TR 1950X. You have a lot of experience with these parts so I was wondering if this was the best bet? What stack does VoiceChat2 use on Nvidia?
Thanks!

The test folder has a few different implementations that can be tried. If you want to leverage voicechat2's FE that reports latency, you can just swap components in and use that as a test harness. Good luck!


Simple merge operation is not possible

Example:
---
#@ def array_a():
- 1
- 2
#@ end

#@ def array_b():
- 3
- 4
#@ end
---

modified: #@ array_a() + array_b()

#! would generate:

#! ytt: Error:
#! - unknown binary op: yamlfragment + yamlfragment
#!     in <toplevel>
#!       a.yml:13 | modified: #@ array_a() + array_b()

The user should be able to merge two yaml arrays together trivially

Hey @fredwangwang!
The default merging behavior for arrays is to overwrite them, this is because there is no default criteria for matching items in the array (unlike map items, which can match by key). You can use overlays to merge items into an existing array. Overlays allow you to be specific about how merging should behave. For example, you can remove, replace, or append array items.
To append to array_a you can define the array in your data values:
#@data/values
---
array_a:
- 1
- 2

To append to it, define an overlay with the additional items
#@data/values
#@ load("@ytt:overlay", "overlay")
---
array_a:
#@overlay/append
- 3
#@overlay/append
- 4

There is some additional information and examples on this in our faq.
Please let us know if this is not what you are looking for.

my bad, should've called it append instead of merge to avoid confusing.
So my use case is that I have two function call that each returns a yaml array fragment, and I need to combine them into a single array and assign to a key:
---
#@ def square(nums):
#@ for i in nums:
#! only as an example, I have some complex yaml snippet
#! here that I don't want to rewrite as pure star functions
- #@ i * i
#@ end
#@ end
---
#@ def cubic(nums):
#@ for i in nums:
#! only as an example, I have some complex yaml snippet
#! here that I don't want to rewrite as pure star functions
- #@ i * i * i
#@ end
#@ end
---

#@ input = [1,2,3,4,5]

#! The output I am looking for is the concatenation of:
#! - output from square
#! - output from cubic
nums: #@ square(input) + cubic(input)

Can this use case be satisfied right now without any substantial pain to figure out the tricks?

One way to achieve what you want without adding data values and overlays would be to use templates with the
#@ template.replace() annotation. Templates are often used for editing items in maps, but can also be used in arrays. For your specific example, you can use templates to append the two lists onto the nums item.
---
#@ def square(nums):
#@ for i in nums:
- #@ i * i
#@ end
#@ end

#@ def cubic(nums):
#@ for i in nums:
- #@ i * i * i
#@ end
#@ end

---
#@ load("@ytt:template", "template")
#@ input = [1,2,3,4,5]

nums:
- #@ template.replace(square(input))
- #@ template.replace(cubic(input))

For further information on using templates, here is an example from the ytt playground.

here is how to do it with overlays:
#@ def first(nums):
- 1
- 2
- 3
#@ end

#@ def second(nums):
- 4
- 5
- 6
#@ end

#@ def appended(ary):
#@ for/end a in ary:
#@overlay/append
- #@ a
#@ end
---

#@ load("@ytt:overlay", "overlay")
#@ input = [1,2,3,4,5]
nums: #@ overlay.apply(first(input), appended(second(input)))

appended() effectively takes array and marks each item with overlay/append to indicate how item should be "merged".

closing per above responses.

@cppforlife's example was helpful, but it confused me initially since it didn't make use of the input arguments. I've simplified it just for readability, in case anyone else also got here trying to learn how to accomplish the same thing (merging arrays in ytt). 😄
#@ def first():
- 1
- 2
- 3
#@ end

#@ def second():
- 4
- 5
- 6
#@ end

#@ def third():
- 7
- 8
- 9
#@ end

#@ def appended(array):
#@ for/end item in array:
#@overlay/append
- #@ item
#@ end
---

#@ load("@ytt:overlay", "overlay")
nums: #@ overlay.apply(first(), appended(second()), appended(third()))


Merge cadence

The buildkite is failing as there are new unit tests that are hardcoded to work in PST. I'm thinking to change them to rather work as they are supposed to (at least succeed in UTC) and in separate PR to fix the tests to work in PST as well

Each of the commits is a PR in cadence and contains already squashed sub-commits. Thinking we should just merge this PR w/o squashing? @shawnhathaway


Is it possible to pan view while zoomed in!?

Hello!!
I just installed your latest version on Linux having dabbled a bit about a year ago.
SHADERed is looking more fantasticer than ever!!
I wanted to ask if there's a key+mouse combo to pan the render view while zoomed in?
I'd like to see what the pixels are doing up close and that would be helpful. I know you must have a huge to-do list so don't worry.
Just thought I'd ask! :)
Cheers and Thank You for this free software!

Hey!
Thank you for the kind words, I'm glad you like SHADERed!
There actually is a combo that lets you pan around -- hold the left ALT key + right mouse button while moving the cursor.
Some other shortcuts:

you can ALT + double click with left mouse button to reset the zoom to 100%.
hold ALT + left mouse button while moving the cursor to select an area you want to zoom in

Hope this helps! Cheers!

Awesome thanks for the quick reply!
It seems like on my OS (Ubuntu) that combo is already used as instead of panning I get something like the Windowmanager's "Minimize", "Move" etc menu popping up.
I'll take a look and see if I can unset that in Ubuntu as that fuctionality is not something that I'd miss.
Thanks! I'll post back if that works out.


make goreportcard happy

Change-Id: Ica8c1aa65a7735dff26b0a27ca21a8c85c218500

Codecov Report

Merging #5 (f34047f) into main (212ac16) will increase coverage by 0.65%.
The diff coverage is 85.45%.

@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   80.76%   81.41%   +0.65%
==========================================
  Files           6        8       +2
  Lines        1367     1431      +64
==========================================
+ Hits         1104     1165      +61
- Misses        196      199       +3
  Partials       67       67

Impacted Files
Coverage Δ

usage.go
81.04% <81.04%> (ø)

flag_unsafe.go
86.66% <86.66%> (ø)

flag.go
82.58% <93.42%> (+0.15%)
:arrow_up:

cli.go
77.70% <100.00%> (+0.35%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Use clang-tidy to find performance issues

Use the clang-tidy static code analyzer to find any performance issues within our source code. I've applied the following checks:

performance-faster-string-find: find any string find algorithms that can be improved
performance-for-range-copy: avoid unnecessary copies inside range based for loops
performance-inefficient-vector-operation: when growing a vector inside a loop, reserve the size before
performance-type-promotion-in-math-fn: avoid calling double variants of math functions if the input & output is a float
performance-unnecessary-copy-initialization: avoid creating any local variable which could be references

All review comments adressed & rebased


command: Delete extraneous config files during deploy

This change deletes config files on the server that no longer exist in source. Without this, old config files stick around in the directory, which could result in subtle bugs where code continues to depend on those files existing, only coming to a head when a fresh deployment needs to be done.
I have:

[X] Based work on latest develop branch
[X] Followed the contribution guide
[X] Looked for lint in my changes with hlint . (lint found code you did not write can be left alone)
[x] Run the test suite: $(nix-build -A selftest --no-out-link)
[x] Updated the changelog
[ ] (Optional) Run CI tests locally: nix-build release.nix -A build.x86_64-linux --no-out-link (or x86_64-darwin on macOS)

Thanks!


Add a gradle task to trigger PackageMetadataGen

Current coverage is 83.23% (diff: 100%)

Merging #775 into master will not change coverage

@@             master       #775   diff @@
==========================================
  Files           305        305
  Lines         11646      11646
  Methods           0          0
  Messages          0          0
  Branches       1540       1540
==========================================
  Hits           9693       9693
  Misses         1526       1526
  Partials        427        427

Powered by Codecov. Last update 6b3bebc...3634e5b

LGTM


Update Synology_Plex_Backup.sh

Added check if backup directory is going to been created in user's volume

Please review


Skeletal Animation

Hello all!
I was played with a skeleton animation.
I created a new small project, included standart "goblins" animation which ships with T2D. Everything is good. This anim runs well.
But then I exported an animation from new version of Spine. Now Torque 2D is failed.
I think this happens because the export format was changed, am I wrong?

Exactly, old files and new files are different and they count is different

From what I remember, the atlas file added extra information at its beginning. Removing the first line used to do the trick.
Even if it works, remember that the T2D implementation is partial and based on extremely outdated versions of the Spine runtime; most modern Spine features won't be imported to T2D.

Spine runtime is open; I have seen Torque's loader and Spine runtime loader, there are a huge changes

Meanwhile in both old atlas file and new file the first line is empty and second is a name of a graphic file

Has there been anyone working on finishing or maintaining any Spine runtime support for this? Nathan Sweet had done some work in it but nothing I can find after this Trello or this GitHub
They've since moved Spine work to a waffle, but no further mention of Torque. And I haven't seen anyone in this community that was actively working on it.

Nobody has stepped forward to own Spine support. As I understand it is pretty out-of-date at this point.  You are welcome to take up the challenge.

I saw docs on Spine site and looked making Spine support is less simple than T2D has.
Shoud I dig in :)


Working with Arrays at the Root

Suppose i have array of  URLS. I am trying to convert the below to NSURL objects but couldn't find any method.
[
    "http://google.com",
    "http://facebook.com"
]

But if i have a rootKey like the below json. I can use Decoder.decodeURLArray("urls")(json).
{
"urls" : [
    "http://google.com",
    "http://facebook.com"
]
}

I guess JSON should be AnyObject instead of [String: AnyObject].

it's not clear to me that that's a good way to handle that situation the library itself. it could be managed client-side by doing the following.
create a model with a new initializer that takes in JSON array - and creates a JSON dictionary with a custom key, which is passed to the required initializer:
struct Test: Glossy {

    let urls: [String]

    // introduce JSON array initializer that creates JSON with a custom key
    init?(jsonArray: [AnyObject]) {
        let jsonDictionary = ["myCustomJSONArrayKey" : jsonArray]

        self.init(json: jsonDictionary)
    }

    init?(json: JSON) {
        guard let urls: [String] = "myCustomJSONArrayKey" <~~ json else {
            return nil
        }

        self.urls = urls
    }

    func toJSON() -> JSON? {
        return jsonify([
            "myCustomJSONArrayKey" ~~> self.urls
            ])
    }

}

client-side, use the custom key to retrieve values:
let testJSON = [ "http://google.com", "http://facebook.com" ]
let test = Test(jsonArray: testJSON)

print(test?.urls)

// use the custom key to retrieve array
let myJSON: [String]? = test?.toJSON()?["myCustomJSONArrayKey"] as? [String]

print(myJSON)

i get its not ideal - but the designation of JSON as a dictionary is currently part of the library. thoughts on this solution?

The solution works but I guess this will increase more work for the developer.
JSON could be Object, Array, String, Number and NSNull.
Refer to https://github.com/thoughtbot/Argo/blob/master/Argo/Types/JSON.swift. It is handling all the scenarios of JSON.
The same issue exists with Alamofire also. The parameters are the type of [String: AnyObject] so it doesn't allow us to send post requests using Array of objects. We always have to keep a rootKey like "results" and then pass the array into it.
http://stackoverflow.com/questions/27026916/sending-json-array-via-alamofire
I can work on this with the test cases if you like. I kind of need this functionality to save myself from extra work 😋.

sure, if you have the time to work on it. i'd love to see what you come up with

Update: I was able to solve this in Reactofire itself and it seems to work without changing the Gloss Library. Regards


Error when compiling: source/PlayState.hx:75: characters 8-22 : Type not found : vlc.MP4Handler source/PlayState.hx:1620: characters 13-23 : Type not found : MP4Handler

Describe your bug here.
When trying to compile the game it brings this up:
source/PlayState.hx:75: characters 8-22 : Type not found : vlc.MP4Handler
source/PlayState.hx:1620: characters 13-23 : Type not found : MP4Handler
How do i fix this?
Command Prompt/Terminal logs (if existing)
source/PlayState.hx:75: characters 8-22 : Type not found : vlc.MP4Handler
source/PlayState.hx:1620: characters 13-23 : Type not found : MP4Handler

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No i changed nothing

haxelib install hxCodec 2.5.1

use my version
haxelib git hxCodec https://github.com/JonnycatMeow/hxCodec-old-version.git
its the old version but it was mac support

https://github.com/ShadowMario/FNF-PsychEngine/issues/10756


Flexible data location

implemented much more flexible input and inference data location adding options

--data_dir for all scripts, and
--inference_dir for inference.py

added more flexible data structure


nixosTests.xfce: Check if Xfwm4 has ever coredumped

Adds a regression test for https://gitlab.xfce.org/xfce/xfconf/-/issues/35.
Description of changes

Xfce version of https://github.com/NixOS/nixpkgs/pull/249561
cc #264230

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg test xfce
(Yes, this should fail right now)

Testing again with #264230 merged:
@ofborg test xfce after-264230-merged

@ofborg eval

Just a thought:
I'm not sure if it gets too much of an effort to grep for all possible core dumps.  On the other hand, I guess in most vm tests in NixOS, a coredump is a bad sign and should make the test fail, irrespective of the particular process that dumped core.
Maybe we should by default (but disable-able via a switch for each test) alter systemd-coredump to crash the machine in every vm test, so we can catch all coredumps without the need to list them one by one.

I made it grep No coredumps found for now :thinking:
@ofborg test xfce


error: cannot open .git/FETCH_HEAD: Permission denied

Hello,
When I'm trying to update Homebrew with brew update, I encounter the following error:

error: cannot open .git/FETCH_HEAD: Permission denied
Error: Fetching /usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask failed!

How can I solve that?
Thanks

Please note we may immediately close your issue without comment if you do not fill out the issue template and provide the requested information.

brew config

HOMEBREW_VERSION: 1.1.5-54-g05f35d7
ORIGIN: https://github.com/Homebrew/brew
HEAD: 05f35d763b444077806241c3496259502ed4dbd0
Last commit: 2 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: fbb6f1b0618aee564a2c989080ff376d588d0b1d
Core tap last commit: 2 hours ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_REPOSITORY: /usr/local/Homebrew
HOMEBREW_CELLAR: /usr/local/Cellar
HOMEBREW_BOTTLE_DOMAIN: https://homebrew.bintray.com
CPU: octa-core 64-bit haswell
Homebrew Ruby: 2.0.0-p648
Clang: 8.0 build 800
Git: 2.10.1 => /Library/Developer/CommandLineTools/usr/bin/git
Perl: /usr/bin/perl
Python: /usr/bin/python
Ruby: /usr/bin/ruby => /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/bin/ruby
Java: N/A
macOS: 10.12.2-x86_64
Xcode: N/A
CLT: <IP_ADDRESS>.1.1480973914
X11: 2.7.6 => /opt/X11

brew doctor

Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry and just ignore them. Thanks!

Warning: "config" scripts exist outside your system or Homebrew directories.
./configure scripts often look for *-config scripts to determine if
software packages are installed, and what additional flags to use when
compiling and linking.
Having additional scripts in your path can confuse software installed via
Homebrew if the config script overrides a system or Homebrew provided
script of the same name. We found the following "config" scripts:
/opt/ImageMagick/bin/Magick++-config
/opt/ImageMagick/bin/Magick-config
/opt/ImageMagick/bin/MagickCore-config
/opt/ImageMagick/bin/MagickWand-config
/opt/ImageMagick/bin/Wand-config
Warning: Your XQuartz (2.7.6) is outdated.
Please install XQuartz 2.7.9 (or delete the current version).
XQuartz can be updated using Homebrew-Cask by running
brew cask reinstall xquartz
Warning: Unbrewed header files were found in /usr/local/include.
If you didn't put them there on purpose they could cause problems when
building Homebrew formulae, and may need to be deleted.

Thanks!


[PDI-15552] PDI: Getting error message when double-clicking 'Put A file with FTP' step

[PDI-15552] PDI: Getting error message when double-clicking 'Put A file with FTP' step
-added using empty string instead of null for port

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f ui/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f ui/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  ui/src/org/pentaho/di/ui/job/entries/ftpput/JobEntryFTPPUTDialog.java


proxy: slim node agent from k8s and envoy dependencies

Change-Id: I8c0ad6f9450ef5a7cab11125739db68e51c96c5a
Continuation of #50134 for node agent.

@kyessenov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
b1a1f8c9a0675014b4f3e3673431e4763e3d6808
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@kyessenov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
b1a1f8c9a0675014b4f3e3673431e4763e3d6808
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
b1a1f8c9a0675014b4f3e3673431e4763e3d6808
link
true
/test lint

gencheck_istio
b1a1f8c9a0675014b4f3e3673431e4763e3d6808
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


python312Packages.bthome-ble: 3.9.0 -> 3.9.1

Diff: https://github.com/Bluetooth-Devices/bthome-ble/compare/refs/tags/v3.9.0...v3.9.1
Changelog: https://github.com/bluetooth-devices/bthome-ble/blob/v3.9.1/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 317655 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.bthome
python311Packages.bthome-ble
python311Packages.bthome-ble.dist
python312Packages.bthome-ble
python312Packages.bthome-ble.dist


Add set text analyser for Coq lexer

This PR ports pygments Coq text analysis to chroma/go. Original code can be found at: https://github.com/pygments/pygments/blob/master/pygments/lexers/theorem.py#L156
In the current pygments analysis the actual value for completing a proof is Qed but also qed can appear on it. So I applied a regex to validate it. Also opened a PR to fix it on Pygments.
https://coq.inria.fr/refman/proof-engine/proof-handling.html?highlight=qed#coq:cmd.qed
https://coq.inria.fr/refman/proof-engine/tactics.html#coq:tacn.tauto
Fixes: wakatime/wakatime-cli#93

LGTM. Just mind your PR descriptions here and in pygments PR. The order of Qed and qed has to be the other way around. Should be:
The current Coq analysis the actual value for completing a proof is `qed` but also `Qed` can appear on it. So I applied a regex to validate it.

Actually what's in the documentation is Qed but qed can also appear. The regex is [qQ]ed.


Feature/add marker wasm

Description
This PR adds marker wasm encode/query support. Including all people that participated in the group coding session for this.
closes: #28

This is a draft until @ktalley-figure can verify the provwasm rust bindings, mocks, and integration test contract are all working.

Codecov Report

Merging #39 (020e528) into main (82724cb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   33.01%   33.00%   -0.02%
==========================================
  Files          74       74
  Lines        4719     4721       +2
==========================================
  Hits         1558     1558
- Misses       2957     2959       +2
  Partials      204      204

Impacted Files
Coverage Δ

app/app.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82724cb...020e528. Read the comment docs.


Add shelve-delete command

Add a new shelve-delete command that allows users to delete tfs shelve-sets they own. Fixes #505.

I've tested this functionality manually with VS 2015 SDK + Visual Studio Team Services since that was all I had access to at the time.

The code looks pretty good. Along the lines of https://github.com/git-tfs/git-tfs/issues/505#issuecomment-29682867, this seems like something that's tangential to moving data between TFS and Git, though, so I think it's out of scope for git-tfs.

I agree that it's not strictly moving data between TFS and git. But if git-tfs lets me create shelvesets, it feels counter-intuitive to use another tool (tf) to then delete the shelveset.

I think that we could add this feature to git-tfs.
I understand that it is not used to "move data between TFS and git" especially when moving away of tfs.
But if you use git-tfs as a bridge between git and tfs in a day to day work, using git in local and tfs as a server and that your team use shelveset (for example when doing gated checkin or reviews), you will have to delete shelvesets...
And if we see git-tfs as a toolbox, I feel that there is a tool missing :( You could do quite everything you need with it except delete the shelvesets, even create, list and check out them. Why not delete them? I myself, in the old days, thought that there was a missing feature when I had to deal with shelvesets. I was ashamed to be obliged to use the painfull tf.exe to do it.
I really think that we should merge it because there is not a lot of code and that won't change a lot in the future and that will improve git-tfs usage. Let's do exceptionally a little infringement for this feature... And I agree that the contribution is very good ;)

:+1:

Thank you @spraints @pmiossec!


Bug: Error After Connecting with Chameleon Ultra

Everything was working correctly until about two days ago.

Now, when I try to pair the Chameleon Ultra, I get an error message.

Can you open the devtools (F12) > console page, reproduce the error, and capture the error logged in the devtools' console page?

Thank you, this morning I retook the test and the page works perfectly.
Thank you for the quick solution.
Il giorno ven 7 giu 2024 alle ore 05:23 戴均民 @.***> ha
scritto:

Closed #115 https://github.com/taichunmin/chameleon-ultra.js/issues/115
as completed via ab01745
https://github.com/taichunmin/chameleon-ultra.js/commit/ab0174541687b5d505ae7651e10dac44f00e6d09
.
—
Reply to this email directly, view it on GitHub
https://github.com/taichunmin/chameleon-ultra.js/issues/115#event-13074519933,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF7YLBY5BPEBRBAQVB6GI43ZGERSVAVCNFSM6AAAAABI4AL5QWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGA3TINJRHE4TGMY
.
You are receiving this because you authored the thread.Message ID:
@.***
com>


feature: add cgroupfs in Info API

Signed-off-by: Allen Sun<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
add cgroupfs in Info API.
current pouchd only supports directly managing cgroupfs. In the future we will support this config in the daemon configuration.
TODO: add 'systemd' to make systemd manage cgroupfs rather than directly using it.
Ⅱ. Does this pull request fix one issue?

fix https://github.com/alibaba/pouch/issues/2143
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
added in integraion test.
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none

Ping @Ace-Tang
Could you help review this, again?

lgtm


Feature: Rename files and folders

It would be great to add an option to allow renaming of a file or folder
This could be an option that could be enabled via a prop. that offers an "edit" icon that a user can click, which turns the file name into a text input.
You could also change the "X" button to instead be a button that opens a context menu that offers multiple options, like deleting a file, renaming a file, etc.
A third option would be to simply enable a keyboard shortcut. CodeSandbox has the shortcut mapped to "enter". A good start would be to mimic this behaviour.
What do you think?

can i pick up this issue?


Link not working. Running sample required, otherwise...

Unfortunately the link to a sample project is not working.

Could you please provide a working example (for symfony) with usage of protecting routes by scopes?

Hi @sufius unfortunately we no longer have up to date QuickStarts available for this library. I'll make a note to remove that deprecated link until we can get something online again. If I can answer any questions for you otherwise about using the library please let me know.


Linker failure: undefined reference to `z_deflateInit_'

Operating system or device - Godot version:
GNU/Linux, Parabola or Arch Linux, is almost the same thing.
Issue description (what happened, and what was expected):
Compiling Godot from sources, I'm the AUR package maintainer for the engine. This is the output I get from the linking phase:
core/libcore.x11.opt.tools.32.llvm.a(compression.x11.opt.tools.32.llvm.o): In function `Compression::compress(unsigned char*, unsigned char const*, int, Compression::Mode)':
core/io/compression.cpp:(.text+0x94): undefined reference to `z_deflateInit_'
core/io/compression.cpp:(.text+0xae): undefined reference to `z_deflateBound'
core/io/compression.cpp:(.text+0xcd): undefined reference to `z_deflate'
core/io/compression.cpp:(.text+0xdd): undefined reference to `z_deflateEnd'
core/libcore.x11.opt.tools.32.llvm.a(compression.x11.opt.tools.32.llvm.o): In function `Compression::get_max_compressed_buffer_size(int, Compression::Mode)':
core/io/compression.cpp:(.text+0x1f4): undefined reference to `z_deflateInit_'
core/io/compression.cpp:(.text+0x20a): undefined reference to `z_deflateBound'
core/io/compression.cpp:(.text+0x218): undefined reference to `z_deflateEnd'
core/libcore.x11.opt.tools.32.llvm.a(compression.x11.opt.tools.32.llvm.o): In function `Compression::decompress(unsigned char*, int, unsigned char const*, int, Compression::Mode)':
core/io/compression.cpp:(.text+0x2ef): undefined reference to `z_inflateInit_'
core/io/compression.cpp:(.text+0x37e): undefined reference to `z_inflate'
core/io/compression.cpp:(.text+0x38c): undefined reference to `z_inflateEnd'
core/libcore.x11.opt.tools.32.llvm.a(zip.x11.opt.tools.32.llvm.o): In function `zipOpenNewFileInZip4_64':
core/io/zip.c:(.text+0x1dc4): undefined reference to `z_deflateInit2_'
core/io/zip.c:(.text+0x1e05): undefined reference to `z_get_crc_table'
core/libcore.x11.opt.tools.32.llvm.a(zip.x11.opt.tools.32.llvm.o): In function `zipWriteInFileInZip':
core/io/zip.c:(.text+0x2466): undefined reference to `z_crc32'
core/io/zip.c:(.text+0x2529): undefined reference to `z_deflate'
core/libcore.x11.opt.tools.32.llvm.a(zip.x11.opt.tools.32.llvm.o): In function `zipCloseFileInZipRaw64':
core/io/zip.c:(.text+0x2711): undefined reference to `z_deflate'
core/io/zip.c:(.text+0x2765): undefined reference to `z_deflateEnd'
core/libcore.x11.opt.tools.32.llvm.a(unzip.x11.opt.tools.32.llvm.o): In function `unzClose':
core/io/unzip.c:(.text+0xdbd): undefined reference to `z_inflateEnd'
core/libcore.x11.opt.tools.32.llvm.a(unzip.x11.opt.tools.32.llvm.o): In function `unzCloseCurrentFile':
core/io/unzip.c:(.text+0xe61): undefined reference to `z_inflateEnd'
core/libcore.x11.opt.tools.32.llvm.a(unzip.x11.opt.tools.32.llvm.o): In function `unzOpenCurrentFile3':
core/io/unzip.c:(.text+0x1fe0): undefined reference to `z_inflateEnd'
core/io/unzip.c:(.text+0x2647): undefined reference to `z_inflateInit2_'
core/libcore.x11.opt.tools.32.llvm.a(unzip.x11.opt.tools.32.llvm.o): In function `unzSeekCurrentFile':
core/io/unzip.c:(.text+0x27c3): undefined reference to `z_inflateReset'
core/libcore.x11.opt.tools.32.llvm.a(unzip.x11.opt.tools.32.llvm.o): In function `unzReadCurrentFile':
core/io/unzip.c:(.text+0x29ee): undefined reference to `z_crc32'
core/io/unzip.c:(.text+0x2a51): undefined reference to `z_inflate'
core/io/unzip.c:(.text+0x2a96): undefined reference to `z_crc32'
clang-3.9: error: linker command failed with exit code 1 (use -v to see invocation)
scons: *** [bin/godot.x11.opt.tools.32.llvm] Error 1
scons: building terminated because of errors.
==> ERROR: Se produjo un fallo en build().
    Cancelando…

Steps to reproduce:
Try my package at AUR on Arch Linux and you will see.
Link to minimal example project (optional but very welcome):

I deleted builtin_zlib=yes and added zlib as a dependency, the build finished successfully.

Reopening, since this isn't less of an issue if there is a workaround -- we should probably support builtin zlib as well..


Question: How can I query the data transfer cost grouped by regions with Usage API?

As the title asks.
https://github.com/Azure/azure-sdk-for-go/blob/f252cd9f178d89af5a3b0f595e72c8b1479904c7/sdk/resourcemanager/costmanagement/armcostmanagement/forecast_client.go#L120

You can refer to this example, which seems to have some filter related examples


Sleaze to the Max leaderboard

I have a couple new BAFS stat suggestions.
I have 7 sleaze ride days for BAFS 2019 but about half of them were sleaze rides to reach my maximum team points for the week (Sleazes to the Max).
Additionally, 2 of my 7 sleaze rides were a Double Sleaze to the Max: I finished the week with 2 consecutive sleaze ride days to reach my maximum team points for the week.
If the technology allows it my suggestion is to add “Sleazes to the Max” and “Double Sleazes to the Max” as columns to the Individual Sleaze Rides page.
Jim B

OBE


Documentation link point to a 404 page

https://anarthal.github.io/mysql/index.html -> 404 = -.-

That went lost when we migrated the repo to boostorg. I've re-uploaded the latest stable docs, should work now.

Thank you!


Extract spa_ui/self_service into its own repo

https://github.com/ManageIQ/manageiq-ui-self_service

@dclarizio Please review

:heart_eyes:


backport 'Rename aggregator_unavailable_apiservice name tag to apiservice_name'

What does this PR do?

Backport https://github.com/DataDog/integrations-core/pull/14738
Motivation

We added this metric in 7.46 and want to ship it without any bug.
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

Superseded by https://github.com/DataDog/integrations-core/pull/14751


how to verify extraHttpHeaders and Cookies set using plugins

how to verify the headers and cookies set from plugins using "req.prerender.tab.Network" object functions such as setExtraHttpHeaders & SetCookies?
I am not able to console.log the headers using "req.prerender.tab.prerender.headers", giving me undefined message. Also how do i console.log the cookies set? didn't not succeed trying to inspect/log using "req.prerender.tab.Network.getCookies".
Any help on how to print and verify these headers & cookies would be much appreciated. Thanks!

The headers are sent on the network request so you might have to hook into Chrome's Network.requestWillBeSent function like:
req.prerender.tab.Network.requestWillBeSent((params) => {
    console.log('headers:', params.request.headers)
});

As for the cookies, I would assume those would be sent on the network request as a header too, but I'm not seeing any sent. So I think the cookies should be getting cleared every time since we open a new "incognito" context for each browser tab. I know we had a bug with Chrome in the past here so I could be wrong.

Thanks, i am able to verify the headers using this function "Network.requestWillBeSent" as suggested but not seeing any cookies being sent as u mentioned.. how do we then send/pass cookies in the prerender request to chrome browser tab? Thought, setting "cookiesEnabled: true" flag should allow SetCookie on the prerender request? Any help with this cookie pass through in the prerender request to chrome browser tab is much appreciated. Thanks!

We should be clearing cookies on every request. If you are wanting to pass cookies through from a request to the Prerender server, you will need to write a plugin that takes the cookie off of the incoming request and then uses Chrome's API to set that cookie header on the Prerender request before the page is loaded.

that's exactly what i am trying to do..take the cookie off from incoming request and set the cookie on the prerender request using "req.prerender.tab.Network.setCookie" function and trying to validate whether its being sent correctly in the prerender request to load the page in chrome browser tab.. but i am not seeing the cookie being sent as a header in the network request.. am i missing something here?!

Can you share the code that you are using to take the cookie off the incoming request and set it on Chrome? I'll be happy to take a look at what you've got.

actually setCookie function works and sets the cookie header in the prerender request which i can verify by inspecting the request headers from inside the page which is prerendered...so i think, its just the Network.requestWillBeSent function which is not showing the cookies sent as part of the headers.. not sure why?

Sorry for the delay here! Interesting...must be a Chrome thing? We don't mess with that at all.
Going to close this issue if it's working. Feel free to reopen if needed!


nova: init at 3.6.2

Description of changes
Hello,
first attempt to create a Nix package. I'd like to make progress, so don't hesitate to point out what's wrong.
I use Nova to check if my HELM charts are up to date on my clusters. It's a small binary that has no dependencies.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md. (I Guess)

You need to add the package to pkgs/top-level/all-packages.nix. Then ofborg-eval will show you the errors to be fixed.

@ofborg build nova nova.passthru.tests


Add constraint_setting, values, and platform for grpc_no_ares

The Asylo project builds with --define=grpc_no_ares=true, but is
migrating to new functionality for flagless builds by combining
platforms and "transitions". The preferred method for build
configurability is with constraints and platforms, and not with defines.

Raising priority because of long response latency from gRPC team.

Closing because this is meant to enable Bazel configurability through transitions, and should be tested with that workflow first.


fix fix bug: convert stringLikeLiteral to double

What problem does this PR solve?
The optimizer maps different data types to Double, allowing for a unified comparison of literals.
StringLikeLiteral is regarded as a long int, and map the long int to double.
To extract the first N bytes from a string, you should use String.getBytes().length instead of String.length().
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)

Test

[ ] Regression test
[x] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall


[ACR] [Pre-GA] Finalize cloud configuration API

The service will be making changes to how users can authenticate with it.  Given this, we'll want to revisit and potentially replace the AuthorizationScope property on ContainerRegistryClientOptions with an API that
(in order of preference)

(if General ACR scope enables this) makes it unnecessary for customer to specify cloud
Arch board guidance specifies how users can indicate which cloud in a Track 2 consistent way
If the service provides two permissions models with different scopes associated with them, we would provide an API that communicates the differences between the two models, and either guides the user to choose the appropriate scope, or specifies it for them.

Per conversations with @schaabs and @AlexGhiondea, we will make the following changes to the API:

Provide an Audience property in ClientOptions, replacing the AuthorizationScope property from the Beta 3 API
Audience is an extensible enum, listing the known clouds, but user can override with a string if needed
If Audience is set, client library will append /.default to Audience to specify the default scope
Audience will default to data-plane scope root, which should be common across clouds

Moving to August per internal discussion.

Proposed APIView here: https://apiview.dev/Assemblies/Review/ba57bf904e524ce3bf647dad124ddc7c/b7bc17cdde3d4cce9d746014f58e91d7?diffRevisionId=d901b2eecfc1401ca50a1118fcf7d8b8&doc=False&diffOnly=False
With samples: https://github.com/Azure/azure-sdk-for-net/compare/main...annelo-msft:acr-audience-exp1#diff-4c97342c11eae10a5f275e0e8bea9b5bb07c74040e3f7c9fbabd0e8b0ab52223R28


Use AzureDevOpsCredentialsProvider

Hey, I just made a Pull Request!
Added support for using AzureDevOpsCredentialsProvider and deprecated azureDevOps.token configuration value.
This lays the foundation along with https://github.com/backstage/backstage/pull/19616 towards adding multi-org support to the Azure DevOps plugin
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Hi @marleypowell, @sanderaernouts, If you have some time can you give this a look over? Keep in mind this is just laying the foundation for multi-org support. The ideas is that once this and https://github.com/backstage/backstage/pull/19616 are merged in we can start the work completing the wiring between the frontend and backend 🚀


Print stderr when running a command just like vim does

I noticed that whenever try to run a local command: ":! something" only stdout gets printed.
In vim/nvim both stderr and stdout get printed. We can fix this with this PR.
TODO:

[x] Test that the stderr is printed
[x] Test that colors are properly stripped from the output.

I checked, now I get a nice readable output after colors get stripped:
:!pg a %

2022-01-02T16:09:29.671516Z  INFO play_ground::imports_analyzer: crate::cmd -> 1
2022-01-02T16:09:29.671530Z  INFO play_ground::imports_analyzer: crate::custom_layer::CustomLayer -> 1
2022-01-02T16:09:29.671534Z  INFO play_ground::imports_analyzer: anyhow::Error -> 3
2022-01-02T16:09:29.671537Z  INFO play_ground::imports_analyzer: reqwest::header -> 4
2022-01-02T16:09:29.671540Z  INFO play_ground::imports_analyzer: std::env -> 3
2022-01-02T16:09:29.671543Z  INFO play_ground::imports_analyzer: std::fs -> 1
2022-01-02T16:09:29.671545Z  INFO play_ground::imports_analyzer: std::io -> 4
2022-01-02T16:09:29.671547Z  INFO play_ground::imports_analyzer: std::path -> 1
2022-01-02T16:09:29.671550Z  INFO play_ground::imports_analyzer: std::process -> 1
2022-01-02T16:09:29.671553Z  INFO play_ground::imports_analyzer: tracing::Level -> 3 / 4 indirect=1
2022-01-02T16:09:29.671556Z ERROR play_ground::imports_analyzer: x1=3 x2=4

Great, thank you for the contribution!

Hi @pmnoxx ! Could you please take a look at this discussion so we can use your change under the new MIT license? Thank you!
https://github.com/JetBrains/ideavim/discussions/542


在js项目中 无法通过eslint no-undef 校验

Describe the bug
'defineOptions' is not defined eslint no-undef
可以使用 vite 快速构建一个js项目，开启eslint
使用 defineOptions 便会出现这个错误提示
Reproduction
npm create vite@latest
System Info
MacOs Vscode

Used Package Manager
npm
Validations

[ ] Follow our Code of Conduct
[ ] Read the Contributing Guide.
[ ] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[ ] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[ ] The provided reproduction is a minimal reproducible of the bug.

自行配置 ESLint 规则
{
  globals: {
    defineOptions: 'readonly'
  }
}


Can't find  kvmconfig and no AFL status screen

Hi，dear blogger:
I can not run the "make kvmconfig"  command and I  did not find it in Makefile. I don't know  whether  it will affect my later operation. And is there a AFL status screen after the command "./virtme/virtme-run --rw --pwd --kimg linux/arch/x86/boot/bzImage --memory 512M --script-sh "echo core > /proc/sys/kernel/core_pattern; ./AFLplusplus/afl-fuzz -i ./inp -o ./out -- ./fuzznetlink --dmesg dmesg.txt"". I have noting shown on my screen. I don't know is there something wrong with my operation.

The method to fuzz the linux kernel really work! It can start fuzz the kernel. As for my problem, I use make kvm_guest.config to replace it. What I want to emphasize is that is configure must be right. It is very important. And last thank the author's idea and work!

Dear：
Hello, your method has perfectly solved my problem, but I have another issue where I ran for over an hour and didn't find any crashes. Is this my problem with AFL? Thank you


How to get the buffer data?

How to get the buffer data after the video is fully buffered? I want to have it stored locally.
related issue
https://github.com/react-native-community/react-native-video/issues/838

It's not possible to save the video from the buffer at the moment. There is a PR in #885 but I haven't had a chance to evaluate it yet.
Otherwise, it will probably be quite awhile before we support this on ExoPlayer.

Thank you for your prompt reply, and looking forward to this function very much.

Interesting I did not know you could do such thing.
One question, assuming a video has been fully buffered at this point and the user decided to replay it again. Will it go and re-download it again or would the player play it from the buffer?
thank you for your answer(s).

It should play from the buffer. You can test this by turning off WiFi and seeing what happens.

However, be aware that the player is not likely to keep the whole video in memory (unless it's very short). How much the player buffers varies depending on platform. On some, it's configurable.

Thank you for your attention.
I found something like this: if you play the same video over and over again, it will use the buffered data. But if you switch to another video, then come back again, the buffered data for the last video seems to have lost.
I did this at present: add a download button, manually download and store it locally, then you can use the local data (if it has been downloaded).


vx_amd_migraphx tests

Updated scripts to take multiple batch sizes. However with TOT MIGraphX repo only batch size = 1 works. TO test on bigger batch sizes , build and install this branch
Results on confluence page

@LakshmiKumar23 is this ready to be merged?

@LakshmiKumar23 is this ready to be merged?

@kiritigowda No, we need Pavel to run tests and approve it

@paveltc let me know when this good to merge.

@asalmanp @LakshmiKumar23 @kiritigowda I ran the tests for this PR. It's good to merge.


Show (pretty and) helpful error messages, if any

[ ] during startup
[ ] if any plugins could not be added

hi @jennydaman is this issue still relevant ?

Thanks for visiting this issue. It's somewhat obsolete now, the heavy-lifting is now done by pure docker-compose and chrisomatic.
@lumuchris256 are you interested in infrastructure, backend, containers, etc? You could try contributing to chrisomatic, or try creating miniChRIS using Kubernetes or OKD instead of docker-compose. These would all be very cool but very involved, let me know and I'd be happy to guide you.

Thanks for visiting this issue. It's somewhat obsolete now, the heavy-lifting is now done by pure docker-compose and chrisomatic.
@lumuchris256 are you interested in infrastructure, backend, containers, etc? You could try contributing to chrisomatic, or try creating miniChRIS using Kubernetes or OKD instead of docker-compose. These would all be very cool but very involved, let me know and I'd be happy to guide you.

thanks for the pointers am more into the react typescript frameworks
but okay to jump in finding the way around  creating minichris using kubernetes (i have some background in CI deployment with docker)
the only blocker would be the given  limited time to do final application for outreachy with ChRIS project


DynamoDB tables created directly from Resources declaration

As mentioned in #56, this PR will create local DynamoDB tables solely from the serverless.yml Resources declaration. Consequently, this PR removes the existing ability to seed data. It also removes the ability to set table prefixes or suffixes, as this will do only what is configured in Resources to mimic what would be deployed by Serverless. In #56, @AshanFernando outlined the creation of a separate dynamodb-seeds plugin to add back the ability to seed DynamoDB tables. I have not had a chance to create that yet.

LGTM 👍
Thanks for the awesomeness @msjonker
@AshanFernando any feedback?


feat: support hashed value 'H'

This closes https://github.com/tisonkun/cronexpr/issues/15.
@epage welcome to leave your review and hope the usage of winnow is properly :D

Merging ...
Review after merge is always welcome though :D


Ability to export data into structured file format JSON

Ability to export data into structured file format JSON

It was agreed this functionality is not needed -> closing this issue.


Add MicroBadger badge

We saw your image on Docker Hub at lambda3/vsts-agent, and we thought you might like this badge for your GitHub readme showing the image contents.
The badge shows the number of layers and download size of your Docker image, and links to our site where you can see the contents of each layer.
As you're using an automated build it will also show up in your Docker Hub description.

@microbadger cool, tks


Added the generic split code

The code is not yet tested on a groove. But the depth2 or S is added in this version of the code

Branch was pulled and modified => new PR #76


Show message box when the user

Currently we show a warning box with a message when drive gets submitted with wrong or empty signature (see picture below)

But this (yellow) box will not appear when the signature is correct. I thought that it would be a good idea to add the green confirmation box which informs the Driver that a drive was verified successfully, besides the regular green/gray box which indicates if drive was submitted to server.

@bckamil


[EN DateTimeV2] "Between year 2013-01-01 and 2016-01-01" not be recognized as right answer

@acblacktea can you provide the details of what is wrong and what's the expected outcome?


feat: add r/msteams_workflow_recipient

Adds the new r/msteams_workflow_recipient resource, deprecates r/msteams_recipient, and removes the ability to create net-new instances of r/msteams_recipient.

Codecov Report
Attention: Patch coverage is 88.57143% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.14%. Comparing base (6713cc3) to head (f9d2c5f).

Files
Patch %
Lines

honeycombio/type_helpers.go
44.44%
5 Missing :warning:

honeycombio/resource_msteams_workflow_recipient.go
93.54%
2 Missing :warning:

client/recipient.go
66.66%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
+ Coverage   78.53%   79.14%   +0.60%
==========================================
  Files          73       74       +1
  Lines        5619     5667      +48
==========================================
+ Hits         4413     4485      +72
+ Misses        913      882      -31
- Partials      293      300       +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Make page in metatitle translatable?

When using pagination on the blog index, the title in the browser show the current page you're on. This is great, but it is not translatable (to dutch, in my case).
I don't know how, but it has something to do with the "common.i18n.t" function I guess? Am I right?
Can someone help me explain the use of it and how I can make this string translatable?
It's about this line: https://github.com/TryGhost/Ghost/blob/415ff2cf2040a04e4ac8c01eac553c0b1a9b2523/core/server/data/meta/title.js#L15
Kind regards, Mante

Hey @mantebridts 👋
There is an open pull request for this missing string, see. The PR was already reviewed, but the contributor never came back. Any helper is very welcome.

Something similar to {{plural}} and {{reading_time}} helpers -with explicit default texts- could be
<title>{{meta_title page=(t "Page %")}}</title>

instead of
<title>{{meta_title}}</title>

in the theme's default.hbs template, with a string placeholder in core/server/data/meta/title.js and replacement logic in core/server/helpers/meta_title.js .
That's just a possible idea for anyone willing to work on this, since for example I'm always in a hurry these months. :wink:

Allright, I think I get it. I will try to make a fix! :)

I think I made a PR that should do the trick. It works here, I follow the instructions and ran the tests... 😊
I hope I did everything right, first-time-contributer here, just tell me when I did something wrong. 😅
https://github.com/TryGhost/Ghost/pull/9468

Is there no way to do this for navigation labels & site data currently? #11444


Added flag --skip-secure-verify

In order to increase this feature, I ran dep ensure -v -update github.com/aliyun/alibaba-cloud-sdk-go to update the dependency.

Codecov Report

Merging #159 into master will increase coverage by 0.09%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
+ Coverage   85.73%   85.82%   +0.09%
==========================================
  Files          50       50
  Lines        2979     2978       -1
==========================================
+ Hits         2554     2556       +2
+ Misses        313      311       -2
+ Partials      112      111       -1

Impacted Files
Coverage Δ

config/flags.go
100% <ø> (ø)
:arrow_up:

config/profile.go
79.74% <100%> (+1.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0734ace...fc8e43f. Read the comment docs.


Update to discord.js ver 14?

Can you update this to ver 14 pls, i really need this :>

discord.js version 14 isn't out yet

discord.js version 14 isn't out yet

:( hope you will add more update, have a nice day

discord.js version 14 isn't out yet

idk, but can i have your discord name? i have some thing want to talk with you

yeah, sure issadarkthing#4495

issadarkthing#4495

my name is YL ●  Normal bị ban owo#3106


systemctl daemon-reload fails

Hi,
I'm trying to add a systemd service. Unfortunately systemctl daemon-reload fails with:
System has not been booted with systemd as init system (PID 1). Can't operate.
Failed to connect to bus: Host is down

Any clues on how to find a workaround?

I wanted to run https://github.com/deltachat/mailadm/blob/bot/install_mailadm.sh#L83 inside the container, to install mailadm, a tool for creating and deleting mail addresses.
The actual container I'm using extends this container: https://github.com/deltachat/docker-mailadm/blob/bot/mailadm/Dockerfile
Do you have any ideas how I could use this part of systemd inside docker as well?

I see. You're trying to run the linked script in the Dockerfile, which requires systemd to be active. Commands of the Dockerfile will be run during build. However, systemd doesn't run at this time, as build RUN will be executed in naked containers with no other processes running. Systemd will not be availabe until the final image is started as container.


Can't Block 'use'

I get this error repeatedly also.
Pastebin Link
Idk what's wrong. Disable crafting works fine

This error has nothing to do with StackBan. It's an issue with Project Inventories.


Can crossbeam::queue support rayon?

Is it possible to implement rayon's par_iter and into_par_iter for crossbeam::queue?

I think we could do that, but perhaps it'd be better to add .iter() to queues (similar to channels), and then you could convert the iterator into a parallel one by doing .par_iter() or .into_par_iter() (I forget which one).


Ignore the kamel-x.xx.x file created using minikube setup

NO JIRA.
PR owner checklist
Please make sure that your PR meets the following requirements:

[x] Your code is properly formatted according to this configuration.
Run mvn clean verify -DskipTests so that imports are correctly set.
[x] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-XXX] - $clear_explanation_of_what_you_did"
[x] The layers in the kustomize folder have been updated accordingly.
[x] All new functionality is tested
[x] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains link to any dependent or related Pull Request
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket

PR reviewer(s) checklist

[ ] Check if code and Github action workflows have been modified and if the modification is safe
[ ] If the modification is safe, add the safe to test label

How to trigger pipelines and use the bots:

Run the end to end pipeline
Annotate the pull request with the label: safe to test. If you want to run the pipeline again, remove and add it again.

Rebase the pull request
Comment with: /rebase.

Deploy BOT
Comment with `/deploy <dev,stable> when the PR has been merged to deploy to a target environment.

@kostola FYI:

Side question: why don't we use /tmp to store the kamel binary during the installation?

Side question: why don't we use /tmp to store the kamel binary during the installation?

@r00ta the idea is that once you downloaded it the first time, you won't need to download it anymore. With /tmp you'll download it every time the temporary folder is cleared.
Also, having it in the scripts directory allows you to use it manually if you need it.


Short history do not show last events

Adding multiple values, short history on main screen drags behind, because history buffer is larger than number of visible elements. Need to add "goToBottom"/"goToTop" methods to list class.

fixed


Integration in CodeIgniter 3

Hi,
How can I verify a transaction without a .env file
The problem is when trying to integrate it for multiple users we can't create  .env files for all users.
Need to pass the keys via parameters, how can i do this?

HI @phplime
trust you are doing fine. just wanted to know if you still need help with this.

for custom configuration, you can simply create a class that implements the ConfigInterface and simply pass the secret_key, public_key, encryption key, and env values.

Hi @bajoski34
Thank you for getting back to me. Yes, I got the solution and successfully verified the transaction.

Great to hear that @phplime. if you have any requests or ideas to better improve the SDK. do let us know.
Thanks for choosing Flutterwave.


fix(form): mark only blurred control as touched instead of whole form

Signed-off-by: Wallabeng<EMAIL_ADDRESS>PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
Workaround for touching controls (#4767), touches all controls inside a form, because MarkControlService is provided on form level. So validation messages (e.g. for required validator) inside the form are shown, regardless of any user interaction.
What is the new behavior?
Workaround for touching control touches the blurred control only.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@bbogdanov, @Jinnie please have a look at this

bump! Can anyone have a look at this please? It's blocking us from upgrading to clarity v4.

What happens when all controls are touched? Does the form get ng-touched in this case?

Yes the form and all controls inside it are getting touched. So you also get validation messages for controls the user himself never touched.

The form gets touched even if only one control is touched. This is what I was looking for cause it is a default @angular/forms behavior.
LGTM!


[Feature Request] Add default rule: block all

I want to block all by default, but if domain found in white list - get DNS request for this domain.
Thanks.

Whitelists work really badly in practice. Today's website rely on load balancers, CDNs, and other pieces of infrastructure dynamically generating DNS names.
Establishing a reliable whitelist for specific services is virtually impossible and requires quite a lot of maintenance.
That can be done, and actually you can just take the current blocking plugin and invert the check, but be prepared for breakage.

invert the check
how to do it?
how to allow it by the white list?

For example, in config file:
BlockAllDomains on
WhiteDomainsList: "/etc/domains_white.list"

When open example.com, check this domain in white list. If not found - return DNS error code.

Changing if (block) to if (block == 0) here: https://github.com/jedisct1/dnscrypt-proxy/blob/4a2e773af9e24413c9ad7c6eee38dc1a781ee944/src/plugins/example-ldns-blocking/example-ldns-blocking.c#L655 should invert the behavior.

I quickly hacked that thing based on the block plugin: https://github.com/jedisct1/dnscrypt-plugin-whitelist-only
Completely untested, but feel free to give it a spin!

Thanks you very much. It's work. I'm happy. :-)


operator: refactor release prep script to patch operator manifests too

Ensure that we sed the image tag to the next release tag before pushing a new tag.
This will ensure that when new tag is pushed and image build is started, our images
will have the right manifests.

@klihub
I noticed that my changes were pushed directory to the upstream branch instead of to my work.
As such, I have to close this PR here and we can continue reviewing the changes in https://github.com/containers/nri-plugins/pull/235.


Redesign "Quick-Recovery" Backup and Restore Method

Problem Description:
Using s3 sync --delete ${JENKINS_HOME} s3://<BUCKET>/<PATH> is sufficiently fast for small-sized ${JENKINS_HOME}s and when only doing delta'd up-syncs but is paaaaainfully slow on restores beyond 1GiB or so
Expected Behavior:
Restores (full) operate quickly
Actual Behavior:
Restores (full) are painfully slow
Steps to reproduce:
Attempt to build new instance from "quick-recovery" backup
Fix recommendation:
Need to replace s3 sync with more performant method (probably tar cf - ${JENKINS_HOME} | s3 cp - s3://<BUCKET>/<PATH>/<BACKUP_NAME>.tar

Closed by #19


SOS esprima 404 error

Hi @ariya how are you? I'm sorry for opening this PR, but since I haven't found a place to post an issue with esprima, it was the only way I found to post this problem.
I'm trying to install all dependencies in my react project, but when I run npm install I'm getting some errors related to esprima:
npm ERR! 404 Not Found - GET https://codeload.github.com/ariya/esprima/legacy.tar.gz/master
npm ERR! npm ERR! 404
npm ERR! npm ERR! 404  'esprima@https://github.com/ariya/esprima/tarball/master' is not in the npm registry.
npm ERR! npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! npm ERR! 404
npm ERR! npm ERR! 404 Note that you can also install from a
npm ERR! npm ERR! 404 tarball, folder, http url, or git url.
Can you please help me with this error?

I could resolve this issue after downgrading my npm version from 7.14.0 to v6.14.13. It may not be the best solution, but it was the only way I could get rid of this problem.


Track Timestamps

Keep a running track of timestamps of the input data  to show how stream position can be kept track of

Done in segmented runner (not the simple batched inference runner though)


Fix jenkins with no jobs contrast with dark theme

Links
https://github.com/jenkinsci/jenkins/pull/4761

Thanks for your contribution! A bit late for the hackfest, but it is still much appreciated


Fundamental Soundness Problem

TL;DR: Ouroboros has a soundness problem. A fix has been attempted but it was also unsound. Currently the compiler does not actually produce unsound machine code, but it may begin doing so at any point in the future. Migrate code to use self_cell instead.
More details:
Currently, Ouroboros works internally by creating a struct where all uses of 'this are replaced by 'static. However, a recent addition to Miri checks that references passed to functions are valid during the entire execution of the function, even when those references are passed inside a struct. This poses an issue for dropping self-referencing values, as the reference becomes invalid during the dropping process. Effectively, since self-referencing structs are not allowed in vanilla Rust, there is no allowance for dropping data during a function that has also been given a reference to that data. There's usually no way to pass a and &a to the same function.
A fix was attempted, where the struct would be turned in to a raw byte array and only transformed back into the underlying data type inside each function. This is allowable as a reference can be created and die over the body of a function, as long as the reference was created inside the function. However, this is also not sound if the original struct contains padding. There is no way to initialize padding bytes to a known value that Miri will accept, so when it is cast to an array some of the bytes contain uninitialized values. This is not acceptable (despite the fact that these bytes are never read) due to the potential for optimizations that may read from the uninitialized bytes. Besides which, this fix does not allow for template or constant parameters as there is no way to check the size of a templated type without giving specific, concrete values for the template parameters.
At this point, I'm just going to move on to other things. self_cell appears to be an excellent alternative for anyone using this crate.

Rustsec PR: [https://github.com/rustsec/advisory-db/pull/1707]

Did you consider transmuting to an array of MaybeUninit instead to avoid the padding/unitialized bytes problem?

Hey, I just wanted to say thank you for all the hard work you put into ouroboros.

Is it clear that self_cell does not have this issue, or is it possible that it just did not get the same amount of scrutiny?

@rklaehn from what I can tell it doesn't have the same issue because it doesn't store the values as 'static. Instead it stores the value as NonNull<u8> and materializes lifetimes within the functions. It has an extensive test suite that is tested with miri. But this stuff is really complex and I can't exclude the possibility that it has future soundness issues as it has had in the past.

@joshua-maros wrapping in ManuallyDrop should palliate the issue at the moment, until we get that magic of ManuallyDrop extracted into its own wrapper type. See https://github.com/rust-lang/rfcs/pull/3336

Hey @joshua-maros, thanks for the efforts of maintaining ouroboros for years!!

EDIT: ManuallyDrop currently does not prevent the miri error, which I'd argue to be a bug (ManuallyDrop should include MaybeDangling, shouldn't it? cc @RalfJung)

ManuallyDrop is not currently specified to have the MaybeDangling behavior, and in the codegen backend (to my knowledge) there is no exception for ManuallyDrop. So this is not a bug, Miri is behaving as intended.
This looks like a good use-case to add to https://github.com/rust-lang/rfcs/pull/3336. Would it be possible for someone to prepare a brief writeup of what ouroboros needs, and how MaybeDangling is required to achieve that goal?

Effectively, since self-referencing structs are not allowed in vanilla Rust, there is no allowance for dropping data during a function that has also been given a reference to that data. There's usually no way to pass a and &a to the same function.

FWIW, there is currently one exception to this, and that is a &UnsafeCell<T> reference. Those must be dereferenceable on function entry, but they are permitted to be deallocated while the function runs.

To be clear, when I said "intended behavior" I meant that this is not a Miri bug. I do think we should change this. But I can't just change this in Miri, codegen needs to be adjusted first, and that probably needs an RFC, and that's why I wrote https://github.com/rust-lang/rfcs/pull/3336.

Thank you @Bwallker and @danielhenrymantilla for the suggestion, I've tried it out and it appears to make the test suite pass under miri. It still won't support template parameters, but it's enough for now. I'll be publishing a version of the library that uses this fix soon and update the security advisory accordingly.

@joshua-maros, do you mind clarifying if you intend to continue working on ouroboros moving forward? The original post mentioned that you planned on moving on. Is that still the case (and 0.16 is the last version) or have plans changed?

I intend to continue now that a fix has been found. I was planning on leaving due to there being nothing else I could do, since that is no longer the case I will keep working on it.

@joshua-maros given the issued rustsec advisory I wonder if previous versions should be yanked from crates.io, what do you think?

I will be doing that but only after people have had a chance to migrate. I had previously yanked a version too soon after uploading a fix, and it caused a lot of chaos as many libraries were suddenly broken and unable to compile.

Thanks for clarifying.

IMO yanking is entirely unnecessary here, given there are (AFAIK) no reports of this unsoundness causing a concrete issue.

Out of genuine interest, and having been in the same situation before. My understanding behind the motivation to yank in such situations was that it sends a clear signal to users, which might also run tests with miri, that their current version of the crate may cause issues with future compilers and that upgrading is necessary to avoid those issues.

:shrug: IMO the advisory is good enough, people that care enough will see the warning in cargo audit and it's not worth disrupting everyone else.
That's just my opinion though.


can't infer ConstructedAtomType properly

Hi, @agentm
I was creating a schema by trying project-m36-typed example with CrashSafePersistence db, and then tried to test an insert by tutd. But I can't find a way to input ConstructedAtomType in tutd. I can input Just "something" but not Nothing.  It seems tutd can't infer Nothing's type.
TutorialD (master/main): :showexpr temp
┌───────────────────────────────────┬──────────────────────┬───────────────────────┐
│phoneNumberComment::Maybe (a::Text)│phoneNumberEmail::Text│phoneNumberNumber::Text│
├───────────────────────────────────┼──────────────────────┼───────────────────────┤
│Just "12345"                       │"12345"               │"12345"                │
└───────────────────────────────────┴──────────────────────┴───────────────────────┘
TutorialD (master/main): insert temp relation{tuple{ phoneNumberComment (Just "12346"), phoneNumberEmail "12346", phoneNumberNumber "12346"}}
TutorialD (master/main): :showexpr temp
┌───────────────────────────────────┬──────────────────────┬───────────────────────┐
│phoneNumberComment::Maybe (a::Text)│phoneNumberEmail::Text│phoneNumberNumber::Text│
├───────────────────────────────────┼──────────────────────┼───────────────────────┤
│Just "12345"                       │"12345"               │"12345"                │
│Just "12346"                       │"12346"               │"12346"                │
└───────────────────────────────────┴──────────────────────┴───────────────────────┘
TutorialD (master/main): insert temp relation{tuple{ phoneNumberComment (Nothing), phoneNumberEmail "12346", phoneNumberNumber "12346"}}
ERR: TypeConstructorTypeVarsMismatch (fromList ["a"]) (fromList [])

And in the meantime, I can't auto-derive some newtype Atomable from base Atoms.
newtype SafeId = SafeId B.ByteString
  deriving (Eq, Ord, Show, Generic)
  deriving newtype (NFData, Binary)

--    * Couldn't match representation of type `proxy ByteString'
--                               with that of `proxy SafeId'
--        arising from the coercion of the method `toAtomType'
--          from type `forall (proxy :: * -> *).
--                     proxy ByteString -> ProjectM36.Base.AtomType'
--            to type `forall (proxy :: * -> *).
--                     proxy SafeId -> ProjectM36.Base.AtomType'
--      NB: We cannot know what roles the parameters to `proxy' have;
--        we must assume that the role is nominal
--    * When deriving the instance for (Atomable SafeId)

It's due to some type role issue. And change proxy to Proxy may work (saw this advice somewhere).
Is there any reason to have a toAtomType :: proxy a -> ... with a type variable instead of the Proxy type?

The type inference problem is covered by #46 where there is thankfully an easy workaround by adding the type to the relation. The backend doesn't yet connect the type of the target relation and the "floating" relation, so relation{x Nothing}, in general` is insufficiently typed.
Regarding the second issue, I think it should be resolved by switching from newtype to data. The backend definitely doesn't support newtype structures, so even if you could get past this error, something else would go wrong. I'll think about how to resolve that.


Variable item height

This is something that will help me out a lot right now, so I decided to quickly throw together a PR of the bare minimum functionality that I need.
Edit: Disregard all of the below. After way too much time debugging this, it turned out to be a minor issue with dataTimestamp and my introduction of async functions. Everything is working 100% as intended now!

~Unfortunately, I haven't been able to properly test it. The base case itemHeight: 123 still works as expected, but adding any asynchronicity at all seems to break things. e.g. itemHeight: Promise.resolve(123) causes no list items to be rendered, except in one instance where it randomly worked. I'm guessing there's some sort of timing/concurrency issue here (maybe related to the connect order?), but not really sure since I haven't spent a lot of time investigating. Any ideas?~
~Testing issues / concurrency aside, does the approach I took here look like it makes sense?~
~Edit: Upon further testing, just itemHeight: 123 actually pretty much consistently triggers the problem when Firefox is using really high CPU. I'm guessing that there's a pre-existing concurrency issue here somewhere and my changes just made it more apparent.~

Hi, thanks for the PRs. I will try to give you a review next week!

Sounds good, and not a problem at all.

I'm checking your PR and tried to clone the included demo and use the new function: itemHeight feature. I couldn't get it to work :/. It takes up 100% of the CPU and I have to kill the tab. I'd like to show you the code, maybe you can tell me what I'm doing wrong. Could you give me the rights to push my branch on your fork?

Cool, just added you as a collaborator. I'm not sure why that would happen, but it's possible that I'm not handling some edge case properly (or that my entire implementation isn't very good and is fragile / just happens to work for my use cases).

Ok, we'll find out. It's on the demo/pr-varheight branch.

Ok, saw your edited note.


Start screen UI challenge/yefim yakunin

Done Start Screen challenge

Help pleas ))

Wrong button height, button font weight (should be medium - not regular)

You need to add 3 images (not just 1)

Set all texts in the controller (on viewDidLoad). Don't leave texts in xibs and storyboards


Tailwind CSS IntelliSense extension and "Tailwind CSS" language mode

I'm working on a Next.js project with Tailwind installed along with the Tailwind CSS IntelliSense extension for autocomplete of Tailwind classes in *.css files.

When the Language Mode is set to "Tailwind CSS" (see attached):

Tailwind CSS IntelliSense works
CSS Variable Autocomplete doesn't work

When the Language Mode is set to "CSS":

Tailwind CSS IntelliSense doesn't work
CSS Variable Autocomplete works

Is there a way I can configure CSS Variable Autocomplete to work in CSS files with Language Mode set to "Tailwind CSS"?

Adding tailwindcss to the languages in the VS Code settings appears to fix my issue:
  "cssVariables.languages": [
    "tailwindcss",
    "svelte",
    "scss",
  ]

I'm now able to leave the Language Mode set to Tailwind CSS and both autocomplete options now work.

Adding tailwindcss to the languages in the VS Code settings appears to fix my issue:
  "cssVariables.languages": [
    "tailwindcss",
    "svelte",
    "scss",
  ]

I'm now able to leave the Language Mode set to Tailwind CSS and both autocomplete options now work.


Add NL locale and some pluralisation fixes

Contributed Dutch translations and fixed the "results" pluralisation.

Thanks!


Geojson memory leak

I'm using Mapzen vector tiles to get Geojson data and load it using Cesium.GeoJsonDataSource().load()
After browsing the map a while, Cesium starts using more and more ram and crashes after reaching ~3GB RAM
Made a sandcastle demo to show the Geojson memory leak: https://cesiumjs.org/Cesium/Apps/Sandcastle/?src=Hello World.html&label=Showcases&gist=6079abc25a6ff992220adc40da0284b3

Thanks for the report @AnotherFoxGuy, and thanks for the Sandcastle demo!
We'll try to take a look at this soon. If you're able and have time to debug the problem yourself, we'd be happy to accept any contributions.

I'm closing this as a duplicate of #5662


Vault Agent Injector | Unable to use different Kubernetes Auth Method

Hi everyone,
First thing, many thanks for creating/proving this Operator.
Due to the complexity provided by Vault itself, but also automating complex concepts such as Access Management/Tenancy is very hard, such Operator is very helpful to provide Vault as Service to many Customers.
As suggested in the documentation, we would like to provide to each Customer/Team a separate Auth Engine i.e
Team A : type kubernetes, path : cluster1/team-a-kubernetes
Team B : type kubernetes, path : cluster1/team-b-kubernetes
...
But this doesn't seem to work with how Vault Agent Injector (deployed with Official Helm Chart for OCP), where you can specify there only one Kubernetes Auth Method, as shown be below :
injector:
  # True if you want to enable vault agent injection.
  enabled: true

  # Mount Path of the Vault Kubernetes Auth Method.
  authPath: "auth/kubernetes"

What maybe could work :
injector:
  # True if you want to enable vault agent injection.
  enabled: true

  # Mount Path of the Vault Kubernetes Auth Method.
  authPath:
  -  "auth/kubernetes"
  -  "cluster1/team-a-kubernetes"
  -  "cluster1/team-b-kubernetes"

Environment :

OpenShift 4.9
HashiCorp Vault Helm Chart : https://github.com/hashicorp/vault-helm

name: vault
version: 0.19.0
appVersion: 1.9.3
kubeVersion: ">= 1.14.0-0"

Vault Config Operator :  0.3.1 provided by Red Hat Community of Practice

I don't know if this is by design or if I am missing something, but I was not able to find anything in the Operator documentation.
Any kind of suggestion would be really helpful.
cc : @raffaelespazzoli
Many Thanks,
erlis

@erlisb So the question here seems to be: how can I have the vault agent injector inject an agent that uses a different login path per tenant. This seems to be more of a question for HashiCorp than for this operator. Anyway from what I can see in the docs this is not possible. However you can use annotations in your deployments to change what the injector does on a per tenant basis:
https://www.vaultproject.io/docs/platform/k8s/injector/annotations#vault-annotations .
In particular this one https://www.vaultproject.io/docs/platform/k8s/injector/annotations#vault-hashicorp-com-auth-path allows you to customize the path.

Hi @raffaelespazzoli ,
thanks for your reply.
I did as you suggested and it works as expected. I will close this "issue".
For anyone who might come across this, please remember to use a full path in the Vault annotation :
vault.hashicorp.com/auth-path: "auth/cluster1/team1"
and not just the name of the AuthEngineMount :
vault.hashicorp.com/auth-path: "cluster1/team1"
We are planning to use this Operator for productions workloads, and I see a lot of potential behind it in the Vault Community, so I would ask if there a plan for the future to further develop and enhance it with additional Auth Methods i.e LDAP or different Secret Engines i.e Azure/AWS ?
Many thanks,
erlis


bug in npm install?

Hi,
have i anything bad, please?

what version of node, what os? type node -v

Thank you for fast reply Anthony.
I testing on Debian 8.3 (jessie) 64bit
node v5.7.1

Hey @kraja, sorry for the slow reply. Did you end up getting it working? I have it working with v5.7.1 with Wheezy, and it was developed on Jessie, so it should work.


Supporting Duration as DateTimePickerType

Just asking if the following it's possible and could be a valid idea:
At the moment I'm using the library also as duration picker, but I need to convert every time the DateTime to a Duration which is fine, but not ideal.
I was wondering if it's possible to add duration as pickerType, pickers showed would be same as pickerType.time one, but the returned value would be a Duration.

@matteoberla
Would it be better to have a callback with another type instead of the DateTime type for the time selection?
It is true that it does not seem necessary to have a DateTime type for time only.
For example, how about defining another class to receive the hour and minute in a callback?
class BoardDateTimeDurationResult {
  final int hour;
  final int minute;
}

@matteoberla
Implemented onResult method.
onResult: (val) {
  print('${val.hour}, ${val.minute});
}

In addition to the traditional showBoardDateTimePicker method, a method for each type has been defined.
By using this one, you do not have to define the type of the onResult parameter, but it will return the one that matches the type you want to display.

showBoardDateTimePickerForDateTime: BoardDateTimeResult
showBoardDateTimePickerForDate: BoardDateResult
showBoardDateTimePickerForTime: BoardTimeResult

In the case of a regular Builder, generics can be used to obtain onResult results. Please use it if necessary.
We will release v1.4.0 with this issue, so please be patient!

This is a perfect solution.
I'll test it as soon as you will release the new version.
Thank you very much, I really appreciate it.


[stable/pachyderm] Kubernetes 1.16 support

Describe the bug
pachyderm/templates/etcd_deployment.yaml": no matches for kind "Deployment" in version "extensions/v1beta1"

pachyderm/templates/pachd_deployment.yaml": no matches for kind "Deployment" in version "extensions/v1beta1"

Version of Helm and Kubernetes:
Kubernetes 1.16.3
Helm : 2.13.1
Which chart:
stable/pachyderm
What happened:
Installation error
What you expected to happen:
Chart to be installed with no error
How to reproduce it (as minimally and precisely as possible):
Default installation method
Anything else we need to know:
apiVersion should be apps/v1

i have the same issue


Click on path to copy to Clipboard - visual feedback

please consider adding some sort of visual feedback after copying the path to the clipboard , eg. like in vis2

cheers

When you left/right click on the path, does it not show a tooltip ("Copied "path" to Clipboard!" message)?

This was a bug in AHK, the incorrect positioning of the ToolTip was supposed to be fixed in AHK version <IP_ADDRESS>. Are you running an older version?
With the latest AHK version the ToolTip always appears where the click was made.

you are right, i was using an old version <IP_ADDRESS>


Another related issue, is the fact that loki is not collecting logs from cos itself.


How to import latest angular2-highcharts using AOT compiler

Using angular2-highcharts with webpack and AOT compiler.  The app module does not like the ChartModule.forRoot(require('highcharts')).  I get the following error when I build:
ERROR in Error encountered resolving symbol values statically. Calling function 'ChartModule', function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symbol AppModule in ... /app/app.module.ts, resolving symbol AppModule in ... /app/app.module.ts
It worked fine before upgrading to "angular2-highcharts": "0.5.5",  "@types/highcharts": "4.2.47",
Is there a workaround or how should I configure this?
I have tried using a function to return highcharts like this:
export function highchartsFactory() {
return highcharts;
}
ChartModule.forRoot(highchartsFactory()),
but I get the same error.

You can view a temporary work around here: #160 #156
Looks like a more permanent solution is being investigated by the author.

Нes, it is known issue

May be some of the steps suggested here could help solve this issue -
<EMAIL_ADDRESS>

Any updates on this issue?

I used the workaround provided above (#160) to move on for now:

@mannb1 When you did the workaround, did you run into:
Cannot find name 'require'.)?  Might have missed something from the #160 solution...

I don't recall having any issues of that nature

Yeah I keep getting that same error, it's almost like a race condition...

Just a note on the #160 workaround. It seems like this fix has a huge performance degradation associated with it.

Used following code in my app module and its running fine
import { BrowserModule } from '@angular/platform-browser';
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
import { NgModule } from '@angular/core';
import { FormsModule } from '@angular/forms';
import { HttpModule } from '@angular/http';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { MaterialModule } from '@angular/material';
import 'hammerjs';
import { ChartModule } from 'angular2-highcharts';
import * as highcharts from 'highcharts';
import { HighchartsStatic } from 'angular2-highcharts/dist/HighchartsService';
import { AppRouting } from './app.routing';
import { AppComponent } from './app.component';
declare var require: any;
export function highchartsFactory() {
const hc = require('highcharts');
const dd = require('highcharts/modules/drilldown');
dd(hc);
  return hc;

}
@NgModule({
declarations: [
AppComponent,
],
imports: [
BrowserModule,
FormsModule,
HttpModule,
AppRouting,
BrowserAnimationsModule,
MaterialModule,
ChartModule
],
providers: [{
provide: HighchartsStatic,
useFactory: highchartsFactory
}],
bootstrap: [AppComponent]
})
export class AppModule { }

@Gsmalhotra1
did you try running rollup afterwards?
I'm getting 'Uncaught (in promise): ReferenceError: require is not defined' error

I am getting the same error
core.es5.js:1084 ERROR Error: Uncaught (in promise): Error: Template parse errors:
Can't bind to 'options' since it isn't a known property of 'chart'

Any update on whether this will be fixed without requiring a workaround?

Any updates on this issue?

having the same issue

bump

Also curious about a solution that does not require a workaround

I used a different approach to come around the issue.

Load highcharts via .angular-cli.json through scripts field,

scripts: [
......
{
                    "input": "../node_modules/highcharts/highcharts.js",
                    "output": "highcharts.js"
 },
......
]

Declare highcharts in typings.d.ts (or any other definitions file)

declare var Highcharts: any;

Use the following configuration for HighchartsStatic in your module declaration

    providers: [
        {provide: HighchartsStatic, useValue: Highcharts}
    ]

That's it. Now your code should compile on aot mode.
Hope this helps.

We use the regular approach, and it works with aot. Just import and apply the modules.
import * as highcharts from 'highcharts/js/highcharts';
import * as highchartsMore from 'highcharts/js/highcharts-more';
import * as brokenAxis from 'highcharts/js/modules/broken-axis';
import * as bullet from 'highcharts/js/modules/bullet';

@NgModule({
  imports: [
    ChartModule,
  ],
  providers: [
    {
      provide: HighchartsStatic,
      useFactory: highchartsFactory
    },
  ],
})
export class AppModule { }

export function highchartsFactory() {
  // Default options.
  highcharts.setOptions({
    global: {
      useUTC: false
    }
  });

  // Initialize addons.
  highchartsMore(highcharts);
  brokenAxis(highcharts);
  bullet(highcharts);

  return highcharts;
}

Works like a charm.

Thanks @Jrubzjeknf, it worked perfectly.