Warn if a non dynamic class declaration is overridden in an extension

This will generate a warning if a non-dynamic class declaration is overridden in an extension. When this happens, swift does not update the vtable entry for the class, it just adds the dynamic method. This causes a silent failure when invoking methods via the base class, since the overridden method is not in the vtable.
I updated some Sema unit tests to include this error, since the scenario was tested, and expected to work.
This makes progress on SR-584. I'm investigating the full fix of correctly updating the VTable, if the extension is in the declaring module, but I believe that is in the SILGen code which I haven't touched yet. Any pointers of where to look would be great. I'm going to try to trace into how a dynamic override is able to correctly update the vtable, and see where that goes.
I still think that this fix as it stands would be an improvement, as this can still warn the developer at compile time that the override will not work.

There are some test failures in CursorInfoTest that I was hoping were a build issue, but still happen. Any thoughts on how to run them without re-running the whole test suite?

@KingOfBrian Run check-swift-validation -v, which prints each command that is run. The final invocation runs lit.py with some parameters. Copy and paste those parameters and add --filter=SourceKit/ to run just the sourcekit tests. When you change the code, run ninja sourcekitd-test to just rebuild sourcekitd without the standard library, etc.

Thanks @slavapestov -- I couldn't find check-sift-validation, but --filter is a big help. I think it was a build issue though, I ended up removing build and doing a full new build and the tests are passing -- so this PR should be ready for review.

The other fix we'd like to make in this area is to just take extensions in the same module into account when building the vtable. I guess this doesn't make things worse, though; it just means we stop lying about what's working and what's not.

@jrose-apple Just to clarify, implementing the new vtable behavior is not a requirement for this patch going in, is it? I think even after we implement the new SILGen behavior, we'll still want the warning for the case where you're extending a type from another module.

Yes, I agree. It's not a warning but an error anyway. (I suppose we could warn in Swift 3 mode and error in Swift 4 mode.)

Thanks again for the feedback. I went with your suggestion @jrose-apple of generating a warning in swift 3 in the hope that it helps someone. I couldn't figure out how to generate a diagnostic as a warning or an error without adding another entry in DiagnosticsSema.def. Any suggestions to clean that up would be great.

Two duplicate diagnostics are fine in this case.
Can you rebase though to kill that merge commit?

Hey @jrose-apple - I made a naive stab at this and was curious what you thought. This is my first dip into SILGen, and my cpp is still pretty rusty, but I was able to get extensions to override. I still don't understand how this could work for extensions in multiple files though. If this is a tree that you think is worth me barking up, I could make a PR for comments, or bring discussion to swift-dev?
https://github.com/KingOfBrian/swift/commit/10690fb6fe46f2b0e2c6840e73a0e2888d9285a9

I agree with @slavapestov: this version looks good to go (with the diagnostic nitpicks). We can do the SILGen part later (and probably not for Swift 3.1).

@swift-ci Please smoke test

I can fix up the diagnostic errors on that commit and make another PR. I've been trying to understand when a module refers to a compilation context and when it refers to the Swift module. This made the warning checks a bit more interesting, so I just disabled them while seeing if I could get the SIL to change correctly.
Allowing VTable expansion inside one file doesn't seem like much of an improvement. It would be great if the VTable could be expanded inside a swift module, but I think that would force compilation to use whole module optimizations. I'm not sure if forcing WMO to build with swift is in the cards or not though. And without forcing WMO, we'd need to restrict VTable assembly to account for the file when building with WMO so the VTable is the same with and without WMO.
Anyway, I'm just thinking these things through, I imagine you guys have a plan here, but it's been fun to tag along.

The plan is to go crawl through all extensions in other files when in single-file mode. That's pretty much it. :-)

Interesting, thanks @jrose-apple!

@KingOfBrian I filed an issue related to this diagnostic. It looks like it is emitted multiple times in some cases: https://bugs.swift.org/browse/SR-4024


Improved pingreq sending timing.

It used to be sent each ping_duration_ms_.
After this update, pingreq is sent ping_duration_ms_ passed
after any mqtt control packet sent.

Hi redboltz,
I think it's better to remove client::set_timer() from client::handle_timer().
you can see the function at https://github.com/redboltz/mqtt_cpp/blob/optimize_pingreq/include/mqtt/client.hpp#L506 .
client::handle_timer() calls client::set_timer() twice.
The one is the following call sequence and the second is directly.
endpoint::pingreq()
endpoint::send_pingreq()
endpoint::do_sync_write()
client::reset_timer()
client::set_timer()
The other changes looks good to me.

@udonmo , thank you for the comment. I updated the PR.


update regex of pid field for conformance to RFC5424 spec

Per RFC5424, the field for PROCID is either a NILVALUE (-) or ASCII field from 1 to 128 characters.
https://tools.ietf.org/html/rfc5424#section-6
Valid RFC5424 formatted log using alphanumeric PROCID(PID) value of 'proc1':
<16>1 2013-02-28T12:00:00.003Z <IP_ADDRESS> fluentd proc1 ID24224 [exampleSDID@20224 iut="3" eventSource="Application" eventID="11211"] Hi, from Fluentd!
The regex in this PR commit will properly match the example above.
Replacing PR #2049

Merged. Thanks!
Next, please update commits with push -f. No need to create new PR for update.


Update ReactPhysics3D-UserManual.tex

Fix Typo on documentation

Hello. Thanks a lot for your contribution.
I am closing this pull request because this has already been changed in the develop branch. But thanks a lot anyway.


Syntactic sugar for indexing and slicing

Breeze's a(1 until 5) is more verbose than Numpy's a[1:5]. The same happens with many other indexing and slicing operations. Would you consider implementing Python-like syntactic sugar, maybe using Scala macros?
In several places I have read that syntactic sugar for indexing and slicing of arrays and lists is one of the reasons for the large-scale adoption of Python for data analysis. Thanks to Breeze and other projects, the JVM ecosystem now has the potential to become a solid alternative to Python in this field. Retaining the notation that has been used for decades in Fortran, Matlab and Python would make the transition easier for many people.

can you suggest a syntax? actual python indexing isn't valid scala. I agree it's not ideal, but I'm not sure what to do


fix: increase the content length to fix large file size not working.

Description

[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!TIP]
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10212521266
Commit: 3f4d4a77de26137c70db94457dd4106233fb3941
Cypress dashboard.
Tags: @tag.Datasource
Spec:
Fri, 02 Aug 2024 09:02:19 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit

New Features

Enhanced configuration for handling multipart form data, allowing for the processing of larger files without data truncation.

Improvements

Streamlined initialization of the data processing component, improving readability and maintainability.

@subrata71 It would take more memory for the time it's getting execute. but number of these cases is generally too low on our deployments, For customers who frequently use large files may see spike in memory.
I'm not sure how this could lead to memory leaks, this is basically increasing the acceptable limit of file size.
Although, if there is an existing memory leak we may start to notice since diff will be larger

added a task to increase observability of file size.


Upgrade gulp-minify-css to version 1.2.2

Libraries.io has found that there is a newer version of gulp-minify-css that this project depends on.
More info: https://libraries.io/npm/gulp-minify-css/1.2.2

I'll take this one


"export as namespace" in index.d.ts

I want to use Stimulus as a UMD global from a non-module-based TypeScript project.
// foo_controller.ts
class FooController extends Stimulus.Controller {
    // ...
}

The index.d.ts file which ships with Stimulus only declares a TypeScript module, not a UMD global as well, which means that you can't use Stimulus in a TS script file.
Please could you add export as namespace Stimulus to index.d.ts?

We’d have to do this in a post-build step, I think. Our .d.ts files are generated by the TypeScript compiler, not checked into the source tree.

Is this not it? https://github.com/stimulusjs/stimulus/blob/master/packages/stimulus/index.d.ts

I’m sorry. I was thinking of the @stimulus/core package. You’re correct, that’s where the change should be made.

No worries. Would you like me to send you a pull request or would you prefer to do it yourself?

A pull request would be great - thank you!


"About IPFS" should link to the IPFS-hosted version of the website

Rather than linking to http://ipfs.io/, it seems more appropriate to link instead to http://localhost:8080/ipns/ipfs.io (or whatever the local gateway address is). It would promote the usage of IPFS within the system itself.

https://ipfs.io has a dnslink record that points to the latest CID for the site.
$ jsipfs dns ipfs.io
/ipns/website.ipfs.io

If you have IPFS Companion installed it will detect it and redirect the request to you local IPFS gateway and load the site over IPFS rather than http, which is rad! Using http links with dnslink for the domain is a good way of ensuring that both IPFS and non IPFS users can use them.
In the case of the Web UI it would be cool to use http://localhost:8080/ipns/ipfs.io but then it's not a URL you can easily share with friends who aren't already set up with a local IPFS daemon.


Use system's default rocgdb instead of AOMP's

rocgdb requires libpython.so which is more likely to be found by the system's default rocgdb.
The one in AOMP/bin/rocgdb complains about missing libpython.so file.

I also wonder why we don’t want to test the rocgdb we built and packed ?

I am seeing a different complaint instead of a missing libpython:
[r6 ~]$ /COD/LATEST/aomp/bin/rocgdb
amd-dbgapi library version mismatch, got 0.70.1, need 0.71+

Seems to have started on:
[r6 ~]$ /COD/2023-12-20/aomp/bin/rocgdb
amd-dbgapi library version mismatch, got 0.70.1, need 0.71+

Works before that date:
[r6 ~]$ /COD/2023-12-19/aomp/bin/rocgdb
GNU gdb (AOMP_18.0-1) 13.2
...
For help, type "help".
Type "apropos word" to search for commands related to "word".
(gdb) q

We are actually staging python libs into COD to allow tools that are linked to specific versions of python shared objects to work.  If you see a missing python lib error, paste in the exact error message and the system you saw it on.

We are actually staging python libs into COD to allow tools that are linked to specific versions of python shared objects to work. If you see a missing python lib error, paste in the exact error message and the system you saw it on.

I am getting same error irrespective of using 2024-03-07 build or 2023-12-04 build.
/COD/2024-03-07/aomp/bin/clang++  -g -O0    -fopenmp --offload-arch=gfx90a  -D__OFFLOAD_ARCH_gfx90a__ clang-325070.cpp -o clang-325070
/COD/2024-03-07/aomp/bin/rocgdb -x doit.gdb --args ./clang-325070 0 2>&1 | tee run.log
/COD/2024-03-07/aomp/bin/rocgdb: error while loading shared libraries: libpython3.8.so.1.0: cannot open shared object file: No such file or directory
make: *** [../Makefile.rules:71: run] Error 127

/COW/2023-12-04/aomp/bin/clang++  -g -O0    -fopenmp --offload-arch=gfx90a  -D__OFFLOAD_ARCH_gfx90a__ clang-325070.cpp -o clang-325070
/COW/2023-12-04/aomp/bin/rocgdb -x doit.gdb --args ./clang-325070 0 2>&1 | tee run.log
/COW/2023-12-04/aomp/bin/rocgdb: error while loading shared libraries: libpython3.8.so.1.0: cannot open shared object file: No such file or directory
make: *** [../Makefile.rules:71: run] Error 127

Looking back at the original thread on the 'CI OpenMP compiler daily triage group' teams chat motivated the staging fix, you will need to do the following on a 22.04 system:
[r11 ~]$ PYTHONHOME=/COD/LATEST/aomp/lib/python3.8 PYTHONPATH=/COD/LATEST/aomp/lib/python3.8  LD_LIBRARY_PATH=/COD/LATEST/aomp/lib /COD/LATEST/aomp/bin/rocgdb
GNU gdb (AOMP_19.0-0) 13.2
...
For help, type "help".
Type "apropos word" to search for commands related to "word".
(gdb)

Also note that setting the above env vars also fixes the 'amd-dbgapi library version mismatch, got 0.70.1, need 0.71+' error now seen on 20.04 systems.
Not a "fix" so much as a workaround for running rocgdb built on an older OS.
Not that it helps us in this situation, but the moral of the story is don't link your product with the python shared objects.  There is just no backward compatibility guaranteed (at least not building on 20.04 and running on 22.04).

The 'amd-dbgapi library version mismatch, got 0.70.1, need 0.71+' error is even a problem on the same system where rocgdb was built.   Without specifying LD_LIBRARY_PATH, it is picking up the library from the system /opt/rocm:
[r5 /COD/LATEST/aomp]$ ldd /COD/LATEST/aomp/bin/rocgdb | grep dbgapi
        librocm-dbgapi.so.0 => /opt/rocm-5.7.0/lib/librocm-dbgapi.so.0 (0x00007f8046edb000)

Gets the staged librocm-dbgapi.so.0 with the workaround:
[r5 /COD/LATEST/aomp]$ PYTHONHOME=/COD/LATEST/aomp/lib/python3.8 PYTHONPATH=/COD/LATEST/aomp/lib/python3.8  LD_LIBRARY_PATH=/COD/LATEST/aomp/lib ldd /COD/LATEST/aomp/bin/rocgdb | grep dbgapi
        librocm-dbgapi.so.0 => /COD/LATEST/aomp/lib/librocm-dbgapi.so.0 (0x00007f25342d1000)

This issue feels like a cmake bug in rocgdb, as it should try to pick up shared libraries relative to it's installed location first.


[suggestion] clear tts queue on channel change

This might be a suggestion instead of a problem:
Whenever one changes channel, shouldnt the TTS queue be cleared?

Yes, we should disable TTS and clear the queue when the channel is changed.


Improving types

https://github.com/Tommertom/svelte-ionic-app/blob/e4c7652342c49376dfe74d2d8e41288a36fceacd/index.d.ts#L558C12
For boolean attributes, the correct value type would be:
type Boolean = `${boolean}` | boolean | undefined | null;

In order to write less code and to ensure that the types are always up-to-date and correct, they do not need to be written manually, but taken directly from the source:
import type { DatetimeChangeEventDetail, JSX } from "@ionic/core";
interface IonDatetime_Old {
    "clear-text"?: string;
    "on:ionChange"?: (event: CustomEvent<DatetimeChangeEventDetail> & { target: HTMLIonDatetimeElement }) => void;
}
type IonDatetime_New = {
    "clear-text": JSX.IonDatetime["clearText"];
    "on:ionChange": JSX.IonDatetime["onIonChange"];
};

But comments need to be copied.


Fix #1013 - maintain backward compatiblity

This isn't the best approach to maintain backward compatibility. Look at the recommended approach by the flutter team.

This isn't the best approach to maintain backward compatibility. Look at the recommended approach by the flutter team.

@shabbyplace yup -- you're right. Thanks for the reference - fixed and pushed!

Thank you guys
I will merge it ASAP

Fixed in 0.50.6 Please check it out.


validation failed errors after upgrading to 2.16.4

👋I upgraded to the recently 2.16.4 and now I'm getting this kind of error when I try to upgrade/install some chart:
Release "foo-elasticsearch" does not exist. Installing it now.
Error: validation failed: [services "elasticsearch" not found, services "elasticsearch-headless" not found, statefulsets.apps "elasticsearch" not found]

This was using the official elasticsearch chart, but I tried with different charts, even from the official channel and got the same error. I also tried in a k3d cluster and got the same problem.
Output of helm version:
Client: &version.Version{SemVer:"v2.16.4", GitCommit:"5e135cc465d4231d9bfe2c5a43fd2978ef527e83", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.16.4", GitCommit:"5e135cc465d4231d9bfe2c5a43fd2978ef527e83", GitTreeState:"clean"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.0", GitCommit:"ddf47ac13c1a9483ea035a79cd7c10005ff21a6d", GitTreeState:"clean", BuildDate:"2018-12-03T21:04:45Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.9-gke.12", GitCommit:"4dde8f42b43042db3e662cdd2e707c0f922cae6e", GitTreeState:"clean", BuildDate:"2020-02-13T18:39:12Z", GoVersion:"go1.12.12b4", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):  GKE

Same with me, I'm running AWS EKS 1.15 and upgrade my helm to 2.16.4, one of my charts also got the same issue.
but, if I downgrade helm back to 2.16.3, and everything works again.

You can downgrade the helm version by using below steps
curl https://raw.githubusercontent.com/kubernetes/helm/master/scripts/get > install-helm.sh
chmod u+x install-helm.sh
./install-helm.sh --version v2.16.3
helm init --service-account tiller --wait --upgrade  --force-upgrade

seeing an increased number of cases this morning reporting the same issue. Will look into this today.

My wild guess is this - commit - fe4ffcfa0b872c29df0fbe802ae2c60b7442e1fd . Still digging to understand the commit and how it broke only now. Also, this line is another guess - https://github.com/helm/helm/blame/c35b2b1cce5d14462aee04880f64ac3f09797630/pkg/kube/client.go#L211

https://github.com/kubernetes/cli-runtime/blob/c5a29d532eb1b2cb01eabc7b67be1fb984579c65/pkg/resource/builder.go#L673-L677

Seems to me like the latest should be enabled only when it's an upgrade. For install - it will give an error saying object doesn't exist

I still didn't get the entire meaning or the feature of the latest. What it means by it will fetch the latest copy, then what's the usual? The only things I found out was the below in vendor/k8s.io/cli-runtime/pkg/resource/builder.go
if b.latest {
	// must set namespace prior to fetching
	if b.defaultNamespace {
		visitors = NewDecoratedVisitor(visitors, SetNamespace(b.namespace))
	}
	visitors = NewDecoratedVisitor(visitors, RetrieveLatest)
}

and the below in vendor/k8s.io/cli-runtime/pkg/resource/visitor.go
func RetrieveLatest(info *Info, err error) error {
	if err != nil {
		return err
	}
	if meta.IsListType(info.Object) {
		return fmt.Errorf("watch is only supported on individual resources and resource collections, but a list of resources is found")
	}
	if len(info.Name) == 0 {
		return nil
	}
	if info.Namespaced() && len(info.Namespace) == 0 {
		return fmt.Errorf("no namespace set on resource %s %q", info.Mapping.Resource, info.Name)
	}
	return info.Get()
}

Latest() was added in error. I spent a fair amount of time and trials making changes to figure out how to list resources and their status for the linked PR. Latest() was accidentally added to Validate. #7810 should fix it and did so in my testing.

Once we get this fix I can quickly get another release out.

One issue which might be related (let me know, otherwise I'll post a new bug): when upgrading tiller to 2.16.4 we got the following messages when installing / upgrading deployments:
> helm upgrade myrelease . --install --dry-run -f values.secrets.yaml --namespace mynamespace

Release "myrelease" does not exist. Installing it now.
Error: namespaces "mynamespace" not found

This was solved when rolling back to tiller 2.16.1 (still have to try 2.16.3)

2.16.3 worked for me. Thanks

Merged the fix. Release coming shortly.

2.16.5 is out with the fix.

All good here with 2.16.5, thanks a lot @mattfarina!


ld2412

Hello, friends! Recently, HLK has used this library in addition to a new LD2410-like sensor LD2412, but it doesn't seem to work, if possible, can you help me adapt it? Thank you so much!Here's the documentation for it！
HLK-LD2412 Serial Communication Protocol.pdf

LD2412 seems to be a very different sensor. MyLD2410 library only works with LD2410x sensors (see the instructions)
I could in principle write a separate library for the LD2412 sensor if I had one to test...

您的邮件已收到！

hank you for your reply, I observed that the documentation for these two sensors is not very different, maybe I can modify it on the basis of your library, I will try it. Thank you

Sure. The first step is to change the default baud rate to 115200. The serial communication protocol is the same; you will need to introduce several new commands, though.

Yes, the baud rate is different, it seems that most of the instructions are the same, a few new instructions need to be added, the basic framework is the same, I will try it

For now the library only supports LD2410x.
In the future, I may introduce the LD2412-specific commands when I get my hands on that sensor for testing


Error while building colcon colcon:stderr: mim_control

Error while building colcon colcon build --cmake-args -DCMAKE_BUILD_TYPE=Release:
--- stderr: mim_control
CMake Error at CMakeLists.txt:25 (find_package):
  By not providing "Findpinocchio.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "pinocchio", but CMake did not find one.

  Could not find a package configuration file provided by "pinocchio" with
  any of the following names:

    pinocchioConfig.cmake
    pinocchio-config.cmake

  Add the installation prefix of "pinocchio" to CMAKE_PREFIX_PATH or set
  "pinocchio_DIR" to a directory containing one of the above files.  If
  "pinocchio" provides a separate development package or SDK, be sure it has
  been installed.

---
Failed   <<< mim_control [2.34s, exited with code 1]
Aborted  <<< real_time_tools [10.9s]

Summary: 7 packages finished [12.9s]
  1 package failed: mim_control
  1 package aborted: real_time_tools
  5 packages had stderr output: bullet_utils mim_control real_time_tools robot_properties_bolt robot_properties_solo
  1 package not processed
dvogureckiy99@dvogureckiy99:~

Please make sure that you have the Pinocchio installed and that you sourced it.


Made EventDispatcher optional.

For simple usage, if you don't need event dispatcher for translation events.

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues

Overall direction is alright. Let's finish this one.

Overall direction is alright. Let's finish this one.

Thanks!

Thanks!


Split marriage abroad outcome for same sex ceremonies not possible

The current outcome template
(outcome_same_sex_marriage_and_civil_partnership_not_possible) contains two
logical outcomes:

One for ceremonies in Gibraltar
One for countries where same sex ceremonies are not possible

The outcome body contains a single if/else statement that decides which
logical outcome to display. Splitting these logical outcomes and moving the
"routing logic" to the flow is more consistent with the majority of this Smart
Answer.

LGTM 👍

I've rebased on master and force pushed in preparation for merging.

I've rebased on master and force pushed in preparation for merging.


OneDrive - Teams/Sharepoint folders

In the "cloud archives" section,
add OneDrive folders related to the enterprise (Sharepoint/Teams)

Merging with #1310


Update default_data.json

add my account<EMAIL_ADDRESS>

Thank you for contributing to openstack/stackalytics!
openstack/stackalytics uses Gerrit for code review.
Please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


Any reason for not trying to port  and  vim behaviour?

Was curious why is it that there is no option for native like vim scrolling behaviour with C-d, C-u, is it something that's just not important enough or hard/(too hacky) to for vscode?

Question makes no sense.


Properly pass helmet html attributes when rendering on the server

When spreading helment.htmlAttributes.toString(), it results in passing each letter as a prop.
E.g.
<Helmet>
  <html lang="de" />
</Helmet>

turns into
<html 0="l" 1="a" 2="n" 3="g" 4="=" 5=""" 6="d" 7="e" 8=""" lang="en" prefix="og: http://ogp.me/ns#" data-reactroot="">

Closing due to releasing a new 3.0.0 kit - please reopen at https://github.com/leebenson/reactql if you feel it's still relevant, thanks.


Would be nice to have the original Hive Columns in TableSpec

For my own purposes I have copied some functionality from HiveOps into my own helper called HbaseHiveOps...I copied TableSpec and added another param for the serde columns via the call table.getSd.getCols.asScala.toVector.
I actually needed this and might be useful to have it in HiveOps in the future?
    val table = client.getTable(dbName, tableName)
    val tableType = TableType.values().find(_.name.toLowerCase == table.getTableType.toLowerCase)
      .getOrElse(sys.error("Hive table type is not supported by this version of hive"))
    val params = table.getParameters.asScala.toMap
    TableSpec(
      tableName,
      tableType,
      table.getSd.getCols.asScala.toVector,
      table.getSd.getLocation,
      table.getSd.getNumBuckets,
      table.getSd.getBucketCols.asScala.toList,
      params,
      table.getSd.getInputFormat,
      table.getSd.getOutputFormat,
      table.getSd.getSerdeInfo.getName,
      table.getRetention,
      table.getCreateTime,
      table.getLastAccessTime,
      table.getOwner
    )

Yep agreed.
On 22 Feb 2017 11:11 a.m., "hannesmiller"<EMAIL_ADDRESS>wrote:

For my own purposes I have moved copied some functionality from HiveOps
into my own helper called HbaseHiveOps...I copied TableSpec and added
another param for the serde columns via the call
table.getSd.getCols.asScala.toVector.
I actually needed this and might be useful to have it in HiveOps in the
future?
val table = client.getTable(dbName, tableName)
val tableType = TableType.values().find(_.name.toLowerCase == table.getTableType.toLowerCase)
  .getOrElse(sys.error("Hive table type is not supported by this version of hive"))
val params = table.getParameters.asScala.toMap
TableSpec(
  tableName,
  tableType,
  table.getSd.getCols.asScala.toVector,
  table.getSd.getLocation,
  table.getSd.getNumBuckets,
  table.getSd.getBucketCols.asScala.toList,
  params,
  table.getSd.getInputFormat,
  table.getSd.getOutputFormat,
  table.getSd.getSerdeInfo.getName,
  table.getRetention,
  table.getCreateTime,
  table.getLastAccessTime,
  table.getOwner
)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sksamuel/eel-sdk/issues/252, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAtZGmWl_hl3NoVnPEMG68uoTcFluq-Rks5rfBfngaJpZM4MIgf-
.


Cork 2 doesnt find libcpr.so.1 after installing

After installing Cork 2, when you try running any cork command, you get a missing library error

The instructions on the readme might be a bit outdated, try using the following to build it:
git clone https://github.com/CorkHQ/Cork.git
cd Cork
mkdir build
cmake -Bbuild -H. -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=OFF -DCPR_USE_SYSTEM_CURL=ON
cmake --build build/ --target all
cd build
cmake --install . --prefix ~/.local

Let me know if it works!

This worked first try, thanks!


Rename of the Xiaomi Gateway platform

We discussed the topic recently on discord. The name of the xiaomi gateway platform isn't perfect. The supported xiaomi products at HA can be divided into two groups:

Aqara (zigbee) devices + the gateway (xiaomi, xiaomi.switch, xiaomi.light, xiaomi.binary_sensor, ...)
Miio (WiFi) devices (vacuum.xiaomi, xiaomi_philipslight)

I want to contribute the support of the xiaomi_airpurifier, xiaomi_plug and some more xiaomi miio devices. The suggestion is a rename of some platforms grouped by protocol:
xiaomi -> xiaomi_aqara, xiaomi_aqara.switch, xiaomi_aqara.light, xiaomi_aqara.binary_sensor, ...
vacuum.xiaomi, xiaomi_philipslight -> xiaomi_miio, vacuum.xiaomi_miio, light.xiaomi_miio
It will be a breaking change but will solve a lot of confusion at the community.
@Danielhiversen
@balloob

I agree with this. It seems like the Xiaomi gateway is branded as "aqara" and so we should tag the component and related platforms with that.
Note that components and platforms that are related (because of discovery) should share their name for component and platforms. That way the documentation will also link them together.

I agree.
I can  do the refactoring of the code to day or tomorrow.

Cool! Please tell me if you need support or I can do some testing.
Please don't miss the new discovery of @pfalcon: https://github.com/home-assistant/netdisco/blob/master/netdisco/discoverables/xiaomi_gw.py


envoyproxy/envoy:v1.23.0 docker image broken on aarch64

Description:
This is duplicate of https://github.com/envoyproxy/envoy/issues/22261, missed it on first look.
The envoyproxy/envoy:v1.23.0 fails to start with /docker-entrypoint.sh: 29: exec: su-exec: Exec format error. The envoyproxy/envoy:v1.22.0 works as expected.


implement shelve feature

There is an old feature request
https://github.com/Microsoft/vscode/issues/54243
Git stash ain't a convinient thing: I want to access shelved files in any branch within an explorer view, could compare diffs with any branch. I really miss this thing from IntellijIdea

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

Is there any progress on this feature? It is so useful in Rider as well.

(up)

waiting for this feature

(up)

+1

(up)


access: may-start-trybots

I have been doing an increasing amount of work on golang for ppc64, and this would be helpful to reduce noise to others.  My linked account is<EMAIL_ADDRESS>Can it be granted access to may-start-trybots and anything else required to perform CI on the go and go/arch repos?

/cc @golang/release

Hi Paul,
Thank you for your contributions and for requesting Trybots access! I've added you to the may-start-trybots group, so you should be able to do so now.
As you've likely read at https://golang.org/wiki/GerritAccess#trybot-access-may-start-trybots, please be sure to at least skim CLs before starting a Trybot run.
Let us know if you have any questions or issues with it, and thanks again! I apologize for the delay in responding to this request.


Add event http logger handler

:mag: Description
Issue References 🔗

Describe Your Solution 🔧
Add event http logger handler
Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklists
📝 Author Self Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

[ ] Pull request title is okay.
[ ] No license issues.
[ ] Milestone correctly set?
[ ] Test coverage is ok
[ ] Assignees are selected.
[ ] Minimum number of approvals
[ ] No changes are requested

Be nice. Be informative.

@silencily thanks for your contribution, can we have a doc for this feature? What should be HTTP server be like?


cmdline.txt

make: *** No rule to make target pi-init2/boot/cmdline.txt', needed by boot'.  Stop.
Something missing perhaps?

Also this one, because Makefile.


Emit es6 imports for TypeScript files

Fixes #519
Tests need to be adjusted before merging.

@wokalski thanks for putting this up.
The issues that come up with es6 imports have to do with the fact that TS treats them as types, while require's are untyped.
For example:
Could not find a declaration file for module 'bs-platform/lib/es6/curry.js'. '/Users/cristianoc/reasonml/genType/examples/typescript-react-example/node_modules/bs-platform/lib/es6/curry.js' implicitly has an 'any' type.
  Try `npm install @types/bs-platform` if it exists or add a new declaration (.d.ts) file containing `declare module 'bs-platform/lib/es6/curry.js';`  TS7016

Wondering what code (or silencing comment) should be generated to make it treat imports as untyped.

@cristianoc I added two more commits on my branch but for some reason they don't pop up here. You can see them here:
https://github.com/dialohq/genType/commits/es6-typescript-imports

@cristianoc I have addressed the issue with a workaround.

We first import using es6 syntax and ignore the type error
We cast the imported value to any

// @ts.ignore: Ignore any on import
import * as ModuleBsEs6Import from "./module.bs";
const ModuleBs: any = ModuleBsEs6Import;

The only possible drawback is when there are any cases when we depend on type definitions from imported modules which IIUC should not happen.

@wokalski thanks a lot, this looks great.
Would you change the suffix from Es6Import to __Es6Import to make name clashes a bit less likely?

@cristianoc On another note - would you accept a contribution either with esy.json or with instructions how to develop using esy? It doesn't require any changes if you set esy.buildsInSource: "build" in esy.json.
Another thing I'd like to do is adding test script to all examples and them in integration test suite. For typescript the test script would call tsc and for flow it'd run flow. At first I didn't notice the issue you mentioned in the first comment because I foolishly just ran tests.

Amazing, thank you so much.

@cristianoc are you going to release the change soon or should I depend on master with opam/esy in my project?

@wokalski planning to do a release today or tomorrow.

@wokalski in release 3.45.0.


Removing the duplicated pushy Windows dependencies

We don't actually need to duplicate these.  See https://github.com/chef/opscode-pushy-client/pull/91#issuecomment-220693642 for more detail.
\cc @ksubrama @mwrock @PrajaktaPurohit

After changing the Gemfile, I just did a bundle install because running bundle exec rake dependencies started changing a bunch of stuff

We fixed this another way


Add missing MySQL type

ModelQ missed double data type, it is generated as "string". The PR fixes that

Thank you very much.


k3s will be restart every 15 minutes when only run etcd

error message
level=fatal msg="Tunnel watches failed to wait for apiserver ready: timed out waiting for the condition, failed to get apiserver /readyz status: apiserver disabled"

configuration of k3s server
private-registry:/path/to/file
pause-image: docker.io/rancher/mirrored-pause:3.6
node-name: xxx
cluster-init: true
disable-apiserver: true
disable-controller-manager: true
disable-scheduler: true
disable-helm-controller: true
disable-cloud-controller: true
disable: servicelb,traefik,local-storage
disable-agent: true
disable-kube-proxy: true
disable-network-policy: true
flannel-backend: none
token-file: /path/to/file
agent-token-file: /path/to/file

what should i do to keep etcd running and not restart

Have you added a control-plane node, without the apiserver and everything else disabled? You're not intended to leave the etcd-only node sitting there by itself forever.

As mentioned in the docs, disable-agent is experimental, and not supported with embedded etcd. Embedded etcd needs an agent so that a node object is created to track etcd cluster membership.

I try to run etcd with disable-agent false, it have not  restart yet.
We will try another way to deal with etcd-only.
Thanks for your reply.

What are you trying to get out of running dedicated etcd and control-plane nodes without agents? If you could help us understand your use case, we might be able to accommodate it in future releases.

We have a cluster with one k3s server which running etcd and master, and every time we try to delete all the pod in one namespace, k3s server will crash and restart. The server which k3s running on with high cpu usage, 100%wa.
That's the reason why we try to separate etcd from server.

The number of pods is around 100

Ok but why did you disable the agent, instead of just tainting the node to keep workload pods off it?

For the reason,
We don't want to see etcd node and master node by kubectl.
And the node may be scheduled when toleration Exists is present on the pod. That might cause some security issues.

It's true we were suffer insufficient disk throughput for etcd when server crashed.
We will try to run server with sqlite later on our dev environment.
Thanks a lot, your recommendation is helpful for us.


[FR] Add possibilty to use Video entry

I'm using an Video entry System of Comelit and would like to integrate that to HA.
The System i'm using is the Mini Wi-Fi (https://www.comelitgroup.com/en/systems/video-entry-technology/the-home-indoor-video-entry-phones/mini-wi-fi/)
This is connected to the Comelit App and can be used for opening the Latch and display the Video from the Outdoor part.
(https://www.comelitgroup.com/en/systems/video-entry-technology/outdoors-entry-phones-and-monitors/quadra/)

The integration supports the comelit vedo and comelit simple prog protocols.
I am trying to figure out how it should support the Mini Wi-fi system and its aim.


Angular cli compile errors

I have integrated the plugin into my project but when I go to compile using the angular cli, I get the following error
ERROR in node_modules/filterizr/dist/FilterContainer.d.ts(1,10): error TS2305: Module '"/Users/work/project/project1/node_modules/filterizr/dist/FilterizrOptions/defaultOptions"' has no exported member 'RawOptionsCallbacks'
node_modules/filterizr/dist/FilterItems.d.ts(1,10): error TS2305: Module '"/Users/work/project/project1/node_modules/filterizr/dist/ActiveFilter"' has no exported member 'Filter'.
Is this module compatible with angular cli?

@karl04 which Filterizr version are you using?

@giotiskl  I'm using version filterizr": "^2.2.3"
when I run the ng build command, it throws the above errors

@karl04 can you share the code snippet where you import/use Filterizr or are the errors simply thrown by adding filterizr to your node modules and runing the ng build command?
It looks like there's some problem with the type declarations shipped with Filterizr, adding to your tsconfig.json the following will temporarily disable these issues (most likely) but that's not a proper fix ofc.
{
    "compilerOptions": {
        "skipLibCheck": true,
        ...
    },
    ...
}

I'll have to look more into this

the errors simply thrown by adding filterizr to node modules and running the ng build command.
yes it compiles with the flag enabled, but is there a way to just skip checking for this module?

@karl04 could you please also share the contents of your tsconfig.json?
As far as I know the skipLibCheck option is applied to all installed (TypeScript) libraries, but is not necessarily a bad practice (e.g. FB's create-react-app has it enabled by default for newly created TypeScript React apps). In some cases it can even speed up the compilation of your own app.
The thing is that some times libraries have a less (or more) strict tsconfig than your own which can cause incompatibilities.
Although based on the error you get it looks like some types are not exported properly. I couldn't reproduce it yet unfortunately.

{
"compileOnSave": false,
"compilerOptions": {
"outDir": "./dist/out-tsc",
//"skipLibCheck": true,
"baseUrl": "src",
"sourceMap": true,
"declaration": false,
"moduleResolution": "node",
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"target": "es5",
"typeRoots": [
"node_modules/@types"
],
"lib": [
"es2016",
"dom"
]
},
"exclude": ["./node_modules"],
"angularCompilerOptions": {
"preserveWhitespaces": false
}
}

I have integrated the plugin into my project but when I go to compile using the angular cli, I get the following error
ERROR in node_modules/filterizr/dist/FilterContainer.d.ts(1,10): error TS2305: Module '"/Users/work/project/project1/node_modules/filterizr/dist/FilterizrOptions/defaultOptions"' has no exported member 'RawOptionsCallbacks'
node_modules/filterizr/dist/FilterItems.d.ts(1,10): error TS2305: Module '"/Users/work/project/project1/node_modules/filterizr/dist/ActiveFilter"' has no exported member 'Filter'.
Is this module compatible with angular cli?

I also had the same error with ionic 4. Any solution ?


more methods for wrappers like StXSL and StClasspath

@rultor release, tag is 0.5.0

@rultor release, tag is 0.5.0

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.5.0

@yegor256 Done! FYI, the full log is here (took me 5min)


Provide a feature to configure database driver config

The problem faced currently?
No way to configure the underlying database drivers
How can we solve it?
We should expose this on the frontend.

If you want this feature to be implemented, give it a thumbs up reaction, so that we can determine which features are important to you.
👍

What type of config are we talking about here? Things like connection pooling?

Yes @HeyItsJs. Done in the backend.

Done in frontend as well


[WIP] use llhttp as default HTTP parser

Description: Uses llhttp to parse HTTP/1.1 traffic. A compile-time switch is provided to use the legacy Node http-parser. Preprocessor macros were selected due to global naming conflicts between the two libraries. The alternative to make it a runtime switch would require #includeing the libraries within separate namespaces (I can backtrack to this option if it's more desirable).
TODO

resolve lenient_http_headers issue as mentioned on the ticket
fix BadRequestNoStream test to not open a new stream

There are other places that still use the http-parser, notably the http_inspector network filter and the url parsing utilities.
Risk Level: medium
Testing: existing
Docs Changes:
Release Notes:
Fixes #5155
Deprecated: http-parser

Fantastic work, @derekargueta ! I'm curious if this will bring any noticeable performance improvements to envoyproxy!

@envoyproxy/security-team for review as well.

@derekargueta awesome stuff. I put this comment in the issue, but is it possible to compile both in for a period of time so we can feature flag which parser to use?
/wait-any

+1 to what Matt said.  I'm super excited for the switch and it'd be even better if we can runtime switch this for a release or two!

FWIW, I've created a PR to introduce lenient parsing to llhttp: https://github.com/nodejs/llhttp/pull/33 .

@mattklein123 @alyssawilk yeah I started working on a runtime switch. The catch is that llhttp.h and http_parser.h can't be in the same compilation unit due to conflicting enum definitions (ODR \o/) so the solution I have working so far uses the pimpl pattern to contain those libraries in source files. I'm a bit concerned about a perf penalty for the pointer-indirection, granted I'm not super experienced here in C++ perf, but am planning on writing a few benchmark tests to justify the change. Doesn't seem we have codec benchmark tests yet. If I'm going overboard or there's a better pattern I'd be happy to hear it 🙂

@derekargueta from a quick glance it doesn't seems have conflicting enum between llhttp and http_parser, seems everything in llhttp is prefixed with llhttp_. I don't think pimpl solves the ODR because you still link them together at the end.

@lizan sorry I misspoke, it's not the enum's themselves (which you are correct, llhttp is prefixed with llhttp_) but the enum values since they are plain C enums and not C++ class-enums.
When the 2 are included into the same context (directly or transitively):
...
In file included from source/common/http/http1/comparison.cc:7:
external/com_github_nodejs_http_parser/http_parser.h:210:19: error: redefinition of enumerator 'HTTP_REBIND'
  HTTP_METHOD_MAP(XX)
                  ^
external/com_github_nodejs_llhttp/include/llhttp.h:124:3: note: previous definition is here
  HTTP_REBIND = 17,
  ^
In file included from source/common/http/http1/comparison.cc:7:
external/com_github_nodejs_http_parser/http_parser.h:210:19: error: redefinition of enumerator 'HTTP_UNBIND'
  HTTP_METHOD_MAP(XX)
                  ^
external/com_github_nodejs_llhttp/include/llhttp.h:125:3: note: previous definition is here
  HTTP_UNBIND = 18,
  ^

Can we change llhttp to prefix it's enum values? I am not sure that is necessary though.
We should have an abstraction layer with its own enum to enable the switch, right!

@derekargueta thanks that makes sense, yeah then you need two classes implement same interface in different compilation unit to make it work.

Still very much a WIP, not yet ready for full review but high-level comments welcome. Wrestling with getting the static-casting right from void* to ParserCallbacks*, then likely debugging a few tests, and cleaning up misc comments & cruft. Also still massaging the abstractions a bit.
This introduces quite a few abstractions with the aim of completely decoupling the HTTP parser from the codec/connectionimpl which is necessary for the 2 libraries to coexist. Main components are

ParserCallbacks, an interface the {Server|Client}ConnectionImpl classes implement to hook into the parser callbacks
ParserFactory for constructing the parser
Parser/LlHttpParserImpl/LegacyHttpParserImpl which is where the PImpl pattern mentioned earlier is being used to encapsulate the libraries in separate compilation units.

Also keeping an eye on https://github.com/envoyproxy/envoy/pull/8667 which looks like will have conflicts with this PR


libs/datamodel/connectors/dml/src/model.rs:338:29

Bug description
When testing prisma db pull on a database received an error:
[libs/datamodel/connectors/dml/src/model.rs:338:29]
Hi there! We've been seeing this error in our error reporting backend, but cannot reproduce it in our own tests. …

Reporting as requested in error message.
How to reproduce
This error is reproducable by doing a prisma db pull on an existing database with a table that has a primary key column that lacks any [a-zA-Z] characters in its name. It occurs both on single column primary key constraints, and table level composite primary key constraints if one of the columns.
It does not occur with columns that are not primary key columns.
CREATE TABLE "example" ( "имя" text primary key );

-- or --

CREATE TABLE "example" ( "_" int, "a" text, primary key ( "_", "a" ));

Expected behavior

The same as when there are no [a-zA-Z] characters in other columns, comment out the key and add @@ignore to the table for lack of a primary key;
Auto-assign a column name such as column_1;
Better support for international languages and non [a-zA-Z] columns and table names.

Prisma information
generator client {
  provider = "prisma-client-js"
}

datasource psql {
  provider          = "postgresql"
  url               = env("DATASTORE_URL")
  shadowDatabaseUrl = env("DATASTORE_DEV")
}

Environment & setup

OS: Ubuntu 20.04.3 LTS ( WSL 2 )
Database: PostgreSQL
Node.js version: 16.13.1

Prisma Version
prisma                  : 3.7.0
@prisma/client          : 3.7.0
Current platform        : debian-openssl-1.1.x
Query Engine (Node-API) : libquery-engine 8746e055198f517658c08a0c426c7eec87f5a85f (at node_modules/.pnpm/@prisma+engines<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 8746e055198f517658c08a0c426c7eec87f5a85f (at node_modules/.pnpm/@prisma+engines<EMAIL_ADDRESS>Introspection Engine    : introspection-core 8746e055198f517658c08a0c426c7eec87f5a85f (at node_modules/.pnpm/@prisma+engines<EMAIL_ADDRESS>Format Binary           : prisma-fmt 8746e055198f517658c08a0c426c7eec87f5a85f (at node_modules/.pnpm/@prisma+engines<EMAIL_ADDRESS>Default Engines Hash    : 8746e055198f517658c08a0c426c7eec87f5a85f
Studio                  : 0.445.0

Here's a more recent error report for this issue: https://prisma-errors.netlify.app/report/14260

Fixed in https://github.com/prisma/prisma-engines/pull/2898
I'd recommend updating to the latest version (4.7.1) due to it having a LOT of introspection crashes fixed.


Update Cats and Circe versions

Circe 0.5.0 is identical to 0.5.0-M3, and Cats 0.7.2 is binary-compatible with 0.7.0, but updating lets us avoid exposing users to this bug in Cats 0.7.0.

Current coverage is 74.95% (diff: 100%)

Merging #639 into master will not change coverage

Powered by Codecov. Last update f165e43...0a0115b

Thanks @travisbrown!


Inconsistent Mermaid semicolons

On this page [1], you have this example:

where the first line omit semicolon, but all others have it. This seems to run counter to the Mermaid docs, which either use all [2] or none [3].

https://github.blog/2022-02-14-include-diagrams-markdown-files-mermaid
https://mermaid-js.github.io/mermaid
https://mermaid-js.github.io/mermaid/#flowchart

@89z
Thanks for opening this issue! The best place to send your feedback regarding this is at https://github.com/github/feedback/discussions/4539 💛


Detect epoch lag & catch up

We watched the epoch differences in a94cb3f.

The above dev. debug message shows that node 4 is in the epoch 10, 4 blocks behinds the main chain. This may happen when node 4 heading too fast to epoch 10 with a loser tail block, and then ignores other peers's winner block of the epoch 9. After that node 4 will reject all legitimate bp & blocks of the epoch 10, since its chain tail is wrong.
Solutions
We may have two strategies here:

Wait & Sync: Node counts enough block (new block) message before heading to next epoch.
Detect & Catch up : Node detects its epoch lag by watching received bp and block's height, and then query the network to catch up its epoch.

What we encountered here is actually an accumulative error. Node 4 may start epoch 10 early since it ends epoch 9 early. We may use a more accurate event indicator to start the goNextEpoch timer than current Enough_Txs. e.g. an AFW (r3) message of the current epoch.

After rethinking of the sync problem here, we decide to make two fundamental changes in W3 protocol:

Tx Collecting Strategy: tx_count → fixed collecting timeframe
Epoch Sync: the previous epoch's block message resets the current epoch's nextEpochTimer

We've already implemented the Epoch Sync strategy, i.e. almost-fixed epoch time and adjusting by the block (minted) messages. Now we have to adapt our verification algorithms to work with it, verifying not only bps, blocks for this epoch, but also for previous epoch when needed.

This issue is resolved, #2


Magazines should be searchable

Magazine content should be indexed in algolia as we do for news.
A newsroom like page, and a link in the Menu is also required.
Accept criteria:

[ ] Improve search documentation in Runbook
[ ] Add documentation for magazines in Runbook
[ ] Verify if sanity roles need to be updated to include magazine, if not already done so

Pending creation of magazine articles.
What's left to do is documentation at least.

Hi @SvSven, a few points:
There is a 'News' placeholder in the Magazine.

This would also be nice to be renamed, in MagazineIndexPage.tsx:

For the magasin index file, we should update this from en to no:

We should also make sure the magazine type is added correctly to the sanity roles before deploying to production. I'll update the acceptance criteria

Good catch on the magasin index page; copy paste error 😅
Have fixed the component names and the heading. It's not perfect yet, we should at some point come back here and refactor things more - the newsroom was never set up to have "shared" code/components so it's a bit of a mess still.
The roles I am not sure of, have not done anything with that yet.

Magazine Index page is not being displayed in the studio:

Good catch on the magasin index page; copy paste error 😅 Have fixed the component names and the heading. It's not perfect yet, we should at some point come back here and refactor things more - the newsroom was never set up to have "shared" code/components so it's a bit of a mess still.
The roles I am not sure of, have not done anything with that yet.

I've basically added it to here:

Reminder to add exclude from search

@meols @jorgol, can you please review this one?
https://studio-global-development-equinor-web-sites-dev.c2.radix.equinor.com/desk/misc;magazineIndexPage;magazineIndex
https://web-global-development-equinor-web-sites-dev.c2.radix.equinor.com/search?query=magazine&tab=magazine
https://web-global-development-equinor-web-sites-dev.c2.radix.equinor.com/magazine
Please keep in mind that adding a new magazine or updating it, will not automatically index it. I need to run a script to update the indexed magazines in the dev environment.

@fernandolucchesi - when searching for "second magazine" it looks like I don't get a hit with the text Nothing found showing, but there is a hit in the magazine tab, which isn't easy to see (and probably not good for accessibility)

Will we (can we) get the cards/promo look instead of the list look on the index page to make it more visually appealing (as we had in AEM)
Also some comments to the template:

is it decided (by who) to not have date/custom date, which we had in AEM. Is it a big task to add it?
I suggest to edit the distribution/subscription text to:
Subscribers: Toggle (change to green) to send to subscribers when you publish the magazine article.

Hi @meols, we can for sure improve UX for search, specially now that @NickHaggerty1 is back. However I'd suggest that these UX improvements are handled by a different issue.
As for the templates, It was agreed before that since we didn't have a custom template (design wise) for Magazine, using the same as Topic Page was a good start, and that is why there is no date/custom date (since topics don't have this field). Adding it is not a big task :)

@meols Feel like there are quite a few different points you are raising here relating to magazine. There has been no internal chat (as far as I know) on the requirements for magazine so suggest we do that so we cover all the different elements and then create issues relating to Magazine. There are points relating to  Magazine template. Magazine landing page. As well as search display. For me the UX on magazine search is correct (its just not showing the result you expected) and in keeping with the approved and implemented design for News search and Topic search.

Wait to deploy - do not turn on feature flag 🎏


Some questions about DSTIKE products

Sorry if this questions is not for this forum, but i need to ask it.
I am a very unexperienced user of ARDUINO and I want to buy such a device, which works "from box".
I want to buy the following DSTIKE products
https://ru.aliexpress.com/item/32964715932.html
https://ru.aliexpress.com/item/32971339474.html
https://ru.aliexpress.com/item/32859266128.html
at ALIEXPRESS, but the seller cant fully answer my questions and offered to ask this questions at this forum
Q1: Has first device (DSTIKE D-duino-32 SD Final ESP32 OLED) got a SD socket "from box" and can it save packets directly to SD flash "from box"?
Or i need to purchase some details and need to attach them to that device?
Q2: How easy is it to change the settings of the second device (DSTIKE WiFi Deauth detector)? Will it be neccessary to make the firmware update?
For example, how easy is it to change the thresold of the number of deauthorization packets caught for an audio signal (eq: change 5 caught packets to 20 packets, or mute the audio)?
Q3: first device (DSTIKE D-duino-32 SD Final ESP32 OLED) - to save space on the SD card, is it possible to configure it, so that it saves only certain packets (not all packets)?
Has it got some filtration before saving the data to SD?
Q4: first device (DSTIKE D-duino-32 SD Final ESP32 OLED) - what is the size of the memory card it can use?
Does the device somehow inform that there is no space on SD?

Don't buy this stuff if you want something that works out of the box.
I mean the devices come flashed with software, but your questions show that you wish to configure a lot of different things.
I wouldn't say it's hard to do these changes, but that's subjective. It's impossible for me to give you a scale on how hard it will be for you.
All I can tell you is that you will have to invest some time and learn how to code with Arduino.
Changing a threshold just the matter of changing the right variable, filtering different kinds of packets however requires you to know how different packets look (in bytes).
The point of these devices is not to be a commercial product for consumers to just use but a development board to tinker around with.
Q1: It does have a SD card socket yes.
Q2: Modify the code
Q3: Modify the code
Q4: No limit, however I would recommend 32GB max if you use windows, as you will need to format it to FAT32 and windows won't let you do that for bigger cards.
I don't think it has a proper info when the card is full, but not sure.
I hope this answers your questions :)

Q1: It does have a SD card socket yes.
Q2: Modify the code
Q3: Modify the code
Q4: No limit, however I would recommend 32GB max if you use windows, as you will need to format it to FAT32 and windows won't let you do that for bigger cards.
I don't think it has a proper info when the card is full, but not sure.
Thank you for answers.
Q2-plus and Q3-plus:
Does the build-in USB interface allow the modification of code?
Or i need to purcase some firmware update device tool?

Q2-3 yes. Just plug it into your computer and you will be able flash new code onto it like that. No extra hardware needed for that part


Package is not indexed after published for a few hours, please help investigate

The package is listed here:
https://www.nuget.org/packages/Microsoft.ApplicationInsights.Profiler.Core/1.1.4-beta1

Seems it resolved by itself after a while.


Missing a unboxing when compiling a call to new NativeArray

In the following code,
var i
i = 4
var na = new NativeArray[Object](i)

the declaration type of i is nullable Object, so the C-type of i is val* (and not int).
Therefore, in the new NativeArray, it should be unboxed because the C signature expect a int.

+1

+1

:shipit:


[ENHANCEMENT] Remove examples from README

Rename examples/README.jl to examples/examples.jl, remove the badges and installation instructions, and use Literate to compile it to docs/src/examples.md. Then, remove the examples from README.md (which will no longer by generated by Literate), and link to the examples in the docs.
That way, we can more easily update the README using ITensorPkgSkeleton.generate without overwriting the examples.

Based on a discussion with @lkdvos I don't think this is a good idea since the README will likely be modified anyway, so there is no real gain to doing this.


transformer: React Refresh different output compared to babel

Using https://github.com/oxc-project/bench-transformer/blob/main/fixtures/UserSettings.tsx
With https://github.com/oxc-project/bench-transformer/blob/1d97626d9a40046e4be7a3538ec1a9378cdd64c5/src/transform.bench.js#L8-L9
const development = true;
const refresh = true;

Uncomment https://github.com/oxc-project/bench-transformer/blob/1d97626d9a40046e4be7a3538ec1a9378cdd64c5/src/transform.bench.js#L63
then run pnpm run bench transform
Oxc produces
_s(UserSettings, "xzl9n9mUlx5jvXUu+MIqPIqvR+E=", false, function() {
	return [
		trpc.useSuspenseQuery,
		useLocale,
		useTimePreferences,
		useTelemetry,
		useForm,
		trpc.useUtils,
		trpc.useMutation
	];
});

Babel produces
_s(UserSettings, "t749M4ZN74U/lulDMtBAO8yAXBg=", true, function () {
  return [useLocale, useTimePreferences, useTelemetry, useForm, trpc.useUtils];
});

swc produces
_s(UserSettings, "t749M4ZN74U/lulDMtBAO8yAXBg=", false, function() {
    return [
        useLocale,
        useTimePreferences,
        useTelemetry,
        useForm,
        trpc.useUtils
    ];
});

What is the 3rd argument true / false?

What is the 3rd argument true / false?

This argument means whether to force reset, But I don't how it does in the runtime of React Fast Refresh
https://github.com/oxc-project/oxc/blob/f468da13b8c8d7b0722afec9f232c6606ea4562c/crates/oxc_transformer/src/react/refresh.rs#L634-L640
The implementation of Babel handling here
https://github.com/facebook/react/blob/ba6a9e94edf0db3ad96432804f9931ce9dc89fec/packages/react-refresh/src/ReactFreshBabelPlugin.js#L294-L318
I re-read this logic and I haven't seen the problem. Needs to debug how was going in Babel plugin

I think Babel logic output false because it for trpc.viewer.me.useSuspenseQuery() is analyzed as me.useSuspenseQuery() and me is not in scope.
I think the ideal output in the logic of fast refresh would be to have true and trpc.viewer.me.useSuspenseQuery in the hook array, but I think following swc behaviour is better for compatibility

I think Babel logic output true because it for trpc.viewer.me.useSuspenseQuery() is analyzed as me.useSuspenseQuery() and me is not in scope. I think the ideal output in the logic of fast refresh would be to have fals and trpc.viewer.me.useSuspenseQuery in the hook array, but I think following swc behaviour is better for compatibility

Thanks for your investigation. Now the output same as SWC, and then all of us implementation has some problems 😢