privacyGroupId as input to orion private transaction

privateFor[] and privacyGroupId are treated mutually exclusive (cannot
supply both
adds privacyGroupId to swagger input
Fix parameters to priv_getTransactionReceipt

We also need to think about the gas estimate case, and ensure the gas estimation (and subsequent call if it falls to get the revert message) are performed using the private tx.

@peterbroadhurst it appears that the equivalent of eth_call method for private transactions priv_call is in progress https://jira.hyperledger.org/browse/BESU-78 . I did not find an equivalent in quorum/tessera for this. I could not find documentation for the params to be passed to eth_call for privacygroupid/privatefor

It shouldn't be needed for quorum/tessera I think, because there the execution will run against the private state (as known to the connected node) by default I believe.
Sounds like we'll have to disable the estimate for Besu for now, and require the user to do their own gas estimation?

Mind doing a merge with master for these changes too?

Tested changes using a locally running ethconnect rest api server and connected to a besu node in kaleido (verfied orion logs to check contract deployment and get/set). The request was:
http://localhost:7777/abis/a1386ead-4ea3-44b6-4c69-976443bc4971?kld-privatefrom=5EBljVIcDKinitW3KLLxCWhoF+LdrSJ6aAE6uOXIHno=&kld-from=0x70a9047c43091594135da450d55aed382d8cd968&kld-sync=true&kld-privacygroupid=TCSmA79lr6yK7MNA770OPtviG9wh6ysH3Sn1rzBmDyY=

kld-from
kld-privatefrom
kld-privacygroupid
kld-sync


Pattern: Card - Accessibility - When focus reaches Click here link, Voiceover announces "table start landmark" which confuses the user.

Detailed description
Issue :- When focus reaches this click here link, Voiceover announces "table start landmark" which confuses the user.
Expected - Since there is no landmark or table found here, Screen reader should not be announcing this.
Additional information

@Praveen-sr
Some updates were done to the cards recently,
can you please test it again? thanks!

@RaphaelAmadeu Ram re checked, the following issue is not there now.
Instead Voice-over iPhone is announcing as "footer region" when focus comes to the click here link.
He is suggesting - If this link is not within a footer section, the footer landmark should be removed from the code.


fix auto-update script to handle new go modules from core

Signed-off-by: Robbie Lankford<EMAIL_ADDRESS>@jpkrohling I saw your comment on #37 and updated the script. Feel free to close if this isn't what you had in mind.

I've seen a failure when running the workflow manually, but it's likely unrelated to this PR:
jq: error: Could not open file latest-core.json: No such file or directory
date: invalid date ‘+%s’
jq: error: Could not open file latest-contrib.json: No such file or directory
date: invalid date ‘+%s’
./scripts/update-to-latest-otelcol.sh: line 48: ((: <  : syntax error: operand expected (error token is "<  ")

Are you on a mac? Running it locally on mac I had to make sure to use GNU date or I had the same error.

Linux, but this error came from the CI.

Ahh this does look like a different error than I saw locally but now I'm curious, I'll look into it a bit later today.


v0.0.30

Updated dependencies

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (533b4b2) 100.00% compared to head (c19eb73) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           18        18
  Lines         1073      1073
=========================================
  Hits          1073      1073

Flag
Coverage Δ

unittests
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add partition in morphtree

Current coverage is 100.00%

Merging #143 into master will not affect coverage as of e42bdee

@@            master    #143   diff @@
======================================
  Files           30      30
  Stmts         1032    1034     +2
  Branches         0       0
  Methods
======================================
+ Hit           1032    1034     +2
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of e42bdee

Powered by Codecov. Updated on successful CI builds.

Which lines are you referring to? Could you add an inline comment in the right place?


Alamofire.download destination parameter issue

Alamofire.download("url","headers").responseData
not work if i don't define the "to: destination" and give me exception:
"Response could not be serialised, input file could not be read: file url in temp location"
and if i use the "destination" with this options
let destination: DownloadRequest.DownloadFileDestination = { _, _ in
    let documentsURL:URL = FileManager.default.urls(for: .documentDirectory, in: .userDomainMask)[0]
    let fileURL:URL = documentsURL.appendingPathComponent("peer.pdf")

    return (fileURL, [.removePreviousFile, .createIntermediateDirectories])
}

You need to define destination on all platforms except macOS. Otherwise you won't be able to access the file's data since it is outside of your sandbox. Moving it into the Documents directory before you use it should work fine.
Cheers. 🍻


Any Example Job?

Is there any scientific software and example scripts pre-installed on AMI that can be used to run and test some example cluster jobs?

No, unfortunately there's no scientific apps pre-installed.
I highly recommend you look at https://spack.io/ (hpc package manager) and for a general getting started guide there's https://cfncluster.readthedocs.io/en/latest/hello_world.html
Here's an example with Lammps (http://lammps.sandia.gov/):
# install lammps
module load mpi/openmpi-x86_64
cd /shared
git clone https://github.com/lammps/lammps
cd lammps/src
make mpi

# run it
mpirun -np 8 ./lmp_mpi -in ../bench/in.lj

(See https://github.com/lammps/lammps/blob/master/bench/README for info on lammps benchmarks)
Now create a file ~/lammps.sh with the following:
#!/bin/bash
#$ -pe mpi 8
#$ -cwd

module load module load mpi/openmpi-x86_64
mpirun -np 8 /shared/lammps/src/lmp_mpi -in /shared/lammps/bench/in.lj

And run it:
qsub lammps.sh
sleep 2
qstat

That example builds lammps with mpi support, runs it across 8 cores and finally shows you how to schedule it with sge. The output is contained in lammps.sh.o*.

Wanted to clarify, I'm installing from source in this example, however I recommend you install spack as it makes it really easy to install and manage applications.

Thanks @sean-smith !


replace individual endpoint_cnt read from store with 1 bulk read

getNetworksFromStore reads networks and endpoint_cnt from the kvstores.
endpoint_cnt especially is read in a for-loop for each network and that
causes a lot of stress in poorly performing KV-Stores.
This fix eases the load on the kvstore by fetching all the endpoint_cnt
in a single read and the operation is performed on it.
Signed-off-by: Madhu Venugopal<EMAIL_ADDRESS>

LGTM


upgrade GH Action

Upgrade version of Paths Changes Filter helper GH Action

previous version uses deprecated version of Node (16)
v3 uses Node 20
not urgent

Thanks, meant to get to this

Thanks, meant to get to this
No Problem!


Cannot login, redirects to <IP_ADDRESS>:58658 but is not available

When I try to login from Rider, it opens the webbrowser and tries to redirect to <IP_ADDRESS>:58658 but it fails (browser unable to connect to that URL).
Rider: 2024.2.4
Codeium: 1.14.14
Firefox: 130.0

Same issue with IntelliJ with Codeium 1.16.18.

I have the same problem with WebStorm 2024.2.3 and Codeium 1.20.4

After reading this comment, I tried the same solution, and worked perfectly fine
In Windows, you need to remove the folder of codeium is Located in C:\Users<user>.codeium
for Linux refer to the issue comment https://github.com/Exafunction/CodeiumJetBrains/issues/34#issuecomment-2297503214


please update your document

[Hi Team Documentation Microsoft Azure, please update your pricing skenario in this pages because not sync in this FAQ https://azure.microsoft.com/en-us/pricing/details/service-bus/ , example : Sample pricing 1—If you have a single listener, such as an instance of the hybrid connections manager installed and continuously running for the entire month, and you send 3 GB of data across the connection during the course of the month, your total charge will be $9.782.]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3be4abe7-1565-49e9-35e4-531bc14abc60
Version Independent ID: 877f67c8-87b4-139e-2fd6-e4137b711c0d
Content: Azure Relay FAQs
Content Source: articles/azure-relay/relay-faq.yml
Service: service-bus-relay
GitHub Login: @v-hearya

@prabowoekky Thanks for your feedback. We will review and update as appropriate.
@v-hearya please review.

We should have pricing information only on the Pricing page. I will remove it from FAQ after discussing with the Program Manager for the service.

Removed the pricing details from the FAQ. PM will add the information to the Pricing page after updating the content.
#please-close


Added Tombstones

.retain() now returns an iterator with the removed items
closes bluss/ordermap#11
Also cleaned up some match statements.

Thanks, that's interesting. It seems like a direct translation of the retain method into an iterator.
You're kind of putting me on the spot here, I have to review the design of the retain iterator and if I do it with my usual critical eye, there are some imperfections here:

OrderMap gets an iterator that does not use the regular order of the elements
Run on Drop is a questionable design pattern in itself. (Open question: Why should we use this pattern if we are making a new API?)

forget problematics show how nonintuitive it can be to tie behaviour to a temporary value
the operation is lazy as an iterator but eager on drop.

I believe this crate can implement an in-order "retain" iterator with the same algorithmic complexity

Well, that was why I said it seemed simple 😝 .
The only alternative I can think of to Run on Drop is how thread::scoped solved its issues. I'm certainly open to:
pub fn retain<F, G, R>(&mut self, keep: F, retain: G) -> R
    where F: FnMut(&mut K, &mut V) -> bool,
    G: FnOnce(Retain<K, V, S, F>) -> R

Which would complete the operation before returning.  I suspect forget would prevent, or at least significantly slow in-order traversal. So this would avoid that, and still allow users to do simple loops or .collect() it for storage.

There's also the alternative of designing the operation to be entirely lazy, i.e. don't have any implicit action on drop, don't remove more elements than the iterator is driven into doing.

That's somewhat unintuitive for users who don't want to iterate (i.e. people who would like to use the current function):
m.retain(|k, _| k < 5); // does nothing
m.retain(|k, _| k < 5).count(); // actually works

Some ideas, just in that case:

Rename the method so that expectations change (can't keep the "retain" name since the expectations from existing APIs is wrong).
use #[must_use] so that it makes a warning when it does nothing (just like iterator adaptors like .map())
add an explicit method for draining the iterator / running it til the end.

I think I'm now thoroughly convinced you cannot have all of these:

O(n)
A forgettable return value (no Drop or scoped style impl).
No change to iteration order.

There maybe some exceedingly clever way of accomplishing this, but if so, I'm not seeing it.

hehe, don't let me torture you for ordermap's purposes!

But if you had to pick two...

Rename the method so that expectations change (can't keep the "retain" name since the expectations from existing APIs is wrong).

Name idea filter_cursor

Well, this no longer adds a Retain iterator, but it does add tombstones, which will make implementing filter_cursor trivially easy.

Hah, crazy but interesting. Implementing tombstones is a big step. I'll have to look at this carefully. What are the benchmarks like?

I've only changed Entry and retain to use tombstones, swap_remove and any benches which test that are unaffected. Overall, very little change.

Found some bugs and fixed them. Also added some unsafe options under test feature flags.  They don't really seem to provide any perf benefit, so I'll probably end up scrapping them.
The CI break seems to be from an SSL error for crates.io trying to pull the tagged union packaged I added as a dependency. Not sure what's up with that but with how things are looking I'll probably end up removing the dependency.

So, found a couple more bugs, but while I'm already touching so much of the code, how would you feel about the following changes:

Remove self.mask in favor of getting the mask via indices.len() - 1
Removing probe_loop! in favor of loop and probe = (probe + 1) & mask

My justification for the former is, it seems like a bad idea to have duplicate data that could get out of sync. The mask is already implicitly stored in indices and is cheap to recover.
My justification for the later is it reads better than the macro (especially when debugging as line numbers get collapsed to the first line of the macro) and seems to have very little perf cost.

I'm sorry I haven't sat down and looked at this yet. I would hold off on both of those changes.

No problem, I've had to do quite a bit of cleanup before this PR would actually be usable. I've removed all my unsafe testing (it ultimately worked out to a maybe a 5% gain) and switched everything over to tombstones which can benefit from them.

I'm sorry that I haven't been able to review this. I think tombstones are going to be useful, and maybe we should bench it against linked hash map instead for a more apples to apples comparison. Unsure if we should fork the crate for this, I almost think so if we can't bring the overhead down. Improving retain just to have lookup and insert regress really is throwing the baby out with the bath water for a general purpose hash table.

Ok, I'm clearly not fit to help this PR as a maintainer. I would recommend forking the crate and giving the map a different name, because with tombstones you get a different hash table with other nice properties, while removing some of the nice properties of this OrderMap. (Performance and compactly indexed set).

@Popog Hey! What do you think about publishing ordermap with full insertion order (using tombstones) as a separate crate?

Got a good idea for a name? (I'm the worst at naming things)

A. What if current ordermap is renamed to donate its name?
Current ordermap is characterized by (1) consistent hash-independent order (2) compactly indexable map, so what's a good name for it?? Now we have the same problem... maybe "CompactMap"?
B. ordermap stays and the new type with matching crate is "InsertionOrderMap"?

compactmap is taken: https://crates.io/crates/compactmap

I think this PR would be simpler if it didn't use index tombstones, only entry tombstones. We don't need to keep any index order

Yeah, the index tombstones was just an attempt to amoratize other operations. I should have time this weekend to go back a couple commits to just entry tombstones and clean that up.
What about instead of a new crate, just adding it as a another type to this crate?

I'd prefer to split the crates if we are not at the point where implementation can be shared. I think all the core probe loops etc will look different, so there will not be so much actual overlap?
There's also the reason that if it's in this crate I'd feel responsible for it, and I don't have time to be responsible for another one unfortunately.

I believe this PR is obsolete since renaming to indexmap.
I think it's been long enough that we could donate / give up the ordermap name now, if that's still desired. Let us know if you want it.


Trivial commit to test stage

Pull Request Test Coverage Report for Build 706

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.485%

Totals

Change from base Build 703:
0.0%

Covered Lines:
1352

Relevant Lines:
2110

💛  - Coveralls

:tada: This PR is included in version 1.0.0 :tada:
Your semantic-release bot :package::rocket:


Adds allow_origins config value to websocket cors

I have a Chainlit-based app set up with the following AWS setup:

S3 static website using custom frontend
load balancer
ec2 instance(s) running docker container with the app

The S3 -> load balancer XML/HTTP requests work, using HTTPS, but the Websocket requests are failing because of CORS issues.
I'm looking to solve this for myself, and hopefully I can provide a simple and useful solution for the project as a whole.

So, I just realized that this was just modified here: https://github.com/Chainlit/chainlit/pull/681/files
Why are you removing support for custom backends?

Closing this, I've dug way further into SocketIO / Starlette than I wanted to, I may re-open later with some more clarity


[BUG] It's not clear how to call an advantage module with batched envs and pixel observations.

Describe the bug
When you get a tensordict rollout of shape (N_envs, N_steps, C, H, W) out of a collector and you want to apply an advantage module that starts with conv2d layers:

directly applying the module will crash with the conv2d layer complaining about the input size e.g. RuntimeError: Expected 3D (unbatched) or 4D (batched) input to conv2d, but got input of size: [2, 128, 4, 84, 84]
flattening the tensordict first with rollout.reshape(-1) so that it has shape [B, C, H, W] and then calling the  advantage module will run but issue the warning torchrl/objectives/value/advantages.py:99: UserWarning: Got a tensordict without a time-marked dimension, assuming time is along the last dimension. leaving you unsure of wether the advantages were computed correctly.

So it's not clear how one should proceed.

[x] I have checked that there is no similar issue in the repo (required)
[x] I have read the documentation (required)
[x] I have provided a minimal working example to reproduce the bug (required)

Good point there
Regarding reshaping: you should reshape and refine_names, I believe the last dim will still be time-compliant (but you need to make sure you have truncated signals at the end of each time step)
Other than that, we could consider falling back on vmap / first-class-dimensions whenever this situation is encountered. I will give it a look and ping you once it's on its way, as usual.

@vmoens in some cases the env data may have an arbitrary batch size (*B) before the time dimension.
Is the current approach, before we land smth like https://github.com/pytorch-labs/tensordict/pull/525, to try to flatten all these dims into one making sure to add terminations when doing so?

I don't think so, as I said in my answer the proper approach should be to vmap over the leading dims up to the time dim. Wdyt?

Actually, the error might be coming from my implementation of the model. In the PPO example, the advantage module is called on the rollout batch shape (https://github.com/pytorch/rl/blob/147de71d090d5705182bfabd24a99f3b2ee4cec9/examples/ppo/ppo.py#L103) and doesn't crash with the conv2d complaining.
I also managed to reproduce this with the ConvNet and MLP modules of PyTorch RL and my advantage module now runs without reshaping.
I'm sending more details to compare the settings.

Okay, so the ConvNet of TorchRL actually flattens the batch before running a forward and then unflattens it back.
https://github.com/pytorch/rl/blob/147de71d090d5705182bfabd24a99f3b2ee4cec9/torchrl/modules/models/models.py#L479
Maybe this could be made clearer to the user so that when designing custom models they know that they have to do something similar.
Otherwise, vmaping would be the way to go. I'm just concerned about memory requirements compared to flattening the tensordict.

Otherwise, vmaping would be the way to go. I'm just concerned about memory requirements compared to flattening the tensordict.

@skandermoalla Looking back at this comment, I wonder why vmap should have higher mem requirements?

I'm not very familiar with vmap, but does the memory taken by the model weights stay the same when you vmap it?


Change BG Images / Update to 1.2, help needed

hello there! first of all, thank you very much for such a great proyect and hard work.
Im building pibooth for my daughter's birthday party and this your project has something that many others has not.. a huge amount of time putting together clear instructions on how to get it to work :-)
I do have pibooth already working but strugle to change bg images, overlays, etc; how can I change bg images? how do I set an overlay?
thank you very much in advance

You can check your pibooth version by typing the command pibooth --version on a terminal.
If you have installed pibooth through pip you can simply upgrade via the command
pip install --upgrade pibooth
Once you are up to date, you need to open the config file to do your changes:

the background image is in the WINDOW/background field, just put the path to the image you wan to use.
for the overlay it is on PICTURE/overlays, and it accepts a list of overlays if you want a different one for the 1 picture and 4 pictures.

Tell us if it solve your questions, or if you need more help.

hello mate!
sorry for the late reply; sure you solved my question, thank you very much for that.
I have a last one.. are the png (choose a picture, choose layout, processing.. etc) also customizable? I have been able to find the gimp files but as far as I don't use Gimp, don't know if it si so simple as replace the existing ones by new ones.
than you in advance!

As I explained in another issue, since version 1.2.0 there is no longer dedicated image for each step but only overlays (such as arrow.png, processing.png, layout2.png...). These overlays are considered as a white drawing on a transparent background (to be put over the background and colorized according to the text color).
You can change any of these overlays to one of your choosing if you want, just keep in mind that they are considered as white drawing on transparent background by pibooth

thank you sir!


Select all function

Is your feature request related to a problem? Please describe.
When sending multiple pictures, it is inconvenient to check them one by one
Describe the solution you'd like
Want to add a select all option, or swipe selection function
Describe alternatives you've considered
No response
Additional context
No response

Specially in iOS

This feature would be very useful for transferring all the photos from an iPhone, for example.

Using the native media picker is the goal but there are some issues regarding the file name.
Closing this in favor of #376

Using the native media picker is the goal but there are some issues regarding the file name.
Closing this in favor of #376

Oh, because the native media picker doesn't allow you to select all files


fix a bug in ipv4_address::is_private_network() and avoid a compiler warning

As per the definition of IPv4 private network, m_bytes[1] & 0xC0 should be m_bytes[1] & 0xF0

Thanks for the fix!


camera resolution

the camera resolution defaults to the screen resolution if it is not set in the code. This means that that the image size (normal + crop) and pixel size will change w/ the screen size. there are a few problems i see:

it seems like the 512 x 512 crop from the camera actually includes strips of black the top and bottom because the screen resolution is likely not 512 in teh vertical...
The pixel size does also not seem to be fixed, so resolution changes result in pixel size changes.
The point of taking a center crop is to make sure no lens distortion occurs. but if the crop size is close to the full image size, the crop actually does pick up lens distortion... so we need to pick an image size that is large enough where the crop does not see lens distortion.

i think a more rational approach would be to set the camera resolution to a specific size that is larger than the crop size. Unfortunately this means that we need to take a pic of a known sample to get the pyDGS stats, but this can be done when the camera is shipped back...

this also means the max field of view for the workable area is ~32mm X ~32mm .. so pics of things above fine gravel is pushing it...


Breakpoint Alarm / Sound

While debugging:
In Visual Studio it is possible to trigger an alarm sound, whenever a breakpoint is hit. This is extremely useful when having a long running code and after maybe hours a breakpoint is being hit. Tutorial on how to activate
We definitely need that feature in VS Code!

I'll work on that. Could you please assign me?

@dev-manuel done
/cc @isidorn

This is a fair request, but as a pre-request it has the ability for VS Code to play sounds. This is captured in this issue https://github.com/microsoft/vscode/issues/130565
After we have that we plan to add a sound when a user navigates to a line that has a breakpoint.
However we can also add a different sound when a breakpoint gets hit.
So I suggest to follow that issue for details, and once we have that we can continue on this one.
fyi @hediet

@isidorn @deepak1556 should we have vscode issue labelled electron to track enabling sounds and all related issues? I believe it doesn't work on some environments due to how Electron is packaged. This is the terminal issue tracking the audible bell https://github.com/microsoft/vscode/issues/47711

Even though this issue is too specific, it captures our first steps into making sounds by vscode https://github.com/microsoft/vscode/issues/130565
So I suggest to not create any new issue and depending on how that issue goes we can adopt sounds in other parts of VS Code.
fyi @hediet

We are introducing sounds to VS Code. And we have already done so when a user navigates to a line with a breakpoint as part of our audioCue for breakpoints. More details here https://github.com/microsoft/vscode/issues/90842#issuecomment-1007553602
We are also thinking of adding a sound when a breakpoint is hit.
What I am not sure if the sound of a breakpoint hit should be different from a sound of when you navigate across a breakpoint. I think not. I think it should be the same sound, and the user can figure out the context based on if he or she is using keyboard to navigate or not.
We currently have a audioCues setting that can be "on" | "off" | "auto". I think we need another setting which would be "breakpointHit" or "importantOnly". The point is that I think a lot of users would want sounds when a brekpoint is hit, but not other sounds which are aimed more for our screen reader audance.
@hediet what do you think?
Sound design by @gino-scarpino

Implemented in 7057aac64f031956a2b57ca328d21924a9b192de.
You can set audioCues.debuggerStoppedOnBreakpoint to on, off or auto. Default is auto.

I tried it out and works as expected -> adding verified label.
Users try this out by setting "audioCues.debuggerStoppedOnBreakpoint": "on" in your settings.
Feedback is very much welcome. Thank you!

I also like audioCues.onDebugBreak, although it's not a big deal if you don't want to change the setting at this point.
A similar phrase is used in these settings

@hediet I think it is not too late to change. What do you think? Can we change to audioCues.onDebugBreak?

Fixed in 643cf95e.


Bind to interface/IP, whitelist

Hi, it is possible to add such thing as bind to interface/IP and IP whitelist? Also will be nice to bind on multiple ifaces/IPs/ports
Thanks!

Also will be nice to bind on multiple ifaces/IPs/ports

Right now it binds to INADDR_ANY / in6addr_any, and it's hard-coded that
way, but it should probably be a configuration option.

I'd like to have that possibility as well. I want to put endlessh on my ppp0 device while still having my sshd listenening to my eth0 device.

ah, yes, I have my wireguard interfaces on 22 and outside on a different port.
In keeping with the openssh-ish config, we could have:
Port 22
ListenAddress <IP_ADDRESS>
ListenAddress <IP_ADDRESS>:2222
ListenAddress <IP_ADDRESS>:22222

ah, yes, I have my wireguard interfaces on 22 and outside on a different port.
In keeping with the openssh-ish config, we could have:
Port 22
ListenAddress <IP_ADDRESS>
ListenAddress <IP_ADDRESS>:2222
ListenAddress <IP_ADDRESS>:22222

ah, nevermind, #40 solves this for me and I puppetized it without templatizing the config file.  Works well.

Looking for a whitelist option as well for vuln scanners and such


How to add a custom prefix?

Hi,
Its a great work that I have been searching for long time.  A feature request here: so, Is it possible to add a custom prefix? It is still taking 20chars even if I changed the domain size to public.xid AS CHAR(25) .  And then I should be able to default to a custom prefix for a table.  Any help is appreciated.

Not sure of the use case / what you want to accomplish here. Changing the domain size and adding a prefix will break the support functions along with adding blankspaces at the end for xid:s without a 5 char prefix.
My suggestion would be to just treat it as text or add you own domain along with wrapper function if it is just one prefix you need?
eg
CREATE OR REPLACE FUNCTION prefixed_xid(prefix TEXT, _at TIMESTAMPTZ DEFAULT CURRENT_TIMESTAMP)
    RETURNS TEXT
    LANGUAGE plpgsql
AS
  RETURN prefix || xid(_at)::TEXT
END;
$$;

Adding a domain should be fairly straight forward.
DO $$ BEGIN
    CREATE DOMAIN public.prefiexed_xid AS TEXT CHECK (VALUE ~ '[a-v0-9]{20}$');
EXCEPTION
    WHEN duplicate_object THEN null;
END $$;

then all other functions can be wrapped to remove or add the prefix.

Hi Rasmus,  Perfect! thanks for the snippet and it just works awesome.  But one small issue I ran into, I would have to call it like: SELECT prefixed_xid('test-', CURRENT_TIMESTAMP);  otherwise if I ignore the 2nd parameter then I get only 'test-'.  I do not know why it is like that.
BTW,  we would need to have a prefix for every table pkey which is the requirement is the reason.  I know its more characters but we have to choose it that way to differentiate the key generation per entity.

Thanks for this library and this prefix solution, @crholm. It's a nice way to get Stripe-style IDs. Here's some background on the motivation for prefixes.
I ran into the same issue that @senipsrox did where omitting current_timestamp from prefixed_xid returned just the prefix.
I spent a bit of time debugging and had that "I'm going crazy feeling" for a while, so I'm writing this up in case it helps future internet citizens. I don't expect any action from anyone on this.
Here's what I think is happening:

The domain prefixed_xid and the function prefixed_xid are interacting, the domain is shadowing the function when there's only one argument.
When calling prefixed_xid('test_') Postgres is calling the domain instead of the function, so you get back the same value but the type is now the domain type.
When you add the second argument, current_timestamp, the signature no longer matches the domain, so Postgres has to call the function.
This doesn't happen in the library xid function/domain because neither xid() or xid(current_timestamp) match a call to the domain that takes a text.

Postgres matches functions on name and signature (you can have two different Postgres functions with the same name and different parameters / types). It's bitten me before. Apparently this applies to domains and functions too.
Here's a recreation taking the xid and timestamp stuff out for clarity:
create domain foobar as text;

create or replace function foobar(arg_a text, arg_b int default 1)
    returns text
    language plpgsql
as
$$
declare
begin
    return 'this is the function output';
end
$$;

pg=> select foobar('hello');
 foobar
--------
 hello
(1 row)

pg=> select pg_typeof(foobar('hello'));
 pg_typeof
-----------
 foobar
(1 row)

pg=> select foobar('hello', 2);
           foobar
-----------------------------
 this is the function output
(1 row)

pg=> select pg_typeof(foobar('hello', 2));
 pg_typeof
-----------
 text
(1 row)

The solution is to give the domain and the function different names.
The only remaining mystery is why this doesn't happen for @crholm. My only guess is different behavior between PG versions.
My tests done with:
select version();
                                                          version
---------------------------------------------------------------------------------------------------------------------------
 PostgreSQL 15.8 (Debian 15.8-1.pgdg120+1) on aarch64-unknown-linux-gnu, compiled by gcc (Debian 12.2.0-14) 12.2.0, 64-bit
(1 row)

Also for the internet, here's my implementation:

create domain public.prefixed_xid as text check (value ~ '^[a-z]{1,5}_[a-v0-9]{20}$');

create or replace function public.gen_prefixed_xid(prefix text, _at timestamptz default current_timestamp)
    returns public.prefixed_xid
    language plpgsql
as
$$
declare
begin
    return prefix || '_' || xid(_at)::text;
end
$$;

create or replace function public.prefixed_xid_time(_prefixed_xid public.prefixed_xid)
    returns timestamptz
    language plpgsql
as
$$
declare
    _id public.xid;
begin
    _id := split_part(_prefixed_xid, '_', 2);
    return public.xid_time(_id);
end
$$;

create or replace function public.prefixed_xid_decode(_prefixed_xid public.prefixed_xid)
    returns int[]
    language plpgsql
as
$$
declare
    _id public.xid;
begin
    _id := split_part(_prefixed_xid, '_', 2);
    return public.xid_decode(_id);
end
$$;

create or replace function public.prefixed_xid_pid(_prefixed_xid public.prefixed_xid)
    returns int
    language plpgsql
as
$$
declare
    _id public.xid;
begin
    _id := split_part(_prefixed_xid, '_', 2);
    return public.xid_pid(_id);
end
$$;

create or replace function public.prefixed_xid_counter(_prefixed_xid public.prefixed_xid)
    returns int
    language plpgsql
as
$$
declare
    _id public.xid;
begin
    _id := split_part(_prefixed_xid, '_', 2);
    return public.xid_counter(_id);
end
$$;

create or replace function public.prefixed_xid_machine(_prefixed_xid public.prefixed_xid)
    returns int[]
    language plpgsql
as
$$
declare
    _id public.xid;
begin
    _id := split_part(_prefixed_xid, '_', 2);
    return public.xid_machine(_id);
end
$$;

kaavio=> select x,
kaavio->        prefixed_xid_decode(x),
kaavio->        prefixed_xid_time(x),
kaavio->        prefixed_xid_pid(x),
kaavio->        prefixed_xid_counter(x),
kaavio->        prefixed_xid_machine(x)
kaavio-> from (select gen_prefixed_xid('inv') x) t;
            x             |             prefixed_xid_decode             |   prefixed_xid_time    | prefixed_xid_pid | prefixed_xid_counter | prefixed_xid_machine
--------------------------+---------------------------------------------+------------------------+------------------+----------------------+----------------------
 inv_ct2n1r0sg0j04nupflqg | {103,69,112,236,28,128,38,2,95,217,125,117} | 2024-11-26 06:55:40+00 |              607 |             14253429 | {28,128,38}
(1 row)

And I'll give that code an MIT license so you can safely copy/paste that at work.
The above code is licensed as follows:
MIT License

Copyright (c) 2024 Samuel Bobb

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

 IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

TIL,
I think i might not have created a domain in my example, if i remember correctly.
The blog post makes a good case for including prefixing functionality. It might be worth looking into a templated version or maybe include supporting functions

Glad the background on prefixes is helpful.
Interesting explanation. It would make sense that you’d skip making the domain in your example. It’s unintuitive that they interact. I thought I’d lost it last night 😆
I’m happy to make a PR with those functions if you want to add them. I also don’t mind you adding them yourself.
I also think it’s reasonable to keep the library small and show people how to extend it. Maybe just add some info to the Readme?

hm.. Referencing this thread in the readme is probably a better way to go about it at the moment.
It seems that the prefixing could be handled with named and default parameters, as long as the issue with the domain i dealt with. Dealing with the function calls should be trivial, more of an issue to have the domain work as intended... eg  select xid(_prefix => 'sk_')

Oh yeah, that's a good idea. You're saying one set of functions and one domain.
You could have a domain that matches both the prefixed and non-prefixed version, like:
create domain public.xid as text check (value ~ '^([a-z]+_)?[a-v0-9]{20}$');


Update Express.js example in examples/solutions

Description

Add body-parser package to fix an error in original example.
Update README

git clone https://github.com/vercel/examples/tree/main/solutions/express doesn't work, so change this to pnpm create next-app --example https://github.com/vercel/examples/tree/main/solutions/express express
Change vercel dev to vercel for deploying the app.

Demo URL

https://express-example-yumin.vercel.app/
Type of Change

[ ] New Example
[x] Example updates (Bug fixes, new features, etc.)
[ ] Other (changes to the codebase, but not to examples)

New Example Checklist

[ ] 🛫 npm run new-example was used to create the example
[ ] 📚 The template wasn't used but I carefuly read the Adding a new example steps and implemented them in the example
[ ] 📱 Is it responsive? Are mobile and tablets considered?

@leerob Could you kindly take a look at this PR?


Add releaseNotes links to watchOS 9.x

Need these to update the wiki.

Also could someone add securityNotes for me? >.>


sides parameter on ttest

Add the sides option on the proc_ttest() function.  Controls how the h0 option is interpreted.  Value are U, L or 2.

Probably won't do this now.


fix import pmx Texture missing on MacOS or Other OS.

some Texture path include '' ,but MacOS didn't recognize it ,need replace by 'os.path.sep'
Tested on my Mac.
focus on line 137.
Other lines auto delete blank by my IDE。

Sadly it seems sugiany has abandoned the project... Well, I'm not going to maintain it actively. But I've fixed a few bugs.

FYI @powroupi is active and we collaborated on fixing paths for non-windows OS-es: https://github.com/powroupi/blender_mmd_tools/commit/d9b895f83bc9c6377b298ddcb3a17653708fe740
Things work fine on my Mac.

@ptrthomas I'm very glad to hear that, I took a look at some commits and you have made a great work.
Probably what I fixed in lordscales91@b90431df1e66a349039b26f96283505e3176033e you had already fixed it a long time ago. I will open an issue here to let the people know this project has been discontinued by sugiany and is being active developed by @powroupi


delete ipmagplotlib?

Now that the backend issue is resolved by @moonshoes87 (I think?), should ipmagplotlib be deleted from the repository so that we are solely using pmagplotlib?

I think that would be great.  and it would also be nice if we could move back to a unified pmag.py module as well - is that a possibility?
lisa

On Jan 26, 2016, at 5:29 PM, Nick Swanson-Hysell<EMAIL_ADDRESS>wrote:
Now that the backend issue is resolved by @moonshoes87 https://github.com/moonshoes87 (I think?), should ipmagplotlib be deleted from the repository so that we are solely using pmagplotlib?
—
Reply to this email directly or view it on GitHub https://github.com/PmagPy/PmagPy/issues/40.

When Lori and I were discussing ways to reorganize the directory structure, I brought up this pmag.py and ipmag.py merge possibility. Lori's perspective (which she convinced me of at the time) is that it makes sense to keep them separate with pmag.py containing the functions that mostly do a single thing and ipmag.py containing functions that bring pmag.py functions together to do more of a work flow (e.g. do a bootstrap reversal test and have options to save the associated output). In this way, the ipmag.py functions are similar to the command line programs that are built on top of pmag.py functions, but are built to be used without sys.argv calls, etc. The current split between the modules isn't entirely consistent with this design conception, but it largely is. Worth talking about more moving forward...
@moonshoes87 are we good to delete ipmagplotlib?

Yes, let’s delete it.  Thanks!

On Jan 27, 2016, at 8:27 AM, Nick Swanson-Hysell<EMAIL_ADDRESS>wrote:
When Lori and I were discussing ways to reorganize the directory structure, I brought up this pmag.py and ipmag.py merge possibility. Lori's perspective (which she convinced me of at the time) is that it makes sense to keep them separate with pmag.py containing the functions that mostly do a single thing and ipmag.py containing functions that bring pmag.py functions together to do more of a work flow (e.g. do a bootstrap reversal test and have options to save the associated output). In this way, the ipmag.py functions are similar to the command line programs that are built on top of pmag.py functions, but are built to be used without sys.argv calls, etc. The current split between the modules isn't entirely consistent with this design conception, but it largely is. Worth talking about more moving forward...
@moonshoes87 https://github.com/moonshoes87 are we good to delete ipmagplotlib?
—
Reply to this email directly or view it on GitHub https://github.com/PmagPy/PmagPy/issues/40#issuecomment-175725587.

I deleted it and I think I have removed the import statements to the module and changed back to pmagplotlib where necessary although some still could be lurking.


Better reporting of errors in config.yaml

Hi,
I've just found that any error in config.yaml (missing empty line on end of file, for example) is reported with following error message:
brunch:   Couldn't find config.yaml file
I think, that brunch should be a bit more verbose about problem :)

I'm not entirely sure, but I believe this is an issue of js-yaml ... I will investigate

Fixed.

Great, thanks :)


[BUG] Dataproc GKE user qualification tool fails because there is no cluster creation script template

Describe the bug
Dataproc GKE user qual tool fails with error:
2024-07-25 15:34:31,378 INFO rapids.tools.qualification: Generating GPU Estimated Speedup: as xxxxxx/spark-rapids-tools/user_tools/qual_20240725223353_A22DcBf7/qualification_summary.csv
2024-07-25 15:34:31,384 ERROR root: Qualification. Raised an error in phase [Collecting-Results]
Traceback (most recent call last):
  File "xxxxxx/spark-rapids-tools/user_tools/src/spark_rapids_pytools/rapids/rapids_tool.py", line 114, in wrapper
    func_cb(self, *args, **kwargs)  # pylint: disable=not-callable
  File "xxxxxx/spark-rapids-tools/user_tools/src/spark_rapids_pytools/rapids/rapids_tool.py", line 246, in _collect_result
    self._process_output()
  File "xxxxxx/spark-rapids-tools/user_tools/src/spark_rapids_pytools/rapids/qualification.py", line 1058, in _process_output
    summary_report = report_gen.generate_report(app_name=self.pretty_name(),
  File "xxxxxx/spark-rapids-tools/user_tools/src/spark_rapids_pytools/rapids/qualification.py", line 194, in generate_report
    csp_report = csp_report_provider()
  File "xxxxxx/spark-rapids-tools/user_tools/src/spark_rapids_pytools/rapids/rapids_tool.py", line 329, in _generate_platform_report_sections
    rep_lines.extend(self._generate_section_content(curr_sec))
  File "xxxxxx/spark-rapids-tools/user_tools/src/spark_rapids_pytools/rapids/rapids_tool.py", line 314, in _generate_section_content
    all_lines = self._generate_section_lines(sec_conf)
  File "xxxxxx/spark-rapids-tools/user_tools/src/spark_rapids_pytools/rapids/qualification.py", line 1073, in _generate_section_lines
    script_content = gpu_cluster.generate_create_script()
  File "xxxxxx/spark-rapids-tools/user_tools/src/spark_rapids_pytools/cloud_api/sp_types.py", line 1235, in generate_create_script
    return TemplateGenerator.render_template_file(template_path, render_args)
  File "xxxxxx/spark-rapids-tools/user_tools/src/spark_rapids_pytools/common/utilities.py", line 238, in render_template_file
    with open(fpath, 'r', encoding='UTF-8') as f:
FileNotFoundError: [Errno 2] No such file or directory: 'xxxxxx/spark-rapids-tools/user_tools/src/spark_rapids_pytools/resources/templates/dataproc_gke-create_gpu_cluster_script.ms'

Steps/Code to reproduce bug
spark_rapids qualification --verbose --eventlogs <my-event-logs> --platform dataproc-gke --cluster <my-gke-cluster>

Closing as the issue is not present after cost savings is disabled.


Typo in bigint.dart

The following snippet refers to d_cmp_ab which is not defined anywhere. d_cmp_b is defined above but unused, so that is probably what this was meant to be?
        if (d_neg == b_neg) {
          var d_cmp_b =
              _compareDigits(d_digits, abcd_used, b_digits, abcd_used);
          if (d_cmp_b > 0) {
            _absSub(d_digits, abcd_used, b_digits, abcd_used, d_digits);
          } else {
            _absSub(b_digits, abcd_used, d_digits, abcd_used, d_digits);
            d_neg = !d_neg && (d_cmp_ab != 0);
          }
        }

Yep, looks like a typo to me.
If this can wait a few days, I'll into it next week and understand why this remained hidden until now. I'm too busy batch interviewing in Shanghai right now.

No hurry from my side, better just take our time and get the fix tested as well.
For context: I'm playing with using your code as the bigint implementation for Fletch which is where I noticed this in passing. :-)

The code path with the typo is only used for modInverse (not for gcd), and only when the modulus is even, which never really happens in practice. It is quite painful to find a pair of input numbers that will trigger this path. But the fix is obvious.
Thanks for finding it.


Mount papermerge folder

I think many of those interested in this project already have some kind of digital document archive. In many cases simply folder structures with PDFs in it.
It would be great be able to mount (e.g. via WebDAV or something more modern) the folder structure of papermerge for desktop search and import of documents.

This feature requests overlaps with REST API - what I mean, is that you can import documents from virtually anywhere by writing you own little bash/python/any other language + REST API registered key.
Here is a documentation.
Here is REST API feature demo.
Basically importing a file can be as simple as:
curl -H "Authorization: Token <REST_API_KEY>"   -T /home/eugen/documents/demo/2019/berlin1.pdf   <PAPERMER HOST URL>/api/document/upload/

Thanks. Does the API also allow to upload to anything else than upload? The documentation is not clear on that.


Fix time displayed in Most Recent executions dropdown on tests

Currently everywhere else uses the local_time gem except for this dropdown, adding to the dropdown as well to standardize.

https://github.com/projectcypress/cypress/commit/bbacc1e0e373a62df3b6c663cc72ea10fdddbd50


Plugin is not installed on elasticsearch 7.5.2

Hello, we are currently using elasticsearch version 7.5.2, I have compiled a zip file from the 7.5.0 branch.
When trying to install this plugin, I get the error:
Exception in thread "main" java.lang.IllegalArgumentException: Plugin [elasticsearch-binary-vector-scoring] was built for Elasticsearch version 7.5.0 but version 7.5.2 is running
at org.elasticsearch.plugins.PluginsService.verifyCompatibility(PluginsService.java:346)
at org.elasticsearch.plugins.InstallPluginCommand.loadPluginInfo(InstallPluginCommand.java:728)
at org.elasticsearch.plugins.InstallPluginCommand.installPlugin(InstallPluginCommand.java:803)
at org.elasticsearch.plugins.InstallPluginCommand.install(InstallPluginCommand.java:786)
at org.elasticsearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:232)
at org.elasticsearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:217)
at org.elasticsearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:86)
at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:125)
at org.elasticsearch.cli.MultiCommand.execute(MultiCommand.java:77)
at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:125)
at org.elasticsearch.cli.Command.main(Command.java:90)
at org.elasticsearch.plugins.PluginCli.main(PluginCli.java:47)
Please tell me how to install this plugin on elasticsearch version 7.5.2?

just pushed a new branch for it called es-7.5.2
please use that


Derive macros as a library crate

I'm writing a derive macro for a trait that requires Deserialize, and writing implementations by hand is very tedious. It would be useful if Serde could provide a non-proc macro crate with the same functionality as the proc macro crate, so I can simply invoke all of Serde's derive logic from a proc macro.
It could be called serde_derive2 or something, and it would expose the implementation of the derive functions as functions that use proc_macro2 types (maybe it could also support different names for the serde attribute). Like what currently goes on with serde_derive_internals it can be a module of serde_derive as well as an external crate.
If this is a good idea I'm happy to make a PR for it.

I wouldn't recommend starting with a PR for this — it seems like something that could be developed as an external crate, either using code forked from serde_derive, or rewriting just the parts of the logic that you feel other macros are going to want to use.

If anyone happens to encounter this in future, there was never actually any need for this. Derive macros can just expand to the same item but deriving the Serde macro, using a second attribute macro to not duplicate the type.
// Initial code:
#[derive(YourDeriveMacro)]
struct S;

// After your derive macro runs:
struct S;
impl YourTrait for S { /* ... */ }

#[derive(Deserialize)]
#[::your_crate::black_hole]
struct S; // second instance of the type, with added derives, emitted by your macro

// After Serde's derive macro runs:
struct S;
impl YourTrait for S { /* ... */ }
#[::your_crate::black_hole]
struct S;
impl<'de> Deserialize<'de> for S { /* ... */ }

// After your `black_hole` attribute macro runs (and emits nothing):
struct S;
impl YourTrait for S { /* ... */ }
impl<'de> Deserializer<'de> for S { /* ... */ }

It's a neat trick. black_hole can be implemented like so:
/// Not public API, do not use.
#[doc(hidden)]
pub fn black_hole(_: TokenStream, _: TokenStream) -> TokenStream {
    TokenStream::new()
}

Note that unfortunately #[cfg(any())] cannot be used in place of the black_hole macro, because it would run before the derives even if it's placed after.


Inconsistent parsing of command line flags

caddy parses command line options inconsistently: in some cases both -option value and -option=value is accepted, but in others only the first is accepted.
Both forms accepted for -type:
$ caddy -type http -validate
Caddyfile is valid
$ caddy -type=http -validate
Caddyfile is valid

Only one for accepted for -http2:
$ caddy -http2 false -validate
2018/04/26 10:32:45 args:2 - Error during parsing: Unknown directive 'false'
$ caddy -http2=false -validate
Caddyfile is valid

The documentation does not suggest there would be any difference in the way these options are parsed:
  -http2
    	Use HTTP/2 (default true)
...
  -type string
    	Type of server to run (default "http")

It is not inconsistent, it is how Go parses command line. Booleans are different.
To set boolean you need = i.e. -http2=false.

Ah, I see. In that case, can the documentation be changed to make this clear? I suspect many users are not familiar with the details of go's command-line parsing behavior (or even that caddy is written in go).
Perhaps:
-http2=true|false

Yeah you're right end users may not know. Noted.


Cherry-pick "Prevent the bazel plugin from being used for non-Android C++ development in Android Studio."

original commit: https://github.com/bazelbuild/intellij/commit/28823de2b987213e3a5eba47c5a77345d83b4b22

I wanted to get @ujohnny review on this

@mai93 I'm still waiting for 1 more commit to arrive. https://github.com/bazelbuild/intellij/pull/6218#discussion_r1516446732

@mai93 I'm still waiting for 1 more commit to arrive. #6218 (comment)

this is included now


Update standard workflow files.

This PR was created automatically by the repo_checks.py script in the
https://github.com/openedx/terraform-github repository.

:tada: This PR is included in version 2.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[SerializableAttribute] still mentioned in the Exception doc despite the current obsoletion strategy

Describe the issue or suggestion
Context
https://learn.microsoft.com/en-us/dotnet/standard/exceptions/how-to-create-localized-exception-messages - mentions couple times marking the Exception with SerializableAttribute.
However based on the BinaryFormatter Obsoletion Strategy this should not be already done from net8 up (including multitargeted projects): https://github.com/dotnet/designs/blob/main/accepted/2020/better-obsoletion/binaryformatter-obsoletion.md#no-new-serializable-types-introduced-net-8
Goal
The documentation doesn't recommend decorating new custom Exceptions with SerializableAttribute
FYI @GrabYourPitchforks, @ladipro

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ed065e03-3620-cd2a-66b7-706ce2f863d9
Version Independent ID: fe5453a0-d849-a145-7260-036f769c208f
Content: How to create user-defined exceptions with localized exception messages - .NET
Content Source: docs/standard/exceptions/how-to-create-localized-exception-messages.md
Service: dotnet-fundamentals
GitHub Login: @Youssef1313
Microsoft Alias: gewarren

Associated WorkItem - 286586

Also see https://github.com/dotnet/dotnet-api-docs/issues/9980#issuecomment-2246263904.


Migrate IniFileConfigStore to @configu/integrations

Closes #516

@jamesL92 thanks for the quality review! Regarding #572, I suggest we handle it in a separate PR as it's not relevant to the migration of the config store, it should be handled after the migration is complete to keep the scope of this PR lean.

@RichardAkman  do i need to change anything in this ?

@i-sanjay-cs, all of the change requests that @jamesL92 made are relevant besides the one referred to in #572. Please apply them before we proceed with the review 🙏🏻

Hi @i-sanjay-cs, I noticed you've unassigned yourself from this PR, and there haven’t been any updates recently. Could you let me know if you plan to continue working on it? If not, I’ll close the PR to make the issue available for other contributors. Thank you!

Hey @RichardAkman I am little bit busy with the current work thats why I just unassigned so any other can work on this issue. So you can close it.


Remove unsafeCoerce for the hash.

Hash is already an instance of Show.

@jinwoo Thanks! I'm not sure why CI didn't start here. Do you mind if I cherry pick your commit into another branch?

@brandon-leapyear Not at all. Please go ahead!

Superceded by #16


[BUG] OSB supporting ZSTD and ZSTDNODICT Compression Codecs

Describe the bug
OSB, starting version 0.50, validates index.codec for valid compression codec values -- currently default and best_compression. But since version 2.7.0, OpenSearch also supports ZSTD and ZSTDNODICT compression codecs that OSB does not currently support.
 No errors should be thrown for ZSTD and ZSTDNODICT values for index.codec (and their lower-case equivalent: zstd and zstdnodict).
More Context (please complete the following information):

OpenSearch 2.7.0
OpenSearch Benchmark 0.5.0

Removing bug flag as this is an enhancement rather than a bug


[create_lmdb] bug fix: wrong image size order

It's easy to check and reproduce this bug by replacing the "get_image_size" with "identify" in the origin create_list.sh.

Thanks!


karma command not found

Summary
When following the guidelines for contributing, you may get an error about karma not being found if it's not installed.
Expected Behavior
Follow guidelines for contributing
Run bundle exec rake
Expect tests to pass
Current Behaviour
bundle exec rspec && karma start --single-run
.....

Finished in 0.04987 seconds (files took 2.34 seconds to load)
5 examples, 0 failures

sh: karma: command not found
rake aborted!
Command failed with status (127): [bundle exec rspec && karma start --single-...]
/Users/smitha103/workspace/bbc-a11y/Rakefile:7:in `block in <top (required)>'
/Users/smitha103/.rvm/gems/ruby-2.2.4/gems/rake-11.3.0/exe/rake:27:in `<top (required)>'
/Users/smitha103/.rvm/gems/ruby-2.2.4/bin/ruby_executable_hooks:15:in `eval'
/Users/smitha103/.rvm/gems/ruby-2.2.4/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => default => unit
(See full trace by running task with --trace)

Possible Solution
npm install -g karma
or update Rakefile to run
bundle exec rspec && node_modules/karma/bin/karma start --single-run
instead of
bundle exec rspec && karma start --single-run

I had the same issue and sudo npm install -g karma-cli worked for me

Thanks @andymsuk! Fixed in https://github.com/bbc/bbc-a11y/commit/642c5251b79ca93f6a525a134d1935ad324e1cdf

Incidentally I wouldn't recommend installing global modules, it just means we'all be running different versions of the test runner...


Use LinearAlgebra.AdjOrTrans

This symbol is not public so I can't rely on it.
help?> LinearAlgebra.AdjOrTrans
  No documentation found.

  Summary
  ≡≡≡≡≡≡≡

  LinearAlgebra.AdjOrTrans is of type UnionAll.

  Union Composed of Types
  ≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡

    •  Adjoint

    •  Transpose


Correction for Win10 Pro and M365B

Article incorrectly states Windows Enterprise is required for baseline protection.  This is also included in Windows 10 Pro and Windows 10 Business when used with Microsoft 365 Business.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0238a73f-da06-ae17-c61d-85ae54e0f7cb
Version Independent ID: e5bb4a25-a7c3-3a16-bd95-d6f2513402e0
Content: Windows Defender Credential Guard Requirements (Windows 10)
Content Source: windows/security/identity-protection/credential-guard/credential-guard-requirements.md
Product: w10
Technology: windows
GitHub Login: @DulceMontemayor
Microsoft Alias: dansimp

@officedocsbot assign @jvsam

Thank you again for pointing this out @davebirr, much appreciated. Similar to ASR rules (see #4993), Windows Defender Credential Guard is available on my Microsoft 365 Business subscription/Windows 10 Pro.

Hello @DulceMontemayor, if you are not busy, can you please confirm Credential Guards's availability on Windows 10 Pro with Microsoft 365 Business subscription? Thank you in advance.

Hello again @DulceMontemayor, I'd like to follow-up on this issue. Can you please confirm if Windows Defender Credential Guard is officially available on Microsoft 365 Business subscription + Windows 10 Pro? Thank you so much.

Hello again @DulceMontemayor, do you have any update on this? Can you please confirm if the information on this doc is accurate?  Thank you,

Maybe you could get this confirmed by the document manager (Daniel Simpson), in case he is more available than the original author?

Will follow-up via email and escalate @illfated, thanks.
@officedocsbot assign @DulceMontemayor

Hi @DulceMontemayor just a friendly follow-up. We'd appreciate if you could provide feedback on this issue so we can move forward. Thank you.

Hi again @DulceMontemayor, hoping you'll have time to review this and provide some insights. Thank you.
CC: @Dansimp, will you be able to assist? Thank you,

Hi @davebirr, we appreciate your patience on this matter. Since there is no update yet from the author related to your question, what I would recommend is to contact Windows 10 support instead if you have time. They'll be able to provide you a more definitive answer. Personally, I'd assume the answer may be similar to the answer to you other question (see #4993), it's not Windows Pro per se' but the subscription to Microsoft 365 (E5 specifically) that provides you access to the feature. I am sorry that we cannot provide you more information. If you do contact support, kindly keep us informed on the resolution or any relevant information that can be incorporated into this documentation. Our main goal here is to ensure users have the best Windows 10 experience by providing useful, accurate and up-to-date documentation.
Thank you so much!

Hi again @davebirr, hoping you were able to contact support since it's your best option to get immediate and definitive answer. There have been no further action or changes on the docs from the author, hence, it may be safe to assume that the content is still accurate (Please see my comment regarding E5 subscription). For now, we will close this issue. Again, please keep us informed (and you can reopen this issue) of any relevant information from other MS resources that can be incorporated into this documentation, e.g. confirmation about the baseline requirements, etc. Thank you.

@officedocsbot close


Preparing POST request hook

First, as countless have said, I'd like to thank all of the contributors for such an excellent package.
I am trying to maintain an auto-incrementing id for a given session and url every time I submit a post request. For example, say I have an authenticated session object.
Example
ID_KEY = 'id'
counter = 1
data = 'blah'
payload = {ID_KEY: counter, 'other_stuff': data}
resp = session.post(SPECIFIC_URL, json=payload)
counter += 1
payload = {ID_KEY: counter, 'other_stuff': data}
resp2 = session.post(SPECIFIC_URL, json=payload)

My easy solution is having an adapter class that wraps the session object with its own post method, but I was wondering if I could use either a prepared request or hook that would achieve the same effect more cleanly?

A Session wrapper or something similar is the best approach here. We got rid of most of our hooks, and you can't hook into the request factory easily.


[WebRTC] Static extension registration.

Move WebRTC extension registration from WebRTCPeerConnectionExtension to a static method of WebRTCPeerConnection.
This let the official WebRTC plugin register without having to instantiate itself.

Thanks!


Adding dummy-one

Depends on #9

new comment

now depends on #8

again

depends on #20

ping

depends on #20


limits of cuda hash failure

hi,
I am trining as per the documentation,
python train.py --cfg cfgs/kitti_models/pv_rcnn.yaml --batch_size 64
however running into the following issue. I tried various batch sizes, 256, 64, 512 and it hasn't helped. How do I fix this?
I have single GPU AWS instance, g3.4xlarge.
2020-10-17 02:08:43,880   INFO  Start training kitti_models/pv_rcnn(default)
epochs:   0%|                                                                            | 0/80 [04:03<?, ?it/s]
Traceback (most recent call last):                                                        | 0/8 [00:00<?, ?it/s]
File "train.py", line 198, in
main()
File "train.py", line 153, in main
train_model(
File "/projectdata/OpenPCDet/tools/train_utils/train_utils.py", line 86, in train_model
accumulated_iter = train_one_epoch(
File "/projectdata/OpenPCDet/tools/train_utils/train_utils.py", line 38, in train_one_epoch
loss, tb_dict, disp_dict = model_func(model, batch)
File "/projectdata/OpenPCDet/pcdet/models/init.py", line 30, in model_func
ret_dict, tb_dict, disp_dict = model(batch_dict)
File "/projectdata/anaconda3/envs/apple2/lib/python3.8/site-packages/torch/nn/modules/module.py", line 532, in call
result = self.forward(*input, **kwargs)
File "/projectdata/OpenPCDet/pcdet/models/detectors/pv_rcnn.py", line 11, in forward
batch_dict = cur_module(batch_dict)
File "/projectdata/anaconda3/envs/apple2/lib/python3.8/site-packages/torch/nn/modules/module.py", line 532, in call
result = self.forward(*input, **kwargs)
File "/projectdata/OpenPCDet/pcdet/models/backbones_3d/spconv_backbone.py", line 139, in forward
x = self.conv_input(input_sp_tensor)
File "/projectdata/anaconda3/envs/apple2/lib/python3.8/site-packages/torch/nn/modules/module.py", line 532, in call
result = self.forward(*input, **kwargs)
File "/projectdata/anaconda3/envs/apple2/lib/python3.8/site-packages/spconv/modules.py", line 134, in forward
input = module(input)
File "/projectdata/anaconda3/envs/apple2/lib/python3.8/site-packages/torch/nn/modules/module.py", line 532, in call
result = self.forward(*input, **kwargs)
File "/projectdata/anaconda3/envs/apple2/lib/python3.8/site-packages/spconv/conv.py", line 169, in forward
outids, indice_pairs, indice_pair_num = ops.get_indice_pairs(
File "/projectdata/anaconda3/envs/apple2/lib/python3.8/site-packages/spconv/ops.py", line 91, in get_indice_pairs
res = torch.ops.spconv.get_indice_pairs(indices, batch_size, out_shape,
RuntimeError: /projectdata/spconv/src/spconv/spconv_ops.cc 40
batchSize * outputVolume < std::numeric_limits::max() assert faild. due to limits of cuda hash, the volume of dense space include batch size must less than std::numeric_limits::max() = 2e9

hi,
If the BATCH_SIZE is 1, it works. It does not work for 2,4,32...
The training takes ages and GPU AWS instance, g3.4xlarge, cost $2.5/hr. Is there a work around for this?

Maybe this thread could be useful: https://github.com/open-mmlab/OpenPCDet/issues/299

@suvasis did you find the reason for this error? I'm struggling with the same thing. Maybe its got to do with the VRAM capacity not being enough for those batch sizes...


Fix psycopg2 warning by updating to psycopg2-binary

Description
As of the title, it was fixed warning of psycopg2.
According to the message that psycopg 2 is renamed to psycopg 2 - binary as the version is upgraded.
Wanring log
$ docker exec doccano tools/create-admin.sh "admin"<EMAIL_ADDRESS>"password"
/usr/local/lib/python3.6/site-packages/psycopg2/__init__.py:144: UserWarning: The psycopg2 wheel package will be renamed from release 2.8; in order to keep installing from binary
 please use "pip install psycopg2-binary" instead. For details see: <http://initd.org/psycopg/docs/install.html#binary-install-from-pypi>.
  """)
/usr/local/lib/python3.6/site-packages/psycopg2/__init__.py:144: UserWarning: The psycopg2 wheel package will be renamed from release 2.8; in order to keep installing from binary
 please use "pip install psycopg2-binary" instead. For details see: <http://initd.org/psycopg/docs/install.html#binary-install-from-pypi>.
  """)
Operations to perform:
  Apply all migrations: admin, auth, contenttypes, server, sessions, social_django
Running migrations:
  No migrations to apply.
Superuser created successfully.
/usr/local/lib/python3.6/site-packages/psycopg2/__init__.py:144: UserWarning: The psycopg2 wheel package will be renamed from release 2.8; in order to keep installing from binary
 please use "pip install psycopg2-binary" instead. For details see: <http://initd.org/psycopg/docs/install.html#binary-install-from-pypi>.
  """)

Normal(fixed) log
$ docker exec doccano tools/create-admin.sh "admin"<EMAIL_ADDRESS>"password"
Operations to perform:
  Apply all migrations: admin, auth, contenttypes, server, sessions, social_django
Running migrations:
  No migrations to apply.
Superuser created successfully.

Thanks!


Fix flaky testDisablingAllocationFiltering

Fix flakiness of the test as new shard allocation may not have happen yet.
Force re-allocation using the ES API by executing an empty reroute command.
(Same happen on the original commit)
Also the name of node_1 is not a constant name (could be node_t1 instead
of node_1), use resolved name instead.
This change does not exists at the original ES commit as it no real effect
currently anyhow because the current default of max_concurrent_recoveries
is not smaller than the used 2 shards.
See https://github.com/crate/crate/pull/10797/checks?check_run_id=1443820573#step:4:1376 for a failing scenario which should be fixed by this commit.

Do you think we should also remove the assertBusy from testAutoExpandReplicasToFilteredNodes and add the reroute call there too?

Good point, added a commit.

retest this please

The root cause is now solved by #10825, making this PR obsolete (also it was not tackling the root cause but just adding more workarounds).


Timeouts do not occur when stream == True.

As stated in the docs:

timeout is not a time limit on the entire response download; rather, an exception is raised if the server has not issued a response for timeout seconds (more precisely, if no bytes have been received on the underlying socket for timeout seconds).

With that said, it should still be possible to timeout when stream == True.
The following command times out as expected.
$ python3 -c "import requests; response = requests.request('GET', 'http://httpbin.org/delay/3', timeout=1); print(response)"

The following command does not timeout. A timeout is expected.
$ python3 -c "import requests; response = requests.request('GET', 'http://httpbin.org/delay/3', stream=True, timeout=1); print(response)"

I'm having the same problem still, though it may be user error. I need to combine stream=True with a timeout that reliably raises an exception if the internet is not available.
To test this I turn off my router and run this code:
`
import requests
from contextlib import closing
content = ''
try:
with closing(requests.post(url,
data=dataDict,
timeout=2.0,
stream=True)) as responseObject:
for chunk in responseObject.iter_content(chunk_size=32):
print chunk
content += chunk
except requests.HTTPError as e:
print 'Checking internet connection failed, status code {0}.'.format(e.response.status_code)
except requests.ConnectionError:
print 'No internet connection available.'
except requests.Timeout:
print 'Request timed out.'
`
However, more often than not, this just doesn't time out after 2 seconds but either never returns, or times out after a very long time (i.e. minutes).
Am I doing something wrong or is this buggy?

OK posting on an old issue but it still applies to master branch. The test does not set stream=True, so I don't think it is actually testing what it should test. Correct?

@julienaubert Sorry, can you provide more explanation about what is going on here? The read timeout should still apply.

@Lukasa afaic, the test that was meant to test that timeout works when stream=True, is not correct, as it is not setting stream=True and the default value is stream=False. See: https://github.com/kennethreitz/requests/blob/master/tests/test_requests.py#L1943

@julienaubert The reason there isn't an explicit stream argument is due to the patch that fixed this (and added this test).  #1935 removed the use of a different timeout object in send depending on the value of stream. That means Requests now always hands the read timeout so the stream flag isn't relevant in this regard.
Are you experiencing issues with a current version of Requests?

My code is as following
r = requests.get(url, stream=True, timeout=10)
with open(filename, 'wb') as f:
    for chunk in r.iter_content(chunk_size=1024):
        if chunk:
            f.write(chunk)

I hope that the code will raise exception if it did not download file over before the timeout. While it did not work.
Did I do anything wrong? The version of Requests is 2.18.4.

Timeouts are per socket operation, not total-time. If each read occurs faster than 10 seconds, then this will not trigger at timeout. If you want that behaviour you need to add it yourself by checking the clock between each read. =)

@Lukasa
Ok, I get it. Thanks~


install ctc_decoder for windows

PR types

PR changes

Describe

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Doubledongli:x: lidongdonglidongdong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


operator tf-operator (2011.L2.372)

This operator helps bring-up Juniper Contrail SDN networking for Redhat Openshift.

closing this to add fix opening new PR


Bug: broken completion

Hi there,
This commit from the 28th of March seems to introduce a problem with completion, at least on my system.
The problem is that if I am typing the name of a command in the current working directory, including a leading ./, completion picks up names of commands in other folders in my $PATH.
For example, let's say I'm doing some Django development and I want to run ./manage.py.  Then, if I type ./man and hit tab, it completes to ./man  (with a trailing space), presumably because it's finding man in my $PATH. Same for ls, sudo, yes, wc, etc.
My understanding/expectation is that given the leading ./, it should only complete to something in the cwd, and ignore the rest of $PATH.
I've stripped my ~/.zshrc back to this single line and I still see the problem:
source $HOME/prog/others/zsh-users/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh

Sadly I don't have the zsh knowledge to attempt to fix this, so I'm raising it as an issue. As a temporary workaround, I've rolled my local copy of zsh-syntax-highlighting back to the previous commit, which seems to work fine.
Other info:
ld% echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games

ld% zsh --version
zsh 5.0.2 (x86_64-pc-linux-gnu)

ld% lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 14.04.5 LTS
Release:	14.04
Codename:	trusty

I've stripped my ~/.zshrc back to this single line and I still see the problem:

And I'm assuming you've tried it without this line and the problem disappears? I realise this seems like a silly question, I just want to be 100% clear :)

I can confirm that I see the same behaviour here, using master z-sy-h and zsh 5.2

Yep, completely empty .zshrc fixes the problem. :-)

Hmmm, I might be wrong about the commit that's introducing the problem though. I found it via a git bisect, but I've just cloned out a fresh version of the repo and checked out that commit and I'm not seeing it on that commit.  I did another bisect and it's looking like this is the culprit but I might just be confusing myself so I'd recommend doing your own bisect rather than 100% trusting that aspect of the original report. Apologies for confusion.

OK thanks for the info: I'll attempt to isolate it myself and see what I can come up with here.

According to a git bisect I've just done, the first bad commit is 12b879caf7a6f96921d1c03ab9b839a7f6c8eb1e

On closer inspection, it would appear that if I remove line 116/117:
elif ! builtin type -w -- $1 >/dev/null 2>&1; then
  REPLY=none

it works as expected again. Wrapping the builtin type -w -- $1 inside $() also seems to prevent the completion of items on the PATH, but I'm not experienced enough in zsh to understand the ramifications of doing that :-)

I think I see the problem: ./sudo<TAB> gives me this output (with the format style set):
> external command
./sudo
> executable file
sudofoo*
> all matches
./sudo sudofoo

This doesn't happen for ./sud, only for ./sudo.

I'll have to get you to explain all this to me on IRC at some point :)
On 24 Aug 2016 19:08, "Daniel Shahaf"<EMAIL_ADDRESS>wrote:

I think I see the problem: ./sudo gives me this output (with the
format style set):

external command
./sudo
executable file
sudofoo*
all matches
./sudo sudofoo

This doesn't happen for ./sud, only for ./sudo.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/zsh-users/zsh-syntax-highlighting/issues/354#issuecomment-242157402,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmTyf6XR3DHP91F0IpsuJLWynSIfETeks5qjIiMgaJpZM4Jr1zr
.

Even odder: I can reproduce the issue in zsh -f + autoload compinit && compinit + z-sy-h, but not in z-sy-h with this patch:
diff --git zsh-syntax-highlighting.zsh zsh-syntax-highlighting.zsh
index 9de8d61..855fe33 100644
--- zsh-syntax-highlighting.zsh
+++ zsh-syntax-highlighting.zsh
@@ -272,5 +272,6 @@ _zsh_highlight_bind_widgets()
   widgets_to_bind+=(zle-isearch-update)

   local cur_widget
+  widgets_to_bind=( expand-or-complete )
   for cur_widget in $widgets_to_bind; do
     case $widgets[$cur_widget] in

where expand-or-complete is the widget invoked by TAB.  Binding just expand-or-complete and zle-line-finish doesn't reproduce the bug either.

I suspect this may be a workers/39001 problem — namely, an issue where simply installing a noop wrapper around a widget change its behaviour.

The bug is triggers with widgets_to_bind=( self-insert ) but not with widgets_to_bind=().
However, that alone is not the whole story: in zsh -f + autoload compinit && compinit, the command func() { () { zle "$@" && : } .self-insert -- "$@" }; zle -N self-insert func does not reproduce the issue.  That command mimics the wrapping of the self-insert widget.

Found a reproducer:
func() { () { zle "$@" && { if [[ $BUFFER == ./sudo ]]; then type -w ./sudo >/dev/null; fi } } .self-insert -- "$@" }; zle -N self-insert func

Without the type -w call it doesn't reproduce the problem.  This assumes sudo is in $PATH and ./sudofoo exists and is executable.

I reported the bug upstream: http://www.zsh.org/cgi-bin/mla/redirect?WORKERNUMBER=39099
Thanks for the report @gimbo, it was an interesting chase!  And thank you, @ascii-soup, for narrowing down the problem.

The link should be Running 'type' causes false positive hashed command completion.

Fixed, and for future reference the upstream bug has been fixed too:
https://github.com/zsh-users/zsh/commit/b312abc93b3b8eae8feb4a9884b22f519a137c7f (workers/39104)


⚠ Ausource International has degraded performance

In ce514ed, Ausource International (https://ausourceintl.com.au) experienced degraded performance:

HTTP code: 200
Response time: 23376 ms

Resolved: Ausource International performance has improved in 6e1f4cf after 4 minutes.


Add Support for  Element (for Icon Embedding)

Description

Add the <i> element, which is commonly used for embedding icons, especially with libraries like FontAwesome.
Update the documentation (README) to include the <i> element in the list of supported elements, with emphasis on its use for icon embedding.
Create a test for it

Use Case
The <i> element, when used with icon libraries like FontAwesome, can represent various icons, such as:
<i class="fa-regular fa-face-smile"></i>

@chasefleming
Hi, can you assign me? I would like to work on this issue.

Thanks @u5surf ! Assigning you. And yes please, let's do it according to the MDN spec. Sorry if the issue description was not clear. Thanks for clarifying.


Bug in ROM::SQL::Associations#graph_join with custom dataset name

Following my question in gitter on the use of the relation whose name differs from the corresponding table, I think I've found the root of the problem. And this seems to be a bug.
Using this relation:
class Tasks < ROM::Relation[:sql]
  register_as :tasks        # Differs from the dataset's
  dataset     :mygem_tasks
end

I've found that when I declare association (one_to_many etc.):
class Users < ROM::Relation[:sql]

  one_to_many :tasks, key: :user_id

  def with_tasks
    association_join :tasks, select: %i(value)
  end
end

I have to use the name of the repository in one_to_many, otherwise it won't be recognized by ROM::SQL::Relation::ClassMethods finalizer - it expects the name of the relation, not the dataset.
The association_join expects just the same name for ROM::SQL::Associations to return proper reflection.
But at the same time, when ROM::SQL::Associations builds graph, it treats the name :tasks not as the relation but as the db table.
I think, the problem is in the method ROM::SQL::Associations#graph_join. IMHO it should substitute the name of relation (its assoc_name argument) by the name of the dataset.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/13513172-bug-in-rom-sql-associations-graph_join-with-custom-dataset-name?utm_campaign=plugin&utm_content=tracker%2F155789&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F155789&utm_medium=issues&utm_source=github).

Yes this is definitely a bug. When I added this feature we didn't have a way of setting up a custom dataset name. So, relation name was also dataset name. This must be taken into account now in both association DSL and then graph_join.

Obviously, here is two options:

Change association DSL so that they use the table name, not the relation one
Alternatively we could change the #graph_join, so that it use the relation name

I'd prefer the first way because it doesn't require the second relation to be defined.
In such a case a proper use of association would be like this:
ROM::SQL.migration do
  change do
    create_table :mygem_tasks do
      foreign_key :user_id, :mygem_users
      # ...
    end
  end
end

ROM::SQL.migration do
  change do
    create_table :mygem_users do
      primary_key :id, null: false
      # ...
    end
  end
end

class Users < ROM::Relation[:sql]
  dataset :mygem_users

  one_to_many :mygem_tasks, key: :user_id

  def with_tasks
    association_join :mygem_tasks, select: %i(title)
  end
end

Relation for tasks is not necessary at all.

I'm afraid, there is a deeper problem that appears here.
As it stated in overview, the commands and relations are expected to be separate.
But the implementaion differs: commands back on relations, not "pure" datasets.
class CreateUser < ROM::Commands::Create[:sql]

  relation :users  # command depends on relation
                   # that mediates its access to datastore

end

Following overview, I'd expect the syntax to be something like this:
class CreateUser < ROM::Commands::Create[:sql]

  repository :default  # like in definition for the relation
  dataset :mygem_users # uses the dataset (db table etc.), not the relation,
                       # because commands knows nothing about relations

end

It is the example that would be consistent to the first option in my previous comment. But, well, I understand it could be too late for such a velleity...

Not really, it's not a problem. Commands use relations but each relation exposes its dataset so a command could use dataset directly, in fact rom-sql does that in a couple of places.

Of course, you're right: the dataset is accessible.
IMHO the problem is that a Sequel knows nothing about relations, and with it we HAVE TO use datasets. At the same way in association we refer to relations, which is a bit perplexing.
For example, to fix the bug, I forked the repo and changed integration spec by renaming the tasks repository to goals (the Task model to Goal etc.). And then added the small patch to #graph_join that solves the problem.
Well, it works.
But, as I mentioned above, despite the fact the relation name goals is used in associations, I still have to use the table name tasks in grouping because this is the Sequel's context, not the ROM's.

Fixed via rom-sql#25


feat(building-rollup): dedupe lit-html by default

exposes dedupeModules option in config generator options.
closes #748
affects: @open-wc/building-rollup
Relevant section of deploy preview:
https://deploy-preview-1000--open-wc-org.netlify.com/building/building-rollup.html#deduplicating-node-modules

Reviewers, will this have knock-on effects in other packages?

Is there a 'dedupe all' option? I'd personally go for that.

rollup-plugin-node-resolve's dedupe option can take as its value either an array of package names, or a function of importee -> boolean
So we could pass () => true to dedupe everything, meaning our option's type could be Boolean | Function | 'all' | string[], and in case of 'all', we'd pass that constant true func.

Sounds good to me, I think you would only want duplicate packages in specific use cases

Per our discussion in slack, we might want to change the base of this MR to some dedupe branch, which would include support for deduping modules in building-webpack and es-dev-server as well.
At the moment it would seem all three require their own bespoke implementations, until support for import maps lands in the bundlers.

Considering #748 is closed, I'm closing this PR.


Cherrypick - Extract and Log Contract Revert Reason (#1043)

Description:
Cherry-picks:
https://github.com/hashgraph/hedera-json-rpc-relay/pull/1043

Codecov Report
Patch coverage: 52.94% and project coverage change: -0.20 :warning:

Comparison is base (72212d7) 74.63% compared to head (8d6bc88) 74.43%.

:exclamation: Current head 8d6bc88 differs from pull request most recent head cda385c. Consider uploading reports for the commit cda385c to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           release/0.21    #1070      +/-   ##
================================================
- Coverage         74.63%   74.43%   -0.20%
================================================
  Files                30       30
  Lines              2030     2046      +16
  Branches            386      390       +4
================================================
+ Hits               1515     1523       +8
- Misses              410      417       +7
- Partials            105      106       +1

Impacted Files
Coverage Δ

packages/relay/src/lib/constants.ts
100.00% <ø> (ø)

packages/relay/src/lib/errors/SDKClientError.ts
58.82% <0.00%> (-3.68%)
:arrow_down:

packages/relay/src/lib/eth.ts
83.33% <12.50%> (-0.94%)
:arrow_down:

packages/relay/src/lib/clients/mirrorNodeClient.ts
94.16% <100.00%> (+0.16%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


10/26/2018 01:37 : Create Pull Request for branch prTesting_2018102601 -> master

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


updated podspec to avoid errors when trying to use cocoapods from an iOS only project

updated podspec to use ios.deployment_target and oxs.deployment_target to avoid errors when trying to use cocoapods from an iOS only project
Problem:
Cannot run pod install on the latest version of MulticastDelegate (2.1.0). Cocoapods shows an error message that it does not support the platform 'ios'. My company had to downgrade to MulticastDelegate 2.0.1 to allow pod install to be able to run

I believe this problem is due to this commit here: https://github.com/jonasman/MulticastDelegate/commit/d3fe045be7a190e5d509db37d0c9b534d85cbdb0
This PR is updating the podspec to match the format specified in this cocoapod issue:
https://github.com/CocoaPods/CocoaPods/issues/4185
Here is an example from Alamofire that my change is based on:
https://github.com/Alamofire/Alamofire/blob/master/Alamofire.podspec

Thanks! I will update the trunk soon


Unsuccessful response from plugin. Plugin returned with code '500'

Hi!
Thank you for this plugin!
I installed it without any issue on a 15.2 Go Server but I tried to use it with parameters #{HEALTHCHECK_URL} (I use templates and the URL is different on every pipeline) and use static value after it failed and a simple test on a static page give me this error:
09:33:30.953 [go] Start to execute task: Plugin with ID: healthcheck.task.plugin.
09:33:30.960 Error: Interaction with plugin with id 'healthcheck.task.plugin' implementing 'task' extension failed while requesting for 'execute'. Reason: [Unsuccessful response from plugin. Plugin returned with code '500' and the following response: '{"message":"Health check failed","exception":null,"success":false}']
09:33:30.977 [go] Current job status: failed.

I don't know if it's the configuration or the plugin because the logs are not really clear.
Thank you for your help!
Damien

Did you solve your problem timoa?

something similar happens for me also. Huge error message without sense.


[EWT-16]: Airflow fix for manual trigger during version upgrade

Can you explain why this change is needed and add a comment to this effect in the code, and also make the info message clearer?
Since this is a fork, can we also file an upstream JIRA ticket to fix the root cause of the issue, and add a TODO here referencing this JIRA? Ideally we would resolve this issue upstream since it will probably bite someone again in the next few releases, but this is out of scope for your current task.

Can you explain why this change is needed in a lot of detail and add a comment to this effect in the code, and also make the info message clearer? Someone is likely to bump into a problem with this code in the future and it could save them days of work/investigation.
Since this is a fork, can we also file an upstream JIRA ticket to fix the root cause of the issue, and add a TODO here referencing this JIRA? Ideally we would resolve this issue upstream since it will probably bite someone again in the next few releases, but this is out of scope for your current task.

Added this in TODO, will create a jira for this and resolve this in upstream.
For now, using this hack.


Remove editor header in issues on archived repositories

Description
On issues in archived repositories, GitHub displays the editor header ("Write" and "Preview"), which doesn't make sense.

What Refined GitHub does is remove the avatar in front of it. However, it would make more sense to remove the header completely.
Example URLs
https://github.com/liip/bund_ds/issues/132#event-10996157695

PR welcome. This can be a 3-line CSS-only feature: features/clean-archived-issue.css I think

Hi @fregante I would like to work on this, but did not find the mentioned file,
could it be a feature with the same logic as this one: https://github.com/refined-github/refined-github/blob/2fcbc2b28b6ca8c241c0411887e53a61b9e33e1e/source/features/archive-forks-link.tsx#L9
To get this done we could remove the div with the next classes: comment-form-head tabnav

This is the first time for me to contribute here, how would the extension detect the CSS in the file and understand if the issue is archived?


landrush_ip_get is called before landrush_ip_install with libvirt provider

==> default: Setting hostname...
==> default: Configuring and enabling network interfaces...
==> default: [landrush] setting up machine's DNS to point to our server
==> default: [landrush] network: :forwarded_port, {:guest=>22, :host=>2222,     :host_ip=>"<IP_ADDRESS>", :id=>"ssh", :auto_correct=>true, :protocol=>"tcp"}
The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

/usr/local/bin/landrush-ip -yaml

Stdout from the command:

Stderr from the command:

bash: line 2: /usr/local/bin/landrush-ip: No such file or directory

I believe the issue is, how the install action is registered in relation to Landrush.

I faced the same issue while using Vagrant on CentOS with libvirt.

Odd, when I implemented this I could've sworn it worked with Libvirt too. Will test in the coming days unless either of you has an idea for a better hook point for Libvirt?

@Werelds, did you get a chance to test this?

This'll have been solved to some extent for Libvirt + Landrush users with the new mechanics, but I'm setting up a Linux VM atm in which I'll test libvirt directly. Doing that on OS X is more work than setting up a VM :P


Closes #49 | Updated existing TICO_19 dataloader to support more sea languages

Closes #49
Checkbox

[x] Confirm that this PR is linked to the dataset issue.
[x] Create the dataloader script seacrowd/sea_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
[x] Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
[x] Implement _info(), _split_generators() and _generate_examples() in dataloader script.
[x] Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
[x] Confirm dataloader script works with datasets.load_dataset function.
[x] Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py.
[x] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

@ssun32 , thank you for the updates! Merging now


Sign in with Google temporarily disabled for this app

Our server version info:
lsb_release -a
LSB Version:	:core-4.1-amd64:core-4.1-ia32:core-4.1-noarch:cxx-4.1-amd64:cxx-4.1-ia32:cxx-4.1-noarch:desktop-4.1-amd64:desktop-4.1-ia32:desktop-4.1-noarch:languages-4.1-amd64:languages-4.1-noarch:printing-4.1-amd64:printing-4.1-noarch
Distributor ID:	RedHatEnterpriseServer
Description:	Red Hat Enterprise Linux Server release 7.8 (Maipo)
Release:	7.8
Codename:	Maipo

Go version info:
go version go1.13.14 linux/amd64

I stuck with step five:  gdrive list. After copy & paste the authentication link, I got this error info as the image shows.
Do I have something wrong with these? Thanks a lot!

I have same problem

I have same problem

This is happening for me too.

This is happening for me too.

I have also the same problem ; how to fix it ?

App still does not work.
https://imgur.com/VzXaixT.png

The same, but i see author is nothing doing with this...