Fix alacritty config path mismatch with it's doc

According to https://github.com/alacritty/alacritty/tree/master#configuration, the configure file should be in following path

$XDG_CONFIG_HOME/alacritty/alacritty.yml
$XDG_CONFIG_HOME/alacritty.yml
$HOME/.config/alacritty/alacritty.yml
$HOME/.alacritty.yml

but paths in script do not fully match these paths, this patch fix this problem.

Thank you!


Missing BCCommon.Frame.Search.pas

[dcc32 Fatal Error] BCCommon.Delphi.Seattle.Runtime.dpk(106): F2613 Unit '..\Source\BCCommon.Frame.Search.pas' not found.

That is obsolete and removed. I will remove it from the packages.


Optimize method for initializing cache of  versions of the deployer tool

When the network is not connected or the speed is slow, obtaining the deployment tool version from  the endpoint https://api.github.com will can take a long time (about 25 min), and this method uses @PostConstruct  which make the application start slowly, looks like the application cloud not be started normally. This must be optimized.
The following changes to the method:

[x] Move the initialization method after the application is successfully started.
[x] Due to the GitHub SDK used not providing a setting for connection timeout duration, add network connection check and customize timeout duration.
[x] Output necessary logs. such as start, end ,error
[ ] Update this method in xpanse, terraform-boot,tofu-maker

I will take it.

LGTM


rwpspread: init at 0.1.8

Description of changes
Added rwpspread a multi monitor wallpaper utility for use on wlroots based compositors

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

reverting the change of sourcing the Cargo lock file direct from source as eval here failed.
worked fine locally so would love to see if there's some way to avoid including that big lock-file separately as I do now.

Result of nixpkgs-review pr 284144 run on aarch64-linux 1

1 package built:

rwpspread


build: bump images to v1.24.1 for release

The Issue
It's time to build new images for v1.24.1 (bugfix release)
How This PR Solves The Issue
Manual Testing Instructions
Automated Testing Overview

Release/Deployment Notes

Release notes look great, thanks for doing them.


Ability to silence the concierge

There may be scenarios where we want the concierge to disengage from all or part of a PR/issue, e.g., perhaps if there is a PR we want to keep open and not merge for a few months.
Some experience here will probably make what is useful obvious, but I could imagine something like an @mention or tasklist checkbox to be able to silence things like the stale bumper, CHANGES.md update, etc.

This is implemented in the bumper script (https://github.com/AnalyticalGraphicsInc/cesium-concierge/pull/106). Just needs to be generalized (https://github.com/AnalyticalGraphicsInc/cesium-concierge/issues/110).


Not selecting a value clears validator error

Description
Vaadin version 14.5.3
If you have set a Select set as required through Binder and with setEmptySelectionAllowed(false), you can clear the red validation status by opening the select popup and choosing nothing.
Steps to Reproduce
Code example:
public class MasterDetailView extends VerticalLayout {

    public MasterDetailView() {
        Select<String> select = new Select<>();
        select.setItems("Foo", "Bar");
        select.setEmptySelectionAllowed(false);

        Binder<DummyItem> binder = new Binder<>(DummyItem.class);
        binder.readBean(new DummyItem());
        binder.forField(select).asRequired().bind(DummyItem::getName, DummyItem::setName);

        Button validateB = new Button("Validate", e -> {
            binder.validate();
        });
        add(select, validateB);
    }

    static class DummyItem {
        public String getName() {
            return name;
        }
        public void setName(String name) {
            this.name = name;
        }
        private String name;
    }
}

Steps

Click validate (makes the Select invalid)
Click to open the Select overlay
Click outside the overlay to choose nothing -> Select becomes valid again even though there is no value selected

Expected Results
Closing the overlay should not change the Select to become valid
Actual Results
Closing the overlay makes the Select valid
Browsers Affected

[x] Chrome
[x] Firefox
[x] Safari
[x] Edge
[x] iOS Safari
[x] Android Chrome

Version
vaadin 14.5.3

Here is a sample project to reproduce the issue: select-required-issue-v14.5.3.zip


Investigate how to pass attacks w/o using YAML file

Looks like this isn't currently possible but there is a feature request to add it here: https://github.com/ros2/rcl/issues/460

@ryanewel any updates?

I don't think so, we still don't have a good way to do this from the command line and that issue is still open


Links Node - Output duplication

Hi there, I noticed this node's (Links) output jumping around upon each open of the script.  I can fix it by deleting and undoing, but I figured I should point it out. I believe it has to do with the upgrade to 2.0 since it doesn't happen in 1.3.  Hope I'm not jumping the gun on this one.

Dynamo Version : 2.0
Windows 7
Revit 2018.3

Thanks for the comment! Definitely because of Dynamo 2.0. Rhythm is not currently 100% compatible with 2.0. I plan on releasing an update pertaining to this in a few months.

I figured it was a bit early but never hurts to know one of the issues ahead of time. Is this a good place to report any further issues pertaining to the upgrade?

Definitely! I appreciate the help in squashing some bugs! Thanks @DillonManning

This is fixed in the next release. (Will be out on Friday)


community-feed: date picker does not work properly

Date picker in the community feed does not work properly when the slider is used.
Not sure there is a fix.

Decided not to have this anymore


Wrong description in Digit classifier : Tensorflow Lite examples

URL with the issue: https://www.tensorflow.org/lite/examples
Description of issue:
The digit classifier example card has the wrong description :
"Generate reply suggestions to input conversational chat messages."
Screenshot

Thanks. Filed an internal issue: b/154952252

This has been fixed now. Thanks!


Move some side panels context variables resolution to the view

Redo of #10854 with a different approach (less pulling stuff out of the parent context). Fixes #9702.
I highly recommend reviewing each commit, with the "hide whitespace" option on GitHub.
In the generic side panels code there are still some variables inherited from the parent context:

form: would be nice to pass this via the side panel's constructor instead, but apparently the generic create/edit views do not bind the form instance to the view (self.form) until the form is submitted (in form_valid and form_invalid). This means for GET requests, in the view you'll need to either:

Do self.form = self.get_form() manually inside get_context_data and pass it to super().get_context_data to prevent Django from instantiating the form again and ensure that we're using the same form instance, or
Do self.form = context.get("form") in get_context_data() so we can use it in get_side_panels(). I'm not a fan of setting attributes to self in get_context_data because that method is called near the end of the view process and is only called for template responses, which means accessing the attribute in other places/cases may fail.
Change signature of get_side_panels(self) to get_side_panels(self, form) and pass the form from the context. Not a fan of this, because this means we're special-casing form for a method that's not directly related to it (compared to e.g. form_valid(self, form) and form_invalid(self, form).
I think ideally we would instantiate the form early e.g. in setup/dispatch/get/post and bind it to self.form, to be used later in get_context_data, similar to how the page create and edit view work. That would guarantee the availability of self.form everywhere and ensure that we use the same instance. However, I think it's a bit too risky to do for now, so I opted not to do it for now.

user_can_lock/user_can_unlock: this would be much easier once we've consolidated the permission tester for pages and non-pages, so I'm leaving it for later.

the toggle classes inherited from slim_header.html: I probably should've used a different approach back in dbcad2b7c67c95bff81bf17ff360d7b7753599a2, but I faced some difficulties due to the form variable unavailability and so I figured if inheriting from the parent context is OK, might as well do it in more places. Will look into possibly refactoring this later.

Anyway, the result is that we're a few steps closer to allow the side panels to be used in generic views. The remaining snippets-specific code is only to inherit some context values from the view, most of which are features that are snippets-specific (revisions, drafts, locking, workflows) after we bring history and usage views to the generic ModelViewSet.
Please check the following:

[x] Do the tests still pass?[^1]
[x] Does the code comply with the style guide?

[x] Run make lint from the Wagtail root.

[x] For Python changes: Have you added tests to cover the new/fixed behaviour?

Not added per se, but I've uncommented the related expectedFailure tests and they pass.

[^1]: Development Testing
[^2]: Browser and device support
[^3]: Accessibility Target

Rebased.


%reset function -- error message

<!---   *** BEFORE SUBMITTING: PASTE CLIPBOARD HERE TO COMPLETE YOUR REPORT ***   ---!>
I am new to Anaconda and GitHut.

I was reading the into for beginners and was trying to delete an existing function in the console as advised in the console tutorial by typing %reset. It didn't work.

Thank you

%reset -f
works just fine.

Hey @annnnnroot, thanks for reporting. This problem is fixed in a more recent version. Please update by closing Spyder, opening the Anaconda Prompt and running there
conda update anaconda
conda install spyder=5.2.2


How to redirect all traffic from www to non-www

Title: How to redirect all traffic from www to non-www
Description:
I would like to redirect all traffic from www.domain.com to domain.com:

http://www.domain.com →https://domain.com (done)
http://www.domain.com/page.html → https://domain.com/page.html
https://www.domain.com → https://domain.com
https://www.domain.com/page.html → https://domain.com/page.html

Config:
admin:
  access_log_path: /dev/null
  address:
    socket_address: { protocol: TCP, address: <IP_ADDRESS>, port_value: 8001 }

static_resources:
  listeners:
  - name: listener_http
    address:
      socket_address: { protocol: TCP, address: <IP_ADDRESS>, port_value: 80 }
    listener_filters:
    - name: "envoy.listener.tls_inspector"
      typed_config: {}
    filter_chains:
    - filters:
      - name: envoy.http_connection_manager
        config:
          codec_type: auto
          stat_prefix: ingress_http
          route_config:

            virtual_hosts:

            # this only redirect: http://www.domain.com to https://www.domain.com
            - name: www_backend
              domains:
              - "www.*"
              routes:
              - match: { prefix: "/" }
                redirect: { path_redirect: "/", https_redirect: true }

            - name: backend
              domains:
              - "*"
              routes:
              - match: { prefix: "/" }
                redirect: { path_redirect: "/", https_redirect: true }

          http_filters:
          - name: envoy.router
            config: {}

  - name: listener_https
    address:
      socket_address: { protocol: TCP, address: <IP_ADDRESS>, port_value: 443 }
    filter_chains:
    - filters:
      - name: envoy.http_connection_manager
        typed_config:
          "@type": type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager
          codec_type: AUTO
          stat_prefix: ingress_http
          route_config:
            name: local_route

            virtual_hosts:
            - name: domain_com_backend
              domains:
              - "domain.com"
              routes:
              - match: { prefix: "/" }
                route: { cluster: domain_com }

          http_filters:
          - name: envoy.router
            typed_config: {}
      tls_context:
        common_tls_context:
          alpn_protocols: [ "h2,http/1.1" ]
          tls_certificates:
          - certificate_chain: { filename: "/etc/envoy/certs/domain_com.cert" }
            private_key: { filename: "/etc/envoy/certs/domain_com.key" }

  clusters:
  - name: domain_com
    connect_timeout: 0.25s
    type: STRICT_DNS
    lb_policy: ROUND_ROBIN
    http2_protocol_options: {}
    load_assignment:
      cluster_name: domain_com
      endpoints:
      - lb_endpoints:
        - endpoint:
            address:
              socket_address:
                address: domain_com
                port_value: 80

Thanks!

@joseluisq I think if you drop the path_redirect field it should work as you intend.

@htuch I solved it droping www_backend (listener_http) then in listener_https I have created a new entry in virtual_hosts putting manually the domain name (with www), finally redirecting via host_redirect:
static_resources:
  listeners:
  - name: listener_http
    # ...

            virtual_hosts:
            - name: backend
              domains:
              - "*"
              routes:
              - match: { prefix: "/" }
                redirect: { https_redirect: true }

  - name: listener_https
    # ...

            virtual_hosts:
            - name: www_backend
              domains:
              - "www.domain.com"
              routes:
              - match: { prefix: "/" }
                redirect: { host_redirect: "domain.com", https_redirect: true }

           virtual_hosts:
            - name: domain_com_backend
              domains:
              - "domain.com"
              routes:
              - match: { prefix: "/" }
                route: { cluster: domain_com }

But the questions is how can I do using a wildcard? Actually this below doesn't work.
            virtual_hosts:
            - name: www_backend
              domains:
              - "www.*"
              routes:
              - match: { prefix: "/" }
                redirect: { https_redirect: true }

                # Something like this maybe?:
                redirect: { host_redirect: "*", https_redirect: true }

@htuch By the way, time to time I got a :
upstream connect error or disconnect/reset before headers. reset reason: connection termination
then when I refresh the page in browser it works again. Do you know why?

@joseluisq Envoy doesn't do wildcard redirects in this way (at least today). Given the bounded number of  redirects you want to do, I think you can just enumerate them.
If you want to just do the SSL redirect (i.e. not the www. drop), this can be wildcard based.
I'm not sure about the error, there's probably a lot of potential causes. I would look at -l trace level logs for more info.

Thanks :+1:

Title: How to redirect all traffic from www to non-www
Description:
I would like to redirect all traffic from www.domain.com to domain.com:

http://www.domain.com →https://domain.com (done)
http://www.domain.com/page.html → https://domain.com/page.html
https://www.domain.com → https://domain.com
https://www.domain.com/page.html → https://domain.com/page.html

Config:
admin:
  access_log_path: /dev/null
  address:
    socket_address: { protocol: TCP, address: <IP_ADDRESS>, port_value: 8001 }

static_resources:
  listeners:
  - name: listener_http
    address:
      socket_address: { protocol: TCP, address: <IP_ADDRESS>, port_value: 80 }
    listener_filters:
    - name: "envoy.listener.tls_inspector"
      typed_config: {}
    filter_chains:
    - filters:
      - name: envoy.http_connection_manager
        config:
          codec_type: auto
          stat_prefix: ingress_http
          route_config:

            virtual_hosts:

            # this only redirect: http://www.domain.com to https://www.domain.com
            - name: www_backend
              domains:
              - "www.*"
              routes:
              - match: { prefix: "/" }
                redirect: { path_redirect: "/", https_redirect: true }

            - name: backend
              domains:
              - "*"
              routes:
              - match: { prefix: "/" }
                redirect: { path_redirect: "/", https_redirect: true }

          http_filters:
          - name: envoy.router
            config: {}

  - name: listener_https
    address:
      socket_address: { protocol: TCP, address: <IP_ADDRESS>, port_value: 443 }
    filter_chains:
    - filters:
      - name: envoy.http_connection_manager
        typed_config:
          "@type": type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager
          codec_type: AUTO
          stat_prefix: ingress_http
          route_config:
            name: local_route

            virtual_hosts:
            - name: domain_com_backend
              domains:
              - "domain.com"
              routes:
              - match: { prefix: "/" }
                route: { cluster: domain_com }

          http_filters:
          - name: envoy.router
            typed_config: {}
      tls_context:
        common_tls_context:
          alpn_protocols: [ "h2,http/1.1" ]
          tls_certificates:
          - certificate_chain: { filename: "/etc/envoy/certs/domain_com.cert" }
            private_key: { filename: "/etc/envoy/certs/domain_com.key" }

  clusters:
  - name: domain_com
    connect_timeout: 0.25s
    type: STRICT_DNS
    lb_policy: ROUND_ROBIN
    http2_protocol_options: {}
    load_assignment:
      cluster_name: domain_com
      endpoints:
      - lb_endpoints:
        - endpoint:
            address:
              socket_address:
                address: domain_com
                port_value: 80

Thanks!

@joseluisq, could you help me with the configuration as I'm trying to use envoy for forwarding data from http://example.com to https://example.com


Can't deactivate "import/no-extraneous-dependencies" (for devDependencies) for .ts files

I continue to get errors for "import/no-extraneous-dependencies" despite doing my best to deactivate it in my .eslintrc.js. I've tried all variations of deactivating it I could think of for well over an hour now, and all of them are ignored. I can't even set it to "warn" instead of "error".
Things that work:

Turning it off seems to work fine in .js files. When I rename my file from main.ts to main.js, my "import/no-extraneous-dependencies" configuration behaves exactly as expected.
All other changes I make in the .eslintrc.js file work fine.
Deactivating the error with // eslint-disable-next-line import/no-extraneous-dependencies works fine.
/* eslint import/no-extraneous-dependencies: ["error", {"devDependencies": true}] */ works fine too, but putting the same into .eslintrc.js produces no effect. It's like something adds the rule after my .eslintrc.js rules.

Here is an example of the error I get:
'pixi.js' should be listed in the project's dependencies, not devDependencies.eslint(import/no-extraneous-dependencies)
Here is my .eslintrc.js:
module.exports = {
    parser: "@typescript-eslint/parser",
    plugins: [
        "@typescript-eslint",
        "eslint-comments",
        "jest",
        "promise",
        "unicorn",
    ],
    extends: [
        "airbnb-typescript",
        "plugin:@typescript-eslint/recommended",
        "plugin:eslint-comments/recommended",
        "plugin:jest/recommended",
        "plugin:promise/recommended",
        "plugin:unicorn/recommended",
        "prettier",
        "prettier/react",
        "prettier/@typescript-eslint",
    ],
    env: {
        node: true,
        browser: true,
        jest: true,
    },
    rules: {
        // Too restrictive, writing ugly code to defend against a very unlikely scenario: https://eslint.org/docs/rules/no-prototype-builtins
        "no-prototype-builtins": "off",
        // https://basarat.gitbooks.io/typescript/docs/tips/defaultIsBad.html
        "import/prefer-default-export": "off",
        "import/no-default-export": "error",
        // Too restrictive: https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/destructuring-assignment.md
        "react/destructuring-assignment": "off",
        // No jsx extension: https://github.com/facebook/create-react-app/issues/87#issuecomment-234627904
        "react/jsx-filename-extension": "off",
        // Use function hoisting to improve code readability
        "no-use-before-define": [
            "error",
            { functions: false, classes: true, variables: true },
        ],
        // Makes no sense to allow type inferrence for expression parameters, but require typing the response
        "@typescript-eslint/explicit-function-return-type": [
            "error",
            { allowExpressions: true, allowTypedFunctionExpressions: true },
        ],
        "@typescript-eslint/no-use-before-define": [
            "error",
            { functions: false, classes: true, variables: true, typedefs: true },
        ],
        // Common abbreviations are known and readable
        "unicorn/prevent-abbreviations": "off",

        // I put everything into dev-dependencies because it will all be transpiled by webpack
        "import/no-extraneous-dependencies": [
            "warn",
            {
                "devDependencies": true,
                "optionalDependencies": true,
                "peerDependencies": true,
            }
        ],

        // I don't see the point of this
        "unicorn/prefer-node-append": "off"
    },
}

Re "I put everything into dev-dependencies because it will all be transpiled by webpack" - anything that is conceptually a runtime dependency belongs in production deps. Use of webpack is an implementation detail, and doesn't make those things dev deps.
That said, it should certainly be set to warn as a result of this config. Try adding "root": true, because you might have a ~/.eslintrc or something?

Re: devDendencies vs dependencies - from what I understand, runtime dependencies are dependencies that have to be present in ./node_modules while running the app. But here, everything is already bundled into the distribution, so the app could theoretically (it's theoretical because it's not a node app) be executed with an empty ./node_modules folder.
There's a fun thread about it over in the webpack issues: https://github.com/webpack/webpack/issues/520 that leans strongly towards devDependencies, and prominent frontend libraries like React (https://github.com/facebook/react/blob/master/package.json) and Vue (https://github.com/vuejs/vue/blob/dev/package.json) use that pattern too.
Either way, this is a pretty philosophical discussion considering that the app will never run as a node app.
Re: "root": true: Like this?
module.exports = {
    root: true,
    parser: "@typescript-eslint/parser",
[...]

That didn't change anything.
At this point I'm rather convinced that it's a problem with .ts files as opposed to e.g. .js files. As I said in my opening post, renaming a .ts file to .js makes it behave correctly, i.e. the error vanishes (with the configuration file above) or turns into a warning if I set devDependencies to false in the configuration file.
It only and persistently stays an error as long as the file has the .ts extension.

You're only describing code that runs in node - dependencies is a conceptual field for anything that applies to the runtime.

Yes, that's what I meant by root true :-/
I'm not familiar with airbnb-typescript - airbnb doesn't maintain that. Are you sure it's setting up all the right typescript extensions?

I'm not really sure about anything, especially since this is my first time using ESLint for Typescript. For that reason, I'm just using this configuration file https://github.com/iamturns/create-exposed-app/blob/master/.eslintrc.js to start out with. Can you clarify what you mean by "setting up all the right typescript extensions"?

The import plugin has to be told to look at .ts/.tsx files.
<EMAIL_ADDRESS>looks like it is doing that, though.

Turns out I was using an extremely outdated eslint-config-airbnb-typescript (among other things). Upgrading my package.json to current versions (via ncu -u) helped.
Thanks a lot for your quick answers, and sorry I wasted your time there!


How to generate dynamic form using json in hygen?

How to generate dynamic form using json in hygen?
Is there a way to generate custom form with react using json schema in hygen?
Thanks in advance for any suggestion and work around

How to generate dynamic form using json in hygen?
Is there a way to generate custom form with react using json schema in hygen?
Thanks in advance for any suggestion and work around

did you get any solution?


Lost rows during the same data ingesting into FiloDB

I am testing FiloDB with latest trunk, include PR-91, and  can produce this problem that I saw the filodb lost raw after the data ingested. Below is the test case I run, and just want to make sure that it is a bug, not something I misunderstand how filodb is supposed to work.
I have this 1m records of unique emails, with domain. I will use the first 2 characters as the partition key, and use the domain as the segment key, and unique email address itself as the row key. I tested with in memory.

After I save the data from spark into filoDB, if I load the data back in one DF, the count is 1M.
Then I save the exactly same data from spark into filoDB again in the same spark shell, and load the data back in one DF, the count is less than 1M.

I enable the log at debug level for filoDB package, and the full log is attached.
From the log, you can see what is my steps, and the log output from filoDB, and the 2nd time, the count is not correct.
I will also dig the log more, as want to understand more internal of filoDB. Hope the log is helpful to identify the root cause of this case.
Thanks
Yong
filodb-lost-update-bug.log.gz

@java8964 so I'm looking at your logs now.  Your choice of segment key probably results in really small segments, btw.
I don't see anything unusual from the logs alone.
Repeating the steps from the other PR, including starting the Spark shell (except I added java options for G1GC), I first verified that all the emails are indeed unique.
I then discovered something in my new code, which breaks the InMemoryColumnStore, so I'll go back and fix that.  But in the meantime, you might want to issue a flush at the end manually and see if that fixes it.
filodb.spark.FiloSetup.client.flushByName("poc1")
(Note this API will change slightly in the future)

@java8964 I have some changes in a new branch, which adds "clustering" support.
velvia/clustering-support-90
If you run in local / in-memory store, like your test in the other thread, you should find that it consistently returns 1 million rows now.   Basically one change is that it makes sure to flush any remaining rows it finds in the memtable at the end of ingestion.
If you test code in this branch on a cluster, be ware that it will require an extra port to be opened.  Right now the port assignment is random, and I'll need to add config to make sure it's not random.
It will be possible to connect in the future remotely to this port and get monitoring/stats out.

Fix is merged now


Unable to use @backstage/core in Custom Actions

Expected Behavior
Able to add a custom action to /backend/src/actions/createNewFileAction.ts and everything mentioned in the following doc to /backend/src/plugins/scaffolder.ts
https://backstage.io/docs/features/software-templates/writing-custom-actions#docsNav
when running yarn tsc i am getting a number of errors related to fs-extras

Possible Solution

Steps to Reproduce
Follow this doc - https://backstage.io/docs/features/software-templates/writing-custom-actions#docsNav
Your Environment

NodeJS Version (v14)
Win 10

What errors? Cloud you provide the log output?

I guess that would help huh lol my bad i ended up getting passed the error but it still looks like i am not able to use @backstage/core directly in the action. It was mentioned on Discord its something about how its being used in @backstage/backend-common ?
Here's what my scaffolder.ts in case in helps anyone -
import { ScmIntegrations } from '@backstage/integration';
import { SingleHostDiscovery } from '@backstage/backend-common';
import { CatalogClient } from '@backstage/catalog-client';
import {
  CookieCutter,
  createRouter,
  Preparers,
  Publishers,
  CreateReactAppTemplater,
  Templaters,
  createBuiltinActions,
} from '@backstage/plugin-scaffolder-backend';

import { myCustomAction } from '../actions/publish/myCustomAction';
import Docker from 'dockerode';
import { Router } from 'express';
import type { PluginEnvironment } from '../types';

export default async function createPlugin({
  logger,
  config,
  database,
  reader,
}: PluginEnvironment): Promise<Router> {
  const cookiecutterTemplater = new CookieCutter();
  const craTemplater = new CreateReactAppTemplater();
  const templaters = new Templaters();

  templaters.register('cookiecutter', cookiecutterTemplater);
  templaters.register('cra', craTemplater);

  const preparers = await Preparers.fromConfig(config, { logger });
  const publishers = await Publishers.fromConfig(config, { logger });

  const integrations = ScmIntegrations.fromConfig(config);
  const dockerClient = new Docker();

  const discovery = SingleHostDiscovery.fromConfig(config);
  const catalogClient = new CatalogClient({ discoveryApi: discovery });

  const proxyUrl = await discovery.getBaseUrl('proxy');
  const builtInActions = muCustomAction({
    dockerClient,
    integrations,
    catalogClient,
    templaters,
    reader,
  });
  const actions = [...builtInActions, myCustomAction({ proxyUrl })];

  return await createRouter({
    preparers,
    templaters,
    publishers,
    logger,
    config,
    dockerClient,
    database,
    catalogClient,
    reader,
    actions,
  });
}

Oh, core is a frontend-only package - it's entirely not possible to use it in backend packages. You can tell by its being built as ESM https://github.com/backstage/backstage/blob/master/packages/core/package.json#L
Compare to a backend package which is CJS https://github.com/backstage/backstage/blob/master/packages/backend-common/package.json#L10
Or to a universal package which supports both https://github.com/backstage/backstage/blob/master/packages/catalog-model/package.json#L10

Does this mean that the issue can be closed?

@regicsolutions what exports from the @backstage/core package is it that you want to use?


Added network automation awesome list

Curated Awesome list about Network Automation.

[https://github.com/networktocode/awesome-network-automation]
[Network Automation is cross between two disciplines of Infrastructure Networks and Programming, this list was created to as a one-stop shop to find the information.]
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request

You have to review at least 2 other open pull requests. Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
I have read and understood the instructions for creating a list.
This pull request has a descriptive title in the format Add Name of List (Example: Add Swift), not Update readme.md or Add awesome list.
The entry in the Awesome list should:

Include a short description about the project/theme of the list. It should not describe the list itself.Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
Be added at the bottom of the appropriate category.

The list I'm submitting complies with the below requirements.

Requirements for your Awesome list

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
It's the result of hard work and the best I could possibly produce.
Non-generated Markdown file in a GitHub repo.
Includes a succinct description of the project/theme at the top of the readme. (Example)
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate.
Only has awesome items. Awesome lists are curations of the best, not everything.
Includes a project logo/illustration whenever possible.

Either centered, fullwidth, or placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Includes the Awesome badge.

Should be placed on the right side of the readme heading.

Can be placed centered if the list has a centered graphics header.

Should link back to this list.

Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.
Should only have one level of nested lists, preferably none.

Has an appropriate license.

That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
WTFPL and Unlicense are not acceptable licenses.
If you use a license badge, it should be SVG, not PNG.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.

Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.

Go to the top and read it again.

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.
// @itdependsnetworks @ChristopherJHart

@sindresorhus if you have noticed multiple issues, can you document them?

@sindresorhus all of your comments have been addressed.


Support to React Context API

Some planned update?

@darioajr There shouldn't be anything from preventing you from implementing and using the React Context API in an Ignite project, but we currently do not have any plans to integrate it into Ignite itself as we use MobX-state-tree (and Redux in Andross) for solving the global data-store problem.


Correct IdentityProvider service's class name

Does not necessarily pose a problem, but helps IDEs, and, well... it was just plain wrong.

Kietel @DRvanR

Hrmmmms, shame they don't check if the class generated by the factory is actually an instance of the specified class... In any case, :+1:  good catch.


SVG vector graphics

Hi,
I recognized that one can only save the capture viewport as a png file. For high quality publications scalable vector graphics would be essential (svg). Otherwise I experience a huge quality drop after loading into adobe illustrator for instance.
Best,
Tolga

Hi,
This is the same issue as https://github.com/TissUUmaps/TissUUmaps/issues/3
The solution in TissUUmaps is to use a bigger resolution factor when capturing viewport (4, 8, etc.).
It is still not vectorial, but unfortunately we can not export in SVG for now, and it should be good quality for publication.


[FEAT] Resize image to fit flashcards review UI

If I add an image into the flash card, it won't fit well into the UI window. I have to constantly do horizontal scrolling to view its content properly.
For example, in the following screenshot, the horizontal scroll bar indicates that the embedded image is too large.

A question: do you specify the size of the image directly i.e. ![[image.png|100x100]]?
Related to #139.

A question: do you specify the size of the image directly i.e. ![[image.png|100x100]]?
Related to #139.

Yes I did. ![[Pasted_image.png|300]] in my case.

Yes I did. ![[Pasted_image.png|300]] in my case.

Nice, I'll fix this soon.
https://github.com/mgmeyers/obsidian-kanban/blob/main/src/components/MarkdownRenderer.tsx

Images are now being resized based on the ![[Pasted_image.png|300]] format. If no size is specified, the images are resized to fit the flashcard modal view.
Fix should be available in the next release.


Eliminate potential undefined behavior (RIPD-1685):

Under certain conditions, we could call memcpy or memcmp with a null source pointer. Even when specifying 0 as the amount of data to copy this could result in undefined behavior under the C and C++ standards.
Acknowledgements:
Ripple thanks Guido Vranken for responsibly disclosing these issues.
Bug Bounties and Responsible Disclosures:
We welcome reviews of the rippled code and urge researchers to responsibly disclose any issues that they may find. For more on Ripple's Bug Bounty program, please visit: https://ripple.com/bug-bounty

I find myself wondering if we should use ripple::memcopy in place of std::memcpy, where the former is:
void*
memcopy(void* dbegin, void const* dend, void const* sbegin, void const* send)
{
    auto d = static_cast<unsigned char*>(dbegin);
    auto de = static_cast<unsigned char const*>(dend);
    auto s = static_cast<unsigned char const*>(sbegin);
    auto se = static_cast<unsigned char const*>(send);
    size_t n = std::max<ptrdiff_t>(0, std::min(de-d, se-s));
    for (; n > 0; --n)
        *d++ = *s++;
    return d;
}

This accepts {nullptr, nullptr} source or target gracefully (no UB).  It also safely handles the case where the target range is not big enough to handle the source range by copying only the subset of the source that fits in the target.  Finally, because of modern optimizers, this will be just as efficient as std::memcpy.
This will take some modifications at the call site for each case to turn the size into a range.  Conversely, if we don't want to make that modification:
void*
memcpy(void* s1, const void* s2, size_t n)
{
    auto d = static_cast<unsigned char*>(s1);
    auto s = static_cast<unsigned char const*>(s2);
    for (; n > 0; --n, ++d, ++s)
        *d = *s;
    return s1;
}

Now we handle memcpy(nullptr, nullptr, 0) without UB with the same API, and no performance loss.

Considering that  delete p; is acceptable if p == nullptr I wish that the committee would just give us sensible semantics by explicitly allowing nullptr as the src of dst of memcpy, memcmp and and memset iff the size parameter is 0. :pray:
Back in the real world, I am forced to wonder if it's reasonable for us to banish std:memcpy and std::memset and use std::fill/std::fill_n and std::copy/std::copy_n as appropriate. I doubt it'll be any less efficient.
A quick review of our codebase (looking only at stuff under src/ripple) shows the state of the world:

API
Instances
Replacement

memcpy
70
std::copy and std::copy_n

memset
7
std::fill and std::fill_n

memcmp
6
std::lexicographical_compare

That's not that bad. There's 83 instances, and most are basically mechanical refactorings. Is it worth doing this?

Jenkins Build Summary
Built from this commit
Built at 20181108 - 05:59:42
Test Results

Build Type
Log
Result
Status

rpm
logfile
1139 cases, 0 failed, t: n/a
PASS :white_check_mark:

msvc.Debug
logfile
1136 cases, 0 failed, t: 616s
PASS :white_check_mark:

msvc.Debug, NINJA_BUILD=true
logfile
1136 cases, 0 failed, t: 634s
PASS :white_check_mark:

msvc.Debug -Dunity=OFF
logfile
1136 cases, 0 failed, t: 1264s
PASS :white_check_mark:

msvc.Release
logfile
1136 cases, 0 failed, t: 413s
PASS :white_check_mark:

gcc.Release -Dassert=ON, MANUAL_TESTS=true
logfile
915 cases, 0 failed, t: 6m6s
PASS :white_check_mark:

docs, TARGET=docs
logfile
1 cases, 0 failed, t: 0m1s
PASS :white_check_mark:

clang.Debug
logfile
1139 cases, 0 failed, t: 3m12s
PASS :white_check_mark:

gcc.Debug -Dcoverage=ON, TARGET=coverage_report, SKIP_TESTS=true
logfile
1139 cases, 0 failed, t: 16m59s
PASS :white_check_mark:

gcc.Debug
logfile
1139 cases, 0 failed, t: 3m26s
PASS :white_check_mark:

clang.Debug -Dunity=OFF
logfile
1139 cases, 0 failed, t: 9m43s
PASS :white_check_mark:

clang.Release -Dassert=ON
logfile
1139 cases, 0 failed, t: 5m43s
PASS :white_check_mark:

gcc.Debug -Dunity=OFF
logfile
1139 cases, 0 failed, t: 11m49s
PASS :white_check_mark:

gcc.Release -Dassert=ON
logfile
1139 cases, 0 failed, t: 6m6s
PASS :white_check_mark:

gcc.Debug -Dstatic=OFF
logfile
1139 cases, 0 failed, t: 3m26s
PASS :white_check_mark:

gcc.Debug -Dstatic=OFF -DBUILD_SHARED_LIBS=ON
logfile
1139 cases, 0 failed, t: 3m28s
PASS :white_check_mark:

gcc.Debug, NINJA_BUILD=true
logfile
1139 cases, 0 failed, t: 3m0s
PASS :white_check_mark:

clang.Debug -Dunity=OFF -Dsan=address, PARALLEL_TESTS=false, DEBUGGER=false
logfile
1139 cases, 0 failed, t: 10m0s
PASS :white_check_mark:

clang.Debug -Dunity=OFF -Dsan=undefined, PARALLEL_TESTS=false
logfile
1139 cases, 0 failed, t: 11m55s
PASS :white_check_mark:

@nbougalis I like the proposed replacement of memcpy and firends with std:: equivalents a lot. In fact, I think we should consider making part of the style guide. Other than the perf hit (which I'm skeptical is much at all) I really don't see a down side, and the up side is sane handling of the zero copy case.


Revert Change

what has been done:

Revert change at past 'test-Readme.md'
Update Bab.12 Basis Data - Sub-Bab: NoSQL

I'm sorry sir, but is this how it should be ?

di send ulang mas @boysatr93 - tanpa edit README.md


Vector fields docs

Would be good to add a simple page in the docs that describe how fmmax computes vector fields. The paper describes this to some detail, but even since then, fmmax has changed it's approach.
Some interesting details include...

FOMs used
Comparisons of methods (especially compared to their FOURIER counterparts)
When to use some vs others

We can start will a "brain dump" (it doesn't have to sound like a paper). But documenting this will help us keep things consistent.

Here's some good info:
https://github.com/facebookresearch/fmmax/blob/c6cd855fceb26fda5234ec704d1ea0cd0cbff6c9/src/fmmax/vector.py#L113-L130


create zalenium helm chart into incubator

from our current best practices and styles

depends on https://github.com/teracyhq/helm-charts/issues/10 https://github.com/teracyhq/helm-charts/issues/1

@hoavt make sure to review the content and verify the content by following the docs to run.

we're not going to create the helm chart for zalenium but use the official helm chart instead, so we need doc to be moved to the teracy-dev-k8s project.

and delete the zalenium helm chart from this repo.


Add Anchore to Secure Images

The secure images section is missing Anchore which provide a policy based image governance solution. Anchore is available both as an open source project and commercial offering.
www.anchore.com

Anchore is now included under Secure Images in v0.9.3


update to the latest args

stagehand specified an older args, and was causing other packages to resolve to a pre-1.0 args

Coverage decreased (-1.04%) to 82.743% when pulling 4cfc2b78bf0b5e6f1bfd8c1051915e33c32c67d1 on pubspec into a13df1a24690082d425434eecb4c1f2b18c7bd5c on master.

Coverage decreased (-1.04%) to 82.743% when pulling 4cfc2b78bf0b5e6f1bfd8c1051915e33c32c67d1 on pubspec into a13df1a24690082d425434eecb4c1f2b18c7bd5c on master.

I didn't know about the 2-dev branch :)
Looks like the args dep is already upgraded there.


Issue #135: hackishlyHidesInputAccessoryView not found on object of t…

…ype UIView
This PR fixes issues #135 and #154

Never mind, I see it is fixed in 1.0.8 but I was using 1.0.4.


How to preload the desock.so when running arm binary with qemu?

Hi!
I not sure if preeny can work well with other architectures for example arm.  What I'm trying to do is to 'desocket' an arm-based binary by preeny and to run it with qemu user mode.
And the problem occurred when I tried to preload the desock.so  to the binary and using qemu-arm to run it.  Auctually, I don't know how to preload the desock.so when working with qemu. Because it seems quite different from executing the binary itself.
I use the following command while making and the information of file desock.so also shown below.
make -i CC=arm-linux-gnueabi-gcc

apple@ubuntu:~/afl-qemu/preeny-master/arm-linux-gnueabi$ file desock.so
desock.so: ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, BuildID[sha1]=d121c381bfce288e8d7c9b36eae7ca1d4bda41dd, not stripped

Normally, I use the following command to run the arm-based binary with qemu. The indispensable -L parameter shows the prefix of the dependent libs path of the target binary which was dynamically linked.  When I export the LD_PRELOAD=xxx/desock.so, the -L didn't works anymore.
By the way, the binary would set up an HTTP server and wait for requests from sockets.
apple@ubuntu:squashfs-root$ qemu-arm -L . ./usr/sbin/httpd
sendto() error 2
[debug]add server push uri 3 video3.mjpg
[debug]add server push uri 4 video4.mjpg
gethostbyname:: Success

Is there anybody who can help me out?

If your libc supports LD_PRELOAD, you should be able to use the -E flag to
qemu to set it.
On Fri, Feb 19, 2021 at 3:46 AM jackfromeast<EMAIL_ADDRESS>wrote:

Hi!
I not sure if preeny can work well with other architectures for example
arm. What I'm trying to do is to 'desocket' an arm-based binary by preeny
and to run it with qemu user mode.
And the problem occurred when I tried to preload the desock.so to the
binary and using qemu-arm to run it. Auctually, I don't know how to
preload the desock.so when working with qemu. Because it seems quite
different from executing the binary itself.
I use the following command while making and the information of file
desock.so also shown below.
make -i CC=arm-linux-gnueabi-gcc
apple@ubuntu:~/afl-qemu/preeny-master/arm-linux-gnueabi$ file desock.so
desock.so: ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, BuildID[sha1]=d121c381bfce288e8d7c9b36eae7ca1d4bda41dd, not stripped
Normally, I use the following command to run the arm-based binary with
qemu. The indispensable -L parameter shows the prefix of the dependent
libs path of the target binary which was dynamically linked. When I export
the LD_PRELOAD=xxx/desock.so, the -L didn't works anymore.
By the way, the binary would set up an HTTP server and wait for requests
from sockets.
apple@ubuntu:squashfs-root$ qemu-arm -L . ./usr/sbin/httpd
sendto() error 2
[debug]add server push uri 3 video3.mjpg
[debug]add server push uri 4 video4.mjpg
gethostbyname:: Success
Is there anybody who can help me out?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/zardus/preeny/issues/80, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2LHF5B5LNY6GOEHUQD2HTS7Y6RXANCNFSM4X4ESI4Q
.

Hi, I am so sorry that I had lots of other work to do.
I tried your suggestion, but it seems didn't work. The output is shown below. I guess I am still missing some dependent lib that the symbol can't be resolved. But what is it?
apple@ubuntu:squashfs-root$ qemu-arm -L . -E LD_PRELOAD=/desock.so ./usr/sbin/httpd

./usr/sbin/httpd: symbol '__aeabi_unwind_cpp_pr0': can't resolve symbol

By the way, I didn't have the source code of the arm binary so I can't recompile.

I also tried this.
apple@ubuntu:squashfs-root$ qemu-arm -L . -E LD_PRELOAD=/home/apple/afl-qemu/preeny-master/arm-linux-gnueabi/desock.so  ./usr/sbin/httpd

./usr/sbin/httpd: symbol '__aeabi_unwind_cpp_pr0': can't resolve symbol


Chromecast support

Are there any plans of adding Chromecast (Since it was mentioned in the spec)

Hi,
sorry for replying so late. In the current state of the implementation we only support the single user agent mode, which means that there is no application specific logic executed on the presentation display. The content is just streamed to the presentation display (in our case using AirPlay or Miracast).
However, we welcome contributions of any kind that allow for more coverage of the API, in particular the support of the two user agent mode. We cannot give any information about the readiness of this request at the moment.
Since the Chromecast API / SDK is available for both of the currently supported platforms of cordova-plugin-presentation we really looking forward to support this device, too. As mentioned: contributions are more than welcome.
BR

@FranklinWaller FYI: The W3C Presentation (https://www.w3.org/TR/presentation-api/) will become a Recommendation soon (end of the year) and we will then publish a new version of the plugin that is fully compatible with the new version which also bring some new features which are not supported in the current version which implements an older version of the Presentation API Specification (https://www.w3.org/2014/secondscreen/presentation-api/20140721/)


Fix Agilent MS1 centroided spectra erroneously treated as SIM

Fixed incorrect MS1 chromatograms from some Agilent centroided data (reported by Darshak)

Actually, this fix breaks "AgilentGCEIChromatogramTest" because the isolation window is used for something related to MSe.
I will keep investigating.


feat: argument replacements

Description
After the required to Graph-Go-Tools in the PR here, we can now look to fix the issue with customIntScalars described here. The goal of this PR is to adjust the ArgumentConfiguration so that the upstream origin has an understanding of which arguments have been replaced with the Int or Float types.

Checklist

[x] run make test
[x] PR title must follow conventional-commit-standard
[x] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message and code follows the Code of conduct

@jensneuse, I've added the PR here with my current efforts. Once it got to debugging the requests being sent to the Go server, my skills were limited due to not debugging the Wundergraph server before.
I've added the changes to ArgumentConfiguration which looks like it is set up correctly during the introspection however there's a bug somewhere which I'm missing.

Hey @fiam, hope you had a nice New Year! Just double checking where this fits on your timelines? Not too sure about how to proceed with this and it's blocking us from using Wundergraph for our application.

@OLingard Apologies for the delay and thanks for the heads up! We've discussed this feature and we're more than happy to accept your contribution. Could you please fix the conflicts so we can move forward with the review? Thanks!

Hi @fiam, updated so it is in sync with the latest main.

I've added the changes to ArgumentConfiguration which looks like it is set up correctly during the introspection however there's a bug somewhere which I'm missing.

Just re-adding the comment I made to Jens above, hopefully should be a minor bug but my Wundergraph knowledge isn't deep enough to fully crack the final bug and unfortunately I'm on holiday for a couple weeks from tomorrow. I'll keep an eye on this thread though and try and make any changes needed.

Hi @fiam, updated so it is in sync with the latest main.

I've added the changes to ArgumentConfiguration which looks like it is set up correctly during the introspection however there's a bug somewhere which I'm missing.

Just re-adding the comment I made to Jens above, hopefully should be a minor bug but my Wundergraph knowledge isn't deep enough to fully crack the final bug and unfortunately I'm on holiday for a couple weeks from tomorrow. I'll keep an eye on this thread though and try and make any changes needed.

Thanks for the quick reply! Could you please elaborate on that bug? Is it uncovered by the test suite? If we can easily reproduce it, we'll find a quick way faster.

Hi @fiam, updated so it is in sync with the latest main.

I've added the changes to ArgumentConfiguration which looks like it is set up correctly during the introspection however there's a bug somewhere which I'm missing.

Just re-adding the comment I made to Jens above, hopefully should be a minor bug but my Wundergraph knowledge isn't deep enough to fully crack the final bug and unfortunately I'm on holiday for a couple weeks from tomorrow. I'll keep an eye on this thread though and try and make any changes needed.

Thanks for the quick reply! Could you please elaborate on that bug? Is it uncovered by the test suite? If we can easily reproduce it, we'll find a fix way faster.

Hey @fiam, sorry for the slow response, been out of the country for the past weeks. I've updated the PR with the latest changes from main.
Regarding the bug, it looks like the config inside the generated wundergraph.config.json is what is expected when a custom scalar is provided. The argument configuration of an affected field looks like:
        {
          "typeName": "Query",
          "fieldName": "testField",
          "argumentsConfiguration": [
            {
              "name": "id",
              "sourceType": 1,
              "sourcePath": [],
              "renderConfiguration": 0,
              "renameTypeTo": "ID"
            }
          ],
          "disableDefaultFieldMapping": false,
          "path": [],
          "requiresFields": [],
          "unescapeResponseJson": false
        }

However in the debugTransport, it still doesn't seem to edit the origin request to include the renamed argument type. In other words, I still get this error returned from the origin:
errors": Array[1][
    {
      "message": "Validation error of type VariableTypeMismatch: Variable type 'Int!' doesn't match expected type 'ID!' @ 'testField'",
      "locations": Array[1][
        {
          "line": 1,
          "column": 61
        }
      ],
      "extensions": {
        "classification": "ValidationError"
      }
    }
  ],

I'm replicating this with my upstream server so I'm happy to jump on a call to explain this further and to debug this together.

Thanks for the update @OLingard. This week we're a bit busy preparing the beta, I'll take a look no later than next week.

Hi @fiam, is there any update into timelines on this?

Hi @fiam, sorry to push, just trying to gather timelines on this one, is there any update?

Hi @OLingard - Sorry about the delay, this fell through the cracks and we haven't given it a good look yet. Do you have a repro that I can run myself and try to fix the remaining issue? That would help speed things up a lot. Thanks!

Hi @fiam, I've added a quick demo here showcasing the issue here: https://github.com/OLingard/Wundergraph-Bug-Showcase. I'd just copy the example into the examples folder in the Wundergraph repository to try it out.
As mentioned prior I'm not on top of the inner working of the code base so I might be missing something in my set up or something else which is simple.

Hi @fiam, I've added a quick demo here showcasing the issue here: OLingard/Wundergraph-Bug-Showcase. I'd just copy the example into the examples folder in the Wundergraph repository to try it out.
As mentioned prior I'm not on top of the inner working of the code base so I might be missing something in my set up or something else which is simple.

Thanks a lot, that's super helpful!

Hi @OLingard
I have made additional fixes, and now no need to modify a query, it should work as is
query HorizonAndHygraphDemoProduct($sku: Int!) {
     horizon_product(sku: $sku, strict: false) {
         title
     }
}

Hi @fiam, thanks for looking at this! Almost reading to go now, one SKU which should return data is 14187821. I think we're close however there's an issue with the query being passed to the backend. The stack trace of a request using the operation in the demo is as follows:
--- ClientRequest start ---

GET /operations/ProductDemo?sku=14187821 HTTP/1.1
Host: localhost:9991
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7
Accept-Encoding: gzip, deflate, br
Accept-Language: en-GB,en-US;q=0.9,en;q=0.8
Cache-Control: max-age=0
Connection: keep-alive
If-None-Match: W/"2778056214337555698"
Sec-Ch-Ua: "Chromium";v="110", "Not A(Brand";v="24", "Google Chrome";v="110"
Sec-Ch-Ua-Mobile: ?0
Sec-Ch-Ua-Platform: "macOS"
Sec-Fetch-Dest: document
Sec-Fetch-Mode: navigate
Sec-Fetch-Site: none
Sec-Fetch-User: ?1
Upgrade-Insecure-Requests: 1
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36

--- ClientRequest end ---

2023-03-07T10:19:25+00:00 INFO: incoming request {"component":"@wundergraph/server","reqId":"314274f0-5460-b941-e29f-381d4ebf0427","req":{"method":"POST","url":"/global/httpTransport/onOriginRequest","hostname":"localhost:9992","remoteAddress":"::1","remotePort":56364}}
onOriginRequest { variables: { sku: 14187821, a: false } }
2023-03-07T10:19:25+00:00 INFO: request completed {"component":"@wundergraph/server","reqId":"314274f0-5460-b941-e29f-381d4ebf0427","res":{"statusCode":200},"responseTime":6.246208995580673}

--- DebugTransport ---

Request:

POST /graphql HTTP/1.1
Host: horizon-api.www.coggles.com
accept: application/json
content-type: application/json
x-request-id: 314274f0-5460-b941-e29f-381d4ebf0427

{"variables":{"sku":14187821,"a":false}}

Duration: 228 ms

Response:

HTTP/2.0 400 Bad Request
Connection: close
Access-Control-Allow-Credentials: true
Access-Control-Allow-Headers: Content-Type, X-Captcha-Type, X-Captcha-Response, X-Force-Rate-Limit, X-Preview-Site-State-Key, X-Chumewe-User, X-Chumewe-Session, X-Horizon-Client
Access-Control-Allow-Methods: POST, OPTIONS
Access-Control-Allow-Origin: https://www.coggles.com
Access-Control-Max-Age: 86400
Content-Type: application/json
Expires: Thu, 01 Jan 1970 00:00:00 GMT
Strict-Transport-Security: max-age=31536000
Vary: Origin
X-Content-Type-Options: nosniff

No query provided

--- DebugTransport

The request still works for queries not using the custom int mapping such as:
query CollectionDemo($page: horizon_PagePath!) {
    horizon_page(path: $page) {
        title
    }
}

With a page variable of /woman.
A stack trace of running this operation returns:
--- ClientRequest start ---

GET /operations/CollectionDemo?page=/woman HTTP/1.1
Host: localhost:9991
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7
Accept-Encoding: gzip, deflate, br
Accept-Language: en-GB,en-US;q=0.9,en;q=0.8
Cache-Control: max-age=0
Connection: keep-alive
If-None-Match: W/"16680724490209898961"
Sec-Ch-Ua: "Chromium";v="110", "Not A(Brand";v="24", "Google Chrome";v="110"
Sec-Ch-Ua-Mobile: ?0
Sec-Ch-Ua-Platform: "macOS"
Sec-Fetch-Dest: document
Sec-Fetch-Mode: navigate
Sec-Fetch-Site: none
Sec-Fetch-User: ?1
Upgrade-Insecure-Requests: 1
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36

--- ClientRequest end ---

2023-03-07T10:26:05+00:00 INFO: incoming request {"component":"@wundergraph/server","reqId":"309cba00-6260-151e-fda9-e9ec03704dd4","req":{"method":"POST","url":"/global/httpTransport/onOriginRequest","hostname":"localhost:9992","remoteAddress":"::1","remotePort":56444}}
onOriginRequest {
  variables: { page: '/woman' },
  query: 'query($page: PagePath!){horizon_page: page(path: $page){title}}'
}
2023-03-07T10:26:05+00:00 INFO: request completed {"component":"@wundergraph/server","reqId":"309cba00-6260-151e-fda9-e9ec03704dd4","res":{"statusCode":200},"responseTime":4.431583002209663}

--- DebugTransport ---

Request:

POST /graphql HTTP/1.1
Host: horizon-api.www.coggles.com
accept: application/json
content-type: application/json
x-request-id: 309cba00-6260-151e-fda9-e9ec03704dd4

{"variables":{"page":"/woman"},"query":"query($page: PagePath!){horizon_page: page(path: $page){title}}"}

Duration: 46 ms

Response:

HTTP/2.0 200 OK
Access-Control-Allow-Credentials: true
Access-Control-Allow-Headers: Content-Type, X-Captcha-Type, X-Captcha-Response, X-Force-Rate-Limit, X-Preview-Site-State-Key, X-Chumewe-User, X-Chumewe-Session, X-Horizon-Client
Access-Control-Allow-Methods: POST, OPTIONS
Access-Control-Allow-Origin: https://www.coggles.com
Access-Control-Max-Age: 86400
Content-Type: application/json
Expires: Thu, 01 Jan 1970 00:00:00 GMT
Strict-Transport-Security: max-age=31536000
Vary: Origin
Vary: Accept-Encoding
X-Content-Type-Options: nosniff

**Correct Returned Data**

--- DebugTransport

Once this bug is good, all will be good on my side! Again thanks for fixing the previous bugs, much appreciated.

Hi @OLingard
Could you clarify how you were testing these changes?
As this is unmerged and not released we usually use testapps/default or tesapps/simple to test such changes with changed sdk
In order to test this change with the simple test app

add your api and query to the simple test app
make sure to clean .wundergraph/cache and .wundergraph/generated folders within simple test app
run make
run make wunderctl
after that you will be able to run scripts from testapps/simple/package.json

On this branch with the latest fixes I see such query to upstream
{"variables":{"sku":14187821,"a":false},"query":"query($sku: SKU!, $a: Boolean!){horizon_product: product(sku: $sku, strict: $a){title}}"}

Yep you're completely right! I had created a new example in the examples folder to test it out whilst changing the sdk package to point to the file system.
Just for the future, it might be worth adding some documentation in the contributing guide about this. It wasn't clear to me how to run and debug a local test.
This works as expected after following your instructions, thanks so much!


routerrpc: adapt to changed interfaces of routing subsystem

Needs a rebase!

@Roasbeef rebased ptal

Fails travis:
    lnd_test.go:107: lnd finished with error (stderr):
        exit status 2
        panic: reflect: call of reflect.Value.Set on zero Value

@Roasbeef bug fixes, ptal


Rounded edges on Always On Top indicator

Description of the new feature / enhancement
The Always On Top indicator borders should be rounded on Windows 11.

Scenario when this would be used?
Windows 11 has switched to rounded edges, and it is only fitting that the Always On Top borders should be consistent with its UI design.
Supporting information
No response

/dup #15284


add option to disable route continue enforce

fix https://github.com/VictoriaMetrics/operator/issues/615
add option disableRouteContinueEnforce to allow canceling the behavior for VMAlertmanagerConfig that always enforce first-level route continue to true

Thanks for contribution!


tflite: java wrapper for xnnpack delegate

I've implemented a java wrapper for tflite xnnpack delegate (analogous to gpu delegate)
Usage example (Kotlin):
import org.tensorflow.lite.xnnpack.XNNPackDelegate

...

val xnnOptions = XNNPackDelegate.Options()
xnnOptions.setNumThreads(4)

val xnnDelegate = XNNPackDelegate(xnnOptions)!! // create the delegate
interpreter.modifyGraphWithDelegate(xnnDelegate) // register the delegate

@googlebot I signed it!

Hi Denis, thanks for the proposal.
We're still exploring how best to expose the XNNPACK delegate. Ideally we want this integrated in an automatic way that doesn't require explicit user interaction. Stay tuned for more details, but for now we probably won't be exposing the Java API directly.


(Crystal) formats integer divison incorrectly

Describe the issue
Using // in crystal will make the highlighter mark the rest of the file.
In crystal is // used for integer division.
Code:
def something()
    something // 4
end

Which language seems to have the issue?
Crystal
Are you using highlight or highlightAuto?
highlight
Sample Code to Reproduce
def something()
    something // 4
end

Expected behavior
The expected behavior is to not mark the rest of the code with the color green.
Additional context
Nope

The trick here would probably be to introduce a new mode rule that only matches the literal // (with no scope, so as not to color it)... we only want to prevent It from being mis-recognized by the regex mode rule.

Yeah, to be a valid regex it needs to be at least 1 character between the // otherwise it is invalid and is thereby integer divison

Hi, I want to contribute but I don't know how to add crystal in tools/developer.html to test. Anyone can help me out?

./build -t browser crystal


nixos-rebuild: allow passing --log-format

This is benefitial when using nix-output-monitor: Now one can use nixos-rebuild switch --log-format internal-json -v |& nom --json.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

One thing I notice is that --log-format is only known by nix3 cli.

I can't reproduce that:
➜ nix-build -A hello --log-format internal-json
@nix {"action":"start","id":9579568071442432,"level":6,"text":"querying info about missing paths","type":0}
@nix {"action":"stop","id":9579568071442432}
@nix {"action":"start","id":9579568071442433,"level":0,"text":"","type":102}
@nix {"action":"start","id":9579568071442434,"level":0,"text":"","type":104}
@nix {"action":"start","id":9579568071442435,"level":0,"text":"","type":103}
@nix {"action":"result","fields":[0,1,0,0],"id":9579568071442434,"type":105}
@nix {"action":"result","fields":[0,0,0,0],"id":9579568071442435,"type":105}
@nix {"action":"result","fields":[101,0],"id":9579568071442433,"type":106}
@nix {"action":"result","fields":[100,0],"id":9579568071442433,"type":106}
@nix {"action":"start","id":9579568071442436,"level":6,"text":"querying info about missing paths","type":0}
@nix {"action":"stop","id":9579568071442436}
@nix {"action":"result","fields":[0,0,0,0],"id":9579568071442434,"type":105}
@nix {"action":"result","fields":[0,0,0,0],"id":9579568071442435,"type":105}
@nix {"action":"result","fields":[101,0],"id":9579568071442433,"type":106}
@nix {"action":"result","fields":[100,0],"id":9579568071442433,"type":106}
@nix {"action":"stop","id":9579568071442435}
@nix {"action":"stop","id":9579568071442434}
@nix {"action":"stop","id":9579568071442433}
/nix/store/phbfakv2rij3zwp1an9pvvr7qhnxiy2y-hello-2.12.1

Oh, I tested with --log-format json-internal

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2337


App crashes when tapping Sponsors

Tap the hamburger menu.
Tap Sponsors.
Crash.

Pixel 2 XL, Android 9

This has been fixed.


Bug: Two equal tags with different capitalisation lead to 500 server errors

When some bookmarks have tag 'freebsd' and another has a tag 'FreeBSD', than adding new bookmarks with either the tag 'freebsd' or 'FreeBSD' returns a Server Error (500)

I already noticed this, its very likely that this was introduced with #45 . In the meantime you can fix this by removing the duplicate tag in the admin. At least in my case one of the tags was unused and was thus easy to delete.
At least #45 should ensure that it's not possible anymore to create duplicates with different capitalization.

I already noticed this, its very likely that this was introduced with #45 . In the meantime you can fix this by removing the duplicate tag in the admin. At least in my case one of the tags was unused and was thus easy to delete.
At least #45 should ensure that it's not possible anymore to create duplicates with different capitalization.

Thanks ! In the admin I deleted the tag 'freebsd' and now I can use the tag 'FreeBSD' again, without 500 errors :)

Thanks ! In the admin I deleted the tag 'freebsd' and now I can use the tag 'FreeBSD' again, without 500 errors :)


Error Alignement with Commonalities

Problem description
Following Commonalities rules:
To be applied:
Error 429 must be added for location-retrieval (already present in location-verification & geofencing)
Errors 410 & 429 must be added to the callback endpoint in Geofencing
Error 409 must be added for POST /subscriptions in Geofencing
To be discussed:
Error code 500 & 503 could be removed but we need a decision for all 3 APIs for consistency
Error code 429 could be removed for GET & DELETE subscriptions in Geofencing
Expected behavior
Update yamls
Alternative solution

Additional context

Why would we remove 500 and 503 errors? There can be system level issues on the server side. Thank you.

I see, thank you @bigludo7


[#69] Added javadocs

fixes #69

yay.. got to the bottom :)
I trust you'll choose the right path based on feedback noted, as you often do. Ping me if you need any clarifications, otherwise merge when you are ready!


Feature request: reuse password tokens for their lifetime

First, thank you for this work. We'd like to use it to eliminate needing to manually manage and rotate mysql  passwords when in the AWS environment.
I'm concerned that because a new password token is generated on every point of need, that we will run into the AWS 200-per-second rate limit for our production uses, which will spin up dozens of ECS instances, each with upwards of 100 connections. This concern would be alleviated if password tokens were cached and reused until expiry, which is what Amazon recommends.
I opened a similar feature request with the haines/pg-aws_rds_iam project, who implemented token caching and reuse.  Since this project was inspired by the pg project, could something similar be added to this gem to cache and reuse tokens until expiry.
Full disclosure: I took a stab at adding IAM support directly in the mysql2 gem.. Upstream maintainers haven't commented on it, and like the pg maintainer, may not want AWS-specific code in the gem like this, hence being in a gem as you have may be deemed the best approach.

The https://github.com/haines/pg-aws_rds_iam gem added support for token reuse in the new 0.7.0 release last week, via commit https://github.com/haines/pg-aws_rds_iam/commit/e551a07320b0f5e0a244eb1e57e7c49f15bc0765.  This may be a useful pattern for this gem as well.

Hey @matt-domsch-sp, thank you for the feature request. I was working on it over the weekends #5

@matt-domsch-sp, release it under 0.2.0.
Thanks again!

Thank you!


[sram_ctrl] Initial part of sival testplan

This PR isn't all that clever: it's just re-arranging things to match the "sival-enabled" format that we're expecting to use. This adds feature/sv_stage tags to existing tests, but doesn't define any new ones. Those can come next, but I thought it was worth splitting out reviewing the refactor and reviewing new proposed tests.

CHANGE AUTHORIZED: hw/ip/sram_ctrl/data/sram_ctrl.hjson

CHANGE AUTHORIZED: hw/ip/sram_ctrl/data/sram_ctrl.hjson


Injecting dependencies into additive scene

I am not talking about scene that loaded with SceneManager.LoadScene or ZenjectSceneLoader.
My case is the scene loaded on editor.
The hierarchy is like the following:

The active scene is Scene 1 as indicated with bold text.
Scene 1 is doing fine, but Scene 2 is not.
Scene 1's dependencies are injected as expected.
Scene 2's dependencies are not injected.
Is Zenject already support this case?

That should work fine.  However, I should note that any bindings in Scene1 will only be available within Scene1 and similarly for Scene2.  Is that not working for you?

Sorry,  I forgot to mention that I need it to behave like ZenjectSceneLoader with Child mode.
In my current case, I need Scene 1 bindings to be available within Scene 2. Currently, I have Installer in Scene1 and no installer in Scene 2.
I also would like to know if it is possible to have Scene 1 bindings & Scene 2 bindings to be available for each other.

You can have Scene 1 and Scene 2 share bindings by making Scene 1 a scene decorator for Scene 2.
Currently though, there isn't a lot of good support for using Unity's multi-scene editing stuff and then setting up scene parenting relationships at design time.  Right now, if you want to make one scene a child of another, you need to use ZenjectSceneLoader and load the scene dynamically.  We've been discussing some approaches to design-time support for this and will have more to say on that soon (I will post the details of that here)

Just wanted to mention that design-time support using Unity's multi-scene editing stuff is not submitted on develop branch, as mentioned in in issue #164, so that might help address your needs here.  I'm going to document it more this weekend hopefully

If you still have issues with version 4.6 please comment again here and I'll re-open this issue


Blurry Render at small sizes

Really appreciate the library.  I need to render barcodes at sizes below a width of '1' as set in the options.  When I use fractions such as .9 or .8, the data-uri renders very blurry.  Is there anything that can be done programmatically to ensure clarity at smaller widths?

That would be impossible. One line needs to be one pixel or more. If you want to understand why you could read more about computer graphics, specifically pixels.

I didn't dig into your code in order to make comparisons, but I ended up using this older jQuery [barcode generator]https://github.com/jbdemonte/barcode library and it rendered the Code39 barcodes at a smaller width, which was perfect for the ID cards they needed to be printed on.  Thanks for the article though ;-)

That project is using seems to be using Scalable Vector Graphics to render the image while this project uses PNG (since the plan have always been that this project should be used at the web). One way you could get around this is to render a barcode with a wider width and then just use it but scale it down, should do the job.


Bumping appium java-client for selenium 3.3.1 compatibility

[x] By placing an X in the preceding checkbox, I verify that I am a PayPal employee or
I have signed the Contributor License Agreement

👍  thanks @elhuang .. will merge this today


remove accidental org.junit.* imports

Description
Clean up a few dangling org.junit.* imports. Given that we're running on TestNG, they seem accidental.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
No
Does this PR fix a zero-downtime upgrade introduced earlier?
No
Does this PR otherwise need attention when creating release notes? Things to consider:
No

Codecov Report

Merging #6404 (eeabeda) into master (1beaab5) will decrease coverage by 1.46%.
The diff coverage is 56.80%.

@@            Coverage Diff             @@
##           master    #6404      +/-   ##
==========================================
- Coverage   66.44%   64.98%   -1.47%
==========================================
  Files        1075     1318     +243
  Lines       54773    64104    +9331
  Branches     8168     9329    +1161
==========================================
+ Hits        36396    41659    +5263
- Misses      15700    19477    +3777
- Partials     2677     2968     +291

Flag
Coverage Δ

unittests
64.98% <56.80%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/broker/api/resources/PinotBrokerDebug.java
0.00% <0.00%> (-79.32%)
:arrow_down:

...ot/broker/broker/AllowAllAccessControlFactory.java
71.42% <ø> (-28.58%)
:arrow_down:

.../helix/BrokerUserDefinedMessageHandlerFactory.java
33.96% <0.00%> (-32.71%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ava/org/apache/pinot/client/AbstractResultSet.java
66.66% <0.00%> (+9.52%)
:arrow_up:

.../main/java/org/apache/pinot/client/Connection.java
35.55% <0.00%> (-13.29%)
:arrow_down:

...inot/client/JsonAsyncHttpPinotClientTransport.java
10.90% <0.00%> (-51.10%)
:arrow_down:

...not/common/assignment/InstancePartitionsUtils.java
73.80% <ø> (+0.63%)
:arrow_up:

...common/config/tuner/NoOpTableTableConfigTuner.java
100.00% <ø> (ø)

...ot/common/config/tuner/RealTimeAutoIndexTuner.java
100.00% <ø> (ø)

... and 1149 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37f2e28...eeabeda. Read the comment docs.

Codecov Report

Merging #6404 (eeabeda) into master (1beaab5) will decrease coverage by 1.46%.
The diff coverage is 56.80%.

@@            Coverage Diff             @@
##           master    #6404      +/-   ##
==========================================
- Coverage   66.44%   64.98%   -1.47%
==========================================
  Files        1075     1318     +243
  Lines       54773    64104    +9331
  Branches     8168     9329    +1161
==========================================
+ Hits        36396    41659    +5263
- Misses      15700    19477    +3777
- Partials     2677     2968     +291

Flag
Coverage Δ

unittests
64.98% <56.80%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/broker/api/resources/PinotBrokerDebug.java
0.00% <0.00%> (-79.32%)
:arrow_down:

...ot/broker/broker/AllowAllAccessControlFactory.java
71.42% <ø> (-28.58%)
:arrow_down:

.../helix/BrokerUserDefinedMessageHandlerFactory.java
33.96% <0.00%> (-32.71%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ava/org/apache/pinot/client/AbstractResultSet.java
66.66% <0.00%> (+9.52%)
:arrow_up:

.../main/java/org/apache/pinot/client/Connection.java
35.55% <0.00%> (-13.29%)
:arrow_down:

...inot/client/JsonAsyncHttpPinotClientTransport.java
10.90% <0.00%> (-51.10%)
:arrow_down:

...not/common/assignment/InstancePartitionsUtils.java
73.80% <ø> (+0.63%)
:arrow_up:

...common/config/tuner/NoOpTableTableConfigTuner.java
100.00% <ø> (ø)

...ot/common/config/tuner/RealTimeAutoIndexTuner.java
100.00% <ø> (ø)

... and 1149 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37f2e28...eeabeda. Read the comment docs.


fix(material/tabs): avoid timeouts in background tabs

The tabs have a couple of requestAnimationFrame calls when checking for the size/position of elements which can cause tests to hang when they're in a background tab. The problem is that browsers block requestAnimationFrame when the browser is out of focus and test harnesses will wait for the call to resolve.
These changes switch to NgZone.onStable in an attempt to resolve the issue.
Fixes #23964.

Can we merge it?


CupertinoSliverNavigationBar border

Is there a way to either remove or edit navbar's bottom border using CupertinoSliverNavigationBar? I've seen it is possible to do this with standard Cupertino's navigation bar CupertinoNavigationBar. I checked the documentation and apparently there's no way to do so.

I'm note sure what you mean , but you may want to refer to this link

https://stackoverflow.com/questions/49015038/removing-the-drop-shadow-from-a-scaffold-appbar-in-flutter

I searched 4 hours because I was mislead to think there are two app bars.

I'm building my app using CupertinoSliverNavigationBar without using the default navbar. Here's my code:
@override   Widget build(BuildContext context) {     return new Material(         child: new Container(       color: Colors.white,       child: new CustomScrollView(         slivers: <Widget>[           new CupertinoSliverNavigationBar(             largeTitle: new Text("Top Books"),             backgroundColor: Colors.transparent,           ),           new TopBooksCollectionList()         ],       ),     ));
This is the navbar's bottom border I'm talking about:

Yes, you can try using elevation: 0.0 in that Navigation bar widget. See if it works...

It doesn't work, as you can see in the documentation (https://docs.flutter.io/flutter/cupertino/CupertinoSliverNavigationBar-class.html) there's no this property

Ah you're right, it's not in the API currently. Though it should be trivial to add if anyone wants to send us a PR :)  (e.g. have https://github.com/flutter/flutter/blob/4cd5870ecef50fbf4fd7e681cf327897f0695abe/packages/flutter/lib/src/cupertino/nav_bar.dart#L267 also pass in a border and have CupertinoSliverNavigationBar take in a border which defaults to _kDefaultNavBarBorder)


No key assigned to instance created from Image

I have created an image and assigned it to auto scaling and it is creating a key while building image but it is not assigning the key to the instances created from auto scaling group. It is not assigning even default key also and I am using the latest gem.

Hey!
You need to  configure your launch configuration (used by the auto scaling group) with that option.
http://docs.aws.amazon.com/sdkforruby/api/Aws/AutoScaling/Client.html#create_launch_configuration-instance_method
So in attribute "options" here https://github.com/chef/chef-provisioning-aws/blob/master/lib/chef/resource/aws_auto_scaling_group.rb pass a key_name in the hash.
Cheers


Refactor register method and specs

Refatora metodo register e cria e edita os testes.

I've prepared a stage to preview changes. Open stage or view logs.

Coverage increased (+0.9%) to 77.763% when pulling cc2cd8352bef54726930257195e2dba7bf250a91 on henriquegeek:refactor_register_method_and_specs into 88f04f21b91c60f066d23fd2cbf11cd7360d9da2 on gorails:master.

Coverage increased (+1.5%) to 78.351% when pulling b19ede43dd1990f00831f9777528489b47523f55 on henriquegeek:refactor_register_method_and_specs into 88f04f21b91c60f066d23fd2cbf11cd7360d9da2 on gorails:master.


nalbatahighschool

@aminulidev Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.


Added export maps button

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#3138  👈
#3137
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tommylau523 and the rest of your teammates on  Graphite

Merge activity

Sep 6, 1:12 PM EDT: @tommylau523 started a stack merge that includes this pull request via Graphite.


langauge server will not start on flow-cli later then  0.39.1

When starting my editor (nvim) with flow-cli versions later then 0.39.1 my editor just hangs and will not start lsp.

flow-cli version 0.39.1 and 0.39.2 does not work on vscode either.
The flow-cli dependency cannot be found on vscode.
Also inline comment and auto-complete seems to be gone as well for these flow-cli versions.

@bjartek there were a bunch of changes we introduced in the latest version of LS. So can you make sure the changes are reflected in the LS client.
@Bamthelearner Which version of vscode extension do you have? please make sure it's the latest.

@bjartek there were a bunch of changes we introduced in the latest version of LS. So can you make sure the changes are reflected in the LS client.
@Bamthelearner Which version of vscode extension do you have? please make sure it's the latest.

Thank you!
I am on v1.0.4, I think that's the latest version?

@Bamthelearner it is. Let me move this to the vscode repo as it might be related to that. @DylanTinianov might have some more questions.


[docs] Improve favicon

Closes #16627
https://realfavicongenerator.net/favicon_checker?protocol=https&site=material-ui.com has reported two interesting issues:

Fix the squareness of the icons
Add a meta for iOS

Browsers cache favicons aggressively, we might not see the change before a month or two.

I noticed this as well for the azure org. Should we square the logo in general?

Yes, I think that we should square the logo in general. There are two assets in the repository:

brand.png: this is the assets we are using in all/most of the platforms.
logo.png: this is equivalent to the raw format.


Matter Object toJson() throws exception

So far no solution on my forum thread: https://phaser.discourse.group/t/matterjs-and-tojson/443
Calling toJson() on MatterJS Objects results in the exception:
Uncaught TypeError: Cannot read property ‘position’ of undefined
at MatterSprite.get [as x] (phaser.js:166821)
at Object.ToJSON (phaser.js:94119)
at MatterSprite.toJSON (phaser.js:11382)
at JSON.stringify ()

This works fine for me in both 3.15 and master branch:
var block = this.matter.add.sprite(400, 300, 'block');

var data = block.toJSON();

console.log(data);

It seems to happen when the Scene that the sprite is added in has been stopped. I'm saving all game objects in the scene when switching to the main menu. Calling toJSON() before stopping the current scene seems to work fine. Is that intended behaviour?

That's because the Sprite no longer has a physics body, as the Scene has been stopped and the world cleared, so it can't read the x/y position from the body. This is too far outside the bounds of acceptable use to warrant changing I'm afraid.


Ignore invalid full wildcards for cache_rule cache_key includes/excludes

Wildcards for the include and exclude values for cache keys need to be set using the ignore rules. Setting the value using include or exclude can cause unexpected behaviors. This addresses this outstanding bug by adding new validation to the schema.
Implementation:

Adds new validation to the query_key schema for cache_key in cache_rules

looks like this new validator is going to break expected functionality here - https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/internal/framework/service/rulesets/resource.go#L524-L538

This was mischaracterized as a problem that needed additional validation. It turns out everything is functioning exactly as it should. There is no need for this PR. Closing. :)


Added display text to the website when there are no matches to the filter.

Fixes

Fixes #295  by @Murdock9803

Description
This pull request addresses the issue where no resources are displayed when certain filters are applied. With this PR, there is a message being displayed indicating that no resources are available for the selected filters, preventing any user confusion.
Technical details

I added a function noResourcesText in listing.js to check if any resources are available based on the selected filters.
A text ("No resources are matching these filters")  is displayed when no matching resources are found.
message is hidden when at least one resource is displayed on the screen.

Tests
I viewed the website in my localhost after implementing changes and ensured the text was displayed only when selected filters don't have a respective resource available.
Screenshots
Problem

Solution

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Queen-codes the gemfile.lock file needs to be there in the codebase. For more context - context

@Queen-codes the gemfile.lock file needs to be there in the codebase. For more context - context

ohhhh. i understand now. i completely misunderstood. thank you.


fix dropping front block in BlockBuf

if remaining bytes is 0 for front block, then BlockBuf::drop always pops front block.

Ah, good call. Thanks.


Updated EBI input tutorial

Minor updates:

fixed renaming the columns
updated history and workflow
workflow tests added

Hmm, the tests don't produce .yml file or anything in the test-data folder...

Tested it and works well. I don't understand the error. The -test.yml file exists. @hexylena  is it something to do with the parentheses in the workflow name?

Yep, linting issue was down to trying to find files with that extension, I used .grep() and failed to escape the filename first.


[Package Request]: Godot 4

How can we help?
I would like someone else to build the manifest.
Please read and ensure the following

[X] The installer meets the above requirements

Please provide the following information
Download Page Url: https://godotengine.org/download/windows/
Publisher: Godot
Package Name: Godot
Description: Multi-platform 2D and 3D game engine
Package Version: 4.1.3
Installer URL: https://github.com/godotengine/godot/releases/download/4.1.3-stable/Godot_v4.1.3-stable_win64.exe.zip
### Tasks

@Bot-Kerem Could you please try GodotEngine.GodotEngine? Is that package you are looking for?
If it is, I'm glad to help updating the manifest.

Related https://github.com/microsoft/winget-pkgs/pull/107422


Stores array of folder configuration

Is your feature request related to a problem? Please describe.
Trying to load store files from multiple folders, I have found that the feature does not support the same configuration as components.
Describe the solution you'd like
Allow stores configuration in nuxt.config.js to be able to load store modules from multiple folders.
{
  stores: ["~/store", "~/mylib/store"]
}

Describe alternatives you've considered
Thought of using soft links but they are a pain to maintain.
Additional context
See https://nuxtjs.org/docs/configuration-glossary/configuration-components/#overwriting-components

Anyone has insights on this?
Can I do a PR to add the feature?
Will read up on that.