Unable to find library

t:\>vcpkg list | rg zlib
zlib:x64-windows-static     1.2.11           A compression library
zlib:x86-windows-static     1.2.11           A compression library

t:\>vcpkg_cli probe zlib
Failed:  Could not find library in vcpkg tree Unable to get OUT_DIR

t:\>vcpkg_cli -t x86-windows-static probe zlib
Failed:  this vcpkg build helper can only find libraries built for the MSVC ABI.

t:\>vcpkg_cli -t x86-windows probe zlib
Failed:  this vcpkg build helper can only find libraries built for the MSVC ABI.

(If you're here because of an nmake error in libz-sys on nightly, maybe this is interesting: https://github.com/alexcrichton/libz-sys/pull/18)
If you are looking at the git version of libz-sys, the vcpkg changes have not been published on crates.io yet.
Sorry, the messages are pretty unclear. If you are using the crates.io version of vcpkg_cli, I probably need to make a new release, but here is how it works :
PS C:\Users\jim\src\rust\vcpkg-rs\vcpkg_cli> cargo run -- probe zlib -l static
    Finished dev [unoptimized + debuginfo] target(s) in 0.0 secs
     Running `C:\Users\jim\src\rust\vcpkg-rs\target\debug\vcpkg_cli.exe probe zlib -l static`
Found library zlib
Include paths:
        C:\Users\jim\src\vcpkg\installed\x64-windows-static\include
Library paths:
        C:\Users\jim\src\vcpkg\installed\x64-windows-static\lib
Runtime Library paths:
Cargo metadata:
        cargo:rustc-link-search=native=C:\Users\jim\src\vcpkg\installed\x64-windows-static\lib
        cargo:rustc-link-lib=static=zlib
Found libs:
        C:\Users\jim\src\vcpkg\installed\x64-windows-static\lib\zlib.lib
PS C:\Users\jim\src\rust\vcpkg-rs\vcpkg_cli> cargo run -- -t i686-pc-windows-msvc probe zlib -l static
    Finished dev [unoptimized + debuginfo] target(s) in 0.0 secs
     Running `C:\Users\jim\src\rust\vcpkg-rs\target\debug\vcpkg_cli.exe -t i686-pc-windows-msvc probe zlib -l static`
Found library zlib
Include paths:
        C:\Users\jim\src\vcpkg\installed\x86-windows-static\include
Library paths:
        C:\Users\jim\src\vcpkg\installed\x86-windows-static\lib
Runtime Library paths:
Cargo metadata:
        cargo:rustc-link-search=native=C:\Users\jim\src\vcpkg\installed\x86-windows-static\lib
        cargo:rustc-link-lib=static=zlib
Found libs:
        C:\Users\jim\src\vcpkg\installed\x86-windows-static\lib\zlib.lib

I just played with vcpkg_cli version from crates.io, yes.

If you wouldn't mind, can you tell me a little about your configuration?
Are you actually intending to pick up libraries from Vcpkg at this point or is it accidental? (It finds the tree if you have VCPKG_ROOT set or you have run vcpkg integrate install.)
What version of the compiler are you using and do you have any RUSTFLAGS set?
Do you have your vcpkg configuration available in a public repository that I could take a look at?

Yes, I have VCPKG_ROOT and I do not use vcpkg integration.
I have VS 2015 and 2017 (guess, Rust uses the first one by default).
I have no RUSTFLAGS.
As my vcpkg - it is a default "nightly" vcpkg with the only exception: I use my own curl port, decause the only I need - it is HTTP(s).

You have to be on nightly Rust, right? Otherwise you shouldn't have seen the nmake breakage...
Is the port called "libcurl" or did you give it a different name?
Are building a mixed C/C++/Rust/something application, or is it just Rust? (If it's just Rust, rust-curl's built in curl is I think configured exactly as yours is, but I believe it will be statically linked so it would probably be easier just to use that.) If you are building a mix of Rust and something else and you want it to all use the same curl then using Vcpkg/vcpkg-rs should be a pretty good solution.
Thanks a lot for the information on this.

Otherwise you shouldn't have seen the nmake breakage...
Why? cargo +stable build for curl-sys results the same error as +nightly.

Is the port called "libcurl"
No, it is the same as original curl, just stored in different git branch.

or is it just Rust?
It is essentially cargo install-update --all, it fails on cargo-update command (while building git2, which requires curl).

By the way, back to the subject issue:
$ cargo install --list | rg vcpkg
vcpkg_cli v0.2.1:
    vcpkg_cli.exe

$ vcpkg list | rg zlib
zlib:x64-windows-static     1.2.11           A compression library
zlib:x86-windows            1.2.11           A compression library
zlib:x86-windows-static     1.2.11           A compression library

$ vcpkg_cli probe zlib
Failed:  Could not find library in vcpkg tree VCPKG_ROOT\installed\x64-windows\lib\zlib.lib

$ vcpkg_cli -t x86-windows-static probe zlib
Failed:  this vcpkg build helper can only find libraries built for the MSVC ABI.

$ vcpkg_cli -t x86-windows probe zlib
Failed:  this vcpkg build helper can only find libraries built for the MSVC ABI.

Oh yeah, sorry - I pushed that release for you but I forgot to mention it.
The -t is a Rust target triple. Try:
vcpkg_cli probe zlib -l static
vcpkg_cli -t i686-pc-windows-msvc probe zlib -l static

and it should find both of those. There is currently no way to make vcpkg_cli call .lib_names("zlib", "zlib1") on the Config so even though the libz-sys build script can find the dynamic variant there is no way to verify that from the command line.
It claims it's working with package names, but it is actually using that as the stem and adding .dll or .lib to find the libraries right now. I'm reworking it to actually work with packages. If you have a moment, I'd be interested to see what you get from
git clone https://github.com/mcgoo/vcpkg-rs
cd vcpkg-rs\vcpkg_cli
git checkout deps
cargo run -- deps curl

I get:
[...]
=============================
required port ("curl", Port { dlls: ["libcurl.dll"], libs: ["libcurl_imp.lib"], deps: ["zlib", "openssl", "libssh2"] })
required port ("libssh2", Port { dlls: ["libssh2.dll"], libs: ["libssh2.lib"], deps: ["zlib", "openssl"] })
required port ("openssl", Port { dlls: ["libeay32.dll", "ssleay32.dll"], libs: ["libeay32.lib", "ssleay32.lib"], deps: [] })
required port ("zlib", Port { dlls: ["zlib1.dll"], libs: ["zlib.lib"], deps: [] })
Failed:  Could not find library in vcpkg tree C:\Users\jim\src\vcpkg\installed\x64-windows\lib\curl.lib

The error at the end is because I'm not done. Hopefully it will parse your installation correctly and you will get something like:
required port ("curl", Port { dlls: ["libcurl.dll"], libs: ["libcurl_imp.lib"], deps: [] })

Thanks for the walkthrough on what you are trying to do, by the way. I looked up the cargo-update tool - that looks pretty neat.
The original intent of this vcpkg-rs work was to link statically by default, but that turned out not to be possible. Unfortunately, because you are trying to cargo install things, and using vcpkg-rs favors dynamic linking, even if the build completes, the resulting binary will not run because it won't be able to find curl.dll.
It is possible to do static builds if you set RUSTFLAGS=-Ctarget-feature=+crt-static and compile with nightly (the initial intent of this work was to make it easier to install diesel_cli). It seems like it would be easier to just disable vcpkg-rs with NO_VCPKG=1 in your environment. Then, assuming nmake/jobserver issue is now fixed you should be good to go.
This is a disapointing result for me - I was hoping to have it enabled by default, but I think it will have to require a variable to be set to enable it. Sorry again for the breakage.

Thanks for detailed explanation.
Yes, now it finds a static zlib (but not zlib1.dll, as you warned above).
Also it is a bit confusing to have "static", but "dll" instead of "dynamic":

error: 'dynamic' isn't a valid value for '--linkage '
[values: dll, static]

As for lib_names — I think, it is possible to have it in command line tool as well. Since vcpkg_cli is intended for vcpkg feature exploration and testing, it would be nice to have all features covered by command line. Or may be no.
And the last thing: I am worrying about NO_VCPKG, would not it be confusing with official VCPKG_* variables? May be it is better to use RUST_VCPKG_* format?
Anyway, thanks for support.

cargo install -f cargo-update now results in a working binary for me. You should see it pick up vcpkg 0.2.2.
Thanks for the comments about vcpkg_cli - I'll try to remove some of those surprises shortly.
I changed the build help specific environment variables to all have a VCPKGRS_ prefix to try and keep out of everyone elses' namespace.
Could you let me know if this unbreaks your setup?


Preparação do ambiente de desenvolvimento

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2c83d85). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             master        #1   +/-   ##
==========================================
  Coverage          ?   100.00%
==========================================
  Files             ?         1
  Lines             ?         2
  Branches          ?         0
==========================================
  Hits              ?         2
  Misses            ?         0
  Partials          ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c83d85...368d845. Read the comment docs.


Update linux-install-manually.md

Update the Install the Microsoft GPG public key section to reflect  a better way to tell apt to only trust that GPG key for a specific source
Reference third-party doc -https://blog.cloudflare.com/dont-use-apt-key/

@JohanFreelancer9 Please copy review

issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/9990

Learn Build status updates of commit 8393ee3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/defender-endpoint/linux-install-manually.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 3c52b3c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/defender-endpoint/linux-install-manually.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


DMT /getDeployment/{ticker} problem.

When running GET /getDeployment/{ticker} with VESSELS as a ticker, I get the following response:
{"result":null}
This is wrong, because there is a valid deployment with this ticker:
https://ordiscan.com/inscription/71985009
Why is it like this?

Figured it out, for those, who have the same problem, maybe you need to prefix the ticker from on-chain with something (e.g. "dmt-" for DMT projects).


Avoid registering a service

Is there a way, a service can avoid registering itself? I have a go-web service running in a docker container and there is a registrator on the same machine to register the service separately, which results into two consul nodes for the same service. If we can set some flag value which tells service.Run() to not  to call Register().
Thanks.

Go Web is a slim wrapper around go-micro and net/http to register http based services in discovery. If you don't need this functionality you should really not be using go-web.
In the event you want to use it and not register, I would advise you to use the plugin for the noop registry https://github.com/micro/go-plugins/tree/master/registry/noop.
Otherwise, what you're doing makes no sense because the whole reason for the existence of go-web is to register services.


Cherry pick of AmbiguousImplementationException

Cherry pick of AmbiguousImplementationException to use on DIM issues.

@thaystg for the future, such changes should be squashed


Support for .NET 4.7.1 & 4.7.2 + version bump

I added the 4.7.1 and 4.7.2 frameworks to the list. Please publish vsix.

Please Merge

Pity to see this not merged,

Why not just create a fork and someone else run with it? This guy is obviously AWOL. Their loss, but it doesn't have to be ours. Not like it's a complicated thing to write.

Plz: publish Hannes update.

In case of DIY, I found my files here: %LocalAppData%\Microsoft\VisualStudio\15.0_630ee505\Extensions\24n4fs45.ytv

Please pull this

FWIW: Using VS 15.9.8 (latest 2017 version at this time), I was able to:

Clone the FHannes' fork of this repo
Open and build the solution
Double click the .vsix file in the bin directory to launch the extension installer
Migrate projects to 4.7.2

Thanks for this!

I'm getting an error after compilation and installation of the extension:

Anything I can do to make it work?
Thanks
Piotr

The issue above was caused by the c++ project existing in the solution. Locally I added exclusion of this project type to the extension code and the error is gone, seems all is fine now.

Thanks for the PR!
This will be fixed in the next release, probably by https://github.com/TargetFrameworkMigrator/TargetFrameworkMigrator/pull/57
As this is an older PR, I will close this one instead of #57.


Enhances spo navigation node add and spo navigation node set with linkless navigation node, Closes #4586

This PR enhances spo navigation node add and spo navigation node set with linkless navigation node.
Closes #4586

Nicely done! We'll try to review it ASAP!

We're nearly there! Let's make some adjustments first.

Thank you for another awesome review! Your feedback is processed

Merged manually, many thanks!


Optimize templates used in project organizer to load once

Purpose
Based on code review, to put the instantiation of templates at the top so they happen once.
Changes
There are now global variables for the templates which get built once
Side effects
Since the templates get fed with data with handlebars there shouldn't be any side effects.

1st pass finished. :cake:


Enable Travis checks for Python 3.7 and 3.8

https://trello.com/c/GsDBHBo7
Let's see how everybody's favourite repo copes with this.

Hey look they worked


fix: Improved Script Efficiency and Readability

PR description
I’ve made a few updates to the script to improve its efficiency and readability, as well as fix some minor issues. Here's a breakdown of what’s been changed:

Architecture Detection: I added a line to automatically detect the system architecture (export architecture=$(uname -m)), which helps if the architecture variable isn't provided earlier.

Modern Syntax for Incrementing: Replaced the outdated syntax (i=\expr $i + 1) with the more modern ((i++)). This not only improves readability but also enhances the script’s performance.

Grammar Fix: I corrected a grammatical issue in the comments by updating the line:
# we test that things listen on the right interface/port, not what interface they advertise

Replacing Inefficient Constructs: Switched the use of expr to ((i++)) for numerical operations, which is more efficient in Bash.

Error Checking Improvements: Changed [[ $i != 0 ]] to ((i != 0)) for checking the value of i, as the latter is more appropriate and standard for numeric comparisons in Bash.

Directory Creation: Added a step to ensure that the necessary report directories exist (mkdir -p ./reports) or created them if they were missing. This prevents errors when generating reports.

These updates should make the script more stable, modern, and easier to work with.
Thanks for sending a pull request! Have you done the following?

[x] Checked out our contribution guidelines?
[x] Considered documentation and added the doc-change-required label to this PR if updates are required.
[x] Considered the changelog and included an update if required.
[x] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

[x] unit tests: ./gradlew build
[x] acceptance tests: ./gradlew acceptanceTest
[x] integration tests: ./gradlew integrationTest
[x] reference tests: ./gradlew ethereum:referenceTests:referenceTests

Hi, thanks for your interest in our project. We'd love for you to contribute code, however we don't accept trivial contributions such as this. Have a look at good first issues and please read our contributing guidelines https://github.com/hyperledger/besu/blob/main/CONTRIBUTING.md#guidelines-for-non-code-and-other-trivial-contributions


Make native staked DAO-DAO voting, have SDK hooks that call into it for stake changes

DAO DAO voting for natively staked coins can be more powerful, if we make an SDK module that just listens for all delegate, undelegate, and redelegate hooks. Then on each of these hooks, calls a sudo message to a pre-configured contract.
This would let us have a more powerful wrapper for governance! They could now compute the current semantic of "Voting power = stake at end of voting period", with no iteration at end time for instance. (The only iteration needed, would be to reclaim state, but we can have a separate process for that. Espec. if we make a gas token like dynamic)
Or we could switch semantics to "voting power = stake at beginning of voting period", or my favorite "voting duration = k days. Voting power = sum of stake_at_time_i * voting decision_at_time_i for times in the final day of voting" (to protect against last second vote attacks)
If we make an SDK module for communicating stake change events during the voting period, then we can unlock all of these capabilities for DAO DAO voting.

DAO DAO voting for natively staked coins can be more powerful, if we make an SDK module that just listens for all delegate, undelegate, and redelegate hooks. Then on each of these hooks, calls a sudo message to a pre-configured contract.

Woah. This would be amazing. I think it would be useful for many other things as well!
FWIW, we do allow for native staked voting in DAO DAO V2... though I'm not 100% convinced it's the best implementation: https://github.com/DA0-DA0/dao-contracts/tree/main/contracts/voting/cwd-voting-staking-denom-staked


[FEATURE] Ability to run the script from IBM Cloud Shell

Is your feature request related to a problem? Please describe.
I would like to deploy OpenShift on PowerVS using IBM Cloud shell which comes preconfigured with necessary tools and utilities
https://cloud.ibm.com/docs/cloud-shell?topic=cloud-shell-shell-ui
Describe the solution you'd like
IBM Cloud Shell is a temporary environment. So tfstate and other details need to be stored in a persistent storage like IBM Cloud object store or Git.
The solution should handle this aspect

IMO it is not a good idea to deploy from IBM Cloud shell because the deployment configurations contains sensitive and required files such as ssh keys, pull-secret and Terraform state file. These files are also needed for destroy purpose later. Maintaining the same session is difficult due to network disconnections, closing the browser tabs, etc.
Supporting remote backend for state is a Terraform feature and need to be implemented in the parent project. Also I do not think IBM Cloud Object Storage or Git is supported. Even it will need additional mechanism to manage endpoints and authenticate these services for storing the sensitive state file for supported backends.

I would want to see a feature where I can start the create step, answer all questions and I should be able to disconnect and close my laptop/shell. I know one way is to use screen linux cmd from a lab server but not always lab server (always-on) is available for everyone in order to use screen or equivalent cmd.

I would want to see a feature where I can start the create step, answer all questions and I should be able to disconnect and close my laptop/shell. I know one way is to use screen linux cmd from a lab server but not always lab server (always-on) is available for everyone in order to use screen or equivalent cmd.

I would want to see a feature where I can start the create step, answer all questions and I should be able to disconnect and close my laptop/shell. I know one way is to use screen linux cmd from a lab server but not always lab server (always-on) is available for everyone in order to use screen or equivalent cmd.

I am sure this is not possible since Terraform process needs to be running always in the background. The script support re-running create and re-start from the last point when the session was disconnected or teraform process was ended.

I would want to see a feature where I can start the create step, answer all questions and I should be able to disconnect and close my laptop/shell. I know one way is to use screen linux cmd from a lab server but not always lab server (always-on) is available for everyone in order to use screen or equivalent cmd.

I am sure this is not possible since Terraform process needs to be running always in the background. The script support re-running create and re-start from the last point when the session was disconnected or teraform process was ended.


Change enum fields from CharFields to IntegerFields

This might fall under the category of premature optimization, but I believe that enum fields should be changed from CharFields to IntegerFields. An example of this is the Membership_type on the Membership model. I'm not sure if it actually is noticable, but AFAIK a string comparison is many times more computationally expensive than an integer comparison. Additionally, Django's implementation of IntegerChoices does not have any drawbacks in terms of readability. The only difference is in how the backend SQL server handles these fields. Therefore, I think we should consider changing these fields.

@mark-boute can you take care of this for fields with choices in the users app?


openmvg: 1.1 -> 1.3

Motivation for this change
Upstream library changes broke the building of openmvg on nixos. However, these are fixed in openmvg 1.3, so this simple version bump fixes building.
Things done
openmvg: 1.1 -> 1.3 version bump

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build openmvg

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: openmvg
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: openmvg
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

No attempt on x86_64-linux (full log)
The following builds were skipped because they don't evaluate on x86_64-linux: openmvg
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.


Add support for loading multiple ScriptDomains

Implemented as tree-like domain chain, parent domain will dispatch events to child/sub domains. Still sketchy, but should provide a way to load/unload individual domains with the console.
To avoid repeated memory scanning, I think a shared dictionary can be used to cache the pattern and corresponding offset.
Any feedback/suggestion will be appreciated

I don't quite understand what this is solving?

It's more like adding a feature, so scripts can be unloaded/reloaded individually.
#1162, #916

l

This would be very sorry to hear this, but I believe we have to give up on adding the individual reloading feature for existing scripts for the sake of existing compatibilitities. It would be safe to add it for v4 scripts, but is not for v3 or earlier ones unfortunately.
Even when only considering those that don't have references to any other scripts, separating scripts into separate AppDomain is a breaking change. Two or more scripts wouldn't be able to use another script for shard variables if the change was made, like how HKH191 does in his mod helper (HKHModHelperNew.dll). Although using a script as a shard variable store can lead into data races, it should have been prevented by our design...


Unix Domain?

Handling requests from an upstream server, or tor, is a must! If the upstream server is local it becomes encumbering to use ports on a localhost interface for IPC. Enter Unix Domain Sockets.

If I understand correctly, the request might be better forwarded to the underlying HTTP implementation, i.e. https://github.com/tiny-http/tiny-http. Doesn't have the time to formulate it properly right now, though.

Sorry.  This would be an extension on the listening socket, to allow for accepting connections on UDS.

PR #287 may be of interest.


How to get unseen threads only?

I have a requirement that only figures out the unseen threads (excluding pending threads).
I have digged into every field a thread instance provides and still cannot find out any relevant fields that indicate the thread as it's unseen.
Thank you very much.

Addressed in rewrite or no longer relevant.


Handle dict of metrics in distributed training

When training with a model with a subclass tf.keras.metrics.Metric which which returns a dict, e.g.
class CustomMetric(tf.keras.metrics.Metric):
    def result(self):
        return {"good", tf.convert_to_tensor([1.0]), "bad": tf.convert_to_tensor([0.0])}

I got an exception in merge_fn_wrapper when trying to call array_ops.identity on a Dict[str, tf.Tensor]. This fix allows me to do distributed training with the above metric.

Hi @froody Can you please check @qlzh727's comments and resolve conflicts?. Thank you!

Hi @froody Any update on this PR? Please. Thank you!


refactoring: enable email confirmation at API

PR which enforces user to confirm his email address after registration (applies only for new registered users, not invited ones). User is not able to login, before they finish email confirmation.
Users should receive email after registration with following link #{ENV["FRONTEND_URL"]}/sign-up?confirmation_token=#{@token}.  API used to confirm email is already implemented and documented at Rswag doc (/api/v1/email_confirmation). There is also possibility to re-send confirmation email via API.
@clementprdhomme @barbara-chaves
Testing
Use rswag documentation

register new user --> you should receive email which allows you to confirm your email address
take token from url inside email
and send it to GET /api/v1/email_confirmation and confirm
your user should get confirmed and you should get logged in (session is created)

Tracking
Part of https://vizzuality.atlassian.net/browse/LET-203 -- enabling email confirmation

Can we not merge it (or have it disabled) until the front-end is done? The front-end team won't have capacity to work on this before the end of the sprint and thus before we deploy to production.
We also need to evaluate the front-end work to do. I know this was enabled at some point but the code has changed quite a lot since then and we need to make sure everything is in order.
Thanks for tagging us and adding some documentation!

Can we not merge it (or have it disabled) until the front-end is done? The front-end team won't have capacity to work on this before the end of the sprint and thus before we deploy to production.
We also need to evaluate the front-end work to do. I know this was enabled at some point but the code has changed quite a lot since then and we need to make sure everything is in order.
Thanks for tagging us and adding some documentation!

I think disabling does not make much sense because purpose of this PR is to enable it, but we can wait with merge -- It will appropriate label to PR for now and when you are ready to work on this, feel free to merge this.


Responsive devices ?

Is here any way to make devices responsive ?  Something like images with css : width:100%; height:auto; ?

I was able to center the phone horizontally & vertically by adding this code to my CSS file
.marvel-device {
margin: 0 auto;
top: 50vh;
margin-top: -410px;
display: block;
}

The real issue is the device metrics, not positioning.
Since the whole project was created using a lot of px values, the simplest way is to use the css zoom property.
.marvel-device {
    zoom: 0.8
}

to be used in media queries !

It would be ideal if the entire device and everything in it was able to scale linearly according to vh or %

To achieve this you use the css property transform and use media queries. DEMO

Hi everyone, brand new to Github (and relatively new to coding in general) - just want to let you know that I found a bit of a workaround for this (totally unsure of browser compatibility etc!):

Find & replace all "px" for "em" in the devices.min.css file.
Place the html in a container that sets the 'font-size' to whatever you need (setting it at 1px will be equal to the current size - I used font-size:0.5px;).
You can then adjust the font-size at different break points if required.

Hopefully that proves useful for someone! (I only used the iphone 8 code so unsure if it works with all devices but I don't see why not?)
Cheers!

@evansanto
This is literally great idea, you won this issue Evan!
Using scale or zoom isn't really a solution as it mixes DOM measurements that are hard to handle.

You're right @adriandmitroca , @evansanto totally nailed it, it should work with all the devices. Here's a demo. vw unit could also be used to avoid using media queries.

@evansanto very nice indeed!

Give https://github.com/osrec/ResponsiveDevices.css a try for totally responsive devices - they're not as detailed as the very realistic ones on here, but might be useful to someone :)

@evansanto be careful with this on chrome, you can run into issues with Chrome's minimum font size making the device huge

I wrote a different approach to this issue. My version modifies the scss directly, which you can then use to create the phones in any size you want. If you want to change between multiple sizes, use @media queries and load multiple files.
https://github.com/philipkiely/devices.css

Nice endeavour @philipkiely, it looks like you nailed it.

Word of caution regarding zoom:

Non-standard: This feature is non-standard and is not on a standards track. Do not use it on production sites facing the Web: it will not work for every user. There may also be large incompatibilities between implementations and the behavior may change in the future.

source: https://developer.mozilla.org/en-US/docs/Web/CSS/zoom


DESTDIR is / and install requires root priv

if you change DESTDIR to anything else, install will fail silently
Is there any way to install this without root?

if you must, reproduce non-root priv using;
Dockerfile
FROM --platform=amd64 debian:buster-slim
ARG DEBIAN_FRONTEND=noninteractive

RUN mkdir /srv/app
WORKDIR /srv/app

RUN apt-get update && \
    apt-get install -y --no-install-recommends \
    make git curl wget \

The in a bash shell
    git clone https://github.com/awslabs/git-secrets
    cd git-secrets
    DESTDIR=/srv/app/.local make install
    git secrets --install

outputs
remote: Enumerating objects: 1, done.
remote: Counting objects: 100% (1/1), done.
remote: Total 345 (delta 0), reused 0 (delta 0), pack-reused 344
Receiving objects: 100% (345/345), 113.70 KiB | 285.00 KiB/s, done.
Resolving deltas: 100% (194/194), done.
git: 'secrets' is not a git command. See 'git --help'

Retry changing DESTDIR to anything, same result
Retry without changing DESTDIR to anything at all (default), results in permission issues;
mkdir: cannot create directory '/usr/local/share/man/man1': Permission denied
make: *** [Makefile:20: install] Error 1

Unexpected behavior following the instructions of prerequisites and install, looking for a solution or bug acceptance.

And don't suggest to change to Dockerfile - that is a reproduction only...
Sayign to do that would be like asking a guest user to have the shared host changed for all guests...

I am using Centos, and I am also trying to install make file does not do anything :(

Shouldn't git secrets --install be git-secrets --install instead?

I was only asking because it seems strange to install the hook via git secrets --install as secrets is indeed not a Git command. This is how the README says we should proceed but I can't see how this is working (it must be though).

git secrets transparently calls git-secrets for you, as many git commands do.
git secrets --install and git-secrets --install are roughly equivalent. What they do is install the relevant hooks to your current repo configuration. This is unrelated to installing git-secrets itself, which is done via make install.
DESTDIR=/srv/app/.local make install
git secrets --install

This installs the git-secrets script to /srv/app/.local/bin/git-secrets, so that /srv/app/.local/bin needs to be on your path for git secrets to work.


Az Tag Delete Command Removes All Tags

Describe the bug
In reading the documentation it appears that should I provide an input for the parameter --name the intended action should be to remove only that one tag, but instead deletes all tags on the resource.  I specifically was testing the command against a resource group, in this instance.
https://learn.microsoft.com/en-us/cli/azure/tag?view=azure-cli-latest#az-tag-delete
Related command
 az tag update --name $tag_key --resource-id $resource_id --yes
Errors
All tags on resource group are deleted, not just the named ones
Issue script & Debug output
Results are that all tags are removed, not just the named ones
Expected behavior
Only the named tag(s) should be removed
Environment Summary
"azure-cli": "2.49.0",
"azure-cli-core": "2.49.0",
"azure-cli-telemetry": "1.0.8",
"extensions": {
"azure-devops": "0.26.0",
"azure-iot": "0.21.2",
"bastion": "0.2.4",
"kusto": "0.5.0",
"managementpartner": "0.1.3"
}
Additional context
No response

Thank you for opening this issue, we will look into it.

@delarooster Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

@delarooster Our docs clearly says that the below command Delete a predefined tag from the subscription not associated with a resource or having no tag values.

az tag delete --name MyTag

While all the other commands in az tag delete command with an id deletes the entire set of tags on a resource, resource group or subscription.
Instead you should be using the az tag update command with operation delete parameter as shown below:

az tag update --resource-id /subscriptions/{sub-id} --operation merge --tags key1=value1 key3=value3

More Info here. Hope this helps.

@delarooster The action is currently pending on you to try the above suggestion. If you need any further assistance on this issue in future, please feel free to reopen this thread. We would be happy to help.


Deploy the contracts to Ethereum Classic and the Ethereum Classic Kotti Testnet

🧐 Motivation
Many developers choose Ethereum Classic to deploy their contracts to. By January, ETC's upcoming Agartha hard fork will provide feature-parity with Constantinople. It would be useful to developers on ETC if the openzeppelin-contracts-ethereum-package contracts could be deployed to Ethereum Classic's mainnet and the primary testnet Kotti (https://github.com/goerli/testnet).
📝 Details
I have tried to deploy this myself manually. I have an ETC account with a balance on it and I have the following settings in my network.js file:
require('dotenv').config();
const HDWalletProvider = require('truffle-hdwallet-provider');
module.exports = {
  compilers: {
    solc: {
      version: '0.5.1',
      settings: {
        evmVersion: 'byzantium'
      }
    }
  },
  networks: {
    kotti: {
      provider: () => new HDWalletProvider(
        [process.env.DEV_PRIVATE_KEY],
        "https://www.ethercluster.com/kotti"),
      networkId: '6'
    }
  }
};

Here is the output I get from open-zeppelin-sdk:
$ openzeppelin push
Nothing to compile, all contracts are up to date.
? Pick a network kotti
? One or more linked dependencies are not yet deployed on dev-6.
Do you want to deploy them now? Yes
✖ Deploying @openzeppelin/contracts-ethereum-package dependency to network dev-6
Failed deployment of dependency @openzeppelin/contracts-ethereum-package with error: Failed to check for transaction receipt:
{}

Hi @husainfazel,
I suggest this issue can be closed now.
I answered this in the forum, the issue was the EVM version of the Proxy and ProxyAdmin contracts in OpenZeppelin CLI.  A Byzantium version of the OpenZeppelin CLI was created to allow contract creation on Kotti.
https://forum.openzeppelin.com/t/deploying-a-token-that-uses-contracts-ethereum-package-to-ethereum-classic/1810/4


utils: add fallback mimetype

closes https://github.com/zenodo/rdm-project/issues/547

Not required anymore as we agreed to hardcode the default mimetype

Just to clarify, I'm against moving this to config since IMHO it's a constant, and I also agree that introducing it in utils.py as FALLBACK_MIMETYPE might have been a "brittle" solution.


Plot bandstructure generated with 0-weight SC procedure

I would like to plot a bandstructure which has been generated using the 0-weight (fake) SC procedure outlined here. It would be useful if there was a sumo-bandstats option to plot only the zero-weighted k-points. I'm happy to try and implement this if you could confirm that this is not already possible and agree that this would be a useful enhancement.

Not only can sumo-bandplot already do this, sumo-kgen is actually designed to help set up these calculations!
https://sumo.readthedocs.io/en/latest/sumo-kgen.html#hybrid-band-structures

We recently got a fix put in Pymatgen so this method can be used for meta-GGA calculations as well as hybrids. This may not have hit the release version of Pymatgen yet.

I assume that pymatgen/sumo works out which k-points to plot automatically, as I can't see user options in the documentation. However, this does not seem to be working for a PBEsol with SoC calculation I am trying to plot - it is plotting all of the points. I've attached the vasprun.xml, KPOINTS and sumo output files. I've also included the bandstructure generated using effmass (which reads from the OUTCAR and PROCAR) - one plot includes all k-points, and one includes only the zero-weighted k-points.
sumo_issue_30.zip

Hi Lucy,
For a PBEsol calculation, you don't need zero weighted k-points, and you
should just calculate the band structure self consistently using only the
k-points for the directions you want, all weighted properly. So this is
probably why SUMO plots all of the k-points, as these should all be valid.
Best wishes
David
On Wed, Oct 3, 2018 at 12:14 PM Lucy Whalley<EMAIL_ADDRESS>wrote:

I assume that pymatgen/sumo works out which k-points to plot
automatically, as I can't see user options in the documentation. However,
this does not seem to be working for a PBEsol with SoC calculation I am
trying to plot - it is plotting all of the points. I've attached the
vasprun.xml, KPOINTS and sumo output files. I've also included the
bandstructure generated using effmass https://github.com/lucydot/effmass
(which reads from the OUTCAR and PROCAR) - one plot includes all k-points,
and one includes only the zero-weighted k-points.
sumo_issue_30.zip
https://github.com/SMTG-UCL/sumo/files/2441741/sumo_issue_30.zip
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SMTG-UCL/sumo/issues/30#issuecomment-426598975, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AOQncliqxh58wajHCm8J8zlurGJMiz8Vks5uhJwWgaJpZM4W8E8e
.

Hi David,
Thanks - pymatgen source code confirms your suggestion here. To avoid re-doing the calculation I used an easy workaround: Setting LHFCALC equal to T(rue) in the vasprun.xml tricked pymatgen into thinking it was a hybrid calculation and the bandstructure is looking great!

This is the Pymatgen bug I mentioned, which has been fixed but presumably isn't in the main release yet. Try using the latest version of pymatgen from source?


Author-date citations with page references not separated by a semicolon

Pandoc correctly separates multiple references to the same author with a comma. When there are also page references, they should go back to being separated with a semicolon (without adding the duplicate author name), and this is not happening.
The Chicago Manual of Style gives the following examples:

(Whittaker 1967, 1975; Wiens 1989a, 1989b)
(Wong 1999, 328; 2000, 475; García 1998, 67)

With pandoc-citeproc <IP_ADDRESS>:
pandoc -F pandoc-citeproc -t plain << EOT
---
references:
- id: 'test1'
  author:
    - family: Shakespeare
      given: William
  issued:
    - year: 1615

- id: 'test2'
  author:
    - family: Shakespeare
      given: William
  issued:
    - year: 1616

- id: 'test3'
  author:
    - family: Donne
      given: John
  issued:
    - year: 1629
---

[@test1; @test2; @test3]

[@test1, pp. 1875; @test2, pp. 110–130; @test3, pp. 10–16]

EOT

Result:
(Shakespeare 1615, 1616; Donne 1629)

(Shakespeare 1615, 1875, 1616, 110–30; Donne 1629, 10–16)

Can we determine whether this is a problem with the csl
style or a problem with pandoc-citeproc?

I do not think that the CSL spec even considers this problem; there's nothing about it under Cite Collapsing.

This has been discussed before on the Zotero forums (https://forums.zotero.org/discussion/38027/style-error-chicago-authordate-collapse/, and also https://forums.zotero.org/discussion/47396/citation-delimiters). The “collapse” bit mentioned in the first thread was a CSL style issue, and has been addressed.
Concerning the “separate by commas, except where page numbers are required” issue, @rmzelle suggested two possible fixes:

One option would be to fall back from using any custom delimiter to the delimiter set on cs:layout whenever two neighboring years or year-suffixes are separated by additional content (like a locator). This could be a configurable toggle.

Or we could introduce another delimiter, like after-locator-delimiter.

The first one seems to involve tweaking the CSL processors (which does not seem to have been tried for citeproc-js so far – but I don’t see why pandoc-citeproc couldn’t), while the second would require a change in the CSL schema (which definitely has not happened yet).

Glad to know I'm not the first to notice it, at least. Given that (in Chicago) this can produce unreadable references, that fallback option seems ideal.

@fbennett has come up with a fix for citeproc-js (see here). It involves tweaking the processor (note that some test cases have been added or modified) and adjusting chicago-author-date.csl as indicated here. (For now, I have uploaded a copy of the adjusted style here. Using this, I get the expected results with Zotero+propachi-vanilla-v1.1.120-fx.xpi and LibreOffice.)

Somewhat belatedly, chicago-author-date.csl (incl. de, fr, basque) have been “adjusted” in the official CSL style repository, so this issue is now fully resolved for Zotero/LO users. It’d be great if pandoc-citeproc could follow suit. As always, I’m happy to test anything that is sent my way.


Filtering on a relation actually returns the filtered relations, not the filtered main array

For exemple, if I filter my cats by toys.name=$not:$eq:pillow, if some of the cats have a toy whose name is pillow, they will still appear in the filtered results, only the toy entity will not be included in the loaded relation array, is this intended ?

I understand this one is more of an SQL issue, I don't know if this will be easy to fix


Added String() method to TableColumn

so that "%v" will print lower-level *TableColumn
members nicely.

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.

go/vt/schema/schema_test.go, line 13 [r1] (raw file):

func TestTableColumnString(t *testing.T) {
	c := &TableColumn{Name: cistring.New("my_column"), Type: querypb.Type_INT8}
	expected := "{Name: 'my_column', Type: INT8}"

Please use "want" and "got" to be Go idiomatic.

Comments from Reviewable

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

go/vt/schema/schema_test.go, line 13 [r1] (raw file):
Previously, michael-berlin (Michael Berlin) wrote…
> Please use "want" and "got" to be Go idiomatic.

Done.

Comments from Reviewable


EE CORE UNION There is already an open DataReader associated with this Command which must be closed first.

IQueryable database not data
There is already an open DataReader associated with this Command which must be closed first.
but database one data not error
XXX.GetAll().TList() close conn OK
ERROR 2018-10-23 15:09:01,753 [57 ] e.Diagnostics.ExceptionHandlerMiddleware - An unhandled exception has occurred: There is already an open DataReader associated with this Command which must be closed first.
System.InvalidOperationException: There is already an open DataReader associated with this Command which must be closed first.
at System.Data.SqlClient.SqlInternalConnectionTds.ValidateConnectionForExecute(SqlCommand command)
at System.Data.SqlClient.SqlInternalTransaction.Rollback()
at System.Data.SqlClient.SqlTransaction.Dispose(Boolean disposing)
at Microsoft.EntityFrameworkCore.Storage.RelationalTransaction.Dispose()
at Abp.EntityFrameworkCore.Uow.DbContextEfCoreTransactionStrategy.Dispose(IIocResolver iocResolver)
at Abp.EntityFrameworkCore.Uow.EfCoreUnitOfWork.DisposeUow()
at Abp.Domain.Uow.UnitOfWorkBase.Dispose()
at Abp.AspNetCore.Mvc.Uow.AbpUowActionFilter.d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Rethrow(ActionExecutedContext context)
at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.d__14.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.d__23.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow(ExceptionContext context)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.d__22.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow(ResourceExecutedContext context)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.d__17.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.d__15.MoveNext()
--- End of stack trace from previous location where exception was thrown ---

@stuyun There isn't enough information here for us to be able to effectively investigate. Please post a runnable project/solution or complete code listing that demonstrates the behavior you are seeing.

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


Fix memory leak when (de)serializing objects with enums (#1991)

Implements Equals and GetHashCode methods in Naming Strategy.

Thanks for the fix. I think this is ok, but I'll test it out more before 12.0.2.
For 13.0 I think I'll seal CamelCaseNamingStrategy and SnakeCaseNamingStrategy.

I think i've just come across this memory leak issue with entity framework + newtonsoft, using Enums in models. The memory object count rises slowly and the culprit seems to be Newtonsoft.Json.Serialization.CamelCaseNamingStrategy, Newtonsoft.Json.Utilities.EnumInfo and Newtonsoft.Json.Utilities.StructMultiKey.
I'm glad to see this has been found already ! When could we expect the 12.0.2 release ?

12.0.2 will come soon. This is a subtle yet high-impact bug.


fix: run vault init container as non-root user

Signed-off-by: ankitm123<EMAIL_ADDRESS>

/test vault

/hold
Still testing ...

/test vault

/hold cancel

/lgtm


Pinot datasets not showing in thirdye UI

I have integrated pinot into thirdeye using following connector configurations-

className: com.linkedin.thirdeye.datasource.pinot.PinotThirdEyeDataSource
properties:
zookeeperUrl: 'localhost:2181'
clusterName: 'PinotCluster'
controllerConnectionScheme: 'http'
controllerHost: '<IP_ADDRESS>'
controllerPort: 9000
cacheLoaderClassName: com.linkedin.thirdeye.datasource.pinot.PinotControllerResponseCacheLoader
metadataSourceConfigs:
- className: com.linkedin.thirdeye.auto.onboard.AutoOnboardPinotMetadataSource

className: org.apache.pinot.thirdeye.datasource.sql.SqlThirdEyeDataSource
properties: ......

The pinot is working fine on 9000 port.  I ingested data into pinot using the offline mode. I am able to query as well on the pinot server. But the data doesn't appear in the root cause analysis.
I also checked the admin dashboard. The data doesn't appear in the database configuration.
Moreover auto onboarding of the pinot datasets in the thirdye-frontend/config/detector.yml file
is also set to true.  Any solutions to this??

@ShubhamMMT1 can you share the events you see in the logs? Any error or warning messages?

ERROR [2019-06-19 06:36:26,339] org.apache.pinot.thirdeye.datasource.DataSourcesLoader: Exception in creatingthirdeyedatasourceorg.apache.pinot.thirdeye.datasource.sql.SqlThirdEyeDataSource ! java.lang.IllegalStateException: The file is locked: nio:/home/shubham.mourya/third/incubator-pinot/thirdeye/thirdeye-pinot/config/h2db.mv.db [1.4.192/7]
This is what I am getting in the logs of run-backend.sh.

ERROR org.apache.pinot.thirdye.auto.onboard.AutoOnboardUtility: Exception in creating metadata.constructor.com.linkedin.thirdeye.auto.onboard.AutoOnBoardPinotMetaDatasoorce
Warn -java.lang.ClassNotfoundException- cm.linkedin.thirdeye.auto.onboard.AutoOnboardPinotMetaDataSource
Shows class not found as well! @akshayrai  Soln to these?

There is a bug in the documentation. It should be org.apache.pinot.thirdeye.auto.onboard.AutoOnboardPinotMetadataSource and org.apache.pinot.thirdeye.datasource.pinot.PinotThirdEyeDataSource instead of com.linkedin.thirdeye... (Notice the package name)
@ShubhamMMT1 , have you resolve the SqlThirdEyeDataSource issue?

Yes, it  was resolved. The class name was incorrect.
Thanks @akshayrai

# Please put the mock data source as the first in this configuration.
dataSourceConfigs:
  - className: org.apache.pinot.thirdeye.datasource.pinot.PinotThirdEyeDataSource
    properties:
      zookeeperUrl: 'localhost:2181'
      clusterName: 'PinotCluster'
      controllerConnectionScheme: 'http'
      controllerHost: '<IP_ADDRESS>'
      controllerPort: 9000
      cacheLoaderClassName: org.apache.pinot.thirdeye.datasource.pinot.PinotControllerResponseCacheLoader
    metadataSourceConfigs:
      - className: org.apache.pinot.thirdeye.auto.onboard.AutoOnboardPinotMetadataSource

I used this configuration, and got an error.
2022-05-17 18:26:33.104 [main] INFO  org.apache.pinot.thirdeye.datalayer.util.DaoProviderUtil - Using existing database at 'jdbc:mysql:///thirdeye?autoReconnect=true'
May 17, 2022 6:26:37 PM org.apache.tomcat.jdbc.pool.ConnectionPool init
SEVERE: Unable to create initial connections of pool.
com.mysql.jdbc.exceptions.jdbc4.MySQLNonTransientConnectionException: Could not create connection to database server. Attempted reconnect 3 times. Giving up.

@akshayrai @ShubhamMMT1
Do you have any suggestion for this error?


Possible error in doc?

In the dynamic and lightweight convolution example page, the user is instructed to build the shared library twice.
Could I check with the fairseq developers if this is a typo?

for the cuda kernel? No, you need to build each one separately.


feat(#1454): add pencil outline icon

Before (the change)
Using the code:
<goa-icon type="pencil"></goa-icon>
<goa-icon type="pencil" theme="filled"></goa-icon>

They are the same now. Expected they are different. When no theme is specified, the outline should be displayed. Pencil icon is missing outline variant.
After (the change)

Make sure that you've checked the boxes below before you submit the PR

[x] I have read and followed the setup steps
[x] I have created necessary unit tests
[x] I have tested the functionality in both React and Angular.

Steps needed to test

FIlled Icon and outline icon is not at the same height.

issue is verified on react and angular

:tada: This PR is included in version 1.17.0-alpha.70 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0-alpha.4 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.22.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.21.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.17.0-alpha.32 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Comment after all causes pydocstyle to freeze

Including a comment at the end of a __all__ = ... line causes pydocstyle to freeze.
Steps to reproduce
pip install --upgrade pydocstyle
mkdir tmp/
cd tmp/
echo "__all__ = [] #" > test.py
pydocstyle . -esdv

Output
$ pydocstyle . -esdv
starting in debug mode.
No config file specified, discovering.
No config file specified, discovering.
No config file specified, discovering.
No config file specified, discovering.
No config file specified, discovering.
No config file specified, discovering.
Checking file ./test.py.
parsing module.
parsing docstring, token is tk.NAME (__all__)
parsing definition list, current token is tk.NAME (__all__)
got_newline: True

Environment

Ubuntu 18.04
python 3.6.4
pydocstyle 3.0.0

Confirmed and briefly checked 3.0.0 tag code. It fall into a infinite loop.
https://github.com/PyCQA/pydocstyle/blob/37c00d8fa8e43119e038d7309a784b094bd482ad/src/pydocstyle/parser.py#L494-L498
self.current is a Comment Token.
And the master branch has the same issue, I think it should consume token here
diff --git a/src/pydocstyle/parser.py b/src/pydocstyle/parser.py
index e8f5c7c..473beba 100644
--- a/src/pydocstyle/parser.py
+++ b/src/pydocstyle/parser.py
@@ -487,6 +487,7 @@ class Parser:
                 self.dunder_all = None
                 self.dunder_all_error = 'Could not evaluate contents of __all__. '
                 return
+            self.stream.move()

     def parse_module(self):
         """Parse a module (and its children) and return a Module object."""

I will work on this


Use container image build metadata from brew to determine the image name

This is the follow up issue from https://github.com/crc-org/snc/pull/831#discussion_r1512372832 one. As of now inplace image name is updated but in future when component is changed to rhel10 then it again need updated so better to use jq on the image metadata for get the name.
$ curl -L -O https://download.eng.bos.redhat.com/brewroot/packages/crc-cluster-kube-apiserver-operator-container/${version}/${release}/metadata.json
$  jq .build.extra.image.index.pull metadata.json
[
  "registry-proxy.engineering.redhat.com/rh-osbs/openshift-crc-cluster-kube-apiserver-rhel9-operator@sha256:d5706c6abf05f67c1c943b54d6d976887b95ad0b5514fb725b39df4ceb2b24c6",
  "registry-proxy.engineering.redhat.com/rh-osbs/openshift-crc-cluster-kube-apiserver-rhel9-operator:v4.15.0-202403071539.p0.g9fe0ab1.assembly.stream.el9"
]

from pull list we can choose any one because one is with sha256 digest and another one with the tag and both images are same.

Merged


Strange int-to-string attribute conversions

I suspect that it is a bug that the following example compiles:
int main()
{
  std::string result;
  auto b = bp::parse("3", bp::int_, bp::ws, result);
  //                                        ^~~~ storing an int into string
}

Shouldn't some attribute conversion check detect it? This even runs, and returns true.
Full example: https://godbolt.org/z/bMv3er6eY

Nope.  It's just the way std::string works, unfortunately.  This is fine:
std::string str;
str = 3; // Implicit int->char conversion.

That's why your example is well-formed.  You could also have used bp::double_ with similar results.

I would encourage you to special-case the int-to-string, double-to-string conversion.
Converting anything but char to string is an unintended behavior (maybe except for literal 0).
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p2037r1.html
Even assignment from char is fishy: it is like assigning an element to the container of elements.
The only reason the committee decided not to fix it is the backwards compatibility. Clang-tidy warns about it.
You will only do your users a favour by disallowing these (even at the cost of special-casing broken std::string. You have the potential to prevent user bugs, without a risk of breaking any valid user code.

Ha! I forgot you wrote that paper.  I was aware of it.  I voted for it IIRC.  Yeah, that's fair though.  This is super surprising.

Are you sure this one is fixed? THe example above (https://godbolt.org/z/bMv3er6eY) still compiles, even though I would expect it not to.

It's definitely ill-formed on HEAD of master.  Maybe the single header file is stale?


Issues installing with v1.4.0

I get this error when I use the latest version 1.4.0
below is my error
error /Users/farisroslan/Desktop/projects/postco-apps/postco/client/node_modules/react-social-sharing: Command failed.
Exit code: 1
Command: npm run dist:modules
Arguments:
Directory: /Users/farisroslan/Desktop/projects/postco-apps/postco/client/node_modules/react-social-sharing
Output:
><EMAIL_ADDRESS>dist:modules /Users/farisroslan/Desktop/projects/postco-apps/postco/client/node_modules/react-social-sharing
> del-cli ./dist-modules && cross-env BABEL_ENV=modules babel ./src --out-dir ./dist-modules

sh: del-cli: command not found
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>dist:modules: `del-cli ./dist-modules && cross-env BABEL_ENV=modules babel ./src --out-dir ./dist-modules`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>dist:modules script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR!      /Users/farisroslan/.npm/_logs/2018-08-14T06_16_36_346Z-debug.log

v1.3.3 and 1.3.2 work fine
Thanks for the library!

I will fix this today and also most likely clean up all the way these modules are created and just use something like webpack for this :)

Bless you, friend 😃

I'm having similar issues when installing 1.4.1 with yarn:
error /Users/codycody/uturnr/specials/node_modules/react-social-sharing: Command failed.
Exit code: 1
Command: npm run dist:modules
Arguments:
Directory: /Users/codycody/uturnr/specials/node_modules/react-social-sharing
Output:
><EMAIL_ADDRESS>dist:modules /Users/codycody/uturnr/specials/node_modules/react-social-sharing
> cross-env BABEL_ENV=modules babel ./src --out-dir ./dist-modules

events.js:182
      throw er; // Unhandled 'error' event
      ^

Error: spawn babel ENOENT
    at _errnoException (util.js:1019:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:192:19)
    at onErrorNT (internal/child_process.js:374:16)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)
    at Function.Module.runMain (module.js:667:11)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:607:3
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>dist:modules: `cross-env BABEL_ENV=modules babel ./src --out-dir ./dist-modules`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>dist:modules script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR!      /Users/codycody/.npm/_logs/2018-09-09T23_03_13_338Z-debug.log


about pretrained model

Thank you for great work, I would want to know where I can download the pretrained model "ResNet-50-model.keras.h5"

https://github.com/fizyr/keras-models/releases

Thank you very much ^_^


STPrivilegedTask not working when invoking bash

STPrivilegedTask works if interpreter is /bin/sh but not /bin/bash.

But it seems that with a script written in bash, platypus doesn’t  run the script with root privileges.
We had a script, written in sh, which has the root level, everything’s fine in Platypus.
We wanted to do do the same with a script written in bash. But we have seen that in Platypus, the script has the right of the user, not the rights of root.
Is it normal?

I ran in to this issue. Some of the scripts we need to run are written in bash and I noticed that Platypus fails on those scripts.
What's the status with this issue? Is there any plans to fix that? Or maybe there is some workaround for that?

Truth be told, I have no idea what's causing this. /bin/sh is a bash binary (bash being the default shell on macOS), but it's different from /bin/bash. Why? Your guess is as good as mine.
See the following:

Just checked to make sure, this is not an issue with the OS. At least sh & bash have not changed since El Capitan. -v3.2.57

Ok, found the following:

Changing the scripts to sh fixed the issue
Minor errors unnoticed in running from shell (e.g. the script continues) seems to abort the script in Platypus. You need to do verbose checking and error trapping to track this down

#! /bin/bash clearly cannot run as root.

I know that this is an old issue, but it would help note this known issue in the documentation.

Special Options
Run with root privileges: If selected, the application prompts for an Administrator password and executes the script with escalated privileges via Apple's Security Framework. This is not strictly equivalent to running the script as the root user. For details, see the documentation for Apple's Security Framework.
Platypus scripts must not use the 'sudo' command. This causes the script to prompt for input via STDIN, and since no input is forthcoming, the application will hang indefinitely.
Please note that if this option is selected, the script will not print STDERR output due to limitations in the Security APIs. This can be circumvented by using a shell script to execute another script while piping STDERR into STDOUT (e.g. perl myScript.pl 2>&1).
Known issue: /bin/bash scripts cannot run with root privileges.

I know that this is an old issue, but it would help note this known issue in the documentation.

Special Options
Run with root privileges: If selected, the application prompts for an Administrator password and executes the script with escalated privileges via Apple's Security Framework. This is not strictly equivalent to running the script as the root user. For details, see the documentation for Apple's Security Framework.
Platypus scripts must not use the 'sudo' command. This causes the script to prompt for input via STDIN, and since no input is forthcoming, the application will hang indefinitely.
Please note that if this option is selected, the script will not print STDERR output due to limitations in the Security APIs. This can be circumvented by using a shell script to execute another script while piping STDERR into STDOUT (e.g. perl myScript.pl 2>&1).
Known issue: /bin/bash scripts cannot run with root privileges.

@mirkop Done.

@mirkop Done.


Compilation error with react-scripts 4.0.0 ( Can't resolve file )

latest update of react-scripts to 4.0.0 from 3.4.4 causes a compilation problem.
With 3.4.4 it works, and the file exists
./src/styles/mycssfile.css
Error: Can't resolve '/images/module/filename.png' in 'D:\dev\workspace\xxxxxxxxx\src\styles'

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: `react-scripts build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\xxxxxxxxxxxxxx\AppData\Roaming\npm-cache\_logs\2020-10-23T16_16_47_530Z-debug.log

Having a similar issue but with sass url() imports of images in the /public folder

What does the import line look like? What kind of file is it in?
I had the same url() issue as @efeichen and fixed it by moving images to src/.

@jrr background-image: url(/contact-clip.svg); it's in a sass file in /src/scss
I'd like to move the images to src/ since I believe the relative path from the sass file to the image is working (but can't do that for images in public because of the can't import from outside src restriction), but I'd prefer not to unless absolutely necessary. Thanks for the tip though!

I have the same problem with SCSS and CSS files (images and fonts). In 3.x.x works but now it says it can't resolve the file in src.

I also have a problem when loading fonts from public folder. It did work in 3.x.x

I had the exact same issue, it started just today when I upgraded to 4.0.0
src: url(/fonts/josefin-sans-regular.ttf)

And it leads to the error:
Error: Can't resolve '../fonts/josefin-sans-regular.ttf' in '.\frontend\src\scss'

I had this error on a project that was using absolute imports. It seems like setting NODE_PATH=src/ in the .env file is no longer supported. I instead had to use a jsconfig.json as described here: https://code.visualstudio.com/docs/languages/jsconfig
{
  "compilerOptions": {
    "baseUrl": "src"
  },
  "include": ["src"]
}

I'm also seeing this issue where we have an image in /public but it's not getting resolved. Error:
./src/styles/style.css (./node_modules/css-loader/dist/cjs.js??ref--4-oneOf-4-1!./node_modules/postcss-loader/src??postcss!./src/styles/style.css) Error: Can't resolve '/bg.jpg' in '/mnt/c/git/application/src/styles'

Can confirm this happens with url() calls in @font-face directives as well as per<EMAIL_ADDRESS>For instance:
@font-face {
  font-family: 'Nunito';
  font-style: normal;
  font-weight: normal;
  font-display: swap;
  src: local('Nunito Bold'), local('Nunito-Bold'), url('/fonts/nunito.woff2') format('woff2');
}

./src/index.css (./node_modules/css-loader/dist/cjs.js??ref--5-oneOf-4-1!./node_modules/postcss-loader/src??postcss!./src/index.css)
Error: Can't resolve '/fonts/nunito.woff2' in '/Path/To/Project/src'

To be fair, there was a warning in v3.4.4

But this does not solve the style issues using url() referencing images from public folder

It's possible to disable this validation?

this is crazy! no testing seriously? I broke a production app before deploying thank God!
you have not even mentioned this anywhere??

this is crazy! no testing seriously? I broke a production app before deploying thank God!
you have not even mentioned this anywhere??

What? Who is "you"?

this is crazy! no testing seriously? I broke a production app before deploying thank God!

Chill. Also, this is a major update. That implies breaking changes.

this is crazy! no testing seriously? I broke a production app before deploying thank God!
you have not even mentioned this anywhere??

@x5engine What? Who is "you"?

Who dis new phone?
I am the engine.

this is crazy! no testing seriously? I broke a production app before deploying thank God!

Chill. Also, this is a major update. That implies breaking changes.

Yeah man I was going nuts.
Hope this gets sorted out soon 🙂

running the same issue... waiting for clues

If you care to dive into the react-scripts webpack setup, you can pass in the option to disable url routing to css-loader. In node_modules/react-scripts/config/webpack.config.js on line 121 change
options: cssOptions,

to
options: {...cssOptions, url: false},

Of course this entails all the issues that come around with modifying the config inside of node_modules, but hopefully this might help in a long term fix for the change in css-loader resolving the urls.

Looking at css-loader it looks like they're not going to fix it https://github.com/webpack-contrib/css-loader/issues/1136#issuecomment-664984703
You would have to include /public to the resolve paths. I just moved my assets to /src as I didn't want to eject

For those used to patch-package, here's the patch based on @elylucas workaround
diff --git a/node_modules/react-scripts/config/webpack.config.js b/node_modules/react-scripts/config/webpack.config.js
index 80c6ac2..01de68e 100644
--- a/node_modules/react-scripts/config/webpack.config.js
+++ b/node_modules/react-scripts/config/webpack.config.js
@@ -117,7 +117,7 @@ module.exports = function (webpackEnv) {
       },
       {
         loader: require.resolve('css-loader'),
-        options: cssOptions,
+        options: {...cssOptions, url: false},
       },
       {
         // Options for PostCSS as we reference these options twice

I had an issue loading fonts from within CSS. But thanks to @evilebottnawi pointing out how webpack/css-loader@4+ resolves URLs i was able to fix my issues:

/font/font.woff2 never was and never can be ./font/font.woff2, please read spec about URL resolving in CSS

I use rsuite as a UI framework. To override default icon font settings you can set a less variable @icon-font-path to suit your needs. I did that in a way which worked when using webpack/css-loader@3 but needed to be changed like displayed below to avoid issues when using webpack/css-loader@4.
/src/app/styles/rsuite/index.less:
-      @import '../../../../node_modules/rsuite/lib/styles/themes/default/core';
+      @import './node_modules/rsuite/lib/styles/themes/default/core';

-      @icon-font-path: '/fonts/rsuite-icon';
+      @icon-font-path: './fonts/rsuite-icon';

My icon font is located in /public/fonts/rsuite-icon.
Maybe this helps by getting the idea of how URLs are resolved.

We had the same issue when trying out CRA 4. Btw. this seems to effect a lot of people, it's been reported in multiple issues:
https://github.com/facebook/create-react-app/issues/9937
https://github.com/facebook/create-react-app/issues/9992
https://github.com/facebook/create-react-app/issues/10022

I have the same issue with Can't resolve './animations.scss'

Here's a fix with react-app-rewired for css files with absolute links. In your config-override.js, do:
const getCssLoaders = config => {
  const loaderFilter = rule => rule.loader && rule.loader.includes('/css-loader')

  let loaders = config.module.rules.find(rule => Array.isArray(rule.oneOf)).oneOf

  loaders = loaders.reduce((ldrs, rule) => ldrs.concat(rule.use || []), [])

  return loaders.filter(loaderFilter)
}

/**
 * Overrides a create-react-app configuration for the given sources.
 *
 * @param src Source path of the create-react-app project.
 */
module.exports = src => {
  return (config, env) => {
    // Fix url('/images/....') being processed by css-loader 4 =/
    for (const loader of getCssLoaders(config)) {
      loader.options.url = url => url.startsWith('.')
    }

    return config
  }
}

If you care to dive into the react-scripts webpack setup, you can pass in the option to disable url routing to css-loader. In node_modules/react-scripts/config/webpack.config.js on line 121 change
options: cssOptions,

to
options: {...cssOptions, url: false},

Of course this entails all the issues that come around with modifying the config inside of node_modules, but hopefully this might help in a long term fix for the change in css-loader resolving the urls.

Great 👯 It's worked.

Having the same problem with CRA 4.0.1: paths in css/url does not resolve and break the  process
@font-face {     font-family: "percolate";     src: url("/icon/percolate.eot"); /* here is the error */     font-weight: normal;     font-style: normal; }
the assets are in public folder

If you care to dive into the react-scripts webpack setup, you can pass in the option to disable url routing to css-loader. In node_modules/react-scripts/config/webpack.config.js on line 121 change
options: cssOptions,

to
options: {...cssOptions, url: false},

Of course this entails all the issues that come around with modifying the config inside of node_modules, but hopefully this might help in a long term fix for the change in css-loader resolving the urls.

It works, thanks!

Our product needs more nuanced resolution. Setting url: false will then prevent relative file paths from resolving. Best of both worlds may be adding conditional resolution, something like:
  // ...
  options: {
    ...cssOptions,
    url: url => !url.startsWith(‘/’)
  },
  // ...

When compiled, /example.jpg will still be /example.jpg but ./local.jpg will be <dynamic_path>/local.<hash>.jpg.

my solution with react-app-rewired, in webpack function in config-overrides.js, paste in following lines:
// override css loader rules due to bug: https://github.com/facebook/create-react-app/issues/9870
    const cssLoaderRules = config.module.rules[1].oneOf.filter(rule => rule.use);
    cssLoaderRules.forEach(rule => {
      const cssLoader = rule.use[1];
      cssLoader.options.url = false;
    })
    process.stdout.write('**** overrided CRA webpack css loader rules **** \n')
    process.stdout.write(JSON.stringify(cssLoaderRules)+"\n");
    process.stdout.write('\n')

It just turn off url() resolving of static assets by css-loader.

my solution with react-app-rewired, in webpack function in config-overrides.js, paste in following lines:
// override css loader rules due to bug: https://github.com/facebook/create-react-app/issues/9870
    const cssLoaderRules = config.module.rules[1].oneOf.filter(rule => rule.use);
    cssLoaderRules.forEach(rule => {
      const cssLoader = rule.use[1];
      cssLoader.options.url = false;
    })
    process.stdout.write('**** overrided CRA webpack css loader rules **** \n')
    process.stdout.write(JSON.stringify(cssLoaderRules)+"\n");
    process.stdout.write('\n')

It just turn off url() resolving of static assets by css-loader.

I'm surprised that more people haven't realised that this is a major concern for SEO.
Lets say that you have a image file within the src folder, and you're using it within your CSS file like this -
.Profile {
text-align: center;
background-image: url("../../images/user/profile.png");
}
If this profile.png file is inside the src > images > user directory, then while creating a build with react-scripts, the URL generated for this file will be something like this -
https://{my-domain.com}/static/media/profile.{hash}.jpg
This {hash} value changes with every build. Therefore, if you use this in a static website, and if your website is crawled by google bot, you may see 404's reported in the google search console the next time you deploy, because Google can take several weeks before indexing your site again.
This is where an image in the public folder would have helped, because that URL will never change, and can safely remain indexed in search engines.

I'm surprised that more people haven't realised that this is a major concern for SEO.
Lets say that you have a image file within the src folder, and you're using it within your CSS file like this -
.Profile {
text-align: center;
background-image: url("../../images/user/profile.png");
}
If this profile.png file is inside the src > images > user directory, then while creating a build with react-scripts, the URL generated for this file will be something like this -
https://{my-domain.com}/static/media/profile.{hash}.jpg
This {hash} value changes with every build. Therefore, if you use this in a static website, and if your website is crawled by google bot, you may see 404's reported in the google search console the next time you deploy, because Google can take several weeks before indexing your site again.
This is where an image in the public folder would have helped, because that URL will never change, and can safely remain indexed in search engines.

Does Google even index images from CSS backgrounds?

Does Google even index images from CSS backgrounds?

I ran into this when upgrading a large project to the latest react-scripts.  All css url('/assets') imports break due to absolute path changes in css-loader.  My workaround isn't ideal but it allows compilation without major refactors.

Keep all your assets in /public/assets because any jsx needs eg.
Create a new directory /src/assets.
Any time you are using css (or sass) url imports copy the file into the /src/assets folder
Replace absolute paths with relative ones in the css import.  Eg.  replace  url('/assets/file.png') with url('../../assets/file.png')

I ran into this when upgrading a large project to the latest react-scripts.  All css url('/assets') imports break due to absolute path changes in css-loader.  My workaround isn't ideal but it allows compilation without major refactors.

Keep all your assets in /public/assets because any jsx needs eg.
Create a new directory /src/assets.
Any time you are using css (or sass) url imports copy the file into the /src/assets folder
Replace absolute paths with relative ones in the css import.  Eg.  replace  url('/assets/file.png') with url('../../assets/file.png')

Please update webpack to the latest version (v4)

Please update webpack to the latest version (v4)

Hello, guys,
I've also faced this issue after updating to 4.0.0 (or actually 4.0.1).
As a workaround I use declaring background image right in JSX, like you know:

It works, because obviously css-loader has nothing to do with JSX files.
And it works for me, because code is arranged in a way where background can be changed depending on the section of application. In other words I use 1 component with several times with different images or maybe in different projects.
As for other projects, I'd like to join collective resentment. It seems to be strange to store images in src and I certainly don't have a teeny tiny intention to mess with webpack :-)

Hello, guys,
I've also faced this issue after updating to 4.0.0 (or actually 4.0.1).
As a workaround I use declaring background image right in JSX, like you know:

It works, because obviously css-loader has nothing to do with JSX files.
And it works for me, because code is arranged in a way where background can be changed depending on the section of application. In other words I use 1 component with several times with different images or maybe in different projects.
As for other projects, I'd like to join collective resentment. It seems to be strange to store images in src and I certainly don't have a teeny tiny intention to mess with webpack :-)

Does Google even index images from CSS backgrounds?

It does. Images show up in google image search results.

Does Google even index images from CSS backgrounds?

It does. Images show up in google image search results.

@sagar7993 They say otherwise: https://developers.google.com/search/docs/advanced/guidelines/google-images

@sagar7993 They say otherwise: https://developers.google.com/search/docs/advanced/guidelines/google-images

Also experiencing the same issue using react-scripts 4.0.1. The comments in https://github.com/webpack-contrib/css-loader/issues/1136 are less than helpful. I have an image in <root>/public/assets I am trying to reference in the css as
background-image: url(/assets/image.jpg);

and am getting
./src/App.css (./node_modules/css-loader/dist/cjs.js??ref--5-oneOf-4-1!./node_modules/postcss-loader/src??postcss!./src/App.css)
Error: Can't resolve '/assets/image.jpg' in '<root>/src'

The options as I see it are:

Move the image into src and avoid the css-loader altogether. Would prefer not to as means changing the logical structure of my project just to workaround a problem with tooling.
Use root relative urls in css ie /public/assets/image.jpg. Fails with the error message

./src/App.css (./node_modules/css-loader/dist/cjs.js??ref--5-oneOf-4-1!./node_modules/postcss-loader/src??postcss!./src/App.css)
Module not found: You attempted to import ../public/assets/image.jpg which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.

Eject and switch off url checking in css-loader. I lose automatic updates to react-scripts (including potentially a fix to this problem), and kinda negates the point of the changes in css-loader in the first place.
Use react-app-rewired to override and do the option 3 above without ejecting as described here and here. Probably the best option, but again negates the point of the css-loader changes and means adding a layer of overrides over something that should just work.

Is there any improvement on this, and what would be needed to be changed in create-react-app/react-scripts to get url() to just work with the <root>\public directory in react apps?

Also experiencing the same issue using react-scripts 4.0.1. The comments in https://github.com/webpack-contrib/css-loader/issues/1136 are less than helpful. I have an image in <root>/public/assets I am trying to reference in the css as
background-image: url(/assets/image.jpg);

and am getting
./src/App.css (./node_modules/css-loader/dist/cjs.js??ref--5-oneOf-4-1!./node_modules/postcss-loader/src??postcss!./src/App.css)
Error: Can't resolve '/assets/image.jpg' in '<root>/src'

The options as I see it are:

Move the image into src and avoid the css-loader altogether. Would prefer not to as means changing the logical structure of my project just to workaround a problem with tooling.
Use root relative urls in css ie /public/assets/image.jpg. Fails with the error message

./src/App.css (./node_modules/css-loader/dist/cjs.js??ref--5-oneOf-4-1!./node_modules/postcss-loader/src??postcss!./src/App.css)
Module not found: You attempted to import ../public/assets/image.jpg which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.

Eject and switch off url checking in css-loader. I lose automatic updates to react-scripts (including potentially a fix to this problem), and kinda negates the point of the changes in css-loader in the first place.
Use react-app-rewired to override and do the option 3 above without ejecting as described here and here. Probably the best option, but again negates the point of the css-loader changes and means adding a layer of overrides over something that should just work.

Is there any improvement on this, and what would be needed to be changed in create-react-app/react-scripts to get url() to just work with the <root>\public directory in react apps?

@donal-s
Or option 5, see @atiastudio comment.  Change any css url imports to jsx

@donal-s
Or option 5, see @atiastudio comment.  Change any css url imports to jsx

I am no expert but I have an easy fix to this css image issue. I used react style attribute (inline) for the image path. and did the rest of the styling in css. That way you can still support styling like background-attachment: fixed and so forth

I am no expert but I have an easy fix to this css image issue. I used react style attribute (inline) for the image path. and did the rest of the styling in css. That way you can still support styling like background-attachment: fixed and so forth

I'd suggest there is a difference between fix and workaround. A fix would be the tooling not inhibiting the dev from using the existing css url() feature inside a css file (as opposed to inline style attributes), and being able to reference assets where many (not all of course) would think is the most logical place (the public folder).
The workarounds all share one common feature - ways to switch off or bypass the new url() checks from css-loader, which is not ideal, and also all have some level of hack around what a dev would normally do here to get an image/font/whatever referenced from css.
Currently, all we have are workarounds, so I guess that's what we make do with for now :)

I'd suggest there is a difference between fix and workaround. A fix would be the tooling not inhibiting the dev from using the existing css url() feature inside a css file (as opposed to inline style attributes), and being able to reference assets where many (not all of course) would think is the most logical place (the public folder).
The workarounds all share one common feature - ways to switch off or bypass the new url() checks from css-loader, which is not ideal, and also all have some level of hack around what a dev would normally do here to get an image/font/whatever referenced from css.
Currently, all we have are workarounds, so I guess that's what we make do with for now :)

As developer of css-loader, I want to say that css-loader supported /images/image.png in url, CRA should add src to resolver.roots (and using /images/image.png will be resolved as /src/images/image.png, it is default behavior for webpack@5)

As developer of css-loader, I want to say that css-loader supported /images/image.png in url, CRA should add src to resolver.roots (and using /images/image.png will be resolved as /src/images/image.png, it is default behavior for webpack@5)

Anyway we can implement:
div {
  /** webpackIgnore **/
  background: url(/images/image.png);
}

and don't touch this url, if somebody want this, feel free to open a new issue in css-loader

Anyway we can implement:
div {
  /** webpackIgnore **/
  background: url(/images/image.png);
}

and don't touch this url, if somebody want this, feel free to open a new issue in css-loader

As developer of css-loader, I want to say that css-loader supports /images/image.png in url, CRA should add src to resolver.roots (and using /images/image.png will be resolved as /src/images/image.png, it is default behavior for webpack@5)

Would adding public to resolver.roots mean that adding url(/assets/image.png) correctly resolves to <rootdir>/public/assets/image.png? I think that's what we want.

As developer of css-loader, I want to say that css-loader supports /images/image.png in url, CRA should add src to resolver.roots (and using /images/image.png will be resolved as /src/images/image.png, it is default behavior for webpack@5)

Would adding public to resolver.roots mean that adding url(/assets/image.png) correctly resolves to <rootdir>/public/assets/image.png? I think that's what we want.

@donal-s Yes, just add public to resolver.roots

@donal-s Yes, just add public to resolver.roots

I had a scan of webpack, css-loader, and react-scripts. I'm still not clear on what exactly needs to be changed where in react-scripts to fix this issue. Could someone more familiar with these projects take a look at applying @alexander-akait 's suggestion please?

I had a scan of webpack, css-loader, and react-scripts. I'm still not clear on what exactly needs to be changed where in react-scripts to fix this issue. Could someone more familiar with these projects take a look at applying @alexander-akait 's suggestion please?

I had a scan of webpack, css-loader, and react-scripts. I'm still not clear on what exactly needs to be changed where in react-scripts to fix this issue. Could someone more familiar with these projects take a look at applying @alexander-akait 's suggestion please?

You can use this @elylucas with url. It helped me
Open node_modules\react-scripts\config\webpack.config.js
change options for css loader for options: {...cssOptions, url: url => !url.startsWith('/')},
Waiting for a fix

I had a scan of webpack, css-loader, and react-scripts. I'm still not clear on what exactly needs to be changed where in react-scripts to fix this issue. Could someone more familiar with these projects take a look at applying @alexander-akait 's suggestion please?

You can use this @elylucas with url. It helped me
Open node_modules\react-scripts\config\webpack.config.js
change options for css loader for options: {...cssOptions, url: url => !url.startsWith('/')},
Waiting for a fix

To the above list of workarounds, I can add the following pragmatic one if you are facing this error while trying to load local fonts from the public folder:
Add (for the time being) the style in your index.html.


Support --allhomes for dockutil

Managing a device with multiple user using the ansible dock role is complicated
due to the role not supporting the --allhomes or the dock-plist.
It would be great supporting either of the options.
A problem with that is that this would require the role potentially needing
to become root.
Getting the dock position would probably be a lot more complicated, too.
Maybe it would be easier just passing the plist location and a user potentially running/including
the role multiple times.
Thanks for all the hard work you put into all your roles!

For people in the future stumbling upon this issue:
I did workaround this issue not using the role, but just creating the dock and copying
the plist to every user.
Its far from perfect, but works for me at the moment.

As long as the feature wouldn't require root (e.g. if someone didn't specify the option), I'd be okay with accepting a PR that doesn't break the existing default one-use use case. It seems niche enough though (most users sharing a Mac would probably have different apps/dock layouts), that I'd rather not add too much complexity here.


Work with researchers as they run through use cases

Get devs working with users for rapid feedback.
┆Issue Number: HCAB-389

We have talked to researchers at the DCP F2F and with various tertiray portal groups, inclucing Terra, SCP, Single Cell Expression Atlas, Xena, and UCSC Cell Browser.


Revert "New version: ModelingToolkit v1.5.0 (#12792)"

This MTK v1.5 tag since it was more breaking than I thought, and is replaced with a 2.0 tag.

Please yank instead....


hotfix: #696 oc namespace config

Update the pr-open.yml to have a specific environment defined

Thanks for the PR!
Any successful deployments (not always required) will be available below.

api
admin
public

Once merged, code will be promoted and handed off to following workflow run.

Main Merge Workflow

I assume this works because you are removing the OC_NAMESPACE repository variable and just leaving it as an environment variable, including for a new dev environment?

That's exactly it

@craigyu We probably don't need this PR anymore.  I just removed the var completely in this pr!  https://github.com/bcgov/nr-fom/pull/701

@craigyu We probably don't need this PR anymore. I just removed the var completely! #701

Looks like magic and a better solution to me

done in #701


ProlificDreamer seperate gradient propagation

It seems in the original paper they do gradient steps on scene parameters first and then on LoRA parameters (i.e. the VSD loss does not propagate gradients to LoRA parameters). However here the two loss terms are added so VSD loss does propagate gradient to LoRA parameters. Is there a reason for this?

I believe VSD loss is computed with torch.no_grad() when estimating the noise using the LoRA unet. So there is no problem.

You're right. Thanks. Closing this issue.


Cesium inspector: terrain crashes

Run the Cesium inspector example.

Terrain - Pick a tile.  Click on the globe without changing the view.
Click NW under Select relative.
Check Show only selected.

I think we just need to tighten up what the UI allows a bit.  I also ran into exceptions about upsampling.
This is in b27 and master.

Duplicate #2448


cheveron -> chevron

Same as #24, but this is more general.
See https://github.com/refactoringui/heroicons/issues/50
Your website still says cheveron, which is now out of date

Yeah. This changed very recently. I updated the site to reflect this change yesterday. Thanks for creating an issue! Will close this.


Undefined index: relative_file (ClassReflection.php)

I'm trying to update my PHP documentation with:
php vendor/sami/sami/sami.php update sami.php

and keep hitting this error:
[ErrorException]
  Notice: Undefined index: relative_file in ...snip.../vendor/sami/sami/Sami/Reflection/ClassReflection.php line 484

Same happens with --force. Trace output with -vvv:
Exception trace:
 () at vendor/sami/sami/Sami/ErrorHandler.php:42
 Sami\ErrorHandler->handle() at vendor/sami/sami/Sami/Reflection/ClassReflection.php:484
 Sami\Reflection\ClassReflection::fromArray() at vendor/sami/sami/Sami/Store/JsonStore.php:55
 Sami\Store\JsonStore->readProject() at vendor/sami/sami/Sami/Project.php:343
 Sami\Project->read() at vendor/sami/sami/Sami/Project.php:151
 Sami\Project->switchVersion() at vendor/sami/sami/Sami/Project.php:110
 Sami\Project->update() at vendor/sami/sami/Sami/Console/Command/Command.php:79
 Sami\Console\Command\Command->update() at vendor/sami/sami/Sami/Console/Command/UpdateCommand.php:52
 Sami\Console\Command\UpdateCommand->execute() at vendor/symfony/console/Command/Command.php:259
 Symfony\Component\Console\Command\Command->run() at vendor/symfony/console/Application.php:878
 Symfony\Component\Console\Application->doRunCommand() at vendor/symfony/console/Application.php:195
 Symfony\Component\Console\Application->doRun() at vendor/symfony/console/Application.php:126
 Symfony\Component\Console\Application->run() at vendor/sami/sami/sami.php:14

(Paths have been altered in the above trace.)
The project is nothing spectacular, a WordPress theme where vendor sits inside the theme's directory. No major* code changes have happened and the Sami error popped up out of the blue.
I'm running Ubuntu 14.04, Apache 2.4 and PHP 5.5+. Composer and Sami are at their latest versions.
(* not sure how major is major for Sami.)

The cache format has changed in recent Sami version (some keys added) and what's happening is that you're restoring cache from older Sami version.
I recommend you deleting cache folder and you should fine.

Oh didn't think of that. Now it worked fine again. Many thanks!


add coolify-proxy to uninstall.mdx

I tried to uninstall coolify from my system and when removing the docker network it prompted me that there was still as service running in that network. The cause was coolify-proxy not being removed in the previous steps.

Thank you for the PR!