Sound

Implement support for sound (looks tricky :-1: )

Good luck!

Hi,
I've also written a gameboy emulator in go. (DMG only) but i have working sound. If you need any help let me know.

hey @boombuler thanks, will be picking this up at some point I think!

If you do, feel free to reach out to me as well! I have sound working, and apparently I did an alright job first go. I have all the weird voices that are generated using the wave channel working 😄 Though I fail a bunch of sound tests for blarggs tests 🙃


Key bindings use default keyboard layout rather than the current one

Description
After upgrading from 1.8.0 to 1.12.5, Atom uses the default keyboard layout rather than the current one when resolving key bindings. If this non-standard behaviour is intended, there should be a switch in the settings that disables it.
Steps to Reproduce

Change your default keyboard layout to a QWERTZ layout (e.g. Czech).
Change your active keyboard layout to English (QWERTY).
Open the Key Binding Resolver.
Press Ctrl-Z.

Expected behavior: core:undo is executed.
Actual behavior: core:redo is executed.

In Atom 1.12.5 there is an issue where the keyboard layout does not update correctly if you change layouts while Atom is running. This has been fixed on master and will go out in the next hotfix release.

@Ben3eeE I can reproduce the same behaviour by changing the keyboard layout settings when Atom is not running. Are you sure this is the same issue?

Actually just realized that I can't be sure since your issue is missing information. What operating system are you using?

Linux Mint 17.1 Cinnamon

Do you see the same behavior in the keybinding resolver when using another modifier than Ctrl?

No. If I add a binding for Alt-Z or just Z, it works fine.

@cifkao Your issue is a duplicate of https://github.com/atom/atom/issues/13170. This was previously only known to happen on colemak but given your added information of the same behavior with qwerty and qwertz I am assuming it happens with any layout. Thank you for your report 🙇


[locale,keyboard] fix keyboard mapping on apple

fix the client side mapping for x11 keycodes on apple

@freerdp-bot test

@freerdp-bot test properly!

Works!  The real fix was the missing keycode - 8.


support eth in 3lang

Related issues

https://github.com/threefoldtech/web3_proxy/issues/119

CI should pass after merging https://github.com/freeflowuniverse/crystallib/pull/177

i just have a small suggestion if it is okay

was just discussing this with @brandonpille , will update. thanks!

Merging into archive until discussion is done over web3 proxy


filter: add language http filter "accept-language"

Commit Message:
filter: add a new anguage filter "accept-language"
Additional Description:
The language detection filter (i18n) picks the best match between a client's desired locales and an application's supported locales.
Parses a list of locales from an Accept-Language header RFC 2616 Section 14.4
and adds a new x-language header to the request.
The filter uses Unicode ICU for locale parsing.
    // Multiple types, weighted with the quality value syntax:
    Accept-Language: fr-CH, fr;q=0.9, en;q=0.8, *;q=0.5

The client is from the Romandy region and prefers Swiss French, the variety of French spoken in the French-speaking area of Switzerland
The client sends an Accept-Language header
An Accept-Language header indicates the natural language and locale that the client prefers
The application is only configured to match French fr
The filter sets the value of the x-language header to fr

The language detection filter outputs statistics in the http.<stat_prefix>.language. namespace.
Risk Level:
Low
Testing:
Adds integration tests
Docs Changes:
Adds a new documentation page for the language filter
Release Notes:
Platform Specific Features:

Example configuration
Minimal filter configuration:
  name: envoy.filters.http.language
  typed_config:
    "@type": type.googleapis.com/envoy.extensions.filters.http.language.v1.Language
    default_language: en
    supported_languages: [en, en-uk, de, dk, es, fr, zh, zh-tw]

The above configuration can be understood as follows:

Try to pick the client's desired locale from an Accept-Language header
At any point the filter uses Unicode ICU for locale parsing
If the client's desired locale can not be picked, for example because the client provided an invalid value, the Language.default_language option will be used as a fallback

Example configuration
Minimal filter configuration:
  name: envoy.filters.http.language
  typed_config:
    "@type": type.googleapis.com/envoy.extensions.filters.http.language.v1.Language
    default_language: en
    supported_languages: [en, en-uk, de, dk, es, fr, zh, zh-tw]

The above configuration can be understood as follows:

Try to pick the client's desired locale from an Accept-Language header
At any point the filter uses Unicode ICU for locale parsing
If the client's desired locale can not be picked, for example because the client provided an invalid value, the Language.default_language option will be used as a fallback

@htuch before I take another pass on this, can you remind me why icu was removed?

I'm not familiar with Windows. The msvc-cl pipeline fails to compile libicu with the following error
checking whether the C compiler works... no
...
configure: error: C compiler cannot create executables

ICU is pretty scary from a security perspective, see the numerous CVEs https://www.cvedetails.com/vulnerability-list/vendor_id-17477/Icu-project.html. @yanavlasov also has some experience with this, there is substantial history in the non-public https://github.com/envoyproxy/envoy-setec/issues/196.
Not super excited to bring this back into the Envoy repository TBH, but willing to be persuaded.

@htuch The extension only uses a very limited subset of ICU, in particular icu::Locale and the icu::LocaleMatcher. ICU 67.1 (launched in April 2020) comes with an improved icu::LocaleMatcher API and implementation. The generated ICU data file is minimal.

@diceride that reminds me that we've had some outages with ICU artifacts that were supposed to be linked in but weren't present on the system. I'm going to defer to @yanavlasov here as he is ICU expert and also it would be good to hear from other @envoyproxy/dependency-shepherds like @moderation @wrowe. If there is consensus that a limited use of ICU for this application is OK that's fine by me, but I'm a little concerned we're undoing a deliberative historical choice on deps here.

If there is consensus that a limited use of ICU for this application is OK that's fine by me, but I'm a little concerned we're undoing a deliberative historical choice on deps here.

If we are talking about parsing locale data, or simply transforming between charsets, ICU is fine and more portable on Windows than the GPL iconv. If we bring this in we might want to cautiously limit what components we configure for, much like we've done for curl. The windows build could be adjusted, ping me, but as long as we follow the RFC our own implementation of locale code matching and basic validation would be trivial.
ICU is maintained and as close to a reference implementation as we can get.

The windows build could be adjusted

Note that our convention has been to use CMake (foreign_cc) builds
in the absence of bazel-build for these dependencies. Autoconf has
been strongly avoided. I'll have a look to see if the current ICU release
can be realistically built on win32, or if this filter simply won't be built
on windows at all.

This filter now only matches the desired locale of a client using the Accept-Language header and nothing more. The support to match the desired locale of a client using a query parameter value or a cookie value was removed.
This simplifies the API and improves security, as only the getBestMatchForListString() method of the icu LocaleMatcher class is used.

This filter now only matches the desired locale of a client using the Accept-Language header and nothing more. The support to match the desired locale of a client using a query parameter value or a cookie value was removed.
This simplifies the API and improves security, as only the getBestMatchForListString() method of the icu LocaleMatcher class is used.

The support to match the desired locale of a client using a query parameter value or a cookie value was removed.
This filter now only matches the desired locale of a client using the Accept-Language header. It simplifies the API and improves security, as only the getBestMatchForListString() method of the icu LocaleMatcher class is used.

Moved the extension to the contrib directory and registered it as a contrib extension
Renamed the API version from v3 to v3alpha
Disabled Windows support
Updated the documentation and added a warning that Windows support is disabled
Updated the documentation and added a warning that this filter is experimental

Moved the extension to the contrib directory and registered it as a contrib extension
Renamed the API version from v3 to v3alpha
Disabled Windows support
Updated the documentation and added a warning that Windows support is disabled
Updated the documentation and added a warning that this filter is experimental

Added a new method validateHeaderValue to determine whether the Accept-Language header value is compliant with the specification before parsing the header value using the getBestMatchForListString() method of the icu LocaleMatcher class.

@diceride please fix CI.

The CI is failing due to the following error
ERROR: Contrib extensions require at least 2 owners in CODEOWNERS:

Moved the initialization of the default locale and the locale matcher to the filter config object
Made the default locale and the locale matcher immutable
Added a new filter config test
Updated the CODEOWNERS file to bypass the missing sponsor warning (self-sponsoring)

Moved the initialization of the default locale and the locale matcher to the filter config object
Made the default locale and the locale matcher immutable
Updated the CODEOWNERS file to bypass the missing sponsor warning (self-sponsoring)

My computer can't handle the workload to run these tests so I'm outsourcing it to the CI for the moment.

My computer can't handle the workload to compile these tests so I'm outsourcing it to the CI for the moment.

There was a typo in the handle.
@yanavlasov

@yanavlasov @wrowe

/lgtm deps

@htuch there is a remaining comment by @adisuissa for the bazel/repository_locations.bzl file. Can you take a look whether the use_category property should be changed?

@htuch there is a remaining comment by @adisuissa for the bazel/repository_locations.bzl file. Can you take a look whether the use_category property should be changed?

@diceride I left a comment - we don't need to block merging this PR on that, but we should follow up ideally.

@htuch I will follow up on this in a separate PR as suggested by you in https://github.com/envoyproxy/envoy/pull/20143#discussion_r839147761.
@yanavlasov Ready to be reviewed again.

Restarted the CI as the Azure build pipeline ran out of disk space the last time.

One of the Azure build pipeline steps ran out of disk space. Force-pushed to restart the CI.

One of the Azure build pipeline steps ran out of disk space. Force-pushed to restart the CI.

One of the Azure build pipeline steps ran out of disk space multiple times now. Rebased and force-pushed to restart the CI.

https://github.com/envoyproxy/envoy/issues/20619

Rebased and force-pushed to restart the CI.

Please, do not rebase. You can simply push an empty commit (--allow-empty) to shake the CI.

One of the Azure build pipeline steps is still running out of disk space.

Added a new commit to prevent one of the Azure build pipeline steps to run out of disk space.
@wrowe @yanavlasov

Added a new commit to prevent one of the Azure build pipeline steps from running out of disk space.
@wrowe @yanavlasov

This is good to go. Please resolve conflicts and then I will merge.

/wait

@wrowe I know that. I squashed some previous empty commits that had missing or wrong DCO signatures, without rewriting the tree to the point of the changes.

@wrowe I know that. I squashed some previous empty commits that had missing or wrong signatures, while only rewriting the tree to the point of changes as the DCO check was failing.

/retest

@wrowe I know that. I squashed some previous empty commits that had missing or wrong signatures, while only rewriting the tree to the point of changes as the DCO check was failing. I did not know that I can issue commands to repokitteh to retry single build steps, instead of using empty commits.
@yanavlasov I resolved the merge conflicts, can you check again? Thank you.

@wrowe I know that. I squashed some previous empty commits that had missing or wrong signatures, while only rewriting the tree to the point of changes as the DCO check was failing. I did not know that I can issue commands to repokitteh to retry single build steps, instead of using empty commits.
@yanavlasov I resolved the merge conflicts.

@diceride can you merge main - it seems like there are some changes in this PR that are already present on main

I'll merge once the change in .azure-pipelines/pipelines.yml is resolved
/wait

Dropped the pipeline commits and merged with main.

Great work! We had a similar need and didn't get around to adding this functionality yet. Thanks!


Get latest lean4 version

I just realized in the case where there is no leanpkg.toml file (as per the quickstart my vscode PR won't work because the elan-init command line I'm calling with no args, results in installing lean3.  but I don't want to bake "leanprover/lean4:nightly-2021-10-01" into the vscode extension, so can we change elan to support a latest version request?
elan-init.exe --default-toolchain "leanprover/lean4:latest"

Solution is to use elan-init.exe --default-toolchain leanprover/lean4:nightly


Layout home login

Layout UX

Update header and footer
Mobile navigation and set-view-port

Closes #214
Landing UX

New homepage that includes searching for domains
Uses existing search operations/reducer/etc

Testing instructions found here: https://hackmd.io/KGgS_rtpTUyhcQ4OgVcmvg
no github issue
Login UX

Adds new login button in the top right that allows you to login and switch between domains
Adds a loading screen while logging in. Mostly used when switching between networks

Testing instructions: https://hackmd.io/Q1UnRFltT8SZiKaORTcaIw
Closes #193
Closes #191
Misc

Fixes an issue where subdomains could not log in. commit 2f43a62

Header:

Does it feel better if search takes to landing page?

Landing page:

Search's placeholder should be 'Find your domain'
Images are blurred. Do we have them in high resolution?
Cost effective text should be: 'Acquiring a personalized RNS domain for your blockchain address costs less than a dollar. Moreover, the domain owner can create associated subdomains with no additional cost.'
In 'are you a developer?' section, each box should have a link:

Read documentaiton: https://developers.rsk.co/rif/rns
Collaborate: https://github.com/rnsdomains
Integrate with rns: https://developers.rsk.co/rif/rns/integrate
Ask: https://gitter.im/rsksmart/rif-name-service

Footer:

Wrong links:

Rif whitepaper: https://www.rifos.org/assets/whitepapers/rif-whitepaper-en.pdf
Roadmap: https://www.rifos.org/directory#roadmap
Contact: https://gitter.im/rsksmart/rif-name-service
Developers whitepaper: https://www.rifos.org/nameservice/assets/rns-specs/rif-directory-protocol-en.pdf
Docs: https://developers.rsk.co/rif/rns
Privacy policy: https://www.rifos.org/privacy-policy
Terms and conditions: https://www.rifos.org/terms-conditions

Search flow: all good!
Login: all good

It has a strange behaviour when logging in. All the screen goes loading for a while. We can improve this for next releases.

Excellent job! Looks great.


Extends aad app add with returning Directory ID. Closes #2187

Extends aad app add with returning Directory ID. Closes #2187

Hey @SmitaNachan, it looks like we have tests failing. Would you mind having another look?

Merged manually. Thank you! 👏


[Feature][master-server] condition by param

Determine the nodes that need to be run based on the value of the parameter.

i will submit this pr in few days

done


[semver:minor] - limit ginkgo to 4 parallel builds

Prevent OOM issues and high CPU usage
Clean up ginkgo params to be consistent with official documentation

Some background on what and why
I got curious as to why ginkgo would use 100% CPU and 100% memory despite only having 4 parallel tests
Reading ginkgo documentation this stood out
https://onsi.github.io/ginkgo/#recommended-continuous-integration-configuration

--compilers=N will control how many cores to use to compile suites in parallel. You may need to set this explicitly to avoid accidentally trying to use all 32 cores on that CI machine!

Tested this in Builder backend repo
https://github.com/myhelix/partner-experience-backend/pull/443/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R20
After this change, we haven't had any "compilation failed" errors from ginkgo.
So introducing this change to our ginkgo v2 commands and jobs :)


intercept

Will this project support the intercept function similar to pyppeteer's intercept function? If I need it now, how can I do it myself?
intercept request or response

100% this is definitely needed


EventArray.iterMinMeanMax() + UnivariatePolynomial has problems

Somewhere in the process of iterating EventArray.iterMinMeanMax() with a PolyPoly transform containing a UnivariatePolynomal, the data is retrieved as the wrong shape.
Traceback (most recent call last):
  ... (irrelevant calls from code using idelib removed) ...
  File "<project venv>\lib\site-packages\idelib\dataset.py", line 2115, in iterMinMeanMax
    mx = xform(t, m, session, noBivariates=self.noBivariates)
  File "<project venv>\idelib\transforms.py", line 1347, in __call__
    return timestamp, self._function(*values)
TypeError: <lambda>() takes 2 positional arguments but 57 were given

The shape of values in the above case was (57,) .
EventArray._getBlockRollingMean() may be the source of the weird data. I'm attempting to pinpoint the problem more specifically.
The introduction of the 'in place' optimizations (3.2) seem to be where this came in. @theflanman, I know this is no longer your problem, but does this ring any bells?

It's definitely ringing a bell.  IIRC, there was a bug I couldn't track down and we decided to deprecate rolling mean removal in favor of an IIR or FIR filter.

@theflanman Rolling mean removal is deprecated; the method generates a warning and just does total mean.

#135 and #136 appear to test for these issues and fix this.


Aspira Health Onboarding – Go Live Coordination

Acceptance Criteria

[ ] Contacted sender to confirm when they want to start sending
[ ] Introduced sender to the Customer Support form and CC: the Ops team (at least Sharon Liu and Berni Xiong)
[ ] Adjusted final settings:

[ ] Modified organization.yml and created yamlitos

[ ] Customer status = active
[ ] For HL7 senders, schemaName: hl7/hl7-ingest-covid-19-prod

[ ] Modified prod settings table
[ ] Modified staging settings table

To Do

[ ] RS engineer: update this ticket with comments with every interaction with sender and ops team
[ ] RS team member who originates this ticket: add dependencies:

[ ] Aspira Health Onboarding – Create Org and Sender Settings
[ ] Aspira Health Onboarding - Validate Test Files
[ ] Aspira Health Onboarding – Testing in Staging and Prod
[ ] Aspira Health Onboarding – Validate Receiver

[ ] RS team member who originates this ticket: complete the following when creating this Issue.

[ ] Pipelines: Onboarding & Operations (New)
[ ] Labels: "Onboarding-ops" and "Sender"
[ ] Epics: #6972

Update on 1/4/23 as of 12:55pm: Followed up with William Albanese if still interested, sign TOS and send test file to validate.... awaiting response.
Email from Christopher Decker on 1/4/23 and 9:43am
Good Afternoon,
We have a lab, Atracare, who has reached out to us about reporting labs via HL7 messaging. We directed them to Prime. We have been in contact with their representative, William Albanese; however, we wanted to reach out to Prime/reportstream to see where they may be in the onboarding process. Because they perform a substantial amount of Covid testing, we would like to get this facility onboarded as soon as possible.
Mr. Albanese did mention that Prime gave them  syntax to plug into Athena (their EMR system), but have not received any other updates.
Please let me know if there is anything I can do to help assist this process so Atracare can begin reporting via HL7 as soon as possible .
Thank you so much and have a great day!
Christopher Decker
Management Analyst III
Delaware Department of Health and Social Services
Division of Public Health
Jesse S. Cooper Building
417 Federal Street, Dover, DE 19901
Phone:<PHONE_NUMBER>
<EMAIL_ADDRESS>


CLSAG audit report and post

Adds the CLSAG audit report and a corresponding blog post.

Can you also add the SVG version somehow? Just to have a record of it (and perhaps link to it with the last "CLSAG logo" part that credits the designer).

Can you also add the SVG version somehow? Just to have a record of it (and perhaps link to it with the last "CLSAG logo" part that credits the designer).

The SVG version has padding issues. We can add it to the assets folder if you really want.

Please make these changes:
--- a/_posts/2020-07-31-clsag-audit.md
+++ b/_posts/2020-07-31-clsag-audit.md
@@ -4,10 +4,11 @@ title: CLSAG audit results
 summary: Results of an external security audit of the CLSAG signature construction
 tags: [community]
 author: Sarang Noether, Ph.D.
+image: /blog/assets/clsag/clsag.png
 ---

-
+

That structure is needed to make the logo show up in the link preview (#1002).

Done.


qemu-virtiofs: Add one patch to fix libvhost-user

In order to get both QEMU and Cloud-Hypervisor working with virtio-fs, a
patch needs to be applied in order to fix a libvhost-user bug.
Fixes #810
Signed-off-by: Sebastien Boeuf<EMAIL_ADDRESS>

/test

/AzurePipelines run

lgtm (heh, classic error).
A permaref to upstream PR would (have been) nice.
Also, that is patch '2/2' - do we need to worry about '1/2'?
@jcvenegas @chavafg - I see obs packaging CI has failed (which is blocking an easy merge) - I've seen that a few times recently - known issue?

@grahamwhaley

Also, that is patch '2/2' - do we need to worry about '1/2'?

No there's no 1/2, it's just the way I ran git format patch.

/AzurePipelines run

/test


[OPENJDK-2881]Update versions of JDK for the April CPU.

Version update for the OpenJDK container release for the April CPU.

version numbers LGTM


Accessing app is not supported in Nuxt3

Getting the following error in the console when using this plugin with nuxt 3:
Accessing app is not supported in Nuxt3.
mock @ legacy-app.mjs:4
get @ legacy-app.mjs:88
default @ vitals.client.js:8
(anonymous) @ nuxt.mjs:69
callWithNuxt @ nuxt.mjs:91
applyPlugin @ nuxt.mjs:48
applyPlugins @ nuxt.mjs:57
await in applyPlugins (async)
initApp @ bootstrap.mjs:28
(anonymous) @ bootstrap.mjs:38

And the plugin itself does not work with both vercel and log providers (not tested with google)

I think that the problem is right here: https://github.com/nuxt-community/web-vitals-module/blob/e019d1e364df6ee2f8fbdb234054c485eda2fb0c/src/runtime/vitals.client.mjs#L6
In https://github.com/nuxt/framework/issues/968 , nuxt.app was renamed to nuxt.vueApp

Hey hey,
I am porting the module to nuxt 3 compatiblity -> https://github.com/nuxt-community/web-vitals-module/issues/43
After some testing I am hoping to see it released next week :)


Need to launch Fastlane with sudo when publish to PlayStore

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
Since several version of Fastlane, in need to execute fastlane with sudo when I want to publish to PlayStore, otherwise, I get an error when supply. Execute Fastlane with sudo works, but, I create many trouble on my project after, so, isn't a good solution.
Complete output when running fastlane, including the stack trace and command used
[16:14:43]: fastlane finished with errors
/usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:127:in require': cannot load such file -- googleauth (LoadError) 	from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:127:in rescue in require'
from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:40:in require' 	from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/supply/lib/supply/client.rb:1:in <top (required)>'
from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:68:in require' 	from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:68:in require'
from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/supply/lib/supply.rb:3:in <top (required)>' 	from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:68:in require'
from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:68:in require' 	from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/actions/upload_to_play_store.rb:37:in available_options'
from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/configuration_helper.rb:4:in parse' 	from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/runner.rb:237:in block (2 levels) in execute_action'
from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/actions/actions_helper.rb:50:in execute_action' 	from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/runner.rb:231:in block in execute_action'
from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/runner.rb:227:in chdir' 	from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/runner.rb:227:in execute_action'
from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/runner.rb:148:in trigger_action_by_name' 	from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/fast_file.rb:148:in method_missing'
from Fastfile:119:in block (2 levels) in parsing_binding' 	from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/lane.rb:33:in call'
from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/runner.rb:49:in block in execute' 	from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/runner.rb:45:in chdir'
from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/runner.rb:45:in execute' 	from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/lane_manager.rb:56:in cruise_lane'
from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/command_line_handler.rb:36:in handle' 	from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/commands_generator.rb:108:in block (2 levels) in run'
from /var/lib/gems/2.3.0/gems/commander-fastlane-4.4.5/lib/commander/command.rb:178:in call' 	from /var/lib/gems/2.3.0/gems/commander-fastlane-4.4.5/lib/commander/command.rb:153:in run'
from /var/lib/gems/2.3.0/gems/commander-fastlane-4.4.5/lib/commander/runner.rb:476:in run_active_command' 	from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:75:in run!'
from /var/lib/gems/2.3.0/gems/commander-fastlane-4.4.5/lib/commander/delegates.rb:15:in run!' 	from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/commands_generator.rb:337:in run'
from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/commands_generator.rb:42:in start' 	from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/cli_tools_distributor.rb:98:in take_off'
from /var/lib/gems/2.3.0/gems/fastlane-2.78.0/bin/fastlane:20:in <top (required)>' 	from /usr/local/bin/fastlane:22:in load'
from /usr/local/bin/fastlane:22:in `'
Environment
Stack

Key
Value

OS
debian_based stretch/sid

Ruby
2.3.3

Bundler?
false

Git
git version 2.14.1

Installation Source
/usr/local/bin/fastlane

Host
Ubuntu 17.10 debian_based stretch/sid (4.13.0-32-generic)

Ruby Lib Dir
/usr/lib

OpenSSL Version
OpenSSL 1.0.2g  1 Mar 2016

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

System Locale

Variable
Value

LANG
fr_FR.UTF-8
✅

LC_ALL

LANGUAGE

@aguillard This is definitely one of the drawbacks to using a system Ruby. Using rbenv like @taquitos mentioned is usually a good idea. I personally use chruby and ruby-install. Happy fastlaning 🚀


Merge ExecuteDsl and friends into a single trait.

This applies the same strategy as #1343 to ExecuteDsl, LoadDsl, and
FirstDsl. Ultimately I didn't think that LoadDsl and FirstDsl were
pulling their weight enough to continue to exist.
This will dramatically improve our error messages in some cases, since
we should never see no method named "first" for <INSERT PAGE LONG TYPE HERE OMG THIS IS PROOF DIESEL IS THE MOST COMPLEX THING EVER RUN FOR YOUR LIFE> again. Users should see the actual issue that caused
the query to be invalid. Many of those errors still need to be improved,
but it's a step in the right direction. This ends up killing the UFCS
trick.
There was one unfortunate side effect, which is that I had to convert an
impl which previously applied to all backends which support the
returning keyword to one that is PG specific. This will go away with
either specialization (maybe) or disjointness on associated types.
I've opted to change ExecuteDsl to not take a self parameter here,
as it seemed like most code using it with a where clause was also
imporitng RunQueryDsl.
This also forces an explicit impl of RunQueryDsl on types which we
want to be able to execute as a full query. Previously Query did this
for cases where we were using get_result, but it's actually possible
to do id.eq(1).execute(&conn) before this commit (which would of
course error).

imporitng


chore(yafti): Rename to 'Welcome to Bazzite'

Provides clearer naming for users

How about "Bazzite Configurator" or similar and I'll rename it in the GNOME extension as well


[DO-NOT-MERGE] Increase test timeout for macOS

Description
Testing a fix for PR 1057
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

This works, closing this PR.


Not closing completely after pairing stick

Hi, I have paired the USB stick with this HA component, tested it down and up, al good, but now the sun cover doesnt close completely. I dont know why but after pairing the stick as additional controller now it doesnt fully close, like 2 or 3cm, even with HA controls or with original remote, same result :(, any hint? Thanks!

I think there is no relationship to HA. If you press open or close, it just send this command to the cover. The same than the remote does.
Has the cover a programmed end position? Maybe the end position has changed for some reason and needs to be re-programmed. Maybe you changed it by mistake during pairing. You will find instructions how to change it in your manual.
Some cover detect their end position by their self. If this is the case, some blocking thing might be the reason.

Thanks for your reply Rainer. Yeah, I know is not related...I see that the crips from ole1986 just send UP DOWN, STOP and PAIR stuff... So maybe I changed something during the pairing, but not sure how, I followed instructions carefully. Anyway I raised an issue here to check if anyone knew any way to fix it. Installer just put the cover and gave me the remote... so I'm not really sure whats's inside and how to re-adjust it... I will call them if I dont find a way to readjust the limits by myself. Thanks anyway and congrats for the HA component, very good work :)

Most likely holding the programming button of your remote and the up/down button programs a new end position in up/down direction. This could be happend by mistake.
Holding the programming button and stop button clears both end position.
Usually newer products will detect end position automatically. Therefore this might be the right way to overcome you issue.
But as you seems to have a new product with quarantee, ask your installer first.

Thanks Rainer, very helpful! I did a reset with "STOP+Pair" for some seconds till the "2xClank", then it went to manual and I could roll the cover up to the limit, and then programmed the UP & DOWN positions with UP+Pair and DOWN+Pair till "Clank" :), all solved, and USB stick doing it's work as before through HA ;)


Design System > Compare all elements with design link

Design System > Compare all elements with design link

design system.xlsx

@trivenikulkarni @kaushikgokhale @Arbaaz-Sayyed @ShalviPalande1
I tested all the workflows, and the status is mentioned in the Excel sheet below
design system.xlsx


docker-putty crashing on launch (?)

Trying to run putty in docker on Synology DSM 6.
I cannot load the application and in the logs i see the following error:
(putty:889): Gtk-CRITICAL **: 11:19:47.309: gtk_box_gadget_distribute: assertion 'size >= 0' failed in GtkScrollbar

This message is "normal".  Do you see that the container is stopping itself ?
What do you see when you try to load the app ?  Please share your container configuration (i.e. how you create it) and how you access it.

Closing this issue.  Please re-open if needed.


Voting v2 tranfer assets

Merging changes from voting-v2-transer-assets into voting-v2
CONJOINED TRIANGLES OF SUCCESS

Looks good! Lets die now.


Open app Notification app crash

Hi,
I have integrated push notification for our chat system separately and its works fine. But when i open notification when the phone is locked with the app is  in foreground,  App get crash. Other than this scenario it works fine. Please refer the below demo video. Can you please give any solution for this ?
Screen Recording 2020-10-23 at 4.41.57 PM.zip

Hi, @ciamalaeaskan
Try to use real device.

Yes real device also having this same poblem. On real device the get stopped on both android and ios.

Please show logs from Metro server or from AndroidStudio


Fix loopy version in requirements & travis (retry)

All passed except for flake -- should add test for issue that @kahilah brought up via email

All pass but flake, merging in


multilabel classification ?

excuse me，the original is a multi-label classification problem, I did not get to know how your label is processed, after study your code I think your label is a single multi-label classification problem, am i wrong?
would you help me to explain the label question? very very thank you!!

Don't understand what do you mean by multi-label classification problem and single multi-label classification problem. For labels and dataset preparation see  https://github.com/YerevaNN/mimic3-benchmarks.

oh....I'm so sorry.I mean a sample has multiple labels, how to deal with the labels?

Check this:  https://github.com/YerevaNN/mimic3-benchmarks.


Querying message delivery information via API

I need to fetch the list of email submitted for delivery over SMTP and then their corresponding status so that a report can be generated. Is there a way to run queries via the API so that I can use filters similar to the web interface and get these details programmatically? I would be glad to write this utility (in Ruby) and release it so that it might be useful to others as well.

It doesn't look like there is any method for this currently, you could have a look at the existing API controllers and make a new one if you wanted.
https://github.com/postalhq/postal/blob/a735219783127cd0495246ccee89422069da1a1c/api/controllers/messages_api_controller.rb


nixos/nixos-install: build system using local nix store first

Motivation for this change
Essentially apply current work-around described in #126141
closes: #126141
Commit message:

We build the flake twice to populate the local nix store with
all of the paths needed to do installation.
This is to avoid situations where nix-build --store <path> --extra-substitutres auto?trusted=1
errors on paths not being found in the local nix store.
See https://github.com/NixOS/nixpkgs/issues/126141 for more details.

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg test installer.simple

@ofborg test installer.simple

hmm, wanted to make a nixos test, but it looks like creating new paths within the sandbox is very tricky. Even instantiatiation fails.

I'm not sure it's a good idea to use the local store: when I tried it it filled up the disk pretty much immediately and nearly OOMed.

I'm not sure it's a good idea to use the local store: when I tried it it filled up the disk pretty much immediately and nearly OOMed.

I agree with you, but for most this is just "I tried to install NixOS, and it failed. It's terrible".
The correct solution is a lot more involved, this is a "should work for most people" solution. Where as the current situation is, "any new path which needs to be created will fail your install"

cc @edolstra if he has a better solution

Well, this solution seems strictly speaking worse, because it turns a potential failure due to a bug (not sure what's going on in #126141) into a guaranteed OOM if the configuration doesn't fit into RAM. Seems better to fix the bug than work around it.
It also makes the installation slower, because it builds the configuration in one store and then needs to copy it over.

I think a better workaround is to do some overlayfs trickery to overlay /mnt/nix over /nix. Something like this: https://github.com/balsoft/nixos-config/blob/ea72d681ef5f8fe40f97ee8e8e1714bae34ed46d/bootstrap (it's quite terrible but I think the idea is valid)

(Oh, no, my thing doesn't use overlayfs; I don't remember where I saw the overlayfs then.)

The installation images will use overlayfs for the local /nix/store. I mentioned it https://github.com/NixOS/nixpkgs/issues/126141#issuecomment-870985176

Well, this solution seems strictly speaking worse, because it turns a potential failure due to a bug (not sure what's going on in #126141) into a guaranteed OOM if the configuration doesn't fit into RAM. Seems better to fix the bug than work around it.
It also makes the installation slower, because it builds the configuration in one store and then needs to copy it over.

Agreed, I mentioned that (in other words) https://github.com/NixOS/nixpkgs/issues/126141#issuecomment-870985176

Result of nixpkgs-review pr 128698 at ac6b3596 run on x86_64-linux 1

2 packages built successfully:

nixos-install-tools
tests.trivial

The installation images will use overlayfs for the local /nix/store. I mentioned it #126141 (comment)

Ok, my train of thought was completely incorrect. I guess what I'm proposing is to copy all of /nix/store to /mnt/nix/store and then bindmount /mnt/nix to /nix. This would remove any need for a tmpfs nix store.

converting to draft, as the --store options in nix should be fixed

this is has been properly fixed


Create Script to Provision Azure VM for Demo Use

Provision an Ubuntu Azure VM with a static ip address for demo use.

A script was not required as we provisioned an IP and VM manually on Azure.


feat: add gitpod help doc link

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #57296

Per https://github.com/freeCodeCamp/freeCodeCamp/issues/57296#issuecomment-2501511754, the following pages from these topics also include a link to the documentation:

Information Security with HelmetJS
Information Security Projects
Quality Assurance
Quality Assurance Projects

Hi @cplan85 . Congrats on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 📝


My bot starts but after login, it tell me that and restart.

My bot starts but after login, it tell me that and restart.
Traceback (most recent call last):
File "pokecli.py", line 795, in
main()
File "pokecli.py", line 142, in main
bot = start_bot(bot, config)
File "pokecli.py", line 102, in start_bot
initialize_task(bot, config)
File "pokecli.py", line 93, in initialize_task
tree = TreeConfigBuilder(bot, config.raw_tasks).build()
File "/home/cephis/PokemonGo-Bot/pokemongo_bot/tree_config_builder.py", line 79, in build
instance = worker(self.bot, task_config)
File "/home/cephis/PokemonGo-Bot/pokemongo_bot/base_task.py", line 23, in init
self.initialize()
File "/home/cephis/PokemonGo-Bot/pokemongo_bot/cell_workers/follow_spiral.py", line 23, in initialize
self.points = cycle(self.spiral+list(reversed(self.spiral)[1:-1]))
TypeError: 'listreverseiterator' object has no attribute 'getitem'
[2016-09-02 23:37:21] [sentry.errors] [ERROR] Sentry responded with an error: 'module' object has no attribute 'HTTPSHandler' (url: https://app.getsentry.com/api/90254/store/)
Traceback (most recent call last):
File "/home/cephis/PokemonGo-Bot/local/lib/python2.7/site-packages/raven/transport/threaded.py", line 174, in send_sync
super(ThreadedHTTPTransport, self).send(data, headers)
File "/home/cephis/PokemonGo-Bot/local/lib/python2.7/site-packages/raven/transport/http.py", line 47, in send
ca_certs=self.ca_certs,
File "/home/cephis/PokemonGo-Bot/local/lib/python2.7/site-packages/raven/utils/http.py", line 44, in urlopen
class ValidHTTPSHandler(urllib2.HTTPSHandler):
AttributeError: 'module' object has no attribute 'HTTPSHandler'
[2016-09-02 23:37:21] [sentry.errors.uncaught] [ERROR] [u"TypeError: 'listreverseiterator' object has no attribute 'getitem'", u'  File "pokecli.py", line 795, in ', u'  File "pokecli.py", line 142, in main', u'  File "pokecli.py", line 102, in start_bot', u'  File "pokecli.py", line 93, in initialize_task', u'  File "pokemongo_bot/tree_config_builder.py", line 79, in build', u'  File "pokemongo_bot/base_task.py", line 23, in init', u'  File "pokemongo_bot/cell_workers/follow_spiral.py", line 23, in initialize']
vendredi 2 septembre 2016, 23:37:21 (UTC+0200) Pokebot  Stopped.
Press any button or wait 20 seconds to continue.
Other Information
OS: xubuntu
Branch:
dev
Python 2.7.6

Checkout previous commits


[DO NOT MERGE] Experiment with perf tests

Do not merge - just an experiment with perf tests

/ok-to-perf

/ok-to-perf


High CPU usage and timeout while repository listing

Gogs version (or commit ref): 0.9.0 (also with previous versions: 0.8.43, 0.8.25, 0.8.10, 0.7.33). Both binary and built from source code versions
Git version: <IP_ADDRESS> (also with 1.7.1)
Operating system: CentOS 5.4 2.6.18-238.19.1.el5
Database:

[ ] PostgreSQL
[x] MySQL
[ ] SQLite

Can you reproduce the bug at http://try.gogs.io:

[ ] Yes
[ ] No
[x] Not relevant

Description
I would like to install Gogs in my linux cluster but I have two major issues. Every time I start Gogs in my 8-core cluster node, Gogs is running at 300-400% CPU for several minutes. Also, this behavior happens every now and then while using Gogs. The other issue is with an empty repository, most of the times I can't browse it because a timeout error happens. Nevertheless, I can browse most of the other options without problem (issues, commits, releases...) and immediately.
I don't if both issues are related. I've tried all the latest versions, and also with both the binary and source versions. Also, I've tried with Git 1.7.1 and <IP_ADDRESS> versions. I don't know what more can I do in order to find out what is happening. I've searched but I can't found any issue related or other people with the same problems. I've found that CentOS 5 is not officially supported by Go, but I've heard that most of applications are running without issues.
If you could help me to know what is happening, I would be very grateful. I would like a lot to offer Gogs to my cluster users!

Hi, please check gogs server log for "timeout" operations.

Thanks for your prompt reply! Which log file? I have only two log files: http.log is empty, and xorm.log seems to have only sql queries.

path/to/gogs/log/gogs.log

I don't have that file. I launch gogs vía a init.d script, and this file is deleted once Gogs is totally launched. Do I launch gogs Cía ./gogs web?

Do I launch gogs Cía ./gogs web?

Yes, please do that.

I've doing some research, and I forgot to mention that I'm using gogs via apache. If I use gogs server directly, there aren't timeouts, but loading a repository is very slow. I think that this make apache returns a timout. For example:
Completed /python/issues 200 OK in 34m38.978975763s (issues webpage)
Completed /python 200 OK in 74h0m38.131986309s (repository index)
I have just one repository (called python), with 3 files: .gitignore, LICENSE and README.md
Also, I've found that when CPU is high, some entries appear:
[T] Doing: MirrorUpdate
[T] Doing: MirrorUpdate
[T] Doing: MirrorUpdate
[T] Doing: MirrorUpdate
[T] Doing: MirrorUpdate
[T] Doing: MirrorUpdate
[T] Doing: MirrorUpdate
[T] Doing: MirrorUpdate
[T] Doing: MirrorUpdate
[T] Doing: MirrorUpdate
[T] Doing: MirrorUpdate
[T] Doing: CheckRepoStats
[T] Doing: GitFsck
Is that normal? I have just one user with an almost empty repository, and I'm just browsing for now.

Please do not truncated the log in the way you think it would be nice, I need complete, full dump of log, thanks!

Ok, here they are (I've just removed ips and emails from logs).
One user (called pythonuser) with one repository (called python). I've started gogs from scratch (removing previous logs):

user logs in
user browse to the repository (fast)
user browse to issues (very fast)
user browse back to the repository (very very slow)

Please, tell me if you need more files or tests.
Thanks!
logs.zip

The log you packaged does not look like the one you posted on your previous comments.

Yes, because I delete previous logs. These ones are generated from scratch just a moment ago.

OK, the log looks right to me.

Check your anti-virus?

It don't have any anti-virus. Is that normal that an empty repository lasts so much?

Consider upgrade your system.... :sweat:

Do you think it's a matter of CentOS 5?

Or do you think it's a power issue?
Because the first time is loaded well:
[Macaron] Completed /pythonuser/python/issues 200 OK in 1h58m35.815553505s
The second one is:
[Macaron] Completed /pythonuser/python 200 OK in 162h41m30.093555215s

1h58m35.815553505s does not look well to me...

How long it takes to run git version command?

I can save a screencast for you. I think units are not well. The first webpage is loaded in a couple the seconds. The second time takes more than a minute.

Now I'm running latest binary version (Gogs 1.9), so Go is 1.6. Previous binary versions were compiled in previous Go compiler version. I've also compiled from sources with Go 1.4 with the same result.

I'm out of ideas. Is it possible to remote login a user of your node so I can do some tests?

Sorry, but that is not possible because of security policy. But I could run logs more verbose if you want.
I'm also out of ideas, and that is why I write this issue. I think that is maybe related that Go is not supported in CentOS 5, because no more people seems to have this issue. But upgrading the cluster is not possible right now.

OK, dump log again after some repository view opeations.

Remote login is not possible but you can browse the repository if you want, and I can dump log file for you. How can I give you the details privately?

@juanfcocontreras Let's start with dump log again after some repository view operations first...

Ok. More logs here:
logs2.zip

Looks like your system time is messed up, I see 2016-5-1 at the beginning, and 2016-3-xx at the end.

I think that is the reason because time units were wrong. But I don't have any related issue in other software, and I have many installed.
The only thing I think could be is CentOS 5 and Go:
http://dave.cheney.net/2013/06/18/how-to-install-go-1-1-on-centos-5
Does it make sense to you? It's too low-level language for me...

 In fact, I don’t think Go will even compile on RHEL5/CentOS5 after version 1.3.

I see this in the article...

Yes, but I'm not sure if this is related or not with this issue. I'm very new to Go. I've also read this:
https://www.reddit.com/r/golang/comments/2u3bb7/running_go_on_centos5/
"We use nothing but CentOS 5 for our servers (overdue for an upgrade). We've been doing all sorts of go development with no problems whatsoever."
"We've also used Go 1.2/1.3 in production with RHEL 5.3 and 5.11 for a year, without any problems."
"I've had this website running on a Webfaction CentOS 5.11 shared server for a month or so. I have Go 1.3 installed and have not had any problems."

BTW, I compile Go 1.3 without any issue.

The problematic thing about slow when view repository files is Gogs calling git xxx commands through shell. You might have some ideas?

How do you call shell commands? I can make a very simple Go app calling git command within Go and directly in the prompt shell to compare.

 Problem seems to be related to:
2016/04/16 15:06:09 [T] Doing: MirrorUpdate
The rest of the code is executed immediately. What does it do?

It is very obvious it updates your mirror repositories, but since you have none, it should do nothing.
Again, your system time is very wrong, there is no guarantee everything works as expected.

Any idea of debugging about debugging system time? I don't have any issue in bash scripts, python or php.

I don't think wrong system time is a right environment setup, and the statement  I don't have any issue in bash scripts, Python or PHP. is invalid because Gogs is not written in bash scripts, Python or PHP, and even you don't have problem with other Go apps, there is no guarantee Gogs should function the same.
I don't think it is worth investigating until the system time problem is solved.

Yes, I totally agree with you. I think everything could be related to system time, because is something very sensible.
What I meant is that when you say "system time" as something affecting the whole system,  it's something I found very weird because I have a lot of things running in the system without any similar time issue.
So I think is something related to both Gogs and my system. In one hand, because Gogs is the only app with the issue. On the other hand,,if there aren't any other Gogs users with the same problem, is obviously something related also to my system.
Do you think I can do anything to debug it? Do you think it's time to give up?

It's not a good practice to skip my comments...

Where can I get a copy of the distribution that is same as yours? So I could setup a VM and test.

Sorry, with so many comments, I missed that one.
My exact system is this one "Rocks Cluster Distribution 5.4.3":
ftp://ftp.rocksclusters.org/pub/rocks/rocks-5.4.3/linux/area51+base+bio+condor+ganglia+hpc+java+kernel+os+perl+python+sge+web-server+xen-5.4.3.x86_64.disk1.iso
It's a customized version of CentOS 5.6 for cluster systems. So I think you could use CentOS 5.6:
http://archive.kernel.org/centos-vault/5.6/isos/x86_64/CentOS-5.6-x86_64-LiveCD.iso
Thank you very much.

I downloaded the FTP one but can't seem to start installing with VirtualBox:

Is that Rocks? I think CentOS should work out of the box.

I think CentOS should work out of the box.

It does but too minimal, looks too different than I would expect, VB plugins are not able to install either so I can't share clipboard which is a huge pain.
I'm closing this since it's more like deployment environment specific issue. Please post future updates on https://discuss.gogs.io/.

Do you mind if I try to set up a VM for you?

It might be easier for you just find one with correct system time and test again.

Ok, then I'll try another Git system.
If changing a cluster system with several dozens of nodes and users was an option, be sure I didn't waste your time in this thread.
Thanks anyway.

Ok, then I'll try another Git system.
If changing a cluster system with several dozens of nodes and users was an option, be sure I didn't waste your time in this thread.
Thanks anyway.


After start connect-to-mainnet, sync error

Failed to add headers from "<IP_ADDRESS>:3000:0" to block retrieval queue: queue is full
How to solve it?

version: 1.3.1

i have same issue

Version 1.3.1 has not been released yet. Are you compiling from git?

https://github.com/input-output-hk/cardano-sl/issues/3647#issuecomment-424572542


Fix DALL-E Mini Colab Link

Didn't change the update key for DALL-E Mini, not sure where to get that data.

Thanks for fixing the link!


Add endpoint for pipeline run stage results

Add endpoint for pipeline run stage results
For the Pipeline Monitoring feature

Add stage_results route to samples_controller, which takes the most recent pipeline run for the sample and returns a JSON combining the dag_json field of each pipeline run stage. Should include all four stages for admin users and only three stages for non-admin users (no experimental stage)

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix a feature that knowingly causes existing functionality to not work as expected)

Test and Reproduce
Visit samples/[sample_id]/stage_results to fetch json

When I go to the endpoint it looks like it's returning the dag JSON all as a string, but you want to return the parsed JSON, right?

@emilyzhong @cdebourcy points out that you should add a test that users can't access the endpoint if they don't have access to the sample

Working on changes in https://github.com/chanzuckerberg/idseq-web/pull/2287


Crash when key set to ""

Version of Advanced Rocketry
1.5.0.-134
Have you verified this is an issue in the latest unstable build
Have not verified
Version of LibVulpes
0.4.0.-52
Version of Minecraft
1.12.2
Crash report or log (if applicable)
http://pastebin.com is a good place to put them
crash reports that are put in the issue itself are
hard to read
https://pastebin.com/UiFLjHgv
Description of the problem
While cleaning up my keybindings, I set the Toggle RCS key to \. However, upon loading a world and pressing a key, I get the above crash. It appears that \ is not one of the keys that Advanced Rocketry checks for properly.

I cannot reproduce this, can you give more specific conditions?

I'm running Minecraft 1.12 with Forge <IP_ADDRESS>15, on OpenSuse Tumbleweed
Linux.
On Sat, Apr 20, 2019 at 8:00 PM Silfryi<EMAIL_ADDRESS>wrote:

I cannot reproduce this, can you give more specific conditions?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zmaster587/AdvancedRocketry/issues/1563#issuecomment-485209092,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACNXHR7EAFSJBT7Z3SMWXUTPRO4EPANCNFSM4HFC6OMQ
.

One of my modpack's players have also experienced this crash, when setting Open Rocket GUI to mouse 5, or other mouse buttons. Crashes the singleplayer world after exiting the menu, and crashes on world load as long as it is set.
Forge <IP_ADDRESS>36, Advanced Rocketry 1.5.0.-139
https://paste.dimdev.org/gonunexako.mccrash
modpack: https://minecraft.curseforge.com/projects/dragonbox/files/2718492

can you replicate the issue with just AR, if not, what's the smallest set of mods you can replicate it with.
As far as I can tell from the crash report, it looks like an issue from the underlying engine.  LWJGL should not be throwing errors when checking to see if a key is pressed.

Yes, here's the crashlog with only AR LibVulpes and Forge:
https://paste.dimdev.org/agilakezal.cs

I had a similar problem in mod version 1.5.0.-138, but it occured when I tried to leave a rocket by using the shift key and one time after closing my inventory.
This could be solved by setting every key binding of Advanced Rocketry to an unused key (I used the numpad keys).
For completeness sake here is my crashlog: https://pastebin.com/yD7zjfbK (This is a modpack based on the All The Mods 3 pack but since this similar issue exists I think it is unrelated to the other mods)

I can replicate @CvoidWyvern's issue.  Though that makes sense since it's only meant to look for key presses.

31d2058 should fix the issue


fix: use tutor variables to expose clickhouse container ports in k8s

Description
Updates the k8s configuration to use Tutor variables when exposing the Clickhouse container ports.
Related information
Closes https://github.com/openedx/tutor-contrib-aspects/issues/387

Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@pomegranited 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.


Add abstractcontroller on rules and tests

Closes: #34

@Hakihiro separate PR for service to detect controller seems ok 👍

I am merging it ;) @Hakihiro thank you


Fix @dynamicMemberLookup for protocol/archetype types.

Enable subscript(dynamicMember:) as a requirement for @dynamicMemberLookup protocols.
Previously, @dynamicMemberLookup protocols could only define subscript(dynamicMember:) in an extension. This patch fixes that.
@dynamicMemberLookup
protocol DynamicProtocol {
  // This works now.
  subscript(dynamicMember name: String) -> Self { get }
}
// Previously, only this worked (method in protocol extension).
extension DynamicProtocol {
  subscript(dynamicMember name: String) -> Self { return self }
}

Resolves SR-8077.
There's also some @dynamicCallable-related gardening.

@swift-ci Please smoke test

@dan-zheng Take a look at extractDirectlyReferencedNominalTypes() in lib/AST/NameLookup.cpp. Do you think this can be useful for @dynamicCallable and @dynamicMemberLookup?
More generally it would be nice to factor out a common superclass/conforming protocol walk for use by name lookup and these attributes. If you think about it what they're doing is very similar to name lookup except they're searching for an attribute and not a member.

@slavapestov Thanks for the suggestion!
extractDirectlyReferencedNominalTypes does seem useful. It populates a SmallVectorImpl with decls, but the order of the decls might not be ideal here - need to investigate.
A common superclass/protocol type walk function definitely makes sense. I'm happy to look into it, perhaps we can merge this PR to unblock progress in the meantime.

I got some weird test failures regarding pch. Retriggering tests in hopes things pass.
@swift-ci Please smoke test

@shahmishal: you're probably aware of this already, but do you know why CI is failing with error: compilation involves pch was enabled in PCH file but is currently disabled?
Example build job.
CI for other PRs seems to fail with the same error currently.

@milseman Is this related to cherry-pick on clang/llvm branch?

@dan-zheng @shahmishal Jordan pushed a fix for the PCH issue, tests should pass now.

@dan-zheng Why would the order matter?

@swift-ci Please smoke test

@dan-zheng Yeah, I would first make the function public and use it in the implementation of those attributes, and make sure there are no regressions, etc. Then I would think about extracting the nominal type visitation logic as a separate task.

I'm +1 on this patch (including the testcase), but am sufficiently far enough away from the code to not be the best reviewer.  Is anyone else able to give this a sniff test?

cc @slavapestov @rudkx: could you please review?
As suggested by Slava, in a follow-up PR, I plan to make extractDirectlyReferencedNominalTypes public and use it to dedupe type walking code in hasDynamicMemberLookupAttribute and getDynamicCallableMethods.

Added a // SR-8077 test case comment in the test file.
@swift-ci Please smoke test


Load baseline with Famix  only if the image do not contain moose

It should load famix only if not exist in the image. For example, if Famix is already loaded, the baseline load famix anyway.  In my case, it loads famix twice. Which slowdown my builds

There is a baseline of replication without famix.
Since replication depends on famix but is also a dependency of Moose (which contains famix), I cannot do the usual famix loading trick explained in the wiki.


Clone Functions do not Work

Implement clone functions for Collection, Ellipse, Path, and Rectangle classes.

Clone function should use the copy function that is part of the data class type.

The copy function provided by the data class type is not a deep copy and as such should be used with caution.


Fix link to Gaug.es in README

Gauges homepage requires the get. subdomain.

Thanks for the fix, James!


Improve chocolatey package

ffmpeg and gifski could be added as choco dependencies. Gifski doesn't exist as choco package yet but I am willing to make it.
That way

doing cinst screentogif would install all of them and configure correctly.
doing choco update ... would update only dependencies that actually have a new version
it is also possible to install only main package without dependencies using  --ignore-dependencies cmd line argument.

What do you think ?
If you accept, I can do relevant work. I also think package should be embedded (i.e. contain binary inside, not just link)

@majkinetor Hi, sorry for taking so long.
I would like to push this forward, at least with FFmpeg.
With Gifski and SharpDX, it's a little bit different. I think that it's best to bundle together.

Sure, just add 1 line to nuspec file, that it depends on ffmpeg. I am personally involved in keeping this package up to date all the time as you can see in the version history.
If you need any help let me know.

Strange, it's not working on my tests in here:
I added these lines to the nuspec:
<metadata>
  <package>
    [...]
    <dependencies>
      <dependency id="ffmpeg" version="4.2.2"/>
    </dependencies>
  </metadata>
</package>

And I'm trying to test with this command:
choco install -fdv .\screentogif.nuspec
I end up with this error:
screentogif not installed. An error occurred during installation:
 Unable to resolve dependency 'ffmpeg (≥ 4.2.2)'.

Forget it, it's working now with this command, running the same folder as the package:
choco install -s "'.;https://chocolatey.org/api/v2/'" -fdv screentogif

Now for the Gifski and SharpDX, I think that I could simply ship my own MSI file.
But I'm not sure how existent "choco" installations of ScreenToGif would work.
Because the current package is installed via the portable version.

Now for the Gifski and SharpDX, I think that I could simply ship my own MSI file.

Why not just add them to portable installation directly. Why MSI for 1 simple exe and a library ?

I'll try to embedd both Gifski.dll and SharpDX.dll.

I just got a message saying Netframework 4.8 is required as well... Could be added as another dep: https://chocolatey.org/packages/netfx-4.8

@lucastheisen Yes, it can be. Thanks.

Is it possible to get an installer in addition to the current portable version, or at least an install argument? Cause the current package is potable only


removed musixmatch.com

Isn't a spam site - I've used it myself. It was watched for being used as an example of a site that had a lot of lyrics, so https://metasmoke.erwaysoftware.com/post/72014 probably shouldn't have been deleted as spam.

!/approve

!!/approve


Appears to be broken in Flutter 3.22.0

I've created a bug over on the Flutter board related to this: https://github.com/flutter/flutter/issues/148653
The TL;DR is that it appears that something in commit 8e418d18185697e56024ef3d5784afba4ac96370 seems to have broken something that is being done with rendering the popup on Linux. I haven't had luck figuring out what exactly yet though. I'm going to keep dabbling with it to see if there is a work around. For now, using the standard example, in previous releases one would get:

...but now one gets:

The case degenerates in a different way in my own app though.

This change probably fixes it, since this was the test case I reported as being broken. https://github.com/flutter/flutter/issues/148653


Tensor Parallelism on TGI

System Info
Hi all, I have been running benchmark and testing myself to get a sense how an ideal setup for deploying some models is, and in the past a few months I've noticed an issue with Tensor Parallelism on TGI on A100-80G. With the v1.2 image I was able to run some benchmark on H100 observed this issue again, so I decided to raise this concern. (Some discussion & results I had previously can be found here https://github.com/huggingface/text-generation-inference/issues/1129)
I'm running the benchmarks on K8s with the v1.2 image on codellama/CodeLlama-34b-Instruct-hf. Each deployment shares the same spec except for the number of GPUs and thus the value for --num-shard. All of the requests are sent non-concurrently to eliminate any client-server factor, and the metric of interest here is simply latency per token (in ms) for each request (Each request generates ~100 tokens).

GPU
#GPU
Average
P50
P99

A100-80G
1
46.79
46.07
55.25

A100-80G
2
29.39
28.71
34.95

A100-80G
4
32.06
30.83
50.18

H100
1
27.98
27.56
30.68

H100
2
28.02
27.82
30.81

H100
4
31.77
30.50
47.52

I do notice there is an warning when deploying the model with v1.2 image on multiple GPUs
WARN text_generation_launcher: Disabling exllama v2 and using v1 instead because there are issues when sharding
Theoretically speaking, inference over more GPUs should be faster because of TP. I assume this performance degradation is in fact coming from exllama since that's the actual kernel used, but I am wondering if the HF/TGI team is aware of this.
My guess is there could be probably something wrong with the TP implementation in exllama. I haven't tested with just exllama itself but will do in the near term, and will probably raise an issue there if I observe the same behaviour.
Information

[X] Docker
[ ] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction
Deploy codellama/CodeLlama-34b-Instruct-hf with TGI v1.2.0 over multiple GPUs with default settings, send non-concurrent requests and measure the latency per token
Expected behavior
I expect a deployment over 4 GPUs to have a lower latency per token than over 2 GPUs because of TP.

Theoretically speaking, inference over more GPUs should be faster because of TP.

It's complicated.
If you are compute bound, TP generally helps. However that is very rare for the decode steps which dominate your benchmark here. For prefill its more frequent. If you force the model to only generate one token in your tests, you sill see a very different behaviour. We recommend using the benchmarking tool to better investigate the thow phases (prefill and decode).
If you are not compute bound, it only adds a communication overhead.
We cannot really make recommendations here as the optimal number of shards for the best latency is entirely dependant on the hardware and the model size + type.

@OlivierDehaene Thank you for the response and the explanation! I went ahead and reran some tests to including time-to-first token as you suggest and below are the results:

GPU
#GPU
Average
P50
P99

A100-80G
1
136.2
125.0
387.4

A100-80G
2
94.91
65.21
267.4

A100-80G
4
336.6
338
494.9

A100-80G
8
530.7
525.4
674.7

H100
1
67.06
54.89
162.3

H100
2
58.11
53.68
100.2

H100
4
89.09
83.34
162.6

H100
8
55.2
54.04
67.33

It just seems to me that beyond 2 GPUs, communication overhead overshadows the benefit from TP. I haven't got into the GPU profiling but the utilization rate when over 2 GPUs also show that some GPUs have low util rate due to having to waiting for others. This was mentioned in https://github.com/huggingface/text-generation-inference/issues/863 by @jameswu2014, and @Narsil has kindly responded there as well.
Not asking for a fix/recommendation but I was just trying to confirm if this issue only happens to me (bad gpus, bad node, who knows), but the development of Candle is surely exciting to hopefully solve this issue fundamentally!

Thought to share another set of results of the same benchmark on TGI versus vllm v0.2.6 docker - it's pretty clear to me that there's something wrong with TP when going above 4 GPU.

Could you share your benchmarking code ? Doesn't look like anything it should...
I managed to reproduce on A100-80 something like your numbers (not quite tho, I get 45-30-40-35 using text-generation-benchmark).
I'm digging a bit more into it, since I was able to reproduce somehow. Definitely doesn't feel right if it holds. (We do use nccl for communication, which is not necessarily the best communicator across GPU, that's a potential target, but again).
I couldn't reproduce on lower models, or lower machines though

I think we found the reason. 3 weeks ago vllm added cuda graphs to their execution engine.
Having a cuda graph makes CPU usage much smaller, leading to better consistency of timings across GPUs, which leads to speedups because NCCL syncs don't have to wait so long for each other.
We'll add cuda graphs here too @OlivierDehaene is on it. Also, using a compiled language would most likely have prevented the need for that (should cuda graphs be unusable for whatever reason)

Hi @Narsil @OlivierDehaene , any updates on this? I also had a problem that the deployment with 8 GPUs is not faster than with that with 4 GPUs. I'm using V100.


Use RNGCryptoServiceProvider for crypto headers

Use a proper RNG for cryptographically important randomness.
Fixes #536
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

Is it intentional that the RNGCryptoServiceProvider is disposed in two of those change, but not the third?

Is it intentional that the RNGCryptoServiceProvider is disposed in two of those changes, but not the third?

Noope.


feat(lit-frontend): (Story) Campaign History Card

Goal: https://www.figma.com/file/2qnS79SjZJeyTKC3YLVYwA/Project-Emblem?node-id=111%3A445
Legend:
Campaign card: Parent/Face card.
Campaign history card: For every time a campaign has been run, a campaign history card will be created.  (1 to many)
Child tasks:

[ ] Goal circle graph component (gradient). Should list goal / raised amount.

[ ] Display given campaign image, status, created date, closed data, owner list. Style to match design. Not clickable.

Currently outdated, closing in favor of refreshed issues.


[Question] Is a web-server needed to run the production (dist) project?

I'm trying to run the production project directly from the browser (Opening up the generated index.html), but it gets stuck in the "Loading..." page from the root component. The console doesn't output anything, either.
If I launch a web server, let's say Python's SimpleHTTPServer, and access it from the browser (IP:Port), the page loads up normally. I was wondering, is this behaviour by design? Or is it related to Angular/SPAs/this project only?
All I did was clone the repo, install deps and build the distribution version by using npm run build.
Am I missing something? Thanks.

Hi Arthrmlo, yes a web server of your own choosing is needed to run this in production. Your dist folder has all the html, css, js and asset files necessary for you to use any server of your choosing. Even a simple node server which serves and index file for all (*) requests will work.

Hi @dannypule, thanks for answering. I've looked up a bit more on why a web server is it needed and found a more in-depth answer on stack overflow. Here is the link for anyone who might have the same question: http://stackoverflow.com/a/34587117.
I'm closing this issue.


Rewrite sysex sending with block size parameter

Certain broken MIDI interfaces like the Alesis USB-MIDI cannot send more than 128 bytes of sysex at a time. Instead of using the built-in MIDISendSysex() function, write my own that has a user-selectable block size.  (Need to find one of these interfaces to test with, too.)

Released (finally) in versions 1.4 of both apps.


[Feature][CI] Automatically generate LICENSE

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
We should support automatic generation of LICENSE file to improve efficiency and accuracy.
Background
As we all know, the SeaTunnel is a high-performance Data Integration Platform that supports efficient data transformation and transfer between heterogeneous data sources. Therefore, it is inevitable to introduce many third-party dependencies. Therefore, there is also a problem, which is, with more and more third-party components, it will be a very labor-intensive process to manually maintain LICENSE. At the same time, newbies need to learn this LICENSE mechanism, which also increases the entry threshold for newbies. Therefore, this document will introduce a way to automatically generate the LICENSE file.
Requirement
After preliminary research, some basic requirements have been sorted out:

It needs to be implemented in a scripting language to facilitate understanding and maintenance;
It can be integrated with the existing Maven build process;
It should support Github Action to trigger automatically.

Plan
Version v1.0
The easiest way is to generate a temporary THIRD-PARTY.txt through Maven's license-maven-plugin plugin. Then through the Python script, the LICENSE file is automatically parsed and created.

Version v2.0
Further through Maven's exec-maven-plugin plug-in, it supports one-click triggering by using Maven.

Version v3.0
Going a step further, we can integrate with Github Action. When a new PR is created, if the dependency changes, Github Action automatically modifies the LICENSE, and creates a commit to submit it to the new PR. In this way, when contributing new plug-ins, users do not need to understand the LICENSE mechanism, all of which are automatically modified, which greatly reduces the threshold for newbies.

Conclusion
Currently I have created the #1210 PR, which has completed versions v1.0 and v2.0, we need to discuss whether v3.0 needs to be implemented at this stage. And then we can implement v3.0 in a follow-up PR if necessary. Any comments are welcome, thank you very much.
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Good job flow and describe 👍


Markup issues on "Collect and Publish Images to your Private Registry" page

https://rancher.com/docs/rancher/v2.x/en/installation/other-installation-methods/air-gap/populate-private-registry/
Table under A. Find the required assets for your Rancher version is broken.
Step 3 of D. Populate the private registry shows ```plain in code block
Directly under there is <div class="tab-pane" title="Linux and Windows Clusters"> shown in a code block.

Closing this issue because it is addressed by https://github.com/rancher/docs/pull/2131 and https://github.com/rancher/docs/pull/2132


Refactor/code coverage

Issue
Description
Checklist

Code is easy to understand
No obvious errors or bugs
CI/CD Pipelines did run successfully
Tests were implemented
Documentation was created

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@c68cd17). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage        ?   48.72%
=======================================
  Files           ?       10
  Lines           ?      236
  Branches        ?       34
=======================================
  Hits            ?      115
  Misses          ?       87
  Partials        ?       34

Flag
Coverage Δ

unittests
48.72% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


(epub) move temporary mp3 files to temporary folder

when an epub are converted in m4b, the following steps are executed:

extractiong all data from epub in a temporary folder
extract guide from epub
for each file (not in guide)

extract text and save it (on the folder where the script is executed)
generate mp3 and save it (on the folder where the script is executed)

generate ffmetada starting from mp3 generate previously
merge all mp3 and ffmetada in unique M4B file

The goal of this activity is remove the temporary file.

closed with b41e50dfc1bebc336d669b6bc7dc965b2d6a2ae7


1.0.0-beta3 - best approach for DefaultRoute functionality?

I'm trying to implement something like <DefaultRoute/>, which doesn't appear to exist in 1.0.0-beta3. I have this working w/ a <Redirect/>, but is there a recommended approach for this?
Example:
<Route path="dash" component={...}/>
<Route path="/some/other/page" component={...}/>
<Redirect from="*" to="dash"/>

There are a couple of approaches:
#1315 suggests handling the default in the parent's render method:
render() {
    return <div>
        {this.props.children || "This is the default text"}
    </div>
}

#1333 suggests no path on the parent; the index and detail are siblings.
 <Route component={App}>
    <Route path="/" component={DefaultView}/>
    <Route path="/eg1" component={View1}/>
    {/* ... */}
</Route>

I'm not sure which one is to be preferred. I've been doing the latter, but it gets a little unwieldy if you have nested default views for something like

Cool thanks!

Hi guys, I've being using both of these examples #1474 but I'm getting a warning using the
{this.props.children || "This is the default text"}

approach and the
<Route path="/" component={DefaultView}/>

doesn't work for nested routes.
Do you guys, have any suggestions to avoid that warning?

In my initial question I mentioned I'm doing this:
<Redirect from="*" to="dash"/>
Which actually works fine for me. Probably some would consider this an abuse, but logically I see this as, "anything that didn't get matched by more specific rules, go to 'dash'"...so I'm not too broken up about this. Remains to be seen if I'll run into issues w/ this down the road..

Hi im also looking for an elegant solution to this matter..
I have several mini apps that runs on different root path
<Route path='app1' component={App1}>
  <Route component=App1Dashboard>
  ...
</Route>
<Route path='app2' component={App2}>
  <Route component=App2Dashboard>
  ...
</Route>

i cant seem to make /app1 and /app2 to work
the child routes work though. e.g.: /app1/blah, etc..

I ended up need to implement my own DefaultRoute that override onEnter to do so. I'm curious to see if there's a better solution to this.


Update docs for federated identity credentials

Update docs for new OIDC (federated identity credentials)
Pipeline Config: https://learn.microsoft.com/en-us/azure/developer/azure-developer-cli/configure-devops-pipeline?tabs=GitHub
FAQ: https://learn.microsoft.com/en-us/azure/developer/azure-developer-cli/faq
Related: #408
Details for feature documented: #1086

@hhunter-ms, can you take a look?

Done


feat: add Connect Wallet pop up screen

Description
Closes: #XXXX
BDU-669

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[x] ran linting
[x] wrote tests where necessary
[x] included the correct type prefix in the PR title
[x] targeted the correct branch
[x] provided a link to the relevant issue or specification
[x] reviewed "Files changed" and left comments if necessary
[x] confirmed all CI checks have passed
[x] added an entry to the CHANGELOG.md file

LGTM, Thanks @MonikaCat can mark the story as done, but won't merge this for now

Closing as this is now replaced with https://github.com/forbole/big-dipper-2.0-cosmos/pull/1128


Prepare for hex publication.

Coverage remained the same at 100.0% when pulling 23bce329bca31e8088eba59d0d1ffcb3e37f0690 on prepare-for-hex-publish into 022fbe1bca3dd883ff260aa2a3d162c2e869ce80 on master.

Coverage remained the same at 100.0% when pulling ecf7aa5837c0a4a8fb73d343a2ca61334bcd531f on prepare-for-hex-publish into 022fbe1bca3dd883ff260aa2a3d162c2e869ce80 on master.


fix dependency conflict issue

#462  fix dependency conflict issue for commons-codec:commons-codec

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Ensure list view doesn't show unexpectedly

Previously when changing any unrelated prop, the list view would show up

:+1: solved it for me too!!! thanks

Thanks for the PR!


Update documentation for 14.1.0 release

The documentation needs to be updated for the 14.0.1 release.

I updated the documentation.  Close this issue.


Direct Manipulation doesn't work. Can't get TextInput value from ref

Environment
Environment:
  OS: macOS High Sierra 10.13.4
  Node: 8.11.3
  Yarn: Not Found
  npm: 5.6.0
  Watchman: 4.9.0
  Xcode: Xcode 9.4.1 Build version 9F2000
  Android Studio: 3.1 AI-173.4819257

Packages: (wanted => installed)
  react: 16.3.0-alpha.2 => 16.3.0-alpha.2
  react-native: 0.54.2 => 0.54.2

Description
ref doesn't work. I can't get value from TextInput
Reproducible Demo
No demo!
This real live code is enough for you to understand and reproduce
const first_name = ...
render() {
    return (
      <View>
        <View style={{marginVertical: 10}}>
          <TextInput
            ref={ ref => this.first_name = ref }
            // This doesn't work. You give this as an example in your docs. But this doesn't work
            onChangeText={ text => this.first_name.setNativeProps({text}) }
            keyboardType={'default'}
            placeholder={'Your first name'}
            defaultValue={ first_name }
          />
        </View>
}

All these things do not work:
this.first_name._inputRef.value // => undefined
this.first_name.value // => undefined
this.first_name._getText() // => returns ONLY defaultValue. Never returns updated value.
this.first_name._inputRef._getText() // => not available

You give this as an example in your docs.

I just checked both these pages (1, 2) but there is nothing saying to use the ref element, where have you seen that code?

@kelset
Here https://facebook.github.io/react-native/docs/direct-manipulation#setnativeprops-to-clear-textinput-value
Precisely, this part. The only difference is that it is example for clearText.
  clearText = () => {
    this._textInput.setNativeProps({text: ''});
  }
        <TextInput
          ref={component => this._textInput = component}
        />
        <TouchableOpacity onPress={this.clearText}>
          <Text>Clear text</Text>
        </TouchableOpacity>

So in my case I do the same but differently, for capturing text typing
          <TextInput
            ref={ ref => this.first_name = ref }
            onChangeText={ text => this.first_name.setNativeProps({text}) }
          />

I hope you realise that:

you are not paying for any kind of support
React Native is a 0.x project so keeping up to date with the latest release is your responsability
we tests releases before rolling them out

I also suggest you start behaving accordingly to the CoC or we will enforce it.

Here's a workaround.
monkeypatch the TextInput class:
`import { TextInput } from 'react-native';
TextInput.prototype.componentDidMount = function() {
if (this.props.getRef) {
this.props.getRef(this);
}
this._lastNativeText = this.props.value;
if (!this.context.focusEmitter) {
if (this.props.autoFocus) {
this.requestAnimationFrame(this.focus);
}
return;
}
this._focusSubscription = this.context.focusEmitter.addListener(
'focus',
el => {
if (this === el) {
this.requestAnimationFrame(this.focus);
} else if (this.isFocused()) {
this.blur();
}
}
);
if (this.props.autoFocus) {
this.context.onFocusRequested(this);
}
};
`
Then use 'getRef' to get the actual ref:
 <TextInput         getRef={ref => …} …

The original report is for an older version of React Native, and the TextInput component has been updated significantly since then. Closing - if someone believes this is still an issue in 0.58 or later, please do feel free to open a new issue.


Get description metadata

Created a lightweight query endpoint to retrieve the OpenGraph metadata from a 3rd party web site.
This is used for collection admin tools only
https://getpocket.atlassian.net/browse/TML-86
Note that this alternative Parser modification was considered but we are trying to limit changes to the parser
https://getpocket.atlassian.net/wiki/spaces/PE/pages/2988441601/Spec+Add+article+description+to+Item

Duplicate PR - other PR with signed commits was just merged


OData endpoint returns 406 Not Acceptable

Hi,
I have successfully run the SwaggerODataWebApiSample example and could hit all of the endpoints.
However, I want to add some OData controllers to my existent versioned Web API solution.
My WebApiConfig.cs looks like this:
public static void Register(HttpConfiguration config)
       {

           config.Formatters.JsonFormatter.SupportedMediaTypes
               .Add(new MediaTypeHeaderValue("text/json"));
           var constraintResolver = new DefaultInlineConstraintResolver()
           {
               ConstraintMap =
               {
                   ["apiVersion"] = typeof( ApiVersionRouteConstraint )
               }
           };
           config.MapHttpAttributeRoutes(constraintResolver);
           config.AddApiVersioning(o => o.ReportApiVersions = true);

           GlobalConfiguration.Configuration.Formatters.JsonFormatter.SerializerSettings
               .ReferenceLoopHandling = Newtonsoft.Json.ReferenceLoopHandling.Ignore;

           GlobalConfiguration.Configuration.Formatters
               .Remove(GlobalConfiguration.Configuration.Formatters.XmlFormatter);

           GlobalConfiguration.Configuration.Filters.Add(new CustomExceptionFilterAttribute());

           GlobalConfiguration.Configuration.Filters.Add(new IdentityBasicAuthenticationAttribute());
    }

And I added the lines of the Startup.cs on your example (excluding the Swagger stuff), like this:
var modelBuilder = new VersionedODataModelBuilder(config)
           {
               ModelBuilderFactory = () => new ODataConventionModelBuilder().EnableLowerCamelCase(),
               ModelConfigurations =
               {
                   new PersonModelConfiguration()
               }
           };
           var models = modelBuilder.GetEdmModels();

           config.MapVersionedODataRoutes("odata", "api", models, ConfigureODataServices);
           config.MapVersionedODataRoutes("odata-bypath", "api/v{apiVersion}", models, ConfigureODataServices);

While compiles OK, I get a 406 Not Acceptable code when I try to access the route:
api/v1/people(1) . I have also tried several combinations of the elements of that route without any success.
The route api/v1/ seems to go to the $metadata controller.
What could I be doing wrong? Is it possible to have a versioned Web API and versioned OData controllers with the same solution configuration?
Thank you.

First, it's definitely possible to do both. You can look at the advanced OData Web API sample for an end-to-end example. One thing to note is that there are limitations in the Web API routing infrastructure. You need to be careful if you use API versioning and mix in attribute-based routing for normal controllers. OData only supports convention-based routes under the hood. You might be ok if you don't switch regular and OData controllers for a given service in between API versions. If you switch, then you'll almost certainly need to use convention-based routes. It's kind of lame, but to be sure, you might consider convention-based routes only. I have also found that using that approach helps you troubleshoot routing issues if or when they arise.
A few other minor points:

In your Register method, the HttpConfiguration is already provided; prefer the parameter over GlobalConfiguration.Configuration
You do not need both flavors of MapVersionedODataRoutes. The example shows both merely so I didn't have to create two applications. I suggest that you choose to version by query string or by URL segment, but not both. My recommendation is by query string.
Why are you registering text/json? That is not the official MIME type for JSON; application/json is and is already registered. For additional details refer to this documentation.

Without more information, it's difficult to be sure exactly what's causing the 406, but it is definitely related to media type negotiation. Web API does this by using the registered MediaTypeFormatter instances. If I had to guess, you are sending a request to an OData endpoint that has the media type text/json, which will not work. Furthemore, OData uses its own MediaTypeFormatter that does not use or rely on JSON.NET. Since you are receiving 406, this indicates to me that the route selected was for an OData-based controller, but it was unable to format the response. Assuming the routes are configured correctly, sending a request that accepts application/json will produce the expected response as is demonstrated in advanced OData example.
I hope that gets you going in the right direction. Let me know if you continue to be stuck.

Hi Chris,
First of all, thank so much for your detailed answer. I did take a look at the advanced OData Web API sample and adjusted some things on my Register method based on the sample.
I can confirm that the route that is being selected is an OData one (for example, I could hit a breakpoint under the People controller's Get method), but right after that, the response is throwing the 406 error.
Also, I commented all the Formatters related lines with the same results. Regular controllers still work.
I have also tried, comparing all the using references from the controllers and the Startup.cs from the sample and modifying them on my solution. On some cases, I was referencing the System.Web.Http.OData namespace instead of System.Web.Http.OData. However, after I tried this, I started to get an error at Global.asax.cs saying:
The path template 'People' on the action 'Get' in controller 'People' is not a valid OData path template. Resource not found for the segment 'People'.
After that, I noticed that I had some issues in the PersonModelConfiguration class. Adjusting those made both OData and Web Api controllers work.
Regarding the points you mentioned:

Yes, you're right. I guess I got distracted and forgot to modify that.
I tried one of the MapVersionedODataRoutes forms but had the same results.
Don't know exactly why was this configured like that (could be some front-end related reason).

It seems that with your guidance combined to checking the sample solutions enabled me to solve the issue.
Thank you.
Agustín

Glad to hear it. Let me know if you run into any other issues.


Update Included 5.40 node12.19.0 chrome86 ff82

Updates the included image 5.4.0 to use cypress/browsers:node12.19.0-chrome86-ff82.
This PR is based on #389 and #390.

Hi, @ottnorml thanks for opening a PR, but as a rule (that I just added to our guide, should have been done a long time ago https://github.com/cypress-io/cypress-docker-images/blob/master/CONTRIBUTING.md#replacing-existing-images) we do not replace existing images.

Thanks for clarifying. :)


Error contains password in plaintext

Hi, I'm using ioredis like this (simplified):
import Redis from 'ioredis'

const password = process.env.REDIS_PASSWORD // e.g. 'abc123'
const redis = new Redis({ password })

redis.on('error', (error) => {
  logger.error('Redis error', error)
})

Due to a human error, the password used was not the correct one for my service, so ioredis could not connect.
This resulted in the following error:
Error {
  command: {
    name: 'auth',
    args: ['abc123']
  }
}

Since this error gets emitted and ultimately logged, it ended up in plaintext in my service logs, which for some could equate to a security incident.
I've since made sure to omiterror.command.args before logging. But is this expected behavior? Is there a better way to handle this?

Hey Sam, thanks for bringing this to our attention!
To be frank I didn't think about this issue before but it makes sense to avoid logging sensitive data at the library level. I open to any suggestions regarding this.

Hey Luin! Okay, how about this?
Assuming that the consensus is that any data (not just passwords) is potentially sensitive:
Make the existence of error.command.args configurable through a flag (e.g. errorsContainCommandArgs). This could start as an opt-out, to not break current behavior. If the option is not explicitly set by the user, ioredis can log a warning:

[ioredis] Command args in errors are deprecated.
In the future, command args will not automatically be included in the error object.
To keep the current behavior, set errorsContainCommandArgs: true when configuring ioredis

Yeah, that sounds reasonable. Can you make a PR for that?

PR is up! :)

@luin Feel free to review #1233 when you have time

@luin Hi Zihua, is there a plan to merge #1233 ?
It would be really nice to hide the credentials from the logs when an error occurs.

Closing as I no longer have context on this library. If someone reads this and it is still a problem, open a new issue 👍