Confusing diffs in first time settings sync

Testing #103604
I am using settings sync when I'm normally using code-insiders, and I have signed in using GitHub. For testing, I signed in using a Microsoft account, and I am using a different user-data-dir and extensions-dir as mentioned in the test plan item.

Turn on settings sync, sign in using MS
"Settings Sync: Show synced data"
Activity/State from both accounts is visible

On my MS account, I don't have any extensions installed.

On my MS account, I don't have any extensions installed.

Built in extensions are also included to sync their enablement state. So Extensions entry include both built in & installed. Can you please open Extensions and make sure that is the case?
If you are also seeing installed extensions or data which you did not synced can you please provide the steps to repro, above steps do not look complete enough.

Built in extensions are also included to sync their enablement state.

Ah yes, that seems to be the case indeed. :see_no_evil:
Although turning on sync for the first time gives me this activity.

As you said, it looks like these are all the built-in extensions, but I'm not really sure what the diff view signifies in this case. As I turned on sync for the first time, I expected the diff view to look something like this:

or

Old
Current

{}
{ "window.zoomLevel": 1 }

Might be related. If it's not I can create another issue.
The diffs are confusing for globalState.json as well. No matter what change I make, it always shows up like this:

Diffs seem wrong to me. Please update the description and it would be great if you can provide me the steps to repro.

@sandy081 steps to repro are:

Turn on settings sync
Make some changes / move around some UI
"Settings Sync: Show Synced Data"
Click on diffs


Use Chrome's built-in favicon cache

Prevent excessive amount of favicon requests, if you have a lot of tabs.
Also, this fixes a number of other issues with favicons:

Unopened tabs/pages favicons now work (resolves #21)
Chrome url extension pages favicon now work
More..

Absolutely understandable without any additional tests. And you did look into this solution some time ago with issues, so I would definitely be hesitant myself. However, maybe they internally updated some things since then? I haven't notice an issue, yet (wrong/missing/inconsistent, as you describe, nor does it ever hit the network). And I have a lot of tabs. I noticed it would saturate my bandwidth for at least a good couple of seconds every time I opened tabli popup, while slowly loading the favicons one by one. But with this solution it has been instantaneous. As you probably already know, this is the same solution used internally by chrome://history and chrome://bookmarks.
I don't mind if you don't accept the pull request, but maybe look into this again. :+1:

Thanks.  While anecdotal, that's very useful information.  I can't make any promises right now about when I might get to it, but this certainly merits revisiting.  Thanks again for this submission and comments.

So, after a long hiatus and then working on many other Tabli issues, I've finally come back to take another look at this.
The original PR is no longer applicable, but since it was a two liner I've made the change locally to current master. It sure does seem to work well!  I'll continue testing locally and (if all goes well) will incorporate this into the next release, and will add you to a CONTRIBUTORS file in the source to give you credit for this.  Thank you very much for this contribution!

(...minor clarification: I'm currently on a flight so change is only in my local copy for now, but should hit master within 24 hours.)

Awesome! Glad to see you are having the same results now.

No issues after a couple of days of banging on this. Merged in and closing PR. Thanks again @jonbo!


Allow debuggers to support StepBack without ReverseContinue

The "ReverseContinue" action is controlled by the same supportsStepBack flag that "StepBack" is. This means for any debugger than can support step back, but not reverse continue, there will be an extra button on the debug toolbar that won't function.

Adding a new capability or changing the existing ones in a m^backward compatible way would be a mess.
No plans to do this.

I forgot to post back here - I was actually using the wrong thing here anyway (I was implementing RestartFrame). It's done correctly now so I'm not using this now :-)


add podcast_length parameter to rss feed

Still determining if this is needed.

Confirmed is needed.
https://help.apple.com/itc/podcasts_connect/#/itcb54353390

This should also have a check to see if it is isset and also if it is equal to "" - only display if it is set to a value.


fix: save with latest google chrome

This PR is to address #424
The challenge was that our resizing set the browser outer dimensions, but this does not account for space taken up by browser UI elements (which vary by browser). We had a "crud factor" set that basically accounted for this space by blissful accident.
.save() now explicitly tries to calculate the space between outer and inner browser dimensions, with a much smaller crud factor (to create some small padding around the table. This is important because table borders without crud factor might cause issues).

@rich-iannone do you mind checking the uploaded screenshots when you review? They're tucked intot he "Test for saving table image..." gh action...

When it's time, let's squash and merge this so the orphan commit isn't in our history


Enable to send multi SELECT and get multi results

Enable to send multi SELECT and get multi results  (at least 3 SELECT)
Highlight 3 SELECT with mouse and clicking "Run" button.
Using SnowFlake JDBC connectors.
Enable to the 3 results (back to back) in the same panel.

Ok thanks!
Le mar. 11 juin 2024 à 09:45, Elizabeth @.***> a écrit :

If I correctly understood you, we have such mode for execution as a script
with this button image.png (view on web)
https://github.com/dbeaver/dbeaver/assets/28875055/be3d3a7f-34ab-4c8c-b48f-d03effa93314
You can enable it in the context menu
image.png (view on web)
https://github.com/dbeaver/dbeaver/assets/28875055/a3b68ed2-bb39-478b-80d0-d110e5108b0d
—
Reply to this email directly, view it on GitHub
https://github.com/dbeaver/dbeaver/issues/34317#issuecomment-2160808676,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJCODLATJ6GJNM3AT36JFULZG35QLAVCNFSM6AAAAABJCORSR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRQHAYDQNRXGY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Improvement: adding in options for the applied className and the titleSeparator

Hey, there friend,
It would be super helpful if we could update the plugin to accept options such as className and titleSeparator. For example, a user (in this case me) might want to do something like language:title=an-example-title versus language:an-example-title in their input.
Here's what the new interface could look like. I'm more than happy to make a PR as well b/c I had to make changes to your plugin for it to fit my use case  😊.
import { BuildVisitor, visit } from "unist-util-visit";
import type * as H from "hast";
import type { VisitorResult } from "unist-util-visit";

type Options = {
  className?: string;
  titleSeparator?: string;
};

function rehypeConfigurableCodeTitles() {
  return function optionsHof({
    className = "rehype-configurable-code-title",
    titleSeparator = ":",
  }: Options) {
    return function transformer(tree: H.Root) {
      const visitor: BuildVisitor<H.Root, "element"> = (
        node,
        index,
        parent
      ): VisitorResult => {
        // a changed implementation that leverages the options
      }

      visit(tree, "element", visitor);
    };
  };
}

export default rehypeConfigurableCodeTitles;

Hey @tearingItUp786 I like the idea may I ask why the separator needed to be changed?
If you are willing to put up a PR that ensures there is backwards compatibility for current users I would be more than happy to add the feature.

Yup, more than happy to make a PR! I want the option for the separator because I'm coming from gatsby-remark-code-titles and all my mdx files are using the :title= syntax for the separator and I quite like it!
I'll throw something up right now!

Closed by #240


regex error for video (akamaized pattern)

I am getting this error
<class 'pytube.exceptions.RegexMatchError'>,
RegexMatchError('regex pattern (yt\.akamaized\.net/\)\s*\|\|\s*.?\sc\s*&&\sd\.set\([^,]+\s,\s*(?P[a-zA-Z0-9$]+)\() had zero matches',)
When attempting to construct the YouTube instance for this video https://youtu.be/IABRgZH12YA
I've also tried the long link (https://www.youtube.com/watch?v=IABRgZH12YA&feature=youtu.be) and it did not work.
repro:
from pytube import YouTube
yt = YouTube("https://youtu.be/IABRgZH12YA")

pytube version 9.3.5

Same error ! Check out this code:
from pytube import YouTube as Youtube

yt = Youtube('https://www.youtube.com/watch?v=nsm4ReJaED0')
yt.streams.all()

_pytube.exceptions.RegexMatchError: regex pattern (yt.akamaized.net/)\s||\s.?\sc\s*&&\sd.set([^,]+\s,\s*(?P[a-zA-Z0-9$]+)() had zero matches_**

seems like the fix mentioned in this thread  applies to this problem as well. When I update the regex pattern in cipher.py, it works, but is that actually the right fix?

dupe of issue #333, closing this. For now, use the fix as detailed in #333


Submitting to multiple MC endpoints

Hey guys,
I'm building a Gatsby site that needs to use 2 MailChimp endpoints (2 different lists). I suspect this may be somewhat common, and the way the current configuration is leaves this plugin a bit inflexible. It might be better to pass the endpoint as a parameter to addToMailChimp as opposed to defining it in the config file. Thoughts?

I prefer to leave it in the config bc then what if you have multiple components that want to submit to MC, then you have to defined the endpoint in each component.  That gets a bit messy.
Although, I am open to the idea of submitting to multiple MC endpoints.  Not sure how you would handle the success/error state... what if one fails but the others pass?

I need to refactor to allow for this option.  Feel free to open a PR @isaac-martin ! :)


Failed to build on ios

-i use same code on android and ios  = in android it build without problems and in ios it show me this(see image)
if i remove plugin it is building normaly

this error happen in lot of apps not just in single app

could you please tell me your version of cordova, plugin, and xcode?

latest version of admobpro and xcode 5.1.1

This macro is introduced by Apple in newer version of Xcode. My xcode is v7.1.1, it build quite well.
You need upgrade xcode.


Add open-folder-in-application extension

Description

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi 👋
Thanks for your contribution 🔥
This extension seems to be pretty similar to Folder Search, could you check that out?

At first glance, the extensions seem somewhat similar.
However, with Folder search, when you hit enter, it opens the folder by default. To open in application, you have to:

Open the extension
Search for a folder
Open Folder Actions
Select the application
Then open the folder in the app

With My extension, it immediately opens with the application selector once you select a folder. Hence the name "Open Folder in Application".
I believe there is value in being able to open a folder in an application quickly. Else what is the point of Raycast. If there's so many steps involved one might as well just launch your app from the terminal or use Alfred.

@pernielsentikaer ☝

Hi! Thanks for your effort making this extension!
I believe that the following extensions:
https://www.raycast.com/timothy_boye/open-folders
https://www.raycast.com/GastroGeek/folder-search
The missing feature that you are adding here would fit perfectly in one of them. I would suggest creating another PR adding it to one of these. Let me know if you have any concerns and want to discuss this further.


Add 'reset discussion' feature

Solves #53, adds a "reset discussion" button which recreates a list by deleting it and creating a new one with the same name.

Looks good. I did some on-GitHub wild west committing :D


Missing Data

Data missing from Health, Demographics, Earnings, Natural Products

Health has been removed.
Demographics needs census data.
Earnings is complete.
Natural Products is complete.

Labor needs Unemployment Rate data from here

State Sales tax needs to be automatically updated to Earnings


Table rerender infinitely with non-zero padding for left and right

If i set the following style for my td
td { text-align: center; padding: 4px 2px; }

the component is rerendering and goes on expading overflowing the page width

I am facing similar issues with infinite expansion. I suspect it is where the code attempts to keep headers of the columns (which are outside the table) the same with as the cells in the columns. Try applying the same padding to "th" as well to see if it still occurs.


llvm-header-guard diagnostics not generated for headers with --clang-tidy

I use clangd as an LSP in my neovim setup. It works fine and I get diagnostics and code actions just fine. However, today, I noticed that clangd would just not give me diagnostics when I enabled llvm-header-guard as a check in my project's .clang-tidy file. This is weird because when I run clang-tidy on the CLI, I do get the diagnostics for this test, leading me to believe that something might be happening in clangd.
System information
Output of clangd --version:
clangd version 16.0.6
Features: linux
Platform: x86_64-pc-linux-gnu

Editor/LSP plugin:
neovim with nvim-lspconfig
Operating system:
Arch Linux

As ckandeler mentioned on Discord, this check is deliberately disabled for clangd.
The accompanying comment is:
      // Check relies on seeing ifndef/define/endif directives,
      // clangd doesn't replay those when using a preamble.

I don't have a sense for how feasible it would be to remove this limitation (i.e. start replaying the relevant directives). I will keep the issue open to track investigating this.


Generate and run benchmark artifacts with Python

This is an attempt towards #5767.
Right now we have the problem that the models we want to
benchmark are compiled with various options (for different
configurations, for working around issues, etc.) not covered in
normal tests. Frequently, we see compilation failures in the
benchmark pipeline itself, because we have disjoint flows
there: the benchmark pipeline uses its own Python script
which embeds those compilation/runtime flags.
This commit takes a step to place the artifact generation
in the build system itself, with a dedicated target, for better
integration and unification. It will enable running them as a
normal step during project compilation/testing. It also allows
easier local generation of the suite for repro purposes.
This goes directly from Python source model with real
weights. It helps to reduce friction and avoids surprises
because fake weights can trigger different CodeGen paths.
There are multiple levels we may want to add benchmarks.
This covers Python input benchmarks, which is the most
complicated. For MLIR/C++ input benchmarks, we can have
similar CMake macros/functions for adding them and place
them into the same filesystem directory so we can zip them
easily later for running on a phone.
For a unified local/CI workflow, a script is added to probe
Android devices and use its CPU/GPU target information
to filter compiled benchmarks and run matched benchmarks
on the device.

It looks like *_benchmark.py are copied from integrations/tensorflow/e2e/*, how do we prevent the case that one changed, but another did not change?

I won't worry too much over that. We will likely just have very few cases for both _test.py and _benchmark.py as we don't want to benchmark all the Python scripts for testing. For the ones we have both, the code is actually very short; just a few lines. It does not matter that much as we just copy here. And the scripts change very slowly (if ever). So it's a quite low maintenance task to keep them sync, with the benefit that we don't mix too much stuff in the same source script. (The Python layer is already complicated enough..)

Thanks for the detailed review, @GMNGeoffrey! Replying to your comments:

There seems to be a fair amount of duplication with the testing, like we have to have separate benchmark python files for each benchmark.

Hanhan raised a similar concern. I actually don't worry that much. See my reply here: https://github.com/google/iree/pull/5837#issuecomment-840848697.

There's some fair amount of fiddliness with all the phone setup. That actually looks unavoidable to me, but I'm a bit worried about whether we're depending on magic strings somewhere that are going to be hard to change. I guess I need to look at your upload scripting :-)

Actually here it deserves some explanation why I did it this way.
The main considerations I have is to make benchmarking scalable. To me, it should mean scable across three "dimensions": 1) developer flow, 2) new models, 3) new phones. The goal is that adding a benchmark should be just as simple as registering a new CMake target or adding a new device to Buildkite and nothing more. All the rest of the pipeline should adjust accordingly, instead of requiring touching various places.
To achieve this, we need a way to encode the benchmark and use it to chain various components (artifacts generation, data collection, pushing to dashboard/GitHub PR, etc.). Using a structured string is what I find actually a good trade off here. If we just have a numeric ID, then we need a way to convert between the benchmark and its ID at basically all components. And assigning the ID can introduce quite some complexity (do we need a server for it? where do we host the mapping? A script or ?) Just like the old reliable way of using file as pipe in Unix systems. :) Also the additional benefits that it's always readable and very clear what we are handling (as the string encodes major important bits).
But it does require that we think ahead regarding the benchmark string format so we anticipate future cases. I currently designed it like
<model-name> (<additional-model-info>) [<source-ml-framework-tool-etc>] with <runner> @ <phone-model> (<phone-details>)

I think it should be sufficient to capture various "degrees of freedom" we have. But any feedback is welcome here!
The scripts provide various maps. One goal there is also to provide a "hook" where we can redefine things if necessary for additional flexibility (though I wish we don't use it much).

I'm a bit worried about the extra complexity we're adding here. Ah well. I guess the main point there is: if we go forward with this can we completely delete the current custom scripting we have for benchmarking or is this on top of that? (obviously transition period, etc.). Just worried that we'll have a halfway migrated thing and then have to deal with the complexity of both (a situation I've been guilty of creating multiple times in the past...)

Yeah. complexity comes from various places. Some are from the problem that we cannot eliminate at all. Some are due to engineering. :) But here I think the majority of the complexity is already there. The "heavy" part is compiling artifacts, which I just leverage what we have for testing with some minor addition to pass in additional compilation/run flags. The other code are mainly for threading stuff together. IIUC, we are gonna improve the testing part. I'd expect when that happens we take benchmark into consideration and have a better structure. :)

I'm having trouble tracking everything that's going on in this PR, but the last high-level comment I saw was Scott asking for us to take a step back, which is why I haven't approved.
Without going line by line, my concerns are:

The facility to add additional runtime and compile-time flags is only added for benchmarking. This is very worrying, since we should really be testing whatever we're benchmarking. I understand we might continue to want to test and benchmark special flags (especially as we're rolling out a new feature, for instance), but at the last I don't think it should be for benchmarking only.
Entire model files and utilities are duplicated from testing to benchmarking. Right now there aren't too many of those, but this seems the opposite of the scalability you're looking for.
The testing utils acquire a new boolean param for "don't do one of the things", which feels very much like a hack.

And then overall, I have a hard time seeing if I've missed something in the discussions here because there are so many (and the GitHub UI doesn't help with that).
All that said, I don't currently have better suggestions that I can put into practice and I don't want to let the perfect be the enemy of the good here. So I'm kind of fine going forward, but just with the caveat that I have the above misgivings.

+1 to Geoffrey's comments. Broadly speaking, this improves upon our current infrastructure in several ways and I don't want to derail that. I do think that if we're taking the time to refactor for future scaling then we should iterate a bit more on the design.

Thanks for the feedback, @ScottTodd and @GMNGeoffrey!
Sorry this bundles too much stuff; it gets larger and larger as I address comments and fix issues. I do want to push this forward asap so that we can address recurring issues w.r.t. benchmarking and scale our benchmark suite; but I'm entirely fine to take a step back given the concerns here. So what about this:

Let me create a design doc to describe how I think everything should connect for the benchmark pipeline. We can list short term solutions vs. long term ones. For short term ones how much overhead they add and how to migrate it away. So we can agree on those and make forward progress, not gated on waiting everything to be properly addressed.

Let me break this pull request down and send various bits out separately. (I think certain components are useful in its own so they can land first.)

Does this sounds good? :)

Yes that approach makes sense to me. And sorry for holding things up here. Like I said, I don't think you should consider me a hard blocker because I agree that there's a real benefit to getting this done sooner rather than later.
And I totally understand that sometimes something starts a reasonable size and then balloons :-)

SGTM! Thanks for your patience :)

This is obsolete and not needed anymore.


pulumi-bin: 3.138.0 -> 3.140.0

https://github.com/pulumi/pulumi/compare/v3.138.0...v3.140.0
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Closed due to #358725


bug: Explorer freezes when loading big image

Describe the bug
When moving fast through files, if it catches a big image file, it freezes until the image is loaded, even though I jumped out of the file already.
To Reproduce
Go to any directory with any big image and other files. Hold J to navigate down the directory. When it catches the big file, it freezes and jumps 2-4 files ahead when the file finishes loading.
Expected behavior
The explorer should behave smoothly and kill the loading process if the user already jumped out of the file.

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Hey @AleryBerry, thanks for the bug report. I'm currently working on this issue!
It's unfortunately a bit of a tricky one but I'm going to test with updating the library / possibly threading the image loading process as to not cause the user to freeze.

Hey @AleryBerry, I've gone ahead and created a new release which should help with viewing large images.
You can download the latest version here https://github.com/BrookJeynes/zfe/releases/tag/v0.5.0
Unfortunately, this doesn't really fix the issue at hard but more or less optimises the current approach. I'm going to leave this issue open as I plan to experiment with threading the image loading process to hopefully fix the problem at its root.

@BrookJeynes I tested it and it's working a lot better although it still freezes the explorer a bit. Looking forward for the threading update!


Cancel the other branch when there's succeess in a race

I think this could probably use a test (using cancelWith).

@natefaubion How's this?

👍


Fix citation formatting in README.md

Fix citation to not use {}-encapsulation for all fields.
Probably the world's smallest fix, but it annoyed me while writing my thesis, so figured I'd change it to make life easier for anyone wanting to use the citations in the future.
I am by no means doing this to say "Hey, look how I contributed to a large language model", so feel free to deny the PR if you fear for that!

Thank you, and thanks for referring to our article. Please send us a link to your thesis.

Thanks for approving the PR, always a pleasure to be able to help (even for small things)!
I will do my best to remember to send it to you! It may be held back from publication for some time, and is focused on business models of LLMs, rather than any technical developments, but I will try to remember to send it when it's done! 🐱


GPU - Random freezing

Please check if your issue is not a duplicate by searching existing issues
Describe the bug
Hi, I do a lot of risk fighting in PVP worlds via runelite, stretched mode and GPU enabled, within the logs I have had a recent crash and the GPU has been to blame...which lost me some gp...is there a way i can fix this to ensure i don't dc mid fight again please?
Expected behavior
Advice based on the logs uploaded.
Screenshots
Not applicable, I closed the client down in a fit of rage...apologies.
Environment
client.log
:

You aren't using RuneLite, but instead a cheat client. Instead download runelite from https://runelite.net.


Torch distributed hotfix

#69 Mentioned tensor_parallel not working properly. This PR fixes it.
This functionality hasn't been properly tested in a long time. This PR does not add tests but fixes immediate behavior. Will add tests later.

transformers==4.28.0 was released and LLaMA tests kicked in. I needed to tweak them a little.
e


test: add simple stress tests for rarity simulation

Just two very simple test cases that are intended to be first step towards measuring how rarity simulation performs. Let me know if these make some sense and could be interesting. I mostly just want to start a discussion with this PR. All hints for further test cases are of course welcome.

long-loop-single.c: This one is found pretty reliably by the current implementation. When I run it against the monster solver (as well as boolector and z3) I need to increase the execution depth to about -d 10000 for the bug to be found.
long-loop-triple.c: The rarity simulation has a much harder time with this one, most runs I started didn't find the bug. I wasn't able to make the other solvers find the bug here either, I have a suspicion they might be having troubles because I am re-using the same memory location at x[0] multiple times. I'll investigate further.

Yep, my suspicion seems to have been correct, I filed issue #111 with details.

Merged rarity-simulation into main. Therefore I rebased your PR! :)


Take down x link on blog

Delete the following lines:

The change has been made in dev using the branch for the next blog posting.


ENet version?

Dear Maxim,
Nice to read your paper. Congrats for getting selected in the CVPR 18. Great joob!!!
I am interested in fine tuned ENet version of your work. If you can provide relevant prototxt files and pre trained weights and/or modified caffe build would help me alot.
Thanks

Hi @sourabhyadav, we will provide the trained weights later on. Keep in mind though that it won't be in caffe, I've been using my "ENet pytorch" implementation as described in https://github.com/bermanmaxim/Enet-PyTorch (this model is directly converted from the lua-torch model provided by the authors).


Add a way to indicate which frame will be used for the printed version of an animated gif

An animated gif can be great in a web browser. For example:

However, when printed, it uses this frame (yuck):

It will use the first frame of the gif.
We can't control this.
What you can do is to make a frame at the beggining to be the frame that you want to use in print.


Fixed description of num_threads in tf.lite.interpreter doc

Hi
As per the code  tensorflow/tensorflow/lite/python/interpreter.py
Lines 460 to 464 in b297295 , code num_threads is greater than equal to 1 but in description it was given as -1. This PR fixes description of num_threads in tf.lite.interpreter doc.
This PR fixes: TFLite issue #68862
Thank You

Hi @junjiang-lab , Can you please review this PR? Thank you .

Hi @junjiang-lab,
Thank You for the suggestion. If num_threads >=1, no need to mention about 0 and -1 cases. So removed those lines.
Thank You


Add R as a highlighted language

There is a rather large R community on Twitter (#rstats) that I think would appreciate this.

Hi, @samhinshaw. Thanks for the PR. This looks good to me.

:shipit:

Thank you all for the wonderful work you do! 😊


How to export non-numeric "issue" field of journal article as "number" field in BIB reference?

Report ID: X82SY2H4-euc
Exporter used: Better BibLaTeX
Expected behavior: Non-numeric issue field in journal article item should get exported in the number reference field.
Actual behavior:  The issue item field gets exported in the issue reference field.

It seems that the way Better BibLaTeX exports the issue field of a Journal Article item depends on whether or not the the field value is numeric: if it is, it gets exported in the number reference field; otherwise, in the issue field.
I can see that being reasonable behaviour in general, but I would like to override it and have the item issue be exported into the reference number even when it is non-numeric.  I tried doing that by adding the following postscript:
if (Translator.BetterTeX) {
  if (item.itemType == 'journalArticle' && item.has.issue) {
    reference.remove( 'issue' );
    reference.add( {name: 'number', value: item.issue} );
  }
}

and some variations thereof, but could not get it to work.  Could you please help?

close, but has lives on the reference being built, not the source item:
if (Translator.BetterTeX) {
  if (item.itemType == 'journalArticle' && reference.has.issue) {
    reference.remove( 'issue' );
    reference.add( {name: 'number', value: item.issue} );
  }
}

That works.  I was sure I had tried that, but apparently I was wrong...
Thanks a lot!  For your help here and in general for this project.  :)

You're very welcome.


fix: grafana dashboard

Description

Re-enable Grafana dashboard. Previously disabled presumably due to alert quotas
Disable type=raw tagging policy. Based on my research it seems to me that this causes the latest tag to not be published. But only one way to find out.
Docs & other improvements for deploying Terraform locally, comments

Resolves #30
How Has This Been Tested?
Deploying Grafana dashboard tested locally. Otherwise not tested
Due Diligence

[ ] Breaking change
[ ] Requires a documentation update
[ ] Requires a e2e/integration test update

Before merging: Must delete cast server alerts to make room for notify server alerts.


⚠ Bofrost.at has degraded performance

In 4e568c8, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1896 ms

Resolved: Bofrost.at performance has improved in 9860b88.


Add maintenance note

I wanted to call out the ownership of metalsmith more broadly going forwards!

Coverage remained the same at 96.875% when pulling 503ab77541074e05ea6a41c0600bb7e339810566 on f2prateek-patch-1 into 8eacefcc58c00dd3a17e30184302b414e7cb14e2 on master.

In that case, would it make sense to move the repo back to the metalsmith org? That might help communicate the project's status implicitly.


Timeout

After npm test
I get this
test://"before all" hook in "{root}"

Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

We need more information to diagnose this. Which tests are you running? What setup did you do before running the tests?

Firestore emulator https://github.com/firebase/quickstart-nodejs/tree/master/firestore-emulator/javascript-quickstart
I changed the port back to 8080 and the error disappears but a new one appears:

app.firestore is not a function

I have firebase-admin 8.2.0 and  "@firebase/testing": "^0.11.5", installed

I modified the javascript-quickstart's package.json to look like
{
  "name": "cloud-firestore-emulator-javascript-quickstart",
  "version": "1.0.2",
  "description": "Cloud Firestore emulator testing",
  "scripts": {
    "format": "prettier --write **/*.js",
    "test": "mocha"
  },
  "devDependencies": {
    "@firebase/testing": "0.11.5",
    "firebase-admin": "8.2.0",
    "mocha": "5.2.0",
    "prettier": "1.15.2"
  }
}

and ran rm -rf node_modules/ && npm install && npm test. Would you mind trying to the same and telling me what happens?

Just wanted to say, I had the same issue, tried using this.timeout(10000);, didn't work. I solved it by changing the timeout in the script using the --timeout 10000 option. Final package.json looked something like this:
{
  "name": "cloud-firestore-emulator-javascript-quickstart",
  "version": "1.0.0",
  "description": "Cloud Firestore emulator testing",
  "scripts": {
    "format": "prettier --write **/*.js",
    "test": "mocha --timeout 10000"
  },
  "devDependencies": {
    "@firebase/testing": "0.11.8",
    "filesystem": "1.0.1",
    "mocha": "5.2.0",
    "prettier": "1.15.2"
  }
}

Gotcha, these tests can definitely be slow depending on your hardware. I'll add the --timeout flag to the quickstarts.

Make sure you have two terminals:

One running firebase emulators:start
A second one where you run npm test


Toggle buttons for clipplane and wireframe do not toggle in JupyterLite

We could decide to make the clipping toolbar icon should appear as toggled when clipping is enabled.

This was implemented in https://github.com/jupytercad/JupyterCAD/pull/441 and it looks like it's not working anymore?

I wonder if the switch to reactive toolbar may broke it https://github.com/jupytercad/JupyterCAD/pull/455

Hi there, I tried reproducing this on my end and It works fine for me (I'm at the latest commit)
Maybe can you try reproducing?
https://github.com/user-attachments/assets/bb4ed69e-fb0f-4b4c-b00c-7eb8939041fb

Maybe @brichet would know if the reactive toolbar does not support toggled buttons.

AFAIK the reactive toolbar handles the buttons in the same way as the regular toolbar, storing only those that overflow into a popup toolbar.

EDIT: Yes, I just realised and checked that it's not working on jupyterlite deployment

Indeed. Although I can see the class change on the button.

So this may be JupyterLite not bringing the Lumino CSS for lm-mod-toggled!

So this may be JupyterLite not bringing the Lumino CSS for lm-mod-toggled!

Ping @jtpio

hmm strange that JupyterLite would not include this rule, since it should include the Lumino CSS by default.
Are you able to check the rule is available when using regular JupyterLab, and not with JupyterLite? (for example via the elements tab of the dev tools)

Are you able to check the rule is available when using regular JupyterLab, and not with JupyterLite? (for example via the elements tab of the dev tools)

Hi @jtpio, yes this is available on regular JupyterLab, this clip is of JupyterLab running locally.

I mean can you point at the specific CSS rule? (so it's easier to check why it would be missing in lite)

It should be lm-mod-toggled
https://github.com/user-attachments/assets/9843fdac-193d-474c-9512-f628a9992025

For the class yes. But what is the expected CSS rule?

This is the only rule we could find in lumino -
https://github.com/jupyterlab/lumino/blob/10ee22d2a93ae618f36c5ba380337bc440106399/packages/default-theme/style/menu.css#L75-L77

I cannot see this exact rule but there are significant differences between how lab is rendering the button and how lite is. One of the major one is that in jupyterlab button is jp-button but in jupyterlite it's only button and i also cannot notice styles being modified in lite
JupyterLab
https://github.com/user-attachments/assets/ec2b2c08-0ddf-4ba9-b892-34a65172e35c
JupyterLite
https://github.com/user-attachments/assets/f64e5b47-4eb7-4db1-b1fe-578ea6959920

I cannot see this exact rule but there are significant differences between how lab is rendering the button and how lite is.

Even by searching for lm-mod-toggled on the "Elements" tab? Probably there should then be some references to it in the <style> elements.

I cannot see this exact rule but there are significant differences between how lab is rendering the button and how lite is.

Even by searching for lm-mod-toggled on the "Elements" tab? Probably there should then be some references to it in the <style> elements.

Can't find one in local jupyterlab:
https://github.com/user-attachments/assets/6f8f22ac-dba2-4493-96fc-95a5b0df108a
But in jupyterlite, is this it? -

One of the major one is that in jupyterlab button is jp-button but in jupyterlite it's only button

Indeed. It looks related to the changes in JupyterLab w.r.t the toolbar buttons. Maybe there is a @jupyterlab package in JupyterLite that was not updated to the latest version?

Will the "bug" be resolved in a future version of JupyterLite ?
The CSS change could be submitted upstream in Lab.

Will the "bug" be resolved in a future version of JupyterLite ?

From a conversation with @martinRenou on video, Yes

The CSS change could be submitted upstream in Lab.

Sounds good, happy to do that if I'm good to do that, please let know if someone else shall do it.

Following up on this: is there anything to be done in JupyterLab? In JupyterLite? Is there an issue in these repos?

Following up on this: is there anything to be done in JupyterLab? In JupyterLite? Is there an issue in these repos?

From that thread, two issues are have been raised:

The CSS for the toggle buttons could be improved in JupyterLab
In JupyterLite, we are missing some CSS either from JupyterLab or Lumino for lm-mod-toggled

It looks like the rule that is being used for that toggle button is:

It is nowhere to be found though!!! This "constructed" thingy leads to nothing in my dev tools, and I can't find any reference to this variable in JupyterLab or Lumino. I can only find that this CSS variable comes from microsoft/fast.

I'm removing this issue from the 3.0.0 milestone for JupyterCAD.
How about we introduce a new CSS rule in JupyterLab for this, that implements what I suggested in https://github.com/jupytercad/JupyterCAD/issues/488#issuecomment-2431174872, then JupyterLite will get this for free upon update at some point.

Out of nowhere, it seems to be working now...


 not accepted: SCHEMA_VALIDATION_FAILED: /States/Create an EMR cluster/Resource is invalid. must match exactly one schema in oneOf

Describe the bug
The json below is from the AWS docs. The error message reads:
✕ State machine definition "path/to/file/example-state-machine-code.asl.json" is invalid:
SCHEMA_VALIDATION_FAILED: /States/Create an EMR cluster/Resource is invalid. must match exactly one schema in oneOf
To Reproduce
Please provide a complete state machine definition:
{
  "Comment": "An example of the Amazon States Language for running jobs on Amazon EMR",
  "StartAt": "Create an EMR cluster",
  "States": {
    "Create an EMR cluster": {
      "Type": "Task",
      "Resource": "arn:<PARTITION>:states:::elasticmapreduce:createCluster.sync",
      "Parameters": {
        "Name": "ExampleCluster",
        "VisibleToAllUsers": true,
        "ReleaseLabel": "emr-5.26.0",
        "Applications": [
          { "Name": "Hive" }
        ],
        "ServiceRole": "<EMR_SERVICE_ROLE>",
        "JobFlowRole": "<EMR_EC2_INSTANCE_PROFILE>",
        "LogUri": "s3://<EMR_LOG_S3_BUCKET>/logs/",
        "Instances": {
          "KeepJobFlowAliveWhenNoSteps": true,
          "InstanceFleets": [
            {
              "Name": "MyMasterFleet",
              "InstanceFleetType": "MASTER",
              "TargetOnDemandCapacity": 1,
              "InstanceTypeConfigs": [
                {
                  "InstanceType": "m5.xlarge"
                }
              ]
            },
            {
              "Name": "MyCoreFleet",
              "InstanceFleetType": "CORE",
              "TargetOnDemandCapacity": 1,
              "InstanceTypeConfigs": [
                {
                  "InstanceType": "m5.xlarge"
                }
              ]
            }
          ]
        }
      },
      "ResultPath": "$.cluster",
      "Next": "Run first step"
    },
    "Run first step": {
      "Type": "Task",
      "Resource": "arn:<PARTITION>:states:::elasticmapreduce:addStep.sync",
      "Parameters": {
        "ClusterId.$": "$.cluster.ClusterId",
        "Step": {
          "Name": "My first EMR step",
          "ActionOnFailure": "CONTINUE",
          "HadoopJarStep": {
            "Jar": "command-runner.jar",
            "Args": ["<COMMAND_ARGUMENTS>"]
          }
        }
      },
      "Retry" : [
        {
          "ErrorEquals": [ "States.ALL" ],
          "IntervalSeconds": 1,
          "MaxAttempts": 3,
          "BackoffRate": 2.0
        }
      ],
      "ResultPath": "$.firstStep",
      "Next": "Run second step"
    },
    "Run second step": {
      "Type": "Task",
      "Resource": "arn:<PARTITION>:states:::elasticmapreduce:addStep.sync",
      "Parameters": {
        "ClusterId.$": "$.cluster.ClusterId",
        "Step": {
          "Name": "My second EMR step",
          "ActionOnFailure": "CONTINUE",
          "HadoopJarStep": {
            "Jar": "command-runner.jar",
            "Args": ["<COMMAND_ARGUMENTS>"]
          }
        }
      },
      "Retry" : [
        {
          "ErrorEquals": [ "States.ALL" ],
          "IntervalSeconds": 1,
          "MaxAttempts": 3,
          "BackoffRate": 2.0
        }
      ],
      "ResultPath": "$.secondStep",
      "Next": "Terminate Cluster"
    },
    "Terminate Cluster": {
      "Type": "Task",
      "Resource": "arn:<PARTITION>:states:::elasticmapreduce:terminateCluster",
      "Parameters": {
        "ClusterId.$": "$.cluster.ClusterId"
      },
      "End": true
    }
  }
}

Expected behavior
A clear and concise description of what you expected to happen.
It should be valid.
Version:
Can be found by running asl-validator --version.
"asl-validator": "^3.8.2",
Additional context
Add any other context about the problem here.

@remy90 I don't think AWS is expecting you to use this ASL source as is. The value for the Task's ARN is intended to be replaced with a valid ARN.
For example, the value for PARTITION should be one of:

aws
aws-cn
aws-us-gov

Looking closer, I think you're right.
I've just inherited a code base that is using a step function with this  in production and its been there for ~3 years!
I'm still new to the repo I'm looking at (and step functions in general) but yes, I think this can be closed.


couple redundant semicolons that fails the build with g++10 and pedantic flag

https://github.com/CESNET/libyang-cpp/blob/master/src/Collection.cpp#L173
and
https://github.com/CESNET/libyang-cpp/blob/master/src/Collection.cpp#L258

Done, thanks!


yarn build && yarn package

Current dependencies on/for this PR:

main

PR #1783   👈

This comment was auto-generated by Graphite.


The scope of this repo is far beyond than it can be imagined

This is an amazing repo, I got so exited to see this. Because I have been thinking about similar ideas lately. I took a quick look into the repo, and it seems like the main aim (for now) is to support scikit learn datasets and make it some how fused with gpt prompts and make gpt models to do the work. But I think we there are more scopes to do just this.
Since scikit learn has been a huge ecosystem for ML and it is mostly used (till now and will be) by most of the organizations. When it comes to tabular data (100M row +) I do not think scikit LLM can work. But till now there are several real world problems that has this kind of tabular data with different varying patterns. And those kind of problems might not be solved with 'just' LLM.
Also at least with scikit learn models are much more LESS black box then these models are and hence easily interpretable where as these black box are far less interpretable and we might not be able to proof locally that why our models is generating this behavior for some data. Also these models are not deterministic, just change one small part of the input and the whole black box can turn into a different direction.
However, think of like this. Let's think in terms of BFF (Backend for Frontend) design, approach instead making GPT as the backend of computation, make it the front end part of the computation. Provide the dataset link, give it the 'sample dataset', provide the problem statement, give the meta data and using
langchain like tools, and existing awesome ecosystem of scikit learn, we can tell these models to do the computation on bare scikit learn and then come up with the predictions and even for example, if something is showing an anomaly in terms of behaviour, we can use explainable ai like LIME/SHAFT and use GPT in the top of these and may be generate awesome interpretable reports with these local 'fit' curves / graphs. In this way we can automate lot of process, keeping the reliability factor in check.
And then this can be used and 'deployed' in real world systems because the heavy lifting is still done by scikit learn, but with a front end of gpt. It then all boils down to fitting the right information and right instructions into right place to provide the results we want.
Some examples.
I provide a dataset link, the statement, metadata, it makes the ml model stores some where and provides the training report for each stage of ML training.
Then if I just provide a new data like, I have an user (not present in training data) with these 'unseen' feature what will be the prediction for that user. On the backend it might run prediction pipeline and then we can provide lot of follow ups like

why you predicted this
What if the input was this and how the output would have changed

Even systems which use real time ML can also incorporate, because real time ML is highly dependent on interpretable and light weight models as Speed and reliability both are indepedent. Using gpt as a query engine interface on top of it can be used for enhanced telemetry or something else, like automatically generating the use behavior from data drift or something else. All we might have to query with natural language.
In that way we are not using huge amount of tokens, can provide lesser black box results and also an use case of safe and less hallucinating AI. Please provide me your thought in general, I know this description got really big, but let me know, I am always up to discuss more on this, if my thought is aligned with yours.
Thanks

Hi @Anindyadeep
Thank you for your suggestion. It looks very interesting, but I have to admit this goes well beyond the scope of scikit-llm. First of all, scikit-llm does not (and is not meant to) support arbitrary tabular datasets. Instead we are mainly focusing on text classification/transformation.
From your description it seems like you’re suggesting something more similar to scikit-learn version of pandas-ai. We had some thoughts in this direction, but discarded them for 2 reasons: 1) as already mentioned, this goes beyond the scope; 2) these kinds of pipeline are more prone to failures and much more difficult to maintain, especially when the APIs of the libraries change and the LLM is unaware of the changes.  For example, this is the primary reason pandas-ai is unable to support pandas>=2.0.0 for now.
In general, we are open to the idea of extending the scope of scikit-llm, but maybe there are other more suitable places for implementing such a functionality. In addition to scikit-llm we have 2 other projects:

Falcon AutoML: this was meant as a general ML library that automates the pipeline from data ingestion to producing a production-ready model in ONNX format. Falcon can be extended with both custom training pipelines (e.g. LLM guided pipeline) as well as custom integrations (e.g. LLM based explainability tool).  I have to admit that we did not have sufficient amount of time to work on this library, so for now only a skeleton with the most basic functionality is implemented, but we have lots of updates planned (hopefully before Christmas). Overall, the scope of the library is virtually unrestricted.
AgentDingo: an extremely small library for building GPT based agents. We are not planning to add too many things to the “core” as we want to keep it both minimalistic and unopinionated. However, we can still add lots of extra functionality in addition to the core submodule.

Hence, I think for the functionality you are describing it might make sense to leverage the other libraries a bit more while not changing the original scope of scikit-llm too much. Also, if we decide to implement something in this direction, I would not want to let the LLM generate any code for direct execution (both for the reasons mentioned in the second paragraph and potential security threats if the library is not used locally but let’s say integrated into a web app), but rather come up with some more abstract grammar that could be used, which is a challenging task on its own.
As this might be relevant beyond scikit-llm, I suggest to continue further discussions of this topic in discord.

Ahh yes, Now I get it. However still I would be interested to contribute here and would like to talk more about the same in discord. Thanks


Flame - loading multilayer with controlled layer names

Brief description
Layers can be renamed dynamically during loading to batch
Description
Folowing settings were created for layer template and layer rename patterns:

project_settings/flame/load/LoadClipBatch/layer_rename_template
project_settings/flame/load/LoadClipBatch/layer_rename_patterns

Regular expression patterns could be used for detecting name patterns in loaded layers and if any match is found, then the layer is renamed to use of version context data and additional formatting keys found if the context of loading file and its layer. For example layer with name rgba and layer uid BEAUTY:MasterBeauty can be now renamed with template {asset}_{subset} [{layerUID}] to new name shot01_renderMain [BEAUTY:MasterBeauty].

This had been requested by a client who is using Flame for metadata slates. The metadata key layer will now show more than just rgba.

Ready for merge ;)


[MM-38430] - Onboarding invite shows limits that no longer apply

Summary
This PR updates the invitation card subtitle in the onboarding to show correct text depending on whether the cloud subscription is paid or not
Ticket Link
MM-38430
Release Note
NONE

Looks good @AGMETEOR!

@stevemudie we also need to check other places where these limitations were occurring like the invitation modals (members and guests)

@AGMETEOR

@stevemudie we also need to check other places where these limitations were occurring like the invitation modals (members and guests)

Yeah, sorry I didn't describe what I'd tested in more words but yes, new members see the same (new/revised text) as expected. Guest members don't have the invite onboarding step of course but I checked to see to make certain and it's all good.

Hello @stevemudie going to ask for another QA review because the code has changed significantly

/cherry-pick release-6.0

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-webapp
   27afa1780..47710d196  MM-37187_2-pluggable-to-ts -> upstream/MM-37187_2-pluggable-to-ts
 * [new branch]          MM-37971_separate-last-post-at -> upstream/MM-37971_separate-last-post-at
 * [new branch]          bugfix/MM-38850_remove-suggestionlist-dividers -> upstream/bugfix/MM-38850_remove-suggestionlist-dividers
   966ae163f..4603c37e4  clean-up/MM-38227_apply-styles -> upstream/clean-up/MM-38227_apply-styles
 * [new branch]          clean-up/MM-38350_folder-structure -> upstream/clean-up/MM-38350_folder-structure
   a7537cda7..c779ce345  master      -> upstream/master
   b32c928d4..bac8947ec  release-6.0 -> upstream/release-6.0
Fetching origin
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-webapp-#8944-upstream-release-6.0-1632840419
Switched to a new branch 'automated-cherry-pick-of-mattermost-webapp-#8944-upstream-release-6.0-1632840419'
Branch 'automated-cherry-pick-of-mattermost-webapp-#8944-upstream-release-6.0-1632840419' set up to track remote branch 'release-6.0' from 'upstream'.

+++ About to attempt cherry pick of PR #8944 with merge commit 4bad07c5cf6a0cc6bbe021d0b8f9b5e1182ec23d.

error: could not apply 4bad07c5c... [MM-38430] - Onboarding invite shows limits that no longer apply (#8944)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

+++ Conflicts detected:

UU components/next_steps_view/steps/invite_members_step/invite_members_step.tsx
Aborting.

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.

@marianunez Ticket has 6.0 milestone. Just wanted to double-check whether this needs cherry-picking.

@marianunez Ticket has 6.0 milestone. Just wanted to double-check whether this needs cherry-picking.

Yes, this needs to be cherrypicked but left a comment above of something that still needs to be fixed to be complete for 6.0

/cherry-pick release-6.0

Cherry pick is scheduled.


validation stops working if I overwrite onBlur for Field

I have a Field that needs some custom onBlur functionality, but when I implement my functionality, the normal sync validation stops working. I can still see the error getting updated within props.meta.error when I console log with componentDidUpdate, but it doesn't actually show the error.
I've tried tinkering with manually dispatching a 'touch' action, and trying asyncValidation too, but the error field doesn't show up unless I leave the onBlur prop alone.
Is there a way I can implement my own onBlur function, while still retaining the original error validation stuff?
This is the component I'm making:
class PostalCodeTextInput extends React.Component { // eslint-disable-line
  fetchAddressesValid = () => {
    // this.props.async();
    if (this.props.input.value.length > 5) {
      if (!this.props.meta.error) {
        this.props.fetchAddresses(this.props.input.value);
      }
    }
  }

  render() {
    const { helpText, input, label, type, meta: { touched, error } } = this.props;
    const classNames = classnames({
      'text-input': 'text-input',
      'form-group': 'form-group',
      invalid: touched && error,
    });
    return (

        {label}

          <input
            {...input}
            type={type}
            placeholder={label}
            onBlur={this.fetchAddressesValid} // *
          />
          {touched && error &&
{error}
}

        {helpText}

    );
  }
}

And this is the validation that's supposed to apply:
const validate = (values) => { // eslint-disable-line
  const errors = {};

  // NewAddressFields
  if (!values.get('postal_code')) {
    errors.postal_code = 'Required';
  }

and the link to the stackoverflow question with pictures:
http://stackoverflow.com/questions/40535105/how-to-keep-sync-validation-with-redux-form-v6-while-implementing-custom-onblur

You shouldn't overwrite onBlur without enabling redux-form onBlur functionality. Can you please try this:
onBlur={(e) => {
  input.onBlur(e);
  this.fetchAddressesValid();
}}

This way you are still doing what you want onBlur, but you are also enabling redux-form onBlur action at the same time. I suppose this should fix the issue for you. Enhancement should happen in the future:
https://github.com/erikras/redux-form/issues/883
Another thing to note, sometimes you will need to do this:
onBlur={(e) => {
  input.onBlur(e);
  setTimeout(() => this.fetchAddressesValid());
}}

If you don't call your function with timeut than you will have props from last tick instead of fresh new values from last change.

Thanks for solving this month long struggle.


Customize env variables parsing

I have some env variables that are not valid json. For example my_env_var=foo,bar,baz. And I want to load them in pydantic nested settings object like:
class MyObject(BaseSettings):
    foo: str
    bar: str
    baz: str

class Settings(BaseSettings):
    my_env_car: MyObject = {'foo': 'default', 'bar': 'default', 'baz': 'default'}
    # other settings...

I found out, that some kind of solution is implemented, but in original pydantic's old version(https://github.com/pydantic/pydantic/commit/fe7c9da6c19d602907aa236bec3cde86495c8c18#diff-92b745c29e70744f83f362314799e81846825caa126a47263f243a754f61fce9R3).
It would be good if we could have this kind of possibility in pydantic_settings too. And solution in original pydantic kinda good. But i would like to have a whole field object in parse_env_var function rather than just field_name, so it could be something like:
class Settings(BaseSettings):
    my_env_var: MyObject = Field({'foo': 'default', 'bar': 'default', 'baz': 'default'}, is_comma_separated=True)

    class Config:
        @classmethod
        def parse_env_var(cls, field: FieldInfo, raw_val: str) -> Any:
            if field.extra.get('is_comma_separated'):
                return {val: str(len(val)) for val in raw_val.split(',')}
            return super().parse_env_var(field, raw_val)

Is this issue is viable or is there are a workaround that I couldn't find?

NVM. Found solution in https://docs.pydantic.dev/latest/concepts/pydantic_settings/#parsing-environment-variable-values


[common] Add support for ClientSocket on Linux

Uses the abstractions written for ServerSocket in ClientSocket, so that it builds on Linux. Also adds a method to poll for connections and uses that in cdc_rsync. Similar code will be used in cdc_fuse_fs to wait for a connection in a future CL.

Hey Florian, PTAL. Absolutely no rush.


Add --no-header to the project settings (based on: #79179)

this pull request is based on : #79179
it just adds the parameter to enable or disable --no-header in : application/run/quit_header

What's the reason of this PR? It's mostly the same code as the other one, why not suggest these additions in that PR?

You're right, I didn't think of that just now.

Sorry this didn't end up working out, hope to see your contributions elsewhere!

@AThousandShips I can't do a review in a file that hasn't been modified - example (Project_Settings.cpp)

Review of what?

the code review for pull request #79179

I would suggest just adding your own code for the project settings and not building on top of any other PR, there's no code you depend on there

the code review for pull request #79179

Just add a normal comment

ok I think I'll do that or else I'll wait for the pull request (#79179) to be merged

in case I keep the branch in my fork


Following getting started steps to make a Blazor app silently fails if .NET Core 3 did not install or is not being used

Describe the bug
I followed the get started steps here to use Blazor with VS2019 preview and NET Core:
https://docs.microsoft.com/en-us/aspnet/core/blazor/get-started?view=aspnetcore-3.0&tabs=visual-studio
Installed SDK, Installed VS2019 Preview, Installed Extension, then made an app using the template.
It fails:
1>c:\program files\dotnet\sdk\2.2.400-preview-010219\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(143,5): message NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview
1>Startup.cs(14,30,14,33): error CS0246: The type or namespace name 'App' could not be found (are you missing a using directive or an assembly reference?)
1>Done building project "WebApplication1.csproj" -- FAILED.

I eventually realized that .NET Core 3's SDK install had failed or I had accidentally installed the wrong SDK (I don't know which). I manually installed the 3.x SDK as suggested by the instructions and then the project began building successfully.
Expected behavior
Diagnostic messages to indicate why the build failed or that a dependency needed by the template is missing.
Screenshots

Additional context
**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.2.0-pre.2.0
** Copyright (c) 2019 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'

E:\Visual Studio 2019>dotnet --info
.NET Core SDK (reflecting any global.json):
 Version:   2.2.400-preview-010219
 Commit:    532dec6f1c

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.17763
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   c:\program files\dotnet\sdk\2.2.400-preview-010219\

Host (useful for support):
  Version: 2.2.5
  Commit:  0a3c9209c0

.NET Core SDKs installed:
  1.0.3 [C:\Program Files\dotnet\sdk]
  1.0.3 [c:\program files\dotnet\sdk]
  1.0.4 [C:\Program Files\dotnet\sdk]
  1.0.4 [c:\program files\dotnet\sdk]
  1.1.0 [C:\Program Files\dotnet\sdk]
  1.1.0 [c:\program files\dotnet\sdk]
  2.1.3 [C:\Program Files\dotnet\sdk]
  2.1.3 [c:\program files\dotnet\sdk]
  2.1.4 [C:\Program Files\dotnet\sdk]
  2.1.4 [c:\program files\dotnet\sdk]
  2.1.200-preview-007474 [C:\Program Files\dotnet\sdk]
  2.1.200-preview-007474 [c:\program files\dotnet\sdk]
  2.1.201 [C:\Program Files\dotnet\sdk]
  2.1.201 [c:\program files\dotnet\sdk]
  2.1.300-preview2-008324 [C:\Program Files\dotnet\sdk]
  2.1.300-preview2-008324 [c:\program files\dotnet\sdk]
  2.1.401 [C:\Program Files\dotnet\sdk]
  2.1.401 [c:\program files\dotnet\sdk]
  2.1.507 [C:\Program Files\dotnet\sdk]
  2.1.507 [c:\program files\dotnet\sdk]
  2.1.800-preview-009696 [C:\Program Files\dotnet\sdk]
  2.1.800-preview-009696 [c:\program files\dotnet\sdk]
  2.2.400-preview-010219 [C:\Program Files\dotnet\sdk]
  2.2.400-preview-010219 [c:\program files\dotnet\sdk]

Thanks for contacting us, @kg.
Down-level SDKs don't have knowledge about what's available in the future versions, so the exception you're getting about an unknown type is actually valid.
There is nothing we plan to do in this area.

Just to be clear, there's no way for the extension to sense missing dependencies or for the template to sense missing dependencies?


Generates Error in a List View

This seems to generate an error when I place it in a Column.  When wrapped in an Expanded, the error goes away.  However, then when I try to put several in a ListView, this error pops up again:
"The following assertion was thrown during performResize():
"Vertical viewport was given unbounded height.
"Viewports expand in the scrolling direction to fill their container.In this case, a vertical
viewport was given an unlimited amount of vertical space in which to expand. This situation
typically happens when a scrollable widget is nested inside another scrollable widget."
I also tried wrapping it in a sized box, but that didn't help.  I'm new at this, so perhaps I'm not understanding the right way to constrain it?  Looking through the code, and the way it looks, it appears that the animation goes outside the bounds of the image (because of the 3D affect, I assume).  Is this part of the issue?
Here's part of the code.  I extracted the instance into a new widget so I could easily put a bunch of these in a ListView:
Widget build(BuildContext context) {
return SizedBox(height: 300,
child: Expanded(
child: FlipCard(
direction: FlipDirection.HORIZONTAL,
flipOnTouch: true,
front: Container(
padding: EdgeInsets.all(10),
decoration: BoxDecoration(
color: Colors.white,
image: DecorationImage(image: AssetImage(frontURI))),
),
back: Container(
padding: EdgeInsets.all(10),
decoration: BoxDecoration(
color: Colors.blue,
image: DecorationImage(image: AssetImage(rearURI))),
),
),
),
);
}

@skaterdude  Thanks for your feedback.
I am not able to guess the reason.
Could you simply replace the flip_card with AssetImage to see if it works well?
If do, could you pls post whole code?

I found the problem after a LOT of reading about rendering.  It's this statement:
fit: StackFit.expand,
which tries to make it as big as possible.  When I change it to:
fit: StackFit.passthrough,
the error goes away.  So I guess it depends upon the context where you're using it.
Hope that helps!

@skaterdude  Thanks a lot.
Can I close it now?

Sure, if you've checked my proposed solution and updated / tested the code.  Or, alternatively, if you don't think the solution is generally applicable.


Migrate sampler to otel package

So this really does two things.

It attempts to address the TODO in the RumInitializer about the lazy init of a static/mutable variable. It does this by leveraging the fact that the session ID is also in the attributes passed to the shouldSample() method. One downside is that we currently rely on "splunk" in that name and so there's still splunk leakage in the otel package (this just moves things around however). We will need to figure this out -- especially because the name the sampler uses will need to match the name the SessionIdSpanAppender uses.
It moves the sampler out of the splunk package and into the otel package.

It does this by leveraging the fact that the session ID is also in the attributes passed to the shouldSample() method.

Is it, really? Session id is appended in a SpanProcessor, which runs after the Sampler.

One downside is that we currently rely on "splunk" in that name and so there's still splunk leakage in the otel package (this just moves things around however). We will need to figure this out -- especially because the name the sampler uses will need to match the name the SessionIdSpanAppender uses.

I suppose we could use the SplunkSpanDataModifier to rename the attribute just before the span is exported.

It does this by leveraging the fact that the session ID is also in the attributes passed to the shouldSample() method.

Is it, really? Session id is appended in a SpanProcessor, which runs after the Sampler.

Ugh, you're right. My testing was invalid because I hadn't actually set the config setting that enables the sampler (it's off by default).
Time to regroup.


07/05/2018 19:09 : Create Pull Request for branch prTesting_2018070519 -> master

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update Relevant Projects Section

Describe the enhancement
Update the content in the Relevant Projects section.
Tasks

[ ] Updated the content of the Book Search project
[ ] Updated the content of the Notebook project

git fetch origin
git checkout 104-update-relevant-projects-section


ARTEMIS-698 Remove full path + executability check of java

Fixes issues with systems that have no "which", as well as the fallback
to using plain "java" from PATH.
This is an alternative fix to #732, see discussion in it for more details.

@scop  I think you should close this PR, and squash this commit into #732
if you squash it and push -f the PR will be updated.

Done.


refactoring and restructuring

I restructured everything so it is a little bit more streamline and formatted the code so it looks more consistent
Basically not much changed in functionality. Things I changed are:

update and removed some dependencies
added some minor optimisations to chat (Server messages are not linked to the player view)
a simple loading wheel will be displayed before angular is initialised

@garrynewman is there something wrong with this PR?

It's a shame this never got merged...


Nick: Watch bluehackangels407

Nick requests the watch of the watch_keyword bluehackangels407. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

bluehackangels407 has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Rejected by Makyen in Charcoal HQ. Reason: 'Chose to use a regex which included a partially obfuscated version of the gmail domain.'

Approved by Makyen in Charcoal HQ


Document behavior when specified SDK version in global.json is not available

What happens if the specified SDK version in global.json is not found? Will it use a newer version if available? Is it an error if the specified version is not found?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a94c335b-0b65-96cc-1c25-65777fbe4bb5
Version Independent ID: 6d80613f-42dc-35d7-aeff-3187a36dbbca
Content: global.json reference
Content Source: docs/core/tools/global-json.md
Service: unspecified
Product: dotnet-core
GitHub Login: @blackdwarf
Microsoft Alias: mairaw

Thanks @danroth27. This is being addressed by PR #4704 that I hope to merge this week. Let me know if that doesn’t answer the question.

We now have docs for this in the global.json reference that I just reviewed. I think we should move it here.


[BUG] Bloxstrap isnt Installing after restarting or waiting for it to get fixed

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[ ] I did not answer truthfully to all the above checkboxes.

Bloxstrap Version
v2.8.1
What problem did you encounter?
Bloxstrap isnt installing even restarting and waiting to get fixed. I uninstalled Bloxstrap and tried reinstalling but it still didnt work the same error but with a different hash kept showing up. I even tried using administrator and it still didnt work.. I dont know what else to try! I went through appdata to delete all Bloxstrap files and still the same error with a differnt hash code.
What i see when its installing;
Installing for a few or less than a second then starts to install again after that point (see image) an error message comes up.

Bloxstrap Log
Bloxstrap.Exceptions.ChecksumFailedException: Failed to verify download of http://setup.rbxcdn.com/version-8aa36bbf0eb1494a-RobloxApp.zip

Expected hash: 49f61f3a1dd6b51e7919f5bfccbad9f1
Got hash: 04a825d3a9fa83d380eddb095db31cdf

Please read the wiki about this.


Add support for single-level nesting through companion objects

Problem
The fix for "case classes nested one level inside of objects" didn't work if that object was a companion object, since earlier code would "find" the companion object's class instead of the object itself.
Solution
If we're trying to find an case-class-in-object, don't attempt to use the object's companion class.
Result
This now works for a single level of nesting through companion objects.
However, i'm convinced that this case class code as a whole is extremely brittle and unlikely to work for any particular cases that aren't exactly captured by unit test scenarios.  It should probably be completely rewritten, and i'll probably take a whack at this larger problem at some point.

Thank you for the pull request. This was submitted internally, and pushed back out to the develop branch in commit https://github.com/twitter/finatra/commit/0215ed3b46561f7b4f540ba125eba9336e24fdb8

@ryanoneill this is a follow-up to the previous PR and this one still needs to be merged. I was hoping for a clean TravisCI build before attempting to merge internally.

Codecov Report

Merging #386 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #386   +/-   ##
========================================
  Coverage    94.57%   94.57%
========================================
  Files          219      219
  Lines         3206     3206
  Branches       252      252
========================================
  Hits          3032     3032
  Misses         174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd15d14...c7b327a. Read the comment docs.

Thanks @cacoco. My apologies for closing it @virusdave.

Merged in 24f25b7b8149b9d726ace176da11bf81d833d650


chore: use chunk data in NIAH and QA evals

Description

Adds chunk data to the NIAH and QA evaluations to better evaluate the retrieval stage of RAG
Adds chunk_rank metric to NIAH evals to evaluate how well ranked the chunks are
Adds 2 new LLM-as-judge metrics to QA evals: Contextual Relevancy and Faithfulness
Updates package versions
Fixes bug when not using padding data in NIAH evals

BREAKING CHANGES
NIAH Retrieval now measures slightly differently, meaning prior NIAH retrieval metrics should not be compared to these new values.
CHANGES
Replaces the current proxy annotation measure for NIAH retrievals with one based on the chunk data directly.
Related Issue
Relates to #1067
Checklist before merging

[ ] Tests, documentation, ADR added or updated as needed
[ ] Followed the Contributor Guide Steps

Evaluation results from most recent run using new metrics:
Final Results:
INFO:root:Average Needle in a Haystack (NIAH) Retrieval: 1.0
INFO:root:Average Needle in a Haystack (NIAH) Response: 1.0
INFO:root:Average Needle in a Haystack (NIAH) Chunk Rank: 0.9600000000000001
INFO:root:Average Correctness (GEval): 0.82
INFO:root:Average Answer Relevancy: 0.9583333333333335
INFO:root:Average Contextual Relevancy: 0.504
INFO:root:Average Faithfulness: 0.9278174603174603
INFO:root:Average Annotation Relevancy: 0.9359999999999999
INFO:root:MMLU: 0.696969696969697
INFO:root:HumanEval: 0.95
INFO:root:Eval Execution Runtime (seconds): 1655.2433378696442


support for atlas query, status update, OLM basics

@jianrongzhang89 going to go ahead and merge up so we can move forward with work we need to get through for the week, but an FYI this is out here if we want to have some convo on it.

@jeremyary is this runablle right now? Can I take look

@wtrocki It is! I've got it deployed and running on our lab, happy to show you there on a quick vid chat or google chat me and I can walk you thru make commands and what resource you'll need to create to trigger it if you'd like. The functionality is not fully there yet for creating the resource that we'll be "binding" against, though that's coming soon. Thus far, it's all about querying Atlas and getting instance info back to allow the admin to select from in a mock UI.

Thank you. Will check code and we can have some Dev sync later


Drop pointer on request id fields

What changed?
Drop pointer for request id fields within internal types.

Why?
This is one of PRs planned to drop pointers for always required fields in internal types. It will make them more idiomatic and easier to use. These pointer are legacy of Thrift types that were used previously through our codebase. This will also allow safer migration to grpc, as proto primitive types don't have nils by default.

How did you test it?
Passing build and existing tests.

Potential risks

Coverage decreased (-0.06%) to 61.613% when pulling 258579ac0494df394da3e3d1c9b277c0235b9175 on vytautas-karpavicius:drop-ptr-request-id into b32559a1a5f29859fc930458afca00a9a7d7e946 on uber:master.

Coverage decreased (-0.06%) to 61.613% when pulling 258579ac0494df394da3e3d1c9b277c0235b9175 on vytautas-karpavicius:drop-ptr-request-id into b32559a1a5f29859fc930458afca00a9a7d7e946 on uber:master.


Use microbundle instead of dts-bundle-generator

Did this simpler fix instead: https://github.com/micahjon/rhf-conditional-logic/pull/3
But might move to microbundle in the future since it would simplify some things...


@Part() doesn't generate MultipartFile

Describe the bug
I just update flutter to 43.0.1, retrofit to ^1.1.0+1 and retrofit_generator to ^1.1.0+1. It give me error when I run build_runner, because I have to use @Part() instead of @Field() to send File data type. But when I look to the generated file, the File is not generated to MultipartFile like when I used @Field() before updating version. The file is definitely not sent to the server.
To Reproduce
Steps to reproduce the behavior:

update flutter to 43.0.1, retrofit to ^1.1.0+1 and retrofit_generator to ^1.1.0+1
use @Part() instead of @Field() to send File data type

Screenshots
This is my method

@POST(defaultPath)
Future postDoNotWithImage(@Field() String title,
@Field() String reason,
@Field() String image,
@Part() File file,);

This is the generated method

@override
postDoNotWithImage(title, reason, image, file) async {
ArgumentError.checkNotNull(title, 'title');
ArgumentError.checkNotNull(reason, 'reason');
ArgumentError.checkNotNull(image, 'image');
ArgumentError.checkNotNull(file, 'file');
const _extra = <String, dynamic>{};
final queryParameters = <String, dynamic>{};
final _data = {'title': title, 'reason': reason, 'image': image};
final Response<Map<String, dynamic>> _result = await _dio.request('/donot',
queryParameters: queryParameters,
options: RequestOptions(
method: 'POST',
headers: <String, dynamic>{},
extra: _extra,
baseUrl: baseUrl),
data: _data);
final value = DoNotModel.fromJson(_result.data);
return Future.value(value);
}

Smartphone (please complete the following information):

Device: emulator
OS: Android API 21

Please DO not use both  @field and @Part at the same time.
@Field is not supported when content-type is multipart.
Replace all @Field with @@part

On Feb 3, 2020, at 2:42 PM, RakaAlrian<EMAIL_ADDRESS>wrote:
Describe the bug
I just update retrofit to ^1.1.0+1 and retrofit_generator to ^1.1.0+1. It give me error when I run build_runner, because I have to use @part https://github.com/part() instead of @field https://github.com/field() to send File data type. But when I look to the generated file, the File is not generated to MultipartFile like when I used @field https://github.com/field() before updating version. The file is definitely not sent to the server.
To Reproduce
Steps to reproduce the behavior:
update retrofit to ^1.1.0+1 and retrofit_generator to ^1.1.0+1
use @part https://github.com/part() instead of @field https://github.com/field() to send File data type
Screenshots
This is my method
@post https://github.com/post(defaultPath)
Future postDoNotWithImage(@field https://github.com/field() String title,
@field https://github.com/field() String reason,
@field https://github.com/field() String image,
@part https://github.com/part() File file,);
This is the generated method
@override https://github.com/override
postDoNotWithImage(title, reason, image, file) async {
ArgumentError.checkNotNull(title, 'title');
ArgumentError.checkNotNull(reason, 'reason');
ArgumentError.checkNotNull(image, 'image');
ArgumentError.checkNotNull(file, 'file');
const _extra = <String, dynamic>{};
final queryParameters = <String, dynamic>{};
final _data = {'title': title, 'reason': reason, 'image': image};
final Response<Map<String, dynamic>> _result = await _dio.request('/donot',
queryParameters: queryParameters,
options: RequestOptions(
method: 'POST',
headers: <String, dynamic>{},
extra: _extra,
baseUrl: baseUrl),
data: _data);
final value = DoNotModel.fromJson(_result.data);
return Future.value(value);
}
Smartphone (please complete the following information):
Device: emulator
OS: Android API 21
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/trevorwang/retrofit.dart/issues/105?email_source=notifications&email_token=AAA5Y3TYVC7LTTYG5K74OTTRA64G3A5CNFSM4KO72JVKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IKPZINQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA5Y3W555TKB627KDL2RI3RA64G3ANCNFSM4KO72JVA.

Ohh, my bad. Thanks :D


Can interrupt identity >63 cause a trap in non virtualized mode?

On page 61:

The RISC-V Privileged Architecture ensures that, when the value of mtopi is not zero, a trap is taken to M-mode for the interrupt indicated by fi eld IID if either the current privilege mode is M and mstatus.MIE is one, or the current privilege mode has less privilege than M-mode. The trap itself does not cause the value of mtopi to change.

The mtopi actually allows IID>63. But the Privilege spec says:

an interrupt traps to M-mode wheneverall of the following are true: (a) either the current privilege mode is M-mode and machine-level interrupts are enabled by the MIE bit of mstatus, or the current privilege mode has less privilege than M-mode; (b) matching bits in mip and mie are both one; and (c) if mideleg exists, the corresponding bit in mideleg is zero.

The mip and mie cannot be wider than 64, so why are they compliant?

The value of mtopi.IID can be greater than 63 only with another extension, which might be a custom extension or a future standard one.  By specifying field IID in mtopi as 12 bits wide, the AIA is pre-allocating space in mtopi for such an extension.  But the current AIA does no more, itself supporting only values up to 63.
An extension that allows for interrupt numbers > 63 will need to specify what is missing, including modifying the existing rules for when a trap is taken.
Today, the expectation is that only custom extensions might use interrupt numbers greater than 63.  But it's always possible that the RVIA may someday choose to ratify a new standard extension that does so.

@jhauser-us Understood. Thank you very much!


Documentation fixes

fixed broked at 1549110e5f2da2883893b153a3d3b451bdabc762 class.dd
used ++ and *= for array.length at array.dd
fixed Associative Array word count example at array.dd
changed In Out and Inout Parameters to In, Out and Ref Parameters at overview.dd
changed next to popFront etc. at statement.dd
changed incorrect cast at integer bit pattern section of type.dd
Following macros removed:
WEB (except phobos-like definition in intro-to-datetime.dd and glossary.dd)
EBOOK
WEBURL
Following macros added:
DDLINK - link to other *.dd file (other page on the site, other section in ebook)
DDSUBLINK - same as DDLINK, but references to subsection
DPLLINK - link to http://d-programming-language.org page (external link in ebook)
NOTEBOOK - hides its arguments in ebook

Also @WalterBright could add to his std.ddoc file two macros used in Phobos:
CXREF = $(D core.$1.$2)
LREF = $(D $1)
to solve D's local documentation navigation problems

Am I right that ulong  u4 = cast(ulong)-1; // ok, -1 can be represented in a ulong line hadn't caused a single improvement pull request before because that section (I mean about bit pattern) is completely obscure?

What are exactly the improvement brought about by this diff?

It fixes a lot of broken links without breaking ebook generation.

Thanks!


fixed styling on login and sign up page

Fixed the layout of both pages also works better with dark mode now

test the pages and let me know if anything should change


pytest-selfie: FS.assertFailed

This is FSJava as supplied by the junit5 runner
https://github.com/diffplug/selfie-python-wip/blob/e6c59053316e3492b3552a5dcf54c9ba598ee7e3/jvm/selfie-runner-junit5/src/main/kotlin/com/diffplug/selfie/junit5/SnapshotSystemJUnit5.kt#L57-L59
And this is FSOkio as supplied by the kotest runner
https://github.com/diffplug/selfie-python-wip/blob/e6c59053316e3492b3552a5dcf54c9ba598ee7e3/jvm/selfie-runner-kotest/src/commonMain/kotlin/com/diffplug/selfie/kotest/FSOkio.kt#L44-L63
The key thing to note here is that the exception has two cases:

expected and actual both null -> can be a regular AssertionError
should be an equals assertion:

unittest -> self.assertEqual(expected, actual, msg)
pytest -> assert expected == actual, msg

@Trickybrain this would be a good thing to work on too, we will need it soon


Allow invoking rule command with keywords rather than rule number

maybe link some keywords to rules.. like the rule-6 is related to advertising, so maybe we can just type !rule ad.

Would it be best to have this implemented on a keyword basis? Meaning that we have a list of particular keywords that map to a particular rule?
Or would it be better to use NLP here in order to try to identify the rule that a particular user is trying to mention, and then maybe give suggestions ?

Would it be best to have this implemented on a keyword basis? Meaning that we have a list of particular keywords that map to a particular rule?
Or would it be better to use NLP here in order to try to identify the rule that a particular user is trying to mention, and then maybe give suggestions ?

I think having keywords would be best, it should be simpler, as well as being more predictable and giving us more control.
With that we would need some way of discovering the keywords that work for each rule. We could include it in each rule invocation, or have a separate command that lists them.

IMO regardless of what we do, we should keep the ability to reference based on numbers, on top of whatever we do here.
The rule command has existed for quite a while that a lot of staff and regulars are very used to be able to invoke based on an index.
In terms of implementation, this is trivial, as we would just need to leave the greedy int convertor, and add an optional string param.

@ChrisLovering I don't think the point was to change the fundamentals of how the command works. Listing a rule by its number would remain the same.
What we're trying to do is to make it slightly easier for people who are unacquainted with the rule numbers to find them easily.
@wookie184 I definitely agree with you on that. Because we don't want it to get too clunky and get lost in finding keywords as well.
I'll try to spin up a draft PR for this and discuss implementation details there when needed.

One aspect that is lost here is that the current rules command is dynamic. The rules are fetched from the API. The suggested approach is probably ok, but will require hardcoding keywords, which will need to be changed/rearranged if the rules ever change. How much of an issue would be to take a keyword and check whether it appears only in a particular rule?

How much of an issue would it be to take a keyword and check whether it appears only in a particular rule? In terms of getting undesirable results

Not so much undesirable results, but it would stop us having stuff like !rule tos if the rule just contains "terms of service", or !rule advert if the rule contains advertisment.

The rules are fetched from the API

It shouldn't be too difficult to add the keywords on the site side and make them be fetched along with the rules.

Yeah that makes sense

@wookie184
I was thinking of how this would be implemented:

Do we keep this as 1 command only or do we have a group of commands? The "main" one would be using the rule number like usual & the other with a keyword.

If we decide to have one command, I suppose that we need to prioritize numbers on keywords, this leads to having a signature like this:  async def rules(self, ctx: Context, rules: Greedy[int], keyword: Optional[str]) -> None
--> If no number is provided, we will try to search for a keyword that might match the one provided

You said that "we would need some way of discovering the keywords that work for each rule. We could include it in each rule invocation, or have a separate command that lists them."
This would depend on how we would be mapping our keywords to the rules
a. One key words points to one rule --> Cluggy & messy.
b. Each rule keeps a collection (list, set) of keywords -> This would require a longer lookup time in case the list of keyword grows & our target keyword is the final one to search for.

Since I'm not familiar with our code base, what's the most suitable place (if there guidelines for this) to store this map ?

Do we keep this as 1 command only or do we have a group of commands?

It should remain as one command, here are examples of how I think it should work:
!rule -> Shows the general rule message as it did before.
!rule 1 -> Shows rule 1 as it did before
!rule 1 2 -> Shows rule 1 and 2 as it did before.
!rule coc -> Shows the rule with keyword "coc".
!rule 1 Look at this rule -> Only shows rule 1, i.e. ignore the text if a number was already given.
!rule a b c -> There are a bunch of ways this could be interpreted: A single rule with a multiple keyword invocation e.g. !rule code of conduct; multiple rules e.g. !rule tos coc advert; or one rule and ignored text, e.g. !rule coc Look at this. I don't mind which we go with.
I think you should be able to do this with the signature you posted above, depending on how the last case I showed is handled.

This would depend on how we would be mapping our keywords to the rules

I like option b in terms of how they're stored as it sounds a bit neater to keep the keywords with the rule's definition, how the lookup is done at runtime is up to you, there should be no issue with lookup speed whatever you do as there are only 9 rules.

what's the most suitable place (if there are guidelines for this) to store this map?

The rules are actually stored on the site project so the response there should be changed to include the keywords for each rule as well as the contents. This means you'll need 2 PRs, one to site and one to bot.
If you haven't found it already our contributing guide has information on how to set up the projects, feel free to ask on the server if you have any issues setting stuff up!

Awesome, that should be enough to get me started.
Thanks a lot, we'll continue the discussion in the PRs.

@wookie184
Here are the two PRs
https://github.com/python-discord/site/pull/770
https://github.com/python-discord/bot/pull/2261
I'd love to have some feedback !

@wookie184 I just remembered this and I was thinking about the discoverability of these keywords.
Should we include them in the the Embed's footer maybe ? Or attach them to each rule
Here's how it currently is

Here's how it could be attached

Let me know what you think

@wookie184 We forgot to close this.


Enforce documenting public APIs and stricter linting in Ethereum light client

As per: https://github.com/cosmos/ibc-go/pull/7603#discussion_r1859769892
We want to enforce proper documentation of public APIs in the Rust code as well as stricter linting in general like we do for the SP1 light client.
Make sure this is checked in CI as well.

Moved and superseded by https://github.com/cosmos/solidity-ibc-eureka/issues/146