Form Overrides not working

Hi, having an issue with a form where no overrides are working.
Please see the code below:

            {% macro errorList(errors) %}
                {% if errors %}
                    {{ ul(errors, {class: 'errors'}) }}
                {% endif %}
            {% endmacro %}

            {{ csrfInput() }}
            {{ actionInput('contact-form/send') }}

            <input type="hidden" name="message[formName]" value="supplierForm">
            <input type="hidden" name="message[template]" value="{{ 'supplier'|hash }}">
            <input type="hidden" name="message[subject]" value="{{ 'Your Submission to' ~ entry.title|hash }}">
            <input type="hidden" name="message[disableConfirmation]" value="true">
            <input type="hidden" name="toEmail" value="{{<EMAIL_ADDRESS>~ entry.supplierEmail|hash }}">
            <input type="hidden" name="url" value="{{ entry.url }}">

              Your Name
              {{ input('text', 'fromName', submission.fromName ?? '', {
                  id: 'from-name',
                  autocomplete: 'name',
                  class: 'form-control mb-3'
              }) }}
              {{ submission ? _self.errorList(submission.getErrors('fromName')) }}

              Your Email
              {{ input('email', 'fromEmail', submission.fromEmail ?? '', {
                  id: 'from-email',
                  autocomplete: 'email',
                  class: 'form-control mb-3'
              }) }}
              {{ submission ? _self.errorList(submission.getErrors('fromEmail')) }}

              Message
              {{ tag('textarea', {
                  text: submission.message ?? '',
                  id: 'message',
                  name: 'message',
                  rows: 10,
                  cols: 40,
                  class: 'form-control mb-3'
              }) }}
              {{ submission ? _self.errorList(submission.getErrors('message')) }}

              {% if craft.app.session.hasFlash('notice') %}

{{ craft.app.session.getFlash('notice') }}

              {% elseif craft.app.session.hasFlash('error') %}

{{ craft.app.session.getFlash('error') }}

              {% endif %}

          <button type="submit" class="btn btn-lg btn-success my-3 float-end">Send Enquiry</button>
        </form>`

I'm still getting the default confirmation emails as well as subjects.
My templates are under _emails/supplier.twig
Thanks

@JMKelley Is this craft 3 or 4?

Craft 4
On Tue, 13 Dec 2022, 17:30 Ross K, @.***> wrote:

@JMKelley https://github.com/JMKelley Is this craft 3 or 4?
—
Reply to this email directly, view it on GitHub
https://github.com/hybridinteractive/craft-contact-form-extensions/issues/167#issuecomment-1349197300,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPVLM4YMUVFWHV5DSUQLITWNCXD5ANCNFSM6AAAAAASZS7DYQ
.
You are receiving this because you were mentioned.Message ID:
<hybridinteractive/craft-contact-form-extensions/issues/167/1349197300@
github.com>

Any luck? :)

Yeah, sorry I tested this yesterday and figured it out today.

You can't just use message as it will overwrite the array that is being built. You need to change it to something like message[message]. I just added a note about this in the readme.
Note: All of the overrides will use the message as an array and therefore if you want a message field it would be name=message[message]. If a name=message is used it will wipe out the array of overrides.

Hi @rosskenney
I' having the same issue and neither the template or subject work. Im still receiving the default template and subject from my main config (it is not overwriting it).
The formName works though.
This is my code
My email template is in templates/_emails/interest.twig
<form method="post" accept-charset="UTF-8"  class="mt-12 sm:mx-auto sm:flex sm:max-w-lg form">
                        {{ csrfInput() }}
                        {{ actionInput('contact-form/send') }}

                            {{ input('email', 'fromEmail', submission.fromEmail ?? '', {
                                id: 'from-email',
                                autocomplete: 'email',
                                class: 'form__field block w-full drop-shadow-lg',
                                autofocus: false,
                                required: true,
                                placeholder: 'Enter your email address',
                            }) }}
                            Email address

                        <input type="hidden" name="message[message]" value="Expression of interest">
                        <input type="hidden" name="message[formName]" value="Expression of interest">
                        <input type="hidden" name="message[template]" value="{{ 'interest'|hash }}">
                        <input type="hidden" name="message[subject]" value="{{ 'Thank you for your interest'|hash }}">

                        <input type="hidden" name="fromName" value="" />

                        {{ craft.contactFormExtensions.recaptcha | raw }}

                        <button type="submit"
                                class="button form-submit big-btn block w-full sm:w-fit ml-0 sm:ml-4 mt-4 sm:mt-0">{{ site.buttonLabel|default('Get started')  }}</button>
                    </form>```

Hi @palomamtnez,
It is not message[subject] is is just subject to override that. If you want to override the confirmation subject it would be message[confirmationSubject]
The template overrides are as such message[notificationTemplate] and message[confirmationTemplate]
I assume you are using Craft 4 so please take note of all changes and additions to overrides listed in the README.md file.

 Thanks, that worked!


feat: add support for macOS

Quickemu now runs on macOS, as such Quickgui should also add support for running on macOS x86 and Apple Silicon.

Fixed in #188 but needs testing on an x86 macOS


Fixed .gitignore and removed packages from repository

Closing this out due to inactivity. Please feel free to re-open it with more information on how to test this change to verify it will not cause any problems for any of our users.


Text color and background reset button issue

In this video you can see the as soon as i write text and apply color and background color it works fine and i can reset the color and background color however if i apply font size after applying color and background color, now it does not let me reset the color and background color.
https://user-images.githubusercontent.com/38204661/116360811-bc326480-a819-11eb-8f16-ba0aec3d92a8.mov

The 2.38.5 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.

Thanks, @JiHong88 it's fixed now.


Make the number of bitstreams on the Item pages configurable

Is your feature request related to a problem? Please describe.
In DSpace 7, at most 5 bitstreams appear in Simple and Full Item Views, e.g. https://demo7.dspace.org/items/03731881-2185-4baf-a6a8-1438a4d29dc8 and https://demo7.dspace.org/items/03731881-2185-4baf-a6a8-1438a4d29dc8/full.
In Simple Item View, "Show more" adds 5 more bitstreams to the list.

In Full Item View, 5 bitstreams initially display. Clicking advances to the next page of 5 bitstreams.

Describe the solution you'd like
In DSpace 6 XMLUI, all bitstreams appear in Simple and Full Item Views. Please implement this or a configuration to set the initial and incremental number of bitstreams shown on these pages.
Describe alternatives or workarounds you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Agreed, this should be configurable.
Currently, it appears to be hardcoded to '5' in this component:
https://github.com/DSpace/dspace-angular/blob/main/src/app/item-page/simple/field-components/file-section/file-section.component.ts#L38
Changing that to be configurable should not be difficult, and it'd likely be similar to what was done in #1771.   I'd recommend making this configurable instead of defaulting to display all bitstreams, as I suspect different sites will want different behaviors.
Since this is a public page, I'll flag this as high priority and pull it over to the 7.4 board.  I think this could be implemented by a novice developer & might be done alongside similar tickets like #1750 and #1749


How to use Contacts API ?

Not clear at all and it's not in generated/google/apis

Contacts API isn't supported by this library. It's based on an older data format (gdata) that was deprecated quite awhile ago. There are only a handful of Google APIs still using that format and there are no plans to add support for them in this library.

In v0.8.6 I managed to use Contacts API with this library like here: https://gist.github.com/cantino/d1a63045fbfe5fc55a94
Now that I need creating and editing contacts, I couldn't figure out how to do it... https://developers.google.com/google-apps/contacts/v3/?hl=en#creating_contacts
I need POST requests... so is this possible to do manually either in 0.8.6 or in 0.9.0?

There is a generic http method that can be used to make arbitrary requests in the same way that gist uses the old execute method. The format of the call is a little different, but you should be able to modify that gist without too much work.

thank you... for now I managed to do everything I need with 0.8.6 .. maybe I will migrate to 1.0.0 when it's ready.. I now know which method to use


[v2] ThemeProvider eats css objects?

Version
2.0.0-17
Reproduction
https://www.webpackbin.com/bins/-Kj6oK5hyYyMNuV56HvI
Steps to reproduce
put a css-generated object in theme
Expected Behavior
you can interpolate it
Actual Behavior
it does not work. See repro; the only style working is the hover over the title

Oops I just realized that I didn't use theme. I was trying to reproduce an issue in my app but now I realize it is probably the babel plugin.


feat(rust): add ngrok-like tunnel example application

This PR introduces a new example project called tunnel, which is a nano version of ngrok.
Resolves #1762

@Stupremee that looks awesome!! Thank you for sending the PR ❤
While we get some feedback from @SanjoDeundiak and @jared-s ... could you accept our CLA
Read the CLA at
https://www.ockam.io/learn/how-to-guides/contributing/cla/
To accept the CLA please send a different PR to our contributors repo indicating that you accept the CLA by adding your Git/Github details in a row at the end of the CONTRIBUTORS.csv file:
https://github.com/ockam-network/contributors/blob/master/CONTRIBUTORS.csv
Looking forward to merging your first contribution!!

Hey @Stupremee , nice job. Few questions before we can merge it


[bug] Cannot import additional plugins when used with Svelte

Describe the bug
I've successfully used this library without additional plugins.
But as soon as I import or mount the Swap plugin, I get errors:

Mounting with
import Sortable, { Swap } from 'sortablejs';
Sortable.mount(new Swap());

gives the following error:
[vite] Named export 'Swap' not found. The requested module 'sortablejs' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'sortablejs';
const {Swap} = pkg;

Needless to say, the proposed solution does not work.

Mounting with
import Sortable from 'sortablejs';
Sortable.mount(new Sortable.Swap());

gives the following error in VSCode:
TypeError: __vite_ssr_import_1__.default.Swap is not a constructor

And I get a  500 - Internal Error from the console.

Importing with
import Sortable from "sortablejs/modular/sortable.core.esm";

gives the following error in console:
Unexpected token 'export'

/path/to/app/node_modules/sortablejs/modular/sortable.core.esm.js:3349
export default Sortable;
^^^^^^

and the following error in VSCode:
Could not find a declaration file for module 'sortablejs/modular/sortable.core.esm'. '/path/to/app/node_modules/sortablejs/modular/sortable.core.esm.js' implicitly has an 'any' type.
If the 'sortablejs' package actually exposes this module, consider sending a pull request to amend 'https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/sortablejs'

Trying to enable swap: true on my Sortable without the import doesn't trigger the swap behaviour.
The weirdest thing is, when building the app from scratch, I do get the correct behaviour without any error with the first mentioned method, but this breaks as soon as I add another component. Removing entirely the component does not remove the errors.
To Reproduce
Steps to reproduce the behavior:

Create a basic svelte skeleton app with npm create svelte@latest
Import Sortable with npm install storablejs
Add basic Sortable code in +page.svelte
Use any method mentioned above to add Swap
Add a component
Run the developpement environment with npm run dev
Error appear in console and/or on screen

You can also grab the code sandbox given below.
Expected behavior
Swap correctly imported and my list behaving correctly
Information
Versions:
sortablejs = ^1.15.2
@types/sortablejs = ^1.15.2
Additional context
As mentioned, I encounter this issue in a Svelte app using Sveltekit and Vite.
@sveltejs/kit = ^2.0.0
@sveltejs/vite-plugin-svelte: ^3.0.0
vite = ^5.0.3
I am also using TypeScript.
typescript = ^5.0.0
Reproduction
codesandbox: Code Sandbox

I managed to work around this in a different way with:
onMount(async () => {      const Sortable = (await import('sortablejs/modular/sortable.complete.esm.js')).default;      Sortable.create(...);


Providing a way to receive webhooks or deployment notifications in site extension

I am creating a site extension that needs to receive the deployment webhook for the same site.  Currently the webhook is unable to hit my site extension because it is blocked by Kudu's basic auth security.
Since this is an extension for the same site the webhook is coming from, could there be a way to POST to a site extension without going through this layer of security? Or is there another way to get this kind of notification?

This is a tough one to solve, and has come up once or twice before. While it seems like a no brainer, code running in the scm site has no easy way today to make an http request to itself because of the auth.
We've discussed possible approaches where the scm site would have some kind of token available that could be used to auth back to itself via http, but we never took that too far.

The token would be a good way do it, especially if the extension could use the same token to access the scm site's REST APIs.  That would allow the extension to even register itself to receive the webhook.
Is there any chance of this feature being added in the near term?

Realistically, you should not expect that near term, as there are just too many other things going on, and this has not been a super high demand point. Though I still hope it will get done at some point.
And note that the work for this would not be in Kudu, but in some deeper part of Azure that deals with auth.

10-4, Thanks.
I'll leave this issue to you to leave open or close out as you see fit.

Hi
Kudu will continue to run in Azure App Service. However, this repo will no longer be maintained.
If the problem persists and is related to running on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


Enhancement: do not drop the filter after returning from Info page

Apply filters to the grid
Go to resource model Info page (or Edit page)
go back using the back button on the page (not browser back button), filters are dropped.

Hi, @dmitryLagoda. Thanks for the suggestion. We will rebuild the UI a little bit in version 2.0 that filters will be probably in a list  (there wont be a "slide" filters bar). So I am closing this one since it will be rewritten either way


Directly open home screen if active survey available

Fixes #2260

@gino-m @scolsen @sufyanAbbasi  PTAL?

Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)

Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)

This is really annoying, I'll try to spend some time on this GCB issue this week. It has become very flaky since past few weeks.
I ran the unit tests and code quality checks locally. Verified that everything is green.
Going ahead with merging this.


Init prompt from params

use prompt from params if present when the comfyui pipeline starts, add logging when prompt is set

Pinned to streamdiffusion fork to resolve hugging_face version issue
https://github.com/livepeer/ai-worker/pull/327/files#diff-f31feccb2794231dcf1486973c09d7c443f7a49150113cedd78039b5604919d0R28


Add MariaDB support

MariaDB is supported for Liferay 6.2 and certified for DXP.
Also, the JDBC connector lib is included in DXP by default.

Implemented as of 3bbc60ef33850dae647b6aba0b6a2fef41989c98
Thanks!


[CI] Integrate blockhound

Motivation:
Explain why you're making this change and what problem you're trying to solve.
Modifications:

List the modifications you've made in detail.

Result:

Closes #. (If this resolves the issue.)
Describe the consequences that a user will face after this PR is merged.

Note: There is a known issue where a Option AllowRedefinitionToAddDeleteMethods was deprecated.. is printed in logs. Will look into this as well.
https://bugs.openjdk.org/browse/JDK-8221528
https://github.com/reactor/BlockHound/issues/33

As of Netty 4.1.85, FastThreadLocalThread permits to perform blocking calls. If the flag is set, a Netty Blockhound integration module does not assume the thread is a non-blocking thread. https://github.com/netty/netty/pull/12978

Hi, let me report the following after trying blockhound with Armeria 1.20.3
Zipkin tracing can block when flushing spans
at java.base/java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:267)
	at zipkin2.reporter.ByteBoundedQueue.offer(ByteBoundedQueue.java:51)
	at zipkin2.reporter.AsyncReporter$BoundedAsyncReporter.report(AsyncReporter.java:259)
	at (...)
	at zipkin2.reporter.brave.ConvertingSpanReporter.report(ConvertingSpanReporter.java:44)
	at zipkin2.reporter.brave.ConvertingSpanReporter.report(ConvertingSpanReporter.java:29)
	at zipkin2.reporter.brave.ZipkinSpanHandler.end(ZipkinSpanHandler.java:148)
	at brave.internal.handler.NoopAwareSpanHandler.end(NoopAwareSpanHandler.java:57)
	at brave.internal.recorder.PendingSpans.finish(PendingSpans.java:122)
	at brave.RealSpan.finish(RealSpan.java:143)
	at brave.http.HttpHandler.handleFinish(HttpHandler.java:84)
	at brave.http.HttpServerHandler.handleSend(HttpServerHandler.java:200)
	at com.linecorp.armeria.server.brave.BraveService.lambda$maybeAddTagsToSpan$2(BraveService.java:138)

Though it sounds ignorable, I'm not sure if armeria integration should be the one ignoring it, as opposed to each application using it.
Reading Prometheus gauges (ExecutorServiceMetrics) can block
at java.base/java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:267)
	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.size(ScheduledThreadPoolExecutor.java:1069)
	at io.micrometer.core.instrument.binder.jvm.ExecutorServiceMetrics.lambda$monitor$0(ExecutorServiceMetrics.java:347)
	at io.micrometer.core.instrument.internal.DefaultGauge.value(DefaultGauge.java:53)
	at io.micrometer.prometheus.PrometheusMeterRegistry.lambda$newGauge$5(PrometheusMeterRegistry.java:335)
	at io.micrometer.prometheus.MicrometerCollector.collect(MicrometerCollector.java:75)
	at io.prometheus.client.Collector.collect(Collector.java:45)
	at io.prometheus.client.CollectorRegistry$MetricFamilySamplesEnumeration.findNextElement(CollectorRegistry.java:204)
	at io.prometheus.client.CollectorRegistry$MetricFamilySamplesEnumeration.nextElement(CollectorRegistry.java:219)
	at io.prometheus.client.CollectorRegistry$MetricFamilySamplesEnumeration.nextElement(CollectorRegistry.java:152)
	at io.prometheus.client.exporter.common.TextFormat.writeOpenMetrics100(TextFormat.java:202)
	at io.prometheus.client.exporter.common.TextFormat.writeFormat(TextFormat.java:57)
	at com.linecorp.armeria.server.metric.PrometheusExpositionService.doGet(PrometheusExpositionService.java:95)
	at com.linecorp.armeria.server.AbstractHttpService.serve(AbstractHttpService.java:53)

This looks ignorable.
recording in a Hdr histogram can cause a sleep
at java.base/java.util.concurrent.TimeUnit.sleep(TimeUnit.java:446)
	at org.HdrHistogram.WriterReaderPhaser.flipPhase(WriterReaderPhaser.java:244)
	at org.HdrHistogram.DoubleRecorder.performIntervalSample(DoubleRecorder.java:300)
	at org.HdrHistogram.DoubleRecorder.reset(DoubleRecorder.java:265)
	at io.micrometer.core.instrument.distribution.TimeWindowPercentileHistogram.resetBucket(TimeWindowPercentileHistogram.java:63)
	at io.micrometer.core.instrument.distribution.TimeWindowPercentileHistogram.resetBucket(TimeWindowPercentileHistogram.java:35)
	at io.micrometer.core.instrument.distribution.AbstractTimeWindowHistogram.rotate(AbstractTimeWindowHistogram.java:268)
	at io.micrometer.core.instrument.distribution.AbstractTimeWindowHistogram.recordLong(AbstractTimeWindowHistogram.java:221)
	at io.micrometer.core.instrument.distribution.TimeWindowPercentileHistogram.recordLong(TimeWindowPercentileHistogram.java:35)
	at io.micrometer.core.instrument.AbstractTimer.record(AbstractTimer.java:182)
	at io.micrometer.core.instrument.composite.CompositeTimer.record(CompositeTimer.java:50)
	at com.linecorp.armeria.internal.common.metric.RequestMetricSupport.onResponse(RequestMetricSupport.java:115)

The sleep is about 1ms at most, so I suppose it can be ignored, but let's be aware that it could happen for each histogram that is being updated in a non-blocking thread.
Submitting a task to a blocking scheduler can block
at java.base/java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:267)
	at java.base/java.util.concurrent.ThreadPoolExecutor.addWorker(ThreadPoolExecutor.java:916)
	at java.base/java.util.concurrent.ThreadPoolExecutor.ensurePrestart(ThreadPoolExecutor.java:1583)
	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor.delayedExecute(ScheduledThreadPoolExecutor.java:346)
	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor.schedule(ScheduledThreadPoolExecutor.java:562)
	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor.execute(ScheduledThreadPoolExecutor.java:705)
	at com.linecorp.armeria.common.util.DefaultBlockingTaskExecutor.execute(DefaultBlockingTaskExecutor.java:126)

The lock seems like it's never held for long.
Guava's MapMaker's ConcurrentMap can block
at java.base/java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:267)
	at com.linecorp.armeria.internal.shaded.guava.collect.MapMakerInternalMap$Segment.put(MapMakerInternalMap.java:1476)
	at com.linecorp.armeria.internal.shaded.guava.collect.MapMakerInternalMap.putIfAbsent(MapMakerInternalMap.java:2419)
	at java.base/java.util.concurrent.ConcurrentMap.computeIfAbsent(ConcurrentMap.java:331)
	at com.linecorp.armeria.client.HttpClientFactory.pool(HttpClientFactory.java:404)
	at com.linecorp.armeria.client.HttpClientDelegate.acquireConnectionAndExecute0(HttpClientDelegate.java:169)

Again, the lock seems never held for long.

Is there any progress on this?

Is there any progress on this?

Let me try working on this again when I have more time 😅
At the moment, the difficult part is figuring out why failed tests are failing.  The pattern most often found is:

An assertion is made on a thread other than the junit main thread
I have to spend a significant amount of time figuring out at which point the test failed

Let me look into this again next week 😅   Sorry about the delay

If we introduce a general interface that marks all methods of its subclasses are safe to execute in an event loop, it would be easier to implement the BlockHound integration module.
The following example was borrowed from the change in #4837
public interface EventLoopSafe {}

class DestroyHandler implements BiFunction<Object, Throwable, Void>, EventLoopSafe {

	@Override
	public Void apply(Object unused, Throwable throwable) {
	    // BlockHound will report this blocking operation without EventLoopSafe
	    lock.lock();
	    try {
	       ...
	    } finally {
	        lock.unlock();
	    }
	    return null;
	}
}

If we introduce a general interface that marks all methods of its subclasses are safe to execute in an event loop, it would be easier to implement the BlockHound integration module.

I'm not sure if I understood the intention, but could it be easier if we just introduce a lock which is ignorable by Blockhound?

In #4837, it is likely that DefaultHealthCheckerContext.destroy() is detected by BlockHound because of the usage of ReentrantLock.lock().
Question: Is it feasible to extend ReentrantLock and add it to allowBlockingCallsInside?
For example:
class ReentrantShortLock extends ReentrantLock { ... }

BlockHound.Builder builder = ...;
builder.allowBlockingCallsInside("com.linecorp.armeria.internal.common.ReentrantShortLock",
                                 "lock");

Sorry about the delay 🙏    I believe this PR is (finally) ready for review

Thank you!


v0.8.0 tag trtllm-build does not accept max_draft_len arg

System Info
TensorRT-LLM v0.8.0 branch https://github.com/NVIDIA/TensorRT-LLM/blob/v0.8.0/tensorrt_llm/commands/build.py
versus main branch https://github.com/NVIDIA/TensorRT-LLM/blob/main/tensorrt_llm/commands/build.py
Who can help?
@ncomly
Information

[ ] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
The max_draft_len parameter is necessary when building the model for speculative decoding. In the main branch, the code to accept this arg is there in lines 122 to 128:
parser.add_argument(
        '--max_draft_len',
        type=int,
        default=0,
        help=
        'Maximum lengths of draft tokens for speculative decoding target model.'
    )

However, this support for max_draft_len is absent in the version tagged v0.8.0 - not sure if it was accidentally missed before the v0.8.0 release. Could it be added to the v0.8.0 version?
Expected behavior
See above
actual behavior
See above
additional notes
N/A

max_draft_len parameter is added to main branch in the code freeze period of v0.8.0 release, it is not a feature of v0.8.0 release. If it is needed, main branch can be used or wait for later v0.9.0 release.

Hi @ydm-amazon ,please try the latest branch and see if the issue still exists or not.

Close it since this parameter is avaiable now


preset es2015 and es2015-rollup

My rollup build process needs es2015-rollup, but my mocha test needs es2015. I need a workflow that gets me to use both. Any help appreciated.

You could try putting the .babelrc needed by Mocha in your tests folder, and passing configuration directly to rollup-plugin-babel:
plugins: [
  babel({ presets: [ 'es2015-rollup' ] })
]

Yes,
Thank you


Added additional fields to DepartmentUser Excel export. Added favicon.

This change is

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Login screen issue in docs

This is a (multiple allowed):

[x] bug
[ ] enhancement
[ ] feature-discussion (RFC)

What you did
Clickend on "open login screen with JS"
Expected Behavior
To be closed after click on sign in.
Actual Behavior
Did not close - see screenshot (error).

It's just that goBack() function has been renamed to back() while ago.

@GuillaumeBiton PR?

I get try but it should be in Framework7-Website repository


aws_security_group_rule is being replaced.

https://github.com/terraform-aws-modules/terraform-aws-ecs/blob/d764aae10c537a381f6098587e877edc0c26798b/modules/service/main.tf#L1312
The service module is using aws_security_group_rule which has been replaced/superseded by the aforementioned resources.
"The aws_vpc_security_group_egress_rule and aws_vpc_security_group_ingress_rule resources have been added to address these limitations and should be used for all new security group rules." [1]

Is there any particular issue you are seeing with the current implementation?

Is there any particular issue you are seeing with the current implementation?

Yes, I am seeing the task security group get re-created every time during apply despite no changes being made.

do you have a sample reproduction we can try out?


Update file ordering system

Fixes: Changes file uploads section to display file uploads in reverse sorted order by creation time. This is preferable since users most likely want to see their most recently uploaded files first.

Thanks! How does this PR improve upon #23744? We should likely just iterate there rather than opening a new PR for this issue.

Closing as abandoned and possibly a duplicate of https://github.com/zulip/zulip/pull/23744.


update readme; add badges and expand on examples

@muneeb-ali What do you think about registering this library on pypi as "blockstack-proofchecker"? That way, with all of our blockstack-specific libraries we'll be pushing the blockstack brand across. The other idea I had was "blockstack-proofs".

Registered as blockstack-proofs! Same name as the name of the repo on Github.

ok awesome!


Key Error for  buffer_dict

Please describe the bug
Then I tried to train a gpt-neo 1.3b  parameters model using the code https://github.com/alpa-projects/alpa/blob/main/examples/gpt2/run_clm_flax.py on 2 nodes, one head node which don't have any cpus or gpus and one worker node has 8 gpus showing the following error:
2022-12-02 14:31:03,423	ERROR worker.py:400 -- Unhandled error (suppress with 'RAY_IGNORE_UNHANDLED_ERRORS=1'): ray::MeshHostWorker.run_executable() (pid=8620, ip=<IP_ADDRESS>, repr=<alpa.device_mesh.MeshHostWorker object at 0x7fd3c60e67c0>)
  File "/home/nlp/miniconda/lib/python3.8/site-packages/alpa/device_mesh.py", line 277, in run_executable
    self.executables[uuid].execute_on_worker(*args, **kwargs)
  File "/home/nlp/miniconda/lib/python3.8/site-packages/alpa/mesh_executable.py", line 907, in execute_on_worker
    del buffer_dict[next_batches_uuids[i]]
KeyError: None

Please describe the expected behavior
System information and environment

OS Platform and Distribution (e.g., Linux Ubuntu 16.04, docker): Docker based on nvidia/cuda:11.3.1-cudnn8-devel-centos7
Python version: 3.8
CUDA version: 11.3
NCCL version: 820
cupy version: cupy-cuda113
GPU model and memory: 2080ti 11g
Alpa version: 0.2.2
TensorFlow version: 2.1.0
JAX version: 0.3.22+cuda113.cudnn820

To Reproduce
I have modified the https://github.com/alpa-projects/alpa/blob/75f3597dbf4a49debce3cc1a8c83f2cb7b8b6eda/alpa/device_mesh.py#L2153 line, to pass the node which don't have any gpus.
Then I tried to train a gpt-neo 1.3b parameters model using the code https://github.com/alpa-projects/alpa/blob/main/examples/gpt2/run_clm_flax.py on 2 nodes, one head node which don't have any cpus or gpus and one worker node has 8 gpus(2080) using following command :
ray job submit --working-dir . --address http://<IP_ADDRESS>:8265 -- python run_clm_jax.py --output_dir="test_norwegian-gpt-neo_big"     --model_type="gpt-neo"     --config_name="pretrain_model/models--EleutherAI--gpt-neo-1.3B/snapshots/797174552ae47f449ab70b684cabcb6603e5e85e/"     --tokenizer_name="pretrain_model/models--EleutherAI--gpt-neo-1.3B/snapshots/797174552ae47f449ab70b684cabcb6603e5e85e/"     --dataset_name="oscar"     --dataset_config_name="unshuffled_deduplicated_no"     --do_train --do_eval     --block_size="512"     --per_device_train_batch_size="2"     --per_device_eval_batch_size="2"     --num_micro_batches="1"     --dtype="float16"     --learning_rate="1e-3" --warmup_steps="1000"     --adam_beta1="0.9" --adam_beta2="0.98" --weight_decay="0.01"     --overwrite_output_dir     --num_train_epochs="1"     --logging_steps="100"     --save_steps="2500"     --eval_steps="2500"

Can you run tests/pipeline_parallel/test_bert.py successfully? Plus, I also wonder more detail of the KeyError, say, is i == None or next_batches_uuids[i] == None?

yeah, I will check it

tests/pipeline_parallel/test_bert.py

This is passed the test

I have been getting the same error. I had to reduce the VRAM usage, though there should have been plenty of it.

how did u do to reduce the vram usage

Can you run tests/pipeline_parallel/test_bert.py successfully? Plus, I also wonder more detail of the KeyError, say, is i == None or next_batches_uuids[i] == None?

I am back. After reproduce the error,  i found that i ==0 and next_batches_uuids[i] == None and next_batches_uuids ==(None,)


Antarctic doesn't show in ImageRenderer.

To reproduce:

Open VAPOR, load WRF data /little_glade/data/WRF/antarctic/antarctic_02/wrfout_d02_2009-04-01_00:00:00.
Create an Image Renderer, enabled it. Nothing shows on screen.
Uncheck "Geo Reference" results in a rendering. But I suspect it should also show the Antarctic with "Geo Reference" checked.

Currently if Geo Reference is checked, the rendering is gone. I'm not sure if this is the desired behavior. If it is, then we could close this issue.

Update on 6/11/2018:
Still the same.

Duplicate of #1341. (Closing this one even though it is older as the other issue has more info)


[files/scripts/whitelist] Remove redundant messages

They are already logged in Whitelist.
Fixes:
$ files/scripts/whitelist.py approve username
Account: username approved successfully
Account username approved successfully

recheck

* packit-service-pre-commit  : FAILURE in 1m 30s

urllib.error.HTTPError: HTTP Error 500: Internal Server Error


Added note about max URI length

Moved from: https://github.com/SparkPost/sparkpost-api-documentation-DEV/pull/327


Add navsat tile zoom settings

The tile zoom is set to 19 (max for OSM) by default and would need an input box to set it to anything else.

would this enhancement allow to zoom out more? I am interesting in increasing max zoom out, but I don't know how to change it yet

Max zoom is defined here if you want to experiment with changing it, it's mainly limited to that so it clamps accidental zoomouts, but yes also to some extent so it doesn't trigger fetching of a billion navsat tiles. Fetching is throttled to prevent spamming the OSM CDN, so if the queue fills up at that scale it'll be processing it a long time and won't be very responsive if you move to a new area.
It would be certainly good to be able to zoom out further, since it's definitely annoying when working with very large areas (especially when trying to find the base_link relative to the faraway world origin).
There are lots of ways it could be partially worked around for the navsat widget, initially maybe just blocking fetching above some zoom level, discarding too old tiles in the loading queue or limiting its size, and the best option: automatically fetching larger tiles when zoomed out further (just like any proper GIS renderer does it) and as a draft when the max accuracy level hasn't loaded in yet. Perhaps level 17 as the draft and level 15 as the max zoom out, or just have it all completely dynamic.
It's currently rather hardcoded though so it would take some refactoring. Not all tile servers offer all zoom levels either, so having some adjustable numbers would not be the worst idea either.

@darkhannibal and I are playing with your code in this repo https://github.com/kosmonauta144/vizanti to change time zoom level. It still needs some cleanup but for the moment is seems to work not as bad as I though it would.. We are still checking for errors, but if you have some time and you could check it for possible bugs or what can need improvement, it could be great.

Oh awesome, I'll turn it into a PR and we can discuss and refine it there. :+1:

Closed by #79 and #80. Opened #81.


Add serializer context

Could be used for making wire format smaller later, introduce it so we don't need an interface change to add it.

I think this could just be added to Serializers if needed.


add support for AzureCLI@2 syntaxfixes issue https://github.com/mic…

fixes issue https://github.com/microsoft/azure-pipelines-vscode/issues/282

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: a30001539 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

The schema file is generated by an automated process, and we don't take manual changes to it.


template error while templating string: no test named 'false'

Getting this when trying to run. This worked on a previous version of ansible, not sure which version it was though (sorry).
I have not changed any haproxy_global stuff
TASK: [info.haproxy | Ensure chroot directory exists] *************************
fatal: [lb0.example.com] => template error while templating string: no test named 'false'

FATAL: all hosts have already failed -- aborting

ansible-playbook --version
# => ansible-playbook 1.8.2

Thanks @ahaitoute ! Closing this for now.


Rocket.Chat.Electron doesn't display certain changes (because of caching?) / Global Setting to define TTL for cache ?

My Setup

Operating System: Windows 7 SP1 x64
App Version: 2.9.0

[x ] I have tested with the latest version
[x ] I can simulate the issue easily

Server Setup Information:
Version of Rocket.Chat Server: 058.1
Operating System: Debian 9.1 Stretch
Deployment Method(snap/docker/tar/etc): tar
Number of Running Instances: 2
DB Replicaset Oplog: Yes, 1 ReplicaSet
Node Version: 4.8.2
Description
For example a change in the user profile picture or auto-generated avatar only will be displayed after:

Full reload with Clearing Cache (CTRL+Shift+R) (helps sometimes)
Deleting the users %APPDATA%/Roaming/Rocket.Chat+ folder and restarting Rocket.Chat.Electron (helps always)

This may be linked to Caching, or to the "Save Mobile Bandwith" Setting beeing enabled.
Please see: https://github.com/RocketChat/Rocket.Chat/issues/7994
Current Behavior
For example a user changes the profile picture. When using Rocket.Chat via a browser e.g. Firefox, the change gets displayed after a short amount of time.
When using Rocket.Chat.Electron, the change only get's displayed after force-deleting it's Cache.
Expected Behavior
The change should be visible immediatly, or at least after a few minutes.
Is it possible to disable caching for Rocket.Chat.Electron? Or to define a TimeToLive for the cache?
Any ideas?
Thanks for your answers!

Update: I couldn't reproduce the error since updating to the newest Rocket.Chat RC's. I think this can be closed.


js[patch]: Fix listRuns limit arg

Added faker package for tests

@hinthornw ci throwing 401 unauthorized errors. Did something happen to the LS secrets in gh actions?

Nothing was changed in 3 months... Wonder if GH is acting up. I went ahead and updated the key just in case


Update mikro-orm v5 nestjs docs

We should probably add a section about this - I see its totally missing in there, so it might look confusing in a sense that people may think the @UseRequestContext or special context handling is required, which is pretty much the opposite of truth as things work out of box in most cases.

@B4nan Using GraphQL with Nest.js I am getting errors on every request about RequestContext. If I explicitly register express middleware after all body parsers as you described in the docs I'll get an application works a proper way.

So? Do I get it right that you are telling me that there is a limitation we already describe in the docs? :]
https://mikro-orm.io/docs/usage-with-nestjs#request-scoping-when-using-graphql


Publish the PowerBIPS module on the psgallery

Would it be possible to publish the module on https://www.powershellgallery.com/ ?

Hi Stinjnc,
Great tip, its published! https://www.powershellgallery.com/packages/PowerBIPS/
Also need to include the dll "Microsoft.IdentityModel.Clients.ActiveDirectory.WindowsForms.dll" to make it work.
Thanks


fix: Not found page appear briefly after updating the first approver

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/51282
PROPOSAL: https://github.com/Expensify/App/issues/51282#issuecomment-2429976093
Tests

Create a new workspace with at least 2 members
Enable workflow -> enable Add approvals
Change the first approval
Click save button
Verify that: Not found page doesn't appear

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Create a new workspace with at least 2 members
Enable workflow -> enable Add approvals
Change the first approval
Click save button
Verify that: Not found page doesn't appear

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/1b2a1a2e-d253-4765-899e-8512182811bc

Android: mWeb Chrome
https://github.com/user-attachments/assets/cd51b7a9-23b9-4e2a-812c-83e3f32aaef7

iOS: Native
https://github.com/user-attachments/assets/bee3d20e-f085-4da4-978d-7a4620b092df

iOS: mWeb Safari
https://github.com/user-attachments/assets/fdb4e6ae-3722-4910-af2a-fb9b3390b023

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/538666c7-dbbb-4601-a914-9d1bd97a77fc

MacOS: Desktop
https://github.com/user-attachments/assets/9b67e360-1def-4e65-82f5-4dc08529f070

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@daledah BUG: The approver on the "Add approver" section is flicker
https://github.com/user-attachments/assets/3f978c3d-bdfd-4e9e-a30a-0d7befc8f09c

@daledah  Jest UTs 3 failed

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


modules: hal_nordic: nrfs: DVFS cleanup

Removing unnecessary logging from DVFS reg operations in lib NRFS.
Update manifest to include latest updates from NRFS.

please rebase :)


Transforming multipart/form-data returns application/octet-stream

The matching logic must be off. Requires investigation.

@dhwaneetbhatt Can you confirm this is still the case?  I haven't been able to reproduce it.  It may have been fixed at some point and just not released.  The Web version currently has the latest from the main branch: https://kevinswiber.github.io/postman2openapi/ or you can build and test from the latest code in the repo.  Thanks!

Should be fixed in v1.0.0.


Case Sensitive Values

budget-by value, "Person" returned an error from Harvest, but "person" (lowercase) did not. I suggest converting the BudgetMethod enum to lowercase.

I've updated the enumeration definition in 0.14


Update notification end points on relay

Release notification for only the latest release should be fetched.
User should get release notification only if the user app version is less than MAN

-Release notification did not work.

Tested with shivani on dev app v2.0 and 1.0


Fix review functionality.

Found that Assessor is able to review the all User forms even if is not
assigned to that case and is not a lead either. Added some restrictions to
reviewing the resources also as It was designed initially to use for the Admin,
but in case of Assessors we should be more suspicious.

Good to merge :+1:  Waiting travis


A bunch of fixes for nightly tests

Nightly flake failed with some new failures (and one old failure) last night

Startup and shutdown hung. This was caused by the notebook in use for the initial window not being disposed completely by the time the second window comes up
Remote tests all failed with 'insecure not supported'. This was caused by the secure server stuff. Fixed it by making the app shell return the 'yes' value when asked.
Ipywidgets are still having trouble executing more than a couple of cells randomly. Added some timeouts and some extra logging.
Unit test failure with nyc
Multiple interpreters not finding another interpreter. This I can't repro but might be related to the startup and shutdown fix as this test tries opening/closing windows and switching interpreters in between.

Codecov Report

Merging #13099 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #13099      +/-   ##
==========================================
- Coverage   59.79%   59.76%   -0.03%
==========================================
  Files         671      671
  Lines       36681    36683       +2
  Branches     5158     5158
==========================================
- Hits        21933    21924       -9
- Misses      13655    13663       +8
- Partials     1093     1096       +3

Impacted Files
Coverage Δ

src/client/datascience/jupyter/jupyterNotebook.ts
4.25% <0.00%> (-0.02%)
:arrow_down:

src/client/common/utils/platform.ts
64.70% <0.00%> (-11.77%)
:arrow_down:

src/client/datascience/crossProcessLock.ts
79.41% <0.00%> (-11.77%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0.00%> (-0.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c99859...41935fd. Read the comment docs.


[Bug]: Route53 Zone external name not being set after creation

Is there an existing issue for this?

[X] I have searched the existing issues

Affected Resource(s)

route53.aws.upbound.io/v1beta1 - Zone

Resource MRs required to reproduce the bug
apiVersion: route53.aws.upbound.io/v1beta1
kind: Zone
metadata:
  name: example
spec:
  forProvider:
    name: mycompany.test
    region: us-west-1

Steps to Reproduce

Apply MR (Zone) to cluster
Hosted Zone is created in AWS Route53 by provider
MR becomes synced: true and ready: true

What happened?

External name annotation is never added to MR
Crossplane will eventually create duplicate hosted zones if the provider is restarted

Relevant Error Output Snippet
No response
Crossplane Version
v1.16.1
Provider Version
v1.17.0
Kubernetes Version
v1.29.8
Kubernetes Distribution
EKS
Additional Info
This issue is similar to https://github.com/crossplane-contrib/provider-upjet-aws/issues/1482

Hi @awprice,
Thank you for bringing up this issue. I could not reproduce the issue with the provided information.
apiVersion: route53.aws.upbound.io/v1beta1
kind: Zone
metadata:
  annotations:
    crossplane.io/external-create-pending: "2024-11-30T10:53:06Z"
    crossplane.io/external-create-succeeded: "2024-11-30T10:53:06Z"
    crossplane.io/external-name: Z04762493SW6AYLIXTUYH
    ...

Have you made any changes to resource management policies? This is a known issue if you disable late initialize: https://github.com/crossplane/crossplane/issues/5918

Thanks @turkenf for looking into this.

Have you made any changes to resource management policies?

Apologies I had forgot to mention in the original post that I was using the following:
  managementPolicies:
    - Observe
    - Create
    - Update

and indeed, adding LateInitialize to the list of managementPolicies fixes the issue.
Closing this out.


Add mocha before hook issue fix

Description
If a test is failed in before , the rest of the tests are not executed and the status of the test is also not reported.
Hereafter these tests are marked as skipped and a new event test.skipped will be triggered
Before

After

Fixes #2349

what issue it fix?

what issue it fix?

@Vorobeyko Linked the issue now, fix is not complete. Will add complete description once it is fixed completely

It seems that skipped scenario is logged incorrectly twice in CodeceptJS 2.6.2:
2.6.2 :beetle: :
$ npx codeceptjs run
CodeceptJS v2.6.2
Using test root "/home/mirao/workspace/codeceptjs/tests/demo"

Login --
  S Successful login
  S Failed login
  S Successful login
  S Failed login

  OK  | 0 passed, 4 skipped   // 3ms

2.6.1 :heavy_check_mark: :
$ npx codeceptjs run
CodeceptJS v2.6.1
Using test root "/home/mirao/workspace/codeceptjs/tests/demo"

Login --
  S Successful login
  S Failed login

  OK  | 0 passed, 2 skipped   // 3ms

@mirao Can you share with me the sample test case? Github repo will also do!

E.g. this one:
Feature("Login");

Scenario.skip("Open a page", (I) => {
    I.amOnPage("/");
});

log:
$ npx codeceptjs run
CodeceptJS v2.6.2
Using test root "/home/mirao/workspace/codeceptjs/tests/demo"

Login --
  S Open a page
  S Open a page

  OK  | 0 passed, 2 skipped   // 3ms

Thanks, Let me check

@mirao Found the issue, Will fix it right away


Only allow declares inside declare module

This is the followup of #71
This now checks for the term declare being used inside declare module. Previously everything was allowed instead of declare. https://astexplorer.net/#/Y6hVjJkQ2m

Current coverage is 96.91% (diff: 100%)

Merging #73 into master will not change coverage

@@             master        #73   diff @@
==========================================
  Files            19         19
  Lines          2922       2922
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           2832       2832
  Misses           90         90
  Partials          0          0

Powered by Codecov. Last update f576865...988be93

I changed the error message to be a little bit nicer.

k 👍 , @jeffmo

👍 this looks correct to me. Everything inside of a declare module declaration does start with declare.


SSH needs to ignore key fingerprint

The authenticity of host XXXX can't be established.
ED25519 key fingerprint is SHA256:1XXX.
This key is not known by any other names
Are you sure you want to continue connecting (yes/no/[fingerprint])?

Fix committed.


Socket timeout setting ignored for filebeat

Due to a bad comparisson, the socket timeout for lostash_async was ignored when using the filebeat transport.

Thanks and oops.


Identify Submodels also in the IRS owner's registry

As a PURIS user ,
I want to be able to retrieve also submodels in my own registry for the given Catena-X ID of the child items,
so that I am able to retrieve submodels from my partner's and my own twin.
Hints / Details

PURIS has information that belong to both, customer and supplier but should refer to the same digital twin.
The twins need to be provisioned according to Industry Core KIT.
The following graphic provides an overview:

Given the customer manufactures the material "Control Unit", the customer IRS traverses the SingleLevelBomAsPlanned to identify also the material "Semiconductor" of his supplier based on the Catena-x ID and the BPN (EDC Discovery). As a result thesSubmodels "Supplier Production Output" and "Supplier Stock" have been found.
The IRS does NOT find the material "Semiconductor" of the customer. Thus, the Submodels "Customer Demand" and "Customer Stock" may not be found. -> To find this information, the IRS must lookup the same Catena-X ID (Global Asset ID) in the customer's own Digital Twin Registry. A BPN Discovery usage is not needed for this step.

Outcome / Acceptance Criteria

Outcome

The IRS considers the submodels of the customer's and supplier's twins that represent the same asset.

Acceptance Criteria

The IRS finds the submodels of the suppliers twin for each child item (following the already existing access restrictions).
The IRS finds the submodels of the customers twin for each child item (following the already existing access restrictions).

Out of Scope

A third party providing information about the same asset with a third twin.

@tom-rm-meyer-ISST thank you for your issue. We'll have a look and let you know how we proceed with this

Focus time due is Release 24.05

Label DISCUSSION_NEEDED was removed. Initially we start with a concept as a base for further discussions.

To be clarified:

For which bom lifecycles and direction is this applicable?
Are there only certain aspect models which have to be requested in this manner or does this apply to all aspect models?

@ds-jhartmann thanks for reaching out.
We discussed the requirement again and don't need it anymore. Actually this seems also to be an anti pattern to use the IRS + EDC to get data out of our own twins.
Can be closed from my point of view (closing is up to you :)).

Wontfix


storage kept hot when should be cold

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (8adf428 2023-05-08T00:12:01.390438000Z)
What command(s) is the bug in?
No response
Operating System
macOS (Apple Silicon)
Describe the bug
SLOAD/SSTOREs are hot after their first load in the test. I would think that hitting a contract would be a signal to invalidate the storage cache (make all storage slots cold) since that would indicate a separate transaction. However, what happens is SLOAD/SSTOREs are kept hot over the course of a test, presumably because it is a single function. Is there a way to work around this, or is this a bug?

i have tried moving the block timestamp forward to see if that helps, but it does not seem to

Hope to have the vm cheatcode for warming/cooling for proper simulations.

Right, slots are warm the whole time since each test is a single transaction. There is an issue for a vm.cool cheatcode here https://github.com/foundry-rs/foundry/issues/1340

vm.cool has been added here: https://github.com/foundry-rs/foundry/pull/5830
We also have the --isolate mode for improved gas accuracy to run a test in an isolated environment


[UI][FIX] Disabled Signup button for the users who already have the extension/the capability to use meshmap

Notes for Reviewers
This PR fixes #7155
Approach:

Fetched the capabiltiesRegistry from the global store.
Checked whether there exists an extension navigator for meshmap for the currently signed in user.
Finally disabling the signup button and the signup message.

Demo
https://user-images.githubusercontent.com/71918441/221029801-cb86f4ad-c704-4731-9881-58782cd8b20b.mov
Signed commits

[X] Yes, I signed my commits.

cc: @leecalcote

This is looking real good. @krishna9304, while disabling the card on the Extensions page, will you also change the button text from "Sign Up" to "Enabled"?

@MUzairS15 any thoughts on this one?

This is looking real good. @krishna9304, while disabling the card on the Extensions page, will you also change the button text from "Sign Up" to "Enabled"?

Sure, Will do that.

Thank you @krishna9304 🚀


Fix Broken GeneralAppPropertiesActivity UI test

This is a pull request raised for issue https://github.com/odk-x/tool-suite-X/issues/470
Reason for Fix:
The UI test for the settings screen was broken following a rework of the settings screen. As a result, the strings to be matched weren't referenced correctly and the position of the item to be clicked were out of order. this raised the need for some refactoring to fix the broken UI test.

Changes made to the GeneralAppPropertiesActivityTest class
1 Corrected the referenced to the matched strings in the following tests:
  -whenOpenDocumentationScreenIsClicked_launchUrl()
 -checkIfDeviceSettingScreen_isVisible()
 -checkIfTableSpecificSettingScreen_isVisible()
 -checkIfEnableUserRestrictionScreen_isVisible()
 -whenResetConfigurationScreenIsClicked_launchResetConfigurationDialog()
 -checkIfVerifyUserPermissionScreen_isVisible()

2 corrected the position of item on the list for
 -whenOpenDocumentationScreenIsClicked_launchUrl()
 -checkIfDeviceSettingScreen_isVisible()
 -checkIfTableSpecificSettingScreen_isVisible()
 -checkIfEnableUserRestrictionScreen_isVisible()
 -whenResetConfigurationScreenIsClicked_launchResetConfigurationDialog()
 -checkIfVerifyUserPermissionScreen_isVisible()

@Redeem-Grimm-Satoshi awaiting your review

Hi @Redeem-Grimm-Satoshi I've  added the screenshot(s) as requested.

Looks good to me


Cloudflare DNS challenge times out after 2 minutes

1. What version of Caddy are you using (caddy -version)?
0.11.1
2. What are you trying to do?
Use DNS challenges with Cloudflare.
3. What is your entire Caddyfile?
Example:
www.domain.com domain.com {
        gzip
        tls {
        dns cloudflare
        }
        proxy /site1 IP:port {
                transparent
                }
}

site2.domain.com {
        tls {
        dns cloudflare
        }
        proxy / IP:port {
        transparent
        }
}

Caddy works fine when removing TLS/DNS tags and using HTTP challenges.
4. How did you run Caddy (give the full command and describe the execution environment)?
systemctl start caddy
(/usr/local/bin/caddy -log stdout -agree=true -conf=/etc/caddy/Caddyfile -root=/var/tmp)
CentOS, Caddy installed according to this.
5. Please paste any relevant HTTP request(s) here.

6. What did you expect to see?
DNS challenge passing.
7. What did you see instead (give full error messages and/or log)?
Activating privacy features… [INFO][sub.domain.com] acme: Obtaining bundled SAN certificate
[INFO][sub.domain.com] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz/…
[INFO][sub.domain.com] acme: Could not find solver for: tls-alpn-01
[INFO][sub.domain.com] acme: Could not find solver for: http-01
[INFO][sub.domain.com] acme: Trying to solve DNS-01
[INFO][sub.domain.com] Checking DNS record propagation using [DNS]
Caddy waits for two minutes, then restarts and does the same thing again.
The TXT is written to Cloudflare and remains there until it's removed manually.
8. How can someone who is starting from scratch reproduce the bug as minimally as possible?
Similar issue described here.
Lego has environment variables that seem to handle this problem.
Caddy forum discussion.

I got similar bugs too.  HTTPS works fine without Cloudflare.

Could either of you try from the latest on master? There may be some other issues, but it would be good to see if certs can be resolved

The issue remains, but the log looks different in 0.11.2, and directly lists the 2 minute timeout:
[INFO] [sub.domain.com] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz/XXX
[INFO] [sub.domain.com] acme: Could not find solver for: tls-alpn-01
[INFO] [sub.domain.com] acme: Could not find solver for: http-01
[INFO] [sub.domain.com] acme: use dns-01 solver
[INFO] [sub.domain.com] acme: Preparing to solve DNS-01
[INFO] cloudflare: new record for sub.domain.com, ID [X]
[INFO] [sub.domain.com] acme: Trying to solve DNS-01
[INFO] [sub.domain.com] acme: Checking DNS record propagation using [DNS]
[INFO] Wait [timeout: 2m0s, interval: 2s]
[INFO] [sub.domain.com] acme: Waiting for DNS record propagation.

Tried 0.11.3 too, no change.
For completeness, before Caddy restarts it says "[INFO] [sub.domain.com] acme: Cleaning DNS-01 challenge".

@mholt any ideas?

Just built 0.11.3 myself and can't replicate the issue.
whitestrake in ~ at kairos is 🐳 v18.09.1
➜ dc exec caddy caddy -version
Caddy 0.11.3 (+2ea544e Tue Feb 05 23:27:44 UTC 2019) (unofficial)
1 file changed, 2 insertions(+)
caddy/caddymain/run.go

(the modifications are for http.git and tls.dns.cloudflare)
caddy_1  | Activating privacy features... 2019/02/05 23:33:38 [INFO][FileStorage:/root/.caddy] Started certificate maintenance routine
caddy_1  | 2019/02/05 23:33:39 [INFO] acme: Registering account for<EMAIL_ADDRESS>caddy_1  | 2019/02/05 23:33:39 [INFO] [kairos.whitestrake.net] acme: Obtaining bundled SAN certificate
caddy_1  | 2019/02/05 23:33:40 [INFO] [kairos.whitestrake.net] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz/eG0enmAnm8wl0JblKbRa7z897g_tA8BXOgIs4bVCrA8
caddy_1  | 2019/02/05 23:33:40 [INFO] [kairos.whitestrake.net] acme: Could not find solver for: tls-alpn-01
caddy_1  | 2019/02/05 23:33:40 [INFO] [kairos.whitestrake.net] acme: Could not find solver for: http-01
caddy_1  | 2019/02/05 23:33:40 [INFO] [kairos.whitestrake.net] acme: use dns-01 solver
caddy_1  | 2019/02/05 23:33:40 [INFO] [kairos.whitestrake.net] acme: Preparing to solve DNS-01
caddy_1  | 2019/02/05 23:33:41 [INFO] cloudflare: new record for kairos.whitestrake.net, ID 255d406db72367697fba415cba7d8daf
caddy_1  | 2019/02/05 23:33:41 [INFO] [kairos.whitestrake.net] acme: Trying to solve DNS-01
caddy_1  | 2019/02/05 23:33:41 [INFO] [kairos.whitestrake.net] acme: Checking DNS record propagation using [<IP_ADDRESS>:53]
caddy_1  | 2019/02/05 23:33:41 [INFO] Wait for propagation [timeout: 2m0s, interval: 2s]
caddy_1  | 2019/02/05 23:33:41 [INFO] [kairos.whitestrake.net] acme: Waiting for DNS record propagation.
caddy_1  | 2019/02/05 23:33:43 [INFO] [kairos.whitestrake.net] acme: Waiting for DNS record propagation.
caddy_1  | 2019/02/05 23:33:46 [INFO] [kairos.whitestrake.net] The server validated our request
caddy_1  | 2019/02/05 23:33:46 [INFO] [kairos.whitestrake.net] acme: Cleaning DNS-01 challenge
caddy_1  | 2019/02/05 23:33:47 [INFO] [kairos.whitestrake.net] acme: Validations succeeded; requesting certificates
caddy_1  | 2019/02/05 23:33:48 [INFO] [kairos.whitestrake.net] Server responded with a certificate.
caddy_1  | done.
caddy_1  | https://kairos.whitestrake.net
caddy_1  | 2019/02/05 23:33:48 https://kairos.whitestrake.net
caddy_1  | http://kairos.whitestrake.net
caddy_1  | 2019/02/05 23:33:48 http://kairos.whitestrake.net

@sfkpmr:
I have seen in the past people encountering this issue with some domains but not others. If you have another domain to test with, I'd suggest that (you can get free short-renewal .tk domains).
You could also open your Cloudflare dashboard and look at the domain's DNS records while this challenge is happening to double check that the record is being added. If you can see it in your dashboard, you can get your Cloudflare nameserver and ensure it's responding properly by running dig @[NAMESERVER] _acme-challenge.subdomain.example.com txt (replace [NAMESERVER] as appropriate).

@sfkpmr What is the domain name that has the issue?

@whitestrake @magikstm
It's a .co domain, could that be the issue?

I highly doubt the TLD itself is the issue.
The thing I mentioned was just Cloudflare being on the fritz for some specific domains on its service, i.e. working for bar.example.com but not for foo.example.com.
I assume magikstm was asking after the actual domain name, so that we can investigate it for any discrepancies that might contribute to the issue.

It's wallen.co

Could it be a misconfiguration because it uses the Cloudflare certificate and not the Let's Encrypt one?
https://crt.sh/?q=wallen.co&dir=^&sort=1&group=none
https://www.geocerts.com/ssl-checker
Could you revoke the Cloudflare ones, use them explicitly or use the Let's Encrypt one explicitly?

I think you may need to adjust your TLS to force it to use your Cloudflare certificate:
tls ../cert.pem ../key.pem
Or
tls {
    load /www/certificates
}

https://caddyserver.com/docs/tls

Could you revoke the Cloudflare one, use it explicitly or use the Let's Encrypt one explicitly?

I've disabled Cloudflare's SSL and will try again tomorrow. I assume Geocerts should flip to Let's Encrypt/nothing.

Maybe I can add something to this ticket. I have to domains example-a.com and example-b.org. example-b.org has a wildcard (*) CNAME record that points to example-a.com as well as CNAME example-b.org pointing to example-a.com. Here's an excerpt from the zone file
[...]
;; CNAME Records
*.example-b-org.	120	IN	CNAME	example-a.com.
example-b-org.	120	IN	CNAME	example-a.com.

The zone file for domain example-a.com is this:
;; A Records
*.example-a.com.	120	IN	A	<IP_ADDRESS>
example-a.com.	120	IN	A	<IP_ADDRESS>

I can issue certificates for *.example-a.com but not for *.example-b.org. Here's part of the logfile:
2019/02/28 15:15:53 [INFO] [foo.example-b.org] acme: Trying to solve DNS-01
2019/02/28 15:15:53 [INFO] [foo.example-b.org] acme: Checking DNS record propagation using [<IP_ADDRESS>:53]
2019/02/28 15:15:53 [INFO] Wait for propagation [timeout: 2m0s, interval: 2s]
2019/02/28 15:15:53 [INFO] [foo.example-b.org] acme: Waiting for DNS record propagation.
2019/02/28 15:15:55 [INFO] [foo.example-b.org] acme: Waiting for DNS record propagation.
2019/02/28 15:15:57 [INFO] [foo.example-b.org] acme: Waiting for DNS record propagation.
[...]
2019/02/28 15:15:59 [INFO] [foo.example-b.org] acme: Waiting for DNS record propagation.
2019/02/28 15:17:54 [INFO] [foo.example-b.org] acme: Cleaning DNS-01 challenge
2019/02/28 15:17:55 http: TLS handshake error from <IP_ADDRESS>:35810: [foo.example-b.org] failed to obtain certificate: acme: Error -> One or more domains had a problem:
[foo.example-b.org] time limit exceeded: last error: NS erin.ns.cloudflare.com. did not return the expected TXT record [fqdn: example-a.com., value: ****]: ca3-****
2019/02/28 15:17:55 http: TLS handshake error from <IP_ADDRESS>:35808: no certificate available for 'foo.example-b.org'
2019/02/28 15:23:29 http: TLS handshake error from <IP_ADDRESS>:40520: hostname '' does not qualify for certificate

So it actually picks up on example-a.com (see third line from bottom)?

I did more testing and when I remove the CNAME record from example-b.org that points to example-a.com and enter the IP address as A record, everything works fine. So this seems like a bug in the cloudflare dns plugin.

@riker09 Now that you mention it, you are probably right (not in the plugin itself exactly, but in the cloudflare provider in lego which has the actual logic) -- I think I've heard of this before, but I haven't looked into the issue, but I know that CNAME can be problematic for some reason. Maybe best to continue this in the lego package.


Bug fixes env pathing and file extentions

Add fixes that address https://github.com/jmtsuji/rotary/issues/61 and https://github.com/jmtsuji/rotary/issues/62

Moved the rotary conda environment directory to the database directory.
Fastq file extension checks are now compatible with fastq.gz files.
Check for both fq and fastq in rotary init.
Created unified function for checking if a file is a fastq file.

@jmtsuji  If you accept, I will merge this into the development branch.

Looks good to me -- feel free to merge these changes.


build_wincrypt_test.c: Fix compilation with MSVC

uses #pragma message instead of #warning with MSVC
Fixes issue https://github.com/openssl/openssl/issues/20805

This pull request is ready to merge

Merged to master branch. Thank you for your contribution.


ConvertMemoryOps should not use cf dialect

Doing so is likely to break invariants that the scf dialect expects. In particular, when handling a masked load or store within a scf.for loop, ConvertMemoryOps would create multiple blocks within that loop, resulting in errors of the form
'scf.for' op expects region #0 to have 0 or 1 blocks

I have added a test to exercise the lowerToScalar{Loads,Stores} codepaths. I have not included the for loop in those tests because I have already removed "cf" as a legal dialect for the ConvertMemoryOps pass, which should prevent future errors.

Yep, I noticed the atomic ops lowering uses the cf dialect too. I'll look into fixing that too.


#7 add root package.json with start:all command to run both BE and FE instances

Issue: #7
Reason: was not implemented yet
Changes:

create root package.json
add scripts to run FE / BE and both of them

Usage: <project_root>: npm run start:all

Hey @eLeontev , thanks a lot for your valubale contribution.
Following code will be really helpful & hence, merging the same.


Ignore | Just testing [travis]

Warnings

:warning:

This PR modified the server but none of the service tests. That's okay so long as it's refactoring existing code.

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @RedSparr0w!

  Generated by :no_entry_sign: dangerJS


calling .focus() on a node that is currently off-screen breaks the view

Describe the Bug
calling .focus() on a node that is currently off-screen breaks the view. App becomes non-responsive.
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
programatically call .focus() on a node that is off-screen
Expected behavior
I am not sure what the right behaviour is.
Screenshots or Videos
No response
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]
macos
chrome

Additional context
No response

it is very hard to get around.
Here is the in-ellegant solution that finally seems to work
const offscreen = function(el) {
  var rect = el.getBoundingClientRect();
  return (
           (rect.x + rect.width) < 0
             || (rect.y + rect.height) < 0
             || (rect.x > window.innerWidth || rect.y > window.innerHeight)
         );
};

    useEffect(()=>{
      if(data.isNewNode){
        data.isNewNode = false

        // if the node is offscreen, focussing it will break react-flow so we must center it as smoothly as possible
        if(offscreen(ref.current)){
          const {x, y} = ref.current.getBoundingClientRect() // get the dom coordinates
          const zoom = flow.getZoom() // capture the current zoom
          let res = flow.project({x, y}) // translate it to the react-flow coordinate system
          setTimeout(()=>{
            // delay this so its had a chance to settle
            flow.setCenter(res.x, res.y, {zoom})
          }, 100)
          setTimeout(()=>{
            // delay this so more its had a chance to settle
            textInputRef.current.focus()
          }, 200)
        } else {
          textInputRef.current.focus()
        }
      }
    },[data.isNewNode])

Hay @marchingband . I am not sure how we can fix this, but we will look into it. It's a browser feature but it breaks React Flow :/

Thanks for the responses.
I am working on an ed-tech app that needs to be usable by non-sighted users. I have key commands to traverse the graph and create new nodes. The nodes all contain editable text areas. When the user creates a new node, it automatically gets focus. New nodes can easily end up being created off-screen, which is when the bug shows up.
The ideal solution would be ReactFlowInstance.focus(node) to achieve similar to what I implemented in my (sketchy) solution.
The next best would be ReactFlowInstance.show(node) which would synchronously pan to show the node, in the least invasive way possible, so I can call .focus() on it within a hook without having to wait for the rerender with setTimeout().
I'm not sure that either of these are possible or reasonable, but to be honest I'm not clear on what would work best from the library perspective.

@bcakmakoglu I can try that. Perhaps I need to update? I have
export declare type FitViewOptions = {
    padding?: number;
    includeHiddenNodes?: boolean;
    minZoom?: number;
    maxZoom?: number;
    duration?: number;
};

Wouldn't I still need to wait for a rerender before I `.focus()' the node?

@marchingband that works! You can pass nodes, or just an array with objects that only have an id.

Could you solve this? Did you try to do .focus({ preventScroll: true }) ?

@marchingband could you try if position: fixed for .react-flow fixes your issue?

related to #3817

duplicate of #3483


Instant.MIN and Instant.MAX should not be the defaults - fails on query

the current default params for start and End time https://github.com/bekk/db-scheduler-ui/blob/2239dc371305d61750d77a75b0f686b34905ff82/db-scheduler-ui/src/main/java/no/bekk/dbscheduler/ui/model/TaskRequestParams.java#L58-L59 fail when queried with postgres - will create pr with possible better defaults
Caused by: org.postgresql.util.PSQLException: ERROR: timestamp out of range: "169108098-07-04 06:51:43+02"

proposal coming with
startDate now() - 50 day
endDate now() + 50 days

Works for me now 🚀


Use Checkpoints instead of ProvenHeadersActivationHeight

After lot of discussions and design changes we agreed on activating Proven Header since genesis.
This mean we'll store PH for every block and we are able to serve PH at any height.
To speedup IBD, we are going to use CheckPoints when available, and we are synching in the legacy way with normal headers and bypassing some validation rules.
In case a peer supports Checkpoints, Last Checkpoint act as previous ProvenHeadersActivationHeight in the sense that since that height it accepts only Proven Headers.
The required changes are to remove all occurrance of ProvenHeadersActivationHeight using Checkpoints  instead.

Memorandum:

remove all occurrance of ProvenHeadersActivationHeight using Checkpoints instead
improve ProvenBlockHeaderRepository to handle reorgs
convert the header of any legacy blocks received pre-checkpoint into ph header and store it

This is now tracked here https://github.com/stratisproject/StratisBitcoinFullNode/issues/2464


Fix UG inconsistencies and missed details.

Summary of UG changes:
#202 - Closed as unable to duplicate error.
#203 - Remove [ ] brackets,
#206 - Added names are case insensitive,
#210 - Changed to true / false , remove use of word 'BOOLEAN'
#217 - Added:

The first option must be valid.
After the first valid option, any other invalid options that is not stated below will be ignored.

#219- Added full name to tagTask and untagTask
#220 - Removed the extra space.
#222 - Added full name to tagTask and untagTask
#224 - Change instructions for clear to 'delete' instead of using 'clear'
#227 - Added:

The employee you are tagging must be in the current displayed employees list. (same for untagTask)

#229 - Added: lightbulb after all examples, similar to addTask. (HHmm one)
#231 - Solve by 222 and 219.
#232 - Closed, able to chain commands, even gave examples.
#233 - Added a note for addEmployee, addTask
#234 - Added:

For creation of Tasks, ManageEZPZ will allow past deadlines and events to be added for the Managers to track. (Lightbulb)

#236 - Edited the lightbulb to cover HHmm format and restrictions.
#240 - Added an e.g. for findEmployee

Codecov Report

Merging #248 (f9b092a) into master (c5af4a1) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #248      +/-   ##
============================================
- Coverage     51.81%   51.58%   -0.23%
+ Complexity      597      595       -2
============================================
  Files           107      107
  Lines          2484     2489       +5
  Branches        285      286       +1
============================================
- Hits           1287     1284       -3
- Misses         1137     1145       +8
  Partials         60       60

Impacted Files
Coverage Δ

.../manageezpz/logic/commands/AddTodoTaskCommand.java
0.00% <0.00%> (-9.10%)
:arrow_down:

...c/main/java/manageezpz/model/task/Description.java
70.00% <0.00%> (-2.73%)
:arrow_down:

...ava/manageezpz/logic/commands/EditTaskCommand.java
0.00% <0.00%> (ø)

...ava/manageezpz/logic/commands/FindTaskCommand.java
100.00% <0.00%> (ø)

...ava/manageezpz/logic/parser/AddressBookParser.java
55.17% <0.00%> (ø)

...ageezpz/logic/parser/AddEmployeeCommandParser.java
100.00% <0.00%> (ø)

...ageezpz/logic/parser/AddTodoTaskCommandParser.java
0.00% <0.00%> (ø)

...geezpz/logic/parser/AddEventTaskCommandParser.java
0.00% <0.00%> (ø)

...zpz/logic/parser/AddDeadlineTaskCommandParser.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5af4a1...f9b092a. Read the comment docs.


Feature/erc20 staking

This pull request is a complete submission for https://gitcoin.co/issue/casper-network/gitcoin-hackathon/9/100026583

Wrong destination, please abandon this PR, will be deleted.


Issue loading binary onto stm32f3discovery

Hello, i tried to follow the guide in the rust book as well as possible, but i'm unable to load binaries on the microcontroller.
I already upgraded to the latest firmware with the tool from the st website.
This is what i'm doing in gdb: (i also ran monitor reset halt prior to this in gdb to make a "undefined debug reason 7 - target needs reset" error go away in openocd.)
~/Documents/programmeren/rust/micro/app : arm-none-eabi-gdb -q target/thumbv7em-none-eabihf/debug/examples/hello
Reading symbols from /home/frederik/Documents/programmeren/rust/micro/app/target/thumbv7em-none-eabihf/debug/examples/hello...done.
(gdb) target remote :3333
Remote debugging using :3333
0x08003cc8 in ?? ()
(gdb) load
Loading section .vector_table, size 0x400 lma 0x0
Loading section .text, size 0x2064 lma 0x400
Load failed

I'm sorry if this isn't the right place to post this.

Just to make sure the issue is generally wrong instructions in the book I tried the instructions step-by-step and it does work for me:
# arm-none-eabi-gdb -q target/thumbv7em-none-eabihf/debug/examples/hello
Reading symbols from target/thumbv7em-none-eabihf/debug/examples/hello...done.
(gdb) target remote :3333
Remote debugging using :3333
Reset () at /Users/egger/.cargo/registry/src/github.com-1ecc6299db9ec823/cortex-m-rt-0.6.4/src/lib.rs:494
494	    __pre_init();
(gdb) load
Loading section .vector_table, size 0x400 lma 0x8000000
Loading section .text, size 0x2032 lma 0x8000400
Loading section .rodata, size 0x604 lma 0x8002440
Start address 0x80021f4, load size 10806
Transfer rate: 15 KB/sec, 3602 bytes/write.
(gdb) target ext :3333
A program is being debugged already.  Kill it? (y or n) y
Remote debugging using :3333
Reset () at /Users/egger/.cargo/registry/src/github.com-1ecc6299db9ec823/cortex-m-rt-0.6.4/src/lib.rs:494
494	    __pre_init();
(gdb) load
Loading section .vector_table, size 0x400 lma 0x8000000
Loading section .text, size 0x2032 lma 0x8000400
Loading section .rodata, size 0x604 lma 0x8002440
Start address 0x80021f4, load size 10806
Transfer rate: 15 KB/sec, 3602 bytes/write.

I configured my memory.x file wrong, and i was using the wrong gdb version, i needed the gdb for arm (arm-none-eabi-gdb).
The "monitor reset halt" is also not necessary

i have the exact same issue. It appears the memory offsets in my memory.x are being ignored.
How exactly is memory.x used?
I don't specify it anywhere. Is it loaded by some convention?
memory.x is difficult to 'google', as the search engine assumes I want to know about the gdb 'x' command.

It's copied in to your build output tree with build.rs, and included by the cortex-m-rt linker script, which is specified in the .cargo/config file.

I configured my memory.x file wrong, and i was using the wrong gdb version, i needed the gdb for arm (arm-none-eabi-gdb).

Thanks! My memory.x was wrong too but I could use gdb-multiarch (ubuntu 18.04). I think I had to use monitor reset halt once.
Just for reference in case someone else comes here, here is the memory.x for my stm32f103c8t6:
MEMORY
{
  /* NOTE 1 K = 1 KiBi = 1024 bytes */
  FLASH : ORIGIN = 0x08000000, LENGTH = 128K
  RAM : ORIGIN = 0x20000000, LENGTH = 20K
}


Update firestormos to <IP_ADDRESS>634

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

BTW, FirestormOS project lists the official SHA1 sum as:
F5626947FB6DE7432D85D1AE0426C831957B8089
running shasum on the cached .dmg results in:
f5626947fb6de7432d85d1ae0426c831957b8089

Thanks for the PR!


Added gaps at the end of the storage of each contract.

Fixes #13.
Despite IERC721 and friends being contracts and not interfaces (due to a Solidity limitation), I kept this out of those, since they should be used as interfaces.

I'd say we are fine with 50 slots per contract :-)

I'd say the opposite, better keep Initializable as clean as possible
On Tue, Oct 9, 2018 at 6:34 PM Nicolás Venturo<EMAIL_ADDRESS>wrote:

@nventuro commented on this pull request.
In contracts/Initializable.sol
https://github.com/OpenZeppelin/openzeppelin-zos/pull/29#discussion_r223775366
:

@@ -46,4 +46,6 @@ contract Initializable {
assembly { cs := extcodesize(address) }
return cs == 0;
}

uint256[50] private ______gap;

Yes - should we add this there?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/OpenZeppelin/openzeppelin-zos/pull/29#discussion_r223775366,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAaOJAB2z0lTjWlC_EEnbfmUhy0WBClKks5ujNAlgaJpZM4XNZRq
.

Any specific reason to not add the gap? I wouldn't discount the possibility of Initializable becoming more complex and needing more storage.

Pull Request Test Coverage Report for Build 67

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.758%

Totals

Change from base Build 66:
0.0%

Covered Lines:
577

Relevant Lines:
577

💛  - Coveralls

I was going to suggest backwards compatibility with the Initializable from 1.x, but that one used a single boolean variable, while the current one uses two. And this exactly proves your point. So, can you send a PR to zeppelinos to add the gap there as well?

Sure thing! Opened https://github.com/zeppelinos/zos/pull/215


[storage-file-datalake] Remove unused dev dependency "nock"

Dependency was added in #6337 but it appears to be unused. I do not see any references to nock in the storage-file-datalake sources (except for the test recordings, which I believe are a special case and do not require a dev dependency in the runtime package).

@XiaoningLiu: Can you please review?

I believe it was unintentionally copied from the other storage package and was never removed since this package might have been in development while the others have it removed.


Add PHP 8.2 support to 3.x branch

This is a re-roll of https://github.com/openspout/openspout/pull/101 against the 3.x branch, allowing users to have a version that supports both PHP 7.4 (the last version compatible with the old Box-maintained lib) and 8.2, vs. needing an intermediate runtime version step (7.4 -> 8.1, then lib version 3.x -> 4.x, then 8.1 -> 8.2).

Duplicate of https://github.com/openspout/openspout/issues/110


Fix: grpc batch out-of-order data streams

Proposed Changes:

Fix grpc batch out-of-order data streams

Which issue(s) this PR fixes:

Fixes #470
Additional documentation:

@ethfoo  PTAL!


new message bubble

how can I connect the bubble manager from my GCM service class.Its not showing when I tried to initialize it from the service.

Hi @karthika89, I'm not sure but maybe you have a problem with the Contexts.

sorry I made it working inside another service and it's working thanks


fix spawn placement

Fixes incompatabilities that arise when any other mod adds SpawnPlacments

Didn't notice the PR and had already made such changes, I thank you for them. Will still probably deal w/ the conflicts as it does make some of the code a little cleaner in the process too.


Gift sats: showing "undefined" text at the time of gift acceptance.

If I create a gift and sent it to f&F by doing skip contact then in that case on sender side it does not show the wallet name on gift card and on receiver side gifft card it is showing "Undefined" text

Instead of this message, there is text "undefined".

** On Sender side:**

https://user-images.githubusercontent.com/62699947/156322162-c609de7a-50db-4ec8-a58a-7a9e56d4e0aa.mp4

Check all the messages of gift cards.

On Receiver side:

https://user-images.githubusercontent.com/62699947/156322467-0dae6151-8912-48fa-bed5-05b6ef77324f.mp4

Verified this issue on dev app v2.0.70(450)