S3 returns No results. when specifying an invalid file_format

Describe the bug
When using the S3 connector, specifying a file_format that is invalid for the files being queried returns No results. instead of returning an error.
To Reproduce
Steps to reproduce the behavior:

Configure a dataset using a file_format parameter that is different to the actual stored files
Observe behavior

Expected behavior
The Runtime should return an error when encountering a file in the specified path that differs from the specified file_format.
Runtime Details
Spicepod
version: v1beta1
kind: Spicepod
name: spicepod
datasets:
  - from: s3://spiceai-demo-datasets/taxi_trips/2024/
    name: taxi_trips
    params:
      file_format: csv

Have you tried this on the latest trunk branch?

[x] Yes
[ ] No

Related to https://github.com/spiceai/spiceai/issues/3556


Add null check to StringTransformer

If a class is defined after an instance of StringTransformer is registered,
the transform method will be called and passed a null className as the new
class is being defined. This will throw an exception and end the test so we
need to ensure the className is not null before the equality check.
Signed-off-by: Mike Zhang<EMAIL_ADDRESS>Fixes https://github.com/eclipse/openj9/issues/10504

Thanks @mikezhang1234567890 . The change looks good.


Add services metadata labels to consul labels

Signed-off-by: Julien Pivotto<EMAIL_ADDRESS>

Not sure how I can test it because we populate that on watch() and watch() is not run in unit tests

+65,452 −299
I am speechless.


Repeat option not working

What is your Quests version / build number (do not say "latest")?
3.6.3-b668
Describe the problem and how to replicate it. Any console errors to post using Pastebin.com?
I tried to do Daily quests with timer resetting for all players in same time. I was manipulating with start, end and repeat option but with no effect. I don't have any errors in console.
Cooldown is working fine in other quests but it's not what I really wanted.
If I set start date and repeat timer, when I finish quest I can't take it again because of finished state.
Also I tried different examples from others like here: https://github.com/FlyingPikachu/Quests/issues/390 or from Discord. None of them was working for me.
If applicable, can you provide an example quest from quests.yml using Pastebin.com?
It's a version for quicker tests in which I wanted reset after 1 minute timer.
https://pastebin.com/Prm7Dd3G

Your start date is set in the future, so the repeat won't take effect until that time. Set the start date to a past or current date/time to resolve the issue.

I changed date to: 25:1:2017:0:22:0:Etc/UTC (I tried many different dates and times) and problem still exists. I can take quest once and after it's finished I can't take it again as it's completed and can't be repeated.

I changed date to: 25:1:2017:0:22:0:Etc/UTC (I tried many different dates and times) and problem still exists. I can take quest once and after it's finished I can't take it again as it's completed and can't be repeated.

Thinking you may also need to set an end date, but I'll reopen this until I have the opportunity to test it.

I've tried with end date too. With it if I'm trying to take a quest it's saying all the time that I have to wait even if I'm trying just a second after it should be available so I can't take this quest at all.
Also it says 2 minutes instead of 60 seconds which I have in "repeat".

Exmaple quest: https://pastebin.com/0q7avjm0

I can confirm that this is happening for me as well. Users have reported being unable to repeat quests.
I used the format we discussed on Discord:
  Daily Pumpkins:
    name: Pumpkins for the proles (Daily)
    planner:
      start: 30:2:2018:19:0:0:SystemV/EST5
      repeat: 86400
    npc-giver-id: 24
    ask-message: <darkgreen>We need 5 stacks of pumpkins today to feed the people,
      can you help?
    finish-message: <darkgreen>Thank you kindly, your efforts are most appreciated!
    stages:
      ordered:
        '1':
          items-to-deliver:
          - name-pumpkin:amount-320
          npc-delivery-ids:
          - 24
          delivery-messages:
          - Thanks, keep it up!
    rewards:
      money: 50
      quest-points: 1

I'll see if I can get on tonight and test it personally to produce an output screenshot, we'll see how I'm doing after the pub.

Use http://ci.ac3-servers.eu/job/Quests/697/ once available to resolve the issue.
Please note that using the editor now requires you set a start and end date before setting a repeat option. If you've previously set a repeat without a start/end, you'll need to go back in and set a start/end.
Also note that the repeat option is based on the start date, so if you set a repeat for 24 hours and your quest starts at 3:00pm, it'll be available the next day at 3:00pm as well.

For clarity - does this require a start and end? I suppose I could just set the end date to 2999 or something, but this feels like a dirty workaround and might not be intuitive for users who want to have indefinitely-repeatable quests.
The repeat matching the start time is perfect and should be the expected behavior, thank you!

Yes, because the end is used to calculate the duration of the quest (so when it becomes available again, the plugin knows how long to keep it active for). I hadn't considered what might happen if someone were to set a start-to-end time longer than the repeat time, but you're welcome to try it and see what happens!

Sorry, is the end time supposed to be 24 hours from the start time, with a 24-hour repeat, if we'd like the quest to repeat every 24 hours? I'm just trying to set up daily repeating quests.

24 hours was an example, but yes that's what you'd do if you want a daily quest. That said, the repeat operates in seconds, so for 24 hours you'd use a value of 86400 seconds.

Right, was just writing for simplicity. So to recap:
Start date X
End date X+24h
Cooldown 86400
This together ought to set a quest to be repeatable every 24h, yeah?

Well no, you don't need to add anything to the end date. Just set the repeat option for 24 hours.
Let's say you want your quest to be available for an hour each day, starting at 3:00pm. It'd look like:
Start 3:00pm
End 4:00pm
Repeat 24h / 86400s
The cooldown is if you want a player to be unable to take the quest again for a certain amount of time. So if you want individual players to only be able to complete the quest once a week, you could set it to 604800s.

Resolved on Discord. Anyone else reading should direct their question there as well:
https://discordapp.com/invite/d56CQ6e

For anyone checking this issue later, a quest that can be taken once per day, each day, should use a format like this:
  Daily Fishing:
    name: Demonstrate your fishing skills (Daily)
    planner:
      start: 30:2:2018:19:0:0:SystemV/EST5
      end: 30:3:2018:19:0:0:SystemV/EST5
      repeat: 86400


Weird default suggestion list

Original issue: https://github.com/atom/autocomplete-plus/issues/502
In every file (even plain text), autocomplete suggests a list of items that have no use for me when I type a dot:

They appear only when atom-ctags is enabled, thus I suspect they are introduced to the autocomplete suggestion list by this package.

Having the same problem

+1
looking at the tags file, this data definitely comes from there. Must be something in the way atom-ctags is parsing it?

Same here. Would also be nice if the provider set correct types for suggestions so we get those fancy icons in the suggestions list.

Some one who can tell me how to reproduce this issue? I type dot in css file and not reproduce this issue? Did I missing something?

@yongkangchen I think it may have something to do with what version/type/binary of ctags that is installed or something, as I'm having the same problem and in the atom dev tools console this is the error: repetition-operator operand invalid (i've pasted the full error below).  I used homebrew to install ctags, not sure if the version they use isn't the same?
atom-ctags: command error, ctags-darwin: Warning: regcomp with[ 	]+([^;]+)[ 	]*?;: repetition-operator operand invalid
ctags-darwin: Warning: regcomp extends[ 	]+['"]([^'"]+)['"][ 	]*?;: repetition-operator operand invalid
ctags-darwin: Warning: regcomp use[ 	]+base[ 	]+['"]([^'"]+)['"][ 	]*?;: repetition-operator operand invalid
ctags-darwin: Warning: regcomp use[ 	]+parent[ 	]+['"]([^'"]+)['"][ 	]*?;: repetition-operator operand invalid
ctags-darwin: Warning: regcomp Mojo::Base[ 	]+['"]([^'"]+)['"][ 	]*?;: repetition-operator operand invalid
ctags-darwin: Warning: regcomp ^[ 	]*?use[ 	]+([^;]+)[ 	]*?;: repetition-operator operand invalid
ctags-darwin: Warning: regcomp ^[ 	]*?require[ 	]+((\w|\:)+): repetition-operator operand invalid
ctags-darwin: Warning: regcomp ^[ 	]*?has[ 	]+['"]?(\w+)['"]?: repetition-operator operand invalid
ctags-darwin: Warning: regcomp ^[ 	]*?\*(\w+)[ 	]*?=: repetition-operator operand invalid
ctags-darwin: Warning: regcomp ^[ 	]*?our[ 	]*?[\$@%](\w+): repetition-operator operand invalid
ctags-darwin: Warning: regcomp ^[ 	]*+([A-Za-z0-9_]+)(;|\([^)]*:[^)]*\)): repetition-operator operand invalid
 /Users/trosta/Work/code.espn.com/sRPMBut/.tags/Users/trosta/.atom/packages/atom-ctags/lib/tag-generator.coffee:81 stderr

@AWTrost I installed via Preferences menu, currently on version 4.2.0 with the same problem so it's definitely an issue with the current version.

As far as reproducing it goes, I disabled all my non-core packages and just started writing a python script:

I just reinstalled, and my autocomplete still looks the same... But the goto/return from declaration commands work just fine.

any update on this topic?

Im agreed with @AWTrost, probably it is something to do with the binary or ctags. Im having this problem on fedora, ctags installed from the fedora repo

Any news with this one?

+1

Fixed by f6d69910fe0408bafccb1b589fda8dbb330771b3


e2e flake: wrong id counter

From failure logs:
time="2016-10-15T04:56:51Z" level=info msg="Running members: test-etcd-cxtay-0000,test-etcd-cxtay-0001,test-etcd-cxtay-0002"
time="2016-10-15T04:56:51Z" level=info msg="Expected membership: test-etcd-cxtay-0002,test-etcd-cxtay-0000,test-etcd-cxtay-0001"
time="2016-10-15T04:56:51Z" level=error msg="fail to add new member (test-etcd-cxtay-0002): etcdserver: Peer URLs already exists"
time="2016-10-15T04:56:51Z" level=info msg="Finish reconciling"
time="2016-10-15T04:56:51Z" level=error msg="cluster (test-etcd-cxtay) fail to reconcile: etcdserver: Peer URLs already exists"

I sort of get what's happening here.
Our assumption on id counter is that if a pod is created counter should increment. This wasn't always true previously because we have wait ready logic in CreateEtcdPod().
It seems fine now, but I will change the code to make it obvious.

Closing this right now since it's not a bug anymore

Our assumption on id counter is that if a pod is created counter should increment. This wasn't always true previously because we have wait ready logic in CreateEtcdPod().

Can you show me the previous code?

https://github.com/coreos/etcd-operator/blob/46dbc28ac988ff63cc236a1c41be20a3ea2f9109/pkg/util/k8sutil/k8sutil.go#L157-L168

i see. thanks.


Merge branch-24.10 into main [skip ci]

Change version to 24.10.1
Note: merge this PR with Create a merge commit to merge

build

failed only the known spark400 issue. Will ignore the failure and start building 24.10.1 release candidate


Manachers algo Added #758

#785 done in java
Manacher’s Algorithm – Linear Time Longest Palindromic Substring added
Please Review

Hey do look at the review comments

Describe what n is.

Thanks for Reviewing it and Sorry for Delay from my side, @rish-singhal
New Changes Done!

Great!


Send all metadata keys to update run metadata

Send all metadata keys to update run metadata
This update is to address missing run metadata due to concurrent update run metadata updates.

No longer clearing the buffered metadata on flush metadata, sending all historical + new keys on every flush
Flushing both wandb and model init time together on after_load

Waiting on merging this because there are likely to be issues with duplicated run events if we do not delete run event keys from update run metadata

@jjanezhang can we close this PR?


Flaky Test: RazorGenerate_BuildsIncrementally

This failed on Travis (Mac): https://travis-ci.org/aspnet/Razor/jobs/322388123

@pranavkm / @mkArtakMSFT - any work planned here in the near future?

Verifying if the issue is fixed on dotnet-ci's OSX agents with https://github.com/aspnet/Razor/pull/2254. Might need more work if it isn't.


Processing large number of files - run in parallel or filter out some files?

Does anybody have experience or ideas for speeding up this process? We successfully ran the script on our development server and it processed about 5 files/second. On our live server we have 10 million+ files which at that rate will take 19 days of processing to complete.  So I wonder if there is a fast way to skip some older files (or conditionally based on some other table column) or is it safe to run the script in parallel on multiple hosts? Thanks.

Hey Joe, I was in a similar situation. I decided to write my own version so I got a better idea on what I'm moving, and how long to take. I ironed out all the timeout/memory leaks. Try it out:
https://github.com/BuffMcBigHuge/Mongo-Migrator


Feature List for Marketing

Elegantt data. What's this?

➤ Matt commented:
Big Tickets

NavTech Transactions
Multi Sig wallets (multiple people share a wallet and a certain % of them have to agree on transactions)
Changelly integration
Multi-platform (Android, iOS, Linux, OSX, Web, Windows, Chrome App)
Wallet encryption

Small Fish

Address book (you can save addresses)
QR Scanner
Seed phrase back up

➤ Craig MacGregor commented:
can use fingerprint to unlock on moblie


[Bug]: the send message text is not aligned to center

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug

the send message in yellow box is not aligned to center
Expected behavior
it must be aligned to center to have users positive review
Add ScreenShots
No response
On which device are you experiencing this bug?
No response
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC-EXT contributor
[X] I'm a HACKTOBERFEST contributor
[X] I have starred the repository

@laxmikandivalasa, This is a good issue but, we can't assign for small issues please see more bugs and raise an issue again.
Thank you


Japanese 4.0 Deed page needs update

Hi Matt!
I got the message below from CC Japan. It seems they made some change to the Japanese 4.0 deed on transifex and wanted to get it published. Could you take a look and help? Thanks!!!

This is Tomo from CC Japan. I have a quick question.
Is there any schedule for porting transifex file to the
CC's web site? We recently received some error report
(error in translation, that is), and I wondered when the
fix will be reflected into the web page.

Best,
Soohyun

@robmyers Can you run the update-i18n script on the site? It's in the crontab (but commented out)

@soohyunpae This has been done.


Update ReadME - Include ReadtheDocs link

Hey guys we'll need to update the ReadMe so that includes the link to the ReadtheDocs page and instructions on how to access / read it :)

Nice looks like its posted thansk @chrisgqy


Set Up SQL Database Integration for Github Data

Set up PostgreSQL tables according to the specified schema.
expected a fully functional database setup that can store GitHub data effectively.

Are you done? @mario99logic  If so please close the ticket.

The PostgreSQL database setup has been completed and is fully functional. Closing this issue now.


Improve NLU for more detailed queries

Be able to subtract a type of entity from a query. Such as date, number, location, etc.
If it uses a tiers but Node.js, it should operate from the core and send the result object to modules via the child process parameters.
Otherwise, it should fully be implemented in the core itself.
I noted some following leads in this Trello card.

 🔧 Improve NLU for more detailed queries

Rasa integration?

Hello @Immortalin,
I do not plan to have a Rasa integration yet. But it does not mean I will not in the future.

If will make slot filling etc. easier as you can just delegate everything

In any case if you do decide to use Rasa, please make it modular, it seems that Rasa does not have any serious support for non-trivial morphology.

Snips-NLU perhaps?

@Immortalin looks like snips doesn't support languages with substantial morphology and morphophonology either.

Quick update for this topic:
I'm working under the nlu-improvement branch.
Leon is able to find several entities from a query thanks to node-nlp.
The Is It Down module is now using these entities instead of a custom regex to find the domain names (related to https://github.com/leon-ai/leon/issues/51).
I'll be working on the Trends package now to validate the feature, but I'll also need to dig into other topics regarding that improvement (such as locations and slot filling).
I'm note sure that will be in the 1.0.0-beta.2 release, but still, here is what may plan:

📝 Take a look at how to implement location entities with slot filling or for other purposes such as "add X in Y list"
✨ Dedicated modules flow

I finished this improvement. It'll be released in the 1.0.0-beta.2 version (cf. https://github.com/leon-ai/leon/commit/82ebbee568d1b8ccfacbe2a74e50afb01e9d9577).

The docs according to those changes has been published. Most of the essentials information can be found in this part.

@louistiti , the "this part" link in the previous post resolves to a 404 here. Could you fix this please? Thank you!

@louistiti , the "this part" link in the previous post resolves to a 404 here. Could you fix this please? Thank you!

Hi, sure, here you are: https://docs.getleon.ai/packages-modules#entities.


Curtain module

Hello,
I connected a ZIGBEE curtain modul (tuya QS-Zigbee-C01) to homey.
It is well recognized but when I ask to open or close the curtain,I get the message : could not get devise by id.
I remove and reinstall twice the modul, I stiill have the same results.
Is there something I can do to solve this issue ?
Thanks per advance for your advice

Is this still an issue?

Hello,
It's still an issue, but for our concern we are usinganother gateway to mange the curtain.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_1109ba0e-c7f6-46b5-a6a9-476a5f825612/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_1109ba0e-c7f6-46b5-a6a9-476a5f825612.git

Docs Build status updates of commit bc5c8b5:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-BuildPermissionInsufficientError] Your repository https://github.com/VSC-Service-Account/docs-archive-test-source has enabled Docs Build service account. It seems that at least one of the account, e2ebd2, does not have Read permission to the repo. Please ask your repo admin to grant correct permission to service accounts (refer to this document: https://review.docs.microsoft.com/en-us/engineering/projects/ops/engdocs/how-to-grant-service-account-permission-in-your-repository?branch=master) and then retry the build.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Update benchmark.md

I added the FCP lag test to the benchmark page. I linked the bundle on dropbox.

@PattonForge - FYI: That Dropbox link only contains the Final Cut Pro library, not this:

included is a video file explaining how to replicate this test.

Did you want to upload that explainer video to the same Dropbox link?


feat: Show similar events by location

Fixes #207

Look at the code! Why is favorite there!

Did you run this locally it would never work

Don’t push without testing your code for once

@dreadpool2  can you confirm is it working?

@simarsingh24 I was just going to say that. The mapping is working. The events which are actually favorited are appearing to be favorited even after reload. The only issue is that the process in an infinite loop. The events are loaded constantly

@dreadpool2 could you please finalize this PR its not nice to keep a PR open for a month 👍

Doing that :+1:


issue in v1.1.0: "A parameter cannot be found that matches parameter name 'f'. "

During a puppet run the following error occurs:
Could not evaluate: A parameter cannot be found that matches parameter name 'f'. Source: .../Dsc_xiismodule[PHP54]
This is the resource I'm using:
dsc_xIISModule { 'PHP54':
dsc_ensure      =>'Present',
dsc_verb        => '',
dsc_moduletype  =>'FastCgiModule',
dsc_requestpath =>'.php',
dsc_name        =>'PHP-5.4',
dsc_path        =>'C:\PHP-5.4\php-cgi.exe',
}
This works fine in v1.0.1.

@mansong1 I don't receive the same error using your example, it parses fine. I get the following:
Error: /Stage[main]/Main/Dsc_xiismodule[PHP54]: Could not evaluate: PowerShell DSC resource MSFT_xIisModule  failed to execute Test-TargetResource functionality with error message: Cannot bind argument to parameter 'Verb' because it is an empty string.

A parameter error like this happens before DSC is called, and indicates that an incorrect parameter was specified in the puppet manifest. If you run the manifest with puppet apply --debug in an interactive session on the target host that will give you more information. You may be able to find the line that has the incorrect parameter added.

@jpogran I've amended the resource I was using. The attribute dsc_verb should be an asterisk rather than empty string. That should get rid of the error you got.
I've dug a bit further and found the errors I was getting was to due to some errors in the MSFT_xIisModule.psm1.  I've created a pull request for the file on Microsofts Powershell repository:
https://github.com/PowerShell/xWebAdministration/pull/240

I have the same issue. I temporarily corrected it by downgrading xWebAdministration to the previous release version.

@mansong1 nice investigative work! When that PR get's merged and they release a new tag, we can add it to our release

@mansong1 / @MColaianni - now that 1.2.0 has shipped with a newer xWebAdministration, could you confirm that this is no longer a problem?
Thanks!

Yes.

Glad to hear it. I'll close this out then


Fix 236

Pull Request Checklist:

[X] This PR addresses an already opened issue (for bug fixes / features)
[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)
[X] HISTORY.rst has been updated

After merging to master and before closing the branch:

[ ] bumpversion (minor / major / patch) has been called on master branch
[ ] Tags have been pushed

What kind of change does this PR introduce?
Bug fix, #236

Does this PR introduce a breaking change?
no

Other information:
subset_gridpoint() will now use .sel method if lon, lat dims are in the dataset. Otherwise it uses old version based on distance

This PR fixes #xyz

Pull Request Test Coverage Report for Build 975

23 of 24 (95.83%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 92.302%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

xclim/subset.py
23
24
95.83%

Totals

Change from base Build 971:
0.02%

Covered Lines:
1295

Relevant Lines:
1403

💛  - Coveralls

Does it also fix the issue raised by David C ?

The issue of different dimension orders? If yes, then it should be solved as I no longer create a 2d meshgrid out of 1d lon lat dim values but instead use the sel method.  The 'distance' method is therefore only used when lon, lat dims are not present (i.e. rlat and rlon) and is calculated directly on the irrelgular 2d lon, lat values already present in the dataset.
Just to make sure I added a test for this in test_utils in test_irregular where I transpose the data before running the subset

test failing ... @huard wait a minute.

Test should be working now...


Bookmarklet generator enhancements

allow hlx3 flag to be passed via URL
show help text when helix logo is clicked
only show from link if it has a value

:tada: This PR is included in version 3.5.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


%%wandb doen't work in PyCharm

wandb --version && python --version && uname

Weights and Biases version: latest
Python version: 3.7
Operating System: Windows7

The error 'Failed to query for notebook name, you can set it manually with the WANDB_NOTEBOOK_NAME environment variable' occurs
When I tried on web browser with jupyter, it seems to work but the error still occurs

Should I set WANDB_NOTEBOOK_NAME correctly? But I couldn't find what name should I set on this field...

Setting the WANDB_NOTEBOOK_NAME is optional.  You should set it to whatever your notebook is named, i.e. "My Notebook.ipynb".  The error you're seeing isn't related though.  If you rerun the cell in pycharm does it show up?

@vanpelt
The error message disappeared so there's difference, but still doesn't work

Hey @YahngSungho
In the past year we've majorly reworked the CLI and UI for Weights & Biases. We're closing issues older than 6 months. Please comment to reopen.


V2 fulltext search results: highlight matches

Instead of returning the full string representation of a property matching a fulltext search, the results should just include the search term (match) and provide some context (words before and after).
However, this is difficult when a user provides more than one search term or provides wildcards.
Approach 1: scala
            searchResponseAsSeq: Vector[ReadResourceV2] = ConstructResponseUtilV2.createSearchResponse(queryResultsSeparated, settings)

            // shorten stringd that matched the search criteria
            searchResponseAsSeqStringShortened: Vector[ReadResourceV2] = searchResponseAsSeq.map {
                (resource: ReadResourceV2) =>
                    resource.copy(
                        values = resource.values.map {
                            case (propIri: IRI, values: Seq[ReadValueV2]) =>

                                propIri -> values.map {
                                    (value: ReadValueV2) =>
                                        value.valueContent match {
                                            case textval: TextValueContentV2 =>

                                                value.copy(
                                                    valueContent = textval.copy(
                                                        valueHasString = ConstructResponseUtilV2.extractContextFromString(resultString = textval.valueHasString, searchTerm = searchValue, context = 15)
                                                    )
                                                )

                                            case _ => value
                                        }
                                }
                        }
                    )

            }

    /**
      * Extract a term from a search result string and provide some context.
      *
      * @param resultString the string representing a search result.
      * @param searchTerm the term searched for contained in the  `resultString`.
      * @param context the context to be provided (how many characters before and after the `searchTerm`).
      * @return a [[String]] containing the `searchTerm` with some context.
      */
    def extractContextFromString(resultString: String, searchTerm: String, context: Int): String = {

        // TODO: what happens if the user uses wildcards etc.?
        val index = resultString.indexOf(searchTerm)

        val startIndex = if (index - context >= 0) {
            index - context
        } else {
            index
        }

        val endIndex = if ((index + searchTerm.length + context) < resultString.length) {
            index + searchTerm.length + context
        } else {
            index + searchTerm.length
        }

        "..." + resultString.substring(startIndex, endIndex) + "..."

        //resultString
    }

Approach 2: Sparql
SELECT DISTINCT ?matchingSubject ?matchingProperty ?context WHERE {

            GRAPH <http://www.ontotext.com/explicit> {
                ?matchingSubject ?matchingProperty ?literal .
            }

            ?literal <http://www.ontotext.com/owlim/lucene#fullTextSearchIndex> 'Newton' .

            BIND(STRBEFORE(?literal, 'Newton') AS ?literalContextBeforeAll)
            BIND(SUBSTR(?literalContextBeforeAll, STRLEN(?literalContextBeforeAll)-20) AS ?literalContextBefore)

            BIND(STRAFTER(?literal, 'Newton') AS ?literalContextAfterAll)
            BIND(SUBSTR(?literalContextAfterAll, 1, 20) AS ?literalContextAfter)

            BIND(CONCAT(?literalContextBefore, " ", "Newton", "", ?literalContextAfter) AS ?context)

        } LIMIT 500

duplicate of #1572


picard-tools: 2.22.2 -> 2.22.4

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/broadinstitute/picard/releases.
meta.description for picard-tools is: "Tools for high-throughput sequencing (HTS) data and formats such as SAM/BAM/CRAM and VCF"
meta.homepage for picard-tools is: "https://broadinstitute.github.io/picard/"
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.22.4 with grep in /nix/store/46dwfi1rjhd3akc5690p4qz0dblcvx69-picard-tools-2.22.4

directory tree listing: https://gist.github.com/f0a506c1389e37b7f89f9d038a009269

du listing: https://gist.github.com/87a11aa1b7aa47d5812d5405eacf42eb

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
picard-tools

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/46dwfi1rjhd3akc5690p4qz0dblcvx69-picard-tools-2.22.4 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A picard-tools https://github.com/r-ryantm/nixpkgs/archive/877b1cdad74500320afe7e1b06b525d21c1a0741.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/46dwfi1rjhd3akc5690p4qz0dblcvx69-picard-tools-2.22.4
ls -la /nix/store/46dwfi1rjhd3akc5690p4qz0dblcvx69-picard-tools-2.22.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:
- picard-tools

Maintainer pings
cc @jbedo for testing.

LGTM.


Can not use BEHAT_PARAMS variable to set parameters to individual items in suites>default>contexts>[individual item]

Lets say I have a custom FeatureContext that accepts two constructor parameters $dummy1 and $dummy2.
class FeatureContext extends RawMinkContext implements MinkAwareContext
{
  public function __construct($dummy1 = false, $dummy2 = false) {
    // Do something with the constructor values.
  }
/* ... */
}

To correctly set $dummy1 and $dummy2, I'd do the following in my behat.yml:
default:
  suites:
    default:
      contexts:
        - FeatureContext:
             dummy1: true
             dummy2: true

If you commented out dumm1 in behat.yml, then attempt to set it in the environment BEHAT_PARAMS variable like: {"suites":{"default":{"contexts":[{"FeatureContext": {"build_number":"99"}}]}}}, the constructor never gets the value from the BEHAT_PARAMS environment variable.
I'm pretty certain that's the correct JSON structure. I inspected the resulting structure from the working behat.yml in the ConfigurationLoader.php file and mimicked it.
The issue seems to come down to the fact that individual context items are cast to  Symfony\Component\Config\Definition\VariableNode. In the VariableNode-> mergeValues($leftSide, $rightSide) function, it simply returns $rightSide.
Excerpt from VariableNode.php:
    /**
     * {@inheritdoc}
     */
    protected function mergeValues($leftSide, $rightSide)
    {
        return $rightSide;
    }

Because of this, anything defined in the behat.yml for FeatureContext will override the BEHAT_PARAMS, instead of merging individual items. Even if there is just one constructor parameter and it exists in the environment variable, not behat.yml. The entire context declaration from the behat.yml file is used.
FYI: I'm aware the behat.yml settings take precedence over the BEHAT_PARAMS env variable; this is not the case.
Even if this is the expected functionality, I hope someone finds this who is having trouble. The Behat 3.x docs state the following which could be frustrating if this is not the intended functionality.

You can set any value for any option that is available in a behat.yml file. Just provide options in JSON format.

I'd put together a PR, however, I'm not entirely sure what the appropriate solution would be.

Context parameters are indeed not merged, but overridden between configurations.
This is expected behaviour, but it is due to the technical, not logical limitations. In other words - it works this way because I didn't figure out the better way yet. Help is greatly appreciated!

Thanks for the quick response and confirmation!
I want to say it is something in how the configuration is defined to Symfony in the configure function of the SuiteExtension.php file.
But looking the way the tree is built, it's pretty intimidating:
        $builder
            ->defaultValue(array('default' => array(
                'enabled'    => true,
                'type'       => null,
                'settings'   => array()
            )))
            ->treatNullLike(array())
            ->treatFalseLike(array())
            ->useAttributeAsKey('name')
            ->normalizeKeys(false)
            ->prototype('array')
                ->beforeNormalization()
                    ->ifTrue(function ($suite) {
                        return is_array($suite) && count($suite);
                    })
                    ->then(function ($suite) {
                        $suite['settings'] = isset($suite['settings'])
                            ? $suite['settings']
                            : array();
                        foreach ($suite as $key => $val) {
                            $suiteKeys = array('enabled', 'type', 'settings');
                            if (!in_array($key, $suiteKeys)) {
                                $suite['settings'][$key] = $val;
                                unset($suite[$key]);
                            }
                        }
                        return $suite;
                    })
                ->end()
                ->normalizeKeys(false)
                ->addDefaultsIfNotSet()
                ->treatTrueLike(array('enabled' => true))
                ->treatNullLike(array('enabled' => true))
                ->treatFalseLike(array('enabled' => false))
                ->children()
                    ->booleanNode('enabled')
                        ->info('Enables/disables suite')
                        ->defaultTrue()
                    ->end()
                    ->scalarNode('type')
                        ->info('Specifies suite type')
                        ->defaultValue(null)
                    ->end()
                    ->arrayNode('settings')
                        ->info('Specifies suite extra settings')
                        ->defaultValue(array())
                        ->useAttributeAsKey('name')
                        ->prototype('variable')->end()
                    ->end()
                ->end()
            ->end()
        ;

The issue is that Behat really allows anything in suite parameters. So we have no way to provide a strict configuration there.
We could build a system validating them strictly (and then allowing to merge deeper), but it would require some BC-breaking changes. Extensions would have to register explicitly the suite settings they support, and any other key would become forbidden (or silently dropped from the configuration, which is even worse IMO).

hmm, actually, due to the fact that most people use a shortcut notation for settings, we may find a BC way to handle it for them (not easy for people using the settings key explicitly). It would require some work though

I'm having a hard time thinking of a clean fix. Everything I've looked into results in special Context specific logic embedded in the SuiteExtension file. This seems nasty.
Maybe holding off until Behat can use Symfony 3.2+ would be the best option. Then we could use environment variables inside YML files.
See: http://symfony.com/doc/current/configuration/external_parameters.html

New in version 3.2: env() parameters were introduced in Symfony 3.2.

have a look at Behat/Behat#1048

I feel like we'll have to live with this one for a while. @cravecode thanks for your thinking though :) It all matters and helps!


[docs] update 'See code' links in README

Checklist
Not applicable

[x] I've added an entry to CHANGELOG.md if necessary.
[x] I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why
Majority of the See code links in the README resolve to nonexistent paths causing 404s. For example, build/commands/account/login.ts should resolve to src/commands/account/login.ts.
How
Simple find and replace with the links and updating relevant text.
Test Plan
Clicked through the links to make sure they all resolve to right locations.

Thanks for the PR! Unfortunately, this is only a one-time fix. This has already been reported in https://github.com/expo/eas-cli/issues/350
Regenerating README.md is handled by oclif during every release.
See https://github.com/expo/eas-cli/blob/main/CONTRIBUTING.md to learn how we release EAS CLI. Basically, we run yarn release which runs yarn version. The version script is defined in the package.json for EAS CLI (https://github.com/expo/eas-cli/blob/main/packages/eas-cli/package.json#L174). The command responsible for regenerating README.md is oclif-dev readme (https://github.com/oclif/dev-cli#oclif-dev-readme). So it seems that if you wanted to fix this properly you'd need to look into how oclif generates those files.
Also, keep in mind that our case is even more complicated because we have a monorepo and the README.md in the root directory is only a symlink to the actual file in packages/eas-cli (https://github.com/expo/eas-cli/blob/main/README.md).
Having said that, it doesn't make sense to merge this one as it'll be broken again after another release.

@dsokal Gotcha--i'll look into it. Thanks for the in-depth overview.

@dsokal looked over oclif source for auto-generating paths and surrounding issues. There is no clear solution that wouldn't involve changing their source and adding an additional flag which has been denied in their past issues / PRs.
Potential solutions are using sed(1) with a bash script including these commands
$ sed -i '' 's/\[build/\[lssrc/g' README.md
$ sed -i '' 's/build\/commands/src/packages\/eas-cli\/src\/commands/g' README.md

However sed(1) has different behavior / flags depending on system and this would only work on Mac machines. A system-agnostic alternative would be a Python script like
s = open('README.md').read()
s = s.replace('[build/', '[src/')
s = s.replace('build/commands', 'packages/eas-cli/src/commands')
f = open('README.md', 'w')
f.write(s)
f.close()
quit()

But this is also a bulky solution and looks unprofessional. Either of these solutions could be run with an && after README generation. However, given the inherent nuances in our workflow, neither solution is elegant so I am closing this PR.

Sorry, I overlooked your comment.
I think that using sed is not that bad. You said that the behavior/flags differ depending on the system

Sorry, I overlooked your comment. I think that using sed doesn't seem that bad. We could have a conditional checking the OSTYPE env var and have slightly different commands for different systems.
However, I think a better solution would be (as you suggested) a simple JS script (I'd prefer no to mix in Python here) that is system-agnostic. Could you elaborate why you think it looks unprofessional?


add second derivatives for squar_sin_exp

I added second order derivatives for the squar_sin_exp kernel in smt/utils/kriging.py, and modified the smt/surrogate_models/tests/test_krg_training.py to include tests for it.

Looks good to me @relf !

I don't have anything to add on that part, everything seems good!


[BUG] DataLakeFileSystemClient.GetDirectoryClient(string.Empty).Path is "" on "12.3.0-preview.1", and "/" on other version

Describe the bug
Run following code , the 'rootDirPath' value will change on different "Azure.Storage.Files.DataLake" version:
string rootDirPath = new DataLakeFileSystemClient(new Uri("https://accoutname.blob.core.windows.net/filesystem1/"))
                .GetDirectoryClient(string.Empty).Path;

12.0.0, 12.2.2: "/"
12.3.0-preview.1: ""
12.3.0-preview.2: "/"

It seems a regression on "12.3.0-preview.1" , and fixed on "12.3.0-preview.2".
As PSH depends on this value to decide if a DataLakeDirectoryClient object is root directory, the regression on "12.3.0-preview.1" takes the PSH issue https://github.com/Azure/azure-powershell/issues/12553
To avoid this kind of issue happen in Powershell again, would you please help to confirm:

What's the value of DataLakeDirectoryClient.Path on a root directory (Or what's the best way to decide if a DataLakeDirectoryClient object point to root directory)

Expected behavior
The 'rootDirPath' value should always be "/"
Actual behavior (include Exception or Stack Trace)
The 'rootDirPath' value is "" on "12.3.0-preview.1", and "/" on other version
To Reproduce
Steps to reproduce the behavior (include a code snippet, screenshot, or any additional information that might help us reproduce the issue)
Run the above code.
Environment:

Name and version of the Library package used: [e.g. Azure.Storage.Files.DataLake 12.3.0-preview.1]
Hosting platform or OS and .NET runtime version (dotnet --info output for .NET Core projects): [e.g. Azure AppService or Windows 10 .NET Framework 4.8]

.NET Core SDK (reflecting any global.json):
 Version:   2.2.108
 Commit:    33ed5b90ce

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.18363
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.2.108\

Host (useful for support):
  Version: 2.2.6
  Commit:  7dac9b1b51

.NET Core SDKs installed:
  2.2.108 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

IDE and version : [e.g. Visual Studio 16.3]
VS 15.7.4

Thank you for your feedback.  Tagging and routing to the team best able to assist.

Would you please help to confirm:

What's the value of DataLakeDirectoryClient.Path on a root directory (Or what's the best way to decide if a DataLakeDirectoryClient object point to root directory)

Path is set to "/" by design.   DataLakeFileSystemClient.GetDirectoryClient(string.Empty) refers to the file system's root directory, who's path is "/".

@seanmcc-msft
Thanks for the confirmation!
Would you please kindly point out the test case to validate the Path is "/" on the root directory, to avoid this kind regression happen again？


Create dependabot.yml

Description

Enable dependabot version updates.
How Has This Been Tested?

NA
Merge criteria:

[X] The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
- [ ] The developer has manually tested the changes and verified that the changes work

@lampajr we should add some path filters to avoid building image for PRs like this one that doesn't affect any image sources.

we should add some path filters to avoid building image for PRs

i believe this covers: https://github.com/opendatahub-io/model-registry/issues/93

@lampajr we should add some path filters to avoid building image for PRs like this one that doesn't affect any image sources.

I definitely agree on this, I opened an issue few mins ago https://github.com/opendatahub-io/model-registry/issues/93

Added pip package for python dependencies.

Nice! this would catch any existing CVE issues.

Nice! this would catch any existing CVE issues

@rareddy fwiw we had them already:

https://github.com/opendatahub-io/model-registry/pull/86
https://github.com/opendatahub-io/model-registry/pull/69

this PR, in my understanding, will override Org level settings for specific MR settings (works for me I assume we wanted fine tuned controls).


Perfdash uses GCS as a source

@spiffxp @jeremyeder @kubernetes/sig-scalability

@wojtek-t PTAL

/cc @kubernetes/sig-testing

cc @hongchaodeng

Few more comments.

LGTM


Fix hover_doc

Related: #674 #688
Fixed an error in tsserver due to incorrectly positioned code for converting contents.

just wonder why it behind the parser content.  when request done . we should check result first.   then check result.content after parse. so it should .
if not result or not result.content then
return
end

parse result.content
....

Sorry, I fixed it to work, but I think the code was wrong and I will check it.
However, the current code sometimes has a string in result.contents, so I get an error at next(result.contents).

yes . res.content not always table so remove this check next(result.content) == nil

Thank you. Should I delete this PR?

you can just remove this or next(result.contents) == nil

Modified PR to remove only the part that uses next.

Thanks


Flip assertEqauls() arguments

Cf. https://phpunit.readthedocs.io/en/stable/assertions.html#assertequals

Thanks for opening a PR to help improve the PHP track!
I'll need to check more closely, but I think this work is already being done in an open PR in #357 by @codedge which was opened 2 days ago.
If it isn't overlapping I'll take a look at this tonight to review it.

Awesome! I think @codedge missed part of this meetup test file, which your PR covers! Most appreciated!!


Add --no-dev option

Resolves #67
Nits are welcome.

Thank you for the PR! I am currently traveling, so I am not sure when I will be able to review it.
If it slips through the cracks and I don't review it within a week, please remind me - leaving a comment here should be sufficient.

Will do. Thank you, @Shnatsel.

Friendly ping. No rush, though.

Sorry the review took so long, I was preoccupied with other urgent matters.
The approach looks good to me. The only nit is I'd like to have tests for this functionality, since it's not entirely trivial. Specifically I would like to cover the case when the toplevel package has a dev dependency that in turn has runtime dependencies; these should not be included even though they have DependencyKind::Development.
Thanks again for the PR!

The only nit is I'd like to have tests for this functionality

That's not a nit at all.
I was actually considering using trycmd for this. Would that be okay?
If so, are there any particular packages you would like used for the tests?

trycmd has a rather sprawling supply chain, and I'm trying to eat my own dog food here and be conscious about supply chain sprawl. It would add 35 publishers to the supply chain in the default configuration, or 19 without the default features.
Would insta suffice instead? It's a popular snapshot testing tool with a much smaller supply chain footprint, and would only add 4 publishers.
I don't really have a preference on the packages to use.

Would insta suffice instead?

I haven't used insta before, but I suspect I can figure it out.
I'll start on this very soon.

How is this?
I tried to make the ui test something that is extensible. The no_dev test is then implemented on top of that.
The similar-asserts dependency isn't strictly needed. It just makes the output look nicer when there's a difference.
Hopefully, adding tempfile was okay.

Is this better?

Yeah, that looks great! Merging. Thanks again!

I'll make a stable release soon, too.

Thanks, @Shnatsel. I will use this!

I've published v0.3.3 with these changes. Thanks again!


MAINT: Bump tol for gamma map test

All PRs are currently failing due to a gamma_map test being too strict about distances:
https://travis-ci.org/github/mne-tools/mne-python/jobs/685787842
This one is only off by 3.6 mm so here we just bump the tol. I cannot reproduce locally so we'll have to see what the CIs say.
It's not clear to me what this is due to, possibly some version bump in mkl ... ?

yes it can be an update in MKL. As solver is non-convex you easily end up is a slightly different local minimum


Fix empty keywords parsing

Fixes #335

Thanks!
About your remark on (null), my intial idea was to use it for fields that are only available in the info output, and the search one. But since URL might not be filled in either just using - for the bunch seems fine to me.


Add certification tests for the Local Storage Output Binding

The Local storage Output binding requires certification tests to be created.
Add conformance tests if not present.

/assign


fix(osm): Fix link to mapcomplete tool

We are linking to a version of the theme in our account
and we are using a raw github url with a git hash now
Todos:

[x] Can we pass zoom?
[x] Can we pass the location?

Yes we can.

[x] Get lat lon of pump
[x] Pass zoom

@technologiestiftung/giess-den-kiez can you please test and review this again.


Connect via LAN

Hi , Can you please add Connect via LAN feature ? , ty <B
Currently other device in network cant access to specific port and ip inside home network.

If you want to use the socks proxy on the lan, then you should bind to <IP_ADDRESS>:8086.


device-to-device has been changed to local-discovery

The text seems OK to be, but the netlify preview is broken - don't know if that's problem on our site or in the netlify configuration though.


Crash when debugging on Linux using v1.5.5

I was using version 1.5.4, and everything is fine. Today I downloaded the v 1.5.5 from https://github.com/dfranx/SHADERed/releases/download/v1.5.5/Linux.zip and unzip it.
Then I ran the executable, saw the colorful cube, pressed the Pause button, and in the Pixel Inspect I click the first Run button for debugging the frag shader.

And then, no matter I choose to Step or to Stop, the program crashed, with a Segmentation fault (core dumped) message.
I can still use v1.5.4 to avoid this, and thanks for the great tool.
BTW, my system is Ubuntu 20.04 LTS, with 5.4.0-88-generic kernel.
My nvidia driver is 470.63.01, and the card is GeForce GTX 1070 Mobile.

Same for me on Win10Pro RTX 2060 notebook


Synchronous or asynchronous

Thanks for sharing this.
But how do I switch between synchronous or asynchronous remote/local ?
Thanks in advance

Hi Kevin,
You can switch between synchronous/asynchronous by setting
MVCarouselCollectionView.commonImageLoader.
See ViewController.swift in the Demo application for an example of how this
would work.
If you have any other questions, let me know.
Kind Regards,
Andrea
On 16 June 2015 at 13:21, Kevin Thulin<EMAIL_ADDRESS>wrote:

Thanks for sharing this.
But how do I switch between synchronous or asynchronous remote/local ?
Thanks in advance
—
Reply to this email directly or view it on GitHub
https://github.com/bizz84/MVCarouselCollectionView/issues/3.

--
Andrea Bizzotto
Software Developer and Consultant
mobile: +44<PHONE_NUMBER>
e-mail<EMAIL_ADDRESS>Personal website: www.bizzotto.biz
Company website: www.musevisions.com
Got an Oyster Card? Try this: taps.io/MyOyster
https://itunes.apple.com/app/id784860215


Create docker image

Is it possible to create docker images of these projects? Espcially of CLI

Good idea! I'll get onto that.

I worked on it, it will be in my fork (https://github.com/AssafKatz3/pact-reference) in next hours. But helping will be very welcome since this is the first time that I do something like this.

Hi,
I added the modifications (adding of release-docker.sh and Dockerfile files) - https://github.com/pact-foundation/pact-reference/compare/master...AssafKatz3:master. I need help for integrate to build.
Thanks,
Assaf

The code is pulled from my fork, but still don't intergrate to build process. I don't know how to write it, and don't have permission to grant docker hub to automated builds on Docker Hub
.

I've setup access to pact foundation docker hub, so I'll setup the repo as soon a I get a spare moment.

Docker images exists at:

https://hub.docker.com/r/pactfoundation/pact-ref-mock-server/
https://hub.docker.com/r/pactfoundation/pact-ref-verifier/


Question on usecases for the 'min' rule

Hi, I have just created a pull request for a slight improvement of the dutch (nl.js) translation. I only changed the 'min' rule as it gave wrong results.
That makes it better already but I am still struggling with a specific use case of the 'min' rule:
Suppose we have an input of type=text and an input of type=number. Both inputs use the min:5 rule for validation and the user leaves the field blank and tabs to the next field. In the dutch language the validation message should be different for these two cases.
For the text field something like this: 'name should be at least 5 characters long'
For the number field something like this: 'age should be greater than 5'
In the current translation, the latter is used (translation reads '$name moet groter zijn dan $arg'), but I am unsure how to change it. I think it is somewhere in these lines (lines 5-8), but I am not sure how to change it accordingly.
min: function ({ name, value, args }) {
    if (Array.isArray(value)) {
      return `Je moet tenminste ${args[0]} selecteren als ${name}.`
    }
    const force = Array.isArray(args) && args[1] ? args[1] : false
    if ((!isNaN(value) && force !== 'length') || force === 'value') {
      return `${s(name)} moet groter zijn dan ${args[0]}.`
    }
    return `${s(name)} moet tenminste ${args[0]} karakters bevatten.`
  },

Part of this is how the rule is written. min and max (if it is wrong in one it's probably wrong in both) are both capable of string length or numeric value. The rule itself, and the message are aware of this. However, they can also be forced into evaluating one type vs the other, and this would be the recommended way to use the rule. For example, if you want to limit the length of the input min:5,length or in the numeric case, min:5,value. The psuedo logic for the above code is:
min: function ({ name, value, args }) {
  // Case 1. The value is an array, in this case we can only evaluate based on a the length of the array
      // return `Je moet tenminste ${args[0]} selecteren als ${name}.`
  // Case 2. The value is either a number, or the user has declared we should evaluate this as a number
      // return `${s(name)} moet groter zijn dan ${args[0]}.`
  // Case 3. The value must be a string, or the user wants us to evaluate it as a string
      // return `${s(name)} moet tenminste ${args[0]} karakters bevatten.`
}

Empty values are hard to coerce correctly because isNaN('') === false (so it thinks a blank field is a number). So often it's best to combine this with a required rule with a the bail modifier ^required|min:5,value. It might be in your case you just need to adjust the way you're writing the validation rule, but you're the native speaker so feel free to adjust as necessary. Hopefully this sheds some light on what is happening though.

Thanks @justin-schroeder for the very quick reply once more. It took me some time to get my head around it (was reading your comment on my phone). This morning I took some more time to read and trying it.
I didn't know about the way you can force the validation to use either length or value as second value to the min rule. Also, the bail modifier was new to me. I changed my rule to ^required|min:3,length|max:10,length and now it works for all use cases I can think of.
Thanks also for the pseudo logic, that makes reasoning about the logic much easier for me.
All in all, I just checked the docs and it's all there so I think I just didn't read it carefully enough.
Keep up the good work, I read your post featured in the Vue.js developers newsletter #171, hopefully it draws even more attention to this wonderful project!


Core: Fix TypeError in showLabel when using groups settings

The this inside $.each() refers to the current value of the
Objcet|Array we iterate over, not the plugin instance.
Ref https://github.com/jzaefferer/jquery-validation/pull/1614#discussion_r51156526

awesome thx. confirmed that the error gone away!

You're welcome :) Thanks for confirming :)


Check if an array_like object is an Enumerable

Context
When passing an array like ActiveModel::Errors, I'm unable to render blueprint because it does not pass array_like? condition. Both [] and ActiveModel::Errors are Enumerable, I'm proposing to check if array is Enumerable instead.
Let me know what you guys think? Thank you.
Usage Example
Before
ModelBlueprint.render(model.errors.full_messages, root: :errors)

After
ModelBlueprint.render(model.errors, root: :errors)

@triciatzy - we recently fixed this in the fork - https://github.com/blueprinter-ruby/blueprinter/pull/6. Pls let me know if it helps.

Thanks @ritikesh


Not able to debug test case (written using protractor )

We have written test cases using protractor(selenium based). I am able to run test cases successfully though vscode without debugging but when I am running it in debug mode it is displaying error in debug console (grunt is configured to run test cases)
launch.json:
{
    "version": "0.2.0",
    "configurations": [
        {
            "type": "node",
            "request": "launch",
            "name": "Launch Program",
            "program": "${env:APPDATA}\\npm\\node_modules\\grunt-cli\\bin\\grunt",
            "stopOnEntry": true
        }
    ]
}

debug console:
Running "modify-and-run:all" (modify-and-run) task
[2017-07-21 19:04:49.809] [INFO] modify-and-run - There are no describe appenders configured.
[2017-07-21 19:04:49.841] [INFO] modify-and-run - Executing: 2/2 ui and 1/1 non-ui tests from a total of: 3
[2017-07-21 19:04:49.841] [INFO] modify-and-run - Number of automated tests: 3/3 (100%)
Running "protractor:modify" (protractor) task
Error: listen EADDRINUSE :::28972
    at Object.exports._errnoException (util.js:890:11)
    at exports._exceptionWithHostPort (util.js:913:20)
    at Agent.Server._listen2 (net.js:1234:14)
    at listen (net.js:1270:10)
    at Agent.Server.listen (net.js:1366:5)
    at Object.start (_debug_agent.js:21:9)
    at startup (node.js:75:44)
    at node.js:404:3

part of successful console output:
Running "modify-and-run:all" (modify-and-run) task
[2017-07-21 19:15:42.967] [INFO] modify-and-run - There are no describe appenders configured.
[2017-07-21 19:15:43.310] [INFO] modify-and-run - Executing: 2/2 ui and 1/1 non-ui tests from a total of: 3
[2017-07-21 19:15:43.310] [INFO] modify-and-run - Number of automated tests: 3/3 (100%)
Running "protractor:modify" (protractor) task
Using ChromeDriver directly...
[launcher] Running 1 instances of WebDriver
problem trying to remove a folder
Started

VSCode Version: 1.14.1
OS Version:Windows 7 Professional N 64-bit
Node: 5.10.0

Reproduces without extensions: Yes

If you see a "error: listen EADDRINUSE :::28972" this means that the port is already used.
I don't know how "protractor" works but make sure that
your program ${env:APPDATA}\\npm\\node_modules\\grunt-cli\\bin\\grunt does the right thing when an command line argument --inspect-brk=12345 is added by VS Code.
(this happens when you start debugging with your debug configuration from above).


Dynamic EP discovery doesnt work if Duplicate IP exists under pre-existing AS3 configuration.

Environment

Application Services Version: 3.19.1
BIG-IP Version:15.1

Summary
In case when user posts duplicate IPs to service discovery endpoint for 2 different BigIP Partitions/Apps, one of them succeeds and the other operations ends up with the duplicate IP staying absent in pool.
This is acceptable as BigIP doesn't support duplicate IP. However, after this, even if a valid and unique IP is posted to service discovery endpoint, that doesn't work. It only gets added as a node but fails to make it to desired pool as a pool member.
Steps To Reproduce
Steps to reproduce the behavior:
1.On BigIP, submit the list of endpoints to service discovery endpoint under a partition/App/Pool PK02/A1/web_pool: https://BIGIP/mgmt/shared/service-discovery/task/~PK_02~A1~web_pool
[{"id":"/PK_02/<IP_ADDRESS>","ip":"<IP_ADDRESS>"},{"id":"/PK_02/<IP_ADDRESS>","ip":"<IP_ADDRESS>"},{"id":"/PK_02/<IP_ADDRESS>","ip":"<IP_ADDRESS>"},{"id":"/PK_02/<IP_ADDRESS>","ip":"<IP_ADDRESS>"},{"id":"/PK_02/<IP_ADDRESS>","ip":"<IP_ADDRESS>"},{"id":"/PK_02/<IP_ADDRESS>","ip":"<IP_ADDRESS>"},{"id":"/PK_02/<IP_ADDRESS>","ip":"<IP_ADDRESS>"}]}
2.On same BigIP,submit one more list of endpoints - but containing a duplicate IP <IP_ADDRESS> -  to service discovery ep on second partition/App/pool PK_04/A1/web_pool: https://BIGIP/mgmt/shared/service-discovery/task/~PK_04~A1~web_pool
[{"ip":"<IP_ADDRESS>","id":"/PK_04/<IP_ADDRESS>"},{"ip":"<IP_ADDRESS>","id":"/PK_04/<IP_ADDRESS>"},{"ip":"<IP_ADDRESS>","id":"/PK_04/<IP_ADDRESS>"},{"ip":"<IP_ADDRESS>","id":"/PK_04/<IP_ADDRESS>"},{"ip":"<IP_ADDRESS>","id":"/PK_04/<IP_ADDRESS>"},{"id":"/PK_04/<IP_ADDRESS>","ip":"<IP_ADDRESS>"},{"id":"/PK_04//PK_02/<IP_ADDRESS>","ip":"<IP_ADDRESS>"},{"id":"/PK_04/<IP_ADDRESS>","ip":"<IP_ADDRESS>"},{"id":"/PK_04/<IP_ADDRESS>","ip":"<IP_ADDRESS>"}]}

After step 2, any new ip - unique IP - when added to partition/App/pool PK_04/A1/web_pool resulted only in a corresponding node creation but failed to create pool member.
This issue persisted till the duplicate entry was present.

After removing the duplicate IP entry from service discovery endpoint and the partition, the subsequent Attach/Detach operations worked properly.

Additional Observation-
Similar behavior is observed when instead of duplicate IP,, a non-supported IP format like <IP_ADDRESS>/24 exists in the node list.
Submit the list of endpoints as below:
[{"id":"/PK_02/<IP_ADDRESS>","ip":"<IP_ADDRESS>"},{"id":"/PK_02/<IP_ADDRESS>","ip":"<IP_ADDRESS>"},{"id":"/PK_02/<IP_ADDRESS>","ip":"<IP_ADDRESS>"},{"id":"/PK_02/<IP_ADDRESS>","ip":"<IP_ADDRESS>"},{"id":"/PK_02/<IP_ADDRESS>","ip":"<IP_ADDRESS>"},{"id":"/PK_02/<IP_ADDRESS>","ip":"<IP_ADDRESS>"},{"id":"/PK_02/<IP_ADDRESS>/24","ip":"<IP_ADDRESS>/24"}]
Expected Behavior
-AS3 to allow all unique IPs to get added to configured pool except the duplicate IP.
Actual Behavior
Unique IPs - as endpoint list - added after duplicate ip event are added only as node however not as pool members in respective partition

Found during testing integration with F5 ACI ServiceCenter

I have confirmed this bug and added it to our internal product backlog as AUTOTOOL-1677.
As a work-around, you can add "shareNodes": true to your member declarations.


feat: add QUACK token

looks good, if possible could you update quack to this icon?

Can you send the SVG path? I will do update that in a separate PR


Add About Tab

Credit contributors, funders, and labs.
Also general project info, and links to the opensource projects used.

Looking at getting this done over winter break.

Code is there, will discuss with Rob and Chad what should be in there


Delete key doesn't work when Find in Files is in effect

VSCode Version: 1.12.2
OS Version: Windows 7 also 10

Steps to Reproduce:

Ctrl+Shift+F
Search for anything
F4, F4, Shift+F4
The cursor is at the match in the editor
Move around with Left arrow/Right arrow (Type some text maybe)
Del
Instead of deleting a character, the active search result is deleted, or error message is shown (Cannot read property 'parent' of null)
Other keys like Bksp work as expected

If the tree has focus, like when using up/down to navigate, then delete should remove the result, this is by design. If the editor has focus, when this happens, that would be a problem.

Sorry I didn't make that clear, the editor has focus in this case

Is it deleting the text, which would cause the result to be removed from the results list? Can you share a gif or screenshot of the difference between del and backspace?

Can you open dev tools (Help > Developer tools) and check for a full stack trace for that error message?

There is nothing logged in the Devtools

Perfect thanks.

Can you try downloading the Insiders' build and tell me whether it reproes there? https://code.visualstudio.com/insiders
I thought I reproed it before but I can't anymore.

@roblourens Yes, I can reproduce with a new Insiders' build install


Volume

I would contribute to this but I lack JavaScript experience, the volume is too low even though I have it set to 100% and on my pc it is set to 100%.

Issue created on the same day and and is duplicate of #117


error when using minify with quic

I am using caddys experimental quic support.
When adding the minify directive, I get an:

ERR_QUIC_PROTOCOL_ERROR

I'm trying to reproduce this issue but this is happening to me even if I don't add the minify directive.

Due to the recent developments of Caddy (v2!) and the incompatibility of this plugin with newer versions, as well as not being maintained, I'm closing this issue and archiving the repository.


Animation: inconsistent camera parameters between the play() function and values obtained from typing 'C' key

Hi @marcomusy,
I've got another issue for you with the Animation class. I observed that the camera parameters from directly printing inside the play function is different from what I obtained by pressing C key with my keyboard.
For example, the following code simply rotates the body 180 degrees along the z-axis. I can print out the camera parameters by adding all the print lines before self.show in the play function in the Animation class:
            if dt > self.eps:
                print(self.camera.GetPosition())
                print(self.camera.GetFocalPoint())
                print(self.camera.GetViewUp())
                print(self.camera.GetClippingRange())
                print(self.camera.GetDistance())
                self.show(interactive=False, resetcam=self.resetcam)

When the rotation finishes, I press C to get camera parameters, and they are different. The last values printed are
(-653227.8500875884, -6233719.241304105, 1505.5680089146688)
(-653227.8500875884, -6233719.241304105, 9.46603775024414)
(0.0, 1.0, 0.0)
(1313.4217270188815, 1729.6674490770752)
1496.1019711644246

and the values obtained by pressing C are
plt.camera.SetPosition( [-555720.156, -6243167.25, 1485.5] ) \n
plt.camera.SetFocalPoint( [-555720.156, -6243167.25, 9.466] )\n
plt.camera.SetViewUp( [0.0, 1.0, 0.0] )
plt.camera.SetDistance( 1476.034 )
plt.camera.SetClippingRange( [1293.555, 1709.299] )

Here is the code I used:
#!/usr/bin/env python3

import numpy as np
from vedo import TetMesh, show, screenshot, settings, Picture, buildLUT, Box, \
    Plotter, Axes
from vedo.applications import Animation

import vtk
import time as tm

from vedo import settings

settings.allowInteraction=True

# Do some settings
settings.useDepthPeeling=False  # Useful to show the axes grid
font_name = 'Theemim'
settings.defaultFont = font_name
settings.multiSamples=8
# settings.useParallelProjection = True # avoid perspective parallax

# Create a TetMesh object form the vtk file
ovoid_tet = TetMesh('final_mesh.1.vtk')
host_tet = ovoid_tet.clone()

# This will get rid of the background Earth unit and air unit in the model
# which leaves us with the central part of the model
ovoid_tet.threshold(name='cell_scalars', above=1, below=1)
host_tet.threshold(name='cell_scalars', above=2, below=2)

# Crop the entire mesh using a Box object (which is considered to be a mesh
# object in vedo)
# First build a Box object with its centers and dimensions
cent = [555700, 6243165, 100]
box = Box(pos=cent, size=(4000, 4000, 3000))
# So, we now cut the TetMesh object with a mesh (that Box object)
# host_tet.cutWithMesh(box, wholeCells=True)
host_tet.cutWithMesh(box, wholeCells=False)

# And we need to convert it to a mesh object for later plotting
ovoid = ovoid_tet.tomesh().lineWidth(1).lineColor('w')
host = host_tet.tomesh(fill=False).lineWidth(1).lineColor('w')

# We need to build a look up table for our color bar, and now it supports
# using category names as labels instead of the numerical values
# This was implemented upon my request
lut_table = [
    # Value, color, alpha, category
    (1.0, 'indianred', 1, 'Ovoid'),
    (1.5, 'lightgray', 1, 'Host'),
]
lut = buildLUT(lut_table)

host.cmap(lut, 'cell_scalars', on='cells')
ovoid.cmap(lut, 'cell_scalars', on='cells')

# Set the camera position
plt = Animation(videoFileName=None, showProgressBar=False)

# size = [3940, 2160]
size = [2560, 1600]
plt.size = size

# # Trying to play with the Animation class
# plt.showProgressBar = True
plt.timeResolution = 0.01  # secs

# Fade in the ore body
plt.fadeIn(ovoid, t=0, duration=0.5)

# Rotate the ovoid body
plt.rotate(ovoid, axis='z', angle=180, t=0.5, duration=2)

plt.play()

Again, here is the data:
final_mesh.1.vtk.zip
My plan was to move the camera from the endpoint after the rotation to something else. But it turned out I could not do it possibly because of this inconsistency. Any ideas?

Hi Xushan - this Animation class is pretty old and needs an in-depth revision... I'll only be able to look at this in 1-2 weeks... meanwhile if you are in a hurry I would suggest to modify the camera manually in a loop.
Sorry about that and thanks for your feedback, I'll let you know anyways when I get some results on this!

Hi Marco,
I've been doing things by modifying the applications.py file and I've made an animation that serves my need. The only thing I think I actually needed was to make resetcam to be always False for the moveCamera function, and I am now only using that function. It's just adding more camera positions to the movement series but it worked. Please fix this whenever you have time. I am interested to read the source code further down the road to see whether I can help more than just reporting issues. Thanks very much!

sounds good! If you like you can make a push request with your new application.py

Unfortunately, making it False would make other functions stop working although moveCamera does work with that. I think it is related to something deeper in the Plotter.show() function but I am not sure.


FR: Support Tanzu mission control

Tanzu Mission Control (TMC), supports managing and deployment of many different clusters.
Using the Tanzu cli, it's possible to get the kubeconfig from those managed clusters.
So a feature request is to support Tanzu Mission control, the same way as GCP etc.
This Issue is created as a placeholder, for ref. I will dig into the documentation, and see if i can make it work.
Ref : https://tanzu.vmware.com/mission-control

Hi, I have to rely on community contributions as I don't have a Tanzu installation privately or at work. So if someone sees value in supporting Tanzu, feel free to create a PR.

Hi. I had a plan to create this, but my work focus changed, so i don't have access to a tmc tenant anymore.
So let's just close this


Is it possible to initialize telescope file browser in normal mode?

Is your feature request related to a problem? Please describe.
When I run :Telescope file_browser vim switches to insert mode.
Describe the solution you'd like
I would like to initialize the file browser and stay in normal mode.

Sure.
:Telescope file_browser initial_mode=normal or :lua require 'telescope'.extensions.file_browser.file_browser { initial_mode = 'normal' } which can also be passed to extension setup.

Hey, I came across this issue while looking for the same function. However, I noticed that, if I call the file browser via the lua function require 'telescope'.extensions.file_browser.file_browser { path="xyz", initial_mode = 'normal' } for different folders, the initial_mode settings is only applied the first time. When I call the function a second time with the same settings, only on another path the setting is ignored and I end up in insert mode. Is this expected behavior? Is the file_browser somehow resumed instead of reinitialized?
If this is not expected I would open a seperate issue ...
Thanks in advance!

Seems to be a separate issue, and I cannot reproduce from what you wrote. Please make sure to fill out the template.

Is the file_browser somehow resumed instead of reinitialized?

From what you wrote, it's fully reinitialized, though there are situations in which it strictly speaking is resumed (:Telescope resume or changing between file & folder browser).


Implement average progress with multi-writes

There are multiple things we need to consider:

Transitioning from flashing to verifying

Once writing finishes, show average flash that has been happening in the background

Keeping the average consistent

Solution: cache devices that are done and consider them at 100%
Ensures the progress doesn't jump backwards

@Shou is this specified somewhere? If so, can you add links to it?

@jhermsmeier it was briefly discussed in the product call today, whether to use the slowest drive or an average of all – the average was selected, so this is just a list of things to consider when implementing it.

Resolved by #2124


full stack modelling for guitar only

You can now make full  stack model if you dont mind losing almost everything below 90Hz and above 10kHz.
Take this as your training file https://www.dropbox.com/s/5kch9a0w4oqc6ih/v1_1_2.wav?dl=0
then add to nam/train/core.py this line in to version
"405a54616574a647005b0befdbed5c50": Version(1, 1, 1),
like this
version = {
"4d54a958861bf720ec4637f43d44a7ef": Version(1, 0, 0),
"7c3b6119c74465f79d96c761a0e27370": Version(1, 1, 1),
"405a54616574a647005b0befdbed5c50": Version(1, 1, 1),
}.get(file_hash)
Some one could try to find out what are the actual frequencies we need to cut to be able to still create accurate models of full stack, but mean while happy modeling to you all and remember the cuts are too deep for bass guitar.

btw you should use at least 200 epochs for above learning.
Here's little less gutted version of training wav, all under 40Hz and above 13kHz are filtered out https://www.dropbox.com/s/xe0plvsskv03x84/v1_1_3.wav?dl=0
This needs more epochs to get more accurate, at least 300.
And here the checksum for it
"238f8845c6ee1ab01616722b2169c19c": Version(1, 1, 3), add the same way as above to the nam/train/core.py

Is this for a new capture signal, then?
I've been really happy to let folks "hack" the capture signal, and there's a better way to do it that currently. I think a better way to get you this flexibility without making a new "official" signal (which I want to be conservative on iterating on for others' stability--I want to recommend only one capture signal for simplicity) would be to re-think how the hashing works.
The other thing is that I'd like to see a more complete "battery" of tests to prove that your new capture signal is really improving modeling.
The critical parts of the v1_1_1.wav signal are the start and the end. One could hash the audio itself (first 6 seconds and last 9 seconds), which would leave you with the ability to mess with the "bulk" of the signal as you'd like if you want to "hack" it.

This is basically copy of v1_1_1.wav with low and high cut filters.
It might be better if those first 6 seconds and last 9 would be untouched but ill have to test it when i have more time.
But idea in this is that when there's less stuff for AI to learn, it will learn stuff better and we all know that there are certain frequencies that are going to be cut out anyways, hence 40Hz high pass and 13kHz low pass filtering.

I been thinking along these lines as well.
One way to check the result would be to compare the output of a normally trained model high/low passed afterward with the the output of a model trained on the high/low passed input signal - also high/low passed afterward.
That should show whether the high/low pass input training actually results in a more accurate reproduction of the desired end frequencies.

I don't know ... a "cured" signal may work for a 6 string guitar in standard tuning but if somebody brings in a baritone guitar (or a 8 or 9 string) to play a model that's been trained that way, not sure how that'll fair.
The beauty of NAM though is that it's easy to use a custom training signal and hone in on that ideal snapshot but taking data out of the training signal (instead of adding more) would probably only lead to an accurate representation of just some tones

The frequencies @jolappi is using are fairly aggressive (particularly on the low end) - ones closer to the limits of human hearing would be more conservative.
It also might make more sense to do the filtering to the output capture file, rather than the input - since amp distortion adds so much harmonic content.

Basically, the low pass(not cut) saves so little data that there really is no point to it but on the other hand upper cut when ex. cutting from 15k saves lot more.
Celestion v30 range is 70Hz->5kHz for guitar of course and this is just for metal heads but you can ask yourself how much you miss those hight frequencies ex. above 15k. None after you hit 50 years.
Also I checked Tonex training and it starts to lower(not cut) on 80Hz and after 8kHz thats is why ist learning is easier less frequencies to learn.
I know harmonics are always nice to have but i think the distortion will anyway create those.
I dont know which is easiest for Intellegence to learn, creating something that is missing(input cutted,output not) or
uncreating something that is missing(input no cutted, output cutted).
Anyway it is so dumb or persistent that it wil try to do what ever you ask of it, for as long there is electricity.
I tried without low pass filtering and high pass at 14k and there was no way for me to tell which was original full stack.
14K filtering seems to speed up learning guite lot.

This is basically copy of v1_1_1.wav with low and high cut filters. It might be better if those first 6 seconds and last 9 would be untouched but ill have to test it when i have more time. But idea in this is that when there's less stuff for AI to learn, it will learn stuff better and we all know that there are certain frequencies that are going to be cut out anyways, hence 40Hz high pass and 13kHz low pass filtering.

I see.
I'd like to see how well it performs when the cut is not applied to the last 9 seconds. It's important for that last part to be the same so that the comparison is apples to apples.

Hey, most of the current models sound very good (better than tonex?) with a drop-tuned baritone and bass even, so please be careful in  encouraging people to capture with frequency limited signals. In the digital domain we are no longer limited to celestion cabs and it is probably enough for most users to do the cutting at the output of the models.
Probably I am biased since the captures already sound perfect to my ears so they can only get worse :)

This is basically copy of v1_1_1.wav with low and high cut filters. It might be better if those first 6 seconds and last 9 would be untouched but ill have to test it when i have more time. But idea in this is that when there's less stuff for AI to learn, it will learn stuff better and we all know that there are certain frequencies that are going to be cut out anyways, hence 40Hz high pass and 13kHz low pass filtering.

I see.
I'd like to see how well it performs when the cut is not applied to the last 9 seconds. It's important for that last part to be the same so that the comparison is apples to apples.

Here in the zip is original orig.wav and file created with v1_1_6.wav qcorig-nam.wav .
In the v1_1_6.wav beginning and ending are directly from original v1_1_1.wav only middle is low passed at 14k to 20k -48db.
I used lots of distortion as it is harder for AI to learn.
By Ear I cannot hear any difference.
Archive.zip

Probably training could use more epochs but then time gets over hour or so with mac m2 and without eq adjustment the time triples. Whats time difference using nvidia vs m2, any idea?

I'm going to close this:

EQ the input file isn't the same as EQing the output of the amp; the latter is what's usually done when mixing; the former makes the data unrepresentative of how the models are used in practice.
Full-rig modeling has since been shipped with a different implementation.
Downstream users are able to modify the training content of the standardized files now without needing to change the hash checks--you should get a weak match which is good enough to make the validation happy.


Artifactory+NuGet v2: Save/Install broken for prereleases due to incorrect URL

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.

Steps to reproduce

Configure Artifactory with PowerShell-flavored NuGet feed
Publish prerelease package to NuGet
Call Install-PSResource or Save-PSResource with the -Prerelease flag

Expected behavior
PS> Save-PSResource -Name Foo -Path .\modules\ -Prerelease
PS> # completes successfully

Actual behavior
Save-PSResource: 'Response status code does not indicate success: 404.' Request sent: 'https://artifactory.f.q.d.n/artifactory/api/nuget/v2/psgallery-nuget-virtual/Download/Foo/0.9.1'

Error details
PS> Get-Error
Exception             :
    Type       : Microsoft.PowerShell.PSResourceGet.UtilClasses.ResourceNotFoundException
    TargetSite :
        Name          : InstallPackages
        DeclaringType : [Microsoft.PowerShell.PSResourceGet.Cmdlets.InstallHelper]
        MemberType    : Method
        Module        : Microsoft.PowerShell.PSResourceGet.dll
    Message    : 'Response status code does not indicate success: 404.' Request sent: 'https://artifactory.f.q.d.n/artifactory/api/nuget/v2/psgallery-nuget-virtual/Download/Foo/0.9.1'
    Source     : Microsoft.PowerShell.PSResourceGet
    HResult    : -2146233088
    StackTrace :
   at Microsoft.PowerShell.PSResourceGet.Cmdlets.InstallHelper.InstallPackages(String[] pkgNamesToInstall, PSRepositoryInfo repository, ServerApiCall currentServer, ResponseUtil currentResponseUtil, ScopeType scope, Boolean skipDependencyCheck,
FindHelper findHelper)
   at Microsoft.PowerShell.PSResourceGet.Cmdlets.InstallHelper.ProcessRepositories(String[] repository, Boolean trustRepository, Boolean skipDependencyCheck, ScopeType scope)
   at Microsoft.PowerShell.PSResourceGet.Cmdlets.InstallHelper.BeginInstallPackages(String[] names, VersionRange versionRange, NuGetVersion nugetVersion, VersionType versionType, String versionString, Boolean prerelease, String[] repository,
Boolean acceptLicense, Boolean quiet, Boolean reinstall, Boolean force, Boolean trustRepository, Boolean noClobber, Boolean asNupkg, Boolean includeXml, Boolean skipDependencyCheck, Boolean authenticodeCheck, Boolean savePkg, List`1
pathsToInstallPkg, Nullable`1 scope, String tmpPath, HashSet`1 pkgsInstalled)
   at Microsoft.PowerShell.PSResourceGet.Cmdlets.SavePSResource.ProcessSaveHelper(String[] pkgNames, String pkgVersion, Boolean pkgPrerelease, String[] pkgRepository)
   at Microsoft.PowerShell.PSResourceGet.Cmdlets.SavePSResource.ProcessRecord()
   at System.Management.Automation.CommandProcessor.ProcessRecord()
TargetObject          : Microsoft.PowerShell.PSResourceGet.Cmdlets.SavePSResource
CategoryInfo          : InvalidOperation: (Microsoft.PowerShel…lets.SavePSResource:SavePSResource) [Save-PSResource], ResourceNotFoundException
FullyQualifiedErrorId : InstallPackageFailure,Microsoft.PowerShell.PSResourceGet.Cmdlets.SavePSResource
InvocationInfo        :
    MyCommand        : Save-PSResource
    ScriptLineNumber : 1
    OffsetInLine     : 1
    HistoryId        : 3
    Line             : Save-PSResource -Name Foo -Path .\modules\ -Prerelease -Debug
    Statement        : Save-PSResource -Name Foo -Path .\modules\ -Prerelease -Debug
    PositionMessage  : At line:1 char:1
                       + Save-PSResource -Name Foo -Path .\modules\ -Prerelease -Debug
                       + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    InvocationName   : Save-PSResource
    CommandOrigin    : Internal
ScriptStackTrace      : at <ScriptBlock>, <No file>: line 1
PipelineIterationInfo :
      0
      1

Environment data
ModuleType Version    PreRelease Name                                ExportedCommands
---------- -------    ---------- ----                                ----------------
Binary     1.0.5                 Microsoft.PowerShell.PSResourceGet  {Find-PSResource, Get-InstalledPSResource, Get-PSResourceRepository, Get-PSScriptFileInfo…}

Name                           Value
----                           -----
PSVersion                      7.4.3
PSEdition                      Core
GitCommitId                    7.4.3
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
The problem here appears to be that PSResourceGet is synthesizing the download URL incorrectly.
Two separate issues:

V2ServerAPICalls::InstallVersion() is making assumptions about the download URL, even though NuGet v2 responses include the download URL in the <content> element under the <entry> node for a given search result.
I've only validated this on PSGallery and Artifactory - not sure if there's historical context for not simply passing the URL from NuGet into functions like Install*(). The calling convention of InstallVersion() seems to suggest it was designed to support being called without a preceding FindPackagesById() call but I don't think that's actually the case in any scenario.
For reasons not entirely clear to me at the moment, InstallVersion is getting passed the version string without prerelease suffix. My suspicion is that this is due to JFrog not including NormalizedVersion properties on returned packages (and thus PSResourceGet backfills a separate version string), but I'm not 100% sure. JFrog is returning the correct version string in all relevant parts of its response, so this is likely something within PSRG.

I think the problem lies somewhere around here:
https://github.com/PowerShell/PSResourceGet/blob/c4097b0196996f2538122bcb2401aaf567b075e5/src/code/InstallHelper.cs#L804-L807
L804 populates pkgVersion with AdditionalMetadata[NormalizedVersion]. AIUI, this is spec'd to include prerelease strings.
If that property does not exist, we backfill it with .Version in L806, which does not include prerelease strings.
I'd posit that this might be broken on any NuGet feed platform which doesn't include NormalizedVersion on package responses.


Implement quote::ToTokens for AST types

They were already implemented, just without the formalization ;)
r? @alexcrichton

Heh, nice!


Robot Default Configs: µl per millimeter

As a user, I would like my pipette to aspirate (and dispense?) at a defined µl/mm rate, so that I can accurately pipette small volumes of liquid.
Acceptance Criteria

Robot uses a µl/mm function to determine appropriate travel distance for an input aspiration volume.
Robot able to use different function coefficients per pipette

Implementation Notes

Function form (number and order of terms, e.g. "Ax^3 + Bx^2 + C") should be considered stable, and can be stored on the robot
Function coefficients ('A', 'B', and 'C' above) may change per pipette, and should be stored on the pipette at time of production. Note we cannot (easily) write these post-production, so these should be considered fixed.
-- Note our working assumption is that the function and coefficients are the same across pipettes, so these values will initially be uniform. Following this assumption, we will hold any pipettes whose flow rates do not conform to our standard function during production testing. If we implement pipette-specific coefficients in the future, we can write to these pipettes and ship them.
Note if the function form does change, we can use the same pipette data model for coefficients and use versioning to determine (1) what function to use and (2) what coefficients go with which terms.

Resources

Function TBD

Further Notes
https://docs.google.com/document/d/1zW93dkQVCtvy5DmBlDt-VSLGBfjUnxMjC5X7K6NtpWQ/edit#

@andySigler Pipette µl/mm story.

Closing, superseded by #1309


Yarn loader fails to parse nodes

When trying to load a yarn file, the yarn asset has the full text string, but the nodes have missing information, including names and statements.
Using the text from complex.yarn, here's loading the text:
pub struct TitleAssets {
    pub background: Handle<Image>,
    pub yarn_file: Handle<YarnAsset>,
    pub dialogue_runner: Option<Entity>,
}

impl FromWorld for TitleAssets {
    fn from_world(world: &mut bevy::prelude::World) -> Self {
        let asset_server = world.resource::<AssetServer>();
        let yarn_handle = asset_server.load("text/title_screen/title_screen.yarn");
        let mut assets_loading = world.resource_mut::<AssetsLoading>();
        assets_loading.add(yarn_handle.id());
        TitleAssets {
            yarn_file: yarn_handle,
        }
    }
}

Setting up the runner:
fn init_runner(
    mut commands: Commands,
    title_assets: Res<TitleAssets>,
    dialogues: Res<Assets<YarnAsset>>,
) {
    let yarn_asset_option = dialogues.get(&title_assets.yarn_file);
    if yarn_asset_option.is_none() {return}
    let yarn_asset = yarn_asset_option.unwrap().clone();
    dbg!(&yarn_asset);
    let runner = commands
        .spawn(DialogueRunner::new(yarn_asset, "Start"))
    .id();
    commands.insert_resource(TitleDialogueRunner(runner));
}

Console output:
[src\states\game_states\title_state\mod.rs:52] &yarn_asset = YarnAsset {
    raw: "title: Start\r\ntags: #test_tag othertag\r\ncolorID: 1\r\nposition: 301,-291\r\n---\r\nLamik: Hi there !\r\nDona: Hello !\r\nLamik: how are you doing ?\r\n<<say hello>>\r\nBob: Hi !\r\nGrumpy: Grumble !\r\nBob: Oh hello there grumpy !\r\nDona: fine and you ?\r\n->  Lamik: doing ok\r\n    Dona: good to hear :)\r\n    Grumpy: whatever !\r\n    Bob: cool cool cool !\r\n    Dona: let's have a party then !\r\n    Grumpy: NO!\r\n    Bob: sure, whatever..\r\n    Lamik: yeah !\r\n    <<jump Other_node>>\r\n->  Lamik: not so great, sadly :(\r\n    Dona: oh, what is the matter ?\r\n    Lamik: have not caught any crabs.\r\n     <<jump nested_node>>\r\nLamik: continuing to talk here outside of choices\r\n===\r\ntitle: Other_node\r\ntags: \r\ncolorID: 0\r\nposition: 567,-265\r\n---\r\nLamik: bleh bleh\r\nDona: what is wrong ?\r\n->  Grumpy: and what about me ?\r\n    Bob: sure\r\n    -> Grumpy: yes ?\r\n    -> Grumpy: what ?\r\n-> Grumpy: another answer\r\n\r\nBob: and me ?\r\n===\r\ntitle: nested_node\r\ntags: \r\ncolorID: 0\r\nposition: 567,-265\r\n---\r\nDona: what is wrong ?\r\nLamik: let's do some nesting\r\n->  Grumpy: and what about me ?\r\n    Bob: sure\r\n    -> Grumpy: yes ?\r\n       Bob: what \r\n       -> Grumpy: more nesting ?\r\n          Bob: not sure\r\n       -> Grumpy: or not ?\r\n          Bob: sigh\r\n       -> no more nesting  \r\n    -> Grumpy: what ?\r\n-> Grumpy: another answer\r\n\r\nBob: and now back to our normal programming\r\nYuri: really ?\r\nBob: yeah, so a boring one\r\n===",
    nodes: {
        "Start": YarnNode {
            title: "Start",
            tags: [],
            branch: Branch {
                statements: [],
            },
        },
        "": YarnNode {
            title: "",
            tags: [],
            branch: Branch {
                statements: [],
            },
        },
    },
}

Followed by a crash:
thread 'Compute Task Pool (0)' panicked at 'index out of bounds: the len is 0 but the index is 0', C:\.cargo\git\checkouts\bevy_mod_yarn-e20b3c6c30dd4f32\5b28e60\src\evaluator\dialogue_runner.rs:64:33

Found the issue. Seems that when I made the Yarn file, it had the wrong encoding. It needs LF, not CRLF. Changing the encoding fixed the issue. I apologize from taking your time.


Fix category / collection page name header

Changes the way that bottom padding under collection / category title is added.

Codecov Report

Merging #1745 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1745   +/-   ##
=======================================
  Coverage   83.15%   83.15%
=======================================
  Files         142      142
  Lines        6095     6095
  Branches      661      661
=======================================
  Hits         5068     5068
  Misses        857      857
  Partials      170      170

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd8688...eb518d3. Read the comment docs.


add covariance fields to imu message

🎉 New feature
Add the covariance fields to the imu message
Summary
The imu message is missing the covariance fields for linear_acceleration, angular_velocity and orientation_covariance.
Those can be very useful when bridging between gz and ros.
Note: a PR is coming to gz-sensors to fill those field.
Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[x] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[x] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

I think this breaks ABI so will need to go into main?

Other than branch target, changes LGTM.

@mjcarroll Thanks for the answer. I just resolved the merge conflicts and updated the PR with it.

@mjcarroll How do you plan on releasing this? Since it's related to PRs on other repos ?

How do you plan on releasing this? Since it's related to PRs on other repos ?

We will need to get each of the other ones landed first and released, and then this one can get in.

@ahcorde fixed the conflicts

@ahcorde @mjcarroll The confligs mainly came from the various merge from main into this branch.
To fix everything and limit this PR to only my changes, i've rebased my changes on main and force-pushed.
Hope this clears things up !

@ahcorde @mjcarroll Hey guys, any update on this PR ? shall I rebase again ?

Thank you for the PR merge! :)

Are there plans to implement or release this feature for older versions, including Fortress?

Unfortunately, this is not a backward compatible change.


[TACHYON-1303] Add unit tests for TachyonFile

Please review:
https://tachyon.atlassian.net/browse/TACHYON-1303

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7128/
Test PASSed.

LGTM

Thanks for the test improvement!

LGTM

@shuhuai007 Thanks for the patch, I will address my formatting comments in a follow up commit.


[DO NOT MERGE] Validate that #70 catches MSRV mismatch

This PR builds on #70 and adds a commit which intentionally introduces an MSRV mismatch to make sure that the CI test in #70 catches it.

Closing this now that #70 has merged.


[DO NOT MERGE] Testing

Please refer to the contribution guide for detailed instructions.
Summary

PR Checklist

[ ] My PR is less than 500 lines of code
[ ] I have added sufficient comment as docstrings in my code
[ ] I have made corresponding changes to the documentation

[ ] I have written unit-tests to test all of my code

looks good, closing