How to iterate and display multiple column wise detail rows for an expanded row?

Select one ...  (check one with "x")
[x] bug
[] feature request
[] enhancement

Expected behavior
I want to show row(parent) and its related children in expanding row as shown below:

Actual behavior
Using custom component and ngProjectAs="clr-dg-row-detail" syntax it is not possible to loop.
Issue link
https://stackblitz.com/edit/clarity-datagrid-row-expand-iterate-issue?file=app%2Fapp.component.html
Environment details

Angular version: 5.2.x

Clarity version: 0.11.x

OS and version: all

Browser: all

@shravansofts  I am not sure how the "my-detail" component would generate a loop on its own, but an ng-template with ngFor works just fine. See this.
Please correct me if I've got the wrong end of the stick…
Jose

@gomesjj Thanks for the workaround.
my-detail component had the ngFor directive inside its .html file.
But how could we make it work using a custom component for the same?
Let's say I got the below usecase in future. I have to show some info after children as shown below:

Which could be achieved as shown in below link. But going with a custom component will be a cleaner and better approach for extensibility in future.
https://stackblitz.com/edit/clarity-datagrid-row-expand-iterate-issue-query2?file=app/app.component.html

@shravansofts I see what you mean now.
Somehow I missed the app.detail.component.html file… The only issue you had there was the wrong ngFor syntax used on an ng-template. This is what you need.

@gomesjj: Thanks for taking the time to answer the debug the issue! We really appreciate it.
@shravansofts: I believe you could also use ng-container inside of the my-detail component:
<ng-container *ngFor="let child of children">
	<clr-dg-row-detail *clrIfExpanded>
		<clr-dg-cell>{{child.username}}</clr-dg-cell>
		<clr-dg-cell>{{child.fullName}}</clr-dg-cell>
		<clr-dg-cell>{{child.role}}</clr-dg-cell>
	</clr-dg-row-detail>
</ng-container>

Closing the issue based on the solution provided by @gomesjj. @shravansofts please feel free to reopen the issue if you have more questions. Also another good place to ask how to questions is on StackOverflow with the vmware-clarity tag. We monitor StackOverflow regularly and filing a question over there also helps other users in the community. Thanks!

@gomesjj Thanks a lot man!
@adityarb88 thanks for the tip on ng-container and stackoverflow. :+1:

@adityarb88 We are using clarity for vCenter plugin development.
When we are using the inline/custom component syntax and doing a data refresh event.
This cannot be replicated in standalone mode(stackblitz). It is showing in vCenter plugin.
We are getting the following error. Can you have a look at actual clarity implementation for any null check missing?

@shravansofts: This error indicates you are somehow destroying the row before it even had time to initialize. In other words, you're creating a row, and then halfway through the initialization lifecycle, you destroy it immediately. That's something that should not happen, and reveals that there is a problem somewhere in your app.
We had a similar issue a while back, with someone wanting to add extra null checks to suppress an error they had, but it was decided against it because early fails like that help you debug before you hit issues that are impossibly hard to investigate. Here is the link if you're interested in the conversation: #151.

@youdz Please find a sample angular project(based on plugin-seed 0.9.8 by vmware) that and implemented a sample Users Listing with datagrid row expand feature.
Now as a standalone webapp also it is throwning error while navigating to next page as shown below:

This is a different error from the above one.
Steps to run project:
prerequisite:
node.js version 6.9 or higher

npm install
npm install -g json-server

Run:

start json-server to get mock data and load local message bundles(cmd terminal #1)
npm run json-server
run the plugin in dev mode and watches your files for live-reload (cmd terminal #2)
ng serve

Code Files path "testplugin-ui\src\app\users"
Here is the project seed with code
testseed-ui.zip
Please let me know what is wrong in this code/clarity code.
Thanks,
shravan

@shravansofts: Both this error and the one before don't seem to be Clarity errors, they're due to an issue in the app's code. On top of that we can't download, install and build projects just to debug them, that would take way too much time.
Because of this, I recommend you ask your question on StackOverflow with the tag vmware-clarity, with a StackBlitz reproducing the issue. There is absolutely no reason for you to be able to reproduce the bug in a project but not in StackBlitz, and since this isn't a Clarity bug we shouldn't have this conversation here on GitHub.

@youdz how do you say it is not clarity bug?
if I comment <user-row-detail [children]="user.child" ngProjectAs="clr-dg-row-detail"> line.
It's working fine.
As I need to have a rest api server, I had done as a standalone project.
I don't think it will take days of your time to download and run.

The best way to report bugs is with a simple isolated StackBlitz. You don't need a server, replace that with static data. It took me 5 minutes to do, and I concur with @youdz that it is not an issue with Clarity but with your lifecycle management of your components. I'd start by reviewing your observables and any async behaviors.
https://stackblitz.com/edit/clarity-light-theme-v11-7e6mxm?file=app/app.component.html

@gnomeontherun Thanks for looking into it. I had done the same thing without service call and in-build refresh mechanism(say a refresh button which fetches and updates data) which works fine as yours and the error occurs on click of next page.
This seed is given by VMware itself. I had followed the same way of observable how other components(monitorComponent) are there in seed project. Please let me know what is wrong in that.
This will be very helpful for us.

The seed is most basic, it doesn't even have Observables https://github.com/vmware/clarity-seed/search?q=Observable&type=Code&utf8=✓ so I'm not sure what exactly you're pointing to.
We cannot spend time triaging people's applications, but this error usually means you are changing the value of something twice, so look at your logic for refreshing the page contents for any place you might be setting a value more than once in a change detection cycle.

I'm talking about vmware plugin seed.
https://labs.vmware.com/flings/vsphere-html5-web-client?download_url=https%3A%2F%2Fdownload3.vmware.com%2Fsoftware%2Fvmw-tools%2Fvsphere_html_client%2FHTML+Client+SDK+Fling+Overview+and+Release+Notes-6094542.pdf#changelog

@gnomeontherun I am not disagreeing with your stance and I think that @shravansofts could have provided a better plunker for troubleshooting. But, to be fair, from my tests so far I have noticed that the errors only occur when pagination is enabled and the clr-dg-row-detail is part of a different component. That occurs whether the data is static or not...
I haven't been able to fully troubleshoot yet because I myself am not much experienced in Typescript and Angular. I will keep trying though, as it is a good learning exercise… :-)

@shravansofts I have added an answer to your question on StackOveflow.

Here is the stackover flow link for reference:
https://stackoverflow.com/questions/49325539/need-help-in-multiple-ui-issues-in-angular-project-with-clarity-framework/49331238#49331238


Failed assertion: line 6156 pos 12: 'child == _child': is not true. using stream builder with the help of provider

Steps to Reproduce

Run flutter create bug.
Update the files as follows: ...
...

Expected results:
Actual results:

Logs

Hi @NVenkateshRaj ,
When opening an issue, please try to provide all or some of the information indicated in the template.

Issue Template
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
- https://flutter.dev/
- https://api.flutter.dev/
- https://stackoverflow.com/questions/tagged/flutter?sort=frequent

If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports

Steps to Reproduce

Please tell us exactly how to reproduce the problem you are running into.

Please attach a small application (ideally just one main.dart file) that
reproduces the problem. You could use https://gist.github.com/ for this.

If the problem is with your application's rendering, then please attach
a screenshot and explain what the problem is.

1. ...
2. ...
3. ...

Please tell us which target platform(s) the problem occurs (Android / iOS / Web / macOS / Linux / Windows)
Which target OS version, for Web, browser, is the test system running?
Does the problem occur on emulator/simulator as well as on physical devices?

Target Platform:
Target OS version/browser:
Devices:

Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.

Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.

Finally, paste the output of running `flutter doctor -v` here.

Closing this issue, since no information has been provided.
Thank you.


make reset role functional also on Redhat and restart workload on MetalLB config change

Closes https://github.com/techno-tim/k3s-ansible/issues/81

Closes https://github.com/techno-tim/k3s-ansible/issues/80

i made the changes on my fork's master branch, sorry for that , if needed i can provide 2 different PR

Also, one side comment, I am surprised that we need to restart the service after applying a new config / custom resource.  Kubernetes should do this for us.  Will need to test this.

So after testing

Also, one side comment, I am surprised that we need to restart the service after applying a new config / custom resource. Kubernetes should do this for us. Will need to test this.

So after testing this, my hunch was right.  This shouldn't be necessary.  I changed the IP range from <IP_ADDRESS>-<IP_ADDRESS> to <IP_ADDRESS>-<IP_ADDRESS> and it applied immediately without need to restart the service.
➜  k3s-ansible git:(master)  kubectl -n metallb-system describe ipaddresspools.metallb.io
Name:         first-pool
Namespace:    metallb-system
Labels:       <none>
Annotations:  <none>
API Version:  metallb.io/v1beta1
Kind:         IPAddressPool
Metadata:
  Creation Timestamp:  2022-09-10T19:19:13Z
  Generation:          1
  Managed Fields:
    API Version:  metallb.io/v1beta1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:kubectl.kubernetes.io/last-applied-configuration:
      f:spec:
        .:
        f:addresses:
        f:autoAssign:
        f:avoidBuggyIPs:
    Manager:         kubectl-client-side-apply
    Operation:       Update
    Time:            2022-09-10T19:19:13Z
  Resource Version:  1380
  UID:               f2c5eac6-baa3-44c2-854b-60ee3e42ec3d
Spec:
  Addresses:
    **<IP_ADDRESS>-<IP_ADDRESS>**
  Auto Assign:       true
  Avoid Buggy I Ps:  false
Events:              <none>
➜  k3s-ansible git:(master) ✗ nano metallb.crs.yaml

➜  k3s-ansible git:(master) ✗ kubectl apply -f metallb.crs.yaml
ipaddresspool.metallb.io/first-pool configured
l2advertisement.metallb.io/default unchanged

➜  k3s-ansible git:(master) ✗ kubectl -n metallb-system describe ipaddresspools.metallb.io
Name:         first-pool
Namespace:    metallb-system
Labels:       <none>
Annotations:  <none>
API Version:  metallb.io/v1beta1
Kind:         IPAddressPool
Metadata:
  Creation Timestamp:  2022-09-10T19:19:13Z
  Generation:          2
  Managed Fields:
    API Version:  metallb.io/v1beta1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:kubectl.kubernetes.io/last-applied-configuration:
      f:spec:
        .:
        f:addresses:
        f:autoAssign:
        f:avoidBuggyIPs:
    Manager:         kubectl-client-side-apply
    Operation:       Update
    Time:            2022-09-10T19:19:13Z
  Resource Version:  1010593
  UID:               f2c5eac6-baa3-44c2-854b-60ee3e42ec3d
Spec:
  Addresses:
    **<IP_ADDRESS>-<IP_ADDRESS>**
  Auto Assign:       true
  Avoid Buggy I Ps:  false
Events:              <none>

I have a feeling that something else is off.  Also, in a comment you mentioned this was with a single node too, which might have its own issues but we also have tests for that, but we surely add more.   I am going to close this PR, but there are some great takeaways here!  Thank you!  I will link the issues after I create them.

Here is the issue.  Thank you again!
https://github.com/techno-tim/k3s-ansible/issues/88


GUI installation error in Ubuntu 20.04[BUG]

Describe the bug
<When installing through CLI in ubuntu 20.04, after running the command "sh install-gui.sh"  I am getting the following error:
"ERROR in ./src/components/icons/index.ts 1:0-43
Module not found: Error: Can't resolve './Covid' in '/home/chia1/covid-blockchain/covid-blockchain-gui/src/components/icons'
@ ./src/components/dashboard/DashboardSideBar.tsx 6:0-142 28:43-51 37:43-53 45:43-51 53:43-51 61:43-51 69:43-51
@ ./src/components/dashboard/Dashboard.tsx 16:0-50 78:89-105
@ ./src/components/app/AppRouter.tsx 9:0-47 55:38-47
@ ./src/components/app/App.tsx 25:0-36 82:138-147
@ ./src/index.tsx 5:0-39 6:50-53"
-->
After this, the GUI starts but there is no option to create a wallet or install the existing 24 words"
To Reproduce
I have tried this on two different machines, with e same error!

Bug fixed, thanks 6708b50

Sorry for the delay.  I actually was going to test this first first but had to install a GUI version of Ubuntu and then got stuck on the day job.


Disable mscolab login without credentials

The login button should be disabled if the mail and password has not yet been provided.

I have solved this issue and commiting changes


Error: "Get displays from point failed" on MacOS

This error happens to me when I plug in a second monitor, then arrange the displays so the second monitor appears to the left and above the primary monitor. See the image.
SECONDARY ISSUE:
The whole request fails whenever there is an issue returning results for any window in ImplWindow::all().
Instead of failing when one window is unavailable, could xcap instead proceed to return valid results for the other windows that didn't fail? Perhaps by returning a Vec<Option<Window>>

@nashaofu xcap is great, thank you for making it! I'd be willing to sponsor you more to clean up some bugs and panics.

@nashaofu xcap is great, thank you for making it! I'd be willing to sponsor you more to clean up some bugs and panics.

Thank you very much for your sponsorship. I will try to fix it this week

@nashaofu xcap is great, thank you for making it! I'd be willing to sponsor you more to clean up some bugs and panics.

Thank you very much for your sponsorship. I will try to fix it this week

Thank you

I have fixed this issue, try upgrading to 0.0.6.

This also seems to have fixed another issue where the coordinates of windows in were outside the bounds of their monitor. I'll report if I see that issue pop up again. Great work.


Remove Ionicons Sass aliases

Short description of what this resolves:
Fixes errors due to missing sass aliases:
Module build failed:
@import "ionicons-variables";
^
      File to import not found or unreadable: ionicons-variables

This:
@import "ionicons-icons";
@import "ionicons-variables";

cannot work without aliases defined in ionic.config.js or webpack or any tool you want to use to compile your Sass.
Changes proposed in this pull request:

Change import from alias to direct path

Ionic Version: 2.x
Fixes: #5155

Hey thanks for the PR!
This is intentional, as where you install your modules isn't a concern of the framework. That way you can install ionicons anywhere you like, and it's up to you to point whatever Sass tool you choose to use, whether it is sass-loader or gulp-sass, in the right direction.

This PR uses ~ that represents the path to wherever you install your dependencies and  ionicons/dist/scss/ionicons-icons will alway be the same as it represent the path within ionicons repo. I do not understand your answer.
@tlancina do you have any example on how to make it work with sass-loader if you do not want to merge that?
thanks :)

I believe ~ is a webpack-specific shortcut for node_modules, in which case it wouldn't make sense for us to add it to the framework, because it would break all other toolchains.
sass-loader allows you to specify Sass options, so you would use includePaths:
module.exports = {
  ...
  module: {
    loaders: [
      {
        test: /\.scss$/,
        loaders: ["style", "css", "sass"]
      }
    ]
  },
  sassLoader: {
    includePaths: [
      "node_modules/ionic-angular",
      "node_modules/ionicons/dist/scss"
    ]
  }
};

I really thought ~ was a sass thing o_O
I guess I use webpack too much :)
I ported the conference app into webpack + typeScript => https://github.com/shprink/ionic2-webpack-boilerplate
You guys should have a look at it, IMHO this architecture is better in a lot of ways.
Thanks again @tlancina,
Julien


merge pull request for Mustang on-tasks repo into RackHD upstream repo

BUILD on-tasks #62 : FAILURE

BUILD on-tasks #62  Error Logs  ▼Test Name: Base Job Subscriptions should clean up subscriptions for every subscriber helper method
Error Details: callback.bind is not a function
Stack Trace: TypeError: callback.bind is not a function
    at InnerMockJob._subscribeHttpResponseUuid (lib/jobs/base-job.js:9:10938)
    at spec/lib/jobs/base-job-spec.js:222:35
    at node_modules/lodash/index.js:3073:15
    at baseForOwn (node_modules/lodash/index.js:2046:14)
    at node_modules/lodash/index.js:3043:18
    at Function.<anonymous> (node_modules/lodash/index.js:3346:13)
    at Context.<anonymous> (spec/lib/jobs/base-job-spec.js:212:15)

got enough comments on merge

BUILD on-tasks #76 : FAILURE

BUILD on-tasks #76  Error Logs  ▼Test Name: Base Job Subscriptions should clean up subscriptions for every subscriber helper method
Error Details: callback.bind is not a function
Stack Trace: TypeError: callback.bind is not a function
    at InnerMockJob._subscribeHttpResponseUuid (lib/jobs/base-job.js:9:10938)
    at spec/lib/jobs/base-job-spec.js:222:35
    at node_modules/lodash/index.js:3073:15
    at baseForOwn (node_modules/lodash/index.js:2046:14)
    at node_modules/lodash/index.js:3043:18
    at Function.<anonymous> (node_modules/lodash/index.js:3346:13)
    at Context.<anonymous> (spec/lib/jobs/base-job-spec.js:212:15)


encoding/json changes type of large integers when deserializing and then serializing

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.7.4 darwin/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.7.4/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.7.4/libexec/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/kp/n63r7pwn20s8wwlfxc_npn440000gn/T/go-build285133725=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
What did you do?
I deserialized a json object
{"Event":{"id":182295565},"Error":"some error","ClientName":"client","Critical":true}

that has an arbitrary object in the Event field. I then serialized the object in the event field.
https://play.golang.org/p/8P8cQ1iHxH
Fina
What did you expect to see?
I expected the serialization to produce the same string as it received
{"id":182295565}

I then wanted to deserialize this into another struct (OtherStruct in play.golang.org link)
What did you see instead?
{"id":1.82295565e+08}

and when I tried to deserialize into
type OtherStruct struct {
	ID int
}

I get the error
json: cannot unmarshal number 1.82295565e+08 into Go value of type int

This is "fixed" (changed in a way that happens to work for your case) in Go 1.8.
See https://beta.golang.org/doc/go1.8#encoding_json
But to be explicit about preserving integers, see https://golang.org/pkg/encoding/json/#Decoder.UseNumber

@bradfitz thanks!


Support existing conditions

Towards https://github.com/giantswarm/giantswarm/issues/14322 and https://github.com/giantswarm/giantswarm/issues/14553
What's in the box:

Generic condition handler for summarizing conditions into a single summary condition (used for Ready condition).
Generic composite condition handlers for combining multiple handlers into one (used for combining multiple condition handlers in to a hander used for reconciling a CR).
Condition handlers for generic Creating, Upgrading, Ready and InfrastructureReady conditions that can be used in Cluster and MachinePool controllers.
Condition handlers for Cluster ControlPlaneReady and NodePoolsReady conditions.
Factory functions for creating Cluster and MachinePool conditions handlers that can be then used in an operator out of the box.

Checklist

[x] Update changelog in CHANGELOG.md.
[ ] Improve tests for InfrastructureReady like it's done for ControlPlaneReady now.

This will be used in azure-operator master for now, so it will not be released until the next minor release.

This is quite difficult to review due to size + ordering of files compared to design / code flow.

Yeah, sorry for the huge PR, I should have tried to split it, it was just many thing s done in parallel, as nothing could be used in azure-operator without actually having everything.
The logic for setting existing conditions is basically the same, with different implementation in some places, and some more fine-grained details, such as more specific condition reasons, so the status is more precise.
Plus new ControlPlaneReady condition for Cluster, and now setting Creating condition for MachinePool as well.

I left minor nits for few places that struck out.
Regarding this design:
Isn't the passed obj always a non-pointer instance of a CR object?

I believe it's the pointer, we then just always get the value from that pointer, here's for AzureConfig for example https://github.com/giantswarm/azure-operator/blob/master/service/controller/key/key.go#L542-L554, we do the same for other CRs.

How does UpdateStatus flag relate to this or in other words: what's the purpose of UpdateStatus flag of handler configuration?

Since condition handlers are combined, it is used so the status is not saved in every condition handler, but only in the last one. That way, when the controller executes the outer/composite handler (that contains all smaller per-condition handlers), the status update is only done once (it's the equivalent of the current behaviour in the azure-operator, now just every condition has it's own handler).
Here is where it's used https://github.com/giantswarm/conditions-handler/blob/support-existing-conditions/pkg/internal/handler.go#L90-L95
How does that look? Would it be better to just save CR Status every time?
To elaborate more on this composite handlers stuff:
Here you can see how the handlers are actually added to azure-operator Cluster controller https://github.com/giantswarm/azure-operator/blob/use-new-condition-modules/service/controller/cluster.go#L101-L113
That is creating an instance of composite.Handler, which is simply calling in the list of handlers it contains, like this https://github.com/giantswarm/conditions-handler/blob/support-existing-conditions/pkg/conditions/composite/handler.go#L52-L62
And here is the opinionated function (used above in azure-operator) that creates the Cluster conditions handler for azure-operator https://github.com/giantswarm/conditions-handler/blob/support-existing-conditions/pkg/factory/cluster.go#L23
It's done similarly for MachinePool.

How does that look? Would it be better to just save CR Status every time?

Ah, I got confused with the operator key functions and didn't realize that this had own one that returns pointer. I suspected for a second that the change doesn't carry over to next handler, but it does. All good in that regard.
I fully support the idea of only calling Update() once in the end since otherwise it would be quite a mess with k8s update events in controllers.


Update Documentation to use En-dash Code Points in Command Line Examples

Copy/pasting the sqline -u command lines result in errors like
# bin/sqlline –u jdbc:drill:schema=dfs;zk=zk-0
���u (No such file or directory)
jdbc:drill:schema=dfs (No such file or directory)

This was due to the docs using en-dash (code point 8211) instead of a regular ascii dash.
JIRA: https://issues.apache.org/jira/browse/DRILL-7462

+1

I just got it by this one.
I let it here for Google:
–n (No such file or directory)
drill (No such file or directory)
–p (No such file or directory)
xxxxxxx (No such file or directory)


Add var/sessions to shared for symfony 4 recipe.

Q
A

Issue Type
Bug

Deployer Version
6.1.0

Description
Missing var/sessions.
Also add cache:warmup to standard flow.

This one seems to be resolved. Even cache:warmup can be seen in 6bf05659740322e5440b5bd48fb45fadb3fced60 commit.


High performance for right-branching strategy

Really appreciate for releasing the code.
I found when I testing the baseline of right-branching strategy on WSJ test set, the F1 is really high (39.87), which does not match the result in the paper (16.5).
I have just changed the code
distance = model.distance[0].squeeze().data.cpu().numpy()
distance_in = model.distance[1].squeeze().data.cpu().numpy()

into
distance = numpy.array([numpy.arange(len(sen), 0, -1)] * 3)
distance_in = numpy.array([numpy.arange(len(sen), 0, -1)] * 3)

, which represent a right-branching strategy.
And the result on WSJ test set is:

So, what my be the reason? Thanks a lot if u could help me out.

We was using the baseline from previous paper. Please check the newest version of our paper for our own baseline score. https://openreview.net/pdf?id=B1l6qiR5F7

That is really helpful. Thanks for your reply. 👍
b.t.w., the previous paper did the evaluation without preprocessing to filter out the punctuations. That matters a lot for the evaluation result, which might be because the punctuations usually appear in the high-level compositions.


Request to update prerequisites/dependencies with CMake version number.

RPC needs to build with CMake 3.17, since the latest version 3.18 causes build issues with component dependencies.

Updated README.md with CMake version info.


Changed notes to match example

Coverage remained the same at 82.675% when pulling 14a83e72f9f3992ec1f5ac9ff1d6b1ecaa503041 on derekdreery:patch-1 into 80a1deab58d1faf41c05a5d741d9e3f51bde3a55 on Geal:master.

Thanks! There are lots of useful documentation PRs recently ;)

:)


Created MenuLinkTrait so we can share menu links for Functional tests…

… as well

Codecov Report

Merging #15 (d9abd9b) into main (be43a31) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #15   +/-   ##
=========================================
  Coverage     54.29%   54.29%
  Complexity      158      158
=========================================
  Files            18       18
  Lines           466      466
=========================================
  Hits            253      253
  Misses          213      213

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


leaks in soter_rsa_key_pair_gen_init() [again]

I am look at the source code of soter_rsa_key_pair_gen_init() again. I can not understand why we call only EVP_PKEY_CTX_free() in bad case.  EVP_PKEY_CTX_new() makes up ref of pkey. EVP_PKEY_CTX_free() make "down ref" of pkey but not free pkey.
Correct me if I'm wrong.

https://github.com/openssl/openssl/blob/master/crypto/evp/p_lib.c#L153
https://github.com/openssl/openssl/blob/master/crypto/evp/pmeth_lib.c#L272
https://github.com/openssl/openssl/blob/master/crypto/evp/pmeth_lib.c#L173
https://github.com/openssl/openssl/blob/master/crypto/evp/pmeth_lib.c#L432
checked how it implemented in openssl and you are right. we should call EVP_PKEY_free(pkey) too

The leaks have been plugged.


Async code sometimes lead to firmware crash

The code written by @nevyn highlighted a bug which makes the device misbehave, or sometimes crash:
https://discord.com/channels/963222352534048818/1107927061391233065
https://github.com/nevyn/allocle/blob/1f24d530cfed0d7d1977c644217944f5fd66a753/device files/main.py

This could be debugged with #228

Testing for a while, this this seems stable now. Will reopen if it happens again


1.0.0+ Enhancement Requests and Known Bugs

Logging enhancement requests and known bugs here. If you have reported a bug or feature request and it is accepted as such, then it will show up here and your original issue will be closed.

Enhancements

Command tab-completion - argcomplete is already coded in. Just need working processes documented to enable in Windows, MacOS, and Linux.
Multi-Execution Result Assembly - Multiple executions when piping produces multiple tables or JSON dumps instead of compiling everything into a single result. It is possible that the output of each of the results may be different. May want to compile results or have an option to do so.

#Bugs

Error Kills Looped Execution - Looped execution (like when pipelining) can be broken by a single error in one of the execution events. This can be seen by issuing meraki organizations getOrganizations | meraki -t "organizationId-id" organizations getOrganizationNetworks when at least one of the organizations is not API-enabled. May want to add error catching or control when performing looped execution.

Documentation Fixes

Add note about using AKI key env variable for pipelining


License file should not contain brackets

Regarding to Apache License appendix How to apply the Apache License to your work the license file should not contain placeholders and brackets should be replaced with the real copyright owner and year:

To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "{}"
replaced with your own identifying information. (Don't include
the brackets!)  The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.

The following line should be changed:

Copyright {yyyy} {name of copyright owner}

To smth like:

Copyright 2018, TeamDev Ltd.

The instruction at the footer says what to do when apply contributor's copyright to a derived work.
See, for example how Guava has a similar instruction in their COPYING file.


output es2017 instead of es2015

I think the "es6" output should use es2017 instead of es2015.
I was tried to compile the firebase-js-sdk with closure.
However with es2015 output, tsc put in a polyfill for async functions that closure compiler doesn't understand. If I change it to es2017 the async functions go directly into the .closure.js file and closure compiler can handle them.

The "es6" output is misnamed, it should be "production", meaning it's the output intended for optimizing bundlers to consume.
I agree that the target should be the highest level language syntax that the (supported) downstream tooling can consume. I think we'd need to do some testing to see if target=es2017 breaks anything with other tools, but it seems like the right thing to do.
/cc @evmar

We should rename output=es6 into output=closure or something.  We already key off of it in other ways, like
https://github.com/angular/tsickle/pull/859/files
          // Use 'const' in ES6 mode so Closure properly forwards type aliases.
            host.es5Mode ? undefined : ts.NodeFlags.Const));

Why is rules_typescript overwriting the tsconfig.json settings for this? I guess I am confused generally why rules_typescript overwrites the output location and the outDir. Is this just the way that bazel needs it to squeeze javascript into its output structure?

Working on a proposal whereby the default output of ts_library is whatever target/module settings from your tsconfig. We'd still have two bazel-controlled flavors (named modules for dev and ESM modules for bundling) so it's possible one ts_library would cause three compilation actions rather than two.


"Import Carla" leading to module not found for Python3.12.24

CARLA version: 0.9.13
Platform/OS: Windows
Problem you have experienced: Trying to import .xodr file into carla using Vscode script, but using
**import carla
def main():
client = carla.Client('localhost', 2000)
client.set_timeout(10.0)**
and returning error
"Traceback (most recent call last):
File "c:\Carla\carla-dev\Build\osm2odr-source\src\TestFile.py", line 13, in
import carla
ModuleNotFoundError: No module named 'carla'"
I've tried to see if Carla is not compatible with the Python I am running, which is 3.12.24, and have downgraded to 3.8.10. However, the import carla still does not work and it says the module not recognized. Any help would be appreciated!

For carla 0.9.13 you probably need to go back to Python 3.7  and use the .egg / wheel provided within that installation.
On PyPy you have these options: https://pypi.org/project/carla/0.9.13/#files

Currently 0.9.15: Python 3.7-3.10 are the versions that are mostly supported. Personally I haven't tried going higher.
https://pypi.org/project/carla/#files

You probably have to add the CARLA .egg/.whl file path to the $PYTHONPATH environment variable for Python to know where to find it.


Create a blog post on Mocking

Description:
Make use of Function Mocking and Object Mocking along with Service mocking to demonstrate the capabilities of mocking in the test framework
Describe your task(s)

[x] Create a service to test on
[ ] Demonstrate Function mocking
[x] Demonstrate Object mocking
[ ] Demonstrate using a mock service

Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

https://github.com/Ibaqu/CodeBlogs/blob/Mocking/Mocking/Mocking.md

Blog Unit test Ballerina Integration with Mock Backends : https://docs.google.com/document/d/1Q44k4GqaA0zeBV0RMD_-PkZwBZRn5VC0R2CiPJ9D5fo/edit?usp=sharing


fix: ruby-version failure

Goal
Fix "Your Ruby version is 2.7.3, but your Gemfile specified 2.7.2" failure.
Approach
Use >=.

@wraasch merging since the changes aren't user-facing.


Function: checkHash

A simple function to compare the sha1 hash value of old and new file.

Generate sha1 hash of old file $hash1
Generate sha1 hash of new file $hash2
Return 1 if $hash1 = $hash2

Tested and validated.


Standardize See also section to use bulleted list

Summary

use bulleted lists in See also section
use sentence case in heading
fix minor Markdown warnings
applied to whole /docs/fsharp folders

Contributes to #6923

You're welcome @mairaw
Actually, this PR only concerns the F# Guide area

My bad! It wasn't supposed to be part of that commit.

Don’t worry!

Be happy 👍


RSA 4096 support ?

Hello,
I'm wondering whether or not the ring supports RSA 4096, the product page says "RSA 2k", which I guess stands for RSA 2048 but looking for technical specification on Infineon website about their SLE78 chip, I saw that all the variants are supposed to support RSA up to 4096 bits.
Using this Applet I was indeed able to make gpg works with 2048 bit RSA but failed to use 4096 bits or 3072 bits keys.
So are we stuck with RSA 2048 or is there a way to make larger RSA keys work ?
Best regards

+1 Would be great to know if it can support RSA 4096
Have you had any luck?


Update README.md

Added bng2latlong API, which converts British easting and northing into latitude and longitude. Free to use for any purpose.
Thank you for taking the time to work on a Pull Request for this project!
To ensure your PR is dealt with swiftly please check the following:

[ ] Your submissions are formatted according to the guidelines in the contributing guide
[ ] Your additions are ordered alphabetically
[ ] Your submission has a useful description
[ ] The description does not end with punctuation
[ ] Each table column should be padded with one space on either side
[ ] You have searched the repository for any relevant issues or pull requests
[ ] Any category you are creating has the minimum requirement of 3 items
[ ] All changes have been squashed into a single commit

Thank you

Thanks Yann!


Roll engine 1cada0a6dca6..f15cc3402938 (1 commits)

git@github.com:flutter/engine.git/compare/1cada0a6dca6...f15cc3402938
git log 1cada0a6dca6..f15cc3402938 --no-merges --oneline
2019-09-19<EMAIL_ADDRESS>Roll src/third_party/skia 18531cde2ab7..9a8b846baf43 (1 commits) (flutter/engine#12360)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5266357152645120 , https://cirrus-ci.com/task/4984882175934464 , https://cirrus-ci.com/task/6392257059487744 , https://cirrus-ci.com/task/4703407199223808 , https://cirrus-ci.com/task/5829307106066432 , https://cirrus-ci.com/task/6708916408287232

Commit queue failed; closing this roll.


Fixnetcdf

James
solved netcdf issue for waterbodies

Thanks @jdhondia-noaa
Will you please change the pull request so that it is coming into jameshalgren:module_reservoir?

redirected to fork.


[Feature] - Improve navigation between command usage and handler implementation for CQRS projects

@SylvainMarty  Thank you for reporting this feature request in KartanHQ/intellij-nestjs/ repo . I'm launching a NestJS plugin. I'm planning to include this functionality into this plugin. Unfortunately, the maintainer of KartanHQ/intellij-nestjs/ repository does not have enough bandwidth to add more features or accept PRs at this time.

Is your feature request related to a problem? Please describe.
We use CQRS (@nestjs/cqrs) extensively in our NestJS monorepo project and many of our developers complains about navigation between CQRS files being not very efficient nor natural.
The main complaint was how slow it was to navigate from the usage of Command/Query to the dedicated Handler which does the work under the hood.
Here is an "example" of the problem:
// 1. The dev see this code somwhere:
const command = new MyCommand();
await this.commandBus.execute(command);

// 2. The dev wants to go to the handler which implement the command logic
// First, it needs to do "Go to implementation" (Ctrl + B) to see the command class definition
// Then it needs to "Go to Declaration and usage" (Ctrl + B) to see all the usages and select the one which relates to the handler
Since our code is mostly CQRS implementations, this mechanic needs to happen a lot of time and is not very efficient.

Aside that, we really like CQRS, we just want to be more efficient using it. :-)
Describe the solution you'd like
I'm not sure what the best solution would be but I was thinking that it would be easier to have a shortcut/option to go to the implementation of a command (aka its handler).
I think it may be possible to get this information since all commands are references by its handler in the @CommandHandler(MyCommand) annotation.
Describe alternatives you've considered
I searched online to see if there were any plugins or shortcut in Intellij based IDE to achieve this but so far, I only found a feature specific to Resharper: Resharper > Navigate To > Consuming APIs.
Sadly this feature is not present on our IDE (PHPStorm).
Additional context
I never developed plugins for Intellij but I have experience in Java/Kotlin and I'm interested in submitting a PR if you think it can be handled by this plugin. 😃

Scheduled for v0.0.3

Scheduled for v0.0.4


crates.io?

When will you upload this crate to https://crates.io?

I'm planning to upload it the next week, i'm currently trying to avoid Boxing in parse and i want to write some basic documentation for the parse derive macro

This crate is now at crates io at https://crates.io/crates/zephyrus


CustomModelData in display_item + custom "back" icon

Unlike the kit items, the display icon in the GUI menu does not support nbt and custommodeldata, which would be useful.
It would also be appreciated if the "back" icon could be modified in the same way (lore, custommodeldata, enchants etc).

I will add this feature in future updates.


feat: create Service trait

Closes https://github.com/hyperium/hyper/issues/2853.

Ok, I see. You could leave the tower-service dependency in for now, since the work to transfer this client stuff is in a separate PR, and then this PR is just replacing the server side. Then when both PRs are done, we can chop out of the Cargo.toml. I think that'll be the least complicated as all this movement happens.

I might be doing something wrong, but it's impossible to just replace the server part. It would require maintaining duplicates of most parts of src/service and some parts src/common, one with stuff tower_service::Service and one with hyper::service::Service. The clean sweep throughout the repo was the closest I got to compiling, working code. Trying to do anything local to src/server just keeps leaking to other parts of the repo.
@seanmonstar could use some guidance here. I saw you did some work on removing tcp feature and parts of src/client. Should I maybe wait till client part is completely gone? I think clean sweep remove of tower_service dependency is the best way to move this MR forward.

Alright, with the help of cross-cutting removals of code Sean have done to the client module, this PR was way easier to do.
Looks good to me now, @seanmonstar I'd ask for CI run and if it's all green (except for miri) a review.

Dumb mistake, I fought the compiler for so long I forgot to run the tests once the project finally compiled.
Locally, all the tests (including examples) pass now.
There is only one reference to tower left in the whole project, and it's in doc-string in client/conn/mod.rs here. If we could remove it, it would be a clean sweep of tower from the project.

I can do fmt + check or test, but I seem to uncapable of remembering to run all 3 of them before pushing :smile:

Alright, couldn't stop myself from removing the last tower reference from client::conn::SendRequest. The repo is now all free of the dependency. If you think that's wrong, I can revert the last commit.

Juuust one more CI trigger.

@seanmonstar Could you address https://github.com/hyperium/hyper/pull/2920#discussion_r950670503 and https://github.com/hyperium/hyper/pull/2920#discussion_r950680044, and I'll move this PR forward?

@seanmonstar I introduced changes from the discussion threads.
LGTM, let's wrap and merge this as soon as possible, as the merge conflicts on this branch are killing me ;)

CI failed on a doc-test, this should be fixed now.

Thanks so so so much! I know this dragged on a while, but it turns out there were tricky things for us to figure out (and conflicts as all sorts of other things got yanked).


Fix CI (io_uring not supported)

Currently the CI uses Linux 5.15, which doesn't support operations such as the send(2) system call, which is a bit of a pain. The next Linux LTS, v6.1, does support everything we need so maybe it's just a matter of waiting until Ubuntu LTS starts using that.

I've split up and disable the CI for now (in https://github.com/Thomasdezeeuw/heph/pull/596), list to enable:

[ ] Heph
[ ] Heph-rt
[x] Heph-inbox
[ ] Heph-HTTP
[ ] Heph-remote

Add support for testing under miri:

[ ] Heph (after we remove the test dependency of Heph-rt
[x] Heph-inbox.

For the other crates we can't as Heph-rt doesn't work under miri and the other crates depend on it.

For context https://github.com/Thomasdezeeuw/heph/pull/577 introduced the usage of io_uring.

I think we'll have to wait a couple more month until Ubuntu 24.04, that should work.

I have since gotten the CI to work for A10, but I'm not sure if it's worth the effort Heph at the moment.


JMX Registry SSL Enabled

Description:
Add JMX registry ssl enable configuration.
Link to tracking Issue:
N/A
Testing:
Turn on rmi registry ssl in test jar. Turn on ssl in contrib. Able to get metrics.
Documentation:
Add comment to config file

Test failures are unrelated to pr


Angular 12

This does not work with Angular version 12. I tried all your versions none is working with it

Hi. Is there any error when you start the app?

I'm using Angular 12 (i have no choice, I had to downgrade from13 it) anyways, I might be facing the same issue. Which is:
Error: node_modules/ngx-chess-board/lib/engine/drag/end/drag-end-processor.d.ts:1:28 - error TS2307: Cannot find module '@angular/cdk/drag-drop' or its corresponding type declarations.

1 import { CdkDragEnd } from '@angular/cdk/drag-drop';
                             ~~~~~~~~~~~~~~~~~~~~~~~~

@yousefalaqra try please install angular cdk npm i @angular/cdk
SInce some Angular version it got deleted as i remember
Let me know if this helped

@grzegorz103 Yes, it works right now! thank you! I would be happy to contribute to your source code, let me know what do you need and I would be love help.
Anyways, I've checked the source and I see that the angular CDK is already installed, why do I need to install it again in my project?

Thanks. This lib has already more things implemented than i ever planned so feel free to push anything comes to your mind :)
Angular cdk is added as peer dependency to the lib, so it isn't installed automatically with the lib. It could be added as normal dependency instead of peer, but im not sure if it is good practice to manage dependencies that way in angular

I think there's a performance issue that I'm considering working on it. I'll investigate it, report it, and fix it


Player#track is not unset when a track is manually (Player#stopTrack()) or automatically ("end" event) stopped.

Player#playTrack() can be used to play a given track. It goes ahead and sets Player#track to the track that is being played, and from there you can do Player#track !== null to check that a track is being played.
However, Player#stopTrack() does not unset this value, meaning if I do Player#playTrack(), and then Player#stopTrack(), Player#track will still be set, even if the player is not playing anything at all.
Similarly, I believe when the library emits "end" in Player#onPlayerEvent(), it also doesn't unset the track.

It entirely depends on implementation in my opinion for this case. stopTrack() does what it says, it stops the playback, which sets the position to 0. I didn't set the track to null because I don't think stopTrack() means clear. Eg: see how musicbee implements stop in the video, they just set the time to 0 and stops the playback, which is I think very fitting. Most other players don't even implement stop button nowdays, see spotify for that.
Eitherways, I don't think I need to set the track to null when you stop since you are just stopping the playback, you aren't clearing it, hence setting the position to 0 which signifies the playback has been stopped is fine in this case.
Changing this however would be breaking, since changing this would require other users to change something in their code if they get the last played track from Player#track, but we'll see I guess?
https://github.com/shipgirlproject/Shoukaku/assets/36309350/f1799034-89c8-4426-b22d-3c4afe288b0d

If you really need that functionality however, there is a way to do that without forking it by extending the player class yourself, then doing something like:
async stopTrack() {
  await super.stopTrack();
  this.track = null;
}

onPlayerEvent(data) {
  if (json.type === "TrackEndEvent") this.track = null;
  super.onPlayerEvent(data);
}

then put it on options.structures of Shoukaku

I didn't set the track to null because I don't think stopTrack() means clear
Well, no, but clear() is an action that's intended for resetting the player to its base state, it can't be used for getting rid of the current track.

Changing this however would be breaking, since changing this would require other users to change something in their code if they get the last played track from Player#track, but we'll see I guess?
Was track not intended to be for getting the current track, and not the last track? I'd argue if a developer uses an API in a way that wasn't intended, that's not the responsibility of the library developer to maintain the behaviour of, and therefore would not be a breaking change if changed.

In the Lavalink documentation, the track value is also documented as being the 'currently playing track'.

Was track not intended to be for getting the current track, and not the last track? I'd argue if a developer uses an API in a way that wasn't intended, that's not the responsibility of the library developer to maintain the behaviour of, and therefore would not be a breaking change if changed.

track is intended for the current track. I didn't notice that I was being illogical to myself there. What I meant in here if they use the #track property on TrackEndEvent for doing something about the track, like storing it somewhere, or using it to decide what to do next. While it is included in the event payload here, it would be breaking if some user do use the track prop instead.
But eitherways, I don't think we should be still clearing the Player#track prop on stopTrack() because you are just stopping the playback as I said earlier, we dont "clear" it. But personally this is up to one's implementation and understanding of what stop.
On lavalink src, they don't also clear it.
see: https://github.com/lavalink-devs/Lavalink/blob/0ea9afdef8d485d6bf9ad5f09af8352f6da561c6/LavalinkServer/src/main/java/lavalink/server/player/LavalinkPlayer.kt#L85
and see: https://github.com/lavalink-devs/Lavalink/blob/0ea9afdef8d485d6bf9ad5f09af8352f6da561c6/LavalinkServer/src/main/java/lavalink/server/player/EventEmitter.kt#L59

Theres one caveat though, lavaplayer do have activeTrack and previousTrack in their audioPlayer class, but Shoukaku don't implement that, nor really need it, hence imitating the behavior of music players seems to be a good choice in here.

Right, well, it's a small gotcha. I don't suppose it's that much of a problem, though, especially since it can be worked around. And, sure, I suppose it's up to the implementation.
Closing.


Fix initilize initialize, etc

Fix initilize initialize, etc

@co63oc Thanks for your pull request, and  can you merge several of your commits into one pull request so that we can review and merge once?

and it seems linter test has failed,  you can refer to https://github.com/modelscope/modelscope/blob/master/docs/source/develop.md#1-code-style to format your code and doc

Thanks, the prs are merged, and have run "pre-commit run --all-files" to change code


angular loadChildren Can't bind to 'ngModel' since it isn't a known property of 'nz-tree'

Version
1.1.1
Environment
Angular CLI: 6.0.8 Node: 10.3.0 OS: darwin x64 Angular: 6.0.7
Reproduction link
https://stackblitz.com/edit/ng-zorro-antd-start-qhvcxh?file=src/app/app.module.ts
Steps to reproduce
无
What is expected?
正常
What is actually happening?
angular loadChildren Can't bind to 'ngModel' since it isn't a known property of 'nz-tree'
Other?
angular loadChildren Can't bind to 'ngModel' since it isn't a known property of 'nz-tree'
import { NgModule } from '@angular/core'
import { CommonModule, registerLocaleData } from '@angular/common'

import { ManageRoutingModule } from './manage-routing.module'
import { ManageComponent } from './manage.component'
import { NgZorroAntdModule } from 'ng-zorro-antd'

import zh from '@angular/common/locales/zh'
registerLocaleData(zh)

@NgModule({
    imports: [CommonModule, ManageRoutingModule, NgZorroAntdModule],
    declarations: [ManageComponent],
})
export class ManageModule {}

https://angular.cn/guide/template-syntax#emformsmoduleem-is-required-to-use-emngmodelem


Add overdrafts to Corebanking back end

Diffblue has found some code changes please check these are intended https://github.com/diffblue/CoreBanking/compare/dcover-demo-01/05-115644...dcover-demo-01/05-115644-Diffblue-tests?expand=1


[Usable - Bot Framework Web Chat - Markdown]: Narrator is not announcing the name for the 'https://bing.com?q=some' and 'http://www.markitdown.net/' links

User Experience:
Screen reader users get affected and cannot know the purpose of the links if the screen reader doesn't announce the name of the link when it receives focus. Screen reader users cannot understand its purpose, they miss accessing it.
Note:
User credentials should NOT be included in the bug.
Repro Steps:

Launch URL: https://microsoft.github.io/BotFramework-WebChat/01.getting-started/a.full-bundle/ on edge dev.
Web chat page opens.
Press 4-tab keys to reach 'Type your message' field. Enter the "markdown" keyword on it. Press 1-tab key to reach the 'send' button and activate it with the enter key.
Press 2-shift tabs and 1-down arrow to reach the received card. Activate it with enter key. Focus lands on 'mark it down' link. Turn on screen reader (Narrator).
Press 1 or 2 tab keys to reach 'https://bing.com?q=some' and 'http://www.markitdown.net/ links'.
Verify whether the screen reader announces the name of the links or not.

Actual Result:
Narrator is not announcing the name for the 'https://bing.com?q=some' and 'http://www.markitdown.net/' links
Observation:

Narrator announces as "link" for both the links when focus lands.

NVDA Behavior: It announces as "https://bing.com?q=some](https://bing.com/?q=some) Opens in a new window; external. link Opens in a new window; external" and " http://www.markitdown.net/ Opens in a new window; external. link Opens in a new window; external."

JAWS Behavior: JAWS announces as "https://bing.com?q=some](https://bing.com/?q=some) Opens in a new window; external. Link" and "`http://www.markitdown.net/ Opens in a new window; external. Link

Expected Result:
Narrator should announce the name for the 'https://bing.com?q=some' and 'http://www.markitdown.net/' links when focus lands on them.
Note:

Issue doesn't repro with JAWS and NVDA.

Reference Links:

External Bug Process: If this bug belongs to external team, mark it as resolved/done and assign it back to the tester with notes on where to file/route the bug. For more information, please use this Link. “HCL Staff should not log any third-party external bugs. Should be routed to edad team”.
Please reach out to C&AI Teams channel for any process related queries.

Test Environment:

OS: Windows 11 Enterprise 22H2 (OS build: 22621.1555)
Browser: Edge Version 114.0.1807.6 (Official build) dev (64-bit)
URL: Web Chat: Full-featured bundle (microsoft.github.io)
Tools: Developer Tool
Screen Readers: Narrator, JAWS, NVDA
Matrix: Edge dev+ Narrator.

#A11yUsable;#A11ySev4;#HCL;#Accessibility;#Benchmark;#Win11-Edge(Chromium);#BotFrameworkWebChat-Apr23

This is an issue with the bot content, rather than Web Chat. I am going to fix it on the bot side.

This is an issue with Windows Narrator + Edge 116.0.1931.0 and is outside of Web Chat.
It seems when the link starts with https: and followed by an , Windows Narrator will only narrate "link".
This is the minimal repro.
<!DOCTYPE html>

      Not repro:
      Hello will be narrated as "link, hello".

      Repro:
      https:Hello will be narrated as "link".

      Not repro:
      https:Hello will be narrated as "link, H-T-T-P-S hello".

      Repro:
      ftp:Hello will be narrated as "link".

      Repro:
      anything:Hello will be narrated as "link".

      Not repro:
      anything: Hello will be narrated as "link, anything hello".


Fix flaky casper test for messsage edits

.message_edit_notice is too broad of a selector to
test if your most recent edit has posted. Also
check if the currently selected message is the one
that's been edited.

Automated message from Dropbox CLA bot
@acrefoot, it looks like you've already signed the Dropbox CLA. Thanks!

@TomaszKolek FYI

Merged, thanks @acrefoot!


verify!() on non-copy data?

I have a parser returning a String that I want to wrap in verify! and do some stuff on the result with a map!.  Is that possible?
My non-working code:
named!(my_parser<MyType>,
       map!(verify!(parser_that_returns_string,
                    |s: String| !s.is_empty()),
       |s| MyType::CaseType(s))

As is, the compiler complains about "value used after move", which seems right.  But if I change to |s: &String| (or |s: &str|) the compiler complains that it expected type &String (or &str) but got String.
Is there an alternative version of verify! that borrows the value instead of expecting it to be a copy type?  Or could there be?

oh, a verify that would borrow would be good. I'll look into it, maybe there's a way to add one while keeping it backward compatible

Yes, verify_ref sounds good.

it is done in 717e7f0595de for the upcoming nom 5

(the verify combinator will take a reference in all cases)


fix: respect type reducibility when generating injectivity lemmas

This forward-ports https://github.com/leanprover-community/lean/pull/812.
For now, I am just creating this to see if it passes CI, since CI appears not to run on my branch in a fork.

The CI failure seems to be a simple matter of reordered messages; do we agree on the general change?

The CI failure seems to be a simple matter of reordered messages.

I don't look at PRs until it is green. We should make it clear to all PR submitters that this is a requirement.

do we agree on the general change?

The change is not properly motivated. A link to another thread is not an acceptable. We should also make it clear on the contribution guidelines that a clear and short motivation for unsolicited PRs is a requirement.


Functionality to use a custom requests.Session, additional optional constructor argument

Problem: When accessing the Wattsight API through a proxy, for example from a corporate network, in some cases some custom configuration of the requests.Session is necessary before using it for the first requests or authentication setup.
The PR adds an additional optional constructor argument to the wapi Session to be able to pass such a preconfigured requests.Session.
Default behavior stays the same, If no session is explicitly passed, one is instantiated as before.

Hi.  Just want to note that yes, this is a sensible extension, and one we have also talked about internally.
I would like to expand a bit on it, both in docs and unit tests, but I expect something very similar to be part of the next release.  In addition to configuring proxies, this approach is also more-or-less the only way it is possible to get around decrypting https proxies that some bigger organizations have in their networks.
(Then there was this thing about enough hours during the day...)

@volueinsight/dev-core This was an interesting feature which was being added sometime 2years back. What would be your comments on this?
For me unless any client agreed that they would like to have such an option, there is no point having this.


Rubocop 0.80.0 broke integration with overcommit

Steps to reproduce the problem
$ git init
$ cat >.overcommit.yml<< ENDOFFILE
PreCommit:
  RuboCop:
    enabled: true
ENDOFFILE
$ overcommit -i
$ touch test.rb
$ touch .rubocop.yml
$ git add .
$ git commit -m 'init'
$ echo 'p "Hi"' > test.rb
$ git add .
$ git commit -m 'first'

Resulting:
Running pre-commit hooks
Analyze with RuboCop........................................[RuboCop] FAILED
Unexpected output: unable to determine line number or type of error/warning for output:
 - Style/HashEachMethods
 - Style/HashTransformKeys
 - Style/HashTransformValues

✗ One or more pre-commit hooks failed

This warning was introduced in Rubocop 0.80. and marked as feature of RuboCop dev team (see https://github.com/rubocop-hq/rubocop/issues/7731#issuecomment-588097212)

I was able to work around this by adding --disable-pending-cops to RuboCop.flags in the config.

Thank you for the report and the clear workaround. Added as a default in 919350b0a15ebbe7f3cfd058f73e5941ee0e881e.


BugFix: DC gain for discrete-time systems

Fix for #114.
An alternative design would be to have LTI.dcgain call either self(0) (ctime) or self(1) (dtime); TransferFunction.__call__ could special case for s=0, so that g(0) and g.dcgain(0) return the same thing.  In this case __call__ would need to be implemented for StateSpace.  In my opinion evalfr and freqresp should both use __call__, and that horner should be deprecated.

Changes Unknown when pulling 3997637c522555e3e33c9eda1a7e160cabba7bc5 on roryyorke:rory/discr-time-dcgain-fix into ** on python-control:master**.

Changes Unknown when pulling 3997637c522555e3e33c9eda1a7e160cabba7bc5 on roryyorke:rory/discr-time-dcgain-fix into ** on python-control:master**.

Changes Unknown when pulling 84033fe56ccf1a82d3c0420e3821f9e5ef564977 on roryyorke:rory/discr-time-dcgain-fix into ** on python-control:master**.

Changes Unknown when pulling 84033fe56ccf1a82d3c0420e3821f9e5ef564977 on roryyorke:rory/discr-time-dcgain-fix into ** on python-control:master**.

rebased on 32f13bc.  Wonder why coveralls giving these "changes unknown" results?

rebased on 32f13bc.  Wonder why coveralls giving these "changes unknown" results?

regarding the mysterious "changes unknown" from Coveralls, it might be a bug in Coveralls server side.
Similar behavior is reported in https://github.com/lemurheavy/coveralls-public/issues/351

regarding the mysterious "changes unknown" from Coveralls, it might be a bug in Coveralls server side.
Similar behavior is reported in https://github.com/lemurheavy/coveralls-public/issues/351

Changes Unknown when pulling 310f5805f0fd51aa9e1191aaf3083d483421695d on roryyorke:rory/discr-time-dcgain-fix into ** on python-control:master**.

It seems that Coveralls is still broken. I measured change in test coverage on Python 3.5.2. Results:

Before your patch: 76.74% (687 missed statements; 2954 total)
After your patch: 77.47% (667 missed statements; 2960 total)

as reported from
nosetests --with-coverage --cover-html --cover-package=control

Your proposed change StateSpace.dcgain to return a matrix of numpy.nan values that has the same shape as the gain matrix is good. The documentation of StateSpace.dcgain should be updated for this.
This also constitutes API change, in particular change to the return type in certain cases. I am not aware of existing applications that would break. Furthermore, NaN spreads readily in a computation.
Therefore, I think that once my comment about documentation is addressed, this PR is good to go.

I had planned to fix the StateSpace.dcgain docstring and the whitespace - I guess it's too late on this PR?

I moved forward with the merge because my remaining comments can be addressed separately with no more effort than addressing them here (in this PR) would require. Also I noticed that there are several other issues of indentation style in the statesp.py, so the issue here and in the other locations can be handled separately soon.

I updated the docstring in ee75d9aab7f36f565fb3ddb3c9699be6c2084173 on master branch.


Feature Request: jade beautify

Would it be possible to allow .jade files formatting as for jade-beautify?

I don't use jade myself, but I expect that the inclusion or omission of the div tag would be a personal coding choice, rather than something that a beautifier should do for you. Other than that, jade-beautify doesn't seem to do much other than convert spaces to tabs and vice versa. Have a look at the extensions: TabSpacer, WhiteSpacer, and Whitespace for that functionality.
Having said that I think there is potential for a seperate extension for jade, especially given the new previewHtml command available in the 0.10.8 release.


comms: Add sol-netctl agent API V6

The agent is necessary in the process of network connection,
that will receive input information from the user and send it
to the network(such as AP and so on).
The API is based on connman D-Bus APIs, it provides register agent,
input login information and so on netctl agent API.
Signed-off-by: Wu Zheng<EMAIL_ADDRESS>

The Version 6 of Add sol-netctl agent API.

Modify the version 5 errors. (https://github.com/solettaproject/soletta/pull/2312)
Change the vector param of sol_netctl_request_input and request_input to ptr_vector.

@ceolin and @barbieri Please check it.

Please, review the comments and submit a new pr that I will integrate it. The serie is pretty good.
@wzhen12 is missing versioning netctl API, the structs in this module are not versioned. You don't need to do this for this pull request, since the problem exists before your pr.
Please let me know if you can do this in another pr.

@ceolin It is okay. Sorry, I have a Chinese holiday. I will have a response soon.


chromedp right click

I have not found a way I can do this/ do not understand the documentation, how could someone send a right click ANY way you know would help.

How about chromedp.ButtonRight() ?
https://godoc.org/github.com/knq/chromedp#ButtonRight

i've figured it out:
chromedp.MouseEvent(input.MousePressed, 477, 233, chromedp.ButtonType(input.ButtonRight)),
Took me alot of back and forth though and as I can see you could only do this with MouseEvent.

If you wanted to do the equivalent chromedp.Click with the right mouse button, then use the MouseClickNode event inside a QueryAfter. Click is a query action, while the Mouse* actions are input actions. The QueryAfter allows one to easily join the
if err := chromedp.Run(ctx,
    chromedp.QueryAfter(`thing`, func(ctx context.Context, nodes ...*cdp.Node) error {
        if len(nodes) < 1 {
            return errors.New("expected at least one node")
        }
       return chromedp.MouseClickNode(nodes[0], chromedp.ButtonRight).Do(ctx)
    }, chromedp.ByID),
); err != nil {

}

If you had looked at the source for Click, you would have seen this is basically what Click does. Unfortunately, it is not possible to pass both query options and mouse options to a single action signature.


Check that the documentation is up to date

Among other things, we should update information about the various related tools: Ortac has changed quite a lot, in particular.

It would be a good opportunity to revise its structure, to make it easier for newcomers.
#57 and #322 contain a few ideas.

Still missing elements in the documentation:

limitations to the supported language (include, for instance, see #302),
updates to the description of tools.

Closing as the documentation has been revised intensively.


Add nuxt-developer documentation

(as opposed to nuxt-app-developer documentation)
Feature request
Add a surface level overview of the architecture of nuxt:

What are the directories (in this repo, not a nuxt-based web app project)
What is the build + testing process
How directory watching and reloading is implemented
How filesystem API is implemented
How code-splitting is implemented

This will enable third party developers to make small contributions more easily, and potentially (it always happens) expose inefficiencies / incorrectness by talking through the architecture.

This is of course a great feature request, will work on it as soon as 1.0 is stable.
We want more contributors and of course we need a lower barrier for contributors to help making Nuxt.js better :tada:

This is partly done in https://nuxtjs.org/guide/contribution-guide
Please open an issue in nuxt/docs (https://cmty.app/nuxt/issues/new?repo=docs) for further discussions


Improve Give us Feedback form

Change User name to: Your name
Add email field: Optional field
3. Denise to provide the caption for email field

Removed 3. as we were going to place the Privacy Notice as a caption but it's in the text above the form so no need.

@Vino-S feedback button not visible to some user (i.e. @richardofsussex )

To check on Test 3.

Suggestions (for discussion):

Change 'Submit Problem Report' to 'Submit Feedback Report'
'Give us feedback' link is not relevant for this page. Maybe could be replaced with 'Back' link ?

Beta updated

Thanks, Vino. I've tested. Can be deployed. (1 and 2 on Test 3)


Allow for known functions to not be analyzed by unnecessary_function_arguments

(starting with parse_transform/2)
I actually created the test first, not that it matters much.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I've added actions/cache for increased lolspeed. A run that took around 3 min. now takes less than 1.


middleware/kubernetes: TLS support

Need TLS support for the K8s endpoint.

@johnbelamaric just in case, if you do not specify the endpoint and run coredns as a pod inside the cluster it will use SSL and the configured service account.

@aledbf, are you saying the client code already does that automatically or that you would like it to work that way?

the client code already does that automatically

Yes (if is running  inside the cluster)

Ok, I tried it yesterday with the pre-TLS code and got an error but maybe the way the client is being initialized is wrong or maybe something is wrong in my k8s setup. I will try again Monday.

Is still still an easy, or can it be closed?

We can close this issue, we have the TLS support now, but I still haven't had a chance to try out what @aledbf is suggesting.


[Release] Stage To Main

release:

https://github.com/adobecom/milo/pull/1802

@Blainegunn @3ch023 FYI @Dli3 is the primary contact for the bacom SOT. I've added him as a reviewer.


update mpi config

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Maybe skip: true  # [win and mpi]?

@CyrilleBonamy So now we have to specify build number while installing?

@ashwinvis I guess that there is a priority for the larger build number so users don't need to specify it.

it is explained at the bottom of this section : https://conda-forge.org/docs/maintainer/knowledge_base.html#including-a-no-mpi-build


Carousel events not working correctly under Firefox

Using Bootstrap v4.0.0 with Firefox 59 under Lubuntu 16.04 (tested under windows 7 too). Carousel events sometimes fire sometimes don't. If you set a handler for just one event ("slide" OR "slid"), it doesn't work correctly. Curiously, if you register both handlers ("slide" and "slid"), they both fire correctly (???). Might be a Firefox quantum issue.
Steps to reproduce:

Open the carousel documentation page with Firefox: https://getbootstrap.com/docs/4.0/components/carousel/
Open console and type $('#carouselExampleControls').on('slid.bs.carousel', function (ev) { console.log('slid!'); })
Try to slide the second carousel example with the controls or just wait to see if the "slid" event fires.
Add the other event listener: $('#carouselExampleControls').on('slide.bs.carousel', function (ev) { console.log('slide!'); }) , and see how both events now works.

Note: everything works under Chrome.

Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case via CodePen or JS Bin and report back with your link, Bootstrap version, and specific browser and OS details.

This is not a bug. It was the console aggregating repeated messages... must get some sleep! :-D Sorry.


refactor: replace prettytable-rs with comfy-table

Manual check-in of https://github.com/singularity-data/risingwave/pull/1726 due to https://github.com/singularity-data/risingwave/issues/1727
close https://github.com/singularity-data/risingwave/issues/1316
close https://github.com/singularity-data/risingwave/pull/1726
Thanks @PsiACE!

Oops, I think I've found some bugs (?) to help merge community PRs. We can mirror community members' PR on our local branch. The GitHub Actions status will be automatically updated for the original PR, if they are of the same commit id.


Second Try

fullname
Glenn Berry
topics
Database Administration, DMV Queries, Cloud Infrastructure, database hardware
regions
Europe
Sessionize
https://sessionize.com/glenn-berry/
language
English

no idea why yours wont run but Brents did but I have manulaly run the second part


Branch:dev_after_restored missing files.

src\common\KeyManager.cpp and src\common\KeyManager.h did not get committed, it appears.
Also: E:\gitsvnhub\Fallout4Test\fallout4_test\src\patches\CKF4\RenderWindow.cpp(51,22): warning C4018: '<': signed/unsigned mismatch

Apparently already fixed in master. Closing.


remove copyright statements from vcpkg PR

remove
# Copyright (c) Microsoft Corporation. All rights reserved.
# SPDX-License-Identifier: MIT
#

from files in vcpkg PR. Because vcpkg guys don't like it

@danieljurek We should automate removing this.

Duplicate of #1664


AzureMapHtmlMarker doesn't include styles generated by styled components

Hello guys,
I'm not able to see in browser any styles generated by MUI styled() utility when I'm passing styled component as a markerContent prop into an AzureMapHtmlMarker.
`
const StyledIcon = styled(Icon)(({ theme }) => ({
fontSize: 25,
}));
const StyledText = styled('span')({
position: 'absolute',
top: '50%',
left: '50%',
transform: 'translate(-50%,-50%)',
});
...
const markerContent = (

{text}

);
<AzureMapHtmlMarker
key={some-generated-key}
options={{
position: [longitude, latitude],
}}
markerContent={markerContent}
/>
`
Will be styled components supported in a future or is there any pretty workaround?
Thanks in advance!

hi @JLittner, there's a (not-so-pretty) workaround by rendering a hidden copy of your styled components outside of the <AzureMapsProvider> container, so that the css can be generated on the page. For example,

import * as React from "react";
import * as ReactDOM from "react-dom/client";
import { Button, styled } from "@mui/material";
import {
  AzureMap,
  AzureMapsProvider,
  AzureMapHtmlMarker
} from "react-azure-maps";
import { data } from "azure-maps-control";

const option = {
  zoom: 12,
  center: [-122.335, 47.62],
  authOptions: {
    authType: "subscriptionKey",
    subscriptionKey: "<subscriptionKey>"
  }
};

const position = new data.Position(-122.335, 47.62);

const StyledButton = styled(Button)(() => ({
  fontSize: 25
}));

function MyApp() {
  return (
    <>
      <AzureMapsProvider>

          <AzureMap options={option}>
            <AzureMapHtmlMarker
              key="1"
              markerContent={

              }
              options={{ position }}
            />
          </AzureMap>

      </AzureMapsProvider>

    </>
  );
}

ReactDOM.createRoot(document.querySelector("#app")).render(
  <React.StrictMode>
    <MyApp />
  </React.StrictMode>
);

Hi,
Thanks for fast answer.
I tried this approach but it didn't work for me.  It could be because I had the styled component separated in another component with additional logic and this I tried to render outside of '' and than in the map.
I ended up with css classes and definition of styles for them in the parent component.
'
import * as React from "react";
import * as ReactDOM from "react-dom/client";
import { Button, styled } from "@mui/material";
import {
AzureMap,
AzureMapsProvider,
AzureMapHtmlMarker
} from "react-azure-maps";
import { data } from "azure-maps-control";
const option = {
zoom: 12,
center: [-122.335, 47.62],
authOptions: {
authType: "subscriptionKey",
subscriptionKey: ""
}
};
const position = new data.Position(-122.335, 47.62);
const AzureMapContainer = styled('div')(() => ({
height: '100%',
width: '100%',
overflow: 'hidden',
// Styled button
'& .styled-button': {
    fontSize: 25
},

}));
function MyApp() {
return (

<AzureMapHtmlMarker
key="1"
markerContent={
Hello World
}
options={{ position }}
/>


added water input modal

Added water input modal in water tracker

@sauravk7077  I'm enjoying reading your code because I'm not very familiar with React.  I'm learning from how you organize code and just seeing more of it so I become more familiar.  Thankyou


Scroll to change workspace

Thanks for the great extension :)
It would be great if the feature to just scroll on the widget to move through work-spaces can be added.

Hi, @SmiteshP !
Thanks!
I've already tried to add it but I don't like the result. Check another issue here. There is a branch with scroll to change logic.
But I'd rather suggest you to try this extension in addition to my indicator. They work pretty well together.


How to integrate Kubernetes with existing AWS ALB?

I want to use existing AWS ALB for my kubernetes setup. i.e. I don't want alb-ingress-controller create or update any existing AWS resource ie. Target groups, roles etc.
How can I make ALB to communicate with Kubernetes cluster, henceforth passing the request to existing services and getting the response back to ALB to display in the front end?
I tried alb-ingress-controller but it will create new ALB for new ingress resource. I want to use the existing ALB resource for it.

This controller is designed to manage the configuration of an ALB, it's not possible to merge ingress resources into existing ALBs.
There has been discussion around creating a single ALB or re-using ALBs for multiple ingresses inside of a cluster and I expect that to happen, but not leveraging an unmanaged ALB.


Add SAIL notes

Commit a document about what we have learned from SAIL code.
reason: on boearing of new members and to help our memory

This is really good, thank you. Maybe we can use some of those later for the "Sail Cookbook"?

We will try to use this for onboarding and I will extend this document in the future. Then it will be useful


feat(lib2): insert/delete-aware difference algorithm

closes #46

I did not notice any other things (except the one thing above), so it looks good to me.


Improve Qwik output

Make it so the code is more human friendly for the Builder.io code output, Mitosis fidlde, and any other codegen use case

@samijaber I'm slightly confused about the failing lint step. it looks like it's a component not actually used (just for your conf talk?) and I can't reproduce the issue locally (lint working fine locally 🤔)

nvm I fixed it, some weird difference between local and production but running prettier manually from vscode fixed


[Concepts] Feedback on CMSIS-Zone integration

Please find some feedback regarding this proposal:
https://github.com/Open-CMSIS-Pack/devtools/blob/main/tools/projmgr/docs/Manual/Overview.md#cmsis-zone-integration

To me, the resources partitioning is a topic related to configuration.
Therefore, I'd prefer that we do not mix it with the YML csolution file that deal with composition.

I agree resource partitioning is at csolution level (what I call application project).
But, it may be interesting to deliver a project "alone" and segregate the projects (only the non-secure projects are delivered to a developer).
So, I think it is important that each cproject gets its associated resources.
This is what I call execution context and execution domain.

Phases can indeed have specific memory regions.
But, in my opinion, this applies to peripherals too: this is again what I call the execution domain (peripherals and memories).

Phases do not allow to have a concept of shared execution domain to list resources that anybody can use.
We miss this item.
Together with this item comes the concept of initializer of a resource.

Some resources might be forbidden for the csolution, we must be able to list it explicitly.

Generally speaking, I think we need to conclude on this topic:
https://github.com/Open-CMSIS-Pack/Open-CMSIS-Pack-Spec/issues/33
To define the concepts we want to enable and then how to do it.

@fred-r sorry I had not enough bandwidth to work on resource management. This is also caused by our internal processes where there was a lack of engineering bandwidth.  I hope we can ensure proper resourcing in the next weeks to address it.
All your suggestions above make sense, but as said I need more bandwidth.

Another point we need to discuss is how to use the rzone properly.
Typically, rzone can define internal and external memories.
So, I assume an rzone can be coupled with a device (internal memories only),
or with a board (external memories added too).
So, where to store it ?
Shall we have:

1 rzone in device pack
another rzone (extension) in board pack ?


Remote RRDCached support in clustered environment?

So I have a web front-end that polls, a second regular cronjob poller, and two servers that run the librenms-poller-service. The last server is a SQL server that runs memcached, rrdcached, and of course the SQL backend. The SQL server is also the NFS host of the RRD files for all 4 pollers.
When I run the map poller regularly, I get a lot of links with 0's reported for traffic in the links. When checked with rrdtool, it is in fact missing data for the 800 second time frame. When I run /opt/librenms/html/plugins/Weathermap/weathermap.php with the additional --chdir /my/rrd/path, I get a lot more values filled in, but many are missing. I tried adding the --daemon ip.of.my.server:42217 and it didnt seem to help, like it can't read anything in rrdcached.
If i change the config on rrdcached to WRITE_TIMEOUT=720 and WRITE_JITTER=360, I'm then able to get 90% of my links populated with traffic on the map. I saw that WeatherMapDataSource_rrd reads back the last 800 seconds of an rrd, so it seemed the only way to get data to come through was to neuter my rrdcached setup.
TL;DR - How do I get Weathermap to accurately read rrd values from rrdcached when Weathermap is on a different server from the rrdcached server?

I was working through a similar issue in Observium. Turns out that rrdtool and rrdcached behave differently when you use a UNIX socket vs a TCP socket. If you use a UNIX socket, then the real path to the RRD is resolved by rrdtool and then sent over the UNIX socket to rrdcached. If you use a TCP socket, then rrdtool just sends the unaltered path to rrdcached. rrdcached expects the path to be relative to the BASE_PATH that you have configured for rrdcached.
So in the weathermap, the RRD path needs to change to a path relative to your RRD directory. Previously I had lines in my weathermap config that looked like this:
TARGET ../../rrd/router.my.net/port-639.rrd:INOCTETS:OUTOCTETS
After switching to a TCP socket I had to change it to look like this:
TARGET router.my.net/port-639.rrd:INOCTETS:OUTOCTETS
This difference in the pathing between the socket types is probably causing rrdtool to fail.

For anyone who stumbles across this in the future i had the same issue.
My setup is a RRDcache + 2x pollers (one of which is the librenms web frontend too).  Both running rrdtool 1.7.1 which is important because it implies that common file store is required by the pollers to access the RRD files and that tcp sockets are the only thing used.  At some version (1.5 i think) RRDtool introduced rrd management to rrdcached and thus shared NAS storage was no longer required for direct access.
Issue 1.  Weathermap does check if the RRD file exists and the code included with the librenms plugin is no different.  The only way that weathermap will with with rrdcache is if your RRD definitions in your map config files have no path at all but that doesn't change the fact that you still need to disable the file existance check you need to change the file 'lib/datasources/WeatherMapDataSource_rrd.php'.  Delete the following lines between 588-614 as follows:
-		if(file_exists($rrdfile) or file_exists($map->chdir."/".$rrdfile))
-			{
				wm_debug ("RRD ReadData: Target DS names are ".$dsnames[IN]." and ".$dsnames[OUT]."\n");

				$values=array();

				if ((1==0) && extension_loaded('RRDTool')) // fetch the values via the RRDtool Extension
				{
					WeatherMapDataSource_rrd::wmrrd_read_from_php_rrd($rrdfile,$cfname,$start,$end, $dsnames, $data,$map, $data_time,$item);
				}
				else
				{
					if($aggregatefunction != '')
					{
						WeatherMapDataSource_rrd::wmrrd_read_from_real_rrdtool_aggregate($rrdfile,$cfname,$aggregatefunction, $start,$end, $dsnames, $data,$map, $data_time,$item);
					}
					else
					{
						// do this the tried and trusted old-fashioned way
						WeatherMapDataSource_rrd::wmrrd_read_from_real_rrdtool($rrdfile,$cfname,$start,$end, $dsnames, $data,$map, $data_time,$item);
					}
				}
-			}
-			else
-			{
-				wm_warn ("Target $rrdfile doesn't exist. Is it a file? [WMRRD06]\n");
-			}

Issue 2.  The data picker in the editor has an actual path hard coded into it in the file 'data-pick.php', you can hand edit the rrd path out every time you use the editor if you like or you can change line 197 in the file as follows:
-		var rra_path = <?php echo js_escape('./'); ?>+name+'/port-id';
+		var rra_path = name+'/port-id';

I hope this helps someone else in future.

Did anyone get this working? I still get this error no matter what.
RRD ReadData: At least one of your DS names (traffic_in and traffic_out) were not found, even though there was a valid data line. Maybe they are wrong? Valid DS names in this file are:  [WMRRD06]
WARNING: configs//campus-core.conf: ReadData: LINK node04965-728, target: orms-core/port-id2828.rrd on config line 68 of configs//campus-core.conf had no valid data, according to WeatherMapDataSource_rrd

Did anyone get this working? I still get this error no matter what. RRD ReadData: At least one of your DS names (traffic_in and traffic_out) were not found, even though there was a valid data line. Maybe they are wrong? Valid DS names in this file are: [WMRRD06] WARNING: configs//campus-core.conf: ReadData: LINK node04965-728, target: orms-core/port-id2828.rrd on config line 68 of configs//campus-core.conf had no valid data, according to WeatherMapDataSource_rrd

I have it fixed in LoveSkylark
/
LibreNMS-Weathermap

How did you fix it?
On Tue, Aug 16, 2022 at 7:11 AM Skylark @.***> wrote:

Did anyone get this working? I still get this error no matter what. RRD
ReadData: At least one of your DS names (traffic_in and traffic_out) were
not found, even though there was a valid data line. Maybe they are wrong?
Valid DS names in this file are: [WMRRD06] WARNING:
configs//campus-core.conf: ReadData: LINK node04965-728, target:
orms-core/port-id2828.rrd on config line 68 of configs//campus-core.conf
had no valid data, according to WeatherMapDataSource_rrd
I have it fixed in LoveSkylark https://github.com/LoveSkylark/
LibreNMS-Weathermap https://github.com/LoveSkylark/LibreNMS-Weathermap
—
Reply to this email directly, view it on GitHub
https://github.com/librenms-plugins/Weathermap/issues/48#issuecomment-1216551329,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGVKA64QXVUVQXOKFKZCMEDVZOAONANCNFSM4EU3S2JA
.
You are receiving this because you commented.Message ID:
@.***>

--
CONFIDENTIALITY NOTICE: This email & attached documents may
contain confidential information. All information is intended only for the
use of the named recipient. If you are not the named recipient, you are not
authorized to read, disclose, copy, distribute or take any action in
reliance on the information and any action other than immediate delivery to
the named recipient is strictly prohibited. If you have received this email
in error, do not read the information and please immediately notify sender
by telephone to arrange for a return of the original documents. If you are
the named recipient you are not authorized to reveal any of this
information to any other unauthorized person. If you did not receive all
pages listed or if pages are not legible, please immediately notify sender
by phone.

https://github.com/librenms-plugins/Weathermap/commit/2481c35972daf20402629ffb0c6cbfcc2d638a03
https://github.com/librenms-plugins/Weathermap/commit/745a0a34ec90b32faeab7834132277049fbfc2c4
https://github.com/librenms-plugins/Weathermap/commit/04fba515ba13e95c417a36fcb5e6cb912be047b2

i tried that but still throwing error


[5.1] Fix Foundation Composer test on various platforms

Little regression from #10294.
Encountered this issue because escapeshellarg() and ProcessUtils::escapeArgument() escape with double quotes on Windows, and the test fail.
Just as in Foundation\Composer::findComposer(), I'm using the Symfony components for robuster, more portable, escaping and PHP binary detection.
See at Symfony: ProcessUtils::escapeArgument() - PhpExecutableFinder::find()

:-1:

We don't want to test it works by using the implementation itself as a way to find out...

That's not testing anything.

Could you send a PR to fix the quotes on different platforms though?

At the beginning I thought as you did. But, we are not testing correctness of escaping and binary detection, it's Symfony's job. And even if we wanted to test this, we couldn't, unless by copying all the code from the Process methods. What we are testing is the building of the string passed to setCommandLine().

By the way, currently when running tests I'm encountering 3 other errors, which look quite similar. I haven't had a look at them yet.

Alternatively, a simple escapeshellarg(PHP_BINARY) would work in most cases.
Could at least this PR be reopened so we get some opinions?

While fixing the other tests, I got your point: you want to make sure the Symfony components don't do more than expected, hence the "fixed" test values, even if it implies failing tests on some (rare) environments.


scipy.optimize.leastsq: handling of inf and nan.

Example:
 import scipy.optimize as opt
 def f(x):
     return np.hstack((np.inf, x))
 opt.leastsq(f, [3, 3])

While the behavior is documented, it my be preferable to have at least an
optional check for finiteness, because depending on the used BLAS library this can even
lead to an crash of the python interpreter.

curve_fit has a check_finite kwarg since 0.15.0

I ask mostly for lmfit usage, where we call leastsq directly. So this probably means the check should be also on lm-side.

@ev-br In this example the inf is generated by the callback function, which I think is called from C code.

@argriffing ah yes, you're right.

If someone suggests the propwr way to solve this, I would be happy to try and create a PR.

A similar issue arises if the Jacobian is inf or nan. The issue is the following Fortran snippet from MINPACK:
!
!  Compute the norm of the scaled gradient.
!
     gnorm = 0.0D+00

     if ( fnorm /= 0.0D+00 ) then

       do j = 1, n
         l = ipvt(j)
         if ( wa2(l) /= 0.0D+00 ) then
           sum2 = dot_product ( qtf(1:j), fjac(1:j,j) ) / fnorm
           gnorm = max ( gnorm, abs ( sum2 / wa2(l) ) )
         end if
       end do

     end if
!
!  Test for convergence of the gradient norm.
!
     if ( gnorm <= gtol ) then
       info = 4
       go to 340
     end if

After the loop gnorm should hold the maximum cosine angle as indicated in the documentation  but if fjac is nan or inf or fnorm is inf it will be 0. Thus, the convergence test succeeds.

Changing
            gnorm = dmax1(gnorm,dabs(sum/wa2(l)))

to
            temp = dabs(sum/wa2(l))
            if (.not. (gnorm .gt. temp)) gnorm = temp

in LMDER and LMDIF makes leastsq at least use the maximum number of iterations instead of reporting success. Not the cleanest solution. The Fortran code was not written with nan or inf in mind. It would be a zero-overhead "fix", though.


code in isDevMode() block is not removed from production builds.

Which @angular/* package(s) are the source of the bug?
compiler
Is this a regression?
Yes
Description
The following code block and its assorted import statements should be elided during a production build.
import { isDevMode, Injectable } from '@angular/core';
import { DevCommandService } from '@project/dev-command';

@Injectable()
export class CoolService {

  constructor() {
    if (isDevMode()) {
      import(DevCommandService).addHelperFunctionToConsoleForDevelopersOnly('someSampleCommand', () => {
        console.log('do a backflip');
      });
    }
  }
}

I expect the output to be as follows:
import { Injectable } from '@angular/core';

@Injectable()
export class CoolService {

  constructor() {
  }
}

However, it is unchanged.
What is the correct way to ensure that during ng build --prod, import {DevCommandService} from '@project/dev-command';  and the entire block which uses it are dropped from the output?
Can we somehow replace isDevMode() with false during production builds, and have dead code elimination / tree shaking properly apply to the application?
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in (run ng version)
Angular CLI: 14.2.2
Node: 14.19.0
Package Manager: yarn <error>
OS: win32 x64

Angular: 14.2.1
... animations, cdk, common, compiler, compiler-cli, core
... elements, forms, language-service, material
... platform-browser, platform-browser-dynamic, router, upgrade

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1402.2
@angular-devkit/build-angular   14.2.2
@angular-devkit/build-webpack   0.1401.3
@angular-devkit/core            14.2.2
@angular-devkit/schematics      14.2.2
@angular/cli                    14.2.2
@angular/flex-layout            14.0.0-beta.40
@schematics/angular             14.2.2
@schematics/schematics          0.1102.12
@schematics/update              0.1102.18
ng-packagr                      14.2.2
rxjs                            7.5.6
typescript                      4.6.4

Anything else?
Maybe isDevMode() is not the correct way to handle this. How should we handle tree shakable development only code, in a project that has multiple apps and libraries?

This is expected since isDevMode is not statically analyzable. You can use environment.production in this case although it does have some caveats. See https://github.com/angular/angular-cli/issues/23738 for more information.


PP-5274: remove feature flag on sqs write

removed feature flag when writing to the queue in the CardCaptureService
test cleanup after removing config from CardCaptureService
added fields to the log when receiving message from the queue - messageId and receiptHandle

We need to wait until e2e tests have sqs container ready (so that this change doesn't break them)

Waiting on scripts::779


[refactor] Record extracted symbol information for the "Extract Repeated Expression" action

rdar://33404892

Address the comment and committed To https://github.com/apple/swift-clang
ebc7bcac62..6ba2ae5e45  upstream-with-swift -> upstream-with-swift


Update install instructions in readme.md

Just adding a bit to the installation instructions in readme.md. I figure this information may be common knowledge to more practiced zig developers but it took me a while to find out how to both fetch git dependencies and update the build file accordingly. Hopefully this helps anyone else in a similar position.

thanks :)


Resolve Lightning App CI

What does this PR do?

We decided to not test logs anymore to avoid reaching rate limiting errors.
Fixes #<issue_number>

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

@tchaton how is it going here?


Webhook service upgrade selector should match any labels that have that same key

Rancher versions: version 1.6.11-rc7
Steps:

Create 2 services with the labels:
Service1  foo=bar
Service2  foo=bar2

Create a service upgrade webhook that only has foo

Upgrade the service

Results:
It will not upgrade Service1 or Service2.
Expected:
It should upgrade Service1 and Service2

Version - v1.6.11-rc8
Verified fixed