[BUG]  Building of a docker image fails

Description
Building of a docker image fails
In which platform does it happen?
Macbook pro 16'' with M1 max processor
How do we replicate the issue?
Run the following command (with  Docker 4.9.1 (81317))
DOCKER_BUILDKIT=1 docker build -t recommenders:cpu --build-arg ENV="cpu" --build-arg VIRTUAL_ENV="conda" https://raw.githubusercontent.com/microsoft/recommenders/aeb6b0b12e177b3eaf55bb7ab2b747549a541394/tools/docker/Dockerfile

Expected behavior (i.e. solution)
Image is builded
Other Comments
Logs:
DOCKER_BUILDKIT=1 docker build -t recommenders:cpu --build-arg ENV="cpu" --build-arg VIRTUAL_ENV="conda" https://raw.githubusercontent.com/microsoft/recommenders/aeb6b0b12e177b3eaf55bb7ab2b747549a541394/tools/docker/Dockerfile

[+] Building 101.9s (9/20)
 => [internal] load remote build context                                                                                0.0s
 => [internal] load metadata for mcr.microsoft.com/mirror/docker/library/ubuntu:18.04                                                                                2.9s
 => [base  1/12] FROM mcr.microsoft.com/mirror/docker/library/ubuntu:18.04@sha256:478caf1bec1afd54a58435ec681c8755883b7eb843a8630091890130b15a79af                                                       7.8s
 => => resolve mcr.microsoft.com/mirror/docker/library/ubuntu:18.04@sha256:478caf1bec1afd54a58435ec681c8755883b7eb843a8630091890130b15a79af                                                              0.0s
 => => sha256:478caf1bec1afd54a58435ec681c8755883b7eb843a8630091890130b15a79af 1.41kB / 1.41kB                                                                                0.0s
 => => sha256:6a4619c02fbaf80504f316f42bd4b732831d9590e9c1c0df2b6f294ffbee86c9 529B / 529B                                                                                0.0s
 => => sha256:f9ea66feed08210b42684caa0bb96b9804bdc0f1d22aaaa242c7897edf237f7d 1.48kB / 1.48kB                                                                                0.0s
 => => sha256:8376114ff9b387126c379fb7f6f90b3752e3082ce48b0c727c0e1b683e1244da 23.73MB / 23.73MB                                                                                7.1s
 => => extracting sha256:8376114ff9b387126c379fb7f6f90b3752e3082ce48b0c727c0e1b683e1244da                                                                                0.6s
 => [base  2/12] WORKDIR /root                                                                                0.1s
 => [base  3/12] RUN if [ "conda" != "conda" ] && [ "conda" != "venv" ] && [ "conda" != "virtualenv" ]; then     echo 'VIRTUAL_ENV argument should be either "conda", "venv" or "virtualenv"'; exit 1;   0.2s
 => [base  4/12] RUN apt-get update &&     apt-get install -y curl build-essential                                                                                30.5s
 => [base  5/12] RUN apt-get install -y libpython3.7-dev                                                                                18.7s
 => [base  6/12] RUN apt-get install -y python3-dev                                                                                20.9s
 => ERROR [base  7/12] RUN if [ "conda" = "conda" ] ; then curl https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh -o anaconda.sh &&     /bin/bash anaconda.sh -b -p conda &&     r  20.7s
------
 > [base  7/12] RUN if [ "conda" = "conda" ] ; then curl https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh -o anaconda.sh &&     /bin/bash anaconda.sh -b -p conda &&     rm anaconda.sh &&     echo ". /root/conda/etc/profile.d/conda.sh" >> ~/.bashrc &&     echo "conda activate base" >> ~/.bashrc ; fi:
#9 0.164   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
#9 0.164                                  Dload  Upload   Total   Spent    Left  Speed
100 73.0M  100 73.0M    0     0  3694k      0  0:00:20  0:00:20 --:--:-- 3845k
#9 20.44 PREFIX=/root/conda
#9 20.67 Unpacking payload ...
#9 20.67 qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory
#9 20.68 qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory
------
executor failed running [/bin/sh -c if [ "${VIRTUAL_ENV}" = "conda" ] ; then curl ${ANACONDA} -o anaconda.sh &&     /bin/bash anaconda.sh -b -p conda &&     rm anaconda.sh &&     echo ". ${HOME}/conda/etc/profile.d/conda.sh" >> ~/.bashrc &&     echo "conda activate base" >> ~/.bashrc ; fi]: exit code: 1

FYI @anargyri

The docker file is specific to linux. For MacOS you need to specify the appropriate miniconda download URL.

yeah, i think the problem is with the new arm based m1 processor the container won't be able to use this miniconda version based on x86 arch.

Closing this since Mac is not supported at the moment


Can't set writeMode of FileRotationLogger

FileRotationLogger's log method calls append with the default writeMode of force.
Seeing some crashes at that point and don't see a way to adjust the writeMode.

I just added these options in my PR, but I wonder why the file handle isn't writeable for you... 😵💫


Question

I have got a string from blood pressure characteristics notify message as below:
HpwA/wf/B+MHCAkNGDX/BwAQAA==
what exactly is it?
Thanks
Frank

FAQ


Generated infrastructure model

DESCRIPTION
This pull request was automatically generated and adds a UML-deployment diagram to your
documentation. Let me know what you think in the comments.
The diagram can be easily edited, extended or updated using text and code, here
Feedback
Infragenie (www.infragenie.eu) is a free-to-use application, currently in early-preview.
Whether you decide on accepting or rejecting this pull request, we would like to invite you to answer a 5min improvement
survey. This will help us to plan future features and improve the application.
Please answer our survey, here.
Thank you.

Hi, seeing that you have closed the PR. Can you please let me know what dp you think of the tool? If you could answer the survey, it would be wonderful. Thank you for your time.


Stuck at verifying bitcoind operation due to permission problem

Describe the issue
I started with a clean install, and followed all steps in the Guide. When executing:

$ ls -la /home/bitcoin/.bitcoin/.cookie

I get the response:

ls: cannot access '/home/bitcoin/.bitcoin/.cookie': Permission denied

Location in guide
Bitcoin > Verification of bitcoind operations
Environment

Hardware platform: Raspberry Pi 4
Operating system: Debian GNU/Linux 12 (bookworm)

Additional context
Also, the subsequent steps in the guide lead errors:

tail -f /home/bitcoin/.bitcoin/debug.log

Returns:

tail: cannot open '/home/bitcoin/.bitcoin/debug.log' for reading: Permission denied

And,

bitcoin-cli getblockchaininfo

Returns:

error: Could not locate RPC credentials. No authentication cookie could be found, and RPC password is not set.  See -rpcpassword and -stdinrpcpass.  Configuration file: (/home/admin/.bitcoin/bitcoin.conf)

Probably all related. I triple-checked whether I executed all previous steps in the guide and that seems to be the case... What to do?

User from which you are running these commands must belong to the bitcoin group.

Thanks, I am running this from the "admin" user, as per the guide, and I added "admin" to the bitcoin group via:

sudo adduser admin bitcoin

(If I re-run the above command it says: "adduser: The user admin' is already a member of bitcoin'.")

I found a solution, I had to give read+execute rights to members of the bitcoin group on the folder /home/bitcoin/

sudo chmod g+rx /home/bitcoin/

After that, the command ran as expected from the user admin:

admin@raspibolt:~ $ ls -la /home/bitcoin/.bitcoin/.cookie
-rw-r----- 1 bitcoin bitcoin 75 Mar 17 20:36 /home/bitcoin/.bitcoin/.cookie

I do think this chmod command is not part of the guide/walkthrough, should it be added?


Refactor task definitions

Pulling xldeployServer, username and password into a base virtual task.
Note: Should not be merged before #4, as this duplicates the changes in https://github.com/demobox/xlr-xldeploy-plugin/commit/4c5fbb08ab88865beacf6d8bad4007c4d6e77c1c.

@bmoussaud @jdewinne Ping ;-)

@bmoussaud @jdewinne @mpvvliet Quick ping?

@jdewinne: Thanks! Now #4 is broken, though :-(

Oh, damn, now I see you asked for this, to merge #4 first :-(
Suggestions on how to fix?


feat: add amino signing support to tokenfactory messages

What is the purpose of the change
This PR changes the codec being used for getting sign bytes of tokenfactory module messages, in order to allow amino signing.
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note

[x] Does this pull request introduce a new feature or user-facing behavior changes?
[x] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Osmosis documentation site
[ ] Code comments?
[x] N/A

Considering you tagged the PR as state breaking, should I move the changelog entry to another section?

Should be fine :) thanks!


Support composite settings file like kustomization.yaml or include just other yaml

Describe the problem/challenge you have
[A description of the current challenge that you are experiencing.]
Now, we have the following structure.
├── base
│   └── api.yaml
└── envs
    └── dev
        ├── api.yaml
        └── values.yaml

Then, we need to execute the following command to generate yaml.
ytt -f base/api.yaml -f envs/dev/api.yaml -f envs/dev/values.yaml

We have to add wrapper script with ytt because of this.
Describe the solution you'd like
[A clear and concise description of what you want to happen. If applicable a visual representation of the UX (ex: new CLI argument name, or resulting yaml).]
I would like to generate yaml by the following command.
ytt -f envs/dev/api.yaml
# or like kustomize
ytt -f envs/dev/

To achieve this, we need to composition settings file like kustomization.yaml or include just other yaml
approach 1. composition settings file
This approach is similar to kustomization.yaml
#! envs/dev/api.yaml
resources:
- ../../base/
- api.yaml
- values.yaml

approach 2. include just other yaml
#! envs/dev/api.yaml
#@ include("../../base/api.yaml")

---
#@ load("@ytt:overlay", "overlay")

#@overlay/match by=overlay.all
---
spec:
  template:
    spec:
      containers:
      #@overlay/match by=overlay.index(0)
      - env:
        - name: SOME_ENV
          value: overlay

Anything else you would like to add:
[Additional information that will assist in solving the issue.]

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

I think it's useful, do not stale.


 element height differs from other form inputs when using custom line height

When compiling Bootstrap with line-height other than the default value, the select element's height slightly differs from other elements and buttons.
select element with default line height:

select element with 1.75 line height:

Thanks!

When compiling Bootstrap with line-height other than the default value, the  element's height slightly differs from other elements and buttons (see screenshot).
1.5 line height (Bootstrap's default):

1.75 line height:

Can't insert an image with markdown:
Button with default line height:
https://cloud.githubusercontent.com/assets/2133064/19626131/5b25d3a8-9954-11e6-9b80-7a33e1fb5337.png
Button with 1.75 line height:
https://cloud.githubusercontent.com/assets/2133064/19626130/5b23cab8-9954-11e6-893d-3706f405f6a6.png

Can't insert an image with markdown:
 with default line height:
https://cloud.githubusercontent.com/assets/2133064/19626131/5b25d3a8-9954-11e6-9b80-7a33e1fb5337.png
 with 1.75 line height:
https://cloud.githubusercontent.com/assets/2133064/19626130/5b23cab8-9954-11e6-893d-3706f405f6a6.png

Just to confirm that I understand it , So the select element's height is the only element that change when you change the default value of line -height on you CSS Document???

@jesusmtzarvizu Yes, the select element height's differs, because it is hardcoded in Bootstrap.
``
select.form-control:not([size]):not([multiple]) {
height: calc(2.75rem - 2px);
}


Client side error - reactInternalInstance

ANET 2.0.13 gets Unable to get property '__reactInternalInstance$8wgv8puabvai' of undefined or null reference error in main.1f692e8d.js 17:30920

I'm pretty sure I copied the line wrongly

Does this still happen since 2.0.18(.1) i.e. with the React 16 upgrade merged?


Make test for Mediaflux version less strict

ref #1089

coverage: 84.165%. remained the same
when pulling 90a2f7fadf29542c972e53a1d011eb84f3dea5f2 on 1089_mflux_version
into 20bc097fe852497bd846a4c797f37343a4a7b0d1 on main.


Vihta integration

Vihta resource management service represent DigiExpress a important 3rd party service that we should have out of box integration. Vihta is widely used in FI public sector especially with organisations where human resource availability management is business critical need like appointment booking of healthcare or social services.
Vihta as published their alpha version of new API v2 that is located here
https://vihta-admin-api-vihta-5.apps.netorek.cloud/admin-api/v2/api-docs/swagger-ui/index.html
The most important API for creating calendar reservation client can be found under these topics
Slot API
Reservation/Appointment API
Customer API

@patope Vihta requires an IP address from which we come in. This should be that is dedicated to our DigiExpress dev environment in Hetzner


adding cobertura to travis

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9c28fc7). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             master   #12   +/-   ##
======================================
  Coverage          ?    0%
======================================
  Files             ?    13
  Lines             ?   156
  Branches          ?     9
======================================
  Hits              ?     0
  Misses            ?   156
  Partials          ?     0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c28fc7...98add3c. Read the comment docs.


When I use FilePond five times on the page, Laravel Livewire with FilamentPHP slows down when navigating to the Edit page

Is there an existing issue for this?

[X] I have searched the existing issues

Have you updated FilePond and its plugins?

[X] I have updated FilePond and its plugins

Describe the bug
I clicked on Edit, and the Edit page takes 1.5 minutes to load completely. I debugged our code and found that the issue is with FilePond not uploading properly on the page. do you have any how i can fixed it.

I have use two table samll size images.
also test on different browser

Reproduction
Same above
Environment
- Device:
- OS:
- Browser:

I've created an example page with 10 FilePond instances, and as far as I can tell there is zero slowdown.
https://stackblitz.com/edit/github-rqasn6?file=index.html
This is most likely related to Laravel Livewire or FilamentPHP, I'm not sure if one of these offers a FilePond component or if you're implementing it manually.


Cannot define correct root for output log file

Hi Everyone, I run cypress tests in the container cypress/included:4.12.1 and I use cypress-terminal-report plugin to output test logs to a file that with path:
module.exports = (on, config) => {
// ...
const options = {
outputRoot: config.projectRoot + '/logs/',
outputTarget: {
'out.txt': 'txt'
}
};
I expect to have the file "out.txt" in the /e2e/logs directory, but nothing created there. I also tried to specify outputRoot: './logs/'  but it does not create the file in the logs directory. I have tried the same on my Windows working laptop and the file is created in the project root in both cases.
How can I specify the output file path to have the log file created in the /e2e/logs directory?
Container config:
AttachStderr true
AttachStdin false
AttachStdout true
Cmd [ cypress, run, --browser, chrome, --headless, --spec, /integration/wugappstate//*.js, --config, baseUrl=http://<IP_ADDRESS>/nmconsole,screenshotsFolder=./screenshots,video=true, --env, testEnv=300_cypress_pre,allure=false,ajaxRoot=http://<IP_ADDRESS>/nmconsole/,baseApiUrl=http://<IP_ADDRESS>:9644/api/ ]
Domainname
Entrypoint [ cypress, run ]
Env [ PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin, NODE_VERSION=12.18.0, YARN_VERSION=1.22.4, TERM=xterm, npm_config_loglevel=warn, npm_config_unsafe_perm=true, CHROME_VERSION=83.0.4103.61, DBUS_SESSION_BUS_ADDRESS=/dev/null, CI=1, QT_X11_NO_MITSHM=1, _X11_NO_MITSHM=1, _MITSHM=0, CYPRESS_CACHE_FOLDER=/root/.cache/Cypress ]
Hostname 846826ff740e
Image cypress/included:4.12.1
Labels { }
OnBuild
OpenStdin false
StdinOnce false
Tty false
User root
Volumes { /e2e: [object Object] }
WorkingDir /e2e

Closing, as this is an old request for help.
You can get support from the Cypress technical community on Discord for questions about how to best configure Cypress
 (click on button)


Assembly.GetEntryAssembly is null

Steps to Reproduce
Write a test that depends on Assembly.GetEntryAssembly having a meaningful value. For example all the ASP.NET Core stuff that uses DependencyContext.Default goes off of Assembly.GetEntryAssembly
Expected Behavior
It should have a value of the unit tested assembly
Actual Behavior
It is null

Before .NET Core, I think that would have been too much of a violation of what GetEntryAssembly means. See Jon Skeet's response when similar was asked for NUnit: http://stackoverflow.com/a/26254779
For an ASP.NET Core application, though, I'll need to know more.  When the application is really running, what does that method return for you? Is it the assembly that includes the Main method that in turn kicks off Kestrel? I think returning "the unit tested assembly" is potentially ambiguous, though.

Since ASP.NET Core is just a console app, it returns the expected ASP.NET Core project assembly.
The other alternative is for me to set the entry assembly from my unit test project. See: https://github.com/jbogard/ContosoUniversityCore/blob/master/test/ContosoUniversityCore.IntegrationTests/SliceFixture.cs#L40
File this under "things that used to work with AppDomains" because DependencyContext.Default uses GetEntryAssembly instead of AppDomain.CurrentDomain

FYI I opened an issue with .NET Core on this: https://github.com/dotnet/core-setup/issues/1017

Although it might not matter any more in light of the dotnet issue you mention above, this is fixed by #170 and will be available in the next prerelease. The test assembly will truly be the entry assembly.


Stylus support?

Hi, In our team we are considering preact for a new application.
However we use stylus for css preprocessor.
Do you have any plans about including stylus in default options?
If so, we would be happy to try to submit a pull request, if some general guidance is available.
Thanks in advance.

@yavorski<EMAIL_ADDRESS>comes with a preact.config.js so you can alter your webpack config there. No need to wait for us

@thangngoc89 thank you for fast answer!
We are definitely going to try this in our starter app.
We still think that it would be nice for some users to have the option build in?

s

IMHO, it would be better for us to leave this in user land.
cc @developit @lukeed for more opinion on this one

Fair Enough!
Just wanted to make sure what do you think!

@thangngoc89 I tend to agree; however, the counterargument is that we already offer SASS & LESS. Maybe we should just so that we cover all the bases?

Hi,
After a little exploration of the code base, I think that this is fairly easy to implement.
Of course I could be wrong (I see it for the first time), but I managed to prepare a pull request.
I tested all localy and it works fine for me and our team.
I hope this would be useful to other teams too, and in general we think that this should be a good option for people using stylus out there.
Looking forward for comments and thank you for your great work so far!

Closed via #194 🎉

That's Awesome, Thank you!
When we should expect new version, so we could install :)

Looks like there's a few changes coming for 1.4, including this. I'd wager end of the week at the latest 👍

Great, thanks! ❤


[stable/gitlab-ee] GitLab: mark very old stable/gitlab-* deprecated

GitLab: mark very old stable/gitlab-* deprecated
Is this a new chart
No.
What this PR does / why we need it:
Very old, long deprecated Omnibus GitLab charts are deprecated.
Mark as so with deprecated: true. READMEs were updated long ago.

stable/gitlab-ee
stable/gitlab-ce

Replaced with charts.gitlab.io, gitlab/gitlab
Which issue this PR fixes
N/A
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [stable/mychartname])

Do I need to add a version bump to add the deprecated flag?

I believe we need to bump the version, lets see what CI has to say.
/ok-to-test

I've pushed and updated commit including the version patch level bump.

I've pushed and updated commit including the version patch level bump.


When importing a Postgres DB dump/backup, no database is created and no error is raised

Commands I am running:
➜  craft-commerce3.test git:(master) ✗ nitro db import qline.zip
  1 - mysql_5.7_3306
  2 - postgres_12.2_5432
Select database engine: [1] 2
Enter the database name to create for the import: qline
Will create the database qline
Uploading "qline.zip" into "nitro-dev" (large files may take a while)...

➜  craft-commerce3.test git:(master) ✗ nitro db import qline.sql
Detected a "postgres" backup file...
Enter the database name to create for the import: qline
Will create the database qline
Uploading "qline.sql" into "nitro-dev" (large files may take a while)...

As you can see above, no error message is output but it did not work with either a zip or sql. After running each command the DBs list remain the same:

Will DM you the files I tried to import.

@lukeholder can you run the following in one terminal?

nitro ssh
sudo journalctl -u nitrod.service -f

In another terminal run the nitro db import and paste the output in the ticket?

output of step 2 was:
ubuntu@nitro-dev:~$ sudo journalctl -u nitrod.service -f
-- Logs begin at Thu 2020-08-27 17:17:36 AWST. --
Nov 13 22:04:07 nitro-dev systemd[1]: Stopped nitrod-api.
-- Reboot --
Nov 13 22:04:55 nitro-dev systemd[1]: Started nitrod-api.
Nov 13 22:04:57 nitro-dev nitrod[715]: running nitrod on port 50051
Nov 13 23:35:04 nitro-dev systemd[1]: Stopping nitrod-api...
Nov 13 23:35:04 nitro-dev systemd[1]: nitrod.service: Succeeded.
Nov 13 23:35:04 nitro-dev systemd[1]: Stopped nitrod-api.
-- Reboot --
Nov 14 00:00:51 nitro-dev systemd[1]: Started nitrod-api.
-- Reboot --
Nov 24 21:24:38 nitro-dev systemd[1]: Started nitrod-api.
Nov 24 21:24:39 nitro-dev nitrod[716]: running nitrod on port 50051

even after running the import command in a separate terminal.

The nitrod api was out of sync, running nitro refresh and nitro restart resolved the issue.

Closing this out


chore: add cargo audit configuration

By adding a cargo audit configuration we are able to ignore security
advisories that don't apply.
Related: https://github.com/kubewarden/policy-server/issues/110

In this instance I'll hold the merge until more approvals are granted, given I want to ensure we are on the same page regarding something as potentially sensitive as this.


SLAL billy

What happened?
i down loader SLAL billy manually and still is not recognized by the mod list .
i cheeked the manifest to make sure the file names match and still .
Modlist version
Tsukiro - Boobies Bounce Thrice beta 1.1.7

4

there is a temporary download link on the tsukiro discord: https://discord.gg/jolly-coop

i opend discord as i looked for an answer but cant locate the file .
can please help .
( new user of discord )


Error while trying installing lsp via doom refresh

I was trying to enable the "Tool" LSP but when I ran doom refresh this was the error:
`Looking for orphaned packages...
No unused packages to remove
Looking for packages to install...
3 packages will be installed:

company-lsp (elpa)
lsp-mode (elpa)
lsp-ui (elpa)

Proceed? (y or n) y
Refreshing package archives
Contacting host: elpa.gnu.org:443
Failed to download ‘gnu’ archive.
Contacting host: melpa.org:443
Contacting host: orgmode.org:443
Package refresh done
Installing lsp-mode
FILE ERROR: https://elpa.gnu.org/packages/spinner-1.7.3.el: Bad Request
Trying again...
Deleted old autoloads.pkg.el
✓ Cached package state
✓ Package autoloads included
✓ Removed load-path/auto-mode-alist entries
Recompiled 0/0 file(s) (170 ignored)
Finished!`
I am still new to emacs so I don't know if it is a doom or a package issue.
I've already tried updating doom but that doesn't fix anything.

Fixed in straight branch


Issue 197704 smokeping forbidden landing page

Description of changes
Fixes #197704.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

[x] NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I do not know if homeMode = "755"; also applies for already-existing home directories.
If not, users may have to manually run:
chmod 755 /var/lib/smokeping

for existing servers.

Wow, that was quick. Thanks a lot!


removing the client_secret for dataflow

it's not being used for anything at the moment and it's causing problems for external pull requests

Coverage remained the same at 71.58% when pulling 3716712ba002d7f7abc64b6033832993c7718502 on lb_remove_encrypted_key_for_now into eb7dd0e85baf3fd3d759d69f5e0cb55108850fa2 on master.

#259 is blocked by this

:+1: please merge


max cropBox width and height

How come there is no maxCropBoxWidth or maxCropBoxHeight?
As a user I would like to set the max width and height of the image to be cropped. For example the image cropped should be max 200px wide.

@philmetzger It is not there since cropperjs doesn't provide it. Here is the reason and a solution https://github.com/fengyuanchen/cropperjs/issues/831


rF2: release game resources on game process exit and on Stop button click

Tested to make sure R3E still works.

i think there might be a previous regression in the PCars Network Data reading process - see line 430 of CrewChief.cs. I need to run it up in a debugger but I think the logic here might prevent pcars network data from working. Or maybe not. Either way I need to understand this better - calling .Disconnect on the gameDataReader is potentially a breaking change for PCars network data because it closes the UDP socket

Jim, Disconnect is a noop on all games but rF2.  The only change that affects other game connections is setting mapped to false.
In case of all games, but rF2, calling intitialise twice is a no op (cached intitialised field is checked).  Hence, I thing changing mapped to false is safe, because it will simply require us to call initialise() again, which simply return.
I know that pCars UDP stuff uses 'stop' and I don't think I changed that, but I'll check again.  I am also planning to debug app shutdown today.  I do not think Initialise() and Disconnect() need synchronization, because they are only called from same main loop method.

Jim, this is much better, but I would still appreciate if you could do a quick test of UDP pcars.  Just try start CC/Stop CC and Start again, see if nothing blows up.  Other than that, the race you mentioned on Discord is fixed. Thanks


adding stuff

About the PR

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

add: Added fun!
remove: Removed fun!
tweak: Changed fun!
fix: Fixed fun!

Please properly name and describe your PR

sorry i didnt mean to send it here


Can we fix images for darkmode?

The tutorial looks pretty bad in dark mode as the images have white backgrounds.

Just adding an alpha channel isn't going to work as the images have black in them, which will become invisible.
I don't know if this easily fixable though as the Jupyterbook website has the same issues. There doesn't seem to be an easy option to force light mode.

idk if JupyterBook has equivalent of : https://github.blog/changelog/2021-11-24-specify-theme-context-for-images-in-markdown/

it must support theming by inspection, since looking at the actual HTML source reveals lines like:
<img src="_static/juliaheplogo.png" class="logo__image only-light" alt="Logo image"/>
<script>document.write(`<img src="_static/juliaheplogo.png" class="logo__image only-dark" alt="Logo image"/>`);</script>

so clearly some part of the Sphynx engine behind the scenes knows about the only-light and only-dark css classes...

https://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/branding.html is the Sphinx level documentation on this: I'll read it properly in the morning

For the Documenter sidebar:
There are two main ways you can do this.
One is to make two versions of the logo, one for dark mode (logo_dark.svg|png), one for light mode ('logo.svg|png`). Documenter will switch between them:

The other way, if you "own" the logo, is to "own" the background as well, ie don't use transparent areas, bring your own background:

This makes life a bit simpler.
In the Documenter content area
Perhaps you don't own the logos, and can't add backgrounds  -- you might have to switch between two versions of a logo.
But Documenter doesn't have built-in syntax for the content area, so you'll have to use CSS. Add a file eg extras.css to docs/src/assets/:
.display-light-only {
    display: block;
}

.display-dark-only {
    display: none;
}

.theme--documenter-dark .display-light-only {
    display: none;
}

.theme--documenter-dark .display-dark-only {
    display: block;
}

and include this CSS file into your make.jl file:
format   = Documenter.HTML(
      ...
        assets=["assets/extra.css"],
      ...
        ),

Then you can refer to different images for light and dark modes using the @raw form in your Markdown:
     ```@raw html
          <img class="display-light-only" src="assets/hsf_logo_blue.png" alt="hsf logo"/>
          <img class="display-dark-only" src="assets/hsf_logo_blue_darkbg.png" alt="hsf logo dark mode"/>
     ```


Initial Cleanup in docs

fixed tensorport.md, and got rid of some stale and redundant files

Codecov Report

Merging #303 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   16.79%   16.79%
=======================================
  Files          72       72
  Lines        4210     4210
=======================================
  Hits          707      707
  Misses       3503     3503

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a142f...6e3d3c0. Read the comment docs.


Support styled(Button) and styled(ListItem)

Right now you can't do:
const StyledButton = styled(Button)

This is because Button isn't a styled() component or core tamagui component, it's a HOC. We have a pattern called extractable that does make it extract using the compiler, but doesn't support wrapping in styled().
This is definitely doable, but requires a few steps to get there - I started work on it, but supporting variants requires a bit more work than anticipated so logging here for future work.

Fixed in https://github.com/tamagui/tamagui/pull/118/commits/a45d501da5e475906e3c1dbff84d9ea94e16d1ae


Bullet points starting with maths are not properly converted

This kind of markdown:
* $f$ is a function that...
* one can compute ...

leads to this kind of html

\(f\) is in the set \(\Gamma_0(X)\) of convex functions on \(X\) that are proper and lower semi-continuous,

one can compute a gradient or subgradient of

The second one is fine but the first one is not. This may have to do with the order in which things are done and eventually md2html is called.
What it does:

only parses a * then closes it as a standalone

 with a single, empty,

then plug in the maths thing

so this is part of a larger issue about context
what was happening:
* text
* (maths)

would be processed as
* text
*

then
(maths)

(an XBLOCK).
Now working on this in branch context to try to make sure things are properly plugged in their context.

this is fixed with the context add in cc6ae92424972fad3392b06247c19fc1c9511c1a


Fix odh release

Description

Fixes #1123
How Has This Been Tested?

Create a new build
Deploy it and check there is no error

Test Impact

Request review criteria:

[ ] The commits have meaningful messages (squashes happen on merge by the bot).
[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work
[ ] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

@lucferbux this is mergable, no? We can't really test this change until it gets to RHODS and part of that build process?

Yes, that's right, this can be merge, and @DaoDaoNoCode can use this for his development.

@lucferbux this is mergable, no? We can't really test this change until it gets to RHODS and part of that build process?

Yes, that's right, but this won't affect RHODS in any means, we use a different Dockerfile downstream so this is targeted only for Upstream release.

@lucferbux this is mergable, no? We can't really test this change until it gets to RHODS and part of that build process?

Yes, that's right, but this won't affect RHODS in any means, we use a different Dockerfile downstream so this is targeted only for Upstream release.

Thanks for the clarification. Is there anyway for us to test this upstream? How do we know this is the desired change? Was the same change done downstream and it worked?

@lucferbux this is mergable, no? We can't really test this change until it gets to RHODS and part of that build process?

Yes, that's right, but this won't affect RHODS in any means, we use a different Dockerfile downstream so this is targeted only for Upstream release.

Thanks for the clarification. Is there anyway for us to test this upstream? How do we know this is the desired change? Was the same change done downstream and it worked?

This same change was done downstream, we are currently shipping with this image, I've tested a local image with this changes and it seems to be working in my dev environment and as per @LaVLaS commented in a private channel, testing http://quay.io/opendatahub/odh-dashboard:main-a317f55 with the release PR seems to work.


DCOS-12431: Apply flex class to AccessDeniedPage

This fixes a bug in Safari where the absence of flex-grow: 1 prevented the content from being visible, so it was just a blank white page.
After:

Looks good! :shipit:


Add my first file

I have created a new branch, created a file, and made a commit!

Here's a recap of your accomplishments:
You learned about GitHub, repositories, branches, commits, and pull requests.
You created a branch, a commit, and a pull request.
You merged a pull request.
You made your first contribution! 🎉

What's next?
If you'd like to make a profile README, use the quickstart instructions below or follow the instructions in the Managing your profile README article.
Make a new public repository with a name that matches your GitHub username.
Create a file named README.md in its root. The "root" means not inside any folder in your repository.
Edit the contents of the README.md file.
If you created a new branch for your file, open and merge a pull request on your branch.
Lastly, we'd love to hear what you thought of this course in our discussion board.
Check out these resources to learn more or get involved:
Are you a student? Check out the Student Developer Pack.
Take another GitHub Skills course.
Read the GitHub Getting Started docs.
To find projects to contribute to, check out GitHub Explore.

Über den offiziellen Kurs:
Summary
Completed
100 XP
1 minute
In this module, you learned about the key features of GitHub, including issues, commits, and pull requests. You also used GitHub Pages to publish a public site based on the contents of your project.
You learned about:
Communicating with the project community in issues
Managing notifications for project events
Creating branches to manage work in parallel
Making commits to update project source
Introducing changes with pull requests
Deploying a web page to GitHub Pages
Differences between Git and GitHub and the roles they play in the software development lifecycle
How a repository fork differs from a clone
Repository labels and where to apply them in issues and pull requests
Now that you're familiar with the basics of GitHub, learn to Upload your project by using GitHub best practices.
Learn more
Here are some links to more information on the topics we discussed in this module.
Setting up and managing organizations and teams
Committing changes to your project
Collaborating with issues and pull requests
About the role of labels
GitHub Actions
Fork a repo
Working with GitHub Pages


gradle for java: cant locate activity view icon after accidentally deleting it

i Accidentally deleted the icon on the activity view for gradle for java and now i cant locate it
POC

you can right click in the side bar (exactly your screenshot), find the Gradle container and enable it.

you can right click in the side bar (exactly your screenshot), find the Gradle container and enable it.
when i right click it doesnt show anything relating to gradle but vscode says i have it installed

you can right click in the side bar (exactly your screenshot), find the Gradle container and enable it.

it doesnt show the gradle container its like it doesnt exist

you can check the activate events here: https://github.com/microsoft/vscode-gradle/blob/859d5124a6bac57140d5ed06be4478605058a75a/extension/package.json#L36-L43 to see if your project meets the requirement.
Besides, you can go to Gradle for Java extension page to check if it's activated.


Fixed an issue with settings call

Tiny adjustment. I was running into issues with running settings from the CLI and narrowed it down to this line.

Request options must be an array or instance of RequestOptions to avoid a validation error.
[ERROR] RequestOptions can only be created from array or from RequestOptions object

         InvalidArgumentException

         in /project/vendor/algolia/algoliasearch-client-php/src/RequestOptions/RequestOptionsFactory.php: 50

Thanks!


Facilitate the link with public databases

Main purpose:
In this project, public databases are used to store the original data. Two types of data have to be downloaded:

Raw data from OpenNeuro (https://openneuro.org/datasets/ds001734/versions/1.0.4)
Original results from NeuroVault (https://neurovault.org)
The aim of this issue is to find a way to automatically download original results and to facilitate the access to raw data (faster and automatic downloading)

Steps:

[ ] Write a script to automatically download raw data from OpenNeuro
[ ] Write a script to download original results (this can be done using pyneurovault or with custom functions, see here)

Will try to adapt this to get the neurovault data:
https://github.com/poldrack/narps/blob/1.0.1/ImageAnalyses/PrepareData.py


enhanced bug fix for issure #144

Coverage remained the same at 100.0% when pulling 4beeb841f6ae1987c01d15db8ca0940c7de5bb59 on jangsutsr:master into 04a6443a8981728958b1ac8d0b741f8999ac5ebd on ansible:master.

Coverage decreased (-0.1%) to 99.859% when pulling 662cf544722877e08c6fd5a94f062664f96b1b9a on jangsutsr:master into 04a6443a8981728958b1ac8d0b741f8999ac5ebd on ansible:master.

👍

Coverage remained the same at 100.0% when pulling 7814a0d32c1650c7e39af741572d7f4bc60e48cd on jangsutsr:master into 04a6443a8981728958b1ac8d0b741f8999ac5ebd on ansible:master.


Unable to pass a JsonNode to stream-processor in args position

In trying to implement a service with clj-nix that receives requests in JSON form and sends responses in JSON form, it makes sense to deserialize as little as possible.
However, trying to pass a JsonNode (corresponding with {"n": 100} to an expression that uses a variable $n) for vars presently results in the following:
java.lang.UnsupportedOperationException: nth not supported on this type: IntNode
 at clojure.lang.RT.nthFrom (RT.java:992)
    clojure.lang.RT.nth (RT.java:940)
    jq.api.api_impl$new_scope.invokeStatic (api_impl.clj:154)
    jq.api.api_impl$new_scope.invoke (api_impl.clj:144)
    jq.api$stream_processor.invokeStatic (api.clj:83)
    jq.api$stream_processor.invoke (api.clj:75)

Can you help me to reproduce the problem?
Here is what i have right now:
((jq.api/stream-processor ".n = $n" {:vars {:n 3}}) (impl/->JsonNode {"n" 100}))

What I attempted with the above results is roughly...
((jq.api/stream-processor ".n = $n" {:vars (impl/->JsonNode {"n" 3})}) (impl/->JsonNode {"n" 100}))

...so a more proper reproducer would be:
((jq.api/stream-processor ".n = $n") (impl/->JsonNode {"n" 100}) {:vars (impl/->JsonNode {"n" 3})})

Now I see what is the issue. I've just made a PR with the feature #53


“Follow to the side” occasionally not working

Issue Type: Bug
When I try to follow to the side this error pops up on a pretty regular basis really annoying
Cannot read property of session id: undefined
Extension version: 1.0.3206
VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-11T01:11:34.018Z)
OS version: Darwin x64 18.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8559U CPU @ 2.70GHz (8 x 2700)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
4, 5, 6

Memory (System)
16.00GB (1.08GB free)

Process Argv
-psn_0_102425 --crash-reporter-id 9640f6d5-f90f-447f-af79-063fea1782dd

Screen Reader
no

VM
0%

Thanks for reporting this! Does this issue happen all the time? Or only sometimes?

At the time of this post, it was pretty consistently happening... every day, multiple times a day. It hasn't happened in at least 2 weeks but a couple of things have changed.
I have updated recently and now I always restart VsCode before pairing on my machine. It seems like if my computer goes into sleep mode overnight(and I can assure it does. I am one of "those" people)... when my partner tries to rejoin he sometimes gets an error message that is almost identical to the one above.... On the rare occasion it has happened when he has tried to rejoin after only a few hours.
We share two projects at the same time and it seems to inevitably happen when he tries to join one or the other, hence me just restarting. We have not had the same issue when it is vice-versa. He left his up for 2 days and I had no trouble rejoining the session... (his computer did not go into sleep mode). I just clicked on the rejoin link and it connected.
This may be an issue with my computer or it going into sleep mode and then reconnecting using the same session ID.
I cannot remember if I was having the "follow to the side" issue when connected to him, vice-versa or if it happened no matter who was sharing.
If it starts happening again, I can update the post if you would like.

Well I'm glad you've been unblocked 😁 It sounds like we can close this specific issue as resolved, and then re-open it if it occurs again?
That said, I'd also be interested to hear more about your Live Share session. Instead of starting and stopping your sessions for the day, have you and your pair been trying to just leave the Live Share session running overnight and then restart the same session in the morning? I'm just wondering if "planned sessions" would work for you (you can create a static URL and then re-use it), or if doing sessions invites via the Contacts pane would be helpful?

#4042 just hit this issue, so it's clearly a bug that we need to prioritize 👍

This issue has been fixed.


Improved Documentation

Description
Fixed Typos & Improved Readaility
Checklist

[x] Unit tested updated code paths
[x] Tagged 1 of @janniks or @zone117x for review

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@janniks Please review the pr


Calls to ray are not sequential

It seems calls to ray() are not actually sequential (see related issue https://github.com/permafrost-dev/node-ray/issues/7)
    ray('string 1')
    ray('string 2')
    ray('string 3')
    ray('string 4')
    ray('string 5')

Steps to reproduce the behavior:

Use the above example

Expected behavior
I am expecting to see the calls in sequential order, however, they are more like async calls
Screenshots

Environment (please complete the following information):

OS: macOS 10.15.7
NodeJS Version 10.15.7

Note: This could be the same issue as reported regarding clearAll() issue
https://github.com/permafrost-dev/node-ray/issues/7

Closed by mistake, this issues still exists

Thanks, I'm looking into this now.

@mikeerickson version 1.9.1+ should resolve this issue.  Please reopen if you're still running into issues.
Thank you!


Requirements URL Is Broken

The language name is not in path form.

Just kidding! Issue was in Ronbun


feat: Convert a/mod.rs into a.rs

This is the reverse operation of #10211.

Close #10143.

LGTM, but one nit: would you mind changing the label to Convert X to Y or Turn X into Y? It sounds a bit better.

Thanks!
bors r+


use Time module, split animation, rename count -> elapsedTime

Some changed I suggested.

I think this all got moved to the elm-architecture-tutorial.
Thanks for cleaning things up!


TSI1: text can be utf-8

Coverage decreased (-0.03%) to 72.077% when pulling 304994851b99ab787725a9c164b314d51ea9cb34 on moyogo:tsi1 into b97476885b24266dd4e0c16f14cebc8dbe6fcd98 on behdad:master.


event edit -time should be seperate of date or have date required

If you end up changing the time for an event a few days ahead it, it changes the date and I think those should be seperate commands or you should also have to fill in the date again in the change time command.
This is to ensure that it doesn't auto change the day and your event gets Started because you changed it to "1 min ago" on accident or something.

Just had this issue and couldn't figure out if this was fixed already or not.


how to upgrade table? Error 3050003: eosio_assert_message assertion failure

version1.0
struct contractinfo{
    uint64_t serverindex;
    uint64_t assfrosec;//asset frozen seconds

    contractinfo(uint64_t serverindexPar, uint64_t assfrosecPar, uint64_t scoresPar, asset feePar){
        this->serverindex = serverindexPar;
        this->assfrosec = assfrosecPar;
    }

    account_name primary_key()const { return serverindex;}
    EOSLIB_SERIALIZE( contractinfo, (serverindex)(assfrosec));
};

Then store a few records
version1.1, Add two fields，
struct contractinfo{
    uint64_t serverindex;
    uint64_t assfrosec;//asset frozen seconds
    uint64_t scores;
    asset fee;

    contractinfo(uint64_t serverindexPar, uint64_t assfrosecPar, uint64_t scoresPar, asset feePar){
        this->serverindex = serverindexPar;
        this->assfrosec = assfrosecPar;
        this->scores = scoresPar;
        this->fee = feePar;
    }

    account_name primary_key()const { return serverindex;}
    EOSLIB_SERIALIZE( contractinfo, (serverindex)(assfrosec)(scores)(fee));
};

but previously stored records can no longer be read because there are no later added fields in version 1.0!
we will get error:
"
Error 3050003: eosio_assert_message assertion failure
Error Details:

"

The current version doesn't support modification of struct, which will result in serialization problem. Please consider rename the table or make another new table instead.


Revised content filters

See email.

Coverage decreased (-0.01%) to 86.557% when pulling 50583d044e3f72acbb906dba94748e0e92875663 on revised-content-filters into da211074b6508ec565c346f89e4af456f2912e60 on master.

re: observations only -- See use case in other email.  Filtering out
lichens should apply to names as well as observations.
re: ContentFilter shouldn't know about checkboxes -- Agreed.  I still don't
have a concrete recommendation for an alternative.  Maybe record the data
type in the ContentFilter instead?  Then account/prefs and
observer/advanced_search can implement UI however they see fit?
re: non-checkbox filter -- Location is the only compelling use case so far.
re: Query::ObservationFilters leveraging ContentFilter -- Arg, yes, it
should, but I got really confused when I tried to do revise this file.  We
can definitely automate the declarations.  And the
"any_observation_filters_on?" methods.  But I couldn't figure out how to
automatically deduce in obs_filter_sql_conds that one boolean filter is
implemented with a "column IS TRUE" or "column IS FALSE" condition, and the
other (syntactically identical!) boolean filter is implemented with a
"column IS NOT NULL" or "column IS NULL" condition.  In the end it added a
large amount of complexity for virtually no gain.  Feel free to disagree.
I wasn't happy with how this file turned out.  The best I can think of id
create a "has_images_sql_condition" and "has_specimen_sql_condition" and
have obs_filter_sql_conds automatically call and AND these two conditions
together based on the filter.sym of the filters which are on.  Definitely
an improvement of what I left it as, but still requires explicit
specialized code for each filter.  Is there any way around at least that
much, though??
re:"dead" line in Query#validate_param -- Hmmm.  I don't think so.  It's a
bit ugly, and certainly won't pass rubocop and therefore should be
refactored, though.  This was a last minute thing to get the tests passing
so I could go to sleep. :(
Thanks for the comments.  This is important work.  (And very well done,
Joe, sorry I keep forgetting to say that!)  I think together we're going to
make this really robust. Well worth the effort.  Sorry it took me a long
night of living with the new code to understand it finally!
-Jason
On Mon, Jan 2, 2017 at 9:01 AM, Nathan Wilson<EMAIL_ADDRESS>wrote:

@mo-nathan commented on this pull request.
Not done with my review, but need to run so here are some initial
comments...
In app/classes/content_filter.rb
https://github.com/MushroomObserver/mushroom-observer/pull/262#pullrequestreview-14858959
:

end

def filters
[has_images, has_specimen]

Array of all available filters.

def self.all
@@filters ||= [

 ContentFilter.new(

   sym:          :has_images,

   model:        Observation,

   checkbox:     :has_images_checkbox,

In my view (and I think this agrees with a comment you made in email) this
object shouldn't know about checkboxes. I'd rather the UI generated the
name/symbol :has_images_checkbox based on the filter's sym.
In app/classes/content_filter.rb
https://github.com/MushroomObserver/mushroom-observer/pull/262#pullrequestreview-14858959
:

end

def filters
[has_images, has_specimen]

Array of all available filters.

def self.all
@@filters ||= [

 ContentFilter.new(

   sym:          :has_images,

   model:        Observation,

What's the current opinion about filters being relevant to anything other
than Observations? It seemed to me that we were converging on the opinion
that these are only relevant to Observations.
In app/classes/content_filter.rb
https://github.com/MushroomObserver/mushroom-observer/pull/262#pullrequestreview-14858959
:

end

module_function(:has_images, :has_specimen, :filters, :observation_filters,

             :observation_filter_keys)

Array of filters which use checkboxes.

def self.observation_filters_with_checkboxes

Do we have a motivating example for a filter without a checkbox? I could
see this once we get to location or taxon based filters, but it's not clear
to me what happens at that point and whether the has_images and
has_specimen filters remain special.
In app/classes/query/initializers/observation_filters.rb
https://github.com/MushroomObserver/mushroom-observer/pull/262#pullrequestreview-14858959
:

 end

 # Lets application controller easily check if we need to apply user's content

 # filter parameters to the current query.

 def observation_filter_input

   true

 end

 # Lets ApplicationController check whether to add default filters to

 # current query; defaults are added unless query already has

 # observation filter params, even if those filters are off.

 # This allows for overriding of default filters.

 def has_obs_filter_params?

   observation_filter_keys.any? {|k| params[k] != nil}

   {

     has_specimen?: :boolean,

Shouldn't this be leveraging ContentFilter.observation_filters() or a
related method?
In app/classes/query/initializers/observation_filters.rb
https://github.com/MushroomObserver/mushroom-observer/pull/262#pullrequestreview-14858959
:

 end

 # array of filters which are on (applied) in this query

 def on_obs_filters

   observation_filter_keys.each_with_object([]) do |filter, ons|

     ons << filter if is_on?(filter)

   end

 end

 # Does params[:x] == one of x's on_vals?  For example:

 # is_on?(:has_images) is true if params[:has_images] == "NOT NULL" || "NULL"

 def is_on?(filter_sym)

   return unless params[filter_sym]

   filter = send(filter_sym)

   filter[:on_vals].include?(params[filter_sym])

   !params[:has_specimen].nil? || !params[:has_images].nil?

Again should be leveraging something from ContentFilter.
In app/classes/query/initializers/observation_filters.rb
https://github.com/MushroomObserver/mushroom-observer/pull/262#pullrequestreview-14858959
:

   def obs_filter_sql_conds

   on_obs_filters.each_with_object([]) do |filter_sym, conds|

     filter = send(filter_sym)

     conds << filter[:sql_cond]

   conds = []

   unless params[:has_specimen].nil?

     val = params[:has_specimen] ? "TRUE" : "FALSE"

     conds << "observations.specimen IS #{val}"

I agree with keeping the SQL separate from ContentFilter, but this should
be derived based on a property of the ContentFilter rather than being
explicit for each key.
In app/classes/query/modules/validation.rb
https://github.com/MushroomObserver/mushroom-observer/pull/262#pullrequestreview-14858959
:

   else

   val = scalar_validate(arg_sym, val, arg_type)

   new_args[arg_sym] = nil

Given that you are failing a line above this, I believe this line is dead.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/262#pullrequestreview-14858959,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADE2teiJsLOqx-LQ_SapZaYW4UcG2_Dsks5rOS10gaJpZM4LY4b_
.

re: observations only -- See use case in other email.  Filtering out
lichens should apply to names as well as observations.

OK, I can see that as well as real taxa (e.g., Boletaceae).

re: ContentFilter shouldn't know about checkboxes -- Agreed.  I still don't
have a concrete recommendation for an alternative.  Maybe record the data
type in the ContentFilter instead?  Then account/prefs and
observer/advanced_search can implement UI however they see fit?

Yes, it seems to me that we should be saying more about the "type" of the ContentFilter.  I think this would help here and with ObservationFilters even potentially with getting rid of the explicit reference to the Observation or Name classes, or maybe we need some more booleans.  For example, .filter_type could be one of (:boolean, :id, :list, :name, :chained_filter).  :boolean and :id would get simple checkboxes and :boolean would use "IS TRUE"/"IS FALSE" whereas :id would use "IS NULL"/"IS NOT NULL".  :list would be fore the lichen case where there is an explicit list somewhere of lichen species.  :name be for matching as a regular expression against a .name field.  :chained_filter would take another field and another filter e.g., (:where, (filter :name "California"))).

re: non-checkbox filter -- Location is the only compelling use case so far.

Generalizing the lichen case to other taxa or lists also seems compelling.

re: Query::ObservationFilters leveraging ContentFilter ...

Does the .filter_type idea above resolve this?

re:"dead" line in Query#validate_param ...

My bad.

I like the "filter_type" field.  I think it's the right direction.
Actually, maybe we should be handling it instead as different subclasses of
ContentFilter.  That's probably the "right" way to go.
But I still don't like putting the SQL into ContentFilters, even if it's
half-hidden behind :id and :boolean type. I think the following case might
help make my point.  Right now we are still using the now-redundant
observations.specimen flag to implement the "has_specimen" filter.
Someday, me might like to see this go away and instead have it check if
there are attached specimen records.  That means the SQL condition will
change from "observations.specimen IS TRUE" to "JOIN specimens ON
specimens.observation_id = observations.id".  This sort of implementation
detail, in my opinion, belongs in Query, not the ContentFilter.
But I will support leveraging what we can from ContentFilter for the rest.
Right now with only two simple boolean filters it will, of course, increase
complexity.  But I'm glad to see interest in expanding the number and
complexity of filters.  It will probably be worth it eventually, if not
immediately.
I've been waiting for this feature for many years, very exciting!
-Jason
On Mon, Jan 2, 2017 at 12:14 PM, Nathan Wilson<EMAIL_ADDRESS>wrote:

re: observations only -- See use case in other email. Filtering out
lichens should apply to names as well as observations.
OK, I can see that as well as real taxa (e.g., Boletaceae).
re: ContentFilter shouldn't know about checkboxes -- Agreed. I still don't
have a concrete recommendation for an alternative. Maybe record the data
type in the ContentFilter instead? Then account/prefs and
observer/advanced_search can implement UI however they see fit?
Yes, it seems to me that we should be saying more about the "type" of the
ContentFilter. I think this would help here and with ObservationFilters
even potentially with getting rid of the explicit reference to the
Observation or Name classes, or maybe we need some more booleans. For
example, .filter_type could be one of (:boolean, :id, :list, :name,
:chained_filter). :boolean and :id would get simple checkboxes and :boolean
would use "IS TRUE"/"IS FALSE" whereas :id would use "IS NULL"/"IS NOT
NULL". :list would be fore the lichen case where there is an explicit list
somewhere of lichen species. :name be for matching as a regular expression
against a .name field. :chained_filter would take another field and another
filter e.g., (:where, (filter :name "California"))).
re: non-checkbox filter -- Location is the only compelling use case so far.
Generalizing the lichen case to other taxa or lists also seems compelling.
re: Query::ObservationFilters leveraging ContentFilter ...
Does the .filter_type idea above resolve this?
re:"dead" line in Query#validate_param ...
My bad.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/262#issuecomment-270015730,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADE2taDzURSoJ5ZuctjZ_hGf3O3xDVUDks5rOVq0gaJpZM4LY4b_
.

Not premature, we're just struggling with understanding how it will work!
On Mon, Jan 2, 2017 at 4:05 PM, Joseph D. Cohen<EMAIL_ADDRESS>wrote:

@JoeCohen commented on this pull request.
In app/classes/content_filter.rb
https://github.com/MushroomObserver/mushroom-observer/pull/262:

end

def filters
[has_images, has_specimen]

Array of all available filters.

def self.all
@@filters ||= [

 ContentFilter.new(

   sym:          :has_images,

   model:        Observation,

Pasting @pellaea https://github.com/pellaea comments here, to keep
thread together:
re: observations only -- See use case in other email. Filtering out
lichens should apply to names as well as observations.
and for locations. If I'm interested in Observations only if they're from
North America, I probably don't want my RSS feed to include new Locations
in Laos.
But am I guilty of premature generalization?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/262, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADE2tX4TNSD-qEfxtFT97TeQ63LoOg4dks5rOZDSgaJpZM4LY4b_
.

Coverage decreased (-0.2%) to 86.413% when pulling c06c169e4648801522d8057ef67f536a9a3feb0e on revised-content-filters into da211074b6508ec565c346f89e4af456f2912e60 on master.

Coverage decreased (-0.1%) to 86.438% when pulling c98d08ccb8f2d69b3a8db0161be7e4d2bb7b3a95 on revised-content-filters into da211074b6508ec565c346f89e4af456f2912e60 on master.

Coverage decreased (-0.1%) to 86.455% when pulling c8e57452a8ddffa156f790b08542be2db5181019 on revised-content-filters into da211074b6508ec565c346f89e4af456f2912e60 on master.

Coverage decreased (-0.02%) to 86.551% when pulling 86dfba15d2b79eeff213ac0dabf1dd8157a0e62c on revised-content-filters into da211074b6508ec565c346f89e4af456f2912e60 on master.

Coverage decreased (-9.0e-05%) to 86.569% when pulling b4f4bc6322eb3a0d8fe5b282305ee89976ced0b0 on revised-content-filters into da211074b6508ec565c346f89e4af456f2912e60 on master.

Coverage decreased (-8.0e-05%) to 86.567% when pulling a2d349b22cefc9dbf96e1629f109a2f50ce57873 on revised-content-filters into 4714c73f854aea7e52726a4644f3025a5e794a4a on master.

Coverage change is due to reduced total line count in the file due to the simplification of a coverage function.  Not going to worry about this coverage decrease.


ASIM Registry schema parser with its sample and test data for SentinelOne

Required items, please complete
Change(s):

Added ASIM Registry  schema parser for SentinelOne based on API Data

Reason for Change(s):

Initial version ASIM Registry  Parser

Version Updated:

Initial version

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Yes

Hi @jayeshprajapaticrest,
Thank you for raising Pull Request with us! We will review it internally and get back to you by shortly.

ETA: for review by 18th Aug

Hi @jayeshprajapaticrest, hope you are doing well. Just wanted to check if you got a chance to look at the suggestions shared. Please feel free to reach out to us for any queries or support. Thanks!

Hi @jayeshprajapaticrest, we are waiting for your response. Thanks!

Hi @jayeshprajapaticrest, thank you for accommodating the suggested changes! We will review the Pull Request.

Hello @jayeshprajapaticrest, please response to the above comments. Thanks!

@v-sudkharat: we're planning to update all SentinelOne-related PRs by tomorrow EOD.

@vakohl we have mapped the inspection fields below in the RegistryEvent parser, which we found from SentinelOne Alerts logs.
RuleName
Rule
ThreatConfidence
ThreatOriginalConfidence


[Sortable] Recompute position when position and group has changed

fixes #1445
fixes #1094
We had before
if (positionChanged) {
    ...
} elseif (groupChanged) {
   recalculate position
}

and no case for position and group changed
Now we have
if (positionChanged) {
  if(groupChanged too) {
       recalculate position
  } else {
    ...
  }
} elseif (groupChanged) {
   recalculate position
}

A new test is added to SortableTest for this case

good work, thanks ;)


pnpm build  ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL  Command "build" not found

I follow the README and run "pnpm build", but it failed with Command "build" not found
It works if I "cd workspace/extension" first.
❯ pnpm --version
9.11.0
Shall we add "cd workspace/extension" to the README?
git clone https://github.com/sveltejs/svelte-devtools.git
cd svelte-devtools
pnpm install
+ cd workspace/extension
pnpm build

Also, "cd workspace/website" and running "pnpm build" throws error, too
error during build:
Error: src/app.html does not exist

Thanks! I've opened #235 to update the instructions. For workspace/website, it's expected to not work yet and will be fixed with #213, but there's some other plans going on that we'll need to wait merging that too.


Feature request: redirect without changing browser URL

Is there a way in Spark to redirect without changing URL?
e.g.
I want http://example.com/message show the same content as http://example.com (static files.)
Or is there  way to load the static files and return it as response?
Thank you

Yes, I believe you can just redirect to the same URI, so it would effectively refresh the page.

Do you mean provide different content but using the same address? You can just return different content as part of the response.

I want to return same content for different address. The difficulty is that the content I am returning is static files, e.g.:
staticFiles.location("/public")
And I want to return the same content for:
get("/message/*", (request, response) -> {
// return static content located at "/"
});

Why can't you just return the same static content for different addresses?

Could you give me a code example? I couldn't find one in doc: http://sparkjava.com/documentation#static-files

Found a solution:
https://stackoverflow.com/questions/44401973/sparkjava-redirect-while-keeping-the-browser-url


Feature Request: Stormy/Rainy Weather with clouds and Fog / Weather Underground sounds

It would be cool to have dark flashing clouds on stormy weather or just dark clouds on rainy weather also for these you could try to use kind of static fog with depth 50 on 117HD plugin (environment section)  to make it a new rainy-foggy day
A nice feature could be that when you disable weather underground only disable the visual effects, but maintain the sound effects to make the weather immersive

also wanted to say thank you for all the hard work you did here, this is my favorite plugin now i'll share it with all my friends

Sorry for the late response.

I'd like to introduce toggleable clouds to rainy weathers at some point. Consider it on the list of things to do
Hmm... I could see that being a bit distracting. If you're very deep in a cave you wouldn't expect to hear rain at all, for example. You may have noticed tho that being indoors (like under a roofed area that isn't underground) now muffles your audio, so I hope that would suffice

You're welcome!

Just found this plugin and I love it! I really enjoy the clouds and not having them during rainstorms seems like a miss. Adding a checkbox for clouds during rain&snow would be awesome!


Serial number of the server to be reflected in Labels

Hi,
Require your help in getting the serial number of the server in the labels. Could you please provide the updated code or kindly guide me as to where all of it has been added to the code?
We can get the serial number from the function "ilo.get_host_data()" as i see.
Regards,
Suder.

@Sudermoni
Please note that this repository has not been updatd by its owner in a long time. We have a new community version of exporter which is actively maintained and welcomes any community enhancements.
https://github.com/hpilo-exporter/hpilo-exporter


Load logos from CDN

What
Load Census 2021, Welsh Government, and UKSA logos from CDN on Release Page.
How to review
Logos should be visible on desktop.
Who can review
Anyone


fix(generate): fixed typo in alloy generate components

https://jira.appcelerator.org/browse/EDITOR-42

Warnings

:warning:

src/commands/alloyGenerate.ts#L45 - src/commands/alloyGenerate.ts line 45 – Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)

Messages

:book:

:floppy_disk: Here's the built vsix for this change.

:book:

:white_check_mark: All tests are passing
Nice one! All 32 tests are passing.

  Generated by :no_entry_sign: dangerJS against 6c50e589e643bf5c94768c984ea1c0be5bed48d9


Add option to drag with a handle

Hi @philip-brink I've been looking for a decent, up to date, package which takes care of reorganizing lists. I've tried a few but they have all kinds of problems. Your project seems to be the most promising at the moment.
One feature, which I'd like to see would be the option to have a custom handle to drag an item with. Currently I can only drag an item on longpress or, if it's set to false, drag the whole item. Both ways have their user experience problems. Dragging on longpress takes a lot of time if there's a lot of items. Dragging the whole item makes scrolling the list impossible without a scroll wheel. I believe the best option would be to have a customizable drag handle.

Hi @mivoligo that's a great idea! It'll also help for iOS consistency as well. I'm pretty busy this week, but should have an update next week.

Awesome! Looking forward to it.

@mivoligo I've added the option for using drag handles now in version 0.2.0. You can enable this in DragAndDropLists by setting the parameter dragHandle. By default it's on the right, but you can also switch to the left with dragHandleOnLeft. I've also added a sample of how to use this in the example app.

@philip-brink Awesome! I'll take a look at it in this week hopefully and let you know.

@philip-brink Awesome! I'll take a look at it in this week hopefully and let you know.

I've managed to test the example file drag_handle_example.dart this morning. It works smoothly on Linux desktop. :+1:
Maybe couple things could be improved a little. I've noticed the handle is by default vertically centered within the item. Maybe this could be made more customizable in the future.
The other thing could be setting different mouse cursor when hovering and grabbing the handle. Currently it's a normal pointer.
I've also experienced a bug when the list is long but I'll report it in another issue.

Hi @mivoligo, I've added both of your ideas in v 0.2.4. For the drag handle vertical placement, you can now use thelistDragHandleVerticalAlignment and itemDragHandleVerticalAlignment parameters in your DragAndDropLists to control their alignment.

Thank you @philip-brink !


feat: spi 16-bit operations

Address rest of points in #105
TODO

[ ] Complete documentation
[ ] Test with 16-bit SPI sensors

Closing this since #148 added 16-bit SPI support.


libEGL warning: NEEDS EXTENSION: falling back to kms_swrast terminate called after throwing an instance of 'Ogre::InvalidParametersException'

Environment

OS Version: Ubuntu 22.04
Source: Ignition Fortress
ROS2  version: Humble

Steps to reproduce

Open one terminal run

ign gazebo empty.sdf

Open another terminal run

ign service -s /world/empty/create --reqtype ignition.msgs.EntityFactory --reptype ignition.msgs.Boolean --timeout 1000 --req 'sdf_filename: "/ros_ws/src/mobot_description/urdf/mobot.urdf", name: "mobot_description"'

I make sure the mesh path is correct and model is works in rviz2 correctly.
I try to delete the visual part in urdf and then it does not raise the errors, but I need the visual part.
The mobot.urdf is:
<?xml version="1.0" ?>
<!-- =================================================================================== -->
<!-- |    This document was autogenerated by xacro from mobot_overall.urdf.xacro       | -->
<!-- |    EDITING THIS FILE BY HAND IS NOT RECOMMENDED                                 | -->
<!-- =================================================================================== -->
<robot name="mobot_description">
  <link name="base_link">
    <inertial>
      <origin rpy="0 0 0" xyz="0.0105481626504806 0.000121730205140724 -0.0536615390649162"/>
      <mass value="11.9970840115073"/>
      <inertia ixx="0.0265731409814962" ixy="1.52214545840681E-05" ixz="-0.000581289129660373" iyy="0.0533099030677871" iyz="-5.74575531055247E-07" izz="0.0503147943878383"/>
    </inertial>
    <!-- <visual>
      <origin rpy="0 0 0" xyz="0 0 0"/>
      <geometry>
        <mesh filename="/ros_ws/src/mobot_description/meshes/base_link.STL"/>
      </geometry>
      <material name="">
        <color rgba="1 1 1 1"/>
      </material>
    </visual> -->
    <collision>
      <origin rpy="0 0 0" xyz="0 0 0"/>
      <geometry>
        <mesh filename="/ros_ws/src/mobot_description/meshes/base_link.STL"/>
      </geometry>
    </collision>
  </link>
</robot>

Output

➜  /ros_ws ign gazebo empty.sdf
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'
libEGL warning: MESA-LOADER: failed to open vgem: /usr/lib/dri/vgem_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/x86_64-linux-gnu/dri:\$${ORIGIN}/dri:/usr/lib/dri, suffix _dri)

libEGL warning: NEEDS EXTENSION: falling back to kms_swrast
terminate called after throwing an instance of 'Ogre::InvalidParametersException'
  what():  OGRE EXCEPTION(2:InvalidParametersException): StagingBuffer cannot map 0 bytes in StagingBuffer::mapChecks at /build/ogre-next-UFfg83/ogre-next-2.2.5+dfsg3/OgreMain/src/Vao/OgreStagingBuffer.cpp (line 64)
Stack trace (most recent call last) in thread 230276:
#10   Object "[0xffffffffffffffff]", at 0xffffffffffffffff, in
#9    Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7f708b5f584f, in
#8    Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7f708b563ac2, in
#7    Object "/lib/x86_64-linux-gnu/libQt5Core.so.5", at 0x7f7085c7e99d, in
#6    Object "/lib/x86_64-linux-gnu/libQt5Core.so.5", at 0x7f7085c7cf90, in qTerminate()
#5    Object "/lib/x86_64-linux-gnu/libstdc++.so.6", at 0x7f7087aff276, in std::terminate()
#4    Object "/lib/x86_64-linux-gnu/libstdc++.so.6", at 0x7f7087aff20b, in
#3    Object "/lib/x86_64-linux-gnu/libstdc++.so.6", at 0x7f7087af3b9d, in
#2    Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7f708b4f77f2, in abort
#1    Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7f708b511475, in raise
#0    Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7f708b5659fc, in pthread_kill
Aborted (Signal sent by tkill() 230206 0)

looks like it's an mesa driver issue? https://forums.developer.nvidia.com/t/vgem-dri-so-file-is-missing-libegl-warning/244383/7
You can try running with ogre 1.x render engine, e.g. ign gazebo --render-engine ogre empty.sdf

looks like it's an mesa driver issue? https://forums.developer.nvidia.com/t/vgem-dri-so-file-is-missing-libegl-warning/244383/7
You can try running with ogre 1.x render engine, e.g. ign gazebo --render-engine ogre empty.sdf

How can I force to always use ogre 1.x?

How can I force to always use ogre 1.x?

easiest way is to do it through the cmd line arg --render-engine ogre: this sets both the GUI window and the camera sensors to render using ogre. You can also edit ~/.gz/sim/<version>/gui.config and update <engine> to ogre for the GUI window.

@pep248 , @iche033 can this issue be closed?

yes, we can close this.

Yes.


[BUG] Fix builds on MacOS

Builds are now working on MacOS thanks to @itsyourboyjonnycat

thats right


"Jump to file" could behave more like the Edge developer tools in the browser

When clicking on a style property in the styles pane of the extension, you jump to the corresponding CSS file. This is very nice, but I would suggest to align this click behaviour with the behaviour in the Edge devtools in the browser:

when clicking on a style property, don't jump to the file
when clicking on the filename, do jump to the file
when control-clicking on a selector, style property or value, do jump to the corresponding file and line

The reason for this suggestion is that I sometimes just want to alter a value and do some minor CSS tweaking on a related component, while working in the context of another component. I don't want to switch context to the related component, because I'm just temporarily trying some things out to see how it interacts with the component I'm working on. Therefore, I think it could be nice if the file-jumping is a bit more of an explicit user action (by only jumping to the file when the user clicks on the filename, or when CTRL is used).

This should work when you have your files synced. As we don't have the sources tab like we have in the developer tools, I wonder where the link should go. I agree though that it shouldn't be a link if it doesn't go anywhere.

This should work when you have your files synced. As we don't have the sources tab like we have in the developer tools, I wonder where the link should go. I agree though that it shouldn't be a link if it doesn't go anywhere.

Hi billie-spektor.  After testing around, I can see your frustration with this behavior.  I'll take a look and try implementing a better workflow for this.  Thanks for filing this issue!

Hi billie-spektor.  After testing around, I can see your frustration with this behavior.  I'll take a look and try implementing a better workflow for this.  Thanks for filing this issue!

Thanks :) The gif in the pull request looks good!

Thanks :) The gif in the pull request looks good!


Issue adding a custom activity

I'm submitting a ...  (check one with "x")
[] bug report => search github for a similar issue or PR before submitting
[] feature request
[X] support request
[] general question

Current behavior (how does the issue manifest):
Hi Team,
I'm trying to use the "Hello World" sample in the doc to add a new activity but it doesn't work, the activity name appears in the UI but I'm unable to add it into a flow.
Could you let me know if I'm missing a step?
Please find the github repo for your reference
https://github.com/kawatoto/testFlogoActivity
Expected behavior:
Minimal steps to reproduce the problem (not required if feature enhancement):
What is the motivation / use case for changing the behavior?
Please tell us about your environment (Operating system, docker version, browser & web ui version, etc):
Flogo version (CLI & contrib/lib. If unknown, leave empty or state unknown): 0.X.X
Additional information you deem important (e.g. issue happens only occasionally):

Hi! To use the activity in the Flogo Web UI your activity.json needs a property called ref. In your case the attribute should have the value github.com/kawatoto/testFlogoActivity. Thanks for pointing out the issue in our documentation though! I'll make sure to update it.

Thanks Leon!
Now I can access to the activity.


tx-builder: ABI items of error type should not be considered as methods.

Description
The UI does not filter ABI items correctly.
In more detail, items whose type is error, which is a new kind of ABI item and can not be invoked as a method,  are also shown in the method selection box.
Here's a sample of contract which uses such kind ABI type. https://etherscan.io/address/0xC96dE26018A54D51c097160568752c4E3BD6C364
A simple fix could be like:
-        if (e?.type?.toLowerCase() === 'event') {
+        if (e?.type?.toLowerCase() === 'event' || e?.type?.toLowerCase() === 'error' ) {

https://github.com/safe-global/safe-react-apps/blob/4236a28d7cc6ed5581f445ea76cc73a0d60cbec5/apps/tx-builder/src/lib/interfaceRepository.ts#L53
Environment

Browser:Chrome
Wallet: MetaMask
Safe: all
Environment: all

Expected result
Items like AddressEmptyCode should not be included in the method option box.
Obtained result
See the screenshot below.
Screenshots

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Thank you! We're currently busy with other priorities so pull requests are welcome.


fe assignment 1

Metric
Value

alert_status
:white_check_mark: OK

bugs
2

code_smells
1

reliability_rating
D (at least 1 Critical Bug)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0


[TC Console.dot Portal] - In the 'Advisories' and 'Vulnerabilities' sections, there are no search results found no matter what string is inserted

Description
In the 'Advisories' or the 'Vulnerabilities' section, there are no search results found no matter what string is inserted
Steps to reproduce:
Open console portal
Select the 'Advisories'/'Vulnerabilities option
Insert any string in the search box -> Click '->' button
Expected result:
There will be results displayed according to the search strings inserted
Actual result:
No results are displayed, no matter what string is inserted.

Should be fixed now

Verified and it is working well now.

Verified and it is working well now.


VirtualService simple merging of http routes at Gateway

Fixes https://github.com/istio/istio/issues/7793 for Gateways only.
This is the rudimentary merge of http routes, pushing
the wildcard/catch all routes to the end.
We already support merging of TCP and TLS routes for gateways.
Merging virtual services at the sidecar requires a lot of intrusive changes to the RDS code.
Signed-off-by: Shriram Rajagopalan<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
06a85dea6bab82afb0053b7b2819a597b5d44211
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
861043e1c16e47a61ed3fb2f2928de399003c573
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
09d0d15a5458bc72b4b1d6f951a4ea6f8295cc2e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
09d0d15a5458bc72b4b1d6f951a4ea6f8295cc2e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-unit-tests.sh
2563a6daf924c0b2319b56ba19954956760d80bb
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
2563a6daf924c0b2319b56ba19954956760d80bb
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
16ac9cc53f506d9c5fc90471d3e2534d0040adf5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@ZackButcher / @costinm dumped the reordering completely. After discussion with @frankbu , here is what we have now:
 new routes =
   append all routes from first virtual service except the catch all routes
   append all routes from second virtual service except catch all routes
   append all catchall routes from first
   append all catchall routes from second

where catchAll is a route with no header match and a prefix match of / or regex match of *.
This technique preserves the relative ordering of routes within a VirtualService, eliminates the need to compare regular expressions. The burden is now on the user to ensure that the blocks of routes in two virtual services don't conflict with each other

I think this is a good and safe thing to try in 1.0.1, to get some feedback. Given that this only works in cases where there really are no conflicts, we aren't setting ourselves up for backward compatibility problems if we decide on doing some reordering in the future release.

Lets merge and iterate. Would like to have some variant in the release tomorrow. and need some time for this to soak, and test.

If we decide to fully reorder, please let me know by EOD today (after consensus)

The more I think about it, the more I think that ANY merge algorithm, other than the simple concatenate and preserve user's order, will not be backward compatible (or break things when a second resource is merged) if we do it by default (without explicit user request). I think something like @rshriram's mergeKey suggestion, which lets the user control merge ordering, might be the right future enhancement, but for 1.0.1 the simple concatenate is the best and safest way to go. I think the latest comments from @ZackButcher and @bmarshall13 in #7793 support this thinking.
@ZackButcher, I do think the the simple concatenate does solve some users problem in a meaningful way, the problem of clearly separating the host into contextually independent parts, presumably managed by different teams. I think the feedback from 1.0.1 will then help us understand where we need to go from there.

SGTM

Are there any notes about how one would test this?

@christian-posta A little bit of documentation is here: https://istio.io/help/ops/traffic-management/deploy-guidelines/#multiple-virtual-services-and-destination-rules-for-the-same-host

@rshriram
You said

Merging virtual services at the sidecar requires a lot of intrusive changes to the RDS code.

Why is that and whats different about the gateways ?
Any feedback is welcome :)
I know this is an old PR, but i didnt find any other references to VirtualService merging..


[FEATURE]: route_short_name in place of route_id

Hi,
(as HA forum is in maintenance, I put this here)
The list of routes you can chose from puts the route id in front of the route name in place of the the route_short_name. In my case, this is not related, so route_id 44 is in fact bus line 74.

´´´
sqlite> select * from routes where route_id = 44;
1|44|None|74|UCCLE-STALLE - CLEMENCE EVERARD||3||A67CB0|FFFFFF
sqlite> select * from routes where route_id = 74;
1|74|None|92|SCHAERBEEK GARE - FORT-JACO||0||E43C2E|FFFFFF
sqlite>
sqlite>
´´´
I didn't check on other gtfs files if the route_short_name is always the line name, but it might be a good idea to check and add it so it's less confusing.
Here's the link to STIB's gtfs file : https://stibmivb.opendatasoft.com/api/explore/v2.1/catalog/datasets/gtfs-files-production/alternative_exports/gtfszip/
Dan

Well... you already guessed it... the gtfs 'suck' on consistency how they use it. I have 2 sources without any short_name and (!) I need the ID, so that will stay. And I have another one where the short name makes no sense
So I can build it ID + short name + long name... it might become a mess though :)

This is how that would look with one of my lines

added with 0.1.5


OpenAIRE 4 submission forms

This PR changes the default submission-forms.xml file and virtual metadata configurations to enable the creation of the specific OpenAIRE entities and their relationships.
In order to use those forms you need to configure your item-submission.xml and add these to the <submission-map>:
<name-map collection-handle="123456789/2" submission-name="openAIREPublicationSubmission" />
<name-map collection-handle="123456789/3" submission-name="openAIREPersonSubmission" />
<name-map collection-handle="123456789/5" submission-name="openAIREProjectSubmission" />
<name-map collection-handle="123456789/4" submission-name="openAIREOrganizationSubmission" />

Please note that my collection-handle="123456789/4" will be different in your system.
EDITED:
Please mind that to test this PR you must firstly run the following:
[/dspace]/bin/dspace initialize-entities -f [/dspace]/config/registries/openaire4-relationships.xml
to load OpenAIRE Entities model and
[/dspace]/bin/dspace registry-loader -metadata [/dspace]/config/registries/openaire4-types.xml
[/dspace]/bin/dspace registry-loader -metadata [/dspace]/config/registries/datacite-types.xml

to load the required fields.

Merging, as this is at +2


Split out CLI and JS code

I wanted to make an issue to capture discussion about splitting this repo up into a core CLI library and a JS API as mentioned here: https://github.com/rosszurowski/micro-airtable-api/issues/9
It sounds like we want to build a core CLI library that can be used by the micro-airtable-api project so that there aren't breaking changes is the project. My thought would be an NPM package?
The big decisions that need to be made are around what belongs in the core CLI library and what features belong in the JS API. I'm going to make a PR just to demo a simple example, but this is all very lo-fi right now.

The plan from https://github.com/rosszurowski/micro-airtable-api/pull/13#pullrequestreview-153561892

Here's some thoughts on how I'd imagine the larger architecture around this. I don't think we need a separate npm package to split the CLI and JS APIs. I'd like to avoid that if possible, because it just becomes one more package dependency, and thing for people to remember.
Use Cases
It might be best to start with how this library could be used. We want to enable three main ways of spinning up an Airtable API.
Via a Now Deploy:
now rosszurowski/micro-airtable-api -e … -e …

Via a CLI:
npm i -g micro-airtable-api
micro-airtable-api start
# starts server…

And via a JS library:
const http = require('http');
const airtable = require('micro-airtable-api');

http.createServer(airtable(config));

We can achieve this in a single package with some smart use of package.json:

The main field points to the handler function, letting people require('micro-airtable-api') and using it as regular Javascript
A bin field will point to a file for the CLI: handling command-line arguments and spinning up a server from the handler
A start script (which Now runs on deploy) that either calls our CLI, or a separate script for a one-off server.

If you use a file structure like this, it should be fairly simple to achieve:
.
├── bin
│   └── index.js    # cli script, potentially what we run on `npm start`
├── src
│   ├── server.js   # optional, what we run on `npm start` if not the cli
│   ├── config.js
│   └── handler.js
├── index.js        # just re-exports `src/handler.js`
└── package.json


Trigger build workflows based on changed files #3439

closes #3439

Something is working properly
Your PR did not execute any workflow
It should have executed the gradle.yml workflow considering your branch name starts with feature-

When using the paths parameter instead of branches you should always include the workflow files in the paths so that changes to the actual workflows trigger the run(s)

Good point 👍 - suggestion added.


CLI errors should exit non zero

Diff or converge errors do not exit with a nonzero exit and they should.

See also https://github.com/rapid7/convection/pull/184#r78578402 for more context.


Setup CircleCI

Setup CircleCI to actually do a proper build instead of just echoing A first hello. I am not too familiar with CircleCI, so any help would be greatly appreciated.

Added circle ci config to check it builds properly (see PR) but both on my machine and on circle the build is currently broken (https://circleci.com/gh/bbeesley/react-building-blocks/2).
Looks like the issue is with this line import Button from './Button'; in src/components/Button/index.js. You're importing from a directory called Button but the directory is actually called button. Maybe you're not using a case sensitive filesystem on your machine?

OK, pushed a fix for that issue as well on the same branch. Build is passing now: https://circleci.com/gh/bbeesley/react-building-blocks/3

@bbeesley thought I would continue the conversation here. I added at least one test for Button for now just to get things going in the right direction. Let me know what I need to do when you get a chance.

@bbeesley I have made it so all components have 100% code coverage now for the ones that I currently have.

I believe I have finished setting this up.


Extendable validation exception

This PR makes the ValidationException extensible and provides it with some new convenience API

@armiol, after out discussion, PTAL again.


Half scale gaussian kernel GPU output mismatch - 5x5 kernel ACL version 17.10 - request for inputs

Hi Sir,
When executing Half scale gaussian kernel in ACL GPU, output mismatches with NEON output. NEON  is matching with reference  OpenVx implementation . Attaching the logs, sample workspace for reference .
Can you please help in resolving this issue?
Thanks,
Vinith
cl_halfscale_gaussian_api.txt
neon_halfscalegaussian_output.txt
Uploading cl_halfscale_gaussian_log.txt…

Hi @vinithsrvv1
One problem I've noticed in the test is that tmp2 is never allocated. I'll compare the output of CL with NEON and let you know if I can reproduce the issue.

Hi @vinithsrvv1
I removed tmp2 altogether, I'm not sure what the purpose of this variable was but it had no effect at all in the test.
I can't see anything wrong with the CL output, as shown below there are no mismatches between Neon and CL.

Please clean up your test (remove tmp2) and try this again with the latest version of ACL 18.05. Closing the issue, if you still experience the problem reopen.


widgets: Cache event handler instead of entire jquery for each widget.

In 61b3c698affb9aebf29300d36f42a1d8440151a6 we stopped restoring widgets from the cache, so the only purpose of the cache remaining was to access the event handler patched onto the widget jquery.
Now instead of the entire jquery object, we cache just the event handler since that's the only thing we need from the cache, and do not patch it onto the widget jquery object.
CZO thread

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

OK, merged, thanks @N-Shar-ma!