fix: --min-coverage does not work when running with --recursive

Description
Currently if you run very_good test --min-coverage 100 --recursive it will go through each package it finds and run the tests. But if any of those packages don't have 100% test coverage there won't be an error displaying that.
Here I am running the command at the root of my project:

It finds three packages, which is correct, but all three of them don't have 100% test coverage:

umbra_flutter:
umbra_core:
umbra_cli:

Steps To Reproduce

Create a repo with two packages, and ensure they don't have full test coverage
Run very_good test --min-coverage 100 --recursive at the root
Tests will succeed but no coverage is reported.

Expected Behavior
I expected that I was able to combine these flags together to run all my tests at the highest level and confirm that they all have the coverage I expected.
Related: https://github.com/VeryGoodOpenSource/very_good_cli/issues/383

When running the tests recursively, it should fail fast if one of the packages does not have the min coverage.

Is there any update on this issue?

Is there any update on this issue?

This issue is in our backlog right now and we’ll get to it as soon as we can but we are always happy to review PRs if you have time and are willing to contribute.

@willhlas  can you comment on this so we can assign you?

@renancaraujo hello!


Expose pipecd ops metrics

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

Looks good!
/lgtm

Yup, looks perfect ;)
/approve


add geom_bar options for position "stack" and "dodge"

Right now geom_bar plots the bars over top of each other - this is almost never the desired behaviour and shouldn't be the default. The current default behaviour should be called "none" and the default should be "dodge"

Can we make "stack" the default to be consistent with ggplot2?

resolved in https://github.com/TidierOrg/TidierPlots.jl/commit/a53d5d71c4bf10582b691d1a19f1d9540edebc66


CI: check mkdocs builds without any errors or warnings

I can't figure out how to do this - just running mkdocs build exists 0 even if there are errors in the Python snippets

Have you tried mkdocs build --strict? The code snippet failing does not fail the entire build

closed by #532


fix: make angle loader compatible with osx app bundles

This changeset fixes the ANGLELoader not working correctly when being executed via an osx app bundle.
The following changes have been made:

Do not extract libraries if executed via app bundle (working directory is / or a *.app/ folder)
Remove duplicate code by using the SharedLibraryLoader
Add documentation how to include angle in an app bundle

The changeset has been tested on:

Windows 11 (x64)
OSX 12.6 (arm64)
Linux Mint 21.1 (x64)

closes #7058

@davidgiga1993 I'm running into the same issue when submitting to the Mac App Store, amazing work! I am however surprised you're not running into the same issue with GlfwAWTLoader, which has similar logic and also doesn't use SharedLibraryLoader. Is that something you also encountered while making these changes?

@davidgiga1993 I'm running into the same issue when submitting to the Mac App Store, amazing work! I am however surprised you're not running into the same issue with GlfwAWTLoader, which has similar logic and also doesn't use SharedLibraryLoader. Is that something you also encountered while making these changes?

The main issue with angle is that is dynamically loads additional libraries from within the native code. This is outside of the JVM and is handled by MacOS. In that case macos prevents the library from being loaded as it's outside of the dynamic library paths defined in the java binary (thus the change required in the JVM).


Made dex fetch api dump on server start

The dex server plugin code should be way cleaner now and easier to edit
Dex now also fetches api dump on server start so it doesn't have to be manually updated whenever roblox adds something new

Highlight will come in a different PR.

why did you delete old Dex

why would you use the old dex its only more laggier and broken

yea but you didnt change the commands as well

yes i did


Update NBGL documentation (Layout layer)

Description
The goal of this PR is to update the layout layer of the NBGL documentation with recent API and screenshots
Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
[ ] Tests
[*] Documentation
[ ] Other (for changes that might not fit in any category)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.47%. Comparing base (25f141f) to head (f26446d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #669   +/-   ##
=======================================
  Coverage   60.47%   60.47%
=======================================
  Files          12       12
  Lines        1723     1723
=======================================
  Hits         1042     1042
  Misses        681      681

Flag
Coverage Δ

unittests
60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Open tasks for new plugin api

[ ] Data from Cloud Storage
[ ] Endpoint to run plugins async/sync
[ ] Update OpenApi spec

I can tackle "Data from Cloud Storage" and "Endpoint to run plugins async/sync" is still up in the air because we don't want to make the code messy or hard to maintain


prime factors of an Integers

I want to add a function to return the vector of prime factors of a number..?
Can you please assign it to me?

@ErSuyog16 add your pull request. if all will be ok, then I will marge that.


Show optional mail link on feedback page

This issue is imported from pivotal - Originaly created at May 1, 2019 by bstrooband
The mail link should visible if we know the emailadress from the Idp if we have the idp from the failed authentication procedure available.
diverged from #164121204

@arnoutt is the assumption is correct to show the support email address from the idp if we know the idp on the feedback page?

FYI: Currently this is a single address for all languages. (bstrooband - May 1, 2019)

The idea is to show the IdP mail address if the error the user sees can/should be solved by the IdP (and not SURFconext). (Arnout Terpstra - May 1, 2019)

So we should be able to "configure", (in the template or code of the error) whether the idp contact should be shown for this error. (Thijs Kinkhorst - Jul 23, 2019)

@arnoutt

Proposal to append to the error feedback configuration:
error_feedback:
    idp_contact:
        - received_invalid_response
        - clock_issue
    wiki_links: "%error_feedback_wiki_links%"
        fallback: \'%openconext_support_url%\'
        specified:
            received_invalid_response:
                en: \'https://example.org/wiki/page1\'
                nl: \'https://example.nl/wiki/page1\'
                pt: \'https://example.pt/wiki/page1\'
            received_invalid_signed_response:
                en: \'https://example.org/wiki/page1\'
            clock_issue:
                en: \'https://example.org/wiki/page1\'

Where a list of page identifiers can be configured under the idp_contact array.  And programmatically we can of course only show the IdP if it is present in the feedback information that is passed to the error page. And which IdP mail addresses should be used? I suppose the support or technical address? (Michiel Kodde - Aug 15, 2019)

@michielkodde For the IdP contact, use the support contact indeed. Not sure where exactly it comes from (you say "present in the feedback information that is passed to the error page"). I assume you know how that works, otherwise ask Thijs :)

I assume that if a specific error is indeed specified under idp_contact but for some reason the user's IdP doesn't have a support contact, the helpdesk button is not shown?
About the wiki_links:

Is the fallback url also multilanguage?
I assume that when an error is listed under specified, but only 1 lang is given (e.g. no NL @ clock_issue), the fallback url will be used? And for any error that is not listed under specified, no wiki link is shown?

Thanks! (Arnout Terpstra - Aug 15, 2019)

Hi @arnoutt, the feedback information setup holds little or no secrets for me.
Answers to your questions in order of appearance:

Your assumption is correct. If the support contact is not available, we will refrain from showing the IdP contact button.
The fallback link currently is not multilingual, but would make sense if it was! Putting this as a task on that story. #165742913
You are correct, that is how I implemented this. For future reference, I will state this in the story #165742913 (Michiel Kodde - Aug 19, 2019)

@michielkodde Perfect! (Arnout Terpstra - Aug 19, 2019)


SolrBackup doesn't work when the collections field is omitted

The SolrBackup CRD has the option to specify collections for backups. However, it's not a required field. One could imagine that without specifying this field, every collection should be backed up.
On version 0.6.0 when the collection field is not configured, nothing happens within the controller, only this is being logged.
2023-01-12T12:10:37.412Z	INFO	controller-runtime.manager.controller.solrbackup	Updating status for solr-backup	{"reconciler group": "solr.apache.org", "reconciler kind": "SolrBackup", "name": "test-whole-backup", "namespace": "one-preprod", "newStatus": {"solrVersion":"8.11.2","startTimestamp":"2023-01-12T12:10:37Z"}, "oldStatus": {"startTimestamp":null}}

Solr doesn't receive any API calls.

Once #507 is merged, we can add tests for this and make sure that it is good to go for the next release.


[sentencepiece] Update port to v0.1.95

Update sentencepiece from 0.1.82 to 0.1.95.
Successfully built in the following triplet:

x64-osx
x64-linux
x86-windows-static
x64-windows-static

simdutf should be fixed by https://github.com/microsoft/vcpkg/pull/19987

Thanks for your contribution!

https://github.com/JackyYin/vcpkg/blob/e113e89769c8cc6aab6527e9ab86c0ece6019645/ports/sentencepiece/portfile.cmake#L25
@ras0219-msft
isn’t this even worse than using an imposed CMAKE_DEBUG_SUFFIX, which is clearly stated as unwanted on vcpkg?
or, let me rephrase: isn’t it better to use CMAKE_DEBUG_SUFFIX instead of hard renaming an artifact after the built?

Hello @cenit,
Thanks for your feedback.
I think I can fix this in another PR,
maybe add an OPTIONS -DCMAKE_DEBUG_POSTFIX=d and remove line 25 - line 29 as you mentioned.

let's discuss with @ras0219-msft because that option is really not wanted here (even too much avoided imho), but again those lines are much worse and they passed the review

let's discuss with @ras0219-msft because that option is really not wanted here (even too much avoided imho), but again those lines are much worse and they passed the review

Some inconsistency between reviewers, sorry. :/
In this case the usual problems with renaming .libs aren't problems because this is an ONLY_STATIC_LIBRARY port


Bluetooth: Mesh: Redefine callback registration

There is a problem with the previous method, that is,
we use the same label(bt_mesh_subnet_cb_subnet_evt) and
put it in the same section, which is not friendly for debugging.
Signed-off-by: Lingao Meng<EMAIL_ADDRESS>

Mistake, sorry for this.


cmd/gofmt: gofmt breaks examples with multline comments as output

What version of Go are you using (go version)?

$ go version
go1.15.6 linux/amd64

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/agus/.cache/go-build"
GOENV="/home/agus/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/agus/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/agus/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build854558968=/tmp/go-build -gno-record-gcc-switches"

What did you do?
As per the guide "Testable examples in Go", I wrote a test file example_test.go inside an empty directory as the following:
package test1_test

import "fmt"

func Example() {
	fmt.Println(1)
	fmt.Println("\t\tA")

	// Output:
/*1
		A*/
}

Run go fmt and then go test:
What did you expect to see?
$ go test
PASS
ok      _/home/agus/code/bugreproduce/gorunnableexample 0.002s

What did you see instead?
After running go fmt (see on playground) , the program becomes:
package test1_test

import "fmt"

func Example() {
	fmt.Println(1)
	fmt.Println("\t\tA")

	// Output:
	/* 1
	A*/
}

The change of indentation of the line A* seems to make the test fail:
$ go test
--- FAIL: Example (0.00s)
got:
1
                A
want:
1
        A
FAIL
exit status 1
FAIL    _/home/agus/code/bugreproduce/gorunnableexample 0.002s

Relevant issues & workarounds:
https://github.com/golang/go/issues/41980
https://github.com/golang/go/issues/5128#issuecomment-708940093
https://github.com/golang/go/issues/6416
The problem can be worked around by using inline comments (//), which don't depend on formatting. This runs ok before and after gofmt:
package test1_test

import "fmt"

func Example() {
	fmt.Println(1)
	fmt.Println("\t\tA")

	// Output:
	// 1
//		A
}

However, this isn't satisfactory because it would make very difficult to check output longer that a couple of lines.

As you have correctly pointed out, https://github.com/golang/go/issues/5128 is the overall issue that tracks this. It is a problem that we've had for quite a while, and unfortunately, using inline comments are the only available workaround as of now.

As you have correctly pointed out, https://github.com/golang/go/issues/5128 is the overall issue that tracks this. It is a problem that we've had for quite a while, and unfortunately, using inline comments are the only available workaround as of now.

As you have correctly pointed out, #5128 is the overall issue that tracks this. It is a problem that we've had for quite a while, and unfortunately, using inline comments are the only available workaround as of now.

That issue is about whether or not block comments should be formatted. The topic shifted during the years and it's now 8 years old. Some code examples don't apply any more. In general I'm not against formatting block comments because the use is almost always within documentation headers.
This issue in turn is about allowing go fmt and go test to work together in a way that allows writing longer examples.
I'd rather keep them separate from each other, if possible.

As you have correctly pointed out, #5128 is the overall issue that tracks this. It is a problem that we've had for quite a while, and unfortunately, using inline comments are the only available workaround as of now.

That issue is about whether or not block comments should be formatted. The topic shifted during the years and it's now 8 years old. Some code examples don't apply any more. In general I'm not against formatting block comments because the use is almost always within documentation headers.
This issue in turn is about allowing go fmt and go test to work together in a way that allows writing longer examples.
I'd rather keep them separate from each other, if possible.

Fine to leave as a separate issue. At some point (maybe when doing whatever is needed to fine-tune generics gofmt output) we need to look at all these gofmt issues.

Fine to leave as a separate issue. At some point (maybe when doing whatever is needed to fine-tune generics gofmt output) we need to look at all these gofmt issues.


Pre-trained data

Do you have pre-trained data for medical images?

I unfortunately no longer have the pertained checkpoints as this work is nearly two years old


Update the Julia [compat] entry

It seems like this package no longer works on Julia 1.0. Therefore, this pull request updates the Julia [compat] entry in the Project.toml file.
cc: @scheinerman

@scheinerman This is ready to review and merge.


Request: allow users to pass in onDragEnd, onDragStart, onDrag callbacks

Use case: After drag I would like my component to internally update its state and track that the Sheet is opened at 600.
Interface could be something like ...
const Component = () => {
  // closed initially
  const [sheetPosition, setSheetPosition] = useState(0);

  return (
    <Sheet
      snapPoints={[600, 400, 100])
      onDragEnd={({snapPoint}) => {
        setSheetPosition(snapPoint);
      }}
    >
      ...
    </Sheet>
  );
}

On https://github.com/Temzasse/react-modal-sheet/blob/master/src/sheet.tsx#L82 we can add a
if (props.onDragEnd) {
  props.onDragEnd({snapPoint})
}

What do you think? Happy to contribute if you think this makes sense or if there's potentially a way for me to know the snappoint without passing in a callback!

Thank you for this idea! 🙏
I will think about this a bit and come back to you with a more detailed answer.

@krissalvador27 Sorry for not coming back to you sooner with an answer.
Do you think that onSnap prop could work?
onSnap: (snapPoint: number) => void

The snapPoint would be a snap point value from the given snapPoints array.
This onSnap would be called when the sheet opens, closes, manually snaps via ref, or after dragging has ended.
I already have a working solution and I think I could just release it on npm for people to try out since it doesn't change or break any existing functionality.

Released the mentioned onSnap prop in v1.2.0 which should solve this issue.

Released the mentioned onSnap prop in v1.2.0 which should solve this issue.


那个分支是可用的？

你好我clone了2.0的分支，但是mvn install 项目 tesseract及designer时，均报错。
[ERROR] Failed to execute goal on project designer: Could not resolve dependencies for project com.baidu.rigel.biplatform:designer:jar:2.0.0-SNAPSHOT: The following artifacts could not be resolved: com.baidu.rigel.biplatform:cache:jar:2.0.0-SNAPSHOT, com.baidu.rigel.biplatform:schedule:jar:2.0.0-SNAPSHOT, com.baidu.rigel.biplatform:common-api:jar:2.0.0-SNAPSHOT, com.baidu.rigel.biplatform:model:jar:2.0.0-SNAPSHOT: Could not find artifact com.baidu.rigel.biplatform:cache:jar:2.0.0-SNAPSHOT -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR] Unknown lifecycle phase "intall". You must specify a valid lifecycle phase or a goal in the format <plugin-prefix>:<goal> or <plugin-group-id>:<plugin-artifact-id>[:<plugin-version>]:<goal>. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, generate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-clean, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/LifecyclePhaseNotFoundException

@jonahLD Me,too. Have you solved it?

@gclsoft no，

1.7.0 is the newest release version.  @gclsoft


Allocate 1D iteration space one at a time for more even distribution.

Resolves #5778
I don't think we need to add a test for this one.  I hand checked that the distribution is evenly spaced.

Thanks for the patch. I think the proposed makes it so that the schedule is weighted more evenly, but the distribution over the schedule ends up with there being more work in the tail of the schedule array. Am wondering if this will have an adverse impact on e.g. TBB performance where working threads are more dynamic in that the less intensive bodies are will end up being run first this potentially leading to a less balanced load?
For example, #5778 reproducer looks like this with 12 chunks:
_lower_parfor_parallel done
loop range[0]: 0 20 (1)
do_scheduling_unsigned
num_dim = 1
ranges = ([0, 19], )
num_threads = 12
sched[0] = 0 0
sched[1] = 1 1
sched[2] = 2 2
sched[3] = 3 3
sched[4] = 4 5
sched[5] = 6 7
sched[6] = 8 9
sched[7] = 10 11
sched[8] = 12 13
sched[9] = 14 15
sched[10] = 16 17
sched[11] = 18 19

@stuartarchibald Good suggestion.  I've front-loaded the larger iteration divisions.

Thanks @DrTodd13, with c9b0427 this appears:
loop range[0]: 0 20 (1)
do_scheduling_unsigned
num_dim = 1
ranges = ([0, 19], )
num_threads = 12
sched[0] = 0 1
sched[1] = 2 3
sched[2] = 4 5
sched[3] = 6 7
sched[4] = 8 9
sched[5] = 10 11
sched[6] = 12 13
sched[7] = 14 15
sched[8] = 16 16
sched[9] = 17 17
sched[10] = 18 18
sched[11] = 19 19

which looks front-loaded as discussed. It'd be nice one day to make the schedule accessible programmatically such that unit tests could assert properties, however, that's not for this PR. Thanks again for fixing, marking for merge.

Presume the force-push was an accident, rechecked the code, still fine to merge on c9b0427.

Presume the force-push was an accident, rechecked the code, still fine to merge on c9b0427.

I had accidentally pushed a change for one of my other PRs to this one.  Then I did a force-push to get rid of it.  It should be fine to merge.  Thanks!


Populate the US with a baseline population of Indigenous Tribes

This is the first step in adding in an accurate portrayal of the location and migration of the indigenous peoples of North America. This is not going to be an exhaustive set of tribes, but just enough to show that there were indigenous tribes all over the US when the Europeans "discovered" and laid claim to North America. All tribes will be treated as statically-located entities at first as a placeholder. Subsequent work will treat these tribes as dynamically-located entities.

Closed this in #111


Recurring Issue: Broken Links in Documentation - https://miniature-adventure-4gle9ye.pages.github.io Returning 404 Errors

Hello Team,
I wanted to bring to your attention an ongoing issue with the Open Mobile Hub's Android OMH Storage repository. The documentation contains multiple links pointing to https://miniature-adventure-4gle9ye.pages.github.io, which are currently returning 404 errors.
This issue has been reported in the past in other repos, so it should have been caught this time, and it would be beneficial for us to resolve it to prevent any disruption for our developers and business development team. They rely on these pages to showcase the SDK to app developers effectively.
Here's a search result that highlights all instances where the incorrect domain is being referenced.
I understand that managing documentation can be challenging, and I appreciate the hard work everyone is doing. It would be great if we could update the links to ensure they reflect the correct URLs and maintain the reliability of our documentation.
Please let me know if there's anything I can do to assist in this process.
Thank you for your attention to this matter.

Hi Diego, @adamTrz will look into that today

Thank you, @adamTrz and @Nataliagros, for handling this. The changes look good at first glance. I’ll conduct a more thorough review next week.


update_{min,max} fail if val is None

Apache Iceberg version
main (development)
Please describe the bug 🐞
This code covers the case that self.current_{min,max} is None but not that val is None
https://github.com/apache/iceberg-python/blob/b7cf14e3b195064d8740b8f2ab306d8729e54dc2/pyiceberg/io/pyarrow.py#L1336-L1340

Thanks for raising this @jonashaag. This seems like a serious issue. Do you have a stack trace or some lines to reproduce it? That would be very helpful.

Reproducer (here with strings)
schema = Schema(NestedField(1, "col1", StringType(), required=False))
tbl = create_table(..., schema)
arrow_schema = schema_to_pyarrow(tbl.schema())
tbl.append(
    pyarrow.Table.from_pylist([{}], schema=arrow_schema)
)

@Fokko @syun64 this didn't actually fix my bug, I can still reproduce

Hey, thank you for flagging this again. I think we must have misunderstood the problem at first:
the issue here is that current_{min, max} is not None and that val is None, possible because the minimum value within the row groups are different.
min(date(2024, 2, 4), None
raises the same exception as above (the order of the comparison objects is reversed for the min operator).
I think the fix is clear here now that we understand the issue… @Fokko do you agree that we need to generate a next RC for this issue?


bug: fix incompatible com.coveo:fmt-maven-plugin:2.11:format version

According to https://github.com/coveooss/fmt-maven-plugin#using-with-java-8, the version 2.11 is only compatible with Java11. This project specifies maven compiler as 1.7.

@c24t would you be able to review/merge this? I don't have permission to add reviewers nor merge.


I try use this nuget but not working

Hi.
I installed the nuget on my all projects, and add the Line TouchEffectPreserver.Preserve() then tried the examples you have by, copying and pasting them into my project, so the animations not working. Am I missing something to add something else?
I appreciate your guidance

Hi, please show me your Xaml and Code

Same issue here

   <StackLayout
        touch:TouchEff.RegularBackgroundColor="Green"
        touch:TouchEff.PressedBackgroundColor="Red"
        touch:TouchEff.PressedScale="1.2"
        touch:TouchEff.RippleCount="1"
        touch:TouchEff.PressedRotation="10"
        touch:TouchEff.PressedRotationX="15"
        touch:TouchEff.PressedRotationY="15"
        touch:TouchEff.PressedTranslationX="5"
        touch:TouchEff.PressedTranslationY="5"
        touch:TouchEff.PressedAnimationDuration="500"
        touch:TouchEff.RegularAnimationDuration="500"
        touch.TouchEff.Command="{Binding Command}">>

                    <StackLayout BackgroundColor="{Binding DriverActivity.IsPriority, Converter={StaticResource ActivityStatusToBackgroundColorConverter}}" Orientation="Horizontal" Padding="10">

                        <customcontrols:LicensePlate IsVisible="{Binding LicensePlate.VehicleLicensePlate, Converter={StaticResource IsVisibleStringToBoolValueConverter}}" ControlTextColor="Black" ControlText="{Binding LicensePlate, Converter={StaticResource LicensePlateValueConverter}}"></customcontrols:LicensePlate>

                    </StackLayout>
    </StackLayout>

@programmingworld1 does Command exist in binding context?

@AndreiMisiukevich The command exists indeed, this problem occurs for both ios and android

@AndreiMisiukevich The command exists indeed, this problem occurs for both ios and android

And you use latest version, right?

@AndreiMisiukevich  Yep, I am. I just installed it yesterday.

@AndreiMisiukevich Yep, I am. I just installed it yesterday.

touch.TouchEff.Command
Should be
touch**:**TouchEff.Command

@AndreiMisiukevich Indeed, I changed that to ":". But that doesn't work.. It shows a background color on the stacklayout but does nothing when I click on it. Maybe the problem is bigger, because the gesturerecognizer from xamarin.forms doesnt work neither, not even on a normal label.

Works fine for me

@programmingworld1 perhaps the view cannot find your Command in binding context.
You can build a small sample with the issue where GestureRecognizer works, but this package doesn't.

@AndreiMisiukevich Indeed, I changed that to ":". But that doesn't work.. It shows a background color on the stacklayout but does nothing when I click on it. Maybe the problem is bigger, because the gesturerecognizer from xamarin.forms doesnt work neither, not even on a normal label.

You can run samples in this repository and play there. Because I cannot reproduce the issue.
Would be great to have a sample

@AndreiMisiukevich Oke, I will have a look at it!

@AndreiMisiukevich Thank you veyr much for your help, it works! The problem was indeed that I used the wrong bindingcontext.. Now I refer to the page bindingcontext instead of the bindingcontext if the item i nthe collectionview, my bad!


qtr1delta alleles not merging

There are two "qtr1delta" alleles in Chado that should be merging into one feature.

Can you let me know the sources?

I  just changed SPAC1687.19cdelta  into qtr1 delta in
curs/59866e3fe9bebea8/
but I don't think that is the issue?
The Canto session look OK, so maybe there is a trailing space in one of the PHAF files?

I think it's a bug in the Chado loader.  I'll dig out the sources.

I think I already changed it.... but I might not have. I can't remember!

I think this is a duplicate of: pombase/pombase-chado#992


Lazy load locales

Closes #1345
index.js size reduction: 538.71 KiB -> 382.74 KiB
TODO

[ ] check for alternatives for vite plugin to load supported locales
[ ] lazy load dayjs locales
[ ] lazy load TimeAgo locales

to test if key is right on linux via cli:
cat web/src/assets/locales/en.json | jq .repo.enable.success

if you get your value the key is right ;)

I couldn't get lazy loading of dayjs and TimeAgo locales to work, so I would suggest to try that later.

Thanks :)


Parametrize Avro dependency version

This is useful when in custom build users want to change Avro version without editing source code.

Can you explain more about the specific motivations for this change? If there is a benefit to upgrading to a newer version, then we should update.
We normally only add version properties when there are multiple dependencies that need to share the same version.

The motivation of this PR is to add a capability to build custom version of Presto with non-default Avro dependency (it could be higher or lower). This is useful when Presto build is part of a bigger build that includes many other OSS components. For example we build our own Hadoop, Hive and Presto and would like all of them to use the same dependencies that we deem important (file formats, for example). In such situations it's handy to have parametrized build that allow to override these dependencies without modifying source code.

The convention is important from a standpoint that this is non-standard, so it might get removed later when someone notices that it's only used in one place. We could address this with a comment, but that leads to the question of why certain dependencies are special in this way.
I'm more concerned about whether this is a reasonable thing to do. The version of dependencies chosen by Presto are an implementation detail. Two versions of Avro might be equivalent from Presto's perspective, as they only have changes in things not used by Presto, or the changes are inconsequential. If they are different in a user visible way, such as producing a file with different contents, then that's important, and we need to understand the consequences. For example, is the new format compatible with old readers? Do we have tests that cover this?
For these reasons, we don't want to encourage or tell people that it's ok to swap out the dependencies at build time. Changing the version is typically a small part of a larger change.
This might be better to discuss Slack.

This make sense, I will close PR then. Thanks for explanation!


Install: R errors are silent

While upgrading the pipeline, I noticed that a few R packages failed to install (glibc version mismatch), but the installation went on nevertheless. Like all the other steps, install failures should abort the install / upgrade.

Luca -- apologies for the confusion. The R packages are in flux as we move over to installing R along with bcbio, and some of the more difficult experimental packages like BubbleTree don't install cleanly on some platforms. We'll definitely work on fixing this as we improve support for these but it's currently expected to not abort as we don't want to stop the install for work in progress. Thanks much for the report.


Errors on schema with interfaces

Given a schema with interfaces:
type Account {
  id: ID
  profile: ProfileData!
}

interface Profile {
  email: String
  phone: String
}

type ProfileData {
  personal: PersonalProfile
  business: BusinessProfile
}

type PersonalProfile implements Profile {
  firstName: String!
  lastName: String!
  email: String
  phone: String
}

type BusinessProfile implements Profile {
  name: String!
  type: BusinessTypes
  email: String
  phone: String
}

@miragejs/graphql gets confused when trying to create Models. The attempts to create a ProfileData record using server.create('profileData') gives an error indicating there is no model nor factory available for it.  In addition, a Profile model is created when there should be none since it is an interface.

Which version of the library were you using when you encountered this issue? There are similar tests for this in the project. I modified the test schema and tests locally to more closely match your scenario and everything is working as expected.


Add select Operation

This implements item 1 in the proposal for adding select.

Put the IndexUnaryOps which return bool into the grblas.select namespace
Allow these to be called directly (gb.select.tril(A)) to perform a select operation
Include the "special" versions (select.row, select.column, select.value), but also include the "raw" versions (select.rowle, etc)
Add a select method (e.g. A.select("tril"), A.select("<", 1), A.select(gb.select.diag, 1), A.select("row<=", 1))

Aha, I see you found errors in the bizarro tests: https://github.com/metagraph-dev/grblas/blob/8e9acb9c1ac0e5689fc2f1066fd60020ea1c3ffe/.github/workflows/test_and_build.yml#L102-L109
This trick is kinda weird, but it's the best way I know to test both types of scalars (C and GrB) throughout the API.  You may find it handy to switch to bizarro world locally with this command:
#!/bin/bash

find grblas -type f -name "*.py" -print0 | xargs -0 sed -i -s \
    -e '/# pragma: is_grbscalar/! s/is_cscalar=False/is_cscalar=True/g' \
    -e '/# pragma: is_grbscalar/! s/is_cscalar = False/is_cscalar = True/g' \
    -e '/# pragma: to_grb/ s/is_cscalar=True/is_cscalar=False/g' \
    -e '/# pragma: to_grb/ s/is_cscalar = True/is_cscalar = False/g'

Scalars are GrB by default, but there are a few places in the code where they must be a specific type of scalar.

When creating a scalar with is_cscalar=True, it is assumed that it must be a C scalar.

Add # pragma: to_grb if it is allowed to be GrB

When creating a scalar with is_cscalar=False, it is assumed it is also safe to change it to a C scalar.

Add # pragma: is_grbscalar if it must be a GrB scalar

We added my_op.is_positional attribute to operators for ones like positioni and firsti.  I think IndexUnaryOps should also have .is_positional attribute, and I think it should be true for all IndexUnaryOps except those with "VALUE" in the name.  Then, in select, the thunk should be treated as int64 if the op is positional unless the int32 version of the operator was explicitly given.

Please try to increase coverage: https://coveralls.io/builds/48230528

@eriknw I think this is ready. Please take one last look, and if you're happy with it, go ahead and merge.

Also, I tried select on a Matrix with a UDT, and it worked!  Can you add a simple example to test_udt in "test_matrix.py"?  For example, you could verify that these give the same result: gb.unary.one(gb.select.tril(M)) and gb.select.tril(gb.unary.one(M)).

For warm-fuzzies, you may want to merge with main branch and update to python-suitesparse-graphblas <IP_ADDRESS>.

This is in, thanks so much @jim22k :tada:


Tests to verify rebind with DynamicMultiGroup, before and after stopp…

…ing an applicaiton with it
Signed-off-by: Mykola Mandra<EMAIL_ADDRESS>

I think this can be merged although there are plans to fix the problem for the remaining Broken test.

this seems to be triggering a race condition where the DMG is being destroyed while a policy runs trying to create a child bucket.  for me it is non-deterministic, happening about 1 in 4 runs.
it is rare that this would occur IRL, basically you need to destroy a DMG in the same sub-second that it is trying to add.  fortunately it is easier to re-create with a test because it can destroy right after the entity which will trigger the bucket is created, when the policy is still running.
it would still be nice to fix though!  i think there are several ways we could do this:
(1) if persisting a BrooklynObject (source BO, eg entity, policy) which has a reference to a target BO which is being destroyed or is destroyed, warn during persistence; this will at least help us to track down the cause if we subsequently see a rebind problem - EASY but NOT A FIX
(1') - as (1), but either omit from persistence or destroy the source BO when one is detected with a missing target - FIX but MESSY, it's basically a clean up process rather than the root cause, and RISKY if ever there are valid cases for persisting something that might have a dangling reference (but I don't think there are)
(2) when creating a source BO, check if its parent/entity is no longer managed, and fail at that point before it is recorded so that it doesn't end up in persisted state - FIX but NEED BE CAREFUL of races and deadlocks
(3) where target BO's create source BO entities/policies/etc directly, set a flag and do a check in onManagementStopping to block until such creation is completed - FIX but PER ENTITY so tedious and easy to miss and BLOCKS DELETION which is not ideal
i think (2) will be the best, maybe also with (1) -- keeping 1' in mind for future; for (2) i think currently we set a flag on the target BO early on in the management stopping process, before it tells the persistence store the item is being deleted, so even if they are racing, the source BO checking for that flag should work.  even if unset it will immediately add the reference to the target BO, giving "plenty of time" (milliseconds) for that to complete before the target BO goes from the management stopping to informing persistence to delete, and meaning by the time the target BO tells persistence state it is gone, it will almost certainly have the reference to the source BO and so both will be deleted


Enable plugin for single server/location only

First of all many thanks for the great job the whole crs team is doing to make the web more secure!
I just found this plugin and would like to try it on my system. Is there any possibility to enable the plugin only on server/location level? In the old rule implementation there is the possibility to enable it with the variable crs_exclusions_phpmyadmin which allowed to enable it in specific directives only. Do you plan to support this here as well?
This is a very specific plugin and should be only enabled on the server/location where it is needed. On the other plugins this configuration option was not needed as they are for the general server protection, but I believe most users have also other websites on the web server where this exclusion rules could be a security risk.

Hi @flo-mic,
You can limit the uses of the phpmyadmin exclusion package, for instance by activating it only in the certain .
SecAction \
 "id:123456,\
  phase:1,\
  nolog,\
  pass,\
  t:none,\
  setvar:tx.crs_exclusions_phpmyadmin=1"

It's also possible to only activate it on certain paths - if you use Apache it can be done within a <Location>.

Sorry, I replied to you, but my solution only was relevant for CRS 3.3.x. Hopefully somebody else has a good solution for your problem. Otherwise we will take it to our next meeting.

I think we should keep the new plugin repositories private until they are officially released with CRS 4, to prevent confusion (otherwise we have two lots of REs officially available at once…)
Personally, I would put such a configuration in its own <VirtualHost> section, e.g. a WordPress only section with the WordPress RE plugin enabled.
@flo-mic For the avoidance of doubt, this rule exclusion plugin is the same as the one you can currently get in the official CRS release using the crs_exclusions_phpmyadmin variable, so you can get exactly the same effect by using it in, say, v3.3.2 as usual.

For context, the CRS official documentation currently advises the following:

Tip
If running multiple web applications, it is highly recommended to enable a rule exclusion package only for the location where the corresponding web application resides. For example, to enable the WordPress rule exclusion package only for locations under ‘/wordpress’, a rule like the following could be used:
SecRule REQUEST_URI "@beginsWith /wordpress/" setvar:tx.crs_exclusions_wordpress=1...

That is correct. We do not have this option when people want to restrict plugins / RE-plugins to individual hosts.
Moving REs to plugins is still the right move, but it does not really allow us to make them more flexbile with the use of Startup time exclusions.

I think we should implement this feature (and i'm sure @airween will agree with me). @dune73 I asked you this some time ago in some other discussion but you didn't reply: Are there any technical problems why this cannot be implemented?

Yes, true. I did not respond. Sorry.
The problem is this is applied context-wide. So either you load the rules / plugins on the server and then it's applied everywhere.  Technically, that works AFAICT (but I do not run it in prod like this), but ModSecurity is known to produce memory leaks this way and hosters run thousands of VHs on the same server, so it's kind of annoying ...

@dune73 @azurit not sure if this is the right approach. But I combined the plugin and rule based implementation in my pgadmin plugin (https://github.com/flo-mic/pgadmin-rule-exclusions-plugin)
I think a option to enable/disable a plugin is not needed for every plugin. If we have a application specific plugin like pgadmin or phpmyadmin this option should be available. On generic plugins like antivirus or fake-bot detection it might not be required. Therefore the generic plugins can still use features like SecRuleUpdateTargetByTag.

@dune73 Why we cannot implement a configuration option which can be used to disable a plugin?
I think enable/disable is needed only for RE plugins like phpmyadmin, as @flo-mic already stated.

This should be implemented, can you confirm @flo-mic ?

Yes, it's implemented with latest plugin change. Thanks


Port OpenID Connect plugin from DSpace-CRIS 7 to DSpace

Is your feature request related to a problem? Please describe.
Integrating other systems with DSpace is a challenge that is made easier by having a shared user database. Open ID Connect provides such infrastructure. Keycloak is an opensource way of providing such a service, and AWS Cognito is a hosted option to do the same.
Describe the solution you'd like
DSpace-CRIS 7 has an OpenID Connect auth plugin, it should be fairly straightforward to port this code to DSpace 7.
Describe alternatives or workarounds you've considered
rewriting this code from the ground up
Additional context
The NGLP project has identified OIDC authentication support as a core need for building/delivering systems that integrate with DSpace.
PR no. 1: https://github.com/DSpace/DSpace/pull/8088
PR no. 2: https://github.com/DSpace/dspace-angular/pull/1470

Guys


GCC 1.27 doesn't show up

See #1263 - although we have the compiler, it doesn't show up in the list as it doesn't support --help or --version

I'm a fool, it's under C not C++ :-)


tap_migrations: support renaming to/from casks.

Allow tap_migrations entries to have a user/repo/formula or user/repo/cask format for migration of formulae to/from casks.

@miccal @vitorgalvao
FYI this is now merged so proper renames between Formulas and Casks should work now.

Excellent news @adidalal, does that imply we can make a start on https://github.com/caskroom/homebrew-cask/issues/23938?

Yes, feel free to tackle those if/when you have time/are interested. There look to only be a handful that people actually use (see the analytics from that post).


Saving a view graph spec directly from editor doesn't work.

Steps to reproduce:
Save a view directly from the editor window after modifying the script
Open the view and edit
Compare new script code with expected saved one, changes are not included.

Fixed on https://github.com/K2InformaticsGmbH/dderl/commit/9c789f2f72d28b42603c4a25fc76054e1d850292


Implement Generics

Adds generics to noir. Currently supports generic functions and structs by adding <> brackets with a list of identifiers within. Currently compiles:
struct Bar<T> {
    one: Field,
    two: Field,
    other: T,
}

fn foo<T>(bar: Bar<T>) {
    constrain bar.one == bar.two;
}

fn main(x : Field, y : Field) {
    let bar1: Bar<Field> = Bar { one: x, two: y, other: 0 };
    let bar2 = Bar { one: x, two: y, other: [0] };

    foo(bar1);
    foo(bar2);
}

After this PR some additional smaller changes will still be helpful. For example there is no distinction currently between "type variables" and "unification variables." Both are called type variables but allow reassignment to other types. So a unification of T = i32 will assign T to i32. This can be undesired if a user writes a function fn foo<T>(x: T) { t == 2_i32 } clearly intending it to be generic (though erroneous) when the compiler knows T must be i32 and quietly reassigns it under the scenes instead of errors. This can be fixed in a later PR.
There is also a FIXME in the ssa pass where ObjectType::from(Type) is sometimes called on unbound type variables (e.g. on a generic function like fn id<T>(x: T) -> T { x } and so we cannot determine a concrete ObjectType to use for all instances of this function. A later PR may be needed to implement e.g. monomorphisation to fix this but it is not part of this PR since the included basic example works.
Edit: Another helpful future change is improving type errors, I have not given them attention at all in this PR. An unbound type variable will be shown as T{N} where {N} is its unique id. Preferable would be keeping its original name if it does not conflict with other type variable names, or automatically renaming them.

Pushed a commit fixing a bug from the generic array sizes PR causing some compilation failures due to the new array size type variable not being generalized.
The commit also added/implemented function types.

LGTM then. I want to leave for @guipublic or @kevaundray to also take a look though as it is a bigger PR.

Forgot to mention this in the initial description:
This PR also changes the array syntax from [N]T to match rust's [T; N]


Icon request

app:AmoledPix
package:com.androholic.amoledpix
app:Weather
package:com.vivo.weather
app:Compass
package:com.vivo.compass
app:STOKiE PRO
package:com.harry.stokiepro
app:Pocket
package:com.ideashower.readitlater.pro
app:Swiggy
package:in.swiggy.android
app:Doodle
package:xyz.zedler.patrick.doodle
app:Fantasia Painter
package:com.datcompany.fantasiapainter
app:Pastel Wallpapers
package:com.arrow.wallpapers.pastelwall

Hello! Weʼre switching to a new system for icon requests in order to be able to better manage them. From now on, icon requests can be submitted here: https://forms.gle/Fx8vZAiWdW1Tyjo57. If your icon request hasnʼt yet been fulfiled, it has been copied to our new icon request database, meaning no action is required. Consequently, this issue will be closed.


Contribute to Xamarin.Forms

Hi, awesome checkbox!
Maybe you want to contribute to Xamarin.Forms:
https://github.com/xamarin/Xamarin.Forms/issues/1728

You can see https://github.com/enisn/Xamarin.Forms.InputKit for more ideas

I would love to submit this as PR. But from the conversations I've had with other developers and read online, it's the iOS that can be an issue. Since they don't have a native control, should we put one out till iOS gets a native control, should we bring it form MacOS, etc...
Someone mentioned that Xamarin.Forms may want to have such controls under a different namespace maybe to allow folks to have cross-platform controls without native offerings restrictions. meh.
I will submit a PR and see where that goes. Thank you.

I was going to use this control until I saw the skia dependency. That library is adding massive weight to the final app. I don´t think any xamarin.forms PR will be merged with skia as a dependency, right?

I don't think so. For the PR, I will be drawing using core APIs 🤓


Get beforeActors working

Issue type:

:heavy_plus_sign: Feature request

Description:
Namely for optimization rules

and re-introduce this generic
import type { IActorTest } from '@comunica/core';
import type { Rule } from '@comunica/reasoning-types';
import type { AsyncIterator } from 'asynciterator';
import type { IActionOptimizeRule, IActorOptimizeRuleArgs, IActorOptimizeRuleOutput } from './ActorOptimizeRule';
import { ActorOptimizeRule } from './ActorOptimizeRule';

export abstract class ActorOptimizeRuleTyped<R extends Rule = Rule> extends ActorOptimizeRule {
  public constructor(args: IActorOptimizeRuleArgs) {
    super(args);
  }

  // Abstract testRule(rules: AsyncIterator<Rule>): rules is AsyncIterator<Rule>;

  public abstract optimizeRule(rules: AsyncIterator<R>): AsyncIterator<R>;

  public async test(action: IActionOptimizeRule): Promise<IActorTest> {
    return true;
    // Return this.testRule(action.rules.clone());
  }

  public async run(action: IActionOptimizeRule): Promise<IActorOptimizeRuleOutput> {
    return { ...action, rules: this.optimizeRule(<AsyncIterator<R>> action.rules) };
  }
}


Tile Indicator - Save/Load Tiles

Would be cool if we were able to highlight tiles we choose. To be frank, only requesting this so I can use to to mark my MM2 path to get to maniacal monkeys. Nonetheless, I think being able to highlight tiles would be pretty nice and beneficial to other things, such as the inferno, marking NPC spawns yourself (hunting), marking where to place traps, marking safespots you find/currently using, etc.

I think @TheLonelyDev was working on something like this

Duplicate of #949


Standardize FindCommand logic

Currently, if we find by multiple keywords with the same field with find, CC will OR the predicates. However, when finding by different fields (name and tag for example), CC will AND both predicates.

Suspect this is due to the argMultiMap grouping keywords for the same field together, causing this difference (confirmed)

Proposed changes:

Enforce 1 keyword per field except for tag (keep the AND)
Get all contacts that fulfill any predicate (keep the OR)

Closed, we have decided to keep this functionality


[WIP] Dialtone V6 Component Tooltip Implementation

[WIP] Dialtone V6 Component Tooltip Implementation

:hammer_and_wrench: Type Of Change

[ ] Fix
[x] Feature
[x] Refactoring
[ ] Documentation

:book: Description

Updated tooltips component classes
Minor updates to documentation
:bulb: Context

To implement V6 Tooltips components
✏  Pull Request Checklist

[ ] Ask the contributors if a similar effort is already in process or has been solved.
[ ] Review the contribution guidelines.
[ ] Use staging as your pull request's base branch. (All PRs using production as its base branch will be declined).
[ ] Ensure all gulp scripts successfully compile.
[ ] Update, remove, or extend all affected documentation.
[ ] Provide a description what is being changed, extended, or removed.
[ ] Link to any issue(s) this request is resolving.
[ ] Ensure no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
[ ] Request a review from Drew Chandler, Joshua Hynes, or Ted Goas.

:crystal_ball: Next Steps

Update tooltips documentation
Scope work for tooltips Vue implementation
❌  Breaking Changes

d-tooltip and d-tooltip--inverted only contain component css vars
Must include d-tooltip__content on the tooltip body wrapper
d-tooltip__{DIRECTION_1}-{DIRECTION_2} is now d-tooltip__arrow--{DIRECTION_1}-{DIRECTION_2}

✅  Additions

d-tooltip--show and d-tooltip--hide can now be applied to the anchor element

📜  Example Usage
<template>
  <div class="`d-tooltip d-tooltip--{visibility}`">
    <slot />
    <div :class="`d-tooltip__content d-tooltip__arrow--{dir1}-{dir2}`">
      <slot #content>
        {{ message }}
      </slot>

</template>

@dialpad-drew @hynes-dialpad I was wondering if I could get a quick once over on the tooltips component class changes?

So I have a little problem with the pure CSS tooltip implementation which prevents us from using these styles in the actual product:

Showing the tooltip on :hover is not accessible.
Tooltips should be rendered at the root of the DOM and positioned to the target element (aka "teleport"). This is because the tooltip will be clipped to the bounding box if it's in a scroll container, and sometimes get resized to the parent element as noted here.
If there are many tooltips on the page they should lazy render only when needed.

IMO we should change the dialtone tooltip implementation to be visual styles only and implement the rest of the desired functionality in the Vue component. Currently we use the v-tooltip directive for this which is not very good.

Showing the tooltip on :hover is not accessible.

This is a good point. However, why wouldn't we just expose the Tooltip on :focus as well? This seems inline with how Heydon Pickering talks about it, and how Carbon does their Icon tooltip and Definition tooltip.

. However, why wouldn't we just expose the Tooltip on :focus as well?

Imagine the following scenario:

A button has a tooltip that shows on hover or focus.
You hover over the button and click on it.
You move the mouse away from the button.
The tooltip is stuck open until you click off the button because it's still focused.

I'm not aware of a pure CSS solution to this unless :focus-visible solves it.
Been a while since I looked into it, but I also think you'll need to update aria-hidden and aria-describedby on the tooltip and anchor elements respectively which requires JS anyway. Also in that Carbon example, the focus moves into the tooltip when it opens which would then close the tooltip with a pure CSS solution (that's really what we call a popover though).

So I have a little problem with the pure CSS tooltip implementation which prevents us from using these styles in the actual product:

Showing the tooltip on :hover is not accessible.
Tooltips should be rendered at the root of the DOM and positioned to the target element (aka "teleport"). This is because the tooltip will be clipped to the bounding box if it's in a scroll container, and sometimes get resized to the parent element as noted here.
If there are many tooltips on the page they should lazy render only when needed.

IMO we should change the dialtone tooltip implementation to be visual styles only and implement the rest of the desired functionality in the Vue component. Currently we use the v-tooltip directive for this which is not very good.

Good call, I have since removed the hover class just leaving the show and hide classes which can be used to toggle the tooltips visibility.

Any idea why some of these examples' widths are collapsing?

No idea currently, will investigate though

@dialpad-drew Is there a max width that you have in mind for the tooltips? or shall we remove the existing max width?
I would personally opt against defining a max width in the base component

. However, why wouldn't we just expose the Tooltip on :focus as well?

Imagine the following scenario:

A button has a tooltip that shows on hover or focus.
You hover over the button and click on it.
You move the mouse away from the button.
The tooltip is stuck open until you click off the button because it's still focused.

I'm not aware of a pure CSS solution to this unless :focus-visible solves it.
Been a while since I looked into it, but I also think you'll need to update aria-hidden and aria-describedby on the tooltip and anchor elements respectively which requires JS anyway. Also in that Carbon example, the focus moves into the tooltip when it opens which would then close the tooltip with a pure CSS solution (that's really what we call a popover though).

Ultimately, here are my concerns about pulling the functionality from the CSS component:

It doesn't work out of the box and we're documenting is essentially a static visual styles, does Tooltip still meet the criteria for being considered a true, first-class CSS component?
Who's responsible for updating all the Tooltip CSS implementations to Vue when we break them when updating projects to DT6? If it's us, then I wanna make sure we trap that as part of the implementation feature.

@dialpad-drew Is there a max width that you have in mind for the tooltips? or shall we remove the existing max width?
I would personally opt against defining a max width in the base component

Honestly, I have no opinion. I haven't really decomposed this component and, unless it's creating problems, would prefer the dimensions to mirror what's live today: https://dialpad.design/components/tooltips/

@dialpad-drew Is there a max width that you have in mind for the tooltips? or shall we remove the existing max width?
I would personally opt against defining a max width in the base component

Honestly, I have no opinion. I haven't really decomposed this component and, unless it's creating problems, would prefer the dimensions to mirror what's live today: https://dialpad.design/components/tooltips/

They weren't required and as such were removed

One issue that I had noticed, it seems that the tooltip is pushed outside of the div when it is not attached to an element like the previous implementation.

@ryandialpad luck of the draw with tooltips being the first component, but these updates broke the tooltips in the top nav.
Expected UI:

vs.
What's in this branch:

Tooltip positioning is now fixed

@ryandialpad luck of the draw with tooltips being the first component, but these updates broke the tooltips in the top nav.
Expected UI:

vs.
What's in this branch:

Since we changed the css implementation, whatever uses the tooltip in our docs site is now broken. Will address the issue tomorrow. We will need JS to control the visibility of the tooltip.

@dialpad-drew Completed updates to the header, let me know what you think

@dialpad-drew

It doesn't work out of the box and we're documenting is essentially a static visual styles, does Tooltip still meet the criteria for being considered a true, first-class CSS component?

The same could be said for modals, tabs, and probably lots of other components. The "true" implementation is really the vue component which implements these styles.

Who's responsible for updating all the Tooltip CSS implementations to Vue when we break them when updating projects to DT6? If it's us, then I wanna make sure we trap that as part of the implementation feature.

Ugh, yeah...there's plenty of places in the app that use the tooltip styles with the hover state. Is there any way to make those backwards compatible? Maybe an additional class to enable the old show-on-hover functionality?

Is there a max width that you have in mind for the tooltips? or shall we remove the existing max width?

Tooltips should have a max width as long as we could override it, which shouldn't ever really be necessary. Imagine all this text on one line:

@dialpad-drew

It doesn't work out of the box and we're documenting is essentially a static visual styles, does Tooltip still meet the criteria for being considered a true, first-class CSS component?

The same could be said for modals, tabs, and probably lots of other components. The "true" implementation is really the vue component which implements these styles.

Who's responsible for updating all the Tooltip CSS implementations to Vue when we break them when updating projects to DT6? If it's us, then I wanna make sure we trap that as part of the implementation feature.

Ugh, yeah...there's plenty of places in the app that use the tooltip styles with the hover state. Is there any way to make those backwards compatible? Maybe an additional class to enable the old show-on-hover functionality?

Is there a max width that you have in mind for the tooltips? or shall we remove the existing max width?

Tooltips should have a max width as long as we could override it, which shouldn't ever really be necessary. Imagine all this text on one line:

@dialpad-drew Thoughts on a max-width to initially set?
@dbecherdialpad I am good to add back the third visibility style that I had created d-tooltip--hover to make the migration a little easier for some teams

@dialpad-drew Thoughts on a max-width to initially set?

I say we keep it the same that it is now. Looking at 5.x, I believe it's max-width: 21.6rem

@dialpad-drew Thoughts on a max-width to initially set?

@ryandialpad I say we keep it the same that it is now. Looking at 5.x, I believe it's max-width: 21.6rem

@dialpad-drew Thoughts on having the content center aligned by default or just leave it up to the user?

@dialpad-drew @dbecherdialpad Added hover style back for now, component is now ready for review

@ryandialpad this looks great! Thanks for being so thorough. 🙌
I know I already approved this, but I'd like your opinion on one last thing: I know this component's CSS form isn't fully accessible (i.e. not visible on focus), but do you or @dbecherdialpad think it'd be worthwhile to at least include a voiceover readout on :focus? Maybe aria-describedby or something?

@ryandialpad this looks great! Thanks for being so thorough. 🙌
I know I already approved this, but I'd like your opinion on one last thing: I know this component's CSS form isn't fully accessible (i.e. not visible on focus), but do you or @dbecherdialpad think it'd be worthwhile to at least include a voiceover readout on :focus? Maybe aria-describedby or something?

@dialpad-drew Thanks! My intention is to make sure that we ideally don't miss anything when transitioning to V6 and to think about the components holistically (css implementation + vue implementation) :)
In terms of the Voiceover readout, 100% we will ensure that the Vue implementation is as accessibly as possible, making sure that there is a readout when the tooltip is visible / focused (I need to read up further on the guidelines for accessible tooltip components).

In terms of the Voiceover readout, 100% we will ensure that the Vue implementation is as accessibly as possible, making sure that there is a readout when the tooltip is visible / focused (I need to read up further on the guidelines for accessible tooltip components).

Makes sense for the Vue component, but what about the HTML component we're working on here? If we think it's going to be used in the product, shouldn't we also provide a reasonably accessible experience as well?

In terms of the Voiceover readout, 100% we will ensure that the Vue implementation is as accessibly as possible, making sure that there is a readout when the tooltip is visible / focused (I need to read up further on the guidelines for accessible tooltip components).

Makes sense for the Vue component, but what about the HTML component we're working on here? If we think it's going to be used in the product, shouldn't we also provide a reasonably accessible experience as well?

@dialpad-drew When we write the docs for this css component we can include accessibility considerations :)
For this PR we are focused on the CSS implementation. Dialtone doesn't include any html components currently but it does include usage examples and in the future, links to the Vue implementations.

In terms of the Voiceover readout, 100% we will ensure that the Vue implementation is as accessibly as possible, making sure that there is a readout when the tooltip is visible / focused (I need to read up further on the guidelines for accessible tooltip components).

Makes sense for the Vue component, but what about the HTML component we're working on here? If we think it's going to be used in the product, shouldn't we also provide a reasonably accessible experience as well?

@dialpad-drew When we write the docs for this css component we can include accessibility considerations :)
For this PR we are focused on the CSS implementation. Dialtone doesn't include any html components currently but it does include usage examples and in the future, links to the Vue implementations.

Gotcha. I created issue #203 for this component to remind us to revisit this (maybe after we do the Vue counterpart?). You're right in that we aren't offering "HTML components," but our examples should probably still show an accessible implementation.
Let's keep track of these as we go and revisit. :)


Update TutorialReact.md to use babel instead of react-tools

Given that react-tools is deprecated, and react is using babel. I've updated the docs to show how to use babel. This is essentially a copy of babel-jest's implementation

Hey @blainekasten,
how do you feel about changing this to recommend babel-jest and then explain how to customize the transform if necessary?

@cpojer Works for me

@cpojer How's that look?

thank you!


Store docker tags as build artifacts

Might be better to store them in a format like json or yml (probably json) - can do that in a future PR.  Could do this after converting the bash scripts to go.

Closes #4


Add simulation/mesh.py to Windows skiplist.

Until the crash can be fixed. See #5540.
Checklist:

[X] I have followed the style guidelines of this project.~~
[X] I have performed a self-review of my own code.~~
- [ ] I have commented my code where applicable.
- [ ] I have updated the release notes.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added debugging support to my changes.
- [ ] I have added tests that prove my fix is effective or that my feature works.
- [ ] I have confirmed new and existing unit tests pass locally with my changes.
- [ ] I have added any new baselines to the repo.
- [ ] I have NOT made any changes to protocol or public interfaces in an RC branch.
[X] I have assigned reviewers (see VisIt's PR procedures for more information).~~

@brugger, please re-review. Changed to having the test in the skiplist for all platforms as it is crashing and yielding invalid results. See my comments in #5540.


Update dependency projectcalico/calico to v3.24.3

This PR contains the following updates:

Package
Update
Change

projectcalico/calico
patch
v3.24.1 -> v3.24.3

⚠ Dependency Lookup Warnings ⚠
Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.

Release Notes

projectcalico/calico
v3.24.3
Compare Source
Release notes can be found on GitHub
Attached to this release are the following artifacts:

release-v3.24.3.tgz: container images, binaries, and kubernetes manifests.
calico-windows-v3.24.3.zip: Calico for Windows.
tigera-operator-v3.24.3.tgz: Calico Helm v3 chart.

v3.24.2
Compare Source
Release notes can be found on GitHub
Attached to this release are the following artifacts:

release-v3.24.2.tgz: container images, binaries, and kubernetes manifests.
calico-windows-v3.24.2.zip: Calico for Windows.
tigera-operator-v3.24.2.tgz: Calico Helm v3 chart.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will now ignore this update (v3.24.3). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


SmartRedis Release v0.3.1

SmartRedis Release v0.3.0
See www.craylabs.org/docs/changelog.html for details.

Codecov Report

Merging #266 (55019e7) into master (e14ecef) will decrease coverage by 2.28%.
The diff coverage is 71.39%.

:exclamation: Current head 55019e7 differs from pull request most recent head 693daa0. Consider uploading reports for the commit 693daa0 to get more accurate results

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   82.45%   80.16%   -2.29%
==========================================
  Files          50       55       +5
  Lines        2838     3443     +605
==========================================
+ Hits         2340     2760     +420
- Misses        498      683     +185

Impacted Files
Coverage Δ

include/client.h
100.00% <ø> (ø)

include/commandlist.h
100.00% <ø> (ø)

include/commandreply.h
100.00% <ø> (ø)

include/redisserver.h
0.00% <0.00%> (-100.00%)
:arrow_down:

include/srexception.h
20.58% <0.00%> (-3.55%)
:arrow_down:

include/tensor.h
100.00% <ø> (ø)

include/tensor.tcc
54.78% <ø> (+3.19%)
:arrow_up:

src/cpp/addressallcommand.cpp
0.00% <0.00%> (ø)

src/cpp/command.cpp
77.34% <16.00%> (-15.87%)
:arrow_down:

include/pipelinereply.h
33.33% <33.33%> (ø)

... and 20 more


cmd +k no longer clears the terminal

When the zeplin extension is enabled the default keybinding cmd + k to clear the focused terminal doesn't work.

I wasn't aware of this command. Thanks. It is now fixed. It will be live on the next release

👍


Javascript Code Format Indentation not always correct

From @zevero on May 13, 2016 8:28

VSCode Version: 1.1.0
OS Version: Debian Stretch

There is a glitch of the (otherwise very perfect) Javascript Code Format:
Steps to Reproduce:
0. (Set "editor.tabSize": 2 for using 2 spaces as indentation)

save this as a .js file

    var series = [{
      name: 'One',
      data: []
    }, {
        name: 'Two',
        data: []
      }, {
        name: 'Three',
        data: []
      }
    ];

Press Ctrl+Shift+i to format code
The Object named One will not get indented correctly.
Indent it manually, so it is aligned with Two and Three.
Press Ctrl+Shift+i
Object One is misaligned again.

It does not understand how to format an object in this way (used in highcharts for example)
It works however if the first '{' is written in an extra line (which I do not like).
I may sound picky, but this is the first code formatter, that I actually use extensively and so I really care! It formats nicely without interfering too much!
Thank you!
Copied from original issue: Microsoft/vscode#6336

Moving to TS since we format JS using the TS formatter.

It works however if the first '{' is written in an extra line (which I do not like).

Just wanted to attach a visual with the formatting that does work (as you mentioned) :rose:
var series = [
  {
    name: 'One',
    data: []
  }, {
    name: 'Two',
    data: []
  }, {
    name: 'Three',
    data: []
  }
];

👍

should be fixed by https://github.com/Microsoft/TypeScript/pull/8364


Creating an Alert-driven SLO fails

Description
Trying to create an alert-driven SLO based upon Capacity.

Should be addressed with rel 1.4.6


Remove AppsAndFeaturesEntries from HydrusNetwork.HydrusNetwork v522

Microsoft Reviewers: Open in CodeFlow

URL:
Invalid URI: The hostname could not be parsed.
(Automated message - build 891)


Experimental variables list causes CTDs frequently

Software version
0.7.0
Flight Simulator installation type
Windows Store
Problem
As of Sim Update 9, the experimental variables list is causing CTDs in MSFS very easily.
How to reproduce the problem
Scroll down through the A: variables list. After a few seconds MSFS will CTD.

Scrolling through the list was bulletproof before SU9.  Now MSFS crashes very easily. It looks like MSFS simply blows up when you subscribe to lots of individual variables. We only subscribe to about 60 at any one time, but when it crashes we have subscribed to and from about 650.
Removing the ClearDefinition code doesn't help. Simply calling RequestDataOnSimObject enough times seems to crash MSFS. :(

This was obviously an issue in MSFS itself. With the latest post-SU9 patch released today, the variables list is stable again.


[move] Lex Move IR source buffers in-place

Rather than copy the source file into a string with its comments removed, skip over the comments while advancing the lexer.
Also, the lexer now verifies the source character set as it goes. Instead of iterating over each character before lexing and checking that it is part of the valid set, the lexer's default match arm for ParseError::InvalidToken catches any characters not explicitly accounted for.
The combination of these two changes means that commented-out Move IR may contain any characters, including emoji and bidirectional text. This isn't necessarily a "feature" -- the code is just less complex and more performant this way, and the lexer ought not care about commented-out text anyway.
Submitted on top of #8845 and #8860, in case you'd like to review those first.

/land


undo changes to NuGet.config from PR#887

Revert NuGet.config change as it introduced a break into end to end builds that wasn't caught by PR validations.

Manually merging this, because this is broken across repos and the end-to-end checks will be blocking each other.


Allow treating ratios as floats

Adds:

conversion from ratio to float
multiplication of ratios
division of float or int with ratio

Examples:
float(40%) = 0.4

50% * 30% = 15%

1 / 40% = 2.5

Resolves #651, resolves #652

If 1 * 40% and 1 / 40% both work, then I would expect 1cm * 40% and 1cm / 40% to work, too. So the result of both multiplication and division is always the left type. Same with 100% * 40%. But 100% / 40% does not return a ratio, it returns a float. This breaks consistency. Since I also thought that the divisions are a bit unintuitive, I removed support for them for now, but we can revisit this.


CometLogger can modify logged metrics in-place

When logger.log_metrics(metrics) is called with a CometLogger, metrics may be modified in-place. This can lead to confusing errors. E.g. if the user does
def training_step(self, batch, batch_idx):
    losses = self._get_losses(batch)
    self.logger.log_metrics(losses)
    return losses

then losses will have all the tensors moved to the CPU and their gradients detached, leading to an error like RuntimeError: element 0 of tensors does not require grad and does not have a grad_fn when backprop is attempted.
None of the other loggers change metrics in-place when log_metrics is called. All of them except neptune say that they just accept metrics: Dict[str, float], though some others (e.g. the tensorboard logger) have code to handle torch.Tensors or other types as well.
The CSVLogger uses the following for handling tensors:
def _handle_value(value):
    if isinstance(value, torch.Tensor):
        return value.item()
    return value
...
metrics = {k: _handle_value(v) for k, v in metrics_dict.items()}

The TensorBoardLogger similarly has
for k, v in metrics.items():
    if isinstance(v, torch.Tensor):
        v = v.item()
    ...
    self.experiment.add_scalar(k, v, step)

In the CometLogger, the current tensor conversion code is
for key, val in metrics.items():
  if is_tensor(val):
    metrics[key] = val.cpu().detach()

but then the entire metrics dictionary is copied later in the function anyway, so it doesn't really make sense to do in-place modification then copy everything.
I'm happy to submit a PR to fix this so that the CometLogger doesn't modify the original metrics dictionary. I just wanted to ask for a couple of opinions before changing things:

Should I keep the current tensor conversion behavior for CometLogger (val.cpu().detach()) or switch to using val.item()? My preference would be the latter, though this does change the behavior (see at the end).
Should I update the other loggers to all accept metrics: Dict[str, Union[float, torch.Tensor]] and have them all use the same method (probably imported from loggers/base.py) to convert to a Dict[str, float]?

I don't know the other loggers, so I'm not sure if tensors are actually not supported or if the type annotation isn't precise and the conversion is happening in third-party code

val.cpu().detach() vs val.item()

Comet sort of has support for tensors with >1 element, so using the first method will make logging such tensors valid while the second method would throw an error. However, I don't think anybody would be using this behavior on purpose. If you do logger.log_metrics({"test": torch.tensor([1.0, 10.0])}), you get COMET WARNING: Cannot safely convert array([ 1., 10.], dtype=float32) object to a scalar value, using its string representation for logging. The metric itself doesn't even appear in the web interface for CometML, so I assume you can only access it if you query for it directly through their API.

PR on this is more than welcome! Great observation. Btw I believe we don't expect users to directly call self.logger.log_metrics, but we should still fix it :)

val.cpu().detach() vs val.item()

Does Comet accept scalar tensors? If it can do the tensor->Python conversion, I would go with val.cpu().detach() as in the other loggers.

@neighthan still interested to send a fix for this?

Hi @tchaton,
Can you please review my PR. There are a few checks that failed and I am unable to determine the exact cause for the same.
Sincerely,
Soham

Hey @ sohamtiwari3120,
Approved. Mind adding a test to prevent regression ?
Best,
T.C

Hi @tchaton
I would love to try! However, it would be my first time writing tests. Therefore could you please help me with the following:

can you explain how will the test to prevent regression look like,
also could you provide any references useful for beginners in writing tests.

Sincerely,
Soham

Dear @sohamtiwari3120,
Check out this document: https://github.com/PyTorchLightning/pytorch-lightning/blob/master/.github/CONTRIBUTING.md
In this case, the test should ensure the values aren't modified the logged metrics owned by the trainer.
Best,
T.C


Dupe detection - Distance rate is editable on the confirmation page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.17-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to workspace chat.
Submit two same distance expenses.
Go to transaction thread of any submitted expense.
Click Review duplicates.
Click Keep this one (any).
Proceed to confirmation page.
Click Rate.

Expected Result:
Distance rate should not be editable on the confirmation page (like other fields).
Actual Result:
Distance rate is editable on the confirmation page.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/20efdbcb-969a-495e-a47c-8d2eed7028f0

View all open jobs on GitHub

We think that this bug might be related to #wave-collect - Release 2

Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance rate is editable on the confirmation page
What is the root cause of that problem?
In MoneyRequest view we are only checking canEditDistanceRate prop before we are making the button interactive and displaying right icon
https://github.com/Expensify/App/blob/2c60fc937881a77062f0e07a405fa0380cc847b3/src/components/ReportActionItem/MoneyRequestView.tsx#L349-L353
What changes do you think we should make in order to solve the problem?
We should check for readonly prop too
interactive={canEditDistanceRate && !readonly}
shouldShowRightIcon={canEditDistanceRate && !readonly}

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance rate is editable on the confirmation page
What is the root cause of that problem?
In MoneyRequestview we are only checking canEditDistanceRate prop before we are making the button interactive and displaying right icon
https://github.com/Expensify/App/blob/2c60fc937881a77062f0e07a405fa0380cc847b3/src/components/ReportActionItem/MoneyRequestView.tsx#L349-L353
What changes do you think we should make in order to solve the problem?
We should check for readonly prop too
interactive={canEditDistanceRate && !readonly}
shouldShowRightIcon={canEditDistanceRate && !readonly}

What alternative solutions did you explore? (Optional)

I can raise a quick PR if needed.

@pecanoro dupe detection is behind a beta, this isn't a deploy blocker right?

Yes, removing the blocker

This one is also pretty easy so I am going to change the initial price to $125

Perf, thanks!

Adding External to get a C+ assigned to review https://github.com/Expensify/App/issues/46954#issuecomment-2273158439.

Rocio is on vacation until next week - she'll review once she's back.

Just came back today, thank you for waiting! Assigning @dominictb to the issue

Summarizing payment on this issue:
Contributor: @dominictb $125, paid via Upwork
Contributor+: @ishpaul777 $125, paid via Upwork
@ishpaul777 do we need regression steps or are we good as is?

Friendly bump @ishpaul777 I think we may need a regression test for this one.

Looks great, thanks!


OpenAPI v3 support

Hi there!
Do you have a plans to support v3 format specs?
Regards,
Serhii

Hi, there are no plans.
Now only support swagger1.X & swagger2.X

+1 for Swagger 3.x
Would like to use it in a corporate setting, but we need Swagger 3 support as well.

For anyone interested in finding differences in OpenApi 3 files, give openapi-diff a go. It's a tool my team has built that can be used as a cli or via nodejs that uses an approach based on set theory to accurately find differences between two OpenApi3 or Swagger 2 specifications, including inside request and response body schemas.

You can also take a look at the following alternative to OpenApi 3:
https://github.com/OpenAPITools/openapi-diff
https://github.com/Azure/openapi-diff


Add description of way to reset forgotten password into FAQs

Add descriptions of the simple way to reset forgotten administrator password
using shell access to server and command line interface.
There's no need to use low-level "SQL magic" or any other dirty tricks to do this.
I've accidentally faced with such problem myself and I was very happy when solved
it without "black magic" and any data loss.
So I wanted to write about it to the place where it's easy to find it (i.e FAQs).
I guess, I'm not the only one who faced with such problem.

Thank you!


[BEAM-9721]Conditionally add Dataflow region to Dataflow-based load tests and performance tests

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Run Java MongoDBIO Performance Test

Run Java MongoDBIO Performance Test

CommunityMetrics failure is irrelevant.

Looks good!

Thanks, merging.


IONIC 2 and Angular 2 have been released

Hi, thank you for this project. I followed the steps carefully but when I try to see the graph page I get a configuration error: "Check if the port is for websocket!"
Which it is. I even tried all the ports listed. Do you know what could be wrong?

But more importantly - will you be upgrading this project to IONIC 2 with Angular 2?
thanks,
Dev

Sorry Dev, I am yet to learn Ionic 2. I think, I also got this error, but don't remember how i solved it. Please refer stackoverflow.

Has a solution ?I have the same problem.

hi dev
I found this solution:
Link MQTT Server:  https://customer.cloudmqtt.com
Goto :Cloud MQTT server login with your credential and click the instance
look like:
click Restart .
problem shortout :)
( or you can create new instance and pass credential in your app setting page )

Thank you arjun sir you great , awesome post unbeatable :)

Thank you, I will give it a try.
On Tue, Nov 28, 2017 at 5:16 AM, Pratibha<EMAIL_ADDRESS>wrote:

hi dev
I found this solution:
Link MQTT Server: https://customer.cloudmqtt.com
Goto :Cloud MQTT server login with your credential and click the instance
look like:
click Restart .
problem shortout :)
( or you can create new instance and pass credential in your app setting
page )
[image: mqtt]
https://user-images.githubusercontent.com/33420530/33314136-b76b041e-d452-11e7-812b-a6e21bf03675.png
Thank you arjun sir you great , awesome post unbeatable :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/arjunsk/Ionic-IOT-Monitor/issues/2#issuecomment-347476630,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYnLrFpgmKTbU_Lj0_enyEQ66JNALMoxks5s691fgaJpZM4MCfqu
.


docs: update bazel readme for clang-format-8 on mac

Signed-off-by: Derek Schaller<EMAIL_ADDRESS>For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: update bazel README to use clang-format from homebrew on mac
Risk Level: Low
Testing: Tested this configuration on my local machine
Docs Changes: N/A
Release Notes: N/A

@dschaller sorry needs master merge.
/wait


Leave meeting key combination doesn't work in calls with multiple people

I'll get straight to the point:
When in a meeting with 1 person, using CTRL-SHIFT-B does what it should: it leaves the meeting.
However, when in a meeting with multiple people, CTRL-SHIFT-B selects the pane of one of the people in the meeting and does NOT leave the meeting.
This bug should be easily reproduceable by joining aforementioned meetings.
I am using Microsoft Teams Version <IP_ADDRESS>064 (64 bit), which was last updated on 08/10/2020.
With kind regards,
Andreas

@Andreas02-dev,
For issues related to teams product, please reach out to the Product support channels.


Passwords Manager Tab

Version 116.0.1938.54 (Official build) (64-bit), I identified a bug in the saved passwords tab, when selecting a saved password the "Delete" option within "More Actions" (...) does not work, nothing reacts.
It is only possible to delete using the top button "Delete."
In short: "Delete" option inside (...) "More Actions" is there, but it doesn't work.
https://github.com/MicrosoftDocs/Edge-Enterprise/assets/143081292/7e5dc338-c1c2-407f-8089-693b062a16ea

@thiagocirqueira Thanks for the feedback.  This is a known issue.  Currently no ETA for the fix but I will pass this on to the team.


v1.2.1

Text import area font style changed from regular to monotype

PR for CI/CD test completed


Update slides content and structure

Also adds placeholders for missing images (for #20 and others)
Includes "further reading" slide (#25)

Added figures and screenshots


New blog posts

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.923%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
220

Relevant Lines:
286

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.923%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
220

Relevant Lines:
286

💛  - Coveralls