Background Design Does Not Align with Retro Theme

Is there an existing issue for this?

[X] I have searched the existing issues

Issue Description
The current background design, featuring trees and a starry sky, doesn't align with the restaurant's branding or theme. The visual style appears more nature-focused, which may not resonate with the dining experience the restaurant is trying to offer. A restaurant's website should evoke its ambiance, whether it's cozy, elegant, modern, or themed around specific cuisine or culture.

Suggested Change
Replace the current background with imagery that matches the restaurant’s vibe. Some options could include:
Elegant textures like wood, stone, or fabric for a fine dining experience.
Photos of the restaurant’s interior, signature dishes, or a warm dining ambiance.
A color palette that complements the restaurant’s branding and creates a welcoming atmosphere.
Rationale
The suggested change to the background is important because the visual design of a restaurant’s website plays a key role in setting the tone for potential customers. A website is often the first point of interaction between the customer and the restaurant, so the design should communicate the restaurant's brand, ambiance, and dining experience effectively.
Urgency
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24EXTD contributor
[X] I have starred the repository

@PremaDongare what is the design i like to add then?

As this is a restront webpage so the background does not aligne with this
.If any uneducated person view this website so thy didn't get to know that
this ia a website of restront beacuse of it's background . We have to add
some best background related to restront .
Please assign this task to me I'll do that
On Tue, Oct 8, 2024, 7:49 AM Lakshmi Pavananjali @.***>
wrote:

@PremaDongare https://github.com/PremaDongare what is the design i like
to add then?
—
Reply to this email directly, view it on GitHub
https://github.com/Anjaliavv51/Retro/issues/296#issuecomment-2398528705,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BFVEHDSOXV7DP4IX364PBGLZ2M6MTAVCNFSM6AAAAABPOSFZJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJYGUZDQNZQGU
.
You are receiving this because you were mentioned.Message ID:
@.***>


Error on Issue-Events

Gitea version (or commit ref): 1.1.0
Operating system: Windows
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Description
There are some html-structure-errors, when editing an issue, see screenshot.
...
Screenshots

This has been reported by #1174 and resolved by #1177

@lunny Thanks! Are there plans to release a bugfix 1.1.x-release? if (true) -> any time schedule?

Yes. 1.1.1 will be released soon, just these days.


ZeroClipboard.swf is not downloaded in Internet Explorer

sorry, didn't have flash installed on my windows machine.


Determining the Steinhardt bond order parameters inside a spherical shell.

The Pyscal code is already capable of carrying out the calculation of Steinhardt BOPs inside a sphere which is defined by a cutoff radius.
Currently, one of the methods to determine the neighbors in Pyscal is to use the method keyword 'cutoff'. By this method, all the neighbors inside the defined cutoff distance are calculated. It would be helpful if the code was able to take a cutoff distance and a shell thickness. This way the neighbors can only be calculated inside the shell thickness. This addition could be helpful for researchers working with particulate materials.
The figure below could help in explaining my request further.
Thank you.

This is now added in version 3.2.1. Pypi and conda releases will be available in a short file. Thanks for the suggestion!


feat(azure): add additional images

What problem does this PR solve?:
Adds additional platforms for azure.
Which issue(s) does this PR fix?:

https://jira.d2iq.com/browse/D2IQ-85256

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Testing of these images still TBD, but wanted to get a draft up with the Offer / SKUs.

All of these images have now been validated to produce an image.


Added support for multiple SQL Database CreateModes (including geo-replication) and other extension methods

Progression with SQL Database
Database-based geo-location works through the extension method SetAsSecondary. It sets the database to be a geo-replica of a primary db (of which the id is passed into the SetAsSecondary method)
Added more CreateMode options:

to Restore a deleted db - use SetAsRestore()
to "restore a geo-replication of backup" - use SetAsRecovery() (see Link)
to copy a db - use SetAsCopy()
to restore a database from long term retention - use SetAsLongTermRetentionRestore()
to restore from a point in time backup - use SetAsPointInTimeRestore()
to set the db as a geo-replica backup (secondary) - use SetAsSecondary()

Added more ext methods:

SecondaryType() -> not entirely sure what this is, but the default value is 'geo' (geo-replication)
EnableZoneRedundancy() -> by default Zone Redundancy is disabled, so I made an option to enable it
MaxDatabaseSizeGB() -> set the database size in GB with an integer (method converts to bytes and inserts into resource argument 'MaxDatabaseSizeBytes')
MinCapacity() -> I've not figured out what this does yet.
StorageAccountType -> Takes StorageAccountType struct as an argument (valid values: GRS, LRS, ZRS)
DatabaseCollation() -> Set the collation of the database
SampleData() -> to insert sample data into the database

Added corresponding unit test methods to test most of the new extension methods (some can't be unit tested).
Most new extension methods have been tested through deployment using 'pulumi up'.

I've updated method names and I have added support for the user to generate a new SQL server to host the new SQL DB (to solve the second part to the issue you raised @sesispla ).


⚠ Bofrost.at has degraded performance

In 352956c, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 811 ms

Resolved: Bofrost.at performance has improved in d1858e3.


"Reverse convert" (Convert existing JSON template into cfndsl Ruby)?

(Preface: I tried searching for any existing issues on this topic but couldn't find any)
I'm evaluating using either cfndsl or https://github.com/bazaarvoice/cloudformation-ruby-dsl and while I like cfndsl's syntax better, the fact that cloudformation-ruby-dsl has two-way conversion is very attractive. Are there any plans to support reverse conversion (however primitive) here?

Hi @suan,
That's a good question. I haven't seen anyone ask for it.  I know a few colleagues and friends have used (and wrote) cfn2dsl.  This might meet your needs.
I personally have found that it was a great opportunity to revisit our templates and make them smarter (using external parameters for example) and actually reduce the number of templates we had.
Let us know how you get on. Happy to help any way we can and always happy to accept pull requests.

Looks like cfn2dsl while could be improved, definitely works as a reverse converter, thanks for pointing that out!


Add typings, markdown lint, tape to tap

Add typings
Switch tape to tap
Remove coveralls as it doesn't work.
Update README.md
Add markdown lint
Update .gitignore

LGTM


Support :counter type being returned as an INT

I think :counter seems to work exactly like an int from a driver point of view.
I have a working branch, I'll add a test or two in a bit, to at least check if incrementing and decrementing an existing value works.
https://github.com/aphillipo/xandra/tree/fix-counter-fail-3.x

Duplicate of #95


Update SPMT PowerShell help documents

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: wenhua-helen sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

spmt/spmt-ps/spmt/Add-SPMTTask.md
:white_check_mark:Succeeded
View (spmt-ps)

spmt/spmt-ps/spmt/Get-SPMTMigration.md
:white_check_mark:Succeeded
View (spmt-ps)

spmt/spmt-ps/spmt/Register-SPMTMigration.md
:white_check_mark:Succeeded
View (spmt-ps)

spmt/spmt-ps/spmt/Remove-SPMTTask.md
:white_check_mark:Succeeded
View (spmt-ps)

spmt/spmt-ps/spmt/Show-SPMTMigration.md
:white_check_mark:Succeeded
View (spmt-ps)

spmt/spmt-ps/spmt/Start-SPMTMigration.md
:white_check_mark:Succeeded
View (spmt-ps)

spmt/spmt-ps/spmt/Stop-SPMTMigration.md
:white_check_mark:Succeeded
View (spmt-ps)

spmt/spmt-ps/spmt/Unregister-SPMTMigration.md
:white_check_mark:Succeeded
View (spmt-ps)

spmt/spmt-ps/spmt/spmt.md
:white_check_mark:Succeeded
View (spmt-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


In-memory cache fix for Collection

I see that the CMS maintains an in-memory cache for Documents but I think there is a bug with maintaining it for Collections. I think the intention was to also maintain in-memory cache for Collections.
Document in-memory cache works from here.
This PR contains a fix for the Collection in-memory cache.
Additionally
What do you think about providing a CMS configuration that toggles in-memory cache? It seems like a nice feature provide some control over. I'd like to disable in-memory cache and use the fetch the item from storage each time.

Hmmm. I think this in-memory cache was created initially, but I think it's a bad idea because there's no way to invalidate it, which may cause issues if the document content was changed outside the CMS.
I think this cache should be removed.
Maybe, if something similar is implemented in the future, it should be in the storage, but for now I rather to don't cache anything.

Good call just removing it entirely. I'll change this PR to strip out the cache.

Good catch!! 🧠

thanks!


ElasticSearch indexes automatically deleted after sometime(index_not_found_exception)

Current behavior
We have migrated magento2 data using Mage2vs command but indexes get deleted automatically after 24-48 hrs from elastic search.
"code": 500,
"result": {
"root_cause": [
{
"type": "index_not_found_exception",
"reason": "no such index",
"resource.type": "index_or_alias",
"resource.id": "vue_storefront_catalog",
"index_uuid": "na",
"index": "vue_storefront_catalog"
}
],
"type": "index_not_found_exception",
"reason": "no such index",
"resource.type": "index_or_alias",
"resource.id": "vue_storefront_catalog",
"index_uuid": "na",
"index": "vue_storefront_catalog"
}
Expected behavior
Elastic index should persist.
Steps to reproduce the issue
Setup new instance on google cloud and migrate data from magento2, elastic search index are deleted after 24-48 hrs without any deployment, elastic docker container still running but indexes are deleted for product, category and attributes.
Version of Vue Storefront
"version": "1.12.3"
Can you handle fixing this bug by yourself?
No
Environment details

Browser: latest
OS: Mac
Node: 10.x
Code Version: 1.12.3

Additional information
We have to delete container again and migrate data then its working fir again its deleted after 24-48 hrs.

make sure your ElasticSearch is not accessible publicly or is behind password.
you can check also what databases exist in Elastic and if you see there "meow" named ones then it might be bot removing those

https://www.itnews.com.au/news/new-meow-bot-attacks-open-elasticsearch-instances-550735

do you think this issue is because of virtual memory allocated to container?


Come up with a best practices doc for creating analyzers

Seems a little weird to have the rule name have a space. Are there any recommended (or required) constraints for rule names?

Originally posted by @twsouthwick in https://github.com/dotnet/upgrade-assistant/pull/939#discussion_r751539216
Things like names/categories/rules/etc should have a well-defined meaning and constraints.

From @eddynaka

Here you can also find some guidance that we created:
https://github.com/microsoft/sarif-tutorials/blob/main/docs/Authoring-rule-metadata-and-result-messages.md#human-readable-identifier

We may want to just link to these. Are there any analyzers for this to ensure stability/etc (kind of like the roslyn diagnostic analyzers?)


Hot exit: preserve files explorer state

VSCode preserves list of open files, but it does not preserve files explorer state (collapsed folders).

It preserves it for me.
I can not reproduce. Can you reproduce using Visual Studio Code Insiders https://code.visualstudio.com/insiders/

@isidorn will try later. Could you try to reproduce it while using Remote Container (docker)?

Try later with insiders and let me know how it goes.

Try later with insiders and let me know how it goes.

Wow, it saves the state in Insiders version. Waiting for this to be merged to main branch.

There might be some extension which is breaking your flow. However since this works in insiders I am closing this issue


Allow Scenes to have arbitrary base type/ independent of KinematicTree's base type

This fixes #105 and also exposes getBaseType for both KinematicTree and Scene as well as getGroupName for Scene.

Merging as this fixed several issues and introduced a correct treatment of the floating base. A follow up PR #109 cleans up the code and moves the logic to KinematicTree as discussed as well as fixes a further bug in the treatment of joint limits for floating base robots with joint groups that do not include the floating base.


Bolt apply does not preserve symlinks in source directories

Describe the Bug
Given a file resource with recurse true and a directory as the source:
file { /home/butter:
    ensure       => present,
    source       => "puppet:///modules/users/home/butter}/",
    recurse      => 'remote',
    mode         => '0644',
    owner        => 'butter',
    group        => 'butter',
    force        => true,
}

$ cd /home/butter
$ tree
.
├── foo -> bar
└── bar

Bolt fails to preserve the symlink, which generates the following erroneous change:
Notice: /Stage[main]/User[butter]/File[/home/butter/foo]/ensure: current_value 'link', should be 'file' (noop)

Expected Behavior
symlink is preserved, resulting in no changes

My guess is that when we tar up the module's files for the apply we loose the symlink https://github.com/puppetlabs/bolt/blob/f76f7444a1fbf44da413062e4a8e9102ccced66a/lib/bolt/applicator.rb#L341 \using Minitar. A quick glance through that library does not yield and obvious way to actually preserve the symlink when building the tar archive. If it is the case that this is the cause of this issue and that it is not an existing feature in minitar someone would probably have to land that feature in the minitar project for us to be able to make this work in bolt.

@op-ct Apologies for the delay. I should be able to merge the symlink support and release a new version by the new year.


Remove version: OpenJS.NodeJS.LTS version 14.16.1

Replaced by another Pull Request
Microsoft Reviewers: Open in CodeFlow

https://www.github.com/microsoft/winget-pkgs/pull/143386#issuecomment-1986949152 [Policy] Needs-Author-Feedback

Close with reason: See discussion in above linked issue;


usm: Fix ProcessMonitorEventStream option in nodeJS monitor

What does this PR do?
Syncs the EnableUSMEventStream option in the nodeJS monitor.
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


Not working on iOS/iPadOS?

Thank you for the great library. I incorporated the upload functionality into my web app, and it works great in browser on a laptop (macOS), but it seemingly doesn't work on iOS/iPadOS. On my iPhone/iPad the upload function doesn't bring up any file selection dialog, and the handler callback is never called.
Is this a known issue, or am I perhaps not using the library properly?
I don't know enough about emscripten to debug/fix this myself, but with guidance am happy to provide more details.
Thanks again.

Please re-open this issue if it isn't resolved by @AnatoliyProjects' fix above.


FG shall support last changed mark in edited files

A CVS like tag $Changed:$  shall be supported by FG that will be refreshed with current date and time on each editing of the file

Done


Fixing #158 and #204

#158
#204
I actually didn't fix these bugs, I just thought I did.
Apparently
\cc @irvingpop @dblessing @jkeiser

Awesome. Thanks @tyler-ball

:+1:  this resolves the "leaky instances" issue for me

Before:
[2015-05-28T10:53:18-04:00] ERROR: aws_launch_configuration[peterb-sensu-client] (@recipe_files::/Users/pburkholder/Projects/pburkholder/conjur_demo/cookbooks/sensu_client/recipes/aws.rb line 94) had an error: NoMethodError: undefined method `aws_tags' for Chef::Resource::AwsLaunchConfiguration

After:
:dancers:


REFACTOR: paid flag -> PaymentResult object

This PR is to deprecate the paid flag in PaymentResponse and PaymentStatus in favor of a more structured PaymentResult, that allows for more flexibility.
I have modified the backends to fill in this new field. The main difference is we DO NOT return SETTLED when paying an invoice unless we get an explicit confirmation, instead we return PENDING and then melt notices this and checks the payment status.
I have also adapted the code in get_mint_quote and melt to rely on the newly added result field.

I am having trouble with LNBits.
The code for get_invoice_status reads a response field paid that isn't event mentioned in the docs (https://demo.lnbits.com/docs#/Payments/Payment_List_api_v1_payments_get)

This will be used to fix #614

I think this is not needed anymore.


Bundle is an abomination

The bundle emitted by Deno is an abomination.

[ ] Filled with garbage.

What in the world is this and why does it exist? The variables aren't even used.

const Zone1 = Zone;
const MeshPyramid1 = MeshPyramid;
const Base1 = Base;
const MeshBox1 = MeshBox;
const World1 = World;

[ ] Renames things it shouldn't.

bzw into mod, which has to be manually overwritten.

[ ] Modules lose their scope.

Such as dom and highlight.

Right now the bundle must be manually edited by the build script: build.ts#L34-L44
Possibly related: swc-project/swc#1349

Updating to Deno v1.8.3 has mostly fixed the issue, however it is still partially there.
https://github.com/BZFlagCommunity/webbzw/blob/f12e5c926f5d24ff51d145da2d51b13970c0366a/build.ts#L39


az webapp deployment source config command fails when trying to add an external repository using a url that isn't one of certain hostnames

From @gabesmsft on February 8, 2019 18:26
From @gabesmsft on February 8, 2019 4:22
If I try to use the Azure CLI command az webapp deployment source config to add an external repository using a url that doesn't use a hostname such as GitHub.com, Bitbucket.org, dev.azure.com (or technically onedrive.com or dropbox.com), it fails with error indicating that the repo-url has an invalid value.
For example, I am trying to add a GitLab external repository via the following command:
az webapp deployment source config --repo-url https://gitlab.com/myfakeaccount/myfakeproj.git --branch master --repository-type externalgit --name myfakeappservice --resource-group myresourcegroup --subscription myfakesubid
This fails with the following error:
The parameter https://gitlab.com/myfakeaccount/myfakeproj.git has an invalid value.
If I add the external repository using the same url via the portal, it succeeds. So it would seem that adding the url via CLI should be allowed, but is presumably failing because CLI validates against a list of specific repo hostnames.
If I then use the cli to get the repository info, it returns the repoUrl as expected. Eg:
az webapp deployment source show --name myfakeappservice --resource-group myresourcegroup --subscription myfakesubid
So the issue appears to be specific just to adding the repoUrl.
Copied from original issue: Azure/azure-functions-core-tools#1028
Copied from original issue: gabesmsft/fakeplaceholder#1

From @ankitkumarr on February 8, 2019 17:59
Hi @gabesmsft, this is the repository for Azure Functions CLI for local development (func). For Azure CLI (az) (Azure management operations), please move the issue to the Azure CLI repository.
Thanks!

For external repo, Kudu will need to be able to do git fetch from that.   There are 2 scenarios we support.

External repo is https to any publicly-accessible git repo.   If it is not, Kudu will not be able to fetch it – it will fail nonetheless.
External repo is ssh which user has set up private SSH key with Kudu (see https://github.com/projectkudu/kudu/wiki/Continuous-deployment#for-private-repos-set-up-a-deploy-key).

In this case, you are using https - so make sure your repo is valid and publicly accessible.

The invalid value error reproduces when using a public repository via https. Eg: https://gitlab.com/gabes_msft/fakepublicrepo.git
Note: It also reproduces when using a private repository via the SSH URI. Eg:
git@gitlab.com:gabes_msft/fakeproj.git
I am able to add either external repository if I use az resource update as a workaround. Eg:
az resource update --resource-group MyRG --namespace Microsoft.Web --parent sites/MyAppServiceName--resource-type sourcecontrols --name web --set properties.repoUrl=git@gitlab.com:MyGitLabAccount/MyProject.git properties.branch=master properties.IsManualIntegration=true properties.deploymentRollbackEnabled=false properties.isMercurial=false

Closing this since this an old issue looks like there is an existing workaround. Please file a new issue if this is still a concern.

The issues is still present after 4 years.
No matter what I set for --repository-type externalgit is always isMercurial=true


Address review comments from previous diagnostic improvement PRs

Addresses review comments from @bnbarham from previous PRs that improved diagnostics.

@swift-ci Please test


fix(license): Correct License reference to Apache-2

In some files reused from other splunk projects as templates the wrong license was retained.

:tada: This PR is included in version 4.2.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[needs help] feature request - export with json

Currently -export makes two files .ies .bss.
There could be also -exportjson
In result it would generate .ies .bss + .json file, containing formated extracted data like its in "--json" output, but it would be stored for each MAC address next to .ies .bss files

I think the approach I'd accept in a PR would be to also export a .json file alongside the .ies and .bss file when using the -export option. I'm not interested in maintaining and supporting an additional CLI option for this.

May be an opportunity here to come up with a sane method of saving output from lswifi to file. Need to research some more.


update NPM version

Hello,
Thank you guys for such a great package. Right now I'm using your source code because the package at npm seems to be pretty outdated. When are you planning on making another npm release?? will it be after your 2.x milestone??

Well, 1.4.0 is very solid. :)
2.0.0 changes the interface (and the implementation is refactored), but there are not new features.
I would like to review a few details and then it is ready to publish (in a couple of weeks).
My suggestion is using the actual version. The upgrade is quite straightforward,

Great :) I like the new interface but I will stick with 1.4.0 for now. Thanks alot!


Update troubleshooting.md

Question for reviewers: Should I move the information from the "conclusion" to the start of the file? To me this seems to be information that would be useful to know from the beginning. It could be integrated into the list of the three environments in the intro.

Question for reviewers: Should I move the information from the "conclusion" to the start of the file? To me this seems to be information that would be useful to know from the beginning. It could be integrated into the list of the three environments in the intro.

Yeah, I think that would be useful in the beginning.

Question for reviewers: Should I move the information from the "conclusion" to the start of the file? To me this seems to be information that would be useful to know from the beginning. It could be integrated into the list of the three environments in the intro.

Yeah, I think that would be useful in the beginning.

Done and committed to the branch


can't access property "open"

Hi, @cajames, thank you for creating this beautiful plugin.
 :-)
But there is an issue in the editor every time when I try to delete gallery block
can't access property "open", this.$refs.settings is undefined

How to reproduce:
I added 7 images, they went to 4 rows.
When I try to delete rows from the bottom one, this happens every time on the second one from the bottom.

Hey @mynameisfreedom, ah thank you for picking this up! I think I've found the issue and will ship a fix soon.

@mynameisfreedom Please let me know if you're still facing this issue with the latest version. 😊

Hi, @cajames !
Confirmed, the issue is resolved.
Thank you very much!


add jimp test to benchmarks?

JIMP looks like it might be an interesting addition to the benchmarks:
https://github.com/oliver-moran/jimp
It's a pure JS image resize library. I doubt if it's especially quick or low on memory use, but it is very easy to maintain and has picked up some users recently.

Thanks for the tip-off John, will do.
https://twitter.com/Rich_Harris/status/647369066399842304

Early testing suggests jimp is currently about half the speed of (CImg-based) lwip for a typical JPEG>resize>JPEG roundtrip.
The bilinear resizing logic is from https://github.com/taisel/JS-Image-Resizer
JPEG decompression from https://github.com/notmasteryet/jpgjs
JPEG compression from https://github.com/owencm/javascript-jpeg-encoder

Correction: jimp and lwip appear to perform at around the same order of magnitude.
Some results from a ~5 year old quad-core AMD box using Node v0.12 (lwip doesn't support Node v4 yet):
jimp-buffer-buffer x 0.76 ops/sec ±3.60% (8 runs sampled)
jimp-file-file x 0.70 ops/sec ±8.03% (8 runs sampled)
lwip-file-file x 0.73 ops/sec ±8.75% (8 runs sampled)
lwip-buffer-buffer x 0.73 ops/sec ±4.26% (8 runs sampled)
imagemagick-file-file x 4.86 ops/sec ±2.44% (28 runs sampled)
imagemagick-native-buffer-buffer x 2.80 ops/sec ±4.16% (18 runs sampled)
gm-buffer-file x 3.51 ops/sec ±1.46% (22 runs sampled)
gm-buffer-buffer x 3.49 ops/sec ±2.20% (22 runs sampled)
gm-file-file x 3.56 ops/sec ±1.23% (22 runs sampled)
gm-file-buffer x 3.41 ops/sec ±3.50% (21 runs sampled)
sharp-buffer-file x 17.91 ops/sec ±0.25% (86 runs sampled)
sharp-buffer-buffer x 17.99 ops/sec ±0.15% (87 runs sampled)
sharp-file-file x 17.44 ops/sec ±0.17% (84 runs sampled)
sharp-file-buffer x 17.51 ops/sec ±0.20% (84 runs sampled)
I'll try to run these tests on a more representative AWS instance later today.

Interesting! JS really is impressively quick.
The decoder doesn't seem to do shrink on load, as far as I can see, that would get them another x 8 speed up. And of course bilinear is probably not good enough for many applications.

When the proposed SIMD data type lands in the V8 JavaScript engine we might have found a liborc replacement :)

Huh, nice, I hadn't come across SIMD.js. Yes, for things like JPEG decode it should be worth a x3 or x4 speedup.

Results, including jimp, now available at http://sharp.readthedocs.org/en/latest/performance/#results
The clock speed on the c4.xlarge EC2 instances seems to vary between 2.6 and 3.3 GHz. I believe this is due to Intel's "Turbo Boost" feature that will auto-overclock based on (lack of) CPU temperature. The cat /proc/cpuinfo command reported a clock speed of 2.9GHz whilst these tests ran.


Upgrade to RN 0.74

slack context: https://expensify.slack.com/archives/C02NK2DQWUX/p1709024519896479
Problem
There are some new arch problems that should be fixed in RN 0.74. So far that's the only thing I'm aware of in 0.74 that we'll need, but it takes a long time to upgrade. It's not necessarily a blocker but unless we upgrade we'll have to use patches.
Solution
Let's get the ball rolling on the RN 0.74 upgrade. If there are issues in the RC we should report them to Meta.

Hey, I would like to work on this issue!

@MrRefactor I'd strongly recommend you to try https://github.com/infinitered/flame. There's a talk from Jamon, it's creator here. I hope it will help streamline the upgrade process for you.

@roryabraham Sure! I will get gpt-4 and try upgrading with that tool!

wrote some best practices on RN upgrades earlier today:

Look at the release notes to understand what changed.
Look at any patches that we've got, find the upstream PR associated with the patch by looking at the PR that introduced the patch: there should be a link to an upstream PR for the patch in the PR description. Evaluate if that patch is still needed or can be removed. If it's still needed, coordinate with the author of the patch to figure out how it needs to be applied to the new version. Have them update their upstream PR if needed. Also consider alternatives if Meta doesn't seem to be actively reviewing the PR. Open a conversation in slack if you're not sure.
If there are any deprecations, investigate what's needed to remove our usage of deprecated code. It doesn't necessarily need to be a blocker, but we want to try to remove uses of deprecated APIs ASAP.
Use flame, an AI-powered CLI made specifically for upgrading React Native. It uses react-native-upgrade-helper under the hood and leverages GPT-4 to apply the diff more intelligently. Very cool tool, you can see a demo here.
Use 2 C+ testers instead of just 1
Create an AdHoc build and have Applause run a full regression suite
Create a GitHub Project for the upgrade so that if any issues are identified, they can be added to the project and tracked effectively, rather than just being comments in the PR. That way we can track what issues need to be resolved and re-tested on staging.

Update:

Tried upgrading with flame-ai but as its still in experimental stage its not really working as expected with 0.74, opened an issue with one of the problems connected with that.
Manually applied changes from upgrade-helper  - I will create draft PR and will be adding any progress there
I will go through all of the patches and list them to make sure if upgrade of rn version is affecting those

Update:

Working on rc-2 as it was released couple days ago
Working on resolving issues with dependencies, trying to apply temporary workaround to get app running on android & ios
Resolving issues with react-native-quick-sqlite connected to wrong compilation of Folly on iOS
Resolving issues with react-native-live-markdown on android
Checking compatibility in android dependencies connected to gradle versioning

CC: @roryabraham  @mountiny

Update:
Created an issue in react-native-quick-sqlite as the same error is visible while building with fresh rn app. In meantime working on a fix for that problem.

Created an https://github.com/margelo/react-native-quick-sqlite/issues/37 in react-native-quick-sqlite as the same error is visible while building with fresh rn app. In meantime working on a fix for that problem.

We'll post in the Margelo room

Update:
Created an issue in @expensify/react-native-live-markdown as the same error is visible while building with fresh rn app for android.

Update:

Switching to RC.3 as it was released
Working on patches for @expensify/react-native-live-markdown and react-native-quick-sqlite

@MrRefactor The fix for @expensify/react-native-live-markdown is pretty simple, it's just a matter of changing a single import in MarkdownUtils.java:
-import com.facebook.react.views.text.CustomLineHeightSpan;
+import com.facebook.react.views.text.internal.span.CustomLineHeightSpan;

@tomekzaw Thanks Tomek!

Update:
Implemented workarounds for:

@expensify/react-native-live-markdown
react-native-quick-sqlite

Working on new issues connected with:
Android:

lottie-react-native
expo , expo-modules-core,

iOS

expo-modules-core

I will also create issue & pr in @react-native-async-storage/async-storage as its showing warnings with mismatched versions of ksp version

Also there was a question from @cead22 if we could upgrade rn to 0.73.5 on the road as its fixing this issue

commented in slack, but I think we should press on with the 0.74 upgrade

@MrRefactor, let's start doing updates in slack to get more visibility, then just link to the slack updates here in GH.
How can we help push this along? What are you doing to parallelize the work here?

@MrRefactor looking forward to seeing an update from you on this project.

Update on upgrade work: https://expensify.slack.com/archives/C01GTK53T8Q/p1711111014179099
CC: @roryabraham @mountiny

latest discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1711111014179099

Update:

switched to rc-6 - link
resolving issues with android build,

I will also post an update on slack - sorry for late update, needed to get back to speed after Easter.

@MrRefactor do you have an estimate when this PR will be ready for review?

@MrRefactor do you have an estimate when this PR will be ready for review?

Aiming at end of this week!

We got another Fabric related issue for which I proposed a patch:

https://github.com/Expensify/App/issues/40081

Discussing it on Slack 🧵, this RN v0.74 commit came up:

https://github.com/facebook/react-native/commit/5fbdc994f945ee8d834632649e3b82451660e8fe

Which might fix our issue and the patch won't be required once we're on v0.74.
We're currently debating whether to add the proposed patch or HOLD until we're upgraded.

I'm wondering if this issue may also have been fixed in RN 0.74

Update - 19.04:
Draft PR link -> link
After merging new arch to main, I needed to revert most of the changes as those have been resolved in new arch pr. Also as we are adding a bridgeless for new architecture it may require more effort as we estimated at the beginning.
There is one breaking issue connected to NotificationService target on iOS - /App/ios/NotificationServiceExtension/NotificationService.swift:8:8 Compiling for iOS 13.0, but module 'AirshipServiceExtension' has a minimum deployment target of iOS 14.0
I have messaged @arosiclair as he created that target couple of months ago. When we switch to higher deployment target its crashing with implementation issues:

Expo update:
today expo released its first beta version of SDK51 for react-native 0.74.0 - link
After updating all expo libraries it seems all building issues connected to expo are resolved on android side, for iOS need to resolve NotificationService issue first to make sure its working fine.
I have removed/updated react native patches introduced in new arch PR, as some of them has been resolved in rn 0.74.0
As for android - after updating/patching libs current build blocker is connected to react-native-clipboard and its alignment to rn0.74.0 but as I can see @WoLewicki has already stared aligning that in this PR
Also in this thread @WoLewicki and @j-piasecki asked if they could join rn-upgrade efforts as there is many more libraries to be aligned with new changes in RN core

I'm wondering if https://github.com/Expensify/App/issues/40108#issuecomment-2062563600 may also have been fixed in RN 0.74

Im checking it right now and will give an update on that in next post on monday.
CC: @mallenexpensify @roryabraham @mountiny @WoLewicki @j-piasecki @arosiclair @

Commenting

Update 22.04:
Draft PR link -> https://github.com/Expensify/App/pull/40548
Hi! Yesterday & today I managed to resolve issues with Airship - now it has min deployment version of 14.0 as marked in this commit.
I also created/updated patches for failing libraries while building on iOS & Android:

react-native-clipboard
rnmapbox/maps - android only, working on patch for iOS
react-native-svg
react-native-plaid-link-sdk
react-native - needed to remove patch for inverted flat list as it was breaking build for iOS - to be fixed

Build issues:
iOS -> issue related to nrmapbox/map:

Android -> issue related to react-native-vision-camera - will open an issue in vision camera repo:
e: /App/node_modules/react-native-vision-camera/android/src/main/java/com/mrousavy/camera/frameprocessors/VisionCameraProxy.kt:31:79 This API is provided only for React Native frameworks and not intended for general users. This API can change between minor versions in alignment with React Native frameworks and won't be considered a breaking change.
e: App/node_modules/react-native-vision-camera/android/src/main/java/com/mrousavy/camera/frameprocessors/VisionCameraProxy.kt:36:19 This API is provided only for React Native frameworks and not intended for general users. This API can change between minor versions in alignment with React Native frameworks and won't be considered a breaking change.
e: /App/node_modules/react-native-vision-camera/android/src/main/java/com/mrousavy/camera/frameprocessors/VisionCameraProxy.kt:36:47 This API is provided only for React Native frameworks and not intended for general users. This API can change between minor versions in alignment with React Native frameworks and won't be considered a breaking change.
e: /App/node_modules/react-native-vision-camera/android/src/main/java/com/mrousavy/camera/frameprocessors/VisionCameraProxy.kt:75:73 This API is provided only for React Native frameworks and not intended for general users. This API can change between minor versions in alignment with React Native frameworks and won't be considered a breaking change.

CC: @mallenexpensify @roryabraham @mountiny @WoLewicki

@shubham1206agra VisionCamera is a bit tricky to bring to new arch. I have asked the Meta team about some implementation specifics regarding the frameProcessor approach I currently use here: https://github.com/reactwg/react-native-new-architecture/discussions/167#discussioncomment-8938596
But so far I don't have a clear approach and I think this is still blocked. I am in contact with phillip from meta and he's gonna help me find a solution to this using CodeGen soon.

Theoretically you could use the interop layer they built, and rip out all the Frame Processor stuff in VisionCamera Android - then it'll surely build.
But a real solution is to get away from the private APIs I currently use to inject the Frame Processor runtime into JSI, which I hopefully plan to solve with CodeGen/Fabric JSI View Managers. cc @philIip

Hey - yup I know, Frame Processors are not enabled here anyways - but the VisionCameraProxy.kt file will still be compiled because Java doesn't support preprocessor flags, so I can't really compile that code out (unless I create another file that stubs out the implementations and switches the source files at build.gradle with srcSets, but that's a bit complex right now).
So these lines here in VisionCameraProxy.kt will still be compiled, and if React Native removes them it will fail to compile - even though we are not calling VisionCameraProxy in Expensify (because Frame Processors are not enabled).
So a workaround for now would be to rip out all the Frame Processors related stuff as a temporary patch, or to compile all that stuff out in build.gradle using srcSets - either of those is only a temporary workaround.
The real solution will be VisionCamera migrating over to new-arch w/ CodeGen, Fabric and TurboModules - but I am still a bit blocked on that since I don't know how to add a JSI-only property to the <Camera> view. I need to run C++ JSI code before that prop (frameProcessor) gets passed to native Java/Swift, kinda like an RCT_ENUM_CONVERTER but for JSI/C++.

I can get VisionCamera migrated to new arch / bridgeless for you next week or the week after that (currently on vacation in Italy 🇮🇹), is that cool with you guys? cc @roryabraham

Do we use react-native-mmkv? That's already migrated, only a minor fix then I can merge that https://github.com/mrousavy/react-native-mmkv/pull/656

Do we use react-native-mmkv? That's already migrated, only a minor fix then I can merge that mrousavy/react-native-mmkv#656

We are not using react-native-mmkv

I can get VisionCamera migrated to new arch / bridgeless for you next week or the week after that (currently on vacation in Italy 🇮🇹), is that cool with you guys? cc @roryabraham

In meanwhile I will try to patch workaround for that issue

I can get VisionCamera migrated to new arch / bridgeless for you next week or the week after that (currently on vacation in Italy 🇮🇹), is that cool with you guys

To understand, is this a blocker for the 0.74 PR? @MrRefactor

Update 24.04:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Reanimated Draft PR link -> https://github.com/Expensify/App/pull/40775
Hi! Today I kept working  on issues reported with android and iOS builds.
I have created an issue in rnmapbox/maps and posted questions about failing iOS builds here -> https://github.com/rnmapbox/maps/issues/3462
Also reproduced that issue on fresh react native 0.74.0 repo.
I have also created a patch for react-native-vision-camera removing all code related to frame processors - still testing that patch if its working properly. It seems like I have issues with codegen, so need to doublecheck it. Also locked version of react-native-vision-camera to make sure all patches introduced with new arch PR are still properly applied.
Also tomorrow @kbieganowski will start helping me with splitting this PR into smaller pieces to merge them to main before rest of the changes as discussed here -> https://github.com/Expensify/App/pull/40548#pullrequestreview-2015296489
CC: @mallenexpensify @roryabraham @mountiny

Update 26.04:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Reanimated Draft PR link -> https://github.com/Expensify/App/pull/40775
Hi! I'm still resolving issues from previous PR - trying to fix new turbo modules linking errors as well as align rnmapbox/map to work with rn 0.74.
I have also started working on 0.74.0 support for react-native-pager-view as its breaking android builds, and needs to be aligned as well.
CC: @mallenexpensify @roryabraham @mountiny @WoLewicki

@MrRefactor I just merged a PR that upgrades react-native-quick-sqlite with RN 0.74 compatibility

Update 29.04:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Reanimated Draft PR link -> https://github.com/Expensify/App/pull/40775
Hi! I'm still resolving android build issues connected to new linking of the packages.

Managed to align rnmapbox/maps to work with rn 0.74.0 on iOS
iOS build is working, app is running:

Updated libraries:

@expensify/react-native-live-markdown to 0.1.69
react-native-gesture-handler to 2.16.0
@react-native-async-storage/async-storage to 1.23.1

Updated patches:

@rnmapbox/maps
react-native-vision-camera

Added patches:

react-native -> Patch with disabling bridgeless mode on iOS as App was failing - I will check the reason of app failing with bridgeless after fixing android build issues

I have also patched react-native-pager-view for android, it seems to be working fine, need to create patch for iOS as well.
NOTE: I'm OOO starting Wednesday, will be back on Monday!
CC: @mallenexpensify @roryabraham @mountiny

@roryabraham I'm putting this in the Summer release, but if there's a particular project that it's necessary for -- let me know. As I understand it, we didn't need it for QBO.

Ok, sounds good. Hopefully we'll finish this up soon after @MrRefactor is back from OOO

Update 06.05:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Reanimated Draft PR link -> https://github.com/Expensify/App/pull/40775
Hey hey! Im back from OO, today I was trying to resolve issues with codegen, made some progress. Tomorrow I will update PR with main merge and will doublecheck iOS build. Also we found a proper fix for react-native-pager-view that I will crate PR for.
CC: @mallenexpensify @roryabraham @mountiny

Update 08.05:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Reanimated Draft PR link -> https://github.com/Expensify/App/pull/40775
Hey! I have just pushed changes from main and align them with current state of the rn 0.74 to build for iOS, for android Im still resolving codegen issues, talking with rn-cli maintainers and looking for the proper resolution of the issues.
Is seems like there is a problem with libraries that are using old syntax for codegen field in package.json as some of the codegen errors are pointing to the change of the config as follows:
BEFORE:
    {
      // ...
      "codegenConfig": {
        "libraries": [
          {
            "name": "libName1",
            "type": "all|components|modules",
            "jsSrcsRoot": "libName1/js"
          },
          {
            "name": "libName2",
            "type": "all|components|modules",
            "jsSrcsRoot": "libName2/src"
          }
        ]
      }
    }

    AFTER:
    {
      "codegenConfig": {
        "name": "libraries",
        "type": "all",
        "jsSrcsRoot": "."
      }
    }

Thats what we are working on in react-native-pager-view as its failing with same error as above.
CC: @mallenexpensify @roryabraham @mountiny

Update 09.05:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Reanimated Draft PR link -> https://github.com/Expensify/App/pull/40775
Hey! Not much changed from yesterday, still resolving codegen issues, also working on react-native-pager-view issue.
CC: @mallenexpensify @roryabraham @mountiny

Update 10.05:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Reanimated Draft PR link -> https://github.com/Expensify/App/pull/40775
Hey hey, today Ive been working together with @kbieganowski on dividing the work related to RN upgrade, also continued on resolving codegen issues.  We have also put attention to react-native-reanimated upgrade PR, It should be ready to be tested on monday.
Also @kbieganowski is actively working on splitting this PR into smaller pieces containing only lib upgrades - in some of the cases its impossible due to the fact those are using rn0.74 changes.
CC: @mallenexpensify @roryabraham @mountiny

Update 14.05:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Reanimated Draft PR link -> https://github.com/Expensify/App/pull/40775
Hey!
Today together with @kbieganowski we have been working on resolving android build issues, upgrading more libraries to the newer versions and adjusting patches in the project. After merging the latest main, iOS builds are working fine, app is building and starting. On the other hand, on android we keep struggling with build issues connected to codegen part of build process. After upgrading react-native-vision-camera to the lates version and applying patches for rn 0.74, now we are facing react-native-webview error, which sadly is project specific - I couldnt reproduce it on fresh 0.74 project with new arch.
CMake Error at /App/android/app/build/generated/source/codegen/jni/CMakeLists.txt:11 (add_library):     add_library cannot create target "react_codegen_RNCWebViewSpec" because     another target with the same name already exists.  The existing target is a     shared library created in source directory     "/App/node_modules/react-native-webview/android/build/generated/source/codegen/jni".
Tomorrow I will try complete reinstall of the package as I can see, there are some most likely merge conflict issues in android files such as multiplication of react-native-webview include statement in settings.gradle

Unfortunately process of resolving android build issues takes time as it takes around 17-20min to run each build in order to check if changes made any difference.
@kbieganowski also tried extracting more libraries to standalone PR's but most of them require rn 0.74 changes so we cannot merge them before the main PR itself.
CC: @mallenexpensify @roryabraham @mountiny

now we are facing react-native-webview error, which sadly is project specific

Maybe it's a bad cache from the patches we have for react-native-webview with RN 0.73?

@kbieganowski also tried extracting more libraries to standalone PR's but most of them require rn 0.74 changes so we cannot merge them before the main PR itself

Got it, thanks for checking this. It's very helpful

Update 15.05:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Reanimated Draft PR link -> https://github.com/Expensify/App/pull/40775
Hey! Not much changed from tomorrow's update:

@kbieganowski is checking iOS build and looking for any major regressions on 0.74 branch
I continue on resolving android build issues, managed to resolve react-native-webview and checking codegen issues with other libs.

CC: @mallenexpensify @roryabraham @mountiny

Update 20.05:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Reanimated PR link -> https://github.com/Expensify/App/pull/40775
Hey hey, we validated react-native-reanimated changes and builds so PR is ready to be reviewed by @shubham1206agra
So far we didnt spot any major issues on iOS - I can see that adhoc build is crashing on iOS due to cache in Pod's - we need to clear the pod's caches and hopefully adhoc build will be ready to be tested.
As for android - we are still resolving build issues, seems like there are few libraries left that we need to go through and check why those are causing builds to crash, I've  also cleared up some setup code related to react-native-webview and will push it to the PR as well.
CC: @mallenexpensify @roryabraham @mountiny

Update 21.05:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Reanimated PR link -> https://github.com/Expensify/App/pull/40775
Hey!
I have updated Reanimated PR based on no longer necessary patches, also still resolving issues connected to android build for main upgrade PR.
CC: @mallenexpensify @roryabraham @mountiny

Update 22.05:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Reanimated PR link -> https://github.com/Expensify/App/pull/40775
Hey!
We are working on resolving crash in Reanimated upgrade PR related to clicking on Emoji button on composer that crashes the app, also actively working resolving android build issues on main upgrade PR. I will also update the version of react-native-pager-view as soon as we will create new release version containing fixes for codegen on rn 0.74.
CC: @mallenexpensify @roryabraham @mountiny

Update 22.05:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Reanimated PR link -> https://github.com/Expensify/App/pull/40775
Hey!
Today we have found issue causing crash on android/iOS in Reanimated upgrade PR. Unfortunately even though the app is building for both iOS and Android, there is a part of the lib that can be only working with react-native 0.74. We have checked reanimated issue on rn upgrade iOS build and we cannot reproduce it there. In that case we should close reanimated PR and dont split that react-native upgrade PR into smaller pieces as libraries are aligned only to rn version >= 0.74. As for android builds in the main PR, we made some progress but still not there with the build.
CC: @mallenexpensify @roryabraham @mountiny

Update 24.05:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Hey!
More progress towards fixing android builds, we spotted next issue connected with react-native-live-markdown which we were able to reproduce with the example app in library as well. Link to the issue -> link.
CC: @mallenexpensify @roryabraham @mountiny @tomekzaw @j-piasecki @kbieganowski

Update 27.05:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Hey!
Thanks to @tomekzaw we fixed issues connected to react-native-live-markdown I have also applied 0.74 patch for react-native-device-info for android, and I keep working on aligning other libraries failing.
CC: @mallenexpensify @roryabraham @mountiny

Update 28.05:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Hey!
Working on aligning react-native-net-info, spotted additional issue with react-native-device-info and already patched it. Also patched react-native-document-picker, working on other libraries fixing android builds. Aiming for mid next week for android builds to be working.
CC: @mallenexpensify @roryabraham @mountiny

Update 29.05:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Hey!
I keep working on fixing android builds & aligning libraries for 0.74 new arch. Also another developer will be joining me in the upgrade effort starting on Friday. Im OOO tomorrow due to bank holiday, next update will be posted on Friday.
CC: @mallenexpensify @roryabraham @mountiny

Update 31.05:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Hey!
Today @kubabutkiewicz joined me with upgrade efforts. I have pushed latest main to the PR with all of the changes made to the patches/libraries. We divided the list of libraries that may be crashing between both of us and we are validating if those are working fine on fresh rn project with 0.74 and new arch enabled. There is an error that we are trying to resolve along with the list of libs:
C++ build system [build] failed while executing:
      /Users/jakubsys/Library/Android/sdk/cmake/3.22.1/bin/ninja
        -C \
        /Users/jakubsys/App/android/app/.cxx/Debug/4r2x36fq/arm64-v8a
        appmodules \
        react_codegen_Airship \
        react_codegen_AndroidLocationEnabler \
        react_codegen_KeyCommand \
        react_codegen_RNCConfigSpec \
        react_codegen_RNCGeolocation \
        react_codegen_RNCNetInfoSpec \
        react_codegen_RNCViewPager \
        react_codegen_RNCWebViewSpec \
        react_codegen_RNHapticFeedbackSpec \
        react_codegen_RNImagePickerSpec \
        react_codegen_RNLiveMarkdownSpec \
        react_codegen_RNPerformanceSpec \
        react_codegen_RNShareSpec \
        react_codegen_ReactNativeBlobUtilSpec \
        react_codegen_lottiereactnative \
        react_codegen_rnasyncstorage \
        react_codegen_rncameraroll \
        react_codegen_rnclipboard \
        react_codegen_rndeviceinfomodule \
        react_codegen_rndocumentpicker \
        react_codegen_rnflashlist \
        react_codegen_rngesturehandler_codegen \
        react_codegen_rnimagesize \
        react_codegen_rnmapbox_maps_specs \
        react_codegen_rnpdf \
        react_codegen_rnpermissions \
        react_codegen_rnpicker \
        react_codegen_rnplaidlink \
        react_codegen_rnreanimated \
        react_codegen_rnscreens \
        react_codegen_rnsvg \
        react_codegen_safeareacontext
    from /Users/jakubsys/App/android/app

It also seems that even after applying fix for react-native-live-markdown there is still an issue with that library, @kubabutkiewicz will post logs in the next comment.
CC: @mallenexpensify @roryabraham @mountiny

Hi, putting a log which @MrRefactor mentioned
android-log.txt
Also I tried to run android build on fresh RN project with new arch enabled, v0.74 installed with LiveMarkdown v0.1.70 and applied patch from Expensify repo and also build is failing
38 actionable tasks: 23 executed, 15 up-to-date

info 💡 Tip: Make sure that you have set up your development environment correctly, by running npx react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/README.md#doctor

/Users/jakubbutkiewicz/Developer/laboratoriumTestowe/node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java:14: error: cannot find symbol
import com.facebook.react.views.text.CustomLineHeightSpan;
                                    ^
  symbol:   class CustomLineHeightSpan
  location: package com.facebook.react.views.text
/Users/jakubbutkiewicz/Developer/laboratoriumTestowe/node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/CustomMountingManager.java:24: error: cannot find symbol
import com.facebook.react.views.text.TextInlineViewPlaceholderSpan;
                                    ^
  symbol:   class TextInlineViewPlaceholderSpan
  location: package com.facebook.react.views.text
/Users/jakubbutkiewicz/Developer/laboratoriumTestowe/node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java:152: error: cannot find symbol
        CustomLineHeightSpan[] spans = ssb.getSpans(0, ssb.length(), CustomLineHeightSpan.class);
        ^
  symbol:   class CustomLineHeightSpan
  location: class MarkdownUtils
/Users/jakubbutkiewicz/Developer/laboratoriumTestowe/node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java:152: error: cannot find symbol
        CustomLineHeightSpan[] spans = ssb.getSpans(0, ssb.length(), CustomLineHeightSpan.class);
                                                                     ^
  symbol:   class CustomLineHeightSpan
  location: class MarkdownUtils
/Users/jakubbutkiewicz/Developer/laboratoriumTestowe/node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/CustomMountingManager.java:163: error: cannot find symbol
          text.nextSpanTransition(i, text.length(), TextInlineViewPlaceholderSpan.class);
                                                    ^
  symbol:   class TextInlineViewPlaceholderSpan
  location: class CustomMountingManager
/Users/jakubbutkiewicz/Developer/laboratoriumTestowe/node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/CustomMountingManager.java:164: error: cannot find symbol
        TextInlineViewPlaceholderSpan[] placeholders =
        ^
  symbol:   class TextInlineViewPlaceholderSpan
  location: class CustomMountingManager
/Users/jakubbutkiewicz/Developer/laboratoriumTestowe/node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/CustomMountingManager.java:165: error: cannot find symbol
          text.getSpans(i, lastAttachmentFoundInSpan, TextInlineViewPlaceholderSpan.class);
                                                      ^
  symbol:   class TextInlineViewPlaceholderSpan
  location: class CustomMountingManager
/Users/jakubbutkiewicz/Developer/laboratoriumTestowe/node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/CustomMountingManager.java:166: error: cannot find symbol
        for (TextInlineViewPlaceholderSpan placeholder : placeholders) {
             ^
  symbol:   class TextInlineViewPlaceholderSpan
  location: class CustomMountingManager
Note<EMAIL_ADDRESS>uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
8 errors

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':expensify_react-native-live-markdown:compileDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:
> Run with --info option to get more log output.
> Run with --scan to get full insights.

BUILD FAILED in 6s
error Failed to install the app. Command failed with exit code 1: ./gradlew app:installDebug -PreactNativeDevServerPort=8081
/Users/jakubbutkiewicz/Developer/laboratoriumTestowe/node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java:14: error: cannot find symbol
import com.facebook.react.views.text.CustomLineHeightSpan; ^ symbol: class CustomLineHeightSpan location: package com.facebook.react.views.text
/Users/jakubbutkiewicz/Developer/laboratoriumTestowe/node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/CustomMountingManager.java:24: error: cannot find symbol
import com.facebook.react.views.text.TextInlineViewPlaceholderSpan; ^ symbol: class TextInlineViewPlaceholderSpan location: package com.facebook.react.views.text
/Users/jakubbutkiewicz/Developer/laboratoriumTestowe/node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java:152: error: cannot find symbol CustomLineHeightSpan[] spans = ssb.getSpans(0, ssb.length(), CustomLineHeightSpan.class); ^ symbol: class CustomLineHeightSpan location: class MarkdownUtils
/Users/jakubbutkiewicz/Developer/laboratoriumTestowe/node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java:152: error: cannot find symbol CustomLineHeightSpan[] spans = ssb.getSpans(0, ssb.length(), CustomLineHeightSpan.class); ^ symbol: class CustomLineHeightSpan location: class MarkdownUtils
/Users/jakubbutkiewicz/Developer/laboratoriumTestowe/node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/CustomMountingManager.java:163: error: cannot find symbol text.nextSpanTransition(i, text.length(), TextInlineViewPlaceholderSpan.class); ^ symbol: class TextInlineViewPlaceholderSpan location: class CustomMountingManager
/Users/jakubbutkiewicz/Developer/laboratoriumTestowe/node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/CustomMountingManager.java:164: error: cannot find symbol TextInlineViewPlaceholderSpan[] placeholders = ^ symbol: class TextInlineViewPlaceholderSpan location: class CustomMountingManager
/Users/jakubbutkiewicz/Developer/laboratoriumTestowe/node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/CustomMountingManager.java:165: error: cannot find symbol text.getSpans(i, lastAttachmentFoundInSpan, TextInlineViewPlaceholderSpan.class); ^ symbol: class TextInlineViewPlaceholderSpan location: class CustomMountingManager
/Users/jakubbutkiewicz/Developer/laboratoriumTestowe/node_modules/@expensify/react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/CustomMountingManager.java:166: error: cannot find symbol for (TextInlineViewPlaceholderSpan placeholder : placeholders) { ^ symbol: class TextInlineViewPlaceholderSpan location: class CustomMountingManager
Note<EMAIL_ADDRESS>uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
8 errors FAILURE: Build failed with an exception. * What went wrong:
Execution failed for task ':expensify_react-native-live-markdown:compileDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details. * Try:
> Run with --info option to get more log output.
> Run with --scan to get full insights. BUILD FAILED in 6s.```
CC: @tomekzaw

Thanks for posting the logs. I was able to successfully build react-native-live-markdown on 0.74.1, maybe something changed in the meantime? I will take a look on it on Monday.

Update 03.06:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Hey hey,
Together with @kubabutkiewicz, @kbieganowski and @tomekzaw we are trying to validate/resolve android build issues.
We are going library by library testing those on fresh react-native application with new arch enabled to check if there are any issues with building/codegen. @szymonrybczak is also supporting me with potential rn-cli errors.
build log file - > link
CC: @mallenexpensify @roryabraham @mountiny

We are going library by library testing those on fresh react-native application with new arch enabled to check if there are any issues with building/codegen.

I tested it and Live Markdown library (from this PR: https://github.com/Expensify/react-native-live-markdown/pull/358) builds successfully in a fresh RN 0.74.1 app (with this PR applied as a patch: https://github.com/facebook/react-native/pull/44684).

I was helping @tomekzaw investigate the Android build issues today. It is caused by the wrong version of rn-cli being used - the version installed in the apps node_modules is 12.x instead of 13.x. After adding
    "@react-native-community/cli": "13.6.4",
    "@react-native-community/cli-platform-android": "13.6.4",
    "@react-native-community/cli-platform-ios": "13.6.4"

to the package.json and re-installing node_modules, the correct version is installed.
Then minSdkVersion needs to be changed to 23 in build.gradle files in the following libraries:

react-native-plaid-link-sdk
react-native-image-picker
react-native-quick-sqlite

As 23 is the minimum since RN 0.74 and they depend on artifacts provided by the RN.
I'm also not sure if that's necessary, but I've removed react-native-release-profiler.
After that, the app built and ran (the patch for @react-native-community/cli-platform-android didn't apply correctly, but I'm not sure if it's required when using the newer version).
Now, the reason for the wrong versions of cli being used is twofold (I think):

react-native-macos and react-native-windows are installed as peer dependencies of a few packages, and the installed version is 0.73, which relies on the older version of the cli
react-native-release-profiler has a direct dependency on cli 12.2.1

Update 04.06:
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
Hey hey,
@j-piasecki was able to run android app, I will apply changes tomorrow morning, cleanup the PR and remaining patches. If everything will work as expected we will be able to run ad-hoc builds.
CC: @mallenexpensify @roryabraham @mountiny @tomekzaw @kbieganowski @kubabutkiewicz

Update 05.06
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
Hey,
I have pushed all the changes related to Android build working, we also have ad hoc builds ready to be tested here
Now we are fixing CI issues, and tomorrow we will be going through the in-app issues caused by the upgrade.
CC: @mallenexpensify @roryabraham @mountiny @kbieganowski @kubabutkiewicz

Update 06.06
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
Hey!
Working on resolving issues:

Modal issues on android
Offline force issue on android & iOS - there is an issue in netinfo package, working on it
storybook build crash on CI

I have also fixed patches for react-native, and working on a patch for netinfo
Opened PR's for
react-native-image-picker,
react-native-image-picker
for minSdkVersion change to 23 so we could remove patches for those.
Resolved apk size for android build, apk from next build should be way smaller.
CC: @mallenexpensify @roryabraham @mountiny @kbieganowski @kubabutkiewicz

@roryabraham @mountiny I'm a tad concerned pushing through a RN upgrade like this is pretty risky before Xerocon. It might be better to hold the merge of the PR until after the conference (which is Wednesday & Thursday next week).

Update 07.06
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
Hey hey,
We are working on resolving app issues on android and CI
-> Android - modal issue reported in the PR,
-> CI -> Storybook issue
CC: @mallenexpensify @roryabraham @mountiny @kbieganowski @kubabutkiewicz

Update 10.06
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
Hey hey,
Trying to find out why adhoc build for Android is doubling previous size, working on modal issue & CI issues.
CC: @mallenexpensify @roryabraham @mountiny @kbieganowski @kubabutkiewicz

Update 11.06
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
Hey hey,
Pushed changes for:
-> Upgrade to rn 0.74.2
-> CI storybook fix
-> Modal issue (useNativeDriver issue on android)
And also explained apk size for ad hoc builds here
New ad hoc builds are available here
Checking useNativeDriver issues on android, and working on resolving CI issue Verify Podfile - @roryabraham could you take a look at this error?
CC: @mallenexpensify @roryabraham @mountiny @koko57 @kubabutkiewicz

Update 12.06
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
Hey hey,
Working on:
-> useNativeDriver issues on android,
-> mapbox issues on android
-> Ci Verify Podfile issue
CC: @mallenexpensify @roryabraham @mountiny @koko57 @kubabutkiewicz

Update 13.06
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
Hey hey,
Working on:
-> useNativeDriver issues on android,(going through libs responsible for displaying modal, all other usages of useNativeDriver are working fine) -  @koko57 &me
-> mapbox issues on android - link to the issue - @kubabutkiewicz &me
-> Ci Verify Podfile issue - @kubabutkiewicz
CC: @mallenexpensify @roryabraham @mountiny @koko57 @kubabutkiewicz

Update 14.06
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
Hey hey,
Fixed:
-> mapbox issues on android - link to the https://github.com/rnmapbox/maps/issues/3522 - I applied a workaround for maps to work, we will work on the main issue in the library itself - @kubabutkiewicz &me
-> Ci Verify Podfile issue - @kubabutkiewicz
Working on:
-> useNativeDriver issues on android,(going through libs responsible for displaying modal, all other usages of useNativeDriver are working fine) - @koko57 @kubabutkiewicz
CC: @mallenexpensify @roryabraham @mountiny @koko57 @kubabutkiewicz

Update 17.06
Main Draft PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
Hey hey,
Working on:
-> useNativeDriver issues on android,(going through libs responsible for displaying modal, all other usages of useNativeDriver are working fine) - @koko57 @kubabutkiewicz
-> Going through the app looking for issues
CC: @mallenexpensify @roryabraham @mountiny @koko57 @kubabutkiewicz

Update 18.06
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
Hey hey,
Working on:
-> useNativeDriver issues on android,(going through libs responsible for displaying modal, all other usages of useNativeDriver are working fine) - @koko57 @kubabutkiewicz
-> Working on issues reported by C+ @MrRefactor
CC: @mallenexpensify @roryabraham @mountiny @koko57 @kubabutkiewicz

Update 19.06
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
Hey hey,
Working on:
-> useNativeDriver issues on android,(working on a fix for react-native-animatable which breaks useNativeDriver) - @koko57 @MrRefactor
-> Working on track expense modal - issue with gesture handler - @kubabutkiewicz @MrRefactor
CC: @mallenexpensify @roryabraham @mountiny @koko57 @kubabutkiewicz

Update 20.06
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
Builds link -> here
Hey hey,
Fixed:
-> Working on track expense modal - issue with gesture handler - @kubabutkiewicz
Working on:
-> useNativeDriver issues on android,(working on a fix for react-native-animatable which breaks useNativeDriver) - @MrRefactor
-> weird background flashing while selecting emoji @kubabutkiewicz @koko57
After @shubham1206agra final review, we will be ready to assign Testers to validate builds, hopefully soon!
CC: @mallenexpensify @roryabraham @mountiny @koko57 @kubabutkiewicz

Update 21.06
PR link -> #40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Builds link -> here
Hey hey,
Working on:
-> useNativeDriver issues on android,(working on a fix for react-native-animatable which breaks useNativeDriver) - @MrRefactor
-> weird background flashing while selecting emoji @kubabutkiewicz @koko57
CC: @mallenexpensify @roryabraham @mountiny @koko57 @kubabutkiewicz

Update 24.06
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Builds link -> here
Hey hey,
Added patch for useNativeDriver in react-native -> it seems there are issues connected to animations on Android in 0.74.2 patch is a temporary fix for modals/animations on Android builds.
Working on:
-> weird background flashing while selecting emoji/animation glitches on android @kubabutkiewicz
-> CI jest pipeline crashing( There is one failure on Jest test, working on reproducing it locally -> for me all the tests are passing) @MrRefactor
CC: @mallenexpensify @roryabraham @mountiny @koko57 @kubabutkiewicz

@MrRefactor is there an upstream issue for the animation problem on Android for RN 0.74.2 ?

Update 25.06
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Builds link -> here
Hey hey,
Working on:
-> weird background flashing while selecting emoji/animation glitches on android @MrRefactor
-> iOS images issue @kubabutkiewicz
-> CI jest pipeline crashing @MrRefactor

@MrRefactor is there an upstream issue for the animation problem on Android for RN 0.74.2 ?

Patch I applied has been merged to react-native and is a part of 0.75 branch. I didnt find the exact issue related to modal backdrop, but there are multiple issues connected with Animated on Android.
I'm still validating react-native-modal and react-native-animatable(which is a dependency of react-native-modal)
CC: @mallenexpensify @roryabraham @mountiny @koko57 @kubabutkiewicz

And also I have a question - couldn't we use modal from react-native itself instead of using react-native-modal?

I think in order to make such a change, we would need to clearly state what the problem is with react-native-modal and why we cannot use it. Also explore what would be the consequence of using other modal

@mountiny The upgrade to RN 0.74 is blocking some of our tasks. It also seems to be quite a lot of work needed to make it happen - is there anything we could help with?
We are currently working on releasing a new version of react-native-release-profiler which was one blocker for the upgrade.

I am not sure if there is an efficient way you could help @MrRefactor @kubabutkiewicz to push this forward. Maybe they could highlight some issues they are facing that could be handled by someone else in parallel.
@MrRefactor How can we speed things up on this project in your opinion?

hey @mountiny @hannojg as for now we are fixing issues created by C+, in that case the only one that is missing at the moment is flashing while closing modals. Apart of that we are waiting for regression results

Also release of react-native-release-profiler would allow us to remove some of the workarounds that we are using atm.

Seems like @shubham1206agra just has one issue to confirm that is fixed and we can hand it off to Applause

Seems like @shubham1206agra just has one issue to confirm that is fixed and we can hand it off to Applause

should already be fixed with expo-image version upgrade

Update 25.06
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Builds link -> here
Hey hey,
Fixed:
-> iOS images issue @kubabutkiewicz
-> Updated all of the expo libraries
Working on:
-> weird background flashing while selecting emoji/animation glitches on android @MrRefactor
-> CI jest pipeline crashing @MrRefactor @kubabutkiewicz
-> update PR description with all of the patches applied and upstream links @MrRefactor
-> Removing potentially unnecessary patches for react-native-cli @MrRefactor
Also @hannojg please let us know when new release of react-native-release-profiler will be ready so we can remove react-native-cli version workarounds.
CC: @mallenexpensify @roryabraham @mountiny @koko57 @kubabutkiewicz

Update 27.06
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Builds link -> here
Hey hey,
Fixed:
-> attachment preview image fix @kubabutkiewicz
-> update PR description with all of the patches applied and upstream links @MrRefactor
Working on:
-> weird background flashing while selecting emoji/animation glitches on android @MrRefactor
-> CI jest pipeline crashing @MrRefactor @kubabutkiewicz
CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

Update 27.06
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Builds link -> here
Hey hey,
StricMode enabled:
We have encountered several critical issues after merging newest main with enabled StrictMode, for both android and iOS mobile main screen is not working at all, we cannot navigate etc.
https://github.com/Expensify/App/assets/32591413/5efba304-d4bb-4f09-a718-2a9667db5afb
For web there are issues connected with:

attachment preview not loading,
attachment modal crash

How should we tackle those issues? Disabling StrictMode is resolving all of them.
Could team that implemented StrictMode help us with those issues?
Working on:
-> weird background flashing while selecting emoji/animation glitches on android @MrRefactor
-> CI jest pipeline crashing @MrRefactor @kubabutkiewicz
CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

@MrRefactor hey I was working on StrictMode and spent a lot of time fighting similar bugs.
On RN 73 the main culprits was react-navigation and reanimated, and I introduced these 2 patches to fix it: https://github.com/Expensify/App/pull/42592/files#diff-8e669add6c10c59477d19de093739cc27882aeaeafcf1dcd920891f3affad29a
What you are describing on native apps is exactly what used to happen on web (cannot navigate problem) and the patch fixed it. I have no idea what exactly could RN 74 change that adds bugs similar to this one.
Did you already try removing all build artefacts and re-running install to make sure patches are applied ok? Just to be 100% sure.
As far as native logic goes - did you add any modifications in the app that might be related to navigation, first loaded screen etc? Any new useEffect hooks that were added?

@MrRefactor a new version of react-native-release-profiler is available, which should be compatible with RN 0.74 now 😊

@MrRefactor a new version of react-native-release-profiler is available, which should be compatible with RN 0.74 now 😊

Thanks, I will check it tomorrow morning!

@MrRefactor @roryabraham
I spend some time investigating (with great help from @WoLewicki  🙏) and I think I found an issue an can help.
tl;dr is this:
We need the same patch for navigation applied to another file. We should merge this PR that I prepared: https://github.com/Expensify/App/pull/44726 and then @MrRefactor you can continue using the updated patch. I have checked out your branch and built the app from scratch and confirmed that navigation issues disappear.
details
The biggest finding is that StrictMode did not work on RN 0.73 on native apps. I have no idea why and I did not know that was the case when I created the original PR. Don't know whether it was intended by react team or just a bug.
In my original PR I focused on web, investigated concurrent react and made web work. When I run ios/android builds - they just worked, so I assumed everything was ok on the native side.
However now I have confirmed that on RN 0.73 StrictMode in fact does nothing, no double renders but on RN 0.74 we get a working StrictMode for the first time on native. That's why all these bugs emerged just now.
Sorry that this happened on your issue, but we should be able to still move forward. I will be also available to help with any other bugs in future, together with @WoLewicki.

Update 02.07
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Builds link -> link
Hey hey,
Fixed:
-> CI jest pipeline crashing @MrRefactor @kubabutkiewicz
-> updated version of react-native-release-profiler and removed overrides for rn-cli @MrRefactor
-> applied patch for StrictMode for native platforms by @Kicu
Bugs status:
Work in progress:
Android - Composer - Previous text is cut off after creating next line @MrRefactor
Android - Composer - Pasted multiline message is displayed in one line  @MrRefactor
Android - Composer - The suggestion list appears with spacing above the composer @MrRefactor
Android - Chat - Green background flickers when dismissing the + modal @MrRefactor
IOU - Same results appear twice when search email on submit expense modal @kacper-mikolajczak
Task – Hidden assignee appears in LHN when assign task without assignee to yourself @kacper-mikolajczak
IOS-Distance rate-Keyboard not open/disappear smoothly when selecting default category @MrRefactor
IOS/Android - Videoplayer controls issue @kubabutkiewicz
Fixed:
IOS - Image preview before sending is not displayed for images from the gallery @MrRefactor
iOS - Track expense - App crashes after selecting track expense @MrRefactor
iOS - App crashes after selecting a video as the attachment to send @MrRefactor
iOS - No image preview on confirmation screen when creating scan request @MrRefactor
Android - Expense - Cursor positions behind the currency when editing amount @MrRefactor
CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

Update 03.07
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Hey hey,
Working on:
-> fixing issues related to strictMode @kubabutkiewicz
-> Upgrading to rn 0.74.3 @MrRefactor
Bugs status:
Work in progress:
Android - Composer - Previous text is cut off after creating next line @MrRefactor
Android - Composer - Pasted multiline message is displayed in one line @MrRefactor
Android - Composer - The suggestion list appears with spacing above the composer @MrRefactor
Android - Chat - Green background flickers when dismissing the + modal @MrRefactor
Android - Expense - App flickers when opening and closing year picker repeatedly @MrRefactor
Android - Workspace chat avatar preview is not displayed @MrRefactor
IOS-Distance rate-Keyboard not open/disappear smoothly when selecting default category @kubabutkiewicz
Fixed:
IOS - Image preview before sending is not displayed for images from the gallery @MrRefactor
iOS - Track expense - App crashes after selecting track expense @MrRefactor
iOS - App crashes after selecting a video as the attachment to send @MrRefactor
iOS - No image preview on confirmation screen when creating scan request @MrRefactor
IOS/Android - Videoplayer controls issue @kubabutkiewicz
Android - Expense - Cursor positions behind the currency when editing amount @MrRefactor
IOU - Same results appear twice when search email on submit expense modal @kacper-mikolajczak
Task – Hidden assignee appears in LHN when assign task without assignee to yourself @kacper-mikolajczak
CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

Update 04.07
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Hey hey,
Working on:
-> fixing issues related to strictMode @kubabutkiewicz @kacper-mikolajczak
-> Upgrading to rn 0.74.3 @MrRefactor
Bugs status:
Work in progress:
Android - Composer - Previous text is cut off after creating next line @MrRefactor
Android - Composer - Pasted multiline message is displayed in one line @MrRefactor
Android - Composer - The suggestion list appears with spacing above the composer @MrRefactor
Android - Chat - Green background flickers when dismissing the + modal @kubabutkiewicz @kacper-mikolajczak
Android - Expense - App flickers when opening and closing year picker repeatedly @kubabutkiewicz @kacper-mikolajczak
Android - Workspace chat avatar preview is not displayed @MrRefactor
IOS-Distance rate-Keyboard not open/disappear smoothly when selecting default category @kubabutkiewicz @kacper-mikolajczak
Fixed:
IOS - Image preview before sending is not displayed for images from the gallery @MrRefactor
iOS - Track expense - App crashes after selecting track expense @MrRefactor
iOS - App crashes after selecting a video as the attachment to send @MrRefactor
iOS - No image preview on confirmation screen when creating scan request @MrRefactor
IOS/Android - Videoplayer controls issue @kubabutkiewicz
Android - Expense - Cursor positions behind the currency when editing amount @MrRefactor
IOU - Same results appear twice when search email on submit expense modal @kacper-mikolajczak
Task – Hidden assignee appears in LHN when assign task without assignee to yourself @kacper-mikolajczak
CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

Update 05.07
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Hey hey,
Working on:
-> fixing issues related to strictMode @kubabutkiewicz @kacper-mikolajczak
Work in progress:
Android - Composer - Previous text is cut off after creating next line @MrRefactor
Android - Composer - Pasted multiline message is displayed in one line @MrRefactor
Android - Composer - The suggestion list appears with spacing above the composer @MrRefactor
Android - Workspace chat avatar preview is not displayed @MrRefactor
Android - Chat - Green background flickers when dismissing the + modal @kubabutkiewicz @kacper-mikolajczak
Android - Expense - App flickers when opening and closing year picker repeatedly @kubabutkiewicz @kacper-mikolajczak
IOS-Distance rate-Keyboard not open/disappear smoothly when selecting default category @kubabutkiewicz @kacper-mikolajczak
Fixed:
IOS - Image preview before sending is not displayed for images from the gallery @MrRefactor
iOS - Track expense - App crashes after selecting track expense @MrRefactor
iOS - App crashes after selecting a video as the attachment to send @MrRefactor
iOS - No image preview on confirmation screen when creating scan request @MrRefactor
IOS/Android - Videoplayer controls issue @kubabutkiewicz
Android - Expense - Cursor positions behind the currency when editing amount @MrRefactor
IOU - Same results appear twice when search email on submit expense modal @kacper-mikolajczak
Task – Hidden assignee appears in LHN when assign task without assignee to yourself @kacper-mikolajczak
CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

Update 08.07
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Hey hey,
Working on:
-> fixing issues related to strictMode @kubabutkiewicz @kacper-mikolajczak
-> resolving nativeDriver issues & composer issues
Work in progress:
Android - Composer - Previous text is cut off after creating next line @MrRefactor
Android - Composer - Pasted multiline message is displayed in one line @MrRefactor
Android - Composer - The suggestion list appears with spacing above the composer @MrRefactor
Android - Workspace chat avatar preview is not displayed @MrRefactor
Android - Chat - Green background flickers when dismissing the + modal @kubabutkiewicz @kacper-mikolajczak
Android - Expense - App flickers when opening and closing year picker repeatedly @kubabutkiewicz @kacper-mikolajczak
IOS-Distance rate-Keyboard not open/disappear smoothly when selecting default category @kubabutkiewicz @kacper-mikolajczak
Fixed:
IOS - Image preview before sending is not displayed for images from the gallery @MrRefactor
iOS - Track expense - App crashes after selecting track expense @MrRefactor
iOS - App crashes after selecting a video as the attachment to send @MrRefactor
iOS - No image preview on confirmation screen when creating scan request @MrRefactor
IOS/Android - Videoplayer controls issue @kubabutkiewicz
Android - Expense - Cursor positions behind the currency when editing amount @MrRefactor
IOU - Same results appear twice when search email on submit expense modal @kacper-mikolajczak
Task – Hidden assignee appears in LHN when assign task without assignee to yourself @kacper-mikolajczak
CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

Update 09.07
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Hey hey,
Working on:
-> resolving nativeDriver issues @kubabutkiewicz @kacper-mikolajczak
-> composer issues on android @MrRefactor
Work in progress:
Android - Composer - Previous text is cut off after creating next line @MrRefactor
Android - Composer - Pasted multiline message is displayed in one line @MrRefactor
Android - Composer - The suggestion list appears with spacing above the composer @MrRefactor
Android - Workspace chat avatar preview is not displayed @MrRefactor
Android - Chat - Green background flickers when dismissing the + modal @kubabutkiewicz @kacper-mikolajczak
Android - Expense - App flickers when opening and closing year picker repeatedly @kubabutkiewicz @kacper-mikolajczak
IOS-Distance rate-Keyboard not open/disappear smoothly when selecting default category @kubabutkiewicz @kacper-mikolajczak
CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

Update 10.07
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Hey hey,
Working on:
-> resolving nativeDriver issues android&iOS @kubabutkiewicz @MrRefactor
-> composer issues on android @MrRefactor
CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

Update 11.07
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Hey hey,
Working on:
-> resolving nativeDriver issues android&iOS @kubabutkiewicz @hurali97 @kacper-mikolajczak
-> composer issues on android @MrRefactor @gedu
-> Suggestion box issues on android @MrRefactor
CC: @mallenexpensify @roryabraham @mountiny

Update 12.07
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Hey hey,
Working on:
-> resolving nativeDriver issues android&iOS @kubabutkiewicz @hurali97 @kacper-mikolajczak
-> composer issues on android @MrRefactor @gedu
-> Suggestion box issues on android @MrRefactor
CC: @mallenexpensify @roryabraham @mountiny

Update 13.07
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Hey hey,
Working on:
-> Upgrading from 0.74.2 -> 0.74.3(removing patches, updating libs) @MrRefactor
-> resolving nativeDriver issues android&iOS @kubabutkiewicz @hurali97 @kacper-mikolajczak
-> composer issues on android @MrRefactor @gedu
-> Suggestion box issues on android @MrRefactor
CC: @mallenexpensify @roryabraham @mountiny

Update 14.07
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Hey hey,
-> Updated from 0.74.2 -> 0.74.3, removed patches for rnmapbox, react-native-plaid-link-sdk, react-native-clipboard
Working on:
-> resolving nativeDriver issues android&iOS @kubabutkiewicz @hurali97
-> composer issues on android @MrRefactor @gedu
-> Suggestion box issues on android @MrRefactor
Also @j-piasecki @WoLewicki as mentioned on slack, could you help us with bugs mentioned above?
CC: @mallenexpensify @roryabraham @mountiny

Update 18.07
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Hey hey,
Fixed:
-> nativeDriver issues android - patch by @j-piasecki
Working on:
-> composer issues on android - link to upstream issue - link
-> Suggestion box issues on android @MrRefactor - checking changes between 0.74 and 0.75 as on 0.75 its working fine
-> Cursor positions behind the currency when editing amount (android) - @kubabutkiewicz
CC: @mallenexpensify @roryabraham @mountiny

Yea - do you want to just upgrade VisionCamera (ideally to latest), or want me to do that?

Update 19.07
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
Hey hey,
Working on:
-> composer issues on android - link to upstream issue - https://github.com/facebook/react-native/issues/45522 @j-piasecki
-> Suggestion box issues on android @MrRefactor - checking changes between 0.74 and 0.75 as on 0.75 its working fine
-> Cursor positions behind the currency when editing amount (android) - @kubabutkiewicz
CC: @mallenexpensify @roryabraham @mountiny

Update 22.08
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
New adhoc builds are ready.
Hey hey,
Working on:
-> composer issues on android, testing changes in prefabs - link to upstream issue - https://github.com/facebook/react-native/issues/45522 @j-piasecki @MrRefactor
-> Suggestion box issues on android @MrRefactor - checking changes between 0.74 and 0.75 as on 0.75 its working fine
-> Cursor positions behind the currency when editing amount (android) - @kubabutkiewicz
CC: @mallenexpensify @roryabraham @mountiny

Update 23.08
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
New adhoc builds are ready.
Hey hey,
Working on:
-> composer issues on android(line height and paste from clipboard), testing changes in prefabs - link to upstream issue - https://github.com/facebook/react-native/issues/45522 @j-piasecki @MrRefactor
-> Suggestion box issues on android @MrRefactor - checking changes between 0.74 and 0.75 as on 0.75 its working fine
CC: @mallenexpensify @roryabraham @mountiny

Update 24.07
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
New adhoc builds are ready.
Hey hey,
Working on:
-> composer issues on android(line height and paste from clipboard), testing changes in prefabs, applied patch by @j-piasecki , checking if both issues are fixed
-> Suggestion box issues on android @MrRefactor - checking changes between 0.74 and 0.75 as on 0.75 its working fine
CC: @mallenexpensify @roryabraham @mountiny

Update 25.07
PR link -> https://github.com/Expensify/App/pull/40548
PR is ready to be tested/reviewed by C+
PR is under regression testing from QA team
New adhoc builds are ready.
Hey hey,
Working on:
-> Suggestion box issues on android @MrRefactor & @kubabutkiewicz  - checking changes between 0.74 and 0.75 as on 0.75 its working fine
CC: @mallenexpensify @roryabraham @mountiny

Update 26.07
PR link -> https://github.com/Expensify/App/pull/40548
New adhoc builds are ready -> link
Hey hey,
New adhoc builds are ready to be tested!
Working on:
-> Suggestion box issues on android @MrRefactor & @kubabutkiewicz - checking changes between 0.74 and 0.75 as on 0.75 its working fine
CC: @mallenexpensify @roryabraham @mountiny

Update 30.07
PR link -> https://github.com/Expensify/App/pull/40548
New adhoc builds are ready -> https://github.com/Expensify/App/pull/40548#issuecomment-2252822245
Hey hey,
Working on:
-> Suggestion box issues on android @MrRefactor & @kubabutkiewicz - checking changes between 0.74 and 0.75 as on 0.75 its working fine
-> Attachment - Opening attachments takes you back to the first attachment - there is an issue with opening attachment, checking it, most likely connected with reanimated
-> Expense - Incorrect currency is displayed when creating an Expense Request in WS -> most likely regression from main, checking
-> Members - Application crashes when scrolling through the "Invite new members" list in WS - every SelectionList component in the app is crashing while opening, seems like its connected to wrong parsing of users with emojis in their names, checking previous builds if its regression from main or not.
CC: @mallenexpensify @roryabraham @mountiny

Update 01.08
PR link -> https://github.com/Expensify/App/pull/40548
New adhoc builds are ready -> https://github.com/Expensify/App/pull/40548#issuecomment-2252822245
Hey hey,
Upgraded rn to 0.74.4, applied fixes for CI
Working on:
-> Suggestion box issues on android @perunt
CC: @mallenexpensify @roryabraham @mountiny

Update 05.08
PR link -> https://github.com/Expensify/App/pull/40548
Hey hey,
Updated patches for expo related to hybrid app setup, I have also implemented a workaround solution to fix suggestion box issue before 0.75 is merged.
With that I think we are ready to merge?
CC: @mallenexpensify @roryabraham @mountiny

Update 07.08
PR link -> https://github.com/Expensify/App/pull/40548
Fresh builds -> https://github.com/Expensify/App/pull/40548#issuecomment-2273386021
Hey hey,

Added workaround for suggestion list by @perunt

We are ready regression testing, also @staszekscp reported issues with building HybridApp, he will look into that as per: https://github.com/Expensify/App/pull/40548#issuecomment-2272724454
CC: @mallenexpensify @roryabraham @mountiny @AndrewGable

Hey! 👋 I'll be working on the upgrade with @WoLewicki starting today!

Thanks for all the work here. as is clear by all the PRs linked above we're in the cleanup phase, upgrading dependencies and removing patches

@dylanexpensify This is ready to be paid out to @shubham1206agra for their help on this one and previously with the 0.74
I think $1000 is fair reward for their testing and code review as well as help with follow ups. Let me know if you disagree

Hi,
The issue likely stems from architectural changes in React Native 0.74+ that are incompatible with your current codebase. The need for patches suggests that your existing setup is not fully aligned with the new architecture, which could introduce bugs, performance regressions, or maintainability challenges. Without upgrading, you may face technical debt, increased complexity, and potential conflicts with future React Native updates.
One possible short-term fix can be applying specific patches with patch-package to replace modules or dependencies that are not compatible, giving alternative solutions for outdated APIs or components. This enables the project to operate without updating while addressing immediate problems. To achieve a lasting fix, transition completely to React Native 0.74+, restructure code to match the new design, verify third-party libraries work well, and conduct thorough testing to prevent any setbacks or additional issues. This will make the project future-proof, get rid of technical debt, and guarantee long-term stability.
Best
Muhammad

@shubham1206agra https://www.upwork.com/jobs/~021833459090006846967

invited!

offer sent @shubham1206agra!