chuy with multiple commands doesn't stop if one errors out

As per title, non erroring might create issues as users might rely on commands are run only after previous commands succeed.
For example
chuy create-container test
The test probably will rely on the container bring created.
Suggestion (to be tested):
https://github.com/UltiRequiem/chuy/blob/7d15303d3431b79e79f8339939323efc7de2f3d5/chuy/helpers.py#L91
We might want to consider changing it to:
subprocess.run(command, shell=True, check=True)

@UltiRequiem happy to close this given https://github.com/UltiRequiem/chuy/commit/8cb55efb2953c9975682660db05d0025876965a8?

Yep, thanks @gabrielecalvo!


Draweditor makes weird jumps when creating multiple annotations on different pages

Page to reproduce: https://mozilla.github.io/pdf.js/web/viewer.html
Configuration:

Chrome version 118, also on Safari
MacOS 14.1.1
PDF.js version: whatever runs on this demo page of yours: https://mozilla.github.io/pdf.js/web/viewer.html
Is a browser extension: No

Steps to reproduce the problem:

Draw an Ink Editor Annotation (just a circle on page 1)
Scroll to page 2 and draw another Annotation

Expected behavior:
There should be two circles:

draw a circle
closed the toolbar for the draw editor
scrolled to page 2
opened the draw editor
draw another circle
Outcome:

What went wrong:
There is a weird jump the draw editor makes so the second circle has a weird line in it:

draw a circle
scrolled to page 2
draw another circle
Outcome:

WFM, in Firefox Nightly 122.0a1 on Windows 11.

Yes, the error also exists on Edge, any Idea on how to fix the error on other browsers?

This issue is reintroduced in the Dec 31st version. Please check.


Small fixes to helpers update

Fix link for astropy-helpers updates, move APLpy to Python 3-only, and update reproject to point to astropy org.

 Clearly wasn't expected this high traffic in this repo for today :)


Update tests to astropy 3.2

Just a small update on some tests due to astropy version 3.2 :rocket:
Solving #665

This push should be one. Sorry for the delay solving this, not sure why the tests were running properly on my local machine :confused:

Now the tests passed, but the question is: where in this code did the change happen? https://github.com/poliastro/poliastro/blob/f66c46c3925f97842b3033bc5219042b01a53c36/src/poliastro/frames.py#L271-L297

Perhaps @shreyasbapat has more information?

This may have the key:
What's new in Astropy 3.2?

Spot the differences :wink:

Source: https://docs.astropy.org/en/v3.2/changelog.html#id21

Since the expected values were in utc scale, we finally decided to rewrite them in the tt one, according to J2000.


pushTextToAll function for WebSocket

Description:
It would be nice to have a pushTextToAll and pushBinaryToAll or similar functions that would push data to all the connected clients of a server. This has to be implemented on the Service object and we may need to have service as an object.

Had a discussion and decided not to introduce such API.


Support decimal values and arithmetic

TypeScript should support decimal values and arithmetic, similar to .NET's Decimal and/or Java's BigDecimal type. This would solve some serious problems when writing business applications in JavaScript.
For the following TS code:
var a = 0.1m; // notation is totally ad-hoc, just for the sake of the example code
var b = 0.2m;
var c = a + b;
if (c === 0.3m) {
    console.log("OK");
}

the JS output should be something like this:
    var a = new Decimal("0.1");
    var b = new Decimal("0.2");
    var c = Decimal.add(a, b);
    if (Decimal.compare(c, new Decimal("0.3") === 0) {
        console.log("OK");
    }

where Decimal is the class that implements the decimal arithmetic and conversions.
There are a number of JS decimal implementations to take inspiration from:
https://github.com/MikeMcl/decimal.js
https://github.com/MikeMcl/bignumber.js
https://www.npmjs.com/package/jsdecimal
https://github.com/iriscouch/bigdecimal.js

See TypeScript's non-goals:

Provide additional runtime functionality or libraries. Instead, use TypeScript to describe existing libraries.

As you've said:

There are a number of JS decimal implementations to take inspiration from:
https://github.com/MikeMcl/decimal.js
https://github.com/MikeMcl/bignumber.js
https://www.npmjs.com/package/jsdecimal
https://github.com/iriscouch/bigdecimal.js

As our non-goal suggests, those libraries are sufficiently usable from TypeScript itself. DefinitelyTyped currently currently has typings for decimal.js

Does Typescript have like bool.parse(), decimal.parse(), etc.?  Does Typescript have datatype conversion features?  Just wondering cuz we don't want to have baggage issues we're struggling with, from adding too many 3rd party libraries.

TypeScript doesn't provide any built-in run-time libraries.

As our non-goal suggests, those libraries should be sufficiently usable from TypeScript itself. DefinitelyTyped currently currently has typings for decimal.js

Looks like it's significantly outdated. Any alternative to this issue so far?

I found this typings
<EMAIL_ADDRESS>for this library:
https://www.npmjs.com/package/decimal.js


Using NSDate().distantPast irreversibly damages property

Using RealmSwift 0.93.2
It seems that when a property is set to NSDate.distantPast(), the year is saved as a negative value. NSDate.distantFuture() seems to work fine. Furthermore, trying to overwrite a property that once was set to NSDate.distantPast() will always be saved with a negative year value after that, the record is permanently damaged. I haven't found a way to restore a record once a value is set to NSDate.distantPast() other than deleting the complete record and recreating it again.
(Saving NSDate.distantPast().timeIntervalSince1970 as a Double shows a different unexpected behavior, it is seen as a nil and crashes queries).
Could it be that Realm's internal date format doesn't consider 0 to be a valid date?
class Record: Object {
    dynamic var startDate: NSDate = NSDate.distantPast()   // Year will be saved as a negative value
    dynamic var endDate: NSDate = NSDate.distantFuture() // This works fine, unless endDate is changed
}

...

let record = Record() // startDate is 0000-12-30 00:00:00 +0000, endDate is 4000-07-24 23:00:00 +0000
record.startDate = NSDate() // Unexpected: startDate is -2014-07-25 00:00:00 +0000 (note year is -2014, not 2015)

record.endDate = NSDate() // startDate is 2015-07-25 00:00:00 +0000
record.endDate = NSDate.distantPast() // endDate is 0000-12-30 00:00:00 +0000
record.endDate = NSDate()  // Unexpected: startDate is -2014-07-25 00:00:00 +0000 (note year is -2014, not 2015)

@ronaldmannak that's quite strange, and I'd love to be able to investigate more thoroughly -- could you possibly share a project with us, either here or privately at<EMAIL_ADDRESS>that demonstrates the issue so I can dig in? Thanks!
(I tried reproducing with the code in your comment, and here's the debugger output I saw:
(lldb) po record
Record {
	startDate = 0000-12-30 00:00:00 +0000;
	endDate = 4001-01-01 00:00:00 +0000;
}

(lldb) po record
Record {
	startDate = 2015-07-25 00:51:23 +0000;
	endDate = 4001-01-01 00:00:00 +0000;
}

(lldb) po record
Record {
	startDate = 2015-07-25 00:51:23 +0000;
	endDate = 2015-07-25 00:51:29 +0000;
}

(lldb) po record
Record {
	startDate = 2015-07-25 00:51:23 +0000;
	endDate = 0000-12-30 00:00:00 +0000;
}

(lldb) po record
Record {
	startDate = 2015-07-25 00:51:23 +0000;
	endDate = 2015-07-25 00:51:41 +0000;
}

)

I found the issue and it's unrelated to Realm. I used OSX' NSDatePicker to change the dates in the database and once you feed it NSDate.distantPast(), NSDatePicker only can go down, hence the negative years. Closing issue


Go over if we should include an app.js file instead of using the Alpine.js CDN

Go over if we should include an app.js file instead of using the Alpine.js CDN (or if we actually need app.js, which is useful mainly for offline sites), or a command/easy way to include it, maybe an easy way to disable the CDN.

See https://github.com/hydephp/develop/issues/2027

Claude Sonnet
Currently, the Alpine.js setup is handled in the following ways:

Alpine.js is loaded via CDN in the scripts layout:

{{-- Alpine.js --}}
<script defer<EMAIL_ADDRESS>integrity="sha256-gOkV4d9/FmMNEkjOzVlyM2eNAWSUXisT+1RbMTTIgXI=" crossorigin="anonymous"></script>

The app.js file is referenced in multiple places but appears to be mostly empty/unused:

/*
* This is the main JavaScript used by Vite to build the app.js file.
*/

The Vite config is set up to handle both app.css and app.js:

        rollupOptions: {
            input: [
                resolve(__dirname, 'resources/assets/app.js'),
                resolve(__dirname, 'resources/assets/app.css')
            ],
            output: {
                entryFileNames: '[name].js',
                chunkFileNames: '[name].js',
                assetFileNames: '[name].[ext]'
            }
        }

Based on the codebase analysis, here are my recommendations:

Keep the CDN as Default

The CDN approach is working well as the default option
It's fast, reliable and requires no build step
Most users won't need offline capabilities

Add Configuration Option

Add a new config option in hyde.php similar to load_app_styles_from_cdn
Something like load_alpine_from_cdn (defaulting to true)
When false, it would include a local copy of Alpine.js

Provide Local Alternative

Create a command to download Alpine.js locally:

php hyde download:alpine

This would download Alpine.js to _media/vendor/alpine.js
Update the scripts layout to check the config and use local file if CDN is disabled

Update Documentation
Add a section in the asset management docs explaining the options:

### JavaScript Assets

By default, Hyde loads Alpine.js from a CDN for optimal performance. However, if you need offline capabilities or prefer local assets:

1. Disable the CDN in config/hyde.php:
```php
'load_alpine_from_cdn' => false

Download Alpine.js locally:

php hyde download:alpine

This will serve Alpine.js from your local environment instead of the CDN.

The current app.js file seems unnecessary since:
1. The main JavaScript functionality (dark mode toggle) is already included inline
2. Alpine.js handles most interactive features
3. No other significant JavaScript appears to be needed in the core framework

Therefore, I recommend:
1. Keep the CDN as the default
2. Add configuration options for local hosting
3. Remove the empty app.js file unless specific JavaScript features are needed
4. Update documentation to clarify these choices

I think having the Alpine CDN is nice. We don't have enough scripts to need to bundle them together. Offline usage can be handled by the user if they need it. Not within the 99% use case. Instead, see https://github.com/hydephp/develop/issues/2027


Unable to Push to git in Sublime but able with the command line - Windows 7

I tried every single possible solution on this thread Push not working #98 but nothing worked. I am using Windows 7 and Sublime Text 3 with the Git plugin installed, using SSH and not HTTPS.
The issue occurs in GitHub desktop as well BUT when I use the command line everything works smoothly!
Steps to reproduce:
After cloning the project, In Sublime (ctrl+shift+p):

Git Add All
Git Commit
Git Push
When I try to push I get the following error in Sublime:

Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

In GitHub Desktop it reads:
Authentication failed. You may not have permission to access the repository. Open options and verify that you're signed in with an account that has permission to access this repository.

Troubleshoot:
git remote -v
#origin  git@github.com:barak-11/Full.git (fetch)
#origin  git@github.com:barak-11/Full.git (push)

git --version
#git version 2.14.1.windows.1

You have to add ssh key on your repository.

One solution: Delete old keys, create one without passphrase (here)

So I'm running into this issue as well.
Running Windows 10, Sublime Text 3, and Windows GIT. I found that I can push without issues via CMD or Bash (Ubuntu on Windows).
However it'll fail everytime with Sublime. HOWEVER, when I used https to clone the repo as opposed to SSH, I am able to push within sublime without issue.
I also want to note that on a separate Windows 10 computer (where I have Cygwin Installed, not Windows Git installed), I am able to push via SSH in Sublime Text 3.
So now I need to figure out how it can be possible without Cygwin and just relying on Windows Bash instead, cause I would definitely like to use SSH for the push instead of https.


Blazor WASM BFF Sample Still Allows API Requests Post Logout

After logging out of the Blazor WASM BFF sample, I'm still able to make API requests using the cookie. It seems like the cookie/underlying token aren't being invalidated. Is there something we can do to enforce this?
After someone logs out, I want the cookie/JWT to be invalidated and rejected by BFF.
Is there something we need to do on the Identity Server side to do this?

Take a look at server side sessions to give you more control over what happens to the session data at logout. If you enable server side sessions, then after logout the cookie will no longer be usable.
The reasons you're seeing this behavior are that JWTs fundamentally cannot be revoked because they are self-contained by design, and the session cookie that stores the session that contains the JWT (when server side sessions are not enabled) can't be invalidated either. Cookies are just http headers that the server uses to ask the browser to handle data in a particular way. If you keep using the cookie after the server asked you to destroy it, the cookie will still be valid unless you have some server-side data store to track sessions. That's exactly what our server side session feature provides.
I'm transferring this to support for better visibility.


Persistent connect, how-to?

The node needs to be connected manually each time the node-red service restart, e.g. after power outage,
(i have to open node-red editor, click node, click connect, click update, and click deploy)
Otherwise, the remote cards that i made on hass will not work.
Is there any solution to solve this particular problem?

which webOS version does your TV have? I fear this is ab Issue with newer webOS version (4.x?), I dont have that issue on my 4y old TV which has webOS 2 or 3 iirc... So I‘m kinda clueless because I cant test that myself... Is there any useful log output?

Problem solved!
I turned the log level to debug mode,
Apparently, we have to provide a key on credentialSecret property in settings.js to encrypt our credentials with the chosen key. (i've never check the log before)
   credentialSecret: "random-string"
By default Node-RED generates a random key for the encryption.


Allow to read and write metadata from JPEG files.

Images uploaded from phone contains metadata that makes them(the images) rendered sideway. It would be great to be able read and write metadata to prevent that issue.

https://github.com/EyalAr/lwip/issues/100


requests.exceptions.SSLError

There is a known bug that on some computers there is an SSLError that is being raised when running methods from the eurostat package.
This is usually fixed by passing verify=False to requests.
Thankfully, in version 1.1.0, the person maintaining the eurostat package added a function that allows you to set the parameters of requests.
https://bitbucket.org/noemicazzaniga/eurostat/issues/32/missing-option-to-specify-ssl-verification
This will be fixed in 0.2.1.

Should be fixed by 4d6b2c7


ModExp function: remove padding & code clean

Remove padding operation in ippsModExp function.
Let ippsMBModExp function support modulus of different bit size(in one vector).
some code clean.

@justalittlenoob Do these changes influence the input size for the accelerator interface? I'd recommend testing it with the accelerator integration branch to see if it remains functional.

@justalittlenoob Do these changes influence the input size for the accelerator interface? I'd recommend testing it with the accelerator integration branch to see if it remains functional.

Hi @fdiasmor  Thank you very much for the suggestion. I have checked it and it works fine.

@justalittlenoob Do these changes influence the input size for the accelerator interface? I'd recommend testing it with the accelerator integration branch to see if it remains functional.

Hi @fdiasmor Thank you very much for the suggestion. I have checked it and it works fine.

@justalittlenoob Awesome -- great work. Thanks for validating this compatibility.
Let's keep the accelerator branch always up-to-date and continuously monitor any degradation in performance. Perhaps we automate the performance monitoring in the CI.


nmap-vulners submodule - out of date?

Hello!
It seems the sumbodule link for your nmap-vulners is broken. Version mismatch perhaps?
caldera_pathfinder/scanners/nmap/scripts/

Thanks, we'll take a look and fix!

The link is setup for ssh pulling and not https.  I can swap it around as both are public repos, but if you also setup a ssh key with github it will pull as well.


Question: why doesn't gobuster ship with wordlists like dirb?

It might be a rookie mistake, but I always find myself downloading dirb just for their wordlists and then linking them to gobuster. Maybe we could ship gobuster with the dirb wordlists?

the wordlists are included by the distro maintainers. If you want wordlist with gobuster in kali you can open a request on https://bugs.kali.org/


Sort gemfile alphabetically

Improve readability

@brandondunne Please rebase and push again.

@chessbyte Up to date and tests are green.


fix NPE in volumes statistics

Description
If volume is migrated between storage pools and "volume.stats.interval"
is set to more frequent interval for example 30 sec.
NullPointerException is thrown, because the hypervisor is looking for
volume on storage pool from which the volume was migrated.
The statistics did not work right - before this fix only one cluster is
lists if we have more clusters from the same type (eg. KVM), and only
one host will return volume stats. Also all volumes are sent to that
host, but they could be on another host. And the logic does not work
correctly.
Also the response was not working correctly for QCOW2 images, because
it's looking for volume's UUID, but in the statistics CS keeps the path
(because of the migrated volumes which UUIDs are changed).
We have discussed the NPE with @Spaceman1984 in PR https://github.com/apache/cloudstack/pull/3949

With this change all clusters will be listed even those with the same type. Host will receive only the active volumes which are on it. And in the logs we will receive a proper information about the volumes
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X ] Bug fix (non-breaking change which fixes an issue)
[ X] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?
CS versions - 4.14 and master
2 clusters each having 2 hosts
hypervisors KVM
2 NFS primary storages with scope Zone

similar issue as #3884 #3878

@sureshanaparti all your concerns addressed?

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2214

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-3018)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38770 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4388-t3018-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 83 look OK, 2 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Failure
310.76
test_vpc_redundant.py

test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers
Failure
297.25
test_vpc_redundant.py

test_hostha_kvm_host_fencing
Error
175.40
test_hostha_kvm.py

@weizhouapache is this lgty?

@slavkap can you fix the conflict?

@blueorangutan package

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2304

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-3104)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32733 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4388-t3104-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_04_rvpc_privategw_static_routes
Failure
241.03
test_privategw_acl.py

@slavkap there are travis errors can you look at that and provide test report/results, please?
I'm not sure why (yet) but the 4.13 integrations fail all around.

Considering that the milestone is 4.15 and this PR was manually tested at 4.14, maybe the best would be moving this to 4.14 or 4.15.
What do you think @slavkap @DaanHoogland?

I'm ok to move it to 4.14, but I'm not sure how those changes are related to VPC. Here is the failure:
    "Ping to VM on Network Tier N from VM in Network Tier A should be successful at least for 2 out of 3 VMs"

I'm ok to move it to 4.14, but I'm not sure how those changes are related to VPC. Here is the failure:
 "Ping to VM on Network Tier N from VM in Network Tier A should be successful at least for 2 out of 3 VMs"

those can be due to a busy system, @slavkap. I don't think these can be related to your changes, but we can re-run if you want to be sure.
note that the tests nine days ago showed different failures.

I just re-kicked Travis checks.

Thanks @GabrielBrascher ! @DaanHoogland I saw some of those failures from nine days ago in another PR of mine, but didn't find the zip with the results

Just checked, it seems that the errors are related to Travis running JDK 11 CloudStack 4.13 uses Java 8.

There was a missing import in one of the classes

Nice! Travis is also running with jdk 8 now.

Thank you all for the time you spent!

code LGTM, haven't tested. Please ensure these changes doesn't cause any regression for managed / unmanaged / local storage.

@sureshanaparti please explain your concerns or ensure what you can? I'm am trusting @slavkap to have validated any configuration she has access too. If you know what to do more please do so or ping the people that can. If we leave it at this I'm pretty sure no follow up will happen.

code LGTM, haven't tested. Please ensure these changes doesn't cause any regression for managed / unmanaged / local storage.

@sureshanaparti please explain your concerns or ensure what you can? I'm am trusting @slavkap to have validated any configuration she has access too. If you know what to do more please do so or ping the people that can. If we leave it at this I'm pretty sure no follow up will happen.

@DaanHoogland the code changes will impact the volume stats for all storage pools. So, it is better if this can be tested with volume(s) on unmanaged, managed and local storage. Otherwise, can cause regression.

code LGTM, haven't tested. Please ensure these changes doesn't cause any regression for managed / unmanaged / local storage.

@sureshanaparti please explain your concerns or ensure what you can? I'm am trusting @slavkap to have validated any configuration she has access too. If you know what to do more please do so or ping the people that can. If we leave it at this I'm pretty sure no follow up will happen.

@DaanHoogland the code changes will impact the volume stats for all storage pools. So, it is better if this can be tested with volume(s) on unmanaged, managed and local storage. Otherwise, can cause regression.

I understood that, @sureshanaparti. But by who and how should this be tested to appease your concerns.
@slavkap, can you explain more about your testing. You claim you have tested with zone wide NFS storage.

Is that all?
have you tested with more types of environement? Or have you @GabrielBrascher ?
is there any reason to think we don't need to test local - or managed storage , @slavkap ?

tnx all

@DaanHoogland @sureshanaparti I have tested it only with non managed storage on StorPool and NFS (on master and 4.14) with 2 clusters each having 2 KVM hypervisors. I'm setting now a dev environment with 4.13 and will test with managed (on NFS) and non managed (on NFS  and StorPool) storage. About local storage - how should it be set managed/unmanaged? If there is somebody that could test this with OVA files will be appreciated

actually what I see is that NFS with default logic is only non managed storage. I can test this only with StorPool (which is non managed) and NFS

I've tested it now with non-managed NFS (zone-wide) and local (scope - host) storage on 4.13, and it works correct without any failures and when I get volume stats it shows the right information in logs
local storage:
'3', 'cloudstack-cl3-hv2-local-0270e029', '0270e029-baa4-4006-9834-cf5a5bc92851', 'Filesystem', '0', '1', '1', '1', '4392984576', '273804165120', '<IP_ADDRESS>', NULL, '/var/lib/libvirt/images', '2020-10-30 10:57:10', NULL, NULL, 'Up', 'DefaultPrimary', 'HOST', NULL, '0', NULL
volume on local storage:
'10', '2', '1', '3', NULL, '10', '0', 'ROOT-10', 'cd875374-ef02-409b-b6da-87adae43b0ee', '8589934592', NULL, 'cd875374-ef02-409b-b6da-87adae43b0ee', NULL, '1', NULL, NULL, 'ROOT', NULL, '17', '4', NULL, '0', '2020-10-30 10:59:31', NULL, '2020-10-30 10:59:39', NULL, 'Ready', NULL, '2', NULL, NULL, NULL, '1', 'QCOW2', NULL, NULL, NULL, 'thin'
response when list volume
DEBUG [c.c.a.ApiServlet] (qtp873447850-307:ctx-ba1bf0cc ctx-f62d604f) (logid:52b44185) ===END===  <IP_ADDRESS> -- GET  command=listVolumes&id=cd875374-ef02-409b-b6da-87adae43b0ee&response=json&_=1604055433757
NFS storage:
'1', 'primary', '95d3f971-b75a-3e1d-a225-09037d2fa9f2', 'NetworkFilesystem', '2049', '1', NULL, NULL, '146331926528', '214736830464', '<IP_ADDRESS>', NULL, '/export/primary-13', '2020-10-30 10:22:01', NULL, NULL, 'Up', 'DefaultPrimary', 'ZONE', 'KVM', '0', NULL
volume on NFS:
'6', '2', '1', '1', NULL, '6', '0', 'ROOT-6', 'c86634ca-0c01-427c-b374-f6bf908f9869', '8589934592', NULL, 'c86634ca-0c01-427c-b374-f6bf908f9869', NULL, '1', NULL, NULL, 'ROOT', NULL, '1', '4', NULL, '0', '2020-10-30 10:50:05', NULL, '2020-10-30 10:50:43', NULL, 'Ready', NULL, '2', NULL, NULL, NULL, '1', 'QCOW2', NULL, NULL, NULL, 'thin'
response when list volume:
DEBUG [c.c.a.ApiServlet] (qtp873447850-307:ctx-b300c496 ctx-0a2259ab) (logid:117df4a9) ===END===  <IP_ADDRESS> -- GET  command=listVolumes&id=c86634ca-0c01-427c-b374-f6bf908f9869&response=json&_=1604055433758
I'm not sure that I should mentioned it here about another problem during the setup of CS with 4.13. I have to do more tests, but I couldn't create guest network for zone with basic network. I saw that @GabrielBrascher have added this functionality
`    /**
* Encodes VLAN/VXLAN ID into a Broadcast URI according to the isolation method from the Physical Network.
* @return Broadcast URI, e.g. 'vlan://vlan_ID' or 'vxlan://vlxan_ID'
*/
protected URI encodeVlanIdIntoBroadcastUri(String vlanId, PhysicalNetwork pNtwk) {
if (pNtwk == null) {
throw new InvalidParameterValueException(String.format("Failed to encode VLAN/VXLAN %s into a Broadcast URI. Physical Network cannot be null.", vlanId));
}
    if(StringUtils.isNotBlank(pNtwk.getIsolationMethods().get(0))) {
        String isolationMethod = pNtwk.getIsolationMethods().get(0).toLowerCase();
        String vxlan = BroadcastDomainType.Vxlan.toString().toLowerCase();
        if(isolationMethod.equals(vxlan)) {
            return BroadcastDomainType.encodeStringIntoBroadcastUri(vlanId, BroadcastDomainType.Vxlan);
        }
    }
    return BroadcastDomainType.fromString(vlanId);
}`

but the list with isolation methods was empty in my case (during debug I've set one element to empty string and it worked).

code LGTM, haven't tested. Please ensure these changes doesn't cause any regression for managed / unmanaged / local storage.

@sureshanaparti please explain your concerns or ensure what you can? I'm am trusting @slavkap to have validated any configuration she has access too. If you know what to do more please do so or ping the people that can. If we leave it at this I'm pretty sure no follow up will happen.

@DaanHoogland the code changes will impact the volume stats for all storage pools. So, it is better if this can be tested with volume(s) on unmanaged, managed and local storage. Otherwise, can cause regression.

I understood that, @sureshanaparti. But by who and how should this be tested to appease your concerns.
@slavkap, can you explain more about your testing. You claim you have tested with zone wide NFS storage.

Is that all?
have you tested with more types of environement? Or have you @GabrielBrascher ?
is there any reason to think we don't need to test local - or managed storage , @slavkap ?

tnx all

is there any reason to think we don't need to test local - or managed storage , @slavkap ?

is there any reason to think we don't need to test local - or managed storage , @slavkap ?

I think it has to be tested with managed storage, but our storage does not support this functionality.  In this change for manged/local storage I think it will work as before, the only difference is that GetVolumeStats task will list all clusters in the zone even their hypervisors are from the same type.
 for (final Cluster cluster : _clusterDao.listClustersByDcId(pool.getDataCenterId()))
and GetVolumeStatsCommand will be send to all hosts, not only to the first which gets an answer like the old implementation:

        for (HostVO neighbor : neighbors) {
            // apply filters:
            // - managed storage
            // - local storage
            if (storagePool.isManaged() || storagePool.isLocal()) {

                volumeLocators = getVolumesByHost(neighbor, storagePool);

            }

            // - zone wide storage for specific hypervisortypes
            if (ScopeType.ZONE.equals(storagePool.getScope()) && storagePool.getHypervisor() != neighbor.getHypervisorType()) {
                // skip this neighbour if their hypervisor type is not the same as that of the store
                continue;
            }

            GetVolumeStatsCommand cmd = new GetVolumeStatsCommand(poolType, poolUuid, volumeLocators);

            if (timeout > 0) {
                cmd.setWait(timeout/1000);
            }

            Answer answer = _agentMgr.easySend(neighbor.getId(), cmd);

            if (answer instanceof GetVolumeStatsAnswer){
                GetVolumeStatsAnswer volstats = (GetVolumeStatsAnswer)answer;
                return volstats.getVolumeStats();
            }
        }

I've tested it now with non-managed NFS (zone-wide) and local (scope - host) storage on 4.13, and it works correct without any failures and when I get volume stats it shows the right information in logs
local storage:
'3', 'cloudstack-cl3-hv2-local-0270e029', '0270e029-baa4-4006-9834-cf5a5bc92851', 'Filesystem', '0', '1', '1', '1', '4392984576', '273804165120', 'host', NULL, '/var/lib/libvirt/images', '2020-10-30 10:57:10', NULL, NULL, 'Up', 'DefaultPrimary', 'HOST', NULL, '0', NULL
volume on local storage:
'10', '2', '1', '3', NULL, '10', '0', 'ROOT-10', 'cd875374-ef02-409b-b6da-87adae43b0ee', '8589934592', NULL, 'cd875374-ef02-409b-b6da-87adae43b0ee', NULL, '1', NULL, NULL, 'ROOT', NULL, '17', '4', NULL, '0', '2020-10-30 10:59:31', NULL, '2020-10-30 10:59:39', NULL, 'Ready', NULL, '2', NULL, NULL, NULL, '1', 'QCOW2', NULL, NULL, NULL, 'thin'
response when list volume
DEBUG [c.c.a.ApiServlet] (qtp873447850-307:ctx-ba1bf0cc ctx-f62d604f) (logid:52b44185) ===END=== host -- GET command=listVolumes&id=cd875374-ef02-409b-b6da-87adae43b0ee&response=json&_=1604055433757
NFS storage:
'1', 'primary', '95d3f971-b75a-3e1d-a225-09037d2fa9f2', 'NetworkFilesystem', '2049', '1', NULL, NULL, '146331926528', '214736830464', 'host4', NULL, '/export/primary-13', '2020-10-30 10:22:01', NULL, NULL, 'Up', 'DefaultPrimary', 'ZONE', 'KVM', '0', NULL
volume on NFS:
'6', '2', '1', '1', NULL, '6', '0', 'ROOT-6', 'c86634ca-0c01-427c-b374-f6bf908f9869', '8589934592', NULL, 'c86634ca-0c01-427c-b374-f6bf908f9869', NULL, '1', NULL, NULL, 'ROOT', NULL, '1', '4', NULL, '0', '2020-10-30 10:50:05', NULL, '2020-10-30 10:50:43', NULL, 'Ready', NULL, '2', NULL, NULL, NULL, '1', 'QCOW2', NULL, NULL, NULL, 'thin'
response when list volume:
DEBUG [c.c.a.ApiServlet] (qtp873447850-307:ctx-b300c496 ctx-0a2259ab) (logid:117df4a9) ===END=== host -- GET command=listVolumes&id=c86634ca-0c01-427c-b374-f6bf908f9869&response=json&_=1604055433758
I'm not sure that I should mentioned it here about another problem during the setup of CS with 4.13. I have to do more tests, but I couldn't create guest network for zone with basic network. I saw that @GabrielBrascher have added this functionality
   /**
     * Encodes VLAN/VXLAN ID into a Broadcast URI according to the isolation method from the Physical Network.
     * @return Broadcast URI, e.g. 'vlan://vlan_ID' or 'vxlan://vlxan_ID'
     */
    protected URI encodeVlanIdIntoBroadcastUri(String vlanId, PhysicalNetwork pNtwk) {
        if (pNtwk == null) {
            throw new InvalidParameterValueException(String.format("Failed to encode VLAN/VXLAN %s into a Broadcast URI. Physical Network cannot be null.", vlanId));
        }

        if(StringUtils.isNotBlank(pNtwk.getIsolationMethods().get(0))) {
            String isolationMethod = pNtwk.getIsolationMethods().get(0).toLowerCase();
            String vxlan = BroadcastDomainType.Vxlan.toString().toLowerCase();
            if(isolationMethod.equals(vxlan)) {
                return BroadcastDomainType.encodeStringIntoBroadcastUri(vlanId, BroadcastDomainType.Vxlan);
            }
        }
        return BroadcastDomainType.fromString(vlanId);
    }

but the list with isolation methods was empty in my case (during debug I've set one element to empty string and it worked).

@slavkap thanks for sharing the test results, which confirms the changes are good with NFS and local storages. As local and managed storage took the same path earlier, this should work for managed as well.

great. i'll merge and merge forward

thank you all for the code review and your time!


Screen tearing workaround

On some platforms, e.g. Bittboy, frequent display refreshing causes visual artifacts to appear. As the game does not involve animations, would it be possible to redraw screen only on certain events, e.g. user input or timer tick? It would make easier to port the game for such platforms and would lower CPU and battery usage.

In SDL 1.2, the internal framebuffer is not supposed to refresh until a call to SDL_Flip (for hardware surfaces) or SDL_UpdateRect (for software surfaces), which in Shisen-Seki (and my other games) happens only after all the rendering for the given frame has been completed. If your platform updates the screen mid-frame, it implies its SDL backend must be broken. Please make sure the screen surface has been initialized with SDL_SWSURFACE if you are not using double buffering.
Regardless of that, I agree with you that there is no need for Shisen-Seki to run at a fixed framerate, so I made experimental changes to decouple gameplay from framerate. You can find them in "adaptive_framerate" branch. Let me know if it improves performance for you.

Menu seems to be working fine. Game screen is like before, the behaviour is dependent on cursor position. For most of them, the screen tears as always. For a few of them it seems to be fine. I would not consider this fix a definite solution to the problem.

Speaking of SDL_SWSURFACE, turning it on solves the problem. The game timer gets slower but at the moment I do not consider it a major issue. Thanks for help :)

Is the game timer accurate now, or is it running slower than a real clock?
If it's the latter and you also run the game without -DADAPTIVE_FRAMERATE, that would suggest your hardware is too slow to render 60 frames per second.

When adaptive framerate is on, SetVideoMode() flags are SDL_HWSURFACE and SDL_DOUBLEBUF, I believe the timer is fine. I am not sure, because I did not pay attention to it, but I think I would notice that something is wrong.
When adaptive framerate is off and SetVideoMode() flag is SDL_SWSURFACE, the display is fine but the timer is running slower than a real clock.

I did not test adaptive framerate with swsurface on, but I believe it could cause timing fluctuations caused by the behaviour described earlier. For your information, Bittboy runs many games and emulators, many of them works at 60 fps. I had similar issue with your other game (Homing Fever) and I believe it is caused by inaccuracy of framerate limiter (it needs to be enabled for Bittboy).

I had similar issue with your other game (Homing Fever) and I believe it is caused by inaccuracy of framerate limiter (it needs to be enabled for Bittboy).

It seems to be some kind of a bug on Bittboy itself. Usually it is enough to restart the program or game to run it at normal speed.
I think I can close the issue as SDL_SWSURFACE solves my problem.


autoMuteThreshold = 0 - Still join with unmuted mic

I have autoMuteThreshold = 0, but all user still join with mic enabled.. what am i doing wrong?
Tested from Chrome, Edge and iPhone.

It is a bug. I will fix it.

Please get the newest develop, it should be fixed. If not, reopen this issue.


Tags & Notes feature retired

Apart from the features mentioned, Tags & Notes are also deprecated/removed, as decribed in this SPO article:
https://support.office.com/en-us/article/SharePoint-Online-Tags-Notes-feature-retired-77851BD5-6D5E-42FE-9BF6-D7C17EEB771F
Particularly: you can still add the web parts, but they will render completely blank.
The 2016 article actually contains a hint, that this would be removed in 2019:
https://docs.microsoft.com/en-us/sharepoint/what-s-new/what-s-deprecated-or-removed-from-sharepoint-server-2016
"The Tags and Notes feature is deprecated in SharePoint Server 2016. This means that users can still create new tags and notes and access any existing ones. However, we don't recommend using this feature because it will be removed in the next release."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0d5144c0-b2a7-8fce-e915-28b0e7f44ca0
Version Independent ID: 3558508e-be15-dfec-5c98-6f2f7e5cba63
Content: What's deprecated or removed from SharePoint Server 2019
Content Source: SharePoint/SharePointServer/what-s-new/what-s-deprecated-or-removed-from-SharePoint-Server-2019.md
Product: sharepoint-server-itpro
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

@toskr Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@scanum assign to me.

Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


I Need Rosbag !!!!!!!!!!!!!!!!!!!!

i really need help.Datasets and rosbags are not available to download.But i need a rosbag using landmark to relocalization.
I really need! Thank you very much!


fix parsing of container id in container in container environments

Fixes https://github.com/neuvector/neuvector/issues/1277

It is a no-harm PR and will fix its issue 1277. However, it is from a community k3s version on the "k3s-docker". The official rancher supports k3s on the "k3s-containerd".
It changes its search direction from the end. It will get the expected "sandbox" ID that which is the best unique ID can be obtained from its root process.


chore: Save e2e outputs to oci artifacts

Description
TSIA
Issue ticket number and link
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/retest

@flacatus is there a joint change that needs to also happen on the qe definitions side to make sure that these two files get collected?

@Dannyb48 no changes need in qe definitions

/retest

/retest


Revert "Cache the hosted directory under .pub-cache instead of all of .pub-cache

This reverts commit 0cfd3dec239faf3c13ce759df15ddab226545e8c.

LGTM


Added functionality for tokens

Added functionality for Tokens. Example in example-switch-with-token.py
Only the mystrom switch is tested.

Changes are applied to init.py.

Are there any plans to get this merged?


Spread is_live for NetApp tests

(message created by the CI based on PR content)

Codecov Report

Merging #5174 into master will decrease coverage by 3.98%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5174      +/-   ##
==========================================
- Coverage   52.98%      49%   -3.99%
==========================================
  Files       10851     6509    -4342
  Lines      227682   182592   -45090
==========================================
- Hits       120636    89476   -31160
+ Misses     107046    93116   -13930

Impacted Files
Coverage Δ

...afactory/azure/mgmt/datafactory/models/__init__.py
50.67% <0%> (-49.33%)
:arrow_down:

...ights/azure/applicationinsights/models/__init__.py
51% <0%> (-49%)
:arrow_down:

...e/cognitiveservices/vision/face/models/__init__.py
51.08% <0%> (-48.92%)
:arrow_down:

...services/language/textanalytics/models/__init__.py
51.16% <0%> (-48.84%)
:arrow_down:

...iveservices/search/entitysearch/models/__init__.py
51.25% <0%> (-48.75%)
:arrow_down:

azure-eventgrid/azure/eventgrid/models/__init__.py
51.25% <0%> (-48.75%)
:arrow_down:

...ration/azure/mgmt/datamigration/models/__init__.py
51.27% <0%> (-48.73%)
:arrow_down:

...ure/mgmt/recoveryservicesbackup/models/__init__.py
51.46% <0%> (-48.54%)
:arrow_down:

...ce/azure/mgmt/containerinstance/models/__init__.py
51.8% <0%> (-48.2%)
:arrow_down:

...tiveservices/search/videosearch/models/__init__.py
52.08% <0%> (-47.92%)
:arrow_down:

... and 4428 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1bc67...3aa2578. Read the comment docs.


Typing for innerRef does not support React 16 RefObject

Typescript throws an error when trying to use React 16's new RefObject with innerRef. Example:
const ref = React.createRef();
<StyledComponent innerRef={ref}/>
// Types of property 'innerRef' are incompatible.
// Type 'RefObject<any>' is not assignable to type '(instance: any) => void'.

The offending line appears to be: https://github.com/styled-components/styled-components/blob/6cff64644d22e447504e917ffed4bffdf8c93b5e/typings/styled-components.d.ts#L15
It should probably be: innerRef?: Ref<any>;

Could I try my hands on this to familiarize myself with the styled-components codebase?

I believe there is already a PR for this?
On Sun, May 6, 2018 at 7:07 PM Chak Shun Yu<EMAIL_ADDRESS>wrote:

Could I try my hands on this to familiarize myself with the
styled-components codebase?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/1695#issuecomment-386923830,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAiy1gUgkHSdyuJdEN-ETs_rMNVUH9UWks5tv4IigaJpZM4TaeTP
.

Oh yeah I think #1711

That's correct. Feel free to improve these typing, if possible. Thanks for reporting!


[GHSA-gcx4-mw62-g8wm] DOM Clobbering Gadget found in rollup bundled scripts that leads to XSS

Updates

Affected products
CVSS v3

Comments
Melhorias

Hi there @lukastaegert! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory


trace.py: improve add_events_deltas()

It's completely untested as my next branch is screwed up at the moment.

Okay. I'm afraid I didn't dig deep enough into how this function is used and by the face value of it I don't expect shifts etc. I'd rather drop this and let you guys handle it then :-)


Generate full pdbs for desktop packages

Fixes #1548

We need to port this to rel/15.3 also

Ported to 15.3 here: https://github.com/aspnet/Razor/commit/e30b09f08e554e0b860d8e1fdf4dd9e08e6f5293


Issue: Failed to Load Config: RuleID Missing (Starting Sept 15th, 2024)

Hi team - starting from 15th Sept 2024 we are seeing the below exception and couldn't run GitLeaks on GitHub repos.
Can you please look into it, and fix it?
Starting: Detect Secrets
==============================================================================
Task         : Gitleaks scan
Description  : Scan git repos (or files) for secrets using regex and entropy.
Version      : 2.9.0
Author       : Joost Voskuil<EMAIL_ADDRESS>Help         : [More information](https://github.com/JoostVoskuil/azure-devops-gitleaks)
==============================================================================
Thanks to Zachary Rice (https://github.com/zricethezav) for creating and maintaining gitleaks.
Thanks to Jesse Houwing (https://github.com/jessehouwing) for providing a gitleaks config that has most of Microsoft's deprecated credscan rules ported to it.

Only commits are scanned that are ommited between this build and the previous build with a max of 1000 commits.
Scanning for 1 Git commit(s) for this build.
The latest version of Gitleaks (8.19.1) must be downloaded...
Downloading: https://github.com/zricethezav/gitleaks/releases/download/v8.19.1/gitleaks_8.19.1_windows_x64.zip
Extracting archive
C:\Windows\system32\chcp.com 65001
Active code page: 65001
C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe -NoLogo -Sta -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command "$ErrorActionPreference = 'Stop' ; try { Add-Type -AssemblyName System.IO.Compression.FileSystem } catch { } ; [System.IO.Compression.ZipFile]::ExtractToDirectory('C:\AzureDevOpsAgent\_work\_temp\b9765b7c-574e-41c9-a2ca-d0628a043980', 'C:\AzureDevOpsAgent\_work\_temp\21b69363-87d9-4ce0-8fcc-893949b121f7')"
Caching tool: gitleaks 8.19.1 x64
C:\AzureDevOpsAgent\_work\_tool\gitleaks\8.19.1\x64\gitleaks.exe detect --config=C:\AzureDevOpsAgent\_work\_tasks\Gitleaks_11bd67d8-bfe7-497b-967d-e800eb673119\2.9.0\configs\UDMSecretChecksv8.toml --source=C:\AzureDevOpsAgent\_work\23\s "--log-opts=e4ca616cb93a1446b9a4a3c266015e8f84acb8cc^! e4ca616cb93a1446b9a4a3c266015e8f84acb8cc" --redact --report-format=sarif --report-path=C:\AzureDevOpsAgent\_work\_temp\gitleaks-report-a9c19ea1-cc59-50ca-acc6-ed87a2323e25.sarif --exit-code=99

    ○
    │╲
    │ ○
    ○ ░
    ░    gitleaks

6:01AM FTL Failed to load config error="rule |id| is missing or empty, regex: (?i)(?:AccessToken|pat|token).*?[':=\"][a-z0-9/+]{70}==(?:'|\"|\\s|[\\r?\\n]+)"

The Task we are using is below and working as expected for the last 2+ years.
      - task: Gitleaks@2
        inputs:
          scanlocation: "$(Build.SourcesDirectory)"
          configtype: "predefined"
          predefinedconfigfile: "UDMSecretChecksv8.toml"
          scanmode: "${{ parameters.scanmode }}"
          taskfail: "${{ parameters.taskfail }}"
          reportformat: "sarif"
          verbose: true
        enabled: ${{ parameters.enabled }}
        displayName: "Detect Secrets"

6:01AM FTL Failed to load config error="rule |id| is missing or empty, regex: (?i)(?:AccessToken|pat|token).*?[':="][a-z0-9/+]{70}==(?:'|"|\s|[\r?\n]+)"
One of your custom rules appears to lack an |id| field.

Same issue with gitleaks_8.19.1 on azure devops

Same issue here, on all our projects, after version  8.19.1. The Issue occurs even when not using custom file. The 8.18.4 version works with custome .toml or with the standard .toml file, without issues.

We use a toml file in our repo to extend the default configuration, like mentioned in the PR I believe to cause this issue: https://github.com/gitleaks/gitleaks/pull/1463
As an example, our "local" config looks like this:
`[extend]
useDefault will extend the base configuration with the default gitleaks config:
https://github.com/zricethezav/gitleaks/blob/master/config/gitleaks.toml
useDefault = true
An array of tables that contain information that define instructions
on how to detect secrets
[[rules]]
id = "generic-api-key"
[rules.allowlist]
description = "False positive. Keys used for colors match the rule, and should be excluded."
files = ['''Some_Files.xaml''']`
In this case, the generic-api-key rule incorrectly flagged some of our hex-defined colors in a XAML file. Since the update, we now get this error:
FTL Failed to load config error="generic-api-key: both |regex| and |path| are empty, this rule will have no effect"
But... the [id] isn't empty?

In previous runs, this was the output from gitleaks:
1:01AM DBG using existing gitleaks config /repo/.gitleaks.toml from `(--source)/.gitleaks.toml`
1:01AM DBG extending config with default config
1:01AM DBG found .gitleaksignore file: /repo/.gitleaksignore
1:01AM DBG executing: /usr/bin/git -C /repo log -p -U0 --full-history --all
1:49AM INF 845 commits scanned.

In the new one that failed:
1:04AM DBG using existing gitleaks config /repo/.gitleaks.toml from `(--source)/.gitleaks.toml`
1:04AM FTL Failed to load config error="generic-api-key: both |regex| and |path| are empty, this rule will have no effect"

Could it be that the extension of the config isn't working, or happening "soon enough"?

Thanks for the additional info @ektosgit & @celloza. I'll take a look.

hei @rgmz sorry, i got over my head in here and forgot to give more infos. The issue is on my side the same as posted in the first comment.

Seems like this will fix my issue too, especially the validation of the ID

hei @rgmz, thank you for #1509 should this be a permanent solution, or there will be a "bugfix" release comming this week?

hei @rgmz sorry, i got over my head in here and forgot to give more infos. The issue is on my side the same as posted in the first comment. This are azure devOps pipelines.

Ah, I didn't realize the GitLeaks scan was a public third-party one and not something custom-built by OP.
There appears to be an unfortunate typo in the config. I've opened a pull request to fix it.
[[rules]]
-d = "CSCAN0240 2"
+id = "CSCAN0240 2"
description = "VstsPersonalAccessToken 2"

https://github.com/JoostVoskuil/azure-devops-gitleaks/blob/efb961dc7ca32664aaac795cd160920d449a00fc/task/v2/configs/UDMSecretChecksv8.toml#L261-L262

cut a new release here https://github.com/gitleaks/gitleaks/releases/tag/v8.19.2
will work on getting validation logic working with extended configs

cut a new release here https://github.com/gitleaks/gitleaks/releases/tag/v8.19.2
will work on getting validation logic working with extended configs

Fix solves our problem... thanks.

waiting to close until https://github.com/JoostVoskuil/azure-devops-gitleaks/pull/87

Working on it. Will fix it tonight

Getting same issue with the GitLeaks Azure DevOps extension 2.0.282 (Latest).

New version of the Azure DevOps Extension is deployed to the marketplace. Sorry for the typo, no idea how that sneaked in months ago. Thanx @rgmz for the PR. And btw. it is not custom build. The extension is just a wrapper, nothing more + a customized toml file to replace credscan.
We really need to get rid of the customised toml file, now it is manually merging the two toml files.
@zricethezav you can close this one.

Thanks, team - confirmed that the tool is working as expected after the fix PR.

Thank you all for jumping on this so fast. Confirmed it is fixed now.
I just wish Microsoft was just as quick at fixing their problems...
Just goes to show Open Source people are the best out there!


Add experimental to the build script

Problem
We want to be able to try experimental work on no-player without affecting the develop branch. This should allow anyone to create a branch and PR it against an experimental branch, on merging this should be released to our private bintray repository.
Solution
Add experiment to the build script. The CI work is almost done too.
Paired with
@mr-archano helped me sort out the CI for this work.

test this

Can I haz merge @mr-archano @juankysoriano 😄 I want to try it out 👅


python38Packages.fastecdsa: 2.2.2 -> 2.2.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.fastecdsa is: "Fast elliptic curve digital signatures"
meta.homepage for python38Packages.fastecdsa is: "https://github.com/AntonKueltz/fastecdsa"
meta.changelog for python38Packages.fastecdsa is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.2.3 with grep in /nix/store/dci599y6g3hdnz0iqaxciaxx241d3pzp-python3.8-fastecdsa-2.2.3

found 2.2.3 in filename of file in /nix/store/dci599y6g3hdnz0iqaxciaxx241d3pzp-python3.8-fastecdsa-2.2.3

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
docbookrx
python38Packages.fastecdsa
python39Packages.fastecdsa

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dci599y6g3hdnz0iqaxciaxx241d3pzp-python3.8-fastecdsa-2.2.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.fastecdsa https://github.com/r-ryantm/nixpkgs/archive/40adb624e0ccadae3f0b16cb058469d0ba3fbfbe.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dci599y6g3hdnz0iqaxciaxx241d3pzp-python3.8-fastecdsa-2.2.3
ls -la /nix/store/dci599y6g3hdnz0iqaxciaxx241d3pzp-python3.8-fastecdsa-2.2.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python38Packages.fastecdsa
python39Packages.fastecdsa

Maintainer pings
cc @prusnak for testing.

Part of https://github.com/NixOS/nixpkgs/pull/149301


Class name in xml should not be case sensitive

description_empty shows an error when the class name is lowercase in my code, but uppercase in the xml.

is the error also present when running abaplint via command line?
try closing and opening the folder again in vscode?

I found out this is related to having multiple folders open in vscode. If I only open one folder, the error disappears.


Integration with a custom program

Hi, i am working on a piece of software to manadge a palletizing robot solution and, since i don't want to reinvent the wheel, i was thinking about using Stack Builder to handle the pallet composition part. the only information i found is a faq refering to some example xml files.

How can i get more information about this topic?
By the way awesome work with this tool

How can i have more informations about the web service?

I'm also curious about the other integration tools you provide. Where can I find more information?

The web service installer can be downloaded from here.
It's price shuld you use the software is 500€.
How to consume the WCF web service.
How to deploy the web service.

Thanks! Got it running! Since we use an web based application written in Javascript I need to find a way to connect to this service.
What do you mean with the price of €500? This project is open source right?

The WCF service installer is not provided within the GitHub repository. Hence, it is not open-source but I guess you can recompile it.


slow website loading

Describe the bug

Image loading is very slow in this website. I can make it faster
Expected behavior

A good website should have minimum loading time.
Screenshots

This website is underperforming
Additional context(if any)
Are you contributing under any open-source program ?

Apertre

Please Assign me

@abhraneel2004  can you describe how you want to solve this issue

@abhraneel2004 can you describe how you want to solve this issue

I can do that by replacing all the jpg and png with webp this will reduce the size of the website images and will load faster than current version.
for SEO I will add meta tags and change/add the necessary alt tag messages

@abhraneel2004  ok!


Updating the Documentation across various sources for workshop readiness

Updated out of date websites on readthedocs main page

When we have phase_constraint in be sure to update the README and ReadTheDocs - "The Phase Constraint Calculator provides a simple interface for calculating the JWST observation start window. The calculation currently only applies to transits, though one can subtract 0.5 from the phase values to compute the eclipse observation start window for planets on circular orbits.  Enter the minimum and maximum phase values into the APT special requirements section when planning your observations. " (The current blurb for the webpage but do double check on the production version.)

@catherine-martlin At yesterday's rehearsal we said that we are going to try to get the 1.0 release out by the end of the day today.  Is there anything more to do on this PR?  If so, let me know if there is anything I can do to help.

@bourque - This is ready for review - I should have taken care of the merge conflicts with master and most changes are to the text so if you do a test on tlexo hopefully things will run the same as they do for current Master.

Sounds good.  I will also test out the sphinx build and make sure ReadTheDocs is working.

This all looks good when running the web app locally, and making the sphinx docs locally.
I am having trouble getting this to build in ReadTheDocs since the RTD build expects there to be an existing EXOCTK_DATA directory.  I'm currently trying to find clever ways to get around that.

Thank you for looking into that @bourque - I haven't had to test on tlexo yet so didn't realize that issue!

Ok, I think I fixed the ReadTheDocs build by modifying utils.py to avoid checking for the EXOCTK_DATA variable when being executed on the RTD servers (this is akin to checking if the code is bring run on travis servers).
To summarize:

This README looks good to me
The web app looks good to me when running locally
The web app looks good to me when running from the test server
The ReadTheDocs page looks good to me (now that its actually building)
All links everywhere seems to be working

The only thing I am a bit concerned about was that the rebasing on this branch seemed to make it appear that a lot of files are changing with the PR.  But since that rebase happened this morning, I think it is fine?  Perhaps @julesfowler can comment on that.
I would like @julesfowler to give this a look over to make sure I am not missing anything, if that is OK.  They can push the merge button if everything looks fine.

I definitely agree on having Jules check the rebase - I agree with you that I think all the files it's counting as changing are actually just files created in your and Jenny's PRs. The only conflicts I hit while rebasing were in the README and it was because I added in some of the info you (Matthew) then added in yourself in your PR so it was just two copies of the same info in the README.

Changes to the readme look good. I'm going to check nothing is different than master due to the rebase trickery now.

@catherine-martlin @bourque Our readthedocs still say they are running v0.4.0. What do we need to do to have it read for our 1.0 release?

@julesfowler We will have to update utils.py to use 1.0 as the version number,  instead of 0.4, when we are ready.

@catherine-martlin If you could address the small content changes by tomorrow, that would be great. Or I will do so tomorrow.


Avhievement Checklist not working

First of all, than you for the achievements checklist page. It's the best way to track my EU4 achievements by far.
As the title says, when I click the link to the page it doesn't work. The browser opens a new tab that gives me this error:
"Application error
An error occurred in the application and your page could not be served. If you are the application owner, check your logs for details. You can do this from the Heroku CLI with the command
heroku logs --tail"
Hope you can fix it because as I said your solution is the best, easiest and more comfortable way to keep achievements under control. A lot of thanks in advance! :)

Hi! Thanks, I did not even know that this website is used by anyone but me :) I always want to finish it up and share it, but somehow I never got around to do that.
I've checked and the other deployment is still working: https://eu4achievementchecklist.azurewebsites.net
I want to use this in the long run, so I will not fix the one ending with .herukoapp.com. I've changed the description too on the Github page, so now it will link to the working one.

Tahnk you so much! :D


[BUG] Outlaw homesteads

If you know which mod might be creating this bug so I can remove it from installation that would help a lot. Tiara is causing outlaw homesteads to not spawn anything at all and it gets you stuck inside unable to exit (the only way is to logout and log back in). This has actually been a bug for a long time now so idk if the answer on this has already been put somewhere

I actually fixed it by turning off the cutscene skip for bandit hideouts


Suggestions for improving the blog

What are some possible improvements to the blog that would help with content discoverability?
Some ideas off the top of my head:

Tag cloud
Posts by Author
Pagination of blog
In addition to Recent posts, display a small number of random posts

@kinson what do you think about making a bunch of these into hacktoberfest tickets? Any other enhancements you can think of?

@doomspork I can tackle this later today or tomorrow!


Allow empty routed path (issue #414)

With this patch it should be possible now to include empty route path
it also checks if both path and prefix are not empty
see #414 for more details

hi
do you think this will land to release ? (we are just trying to understand our project strategy... )

This feature also interests me quite a lot! Perhaps not this exact implementation, but I think it would be very beneficial to have the flexibility of having routes without a trailing slash 👍

I don't like the idea of having FastAPI behaving  differently than
Starlette, if this should land it should be upstream imho, or not at all.
Le jeu. 8 août 2019 à 8:03 AM, Pablo Marti<EMAIL_ADDRESS>a
écrit :

This feature also interests me quite a lot! Perhaps not this exact
implementation, but I think it would be very beneficial to have the
flexibility of having routes without a trailing slash 👍
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tiangolo/fastapi/pull/415?email_source=notifications&email_token=AAINSPXFXBGL75EHAPQALY3QDPAKLA5CNFSM4IIOOMH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD32VLUI#issuecomment-519394769,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAINSPXXUIKMNIV5JMB66T3QDPAKLANCNFSM4IIOOMHQ
.

yeah you're right @euri10 the discussion should be moved there

I don't like the idea of having FastAPI behaving differently than Starlette, if this should land it should be upstream imho, or not at all. Le jeu. 8 août 2019 à 8:03 AM, Pablo Marti
Hi @euri10 , @pablogamboa

Well you forgetting that Starlette's endpoints  can handle multiple http methods (GET, POST, HEAD, PUT) with one function, while what nice about fastapi - each method handled in separate function...

You could use a router with prefix cats, one with prefix dogs, etc,
Sorry for the formatting I'm on mobile, but in essence with the structure
you mentioned you could do what's described here
https://fastapi.tiangolo.com/tutorial/bigger-applications/
dogsrouter = APIRouter()  catsrouter = APIRouter()
app.include_router(dogsrouter)
app.include_router(
catsrouter,
prefix="/cats",
)
@catsrouter.get('/')
@catsrouter.post('/')
@catsrouter.get('/{id}/children')
Le jeu. 8 août 2019 à 12:41 PM, Vitaliy Kucheryaviy <
<EMAIL_ADDRESS>a écrit :

I don't like the idea of having FastAPI behaving differently than
Starlette, if this should land it should be upstream imho, or not at all.
Le jeu. 8 août 2019 à 8:03 AM, Pablo Marti
Hi @euri10 https://github.com/euri10 , @pablogamboa
https://github.com/pablogamboa
Well you forgetting that Starlette's endpoints can handle multiple http
methods (GET, POST, HEAD, PUT) with one function, while what nice about
fastapi - each method handled in separate function...

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tiangolo/fastapi/pull/415?email_source=notifications&email_token=AAINSPQ7ADZXL6CD54A4OQDQDQA4ZA5CNFSM4IIOOMH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD33K5ZA#issuecomment-519483108,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAINSPWBQGOGYE4NKOVEGXDQDQA4ZANCNFSM4IIOOMHQ
.

@euri10 well - it does not work - try it...
you cannot include these endpoints without ending slash
GET  /cats
POST /cats

but making it outside routed views makes code less modular/incapsulated

unless I'm mistaken Starlette redirects you with a 308 if you don't have
the trailing slash
well I may be missing something obvious you want, sorry if I dont get it :)
On Thu, Aug 8, 2019 at 4:19 PM Vitaliy Kucheryaviy<EMAIL_ADDRESS>wrote:

@euri10 https://github.com/euri10 well - it does not work - try it...
you cannot include these endpoints without ending slash
GET  /cats
POST /cats
but making it outside routed views makes code less modular/incapsulated
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tiangolo/fastapi/pull/415?email_source=notifications&email_token=AAINSPXMPAGRNE6WTKIDFHTQDQTQDA5CNFSM4IIOOMH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD33YP6Q#issuecomment-519538682,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAINSPXTGG3J23GCWNVHSCTQDQTQDANCNFSM4IIOOMHQ
.

--
benoit barthelet
http://pgp.mit.edu/pks/lookup?op=get&search=0xF150E01A72F6D2EE

Redirects don't solve this for me. I want my route to be documented as GET /cats not GET /cats/ as it's consistent with my other endpoints that don't have a trailing slash.
What's the reason for not allowing empty paths?

@steinitzu I'm assuming it's just a way to ensure you don't accidentally end up with paths that aren't separated by slashes. Either way, to @euri10's point, I think that the right place to ask this question would probably be on starlette because of this: https://github.com/encode/starlette/blob/master/starlette/routing.py#L147

@dmontagu well starlette routing have nothing to do with fast-API  app.get/post/patch.. these a re different code basses

I'm assuming it's just a way to ensure you don't accidentally end up with paths that aren't separated by slashes

my pull request is actually makes this check - if you use empty routed path and include - it will throw an error

@vitalik

well starlette routing have nothing to do with fast-API app.get/post/patch

I think that's a little extreme; clearly they are related -- APIRoute is a subclass of starlette.routing.Route after all.
That said, it is a valid point that include_router doesn't exist in starlette, so this concern wouldn't apply. Given APIRoute is typically added to an app via include_router I'm convinced this is a reasonable change. I personally would be fine with merging it.
Either way, it would certainly be less controversial if there was a way to implement this that didn't remove validation that would be typically be performed in the superclass.

I'm sorry - maybe I am extreme , sorry about that - but this patch is only removing one line with assert inside fastapi code (have nothing to do with starlette) that's it (plus extra check that both include an route are not empty)
if you can give me any other option how to make my code more modular/isolated withot this assert - I would be happy to use it

Hi @tiangolo
Can you share your concerns or plans about this PR ?
Thank you

Thank you @vitalik ! Merged! :tada: :rocket:

I think I can agree with you all :smile:
I agree I don't want to diverge from Starlette, but it's true that the router functionality and the "path operations" are already handled differently.
I think for a new developer to find a path operation with an empty route in an existing codebase could be confusing, and that in some cases it could be more "intuitive" to have paths that are a prefix of other paths always have a trailing slash.
But that's a bit subjective, depending on the point of view, in fact, GitHub itself has by default the contrary behavior, the one that would be supported by this feature (it's https://github.com/tiangolo/fastapi , not https://github.com/tiangolo/fastapi/).
I also see that this is a feature that seems to help several use cases (at least 3, just from this thread), and I think it might help especially with some migrations, to keep paths consistent with previous implementations. Also, the flexibility it adds doesn't break current behavior, so I think it's fine.
Thanks for your contribution @vitalik ! And thanks for the interest and discussion here everyone!

Now, although I ran the tests locally first (and they passed), as Travis seems to have not triggered, I see now there's a mypy error after merging :disappointed:. So I'll fix it before a release.


Rectangular spotlight?

Any way to create a rectangular spotlight?, the Oval deforms quite a bit if i want to highlight a bigger rectangle.

Sure. You can pass the target as type .rect
See example below
SpotlightNode(text: "Show Spotlight over a rectangle", target: .rect(redView.bounds))]

Thanks !

@lekshmiraveendranath Even passing a rect, the highlight is still an oval, what i'm asking if it there's a way to make the highlight itself rectangular, given that it deforms quite a bit if i'm hightlighting a big rectangle.


fix: auto migrate auth for headless flows

Description of changes

added auto Migration for Auth when using --forcePush or --yes or --headless

Description of how you validated changes

Manual testing and unit tests added

Checklist

[x] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #8735 (44351ef) into extOverrides4 (49b204e) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           extOverrides4    #8735   +/-   ##
==============================================
  Coverage          56.34%   56.34%
==============================================
  Files                835      835
  Lines              47255    47255
  Branches            9477     9478    +1
==============================================
  Hits               26624    26624
  Misses             19813    19813
  Partials             818      818

Impacted Files
Coverage Δ

...wscloudformation/utils/check-for-auth-migration.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49b204e...44351ef. Read the comment docs.


Start checking for PHP compatibility.

To do so we would use this PHPCS addon https://github.com/wimg/PHPCompatibility
We can define the versions that are check with this.
PHP_CodeSniffer::setConfigData( 'testVersion', '5.2-7.0', true );
The best way to implement it is to be able to define the lowest supported PHP version by the theme.
To set it up dynamically we would have.
$minimum_php = '5.2'
PHP_CodeSniffer::setConfigData( 'testVersion', $minimum_php . '-7.0', true );

This mean the maximum supported version cannot be changed as we want people to support PHP7.

Fixed in https://github.com/ernilambar/ns-theme-check/pull/13


Make the use of Geoserver optional

Please connect the issue

Please add in the readme that the GS_ environment variables are only needed if you're running GeoServer

Done


Please merge revision 40bf5d321ea22fd9813d344ca2a0b06de5ec9784 into dev channel

@whesse @mit-mit @kasperl
This support dynamic as type argument to a generic method invocation, for instance m<dynamic>().
Revision to merge: 40bf5d321ea22fd9813d344ca2a0b06de5ec9784
This merged cleanly

Merged in version 1.21.0-dev.11.2


Nested noun chunks

In Spacy documentation, noun chunks are defined as: "A base noun phrase, or "NP chunk", is a noun phrase that does not permit other NPs to be nested within it".
Does this not mean that noun chunks should not be nested?
In this example, this is not the case:
from spacy.en import English
nlp = English()
sent = u'''Peter has chronic command and control issues.'''.strip()
tokens = nlp(sent)
for chunk in tokens.noun_chunks:
    print chunk.orth_

Peter
control
chronic command and control issues

Hmm.
Good point. It seems I changed the definition of this and didn't change the docs. I'm now not sure why I set the definition to include the conj relation:
https://github.com/honnibal/spaCy/blob/master/spacy/tokens/doc.pyx#L244
More broadly, I'm now not so sure I'm happy with the design decision to put the iterator as a property of the Doc object. It seems like it would be better to have a library of these iterators, which should be functions. So you would have noun_chunks(doc) instead of doc.noun_chunks

Thanks for your reply. So is the desired functionality that the noun chunks can be nested?

No --- the output is wrong. I'll fix this.
On Tue, Dec 8, 2015 at 1:30 PM, Matic Horvat<EMAIL_ADDRESS>wrote:

Thanks for your reply. So is the desired functionality that the noun
chunks can be nested?
—
Reply to this email directly or view it on GitHub
https://github.com/honnibal/spaCy/issues/203#issuecomment-162866767.

Thanks!

Now returns
Peter
chronic command and control issues


[REQUEST] Show a pop-up if the user clicks on the "Show Theme" button before adding all the necessary colors

Suggestion/Concern
When users navigate to the color theme page and attempt to generate a theme template by clicking the "Show Theme" button without adding colors to all the required fields, the current behavior is to do nothing. This lack of feedback may lead to confusion for users who forget to fill in all the necessary color fields.

Proposed Solution
To improve user experience and provide guidance in such cases, we need to implement a feature that triggers a pop-up notification when the "Show Theme" button is clicked without all required colors being added. The pop-up should clearly convey to the user that colors must be added to all the mentioned fields before proceeding to display the theme template.

@aaronreed708 I want to work on this, if this issue looks fine to you

@Photon3009 If you would like to add something for now, that is fine.  But I believe that in the vision that @lwnoble has for the Color Theme going forward, there won't be a "Show Theme" button (see https://www.figma.com/file/qplg5PqoDAK6dh9Y58JlMD/Building-Themes?type=design&node-id=25-1927&mode=design&t=l7CIfAzJg5PA6FfD-0).


[SMALLFIX] Remove links to inaccessible files

ClientOptions is completely gone, and FileSystemMasterClientPool is in a separate project from ResourcePool, so it can't be linked by javadoc.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/6319/
Test PASSed.

LGTM


[SPARK-26192][MESOS] Retrieve enableFetcherCache option from submission for driver URIs

What changes were proposed in this pull request?
Retrieve enableFetcherCache option from submission conf rather than dispatcher conf. This resolves some confusing behavior where Spark drivers currently get this conf from the dispatcher, whereas Spark executors get this conf from the submission. After this change, the conf will only need to be specified once.
How was this patch tested?
With (updated) existing tests.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8416/
Test PASSed.

Test build #102947 has started for PR 23924 at commit 23fb786.

Test build #102947 has finished for PR 23924 at commit 23fb786.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102947/
Test PASSed.

Merged build finished. Test PASSed.

Test build #102948 has started for PR 23924 at commit 2e2d27c.

Test build #102948 has finished for PR 23924 at commit 2e2d27c.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102948/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8417/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8471/
Test PASSed.

Test build #103005 has started for PR 23924 at commit 59308f9.

Test build #103005 has finished for PR 23924 at commit 59308f9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103005/
Test PASSed.


Implement MA-SAM+

implement MA-SAM+ algorithm with the following instructions:
Pseudo-code for MA-SAM+, for finding out the relevant LMAs
For every transition (s,a,s’):
1.1. If a contains at least one action a’ that has not been learned safely
1.1.1. For every subset of actions A\subset a
<IP_ADDRESS>. Create a possible LMA
for every list of tuples in possible_lifted_effects, look at every subset in this as said in the pseudo, then create a new action with an appropriate name (Concatenation of the actions)
and the parameters should be Concatenation of the appropriate parameters of the same type.
Also handle a mapping dictionary that has information on reverse transformation ; from Concatenated naming to it's original values.

in a new and bigger branch


Add log level, log format and time encoding values

Description
Add log level, log format and time encoding values
Related issue(s)

See also: https://github.com/kyma-project/keda-manager/issues/4

/retest


Ref #2012 – Update skipping get_post_meta() to match behavior in 2.0

Ticket: #2012
Issue
In #2012 @aj-adl proposed a way to skip Timber from fetching meta values through get_post_meta() via the timber_post_get_meta_pre filter. Turns out that in 2.x, I added pretty much the same behavior, just with a new filter:
https://github.com/timber/timber/blob/35279e5fa8911c52854f2d268fc028bcf76c2313/lib/Post.php#L574-L624
I wasn’t sure whether this was over-optimization, but hey, here we have a use case already 😎.
Solution
This pull request builds on #2012 to replicate the behavior that we’re going to add in 2.0 in the master branch so that this feature can be used now.
Impact
None.
Usage Changes
See #2012.
Considerations
None.
Testing
None.

Thanks @aj-adl and @gchtr — I added a note to the readme so this can go out with all the info in the next version


ParabolicSmoother fails with dynamicpath.GetTotalTime error

Attempting to smooth some trajectories with robot.SmoothTrajectory causes the ParabolicSmoother to fail with this error message:
[parabolicsmoother.cpp:392 PlanPath] parabolic planner failed: openrave (Assert):
[virtual OpenRAVE::PlannerStatus ParabolicSmoother::PlanPath(OpenRAVE::TrajectoryBasePtr):386]
RaveFabs(dynamicpath.GetTotalTime()-_dummytraj->GetDuration()) < 0.001, (eval 0.00656962 < 0.001)

This is a trajectory that reliably reproduces the problem:
https://gist.github.com/mkoval/1a95ef0db049d5382031

We've switched to HauserParabolicSmoother, so this is no longer an issue.


Document CometMock/CometBFT differences/deficiencies

There should be documentation for the deficiencies where CometMock does not replicate the behaviour of CometBFT (yet).
For example, a folder with Markdown documentation.

v0.38:

The POL Round is hardcoded to 0 when creating a new proposal TODO: link
sendInternalMessage is not called when making a proposal


Fix: handle certificate parsing

Fixes the bug I introduced in https://github.com/freeCodeCamp/freeCodeCamp/pull/39176.

LGTM


fix: Update RegExp to work with updated CodePush paths

Rebased code from https://github.com/getsentry/raven-js/pull/1002

@benvinegar React-native-sentry is still in beta and it is not clear whether disabling the native component fallbacks to ravenjs (that is included somehow in the project). There are still issues leading to disabling that part.

@zifeo If you disable the native part, we do fallback to just use raven-js
https://docs.sentry.io/clients/react-native/config/#additional-configuration
So yes, it is deprecated in raven-js and we should probably put it into our react-native-sentry repo.

@HazAT Thanks for confirming, what should we do in this case?

@zifeo I assume you are running a react-native project with just raven-js.
I would recommend removing raven-js and add react-native-sentry, disable the native integration if you like (I recommend using it though) and see if it works.
The public API should mostly be the same as raven-js except the naming Raven -> Sentry.
If there are still problems we can move the fix to the react-native repo.

@HazAT We switched a month ago to the new one but we still have sourcemap issues. On raven-js those were caused by codepush and the missing regex from this PR. On react-native-sentry, we disabled the native integration and followed https://github.com/getsentry/react-native-sentry/blob/master/docs/codepush.rst but sourcemap are still shifted. The first version (no code push) works fine, however after a codepush it does not work (sourcemap are generated and uploaded the same way both time).

@zifeo Have you tried adding this fix to the https://github.com/getsentry/react-native-sentry/blob/master/lib/raven-plugin.js ?
If this fixes it we should fix it there.

@HazAT We tried that when we elaborate the current PR (last month) and we saw that react-native-sentry was copying every release the ravenjs codebase into theirs so we though it should be fixed here first?

@zifeo Yeah, we want to deprecate the react-native integration here in raven-js, so we should move the change to https://github.com/getsentry/react-native-sentry

@HazAT are you going to do it, or should I do the move?

@zifeo I don't have a running CodePush example up and running, so if you already have and you are using react-native-sentry go ahead. If you don't I will do it.

@zifeo I went ahead and created an PR
https://github.com/getsentry/react-native-sentry/pull/236

Thanks Daniel. Closing this one then.

@HazAT That was fast, many thanks!


Add example of mapping using JsonObject in the documentation

It's a built-in type but we don't mention it in the docs

Duplicated issue: https://github.com/hibernate/hibernate-reactive/issues/1606


Adjustment "Pumpe Leistung Heizen" possible?

Is your feature request related to a problem? Please describe.
Want to adjust "Pumpe Leistung Heizen		PID 226	  Register 43 103	Holding R/W"
Describe the solution you'd like
Is there any chance to change it via Modus TCP?
Describe alternatives you've considered
Today i set it up via WEMPortal
Additional context
Context: Currently try to in/decrease power to avoid clocking because our heatpump seems way to large. Want to setup power based on temperature.

Where do you get this Modbus Register information from?
We have: 43103, "Pumpe Einschaltart" from https://docs.google.com/spreadsheets/d/1EZ3QgyB41xaXo4B5CfZe0Pi8KPwzIGzK/edit?gid=1730751621#gid=1730751621

This one: https://docs.google.com/spreadsheets/d/1EZ3QgyB41xaXo4B5CfZe0Pi8KPwzIGzK/edit?gid=636734480#gid=636734480

We have an error here. Acording to the doku 43 101 is Konfiguration  @ Ruhemodus.
So our integration might be right.
@OStrama
We could easily change the entitys to number and have sliders to change the values.

@OStrama
What about making 3 levels:

Read only: Just to monitor the heatpump. No writing modbus registers possible.
Balanced: Open uncritical options for writing

"I think i know what i am doing": Open every possible option for writing.

@exp1338 : In the meantime you could go to hpconst.py and update this line:
    ModbusItem( 43104, "Sollwert Pumpe Leistung Heizen", FORMATS.PERCENTAGE, TYPES.NUMBER_RO, DEVICES.WP, RANGE_PERCENTAGE),
to
    ModbusItem( 43104, "Sollwert Pumpe Leistung Heizen", FORMATS.PERCENTAGE, TYPES.NUMBER, DEVICES.WP, RANGE_PERCENTAGE),

Can you set a warning for these settings? or only after entering OK that the settings are now dangerous and you should know what you are doing there. It would also be important to indicate that you are not responsible for the misconfiguration.

Yes, this could be an option…
@MadOne : Do you know how to implement a popup when changing a value? (It‘s also about the touch interface on the phone. There‘s a risk that you change a value by mistake by swiping on the screen..)

@OStrama You mean on every entity itself? No i dont know.

I googled quite a while and found some custom cards that allow this. But the user would have to set this up on his own. At the moment i see no possibility to define this in our integration.
A possibility would be:
Make a switch witch enables adminmode for 1 minute
The dangerous entitiys check if admin mode is enabled, elso on change setback to value from modbus. (no change)

@OStrama any thoughts on this?

For now we dont see a safe way to open these values for manipulation. You can edit the hpconst.py file as described above if you really need this functionality.
I will close this now, but feel free to reopen if you have new suggestions/info.


Drop support for 0.8, add support for 0.11

Are you open to a migration to promises so that we can yield (on node 0.11/io.js 1.x, and later on await)? We can add examples on the readme on how to nodeify (promise -> callback) for everyone interested in using callbacks.

This is very interesting, how exactly do you think this could look?

var Promise = require('bluebird');

function saveAccessToken(token, callback) {
  return new Promise(function(resolve, reject) {
    if (token === 'foo') {
      return resolve({ accessToken: token });
    }

    return reject(new Error('Invalid token ' + token));
  }).nodeify(callback);
}

// Promise-based.
saveAccessToken('foo').then(function(result) {
  console.log('Saved token "foo":', result);
});
// => Saved token "foo": { accessToken: 'foo' }

// Callback-based.
saveAccessToken('bar', function(err, result) {
  if (err) {
    console.error('An error occurred while trying to save token', err);

    return;
  }

  console.log('Saved token "bar":', result);
});
// => An error occurred while trying to save token [Error: Invalid token bar]

With this in mind, you can now yield the promise inside a coroutine:
Promise.coroutine(function *() {
  let result = yield saveAccessToken('foo')
  console.log(result);
  // => { accessToken: 'foo' }
});

What do you think?

Please do that. It has been a while since last release. I am so excited about all the new features in 3.0.0

Wow that is pretty awesome! Let's get a few features into 3.0.0 and revisit!

Closing as we're tracking elsewhere


feature/invite_non_admins_fix

'Invite circle' button available to non-admins #281

Thanks @kristysnet!


Dep bump

Overview of change:
Addresses an existing issue: yarn.lock and Gemfile updates, in response to the GH vulnerability scanner.
CHANGELOG.md entry:
[no-log]

Whoops, wrong URIs.


Added variable sharePayable and sharePercent

added function to update sharePayable and sharePercent
modified withdraw function to use variables instead of hardcoded values

added whitelist functionality