What is happen with the price when I change a reservation price?

"You can change any reservation property such as size, region, quantity, and term with an exchange."
What this means about price? Do I have to pay one year for early reservation and this will plus with my new size? It is not clear to me.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f0af130-6b0a-0a7e-5fd9-e67810f66b45
Version Independent ID: 445b1c77-472a-e0f7-45fc-168f4a2454f3
Content: Self-service exchanges and refunds for Azure Reservations
Content Source: articles/billing/billing-azure-reservations-self-service-exchange-and-refund.md
Service: cost-management-billing
GitHub Login: @yashesvi
Microsoft Alias: banders

@ingd Thanks for the comment. We are actively investigating on the issue and will get back to you shortly with an update.

@yashesvi For insights.

"The prorated reservation amount is refunded for the reservations that you trade-in. You're charged fully for the new purchase. The prorated reservation amount is the daily prorated residual value of the reservation being returned."
Does this not answer?

@yashesvi, yes, yes. Perfect. I am sorry. It was my bad.
Thank you very much!

@yashesvi Thanks for your help.
@ingd Closing this issue for now. Please don't hesitate to reply if you've any further questions that we can help with.


Update readiness-assessment-fix.md

Made some changes to correct some minor errors and add some more context.

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

Thanks guys, I believe we need Jaime Ondrusek and Elaine (cc'd) to review it for MMD also.
Best, Adam
From: Yogesh Kumar<EMAIL_ADDRESS>Sent: 18 January 2021 16:23
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Adam Shepherd<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] Update readiness-assessment-fix.md (#3936)
@JohanFreelancer9https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJohanFreelancer9&data=04|01|adamshep%40microsoft.com|711649ed215d4e36d1f808d8bbc4f691|72f988bf86f141af91ab2d7cd011db47|0|0|637465801931544614|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=5gT3sI7hR6VrhMSgjQKeD%2BajMYQ%2FDwN38A6N4QQuY40%3D&reserved=0 - kindly do the copy editor review for this PR. Thanks

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fpull%2F3936%23issuecomment-762316503&data=04|01|adamshep%40microsoft.com|711649ed215d4e36d1f808d8bbc4f691|72f988bf86f141af91ab2d7cd011db47|0|0|637465801931554574|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=5%2FK0%2FlaY4M%2BUMpaDIKKUqyP31nD%2FYjdhGuOK2B4rBdA%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKDYLN6N4FGDIQEZLZRZBPLS2RG53ANCNFSM4WHK36IA&data=04|01|adamshep%40microsoft.com|711649ed215d4e36d1f808d8bbc4f691|72f988bf86f141af91ab2d7cd011db47|0|0|637465801931564528|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=6w9tz8gxekQQlnQhHf19kqX3SgoYoPFadFeTBWC1sMo%3D&reserved=0.

Thanks guys, I believe we need Jaime Ondrusek and Elaine (cc'd) to review it for MMD also.
Best, Adam
From: Yogesh Kumar<EMAIL_ADDRESS>Sent: 18 January 2021 16:23
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Adam Shepherd<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] Update readiness-assessment-fix.md (#3936)
@JohanFreelancer9https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJohanFreelancer9&data=04|01|adamshep%40microsoft.com|711649ed215d4e36d1f808d8bbc4f691|72f988bf86f141af91ab2d7cd011db47|0|0|637465801931544614|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=5gT3sI7hR6VrhMSgjQKeD%2BajMYQ%2FDwN38A6N4QQuY40%3D&reserved=0 - kindly do the copy editor review for this PR. Thanks

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fpull%2F3936%23issuecomment-762316503&data=04|01|adamshep%40microsoft.com|711649ed215d4e36d1f808d8bbc4f691|72f988bf86f141af91ab2d7cd011db47|0|0|637465801931554574|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=5%2FK0%2FlaY4M%2BUMpaDIKKUqyP31nD%2FYjdhGuOK2B4rBdA%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKDYLN6N4FGDIQEZLZRZBPLS2RG53ANCNFSM4WHK36IA&data=04|01|adamshep%40microsoft.com|711649ed215d4e36d1f808d8bbc4f691|72f988bf86f141af91ab2d7cd011db47|0|0|637465801931564528|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=6w9tz8gxekQQlnQhHf19kqX3SgoYoPFadFeTBWC1sMo%3D&reserved=0.

@adsshepherd

@adsshepherd

Thanks for looping me in, Adam.  Adding<EMAIL_ADDRESS>to review your edits.
Hi Jaime, can you please review Adam's edits to the ART fix settings article (Adam has been a great resource in confirming the language and the customer experience) and share a link with me to the edits? I am not sure how to see them without a link.
Regards,
Elaine
From: Adam Shepherd<EMAIL_ADDRESS>Sent: Monday, January 18, 2021 7:28 AM
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Author<EMAIL_ADDRESS>Elaine Ansell<EMAIL_ADDRESS>Subject: RE: [MicrosoftDocs/microsoft-365-docs] Update readiness-assessment-fix.md (#3936)
Thanks guys, I believe we need Jaime Ondrusek and Elaine (cc'd) to review it for MMD also.
Best, Adam
From: Yogesh Kumar <notifications<EMAIL_ADDRESS>Sent: 18 January 2021 16:23
To: MicrosoftDocs/microsoft-365-docs <microsoft-365-docs<EMAIL_ADDRESS>Cc: Adam Shepherd <adamshep<EMAIL_ADDRESS>Author <author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] Update readiness-assessment-fix.md (#3936)
@JohanFreelancer9https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJohanFreelancer9&data=04|01|Elainea%40microsoft.com|5a67f51c4a3d44c4717108d8bbc5a836|72f988bf86f141af91ab2d7cd011db47|0|0|637465804981656786|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=81KHKjJrLSDM3OgeksbLG8j5X4n6tcalGCgXmLxyYoA%3D&reserved=0 - kindly do the copy editor review for this PR. Thanks

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fpull%2F3936%23issuecomment-762316503&data=04|01|Elainea%40microsoft.com|5a67f51c4a3d44c4717108d8bbc5a836|72f988bf86f141af91ab2d7cd011db47|0|0|637465804981666746|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=x6%2FxG4ktKGCt59R1Ozl6Qw%2BJuy0gQhXljXkK%2F3xNB9k%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKDYLN6N4FGDIQEZLZRZBPLS2RG53ANCNFSM4WHK36IA&data=04|01|Elainea%40microsoft.com|5a67f51c4a3d44c4717108d8bbc5a836|72f988bf86f141af91ab2d7cd011db47|0|0|637465804981676705|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Bz4Z%2B7WZMRiPKXdiDLsUFP%2BnwdYpdTV2E%2BJ4pA8TMtc%3D&reserved=0.

Thanks for looping me in, Adam.  Adding<EMAIL_ADDRESS>to review your edits.
Hi Jaime, can you please review Adam's edits to the ART fix settings article (Adam has been a great resource in confirming the language and the customer experience) and share a link with me to the edits? I am not sure how to see them without a link.
Regards,
Elaine
From: Adam Shepherd<EMAIL_ADDRESS>Sent: Monday, January 18, 2021 7:28 AM
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Author<EMAIL_ADDRESS>Elaine Ansell<EMAIL_ADDRESS>Subject: RE: [MicrosoftDocs/microsoft-365-docs] Update readiness-assessment-fix.md (#3936)
Thanks guys, I believe we need Jaime Ondrusek and Elaine (cc'd) to review it for MMD also.
Best, Adam
From: Yogesh Kumar <notifications<EMAIL_ADDRESS>Sent: 18 January 2021 16:23
To: MicrosoftDocs/microsoft-365-docs <microsoft-365-docs<EMAIL_ADDRESS>Cc: Adam Shepherd <adamshep<EMAIL_ADDRESS>Author <author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] Update readiness-assessment-fix.md (#3936)
@JohanFreelancer9https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJohanFreelancer9&data=04|01|Elainea%40microsoft.com|5a67f51c4a3d44c4717108d8bbc5a836|72f988bf86f141af91ab2d7cd011db47|0|0|637465804981656786|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=81KHKjJrLSDM3OgeksbLG8j5X4n6tcalGCgXmLxyYoA%3D&reserved=0 - kindly do the copy editor review for this PR. Thanks

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fpull%2F3936%23issuecomment-762316503&data=04|01|Elainea%40microsoft.com|5a67f51c4a3d44c4717108d8bbc5a836|72f988bf86f141af91ab2d7cd011db47|0|0|637465804981666746|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=x6%2FxG4ktKGCt59R1Ozl6Qw%2BJuy0gQhXljXkK%2F3xNB9k%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKDYLN6N4FGDIQEZLZRZBPLS2RG53ANCNFSM4WHK36IA&data=04|01|Elainea%40microsoft.com|5a67f51c4a3d44c4717108d8bbc5a836|72f988bf86f141af91ab2d7cd011db47|0|0|637465804981676705|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Bz4Z%2B7WZMRiPKXdiDLsUFP%2BnwdYpdTV2E%2BJ4pA8TMtc%3D&reserved=0.

@adsshepherd what does "personally owned devices" mean? Devices that are not enrolled in Microsoft Managed Desktop?

@adsshepherd what does "personally owned devices" mean? Devices that are not enrolled in Microsoft Managed Desktop?

Do not merge this until I can make some edits.

Do not merge this until I can make some edits.

Enrollmemt restrictions make a distinction between "Personally owned" i.e. BYOD and corporate devices.    MMD devices fall under the latter category, corporate devices.   We don't care how a customer configures the "Personally owned" restriction.
Best, Adam
From: Jaime Ondrusek<EMAIL_ADDRESS>Sent: 19 January 2021 19:32
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Adam Shepherd<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] Update readiness-assessment-fix.md (#3936)
@adsshepherdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadsshepherd&data=04|01|adamshep%40microsoft.com|50590ca3623f4937516408d8bca87c81|72f988bf86f141af91ab2d7cd011db47|0|0|637466779147440104|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=gxoNlnoDf7edgjCBa%2FLGTVVZNh8rtD7Xrz3Uq3yIflU%3D&reserved=0 what does "personally owned devices" mean? Devices that are not enrolled in Microsoft Managed Desktop?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fpull%2F3936%23issuecomment-763037693&data=04|01|adamshep%40microsoft.com|50590ca3623f4937516408d8bca87c81|72f988bf86f141af91ab2d7cd011db47|0|0|637466779147440104|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=OwGaRRvd4uS8Kbsl%2F0le2frROCWilgOafCyM9v8l2vE%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKDYLN3JX2OGG5MZNBINNV3S2XFZNANCNFSM4WHK36IA&data=04|01|adamshep%40microsoft.com|50590ca3623f4937516408d8bca87c81|72f988bf86f141af91ab2d7cd011db47|0|0|637466779147450057|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=TQqPF%2FPfbUO0t4Wzk7BvvDOEKPrTuuIS2xevf2uS7do%3D&reserved=0.

Enrollmemt restrictions make a distinction between "Personally owned" i.e. BYOD and corporate devices.    MMD devices fall under the latter category, corporate devices.   We don't care how a customer configures the "Personally owned" restriction.
Best, Adam
From: Jaime Ondrusek<EMAIL_ADDRESS>Sent: 19 January 2021 19:32
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Adam Shepherd<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] Update readiness-assessment-fix.md (#3936)
@adsshepherdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadsshepherd&data=04|01|adamshep%40microsoft.com|50590ca3623f4937516408d8bca87c81|72f988bf86f141af91ab2d7cd011db47|0|0|637466779147440104|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=gxoNlnoDf7edgjCBa%2FLGTVVZNh8rtD7Xrz3Uq3yIflU%3D&reserved=0 what does "personally owned devices" mean? Devices that are not enrolled in Microsoft Managed Desktop?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fpull%2F3936%23issuecomment-763037693&data=04|01|adamshep%40microsoft.com|50590ca3623f4937516408d8bca87c81|72f988bf86f141af91ab2d7cd011db47|0|0|637466779147440104|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=OwGaRRvd4uS8Kbsl%2F0le2frROCWilgOafCyM9v8l2vE%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKDYLN3JX2OGG5MZNBINNV3S2XFZNANCNFSM4WHK36IA&data=04|01|adamshep%40microsoft.com|50590ca3623f4937516408d8bca87c81|72f988bf86f141af91ab2d7cd011db47|0|0|637466779147450057|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=TQqPF%2FPfbUO0t4Wzk7BvvDOEKPrTuuIS2xevf2uS7do%3D&reserved=0.

@adsshepherd thanks for that clarification! I find the term "personally owned" to be a bit unclear. I'll try to find a wording that makes it more unequivocal what we're talking about.

@adsshepherd thanks for that clarification! I find the term "personally owned" to be a bit unclear. I'll try to find a wording that makes it more unequivocal what we're talking about.

It's the official term used by Intune - see here:  Set enrollment restrictions in Microsoft Intune | Microsoft Docshttps://docs.microsoft.com/en-us/mem/intune/enrollment/enrollment-restrictions-set#create-a-device-type-restriction
Best, Adam
From: Jaime Ondrusek<EMAIL_ADDRESS>Sent: 19 January 2021 23:01
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Adam Shepherd<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] Update readiness-assessment-fix.md (#3936)
@adsshepherdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadsshepherd&data=04|01|adamshep%40microsoft.com|f30e776f808c4fce133808d8bcc5c533|72f988bf86f141af91ab2d7cd011db47|0|0|637466904900955602|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=BJIRkRvx24y4hYeN1hENWvGwLeUW3n5zoQCaviIczII%3D&reserved=0 thanks for that clarification! I find the term "personally owned" to be a bit unclear. I'll try to find a wording that makes it more unequivocal what we're talking about.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fpull%2F3936%23issuecomment-763169475&data=04|01|adamshep%40microsoft.com|f30e776f808c4fce133808d8bcc5c533|72f988bf86f141af91ab2d7cd011db47|0|0|637466904900965558|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=FJ%2FssyOPM2oIMGKfPmLmhPGuj1l4KbhfICNJiP%2FAXCM%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKDYLN7TXPP3Q4R4S46DBS3S2X6LPANCNFSM4WHK36IA&data=04|01|adamshep%40microsoft.com|f30e776f808c4fce133808d8bcc5c533|72f988bf86f141af91ab2d7cd011db47|0|0|637466904900965558|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=lPFoOcDvRMZ3Iig49QEIeAFrU8YbwMJqaZLmvJiBldw%3D&reserved=0.

It's the official term used by Intune - see here:  Set enrollment restrictions in Microsoft Intune | Microsoft Docshttps://docs.microsoft.com/en-us/mem/intune/enrollment/enrollment-restrictions-set#create-a-device-type-restriction
Best, Adam
From: Jaime Ondrusek<EMAIL_ADDRESS>Sent: 19 January 2021 23:01
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Adam Shepherd<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] Update readiness-assessment-fix.md (#3936)
@adsshepherdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadsshepherd&data=04|01|adamshep%40microsoft.com|f30e776f808c4fce133808d8bcc5c533|72f988bf86f141af91ab2d7cd011db47|0|0|637466904900955602|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=BJIRkRvx24y4hYeN1hENWvGwLeUW3n5zoQCaviIczII%3D&reserved=0 thanks for that clarification! I find the term "personally owned" to be a bit unclear. I'll try to find a wording that makes it more unequivocal what we're talking about.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fpull%2F3936%23issuecomment-763169475&data=04|01|adamshep%40microsoft.com|f30e776f808c4fce133808d8bcc5c533|72f988bf86f141af91ab2d7cd011db47|0|0|637466904900965558|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=FJ%2FssyOPM2oIMGKfPmLmhPGuj1l4KbhfICNJiP%2FAXCM%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKDYLN7TXPP3Q4R4S46DBS3S2X6LPANCNFSM4WHK36IA&data=04|01|adamshep%40microsoft.com|f30e776f808c4fce133808d8bcc5c533|72f988bf86f141af91ab2d7cd011db47|0|0|637466904900965558|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=lPFoOcDvRMZ3Iig49QEIeAFrU8YbwMJqaZLmvJiBldw%3D&reserved=0.

Ah, I see. In UI even. That's unfortunate, because it isn't clear what exactly it's supposed to mean.

Ah, I see. In UI even. That's unfortunate, because it isn't clear what exactly it's supposed to mean.

@JohanFreelancer9

@JohanFreelancer9

All these changes are getting a bit wooly to keep track of, so let's merge these commits for now, then revisit further edits from that version.

All these changes are getting a bit wooly to keep track of, so let's merge these commits for now, then revisit further edits from that version.


Security patches not applied to the latest Windows server core 2022 container image

What is your question?
I am using the latest windows server core 2022 image from here: https://hub.docker.com/_/microsoft-windows-servercore (tag ltsc2022)
After checking the available updates on this image tag (ltsc2022), it shows that the KB5012170 (Security update) and KB5026370 (Cumulative update) are not applied.
1.Why are there missing updates when I use the latest image?
ltsc2022 image - showing missing security and cumulative patches:

I then went ahead and deployed another image with tag (ltsc2022-KB5026370). Using this image, it no longer shows the outstanding KB5012170 (security update), however, it shows the KB5026370 (Cumulative update) is still missing.
2.When using this specific Image, why is there still missing patches? and the missing one (KB5026370) has same name of the image tag (ltsc2022-KB5026370)
ltsc2022-KB5026370 image, showing missing cumulative patches:

However, if you go to this page https://hub.docker.com/_/microsoft-windows-servercore, under the Full Tag Listing, it shows that the ltsc2022-KB5026370 and ltsc2022 images are both updated on the same day (05/09/2023).
3.How can two separate images that are updated on the same day, be released with different patches missing (as per the above two questions)?

Hey @akarshm ,
Thank you for your help in this question. I really appreciate your quick response.
I did a test, and you are right, it is showing as part of the hotfixes. However, it is still showing KB5026370 is missing in both tags ltsc2022 and ltsc2022-KB5026370, and with size 24GB! is there an explanation for that?
ltsc2022:

ltsc2022-KB5026370:

Also, you can see that there is an outstanding security update (KB5012170) in the ltsc2022 tag, is this expected in ltsc2022 tag?
Thank you so much,
Tarek

@tarekmulla Just checking in, did Akarsh's comment help clarify how security patches work and what your next steps should be? If not, please let us know.

Hey @ntrappe-msft and @akarshm
Thank you so much for the help with this question, and with the follow up.
Yup, all good, @akarshm 's answer addressed my question, I am going to close the issue.
Cheers,
Tarek


How can I control two same device at the same time

I want to send some comamnd to 2 device at same time using pyusb, how should i do

Have you tried it and hit an issue?  Or are you asking for general tips on concurrency in Python?

I want to send some comamnd to 2 device at same time using pyusb, how should i do

Maybe you want to elaborate what exactly you want to achieve. Thanks.
Are you asking how to differentiate two identical devices? If the device have unique serial number, that will make things easier.

I want to send some comamnd to 2 device at same time using pyusb, how should i do

Maybe you want to elaborate what exactly you want to achieve. Thanks. Are you asking how to differentiate two identical devices? If the device have unique serial number, that will make things easier.

I use pyusb to send HID evnent to my phone, it work well on there is only one phone, but when I hava 2 same phone, I want to send HID event to both the 2 phones at same time. I try to use mutiprocess, but I find it was blocked by pyusb

I try to use mutiprocess, but I find it was blocked by pyusb

Can you elaborate?

I use pyusb to send HID evnent to my phone, it work well on there is only one phone, but when I hava 2 same phone, I want to send HID event to both the 2 phones at same time. I try to use mutiprocess, but I find it was blocked by pyusb

I use pyusb to send HID evnent to my phone, it work well on there is only one phone, but when I hava 2 same phone, I want to send HID event to both the 2 phones at same time. I try to use mutiprocess, but I find it was blocked by pyusb

@Shimon-Guo,
It seems you accidentally duplicated a previous comment instead of replying with more information.

I use pyusb to send HID evnent to my phone, it work well on there is only one phone, but when I hava 2 same phone, I want to send HID event to both the 2 phones at same time. I try to use mutiprocess, but I find it was blocked by pyusb

I use pyusb to send HID evnent to my phone, it work well on there is only one phone, but when I hava 2 same phone, I want to send HID event to both the 2 phones at same time. I try to use mutiprocess, but I find it was blocked by pyusb

It is just easier to show your codes here.

@mcuee,

BTW, it is better to use HIDAPI and cython-hidapi than libusb/pyusb to talk to HID device.

I honestly curious about where the HID comes in...
Like, is the phone reporting itself as a HID?  Never saw that before...

@Shimon-Guo I think your English is okay, just need to write in details of what you want to achieve. Worst case you can use Chinse and I should be able to translate.

@mcuee Actually，I try to use pyusb to achieve GOOGLE AOA protocol (https://source.android.com/devices/accessories/aoa2),
I successful use the protocol to connect an android phone. This protocol think of my computer as an accessory to my phone like keyboard, mouse. So I can transmit a signal from the computer to the phone, for example by clicking on a certain coordinate on the screen, or entering a string of text.
And now, my questions is: it did good on one phone, but I have many of the same phone devices, I want control all of those phones at same time. But I try to conncet 2 phones use pyusb, and start two process, but I failed.

Show your codes how you start two processes.

@mcuee
`from multiprocessing import Process
import xhid
def func_1():
device = xhid.connect(device_id='43b64863')
device.swipe(500, 2000, 500, 100, 1000)
def func_2():
device = xhid.connect(device_id='5DB659YT7X4HKVWC')
device.swipe(500, 2000, 500, 100, 1000)
process = [Process(target=func_1), Process(target=func_2)]
[p.start() for p in process]
[p.join() for p in process]`
Here is my code, but I found it work now.

@mcuee
`import time
from multiprocessing import Process
import xhid
all_devices = xhid.connect_all()
def func(device):
device.click(150, 1800)
time.sleep(2)
device.swipe(500, 2000, 500, 100, 1000)
process = [Process(target=func, args=(device,)) for device in all_devices]
[p.start() for p in process]
[p.join() for p in process]
`
but i tied this, it didn't work again.
When I exit, here is the messege:
Traceback (most recent call last):
File "/home/mi/PycharmProjects/x-hid/test3.py", line 17, in
[p.join() for p in process]
File "/home/mi/PycharmProjects/x-hid/test3.py", line 17, in
[p.join() for p in process]
File "/usr/lib/python3.6/multiprocessing/process.py", line 124, in join
res = self._popen.wait(timeout)
File "/usr/lib/python3.6/multiprocessing/popen_fork.py", line 50, in wait
return self.poll(os.WNOHANG if timeout == 0.0 else 0)
File "/usr/lib/python3.6/multiprocessing/popen_fork.py", line 28, in poll
pid, sts = os.waitpid(self.pid, flag)
KeyboardInterrupt

@mcuee  I think i have found the problem, I use 'while Ture' condition is the func 'swipe', so it was blocked.
    def swipe(self, s_x, s_y, e_x, e_y, millis):
        """
        swipe gesture
        :param s_x:
        :param s_y:
        :param e_x:
        :param e_y:
        :param millis:
        :return:
        """
        start = datetime.datetime.now()
        dt = 0
        start_point = Point(s_x, s_y).point_scale(self.width, self.height)
        end_point = Point(e_x, e_y).point_scale(self.width, self.height)
        while dt <= millis:
            delta = datetime.datetime.now() - start
            dt = (delta.days * 24 * 60 * 60 + delta.seconds) * 1000 + delta.microseconds / 1000
            progress = dt / max(millis, 1)
            point_x = int(progress * end_point.x + (1 - progress) * start_point.x)
            point_y = int(progress * end_point.y + (1 - progress) * start_point.y)
            self._touch(touch_type='DOWN', point=BasePoint(point_x, point_y))
            # time.sleep(0.01)
        self._touch(touch_type='UP', point=end_point)

@Shimon-Guo ,

I think i have found the problem, I use 'while Ture' condition is the func 'swipe', so it was blocked.

I'm glad you seem to have already resolved your issue.
Here are some additional comments about your code:

If you have any more problems, I would also take a look at xhid.connect(), as it's an obvious place for problems that appear when you have two identical devices;
Having each process connect to its own device (as in you first code sample) is preferable to trying to pass PyUSB devices between processes: this is because PyUSB devices are not pickable, plus you would be sharing a single LibUSB context between different processes, which is not a way LibUSB is supposed to be used (although it can work in some scenarios);
KeyboardInterrupt just means that you manually killed the process with an interrupt signal, e.g. with Ctrl+C on Linux.

Closing the issue as the it seems to be resolved.
P.S. In the future, please ask questions using the Discussions tab, Q&A section.


button support ?

Before adding this issue, make sure you do the following to make sure this is not a duplicate:

Search through the repo's previous issues
Read through the readme at least once
Search the docs for the feature you're looking for

Just describe the feature

Won't be worked on.


Optimize LoadSceneEmotesSystem / Reduce Allocations

Explorer Alpha build versions:
When we have a large number of players in an area, the system that most struggles is LoadSceneEmotesSystem, it has many allocations and can cause performance problems.

This issue is partially fixed on this pr: https://github.com/decentraland/unity-explorer/pull/2399
However we do have more memory leaks, related to the EmotePromise and its internal intention. We need to properly delete the entities that are created to fetch the emote's assets and are no longer used.

I dont see LoadSceneEmotesSystem.Update in the top of the profiling anymore. Closing the ticket


Automatic reporting of contraction costs

Here's an idea for a useful feature we should add (could be post 1.0). We should designate a special tag syntax such as "dim=D" or "dim=chi" or possibly "|D|" or "|chi|" which, when added to an Index, says that the dimension of that Index is called "D" or "chi".
Then when two ITensors are contracted, say with three indices of dimension "chi", two indices of dimension "D", and another Index of unlabeled dimension 10, the code would report the cost as being:
10 chi^3 D^2
This report would only be shown when an option is turned on to show it, either with a macro environment, a global variable, or a function keyword argument. "showcost" could be a good name for this variable or environment name.

That is a neat idea. I guess if an Index doesn't have a dim=* tag it is treated as O(1)?

Good question: actually that's where the "10" in the example above came from. I'm thinking any indices without a "dim=..." tag get their dimensions multiplied together (only counting them once for contracted indices of course), and the resulting integer gets displayed as a prefactor. We may have to take some care dealing with very large numbers, but we can use logs to handle that.

I guess the "dim=___" notation is good enough, because with the 8 character limit it still leaves 4 characters for dimension names, large enough for many common names and Greek letters (and of course one can use unicode Greek letters in Julia too...).

@mtfishman do you happen to know a good way to set up a macro environment sort of thing for this? Something like:
@showcost begin
D = A * B * C
end

Ah I didn't read carefully enough, that makes sense to report the actual dimensions of indices that don't have a "dim=*" tag.
Just a note that right now, tags do not support using greek letters. The reason is because the storage of SmallString was not made large enough for greek letters. Currently it is limited to UInt8, while greek letters are size UInt16:
julia> UInt8('a')
0x61

julia> UInt8('α')
ERROR: InexactError: trunc(UInt8, 945)
Stacktrace:
 [1] throw_inexacterror(::Symbol, ::Type{UInt8}, ::UInt32) at ./boot.jl:557
 [2] checked_trunc_uint at ./boot.jl:587 [inlined]
 [3] toUInt8 at ./boot.jl:653 [inlined]
 [4] UInt8 at ./boot.jl:709 [inlined]
 [5] UInt8(::Char) at ./char.jl:171
 [6] top-level scope at REPL[3]:1

julia> UInt16('α')
0x03b1

It may be nice to expand the storage to UInt16 to allow for greek letter tags, I would think it should not cause problems for memory/performance.

@mtfishman do you happen to know a good way to set up a macro environment sort of thing for this? Something like:
@showcost begin
D = A * B * C
end

It's a good question, I haven't written macros like that. I guess the question is, what do you want it to rewrite that to? I imagine something like:
setshowcost!(true)
D = A * B * C
setshowcost!(false)

I guess that should be pretty simple, since it should involve just adding the first and last lines to the code in the code block.

Or maybe something more subtle, like:
curshowcast = showcast()
setshowcost!(true)
D = A * B * C
setshowcost!(curshowcast)

since you want to keep the current state is was in. Anyway, I guess it should be pretty simple to implement that kind of macro.


Pass position in job to action for multi-action jobs

When there are multiple actions in a request, it is sometimes useful for the action to know its position in the job.

When is it sometimes useful? What is the use case for this?

I refer you to the variety of old soa services that work in multiple action per job requests.  Most of the ones I know about are financial in nature.  In any case, this is needed for old soa emulation by pysoa, which will be along in a review shortly.


Update stack-settings.md to include access control link to administrative setting

Description of the change
Update to stack administrative section to add link to access control
ref: https://spacelift-io.slack.com/archives/C069UG3069W/p1729633549178859?thread_ts=1729632616.840889&cid=C069UG3069W
Checklist
Please make sure that the proposed change checks all the boxes below before requesting a review:

[x] I have reviewed the guidelines for contributing to this repository.
[x] The preview looks fine.
[x] The tests pass.
[x] The commit history is clean and meaningful.
[x] The pull request is opened against the main branch.
[x] The pull request is no longer marked as a draft.
[x] You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
You have updated the navigation files correctly:

[x] No new pages have been added, or;
[ ] Only nav.yaml has been updated because the changes only apply to SaaS, or;
[ ] Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
[ ] Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.
Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.
Thank you for your contribution! 🙇

https://spacelift-user-documentation-pr-652.onrender.com/concepts/stack/stack-settings.html#administrative

I vote we don't add this - as we're investigating changing this.

@Apollorion Great!  As you're investigating this remember to make the docs changes.  I'll close this pr out then as requested.


docs: add an example for async prerender entries

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[ ] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

It was hard to find the right keywords to find how one can control the entries based on an external data source. I finally discovered the entries configuration then found an example here: https://github.com/sveltejs/kit/issues/5107

@Rich-Harris I went ahead and did that: https://github.com/tansanDOTeth/kit/pull/1


CLOUD-46477 fixed termination problem

@keyki

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1740/


Proper handling of None in WHERE condition

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the SQLModel documentation, with the integrated search.
[X] I already searched in Google "How to X in SQLModel" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to SQLModel but to Pydantic.
[X] I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
from typing import Optional

from sqlmodel import Field, Session, SQLModel, create_engine, select, col

class Hero(SQLModel, table=True):
    id: Optional[int] = Field(default=None, primary_key=True)
    name: str
    secret_name: str
    age: Optional[int] = None

sqlite_file_name = "database.db"
sqlite_url = f"sqlite:///{sqlite_file_name}"

engine = create_engine(sqlite_url, echo=True)

def create_db_and_tables():
    SQLModel.metadata.create_all(engine)

def create_heroes():
    hero_1 = Hero(name="Deadpond", secret_name="Dive Wilson")
    hero_2 = Hero(name="Spider-Boy", secret_name="Pedro Parqueador")
    hero_3 = Hero(name="Rusty-Man", secret_name="Tommy Sharp", age=48)

    with Session(engine) as session:
        session.add_all([hero_1, hero_2, hero_3])
        session.commit()

def select_heroes():
    with Session(engine) as session:
        statement = select(Hero).where(col(Hero.age) is None, Hero.name.like('%Deadpond%'))
        results = session.exec(statement)
        for hero in results:
            print(hero)

Description
To make the where condition Hero.age is None functional, because currently it is evaluated as false even though it should be true. Otherwise, one needs to use Hero.age == None, which raises linting error.
Wanted Solution
To make the where condition Hero.age is None functional, because currently it is evaluated as false even though it should be true. Otherwise, one needs to use Hero.age == None, which raises linting error.
Wanted Code
from typing import Optional

from sqlmodel import Field, Session, SQLModel, create_engine, select, col

class Hero(SQLModel, table=True):
    id: Optional[int] = Field(default=None, primary_key=True)
    name: str
    secret_name: str
    age: Optional[int] = None

sqlite_file_name = "database.db"
sqlite_url = f"sqlite:///{sqlite_file_name}"

engine = create_engine(sqlite_url, echo=True)

def create_db_and_tables():
    SQLModel.metadata.create_all(engine)

def create_heroes():
    hero_1 = Hero(name="Deadpond", secret_name="Dive Wilson")
    hero_2 = Hero(name="Spider-Boy", secret_name="Pedro Parqueador")
    hero_3 = Hero(name="Rusty-Man", secret_name="Tommy Sharp", age=48)

    with Session(engine) as session:
        session.add_all([hero_1, hero_2, hero_3])
        session.commit()

def select_heroes():
    with Session(engine) as session:
        statement = select(Hero).where(col(Hero.age) is None, Hero.name.like('%Deadpond%'))
        results = session.exec(statement)
        for hero in results:
            print(hero)

Alternatives
No response
Operating System
Linux
Operating System Details
No response
SQLModel Version
0.0.4
Python Version
3.8.5
Additional Context
No response

I believe this is concerned entirely with SQLAlchemy, not with SQLModel.

Ok, I am working on a PR implementing this, repo owners please give me some time 👍

You can use Hero.age.is_(None)

@tc-imba where to import is_?

@tc-imba where to import is_?

is_ is an attribute. You don't need to import it.

My understanding is this:
where(Hero.age is None) cannot be implemented, because the is operator cannot be overloaded (== can be overloaded via the __eq__ method, etc.).
where(Hero.age.is(None)) cannot be implemented, because is is a reserved keyword and therefore no valid identifier.
where(Hero.age.is_(None)) works and probably is the closest we can get. It follows PEP 8 Naming Styles by using a trailing underscore to "avoid conflicts with Python keyword".
But is_ is not working with autocompletion, at least not in Pycharm. Hero.age is inferred to be int | None, which is exactly what I want in 99% of cases. But it means that Hero.age.is_ raises a warning "unresolved reference".
Not sure there is a good way to deal with it.

For IS NOT NULL, you could use is_not

where(Hero.age.is_not(None))

looking for a team without heros like
select(Team).where(Team.heros == None)
isn't compatible with E711
but select(Team).where(Team.heros is None)
doesn't work

Team.heros is None cannot be made to work because the Python language does not allow overloading is, but does allow overloading ==.
Team.heros == None checks for equality, not identity. It seems to do what you want, but it is a PEP 8 violation.
Team.heros.is_(None) should also do what you want, and is more idiomatic because it checks for identify (like is), not equality (like ==), following the PEP 8 recommendation.
In the end, write the code that works for you. PEP 8 is just a recommendation, and flake8 is just a tool. If you prefer to ignore a recommendation, PEP 8 has a section about that as well.

Besides using # type: ignore is there an easy way to make pylance happy? Attribute "is_" is unknown Pylance

@patrickwasp this issue is still open. It hasn't be merged to the code base yet.
I recommend the following code:
select(Team).where(
            Team.heros == None,  # noqa E711 Comparison to `None` should be `cond is None`.
)

select(Team).where(
            Team.heros is None,  # This does not work as intended.
)


chore: split Ordered instances for subobjects into separate files

Moving these to separate files should make typeclass synthesis less expensive. Additionally two of them are quite long and this shrinks them slightly.
This handles:

Submonoid
Subgroup
Subsemiring
Subring
Submodule
Subalgebra

The copyright headers are from https://github.com/leanprover-community/mathlib/pull/6489

!bench

@YaelDillies  noted on Zulip that they want to take a look

@eric-wieser feel free to push your suggested changes
There are no ordered instances in Submonoid from what I remember

There are no ordered instances in Submonoid from what I remember

Yes there are! I just pushed changes that extracted those too.

Oops! Shows what good my memory is. Am I correct that still the only files downstream of these are themselves?

CI will tell I think.
Should we split Subfield too, or is that far enough along the hierarchy that we don't care?

Yeah. I think we should.

Units.posSubgroup should be moved out of there.

!bench

I don't understand why we have a benchmark result if the build is failing

Ah nevermind, github was showing me stale info; I'll run shake update

!bench

!bench

!bench

Ok this actually bump the top line number to -350B (from 275B).
@eric-wieser if you happy, please send it off

bors merge
Thanks!


fix(macos): Remove keypress handler in the webview for copy/paste/cut

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Documentation
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes. Issue #___
[ ] No

The PR fulfills these requirements:

[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
[ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
It should be handled by the menu.
It prevents showing a popup when we do cmd+v

but is it able to cmd+x/c/v in the webview without menu items?

but is it able to cmd+x/c/v in the webview without menu items?

Nop! But if we follow macOS guidelines it SHOULD be handled trough the menus.
Also, the user still have the possibility to add the javascript if needed (by example, running in kiosk mode).


RFE: Use predictable names in standard iptables rules

atm (podman-4.5.0-1.fc38.x86_64), netavark calls rules with unpredictable names in standard iptables rules.  E.g.
Chain POSTROUTING (policy ACCEPT)
...
NETAVARK-1D8721804F16F  all  --  <IP_ADDRESS>/16         anywhere

Please move these unpredictable names in an extra rule with a fixed id (e.g. NETAVARK-POSTROUTING).
   To keep foreign systems (netavark, cni, docker) operational, I need a well known chain name which can be called from there.

Sounds like you could just use podman network reload --all to restore rules.

It is too slow (18 containers)
# time podman network reload --all
real    0m8,161s

vs.
# time systemctl reload firewall@ipv4
real    0m0,374s

Are you interested in contributing a PR with the change?

ok; but I can work on it not before next week


Checksum failed: missing SHA-1 hash value in dataset_info.json.

I get below checksum error for local text files i used for data for pretraining with Lora.
04/07/2024 13:42:17 - WARNING - llmtuner.data.utils - Checksum failed: missing SHA-1 hash value in dataset_info.json.
Can this cause any issue for training?
For local text/json files Is there anything i need to do to address this?

this warning does not affect training, just ignore it


Translationfr

There are still huge chunks of english text in those files. Mind to translate them also?

what shall I do. I just want to translate the help page. Did I do mistake ?

It appears to me that only a small part of the content you pushed ist translated to french. The majority is still english...

OK I understand now. Yes I should work faster. All is not finished but I wanted to be sure how to use git first . Now I think I see the begining of the work. I will work more....


Support generic OpenAI compatible providers

Problem
There are a number of other LLM providers that are compatible with the OpenAI API specification such as LocalAI. These providers can be used with Token.js by setting the baseUrl field and using the OpenAI provider. However, this behavior isn't documented and there is not great type support for it.
Solution
Token.js should officially support using any OpenAI API compatible provider. We should do this by creating a new provider and handler openai-compatible where the model field is a generic string. This provider should error if a baseUrl value is not provided. This provider should reuse any logic possible from the OpenAI handler for it's implementation.

@RPate97 Any chance this will be implemented?

@punkpeye
Sure thing, thanks for @-ing me on this. I didn't realize it had so many thumbs up. I've implemented the changes described in this issue in #121. Please let me know if you run into any problems with it, or would like better support for any specific provider.

This is awesome. Thank you


Test suite fails on Chromium 53

With Chromium 53.0.2752.0 (1ace3b00d9dad163255b8e73deaad53c0a43a79a) and V8 5.3.64, the test suite (https://marijnhaverbeke.nl/acorn/test/index.html) fails:

Errors

Normal

/[\uD834\uDF06-\uD834\uDF08a-z]/u Error parsing regular expression: Invalid regular expression: /[\uD834\uDF06-\uD834\uDF08a-z]/: Range out of order in character class (1:1)
let {this} = x Expected error message: 'this' can not be used as shorthand property (1:5) Got error message: Binding this (1:5)
({this} = x) Expected error message: 'this' can not be used as shorthand property (1:2) But parsing succeeded.
var x = {this} Expected error message: 'this' can not be used as shorthand property (1:9) But parsing succeeded.
'use strict'; ({eval = defValue} = obj) Expected error message: 'eval' can not be used as shorthand property (1:16) Got error message: Assigning to eval in strict mode (1:16)
function* y({yield}) {} Expected error message: 'yield' can not be used as shorthand property (1:13) Got error message: Binding yield (1:13)
/\u{110000}/u Expected error message: ~ But parsing succeeded.

Loose

/[\uD834\uDF06-\uD834\uDF08a-z]/u "ExpressionStatement" !== "EmptyStatement" (type/0/body)

Stats

Normal parser: 981 tests run in 734ms; 7 failures.
Loose parser: 975 tests run in 467ms; 1 failures.
Total: 1956 tests run in 1201ms; 8 failures.

Does this still happen? It's clean on recent Chrome and Node versions.

All right, I guess I'll have to download and install Chromium.

By the way, I'm using the build from chromium.woolyss.com.

Things are passing in Chromium 55, so I'm going to close this.


Illegal expresssion Error while running "obc-peer" service on pulled image from docker hub

Pushed an image to docker hub after perform 'go build' and 'go test' commands from vagrant environment.
After successfully pulled the image from docker hub using docker pull repository-name, user trying to execute ./obc-peer peer command in vagrant box but he keeps on getting an error message saying Illegal expression

This issue needs more info. Is this still a problem?

It's working as expected now in softlayer machine and from Vagrant box. Able to start peer process after pulled an image from docker hub (pushed to docker hub from vagrant). We can close this issue.
docker pull .txt

@rameshthoomu is there more work needed on this?

No @ibmmark. We can close this issue.

Working as expected. Closing this issue.


In-line functionality into freckle/stack-action

https://github.com/freckle/stack-action
We never use this action on its own, nor the other. We always use them together. There seems to be precedent for this, such as setup-node handling caching, and the separate yarn-cache action(s) being obviated by that.
Combining them would also allow us to do interesting things like:

A separate actions/save call to save a dependency-specific cache after the build --dependencies-only step, with a less specific key
Another separate actions/save call to save the overall cache before running tests, so test failures retain cache. This would be a different possible solution to what motivated #38.

WDYT @mjgpy3 ?

I think that makes sense.
My only question would be the direction of this action as such.

Would this just become an archive repo or would we continue to maintain it?
Are there other consumers of just this who don't want stack-action? Is there a way to tell who we might be leaving behind? I know we get bug reports for this.

I would archive it and direct users to the new major version of stack-action -- unless there's concrete evidence there is a "not alongside stack-action" use-case. Is there?
It's not like we can't un-archive and re-maintain later, if evidence arrives later.

unless there's concrete evidence there is a "not alongside stack-action" use-case. Is there?
There is! But how much is enough?

Looking at the first half of the github results,I see these

https://github.com/BinderDavid/pointer-abstract-machine/blob/94a9fab51400cb9fec1264b5432656f3dc1e60a5/.github/workflows/ci.yml
https://github.com/poseidon-framework/poseidon-analysis-hs/blob/5442fbd1dc164b5550b747b8dbe0e34b89e2fa7c/.github/workflows/main.yml
https://github.com/Archaeology-ABM/nassa-hs/blob/ccc49ebe847f8d97587bae18035d64a1982fd4fa/.github/workflows/normalCheck.yml
https://github.com/miguel-negrao/arrow-utils/blob/1aefbf2e0ba6f55cf8ca0b2b091562720e07f016/.github/workflows/ci.yml
https://github.com/alessandrocandolini/fees-polysemy/blob/a126c0e65e3e776236c83fbc0f851f141f15e1fd/.github/workflows/ci.yml
https://github.com/lykmast/lh-to-coq/blob/634dad3f6e8dc70214977c9756a79b12c6f82632/.github/workflows/coq-test.yml

That seems like enough :shrug:

I did this in stack-action@v4. As mentioned, we probably don't want to Archive this action, but we should update the README to reflect that it's usually not necessary.


OpenFPGA seems doesn't support binding VTR's short type switch

Describe the bug

As my architecture file had the following content, especially the short type switch named adder_chain_wire, i needed to bind the switch to physical circuit. However, to my knowledge, OpenFPGA just supports mux type switch and direct connection in the directlist tag. Is there any helpful information?
Thanks!
<switchlist>
  <!-- mux_trans_size Specifies the size (in minimum width transistors) of each transistor in the two-level mux used by mux type switches. -->
  <!-- buf_size If set to auto, sized automatically from the R value. This allows you to use timing models without R’s and C’s and still be able to measure area. -->
  <switch type="mux" name="sb_mux" R="551" Cin="0.77e-15" Cout="4e-15" mux_trans_size="2.630740" buf_size="27.645901">
    <Tdel num_inputs="12" delay="${SB_MUX_DELAY}"/>
    <Tdel num_inputs="15" delay="${SB_MUX_DELAY}"/>
    <Tdel num_inputs="20" delay="${SB_MUX_DELAY}"/>
  </switch>

  <!-- Not currently allowing an ipin cblock switch to have fanin dependent values
    refer: home/data/shawn/eFPGA/Code/OpenFPGA/OpenFPGA/vtr-verilog-to-routing/vpr/src/base/CheckArch.cpp Line: 66 -->
  <!-- <switch type="mux" name="cb_in_mux" R="2231.5" Cout="0" Cin="1.47e-15" mux_trans_size="1.222260" buf_size="auto">
    <Tdel num_inputs="12" delay="${CB_MUX_DELAY}"/>
    <Tdel num_inputs="15" delay="${CB_MUX_DELAY}"/>
    <Tdel num_inputs="20" delay="${CB_MUX_DELAY}"/>
  </switch> -->
  <switch type="mux" name="cb_in_mux" R="2231.5" Cout="0" Cin="1.47e-15" Tdel="${CB_MUX_DELAY}" mux_trans_size="1.222260" buf_size="auto"/>

  <switch type="short" name="adder_chain_wire" R="0" Cout="0" Cin="0" Tdel="${CARRY_CHAIN_DELAY}"/>
</switchlist>

Correct. We will catch this feature soon.

You do not need to worry about the switch binding. You can specify the circuit model for the short switch using OpenFPGA's architecture description language:
https://github.com/lnis-uofu/OpenFPGA/blob/cd748b1a5e75e9d32422ced63ad5a46137c414a1/openfpga_flow/openfpga_arch/k6_frac_N10_adder_register_chain_40nm_openfpga.xml#L214

@tangxifan  Yep, i indeed did that as what you said , but the following description may incur problems as mentioned in https://github.com/lnis-uofu/OpenFPGA/issues/1174#issuecomment-1562196049, i.e. resulting the inconsistent between the fabric generated by OpenFPGA and the routing resource graph generated by origin VPR.
<direct name="adder_carry" circuit_model_name="direct_interc" type="column" x_dir="positive" y_dir="positive"/>


package.json should be updated with latest packages

I based my project off of this boilerplate, but was stuck for several hours due to the packages in package.json being quite old. They should be updated, and the code should be updated to go along with it.
I'll probably work on this myself in the next few days if I have time.

Hey @AgrimPrasad! I know it's been awhile since this issue was created. Do you know if this was fixed with the changes in #7?

Yup, this should be fixed with #7 Thanks for following up.

@AgrimPrasad Awesome!


Add explicit override modifier to ContractFactory subclasses

This should close #393 for Ethers v5 target.

as it's gonna break some users code due to prettier incompatibilities.

Don't we use that prettier version from our dependencies? I think we'd only break something if somebody has explicitly set a Prettier version in Yarn/pnpm resolutions.

Don't we use that prettier version from our dependencies? I think we'd only break something if somebody has explicitly set a Prettier version in Yarn/pnpm resolutions.

Yeah, you're right but still, #566 seems to me like a better, more generic fix. Why make an exception for this case if we plan on ignoring all similar cases in the future.
Furthermore, I am worried that without tests we will break it again in the near future...

Yeah, you're right but still, #566 seems to me like a better, more generic fix. Why make an exception for this case if we plan on ignoring all similar cases in the future.

I think we misunderstood each other. I didn't propose #546 and create #566 as an alternative to this, I made it in addition to this PR.
#566 is more generic, but I wouldn't call it better — it's a way to work around the problem in userspace, while this PR is a specific fix on our side.
If we generate code that gets compiled and typechecked in user's projects, we should strive to generate it as strict as possible. If you plan to ignore all similar cases in the futures, we can as well make the --ts-nocheck flag default to true, as a similar case will appear every two TypeScript versions when they introduce new flag.
Could we keep this open and merge when we release a major version of TypeChain that depends on TypeScript 4.3 or higher? (override modifier is introduced in 4.3)

Furthermore, I am worried that without tests we will break it again in the near future...

We have some "tests", as I added noImplicitOverride to our config, so our typecheck check tests this, but I can add a new one , with ts-snippet to configure TypeScript config per test perhaps?

We have some "tests", as I added noImplicitOverride to our config,

Ahh right, this takes care of my concern about regressions.
Okay, I didn't realize that this PR will prevent future regressions. That was my biggest concern basically -- I am fine with merging.

We can let this lie here for a bit and mature, as it will be a breaking change for users with old TypeScript.
What needs to be done

[ ] Add a memo to readme noting the required TS version per TypeChain version? Like fp-ts does?
[ ] Mention required versions of TypeScript and Prettier in the changeset
[ ] Ensure that the dependency version is correct


Inputs are being rendered with default system font instead of Bahnschrift

Expected:

Rendered:

I think this one should be fixed.


glfwGetVersionString returning wrong version.

OS and version: Ubuntu 18.04
Release or commit: 0ef149c8f2451fbc8e866834675a075cfc295b6c
Error messages: None
I was trying to get the version of the software just to check if my install is correct.
Here is the code sample is used:
#include <iostream>

int main(){
    std::cout << GLFW_VERSION_MAJOR << "." << GLFW_VERSION_MINOR << "." << GLFW_VERSION_REVISION << std::endl;
    std::cout << glfwGetVersionString() << std::endl;
    return 0;
}

And here is the output produced on my machine:
3.4.0
3.2.0 X11 GLX EGL clock_gettime /dev/js Xf86vm shared

So i guess there is a bug somewhere.

What are you compiler flag and how did you installed glfw?

This is the 3 instructions I ran from a build folder:
cmake -DBUILD_SHARED_LIBS=ON ..
make
sudo make install

I presume you build your app using -lglfw? If that so, most likely you have the correct include flags but you link to the wrong library. In CMake, you'd have to do this:
find_package(glfw3 3.4.0 REQUIRED) # You tell the version
target_link_libraries(your_target PUBLIC glfw) # Link and add include dirs

If you link using the compiler directly, you have to replace -lglfw by /usr/local/lib/libglfw3.a or wherever you installed it.

So I just tried compiling with:
g++ glfw_test.cpp /usr/local/lib/libglfw3.so.3.4
g++ glfw_test.cpp /path/to/build_dir/libglfw3.so.3.4 just to make sure I'm using the right compiled lib.
and with a quick makefile using the find_package as metioned:
cmake_minimum_required(VERSION 3.5)

set(BIN_NAME test)
find_package(glfw3 3.4 REQUIRED)

add_executable(${BIN_NAME} glfw_test.cpp)

target_link_libraries(${BIN_NAME} PUBLIC glfw)

And
g++ glfw_test.cpp -lglfw
and got the same result every time.

That was indeed the issue, I have Mujoco installed that comes shipped with a compiled version of glfw 3.2.0.
Thank you for your help!


Pleiades

Ode function has an error:
This code is wrong,
for i in 14:28
du[i] = zero(u[1])
end
It would be
for i in 15:28
du[i] = zero(u[1])
end
Regards,

Good catch. Thanks! Fixed in https://github.com/SciML/DiffEqBenchmarks.jl/commit/54d390aacc410c5c469bf6e67222f8fb8fad4724 .
BTW, let me know what a good benchmark is to showcase your method in a good light and I'll add it in there.


[Bar Chart] Tooltip placement with multiple datasets and stacked xAxes

Hello and thanks for this amazing work!
Here is a bug report for an issue with the tooltip placement happening with the Chart of 'bar' type, when stacking multiple datasets on the X axes. First, let me start with an image to be explicit:

In the screenshot above, the tooltip should be pointing over the top of the purple bar, not within the yellow one since the cursor (not shown here I'm sorry) is hovering over the purple one. This happens for all datasets but the last one (when having more than 2). I suspect this is due to the position of the tooltip being computed for each datasets before the subsequent datasets have been processed and the yAxes scale have been updated (but I didn't get much into the code base, my suspicion is probably wrong).
Here is a JSFiddle demonstrating the bug: http://jsfiddle.net/bymx7gbo/4/
This has been tested in both Firefox 48.0a2 and Chrome Version 50.0.2661.102 (64-bit) on MacOS X El Capitan.
The version of ChartJS is V2.1.3.
While I'm there, here is a suggestion that I would have found useful (sorry if the feature does already exist): add an option to display the tooltip next to the user cursor (instead of on the top of the hovered bar).

I'm having the same problem. I asked on StackOverflow, but now I'm confident this isn't my fault :-)
Here is my test data: http://gknudsen.no/chart/testchart.html Note that I'm combining a line plot as well, and the same bug occurs. Is there any fix or workaround to this problem?
Btw, please note that the tooltip becomes correct if you "hide" datasets such that there is no overlap (in the x-axis). In the above example, hide the second (yellow) dataset to fix the purple tooltip. Same goes for my example, including for the line plot.

It seems the problem can be fixed by changing the getAveragePosition function (line 7141 in current version of Chart.js). The tooltip position is averaged over all data points occupying the same "slot" on the x-axis. While this makes sense for the x-coordinate, centering the tooltip, it seems to me in this case (with stacked data) that we want the y-coordinate to be fixed (not the average of all the y-points).
return {
   x: Math.round(x / xPositions.length),
   y: Math.round(y)     //y: Math.round(y / xPositions.length)
};

This is just meant as an input to the discussion. The function is used for all chart types (right?) so this hack will surely interfere with situations where we do want the average y-coordinate? Anyone know how to take this further?

Actually, this does not hold if data points are not strictly decreasing (in displayed order, back to front). yPositions is ordered the other way around, so in my case I simply need to always get the first point. That's the data set the mouse is pointing on. If a smaller data set is "behind" it, then I still want the tooltip to indicate the larger front column. Otherwise, if a smaller data set is "after" it, then I want that front-most column to get the tooltip.
        getAveragePosition: function(elements) {

            if (!elements.length) {
                return false;
            }

            var xPositions = [];
            var yPositions = [];

            helpers.each(elements, function(el) {
                if (el) {
                    var pos = el.tooltipPosition();
                    xPositions.push(pos.x);
                    yPositions.push(pos.y);
                }
            });

            var x = 0,
                y = 0;
            for (var i = 0; i < xPositions.length; i++) {
                x += xPositions[i];
                y += yPositions[i];
            }

            if (xPositions.length > 1) y = yPositions[0];  // new line

            return {
                x: Math.round(x / xPositions.length),
                y: Math.round(y)     //modified:    y: Math.round(y / xPositions.length)
            };

        }

This was fixed in #3400 and #3453


Require opting in to repr-less types?

Some of our derives support types without reprs because they're not required for soundness. This can be useful if you don't care about layout stability (and perhaps you care about allowing the compiler to make layout optimizations), but it's a big footgun: it makes it easy to accidentally write code which depends upon type layout without realizing it.
Perhaps we should require users who wish to not use reprs to opt-in to this behavior; something like:
#[derive(FromZeroes, FromBytes)]
#[allow(zerocopy::missing_repr)] // Is this legal? Maybe we need the syntax below instead.
struct Foo;

#[derive(FromZeroes, FromBytes)]
#[zerocopy(allow(missing_repr))]
struct Bar;

This would be a semver-breaking change, but a minor one, and our error message could suggest the allow to steer users in the right direction.
Note one important subtlety: On its own, this isn't sufficient: if a struct contains another type with a non-stable representation, then even if the outer struct is, e.g., repr(C), it isn't sufficient to guarantee the stability of the outer type's layout.
It seems unlikely, but perhaps we could also have zerocopy-derive emit a warning that users can allow using rustc's built-in machinery. According to this documentation, warnings are not currently supported except on nightly, so this may be a non-starter.

The goal of this feature is to ensure that customers using zerocopy to serialize and deserialize values are doing so consistently. But to achieve this, a StableRepr trait would need to be remarkably pedantic — the alignments of Rust's numeric primitives are unspecified, and changes to their alignments can easily impact their offsets in compound types.
I'm on the fence about whether this ergonomic tax is justified by its benefits.

I wonder whether we can just do a more limited analysis - we warn or error if you derive on a type with no repr, and we provide an attribute to silence the warning/error. That's it. No recursive analysis or extra trait.  It's more like a Clippy lint - "are you sure you meant to do this? Doing this is often just an oversight on the part of the programmer." We'd need to figure out how to design the API to make it clear that this is just a lint and not a guarantee, but I think that'd be a good middle ground.

If we're aiming for a lint, perhaps a lint would be best! We could either:

propose a clippy lint
ship a rust-marker lint of our own

The benefit of a lint is that the diagnostic could be much better and actually explain things like platform-specific alignment.

Would Clippy accept a lint that depends on knowing about zerocopy?

Would Clippy accept a lint that depends on knowing about zerocopy?

Specifically for zerocopy? No, but this is a general problem. Even bytemuck doesn't account for layout fluctuations caused by platform-specific alignment.

Also, FWIW, those approaches would not be particularly discoverable.

Our derives can check for the explicit presence/absence of #[allow(<lint name>)]/#[deny()]` and require that one of those directives be present.

Would Clippy accept a lint that depends on knowing about zerocopy?

Specifically for zerocopy? No, but this is a general problem. Even bytemuck doesn't account for layout fluctuations caused by platform-specific alignment.

My concern isn't about #[repr(C)] type which contains a u16 (although that's also something that's possibly worth linting about), but about a type without any repr that derives one of our traits. Clippy would need to know what #[derive(FromBytes)] means in order to know that that's bad.

Clippy would need to know what #[derive(FromBytes)] means in order to know that that's bad.

It wouldn't; clippy would only need a general missing_repr lint that's allow-by-default. We can either then hard-code our derives to look for #[allow(clippy::missing_repr)]/#[deny(clippy::missing_repr)], or we can change our expansion to turn the lint on in a local context; something like having this:
#[derive(FromBytes)]
struct Foo(Bar, Baz);

additionally emit:
#[deny(clippy::missing_repr)]
const _: () = {
    struct Foo(Bar, Baz);
};

...which would trigger the clippy lint.

I've started a zulip topic to discuss. A rustc lint would be ideal, but the bar there is higher for getting it totally right on our first go.


Remove additional CORS settings

@devoncarew TBR These values are now being set in one of the libraries, which was resulting in them being set twice, and hence causing requests to fail.
With this change the dev deploy of the UI talks successfully with a dev deploy of the services library. Doing more manual testing now.

Interesting - is this now done by rpc?
We might also hit the server with a client running on Safari, which has historically been twitchy w/ CORS settings.
lgtm


Feature request: Pause/resume transfers

I'm archiving fairly large amounts of data, but our upload bandwidth is limited.  It would be incredibly useful to be able to pause transfers and resume them later.

We have been transferring large virtual machine images lately and when a upload files at somewhere between 90-99% - you need to restart uploading 200GB + large files gets quite boring and ineffective use of time. Please make this happen ;-)

I had a large download from ADLS gen2 to my local Macbook that failed half-way because of flaky network connectivity (for a minute, after 2 hours of download).
Can you add a "resume" or "continue" download feature for such cases?
Would it be better if I filed a separate feature request, or is this comment here OK?

Yes, a job history with pause/resume/auto-resume is really needed. I was transferring several TB when the host server I was running Storage Explorer on was rebooted for maintenance. Luckily, now that Storage Explorer uses AZCopy, I was able to resume it from command line using AZCopy on that server by changing to:
cd "C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\node_modules\se-az-copy-exe-win\dist\bin"
Login:
azcopy_windows_amd64.exe login --tenant-id=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxx
Get list of jobs:
azcopy_windows_amd64.exe jobs list
show status of the job:
azcopy_windows_amd64.exe jobs show 00000000-1111-2222-3333-4444444444
Percent Complete (approx): 66.4
Final Job Status: InProgress
Resume the job:
azcopy_windows_amd64.exe jobs resume 00000000-1111-2222-3333-4444444444

I could use this feature too, for same reasons others have mentioned.

I could use this feature too, for same reasons others have mentioned.

I`m looking someway to pause and resume as well

May I ask how is development of this feature going?
My non-dev colleague was asking me about this pause and resume feature of Microsoft Azure Storage Explorer.
Much appreciated if there is some feedback on this.

Thank you all for the requests. Once our dependencies support pause and resume, we will add it in Storage Explorer. We know that this is one of the highly asked features. We will prioritize it in our backlog.  Thanks again!

Please ensure this feature request includes resuming a broken download where it left off. We have large files that never completes downloading due to various reasons, and have to start over and attempt multiple times.

I'm surprised this feature hasn't been added yet!

Come on man!  This is sorely needed or at least a documented work around similar to something posted above.
https://github.com/microsoft/AzureStorageExplorer/issues/1279#issuecomment-632120246


Update README.md

Fix the up command, which in the readme was missing the -d option to run the app in detached mode as said by the comment two rows above.

Thank you so much @Jean85!


Create attack-ranges

Displays the player's attack range for their currently equipped weapon.
This is similar to some of the other line of sight plugins/settings but automatically renders on weapon or attack style changes. I did a best-effort attempt to catalog all weapons but I am sure I missed some and I have not done extensive testing.
I tested:

Bowfa
Rune cbow
magic shortbow (i)
Red chin
Dragon knife/thrownaxe
Air battlestaff
Dorgeshuun cbow

The general idea was given an OK, but will call out anyways that I could see this potentially violating the following Jagex guideline:

Anything that automatically indicates where to stand, or not to stand. This applies to only automatic indicators, and not tiles which have been manually marked.

I plan to extend this to NPCs at some point, but decided to prune out what I had in progress for now, so there might be some remnants of that that work in the current case, but might not exactly look right in the current state (e.g. the tile visibility check).

You can still host your images on your repo, just don't put them in src/

I'll update getVisiblePoints.
Gauntlet seems fine, unless there's something I'm missing:

Also CoX seem okay from the first few rooms (I have yet to do the raid), and PoH works but will probably just disable it there

Hmm, it actually works better than I had expected :eyes: I see now that you're using world coords without mapping from instances to template chunks, so this should actually work quite nicely even in assembled instances.

Incidentally, I just ran into an NPE which you might want to fix. It's possible for Perspective.getCanvasTilePoly(client, lp) to return null, so it requires a null check.

I've fixed the NPE and moved the point calculations to onGameTick.
Also, here's a screenshot in the POH checking across rooms of the same type (it was brought up in discord):


Axon 2 Quartz jobs cannot be deserialized

The EventScheduler stores a GenericEventMessage in its job data but this class has been moved.

Hey guys,
I sent in this issue a while ago to spark some discussion on how to go about solving this but there hasn't been any feedback or otherwise.
This is a pretty major issue on the backlog :). Basically it breaks migration from Axon 2 to 3 for any project that is currently in production (that uses Quartz). Also, solutions are quite hard because Java serialisation is used to store Quartz jobs.
A while ago the only work-around I could build was to override Axon code by copy-pasting entire classes (including class path) and making changes there. Obviously that is bad, even for work-arounds.
Pinging @smcvb and @abuijze in the new hope of sparking some discussion on this topic.

Hi Rene,
don't expect too much discussion, I agree that this is an issue with migrating. I've been thinking on how we could resolve this. One way I can think of, is by creating (preferably in a separate jar) a class that is compatible with the old serialized format of jobs and will send messages in the 3.0 style. The Event Bus (if I'm not mistaken) is expected to be part of the scheduler's context, so that's not part of the serialized form.
Perhaps your workaround is what we'd need in this "transition" module?
Cheers,
Allard

I'll put out a PR of what I've built

See PR https://github.com/AxonFramework/AxonFramework/pull/349

Merged in cd45aeb (axon-3.0.x branch)


Using uploadReactNativeMappings = true, and having enableHermes=true gives "A source map was found but could not be applied because it doesn't match the code."

Describe the bug
I have used npx @bugsnag/react-native-cli automate-symbolication to set the uploading of react native source mapping.
But when I also set enableHermes=true I get :
A source map was found but could not be applied because it doesn't match the code..
If I set enableHermes=false, and do a rebuild, everything works fine and I do not get a warning in the Bugsnag UI.
I see that the source map is uploaded in both cases going into Project settings > Source maps
Environment
@bugsnag/react-native: ^7.14.0,
@bugsnag/source-maps: ^2.3.0,
react-native: 0.66.3,

I only get this issue on Android.
With Hermes enabled:

Without Hemes enabled:

I have dug into the react-native/react-gradle, and I see that sourcemap-output  varies depending on whether hermes is enabled or not.
            commandLine(*execCommand, bundleCommand, "--platform", "android", "--dev", "${devEnabled}",
                "--reset-cache", "--entry-file", entryFile, "--bundle-output", jsBundleFile, "--assets-dest", resourcesDir,
                "--sourcemap-output", enableHermes ? jsPackagerSourceMapFile : jsOutputSourceMapFile, *extraArgs)

Logging the values:
jsPackagerSourceMapFile: android/app/build/intermediates/sourcemaps/react/bntest/release/index.android.bundle.packager.map
jsOutputSourceMapFile: android/app/build/generated/sourcemaps/react/bntest/release/index.android.bundle.map

Do the uploadReactNativeMappings take sourcemap-output variations depending on if hermes is enabled or not, into account?
Any help is appreciated, thanks in advance!

Hey @yberstad are you cleaning the project between builds? I'm wondering if there are some leftovers from the non-Hermes build interfering. Use cd android && ./gradlew clean: https://reactnative.dev/docs/hermes#android

Do the uploadReactNativeMappings take sourcemap-output variations depending on if hermes is enabled or not, into account?

Yes, we build the path to the sourcemap, as RN's Gradle script can modify the output source map path: https://github.com/facebook/react-native/blob/v0.66.3/react.gradle#L175

Hi @xander-jones, thank you for your quick reply!
Yes I'm cleaning the project between builds. I now deleted the whole build folder, but I still get the error.
From the output of the build.
With hermes:
Bugsnag: uploading react native sourcemap: [/Users/oyvind/myagent/_work/1/s/node_modules/@bugsnag/source-maps/bin/cli, upload-react-native, --api-key, <our-api-key>, --app-version, 4.0.0, --app-version-code, 514, --platform, android, --source-map, /Users/oyvind/myagent/_work/1/s/android/app/build/generated/sourcemaps/react/prodtest/release/index.android.bundle.map, --bundle, /Users/oyvind/myagent/_work/1/s/android/app/build/intermediates/bugsnag/rescued/Prodtest-release.android.bundle, --project-root, /Users/oyvind/myagent/_work/1/s]
Bugsnag: uploaded react native sourcemap: [info] Preparing upload of React Native source map (release / android)
[debug] Reading source map "/Users/oyvind/myagent/_work/1/s/android/app/build/generated/sourcemaps/react/prodtest/release/index.android.bundle.map"
[debug] Reading bundle file "/Users/oyvind/myagent/_work/1/s/android/app/build/intermediates/bugsnag/rescued/Prodtest-release.android.bundle"
[info] Applying transformations to source map
[debug] Ensuring sourcesContent field is populated
[debug] Stripping project root from sources
[debug] Initiating upload to "https://upload.bugsnag.com/react-native-source-map"
[success] Success, uploaded /Users/oyvind/myagent/_work/1/s/android/app/build/generated/sourcemaps/react/prodtest/release/index.android.bundle.map and /Users/oyvind/myagent/_work/1/s/android/app/build/intermediates/bugsnag/rescued/Prodtest-release.android.bundle to https://upload.bugsnag.com/react-native-source-map in 2030ms

Without hermes:
Bugsnag: uploading react native sourcemap: [/Users/oyvind/myagent/_work/1/s/node_modules/@bugsnag/source-maps/bin/cli, upload-react-native, --api-key, <our-api-key>, --app-version, 4.0.0, --app-version-code, 515, --platform, android, --source-map, /Users/oyvind/myagent/_work/1/s/android/app/build/generated/sourcemaps/react/prodtest/release/index.android.bundle.map, --bundle, /Users/oyvind/myagent/_work/1/s/android/app/build/generated/assets/react/prodtest/release/index.android.bundle, --project-root, /Users/oyvind/myagent/_work/1/s]
Bugsnag: uploaded react native sourcemap: [info] Preparing upload of React Native source map (release / android)
[debug] Reading source map "/Users/oyvind/myagent/_work/1/s/android/app/build/generated/sourcemaps/react/prodtest/release/index.android.bundle.map"
[debug] Reading bundle file "/Users/oyvind/myagent/_work/1/s/android/app/build/generated/assets/react/prodtest/release/index.android.bundle"
[info] Applying transformations to source map
[debug] Ensuring sourcesContent field is populated
[debug] Stripping project root from sources
[debug] Initiating upload to "https://upload.bugsnag.com/react-native-source-map"
[success] Success, uploaded /Users/oyvind/myagent/_work/1/s/android/app/build/generated/sourcemaps/react/prodtest/release/index.android.bundle.map and /Users/oyvind/myagent/_work/1/s/android/app/build/generated/assets/react/prodtest/release/index.android.bundle to https://upload.bugsnag.com/react-native-source-map in 1853ms

To me it seems like the source map is the same even if we are using hermes or not?
And what is the /bugsnag/rescued/Prodtest-release.android.bundle  that is used while using hermes?

Hi @yberstad,

what is the /bugsnag/rescued/Prodtest-release.android.bundle that is used while using hermes?

This is generated by us - Hermes overwrites the generated JS bundle, so we save the unmodified bundle before that happens.
Can you send us a link to an example event in your Bugsnag Dashboard that is displaying the 'source mapping failed' banner so that we can investigate further? You can write in to us at<EMAIL_ADDRESS>or drop a link here.

@yousif-bugsnag, thanks for getting back to me! I sendt you an mail with the info you requested.

Hi @yberstad, thanks for getting in touch! Your link helped us to pin down what was happening here. The issue has now been resolved via the support ticket, but for the benefit of future travellers:
When using Hermes, the bundling works as follows:

Metro builds a JS bundle with a source map.
Hermes compiles the JS bundle to bytecode and creates its own (partial) source map.
The source maps from (1) and (2) are merged to create the final source map (see here)

The final combined source map is what is uploaded to Bugsnag - this contains the correct mappings to be able to map back from the hermes bytecode bundle to the original JS sources.
The reason the 'source mapping failed' banner is being shown in this particular case is that the event stacktrace contains frames originating from hermes internal bytecode, e.g. /tmp/hermes/.../InternalByteCode.js.
Since this is not part of the app bundle the source map does not contain mappings for those frames, leading to the warning banner being displayed, but the source map is valid and all other frames are being mapped correctly.
We have an item on our roadmap to make that banner clearer in situations such as this where we are able to apply source maps to some frames and not others.


Updates in TPM 3.1

Docs Build status updates of commit 3971661:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:bulb:Suggestion
View (skype-ps)
Details

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md

Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'Fqdn' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'MultiValuedProperty' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'String' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'Unlimited' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'Guid' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'CommonParameters' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f1b6abf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 75e799d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 1a66787:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d16270f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:bulb:Suggestion
View (skype-ps)
Details

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineUser.md

Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'some-xml-string' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit c76872a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:bulb:Suggestion
View (skype-ps)
Details

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineUser.md

Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'some-xml-string' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@JohanFreelancer9  committed the suggested changes. Thanks!

Docs Build status updates of commit 3e54514:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:bulb:Suggestion
View (skype-ps)
Details

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineUser.md

Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'some-xml-string' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 16fddb9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:bulb:Suggestion
View (skype-ps)
Details

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineUser.md

Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'some-xml-string' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@dariomws @tseward @get-itips

Docs Build status updates of commit 061dc2a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:bulb:Suggestion
View (skype-ps)
Details

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineUser.md

Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'some-xml-string' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f7e6b6d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:bulb:Suggestion
View (skype-ps)
Details

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineUser.md

Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'some-xml-string' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@dariomws done, made appropriate changes. Thanks!

@tseward

@JohanFreelancer9 Done!

Docs Build status updates of commit 82129da:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:bulb:Suggestion
View (skype-ps)
Details

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineUser.md

Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'some-xml-string' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 5e01bf8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:bulb:Suggestion
View (skype-ps)
Details

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineUser.md

Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'some-xml-string' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@JohanFreelancer9 Done!

@isrumnon, thank you so much for committing the changes, but you seem to have missed two suggested changes. Could you please commit them as well? Thanks again.

@JohanFreelancer9 oh I must have missed those. Committed them, thanks

Docs Build status updates of commit 02fdb95:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:bulb:Suggestion
View (skype-ps)
Details

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineUser.md

Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'some-xml-string' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@tiburd Please merge this PR. Thanks

Docs Build status updates of commit 2837443:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:bulb:Suggestion
View (skype-ps)
Details

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineUser.md

Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'some-xml-string' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel