Jitpack for v4.1.0 is broken

Describe the bug
See https://jitpack.io/com/github/MobilityData/gtfs-validator/v4.1.0/build.log
Looking at Jitpack's logs, the two main issues are missing documentation for various params and return values and no test artifacts, which together cause the build to fail in such way that nothing is published.
Steps/Code to Reproduce

Click "Get It" on https://jitpack.io/#MobilityData/gtfs-validator for v4.1.0
Wait for ages
build is broken

Expected Results
Working build so that I could use gtfs-validator's latest&greatest as Maven dependency.
Actual Results
No artifact available.
Screenshots
No response
Files used
No response
Validator version
4.1.0
Operating system
unrelated
Java version
No response
Additional notes
No response

We are facing the same issue, and are also unable to upgrade the package version as a result

Removed the failed build on jitpack (https://jitpack.io/#MobilityData/gtfs-validator) then did a build on a local test project and jitback rebuilt fine. It should now be available.
As to why it failed before and not now, I have some theories:

I suspect the problem comes from https://github.com/freefair/gradle-plugins/issues/640. One of the logs for the failed build said:

Execution failed for task ':aggregateJavadocJar'.
Could not add file '/home/jitpack/build/build/docs/aggregateJavadoc/gtfs-validator-4.1.0-javadoc.jar' to ZIP '/home/jitpack/build/build/docs/aggregateJavadoc/gtfs-validator-4.1.0-javadoc.jar'.

i.e. it was trying to add a jar file to itself. This fits with the bug.

There was a change done in freefair that could have solved the problem, although I am not sure it affected the version we use: https://github.com/freefair/gradle-plugins/commit/1ac0180260d6781c1cd7bc15380ad230b4e5ef3e

Another possibility is that jitpack changed something in the way they build. In particular it seems that the freefair bug occurs on some linux distros, but not others. Maybe they changed the distro they use for building? Or some other change on their end.

on the gtfs-validator side, it's building from v4.1.0 tag, so there was no change that could explain why it was broken but not anymore.

For reference I attached the log of the failed build here, since it was overwritten when the new successful build was done.
jitpackProblem.txt


MinWidth, MaxWidth

Hey!
This is great. A cooperation with https://github.com/jroimartin/gocui would have been cool, if possible.
Anyway, I was wondering if some kind of "MinWidth"/"MaxWidth" could be specified. This would have been very handy. With these, it would try to keep these values as much as it could, when layouting. For example, now I have a list column to the left that I don't need to expand in width when resizing. And, It gets a bit too small to fit the text when going down in size (I use NewCol(2), NewCol(10)), so having these around would make it possible for me to specify a size range it could be within, while the "column" to the right of it expanded as appropriate.
Thanks!

Size() from termbox could be used or getTermSizeInChars() from https://github.com/gizak/termui/pull/233 (only ANSI terminals).


Ship /etc from /usr through an overlay mount

The existing tmpfile logic took care of folders that the ebuild keepdir directive wanted to exist on the OS. However, files and symlinks were not created, causing them to be missing if we didn't explicitly modify the ebuild files in coreos-overlay to use tmpfiles or patching of paths to be in /usr. We need a logic to provide /etc files from the current /usr partition without getting stale. This can be done best with an overlay mount which requires to keep the original /etc files under /usr.
Move the final /etc folder of the image build to /usr/share/flatcar/etc to serve as lower layer in the overlay. Also remove any state from the rootfs to make sure that we don't rely on it when testing our images before the release. What we get with an overlay mount is essentially a similar behavior to a 3-way merge because as long as the user didn't change the files, the old version is replaced with the new version and as soon as the user did changes, that file is frozen and wins over the provided old (in case of a rollback) or new versions from /usr. It does not work on file lines but on whole file contents, yet that is also what rpm-ostree does to my knowledge. Also, run tmpfiles once and do the SELinux labeling to prevent files being created in the upperdir because they were missing in the lowerdir, or because they had missing SELinux labels.
How to use
Together with https://github.com/flatcar/bootengine/pull/53
Testing done
See linked PR
↓ will do the changelog in the coreos-overlay PR

[ ] Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
[ ] Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

This supersedes https://github.com/flatcar/scripts/pull/264


Fix typescript / typescript-eslint version problem

Fix "WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree."

A more experienced friend let me know that we should probably just ignore this.


chore(main): release 1.13.0

:robot: I have created a release beep boop
1.13.0 (2024-12-08)
Features

add short aliases for commands (#100) (9595a16)
better description and title for prompts (#105) (b4148f9)
change alias from vc to v (#102) (b1d5534)
remove init function (#98) (b321578)
use base theme instead of colored theme (#103) (17d01e3)
use built-in ErrUserAborted instead of == check (#104) (244ccad)

Bug Fixes

exit if not confirm cwd for backup (#101) (5a80c67)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.13.0
:sunflower:


Empty menu item in automatic export

Zotero version: 5.0.97-beta.55+3b993b2af
BBT version: 5.6.8
Support log ID: SH99WY32-refs-euc
Exporter used: Better BibTex
Expected behavior: I think there should be a tick option in the menu for automatic export
Actual behavior: The menu is an empty entry for automatic export. At first I had not used the Better BibTex exporter and didn't see the keep updated tick in the export options. Now I have auto export working but this menu item is still empty

This menu was only expected to appear and populate when you have auto-exports set to manual or on idle. build 1816 should fix it.

Can confirm it's fixed. Thanks!


[Locale Selector] Does not load in IE11

Detailed description

Describe in detail the issue you're having.

This was reported from URX. The locale selector loads as blank when in IE11. Test environment from their end:
https://wwwstage.ibm.com/account/reg/us-en/signup?formid=urx-19907
This was also reproducable on our nextjs ssr environment:

The issues appear to be missing polyfills for IE11:

What browser are you working in?

IE11

What version of the IBM.com Library are you using?

v1.4.0-rc.2
Steps to reproduce the issue

Go to http://ibmdotcom-nextjs-test.mybluemix.net/ in IE11
See locale selector button in the footer

This was an issue submitted by URX.  DDS dev provided a work around to turn off the Locale Selector for IE11.


Configure Dependabot

Signed-off-by: Gábor Lipták<EMAIL_ADDRESS>1. Issue, if available:
2. Description of changes:
3. Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: link to issue
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

#976
gomod updates are not readily green

What do you mean by this?

Just looking at the Go package updates failing compile https://github.com/aws/karpenter/pulls?q=is%3Apr+dependabot+is%3Aopen


Respect main screen scale on convertFromData for UIImage

Without scale: parameter, the image size will be matched to the pixel-based dimensions, which will cause size issue for auto-resizing-UIImageView such as imageView in UITableViewCell.

@hpique ?

@cxa wouldn't it be better with a lazy init ?

@dcharbonnier in Swift, global and static vars are computed lazily.

nice, I didn't know :-)


I have a data question! thanks

Why is the amount of work described in the author table different from the actual amount in the works file

For example, looking up author 2686522 from the authors table has a total of 26 works, but only 5 is actually found from Works

Hi, tks for the issue 👋🏻
We will look into that soon.
My intuition tells me that the author has more works that are not within DBLP. So they are outside of computer science.

I looked at this problem, and it seems the intuition was right. Since we are using SemanticScholar data alongside DBLP from v2.0 on, the total numbers relate to everything in SemanticScholar (possible outside of DBLP) while the actual works are only inside DBLP. We created this issue in the cs-insights-crawler, our latest active project working with D3 data.


Support converting markdown line to html horizontal line

The objective is to support the conversion of the markdown line --- to the HTML horizontal line <hr />.

fixed https://github.com/Myrfion/izyum/commit/5ddf36f47e5a0873677e8f9de91d8d04400f8b22


Feature/managemap ui

Updated the 'manage maps' features. Implemented solution for fetching and adding maps for users. This solution is currently depending on locally hosting firebase cloud functions.

[ ] Does the PR description accurately reflect the changes made?
[ ] Do the commit messages accurately reflect the changes made?
[ ] Is the changelist for this pull request under ~200 lines? (Excepting automatically generated code and package installations)
[ ] Does the code follow the coding style guidelines that we have set up?
[ ] Does the coder include unit tests for his functions?
[ ] Does the QA who reviews the code include his unit tests for all the functions?
[ ] Is there a documentation in place if the functions is related to how users build, test, interact with, or release code?

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


categorical variables value group and auto-binning

categorical variable value could a group of raw values;
do dynamic binning for categorical variables

done


DrawToolContent: fix usage of model properties

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 99.489%

Totals

Change from base Build<PHONE_NUMBER>:
0.007%

Covered Lines:
10091

Relevant Lines:
10093

💛  - Coveralls


Timber::get_terms arguments not working

I am trying to only display the top level elements of a taxonomy, but for some reason the hierarchical argument does not seem to work. I tried orderby and this also does not work?
$context['products'] = Timber::get_terms('products', array('hierarchical' => 0));
When I remove 'Timber::' it works perfectly, any ideas?
$context['products'] = get_terms('products', array('hierarchical' => 0));

The difference may be because Timber::get_terms by default shows empty results which is a good thing. I have used parent=0 to solve this, but will leave the issue open in case there is an issue with hierarchical.

@Quirksmode is this still an issue for you?

I am going to close this as I haven't had a reply. Feel free to comment at any point in time and I will re-open.

I can reproduce the issue as well:
$context['locations'] = \Timber::get_terms('location' , array(             'hide_empty' => true         ));
don't work for me.

Sorry, my fault. The count value of my term was not up to date.


[BUG] ViT in1k model weights key error on loading from hugging face

Describe the bug
Loading hugging face models from How to train your ViT (augreg) weights, pretrained on 21k FT on in1k model weights fails.
To Reproduce
Steps to reproduce the behavior:
requirements.txt
timm==0.6.12
torch==1.13.1
torchmetrics==0.11.1
torchvision==0.14.1

import timm

model = timm.create_model("hf_hub:timm/vit_large_patch16_224.augreg_in21k_ft_in1k", pretrained=True)

(breaks on other model weights from vit aug reg as well)
Expected behavior
Load model.
Screenshots
Python 3.10.6 (main, Nov 14 2022, 16:10:14) [GCC 11.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import timm
>>> timm.create_model("hf_hub:timm/vit_large_patch16_224.augreg_in21k_ft_in1k", pretrained=True)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/agr/Documents/rre/env/lib/python3.10/site-packages/timm/models/factory.py", line 71, in create_model
    model = create_fn(pretrained=pretrained, pretrained_cfg=pretrained_cfg, **kwargs)
  File "/home/agr/Documents/rre/env/lib/python3.10/site-packages/timm/models/vision_transformer.py", line 926, in vit_large_patch16_224
    model = _create_vision_transformer('vit_large_patch16_224', pretrained=pretrained, **model_kwargs)
  File "/home/agr/Documents/rre/env/lib/python3.10/site-packages/timm/models/vision_transformer.py", line 790, in _create_vision_transformer
    pretrained_custom_load='npz' in pretrained_cfg['url'],
KeyError: 'url'
>>>

Seems there was a bug in timm==0.6.12?
For now a workaround is:
pip install timm==0.8.15.dev0

Cheers for the repo rwightman!


Modify operator to use operator-sdk v0.19.2

The operator currently uses operator-sdk v0.9.0 which is old. The operator needs to upgraded to recent versions.

@hexfusion  @alaypatel07 This includes rebuilding the operator image. Can you give access to push the image to this repo https://quay.io/repository/alaypatel07/etcd-ha-operator or creating a new repo works as well.

@HariNarayananMohan you can raise a PR and we will gladly merge it.


Fix (define) append!!(::Empty, ::Empty)

Codecov Report

Merging #127 into master will increase coverage by 2.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   86.89%   88.92%   +2.02%
==========================================
  Files          20       20
  Lines         351      343       -8
==========================================
  Hits          305      305
+ Misses         46       38       -8

Impacted Files
Coverage Δ

src/NoBang/base.jl
94.66% <0.00%> (-1.34%)
:arrow_down:

src/macro.jl
100.00% <0.00%> (+5.00%)
:arrow_up:

src/NoBang/singletoncontainers.jl
100.00% <0.00%> (+11.53%)
:arrow_up:

src/NoBang/NoBang.jl
100.00% <0.00%> (+33.33%)
:arrow_up:

src/BangBang.jl
100.00% <0.00%> (+44.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a6a7a...5925c74. Read the comment docs.

Codecov Report

Merging #127 into master will increase coverage by 2.02%.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a6a7a...5925c74. Read the comment docs.


⚠ Itaca Gallery has degraded performance

In c893fea, Itaca Gallery ($SITE_TCGLR) experienced degraded performance:

HTTP code: 200
Response time: 8123 ms

Resolved: Itaca Gallery performance has improved in 6584c57 after 5 minutes.


Rename the project to environment

Motivation
Fixes #50
Checklist

[ ] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[ ] Tests are passing
[ ] Docs have been updated (if applicable)
[ ] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test
If manual testing is required, what are the steps?

Please check mainly the readme itself. Some parts required to keep "project" in naming and some needed replacement to keep the semantics.


Misleading documentation for dotnet test

I was looking for a way to run tests with net core on x86 and found link to .runsettings file [1], it says that I can use <TargetPlatform>x86</TargetPlatform> option which is wrong, on .net core it does nothing. You should just download .net core x86 and run tests from it.
[1] https://docs.microsoft.com/en-us/visualstudio/test/configure-unit-tests-by-using-a-dot-runsettings-file?view=vs-2019
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61ca4064-7481-a263-60fc-c70127f2ad16
Version Independent ID: 2878af44-8208-7bd8-46d4-3acda3e82ce0
Content: dotnet test command - .NET Core CLI
Content Source: docs/core/tools/dotnet-test.md
Product: dotnet-core
Technology: dotnet-cli
GitHub Login: @mairaw
Microsoft Alias: mairaw

Hello, thank you for bringing this issue to our attention. In researching this issue I found microsoft/vstest#1128 which seems to confirm your issue. We should update this in the docs.


feat: [EP-1882] add organization update

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat(node): allow uprotected txs flag for proxy deploy for devrel team

defaults to false if variable is not set

Since our node has enabled EIP-155, emm not sure will this work?

@davidtaikocha
We are trying to deploy a deterministic proxy contract.
This method: https://github.com/Arachnid/deterministic-deployment-proxy requires us to send a signed transaction with RLP only valid before EIP-155.
Therefore, we need to set the following flag
rpc.allow-unprotected-txs=true

to allow the unprotected transaction to go through.

emmm actually i don't think this requires a PR to merge that flag into our public codebase.   Sending pre-EIP-155 txs with any private key has some potential security issues right? Like those transactions in our testnet can be re-played in mainnet.  So updating the script to make it sending post-EIP-155 txs sounds like a more reasonable approach?

The RLP does not include EIP-155 intentionally here
https://github.com/Arachnid/deterministic-deployment-proxy
for it to be reused cross chain.
Can I use this branch as a reference to add this flag if we choose not to merge?

Updating the script to make it sending post-EIP-155 txs sounds like a more reasonable approach?

I still thinking this is the right way to do that? Sending a unprotected transaction in a EIP-155 enabled chain should be a very very unrecommended behavior and nobody should do that nowadays?

The RLP does not include EIP-155 intentionally here https://github.com/Arachnid/deterministic-deployment-proxy for it to be reused cross chain.
Can I use this branch as a reference to add this flag if we choose not to merge?

But if u think this deterministic-deployment-proxy is a necessary for u at current stage... u can add that flag in a branch but not merge it into main.

Close this one since we won't merge that flag config into main branch.

Yes this is just for devrel to use, apparently they need to not use EIP-155, they talked to the creators of the script and for some reason it can't function the same way without pre-EIP 155. So it's not intended for community use, or anyone besides Marcus really.


std.variant doesn't do postblit/dtor correctly for large structs

john.loughran.colvin (@John-Colvin) reported this on 2019-11-06T12:00:44Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=20360
CC List

bugzilla (@WalterBright)

Description
unittest
{
    import std.variant;
    static struct S
    {
        int* p;
        ubyte[100] u;

        this(int a)
        {
            p = new int(a);
        }

        this(this)
        {
            p = new int(*p);
        }

        ~this()
        {
            p = null;
        }
    }
    Variant v = S(4);
    assert(v.peek!S.p !is null); // fails
}

john.loughran.colvin commented on 2019-11-06T12:02:42Z
related to https://issues.dlang.org/show_bug.cgi?id=12944

bugzilla (@WalterBright) commented on 2020-01-05T19:06:57Z
On my computer the static array u can contain up to 24 element to work. Together with the 8 bytes of the pointer this looks like 32 bytes is the magic border.


Done addition of user column to the table that will only be visible for admin FP-71,72,74, 75 (potential bug that needs a fix)

Please review the part of code and merge for further development or dependency and merge with main upon completion.
@DineshVasireddy  please do review my commits and also a quick bug noticed on dashboard that on changing the topic with keeping the group same the table and graph are continuing with the data of previous sensor/machine as well.
I did confirm that the issue is not with my new addition of code and it is on your side of how you implemented the useEffect. please do check it and fix it.

Thanks for pointing it out. will check the issue and make the bug fixes and as part of your code. it looks great and ready to be merged for further fixes needs to be made on my end


Fixing MANIFEST

Affected Issues

Fixes #

Proposed Changes

Codecov Report

Merging #202 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #202   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          18     18
  Lines         461    461
  Branches       43     43
=====================================
  Hits          461    461

Coverage remained the same at 100.0% when pulling a28216caefa583a2edda40566f1d8c30d57097de on manifest-fix into 398db52d1c2c5e72f95fe5386357816dfdddd8c4 on master.

Coverage remained the same at 100.0% when pulling a28216caefa583a2edda40566f1d8c30d57097de on manifest-fix into 398db52d1c2c5e72f95fe5386357816dfdddd8c4 on master.

Coverage remained the same at 100.0% when pulling a28216caefa583a2edda40566f1d8c30d57097de on manifest-fix into 398db52d1c2c5e72f95fe5386357816dfdddd8c4 on master.

Coverage remained the same at 100.0% when pulling a28216caefa583a2edda40566f1d8c30d57097de on manifest-fix into 398db52d1c2c5e72f95fe5386357816dfdddd8c4 on master.


Switch to the new version of or_urdf that programmatically constructs HERB

The Fuerte version of HerbPy assumes that a .robot.xml exists, which means it was generated from URDF using or_urdf. In Hydro, we are switching to programmatically loading URDF and SRDF files into OpenRAVE. This means that we need to upgrade HerbPy to load the HERB model using the new or_urdf plugin.

This has been done for quite some time.


[e2e]: go schedule main noldflags-multi-uses slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2908806022
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Tue Aug 23 04:20:31 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2908806022
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Tue Aug 23 04:21:08 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2916397751
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Wed Aug 24 04:16:02 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2916397751
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Wed Aug 24 04:17:02 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2923925014
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Thu Aug 25 04:19:11 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2923925014
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Thu Aug 25 04:19:46 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2931254441
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Fri Aug 26 04:26:39 UTC 2022
Tests are passing now. Closing this issue.


Uncommited change behavior on tab or space

Hello,
OS: Linux Ubuntu 16.04
VS Code: 1.10.2
GitLens: 2.11.2
When you use space or tab on empty line you get Uncommited change, if I remember correctly it was VS Code problem and you created new issue, but seems it wasn't fixed...

P.S. Enabled debug, seems everything fine, no errors or warning from GitLens.

@svipben vscode "fixed" the issue, but it hasn't been released yet -- I'm not sure it made it into an insiders build yet (but I think so). It will likely be released in vscode v1.11

@eamodio oh, sorry then. Thanks!

@svipben no worries at all :)


updates and fixes

Fixing line breaks in files.
Signed-off-by: Avital Pinnick<EMAIL_ADDRESS>

/lgtm


Send SSL certificate

Hey @liyasthomas,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: 1a77b4f0-7170-11ea-8884-a9dd557f3dc9


Kudos!!

Hi!
I'm just reaching out to tell you what an amazing job you've done with this project! 🌟
Stumbling upon your datepicker felt like hitting the jackpot after searching for a very long time. It really checks all the boxes for me.
I hope you don't mind if I use wc-datepicker as the basis for my own personal datepicker project?
I work as an accessibility specialist and have been thinking a lot about inclusive datepickers.
A couple of years back I created a proof of concept for a "smarter" datepicker that would allow more ways for the user to enter dates, including via natural language and speech input. E.g

"Yesterday"
"Next week"
June fifth
In 23 days

etc.
My proof of concept ( https://github.com/fymmot/inclusive-dates ) received some attention, but I never managed to make it into a reusable component.
Now, finally, I'm building v2 around your datepicker. I have some of the basic functionality down including date parsing but a lot of things still remain before it's viable. If you wanna take a look, it's here:

Docs: https://inclusive-dates-v2.vercel.app/  (GORGEOUS documentation template btw!)
Repo: https://github.com/fymmot/inclusive-dates-v2

If you want to talk, you could find me via e-mail (tommy.feldt@useit.se). I would love to collaborate with you around this in any way I can!
All the best, and thank you again!

Hey!
Glad someone finds it useful, and probably shares my frustration with the existing solutions. 😉
Your PoC looks promising. I love the natural language approach. And of course you can use this package as a base. Go for it!


Sonoff Motion Switch Not Showing

Describe the bug
I brought some ZIGBEE sonoff switchs and temp sensors they are all connected via zigbee on my eero devices which acts as a zigbee hub with Alexa.
The temperature sensor is showing on the media player as an entity and working fine.
However, the motion switches are now showing as entities at all,  tried to unpair and repair,  showing on alexa app and working fine just won't come threw to Alexa media player.

Put switch into pairing mode
Ask Alexa to discover new devices
Change name of new device to make it easily findable
Check the Alexa media player plugin for entity and see its not showing under OLD or NEW name

I have the same issue with Sonoff motion sensors using the Amazon Echo Zigbee hub. Does this mean that other Zigbee devices might not show up too?

It's not implemented yet.


Documents are not sometimes listed when alternating between Metadata Management and Schema Management

Describe the bug

Above: picture of blank document list  after clicking Schema Management and Metadata Management multiple times
While alternating between Metadata Management and Schema Management, the list of Documents disappear sometimes
Below: Picture after reloading the page.

To Reproduce
Steps to reproduce the behavior:

Go to (https://matwerk.datamanager.kit.edu/metadata-management.html)
Click on Schema Management Tab
If you are lucky you will see the list of documents. Else reload to see the list of documents.
While alternating between Schema Management and Metadata Management multiple times, this behaviour can be reproduced.

Expected behavior
The list of documents should always be visible
Screenshots
are above
Desktop (please complete the following information):

OS: iOS
Browser  Safari
Version 16.2

I cannot reproduce this issue. However, the MatWerk instance is using a rather old version of frontend-collection. As soon as I merged all recent changes, this instance should be updated and I would ask you to check again if this error still occurs for the new version.

I'll close this issue for now. Please re-open if the error still persists.


Document how to ask engineers for overtime

NOTE: this is a work in progress. I'm raising a PR for discussion. If people agree this process would be better than what we have now, then we'll adopt it and see how it works out. If it doesn't work well then we'll change it.
✨  Rendered version 👀

👏  This looks excellent and good to formalise. One question though: how do you/the teams decide who does overtime? Is it voluntary, or do you always pick certain people, or is it skills-based? Should it be spread evenly throughout the team members, if there are multiple occurrences, so that it doesn't unfairly burden one person, or so that other people can have the experience?

Thanks @issyl0!
I don't know what the process will be for deciding who does overtime yet. Hopefully we can come up with something that's fair though - all of your points are good.
I think I'd like to leave that bit of the process undocumented for now, because it's so unclear at the moment. We'll do our best to make any ad hoc assignments fair in the short term, and hopefully we can start to formalise things as we go.

Thanks for raising this @richardTowers. I was thinking of approving, but got stuck with some of the wording: some of the uses of "us" and "we" are unclear, in that they seem to refer to a scoped group of developers, yet this may be read by any developer. I've made a few suggestions, but got stuck when I hit the bit about "what we'll do".

I was actually thinking of "us" as a group of delivery managers and senior tech people who could have some oversight of who's being asked to do what.
This PR was raised before I knew about the other things being done to plan for overtime work, which have progressed a lot in the meantime. It probably needs a bit of a rethink in that light, so I'm going to close it for now, hopefully to be reopened soon once we've worked out some of the details around our current approach.


Mobile campaign

This pr aim to solve some issues in campaign layout.

The donate button wasn't displayed on mobile.

The project status was duplicated on mobile.

Coverage remained the same at 81.174% when pulling f0da0721f5f267964f262cf439dc18dffda14137 on Layout-Campain into a01f466d11734e240eae7c82406fedfd2848ee71 on master.

Coverage remained the same at 81.174% when pulling d3d4f362249bf0f59386d9bbcf6dfe36bae8fccd on Layout-Campain into a01f466d11734e240eae7c82406fedfd2848ee71 on master.

:+1:

Coverage remained the same at 81.174% when pulling c85fabdd93ae31e5286fd8b1c5ce7b40be465aa3 on Layout-Campain into a01f466d11734e240eae7c82406fedfd2848ee71 on master.

Coverage remained the same at 81.174% when pulling 04e3b79d05315c0d76210fc8e61bc6981290af04 on Layout-Campain into a01f466d11734e240eae7c82406fedfd2848ee71 on master.


ci: change AI review model to claude sonnet

PR Type
configuration changes, enhancement

Description

Updated the AI review model in the GitHub Actions workflow from gpt-4o to anthropic/claude-3-5-sonnet-20240620.
Added a new configuration config.model_turbo for the AI model.
Included anthropic.key for authentication purposes.

Changes walkthrough 📝
Relevant filesConfiguration changes

pr-agent.ymlUpdate AI review model to Claude Sonnet and add configurations

.github/workflows/pr-agent.yml
Changed AI review model from gpt-4o to anthropic/claude-3-5-sonnet-20240620  Added config.model_turbo configuration  Added anthropic.key for authentication

+3/-1

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

/describe

/review

/improve


Streams: Fix update of renamed streams

https://github.com/zulip/zulip/issues/16026
Testing Plan:
*Ran JS tests with ./tools/test-js-with-node
*Also manually changed the name of the streams on the localhost to test
GIFs or Screenshots:

@MSurfer20 This change does not fix this issue as we already call stream_list.update_streams_sidebar in stream_list.rename_stream after the stream rename event is sent by the server.
The actual issue here is that update_streams_sidebar returns early because the list of stream ids actually does not change on stream rename unless the sorted order of stream changes. I have explained this a bit more here

Ah, I understand that now. In that case, should we keep a flag to check if update_streams_sidebar has been called by rename function, in which case we definitely need to execute it completely, otherwise we execute it in-line with the optimisations done before(to execute only if the ID changes)?

I think the approach of executing update_streams_sidebar completely in case of stream rename by keeping a flag is fine, as we require that function to display the sorted list.


Not all mower models support updating the mowing schedule

Prerequirements
[:heavy_check_mark: ] I have connected my mower(s) to the Automower Connect App
[:heavy_check_mark: ] I have connected my Husqvanra developers account to the Authentication API
[:heavy_check_mark: ] I have connected my Husqvarna developers account to the Automower Connect API
Describe the bug
When trying to update the mowing schedule using the husqvarna_automower.calendar service, the schedule remains unchanged and an error is logged:
Command couldn't be sent to the command que: 400, message='Bad Request', url=URL('https://api.amc.husqvarna.dev/v1/mowers/20ea32ed-8e38-461b-8b0e-b5a48026dd19/calendar')

Expected behavior
I expected the schedule to be updated or the integration to not expose the service if it is not compatible with my mower.
Additional context
Debug log of the request:
2023-05-16 14:24:14.594 DEBUG (MainThread) [custom_components.husqvarna_automower.vacuum] start in minutes int: 720
2023-05-16 14:24:14.595 DEBUG (MainThread) [custom_components.husqvarna_automower.vacuum] end in minutes: 1080
2023-05-16 14:24:14.750 DEBUG (MainThread) [aioautomower.rest] Mower Action URL: https://api.amc.husqvarna.dev/v1/mowers/20ea32ed-8e38-461b-8b0e-b5a48026dd19/calendar
2023-05-16 14:24:14.751 DEBUG (MainThread) [aioautomower.rest] Sent payload: {"data": {"type": "calendar", "attributes": {"tasks": [{"start": 720, "duration": 360, "monday": true, "tuesday": true, "wednesday": true, "thursday": true, "friday": true, "saturday": true, "sunday": true}]}}}
2023-05-16 14:24:14.751 DEBUG (MainThread) [aioautomower.rest] Resp status mower command: 400
2023-05-16 14:24:14.751 ERROR (MainThread) [custom_components.husqvarna_automower.vacuum] Command couldn't be sent to the command que: 400, message='Bad Request', url=URL('https://api.amc.husqvarna.dev/v1/mowers/20ea32ed-8e38-461b-8b0e-b5a48026dd19/calendar')

I've dug further and tried to update the mowing schedule using Husqvarna's OpenAPI example. Here it failed as well with the following response:
{
  "errors": [
    {
      "id": "1e731fe0-ff0a-4bfc-b87b-4d233f22625f",
      "status": "400",
      "code": "illegal.argument",
      "title": "Illegal argument",
      "detail": "This mower use missions and can not be updated by this endpoint"
    }
  ]
}

This seems related to #317, in which we discovered that some models (405X, 415X and 435X AWD) cannot update the cutting height through the API, as these mowers support different cutting height for different areas (called missions). Indeed, my 415X also support different schedules for each of the areas, and thus cannot change the schedule through the API for now at least.
I don't know if this integration can dynamically expose the calendar service only if the mower model supports it. If not, I think this information should at least be mentioned in the README.

As far as I know, it's not recognisable, if the mower is on mission. I could send once a day a command for a calendar change and have a look at the result. But that's not the best way I think. Can you tell me more about mission. My mower doesn't have this feature. Is the mower mowing all day and night?

From my understanding, this is a matter of whether the mower supports missions. I'll be happy to test this hypothesis in a couple of weeks. As far as I know, I cannot "disable" the use of missions on my 415X. If this is indeed true, the integration could determine if the calendar update is supported directly from the mower model.

Can you tell me more about mission. Is the mower mowing all day and night?

My mower has a schedule of mowing three days a week for nine hours. I have not defined any custom zones or customized the default generated GPS-assisted map in any way. But my mower supports that I define separate zones within my map and each zone can have a different schedule and cutting height.
Quoting Husqvarna support:

Currently the Automower Connect API does not support missions. Missions can be created in the Automower connect app in the map view by creating an area where the mower can work in. You can create multiple work areas and for every area a mission will be created. The mission contains the information like name and cutting height. An area/mission can have its own cutting height. It will be available soon. For missions cutting height need to be set per mission.
Supported models are 405X, 415X and 435X AWD.

My guess is that because my mower supports zones/missions, it always operates using missions albeit my mower only have the default zone.
Currently my mower is remapping the lawn as I've made changes to the boundary cable and deleted it's old map. When it is finished, I'll be happy to test if I can somehow disable the use of "missions" and thus make the API call work, but I suspect that the models 405X, 415X and 435X AWD always use missions and thus cannot use the current API to update cutting height or schedule.

Hello OEHC,
as a 415x owner, did you make it work after 2 weeks? I also would like to integrate the different schedules of the missions in homeassistant (e.g. only cutting the frontyard from dawn till 0900u) after 0900u let the GPS figure out where to cut.
Maybe I just have to be patient untill husqvarna updates there API.

My 415X is still remapping the lawn so I've got no updates yet. I'll get back as soon as it is done and I have tested whether disabling "GPS assisted navigation" makes any difference.
It would be great if Husqvarna updated the API. It is hard to find any information on their roadmap except for the linked answer above.

My 415X is still remapping the lawn so I've got no updates yet. I'll get back as soon as it is done and I have tested whether disabling "GPS assisted navigation" or something similar makes any difference.
It would be great if Husqvarna updated the API. It is hard to find any information on their roadmap except for the linked answer above.

Any news? Did disabling GPS assisted navigation make a difference?

My mower is still remapping my lawn and I would rather not disturb it too much until it is done, at the risk of having to start over. So I have no updates yet. I guess my initial estimate of a couple of weeks for the remapping were quite optimistic.
If anyone else is able to do some testing in the meantime, you are more then welcome to test the hypothesis that 405X, 415X and 435X AWD always use missions and this cannot be disabled using any combination of settings.
As soon as the mapping is complete I'll start testing :)

Yay, the mapping finished today. I've tried disabling the "Settings -> Installation -> Lawn coverage -> GPS assisted navigation" as well as define multiple work areas and stay-out zones and delete them all again. No matter the combination I used, the calendar endpoint threw the illegal argument exception because the mower use missions.
I've sent an email to the Husqvarna devs, asking if it is possible to disable the use of missions on a 405X, 415X and 435X AWD.

Is it necessary to ask for disabling the missions? I would rather see the missions (or more schedules is what it is? ) added.
created in the app 2 schedules. (so those are different missions?)
schedule 1 for the whole yard running from 0900h till dusk/sunset. (in the below image still old as it shows 0.00h)
schedule 2 only for the frontyard running from 0600h till 0900h
(because @ the frontyard there are no sleeping rooms we wont be woken up by the mower between 6 & 9am)
Those 2 schedules can be found back in home assistants calendar:
'
But throws the known error message : Command couldn't be sent to the command que: 400, message='Bad Request', url=URL('https://api.amc.husqvarna.dev/v1/mowers/XXXX/calendar') when I try to change them.
I will write also an email at the developers @ husqvarna to see if there is an indication of when the api supports multipele schedules/missions.
I'm not a programmer myself just an enthousiastich hobbiest. I can change code but Im nowhere @ developing my own or even know how an API works.

No matter how we turn I turn this around, we should get support from Husqvarna for zones and respective schedules from the API. I have two distinct areas mapped, and I am using schedules to make sure that the area being watered is not selected for cutting. I don't want to turn of zones. Wonder if it helps our cause if we all send emails to Husqvarna, letting them know this is important and that they need to put effort in making essential APIs available...

Perfect timing. I was just about to hit send on my email to them, but I will hold off then. Good news! I assume the same will enable setting cutting hight as well on movers with area support, since those are also area dependent in 405X etc


android's app blokada blocks keybase's login process...

it seems that keybase api domains are somewhere listed in some of the lists of blokada and that doesn't let keybase app to login. i know it is more an issue for blokada but because the error messages are scarce and for many people most probably not comprehensible enough i also added the issue here so it could help someone troubleshooting the problem of re-login on android...

i had to add api-0.core.keybaseapi.com to the whitelist in blokada. until they solve this: https://github.com/blokadaorg/blokada/issues/319 i feel if keybase api would need any other api endpoint i will need to catch it and add to blokada.

hm. just found out you can add the app in their list. that solves the problem. will [close and comment] here...


x/text/language: Match detects wrong language

What version of Go are you using (go version)?

$ go version
go1.17.2

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
darwin_amd64

What did you do?
Im trying to resolve a locale language from the "accept-language" http header: en-GB;q=1.0, fr-DE;q=0.9, fr-CA;q=0.8, en-DE;q=0.7
by using golang.org/x/text/language:
m := language.NewMatcher([]language.Tag{language.English, language.French})
desired, _, _ := language.ParseAcceptLanguage("en-GB;q=1.0, fr-DE;q=0.9, fr-CA;q=0.8, en-DE;q=0.7")
tag, i, conf := m.Match(desired...)
fmt.Println("case B", tag, i, conf) // fr-u-rg-dezzzz instead of en-u-rg-gbzzzz

What did you expect to see?
en-u-rg-gbzzzz
What did you see instead?
fr-u-rg-dezzzz
Other comments
Actually this is reproducible at playground: https://play.golang.org/p/puiT36mYjiU
Please notice that english lang has been detected correctly if we remove en-DE from the end of the string: en-GB;q=1.0, fr-DE;q=0.9, fr-CA;q=0.8 (I dont understand how adding ofher low-priority language affects french lang detection but it works)
Realizations in other programming languages
I wrote similar code for other languages to compare the outputs and both of them detected "en" instead of "fr" so probably we have a bug in golang.org/x/text/language package.
javascript
 var parser = require('accept-language-parser');

 var language = parser.pick(['en', 'fr'], 'en-GB;q=1.0, fr-DE;q=0.9, fr-CA;q=0.8, en-DE;q=0.7', { loose: true });

 console.log(language); // en

java
 import java.util.Arrays;
 import java.util.List;
 import java.util.Locale;

 public class MyClass {
     public static void main(String args[]) {
        List<Locale> locales = Arrays.asList(new Locale("en"),new Locale("fr"));
        List<Locale.LanguageRange> list = Locale.LanguageRange.parse("en-GB;q=1.0, fr-DE;q=0.9, fr-CA;q=0.8, en-DE;q=0.7");
        Locale locale = Locale.lookup(list,locales);

       System.out.println(locale); // en
     }
 }

Strangely enough, I think this is working as intended. @mpvl should definitely check my work though 😅
Here is a playground with my examples: https://play.golang.org/p/D4ucCTJ9LfY
Key assumptions the algorithm is making:
:one: Most people do not speak multiple languages equally. A heavy emphasis is put on finding the first exact language match and "pinning" that language. Docs about assumption 1.
m := language.NewMatcher([]language.Tag{language.English, language.French})

desired, _, _ := language.ParseAcceptLanguage("en-GB, fr")
tag, i, conf := m.Match(desired...)
fmt.Println("case A", tag, i, conf) // en-u-rg-gbzzzz
// Returns English because it is the first exact language match,
// even though "fr" is an exact region and language match.

2⃣    If a person lists the dialects they know and the languages are not continuous, then it is assumed they speak all of those languages equally well and it will not give extra preference to the first exact language match it finds.
For example, if your list of desired language tags are: en-GB, fr-DE, fr-CA, en-DE then I will assume that you speak English and French very well.  In this case, the algorithm will not "pin" English even though it is first. Instead it runs the whole algorithm for all of your options and it decides that fr-DE is a better match because of regionality (Germany is closer to France than Great Britain is to the US). Docs about assumption 2.
desired, _, _ = language.ParseAcceptLanguage("en-GB, fr-DE, en-DE")
tag, i, conf = m.Match(desired...)
fmt.Println("case B", tag, i, conf) // fr-u-rg-dezzzz

// Because of the ordering of dialects, the algorithm
// assumes this speaker knows English and French well.
// Returns French because Germany is closer to France
// then Great Britain is to the US.

❓ You may be wondering: "But what about those q values I set???" (At least that is what I was wondering.)
It turns out those values are only for ordering the desired language tags in ParseAcceptLanguage. They are not passed into match at all.

Strangely enough, I think this is working as intended.

Thanks for your reply & investigation.
For me that should not work that way, because:

Algorythm should take q values into account because otherwise golang implementation does not compatible with rfc (rfc7231 and others);
Thats wery weird that golang implementation differs from others. In my case, there are mobile app with some language detection and some backend with some language detection and obviously I dont want my users to "switch" from one language to another;
Logically, I've said that "I speak English and French well" (en-GB, fr-DE), and English language is preferred for the user (because it goes first and, well, it has q=1.0) and also English is preferred for my app (it goes first for the matcher). So I expect final language to be resolved to "English";
Also logically, thats very weird case: "algo resolves language to French if I add another English option";

Hi @eyudkin,
🇫🇷  🇬🇧  UI

Thats very weird that golang implementation differs from others. In my case, there are mobile app with some language detection and some backend with some language detection and obviously I dont want my users to "switch" from one language to another.

I agree that this sounds like a very bad user experience and an unexpected bug.
🔢  q values

Algorithm should take q values into account because otherwise golang implementation does not compatible with rfc (rfc7231 and others);

Go does take q values into account, but just not in the way that I (and maybe you?) assumed when using them initially. According to rfc7231 section 5.3.5:

Note that some recipients treat the order in which language tags are
listed as an indication of descending priority, particularly for tags
that are assigned equal quality values (no value is the same as q=1).
However, this behavior cannot be relied upon.  For consistency and to
maximize interoperability, many user agents assign each language tag
a unique quality value while also listing them in order of decreasing
quality.

The q values are for ordering the preferred language tags correctly, which is what go does when you use ParseLanguageAccept.
✏  RFC Guidance
I found this quote also in rfc7231 section 5.3.5 that seems very related to your example:

Note: User agents ought to provide guidance to users when setting
a preference, since users are rarely familiar with the details of
language matching as described above.  For example, users might
assume that on selecting "en-gb", they will be served any kind of
English document if British English is not available.  A user
agent might suggest, in such a case, to add "en" to the list for
better matching behavior.

However, I am guessing that you are the server and you do not control the client and so you cannot change which desired language tags are being sent by the user.
🥾  Next Steps
While I agree that the logic is not initially intuitive for this case, it is how the algorithm is purposefully written. I am not an expert in this area, just some one who was interested in digging into this case and learning more. While you can argue with @mpvl about changing the algorithm, I doubt that will happen quickly or at all. I think the best and quickest fix is to change your code to detect the language once so that there is not a mismatch between the frontend/backend.


Revert reason in eth_call

Description:

Returns the error data and a readable reason when a contract call is reverted in eth_call.
Adds a new revertReason field in the response of eth_getTransactionReceipt.

Related issue(s):
Fixes #492
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report
Base: 70.66% // Head: 69.81% // Decreases project coverage by -0.85% :warning:

Coverage data is based on head (c410368) compared to base (20b1b88).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #604      +/-   ##
==========================================
- Coverage   70.66%   69.81%   -0.86%
==========================================
  Files          16       16
  Lines        1125     1143      +18
  Branches      191      194       +3
==========================================
+ Hits          795      798       +3
- Misses        279      293      +14
- Partials       51       52       +1

Impacted Files
Coverage Δ

packages/relay/src/lib/clients/sdkClient.ts
6.21% <0.00%> (-0.08%)
:arrow_down:

packages/relay/src/formatters.ts
29.41% <16.66%> (-37.26%)
:arrow_down:

packages/relay/src/lib/eth.ts
83.85% <33.33%> (-0.34%)
:arrow_down:

packages/relay/src/lib/errors/JsonRpcError.ts
69.23% <66.66%> (-0.77%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


OCPBUGS-32930: Allow specifying resource requests per cluster size

What this PR does / why we need it:
Allows memory and CPU requests to be specified by deployment/container per size.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-32930
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[x] This change includes unit tests.

/lgtm

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

/retest

/hold cancel


Create the relevant tables in the Database

We need to first decide what tables we will be storing and how they will be represented. Hence, this is dependent on the completion of the ER diagram.

Created User table in database.

All tables aside from time and material needs (are we creating a table for this?) have been created.

Time and material needs column to be added to EngagementContract table.  Closing issue.


[assemble] Allow environment variables to be set on launch scripts

Is your feature request related to a problem? Please describe.
Launch scripts generated by the javaArchive assembler could support setting key/values for environment variables.
Describe the solution you'd like
An option to define env vars (generic, linux/mac, windows) that may be set on launch scripts generated by templates.
Describe alternatives you've considered
Custom templates must be used instead.
cc: @bmarwell

🎉 This issue has been resolved in v1.13.0 (Release Notes)


customised color?

Hi there, is that possible to make colour to be customised?  I know I can change the value, but I don't want to unlock the file. But I want to keep the pod file unchanged. Thanks

you can style the button like this in your view controller (viewdidload):
loginButton.backgroundColor = UIColor.whiteColor()  loginButton.normalBackgroundColor = UIColor.blueColor()  loginButton.highlightedBackgroundColor = UIColor.greenColor()  loginButton.normalCornerRadius = 0.0


Xarray test suite failing with dask-master

There are a wide variety of failures, mostly related to backends and indexing, e.g., AttributeError: 'tuple' object has no attribute 'tuple'. By the looks of it, something is going wrong with xarray's internal ExplicitIndexer objects, which are getting converted into something else.
I'm pretty sure this is due to the recent merge of the Array._meta pull request: https://github.com/dask/dask/pull/4543
There are 81 test failures, but my guess is that there that probably only a handful (at most) of underlying causes.

cc @pentschev

I believe that this is now resolved.  Please let me know

@mrocklin unfortunately I think the tests are still failing with dask master: https://travis-ci.org/pydata/xarray/jobs/546491564
I'm not that familiar with this part of the codebase; though let me know if I can be helpful at all

OK, reproduced.  I'll take a look later today.  Thanks for pointing me to that @max-sixty .

We're down to 1 failing test!
        # Invalid cases
        if not use_dask or LooseVersion(dask.__version__) > LooseVersion('0.17.4'):
            with pytest.raises(TypeError):
>               xr.dot(da_a, dims='a', invalid=None)
E               Failed: DID NOT RAISE <class 'TypeError'>

https://travis-ci.org/pydata/xarray/jobs/546491564

Xarray definitely had a bug with ImplicitToExplicitIndexingAdapter. See https://github.com/pydata/xarray/pull/3027 for the fix.
Unfortunately, this triggers new failures from inside dask's blockwise_meta helper:
>       return meta.astype(dtype)
E       AttributeError: 'ImplicitToExplicitIndexingAdapter' object has no attribute 'astype'

The bigger issue this surfaces is that I'm not sure whether ImplicitToExplicitIndexingAdapter (and xarray's other custom array types used for data loading) should be in meta or not. These array types overload indexing, but they don't implement the rest of NumPy's ndarray API. So it's a little strange to see them in meta (and of course methods like astype don't work on them).
On the other hand, they do need to be preserved rather than always cast to NumPy arrays. Otherwise repeated indexing like x[i][j] doesn't get optimized by dask, which turns out to be a really important optimization.

We're down to 1 failing test!
        # Invalid cases
        if not use_dask or LooseVersion(dask.__version__) > LooseVersion('0.17.4'):
            with pytest.raises(TypeError):
>               xr.dot(da_a, dims='a', invalid=None)
E               Failed: DID NOT RAISE <class 'TypeError'>

I think this was an intentional change -- see https://github.com/dask/dask/pull/4914.

Indeed it was. Regardless, https://github.com/dask/dask/pull/4954/files#diff-3598e11c3b3a16881fecff61abdf1f4cR97 will solve that.


php 7.3 compat: continue targeting switch equaivalent to break;

Provide a narrative description of what you are trying to accomplish:
in PHP 7.3.0-dev ( nightly )

[x] Are you fixing a bug?

[x] Detail how the bug is invoked currently.
It is inside ArrayObject class which the continue code called inside switch inside loop.
[x] Detail the original, incorrect behavior.
It got error: "E_WARNING "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?"
[x] Detail the new, expected behavior.
using continue 2 using break; to jump to next loop.
[x] Base your feature on the master branch, and submit against that branch.
[x] Add a regression test that demonstrates the bug, and proves the fix.
without this patch, the test should failure.
[x] Add a CHANGELOG.md entry for the fix.

actually, break should be enough as it not break the loop, but break the case itself, except, we use break 2 to break the loop itself, ref https://3v4l.org/3W0u4

Thanks, @samsonasik


Fix pixelated behavior -- see https://github.com/google/mediapy/issue…

See #20
Also changed "plt.cm.get_cmap(cmap)" to "matplotlib.colormaps[cmap]" to avoid some deprecation warnings.

Thanks! I've imported this.
Peter is still out of office but this should be merged tomorrow!

This was merged: https://github.com/google/mediapy/commit/01fdedc09c214fb3a6cc3b477eec8c1a53fc3aaa but for some reason copybara bugged and didn't marked this PR as merged.


Submit documentation to plugins.drone.io

Take it from https://github.com/drone-plugins/drone-s3-cache/blob/7f1179b4d6390d104e68f359cfbeb435d3b79970/DOCS.md

Solved via https://github.com/drone/drone-plugin-index/pull/63


Need help with beaker notebook on remote server

Hello,
newbie with almost everything here and tried to install beaker notebook on aws ec2.
when building from source code following the instruction ( install-dependencies.sh + gradle run ),
I stuck at "beaker Building 0% > :run > :dev:run" after "starting nginx instance ";
when running the docker image, I got a weird ip like "https://321b94ebff76".
I was also wondering if there were an option similar to "c.NotebookApp.open_browser = False" on jupyter notebook, which disables launching a browser on a remote server.
As I couldn't find answers from google, I have to come here. Any help is greatly appreciated.
Ian

docker is probably best.  once it starts, just ignore the IP/URL that it prints out.  you should know the IP or hostname of your instance, just use that (but do copy the port number).  the open_browser option is not needed, it does that automatically.

Thanks a lot. Docker image works fine now and beaker notebook is kind of cool.
But as an R user, I prefer not running docker image because of the ability to add R packages..
Here is where I stuck when building from source (any suggestion is appreciated)
...
:dev:core:build
:dev:core:copyGGVis
:dev:core:copyJQueryUIImages
:dev:core:copyKatex
:dev:core:copyRequireJS
:dev:core:copyVendorStuff
:dev:core:installApp
:dev:build
:dev:run
starting nginx instance (/home/ubuntu/beaker-notebook/core/nginx)
[main] INFO org.eclipse.jetty.server.Server - jetty-8.1.13.v20130916
nginx-stderr>nginx: [alert] could not open error log file: open() "/var/log/nginx/error.log" failed (13: Permission denied)
[main] INFO org.eclipse.jetty.server.AbstractConnector - Started SelectChannelConnector@<IP_ADDRESS>:8802
Connecting to http://<IP_ADDRESS>:8801/
> Building 0% > :run > :dev:run
...

I guess beaker has opened a browser now and is listening to localhost, but I am on a headless remote server..


Compression with bad loader - experimental

Investigating why https://github.com/microsoft/FluidFramework/pull/14337 breaks CI

the experiment is over


[SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

What changes were proposed in this pull request?

This patch proposes to add subexpression elimination for interpreted expression evaluation. Interpreted expression evaluation is used when codegen was not able to work, for example complex schema.
Why are the changes needed?

Currently we only do subexpression elimination for codegen. For some reasons, we may need to run interpreted expression evaluation. For example, codegen fails to compile and fallbacks to interpreted mode, or complex input/output schema of expressions. It is commonly seen for complex schema from expressions that is possibly caused by the query optimizer too, e.g. SPARK-32945.
We should also support subexpression elimination for interpreted evaluation. That could reduce performance difference when Spark fallbacks from codegen to interpreted expression evaluation, and improve Spark usability.
Benchmark
Update SubExprEliminationBenchmark:
Before:
OpenJDK 64-Bit Server VM 1.8.0_265-b01 on Mac OS X 10.15.6
 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
 from_json as subExpr:                      Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 -------------------------------------------------------------------------------------------------------------------------
subexpressionElimination on, codegen off           24707          25688         903          0.0   247068775.9       1.0X

After:
OpenJDK 64-Bit Server VM 1.8.0_265-b01 on Mac OS X 10.15.6
 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
 from_json as subExpr:                      Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
 -------------------------------------------------------------------------------------------------------------------------
subexpressionElimination on, codegen off            2360           2435          87          0.0    23604320.7      11.2X

Does this PR introduce any user-facing change?

No
How was this patch tested?

Unit test. Benchmark manually.

Test build #130948 has started for PR 30341 at commit c7fdae5.

Test build #130948 has finished for PR 30341 at commit c7fdae5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class EvaluationRunTime
case class ExpressionProxy(child: Expression, runtime: EvaluationRunTime) extends Expression
case class ResultProxy(result: Any)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130948/
Test FAILed.

Test build #130949 has started for PR 30341 at commit 33ac8b4.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35554/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35554/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35554/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35555/

Test build #130949 has finished for PR 30341 at commit 33ac8b4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130949/
Test FAILed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35555/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35555/
Test PASSed.

Test build #130955 has started for PR 30341 at commit 6bab83c.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35561/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35561/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35561/
Test PASSed.

Test build #130965 has started for PR 30341 at commit ddd3a96.

GitHub Actions were passed actually.

cc @cloud-fan @dongjoon-hyun @maropu @HyukjinKwon

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35571/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35571/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35571/
Test PASSed.

Thank you for pinging me, @viirya .

Test build #130955 has finished for PR 30341 at commit 6bab83c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130955/
Test PASSed.

Test build #130973 has started for PR 30341 at commit e8449ec.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35579/
Test FAILed.

Test build #130965 has finished for PR 30341 at commit ddd3a96.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #130973 has finished for PR 30341 at commit e8449ec.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130973/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130965/
Test FAILed.

retest this please

Test build #131012 has started for PR 30341 at commit e8449ec.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35618/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35618/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35618/
Test PASSed.

Test build #131012 has finished for PR 30341 at commit e8449ec.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131012/
Test PASSed.

The idea looks good!  left several comments

Nice feature!

Test build #131088 has started for PR 30341 at commit 4780b65.

I addressed most of comments except for https://github.com/apache/spark/pull/30341#discussion_r522822589 and https://github.com/apache/spark/pull/30341#discussion_r522904967.
For https://github.com/apache/spark/pull/30341#discussion_r522822589, I will wait for confirmation.
For https://github.com/apache/spark/pull/30341#discussion_r522904967, I will add some more tests later.

Hmm, actually for https://github.com/apache/spark/pull/30341#discussion_r522904967, that is to add some tests in SQLQueryTestSuite with --CONFIG_DIM spark.sql.codegen.wholeStage=false,spark.sql.codegen.factoryMode=NO_CODEGEN, I think it should be added as a separate PR and merge the test PR first? Then we can run against with it to check if the result is the same. @maropu

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35691/

I think it should be added as a separate PR and merge the test PR first? Then we can run against with it to check if the result is the same. @maropu

Yea, it looks fine. I'll review this again tonight and thanks for the update.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35691/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35691/
Test PASSed.

Test build #131088 has finished for PR 30341 at commit 4780b65.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131088/
Test FAILed.

retest this please

Test build #131089 has started for PR 30341 at commit 4780b65.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35692/

Test build #131089 has finished for PR 30341 at commit 4780b65.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131089/
Test FAILed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35692/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35692/
Test PASSed.

Thanks @maropu

Test build #131094 has started for PR 30341 at commit 47bae35.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35697/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35697/

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35697/
Test PASSed.

Merged build finished. Test PASSed.

It would be great if we can have a benchmark suite (from the code in the PR description), @viirya .

It would be great if we can have a benchmark suite (from the code in the PR description), @viirya .

Yes, @dongjoon-hyun, I remember it. :) I will add a benchmark suite and the tests @maropu suggested in separate PRs.

Test build #131094 has finished for PR 30341 at commit 47bae35.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131094/
Test PASSed.

Thanks @dongjoon-hyun.
Let's wait for @cloud-fan's comment for https://github.com/apache/spark/pull/30341#discussion_r522822589 after this weekend.

#30379 is merged. Could you rebased to the master and regenerate the result, @viirya .
Sure, that's the exact reason I asked their opinion once more. 😄

Let's wait for @cloud-fan's comment for #30341 (comment) after this weekend.

@dongjoon-hyun Thanks! I will update this tonight or tomorrow.

No need to hurry~ Take your time. I just want to give you feedback swiftly from my side.

Test build #131106 has started for PR 30341 at commit 77168fe.

Test build #131106 has finished for PR 30341 at commit 77168fe.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131106/
Test FAILed.

Merged build finished. Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35709/

retest this please

Test build #131107 has started for PR 30341 at commit 77168fe.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35709/

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35709/
Test PASSed.

Merged build finished. Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35710/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35710/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35710/
Test PASSed.

Please let us know if you have another comments, @maropu and @cloud-fan .

Yea, I don't have any more comment, so I'll leave this to @cloud-fan .

Test build #131107 has finished for PR 30341 at commit 77168fe.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131107/
Test PASSed.

Test build #131184 has started for PR 30341 at commit db115d6.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35786/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35786/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35786/
Test FAILed.

Test build #131184 has finished for PR 30341 at commit db115d6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131184/
Test PASSed.

thanks, merging to master!

Thank you, @viirya , @maropu , @cloud-fan !

Thanks @dongjoon-hyun @maropu @cloud-fan

Sorry for a late comment. +1, nice.

Thanks @HyukjinKwon!


Chore - Supabase auth - Update to Current source.

We can delete the supabase-auth branch. We are using it in main

I thought so aswell.


AOSP Email does not connect with GCM for push notifications

LOS 16.0-20199024-microG
Hi everyone,
I just managed to activate GCM on LOS 16.0 with help of this comment. All apps could then be registered with GCM by reinstalling them. Great so far! Unfortunately I can not get the preinstalled AOSP E-Mail app to register with GCM, since it can not be completely removed. I tried deactivating/activating the app and erasing Cache and app data, without succcess. Any Ideas?

@derhagen
Does it actually try to use GCM/FCM?
My AOSP E-Mail App offers POP3 and IMAP. This should be quite different and independent from GCM/FCM. As POP3 is checking based on time interval and IMAP push is a different concept.
If you are sure that GCM/FCM is used, could you please provide logs from time of registering?!

Oh I didn't know "IMAP push" is a thing. I guess that's what they actually mean by "Push". I'm going to check the logs later and reopen the issue if it tries and fails to use GCM.


Interface type inconsistency

com.google.common.base.Predicate is not consistent with java.util.stream.Stream interface.
java.util.function.Predicate should be used instead
Although those two types share the same interface (in most cases) sometimes this one takes over the intended one and it can lead to some very regretful time losses.

Could you be more precise? Because I have no idea what you're talking about. Thanks.

ye, sorry, I was referring to this being used here with java.util.stream.Stream.filter method. Although com.google.common.base.Predicate interface is compatible in most cases with the filter method, sometimes, however, it is not, and I think, it's better to use java.util.function.Predicate instead

you know, I can make a pr, if that can make things easier to understand @gsmet

Thanks, I created https://github.com/quarkiverse/quarkus-amazon-services/pull/59 to fix it.


Add validation type to NimbleOptions.ValidationError

@whatyouhide initial attempt at adding failed validation to NimbleOptions.ValidationError. Only implemented support for {:type, :integer}  so I can get a sanity check on whether you think I'm on the right path.

Pull Request Test Coverage Report for Build d7df5c28720d1edd68b0d059fcf4569b14733347-PR-134
Details

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.7%) to 91.753%

Files with Coverage Reduction
New Missed Lines
%

lib/nimble_options.ex
5
91.89%

Totals

Change from base Build d42dc90bcfa8a2b6c1f082fb47869e4769f9e9de:
-1.7%

Covered Lines:
267

Relevant Lines:
291

💛  - Coveralls

Yeah I think this is the right path but if we pass {:type, _} to structured_error_tuple then we don't need to pass say "integer" as well, we can move the building of the error message completely to that function and deduce the error from {:type, _} in that case.

if we pass {:type, _} to structured_error_tuple then we don't need to pass say "integer" as well

This is a good idea. I'll do this. Thanks!
I'll continue going down this route. Thank you!

Sorry for not getting back to this sooner!
@whatyouhide a couple things.

After digging into this more I'm not sure how specifying {:type, _} allows us to not pass the human-readable version of the type to structured_error_tuple. It makes sense for a type like :integer but not :pos_integer. We could pattern match on the type to specify the human-readable version but I feel like that adds a ton of code without much benefit. I'm assuming I'm not thinking about this correctly or I'm missing the bigger picture.

How should we handle types like {:struct, struct_name}? I think we should pass {:struct, struct_name} as the type rather than just :struct. So the validation would be {:type, {:struct, struct_name}}. Thoughts?

Instead of building the error message where you validate the type, you can build it (by pattern matching) in structured_error_tuple. That was my idea by it's been a while so I’m not really sure here anymore 😄

Thanks for the clarification! That's what I assumed you were referring to. Here is what I wrote in my original question.

We could pattern match on the type to specify the human-readable version but I feel like that adds a ton of code without much benefit.

Would you agree with that?

Yeah this is why I wanted a structured error reason that we could turn into a message later on. Ok, for now let's keep this version passing strings around and I'll see if I can refactor that at some point!

How should we handle types like {:struct, struct_name}? I think we should pass {:struct, struct_name} as the type rather than just :struct. So the validation would be {:type, {:struct, struct_name}}. Thoughts?

Mh I can't recall if :struct is a type or if it's {:struct, struct_mod}. Either way, yeah a separate PR to clean that up if it's weird would be welcome 🙃


Lazy loading selector issue

core.js:6162 ERROR TypeError: Cannot read property 'selector' of undefined
at SafeSubscriber._next (juristr-ngx-lazy-el.js:347)
at SafeSubscriber.__tryOrUnsub (Subscriber.js:183)
at SafeSubscriber.next (Subscriber.js:122)
at Subscriber._next (Subscriber.js:72)
at Subscriber.next (Subscriber.js:49)
at subscribeToPromise.js:5
1)html code from home page
<div [hidden]="!show">
<app-demo-main *ngxLazyEl>

This app-demo-main compoenent is in Module
@NgModule({
declarations: [AppDemoMainComponent],
imports: [
CommonModule,
DemoModule
],
exports: [AppDemoMainComponent]
})
export class AppDemoMaiModule {
customElementComponent: Type = AppDemoMainComponent;
}
DemoModule is using AppDemoMainComponent and DemoModule is
@NgModule({
schemas: [CUSTOM_ELEMENTS_SCHEMA],
declarations: [
'''''
],
imports: [
NgxLazyElModule
    ]

AppModule has   NgxLazyElModule.forRoot(lazyConfig), and lazyConfig configured for selector app-demo-main

I don't know if the problem is the same. But here I had that problem when I try to do content projection. I resolved it that way.
First encapsulate your code into ng-container with a if condition.

Second, emit an event from the lazy component and use it to set a variable as true.

My english is not the best, but I hope it can help someone.


where is the "datasets/objectnav/hm3d_v2.yaml"?

Habitat-Lab and Habitat-Sim versions
Habitat-Lab: vx.x.x or master?
main
Habitat-Sim: vx.x.x or master?
main
Habitat is under active development, and we advise users to restrict themselves to stable releases. Are you using the latest release versions of Habitat-Lab and Habitat-Sim? Your question may already be addressed in the latest versions. We may also not be able to help with problems in earlier versions because they sometimes lack the more verbose logging needed for debugging.
Master branch contains 'bleeding edge' code and should be used at your own risk.
Docs and Tutorials
Did you read the docs? https://aihabitat.org/docs/habitat-lab/
yes
Did you check out the tutorials? https://aihabitat.org/tutorial/2020/
yes
Perhaps your question is answered there. If not, carry on!
❓ Questions and Help
I noticed that datasets/objectnav/hm3d_v2.yaml for object goal navigation is described in the dataste.md, but the link transfer to 404.
I cant find the document mentioned above? can anyone help me?

Hey @Jay-Vim-Lv
I'm not able to find any broken links.
Are you following this dataset guide for HM3d? https://github.com/facebookresearch/habitat-sim/blob/main/DATASETS.md#habitat-matterport-3d-research-dataset-hm3d
You should access the HM3D github page by registering an account with Matterport and requesting key access.

@aclegg3
Thanks for your reply, and i know how to download the dataset.
what i mean is the document habitat-lab/DATASETS.md here.
config to use for the task [Object goal navigation](https://arxiv.org/abs/2006.13171) and scene HM3DSem-v0.2 is datasets/objectnav/hm3d_v2.yaml, but that didn't offer.
and one more question is that when i try to use the ddppo to  train the objectnav task in hm3d, the result seems not right, just like the reply in the this issue,1563, and i want to know how should i do.


Update base image to ubuntu 23.10 (mantic)

Testing. Expecting HIP image to fail, in which case it will stay on an old base image.

Note, the branch name says 23.04, but 23.10 is what I intended. I'm not opening a new PR with a better branch name.


(bug): module doesn't always load

Gets "Failed to instantiate module" error.

Fixed with new module commit


Manually Importing ROM

Issue summary
I have a few ROMs in .md format in my home directory, how can I manually import this ROM?
Awesome work! Super excited about this! :smile:
System information

[Ubuntu 14.04]
[3.5.2]
[Gym Retro 0.5.2]

Sorry I just figured it out!
For other users run python -m retro.scripts.import_path . in the ROM directory

python -m retro.import . should work too, being an alias for the above.


Hope matchUrl to be case-sensitive

I use flight to build a small website. When I browse uppercase and lowercase mixed urls , I will get the same pages. Like these URLs :
http://flight.dev/test/index.html
http://flight.dev/test/index.HTML
http://flight.dev/TEST/Index.html

Hope matchUrl to be case-sensitive.

Now available in latest commit 7fd3594ac7409cdacddc8e6609d0dea58dd5b5c9. You can now do:
Flight::set('flight.case_sensitive', true)


bitbox02: implement sign_message()

will test

@instagibbs I also updated the bb02 dep version in a new commit, to enable antiklepto in message signing.

Perhaps we need to have a discussion about what addresses and signature formats are supported for message signing.
Currently Core only supports legacy addresses for address signing and verification. However I know that there are unofficial standards for segwit address signing. So it might be a problem if we support message signing that is incompatible with core.

Perhaps we need to have a discussion about what addresses and signature formats are supported for message signing.
Currently Core only supports legacy addresses for address signing and verification. However I know that there are unofficial standards for segwit address signing. So it might be a problem if we support message signing that is incompatible with core.

This PR uses the old 'Bitcoin signed message' format, for all supported addresses. Afaik e.g. the Trezor implementation in HWI does the same, and so does Electrum. I think Trezor has an extension that signs segwit a bit differently, but it does not seem to be in use in third party integrations like HWI and Electrum. I am not aware of any other unofficial formats.
I am not sure about what Core does with segwit addresses, but the wider ecosystem (Electrum, various brokers that require signed msgs, etc.) accept the same format regardless of whether it is legacy or segwit.
Maybe BIP322 is an avenue, but for the time being, this PR is compatible with how other hw wallet vendors and wallets do it.

@achow101 ready to merge? As mentioned, this PR behaves the same as e.g. Trezor.

ACK a30d672e56ee142d68a399f8ecd95af7d809e287


Fix Calendar Issues

Supposed to fix #565.
Testing remains to be done. Do not merge, yet.

Ok, works for me now. The code is not beautiful, but it wasn't before either.

So, can I merge this?

Yes.

Done!


Begin Web User Auth (Back End)

As a back-end and automation developer, I will want to begin implementing NextAuth for user authentication.
Is your feature request related to a problem? Please describe.
We need to authenticate users of our application so that they can be given the appropriate permissions.
Describe the solution you'd like
Begin implementing NextAuth for user authentication.
Additional context
TBD
Story Points
2-8

Resolved by #51 (Go over in meeting)


Could you add these games please?

Hello! I saw on games.json that at the moment there's currently only FIFA 19. I was wondering if you could also add the other FIFA games  that are available on the Switch currently (18, 20, 21, and 22). Thank you!

These games were added within this release: https://github.com/hobby-grade/Nintendo-Switch-Discord-Status/releases/tag/<IP_ADDRESS>
In a future release, I will be consolidating all sports games under one title, so instead of having each year, it will just have "FIFA" as yearly releases waste space on the games list.
Thanks!


Add print to confirm that the failed_test_stories.yml has been saved

Proposed changes:

Added a message at the end of rasa test core, showing that the failed stories were saved in results/failed_test_stories.yml, resolving issue #3998
close https://github.com/RasaHQ/rasa/issues/3998

Default path (results)

User specified path

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[x] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Henrike100:x: mbsletYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for submitting a pull request 🚀 @erohmensing will take a look at it as soon as possible ✨

@erohmensing thank you for reviewing the PR. I made the suggested changes. When you can, review the PR again, please.


fix: make drawer accessible in mobile landscape

#1012
Description
Out of bash, we need on mobile devices in landscape mode looking at the map to be able to access the listings list. On production right now, you can see a little sliver, and on staging, you can't see it at all. This PR makes it so the list is accessible, but doesn't improve upon the experience.
How Can This Be Tested/Reviewed?
Using your mobile device, visit the listings map on landscape, and ensure the list is accessible. You can compare the experience to production. There are instructions here for visiting your local stack in a mobile device. You can also toggle landscape mode on and off in the browser's mobile emulator.
Author Checklist:

[ ] Added QA notes to the issue with applicable URLs
[x] Reviewed in a desktop view
[x] Reviewed in a mobile view
[ ] Reviewed considering accessibility
[ ] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[ ] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Documenting offline discussion. Given this is my current experience on mobile landscape with the fix, this is on hold to update the filter and total results to show on the same line and hopefully provide more room to use the drawer 🐧


No menu button in android app

I really like your system and would like to port it so that it runs a modified Bradley meat smoker. I currently use Industrial PID for my system. Is there a place for source code for the android application, on my Samsung S5 i don't get a menu button which means i cannot set the IP address to the raspberry PI to establish a connection. I will be implementing RTD temp sensor support for 4 internal meat temp probes + 2 RTD probes for pid controlled heating loops for smoker internal and pellet heater element. Software will control all aspects of a smoking session including feeder motor for the smoke pucks.

https://faq.whatsapp.com/en/android/21228643/
For the Samsung S5 you need to long press the app switch button.


Remove screen fading momentarily to black

Right before the captcha icon loads in the bottom-right corner of the react native app (for both normal and invisible mode), the screen changes momentarily to black. Is there a way to avoid this?

You are talking about the fade effect when modal opens?

Normal
Invisible

yes I'm talking about the fade momentarily to a darker screen. I would like to remove the fade entirely

You can change the background color with styles.
<Recaptcha
    style={{ backgroundColor: 'transparent' }}
/>

Docs: https://github.com/douglasjunior/react-native-recaptcha-that-works#props

this worked, thanks!


fix return types in Mailer.php phpdocs

No, void is correct. We're saying the return value is garbage. This is because only the smtp driver returns an int, and that might change in a later release too.


React-native version 0.70.0/0.70.1 ios build failed of fresh install on macbook pro(intel chip)

Description
Hi everyone I have installed 4 to 5 times react-native 0.70 but the ios build failed every time.
the version before 0.70 like 0.67 or 0.68 build perfectly
I have also installed node lts v16.17.1 but 0.70 ios is not going to build
Version
0.70 and 0.71
Output of npx react-native info
info Fetching system and libraries information...
System:
OS: macOS 10.15.7
CPU: (8) x64 Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz
Memory: 2.89 GB / 16.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 16.17.1 - /usr/local/bin/node
Yarn: Not Found
npm: 8.15.0 - /usr/local/opt/node@16/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.2 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
Android SDK: Not Found
IDEs:
Android Studio: 2021.1 AI-211.7628.21.2111.8092744
Xcode: 12.4/12D4e - /usr/bin/xcodebuild
Languages:
Java: 11.0.11 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.1.0 => 18.1.0
react-native: 0.70.1 => 0.70.1
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
npx react-native init AwesomeProject
cd AwesomeProject
npx react-native run-ios
Snack, code example, screenshot, or link to a repository
error I get

I have some problem after upgrate 0.69.5 to 0.70.1

0.70 and 0.71

I assume you meant 0.70.1
Is the same failure happening also on a empty project?

need more info.

Spec.:
anatooly@work RnEmptyProject % uname -a
Darwin work.local 21.1.0 Darwin Kernel Version 21.1.0: Wed Oct 13 17:33:23 PDT 2021; root:xnu-8019.41.5~1/RELEASE_X86_64 x86_64

anatooly@work RnEmptyProject % /Volumes/MacHD/usr/sbin/system_profiler SPHardwareDataType
Hardware:

    Hardware Overview:

      Model Name: MacBook Pro
      Model Identifier: MacBookPro15,1
      Processor Name: 6-Core Intel Core i9
      Processor Speed: 2,9 GHz
      Number of Processors: 1
      Total Number of Cores: 6
      L2 Cache (per Core): 256 KB
      L3 Cache: 12 MB
      Hyper-Threading Technology: Enabled
      Memory: 32 GB
      System Firmware Version: 17<IP_ADDRESS>.0 (iBridge: 19.16.10548.0.0,0)
      OS Loader Version: 540.40.4~45
      Serial Number (system): C02X74SHJGH6
      Hardware UUID: AB263AA8-A684-5C63-B359-1EE5EBEC639F
      Provisioning UDID: AB263AA8-A684-5C63-B359-1EE5EBEC639F
      Activation Lock Status: Enabled

Errors:
anatooly@work RnEmptyProject % cd ios
anatooly@work ios % pod install
[Codegen] Generating ./build/generated/ios/React-Codegen.podspec.json
fatal: not a git repository (or any of the parent directories): .git
Analyzing dependencies
[Codegen] Found FBReactNativeSpec
Downloading dependencies
Generating Pods project
Setting REACT_NATIVE build settings
Setting CLANG_CXX_LANGUAGE_STANDARD to c++17 on /Users/anatooly/Developer/RnEmptyProject/ios/RnEmptyProject.xcodeproj
Pod install took 10 [s] to run
Integrating client project
Pod installation complete! There are 59 dependencies from the Podfile and 49 total pods installed.

anatooly@work RnEmptyProject % react-native run-ios
info Found Xcode workspace "RnEmptyProject.xcworkspace"
info Building (using "xcodebuild -workspace RnEmptyProject.xcworkspace -configuration Debug -scheme RnEmptyProject -destination id=7756C5B5-CAA5-4B4D-8633-77466F1625C1")
error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening RnEmptyProject.xcworkspace.

run ios log:
error.log

just install a fresh react-native project but the error remains the same.
Xcode version =>  xcode Version 12.4 (12D4e)

what else info we need to give here

Can try to upgrade xcode version to 13 or 14.

Can try to upgrade xcode version to 13 or 14.

on my example Version 13.4.1, and same issue

the error is that your Ruby version is not the right one - please follow the documentation here: https://reactnative.dev/docs/environment-setup#ruby
<img width="869" alt="Screenshot 2022-09-28 at 8 08 25 PM" src=

"https://user-images.githubusercontent.com/70444687/192816855-b43b8202-69c9-4540-b715-3bd4ad08dcfd.png">

I have updated the ruby version. but the error remains still the same

If there is no one to solve this issue let me know so I can convert back my project to react-native 0.68.

If there is no one to solve this issue let me know so I can convert back my project to react-native 0.68.

I think create new project like npx react-native init RnEmptyProject --version 0.68.3 and move you code or move to you project packages version/Podfile/bundle.grandle/etc :-)

I am closing issue  .. :)
Problem was I need to update xcode version from 12.4 to 13