enable Windows build

Any clue how difficult that would be? ;)

https://github.com/datalad/datalad-extensions/pull/40 might pave the way (although not sure about libmagic since cross-building is probably not allowed, but probably build could just fetch the artifact from datalad-extensions or eventually "official" source).

ok -- we have 2 ways to proceed:

try to reproduce that github actions build recipe (now complete and works!  with libmagic support)
"cheat": download git-annex-installer.exe, 7z x it and place binaries (if any moving needed) where desired.  I would if that would work (yet to try, but I will).  Note: we are not yet re-distributing those binary builds "publicly" (TODO: https://github.com/datalad/datalad-extensions/issues/46) so we could start with "stock" git-annex

known "issue": our builds do not work on windows 7 AFAIK.

@notestaff what would be your thinking/desire? ;)

"try to reproduce that github actions build recipe" seems more correct.  Long-term, if something changes in the conda-forge build process, a recipe that does the building itself is more likely to still work / be easier to adjust?  Unfortunately right now I don't have the bandwidth to figure this out, or the knolwedge of building on Windows...

yeah, bandwidth is limited here too and I always double think when I impose Windows goodness on someone ;)  So what about two stage

short term -- "cheat" way, from http://datasets.datalad.org/datalad/packages/windows/ (I am testing such pure "extract" locally in a VM ATM)
long term -- "proper" build (there is little point to struggle if we see that windows build from "cheat" is "not working").

Sounds good.  This won't be the only recipe to use such a "cheat" until a better way gets worked out.

p.s. what I really wish we had on Windows was a cygwin-based version, but unfortunately GHC has stopped supporting cygwin


Improve TS typing

This is an attempt to fix #167
I do not believe it's correct to suggest the DOMParser implements globalThis.DOMParser, the HTMLElement implements globalThis.HTMLElement, etc.
I think these changes should be ok given the goal of the library is to be close but not too close to the actual dom API.
Perhaps one of the original authors can lend insight into the original motivation for these implements annotations.
Todo:

[x] Fix remaining errors
[ ] Add an automated test case to ensure the library can be imported without errors

The last error to fix is
../types/mixin/parent-node.d.ts:28:5 - error TS1170: A computed property name in a type literal must refer to an expression whose type is a literal type or a 'unique symbol' type.

28     [typeof NEXT]: NodeStruct;
       ~~~~~~~~~~~~~

../types/mixin/parent-node.d.ts:29:5 - error TS1170: A computed property name in a type literal must refer to an expression whose type is a literal type or a 'unique symbol' type.

29     [typeof PREV]: NodeStruct;
       ~~~~~~~~~~~~~

../types/mixin/parent-node.d.ts:30:5 - error TS1170: A computed property name in a type literal must refer to an expression whose type is a literal type or a 'unique symbol' type.

30     [typeof START]: NodeStruct;
       ~~~~~~~~~~~~~~

Found 3 errors in the same file, starting at: ../types/mixin/parent-node.d.ts:28

I think that is the right fix

oh gosh ... all definition files are automatically generated per each CI build step or locally before pushing to npm. Apologies I should've mentioned this as this PR is quite some effort if it was fixed manually per each generated file, but next release will re-create again all files and all changes will be lost.
The files you need to eventually change are in the esm folder, not in the types one, as that's all automation.

Oh shoot thanks!  I’ll make the correct changes when I’m back at my computer.

I noticed types/dom, types/html, types/interface, types/mixin, types/shared, types/svg,types/xml, and types/index.d.ts were not being auto-generated and haven't seen modifications in a very long time and the structure is the same as types/esm. I deleted these stale files.

At the moment the types aren't right yet.
This fails for example:
const {
  window, document, customElements,
  HTMLElement,
  Event, CustomEvent
} = parseHTML("");

I can't figure out where properties like window are set for Document...

At the moment there are a lot of types that are not right. Examples from the readme don't work.

I'm afraid this PR needs some linting adjustment or the CI won't be happy ... and I care about 100% code coverage and happy CI here. Please have a look and yes, exceptions accepted for linters!

I think this PR is good to go

oh gosh ... all definition files are automatically generated per each CI build step or locally before pushing to npm. Apologies I should've mentioned this as this PR is quite some effort if it was fixed manually per each generated file, but next release will re-create again all files and all changes will be lost.
The files you need to eventually change are in the esm folder, not in the types one, as that's all automation.

@WebReflection Hi, I want to contribute. Could you please explain what's the right way to include types? Are they generated from jsdoc comments?

@jeremy-rifkin

I think this PR is good to go

I just wonder once all "pretending to implement" classes are gone, if TS really helps out or it 'causes just confusion. There are things not really standard that might come up while using this project and I guess what are your thoughts there ... also, those two classes ... I think the implementation conforms with the standard? 🤔 are all implements needed to go?

@iMrDJAi yes, this JS project uses TSDoc and generates automatically types at build time.

I just wonder once all "pretending to implement" classes are gone, if TS really helps out or it 'causes just confusion. There are things not really standard that might come up while using this project and I guess what are your thoughts there ... also, those two classes ... I think the implementation conforms with the standard? 🤔 are all implements needed to go?

Thanks for taking a look! It may very well be these two classes do actually implement everything from their globalThis counterparts - I can re-introduce these implements annotations.
I think the one "pretending to implement" part remaining is whatever is returned by Document.defaultView. Alternatively to having it this function return a Proxy that's typed as typeof globalThis & { document: globalThis.Document & Document; }; we could make a proper class / type for exactly what a linkedom document view is. This would address the issue of non-standard things coming up.

this PR has conflicts ... please resolve those and I'd be happy to move forward, thanks!

no answer in years ... closing.


Ruby 3 Support

Note: For general questions and feature requests please leave a message
on Gitter: https://gitter.im/comfy/comfortable-mexican-sofa
Expected behavior
Should work
Actual behavior
MacBook-Pro-2.local ➜  t-website git:(master) ✗ rails s
=> Booting Puma
=> Rails <IP_ADDRESS> application starting in development
=> Run `bin/rails server --help` for more startup options
Exiting
/opt/homebrew/lib/ruby/gems/3.0.0/bundler/gems/comfortable-mexican-sofa-8f7e425a06ac/lib/comfortable_mexican_sofa/routes/cms_admin.rb:5:in `comfy_route_cms_admin': wrong number of arguments (given 1, expected 0) (ArgumentError)
	from /opt/homebrew/lib/ruby/gems/3.0.0/bundler/gems/comfortable-mexican-sofa-8f7e425a06ac/lib/comfortable_mexican_sofa/routing.rb:9:in `comfy_route'
	from /Users/hackeron/Development/t-website/config/routes.rb:2:in `block in <main>'

Steps to reproduce
Install Ruby 3.0.2
System configuration
Rails version: <IP_ADDRESS>
CMS version: git master (fetched 2021-12-04)
Ruby version: 3.0.2

Hi @rgaufman - I experienced the same thing trying to get Comfy/CMS to work with Ruby 3.x.x.. Unfortunately, I don't think Comfy/CMS is being maintained. 👎

check out https://github.com/restarone/comfortable-mexican-sofa

check out https://github.com/restarone/comfortable-mexican-sofa

man, you saved me, thank you very much!

Might need to open up the issue tracker on that fork.
DEPRECATION WARNING: TimeWithZone#to_s(:date) is deprecated. Please use TimeWithZone#to_fs(:date) instead. (called from render at /home/runner/work/growstuff/growstuff/vendor/bundle/ruby/3.1.0/bundler/gems/comfortable-mexican-sofa-456fb8507e96/lib/comfortable_mexican_sofa/render_methods.rb:59)


Swift 3.1 Warning

I'm getting this warning with Swfit 3.1:

Property should not be declared fileprivate because its type uses a private type

Is there any way to fix this or can you update the framework to be compatible with the new version of swift please?

Sorry for the delay, didn't notice this in my notifications. There isn't a way to fix it although I think the warning disappears in Swift 3.0. I've opened a PR to fix it, although I can't any timelines on when a release containing the fix will be released.


Improve the prioritization in getRevisionCandidates()

Please have a look at the individual commit messages for the details.

It's a bit unfortunate that we have no test case for this very important function that would show the difference your PR makes. Would you mind adding one?

Done, finally, @mnonnenmacher.


A.05.IR14.ds.keyword.md

This issue has been extracted from the issue list on:https://ies-svn.jrc.ec.europa.eu/issues/2685
Comment
The test method does not specify in which language to express an inspire theme or if it has to be a language neutral name like a URI:
'If a block is referencing that thesaurus the test should check if at least one keyword is available and it matches with a concept in the thesaurus.'
The MD Regulation requires a theme as it appears in the Annex I, II, III of the INSPIRE Directive
Proposed Change
Rephrase the test method as in the previous point and add the part in bold:
'
Test method
The test looks for an instance of descriptiveKeywords which references  the http://www.eionet.europa.eu/gemet/inspire_themes thesaurus.
The test succeeds if such instance is found and if it contains at least one keyword as it appears in the specified thesaurus in the language of the metadata.
'

Proposed Resolution
The TG MD specifies that the keyword shall be expressed in the metadata language OR using a neutral language value such as a URI. Update test method as follows:
""Test method: If the resource type is not dataset or series, this test is omitted.
The test should check whether a descriptiveKeywords block exists which references http://www.eionet.europa.eu/gemet/inspire_themes. If a block is referencing that thesaurus the test should check if at least one keyword is available and it matches with a concept in the thesaurus, in the language of the metadata OR using a language neutral URI. If a keyword from that source is found, the test succeeds, otherwise it will fail.""
When the proposed change is followed, A.26 which checks whether a metadata language is given, should be added as a prerequisite.

The proposed resolution depends on the resolution of #38, which is flagged for discussion.


Possible Allocation Error: AllocatorOutOfSpace

When I was trying to benchmark the runtime, I ran into an issue where a loop was causing AllocatorOutOfSpace errors.
You can reproduce this error by checking out this commit of Substrate:
https://github.com/paritytech/substrate/tree/7bd0ae11cdff291b805c9633f184e59f49d17e43
Run a node with ./target/release/substrate --dev --execution=Wasm --wasm-execution=Compiled
Then call the RPC state_call with IdentityBenchmarks_run_benchmarks
You will notice that the processes starts, completes a few loops, then returns the alocator out of space error.
We added some print statements around these error points and noticed a consistent growth in item_size which ultimately causes this error.
To solve this problem, we can reduce the size of the loop (before we hit a memory error), or we can use native execution.
Let me know if I can provide any more details.

Still facing this issue actually on the latest stuff. Large loops do not seem to be good here:
====================

Version: 2.0.0-5ee888f90-x86_64-macos

stack backtrace:
   0: backtrace::backtrace::trace
   1: backtrace::capture::Backtrace::new
   2: sp_panic_handler::set::{{closure}}
   3: std::panicking::rust_panic_with_hook
   4: std::panicking::continue_panic_fmt
   5: rust_begin_unwind
   6: core::panicking::panic_fmt
   7: core::result::unwrap_failed
   8: <<sp_io::allocator::HostFunctions as sp_wasm_interface::HostFunctions>::host_functions::ExtAllocatorMallocVersion1 as sp_wasm_interface::Function>::execute
   9: std::panicking::try::do_call
  10: __rust_maybe_catch_panic
  11: sc_executor_wasmtime::trampoline::stub_fn

Thread 'main' panicked at 'Failed to allocate memory: "Allocator ran out of space"', src/libcore/result.rs:1165

This is a bug. Please report it at:

        https://github.com/paritytech/substrate/issues/new

Error: Service(Other("Error executing runtime benchmark: FunctionExecution(\"ext_allocator_malloc_version_1\", \"Failed to allocate memory: \\\"Allocator ran out of space\\\"\")"))

Similar issue:
====================

Version: 2.0.0-2ed0a1d90-x86_64-macos

stack backtrace:
   0: backtrace::backtrace::trace
   1: backtrace::capture::Backtrace::new
   2: sp_panic_handler::set::{{closure}}
   3: std::panicking::rust_panic_with_hook
   4: std::panicking::continue_panic_fmt
   5: rust_begin_unwind
   6: core::panicking::panic_fmt
   7: core::result::unwrap_failed
   8: <<sp_io::allocator::HostFunctions as sp_wasm_interface::HostFunctions>::host_functions::ExtAllocatorMallocVersion1 as sp_wasm_interface::Function>::execute
   9: std::panicking::try::do_call
  10: __rust_maybe_catch_panic
  11: sc_executor_wasmtime::trampoline::stub_fn

Thread 'event.loop0' panicked at 'Failed to allocate memory: "Allocator ran out of space"', src/libcore/result.rs:1165

@shawntabrizi shawntabrizi assigned pepyakin 1 hour ago

maybe @cmichi can also help.


Remove non-functional if-failed code and warn

The way that the :if-failed argument to with-ftp-connection is
handled does not work. make-instance should never return nil, and
any errors signalled within initialize-instance will still be
signalled. I feel it would probably be futile to try and make it work
for the errors which this library signals, as connect-to-server
calls other functions which don't have an argument to avoid
signalling, so the client may be better served with ignore-errors or
similar.

Your analysis seems reasonable, and the patch looks like it should work,
though I don't have an environment set up to test it at the moment.
I'll, uh, have to remedy that.
As you note, getting :if-failed to work at all is likely to be more
trouble than it would be worth, so my initial inclination is to
deprecate it, rather than merely warn of non-functionality.  (In other
words, warn if it was specified at all, with the intent of removing the
argument at some point in the future.)
I'm a little sad I don't have anything prior to version 1.3 to go code
spelunking through, to try and figure out how it ended up that way, but
alas.  Before my time!   That said, looking at the history I do have, if
it doesn't work now it hasn't worked for /at least/ 13 years, so odds
are good nobody is relying on :if-failed.
Anyway, I'm rambling.  Thanks!  It's going to take me longer than I'd
like to get this (or something similar) merged in, but I appreciate the
analysis and patch.
On 11/26/21 5:44 PM, goose121 wrote:

The way that the :if-failed argument to with-ftp-connection is
handled does not work. make-instance should never return nil, and
any errors signalled within initialize-instance will still be
signalled. I feel it would probably be futile to try and make it work
for the errors which this library signals, as connect-to-server
calls other functions which don't have an argument to avoid
signalling, so the client may be better served with ignore-errors or
similar.
You can view, comment on, or merge this pull request online at:
https://github.com/pinterface/cl-ftp/pull/4
-- Commit Summary --

Remove non-functional if-failed code and warn

-- File Changes --
M ftp.lisp (10)

-- Patch Links --
https://github.com/pinterface/cl-ftp/pull/4.patch
https://github.com/pinterface/cl-ftp/pull/4.diff


custom cursor added

Have you read the Contributing Guidelines ?
yes
(Write your answer here.)
Description
Custom cursor is added to the website
(Write your answer here.)
Fixes #1207

Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#1207
(Write your answer here.)
sorry for not creating a separate branch for this PR, if you want i can create a new PR by creating a new branch.

Kindly review this PR.

@Kushal997-das  please kindly review this PR.


[Enhancement]: Update to 2068?

What changes would you like?
Update to 2068?
Any extra information?
No response

I've just bumped to 2071, build is in progress.

2071 is now live in stable

or just update to 2074 ?

2079 is merged and available in edge


Add missing instructions for setting the schema endpoint URI

Summary of the changes (Less than 80 chars)

Add missing instructions for setting the schema endpoint URI

Addresses #bugnumber (in this specific format)

/AzurePipelines run

Thank you for your contribution.


[feature] insert (pandoc) citekey   in the text

While writing academic text it would be useful to have a way to insert pandoc citation of an article into the text.
for example I would like to have the paragraph below
Wrting an article usually involve citing many authors [@harvey2022]

Using pandoc I  can further render this document.

would this be done via a slash command? (potential workflow:/insert pandoc citation → search for and select item → citation gets inserted inline)

indeed, this would be the most obvious worflow (and hotkey in addition maybe)


Kitchen TV: Can not reach TV

I have two TVs, one of them it is working well but the other one is not working sometime yes and sometime not. Please the error in the logs.

@SergioBraulioCadenaJuarez
Thats not a ‚bug‘. Some Sony TVs doesnt allow to access the API while in deep sleep. Therefore the plugin shows a warning because it is not reachable.

Sorry, thanks a lot for the support. I'll close this one because it is not a issue 😅


pull request for e2e test at 01/16/2017 21:45:16

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Added event listener on submit button to update the src of the iframe…

… dinamically to display nearby campsites based on user input

Good Job!


feat scrum board

This is a scrum board with statuses and cards that are commonly used in the scrum methodology for agile software developments

Hey. What's the idea of how this will be used? Should the sticky notes in the example scrum board be used for writing on?
Also, let's group the bug elements (select all the bug, and press Cmd/ctrl+G) for easier manipulation.

I think if we group the bug we are good to merge. Nice addition!

I have grouped the bugs elements, so that they can be easier to manipulate, I look forward to hearing your comments, thanks!!

Thanks! Merging


Introducing new plugin option to allow an empty error array to pass the

@jimkyndemeyer
This is from the brief discussion on https://github.com/jimkyndemeyer/js-graphql-intellij-plugin/issues/272
Empty error arrays are now allowed in introspected schemas. The user is presented a notification warning them that their errors are out of spec, and given the option to permanently hide the warning.
Added two tests, checking to make sure empty errors work & populated errors still fail.

It seems that this information is absolutely not important to the user. Especially if you are a front-end developer who just writes requests to a third-party API.

@vepanimas I agree and updated the PR to reflect your suggested changes. The user is now shown a warning detailing empty errors being out of spec, and given the option to hide it permanently. Given on how other GraphQL libraries have handled the empty errors array, I think we could even leave it out - although I know @jimkyndemeyer was passionate about it in the bug topic.


New version: RLEVectors v0.9.2

Registering package: RLEVectors
Repository: https://github.com/phaverty/RLEVectors.jl
Created by: @phaverty
Version: v0.9.2
Commit: 7da814b997125657eed10a9f233af8b661e66bdc
Reviewed by: @phaverty
Reference: https://github.com/phaverty/RLEVectors.jl/issues/25#issuecomment-545542011

Your new version pull request met all of the guidelines for automatic merging.
I will automatically merge this pull request during the next cron job.
If you want to prevent this pull request from being auto-merged, simply leave a comment.
(If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.)

On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.
Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)
If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.

[noblock]


New tool: add-axis

Similar to the METADATA.pb generator in the add-font tool, following https://github.com/google/fonts/pull/2541 we need simple little add-axis tool which will generate $AXIS.protobuff files for PR'ing into https://github.com/google/fonts by extracting the relevant information from the font's fvar/stat tables.
(Note that the file extension may change, per https://github.com/google/fonts/issues/2595)
I guess we need the axis.proto file that defines the schema that these axis registry files use, too. @nathan-williams please could you supply that? :)

The font binary only has some of the required axis metadata. Also, the GF Axis Registry axes are not intended to be font-specific.
IMO, such a utility doesn't add a lot of value and suggests a coupling between a specific font's axis definitions and those in the GF Axis Registry. What do you think?

Given we will author a relatively small number of axes, perhaps the time taken to write such a tool isn't worth it.
As we will also need to write FontBakery checks to ensure each family's METADATA is compliant with the registry, so perhaps a fontbakery developer like @graphicore or @felipesanches can pick this up at that moment as its a very small task.

Proto file is now added per IM discussion; assigning to Lasse for now

I'm not sure what to do with this assignment other than asking questions.

The font binary only has some of the required axis metadata. Also, the GF Axis Registry axes are not intended to be font-specific.
IMO, such a utility doesn't add a lot of value and suggests a coupling between a specific font's axis definitions and those in the GF Axis Registry. What do you think?

We could use an existing font to jump start (pre-fill) a new $AXIS.protobuff then maybe drop into an interactive mode that helps authoring or just have the user pick up in the editor from there. Also provide some types/sanity checking/does-it-parse validation on top. Could be all one workflow or accessed separately:

jump-start from font
interactive authoring (maybe this just opens $EDITOR)
validation

Given we will author a relatively small number of axes, perhaps the time taken to write such a tool isn't worth it.

Yes. Though, cut out the interactive stuff, or make it super simple based on $EDITOR plus  validation result, and it's probably small enough to start quickly.


[CHORE]: Move ecosystem page to App router

Move ecosystem page to App router
fix the useRouter logic
fix the scroll jumping issue

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


Support setReadOnly()

Why isn't setReadOnly supported? Are there any plans to do so? See line 3042:
https://github.com/Microsoft/mssql-jdbc/blob/19af32bb561685c681c364fbd4d2d02efdfd352b/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java#L3038-L3044

Hi @mkurz, according to the JDBC spec, setReadOnly is not defined as mandatory.
Would be happy to discuss the importance/use case of setReadOnly in your application/workload to try to understand what we can do to help you.

I also looked into other JDBC driver implementations, and it seems MySQL is making use of the setReadOnly parameter, whereas Postgresql and jTBC drivers are recording the isReadOnly but not making use of it.

@peterbae This is not correct, the PostgreSQL JDBC Driver does support the setReadOnly method:
https://github.com/pgjdbc/pgjdbc/blob/REL42.1.4/pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java#L688-L704
What is jTBC?
@ajlam I was evaluating how to make sure that certain users of our web application can not insert/update/delete records in our database. I thought we could just switch on the read-only flag at the beginning of a http request (if the web app user only has read-only permissions) - and switch it off when the request ends (so it is back in the connection pool as it was). Advantage of this approach would be to just (re-)use one single connection pool (which initially hosts read-write connections).
An alternative solution for now would be to use a seperate connection pool for such users which contains just read-only connections. It seems that should be possible by setting up such read-only connections with applicationIntent=ReadOnly in the connection url/properties (see docs). But also I am not sure if that is really working? See https://stackoverflow.com/questions/38356460/sql-server-application-intent-not-working-jdbc (I didn't try myself yet).
Also an alternative solution would be to use a seperate connection pool as well but with a read-only user on database level (instead of setting the intent connection property).
I know it is also possible to set a complete database to read only (ALTER DATABASE...) but that is clearly not an option for us as we have users who still want to write to the database.
As you can see we started looking into this as we were looking on how to make our database access more secure.
However we are also wondering if setting a connection (via applicationIntent) or certain queries within a connection (via setReadOnly) or using a db-level read-only user would result in better performance? Because maybe the database knows for sure there will not happen a write operation and therefore can optimize query plans, doesn't need to acquire locks, etc.
Are you aware of any positive effects on performance using read-only flag?
(I googled around a bit and found a page where they measured performance of a read-only database (ALTER DATABASE ..) was a few percent better than the same read-write database)

Hi @mkurz, thanks for detailing out your requirement with us.
It is true that you may find very minor performance improvements when you modify database to read-only mode by `ALTER DATABASE', but its not significant enough to be considered and also depends on your needs.
Looking at your requirement to secure database by restricting access to some users, the most optimum way to achieve this is by Creating a database user with read-only privileges on databases and connecting as read-only user every time restricted web-app users connect to your application. In this case, a separate connection pool can be maintained for read-only users such that it does not interfere with read-write connections.
Also, to clarify your doubts for applicationIntent=ReadOnly, this property can be used only on AlwaysOn AG and not legacy or read-only databases. It is used to enable read-only routing which creates a read-only replica of database and connects to it. Also, it may take longer than connecting to the primary database because read-only routing first connects to the primary and then looks for the best available readable secondary, which I think in your scenario, is not what you are looking for.
We have not considered providing support for 'setReadOnly' yet. It is said to boost some performance as database need not maintain transaction locks in this scenario, but you will need to make this property true for every connection read-only user is connecting to. On the contrary, significant performance improvement can be achieved by different means, e.g. using batches, optimized queries, creating indices on DB tables, etc.

We have not considered providing support for setReadOnly yet.

You mean providing support by the JDBC driver or within SQL Server itself? Is it possible to turn read-only on and off (back and forth) in SQL Server itself for an active connection right now? How can this be achieved - can you provide a SQL a snippet? If so, I think it would be probably not to hard to implement this in the JDBC driver - or am I wrong?

... but you will need to make this property true for every connection read-only user is connecting to.

This wouldn't be an issue for us as we have a well layered, modularized application source code where we could handle this globally (without the risk that a dev "forgets" to set/unset the read-only flag by automatically switching it depending on the role of the connected web app user).

On the contrary, significant performance improvement can be achieved by different means, e.g. using batches, optimized queries, creating indices on DB tables, etc.

Yeah, for sure. I also thought there are probably many more obvious ways to improve performance. For us read-only isn't about performance improvements in the first place, but would be a nice side effect.
Anyway, I problably will go for the read-only database user with its dedicated connection pool for now.
However supporting setReadOnly would also be nice so people could choose from more options on how to desgin their databases and apps.

I meant to say support for setReadOnly in JDBC driver, it isn't a hard implementation, we will start working on it as well (Will keep this issue open to track implementation progress).. We hadn't focused on it before as it is not defined as mandatory in JDBC specifications and we didn't receive any customer request for implementing this before.
I wanted to suggest a better solution to your use case, as an ideal solution seemed to be with database users with restricted access rights.
Thanks for bringing up the issue anyways, we will update you when we make the feature available.

@cheenamalhotra thanks, great to hear this will be implemented! :+1:
Also thanks to @ajlam and @peterbae for reaching out to me. :smile:

Is it possible to turn read-only on and off (back and forth) in SQL Server itself for an active connection right now? How can this be achieved - can you provide a SQL a snippet?
Hi @mkurz We tried to find a solution for this - but unfortunately SQL Server doesn't support it by itself too. The link provided by you works for PostgresSQL since the database supports read only session properties. Unfortunately, for SQL Server there is no such thing, and that's the reason why no driver supports Read Only Connection to SQL Server. The only way to implement it is by driver intelligently detecting read-only property from connection and then behaving appropriately but that also means the driver gets to decide norms for 'read-only' connection.
We don't think that's an ideal solution too, and hence decided to not go ahead for implementation. Sorry for the delay since we were looking into lots of activities and checking all possibilities for providing support.
Let me know if you have any further questions.

No further questions. Thanks for investing your time into this issue! Although it's a pity this is not possible we can live without that feature.
Thanks!

Thanks @mkurz closing the issue !


17 different modifiers per training stage

I've added an extended stage syntax in the format of:
stagename:
  mix:
    - dataset1 frac
    - dataset2 frac
    - until dataset3 epochs
  modifiers:
    - Modifier: freq

This then overrides the curriculum wide configuration of modifiers. You can use YAML anchors, references, and extends to make much more complicated configurations with this.
I've also updated the Loader to throw CurriculumLoaderError instead of AssertionError which wasn't being executed when running with -O. And I've added more tests for the CurriculumLoader.

I like this. Basically, all of the previous configurations are still valid, but now we have an extended version to work on!


possible lcms bug in profile verification?

Hello everyone,
First, thank you for this nice library, libvips has relied on it for years.
One of our users has reported strange behaviour here:
https://github.com/libvips/libvips/issues/2562
This JPG has an odd embedded profile. libvips is able to use the profile to convert pixels into PCS for processing, but using the profile to convert from PCS back to device space fails (you just get black pixels).
We call cmsIsIntentSupported(profile, intent, LCMS_USED_AS_OUTPUT) to check the profile before doing the PCS -> device space transform, and that returns TRUE, so lcms seems to think the profile is good.
Is there something else we should be checking? Or is this just a broken profile?

Hi John,
That's Marti Maria, nice to meet you again. Thanks for reporting, indeed it was a bug introduced circa 2017 when trying to put some safaguards against divisions by zero. Unfortunately the code was discarding valid combinations as well.
Should be fixed by 8fb182279d9418b1477bb2bfe28e8ed4926e2318
Regards

Hi Marti, thank you very much for fixing this.
Yes, it's nice to interact again, libvips has been following your great work for many, many years now. I almost moved to Barcelona in the 90s to work at HP's large format printer division, so I feel a connection.

Seems fixed, so I close it


If the overlay is double, one of those overlay can't close.

As I told on the title, if the overlay is double, I can't close the one of those. isActive method detect false and closeOverlay not working at that time whenever the overlay is double.

Go into the java code, find showOverlay() in the FlutterOverlayWindowPlugin.java and add:
if (OverlayService.isRunning) return;

@sidetraxaudio
sir i try your solution but its not work for me it still give me multiple overlays after I visit in particular page again in my app

Go into the java code, find showOverlay() in the FlutterOverlayWindowPlugin.java and add: if (OverlayService.isRunning) return;

This solution doesn't working for me.

I think the problem is creating new flutter engine each time the activity is attached.
So, I tried to edit [onAttachedToActivity] method in [FlutterOverlayWindowPlugin.java] file to be:-
@Override
public void onAttachedToActivity(@NonNull ActivityPluginBinding binding) {
mActivity = binding.getActivity();
if(FlutterEngineCache.getInstance().get(OverlayConstants.CACHED_TAG) == null){  //<---
FlutterEngineGroup enn = new FlutterEngineGroup(context);
DartExecutor.DartEntrypoint dEntry = new DartExecutor.DartEntrypoint(
FlutterInjector.instance().flutterLoader().findAppBundlePath(),
"overlayMain");
FlutterEngine engine = enn.createAndRunEngine(context, dEntry);
FlutterEngineCache.getInstance().put(OverlayConstants.CACHED_TAG, engine);
}
binding.addActivityResultListener(this);
}

Fixed here to avoid duplication of the overlay
  flutter_overlay_window:
    git:
      url: git@github.com:X-SLAYER/flutter_overlay_window.git
      ref: feature/overlay-improvements


Add a User table with attributes

add user with attribute first_name, name, address, age and other if you have suggestion.

It ok with me

It ok with me

It is ok with me.


UnitsNet.PressureChangeRate missing BaseUnit property

The PressureChangeRate struct is missing a "BaseUnit" property. All other units of measure contain a property called "BaseUnit" that returns the base unit of measure. Is it possible to add this property to PressureChangeRate? Thanks.

Thanks for pointing this out. I regenerated the code and pushed a new nuget 3.21.1.
Sometimes when merging in pull requests it has outdated generated code.


qmp: fix mem-path properties for hotplug memory.

"mem-path" is the key of map "props" instead of "args"

Coverage decreased (-0.09%) to 79.988% when pulling db47442f01b15a0ef23ee7cc8f807751ae3189a3 on BetaXOi:fix-mempath into c664d3dd94e087ccb7bbc18a816d169dbc5e2aac on intel:master.

Coverage decreased (-0.09%) to 79.988% when pulling db47442f01b15a0ef23ee7cc8f807751ae3189a3 on BetaXOi:fix-mempath into c664d3dd94e087ccb7bbc18a816d169dbc5e2aac on intel:master.

Coverage decreased (-0.09%) to 79.988% when pulling db47442f01b15a0ef23ee7cc8f807751ae3189a3 on BetaXOi:fix-mempath into c664d3dd94e087ccb7bbc18a816d169dbc5e2aac on intel:master.

@bergwolf IIRC you added the original code for memory hotplug, or at least were the last person to modify it.  Do these changes make sense to you?

@BetaXOi I agree with @markdryan , please add a commit message with a description of what you're doing. Also, it'd be helpful that you reference what changed that makes this patch necessary. I mean, I thought the memory hotplug code was working before.
Is it related to the version of Qemu that you're using?

@markdryan @sboeuf @bergwolf I have update the commit, please help review.

LGTM. Thanks @BetaXOi


Upload fails after period of inactivity

FTP Server OS: Windows
FTP Server Type: Windows Server IIS
Client Computer OS: Ubuntu
FluentFTP Version: 48.0.3
Framework: .NET 8
Hi,
A similar error as the one reported in #1082 is happening in the latest version of the library. I've modified the code to reproduce it a bit from the one in #1082 to show case the issue. The problem is the same, trying to upload after a period of inactivity yields a failure, but this time it doesn't throw (see logs for more details). However, if there's a second upload it successfully reconnects and uploads the file.
Code:
using FluentFTP;
using System.Text;

var client = new AsyncFtpClient("ftpserver.com", "user", "pass");
client.Config.LogToConsole = true;
await client.AutoConnect();

Console.WriteLine("connected");

var fileData = Encoding.UTF8.GetBytes("Test message");

Console.WriteLine("upload 1");

await client.UploadBytes(fileData, "file/test1.txt", createRemoteDir: true);

await Task.Delay(TimeSpan.FromMinutes(5));

Console.WriteLine("delay expired");

Console.WriteLine("upload 2");

// second upload doesn't work
await client.UploadBytes(fileData, "file/test2.txt", createRemoteDir: true);

Console.WriteLine("upload 3");

// third upload succesfully reconnects
await client.UploadBytes(fileData, "file/test2.txt", createRemoteDir: true);

Console.WriteLine("done");

Logs :

# AutoConnect()

# AutoDetect(CloneConnection = False, FirstOnly = True, IncludeImplicit = True, RequireEncryption = False, ProtocolPriority = [Tls11, Tls12])
Status:   Auto-Detect trying encryption mode "Auto" with "Tls11, Tls12"

# Connect(False)
Status:   FluentFTP <IP_ADDRESS>(.NET 6.0)
Status:   Connecting to IP #1= ***:21
Status:   Waiting for a response
Response: 220 Microsoft FTP Service [738866,687d]
Status:   Detected FTP server: WindowsServerIIS
Command:  AUTH TLS
Status:   Waiting for response to: AUTH TLS
Response: 234 AUTH command ok. Expecting TLS Negotiation. [27ms]
Warning:  SSL Buffering disabled because of .NET 5.0 and later
Status:   FTPS authentication successful, lib = .NET SslStream, cipher suite = Tls12 (Aes256, TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, DiffieHellman, 0) [133ms]
Command:  USER ***
Status:   Waiting for response to: USER ***
Response: 331 Password required [30ms]
Command:  PASS ***
Status:   Waiting for response to: PASS ***
Response: 230 User logged in. [43ms]
Command:  PBSZ 0
Status:   Waiting for response to: PBSZ 0
Response: 200 PBSZ command successful. [23ms]
Command:  PROT P
Status:   Waiting for response to: PROT P
Response: 200 PROT command successful. [51ms]
Command:  FEAT
Status:   Waiting for response to: FEAT
Response: 211-Extended features supported:
Response: LANG EN*
Response: UTF8
Response: AUTH TLS;TLS-C;SSL;TLS-P;
Response: PBSZ
Response: PROT C;P;
Response: CCC
Response: HOST
Response: SIZE
Response: MDTM
Response: REST STREAM
Response: 211 END [32ms]
Status:   Text encoding: System.Text.UTF8Encoding+UTF8EncodingSealed
Command:  OPTS UTF8 ON
Status:   Waiting for response to: OPTS UTF8 ON
Response: 200 OPTS UTF8 command successful - UTF8 encoding now ON. [29ms]
Command:  SYST
Status:   Waiting for response to: SYST
Response: 215 Windows_NT [31ms]
Status:   Listing parser set to: Windows
Command:  PWD
Status:   Waiting for response to: PWD
Response: 257 "/" is current directory. [34ms]
connected
upload 1

# UploadBytes("file/test1.txt", Overwrite, True)

# FileExists("file/test1.txt")
Command:  SIZE /file/test1.txt
Status:   Waiting for response to: SIZE /file/test1.txt
Response: 213 12 [33ms]

# DeleteFile("file/test1.txt")
Command:  DELE file/test1.txt
Status:   Waiting for response to: DELE file/test1.txt
Response: 250 DELE command successful. [40ms]

# OpenWrite("file/test1.txt", Binary)
Command:  TYPE I
Status:   Waiting for response to: TYPE I
Response: 200 Type set to I. [40ms]

# OpenDataStreamAsync("STOR file/test1.txt", 0)

# OpenPassiveDataStreamAsync(PASV, "STOR file/test1.txt", 0)
Command:  PASV
Status:   Waiting for response to: PASV
Response: 227 Entering Passive Mode (***). [26ms]
Status:   Connecting to IP #1= ***:50023
Command:  STOR file/test1.txt
Status:   Waiting for response to: STOR file/test1.txt
Response: 150 Opening BINARY mode data connection. [33ms]
Warning:  SSL Buffering disabled because of .NET 5.0 and later
Status:   FTPS authentication successful, lib = .NET SslStream, cipher suite = Tls12 (Aes256, TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, DiffieHellman, 0) [81ms]
Status:   Uploaded 12 bytes
Status:   Closing/Disposing FtpSocketStream(data connection)
Status:   Waiting for response to: STOR file/test1.txt
Response: 226 Transfer complete. [152ms]
delay expired
upload 2

# UploadBytes("file/test2.txt", Overwrite, True)

# FileExists("file/test2.txt")
Command:  SIZE /file/test2.txt
Status:   IOException for file  : Unable to write data to the transport connection: Broken pipe.
upload 3

# UploadBytes("file/test2.txt", Overwrite, True)

# FileExists("file/test2.txt")
Status:   Closing/Disposing FtpSocketStream(control connection)
Warning:  Reconnect needed due to disconnected control connection
Status:   Command stashed: SIZE /file/test2.txt

# Connect(True)
Warning:  Reconnect (Count: 1)
Status:   FluentFTP <IP_ADDRESS>(.NET 6.0)
Status:   Connecting to IP #1= ***:21
Status:   Waiting for a response
Response: 220 Microsoft FTP Service [5,004m]
Status:   Detected FTP server: WindowsServerIIS
Command:  AUTH TLS
Status:   Waiting for response to: AUTH TLS
Response: 234 AUTH command ok. Expecting TLS Negotiation. [31ms]
Warning:  SSL Buffering disabled because of .NET 5.0 and later
Status:   FTPS authentication successful, lib = .NET SslStream, cipher suite = Tls12 (Aes256, TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, DiffieHellman, 0) [77ms]
Command:  USER ***
Status:   Waiting for response to: USER ***
Response: 331 Password required [27ms]
Command:  PASS ***
Status:   Waiting for response to: PASS ***
Response: 230 User logged in. [29ms]
Command:  PBSZ 0
Status:   Waiting for response to: PBSZ 0
Response: 200 PBSZ command successful. [29ms]
Command:  PROT P
Status:   Waiting for response to: PROT P
Response: 200 PROT command successful. [29ms]
Command:  FEAT
Status:   Waiting for response to: FEAT
Response: 211-Extended features supported:
Response: LANG EN*
Response: UTF8
Response: AUTH TLS;TLS-C;SSL;TLS-P;
Response: PBSZ
Response: PROT C;P;
Response: CCC
Response: HOST
Response: SIZE
Response: MDTM
Response: REST STREAM
Response: 211 END [31ms]
Status:   Text encoding: System.Text.UTF8Encoding+UTF8EncodingSealed
Command:  OPTS UTF8 ON
Status:   Waiting for response to: OPTS UTF8 ON
Response: 200 OPTS UTF8 command successful - UTF8 encoding now ON. [35ms]
Command:  SYST
Status:   Waiting for response to: SYST
Response: 215 Windows_NT [31ms]
Status:   Listing parser set to: Windows
Command:  TYPE I
Status:   Waiting for response to: TYPE I
Response: 200 Type set to I. [43ms]

# SetWorkingDirectory("/")
Command:  CWD /
Status:   Waiting for response to: CWD /
Response: 250 CWD command successful. [39ms]

Status:   Executing stashed command

Command:  SIZE /file/test2.txt
Status:   Waiting for response to: SIZE /file/test2.txt
Response: 550 The system cannot find the file specified.  [27ms]

# DirectoryExists("file")
Command:  CWD file
Status:   Waiting for response to: CWD file
Response: 250 CWD command successful. [54ms]
Command:  PWD
Status:   Waiting for response to: PWD
Response: 257 "/file" is current directory. [28ms]
Command:  CWD /
Status:   Waiting for response to: CWD /
Response: 250 CWD command successful. [24ms]

# OpenWrite("file/test2.txt", Binary)

# OpenDataStreamAsync("STOR file/test2.txt", 0)

# OpenPassiveDataStreamAsync(PASV, "STOR file/test2.txt", 0)
Command:  PASV
Status:   Waiting for response to: PASV
Response: 227 Entering Passive Mode (***). [40ms]
Status:   Connecting to IP #1= ***:50033
Command:  STOR file/test2.txt
Status:   Waiting for response to: STOR file/test2.txt
Response: 150 Opening BINARY mode data connection. [30ms]
Warning:  SSL Buffering disabled because of .NET 5.0 and later
Status:   FTPS authentication successful, lib = .NET SslStream, cipher suite = Tls12 (Aes256, TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, DiffieHellman, 0) [65ms]
Status:   Uploaded 12 bytes
Status:   Closing/Disposing FtpSocketStream(data connection)
Status:   Waiting for response to: STOR file/test2.txt
Response: 226 Transfer complete. [124ms]
done

Is there any way you might pick up the current master in this repo and play with that, produce a new log? I made some changes.
It might not help in this case, but it's a step forward. It depends a lot on how the timout is performed by the server. Some send a nice polite message before closing, others are more brutal.
My tests with proFTPd behave differently and I would ask you to help by testing this now on your IIS server.

Sure, I've tested it on master. It still doesn't work. The log is the following:
# AutoConnect()

# AutoDetect(CloneConnection = False, FirstOnly = True, IncludeImplicit = True, AbortOnTimeout = True, RequireEncryption = False, ProtocolPriority = [Tls11, Tls12])
Status:   Auto-Detect trying encryption mode "Auto" with "Tls11, Tls12"

# Connect(False)
Status:   FluentFTP <IP_ADDRESS>(.NET 6.0)
Status:   Connecting to IP #1= ***:21
Status:   Waiting for a response
Response: 220 Microsoft FTP Service [738868,903d]
Status:   Detected FTP server: WindowsServerIIS
Command:  AUTH TLS
Status:   Waiting for response to: AUTH TLS
Response: 234 AUTH command ok. Expecting TLS Negotiation. [36ms]
Warning:  SSL Buffering disabled because of .NET 5.0 and later
Status:   FTPS authentication successful, lib = .NET SslStream, cipher suite = Tls12 (Aes256, TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, DiffieHellman, 0) [152ms]
Command:  USER ***
Status:   Waiting for response to: USER ***
Response: 331 Password required [40ms]
Command:  PASS ***
Status:   Waiting for response to: PASS ***
Response: 230 User logged in. [265ms]
Command:  PBSZ 0
Status:   Waiting for response to: PBSZ 0
Response: 200 PBSZ command successful. [47ms]
Command:  PROT P
Status:   Waiting for response to: PROT P
Response: 200 PROT command successful. [50ms]
Command:  FEAT
Status:   Waiting for response to: FEAT
Response: 211-Extended features supported:
Response: LANG EN*
Response: UTF8
Response: AUTH TLS;TLS-C;SSL;TLS-P;
Response: PBSZ
Response: PROT C;P;
Response: CCC
Response: HOST
Response: SIZE
Response: MDTM
Response: REST STREAM
Response: 211 END [65ms]
Status:   Text encoding: System.Text.UTF8Encoding+UTF8EncodingSealed
Command:  OPTS UTF8 ON
Status:   Waiting for response to: OPTS UTF8 ON
Response: 200 OPTS UTF8 command successful - UTF8 encoding now ON. [66ms]
Command:  SYST
Status:   Waiting for response to: SYST
Response: 215 Windows_NT [47ms]
Status:   Active ServerHandler is: WindowsServerIIS
Status:   Listing parser set to: Windows
Command:  PWD
Status:   Waiting for response to: PWD
Response: 257 "/" is current directory. [105ms]
connected
upload 1

# UploadBytes("file/test1.txt", Overwrite, True)

# FileExists("file/test1.txt")
Command:  SIZE /file/test1.txt
Status:   Waiting for response to: SIZE /file/test1.txt
Response: 213 12 [116ms]

# DeleteFile("file/test1.txt")
Command:  DELE file/test1.txt
Status:   Waiting for response to: DELE file/test1.txt
Response: 250 DELE command successful. [50ms]

# OpenWrite("file/test1.txt", Binary, -1, False)
Command:  TYPE I
Status:   Waiting for response to: TYPE I
Response: 200 Type set to I. [42ms]

# OpenDataStreamAsync("STOR file/test1.txt", 0)

# OpenPassiveDataStreamAsync(PASV, "STOR file/test1.txt", 0)
Command:  PASV
Status:   Waiting for response to: PASV
Response: 227 Entering Passive Mode (***). [34ms]
Status:   Connecting to IP #1= ***:50001
Command:  STOR file/test1.txt
Status:   Waiting for response to: STOR file/test1.txt
Response: 150 Opening BINARY mode data connection. [44ms]
Warning:  SSL Buffering disabled because of .NET 5.0 and later
Status:   FTPS authentication successful, lib = .NET SslStream, cipher suite = Tls12 (Aes256, TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, DiffieHellman, 0) [99ms]
Status:   Uploaded 12 bytes
Status:   Closing/Disposing FtpSocketStream(data connection)
Status:   Waiting for response to: STOR file/test1.txt
Response: 226 Transfer complete. [183ms]
delay expired
upload 2

# UploadBytes("file/test2.txt", Overwrite, True)

# FileExists("file/test2.txt")
Command:  SIZE /file/test2.txt
Status:   IOException for file  : Unable to write data to the transport connection: Broken pipe.
upload 3

# UploadBytes("file/test2.txt", Overwrite, True)

# FileExists("file/test2.txt")
Status:   Closing/Disposing FtpSocketStream(control connection)
Warning:  Reconnect needed due to disconnected control connection
Status:   Command stashed: SIZE /file/test2.txt

# Connect(True)
Warning:  Reconnect (Count: 1)
Status:   FluentFTP <IP_ADDRESS>(.NET 6.0)
Status:   Connecting to IP #1= ***:21
Status:   Waiting for a response
Response: 220 Microsoft FTP Service [5,502m]
Status:   Detected FTP server: WindowsServerIIS
Command:  AUTH TLS
Status:   Waiting for response to: AUTH TLS
Response: 234 AUTH command ok. Expecting TLS Negotiation. [43ms]
Warning:  SSL Buffering disabled because of .NET 5.0 and later
Status:   FTPS authentication successful, lib = .NET SslStream, cipher suite = Tls12 (Aes256, TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, DiffieHellman, 0) [95ms]
Command:  USER ***
Status:   Waiting for response to: USER ***
Response: 331 Password required [37ms]
Command:  PASS ***
Status:   Waiting for response to: PASS ***
Response: 230 User logged in. [32ms]
Command:  PBSZ 0
Status:   Waiting for response to: PBSZ 0
Response: 200 PBSZ command successful. [30ms]
Command:  PROT P
Status:   Waiting for response to: PROT P
Response: 200 PROT command successful. [34ms]
Command:  FEAT
Status:   Waiting for response to: FEAT
Response: 211-Extended features supported:
Response: LANG EN*
Response: UTF8
Response: AUTH TLS;TLS-C;SSL;TLS-P;
Response: PBSZ
Response: PROT C;P;
Response: CCC
Response: HOST
Response: SIZE
Response: MDTM
Response: REST STREAM
Response: 211 END [37ms]
Status:   Text encoding: System.Text.UTF8Encoding+UTF8EncodingSealed
Command:  OPTS UTF8 ON
Status:   Waiting for response to: OPTS UTF8 ON
Response: 200 OPTS UTF8 command successful - UTF8 encoding now ON. [30ms]
Command:  SYST
Status:   Waiting for response to: SYST
Response: 215 Windows_NT [44ms]
Status:   Active ServerHandler is: WindowsServerIIS
Status:   Listing parser set to: Windows
Command:  TYPE I
Status:   Waiting for response to: TYPE I
Response: 200 Type set to I. [37ms]

# SetWorkingDirectory("/")
Command:  CWD /
Status:   Waiting for response to: CWD /
Response: 250 CWD command successful. [46ms]

Status:   Executing stashed command

Command:  SIZE /file/test2.txt
Status:   Waiting for response to: SIZE /file/test2.txt
Response: 213 12 [39ms]

# DeleteFile("file/test2.txt")
Command:  DELE file/test2.txt
Status:   Waiting for response to: DELE file/test2.txt
Response: 250 DELE command successful. [47ms]

# OpenWrite("file/test2.txt", Binary, -1, False)

# OpenDataStreamAsync("STOR file/test2.txt", 0)

# OpenPassiveDataStreamAsync(PASV, "STOR file/test2.txt", 0)
Command:  PASV
Status:   Waiting for response to: PASV
Response: 227 Entering Passive Mode (***). [46ms]
Status:   Connecting to IP #1= ***:50007
Command:  STOR file/test2.txt
Status:   Waiting for response to: STOR file/test2.txt
Response: 150 Opening BINARY mode data connection. [71ms]
Warning:  SSL Buffering disabled because of .NET 5.0 and later
Status:   FTPS authentication successful, lib = .NET SslStream, cipher suite = Tls12 (Aes256, TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, DiffieHellman, 0) [81ms]
Status:   Uploaded 12 bytes
Status:   Closing/Disposing FtpSocketStream(data connection)
Status:   Waiting for response to: STOR file/test2.txt
Response: 226 Transfer complete. [199ms]
done

Thanks. I'll work on using that status

You might also like to look at #1410. We are also looking at ways to check for server availability at the users discretion, perhaps a new API function to help with that.
The problem is: You cannot check for connectivity without SENDind anything - and that send (at least in the case of FTP) must be a non destructive command (like NOOP). And you don't want to check all the time, because of the overhead.
In your case, we are getting an IOException on the SIZE command, which seems to be consumed erroneously. I'll look into that.
Bit difficult, as I cannot reproduce this specific behaviour even with your source code.

Regarding #1410, I've tested the new IsStillConnected method. I get false when called after delay, however when I issue a reconnect I also get the broken pipe error.
Another possible solution might be to give the ability to configure KeepAlive (TcpKeepAliveTime, TcpKeepAliveInterval). In the past I've solved problems with half open connections severed by load balancers by changing those, as the ones configured by default are too long to be useful.

Regarding https://github.com/robinrodricks/FluentFTP/issues/1410, I've tested the new IsStillConnected method. I get false when called after delay, however when I issue a reconnect I also get the broken pipe error.

As you can see in #1410, that is still somewhat in progress. Please continue monitoring that or even test it again,

Another possible solution might be to give the ability to configure KeepAlive (TcpKeepAliveTime, TcpKeepAliveInterval). In the past I've solved problems with half open connections severed by load balancers by changing those, as the ones configured by default are too long to be useful.

Yes, I've seen these mentioned in the internet too when researching connection issues and have taken note that we might want a Config option to set these.

In your case, we are getting an IOException on the SIZE command, which seems to be consumed erroneously.

My statement is wrong.
Out entire automatic retry/reconnect logic relies on being able to detect a disconnection before entering a command. We are currently not able to retry a command after it fails due to a disconnection.

One suggestion I would make, is to check the returned value from the uploadbytes. It should be reporting a failure. I have tried to reproduce this and am not successful.

Just to clarify, the issue is not a blocker for me. I've mitigated it by issuing a reconnect (the command fails, but it updates the internal state so that the next command is successful), I could use your suggestion to avoid doing it every time as it returns Failed.
BTW, I've tested the latest implementation of IsStillConnected and throws and exception. I call it after the delay, here is the stack trace just in case it helps:
# IsStillConnected(10000)
Command:  NOOP
Unhandled exception. System.IO.IOException: Unable to write data to the transport connection: Broken pipe.
 ---> System.Net.Sockets.SocketException (32): Broken pipe
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.CreateException(SocketError error, Boolean forAsyncThrow)
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.SendAsyncForNetworkStream(Socket socket, CancellationToken cancellationToken)
   at System.Net.Sockets.Socket.SendAsyncForNetworkStream(ReadOnlyMemory`1 buffer, SocketFlags socketFlags, CancellationToken cancellationToken)
   at System.Net.Sockets.NetworkStream.WriteAsync(ReadOnlyMemory`1 buffer, CancellationToken cancellationToken)
   at System.Net.Security.SslStream.WriteSingleChunk[TIOAdapter](ReadOnlyMemory`1 buffer, CancellationToken cancellationToken)
   at System.Net.Security.SslStream.WriteAsyncInternal[TIOAdapter](ReadOnlyMemory`1 buffer, CancellationToken cancellationToken)
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at System.Net.Security.SslStream.WriteAsyncInternal[TIOAdapter](ReadOnlyMemory`1 buffer, CancellationToken cancellationToken)
   at System.Net.Security.SslStream.WriteAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken cancellationToken)
   at FluentFTP.FtpSocketStream.WriteAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken token) in /Users/josecu08/Desktop/FluentFTP/FluentFTP/Streams/FtpSocketStream.cs:line 763
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at FluentFTP.FtpSocketStream.WriteAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken token)
   at FluentFTP.FtpSocketStream.WriteLineAsync(Encoding encoding, String buf, CancellationToken token) in /Users/josecu08/Desktop/FluentFTP/FluentFTP/Streams/FtpSocketStream.cs:line 786
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at FluentFTP.FtpSocketStream.WriteLineAsync(Encoding encoding, String buf, CancellationToken token)
   at FluentFTP.AsyncFtpClient.NoopAsync(Boolean ignoreNoopInterval, CancellationToken token) in /Users/josecu08/Desktop/FluentFTP/FluentFTP/Client/AsyncClient/Noop.cs:line 26
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at FluentFTP.AsyncFtpClient.NoopAsync(Boolean ignoreNoopInterval, CancellationToken token)
   at FluentFTP.AsyncFtpClient.IsStillConnected(Int32 timeout, CancellationToken token) in /Users/josecu08/Desktop/FluentFTP/FluentFTP/Client/AsyncClient/IsStillConnected.cs:line 21
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at FluentFTP.AsyncFtpClient.IsStillConnected(Int32 timeout, CancellationToken token)
   at Program.<Main>$(String[] args) in /Users/josecu08/Desktop/FluentFTP/test/Program.cs:line 21
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext(Thread threadPoolThread)
   at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining)
   at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
   at System.Threading.Tasks.Task.TrySetResult()
   at System.Threading.Tasks.Task.DelayPromise.CompleteTimedOut()
   at System.Threading.TimerQueueTimer.Fire(Boolean isThreadPool)
   at System.Threading.TimerQueue.FireNextTimers()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()
   at System.Threading.Thread.StartCallback()
--- End of stack trace from previous location ---

   --- End of inner exception stack trace ---
   at System.Net.Security.SslStream.<WriteSingleChunk>g__CompleteWriteAsync|157_1[TIOAdapter](ValueTask writeTask, Byte[] bufferToReturn)
   at System.Net.Security.SslStream.WriteAsyncInternal[TIOAdapter](ReadOnlyMemory`1 buffer, CancellationToken cancellationToken)
   at FluentFTP.FtpSocketStream.WriteAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken token) in /Users/josecu08/Desktop/FluentFTP/FluentFTP/Streams/FtpSocketStream.cs:line 763
   at FluentFTP.FtpSocketStream.WriteLineAsync(Encoding encoding, String buf, CancellationToken token) in /Users/josecu08/Desktop/FluentFTP/FluentFTP/Streams/FtpSocketStream.cs:line 786
   at FluentFTP.AsyncFtpClient.NoopAsync(Boolean ignoreNoopInterval, CancellationToken token) in /Users/josecu08/Desktop/FluentFTP/FluentFTP/Client/AsyncClient/Noop.cs:line 26
   at FluentFTP.AsyncFtpClient.IsStillConnected(Int32 timeout, CancellationToken token) in /Users/josecu08/Desktop/FluentFTP/FluentFTP/Client/AsyncClient/IsStillConnected.cs:line 21
   at Program.<Main>$(String[] args) in /Users/josecu08/Desktop/FluentFTP/test/Program.cs:line 21
   at Program.<Main>(String[] args)

Thanks for your patience.
I am very slowly getting to the core of the problem, but still very unsure of how to handle this.

BTW, I've tested the latest implementation of IsStillConnected and throws and exception. I call it after the delay, here is the stack trace just in case it helps:

Yes it does, it tells me I must further modify this new function to make it better - it currently just checks exceptions on the READ part. It should also do so on the SEND. So there will be another commit on master to make that work better.

Check out this one:
#1419
https://github.com/FanDjango/FluentFTP/tree/THREAD

It works. It executes all commands after the delay without error.

Wohoo! But it will be a while until it is in NuGet, or even merged into Master. Still ironing out some things.
But BIG THANKS for such a quick test.
@robinrodricks Look see! Demon-Noop has passed it's first test in the wild.

This has moved to #1420, it has been improved further.


error when trying to install with node version 11.5.0

C:\Users\smarigowda\SAN\gitLab\wdioPOC (master -> origin<EMAIL_ADDRESS>λ yarn add wdio-mocha-framework
yarn add v1.12.3
info No lockfile found.
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
error C:\Users\smarigowda\SAN\gitLab\wdioPOC\node_modules\fibers: Command failed.
Exit code: 1
Command: node build.js || nodejs build.js
Arguments:
Directory: C:\Users\smarigowda\SAN\gitLab\wdioPOC\node_modules\fibers
Output:
C:\Users\smarigowda\SAN\gitLab\wdioPOC\node_modules\fibers>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\....\node_modules\node-gyp\bin\node-gyp.js" rebuild --release )  else (node "" rebuild --release )
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| win32 | x64
gyp ERR! configure error
gyp ERR! stack Error: Command failed: C:\Users\smarigowda\AppData\Local\Programs\Python\Python37-32\python.EXE -c import sys; print "%s.%s.%s" % sys.version_info[:3];
gyp ERR! stack   File "", line 1
gyp ERR! stack     import sys; print "%s.%s.%s" % sys.version_info[:3];
gyp ERR! stack                                ^
gyp ERR! stack SyntaxError: invalid syntax
gyp ERR! stack
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:294:12)
gyp ERR! stack     at ChildProcess.emit (events.js:189:13)
gyp ERR! stack     at maybeClose (internal/child_process.js:978:16)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:265:5)
gyp ERR! System Windows_NT 6.1.7601
gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild" "--release"
gyp ERR! cwd C:\Users\smarigowda\SAN\gitLab\wdioPOC\node_modules\fibers
gyp ERR! node -v v11.5.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
node-gyp exited with code: 1
Please make sure you are using a supported platform and node version. If you
would like to compile fibers on this machine please make sure you have setup your
build environment--
Windows + OS X instructions here: https://github.com/nodejs/node-gyp
Ubuntu users please run: sudo apt-get install g++ build-essential
RHEL users please run: yum install gcc-c++ and yum groupinstall 'Development Tools'
Alpine users please run: sudo apk add python make g++
'nodejs' is not recognized as an internal or external command,
operable program or batch file.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

This could be because of fibers please use node.js v10 for now


Add Faker::NHS - Support for the British National Health Service

Every person in the United Kingdom has a unique code which identifies them to the National Health Service (NHS). The code is in XXX XXX XXXX format where the final digit is a check digit calculated from the previous ones.
More information on NHS numbers can be found here: https://en.wikipedia.org/wiki/NHS_number
This commit adds the Faker::NHS class along with the Faker::NHS.nhs_number method to generate a valid NHS number.

It would be very nice to have nhs number included!

@maxehmookau Travis is red because of this test:
      8:   def test_nhs_british_number
      9:     sample = @tester.british_number
  => 10:     assert sample.length == 12
     11:     assert_equal ' ', sample[3]
     12:     assert_equal ' ', sample[7]
     13:     assert sample[0..2].split.map { :to_i }.all? { :is_digit? }

It seems that your algorithm fails when we run the tests in ruby 2.1.10 and 2.2.10 because it generates 13 characters instead of 12.

@vbrazo thanks for adding some basic docs!
That's very strange, glad you had CI running to catch that. I'll load up the older ruby version and try and resolve those failures soon.

No problem. I tested in the older versions and what I noticed was that it fails because the last digit that is being generated is 10 or 11, that's why we get 13 characters.

@maxehmookau  just a quick update: this commit removes 2.1.10 and 2.2.10.


add optional params for audio api, e.g. prompt

I found the prompt argument is useful in audio api, so added following optional args from official doc
https://platform.openai.com/docs/api-reference/audio/create :
Prompt      string // For translation, it should be in English
Temperature float32
Language    string // For translation, just do not use it. It seems "en" works, not confirmed...
btw.  I found there already exist a similar pull request from someone else.  I added this change in my local env last week,  today I've done some test works(for real env), so It's just a coincidence....
It is ok, that just close this pr, I just want the changes merged ASAP~

thank you for the PR! 🙌🏻


Update dependencies for 2.8.0

We have some packages to update on dashboard before we ship our next version.
We did get a PR from @pjbgf to do this but based on how our UI works, we need to split those updates into separate ones for easier work. https://github.com/rancher/dashboard/pull/9439 for reference

Note: We need to look at each in tern - not all can be done at this time.

yarn why would help understand the dependencies' own dependencies. yarn audit can help too.

I've updated those we can do given vue-cli and where where we are for this release (see confluence rancher / dashboard dependencies for a full write up). I'll make this in to an epic and split out the ones that are done

I've jigged around the target milestone given what we're committed to

Linking dependent issue https://github.com/rancher/dashboard/issues/7653. Until we bump vue (specifically vue-cli) we can't progress this. Moving to v2.8.next2 to check status of that vue3 migration in next release

Given the vue3 bump this can now be re-evaluated

I'm checking off loader-utils for the following reasons

This is a transitive dependency that is not explicitly declared as a dependency in dashboard
loader-utils is at 1.4.2  as of writing this comment

yarn why loader-utils

yarn why v1.22.19
[1/4] Why do we have the module "loader-utils"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Has been hoisted to "loader-utils"
info Reasons this module exists
   - "workspace-aggregator-7f68b920-9183-44c5-9a85-c1d73de0033e" depends on it
   - Hoisted from "_project_#cache-loader#loader-utils"
   - Hoisted from "_project_#js-yaml-loader#loader-utils"
   - Hoisted from "_project_#@vue#cli-service#vue-style-loader#loader-utils"
   - Hoisted from "_project_#@vue#cli-service#@vue#vue-loader-v15#loader-utils"
   - Hoisted from "_project_#@cypress#webpack-dev-server#html-webpack-plugin-4#loader-utils"
=> Found<EMAIL_ADDRESS>info This module exists because "_project_#csv-loader" depends on it.
=> Found<EMAIL_ADDRESS>info This module exists because "_project_#frontmatter-markdown-loader" depends on it.
=> Found<EMAIL_ADDRESS>info This module exists because "_project_#worker-loader" depends on it.
=> Found<EMAIL_ADDRESS>info This module exists because "_project_#@vue#cli-service#thread-loader" depends on it.
=> Found "<EMAIL_ADDRESS>info Reasons this module exists
   - "_project_#@rancher#components#@vue#cli-plugin-babel#babel-loader" depends on it
   - Hoisted from "_project_#@rancher#components#@vue#cli-plugin-babel#babel-loader#loader-utils"
=> Found "<EMAIL_ADDRESS>info Reasons this module exists
   - "_project_#@rancher#components#@vue#cli-plugin-typescript#babel-loader" depends on it
   - Hoisted from "_project_#@rancher#components#@vue#cli-plugin-typescript#babel-loader#loader-utils"
Done in 0.56s.

Marking word-wrap as completed. At this time, word-wrap is at 1.2.5. It is also a transitive dependency.
➤ yarn why word-wrap

yarn why v1.22.19
[1/4] Why do we have the module "word-wrap"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "_project_#eslint#optionator" depends on it
   - Hoisted from "_project_#eslint#optionator#word-wrap"
   - Hoisted from "_project_#browser-env#window#jsdom#escodegen#optionator#word-wrap"
info Disk size without dependencies: "24KB"
info Disk size with unique dependencies: "24KB"
info Disk size with transitive dependencies: "24KB"
info Number of shared dependencies: 0
Done in 0.62s.

Moving this to QA Review - all dependencies listed in the epic now satisfy their requirements.

nothing for QA to do here. moving to done


Problem with returning tab variables

Hi!
Recently I've encountered an issue with Vim 7.4.712 on Mac OSX Yosemite. It seems gettabvar() cannot read tab variables for the first time after Vim start and after :only (or <C-w>o) if there was an unlisted buffer and got closed. Here's how it behaves (and how to reproduce):
https://asciinema.org/a/emg1wb9ccmu72lhtoj62m8u6p
I can confirm the behavior with help buffer and :only command also on MacVim 7.4.769.
Interestingly, after first attempt (when the empty string is returned) the next call returns the variable value as expected.
Thanks in advance! And welcome to Github :)
s.

fixed with patch  7e47d1ac6a9 (7.4.834)

:+1:


Reimplement portal creating using React portals

So - https://reactjs.org/docs/portals.html#___gatsby

See #58 for why I don't think using the native React portals work for this component.

got you


internal/improve-build-process

Building the DSpace takes too long, check building process in the pom.xml and decide if building process could be faster.
Slack conversation where I asked how to improve building process:

Use
mvn install -Dmaven.compiler.compilerArgs=-Xpkginfo:always
to avoid useless recompilation. Will later add to .pom, possibly from upstream.
Explanation in our MS Teams.


Cannot reach KtxLoader after update to 1.10.1

Describe the bug
We are getting Unresolved reference: KtxLoader message after updating filament libs to 1.10.1
After downgrading only filament-utils-android to 1.10.0 - everything is ok
To Reproduce
Steps to reproduce the behavior:

import com.google.android.filament:filament-utils-android:1.10.1
compileDebugKotlin shows Unresolved reference: KtxLoader

Expected behavior
Application should compile

KtxLoader was renamed KTXLoader to be more consistent with other APIs.


build(semantic-release): adjust config

Coverage remained the same at 100.0% when pulling bcd6733641129657c107ff4783cb9ea4b8e08c95 on build-adjust-semantic-release-config into 7bbe8ce6425c2877cfb6636679682ff4511d01d5 on main.

:tada: This PR is included in version 1.0.10 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Handle null/not-present attributes at the "root" level

What are you trying to accomplish?

Fix the issue with null handling of the root objects

What approach did you choose and why?
The bug was in the way how non-existing attributes were handled:
object with value null in the root was marked as non-existing, that's why exceptions were raised.
Cel-go returns 2 parameters with object (which could be nil) and found:
obj, found := vars.ResolveName(nm) link to original code
I've used existing Pair generic class as Pair<Object, Boolean> to imitate the same behaviour as in Go.
Now resolveName for MapAttribute implementation checks that map contains the key, even if obj is null it will be returned as an existing one:
public Pair<Object, Boolean> resolveName(String name) {
      if (!bindings.containsKey(name)) {
        return new Pair<>(null, false);
      }
      Object obj = bindings.get(name);

      if (obj instanceof Supplier) {
        obj = ((Supplier) obj).get();
        bindings.put(name, obj);
      }
      return new Pair<>(obj, true);
    }

Another approach was throwing noSuchAttributeException, but due to many usages and required try catches wrappers code became less readable, so this approach was declined.
Unit tests that covers desired behaviour were added.
These changes are not breaking existing Interpreter UnitTests.
Fixes #360

Can you sign the CLA?
And revert the 2nd commit - that's all handled during releases.

Changes LGTM. If you guys are okay with it, i can go ahead and merge it and get a new release out.

I'm fine with the changes too @snazy ! I was just wondering if we could not use Optional<Object> instead of the newly defined type: https://github.com/projectnessie/cel-java/pull/368#discussion_r1166789454.

So with this change, how should a FunctionActivation provider indicate that it doesn't know how to resolve a name?  Should we change FunctionActivation(Function<String, Object> provider) to FunctionActivation(Function<String, ResolvedValue> provider) or have some other magic return value from the provider to indicate "absent" or "null"?

So with this change, how should a FunctionActivation provider indicate that it doesn't know how to resolve a name? Should we change FunctionActivation(Function<String, Object> provider) to FunctionActivation(Function<String, ResolvedValue> provider) or have some other magic return value from the provider to indicate "absent" or "null"?

That's a good question. I see 3 different scenarios how it could be handled:

Right now, if provider.apply result is null - it will raise an Exception (the same as it was before logic change)
As you've proposed, we can allow users to set desired value explicitly as ResolvedValue instead of Object and change provider signature to Function<String, ResolvedValue>, but it could cause unforeseen consequences for existing users, that were already sending ``Function<String, Object>`
WDYT about implicit implementation of FunctionActivation with considering null values? Like this one:

/** ResolveName implements the Activation interface method. */
    @Override
    public ResolvedValue resolveName(String name) {
      Object activatedValue = provider.apply(name);
      if (activatedValue == null) {
        return ResolvedValue.NULL_VALUE;
      } else {
        return ResolvedValue.resolvedValue(activatedValue);
      }
    }

That seems reasonable, but would a function provider need to differentiate between null and absent? Currently my code does this by returning null to indicate absent, and NullT.NullValue to indicate it was actually a null value.

That seems reasonable, but would a function provider need to differentiate between null and absent? Currently my code does this by returning null to indicate absent, and NullT.NullValue to indicate it was actually a null value.

Yeah, in this case only approach with provider signature change to Function<String, ResolvedValue> will work, otherwise null will be indicating both absent and null.

Changing the function signature doesn't seem like too big of a concern since this project is pre-1.0.  What do you think @snazy ?
2 possible alternatives:
    @Override
    public ResolvedValue resolveName(String name) {
      Object activatedValue = provider.apply(name);
      if (activatedValue instanceof ResovedValue resolvedValue) {
        return resolvedValue;
      } else {
        return ResolvedValue.resolvedValue(activatedValue);
      }
    }

Or we could make another ResolvedFunctionActivation or something that takes a Function<String, ResolvedValue ?

I put out a proposed fix in #382


Allow more retries on errors in density test

Such failures are happening frequently while running performance tests on Jenkins.

lgtm


fix #841

use $.fn.focus instead of HTMLElement.prototype.focus
for more info see: https://github.com/Dogfalo/materialize/issues/2688

lgtm
Can you rebase the PR on the current master branch?

@DanielRuf please, check #1053


Accept callback based on position

Right now I can create an accept callback like "do you (parent node) accept this node as new child node?".
Since I use several tree node types that should stay grouped I would like the access callback to be called every time the placeholder moves (not only when the placeholder’s parent node changes, but also when it’s position changes) and make an accept filter like "Is it allowed to put this node between this and that node.
I think some users did not immediately understand the meaning of the destIndex parameter (like me) and thus posted related issues.
Thanks you for sharing this cool tool!

Closing this issue due to inactivity. See #815 for more information.
Please create a new issue is this still occurs with the current version of the component.


Interference with embedded Google Maps CSS?

When I tried to embed a Google Map using the Google Maps JavaScript API v3, the street view "pegman" doesn't display correctly. Additionally, markers are "smashed" into tiny versions of the original.
Anyone else notice this? I've been migrating my web app to Foundation and just got to the point where I'm porting over Google maps... already about 90% completed before running into this. (awesome "foundation" so far, love it).
The exact same maps code, running on the live version of my site, loads the maps fine. It's when I port it to Foundation that the issue arises.

Found it, line 71 in grid.css : img, object, embed { max-width: 100%; height: auto; }
Interferes with embedded Google Maps styling (which breaks the street view control, and viewing the streetview in the map, among a few other things).

In this case I guess a best approach would be to overwrite that for the particular map right?
.yourclass {
your-property: your-value !important;
}

Hmm... it's not a rule in my (our) own CSS. It's coming from Google via their Javascript API (v3).

The fix suggested by smileyj68 resolved my problem. Thanks!

Baller.

Just FYI - The same line in grid.css causes Flowplayer's player (object element) to be hidden. Overriding it's height property fixes the problem.


BT-661 (lot) fields.json and schema are in conflict

BT-661 (lot) is defined as indicator type in the fields.json
ref: https://github.com/OP-TED/eForms-SDK/blob/develop/fields/fields.json#L16670-L16690
But in the schema this property is defined as TextType array
https://github.com/OP-TED/eForms-SDK/blob/develop/schemas/maindoc/UBL-ContractAwardNotice-2.3.xsd#L61
https://github.com/OP-TED/eForms-SDK/blob/develop/schemas/common/UBL-CommonAggregateComponents-2.3.xsd#L4999-L5001
https://github.com/OP-TED/eForms-SDK/blob/develop/schemas/common/UBL-CommonAggregateComponents-2.3.xsd#L2221 (array  minOccurs="0" maxOccurs="unbounded" )
and finally limit description is defined as text type:
https://github.com/OP-TED/eForms-SDK/blob/develop/schemas/common/UBL-CommonBasicComponents-2.3.xsd#L3551-L3555
We were expecting this field to be indicator type in XSD

Also BT-14 is defined as indicator but is referencing text type
https://github.com/OP-TED/eForms-SDK/blob/develop/fields/fields.json#L3510-L3529
shouldn't this field be code type?

I found out there is document describing this weird behavior: https://simap.ted.europa.eu/documents/10184/320101/eForms+regulation+vs+Schemas_2/8209153c-9541-4672-9c89-25891137744c
It would be nice to have these documented to the SDK somehow

There are indeed differences between the Implementing Regulation and the UBL Standard; these have been addressed and integrated into the SDK while considering the requirements imposed by both.
Information also exists in the documentation, if you however consider that some information should be added to the SDK, I then recommend that you preferably develop and share this idea in the discussion channel. Clearly stating the expectations (e.g. format, purpose ...) would increase the probability to have it considered and integrated.
I also close this (non-)issue.
KR


Unnecessary drag / pan responder

Is there any real reason why index.js contains a custom handler for when a user pan / drags / swipes a view in the Navigator?
The following is found in index.js line 110 and on.
    var didStartDrag = function(evt) {
      var x = evt.nativeEvent.pageX;
      if (x < 28) {
        this.setState({
          dragStartX: x,
          didSwitchView: false
        });
        return true;
      }
    }.bind(this);

    // Recognize swipe back gesture for navigation
    var didMoveFinger = function(evt) {
      var draggedAway = ((evt.nativeEvent.pageX - this.state.dragStartX) > 30);
      if (!this.state.didSwitchView && draggedAway) {
        this.onBack(navigator);
        this.setState({ didSwitchView: true });
      }
    }.bind(this);

The above code is completely unnecessary, since the Navigator itself handles the gestures through it's scene configurator. Is there a real reason to why the code is present or should I post a pull request to get rid of it?
To prove my hypotheses I've tried to disable the code without breaking any function. Please test more cases to check to see that I'm not mistaking.

This was added by @t4t5 in the original version of the module. I always assumed it was to just detect a swipe back, but if that is already handled by navigator, we can remove it.


Add the UnQlite NoSQL DB

Hi,
This commit add the UnQlite NoSQL DB to the list of DBs. It's released under the 2-Clause BSD license. For more info, please, refer to: https://unqlite.org/ for more infos.
Thanks,
Luca

What is the performance? (quite brave to put yourself before Mark Logic)

I didn't find any official benchmarks. Here is someone that made the same question.

You can check https://github.com/pmwkaa/ioarena UnQlite is listed there

Cool. But I have no time to build and run the results...

@adamansky thanks. In the list of supported dbs, on the root README.md, unqlite is missing:

Supported databases: rocksdb, leveldb, forestdb, upscaledb, lmdb, mdbx, wiredtiger, sophia, sqlite3, iowow


[Bug]: <IP_ADDRESS> is responding 404 which makes the package unreliable

Desctibe the bug
having internet connection but package will result a "no connection" because of a failure check of <IP_ADDRESS>
Reproduction steps
just the package as usual
Expected behaviour
Should return true for isConnected
Flutter version
latest
Package version
3.0.0
What platform are you seeing the problem on?
Android
Relevant log output
no logs.

Hi @totzk9
Thank you for the posted issue. I have checked the address <IP_ADDRESS> and after my ping it seems to be responding correctly. I also see that connecteo uses two other IPs as a backup.
Can you confirm this problem is still present on your side. Maybe you used VPN or other packets loss happened.

Interesting. Had to review the package code and found return connectionResults.any((result) => result); which means it returns true if one of the three is reachable.
Apologies of my misunderstanding. Though what's weird is I still get a false value from the 3 IPs but returns true when checking for baseUrlLookupAddress
Anyway, we can close the issue. Thank you!


builder: unable to restart builder if cedarish fails to download

I think this is also related to having a cached image with a broken cedarish.tar.gz.
https://github.com/deis/deis/blob/master/builder/image/bin/boot#L66

I'm not quite sure how it fails to download. It's bundled in the builder image. Could you please post some logs so we can better understand the issue?
https://github.com/deis/deis/blob/master/builder/image/Dockerfile#L44-L47

Hi, @bacongobbler. We're using our own cedarish and we've noticed when building deis-builder, while it was able to download the cedarish image archive successfully, docker load was unable to extract the cedarish image and failed silently.
I'll see if I could fix the problem by rebuilding our cedarish archive and rebuilding deis-builder.

We're using our own cedarish and we've noticed when building deis-builder, while it was able to download the cedarish image archive successfully, docker load was unable to extract the cedarish image and failed silently.

@aledbf Didn't you also mention something similar for https://github.com/deis/deis/pull/2915#discussion_r23255260 ? @bacongobbler perhaps we're not using the cedarish we're loading as we thought...

@carmstrong the issue in the comment is that the progrium in the tgz is not the same to progrium/cedarish:latest or any other published tag:
progrium/cedarish                    latest                  63dae3c23c6d        8 days ago          984.5 MB
progrium/cedarish                    cedar                   7cac39834d95        8 days ago          843.3 MB
progrium/cedarish                    cedar14                 e030ae9b1977        8 days ago          984.5 MB
progrium_cedarish.tar.gz             latest                  4b458f40de0a        6 weeks ago         995 MB

woah... it shouldn't be loading as progrium_cedarish.tar.gz. I'll look into it.

@bacongobbler I tagged 4b458f40de0a  as progrium_cedarish.tar.gz. The thing is that the image ids are different.

Oh, okay. That's intentional. It's supposed to be an archived version of cedarish based on the date that it was archived, hence why https://github.com/deis/deis/blob/master/builder/image/Dockerfile#L47 has 2014_12_15 tagged onto the end here. That image is then unpacked before we build deis/slugbuilder and deis/slugrunner so that they are using the archived version of cedarish. That way, we don't have to rely so much on the network during builder boot time to build the images.
Anyways, let's keep that discussion over there since it's getting a little off topic from @ngpestelos's issue. :)

@ngpestelos just as a note, we archive/ship the default tarball with make -C builder cedarish/build so you can take a look there for pointers :)

Thanks, @bacongobbler :+1:

We reviewed progrium's previous commits on cedarish and saw this: https://github.com/progrium/cedarish/commit/f7b704c825e7982ae8efef4193436c902477c650
Part of the refactoring effort changed the way the image is tagged, so our deis-builder is looking for a image tagged differently (i.e., cedar14-build vs <our-fork>/cedarish).


wineUnstable: fix wine-mono version 6.4.0 -> 7.0.0

Motivation for this change
Currently, Wine 6.22 cannot automatically find Mono (when using embedInstallers = true), apparently because the expected version of wine-mono is hardcoded in wine. See similar older issue https://github.com/NixOS/nixpkgs/issues/78309. According to https://wiki.winehq.org/Mono it should be wine-mono-7.0.0 for wine-6.22. I've checked that after updating wine-mono to 7.0.0 wine can automatically find and use it.
This should not conflict with latest version bump https://github.com/NixOS/nixpkgs/pull/148683 because wine-6.23 also expects wine-mono-7.0.0 (cc @SFrijters).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Ah, good catch. Normally I look in the changelog for this but this time I was too focused on waiting for the wine-staging tag to be added. Would be nice to test this in some way, but I have no idea how.

Result of nixpkgs-review pr 148986 run on x86_64-linux 1

7 packages built:

pipelight
wine-staging (winePackages.stagingFull)
wine64Packages.stagingFull
wine64Packages.unstableFull
winePackages.unstableFull
wineWowPackages.stagingFull
wineWowPackages.unstableFull

Superseded by (and included in) #150221


Vulkan fixes for macOS

Nice! I got the idea. Thank you a ton! Merging...

A few questions (doing it locally):

VK_KHR_portability_subset =>VK_KHR_PORTABILITY_SUBSET_EXTENSION_NAME (inclusion of vulkan_beta.h was missing)
VK_KHR_dynamic_rendering => VK_KHR_DYNAMIC_RENDERING_EXTENSION_NAME

OK? Looks like no harm :)

Probably fine.


[WIP] Bidirectional branching

Summary of changes
This is a proof-of-concept PR to demonstrate bidirectional branching support in the line diagram rendered next to the stop information.
The main conceptual change here is adjusting branchingOutward from being a page/line-global decision to a per-stop calculation based on the surrounding data in the stops list. I've tried to keep the rest of the code as unmodified as possible to focus on this, though there are definitely some areas to clean up. The only other changes were things that were broken when a branch was small enough not to have collapsed stops.
As it stands, it works for the data that I've been testing with (which is included in the diff), though I would hesitate to call this "complete" as the code still feels pretty edgy and would definitely like to test this with real(er?) data. I've experimented with moving the test branch around in the stop list and things appear to work properly, and other lines render properly as well.

I'm not sure about how well it would handle infinite branches on branches in any directions

I think it would not work at all :)

We're still missing the backend piece, which is crucial as it supplies the frontend with the stop information

Ah I see, I didn't realize that the backend needed any special handling for the directions of the branching.

For what it's worth I still think a longer-term solution to getting the branching "right" is to use a different data representation for the stops, as the flat list quickly becomes tricky to work with and understand for more complex cases.

Ah I see, I didn't realize that the backend needed any special handling for the directions of the branching.

Well, it's more like, we can't automatically expect North Station to have the expected :merge values in its stop_data. Maybe.
We now more or less tell the Green line branches how to coincide/overlap, and that logic probably needs adjusting to tell it run the N Station - Union & N Station - Medford branches to be side-by-side (by specifying the correct stop_data) AND have the prior B/C/D branches on the other end work as expected, within in the same list of stops.
As of now there's a fair amount of manual fiddling (overriding the logic and just hard-coding what each stop should do) for the northern bits of the Green line. Which itself could use improving or replacing.

Closing because I'm finally adding Asana tickets to carry this out, thank you!


cursor render incorrect

Hyprland Version
0.31.0
Bug or Regression?
Bug
Description
Open https://jedsek.xyz in firefox, which will change the cursor style, then switch workspace to move focus to alacritty(or wezterm).
Cursor style does not return to normal.
How to reproduce
See video
Crash reports, logs, images, videos
https://github.com/hyprwm/Hyprland/assets/63626406/b1886c2d-8c99-4974-9869-ebd60f391afd
hx.log

you are on an old commit, please test on -git.
IIRC this was fixed, and I can't repro either.

I apologize for the ping; I copied the wrong issue number :sob:


Use async (gevent) gunicorn workers

Settings are as per http://docs.gunicorn.org/en/stable/settings.html.

Codecov Report

Merging #462 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #462   +/-   ##
========================================
  Coverage    96.28%   96.28%
========================================
  Files          108      108
  Lines         3259     3259
  Branches       291      291
========================================
  Hits          3138     3138
  Misses          84       84
  Partials        37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f82439...1f26218. Read the comment docs.


[T4A6][T09-B4] Zachary

Some comments added. Feel free to comment if you have any questions. Once done, you may the PR after reading comments.


AI panel: auto open last chat room

Memorizes last opened chat room using local storage, and opens it when opening the AI panel. If there is no chat room id found in local storage, then it opens the most recently joined room.

Fixing tests...


How do I delete MyData Cleccetions

Hi
How do I delete (a) entire collections or (b) remove specific files from collections.?
REMOVE SPECIFIC FILES
When I select a single file under the Select Subset of Document(s) for Chat with Collection: MyData section

and select the Deleted Selected Sources from the DB I get the error:

REMOVE ENTIRE COLLECTIONS
How can I delete an entire collection (made up of several files)?

Note: I have uploaded for files four text files each about 80KB only.

The first issue is probably due to a chromadb change, will look.
The second issue is achieved by adding the collection  name to "Purge Collection".  That deletes from UI, DB, and source files as it says.

@pseudotensor thanks for your response.
With regards to the second point/question, I added what I considered the collection name and pressed “purge collection” option. But I do not see the files deleted. I’m not sure what message I should get to inform me the connection has been deleted.
Based on the screenshot I have provided can you kindly identify for me what is the “collection” name in my situation? Also, what should I see which confirms the data has been deleted.
Thanks again.

I am now getting the same/similar error when trying to delete the entire collection. I determined that my  collection's name was "MyData". Furthermore, I worked out the way to delete a collection was to type in the name of my collection in the Purge Collection (UI, DB, & source files) field and then hit ENTER (previously I was incorrectly clicking on Update DB with new/changed files on disk). When I hit ENTER I get the below error:

I then have to log back in, after which the my collection is still there (i.e. not deleted):


Not removing song lyrics in star sign

Input Before:
853
00:40:14,010 --> 00:40:15,080
Aah!
854
00:40:15,110 --> 00:40:18,580

she walked up to me
and she asked me to dance *

855
00:40:18,610 --> 00:40:20,050

I asked her her name

856
00:40:20,080 --> 00:40:23,220

and in a dark brown voice
she said Lola *

857
00:40:23,250 --> 00:40:26,090
I told you you shouldn't
have shot my friend.
858
00:40:26,120 --> 00:40:30,090
Oh, by the way, your fly's
been down the whole time.
After:
791
00:40:14,010 --> 00:40:15,080
Aah!
792
00:40:18,610 --> 00:40:20,050
* I asked her her name
793
00:40:23,250 --> 00:40:26,090
I told you you shouldn't
have shot my friend.
794
00:40:26,120 --> 00:40:30,090
Oh, by the way, your fly's
been down the whole time.
As you see it not removed the single song lyrics line "I asked her her name"
Please fix that it delete single lines with star sign * which basically means song lyrics as well.
Thank you.

@seadogro would you be so kind as to wrap the examples in code blocks?
Also: I'm not sure that song lyrics are always a thing to be removed, sometimes it's crucial to the plot and the singers don't sing very clearly

@seadogro would you be so kind as to wrap the examples in code blocks? Also: I'm not sure that song lyrics are always a thing to be removed, sometimes it's crucial to the plot and the singers don't sing very clearly
not working. Here on pastebin:
https://pastebin.com/UUyuSCBW


Add logical-version field version to the manifest schema

Add an optional logical-version field to the manifest schema. The new field can be used to provide a short human-readable information about the version of the manifest

@jmesnil could you review this please?


bug: produced package-lock may be incompatible with npm v7

npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile
npm WARN audit 400 Bad Request - POST https://registry.npmjs.org/-/npm/v1/security/audits/quick - Bad Request
{
  statusCode: 400,
  error: 'Bad Request',
  message: 'Invalid package tree, run  npm install  to rebuild your package-lock.json'
}

Related to https://github.com/imsnif/synp/issues/74