Do not consider nested comment as part of code

Summary
When there are nested comments, the old logic was to remove the comment prefix and check if now the content is code or not. This would mean that the remaining content would itself be a comment and when parse is called on that, it'll succeed.
# # This is a nested comment

After removing the '#' prefix
# This is a nested comment

Now, this is a valid Python code even though it's just a comment. This means that the function comment_contains_code returned true, triggering the warning in the linked issue.
fixes: #3980

I've randomly checked the changes detected by the ecosystem checks and they all are false positive. I wonder if there are others like that present (https://github.com/charliermarsh/ruff/pull/3878#issuecomment-1496400907) and how to find them.
Also, I guess if it's possible to create links for all the detected ecosystem changes in the diff itself, it would help in navigating to the source code quickly.

The ecosystem could also show the source directly.

The ecosystem could also show the source directly.

I guess GitHub would take care of it automatically when using permanent links. Either way, the output will be pretty large (take this PR as an example).

(Great idea.)

(Great idea.)

Thanks! :)


⚠ ClamAV has degraded performance

In 719bac7, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 84 ms

Resolved: ClamAV performance has improved in 445d918.


[WIP] - Bump @opentelemetry/api to 0.20.0

Now that opentelemetry/api has ESM support, could we remove the commonjs workaround? https://github.com/Azure/azure-sdk-for-js/blob/2089881a3ab785ba51c43f683a70f5efb4d5f432/common/tools/dev-tool/src/config/rollup.base.config.ts#L27

I'll be closing this as we have changed our migration strategy here. Another draft will be incoming shortly


Some experiments to improve signatures

Work in progress. Again not final version. Some experiments to improve signatures after experience with Flow

Can you explain a bit more about what you're trying to improve? Also, are these breaking changes?

Can you explain a bit more about what you're trying to improve?

I added comments in test files, like:
+ // checks third argument

This is what I changed. But I can write this list explicitly - small change log.

Also, are these breaking changes?

It is not breaking, but if people have some type errors which were unnoticed before they will become visible, so this can be perceived as breaking changes by some users

Changelog:

use opaque type for dispatch and getState, to make sure people use exactly those values, not other symbols
add intersection with functions to dispatch and getState, so they would work in cases like this Cmd.run(dispatchNoop, { args: [Cmd.dispatch] }), so dispatchNoop would know what params would be passed to it
Add return type to CmdSimulation, so simulate function is aware about type of result type
Add more types to Cmd.run, so know it makes sure that return value of the side-effect has the same type as input of successActionCreator
Add more types to Cmd.run, so it checks that args fits as input for the side-effect function

Good enough? I'm ready to add more information is needed

these all seem like good ideas. thanks!

Any update on this?
Adding types to ensure the args passed to the function of Cmd.Run() would be helpful.
function foo(a: string) {}

Cmd.run(
  foo, {
    args: ["bar"]
  }
)

@stereobooster are you still interested in making these changes? Do they conflict with #192 ?


Add not dismissible for Popover

Resolves #2505

Great suggestions, but i still not sure if Not dismissible title for the story is good 🤔

Great suggestions, but still, I'm not sure if Not dismissible title for the story is good 🤔

I guess we are trying to convey and example of how you can work use interactive components inside the popover. Much like the "review PR" popup on github. So maybe something along the line of; Interactive content or form inside?

I guess we are trying to convey and example of how you can work use interactive components inside the popover. Much like the "review PR" popup on github. So maybe something along the line of; Interactive content or form inside?

Yes or maybe persistent popover

Something to look into Popover or just add style?

Something to look into Popover or just add style?
If adding padding-bottom to PopoverContetnt, that sorts the problem:
Wouldn’t that be accrue with Figma? 🤔

how does the actual html and css look like? The InnerWrapper has a gap which should solve the spacing between content and actions sub-components.

how does the actual html and css look like? The InnerWrapper has a gap which should solve the spacing between content and actions sub-components.

InnerWrapper has grid-gap, but it looks like the missing part of autocomplete is under the gap.

It is because popover.content have overflow hidden, so the outline around the input gets clipped (because the gap counts as outside the container)


Declared init method in header file to allow instantiation without using the singleton.

Singletons are believed by many people to be a bad pattern. Currently there is no way to instantiate an instance of NBPhoneNumberUtil without using the singleton sharedInstance class method because the init method is not declared in the header file.
I cannot see any reason not to have this method public - it does not prevent anyone from using the shared instances and allows those of us who do not wish to do so to use the init method.

Agree.
But NBPhoneNumberUtil library has a lot of memory consumption.
So, 'init' method will be 'public' after metadata optimization.
Thank you for your issue.

It may have a high memory consumption, but accessing it as a singleton does not in any way reduce that memory consumption - on the contrary it potentially prevents reclaiming unused memory. Presumably you are concerned with programmers making several instances of it and thereby having increased memory consumption. That would be a problem only if they were instantiating and never releasing them or if instantiating the object itself is particularly resource intensive, but in all cases, discretion for that should rest with the programmer to do as appropriate.
On the contrary, forcing instantiation as a singleton forces the object to exist for the entire life-time of the app - the programmer has no way to release it and release the resources associated with it when he no longer has any need for it, thereby consuming more memory than needed.
If people wish to use a singleton object (despite the bad practice) then it is no problem to have the singleton methods as convenience methods, giving the programmer the choice, but there is no valid reason to not expose the initialisation method.
I would ask you therefore to reconsider, thereby avoiding the need for me to maintain a fork.

OK I see

Thanks for that. Will this be part of a new version tag or should I point my Podfile to HEAD?

It will update on 2014-01-18.

Hi - just checking back - it doesn't look like a new tag (and pod spec) has been done for this yet - is this still going to be happening? Thanks.

Hi
Added it. ( Sorry for late )
Thanks.
On Tue, Jan 20, 2015 at 3:40 AM, Rupert-RR<EMAIL_ADDRESS>wrote:

Hi - just checking back - it doesn't look like a new tag (and pod spec)
has been done for this yet - is this still going to be happening? Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/iziz/libPhoneNumber-iOS/pull/40#issuecomment-70540567
.

--
from zen<EMAIL_ADDRESS>http://about.me/ishtar
SungMin Ha (ishtar)
[image: http://]about.me/ishtar
http://about.me/ishtar

And the pod spec?

Ah, maybe later :)That will works fine with "Podfile"
Thanks.
—
Sent from Mailbox
On Tue, Jan 20, 2015 at 5:48 PM, Rupert-RR<EMAIL_ADDRESS>wrote:

And the pod spec?
Reply to this email directly or view it on GitHub:
https://github.com/iziz/libPhoneNumber-iOS/pull/40#issuecomment-70621696

Ok, yes that's working fine.
Thanks.


edit code in docs/basics/UsingSagaHelpers.md

fix code
import { takeEvery } from 'redux-saga'
to
import { takeEvery } from 'redux-saga/effects'

Thanks!


fix(feat): strip comments during the parsing of crs-setup.conf.example

This PR modifies the rules-check.py script that during the parsing of the crs-setup.conf.example it removes the comments before SecRule and SecAction directives. This means it emulates that rules are valid part of CRS, and - for eg. - therefore it does not need to initialize the TX variables.
The next PR will contain the modification which removes the rules 901167 and 901169 from REQUEST-901-INITIALIZATION.conf, therefore the tx.enforce_bodyproc_urlencoded and tx.crs_validate_utf8_encoding variables are no longer initialized.

Thanks guys for your comments, @theseion, @fzipi.

@fzipi, there are three unresolved conversations - is there anything what I can explain better?

Thank you for this welcome workaround. Really appreciated and a good step forward. Talking things through, often again and again, really helps.


Fargate Deployment issue and resolution

Hi Team,
This is to inform you about updating cloudformation template for Fargate. It was failing as it was unable to create S3 buckets due to the recent policy changes in S3 bucket. Adding below two lines to override the default behaviour helped me. We need to change it twice in the template as two buckets are being created.
Same issue for Webclient Template as well.

hi @nagarjuna-jammula
Even after editing this the stack isnt created. did you do any other changes apart from this?

Hi Dharsdi,
I don't remember any other changes but i can check if you can provide me with error info / screenshot.
P.S: We have decided to go for alternative option as we don't get proper support for this project ( there was no response for my queries) and there are lot of security vulnerabilities too.


I see some test parameters as well which are not required in the github summeries

Attached the snapshot of the summary :
It has some unnecessary data -bddData, no idea how to remove it

Fixed with showAnnotation: false
Thanks


React tutorial-Todo App

Todo-App Project
In this project I:

create react Todo App
Added todo app functionality
Implement Add todo
Implement editing and delete todo
Implement a check button functionality
create navbar and add functionality using react routes

Hello @baqar-abbas, I fixed the broken link of the License


RGTC1 and RGTC2 compression is broken

RGTC1 and RGTC2 (unsigned) compression is broken. It produces a segfault in the final compare function.

Fixed in v0.9.1.


Initialized new wagtail project, static files not loading.

I've gone through the whole set up process, got postgres working, can run the dev server, but none of the style sheets are loading.
I'm attempting to run wagtail on an ubuntu server proxy-passed behind nginx. The site shows up just fine, but if I look in the console there are a few "could not load resource errors"
Failed to load resource: the server responded with a status of 404 (Not Found)
mydomain.com/static/CACHE/css/myproject.d41d8cd98f00.css

Hi @allthetime
Please could you ask this on our Google Group? https://groups.google.com/forum/#!forum/wagtail
Github is mainly for bug reports/feature requests. General support is usually done on the Google Group.
Thanks


mappedsuperclass support

@brettwooldridge @lfbayer during migration i found out that there are a lot of MappedSuperclasses in our codebase. here's (initial?) support for it. tests included

also could you guys publish a new build after that PR is closed? this is the last showstopper to complete project migration :)

@brettwooldridge ? @lfbayer ? anyone? :)

Looks good, thanks!

cool. @lfbayer could you publish a new build?

I'm in the process of trying to remember the magic mvn incantation now.

mvn deploy?

@lfbayer also i'd suggest you to squash PRs instead of merging next time, otherwise main repo history is a bit messed up now :(

2.7 is now published. It may take a while before maven central is synced from the sonatype repository.

@lfbayer thanks! don't forget to update README.md :)

Well that's tedious, it'd be nice if that automatically updated. Since we already have the little maven badge in the readme, it makes me wonder if the maven snippet is even necessary.

well, agree. there's maven tag RELEASE which always points to the latest one, but that's not very reliable (nowadays i try to stick to specific versions). maybe just put a link to the central repo.

@brettwooldridge how long it usually takes to sync to main repo? other than that i'd suggest to start writing changes history. i could start if others are busy but i don't know how to do that :)

@sergiorussia If you set sonatype as one of your repositories, or even as your primary repository with central being a fallback, then releases are "immediately" visible after publication-- typically within one minute.
<repository>
   <id>oss-sonatype</id>
   <name>oss-sonatype</name>
   <url>https://oss.sonatype.org/content/repositories/releases/</url>
</repository>


Fixes to UX bugs in Nord colour scheme.

Fixed UX bug on prompts not showing up due to foreground colour being too close to default.
Also... reworked the theme slightly so uses the more canonical Nord palette generally. Much nicer.

Coverage remained the same at 59.168% when pulling 57e6c34e83db7c625f973a8481ff103fafbd8311 on wakatara:master into 2f9254aeab62d29045ef81a71bb7a7d45abf8690 on newsboat:master.

Thank you!


__makeEvents__ defined but it's value is never read

Description
I have no defined events in the backend, so __makeEvents__ is not used.
The problem is that when building the application with tsc it fails throwing the following:

Desired solution
Adding a // @ts-nocheck at the top of the generated file will be sufficient, and even maybe add eslint ignore comments as well.
Environment info

tauri-specta: 2.0.0-rc.5
tsc: 5.4.2

Given we can't account for all different configurations and tools we allow the user to define their own header for the file.
You can do the following:
let builder = ts::builder()
            .commands(...)
            .header("// @ts-nocheck\n"); // <- This this appended to the start of the file

As of the current release you will need a \n to ensure it doesn't end up on the same line as the first line of Tauri Specta's runtime however I have fixed that for the next release.

I've also added a section to the v2 docs because it was definitely unclear how to solve this before.


Replace IIEFs with returns in AST leafs

The Go codegen in Oden is very simple right now and produces IIEFs to get if expressions out of if statements in Go.
if true then "Yes" else "No"

Gives the Go output:
(func() string {
	if true {
		return "Yes"
	} else {
		return "No"
	}
})()

By walking the AST and finding the leaf nodes this could be converted to more efficient and idiomatic Go code, e.g:
if true {
	return "Yes"
} else {
	return "No"
}

The trickier part is of course nested expressions. The Oden code:
if true then (if false then "Yes" else "Maybe") else "No"

Should compile to:
if true {
	// Notice the lack of "return" before this "expression" (because it's a statement in Go)
	if false {
		return "Yes"
	} else {
		return "Maybe"
	}
} else {
	return "No"
}

Probably this would be a nice timing for introducing an intermediate AST for Go code instead of directly converting it to Text.PrettyPrint docs.

Idiomatic code generation is the exact thing in trying to do in a side project. An intermediate language that can special case many of these things is the solution I've arrived at as well.

:+1:
I think the Go AST should be done regardless of this specific transformation, as a sanity thing.

Now working on Go AST: #84


Added feature - conf.d files from templates

If "datadog_conf_d_files" is defined, expect a list of template files to be deployed to /etc/dd-agent/conf.d/
This allows using data dog plugins
Tested on CentOS 6, should work identically in Debian systems

LGTM. Let me test it a bit, then I'll merge.
Thanks!

ping?

I wonder if it would be better to move this new code into main.ml

Hi @smcavoy-b, thanks for contributing! Sorry for not getting back to you earlier.
The repo has changed quite a lot since you opened this PR (it's been merged with a fork that added a few features), and this feature has been implemented with the datadog_checks variable, so I'm going to close this PR. Thanks again!


Issue: #24, wrapping is done by dict.update

Issue: #24, Not to call field's setattr function which do validations, we just update dict. As validation checks are not issued, this speeds up fetching rows from DB

Thanks for your pull request! Seems that wercker needs attention again regarding the RethinkDB service...I'll look into that as soon as I'll have time. After that, if build passes, I'll merge your pull request.


Import dict rather than sequence? e.g. Instance(store, module, {"env": Memory(store, MemoryType(Limits(5, 5)))})

Why is the import in Instance defined as "imports: Sequence[AsExtern]" rather than a dict? So instead of having (import "" "hello") in hello.wat, I can have (import "env" "hello"). This would make the import more organized.
(Although linker make use of that first slot in the import, in my understanding it's more like for linking two .wat file files, rather than organizing the imports? Or am I just not understanding how linker works. Please let me know :) )
Thanks!

Yeah for this it's recommended to use Linker since that does name-based resolution for host functions. Would that work for your use case?

Thanks Alex. I see. Previously my understanding is that for Linker to be used, there must be another module to import. But I only want to give it a different name for clarity of the code. But I can take a closer look at the code.

Ah yes you can also use define_func to add host functions into a Linker too

Hi Alex. Thanks for your reply. I will take a look at it. I have a follow up question regarding import. I want to import a function with no input parameters. However the code below seems to indicate that the input parameters cannot be none. And The ValType doesn't seem to have a "None" type either. Thanks!
class FuncType(Managed["ctypes._Pointer[ffi.wasm_functype_t]"]):
    def __init__(self, params: List[ValType], results: List[ValType]):
        for param in params:
            if not isinstance(param, ValType):
                raise TypeError("expected ValType")
        for result in results:
            if not isinstance(result, ValType):
                raise TypeError("expected ValType")


feat(create-cloudflare): allows user going back to the project name prompt

What this PR solves / how to test
Fixes N/A
This PR adds the ability to go back to the project name prompt, mainly to give users an idea that they can always come back to the previous question when answering the prompt early on.

Author has addressed the following

Tests

[ ] TODO (before merge)
[x] Tests included
[ ] Tests not necessary because:

E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)

[ ] I don't know
[ ] Required
[x] Not required because: no other impact

Changeset (Changeset guidelines)

[ ] TODO (before merge)
[x] Changeset included
[ ] Changeset not necessary because:

Public documentation

[ ] TODO (before merge)
[ ] Cloudflare docs PR(s):
[x] Documentation not necessary because: ux improvement only

I am not sure if this should be consider a feat of fix 🤔

lgtm


Azure Pipeline Fail with 8.10 version

Hi,
we uses 8.10 nuget version but the azure devops pipeline fail with this error:
(_CompileToNative target) ->
  MTOUCH : error MT2101: Can't resolve the reference 'System.IntPtr CoreFoundation.CFString::CreateNative(System.String)', referenced from the method 'System.Void Firebase.CloudMessaging.Messaging::DeleteFcmToken(System.String,Firebase.CloudMessaging.MessagingDeleteFcmTokenCompletionHandler)' in 'Xamarin.iOS, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=84e04ff9cfb79065'.

Is there any specific configuration or workaround for this?

Hi @GabrielOcampoLastra GabrielOcampoLastra we are also facing a similar issue in our app, can you help us with info on how you were able to resolve this?


Automated cherry pick of #2699: fix: 忽略裸金属器删除条件

Cherry pick of #2699 on release/2.11.
#2699: fix: 忽略裸金属器删除条件

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@7fe3d64). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.11   #2701   +/-   ##
==============================================
  Coverage                ?   7.22%
==============================================
  Files                   ?     470
  Lines                   ?   74363
  Branches                ?       0
==============================================
  Hits                    ?    5374
  Misses                  ?   68537
  Partials                ?     452

Flag
Coverage Δ

#aFlag
7.22% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/guests.go
0.67% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe3d64...c9c00f3. Read the comment docs.

/approve
/lgtm


Request: Add option in menu to launch inserted game disc (PS2 game)

OPL is so awesome that i set it to autolaunch when I power up my system, and most of the time i play backuped games over the internal HDD so its cool and all, but when I want to play a game disc i need to go back to the system dash (or FMCB dash).
How feasible would it be to add an menu entry to launch the inserted game disc? That way OPL would be the ultimate system dashboard for the PS2!
And thank you all the devs for putting time and effort to make this awesome piece of software, OPL is the single reason i still use my PS2 in 2019!

You can just have FMCB/FHDB'd 'Fastboot'-function turned 'on' and FMCB will boot the logo during/after the FMCB-Logo! ;)
Implementing a function which solely starts an inserted disc is possible and not too much work... However... As long as it doesn't support any of OPL's additional features like GSM, PADEMU, or simply ART, it doesn't really yield much advantages.

Ooops my previpost had some typos and errors. I fixed them.

'Issue' or feature-request #131 seems to be the exact same thing and I wrote a reply in there as well!
I think that's quite possible and just 'starting' it, would be relatively easy and fast to implement.
The extra-features (PADEMU, GSM, VMC, etx.) however would take longer.


Tangling over ssh

Hi, thanks for the great package.
I got the following block:
#+begin_src python :tangle /ssh:g5:/mnt/e/epi25/WES/migren/get_intervar_and_format_table.py
import pandas as pd
pairs = {
"a": {'SAMPLE': 'Sample', 'Location': 'Location'},
"b": {'SYMBOL': 'Symbol', 'Consequence': 'Consequence'},
"c": { "EXON": 'Exon',"INTRON":'Intron' },
"d": { "HGVSc": 'HGVSc',"HGVSp": 'HGVSp' },
"e": { "Existing_variation": 'Existing variation',"MAX_AF": 'Frequency' },
"f": { "AD": 'Allele depth',"GT": 'Genotype' },
"g": { "Criteria": 'Criteria','Intervar':"Classification" },
}
def format_df(df):
.
.
.
#+end_src

I can tangle this with the org-bable-tangle command. But org-auto-tangle gives the following error:
error in process sentinel: async-when-done: Opening output file: No such file or directory, /ssh:g5:/mnt/e/epi25/WES/migren/.#get_intervar_and_format_table.py
error in process sentinel: Opening output file: No such file or directory, /ssh:g5:/mnt/e/epi25/WES/migren/.#get_intervar_and_format_table.py

org-auto-tangle: 0.6.0
GNU Emacs     v29.1            nil
Doom core     v3.0.0-pre       HEAD -> master 03d692f1 2023-12-08 15:11:45 -0500
Doom modules  v23.12.0-pre     HEAD -> master 03d692f1 2023-12-08 15:11:45 -0500

I hit the same issue. Going deeper, org-auto-tangle uses async-start to tangle asynchronously. This starts a new Emacs process that does not know the existing ssh connection.
I can think of two ways to fix it

teach the child Emacs process to use the existing ssh connection, like ,(async-inject-variables "tramp-ssh-controlmaster-options")
use make-thread so that everything happens in the same process.

I did not get (1) to work but can get (2) working. Here is the rewritten version. One cons it that it might freeze the UI like usual org-babel-tangle.
  (defun org-auto-tangle-async (file)
    "Invoke `org-babel-tangle-file' asynchronously on FILE."
    (message "Tangling %s..." (buffer-file-name))
    (make-thread
     (let* ((buf-vars (plist-get (org-auto-tangle--get-inbuffer-options)
                                 :with-vars))
            (with-vars (if buf-vars
                           (mapcar #'intern
                                   (org-uniquify (org-split-string
                                                  (symbol-name buf-vars) ":")))
                         org-auto-tangle-with-vars))
            (preserved (mapcar (lambda (v)
                                 (cons v (symbol-value v)))
                               (append '(org-src-preserve-indentation
                                         org-babel-pre-tangle-hook
                                         org-babel-post-tangle-hook)
                                       with-vars)))
            (evaluate (not (member file org-auto-tangle-babel-safelist))))
       (let ((start-time (current-time))
             (non-essential t)
             (org-confirm-babel-evaluate evaluate))
         (cl-progv (mapcar #'car preserved) (mapcar #'cdr preserved)
           (org-babel-tangle-file file))

         (let ((tangle-time (float-time (time-since start-time)))
               (message-string (format "Tangling %S completed after" file)))
           (message "%s %.2f seconds" message-string tangle-time))))))


Add filter to pipelinerun link data

Fixes

https://issues.redhat.com/browse/RHTAPBUGS-26
Description
Add filter to link data for PIpelineRun node.

Type of change

[ ] Feature
[x] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review
https://user-images.githubusercontent.com/20013884/235201161-8766e534-5273-48dd-9c8c-141c8fee4a5e.mp4

How to test or reproduce?

Browser conformance:

[ ] Chrome
[x] Firefox
[ ] Safari
[ ] Edge

/cc @jeff-phillips-18

/approve

Added tests to satisfy codecov

/lgtm


Strip replica labels from series in Store Gateway

Store Gateway is currently the only store which does not strip replica labels from stores. This causes deduplication problems for certain cases where users need to deduplicate by labels stored in TSDB.
This commit modifies store-gateway to strip replica labels when they are also stored in TSDB blocks.
This is a partial fix for https://github.com/thanos-io/thanos/issues/6257.

[ ] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes

Verification

That PR only removes replica labels from external labels, but I thought we should also strip when they are part of the. This is what we do for the receiver and sidecar.
However, after my last comment , I think this would only mask the dedup problem that people are seeing in 0.31.0.

@fpetkovski I rebased this with the tests from main and it solved the problem in the Store GW. Problem's still present in Receive and Sidecar. Do you think you can extend the fix here to these other components?


Unreadable Logs on K8s v1.6

I'm seeing the same issue as #11
/mnt/log/containers/kube-apiserver-ip-10-131-51-160.ec2.internal_kube-system_kube-apiserver-c7a8163d649d8c56993670717b8aaa72704a7a9930aa115bd45971072f0ac96d.log unreadable. It is excluded and would be examined next time

I deployed the DaemonSet and Secret on my K8s cluster following the directions of the README file and it worked on my v1.5 cluster, but when I deployed it to my v1.6 cluster I got the above issue.
Differences between my v1.5 and v1.6 cluster set up:

v1.6 is using RBAC roles to restrict resources to within their namespace
Consequently, the kube-system has permissions across all namespaces and therefore I deployed the DameonSet and Secret to that namespace.  (Was getting a permissions issue when I deployed to the default namespace)

Has anyone seen this issue on v1.6?

@salilgupta1 : are you using the default configuration for the daemonet or have you customized it at all?

@frankreno we're using Kops to bring up the cluster. The DaemonSet is the standard configuration - only thing I added was namespace: kube-system to the metadata.

I have also this issue in kubernetes 1.6.1. Is there any known fix?

I haven't tried it out yet, but this seems relevant:
https://github.com/fabric8io/docker-fluentd-kubernetes/issues/14

Everything indicates it's some bad links. In the directory /mnt/log/containers there's one link per pod, but it's linked against /var/log/pods directory instead of /mnt/log/pods directory.

I solved it for my environment. What I've done is change the daemonSet of sumologic to mount the log volume on /var/log instead of on /mnt/log and create a docker image based on sumologic/fluentd-kubernetes-sumologic:latest with new versions of source.kubernetes.conf and source.containers.conf that replaces /mnt/log by /var/log in order to scrape correctly the logs.

@i02sopop : thank you for figuring this out.  It looks like the mount paths changed between k8s 1.5 and 1.6.  I will look at the best way to solve this and get the appropriate changes made as well as get proper versions in DockerHub.

I am thinking what we will do is create an environment variable for the mount path so that it can overridden.  Pre 1.6, the current path works fine (testing on 1.4 and 1.5).  However 1.6 has changed the paths so we need to update the mount path accordingly.  Plan is to get this done this week and get the new image pushed to Docker hub so you do not have to also maintain the image.

Actually, you can do this without modifying the config files OR creating your image.  You can correct this by updating only the fluentd.daemonset.yaml container volume mounts.  If you change


Question about TypeScript typing of query override

In the Custom query builder guide, extending the query builder in TypeScript is achieved with the following workaround:
import {
  Model,
  Page,
  QueryBuilder,
} from 'objection'

export class MyModel extends Model {
  static get QueryBuilder() {
    return class MyModelCustomQueryBuilder<M extends Model, R = M[]> extends QueryBuilder<M, R> {
      ArrayQueryBuilderType!: MyModelCustomQueryBuilder<M, M[]>;
      SingleQueryBuilderType!: MyModelCustomQueryBuilder<M, M>;
      NumberQueryBuilderType!: MyModelCustomQueryBuilder<M, number>;
      PageQueryBuilderType!: MyModelCustomQueryBuilder<M, Page<M>>;

      constructor(...args: [arg: any]) { // 1-element tuple, ugly hack/workaround
        super(...args)

        this.onBuild(builder => {
          const { withArchived = false } = builder.context()
          if (!withArchived) {
            builder.andWhere('is_archived', false)
          }
        })
      }
    }
  }
}

It works, but the guide also suggests just overriding the query static method since I am not adding methods to the custom query builder and only modifying the query behavior (specifically, automatically adding the is_archived = false WHERE condition on all queries by default).
I cannot, however, make the static query override pass the TypeScript type-check. Here's my latest attempt:
import {
  Model,
  Page,
  QueryBuilder,
} from 'objection'

export class MyModel extends Model {
  // this would've been shorter, but it wouldn't compile due to https://github.com/microsoft/TypeScript/issues/4628 :(
  static query(...args: any[]) {
    return super.query<MyModel>(...args)
      .onBuild(builder => {
        const { withArchived = false } = builder.context()
        if (!withArchived) {
          builder.andWhere('is_archived', false)
        }
      })
  }
}

The error from the TypeScript compiler:
Class static side 'typeof MyModel' incorrectly extends base class static side 'typeof Model'.
  The types returned by 'query(...)' are incompatible between these types.
    Type 'QueryBuilder<MyModel, MyModel[]>' is not assignable to type 'QueryBuilderType<M>'.
      Type 'QueryBuilder<MyModel, MyModel[]>' is not assignable to type 'QueryBuilder<M, M[]>'.
        The types returned by 'findById(...).execute()' are incompatible between these types.
          Type 'Promise<MyModel>' is not assignable to type 'Promise<M>'.
            Type 'MyModel' is not assignable to type 'M'.
              'M' could be instantiated with an arbitrary type which could be unrelated to 'MyModel'.ts(2417)

My question is:

Is there a way to make this work? Am I missing a type-coercion trick on my code?
If not, is the Model base class static query method typing incorrect (or can it be improved to make this work)?

Or is there nothing that can be done because this is just a natural limitation of https://github.com/microsoft/TypeScript/issues/4628?

You don't need to override query.


Support 2019 Lexus RX450h with Color HUD?

Can support be added for 2019 Lexus RX450h with Color HUD? So far OP will not identify car. Fingerprint info below:
fingerprint 36: 8, 37: 8, 166: 8, 170: 8, 180: 8, 295: 8, 296: 8, 426: 6, 452: 8, 466: 8, 467: 8, 550: 8, 552: 4, 560: 7, 562: 6, 581: 5, 608: 8, 610: 5, 643: 7, 658: 8, 713: 8, 740: 5, 742: 8, 743: 8, 800: 8, 810: 2, 812: 3, 814: 8, 818: 8, 819: 8, 820: 8, 821: 8, 822: 8, 830: 7, 835: 8, 836: 8, 845: 5, 863: 8, 865: 8, 869: 7, 870: 7, 871: 2, 898: 8, 900: 6, 902: 6, 905: 8, 913: 8, 918: 8, 921: 8, 933: 8, 944: 8, 945: 8, 950: 8, 951: 8, 953: 8, 955: 8, 956: 8, 971: 7, 975: 6, 993: 8, 998: 5, 999: 7, 1000: 8, 1001: 8, 1014: 8, 1017: 8, 1020: 8, 1041: 8, 1042: 8, 1044: 8, 1056: 8, 1057: 8, 1059: 1, 1063: 8, 1071: 8, 1076: 8, 1077: 8, 1082: 8, 1114: 8, 1161: 8, 1162: 8, 1163: 8, 1164: 8, 1165: 8, 1166: 8, 1167: 8, 1227: 8, 1228: 8, 1235: 8, 1237: 8, 1263: 8, 1264: 8, 1279: 8, 1349: 8, 1350: 8, 1351: 8, 1413: 8, 1414: 8, 1415: 8, 1416: 8, 1552: 8, 1553: 8, 1556: 8, 1557: 8, 1568: 8, 1570: 8, 1571: 8, 1572: 8, 1575: 8, 1592: 8, 1594: 8, 1595: 8, 1649: 8, 1777: 8, 1779: 8

@schomems , definitely. Could you please post (or PM me on discord) a cabana drive with stock system operating?

Hi rbiasini! I haven't done a drive yet since the EON / Panda won't find the car and the car is giving nothing but errors currently. How can I find you on discord? I searched for your handle here but found nothing there. I can PM you further details there. Thank you!

Hi again rblasini! I just completed two drives- one with switches set to 0111 to enable OP, and another with switches set to 1111 to set to stock. I tried to replicate the drive as exactly as possible. Can you DM me on discord and I can give you any details you might need? Thank you!

for toyota
1011 (Without comma power)
1001 (With comma power)
To use stock fuction

Merged in 5.11, closing


Update: Meltytech.Shotcut version 21.02.27

Removing old versions to reduce clutter
Microsoft Reviewers: Open in CodeFlow

/azp run


makeffv1 - adjust folder path

adjust folder path to mirror the folder path used in the BAI ad project. Instead of logs,md5,video, xml - have objects, metadata, logs, - check folder path templates on the isis for confirmation of correct path.

Hey, this was added back in october in this commit:
https://github.com/kieranjol/IFIscripts/commit/19f7204ac12f5ab8e1b35b3959cae00ab5ef873d
Here's a tree of the ffv1 file I just created:


Fastnlight: Blacklist jamesmckaywizard

Fastnlight requests the blacklist of the keyword jamesmckaywizard. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

jamesmckaywizard has been seen in 10 true positives, 0 false positives, and 0 NAAs.

Please bin this PR

Rejected by Jeff Schaller in Charcoal HQ. Reason: 'at the author's request '


Document audio sample formats.

Apologies for asking this in the issue tracker, I didn't see any forum linked from the README.
I have an av.AudioFrame
<av.AudioFrame 0, 1024 samples at 48000Hz, mono, fltp at 0x7ffa7f939ec8>

but calling .to_nd_array() on it gives me this error
(Pdb) frame.to_nd_array()
*** AssertionError: ("Don't know how to convert data type", 'fltp')

how can I see the samples?

this may well be related to #70 but I'm afraid I have no idea how to access the "buffer interface"

is this right? np.frombuffer(frame.planes[0].to_bytes(), dtype=np.uint8)

Take a look at https://www.ffmpeg.org/doxygen/2.8/group__lavu__sampfmts.html#gaf9a51ca15301871723577c730b5865c5 to see what the formats mean. "fltp" will be planar float, so one plane per channel, as floats.
You should also be able to use the buffer interface directly, so I'd try:
np.frombuffer(frame.planes[0], dtype=float)

(I did not try the above.)
I'll leave this open as a signal that this should be documented better.

ok cool, thanks!
I now have a big bunch of arrays of floats... currently trying to understand how to convert this into something play or aplay will accept so I can hear that it is the right thing.

play -t raw -r 48k -e floating-point -b 32 -c 1 audio.raw

I'm not convinced that the data is what I think it is. Plotting it
        container = av.open(datum.f)
        frames = container.streams.audio[0].frames
        chunk = container.streams.audio[0].frame_size // 2  # bug in av?
        rate = container.streams.audio[0].rate
        fltp = np.zeros((frames, chunk), dtype=float)
        for n, frame in enumerate(container.decode(audio=0)):
            fltp[n, :] = np.frombuffer(frame.planes[0], dtype=float)
        fltp = fltp.flatten()
        plt.plot(fltp)
        plt.show()

has some huge volume spikes.
 Python's float is 64bit. Whoops. 😜

people keep telling me Python is "easy" and fast to write, and Scala is "hard" and slow to write code, and I keep saying "well, this week I lost X days to a simple type error, and it didn't even involve higher order types".

To be completely fair, the problem wasn't python's float types, it was fortran's float types.

Re-opening this as a signal to document.

hi @mikeboers do you mind creating a copy of this ticket? I'm trying to create an Advanced Search with all my open tickets with a view to fixing them and I honestly don't think I will find the time to do this one, since I'm not using python anymore.

Okay; it is done.


vertx-framework-mysql-postgresql  question of LocalDateTime

is ok
but

I wish vertx could be more friendly to the date type of Java
thank you very much!

Maybe there's a better way. Just I don't know


Update documentation: label beta.kubernetes.io/arch to kubernetes.io/arch

This pull request updates deprecated label beta.kubernetes.io/arch to kubernetes.io/arch within example deployment file.
This label is deprecated since Kubernetes version 1.14 and is targeted for removal in v1.18
Fixes https://github.com/k8snetworkplumbingwg/sriov-cni/issues/193

Approval given by @zshi-redhat and myself.
Proceeding with the merge.


It's Possible to add Popover/ Tooltip in Road when Hover / Click ?

Hello @liodali ,
it's possible to add popover in road when event hover / click ?

Thanks

for now no
it little complicated to do it
but it will be nice feature to add
sorry for that

all right thanks @liodali

btw @liodali
how to implement onRoadTap ?

add
with OSMMixinObserver  to your widget
and call any method you want
for mapController
in initstate
call
controller.addObserver(this)

btw can we use onRoadTap to get the specific road we click?

yeah sure you get the information of that road
start point last distance
some other also

let's say I clicked on Purple road
why I get different hex color like "#66bbe"

thats the identifier of  the road has nothing to with the color just used uniquekey from flutter to keep track of it

thats happen internally from our api
when you call drawMultiRoad before return roadInfor for each road we associete to it key
maybe I will add name for it at least you can used also as link for it

sure bro @liodali pls add ✌🏻
really appreciate it!


fix: Should not show LUIS locale warnings if bot is exclusively using Orchestrator

Description
User receives LUIS "locale not supported" warnings even if their bot is using Orchestrator everywhere instead of LUIS.  We make the LUIS recognizer check explicit to prevent this warning when using Orchestrator.
Task Item
#minor

Coverage remained the same at 52.913% when pulling e365cee8de85a132bda4d5dddc2ba4eec60fd772 on tachou/orchLuisLocaleWarningFix into 8dc322d37835e588974a43adccb0fea7ea0f2fa1 on main.


Email bodies should be sub parts

The HTML and plain text parts of an email should be sub parts of a part with content type "multipart/alternative" and the main message content type should be "multipart/mixed". Attachments should be siblings of the "multipart/alternative" and not on the same level as the HTML or plain text parts.
"multipart/mixed"
    |
    |\ "multipart/alternative"
    |   |\ "text/plain"
    |   \ "text/html"
    |
    \ attachments

This problem presents itself when some recipients say they are not able to see the attachments to the message.
You can also replicate this issue by downloading a sent message within the Postal UI. If you open the EML file in Outlook 2016, you will not be able to see the attachment.
Ruby reference: https://github.com/mikel/mail/issues/522#issue-11549826
Comparable Stack Overflow question: https://stackoverflow.com/questions/3902455/mail-multipart-alternative-vs-multipart-mixed
I will fix this as a pull request shortly...

when will this get merged?

:tada: https://github.com/postalserver/postal/pull/376#event-8731747240

Resolved by d0db1345a2bf8f538b01b974e74391da6fffe2b1


Got rid of if insanity, that's what default args are for

Got rid of the huge if insanity in cli.py, that's what default args were designed for.

Lol :+1:

Yeah... I'm insane ¯_(ツ)_/¯


Implementation independent tests?

Are there generic tests that should work for every UHI implementation? I.e. if I implement UHI to e.g. yoda I don't want to write the tests myself, but reuse the tests from uhi.
Cheers,
APN

This is something that I've wanted, but hasn't been written yet.


Improve performance - add net flow measures into single WorkItems table

Currently the dashboard uses 2 x WorkItems tables for the net flow visual - this can be done within the same table thus improve performance/size of .pbix when saved

Not possible to do, however have altered the query to only pull relevant work items that have been started (i.e. have an InProgressDate field populated)


build issue with catkin build ROS1

Hi,
I am trying to build tsid repo with  catkin build ROS1. But, I  am having problem with eigenpy as shown in figure

But I have already installed the eigenpy  by using
sudo apt-get install ros-noetic-eigenpy
I really appreciate if you can help me to solve this issue.

sorry @nim65s it didn't work. Are there any build instructions for ros?. Ideally I want to use tsid c++ library in ros to build a hierarchical control for our robot. But, So far, I haven't seen any build instructions for ros . And also I have seen examples in python. Are there any examples for rosc++ or c++?. Am I missing something here?. Thank you and I really appreciate your help

Standard CMake build instructions seems to work fine for me on ros noetic. At least this work without issue:
FROM ros:noetic

RUN --mount=type=cache,sharing=locked,target=/var/cache/apt \
    --mount=type=cache,sharing=locked,target=/var/lib/apt \
    apt-get update -y && DEBIAN_FRONTEND=noninteractive apt-get install -qqy --no-install-recommends \
    ros-noetic-pinocchio

ADD https://github.com/stack-of-tasks/tsid/releases/download/v1.7.0/tsid-1.7.0.tar.gz /
ADD https://github.com/stack-of-tasks/eiquadprog/releases/download/v1.2.8/eiquadprog-1.2.8.tar.gz /
WORKDIR /src

RUN . /opt/ros/noetic/setup.sh \
 && tar xvf ../eiquadprog-1.2.8.tar.gz \
 && cmake -B build -S eiquadprog-1.2.8 \
 && cmake --build build \
 && cmake --build build -t test \
 && cmake --build build -t install \
 && rm -rf build eiquadprog-1.2.8 \
 && tar xvf ../tsid-1.7.0.tar.gz \
 && cmake -B build -S tsid-1.7.0 \
 && cmake --build build \
 && cmake --build build -t test \
 && cmake --build build -t install \
 && rm -rf build tsid-1.7.0

Hi @nim65s , thanks for the help. I was trying to build and use tsid as a catkin package.
# Step 1: Create a Catkin workspace
cd ~
mkdir -p catkin_ws/src

# Step 2: Clone the TSID repository into the src directory
cd ~/catkin_ws/src
git clone https://github.com/stack-of-tasks/tsid.git

# Step 3: Build the TSID package
cd ~/catkin_ws
catkin build tsid

I installed tsid using robotpkg-py3*-tsid earlier. I went through the python examples without having any issue.

Do you think previous installation using robotpkg conflicting with building with catkin package. Thank you

You must not have the same package installed twice. You can either use our softwares from robotpkg- or from ros-, but not at the same time. Having 2 different versions of eigenpy / hpp-fcl / pinocchio / eiquadprog / tsid / etc. active at the same time will result in errors.
For your setup, I don't have catkin on ros noetic, but catkin_make / catkin_make_isolated. And these are working fine:
FROM ros:noetic

RUN --mount=type=cache,sharing=locked,target=/var/cache/apt \
    --mount=type=cache,sharing=locked,target=/var/lib/apt \
    --mount=type=cache,sharing=locked,target=/root/.cache \
    apt-get update -y && DEBIAN_FRONTEND=noninteractive apt-get install -qqy --no-install-recommends \
    git \
    ros-noetic-eiquadprog \
    ros-noetic-pinocchio

WORKDIR /ws/src
RUN . /opt/ros/noetic/setup.sh \
 && git clone --recursive https://github.com/stack-of-tasks/tsid \
 && cd .. \
 && catkin_make_isolated

@nim65s thank you so much for detail answer and I really appreciate it. I will follow the setup instructions given above. Sorry for the trouble.


fix NPE while adding new elem into a list

The error occurred while adding a new item into an empty list (industrySectors, languages etc.).
@LebedkoDmitry could you please take a look?

Codecov Report

Merging #40 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master     #40     +/-   ##
========================================
+ Coverage    70.2%   70.3%   +0.1%
========================================
  Files          52      52
  Lines        1168    1172      +4
  Branches       68      72      +4
========================================
+ Hits          820     824      +4
  Misses        332     332
  Partials       16      16

Impacted Files
Coverage Δ

src/app/users/user-profile.component.ts
83.13% <100%> (+0.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47d7980...7c537f8. Read the comment docs.


Distribute the plugin as a gradle plugin.

Closing this as invalid, as I'll want to move to KSP for this project.


⚠ Bofrost.fr has degraded performance

In 2e1f35c, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1069 ms

Resolved: Bofrost.fr performance has improved in 59ebe58 after 13 minutes.


chore: add colorout

Pull request 203 automated checks returned findings: URL of package 'colorout' is given as 'jalvesaq/colorout' but does not appear in its DESCRIPTION file published on CRAN.

The archived version on CRAN appears to predate the creation of the repository on GitHub.


What is the proper way to use router.go in a vue component?

This is an example of how most of my components use redirection right now:
var Login = Vue.extend({
    template: require('./template.html'),
    methods: {
        onSubmit: function() {
            // Do some stuff here
            this.$route.router.go('/somewhere-else');
        }
    }
});

It works, but is this.$route.router.go the right way to do it?
The documentation lacks an example of how to use it in a component:
http://vuejs.github.io/vue-router/en/api/go.html
It might be a good idea to include an example since I had to dig through the $route object to find the router.go method.

Yeah, might be easier to just expose this.$router directly in the future.

this.$router will be directly available in next release.

I tried both 'this.$router.router.go' and 'this.$route.router.go', I got undefined error for both methods: 'ManageView.vue?1fff:56 Uncaught TypeError: Cannot read property '$route' of undefined'. Is therr any update on this?

It's this.$router.go().
But your error is for something else, it says this isn't available.

I figured this out. It was the es6 arrow function scope issue.

Guys help me, am having issue with vue router, i am unable to use selector for template.like
var home = Vue.extend({   template: '#homeView' })
This is not working but working with
var home = Vue.extend({   template: '
Home Template
' })

need more available examples...

for vue 2.0 do: this.$router.push('/about') instead of using this.$router.go()
https://router.vuejs.org/en/essentials/navigation.html

it gives me an error => "Cannot read property '$router' of undefined"

it gives me an error => "Cannot read property '$router' of undefined"

You probably have the wrong this, make sure to hold the reference:
created: {
  // keep reference
  let self = this

  Service.perform.then(function () {
    // the *this* here refers to the function
    self.$router.push('/about')
  })

  // or use arrow function to keep the same *this*
  Service.perform.then(() => {
    this.$router.push('/about')
  })
}

@felipe-augusto Thanks, your solution works perfectly fine. 👍

this.$router give to me this error
Cannot read property '$router' of undefined

For me, it's like using an anonymous function.

this.$router.go("/somewhere-else")
changed to
this.$router.push("/somewhere-else")
in recent vue versions

import router in your component
import router from '../router'
and use that like this
router.replace('home')
my full code example :

import router in your component
import router from '../router'
and use that like this
router.replace('home')
my full code example :

@Rhyanz46 Thanks, your method solved my error!


[Feature] KubeVela image ADAPTS to the domestic operating systems arm64 and x-86

Is your feature request related to a problem? Please describe.

KubeVela image ADAPTS to the domestic operating systems arm64 and x-86
Describe the solution you'd like

Describe alternatives you've considered

Additional context

vela image already supports linux/arm64 and linux/amd64. Do domestic operating systems require a more specialized version?


Add DataFrame.filter()

This PR adds DataFrame.filter()

Codecov Report

Merging #589 into master will decrease coverage by 2.84%.
The diff coverage is 91.11%.

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
- Coverage   93.43%   90.58%   -2.85%
==========================================
  Files          31       31
  Lines        4631     4675      +44
==========================================
- Hits         4327     4235      -92
- Misses        304      440     +136

Impacted Files
Coverage Δ

databricks/koalas/missing/frame.py
100% <ø> (ø)
:arrow_up:

databricks/koalas/frame.py
92.46% <91.11%> (-2.04%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
23.14% <0%> (-74.08%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
76.31% <0%> (-7.9%)
:arrow_down:

databricks/conftest.py
90.69% <0%> (-6.98%)
:arrow_down:

databricks/koalas/utils.py
97.43% <0%> (-2.57%)
:arrow_down:

databricks/koalas/namespace.py
87.5% <0%> (-1.62%)
:arrow_down:

databricks/koalas/plot.py
92.51% <0%> (-1.58%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59eac08...b4fc0ca. Read the comment docs.


[docs] Suggest using gitpod in CMS quickstarts

The Problem/Issue/Bug:
testing area for devlopers
How this PR Solves The Problem:
Manual Testing Instructions:
Automated Testing Overview:

Related Issue Link(s):
Release/Deployment notes:

Sorry, I don't think we should introduce gitpod here. If people aren't already using it, they have to do a little setup. I think this will be a distraction.

well gotcha, actually I had an Idea to fork the ddev-launch repo in order to PR a new feature that can specify the project type through one of the environment variables passed through the URL to match the idea that @tyler36  mentioned: "I think it would be helpful if we had a repo for each supported framework." .
anyway just let me know if you decide to use gitpod in the cms quickstart.

It's just that people are already wedded to what they're using. Gitpod is a fantastic tool, but I think people are better to use the tool they're familiar with here. Thanks for the good thinking!


Bug for NPP015 (REDEFINE length) partially fixed

In the disabled test, which variable/line do you expect a diagnostic to be raised and why? (e.g. 900 bytes > 800 bytes)
I'm a bit lost on such complex redefines :D

2 #bytes2 (A1/1:850)
2 redefine #bytes2
3 #bytes-str (A750)
3 #r1 (a1/1:450)
Bytes2 is 850, but the redefinition fields are 750+450

It seems to not check the redefine at all, because the top level #GRP is checked.
This is a tough change. Maybe it would be easier to pull out the length check from the addTargetToRedefine (it is never called for redefine #bytes2?) and do a pass over all variable at the end of parseInternal and check if a variable is a redefine and if yes, then check the sizes.
You can use defineData.variables() to do so, no need to manually go through all levels. That method already does return all variables (including tested).


Error when running the ‘apply’ command on remote kubernetes: error: SchemaError(io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta): invalid object doesn't have additional properties

Environment:
I have two machines. The first one with clean ubuntu (I have only docker and harbor installed on it). The second - with windows 10 running docker for windows with enabled kubernetes.
I want to connect kubernetes from my windows machine to kubernetes on ubuntu.
I ran a next command to install microk8s on ubuntu:
$ sudo snap install microk8s --classic
After that, I got configuration using the command
$ microk8s.config
My configuration:
apiVersion: v1
clusters:
- cluster:
    certificate-authority-data: ***
    server: https://<IP_ADDRESS>:16443
  name: microk8s-cluster
contexts:
- context:
    cluster: microk8s-cluster
    user: admin
  name: microk8s
current-context: microk8s
kind: Config
preferences: {}
users:
- name: admin
  user:
    username: admin
    password: ***

I replaced the whole kubernetes configuration file on windows machine with the above configuration text.
Kubernetes version (use ‘kubectl version’ on windows machine) :
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.11", GitCommit:"637c7e288581ee40ab4ca210618a89a555b6e7e9", GitTreeState:"clean", BuildDate:"2018-11-26T14:38:32Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"windows/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.0", GitCommit:"641856db18352033a0d96dbc99153fa3b27298e5", GitTreeState:"clean", BuildDate:"2019-03-25T15:45:25Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}

What happened:
On windows machine, I can successfully run ‘get pods’ command that shows running pods on ubuntu. I even can run ‘delete’ command on windows machine to remove deployment on ubuntu. But when I try to run ‘apply’ command, I got the error
kubectl apply -f https://k8s.io/examples/application/deployment.yaml
error: SchemaError(io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta): invalid object doesn't have additional properties

When I run this command directly on ubuntu, it succeeded.
What you expected to happen:
After executing the command
kubectl apply -f https://k8s.io/examples/application/deployment.yaml
I expected that I would have running pod on my ubuntu
inspection-report-20190403_082007.tar.gz

Hi @KlausTrikk,  have you tried with a client that matches the 1.14 version?

No, I only tried to connect from the windows machine that running the latest Docker Desktop for windows v<IP_ADDRESS> with Kubernetes v1.10.11
In my configuration, I need to deploy my application from the windows machine on ubuntu.

I tried to connect from another ubuntu with microk8s - it works well.
$ microk8s.kubectl version
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.0", GitCommit:"641856db18352033a0d96dbc99153fa3b27298e5", GitTreeState:"clean", BuildDate:"2019-03-25T15:53:57Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.0", GitCommit:"641856db18352033a0d96dbc99153fa3b27298e5", GitTreeState:"clean", BuildDate:"2019-03-25T15:45:25Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}

But I need to connect from windows machine, as I mentioned before. I have no idea what I shroud do.

@KlausTrikk if you do not want to dig into the API compatibility issues you could try to downgrade MicroK8s. For example to get the 1.12 kubernetes you can:
sudo snap install microk8s --classic --channel=1.12/stable

This has happened to me because of wrong version of kubectl installed by docker in the path
"C:\Program Files\Docker\Docker\resources\bin" .
I resolved this by following below steps
Install kubectl manually by :

Install-Script -Name install-kubectl -Scope CurrentUser -Force
install-kubectl.ps1 [-DownloadLocation ]

(https://kubernetes.io/docs/tasks/tools/install-kubectl/#install-kubectl-on-windows)
CD to the [-DownloadLocation ] folder and run kubectl from the downloaded . If the location is not given it will install it in temp by default. I have installed it in temp
PS C:\Users\sysadmin\AppData\Local\Temp> : kubectl version
If the version mismatch run the command again and check.
Try kubectl apply from this location.

@vinothrao, thank you, this solved my problem!
I've downloaded the newest kubectl.exe using the link above and replaced the old one (C:\Program Files\Docker\Docker\resources\bin\kubectl.exe) with it and it works for me!
Thanks a lot!

We can consider this issue resolved. Feel free to reopen if you have the same issue.

wasted one good hour on this issue ,never thought that a kubectl version is issue . kubectl upgrade fixed it .

hi
i found error:
error: SchemaError(io.k8s.api.core.v1.StorageOSVolumeSource): invalid object doesn't have additional properties.
while performing kubernetes deployment in CircleCI

Hitting this error again with kubectl v1.6.3 and microk8s v1.6.3.

@CalvinHartwell could you share the microk8s.inspect tarball?

@CalvinHartwell could you share the microk8s.inspect tarball?

Hey Kos,
We figured it out. At first, I was confused because I've seen errors when the version of kubernetes is different than the version of kubectl used, due to the fact api entries change between versions. A recent example in Kubernetes 1.16/1.15 was the graduation of the Deployment object from apiVersion: extensions/v1beta1 -> apiVersion: extensions/v1 (stable).
Our test platform is as follows:

Windows 10 Latest
Multipass + 18.04 image
Kubectl 1.6.3
Microk8s with Kubernetes 1.6.3

We worked out that whenever we did not use kubectl with the full path we hit errors when trying to create Deployment objects, either using apply with a pre-created yaml manifest or using kubectl create deployment, both times it failed. We were using kubectl by appending it's path to the main path variable on windows (as per usual).
The message from vinothrao gave this away:

This has happened to me because of wrong version of kubectl installed by docker in the path
"C:\Program Files\Docker\Docker\resources\bin" .
I resolved this by following below steps
Install kubectl manually by :

Install-Script -Name install-kubectl -Scope CurrentUser -Force
install-kubectl.ps1 [-DownloadLocation ]

(https://kubernetes.io/docs/tasks/tools/install-kubectl/#install-kubectl-on-windows)
CD to the [-DownloadLocation ] folder and run kubectl from here . If the location is not given it will install it in temp by default. I have installed it in temp
PS C:\Users\sysadmin\AppData\Local\Temp> : .\kubectl.exe version
If the version mismatch run the command again and check.
Try kubectl apply from this location.
PS C:\Users\sysadmin\AppData\Local\Temp> .\kubectl.exe apply -f C:\Users\sysadmin\source\repos\RecruitManage\webapp-pod.yaml
Note : careful about that kubectl use .\kubectl.exe which is inside the folder not the plain kubectl because it will fall back to Docker's kubectl as it is set in environment variable.

I've created a bug here for kubectl: https://github.com/kubernetes/kubectl/issues/777
I do not think this issue is directly caused by multipass or microk8s, it is a kubectl bug.
Cheers,

Calvin

@CalvinHartwell Thank You! I was also facing same issue and got solved. It was because of following version differences between client and server:
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.0", GitCommit:"fc32d2f3698e36b93322a3465f63a14e9f0eaead", GitTreeState:"clean", BuildDate:"2018-03-26T16:55:54Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"windows/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.5", GitCommit:"20c265fef0741dd71a66480e35bd69f18351daea", GitTreeState:"clean", BuildDate:"2019-10-15T19:07:57Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
I have updated kubectl.exe to match server dependency and now it's working fine:)


use ef6 and mysql

i had use ef code first to create database,and i used charset = utf8 in
but the  generate database charset is latin1 -- cp1252 West European.
before i use unity to mapping the identity tables ,i can insert chinese to tables
if the mapping error Cause fail to generate database ?
are you help me ?
oh! my english so bad!!

Sounds like an excellent question for stackoverflow.


Turn on account sign up

Describe the Problem Statement
Remove the default admin and kitteh users.
Turn on user registration.
Add a user profile validator to check domains:
https://keycloak.discourse.group/t/user-registration-email-domain-whitelist/13298
Ideally we could set the email domain we allow users to sign up with an environment variable in the keycloak config.
For dev:

nexodus.local
For QA/Prod:
redhat.com

In our QA and Production deployments we MUST set up email address validation to prevent users from signing up with bogus email addresses - i.e I could use<EMAIL_ADDRESS>or<EMAIL_ADDRESS>if we don't set up validation.
This may require using an SMTP service to send those validation emails...
Describe the Enhancement
No response
Alternate Solutions
No response
Additional context
No response

Could we just oauth with google for qa/prod..  I think you HAVE to be a valid red hat person to get an email on that domain via google.

Could we just oauth with google for qa/prod.. I think you HAVE to be a valid red hat person to get an email on that domain via google.

Maybe. When I last tested this what happens is:

Go to try.nexodus.local
Click "Login With GitHub"
Go through the flow
You're logged in and you have a username (which is your GH username) and and ID that is your user-id

The problem being that you don't get a password created.
Without a password, you can't use nexd --username foo --password bar and you HAVE to use the device flow for everything. I think @nerdalert had some concerns about that.
This way seemed the shortest route to getting a working service.
The other way #285, would require us figuring out:

How to tell Keycloak that the user needs to add some additional information to their profile after the user sign up
If it can't be done as part of the account registration, we'd need to figure out how to "wrap" the keycloak service so we can let users update their profile from the nexodus UI.

This should be blocked on #646

This is done now via allowing login via Google. It requires the device login flow, but caching the API refresh token makes it tolerable for now.


question about match

OrientDB Version, operating system, or hardware.

v2.2.14

Operating System

[x] Linux
[ ] MacOSX
[x] Windows

Hi guys.
I have a question about match's behaviour.
I'll start with an example:
I have 5 classes of vertices: start, mid, left, right, finish
and 6 classes of edges between them: toMid, toRight, fromRight, toLeft, fromLeft, toFinish
                    ( left )
                      A   |  fromLeft
              toLeft  |   V
( start ) -- toMid-> ( mid ) -- toFinish -> ( finish )
             toRight  |   A
                      V   |  fromRight
                   ( right )

and two way

( start ) --toMid-> ( mid ) --toRight-> ( right ) --fromRight-> ( mid ) --toLeft-> ( left ) --fromLeft-> ( mid ) --toFinish-> ( finish )
( start ) --toMid-> ( mid ) --toLeft-> ( left ) --fromLeft-> ( mid ) --toRight-> ( right ) --fromRight-> ( mid )--toFinish-> ( finish )

for first way I use query:
MATCH {class: start}
.out('toMid')
.out('toRight')
.out('fromRight')
.out('toLeft')
.out('fromLeft')
.out('toFinish'){as: fin}
RETURN $matches

for secon:
MATCH {class: start}
.out('toMid')
.out('toLeft')
.out('fromLeft')
.out('toRight')
.out('fromRight')
.out('toFinish'){as: fin}
RETURN $matches

Can I select two way with one query?

Hi @Ivanov-Yuriy
I'm not sure I got your question... probably you can split your patten in three:
MATCH
    {class: start} .out('toMid'){as:mid}.out('toFinish'){as: fin},
    {as:mid}.out('toLeft').out('fromLeft'),
    {as:mid}.out('toRight').out('fromRight')
RETURN $matches

you can also add constraints about the fact that the result of {as:mid}.out('toLeft').out('fromLeft') is still {as:mid}, eg.
MATCH
    {class: start} .out('toMid'){as:mid}.out('toFinish'){as: fin},
    {as:mid}.out('toLeft').out('fromLeft'){as:mid},
    {as:mid}.out('toRight').out('fromRight'){as:mid}
RETURN $matches

Thanks
Luigi

I poorly explained

CREATE CLASS start extends V
CREATE CLASS mid extends V
CREATE CLASS right extends V
CREATE CLASS left extends V
CREATE CLASS finish extends V

CREATE CLASS toMid extends E
CREATE CLASS toLeft extends E
CREATE CLASS fromLeft extends E
CREATE CLASS toRight extends E
CREATE CLASS fromRight extends E
CREATE CLASS toFin extends E

create property toMid.out LINK start
create property toMid.in LINK mid

create property toLeft.out LINK mid
create property toLeft.in LINK left

create property fromLeft.out LINK left
create property fromLeft.in LINK mid

create property toRight.out LINK mid
create property toRight.in LINK right

create property fromRight.out LINK right
create property fromRight.in LINK mid

create property toFin.out LINK mid
create property toFin.in LINK finish

first way
insert into start set str='start'
insert into mid set str='mid.1'
insert into mid set str='mid.2'
insert into mid set str='mid.3'
insert into right set str='right'
insert into left set str='left'
insert into finish set str='finish'

create edge toMid from (select from start) to (select from mid limit 1) set str='toMid'
create edge toRight from (select from mid limit 1) to (select from right) set str='toRight'
create edge fromRight from (select from right) to (select from mid skip 1 limit 1) set str='fromRight'
create edge toLeft from (select from mid skip 1 limit 1) to (select from left) set str='toLeft'
create edge fromLeft from (select from left) to (select from mid skip 2 limit 1) set str='fromLeft'
create edge toFin from (select from  mid skip 2 limit 1) to (select from finish) set str='toFin'

second way
insert into start set str='start #2'
insert into mid set str='mid.1 #2'
insert into mid set str='mid.2 2 #2'
insert into mid set str='mid.3 #2'
insert into right set str='right #2'
insert into left set str='left #2'
insert into finish set str='finish #2'

create edge toMid from (select from start skip 1 limit 1) to (select from mid skip 3 limit 1) set str='toMid #2'
create edge toLeft from (select from mid skip 3 limit 1) to (select from left skip 1 limit 1) set str='toLeft #2'
create edge fromLeft from (select from left skip 1 limit 1) to (select from mid skip 4 limit 1) set str='fromLeft #2'
create edge toRight from (select from mid skip 4 limit 1) to (select from right skip 1 limit 1) set str='toRight #2'
create edge fromRight from (select from right skip 1 limit 1) to (select from mid skip 5 limit 1) set str='fromRight #2'
create edge toFinish from (select from  mid skip 5 limit 1) to (select from finish skip 1 limit 1) set str='toFinish #2'

These two paths are different, but I will want to get them of one query if it possible
Unfortunately, I could not use your queries, maybe because I have no direct way of start -> mid -> finish, but my ways have spirals  start -> mid.1 -> left -> mid.2 -> right -> mid3 -> finish
I know that I can handle the spiral using cycles
.out('toMid')
.(out('toRight').out('fromRight')){while:($depth < 10), as: R}
.(out('toLeft').out('fromLeft')){while:($depth < 10), as: L }
.out('toFin')
{as: fin}
RETURN $matches

MATCH {class: start, as: s}
.out('toMid')
.(out('toLeft').out('fromLeft')){while:($depth < 10), as: L }
.(out('toRight').out('fromRight')){while:($depth < 10), as: R}
.out('toFin')
{as: fin}
RETURN $matches

but I do not know how to combine these queries

hi @Ivanov-Yuriy
If I got it right, it's easier than you think: just use out('toLeft', 'toRight').out('fromLeft', 'fromRight')
Thanks
Luigi

your example will work if ways have the same count of edges, but what will I do if right way has more edges than left?


fluvi guide fix

Pull request checklist
Use the following template to make sure your PR fits the ConsenSys documentation standard.
Before creating the PR
Make sure that:

[ ] You've read the contribution guidelines.
[ ] You've previewed your changes locally.

Describe the change

added mapping required warnings
Issue fixed

No current issue exists
Impacted parts

For content changes:

[ x] Documentation content
[ ] Documentation page organization

For tool changes:

[ ] Build and QA tools
[ ] Node dependencies and JavaScript
[ ] GitHub integration

After creating your PR and tests have finished
Make sure that:

[ ] You've fixed any issues raised by the tests.
[ ] You've previewed your changes on Vercel below.

@doongzzi can you rebase on original consensys main? I'm not sure what changes you're trying to make
The original fluviwallet guide has already been merged


RubyVM and Logging Metrics not appearing

Description
After setting instrumentation.thread.tracing to true, the API Evolution team noticed key information missing from the New Relic platform. The Logs graph on the APM Summary page appears empty. The RubyVMs page also shows 0 for its metrics. Other information, such as that related to transactions, appears as expected.
Expected Behavior

Expect Logging Summary table to be populated
Expect Logging/lines/{severity} metric to be collected
Expect Ruby
Expect RubyVM metrics to be collected

Troubleshooting or NR Diag

Debug-level logs turned on - No errors being raised, Samplers correctly ingested, some metric events still being sent
Audit logging turned on - Confirmed that no Logging/lines metrics are being gathered, no RubyVM/* metrics being gathered

Steps to Reproduce

Have not been able to reproduce the issue locally, however, the problem can be observed on ASGS (staging), an internal app.

permalink to summary page: https://staging.onenr.io/08dQeboLowe (Internal)
permalink to RubyVM page: https://staging.onenr.io/04ERPNql6QW (Internal)

Your Environment

Rails 7.0.3
Ruby 3.1.1
newrelic-infinite_tracing 8.8.0 + bugfix branch
application_logging.local_decorating.enabled: true
instrumentation.thread.tracing: true
error_collector.max_backtrace_frames: 250

Additional context

For Maintainers Only or Hero Triaging this bug
*Suggested Priority (P1,P2,P3,P4,P5): P3
*Suggested T-Shirt size (S, M, L, XL, Unknown): Unknown at this time

Linking this one to #1309


"Run with Full Refresh" fails with timeout

hi,
We installed the dataform scripts as instructed, and we executed the Full Refresh for one day (start day 30th June), then for one week (start date 24th June), and both finished successfully.
When we are defining an earlier start date like 01-Jan-2024 or 01-Mar-2024 (by updating constants.js file), one of the processes ends in error with timeout, as you can see in the screenshots.

From our initial investigations we found out that all the data seems to be present in the sessions output table but not the events output table.
Can you please provide information about how to diagnose this issue, or maybe provide instructions about how to submit the executions with smaller batches of data/dates. Is it even possible to submit smaller date ranges due to the lookback windows?

Hey @edkaizen , could you confirm you are using the latest commit of the GitHub repository? (There has been some optimizations done to the event query)
Also note, the event attribution model does not affect session attribution, so in case you are only interested in session attribution , you are good to ignore the events model.
You could also try loading it in smaller batches, but please make sure the date range goes back to the lookback window at a minimum.

hi @piariachi thank you for the feedback. We pulled the repo around 30th June, and I can see that the last commit is 28th May, so I am safely assuming that we are using the latest commit.
In the meantime I have some more screenshots of the query and error that is causing the failure I will upload them here. It is a join that is being done at the last steps of the sessions process. Do you suggest any solution for this?

Regarding loading in smaller batches, can you please provide instructions of how to do that? Do we need to move the Start Date month by month backwards (from the constants.js file) and the run ALL ACTIONS and DO NOT select "Run with Full Refresh"? How will the lookback window queries work in that case?

Thanks for sharing the screenshots, the is definitely related to large data volume. I do not have an alternative query at the moment unfortunately.
Would excluding un-necessary events from the staging layer help here? I have seen that a lot of datasets have 70%+ events that are just informational and custom (as opposed to the core events page_view, session_start, purchase etc...)
For smaller batches, the models do not support this and you would need to manually configure that for now. The current code only supports a recent 'start_date' but not 'end_date'...

hi @piariachi , we have followed your suggestion to optimise the queries in the output events file event.sqlx since the dataform was getting stuck for hours in this step. Specifically it was getting stuck in the "final as (" part since there is a sub-query within the select statement for all the events, which is very inefficient. The subquery was to sort out the last click attribution with the two lookback windows:
final as (     select     a.*,     if(coalesce(nullif(a.collected_traffic_source.source, '(direct)'), nullif(a.collected_traffic_source.medium, '(none)'), nullif(a.collected_traffic_source.campaign, '(direct)')) is null,     (     select     array_agg(b.collected_traffic_source)     from     int_event as b     where     b.user_key = a.user_key     and cast(b.event_timestamp / 1000000 as int64) >= (cast(a.event_timestamp / 1000000 as int64) -     case     when a.event_name in ('first_visit', 'first_open') then ${constants.AQUISITION_EVENTS_LOOKBACK_WINDOW}     else     ${constants.ALL_EVENTS_LOOKBACK_WINDOW}     end     )     and cast(b.event_timestamp / 1000000 as int64) <= cast(a.event_timestamp / 1000000 as int64)     and coalesce(nullif(b.collected_traffic_source.source, '(direct)'), nullif(b.collected_traffic_source.medium, '(none)'), nullif(b.collected_traffic_source.campaign, '(direct)')) is not null)[safe_offset(0)],     a.collected_traffic_source     ) as last_non_direct_traffic_source     from     int_event as a )
I had a look at the sessions.sqlx file since this also queries the events table but finishes in minutes, the main difference though is that it only has the sessions lookback window and not the acquisition one too. So I have attempted to get the main query structures from the sessions.sqlx file and adapt them to the events file. It seems to be successful i terms of optimisation since the script now ends in like 30 mins rather than timing out after 9 hours. However I would need some help to verify the script and some direction of how to QA the resulting output data. I will upload the events file for your review.
event.sqlx.zip

Hi @edkaizen thanks for sharing the optimized query. I tried it on a dataset and the logic looks fine. I haven't gotten the chance to QA the results yet, but will add it to my todo.


Replace linenoise with own solution

Linenoise does not handle utf8 and Ctrl+C/D
Write our own solution or find something that can do as much as https://github.com/giann/sirocco

We could use readline if we manage to build it from build.zig

https://github.com/daanx/isocline might do


BIGTOP-3889: Update S3 bucket links of Jars downloading for Metrics in Mpack

https://issues.apache.org/jira/browse/BIGTOP-3889
For Metrics in Mpack,  the bigtop-snapshot bucket would be refreshed every new build. Then the Jars would be cleaned in the related path and files would be not found.
Update the link to the bucket: repo.bigtop.apache.org which would be permanently reserved for 3.2.0.

LGTM. +1


new: scap ppme to sc mapping table

What type of PR is this?
/kind cleanup
/kind feature
Any specific area of the project related to this PR?
/area libscap
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR is extracted from #889 .
It implements:

split scap ppm sc API (exposed by scap.h) in scap_platform library, under {linux,win32,osx}/scap_ppm_sc.c source file.
In the linux file, a new map[event_code][list of ppm_sc codes that generated that event] was created and it is needed to correctly retrieve all ppm_sc given an event_set.
Indeed, using the syscall_table to retrieve that information was very error prone because in userspace we only saw syscalls present on that architecture (included by our driver/syscall_compat_$arch.h); moreover there was no way to map OLD_VERSION events.
Ported all ppm_sc related scap APIs to use that table (that is linux specific, and scap_ppm_sc.c private).
This allows us to reliably retrieve all ppm_sc related to an event set (because we are no more iterating over the syscalls_table, but we directly map event -> ppm_sc).

Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Most of the changes are in userspace/libscap/linux/scap_ppm_sc.c.
Macos and win32 scap_ppm_sc API impl does nothing.
Tests were cleaned up of now useless ifdef __NR_FOO checks, and <sys/syscall.h> includes.
Added a small test to guarantee that any new PPM_SC is also added to the new scap_ppm_sc.c table.
Other tests present in #889 will be added once all the PRs are in (ie: this one,  #936 and the ppm_tp table refactor/merge into ppm_sc)
Does this PR introduce a user-facing change?:
NONE

/milestone 0.11.0

Rebased on top of new master.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Need to rebase :(

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cc @falcosecurity/libs-maintainers for visibility.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, incertum
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, incertum
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


react highlighting and autocomplete not working

hi yesterday it works but now it doesn't work. Why is that? Can you help me fix it

I'm experiencing the same problem, you aren't alone!

SAme problem here

I installed the package called language-babel. That works perfectly fine. Another solution is to use this package https://atom.io/packages/language-javascript-jsx. Both language-babel and language-javascript-jsx will solve this issue until the react package is fixed. Make sure you just use one of these, disable the others.

I tried that, but not autocompleting yet.
Atenciosamente,
Maurício R. Duarte.
2016-08-04 20:52 GMT-03:00 Marcus Hurney<EMAIL_ADDRESS>
I installed the package called language-babel. That works perfectly fine.
Another solution is to use this package https://atom.io/packages/
language-javascript-jsx. Both language-babel and
language-javascript-jsx will solve this issue until the react package
is fixed. Make sure you just use one of these, disable the others.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/orktes/atom-react/issues/184#issuecomment-237719916,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABE4_ciLSTMyhyUENfBPcQvFhqY2tvgsks5qcntSgaJpZM4JcXfU
.

I recomend using language-babel https://atom.io/packages/language-babel
It has similiraties to react package since it has autocomplete and highlighting.  The othe package doesn't have autocomplete.

I agree, not having autocomplete is a big disadvantage of the jsx language
package.
On Friday, August 5, 2016, pillowface<EMAIL_ADDRESS>wrote:

I recomend using language-babel https://atom.io/packages/language-babel
It has similiraties to react package since it has autocomplete and
highlighting. The othe package doesn't have autocomplete.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/orktes/atom-react/issues/184#issuecomment-237870544,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMusLgj98qwACBpHSgw7Hglx12Q_wiWmks5qc00_gaJpZM4JcXfU
.

Should be fixed https://github.com/orktes/atom-react/issues/188


Object Detector C++ unit tests do not compile.

Running make inside debug/test on current master leads to the following error:
/Users/schhabra/workspace/turicreate/test/unity/toolkits/object_detection/test_object_detector.cxx:499:27: error: too few arguments to function call, single argument 'compute_final_metrics' was not specified
  model.finalize_training();
  ~~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/schhabra/workspace/turicreate/src/toolkits/object_detection/object_detector.hpp:61:3: note: 'finalize_training' declared here
  virtual void finalize_training(bool compute_final_metrics);
  ^
1 error generated.
make[2]: *** [test/unity/toolkits/object_detection/CMakeFiles/test_object_detector.cxxtest.dir/test_object_detector.cxx.o] Error 1
make[1]: *** [test/unity/toolkits/object_detection/CMakeFiles/test_object_detector.cxxtest.dir/all] Error 2
make: *** [all] Error 2

Addressed by #2590


Davrods is not accepting anonymous ticket access in dev

While testing ticket access I ran into the following error from Davrods:
[dav:error] [pid 19] [client <IP_ADDRESS>:38018] Anonymous mode is enabled but Davrods couldn't log in with the configured anonymous credentials (option DavrodsAnonymousLogin) and the configured auth scheme (option DavrodsAuthScheme).  [500, #0]

Should look into this.

I need to ensure this works once I've upgraded to Davrods for iRODS v4.3.x (#63).

This was a dev server configuration problem. see #68.


NEW: Start adding Collection

Adds new Collection type to support collections of outputs

Blocking qiime2/q2cli#288

This all generally makes sense at a high level. I'll do another pass after you've addressed all of Evan's review comments!


Deploying cluster using non-root user

Signed-off-by: Aishwarya Kamat<EMAIL_ADDRESS>

/lgtm

/hold for playbook changes to be merged.

@yussufsh The playbook changes are merged. Can you please review this PR? Thanks.

/unhold


[FEATURE REQ] CosmosError should offer a getter for error messages

Is your feature request related to a problem? Please describe.
CosmosError.java should offer a way of accesing the Error property from the propertyBag.
Currently, when a ConflictException is thrown, one can't access the human readable error message. The only way to get there is to use toString() and to extract it from there. The information is available in the propertyBag but there is no getter for the array of Errors
Describe the solution you'd like
a new method like:
public List<String>/Set<String> getErrors() { ... }
accessing the propertyBag and extracting all entries from the Errors array.
Additional context
Cosmos DB
Java SDK v4 preview.2
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Description Added
[x] Expected solution specified

I discovered a better workaround:
ArrayNode errorsNode = (ArrayNode) cce.getError().get("Errors");
where cce is the CosmosClientException
Still - having a dedicated method getErrors would make it discoverable.

Thanks for filing this issue @tomekapc.  @kushagraThapar or someone from the Cosmos team will follow up with you.

@simplynaveen20 will take a look at this shortly. Thanks for reporting this.

CosmosError is no longer a public class, instead use CosmosException which has the getters for message and exception details.


Support node_modules or npm

I have a module (x) installed in node_modules.
I would like to be able to just call require(x) and modul8 should just be able to find the file.

npm modules has been something I have so far avoided for a couple of reasons:
1 - there's no guarantee they will work on the client (usage of the 'fs' and other server only code will cause them to fail)
2 - there's no guarantee they will fully resolve on the server (detective does not detect conditional/programmatic requires)
3 - you have very little control over what is pushed into the compiled source because of the recursive dependencies that can change on npm update
4 - their dependencies have to be special cased during analysis because of the extra require path on node_modules/
This is why I was advocating a more plugins based approach where you explicitly create a folder of these things.
That said, there are obviously, good reasons for including them if you are 100% aware of the potential consequences, and know that the module is browser safe.
I think basic npm support could be implemented by special casing the resolver on each end, but you have to note that this will only work when point 1 or 2 is not violated by the module or any of its recursive dependencies.
Maybe it would be useful to have a flag in package.json to indicate compliance to 1 and 2.
I can't promise anything about this yet, I feel it is dangerous, and that you should probably use .libraries() or possibly ender for these things. Not sure how compatible they are with your particular use case, but they should be far safer in general.

@clux I can appreciate not wanting this in core.
But could you give some high level explanation about how I could write a plugin to support loading dependencies from node_modules.
I just personally like using npm to build my node_modules folder rather then having a seperate vendor folder with all of the code copy/pasted into it.
My main issue is that with
/node_modules
/pd
package.json (has field main = correct path)
and
.domains({ 'npm': path.join(__dirname, 'node_modules')});
it doesn't work. Satisfying compliance with 1 and 2 is something I can do on my own.
I guess the plugin needs to allow module loading through a package.json file in a directory and it would need to push the resolver around a bit until it works.

Yeah, at the moment npm domain would not work as you wrote above. Your pull would give basic support, but it would miss out dependencies of the modules.
The fix for this could be similar, but with your pull, and that potentially added in, the Resolver::locate function quickly becomes the god function that handles everything. I would rather specialize the npm domain internally, to do this checking elsewhere.
As you have pointed out, I need to rewrite a little bit to have windows support anyway, so might as well tidy up in there properly.
I can do this this weekend, in the mean time, I'll accept the pull.

Pull, auto-closed, whoops.

I have added the 'npm' domain to the exception list in the resolver and added some special behaviour for it (prepend join node_modules to current path if absolute require to fix recursive requires of npm modules).
This is not in master yet, but locally, there are two ways of requiring npm modules:

require('npm::underscore')
require('underscore')

The first is safer. It will throw if you do not have underscore in your node_modules folder, and it is immediately obvious that it does not come from an arbitered library you included manually.
The second has none of these benefits and does not have particular priority over other files in your other domains.
For these reasons I might remove the second way to reduce collisions / improve readability. It may be more to type, but it is only in your app code, and I think it will make things better.
On the other hand, maybe it should just work, I can always throw in the code if there are arbiters of the same name.
Thoughts? Should absolute npm requires be allowed from app code? If so, should they have priority over same named files on current domain?

This depends, does absolute npm requires work recursively?
i.e. if i `require('backbone') will backbone be able to require underscore ?
If it doesn't work recursively then just stick to require(npm::underscore)

I personally would wrap all my npm modules with require(npm::module) it would just be nice if real requires in the npm modules worked.
the way I use modul8 I actually avoid non-domain requires.

basic npm is now up. client side stuff is unchanged, so it is unix only atm. It is also a bit annoying the way it exports node modules that are subs.
There's an example in the examples/npm folder, underscore as a result is requirable, but I think that domain needs special logic on the client.

Got the server side resolver up locally and it's now clever enough to check up the tree, i.e.
npm install underscore
npm install backbone

bb install will not install underscore as it exists in the level above. Resolver will look for a local version first, then the one above recursively until at root.
This also means all multiple version issues can be avoided (with a little bit of trickery at the client level).
Will push once I have a useful path.js and a decent mechanism for including that and builtins.

npm support should now be up on master - probably going to do 0.15.0 of current master when i get npm docs in.
As of so far, nothing is fully tested, but advanced individual cases (with multiple existing versions) seem to work, and all existing tests pass. I'll write a more specific test for these features later.
require('npm::path') will always work as the require algorithm uses this instead of the much less robust 5 liner I had for folder slicing.
Set the node_modules root by chaining on
.npm('./node_modules')

in the normal fashion. Everything in that root is immediately requirable in app by using the npm:: prefix. Every absolute require inside the npm domain will try out local (then outer) modules and builtins. If people mess with require paths, then you are kind of screwed, but thankfully, but thankfully require.paths usage is deprecated. Closing for now : )


Wrong syntax (hook from #7609)

The issue in the subject was closed by Bittarman but the evidence showed points to anoter repository.
The file Version\Version.php of 2.4.4 release has a wrong declaration of constants, wich broke the entire aplication.
The line 23 of this file shoud be something like this:
const VERSION = '2.4.4'
Look at https://github.com/zendframework/zf2/blob/release-2.4.4/library/Zend/Version/Version.php to see the problem.
Thanks.

Confirm

Fixed, and replaced the release-2.4.4 tag with the fixed version.

Thanks guys! :D


GPIO.GeneralPurpose and pin numbering - example is confusing

I'm trying to figure out how to twiddle pins by looking at the blink and watch examples. In the project description it says that only one pin numbering system is in use which I took to mean BCM. The watch example usage shows "Console.WriteLine("I.e.: sudo mono Test.Gpio.WatchPin.exe P1Pin23");"
What is a PiPin23? Is that pin #23 on the header or is it GPIO23?
Also, forgive my newbishness but is there a simpler way of passing the pin number to the program rather than using a string and having to search an enumeration? Can't we just give the number and go from there?

There are some misprint. Have look here:
GPIOMonitor
We only use GPIO numbers.


Display filenames when metadata is not present

Thanks for this great Mopidy web client!
I'm using Mopidy to play wav files which (obviously) don't have metadata in them. Would it be possible to display filenames when no metadata is present?

That would probably be something for the Mopidy guys. Moped just consumes the data generated by Mopidy and displays the name of an item. We can't influence whether that's from meta-data or a file name. https://github.com/mopidy/mopidy/issues