Enhancement: Serialize/Deserialize definition

Our app talks to a back-end API and we wanted to have the back-end "drive" the application by sending down a state definition object.  This all worked great in theory (locally, with local unit tests etc).  But as soon as we tried to serialize the definition object we got the following exception:
'Appccelerate.StateMachine, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=917bca444d1f2b4c' is not marked as serializable.
How hard would it be to add this to the next release?
To be clear, here is a very simple example:
var builder = new StateMachineDefinitionBuilder<State, StateEvent>();
builder.In(State.InitialState)
.On(StateEvent.NextState)
.Goto(State.Login);
< code omitted for brevity>
            BinaryFormatter binaryFormatter = new BinaryFormatter();
            outStream = new MemoryStream();
            binaryFormatter.Serialize(outStream, builder);

The idea being that we'd send down just the definition object.  The app would be in charge of Build() and starting the state machine.  Again, this all works great locally (passing the definition object around the application) as long as we don't try to serialize it.

We figured out a simple way to get around the non-serializable issue.  It would still be a nice enhancement, but for anyone looking for a simple work around:
We created our own State Machine Definition object ("NTAStateMachineDefinition" below).  It is a simple class with an "Initial State" and a "Dictionary of transitions" (Dictionary<StateEvent, State>).  Having that, we can then use the following code to create a custom StateMachineDefinitionBuilder from what the API hands us (again, the API hands us our "NTAStateMachineDefinition" which is serializable to JSON):
public static StateMachineDefinitionBuilder<State, StateEvent> BuildStateMachine(NTAStateMachineDefinition definition)
        {
            if (definition == null)
                return null;

            var builder = new StateMachineDefinitionBuilder<State, StateEvent>();

            builder.DefineHierarchyOn(definition.InitialState)
                .WithHistoryType(HistoryType.None);

            foreach (var state in definition.States)
            {
                foreach(var transition in state.Transitions)
                {
                    builder.In(state.ThisState)
                        .On(transition.Key)
                            .Goto(transition.Value);
                }
            }

            builder.WithInitialState(definition.InitialState);

            return builder;
        }


Move ModelExplorer to ViewFeatures

This change removes the last vestiges of ModelExplorer from the model binding code, and moves it to ViewFeatures

:shipit:


Feature/sahu/qt framework

This PR adds the visualization and demonstration code, which is a QT based wrapper around our Controller API and a dummy "Plant" class.
There are a few API breaking changes incorporated into this class, the largest of which is the transformation of all our classes to access the same (atomic, thread-safe) shared data. This allows the user to also use this tool for tuning and online modification of parameters.
Draft until the following are accomplished:

[x] Modify PID class to use the shared_ptr to Params class. This is a little trickier than the others because there are multiple instances.
[x] Clean up GUI (legends, scaling, Y axis range, etc.)
[x] #14 and #15 should both be merged prior to this.

This PR is ready to merge.

Needs update to readme file - under "Dependencies", need to add "libqcustomplot-dev" to the "sudo apt-get install" command example.


Module issue in Playground code

Hey mate, great project! Working on integrating it into a few apps at the moment.
Noticed one issue; when opening up the workspace and attempting to run the playground, I'm getting this:
error: could not build Objective-C module 'SwiftOSC'

Did you already build the framework with no issues?
Also what version of Xcode/OS are you using?

On Oct 29, 2018, at 11:27 AM, Nick Arner<EMAIL_ADDRESS>wrote:
Hey mate, great project! Working on integrating it into a few apps at the moment.
Noticed one issue; when opening up the workspace and attempting to run the playground, I'm getting this:
error: could not build Objective-C module 'SwiftOSC'
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/devinroth/SwiftOSC/issues/27, or mute the thread https://github.com/notifications/unsubscribe-auth/AMaIEX39nOkeZBusXaWlRWeGUKu4mDiPks5up0h2gaJpZM4X_y3C.

Yeah, built the framework without any problem.
I'm on Xcode 10 / macOS 10.14.1
(Had another question as well; but that may be related to something else - will make another issue shortly).

Okay. I’ll check it out on my other system tomorrow and let you know.
I’m running an older version of Xcode and I think it makes a difference.

On Oct 29, 2018, at 12:48 PM, Nick Arner<EMAIL_ADDRESS>wrote:
Yeah, built the framework without any problem.
I'm on Xcode 10 / macOS 10.14.1
(Had another question as well; but that may be related to something else - will make another issue shortly).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/devinroth/SwiftOSC/issues/27#issuecomment-434053264, or mute the thread https://github.com/notifications/unsubscribe-auth/AMaIEQ4Jw5N-H_ohUmB2CUE9CpogSGrsks5up1t9gaJpZM4X_y3C.

Works fine for me on Xcode 10/ macOS 10.14. The only other thing I can think of is that the Playground is using the macOS version of the framework. Try building that and seeing if it runs.
That being said, playground support has been shoddy at best. If you can’t get that running you’re really not missing anything.
Are the test apps working fine?

On Oct 29, 2018, at 1:04 PM, Devin Roth<EMAIL_ADDRESS>wrote:
Okay. I’ll check it out on my other system tomorrow and let you know.
I’m running an older version of Xcode and I think it makes a difference.

On Oct 29, 2018, at 12:48 PM, Nick Arner<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Yeah, built the framework without any problem.
I'm on Xcode 10 / macOS 10.14.1
(Had another question as well; but that may be related to something else - will make another issue shortly).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/devinroth/SwiftOSC/issues/27#issuecomment-434053264, or mute the thread https://github.com/notifications/unsubscribe-auth/AMaIEQ4Jw5N-H_ohUmB2CUE9CpogSGrsks5up1t9gaJpZM4X_y3C.

Yup, rebuilding made everything work fine - closing!


Fix position of sidebar in Safari

Fixes #29
See twbs/bootstrap#12126

awesome

Thanks! But I think the fact that you need such a fix for Safari is rather awful than awesome :-)


[Feature Request]: output.crossOriginLoading support

What problem does this feature solve?
enable cross-origin loading of chunks.
What does the proposed API of configuration look like?
just like webpack：crossOriginLoading

I will try to implement this configuration.


Error Thrown When Decoration Used: Suggests Using Decoration

I am going through the DeepDream tutorial for Tensorflow 2.0 located here:
https://www.tensorflow.org/tutorials/generative/deepdream

OS Platform and Distribution: Clear Linux OS, VERSION_ID=32270

TensorFlow installed from (source or binary): clear linux machine-learning-tensorflow bundle

TensorFlow version (use command below): 2.0.0

Python version: 3.8.1

CPU model and memory: Intel(R) Xeon(R) Gold 6136 CPU @ 3.00GHz

Describe the current behavior
This works:
class DeepDream(tf.Module):
  def __init__(self, model):
    self.model = model

# !!!!! NOTICE THAT THESE LINES ARE COMMENTED OUT !!!!!
# :
#   @tf.function(
#       input_signature=(
#         tf.TensorSpec(shape=[None,None,3], dtype=tf.float32),
#         tf.TensorSpec(shape=[], dtype=tf.int32),
#         tf.TensorSpec(shape=[], dtype=tf.float32),)
#   )
  def __call__(self, img, steps, step_size):
      print("Tracing")
      loss = tf.constant(0.0)
      for n in tf.range(steps):
        with tf.GradientTape() as tape:
          # This needs gradients relative to `img`
          # `GradientTape` only watches `tf.Variable`s by default
          tape.watch(img)
          loss = calc_loss(img, self.model)

        # Calculate the gradient of the loss with respect to the pixels of the input image.
        gradients = tape.gradient(loss, img)

        # Normalize the gradients.
        gradients /= tf.math.reduce_std(gradients) + 1e-8

        # In gradient ascent, the "loss" is maximized so that the input image increasingly "excites" the layers.
        # You can update the image by directly adding the gradients (because they're the same shape!)
        img = img + gradients*step_size
        img = tf.clip_by_value(img, -1, 1)

      return loss, img

This (as is given in the tutorial) does not:
class DeepDream(tf.Module):
  def __init__(self, model):
    self.model = model

  @tf.function(
      input_signature=(
        tf.TensorSpec(shape=[None,None,3], dtype=tf.float32),
        tf.TensorSpec(shape=[], dtype=tf.int32),
        tf.TensorSpec(shape=[], dtype=tf.float32),)
  )
  def __call__(self, img, steps, step_size):
      print("Tracing")
      loss = tf.constant(0.0)
      for n in tf.range(steps):
        with tf.GradientTape() as tape:
          # This needs gradients relative to `img`
          # `GradientTape` only watches `tf.Variable`s by default
          tape.watch(img)
          loss = calc_loss(img, self.model)

        # Calculate the gradient of the loss with respect to the pixels of the input image.
        gradients = tape.gradient(loss, img)

        # Normalize the gradients.
        gradients /= tf.math.reduce_std(gradients) + 1e-8

        # In gradient ascent, the "loss" is maximized so that the input image increasingly "excites" the layers.
        # You can update the image by directly adding the gradients (because they're the same shape!)
        img = img + gradients*step_size
        img = tf.clip_by_value(img, -1, 1)

      return loss, img

I've put the error that's thrown in the sections below.
Describe the expected behavior
I would expect it to work with the decoration tag and (perhaps) not work with the decoration tag commented out. However when I run it with the decoration it throws an error that seems to suggest adding the decoration that appears to already be there, and when I comment out the decoration tag it works.  When I use the decoration tag the final error is:
OperatorNotAllowedInGraphError: iterating over tf.Tensor is not allowed: AutoGraph did not convert this function. Try decorating it directly with @tf.function.
(more detailed log below)
However when I remove the decoration by commenting it out, that is when it works.
NOTE:  I have Tensorflow 2.0.0 setup on google collab as well with python 3.6.9 and it does not display the same behavior.  It works either with or without the decoration.
All of this was installed on a fresh Clear Linux install tonight with no tinkering.  I had another installation earlier where I tried a fix seen elsewhere which included downgrading gast to 0.2.2.  I did that and that did not work.
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
# [CURRENT DEEP DREAM TUTORIAL AT: https://www.tensorflow.org/tutorials/generative/deepdream

def run_deep_dream_simple(img, steps=100, step_size=0.01):
  # Convert from uint8 to the range expected by the model.
  img = tf.keras.applications.inception_v3.preprocess_input(img)
  img = tf.convert_to_tensor(img)
  step_size = tf.convert_to_tensor(step_size)
  steps_remaining = steps
  step = 0
  while steps_remaining:
    if steps_remaining>100:
      run_steps = tf.constant(100)
    else:
      run_steps = tf.constant(steps_remaining)
    steps_remaining -= run_steps
    step += run_steps

    loss, img = deepdream(img, run_steps, tf.constant(step_size))

    display.clear_output(wait=True)
    show(deprocess(img))
    print ("Step {}, loss {}".format(step, loss))

  result = deprocess(img)
  display.clear_output(wait=True)
  show(result)

  return result

from datetime import datetime
startTime = datetime.now()

dream_img = run_deep_dream_simple(img=original_img,
                                  steps=100, step_size=0.01)

print(datetime.now() - startTime)

Other info / logs
WARNING:tensorflow:Entity <bound method DeepDream.__call__ of <tensorflow.python.eager.function.TfMethodTarget object at 0x7faea2d46d30>> could not be transformed and will be executed as-is. Please report this to the AutoGraph team. When filing the bug, set the verbosity to 10 (on Linux, `export AUTOGRAPH_VERBOSITY=10`) and attach the full output. Cause: invalid value for "node": expected "ast.AST", got "<class 'NoneType'>"; to visit lists of nodes, use "visit_block" instead
WARNING: Entity <bound method DeepDream.__call__ of <tensorflow.python.eager.function.TfMethodTarget object at 0x7faea2d46d30>> could not be transformed and will be executed as-is. Please report this to the AutoGraph team. When filing the bug, set the verbosity to 10 (on Linux, `export AUTOGRAPH_VERBOSITY=10`) and attach the full output. Cause: invalid value for "node": expected "ast.AST", got "<class 'NoneType'>"; to visit lists of nodes, use "visit_block" instead
Tracing
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/impl/api.py in converted_call(f, options, args, kwargs, caller_fn_scope)
    505         options=options, autograph_module=tf_inspect.getmodule(converted_call))
--> 506     converted_f = conversion.convert(target_entity, program_ctx)
    507

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/impl/conversion.py in convert(entity, program_ctx)
    320
--> 321   converted_entity_info = _convert_with_cache(entity, program_ctx,
    322                                               free_nonglobal_var_names)

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/impl/conversion.py in _convert_with_cache(entity, program_ctx, free_nonglobal_var_names)
    238
--> 239     nodes, converted_name, entity_info = convert_entity_to_ast(
    240         entity, program_ctx)

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/impl/conversion.py in convert_entity_to_ast(o, program_ctx)
    470   elif tf_inspect.ismethod(o):
--> 471     nodes, name, entity_info = convert_func_to_ast(o, program_ctx)
    472   elif hasattr(o, '__class__'):

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/impl/conversion.py in convert_func_to_ast(f, program_ctx, do_rename)
    668   context = converter.EntityContext(namer, entity_info, program_ctx, new_name)
--> 669   node = node_to_graph(node, context)
    670

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/impl/conversion.py in node_to_graph(node, context)
    697
--> 698   node = converter.standard_analysis(node, context, is_initial=True)
    699   node = converter.apply_(node, context, function_scopes)

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/core/converter.py in standard_analysis(node, context, is_initial)
    383   node = qual_names.resolve(node)
--> 384   node = activity.resolve(node, context, None)
    385   node = reaching_definitions.resolve(node, context, graphs, AnnotatedDef)

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/pyct/static_analysis/activity.py in resolve(node, context, parent_scope)
    497 def resolve(node, context, parent_scope=None):
--> 498   return ActivityAnalyzer(context, parent_scope).visit(node)

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/pyct/transformer.py in visit(self, node)
    479     if not anno.hasanno(node, anno.Basic.SKIP_PROCESSING):
--> 480       result = super(Base, self).visit(node)
    481     self.ctx.current_origin = parent_origin

/usr/lib/python3.8/ast.py in visit(self, node)
    359         visitor = getattr(self, method, self.generic_visit)
--> 360         return visitor(node)
    361

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/pyct/static_analysis/activity.py in visit_FunctionDef(self, node)
    441     self._enter_scope(False)
--> 442     node.body = self.visit_block(node.body)
    443     anno.setanno(node, NodeAnno.BODY_SCOPE, self.scope)

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/pyct/transformer.py in visit_block(self, nodes, before_visit, after_visit)
    370
--> 371       replacement = self.visit(node)
    372

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/pyct/transformer.py in visit(self, node)
    479     if not anno.hasanno(node, anno.Basic.SKIP_PROCESSING):
--> 480       result = super(Base, self).visit(node)
    481     self.ctx.current_origin = parent_origin

/usr/lib/python3.8/ast.py in visit(self, node)
    359         visitor = getattr(self, method, self.generic_visit)
--> 360         return visitor(node)
    361

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/pyct/static_analysis/activity.py in visit_Expr(self, node)
    265   def visit_Expr(self, node):
--> 266     return self._process_statement(node)
    267

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/pyct/static_analysis/activity.py in _process_statement(self, node)
    259     self._enter_scope(False)
--> 260     node = self.generic_visit(node)
    261     anno.setanno(node, anno.Static.SCOPE, self.scope)

/usr/lib/python3.8/ast.py in generic_visit(self, node)
    444             elif isinstance(old_value, AST):
--> 445                 new_node = self.visit(old_value)
    446                 if new_node is None:

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/pyct/transformer.py in visit(self, node)
    479     if not anno.hasanno(node, anno.Basic.SKIP_PROCESSING):
--> 480       result = super(Base, self).visit(node)
    481     self.ctx.current_origin = parent_origin

/usr/lib/python3.8/ast.py in visit(self, node)
    359         visitor = getattr(self, method, self.generic_visit)
--> 360         return visitor(node)
    361

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/pyct/static_analysis/activity.py in visit_Call(self, node)
    327     self._enter_scope(False)
--> 328     node.args = self.visit_block(node.args)
    329     node.keywords = self.visit_block(node.keywords)

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/pyct/transformer.py in visit_block(self, nodes, before_visit, after_visit)
    370
--> 371       replacement = self.visit(node)
    372

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/pyct/transformer.py in visit(self, node)
    457                  type(node))
--> 458       raise ValueError(msg)
    459

ValueError: invalid value for "node": expected "ast.AST", got "<class 'NoneType'>"; to visit lists of nodes, use "visit_block" instead

During handling of the above exception, another exception occurred:

OperatorNotAllowedInGraphError            Traceback (most recent call last)
<ipython-input-9-43912bcedaa9> in <module>
      2 startTime = datetime.now()
      3
----> 4 dream_img = run_deep_dream_simple(img=original_img,
      5                                   steps=100, step_size=0.01)
      6

<ipython-input-8-193f882b4182> in run_deep_dream_simple(img, steps, step_size)
     14     step += run_steps
     15
---> 16     loss, img = deepdream(img, run_steps, tf.constant(step_size))
     17
     18     display.clear_output(wait=True)

/usr/lib/python3.8/site-packages/tensorflow_core/python/eager/def_function.py in __call__(self, *args, **kwds)
    455
    456     tracing_count = self._get_tracing_count()
--> 457     result = self._call(*args, **kwds)
    458     if tracing_count == self._get_tracing_count():
    459       self._call_counter.called_without_tracing()

/usr/lib/python3.8/site-packages/tensorflow_core/python/eager/def_function.py in _call(self, *args, **kwds)
    501       # This is the first call of __call__, so we have to initialize.
    502       initializer_map = object_identity.ObjectIdentityDictionary()
--> 503       self._initialize(args, kwds, add_initializers_to=initializer_map)
    504     finally:
    505       # At this point we know that the initialization is complete (or less

/usr/lib/python3.8/site-packages/tensorflow_core/python/eager/def_function.py in _initialize(self, args, kwds, add_initializers_to)
    405     self._graph_deleter = FunctionDeleter(self._lifted_initializer_graph)
    406     self._concrete_stateful_fn = (
--> 407         self._stateful_fn._get_concrete_function_internal_garbage_collected(  # pylint: disable=protected-access
    408             *args, **kwds))
    409

/usr/lib/python3.8/site-packages/tensorflow_core/python/eager/function.py in _get_concrete_function_internal_garbage_collected(self, *args, **kwargs)
   1846     if self.input_signature:
   1847       args, kwargs = None, None
-> 1848     graph_function, _, _ = self._maybe_define_function(args, kwargs)
   1849     return graph_function
   1850

/usr/lib/python3.8/site-packages/tensorflow_core/python/eager/function.py in _maybe_define_function(self, args, kwargs)
   2148         graph_function = self._function_cache.primary.get(cache_key, None)
   2149         if graph_function is None:
-> 2150           graph_function = self._create_graph_function(args, kwargs)
   2151           self._function_cache.primary[cache_key] = graph_function
   2152         return graph_function, args, kwargs

/usr/lib/python3.8/site-packages/tensorflow_core/python/eager/function.py in _create_graph_function(self, args, kwargs, override_flat_arg_shapes)
   2029     arg_names = base_arg_names + missing_arg_names
   2030     graph_function = ConcreteFunction(
-> 2031         func_graph_module.func_graph_from_py_func(
   2032             self._name,
   2033             self._python_function,

/usr/lib/python3.8/site-packages/tensorflow_core/python/framework/func_graph.py in func_graph_from_py_func(name, python_func, args, kwargs, signature, func_graph, autograph, autograph_options, add_control_dependencies, arg_names, op_return_value, collections, capture_by_value, override_flat_arg_shapes)
    913                                           converted_func)
    914
--> 915       func_outputs = python_func(*func_args, **func_kwargs)
    916
    917       # invariant: `func_outputs` contains only Tensors, CompositeTensors,

/usr/lib/python3.8/site-packages/tensorflow_core/python/eager/def_function.py in wrapped_fn(*args, **kwds)
    356         # __wrapped__ allows AutoGraph to swap in a converted function. We give
    357         # the function a weak reference to itself to avoid a reference cycle.
--> 358         return weak_wrapped_fn().__wrapped__(*args, **kwds)
    359     weak_wrapped_fn = weakref.ref(wrapped_fn)
    360

/usr/lib/python3.8/site-packages/tensorflow_core/python/eager/function.py in bound_method_wrapper(*args, **kwargs)
   2656     # However, the replacer is still responsible for attaching self properly.
   2657     # TODO(mdan): Is it possible to do it here instead?
-> 2658     return wrapped_fn(*args, **kwargs)
   2659   weak_bound_method_wrapper = weakref.ref(bound_method_wrapper)
   2660

/usr/lib/python3.8/site-packages/tensorflow_core/python/framework/func_graph.py in wrapper(*args, **kwargs)
    894           # TODO(mdan): Push this block higher in tf.function's call stack.
    895           try:
--> 896             return autograph.converted_call(
    897                 original_func,
    898                 autograph.ConversionOptions(

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/impl/api.py in converted_call(f, options, args, kwargs, caller_fn_scope)
    532         ' the verbosity to 10 (on Linux, `export AUTOGRAPH_VERBOSITY=10`) and'
    533         ' attach the full output. Cause: %s', target_entity, e)
--> 534     return _call_unconverted(f, args, kwargs, options)
    535
    536   with StackTraceMapper(converted_f), tf_stack.CurrentModuleFilter():

/usr/lib/python3.8/site-packages/tensorflow_core/python/autograph/impl/api.py in _call_unconverted(f, args, kwargs, options, update_cache)
    324
    325   if inspect_utils.istfmethodtarget(f):
--> 326     return f.__self__.call(args, kwargs)
    327
    328   try:

/usr/lib/python3.8/site-packages/tensorflow_core/python/eager/function.py in call(self, args, kwargs)
   2618     if tf_inspect.ismethod(wrapped_fn):
   2619       wrapped_fn = six.get_unbound_function(wrapped_fn)
-> 2620     return wrapped_fn(self.weakrefself_target__(), *args, **kwargs)
   2621
   2622

<ipython-input-6-3ac13775042b> in __call__(self, img, steps, step_size)
     12       print("Tracing")
     13       loss = tf.constant(0.0)
---> 14       for n in tf.range(steps):
     15         with tf.GradientTape() as tape:
     16           # This needs gradients relative to `img`

/usr/lib/python3.8/site-packages/tensorflow_core/python/framework/ops.py in __iter__(self)
    545   def __iter__(self):
    546     if not context.executing_eagerly():
--> 547       self._disallow_iteration()
    548
    549     shape = self._shape_tuple()

/usr/lib/python3.8/site-packages/tensorflow_core/python/framework/ops.py in _disallow_iteration(self)
    538       self._disallow_when_autograph_disabled("iterating over `tf.Tensor`")
    539     elif ag_ctx.control_status_ctx().status == ag_ctx.Status.ENABLED:
--> 540       self._disallow_when_autograph_enabled("iterating over `tf.Tensor`")
    541     else:
    542       # Default: V1-style Graph execution.

/usr/lib/python3.8/site-packages/tensorflow_core/python/framework/ops.py in _disallow_when_autograph_enabled(self, task)
    514
    515   def _disallow_when_autograph_enabled(self, task):
--> 516     raise errors.OperatorNotAllowedInGraphError(
    517         "{} is not allowed: AutoGraph did not convert this function. Try"
    518         " decorating it directly with @tf.function.".format(task))

OperatorNotAllowedInGraphError: iterating over `tf.Tensor` is not allowed: AutoGraph did not convert this function. Try decorating it directly with @tf.function.

Thank you!

@1-willAll-0 I cannot reproduce the issue. I am using most recent tf-nightly. Please check the gist here. Thanks!

Thanks for the response, jvishnuvardhan.  Perhaps bugs are only relevant to post if I'm using the most updated version?  If so I won't post next time.  I did already mention I myself couldn't reproduce the issue in collab, so maybe that's a non-starter.
I don't want to start building now and disrupt the continuity of the managed bundles in Clear Linux, otherwise I'd be using 2.1.0.  As of now I'm on 2.0.0 and I have a workaround which may or may not pan out as I proceed.  I suppose this is because I'm running Python 3.8?

@1-willAll-0

Thanks for the response, jvishnuvardhan. Perhaps bugs are only relevant to post if I'm using the most updated version? If so I won't post next time. I did already mention I myself couldn't reproduce the issue in collab, so maybe that's a non-starter.

No. we encourage you to post issues with older versions also. I just checked with latest version to see whether the issue is still there in the latest version or not. I also checked with TF2.0 and TF2.1 and I cannot reproduce the issue as well. I noticed your note about colab.
Let me check with my laptop and respond to you soon. Thanks!

Ah, good to know!
Thanks for looking into it!

@1-willAll-0 On My MacBook Pro, I have install 2.0 and ran your code in the gist and I could not see any error with the code. Not sure why you are facing that issue. May be try uninstalling and reinstalling the TF and then check. Thanks!

I am closing this as this was resolved. Feel free to reopen the issue if this was not resolved for you. Thanks!


Too many pipes are spawned (flags CaptureInput without MergeStderr)

Pipes can be create both in procstreams builder and in childproc_posix :
(flags Captureinput and (Interactive or custom input) without MergeStderr flag).
https://github.com/Alogani/asyncproc/blob/fbea6d699c37f527c6fa88168fa59ea4d0c28ee9/src/asyncproc/private/childproc_posix.nim#L91

Fixed with version v0.3.1


Change annotations to annotate

Brings name of annotations metadata in line with AtScript spec by changing name to 'annotate'.
resolve #1642

signed CLA.

I'm going to close this and the bug until I hear from @mhevery or @IgorMinar.


Improve Type, fixes #1262

This PR migrates the protobuf generated code for SemanticDB Type to use an unmerged feature in ScalaPB called "sealed oneof" which translates a subset of protobuf "oneof" into idiomatic Scala sealed traits. Fixes #1262.
In a nutshell, it's far more ergonomic to work with scala.meta.internal.semanticdb3.Type now.
For example, to construct the type Array[Int]:
// before
Type(
  tag = Tag.TYPE_REF,
  typeRef = TypeRef(
    None,
    "scala.Array#",
    Type(tag = Tag.TYPE_REF, typeRef = TypeRef(None, "scala.Int#", Nil) :: Nil
  )
)
// after
TypeRef(NoType, "scala.Array#", TypeRef(NoType, "scala.Int#", Nil) :: Nil)

The generated protobuf sources are moved into version control for several reasons

So that generated sources are published as part of -sources.jar to Maven, fixes #1517
Make it possible to browse/search the generated code on GitGub
We don't have to wait for the ScalaPB PR https://github.com/scalapb/ScalaPB/pull/458, we don't rely on the implementation details of the code generation for "sealed oneofs" so we're fine if the PR still goes through several revisions.

Thank you for this PR @olafurpg! These are really nice ergonomic improvements for working with scalameta ❤


USE_ defines cause a warning

Steps to reproduce:

Make a new project
cmake -Hall -Bbuild -DUSE_CCACHE=ON

Expected output:
No warnings.
Actual output:
CMake Warning:
  Manually-specified variables were not used by the project:

    USE_CCACHE

Good catch! When the tools were originally written, they were intended to be included by the main library and needed to be excluded when used as a third-party dependency. As we are now only importing tools from subprojects, the restriction should not be necessary anymore.

On second thought, the flags we are setting should be scoped for the whole project, so the best solution would be to simply include the tools from the "all" subproject as well.


CenterArc fails to draw clockwise

given this code:
from build123d import *

with BuildPart(Plane.XZ) as clamp:

    with BuildSketch(Plane.XZ) as sketch_builder:
        with BuildLine(Plane.XZ) as shape:
            t0 = CenterArc((0, 0), 4, 0, 40)
            t1 = CenterArc((0, 10), 4, 0, -40)

        make_face()

show_object(t0.wrapped, name="segment a_start=0 dir=pos")
show_object(t1.wrapped, name="segment a_start=0 dir=neg")

I expect two segments of a circle painted on the XZ plane.
The arc at the coordinate root starting on the X axis counter clockwise 40°.
The arc 10 units above the coordinate root starting 10 units above the X axis clockwise 40°.
The first segment is rendered as expected, the second starts as expected at the expected position, but instead of "40° clockwise " "320° counter clockwise" are rendered.

Thanks.  The problem was in the direct api make_circle method and is now fixed:


Health scope should provide APIs that return descriptive errors when deployments fail

The health scope should have APIs that I can query after a deployment fails (and assuming the YAML was valid), that will describe to me what went wrong with the deployment.

For example, if I deploy an ApplicationConfiguration and there is an error, the Health Scope should be queryable and return information on which components failed to come up and some deeper information as to why.

kubectl describe healthscope  and it returns a description of the scope and the problems within that scope

I have given a PR(#473) to solve how we give errors back to the user. My answer is k8s events.
In that PR, I also give an example, when I deploy an appconfig with something wrong, I could use kubectl describe to see what's wrong.
$ kubectl describe cfg first-app
Name:         first-app
Kind:         ApplicationConfiguration
...
Spec:
  Components:
    Component Name:  helloworld-python-v1
    Instance Name:   first-app-helloworld-python-v1
...
Events:
  Type     Reason                                                                                Age   From  Message
  ----     ------                                                                                ----  ----  -------
  Warning  ApiError NotFound ("componentschematics.core.oam.dev \"helloworld-python-v1\" not found")  3s          creating AppConfig first-app error

Yeah, I know provide API from health scope is better, but I don't think this is a high priority issue.

I am troubleshooting a similar issue but no events at this point with the alpha 1 version. Any that I can get the warning events you got from k8s today? Mine is empty. No deployments for this instance yet.
kubectl describe cfg bikesharing-app
Name:         bikesharing-app
Namespace:    default
Labels:
Annotations:  kubectl.kubernetes.io/last-applied-configuration:
{"apiVersion":"core.oam.dev/v1alpha1","kind":"ApplicationConfiguration","metadata":{"annotations":{},"name":"bikesharing-app","namespace":...
API Version:  core.oam.dev/v1alpha1
Kind:         ApplicationConfiguration
Metadata:
Creation Timestamp:  2020-01-07T18:05:21Z
Generation:          1
Resource Version:    3149582
Self Link:           /apis/core.oam.dev/v1alpha1/namespaces/default/applicationconfigurations/bikesharing-app
UID:                 45010f4e-3178-11ea-a462-7a73f2d3d989
Spec:
Components:
Component Name:  bikesharing-ui-v1
Instance Name:   bikesharing-ui
Traits:
Name:  ingress
Parameter Values:
Name:        hostname
Value:       bikesharing.com
Name:        path
Value:       /
Component Name:  bikesharing-email-api-v1
Instance Name:   bikesharing-email-api
Component Name:  bikesharing-feedback-api-v1
Instance Name:   bikesharing-feedback-api
Component Name:  bikesharing-profile-api-v1
Instance Name:   bikesharing-profile-api
Events:


upstream: update header maps on response path

Signed-off-by: Mike Schore<EMAIL_ADDRESS>

Distributables compile; tests need to be updated.

Should be good to go now.


Better package installation watcher

Current watcher is fairly unreliable. We need better detection when package is installed so we can either reload modules properly or analyze new module at the time of installation so analysis is ready when user actually imports it.

Also, #984

https://github.com/acken/FSWatcher


CSV icon

Is it possible for you to add icons?
If so, can you please add an icon for CSV file format?
Thanks!

Merged


min_by and max_by Presto aggregates do not process extreme values correctly

Bug description
These aggregates initialize accumulators with min and max values, then update the accumulator only if input is > or < than current value. Thus, they fail to update the values if inputs are themselves equal to min or max.
CC: @majetideepak @bikramSingh91 @kagamiori @laithsakka @kgpai
Simple repro:
TEST_F(MinMaxByComplexTypes, limits) {
  static const auto kMax = std::numeric_limits<int64_t>::max();
  static const auto kMin = std::numeric_limits<int64_t>::min();
  auto data = makeRowVector({
      makeFlatVector<int64_t>({1, 2}),
      makeFlatVector<int64_t>({kMin, kMin}),
  });

  createDuckDbTable({data});

  testAggregations(
      {data},
      {},
      {"min_by(c0, c1)", "max_by(c0, c1)"},
      "SELECT min_by(c0, c1), max_by(c0, c1) FROM tmp");
}

System information
n/a
Relevant logs
No response

CC: @xiaoxmeng @spershin @amitkdutta @vermapratyush

CC: @aditi-pandit

This issue is caused by the initialValue_, it will be set to accumulator when initialization.
https://github.com/facebookincubator/velox/blob/9cbee26a68f49538b0019ff021482c169e1f5186/velox/functions/prestosql/aggregates/MinMaxByAggregates.cpp#L172-L174
For above test, initialValue_ is kMin, the reason for wrong result of min_by is current implementation use a strictly comparator, every coming value in lessThan(newValue, oldValue) return false, so accumulator will never be updated.
Use std::optional as accumulator initial value may fix this problem.
if (accumulator.hasValue()) {
    compareAndUpdate();
} else {
    update();
}

CC @mbasmanova

@Yohahaha Thank you for taking a look. Would you like to submit a fix?

@Yohahaha Thank you for taking a look. Would you like to submit a fix?

Sure, I will fix it.


Paths should default sort below highways

Eraser Maps is dealing with some strange sort issues on the Golden Gate Bridge. Turns out there are several features (some road, some path) and they are all getting the same sort order from the server.
It seems like the sort order for paths should be below roads, when a level hasn't been defined.

Example: http://tangrams.github.io/eraser-map/#18/37.81189/-122.47685

Fixed in https://github.com/mapzen/vector-datasource/pull/564.


[backport] Fixes an error on chainer.grad for multiple devices

Backport of #7692

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit f8e52341fd6142143991793b23b8990c50e69b0b, target branch v6) succeeded!

Jenkins CI test (for commit f8e52341fd6142143991793b23b8990c50e69b0b, target branch v6) failed with status FAILURE.


chore: update darvaza.org/core to v0.15.0 and fix make tidy

Summary by CodeRabbit

Bug Fixes

Improved error handling for duplicate horizon names in the Append method, simplifying error messages.

Chores

Updated the version of the darvaza.org/core module.
Streamlined command generation logic in the script, enhancing clarity and reducing redundancy.

v0.4.3 tagged


check deployment on kristoftest farm

@despiegk created a farm with 4 nodes and failing to deploy anything on them https://explorer.testnet.grid.tf

on zero-os tech channel
Zaibon, [14.09.20 14:43]
This farm is not ready yet
Zaibon, [14.09.20 14:43]
None of the node in there are ready to process reservation
@zaibon can you please specify how to get these nodes ready?

?

@zaibon can you please specify how to get these nodes ready?

As soon as we know I can tell yes. But at the moment we need at least on of the node to be rebooted. A direct access to the hardware could make us make faster progress too.

I see 2 nodes has been rebooted:
CS4jpDv1jZHVyvh5kjXcdVNE3zMFdUbobKT3BvEy9yyP looks fine
HWXeXnaa76NoTYxY75kwwnEDwe7KSuCXtich3pj37RSM seems to still have an issue.

this is no longer relevant. wrong farm config


Merge in various changes from kanzure and olsonse

@kanzure and @olsonse have made a few changes and fixed a few items over the past years.  These items had not been merged back into the SVN that was on code.google.com.  With the upstream of this project moving to github.com, it is desirable that the two lines get merged back.  We would appreciate if upstream would accept changes that are applied to a prior svn-to-git base, to preserve history.
Short summary of merged changes:

adds a .gitignore file
make "main" of ctypesgen.py be a callable function called 'main'
fix macro sub-calls; add lots of unit tests for these
append paths for finding libraries and ensure that they get converted to absolute paths (allows relative paths to be used)
ensure that only valid items can get marked as anonymous (following ctypes documentation that only structs and unions can be marked as anonymous)

The fixes here seem pretty large, important, and by now - urgent.
Is it recommended to use pip to install the version from olsonse (https://github.com/olsonse/ctypesgen) directly instead?

I have not tested installing this with pip from github--I rarely use pip.  That being said, I do agree that the changes included on my master branch are somewhat critical and urgent.  I do not mind keeping things updated for the foreseeable future, until something else comes along that is significantly better.

Hi,
Apparently, I hadn't noticed your changes - and went and probably fixed some of the same things you fixed, converted it to run under and generate python3-compliant code, and made all the tests run under tox, and reformatted everything to be uniformly formatted using the black formatter.
Is there any chance you can look at my branch, and see how hard it would be to put your changes on top of mine?  https://github.com/Alan-R/ctypesgen

I'm going to pull this one in - it definitely has fixes my branch doesn't have. Then I'll reformat to black, and see if any of my changes are needed any longer. Mine just concentrated on python 3 compliance and fixing some bugs that kept it from working with somewhat more modern C.

@olsonse, @kanzure, @olivierberten, @ZenithDK @davidjamesca:
This has been merged in and two other changes made on top of this:

Code was completely reformatted with 'black'. This will be a requirement going forward.
tests were moved to be a subdirectory in the package
I added tox testing to the code - and fixed an options problem which I presume was py26 incompatibility.

I haven't yet tested this with the Assimilation code (my project), but it passes all the tests in both py26 and py27. Please check and ensure that you're happy with it.


Feature/mc 9325

Dynamic Profiles.  Tests currently passing

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Every line is transformed as header element in markdown

Describe the bug
Thanks for this library. Very much helpful. I am seeing a weird issue. When parsing this PDF, each and every line is transformed as a header element instead of sentences/paragraphs. This issue is happening with original repo as well. Tested here: https://pdf2md.morethan.io/
To Reproduce
Steps to reproduce the behavior:

call @opendocsg/pdf2md in cmd line with the above file as input
Check the output

Expected behavior
Some of the text in the pdf, for ex: Selecting the “right” amount of information to include in a summary is a difficult task. A good... should not be treated as header
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: macOs
Browser NA
Version NA

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Since this issue exists in original repo, it will be great if you can point me how to resolve this issue. Appreciated!

I'm having this same issue on the latest version


Ask user for extension type

Hi There. 👋
I have added some new features and updated the readme.

Custom extension type when creating a temp file (mainly to test random code).
Open recently created temp files.
Allow the user to have a default extension type for the input prompt based on a new setting.

We can add a setting to skip the prompt if you feel it should be more direct.

Thanks, this looks great to me. Will merge this request.


First cut at a truss shell node command

To test, point your current kubectl context at nonprod-cmh (or any cluster), then:
# Pull the latest Truss CLI config
$ rapture wrap arn:aws:iam::127178877223:role/xacct/ops-admin truss get-global-config s3

$ kubectl get nodes # Copy one of the node names to use below
$ go run . -e nonprod-cmh shell node ip-10-12-11-61.us-east-2.compute.internal

To launch a general-purpose debug container, you can run truss shell -e nonprod-cmh.


Host header is always overwritten

Describe the bug
For some applications, e.g. Kubernetes, you need to be able to specify a custom host header. For the Kubernetes use case, it's so that the request can be routed appropriately. However, Drogon currently always overwrites the host header in HttpClientImpl.cc#L348-362.
Expected behavior
I'd like Drogon to check to see if the host header is already set before setting it. Alternatively, the host header setting code could be moved to the passthrough mode.
I can raise a PR for this if one of those solutions is acceptable.

@varunsh-xilinx Thanks so much for the feedback. You could make a PR for this. Thanks.


Sync 2201.4.0-stage with 2201.4.x

Purpose
$title

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.11 out of 12 committers have signed the CLA.:white_check_mark: daneshk:white_check_mark: Nadeeshan96:white_check_mark: NipunaRanasinghe:white_check_mark: IMS94:white_check_mark: niveathika:white_check_mark: Thevakumar-Luheerathan:white_check_mark: chiranSachintha:white_check_mark: warunalakshitha:white_check_mark: Dilhasha:white_check_mark: udda1996:white_check_mark: sameerajayasoma:x: Danesh KuruppuDanesh Kuruppu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Check links status

Check links status for all video and related_url and identify broken links (With a python script).

I am new the project and I am excited to contribute!

@lgh2 FYI, we're moving to pyvideo


Coral Micro with WiFi not able to flash again

Description
Hello,
I managed to write face detect sample on the board. Now sometime it boots sometime it hangs but I cannot reflash again.
This is the log I see in the serial attached to the RX/TX pins. I use a CP210x UART bridge
Multicore Model Cascade!
failed to read back country, returning default
WLAN MAC Address : 24:CD:8D:68:3E:8C
WLAN Firmware    : wl0: May  2 2019 02:46:20 version 7.45.189 (r714228 CY) FWID 01-105ab14e
WLAN CLM         : API: 12.2 Data: 9.10.136 Compiler: 1.29.4 ClmImport: 1.36.3 Creation: 2019-05-02 02:31:24

I tried both reset procedures but the board is not detected in my Ubuntu.
there are no Coral or other devices detected in the lsusb command.
When I enter in the flash mode there is no log in the serial console.
I tried to connect the board on Ubuntu and Windows 10, I changed multiple USB cables to check but it seems it is not detected.
$ uname -a
Linux bogdan-ThinkPad-X240 6.2.0-32-generic #32~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Fri Aug 18 10:40:13 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
Is it possible to flash the board usinf the Serial console?
Thank you,
Bogdan
Click to expand!
Issue Type
Support
Operating System
Ubuntu
Coral Device
Dev Board Micro
Other Devices
No response
Programming Language
Other
Relevant Log Output
Multicore Model Cascade!
failed to read back country, returning default
WLAN MAC Address : 24:CD:8D:68:3E:8C
WLAN Firmware    : wl0: May  2 2019 02:46:20 version 7.45.189 (r714228 CY) FWID 01-105ab14e
WLAN CLM         : API: 12.2 Data: 9.10.136 Compiler: 1.29.4 ClmImport: 1.36.3 Creation: 2019-05-02 02:31:24
Multicore Model Cascade!
Multicore Model Cascade!
failed to read back country, returning default
Multicore Model Cascade!
failed to read back country, returning default

bogdan@bogdan-ThinkPad-X240:~/coralmicro$ lsusb
Bus 001 Device 002: ID 8087:8000 Intel Corp. Integrated Rate Matching Hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 003 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 002 Device 005: ID 5986:0268 Acer, Inc SunplusIT INC. Integrated Camera
Bus 002 Device 004: ID 8087:07dc Intel Corp. Bluetooth wireless interface
Bus 002 Device 040: ID 138a:0017 Validity Sensors, Inc. VFS 5011 fingerprint sensor
Bus 002 Device 042: ID 0bdb:193e Ericsson Business Mobile Networks BV N5321 gw
Bus 002 Device 049: ID 10c4:ea60 Silicon Labs CP210x UART Bridge
Bus 002 Device 048: ID 1a40:0101 Terminus Technology Inc. Hub

USB-C cables are the cause. Found a thicker and shorter one which works fine.


feat: update retry methods and queries on sql repository

@jrobinAV I think Im not gonna merge this PR while we discuss about removing sql.

All right. Sounds fair.

Since we decided to remove the sql option for repository type, should we close the PR and delete the branch ?

Closing this since we decided to remove SQL Repository


Consider using Vault Validation

https://jackrabbit.apache.org/filevault/validation.html

closing as stale


Add docs for installing in Linux

Installation and basic usage instructions for linux.

@jorgebay will you be merging this PR, or updating it again, or...? If I have comments/edits, do you want them against this PR?

@tanberry yes, please send comments/suggestions over this PR.

I've addressed the suggestions, I'll merge it as it's a good starting point for the beta.


Facebook Account Kit integration

Would be nice if we could get Account Kit integration in the plugin as well. I would love to contribute. React Native have it  already.

Hi @albe-rosado, this sounds like a great idea. Do you think that Facebook Account Kit should be incorporated in this plugin? How about separate plugin for Facebook Account Kit?

I'm also interested in a plugin for the Facebook Account Kit. Maybe as a separate plugin would be nice.

+1

Another plugin... not done yet, I guess... will have to dig and do it ourselves 👍

@velchev You can use the plugin seed as a starting point:)

In the making,
https://github.com/rajivnarayana/nativescript-facebook-account-kit.
https://www.npmjs.com/package/nativescript-facebook-account-kit.
@radeva, Did use the plugin seed as a starting point.
Ran into issues where I could not set properties on iOS for and had to [NSObject performObjectWithSelector] and [NSInvocation invocationWithMethodSignature] etc. Resolved them and am successfully able to receive code to phone and eventually get an auth code.
Would some body like to contribute? I can bring in simple UI customization by myself but I would like to have contributions to support advanced UI via {N}.
@albe-rosado?


Fixing error with host network mode on upgrade from pre 17.06 versions

This commit contains the following fixes:

On upgrade from pre 17.06 version services created with net=host
were failing because the swarm was not aware of host network being
created. The fix added takes care of this by creating network if
the store does not contain predefined networks

On a cluster with upgraded 17.06 version of docker swarm manager
the daemon panics while trying to access IPAM driver in the createNetworkRequest on
the nodes with pre 17.06 versions. In order to avoid panics empty struct is passed
with network attachment. This does not have any function impact.

Signed-off-by: Abhinandan Prativadi<EMAIL_ADDRESS>

Thanks @abhinandanpb .
LGTM
This PR prevents worker panic running older versions (17.05 and lower) when the user executes docker service create --network=host xxxxxx.

LGTM


添加北京国槐信息科技有限公司

北京国槐信息科技有限公司
Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues

Bug fix

Bug description.

How to fix?

New feature or improvement

Describe the details and related test reports.

Ref to #443 Thanks for sharing. FYI @apache/skywalking-committers

Coverage increased (+0.003%) to 12.303% when pulling 37ea7fc283529de6589d97af38460168e3de1b9c on justeene:patch-1 into 2b1ad220df84c79044e2ac42f2aeaaf137f19e06 on apache:master.


Cancelled InventoryClickEvent resets slot in new inventory

Open a custom inventory.

Click on a slot in the inventory and cancel the resulting InventoryClickEvent.
Open another custom inventory in the InventoryClickEvent handler.
The item from the slot you clicked will be placed in the same slot in the newly opened inventory.

Related to #1175 and #1045.
Verified on SpongeVanilla 1.11.2-6.0.0-BETA-228.

Duplicate of #1175.

Fixed in commit https://github.com/SpongePowered/SpongeCommon/commit/2406e2f0114c0955b0910dff7001456a9a1e1b52


Simplify Project Template: DpiAwareness in app.manifest

This PR fixes microsoft/microsoft-ui-xaml#5659
Basically, the DPI awareness settings in the project template are needlessly complicated.
Those complicated settings are recommendable if old versions of Windows are supported, however WindowsAppSDK requires Windows 10 1809, which easily supports the most modern setting.

Can I do anything else to get this merged? Please take this into consideration. //cc: @andrewleader

@evelynwu-msft would this be your area? Or who would own this?

No, I have no particular expertise to judge whether or not it is the correct thing to do (although it seems reasonable enough). @MikeHillberg what are your thoughts on this?

Hi @MikeHillberg and @Scottj1s! What are your thoughts?


Todo List + Beginner Issues

These are just few ideas or bugs I know right now. I will keep updating the list. Before starting anything, create an issue and await instructions. Feel free to suggest any features or bug fixes
Simulator

[x] Counter
[ ] Decimal to BCD and vice versa
[ ] Combinational Analysis - Make it easier to give input.
[x] 7 Segment - change color
[x] Add undo - redo buttons
[ ] Undo - fixes - combinational and new project loaded: call backup()
[ ] Test and Fix shortcuts in firefox
[x] Move from this to prototype
[x] Complete Plotting implementation
[ ] Disable copying / combinational circuits according to assignment preferences
[x] Watermark with link in embed - outside only
[ ] Add scroll bar to sidebar
[ ] Add a link to assignment desription on the simulator page
[ ] Enable minimap to show rotated elements
[ ] Fix Trivial cases - constant and Z state in combinational analysis
[x] Configure shortcuts for Zoom/save online
[ ] Setup a good offline backing of circuits

bug fixes

[x] Save empty circuit causes problems
[ ] Subcircuit of empty circuit causes problems
[x] Image of empty circuit causes problems
[ ] Undo after deleting subcircuit (ie main circuit was deleted) causes problems.

Ambitious Features

[ ] Expresso - replacement of combinational analysis
[x] Custom layout for sub circuits - logisim does a brilliant job at this
[x] Write Test suite for simulator

Website - rails + normal front end

[ ] Configure back button correctly
[x] Flash messages ( notice ) not configured correctly
[x] Assignment Grading system
[ ] Customize Dashboard
[ ] Add shortcuts to getting started page
[ ] Add a link to view project in assignment page
[x] Trending and Featured sections
[ ] Preview should go full screen
[ ] Email for assignment submissions for students. Assignment report for mentor
[x] Use CSS and beautify email
[ ] Follow users ( probably later )
[x] Write Test suite for backend
[x] Countries and University - to users
[ ] Add shortcut on homepage for pending assignments
[ ] Add shortcut on simulator page for assignment description

Others

[ ] Powerpoint Plug-In

Documentation
This involves a full documentation of all circuit elements. It shouldn't take more than a days work. It is important to someone who comes to our website and has little knowledge of the various components.
Things to document.

What the element does
Truth table if applicable
Small demo
Uses of the element
Further reading resources

I have fixed a bug related to saving an empty circuit. Kindly review and inform me if everything is correct.

Can we split these issues into separate github issues

Can we split these issues into separate GitHub issues

Yes, we need to kill this issue and split it across separate issues. Some of these are resolved and need to be marked as completed.

@satu0king I can help with the documentation part, can you guide me how to get started after setting up of my development environment?
From what I have understood I think you need a separate webpage with description of all elements on your site. Am I right?

@satu0king I can help with the documentation part, can you guide me on how to get started after setting up of my development environment?
From what I have understood I think you need a separate webpage or a pdf with a description of all elements on your site. Am I right?
I am making the documentation content like this: https://docs.google.com/document/d/1i9JRlZcfrVNDnx7fDwTlFFkjljNuadqTgiHGCAHxt0A/edit?usp=sharing
Please have a look.

We already have a documentation: docs.circuitverse.org
See https://github.com/CircuitVerse/CircuitVerseDocs

I would love to work on the assignment grading system.. am currently working on an LMS system, I have a bit experience in this area. but I need more details on this issue. is there a requirement or a story I can get more info on what to do?

Hey it's my first time, I'd like to work on decimal to bcd and vice versa. Please help me out.

Hi!! this is the first time i'm contributing somewhere i would love to try my hands in documentation please guide me how to get started!!

Hey @satu0king Sir the Redo option is not available in the menu yet. I would like to give a try to it .

Hello, where is the shortcut to getting started required?

@satu0king  Can i add breadcrumbs to the website that will make navigation easier from one page to another?

I would like to contribute to this issue.
Is the issue open?

@satu0king I would like to work on the task Decimal to BCD and vice versa  please assign it to me,

@satu0king  i would like work and contribute on "configure back button "  can i work on it

@satu0king I would like to work on the customization of dashboard. Can I go ahead?

@satu0king I would like to work and contribute on 'Add shortcuts to getting started page' and/or 'Preview should go full screen' . Can I go ahead?

@all this is an old Issue created 2 years back. I don't know if these are relevant anymore. Check if they are relevant and create a new issue to work on them.

@satu0king  i would like to work and contribute to 'Add scroll bar to sidebar' . can i go ahead ?

Hi sir/mam, I am utkarsh, new to open source, and looking forward to enhancing and learning new skills and gaining some experience. And I would love to contribute to your organization.  Since I had used circuit verse in my 2nd semester for my electrical lab I am a bit familiar with it so, can I work on ''Decimal to BCD and vice versa'' please?

Hi! I am new to opensource can anyone suggest from where I should start my journey?

@satu0king Sir I am new to opensource I want to work on Decimal to BCD and vice versa. Can you assign me this.

@satu0king  If the issue is still open, I would like to work on it.

If you want to work on any of the above tasks, create a new issue and refer that issue from your PR. Also ensure that issue is not created before to avoid duplicates

Hey @satu0king could you please update this list or it's already been updated ?

Hello! Can I work on this issue or it is already assigned?

If you want to work on any of the above tasks, create a new issue and refer that issue from your PR. Also ensure that issue is not created before to avoid duplicates

@akashroy1 yes you can go ahead, please follow this instruction

Thanks for your reply.
On Wed, Feb 9, 2022, 5:19 PM Palak Sharma @.***> wrote:

If you want to work on any of the above tasks, create a new issue and
refer that issue from your PR. Also ensure that issue is not created before
to avoid duplicates
@akashroy1 https://github.com/akashroy1 yes you can go ahead, please
follow this instruction
—
Reply to this email directly, view it on GitHub
https://github.com/CircuitVerse/CircuitVerse/issues/2#issuecomment-1033676272,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASO7HHMEU6E3C4XLJD67PB3U2JIDHANCNFSM4F5T47VA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

i want to work on this issues. Please assign me this issue

Hey @satu0king , I would like to work on this issue This would be my first contribution, I want to work on this issue, Please assign This to me.

@Nikuunj   To begin working on any of the mentioned tasks, open a new issue and refer to it with your PR. Also, ensure that the issue is present right now.

@satu0king  Hi! I would like to work on this issue. The problem seems to be with the undo functionality after a main or subcircuit is deleted. I will investigate how the undo feature interacts with these deletions and make the necessary fixes to ensure it works as expected.
I will also run tests to verify that the fix works properly and ensure compatibility across different browsers.
Looking forward to working on this!


Add support for Cache-Control: immutable

If the maxAge option is set to Infinity then the resulting header will be set:
Cache-Control: public, max-age=31536000, immutable

Resolves https://github.com/expressjs/express/issues/3197

So after some (light) reading, I realize (and I don't think I did before) that "immutable" is actually useful for any cache duration, so saying max age 4 hours + immutable is a valid configuration. I am going to land this still, still with full credit to @jcready , but with the following API change: instead of { maxAge: Infinity } = add immutable flag, a new immutable option will be added, with the default as false, such that { immutable: true } = immutable (and you can do { maxAge: '4h, immutable: true }).

Another option, just to throw it out there (though it's high visibility), is to actually deprecate the maxAge option and have cacheControl accept an object so you can { cacheControl: { maxAge: '4h' } } or { cacheControl: { maxAge: '6h', immutable: true } } or some other combination.
I'm not 100% sure how I feel about deprecating the maxAge option since it's been here for so long. Perhaps deliver the separate { immutable: true } option now and in a later release deprecate both maxAge and immutable to move them into cacheControl 🤔

Now I’m curious, how is “immutable” useful for any cache duration? Could you point me to what you were reading?

I was specifically reading through the Firefox bug for the implementation: https://bugzilla.mozilla.org/show_bug.cgi?id=1267474 and MDN https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control
Basically, it is a directive that tells the web browser that, if the browser has a valid cached version (which means it needs to have some directive to tell it to cache the response), it will just not send the revalidation requests until the resource expires out of the browser's cache.

Interesting. I had (I guess incorrectly) assumed that “immutable” meant the resource could never change and that the maxAge part of it was only a fallback for clients that didn’t support the immutable part of the directive.

Yea, I had the same assumption as well.


Update the Cloud screenshot on the IaC page to a stylized screenshot

This pull request replaces the Pulumi Cloud screenshot on the Pulumi IaC page with a stylized screenshot of IaC in Cloud.

Added the stylized screenshot to the IaC page, /product/infrastructure-as-code/.


Automatigically handled sealed traits whose implementations are case classes

@ochrons You told me to keep ideas coming, so here's one.
I'll be honest: this is out of my reach and I wouldn't be able to contribute it, so I'll perfectly understand if you decide ditch it.
Quite often, I have some sealed abstraction (trait or abstract class) where all the implementations are case classes. Currently, I have to write Picklers and Unpicklers all the way down to deal with the abstractions, which is simple yet boilerplate.
With macros, it's possible to enumerate the implementations of a sealed trait, here's an example. So, based on this, it could maybe be possible for Boopickle to automatically generate the Picklers and Unpicklers implementations for such hierarchy.

Yeah, this is how uPickle does it, but it doesn't always work and produces weird problems and compiler errors. Doesn't the CompositePickler work for you in these cases?

Thanks, CompositePickler mostly did the trick, sorry for the noise.
The only limitation I found is that I sometimes had to explicitly expose the CompositePickler's pickler and unpickler for types that are deep in the tree. Still trying to figure out a simple test case.


font-size

Issue Type: Bug
Hey guys. The latest upgrade (May) changed the application's font family to use my system font but whenever the font size is wrong. It does increase or reduce when i make the changes on my system
VS Code version: Code 1.46.0 (a5d1cc28bb5da32ec67e86cc50f84c67cc690321, 2020-06-10T08:59:04.923Z)
OS version: Linux x64 5.3.0-3-amd64

System Info

Item
Value

CPUs
AMD A6-6310 APU with AMD Radeon R4 Graphics (4 x 2028)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: disabled_off_okvideo_decode: unavailable_offviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
4.77GB (0.15GB free)

Process Argv
--no-sandbox --unity-launch

Screen Reader
no

VM
0%

DESKTOP_SESSION
deepin

XDG_CURRENT_DESKTOP
Deepin

XDG_SESSION_DESKTOP
deepin

XDG_SESSION_TYPE
x11

Extensions (11)

Extension
Author (truncated)
Version

code-gnu-global
aus
0.2.2

vscode-eslint
dba
2.1.5

gitlens
eam
10.2.2

code-runner
for
0.10.0

rest-client
hum
0.24.1

cpptools
ms-
0.28.3

debugger-for-chrome
msj
4.12.8

vscode-react-native
msj
0.16.0

LiveServer
rit
5.6.1

vscodeintellicode
Vis
1.2.8

vscode-icons
vsc
10.1.1

/duplicate https://github.com/microsoft/vscode/issues/10144
cc @kdrag0n

@bpasero If possible, please unlock the conversation in #10144. I noted it has gone read-only now.

Continuing here since #10144 is read only. I still consider this a problem. We have changed now to a behavior that is much harder to override. It might be a great change for 90% of the users, but it's quite annoying for the other 10% of us. I am still on the old version of VS Code until this can be properly resolved.
I think it could also be resolved by a custom fontconfig config file. Might look into it some day. Of course, #519 would be the long-term fix.


kamelet-binding : suport for error handling

We should support setting-up an error handler, like:
apiVersion: camel.apache.org/v1alpha1
kind: KameletBinding
metadata:
  name: telegram-text-source-to-kafka
spec:
  source:
    ref:
      kind: Kamelet
      apiVersion: camel.apache.org/v1alpha1
      name: telegram-text-source
    properties:
      botToken: the-token-here
  sink:
    ref:
      kind: KafkaTopic
      apiVersion: kafka.strimzi.io/v1beta1
      name: my-topic
  error-handler:
    ref:
      kind: Kamelet
      apiVersion: camel.apache.org/v1alpha1
      name: retry-handler
    properties:
      ...

/cc @nicolaferraro

/cc @nicolaferraro

I am having a look at it

Is there wat to distinguish types of errors that might trigger an error handler in the first place? Thinking about something like this:

Failure: External behavior is incorrect
Fault: Discrepancy in code that causes a failure.
Error: Human mistake that caused fault

Not sure about the underlying details of Camel, but we may think of giving the user the possibility to chose what to do based on the specific exception caught. Maybe the same try-catch could work out of the box if used in the steps. However I think it defeats the concept of hiding the complexity behind the scene as the user must know the java exception type that may be thrown. We may consider come back to this as advanced feature in a future refinement.


Instructions on local jaeger

Currently Jaeger has the advantage of correlating traces from all Pulumi sub-processes. Linked pulumi/pulumi#7109

@viveklak following up on our discussion, here is a method that works today to explore correlated sub-process traces. I'll await review here on whether we want this exposed in public docs, if not, this will move to internal wiki until we can fix the default appdash-based tracing to work equally well.

I do think that we should add this
I also think that it would probably be worth having the CLI serve a collection endpoint and plumb that endpoint through to its subprocesses s.t. we can collect the same data when tracing to a file.

Yeah no concerns merging this. Also agree with Pat's propoosal to add a collection endpoint to the CLI. Could you cut a ticket to track that?

It think it's https://github.com/pulumi/pulumi/issues/7109 - I probably can take care of this shortly.


Harden all transport code for transient errors

Find every call in Defer/CompleteAsync() that could fail, and put decent error handling & logging around everything

Tasks

[ ] Azure Service Bus listener
[ ] Azure Service Bus sending protocol
[ ] SQS listener
[ ] SQS sending protocol
[ ] Rabbit MQ sender
[ ] Rabbit MQ listener
[ ] ISenderCallback.MarkSuccessfulAsync() -- all implementations
[ ] ISenderCallback.MarkProcessingFailureAsync() -- all implementations


[docs] Provide an alternative solution to defaultProps

Duplicates

[X] I have searched the existing issues

Related page
https://mui.com/material-ui/customization/how-to-customize/#2-reusable-component
Kind of issue
Other
Issue description
One pattern I really enjoy when working Mui is creating custom components that have zero new JS code, but are instead just configurations of existing Mui components, for example:
const Main = styled(Box)`
  width: 100%;
  display: flex;
  flex-direction: column;
  justify-content: flex-start;
  height: calc(100vh - ${HEADER_HEIGHT}px);
  margin: 0 auto;
  max-width: ${({ theme }) => theme.breakpoints.values.xl}px;
  padding: ${({ theme }) => theme.spacing(1)};

  ${({ theme }) => theme.breakpoints.up("md")} {
    padding: ${({ theme }) => theme.spacing(2)};
  }
`;

Main.defaultProps = {
  component: "main",
} as BoxProps;

The problem is that when doing that we are now getting this heads up:
Warning: Styled(ForwardRef(IconButton)): Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.
    at /Users/pedro/dev/chair-flight-monorepo/node_modules/.pnpm/@emotion+react@11.11.0_@types+react@18.2.6_react@18.2.0/node_modules/@emotion/react/dist/emotion-element-48d2c2e4.cjs.dev.js:70:25

Which is fair, React core team have been warning this feature will be gone any time for the past 5 years.
So now I'm searching for  a more elegant way to achieve the same functionality?
The proposed solution becomes really cumbersome really fast, if one wants to maintain the low level API of the original component, specially in TS (pass the ref, override the props, blergh...).
const Main = styled(forwardRef<HTMLDivElement, BoxProps>(
  ({ component = "main", ...props }, ref) => (<Box
    component={component}
    ref={ref}
    {...props}
  />)
))`
  width: 100%;
  //... more stuff
`;

Context 🔦
No response

I don't think we should offer solution to this problem as part of the library. I would recommend creating your own thin wrapper around the styled() util that will do this (accept the default props and merge them with the component props).

Hi @mnajdova
Sorry I missed your reply.
I totally get where you are coming from. Nonetheless, I would like to know if you are open to consider an API change that would make this a bit more practical. IMO it's a great pattern that is being set for extinction and makes me a bit sad :(
I will try to work on something from my side and will  post something more concrete when ready.


Fetch the metrics snapshot before killing the daemon and upload

Issue summary

It could be useful to see the metrics snapshot in the sync check report, together with the daemon log.
We can also do some checks on the metrics log, e.g. process memory usage, open fd, all libp2p protocols have successful message exchange, etc
Other information and links

endpoint: http://localhost:6116/metrics

Snapshot service discontinued in favour of the ChainSafe infra snapshot service.


Missing class in sample (UsersViewBinding)

I managed around it, but your sample is missing a class.
net.droidlabs.mvvmdemo.databinding.UsersViewBinding

I'll check this.

I gotta comment on this. This isn't a bug. This is part of binding, check this link: https://developer.android.com/tools/data-binding/guide.html#binding_data.
When you build the project, it will generate the necessary binding classes. For this sample, it will generate the UsersViewBinding.


fix filename issue; add uploaded listener when file has been uploaded

the key object is wrong when using file as the parameter meanwhile it's necessary to add uploaded listener when the ali oss upload file finish

@mackwan84  Please take a look at this commit. Thanks.


Bump controller manager memory request and limit

Based on the measurement the main memory cost occurs at the startup of the controllers later during deployment of openstack services the operator memory consumption is fairly steady.
The measurements shows that the current operator consumes close to 120Mi memory after init. So the resource request of the operator is bumped to from 64Mi to 128Mi and the limit is bumped from 128Mi to 256Mi.
This was needed as we observed random OOM kills during operator startup.
Related: https://issues.redhat.com/browse/OSP-25984

/test octavia-operator-build-deploy-kuttl

/retest

@gibizer We can try rebasing this and retesting now that https://github.com/openstack-k8s-operators/octavia-operator/pull/146 has merged

pushed the rebase

/test octavia-operator-build-deploy-kuttl
Seems like an infra issue:
oc project openstack
error: unable to default to a user name: the server is currently unable to handle the request (get users.user.openshift.io ~)

The kuttl test actually passed. So I'm not sure why the job failed
=== CONT  kuttl
    harness.go:405: run tests finished
    harness.go:513: cleaning up
    harness.go:570: removing temp folder: ""
--- PASS: kuttl (124.95s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/octavia_scale (114.07s)
PASS

/test octavia-operator-build-deploy-kuttl


[WIP] common: call syscalls via Api::OsSysCalls and not directly.

Risk Level: Low
Testing: bazel test //test/...
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Piotr Sikora<EMAIL_ADDRESS>

This is still WIP, since that's not the only instance of syscall being called directly.
2 questions:

Should we move all socket syscalls to Api::OsSysCalls or only those that need to be mocked in tests?
Any preference for:

Api::OsSysCallsSingleton::get().close(fd_);

vs
auto& os_syscalls = Api::OsSysCallsSingleton::get();
os_syscalls.close(fd_);

?
The latter is currently used in the codebase, but I personally find the shorter version more readable.
cc @mattklein123 @ggreenway

Should we move all socket syscalls to Api::OsSysCalls or only those that need to be mocked in tests?

I'd prefer all of them, but if you only want to touch the part you need for now, that's fine with me.

Any preference for

If it's only used once in a function, I prefer the 1-liner. If there are multiple calls in a function, I prefer the separate ossyscalls reference 2-liner.

Agree with @ggreenway

+1
Also I'd page @dwallacelf for visibility as it will affect VPP work, but that's not autocompleting so I'm not sure it'll tag him in.


Clean repo

Done.
The commands to run:
cd turms
git filter-repo --analyze
cat ./.git/filter-repo/analysis/path-deleted-sizes.txt | tail -n +3 | awk '{ print $4 }' > files-to-delete.txt
git filter-repo --invert-paths --paths-from-file files-to-delete.txt

The deleted files:
files-to-delete.txt


mulle-sde test init does not use PREFERRED_STARTUP_LIBRARY

Should have used MulleObjC-startup but used Foundation-startup.

Fixed


PR build for Linux Java 11 with Spark 3.4 is not running

Describe the bug
The github action PR build for Linux Java 11 with Spark 3.4 is not running
Steps to reproduce
Looks like the variable substitution is not working, i.e. PR Build / ${{ matrix.os }}/java ${{ matrix.java_version }}-spark-${{ matrix.spark-version }}/${{
Expected behavior
We should run tests for Java 11
Additional context
No response

Thanks @advancedxy Do you know the original reason why this specific combination was excluded by any chance?

Thanks. Looks like this is the history https://github.com/apache/datafusion-comet/pull/122
We can keep it as is for now. Closing


docker/docker-compos images are always pruned

Describe the bug
In the lifecycle of the docker plugin, the finalize step calls 'docker image prune --all --force' which would unconditionally remove all unused docker images whenever the docker plugin is asked to 'install/remove' something.
Expected behavior
ThinEdge should not remove things it was not asked about.

The same is true for the docker-compose plugin.

I agree that pruning all the images on install/remove is a cause of bad surprises.
I also wonder if this is the right place for these Docker and Docker Compose plugins. They are examples after all.

AC

Fix the reported issue.
Then move docker and docker-compose plugins to the example repo.
Update tests using docker and docker-compose plugins from the example repo.

A new sm-plugin has already been created to support container management, see the tedge-container-plugin repository.
So all that is left is to remove the docker and docker-compose plugins from the project.

Closed as the docker and docker-compose plugins have been removed from the project #2016


Adds note about deploys not working

I thought linking to an issue with the current workaround would be less brittle than documenting everything in the readme, so I opened #1077.

👍


[REEF-344] Cleaned up LibLoader

After this change, LibLoader will only load the Bridge DLL from the reef/local or reef/global folder. Preference is given to reef/local.
If the DLL is found but can't be loaded, the bridge will now crash. This is to avoid situations in which users believe they load the version in reef/local while the system in fact silently switches to reef/global.
Loading the DLL from the REEF JAR is no longer supported after this change.
JIRA:
REEF-344

I've tested this with the .NET tests on my laptop. However, it would be good to get independent confirmation that this doesn't break tests.

I will look at and test it.

I completed my pass. Reef .Net test passed.

Thanks, @jwang98052
I addressed your comments in the latest commit.


Update Nutanix Cluster API Provider to v1.2.1

Release notes for v1.2.1 https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/releases/tag/v1.2.1

/assign @abhinavmpandey08


Support Aliyun Oss

Will you support Aliyun Oss ?
https://www.alibabacloud.com/en/product/oss
I try with thanos, it's not working yet, would like to see Thanos supporting it.

Nothing will be done without community support, so if you want it, you can help writing down the adapter for it. See steps here: https://github.com/improbable-eng/thanos/blob/master/docs/storage.md#how-to-add-a-new-client
Plus we need someone who will be ok to maintain that code (:

Anyone working on this? If not, I'd like to take this

@yeya24 Thanks for your help! Maybe it will improve practice for Thanos in China.

Cool...

I have implemented  Aliyun OSS objstore .

@SecretSun Now Thanos supports Aliyun OSS, further information is here.


Falling thru ground?

Hello, i made my character a mesh with a rig and when i play it falls through the ground? How do i fix it and why does it occur

attach a collider to the ground. if you already have a collider on it, make a layer called "Ground" and layer the floor as "Ground". that should work. unless yur using a plane. if yur using a plane, switch it out for a cube

did it work?

lol


Document how to change java package

Minecraft 1.20.5+ requires Java 21, but jre_headless in nixpkgs 23.11 is Java 19. This causes the server to fail to start with an error like
net/minecraft/bundler/Main has been compiled by a more recent version of the Java Runtime (class file version 65.0), this version of the Java Runtime only recognizes class file versions up to 63.0

This can be fixed by overriding the jre_headless input to the desired server package like
package = pkgs.fabricServers.fabric-1_20_6.override {
  jre_headless = pkgs.temurin-jre-bin-21;
};

Maybe this could be made more convenient with some kind of javaPackage option? Either way, it would be great to document a recommended approach.
I see that you probably already noticed some related issue here with https://github.com/Infinidoge/nix-minecraft/commit/d9ca459b3b87d2639407cef26bb8e94a1314f40e.

Yeah, I did notice this issue, which ended up being """fixed""" by me bumping the nixpkgs revision both for nix-minecraft and in my system configuration. Ideally this should be fixed by requesting the proper version in nix-minecraft explicitly, as opposed to setting it. (I.e., nix-minecraft will explicitly gran jdk 8/17/21 instead of 8 or 'latest')


Allow nil service_offering_icon_id when creating a portfolio_item

Currently this will explode if the service_offering_icon_id is nil since we were assuming all service offerings have icons. This isn't the case and could potentially cause problems in the future.

@miq-bot add_reviewer syncrou


cigarette pack is too big inside

maybe make only cigs whitelist?

maybe make only cigs whitelist?

good idea

Things people put in their cig packs irl... Cigs, lighters, matchbooks, joints, cash, IDs.

i think you cn close it now


Questions about adding more envs

Hello, I try to add more tasks on Maniskill2 to your env. However, in Maniskill2 repo, I can't find any version that matches your code, can you provide the way that you get your env code. Thanks!

Hi, thanks for your question! When we started this project, ManiSkill2 was at version 0.5.3. You can find their source code at this branch.

I find version 0.5.3, but it seems your env code is not totally identical to the repo. Do you make some minor change to adapt your experiment (one thing I find is that set random seed) ?

Yes. We made some minor modifications to satisfy our evaluation experiments, but I think it's also okay to use the original environments.

Ok, thank you!


Datetime validation without offset should allow omission of Z zone designator

ISO-8601 allows datetime strings to not have any timezone offset or Z zone designator. In these instances, it is assumed to be in local time. (Reference: https://en.wikipedia.org/wiki/ISO_8601#Local_time_(unqualified))
However, the datetime validator currently marks these as invalid.
const schema = z.string().datetime() // offset: false is default behavior
console.log( schema.safeParse( '2022-01-01T00:00:00' ).success ) // false

I've opened PR that adds optional support for local (unqualified) date times here #2913

My workaround is just to refine for now. This also makes seconds optional.
const Timestamp = z
  .string()
  .refine(
    (value) => value.match(/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}(:\d{2}(\.\d+)?)?$/),
    {
      message:
        "timestamp must be of the unqualified form yyyy-mm-ddThh:mm[:ss[.mmm]]",
    },
  );

This is an issue as well for us, dealing with OpenAPI datetime fields.
We are using zod-to-openapi to build clients for services we use - it sees an OpenAPI schema like "type": "string", "format": "date-time" and turns it into z.string().datetime({ offset: true }) - which is technically correct.
But we have an API that actually returns a datetime with no trailing Z - so when we query it, the zodios API throws a validation error as it's not a valid ISO8601 (well, really rfc3339) datetime.
The root problem is that API - but having a workaround in Zod would be very useful.

This is almost a year old. Please prioritize this Zod team. I'm here because Zod validation is failing on dates coming from our ERP system.

This is available in canary and will land in Zod 3.23.

If you also land here and wonder why this is closed but still doesn't work and there is nothing about it in the documentation:
add flag: { local: true }
This is mentioned (only) in the release notes for v3.23.0:
You can now allow unqualified (timezone-less) datetimes using the local: true flag.
const schema = z.string().datetime({ local: true });
schema.parse("2022-01-01T12:00:00"); // OK

Thanks for calling this out @plehnen. I opened a PR to update the docs: https://github.com/colinhacks/zod/pull/3760


Debugging async/await Typescript with @babel/register doesn't work

Issue Type: Bug
In the latest version, it seems the VS Code debugger doesn't play nice with @babel/register along with @babel/plugin-transform-typescript. I believe this bug wasn't present in v1.41.0.
// main.js

require("@babel/register")({
  presets: [
    ["@babel/preset-env", {
      targets: { node: "current" }
    }]
  ],
  plugins: [
    "@babel/plugin-transform-typescript",
  ],
  extensions: [".ts", ".js"],
  cache: true
})

const {main} = require("./test.ts")
main()

// test.ts

export async function main() {
  await new Promise(r => setTimeout(r, 1000))
  console.log('hello!')

  let a = await new Promise(r => r('a'))
  console.log(a)
}

The above main function is basically undebuggable using VS Code. I've created a test repository and included more detailed reproduction steps to demonstrate the issue. When doing all the steps using the Chrome debugger, everything works fine.
VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T14:58:56.166Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7300U CPU @ 2.60GHz (4 x 2712)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.81GB (6.18GB free)

Process Argv

Screen Reader
no

VM
40%

Extensions (2)

Extension
Author (truncated)
Version

gitlens
eam
10.2.0

vscode-typescript-tslint-plugin
ms-
1.2.3

This is a scenario that we can't really support, and I confirmed that it also doesn't work at least in 1.39. But, it does work in our new experimental debug adapter which you can try out with this extension: https://marketplace.visualstudio.com/items?itemName=ms-vscode.js-debug-nightly


[BUG] Launching the game via TF2BD causes vsync issues

Describe the bug
When launcing tf2 via TF2BD, there's screen tearing
To Reproduce

Launch TF2BD
Launch TF2 via TF2BD
Click the "Find a Game" button
It'll be warped while opening (applies ingame too)

Expected behavior
No screen tearing (launching via steam has no issues)
Desktop (please complete the following information):
Linux Mint 21.3
Additional context
Recording TF2 with something like OBS does not capture the screen tearing

What was the issue for this

I made it originally because launching via steam didn't cause the issue but then it started happening there too


fix(popup): don't make the window column go below 0

Fixes: https://github.com/folke/noice.nvim/issues/736

I can confirm this fixes the issue #736 I had with noice.nvim.

Thanks!


image renderMode Layer memory leak

image renderMode Layer memory leak version v5.3.1
demo here https://codesandbox.io/s/918187vy3r
quickly click rerender button,  memory never release, it will be slow on mobile phone. any ideas?

We removed the image render mode. From v6 on, use a Vector source with a VectorImage layer.


Here are the trained weight files (modelG.pth)

The first is to thank and worship the leaders for their outstanding contributions.
Here is the model file I have trained with the boss's existing code for friends who like this application direction to test.
链接：https://pan.baidu.com/s/1PhqNv3pLKBNWJRPQR70XDQ
提取码：d6fk
You can optimize the data loading, increase the speed by about 5 times (single process), further increase the speed of multiple processes, and then train for 15 hours a night. Intel CPU i7 + SSD + 12g -- rtx3060.

Thank you for your work. I don't have to spend a lot of time training

@huang229 could you please send discriminator.pth file??


Unable to track student's build plan

Hello, I'm a tutor for a course and we create a exercise with the url:
https://artemis.ase.in.tum.de/course-management/85/programming-exercises/2710
But something very strange is that, for one student I can see his repo and score, but his status is inactivate,

His build plan should be somewhere:

But I don't have access to his build plan, why is this the case?

Inactive means that the build plan was already cleaned up due to inactivity. You can simply trigger a single build for this student on the participations page, then the build plan will be recreated.

Inactive means that the build plan was already cleaned up due to inactivity. You can simply trigger a single build for this student on the participations page, then the build plan will be recreated.


More interacting Readme.md

I'm not in favor of the combination of changes this PR.
Can you explain your reasoning behind each of the changes @vikas28km?

I'm not in favor of the combination of changes this PR.
Can you explain your reasoning behind each of the changes @vikas28km?

I just try to make that conversation more polite and interacting.....

I'm not in favor of the combination of changes this PR.
Can you explain your reasoning behind each of the changes @vikas28km?

I just try to make that conversation more polite and interacting.....
I'm sorry for hearing that from you :-(
Please forgive me for this, if you don't like it. Then, you can tell me, i will remove it :(

besides of all these,,
Can we be the friends??

I don't understand what "interacting" means in this context.
I don't see how the changes are any more polite than what is currently there. Can you explain case by case how it is more polite?

I don't understand what "interacting" means in this context.
I don't see how the changes are any more polite than what is currently there. Can you explain case by case how it is more polite?

sorry,
I am new here. I can't explain you any more :(

Would you like to be friend??
I want to learn more from you..

Closing as low-quality contribution.


ConfigTest should return non 200 if config is not ok

Maybe triggered by ?failonerror=1

Fixed in PR#411 /api/appstatus/500 will return 500 errors if status is not OK


An idea for announcing upcoming events

@VictoriaODell: You might hate this idea but what do you think about making the date more prominent with this little calendar component?

Alternatively, with a few tweeks, this could work well for showing a pair of upcoming meetup events:

@luqmaan, I dropped the .fade-out because it breaks on Safari... Looked for a fix but got stuck.

:+1:

@mateoclarke lol don't start anything with "You might hate this".

I totally dig the calendar component. I feel like that was an idea early on at some point.
The 1st option will be visually more consistent. The title lengths of the different events will throw off the symmetry in the second version
Thoughs about the below iterations? With the empty spaces having the clandar

4. If those ^^ are weird then I suggest going with your option 1 but having the button aligned left.  :cat2:

I like those recommendations. I'll work towards that and merge. Thanks! :bow:


Azure devops demo

Azure devops demo project creator raises an error

Hi @shruthi-de
Kindly provide more info on what issue you are facing, we would be happy to help you.
Thanks


Highlight consumed input

This PR adds support for highlighting the lines that have been consumed in batch mode.
A div element with contenteditable=true has some undesirable default behaviour that is very clunky and error-prone to work with (first child is a TextNode before using divs,  replacing that TextNode with a div causes new elements to appear, ...) so I decided to stop using it. Instead, CodeMirror already provides an editor with plenty of flexiblity and a useful API.  This editor can then share some code with the CodeEditor-class.
To provide actual highlighting and gutters, I added new classes. The Gutters base class allows creating arbitrary gutters (such as the checkmark gutter, but also a breakpoint gutter (useful for #109)). To prevent code duplication in the BatchInputEditor, I created a base class grouping similar functionality between the input and the code editor together. I also used the CodeMirror theme extension to properly fix the layout of the editor is always correct.
The highlight-style is still up for debate. I currently use the built-in CodeMirror activeLine classes.
Closes #82
Depends on #216 (to be able to use cleaned version of onChange in the new Editor base class)

Can this be deployed somewhere? https://papyros.dodona.be/dev shows a blank page for me.

Can this be deployed somewhere? https://papyros.dodona.be/dev shows a blank page for me.

I didn't get a blank page, but I have also scheduled a deployment as the deployed version wasn't this one.

Tooltip: "This line has already been used as input", "Deze regel werd al gebruikt als invoer"

Does this mean the part containing the prompt it answered should be omitted? Or should I append that to these strings?

@winniederidder: The version that is deplyoyed right now on /dev, doesn't seem to have the latest changes when it comes to input lines that have already been processed (marking those lines, tooltip of icon, making the line read-only). On Windows 10 / Chrome I haven't seen anything that needed to be done to make the service workers work (at least not recently).

After applying the suggestions and fixing some other issues, this is the current state:

Layout likely still needs tweaking. Currently a cyan background is used for consumed lines, and a light background is applied to the line that will be used.

Highlighting line that will be consumed next is a bit weird as a feature, as there is no guarantee that another line will be consumed. On the other side, the highligting is so subtle that almost need to know this feature exists, to notice it.

Just as the code in the editor is stored and reused after a page load, it might be interesting to do the same for batch input.

Chan background Color doesn’t look great in dark mode.

Misalignment between editor and gutter now even seems worse. Hadn’t noticed it myself before, but now I clearly see it on iPad.

Would seem more logical to always show the gutter in the batch input editor

@bmesuere @pdawyndt I should have resolved the given remarks and deployed the newest version.
Last issue is likely the styling of the consumed and next-to-use lines (see the comment from Peter).


[bug] @storybook/jest breaks PHPStorm Inspections

Describe the bug
Angular uses Jasmine and PHPStorm Inspections work without @storybook/jest. Using just Angular + @storybook/storybook is also working fine. However, once you start using @storybook/jest PHPStorm starts to think that all *.spec.ts files are Jest tests instead of Jasmine ones. It's easily reproducible in a fresh Angular install.
To Reproduce
Steps to reproduce the behavior:

Use e.g. the toHaveBeenCalledOnceWith matcher in a Angular spec file
import { expect } from '@storybook/jest'; and use it in a stories file
Go back to the Angular spec file
See PHPStorm error

Expected behavior
Ideally there should be no errors and PHPStorm should just get it automatically. However, this is probably not going to happen. Maybe Storybook team could add some notes to the docs providing more information. E.g. that @storybook/jest is not compatible with Angular or how to work around the described issues. Alternatively there might be a @storybook/jasmine for Angular users.
Screenshots

System
Environment Info:

  System:
    OS: macOS 14.0
    CPU: (10) arm64 Apple M1 Pro
  Binaries:
    Node: 16.18.1 - ~/.nvm/versions/node/v16.18.1/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 8.19.2 - ~/.nvm/versions/node/v16.18.1/bin/npm
  Browsers:
    Chrome: 117.0.5938.149
    Safari: 17.0
  npmPackages:
    @storybook/addon-docs: ^7.4.6 => 7.4.6
    @storybook/addon-essentials: ^7.4.6 => 7.4.6
    @storybook/addon-interactions: ^7.4.6 => 7.4.6
    @storybook/addon-links: ^7.4.6 => 7.4.6
    @storybook/angular: ^7.4.6 => 7.4.6
    @storybook/blocks: ^7.4.6 => 7.4.6
    @storybook/jest: ^0.2.3 => 0.2.3
    @storybook/testing-library: ^0.2.2 => 0.2.2

Additional context
–

Found a workaround:
Add /// <reference types="@types/jasmine" /> to the Angular test.ts file.


Potential feature: APIPort helper when nuget resolves an assembly from a different TFM

/cc @terrajobst
See https://github.com/NuGet/Home/wiki/Enable-.NET-Core-2.0-projects-to-work-with-.NET-Framework-4.6.1-compatible-packages
When NuGet uses AssetTargetFallback to resolve an assembly from a different framework on the current one, wouldn't it be nice to have a helper that could launch API port to let a dev know how successful that might be?
Similarly it'd be nice to be able to do the same in relation to some types of exceptions like typenotfound / missingmethod / typeload.  Not sure how successful these could be, but I think the ATF/PTF use case I mention above is pretty straight forward.

Not sure about an event.  There is a warning that shows up in the error list: NU1701.  Can you hook when someone double clicks that?  Alternatively can you add a right-click option to the reference node (which will have a Warning icon next to it)?

Closing as API Port was deprecated in favor of binary analysis in .NET Upgrade Assistant.