add duckdb and motherduck destination connector

This PR adds support for DuckDB and MotherDuck destination connector.

This is looking great! I think we are almost there.

I've added the needs edits label to this PR for now. Feel free to remove it once it's ready to have someone rereview it.

@krish-adi We are in the middle of a big code push this week. I will help you with Roman's comments for this PR at the beginning of next week.

hey @potter-potter good luck with the release. I'll follow up on the fixes requested above, and you can take a look next week.

@potter-potter , hope the release went well! I am wondering what changes need to be made here to be compatible with the newer version of the library? Could you review it and let me know, and I could get the changers in by this week.

@rbiseck3 I am assuming your comments on this PR are still accurate? Were there any async or multiprocessing changes that would need to be looked at? (thats the only think I can think of that might have changed in the last 3 weeks)
@krish-adi Thanks. Release went well. But of course we are slammed again for another sprint. :) I would say that Roman's changes are still accurate. And would help take this over the finish line.

Also there should be some good examples of splitting out the 2 distinct connectors now based on authentication in the repo now. Like for databricks_volumes. This will help make the connector easier to integrate in our Platform UI.

@krish-adi please switch the tag to  ready for review when you feel its ready

to test against motherduck, you would require a MOTHERDUCK_TOKEN. you can get a free account from motherduck.com (docs on this here)and the free limits would be enough for testing the integration.
how often would this run in your CI ?

hey folks, any update on this one?

hey folks, any update on this one?

thanks for the bump. I'll look at it this evening. We have been turbo slammed. (i know seems like always right now...)

Hey. This a really cool. Motherduck is a very nice experience. Sort of a lightweight databricks. A pleasure to use.
The connector works well. Can you put the motherduck.py and duckdb.py into a folder called duckdb?
Can you address this warning I am getting in the tests:
UserWarning: Field name "schema" in "DuckDBConnectionConfig" shadows an attribute in parent "ConnectionConfig"

Hey @potter-potter ! great to hear that :) thanks for suggestions. I've moved the motherduck and duckdb connectors and their tests into duckdb folder. I've also renamed the schema to db_schema to not conflict with the parent.

Hey @potter-potter and @rbiseck3 , any other changes required for this connector?

Hey @potter-potter let me know when this is released and lands on your platform. We could do a shoutout on socials.

@krish-adi Closing this because it is now in the latest release via the other PR. Thank you!


Faces Tab groups faces to one face

Describe the enhancement you'd like
Something similar to Google Photos, where people are represented by  a cover photo of their face, and that can be expanded to reveal all the faces of that person.
Describe why this will benefit the LibrePhotos
Faster load times of the faces page, seeing as not all faces should load every image under them, it would also make it easier to manager faces if you plan to include a hide face feature in the future.
Additional context
Add any other context or screenshots about the enhancement request here.

Just to clarify the necessity of this, right now when I scroll down in the faces tab, the browser sometimes hangs before loading the next batch of faces. Making these collapsable into a single face icon would solve that behavior.


Fix Layout for Plans

I have changed the strategy to call Stripe's API from the sensetif-datasource-plugin and return their objects directly.
Plans.tsx and PlansList.tsx is trying to format that nicely, but I can't figure it out.
Preferred;

Make each "plan" a box, not occupying the whole width
Stack plans next to each other
Pricing in a "reasonable" way, i.e. Yearly possibly larger, with "% OFF" from the "Monthly" fee. The "Onetime" should change to "10 years Prepaid" or something like that. Single click "subscribe" is preferred.
I am going to utilize Images later, but has no material yet. Suggestions welcome...

When the boxes wrap to new lines, they "float together" and become confusing.

@niclash fixed


Support question answering tasks in the open-domain setting

Is there a way to enable analysis for open-domain question answering datasets? Or at least on the Reading Comprehension (RC) side, given different retrieved contexts from multiple retrieval models, to use/submit different versions of the context dataset but for the same RC task.

Thanks @zorazrw !  I think the "new tasks" part is covered by this https://github.com/neulab/ExplainaBoard/issues/54
but you also want new functionality concerning handling retrieved contexts in retrieval-based QA systems, which is an interesting problem.


Clean up

Removed broken integration to RealFaviconGenerator
Removed build artifacts from git
Improved automated tests to check generated assets against known fixtures
Updated dependencies

Since the online generation feature has been removed we have to bump the major version

@brunocodutra feel free to merge and ping me i am give your right to npm

@evilebottnawi thanks!
How do we coordinate publishing to npm?

@brunocodutra send me your npm username on email<EMAIL_ADDRESS>

@brunocodutra done, try to release :+1:

@brunocodutra wait

@brunocodutra we will major release?

@evilebottnawi I believe we have to, since there's a breaking change in that a feature was removed

@brunocodutra good, let's fix license field https://github.com/evilebottnawi/favicons/blob/master/package.json#L26 to MIT (now we have one license in package and other in project) and feel free to release :+1:


Use Asciidoc format for the styling guidelines document

Markdown is limited (by design) in the vocabulary it offers.
AsciiDoc offers more vocabulary that could be very useful for the Styling Guidelines document.
Pros

as simple as you want it to be, if you know Markdown, you already know Asciidoc
Asciidoc is supported by GitHub
more vocabulary, more structure for free
easily convertible back to Markdown or any other markup language (see Pandoc)

Cons

it's not Markdown :interrobang:

I have created a rapid conversion of https://github.com/ab18556/styling-guidelines/pull/4 as a proof of concept.
See https://github.com/ssirois/styling-guidelines/tree/chore/readme-format
If this feature request is accepted, I will create a PR for the format change.


How do I convert glsl to hlsl?

I would like to convert glsl shaders to hlsl for the magpie program

Doesn't Magpie already have Anime4K shaders?

not all of them

Porting an mpv hook to a Magpie effect is challenging. Currently, the Anime4K shaders available in Magpie were manually ported, making it difficult to handle especially large shaders like UL and UUL. I see two potential solutions:

Write a script to export the weights as a Magpie effect, similar to how they are exported as an mpv hook in this repository.
Export the weights as ONNX. Magpie has a special version that supports this format.


Support URL for icons

Is your feature request related to a problem? Please describe.
In Homer I am able use custom icons which is handy to have the real app icon
Describe the solution you'd like
Custom apps support URLs so if this support could be added to the annotation for ingress apps then any icon might be used.
Extended feature would be to upload icons that could be served by the hajimari web server.
Describe alternatives you've considered
For the icons a custom container might be created that has the apps each user has but it is an "advanced" feature to build your own container. It would work for me thought.
Additional context
Add any other context or screenshots about the feature request here.

Added in #44


PrivateMethodTester doesn't find methods in superclass

The PrivateMethodTester assumes the private method under test can be found in the concrete, runtime type of the receiver object. Sometimes the private method under test is in the superclass, but there is no way to instruct the method tester to look up the super type chain, nor to pass an explicit Class object (it hard-codes .getClass).
For example:
abstract class Base {
  private def internal: String = ???
}

class Concrete extends Base

I can't test internal. Since Base is an abstract class, there won't be any instances of that class, so there's really no way to work around it.

While I realize the following doesn't help @dragos, it does—at least—illustrate another use-case.
Suppose a Base#internal was protected (instead of private) as in the earlier example. Here's a  workaround via anonymous implementation of Concrete:
abstract class Base {
  protected def internal: String = ???
}

class Concrete extends Base

val concrete = new Concrete {
  override protected def internal: String = super.internal
}

it must "throw expected exception" in {
  val internal = PrivateMethod[String]('internal)
  a[NotImplementedError] should be thrownBy (concrete invokePrivate internal())
}

A workable-but-unwieldy way of achieving the desired invocation when the non-public member is not defined by the instance class.


Automatically regenerate schema diagrams

On each push to master, before documentation is deployed, the diagrams
are regenerated.
There is actually an issue with the generated documentation: Travis only
checks out latest 50 commits. If the latest python-pdc-* tag is older
than that, getting version will fail.
JIRA: PDC-1110

Looks good to me.
If we tag every SP, I think it won't be problem.

That could work. However, we need to figure out some consistent way of using the tags. Currently, the version is base only on tags created by tito (and it's actually not correct – dev server shows version as  0.1.0-1.79.g2c7e619). I think we should switch it back to using the manual tags v0.*.* and just make sure that tito builds are done from that commit.

:+1:

+1


Install roles in roles directory.

This is to ensure the desired versions of roles are installed; the user might already
have some old ones in the global role path.
An alternative way to approach this would be to ignore ansible.cfg and provide an example along with an explanation. Then people can set roles_path (and other options) to whatever they want.

Interesting idea... but why not recommend that the global roles be at the latest versions?

People might be using them in other playbooks. If, however, roles respect
semver and ansible-galaxy understands semver, then this could be feasible.
On Tue, Jan 20, 2015 at 5:08 PM, Jeff Geerling<EMAIL_ADDRESS>wrote:

Interesting idea... but why not recommend that the global roles be at the
latest versions?
—
Reply to this email directly or view it on GitHub
https://github.com/geerlingguy/drupal-dev-vm/pull/28#issuecomment-70679113
.

I'm going to close this PR for now... I think I'd rather people have the roles installed globally, and I don't want to add anything to install them local to this playbook (for now), unless there's a simple way it can be configured easily, through local variables.


As a cluster administrator I want to group entities by different params

AS a cluster admin I want to see how many groups on the cluster has -2 devices. Or how many nodes are in datacenter X
Or how many nodes have pdisks with usage from 60%  to 70%.
Basicaly I want to apply this grouping to following views:

databases
nodes
groups

needs review @antonkovalenko @adameat https://nda.ya.ru/t/MDAwdVT978D6Xh

needs review @antonkovalenko @adameat https://nda.ya.ru/t/MDAwdVT978D6Xh

looks fine to me


Introduction to HIP

Add Introduction to HIP
Combine Programming Model and Programming Model Reference
Update links on index and TOC

@randyh62 Opened a new PR: #3558


BrowserPanelHandle: Update to pass test if webpage failed to load #733

Fixes #733
If Google rejects search requests made by our automated tests on
Travis CI or AppVeyor, these tests will fail. Developers will have to
re-run the build until Google stops rejecting these search requests.

This causes unnecessary delay for the developers to find out whether
their PR actually breaks the build.

Let’s update BrowserPanelHandle#isLoaded to return true when the attempt
to load a webpage is completed, regardless the loading of the webpage
is successful or a failure.

Prof, here's the code!
<!doctype html>

		<meta charset="utf-8">
		<title>My test page</title>

	Hi : This is a placeholder page for se-edu/addressbook-level4

Oh, I'd recommend we try hosting it on GitHub pages first, since we already have an automatic deployment system in place.

Oh, I'd recommend we try hosting it on GitHub pages first, since we already have an automatic deployment system in place.

Sorry, how do I do that? >< I tried locally putting the .html file into the docs folder, but upon pushing it doesn't auto-generate in my Github Pages. But I thought it's weird for me to convert it to AsciiDoc also right? :O

I merged this on my own master branch, as such you can access the GitHub Pages here to verify that it works as intended.

Just to confirm, although all forks will deploy their own search page, their app will access upstream se-edu search page by default (because the URL will be hard-coded in the code)?

Just to confirm, although all forks will deploy their own search page, their app will access upstream se-edu search page by default (because the URL will be hard-coded in the code)?

Yes. One way to go about this issue is to mention in the Developer Guide since we have a segment informing them to update documentation to match your fork.
What Paul suggested earlier was that we could try it out first and see if GitHub complains, since GitHub Pages serves static pages which require less processing power, which perhaps means that it's less likely to cause any issue.

Just to confirm, although all forks will deploy their own search page, their app will access upstream se-edu search page by default (because the URL will be hard-coded in the code)?

Hmm it might be possible to have travis and gradle replace the hard coded string for us, with the help of
travis environment variables and gradle replace string if its not desirable to access upstream se-edu search page by default.

Hmm 2nd paragraph didn't mention the initial problem we faced

@eugenepeh sorry which initial problem? ><

Hmm it might be possible to have travis and gradle replace the hard coded string for us, with the help of travis environment variables and gradle replace string if its not desirable to access upstream se-edu search page by default.
Edit: But then again... it will requires the trigger of travis and gradle build so yeh it might be better for them to edit themselves.

Ah I thought this was a good idea too, until you pointed out that tests will still access the .html file in se-edu repo when run locally. Only when it's run on Travis then it accesses the .html file in their own repo.

@eugenepeh sorry which initial problem? ><

Uh... the tests failing? ~who cares about google~ :x

Other than the indentation of the docs/DummySearchPage.html, everything else seems okay

Totally slipped my mind; was too focused on just to get it to work. Thanks! :)

[3/3] Missed out on updating 2nd paragraph of the commit message.

Sorry, missed something in the previous review. Also, now that we use a dummy page, should the test pass when there is no Internet connection? Isn't it safer to fail in such a case? If the cause is lack of Internet, repo admin can decide to merge in spite of the failure.

If the connection failed, I'm not sure whether we can tell from the Travis log that the failure is due to no Internet connection.
Also, even though there's no internet connection and the browser fails to load the page, however the browser's url will be updated to the dummy page's url. Since the test simply verifies that the url is correct (i.e. the url is the same as that of the dummy page. We don't verify the contents of the page), it should pass even though the internet connection fails?

If the connection failed, I'm not sure whether we can tell from the Travis log that the failure is due to no Internet connection.

Is it possible/probable that Travis server loses Internet connection? Did it happen before? If not, we should not create a mechanism that gives a possibly-false positive. If we really want to skip test when there is no Internet, we should have a way to confirm there is no Internet. That is, we should avoid a case where the test passes because it thinks there is no Internet but the page is not loading due to a different bug.

Also, even though there's no internet connection and the browser fails to load the page, however the browser's url will be updated to the dummy page's url. Since the test simply verifies that the url is correct (i.e. the url is the same as that of the dummy page. We don't verify the contents of the page), it should pass even though the internet connection fails?

Is it possible to check the content of the page too? It's supposed to show the name of the person right? If not, how do we confirm that the the browser component is working? But this can be a separate PR.
What do you guys think?

Is it possible/probable that Travis server loses Internet connection? Did it happen before?

I recall seeing it only once happening in my PR. So it's really rare. We can remove it.

Is it possible to check the content of the page too? It's supposed to show the name of the person right? If not, how do we confirm that the the browser component is working?

Yup we should strengthen the test by verifying that the page shows the name of the person.


Update Istio API to 11/12

Update API to https://github.com/istio/api/commit/62bf0afefa2f323e70ee21b45afed3748922f8f9

@diemtvu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
3c55ab82f42ea6dda8583da74f377006d4618a4e
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
3c55ab82f42ea6dda8583da74f377006d4618a4e
link
/test integ-mixer-k8s-tests_istio

lint_istio
3c55ab82f42ea6dda8583da74f377006d4618a4e
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
3c55ab82f42ea6dda8583da74f377006d4618a4e
link
/test integ-mixer-k8s-tests_istio

lint_istio
3c55ab82f42ea6dda8583da74f377006d4618a4e
link
/test lint_istio

integ-security-k8s-tests_istio
3c55ab82f42ea6dda8583da74f377006d4618a4e
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-tests_istio
/test lint_istio


Param classes defined in external file and inheritance

I have a use case for panel that's difficult to describe without a demo so I'm attaching two files. The notebook walks through my issue.
user_guide.zip
I'd be interested to hear any thoughts on how I can improve this approach.

The issues seem to be fixed according to my testing, if you can confirm could you close this?

I updated param and panel to master and now I can't get the panel to display. I'm getting a javascript error:

Could you report the versions you've got for each? I can't reproduce that.

JupyterLab and jupyterlab_pyviz versions may also be useful.

param                     1.8.0a8.post5+ga97c18b
panel                     0.1.0a11.post3+ge8e0f6d.dirty
jupyter                   1.0.0
jupyter_client            5.2.3
jupyter_console           5.2.0
jupyter_core              4.4.0
jupyterlab                0.34.6
jupyterlab_launcher       0.13.1
@pyviz/jupyterlab_pyviz v0.6.1

Thank you!

Okay updated JupyterLab and can now reproduce the issue. I'll try to get an updated jupyterlab_pyviz release out with a fix.

Okay nevermind, it's not an issue with the extension, it's merely down to the fact that you haven't loaded the extension. So try clearing the output, and then loading the panel (or holoviews) extension:
panel.extension()

Not sure how I was missing that before when this was working. At any rate, panel.extension() doesn't seem to fix it for me.

I'm heading out for the day, I'll pick back up with this tomorrow.

I had to clear the notebook and reload the page for some reason.

Got it working. My guess is that the other tab was hanging on to a previous build.
Now, is this expected behavior given how I have this coded?:

And can you confirm that this:
loc = foo.location(name='')
adv = foo.advanced(name='')
Tabs(('INPUT', loc), ('Advanced', adv))

foo.launch(loc.solve_on, adv.notebook)

Is the cleanest and most efficient way to apply my code?

Now, is this expected behavior given how I have this coded?:

No, appears to be a bug, I can see an error on the console.

Fixed in https://github.com/ioam/param/pull/289

What I was hoping for (and what I think worked in a previous iteration of my code without panel and possibly with a different class setup) was this:
Tabs(('INPUT', foo.location), ('Advanced', foo.advanced ))

foo.launch(foo.location, foo.advanced)

And something like this:
def launch(location, advanced):
   v = solve_on
   g = notebook

Where basically because launch was inheriting param.Parameterized classes and I could just use the objects from those classes directly inside the method (e.g. solve_on above). It felt weird at first because its not clear what's going on, but I eventually liked it because it made my code so clean. Is this not possible now with the way I have it set up above?
If this isn't clear, I can demo what I have on a call next week.

Orrrr.... could I write a subfunction in each param.Parameterized class that simply returned all the objects. Then I could call launch like this:
foo.launch(foo.location.return_objs(), foo.advanced.return_objs())
And then I'd just have to unpack the input.
And for reference... this is what I currently have based on your last suggestion, which is a nightmare:
solve_obj = solve2.solve(loc_param.solve_on, loc_param.solve_from, loc_param.local_architecture,
                         login_param.hpc_login_node, submit_param.hpc_subproject, submit_param.workdir,
                         submit_param.nodes, submit_param.wall_time, submit_param.queue,
                         submit_param.submit_script_filename, adv_param.notebook, input_param.sim_files,
                         input_param.model, input_param.adh_rootname, input_param.adh_root_filename,
                         input_param.adh_directory)

Could you describe what exactly about this isn't working? I can't reproduce any problem with what you're describing. I don't quite follow the difference between foo.launch and the launch function. The other thing I don't follow is this:
foo.launch(foo.location, foo.advanced)

There is no reason to pass those parameters to the launch method since they are available on self. I think what you really want is a classmethod?!
class location(param.Parameterized):
    solve_on = param.ObjectSelector(default='topaz', objects=['topaz', 'desktop'], precedence=1)

class advanced(param.Parameterized):
    notebook = param.Boolean(default=True, precedence=9)

class solve(location, advanced):
    @classmethod
    def launch(cls):
        if cls.solve_on == 'desktop':
            print('bar')
        if cls.notebook:
            print('notebook')

If this isn't what you want let's discuss next week.

OoOoOo I didn't know that I was a thing (engineer != programmer). That seems like it might be what I'm looking for. Let me work on this a bit and get back with you.

And to answer your question. Its all working, its just much less clean than it was before I implemented Panel so I want to make sure that I'm streamlining things as much as possible.

So param actually also provides a bothmethod decorator, which means you can use the method on the class or an instance of the class which may also be useful:
class solve(location, advanced):
    @param.parameterized.bothmethod
    def launch(self_or_cls):
        if self_or_cls.solve_on == 'desktop':
            print('bar')
        if self_or_cls.notebook:
            print('notebook')

@philippjfr Have you had a chance to look at the solve code I sent yet? I have a soft deadline for a demo at the end of the week and I'd love to use the more streamlined version of that code.

Looking at this now, hope to get back to you very soon.

works great! thanks!!


[FLINK-33876][table-planner][JUnit5 Migration] Introduce methodName method in TableTestBase

What is the purpose of the change
[FLINK-33876][table-planner][JUnit5 Migration] Introduce methodName method in TableTestBase
Brief change log
After completing the JUnit5 migration in the table planner, there is an incompatibility issue with JUnit TestName and TestInfo. Therefore, considering introducing the methodName method in TableTestBase. External connectors's TablePlanTest can override this method when performing JUnit 5 migration for TableTestBase to avoid compilation issues.
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not documented)

Hi @leonardBang, please help review it when you have time.

@flinkbot run azure


kind-tests_hack_main job failing

The e2e kind test has been failing because it times out waiting for net-istio to be installed (example).

/assign @kauana


nrf9160/nrf9160-dk:modem_ns crash on start

Hello,
I am trying to run the nrf9160-dk:modem_ns example, however it seems to crash very early in the startup routine. Specifically, it crashes in nrf91_clockconfig.c:75 when accessing a register. I have started looking into this and I feel it is related to the configuration CONFIG_ARCH_TRUSTZONE_NONSECURE=y. The nrf9160-dk:nsh example works fine, however when I change the one setting to CONFIG_ARCH_TRUSTZONE_NONSECURE=yit also fails at the first register access (through putreg32).
I am using the CMake build since the make build has an issue resolving the NRXFLIB URL. I am on nuttx-12.5.1 and I briefly tried nuttx-12.3.0, the release shortly after nrf9160-dk:modem_ns was added.
Tagging @raiden00pl, since you added this config.
I will continue looking into this, but maybe somebody can provide some insights?
Thanks!
Max

@raiden00pl please take a look

It looks like I broke modem example with dd611b9c5ba8aca0d6d6901fb7ac51d0fce35e84

Thanks for looking into this! Can you provide me a brief tutorial on the relation between the miniboot_s and modem_ns configuration? I am not familiar with the secure bootloader.
I compiled the miniboot_s configuration and flashed it to the board, but I don't know how to proceed. Also, I am on nuttx-12.5.1 or do I need to be on nuttx-12.5.0?

Thanks, @raiden00pl, the additional documentation in https://github.com/apache/nuttx/pull/12778#issue-2431829826 helped!

@raiden00pl do you potentially also have instructions on how to test the modem? I see that wget is configured, but I am not sure if there is additional steps required in hardware and configuring the modem?
The nrf9160-dk comes with a iBASIS SIM card. Do you have experience with it?

You have to register your SIM card on https://nrfcloud.com/ and activate it.
After chip reset, modem is in power off state, so you have to enable modem and if necessary configure it. At this moment, this must be done manually either with lapi from apps or with AT commands on /dev/modem (you can use cu program enabled by default for modem configuration).
This should be done automatically by the LTE link-control daemon, but NuttX doesn't have anything like that yet, and I haven't had a chance to finish my implementation.
To start with, I recommend playing around with Nordic tools to understand how LTE-M works (nRF Connect Cellular Monitor

@maxikrie if you get it working, please submit a documentation. Also creating blog posts helps to let more people to discover about NuttX.

@acassis I got it working with a 1nce (https://1nce.com/) SIM card, which I was using with an Arduino board. I can also try with iBASIS SIM card, which comes with the nrf9160-dk and maybe more convenient. Where should I provide the documentation?

@maxikrie I think at Modem Support here: https://nuttx.apache.org/docs/latest/platforms/arm/nrf91/index.html

@raiden00pl Thank you again for your amazing work, this helped me to get started quite easily. Very satisfying to be able to just open a socket()! I have a few follow-up questions:

I tried break-point debugging with Ozone, but I only can get it working with the nsh example. The different memory layout with the combination of miniboot_s and modem_ns seems to mess up things and I likely have it not configured correctly. Did you try this?
I am still quite new to usrsock in Nuttx. I looked at the gs220m and alt1250 implementation, which employ an additional daemon and also employ '/dev/usrsock' while for the nrf9160 it doesn't have that. Instead NET_USRSOCK_CUSTOM is set. Is this what you mean by missing the 'LTE link-control daemon' or what is the difference between NET_USRSOCK_DEVICE and NET_USRSOCK_CUSTOM?

I tried break-point debugging with Ozone, but I only can get it working with the nsh example. The different memory layout with the combination of miniboot_s and modem_ns seems to mess up things and I likely have it not configured correctly. Did you try this?

I've worked with gdb only so I can't help.

I am still quite new to usrsock in Nuttx. I looked at the gs220m and alt1250 implementation, which employ an additional daemon and also employ '/dev/usrsock' while for the nrf9160 it doesn't have that. Instead NET_USRSOCK_CUSTOM is set. Is this what you mean by missing the 'LTE link-control daemon' or what is the difference between NET_USRSOCK_DEVICE and NET_USRSOCK_CUSTOM?

You can look at alt1250 architecture here: https://github.com/apache/nuttx-apps/blob/master/lte/alt1250/README.txt
alt1250 implements user socket API on apps side and NET_USRSOCK_DEVICE provides interface to communicate with kernel side part of alt1250 implementation (like SPI data transfer).
For nrf91 all user socket API is implemented on kernel side, so we don't need /dev/usrsock.
When I write 'LTE link-control daemon', I mean something like https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/libraries/modem/lte_lc.html so we can automate the modem configuration and control.

I often have the issue that when I only want to flash changes to the modem_ns build, the board bricks and I have to first reflash the miniboot_s build (chiperasing everything during the operation) and then again flashing the modem_s. Do you also encounter this issue?

Sounds like AP-protect mechanism in Nordic chips: https://docs.nordicsemi.com/bundle/ncs-2.6.0/page/nrf/security/ap_protect.html
It blocks the debugger and the only option to unlock the system is to erase the chip.
AP-protect mechanism is broken for NRF52 (famous NRF52 fault injection bug) so for new chips Nordic enables AP-protect at default in HW. But I don't remember if it's enabled by default for NRF91, probably it probably is.
The missing logic is here:
https://github.com/apache/nuttx/blob/3862b717286ddd6ad8375639daa294844b817ade/arch/arm/src/nrf91/nrf91_start.c#L79-L88


CI: Add CircleCI support

cargo support fix, via changing .gitconfig
cache support, download rust only when nightly date changes
pd-server from docker hub

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

I think we can add the CI build status in README like tavis CI.

@siddontang
according to https://circleci.com/docs/status-badges/ , an API token is needed.
Only repo manager can do that.

according to https://circleci.com/docs/status-badges/ , an API token is needed.
Only repo manager can do that.

@ngaut

Done!

@ngaut @siddontang PTAL

LGTM

LGTM


WIP - Multi api

Not currently happy with this implementation. Looking at others right now.

Changed implementations.


Serverless construct static export

A new version of the serverless cdk plugin that does not utilize the "exports" syntax of the package.json file.

@adriencaccia or @fargito this time we're ready 👀
Sorry for all the different PRs on this subject


netty  接收超过1024字节的数据

Expected behavior
单包数据读取大于1024
Actual behavior

得到此异常：java.lang.IndexOutOfBoundsException: readerIndex(8) + length(8968) exceeds writerIndex(1024): PooledUnsafeDirectByteBuf(ridx: 8, widx: 1024, cap: 1024)

Steps to reproduce
read单包大小超过1024
Minimal yet complete reproducer code (or URL to code)
Netty version
4.1.2.Final
JVM version (e.g. java -version)
java8
OS version (e.g. uname -a)
win10

Please use English ... and also include the full stacktrace

Hello, thank you for your reply
I'm using netty to read data,However, the size of a single packet exceeds 1024.
So I get the following exception

java.lang.IndexOutOfBoundsException: readerIndex(8) + length(8968) exceeds writerIndex(1024): PooledUnsafeDirectByteBuf(ridx: 8, widx: 1024, cap: 1024)

@git-chenjiqing you need to check first if there is enough data to read. Remember netty is non blocking so it will push bytes through the pipeline as it sees it. You may need to implement your own ByteToMessageDecoder to buffer data until there is enough to be read


Ingest Avro Key Records

We need to be able to ingest v2 records (ones with avro key and value).
Closes #309.

Codecov Report

Merging #310 into master will increase coverage by 0.04%.
The diff coverage is 94.11%.

@@            Coverage Diff            @@
##           master    #310      +/-   ##
=========================================
+ Coverage   89.85%   89.9%   +0.04%
=========================================
  Files         133     134       +1
  Lines        2888    2902      +14
  Branches      132     132
=========================================
+ Hits         2595    2609      +14
  Misses        293     293

Impacted Files
Coverage Δ

...la/hydra/kafka/producer/AvroKeyRecordFactory.scala
100% <100%> (ø)

...in/scala/hydra/core/akka/SchemaRegistryActor.scala
93.02% <100%> (+0.25%)
:arrow_up:

...la/hydra/kafka/producer/KafkaRecordFactories.scala
87.5% <50%> (-5.36%)
:arrow_down:

...scala/hydra/kafka/ingestors/KafkaTopicsActor.scala
100% <0%> (+3.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5e55bf...761fd91. Read the comment docs.


Is it possible to apply css conditionally in the same state?

    data: ($routeParams) ->
         if($routeParams.theme == 'white')
              css: 'styles/white-override.css'
         else
              css: 'styles/black-override.css'

I have a lot of nested states where the last states have a resolve. Using the solution with new states would multiply these by the theme colors. So I'm asking, if so would be great to find an example in the read.me.

At the moment you can't, you have to do something like
.state('state', {
    url: '/state',
    abstract: true,
    controller: 'Statecontroller',
    templateUrl: 'yourtemplate.html'
})

.state('state.white', {
    url: '/white',
    data: {
      css: 'styles/white.css'
    }
})

.state('state.black', {
    url: '/black',
    data: {
      css: 'styles/black.css'
    }
})

Thx, I solved it in another way. Would be a good feature for various applications.


zerotierone: 1.12.2 -> 1.14.0

Description of changes
https://github.com/zerotier/ZeroTierOne/releases/tag/1.14.0 https://github.com/zerotier/ZeroTierOne/compare/1.12.2...1.14.0 https://github.com/zerotier/ZeroTierOne/blob/1.14.0/RELEASE-NOTES.md
Also had to fix up the update script to account for a moved directory in the upstream source.
Things done

Built on platform(s)

[v] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[v] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 309343 run on aarch64-linux 1

2 packages built:

zerotierone
zerotierone.man


Account for post-dispatch weight correction

The weight that is currently emitted is only the pre-dispatch weight. Since some functions now return a weight correction, they should emit any post-dispatch info so that one can calculate the exact fee paid for a transaction.

I am in the process of adding this. PR will follow soon. However, I will be just replacing the weight in the DispatchInfo with the actual weight. In this way we do not need to emit additional data.


global: initial alembic recipes

Depends on inveniosoftware/invenio-db#59

[x] add foreign key to transactions table

LGTM (cc @lnielsen)

LGTM, just check the need for kombu

LGTM


Simplify the Even or odd number snippet

In this case using Math.abs() is unnecessary since negative even number modulo 2 returns -0.
-0 === 0 // true

I remember that the Math.abs() was there to deal with some edge-case, but I can't remember why. I'll test it further and get back to you!


TypeScript not recognizing brain.utilities

What is wrong?
Property 'utilities' does not exist on type 'typeof import("f:/Projects/brain.js-snowpack/node_modules/brain.js/src/index")'.ts(2339)
How do we replicate the issue?
Use TypeScript and run this code:
import brain from 'brain.js';
const network = new brain.NeuralNetwork();
const mapScreen = document.getElementById('display-map')!;
mapScreen.innerHTML = brain.utilities.toSVG(network);

Expected behavior (i.e. solution)
Be able not to use //@ts-ignore
Version information
Nodejs: 6.12.1
Brain.js: 2.0.0-beta.2
typescript: "^4.0.0"
How important is this (1-5)? 4
Other Comments
More details available here

This is no longer an issue, and was resolved around 2.0.0-beta.10 or so.  Just tested with 2.0.0-beta.12 and works perfectly

.
Sorry for the delay!


[CalendarSkill] Calendar fails if the user tries to sign out in the middle of a flow

Project
Virtual Assistant, Skills
Description
An internal exception is thrown in SkillDialog when the user tries to sign out in the middle the calendar flow (it may affect other multi turn flows in other skills based on OAuth).
To Reproduce
Start a session with the assistant with a user that has o365 linked account

Say "schedule a meeting" (you'll be prompted for participants)
Say "sign out"
You'll get "sorry something went wrong"

Expected behavior
Highest priority I would expect the skill not to crash.
If we allow the user to sign out in the middle of a flow, then the flow should end.
If we don't , then we should tell the user that we didn't understand or that they can't do that at the moment.
Screenshots
Exception inside SkillDialog

Session:

Additional context
The exception is thrown inside SkillDialog so this may be affecting other multi-turn skills based on o365,

Check with design but default behaviour should be top level intents can interrupt


fix(number-box)

Pull request type

Please check the type of change your PR introduces:

[ ] Update
[x] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes

What is the current behavior?
Fix NumberBox functionality. Now ValueProperty will update after lost focus and correct the TextProperty
Issue Number: 1016
What is the new behavior?
ValueProperty will only be updated after losting focus.
Other information
Remove some unused code.

Updated, fix compile errors and remove my own test code

xd你的issue没链接上，数字前面加个#号


Requesting stop button for player capability.

The player capability has the following transport controls. Previous track, next track, play and pause. The stop button is missing and essential for my kodi player.

Do you need stop as an additional separate button? or to replace play pause (play/stop)?

Add it.
While watching a movie i want to be able to pause it but also to stop it.
The main UI on most media players is on a TV or Projector. and those UI elements react differently on a stop or a pause.
i can also imagine players that only need a play/stop but i personally dont need that right now ;-)

Got it. We'll put this in the pipeline, there's already some other player and lists features/bug fixes we need to finish first.


style: Improves code readability with black

Codecov Report

Merging #6 (f0f7371) into main (9fe9d70) will increase coverage by 0.75%.
The diff coverage is 89.36%.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   86.59%   87.34%   +0.75%
==========================================
  Files          22       22
  Lines         664      664
==========================================
+ Hits          575      580       +5
+ Misses         89       84       -5

Flag
Coverage Δ

unit
87.34% <89.36%> (+0.75%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

hostingde/exceptions.py
62.50% <0.00%> (ø)

hostingde/model/account.py
80.00% <ø> (ø)

hostingde/hostingde.py
70.83% <50.00%> (ø)

hostingde/dns/dns.py
43.10% <81.25%> (ø)

hostingde/__version__.py
100.00% <100.00%> (+100.00%)
:arrow_up:

hostingde/account/account.py
78.57% <100.00%> (ø)

hostingde/dns/requests/create_new_zone.py
100.00% <100.00%> (ø)

hostingde/job_waiter.py
61.90% <100.00%> (ø)

hostingde/model/__init__.py
100.00% <100.00%> (ø)

hostingde/model/filter.py
96.94% <100.00%> (ø)

... and 6 more


Can't find #include "class/midi/midi_host.h"

Hi 👋
I was trying to compile your code on a windows 10 with
vs code but I was not able find this file anywhere in your code (#include"class/midi/midi_host.h") can you please guide me about this issue. I have old m audio keystudio 49 that doesn't connects to Cubasis 3 but works fine with FL studio mobile on the same phone. Thanks in advance. I am getting the same error as described by fadh3r please help

@Sorry for the slow reply. The file is in my fork of the tinyusb library in the midihost branch. https://github.com/rppicomidi/tinyusb/tree/midihost/src/class/midi. So either your PC's pico sdk has the wrong fork of tinyusb in it, or the tinyusb fork has the wrong branch checked out. Please see the README.md for step by step.

Hi first of all thank you very much for replying. I was able to compile the code correctly after getting the library in midi host branch you mentioned. Well for software part I think I have done it. Now I will connect to my m audio keystudio tomorrow and let you know if it is working. Thanks again. 🙏

@rppicomidi I fixed the issue of notes getting stuck it had nothing to with raspberry pi pico midi2usbhost. It was the ble parser board which had the problem in its code. Thanks again for your help.


SummedPauliOp for opflow based on SparsePauliOp

Add a dedicated SummedPauliOp class to opflow, for efficiency and functionality, based on quantum_info SparsePauliOp.
The new operator class should be part of opflow and respect the pratice, design of opflow etc. Have operator math, and other operations commensurate with the rest of opflow.
In order to allow legacy operators to be deprecated and internal logic moved fully over to opflow addition function, presently supported by the legacy operators is required. This should includes such methods to check commutation

[ ] commutes
[ ] anti-commutes

ideally also methods for truncation, rounding etc., based on a supplied tolerance value in the method, like are currently in the legacy operators.
Also Z2 Symmetry support see #1029

[ ] Z2 symmetry support

Plus here is an nice to have #1425 - I will link it but it could be considered separately later as an enhancement once the basics are in place.

I will make at least 3 Pull Requests for SummedPauliOp because this has a large influence.

Add SummedPauliOp
Optimize AbelianGrouper, CircuitSampler, AerPauliExpectation, and EvolvedOp(Trotterizatoin) for SummedPauliOp
Support Z2 symmetry

I will note that deprecating the legacy operators, mostly the WeightedPauliOperator, needs a set of changes in the application modules as well to move away from using these - mostly in chemistry FermionicOperator. Once the SummedPauliOp is in place, with the Z2 symmetry support, then that code can be changed to use it and the legacy operators then deprecated.

I reopened. I will make 3 PR for this issue. (1/3 done)


Get progress_data along with other redis fields

In Job.progress() one can use 3rd argument to push additional information:
Job.prototype.progress = function( complete, total, data ) {
...
  if( data ) this.set('progress_data', JSON.stringify(data));

I find it very useful, but it was impossible to obtain this field using Job.range()

Is there a reason not to merge this?  I couldn't see the progress data field in the kue_ui

totally blown this, yes we can merge this in


TOC Candidate Nomination for Daniel Vaughan

Nomination via email to CFF staff. Nominated by Alan Flower, HCL's representative on the CFF Governing Board.
Candidate Name: Daniel Vaughan
Affiliation: HCL
Nomination Statement (from Alan):
I would like to nominate Daniel Vaughan from HCL. Dan is based in our London Lab and is our CF development lead. He is the project leader for our KubeCF implementation and is responsible for our CF-4-K8s alignment too. He led engineering for the new CFMR on OpenShift (this is the product we created for IBM).  IBM have recently asked us to contribute to Eirini and Dan is leading that effort too.
He is both CFCD and CKAD.  If TOC wants someone who is firmly aligned with where we need to drive CF, then I don’t think we would find anyone stronger than Dan.

Acknowledged and confirmed to meet TOC nominee criteria.


Delete unnecessary spaces

When copying from the web page, there is an unnecessary space after the code.

@changeworld : Thanks for your contribution! The author, @mamccrea, has been notified to review your proposed change.

@changeworld : Thanks for your contribution! The author, @mamccrea, has been notified to review your proposed change.

#sign-off


add back apl

add syntactic sugar to simplify having a big switch case with a bunch of condition

closing this for now. not much demand for this and so far the big switch seems to work just fine


Symfony 6 Rules about ContainerInterface

I'm upgrading a few project from Symfony 5.4 to 6.4. I first try to upgrade to Symfony 6.0 and I don't quite understand the rules about ContainerInterface.
    $rectorConfig->ruleWithConfiguration(ReplaceServiceArgumentRector::class, [
        new ReplaceServiceArgument('Psr\Container\ContainerInterface', new String_('service_container')),
        new ReplaceServiceArgument(
            'Symfony\Component\DependencyInjection\ContainerInterface',
            new String_('service_container')
        ),
    ]);

What's is this supposed to change ?
If we use the interface directly it doesn't change anything so shouldn't it be a class rename from ContainerInterface (both PSR and Symfony) into Symfony\Contracts\Service\ServiceProviderInterface? (not sure about that as ServiceLocator are not the only use for injecting ContainerInterface)
Or at least add the following definitions ?
services:
  Symfony\Component\DependencyInjection\ContainerInterface: '@service_container'
  Psr\Container\ContainerInterface: '@service_container'

If recall correctly, this was due to interface not being a valid service name anymore. This applied only to PHP files (configs).
If you add aliases to your YAML files like these, it's another way to upgrade, but it only reverts the upgrade path, so not really way to go:
services:
  Symfony\Component\DependencyInjection\ContainerInterface: '@service_container'
  Psr\Container\ContainerInterface: '@service_container'

What's the use case for service using container? Those should be refactored to require particular services over whole container.

If I recall correctly, this was due to interface not being a valid service name anymore. This applied only to PHP files (configs).
Yeah, ContainerInterface is not "exposed" anymore.

It was to use Locators (bad use of the interface, I guess but symfony docs keep showing this in example, event for 7.x) and some very specific cases but I'm refactoring it to use ServiceProviderInterface instead.
And for the very specific cases, I added the services definitions to keep using ContainerInterface (won't go into details but it's used in files that can't be edited.
But as Symfony keep showing ContainerInterface usage for locator, I thought It could be good to rename ContainerInterface to ServiceProviderInterface, used by ServiceLocator class (and tell synfony to stop showing usage of ContainerInterface ?)

Sounds good 👍 Could you share a diff how this change should look like?
What Symfony version should it target?

Sure
It happened to me with the SymfonySetList::SYMFONY_60 and the removal of ContainerInterface alias is in 6.0 upgrade notes so I'd say symfony: 6.0 ?
And the diff should be something like that (including both ContainerInterface as old content):
- use Psr\Container\ContainerInterface;
// OR
- use Symfony\Component\DependencyInjection\ContainerInterface
+ use Symfony\Contracts\Service\ServiceProviderInterface;

class MyClass
{
    public function __construct(
         #[TaggedLocator(tag: 'app:tag-locator')]
-        private readonly ContainerInterface $locator,
+        private readonly ServiceProviderInterface $locator
    ) {}
}

Not sure if it's possible but to make sure the ContainerInterface is used for locators, we could check the #[TaggedLocator] Attribute or check in the services.yaml ?
To avoid side effects to the maximum

Thanks! Looks good to target 6.0. Checking TaggedLocator makes sense as it's available in the code  :+1:
Would you like to contribute this feature?

I could take a look and let you know if I can do it in a few days, yeah


Remove infinispan

Policy and saml-engine used to use infinispan as a session store.  We
migrated to use Redis instead, but for a transition period we had a
lot of conditional code which allowed the use of either backend.
The time has come to get rid of that code.
Of note:

stop using the old PolicyAppRule (which runs infinispan) and use
PolicyAppRuleWithRedis instead (now renamed to PolicyAppRule)
remove StateDeserializationTest, because Redis uses JSON
serialization instead of old skool java serialization

Does it change anything when running locally? I don't think it uses Redis locally...

@jakubmiarka probably, I didn't look at that. Could I get some help with this? I don't know how local startup works...

@jakubmiarka probably, I didn't look at that. Could I get some help with this? I don't know how local startup works...

@philandstuff we don't use verify-local-startup ... it's set of startup.sh scripts... to run the whole hub locally we use the ida-hub-acceptance test... there's a bunch of config which it uses, so the infinityspan should be replaced with redis there too? https://github.com/alphagov/ida-hub-acceptance-tests/blob/master/configuration/hub/saml-engine.yml#L33
and then add a docker for the redis or however we recommend spinning redis locally? somewhere here https://github.com/alphagov/ida-hub-acceptance-tests/blob/master/scripts/hub-apps-startup.sh

Oh, this is interesting, I think this means the folk-memory "reasons why ZDD tests tends to fail" things I thought I knew are wrong :-) 🎉

Raised https://github.com/alphagov/ida-hub-acceptance-tests/pull/164 to try to fix that? don't know if it works?

@jakubmiarka nice spot, pushed an update to add sensible defaults to local config


is there alternative to used in rust

hello ...
is there an alternative to used in rust project ?? or anyone know about a good example with best practice for rust project

@wprzytula Could you answer that?

I don't understand the question. How should I parse it?
Is used some keyword in Rust driver or gocqlx?

@ikaaasra

So is the question about a gocqlx equivalent for Rust projects?
If so, then there is e.g. charybdis.

Question is answered, closing it.


Handle the send message event on Enter key press

When we use to type the message using Japanese text then we get the suggestion dropdown. If we select the option from the dropdown by pressing the enter key then the "send-message" events get triggered. We need some functionality to handle this scenario.

I cannot reproduce. Which chat version are you using? Which browser? Can you share a video?

Closing this until I get more information

I have forked shift+enter to send message and using this for now.
@antoine92190 Could you please check if it's fit for merge.
https://github.com/antoine92190/vue-advanced-chat/pull/304

Same issue.
This problem only occurs on my mac, it works fine on my windows and android.

I have faced same problem.
Then I have tried #304, it was work fine for me.

I thing we can use KeyboardEvent.isComposing property or compositionstart/compositionend event to determine whether the user is selecting word from a list.
this.getTextareaRef().addEventListener('keyup', e => {
    if (e.key === 'Enter' && !e.isComposing && !e.shiftKey && !this.fileDialog) {
        ...

Hello @antoine92190,
I investigated the error that occurred in CI.
This error only occurs if the typescript version is 4.7, so we can use v4.6.x as a workaround.
I have created new PR for this workaround: #315
Could you please confirm this changes?


Enable checkbox

"Enable" checkbox to determine whether the currently displayed workflow type is enabled
show in green in the dropdown which of the workflow types are currently enabled

closes #118
closes #103

Should we disable all of them by default?

Yes, I think that's reasonable. that's what I'm doing at the moment.

updated the wiki page related to external_code.run_workflow


Adds support for right-padding of logging labels

Sometimes, when multiple loggers emit at the same time, we will want their labels to be padded to the same length, to support correct indentation of the actual logging messages.

@happz we are a bit confused with @janhavlin, is there some example to see it in action? How would it look like?

@happz we are a bit confused with @janhavlin, is there some example to see it in action? How would it look like?

Sure. With labels and shifts, each log message starts at position (len(render labels) + shift * 4). With a single logger, this is fine. With multiple loggers, and when each logger is given different set of labels, like a name of the guest execute should work on, the first element of the expression above differs for each logger:
[server]        this is a logging message 1
[server]            this is a logging message 2
[another-client-2]        this is a logging message 1
[another-client-2]            this is a logging message 2
[client-1]        this is a logging message 1
[client-1]            this is a logging message 2

Note how the actual text of the message starts at different columns. With padding, code that creates the loggers - this bit, in particular: https://github.com/teemtee/tmt/pull/1790/files#diff-d9422da1a3efb9209a7d4beb7d824f85a19e5abe91fb239f74806847d88db266R1441 - can ask logger to pad labels to a defined length, adjusting the indentation:
[server]                          this is a logging message 1
[server]                             this is a logging message 2
[another-client-2]        this is a logging message 1
[another-client-2]            this is a logging message 2
[client-1]                        this is a logging message 1
[client-1]                           this is a logging message 2

That looks weird, I guess you meant
  [server]                  this is a logging message 1
  [server]                    this is a logging message 2
  [another-client-2]        this is a logging message 1
  [another-client-2]          this is a logging message 2
  [client-1]                this is a logging message 1
  [client-1]                  this is a logging message 2

GitHub is silly with this monospace font handling. BTW why is message 2 indented differently in your example @happz ?

@happz we are a bit confused with @janhavlin, is there some example to see it in action? How would it look like?

Sure. With labels and shifts, each log message starts at position (len(render labels) + shift * 4). With a single logger, this is fine. With multiple loggers, and when each logger is given different set of labels, like a name of the guest execute should work on, the first element of the expression above differs for each logger:
[server]        this is a logging message 1
[server]            this is a logging message 2
[another-client-2]        this is a logging message 1
[another-client-2]            this is a logging message 2
[client-1]        this is a logging message 1
[client-1]            this is a logging message 2

Note how the actual text of the message starts at different columns. With padding, code that creates the loggers - this bit, in particular: https://github.com/teemtee/tmt/pull/1790/files#diff-d9422da1a3efb9209a7d4beb7d824f85a19e5abe91fb239f74806847d88db266R1441 - can ask logger to pad labels to a defined length, adjusting the indentation:
[server]                          this is a logging message 1
[server]                             this is a logging message 2
[another-client-2]        this is a logging message 1
[another-client-2]            this is a logging message 2
[client-1]                        this is a logging message 1
[client-1]                           this is a logging message 2

That looks weird, I guess you meant
  [server]                  this is a logging message 1
  [server]                    this is a logging message 2
  [another-client-2]        this is a logging message 1
  [another-client-2]          this is a logging message 2
  [client-1]                this is a logging message 1
  [client-1]                  this is a logging message 2

GitHub is silly with this monospace font handling. BTW why is message 2 indented differently in your example @happz ?

Yeah, looks like a PEBKAC. Messages should indeed be well-aligned, all starting at the same "column" despite the different lengths of labels.


acntDX10Berlin

acntDX10Berlin is required but is not free.
So i cannot compile
C:\Program Files (x86)\Embarcadero\Studio\LimLib\bonecode\BCControls\Packages\BCControls.Delphi.Berlin.Runtime.dproj

TBCEditor control does not require AlphaSkins to be installed. Only demo does but it is nothing but a show case. Install package, drop the control on a form, load highlighter and color. That is the simplest demo you can have, I don't need to create a demo project for it. If the control does not explain itself, I have failed.
FYI: BCControls are controls and components for bonecode software. Most of these are wrappers to enable single point bug fixing and customizing.


refactor metrics

Use dataframes and merge operations instead of many arrays
Extract tracking_metric_dfs function
Handle eta and phi in tracking metrics df

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.02 :tada:

Comparison is base (03ca774) 72.23% compared to head (e539544) 72.25%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   72.23%   72.25%   +0.02%
==========================================
  Files          46       46
  Lines        2550     2552       +2
==========================================
+ Hits         1842     1844       +2
  Misses        708      708

Impacted Files
Coverage Δ

src/gnn_tracking/metrics/cluster_metrics.py
95.23% <100.00%> (+0.11%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix bugs and improve UI

Description
fix bugs on autocomplete, and improve UI on search input line and button. Also deleted all unnecessary "console.log" in the code.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.009%) to 34.615%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/commons/navigationBar/subcomponents/SicpNavigationBar.tsx
0
3
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.009%

Covered Lines:
4823

Relevant Lines:
12985

💛  - Coveralls


Add sections to NavScroll

We need to add new titles that open a section to the nav-scroll part and render to them rich HTML, just like overview. What is the correct way to do this?

New functionality in release 0.4. If you find any issues with it, please create a new issue.


Duplicate and Non-existent

Duplicate achievements:
Deianeira of Snezhevna (The real achievement is also in the Wonders of the World)
Semnai Sans Shadow (The real achievement is in the Fontaine: Dance of the Dew-White Springs (III))
Secret Miracle (Discarded) (The real achievement is also in the Wonders of the World)
Non-existent achievements:
Measure of Interference
Gentle Descent
Hanging Gardens of Plucked Jade

It is almost unbelievable that we have been waiting for several months for duplicate achievements to be removed. This is just a few lines in the database to remove...

Duplicate #487 #488 #491 #493 #497 #498 #500 #504 #513 #517

New non-existent achievement added now


 Fix Missing Cluster ID Qase test

Backport
v2.9 https://github.com/rancher/rancher/pull/47121
v2.8 https://github.com/rancher/rancher/pull/47150
v2.7 https://github.com/rancher/rancher/pull/47154

Is this effectively just updating the config in some cases (when passed withUpdateConfigProvisioning), but in other cases (when passed with UpdateConfigValidation) not doing anything?
Would it make sense to instead just have a bool in the functions that were updated here, and only update the config when true? Apologies if I'm misunderstanding the flow!

Hi Max, yes, you understood the flow! how you said, my first ideia was add a boolean as parameter to controll the config update that is pretty simple and also works very well, but to let the code more flexible, I decided use a "composition" to do it, but it is also a more complex solution

@rancher-max and @slickwarren, reading your comments, I am going to change the implementation and create a new variable with a default value in the create.go to control the config change, with it, I would not need pass a new parameter on the create functions and it also would me let control the config change

my main concern is:
is there a way to instantiate this without having the new struct/interface? we should avoid adding parameters to the Create calls if possible.

Yes, it is possible, I am working in a new solution

last request; can you add to the appropriate README (not sure what that is off the top of my head) when the disable function is appropriate to add? everything LGTM

Yes, I can


[BugFix] enhance analyse for percentile_approx to check constant

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Problem Summary(Required) ：

#21962 forgot to check constant for the second and the third parameter of percentile_approx, so add the check.
Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)
[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/analyzer/FunctionAnalyzer.java
3
3
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/analyzer/FunctionAnalyzer.java
3
3
100.00%
[]

@Mergifyio backport branch-3.0


New-BcContainer error:  The request is not supported

I used the New-BcContainerWizard to create a New-BcContainer script, based on this post:
https://freddysblog.com/2020/07/03/business-central-on-docker-script-generator/
I primarily used the wizard defaults, but chose to create a named image.
When I run the script, I get an error that says "The request is not supported".
docker : hcsshim::CreateComputeSystem 430e5798fe9f22badd413f4c129ff25f20e33fd94f4d7ad40eed240e0b84ab9a: The request is not supported.

I've tried commenting out different parameters for New-BcContainer, but get the same error, resulting in what appears to be orphaned containers and images.

PS script:
$containerName = 'sandbox1'
$password = 'P@ssword'
$securePassword = ConvertTo-SecureString -String $password -AsPlainText -Force
$credential = New-Object pscredential 'admin', $securePassword
$auth = 'UserPassword'
$artifactUrl = Get-BcArtifactUrl -type 'Sandbox' -version '' -country 'us' -select 'Latest'
$licenseFile = 'c:\zdisks\business central\2020-06bcv16license.flf'
New-BcContainer `
    -accept_eula `
    -containerName $containerName `
    -credential $credential `
    -auth $auth `
    -artifactUrl $artifactUrl `
    -imageName 'mybc16' `
    -assignPremiumPlan `
    -licenseFile $licenseFile `
    -dns '<IP_ADDRESS>' `
    -updateHosts
Setup-BcContainerTestUsers -containerName $containerName -Password $credential.Password -credential $credential

Last portion of output:
Downloading Prerequisite Components
Downloading c:\bcartifacts.cache\sandbox\16.3.14085.14363\platform\Prerequisite Components\Open XML SDK 2.5 for Microsoft Office\OpenXMLSDKv25.msi
Downloading c:\bcartifacts.cache\sandbox\16.3.14085.14363\platform\Prerequisite Components\Microsoft Report Viewer 2015\ReportViewer.msi
Downloading c:\bcartifacts.cache\sandbox\16.3.14085.14363\platform\Prerequisite Components\IIS URL Rewrite Module\rewrite_2.0_rtw_x64.msi
Downloading c:\bcartifacts.cache\sandbox\16.3.14085.14363\platform\Prerequisite Components\Microsoft Report Viewer 2015\SQLSysClrTypes.msi
Downloading c:\bcartifacts.cache\sandbox\16.3.14085.14363\platform\Prerequisite Components\DotNetCore\DotNetCore.1.0.4_1.1.1-WindowsHosting.exe
Copying Platform Artifacts
Copy Database
Copy ConfigurationPackages
Copy Extensions
Copy Applications.*
c:\$TMP$-mybc16-sandbox-16.3.14085.14363-us
Sending build context to Docker daemon  1.868GB

Step 1/6 : FROM mcr.microsoft.com/dynamicsnav:10.0.17763.437-generic
 ---> c9779293490e
Step 2/6 : ENV DatabaseServer=localhost DatabaseInstance=SQLEXPRESS DatabaseName=CRONUS IsBcSandbox=Y artifactUrl=https://bcartifacts.azureedge.net/sandbox/16.3.14085.14363/us
 ---> Running in 7a1ded183828
Removing intermediate container 7a1ded183828
 ---> ac235fecaf70
Step 3/6 : COPY my /run/
 ---> d5df05a299c8
Step 4/6 : COPY NAVDVD /NAVDVD/
 ---> d0ec30d0e948
Step 5/6 : RUN \Run\start.ps1 -installOnly
 ---> Running in 430e5798fe9f
docker : hcsshim::CreateComputeSystem 430e5798fe9f22badd413f4c129ff25f20e33fd94f4d7ad40eed240e0b84ab9a: The request is not supported.
At C:\Program Files\WindowsPowerShell\Modules\navcontainerhelper\<IP_ADDRESS>\ContainerHandling\New-NavImage.ps1:294 char:1
+ docker build --isolation=$isolation --memory $memory --tag $imageName ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (hcsshim::Create... not supported.:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

I deleted all BC containers and images, including the generic image, and then ran the script again.  It completed successfully.

Very strange.
The imagename parameter will save the image and that should actually be the safe route (like if the other one fails)
Could you dump the full output of the container generation when you leave out imagename?
Thanks

I ran this script to create "sandbox3", without the imageName parameter.  The container was created successfully.
$containerName = 'sandbox3'
$password = 'P@ssword'
$securePassword = ConvertTo-SecureString -String $password -AsPlainText -Force
$credential = New-Object pscredential 'admin', $securePassword
$auth = 'UserPassword'
$artifactUrl = Get-BcArtifactUrl -type 'Sandbox' -version '' -country 'us' -select 'Latest'
$licenseFile = 'c:\zdisks\business central\2020-06bcv16license.flf'
New-BcContainer `
    -accept_eula `
    -containerName $containerName `
    -credential $credential `
    -auth $auth `
    -artifactUrl $artifactUrl `
    -updateHosts `
    -assignPremiumPlan `
    -licenseFile $licenseFile `
    -dns '<IP_ADDRESS>'
    #`
    #-imageName 'mybc16'

Setup-BcContainerTestUsers -containerName $containerName -Password $credential.Password -credential $credential

Attached is the output from the successful container generation process.
sandbox3 log.txt

Your host is 10.0.17763.107 - that is a very very old un-updated Windows and that is likely the reason for this.
Could you try to add -isolation hyperv to the script when using -imagename to see whether that changes anything?
Thanks

Thank you!
It looks like Windows Update had a few updates that failed, and that was preventing any new updates.
I cleared out the failed updates, rebooted, then applied the latest 1809 update.
It’s now on 17763.1282.
Tomorrow I will delete all containers and images and try the script again.

I had the same issue and I've changed "isolation" the from hyper-v to process.
I also updated docker on my windows-server by following this:
https://docs.microsoft.com/en-us/virtualization/windowscontainers/quick-start/set-up-environment?tabs=Windows-Server

After installing the Windows Updates and getting on build 17763.1282, the New-BcContainer script is working properly with the imageName parameter.
The script no longer issues the warning about the Host OS mismatch!  Yeah!

I learned several lessons from this and will be doing a video on it.
Thanks for the help Freddy!

Issue resolved by installing Windows Updates, removing containers and generic image based on older Windows version, and then re-running the New-BcContainer script with the imageName parameter. 👍

Issue resolved by installing Windows Updates, removing containers and generic image based on older Windows version, and then re-running the New-BcContainer script with the imageName parameter. 👍


Feat : Details page - Temporal coverage

Feature: Details page - Temporal coverage

As a User of the portal on the details page of a dataset,
I want to read the temporal coverage of the dataset
So that I easily understand the context of this dataset

Acceptance criteria
Scenario: General display
Given that I am a user of the web portal on the detail page of a dataset,
And I am using any device,
When the Start date and End date of a dataset are filled out,
Then I should see From Start date + To End date displayed on 2 lines (mock up 1)
When only the Start date of a dataset is filled out,
Then I should see From Start date (mock up 2)
When only the End date of a dataset is filled out,
Then I should see To End date (mock up 3)
When there is no date filled out,
Then I should not see Temporal Coverage
Scenario : Error
Given that I am a user of the web portal on the detail page of a dataset,
And I am using any device,
When the Start Date or the End date are not filled out correctly (bad format or Start Date later than End Date for instance)
Then I should see a dash (mock up 4)
Scenario : Internationalization
Given that I am a user of the web portal on the detail page of a dataset,
And the selected language is English
Then the date format should be MM/dd/yyyy
And texts should be displayed in English
From
To
Given that I am a user of the web portal on the detail page of a dataset,
And the selected language is French
Then the date format should be dd/MM/yyyy
And texts should be displayed in French
Depuis le
Jusqu'au
Given that I am a user of the web portal on the detail page of a dataset,
And the selected language is German
Then the date format should be dd.MM.yyyy
And texts should be displayed in German
Von
Bis
Resources
Mockups
1 /
2/
3/
4/
Environment

staging URL: https://app.staging.okp4.network/

Additional informations
None.

@MdechampG could you confirm me that the german date is dd.MM.yy? Or like french and english, the year is display with 4 digits ? dd.MM.yyyy? Thanks

@0xLodz I checked with @lmarline and finally it's not the good format. It should be exactly like for French dd/MM/yyyy
I have updated the issue description.

Thanks @MdechampG , I also guess that we need french and german translations for "From:" and "To:".
Is "De : " and "À : " for french and "Von : " and "Bis : " for german the most appropriate?
Thanks

@lmarline thanks for the clarifications!
@MdechampG it looks weird in french with De and À.

Depuis le and jusqu'au seems more appropriate, what do you think?

@0xLodz I have added the error Start End later than End date in the Scenario Error.
We should see a dash as well as for the format error.

Thanks @lmarline for the trad in German !
@0xLodz You're right it's better with Depuis / Jusqu'au.
I add the translations in the issue :)

@MdechampG on the mockup we don't have colons. Should we display them? Thanks

@0xLodz you can show or hide them in the right menu in the "Layout Grid" section by pressing the eye

@SpicySalm0n sorry if I wasn't clear in my previous request. I asked for the colons : between From and the date.

@0xLodz
Yes mb I understand "columns" 😅
I updated all the mock-ups!

Test on firefox desktop

S1 : Executed, only the start and end date both filled is passed,

I need dataset with only a start date, and a dataset with only an end date, and a dataset with no date

S2 : Not executed


Reduce the overhead of Parse calls

Saves 8 % (~65 ns) on my machine when parsing Markdown.Parse("foo", _pipeline) with
new MarkdownPipelineBuilder().UsePreciseSourceLocation();

and 15 % (~150 ns) with UseAdvancedExtensions.

Thanks!


The file share snapshot doesn't auto display in the new file explorer

Storage Explorer Version: 1.32.0-dev (93)
Build Number: 20230908.4
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Ventura 13.5 (Apple M1 Pro)
Architecture: x64/x64/arm64
How Found: From running test cases
Regression From: Previous release (1.31.1)
Steps to Reproduce

Expand one storage account -> File Shares.
Create a file share -> Click 'View Share Snapshots'.
Right click the file share -> Click 'Create Snapshot'.
Check whether the snapshot auto displays.

Expected Experience
The snapshot auto displays.
Actual Experience
The snapshot doesn't auto display.

Verified this issue on the build 20230911.1. Fixed.


signalbackup-tools: 20230421-1 -> 20230424-1

Description of changes
Updated to latest version. No changes that effect build (diff: https://github.com/bepaald/signalbackup-tools/compare/20230421-1...20230424-1).
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.


Create redirect

Coverage increased (+3.9%) to 64.414% when pulling e38af6a64a99e48cbc8cf25d2c1af003f38876d7 on create-redirect into c8924e75821cf6be688828e0fe96f241e23fda8c on development.


MSVC: Remove duplicated line

Codecov Report

Merging #4436 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4436      +/-   ##
==========================================
+ Coverage   80.41%   80.42%   +<.01%
==========================================
  Files         110      110
  Lines      142935   142935
==========================================
+ Hits       114948   114954       +6
+ Misses      27987    27981       -6

Impacted Files
Coverage Δ

src/gui_gtk_x11.c
48.27% <0%> (-0.4%)
:arrow_down:

src/term.c
73.68% <0%> (-0.06%)
:arrow_down:

src/window.c
86.39% <0%> (-0.04%)
:arrow_down:

src/os_unix.c
60.67% <0%> (+0.04%)
:arrow_up:

src/if_xcmdsrv.c
84.2% <0%> (+0.17%)
:arrow_up:

src/gui.c
58.09% <0%> (+0.72%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80f9542...06c7c9e. Read the comment docs.


Getting started instructions fail

Package version (if known): v1.0.0-alpha.14
Describe the bug
Following  instructions literally from https://inveniosoftware.github.io/react-searchkit/docs/getting-started produces the following compilation error:
Compiling...
/home/cebrian/borralodedentro/search-app/node_modules/react-scripts/scripts/start.js:19
  throw err;
  ^

[Error: ENOENT: no such file or directory, stat '/initrd.img'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'stat',
  path: '/initrd.img'
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Steps to Reproduce

Follow instructions in https://inveniosoftware.github.io/react-searchkit/docs/getting-started
When running yarn start you'll see the compilation error

Expected behavior
Demo application up and running
Additional context
Used:

node v15.13.0
npx 6.14.8
yarn 1.22.5

Hi @tonicebrian it might be that you are missing some required modules, try to run this command to add them:
npm install axios react-overridable react-redux react-thunk redux-thunk semantic-ui-react

Thanks for reporting this, we will update the getting started guide.
Please let us know if this solved your problem.

I solved the problem by removing all the node modules in my computer and reinstalling them again. I still don't know what was going on.


Linq to query wrong query generation ?

Describe what is not working as expected.
I have a linq query to get max with where clause, But i am getting values even if its null.
var max = _context.Table.Where( x => x.ParentId == dto.ParentId  ) // property is null
                                      .Max( x => x.Order);

Should generate the SQL like this i guess?
SELECT MAX([x].[Order])
FROM [Table] AS [x]
WHERE [x].[ParentId] = null

but i am getting the SQL like this.
SELECT MAX([x].[Order])
FROM [Table] AS [x]
WHERE [x].[ParentId] IS NULL  -- is should be equal (=) ?

Even the where clause predicate is falsy as null property, i am getting values?

If you are seeing an exception, include the full exceptions details (message and stack trace).
none

Steps to reproduce

Create Linq query to get max with where clause.
.Where( x => x.ParentId == dto.ParentId  ).Max( x => x.Order)

Check the generated SQL query using SQL Server Profiler.

Further technical details
EF Core version: 1.1.2
Database Provider: 1.1.2
Operating system: windows 10
IDE:  Visual Studio 2017 release

What is the value of dto.ParentId?

It is an int which is nullable

In T-SQL while using comparison operators, if any argument is null then it returns UNKNOWN which is different from how it works in C#. Hence a == null in C# gets translated to a is NULL in T-SQL.
More info on null handling in t-sql here https://docs.microsoft.com/en-us/sql/t-sql/queries/is-null-transact-sql
To check if result from database actually match up with what in memory would give run this query,
var maxInMemory = _context.Table.ToList().Where( x => x.ParentId == dto.ParentId  ).Max( x => x.Order);
Both will give same results.

You mean that any null arguments gets translated to a is NULL  and if i want to translate is to be equal  then i have to call .ToList() before comparison? That's what your saying? Thanks

Yes by default == null will get translated to Is NULL to get results as C# would expect. EF Core compensate for difference between database/in memory null handling. If you want to remove this processing done by EF and convert == null to database as = NULL then you can configure it.


Remove link to FAF Statuspage

The FAF Statuspage will be taken offline soon.
Please remove the reference on the login screen.

@Brutus5000 why will it be taken offline? Is there a replacement?

No one ever has the time or thinks to update it. So it has become more of a source of misinformation than anything else

A health-check service would then be nice :)

@micheljung Atlassian statuspage does not offer any automation - at least in the free tier. So I still need to post it in other places as well manually. And they do some internal changes so if we don't do some migration steps they delete the statuspage so why bother ;)


rework block arg handling to avoid allocations in (some) common cases

Motivation

The motivating example here is something like:
def foo(args, &blk)
  ...
  begin
    yield
  ensure
    ...
end

With the current compiler, it will look like blk is referenced by the top-level method (ruby block 0) and the begin "block" (ruby block 1 or so).  Therefore, blk will be eagerly converted to a proc (setting aside issues of type-checking) so that it can be stored on the Ruby stack, since the "variable" for the block is referenced in multiple Ruby blocks.
This is clearly suboptimal: the extra allocation is totally unnecessary.
This approach this PR takes is to more carefully track how the block arg is used throughout the method: we can avoid turning the block into a proc if all its uses are either in the top-level method or in a "block" that would share the same stack frame as the method (since the original block could still be fetched always as though we were in the top-level method).  TrackCaptures, then, is augmented to do this extra tracking of how the block argument is used.  I think this provides a much firmer foundation for our current optimizations of when we can pass through block and yield directly to blocks...but it is also a moderately large amount of code.
This PR does not (yet?) address the equally common case of:
def foo(args, &blk)
  bar do
    ...
    yield
    ...
  end
  ...
end

The VM avoids allocating a complete proc for blk here by passing a proxy object that knows how to fetch the original block.  We should do this too, and I think this PR might be able to be extended to handle that case.
Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_KbPIWw4ON3dgR3
→ https://go/builds/bui_KbPIyMw6ZvpXCG


Fix build

het thanks I did not fix my nix build script anyways I will resolve the conflicts and merge today.


Update Scala.js, refined patch version, etc.

Codecov Report

Merging #920 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #920      +/-   ##
==========================================
+ Coverage   85.72%   85.76%   +0.04%
==========================================
  Files          76       76
  Lines        2459     2459
  Branches      157      157
==========================================
+ Hits         2108     2109       +1
+ Misses        351      350       -1

Impacted Files
Coverage Δ

.../core/shared/src/main/scala/io/circe/Decoder.scala
92.69% <0%> (+0.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc10db...50acea7. Read the comment docs.


Implement fromCell and fromSlice methods for structs

Closes #344

[x] I have updated CHANGELOG.md
[x] I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
[x] I have run all the tests locally and no test failure was reported
[x] I have run the linter, formatter and spellchecker
[x] I did not do unrelated and/or undiscussed refactorings

Just realised that I didn't add any negative tests for struct parsing

@anton-trunov do you mean a user-defined function with the same name - fromCell or fromSlice?
I think it should work the same way as it works for all other built-ins such as toCell for structs, and set, get and del for maps.

@Gusarich Yep. Because right now this shadowing is allowed and it overrides the generated code.

@Gusarich Yep. Because right now this shadowing is allowed and it overrides the generated code.

Should we forbid such shadowing for all built-in functions?

Yeah, we do not allow any form of shadowing in Tact. And if we do, it's a bug

btw, there is some merge conflicts

Yeah, we do not allow any form of shadowing in Tact. And if we do, it's a bug

In this case maybe we should create a separate issue about that and resolve that in another PR?

In this case maybe we should create a separate issue about that and resolve that in another PR?

Yeah, there are issues like that, for instance #307. There is a special tag for those https://github.com/tact-lang/tact/labels/scope%3A var-scope


When view load set a anydate as selected

hello, when I show calendar need to show default date as selected ... not today

@zahedul  Just call selectDate:


[Clear btn]  should not clear query area

Describe the bug
Hi,
when click btn Clear beside clear result of the query ( on bottom),
its clear also  query area.
To Reproduce
Steps to reproduce the behavior:

create a query
click on run or F5
click on clear btn

Expected behavior
should only affect the bottom area ( result area), not query area
Application (please complete the following information):

App client: sqlite3
App version: 0.5.18
Installation source: linux store ( ubuntu budgie)

Environment (please complete the following information):

OS name: ubuntu budgie
OS version: 20.04.5 LTS
DB name: sqlite3
DB version: -

Additional context
Add any other context about the problem here.

Hi @ampmonteiro,
The clear button is designed to empty both the query area and the results.

Hi @Fabio286.
ok, it is not a bug but if you see, for example on the console of the browser or even in the vs code, will not affect the main area, only bottom area.
My suggestion is:  clear btn affect bottom and for query area you could create an action on context menu of query area by doing right click with ' clear'.
Of course, it is up to you, if you want to implement this suggestion.
If you want, you can close the issue,
Thanks for the program, i find out today, it is great replacement for what used until today and i will make the same switch on my computer of the company( with windows) ;)

I'm glad to know that you appreciate Antares, thank you.
The clear button was implemented to do a reset of the query tab, but i will consider your feedback and eventually future changes if i will receive other opinions related.


Demoted manager can rejoin if waiting for role change times out

There's a rather interesting integration test failure here: https://circleci.com/gh/docker/swarmkit/6331
The Raft ID of the node that's left over in the manager list at the end is 1B8568509E87E6C. But curiously, this node never becomes the leader, so based on the test it never should have been demoted.
After a lot of staring at the log, I think I've figured out what's going on. This Raft ID is the result of the demoted node joining Raft a second time. Notice this log message:
time="2017-02-27T21:30:16Z" level=warning msg="failed to get worker role after manager stop, restarting manager" module=node testnode=2

That means the agent took too long to reconnect to the surviving manager and get the role change notification. Normally restarting the manager is the right thing to do in this case. But if the manager was stopped because it was removed from Raft, restarting it is very bad, because it will cause it to join again.
A simple fix for this would be to avoid restarting the manager if the manager was stopped because it was removed from Raft. This isn't perfect, because if the agent can't reconnect to a surviving manager for some reason, no certificate renewal will be triggered, and on the next restart, this node will start up as a manager, rejoining the Raft cluster under a new Raft ID. To deal with this, we might consider forcing a certificate renewal after the timeout on the role change.
I'll submit a PR to fix this case. Separately, I'll submit a PR to improve logging in integration tests, which is very ambiguous right now.

Hm, this is actually harder than it looks. The node can't really distinguish a demotion without a matching role change from a rapid demote/promote cycle. That means there's no right thing to do in this case. Restarting the manager may be wrong because it could cause a demoted manager to add itself to the Raft cluster as a new node; not restarting the manager may be wrong because we could be ignoring a promotion.
The 16 second timeout in place was clearly put there to try and deal with this problem. It seems it's not completely reliable, though.

cc @LK4D4 (just in case)


Missing fork methods in PUT builds on NonStop

In 3.0, the following methods are missing from the POSIX user thread build, referenced by liblegacy-lib-threads_pthread.o:

OPENSSL_fork_prepare
OPENSSL_fork_child
OPENSSL_fork_parent

This occurs during the link phase of providers\legacy.so.

This appears to occur because of:
https://github.com/openssl/openssl/blob/648cf9249e6ec60e0af50d5d903e05244b837cb0/crypto/init.c#L669
not being defined for NonStop platforms. The following might solve this:
#if defined OPENSSL_SYS_UNIX || defined OPENSSL_SYS_TANDEM

If appropriate, I will create a PR for this.

Hmm. They are defined in init.c - and that file is not included when building liblegacy:
$UTIL_COMMON=\
        cryptlib.c params.c params_from_text.c bsearch.c ex_data.c o_str.c \
        ctype.c threads_pthread.c threads_win.c threads_none.c initthread.c \
        context.c sparse_array.c asn1_dsa.c packet.c param_build.c $CPUIDASM \
        param_build_set.c der_writer.c passphrase.c
$UTIL_DEFINE=$CPUIDDEF

SOURCE[../libcrypto]=$UTIL_COMMON \
        mem.c mem_sec.c \
        cversion.c info.c cpt_err.c ebcdic.c uid.c o_time.c o_dir.c \
        o_fopen.c getenv.c o_init.c init.c trace.c provider.c \
        punycode.c \
        $UPLINKSRC
SOURCE[../providers/libfips.a]=$UTIL_COMMON
SOURCE[../providers/liblegacy.a]=$UTIL_COMMON

I have no idea why they are included in init.c. The only place they are ever referenced from internally is threads_pthread.c - and they are only relevant in a pthreads build. I'd suggest we move their definitions (which are empty anyway) in threads_pthread.c.
The alternative is to remove them completely. They are totally unused, and do nothing - but they do form part of the public API.

not being defined for NonStop platforms.

The reference for them has the same guard - so this doesn't look like the issue to me:
#  ifdef OPENSSL_SYS_UNIX
static pthread_once_t fork_once_control = PTHREAD_ONCE_INIT;

static void fork_once_func(void)
{
    pthread_atfork(OPENSSL_fork_prepare,
                   OPENSSL_fork_parent, OPENSSL_fork_child);
}
#  endif

My impression from the documentation is that external developers can fill these in with whatever they need on a platform basis. Doesn't help though. It has me scratching my head as to why these are being referenced  through that guard, but they are.

My impression from the documentation is that external developers can fill these in with whatever they need on a platform basis.

No. The idea is that applications can call these manually to inform OpenSSL about forks - if OpenSSL is running on a platform where it can't detect the fork itself. I think the original idea was that OpenSSL would do something in response to this information (e.g. reseed the DRBG). However in practice calls to these functions are ignored and have been ever since they were first introduced in 1.1.1. So they are no-ops and always have been no-ops. I doubt very much anyone is actually calling them, so we probably could just delete them entirely and no-one would notice. However strictly speaking that is an API break that would require an OMC vote.

@mattcaswell 's summary is correct and they should at least be deprecated.

I'm just testing the change to move the content from init.c to threads_pthread.c, which should ensure that the build works without changing functionality and will push when it's done.

Aside: I'm finding other configuration nits around PUT and SPT builds. Will open those as a separate issue. Very small cleanup changes in 50-nonstop.conf. :(

However in practice calls to these functions are ignored and have been ever since they were first introduced in 1.1.1

Technically they were used for a while for actual robust DRBG fork-safety, which got ripped out in favor of the simple pid-based mechanism by https://github.com/openssl/openssl/pull/9832 (so the use never made it into a release).

@kaduk well the PR should be ready in any event.

Looks happy now


Move terraform project versions to JSON file

Moves the terraform-dxw-dalmatian-account-bootstrap and terraform-dxw-dalmatian-infrastructure versions to terraform-project-versions.json, which allows for easier version bumping
Bumps terraform-dxw-dalmatian-infrastructure to v0.22.0
https://github.com/dxw/terraform-dxw-dalmatian-infrastructure/compare/v0.21.5...v0.22.0

Changed to 2 commits and fixed the bugs 👍


Upgrade golangci-lint to 1.19.1

Fix whitespace and stylecheck errors.
Disable godox.
preparing https://github.com/pion/.goassets/pull/4

Codecov Report

Merging #975 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #975      +/-   ##
==========================================
- Coverage   74.34%   74.21%   -0.14%
==========================================
  Files          66       66
  Lines        4978     4979       +1
==========================================
- Hits         3701     3695       -6
- Misses        958      964       +6
- Partials      319      320       +1

Flag
Coverage Δ

#go
76.29% <ø> (-0.16%)
:arrow_down:

#wasm
68.71% <ø> (+0.02%)
:arrow_up:

Impacted Files
Coverage Δ

peerconnection.go
73.01% <ø> (ø)
:arrow_up:

internal/mux/mux.go
84.61% <ø> (ø)
:arrow_up:

pkg/media/oggwriter/oggwriter.go
75.67% <ø> (ø)
:arrow_up:

pkg/media/samplebuilder/samplebuilder.go
91.07% <ø> (ø)
:arrow_up:

pkg/media/ivfreader/ivfreader.go
67.3% <ø> (ø)
:arrow_up:

internal/util/util.go
80% <ø> (ø)
:arrow_up:

pkg/media/ivfwriter/ivfwriter.go
58.82% <ø> (ø)
:arrow_up:

sctptransport.go
75.38% <0%> (-3.59%)
:arrow_down:

datachannel_js.go
45.53% <0%> (+0.49%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82324cc...01fa746. Read the comment docs.