Nodepools servers custom configuration

Hello,
Great job !!
Hetzner answered that they are not planing to add new images! (MicroOs request).
So meanwhile would be great if we could run (aka cloud-init) a list [] of commands to have a persisten nodepools server's custom setup.
Jorge

Hello @AdZoAi, thanks for pinging Hetzner, it's good to let them know our interest.
What do you mean by persistent nodepools server's custom setup? As currently, we do set up the MicroOS image via cloud-init already, to make it ready to receive k3s.

Hello
What we would like is to have the chance to be able to pass and "append" our scripts to yours in that "cloud init" you  use, so that we do not have to run our scripts manually in each server (also less prone of errors in case of a scale up down where always all nodes in a given nodepool should have the same config).
Regards,
Jorge

Our cloud init file is here https://github.com/kube-hetzner/terraform-hcloud-kube-hetzner/blob/master/modules/host/templates/userdata.yaml.tpl, as it is yaml, it can be optionally generated with the yamlencode terraform function, which would allow better merging with your config.
When you have something working, please do not hesitate to submit a PR back if you think that's a feature others would need.

Also please note that the node setup is done in an independent module https://github.com/kube-hetzner/terraform-hcloud-kube-hetzner/tree/master/modules/host.

Hello,
Many thanks for the detailed info!!


docs: align sources & generated content

Following https://github.com/okp4/contracts/pull/361, ensure that sources and generated documentations are aligned.

size-limit report 📦

Path
Size

target/wasm32-unknown-unknown/release/okp4_objectarium.wasm
427.68 KB (0%)

target/wasm32-unknown-unknown/release/okp4_law_stone.wasm
636.59 KB (0%)

target/wasm32-unknown-unknown/release/okp4_cognitarium.wasm
790.47 KB (0%)


Reduce rate of taking all Monitor locks in string interning

Reduce rate of taking numProcessors or even more Monitor locks in string interning by increasing initial size of the string interning dictionary.
Increases from 31 to 2048.NextPrime() initial capacity. In medium-sized codebases (3K proj files) we see 200K of these; for 500 projects, 48K.
Intended to also reduce the rate of exceptions we see parsing large repos in QuickBuild:
System.UnauthorizedAccessException: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED))
at System.Threading.Monitor.Enter(Object obj)
at System.Collections.Concurrent.ConcurrentDictionary2.AcquireLocks(Int32 fromInclusive, Int32 toExclusive, Int32& locksAcquired)    at System.Collections.Concurrent.ConcurrentDictionary2.GrowTable(Tables tables, IEqualityComparer1 newComparer, Boolean regenerateHashKeys, Int32 rehashCount)    at System.Collections.Concurrent.ConcurrentDictionary2.TryAddInternal(TKey key, TValue value, Boolean updateIfExists, Boolean acquireLock, TValue& resultingValue)
at System.Collections.Concurrent.ConcurrentDictionary2.GetOrAdd(TKey key, TValue value)    at Microsoft.Build.OpportunisticIntern.BucketedPrioritizedStringList.TryIntern(IInternable candidate, String& interned)    at Microsoft.Build.OpportunisticIntern.BucketedPrioritizedStringList.InterningToString(IInternable candidate)    at Microsoft.Build.Evaluation.Expander2.PropertyExpander1.ExpandPropertiesLeaveTypedAndEscaped(String expression, IPropertyProvider1 properties, ExpanderOptions options, IElementLocation elementLocation, UsedUninitializedProperties usedUninitializedProperties)
...

What is the cause for the "access is denied" -- do you know whether that repros in .NET Core?

@danmosemsft QuickBuild is massively parallel threaded and running on 48- and 64-core datacenter machines. The error above seems to come from any time most or all of the thread pool is waiting synchronously on a Monitor, in this case there are many many threads trying to run XML and OM parsing of 3K-25K proj files in large MSBuild repos. The rate of these types of errors is 1-5 in 45K builds per day, so 0.01%, but the number of builds grows daily and these errors get magnified over time. This PR is simply a reduction in wasteful locking but will only affect the rate of the errors, not fix them entirely. I'm working on the threading model in a separate set of changes in QuickBuild's repo as well.

@danmosemsft Also - no idea if this repros on NetCore, QuickBuild only just got to 4.7.2 because of back-compat requirements across all divisions in the company. By the time we move to Core this problem should be eliminated through thread model changes.

Test failures are known; I'm fixing them.

Something got confused and a stale check run is sticking around. Bouncing the PR.

I find the check failure mysterious (it's showing both passed and failed, from two different top-level checks) and I'm going to just ignore it.


Bumped Spring Boot versions

Related pull request: https://github.com/stratospheric-dev/stratospheric-book/pull/76

I'd suggest to stay in the Spring Boot 2.4.X branch for a little bit longer. The Spring Cloud version we're using is also "only" supporting Spring Boot 2.3.X and 2.2.X.
With the migration to awspring I would also bump Spring Boot 2.5.X (or even 2.6.X if it's already available then)

I'd suggest to stay in the Spring Boot 2.4.X branch for a little bit longer. The Spring Cloud version we're using is also "only" supporting Spring Boot 2.3.X and 2.2.X.
With the migration to awspring I would also bump Spring Boot 2.5.X (or even 2.6.X if it's already available then)

I've now tentatively migrated to Spring Cloud AWS, too. I've also created a branch for the book in which relevant versions have been updated: https://github.com/stratospheric-dev/stratospheric-book/pull/76

I wouldn't do the migration to awspring now shortly before we go live. While dependency-wise it's just changing the import, there are some parts that have changed and get simplified. This would take some additional time to reflect both in code and in writing.
I'd do the migration in the post-release time and for now stick to Spring Boot 2.4.X and the "old" Spring Cloud AWS.


Night CI 2024-01-08: Failed

action url: https://github.com/spidernet-io/egressgateway/actions/runs/7452529903

• [FAILED] [30.518 seconds]
Reliability [Reliability]
/home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_test.go:30
  Test the drift of the EIP [BeforeEach]
  /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_test.go:43
    restart components [R00007]
    /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_test.go:225
      restart calico-kube-controllers
      /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_test.go:299

  Timeline >>
  > Enter [BeforeEach] Test the drift of the EIP - /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_test.go:43 @ 01/08/24 20:23:16.228
  succeeded to create the gateway: egw-007fccd2-aeb1-4f28-9687-4424049fac82
  v4DefaultEip: <IP_ADDRESS>, v6DefaultEip:
  Automatically polling progress:
    Reliability Test the drift of the EIP restart components restart calico-kube-controllers (Spec Runtime: 20.001s)
      /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_test.go:299
      In [BeforeEach] (Node Runtime: 20.001s)
        /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_test.go:43

      Spec Goroutine
      goroutine 857 [sleep]
        time.Sleep(0x1dcd6500)
          /opt/hostedtoolcache/go/1.20.5/x64/src/runtime/time.go:195
        github.com/spidernet-io/egressgateway/test/e2e/common.CreateDaemonSet({0x2971330, 0xc0000501b8}, {0x2978f00, 0xc0004b7b00}, {0xc0004bff00, 0x33}, {0xc000046246, 0x2e}, 0x0?)
          /home/runner/work/egressgateway/egressgateway/test/e2e/common/ds.go:71
      > github.com/spidernet-io/egressgateway/test/e2e/reliability_test.glob..func3.1.1()
          /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_test.go:69
            |
            | // daemonSet
            > daemonSet, err = common.CreateDaemonSet(ctx, cli, "ds-reliability-"+uuid.NewString(), config.Image, time.Minute/2)
            | Expect(err).NotTo(HaveOccurred())
            | GinkgoWriter.Printf("succeeded to create DaemonSet: %s\n", daemonSet.Name)
        github.com/onsi/ginkgo/v2/internal.extractBodyFunction.func3({0x474667, 0x0})
          /home/runner/work/egressgateway/egressgateway/vendor/github.com/onsi/ginkgo/v2/internal/node.go:463
        github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func3()
          /home/runner/work/egressgateway/egressgateway/vendor/github.com/onsi/ginkgo/v2/internal/suite.go:889
        github.com/onsi/ginkgo/v2/internal.(*Suite).runNode
          /home/runner/work/egressgateway/egressgateway/vendor/github.com/onsi/ginkgo/v2/internal/suite.go:876
  [FAILED] Unexpected error:
      <*errors.errorString | 0xc0004961e0>:
      create DaemonSet time out
      {
          s: "create DaemonSet time out",
      }
  occurred
  In [BeforeEach] at: /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_test.go:70 @ 01/08/24 20:23:46.577


Change detail level adaptively

This PR is to enable #2.
n is calculated by log10(3 / range) * 30 + 100.

@timdiller
Thank you for your comment.
Regarding the detail level, I miscalculated it. n should have been calculated by log10(3 / range) * 300 + 100 for range=0.0003 and n=1000. I modified the calculation. https://github.com/kuromusha/mandelbrot-chaco/pull/4/commits/d2baa88beaf0885d2c0da04f9c705e69c2044da4 It looks better than before. But it takes more time for extreme zoom factors and the calculation formula can be improved as you mentioned. (They are other problems, though.)
Regarding the drawing performance, I modified the way of updating the plot as you advised. https://github.com/kuromusha/mandelbrot-chaco/pull/4/commits/dd04858dd7dcc988db12fde5ae7cf88a48bb73cc The performance became a little better. Thank you very much for your advice!

@kuromusha Looks good to me.  See here for help on how to link a pull request to an issue.  You can explicitly make the link by editing the PR through the Github interface, or you can include the words " Closes #2 " in the description to trigger it implicitly.

@timdiller
Thank you. I linked this PR with the Issue #2. And I merge this.


Use OpenTelemetry SDK in HotROD

replacing the jaeger-client-go ot tracer implementation with the ot-otel bridge implementation

Signed-off-by: rbroggi<EMAIL_ADDRESS>Which problem is this PR solving?

Issue #3380

Short description of the changes

First iteration in replacing the jaeger client ot tracer implementation with the otel bridge ot implementation

Some comments:
With this change something is not really going as planned as the DAG I get is:

instead of the one in the article
Another change that will have to be documented is that we also need to open the grpc port while running the all-in-one container for the go binary to reach jaeger:
docker run -d -p6831:6831/udp -p16686:16686 -p14268:14268 jaegertracing/all-in-one:latest

Will there be a way to update the medium article (it was very useful to me, it would be a shame to loose it)

The frontend tracers are not connecting to the rest:

The frontend tracers are not connecting to the rest:

Dear @yurishkuro, would you have any advice on how I could troubleshoot this problem efficiently?
By investigating the code I fail to understand why this change had an impact only in the frontend component of the HOTRod. Well I'm not even sure whether the problem lies 100% on the frontend, the only real info I have is that there is a discontinuity between the trace from frontend and the others.

I suspect this has something to do with the propagator of the context on the wire. What happens when the code calls tracer.Inject() and the tracer is the one from the bridge?

This was finished in #4187


visualization

Hi,
I've used 'visualize' option to view the subgraphs and predicted ratings. I wanted to know how to get the user and item ids corresponding to the 'red' and 'blue' nodes in the visualization.pdf so that it can be identified which target user-item pair this enclosing subgraph has been built around.
I am using this code for a new dataset, and I want to annotate the nodes in the visualization with the actual row and column indices so that the rating matrix can be tallied with the corresponding subgraph. Thanks.

It's not directly supported and needs some work. Because the original node indices have been removed when constructing the local enclosing subgraphs, there are no node indices recorded in each PyG data object. You may need to modify this function (and the following functions that call it) to record the ind[0] and ind[1], then you can visualize them.


Logging for launcher

Added logging functionality and also added the debugging changes so that it works on windows.

This change is

Closing, new PR to be opened after further discussion and branch cleanup


generic_activation is using too many registers

Branch/Tag/Commit
main
Docker Image Version
nvcr.io/nvidia/tritonserver:22.12-py3
GPU name
A100
CUDA Driver
515.86.01
Reproduced Steps
I'm trying to implement the LLaMA model which requires generic_activation in its FFN. However, I'm getting "CUDA runtime error: too many resources requested for launch" for the kernel, which usually means launching the kernel using the configuration is taking too many registers than the SM has.
I commented out some of the branches I don't need and it works now. Using templated dispatching instead of runtime branching maybe helpful in reducing the register pressure here.

So you got it working for LLaMa @lzhangzz? Do you have example code that I could refer to?


Your first program: Android Basics with Compose

URL of codelab
In which task and step of the codelab can this issue be found?
Describe the problem
Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

@irmanfauzi33
Please provide detailed information about what issue you are facing.

The issue is closed as no further clarification of it was provided.


Trigger actions (If this, then that)

Would be cool to build out "workflows" to do some basic "scripting" via a UI. For instance, "if I get a text, and the text contains some sort of keyword, do something". Or, "if I get a text during a date range, auto reply with an away message"

Gonna close this in preference of endless possibilities with REST API / webhooks


Aggregation filter is being pushed down in a way it breaks SQL semantics

Right now in Pinot, aggregation filters like select SUM(1) FILTER (WHERE a = 1) from Table are pushed down into something like SELECT SUM(1) FROM Table WHERE a = 1. That is fine and it is even desired given it allows us to use indexes in this kind of queries.
But the same optimization is also applied to queries with group by like: select b, SUM(1) FILTER (WHERE a = 1) from Table group by b, which are translated to SELECT b, SUM(1) FROM Table WHERE a = 1. This is incorrect if there are values of b which are never assigned to an a whose value is 1. For example, assuming Table is:
a | b
-----
1 | 0
2 | 0
2 | 1

Then the expected result for select b, SUM(1) FILTER (WHERE a = 1) from Table group by b is:
b | sum
-------
0 | 1
1 | 0

but we are actually returning
b | sum
-------
0 | 1

In order to correctly follow SQL semantics, we should either:

Disable this optimization when there are group by.
Push the filter in some way that the rows used as keys are not filtered out if they don't match the aggregation filter.

At shorter term what we could offer is an option or hint to disable this optimization.
PS: This problem affects both single and multi stage
PS2: See https://modern-sql.com/feature/filter

Hello @gortiz  .
I've spent some time debugging and found that this filter pushdown happens during construction of operators (FilteredGroupByOperator to be precise). I think fix could either:

disable AGGREGATE_CASE_TO_FILTER when aggregation is keyed and add rule for rewriting agg(exp) filter (cond) to agg(case when cond then exp end) for keyed aggregations
for keyed aggregations, separate aggregation filters from other filters in buildFilteredAggregationInfos() and introduce an intermediate ProjectionOperator that'd implement agg(case when cond then exp end) .

I'm not sure if it's possible to fetch all key combinations that are missing from query output due to filter pushdown. I saw key column dictionary being used to estimate key cardinality but I doubt stats are kept on column value combinations.
Please let me know what you think .

Thanks @bziobrowski for debugging this. Your solution seems interesting, but it is partial. Pinot has 2 different engines. The original one (we call single-stage or V1) uses Calcite just to parse the expression and apply some simplifications while most of the logical to physical transformations are applied eagerly by our own code. Then we have a second engine (called multi-stage or V2) that relay more in Calcite. This second engine ends up calling the single-stage engine in the leaves of the execution tree.
If I remember correctly, this issue was detected when adding AGGREGATE_CASE_TO_FILTER and we found it affects both single and multi stage. As you say it seems that FilteredGroupByOperator is involved. That class is used in single-stage.
Your first suggestion may be useful, but it is limited to multi-stage and it would end up producing inefficient plans. The reason to merge #12643 was to try to use some indexes we cannot use in filtered aggregations. Also, I'm not sure what do you mean with keyed aggregation. Do you mean using group by k1, k2, etc? I don't think that is an actual problematic case. Instead the problem arise when using two aggregate functions and only one of them is filtered.
BTW, it looks like this issue was reported twice (see https://github.com/apache/pinot/issues/13749) and I think @Jackie-Jiang already fixed this in https://github.com/apache/pinot/pull/13784.

Thanks @gortiz . From what I see the issue is not fixed in latest master . You can see it if you run and compare
select AirTime, count(*) filter ( where AirTime < 0 ) from AirlineStats group by AirTime

with
select AirTime, sum( case when AirTime < 0 then 1 else 0 end)
from airlineStats
group by AirTime

in query console (assuming instance was started with ./bin/pinot-admin.sh QuickStart -type batch).
The second query contains all AirTime values, not only those matching filter predicate.
It's not necessary to include more than one aggregate function to see the effect. In fact, if filter-less aggregate functions are present, they hide the bug. That's because all group by key combinations produced by  filter-less aggregate get merged with some  produced by filtered aggregate.
By keyed aggregation I meant, as you guessed, one with group by key[s].
The way I see it, the problem is that aggregation filters get pushed down even when aggregation is keyed (see AggregationFunctionUtils.buildFilteredAggregationInfos()), leading to filtering of both aggregation keys and values.
It only seems valid when aggregation doesn't have any key.
You are right about the first approach related to AGGREGATE_CASE_TO_FILTER being a partial solution since issue affects both engines and that rule only applies to V2. My initial idea was to limit AGGREGATE_CASE_TO_FILTER to keyless aggregates and add reversed rule for keyed aggregates with filter, e.g.
select AirTime, count(*) filter ( where AirTime < 0 )
-->
select AirTime, count( case when AirTime < 0 end )

but that transformation is problematic to apply correctly for all aggregate functions (multiple parameters, quirks around null handling, etc.) .
Back to the core issue - I think the most promising approach is option two :
for keyed aggregations, separate aggregation filters from other filters in AggregationFunctionUtils.buildFilteredAggregationInfos() and push it to e.g. DefaultGroupByExecutor to execute it after computing keys but before aggregate values.

@gortiz Hi, any update on this issue?

Hi @kmozaid! This was fixed in #14211 last week and will be included in the next release.

Hi @kmozaid! This was fixed in #14211 last week and will be included in the next release.

Thank you!!


Dave week 22

Hello @pbalm! Thanks for submitting the PR.

In the file src/main/python/model/dataset.py, following are the PEP8 issues :

Line 121:29: E128 continuation line under-indented for visual indent
Line 122:29: E128 continuation line under-indented for visual indent
Line 141:37: E128 continuation line under-indented for visual indent
Line 142:37: E128 continuation line under-indented for visual indent
Line 143:37: E128 continuation line under-indented for visual indent

In the file src/main/python/server.py, following are the PEP8 issues :

Line 57:121: E501 line too long (121 > 120 characters)
Line 63:13: E128 continuation line under-indented for visual indent
Line 64:13: E126 continuation line over-indented for hanging indent
Line 70:13: E128 continuation line under-indented for visual indent
Line 71:13: E126 continuation line over-indented for hanging indent
Line 77:13: E128 continuation line under-indented for visual indent
Line 78:13: E126 continuation line over-indented for hanging indent
Line 84:13: E128 continuation line under-indented for visual indent
Line 85:13: E126 continuation line over-indented for hanging indent
Line 91:13: E128 continuation line under-indented for visual indent
Line 92:13: E126 continuation line over-indented for hanging indent
Line 98:13: E128 continuation line under-indented for visual indent
Line 104:13: E128 continuation line under-indented for visual indent
Line 110:13: E128 continuation line under-indented for visual indent
Line 111:13: E126 continuation line over-indented for hanging indent
Line 119:13: E128 continuation line under-indented for visual indent
Line 120:13: E126 continuation line over-indented for hanging indent
Line 128:13: E128 continuation line under-indented for visual indent
Line 129:13: E126 continuation line over-indented for hanging indent
Line 139:13: E128 continuation line under-indented for visual indent
Line 140:13: E126 continuation line over-indented for hanging indent

In the file src/main/python/utils/dataset_helper.py, following are the PEP8 issues :

Line 23:42: E211 whitespace before '('
Line 45:46: E211 whitespace before '('
Line 71:43: E261 at least two spaces before inline comment
Line 71:44: E262 inline comment should start with '# '
Line 134:36: E211 whitespace before '('
Line 136:26: E127 continuation line over-indented for visual indent
Line 138:25: E127 continuation line over-indented for visual indent
Line 141:36: E211 whitespace before '('
Line 157:44: E211 whitespace before '('
Line 158:44: E211 whitespace before '('
Line 164:22: E211 whitespace before '('
Line 168:1: E265 block comment should start with '# '
Line 171:24: E703 statement ends with a semicolon
Line 194:1: E265 block comment should start with '# '
Line 196:31: E226 missing whitespace around arithmetic operator
Line 197:9: E265 block comment should start with '# '
Line 250:37: E211 whitespace before '('
Line 260:36: E211 whitespace before '('
Line 261:33: E128 continuation line under-indented for visual indent
Line 312:30: E225 missing whitespace around operator
Line 313:27: E225 missing whitespace around operator
Line 317:121: E501 line too long (172 > 120 characters)
Line 320:18: E211 whitespace before '('
Line 324:12: E713 test for membership should be 'not in'

In the file src/main/python/utils/dave_endpoint.py, following are the PEP8 issues :

Line 42:1: E265 block comment should start with '# '
Line 43:1: E302 expected 2 blank lines, found 1
Line 59:35: E261 at least two spaces before inline comment
Line 265:121: E501 line too long (126 > 120 characters)
Line 308:33: E127 continuation line over-indented for visual indent
Line 337:49: E128 continuation line under-indented for visual indent
Line 345:33: E127 continuation line over-indented for visual indent
Line 373:49: E127 continuation line over-indented for visual indent
Line 384:4: E111 indentation is not a multiple of four
Line 385:4: E111 indentation is not a multiple of four
Line 386:8: E111 indentation is not a multiple of four
Line 388:4: E111 indentation is not a multiple of four
Line 389:4: E111 indentation is not a multiple of four
Line 390:8: E111 indentation is not a multiple of four
Line 391:8: E111 indentation is not a multiple of four
Line 392:12: E111 indentation is not a multiple of four
Line 394:4: E111 indentation is not a multiple of four
Line 395:4: E111 indentation is not a multiple of four
Line 396:8: E111 indentation is not a multiple of four
Line 397:8: E111 indentation is not a multiple of four
Line 398:12: E111 indentation is not a multiple of four
Line 400:4: E111 indentation is not a multiple of four
Line 401:4: E111 indentation is not a multiple of four
Line 402:8: E111 indentation is not a multiple of four
Line 404:4: E111 indentation is not a multiple of four
Line 405:4: E111 indentation is not a multiple of four
Line 406:8: E111 indentation is not a multiple of four
Line 407:8: E111 indentation is not a multiple of four
Line 408:12: E111 indentation is not a multiple of four
Line 410:4: E111 indentation is not a multiple of four
Line 411:4: E111 indentation is not a multiple of four
Line 412:8: E111 indentation is not a multiple of four
Line 413:8: E111 indentation is not a multiple of four
Line 414:12: E111 indentation is not a multiple of four
Line 416:4: E111 indentation is not a multiple of four
Line 417:4: E111 indentation is not a multiple of four
Line 418:4: E111 indentation is not a multiple of four
Line 419:4: E111 indentation is not a multiple of four
Line 420:4: E111 indentation is not a multiple of four
Line 421:4: E111 indentation is not a multiple of four
Line 422:4: E111 indentation is not a multiple of four
Line 423:4: E111 indentation is not a multiple of four
Line 424:4: E111 indentation is not a multiple of four
Line 425:4: E111 indentation is not a multiple of four
Line 426:4: E111 indentation is not a multiple of four
Line 427:4: E111 indentation is not a multiple of four
Line 428:4: E111 indentation is not a multiple of four
Line 429:4: E111 indentation is not a multiple of four
Line 430:4: E111 indentation is not a multiple of four
Line 431:4: E111 indentation is not a multiple of four
Line 433:4: E111 indentation is not a multiple of four
Line 437:4: E111 indentation is not a multiple of four
Line 439:4: E111 indentation is not a multiple of four

In the file src/main/python/utils/dave_engine.py, following are the PEP8 issues :

Line 46:17: E265 block comment should start with '# '
Line 51:13: E265 block comment should start with '# '
Line 84:56: E226 missing whitespace around arithmetic operator
Line 84:121: E501 line too long (124 > 120 characters)
Line 85:85: E128 continuation line under-indented for visual indent
Line 86:85: E128 continuation line under-indented for visual indent
Line 97:55: E261 at least two spaces before inline comment
Line 98:50: E261 at least two spaces before inline comment
Line 249:121: E501 line too long (128 > 120 characters)
Line 260:13: E265 block comment should start with '# '
Line 269:9: E265 block comment should start with '# '
Line 339:1: E265 block comment should start with '# '
Line 375:13: E265 block comment should start with '# '
Line 380:121: E501 line too long (121 > 120 characters)
Line 387:121: E501 line too long (134 > 120 characters)
Line 391:121: E501 line too long (161 > 120 characters)
Line 453:44: E261 at least two spaces before inline comment
Line 456:73: E226 missing whitespace around arithmetic operator
Line 456:121: E501 line too long (157 > 120 characters)
Line 456:126: E226 missing whitespace around arithmetic operator
Line 463:48: E225 missing whitespace around operator
Line 464:60: E225 missing whitespace around operator
Line 493:1: E265 block comment should start with '# '
Line 513:13: E265 block comment should start with '# '
Line 520:121: E501 line too long (159 > 120 characters)
Line 521:77: E128 continuation line under-indented for visual indent
Line 552:33: E127 continuation line over-indented for visual indent
Line 582:40: E211 whitespace before '('
Line 601:20: E711 comparison to None should be 'if cond is not None:'
Line 638:33: E127 continuation line over-indented for visual indent
Line 665:40: E211 whitespace before '('
Line 673:16: E711 comparison to None should be 'if cond is not None:'
Line 676:25: E711 comparison to None should be 'if cond is not None:'
Line 698:20: E711 comparison to None should be 'if cond is not None:'
Line 782:41: E211 whitespace before '('
Line 794:41: E211 whitespace before '('
Line 801:27: E711 comparison to None should be 'if cond is not None:'
Line 802:27: E711 comparison to None should be 'if cond is not None:'
Line 814:9: E265 block comment should start with '# '
Line 833:13: E265 block comment should start with '# '
Line 838:21: E711 comparison to None should be 'if cond is not None:'
Line 840:21: E711 comparison to None should be 'if cond is not None:'
Line 865:1: E265 block comment should start with '# '
Line 877:26: E225 missing whitespace around operator
Line 899:80: E703 statement ends with a semicolon
Line 900:48: E226 missing whitespace around arithmetic operator
Line 928:5: E265 block comment should start with '# '
Line 966:121: E501 line too long (121 > 120 characters)
Line 974:26: E211 whitespace before '('
Line 981:41: E211 whitespace before '('
Line 983:36: E261 at least two spaces before inline comment
Line 985:48: E225 missing whitespace around operator
Line 998:26: E211 whitespace before '('
Line 1025:9: E125 continuation line with same indent as next logical line
Line 1031:121: E501 line too long (140 > 120 characters)
Line 1035:9: E265 block comment should start with '# '
Line 1037:40: E211 whitespace before '('
Line 1057:47: E211 whitespace before '('
Line 1057:121: E501 line too long (142 > 120 characters)
Line 1061:121: E501 line too long (127 > 120 characters)
Line 1095:30: E211 whitespace before '('
Line 1100:59: E211 whitespace before '('
Line 1104:1: E302 expected 2 blank lines, found 1

In the file src/main/python/utils/dave_reader.py, following are the PEP8 issues :

Line 14:10: E225 missing whitespace around operator
Line 16:1: E302 expected 2 blank lines, found 1
Line 48:9: E265 block comment should start with '# '
Line 57:48: E128 continuation line under-indented for visual indent
Line 58:48: E128 continuation line under-indented for visual indent
Line 63:57: E128 continuation line under-indented for visual indent
Line 75:65: E231 missing whitespace after ','
Line 148:36: E128 continuation line under-indented for visual indent
Line 149:36: E128 continuation line under-indented for visual indent
Line 175:37: E128 continuation line under-indented for visual indent
Line 176:37: E128 continuation line under-indented for visual indent
Line 202:45: E128 continuation line under-indented for visual indent
Line 204:5: E265 block comment should start with '# '
Line 217:30: E128 continuation line under-indented for visual indent
Line 218:30: E128 continuation line under-indented for visual indent
Line 221:69: E127 continuation line over-indented for visual indent

In the file src/test/python/test/utils/test_dave_reader.py, following are the PEP8 issues :

Line 89:49: E128 continuation line under-indented for visual indent


Fix detach cascading see #978

As described in #978 I think the detach cascading for embedded documents is not working correct. I also added  a small test.
I was not sure where to put the test.. I hope it is correct this way.

This has been merged manually in https://github.com/doctrine/mongodb-odm/commit/994783a5edfd5f2cbe29f709cf49cbb5ad40ccb7 - thanks @fridolin-koch!

@fridolin-koch, @malarzm: Comparable logic existed in cascadeRefresh(), which recurses with cascadeRefresh() instead of doRefresh() on the embedded document(s). I suppose that's alright since embedded documents would never be refreshed on their own (unlike detachment). Would you agree?

I agree with that :)

I also agree :+1:


Wrong letter in jetson-containers/scripts/docker_base.sh

When running docker_build, the error message "pull access denied for nvcr.io/nvidian/nvidia-l4t-base, repository does not exist or may require 'docker login': denied: requested access to the resource is denied" appears as there is a typo in  jetson-containers/scripts/docker_base.sh. It should be "nvcr.io/nvidia/nvidia-l4t-base" and not "nvcr.io/nvidian/nvidia-l4t-base".

Hi @fjfricke, please see:  https://github.com/dusty-nv/jetson-containers/issues/136#issuecomment-1083458501


Backport metrics node provisioning to v1.54

What this PR does / why we need it:
Adds 2 new buckets to the /metrics endpoint about provisioning

machine_controller_provisioning_time_seconds
machine_controller_deprovisioning_time_seconds

Which issue(s) this PR fixes:

Fixes #1574
What type of PR is this?
/kind feature

Special notes for your reviewer:
golang v1.18 does not have support for .Abs() which broke the backport to release/v1.54 triggered in #1572
This PR fixes this by using time.Since()
Does this PR introduce a user-facing change? Then add your Release Note here:

Added machine_controller_provisioning_time_seconds and machine_controller_deprovisioning_time_seconds metrics to the machine controller

Documentation:

NONE

/retest


Implement derive on unions

In trying to build a simple ESP8266 firmware example, I am unable to compile my crate of generated bindings to the Arduino library because it depends on deriving Copy on unions:
:0: BUG:src/expand/derive.cpp:2186: TODO: handle - Handle #[derive] for other item types - Union

(I was bored/procrastinating, and rustc progress is stuck on a typecheck issue - this was easy to fix)

Thanks! That did the trick. I now have a working blink firmware for ESP8266 written in Rust! I had to delete the 128-bit integer typedefs and functions (ESP8266 is 32-bit). Is there a way to tell mrustc that my target is 32-bit?

add a 32-bit target to src/trans/target.cpp


I can't download custom models

I normally download custom models from my Google Drive account to train with Kohya but since three days ago each time I try to get a custom model I  get the following error (no matter how large the model is):
Access denied with the following error:
Cannot retrieve the public link of the file. You may need to change
the permission to 'Anyone with the link', or have had many accesses.

You may still be able to access the file from the browser:

You SHOULD be able to just connect the drive at the start, and if your models are loaded in a specific folder in drive, just copy and paste the details from the file/folder broswer in colab. I struggled to get it to load zip files VIA URL that's why I suggest that, it may be the same thing <3

You SHOULD be able to just connect the drive at the start, and if your models are loaded in a specific folder in drive, just copy and paste the details from the file/folder broswer in colab. I struggled to get it to load zip files VIA URL that's why I suggest that, it may be the same thing <3

I'm still struggling tog et it to find or pull Zip files, what wound up working for you if you don't mind me asking?


Incorrect configuration for default Request and Response filters

When we look at the spring boot starter section in logbook documentation it states that the default configuration for request and response filters are none():

RequestFilter

RequestFilter.none()

ResponseFilter

ResponseFilter.none()

However, when i look at the Logbook Auto Configuration class , they are configured differently.
@API(status = INTERNAL)
@Bean
@ConditionalOnMissingBean(RequestFilter.class)
public RequestFilter requestFilter() {
    return RequestFilters.defaultValue();
}

@API(status = INTERNAL)
@Bean
@ConditionalOnMissingBean(ResponseFilter.class)
public ResponseFilter responseFilter() {
    return ResponseFilters.defaultValue();
}

As a library user, i do not expect any filterfor the response and request object by default.

The code is actually correct. I opened #670 to fix it.
The default values make sense because they will either provide now additional benefit (logging binaries, multipart) or break applications (trying to log endless streams).

Logbook logs request/response to the log console by default. So it make sense to replace binaries or multipart files with static string valus (such as , ). But if i persist logs to the database i need to persist original binaries and multipart files. So i can write my own filters to eliminate those filters.
Is my assumption correct?

I have another question. When i override RequestFilter with RequestFilter.none(), my requst body is null for multipart files. Before I had "multipart" string in the request body.
When i remove the default requestfilter, i expect original value in the request value.
How can i handle this situation?

But if i persist logs to the database i need to persist original binaries and multipart files. So i can write my own filters to eliminate those filters.
Is my assumption correct?

That is correct. Configure/Register RequestFilter.none() and ResponseFilter.none() respectively instead of the default.

When i remove the default requestfilter, i expect original value in the request value.

That's a reasonable expectation to have. Can you paste your request here or a minimal version of it? Maybe even produce a test case or demo project?

I am using postman form-data/file option to pass multipart bodies.
I debug the code and i found out that the issue is in RemoteRequest class.
The following line (line number 108) return empty byte array for multipart bodies.
new Buffering(toByteArray(request.getInputStream()));
When i use binary option (in postman) to pass one file (just to check the behaviour), i have proper byte array object.

The handling of multipart is always somewhat special. Is there any filter running before Logbook? Which component is actually parsing the multipart request body? The servlet container? Application framework?

Is there any filter running before Logbook?
Yes, secure logbook filter. But in my opinion it is not a problem,since secure logbook filter delays handling the request log.

Which component is actually parsing the multipart request body? The servlet container? Application framework?

It is application context.
When i call the request.getBody() in my Sink implementation, here is the stackstrace:


Not an issue but request for a feature for custom text to speak in beep!!!

How will that be if instead of just beep sound, your custom error is spoken like a voice???
Is it possible?  If yes will you implement this?
Is it implemented anywhere? If yes where?

That is very far outside the scope of this package. Packages do exist though; the keyword you are looking for is text-to-speech or tts.

What @dskrepps said 👍


Error handling for bad api calls

When passing bad configurations, the errors returned are not helpful. This may be due to error handling from responses coming from the api.
As an example configuring --api-pass=notthecorrectpassword will return in my use case:
Error executing sensu-aggregate-check: error executing check: invalid character 'U' looking for beginning of value

While configured with the correct password the check works correctly.

The 'U' is because it's expecting a JSON response back with the access token, but is instead getting only the text 'Unauthorized'.
We can definitely add something to at least catch that and surface it better.


Update cobertura reporter to support ignores.

Since the Cobertura Report XML cannot handle ignores directly, this will mark the ignored functions, statements and branches as covered.

+1 on this one. Tested and works for me.
Let me know if I can help in any way

Seems like the build on travis failed only for node 0.8 during npm install.
@gotwarlost can you re-run the travis build?

+1

+1

Any updates on this? Would really like to rid of the custom git repo in package.json :)
PS: I just pulled in all the changes from master into my branch. Everything seems to be working fine.

Coverage decreased (-0.04%) to 97.87% when pulling 8abd16945e4353c10f11937611f319223f60719c on BonsaiDen:master into c7bc4cc87b7190515b3765eb770855ca7ed3f19c on gotwarlost:master.

+1 on this. cc @gotwarlost

@BonsaiDen - could you reconcile this work with https://github.com/gotwarlost/istanbul/pull/238 ? Looks like that one is also trying to accomplish what you are doing here but in a more general way that is not cobertura-specific.

@gotwarlost Sure thing! I'll check tomorrow on whether this has the same results as the changes I made for cobertura.

I think this is fixed via #238 ? Closing. Lemme know if this is not the case.

Coverage decreased (-0.04%) to 97.487% when pulling 2ba7aec9cb44caa622534fb54fd2b6e1b1d866b6 on BonsaiDen:master into c0d9f0597f1feb17a994e109dc5f63adfed208a6 on gotwarlost:master.


ants: 2.5.3 -> 2.5.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/ANTsX/ANTs/releases.
meta.description for ants is: Advanced normalization toolkit for medical image registration and other processing
meta.homepage for ants is: https://github.com/ANTsX/ANTs
meta.changelog for ants is: https://github.com/ANTsX/ANTs/releases/tag/v2.5.4
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.5.4 with grep in /nix/store/agykmrws4wj41wqq4vhk3j8kdwh6v0s1-ANTs-2.5.4
found 2.5.4 in filename of file in /nix/store/agykmrws4wj41wqq4vhk3j8kdwh6v0s1-ANTs-2.5.4

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

ants
mrtrix

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/agykmrws4wj41wqq4vhk3j8kdwh6v0s1-ANTs-2.5.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ants https://github.com/r-ryantm/nixpkgs/archive/b2a83dc1e6bfd8b90b6e0f1139a2044445839053.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/b2a83dc1e6bfd8b90b6e0f1139a2044445839053#ants

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/agykmrws4wj41wqq4vhk3j8kdwh6v0s1-ANTs-2.5.4
ls -la /nix/store/agykmrws4wj41wqq4vhk3j8kdwh6v0s1-ANTs-2.5.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 2 packages built:

ants
mrtrix

Maintainer pings
cc @bcdarwin for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

but let's wait a bit for ofborg.

ofborg is having a bad time recently, with hundreds of pending evals.

Eval and Linux builds finished at least.


Skip over unplayable audio

Firefox has trouble playing back our 0-length tracker ads.
This catches those playback errors, sends the ad-impression, and skips to the next file.

I'll also say that, as i was testing playback for this code ... duration and skip/seek functionality are a bit wonky.  Since we don't know the length of an ad until we hit it, things can get crazy when going through 3 consecutive ads.  But ... that's a problem for another day.


[WFCORE-654] : Configuration files get default permissions when written.

Using Nio2 API to try to create the temporary configuration file with the same attributes as the original configuration file.
Jira: https://issues.jboss.org/browse/WFCORE-654

Core - Full Integration Build 1358 is now running using a merge of e62f13262683f59c8d06f6b4360bbaca28632980

Linux Build 2219 is now running using a merge of e62f13262683f59c8d06f6b4360bbaca28632980

Windows Build 1745 is now running using a merge of e62f13262683f59c8d06f6b4360bbaca28632980

Windows Build 1745 outcome was FAILURE using a merge of e62f13262683f59c8d06f6b4360bbaca28632980
Summary: Tests failed: 1 (1 new), passed: 3376, ignored: 63 Build time: 0:33:36
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.domain.management.cli.CloneProfileTestCase.testProfile: <no details avaliable>

Linux Build 2219 outcome was SUCCESS using a merge of e62f13262683f59c8d06f6b4360bbaca28632980
Summary: Tests passed: 3377, ignored: 63 Build time: 0:35:28

Core - Full Integration Build 1358 outcome was SUCCESS using a merge of 4832843fcc45b46829d3db3424432800b628e8e0
Summary: Tests passed: 2956, ignored: 354 Build time: 0:46:05

Linux Build 2220 is now running using a merge of 4832843fcc45b46829d3db3424432800b628e8e0

Core - Full Integration Build 1359 is now running using a merge of 4832843fcc45b46829d3db3424432800b628e8e0

Windows Build 1746 is now running using a merge of 4832843fcc45b46829d3db3424432800b628e8e0

Windows Build 1746 outcome was FAILURE using a merge of 4832843fcc45b46829d3db3424432800b628e8e0
Summary: Tests failed: 1, passed: 3376, ignored: 63 Build time: 0:33:49
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.domain.management.cli.CloneProfileTestCase.testProfile: <no details avaliable>

Linux Build 2220 outcome was SUCCESS using a merge of 4832843fcc45b46829d3db3424432800b628e8e0
Summary: Tests passed: 3377, ignored: 63 Build time: 0:35:04

Core - Full Integration Build 1359 outcome was SUCCESS using a merge of 4832843fcc45b46829d3db3424432800b628e8e0
Summary: Tests passed: 2956, ignored: 354 Build time: 0:47:36

Windows Build 1748 is now running using a merge of ef8133d84058b0fc0f2ab46f2cd4e003f76533e2

Windows Build 1749 is now running using a merge of ef8133d84058b0fc0f2ab46f2cd4e003f76533e2

Linux Build 2222 is now running using a merge of ef8133d84058b0fc0f2ab46f2cd4e003f76533e2

Core - Full Integration Build 1361 is now running using a merge of ef8133d84058b0fc0f2ab46f2cd4e003f76533e2

Windows Build 1748 outcome was FAILURE using a merge of ef8133d84058b0fc0f2ab46f2cd4e003f76533e2
Summary: Tests failed: 1, passed: 3376, ignored: 63 Build time: 0:33:30
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.domain.management.cli.CloneProfileTestCase.testProfile: <no details avaliable>

Windows Build 1749 outcome was FAILURE using a merge of ef8133d84058b0fc0f2ab46f2cd4e003f76533e2
Summary: Tests failed: 1, passed: 3376, ignored: 63 Build time: 0:35:15
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.domain.management.cli.CloneProfileTestCase.testProfile: <no details avaliable>

Linux Build 2222 outcome was SUCCESS using a merge of ef8133d84058b0fc0f2ab46f2cd4e003f76533e2
Summary: Tests passed: 3377, ignored: 63 Build time: 0:36:27

Windows Build 1751 is now running using a merge of 5e77bad0ae70dddd1f3bb65b3f9ea30b111459c4

Core - Full Integration Build 1361 outcome was FAILURE using a merge of 5e77bad0ae70dddd1f3bb65b3f9ea30b111459c4
Summary: Tests failed: 2 (2 new), passed: 2954, ignored: 354 Build time: 0:47:31
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ejb.client.descriptor.EJBClientDescriptorTestCase.testClientPropertiesReplacementInConfig: <no details avaliable>

org.jboss.as.test.integration.ejb.client.descriptor.EJBClientDescriptorTestCase.testEJBClientContextWithNoReceiversConfiguration: <no details avaliable>

Windows Build 1752 is now running using a merge of 5e77bad0ae70dddd1f3bb65b3f9ea30b111459c4

Core - Full Integration Build 1363 is now running using a merge of 5e77bad0ae70dddd1f3bb65b3f9ea30b111459c4

Linux Build 2224 is now running using a merge of 5e77bad0ae70dddd1f3bb65b3f9ea30b111459c4

Windows Build 1751 outcome was SUCCESS using a merge of 5e77bad0ae70dddd1f3bb65b3f9ea30b111459c4
Summary: Tests passed: 3377, ignored: 63 Build time: 0:33:42

Windows Build 1752 outcome was SUCCESS using a merge of dc14cef3e1c927f7a1d66e0e3b05fe46d85d491e
Summary: Tests passed: 3377, ignored: 63 Build time: 0:33:38

Linux Build 2224 outcome was SUCCESS using a merge of dc14cef3e1c927f7a1d66e0e3b05fe46d85d491e
Summary: Tests passed: 3377, ignored: 63 Build time: 0:35:18

Core - Full Integration Build 1363 outcome was FAILURE using a merge of dc14cef3e1c927f7a1d66e0e3b05fe46d85d491e
Summary: Tests failed: 3 (3 new), passed: 2953, ignored: 354 Build time: 0:45:58
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ejb.timerservice.mgmt.NonPersistentCalendarTimerManagementTestCase.testResourceExistence: <no details avaliable>

org.jboss.as.test.integration.jca.datasource.remove.EjbAppDsRemoveTestCase.testDatasourceRemove: <no details avaliable>

org.jboss.as.test.clustering.cluster.ejb.stateful.StatefulFailoverTestCase(SYNC-tcp).jmsConnectionFactoryFailover: <no details avaliable>

Core - Full Integration Build 1364 is now running using a merge of dc14cef3e1c927f7a1d66e0e3b05fe46d85d491e

Linux Build 2226 is now running using a merge of dc14cef3e1c927f7a1d66e0e3b05fe46d85d491e

Windows Build 1753 is now running using a merge of dc14cef3e1c927f7a1d66e0e3b05fe46d85d491e

Windows Build 1753 outcome was SUCCESS using a merge of dc14cef3e1c927f7a1d66e0e3b05fe46d85d491e
Summary: Tests passed: 3377, ignored: 63 Build time: 0:34:06

Core - Full Integration Build 1364 outcome was FAILURE using a merge of dc14cef3e1c927f7a1d66e0e3b05fe46d85d491e
Summary: Tests failed: 2 (2 new), passed: 2954, ignored: 354 Build time: 0:45:09
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ejb.client.descriptor.EJBClientDescriptorTestCase.testClientPropertiesReplacementInConfig: <no details avaliable>

org.jboss.as.test.integration.ejb.client.descriptor.EJBClientDescriptorTestCase.testEJBClientContextWithNoReceiversConfiguration: <no details avaliable>

Linux Build 2226 outcome was FAILURE using a merge of dc14cef3e1c927f7a1d66e0e3b05fe46d85d491e
Summary: Execution timeout (new); tests passed: 3030, ignored: 48; org.wildfly.core:wildfly-core-testsuite-domain Build time: 1:00:03
Build problems:
Execution timeout
Process exited with code 137

retest this please

Core - Full Integration Build 1368 is now running using a merge of dc14cef3e1c927f7a1d66e0e3b05fe46d85d491e

Linux Build 2231 is now running using a merge of dc14cef3e1c927f7a1d66e0e3b05fe46d85d491e

Windows Build 1757 is now running using a merge of dc14cef3e1c927f7a1d66e0e3b05fe46d85d491e

Windows Build 1757 outcome was SUCCESS using a merge of dc14cef3e1c927f7a1d66e0e3b05fe46d85d491e
Summary: Tests passed: 3377, ignored: 63 Build time: 0:33:52

Linux Build 2231 outcome was SUCCESS using a merge of dc14cef3e1c927f7a1d66e0e3b05fe46d85d491e
Summary: Tests passed: 3377, ignored: 63 Build time: 0:35:55

Core - Full Integration Build 1368 outcome was FAILURE using a merge of dc14cef3e1c927f7a1d66e0e3b05fe46d85d491e
Summary: Tests failed: 4 (4 new), passed: 2952, ignored: 354 Build time: 0:46:49
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ejb.mdb.cdi.MDBRAScopeCdiIntegrationTestCase.testMe: <no details avaliable>

org.jboss.as.test.integration.ejb.remote.view.LocalViewRemoteInvocationTestCase.testLocalViewInvocationRemotelyOnSFSB: <no details avaliable>

org.jboss.as.test.integration.ejb.timerservice.mgmt.NonPersistentCalendarTimerManagementTestCase.testResourceExistence: <no details avaliable>

org.jboss.as.test.integration.ejb.timerservice.mgmt.NonPersistentCalendarTimerManagementTestCase.testSuspendAndActivate: <no details avaliable>


Bump rails and related packagaes to v7.X

All rails related packages currently use rails 6.1.x. We should eventually upgrade to the latest v7 rails version.
Rails v7 contains a few breaking changes and cannot not easily be adopted.
Dependabot tried and failed:
https://github.com/cloudfoundry/cloud_controller_ng/pull/3431
https://github.com/cloudfoundry/cloud_controller_ng/pull/3332
Should be done by end of 2023.

It looks like the PRs were failing due to the migration from the classic Rails autoloader to Zeitwerk.
It looks like we can do that migration via configuration in Rails 6, so we can hopefully solve that problem prior to the Rails 7 upgrade.

Rail upgrade (7.1) has been merged.


Emit event on install

Emit a Transfer event on install_contract() to register token's existence.  It would be best if some event was emitted on install.

@Levike34  Maybe it should be a Mint event?

@Levike34 Maybe it should be a Mint event?

That does make more sense.  For more context, I created this PR to address this issue: After deploying a new CEP18 contract, tokens do not appear in Casper Wallet until some event is emitted. Transfer works for sure, but I will have to check if Mint works as well.  Tokens only seem to appear if events_mode is enabled and after a Transfer event.

@Levike34 thanks for the context information. I just tried and, yes, emitting a Mint event during contract installation also makes the initial supply visible in the contract owner account.

@davidatwhiletrue updated to Mint event

Technically it is a Mint event.


Create a new theme called Achrom for Achromatopsia #wcag #a11y

Make an accessible color scheme theme for Achromatopsia.
This requires some research about what colors to use for this form of visual impairment.
More information can be found here.

https://www.a11yproject.com/
http://colorsafe.co/

How To:

Make a copy of dark.css in the /themes folder and rename it to Achrom
Include your name at the top in a comment
Change the colors and styles
Make sure the theme looks good with all current pages in the /pages folder and index.html
Update the themes_list.txt in the root folder
Update the Contributors.md file in the root folder and add your information

If assigned, please fork immediately.
Comment within 2 days (at least leave a comment) if you haven't done a PR yet.
Resign yourself if you won't get to it so someone else can.??
Be creative.
Read the Docs.
Give a ⭐
Don't break anything. :)

I want to assign it.

please assign this task to me


Buttons used as links need role="link" to signify to screen readers that they are linking to another page

Description
The buttons on the milestone cards in milestones.js redirect to another site and therefore need role="link" added. Also because the url opens in a new window for extra safety it should also have an attribute rel="noopener noreferrer"
https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types/noreferrer
https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types/noopener
Screenshots

Additional information
No response

Is this issue still not resolved? I would like to work on this.

Looks like someone has already started to work on it :) Please have a look to our other issues


RFE: Offline usage trigger

It may be usefull to run trivy-operator in offline (air-gapped) environment.
But now trivy-operator always fetch trivy db on startup ("startup_fn_trivy_cache" function) and during runtime.
I think that it is difficult to embrace all variants of offline envs in real-life, so my suggestion for now is simple: it is possible to implement completely offline trivy usage trigger? Idea is to leave db update up to sysadmin.
Official documentation may be good starting point: https://aquasecurity.github.io/trivy/v0.31.3/docs/advanced/air-gap/

Hi @evgkrsk
Thank you for using my trivy-operator. It is an interesting function. I think it is a fairly simple to add an option for offline scan in the CRD. Based on that it can disable the vulndb download at the beginning and add offline scan option to trivy run. If you want to help in that  pull requests are welcomed.
I will try to check on this this in the next release. I plan to release the 2.5 release at the end of September.

Not sure if offline-scan is attribute of CRD. trivy-operator's deployment in k8s have internet access to update DB or don't have it. So, effectively all CRD objects are offline or online.
But surely you have better understanding of project's internals.

@evgkrsk There is an option for trivy to use your docker registry for viln-db storage:
DB Flags
      --db-repository string   OCI repository to retrieve trivy-db from (default "ghcr.io/aquasecurity/trivy-db")
      --download-db-only       download/update vulnerability database but don't run a scan
      --no-progress            suppress progress bar
      --reset                  remove all caches and database
      --skip-db-update         skip updating vulnerability database

Yes, it is one of possible ways to deliver fresh trivy db. It may be handy for some users to have ability to override ghcr.io OCI repo in trivy-operator.

@evgkrsk in the 53e915e I added the ability to use custom OCI repo. I need to test of course but with that I think this feature is done.


Support FileImporter

Support for this added in v 0.14.

Codecov Report

Merging #19 (20a0344) into main (baeb664) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   98.93%   99.15%   +0.22%
==========================================
  Files          29       29
  Lines        2619     2619
==========================================
+ Hits         2591     2597       +6
+ Misses         28       22       -6

Impacted Files
Coverage Δ

Sources/DartSass/Compiler.swift
97.60% <0.00%> (+1.59%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baeb664...20a0344. Read the comment docs.


[ENH] CIP-3: Improving developer experience (DX) with max token inputs warnings/exceptions

By default, developers will be warned if any of the documents they are attempting to embed exceed the maximum input tokens for the given EF model.
Optionally, CHROMA_STRICT_MODE=true env var is added to make the mechanism throw an exception if the max input tokens are exceeded.

Refs: #430
Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

Added max input token warnings to many of the EFs

Test plan
New tests added in chromadb/test/ef/test_ef_exceptions.py

[x] Tests pass locally with pytest

Documentation Changes
Embedding Function documentation must be updated to both let developers know how to read the warnings + some explanations about the max input tokens for models.

@HammadB @jeffchuber take a look and let me know. There's still work to be done but I think this is an important topic to address as adoption grows.
I've taken the liberty to prepare a CIP for this as it seems an important change - https://github.com/amikos-tech/chroma-core/blob/dx/ef-warning-exception-on-max-input/docs/CIP_3_DX_Max_Embedding_Function_Token_Input.md

@tazarov I think the hard part about this is maintaining the match between external EF providers and our max token count. For example if HF adds a new model, the max token could be wrong for that since we haven't hardcoded it. For these cases we may be able to introspect the model itself rather than rely on hardcoding. Can we investigate that?

@HammadB, I totally agree; for HF models, I've added naive heuristics of fetching the config.json of the model and then getting max_position_embeddings. But ideally, there's no one solution or even no one clear solution this. The majority of people do use MiniLM + OpenAI + Cohere, so maybe for those, we can get it right, and for the rest ... we leave it as-is so we don't make the assumption?
If we can help 50+% of devs, avoid their docs unknowingly truncated is perhaps better than 0% :)

We should only warn, lets remove strict mode concept.
We should only warn IF we are 100% confident that the token limit is reached - i.e we have access to the tokenizer
Thus, lets make it optional, but a useful warning.
Lets focus on the interface for this, and make it easy for people to do this for any EF
Lets do this for the top 3 used EFs - OpenAI, ONNX, Huggingface sentence transformers

Adding targets as task list:

[ ] We should only warn, lets remove strict mode concept.
[ ] We should only warn IF we are 100% confident that the token limit is reached - i.e we have access to the tokenizer
[ ] Thus, lets make it optional, but a useful warning.
[ ] Lets focus on the interface for this, and make it easy for people to do this for any EF
[ ] Lets do this for the top 3 used EFs - OpenAI, ONNX, Huggingface sentence transformers

@HammadB, have a quick look. This should be good to go.
I've added max token checks for all EFs for which we either know the limit from API, and we can calculate tokens (e.g. OAI with tiktoken) or those based on local tokenizers for which we can get the max tokens.
EF tests pass locally, but some will not run in GH actions as either dips or API keys will be missing; we can fix that later on.

I am not sure whether this amount of added complexity is worth the payoff here.

Every EF has a different way to check the max length / check for truncation

[TA] That is correct, but developer using Chroma don't necessarily understand this hence it is more likely for them to get their inputs truncated without their knowledge than not. Developer awareness is the primary driver for this PR. Surprisingly people pay attention to the warnings raised by Chroma.

Some of these require us to separately pull in a tokenizer

[TA] The only exception for pulling anything remotely is HF Inference API, but we don't even use it in checking token limits, so that piece of code can be removed altogether.

These all need to be maintained through breaking changes

[TA] Several factors make the trade-off worthwhile:

Chroma users are a variety of ML, non-ML developers and sometimes even complete beginners. These warnings are a great DX for people will less knowledge about models and their limitations
Monetary impact - OpenAI, being a commercial API, did this well by rejecting API requests that exceed the model's capabilities without making an implicit decision on what the user intends and thus accepting a request that will yield sub-par results (aka truncated text) and charge the user for it. OSS models, which Chroma users heavily rely on are more than happy to make that trade-off and truncate input, which at small scale may be fine for some, but has real impact at larger scales where user's pay for compute and end up with sub-optimal solutions (aka truncated texts)

Additionally, OpenAI is missing a check (we can use tiktoken): https://platform.openai.com/docs/guides/embeddings/how-can-i-tell-how-many-tokens-a-string-has-before-i-embed-it but the value is not accessible via API.

[TA] I had the implementation with tiktoken but removed it OpenAI already does max token validation on their embedding endpoints.

Willing to hear arguments about why we should do this.

The main argument is the DX: The warnings deliver invaluable feedback in the form of awareness, help prevent costly mistakes, and invalidate the developer's assumptions.
One fundamental challenge with our default EF is that it aggressively and unapologetically truncates user input over 256 tokens. Here is an example to illustrate:
import chromadb
from chromadb.utils import embedding_functions
chroma_client = chromadb.EphemeralClient()
col = chroma_client.get_or_create_collection("test")

text = """
Building Performant RAG Applications for Production
Prototyping a RAG application is easy, but making it performant, robust, and scalable to a large knowledge corpus is hard.

This guide contains a variety of tips and tricks to improve the performance of your RAG pipeline. We first outline some general techniques - they are loosely ordered in terms of most straightforward to most challenging. We then dive a bit more deeply into each technique, the use cases that it solves, and how to implement it with LlamaIndex!

The end goal is to optimize your retrieval and generation performance to answer more queries over more complex datasets accurately and without hallucinations.

General Techniques for Building Production-Grade RAG
Here are some top Considerations for Building Production-Grade RAG

Decoupling chunks used for retrieval vs. chunks used for synthesis

Structured Retrieval for Larger Document Sets

Dynamically Retrieve Chunks Depending on your Task

Optimize context embeddings

We discussed this and more during our Production RAG Webinar. Check out this Tweet thread for more synthesized details.

Decoupling Chunks Used for Retrieval vs. Chunks Used for Synthesis
A key technique for better retrieval is to decouple chunks used for retrieval with those that are used for synthesis.

Motivation
The optimal chunk representation for retrieval might be different than the optimal consideration used for synthesis. For instance, a raw text chunk may contain needed details for the LLM to synthesize a more detailed answer given a query. However, it may contain filler words/info that may bias the embedding representation, or it may lack global context and not be retrieved at all when a relevant query comes in.

Key Techniques
There’s two main ways to take advantage of this idea:

1. Embed a document summary, which links to chunks associated with the document.

This can help retrieve relevant documents at a high-level before retrieving chunks vs. retrieving chunks directly (that might be in irrelevant documents).

Resources:

Recursive Retriever + Query Engine Demo
Document Summary Index
2. Embed a sentence, which then links to a window around the sentence.

This allows for finer-grained retrieval of relevant context (embedding giant chunks leads to “lost in the middle” problems), but also ensures enough context for LLM synthesis.

Resources:

Metadata Replacement + Node Sentence Window
"""
col.upsert(ids=["1"],documents=[text])

res1 = col.query(query_texts=["retrieval vs. chunks used for synthesis"])

res2 = col.query(query_texts=["Recursive Retriever"])

res3 = col.query(query_texts=["lost in the middle"])

res4 = col.query(query_texts=["Node Sentence Window"])

print(res1['distances'][0],res2['distances'][0],res3["distances"][0],res4["distances"][0])

The above outputs:
[0.8014105558395386] [1.7559237480163574] [2.0085155963897705] [1.7934592962265015]

In more practical terms:
from chromadb.utils.embedding_functions import ONNXMiniLM_L6_V2

ef = ONNXMiniLM_L6_V2()

ef([text]) # we run this just so we initilize the tokenizer

lt1=ef.tokenizer.encode(text2).tokens
print(lt1[-10:])

Demonstrating the output gets truncated around Motivation section (most users will be unaware of this):
['used', 'for', 'synthesis', '.', 'motivation', 'the', 'optimal', 'chunk', 'representation', '[SEP]']


Move eventid cut into uproot data loading

This PR tries to move the changes from https://github.com/XENONnT/fuse/pull/154 into the data loading with uproot.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

11 of 26 (42.31%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 66.654%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

fuse/plugins/micro_physics/input.py
11
26
42.31%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
1781

Relevant Lines:
2672

💛  - Coveralls


Updated with redirect to tutorial published on IBM Developer

@odrodrig please review and merge these changes to link this repository with the tutorial text and images published on IBM Developer at https://developer.ibm.com/tutorials/spin-up-a-single-node-openshift-cluster-with-one-command/ so there are not duplicate copies.  Thanks!

Looks good to me.


Some tests fail in non-English locales

FAIL: test_hello_custom_failed (tests.test_units.test_decorator_validate.TestValidateDecorator)
FAIL: test_hello_failed (tests.test_units.test_decorator_validate.TestValidateDecorator)
FAIL: test_network_failed_validation_non_ascii (tests.test_units.test_decorator_validate.TestValidateDecorator)
That's because these tests expect English error messages and get translated ones. Reproducible in ru_RU.UTF-8 with Pylons 1.0 and git-72f4a5ed

Actually, newer routes seems to handle this, the test works differently now. I've updated it so it reflects reality.


Account for changed folderstructure in Endurance

Seems Jenkins does not approve the existance of the new @thumbs folder under Ships. This will do for now though, merging.


How to show definition?

Is it possible to add the definition information in Quick info, so that user can jump to definition? Thanks.

I don't know about adding definition but the shortcut key to go to definition is F12 is my system


Disable nightly CI

Summary of changes
Changes introduced in this pull request:

Nightly CI builds are broken and causing us to have a lot of :x: which makes me sad. Let's disable that for now, and maybe if someone can find time to spend on CI, it can be corrected.

Reference issue to close (if applicable)

N/A
Other information and links

N/A

@connormullett GitHub is being fucky with resolved conversations. Anyway, yes, I can create a tracking issue for this, to address later.


one line breaks by emoji

Hi, that seems to be an upstream issue. Most likely, your font is not using monospaced characters for emojis (that rocket seems to be taking 2 or more columns)
If that is the case, there's nothing I can do...

Hi, that seems to be an upstream issue. Most likely, your font is not using monospaced characters for emojis (that rocket seems to be taking 2 or more columns)
If that is the case, there's nothing I can do...
I can confirm the size considered for this unicode char is:

ah ok check yes now understand thats my font^^


events.x.x.Vacation has no existing object, this might lead to an error in future versions

ical 1.10.0
Admin 5.1.12
js-controller 3.3.14
The following warnings are shown in log with ical and js-controller 3.3.x
Steps to reproduce:

Update ical to 1.10.0
stop ical
delete ical.* objects
start ical instance

21 Jul 2021 19:19:42.764  ical.0 (5131) State "ical.0.events.0.today.Vacation" has no existing object, this might lead to an error in future versions
21 Jul 2021 19:19:42.717  ical.2 (5149) State "ical.2.events.0.today.Vacation" has no existing object, this might lead to an error in future versions
21 Jul 2021 19:15:19.426  ical.0 (4995) State "ical.0.events.2.Vacation" has no existing object, this might lead to an error in future versions
21 Jul 2021 19:15:19.424  ical.0 (4995) State "ical.0.events.1.Vacation" has no existing object, this might lead to an error in future versions
21 Jul 2021 19:15:19.422  ical.0 (4995) State "ical.0.events.0.later.Vacation" has no existing object, this might lead to an error in future versions
21 Jul 2021 19:15:19.419  ical.0 (4995) State "ical.0.events.0.now.Vacation" has no existing object, this might lead to an error in future versions
21 Jul 2021 19:15:19.376  ical.0 (4995) State "ical.0.events.0.today.Vacation" has no existing object, this might lead to an error in future versions

Thank you, please try GitHub version

@apollon77 Is fixed with new github version :-) Thanks.


Its faster than zgen/zgenom?

 From what I can tell, they all perform similarly except in one area: "first command lag" -- the amount of time before the first typed command begins to be executed. zgen is a little slower than zcomet, and zgenom is a little faster than zcomet:

(I used the zsh-bench benchmark program to do the calculations -- you should read the zsh-bench essay if you're interested in how to assess whether specific benchmarks are meaningful. diy++ is just a very well designed .zshrc with no plugin manager.)
The zgen/zgenom paradigm is very different from that of zcomet. The former two plugin managers use a cache script so that they don't have to recalculate how to load plugins every time they run. They also use (by default, at least) compinit -C to largely bypass compinit's time-consuming activities. That seems to work quite well for many people, but it means extra steps if you make a change to your setup.
zcomet is more dynamic; if you change your .zshrc or type zcomet load author/plugin at the command line, you'll see the change immediately -- there's no need for a save, apply, or reset command. So zcomet's model takes convenience as well as speed into account.
Let me know if you have any other questions.

The raw data from 64 iterations of zsh-bench:
==> starting ubuntu:impish in docker ...
==> setting up a container ...
==> benchmarking diy++ ...
creates_tty=1
has_compsys=1
has_syntax_highlighting=1
has_autosuggestions=1
has_git_prompt=1
first_prompt_lag_ms=14.229
first_command_lag_ms=125.064
command_lag_ms=4.493
input_lag_ms=23.953
exit_time_ms=38.224
==> benchmarking zcomet ...
creates_tty=1
has_compsys=1
has_syntax_highlighting=1
has_autosuggestions=1
has_git_prompt=1
first_prompt_lag_ms=15.902
first_command_lag_ms=131.435
command_lag_ms=4.593
input_lag_ms=23.735
exit_time_ms=43.216
==> benchmarking zgen ...
creates_tty=1
has_compsys=1
has_syntax_highlighting=1
has_autosuggestions=1
has_git_prompt=1
first_prompt_lag_ms=15.907
first_command_lag_ms=140.969
command_lag_ms=4.515
input_lag_ms=26.990
exit_time_ms=53.481
==> benchmarking zgenom ...
creates_tty=1
has_compsys=1
has_syntax_highlighting=1
has_autosuggestions=1
has_git_prompt=1
first_prompt_lag_ms=15.911
first_command_lag_ms=113.059
command_lag_ms=4.509
input_lag_ms=26.191
exit_time_ms=24.928


Docs are broken: infinite redirect loop

When visiting https://googleapis.github.io/google-cloud-php/ and clicking "Read the docs" I get an infinite loop that redirects from https://googleapis.github.io/google-cloud-php/#/docs/google-cloud/0.135.0/not-found to https://googleapis.github.io/google-cloud-php/#/docs/google-cloud/v0.135.0/not-found and back again. The docs can therefore not be accessed.
Occurs in all browsers on all platforms.

Thanks for the heads up @bramus. We'll get this taken care of.

Fixed!


Fix MomentJS data loading.

Issue summary
MomentJS TZ returns a "data not loaded" error when using the library. As a result, it uses and displays GMT time.
Expected behavior
Data should be loaded appropriately, and as a result all dates should be consistent.
Actual behavior
Data is, apparently, not loaded correctly. So the "edit activity" page is mismatched from the header for that activity.
Your environment
Include version numbers

Browser: Chrome
Moment Timezone version: 0.5.31
npm version: 6.14.7

Additional Information
The momentJS documentation states that the data is automatically loaded.

Following the data loading procedures anyway does not fix this issue.


PhantomJS randomly crashes while running protractor e2e test

Setup:
maven (maven-ng-protractor 0.0.2)
protractor 1.3.1
phantomjs 1.9.7
webdriver-selenium 2.42.1
once for a while (sometimes about a half of builds) crash is happening :
Logs:
maven relevant log entries:
Message:
[INFO]      Error: ECONNREFUSED connect ECONNREFUSED
[INFO]    Stacktrace:
[INFO]      Error: ECONNREFUSED connect ECONNREFUSED
[INFO]     at ClientRequest.emit (events.js:95:17)
[INFO]     at Socket.socketErrorListener (http.js:1551:9)
[INFO]     at Socket.emit (events.js:95:17)
[INFO]     at net.js:440:14
[INFO]     at process._tickCallback (node.js:419:13)
[INFO] ==== async task ====
[INFO] WebDriver.navigate().to(data:text/html,)
[INFO]     at Object.webrep.pages.create (/home/src/portal/portal-webapp/src/test/e2e/someTest/webDataObject.js:32:37)
[INFO]     at [object Object]. (/home/src/portal/portal-webapp/src/test/e2e/someTest/webSpec.js:27:22)
[INFO] ==== async task ====
[INFO] Asynchronous test function: it()
[INFO] Error
[INFO]     at [object Object]. (/home/src/portal/portal-webapp/src/test/e2e/someTest/webSpec.js:26:5)
[INFO]     at Object. (/home/src/portal/portal-webapp/src/test/e2e/someTest/webSpec.js:1:63)
....(rest of e2e tests are failing after first fails)
phantomjs relevant log entries:
[DEBUG] WebPage - evaluateJavaScript result QVariant(QString, "{"status":0,"value":"User-Agent header"}")
[DEBUG] HTTP Response - Status Code 200 OK
[DEBUG] HTTP Response - Sending Header "Cache" = "no-cache"
[DEBUG] HTTP Response - Sending Header "Content-Length" = "91"
[DEBUG] HTTP Response - Sending Header "Content-Type" = "application/json;charset=UTF-8"
[DEBUG] HTTP Request - URI /session/f5a377c0-bd03-11e4-996d-a54813631f33/window/current/maximize
[DEBUG] HTTP Request - Method POST
[DEBUG] HTTP Request - HTTP Version 1.1
[DEBUG] HTTP Request - Query String
[DEBUG] HTTP Request - Receiving Header "Accept" = "application/json; charset=utf-8"
[DEBUG] HTTP Request - Receiving Header "Content-Length" = "2"
[DEBUG] HTTP Request - Receiving Header "Content-Type" = "application/json;charset=UTF-8"
[DEBUG] HTTP Request - Receiving Header "Host" = "<IP_ADDRESS>:4444"
[DEBUG] HTTP Request - Receiving Header "Connection" = "keep-alive"
[DEBUG] HTTP Request - Method POST/PUT
[DEBUG] HTTP Request - Content Body: {}
[DEBUG] HTTP Response - Status Code 200 OK
[DEBUG] HTTP Response - Sending Header "Cache" = "no-cache"
[DEBUG] HTTP Response - Sending Header "Content-Length" = "74"
[DEBUG] HTTP Response - Sending Header "Content-Type" = "application/json;charset=UTF-8"
[DEBUG] HTTP Request - URI /session/f5a377c0-bd03-11e4-996d-a54813631f33/url
[DEBUG] HTTP Request - Method POST
[DEBUG] HTTP Request - HTTP Version 1.1
[DEBUG] HTTP Request - Query String
[DEBUG] HTTP Request - Receiving Header "Accept" = "application/json; charset=utf-8"
[DEBUG] HTTP Request - Receiving Header "Content-Length" = "38"
[DEBUG] HTTP Request - Receiving Header "Content-Type" = "application/json;charset=UTF-8"
[DEBUG] HTTP Request - Receiving Header "Host" = "<IP_ADDRESS>:4444"
[DEBUG] HTTP Request - Receiving Header "Connection" = "keep-alive"
[DEBUG] HTTP Request - Method POST/PUT
[DEBUG] HTTP Request - Content Body: {"url":"data:text/html,"}
[DEBUG] WebPage - updateLoadingProgress: 10
PhantomJS has crashed. Please read the crash reporting guide at https://github.com/ariya/phantomjs/wiki/Crash-Reporting and file a bug report at https://github.com/ariya/phantomjs/issues/new with the crash dump file attached: /tmp/13e77164-eec6-bc54-2b5f0435-4b0f2bd4.dmp
initial form is not allowing the attachements of dmp type
Configuration
Command line args for the phantom js :
--webdriver=4444
--ignore-ssl-errors=true
--debug=true
--web-security=false
--webdriver-loglevel=DEBUG
--webdriver-logfile=webdriver.log
phantomjs is started by protractor.
Additional information

Each build is starting and using new instance of phantomjs.

This error is happening in random tests so it's not relevant to include them here. Also if builds are reusing the same instance
of phantomjs - then test are running much longer without any troubles. (not tested for how long but about 50 builds were successful,
and in case of new build - new instance case it starts to fail in about 7-10 builds).

If one build is failing next can be successful, there is no dependency between builds.

I'm having a very similar issue to this, any progress?


[Bug] Pages that result to 500 error get past fern check validations

Describe the bug
I am able to run:

fern check
fern generate

without any errors thrown, but on the docs site generated I have pages that can lead to a 500 error.
To reproduce
Steps to reproduce the behavior:

In any page, include <ResponseField>Some arbitrary content</ResponseField>
Run the command fern generate --docs --log-level debug  or fern check and see it succeed
Navigate to the page with this problematic content and see that it should lead to a 500 error instead of the page.

I understand that <ResponseField>Some arbitrary content</ResponseField> or content that shouldn't be parsed should be known to the user, but the visibility of 500 pages may be a problem for folks who depend on fern check
Expected behavior
Error raised regarding 500 pages.
Screenshots

Version
Fern Version: 0.16.35
Additional context
Add any other context about the problem here.

+1 this Issue is relevant: https://github.com/fern-api/fern/issues/2536

closing as a dup of https://github.com/fern-api/fern/issues/2536


Skip opening/creating file by Posh Git

As of today  git commit --amend will open a new text file in my text editor.
It's not fully clear why that is needed. Can this be disabled? It's really interrupting my command line work.

Isn't that normal behaviour? git commit --amend should open the editor populated with the commit being amended's message if not given --no-edit.
What version of git do you have?

git version 2.5.3.windows.1
So I just need to append --no-edit? Was this different before?

I don't think so. This isn't really posh-git, it's git's functionality.

OK thanks!

I believe that should do it, and I don't think this is new.

Yeah, not new. Fixing typos in commit messages is a common --amend use case.


fix new grafana versions not starting

imports a fix that sets a PID_FILE_DIR variable in /etc/defaults/grafana-server
see https://github.com/grafana/grafana/issues/9133
see https://github.com/grafana/grafana/commit/c3cffeb10ccd586b21774d54a1ebf434fddb2112#diff-ad598638c92a28d5d7ffdaba305d92b2

this has been fixed by https://github.com/ansiblebit/grafana/pull/10.

thank you for the PR and I apologize for the delay.


Broken returned  class from arrow function.

First of all ZOMG when I saw this project moved to Github @Rich-Harris. As you know i've been following (AND USING) bublé on all my projects for a couple years now. Gets the job done except in two cases.
const Foo = bar =>
(/* This code breaks compiler without parens */
class Baz {}
/* le sigh */ )

Foo ('bat') // class Baz {}

I did notice a slew of Arrow function messing up transpilation issues but haven't gone through all the issues yet.
Lastly...and not relative to this Issue but I need to know for the past 6 months. How do I enable string template literals? 😂
Thanks for the awesome tool! Keep it rocking. Some of us lo-key 🔑  depend on it. Hi-key even.

const Foo = bar => class Baz {} compiles for me fine with current master. What output do you get?

@adrianheine not certain as i've just been wrapping in ( ) I should check. Appreciate looking out for this.
Can finally update this line of code if what you say is correct. Thanks homie! <3

This works: https://buble.surge.sh/#const Foo %3D bar %3D>
class Baz {}

Foo ('bat') %2F%2F class Baz {}


get_queue should handle < 1s's precision

        let result: (Vec<Option<String>>, (u64, u64)) = pipe()
            .atomic()
            .cmd("HMGET")
            .arg(format!("{}{}:Q", self.ns, qname))
            .arg("vt")
            .arg("delay")
            .arg("maxsize")
            .cmd("TIME")
            .query(conn)?;

        let time_millis = (result.1).0 * 1000;

now get_queue just use seconds as queue.ts and uses that as a score for incoming message, we lose some precision here

Ref: https://github.com/smrchy/rsmq/blob/5c507c2ae97145fbdef7369da52dc69b105e0cc6/index.js#L44

https://github.com/smrchy/rsmq/blob/5c507c2ae97145fbdef7369da52dc69b105e0cc6/index.js#L175 here it throw away the milli seconds, but I feel we should be consistent

Hi! I'm happy to add that to the library.
Just two things:

Can you make an MR?
We should make it optional, as I want for it to still be compatible with the Nodejs version of it. So we can have a "js_compatible" feature that uses seconds, and have it disabled by default.

What do you think?

yes I'll make a PR

@DavidBM raised simple PR at: GopherJ:fix/score-precision

@GopherJ The MR is good! But could you make it so the changes are under a feature flag?

I merged your MR and followed up with some changes. Now your time precision is hidden behind a flag. You can enable it by adding rsmq async to your crate like this:
rsmq_async = { version = "11", features = [ "break-js-comp" ] }


Could not find a Coverage file!

I run the following command dotnet test /p:CollectCoverage=true /p:CoverletOutputFormat=opencover /p:CoverletOutput=TestResults/,
but when I click on WATCH it displays the following message "Could not find a Coverage file!"
this is configuration

I tried this one too, but to no avail.

@angelSwp Thanks for submitting an issue, lets try to get the extension working for yah!
I am not too familiar with the donet realm but many people seem to use this article to setup the extension with a given project has you taken a look at this yet? https://www.hanselman.com/blog/automatic-unit-testing-in-net-core-plus-code-coverage-in-visual-studio-code
You might be on the right track for using the custom xml name for the coverage file. What is the name of your filename outputted in TestResults? Usually you will want to just provide the name of the file rather then a path to the xml file (the extension will handle searching the workspace / project you have open for any xml files that match the name / regex.
https://github.com/ryanluker/vscode-coverage-gutters/blob/master/package.json#L44
Let me know if either of those help any!

Closing due to lack of activity, but can reopen!

I have more information on reproducing this.
To reproduce:

Load this repository in vscode:

Press F5

Wait for the new window to open, open the terminal and enter:

node ➜ ~ $ mkdir foo
node ➜ ~ $ cd foo/
node ➜ ~/foo $ mkdir bar
node ➜ ~/foo $ cat foo > lcov.info
cat: foo: No such file or directory
node ➜ ~/foo $ echo foo > lcov.info
node ➜ ~/foo $ chmod -r bar

This will create a directory in the development container named foo and a subdirectory named bar.
It will place a placeholder lcov.info, and then make bar unreadable.

Press Watch

I'm working on the fix on this branch:
https://github.com/auto-mat/vscode-coverage-gutters/tree/could-not-find-coverage-file
So far I've only added some debug messages.

Found the bug. It's in glob: https://github.com/isaacs/node-glob/pull/413
PR is forthcoming.

@timthelion Thanks for the detailed reproduction! I assigned this issue and the PR to the next release (2.9.0) so hopefully we can get it out shortly 🦾 .


Use environment to control program arguments

See #16:

I pushed a commit earlier today that allows the use of environment variables.
I thought you may be interested in cherry-picking if you found it useful?
export NPM_LAZY_PORT=80
export NPM_LAZY_EXTERNAL_URL=http://localhost
node index.js

Done, thanks a lot!


Implement __str__ for concat

My sense is that maybe we should stop implementing __str__ and just rely on pprint.  The str implementation is weird.  Thoughts?

I kind of prefer the str representation for short expression.
print(df.a.sum())

<dask_expr.expr.Scalar: expr=df['a'].sum()>

This is a bit closer to what I would expect as a user compared to pprint:
Sum:
  Projection: columns='a'
    FromPandas: frame='<pandas>' npartitions=5

i agree that short is good, but our implementation of str is haphazard at
best, and sometimes wrong.  There's a quality issue here I think
On Fri, Jun 30, 2023 at 9:16 AM Patrick Hoefler @.***>
wrote:

I kind of prefer the str representation for short expression.
print(df.a.sum())
<dask_expr.expr.Scalar: expr=df['a'].sum()>
This is a bit closer to what I would expect as a user compared to pprint:
Sum:
Projection: columns='a'
FromPandas: frame='' npartitions=5
—
Reply to this email directly, view it on GitHub
https://github.com/dask-contrib/dask-expr/pull/180#issuecomment-1614718858,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACKZTCGY5VIOYLVTGDSNL3XN3NT7ANCNFSM6AAAAAAZRRCTAE
.
You are receiving this because you commented.Message ID:
@.***>

There's a quality issue here I think

Yep I agree with this


Add .egg/ directories to .gitignore

there are a few other things ignored, fixing this means not having to worry about 'git status' showing:
Untracked files:
(use "git add ..." to include in what will be committed)
netaddr-0.7.19-py2.7.egg/
nose-1.3.7-py2.7.egg/

after running: python setup.py test

PR $64.


MutableRoaringArray: Set the right capacity for arrays when deserializing

Fixes #652
SUMMARY
I've modified the deserialize method in RoaringBitmapArray to use the same mechanism
that sets the array sizes (keys and values), in order to remove code duplication,
I've extracted a new method getNewCapacity. This fixes a bug in deserialization
where deserializing small data would cause ArrayIndexOutOfBoundsException.
I've added a test to cover the new code.
Automated Checks

[X] I have run ./gradlew test and made sure that my PR does not break any unit test.
[X] I have run ./gradlew checkstyleMain or the equivalent and corrected the formatting warnings reported.

I am not opposed to the change, but I think that there is a logical error in the intersects function.

@shanielh and @richardstartin : please checkout https://github.com/RoaringBitmap/RoaringBitmap/pull/654

I think I'll close it for now since it was fixed, Thanks @lemire


About test

Hi, I have finished training proces, but when I run test.py, it has the following error:
Traceback (most recent call last):
File "E:/HiFuse-main/test.py", line 68, in
main()
File "E:/HiFuse-main/test.py", line 45, in main
model.load_state_dict(torch.load(model_weight_path, map_location=device))
File "D:\Anaconda3\envs\pyt1.10\lib\site-packages\torch\nn\modules\module.py", line 1483, in load_state_dict
self.class.name, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for main_model:
Unexpected key(s) in state_dict: "stages.2.2.dwconv.weight", "stages.2.2.dwconv.bias", "stages.2.2.norm.weight", "stages.2.2.norm.bias", "stages.2.2.pwconv.weight", "stages.2.2.pwconv.bias", "stages.2.3.dwconv.weight", "stages.2.3.dwconv.bias", "stages.2.3.norm.weight", "stages.2.3.norm.bias", "stages.2.3.pwconv.weight", "stages.2.3.pwconv.bias", "stages.2.4.dwconv.weight", "stages.2.4.dwconv.bias", "stages.2.4.norm.weight", "stages.2.4.norm.bias", "stages.2.4.pwconv.weight", "stages.2.4.pwconv.bias", "stages.2.5.dwconv.weight", "stages.2.5.dwconv.bias", "stages.2.5.norm.weight", "stages.2.5.norm.bias", "stages.2.5.pwconv.weight", "stages.2.5.pwconv.bias", "layers3.blocks.2.norm1.weight", "layers3.blocks.2.norm1.bias", "layers3.blocks.2.attn.relative_position_bias_table", "layers3.blocks.2.attn.relative_position_index", "layers3.blocks.2.attn.qkv.weight", "layers3.blocks.2.attn.qkv.bias", "layers3.blocks.2.attn.proj.weight", "layers3.blocks.2.attn.proj.bias", "layers3.blocks.2.norm2.weight", "layers3.blocks.2.norm2.bias", "layers3.blocks.2.fc1.weight", "layers3.blocks.2.fc1.bias", "layers3.blocks.3.norm1.weight", "layers3.blocks.3.norm1.bias", "layers3.blocks.3.attn.relative_position_bias_table", "layers3.blocks.3.attn.relative_position_index", "layers3.blocks.3.attn.qkv.weight", "layers3.blocks.3.attn.qkv.bias", "layers3.blocks.3.attn.proj.weight", "layers3.blocks.3.attn.proj.bias", "layers3.blocks.3.norm2.weight", "layers3.blocks.3.norm2.bias", "layers3.blocks.3.fc1.weight", "layers3.blocks.3.fc1.bias", "layers3.blocks.4.norm1.weight", "layers3.blocks.4.norm1.bias", "layers3.blocks.4.attn.relative_position_bias_table", "layers3.blocks.4.attn.relative_position_index", "layers3.blocks.4.attn.qkv.weight", "layers3.blocks.4.attn.qkv.bias", "layers3.blocks.4.attn.proj.weight", "layers3.blocks.4.attn.proj.bias", "layers3.blocks.4.norm2.weight", "layers3.blocks.4.norm2.bias", "layers3.blocks.4.fc1.weight", "layers3.blocks.4.fc1.bias", "layers3.blocks.5.norm1.weight", "layers3.blocks.5.norm1.bias", "layers3.blocks.5.attn.relative_position_bias_table", "layers3.blocks.5.attn.relative_position_index", "layers3.blocks.5.attn.qkv.weight", "layers3.blocks.5.attn.qkv.bias", "layers3.blocks.5.attn.proj.weight", "layers3.blocks.5.attn.proj.bias", "layers3.blocks.5.norm2.weight", "layers3.blocks.5.norm2.bias", "layers3.blocks.5.fc1.weight", "layers3.blocks.5.fc1.bias".
I want to know what is the reason, thank you!

You can change 'checkpoint' to 'model.state dict()' in train.py (line 140).

Thanks for your reply, but it doesn't work. In test.py, "best_model.pth" is used, and in train.py,  when save  "best_model.pth", it is "torch.save(model.state_dict(), "./model_weight/best_model.pth") "(line 125). Hence, I don't think that's the reason.

You can change 'checkpoint' to 'model.state dict()' in train.py (line 140).

Thanks for your reply, but it doesn't work. In test.py, "best_model.pth" is used, and in train.py, when save "best_model.pth", it is "torch.save(model.state_dict(), "./model_weight/best_model.pth") "(line 125). Hence, I don't think that's the reason.

You can change 'checkpoint' to 'model.state dict()' in train.py (line 140).

And I tried "model.load_state_dict(torch.load(model_weight_path, map_location=device),False)", it can run， but I wonder if the model is really loaded, because the accuracy in test was ten points lower than that in training phase.

You can change 'checkpoint' to 'model.state dict()' in train.py (line 140).

I have found the reason. in train.py is "from main_model import HiFuse_Small as create_model" but in test.py is "from main_model import main_model as create_model", the model is different.


We should be able to write attributes before observing a resource.

Acording to LWM2M specification for notify (5.5.2). We should be able to set the observe attributes before sending the observe request.

As far as I could tell the handling of the the attribute values is done in the respective handle_put_request method from M2MBase and derivations where handle_observation_attribute is called if a query is present.
To do so, at that point in time the _report_handler must be already initialized. The problem I see is that _report_handler  is only initialized either during assigment/copy of one M2MBase instance. Or in the M2MBase::set_under_observation method call.
As far as I understood, this method call will only happen when make an observe request to the resource, therefore making impossible to set the attributes before the observe request.

Hi,
Yes that's how it has been implemented at the moment. There are few changes we are planning to do related with observation and handling attributes and this is one of them which we will check and fix. We will update when we do this change.

ARM Internal Ref: IOTCLT-593

On a unrelated note, trying to hack my way through. I did some small changes to try to set the attributes beforehand when I observed something weird. I got to a point were I run the M2MReportHandler::set_notification_attribute method. When I reach the code shown below (which I also modified slightly to test) the values of the following variables are:
option "pmin=10.0"
attribute "pmin\0"
attribute "10\0"
if (strcmp(attribute, PMIN.c_str()) == 0) {
    	int test = -1;
    	double test2 = -1;
    	int r = -1;
    	r = sscanf(value, "%d", &test);
    	r = sscanf(value, "%lg", &test2);
        r = sscanf(value, "%f", &_pmin);
        success = true;
        _attribute_state |= M2MReportHandler::Pmin;
        tr_debug("M2MReportHandler::set_notification_attribute %s to %f read %d", attribute, _pmin, r);
    }

Nevertheless only the first sscanf works, filling test with value 10.
I'm currently using the version 4.9_2015q1 of the GNU Tools ARM Embedded.
Is there any reported misbehavior of the sscanf function?
Is there any better place to post this secondary issue?

Hi, That's strange behaviour because we have tests where we are passing pmin=10.0 and it works correctly. We will need to check this again. Of late, there has been issue with using float on some compilers.

Thanks for the heads up. For completion, I updated the previous comment (I was mixing 10.0 and 10) also just add that I tried using "pmin=10" (and other random values with and without ".") with no luck.

Hi, It's should be possible to write attributes before the observation is started, at least I got it working nicely. M2MBase::set_under_observation is called when ever resource is created in M2MNsdlInterface class so report handler should exist when handle_put_request is called.
There is also fix for float type handling. Can you try out and see is the mbed-client version 1.4.4 working any better?

Hi, I'll close this ticket since no response, but feel free to open it again or create new one if you have any further questions.


Ghost Wall only Hands

I think ghost hands could have both types.
Also I think there should be example of ghost hands that shows only when hands is poking throu wall and does not activate for items.

The ghost hands were made using the technique described in the Display Your Character Behind Walls in less than 5 Minutes (no code) - 3D Godot Tutorial youtube video.
I'm not sure if there's a simple technique which would allow the ghost-hand effect to be selective to only show for certain objects.

This is not something simple and highly specific, Malcolms solution works for certain situations.
We'll give this some more thought to see if we can come up with something, but if we don't come up with something generic this may not end up in XR Tools.