Issue reporting

Note: This branch was based off of another branch where devcontainer support was added. (see PR https://github.com/Lissy93/portainer-templates/pull/57)
The purpose of this PR is to provide direct issue-reporting links alongside each of the apps. This should hopefully empower users to report issues in the proper repo.

I think we can also make an improvment, where we extract the maintainer from the template source, so that it doesn't need to be specified twice in the sources.csv.
E.g.
dnburgess_templates, https://raw.githubusercontent.com/dnburgess/self-hosted-template/master/template.json, https://github.com/dnburgess/self-hosted-template/
We can figure out that the repo is https://github.com/dnburgess/self-hosted-template from the initial link, without needing the second one


[usbdev] Increase robustness of packet reception when SYNC signal is corrupted.

Description
Description copied over from: https://github.com/lowRISC/opentitan/pull/23717
Commit 1:
Modify end of packet detection so that it does not depend upon the validity of the SYNC signal. End of packet must always be signaled to the packet state machines even if the packet has been declared invalid, because otherwise the OUT side state machine will wait indefinitely for the end of a DATA packet.
This does not occur in normal use, but may occur in the presence of interference, signal integrity issues and/or improper sampling.
Background: fault injection testing in block level DV transmitted a valid OUT packet which was then followed by a DATA packet with a corrupted SYNC signal. The result is that 'packet_valid_q' does not become set for the DATA packet, although 'pkt_start_o' is asserted, and there is thus no 'pkt_end_o' assertion for the DATA packet. The OUT side state machine remains in the StRcvdDataStart state, from which there is no exit until the end of a subsequent packet.
The RTL change proposed in this draft PR permits the block level test to run to completion. (The test in question is generating invalid traffic whilst a streaming + checking process is running and keeping the DUT busy; the invalid traffic is expected to produce no response from the DUT but because of the above issue caused interference with the streaming operation.)
Update: There is a further deficiency in the handling of 'packet_valid_q' because of the way that bit stuffing errors and preamble cause the signal to be deasserted. After a bit stuffing error the logic can wake up again mid-packet in response to a bit sequence that looks like a SYNC signal. There is nothing to stop a KJKJKK sequence occurring within the ensuing bits. This PR now remembers the fact that the packet is being ignored and prevents 'packet_valid_d|q' becoming reasserted prematurely.

Hi @a-will can we get your assessment on this issue?

@alees24 found a robustness / fault tolerance issue. The OUT packet engine can freeze if there are errors in the SYNC signal during the data phase of the transaction. At first glance, the severity doesn't seem particularly high, though, as the likelihood of unrecoverable failures seems to be very low.
The FSM should unwedge on the next token packet (heading back to Idle and transmitting no ACK for potentially both transactions) or on the reception of a SYNC-like data pattern, where a highly unlikely sequence could lead to bad data being accepted. For the latter case, the data stream would need to have the equivalent of a SYNC + correct PID and still pass the CRC-16 for bad data to be accepted.
There's some badness in the interface between usb_fs_rx and other modules that could be cleared away by not exposing them to the SYNC at all. If response timeouts were increased to accommodate time for a SYNC, then usb_fs_rx.pkt_start_o could be properly tied to usb_fs_rx.packet_start, and the interface would become the boundaries that mark the regions where we receive actual bits. In that case, the PID check would be guaranteed to occur.
After a failed SYNC, usb_fs_rx probably should also be rejecting inputs until it sees at least the [SE0, J] sequence, but the packet engines shouldn't need it.
Overall, if the RTL fix is small enough and can be taken easily, I think it'd be good to make the ECO. However, the bug doesn't seem critical enough to warrant any more major efforts (e.g. resynthesis).
Please correct me, @alees24, if I have made an error in the reasoning.

We've discussed this issue in the tape-out sync yesterday (2024-06-24) and reached consensus to:

Not merge this / integrate this as ECO now. The reasons are mostly that i) the issue isn't super critical, ii) normal operation shouldn't be affected (the fix improves things in the presence of interference and signal integrity issues), and iii) to increase confidence proper FPGA soak time would be needed which we don't have.
Integrate the change post M5 after the TO branch has been taken to allow this USBDEV improvement for future releases / revisions of the design.

Integrating this improvement after taking the TO branch should be easy as it doesn't involve any software changes which could break the compatibility with Earlgrey-PROD A1.

We just discussed this in triage and agreed to put it into Backlog, because it won't be implemented with an ECO or metal fix, thus not part of Earlgrey-PROD.


Issues around nested routes

So Lotus router lets you do this, and doesn't complain:
router = Lotus::Router.new do
  resources :groups do
    member do
      resources :activities
    end
  end
end

But if we do puts router.inspector...
/groups/:id/activities GET, HEAD  /groups/:id/activities         /groups/:id/activities::Index
new_/groups/:id/activities GET, HEAD  /groups/:id/activities/new     /groups/:id/activities::New
/groups/:id/activities POST       /groups/:id/activities         /groups/:id/activities::Create
/groups/:id/activities GET, HEAD  /groups/:id/activities/:id     /groups/:id/activities::Show
edit_/groups/:id/activities GET, HEAD  /groups/:id/activities/:id/edit /groups/:id/activities::Edit
/groups/:id/activities PATCH      /groups/:id/activities/:id     /groups/:id/activities::Update
/groups/:id/activities DELETE     /groups/:id/activities/:id     /groups/:id/activities::Destroy
              groups GET, HEAD  /groups                        Groups::Index
          new_groups GET, HEAD  /groups/new                    Groups::New
              groups POST       /groups                        Groups::Create
              groups GET, HEAD  /groups/:id                    Groups::Show
         edit_groups GET, HEAD  /groups/:id/edit               Groups::Edit
              groups PATCH      /groups/:id                    Groups::Update
              groups DELETE     /groups/:id                    Groups::Destroy

...it gives us complete nonsense.
Same thing for:
router = Lotus::Router.new do
  resources :users do
    member do
      resource :avatar
    end
  end
end

new_/users/:id/avatar GET, HEAD  /users/:id/avatar/new          /users/:id/avatar::New
   /users/:id/avatar POST       /users/:id/avatar              /users/:id/avatar::Create
   /users/:id/avatar GET, HEAD  /users/:id/avatar              /users/:id/avatar::Show
edit_/users/:id/avatar GET, HEAD  /users/:id/avatar/edit         /users/:id/avatar::Edit
   /users/:id/avatar PATCH      /users/:id/avatar              /users/:id/avatar::Update
   /users/:id/avatar DELETE     /users/:id/avatar              /users/:id/avatar::Destroy
               users GET, HEAD  /users                         Users::Index
           new_users GET, HEAD  /users/new                     Users::New
               users POST       /users                         Users::Create
               users GET, HEAD  /users/:id                     Users::Show
          edit_users GET, HEAD  /users/:id/edit                Users::Edit
               users PATCH      /users/:id                     Users::Update
               users DELETE     /users/:id                     Users::Destroy

So from here I see two options:

Decide that nested resources are evil, and explicitly disallow them. (And I can totally see arguments for this).
Make it work in a more expected manner.

If nested resources were explicitly disallowed, I think there'd be some utility from the users/:id/avatar case that would be lost. As such, I think option two is probably the better option.
If option two works, I'd be happy to put together a pull request (though it may take me a while, since it looks like it would be a significant set of changes to the internals here).

@Emily the first example raises an exception for me:
HttpRouter::AmbiguousVariableException: You have duplicate variable names present: id
	from /home/alfonso/.rvm/gems/ruby-2.2.0/gems/http_router-0.11.1/lib/http_router/node/path.rb:10:in `initialize'
	from /home/alfonso/.rvm/gems/ruby-2.2.0/gems/http_router-0.11.1/lib/http_router/node.rb:66:in `new'
	from /home/alfonso/.rvm/gems/ruby-2.2.0/gems/http_router-0.11.1/lib/http_router/node.rb:66:in `add_destination'
	from /home/alfonso/.rvm/gems/ruby-2.2.0/gems/http_router-0.11.1/lib/http_router/node/root.rb:135:in `add_non_path_to_tree'
	from /home/alfonso/.rvm/gems/ruby-2.2.0/gems/http_router-0.11.1/lib/http_router/node/root.rb:84:in `block in add_route'
	from /home/alfonso/.rvm/gems/ruby-2.2.0/gems/http_router-0.11.1/lib/http_router/generator.rb:71:in `block in each_path'
	from /home/alfonso/.rvm/gems/ruby-2.2.0/gems/http_router-0.11.1/lib/http_router/generator.rb:71:in `each'
	from /home/alfonso/.rvm/gems/ruby-2.2.0/gems/http_router-0.11.1/lib/http_router/generator.rb:71:in `each_path'
	from /home/alfonso/.rvm/gems/ruby-2.2.0/gems/http_router-0.11.1/lib/http_router/node/root.rb:72:in `add_route'
	from /home/alfonso/.rvm/gems/ruby-2.2.0/gems/http_router-0.11.1/lib/http_router/node/root.rb:34:in `block in compile'
	from /home/alfonso/.rvm/gems/ruby-2.2.0/gems/http_router-0.11.1/lib/http_router/node/root.rb:34:in `each'
	from /home/alfonso/.rvm/gems/ruby-2.2.0/gems/http_router-0.11.1/lib/http_router/node/root.rb:34:in `compile'
	from /home/alfonso/.rvm/gems/ruby-2.2.0/gems/http_router-0.11.1/lib/http_router.rb:295:in `compile'
	from /home/alfonso/.rvm/gems/ruby-2.2.0/gems/http_router-0.11.1/lib/http_router.rb:238:in `to_s'
	from /home/alfonso/.rvm/gems/ruby-2.2.0/gems/http_router-0.11.1/lib/http_router.rb:243:in `inspect'
	from /home/alfonso/.rvm/rubies/ruby-2.2.0/bin/irb:11:in `<main>'

@Emily Sorry for taking so long to reply. My apologize.
First example
I can confirm what @AlfonsoUceda said:
% bundle console
Resolving dependencies...
irb(main):001:0> router = Lotus::Router.new do
irb(main):002:1*   resources :groups do
irb(main):003:2*     member do
irb(main):004:3*       resources :activities
irb(main):005:3>     end
irb(main):006:2>   end
irb(main):007:1> end
HttpRouter::AmbiguousVariableException: You have duplicate variable names present: id
	from /Users/luca/.gem/ruby/2.2.0/gems/http_router-0.11.1/lib/http_router/node/path.rb:10:in `initialize'
	from /Users/luca/.gem/ruby/2.2.0/gems/http_router-0.11.1/lib/http_router/node.rb:66:in `new'
	from /Users/luca/.gem/ruby/2.2.0/gems/http_router-0.11.1/lib/http_router/node.rb:66:in `add_destination'
	from /Users/luca/.gem/ruby/2.2.0/gems/http_router-0.11.1/lib/http_router/node/root.rb:135:in `add_non_path_to_tree'
	from /Users/luca/.gem/ruby/2.2.0/gems/http_router-0.11.1/lib/http_router/node/root.rb:84:in `block in add_route'
	from /Users/luca/.gem/ruby/2.2.0/gems/http_router-0.11.1/lib/http_router/generator.rb:71:in `block in each_path'
	from /Users/luca/.gem/ruby/2.2.0/gems/http_router-0.11.1/lib/http_router/generator.rb:71:in `each'
	from /Users/luca/.gem/ruby/2.2.0/gems/http_router-0.11.1/lib/http_router/generator.rb:71:in `each_path'
	from /Users/luca/.gem/ruby/2.2.0/gems/http_router-0.11.1/lib/http_router/node/root.rb:72:in `add_route'
	from /Users/luca/.gem/ruby/2.2.0/gems/http_router-0.11.1/lib/http_router/node/root.rb:34:in `block in compile'
	from /Users/luca/.gem/ruby/2.2.0/gems/http_router-0.11.1/lib/http_router/node/root.rb:34:in `each'
	from /Users/luca/.gem/ruby/2.2.0/gems/http_router-0.11.1/lib/http_router/node/root.rb:34:in `compile'
	from /Users/luca/.gem/ruby/2.2.0/gems/http_router-0.11.1/lib/http_router.rb:295:in `compile'
	from /Users/luca/.gem/ruby/2.2.0/gems/http_router-0.11.1/lib/http_router.rb:238:in `to_s'
	from /Users/luca/.gem/ruby/2.2.0/gems/http_router-0.11.1/lib/http_router.rb:243:in `inspect'
	from /Users/luca/.gem/ruby/2.2.0/gems/bundler-1.7.9/lib/bundler/cli/console.rb:38:in `run'
	from /Users/luca/.gem/ruby/2.2.0/gems/bundler-1.7.9/lib/bundler/cli.rb:286:in `console'
	from /Users/luca/.gem/ruby/2.2.0/gems/bundler-1.7.9/lib/bundler/vendor/thor/command.rb:27:in `run'
	from /Users/luca/.gem/ruby/2.2.0/gems/bundler-1.7.9/lib/bundler/vendor/thor/invocation.rb:121:in `invoke_command'
	from /Users/luca/.gem/ruby/2.2.0/gems/bundler-1.7.9/lib/bundler/vendor/thor.rb:363:in `dispatch'
	from /Users/luca/.gem/ruby/2.2.0/gems/bundler-1.7.9/lib/bundler/vendor/thor/base.rb:440:in `start'
	from /Users/luca/.gem/ruby/2.2.0/gems/bundler-1.7.9/lib/bundler/cli.rb:9:in `start'
	from /Users/luca/.gem/ruby/2.2.0/gems/bundler-1.7.9/bin/bundle:20:in `block in <top (required)>'
	from /Users/luca/.gem/ruby/2.2.0/gems/bundler-1.7.9/lib/bundler/friendly_errors.rb:5:in `with_friendly_errors'
	from /Users/luca/.gem/ruby/2.2.0/gems/bundler-1.7.9/bin/bundle:18:in `<top (required)>'
	from /Users/luca/.gem/ruby/2.2.0/bin/bundle:23:in `load'
	from /Users/luca/.gem/ruby/2.2.0/bin/bundle:23:in `<main>'irb(main):008:0>

I'm running that command from my local copy of lotus-router repository.  I'm for keeping nested resources. We can discuss if they are good or not, but those can be required for API endpoints that need that kind of design by specifications.

In my experience I believe nested routes are useful but only one level, imagine you want get comments by post:
/post/1/comments/
For my this is useful but more nested routes are useless, eg:
granparents/1/parents/1/children
Can be converted to:
granparents/1/parents
parents/1/children
because only need the :parent_id to get children

@Emily I think I committed I mistake while triaging this issue: the following syntax isn't something that we want to support.
member do
  resource :avatar
end

This looks like a workaround for nested RESTful resources. I'm closing this, because it isn't a bug, if it doesn't show the right output for unsupported feature.
I think we need proper nested RESTful resources. Opened a ticket for this: https://github.com/lotus/router/issues/47


Fix tests on PHP 5.6 & HHVM

This fixes thephpleague/skeleton/issues/114
The minimum requirement for PHPUnit when run with --prefer-lowest is 5.4.3
(more precisely it would be 4.8.35, but since the default PHP requirement is PHP 5.6 there is no point in targeting 4.8)
Also fixing tests on HHVM which require now dist: trusty to run
All tests pass with this.

Ping. Anyone alive? :)

@frankdejonge


Use DisplayVersion for OpenRCT2.OpenRCT2 0.3.4

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Related to #94743

Microsoft Reviewers: Open in CodeFlow

@wingetbot run

@wingetbot run


Custom events and trigger

Allow the use of .on() with some custom event. Also add a trigger() on views.
You can now use something like
append(UIView).on(:my_event) {|o| }

rmq(UIView).trigger(:my_event)

I love this idea.

:+1:

This is awesome Benjamin, let me check the code real quick

Love it.

Benjamin merged. You get a high four for that http://ir_public.s3.amazonaws.com/slack/high_four.jpg
It would be uber cool, if you could add docs to RedPotion's event docs also: https://github.com/infinitered/redpotion/blob/master/docs/cookbook/events_and_gestures.md

@twerth i'll do that

Something is broken with this, I'm debugging now

I'm using it atm, what is broken ?

sender is an RMQ object
      sender.should == view
      some_value = true
    end```

is test I just created, it's failing

or is it suppose to return the rmq object? Hmm, I may be totally wrong on that

Hmm, no, you're right, it should be
events(view)[event].block.call(self.get) if events(view)[event]

on events.rb:111

Nevermind, I have another test that says it should be the view wrapped in an RMQ object. It's been a while since I wrote this (events were actually the very first thing I wrote for RMQ). My mistake, sorry.

Small fix: https://github.com/infinitered/rmq/commit/0606d93c86102ff4756e27a8b0a6b124915e134a

FYI, there are some other issues, user_interaction is enabled on a custom event, this causes issue. I'm also checking the the event state is correct on custom events. I'm working on tests and fixes for this

Mhh, sorry @twerth, tests were running fine, I thought I had broken anything :/

No worries Ben.  It's a great feature and the community will really appreciate you created it.

I'd love to see an example of what you guys are doing with custom events like this! :)

@squidpunch The simplest example of the world :)
I've a "button" and only want to allow tap on part of this view
# Screen
append(Button, :style).on(:tapped) do |sender|
       # i've been tapped
end

# Button < UIView
def on_load
   append(UIImageView, :bg).on(:tap) do |_|
        find(self).trigger(:tapped)
   end
end

# style
def bg(st)
     st.frame = {l: 30, t: 30, fr: 30, fb: 30 }
end

oh ok, i gotcha - cool, thanks @bmichotte

You can also imagine something like (web browser)
def on_load
   append(UITextField, :url_field)

   append(UIWebView, :web).on(:goto_url) do |sender|
        url = find(:url_field).data # not sure about the .data, i'm new to redpotion :p
        sender.loadRequest url.nsurl.nsurlrequest # using sugarcube
   end

   append(UIButton).on(:tap) do
       find(:web).trigger(:goto_url)
   end
end

I find this very elegant, more then
def on_load
   append(UITextField, :url_field)
   append(UIWebView, :web)
   append(UIButton).on(:tap) do
       goto_url
   end
end

def goto_url
   url = find(:url_field).data
   find(:web).get.loadRequest url.nsurl.nsurlrequest
end

I do this all the time with jQuery, so it's a natural fit here.

FYI some more fixes and tests: https://github.com/infinitered/rmq/commit/06885808f5421eac96a4918f62af2370750df1fa

Waow, nice :)

Hey @bmichotte, @twerth , I don't believe that this commit is correct: 0606d93
For non-custom/regular events sender is not a rmq object.


does mysql in docker-compose-base.yaml allow  remote connection as default?

Describe your problem
if so , after running docker compose -f docker-compose-base.yaml up -d , try to run ragflow_server.py for local development, then it throws as following:
Traceback (most recent call last):
  File "/Users/yangboz/git/dangkang/flaskrestx/ragflow_server.py", line 63, in <module>
    init_web_db()
  File "/Users/yangboz/anaconda3/envs/ragflow/lib/python3.11/site-packages/peewee.py", line 3127, in inner

....

peewee.OperationalError: (2003, "Can't connect to MySQL server on 'mysql' ([Errno 8] nodename nor servname provided, or not known)")

any idea ? thanks.

Check the conf/service_conf.ymal.
Make sure all the hosts there are accessible,


Docs - Quick Start - Add a Theme section not displaying properly

While visiting following url, Add a Theme section is not displaying properly.
https://gohugo.io/getting-started/quick-start/#step-3-add-a-theme

@bep I am able to pick it up. Please let me know.

Please, post this at https://github.com/gohugoio/gohugoioTheme

@peaceiris Done - https://github.com/gohugoio/gohugoioTheme/issues/137

You can close this.


the bot crashes when a bot sends a message

Whenever a bot sends a message, the bot itself crashes because it tires to access a property that doesn't exist when it's the bot itself writing the message.
    if (
      inPrivate(msg) ||
      hasPerms(msg) ||
      msg.author.bot ||
      hasExcludedSpamChannels(msg) ||
      hasExcludedSpamUsers(msg)
    )

should be changed to
    if (
      inPrivate(msg) ||
      msg.author.bot ||
      hasPerms(msg) ||
      hasExcludedSpamChannels(msg) ||
      hasExcludedSpamUsers(msg)
    )

what file is this?

cant seem to duplicate the bot crashing

@MSFTserver the spam checker, gets this error because of hasPerms being called before checking if its a bot, therefore if its a bot it crashed because a bot is not a member

oh maybe cause i had role BOTS added to has perms ;)


perf: speed up integrable_rpow_neg_one_add_norm_sq

This goes from about 20 seconds to instantaneous locally.

Good point, I was going to add a comment but forgot. As far as I understand it, fun_prop should replace measurability at some point (but it doesn't work yet for this proof), so I don't think anyone will look at an issue.
maintainer merge

Out of curiosity: how did you find this one? Do you know other measurability invocations which are really slow?
(If I have some free Lean time and like popping bubble wrap, fixing these could be a nice thing to do :-))

Purely by accident - I had put a #minimize_imports at the end of the file and was waiting for it to run - and waiting - and waiting...

It might also be interesting to see how fun_prop does.
bors merge

Purely by accident - I had put a #minimize_imports at the end of the file and was waiting for it to run - and waiting - and waiting...

Oh wow, that was a happy accident! I'll keep an item on my long list of things to investigate.
(Current plan: set_option profiler true globally, build mathlib and see which tactic calls stick out. I don't have time to look at this list right now, though.)


issue #12450: return original URL in original_url JSON field

As related in issue #12450, the field original_url is always empty when requesting the API route GET repos/{orga}/{project}, even when the project is a mirror repo.
In such case I would excpect to get in original_url the URL of the origin repository used to initiate the project.
This PR is my attempt to fix this :
curl -s -X GET "http://<IP_ADDRESS>:3000/api/v1/repos/rico/input-event-daemon?access_token=$TOKKEN" -H "accept: application/json" | jq
{
  "id": 1,
...
  "html_url": "http://localhost:3000/rico/input-event-daemon",
  "ssh_url": "rico@localhost:rico/input-event-daemon.git",
  "clone_url": "http://localhost:3000/rico/input-event-daemon.git",
  "original_url": "https://github.com/eric-belhomme/input-event-daemon.git",
 ...
}

I tested my patch with mysql and sqlite3 database backends with no errors.

ping

Backport: #13886


feat(watchMode): add watch mode on codelens

fix issue https://github.com/firsttris/vscode-jest-runner/issues/202
How I test  ?

I run watch mode from command palette and Lens on some tests

good work! appreciate you contribution


Upgrade prettier peer dependency to ^3.0.0

Prettier v3 has been released. Currently when using this plugin, the peer dependencies conflict with prettier v3:
  "peerDependencies": {
    "prettier": "^2.0.0"
  },

Do we have an execution plan yet?

I just updated  prettier-plugin-organize-attributes to support v3. Next up this plugin will come.


Relax poison dependency.

decode! and encode! work the same in 1.x and 2.x, so I relaxed the dependency.

Interesting, I was not aware you can do or in mix files. For some reason this does not merge. Can you please take a look?

It conflicted with this commit, I just fixed it!


What version of libsodium?

Hi again
What version of libsodium was this built against?
Thanks
Simon

It's using shared sodium library:
"libraries": {       "shared": [         "v8",         "sodium"       ]     },
Meaning it's the version you have installed.


Feature/outlook refactor

This separates out the previous OutlookStorage class with OutlookAccount, OutlookStore and OutlookFolder classes, for cleaner interfaces.


HBASE-28866 Setting hbase.oldwals.cleaner.thread.size to negative value will brea…

…k HMaster and produce hard-to-diagnose logs
This Pull Request addresses the issue described in HBASE-28866: setting hbase.oldwals.cleaner.thread.size to a negative value can break HMaster and produce hard-to-diagnose logs.
Problem: When the configuration property is set to -1, the HBase Master fails to initialize due to an IllegalArgumentException, resulting in confusing logs that mislead users regarding the root cause.
Solution: The attached patch adds a validation check and relevant logging for the hbase.oldwals.cleaner.thread.size during the LogCleaner initialization. This improvement will help users diagnose issues more effectively.
We appreciate your review and feedback!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  7s

master passed

+1 :green_heart:
compile
3m  2s

master passed

+1 :green_heart:
checkstyle
0m 38s

master passed

+1 :green_heart:
spotbugs
1m 39s

master passed

+1 :green_heart:
spotless
0m 46s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 54s

the patch passed

+1 :green_heart:
compile
3m  2s

the patch passed

+1 :green_heart:
javac
3m  2s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 37s

the patch passed

+1 :green_heart:
spotbugs
1m 42s

the patch passed

+1 :green_heart:
hadoopcheck
10m 31s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

-1 :x:
spotless
0m 39s

patch has 22 errors when running spotless:check, run spotless:apply to fix.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 40s

the patch passed

+1 :green_heart:
compile
1m 34s

the patch passed

+1 :green_heart:
javac
1m 34s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed

+1 :green_heart:
shadedjars
8m 58s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
299m 16s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

333m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6310/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6310

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux eb24e754f5e8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a7fa68d0ba7619ebb0c6281f62c3162e6017cdce

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6310/1/testReport/

Max. process+thread count
4408 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6310/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  7s

master passed

+1 :green_heart:
compile
3m  5s

master passed

+1 :green_heart:
checkstyle
0m 36s

master passed

+1 :green_heart:
spotbugs
1m 34s

master passed

+1 :green_heart:
spotless
0m 43s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 52s

the patch passed

+1 :green_heart:
compile
3m  3s

the patch passed

+1 :green_heart:
javac
3m  3s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 34s

the patch passed

+1 :green_heart:
spotbugs
1m 37s

the patch passed

+1 :green_heart:
hadoopcheck
10m 51s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

-1 :x:
spotless
0m 36s

patch has 27 errors when running spotless:check, run spotless:apply to fix.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 53s

the patch passed

+1 :green_heart:
compile
0m 53s

the patch passed

+1 :green_heart:
javac
0m 53s

the patch passed

+1 :green_heart:
javadoc
0m 25s

the patch passed

+1 :green_heart:
shadedjars
5m 30s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
211m 46s

hbase-server in the patch passed.

236m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6310/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6310

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 7fe369e5cf93 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 928988e8d4b488bd659bec8bd3f7ebc5c2ebb2a9

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6310/2/testReport/

Max. process+thread count
5319 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6310/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  7s

master passed

+1 :green_heart:
compile
3m  2s

master passed

+1 :green_heart:
checkstyle
0m 36s

master passed

+1 :green_heart:
spotbugs
1m 38s

master passed

+1 :green_heart:
spotless
0m 46s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 55s

the patch passed

+1 :green_heart:
compile
3m  0s

the patch passed

+1 :green_heart:
javac
3m  0s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 37s

the patch passed

+1 :green_heart:
spotbugs
1m 40s

the patch passed

+1 :green_heart:
hadoopcheck
10m 46s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 44s

patch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  5s

the patch passed

+1 :green_heart:
compile
0m 57s

the patch passed

+1 :green_heart:
javac
0m 57s

the patch passed

+1 :green_heart:
javadoc
0m 26s

the patch passed

+1 :green_heart:
shadedjars
5m 43s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
213m 46s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

239m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6310/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6310

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 8a617e83acac 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6f1fbd1178fc3142a9bd3b1b73e71ec101ad902e

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6310/3/testReport/

Max. process+thread count
5540 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6310/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 53s

master passed

+1 :green_heart:
compile
3m  2s

master passed

+1 :green_heart:
checkstyle
0m 37s

master passed

+1 :green_heart:
spotbugs
1m 33s

master passed

+1 :green_heart:
spotless
0m 44s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 54s

the patch passed

+1 :green_heart:
compile
3m  3s

the patch passed

+1 :green_heart:
javac
3m  3s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 37s

the patch passed

+1 :green_heart:
spotbugs
1m 39s

the patch passed

+1 :green_heart:
hadoopcheck
10m 23s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 44s

patch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  3s

the patch passed

+1 :green_heart:
compile
0m 57s

the patch passed

+1 :green_heart:
javac
0m 57s

the patch passed

+1 :green_heart:
javadoc
0m 27s

the patch passed

+1 :green_heart:
shadedjars
5m 47s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
211m 16s

hbase-server in the patch passed.

237m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6310/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6310

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 7e3b01435667 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 5cd3ae2a3d11706a3674da1f1bdfdc326d3fc7e8

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6310/4/testReport/

Max. process+thread count
5503 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6310/4/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


Add note about QCCSID

QCCSID must not be 65535 for source dates to be used.

@worksofliam Done. Please review.


Add a code of conduct section to README.md

Associated Issue: #48
Summary of Changes

Add the code of conduct section to the README.md

Pull Request Test Coverage Report for Build 170

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.789%

Totals

Change from base Build 164:
0.0%

Covered Lines:
97

Relevant Lines:
107

💛  - Coveralls

Thank you!


Syntax error when run it in HPC

Hi, I was trying to run HPV-EM in the HPC terminal. Yet I received a series of syntax error, such as:
$ python HPV-EM.py -s ../GRCh38.100 ../Data/xxx_1.fq ../Data/xxx_2.fq
File "HPV-EM.py", line 31
except subp.CalledProcessError, e:
^
SyntaxError: invalid syntax
also error shown for print, etc. I am running with python/3.7.0. How could I address this issue? Thanks!

It is due to different python versions.
We will address this compatibility issue in the coming updates.
From: Laurel Gui<EMAIL_ADDRESS>Reply-To: jin-wash-u/HPV-EM<EMAIL_ADDRESS>Date: Wednesday, September 16, 2020 at 10:34 AM
To: jin-wash-u/HPV-EM<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [jin-wash-u/HPV-EM] Syntax error when run it in HPC (#1)

External Email - Caution *

Hi, I was trying to run HPV-EM in the HPC terminal. Yet I received a series of syntax error, such as:
$ python HPV-EM.py -s ../GRCh38.100 ../Data/xxx_1.fq ../Data/xxx_2.fq
File "HPV-EM.py", line 31
except subp.CalledProcessError, e:
^
SyntaxError: invalid syntax
also error shown for print, etc. I am running with python/3.7.0. How could I address this issue? Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/jin-wash-u/HPV-EM/issues/1, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEIC43TODE4BNCFXZONNWGTSGDLJVANCNFSM4RPAQ35A.

The materials in this message are private and may contain Protected Healthcare Information or other information of a sensitive nature. If you are not the intended recipient, be advised that any unauthorized use, disclosure, copying or the taking of any action in reliance on the contents of this information is strictly prohibited. If you have received this email in error, please immediately notify the sender via telephone or return mail.

Hi laurelgui,
HPV-EM has been updated so it can be run with Python 3+ without errors.


resync C version of engine.js with API changes

i love how this issue title implies it ever worked in the first place

This is an ongoing task.


Relabel the heading styles in figma to make the heading tags more visible

Currently our heading tags naming format is too long for the developers to see (green highlight)

Once #543 is complete ,please go to the Figma file and update the heading styles.

I think you will find that there isn't a great way to handle this in Figma. The current naming for our typography is just (desktop or mobile)+(Type style) =  eg. "Desktop/Header 1".
When it is brought in from an external library (the guidelines design library) it adds DIO Typography to the front of the name.

Not solvable in Figma


Update mobile-developer-setup.rst

Hey,
as mentioned in the native mobile apps channel.
Please read to verify: https://github.com/fastlane/fastlane/issues/3920
read: biolinh commented on 7 Apr 2016
worked for me to solve my issue.

No need for another PR just make the changes into this one and the push the commit :)

@CoolMoeDee,
Thanks for the PR 👍  Could you rebase and we'll get it through PM review :)
Thanks!


Add Triple Point Shock Problem as Euler Application

Adds an additional example under applications/clawpack/euler/2d/triple. This runs the triple point shock problem as outlined here. The implementation has been verified.

I failed to add the regression test files, I added them in the latest commit.

The only test that fails is the CMake build on MacOS. It fails when running the regression test for triple. It looks like it fails when trying to write an output file:
...
[fclaw] Output Frame    2  at time   2.00000000e-01

[libsc 1] Caught signal SEGV
[libsc 1] Abort: Obtained 7 stack frames
[libsc 1] Stack 0: 0   triple                              0x0000000102364e18 sc_abort_handler + 56
[libsc 1] Stack 1: 1   ???                                 0x00007ffeed9946b0 0x0 +<PHONE_NUMBER>66032
[libsc 1] Stack 2: 2   libmpi.40.dylib                     0x000000010253386c mca_fcoll_vulcan_file_write_all + 3297
[libsc 1] Stack 3: 3   libmpi.40.dylib                     0x000000010256d76d mca_io_ompio_file_write_all + 69
[libsc 1] Stack 4: 4   libmpi.40.dylib                     0x000000010249caf9 MPI_File_write_all + 196
[libsc 1] Stack 5: 5   triple                              0x00000001022a9e77 fclaw2d_vtk_write_field + 455
[libsc 1] Stack 6: 6   ???                                 0x0000005100000005 0x0 +<PHONE_NUMBER>81
--------------------------------------------------------------------------
MPI_ABORT was invoked on rank 1 in communicator MPI_COMM_WORLD
  Proc: [[12403,1],1]
  Errorcode: 1

NOTE: invoking MPI_ABORT causes Open MPI to kill all MPI processes.
You may or may not see output from other processes, depending on
exactly when Open MPI kills them.
--------------------------------------------------------------------------
...

I'll remove output for the regression tests to see if that fixes it.

Merged recent develop commits into feature-triple. Assuming they pass units tests, this feature will be ready to merge into develop.

Ready to merge!

I updated the Automake files for you. I'll let @donnaaboise look at this and merge.


[feature request] determine if an asset file is in use

description
In a huge project, there may be some verbose asset files that may be forgotten to be deleted. It's helpful for developers if the dev tool can find them.

#334 implements the basic analysis of asset importers with a new Vite server action assets:get-asset-importers.
However, the importers of the assets that are dynamic-import or lazy-load won't be detected until they are actually loaded.
Also, there needs to be a Vite client listener so that the importers in the AssetDetails can be updated immediately.
Furthermore, a full analysis of the whole project's asset utilization may be helpful for developers to manage their repository. ( But it seems difficult on the development step. )


AttributeError: 'Namespace' object has no attribute 'COCO_ROOT'

Hey guys! I got this issue:
Traceback (most recent call last):
File "test.py", line 102, in
test_voc()
File "test.py", line 92, in test_voc
testset = COCODetection(args.COCO_ROOT, 'trainval35k', None, COCOAnnotationTransform)
AttributeError: 'Namespace' object has no attribute 'COCO_ROOT'
Could you plz give me some advices how to fix it

FIX IT


Investivate AppLayout menu rendering issue on Chrome / Edge

See some investigation but right now it

Only affects Chrome (Safari, Firefox, Arc, and Brave seem unaffected).  Tested on version 121
Mostly only notable on Mac.  Windows has delay but renders
Seems to be a compositing issue when content overflows and a transitions exists.

So far tested on 2 Macs (M1 Max and M3 Max) and Windows desktop.

I believe this was fixed in Chromium 122 (ironically #269 was introduced in 122 but has a workaround)


feat: add setting/getting of config to console

https://github.com/user-attachments/assets/eadd9164-bff5-480a-86b2-0ef4c9873756

Veeeery cool!


Added logs

Hi sharjjeel -  I really do not understand this proposed submission.
Was the PR created in error?

yes, please disregard


implement web sockets on FE dashboard

socketIO send & receive

websocket on gamehistory. on response requery all data.


Infer type annotations

coverage: 75.141% (+0.02%) from 75.126% when pulling ca6b3520b3f68b8ce18e8a839e6defae04ccdd0a on jmcrawford45:PS-4534-pyannotate into dd27d7168438adbbcac303a93a9fe772dcd84197 on Netflix:master.


Accidentally deleted get_schema_urls() function, bringing it back.

Codecov Report

Merging #39 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   67.99%   67.98%   -0.02%
==========================================
  Files          31       31
  Lines        2684     2686       +2
==========================================
+ Hits         1825     1826       +1
- Misses        859      860       +1

Impacted Files
Coverage Δ

ingest/template/schema_template.py
83.05% <50%> (-0.38%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007d60f...5614562. Read the comment docs.


implemented search flow

I just tested it out,
can you add support for ignoring lower/upper case?
can you add a clear button (a X icon) on the right to clear search bar input when input is not null


Allow Exceptions to take std::string as input

Our Exception class currently only supports const char * for the error message:
https://github.com/cmu-db/terrier/blob/master/src/include/common/exception.h#L39-L40
But it is easier to construct error messages with std::string with embedded information. This is causing some people to explicitly convert std::string in their code:
https://github.com/cmu-db/terrier/pull/475/files#diff-b4603b98bf01929a9ba25807c768fe0bR213
We should just add a new constructor to Exception:
Exception(const ExceptionType type, const std::string &msg, const char *file, int line) :
      : Exception(type, msg.c_str(), file, line) {}

The only potential issue with this is that we may want to have non-dynamic error messages and therefore we should not be passing in a std::string

we may want to have non-dynamic error messages

Is there a way we can completely avoid dynamic error messages? If we are embedding information we would need that right?

This was resolved in #959


HTTPoison issue on any URL

I'm running Wallaby 0.19.2 on a Debian Jessie Docker container (hosted on Mac OS X) with Elixir 1.6. Whenever I do session |> visit(any URL whatsoever), I get the following error:
** (RuntimeError) Wallaby had an internal issue with HTTPoison
    (wallaby) lib/wallaby/httpclient.ex:32: Wallaby.HTTPClient.make_request/4
    (wallaby) lib/wallaby/phantom/driver.ex:151: anonymous fn/2 in Wallaby.Phantom.Driver.visit/2
    (wallaby) lib/wallaby/driver/log_checker.ex:6: Wallaby.Driver.LogChecker.check_logs!/2
    (wallaby) lib/wallaby/browser.ex:703: Wallaby.Browser.visit/2

HTTPoison seems to be retrieving the pages just fine, but I believe the problem is that Wallaby is attempting to decode the resulting HTML as if it were JSON (see https://github.com/keathley/wallaby/blob/v0.19.2/lib/wallaby/httpclient.ex#L54, where the first thing it does is run Poison.decode(body), which fails since the result isn't JSON). Help?

On reflection, I'm not sure I'm right about the JSON issue, since I suppose Wallaby would have to be making requests to the PhantomJS endpoint, not directly to the desired HTML page. But I definitely can't get Wallaby to visit any page successfully, even though those pages can successfully be seen by a client such as HTTPoison.

Oh, and I'm using PhantomJS 2.1.1 and setting QT_QPA_PLATFORM=offscreen as recommended here.

I think I was wrong about the root cause here:
> {status, %HTTPoison.Response{}} = HTTPoison.get session.url
> status
:ok
>  HTTPoison.post session.url, Poison.encode!(%{url: Endpoint.url})
{:error, %HTTPoison.Error{id: nil, reason: :timeout}}

So for some reason the session URL (that's the PhantomJS endpoint, right?) is timing out on POST but not on GET.

I think there was a twofold problem.

I was using the PhantomJS installation from jessie-backports, which doesn't appear to work with Wallaby. I switched to the NPM phantom-prebuilt package.
I was also setting QT_QPA_PLATFORM=offscreen as required for PhantomJS 2.1.3. Unfortunately, 2.1.1 (which both backports and the Node package use) don't work if I do that.

So...problem solved by switching to phantom-prebuilt and not setting QT_QPA_PLATFORM. Is it worth warning against the jessie-backports version of PhantomJS in the docs?

@marnen thanks for the investigation. It might be worth specifying what version of phantomjs we expect, yes :)

Not sure why this was closed, given that the docs were never updated...

If you would like to submit a PR that updates the docs then that would be great. Otherwise we're planning on moving to chrome as the default driver since phantom is deprecated so this problem will be lessened.

Oh, OK. If this is moot then I won’t bother, but I’ll try to add a sentence or two.


Padding now working in Sketch 49.2

This is an issue template.
Please fill in the relevant fields – whether this is a Feature request or a Bug report
Remove any sections that are not relevant to you.

Feature request / enhancement
(Please detail the request; any mockup examples are also helpful)

Bug report
Expected behavior:
Actual behavior:
(Please include a screenshot or screen recording if possible)
Steps to reproduce:
(Please attach a Sketch file if possible)

Changing the text doesnt automatically resize the group :(

1.un-install the plugin and quit sketch(not just close you need to quit it)
2.Reinstall the plugin
It worked for me afterward.

Yasss Now its working with Sketch 49.3! Thank You!


Hashicorp Vault Secret Store - To support cert. rotation and renewals

Enhance Hashicorp Vault Secret store to support password/ cert. renewals and publish the notification/ event when change takes place.

Hi,
Please consider a scenario when a microservice is connected to Hashicorp Vault using Dapr and a database. Hashicorp vault is managing the database credentials (Static role for this scenario) and Microservice is getting the credentials from Dapr (by Vault) and Creating a connection pool to connect to database using the credentials and performs the operation.
Suppose there is a password rotation happens by vault and database password got changed and vault also rotates its credentials.
This scenario won't affect Microservice for the new connection pool creation as it will fetch the credentials from Vault. However the Old pool will still in the active state with old credentials so it will try to create new connection and get the exception as credentials are old and not updated.
There is a need of some mechanism to inform the microservice to nullify the pool / pool credentials on the password rotation at database through Vault. i.e. If there is an updation of the password / Lease at Vault then Dapr should trigger some event back to microservice and inform as there is an update of password / lease happened at Vault & database so Microservice can also refresh / nullify the current connection pool.

Tagged for 1.10

Tagged for 1.10

We do not tie certification efforts to a particular milestone. Also, certifying this component for GA does not require certificate renewals. These are two separate things.

/assignee

👋

The Certification of Hashicorp to stable is being handled by other issue, this will be targeted to enable the Hashicorp vault supporting cert. / password renewals and publishing an event when renewal takes place.

The Certification of Hashicorp to stable is being handled by other issue, this will be targeted to enable the Hashicorp vault supporting cert. / password renewals and publishing an event when renewal takes place.
@mukundansundar - can you help update the issue description to - Feature request to support password/ cert. renewals and publish the notification/ event when change takes place in Hashicorp vault secret store.

Done

//comment

//comment


[DRAFT] Beam 2.16.0 release Blog post

Beam 2.16.0 release Blog post.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---

---
---

Java

Python

---

---
---

XLang
---
---
---

---
---
---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

+cc: @aaltay @kennknowles @tvalentyn

Please ignore my second set of comments. Github, somehow resent my previous comments.

PTAL @aaltay @angoenka @ibzib


Switch to dark mode feature

@Vin205
please assign me this under GSsoc-ext, hacktoberfest, & level -1,2,3

@Ishika-Gupta06 what type of issue it is, give brief  about it like some screenshot or img!

@Vin205 user can easily toggle to dark mode upon one click

@Ishika-Gupta06 assigned!


ARTEMIS-488 Fix OpenWire Test (Temp Queue removal and others)

Temp Queue not deleted when connection is closed.
Enable Stomp in openwire test because some test uses it.
Remove unused code in opwnwire
Wrong XA error code returned when xid is missing
(ActiveMQXAConnectionFactory.testRollbackXaErrorCode)
regression in ActiveMQSslConnectionFactoryTest (SSL related)

Howard,
You can't simply duplicate functionality that is already available on the Broker.
ServerSessionImpl, which is used by OpenWireConnection already has controller for temporary queues. Why we can't simply use the TemporaryQueues from The ServerSession?
I don't want to keep adding copy & paste inheritance on the openwire protocol head. if something on the broker is not working as expected I would rather change with parameter to adapt any semantics than copy & paste and duplicate functionality just to fix tests.

The proper change for the Temporary Queue would be to call internalSession.createQueue instead of duplicating the createQueue control through the protocol head.
So, that makes it two changes to the PR:
i - adapt the create queue, and make sure the ServerSession close is called when things happens (I think it is).
ii - change the routing to add a new overloaded method to be used by OpenWire instead of queueQuery on every message. (if that even is required... we need to check if that's really needed... because if the temp queue was deleted.. it simply means we don't need to bother.. just relax the test).
You may ping me before you do these changes.

Thanks clebert. I think you are right. There is an internal core session that can be used to created queues. I'm going to try use that. I'll think of how to improve the check queue deletion code.

Hi Clebert, Just updated my branch with new changes. I'm adding a return value to session.send(), which is a enum called SendResult to help check the temp queues.
Please review the code when you have time.
Thanks

This is much better....
I'm not sure I like the SendResult. I would rather add a parameter to have the send throwing an error if no bindings. Much simpler change.

Ok, I like the SendResult idea after all. With just a few modifications to make it really cool and a consistent API.

Rename SendResult as RoutingStatus (or find a better name, being part of Routing)

Move it under org.apache.activemq.artemis.core.postoffice

The enum constants should be. (No need to set any prefix on them).
OK, NO_BINDINGS, NO_BINDINGS_DLA, DUPLICATED_ID

Notice that there's no need for SEND_NO_DLA API wise.. just make it NO_BINDINGS.

Also, make all the PostOffice::route operations to return RoutingStatus. to make the API clean.

I'll do the changes. Thanks Clebert.

done.

hmm, some test failures. looks like not related to my changes...

@clebertsuconic can you ack the changes please.

@howardgao Just looking at this, wanted just to say it's usually good practice to keep the commits within reasonably small scope.  This makes it easier to understand what the code changes are trying to achieve, for review or when looking at the history.  It looks like you're fixing about 5 issues in one huge commit here, would probably be best to have 1 commit per issue/fix.

@mtaylor you are right. At first I thought those are very small fixes so it doesn't matter if I make one commit. But it turns out to have evolved into a big commit.
@clebertsuconic how about I split it into two commit?

The ProtocolManagerFactory still present on your PR.
I'm going to remove it myself during the merge. Please review it after merge

lets do it for next PRs.
The idea is that you keep concentrate within issues.. but you still rebase and squash accordingly.
I usually have lots of small committs on my branch and then I squash them accordingly to atomic issues before PR.
An example of a previous PR I worked on:
https://github.com/apache/activemq-artemis/pull/463


Fix parsing relative references to other files

This sets the $id attribute to the absolute file URI if it is not already set,
so that a base URI is available and the existing code for resolving references
can be used.

I took the simplest possible approach I could find here, instead of changing a lot of things to be able to pass the original URI along with the documents through all the layers of code.
I'm not sure how to fit this into the existing test suite, though.  The cli tests mock everything, and the standard json-schema test suite (unfortunately, and hopefully just for now) does not contain any tests for this.  Suggestions on how this should be tested welcome.

Hi, thanks!
Maybe a good start would be if you could show a reproducing example?
Definitely appreciated!

It turns out that this approach doesn't work because it can break "strict" schemas with additionalProperties: false, but I ended up writing my own command line script to get around other issues, that uses an appropriately configured RefResolver as mentioned in some other issues.
I still think it would be nice if the stock jsonschema script supported this correctly, though, so I'll try to come up with a simple example and/or a test and tinker some more with implementing it.

Thanks! Yeah I'm happy to merge improvements, the rub so far has been making sure to have simple test cases to merge alongside the improvement.

Closing this, though definitely happy to discuss if you can show some concrete examples we can work on!


bgfx vertex decl replaced by vertex layout

bgfx update introduces vertexDecl to be replaced by vertexLayout
bgfx.cmake PRs that need to be merged at the same time
https://github.com/BabylonJS/bgfx.cmake/pull/2
upstream PR:
https://github.com/JoshuaBrookover/bgfx.cmake/pull/64
Not sure it will be merged quickly in upstream so I did one on our own bgfx.cmake repo.

Merging as I want to test it with my next Mac PR


[Removal]: Oblong Cherry Shetland

Hotspot Name
Oblong Cherry Shetland
Hotspot b58 Address
11roxPBopnEWJdCq4xj8C2yVKaPzkcQXqMgu9cdQxa6xq8P9CEC
Discord Handle
Borislav95#6522
Hotspot Manufacturer
Bobcat
Removal Reason
This hotspot was bulk added to the denylist along with the whole town,
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
I'm the owner of Oblong Cherry Shetland, located in Ihtiman, Bulgaria. I noticed the whole town was included in the denylist. Although there might be users that are farming with multiple hotspots, mine is legit and located in the town as you can see from my beacons & witnesses.
My hotspot is regular Bobcat and never have been modified in any way.
I have been a victim of a malfunctioning software algorithm and the assumption that the hotspots in Ihtiman are not real and your bot is concluding that they are farming which is not true.
Best Regards,

I have been banned again for the second time. Old issue is Issue: 95

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


q/a | setting time in tests

Expected Behavior
When writing expressions that use feel functions like now(), we want to write tests against this date logic. Additionally, even if we trust that now works as expected, we still may want to test the entire decision flow and if it depends on now() then we need to do something about it.
Actual Behavior
In the generated Java object that holds the feel expression, we see that the generated drg element eventually delegates to now() in a super class which contains dateTimeLib for instance. We don't see an opportunity control the clock in a unit test environment.
jDMN Version where this issue was observed
<jdmn.version>8.2.3</jdmn.version>
We are using the Java generator.
Workaround
Right now we supply our own currentDateTime input variable.
Question
Is there support for this kind of testing?

The testing of usage of now() and today() can be done by mocking using either stubs or existing mock frameworks.
I hope this helps,

Is there an example used in jdmn? Not sure how we can supply a stub or mock with how the datetimelib is encapsulated.

You can create a new class that extends the decision that invokes the today() / now() and override the today() or now() method to return the value you want to test.

Gotcha, yeah gets past the immediate use case.
What are your thought on providing a clock to the EvaluationContext? We can subclass, but then we need to remember to override today or now on every intermediate decision object.


Add separate "Home Z axis" option

Hi, I have been using CncGcodeController for a while now (very convenient software, thanks!) and I am missing separate homing options.
In my current setup, when pressing "Homing" thr XY axes travel to zero and then Z goes down until I manually make contact with the probe wires. How does this differ from your Marlin configuration?
I wanted to ask for a new feature, to split the homing button into "Home XY" and "Home Z". That way it would be possible to zero the height in a more controlled manner without having to manually stop Z homing and later type G28 Z0 in the console.

A pull request is in the queue right now with a simple pronter face like user interface that allows nearly the same things as pronterface except the mangement of heating elements of course.
So home separately X, Y and Z is possible as well as XY and XYZ at once.

managed by PR https://github.com/pknoe3lh/cncgcodecontroller/commit/6018c81f5da4e045df3ca587e1cd8abfd9aa948d we may close this item

added in 5.0


Hotfix build 0.xx.5

Description
Hello
Android builds (on most recent versions > 0.63) have been impacted by build issues due to dependency repository failure (jcenter) and the way the alternative repository handles dependencies version works (mavenCentral).
Hotfix versions have been made available on the main react-native repo with the tag number 0.xx.5, and an issue explaining the whole situation is available here.
The app i'm working on has a tv and a mobile version, the hotfix fixed this build issue on the mobile app, but i can’t do the same on the tv app because the react-native version is tied to this repository
I cannot upgrade the react-native version to the 0.71.X that looks like it'll embark config changes to not encounter the issue again.
Would it be possible to release hotfix equivalent on this package following the previously established version model (0.XX.5-0) ?
Version
0.66.3
Output of npx react-native info
System:
OS: Linux 5.15 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
CPU: (8) x64 Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
Memory: 7.05 GB / 15.33 GB
Shell: 5.8.1 - /usr/bin/zsh
Binaries:
Node: 16.14.0 - ~/.nvm/versions/node/v16.14.0/bin/node
Yarn: 1.22.18 - /usr/bin/yarn
npm: 8.3.1 - ~/.nvm/versions/node/v16.14.0/bin/npm
Watchman: Not Found
SDKs:
Android SDK:
API Levels: 28, 30, 31, 32, 33
Build Tools: 29.0.2, 30.0.2, 30.0.3, 31.0.0, 32.0.0, 32.1.0
System Images: android-28 | Android TV Intel x86 Atom, android-28 | Wear OS Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-29 | Google APIs Intel x86 Atom, android-30 | Google TV Intel x86 Atom, android-30 | Google APIs Intel x86 Atom, android-31 | Google APIs Intel x86 Atom_64, android-33 | Google APIs Intel x86 Atom_64, android-33 | Google Play Intel x86 Atom_64
Android NDK: Not Found
IDEs:
Android Studio: Not Found
Languages:
Java: 11.0.16 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: Not Found
react-native: Not Found
react-native-tvos:  0.66.3-1
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
Try to create/run an android build
react-native run-android
Snack, code example, screenshot, or link to a repository
No response

You can patch it yourself for now if you don't want to upgrade as described in https://github.com/react-native-tvos/react-native-tvos/issues/386

It works, thanks for the link !
If anybody needs it, i changed the following in our android/buiid.gradle file
From
allprojects {
  repositories {
	def REPOSITORY_URL = "https://repo1.maven.org/maven2"
    	all { ArtifactRepository repo ->
      	if(repo instanceof MavenArtifactRepository){
        	def url = repo.url.toString()
          if (url.startsWith('https://jcenter.bintray.com/')) {
          	project.logger.lifecycle "Repository ${repo.url} replaced by $REPOSITORY_URL."
            remove repo
          }
        }
      }

	google()
	mavenCentral()
	mavenLocal()
	maven {
		url REPOSITORY_URL
	}
	maven {
		// All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
		url("$rootDir/../node_modules/react-native/android")
	}
	maven {
		// Android JSC is installed from npm
		url("$rootDir/../node_modules/jsc-android/dist")
	}
	maven {
		url 'https://bitmovin.bintray.com/maven'
	}
	maven { url 'https://jitpack.io' }
    }
}

To
allprojects {
  repositories {
		// https://github.com/facebook/react-native/issues/35210
		exclusiveContent {
			// We get React Native's Android binaries exclusively through npm,
			// from a local Maven repo inside node_modules/react-native/.
			// (The use of exclusiveContent prevents looking elsewhere like Maven Central
			// and potentially getting a wrong version.)
			filter {
				includeGroup "com.facebook.react"
			}
			forRepository {
				maven {
					// NOTE: if you are in a monorepo, you may have "$rootDir/../../../node_modules/react-native/android"
					url "$rootDir/../node_modules/react-native/android"
				}
			}
		}
		google()
		mavenCentral()
		mavenLocal()
		maven {
			// All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
			url("$rootDir/../node_modules/react-native/android")
		}
		maven {
			// Android JSC is installed from npm
			url("$rootDir/../node_modules/jsc-android/dist")
		}
		maven {
			url 'https://bitmovin.bintray.com/maven'
		}
		maven { url 'https://jitpack.io' }
	}
}


More output from cmake

Hi,
would it be possible to have more output from autocmake (through verbose flag) ? I am used to the DIRAC cmake output, containing compiler flags, compiler versions, extra libraries...
milias@login.grid.umb.sk:~/Work/qch/software/software_projects/autocmake_devel/autocmake/test/fc_blas/.python setup.py --fc=gfortran --blas=auto
FC=gfortran cmake -DEXTRA_FCFLAGS="''" -DENABLE_64BIT_INTEGERS=False -DENABLE_BLAS=auto -DENABLE_LAPACK=auto -DMKL_FLAG=off -DMATH_LIB_SEARCH_ORDER="MKL;ESSL;ATLAS;ACML;SYSTEM_NATIVE" -DBLAS_LANG=Fortran -DLAPACK_LANG=Fortran -DCMAKE_BUILD_TYPE=release -G "Unix Makefiles" None /home/milias/Work/qch/software/software_projects/autocmake_devel/autocmake/test/fc_blas

-- The C compiler identification is GNU 4.4.7
-- The CXX compiler identification is GNU 4.4.7
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- The Fortran compiler identification is GNU
-- Check for working Fortran compiler: /usr/bin/gfortran
-- Check for working Fortran compiler: /usr/bin/gfortran  -- works
-- Detecting Fortran compiler ABI info
-- Detecting Fortran compiler ABI info - done
-- Checking whether /usr/bin/gfortran supports Fortran 90
-- Checking whether /usr/bin/gfortran supports Fortran 90 -- yes
-- BLAS will be searched for based on MKLROOT=/mnt/apps/intel/composer_xe_2013_sp1.1.106/mkl
-- Searching for BLAS using search order MKL;ESSL;ATLAS;ACML;SYSTEM_NATIVE
-- Found BLAS: MKL (-Wl,--start-group;/mnt/apps/intel/composer_xe_2013_sp1.1.106/mkl/lib/intel64/libmkl_gf_lp64.so;/mnt/apps/intel/composer_xe_2013_sp1.1.106/mkl/lib/intel64/libmkl_gnu_thread.so;/mnt/apps/intel/composer_xe_2013_sp1.1.106/mkl/lib/intel64/libmkl_core.so;/usr/lib64/libpthread.so;/usr/lib64/libm.so;-fopenmp;-Wl,--end-group)
-- LAPACK will be searched for based on MKLROOT=/mnt/apps/intel/composer_xe_2013_sp1.1.106/mkl
-- Searching for LAPACK using search order MKL;ESSL;ATLAS;ACML;SYSTEM_NATIVE
-- Found LAPACK: MKL (-Wl,--start-group;/mnt/apps/intel/composer_xe_2013_sp1.1.106/mkl/lib/intel64/libmkl_lapack95_lp64.a;/mnt/apps/intel/composer_xe_2013_sp1.1.106/mkl/lib/intel64/libmkl_gf_lp64.so;-fopenmp;-Wl,--end-group)
-- Configuring done
-- Generating done
-- Build files have been written to: /home/milias/Work/qch/software/software_projects/autocmake_devel/autocmake/test/fc_blas/build

   configure step is done
   now you need to compile the sources:
   $ cd build
   $ make
milias@login.grid.umb.sk:~/Work/qch/software/software_projects/autocmake_devel/autocmake/test/fc_blas/.

It is definitely possible. But the question is probably whether this should be provided by default
and this I don't know yet. Everything that is on by default has to work for "all" possible projects.
I suggest you start coding a module that does that and if it turns out general enough we include it in the standard set of modules.

http://autocmake.readthedocs.org/en/latest/developers/faq.html#autocmake-does-not-do-feature-x-i-really-need-feature-x-and-a-setup-py-flag-x

I tried to emulate config_info output based on git_info output, but plenty of variables are undefined in the simplest test case (I modified fc).
So I leaving this issue. Probably good printout can be in done in own cmake module.
milias@login.grid.umb.sk:~/Work/qch/software/software_projects/autocmake_devel/autocmake_miroi/test/fc/build-20
15-08-03-19-48-21/.m
[ 25%] Generating config_info.h
-- Who compiled             :
-- Host                     :
-- Who compiled             :
-- Host                     :
-- System name              :
-- System                   :
-- CMake version            : <IP_ADDRESS>
-- CMake generator          :
-- Python version           :
-- Processor                :
-- Fortran compiler         :
-- Fortran compiler version :
-- Fortran compiler flags   :
-- C compiler               :
-- C compiler version       :
-- C compiler flags         :
-- CMAKE_ARGC=4
-- CMAKE_ARGV0=/usr/bin/cmake
-- CMAKE_ARGV1=-D_target_dir=/home/milias/Work/qch/software/software_projects/autocmake_devel/autocmake_miroi/test/fc/build-2015-08-03-19-48-21
-- CMAKE_ARGV2=-P
-- CMAKE_ARGV3=config_info_sub.cmake
-- CMAKE_BINARY_DIR=/home/milias/Work/qch/software/software_projects/autocmake_devel/autocmake_miroi/modules/config_info
-- CMAKE_COMMAND=/usr/bin/cmake
-- CMAKE_CPACK_COMMAND=/usr/bin/cpack
-- CMAKE_CTEST_COMMAND=/usr/bin/ctest
-- CMAKE_CURRENT_BINARY_DIR=/home/milias/Work/qch/software/software_projects/autocmake_devel/autocmake_miroi/modules/config_info
-- CMAKE_CURRENT_LIST_DIR=/home/milias/Work/qch/software/software_projects/autocmake_devel/autocmake_miroi/modules/config_info
-- CMAKE_CURRENT_LIST_FILE=/home/milias/Work/qch/software/software_projects/autocmake_devel/autocmake_miroi/modules/config_info/config_info_sub.cmake
-- CMAKE_CURRENT_SOURCE_DIR=/home/milias/Work/qch/software/software_projects/autocmake_devel/autocmake_miroi/modules/config_info
-- CMAKE_EDIT_COMMAND=/usr/bin/ccmake
-- CMAKE_FILES_DIRECTORY=/CMakeFiles
-- CMAKE_HOST_UNIX=1
-- CMAKE_MAJOR_VERSION=2
-- CMAKE_MINOR_VERSION=8
-- CMAKE_PATCH_VERSION=12
-- CMAKE_ROOT=/usr/share/cmake-2.8
-- CMAKE_SCRIPT_MODE_FILE=/home/milias/Work/qch/software/software_projects/autocmake_devel/autocmake_miroi/modules/config_info/config_info_sub.cmake
-- CMAKE_SOURCE_DIR=/home/milias/Work/qch/software/software_projects/autocmake_devel/autocmake_miroi/modules/config_info
-- CMAKE_TWEAK_VERSION=2
-- CMAKE_VERSION=<IP_ADDRESS>
-- UNIX=1
-- _target_dir=/home/milias/Work/qch/software/software_projects/autocmake_devel/autocmake_miroi/test/fc/build-2015-08-03-19-48-21
[ 25%] Built target config_info
[ 50%] Generating git_info.h
-- Found Git: /usr/bin/git (found version "1.7.1")
[ 50%] Built target git_info
[ 75%] Building Fortran object src/CMakeFiles/example.dir/module.f90.o
make[2]: Warning: File `src/CMakeFiles/example.dir/module.f90.o.provides.build' has modification time 25 s in the future
[100%] Building Fortran object src/CMakeFiles/example.dir/example.f90.o
Warning: /home/milias/Work/qch/software/software_projects/autocmake_devel/autocmake_miroi/test/fc/src/example.f90:5: Illegal preprocessor directive
Warning: /home/milias/Work/qch/software/software_projects/autocmake_devel/autocmake_miroi/test/fc/src/example.f90:6: Illegal preprocessor directive
Linking Fortran executable ../bin/example
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
[100%] Built target example

A warning about dealing with build info using header files. Sounds like a perfect idea and I have tried
it myself but this will most probably fail on Fortran due to the line limit. This needs extra care and extra scripts that chop or truncate strings. Alternatively it requires Fortran calling C which includes the header file.


Add a feature to override file extension defining compression

Title
Add a feature to override file extension defining compression.
Motivation
- Implements #607

Tests
Added test_smart_open.S3OpenTest.test_rw_gzip_override and verified it fails as follows without the feature:
FAILED smart_open/tests/test_smart_open.py::S3OpenTest::test_rw_gzip_override  - OSError: Not a gzipped file...

Full test suite run output:
...
=============================================== short test summary info ===============================================
SKIPPED [1] smart_open/tests/test_package.py:18: requires missing dependencies
SKIPPED [1] smart_open/tests/test_package.py:13: requires missing dependencies
SKIPPED [1] smart_open/tests/test_package.py:24: requires missing dependencies
============================ 369 passed, 3 skipped, 7 warnings in 41.56s ==============================================

Checklist
Before you create the PR, please make sure you have:

[X] Picked a concise, informative and complete title
[X] Clearly explained the motivation behind the PR
[X] Linked to any existing issues that your PR will be solving
[X] Included tests for any new functionality
[X] Checked that all unit tests pass

As you mentioned, something that's backwards compatible will require a major release. If that's not on the horizon, what is the objection to "yet another parameter", if is backwards-compatible?

It's more about cost-benefit than protection. For this PR, the cost is effort in reviewing, merging, documenting, explaining it to users, maintaining it and then eventually deprecating it once a proper solution is implemented. The benefit is immediately solving a problem that affects few people and does not strictly require immediate attention. It's simply not worth it.
I'd much rather invest that effort elsewhere, for example, into thinking of a proper way to solve the problem in #607.


Added configurable max cost and update

Added the possibility to change the maximum cost with a config.yml file and update to spigot API 1.18.2 and ProtocolLib 4.8.0

Guava is provided by Spigot and does not need to be included in the
dependency list. Also, this plugin doesn't use it.
Copy/paste my pom.xml. I forgot to remove it
Would prefer this to be inside the if statement - that way we aren't
pulling a config value every time any inventory opens. It's a small
optimization for sure, but an easy one.
Ok
Does this actually work? I imagine we need to toggle faked gamemode
post-PrepareAnvilEvent state so that we're displaying "Too Expensive!" when
the result is too expensive. The result should be denied, but does the
client understand that? I imagine it will create some desync issues.
Yes it works. I tested it. One thing i wanted to do in my plugin is check
if the cost is over the limit setted in the config file and not calling
your method. So it will display !Too expensive!" I didn't succeed to import
the variable from my class to yours.

   <repository>

       <id>sonatype</id>

https://oss.sonatype.org/content/groups/public/
Unnecessary repo.
By default the Minecraft plugin in IntelliJ add this repo. I don't know why
if it's not needed...

-api-version: "1.15"
+api-version: "1.18"
This forces the users of the plugin to be running 1.18 when it can still
run just fine on the version it was originally written against - the packet
format has not changed. I get that 1.18 is the majority market share, but I
don't see a reason to break backwards compatibility in this case. This is
also why I didn't bother updating dependencies.
I don't think it does... I'll check right after sending you this email but
i think even if you use the 1.18 API you still can use the plugin with 1.14
for example. The java version is différent i think. You have to use at
least the version in the plugin. That's why most people keep using 1.8 for
java 8
Le sam. 23 avr. 2022 à 08:40, Adam @.***> a écrit :

@.**** commented on this pull request.
In src/main/resources/plugin.yml
https://github.com/Jikoo/AnvilUnlocker/pull/1#discussion_r856888334:

@@ -1,6 +1,6 @@
name: ${project.name}
main: ${project.groupId}.${project.artifactId}.${project.name}
version: ${project.version}
-api-version: "1.15"
+api-version: "1.18"

I guess we may as well update and go with recent Java constructs though,
it'll clean up the code a touch.
—
Reply to this email directly, view it on GitHub
https://github.com/Jikoo/AnvilUnlocker/pull/1#discussion_r856888334, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AM3JBWGVM7TKI5SNFTLA5ADVGPVSFANCNFSM5UD3TOCQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Manuel Vézina
581 999 6265

Made all the changes I requested 👍

Yes it works. I tested it. One thing i wanted to do in my plugin is check if the cost is over the limit setted in the config file and not calling your method

Specifically, if the maximumCost is set to 45 and the cost is 50 it will display "Too Expensive!"? I didn't think the creative client was capable of that - last I was aware the max cost is never communicated to the client. If that is the case we could revert the changes I added in fff63ef35f and reduce load by not sending as many packets and not using the scheduler.

Sorry, missed some of your replies due to the editor fold, GitHub's email reply system appears to have quoted the entire end section by accident.

This forces the users of the plugin to be running 1.18 when it can still run just fine on the version it was originally written against - the packet format has not changed. I get that 1.18 is the majority market share, but I don't see a reason to break backwards compatibility in this case. This is also why I didn't bother updating dependencies.

I don't think it does... I'll check right after sending you this email but i think even if you use the 1.18 API you still can use the plugin with 1.14 for example. The java version is différent i think. You have to use at least the version in the plugin. That's why most people keep using 1.8 for java 8

Unfortunately, no, that's not how it works. api-version was introduced in 1.13, so versions before that do not support it. However, versions later than that will not load plugins that depend on a newer api-version. They will throw an InvalidPluginException.
Version check is done on load: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/browse/src/main/java/org/bukkit/plugin/java/JavaPluginLoader.java?until=f8b2086d60942eb2cd7ac25a2a1408cb790c222c&untilPath=src%2Fmain%2Fjava%2Forg%2Fbukkit%2Fplugin%2Fjava%2FJavaPluginLoader.java#125
Actual internal version handling is inside CraftMagicNumbers:
https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/browse/src/main/java/org/bukkit/craftbukkit/util/CraftMagicNumbers.java?until=86292d3e084729f53ce77af17b7b20d91754b7a5&untilPath=src%2Fmain%2Fjava%2Forg%2Fbukkit%2Fcraftbukkit%2Futil%2FCraftMagicNumbers.java#309
If you look at the constants specified above, you can see exactly which version strings are legal.
Java version is not exactly related, but certain guarantees can be made. Ex: in 1.11, Mojang released Minecraft compiled against Java 8, which meant that anyone using 1.11 and higher is guaranteed to be using over Java 8. They then upgraded to Java 16 with 1.17 and again to Java 17 with 1.18. By using api-version: "1.18" we guarantee it is okay to compile using Java 17, because the plugin won't enable on earlier servers anyway.


Fix site landing page for mobile

#3165 put the "Why kpt" and "Get started" buttons next to the embedded video. It looks better on my laptop.
However, on my Android phone, the buttons are squeezed off the page, with just "Why" and "Get" appearing at the edge.
We probably need to play with the layout more. For example:
K          text
buttons video
or
K  buttons
text
video
cc @yuwenma

Approved on https://responsivedesignchecker.com/checker.php?url=https%3A%2F%2Fkpt.dev&width=375&height=667
The "Why kpt" and "Get Started" should fit into all listed computer, tablet and phones.
This is the Android pixel look


p5.sound setVvolume issue

From @dairbuirabass on April 28, 2017 19:29
After setting volume and calling play() in draw again, it resets volume to default (1.0).
I know there should be some ways of avoiding it, but still should it count as an issue?
Copied from original issue: processing/p5.js#1918

@dairbuirabass, it's hard to tell if it is really an issue from the elements you give. What are you trying to achieve exactly ?  and could you post a small example with code ?
Are you talking about the setVolume from the p5.SoundFile class : https://p5js.org/reference/#/p5.SoundFile/setVolume
or the masterVolume  : https://p5js.org/reference/#/p5.sound/masterVolume

Yes, I mean the SoundFile class, pardon.
So basically, when I initialize the SoundFile object
function preload()
{
	menu_music = loadSound('sounds/chinese_stock_car_dealer.ogg');
}

Then I set the volume
function setup()
{
	menu_music.setVolume(0.1);
}

And there is no effect neither if I play it right away in setup, nor if I loop it in draw.
I guess it is just me not handling functions correctly, but just in case.

duplicate of https://github.com/processing/p5.js-sound/issues/182 and I'll close this one as https://github.com/processing/p5.js-sound/issues/182 has some more discussion and seems close to a solution

@therewasaguy Thanks


[Draft][Work in Progress] Add pet2bids to ezbids

Adding PET2BIDS to handler so that if PET dicoms are found it runs dcm2niix4pet instead of dcm2niix for those files.

This a draft only at this time, getting failures when I drop PET dicoms into ezBIDS, but not 100% sure where things are going sideways (as is the way with working in a VM).
Currently getting this sort of output:
ezbids-handler-1  | 0|handler  | + echo 'replace file path that contains space'
ezbids-handler-1  | 0|handler  | + find /tmp/ezbids-workdir/6425a7a05f58323ab6d76491 -depth -name '*[ ()]*' -execdir rename 's/[ )]/_/g; s/\(//g' '{}' ';'
ezbids-handler-1  | 0|handler  | replace file path that contains space
ezbids-handler-1  | 0|handler  | + echo 'Making sure all NIfTI files are in .nii.gz format'
ezbids-handler-1  | 0|handler  | + touch /tmp/ezbids-workdir/6425a7a05f58323ab6d76491/nii_files
ezbids-handler-1  | 0|handler  | Making sure all NIfTI files are in .nii.gz format
ezbids-handler-1  | 0|handler  | + find /tmp/ezbids-workdir/6425a7a05f58323ab6d76491 -name '*.nii'
ezbids-handler-1  | 0|handler  | + '[' -s /tmp/ezbids-workdir/6425a7a05f58323ab6d76491/nii_files ']'
ezbids-handler-1  | 0|handler  | + echo 'processing /tmp/ezbids-workdir/6425a7a05f58323ab6d76491'
ezbids-handler-1  | 0|handler  | + echo 'finding dicom directories'
ezbids-handler-1  | 0|handler  | + ./find_dicomdir.py /tmp/ezbids-workdir/6425a7a05f58323ab6d76491
ezbids-handler-1  | 0|handler  | processing /tmp/ezbids-workdir/6425a7a05f58323ab6d76491
ezbids-handler-1  | 0|handler  | finding dicom directories
ezbids-handler-1  | 0|handler  | + cat /tmp/ezbids-workdir/6425a7a05f58323ab6d76491/dcm2niix.list
ezbids-handler-1  | 0|handler  | ./CPSInnovationsHRRT-NIMH
ezbids-handler-1  | 0|handler  | ++ which dcm2niix4pet
ezbids-handler-1  | 0|handler  | ++ echo 0
ezbids-handler-1  | 0|handler  | + PET2BIDS_INSTALLED=0
ezbids-handler-1  | 0|handler  | + '[' 0 -eq 0 ']'
ezbids-handler-1  | 0|handler  | + echo 'PET2BIDS is installed, using dcm2niix4pet for PET directories found in root dir /tmp/ezbids-workdir/6425a7a05f58323ab6d76491'
ezbids-handler-1  | 0|handler  | + export -f rundcm2niix4pet
ezbids-handler-1  | 0|handler  | + ./find_petdir.py /tmp/ezbids-workdir/6425a7a05f58323ab6d76491
ezbids-handler-1  | 0|handler  | PET2BIDS is installed, using dcm2niix4pet for PET directories found in root dir /tmp/ezbids-workdir/6425a7a05f58323ab6d76491
ezbids-api-1      | 0|ezbids  | Mongoose: sessions.findOne({ _id: new ObjectId("6425a7a05f58323ab6d76491") }, { projection: {} })
ezbids-handler-1  | 0|handler  | checking dcm2niix progress--------------------------
ezbids-handler-1  | 0|handler  | Mongoose: sessions.updateOne({ _id: new ObjectId("6425a7a05f58323ab6d76491") }, { '$set': { status_msg: 'PET2BIDS is installed, using dcm2niix4pet for PET directories found in root dir /tmp/ezbids-workdir/6425a7a05f58323ab6d76491', dicomCount: 2, update_date: new Date("Thu, 30 Mar 2023 15:15:53 GMT") }}, { session: null })
ezbids-api-1      | 0|ezbids  | Mongoose: sessions.findOne({ _id: new ObjectId("6425a7a05f58323ab6d76491") }, { projection: {} })
ezbids-mongodb-1  | {"t":{"$date":"2023-03-30T15:15:54.619+00:00"},"s":"I",  "c":"NETWORK",  "id":22943,   "ctx":"listener","msg":"Connection accepted","attr":{"remote":"<IP_ADDRESS>:42082","connectionId":145,"connectionCount":10}}
ezbids-mongodb-1  | {"t":{"$date":"2023-03-30T15:15:54.623+00:00"},"s":"I",  "c":"NETWORK",  "id":51800,   "ctx":"conn145","msg":"client metadata","attr":{"remote":"<IP_ADDRESS>:42082","client":"conn145","doc":{"application":{"name":"MongoDB Shell"},"driver":{"name":"MongoDB Internal Client","version":"4.4.15"},"os":{"type":"Linux","name":"Ubuntu","architecture":"x86_64","version":"20.04"}}}}
ezbids-mongodb-1  | {"t":{"$date":"2023-03-30T15:15:54.714+00:00"},"s":"I",  "c":"NETWORK",  "id":22944,   "ctx":"conn145","msg":"Connection ended","attr":{"remote":"<IP_ADDRESS>:42082","connectionId":145,"connectionCount":9}}
ezbids-handler-1  | 0|handler  | + echo 'Found PET directories:'
ezbids-handler-1  | 0|handler  | + cat /tmp/ezbids-workdir/6425a7a05f58323ab6d76491/pet2bids.list
ezbids-handler-1  | 0|handler  | Found PET directories:
ezbids-handler-1  | 0|handler  | ./CPSInnovationsHRRT-NIMH
ezbids-handler-1  | 0|handler  | + echo 'Removing PET directories from dcm2niix list'
ezbids-handler-1  | 0|handler  | + grep -v -x -f /dev/fd/63 /dev/fd/62
ezbids-handler-1  | 0|handler  | Removing PET directories from dcm2niix list

Ehhhh....

Oh, this is new:
Line 1566 in ezBIDS_core.py:
uploaded_json_list = pd.read_csv("list", header=None, sep="\n").to_numpy().flatten().tolist()

### is throwing this error:
Traceback (most recent call last):
  File "./ezBIDS_core/ezBIDS_core.py", line 1566, in <module>
    uploaded_json_list = pd.read_csv("list", header=None, sep="\n").to_numpy().flatten().tolist()
  File "/usr/local/lib/python3.8/dist-packages/pandas/util/_decorators.py", line 211, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/pandas/util/_decorators.py", line 331, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/pandas/io/parsers/readers.py", line 935, in read_csv
    kwds_defaults = _refine_defaults_read(
  File "/usr/local/lib/python3.8/dist-packages/pandas/io/parsers/readers.py", line 2063, in _refine_defaults_read
    raise ValueError(
ValueError: Specified \n as separator or delimiter. This forces the python engine which does not accept a line terminator. Hence it is not allowed to use the line terminator as separator.

list.txt
attached is list file in question.

@bendhouseart is your python error occurring on your dev instance? I'm unable to reproduce the error on my dev instance or production itself, though I can produce the error on my local python installation. Regardless, using lineterminator will fix your issue: uploaded_json_list = pd.read_csv("list", header=None, lineterminator="\n").to_numpy().flatten().tolist()

@bendhouseart is your python error occurring on your dev instance? I'm unable to reproduce the error on my dev instance or production itself, though I can produce the error on my local python installation. Regardless, using lineterminator will fix your issue: uploaded_json_list = pd.read_csv("list", header=None, lineterminator="\n").to_numpy().flatten().tolist()

It's occurring on my branch https://github.com/bendhouseart/ezbids/tree/pet with any kind of dicom.
Seems like a pandas thing as I rebuild the containers earlier this week. What version of pandas are you using? Mine is 1.5.3 in the container:
Python 3.8.10 (default, Mar 13 2023, 10:26:41)
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pandas
>>> pandas.__version__
'1.5.3'

ezBIDS's pandas version is admittingly a bit dated (version 1.0.1). The lineterminator="\n" should work for pandas version 1.5.3 though

Okay, I think it's time to move onto Vue/JS stuff??
Take a look at the below screenshot and let me know what is next:

Seems like I need to make sure to:

not exclude PET
include some fields PHI fields we drop when we run PET2BIDS, I'm thinking of adding an ezBIDS flag to ensure our json output matches with what you expect. e.g. PatientName, PatientID, PatientBirthDate, AcquisitionDateTime etc.

Looks like things are coming along nicely! Be aware that the message in your screenshot is being triggered because ezBIDS doesn't like the data array's dtype, thinking it's something other than imaging data (see here).

Be aware that the message in your screenshot is being triggered because ezBIDS doesn't like the data array's dtype, thinking it's something other than imaging data (see here).

Hmm, yeah, will update the warning so it doesn't get so mad at PET.

Let us know if you need help with the Vue/JS integration.

That link should suffice for now; I'll reach out if/when I I run into trouble.
Thanks and have a great weekend!

Updated w/ changes discussed earlier, removed draft from PR name to indicated this PR is ready to merge.


add changes to override GCP resources api endpoint

Add ability to override gcp resources api endpoint.

@shellyvilenko thanks for the PR!


chore: update argocd operator

What does this PR do / why we need it:
Updates the argocd operator to the latest version that includes the following fixes:
https://github.com/argoproj-labs/argocd-operator/pull/488
https://github.com/argoproj-labs/argocd-operator/pull/516
https://github.com/argoproj-labs/argocd-operator/pull/518
https://github.com/argoproj-labs/argocd-operator/pull/519
https://github.com/argoproj-labs/argocd-operator/pull/511
https://github.com/argoproj-labs/argocd-operator/pull/507
https://github.com/argoproj-labs/argocd-operator/issues/498
https://github.com/argoproj-labs/argocd-operator/pull/499
https://github.com/argoproj-labs/argocd-operator/pull/505
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:

[ ] Unit Test
[ ] E2E Test

How to test changes / Special notes to the reviewer:

@iam-veeramalla  @jaideepr97 The unit tests were failing because of changes to the latest SSO spec. I've included the fix. Please take a look!

@iam-veeramalla  @jaideepr97 The unit tests were failing because of changes to the latest SSO spec. I've included the fix. Please take a look!

Thanks for raising this PR. I will take a look

@chetan-rns
Thanks for raising this PR, I had raised a draft one earlier that covered some of these changes, but this is more up to date since the sso changes have now gone into master
I think there will be some manifest changes in argocd-operator that should probably be included in this PR
https://github.com/redhat-developer/gitops-operator/pull/247 for reference

@jaideepr97 Sorry! I'm closing this PR since it's a duplicate of #247


refactor(ES6): upgrade NodeEnvironmentPlugin to ES6

What kind of change does this PR introduce?
refactor, ES5 => ES6
Did you add tests for your changes?
No, all existing tests pass
If relevant, link to documentation update:
N/A
Summary
upgraded NodeEnvironmentPlugin to ES6
Does this PR introduce a breaking change?
No

Thank you so much!


Skip zero'th file

If the index of the file within the files list is 0 then it's the starting point for the math, it shouldn't be included in the chart or it'll be a ridiculous comparison.

I'm still not 100% on the file moves and the first variable/notes.
Signed-off-by: kingthorin<EMAIL_ADDRESS>

I believe that's the purpose of the variable first, should be set to 1.

Was the comment associated with first wrong before then? https://github.com/zapbot/zap-mgmt-scripts/commit/9d685cd2c42f587ea91ae80c2c0542c16ca01c10#diff-f92ef62792623bf73ebe4c98fb6f5452
Or was the logic somehow wrong? Wouldn't the zero'th file in the set always cause the issue. Should I scrap the variable and use the index check instead?
Or it "was" correct but it assumed that data collection started (or was already in progress) when the release happened. (That's probably most likely.)

Yeah, the latter.

Okay, so I did decide that it may as well use the index check (now that I noticed the list does get re-assigned to contain 180 files at most).

Sounds good, thanks!


Implement data table

Results are currently only shown on a map, implement a paginated table.

Basic data table in place.

Basic data table in place.


Add missing String & StringName operator descriptions

Adds missing descriptions to the String and StringName operators in the Class Reference. Most notably, a decently detailed one to the "%" operator pointing to the String formatting tutorial.
Also corrects String.bigram()'s print value because I glanced at it, it technically was outdated.

Updated PR to correctly mention Unicode order over alphabetical order in the comparison operators.

I'm also not sure if the link to Wikipedia is sufficient to explain the order,

Do note that the link has been fetched from above, in casecmp_to and its other variations. I agree it'd be nice to find a better website for it, though.


{RecursionError}maximum recursion depth exceeded while calling a Python object

Environment
transformers==4.34.0

I try the patch in README
from torch.nn import functional as F

def NEFTune(model, noise_alpha=5)
    def noised_embed(orig_embed, noise_alpha):
        def new_func(x):
            # during training, we add noise to the embedding
            # during generation, we don't add noise to the embedding
            if model.training:
                embed_init = orig_embed(x)
                dims = torch.tensor(embed_init.size(1) * embed_init.size(2))
                mag_norm = noise_alpha/torch.sqrt(dims)
                return embed_init + torch.zeros_like(embed_init).uniform_(-mag_norm, mag_norm)
            else:
                return orig_embed(x)
        return new_func
    ##### NOTE: this is for a LLaMA model #####
    ##### For a different model, you need to change the attribute path to the embedding #####
    model.base_model.model.model.embed_tokens.forward = noised_embed(model.base_model.model.model.embed_tokens, noise_alpha)
    return model

But model.base_model.model.model.embed_tokens.forward  fails to work, showing the following error message:
{AttributeError}'LlamaModel' object has no attribute 'model'

Therefore, I  tried to edit the patch as below:
 model.base_model.embed_tokens.forward = noised_embed(model.base_model.embed_tokens,
                                                         noise_alpha)

But this will cause another issue:
{RecursionError}maximum recursion depth exceeded while calling a Python object

Could you give me some advice about it? Thank you very much.

replace
model.base_model.embed_tokens.forward = noised_embed(model.base_model.embed_tokens, noise_alpha)
with
model.base_model.embed_tokens.forward = noised_embed(model.base_model.embed_tokens.forward, noise_alpha)
This works for me. If this failed, you can try partial way instead of lambda function, which works for me too.

replace
model.base_model.embed_tokens.forward = noised_embed(model.base_model.embed_tokens, noise_alpha)
with
model.base_model.embed_tokens.forward = noised_embed(model.base_model.embed_tokens.forward, noise_alpha)
This works for me. If this failed, you can try partial way instead of lambda function, which works for me too.

I also encountered the same problem, your method is effective.
And I want to ask why it is like this? I have a guess, I don't know if it's correct: it's just that every time it runs to the
embed_init = orig_embed(x) ,
The forward function in the orig_embed has been replaced with the new_func , so it will be called by __call_impl , so in fact, this line of code has been continuously looping infinitely.


.Include and .IncludeMany does not work with Guid keys in Postgres databases

Hi,
When i use include method in postgres database with primary keys as guid i get the following error:
operator does not exist: uuid = text
I think the problem is here
https://github.com/sqlkata/querybuilder/blob/d098a4ea288819e06fc382ce54e47f335a6b78b9/SqlKata.Execution/QueryFactory.Extensions.Async.cs#L344
instead of
 .Select(x => x[include.LocalKey].ToString())
may be
.Select(x => x[include.LocalKey]);

Do u have workaround for Include in Postgresql?

Yes that's true, can you make a PR for it?

Hi @ahmad-moussawi,
I try to use Include feature, see example
db.Query("environment").Where("siteenvironmentid", UserEnvironmentId).IncludeMany("Organizations", db.Query("organization"), "environmentid", "siteenvironmentid");
it generates this sql statements
SELECT * FROM "environment" WHERE "siteenvironmentid" = 1
SELECT * FROM "organization" WHERE "environmentid" IN ('1')
So it does not work because the second SELECT converts integers to strings
Is it bug or I do something wrong?
Thanks

there is a pr about that issue (see https://github.com/sqlkata/querybuilder/pull/494), why you don't merge this pr to solve this issue?

Would love if this gets solved