is there a pip install package

Hi @loveJasmine - we've got some preliminary wheel files up on PyPI as of today. The package names are "dm-sonnet" or "dm-sonnet-gpu" depending on whether you have tensorflow or tensorflow-gpu installed.
We will change the readme next week to indicate that is the recommended installation procedure, but in the meantime could you try pip install dm-sonnet or pip install dm-sonnet-gpu and let us know how you get on.

not very well, it crashed on dnc project
(venv) mldl@mldlUB1604:~/ub16_prj/dnc-deepmind/sonnet$ python ../train.py --memory_size=64 --num_bits=8 --max_length=3
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcublas.so locally
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcudnn.so locally
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcufft.so locally
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcuda.so.1 locally
I tensorflow/stream_executor/dso_loader.cc:128] successfully opened CUDA library libcurand.so locally
Traceback (most recent call last):
File "../train.py", line 22, in
import sonnet as snt
File "/home/mldl/ub16_prj/dnc-deepmind/sonnet/sonnet/init.py", line 40, in
from sonnet.python.modules import nets
File "/home/mldl/ub16_prj/dnc-deepmind/sonnet/sonnet/python/modules/nets/init.py", line 22, in
from sonnet.python.modules.nets.alexnet import AlexNet
File "/home/mldl/ub16_prj/dnc-deepmind/sonnet/sonnet/python/modules/nets/alexnet.py", line 36, in
from sonnet.python.modules import basic
File "/home/mldl/ub16_prj/dnc-deepmind/sonnet/sonnet/python/modules/basic.py", line 33, in
from sonnet.python.ops import nest
File "/home/mldl/ub16_prj/dnc-deepmind/sonnet/sonnet/python/ops/nest.py", line 41, in
map = nest.map_structure  # pylint: disable=redefined-builtin
AttributeError: 'module' object has no attribute 'map_structure'
(venv) mldl@mldlUB1604:~/ub16_prj/dnc-deepmind/sonnet$

but I also got the same issue as
Mac install fails #29
Open
I herd results build from source but that could be more problems #42
Open
_resampler.so: undefined symbol #25

more seriously, even I build who package from source for Mac, I still got:
ali-186590cc37a5:dnc-deepmind yike.ke$ python train.py
Traceback (most recent call last):
File "train.py", line 22, in
import sonnet as snt
File "/Library/Python/2.7/site-packages/sonnet/init.py", line 126, in
from sonnet.python.ops.resampler import resampler
File "/Library/Python/2.7/site-packages/sonnet/python/ops/resampler.py", line 33, in
tf.resource_loader.get_path_to_datafile("_resampler.so"))
File "/Library/Python/2.7/site-packages/tensorflow/python/framework/load_library.py", line 64, in load_op_library
None, None, error_msg, error_code)
tensorflow.python.framework.errors_impl.NotFoundError: dlopen(/Library/Python/2.7/site-packages/sonnet/python/ops/_resampler.so, 6): Symbol not found: _ZN10tensorflow15shape_inference16InferenceContext15WithRankAtLeastENS0_11ShapeHandleExPS2
Referenced from: /Library/Python/2.7/site-packages/sonnet/python/ops/_resampler.so
Expected in: flat namespace
in /Library/Python/2.7/site-packages/sonnet/python/ops/_resampler.so
ali-186590cc37a5:dnc-deepmind yike.ke$

Could you please run the following command that prints the TF version and report the output here?
$ python -c 'import tensorflow as tf; print(tf.__version__)'

oh, I forgot I shift to tf1.1 for another project.
sure, it works well with tf1.2


chore: Move frontend to src/main

Should this say ”move frontend files” as the version was already updated?

If we update tsconfig.json manually here, won't it then fail for some auto update later on when that is fixed?

This is a temp solution. We have a ticket in Flow to make the updates automatically and will implement it soon.


upgrade to golang 1.10 after rebase on kube 1.11 libraries

upstream changes should make it possible
https://github.com/kubernetes/kubernetes/pull/63046
https://github.com/kubernetes/kubernetes/pull/62412

must be at least golang v1.10.2 per https://github.com/kubernetes/community/pull/2318

closed by #2182
/close


maintain filters in list after deleting

Description

Maintain filters in column dictionary and code table after delete in detail page
Related Issue :

No issue. Release test bug
How Has This Been Tested?

Ran locally.
Go to metadata -> code table / column dictionary ->  apply filters -> move to detail page -> delete -> check if filters are still applied (must not refresh)
Need additional checks?
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.

Additional Context

run build
deploy to 2

@paigechoi
21건의 목록이 존재할때 2페이지 조회하다가 하나의 아이템을 삭제하면 No Data 화면으로 나옵니다.
이건 추가 branch로 작업 부탁드려요.


fix(menu): remove notification to configure identity service

Follow-up to #4125
This PR removes the notification (top right of the main menu) redirecting the user to the settings menu to set up the identity storage (the respective fields were disabled in #4125). In addition, no notification message will be logged in the bottom left of the menu if the identity service token is not set and the user could not be logged in.
Closes #4104

However I'm wondering whether we really need to remove the label and its translations? We do want to revive the identity service after all.

Do we need to? Probably not. On the other hand, I doubt that anybody will pick up that exact same label when re-implementing the whole thing. Instead of removing the translations and the log messages I could have commented it, leaving the i18n strings in place. I would guess this would just become technical debt sooner or later without anyone noticing...


Remove invalid email reference

What this PR does / why we need it:
Replace old bot user email with new<EMAIL_ADDRESS>Also swap git user.name and user.email configurations to use correct defaults.
The old email was removed from the kubevirt-bot GitHub account, thus the publish job for nightly build failed:
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-kubevirt-push-nightly-build-main/1669510740576309248#1:build-log.txt%3A1510
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
/cc @xpivarc @brianmcarey
Release note:

NONE

/approve


J have problem with gradle can u help?

I have a problem with gradle building my mc client, in the right place I ask?

Thank you for your interest in Gradle!
Your question might be answered in Gradle documentation or on our community Slack or forums. Find links to these resources on help.gradle.org.


Spring style of initializing process test coverage rule fails to generate a class level report

Initialising the process test coverage rule for spring like this
  @Rule @ClassRule
  public static ProcessEngineRule rule;

  @PostConstruct
  void initRule() {
    rule = TestCoverageProcessEngineRuleBuilder.create(processEngine).build();
  }

fails to generate a process test coverage report on the "class level". It seems that it can't be produced because at the moment junit looks for an @ClassRule annotated rule, it is not yet initialised.

Unrelated, yet related:
Initially when I started looking at Spring enabling the test coverage plugin, I was investigating how to be able to write Camunda tests with Cucumber. As I remember it, it is impossible to make Cucumber work together with JUnit Rules.
So from a Spring perspective, getting rid of Rule/ClassRule (at least when used with Spring) would be the most desirable outcome of this bug.

I am afraid that the Spring patch I provided is incomplete / broken.
When this issue came up, I did a Spike to see if I could refactor the plugin to support Spring TestExecutionListeners. https://docs.spring.io/spring/docs/current/spring-framework-reference/html/integration-testing.html#__testexecutionlisteners
I didn't make any progress. To me the codebase was too tightly coupled to JUnit 4 Rules and it was hard to see why state was changed and when those calls were made. But code all around assumed that variables were in a certain state to do their work. So I failed to pull the refactoring off.
Now I just read about JUnit 5. In JUnit 5 Rules as deprecated and replaced by Extensions.
http://www.codeaffine.com/2016/04/06/replace-rules-in-junit5/
So if Camunda Test coverage should support JUnit 4, JUnit 5 and Spring testing, maybe it would be a good idea to decouple the code more from Rules? And then have adaptors for JUnit 4, 5 and TestExecutionListeners.
I suspect that JUnit 5 is flexible enough to cover the Spring support. At least Spring 5.0 support ..

At some point I'd like @falko 's feedback on my observations above ...

Sounds reasonable. But I'm not the best to judge a refactoring like this, because I don't know the latest code so well.

interested in using Cumcumber for camunda as well.  anyone start any work on this?

we did an extension for jbehave a while ago. Seems better fitting for processes because of the "given-scenario" support. https://github.com/camunda/camunda-bpm-jbehave

@jangalinski did you ever create a "simplified" implementation?  The jbehave camunda implamation is (IMO) super complicated (while very advanced and option rich) with multiple levels of abstractions and configuration files.  Its the SpaceShip model when typically we need a Toyota camry

Hi all. I added a quick (and a bit dirty) example of how to leverage the camunda assert "scenario" runner in combination with cucumber to an example/cucumber branch. I can execute it within intellij but did not yet take care of more. You find the feature file here https://github.com/camunda/camunda-bpm-assert-scenario/blob/example/cucumber/example/src/test/resources/org/camunda/bpm/scenario/examples/paymentretrieval/RestoreCredit.feature and three related files in the package. I think what's interesting is that the test becomes truly behavioural, there is no hard dependency to the way how a requirement is implemented in the process. Some feedback would be awesome ofc. :-)


GodotPhysics: Avoid NaNs when calculating inertias for bodies without mass/area

This PR fixes #49176 (which also occurs on 4.0 branch) by avoiding division by zero when calculating inertia for bodies with attached colliders without area/mass (RayCast shape).

Looks good!
To answer your question from #49176 (comment):

When testing I noticed that the mass of disabled colliders is counted towards mass of entire object, I'm not sure if that behavior is intended or not.

This behavior is not intended, so the correct thing would be to ignore disabled shapes in the center of mass calculation, and also in the total_area calculation.
If you're up for it, feel free to also fix that in the current PR or a separate one.

I think it should be better to open new issue and separate PR for disabled colliders counting towards mass as this isn't quite related with Physics suddenly calculating NaNs.
It could be also a good idea to check if similar issue of disabled colliders affecting body doesn't occur in other calculations and if fixing that won't cause any regression.

Thanks!

Cherry-picked for 3.4.

Cherry-picked for 3.3.3.


Angular 8 injectable pipe migration schematic produces invalid code

🐞 Bug report
Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [x] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?
No
Description
After running the v8 schematic it produces invalid code. It transforms a pipe's imports to be:
import import { Pipe, PipeTransform, LOCALE_ID, Inject, Injectable } from '@angular/core'; from '@angular/core';

🔬 Minimal Reproduction
git clone https://github.com/mattlewis92/angular-calendar.git
cd angular-calendar
npm install
ng update @angular/cli @angular/core codelyzer --next --force
git diff projects/angular-calendar/src/modules/common/calendar-date.pipe.ts

🔥 Exception or Error
N/A it works, just produces invalid code
🌍 Your Environment

Angular CLI: 8.0.0-rc.1
Node: 11.13.0
OS: darwin x64
Angular: 8.0.0-rc.1
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.800.0-rc.1
@angular-devkit/build-angular      0.800.0-rc.1
@angular-devkit/build-ng-packagr   0.800.0-rc.1
@angular-devkit/build-optimizer    0.800.0-rc.1
@angular-devkit/build-webpack      0.800.0-rc.1
@angular-devkit/core               8.0.0-rc.1
@angular-devkit/schematics         8.0.0-rc.1
@angular/cdk                       7.3.7
@ngtools/json-schema               1.1.0
@ngtools/webpack                   8.0.0-rc.1
@schematics/angular                8.0.0-rc.1
@schematics/update                 0.800.0-rc.1
ng-packagr                         5.1.0
rxjs                               6.5.1
typescript                         3.4.5
webpack                            4.30.0

Anything else relevant?
Nope

Thanks for trying the RC and reporting this issue. A fix for this issue is pending in https://github.com/angular/angular/pull/30170

Thanks for reporting these migration issues. That is really helpful. Let's track this issue on the Angular repository where a similar one already exists: https://github.com/angular/angular/issues/30159.

Whoops, sorry, didn't realise the angular schematics were part of the main repo, didn't think to check there for similar issues. Thanks for looking into it! 😄

Oh yeah that's pretty confusing :smile: Need to check if we can make this somehow more obvious.


crafting and other stuff

if i craft 2 of an item it completely removes that recipe from the interface until i reload, its annoying
please make it so i don't end up with 2 separate unfilled item stacks in the UI
add sub catagories like walls, crafting stations, light sources, boss summons and bags, etc
is it possible to make an item that auto stores items from the inventory like how the Luiafk money collector auto stores coins in the piggy bank?

these are some things (or the lack of) that make me pull my hair out, dont get me wrong i love the mod and i do prefer this version over normal Magic Storage.

Do 1 and 2 still happen in the newest version?

is it possible to make an item that auto stores items from the inventory like how the Luiafk money collector auto stores coins in the piggy bank?

Auto stacker mod can allow you to do this. But would love to see it better implemented into magic storage itself, so @ExterminatorX99, if ya want you could check out the auto stacker GitHub ( https://github.com/srtsnlt/AutoStacker ) and ask to borrow some code.


Change the POST request to a GET one for a static question.mark.html to improve compatibility on nginx servers

Currently, QuestionMark does a POST request to get the content of question.mark.html.
This fails gracefully on nginx servers, as a POST request against a static file will return a 405 non authorized error.
I use the adverb gracefully, as this won't provide any JavaScript error.
A GET request seems more appropriate, as the question.mark.html content is static.

Sorry I didn't even notice this PR (GH never notified me this existed). I've recently updated the project to now use Fetch API.

Sorry I didn't even notice this PR (GH never notified me this existed). I've recently updated the project to now use Fetch API.


Disabled test by default

It wasted time for commercial production deployment

https://github.com/zcoinofficial/zcoin/pull/360


Update netAs.cpp

added checks to avoid "afrihost" from getting detected as Hosting when we're searching for the word "host" on the provider name!
Example IP:  https://iphub.info/?ip=<IP_ADDRESS>

Did you close this because of a code error or because you figured it actually is a host?

it's actually a code error, also was thinking of just making a "whitelist" that if it contains "afrihost" and obviously future hostings it just returns false, it seems like a better way to implement all this


[ParseableInterfaces] Stop replacing inaccessible properties with '_'

Turns out this isn't correct, since SROA can explode these structs into
scalars in inlinable code.
Put the logic in place to effectively disable it, and document the steps
we need to take to make it work in the future.

@swift-ci please test


Crash after editing file: Module loc out of bounds

Input
→ View on sorbet.run
# typed: true

# This is a very long comment. A long comment so that the ::GRPC::GenericService definition at the end of the file
# is at a location that is not within the range of the rbupdate file.

Bundler::CRPC # error: Unable to resolve constant

module ::DRPC::SomeSubmodule; end

Remove the comment to see the crash. Note: It does not occur in web builds.
Observed output
In debug build:
[error] Exception::raise(): core/Loc.cc:68 enforced condition off <= file.source().size() has failed: file offset out of bounds in file: test/testdata/lsp/fast_path/crash.rb @ 259 <= 129

[error] Backtrace:
  #3 0x1783177 sorbet::core::Loc::offset2Pos()
  #4 0x17834d8 sorbet::core::Loc::position()
  #5 0x1784773 sorbet::core::Loc::filePosToString()
  #6 0x171efdc sorbet::core::ErrorLine::toString()
  #7 0x171f5cf sorbet::core::ErrorSection::toString()
  #8 0x171fa70 sorbet::core::Error::toString()
  #9 0x1731eee sorbet::core::ErrorQueue::pushError()
  #10 0x1767d5e sorbet::core::GlobalState::_error()
  #11 0x1720946 sorbet::core::ErrorBuilder::~ErrorBuilder()
  #12 0x13de913 sorbet::resolver::(anonymous namespace)::ResolveConstantsWalk::constantResolutionFailed()
  #13 0x13d62a3 sorbet::resolver::(anonymous namespace)::ResolveConstantsWalk::resolveConstants()
  #14 0x13d9f25 sorbet::resolver::Resolver::runIncremental()
  #15 0xf771b3 sorbet::realmain::pipeline::incrementalResolve()
  #16 0xd2fc78 sorbet::realmain::lsp::LSPTypechecker::runFastPath()
  #17 0xd2d299 sorbet::realmain::lsp::LSPTypechecker::typecheck()
  #18 0xd32eaf sorbet::realmain::lsp::LSPTypecheckerDelegate::typecheckOnFastPath()
  #19 0xe3e36c sorbet::realmain::lsp::SorbetWorkspaceEditTask::run()
  #20 0xe495db sorbet::realmain::lsp::(anonymous namespace)::TypecheckerTask::run()
  #21 0xe4768e sorbet::realmain::lsp::LSPTypecheckerCoordinator::asyncRunInternal()
  #22 0xe4775e sorbet::realmain::lsp::LSPTypecheckerCoordinator::syncRun()
  #23 0xd8772c sorbet::realmain::lsp::LSPLoop::runTask()
  #24 0xd87277 sorbet::realmain::lsp::LSPLoop::processRequests()
  #25 0xcfdbd3 sorbet::realmain::lsp::SingleThreadedLSPWrapper::getLSPResponsesFor()
  #26 0xc2d5be sorbet::test::getLSPResponsesFor()
  #27 0xb3eb38 sorbet::test::_DOCTEST_ANON_FUNC_52()
  #28 0x19bd8a9 doctest::Context::run()
  #29 0xb4016a main
  #30 0x7fede4f97840 __libc_start_main
  #31 0xb37029 _start

Expected behavior
No crash!
The issue occurs in a Sorbet error message that suggests an alternative constant since Bundler::CRPC does not exist. It suggests ::DRPC, which is defined at the end of the file.
When you remove the comment, Sorbet fails to update the location information for ::DRPC's definition, and tries to print a code location that does not exist.
This problem does not occur if we simply define module ::DRPC instead of module ::DRPC::SomeSubmodule, which leads me to believe that there is a bug in incremental namer when entering a submodule on a module that has not yet been defined elsewhere.

OK, here's what I believe is happening:

We create the DRPC symbol implicitly because it does not exist when Sorbet evaluates DRPC::SomeSubmodule. Thus, DRPC ends up having a loc in this file.
Normally, when Sorbet encounters module Foo::Bar and Foo exists, it does not add a loc to Foo.
On the fast path, DRPC exists, so Sorbet does not update its loc when it encounters DRPC::SomeSubmodule.

I'll have to think on if a tractable solution is possible here.

I tried a different approach that assigns a none Loc to these classes, but that ends up propagating to the singleton classes we create and we don't update their loc when we process the actual definition (ugh).
Maybe I can force singletonClass to update the singleton class loc or something.

This looks like the same issue as #1587 but I can't reproduce using this example either. Maybe we fixed it at one point.


Memcached: update packages

Update packages:

memcached to 1.5.13
php-memcached to 3.1.3

cc @etu
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build memcached php71Packages.memcached php72Packages.memcached php73Packages.memcached php71Packages-unit.memcached php72Packages-unit.memcached php73Packages-unit.memcached

Thanks!


Dynamic configuration

Description
This PR adds dynamic configuration of a subset of items in the karavi-config-secret:

certificate.crtfile
certificate.keyfile
certificate.rootcertificate
web.sidecarproxyaddr
web.jwtsigningsecret

These items are removed from the middleware used to configure the proxy-server/handlers and now used as global variables which are updated by Viper.
The certificate and web.sidecarproxyaddr settings are used for injection. web.jwtsigningsecret can be changed to update the JWT secret on the fly. To edit the config secret, you'd execute these steps:

Run k3s kubectl -n karavi edit secret/karavi-config-secret to open the secret
Copy the base64 encoded data in config.yaml under the data field and decode it
Edit the decoded data to make changes and base64 encode it
Run the command in step 1 to open the secret
Replace the base64 encoded in config.yaml with your encoded changes

This was tested by executing these steps with the csi-vxflexos driver:

Inject the driver using the config file in ~/.karavi/config.json
Edit the karavi-config-secret to use a different sidecar tag (functionally the same image) and a different JWT signing secret, wait for the config change in the proxy-server logs
Run karavictl generate token ... | kubectl -n vxflexos apply -f - to update the proxy-authz-tokens secret
Inject again to trigger request flows (injection not required, just used to test)

Issues
List the issues impacted by this PR:

Issue ID

#129

Checklist:

[x] I have performed a self-review of my own changes.

]# make test
docker run --rm -it -v /root/karavi-authorization/policies:/policies/ openpolicyagent/opa test -v /policies/
data.karavi.authz.url.test_get_api_login_allowed: PASS (1.246329ms)
data.karavi.authz.url.test_post_proxy_refresh_token_allowed: PASS (497.729µs)
data.karavi.authz.url.test_get_api_version_allowed: PASS (468.968µs)
data.karavi.authz.url.test_get_system_instances_allowed: PASS (409.229µs)
data.karavi.authz.url.test_get_storagpool_instances_allowed: PASS (525.485µs)
data.karavi.authz.url.test_post_volume_instances_allowed: PASS (418.817µs)
data.karavi.authz.url.test_get_volume_instance_allowed: PASS (460.297µs)
data.karavi.authz.url.test_post_volume_instances_queryIdByKey_allowed: PASS (426.161µs)
data.karavi.authz.url.test_get_system_sdc_allowed: PASS (463.862µs)
data.karavi.authz.url.test_post_volume_add_sdc_allowed: PASS (394.37µs)
data.karavi.authz.url.test_post_volume_remove_sdc_allowed: PASS (394.273µs)
data.karavi.authz.url.test_post_volume_remove_allowed: PASS (478.42µs)
data.karavi.volumes.create.test_small_request_allowed: PASS (1.223597ms)
data.karavi.volumes.create.test_large_request_not_allowed: PASS (326.192µs)
--------------------------------------------------------------------------------
PASS: 14/14
go test -count=1 -cover -race -timeout 30s -short ./...
?       karavi-authorization/cmd/karavictl      [no test files]
ok      karavi-authorization/cmd/karavictl/cmd  17.349s coverage: 65.4% of statements
ok      karavi-authorization/cmd/proxy-server   0.066s  coverage: 15.6% of statements
?       karavi-authorization/cmd/sidecar-proxy  [no test files]
ok      karavi-authorization/cmd/tenant-service 0.048s  coverage: 9.4% of statements
ok      karavi-authorization/deploy     0.092s  coverage: 86.3% of statements
?       karavi-authorization/internal/decision  [no test files]
ok      karavi-authorization/internal/powerflex 9.138s  coverage: 88.9% of statements
ok      karavi-authorization/internal/proxy     7.555s  coverage: 69.4% of statements
ok      karavi-authorization/internal/quota     0.369s  coverage: 90.1% of statements
ok      karavi-authorization/internal/roles     0.045s  coverage: 93.2% of statements
ok      karavi-authorization/internal/tenantsvc 1.507s  coverage: 82.3% of statements
ok      karavi-authorization/internal/token     0.037s  coverage: 90.9% of statements
ok      karavi-authorization/internal/token/jwx 0.036s  coverage: 71.7% of statements
ok      karavi-authorization/internal/web       0.036s  coverage: 28.4% of statements
?       karavi-authorization/pb [no test files]

@atye: Thank you for submitting your pull request!
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at<EMAIL_ADDRESS>


fix: empty string conversion to undefined

Resolves:

https://github.com/formium/formik/issues/2528
https://github.com/formium/formik/issues/2047
https://github.com/formium/formik/issues/1520
https://github.com/formium/formik/issues/1697

it looks like it does a deep clone to pass the object to Yup immutably? isn't there a lodash func for that?

Isn't this a massive breaking change?

definitely a breaking change. it looks like specifically for this, it will break min/max validations at the root level which currently accept no value.
https://github.com/formium/formik/issues/1520
This is how I understand it working from reading the PR (could be outdated):
If a validation schema like Yup.min(1).max(5) is entered, it will currently accept a value of ''.
If a validation schema like Yup.required().min(1).max(5) is entered, it will currently not accept a value of ''.
If a validation schema like Yup.min(1).max(5) is entered with the new changes, it will validate that '' is not between 1 and 5.
Can we get a unit test for this?

@jaredpalmer can you have a look

@jaredpalmer ?
@maddhruv this needs update afaik (and response from Jared)

@jaredpalmer ?
@maddhruv this needs update afaik (and response from Jared)

ping again? c'mon...

We just ran into this issue (empty strings being passed as undefined to yup) so I'll share my opinion. We are using draft-js editor in our form:
type FormValues = {
  name: string;
  text: RawDraftContentState; // from draft-js
}

Because formik replaces all the empty strings recursively with undefined and passes that data to yup, it breaks the draft-js model that is received by my validation function:
function draftjsValidation(context: yup.TestContext, value: RawDraftContentState,
): yup.ValidationError | boolean {

  // draft-js convertToRaw fails because strings inside the value are undefined instead of empty
  const content = convertFromRaw(value);

In my opinion formik should pass the form values as is to yup but then again there are probably historical reasons why formik does this and changing it would be a breaking change.

Need this urgently please!

If you are using yup, you can run the validation yourself. Note the yupToFormErrors comes from formik.
<Formik validate={validate}>

function validate<T>(
  validationSchema: yup.SchemaOf<T>,
  values: T,
  context: ValidationContext
): FormikErrors<unknown> | undefined {
  try {
    validationSchema.validateSync(values, {
      abortEarly: false,
      context: context,
    });
  } catch (err) {
    return yupToFormErrors(err);
  }

  return undefined;
}

#unstale
TBH this is a needed fix

Based on @tparvi's example, here's a ready-to-use wrapper function:
import { FormikErrors, yupToFormErrors } from "formik";
import yup from "yup";
export default function yupFormikWrapper(
  validator: yup.AnySchema
): (values: unknown) => Promise<FormikErrors<unknown>> {
  return async function validate(values) {
    try {
      await validator.validate(values, {
        abortEarly: false,
      });
    } catch (err) {
      return yupToFormErrors(err);
    }
    return undefined;
  };
}

Usage:
// Old
validationSchema={validator}
// New
validate={yupFormikWrapper(validator)}


Getting an Integrity constraint violation: SQLSTATE[23000]

Laravel Version: 5.5.0
Voyager Version: 1.0.0
PHP Version: 7.1.3
Database Driver & Version: MySQL 5.7

Description:
Just thought I would let you guys know that one gets a Query Exception error instead of triggering a validation rule while inserting new user into database with null value for "password".

"SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'password' cannot be null (SQL: insert into users (name, email, password, avatar, role_id, updated_at, created_at) values (FluffyPanda<EMAIL_ADDRESS>, users/March2018/lHBM7WCD3KkcSlR5p3Qj.jpg, 2, 2018-03-15 01:05:06, 2018-03-15 01:05:06))

Steps To Reproduce:

Create New User
Leave "password" null
Get error message! :)

Fixed in #2828


feat(plugin): Support customplugin (#301)

Signed-off-by: Gentleelephant<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #301
Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

@Gentleelephant We also need to update docs for plugins https://github.com/fluent/fluent-operator/tree/master/docs/plugins/fluentbit
@wanjunlei How to generate these docs automatically?
The index should be added manually as I can remember

@Gentleelephant We also need to update docs for plugins https://github.com/fluent/fluent-operator/tree/master/docs/plugins/fluentbit
@wanjunlei How to generate these docs automatically?
The index should be added manually as I can remember

Make docs-update?
https://github.com/fluent/fluent-operator/blob/master/Makefile#L174

@Gentleelephant We also need to update docs for plugins https://github.com/fluent/fluent-operator/tree/master/docs/plugins/fluentbit
@wanjunlei How to generate these docs automatically?
The index should be added manually as I can remember

make docs-update?
https://github.com/fluent/fluent-operator/blob/master/Makefile#L174

Yes

Regarding the modification of the document, do I need to create a new pr? @benjaminhuo @wanjunlei

@Gentleelephant You can add another doc in https://github.com/fluent/fluent-operator/tree/master/docs/best-practice to elaborate on how to use the custom plugin like docs in https://github.com/fluent/fluent-operator/blob/master/docs/best-practice/collect-systemd-logs.md


Made Abstract class abstract

As indicated by @sstok https://github.com/qandidate-labs/broadway/pull/165#discussion_r33753042

:+1:


Dificulty writing on characteristic

Summary
When writing on a concrete characteristic within the same session, sometimes the writings are not effective.

Preconditions
Create an activity passing a bluetooth device object
Let the lifecycle methods of my activity establish and release the connection with this device. In my case Start and Stop.
Create listeners that react when some input change, and then send messages to a known characteristic

Steps to reproduce actual result

Input change, triggering characteristic write using an observable connection previously established in onStart method.
Subscription, with logging
Read result with the ble device monitor.

Actual result
Every time input changes, it sends the message. No exception thrown. But normally the characteristic value is received in the other end, but there is a problem with the following ones. They are sent, but just some of them received.

Expected result
Receive all characteristic without exception.

First of all, congratulations for this amazing library. I find it very useful and sometimes makes things like searching for devices or discovering services extremely easy. I am rising this as an issue, but it is very likely I am doing something wrong.
I also have to say that I tried with android vanilla ble api, and there was no problem writing on the same characteristic.
Thanks in advance.

Hello,
To be able to help you I would need to see the logs from the device (or both if possible) and the code you are using.
I am also thinking if this question should not go to www.stackoverflow.com with rxandroidble tag

Hi,
You are absolutely right, I should have created a thread in stackoverflow. I didn't do it I guess because it was a question related to an specific library outside the android framework, but now I've seen there are some question targeting concrete third party libraries, so I will do that way next time.
Anyway, I have solved the problem. I didn't know until I saw it in the sample app, that you needed to create a ConnectionSharingAdapter for multiple writings within a connection. Before that, I was opening and closing the connection every time I was writing on a characteristic, but I was having problems with that. And before that I was using a single connection as described when I started this thread, but it was crashing, logging that there was a connection already established.
I also have to say that the description of the issue is not accurate as in my mind I mixed up these two cases, having changed the code several times.
In my humble opinion, there should be an example in the main page for multiple writings using ConnectionSharingAdapter, in order to make it a bit more obvious.
Thanks a lot.

Glad to hear that you have resolved your issue. Thanks for the suggestion. I will probably also add a note that knowledge of rxJava is advised.


Add details about Invoice Policies

Jira URL: https://jira.concur.com/browse/AIS-7979
Describe the change:

Added section about invoicePolicies to AIS documentation

What are the acceptance criteria for this change:

Documentation is added for invoicePolicies

How was this tested, and what to look for when testing:

N/A

Commit Checklist

[x] No new CheckStyle findings added for the edited files
[x] Unit and/or functional tests have been added for new code. In case of bug fixes, existing unit tests should also
be updated.
[x] No secrets are being logged as part of exception messages or log statements
[x] Code changes have been validated either against localstack or integration unstable
[x] Dead code is managed: create a follow-up Jira ticket if this change introduces any transient code or causes other code to eventually be dead code, and include in the Future Work section
[x] All TO-DO statements have corresponding Jira tickets created
[x] Validation ticket has been created for complex features
[x] Appsec logs added for any Authentication, Authorization or Config changes

Sorry, please don't review and merge this PR yet. Need to make an additional commit to fix a property name.

Pushed new commit, PR is good for review approval and merge now.


Use the adrg/xdg library to find OS specific path for config

Because on Windows we used 'C:.config\epinio\settings.yaml' which
is not the place where apps write their configuration on Windows.
Probably did the wrong thing on Mac as well.
Fixes #1579

On Windows 10:
PS C:\Users\User> epinio settings show

🚢  Show Settings
Settings: C:\Users\User\AppData\Local\epinio\settings.yaml

...

On Mac:
➜  Downloads ./epinio settings show

🚢  Show Settings
Settings: /Users/mamartin/Library/Application Support/epinio/settings.yaml

✔  Ok
|        KEY        |    VALUE     |
|-------------------|--------------|
| Colorized Output  | true         |
| Current Namespace | workspace    |
| Default App Chart |              |
| API User Name     |              |
| API Password      |              |
| API Url           |              |
| WSS Url           |              |
| Certificates      | None         |
|                   | defined      |

The prepare scripts fail now because the server pod can't start:
panic: could not create any of the following paths: /.config/epinio, /etc/xdg/epinio

Codecov Report

Merging #1586 (0721705) into main (a6689cf) will increase coverage by 6.02%.
The diff coverage is 41.66%.

@@            Coverage Diff             @@
##             main    #1586      +/-   ##
==========================================
+ Coverage   52.11%   58.13%   +6.02%
==========================================
  Files         167      167
  Lines       12309    12317       +8
==========================================
+ Hits         6415     7161     +746
+ Misses       5039     4156     -883
- Partials      855     1000     +145

Flag
Coverage Δ

acceptance-api
?

acceptance-apps
37.77% <25.00%> (-0.41%)
:arrow_down:

acceptance-cli
57.24% <25.00%> (?)

unittests
8.63% <50.00%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/cli/settings/settings.go
78.68% <0.00%> (+6.55%)
:arrow_up:

internal/cli/root.go
75.80% <50.00%> (-5.68%)
:arrow_down:

internal/api/v1/application/match.go
0.00% <0.00%> (-82.36%)
:arrow_down:

internal/api/v1/configuration/match.go
0.00% <0.00%> (-82.36%)
:arrow_down:

internal/api/v1/appchart/match.go
0.00% <0.00%> (-80.65%)
:arrow_down:

internal/api/v1/namespace/match.go
0.00% <0.00%> (-80.65%)
:arrow_down:

internal/api/v1/service/match.go
0.00% <0.00%> (-75.68%)
:arrow_down:

internal/api/v1/service/catalogmatch.go
0.00% <0.00%> (-74.29%)
:arrow_down:

internal/api/v1/application/portforward.go
0.00% <0.00%> (-69.24%)
:arrow_down:

internal/api/v1/configuration/replace.go
0.00% <0.00%> (-60.38%)
:arrow_down:

... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6689cf...0721705. Read the comment docs.


Update level 2 content

Bug report
Description
We need to update the level 2 mission info content as we give the user the handbook right away rather than only in level 2 onwards.
Reproduction steps
Steps to reproduce the behavior:

Go to level 2
Mission info contains a bit about giving the user a handbook.

Expected behavior
This bit about the handbook should either be in level 1 or removed entirely.
Screenshots

Additional context
Questions:

Remove completely or move to level 1? Note that we may want to also point users to the handbook after beating level 1 as that's where the system role is shown. - Reword the section in level 2.

Acceptance criteria
TBD after questions

tested 🤞


ntl init error: TypeError: undefined is not iterable

Describe the bug
When running ntl init I get the error: TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
This occurs particularly when trying to create the functions directory.
Steps to reproduce

Run ntl init and accept the default options

`❯ node -v
v16.8.0
❯ ntl init
? What would you like to do? +  Create & configure a new site
? Team: James Sherry's team
Choose a unique site name (e.g. super-cool-site-by-jmsherry.netlify.app) or leave it blank for a random name. You can update the site name later.
? Site name (optional): test-ttt
Site Created
Admin URL: https://app.netlify.com/sites/test-ttt
URL:       https://test-ttt.netlify.app
Site ID:   b4fc1a25-ba7f-4a09-84d5-7227139fac15
? Your build command (hugo build/yarn run build/etc): # no build command
? Directory to deploy (blank for current dir): public
? Netlify functions folder: netlify/functions
? No netlify.toml detected. Would you like to create one with these build settings? Yes
TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))`
Configuration
example netlify.toml
[build]
command = "# no build command"
functions = "netlify/functions"
publish = "public"
Uncomment to use this redirect for Single Page Applications like create-react-app.
Not needed for static site generators.
#[[redirects]]
from = "/*"
to = "/index.html"
status = 200
(optional) Settings for Netlify Dev
https://github.com/netlify/cli/blob/master/docs/netlify-dev.md#project-detection
#[dev]
command = "yarn start" # Command to start your dev server
port = 3000 # Port that the dev server will be listening on
publish = "dist" # Folder with the static content for _redirect file
more info on configuring this file: https://www.netlify.com/docs/netlify-toml-reference/
Environment
System:
OS: macOS 12.5
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 44.93 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.8.0 - /var/folders/hd/jkczj0nx7zb6xywcm3x9hbn80000gn/T/fnm_multishells/46810_1661895578892/bin/node
Yarn: 1.22.18 - /usr/local/bin/yarn
npm: 7.21.0 - /var/folders/hd/jkczj0nx7zb6xywcm3x9hbn80000gn/T/fnm_multishells/46810_1661895578892/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
npmPackages:
netlify-cli: ^11.5.1 => 11.5.1
npmGlobalPackages:
netlify-cli: 11.5.1

@jmsherry Could you update the Netlify CLI package & try again once? I'm not able to reproduce this issue.
If the issue is still occurring, could you provide a repository in the original state (before running the init command)?

Closing this issue as it's no longer reproducible with netlify-cli/12.2.7.


PHOENIX-6429 Add support for global connections and sequential data generators

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 43s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 10 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
5m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
11m 23s
master passed

+0
hbaserecompile
23m 20s
HBase recompiled.

+1 :green_heart:
compile
1m 35s
master passed

+1 :green_heart:
checkstyle
1m  3s
master passed

+1 :green_heart:
javadoc
1m 14s
master passed

+0 :ok:
spotbugs
3m  5s
phoenix-core in master has 956 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 52s
phoenix-pherf in master has 50 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
8m  3s
the patch passed

+0
hbaserecompile
14m 42s
HBase recompiled.

+1 :green_heart:
compile
1m 35s
the patch passed

+1 :green_heart:
javac
1m 35s
the patch passed

-1 :x:
checkstyle
0m 32s
phoenix-pherf: The patch generated 107 new + 503 unchanged - 36 fixed = 610 total (was 539)

-1 :x:
whitespace
0m  0s
The patch 8 line(s) with tabs.

+1 :green_heart:
xml
0m  4s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 10s
the patch passed

-1 :x:
spotbugs
1m  5s
phoenix-pherf generated 1 new + 50 unchanged - 0 fixed = 51 total (was 50)

_ Other Tests _

-1 :x:
unit
107m 32s
phoenix-core in the patch failed.

+1 :green_heart:
unit
9m 29s
phoenix-pherf in the patch passed.

+1 :green_heart:
asflicense
1m 22s
The patch does not generate ASF License warnings.

181m 57s

Reason
Tests

FindBugs
module:phoenix-pherf

A prepared statement is generated from a nonconstant String in org.apache.phoenix.pherf.workload.mt.tenantoperation.PreScenarioOperationSupplier$1.apply(TenantOperationInfo)  At PreScenarioOperationSupplier.java:from a nonconstant String in org.apache.phoenix.pherf.workload.mt.tenantoperation.PreScenarioOperationSupplier$1.apply(TenantOperationInfo)  At PreScenarioOperationSupplier.java:[line 76]

Failed junit tests
phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1187/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1187

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml

uname
Linux 8c1ef167e95a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 45ebf1a

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1187/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1187/1/artifact/yetus-general-check/output/whitespace-tabs.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1187/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1187/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1187/1/testReport/

Max. process+thread count
16498 (vs. ulimit of 30000)

modules
C: phoenix-core phoenix-pherf U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1187/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Add reclaim space protobuf file

This commit adds the protobuf file which includes the spec
for communication between the CSIAddons Controller and sidecar.
Signed-off-by: yati1998<EMAIL_ADDRESS>

Please add a new makefile to generate go files from protoc files or modify existing makefile or both.
Thanks

Please add a new makefile to generate go files from protoc files or modify existing makefile or both. Thanks

After talking to @nixpanic , he suggested to directly write the protobuf file. @nixpanic What's your thought here? shall I write the README to create the protobuf?

Please add a new makefile to generate go files from protoc files or modify existing makefile or both. Thanks

After talking to @nixpanic , he suggested to directly write the protobuf file. @nixpanic What's your thought here? shall I write the README to create the protobuf?

There is no need to place the protobuf parts in a readme. This is internal to this repository only, not shared for some external API.
There might be a benefit in automatically re-generating the go files from the .proto file, but I do not think we need to do that now. If we really think it helps, we can always add such automation later.

Just makefile with commands to generate go files.

The problem is installing the protoc components... The way it is done in csi-addons/spec is not clean, so I prefer manual generation before we add automation around this and other parts of the project.


Extension to patch AS::TaggedLogging for compatibility

ActiveSupport::TaggedLogging uses Thread.current[]= to track log tags.
This Thread.current[]= is however Fiber local variable (since Ruby
2.0)
Compare:

https://ruby-doc.org/core-2.0.0/Thread.html#method-i-5B-5D
Attribute Reference—Returns the value of a fiber-local variable
(current thread's root fiber if not explicitely inside a Fiber),
using either a symbol or a string name. If the specified variable
does not exist, returns nil.

https://tool.oschina.net/uploads/apidocs/ruby-1.9.3-core/Thread.html#method-i-5B-5D
Attribute Reference—Returns the value of a thread-local variable,
using either a symbol or a string name. If the specified variable
does not exist, returns nil.

The patch uses #thread_variable_set and #thread_variable_get which
are part of Ruby itself since 2.0. ActiveSupport contained shims for
this in the 4.x series, they were dropped in the 5.x series when Rails
adopted a minimum RUBY_VERSION of 2.2, and thus was guaranteed access to
those native implementations of thread_varaible_{set,get}

Thanks, I'll make a few tweaks and push a release shortly after.


[R] Remove tiledb dependency for R package

Motivation
My understanding is that tiledbsoma no longer relies on the tiledb package so that we need to deal with conflicting versions less. However, the cellxgene_census package still has a hard dependency on tiledb.
Definition of Done
Remove the tiledb dep
Tasks
Detail the specific tasks that can be used to accomplish the desired changes.
If detailed steps cannot be provided at this time, please file a Tech Proposal instead.

[ ] Remove tiledb dep
[ ] Don't break things

@mlin or @johnkerl we expect this to just be removing the dependency, right?

My understanding is that tiledbsoma no longer relies on the tiledb package so that we need to deal with conflicting versions less. However, the cellxgene_census package still has a hard dependency on tiledb.

@ivirshup this is still a work in progress for R. For Python, it's largely complete.


Get documentation to access others fields

According to the issue #2 , it is possible to create any kind of formula and use redmine field such as status (self.status_id).
Is it possible to provide the documentation in order to get the name of the variable of the basic redmine field? (such as Assignee,Category,Target version,Parent task, Start date, Due date,Estimated time,% Done )

I guess it is the same name codification than the database column so like this:
tracker_id, project_id, subject, description, due_date, category_id, status_id, assigned_to_id, priority_id, fixed_version_id, author_id, lock_version, created_on, updated_on, start_date, done_ratio, estimated_hours
I tried to use it with the estimated hours for example: self.estimated_hours*2. But I got "Formula is invalid". Could you help me to correct the formula?

I'll add some documentation later when new version of plugin would be relased. Correct formula is "(self.estimated_hours || 0)*2" but current version of the plugin has a validation bug.

I've just released a new version of this plugin, please try it. And let me know if something went wrong.
To write a more detailed documentation I need some more time.

I found that documentation which is very helpful to help writing formulas :
http://www.rubydoc.info/github/edavis10/redmine/Issue

Today I added into "readme" a few links to http://www.rubydoc.info/github/edavis10/redmine


Update index.html

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstrachan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pr-build
2b541a4013a0f568f4043843d1b851b84ab308fe
link
/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest

/test pr-build

/test all


P2 | Part 1Add answers to questions about overall experience

Description: Answer the questions from "Overall experience" in the report. Make a new branch from report.

Closed with merge to report


Tech Retrospective (Tech-tro) - Well Established, Never Published

Similar to a a full-team Retrospective, this Retrospective is focused on how the development team:

How can they improve their own processes?
That is the status of tech-debt in the codebase?
Are there anti-patterns that need to be addressed?
Are there good patterns that need to be more formally and/or widely applied?
etc.

TEST FROM ANOTHER ACOUNT.
I would like to work on this.
TEST FROM ANOTHER ACOUNT.

Great, I have assigned you. Have fun.

Actually never mind. I will un-assign myself.

Actually yeah. I'll work on it.

Great, I assigned you and and moved it to In Progress.

Never mind I'm unassigning myself.


When is logging to Kafka going to support sasl/scram-256?

  Follow the test case test below, all tests passed
Test cases:
Cluster level Logging

Test sasl/scram-256 authentication
Test sasl/scram-512 authentication
Test Plain authentication
Test SSL Configuration
Multiple Endpoint
Test using advanced mode to customize match and SSL Configuration

Project level Logging

Test sasl/scram-256 authentication
Test sasl/scram-512 authentication
Test Plain authentication
Test SSL Configuration
Multiple Endpoint
Test using advanced mode to customize match and SSL Configuration


add try-runtime github workflow

In alignment with https://github.com/paritytech/trappist/issues/197

[x] Check that the try-runtime feature builds
[x] Run try-runtime on PRs marked with a migration label
[ ] Run try-runtime on a release

We may want to consider doing this for every commit as this is what this PR describes:

https://github.com/paritytech/polkadot/pull/7422

We also want this workflow to run on subsequent pushes.


Allow caller to provide RazorLightEngine

Today we provide a bunch of convenience methods to build out an engine, but we never allow the user to provide their own.
There are a lot of options being added to the RazorLightEngineBuilder and instead of trying to add an extension for every possible scenario, it will be helpful to allow the caller to provide their own.

Pushed a quick fix to some tabs/spaces issues in FluentEmailRazorBuilderExtensions.cs, this file is a weird mix of tabs and spaces. let me know if I should just convert that whole file to spaces while I am in there.

Pushed a quick fix to some tabs/spaces issues in FluentEmailRazorBuilderExtensions.cs, this file is a weird mix of tabs and spaces. let me know if I should just convert that whole file to spaces while I am in there.

Hold off on accepting this for now. We need to support more than just CompileRenderStringAsync in the ITemplateRenderer. We should allow rendering from a RazorLight Embedded Resource, or a RazorLight file.
For example, FluentEmail's UsingTemplateFromEmbedded circumvents the Razor Engine for its own assembly-hunting process.

Hold off on accepting this for now. We need to support more than just CompileRenderStringAsync in the ITemplateRenderer. We should allow rendering from a RazorLight Embedded Resource, or a RazorLight file.
For example, FluentEmail's UsingTemplateFromEmbedded circumvents the Razor Engine for its own assembly-hunting process.

This might not be needed since someone can call .UseTemplateEngine when composing the email.

This might not be needed since someone can call .UseTemplateEngine when composing the email.


Support pool invalidation

Force pool handles to be wasted. Available will be wasted on the method call. Used will be wasted on the next recycle.

Codecov doesn't work properly gcov shows different coverage.


remove DinD info (no longer needed) STO-7308

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screenshot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65fb982bf8d30d5ff8ea2bad--harness-developer.netlify.app


Compiler doesn't pick up var duplication caused by parent_type

/datum/beta
    var/poop
/datum/alpha
    var/poop
/datum/beta/parent_type = /datum/alpha

The above code causes a compile-time in BYOND (due to the duplicate var definition) but not in OD.
This is because setting the parent_type doesn't cause, like, some emitted event or something that re-scans the object definition for duplicates (now that its inheritance has been modified).
There's probably other weird behaviour in our parent_type impl beyond this.

Tested this with #1366. Still doesn't pick up the error, I think var definitions will have to be sorted by inheritance before being processed.


Add autoComplete option for the AutoComplete component Textfield

so we can pass down autoComplete props down to the Textfield component in the Autocomplete component
the default autocomplete of the browser textfield sometimes make the UI looks abit off..

@HriBB seems like something wrong with the packaging? im not sure why though.
pretty sure my code is correct now

@badoet yes looks like it. Tests are failing again. I guess there are a lot of old and deprecated dependencies.
I can look at it next week, but if you want, I can give you owner access to the repo, and you can fix it yourself ;)


migration complete log after every client command

this info log shows up after every client command after migrating client to v1:

@dpc

@Kodylow I checked out current master. I start just devimint-env and run fedimint-cli commands and I see no messages.


vitest 0.24.* breaks StyledComponents

Describe the bug
With vitest 0.23.4 styled-components work like expected.
After the update to 0.24.5 all testcases which use styled-components break with the exact same error.
FAIL  src/.../Footer.spec.tsx [ src/.../Footer.spec.tsx ]
TypeError: I.button is not a function
 ❯ ../../lalala/src/dist/lala-shared.es.js:81:17
     79|   desktop: `(min-width: ${yt.desktop})`,
     80|   desktopL: `(min-width: ${yt.desktop})`
     81| }, rn = I.button`
       |                 ^
     82|   display: flex;
     83|   align-items: center;

Reproduction
Footer.styled.ts
import styled from "styled-components";

export const VersionInfo = styled.div`
  visibility: hidden;
`

Footer.tsx
import {VersionInfo} from "Footer.styled";
import React from "react";

const Footer = () => {
    return

        <VersionInfo>{import.meta.env.VITE_VERSION}</VersionInfo>

Footer.spec.tsx
import { render } from "@testing-library/react";
import { describe, test } from 'vitest'
import '@testing-library/jest-dom'
import Footer from './Footer';

describe('Footer', () => {
  test('has created', (context: any) => {
    const rendered = render(); // <-- this fails with the error above
  });
})

strange info:
If I delete the Footer.styled.ts and change the Footer.tsx to
import {VersionInfo} from "Footer.styled";
import React from "react";
import styled from "styled-components";

export const VersionInfo = styled.div`
  visibility: hidden;
`

const Footer = () => {
    return

        <VersionInfo>{import.meta.env.VITE_VERSION}</VersionInfo>

then the test in Footer.spec.tsx works fine
System Info
System:
    OS: macOS 12.6
    CPU: (10) arm64 Apple M1 Pro
    Memory: 1.07 GB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.17.0 - ~/.nvm/versions/node/v16.17.0/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 8.15.0 - ~/.nvm/versions/node/v16.17.0/bin/npm
  Browsers:
    Chrome: 107.0.5304.87
    Safari: 16.0
  npmPackages:
    @vitejs/plugin-react: ^2.2.0 => 2.2.0
    vite: ^3.2.2 => 3.2.2
    vitest: ^0.24.0 => 0.24.5

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Can you provide a runnable minimal reproduction (stackblitz or git repo)? I can't combine your small peaces into reliable reproduction, you have some env variables, other packages and so on.

Sorry for the late answer, I had to look up the real problem myself.
I don't know the exact problem by now, but I was able to fix it.
styled-components was declared as external package in my vite.config under build.rollupOptions.external and was defined it under  build.rollupOptions.output.globals in my library project.
After removing both of them it seems to work fine. But I don't know what this has to do with the version change.
So there may be still an issue, but I'm not really able to write a reproduction for this.


webots.min.js: fix viewpoint reset and other improvements

Fix  #720.
I also fixed some other issues:

fix selection reset when moving the viewpoint
avoid two consecutive costly rendering when applying an animation pose (one for the scene updates and one for the viewpoint change)
fix buttons behavior in benchmark record windows

:+1:

👀


"I dream of being a website. Please star the parse-server repo on GitHub!" instead of "Please star the parse-server repo on GitHub!" and unauthorized from dashboard

I deployed parse server on heroku, a week earlier when I installed similar parse server, I got messgae "Please star the parse-server repo on GitHub!"
But now with new installation it says
"I dream of being a website. Please star the parse-server repo on GitHub!"
Why its different now and when I try to access it from dashboard it says
Server not reachable: unauthorized
I double checked the appID and masterKey
why its happening

This is why the text is updates -> https://github.com/ParsePlatform/parse-server-example/commit/5c1a7bca62ed1884a7d63ebc02e418a1748f4956
Triple-check appId, masterKey, mountPath and serverURL and try again.

I checked them again, they are same.
Is there a limit on length of keys, i am using almost 25 characters

I cloned the app from heroku
Don't why but my keys were not added so changed it
Now working from local dashboard atleat


Issue #SC-0000 fix: fixed post publish instruction event format

Codecov Report

Merging #606 into post-publish-processor will increase coverage by 0.28%.
The diff coverage is n/a.

@@                     Coverage Diff                      @@
##             post-publish-processor     #606      +/-   ##
============================================================
+ Coverage                     32.38%   32.66%   +0.28%
- Complexity                     1225     1232       +7
============================================================
  Files                           170      170
  Lines                         14981    14981
  Branches                       2371     2371
============================================================
+ Hits                           4851     4893      +42
+ Misses                         9406     9363      -43
- Partials                        724      725       +1

Impacted Files
Coverage Δ
Complexity Δ

.../ekstep/searchindex/processor/SearchProcessor.java
66.36% <0%> (+0.9%)
99% <0%> (ø)
:arrow_down:

...p/searchindex/elasticsearch/ElasticSearchUtil.java
47.94% <0%> (+4.38%)
52% <0%> (+3%)
:arrow_up:

...dex/transformer/AggregationsResultTransformer.java
100% <0%> (+100%)
4% <0%> (+4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d927626...f32af10. Read the comment docs.


doc: offline installation of microk8s

Description
This PR adds some clarification to offline microk8s instalaltion.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Refactor/improvement

How Has This Been Tested?
N/A
Checklist

[x] My commit message is conventional
[x] I have run pre-commit on all files before creating the PR
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have checked my code and corrected any misspellings

:tada: This PR is included in version 1.8.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Further refinement of moment interaction n_points, n_spacing when max_comp truncates M/N diagram?

@robbievanleeuwen, I've noted one peculiarity with the way the improvements to M/N curves have been implemented as merged in #66.
When dealing with a max_comp scenario or a proportionally lower upper limit, then when using n_points or n_spacing it puts in the evenly spaced points not between the limits being lower value of upper limit or max_comp, but over the entire default range and the unused points are truncated at max_comp. i.e. it just culls some of the points, rather than spacing the defined points between the refined limits if they were lower or higher once max_comp truncates the axial loads to consider for example.
This leads to some issues when plotting the results with a loss of fidelity in the curves due to a significantly reduced number of axial and moment points being returned.
So if you're using a relatively low max_comp, say for wall design where limits are much lower (in NZ for example singularly reinforced walls it can be as low as 0.015Agfc), then you only get a fraction of the points specified because of the significantly reduced axial load range, and potentially a very jagged plot as a result.
For example, this plot has low max_comp, but with default n_points = 24, because of the reduced range due to the upper limit only 6 intermediate points are plotted in addition to any defined control points, the others were truncated.

Resolution
I think it would potentially be as easy as distributing the points between the refined limits that will be returned from the method, rather than spacing them between the larger original range of axial load points. So if max_comp is lower than the axial load corresponding to the upper limit, redefine the upper limit as max_comp. Then generate the evenly spaced points between the revised limits for the full specified number of points being returned to maintain a "nice curve".
Hopefully, that's all clear and made sense!

@robbievanleeuwen, noted as well just now that the docstring in AS3600.moment_interaction_diagram also needs to be updated as it does not reference the updated limits or control point changes that were made. For example, docstring still references lower limit as being zero curvature tension, but you've redefined it as ("N", 0.0), similarly for the control points reference kappa0, but this is not included any more.


Avoid calling didChangeDependences on a State that has dropped out of the tree

Description
We document didChangeDependencies as being called right before build - but it's also getting called even if build never gets called. This is likely to cause extra work for widgets that subscribe to inherited widgets and then drop out of the tree, particularly if those widgets did not realize the expensive work being done in didChangeDependencies was being done even though they'd never build.
Related Issues
Fixes https://github.com/flutter/flutter/issues/34130 (/cc @rrousselGit - the implementation here is a slight modification of what you suggested in https://github.com/flutter/flutter/issues/34130#issuecomment-500220682)
Tests
I added the following tests:
Test that asserts didChangeDependencies is not called after a widget drops out of the tree.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.

Oh, and flutter_mobx broke too – with a more important bug for this one (with basically the same test).

Looking at the code you posted above I don't fully understand the purpose of that test. You could just move the try/finally from _HookElement.build() to _HookWidgetState.build(), which would get you the old behavior even with this change (and as far as I can tell from the example above doesn't break anything else).

That's impossible.
Element is in the scope of the library, State is in the user scope.
We can't ask all users to include a try/finally inside their build method. And it's not feasible to refactor it into a State subclass either.
And these answers miss the point. What do you think of:
void performRebuild() {
  ...
  Widget built;
  try {
    if (_didChangeDependencies) {
      _didChangeDependencies = false;
     didChangeDependencies();
    }
    built = build();
    debugWidgetBuilderValue(widget, built);
  }
  ...

Element is in the scope of the library, State is in the user scope.

That's not clear from the code you posted.
Anyhow, it looks like you found a solution.


WiX: Update the manifest to include SourceControl.dll

SourceControl has been made a shared library in
swiftlang/swift-package-manager#8124.

@compnerd PTAL
Corresponding PR:swiftlang/swift-package-manager#8124

Tested at https://ci-external.swift.org/job/swift-PR-build-toolchain-windows/5594/artifact/build/artifacts/


difference-of-squares test has no targetTestVersion

The test for difference-of-squares currently does not use the targetTestVersion const to sync up solutions with the tests. I believe a few others do not either. Should all the exercises be using these or is it the sort of thing that you only start using on a second version of a test?

I'll defer to the README's https://github.com/exercism/xgo#problem-versioning section on this point, added in #140 . It says

Each problem defines a const targetTestVersion in the test program

Since it does say "each", then it would appear that any problem that fails to define a targetTestVersion is in violation of the README.
Assuming we agree with the reasoning for having test versions (this is someone's opportunity to speak up, if you think they are not useful), they should be added or the sentence in the README should be changed.

I'd lean towards all exercises starting from a point of having a targetTestVersion that can be incremented as necessary.

The point of it is to sync up the exercise with the test to ensure we don't have users running their source file against a test that may cause incorrect fails or passes?
This looks like the kind of thing that may have been dropped then starter files we not provided with the exercises?
I can see an argument that if there has been no change to the test than the test version doesn't have to be checked (or is implicitly at 0), and if you change the initial test then you have to start using the targetTestVersion at 1.
Either way it is inconsistent in the code base and should probably be brought into alignment across the exercises. Either explicitly not needing it for the first version or requiring it across the board.

I agree, it should certainly be consistent across all the exercises. I think starting each exercise off with a testVersion, whether 1 or 0, is better than not having one, as the intention is to use it if there is ever a significant change to the exercise or it's tests. It's an indication there is some mechanism in place for accommodating changes to tests, rather than it coming into play only if there is a change.
I think this will also cause less confusion regarding some exercises having a testVersion and some not.

I can agree with that, explicit better than implicit.

I can get on adding all the test vars if if what we want to do.

Are you happy with this @petertseng?

Yup, we'd be glad to have them!

Good stuff, thanks for making this happen @tleen

Ok will do!

I noticed some inconsistency in the location for test version test. If there are no objections I will move the test version test function to be the first function in the test file, and keep the benchmark (where available) as the last?

If there are no objections I will move the test version test function to be the first function in the test file

@kytrinyx spoke about this October:

https://github.com/exercism/xgo/pull/401#discussion_r83198176
https://github.com/exercism/xgo/pull/403#discussion_r83205896
https://github.com/exercism/xgo/pull/404#discussion_r83207256

We could change that if we agreed to.
For the record, I have no argument to argue for either side, do as y'all wish.

... but in the absence of strong argument to the contrary, I would stick with the precedent set by Katrina.

OK will keep at bottom as @kytrinyx did, her reasoning is as good as any. I'll move any not at the bottom as part of this overhaul.

OK.
I had a question on whether "bottom" meant "below benchmarks" or "above benchmarks, but below all other non-benchmark tests" - #403 shows it as below benchmarks, I don't know if I have any other examples.
Note (don't know if you would or would not have done this without my saying it), it would probably be best for the sanity of the reviewers if a commit of "move all testTestVersion to bottom" were separate from a commit of "add testTestVersion to exercises that don't already have it".

Oh. I would put it above the benchmarks.

Does this also include moving the version tests out of the main test function as it is in some exercises (https://github.com/exercism/xgo/blob/master/exercises/allergies/allergies_test.go#L27)
Personally I think it's probably better to have the version test separate.
And one more thing, some of the version tests fail with Errorf, and some with Fatalf. As we're going for consistency here, maybe we should stick to the same for all exercises. My choice would be on Fatalf as I don't think there's any point in carrying on if there's a mismatch?

Yes I think we move to its own function with Fatalf.
Order should be:

specific tests
test version test
benchmark (if exists)

Would you rather see this committed monolithically: adding all the testversions for all exercises in one commit, then doing the functions for all of them as another?
Or would it be better to do all the necessary changes on a single exercise to bring it up to snuff and commit it on a per exercise basis? Looks like most of them will need some sort of update to get in sync with the rest.

I would do it per exercise, if you're updating particular files you might as well make all the changes needed.
Just one question before we get going on this. I understand the reasoning behind putting the TestTestVersion function after the exercise specific tests;

to keep it out of the way for the person reading it.

This though means that any exercise tests will be run before this version test, resulting in a test output showing failed exercise tests before a version mismatch, rather than the version mismatch shutting down the test suite before running tests that could be erroring due to this mismatch. Shouldn't the first test to pass be the one that is making sure you're running the correct tests for the exercise?

Visually that is how is reads, but I believe GO tests run in parallel. So location in this case doesn't matter. Moving it to the top would be more like a "Hey! This is an easy way it could fail look here first", but keeping it out of the way makes sense too.

So, after a little digging, it appears tests within a single package are run sequentially, unless marked with t.Parallel(), therefore is it worth ensuring the test version is correct before running any specific exercise tests?
What do you think @petertseng @kytrinyx ?

Looks like this has been subsumed into #470?

Sorry, I meant to mention something, I think we can keep this open until we've confirmed where we want to put the TestTestVersion functions, and difference-of-squares has been updated. I've opened up #470 just to have a place to keep track of all the exercises, and progress on updating each exercises test file.

My mental model of how the test version is used is that it's for the benefit of those reviewing the exercise once it is submitted. If I'm completing an exercise I don't think it matters much to me whether the version check comes first or last. Maybe y'all feel differently, so please share your experiences if you have any.
However, I will make this observation of https://github.com/exercism/xgo/pull/403#discussion_r83205896:

The tests execute in parallel, so it doesn't technically matter where it is

Given that y'all have discovered at https://github.com/exercism/xgo/issues/465#issuecomment-276061377 that they tests don't execute in parallel, does that change the premises on which the recommendation to put it at the bottom is made?

I think 9 times out of 10 it's not going to matter at all where this test is, and therefore having it towards the bottom is preferable. My concern is that 1 time a student spends their time trying to solve a problem that is down to a version mismatch rather than their code, frustration that would be avoided by the mismatch highlighted before the failing exercise tests.
Saying this though I'm happy to leave the version test towards the bottom and revisit this if necessary if it's highlighted by students as causing the problem I've outlined above.
I think I'm maybe making a mountain out of a molehill here, and for the time being we should leave it as @tleen describes here

@robphoenix that was my original thinking if the tests were running sequentially. Having a mismatch between the exercise solution and the tests could cause false negatives which would be awful for a person learning the language. Better to have the fact that somehow the test and the solution are potentially not compatible fail loud and clear ASAP.

Ok then, I don't think this is a little thing, once someone has read a few exercise test files with the TestTestVersion function at the beginning it will hopefully become so familiar as to be invisible, and will avoid much frustration.
So, unless there are any objections, let's put it up at the top of the test file.
I'll update #470 and if you want to submit a PR to close this issue @tleen?

Sure, I think #470 has been absorbed into this bigger overhaul. I'll probably do it on a per exercise basis?

Aye, that'd be grand, thanks.
Obviously don't feel you have to tackle all of them, or even any of them! #470 should enable this to be done as we go, with anyone pitching in as they are able and willing to.
Really appreciate this @tleen

Sounds good, will PR the first one as sort of the how-it-should-be-done example then bring the rest up to be consistent with that one.


Des-ops Feedback Hour

Hi Samuel!
I wanted to just opt if you want to buddy up on lottie-interactive so you're not the only person who's effectively working on it. I would love to make my personal iconset animated in design and code, and I would love to support the development of that a bit. I design in the front-end and mostly use Pinegrow for IRL design and development, and love everything SVG.
I'm currently making my own designer-first design system in front-end called RevolverDS; simply lock, load & ship your themed design system JIT. I wanted to think of a way how to standerdize theming & layering (SVG) artwork, and it works by simply assigning colors to "grounds", such as text-ground, vector-ground, line-ground, shadow-ground, etc... 12 in total that adhere to the cascade, with an optional B.O.U.W.-fork that puts things On, Under and With the Base (B.O.U.W.).
no need for more, simple & memorable straight-forwardness.
I think that would greatly help to systemize theming inside of lottie-files so in CSS you can do the actual designing of your themed system, using a system of layers & grounds to reference colors. I proposed this solution in Lottie-colorify which does just that, but this library is vastly more designer friendly than lottie-interactive and colorify combined.
Seeing your youtube videos I think it's a sensible collaboration. I don't know what your plans are but seeing some ideas date back a year, so feel free to drop me a line at<EMAIL_ADDRESS>if you wish to team up. Would love to make it even better.

Yep, imagine setting up a naming-covention in your svg’s, so you can target them in css because they are named layers. That’s what I would love to contribute to this library, as the convention is what it is about. No API or fancy CSS tooling, it’s a designer-first DS with a lot of help from locical properties.


[BUG] CSS from parent page leaking into CSUI (Vue)

What happened?
When building a basic CSUI (with Vue), default config - the CSS from the parent page is leaking into the shadow/root component. My understanding is this should not be the default behavior.
Image of result
Code:
<template>

This is a test

</template>

Version
Latest
What OS are you seeing the problem on?
MacOSX
What browsers are you seeing the problem on?
Chrome
Relevant log output
No response
(OPTIONAL) Contribution

[ ] I would like to fix this BUG via a PR

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems.

This is the case with tailwind since it consumes the same style. Simply add a namespace to your tw config


Uploading Bug Writing Tutorial

I initially thought to put it in the Knowledge Base, but the Tutorials folder seems more appropriate, now that I think of it. I'm moving it there.
Thanks for contributing.


Python client for AYS REST API

A Python client for the AYS RESTful API that doesn't require to install JumpScale
We (used to) have this raml specifcation for the Cockpit API: https://github.com/Jumpscale/jscockpit/blob/master/ays_api/specifications/api.raml
If this raml still in sync with the REST API of the AYS9?
Is it easy to create an independent Python client based on this?

For now you can use pip3 install aysclient :)


cleanup_django_defender has no effect

Hi,
I'm facing an issue with the cleanup_django_defender command. It says
Starting clean up of django-defender table Finished. Removed 0 AccessAttempt entries.
This is while I can see the list of my attempts over the web interface but not the block-list (empty).
All block functions work but unfortunately I can't delete entries manually due to the given error.
Thanks for helping me. Please let me know which additional information you need.

Please delete. Fatal mistake.


Flutter Web - Exceptions not sent in production environment

Platform:

[ ]  Dart
[ ]  Flutter Android or iOS
[X]  Flutter Web

IDE:

[X]  VSCode
[ ]  IntelliJ/AS
[ ]  XCode
[ ]  Other, which one?

split-debug-info and obfuscate (Flutter Android or iOS) or CanvasKit (Flutter Web):

[ ]  Enabled
[ ]  Disabled

Platform installed with:

[X] pub.dev
[ ] GitHub

Output of the command flutter doctor -v below:
[√] Flutter (Channel stable, 3.0.5, on Microsoft Windows [Versi¢n 10.0.19044.1889], locale es-ES)
    • Flutter version 3.0.5 at C:\DEVELOPMENT\SRC\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f1875d570e (6 weeks ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2

[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at C:\Users\USERNAME\AppData\Local\Android\sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[!] Visual Studio - develop for Windows (Visual Studio Build Tools 2017 15.9.30)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools
    • Visual Studio Build Tools 2017 version 15.9.28307.1321
    • Windows 10 SDK version 10.0.17763.0
    X Visual Studio 2019 or later is required.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 4.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code, 64-bit edition (version 1.70.2)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.46.0

[√] Connected device (4 available)
    • ONEPLUS A5010 (mobile) • <IP_ADDRESS>:5555 • android-arm64  • Android 10 (API 29)
    • Windows (desktop)      • windows           • windows-x64    • Microsoft Windows [Versi¢n 10.0.19044.1889]
    • Chrome (web)           • chrome            • web-javascript • Google Chrome 104.0.5112.102
    • Edge (web)             • edge              • web-javascript • Microsoft Edge 98.0.1108.50

[√] HTTP Host Availability
    • All required HTTP hosts are available

The version of the SDK (See pubspec.lock):
6.9.1

I have the following issue:
I'm only receiving the exceptions thrown while debugging the flutter web application. Once the application is deployed on the server (I'm using was amplify hosting) I'm not receiving any exceptions.
Any idea what I should look for?
Steps to reproduce:

Step

Actual result:

Actual

Expected result:

Result

I just found and resolved the underlying issue:

ASW Amplify Hosting has issues handling requests to files without an extension, in my case build/web/assets/NOTICES

Every time I tried to throw and catch an exception to be sent to Sentry, I saw that a 404 error was thrown because assets/NOTICES or assets/NOTICES/ was called.
By solving the 404 issue I was able to start receiving caught exceptions for my sentry project.
Just in case anyone else faces this issue in the future, here is my workaround: https://github.com/aws-amplify/amplify-hosting/issues/2374


Move common-utils from external repo into OpenSearch

Is your feature request related to a problem? Please describe.
Coming from https://github.com/opensearch-project/common-utils/issues/114, move common-utils into OpenSearch.

:-1:  for 2.0.0 it won't be ready:

There is a lot of legacy code that should be removed before refactoring to core
There is kotlin code that we need to tie in w/ the build hooks
The Integration Tests are Disabled w/ a note "Enable this after integration with security plugin is done" So why aren't we just integrating the appropriate classes with the security plugin?
There is no bwc integration and that will take some time to work out in core.

:+1:  for a future release if targeting core makes sense. We might want to integrate with security first (or dissolve the implementations across other plugins) then integrate security with core rather than blindly integrate with core.

Regarding the integration tests for common-utils. I believe it does not make sense to have any integration tests for the package since the only way to create one is for plugins that depend on the package to create integration tests to test different functionality such as ensuring the Alerting plugin can make calls to the Notification plugin through the data models available in the common-utils package.


Fixed fillna with Series

Closes https://github.com/dask/dask/issues/2809

[ ] Tests added / passed
[ ] Passes flake8 dask
[ ] Fully documented, including docs/source/changelog.rst for all changes
and one of the docs/source/*-api.rst files for new API

Looks good to me. Thanks @TomAugspurger.


hardening by the securityContext

What would you like to be added:
I've seen that the daemonset and the derived pods are using the:

securityContext: Privileged
runAsUser: 0

This give great privileges to the pods.
Could you work on hardening these pods by restricting as much the securityContext.
Why is this needed:
The moto of the security is : less is more.
Informations:
This ticket has a relation with #761

if you move to pos files to ephemeral volumes, every time a pod gets recreated, all logs will be re-read and re-sent to splunk,
on OpenShift privileged is also required to overrule SELinux restrictions.

yeah, i just figured out the hard way that it is not so simple ;-)
I wonder whether there is a way to "fix" this at all. And I do wonder whether the problem with this is as big as I imagine it to be.

In Opentelemetry collector, they have mounted host directory to the deamonset and stored checkpoints there. Also, they are using the init container with root privileges and provided read access to non-root use.
https://github.com/signalfx/splunk-otel-collector-chart/blob/99fa46a0c5e6f3158aa835a101fe9c173d01ef60/helm-charts/splunk-otel-collector/templates/daemonset.yaml#L135-L175


Changing the kernel doesn't work for Interactive

Environment data

VS Code version: 1.59.1
Jupyter Extension version (available under the Extensions sidebar): v2021.8.1236758218
Python Extension version (available under the Extensions sidebar): v2021.8.1159798656
OS (Windows | Mac | Linux distro) and version: Darwin x64 20.5.0
Python and/or Anaconda version: Python 3.8.8
Type of virtual environment used: conda
Jupyter server running: Local

Expected behaviour
After switching the kernel (from 3.8.5 to 3.8.8), the button "Run cell" should execute the code in the 'Interactive' window using the newly selected Python.
Actual behaviour
The editor proceeds to next cell, but the 'Interactive' window tries to execute it using the original kernel.
Running the code directly from the Type code here and press Enter (...) works as expected.
Steps to reproduce:
Make two Python installations available to the jupyter - a default one without ipykernel installed, and another one with an ipykernel. Change the kernel in the 'Interactive' window.
Everything works well if the default python has the IPyKernel installed.
Logs

IPyKernel error

Error 2021-08-25 12:38:03: DataScience Error [a [Error]: IPyKernel not installed into interpreter Python 3.8.5 64-bit:/usr/bin/python3
	at E.handleKernelDependencyResponse (/home/MCB/wwydmanski/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218/out/client/extension.js:90:247249)
	at E.installMissingDependencies (/home/MCB/wwydmanski/.vscode-server/extensions/ms-toolsai.jupyter-2021.8.1236758218/out/client/extension.js:90:246271)] {
  category: 'noipykernel',
  reason: 1
}

This is caused by the promise chaining we do. Pending promises aren't cleared when the kernel is changed, which causes all cells submitted from the Run Cell codelens to wait forever on this line:
https://github.com/microsoft/vscode-jupyter/blob/7f1c9d0bda398d5ae5cf175932ad808f85c7fa63/src/client/datascience/interactive-window/interactiveWindow.ts#L404


Pycharm: Argument name should be lowercase

btw you can set an argument whatever you want, or you can help me to change all examples in documentation to lowercase and you do pull request to me 😁. all examples inside folder ./examples @jet10000


Wiki page "Supported types" does not mention ConcatenatedString

Hi,
the Wiki page Supported types shows which JS type maps to which .NET type. The table contains an entry for JS type string which maps to .NET type System.String.
However, I found that sometimes Jurassic supplies an Jurassic.ConcatenatedString instead of a regular System.String when calling a function, if the JS string has been constructed using the + operator. E.g.:
    ScriptEngine engine = new ScriptEngine();
    engine.SetGlobalFunction("myFunc", new Action<object>(arg =>
    {
        Console.WriteLine(arg.GetType() + ": " + arg.ToString());
    }));

    engine.Execute(@"
myFunc('abc');
myFunc('ab' + 'c');
");

displays:
System.String: abc
Jurassic.ConcatenatedString: abc

I think this could be added to the wiki page to avoid confusion. (When the .NET declares the parameter as string Jurassic automatically converts it to a string, but not when declaring it as object which is sometimes needed if the function should allow parameters of different types.)
Should I add this to the Wiki page?
Thanks!

Yes, you're right, this is a bit of a trap.  ConcatenatedString is intended as a performance optimization, for when you are concatenating in a loop, like this:
s = "start";
for (var i; i < 15; i ++) { s += ", " + i; }
// do something with s

This results in only three strings (and a StringBuilder) being created, rather than the naïve approach, which creates ~30.
Rather than changing the docs, I would rather treat this as a bug and convert ConcatenatedString to a regular string before passing it to the user-defined function.
For now, you can use TypeUtilities.TypeOf() and TypeConverter.ToString() to deal with strings & concatenated strings in a generic way.  (There's also TypeUtilities.IsString() but that's internal...)


Max number of peers not enforced correctly

Description
It happens that Besu (without static peer configured) reports in the log a number of peers greather than the max allowed, for example the following log reports the number of peers to be consistently > 25 for hours:
{"timestamp":"2022-02-02T05:56:49,701","level":"DEBUG","thread":"EthScheduler-Timer-0","class":"WaitForPeerTask","message":"Waiting for new peer connection. 27 peers currently connected.","throwable":""}
{"timestamp":"2022-02-02T05:57:03,334","level":"DEBUG","thread":"EthScheduler-Services-716 (importBlock)","class":"WaitForPeerTask","message":"Waiting for new peer connection. 27 peers currently connected.","throwable":""}
{"timestamp":"2022-02-02T05:58:05,120","level":"DEBUG","thread":"EthScheduler-Services-721 (importBlock)","class":"WaitForPeerTask","message":"Waiting for new peer connection. 27 peers currently connected.","throwable":""}
[...]
{"timestamp":"2022-02-02T07:03:48,917","level":"DEBUG","thread":"nioEventLoopGroup-3-4","class":"WaitForPeerTask","message":"Finished waiting for peer connection.","throwable":""}
{"timestamp":"2022-02-02T07:03:53,440","level":"DEBUG","thread":"EthScheduler-Services-791 (importBlock)","class":"WaitForPeerTask","message":"Waiting for new peer connection. 27 peers currently connected.","throwable":""}
{"timestamp":"2022-02-02T07:03:58,440","level":"DEBUG","thread":"EthScheduler-Timer-0","class":"WaitForPeerTask","message":"Waiting for new peer connection. 27 peers currently connected.","throwable":""}
{"timestamp":"2022-02-02T07:04:03,440","level":"DEBUG","thread":"EthScheduler-Timer-0","class":"WaitForPeerTask","message":"Waiting for new peer connection. 26 peers currently connected.","throwable":""}

and calling admin_peers during at that time, actually returns 27 peers, see the response peers-over-quota-20220202-0605.txt
but at the same time, there is a discrepancy since the exported metric ethereum_peer_count returns 25 peers connected
indeed the graph of this metrics never goes over 25

this metric is exported by the RlpxAgent that could not track all the connections correctly
Expected behavior: [What you expect to happen]
Max number of connected peer is enforced
Actual behavior: [What actually happens]
some times the number of connected peer reported in the logs goes over the max configured
Versions (Add all that apply)

Software version: 22.1.0-RC4-SNAPSHOT
Java version: Java11

Hi @fab-10, we are looking into this as part of #2689. Closing it since it's a duplicate


Gah, this depends on https://github.com/rust-minidump/rust-minidump/pull/932


Icons in completion list is not vertically centered

VSCode Version: 1.6.0-insider (1.6.0-insider)
OS Version: macOS 10.12

Steps to Reproduce:

Type something
Completion list came up

Settings:
fontSize: 16,
lineHeight: 28
As image below:

#12029

Now the text is not vertically centered either.


Chembl compound-treats-disease edges have unexpected core_predicate

I note that this query against the Neo4j endpoint for RTX-KG2.8.1pre,
match (n)-[r]->(m) where r.core_predicate = 'biolink:treats' with r.knowledge_source as ks unwind ks as rr return distinct rr, count(*);

returns:
{
  "knowledge_source": [
    "infores:chembl"
  ],
  "negated": "False",
  "relation_label": "treats",
  "publications_info": "{}",
  "core_predicate": "biolink:affects",
  "subject": "CHEMBL.COMPOUND:CHEMBL4650305",
  "source_predicate": "biolink:treats",
  "predicate_label": "treats",
  "id": "CHEMBL.COMPOUND:CHEMBL4650305---biolink:treats---None---None---None---MESH:D000080362---identifiers_org_registry:chembl.compound",
  "update_date": "2022-07-12",
  "object": "MESH:D000080362"
}

which seems a bit odd. I wonder how the core_predicate value gets set to biolink:affects for this edge?  I wonder if there could/should be a rule (perhaps in predicate-remap.yaml?) that says that says, if a triple has source_predicate value biolink:treats, then the core_predicate should always be set to biolink:treats?

if the above remedy is not possible, I suppose we could (in chembl_mysql_to_kg_json.py) assign these edges to have source_predicate CHEMBL:indicated_for (a fictitious source predicate, to be sure) instead of biolink:treats, and then we could put a block in predicate-remap.yaml like this:
CHEMBL:indicated_for:
  operation: keep
  core_predicate: biolink:treats

would that work?

duplicate of #269


Add a tool to generate the TLS configuration form Mozilla's ciphers recommendation

This tool can generate the TLS configuration from Mozilla's ciphers recommendation and it can be invoked with go generate.
The configuration of TLS rule was generated using the tool. I updated also the README file with some instructions how to do this.
Fix #15
cc @gcmurphy

Awesome work!