[flutter_markdown] Null check operator used on a null value in MarkdownBuilder._buildRichText.(builder.dart:957)

(Same issue as #146282 which was reported back in April and closed by bot)
After updating my production app I've been getting crashlytics reports:
Fatal Exception: io.flutter.plugins.firebase.crashlytics.FlutterError: Null check operator used on a null value. Error thrown .
       at MarkdownBuilder._buildRichText.<fn>(builder.dart:957)
       at _SelectableTextState._handleSelectionChanged(selectable_text.dart:628)
       at EditableTextState._handleSelectionChanged(editable_text.dart:3976)
       at EditableTextState._formatAndSetValue(editable_text.dart:4184)
       at EditableTextState.userUpdateTextEditingValue(editable_text.dart:4554)
       at RenderEditable._setTextEditingValue(editable.dart:719)
       at RenderEditable._setSelection(editable.dart:738)
       at RenderEditable.selectWordsInRange(editable.dart:2117)
       at RenderEditable.selectWord(editable.dart:2098)
       at _SelectableTextSelectionGestureDetectorBuilder.onSingleLongTapStart(selectable_text.dart:105)
       at _TextSelectionGestureDetectorState._handleLongPressStart(text_selection.dart:3332)
       at LongPressGestureRecognizer._checkLongPressStart.<fn>(long_press.dart:703)
       at GestureRecognizer.invokeCallback(recognizer.dart:344)
       at LongPressGestureRecognizer._checkLongPressStart(long_press.dart:703)
       at LongPressGestureRecognizer.didExceedDeadline(long_press.dart:607)
       at PrimaryPointerGestureRecognizer.didExceedDeadlineWithEvent(recognizer.dart:724)
       at PrimaryPointerGestureRecognizer.addAllowedPointer.<fn>(recognizer.dart:667)

Fatal Exception: io.flutter.plugins.firebase.crashlytics.FlutterError: Null check operator used on a null value. Error thrown .
       at MarkdownBuilder._buildRichText.<fn>(builder.dart:957)
       at _SelectableTextState._handleSelectionChanged(selectable_text.dart:628)
       at EditableTextState._handleSelectionChanged(editable_text.dart:3976)
       at EditableTextState._formatAndSetValue(editable_text.dart:4184)
       at EditableTextState.userUpdateTextEditingValue(editable_text.dart:4554)
       at RenderEditable._setTextEditingValue(editable.dart:719)
       at RenderEditable._setSelection(editable.dart:738)
       at RenderEditable.selectPositionAt(editable.dart:2088)
       at RenderEditable.selectPosition(editable.dart:2065)
       at _SelectableTextSelectionGestureDetectorBuilder.onSingleTapUp(selectable_text.dart:145)
       at _TextSelectionGestureDetectorState._handleTapUp(text_selection.dart:3299)
       at BaseTapAndDragGestureRecognizer._checkTapUp.<fn>(tap_and_drag.dart:1198)
       at GestureRecognizer.invokeCallback(recognizer.dart:344)
       at BaseTapAndDragGestureRecognizer._checkTapUp(tap_and_drag.dart:1198)
       at BaseTapAndDragGestureRecognizer.acceptGesture(tap_and_drag.dart:996)
       at GestureArenaManager.sweep(arena.dart:167)
       at GestureBinding.handleEvent(binding.dart:499)
       at GestureBinding.dispatchEvent(binding.dart:475)
       at RendererBinding.dispatchEvent(binding.dart:425)
       at GestureBinding._handlePointerEventImmediately(binding.dart:420)
       at GestureBinding.handlePointerEvent(binding.dart:383)
       at GestureBinding._flushPointerEventQueue(binding.dart:330)
       at GestureBinding._handlePointerDataPacket(binding.dart:299)

I'm unsure where in my app this is being generated as the stacktrace seems entirely outside of my codebase. So until these customers contact me and report where in the app the problem is occurring I'm unable to create a reproducible example. As this issue was reported back in #146282 with the same error it seems to be a genuine bug. They highlighted the code:

It looks like onSelectionChanged is not always set?

Flutter doctor

[✓] Flutter (Channel stable, 3.22.1, on macOS 14.2.1 23C71 darwin-arm64, locale en-GB)
    • Flutter version 3.22.1 on channel stable at /Users/jimmyff/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision a14f74ff3a (2 weeks ago), 2024-05-22 11:08:21 -0500
    • Engine revision 55eae6864b
    • Dart version 3.4.1
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/jimmyff/Library/Android/sdk
    • Platform android-34, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.89.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.90.0

[✓] Connected device (4 available)
    • Pixel 5 (mobile)                • 09021FDD40027X        • android-arm64  • Android 14 (API 34)
    • macOS (desktop)                 • macos                 • darwin-arm64   • macOS 14.2.1 23C71 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin         • macOS 14.2.1 23C71 darwin-arm64
    • Chrome (web)                    • chrome                • web-javascript • Google Chrome 125.0.6422.142

[✓] Network resources
    • All expected network resources are available.

• No issues found!

@bogdannedelcu Did you get any further with your original issue reporting this? #146282

That parameter which is optional should be set. Then no more errors like
this.
It is indeed a bug in the code. Either correct the code or add mandatory to
the parameter.
În joi, 6 iun. 2024 la 17:42 Jimmy Forrester-Fellowes <
@.***> a scris:

@bogdannedelcu https://github.com/bogdannedelcu Did you get any further
with your original issue reporting this? #146282
https://github.com/flutter/flutter/issues/146282
—
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/149817#issuecomment-2152714604,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACAJSJA6QCGFSY4C45NVZP3ZGBYMTAVCNFSM6AAAAABI44ENE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJSG4YTINRQGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I've confirmed that setting the onSelectionChanged parameter fixes the exception.

@jimmyff Please check above possible solution and see if it helps in your case or not.

I'll add the parameter but also sent a PR with the fix

I observed a similar error log upon running below code sample and while trying to select text from the code blocks:
======== Exception caught by widgets ===============================================================
The following _TypeError was thrown while calling onSelectionChanged for SelectionChangedCause.longPress:
Null check operator used on a null value

When the exception was thrown, this was the stack:
#0      MarkdownBuilder._buildRichText.<anonymous closure> (package:flutter_markdown/src/builder.dart:966:35)
#1      _SelectableTextState._handleSelectionChanged (package:flutter/src/material/selectable_text.dart:628:32)
#2      EditableTextState._handleSelectionChanged (package:flutter/src/widgets/editable_text.dart:3972:34)
#3      EditableTextState._formatAndSetValue (package:flutter/src/widgets/editable_text.dart:4180:7)
#4      EditableTextState.userUpdateTextEditingValue (package:flutter/src/widgets/editable_text.dart:4550:5)
#5      RenderEditable._setTextEditingValue (package:flutter/src/rendering/editable.dart:719:27)
#6      RenderEditable._setSelection (package:flutter/src/rendering/editable.dart:738:5)
#7      RenderEditable.selectWordsInRange (package:flutter/src/rendering/editable.dart:2117:5)
#8      RenderEditable.selectWord (package:flutter/src/rendering/editable.dart:2098:5)
#9      _SelectableTextSelectionGestureDetectorBuilder.onSingleLongTapStart (package:flutter/src/material/selectable_text.dart:105:20)
#10     _TextSelectionGestureDetectorState._handleLongPressStart (package:flutter/src/widgets/text_selection.dart:3332:35)
#11     LongPressGestureRecognizer._checkLongPressStart.<anonymous closure> (package:flutter/src/gestures/long_press.dart:703:75)
#12     GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:344:24)
#13     LongPressGestureRecognizer._checkLongPressStart (package:flutter/src/gestures/long_press.dart:703:11)
#14     LongPressGestureRecognizer.didExceedDeadline (package:flutter/src/gestures/long_press.dart:607:5)
#15     PrimaryPointerGestureRecognizer.didExceedDeadlineWithEvent (package:flutter/src/gestures/recognizer.dart:724:5)
#16     PrimaryPointerGestureRecognizer.addAllowedPointer.<anonymous closure> (package:flutter/src/gestures/recognizer.dart:667:41)
#20     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)
(elided 3 frames from class _Timer and dart:async-patch)
====================================================================================================
D/EGL_emulation(14808): app_time_stats: avg=9575.93ms min=10.24ms max=19141.63ms count=2

 code sample

import 'package:flutter/material.dart';
import 'package:flutter_markdown/flutter_markdown.dart';

void main() => runApp(const App());

class App extends StatelessWidget {
  const App({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: Scaffold(
        body: SelectionArea(
          child: Center(
            child: MarkdownBody(
              selectable: true,
              data: '''
# Hello, Markdown!

`sudo dnf install xorg-x11-xauth`

env XDG_SESSION_TYPE=x11
''',
            ),
          ),
        ),
      ),
    );
  }
}


Clean up force_text/force_bytes/force_str calls.

This replaces force_text/force_bytes/force_str calls with either no call at all (yay!) or more explicit calls to encode().
I did this PR pretty methodically by having the force_* functions raise exceptions to generate failing tests, so all of the changes here have some test coverage.  (Of course, it's still plausible that some of these functions have strange codepaths that aren't tested, and there are code organization problems that are going to be exposed here.)
I stayed clear of making risky fixes to some codepaths I don't know well--basically the email mirror, oath stuff, and zephyr.

LGTM

Merged, thanks @showell!  Thanks for doing this audit.


New menus can't be reselected

Seems to be a bug in the UI. If you select a report, it remains selected and you can't click on it again (instead you have to refresh the page).

#142


ratbagd assert failure: double free or corruption (fasttop)

Ubuntu just popped up an "internal error" dialog due to a ratbagd crash; I can't seem to get actual text from it, so for now all I have is screenshots. I was not actively using ratbag/piper when the dialog appeared. I had opened piper a few minutes ago, looked through the dialog pages, and closed it without attempting to make any changes.
This is what I could find in journalctl:
Dec 01 15:20:48 frequency systemd[1]: Starting Daemon to introspect and modify configurable mice...
Dec 01 15:20:48 frequency systemd[1]: Started Daemon to introspect and modify configurable mice.
Dec 01 15:41:28 frequency ratbagd[6516]: double free or corruption (fasttop)
Dec 01 15:41:28 frequency systemd[1]: ratbagd.service: Main process exited, code=dumped, status=6/ABRT
Dec 01 15:41:28 frequency systemd[1]: ratbagd.service: Failed with result 'core-dump'.
Dec 01 15:41:28 frequency systemd[1]: ratbagd.service: Service RestartSec=100ms expired, scheduling restart.
Dec 01 15:41:28 frequency systemd[1]: ratbagd.service: Scheduled restart job, restart counter is at 1.
Dec 01 15:41:28 frequency systemd[1]: Stopped Daemon to introspect and modify configurable mice.
Dec 01 15:41:28 frequency systemd[1]: Starting Daemon to introspect and modify configurable mice...
Dec 01 15:41:28 frequency systemd[1]: Started Daemon to introspect and modify configurable mice.

Which device are you using?

Shoot, that would have been a smart thing to mention. I have a Logitech G703, being accessed via the wireless dongle. Please let me know if there's any log or system data that would be useful.

Which version of the G703? There are two, one with the hero sensor and one with other sensor IIRC.
Can you paste the output of dmesg | grep logitech?

dmesg output:
[    1.716674] logitech-djreceiver 0003:046D:C539.0003: hidraw2: USB HID v1.11 Keyboard [Logitech USB Receiver] on usb-0000:0b:00.3-1.1/input0
[    1.880746] logitech-djreceiver 0003:046D:C539.0004: hiddev2,hidraw3: USB HID v1.11 Mouse [Logitech USB Receiver] on usb-0000:0b:00.3-1.1/input1
[    1.940729] logitech-djreceiver 0003:046D:C539.0005: hiddev3,hidraw4: USB HID v1.11 Device [Logitech USB Receiver] on usb-0000:0b:00.3-1.1/input2
[    2.002776] logitech-djreceiver 0003:046D:C539.0005: device of type eQUAD Lightspeed (0x0c) connected on slot 1
[    2.116896] logitech-hidpp-device 0003:046D:4070.0006: input,hidraw5: USB HID v1.11 Keyboard [Logitech G703] on usb-0000:0b:00.3-1.1/input2:1
[  430.643132] logitech-hidpp-device 0003:046D:4070.0006: HID++ 4.2 device connected.
[21181.516031] logitech-hidpp-device 0003:046D:C087.0007: input,hidraw2: USB HID v1.11 Mouse [Logitech G703 Wired/Wireless Gaming Mouse] on usb-0000:0b:00.3-1.1/input0
[21181.580095] logitech-hidpp-device 0003:046D:C087.0008: HID++ 4.2 device connected.
[21181.702711] logitech-hidpp-device 0003:046D:C087.0008: input,hiddev2,hidraw3: USB HID v1.11 Keyboard [Logitech G703 Wired/Wireless Gaming Mouse] on usb-0000:0b:00.3-1.1/input1
[25767.536974] logitech-djreceiver 0003:046D:C539.0009: hidraw2: USB HID v1.11 Keyboard [Logitech USB Receiver] on usb-0000:0b:00.3-1.1/input0
[25767.598642] logitech-djreceiver 0003:046D:C539.000A: hiddev2,hidraw3: USB HID v1.11 Mouse [Logitech USB Receiver] on usb-0000:0b:00.3-1.1/input1
[25767.658138] logitech-djreceiver 0003:046D:C539.000B: hiddev3,hidraw4: USB HID v1.11 Device [Logitech USB Receiver] on usb-0000:0b:00.3-1.1/input2
[25767.717182] logitech-djreceiver 0003:046D:C539.000B: device of type eQUAD Lightspeed (0x0c) connected on slot 1
[25767.731819] logitech-hidpp-device 0003:046D:4070.000C: HID++ 4.2 device connected.
[25767.792537] logitech-hidpp-device 0003:046D:4070.000C: input,hidraw5: USB HID v1.11 Keyboard [Logitech G703] on usb-0000:0b:00.3-1.1/input2:1

Are you able to reproduce this?

Not so far. There was a kernel upgrade on December 2 from 5.3.0-23 to 5.3.0-24, not sure if a driver change could have resolved it? If it does reoccur for myself or anyone else at least we have this issue to refer back to, let me know if there's any other information that would help.

I think this was resolved by the latest commit in master, could you try?

I have version 0.12, would that contain the fix? I get it via the Ubuntu/Launchpad PPA.

Yes, can you confirm it works?

I poked it with piper and it hasn't crashed after 20 minutes, so it's tough to prove a negative but it seems to be behaving now. Thanks, much appreciated!


added new audio book feature using text-to-speech and pypdf2

⚠ IMPORTANT POINTS: ⚠

Give the PR an appropriate Title.
If you want to fix a lot of Issues together, please consider opening a Draft PR first and mention alL the issues in a list along with the status of the fix that you are working on.
Mention the IssueNumber in your PR if it is fixing an Issue with closes #IssueNumber.
Please provide sufficient information regarding the changes you have made.
Please read the CONTRIBUTION guidelines first otherwise your PR may not get merged.

@krishnasonune this feature was previously in pywhatkit but was removed


Install the CodeSee workflow.

This pull request adds the CodeSee workflow to your repository.
This workflow runs a code analysis on each time:

a new PR is opened
a new commit is pushed to an existing PR
a PR is merged or a new commit is pushed directly to the default branch

The analysis enables code visibility for your codebase: generating maps of your codebase, keeping existing maps up-to-date, and automating code workflows.
Access the CodeSee web app at https://app.codesee.io/ or learn more at https://docs.codesee.io. If you have any questions, please reach out to<EMAIL_ADDRESS>and we'll be happy to help.

:rocket: PR was released in v0.1.0 :rocket:


Fixed #26940 -- Removed makemessages from no_settings_commands whitelist

As makemessages uses several settings for proper run (FILE_CHARSET,
LOCALE_PATHS, MEDIA_ROOT, and STATIC_ROOT), we should require settings
configuration for this command.

Is the settings.configured condition in makemessages.py obsolete now?

Is the settings.configured condition in makemessages.py obsolete now?

Good point. However I even tried to make makemessages not dependent on USE_I18N in https://github.com/django/django/compare/master...claudep:makemessages_usei18n. Thoughts on this?

You no doubt understand whether or not that patch is correct better than I do.


Add Registry Resource Properties support

Purpose
This PR adds the Registry resource properties support to the Integration Tooling by providing a dedicated "Registry Resource Properties" wizard and by enabling to persist the registry resource properties in the artifact.xml file when properties are added or removed from the registry resources.  The new registry resource properties support is as follows in the artifact.xml.
artifact.xml
<?xml version="1.0" encoding="UTF-8"?>
  <artifacts>
  	<artifact name="testEndpoint2" version="1.0.0" type="synapse/endpoint"
  			groupId="com.example.resource" serverRole="EnterpriseServiceBus">
      <item>
          <file>AdminService.wsdl</file>
          <path>/_system/config/repository/wso2con/wsdl</path>
          <mediaType>application/wsdl+xml</mediaType>
          <properties>
              <property key='key1' value='propertyValue1'/>
              <property key='key2' value='propertyValue2'/>
          </properties>
      </item>
  	</artifact>
  	<artifact name="testEndpoint3" version="1.0.0" type="synapse/endpoint"
  			groupId="com.example.resource" serverRole="EnterpriseServiceBus">
  		<collection>
          <directory>emptyFolder_4</directory>
          <path>/_system/governance/custom/emptyFolder_4</path>
          <properties>
              <property key='key1' value='propertyValue1'/>
              <property key='key2' value='propertyValue2'/>
          </properties>
      </collection>
  	</artifact>
  </artifacts>

Related PRs:
https://github.com/wso2/micro-integrator/pull/1993

Please do not merge!

Let's document this feature along with the use-cases.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.sajiniekavindya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Moved https://github.com/wso2/integration-studio/pull/630


how to converts http protocol into the webservice protocol?

Question
How to convert http protocol to webserice protocol? Is there plugin support for this?

Question
How to convert http protocol to webserice protocol? Is there plugin support for this?

divide plugin

Question
How to convert http protocol to webserice protocol? Is there plugin support for this?

divide plugin


Hosted version disappeared

Hi, it was hosted here https://grafana-plugins-web-vgmmyppaka-lz.a.run.app/ but it's gone now. Can I find it somewhere? Thanks!

Yes, we finally got around to create a decent URL for it 😅
https://plugin-validator.grafana.net
It's also documented in the README in case you need to find it again.

Thank you.
BTW in this repository it does not seem to be in readme 🤔

Good catch! We should add it to that repository as well! 💯


WebSockAdapter.UpgradeError

Hello there 👋🏼
In #14 (released as 0.5.5), a change was made to the way websocket connections are validated (I understand it to be that upgrade MUST be a part of the Connection header now). Although this change is aligned with the spec, it caused a notable change in our application's error rate immediately after deploy.
Unfortunately, we are completely unsure when a client would send Connection: Keep-Alive to that endpoint, but it happens often. (Do you know of any reason why a socket connection initiated by phoenix.js might do that?) We are certain that it is a websocket client making the erroneous request — not a rogue crawler or anything like that — because the request includes our authorization token and vsn param. A small sample size of requests have shown Chrome on Windows as the user agent (but the sample size is much too small to be a significant indicator).
Because we can't pinpoint the source of the erroneous request, we also can't know whether the request was being served successfully previously. The WebSockAdapter.UpgradeError doesn't appear to replace any older errors in our tracing, so the outcome of these requests before the change is unclear.
To make this actionable, here are two points:

Could you please consider changes like the introduction of WebSockAdapter.UpgradeError to be breaking changes in the future? Despite the closer alignment with the spec, it was effectively a breaking change for our application.
Are you aware of any situation in which a websocket client (ex. phoenix.js) would send Connection: Keep-Alive to /socket/websocket?

Thanks for your help!

Thanks for the issue!
To your points:

We can / should do this; I agree that this could have been handled better. There was some agony internally about whether to enable this flag by default & the thinking was that pushing towards conformance made possible breakage worthwhile; the homogeneity of clients means that any regressions would probably be apparent early; it looks like you just drew the short straw here.

The spec doesn't entirely seem to be explicit here. The relevant clause is RFC6455§4.1/6, which says

The request MUST contain a |Connection| header field whose value
MUST include the "Upgrade" token.

Specifically, the distinction is whether 'include' means 'equals' or 'contains, possibly comma separated from other values'. Usage of the term is inconsistent elsewhere in the document; some (non-normative) sections use it in a sense which is obvious equivalent to 'equals', whereas other sections use the separate term 'value must equal' to describe equality.
As implemented today, we consider it to mean equals, but Cowboy's implementation interprets it as `contains'.
Setting aside the logical inconsistency of a connection header containing both 'upgrade' and 'keep-alive', I think it's reasonable for us to move to a 'contains' semantic for the connection and upgrade header clauses. I'll get a PR & release cooked up with this shortly.
Thanks for the issue!

https://github.com/phoenixframework/phoenix/pull/5621 up for review that will result in upgrade failures coming back to the client as 400s with actionable error descriptions.

Hi there!
Thanks for talking me through it. It's good to know this isn't a regression, and very interesting that users have been having this experience for so long with no reported issues.
The evidence I have available right now is sparse:

The offending queries have our authorization token and vsn params attached (with valid values), as mentioned before.
We do observe what appears to be some retry behavior, with attempts using the same authorization token between 2–5sec apart.
The handful of requests we were able to check manually were by users who primarily use Chrome on Windows, but no specific version (Chrome 97–118, Windows 7–11).

Given that the user experience is unchanged, we may deploy this again with errors silenced in our tracking so that we can check additional user agents.

Thanks for the update. I continue to suspect that the root cause here is some sort of (possibly long standing) bug in phoenix.js.
https://github.com/phoenixframework/phoenix/pull/5621 is merged upstream and once deployed will surface the errors to the client; hopefully that makes it easier to diagnose.

In the meantime, feel free to close this! We'll adopt the new version of phoenix.js as soon as we can.

Sounds good. Thanks for the issue!


Enhancement: only upload blocks if merger needs them

If I set mindreader-node-merge-threshold-block-age, then mindreader will sometimes merge blocks and sometimes not. The location to upload files to is either: common-oneblock-store-url or common-blocks-store-url.
It would be more efficient to skip merging and uploading entirely if the merger doesn't need them.
Currently mindreader can sync with blockmeta to understand where the chain is at, but it doesn't understand where the merger is at.  If there was a way mindreader could understand merger's status then it could avoid sending blocks that are not required.

The blockmeta (with its database, etc.) is not part of the "modern, lean" version of firehose, so we don't want to depend on it or build more features around it at the time.
The merger is able to easily skip/delete blocks that are too old, or to ignore blocks that are way ahead.
I'm not sure what you are trying to "save" by skipping the upload of merged files...

I'm only trying to save processing load.  If you have an infrastructure that is just booting up (after a crash or whatever), then things are very overloaded as things get in sync. The more 'unecessary' processing load that can be removed, the better (speaking from an operations point of view).
This is low priority.

Just to be clear, we didn't deploy blockmeta service for SF (only there for older dfuse), so not asking for it to come back. ;-)

Closing, every thing is found under https://github.com/streamingfast/firehose-core now anyway. Going to make this repo read-only.


Installation fails. Redirects to non-existing "requirements" dir

Just cloned the master, and when trying to run the setup after accepting the license agreement I am redirected to the 'requirements' directory which does not exist.
In function 'license()':
34        if ($this->input->post('licence_agreed')) {
35            $this->session->set_tempdata('setup_step', 'requirements', $this->setup_timeout);
36	            redirect('requirements');
37	        }

Fixed with "AllowOverride All" in my apache configuration.


Updated copyright headers for Root project, API, and Core

Description
Updates to copyright headers to parts of the project:

Gradle files in root directory
data-prepper-api
data-prepper-core

Issues Resolved
[List any issues this PR will resolve]
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #569 (565c87e) into main (90f3427) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #569   +/-   ##
=========================================
  Coverage     92.28%   92.28%
  Complexity      569      569
=========================================
  Files            71       71
  Lines          1725     1725
  Branches        144      144
=========================================
  Hits           1592     1592
  Misses          102      102
  Partials         31       31

Impacted Files
Coverage Δ

.../com/amazon/dataprepper/metrics/PluginMetrics.java
100.00% <ø> (ø)

.../com/amazon/dataprepper/model/CheckpointState.java
100.00% <ø> (ø)

.../java/com/amazon/dataprepper/model/PluginType.java
100.00% <ø> (ø)

...mazon/dataprepper/model/buffer/AbstractBuffer.java
100.00% <ø> (ø)

...ataprepper/model/buffer/SizeOverflowException.java
100.00% <ø> (ø)

...dataprepper/model/configuration/PipelineModel.java
100.00% <ø> (ø)

...n/dataprepper/model/configuration/PluginModel.java
100.00% <ø> (ø)

...dataprepper/model/configuration/PluginSetting.java
100.00% <ø> (ø)

.../dataprepper/model/event/DefaultEventMetadata.java
100.00% <ø> (ø)

.../com/amazon/dataprepper/model/event/EventType.java
100.00% <ø> (ø)

... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f3427...565c87e. Read the comment docs.


[Flow layout] Add RTL support to Flow Layouts

Fixes #1073
📸 Screenshots (Previews)

LTR
RTL

FlowRow Start/Center/End (no overflow)

FlowRow Start/Center/End (overflow)

FlowColumn Start/Center/End (no overflow)

FlowColumn Start/Center/End (overflow)

Preview Code
The following code was used to generate the preview screenshots:
/*
 * Copyright 2022 The Android Open Source Project
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      https://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package com.google.accompanist.sample.flowlayout

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxHeight
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.size
import androidx.compose.material.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.CompositionLocalProvider
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.platform.LocalLayoutDirection
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.tooling.preview.PreviewParameter
import androidx.compose.ui.tooling.preview.PreviewParameterProvider
import androidx.compose.ui.unit.LayoutDirection
import androidx.compose.ui.unit.dp
import com.google.accompanist.flowlayout.FlowColumn
import com.google.accompanist.flowlayout.FlowCrossAxisAlignment
import com.google.accompanist.flowlayout.FlowMainAxisAlignment
import com.google.accompanist.flowlayout.FlowRow

@Preview(backgroundColor = 0xFFFFFF)
@Composable
internal fun FlowRowNoOverflowPreview(
    @PreviewParameter(LayoutDirectionPreviewProvider::class) layoutDirection: LayoutDirection,
) {
    CompositionLocalProvider(
        LocalLayoutDirection provides layoutDirection,
    ) {
        FlowRowPreview()
    }
}

@Preview(backgroundColor = 0xFFFFFF, widthDp = 70)
@Composable
internal fun FlowRowOverflowPreview(
    @PreviewParameter(LayoutDirectionPreviewProvider::class) layoutDirection: LayoutDirection,
) {
    CompositionLocalProvider(
        LocalLayoutDirection provides layoutDirection,
    ) {
        FlowRowPreview()
    }
}

@Preview(backgroundColor = 0xFFFFFF, heightDp = 150)
@Composable
internal fun FlowColumnNoOverflowPreview(
    @PreviewParameter(LayoutDirectionPreviewProvider::class) layoutDirection: LayoutDirection,
) {
    CompositionLocalProvider(
        LocalLayoutDirection provides layoutDirection,
    ) {
        FlowColumnPreview()
    }
}

@Preview(backgroundColor = 0xFFFFFF, widthDp = 337, heightDp = 60)
@Composable
internal fun FlowColumnOverflowPreview(
    @PreviewParameter(LayoutDirectionPreviewProvider::class) layoutDirection: LayoutDirection,
) {
    CompositionLocalProvider(
        LocalLayoutDirection provides layoutDirection,
    ) {
        FlowColumnPreview()
    }
}

@Composable
private fun FlowRowPreview() {
    Column {
        sequenceOf(
            FlowMainAxisAlignment.Start,
            FlowMainAxisAlignment.Center,
            FlowMainAxisAlignment.End,
        ).forEach {
            FlowRow(
                modifier = Modifier.fillMaxWidth(),
                mainAxisAlignment = it,
                crossAxisAlignment = FlowCrossAxisAlignment.Center,
            ) {
                PreviewBoxes()
            }
        }
    }
}

@Composable
private fun FlowColumnPreview() {
    Row {
        sequenceOf(
            FlowMainAxisAlignment.Start,
            FlowMainAxisAlignment.Center,
            FlowMainAxisAlignment.End,
        ).forEach {
            FlowColumn(
                modifier = Modifier.fillMaxHeight(),
                mainAxisAlignment = it,
                crossAxisAlignment = FlowCrossAxisAlignment.Center,
            ) {
                PreviewBoxes()
            }
        }
    }
}

@Composable
private fun PreviewBoxes() {
    Text(
        modifier = Modifier
            .size(25.dp, 25.dp)
            .background(Color.Red),
        text = "1",
    )
    Text(
        modifier = Modifier
            .size(50.dp, 50.dp)
            .background(Color.Green),
        text = "2",
    )
    Text(
        modifier = Modifier
            .size(25.dp, 25.dp)
            .background(Color.Blue),
        text = "3",
    )
}

internal class LayoutDirectionPreviewProvider : PreviewParameterProvider<LayoutDirection> {
    override val values = sequenceOf(
        LayoutDirection.Ltr,
        LayoutDirection.Rtl,
    )
}

@googlebot I signed it!

This is what we need too. Please check :(

Thank you so much for this contribution. Sorry this has taken so long to get back to you. We have been working behind the scenes to start upstreaming this to Compose main as can now be seen on goo.gle/compose-roadmap. As such we are no longer accepting PRs to FlowLayout.
Sorry again we couldn't get this in.

I think this need to merge


Bug - Android cannot import the module

Hi, i'am using:
react-native 0.44
react-native-fetch-blob 0.10.8
And when i only use this:
import RNFetchBlob from "react-native-fetch-blob"
I got that error:
Attemp to invoke virtual method "java.io.Filejava.io.File.getParentFile()" on a null object reference

In ios everything work perfect.

I think it would help a lot if you could include the particular piece of code that caused it. fs.writeFile is just one of four locations (and functions) in the code where that method is called, just to give an example.

I'll close this for now. Feel free to reopen with new information.


Remove duplicate function recruitment

Created during some earlier refactoring. Removing in favour of recruitment_rate

@Zapiano could you do a quick review before our meeting please?


P2P call sample: remote peer video is blank

In P2P call local stream renders but remote render as grey.
How to fix this ?

Found similar question

Found similar question

Tried solution given in https://github.com/flutter-webrtc/flutter-webrtc-demo/issues/88
Used real devices instead of emulators but still _remoteRender is just blank or grey

Tried solution given in https://github.com/flutter-webrtc/flutter-webrtc-demo/issues/88
Used real devices instead of emulators but still _remoteRender is just blank or grey

@ycherniavskyi @CoreyCole @vasopikof @LinusU help

@ycherniavskyi @CoreyCole @vasopikof @LinusU help

Use setState(() { }); to set srcObject of RTCVideoRenderer
`signaling.onAddRemoteStream = ((, stream, role) {
print(_net.user.registerCode + ' onAddRemoteStream ' + role);
print(' stream.id ' + stream.id.toString());
    setState(() {
      if (role == "USER") _userRenderer.srcObject = stream;
      if (role == "STAFF") _staffRenderer.srcObject = stream;
      if (role == "AMBULANCE") _ambulanceRenderer.srcObject = stream;
    });
  });`

Thanks @s7070099, Added setState() but now i get black square instead grey so still not working.

Thanks @s7070099, Added setState() but now i get black square instead grey so still not working.

signaling.onLocalStream = ((, stream) {
_localRenderer.srcObject = stream;
    setState(() {});
  });

  _signaling.onAddRemoteStream = ((_, stream) {
    _remoteRenderer.srcObject = stream;

    setState(() {});
  });

 Is enough for fix grey screen issue

maybe i have different problem
when running sample
i cant get list i dont know why maybe because this
fyi already using web and work

Any solution for gray screen issue?

       _localRenderer.srcObject = stream;

       setState(() {}); // ADD THIS
     });

     _signaling.onAddRemoteStream = ((_, stream) {
       _remoteRenderer.srcObject = stream;

       setState(() {}); // AND ADD THIS
     });

Is enough for fix grey screen issue

It WORKS! Thanks very much! 😁

       _localRenderer.srcObject = stream;

       setState(() {}); // ADD THIS
     });

     _signaling.onAddRemoteStream = ((_, stream) {
       _remoteRenderer.srcObject = stream;

       setState(() {}); // AND ADD THIS
     });

Is enough for fix grey screen issue

this worked. Thanks.

for me the problem is true value in _invitePeer function, true is screen sharing and false is a camera, and I don't check this value and screen sharing don't work for me and I don't see any permission error, That's why the screen was completely black

https://github.com/flutter-webrtc/flutter-webrtc-server/blob/2b074d179507197307127b65270c1e1286de192d/pkg/turn/turn.go#L19
I encountered and solved the problem that the remote video is not displayed, but this solution is only for the problem caused by the use of dome.cloudwebrtc.com. This is just because the turn service of the dome.cloudwebrtc.com server source code is set to a local loopback instead of public network exposure.


Upgrade upload/download artifact actions in release workflow

Summary
This PR upgrades the upload and download artifact GitHub actions to v4 for the release workflow.
Upgrading the release workflow isn't as straightforward because it relies on the fact that the v3 action automatically merges artifacts with the same name.
The existing release workflow merges all wheels and binaries into two artifacts and downloads these in the publish step.  There are two ways of how we can implement this with the new actions where one is safer and the other avoids storing the artifacts twice:
We can either be bold and use
      - uses: actions/download-artifact@v4
        with:
          pattern: binaries-*
          path: binaries
          merge-multiple: true

This should download all binaries artifacts and merge them in the binaries path. See the action example.
That's what the current implementation uses, but I can't test the workflow without shipping a release...
The safer approach (testable) is to use one additional step that merges all artifacts and reuploads them as a single archive:
  merge-artifact:
    name: Merge Wheel and Bianaries
    runs-on: ubuntu-latest
    needs:
      - macos-universal
      - macos-x86_64
      - windows
      - linux
      - linux-cross
      - musllinux
      - musllinux-cross
    steps:
      - name: Merge Wheels
        uses: actions/upload-artifact/merge@v4
        with:
          name: wheels
          pattern: wheels-*
      - name: Merge Binaries
        uses: actions/upload-artifact/merge@v4
        with:
          name: binaries
          pattern: binaries-*

I verified that the step produces the same artifact as the existing workflow. However, it means we upload each artifact twice: Once as its own archive and once as a merged archive.
I went with the first approach.... With the risk that we have to fix it during the next release.
Closes of https://github.com/astral-sh/ruff/issues/9527
Test Plan

Lol wait no... I'm not done yet and there's some discussion to be had.

Also https://github.com/astral-sh/uv/issues/1943

Also astral-sh/uv#1943

Let's see how this goes first :laughing:


Add VirtualMachine Details section to Instancetypes tab

📝 Description
This PR adds the VirtualMachine Details section to the Instancetypes tab. It does not include the SSH section. That will be added in a separate PR.
🎥 Screenshot
Empty

Filled in

@metalice @upalatucci @hstastna PTAL

/lgtm


Fix compile issue with latest rust

Awesome lib. I really want to use with my own projects but it doesn't seem to compile with 1.0 alpha.

Looks like I wasn't on the latest rustc :(.  Working on it.

Oh, thanks for fixing that!


Adding AST parser to PinotQuery insider BrokerRequest

Per issue: https://github.com/winedepot/pinot/issues/14.
This PR will traverse all the PQL parsed AST nodes and update PinotQuery.
Similar to updateBrokerRequest, this PR implements updatePinotQuery to populate all the required fields of pinotQuery then put pinotQuery into BrokerRequest.
Test cases cover existing PQLs conversion as well as the correctness of PinotQuery fields setup

Codecov Report

Merging #17 into develop will decrease coverage by 8.53%.
The diff coverage is 84.32%.

@@              Coverage Diff              @@
##             develop      #17      +/-   ##
=============================================
- Coverage      64.04%   55.51%   -8.54%
  Complexity         4        4
=============================================
  Files           1044     1044
  Lines          53467    53601     +134
  Branches        7600     7622      +22
=============================================
- Hits           34245    29756    -4489
- Misses         16884    21616    +4732
+ Partials        2338     2229     -109

Impacted Files
Coverage Δ
Complexity Δ

...t/pql/parsers/pql2/ast/BooleanOperatorAstNode.java
27.77% <0%> (-3.48%)
0 <0> (ø)

...pache/pinot/common/utils/request/RequestUtils.java
79.66% <100%> (-16.34%)
0 <0> (ø)

...ache/pinot/pql/parsers/pql2/ast/HavingAstNode.java
100% <100%> (ø)
0 <0> (ø)
:arrow_down:

...pache/pinot/pql/parsers/pql2/ast/WhereAstNode.java
100% <100%> (ø)
0 <0> (ø)
:arrow_down:

...che/pinot/pql/parsers/pql2/ast/GroupByAstNode.java
100% <100%> (ø)
0 <0> (ø)
:arrow_down:

...ava/org/apache/pinot/pql/parsers/Pql2Compiler.java
72.72% <100%> (+0.76%)
0 <0> (ø)
:arrow_down:

...ot/pql/parsers/pql2/ast/StarColumnListAstNode.java
100% <100%> (ø)
0 <0> (ø)
:arrow_down:

...che/pinot/pql/parsers/pql2/ast/OptionsAstNode.java
100% <100%> (ø)
0 <0> (ø)
:arrow_down:

...ache/pinot/pql/parsers/pql2/ast/SelectAstNode.java
96.34% <100%> (+0.68%)
0 <0> (ø)
:arrow_down:

.../pql/parsers/pql2/ast/OutputColumnListAstNode.java
70% <100%> (+7.5%)
0 <0> (ø)
:arrow_down:

... and 349 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9751e3c...600169d. Read the comment docs.

Add a description and link it to the issue.

Do you mean it's one literal with all values in the IN clause?

Either that or split the literal on ", " and set it as a list. Pinot handles both cases I think.  But list is better since we dont have to pay the splitting cost for every segment.


Master

这个pr改了什么呀

你好，咱们项目推出数字通证饺子token，https://github.com/lipangit/JZT， 给所有提交过pr的朋友30000个JZT，表示对你过去对项目支持的感谢。
请下载币威钱包https://www.bitcv.app/，把里面的以太坊地址给我，币威的地址站内转账不需要手续费。这东西值不值钱不重要，玩的是信仰。
Hello, let's launch the JiaoZiToken, https://github.com/lipangit/JZT, and give all the friends who submitted pr 30,000 JZT, thank you for your support of the project.
Please download the coin wallet https://www.bitcv.app/?from=bitcvCom and give me the address of the Ethereum. There is no charge for transferring money at the address station, if you do not know Chinese , you can give me other address of the eth. It is not important that the value of this thing is worthless. It is faith.


feat: implement channels:rename

This is a suite of new files and modifications that creates a new channels command topic. The channels:rename command is implemented and tested, along with associated API adapters and types.

Closing in favour of #22.


GH-36680: [Python] Add missing pytest.mark.acero

Rationale for this change
test_invalid_non_join_column depends on Acero.
What changes are included in this PR?
Add @pytest.mark.acero.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.

Closes: #36680

@github-actions crossbow submit example-python-minimal-*


Add Circle CI

Add Circle CI early on.

add sample node, mocha + chai tests and python, unittest tests
add circle.yml, configure multi-language build
add heavy dependencies for early caching
add badge

Done for now


Move examples in separate folders

Why advantage does it bring? We still have the same amount of entries in the source folder but now we have more levels.

The advantage of the intermediate step is indeed limited. It is not true though, that we have the same amount of entries, you probably forgot about the ui files.
The next step would be to add one README per example.
I would then suggest to discuss within a follow-up issue:

If we really want to keep all examples
How we could structure them, so that especially newcomers know where to look.

The next step would be to add one README per example.

And to also add a screenshot to each UI example.
I think overall this makes going through the examples much more friendly and less confusing for users. There's not just a collection of source files but a proper overview and pre-example documentation, and everything belong to an example is in the same directory instead of having everything put together.

I think CI will be fixed as soon as https://github.com/gtk-rs/gtk-rs/pulls is merged and I rebased.

@sdroege you requested a review, this is still a a draft PR though.
One other thing, I don't really know how to resolve the gir conflict.

One other thing, I don't really know how to resolve the gir conflict.

Reset it to the version that is in master :)

@sdroege you requested a review, this is still a a draft PR though.

It would still be good to get some opinions on it before it's finished IMHO

Reset it to the version that is in master :)

Could you please tell me the command?
The web does not seem to be very helpful here.

Just rebasing on top of master should fix this already in your case.

So, overall this seems nice. Now I have a big issue with adding images directly in this repository. It increases the size a lot for finally small gain. I like the idea of having screenshots though, so if someone has an idea on how to go around this issue...

So, overall this seems nice. Now I have a big issue with adding images directly in this repository. It increases the size a lot for finally small gain. I like the idea of having screenshots though, so if someone has an idea on how to go around this issue...

Git-lfs
Not sure if adding images which don't change are a big problem though

On the repository definitely. I don't want to download images to update code. Also, unless stricly needed, we'd better stay as far away as possible from git-lfs.

Host the images on a website and link them there.
I would like to mention that most screenshots were already there, so the repo size would only shrink if we change history (unless I misunderstand how git works)

Also, unless stricly needed, we'd better stay as far away as possible from git-lfs.

Wouldn't mind if you'd have the same policy for git submodules :P

I would like to mention that most screenshots were already there, so the repo size would only shrink if we change history (unless I misunderstand how git works)

Damn, I didn't clean up things before merging repositories... T_T
git submodules are necessary evil here. :p

Not sure why the regen check fails.
Hints would be very welcome :)

Apart from the CI failure it is ready for review now.

The CI failure should be gone if you rebase on top of latest master

@GuillaumeGomez What do we do with the images? They're there already so let's keep them for now and get rid of them at a later time separately?

For the existing images, there is nothing to do unless rewriting the whole history. But I really don't know if this is a good idea to add new ones...

Doesn't seem like much of a problem to me, they're small and not changing often.

30KB x the number of added images is definitely not small in a git repository. I really don't know what to do here...

How much is it in sum that is added as part of this PR?

Around 88KB.

Why are we even talking about this then?

I rebased and squashed the commits now.
I hope that the CI is fine now and that we can move the binaries discussion to a separate issue.

regen check still fails :(

If one of you knows a magic command which might fix the CI, please feel free to push to this branch.

I assume this already fails before your PR then, i.e. master currently fails the CI. There's nothing in your PR here that should break it.

Just rebasing on master should be enough for the failure so that's not a problem. I'm really sad not having see the images before. Well, what's done is done. Thanks for moving the examples, I really like how they look now!

Thanks for moving the examples, I really like how they look now!

Glad to hear that you like it as well :)


MAISTRA-1648: Add CI script

It's invoked by the prow job.

The test passed! (See the checks, proxy_2.0-unit job). It currently builds and run unit tests. It took 1h40m.
Once this is merged, we can trigger it on https://github.com/maistra/proxy/pull/39 and make it required.


Error with mapping and last value

Hello
First congratulations for the plugin is very useful.
I'm having trouble with the mapping for some text items and does not receive the correct current value.
I tried to grafana 2.0 and 2.1 and versions 2.0.0 and 2.0.1 plugin
Since already grateful for your attention

Hello! Check Max data points parameter. By default It sets to 100 in Singlestat panel (it's Grafana-specified behavior). And if you sets time period which returns more than 100 points downsampling will be used. Try to increase this parameter.

Did not work. I decreases the range time to match the recent zabbix data but also there was no change.

Which value you expect? Is it integer or float?

float (1.98), as in the second image of the first comment

Try to sets Decimals parameter from auto to 2.

It works! However the mapping to text does not work with thresholds, right? But it's good. As a suggestion for the future the mapping could encompass such case or perhaps in some cases work as coloring. Thank you my friend, your plugin is the best!

Text mapping and coloring is Grafana features, not my plugin. I think thresholds must works with text mapping. Try to look at Grafana documentation. Thanks for feedback!


Build failure with no error reported

In https://buildkite.com/llvm-project/premerge-checks/builds/1396#07950d9a-f40f-425f-95c5-88ce49b18cc4, the Linux build is failing with
OK    cmake
FAIL  ninja all
OK    clang-tidy
OK    clang-format

but the ninja log contains no error output.

I'm also seeing these in libclc diffs, e.g. https://buildkite.com/llvm-project/premerge-checks/builds/3243 and https://buildkite.com/llvm-project/premerge-checks/builds/3031.
@metaflow Do you have any idea what's going on here?

Yes, funny that I have just noticed this too. The issue was that we filter ninja log to output only "interesting" bits in combined log. It is a surprise for me that  grep exits with 1 if everything is OK and resulting output is empty.
I am going to remove some filters for now and figure out how to implement this properly.

Thanks, I saw the commit changing this, but not sure if it's been deployed as it's still failing on https://buildkite.com/llvm-project/premerge-checks/builds/3031

@fooishbar well the commit was only 2h ago and should be in effect since then :) I have restarted the build above.

Awesome, thankyou! It passes now.

@fooishbar Thank you for the head up! Sorry for the wrong signal from the premerge tests..


Add proper test infrastructure

[ ] add test coverage for extension
[ ] setup travis

Do you mind if I add this to my Jenkins X instance and see if we can automate the releases?

Where does travis send the artefacts to? or just run the tests?

I'd only run the tests on travis and maybe publishing new releases manually for now.


CupertinoActionDialog title deviates from iOS look and feel

Steps to Reproduce
Compare Flutter:
showCupertinoDialog(
  context: context,
  builder: (BuildContext context) => CupertinoAlertDialog(
    title: Text('Your score'),
    content: Text(computeScore().toString()),
    actions: <Widget>[
      CupertinoButton(
        child: Text('OK'),
        onPressed: Navigator.of(context).pop,
      )
    ],
  ));

with Swift:
Button(action: {
  self.showAlert = true
}) {
  Text("Hit me!")
}.alert(isPresented: $showAlert) {
  Alert(title: Text("Your Score"),
    message: Text(String(computeScore())))
}.padding()

Expected results (SwiftUI):

Actual results (Flutter):

Logs
 flutter doctor -v
[✓] Flutter (Channel master, v1.14.7-pre.10, on Mac OS X 10.15.2 19C57, locale en-US)
    • Flutter version 1.14.7-pre.10 at /Users/timsneath/flutter
    • Framework revision dd98046fe5 (20 hours ago), 2020-01-28 13:21:56 -0800
    • Engine revision c4229bfbba
    • Dart version 2.8.0 (build 2.8.0-dev.5.0 fc3af737c7)

While still pretty easy to tell the difference, this used to do a better job at matching native iOS (tested on the same simulator, the title of the route looks different too):

stable
master

.SF UI {Display, Text} are not using the specified font weight.
\cc @GaryQian anything changed on the typography front?

https://github.com/flutter/flutter/issues/49492

Duplicate of #49492. Thank you @calvinmuller.


In the src/test/java directory, replace "Paths.get(String)" to "java.nio.file.FileSystems.getDefault().getPath(String)"

I should not use java.nio.file.Paths.get(String path). I should prefer java.nio.file.FileSystem.
In the  src/test/java directory, there are 99 matches of the Paths string in 39 files.
In the src/test/java directory, rewrite it to "java.nio.file.FileSystems.getDefault().getPath(String)"

No, I would not do this.
In the branch issue442 I modified nearly 20 .java files and realized that replacing java.nio.file.Paths.get(String path) to java.nio.file.FileSystems.getDefault().getPath(String path) is meaningless.
In #440 I needed to avoid Paths.get(String) in the src/main/java files in order to support S3 FileSystem in future. That's meaningful.
However, In the  src/test/java files, Paths.get() is suffient.

#439 is introducing the unittest-helper in the src/test/java files. This action will effectively change the same sections.

I won't do this.


enforce_detection

Hello,
How do I use the enforce_detection option in a script?
if I have to check all the pictures manually I'll be spending a very long amount of time.
I am using the Facial attribute analysis but with multiple images:
from deepface import DeepFace
objs = DeepFace.analyze(["img0.jpg", "img1.jpg"])
#print("emotion: ",obj["dominant_emotion"])
print(obj)
print(objs)

objs = DeepFace.analyze(["img0.jpg", "img1.jpg"], enforce_detection=False)
its default value is true. If you don’t set it, then it returns exception if it cannot detect any faces. Setting it to false skips exception when it cannot detect any faces.

objs = DeepFace.analyze(["img0.jpg", "img1.jpg"], enforce_detection=False)
its default value is true. If you don’t set it, then it returns exception if it cannot detect any faces. Setting it to false skips exception when it cannot detect any faces.

@serengil So what exactly does it do? triying to enforce finding any box and considering it to be a face and do the analysis?

@serengil So what exactly does it do? triying to enforce finding any box and considering it to be a face and do the analysis?

enforce detection tries to find a face in the image. If it cannot find a face, then function returns exception. In this way, we can verify images with highly resolution.
In some cases, you need to still apply face recognition without face detection. We set enforce_detection to False in this case. This decreases the accuracy but it won't return exception.

enforce detection tries to find a face in the image. If it cannot find a face, then function returns exception. In this way, we can verify images with highly resolution.
In some cases, you need to still apply face recognition without face detection. We set enforce_detection to False in this case. This decreases the accuracy but it won't return exception.

Thanks for your commens @serengil . So is it a right understanding, that if I set the enforce_detection as False, then though MTCNN is not detecting any face in the picture, the library will consider the whole input image as a face and compute its embedding ?
Also you mentioned about verifying images with high resolution, I happen to observe the same behaviour. When i improve my image resolution, the face detection accuracy seems to go down. Though I am Not sure  why this is the case?

Thanks for your commens @serengil . So is it a right understanding, that if I set the enforce_detection as False, then though MTCNN is not detecting any face in the picture, the library will consider the whole input image as a face and compute its embedding ?
Also you mentioned about verifying images with high resolution, I happen to observe the same behaviour. When i improve my image resolution, the face detection accuracy seems to go down. Though I am Not sure  why this is the case?

if I set the enforce_detection as False, then though MTCNN is not detecting any face in the picture, the library will consider the whole input image as a face and compute its embedding -> Yes
verifying images with high resolution, I happen to observe the same behaviour. When i improve my image resolution, the face detection accuracy seems to go down -> that might be appear in your case. The default behaivour is that the higher the resolution the better it is.

if I set the enforce_detection as False, then though MTCNN is not detecting any face in the picture, the library will consider the whole input image as a face and compute its embedding -> Yes
verifying images with high resolution, I happen to observe the same behaviour. When i improve my image resolution, the face detection accuracy seems to go down -> that might be appear in your case. The default behaivour is that the higher the resolution the better it is.

@serengil
below is my code:
Decode the base64-encoded binary buffer received as Blob
image_data = image_blob.split(",")[1]
image_data = base64.b64decode(image_data)
Convert the binary data to an image array
image_array = np.frombuffer(image_data, dtype=np.uint8)
img = cv2.imdecode(image_array, flags=cv2.IMREAD_UNCHANGED)
faces = face_cascade.detectMultiScale(img, scaleFactor=1.3, minNeighbors=5, flags=cv2.CASCADE_SCALE_IMAGE)
result = DeepFace.analyze(img_path = img , actions = ["emotion"], enforce_detection=False,detector_backend='ssd')
when i use DeepFace.analyze i am fetting error "/AppleInternal/Library/BuildRoots/c2cb9645-dafc-11ed-aa26-6ec1e3b3f7b3/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShadersGraph/mpsgraph/MetalPerformanceShadersGraph/Core/Files/MPSGraph.mm:669: failed assertion `Placeholder shape rank mismatches"
but by commenting that out i don't get any error.
Any idea about the error ?


Smart alerts GA

PLEASE READ
Following a recent back-end update, all contributors with a local clone or fork of our repository are required to run yarn install. This does not apply to direct page edits.

[x] Yes, I've run yarn install
[ ] No, does not apply to me

Purpose of this pull request
This pull request:

Removes the beta tagging from this article:
https://help.sumologic.com/docs/alerts/monitors/use-playbooks-with-monitors/
Adds a release note:
https://help.sumologic.com/release-notes-service/2024/01/24/alerts/
Updates these articles:

https://help.sumologic.com/docs/alerts/monitors/create-monitor/
https://help.sumologic.com/docs/alerts/monitors/alert-response/
https://help.sumologic.com/docs/alerts/monitors/alert-grouping/

Select the type of change:

[ ] Minor Changes - Typos, formatting, slight revisions, .clabot
[ ] Update Content - Revisions, updating sections
[x] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

@banant, could you review this PR?


Error popup on upgrade

Microsoft PowerToys version
0.57.0
Running as admin

[ ] Yes

Area(s) with issue?
Installer
Steps to reproduce
Update from the settings menu
✔ Expected Behavior
No error
❌ Actual Behavior

Other Software
No response

/bugreport

Why is that feature so hidden? Should be part of the issue template as well, imo. Anyway, here you go:
PowerToysReport_2022-03-30-21-09-42.zip

Looking at installationFolderStructure.txt, it looks like some files from 0.49.0 and 0.51.1 are mixed up in the installation folder.
It's a mystery to me how you seem to have been able to run newer versions without issues :)
Would you mind:
1 - Uninstall PowerToys.
2 - See if the PowerToys install directory (default: C:\Program Files\PowerToys) is still there. If it is, delete it manually.
3 - Install PowerToys.
Please let us know if this works for you.

/needinfo

Thanks, yeah there were a lot of files left over, works now.


Create flag Celsius/Kelvin

Add an additional flag to specify the initial unit of measure of the camera (Celsius/Celvin), the default is Kelvin
(in case the flag is not written) Add a dialog line before the start of conversion, where the minimum and minimum temperature of the first frame will be displayed to confirm the initial temperature in Kelvin, or change to Celsius

Added in 87a6310cab1ea12c653bd32cb4f8fba1bddc8883


Not working after deployment? Seeing no notification - it does not work at all

I don't see a notification in my channel that says that the app is actually installed/deployed. Also getting a popup that says: "about this bot, this bot sends notifications only. You're not able to chat with or @mention it"
I tried redeploying, but nothing works.
Anyone else having the same problem?

I had a similar problem recently. The problem was that we had deployed the app to one tenant but it would be used in a different tenant. So when deploying the app I had to change the tenant ID to the tenant where the app was going to be used.

Thanks! Where did you change that? In Azure? Can you explain how to do that?

I followed the manual deployment guide here:
https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/wiki/Deployment-guide-manual
In step 2, when you click the blue Deploy to Azure button, you're presented with a form. I changed the Tenant Id field to the tenant where the app would be used.

It's crazy, but it seems like it did the trick. Thanks, @wy62!
Just another note: how frequent should it get updated? Do you happen to know if we can change the settings? It send me a welcome message (with take the tour button) and that's it really, can't do anything else...

Glad that helped. We struggled with it for weeks!
You can change the schedule by going to the resource group in Azure, clicking on the Logic App resource, click Edit to edit the logic app, then change the schedule of the first action from weekly to whatever you want. This logic app is the trigger for the app to do the pairing up. You can also run the logic app (and therefore trigger the pairing) by clicking the Run button when you click into the logic app.

You have been great, @wy62. Thanks a bunch, it works now.

Happy to help :) Don't forget to close the issue.

This should be in the Troubleshooting instructions.


Adding name Harry

hi @harryrf, thanks for adding a name!
please stick to the standard format, and don't translate the meaning
i'll merge it once the test pass

@bluzi I believe all is well now. Thanks for the patience.

hi @harryrf, thank you for you effort. merged #1


Emojis in HTML Body break URL Pages Editor

More of an FYI than anything.
Emojis break the html body, so other valid character sets might as well.
Seems to be this: https://stackoverflow.com/questions/30106476/using-javascripts-atob-to-decode-base64-doesnt-properly-decode-utf-8-strings
Nice project!

HTML comment tags also cause problems, just saying.

Apologies for taking nearly a year to fix this. I have just pushed an update that should address the problem. I had to write a base64 library for another project I am working on, and decided to integrate it into this project to fix issues with encoding more exotic character sets. Hopefully it works now!


Add notes in readme about ubuntu install issues.

This fix includes the advice from two issues:
https://github.com/revery-ui/revery/issues/316#issuecomment-462505096
and
https://github.com/revery-ui/revery/issues/339 (which is not only an issue with Fedora but also ubuntu <= 18.04 - https://www.ubuntuupdates.org/package_metas?utf8=✓&q=harfbuzz)

Thanks @JasoonS for adding this!


Update Json Schema

Closes #65
This change includes:

The replacement of the v2.3RC with the v2.3-RC2 done in MobilityData/gbfs-json-schema/pull/67
The fixes done in MobilityData/gbfs-json-schema/pull/66

@isabelle-dr I believe you have a unit test failing because it's trying to read the schema from the wrong path due to this fixture:
https://github.com/MobilityData/gbfs-validator/blob/master/gbfs-validator/__test__/fixtures/plan_id.js#L10
Change the version on this line to '2.3-RC2' and I think it will pass again.

@PierrickP Still failing 😕 I can't seem to find why.
Also: I renamed the folder in the schemas V2.3-RC2, do you think this would cause an issue with the version drop-down on the website?

Well it seems like it does 🙈. I updated the Validator.vue file to match the new name. I still can't get why the unit tests are failing.

Here is a PR into this branch that fixes the issue: https://github.com/MobilityData/gbfs-validator/pull/68
I still think we need to remove the requirement condition on default_pricing_plan_id though.

Thanks @testower, i merged your PR to fix this PR.
@isabelle-dr you renamed RC to RC2. Should we NOT keep old RCs ?

@isabelle-dr Thanks
Ok for the v2-3-RC and i ll make a PR to update the version requirement according to the latest change


Image.open is self closing, del img removes the loaded object

Per PIL documentation, the Image.open method is self closing when any operations are performed on the image. Calling Image.close() is only required if Image.open() was called and no operations are performed.
https://pillow.readthedocs.io/en/stable/reference/Image.html#PIL.Image.Image.load
Replacing:
img.close()

with:
del img

deletes the loaded image object
Also the later nodes don't work with the Image object, the image is covered to a tensor, and output_image is a tensor, not a copy of img that was loaded by PIL.

https://github.com/bigcat88/pillow_heif
Look at how the Image.open function is hooked/overloaded in this code to include support for heic/heif formats, I think a similar approach can be used to change the behavior of the upload_image / image_upload functions

https://github.com/bigcat88/pillow_heif
Look at how the Image.open function is hooked/overloaded in this code to include support for heic/heif formats, I think a similar approach can be used to change the behavior of the upload_image / image_upload functions
What I don't know is if the local path is maintained or if the path to the saved image is used for repeat generations. That could potentially create break something if it does rely on the image from the inputs folder instead of the local link.

There are two steps, upload and prompt. See https://github.com/liusida/ComfyUI-Login/issues/5#issuecomment-2111350481

https://github.com/bigcat88/pillow_heif
Look at how the Image.open function is hooked/overloaded in this code to include support for heic/heif formats, I think a similar approach can be used to change the behavior of the upload_image / image_upload functions
What I don't know is if the local path is maintained or if the path to the saved image is used for repeat generations. That could potentially create break something if it does rely on the image from the inputs folder instead of the local link.

There are two steps, upload and prompt. See #5 (comment)

Yes, and I am suggesting those processes can be overloaded using the methods suggested.

https://github.com/bigcat88/pillow_heif
Look at how the Image.open function is hooked/overloaded in this code to include support for heic/heif formats, I think a similar approach can be used to change the behavior of the upload_image / image_upload functions
What I don't know is if the local path is maintained or if the path to the saved image is used for repeat generations. That could potentially create break something if it does rely on the image from the inputs folder instead of the local link.

There are two steps, upload and prompt. See #5 (comment)

Yes, and I am suggesting those processes can be overloaded using the methods suggested. To clarify I think it's possible to have a function or method that overloads the base functions to prevent the default save behavior.

But the base ComfyUI is moving very fast. If we override it here, it might be deprecated very soon. How could this be solved?

https://github.com/bigcat88/pillow_heif
Look at how the Image.open function is hooked/overloaded in this code to include support for heic/heif formats, I think a similar approach can be used to change the behavior of the upload_image / image_upload functions
What I don't know is if the local path is maintained or if the path to the saved image is used for repeat generations. That could potentially create break something if it does rely on the image from the inputs folder instead of the local link.

There are two steps, upload and prompt. See #5 (comment)

Yes, and I am suggesting those processes can be overloaded using the methods suggested. To clarify I think it's possible to have a function or method that overloads the base functions to prevent the default save behavior.

But the base ComfyUI is moving very fast. If we override it here, it might be deprecated very soon. How could this be solved?

Thats unfortunately the reality of wanting to modify core behavior of a library instead of simply extending it. If the goal is to prevent server side saving, the nodes and code base need to keep up with any changes that would break them, or you would need to get changed committed to the main repo the enable the functionality you want.
But as I discussed, if the goal of the node is privacy, server side saving of images is not compatible with that aim.
I haven't done a full stack trace of the calls from when you select an image, to when it gets saved to the server, but I imagine there are several places to interrupt the process, or its probably possible to write your own javascript for the node to handle all of the image loading and bypass the server.py functions entirely.
My only experience with the javascript in the repo is tracing to which functions need changing for commits, Ive not written any for any of my own custom nodes, but Id recommend you look at the repo for ltdrdata's impact pack, he seems to have written javascript code for his own image loading.
He generally seems quite open to answering questions, and is very knowledgeable about the code base, he might be able to suggest a way to implement this.
https://github.com/ltdrdata/ComfyUI-Impact-Pack/blob/Main/js/impact-image-util.js


Revert "[MB-15297] Upgrade to go 1.20.1"

Reverts transcom/mymove#10169
Trying to see if it fixes our current CircleCI problems in the deploy_stg_app and deploy_stg_app_client steps.

Messages

:book:
:link: MB-15297

  Generated by :no_entry_sign: dangerJS against 9fc7945172f489a3fec2cb5b546f7f0eb9e22451

Note: reset the server test coverage key in CircleCI as part of this because we kept getting test coverage check failures even though this PR doesn't do anything with tests or add Go code.


Can't output into subdirectory

My config:
export default {
  input: 'src/main.ts',
  output: {
    dir: 'public',
    entryFileNames: '[name].[hash].js',
    chunkFileNames: '[name].[hash].js',
    format: 'iife',
  },
  plugins: [
    htmlTemplate({
      template: 'src/index.html',
      target: 'public/index.html', // << Note: root of output dir
      replaceVars,
    }),
    htmlTemplate({
      template: 'src/views/modal.html',

      // This always gets output in root of /public dir
      target: 'public/views/modal.html', // << Note: subdir in output dir

      replaceVars,
    }),
  ],
};

In my source I have index.html in the root folder and then a views/ folder for other views. I'd like that mirrored in the output folder but it doesn't seem possible as views always get output in root of output dir. Any suggestions or is it a bug? Thanks

👋 Got the same issue ☝
As I see from the source code target parameter is using only for the name creating.
Got one workaround in the plugin, will try to create a PR from it:)


feat(client): support joining multiple links at once

This pull request adds Link.from so multiple links can be joined into a single link at once.
final Link link = Link.from([authLink, loggingLink, httpLink]);

Fixes / Enhancements

Add Link.from.

Docs

Document Link.from in README.md.

Please make sure your commits are signed. Follow instructions here.

No problem, signed and force-pushed. Perhaps mention signing in CONTRIBUTING.md?

I added that sometime back, it's in beta branch though. Will be merged to master in the near future.

@jayjun can you correct the issues highlighted by the CI. Click on details to see why the tests are failing.

I could get the linter to pass. However, test coverage is crashing even without my changes, namely on beta branch.
Found 15 test files.
Generated test-all script in test/.test_coverage.dart. Please make sure it is added to .gitignore.
Unhandled exception:
Tests failed with exit code 255
#0      runTestsAndCollect (package:test_coverage/src/functions.dart:120:5)
<asynchronous suspension>
#1      main (file:///home/cirrus/.pub-cache/hosted/pub.dartlang.org/test_coverage-0.3.0+1/bin/test_coverage.dart:51:9)
<asynchronous suspension>
#2      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:303:32)
#3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)
Exited with code 255

I could reproduce this locally too.

@jayjun Okay, leave it for now. @HofmannZ can you check why the above test is failing on beta?

:tada: This PR is included in version 2.1.1-beta.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix #2146: Active Record scopes

Fix #2146: Added ability to declare scopes for yii\db\ActiveQuery as static methods of yii\db\ActiveRecord

I like the commit but if we use reflection shouldn't we also check the hinted type of the first parameter since it must be (a descendant of) ActiveQuery?

Also, I was wondering (I know this was in my example code as well) if we should return the result from the static scope method or just return the query object.

Objects are always passed by reference.
If we return the return value it could be:
A) Of a different type (not so bad since this will throw clear errors)
B) A different ActiveQuery object.

In case of B this could cause unexpected behavior but it also could add new power.

shouldn't we also check the hinted type of the first parameter since it must be (a descendant of) ActiveQuery?

Nope: such information may be missing. Developer may ommit type restriction and doc comments.

we should return the result from the static scope method or just return the query object.

Need to check with original implementation. Perhaps returning of the query instance is better, allowing reducing the code inside the scope declaration method.

The doc comments don't need to be there. But the type restriction is not a weird requirement. It would also allow us to differentiate between scope and non-scope static methods.

Just found original implementation:
https://github.com/yiisoft/yii2/blob/2.0.0-alpha/framework/yii/db/ActiveQueryTrait.php


animate.css and jquery in new firefox

Hi there,
i've found a bug that only occurs in newest Firefox or Chrome. In older Versions it works, in Internet Explorer 11 it works too.
I have 2 Layers: "maincontent" and "subcontent". The "maincontent" layer shows a Link to hide "maincontent" and show "subcontent". In "subcontent" is a link to hide "subcontent" and show "maincontent" again. Simple. When i klick the link in "maincontent" i have a small fadeout effect with animate.css: maincontent fades out, wait for animation ends, after animation ends it hide maincontent and show subcontent.
Here a short test-script. Just copy it in a blank html file and test it yourself in act firefox (49.0.2)!
<!DOCTYPE html>

  <meta charset="utf-8">
  <meta http-equiv="X-UA-Compatible" content="IE=edge">
  <title>Test</title>
  <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/animate.css/3.5.2/animate.css">

ANIMATED TEXT

    open subcontent

    you are on subcontent now
    close subcontent

The problem occurs when i close "subcontent". When "maincontent" is show again the little animation "ANIMATED TEXT" in "maincontent" (layer id: animtext) runs again, but after it ends it jumps back in the load_subcontent() function and triggers the one.(animationend) event again. I dont know why? I never run this function.
You can check that on the little alert box that says "subcontent loaeded" - This alert box is shown when i close "subcontent" too, but why?
When you remove the "ANIMATED TEXT" layer (id: animtext) or remove the animation (remove Class "animated jello") script works fine!
Problem occurs ín new firefox and crome version. In older Versions or Internet Explorer 11 it works!
I think the Problem here is not animate.css, but i think it is important for you!
Hope someone can help....

test.txt
i uploaded the script as txt, because i cannot upload zip (says filetyp not allowed). Just rename it to test.htm to check. I cannot post the code here, because it doesnt work :-(

Hello,
i've found a solution. The Problem ist, that new Firefox reacts on webkitAnimationEnd and animationend, so the function:
$('#maincontent').one('webkitAnimationEnd` mozAnimationEnd MSAnimationEnd oanimationend animationend', function() {
//do anything
`});

fires 2 Times. It's not longer recommended to use this code to find out if a Animation Ends.
Best way is set following anonymous function at beginning from the script:
var animationEnd = (function(el) {
        var animations = {
            "animation": "animationend",
            "OAnimation": "oAnimationEnd",
            "MozAnimation": "mozAnimationEnd",
           "WebkitAnimation": "webkitAnimationEnd"
        }

        for(var t in animations) {
            if(el.style[t] !== undefined) {
                return animations[t];
            }
        }

})(document.createElement("fakeelement"));

This function runs automatic at beginning of the script and "checks" which Animation End handle the browser accept and writes if in the variable animationEnd (in the most cases it's "animationend")
After that you can use:
$('#maincontent').one(animationEnd, function() {
//do anything
});

This prevents that the browser reacts 2 times!
A fixed Version of my script from the beginning you can find here:
http://plnkr.co/edit/LzabPdRItmJxjwQaPWzA?p=preview

This is a good consideration. I think that IE11 and Edge do recognize webkit prefixes too and may suffer with the same issue. I'll have a look at this in the near future.

@cos200, would you mind sending a PR to fix this on the read me?


New feature - helm template

This is a FEATURE REQUEST, please:
I am interested in using this plugin and need "helm template" Mojo command as a new feature. I also would like to add --host global environment variable. I have made these changes locally and would like to create a pull request. Let me know how I can contribute.

Hi. Just create a PullRequest from your fork.

Closed due inactivity.


How to apply it to new models

Hello, I have succeeded editing models from llama, including llama-7b, ziya-llama-13B.
But it failed on editing chatglm3 with the config from ROME/chatglm2-6b.yaml. Even if I adjust the edition steps to 200, I cannot effectively reduce the loss and improve the accuracy of editing.
It shows:
loss 19.301 = 19.301 + 0.0 + 0.0 avg prob of [ 纽约] 1.9118447269761418e-08
loss 18.104 = 17.835 + 0.071 + 0.198 avg prob of [ 纽约] 7.327661677436481e-08
loss 15.357 = 15.124 + 0.01 + 0.222 avg prob of [ 纽约] 2.2358667592925485e-06
loss 12.684 = 12.451 + 0.011 + 0.222 avg prob of [ 纽约] 2.6959438400808722e-05
loss 11.079 = 10.846 + 0.011 + 0.222 avg prob of [ 纽约] 6.573031714651734e-05
loss 9.582 = 9.349 + 0.011 + 0.222 avg prob of [ 纽约] 0.0002662458864506334
loss 8.234 = 8.001 + 0.011 + 0.222 avg prob of [ 纽约] 0.0014487882144749165
loss 7.08 = 6.847 + 0.011 + 0.222 avg prob of [ 纽约] 0.005161626730114222
loss 6.194 = 5.962 + 0.01 + 0.222 avg prob of [ 纽约] 0.010020474903285503
loss 5.513 = 5.281 + 0.01 + 0.222 avg prob of [ 纽约] 0.016288358718156815
loss 5.183 = 4.951 + 0.01 + 0.222 avg prob of [ 纽约] 0.018959175795316696
...
loss 1.978 = 1.747 + 0.009 + 0.222 avg prob of [ 纽约] 0.18422633409500122
loss 1.996 = 1.765 + 0.009 + 0.222 avg prob of [ 纽约] 0.18353217840194702
loss 1.991 = 1.76 + 0.009 + 0.222 avg prob of [ 纽约] 0.1818918138742447
loss 2.032 = 1.801 + 0.009 + 0.222 avg prob of [ 纽约] 0.1784791201353073
loss 2.24 = 2.009 + 0.008 + 0.222 avg prob of [ 纽约] 0.1463432013988495
loss 8.215 = 7.983 + 0.009 + 0.222 avg prob of [ 纽约] 0.008609873242676258
loss 9.747 = 9.515 + 0.01 + 0.222 avg prob of [ 纽约] 0.00037625530967488885
loss 7.657 = 7.425 + 0.01 + 0.222 avg prob of [ 纽约] 0.0019925576634705067
loss 6.161 = 5.929 + 0.009 + 0.222 avg prob of [ 纽约] 0.010164782404899597

So I wonder how to apply this framework to another mode, and how to set the layers, v_loss_layers, v_loss_layer and others options in config?
Thank you

ROME is kind of a locate-then-edit model.
You can first conduct the causal analysis on the new model to determine which layer may store the knowledge. You can also just set layers as a hyper-parameter and try different ones.
Then, you should compute the layer_stats for the new model, the code would compute automatically, so I think it doesn't matter.
v_loss_layer is usually the last layer of the model.
I also think you can try to change v_lr and v_weight_decay .

hi, do you have any further questions？

It sounds a challenging work.
I will have a try and come back for more advice if I encounter any difficulties.
Thank you very much.

Is there any practical information that can be used as a reference? I encountered this problem https://github.com/kmeng01/rome/issues/43 , but it seems that no developer helped this problem.
Thank you

ROME is kind of a locate-then-edit model. You can first conduct the causal analysis on the new model to determine which layer may store the knowledge. You can also just set layers as a hyper-parameter and try different ones. Then, you should compute the layer_stats for the new model, the code would compute automatically, so I think it doesn't matter. v_loss_layer is usually the last layer of the model. I also think you can try to change v_lr and v_weight_decay .

I  also tried to set layers as a hyper-parameter when editing chatglm3, but none of the results shows it is right.

Sorry for the slow response and I'm not sure if you still face the problem.  However, we 're busy of late and cannot support chatglm3 currently.  We would support it in the future and will let you know.


Error message re: lemmatizer/tokenizer

Pipeline runs fine but getting these errors:
UserWarning: [W108] The rule-based lemmatizer did not find POS annotation for one or more tokens. Check that your pipeline includes components that assign token.pos, typically 'tagger'+'attribute_ruler' or 'morphologizer'.
  warnings.warn(Warnings.W108)
/home/yiwen-h/.pyenv/versions/text_venv/lib/python3.8/site-packages/sklearn/feature_extraction/text.py:516: UserWarning: The parameter 'token_pattern' will not be used since 'tokenizer' is not None'

Related to this, if we use caching then the text preprocessing will happen only once in the pipeline! This will make randomsearch run much more quickly. right now every iteration it is redoing the tokenization etc. if we get the caching working then the text preprocessing which was moved out to factory_data_load_and_split can move back into the pipeline. then this means that in factory_predict_unlabelled_text we don't need to do process_data - the raw df can be passed into the pipeline to be .predicted (which is probably better practice actually).
cf https://stackoverflow.com/questions/47385781/using-scikit-pipeline-for-testing-models-but-preprocessing-data-only-once

Bug fixed! We still get warning below re: the use of the spacy tokenizer but it was always there.
The parameter 'token_pattern' will not be used since 'tokenizer' is not None'
  warnings.warn(

Re: comment above on caching preprocessing in pipeline - it's not worth it at this stage, training doesn't take that long anyways.


Allow specifying void tags.

You might not want to use Data.Default, or provide helper functions for taggyWith/run/parseDOM that use defaults.
Fixes #12.

No problem with using Data.Default for the parsing options AFAICT, it's common enough that most people won't mind I think. Could you however rebase against the last couple of commits on master? I made a few changes to the cabal file and released a new version, nothing major.

Nevermind, I did it through the github interface.

Hello - I have a problem parsing html with <hl>, <link> tags, etc, so would very much like to be able to use this fix. It seems to have been abandoned / forgotten? Any chance it could be completed? (I would volunteer to help, but don't really know what I'm doing!). If not, is there some way I can get the code locally from the "unknown repository" it came from? (Sorry, my knowledge of GitHub is very limited).

I don't have much time to look into taggy these days, sorry. But if you do manage to get this PR up to date and polished I would be happy to merge.

Hi - No problem. I've also discovered the source I'm using has some malformed HTML which is not parsing as expected. I see this mentioned in issue 9. You also mention there some other HTML parsers, so I'll have a look at those first. Thanks!


[Media Object] stack-for-small doesn't work with flex grid

When checking on issue #8738 I noticed the stack-for-small class is not working. This is because flex-wrap: wrap; is being applied to all breakpoints, not just small.
See this codepen and add the stack-for-small class.
I'll sort out a PR to fix both these issues now.

Fixed by #8740


Yarn Debian key expiry date updated

This is a Bug Report

Problem:
The Yarn Debian key has expired for the script in Ubuntu, Debian or HypriotOS. I got the following error message when I ran sudo apt-get update:
The following signatures were invalid: EXPKEYSIG 23E7166788B63E1E Yarn Packaging<EMAIL_ADDRESS>
Proposed Solution:
As mentioned in yarnpkg/yarn, to get the updated key, run this:
curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add -
Page to Update:
https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/#k8s-install-0

/triage accepted
/kind bug

/help

/good-first-issue

As mentioned in yarnpkg/yarn, to get the updated key, run this:
curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add -

@kubernetes/release-engineering
hello, the associated PR is making a change from the existing GPG @ google:
https://packages.cloud.google.com/apt/doc/apt-key.gpg
should we instead update the GPG key @ google?

I'm not sure I understand why this change makes sense. The issue description mentions Yarn even though the existing page makes no mention of Yarn.
/remove-good-first-issue

/remove-help

@AaronLuo3296 I think the existing page is correct. If you have an outdated Yarn key on your system, because you have used Yarn previously, then you should follow the Yarn documention about that. Kubernetes does not document how to ensure you have a current signing key for Yarn; these are different projects.
/remove-kind bug
/kind support

/remove-triage accepted

From RelEng:
Agreed with @sftim's assessment.
This is an issue with the user's local development environment and they should follow Yarn's documentation for adding/updating/removing package signing keys.
@kubernetes/build-admins -- FYI, but no action required.
/close

thanks for having a look @sftim and @justaugustus


Unplayable FPS since 03/03/21 RS Update

Game runs at 0 fps.

Disable Quest Helper and Optimal Quest Guide hub plugins if you have them.

Disable Quest Helper and Optimal Quest Guide hub plugins if you have them.

This fixed the issue immediately.

Back-end Quest change relating to the "IsComplete" flag are the cause. This is also affecting the World Map core plugin.

fixed for core plugins by 6526fd9d7c8155c88c8fcf0eef6406de643b81c8


Updated multi-factor verification note

Updated note to say Option 2 and updated Option 1 with link to Security Defaults

@Demywil : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Demywil - Not sure if you saw my last comment. Again, thank you for the changes. I believe the second change is correct but needs a few more edits. I think the second change should be:
Option 2, enabling Multi-Factor Authentication by changing the user state, overrides Conditional Access policies. Because options 3 and 4 use Conditional Access policies, you cannot use option 2 with them.

@TerryLanfear just updated the document based upon your feedback.

@Demywill - Thanks for the update. Please add the comment "#sign-off" if you are ready to publish. This will get your PR merged.

@Demywil  - Thanks for the update. Please add the comment "#sign-off" if you are ready to publish. This will get your PR merged.

@Demywil - My apologies for the randomization. I thought you needed to sign off. I'll add my sign off now.

#sign-off


[Global] CultureInfo issue when converting double to string

I had a problem with Menu sometimes displaying in the corner even with AnchorRef correctly set.
Found the problem in Popover.cs in GetPositioningStylesAsync. There's this line:
styles.Add("left", $"{left}px");

In my CultureInfo, which is Slovak, or sk-SK, it is translated to "1296,5px" (comma instead of dot) which is not valid CSS. I fixed it in my code like this:
styles.Add("left", $"{left.ToString(CultureInfo.InvariantCulture)}px");

which is a thing I have to always use with floating point numbers. I guess this is going to be a global issue, so I'm not gonna create a PR for this small fix which fixes it in only one place.

oh. not aware of this. this need to be fixed through out the code base where ever used. thanks for reporting.

patch version released with fix https://www.nuget.org/packages/Skclusive.Material.Component/2.0.1. closing the issue.


Application on other dataset：Replica room0 bad convergence

Hi there, Thanks for sharing this excellent code.
I am trying to have this applied to the Replica dataset: https://github.com/facebookresearch/Replica-Dataset
The experiment configuration is like this:
Hardware: Tesla V100 32.768G Ubuntu1604
Dataset: Replica room0: pick 21 views from the first 200 frames, processed by colmap
Training: train/test 18:3 for 50k iteration
parameter config
expname = replica_20v basedir = ./logs/release datadir = ./data/replica_room0_20v dataset_type = llff factor = 4 llffhold = 8 N_rand = 4096 N_samples = 64 N_importance = 128 use_viewdirs = True raw_noise_std = 1e0 no_ndc = True colmap_depth = True depth_loss = True depth_lambda = 0.1 i_testset = 5000 i_video = 10000 N_iters = 50000
When evaluated on 3 test images, the results are PSNR=16.997, 19.288 and 20.136 for RGB inference, respectively. The rendered videos are visually not recognizable as the original scenes, and the depth is not converged.
I have tried the exact dataset on NeRF and trained for 50k iterations as well, it works fine for RGB rendering (PSNR around 30), but the disparity hardly converges, either.
This synthetic dataset resembles the office room scene you demonstrated on your project homepage for the field of views and pose divergence. I am wondering what the problem is, and many thanks for any kind comments!

There is three part of changes I made to suppress the error:
In run_nerf.py ，line 1081:
test_loss = img2mse(torch.Tensor(rgbs).to(device), images[i_test].to(device))
In load_llf.py, line 365, 380 and 383:
error_list=[]
error_list.append(err)
data_list.append({"depth":np.array(depth_list), "coord":np.array(coord_list), "weight":np.array(weight_list),"error":np.array(error_list)})
In load_llf.py, line 52:
args = ' '.join(['mogrify', '-resize', resizearg, '-format', 'jpg', '*.{}'.format(ext)])

Hi, thanks for your interest!
I suspect it's because COLMAP didn't get a reasonable reconstruction because the walls and floor are relatively textureless.


Animal Sniffer Plugin applied for Java compatibility test

Now the plugin tests whether APIs used for pinpoint are compatible for java 1.6.
Two files are modified: pom.xml, web/pom.xml
This test automatically runs during project build. (ex command/ mvn install -Dmaven.test.skip=true)

***pinpoint-web is tested if it is compatible with java 1.7
***sun libraries are ignored at the test.
https://github.com/naver/kaist-oss-course/issues/65

@999fg
Looks good!
One possible suggestion would be to pull sniffer artifactId out as a maven property.
This way, web's pom.xml could simply overwrite this property to java17 instead of redefining the whole plugin. (Similar to how the maven-compiler-plugin is using jdk.version to configure source and target levels)
Automatically setting sniffer's artifactId based on jdk.version would be even better, but I'm not sure if this can be done easily.
I'd love like to hear what you think, please let me know.
Thanks!

@Xylus
Thanks for the comment!
I totally agree with your suggestion, which is more good way of coding and compatible in further development.
When I sent this PR few hours ago, I personally did not like two lines of log appearing when pom-web is being compiled (possibly due to re-defined plugin application in two pom.xml file). Following your suggestions solved this problem.
Anyway, I updated the commit as your suggestion.
Thanks!


Any plans to support the fever API?

Any plans to support the fever API?

Fever or Tiny Tiny RSS API support would be fantastic!


handle OAUTHBEARER SASL connection

Type of change

Enhancement / new feature

Description
Please describe your pull request
Additional Context
Why are you making this pull request?
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Review performance test results. Ensure that any degradations to performance numbers are understood and justified.
[ ] Make sure all Sonarcloud warnings are addressed or are justifiably ignored.
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

@callaertanthony are you still working on that PR?

@franvila not for the moment, we can close it


why determinant of the Jacobian is not considered in loss?

The determinant of the Jacobian is constant after volume normalization, so it is not considered.

thanks


Initial work on performance

This PR includes several commits, but the most major change is that Rc has been replaced with Arc throughout much of the repository, in order to prepare for improvements from multithreading.

Looks like there are just some unused-related warnings, plus Conventional Commits issues, and then it's ready to merge. Probably just squash down to one commit and reword the message to match Conventional Commits.

@alilleybrinker assuming this last check is successful (it should be) I think this is ready to merge!


chore: removing debug screenshots to rerun them

📝 Description
Missed new screenshots for the debug tests so adding them here.
❓ Context

Impacted projects: ``
Linked resource(s): ``

✅ Checklist

[ ] Test coverage
[ ] Atomic delivery
[ ] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

/generate-screenshots


Is there a way to login?

Hi,
I have tested L.interactive_login("username"), but it does not work (#1217 ).
Is there another documented way to login? I have read about --load-cookies, but I don't understand how to use it.
Is there same sample code or same sample cli procedure?
Thank you

--login will prompt you to log in with user and password, and you can use an arg file to store your user and pass with --login=XXXX and --password=YYYY and call it in the CLI.
The cookie method doesn't seem to work in Brave for me, and I always use the CLI

--login will prompt you to log in with user and password, and you can use an arg file to store your user and pass with --login=XXXX and --password=YYYY and call it in the CLI.

I know it, but the --login does not work. I receive the verification code and I receive always 2FA error (as you can see in #1217) 😢
Session file does not exist yet - Logging in.
Enter Instagram password for aborruso:
Enter 2FA verification code: 207661
2FA error: This code is no longer valid. Please request a new one.
Enter 2FA verification code:

Thank you @Showmaster3000 I have a debian machine without GUI and without browsers :(
I will study your links, bt I think I am not able to overcome the obstacle. I had hoped that the login via cli would work as documented.
In any case, this is a really nice project!