Make lisp-interaction-mode-map inherit from emacs-lisp-mode-map

Describe the feature
Currently you can't use the functions bound to localleader in emacs-lisp-mode in lisp-interaction-mode. That's because lisp-interaction-mode-map inherits from lisp-mode-shared-map instead of emacs-lisp-mode-map.
Implementing this should be as easy as adding
(set-keymap-parent lisp-interaction-mode-map emacs-lisp-mode-map)

somewhere in (:lang emacs-lisp), but when I added this line to my config.org I ran into some problems. The keymap somehow does not update until I run M-x describe-variable RET lisp-interaction-mode-map and then change into another Evil state.
System information

((emacs
  (version . "26.3")
  (features . "XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD LCMS2")
  (build . "Aug 29, 2019")
  (buildopts "--prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now")
  (windowsys . batch)
  (daemonp . server-running))
 (doom
  (version . "2.0.9")
  (build . "HEAD -> develop 23d6ec70d 2020-02-22 13:11:07 -0500")
  (dir . "~/.config/doom/"))
 (system
  (type . gnu/linux)
  (config . "x86_64-pc-linux-gnu")
  (shell . "/usr/bin/zsh")
  (uname . "Linux 5.5.2-1-MANJARO #1 SMP PREEMPT Tue Feb 4 19:22:35 UTC 2020 x86_64")
  (path "~/bin" "~/opt/bin" "/usr/local/sbin" "/usr/local/bin" "/usr/bin" "/var/lib/flatpak/exports/bin" "/usr/lib/jvm/default/bin" "/usr/bin/site_perl" "/usr/bin/vendor_perl" "/usr/bin/core_perl" "~/.local/bin" "~/.config/emacs_doom/bin" "~/.dotnet/tools" "~/var/go/bin" "~/.local/share/cabal/bin" "~/opt/ghcup/bin" "~/.gem/ruby/2.7.0/bin" "~/.local/share/cargo/bin" "/usr/lib/emacs/26.3/x86_64-pc-linux-gnu"))
 (config
  (envfile . envvar-file)
  (elc-files .


Added Minimizing condition number by scaling example

Description
Added an example "Minimizing condition number by scaling"
Type of change

[ ] New feature (backwards compatible)
[ ] New feature (breaking API changes)
[ ] Bug fix
[x] Other (Documentation, CI, ...)

Contribution checklist

[ ] Add our license to new files.
[ ] Check that your code adheres to our coding style.
[ ] Write unittests.
[ ] Run the unittests and check that they’re passing.
[ ] Run the benchmarks to make sure your change doesn’t introduce a regression.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add a new property type to manage a file.

Add a new property type to manage a file.
Let's imagine that my module requires a file to be configured.

I want to upload a dsl file for a new module, I would like to be able to add it in the frontend and retrieve it in the backend to process it

yes but at first, I may not need to interact with the other modules.
I was thinking more about the upload part of feature Replay #2907
But ideally your proposal seems the way to go for manage a dsl file.

The replay feature is not a module I think, for me it's a dedicated feature

I think adding a file type property to JHipsterPropertyType and managing it on the frontend side would do the job for some modules.

Yep but can't do it without a use case :D So we need a module that needs a file to add that

agree with @DamnClin : it should be implemented only when you need it, not before. So there should be a use case for that

my module need a file in entry for generate code from this file. Il want to create my domain entity from it ans more later perhaps

I don't get it, by definition domain entity can't be generated since it's not related to any other kind of model (this is the main model, driving the other ones).
Also I don't think this is a module. Model generation (ex to generate a CRUD) is not a module, this is another feature, not a module

I can think of some modules that may need a file (modules related to a provider giving you a configuration file to add to your app) BUT adding file management is a lot of work (I think ~2h to handle the new type front + back and property type to get the file as a byte[]). I don't want to add it without any exact need


Support rtl (right to left text)

Good example here
Ideally implement for both backends (Cairo, PDF).
May require font shaping (HarfBuzz is under construction).

Also need fribidi (or similar for bidirectional layout of Arabic family languages). A port of Perl Text::Bidi module?

Some work in progress on shaper branch, but not in a position to merge just yet.
More progress needed on Bidi as mentioned above. Ideally separate Bidi decomposition (which can be done in HTML::Canvas) and shaping (which can be done in HTML::Canvas::To::Xxxx rendering back-ends.

Rtl/bidirectional support has been added with 0.0.12 release


Updated json for CRR

Updated the json to enable CRR

#sign-off

@nivnar , can you take a look and let us know if this is good to merge?

#sign-off


Ubuntu Linux: "The program can't find any usable optical drives"

Running under Ubuntu 19.04 and the latest makemkv Docker image. Created the container with arguments:
docker run -d     --name=makemkv     -p 5800:5800     -v $HOME/docker/appdata/makemkv:/config:rw -v $HOME:/storage:ro -v "$HOME/Videos/DVD backup/Work/backup":/output:rw --device /dev/sr0 --device /dev/sr1 jlesage/makemkv
I am able to access the GUI via http://localhost:5800/, but in the output pane, I see a message stating the program can't find any usable optical drives. I changed permissions on /dev/sr0 and /dev/sr1 to 0666, but it made no difference.

What the container's log is telling about the drives?  During the startup of the container, you have clear info about them.
docker logs makemkv

I got it sorted; I wasn't passing in the /dev/sg* devices on the command
line.
On Fri, Nov 15, 2019, 19:27 Jocelyn Le Sage<EMAIL_ADDRESS>wrote:

What the container's log is telling about the drives? During the startup
of the container, you have clear info about them.
docker logs makemkv
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jlesage/docker-makemkv/issues/59?email_source=notifications&email_token=AABGUGB5QRLJO5JUL334DJTQT5EB3A5CNFSM4JNBMHN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEHF3LI#issuecomment-554589613,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABGUGCWMMN6LAYIHGXACD3QT5EB3ANCNFSM4JNBMHNQ
.

Although I never knew about the "docker logs" command, so thank you for
that.
On Sat, Nov 16, 2019, 10:30 Kit Peters<EMAIL_ADDRESS>wrote:

I got it sorted; I wasn't passing in the /dev/sg* devices on the command
line.
On Fri, Nov 15, 2019, 19:27 Jocelyn Le Sage<EMAIL_ADDRESS>wrote:

What the container's log is telling about the drives? During the startup
of the container, you have clear info about them.
docker logs makemkv
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jlesage/docker-makemkv/issues/59?email_source=notifications&email_token=AABGUGB5QRLJO5JUL334DJTQT5EB3A5CNFSM4JNBMHN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEHF3LI#issuecomment-554589613,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABGUGCWMMN6LAYIHGXACD3QT5EB3ANCNFSM4JNBMHNQ
.

No problem!
Closing the issue.

any way to pass devices info to cli tool? got the same error when trying makemkvcon fron this container


Report the version of the resource provider that deployed a cluster

Which issue this PR addresses:
https://msazure.visualstudio.com/AzureRedHatOpenShift/_workitems/edit/7482322
What this PR does / why we need it:
This PR does the following things:

cleans up the git sha embedding into the library
places that SHA into the document when doing an adminUpdate
reports the SHA in the document to metrics

This PR produces the SHA as a part of metrics every scrape. This feels inefficient? Some of these metrics may be better off aggregated somehow (e.g. only on change? scraped/aggregated from the database instead?)
Test plan for issue:
Unit tests provided for recording the SHA and reporting through metrics.
Is there any documentation that needs to be updated for this PR?
probably not?

Ping me when you've fixed the error nit and I'll merge.

@jim-minter Done!

Merging, please leave the VSTS item open to add a dashboard (ask @ehashman for help doing that).

Nice work!


TDVT tests - All logical tests fail

About You:
Name: Guang
Your question:
For all the logical tests I am getting
Attempting to run query...
TableauException: Tableau cannot evaluate the query that results from this calculation.

Error running query

I think only one of the tests is running and the others don't run since the first one is failing.
From the logs I can see that the query is generated and I can manually run that query successfully in the database:

Logs:
logs.zip
Any advise?

Hi Guang,
Typically, when you see that particular error message, it means the dialect doesn't define the minimum set of functions Tableau needs to evaluate the expression in the test. $IN_SET$ is an internal system function, and relies on type conversions defined in the dialect. In this case, it's likely that your dialect doesn't define conversion functions between string and datetime.
In case you haven't already, I'd strongly recommend starting with something like this example dialect and modifying it as necessary, instead of trying to start from scratch or using a base dialect (which is really only for connectors that very closely match an existing native connector). That way at least all of the required components are in place.
If you need any further assistance with this, please attach your .tdd file.
Evan


refactor(ui/bottom-navigation): refactor from @varlet/use

Checklist

[ ] Fix linting errors
[ ] Tests have been added / updated (or snapshots)

Change information

Codecov Report

Merging #885 (851cbf3) into dev (755deee) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##              dev     #885      +/-   ##
==========================================
- Coverage   94.86%   94.86%   -0.01%
==========================================
  Files         272      272
  Lines        6119     6116       -3
  Branches     1112     1112
==========================================
- Hits         5805     5802       -3
  Misses        314      314

Impacted Files
Coverage Δ

...es/varlet-ui/src/bottom-navigation-item/provide.ts
80.00% <100.00%> (-3.34%)
:arrow_down:

...ackages/varlet-ui/src/bottom-navigation/provide.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


change img1 and img2 comparison algorithm from getbbox() to imagecompare.is_equal()

Hi! I like your program and I have used it for online presentations. It is very useful, thank you for making it.
I noticed that during zoom calls, the getbbox() function falsely detects changes of the slide. I believe it is due to h.264 streaming artifacts from streaming said video.
I found imgcompare from pip and found it to be useful the program as it allows for tolerance for the image differences. Said tolerances can account for the streaming artifacts. I've set it to 5, and i think maybe we can set a GUI option for this.

Thanks

thank you too


First page of useSWRInfinite should reuse the cache from useSWR

Currently useSWRInfinite always refetches the first page because of this line:
(typeof force === 'undefined' && i === 0)

and it will not reuse the cache from useSWR. This PR fixes that so if there is no originalData (the first render), but has pageData (has cache), we directly return the cache.

Thanks @huozhi!

Thanks @huozhi!


can you bring back the old lua system?

What feature do you want to get added on the base engine?
please do it, indie cross is broken on this new update and sans dodge mechanics dont work
To test your sight, and reliability, please select the option of what should NOT be requested.
Proper credit that was forgotten

It's literally impossible to bring it back, the source has been HIGHLY changed.

Why dont just add 0.7 features to 0.6.3?


ARROW-16062: [Python] Move libarrow_python include definitions to its own file

This PR moves all the arrow/python definitions to its own libarrow_python.pxd file as requested on ARROW-16062

Thanks @jorisvandenbossche ! I've fixed the linting issue, I think the PR is ready for review

@github-actions crossbow submit wheel* conda*


Passwords should always be at least ten characters long, rather than eight characters long.

Hi,
When creating a login, passwords should be at least 10 characters long apparently.
When I specified 8 characters long password, "too short" error always occurred.
This is regarding SQL Database managed instance.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a0f4b3be-5686-ac31-8c5d-676e08953d8f
Version Independent ID: 43881484-714e-d528-7a38-72d24a2d40d1
Content: CREATE LOGIN (Transact-SQL) - SQL Server
Content Source: docs/t-sql/statements/create-login-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @VanMSFT
Microsoft Alias: vanto

@LifeRyuto Sounds good, we'll get an update to this documentation out shortly.

Thanks @LifeRyuto! I've fixed the doc, and it should go live shortly. Thanks again for helping us on this!


Drop request_counts table

The table is unused since CAPI 1.120.0 (Oct. 2021) and the corresponding model class has been removed with CAPI 1.140.0 (Oct. 2022).

[x] I have reviewed the contributing guide

[x] I have viewed, signed, and submitted the Contributor License Agreement

[x] I have made this pull request to the main branch

[x] I have run all the unit tests using bundle exec rake

[ ] I have run CF Acceptance Tests

Please hold off on merging this for now.  We'll need to come up with a strategy for handling this as we have some foundations that are not past CAPI 1.120 yet

Please hold off on merging this for now. We'll need to come up with a strategy for handling this as we have some foundations that are not past CAPI 1.120 yet

Okay, I've converted the PR to a draft.


Import could be included in the New API samples

https://github.com/softwaremill/reactive-kafka/blob/master/docs/NewAPI.md
Currently, trying to copy-paste the Core code sample, leads one to needing to decide between two Consumer classes of reactive-akka:

There would be two ways to avoid this:

not use the same class name in multiple parts of reactive-akka
providing the necessary imports in the code samples

There are pretty many APIs to reactive-kafka, at the moment. Is it the intention that one of these (the kafka2 files) would remain, or all of them?
If all, then the pros and cons of different approaches should be explained somewhere, and the approaches be clearly separated in the code, e.g. by using namespaces (as already kafka and kafka2 are separate, but maybe with more descriptive names?).

From my point of view we should keep only one API. This API should provide all functionality. I call it low level API.
On top of low level API we could build high level components with predefined behavior. Like consumer as Source without commit In at all.
@kciesielski what do you think?

Current readme contains all imports


Adds example for sending a command to a device

If a device is not connected via MQTT, send command to device will fail.

Thanks for your review!


Link Proposal to Policy, refactor engine, reset migrations

TO DO:

[x] Update starter kit policies and update documentation. Wait until Ricky's starter kit change goes in.
[x] Add test for celery task func
[x] Update documentation around PolicyEvaluation
[x] Update sample policies. There was an api change for get_yes_votes etc, since "proposal" is no longer a thing.
[x] Move community_post to PolicyEvaluation instead of PlatformAction

Data model changes

Made BaseAction concrete. Implementing a migration for this change is complex so we decided to reset migrations for this PR instead.
Changed Proposal model. Proposal now represents an evaluation of a single action against a single policy. It has foreign key references to BaseAction and Policy.
Remove MetagovProcess from metagov integration. This model is no longer needed, since we can store the governance process URL and JSON data on the Proposal record. The authoring API for initiatating generic metagov processes has not changed.
Some changes to django_db_logger so logs are tied to specific evaluations
Removed action_codename in favor of action_type and make it a calculated property so each model doesn't need to add it manually

Refactor changes

Move Policy Engine logic out of views.py into engine.py
Consolidate the policy execution code. Instead of having separate functions for check_policy and initialize_policy etc, we have one exec_code_block function that's used for all blocks. All blocks get the same context available to them.

Changes to policy authoring API

Implements proposal from https://github.com/amyxzhang/policykit/issues/440#issuecomment-891940276
Authors now have access to all available PlatformCommunity instances as in-scope variables slack/discord/discourse etc. They are still accessible via action.community and policy.community too, so this isn't a breaking change.
debug("..") is removed in favor of logger which can be used like a typical Python logger. This allows authors to log at different levels, and we can eventually add filtering on the log page for that. This is a breaking change for policies that use "debug".

UI changes
Now you can see policy data in the "pending actions" and "logs" views:

Random thoughts

Unhandled edge case: what if a user receives can_execute permissions while an action is in pending state? we don't re-check that with each evaluation
We should have the evaluation be passed to initiate_vote (and post_message etc) magically, without the author needing to pass it in. We can wrap the functions somehow. Then the authoring signature can just be initiate_vote(users=None, template=None, channel=None) instead of initiate_vote(action, policy, users=None, template=None, channel=None).

closes https://github.com/amyxzhang/policykit/issues/443

This is ready to go, but we are going to wait until https://github.com/amyxzhang/policykit/pull/435 goes in. After that, I'll make a few changes to the starter kit policies on this branch.
When this does go in, here are the db reset instructions for postgres. This does NOT backup most things, it just downloads the policies so they can be re-uploaded to new communities.
# IN POLICYKIT DIR WITH ENV ENABLED:
python manage.py shell -c "exec(open('scripts/download_all_policies.py').read())"

# close all database connections (adjust based on your service names)
systemctl stop celery celerybeat
systemctl stop celery-metagov celerybeat-metagov
systemctl stop apache2

# IRREVERSIBLE!!!! drop and recreate databases. adjust db name and user to match what you have in settings.py.

sudo -u postgres psql
drop database policykit;
create database policykit with owner policykituser;
drop database metagov;
create database metagov with owner metagovuser;
\q

# IN METAGOV DIR WITH ENV ENABLED:
python manage.py migrate

# IN POLICYKIT DIR WITH ENV ENABLED:
python manage.py migrate
python manage.py migrate actstream --fake  # only  if you get an error...
python manage.py showmigrations
python manage.py migrate
python manage.py shell -c "exec(open('scripts/starterkits.py').read())"

# restart everything (adjust based on your service names)
systemctl start celery celerybeat
systemctl start celery-metagov celerybeat-metagov
systemctl start apache2

@amyxzhang alright this is good to go I've tested it out on my server (https://policykit.metagov.org/main/)

Yay exciting!! Merging now.

This requires a database reset. Postgres instructions:
# download policies
python manage.py download_policies

sudo systemctl stop celery-policykit celerybeat-policykit celery-metagov celerybeat-metagov apache2

sudo -u postgres psql
drop database policykit;
drop database metagov;
create database policykit with owner policykituser;
create database metagov with owner metagovuser;
\q

# set up metagov
python manage.py migrate

# set up policykit
python manage.py migrate

sudo systemctl start apache2 celery-policykit celerybeat-policykit celery-metagov celerybeat-metagov apache2


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210717214142983 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210717214142983 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 42.571%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
26721

Relevant Lines:
56890

💛  - Coveralls


More generalized gen_ideal_test.py

Expected Behavior
gen_ideal_test.py should be restored to previous version to be truly a generalized test case. Or a new method that is more generalized and easier to produce tests with should be created.
Current Behavior
gen_ideal_test.py is an ideal test case for the Sleve work in #128
Possible Solution
gen_ideal_test.py should be moved to gen_sleve_ideal_test.py and the previous gen_ideal_test.py should be stored or a new idea test case that is more generalized and easier to produce tests with should be created.

Thanks Soren, the solution I would like to see (when someone has time) is gen_ideal_test with no CLI arguments does what it used to, then
gen_ideal_test.py --sleve generates the test from PR #126 (aka #128 )
gen_ideal_test.py --schar02 generates the test in PR #127
or something like that if possible.

@scrasmussen is it fair to say that it is somewhat general now, or do you still need to add more configurability to it?

@gutmann thanks for the reminder. I have a branch laying around with the changes I wanted, I just need to merge in the upstream changes and then create a PR.


Inform user when local burst differs from VM burst

Currently, if you update burst version locally but there is already a VM running, things don't work and feedback is not transparent.

Need to understand what this means


Keystone: admins needn't be in the db

...otherwise bootstrapping is hard.
Per our discussion on #615.
//cc @henn, @gsilvis, @knikolla

Just realized a fairly glaring error in my test; will fix when I get back to my machine.

Looks good with the anticipated test change.
In addition to a positive test checking that a different project-admin can access stuff, would it be possible to add a negative test too that ensures a regular user with authorization to a non-HIL project can't access anything?

@henn, just fixed the typo and the test, and pushed. Tests pass on my local machine, just waiting on travis.
re: the test you propose, I believe this is what test_anyone_call_unknown_project does. Let me know if I've misunderstood what you're asking for.

Looks good.  +1

+1, merging.


Socket recv_errqueue:deferred copy occurs message

Hi,
I will like to know what this message means: "PhotonLibOS-main/net/basic_socket.cpp:287|recv_errqueue:deferred copy occurs, might harm performance" and the reason it appears.
I am testing  tcp_socket_server / tcp_socket_client  vs zerocopy_tcp_server/zerocopy_tcp_client  with / without TLS

I am getting the 'deferred copy occurs' message when using either tcp or zerocopy_tcp.

One message on the client and one message on the server.
During the connection there is one stream->send and one stream->write

When TLS is used, I get 4  'deferred copy occurs' messages on client and 4 times on server

Also, are there plans to support TLS 1.3?
Thanks.

https://docs.kernel.org/networking/msg_zerocopy.html#deferred-copies
This is a hint for you that your message has been actually copied.
According to my observation, if you are monitoring the net interface by iftop, you are likely to get that message from kernel.

FYI, io_uring socket also has the zerocopy support.

I'll ask my teams first for the TLS. And what is the core feature you want from TLS 1.3?

I'll ask my teams first for the TLS. And what is the core feature you want from TLS 1.3?

I believe TLS 1.3 is twice as fast  for handshake than TLS 1.2 since its one round trip instead of two. Also it has a feature where it 'remembers' the handshake for previous endpoint it has connected to so no need to have handshake again. This really helps for HTTPS connections which I am planning to implement as well.

I'm afraid that right now we don't have plans for TLS 1.3. If you can contribute some code in net/security-context/tls-stream.cpp, it would be appreciated.

TLS 1.3 has changed API, and it seems incompatible with libcurl.


Asking about the Embedding from Gemini API

Do you have plan to add the embedding model from Gemini API

Duplicate with https://github.com/run-llama/LlamaIndexTS/issues/286


database store tests and documentation

Added documentation for the database store
Added tests for the database store, and found a bug or two

okay, so this does look good to me, but could someone with more go expertise check this? @nilueps

@nilueps  if it lgty, you can add the comment, we got some good review on this

/lgtm


HADotNet - fix for states API

Hi Jake,
Hope you are doing well.
I noticed a minor issue with states API - would you please take a look and merge once you have time?
Thanks

Have a look at:
https://github.com/qJake/HADotNet/blob/e4f6d97bd26d7b80b0091da434de706019d868a3/HADotNet.Core/BaseClient.cs#L63
In BaseClient, when Post<T> is called, there is an optional parameter for isRawBody which by default is false.
Therefore, in the StatesClient, when Post is called with the anonymous object new { ... }, it is serialized by the base client.
Feel free to open an issue if you think this behavior isn't working, and/or try a unit test to see what's going on.

Hi Jake,
Yes, you are right, but without the changes that I'm suggesting the code is sending a string Newtonsoft.Json.JsonConvert.SerializeObject(new { state = newState, attributes = setAttributes }) and isRawBody =false, which leads string to be serialized the second time in BaseClient (because isRawBody = false).
Please let me know if you need more details - I can provide more code examples with screenshots.
THanks

Oh I see! Yes, I'm sorry, I read that wrong.
Thanks for fixing this! I will try and do a release soon that includes this.

Thanks a lot Jake!

@imalkevich Sorry for the delay, v1.3.1 has just been published with these changes!

Hi Jake (@qJake ) ,
Great, thank you and thanks for the heads-up!
Thanks


optimize docstring and html

Hi @number1roy , can you resolve the conflict for this PR. I have two suggestions for this PR.

split this PR by module, submit one PR for the docstring change in one module only
change the docstring in each PR to Google style for consistency as mentioned yesterday


Rename tests

Renames version catalog tests, as I'm always wondering what I used as the base name :)

@bot-gradle test QFL

OK, I've already triggered QuickFeedbackLinux build for you.


v1.3 with HPA

You missed the version updates in the package.json files

https://github.com/openshift-cs/ostoy/blob/master/package.json#L3
https://github.com/openshift-cs/ostoy/blob/master/microservice/package.json#L3

Otherwise LGTM 👍🏻

Corrected and updated the version there.
Thanks!


118 Pascal_Triangle

@FreeTymeKiyan

Great to see that you actually use recursion to solve the problem. It's very good practice. But the code looks a bit messy. It would be much cleaner if you use loop instead.

I code in the leetcode first and copy to eclipse. The JavaDoc comment is from eclipse and the tab width is 4 in leetcode...

@JoannaCode Then you probably need to format it using IDE before commit.

OK. Let me try. I use JS instead of Java in work. So I am not familiar with Java format ...


Maybe a wrong loss function

Hello, Takeru, Thanks for your great works.
I find that there may be an error with your code, at the 46th line in vat.py:
" dist = L.kl_divergence_with_logit(logit_p, logit_m)",
where I think you may add a negative sign before  KL_divergence, because here we want to maximize the distance to get the virtual adversarial direction.
Am I right?

Hi,
It's not wrong. The "positive" gradient of dist is the direction whose maximizes dist (i.e. KL divergence).
I speculate that you are confused it with the gradient descent algorithm, in which we add "negative" gradient to a variable.

Hi, Takeru,
Thanks for your kind reply, I was indeed confused it with the GD algorithm.
But I still have another question as following:  according to the code, we know that the 'd' is randomly initialized first, and the gradient 'grad' on current  'd' is calculated,  then this gradient 'grad' is taken as the 'r_vadv'. While my point is that we should take the 'd+grad' as 'r_vadv', because the summation of these two vector is actually the adversarial direction against the current sample x. Do you think so?
Looking forward to your reply, thanks again!

Right, that would be another option for estimating the adversarial perturbation and might improve the performance.
The code we upload is the implementation of the power iteration method which we use to estimate the most vulnerable direction. See Section 3.3 in the paper https://arxiv.org/pdf/1704.03976.pdf.


how to apply constraints before construct graph?

from the source code, I find the constraints of weights in keras just apply after each gradient descent updating. could I apply it at weights directly?
for example, at Dense layer, kernel_ constraint=unit_norm, can I define x*unit_norm(W) rather that x*W?

same problem: https://github.com/keras-team/keras/issues/9068


koord-scheduler: improve the readability of the PreFilter error message of the DeviceShare plugin

Ⅰ. Describe what this PR does
Currently, the error message of PreFiltre in DeviceShare plugin cannot be understood intuitively.
This PR will improve the readability.

Ⅱ. Does this pull request fix one issue?
fix #840

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in make test

/lgtm


Is "*.ext matches .ext" related to 8.3 names?

In Provider specific filters, it is stated that "*.ext where ext is three characters matches *.ext*".
This reminds me of a legacy Windows feature: on some systems, files with long names or extensions get a 8.3 name for DOS compatibility. For example, a file "application.docx" may get a short name "applic~1.doc" and matches *.doc. This feature can be controlled by the fsutil command.
Do you think this is the reason?

Yes, I think this might be the reason, directly or related. Some obsolete and probably related API is still in use. Maybe for some compatibility, maybe it's actually good. Thank you for the info about fsutil, it's new to me. Of course it cannot fix the issue as such for us, PS scripts/tools writers. Scripts cannot count on the issue "fixed".


how to run dso multiple times in a loop

Are there any special considerations that need to be taken into account when using DeepSymbolicOptimizer multiple times within a python program?
Currently we are looping over a set of datasets. In each loop iteration we create a new DeepSymbolicOptimizer object and execute training on it. This seems to work when running on a single core other than of course being slow. When running on multiple cores the program seems to deadlock. Specifically, all printing stops and running top on linux reveals all python processes all using 0.0% CPU. When we do a keyboard interrupt, many processes return stack traces that seem to be waiting for locks. If it's helpful we can provide more detail on the code and or the specific stack traces.

That's a good question. In general the DeepSymbolicOptimizer object is not thread safe--tensorflow does not make creating multiple TF-based objects like this easy.
One option is to use the n_cores_batch parameter. Your multiple training runs will still run in series, but each one will leverage multiple cores.
Otherwise, for batch tasks, you'll be better off parallelizing the entire program and having each one create a single DeepSymbolicOptimizer object called with your different datasets.

Okay thank you for the explanation.
We tried parallelizing the entire program and restricting to one DeepSymbolicOptimizer object per process and that seems to be working.


ContentView appears twice on your table.

ContentView appears twice on your table.

Copy-pasta error, fixed. Thank you!


Problems with Mapillary layer

Hi there.
Since last iD update, I stopped having access to Mapillary image layer.
I didn't see this mentioned elsewhere, so maybe some kind of local issue, but I tested this with Firefox, Chrome and Opera (all last versions for W10). Firefox shows a black screen when clicking on a image in the image stream. Chrome and Opera shows nothing (not even the stream).

Yep, also having some issues, seeminly CORS related

Hi!
We're working on fixing this soon, it is indeed not a local issue: the CORS headers on Mapillary vector tiles are not set correctly right now.
Sorry for the inconvenience, I'll post an update when the issue is fixed!

Thanks for raising this @AntMadeira.
I remember testing this when v2.20.0 was deployed and it was working. @nickplesha I suppose you had some recent changes to mapillary services? Can this be addressed by updating services on your side only?

Yes, this will be fixed on our side.

Hi! The vector tile issue has been fixed now. Sorry for the inconvenience!


Can you add link of my port to readme?

Hello, first of all thanks for easy to use and lightweight tool. I ported it to Stylus. Can you add link in your readme?
I have not npm and bower package yet, but i will do it in the near future.
https://github.com/OlegWock/stylus-angled-edges

Nice! Added!

Thanks you :3


[FLINK-19844][python][docs] Add documentation for Python UDAF.

What is the purpose of the change
This pull request adds documentation for Python UDAF.
Brief change log

Add documentation for Python UDAF.

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (docs)

@dianfu Thanks for your review! I have updated this PR.


mu

https://www.youtube.com/watch?v=6oAVUe3Zw1Y

https://github.com/deeppaz/serenes/commit/18792ba1e77985163ac823f8a9b3aadb7a9fb3a4 closed


Help Wanted: Remove configuration settings from documentation

Context
4 experimental configuration settings are no longer active in the product code base and can be safely removed from product documentation.
Documentation Ask
Remove the following 4 configuration settings (including their associated search meta data located directly above each section title):

Latest Android version
Minimum Android version
Latest iOS version
Minimum iOS version

@cwarnermm Hi, I would like to pick this up, can you assign it to me?

I'd be happy to, @Crossbears! Thank you!

@cwarnermm hey Carrie , I’d like to pick up this issue. Can you assign it to me?

Hi @thomasalex122 - Another contributor is working on this issue.

@cwarnermm Thanks for the update!

@Crossbears - Are you actively working on this issue?

@cwarnermm If there is no update from the contributor's end, feel free to assign this to me. Thanks.

Thanks, @Rutam21!


Some minor bugs.

weight init
In the original paper, he initialization is used instead of xavier, this would translate to using: tf.contrib.layers.variance_scaling_initializer
max pooling
In the original paper, the transition down should be a 2x2 max pool that is non-overlapping. Checking the original Lasagne code it seems they use a 2x2 max pool with a window of 2x2 and stride of 2x2. Wasn't sure if your current 4x4 window as intentional.

Great work on this btw, very readable!

Thank you for the feedback.
Yeah sorry about those, I made this because of a project I was working on, so I may have changed the pooling window and weight inits. Good catch, I'll restore them to the originals.


Is it possible to make dependency versions more inclusive?

In setup.py, all dependencies are stated with "==". This prevents us from using imageai with another library which uses a newer version of these dependencies on the same virtual environment. Is it possible that the dependencies are stated in a more inclusive way like ['numpy>=1.19.3','scipy>=1.4.1','pillow>=8.1.1',"matplotlib>=3.3.2", "h5py>=2.10.0", "keras-resnet>=0.2.0", "opencv-python", "keras>=2.4.3"] ?

this project is dead

Agreed. You can create a PR to fix this. I will gladly review it.


ThyroidAlvarez

Project short name:
ThyroidAlvarez
Primary Wrangler:
Ida
Secondary Wrangler:

Associated files:

Google Drive: tbd

Key Events

[ ] Send initial instructions about contributing, including questionnaire and T&Cs
[ ] Receive project questionnaire
[ ] Assign the Primary Wrangler
[ ] Receive T&C form filled out by at least 1 representative of group/project
[ ] Send custom metadata template spreadsheet, how-to guide and directions for submitting data, matrix and cell annotation files.
[ ] Receive spreadsheet (to a sufficient standard to submit dataset)
[ ] Receive data, matrix and cell annotation files (to a sufficient standard to submit dataset)
[ ] Curate metadata spreadsheet with ontologies
[ ] Upload sheet to validate metadata
[ ] Run graph validator & Check linking
[ ] Validate data files
[ ] Ask the Secondary Wrangler for an end-to-end review of the project. Ask the Expertise Wrangler to review specific tabs if needed
[ ] Get final approval of submission from the contributor including release date, metadata spreadsheet and data files
[ ] Submit to production and inform ingest-devs the project is ready for archiving
[ ] Complete the Export SOP
[ ] Convert project data to SCEA format following the SCEA conversion SOP if appropriate

Please track the below as well as the key events:

Track date first spreadsheet received and final spreadsheet sent by editing ticket to include
date next to event.
Track spreadsheet iterations by placing asterisks next to receive spreadsheet event.
Track any metadata issues/tickets made for dataset with a bulleted list of links under
received spreadsheet event. Links should be to the ticket in the metadata repo.

Looking at the reply in the dataset questionnaire row 80 I think we can't wrangle nor archive this dataset right now
I will get back to them and let them know we can't do it


"Python not installed" diagnostic despite showing an interpreter in the status bar

Environment data

VS Code version: 1.45.1
Extension version (available under the Extensions sidebar): 2020.5.78807
OS and version: Catalina 10.15.4
Python version (& distribution if applicable, e.g. Anaconda): 3.8.0
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv

Expected behaviour
Be able to create a folder or workspace for Python projects.
Actual behaviour
Popup error saying that Python is not installed.
Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]
I just started using VSCode. I installed the Python Extension (2020.5.78807). I have python 3.8.0 installed. I can confirm that by running python --version in the terminal in VSCode. The interpreter in the bottom left of the screen shows as 3.8.0. Command pallet shows the same interpreter.
I can create a new file and save it as a .py and it works with no issues. However, if I create a folder or a workspace and then create a file in that, I get a popup saying that Python is not installed (source: Python(Extension).
The code still seems to run ok. I tried uninstalling and reinstalling the extension but no luck. Any thoughts on how I can get rid of this error?

Hi @basharatusman, thank you for reaching out.

Can you also copy here the output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)?
Last but not least, can you try installing an older version of the extension (for example 2020.4.76186), and see if your problem happens?
You can follow the prompts from "Extensions: Install Specific Version of Extension..." in the command palette:

Or you can open the extensions side bar, click on the settings for the Python extension and pick "Install Another Version...":

Thank you!

@kimadeline thank you for the response.

I installed python using Homebrew
I normally click open folder on the welcome screen in VSCode. Then navigate to Documents and click create new folder on the bottom left of the directory selection popup and create a new folder. Then I create a .py file in that that folder in VSCode and get the error.
I rolled back to 2020.4.76186 on the extension but still getting the error

Here is the output for python. Quick note - I have started using Conda instead of Venv since the original post.
User belongs to experiment group 'AlwaysDisplayTestExplorer - control'
User belongs to experiment group 'ShowPlayIcon - start'
User belongs to experiment group 'ShowExtensionSurveyPrompt - enabled'
User belongs to experiment group 'DebugAdapterFactory - experiment'
User belongs to experiment group 'PtvsdWheels37 - experiment'
User belongs to experiment group 'UseTerminalToGetActivatedEnvVars - control'
User belongs to experiment group 'AA_testing - control'
User belongs to experiment group 'WebHostNotebook - control'
User belongs to experiment group 'LocalZMQKernel - control'
User belongs to experiment group 'NativeNotebook - control'
User belongs to experiment group 'CollectLSRequestTiming - control'
User belongs to experiment group 'CollectNodeLSRequestTiming - experiment'
User belongs to experiment group 'EnableIPyWidgets - experiment'
User belongs to experiment group 'RunByLine - control'

conda --version
pyenv root
python3.7 ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
python3.6 ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
python3 ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
/usr/local/anaconda3/bin/python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
python2 ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
Starting Jedi Python language engine.
Diagnostic Code: NoPythonInterpretersDiagnostic, Message: Python is not installed. Please download and install Python before using the extension.
Python interpreter path: /usr/local/anaconda3/bin/python
conda info --json
conda info --json
conda info --json
conda info --json
/usr/local/anaconda3/bin/python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.prefix)"
cwd: ~/Documents/VSCode/test2
/usr/local/anaconda3/bin/python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.prefix)"
cwd: ~/Documents/VSCode/test2
/usr/local/anaconda3/bin/python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
cwd: ~/Documents/VSCode/test2
/usr/local/anaconda3/bin/python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
cwd: ~/Documents/VSCode/test2
/usr/local/anaconda3/bin/python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())"
cwd: ~/Documents/VSCode/test2
/usr/local/anaconda3/bin/python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())"
cwd: ~/Documents/VSCode/test2
/usr/local/anaconda3/bin/python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py site --user-site
cwd: ~/Documents/VSCode/test2
/usr/local/anaconda3/bin/python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py site --user-site
cwd: ~/Documents/VSCode/test2
/usr/local/anaconda3/bin/python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py flake8 --max-line-length=120 "--ignore=F401, F841" --format=%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s ~/Documents/VSCode/test2/main.py
cwd: ~/Documents/VSCode/test2
/usr/local/anaconda3/bin/python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py flake8 --max-line-length=120 "--ignore=F401, F841" --format=%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s ~/Documents/VSCode/test2/main.py
cwd: ~/Documents/VSCode/test2
conda env list
/usr/local/anaconda3/bin/python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/completion.py
/usr/local/anaconda3/bin/python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/completion.py
##########Linting Output - flake8##########
conda env list
/usr/local/anaconda3/bin/python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py -c "import notebook"
/usr/local/anaconda3/bin/python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py -c "import jupyter"
/usr/local/anaconda3/bin/python ~/.vscode/extensions/ms-python.python-2020.5.78807/pythonFiles/pyvsc-run-isolated.py jupyter kernelspec --version

I couldn't reproduce your issue following the steps you outlined:

It looks like there's some race condition happening though, because the logs you copied show that an interpreter is found:

Diagnostic Code: NoPythonInterpretersDiagnostic, Message: Python is not installed. Please download and install Python before using the extension.
Python interpreter path: /usr/local/anaconda3/bin/python

Can you try rolling back to even older versions of the extension (2020.3.71113, 2020.3.69010, or even 2020.2.64397) so we can pinpoint when this behaviour was introduced?

The issue starts at 2020.3.71113. If i roll back to 2020.3.69010 or earlier then I don't get the error.

I have the same problem, I couldn't fix it. It makes no harm, you can just dismiss the dialog but it is quite annoying.

@kimadeline Thanks! Install an older python extension version solved my problem. It seems that the latest python extension has bugs that cannot find a python interpreter even I reset the python path in settings and my project settings.

Seems like a race condition in the extension 🤔

Possible solutions:

Move the Python interpreter diagnostics (InvalidPythonInterpreterService in diagnostics/checks/pythonInterpreter.ts) to be run after activation
In the Python interpreter diagnostics, replace

https://github.com/microsoft/vscode-python/blob/48ea30382bb7166eae2367706bd0239f15b75262/src/client/application/diagnostics/checks/pythonInterpreter.ts#L70
with
let hasInterpreters = await interpreterService.hasInterpreters;
if (!hasInterpreters) {
     hasInterpreters = (await interpreterService.getInterpreters()).length !== 0;
}

Change hasInterpreters directly so that it doesn't return early if the promise hasn't completed, aka change
https://github.com/microsoft/vscode-python/blob/79840763ea52dcff4b5cd6f6b1926b10b93f22d1/src/client/interpreter/locators/index.ts#L62

to
     return this._hasInterpreters.promise;

⚠ This change was introduced with the (now defunct) conda run changes because we would call hasInterpreters to check if we found any conda environments, but getInterpreters hadn't been called yet so we'd end up blocked waiting for it to complete (which caused Windows test failures).

Initialize _hasInterpreters as undefined, and move the createDeferred called to getInterpreters. Then update the logic in the hasInterpreters getter to:

if _hasInterpreters is undefined
    call getInterpreters

    return this._hasInterpreters.promise;

Instead of hacking around hasInterpreters it would be better if we made the interpreters list observable, which should be done when we refactor interpreter discovery.

We released a fix for this, but if people are still having issues please do let us know.

the problem is still there, I installed python using brew, after that I got this error

@odddemid What is the version of the Python extension that's installed?

Maybe this will help someone, VSCode did not see the folder "usr/local/bin", I opened the terminal, entered the command "code /" after which the system showed a notification requesting access to the disk, network folders, desktop, etc. I gave full access rights and after that I got a list of possible versions of python.
Unexpected solution to my problem, I don’t understand why VSCode didn’t request access rights when opening it for the first time

Closing as fixed. Let us know if you have any issues and we'll reopen.

Can confirm that the latest version of the Python extension has this problem. Fixed using @dehan-jl's suggestion.

@dehan-jl @ZhiJianTan Can you guys please reinstall the latest version of the extension & provide the logs? I'm suspecting to see something similar to https://github.com/microsoft/vscode-python/issues/13581.

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

I stumbled upon the same question.
Here is what I did:

Uninstalled the Python extension.
And then install it again.
Refresh/Restart Visual Studio Code.

@Soban06 Can you please send the information I asked earlier https://github.com/microsoft/vscode-python/issues/11870#issuecomment-680052900?

https://github.com/microsoft/vscode-python/issues/13945#issuecomment-695834483
This solved the issue for me on Windows.

Encountered same issue in latest version. Same fix (deleting extension folder and install again) worked. https://github.com/microsoft/vscode-python/issues/13945#issuecomment-695834483

Encountered same issue in latest version. Same fix (deleting extension folder and install again) worked. https://github.com/microsoft/vscode-python/issues/13945#issuecomment-695834483

Hi @basharatusman, thank you for reaching out.

Can you also copy here the output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)?
Last but not least, can you try installing an older version of the extension (for example 2020.4.76186), and see if your problem happens?
You can follow the prompts from "Extensions: Install Specific Version of Extension..." in the command palette:

Or you can open the extensions side bar, click on the settings for the Python extension and pick "Install Another Version...":

Thank you!

@kimadeline I came here from 9576. I was having the same problem as folks on that issue. So, I tried your suggestion of installing an older version of Microsoft Python extension and yay! VScode not only recognizes my globally installed python, but also any of my virtual env versions with no problem.
Thank you!
My OS is Ubuntu 20.04 LTS and I remember updating my OS with some vscode upgrades very, very recently. Basically, going back about a month back in terms of the Microsoft python extension's version allows python to be recognized by vscode.


data: add Samuelchigozie

I added my name to the file
Related issue

What changes does this PR do?
Screenshots (If any)
Questions

closing due to inactivity feel free to reopen at any time


Hover performance issues

Expected behavior
It should be instantly visible and not fade in like it does. It should also not drag across the entire chart to display it.
Current behavior
The hover is incredibly slow to display and drags across the entire chart and is barely visible at some points.
https://user-images.githubusercontent.com/47824008/205195284-779fa440-1bfe-4fa8-b487-7e297fcc3624.mp4
Reproducible sample
N/A
Optional extra steps/info to reproduce
No response
Possible solution
No response
Context
No response
chart.js version
v4.0.1
Browser name and version
No response
Link to your project
No response

As per the issue template a reproducable sample is mandatory, please add one.

As per the issue template a reproducable sample is mandatory, please add one.

I'm not able to reproduce it in a sample. Would a code sample be more acceptable?

Did you set a long animation duration for the tooltip? The default is 400ms. Hard to tell from the video if this is a perf problem or just a really slow animation

Did you set a long animation duration for the tooltip? The default is 400ms. Hard to tell from the video if this is a perf problem or just a really slow animation

options={{
      maintainAspectRatio: false,
      animation: {
        duration: 25,
      },
      hover: {
        intersect: false,
      }
}}

Removing the animation duration does not change this.

How about removing the intersect: false from hover? (Not sure if its really hover if you dont need to have the cursor over the thing)


add auto-generation of TOC

Can probably scan the  tags and generate a set of nested lists.

TOC is generated now - assumes headers are used sensibly;

document should start with h1
document should only increase header type by one step at a time

But you can obviously go straight from h4 to h2 etc. This is just to map it sensibly onto a ul li tree structure.


zydis: split zycore into separate derivation

Description of changes
This PR splits the Zycore dependency that was previously pulled in via fetchSubmodules into a separate derivation. The package previously didn't install the Zycore headers and CMake configs, making it impossible to actually compile any code that uses Zydis because Zydis includes Zycore headers.
Essentially, the tl;dr here is:

CMake's install rule doesn't install headers and config for dependencies
Zycore is a separate package with separate versions
Zydis headers #includes Zycore headers which are currently not installed

Instead of adding code that manually install the missing files somehow, I figured that it'd probably be most idiomatic to properly build it as a separate derivation. Zycore isn't widely used for anything but a helper to Zydis, so I didn't put it into a completely separate package. I don't feel strongly about that and am also perfectly open to making it a top-level package instead, though I don't think that many people will ever use it.
I also added myself as a maintainer for the package.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux (via qemu)
[x] x86_64-darwin (via Rosetta)
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

CC @jbcrail @AndersonTorres

Thanks for the swift review! I addressed both comments.

Hey, @athre0z. Sorry for digging up something this old, but I'm trying to build a project with a find_package(zydis CONFIG REQUIRED) in their CMakeLists.txt and after adding zydis to the nix dev environment, I get this error when running cmake:
CMake Error at /nix/store/rv1sx6lj8x5ffik7vzy0m3w0a4ci6pnx-cmake-3.29.6/share/cmake-3.29/Modules/CMakeFindDependencyMacro.cmake:76 (find_package):
  By not providing "FindZycore.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "Zycore", but
  CMake did not find one.

  Could not find a package configuration file provided by "Zycore" with any
  of the following names:

    ZycoreConfig.cmake
    zycore-config.cmake

  Add the installation prefix of "Zycore" to CMAKE_PREFIX_PATH or set
  "Zycore_DIR" to a directory containing one of the above files.  If "Zycore"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  /nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/lib/cmake/zydis/zydis-config.cmake:30 (find_dependency)
  CMakeLists.txt:8 (find_package)

Should there have been a ZycoreConfig.cmake/zycore-config.cmake file installed as part of the zydis package?

$ find  /nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/bin
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/bin/ZydisInfo
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/bin/ZydisDisasm
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Generated
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Generated/EnumRegister.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Generated/EnumInstructionCategory.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Generated/EnumISAExt.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Generated/EnumMnemonic.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Generated/EnumISASet.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Utils.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Status.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Disassembler.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/SharedTypes.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Segment.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Mnemonic.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Zydis.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Formatter.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Decoder.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Internal
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Internal/DecoderData.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Internal/FormatterIntel.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Internal/FormatterBase.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Internal/EncoderData.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Internal/SharedData.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Internal/FormatterATT.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Internal/String.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Defines.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/DecoderTypes.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Encoder.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/ShortString.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/Register.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/MetaInfo.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/include/Zydis/FormatterBuffer.h
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/lib
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/lib/libZydis.a
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/lib/cmake
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/lib/cmake/zydis
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/lib/cmake/zydis/zydis-config-version.cmake
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/lib/cmake/zydis/zydis-config.cmake
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/lib/cmake/zydis/zydis-targets-release.cmake
/nix/store/n1x4n3bw11j8vkjgs2i5byi4vh4k6waz-zydis-4.1.0/lib/cmake/zydis/zydis-targets.cmake

can you try whether adding the Zydis dependency with (pkgs.zydis.overrideAttrs (_: _: { propagatedBuildInputs = [pkgs.zydis.zycore]; })) resolves the issue?

It did! Thanks!


Remove soapAction if it is null

Remove soapAction if it is null
Fix https://github.com/wso2/product-apim/issues/5672

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Caught two more small errors

Review:

In the README.md file, there is a typo in the word "Github". It should be "GitHub".
No other changes are necessary.

Thank you, @VictorHugoPilled, for your contribution to the Superagent project! 🙏🏼🚀

Thank u @VictorHugoPilled


refactor: drop dependency on safe-buffer

I'm like 80% sure we don't need this :) . @stephenplusplus now that we're node.js 6 and up, we don't need this right?

Yeah, I think we're good now.


Allow onException timer handler to catch exceptions thrown in async m…

Allow onException timer handler to catch exceptions thrown in async methods
Developing my service I came across problem which took me a while to debug. The problem is that when someone passes async lambda method to Timer onStart handler - onException handler will not be triggered. I believe it's because of the type of onStart handler wchich is Action. One solution would be to just wrap body of lambda function in additional try catch block:
Timers.Start("Poller", 10000, async () =>
{
    try
    {
        await ThrowAsyncException();
    }
    catch (Exception ex)
    {
        _logger.LogError(ex.Message);
    }
}, (err) => { _logger.LogError($"Handler: {err.Message}"); });

But it does not feel right with a method which exposes explicit handler for this.

Thanks! I am rly busy with other stuff right now so it's taking a while to react to these. It makes sense and I am all for improving debug experience. I kind of dislike the repetition in code this brings. Would be great if this could have been handled with one approach. I might look into this further to see if I can find a better solution, but if not, I'll be happy to merge and release this.


Add bin-ops and float:compare for comparing Floats

Adds the >. >=. <. <=. binary operators for comparing Floats (fixes #208).
Adds the float:compare function to the stdlib (fixes #209).

@lpil: Fixed up the integration test to comply with #215. 🙃


tests: removes eager upgrade to okhttp alpha 5

the junit5 extension was written to depend on okhttp5, which hasn't been updated in a year and introduces classpath conflicts. This reverts that, so that the extension is useable in projects that use okhttp and would otherwise conflict on the okio dep okhttp5 brings in.
We need to release a patch after this to unlock zipkin-reporter

I checked in zipkin-reporter that this works even with okhttp 3.14.9 in the classpath.

closing this out as the root cause was an unnecessary dep. The benefit of this is that it excludes the junit:junit dep. After a close look while okhttp isn't releasing as often as before, it is being worked on in the main branch, so not a big deal to keep as is.

https://github.com/openzipkin/zipkin-reporter-java/pull/221 shows it works as is in the reporter, and I don't expect any issues with zipkin-finagle that also uses it in our org.
helidon which is the other main consumer doesn't appear to have a conflict and we can re-open this if that's unresolvable. I can see in their code they are already working around okhttp kotlin stuff, so they may be ok resolving it, and if not we can re-open this.

Brave doesn't use this, but in brave, using mockwebserver3 creates an irresolvable classpath conflict on below:
java.lang.NoSuchMethodError: 'void okhttp3.internal.concurrent.TaskRunner.<init>(okhttp3.internal.concurrent.TaskRunner$Backend, java.util.logging.Logger, int, kotlin.jvm.internal.DefaultConstructorMarker)'

This should be reverted because the cure is worse than the disease (junit:junit dep which is already present in most apps). We can revisit when okhttp releases again

rebased and added comment


Blackbox testing using Robotium

From<EMAIL_ADDRESS>on June 13, 2015 10:11:53
Only .apk is available. My test Project is working fine and every test launches the app on the emulator.
solo methods like enterText(), clickOnButton() do not work . It simply scrolls to the bootom of the screen and throws an error that no editText field was found. I do not have the source code for the app.
Buttons, Image Views, EditText fields are not recognized it seems.
I am using Robotium-solo 5.2.1 and eclipse IDE for my test project
Help out friends, its quite urgent.
Original issue: http://code.google.com/p/robotium/issues/detail?id=684

From<EMAIL_ADDRESS>on June 15, 2015 09:20:22
Probably its a phone gap app that does not work with Robotium.
Status: Invalid
Owner<EMAIL_ADDRESS>


domain prop missing from PolarRadiusAxis

It seems domain has been added since then:
# The domain of the polar radius axis, specifying the minimum and maximum values.
domain: Var[List[int]] = LiteralVar.create([0, 250])


parser: returning 2 from on_headers_complete

Returning 2 from on_headers_complete will tell parser that it
should not expect neither a body nor any futher responses on
this connection. This is useful for handling responses to a
CONNECT request which may not contain Upgrade or
Connection: upgrade headers.
See: https://github.com/nodejs/node/pull/6198
cc @bnoordhuis @jasnell @mscdex
See also: https://github.com/nodejs/node/pull/6198#issuecomment-210857637

LGTM if tests pass.

@mscdex thank you, this is semver minor, right?

Assuming the original intention was for CONNECT to be handled in this way, then I would say yes.

Yeah, also existing code will work just as it was before.

A question for @nodejs/lts team, do you think this could be backported to v4.x.x? It seems that responses to CONNECT requests are currently a bit broken in LTS

The problem is that this is a semver-minor change in http-parser.

Alright, enough time to collect feedback. Landing.

Landed in 04d28a7, thank you everyone!


Add async job hooks

Bump Swift version to 5.5.2
Backport concurrency to older platforms
Add AsyncJobEventDelegate for async hooks
Replace Lock with NIOLock

I'll just merge for now, and then we can remove the #if in a later release (if able)

These changes are now available in 1.12.0


Throttling support?

I was wondering if it would be possible or how easy it would be to implement a throttling config switch in case you want to stop the logging in case something is flooding them (especially useful when wrapping the ADO appender)?
I saw some code on a forked project here https://github.com/salyh/log4net-asyncforwardingappender/blob/master/AsynchronousBufferingForwardingAppender/AsynchronousBufferingForwardingAppender.cs which says it does this so wanted to see if that's something that could be integrated to this lib?
Thanks!

While not a bad idea, I would keep the concerns separated . I would implement it as a separate forwarding appender.

OK thanks for the feedback, i'll see what i can come up with


Node.js Foundation Community Committee Meeting 2020-01-09

Time
UTC Thu 09-Jan-2020 17:00 (05:00 PM):

Timezone
Date/Time

US / Pacific
Thu 09-Jan-2020 09:00 (09:00 AM)

US / Mountain
Thu 09-Jan-2020 10:00 (10:00 AM)

US / Central
Thu 09-Jan-2020 11:00 (11:00 AM)

US / Eastern
Thu 09-Jan-2020 12:00 (12:00 PM)

London
Thu 09-Jan-2020 17:00 (05:00 PM)

Amsterdam
Thu 09-Jan-2020 18:00 (06:00 PM)

Moscow
Thu 09-Jan-2020 20:00 (08:00 PM)

Chennai
Thu 09-Jan-2020 22:30 (10:30 PM)

Hangzhou
Fri 10-Jan-2020 01:00 (01:00 AM)

Tokyo
Fri 10-Jan-2020 02:00 (02:00 AM)

Sydney
Fri 10-Jan-2020 04:00 (04:00 AM)

Or in your local time:

http://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Community Committee+Meeting+2020-01-09&iso=20200109T17
or http://www.wolframalpha.com/input/?i=05PM+UTC%2C+Jan+09%2C+2020+in+local+time

Links

Minutes Google Doc: https://docs.google.com/document/d/1tKHQ9kOvBBvzK6TmrAm0MPqzvxnVC7a-U1kr-fsNdSY/edit

Agenda
Extracted from cc-agenda labelled issues and pull requests from the nodejs org prior to the meeting.
nodejs/admin

Node.js Social Media Accounts #454

nodejs/community-committee

Remove individual membership director role and move williamkapke to emeritus #560
Add licenses to CommComm repositories #559
Starting an Examples Initiative #550
Community Committee and OKRs #547
Initiative #507 — Preparing questions for annual survey #538
Code & Learn in a Box #503
Node.js Social Media Community Collaboration #444

nodejs/nodejs-collection

Update readme with new process #37

Invited

CommComm Members: @nodejs/community-committee

Observers/Guests
Feel free to follow along on the YouTube live stream, or attend meeting as a guest
by calling in to Zoom, using the links below. If you will be attending as a guest,
please comment on this issue to let us know you'll be joining.
Notes
The agenda comes from issues labelled with cc-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.
Joining the meeting

Link for participants: https://zoom.us/j/527273462
For those who just want to watch: https://www.youtube.com/channel/UCQPYJluYC_sn_Qz_XE-YbTQ

Invitees
Please use the following emoji reactions in this post to indicate your
availability.

:+1: - Attending
:-1: - Not attending
:confused: - Not sure yet

Joining meeting, looks like the webinar expired.

Creating a new one now.

Thanks @bnb! 👍

https://zoom.us/j/523381536


refactor: use input parameters instead of environment variables

While testing this PR I found a few different issues with the current implementation of this action, so this increased a bit in scope.
TODO: explain in more detail
Related PRs:

https://github.com/Vandebron/github-actions/pull/253
https://github.com/Vandebron/Vandebron/pull/17046

Green monorepo PR run:

https://github.com/Vandebron/Vandebron/actions/runs/11713281241
https://github.com/Vandebron/argocd/pull/10182

This pull request changed a lot since you originally approved, so I asked for another round of reviews.


Update markdown templates

Hi @arpitjain099 - Since these are unpublished template files, we'll close this PR. Thanks for contributing!


Remove contract concise

Fixes #343  .
Changes proposed in this PR:

remove the contract;
replace with contract caller.

UPDATE: I modified the unit test test_dispenser_status, because after the replacement with contract.caller I noticed that the owner get a certain value for None which is the 0x0000000000000000000000000000000000000000000000000000000000000000 address.

I noticed this issue when I reproduced the marketplace-flow README, more exactly when I tried to create a pool, I received a deprecation warning due to contract concise. I will attach here how it looks right now

NOTE: Tested again with marketplace-flow README, works just fine.

@mariacarmina When you merge this, please do a "Squash and merge" so only 1 commit appears in the main branch history. The default title of this commit should be fine - it will be the title of the PR along with the PR # in parentheses.
The default body is usually not what you want - it puts all the commits from before the squash into a list of bullet points (including intermediate changes that may not be present in the final commit). I usually erase the default body and replace it with a more complete and succinct description of the changes.  Since I like to keep my PR descriptions up to date, I usually just copy and paste the list of changes from the description into the squash commit body.


[QUESTION] Export from blade view cause error

Package version, Laravel version
"maatwebsite/excel": "~2.1.0"
"laravel/lumen-framework": "5.5.*"
Expected behaviour
Export data from view.
Actual behaviour
I've this piece of code, to export data from a blade view:
 $this->export->create($filename, function($excel) use($users) {
     $excel->sheet('Authors', function($sheet) use($users) {
     	 $sheet->setHeight(1, 30);
     	 $sheet->mergeCells('A1:I1');
         $sheet->loadView('exports.users')->with('users', $users);
     });
})->export('xlsx');

Then, i wrap that inside a try/catch, and the result is the message "Invalid parameters passed."
Exception stack trace
Screenshot of Excel file
Steps to reproduce the behaviour
What am I missing ?
A little update, the problem is the 'xlsx' extension, if i switch to 'xls' works fine.

We are closing all old tickets, because version 2.* is reaching the End-of-Life stage. Our full attention is now allocated to version 3.0. It's still possible to use 2.*, but there will be no active support anymore.


build: make libuv buildable with vs2017

Re: #1283
This is the minimal change needed to get this to build on VS2017, it assumes the dev has run vsvarsall.bat (i.e. set-up the dev environment, and chose target and host arch) So to get it to build on appveyor you need to add to the YAML:
before_build:
  - cmd: "C:\Program Files (x86)\Microsoft Visual Studio 15.0\VC\Auxiliary\Build\vcvarsall.bat amd64"

I could add another PR with VS2017 detection code...

/cc @gibfahn @ctaggart

How does this relate to #1283 ? Can you provide some more context?

This change will make libuv buildable on windows with VS2017.
It does not install or setup VS2017 (as #1283 tries to do).
I did not change appveyor.yml. I put the needed change in the description. I could add it if you want.
This does not include VS2017 detection logic (I usually use msvs-com-helper)
#1283 has a script that manipulates the GYP output. This PR makes that redundant.

Green on Appveyor

I'm at a loss here. Can you please walk me through what you are trying to accomplish here? Yes, MSVS 2017 support, but I need to know the details: why is a new file required? Why are we removing checks we used before (which I know people rely upon), etc.

@saghul I'll revamp this as per your comments.
Currently it has some hardcoded values such as os.environ.get('VisualStudioVersion') == '15.0' => td['msbuild_toolset'] = 'v141'
If you want I can add the COM interrogator that is a little bit more future proof and can deduce this value.

P.S. I have a heavy hand and I like to slash code I don't like, then let the CI keep me in check ;)

Currently it has some hardcoded values such as os.environ.get('VisualStudioVersion') == '15.0' => td['msbuild_toolset'] = 'v141'
If you want I can add the COM interrogator that is a little bit more future proof and can deduce this value.

How is this supposed to work with MSVS 2010 or SDK 9.1, both of which we still support?

Fixed by your request:

AppVeyor will do a 2x2 matrix (2015,2017)x(86, 84)
gyp_uv.py will add a default to GYP_MSVS_VERSION = 2010. I just added some explanation to the comment
un-refactored gyp_uv.gyp to be more module like

How is this supposed to work with MSVS 2010 or SDK 9.1, both of which we still support?

using the same flow as before... the function will become a no-op, => config.gypi will not be generated, so it won't be added as an arg to GYP

Green again on the 2x2
@saghul BTW: If you want I can set AppVeyor to check on:

Visual Studio 2008
Visual Studio 2010
Visual Studio 2012
Visual Studio 2013
Visual Studio 2015
Visual Studio 2017
And I think you need to choose the one version that will make a release file (and not waste time packing them on all)

@saghul you like the new changes?

@saghul ping?

@saghul changes addressed.

Also I could tweak appveyor.yml in the manner I described in https://github.com/libuv/libuv/pull/1284#issuecomment-291130728

Good news, VS2017 landed in GYP
PR updated, removed code to "trick" GYP to work.
@saghul hope you like this better.

@saghul Done. PTAL.

Nice and simple! I like it! Now, is this enough to build it using MSVC 2017 or is there something extra needed?

Make sure the script pulls the new GYP (delete old downloaded ver). and that the dev run vcvarsall.bat before.
P.S. host-arch and target-arch are deduced from ENV

and that the dev run vcvarsall.bat before.

Why can't we have this built in, as we do for other MSVC versions? (sorry if I asked before, this has changed so much over time I can't keep track)

Why can't we have this built in, as we do for other MSVC versions? (sorry if I asked before, this has changed so much over time I can't keep track)

MS changed the way to find the installed instance of VS2017, they remove VS***COMNTOOLS env var, and now you need to call a COM server.
I have a tool that does that with only builtin windows tools https://github.com/node4good/msvs-com-helper, I'm working on landing it in node , but it's a little bit cumbersome.
If you want it I can integrate it (it landed in node-gyp, Boost/build, and soon in node ;)

Also @indutny took it into gyp.js

@saghul a bit of good new, MS made it simpler to detect the VS version, but it will take some time until everyone updates, for we can detect only in some of the cases (falling back to the user calling vcvarsall.bat by themselves)

@bnoordhuis I'm working on adding the detection mechanism @saghul asked for, now that MS made it simpler again to detect VS2017.

Re the CI: it's really a regression test, since we don't have VS2017 workers...
P.S. Any idea why is not ok 240 - fs_chown failing?

Any idea why is not ok 240 - fs_chown failing?

No idea, but doesn't seem related to your changes...

@refack Let's add the simple way to do it, and those who haven't updated to that version would need to call vcvarsall.bat themselves. @libuv/collaborators WDYT?

I'll update today.

@refack Thanks for your work on this! We, the folks working on the Azure IoT Gateway SDK, are anxiously awaiting your fix. 👍

@saghul What is the status of this PR? It looks like @refack has made changes. I see you are still blocking, but I don't see any comments since the updates?
The Azure IoT Edge SDK has a bug (with work around) based on the LibUV dependency. It would be great to see this PR come in, we have a bunch of people looking forward to it.
Thanks,
Zak

Fresh CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/277/
@zafields have you tested the change in it's current state to verify that it fixes your problem? Unfortunately, the CI doesn't test VS2017.

@cjihrig To be honest, no I have not. We have a workaround in place and have moved forward.
The immediate problem we are experiencing, is that compiling with VS2017 isn't even a condition in the if->else checks, so it falls to the final else which attempts to use a very old version of the vsbuild. I am assuming (I know, I'm embarrassed even writing the word) that once LibUV can be built with VS2017, then my problem will be solved. However, I am certain that my problem will not be solved until LibUV is in fact buildable with VS2017.
Mostly, I just check in on this PR from time to time, because by it's name alone it looks to be the answer to my problem. To me, it looks like @refack has done the work, and the PR has just gone cold, so I wanted to ping the reviewers.

Mostly, I just check in on this PR from time to time, because by it's name alone it looks to be the answer to my problem. To me, it looks like @refack has done the work, and the PR has just gone cold, so I wanted to ping the reviewers.

Not exactly, current solution requires the dev to call vcvars*.bat manually. I promised to add a vswhere check before falling back to this. But then I got "sucked in" to the whirlwind that is being a nodejs Collaborator.
I'll push that now.

@saghul Implemented vswhere detection with current behaviour as fall back.If vswhere is not found this is the output:
'vswhere' is not recognized as an internal or external command,
operable program or batch file.
Warning: Visual Studio not found
['-Dtarget_arch=ia32', '-Duv_library=static_library', '.\\uv.gyp', '-I', '.\\common.gypi', '--depth=.', '-Dhost_arch=x64']
Project files generated.
Build skipped. To build, this file needs to run from VS cmd prompt.

CI (just in case) https://ci.nodejs.org/view/libuv/job/libuv-test-commit/280/

Just tested it locally with VS 2017 Build Tools. Everything works as expected and tests pass 👍

Update @saghul This will break pyuv builds! There is no way to skip building with VS 2017 if it is installed. So builds for Python < 3.5 won't work anymore as they need another VS compiler.
Right now the correct VS compiler can be selected in pyuv by modifying the environment, the wrong VSXXXCOMNTOOLS variables are removed before calling vcbuild.bat (ref).
So there should be a way to disable building with VS 2017 even if VS 2017 is installed.

Something like
if defined LIBUV_SKIP_VSWHERE_DETECTION goto :no-vs2017-env

Update @saghul This will break pyuv builds! There is no way to skip building with VS 2017 if it is installed. So builds for Python < 3.5 won't work anymore as they need another VS compiler.
Right now the correct VS compiler can be selected in pyuv by modifying the environment, the wrong VSXXXCOMNTOOLS variables are removed before calling vcbuild.bat (ref).
So there should be a way to disable building with VS 2017 even if VS 2017 is installed.

@schlamar
I added a command line arg skip2017, does that help? You could also set skip2017=1, and it'll take.

I would prefer a more specific environment variable, skip2017 is very generally.
As command line argument it'd OK. However, I'm not sure if that's useful as you can't skip other VS versions via command line arguments.
But maybe we should change the logic and instead of skipping a user can set a preferred VS version. We could use GYP_MSVS_VERSION for that. If that variable is defined we check only for the selected VS version. @saghul What do you think?

Oh, my proposal with GYP_MSVS_VERSION won't work for pyuv as you can build Python 3.5+ extensions with VS 2015 and VS 2017. So you cannot select a preferred version. In this case skipping is the way to go.
I would propose LIBUV_SKIP_VS2017 as env variable. But maybe we should then support LIBUV_SKIP_VSXXX as well?

I would propose LIBUV_SKIP_VS2017 as env variable.

Ack.

But maybe we should then support LIBUV_SKIP_VSXXX as well?

That I'm leaving for a different PR, since you need to decide on a fall through policy (yes/no? maybe the var should be a positive selection like GYP_MSVS_VERSION not SKIP logic?)

Rebased

@schlamar Thanks for catching that! As you know we remove things from the environment when building on Windows in order to pick the right compiler. Won't this work if we skip VS 2017?

@refack @schlamar Let's go back a bit and re-think this. Adding a way to skip 2017 is just a hack IMHO. We should maybe read the GYP_MSVS_VERSION env variable and just try to use the requested one instead. In pyuv we'd set that.
Another approach I've been thinking about (for pyuv) is to ditch the libuv build system completely and add the libuv sources, similar to how I build pycares: https://github.com/saghul/pycares/blob/master/setup_cares.py that would simplify the build a lot, and remove Python 2 as a dependency when building on Python 3, among other things.
So, I suggest we go back to the previous scenario, fixup pyuv, and come back with a follow-up PR if we need it after the build refactor. This might be the excuse I was looking for in order to finally do it :-)

@saghul Python 3.5+ extensions can be build with VS 2017 so we should skip VS 2017 only on Python < 3.5. For Python 3.5+ VS 2017 or 2015 should be allowed.
The current state of the PR should work for this use case.
I wouldn't introduce a command line arg, though :)

@saghul We cannot select a specific VS version, see my previous comment.

@schlamar Wouldn't https://github.com/libuv/libuv/pull/1284#issuecomment-305099237 solve it? It would be like building any other extension, since we wouldn't be using the libuv build system.

Yes, I guess this would work and I really like your idea.
A one liner if defined LIBUV_SKIP_VS2017 goto ... shouldn't hurt, though :)

Removed "skip" logic.
I can help with a new PR implementing "positive selection" logic

Removed "skip" logic.
I can help with a new PR implementing "positive selection" logic.

Hi, I am trying to build but i am getting error. kindly check below details
My machine conf. win10 x64
VS 2017 enterprise
git version 2.13.0.windows.1
python 2.7.13
Please help to resolve this.

Try to run the build from a "Developer Command Prompt for VS 2017"

@ganeshmahajan1985 It looks like you want to build v1.10.1 with VS 2017 which is not supported. You need to fetch from this PR (see https://help.github.com/articles/checking-out-pull-requests-locally/) if you want to build libuv with VS 2017.

@schlamar  Interesting.
Let me try this.
Thanks.
@refack Yes I am using developer console only. :)

Hi guys,
I am just following up. It looks like all green lights and no merge. We are getting about 3 issues a week based on lack of VS2017 support with libUV.
Do you have a timeline, any status or a short description of the hang-up I can pass along to our users?
Thanks,
Zak

@refack @schlamar @saghul Can you provide any insight on the status of this PR?

@schlamar @refack vs2017 support would be nice, can we make it opt-in for the time being, before pyuv gets a fix? Maybe an command line arg, like vcbuild vc2017 ?

Done, PTAL.
I used as much code from nodejs as was reasonable so it's a tad bit noisy, but IMHO it's best
I also updated the helper

Also, since things changed quite some: @cjihrig @bnoordhuis @saghul can you reevaluate your reviews?

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/307/

Well It's building, so I assume CI fail on win2008r2-vs2013 is unrelated?
not ok 282 - threadpool_cancel_getnameinfo
# exit code 3
# Output from process `threadpool_cancel_getnameinfo`:
# A

https://ci.nodejs.org/job/libuv-test-commit-windows/371/nodes=win2008r2-vs2013/

I guess so.

@saghul I could find any reference to VS building except for https://github.com/libuv/libuv#windows and it still holds...

@refack Time to extend it then ;-)

@refack Time to extend it then ;-)

How much? do you want whole blurb from node https://github.com/nodejs/node/blob/master/BUILDING.md#windows-1?

How much? do you want whole blurb from node https://github.com/nodejs/node/blob/master/BUILDING.md#windows-1?

Yeah, that would be great! Thanks! 🙏

Added, adjusted, and de-linted (based on https://github.com/nodejs/node/pull/12756)

Thanks for your perseverance and patience! Landed in 19c896dd086abb351361eab54b7e88ed5ce8af08, 0953bf0dad50d0dc77fec2deefe1c5b6c5c3f020 and 80d3b95f57e4509d93b3470e60d090b0cddb216a. 🎉

@refack is this still building successfully for you on AppVeyor? It doesn't seem like it based on https://ci.appveyor.com/project/refack/libuv/build/v1.12.0.build41. That looks like the same error I'm currently seeing while trying to cut the 1.13.0 release.

@refack is this still building successfully for you on AppVeyor? It doesn't seem like it based on https://ci.appveyor.com/project/refack/libuv/build/v1.12.0.build41. That looks like the same error I'm currently seeing while trying to cut the 1.13.0 release.

Havn't looked at it in a while, looking now.


Loader does not resolve non-relative modules

I have this webpack config
resolve: {
    extensions: ["", ".js", ".jsx"],
    root: [
      path.join(process.cwd(), "src"),
    ],
  },
  module: {
    loaders: [
      {
        test: /\.jsx?$/,
        loaders: ["babel"],
        exclude: /node_modules/,
        include: src,
      },
      {
        test: /\.json$/,
        loader: "json",
      },
    ],
  },

Which works. When I mix in the postcss-loader as described in the readme, the modules relative to src are no longer found
app
app/src
app/src/index.js
app/src/api
app/src/api/api.js

and in index.js it says:
import api from "api/api
This resolves fine with my original config but throws api/api not found when using this loader.

Could you show config with PostCSS?

@ai Sure, just copied what I found in the readme, as written above.
resolve: {
    extensions: ["", ".js", ".jsx"],
    root: [
      path.join(process.cwd(), "src"),
    ],
  },
  module: {
    loaders: [
      {
        test: /\.jsx?$/,
        loader: "style-loader!css-loader!postcss-loader?parser=postcss-js!babel",
        exclude: /node_modules/,
        include: src,
      },
      {
        test: /\.json$/,
        loader: "json",
      },
    ],
  },

Do you load JS module and then you have a issue? Very strange. I have no idea where I should look. Maybe you should ask in webpack chat and they will have some ideas?

well it works when I remove all the css loader stuff and just leave:
loader: babel
So, the webpack setup seems correct.

So the actual console output is:
ERROR in ./src/index.js
Module build failed: Error: Cannot find module 'api/api'
    at Function.Module._resolveFilename (module.js:440:15)
    at Function.Module._load (module.js:388:25)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> \app\src\index.js:15:12)
    at Module._compile (module.js:541:32)
    at Object.loaderContext.exec (\app\node_modules\webpack-core\lib\NormalModuleMixin.js:88:7)
    at Object.module.exports (\app\node_modules\postcss-loader\index.js:59:23)

Ouh, I see. I mess that you use postcss-js. Could you show me your style file?

There are no style files. All styles are inline, in the .js* files. There is no style in index.js, the entry file that contains the import to api/api. As written, when I leave out postcss-loader as a loader, the config works just fine.

Ouh, I understand the issue :). You are using postcss-loader in wrong way ;).
If you have style object in JSX files:
const style = {
  display: 'flex'
}

export class Logo extends React.Component {
}

you don’t need postcss-loader at all. postcss-loader is used only when you store styles in separated files like:
export default {
  display: 'flex'
}

Use postcss-js or babel-plugin-csjs-postcss if you want to process styles in JSX files.

So there is no solution out there to use webpack to transform all occurrences of inline styles like those?
const STYLE = {
  display: "flex"
}

const Component = () => (

)

const OtherComponent = () => (
  <Component>
</Component>
)

I give you a 2 links for solutions — look to last paragraph ;).

I checked your 2 solutions. Both are not doing what I hoped they would. Both require code changes, that would be massive in our code base.
Maybe I need to read up on how babel transform plugins work and do this wherever a style prop is used replace it with a call to prefixer(style)`.

Yeap, there is no solution withour code changes right now. But you could write a Babel plugin to do it.


Move StableStringMap from tags.impl to utils

Move StableStringMap from tags.impl to utils. However, keep an alias to the type inside tags to keep the libray backward compatible with previous versions.

In the end, I decided to create a completely new implementation of the stable map called BaseStableMap.  It uses generics to make it easier to extend.

The use of BaseStableMap was able to make the implementation easier to maintain. Furthermore, it have been optimized to run the iterators faster by providing a method to return the entries instead of the keys.


[BACKLOG-26211] - refactoring withVariables to get a copy of the Step…

…MetaInterface object from the plugin registry

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'engine,plugins/streaming/impls/jms,plugins/streaming/impls/mqtt' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,plugins/streaming/impls/jms,plugins/streaming/impls/mqtt' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/core/util/serialization/BaseSerializingMeta.java
  plugins/streaming/impls/jms/src/main/java/org/pentaho/di/trans/step/jms/JmsDelegate.java
  plugins/streaming/impls/jms/src/test/java/org/pentaho/di/trans/step/jms/JmsConsumerMetaTest.java
  plugins/streaming/impls/jms/src/test/resources/jms-consumer.ktr
  plugins/streaming/impls/mqtt/src/test/java/org/pentaho/di/trans/step/mqtt/MQTTProducerMetaTest.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.trans.step.mqtt.MQTTConsumerMeta

Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -3.6% :small_red_triangle_down:
Line Change: -3.3% :small_red_triangle_down:
Method Change: -2.1% :small_red_triangle_down:

org.pentaho.di.trans.step.mqtt.MQTTProducerMeta

Complexity Change: -2.8% :small_red_triangle_down:
Instruction Change: -3.1% :small_red_triangle_down:
Line Change: -3.8% :small_red_triangle_down:
Method Change: -7.2% :small_red_triangle_down:

org.pentaho.di.core.util.serialization.BaseSerializingMeta

Instruction Change: -9.5% :small_red_triangle_down:
Line Change: -3.9% :small_red_triangle_down:

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -0.4% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.7% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.9% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -0.5% :small_red_triangle_down:

org.pentaho.di.trans.step.jms.JmsConsumerMeta

Complexity Change: -12.5% :small_red_triangle_down:
Instruction Change: -21% :small_red_triangle_down:
Line Change: -18.8% :small_red_triangle_down:
Method Change: -12.5% :small_red_triangle_down:

org.pentaho.di.trans.step.jms.JmsDelegate

Complexity Change: -7.1% :small_red_triangle_down:
Instruction Change: -53.2% :small_red_triangle_down:
Line Change: -39.5% :small_red_triangle_down:
Method Change: -7.6% :small_red_triangle_down:

org.pentaho.di.trans.step.jms.JmsProducerMeta

Complexity Change: -3.3% :small_red_triangle_down:
Instruction Change: -7.6% :small_red_triangle_down:
Line Change: -7.5% :small_red_triangle_down:
Method Change: -3.3% :small_red_triangle_down:

License header violations

:heavy_exclamation_mark: Couldn't find acceptable copyright on plugins/streaming/impls/jms/src/test/java/org/pentaho/di/trans/step/jms/JmsConsumerMetaTest.java

:heavy_exclamation_mark: Couldn't find acceptable license on plugins/streaming/impls/jms/src/test/java/org/pentaho/di/trans/step/jms/JmsConsumerMetaTest.java

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'engine,plugins/streaming/impls/jms,plugins/streaming/impls/mqtt' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,plugins/streaming/impls/jms,plugins/streaming/impls/mqtt' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/core/util/serialization/BaseSerializingMeta.java
  plugins/streaming/impls/jms/src/main/java/org/pentaho/di/trans/step/jms/JmsDelegate.java
  plugins/streaming/impls/jms/src/test/java/org/pentaho/di/trans/step/jms/JmsConsumerMetaTest.java
  plugins/streaming/impls/jms/src/test/resources/jms-consumer.ktr
  plugins/streaming/impls/mqtt/src/test/java/org/pentaho/di/trans/step/mqtt/MQTTProducerMetaTest.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes.