Action get_github_release authentication for private repos

added User-Agent header
when api_token is passed in, also adds an Authorization header (useful for private repositories)

Thanks for your contribution, this looks great. It does however change the behaviour when the tag is not available or some error occurs. Up until now, the action would return nil and show a warning. The newly added code raises an exception if something goes wrong.

Ah of course. So which behavior would you prefer? Downgrading those messages from exceptions to error logs but letting the action finish?

Yes, this should just be Helper.logger.error "text" :+1:

Ok. How about yours raise "No release notes found for #{params[:version]}", should I change that as well?

             if current['body'].to_s.length > 0
               Actions.lane_context[SharedValues::GET_GITHUB_RELEASE_INFO] = current
               Helper.log.info "Version is already live on GitHub.com 🚁"
               return current
             else
               raise "No release notes found for #{params[:version]}"
             end

Oh, that's wrong anyway, as it requires a body to be set. I'll update that part. Thanks.

Thanks for the pull request @czechboy0 :+1:


[Enhancement]: Request Existing Organization Members to enable two-factor authentication

Contact Details
No response
Is there an existing issue for this?

[X] I have searched all the existing issues

What would you like to be added?
As per the latest CNCF TCS request, to keep CubeFS github organization secure, one of the requirement for being a member is to enable two-factor authentication.
Why is this needed?
The organization settings currently don't enforce this but we will soon be enforcing to meet the membership guidelines. So I request the existing members to enable two-factor authentication for their github account and respond here. Below is the list of members who have not enabled two-factor authentication
Anything else?
@bladedragon
@Dora28
@guowl0919
@honeyvinnie
@ics091
@JasonHu520
@jzeng4
@kenochen
@KM-SF
@LeeYubo
@lizhendong666
@morningli
@pengtianyue025
@seasan666
@shyodx
@skypigltp
@ssscottt
@tangdeyi
@true1064
@V-yg
@Vivian7755
@wding109
@wenjia322
@xiangcai1215
@xiaowei5998
@xrefft
@yinlei-github
@zhangtianjiong
@znlstar

已收到，谢谢！


Add support for 'operation-location' for dataplane LRO(Long Running Operations)

Please add support for dataplane LRO, response headers 'operation-location'.

Official docs for using operation-location in dataplane.

Currently blocking Communication team


HAProxy shutdown not working

As mentioned in https://github.com/opnsense/core/issues/1447 by someone else.
This still happens to me on OPNsense 17.1.9 and os-haproxy 1.16.
Both these don't work:

Shutting down the haproxy service manually
Rebooting OPNsense via the web UI

Notes that might be of interest:

My configured frontends bind to <IP_ADDRESS>:443 and <IP_ADDRESS>:80
I've configured the firewall itself as a backend/server (on some port, in this case HTTP/4444)

OPNsense 17.7 is scheduled for release this month and will finally update HAProxy to version 1.7.x.

This is still happening on OPNsense 17.7, os-haproxy 1.16, haproxy 1.7.8.
The only message showing up in the log (when attempting to shutdown haproxy manually) is:
Aug 1 19:30:44 | configd.py: [e36569b4-e4df-4c2f-ab56-a40038749656] stopping haproxy

What can I do to help diagnosing this?

This is still happening on OPNsense 17.7, os-haproxy 1.16, haproxy 1.7.8.

Very unfortunate. :( But I'm pretty sure we'll find a workaround soon.

What can I do to help diagnosing this?

The problem is that I was never able to reliably reproduce this issue. Does it happen every time you restart HAProxy? If so, I'd be interested in a config dump – a full config.xml dump would be ideal, but I could live with only the HAProxy parts too (anonymized, if required) :)

I've just sent you a config dump to the mail address mentioned on your GitHub profile.
I haven't rebooted in a long time without killing haproxy manually via the shell before, because I don't want to wait for any timeouts to expire.
But I can tell you that this happens consistently every time when attempting the manual shutdown via the "Services" widget on the start page.

Thanks, @tskarman! I've received your config dump and will use it to debug this issue.

@tskarman According to my tests the "hanging" HAProxy processes on shutdown/stop are related to (a) high timeout values in haproxy.conf and (b) HAProxy's default "graceful" stop mode (see #221 for more details). You can check if HAProxy is still serving connections by running sockstat -4 | grep haproxy on the CLI.
For OPNsense 17.7.1 we've changed the default stop mode of HAProxy from "graceful" to "hard". It's scheduled for release in a few days – please let me know if it solves the issue for you.


fix: remove short attribute to avoid collision

remove short attribute to avoid option name collision

Pull Request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Testing
[ ] Other (please describe):

What is the current behavior?

Issue Number: #366
What is the new behavior?

Beerus CLI works correctly and does not throw the option collision error.
Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

Basically, if you run a CLI command that receives parameters, it doesn't work. According to the clap documentation, if no value is assigned to the short attribute, it takes the first character of the field name by default. This is causing a collision for us. That's why I removed the short attribute.
Moreover, using the short attribute in this way does not seem appropriate for the ux. We should create a discussion to ensure that our CLI has the best ux.

The CLI will be rebuilt as one of the next steps before release of V1 to improve UX and use what we have improved for the RPC.
This PR is interesting but not needed at this moment.
We should focus for now on finalizing the tests for the RPC.

Just tried:
cargo r --bin beerus starknet query-nonce --address xxx
On main and it worked, can you test please.

The current focus is unaligned with PR and CLI might be deprecated, if not this pr will be merged.


Configurable Outline Thickness for Drawing Shapes

During masking, we have set the outline thickness using width to only one region and it's hard coded.
draw.ellipse([rx, ry, rx + rw, ry + rh], outline=color, width=3, fill=color)

Introduce a configuration parameter (OUTLINE_THICKNESS) to control the thickness of outlines for shapes drawn using draw.polygon and draw.rectangle, and also update the draw.ellipse width value with this.
Benefits

Enhances consistency and flexibility in outline appearance.
Simplifies maintenance by managing outline thickness globally.

Implementation Plan

Add OUTLINE_THICKNESS parameter to configuration settings.
Modify drawing functions to use this parameter.
Update documentation and examples accordingly in README.md.

Acceptance Criteria

Drawing functions correctly utilize OUTLINE_THICKNESS.
Global adjustment of outline thickness validated.
Changes integrated without regression.

Hello sumn2u, I would like to help with this issue.

Hey Sumn2u, I review the flask section of the code and updated the draw.foo() functions with a config variable, but as the only draw.foo functions are in the download routes, the width change is only reflected in the downloaded images and not in the preview. Is this what you were looking for, or should I update the frontend/js parts of the code base too?
preview screen:

downloaded:

Also with regards to the README file, there is currently no mention of modifying the config.py file for the MASK_BACKGROUND_COLOR variable either, so should I add a new section to detail how a user can optionally customize these variables?
I've also noticed several other config variables that were defined in the main app.py file instead of in the config.py file. Would you like to migrate these variables all to the config file?
Lastly, I noticed that the current flask code uses the deprecated (and now redundant) flask jsonify method. Would you like to update the code to remove the "jsonify()"s ?

@DQ4443  Thanks for providing the detailed information. I was not aware of the thickness issue with large numbers. Ideally, it would be nice to have a slider in the UI to control the thickness. Based on its value, the Flask application will adjust accordingly and reflect the changes in the downloaded file.
For now, we can use the config variable value and apply it in the Flask application. As for the UI, we can create a separate task to add a slider, limiting the upper bound to 5 to mitigate the thickness issue. This slider will then be linked to the Flask application.

Also with regards to the README file, there is currently no mention of modifying the config.py file for the MASK_BACKGROUND_COLOR variable either, so should I add a new section to detail how a user can optionally customize these variables?

I have added the customization instructions in the documentation section documentation section and will include more information once it's completed.

I've also noticed several other config variables that were defined in the main app.py file instead of in the config.py file. Would you like to migrate these variables all to the config file?

It would be great if you could move them to the config file. I suggest creating an issue for this task and then assigning it to yourself if you are working on it.

Lastly, I noticed that the current flask code uses the deprecated (and now redundant) flask jsonify method. Would you like to update the code to remove the "jsonify()"s ?

Sure.
Thanks for providing the feedback. I suggest creating separate issues and assigning yourself to the ones you want to work on.

The current outline width used in the UI is defined in RegionShapes. Here, you can see that based on the tools, we have various strokeWidth values. We might need to create a map based on the selected tools and use it in the server.

@DQ4443 Thanks for providing the detailed information. I was not aware of the thickness issue with large numbers. Ideally, it would be nice to have a slider in the UI to control the thickness. Based on its value, the Flask application will adjust accordingly and reflect the changes in the downloaded file.
For now, we can use the config variable value and apply it in the Flask application. As for the UI, we can create a separate task to add a slider, limiting the upper bound to 5 to mitigate the thickness issue. This slider will then be linked to the Flask application.

Cool I'll just implement the config variable in the backend first and create a separate PR for the frontend.

Also with regards to the README file, there is currently no mention of modifying the config.py file for the MASK_BACKGROUND_COLOR variable either, so should I add a new section to detail how a user can optionally customize these variables?

I have added the customization instructions in the documentation section documentation section and will include more information once it's completed.

Would you like me to add a section in README file to direct users to the documentation?

I've also noticed several other config variables that were defined in the main app.py file instead of in the config.py file. Would you like to migrate these variables all to the config file?

It would be great if you could move them to the config file. I suggest creating an issue for this task and then assigning it to yourself if you are working on it.

Lastly, I noticed that the current flask code uses the deprecated (and now redundant) flask jsonify method. Would you like to update the code to remove the "jsonify()"s ?

Sure.

I'll create separate PRs for these two issues

Would you like me to add a section in README file to direct users to the documentation?

That would be great.


Changing http links to https

What does the pull request do?
Since there's no redirect, one must explicitly navigate to https pages

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: arthrp sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Add the arch key to the hardware specification

Include architecture among supported keys.
Explicitly list standard architecture names.

As discussed in #1040 it would be good to include arch in the hardware specification and explicitly list architecture names. The names are taken from the context dimension definition (which came from test case relevancy). Proposed in the top level as it is quite common one. Or should it rather go under cpu? @happz, @frantisekz, @lukaszachy, @thrix, @FrNecas, please have a look.

LGTM - IMHO cpu should be for more specific cpu features (eg. s390x as arch can be z-13 as cpu)

Top-level sounds good to me.

LGTM - IMHO cpu should be for more specific cpu features (eg. s390x as arch can be z-13 as cpu)

Yep, makes sense to leave it as arch and reserve cpu for more specific settings :)
Btw, do we want to mention the armhfp at all? It's being phased out, F37 has it turned off already, I am not planning on implementing it testcloud-side unles somebody really wants :)

Btw, do we want to mention the armhfp at all?

Not sure, looking briefly at qe.py I see it was only enabled for fedora-26 and fedora-27. Since fedora-28 it was skipped in the list of supported arches. So... it seems we could forget about it? @lukaszachy, any thoughts on this?

So... it seems we could forget about it? @lukaszachy, any thoughts on this?

Well, I thought you have some use case for it. In RHEL we don't need it at all.

Btw, do we want to mention the armhfp at all? It's being phased out, F37 has it turned off already, I am not planning on implementing it testcloud-side unles somebody really wants :)

Good question, which brings up something the specification should probably mention: as far as TMT is concerned, the list of architectures is probably quite open. For TMT, the actual values are not that important, and it's the concept of "supports/requires an architecture" that's the key part here. This makes the actual values less important and open to additions as needed. If I create a provision plugin that supports my brand new ducky architecture and add tests requiring ducky machines, TMT should not stop me because ducky is uknown to TMT. Provision plugin should stop me when it's incapable of delivering such an architecture, but for TMT itself, it's just an arbitrary string, matched (or not...) with other arbitrary strings in hardware.arch.
I'd say specification should reflect this approach. Instead of "one of the following values", it should be something like "any of well-known short architecture names, e.g. aarch64, i386, ...". Existing HW specs don't make any statements about limiting their allowed values, arch would be the first.

with other arbitrary strings in hardware.arch.

Btw, your mention of hardware.arch reminded me a question which recently popped up in my mind and should be clarified in the spec: Will there be a dedicated hardware key or will the values go right under the provision step config? As for now the hardware spec introduction probably slightly suggests the second way:

As part of the provision step it is possible to specify additional requirements...

Plus, some of the plugins (e.g. testcloud) already support values such as memory or arch directly under the provision step:
provision:
    how: virtual
    image: fedora
    user: root
    memory: 2048

Is this ok? Or was the expectation that there will be a dedicated hardware key under the provision step?
provision:
    how: virtual
    image: fedora
    user: root
    hardware:
        memory: 2048

Thoughts?

with other arbitrary strings in hardware.arch.

Btw, your mention of hardware.arch reminded me a question which recently popped up in my mind and should be clarified in the spec: Will there be a dedicated hardware key or will the values go right under the provision step config? As for now the hardware spec introduction probably slightly suggests the second way:

As part of the provision step it is possible to specify additional requirements...

Plus, some of the plugins (e.g. testcloud) already support values such as memory or arch directly under the provision step:
provision:
    how: virtual
    image: fedora
    user: root
    memory: 2048

Is this ok? Or was the expectation that there will be a dedicated hardware key under the provision step?
provision:
    how: virtual
    image: fedora
    user: root
    hardware:
        memory: 2048

Thoughts?

I for one consider the former to be a relict of the past where these attributes were not standardized, and everyone and their mother had their own idea on how to specify memory size or how to install Koji builds. I'd rather see these plugins to accept standardized hardware key, and if one plugin introduces a shortcut and provision.memory would become supported as well as the standard provision.hardware.memory, I'd say all provision plugins (maintained by TMT developers) should support that, too. Either all of them or none.
I'd say this is something that should live in that shared code for HW requirements. All plugins would pass provision to a library function, and get a validated set of requirements. Then it'd be their job to translate them to libvirt lingo or Beaker XML. I see no point in virtual parsing provision.hardware in its own, e.g. in this particular case, 2048 would mean 2048 bytes, not 2 GiB as the author of those lines would expect, right? If TMT developers decide provision.memory is a good idea, then all plugins would gain support for it thanks to them using shared code to "normalize" HW -related content of provision.
Does it make sense? My universe is pretty opinionated :)

Does it make sense? My universe is pretty opinionated :)

Yeah, definitely makes sense to me. Perhaps we could also shortly discuss this on the hacking session tomorrow.

Does it make sense? My universe is pretty opinionated :)

Yeah, definitely makes sense to me. Perhaps we could also shortly discuss this on the hacking session tomorrow.

Sure, although I'd have to apologize for tomorrow, thanks to a power outage and alternative working conditions not compatible with speaking too loudly.

Thanks to all for your feedback. The nested hardware key was discussed and agreed on the hacking session. It makes a very good sense also because we expect to add it to individual tests as part of the L1 spec as well so these two can be completely consistent. Spec updated to make it clear how a full provision step config will look like plus a couple of readability enhancements.


Aws gce mods

changes to factory to send IDTOKEN to AWS in format that the VM can use.
Intended for use with cloud-vms 2.3.rc1 or later, see cloud-vms/issue/1

These changes seem to support only tokens. Do these need to be coordinated w/ the VM image changes? Any way to support both images (i.e. send both token and proxy if available)?


Error_message

I have trained this repo on a custome dataset.However, When I run the command.Unfortunatelly there is an ECA not found error.
Please if anyone could help me because it is really a crucial project to me
Thank you.

Hello,
If there is still a problem, please provide the specific error.


Check to see if Ganache works with Chainlink nodes

The FAQ says Ganache won't work with Chainlink nodes. Test and verify that.
https://github.com/smartcontractkit/documentation/blob/main/docs/Additional Information/faq.md

It kind of works. I recall Bing from the DevRel team was testing it out. I have a doc somewhere.

the right link is this one
https://github.com/smartcontractkit/documentation/blob/main/docs/Node Operators/running-a-chainlink-node.md
@dwightjl you can run chainlink with ganache. There is an example in here. but you'll need to deploy Chainlink contracts or fork an existing testnet.  Hence , what is the purpose of this issue:

remove Ganache is a mock testnet and it doesn't work with Chainlink because of that. Because it is not 100% accurate
Or write a tutorial showing  how to run a Chainlink node locally ?


Token Renderer

Small script that allows people to render ArtBlocks token server-side at any resolution, aspect ratio, and frame.

Thanks so much @JackShort! This is awesome!
You were so quick to contribute, give me a bit to make sure we have a good system in place for merging PRs from awesome contributors like yourself! ❤


Sort pages by title length

Opening this PR because I couldn't find a proper way to achieve this with built-in sorters.
This add the required code, test and documentation.

OK, I did not read this ...
This sounds like a very specialised use case; I suggest you open up a regular issue (proposal) to discuss it.


Custom options for Lua + made it able to compile without mods enabled.

This does work, I tested it.
This can allow Lua developers to be more creative and also think of some players who might not want their custom addition to the engine, as well as simplifying it if you are an experienced Lua developer and know how to read and write files which give soft-modded Psych Engine custom options (without this pull request).
How it works:
Set a custom option with
setCustomOption(optionName:String, value:Dynamic)

and get a custom option with
getCustomOption(optionName:String)

Note: if the option doesn't exist, trying to get it will return a string of "null".

Approved + Nice formatting

Thanks!

fix this pls

too hard :sob:

that's a LOT of code


Add venue proxy to the release please

Description
Issues
Closes
DEV-XXX:
Related
Testing
Automated tests
Manual testing
Screenshots
Additional notes

Also release-please-manifest.json should be updated: https://github.com/City-of-Helsinki/events-helsinki-monorepo/blob/main/.release-please-manifest.json . You can just use the current package.json version number and it should start updating from there itself.

👍 It's all there


Automatic platform detection

Motivation
Instead of including multiple jars (https://github.com/wasmerio/wasmer-java#development) I would like to include a single JAR that works on multiple platforms and have a single API to use the wasner.
Proposed solution
Automatically detect platform.
Alternatives
None.
Additional context
None.

Yup, that's something I will think about. You aren't the first one to ask that.

You might be interested in this https://github.com/scijava/native-lib-loader


add topn closure executor

implement closure executor for TopN operator

About topNCtx.chk and scanCtx.chk
During table scan process we don't need to decode all cols into chunk, we can decode the columns used in order by. The new row format can fast decode subset of columns.
During eval of expression in order by, we still need a Chunk respect to table's schema, even though we will only access the decoded columns.
So, I add a new method to Chunk, ProjectColumns. This method returns a new Chunk, which columns is simply a reference of the origin Chunk.
scanCtx.chk is returned by topNCtx.chk.ProjectColumns(), so after tableScanProcessCore decoded value, Expr.eval can use topNCtx.chk.GetRow(0) to get decoded row directly.
I'll move ProjectColumns to tidb later.

@jackysp PTAL


Add support for --no-new-privs

This replaces Dan's original PR #218.  As of now, no changes other than a rebase were required.
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

I think we can actually remove it from the DB altogether, given that it's in the spec

@mheon @rhatdan im almost dead sure this is a selinux error.  @rhatdan did you say you were expecting a new selinux package for this too?

@baude are you able to get this to fail locally? Or just in the testing?  Is there a way I can get onto a testing machine where this is happening.

The FAH27 one has:

"kernel": "4.14.18-300.fc27.x86_64",

While the Fedora fedora/27/cloud Podman one has:

"kernel": "4.13.9-300.fc27.x86_64",

As opposed to AH, Fedora usually does not update cloud images after release. You'd have to update the kernel and reboot as a separate step before starting the tests. Which is tricky of course, since the code is running on the host. One way around this is to define a cluster instead:
cluster:
    hosts:
        - name: node
          distro: fedora/27/cloud
          specs:
              ram: 8192
              cpus: 4
    container:
        image: registry.fedoraproject.org/fedora:27

So then your code will run in the container, so you can e.g. ssh node dnf update -y kernel and then ssh node reboot || : or something along those lines.

Follow-up: you can now use fedora/27/cloud/pungi, which is updated at least once a day and should have the latest kernel (see https://github.com/projectatomic/papr/pull/87). But caveat emptor, there's no guarantee these images are going to be as stable as fedora/27/cloud.

bot, retest this please

LGTM

ill add in some conditional check to the test looking for 4.14 or newer

@rh-atomic-bot r+


feat: ecrecover precompile

merge the identity precompile PR
refactor sig_verify.rs, so instead of using apis like halo2_base::AssignedValue::copy_advice, we create a "r,s,v,hash,is_valid" table (called sig verify table?). Then both tx circuit and evm_circuit::ecrecover can lookup this table?     Another benefit of this is, we no longer leak the complexity of halo2_base to other circuits.    @lispc
evm_circuit side taks. @roynalnaruto

You need also to include the address_recovered in the SignVerify table. That is, the table looks like
(v, r, s, msg_hash, address_recovered, is_valid).

@lispc we can close this issue right?


AP => AT: Delete bridge account on account Delete

If I'm not mistaken, this regressed somewhat as part of the fix for #1130.
When Bridgy Fed receives a Delete for a currently or formerly(!) bridged account, it should mark the account as deleted towards Bluesky rather than just deactivating it, in order to fully purge content from Bluesky's cache.
This process should also disassociate the AT DID from the AP account to an extent, so that a new DID is assigned when an account with the same id is bridged later on (after a timeout of ideally several days to account for AP activity shuffling and potentially bugfix operations).
The Bluesky handle shouldn't necessary be invalidated immediately, but should be open to reassignment for the next bridged AP account with the same handle.
(Deletions have a grace period on Bluesky afaik, so destructive bugs in this function would still be fully recoverable for a few days at least. Longer deletion-durations may lose bridged posts and other activities on Bluesky.)
Related to https://github.com/snarfed/bridgy-fed/issues/1462#issuecomment-2466668733.

Understood! Thanks for filing.
I don't know much about deleting your account as a user on the main PDS, but I expect much of that behavior, eg any grace period, is on the PDS, not the appview.
The only real levers we have for the relay/appview are #account (active=false, status=deleted) and #tombstone (deprecated) events: https://github.com/snarfed/bridgy-fed/discussions/1440. Sadly Bluesky haven't documented #account events yet, specifically which are undoable and which purge data from relay/appview. We'd need that before we could realistically do anything here. I'll ask them for that.

I'm fairly sure #account (active=false, status=deleted) is the correct one here.
I just keep forgetting in which issue someone posted an overview of all the different options and behaviour.

It was https://github.com/snarfed/bridgy-fed/issues/1119.

Hah sorry yes #1119! I like the wrong one earlier.
Sadly not official though, and doesn't confirm reversibility, data deletion, etc. I'll ask.

Got a response: https://github.com/bluesky-social/atproto/discussions/2592#discussioncomment-11211051. Asked for something a bit more explicit; we'll see.

We are still debating how prescriptive to be about this. Eg, to some degree this kind of behavior isn't even observable, so compliance with the spec can't be verified externally. We also want to leave wiggle room for implementations to make their own decisions.
We probably will specify that none of the account statuses are truely permanent. They are also generally only "hop by hop": account statuses probably only apply at any specific service, they are not truely network-wide. Eg, can account can be deleted on one PDS, but pop back up (same identity/DID) on a different PDS.
As a rough guide, deactivated and suspended are more temporary and the best practice would be to not purge data on downstream services. deleted and takendown are somewhat more permanent (though reversible!), and purging data would be recommended, possibly after some time delay (eg, 24 hours; not going to be specified in the protocol).

Internally, I'd probably do this with a new, non-standard deactivate AS1 verb. Tricky though because I'd need to handle it to everywhere I currently look for the delete verb, at least for actors.


Update PHPDoc

I went ahead and updated some of the php-doc-blocks. I also made sure that all the possible typehints are applied (keeping the php 5.5 version constraint in mind).

Some of the functions have a docblock on the interface. So they inherit the one from the interface by default. What is the value of adding one on the functions as well?

@gmponos in my opinion it's much nicer to work with code that has docblocks on every method, even though it might be a duplicate of its interface.
It has the added benefit that most of the IDE's can interpret those docblocks.

This PR was merged in #2384


[HOPS-1349] Optimizing copyFromLocal & copyToLocal HopsFS CLI

Make sure there is no duplicate PR for this issue

Please check if the PR fulfills these requirements

[x] Tests for the changes have been added and passed (for bug fixes / features)
[x] HOPS JIRA issue has been opened for this PR
[x] All commits have been squashed down to a single commit
[x] The commit message has the following format: [HOPS-XXX] message

Post a link to the associated JIRA issue
https://hopshadoop.atlassian.net/browse/HOPS-1349

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Can one of the admins verify this patch?

Jenkins test this please.

This does not compile.

This does not compile.

This patch could not be applied on 5200d777dd0. I have rebased and fixed the issue

Jenkins test this please.


Android NDK 16b

Hi,
Always that i change the NDK to 16b i got:
inni-support/support-lib/jni/djinni_support.cpp
  In file included from /Users/paulo/Developer/workspaces/cpp/ubook-library-core/vendor/dependency-djinni-support/support-lib/jni/djinni_support.cpp:18:
  In file included from /Users/paulo/Developer/workspaces/cpp/ubook-library-core/vendor/dependency-djinni-support/support-lib/jni/djinni_support.hpp:21:
  In file included from /Users/paulo/Developer/android-ndk-r16b/sources/cxx-stl/gnu-libstdc++/4.9/include/memory:72:
  In file included from /Users/paulo/Developer/android-ndk-r16b/sources/cxx-stl/gnu-libstdc++/4.9/include/iosfwd:40:
  In file included from /Users/paulo/Developer/android-ndk-r16b/sources/cxx-stl/gnu-libstdc++/4.9/include/bits/postypes.h:40:
  In file included from /Users/paulo/Developer/android-ndk-r16b/sources/cxx-stl/gnu-libstdc++/4.9/include/cwchar:44:
  In file included from /Users/paulo/Developer/android-ndk-r16b/sysroot/usr/include/wchar.h:33:
  In file included from /Users/paulo/Developer/android-ndk-r16b/sysroot/usr/include/stdio.h:42:
  In file included from /Users/paulo/Developer/android-ndk-r16b/sysroot/usr/include/sys/types.h:36:
  /Users/paulo/Developer/android-ndk-r16b/sysroot/usr/include/linux/types.h:21:10: fatal error: 'asm/types.h' file not found
  #include <asm/types.h>
           ^~~~~~~~~~~~~
  1 error generated.
  ninja: build stopped: subcommand failed.

Can you make an update to NDK 16b?

I haven't tried an NDK so new, so no direct experience.  Sounds like the header includes within the NDK are messed up.  I know newer NDKs have deprecated GCC, so this might be related to that.

Solution to migrate:
https://android.googlesource.com/platform/ndk/+/ndk-release-r16/docs/UnifiedHeadersMigration.md

I solve the problem with this code in my CMakeLists.txt:
set(USE_NDK_UNIFIED_HEADERS TRUE) # TRUE or FALSE

if (${USE_NDK_UNIFIED_HEADERS})
    if (${ANDROID_ABI} STREQUAL "x86_64")
        include_directories(${ANDROID_SYSROOT}/usr/include/x86_64-linux-android)
    elseif (${ANDROID_ABI} STREQUAL "x86")
        include_directories(${ANDROID_SYSROOT}/usr/include/i686-linux-android)
    elseif (${ANDROID_ABI} STREQUAL "arm64-v8a")
        include_directories(${ANDROID_SYSROOT}/usr/include/aarch64-linux-android)
    elseif (${ANDROID_ABI} MATCHES "^armeabi(-v7a)?$")
        include_directories(${ANDROID_SYSROOT}/usr/include/arm-linux-androideabi)
    elseif (${ANDROID_ABI} STREQUAL "mips")
        include_directories(${ANDROID_SYSROOT}/usr/include/mipsel-linux-android)
    elseif (${ANDROID_ABI} STREQUAL "mips64")
        include_directories(${ANDROID_SYSROOT}/usr/include/mips64el-linux-android)
    endif()
endif()


Would this map_controller keep our custom Marker's internal state?

Specifically when the marker is disposed because it is out of the screen and comes back in again(created)

Actually not, it just provides a way to manage the map assets. But as this is a recurring problem I started an implementation of stateful markers in a branch
It seems to be working, check the example and tell me what you think of the api please

Stateful markers has been released in 0.7.0


Feedback Component: Initial response is not according to mockup

Current Behavior
The temp response of "we got your feedback" is not what was in the mockup.
Feedback was given that this needed to be corrected.
This component was released and that phrase persists.
Expected Behavior
Use "Submitting your feedback..."

Contributor Guides and Resources

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Sistent site in Figma (open invite)
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

@captain-Akshay


Improve dump-configuration with inline comments to explain each rule

Right now, swift-format dump-configuration is a great (and automatically up to date!) source of documentation on what rules are available:
swift-syntax internal/swift-format/omit-returns ≡2s
 ❯ swift-format dump-configuration
{
  "fileScopedDeclarationPrivacy" : {
    "accessLevel" : "private"
  },
  "indentation" : {
    "spaces" : 2
  },
  "indentConditionalCompilationBlocks" : true,
  "indentSwitchCaseLabels" : false,
  "lineBreakAroundMultilineExpressionChainComponents" : false,
  "lineBreakBeforeControlFlowKeywords" : false,
  "lineBreakBeforeEachArgument" : false,
  "lineBreakBeforeEachGenericRequirement" : false,
  "lineLength" : 100,
  "maximumBlankLines" : 1,
  "noAssignmentInExpressions" : {
    "allowedFunctions" : [
      "XCTAssertNoThrow"
    ]
  },
  "prioritizeKeepingFunctionOutputTogether" : false,
  "respectsExistingLineBreaks" : true,
  "rules" : {
    "AllPublicDeclarationsHaveDocumentation" : false,
    "AlwaysUseLowerCamelCase" : true,
    "AmbiguousTrailingClosureOverload" : true,
    "BeginDocumentationCommentWithOneLineSummary" : false,
    "DoNotUseSemicolons" : true,
    "DontRepeatTypeInStaticProperties" : true,
    "FileScopedDeclarationPrivacy" : true,
    "FullyIndirectEnum" : true,
    "GroupNumericLiterals" : true,
    "IdentifiersMustBeASCII" : true,
    "NeverForceUnwrap" : false,
    "NeverUseForceTry" : false,
    "NeverUseImplicitlyUnwrappedOptionals" : false,
    "NoAccessLevelOnExtensionDeclaration" : true,
    "NoAssignmentInExpressions" : true,
    "NoBlockComments" : true,
    "NoCasesWithOnlyFallthrough" : true,
    "NoEmptyTrailingClosureParentheses" : true,
    "NoLabelsInCasePatterns" : true,
    "NoLeadingUnderscores" : false,
    "NoParensAroundConditions" : true,
    "NoVoidReturnOnFunctionSignature" : true,
    "OmitExplicitReturns" : false,
    "OneCasePerLine" : true,
    "OneVariableDeclarationPerLine" : true,
    "OnlyOneTrailingClosureArgument" : true,
    "OrderedImports" : true,
    "ReturnVoidInsteadOfEmptyTuple" : true,
    "TypeNamesShouldBeCapitalized" : true,
    "UseEarlyExits" : false,
    "UseLetInEveryBoundCaseVariable" : true,
    "UseShorthandTypeNames" : true,
    "UseSingleLinePropertyGetter" : true,
    "UseSynthesizedInitializer" : true,
    "UseTripleSlashForDocumentationComments" : true,
    "UseWhereClausesInForLoops" : false,
    "ValidateDocumentationComments" : false
  },
  "spacesAroundRangeFormationOperators" : false,
  "tabWidth" : 8,
  "version" : 1
}

But, it's not clear what exactly each of those rules does. Luckily, opening the actual source code and the swift file responsible for each particular rule, each rule class seems to have a handy docc comment explaining what that rule does, including both what to expect from linting, and from formatting with that rule.
I think it would be great if dump-configuration also rendered some short version of that explanation in an inline-comment, maybe just 1-2 line, before each rule.
How would you feel about adding that? If the idea seems reasonable, I would be happy to explore a way to make that and keep that up to date.
UPD:

DumpConfiguration.swift fetches the default Configuration() and then encodes it into json, which means it's very elegant and short, but less obvious how to inject comments into it.

JSON5 does support comments, and while it's possible to set allowsJSON5 on the JSONDecoder to allow it to parse JSON with comments successfully when it loads a configuration, there's no way to inject comments when encoding with JSONEncoder. So, doing this would require us to implement our own encoding logic for dump-configuration from scratch, which I don't think is really worth it.
Instead, the real issue is this parenthesized part:

Right now, swift-format dump-configuration is a great (and automatically up to date!) source of documentation

We need to do a much better job of keeping the documentation updated. DocC feels like it might at first be the obvious thing to reach for, because the rule documentation is represented as doc comments on the rules themselves, but there are some quirks about the rules (they're behind @_spi, they're not actually things we want users of swift-format as an API to see) that might make that more difficult. And we may want to use DocC for the actual public API, so I don't know if we should try to use the tool for both purposes.
Thinking about it more, we already have the generate-pipeline tool that uses SwiftSyntax to find all the rules. Maybe this should also scrape the rule documentation from each one and put it into a Markdown file to check in as part of the repo. Maybe it could even generate strings that could be used in a help description emitted by ArgumentParser, so that a formatter binary could stand alone.

I was doing some exploration yesterday night and got the late memo about json and comments. And yep, injecting comments into json AFTER it’s encoded sounds very hacky.
I think the idea with generating a markdown article into a docc bundle is an interesting path that might work!
Another idea: we could try and generate a Snippet and then use it in @.***` directive in DocC. Since the snippet is just a swift file, we can easily do that in generate-pipeline, and then we have a guarantee that the DocC bundle has an up to date list of rules with comments for each.
It feels like markdown is a better approach, we could also generate a docc table directive to make the list more readable and ahow default values.


XamlCompiler or GenXBF bug causes wrong index when Xaml parses the property

Describe the bug

InteractionTests.SplitButtonTests
InteractionTests.SwipeControlTests.SwipeIsNotTabStop
InteractionTests.TreeViewTests.ExpandCollapseViaAutomationTest_NodeMode
randomly failed in RS3 desktop run when SDK updating to insider 18312.
Steps to reproduce the bug

Steps to reproduce the behavior:

Go to 'MUXControlsTestApp' on RS3 desktop VM with x86fre flavor
Click on 'SplitButtonTests' by holding mouse a little bit long and then letting it go

Expected behavior

App is expected to be crashed.
Screenshots

Version Info

NuGet package version:

Windows 10 version
Saw the problem?

Insider Build (18312)
Yes

October 2018 Update (17763)
No

April 2018 Update (17134)
No

Fall Creators Update (16299)
No

Creators Update (15063)
No

Anniversary Update (14393)
No

Device form factor
Saw the problem?

Desktop
Yes

Mobile
No

Xbox
No

Surface Hub
No

IoT
No

Additional context

The simple way to repro this is to find a master commit without AVP change and modify its RS5 number 17763 to 18312.

need to revert change #245 when internal issue is resolved.

Fix will be available in an upcoming Windows SDK.


Added appname to list of valid option names

@sbilodeau would you mind adding a unit test for this?


[Enhancement Request] Option to display count of transitions.

Thanks for this panel, it's something Grafana has been sorely lacking for a very long time! :)
As title says, I would like to be able to display a count of transitions.
Even better would be some kind of histogram of transition count (e.g. number of transitions per hour, with hourly buckets).

in v0.0.5, it can show the transition count in the legend.
This histogram suggestion... i don't fully understand - why not just use the new histogram panel?


Restore refactor

longhorn/longhorn#1279

Due to the restriction, the live upgrade should be disabled for the old DR volume with Degraded state


About MPI-INF-3DHP

Sincerely hope that the author will open source the code of this dataset, countless people thank you for your selfless dedication. Really thank you.

Sorry. You can use the MPI-INF-3DHP code in https://github.com/paTRICK-swk/P-STMO.


Add X-Forwarded-Proto HTTP header to zuul proxy requests

If the zuul reverse proxy and the destination services are using a different scheme
(for example HTTPS on proxy side and HTTP on service side) an additional HTTP
header is required according to RFC7239 [http://tools.ietf.org/html/rfc7239]
This PR fixes #514

closed via bea48c515099f3b78fa9eb748016bbbecdacf0cb


Binding "tap" and "doubletap" on same element

I've tried binding "tap" and "doubletap" on the same element but cannot get the "doubletap" to fire. Is there a way to bind multiple events to the same element?

Closing this due to age and inactivity this is from V1


[feature] Update the provenance format in the docker-based generator

Describe the solution you'd like
The current provenance format does not quite comply with SLSA provenance v1.0. The following changes are needed.

Move config parameters to the input mapValue (see https://github.com/slsa-framework/slsa-github-generator/pull/1547#discussion_r1073705487)
The command is encoded as a JSON string (see https://github.com/slsa-framework/slsa-github-generator/pull/1547#discussion_r1081594741)
Restructure external parameters  according to the new format as in this example.

Additional context
See also

https://github.com/in-toto/in-toto-golang/issues/197
https://github.com/slsa-framework/slsa-github-generator/pull/1547
https://github.com/slsa-framework/slsa-github-generator/issues/1191

Thanks for this issue! I was just thinking about this. OK if I make this update?
I'm also thinking when in-toto is ready to make a PR we can probably move the definitions here upstream.
Only still confused about the oneof representation.
For generated proto, it uses interfaces -- so something like that can work, but I'd like to not introduce proto runtimes into the deps

Thanks for this issue! I was just thinking about this. OK if I make this update?

Yes. Sure. Thanks :)

I'm also thinking when in-toto is ready to make a PR we can probably move the definitions here upstream.
Only still confused about the oneof representation.
For generated proto, it uses interfaces -- so something like that can work, but I'd like to not introduce proto runtimes into the deps

I don't have any experience with using protobufs in Go myself, but had a chat with @tiziano88, and his suggestion was that if interoperability with other languages and services is needed, then code generation from protobuf is preferable.
But I agree with you about runtime dependencies. Is it possible to start with a hand-written definition and replace it with auto-generated code in the future if there is need for it?


More warnings

@mrpollo suggested to have a look at additional warnings mentioned in https://kristerw.blogspot.ch/2017/09/useful-gcc-warning-options-not-enabled.html.

Changes Unknown when pulling e18d5409d6bfdbcb377fec26c288a1a21eda73ed on more-warnings into ** on develop**.


failed to load customDeps

I try to add magellan  to  customDeps
so my customDeps section looks like this:
"customDeps": [
    "harsha2010:magellan:1.0.4-s_2.11"
  ]

and I get the following error in my browser console
[com.jcabi.aether.Aether] #resolve(harsha2010:magellan:jar:1.0.4-s_2.11, 'runtime', com.datafellas.utils.Deps$$anon$1@57aff85e): thrown org.sonatype.aether.resolution.DependencyResolutionException(failed to load 'harsha2010:magellan:jar:1.0.4-s_2.11 (runtime)' from ["Maven2 local (file:/home/dr0ff/.m2/repository, releases+snapshots) without authentication", "maven-central (http://repo1.maven.org/maven2/, releases+snapshots) without authentication", "spark-packages (http://dl.bintray.com/spark-packages/maven/, releases+snapshots) without authentication", "oss-sonatype (https://oss.sonatype.org/content/repositories/releases/, releases+snapshots) without authentication"] into /tmp/spark-notebook/aether/25783b94-03a3-408f-a8d5-548350b5bc4c) out of com.jcabi.aether.Aether#fetch[237] in 5s
...

I also get the same error when I try to use sbt format:
 "customDeps": [
    "harsha2010 % magellan % 1.0.4-s_2.11"
  ]

The strange thing I see is that it tries to resolve harsha2010:magellan:jar:1.0.4-s_2.11 with that extra :jar: added.
I tried with pre-built distribution spark-notebook-0.7.0-scala-2.11.8-spark-2.1.1-hadoop-2.7.2
and I also tried to build Spark Notebook from the sources sbt -Dspark.version=2.1.1 -Dhadoop.version=2.7.0 -Dscala.version=2.11.8
When I try to remove this dependency from customDeps and add it to build.sbt and build Spark Notebook from the sources then it works fine.

seems like a bug in dependency resolving in scala 2.11


Add Codable extensions

This pull request adds extensions to better support Codable models for the following situations:
Metadata
Many of the Watson Developer Cloud models support a generic metadata: [String: Any] property, allowing users to upload/receive an arbitrary JSON object. However, the [String: Any] type does not conform to the Codable protocol.
To support metadata properties, this pull request adds a concrete JSONValue enum type to decode values using trial-and-error. As a concrete type, a JSONValue can encode itself easily.
// decoding
let container = try decoder.container(keyedBy: CodingKeys.self)
metadata = try container.decode([String: JSONValue].self, forKey: .metadata)

// encoding
var container = encoder.container(keyedBy: CodingKeys.self)
try container.encode(metadata, forKey: .metadata)

Additional Properties
Many of the Watson Developer Cloud models are dynamic, i.e. not all of their keys are known in advance. (This is represented by a Swagger specification using the additionalProperties field.)
We considered a way for users to specify the additional key-value pairs to encode/decode. However, there are some models like System where additional properties must be echoed back to the service, even though users do not know the relevant keys.
To support additional properties, this pull request adds a DynamicKeys struct, along with extensions to KeyedEncodingContainer<DynamicKeys> and KeyedDecodingContainer<DynamicKeys>. These extensions filter the known key-value paris, then decode the remaining key-value pairs into a [String: JSONValue] dictionary.
// decoding
let container = try decoder.container(keyedBy: DynamicKeys.self)
additionalProperties = try container.decode([String: JSONValue].self, excluding: CodingKeys.allValues)

// encoding
var container = encoder.container(keyedBy: DynamicKeys.self)
try container.encode(additionalProperties)

Notes

To see the extensions in-action, review ServiceModel and ServiceModelOptional in CodableExtensionsTests.swift. This is what our models will look like after transitioning them to use Codable.

Thanks again for the review, @carlbrown! Really appreciate it.


Rotatable Cryo Pods

About the PR
Pods can now face east as well as west.
(Also makes the description properly capitalized and punctuated.)
Why / Balance
For mapping, mostly.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame.

Tests failed, bad PR


Night Mode

Is your feature request related to a problem? Please describe.

I want to add night mode feature to the website.

Describe the solution you'd like

I will make switch toggle button and using javascript I will toggle the Dark mode class in the website sections.

@ravikr126 If valid Please assign me

no need of night mode on website @vedant-jain03


Adds SE2BoxConstraint

This PR adds:

SE2BoxConstraint which is Testable, Sampleable, and Projectable.
helper methods in JoinStateSpaceHelpers-Impl.hpp so that dart's SE2 joints with x, y constraints can use be tested, sampled, and projected.
SE2 distance metric distance::SE2 which takes l2 norm of (dx, dy, dw). (Happy to take other suggestions too.)

To be consistent with SO2 and SO3 samplers, this does not allow limit on rotational joint, but only on x, y dimensions.

This change is

Why did you close this? These look like a great set of changes.

I realized that I wanted to make some changes, e.g. making the distance
function weighted sum of radial distance and R^2 norm , and add at least
some basic tests. Not sure I could do it in the next a few days (given IROS
deadline), so I'll re open it as soon as its ready!
Thanks for noticing.

Gilwoo

On Sun, Feb 12, 2017 at 7:47 PM, Michael Koval<EMAIL_ADDRESS>wrote:

Why did you close this? These look like a great set of changes.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/personalrobotics/aikido/pull/135#issuecomment-279270356,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE7LaGHTVR8psOgKlBNhZNZnsGm_pxbdks5rb6gRgaJpZM4L96dl
.

This is not demo-priority but we'll need it eventually for base planning. I haven't made any changes I promised, but it'd be great if someone could take a quick pass and comment/agree on the general structure.

Codecov Report

Merging #135 into master will decrease coverage by 2.01%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           master   #135      +/-   ##
========================================
- Coverage   71.01%    69%   -2.02%
========================================
  Files         168    172       +4
  Lines        4910   5104     +194
  Branches      777    810      +33
========================================
+ Hits         3487   3522      +35
- Misses        944   1101     +157
- Partials      479    481       +2

Impacted Files
Coverage Δ

src/statespace/SE2.cpp
76.05% <ø> (ø)
:arrow_up:

include/aikido/distance/detail/defaults-impl.hpp
64% <0%> (-2.67%)
:arrow_down:

include/aikido/distance/SE2.hpp
0% <0%> (ø)

...ude/aikido/constraint/uniform/SE2BoxConstraint.hpp
0% <0%> (ø)

src/constraint/uniform/SE2BoxConstraint.cpp
0% <0%> (ø)

src/distance/SE2.cpp
0% <0%> (ø)

.../constraint/detail/JointStateSpaceHelpers-impl.hpp
48.33% <0%> (-9.28%)
:arrow_down:

... and 3 more

It'd be great if you have time to add the weighted norm and tests, but it might be easier to address it in a future PR and merge this now!

:+1: If we merge this without those great changes, then it would be less great to add issues to track this issues. :smile:

If we merge this without those great changes, then it would be less great to add issues to track this issues.

Introduced the weighted norm and added tests. Please do review. Thanks!

Unrelated issue: It seems the Travis tests on ubuntu isn't working due to http://packages.personalrobotics.ri.cmu.edu is down. Let me resolve this by switching to using PPA instead of running our own debian package server, as discussed.

@jslee02 I agree, the Weighted class needs to be renamed. Pushed the relevant changes and issued a warning message suggesting the new class, in the Weighted.hpp file. Thanks!


ANSI coloring of debug output

Reading the debug output of ServiceProfiler is hard because it's using ANSI coloring.
Visual Studio 2019 does not support ANSI coloring in debug window so the output looks like this:
dbug: ServiceProfiler.EventPipe.Client.ServiceProfilerProvider[0]
Entering StartServiceProfilerAsync.
dbug: ServiceProfiler.EventPipe.Client.ServiceProfilerProvider[0]
Trace: /tmp/4e918aef-39ec-472c-a237-18bb17b14df9.netperf
Since many packages are using ANSI coloring today, the best solution would be to make VS support it, but they for some reason does not see this as a issue.
Is there a way to enable/disable ANSI coloring from debug output?

The Console Logger has a ConsoleLoggerOptions.DisableColors property.
You should set it to 'true' in your configuration (appsettings.json)

@Eneuman I just want to follow up a bit since it has been days. Does the answer from @pharring solves your issue?

Yes it did!
Thanks @pharring
Really hope the VS team can fix colouring in the window. VS Code already got it.

Från: Saar Shen<EMAIL_ADDRESS>Skickat: Tuesday, February 18, 2020 8:01:50 PM
Till: microsoft/ApplicationInsights-Profiler-AspNetCore<EMAIL_ADDRESS>Kopia: Per Bornsjö<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Ämne: Re: [microsoft/ApplicationInsights-Profiler-AspNetCore] ANSI coloring of debug output (#76)
@Eneumanhttps://github.com/Eneuman I just want to follow up a bit since it has been days. Does the answer from @pharringhttps://github.com/pharring solves your issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ApplicationInsights-Profiler-AspNetCore/issues/76?email_source=notifications&email_token=AC4J5TOYNCT6ATSCJEPAYWTRDQWB5A5CNFSM4KUOMI4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMDRKAY#issuecomment-587666691, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC4J5TL3VHR3MTX7UXX6XWLRDQWB5ANCNFSM4KUOMI4A.


Thread names sometimes are not displayed

Please examine this payload on your live version of Perfetto:
bug-report.json.txt
As you can see, I get an untitled Thread 29 instead of ipc 29 in my primary 71556 process.

This seems weird, because in the JSON attached I have thread 29 names for both the processes:
	{"ph":"M","args":{"name":"primary"},"ts":3150987578506433,"tid":0,"pid":71556,"name":"process_name"},
	{"ph":"M","args":{"name":"lifecycle"},"ts":3150987578507433,"tid":0,"pid":71556,"name":"thread_name"},
+	{"ph":"M","args":{"name":"ipc"},"ts":3150987578522433,"tid":29,"pid":71556,"name":"thread_name"},
...
	{"ph":"M","args":{"name":"secondary"},"ts":3150987578523433,"tid":0,"pid":71557,"name":"process_name"},
+	{"ph":"M","args":{"name":"ipc"},"ts":3150987578523433,"tid":29,"pid":71557,"name":"thread_name"},
...

Could you help, please?

Is there a range limit for thread IDs? We generate fake thread IDs because it is JavaScript. 🤷♂  I mean, is it 16-bit or 32-bit?

tids have to be 32-bit numbers so you have 2^32 options - this is plenty even for actual operating systems so should be sufficient for pretty much any use case you have :)

@LalitMaganti, thank you for the insightful and prompt response (and the amazing tool which Perfetto is)! My question now is completely closed.


Update RequestBuilder.java to accept String data type in setRequestBody method

Please and Thank You.

Closing due to lack of activity.


Implement Gradient

I notice you use a 3rd party module to evaluate the gradient of your cost function in your GD routine. What was the reasoning behind this and why not implement it?

There are tens of functions in deep learning module. I prefer simplicity, so everyone can understand the concept behind this.
Flexibility. People can play around with custom functions. No need to manually differentiate them.

But we can definitely get rid of this library in linear models.

for completeness sake: the closed form derivative of mse (ie cost function used in linear regression) is fairly straightforward. the problem is, however, computing gradients for more complicated cost functions like the ones seen in neural networks.


If the Build workflow fails, the SARIF upload also fails

If the Build workflow fails, no SARIF files are created and the "Upload lint reports (SARIF)" step also fails with:
Error: No SARIF files found to upload in "./".
For example: https://github.com/android/nowinandroid/actions/runs/12379945378/job/34555220383?pr=1757.
When opening the failed workflow, the default view is to show the last error. This makes things confusing because it's not the SARIF upload step that is the root cause of failure.
@SimonMarquis any chance you could take a look and change the SARIF upload step so that it only attempts the upload if the SARIF files have been created?

A PR has been created to fix this issue.
It now only runs when the workflow is not canceled and at least one sarif file is found.


"Abort" tasks

Add the ability to abort tasks

@elahehrashedi not sure if it solves all cases but in my PR related with running tasks from Project Outline I have added also cancel task feature.


Error with yarn test

After running yarn, I get this error when running yarn test:
➜  token-vesting-contracts git:(main) ✗ yarn test
yarn run v1.22.10
$ npx hardhat test --logs
Error HH404: File lib/solmate/src/tokens/ERC20.sol, imported from src/TokenVesting.sol, not found.

For more info go to https://hardhat.org/HH404 or run Hardhat with --show-stack-traces
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

After running yarn, I get this error when running yarn test:
➜  token-vesting-contracts git:(main) ✗ yarn test
yarn run v1.22.10
$ npx hardhat test --logs
Error HH404: File lib/solmate/src/tokens/ERC20.sol, imported from src/TokenVesting.sol, not found.

For more info go to https://hardhat.org/HH404 or run Hardhat with --show-stack-traces
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

the forge build command works for you ?

Unrelated question but have you thought of adding the feature of handling multiple beneficiaries by having a list of beneficiaries instead of one beneficiary?

Sorry, I meant to say I did NOT install foundry 😖 Since the documentation implies that the repo can be used with hardhat without foundry. Trying with foundry now... The tests do work after running allthe foundry commands. Maybe you should specify it is necessary in the readme...

Oh ok. Yeah it should be more explicit indeed. Feel free to submit a PR if you want ;)

Unrelated question but have you thought of adding the feature of handling multiple beneficiaries by having a list of beneficiaries instead of one beneficiary?

That's a good feature request. Can you please describe it in an issue ?

Sounds good I will make a PR and an issue later today

Sounds good I will make a PR and an issue later today

awesome thanks


Reconnect after a configurable delay

Pull Request Checklist

[ x] Have you read How to write the perfect pull request?
[ x] Have you read through the contributor guidelines?
[ x] Have you added tests for any changed functionality?

Fixes
This fixes performance problems when one of the nodes in the replica set is down and RM tries to reconnect.
Purpose
This PR introduces a non-blocking, configurable delay for reconnecting when a node is down.
Background Context
The current version of RM since 0.15.1+ has a performance problem with reconnecting. It tries to reconnect as soon as connection fails. Then reconnect fails again and it goes in a loop as long as a node is down. Reconnecting attempts can happen 1000s times per second impacting the performance of the entire app and maxing out cpu. This is regardless of logging level that is set. A better approach in my opinion is to retry after some delay. I have arbitrarily chosen 1000 ms but I'm not married to this number and the PR lets users choose incl 0ms if they want current behaviour.
This problem seems to be system specific. I was able to reproduce on several linux boxes but problem doesn't happen on Macs, at least on Macs I tested. I don't know what causes the problem or difference between systems but after the fix everything continues to work fine on Macs and also works on linux.
ReactiveMongo generally doesn't do anything platform specific but it uses Netty which has a history of problems with specific linux kernel versions, e.g. https://github.com/netty/netty/issues/2616.
References
Are there any relevant issues / PRs / mailing lists discussions?
https://groups.google.com/forum/#!topic/reactivemongo/UK26oAL4eIo

Closing as #787 fixes the problem in a better way


flask app

Description
Problem Solved
Please include the name of the problem solved
NOTE: only one pull request per problem is accepted.
Also, if a pull request solves multiple problems, only one of the solved problems will be add to the user points (and therefore the leaderboard)
Dependencies and Reason
List any dependencies that are required for this solution and the reason why you used these dependencies
List of Developers
This solution has been implemented by the following Developers:

@GithubProfileTag

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] I have checked my code and corrected any misspellings

NOTE: the PR have to be labelled in-progress until the work is complete, the PR will be checked, reviewed and merged only after being labelled as complete

Tolti 50 punti perché non ci sono i 5 algoritmi di sorting e la soluzione non è adatta per le stringhe


Vicky Thomas Project

In the introductory paragraphs, you say that your application of interest is a conveyor belt. But you didn’t try to illustrate the application, as you just write down an equation and simply tell your reader that it describes “the movement of a string-like belt.” You did not explain what the dependent variable u represents.
"An example of a mixed PDE looks like” —> what you show is simply a mixed partial derivative operator … not a PDE (there is no equation shown!)
“Any kind of discretization can be used …” —> This appears to contradict what we stressed throughout this course, which is that the selection of an appropriate discretization scheme needs to take into account the physics represented by the PDE.
Then you show the discretization of the second-order time and space derivatives, and call that “Euler’s method.” That is not Euler’s method.
What you show next for the time derivative, du/dt, that is Euler’s method (it is the same as “forward in time”).
Also, we covered second-order derivatives in the course. We saw them for the first time in Module 2, with the diffusion equation (notebook 3)
http://nbviewer.ipython.org/github/numerical-mooc/numerical-mooc/blob/master/lessons/02_spacetime/02_03_1DDiffusion.ipynb
The discrete second-order derivative is shown there in Eq. (2).
This is not what you are showing for your discretizations of similar terms.
I’m afraid what you have is wrong :-(
BCs: “We need two since our time variable is second order” —> time derivative is second order
The rest of the notebook applies what we learned in the course about how to set up the solution with implicit methods (Module 4, notebook 2). The procedure looks correct, but of course you carry the mistake from the bad discretization.
In your second reference (from Physics Forums), the discussion thread finally arrives at an analytical solution for the PDE, which your could have used to check that your numerical solution is correct. You might have found your mistake then …
But in the end, you got “a solution” to your numerical problem, and it looks like you accepted it without reflecting on what it means, or what the physics of the problem should look like. Overall, it’s a cursory investigation of the problem, and it seems rushed (hence the mistakes).
Typos, grammar, etc.
so that its very clear —> it's


oauth2: Fix panic when oauth upstream is unhealthy

As discussed on<EMAIL_ADDRESS>Envoy currently panics when receiving an Oauth callback while the Oauth has no healthy upstream (e.g. because Envoy can't resolve its hostname), because the onSuccess callback is called immediately during the request dispatch in that case, before the oauth state is changed to pending.
The fix is to set the state before sending the request. Since the state isn't used anywhere else, there's no reason to only set it afterwards.
Unfortunately, I wasn't able to test this properly because I ran into various rather random-looking Bazel failures both building locally or using the CI Docker script (on a Mac).
Failure using the CI Docker script
```
ERROR: /build/bazel_root/base/external/envoy/bazel/foreign_cc/BUILD:11:15: no such package '@com_github_axboe_liburing//': error globbing [**] op=FILES: /build/bazel_root/base/external/com_github_axboe_liburing/man/IO_URING_VERSION_MAJOR.3 (Too many levels of symbolic links) and referenced by '@envoy//bazel/foreign_cc:liburing'
```

Failure using the CI Docker script on the v1.30.1 tag
```
ERROR: /source/WORKSPACE:13:19: no such package '@v8//': error globbing [tools/testrunner/**/*.py] op=FILES: /build/bazel_root/base/external/v8/tools/testrunner/testdata/testroot6/out/build (No such file or directory) and referenced by '//external:wee8'
```

Failure building directly on Mac OS
```
compiling lib/findprog-in.c...
./lib/findprog-in.c:149:25: error: call to undeclared function 'eaccess'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                    if (eaccess (progpathname, X_OK) == 0)
                        ^
./lib/findprog-in.c:149:25: note: did you mean 'access'?
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/unistd.h:431:6: note: 'access' declared here
int      access(const char *, int);
         ^
./lib/findprog-in.c:301:21: error: call to undeclared function 'eaccess'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                if (eaccess (progpathname, X_OK) == 0)
                    ^
2 errors generated.
Compilation failed.
_____ END BUILD LOGS _____
rules_foreign_cc: Build wrapper script location: bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/rules_foreign_cc/toolchains/make_tool_foreign_cc/wrapper_build_script.sh
rules_foreign_cc: Build script location: bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/rules_foreign_cc/toolchains/make_tool_foreign_cc/build_script.sh
rules_foreign_cc: Build log location: bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/rules_foreign_cc/toolchains/make_tool_foreign_cc/BootstrapGNUMake.log
```

Commit Message: oauth2: Fix panic when oauth upstream is unhealthy
Risk Level: Low
Testing: unit test
Docs Changes: N/A
Release Notes: Added
Platform Specific Features: N/A

There is a build error: https://source.cloud.google.com/results/invocations/49bee7ae-a361-46e0-b9ce-9feec302bb92
/wait

Hm, now the test fails but I don't really understand why. I'm not sure I'm reading the stack trace correctly but it looks like it's failing in the destructor, I guess here? But in_flight_request_ should have been set to nullptr here 🤔

Hm, now the test fails but I don't really understand why. I'm not sure I'm reading the stack trace correctly but it looks like it's failing in the destructor, I guess here? But in_flight_request_ should have been set to nullptr here 🤔

To fix the crash, please move the std::shared_ptr<OAuth2Client> client_; to be the last member of the OAuth2ClientTest class. Your test introduced order dependency in the cleanup.
/wait

@yanavlasov anything else the author needs to do before another round of review?


Consider cors caching

Done. Added to CorsOptions:
public TimeSpan? PreflightCacheDuration { get; set; }

Defaults to null for now, but maybe for 2.0 we default to 1h or 24h?
// @leastprivilege


Project setup

Project link: https://github.com/DilsherB/Space-Travelers-Hub/projects/3
We are two members of this group's capstone

Hi @Mahamadou-Nouridine and @DilsherB,  👋🏻👋🏻
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

[ ] Great job on the set up the kanban 💯
[ ] Followed Gitflow 🔥
[ ] No Linters error ✅
[ ] Kudos wokring on the cards and  ⭐

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


[SDP-1316] Rename fields for receiver invitation template and interval

Rename the following fields for organization and disbursement

sms_resend_interval -> receiver_invitation_resend_interval_days
sms_registration_message_template -> receiver_registration_message_template

This change is required to match the breaking change introduced in this PR https://github.com/stellar/stellar-disbursement-platform-backend/pull/412

stellar-disbursement-platform-frontend-preview is available here:http://sdp-frontend-pr147.previews.kube001.services.stellar-ops.com/


Getting error trying to build library of components

Version
3.0.0-beta.6
Reproduction link
https://github.com/jineshshah36/vue-test-lib
Steps to reproduce
clone repo, run yarn, run yarn run build.
What is expected?
Build should create a lib of components
What is actually happening?
Build will fail

Would it be possible to share the error in the issue description so we might get a first idea whats happening before we clone the reporduction repository (thanks for setting that up btw)?

I think you are only missing the entry point of your components in your build script. Something like this: vue-cli-service build --dest lib --target lib src/main.js. This should give you a little more context: https://github.com/vuejs/vue-cli/blob/dev/docs/build-targets.md#library

You are correct, but actually in the process, I have uncovered a new bug If you clone the repo and yarn run build you'll see that it does build but because I had a dash in the name, it spits out. It should probably camelcase the name?
<script src="https://unpkg.com/vue"></script>
<script src="./joinarthur-components.umd.js"></script>
<link rel="stylesheet" href="./joinarthur-components.css">

<div id="app">
  <demo></demo>
</div>

<script>
new Vue({
  components: {
    demo: joinarthur-components
  }
}).$mount('#app')
</script>

I'm seeing this with a scoped package as well.  Is there a way to set the name in the umd.js besides project name?

I've created issue #1064 and a sample repo for the scoped library issue.  Maybe someone will be able to show me what I've done wrong :-)

Closing as the original repro seems no longer available.


#1379 fix

True fix of https://github.com/BrowserSync/browser-sync/issues/1379

@shakyShane please, check this out.

@shakyShane we can implement truly glob support in bs.reload with minimatch lib

@shakyShane ?

@shakyShane hey?

@shakyShane 😞


Reduce verbosity of debug impls for protobuf messages

This should get forward-ported to main as well

The tracing::info! issue is only on main


Could not locate error file: ./MODEL.ERR

Hi Developers,
After compiling and configuring the dscsm048 executable following msg came at my LINUX system:

Could not locate error file: ./MODEL.ERR
Unknown ERROR. Error number:    90
File:                Line:     0 Error key: CSM
Additional information may be available in WARNING.OUT file.

Does it mean the executable file is not properly configured? Because when I run the model code, it says dscsm048 not find.
I don't see any additional information in WARNING file except Run 0.
Thanks for any help.

Hi @vineetk008,
You can get the MODEL.ERR file from the DSSAT48 folder when you install DSSAT in a Windows environment. However, if you do not have that folder, you can find the files necessary to run the model here: https://github.com/DSSAT/dssat-csm-os/tree/develop/Data (including the MODEL.ERR file) and here https://github.com/DSSAT/dssat-csm-data.
The error that you are getting is: CSM      90 Runmode not specified or invalid
About your question:
How are you running the model? I am providing an example for running DSSAT using a batch file for the experiment EBPL8501.MZX  of maize which is available here https://github.com/DSSAT/dssat-csm-data/tree/develop/Maize:
Use the following command: dscsm048 MZCER048 B DSSBatch.v48. I am attaching an example of the batch file, but you will have to modify lines 11 to 14 based on the path where you put your experimental files (change the txt extension to .v48) DSSBatch.txt.


Add support for throttling plugin for xrootd cache

Creates a config knob that if set, enables the throttling plugin for xrootd. Also adds a simple unit test to ensure it is set in config. Settled on the name Cache.Concurrency but that can be easily changed.

@matyasselmeci do you want me to go ahead and merge? Or do you want to wait for Brian's input?

Let's merge it so I can try it out on sc-cache. (I don't need a release, I'll just build from main.) We have time to change the name before the release if Brian wants us to.


UnoSquare version not reconciling

An unhandled exception has occurred while executing the request.
System.IO.FileLoadException: Could not load file or assembly 'Unosquare.Labs.EmbedIO, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
File name: 'Unosquare.Labs.EmbedIO, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'
at SpotifyAPI.Web.Auth.SpotifyAuthServer`1.Start()
When I try to call auth.Start() I always get this error. I tried going into the assembly file and changing it to <IP_ADDRESS> instead of what's there which is <IP_ADDRESS> but that didn't work. I just downloaded this nuget package so I am running the latest versions. Any suggestions?

i installed the <IP_ADDRESS> version of EmbedIO into the project just to get installed in the cache locally and ran it and now it works!


Change pkg_resources call in plugin loading to use resolve rather than load

This change affects the plugin loading code. Instead of calling load(), which triggers requirements checking, we now call resolve() which does not check requirements.
The main purpose of this change is to work around an issue in setuptools resulting in conflicting package names:

The logic for parsing available package names parses the file name from site-packages directory (thus parsing zope.component, for example)
The logic for parsing required package names parses the name from requirements.txt (thus parsing zope-component)

The requirements.txt change to use hyphens (zope-component) instead of periods (`zope.component) is fairly new, and apparently was introduced in pip-tools v6.5.1. I tried downgrading pip-tools but ran into other issues.
This change feels reasonable as the plugin loading logic doesn't seem to be a location where we need to enforce package requirements, as it's only a small portion of the overall project.
I've also included a dependency update to ensure that the tests now pass even with the zope. to zope- naming style change included.

Coverage remained the same at 62.311% when pulling f9dc0d15fe2dd3441d4a8d2af52c6547eae1ffa3 on jtschladen:change-load-to-resolve into 800ab3299002b979af8342634044a20eb07e0154 on Netflix:master.


Allow using YAML instead of JSON when passing in JSON to a request.

Since JSON is a subset of YAML, we should be able to build YAML files and convert them easily to JSON similarly to how we can create a JSON representation of  a form-encoded POST.

Fixed in YAML PR


Deleting the Tier tag category causes UI errors

Affected module
UI, maybe backend.
Describe the bug
After deleting the default "Tier" tag category, an error with the text "tagCategory instance for Tier not found" will keep poping up (as a notification in the top left corner) for various pages where Tier tags would normally appear: /explore, /table/<fqn>/manage.
On the /explore page, on the left pane, the Tier filter still appears even if the Tier category has been deleted.
To Reproduce
Run the docker image and sample data ingestion. Delete the "Tier" tag category.
Expected behavior
Tier being pushed as a "critical" tag is not ideal - users should be able to decide what tags are important in their organization.
This can be a good opportunity to rethink Tiers and how other tag categories can be given more or less importance.
Version:

OS: WSL2 on Windows10 running Ubuntu 18 - Docker on Windows
OpenMetadata version: 0.11.0

@harshach Need to discuss this

@chirag-madlani @ShaileshParmar11 deleting system tags will not be allowed, Users can edit and change the display name of it.
cc @sureshms

UI changes are pushed in PR #8703

Tier tags are system tags. Whether an organization uses it or not, many of OpenMetadata feature uses tiering information in various features. Given system tags can't be deleted, this issue should not occur. Marking as closed.


Ability to customise properties of composite objects

AutoFixture allows you to customise particular properties of objects using this syntax
fixture.Build<Order>().With(x => x.Id, "ABC-123").Create();

This works because C# is able to evaluate the lambda expression to pull out the string "Id".
As a first step I'd like JFixture to be able to do this using a stringly typed API, so something along the lines of
fixture.customise().properyOf(Order.class, "Id", "ABC-123");

Hi, Absolutely loved the library, is this feature implemented yet, If not can I offer any help ?

Hi @waliahimanshu , thanks for the kind words!
I've not worked on this in ages to be honest - I'm a C# dev at work and so this library hasn't been my focus lately, although I should be looking at more often TBH.
Last time I was looking at this issue I was trying to think about the best way it would work under-the-hood, but couldn't come with anything I was happy with, but here's what I was thinking 2 years ago (that I can remember!):

It'll be pretty easy to implement if the API uses strings, e.g. With("Id", "ABC-123"), but using strings to specify the getter is prone to a number of problems. Maybe it's ok as a first iteration though?
It'll be great if this could be strongly typed (as in the example in the original post)
C# does this using Expressions, and the original AutoFixture library uses this mechanism
I had a play with a proxy library (I forget which one) that recorded the invocation and extracted the name out of the invoked method name. Not too hard to do - but it does add a dependency to JFixture which I'd like to avoid.
The newest version of C# also has the nameof operator which looks like With(nameof(order.Id).. which would work too

I've also been thinking of spinning out V3 and only supporting Java 8 (with V2 for Java 6/7). So if Java 8 offers a type-safe way of getting the name of a getter/setter I'd be super happy to include that in V3.
Do you know if Java has a similar mechanism nowadays for doing this?
Thanks

I recently started with Android(Java), was doing .net before and using AutoFixtures a lot for TDD.
I will explore the options java 8 has to offer.
Keen to look at the first point. Will let you know if I have some questions or when I know more around this.

+1 for this
Java 8 has method references, but their name cannot be queried just by using the platform. Even if it worked you couldn't do the same with fields (there're no field references in the language). See http://stackoverflow.com/q/19845213/253468 for more. One of the answers uses Mockito, that might be the same as your point about the proxy library.
Love the idea of the name "stringly typed API", never heard that before :)

@TWiStErRob thanks for the info, that reinforces my understanding. I think the best thing here is to implement a stringed API so people can start using it immediately, then figure out a strongly typed API that will just call down to the string version. Probably using the concept of a proxy (you're right that this is how Mockito does it). Java has a built in mechanism for this that I'll explore too.

Awesome! Thanks for the effort.
(note: comment on commit)


Not all content read on the menu screen with Talkback on

Samsung Galaxy J3 Prime
Android version 7.0
Scenario to reproduce
While Talkback is on, using “Read from top” from “Global Context menu” or swiping right to move to each element on the COVID Alert menu screen, Talkback starts reading from the top of the screen. However, the screen doesn't scroll up automatically while Talkback is on. Talkback stops reading when it reaches what is visually displayed on the screen.
Expected result
Talkback should read all the content on the screen.
Screenshots

@smcmurtry @henrytao-me is this because of pageview vs scrollview?
I can access the content under this point with android but it requires swiping to the right vs. read all.

It's because of BottomSheet component that we are using. BottomSheet controls it own scroller which is not accessibility friendly. If we put a ScrollView inside it. It cannot scroll properly when there is screen reader.

@henrytao-me lets test out your solution.

Similar problem here: https://github.com/cds-snc/covid-shield-mobile/issues/550

Ref https://github.com/cds-snc/covid-shield-mobile/pull/576

Android 8.1.0
This is still happening in version 1.0 (49) and user is stuck at the bottom of the visual screen. TalkBack stops announcing here for swiping right and "read from top".
Android 10 on OnePlus 7 is fine.

Samsung Galaxy J3 Prime
Android version 7.0
Application version: 1.0 (49)
The issue still remains the version 49.


⚠ Bofrost.lu has degraded performance

In 485139d, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2685 ms

Resolved: Bofrost.lu performance has improved in 706a7b2 after 6 minutes.


Add Update Location Button

If you've already added images but didn't have MapBox setup right away there is no way to get the location info recognized in those old images. We should either have an "Update Location Button" or rescanning a source should add location info to old items if it is missing.

.


Textboxes-Are-Well-Formed.test.ps1: fails, but no helpful output

On the attached input, I observe that Textboxes-Are-Well-Formed.test.ps1 fails, and produces this output
[-] Textboxes Are Well Formed (107 ms)

Looking at the test, I see a bunch of Write-Error outputs but I sure
don't see them above.  I instrumented the test like so:
param(
# The contents of CreateUIDefintion, converted from JSON.
[Parameter(Mandatory=$true,Position=0)]
[PSObject]
$CreateUIDefinitionObject
)

# First, find all textboxes within CreateUIDefinition.

$allTextBoxes = $CreateUiDefinitionObject | Find-JsonContent -Key type -value Microsoft.Common.TextBox

Write-Host "debug: edburns: allTextBoxes $($allTextBoxes)"

foreach ($textbox in $allTextBoxes) { # Then we walk over each textbox.
    Write-Host "debug: edburns: $($textbox.Name)"
    if (-not $textbox.constraints) { # If constraints was missing or blank,
        Write-Host "debug: edburns: missing constraints"
        Write-Error "Textbox $($textbox.Name) is missing constraints" -TargetObject $textbox # error
        continue # and continue (since additional failures would be noise).
    }
    if (-not $textbox.constraints.regex) { # If the constraint didn't have a regex,
        Write-Host "debug: edburns: missing regex"
        Write-Error "Textbox $($textbox.Name) is missing constraints.regex" -TargetObject $textbox #error.
    } else {
        Write-Host "debug: edburns: has regex"
        try { # If it did,
            [Regex]::new($textbox.constraints.regex) # try to cast to a regex
        } catch {
            Write-Host "debug: edburns: exception caught"
            $err = $_ # if that fails,
            Write-Error "Textbox $($textbox.Name) regex is invalid: $($err)" -TargetObject $textbox #error.
        }
        Write-Host "debug: edburns: no exception"
    }
    if (-not $textbox.constraints.validationMessage) { # If there's not a validation message
        Write-Host "debug: edburns: missing validationMessage. Textbox $($textbox.Name) is missing constraints.validationMessage"
        Write-Error "Textbox $($textbox.Name) is missing constraints.validationMessage" -TargetObject $textbox #error.
    } else {
        Write-Host "debug: edburns: has validationMessage"
    }
}

And when I re-run it, I see this output.
debug: edburns: missing validationMessage. Textbox dsConnectionURL is missing constraints.validationMessage

If I had seen this output at the outset, I would have saved a bunch of
time.  I'm not sure why I don't see the output, but I don't think using
Write-Host is the correct choice.  Can you please make it so the error
explanations are written out?
Thanks,
Ed

@edburns - Not sure I follow, do you have a sample CUID file and a repro we can try?

@edburns are you still seeing this?

closing abandoned


Excluding jars

Is there a way to exclude certain lib jars? For example, I don't want to include the scala-library.jar since I am using this in a java only project. Also, I have a library that is needed for compilation only and not at runtime.

I found this not to word because of the unmatched parenthesis in front of the old: var. Below works for excluding scoverage when it is added to plugins.sbt.
'mappings in oneJar <<= (mappings in oneJar).map { depends: Seq[(File, String)] =>
depends.filterNot(_._1.getName == "scalac-scoverage-runtime_2.11-1.2.0.jar") }`
For declared dependancies in your build sbt you can append  % "test" like protobuffs and ScalaTest below
libraryDependencies ++= Seq(
"org.json4s" %% "json4s-native" % "3.4.1",
"org.scalaj" %% "scalaj-http" % "2.3.0",
"com.rabbitmq" % "amqp-client" % "3.6.5",
"com.google.protobuf" % "protobuf-java" % "3.1.0" % "test",
"org.scalatest" %% "scalatest" % "3.0.0" % "test")`


Should players get GC for testing maps?

When map manager sets a map for tests, GC, tops and some achievements disabled.
I think they should receive GC for finishing such maps.

GC yes TT no imo.

Tops definitely not but I don't see why achievements and GreenCoins are off, we get them for playing/winning so they should be enabled even while test if you ask me.

Maybe just give 1 GC as a good gesture? Combine it with a message like "Thank you for testing this map with us. Here's 1 GC!"

@JarnoVgr that made me laugh a bit :D

@JarnoVgr comment of the year goes to you, if that happens will we get GC payment for testing maps?

I personally think GCs shouldn't be disabled (Maybe half the reward), so if 1st players gets 16 GCs and 2nd gets 12 GCs. When testing 1st gets 8 GCs and 2nd gets 6 GCs..etc, but achievements and tops should be tho.


Only build docs on changes to docs folder

I figure it makes sense to only build docs when the docs folder change. I assume there is no out of docs folder inspection though, which there may be, then we should not merge this. For example, a script that inspects content in the folder to /docs.

Currently there is not any out-of-docs inspection (though there is cross-repository inspection that generates https://2i2c.org/pilot/infrastructure.html#a-list-of-current-hubs, but I don't think that's something we have control over in this repo)


Fixing LICENSE info in setup.py

Codecov Report

Merging #285 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   79.39%   79.39%
=======================================
  Files          34       34
  Lines        2252     2252
=======================================
  Hits         1788     1788
  Misses        464      464

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77b21e2...8983364. Read the comment docs.

Good catch, thanks! See minor comments.

Thanks!


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
67f3ce5 -> 616b101

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
minor
v1.35.4 -> v1.36.0

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.36.0
Compare Source
Features

simplify testprojects TearDown logic (#845) Simplified the logic around when resources or projects should get deleted during TestTearDown in the testprojects package, also added unit tests to verify all permutations. (380757f)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This issue has been resolved in version 3.29.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[AMBARI-23608] Unable to update credentials of a remotely registered cluster

What changes were proposed in this pull request?
STR

Register a remote cluster with Ambari server
Go to Admin - Remote Cluster page and select the cluster
Hit 'Update Credentials' and supply new/existing admin credentials of remote cluster
Hit Update

Result: Credentials are not updated and UI shows an error
How was this patch tested?
Tested manually on the real cluster

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1901/
Test PASSed.


gclient sync failed to sync the source for dart 3.0.7

Hi, I am trying to build dart using Arch Linux's PKGBUILD: https://gitlab.archlinux.org/archlinux/packaging/packages/dart/-/blob/main/PKGBUILD
It seems that the dart_style repo hosted on https://dart.googlesource.com/dart_style.git no longer contains the following revision (3470ab8451567dad237ddd54f992bfed066a2707), which leads to the following error:
________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress https://dart.googlesource.com/dart_style.git /build/dart/src/sdk/third_party/pkg/_gclient_dart_style_dd59jpev' in '/build/dart/src'

[0:00:52] Cloning into '/build/dart/src/sdk/third_party/pkg/_gclient_dart_style_dd59jpev'...
[0:00:53] remote: Counting objects: 1
[0:00:53] Receiving objects:   0% (1/10590)
[0:00:53] Receiving objects:  10% (1059/10590)
[0:00:53] remote: Total 10590 (delta 7304), reused 10590 (delta 7304)
[0:00:53] Receiving objects: 100% (10590/10590)
[0:00:53] Resolving deltas:   0% (0/7304)
[0:00:53] Resolving deltas:  10% (731/7304)
[0:00:53] Resolving deltas: 100% (7304/7304)
[0:00:54] error: RPC failed; HTTP 400 curl 22 The requested URL returned error: 400
[0:00:54] fatal: expected 'acknowledgments'
[0:00:56] error: RPC failed; HTTP 400 curl 22 The requested URL returned error: 400
[0:00:56] fatal: expected 'acknowledgments'
----------------------------------------
Error: Command 'git -c core.deltaBaseCacheLimit=2g fetch origin 3470ab8451567dad237ddd54f992bfed066a2707 --no-tags' returned non-zero exit status 128 in /build/dart/src/sdk/third_party/pkg/dart_style

Warnings:
Conflicting directory /build/dart/src/sdk/third_party/pkg/dart_style moved to /build/dart/src/_bad_scm/sdk/third_party/pkg/dart_style6t9g1lih.

This revision is from the DEPS file: https://github.com/dart-lang/sdk/blob/3.0.7/DEPS#L136 .
Does this revision got removed from dart_style repo by mistake? It makes the build of dart 3.0.7 unreproducible.
BTW there appears to be other issues with dart_style repo.
git clone shows a warning:
git clone https://dart.googlesource.com/dart_style.git
Cloning into 'dart_style'...
remote: Total 10590 (delta 7304), reused 10590 (delta 7304)
Receiving objects: 100% (10590/10590), 4.30 MiB | 18.40 MiB/s, done.
Resolving deltas: 100% (7304/7304), done.
warning: remote HEAD refers to nonexistent ref, unable to checkout

This might be a problem with google's server/cdn. I can reproduce it on a build server I am using, but I cannot reproduce it on my laptop.

This revision is still on github, but doesn't belong to any branch:
https://github.com/dart-lang/dart_style/tree/3470ab8451567dad237ddd54f992bfed066a2707


Ability to lock a service instance/factory

It should be possible to provide a fixed instance/factory for a service, ignoring the autodiscovery algorithm.
Possible resolution: Once a service is registered in the ambient services, prohibit the auto discovery.
Possible use: An app wants to disable service overrides (for security reasons)

The solution is to define a service with the highest override priority. This should, however, be set only in the end application, as there is no way of having it replaced.


Fixes https://github.com/apache/incubator-mxnet/issues/18575

Description
Fixes #18575
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

What's the status for this?

Not all cases are fixed just yet. Will reopen after fixing the rest of these tests.


Packaging

This fixes #26
@ilumsden Could you please try it and see if it works? Basically you need to checkout this branch and follow the "development installation" instruction here: https://github.com/neutrons/ipywe/tree/ae826157695f129684b081656f45200341aa5e60#installation to install and enable the ipywe widgets, and then start a jupyter notebook server and try out the test notebooks. It is probably best to do this in a fresh environment so the installation does not interfere with your other development environment.

I tried the development install, and it didn't work. I ran into an error on the second to last step. Here's the error message:
KeyError: 'The Python module ipywe is not a valid nbextension, it is missing the _jupyter_nbextension_paths() method.'
Let me know if you want the full traceback.

I'm actually not sure why this popped up. I just checked, and the _jupyter_nbextension_paths() method is in the init.py file in the ipywe directory.
Here's the full traceback:
Traceback (most recent call last):
File "/home/qil/miniconda2/envs/Ipywe/bin/jupyter-nbextension", line 6, in
sys.exit(notebook.nbextensions.main())
File "/home/qil/miniconda2/envs/Ipywe/lib/python2.7/site-packages/jupyter_core/application.py", line 267, in launch_instance
return super(JupyterApp, cls).launch_instance(argv=argv, **kwargs)
File "/home/qil/miniconda2/envs/Ipywe/lib/python2.7/site-packages/traitlets/config/application.py", line 658, in launch_instance
app.start()
File "/home/qil/miniconda2/envs/Ipywe/lib/python2.7/site-packages/notebook/nbextensions.py", line 900, in start
super(NBExtensionApp, self).start()
File "/home/qil/miniconda2/envs/Ipywe/lib/python2.7/site-packages/jupyter_core/application.py", line 256, in start
self.subapp.start()
File "/home/qil/miniconda2/envs/Ipywe/lib/python2.7/site-packages/notebook/nbextensions.py", line 678, in start
self.install_extensions()
File "/home/qil/miniconda2/envs/Ipywe/lib/python2.7/site-packages/notebook/nbextensions.py", line 657, in install_extensions
**kwargs
File "/home/qil/miniconda2/envs/Ipywe/lib/python2.7/site-packages/notebook/nbextensions.py", line 211, in install_nbextension_python
m, nbexts = _get_nbextension_metadata(module)
File "/home/qil/miniconda2/envs/Ipywe/lib/python2.7/site-packages/notebook/nbextensions.py", line 1037, in _get_nbextension_metadata
'it is missing the _jupyter_nbextension_paths() method.'.format(module))
KeyError: 'The Python module ipywe is not a valid nbextension, it is missing the _jupyter_nbextension_paths() method.'

Prior to this pull request being merged, if you are performing the development install, you must make sure you are on the packaging branch.