Immer

It might take a long time to reach a consensus in #2092 so after reading @mweststrate's intro to Immer I gave a shot at migrating the sample app just so we can see what that would look like.
Immediate benefits:

Immutable data without the need to use Immutable's custom data types
Essentially no learning curve
Removes over 50k from our builds
Trivial to remove for anyone who doesn't want it. We could even add it as an option in the generators.

Thoughts? Opinions?
NOTE: Tests will fail. This is a WIP until we can agree on a direction.

I guess I'm a bit confused as to why there's an immediate need to move away from Immutable if there doesn't seem to be a consensus on which direction we should head in?
I don't use any immutable library in any of my own projects so I can't say much-- I only have one opinion: I don't agree about the 'no learning curve' piece. The syntax of this library seems pretty different from immutable (i.e draft?) and for anyone that uses this boilerplate as a part of their daily development, that's going to be a big difference.
Mostly I just don't want to assume our users learning curve. Although this is a production-ready boilerplate, I know it's used for reference quite a bit and Immutable is a big part of this project, it changes the way someone learns/builds/thinks about a redux store. I have a soft spot for people who learn React development from this boilerplate (it really helped me back in the day) and experiencing Yet Another JS Library™ fatigue is real.
Every other bullet point I like and agree with tho 🎉
If I'm the minority here, I have no problem going with this solution. It's tough because we aren't gaining a whole lot of traction with RFCs and immutability is a huge topic 🤷♀

I didn't know there were RFCs—ping me Twitter when you have important RFCs and I'll share them with the wider React community? If there is one for Immutable.js, tweet it and I'll RT

It's #2092 but it may be better to start with a fresh one?

@gretzky If your main concern is the learning curve, maybe we should skip my next PR? I won't divulge what's in it but let's just say that it includes renaming the project to angular-boilerplate 😜😂
More seriously, I'm not trying to express a need to move to Immer, immediate or not. We can totally release 3.7 with Immutable and then any changes to store management can wait for a big 4.0 until we've had more time to discuss and agree.
At that time though, I would probably at least be suggesting a move away from Immutable.js. For several reasons that I'm happy to list (although I believe most of them have been discussed in #2092).
Btw, the main one is probably the huge learning curve associated with Immutable. IMO, a move to Immer would lower the overall learning curve of the project. (Take a quick look at the Immer intro and you'll see it has a tiny API.)
I also completely agree with you about this project being used as a reference and I also learned a TON from it. Seeing as the overall React community's consensus seems to be going towards seeing Immer as "the best way to do immutable state", perhaps "being a reference" means it would make sense for us to follow that trend. (Unless I'm not making sense?)
All that being said, I don't have a strong preference between Immer and another solution. @justingreenberg's suggestion of using redux-immutable-state-invariant to raise errors if data is mutated in dev is also a good one IMO (although it would be nice it we could find a maintained version).
In any case, I'm mostly trying to stimulate the discussion and as I said this can totally wait til the next version. :)
(Sorry I wrote so much!!)

Coverage remained the same at 100.0% when pulling 93fa592ef76f04f5092f4d694edc9f0096cf6d5e on immersion into 472b8aa7bd1b39d8b3f1383137218bcd4681e826 on dev.

Happy to merge this whenever appropriate

Happy to merge this whenever appropriate

@gretzky You're happy to switch to Immer? If so, I'll finish this branch soon.

@julienben yeah I'd say so-- I still don't use immutability but I see the value. Removing it would be a bigger task imo. Take your time!

@gretzky I believe this is ready for review!

All set!


Tracking precision parameters with upstream NOMAD for simple Si and C systems

nomad_stats.xlsx (table with comaprison of currently supported quantities):
https://1drv.ms/x/s!AvUyVgEwy7xOjkU109cqwQzIQEZA?e=iI2bgb

Few more details to get better table updates:

k_line_density is only relevant for periodic systems, i.e., atoms.periodic = [true, true, true], this means that FHI-aims for example should work (at least the few periodic calculations I found work)
planewave cutoff is only relevant for codes with basis set type = planewaves
apw cutoff is only relevant for codes with basis set type = (L)APW

Its surprising that the APW cutoff for exciting would work for main NOMAD and not for the local server, @SimonKratochvil  can you please point me to some such entry?

Entry I uploaded to local server where APW cutoff doesn't work: here


fix warning from using deprecated TSC URL

motivation: TSC URL is deprecated
changes: migrate the url scheme extraction code to the one call site that needs it

@swift-ci please smoke test


[WIP] Create gltf exporter

Reopened due to accidental branch deletion.
Need some CICD.
Alternative to https://github.com/godotengine/godot/pull/32218 that directly uses Godot's importer to write an exporter.
Features:
Export the scene to glTF2.
Updated 2020-01-25
Todo:

Blend shape animations are broken
Integrate new 4.0 apis
Robust compatibility with blender
Add lights
Fix blend shapes being exported incorrectly
Move from the the tools menu to an export menu. Use this new plugin interface to add an "export gltfs" option.

Done:

Fix alpha scissors
Support KHR_texture_transform https://github.com/KhronosGroup/glTF/tree/master/extensions/2.0/Khronos/KHR_texture_transform
Remove duplicate AnimationPlayer node
Remove duplicate Skeleton node
Ignored UV Scaling [Not part of the core gltf2 spec] https://github.com/KhronosGroup/glTF/tree/master/extensions/2.0/Khronos/KHR_texture_transform
Bone attachments Updated 2020-01-01 New Years!
Support GLB binary gltf exports
Support editor created animation properties
Remove extra node on roundtrip.
Meshes
CSG
Gridmap
Materials
Bone weights
Bones
Blendshapes
The root node is put under the new root node.
Cameras
Debugged skins and animation skeletons
More debugging of meshes
Material caching
Use node index instead of bone names to do child parent relationships
Support all meshes instead of just array meshes
Debugged crash with Gridmaps
Removed extra node under skeleton for the skeleton
Bone animations
Blend shape animations (2019-12-05)
Camera crashes (2019-12-06)

Special Thanks

@SubSage

Current questions:
@reduz
Round tripping Godot import and export adds nodes.
Need some advice on how to merge the 5-8 encode accessors types. The encode accessors code was mostly copy and paste.
How to add the exporter abstraction?
Another thing is creating the concept of an exporter that is lossy in the editor interface design. Like a menu?

Due to the requirement of requiring new import and export apis, this is definitely a 4.0 feature. It's back portable, but the pull request as it is currently will be changed.

Question: how does this treat GSG meshes? Does it collapse the tree into a single mesh before exporting?

@jabcross I suppose it takes the CSG geometry as-is, which means it will be exported as a single object. However, its triangulated geometry will make it difficult to edit by hand.

Is something happening with this or its still a draft ? :)

https://github.com/godot-extended-libraries/gltf is the current module in 3.2, I haven't touched this pr as much because I'm waiting on reduz to have time to define an api.

@fire thank you will take a look

This PR is blocked on a bug that that causes the second node to be in an improper place.
Also the export api described by Reduz needs to be implemented.

Could you also amend the commit message to be more explicit? "Import and export GLTF2." is misleading as it sounds like it's implementing glTF 2.0 import, which is already supported.
I'd suggest adding some details to the commit message's body to explain what the commit actually implements (it doesn't have to be as thorough as the PR description, just a few lines that tell a git log reader what to expect from that commit).

Thanks! Amazing work!

This also fixes the mesh name import, super nice. thanks!


Segmentation fault on db pull

Describe the bug
I've had no luck getting supabase set up for local development with an existing project.  All the containers start fine but I end up with a blank file migrations/20241229224617_remote_schema.sql file and a segmentation fault error.  I've tried db reset multiple times as well but with no luck.
To Reproduce
Steps to reproduce the behavior:

npx supabase init
npx supabase login
npx supabase link
npx supabase start
npx supabase db pull --linked

Expected behavior
New file in /migrations that contains the init script for the database.
Screenshots

System information

Ticket ID:<PHONE_NUMBER>37488bb89e4a8ba115ea6b
Version of OS: Windows 11
Version of CLI: 2.1.1
Version of Docker: 27.4.0
Versions of services:

SERVICE IMAGE
LOCAL
LINKED

supabase/postgres
<IP_ADDRESS>
<IP_ADDRESS>

supabase/gotrue
v2.167.0
v2.167.0

postgrest/postgrest
v12.2.3
v12.2.3

supabase/realtime
v2.33.58
-

supabase/storage-api
v1.14.4
v1.14.4

supabase/edge-runtime
v1.65.4
-

supabase/studio
20241202-71e5240
-

supabase/postgres-meta
v0.84.2
-

supabase/logflare
1.4.0
-

supabase/supavisor
1.1.56
-

This is a bit strange. Could you try the following command to help rule out potential issues with the postgres image
echo '<IP_ADDRESS>' > supabase/.temp/postgres-version
npx supabase db pull --linked

@sweatybridge Same issue still unfortunately.


Model Creation

Implemented according to the ERD diagram

Created a new app. The name is BlogValley
Initialized project with Git.
Made sure that my project has a Postgres database set up.
Built my project schema.

Created and run the necessary migration files.
Table and column names should match the ERD diagram.

note: photo for the users table should be a link to an image

Foreign keys included.
All columns that are foreign keys have a corresponding index.

Hi @rex-9
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not have a descriptive readme kindly use the microverse readme template
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


np-bootstrap hangs at confirm prompt

Current behavior

Are you using the latest available version?

Yes (development branch)

What is the problem?

np-bootstrap hangs at the confirm prompt when attempting to overwrite the MainNet chain:

(venv) $ np-bootstrap -m
This will overwrite any data currently in ~/.neopython/Chains/Main.
Type 'confirm' to continue
[confirm]>

Expected behavior

What should be happening?
You should be able to type confirm and continue the process.

How to reproduce

Please explain the steps to reproduce the problem. If you are having an issue with your machine or build tools, the issue belongs on another repository as that is outside of the scope of this project.
Just run np-bootstrap -m. Once the confirm prompt appears, the process hangs and accepts no more input until it is killed.

If you run np-bootstrap -m -s, it works fine since it skips the prompt, so it has something to do with the confirm prompt behavior.
Your environment
Let us know in what environment you're running into the issue:

OS: macOS 10.14.5
neo-python version: development branch (v0.8.5-dev)
Python version: 3.7.4

Thanks Brian, I know what the issue is and will resolve it before release. By keeping this issue open it will hopefully lead users here so I can give them the following warning
Warning
The latest available bootstrap files should not be used with the development branch. The database is not compatible.

do np-bootstrap -ms, -s is to skip confirm


add --unsloth to LLM CLI

Add the --unsloth CLI parameter for LLM fine tuning. Addresses #719.

this has been taken care of in the new release. please note that the preferred way is to use autotrain --config command instead of the cli.


Support a limited number of nodes per POST/PATCH request

Description
The idea here is to count the number of nodes during the production of the JSON.
Unfortunately, we have to hack the json NodeEncoder class even more to do this.
We save now a set of all nodes being fully expressed in the JSON.
If that number exceeds the accepted number nodes per request, we save randomly one node from the graph first.
After this presaving, we show this node only as UUID in the graph and try again.
Changes
It gets more complicated and hard to read.
Tests
We don't have a test for this yet.
https://trello.com/c/wWoz8l5l
Known Issues
It doesn't work yet currently because of this:
https://trello.com/c/kjNVBX40
Notes
Checklist

[x] My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
[x] I have updated the documentation to reflect my changes.

Yeah, so this doesn't work.
Waiting for clarification of the back end devs, on how to do this.

I don't think this will work.
Probably postpone until, @brili has an idea of save can be fixed.


【feat】hudi is need supported

We have been using hudi as a data lake.
Looking forward to supporting.

Hi, @zyclove
Thanks for your feed back.
Supporting hudi is a very useful feature for arctic and we are planning put it into our roadmap.
But It has a lot work to do in order to achieve this goal.
And we are very pleased to welcome you to join the discussing and designing for this feature.

Hi, @zyclove
Thanks for your feed back. Supporting hudi is a very useful feature for arctic and we are planning put it into our roadmap. But It has a lot work to do in order to achieve this goal. And we are very pleased to welcome you to join the discussing and designing for this feature.

目前比较难的是，hudi 没有想iceberg 保留catalog 扩展能力，社区还在讨论中，需要等很久

请问现在社区有进度吗？很希望可以列出方案和计划，一起共同搞起来。现在很多特性确实hudi支持的很不错，hudi线上使用公司也特别多，对Arctic这种元数据管理服务依赖也很强烈。能不能大佬们讨论讨论搞个计划呢？
Hudi vs Delta Lake vs Iceberg: https://www.onehouse.ai/blog/apache-hudi-vs-delta-lake-vs-apache-iceberg-lakehouse-feature-comparison
hudi很多特性我们一直在线上使用，很期待可以支持一下哦。
@zhoujinsong @melin @fantasyni @radiumce

@zyclove
Thanks a lot for bringing this feature up again!
I must admit that right now the Arctic community has no clear plan for Hudi's integration.
However, I think we can start discussing what value the Arctic can bring up to Hudi users after integration so that we can develop a more detailed integration plan later.
As far as I can see Arctic can bring the following values to Hudi users after integration：

Centered optimizing task scheduling for Hudi tables to improve resource usage and stability of table optimizing tasks
A web-based dashboard to show table information and metrics.

However, I would like to get more input from Hudi users about this question, so I would also like to hear your opinion.

目前hudi社区也已经有元数据管理服务，也提供接口，现在是不是对接管理开发也更容易了，能不能加快一下排期呢？

目前hudi社区也已经有元数据管理服务，也提供接口，现在是不是对接管理开发也更容易了，能不能加快一下排期呢？

We are very interested in integrating Hudi. Are you interested in driving this feature?

目前hudi社区也已经有元数据管理服务，也提供接口，现在是不是对接管理开发也更容易了，能不能加快一下排期呢？

As far as I know, Hudi has its own Compaction service. What additional capabilities do you expect Amoro to provide for Hudi?
Do you want visualized Compaction management?


Add optional password fields

Index page

[x] Title
[x] Name or e-mail
[x] Copy
[x] View
[x] Entry page (edit)
[x] haveibeenpwned
[x] New password

Entry page (edit/new):

[x] Title
[x] Name
[x] E-mail
[x] Password
[x] URL
[x] Backup code
[x] Notes

Backend:

[x] Add
[x] Edit
[x] Delete

Password view/edit in a new window.

done


fix(django): Fix complex either url patterns in Django

Resolves #874

Thanks, I think we actually need some matching that cannot be expressed by regex, i.e. actually match open/closing parens, but I think this is good enough.
Can you rebase to fix CI?

Thanks!


Browser language detection

The client should detect the browser language to choose the right translation file.

see #1723

fixed in #1732

done in #1732


Undo/redo history log

Godot version:
3.0, 3.1
OS/device including version:
all
Issue description:
As a UI component for the editor, I think a panel with a history log for all undoable steps is needed.
Why is it important?
To provide certainty for users what steps are undoable, which are not, how many steps users can go back and what is is exactly they are going back to. (or forward to in case of redo)
See example about the confusion about what it is undoable and what not here: (https://www.reddit.com/r/godot/comments/aqr5ja/voice_your_frustration_what_do_you_think_is_the/egili1u)

i'm personally not a fan of  an undo history component in the editor. however, if it's a toggleable setting, i think it'll help those specific developers. but theoretically, 99.99% of undoable actions should work correctly. if the developer runs into a specific undo issue, a separate issue  for it would most likely get it fixed ASAP. thus, eventually negating the issue

Yes, I would imagine it as a window panel you can open and close, move around on the screen and dock to other panels (see https://github.com/godotengine/godot/issues/25920)
Another benefit would be be able to click directly on the history state you want to go to instead of pressing Ctrl +Z a million times hoping not to miss it.
"What did I just do"? - a typical beginner situation, would also help the learning process.
Also this could help with the creation of macros, if we ever want that.

I would love to see this feature added.  Like Photoshop or Affinity designer, it really helps to see the undo history and being able to choose which action in the list is a nice bonus.  While the undo works pretty well in Godot, there are times where certain actions are not undo-able so maybe this would help or at least reveal them more verbosely.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!

Discussion on this issue moved over to https://github.com/godotengine/godot-proposals/issues/953


Fixed dep, errors, warnings, added NovelFactory

Ignore input.txt
There were some variable names that were reserved words in Python.
I added the NovelFactory and a way for each Novel subclass to identify themselves, scan the 'code' to see if they handle that novel, and to register themselves. New novel subclasses just have to register themselves to be used.

I still have a few bugs. I will create a new pull request


Cannot find moment library

Hello,
I have an issue integrating your library with npm like this in package.json :
"angular-material-datepicker": "unmade/am-date-picker"
I import the library in my project like this :
import 'angular-material-datepicker/dist/am-date-picker.min';
I already have moment library in my package.json.
And when i navigate on the page integrating am-date-picker, here the error i take when clicking on the generated input :
ReferenceError: moment is not defined
Do you know what could be the problem ?
Thanks,
Bruno

Hello Bruno!
I guess you are using TypeScript, aren't you? Unfortunately, I'm not familiar with this language.
This date picker uses moment.js library as a dependency, so make sure you have all dependencies install and imported. Maybe that could help.

Hi,
I'm using ES6 with babel and Webpack.
I have to include that plugin in my webpack configuration :
    new webpack.ProvidePlugin({
      moment: 'moment'
    }),

Everything's working now ;)
Bruno


chore: Fixes breaking change log with goreleaser

Description
Fixes breaking change log with goreleaser.
Generated test changlog: https://github.com/mongodb/atlas-sdk-go/blob/89fdc186ed4b2c1c1b3c95559bfab03d3f67a291/tools/releaser/breaking_changes/v20241113004.md
Link to any related issue(s): CLOUDP-281143
Type of change:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Required Checklist:

[x] I have signed the MongoDB CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added any necessary documentation (if appropriate)
[ ] I have run make fmt and formatted my code

Further comments

Script apart from printing breaking changes to file is also responsible in detection of major breaking change.
I asume that we did local tests covering this use case?

Script apart from printing breaking changes to file is also responsible in detection of major breaking change.
I asume that we did local tests covering this use case?

right. Detection of breaking changes is evaluated by whether BREAKING_CHANGES is empty or not, that logic has not been updated and tested for no breaking changes case as well.

Super nice work @maastha Good to merge as we going to see potential new SDK releases today!


Income statement false data

Hello.
Im querying data about Wells Fargo & Company (WFC), with yfinance.Ticker('wfc').financials I receive not right "Total Revenue" value, that shown in web page. Please help to find out why is that.
Thank you.

Would recommend taking a look at my pull request. Works fine for the income statement of WFC.
Cheers,
https://github.com/ranaroussi/yfinance/pull/776

I will check it up, thank you.
Cheers.

ppl help plz to buy a wells fargo card

Fixed in yfinance 0.2


Functional tests for Assign feature

Automate Functional tests for Assign feature

#412 PR  related to this issue

#412 Merged


Get ready for symmetric aggregates

This PR does 2 things:

Add a predicate to AggregateReduceFunctionsRule, cherry-picked from https://github.com/apache/calcite/commit/ecbafbfbd356955db08e363b71c03d8923e6fe98
Fix a bug in the UNKNOWN type to prevent the type from changing when toggling nullability. There is a PR to master for this as well, but since this is a somewhat more controversial feature, perhaps it would be better to include it in the Looker fork first.

Can you replace your commit 50d436e with ecbafbfbd356955db08e363b71c03d8923e6fe98. Or at least give it the same commit message.
In assertCanCast do you have from and to the wrong way round?
Add a JIRA case number to the message first of the commits that deals with UNKNOWN. Without that prefix it's easy to lose track of changes as they are cherry-picked between branches.
With those 3 changes I think we're good for a release.

I did cherry pick it but since it had a merge conflict due to the ImmutableBeans thing it has a different hash, but the commit message is the same now
It does seem a bit unintuitive but that's the way the arguments are ordered in SqlTypeUtil.canCastFrom
Done

I ran
./gradlew clean  check -x :redis:test  -x rat

and got
> Task :core:forbiddenApisTest FAILED
Forbidden method invocation: java.lang.String#format(java.lang.String,java.lang.Object[]) [Uses default locale]
  in org.apache.calcite.sql.type.SqlTypeUtilTest (SqlTypeUtilTest.java:253)
Forbidden method invocation: java.lang.String#format(java.lang.String,java.lang.Object[]) [Uses default locale]
  in org.apache.calcite.sql.type.SqlTypeUtilTest (SqlTypeUtilTest.java:257)
Scanned 884 class file(s) for forbidden API invocations (in 1.92s), 2 error(s).

You should pass in Locale.ROOT as the first parameter to format.

I fixed it.


Menu dropdown icon position/two icons

<Dropdown className="icon" item icon='caret down' text='Account'>
    <Dropdown.Menu>
        <Dropdown.Item></Dropdown.Item>
    </Dropdown.Menu>
</Dropdown>

With above code you cant set up a Dropdown, but you can't align icon left nor you can't have two icons like this:

Why? I'm using React, do I have to use Semantic UI (not react one) to achieve that?

Duplicate, see #1147 for workaround.

Thats not what I ask. I mean two icons on Dropdown text, not options. :/

<Dropdown text={<Icon name='user'/>File} />

do I have to use Semantic UI (not react one) to achieve that?

Note, you'll run into lots of issues trying to run SUI's jQuery plugins on top of React's virtual DOM.  They both will be making changes to the DOM and will get out of sync.  You should use one or the other.

is there any option other than using the text prop? that one is supposed to be a string, and using @layershifter's solution it works, but triggers a PropType validation warning.
/** The text displayed in the dropdown, usually for the active item. */
text: PropTypes.string,

It was wrong advice, use the trigger prop:
<Dropdown trigger={<Icon name='user'/>File} />

Thanks! it works like a charm


[core, hitbtc] introduced concept of clientOrderId and implemented in Hitbtc

@timmolter good question, but one I can't answer I'm afraid.  It's actually a nice feature, I wish more would support it.

clientOrderId - Unique identifier for Order as assigned by trader. Uniqueness must be guaranteed within a single trading day, including all active orders.
this looks like an unique feature for HitBTC - I personally find its week uniqueness constraint dangerous
are the any features which you cannot implement using the unique orderId generated by the exchange?
I personaly don't see any reason why this hitbtc specific feature should be present in a library which tries to unify access to many exchanges using a common API

@walec51 That's exactly why I asked. I cannot really justify adding that if only a very few or in this case one exchange has it.

I would propose to remove changes to the core module from this PR an do the following:
in HitbtcTradeService expose methods:
    @Override
    public String placeMarketOrder(MarketOrder marketOrder) throws IOException {
        return placeMarketOrder(marketOrder, null);
    }

    public String placeMarketOrder(MarketOrder marketOrder, String clientOrderId) throws IOException {
        //...
    }

this will allow you pass this id for this exchange without the need to use exchange DTOs for the order object

Ok, this change seems unpopular.  I'll try something else - more focused to the HitBTC exchange.

Thanks for the feedback everyone.  I've had another go, a less invasive Hitbtc-specific implementation https://github.com/knowm/XChange/pull/2566


make datadog cloudformation resources usable in cdk

I'm currently working on building L1 and partially L2 CDK constructs for https://github.com/DataDog/datadog-cloudformation-resources
Is this something you would be interested in including in this project? If so i could probably add the first steps towards this, otherwise i would publish it as a separate library.

Hi @webratz, sorry for the late reply and thanks for your contribution in advance! Do you have a WIP repo? I need to first have an internal conversation with the owner of https://github.com/DataDog/datadog-cloudformation-resources internally and see what they think. Maybe we can incorporate your contribution into this repo once it gains some usage and the datadog teams can commit to providing official support?

My progress on this has currently stalled as I'm working on other things.
But yeah, i agree it should be closely linked to https://github.com/DataDog/datadog-cloudformation-resources
If we can add directly a better spec to the DashBoard for example (eg generated from the openAPI spec) this would already be good enough for a start.
I use https://github.com/cdklabs/cdk-import to generate the L1 constructs from these definitions. Would be great of course if these were published directly by datadog

@webratz I will leave this issue open for an extended period of time to see if more people express interests. For now, there isn't anything on the roadmap.

Closing due to lack of activities.


Release to ROS buildfarm

Could this package be released to the ROS buildfarm? This would greatly simplify the package installation. Now this package has quite a a-typical setup with regards to all other ROS drivers. Which makes is a maintenance effort from our side.
(Please also take into consideration a marketing aspect, packages that are easy found in the ROS community are free publicity for your hardware).

@Nobleans - We have made the repositories public. Sorry for being slow but we had a significant update in work and wanted to get that done first. We agree with you that making this available on the ROS build farm is a great idea and would certainly appreciate the help.

↖ This was the face behind the @Nobleans messages.
Great news! And thank you for taking the effort.
Did you already try to follow the first tutorial to get the sdk released?

@Timple - No, we haven't tried to do the release yet. I'll try to find some cycles but not sure how quickly we'll get to it.

Hi, just a check-up. Did this end up on a backlog somewhere? :slightly_smiling_face:

Yes but it isn't a top priority for us right now. Sorry! FYI...feel free to reach out to your sales rep. Get sales excited and it's easier for me to free up resources. 😁

Would you mind if I tried to release it?

The merged tickets don't quite solve the issue. It still has some issues with include directories. Issue can be seen using the following Dockerfile:
`FROM ros:noetic
RUN mkdir -p ws/src
WORKDIR ws
RUN apt-get update -qq && apt-get install -qqy python3-catkin-tools python3-osrf-pycommon git
Install dependencies listed in the package.xml files manually (instead of rosdep) to speed up dockerfile
RUN apt-get update -qq && DEBIAN_FRONTEND=noninteractive apt-get install -qqy libpcl-dev libboost-all-dev ros--sensor-msgs ros--pcl-ros
RUN bash -c 'source /opt/ros//setup.bash && catkin init'
RUN git clone -b catkin-support https://github.com/nobleo/quanergy_client src/quanergy_client
RUN git clone -b fix/dependencies https://github.com/nobleo/quanergy_client_ros src/quanergy_client_ros
RUN bash -c 'source /opt/ros//setup.bash && catkin build'`

After the merge the problem of course also reproduces with this repos devel branch:
FROM ros:noetic
RUN mkdir -p ws/src
WORKDIR ws
RUN apt-get update -qq && apt-get install -qqy python3-catkin-tools python3-osrf-pycommon git
# Install dependencies listed in the package.xml files manually (instead of rosdep) to speed up dockerfile
RUN apt-get update -qq && DEBIAN_FRONTEND=noninteractive apt-get install -qqy libpcl-dev libboost-all-dev ros-*-sensor-msgs ros-*-pcl-ros

RUN git clone -b devel https://github.com/QuanergySystems/quanergy_client src/quanergy_client
RUN git clone -b devel https://github.com/QuanergySystems/quanergy_client_ros src/quanergy_client_ros
RUN bash -c 'source /opt/ros/*/setup.bash && catkin build'

@Timple https://github.com/QuanergySystems/quanergy_client/pull/27 fixes the build issue.

So it does, thanks!

PRs for quanergy_client:
https://github.com/ros/rosdistro/pull/30189
https://github.com/ros/rosdistro/pull/30190
I think everything there is ok. As far as I can tell, I've to wait on that to be completed to do quanergy_client_ros because of the dependency.

Awesome, you don't have to wait for the release to be completed though. The PR merged is enough to release quanergy_client_ros.

The quanergy_client can also already be released for the active ROS2 distributions foxy, galactic and rolling. As the library is ROS-independent.

https://github.com/ros/rosdistro/pull/30242
https://github.com/ros/rosdistro/pull/30243
I'll address ROS 2 stuff on that ticket.


Remove prelude imports

They cause conflicts with IntoIterator imports, and by removing the prelude
import instead of IntoIterator this enables continuing to work with 1.0.0-beta

Thanks!


3.8.0 the problem with the intelligence center

General information
Project issue is for:
3.8.0
Expected result:
transfer the crafted graphics card to the inventory.
Actual result:
it is not possible to transfer the crafted graphics card to the inventory. the process freezes and is interrupted after the end of time.
(Add a description of the issue here)
How to reproduce
1.start the process of making a graphic card in the intelligence center
2.take the finished graphic card from the intelligence center to the inventory
3.
Log files
Server: [2024-03-03T08:52:53.325Z] info: 	[Запрос Клиента] /client/game/profile/items/moving
[2024-03-03T08:52:53.332Z] error: 	TypeError: Cannot use 'in' operator to search for 'parentId' in 60391afc25aff57af81f7085
[2024-03-03T08:52:53.328Z] debug: 	event: HideoutTakeProduction
[2024-03-03T08:52:53.333Z] error: 	TypeError: Cannot use 'in' operator to search for 'parentId' in 60391afc25aff57af81f7085
[2024-03-03T08:52:53.334Z] error: 	TypeError: Cannot use 'in' operator to search for 'parentId' in 60391afc25aff57af81f7085
at InventoryHelper.getInventoryItemHash (C:\snapshot\project\src\helpers\InventoryHelper.ts:940:19)
at InventoryHelper.getItemSize (C:\snapshot\project\src\helpers\InventoryHelper.ts:723:70)
at InventoryHelper.canPlaceItemInContainer (C:\snapshot\project\src\helpers\InventoryHelper.ts:288:31)
at InventoryHelper.canPlaceItemsInInventory (C:\snapshot\project\src\helpers\InventoryHelper.ts:250:22)
at HideoutController.handleRecipe (C:\snapshot\project\src\controllers\HideoutController.ts:948:35)
at HideoutController.takeProduction (C:\snapshot\project\src\controllers\HideoutController.ts:765:18)
at HideoutCallbacks.takeProduction (C:\snapshot\project\src\callbacks\HideoutCallbacks.ts:148:39)
at HideoutItemEventRouter.handleItemEvent (C:\snapshot\project\src\routers\item_events\HideoutItemEventRouter.ts:62:46)
at ItemEventRouter.handleEvents (C:\snapshot\project\src\routers\ItemEventRouter.ts:42:29)
at ItemEventCallbacks.handleEvents (C:\snapshot\project\src\callbacks\ItemEventCallbacks.ts:26:52)
[2024-03-03T08:52:53.333Z] error: 	TypeError: Cannot use 'in' operator to search for 'parentId' in 60391afc25aff57af81f7085
at InventoryHelper.getInventoryItemHash (C:\snapshot\project\src\helpers\InventoryHelper.ts:940:19)
at InventoryHelper.getItemSize (C:\snapshot\project\src\helpers\InventoryHelper.ts:723:70)
at InventoryHelper.canPlaceItemInContainer (C:\snapshot\project\src\helpers\InventoryHelper.ts:288:31)
at InventoryHelper.canPlaceItemsInInventory (C:\snapshot\project\src\helpers\InventoryHelper.ts:250:22)
at HideoutController.handleRecipe (C:\snapshot\project\src\controllers\HideoutController.ts:948:35)
at HideoutController.takeProduction (C:\snapshot\project\src\controllers\HideoutController.ts:765:18)
at HideoutCallbacks.takeProduction (C:\snapshot\project\src\callbacks\HideoutCallbacks.ts:148:39)
at HideoutItemEventRouter.handleItemEvent (C:\snapshot\project\src\routers\item_events\HideoutItemEventRouter.ts:62:46)
at ItemEventRouter.handleEvents (C:\snapshot\project\src\routers\ItemEventRouter.ts:42:29)
at ItemEventCallbacks.handleEvents (C:\snapshot\project\src\callbacks\ItemEventCallbacks.ts:26:52)
BepinEx: (found in /BepinEx/LogOutput.log)
Client: (found in /Logs/log_<date>_<version>/<date>_<version> traces.log)
Profile
You can optionally include your game profile if you think it would help us reproduce the error easily (found in /user/profiles/xxxxxxxxxxxx.json)
The profile id can be found in the top left of the launcher.
Screenshots
(Optional, only add them if you think it adds value)
Notes - PLEASE READ!
DO NOT INCLUDE THIS SECTION IN THE REPORT

Do not include any of the text written in parentheses and italics in your report (example text - do not include me in the report!)
If you uploaded and attach the log files to the issue report, instead of using the codepaste, please remove the "Log Files" section as well.
If you use the codepaste site please make sure the paste has a sufficiently long lifespan set, 24hrs is often not enough.
You must be able to replicate the issue with a fresh profile, while running no mods.
If you are using a profile from an older version of SPT-AKI, then please make a fresh profile and replicate the issue like above prior.
You must upload all the required log files, even if you think they are useless.
Failure to comply with ANY of the requirements may result in your issue being closed without further investigation.

Originally written by Torm_Ozz

This was fixed in a recent zip update, the profile is broken and a new one will need to be created.

Originally written by chomp


[backport] Avoid importing NumPy docstring

This this a backport of #355.

jenkins, test this please

Closing, as we won't backport to v1 any more.


[Bug] Table Data Manager Edit Dialog buttons cut-off if the game screen name is too long

Just decided to try out a descriptive name following the naming convention from a torrent VPX packs as the game screen name, but noticed the buttons will be cut off if it's too long.
Game screen name example:
Big Trouble in Little China (Original 2022)(Balutito, TeamTuga)(1.8)[Source Table Wrath of Olympus JPSalas][PuP-Pack]

Fixed with 3.10.3


KQL syntax stopped working

 Environment data

Language Server version: 2021.6.2-pre.1
OS and version: linux x64
Python version (and distribution if applicable, e.g. Anaconda):
python.analysis.indexing: undefined
python.analysis.typeCheckingMode: off

 Expected behaviour
Can use %kql
 Actual behaviour
Pylance puts errors everywhere.

 Code Snippet / Additional information
%%kql RetainedByCohort <<
let cohortWindow = 7d;

FYI Installing https://marketplace.visualstudio.com/items?itemName=donjayamanne.kusto will give you code completions for KQL in Jupyter notebooks.

Thanks @DonJayamanne, I have it installed and am an avid fan.

@jakebailey Does this need to be transferred to vscode-jupyter? Sounds like the recommendation above of not marking these cells as python cells and passing them to the language server would be work on jupyter?

Yes, I'll transfer it for you.


multiple annotations into one event

I have a Brainvision data that for each 3 condition have four annotation markers. How can I combine these 4 annotations and categorize as one event, then be able to compare these 3 events? I am quite new to MNE, so if it does not make sense sorry

For questions about analysis and usage, please use the MNE Forum (https://mne.discourse.group). The GitHub issues are for bug tracking and feature requests.


selection overlay misaligned when element not a root

And parent is not in 0 @ 0

https://github.com/OpenSmock/Pyramid/pull/60


get_resource_kwargs should return kwargs passed

Describe the bug
    def get_resource_kwargs(self, request, *args, **kwargs):
        return {}

This block will remove any values currently present in kwargs, which means data is lost and it is not easy to override.
source
The correct implementation should be:
    def get_resource_kwargs(self, request, *args, **kwargs):
        return kwargs

There should be tests to prove this fix
Versions (please complete the following information):

Django Import Export: 3.3.6

@matthewhegarty Modify the return value of get_resource_kwargs and write a test for it? If that's what you want, I'll get on that asap.

Hi Rob - yes that is all that is needed (along with changelog update).  I would suggest this fix goes into the main branch and then we can port to release-4.

in case it matters I am sitting down to tackle this at this very moment, if you needed to assign anyone for records or anything along those lines.
@matthewhegarty

Thanks - feel free to assign it to yourself :+1:


Hello liuyuan, how to save mesh for nerf? Can I simply comment out the assertion?

this line:
if not isinstance(model.renderer, NeuSRenderer): return

Hi, I don't implement the code for mesh extraction on nerf. The key problem is that you need to specify a density threshold for mesh.

Hey, any chance you implemented the code for mesh extraction on nerf? NeRF is working much faster than NeUS.

楼主的效果看起来不错，准备做做导出mesh模型的工作吗？


Version gas scheduler variables

All on-chain governance modifiable parameters associated with the gas scheduler (i.e. GasCostPayForBlobs) should become versioned parameters i.e. they can only change with a hard fork upgrade.
The reason is to help clients who are submitting transactions make it easier to estimate the gas (as it won't fluctuate from block to block and you won't need additional queries for these values - they can be hardcoded into your estimator)
Context: https://github.com/celestiaorg/celestia-app/issues/3011#issuecomment-2071835562_

All on-chain governance modifiable parameters should become versioned parameters

Clarifying question: do you mean all params or just the params related to the gas scheduler?
I'm a fan of moving governance modifiable params to versioned constants. IMO this likely warrants a CIP b/c it's moving scope for modifying these params from token governance to the CIP process. I think this will be a relatively small code change but it will take time to get through the CIP process so I think it's unlikely to get finalized prior to our scheduled feature freeze on May 15th for v2.

Just related to the gas scheduler. I thought I had specified it but I must have missed it. Thanks for catching it.

The two params that are being considered:

auth.TxSizeCostPerByte
blob.GasPerBlobByte

Can we have this planned for v3? @evan-forbes

We would first need to write a CIP on this

For posterity:

CIP: https://github.com/celestiaorg/CIPs/blob/main/cips/cip-24.md
Implementation: https://github.com/celestiaorg/celestia-app/pull/3735


SDK client should automatically use clientId from the tokenParams or TokenDetails (RSA7b2)

I don't think ably-cocoa supports RSA7b2

(RSA7b) Auth#clientId is not null when:
(RSA7b2) Token authentication is being used, and the TokenRequest or TokenDetails object, used for authentication, has a clientId value that is not null

If I were to summarize: SDK client should automatically use clientId from the tokenParams or TokenDetails if clientId is set to null in clientOptions. I believe this is clearer.
┆Issue is synchronized with this Jira Story by Unito

We should then also check that it supports https://docs.ably.io/client-lib-development-guide/features/#RSA7b3. (This is the case that the client is provided with a token, which is implicitly bound to a clientId, but the token itself is opaque to the library; the library first learns about the clientId after having connected.

We do have automated tests for the RSA7* spec points, but they don't seem to be testing the value of Auth#clientId.

We do have automated tests for the RSA7* spec points, but they don't seem to be testing the value of Auth#clientId.

BTW feature points RSA7a2 and RSA7a3 are absent in the spec

Sorry, @maratal, my mistake. I linked to the tests for RSA7a* by accident. The relevant ones here are the ones for RSA7b*. At a glance, it looks like they're testing the right thing, you might need to look at https://github.com/ably/ably-asset-tracking-swift/issues/401 and run the failing tests mentioned there to investigate further.
But good catch re the extra tests. I created https://github.com/ably/ably-cocoa/issues/1507 for that.

This was finally solved here https://github.com/ably/ably-cocoa/pull/1517

@maratal I don't think that this was in #1517 – that PR was for enforcing RTP8j. I'm going to reopen this one. Can you please confirm whether or not there is any work we need to do on this?

I think that the current implementation
- (NSString *)clientId_nosync {
    if (_protocolClientId) {
        return _protocolClientId;
    }
    else if (self.tokenDetails && self.tokenDetails.clientId) {
        return self.tokenDetails.clientId;
    }
    else {
        return self.options.clientId;
    }
}

reflects specs better, than the one proposed by Ben, which implies to check for options.clientId first. And the phrase "Auth#clientId is not null when ... token authentication is being used, and the TokenRequest or TokenDetails object ... has a clientId value that is not null" doesn't mean that. @lawrence-forooghian

I agree that the current implementation looks mainly fine, @maratal. I don't understand the motivation for the original issue. Will close this.


[beta 17] ion-*-controller don't have async componentOnReady() method

Bug Report
Describe the Bug
In a clean Stencil project with just @ionic/core using any of the controller methods is not possible.
Example: <ion-loading-controller> when used as described in the docs/github https://github.com/ionic-team/ionic/tree/master/core/src/components/loading-controller#javascript does not wait at the componentOnReady call with await. Instead the code runs over it and tries to immedaitely call the create() function below.
Error:
Uncaught (in promise) TypeError: loadingController.create is not a function
    at AppHome.presentLoading (app-home.entry.js:12)

Steps to Reproduce
Clone repo at: https://github.com/bitflower/ionic-controller-bug
Related Code
    componentDidLoad() {
        this.presentLoading();
    }
    async presentLoading() {
        const loadingController = document.querySelector('ion-loading-controller');
        await loadingController.componentOnReady();
        const loadingElement = await loadingController.create({
            message: 'Please wait...',
            spinner: 'crescent',
            duration: 2000
        });
        return await loadingElement.present();
    }

Expected Behavior
Code stops at await and only continues after componentOnReady is finished.

Did you setup the build scripts yourself? This seems like it could be an issue with the source not transpiling to something like es6

Hi, no the repos was setup using npm init stencil. In step 2 I installed ionic and added it to global.ts. Then the code in the component.


[BUG] Hand ray and reticule are hidden when scrolling a scrollable from a disabled child interactable

Describe the bug
Hand ray and reticule are hidden when scrolling a scrollable from a disabled child interactable.
To reproduce
Steps to reproduce the behavior:

Open the scene Experimental/ScrollingExample
Unfold all children of the GameObject VerticalAndHortizontalScrolling
uncheck Is Interactable children called Action Button (x)
Press play and test with the hand simulator, see ray hidden when the scrolling starts with the ray on one of the disabled buttons
Build the and run on Hololens 2, see same thing

Expected behavior
Hand ray and reticule are always visible when scrolling in a scrollable.
Setup

Unity Version 2021.3.21f1
MRTK Version or Commit: main branch a09f5cd

Target platform (please complete the following information)

HoloLens 2
HP Reverb G2
OpenXR

@anonymous2585  can you provide a video of the failure?

Here is an Hololens video:
https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/assets/148471165/482c7c52-e613-4204-8b0d-fa0c555d86b5
At first, I clicked on a not interactable (IsInteractable = false) button, ray desappeared but movements are ok. Then I show it's ok with an activated button.
Here is a view in editor:

At first I clicked on a not interactable (IsInteractable = false) button, movements didn't work at all. Then I show it's ok with an activated button.

Hi @anonymous2585,
Thank you for reporting this issue or requesting this feature. We appreciate your feedback and interest in MRTK3.
We have reviewed your issue or feature request and confirmed that it is valid. We have added it to our backlog and will prioritize it accordingly.
However, if you would like to speed up the process and contribute to the MRTK3 project, you are welcome to submit a Pull Request with your proposed fix or implementation. We would be happy to review your code and merge it into the main branch if it meets our quality standards.
Please let us know if you have any questions or need any assistance. Thank you for your support and collaboration.
Best regards,
The MRTK3 team

@anonymous2585 , the problem here appear to the be that disabled interactor has its collider still enabled.  If you disable the collider, your scenario works.
Changing this to feature request to make "collider disablement easier on interactors".  I have a solution for this here:

https://github.com/AMollis/MixedRealityToolkit-Unity-AMollis-NEW/tree/user/amollis/auto-disable-button-collider-and-pressable-button-disable

I'll be making a PR soon-ish

Here's the PR:

https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/pull/626


Various improvements (task #7224)

Upgraded qobo/cakephp-utils to v8.*
Updated README file
Removed obsolete component dependency
Removed functionality handled by Footprint behavior
Set the table validation flag to false by default

Codecov Report

Merging #640 into master will decrease coverage by 0.26%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #640      +/-   ##
============================================
- Coverage     31.49%   31.22%   -0.27%
+ Complexity     1163     1160       -3
============================================
  Files           104      104
  Lines          3975     3958      -17
============================================
- Hits           1252     1236      -16
+ Misses         2723     2722       -1

Impacted Files
Coverage Δ
Complexity Δ

src/Controller/AppController.php
53.33% <ø> (-0.77%)
30 <0> (ø)

src/Controller/Api/V1/V0/AppController.php
50.6% <ø> (-0.6%)
33 <0> (ø)

src/Model/Table/ScheduledJobsTable.php
97.75% <100%> (+0.69%)
27 <0> (-3)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4eb486...d8f7c42. Read the comment docs.


ScottPlot.WinForms - target a single .NET Framework

Right now the ScottPlot.WinForms targets:

.NET Framework 4.6.1
.NET Framework 4.7.2
.NET Framework 4.8.0
.NET Core 3.0

https://github.com/swharden/ScottPlot/blob/b43efc0b4a0bef339ddcdb5a5314d1662dfc01dd/src/ScottPlot.WinForms/ScottPlot.WinForms.csproj#L4
Are all those .NET frameworks necessary? I can probably remove 4.7.2 and 4.8 as targets and just say "ScottPlot.WinForms supports .NET Framework >=4.6.1 and .NET Core >=3.0"

Actually, targeting .NET Framework 4.7.2 proved to be useful because the build folder only contains 3 DLLs (compared to over 100 when .NET Framework 4.6.1 was used). This makes it much easier to reference this project by DLL when not using a NuGet package.


Copying multiple Cells

I can't copy multiple cells as I do in SSMS after running a query and copying cells in the result pane. This is so annoying.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 811ed1f4-1c78-aa1b-e752-307250ca8eb7
Version Independent ID: f36629bf-b2e6-4993-7c77-32fa311ea942
Content: Download and install Azure Data Studio - Azure Data Studio
Content Source: docs/azure-data-studio/download-azure-data-studio.md
Product: azure-data-studio
Technology: azure-data-studio
GitHub Login: @yualan
Microsoft Alias: alayu

@krisrajzlive -- Raj, thank you for your feedback.  This repo is solely for documentation issues.  Please add your concern here:

SQL Server Feedback

I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.


Fix mapping of CSS URLs

Issue: CAP-1329
What Changed

When we need to rewrite an asset path, we're currently only updating the src attribute on DOM nodes. If an asset loaded from a CSS file or style attribute was rewritten, it will fail to load because the CSS will reference the old path when the snapshot is rendered.
This goes through the contents of style attributes and style elements and replaces any url references as needed.
There's still one empty box in the E2E Storybook due to a missing asset, but that's due to CAP-1194. I believe getting rid of the rrweb fork, which can be a follow up to this, will resolve that.
How to test

Run canary against some test projects
Check out Chromatic build

Change Type

[ ] maintenance
[ ] documentation
[x] patch
[ ] minor
[ ] major

📦 Published PR as canary version: 0.0.37--canary.33.f9c5b5b.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:rocket: PR was released in v0.0.37 :rocket:


events.js need to be changed as event.js

if not we need to invoke function as serverless webpack invoke --function get --path events.json

Good catch!


File names could be shortened a bit in casual stack traces when shown in IDEs

File names take up a lot of space in casual stack traces:
#0      doWork.<doWork_async_body> (file:///Users/johnmccutchan/workspace/stacktrace_demos/lib/recursive_timer.dart:5:5)
<asynchronous suspension>
#1      doWork (file:///Users/johnmccutchan/workspace/stacktrace_demos/lib/recursive_timer.dart)
#2      doWork.<doWork_async_body> (file:///Users/johnmccutchan/workspace/stacktrace_demos/lib/recursive_timer.dart:8:9)
<asynchronous suspension>
#3      doWork (file:///Users/johnmccutchan/workspace/stacktrace_demos/lib/recursive_timer.dart)

Would be great if we could shorten them a bit.

The Dart standard requires StackTrace.toString() to report function activations exactly: no omitted frames (e.g., from inlining), no synthetic frames, no obfuscation, and precise source locations. The base stack traces should not be lossy.

Sure, but surely that doesn't prevent us from post-processing it to make it more usable to the developer when used in a tooling context?

@mit-mit If the idea is to post-process with tooling, would you mind editing the issue title and/or applying the right labels for that? Thanks!

cc @devoncarew should this actually be in the tools tracker?

We do some work in the flutter framework to make traces more appealing, and may do as well in flutter_tools. If we move this issue over, it would be nice to first verify that traces aren't already post-processed.

@devoncarew can you please apply the right area tag for this? (it's not clear to me where this should land)

I'll move this to the flutter repo.

This issue was moved to flutter/flutter#19291


[Event Request] Codeunit::"Sales-Post Prepayments" - Function InsertExtendedText - OnBeforeInsertExtendedText

We like to request the following Event:
Object: Codeunit::"Sales-Post Prepayments"
Function: InsertExtendedText
Publisher Event: OnBeforeInsertExtendedText
Reason: To implement custom business logic
Where is the event placed:
local procedure InsertExtendedText(TabNo: Integer; DocNo: Code[20]; GLAccNo: Code[20]; DocDate: Date; LanguageCode: Code[10]; var PrevLineNo: Integer)
var
TempExtTextLine: Record "Extended Text Line" temporary;
SalesInvLine: Record "Sales Invoice Line";
SalesCrMemoLine: Record "Sales Cr.Memo Line";
TransferExtText: Codeunit "Transfer Extended Text";
NextLineNo: Integer;
begin
OnBeforeInsertExtendedText(TabNo, DocNo, GLAccNo, DocDate, LanguageCode, PrevLineNo);
TransferExtText.PrepmtGetAnyExtText(GLAccNo, TabNo, DocDate, LanguageCode, TempExtTextLine);
if TempExtTextLine.Find('-') then begin
Event Code:
[IntegrationEvent(false, false)]
local procedure OnBeforeInsertExtendedText(TabNo: Integer; DocNo: Code[20]; GLAccNo: Code[20]; DocDate: Date; LanguageCode: Code[10]; var PrevLineNo: Integer);
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Add &&^ and ||^ operators

They are often useful. Also, they are somewhat common because names are unambiguous.
(&&^) :: Monad m => m Bool -> m Bool -> m Bool
(||^) :: Monad m => m Bool -> m Bool -> m Bool

(&&^) : : monad m => m Bool -> m Bool -> m Bool
(||^) : : monad m => m Bool -> m Bool -> m Bool

Is this about using binding in a do notation and then getting the inner Bool values, applying the operator on it and then using pure again to return the final answer?
Or is there more to it?

@kahlil29 I think you can also use ifM function for that:
https://github.com/kowainik/relude/blob/7506ab5b54d559b6cef8a75eeecd46095e795cd7/src/Relude/Bool/Guard.hs#L57-L58

Thanks @ChShersh I'll have a crack at it, then I'll ask for some feedback 😄

Why have Monad here instead of Applicative?

@cronokirby You can't achieve the following behavior with Applicative:
ghci> Just False &&^ undefined
Just False

Monadic version is lazier.


Define props types

Description:

Required by linter otherwise returns a warning

Nice that could squeeze that in. :)


Not a valid WebSocket upgrade request crashes

Apologize if this is probably not the best place to raise my question.
We’ve recently experimented on using Bandit instead of Cowboy for our Websocket service built on Elixir. With just a small percentage of our traffic, we saw a lot of crashes saying “Not a valid WebSocket upgrade request”.  We followed the instructions for migration in https://hexdocs.pm/bandit/1.0.0-pre.1/Bandit.html.
Are there any other configuration which we should do? Is this possible that this issue has always been happening and Cowboy does not raise it but Bandit does?

Hey @mtrudel, thanks a lot for your prompt response:
To answer your questions:

We're using Phoenix and we do not have any non-standard socket configuration
This is the log I found which I believe they're related to the crahses:

07:44:32.443 [error] GenServer #PID<0.3352.0> terminating
** (stop) "Not a valid WebSocket upgrade request"
Last message: {:continue, :handle_connection}

We're using the phoenix-js npm package for our frontend apps. All connections are from users' browsers, the connection goes through a Cloudflare Load Balancer, then to our Google Cloud Load Balancer, and finally to our VMs. Only the traffic between our GC Load Balancer and our VMs is served on HTTP
We also saw these errors on Javascript frontend around the same time if it helps:

SecurityError
Failed to construct 'WebSocket': Access to address of 'websocket.example.com' is not allowed from 'public' address space.

SecurityError
Failed to construct 'WebSocket': Access to this address is not allowed.

It seems like we only saw this happening on a few users as I cannot reproduce the error on my side.

I've added improved logging for the upgrade failure reason in 1.0.0-pre.4 (just released). Give it a try @pvthuyen and see what comes out in the logs (the improved logging will appear in place where ** (stop) "Not a valid WebSocket upgrade request" appeared previously).

Thanks @mtrudel. All of the crashes now gives ** (exit) "WebSocket upgrade failed: error in upgrade_header check".

Interesting! 426 is certainly the wrong choice there (the semantics of 426 refer to the current protocol, not the desired protocol outlined in an Upgrade header); 400 continues to be the most reasonable choice, so in terms of response codes we're doing it right (at least IMHO).
In terms of crashing, there's a tricky balance here. If the client is indeed attempting to upgrade to a WebSocket connection then it's not a great idea to attempt to reuse the underlying TCP connection via keepalives, so closing the underlying connection is likely a good idea. We also want to notify via logging that an error occurred so we can debug issues (like this one!). That being said we can do a better job of doing this without crashing; I'll work up a better approach for the next release.
Regardless, it would seem that your upstream client is doing something wrong here (that, or we have a bug!). To diagnose this, you'll want to find out the header values that the broken client(s) are sending when attempting to upgrade, which is probably going to be difficult for you given that you've mentioned it's not reproducible. I'll make sure that the improvements I land in the next version capture this logging as well as possible. Stay tuned.

We're seeing a whole bunch of ** (exit) "WebSocket upgrade failed: error in upgrade_header check" errors as well (Bandit 1.0.0-pre.6). I don't know what to do about them, but they do clog up our error logs. If anybody knows how to deal with this, please let me know.

I've pushed improved logging for this to main and have released it as part of 1.0.0-pre.7. Give it a shot and let me know what the improved error messages are; this should help narrow down the culprit!

Now we're getting this:
** (exit) "WebSocket upgrade failed: error in upgrade_header check: \"Did not find upgrade in websocket\""

Ugh. I switched the needle and the haystack values in the logging output; those logs aren't helpful. Let me cut a new version. Sorry for the trouble.

Now we get this:
** (exit) "WebSocket upgrade failed: error in upgrade_header check: \"Did not find 'websocket' in ''\"")

🤔

There you go.
 Anything in your logs to suggest either?

This is a Phoenix/LiveView application. Websockets work fine, so I don't think it's a misconfiguration.
Some clients seem to do GET requests on /live/websocket indeeds. Among the user agents are some bots like bingbot or semrush bot, but also mobile safari or LINE. I don't know why the latter would make those requests. The app works fine in mobile safari as well, we only see these errors occasionally.
It seems like this is something outside of our control, so I don't think we need to handle this with exceptions that end up in Sentry. Do you think it would be better if bandit handles this silently?

Some clients seem to do GET requests on /live/websocket indeed. Among the user agents are some bots like bingbot or semrush bot, but also mobile safari or LINE. I don't know why the latter would make those requests. The app works fine in mobile safari as well, we only see these errors occasionally.

This is very much expected for normal WebSocket upgrade calls (after all, all WebSockets start as GETs). The problem is what happens when a client connects expecting a regular HTTP response, but the server mistakenly tries to upgrade the connection to a WebSocket. This is what you're seeing here.
This is happening because Phoenix/WebsockAdapter is pretty loosey-goosey with what it tries to upgrade (basically, it tries to upgrade any GET request to a designated socket endpoint, as codified here). What it should be doing is actually validating the clauses in the RFC6455§4.2.1 handshake before signalling an upgrade to the underlying server, because once such an upgrade is signalled there's no way for the user to express any control over what happens in the case of a failed upgrade. I think this behaviour belongs in WebSockAdapter so that anyone will be able to make use of it, not just Phoenix.
In light of this Bandit chooses to fail loudly (as you're seeing), in keeping with our stated goal of not codifying policy. Beyond this particular issue, this goal is proving to be a bit of a pain as it's exposing places where the Phoenix / Plug / Cowboy interface was leaking and nobody noticed since Cowboy's usual behaviour is to silently fail (examples #144, #106, #101). Thanks for bearing with the pain of helping to plug (ha!) all these leaky abstractions.
I'm going to close this issue and start on a PR to add the relevant improvements described above to WebSockAdapter. I'll keep this issue linked to those changes.
Thanks again for your patience and diagnostic work on this!


"make test_python" depends on "make install_c"

Which is not to say that "make test_python" yet exists, but if it did, it would depend on "make install_c".
It would be really nice if developing Python GRPC* didn't require root permissions at any point. Unfortunately it seems like all the standard development tools (distutils, virtualenv, and pip, at least for now) steer the developer toward requiring root access and installing system-wide any underlying libraries used by, but not statically linked into, the developer's Python C extension module.
Boo.
This may not be solvable within GRPC; this may only be solvable by enhancements to the tools themselves. It's worth at least investigating though.
*and perhaps all of GRPC, but let's leave that out of scope for this issue

Nicolas, is building a "test_python" make target still a worthwhile objective, or does the utility of run_tests.py obviate the use for such a target?
Should this issue just be closed?

(Of course the main complaint in the original report of this issue, "testing Python requires root privileges", has long since been fixed.)

There is no work remaining to do here that isn't separately tracked in #276.


Android example

New Android example is here https://github.com/veandco/go-sdl2-examples/tree/master/examples/android . Thanks to static libs now it is really simple to build apk.
User needs to import "C" to export "main" function, https://github.com/veandco/go-sdl2-examples/blob/master/examples/android/main.go#L182 , and is used then in Java https://github.com/veandco/go-sdl2-examples/blob/master/examples/android/android/src/main/java/com/example/android/MyGame.java#L16 . Perhaps that can be somehow solved, i.e. with some function like SetMain.

Great work @gen2brain!


Review Proposal

Two questions:

L118: Why must we prevent contributions of value 0?
I noticed we are skipping the withdraw fees and rewards tests. Why? Can we bring those back?

If the contribution = 0 then we emit a dummy contribution event, I didn't want this to happen. Alternatively, we could emit if contribution > 0. I thought it is cheap and makes sense to have the transaction fail when you don't contribute anything.

If the contribution = 0 then we emit a dummy contribution event, I didn't want this to happen. Alternatively, we could emit if contribution > 0. I thought it is cheap and makes sense to have the transaction fail when you don't contribute anything.


Add go vet to travis

Need to add vet to the makefile. Perhaps as the last step in make test-long?
test-long: clean fmt REBUILD
	go test -v -race -tags='testing debug' -timeout=300s $(pkgs) -run=$(run)
        go vet $(pkgs)

done

no, you still need it because the build won't fail

oh yeah, you can't just throw a go vet in travis, you have to wrap it in the test call

Discussed IRL: go vet actually returns an error code if it detects anything, so it'll fail without needing to run the test -z $(go vet ./...) line. So it's been removed from setup and just added to a part of make test-long


pass $injector into services

will make it more robust and less dependent on the order of params

done in a couple new services, now it needs to be done for all


Tool Usage Question

Hello,
I just want to crawl a website. I want the application to scan for vulnerabilities on the port I specified without doing a port scan. I just want it scanned for known vulnerabilities.
I created a command as follows. But the application still brute-forces the ssh port. How do I prevent it from brute-force?
scan4all -host http://scanme.nmap.org -p 80 -ep 22,3306 -stream -v

priorityNmap=false ./scan4all -host http://scanme.nmap.org -p 80 -ep 22,3306 -stream -v


[TextField] Multiline dynamically added text does not grow to the correct number of rows

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
TextField remains 1 line and throws warning in the console
Expected behavior 🤔
TextField expands to multiple lines to handle added text
Steps to reproduce 🕹
Example sandbox: https://codesandbox.io/s/invariant-example-h03uob
Context 🔦
I have a form that contains summary information text that can be pretty long. When editing an existing set of data, I load that long text into the form and the invariant warning prevents the TextField from expanding vertically to fit the text. I can work around this by using the various min/max rows props, but I want the TextField to expand vertically based on the length of the text, not show a scrollbar so setting a max row is not great, and having a min row takes up too much vertical space when there is shorter text.
Your environment 🌎
No response

[https://github.com/mui/material-ui/issues/32689#issuecomment-1121562484](Duplicate Issue)
Please check above Issue, already answered the question.
In multiline textbox you need to set rows prop.

I can't reproduce the error you reported in your codesandbox. It is behaving the same as you described in "expected behaviour. Please double check and let me know.

@hbjORbj
Try to enter too much text, then you will be able to see the issue

This is the issue, but if you add rows prop, you won't get that too many render error again

@PunitSoniME the rows prop solution is incomplete because it will either require specifying a large rows that looks bad UI wise when there is small text, or small rows that will cause the text to overflow with an ugly scrollbar. My use case is that the textfield expands to the correct number of rows automatically, but otherwise starts as 1 row.

@hbjORbj In Chrome 101 on Mac I get the following UI when loading the codesandbox and pressing the button:

Long text does not force the TextField to expand to multiple lines. Another re-render can force the TextField to a long size, but the initial button click produces that screenshot.


Introduced configuration support for Redis host and Redis port

Introduced the common Elixir way for configuring the hostname and portnumber for the Redis server.
Using :redis_host and :redis_port can be used and are set to the default values localhost and 6379, respectively.
Reason for this was executing the tests on a machine, where Redis is i.e. running in a non-local container.

I tend to be 👎 on this; if you want to connect to something other than localhost:6379, why not specify it explicitely in Redix.start_link(host: host, port: port)? You can build any abstraction you want on top of this, including relying on application config.
As far as tests goes, I can understand the need to run tests on a custom host/port, but I think a better solution may be in environment variables (for example, $REDIX_TEST_HOST and $REDIX_TEST_PORT). Wdyt?

The ENV proposal sounds good and I thought about it.  It is just another way, different to the default Elixir mechanism.

I argue this is the "default Elixir mechanism"; it's a possible mechanism and one I don't think applies very well here since the Redix application is pretty simple and straightforward, and I think changing defaults through application configuration is more magic than I'd like to introduce. Since this is just for running tests, I think env works pretty well. :)

Point taken ;). I will drop this pr and I'll fix the tests s.t. ENV variable are taken with default values localhost and 6379.
Ok?

Yes, that would be awesome :) Thanks so much!


testing: ods/jh-at-scale.sh: deploy from QE's OLM catalog in OSD

/test test-pr

/test ods-jh-at-scale

/override ci/prow/test-pr
... was the wrong command ...

/test ods-jh-at-scale

/test ods-jh-at-scale

/test ods-jh-at-scale

Test passed,  RHODS was deployed from QE's catalog (where we can control the version being installed) instead of RHODS addon.


Add Turnstile validation rule

Right now, the only way to use this package is through a middleware or manual method.
Implement the turnstile validation rule.

Fixed by #16


Not creating make file to compile on windows

I'm not getting the .dll because something's missing after cmake, I already have installed eigen, boost, MKL and referred them in variables, actually cmake is not flagging errors. Any ideas why this might be?

Not creating make file to compile on windows

Because you're using Visual Studio generator, there will be no Makefile and you can't do make.

Thanks, is there a way to generate that .dll from there?

Try to generate the project with BUILD_SHARED_LIBS=ON and use standard CMake instructions. Also, I'm not sure if it will help, I'm not an active user of this project.

Closing inactive discussion.


Accessing admin console gives 302

Hi,
I enabled the admin console and changed the auth token. When I try to access http(s)://domain/_sish/console?x-authorization=<> it gives me a 302 and redirects me here. Am I doing anything wrong?
Thanks!

Hmm, this is generally due to an auth code issue (i.e. it's not valid)

I crossed check the validity and it wasn't a problem. Following the console output:
2020/10/09 - 06:27:55 | Error retrieving keepalive response: EOF
2020/10/09 - 06:27:55 | Closed SSH connection for: <IP_ADDRESS>:51260 user: vidursatija
2020/10/09 - 06:27:58 | http: TLS handshake error from <IP_ADDRESS>:51288: cannot find connection for host: <domain>
2020/10/09 - 06:27:59 | http: TLS handshake error from <IP_ADDRESS>:51290: cannot find connection for host: <domain>
2020/10/09 - 06:27:59 | http: TLS handshake error from <IP_ADDRESS>:51292: tls: client offered only unsupported versions: [301]
2020/10/09 - 06:27:59 | http: TLS handshake error from <IP_ADDRESS>:51294: cannot find connection for host: <domain>
2020/10/09 - 06:27:59 | http: TLS handshake error from <IP_ADDRESS>:51296: cannot find connection for host: <domain>
2020/10/09 - 06:28:00 | http: TLS handshake error from <IP_ADDRESS>:51298: tls: client offered only unsupported versions: [301]


Introduce a new libvirt module for testing Salt: "salt_testenv"

What does this PR change?
This PR creates a new module for libvirt backend in sumaform that takes care of deploying machines and preparing a Salt testing environment, with all necessary test dependencies, in order to run the Saltstack "unit/integration/functional" tests.
Tracks: https://github.com/SUSE/spacewalk/issues/21165
Workflow

Salt Bundle is used to run the sumaform deployment for "salt_testenv" nodes. As some OSes don't have classic package available anymore.
Depending on the selected OS image, the classic Salt package and/or Salt Bundle will be deployed for the testing:

Classic Salt package (python3-salt + python3-salt-testsuite)

SLE15 family (all SPs)
openSUSE Leap

Salt Bundle package (venv-salt-minion + venv-salt-minion-testsuite)

SLE15 family (all SPs)
SLE12 family
openSUSE Leap
AlmaLinux 8/9
CentOS 7
Debian 9/10/11
Ubuntu 20.04 / 22.04

The different Salt flavors can be selected for testing (i.a "products", "products:testing" or "products:next"), by using the new salt_obs_flavor variable.
After deployment is done, pytest should be able to run the deployed tests.

Example of use
You can simply add salt_testenv nodes in your main.tf like this:
module "test-salt-sles15sp1" {
  source             = "./modules/libvirt/salt_testenv"
  base_configuration = module.base.configuration

  name               = "test-salt-sles15sp1"
  image              = "sles15sp1o"
  salt_obs_flavor    = "products:next"
}

module "test-salt-alma8" {
  source             = "./modules/libvirt/salt_testenv"
  base_configuration = module.base.configuration

  name               = "test-salt-alma8"
  image              = "almalinux8o"
  salt_obs_flavor    = "products:next"
}

IMPORTANT: At the time of creating this PR, since some of the necessary "testsuite" subprojects for the Salt Bundle are not yet fully ready at OBS, you might need to use salt_obs_flavor = "products:next" when deploying nodes that are going to use the Salt Bundle in order to prevent repository issues during deployment. As in the example above.
Running "pytest" inside the deployed VMs
Classic Salt:
# cd /usr/lib/python3.6/site-packages/salt-testsuite
# pytest -vvvv tests/unit tests/pytests/unit/ ...

Salt Bundle:
# cd /usr/lib/venv-salt-minion/lib/python3.10/site-packages/salt-testsuite/
# ../../../../bin/pytest -vvvv tests/unit tests/pytests/unit/ ...

Looking at the commit history, what's your plan @meaksh?


[Epic] Improving Support for Multi-Targeting in the Compiler

This is intended to be a list of required tasks, as well as a central issue for discussion on how to wean the compiler off of exact compilation targets. Items below are approximations of what needs to be done and can be updated/adjusted as needed.
### General
- [ ] #50
- [ ] #15295
- [ ] #15284
- [ ] #15286
- [ ] #15309
- [ ] Allow specifying a list of the explicit `hal.device.targets` explicitly, similar to the way `vk.target_env` can be specified as a command line argument.
- [ ] Allow `hal.dispatch.extern` to specify the minimum set of required features for an object rather than the exact target environment.
- [ ] Implement an `isSubsetOf` interface on `hal.device.target` and `hal.executable.target`

### General Codegen
- [ ] #15321
- [ ] Create `MaterializeExecutableVariantsPass` as a precursor to `TranslateExecutablesPass` that expands/contracts variants based on selected lowering strategies. This avoids excessive duplication of codegen work when the number of similar variants to compile for explodes.
- [ ] Nest the majority of the strategy specific code generation on functions. This allows setting translation info on the function rather than the export, enabling specialization and horizontal fusion.
- [ ] Allow multiple strategies per entry point and private function.
- [ ] Add an interface to `DispatchLoweringPipeline` strategies that specifies high level required, unneeded, and unknown capabilities/extensions/features to inform `MaterializeExecutableVariantsPass` how to create new variants.

### SPIR-V
- [ ] Allow specifying trinary (present, not present, unknown) state on capabilities and extensions. This could be achieved by using the `vk.target_env` as the target attribute and only do the conversion to the `spirv.target_env` when materializing the variant.
- [ ] Compile multiple SPIR-V modules per variant and implement a linking stage that connects functions with more relaxed feature requirements with stricter modules.
- [ ] Add support for specialization constants.

### CPU
- [ ] Materialize data tiling encodings per variant?

cc @benvanik @MaheshRavishankar @antiagainst @kuhar

This is a pseudo-clone of #50 :D


Docker support: minor cosmetic enhancements to Docker.md and mochidocker

Thanks!
I‘m so sorry for my very late response.


(dev) WIP: VPP-Agent update - Use GoVPP socket client instead of shmem client

testing, do not merge

Coverage remained the same at 76.189% when pulling fcf08cceeb832d92890fd0bba44031b705ae1f10 on rastislavszabo:dev into d3c36125b6abd0cf1b0b614c567f28a3801c8fbc on contiv:dev.


create copy of player in footer from listing of Audio instance

Unable to create two intance of player one in listing and another in bottom like soundcloud. I have go through  #1496 but it is not working.

the easiest solution is to create 2 instances of wavesurfer.
The other solutions involve things like using 1 fullscreen canvas to draw two waves, or using getImage and putImage to copy and paste from one canvas to another.
There's no easy way to share resources across 2 html5 canvases as far as I know


Add syntax color for 3sum-4sum code in Readme

Checklist

[x] I've looked at the contribution guidelines.
[x] This pull request is complete and ready for review.

Description
as title

👍


Disabled escaped characters in tokenizer

Fixes #726
Originally opened as #727, but that suffered from a botched git surgery from which it never recovered 💀
Checklist

[x] I have added tests

Sorry I had to re-open; lmk if I botched anything.  Also would be good to add a test including a Windows path so this doesn't break in the future

Looks good to me feel free to merge


⚠ AsianCinema has degraded performance

In 0ca656c, AsianCinema ($ACM) experienced degraded performance:

HTTP code: 200
Response time: 1254 ms

Resolved: AsianCinema performance has improved in 53ddb68 after 238 days, 19 hours, 57 minutes.


Question: Why are there so many copy constructor calls in my transform?

Consider the following (questionable) transform, that replaces + with -:
// custom expression
template <boost::yap::expr_kind Kind, typename Tuple>
struct my_expr
{
    inline static const boost::yap::expr_kind kind = Kind;
    Tuple elements;
};
BOOST_YAP_USER_BINARY_OPERATOR(plus, my_expr, my_expr)
BOOST_YAP_USER_BINARY_OPERATOR(minus, my_expr, my_expr)

// a transform for my custom expression
struct plus_to_minus_transform
{
    template <typename L, typename R>
    constexpr decltype(auto) operator()(boost::yap::expr_tag<boost::yap::expr_kind::plus>,
                                        L&& l, R&& r)
    {
        return boost::yap::make_expression<my_expr, boost::yap::expr_kind::minus>(
            boost::yap::transform(boost::yap::as_expr<my_expr>(std::forward<L>(l)), *this),
            boost::yap::transform(boost::yap::as_expr<my_expr>(std::forward<R>(r)), *this)
        );
    }
};

If I call
auto x = boost::yap::make_terminal<my_expr>(1.);
auto y = boost::yap::make_terminal<my_expr>(2.);
auto test = boost::yap::transform(x+y, plus_to_minus_transform{});

both terminals x and y get copied 5 times during the transform. Intuitively I would think, that no copies are neccessary: I construct new minus expressions that I would expect to reference the existing terminals x and y.
If I do the same for a sum of three terminals
auto x = boost::yap::make_terminal<my_expr>(1.);
auto y = boost::yap::make_terminal<my_expr>(2.);
auto y = boost::yap::make_terminal<my_expr>(3.);
auto test = boost::yap::transform(x+y+z, plus_to_minus_transform{});

I get a total of 28 copy-constructor calls.
Live Code Example
Here is a godbold example that traces the copy constructor calls.
Background
Replacing + with - is useless, my real use case is implementing a caching expression. My strategy is to wrap an expression in something derived from my_expr<boost::yap::expr_kind::if_else, SomeAppropriateHanaTuple> and store the cached evaluation result in an std::optional after the first evaluation. The if_else is used to check wether the cache has a value, retrieve the value if it does and evaluate the wrapped expression if it doesn't. I managed to implement this and it seems to work quite nicely.
Now I wanted to implement a transform that replaces any non-terminal expression with a cached version. Here I have performance issues and during debugging I noticed that I am creating a lot of copies.

Ok, I figured it out. It turns out that if I add a custom copy-constructor to my expression my_expr (I need one for my cached expression, and I used it in the example to std::cout something with each copy-ctor call), then there will be no implicitly defined non-trivial move constructor: https://en.cppreference.com/w/cpp/language/move_constructor
So in order to fix my example I need to write a custom move constructor, or explicitly add my_expr(my_expr&&) = default: Live Code
Sorry for bothering you with this here, it took me a while to spot this one 😅

Ok, I figured it out. It turns out that if I add a custom copy-constructor to my expression my_expr (I need one for my cached expression, and I used it in the example to std::cout something with each copy-ctor call), then there will be no implicitly defined non-trivial move constructor: https://en.cppreference.com/w/cpp/language/move_constructor
So in order to fix my example I need to write a custom move constructor, or explicitly add my_expr(my_expr&&) = default: Live Code
Sorry for bothering you with this here, it took me a while to spot this one 😅


WorkflowTask deserialisation initialise empty lists

Hello,
I noticed when deserialising WorkflowTask that all collections are initialised as empty collections even when the field in the json is absent. This is due to the fact that the empty constructor initialises them. This is present in all collections in the model.
It makes it impossible to differentiate the case when the json field is actually an empty array and the case when it is absent.
Do you know if there would be any impact if we remove these initialisations? Or do you have any other solution that could help for this issue?

@Stephane90 Do you have an example for when it would be useful to have null fields over empty fields? Having empty collections helps avoid null checks and we can infer there are no values if the list is empty anyways.


Unary and binary operators: find the proper overload by also checking the base classes

This is an attempt at fixing #135 . The gist is to try to find the proper user defined operator instead of solely relying on the Linq resolution (which doesn't check the base classes).
There were already some tests for user defined operators, I've added a use case to expand on it.

Released v2.4.1


Updates for Linerly's Website

Hi everyone!
This is the place throughout updates for my website, and also the things I'm working on for my website.
https://linerly.github.io/

...oops


[SuperEditor] - Add new Editor framework

For #748 we're replacing the DocumentEditor system with a new edit pipeline. At the center of that pipeline is a class called Editor, which essentially replaces DocumentEditor.
For this ticket, add Editor to the codebase without altering the existing system. We'll do this to get eyeballs on the core API without breaking anything.

When will the next version be updated? I find that there is now a big difference between the stable version and the main branch. The main branch has fixed some stable releases and is still updating, so I'm worried that when I'm coding from the last release, a new version will be released and I won't be able to fit in well.

@Dboy233 this ticket isn't the appropriate place to ask general questions about project releases or policies. If you're running into specific issues, please file a new ticket.


[docs] Add Badge TypeScript demo

[x] I have followed (at least) the PR section of the contributing guide.

@eps1lon do you know why it fails?

@vitkon It's a flaky test, I have rerun it.


New database created but not displayed

I have a connection on PostgreSQL. PostgreSQL-DB exists. I created one new database with a table and filled it with data. Then the program closed. After I restarted the program, the new DB was gone. Connection to PostgreSQL works. If I want to create a new one with this name, I become the message "Cannot create DB already exists ...". But I can't load or see them anywhere. The problem is reproducible.
Can you help me.

The system is a new iMac 27' 2020 Intel
I use postgres.app as postgresql

Hello @THE1960
Please check your connection settings with right click on your connection in the Database Navigator Tree.
The setting "Show all databases" must be enabled, if you want to see all your databases in one connection.

Good morning and wish you a good new year,
Thank you for the information. It works very well. I didn't know that I had to change these settings.
Freundliche Grüsse
Tobias Heise
Tobias Heise
Alte Torkelbergstr. 37	Mobile: +49<PHONE_NUMBER>9
78465 Konstanz		Mail: @.*** @.***>

Am 06.01.2022 um 07:36 schrieb Anastasiya @.***>:
Hello @THE1960 https://github.com/THE1960
Please check your connection settings with right click on your connection in the Database Navigator Tree.
The setting "Show all databases" must be enabled, if you want to see all your databases in one connection.
https://user-images.githubusercontent.com/45152336/148339586-a9b58684-f60f-48db-8175-d10387d0cfca.png
—
Reply to this email directly, view it on GitHub https://github.com/dbeaver/dbeaver/issues/15116#issuecomment-1006320666, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHHQA4JKHODSDHRJGKDWTQTUUUZ7NANCNFSM5LJ6TXPA.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.


Add a Script For Firefox

The Script doesn't work on Firefox and Firefox Quantum 58.0.

I ran the given script in Firefox 71.0 and it ran successfully for me. If you encountered some error please state what was it?

Its fixed now !!


Suggestion: use WebView for FaceTime

Instead of redirecting the user to chrome whenever a FaceTime call comes, Android System WebView should be used instead, as it is based on Chrome and allows for a full screen FaceTime experience on Android.

I think the reason we did it this way was so that you could stay in the call but still respond to texts and stuff

I think the reason we did it this way was so that you could stay in the call but still respond to texts and stuff

The WebView could be a separate activity with a big return to call button at the top like other services.

The real reason it was done this way is because the framework we use (Flutter) frankly has terrible support for web views and other platform native components. Handling permissions and even just webview performance is pretty poor. Using the built in browser just makes sure that the experience stays as good as possible even though the downside is it's not truly full screen.

The real reason it was done this way is because the framework we use (Flutter) frankly has terrible support for web views and other platform native components. Handling permissions and even just webview performance is pretty poor. Using the built in browser just makes sure that the experience stays as good as possible even though the downside is it's not truly full screen.

I see. I wanted this because I use Firefox, which for reasons unbeknownst to me, is not supported by FaceTime.

We have thought about this and it should forcefully open in chrome as long as you have it installed.

We have thought about this and it should forcefully open in Chrome as long as you have it installed.

I had Chrome disabled which is why it wasn't opening 😅.


"hello" is 0.62% English

As title says, even with TinyLD Heavy, the word "hello" is only 0.62% English...

Yes and this is by design, because it use a statical approach, it needs a certain amount of characters ~40 to work with. It cannot work with one or two word and never will be.
https://github.com/komodojp/tinyld/blob/develop/docs/faq.md#can-tinyld-identify-short-strings
I guess for the moment your best hope is that someone make some good AI for language detection.

I see. I figured you had compressed dictionaries of common words or some such... I will just do this myself. I need to determine language from just one word sometimes, as it's used to implement a language whitelist.


Internal Server Error

Describe the bug
When I submitted my code for a kata, it gave the error.
To Reproduce
def create_phone_number(n):
if len(n) != 10:
raise ValueError("List must contain exactly 10 numbers.")
numbers_str = ''.join(map(str, n))
formatted_phone_number = f"({numbers_str[:3]}) {numbers_str[3:6]}-{numbers_str[6:]}"
return formatted_phone_number
Expected behavior
I expected it to say "code submitted!" or something similar then take me to the discussions page.
Screenshots

Browser
I am on Chrome.
Additional context
This has not happened for any other Kata I have done, ever.

Duplicate of #3209


Why no dart compile exe ?

Strangely, dart AOT compilation is slower. Did I do something wrong in this Makefile?

Seems OK
iirc the product manager asked me to use exe as default instead of jit


[🐛 BUG]: Building with velox 1.1.3 fails with roadrunner v2.11.1 as reference

No duplicates 🥲.

[X] I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?
Trying to build roadrunner binary with velox 1.1.3 and roadrunner ref v2.11.1. Build fails with error of some type inconsistency.
Using the following velox.toml configuration for the build.
[velox]
build_args = [
    '-trimpath',
    '-ldflags',
    '-s -X github.com/roadrunner-server/roadrunner/v2/internal/meta.version=develop -X github.com/roadrunner-server/roadrunner/v2/internal/meta.buildTime=10:00:00']

[roadrunner]
ref = "v2.11.1"

[github]
    [github.token]
    token = "${RT_TOKEN}"

[log]
level = "debug"
mode = "development"

Version (rr --version)
2.11.1
Relevant log output
{"log": "# github.com/roadrunner-server/roadrunner/v2/internal/cli/workers\ninternal/cli/workers/render.go:33:17: cannot use workers[i].Pid (variable of type int64) as type int in argument to strconv.Itoa\ninternal/cli/workers/render.go:34:17: cannot use workers[i].Status (variable of type int64) as type string in argument to renderStatus\ninternal/cli/workers/render.go:35:26: workers[i].NumJobs undefined (type *process.State has no field or method NumJobs)\ninternal/cli/workers/render.go:58:17: cannot use workers[i].Pid (variable of type int64) as type int in argument to strconv.Itoa\n"

Hey @zdraganov 👋🏻
Could you please try to use the ref="release/v2.11.2" RR's branch? Unfortunately, I have to move some of the internals 😢 , thus the build fails.

Updated the ref in the velox.toml file and now get this error:
#22 0.121 2022-09-13T13:16:39.025Z      INFO    [GET ARCHIVE LINK]      {"owner": "roadrunner-server", "repository": "roadrunner", "encoding": "zip", "ref": "release/v2.11.2"}
#22 0.402 2022-09-13T13:16:39.305Z	INFO	[REQUESTING REPO]	{"url": "https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/refs/heads/release/v2.11.2"}
#22 0.402 2022-09-13T13:16:39.306Z	INFO	[FETCHING CONTENT]	{"url": "https://codeload.github.com/roadrunner-server/roadrunner/legacy.zip/refs/heads/release/v2.11.2"}
#22 0.899 2022-09-13T13:16:39.801Z	DEBUG	[FLUSHING DATA ON THE DISK]	{"path": "/tmp/roadrunner-server-release/v2.11.2.zip"}
#22 0.899 2022-09-13T13:16:39.802Z	FATAL	[DOWNLOAD TEMPLATE]	{"error": "open /tmp/roadrunner-server-release/v2.11.2.zip: no such file or directory"}

Just managed to make it working with this git tag - 343c5be

Good, sorry for the inconvenience. I'll release v2.11.2 on Thursday, so the problem should be gone.

The problem with the release/v2.11.2 branch is in the / in the branch name. It is recognized as a path, and I'll fix that.

@zdraganov, Could you please try to use Velox v1.1.4 with the branch name release/v2.11.2?

Yeah, looks like working with those versions! Great!


Close #1362 - fix newline when print to stdout/stderr

Closes https://github.com/allinurl/goaccess/issues/1362
Tested with ~10MB access.log file, and observed a newline added correctly:
$ goaccess access.log -o report.html --log-format COMBINED
Parsing...[58,556] [58,556/s]
$

Merged. Thank you for submitting this PR!


Storage - new 'putFile' method implementation breaks old code

Description
The new implementation of 'putFile' method, breaks old code.
If I pass StorageMetadata object with set up 'contentType' to this method, I get crash with error

FirebaseStorage/StorageUploadTask.swift:68: Fatal error: Internal error enqueueing a Storage task

because 'path' and 'name' won't be set for metadata object from parameters.
  open func putFile(from fileURL: URL,
                    metadata: StorageMetadata? = nil,
                    completion: ((_: StorageMetadata?, _: Error?) -> Void)?) -> StorageUploadTask {
    var putMetadata: StorageMetadata
    if metadata == nil {
      putMetadata = StorageMetadata()
      if let path = path.object {
        putMetadata.path = path
        putMetadata.name = (path as NSString).lastPathComponent as String
      }
    } else {
      putMetadata = metadata!
    }

'putData' method has different implementation and works well.
open func putData(_ uploadData: Data,
                    metadata: StorageMetadata? = nil,
                    completion: ((_: StorageMetadata?, _: Error?) -> Void)?) -> StorageUploadTask {
    let putMetadata = metadata ?? StorageMetadata()
    if let path = path.object {
      putMetadata.path = path
      putMetadata.name = (path as NSString).lastPathComponent as String
    }

Reproducing the issue
No response
Firebase SDK Version
10
Xcode Version
14.0.1
Installation Method
CocoaPods
Firebase Product(s)
Storage
Targeted Platforms
iOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved
No response
If using CocoaPods, the project's Podfile.lock
No response

@alexmomotiuk - thank you for looking into this issue and reporting it. I have merged the PR and the fix should be in the next release. In the meantime, if you initialize the metadata before passing it to the putFile function, you should be able to bypass the error.

@maneesht how do we fix this issue while we wait for the next release?

@jtressle don't pass metadata

@alexmomotiuk I require the metadata so I ended up using the putData method.  Hopefully, unit tests can catch this issue in the future.  It's an inconvenience to change code because of oversight.

@jtressle - if you fill the metadata with the proper path and name properties before you pass it to putFile, you shouldn't have any issues.
Please see https://github.com/firebase/firebase-ios-sdk/pull/10356/files#diff-8a6fda4f1d223479d5cafa7db5c6ca8f33220cbb93e59e0e3352c23eb8f7e4aeR215

@maneesht can you provide an example?
I'm getting the error Cannot assign to property: 'name' setter is inaccessible for both the metadata name and path.  This is how I'm setting the variables.  Ref is my document reference.
let metadata = StorageMetadata()   metadata.name = (ref.fullPath as NSString).lastPathComponent as String   metadata.path = ref.fullPath
Thanks.

@jtressle - I was mistaken. name and path are internal only. Please wait until the next release or roll back to a previous version. The next release should be out soon.

it is possible to make an NSMutableDictionary (alloc + init it), put a "name" entry in there that is the full path, then do initWithDictionary on the FIRStorageMetadata. The name gets copied to path and it all works. Of course that is internal stuff and a workaround and not supported and you accept responsibility etc ;-) just thought I would mention it

Thanks, @mikehardy!


Right-clicking open dropdown will cause next left click on dropdown to get eaten

Bug Report:
Module/Core: Core
Version: v0.7.0
Issue: When right clicking dropdowns (for whatever reason; maybe an accident), it will eat the next left click input.
(So rClick => lClick eaten => rClick => lClick normal => rClick => lClick eaten => rClick => lClick normal)

This is due to a debounce feature that prevents the dropdown from immediately reopening if there was a left click to close the menu while still hovering over the dropdown control.