[Android] Unable to run e4k on vs2017

When I use the e4k nuget package in vs2017, I am getting the following error:
In file included from F:\git\PV\library\HS\output\mono_embeddinator.h:32:0,
                   from F:\git\PV\library\HS\output\HIALibAndroid.h:10,
                   from F:\git\PV\library\HS\output\HIALibAndroid.c:7:
  F:\git\PV\library\HS\output\mono-support.h:187:26: fatal error: mono/jit/jit.h: No such file or directory
   #include <mono/jit/jit.h>
                            ^
  compilation terminated.

I saw a separate issue with this error, related to iOS. I attempted to run e4k from source but ran into the following error:
Unhandled Exception: System.IO.FileNotFoundException: Mono.Android, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=84e04ff9cfb79065
   at IKVM.Reflection.Universe.Load(String refname, Module requestingModule, Boolean throwOnError) in F:\git\e4k\Embeddinator-4000\external\ikvm\reflect\Universe.cs:line 756
   at IKVM.Reflection.Reader.ModuleReader.ResolveAssemblyRefImpl(Record& rec) in F:\git\e4k\Embeddinator-4000\external\ikvm\reflect\Reader\ModuleReader.cs:line 594
   at IKVM.Reflection.Reader.ModuleReader.ResolveAssemblyRef(Int32 index) in F:\git\e4k\Embeddinator-4000\external\ikvm\reflect\Reader\ModuleReader.cs:line 577
   at IKVM.Reflection.Reader.ModuleReader.ResolveType(Int32 metadataToken, IGenericContext context) in F:\git\e4k\Embeddinator-4000\external\ikvm\reflect\Reader\ModuleReader.cs:line 460
   at IKVM.Reflection.Reader.TypeDefImpl.get_BaseType() in F:\git\e4k\Embeddinator-4000\external\ikvm\reflect\Reader\TypeDefImpl.cs:line 59
   at IKVM.Reflection.Type.get_IsEnum() in F:\git\e4k\Embeddinator-4000\external\ikvm\reflect\Type.cs:line 1335
   at Embeddinator.Generators.ASTGenerator.Visit(TypeInfo typeInfo) in F:\git\e4k\Embeddinator-4000\binder\Generators\AstGenerator.cs:line 105
   at Embeddinator.Generators.ASTGenerator.Visit(Assembly assembly) in F:\git\e4k\Embeddinator-4000\binder\Generators\AstGenerator.cs:line 68
   at Embeddinator.Driver.Process() in F:\git\e4k\Embeddinator-4000\binder\Driver.cs:line 80
   at Embeddinator.Driver.Run() in F:\git\e4k\Embeddinator-4000\binder\Driver.cs:line 236
   at Embeddinator.CLI.Main(String[] args) in F:\git\e4k\Embeddinator-4000\binder\CLI.cs:line 215

Any thing I can try to get this to work?

Could you try using the version from master? There's a bunch of Windows fixes that are not in the Nuget yet.
And please post the command line arguments when posting these errors so we can have an idea which modes you're trying to use.
Can you explain the second error, I didn't understand if it's related to iOS or Android, and on which platforms. Is this still on Windows?

These are the steps I followed for the second error:

Cloned master and sub-modules with
git clone https://github.com/mono/Embeddinator-4000.git --recursive
Opened the solution in VS2017 and built the Embeddinator-4000 project
From the debug directory ran the following command:
Embeddinator-4000.exe f:\git\pv\library\HS\HIALib.Android\bin\Debug\HIALibAndroid.dll --gen=Java --platform=Android --outdir=generated -c

Hope this makes it a little clearer!

I see.
Can you try running ./build.ps1 -t Download-Xamarin-Android from Powershell?

New steps:

Fresh Clone of the repository
Ran the command above in PowerShell
Open solution in VS2017 and build
Running the command above in both PowerShell and CMD resulted in the same exception

F:\git\e4k2\Embeddinator-4000>build\lib\Debug\Embeddinator-4000.exe f:\git\pv\library\HS\HIALib.Android\bin\Debug\HIALibAndroid.dll --gen=Java --platform=Android --outdir=generated -c
Parsing assemblies...
    Parsed 'HIALibAndroid.dll'
Processing assemblies...

Unhandled Exception: System.IO.FileNotFoundException: Mono.Android, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=84e04ff9cfb79065
   at IKVM.Reflection.Universe.Load(String refname, Module requestingModule, Boolean throwOnError) in F:\git\e4k2\Embeddinator-4000\external\ikvm\reflect\Universe.cs:line 756
   at IKVM.Reflection.Reader.ModuleReader.ResolveAssemblyRefImpl(Record& rec) in F:\git\e4k2\Embeddinator-4000\external\ikvm\reflect\Reader\ModuleReader.cs:line 594
   at IKVM.Reflection.Reader.ModuleReader.ResolveAssemblyRef(Int32 index) in F:\git\e4k2\Embeddinator-4000\external\ikvm\reflect\Reader\ModuleReader.cs:line 577
   at IKVM.Reflection.Reader.ModuleReader.ResolveType(Int32 metadataToken, IGenericContext context) in F:\git\e4k2\Embeddinator-4000\external\ikvm\reflect\Reader\ModuleReader.cs:line 460
   at IKVM.Reflection.Reader.TypeDefImpl.get_BaseType() in F:\git\e4k2\Embeddinator-4000\external\ikvm\reflect\Reader\TypeDefImpl.cs:line 59
   at IKVM.Reflection.Type.get_IsEnum() in F:\git\e4k2\Embeddinator-4000\external\ikvm\reflect\Type.cs:line 1335
   at Embeddinator.Generators.ASTGenerator.Visit(TypeInfo typeInfo) in F:\git\e4k2\Embeddinator-4000\binder\Generators\AstGenerator.cs:line 105
   at Embeddinator.Generators.ASTGenerator.Visit(Assembly assembly) in F:\git\e4k2\Embeddinator-4000\binder\Generators\AstGenerator.cs:line 68
   at Embeddinator.Driver.Process() in F:\git\e4k2\Embeddinator-4000\binder\Driver.cs:line 80
   at Embeddinator.Driver.Run() in F:\git\e4k2\Embeddinator-4000\binder\Driver.cs:line 236
   at Embeddinator.CLI.Main(String[] args) in F:\git\e4k2\Embeddinator-4000\binder\CLI.cs:line 215

Hmm, do you have Xamarin.Android installed on your VS 2017 instance?

If you have this under VS, then it would be nice if you can help debug the issue.
We setup the Mono.Android.dll directory to the parser here: https://github.com/mono/Embeddinator-4000/blob/master/binder/Driver.cs#L62
Can you put a breakpoint in there and try to check the values returned by XamarinAndroid.TargetFrameworkDirectories?

I see a couple of things that appear to be happening:

In e4k external I don't have a Xamarin.Android, so the very first check fails.

Next in GetMonoDroidPath we check for the lib folder:

if (File.Exists(Combine(binPath, "lib")))
                return GetFullPath(MonoDroidSdk.BinPath);

This check always fails, because its checking for a File, but lib is a directory.

The Path from here is used to create targetFrameworks, which is looking for a folder called "xbuild-frameworks" which I can't find anywhere in my Xamarin install.

These are the versions of Xamarin and its components I have installed:

Xamarin   <IP_ADDRESS>9 (b63523e27)
Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.
Xamarin.Android SDK   <IP_ADDRESS> (2851083)
Xamarin.Android Reference Assemblies and MSBuild support.
Xamarin.iOS and Xamarin.Mac SDK   <IP_ADDRESS> (80b8487)
Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support.

FWIW, here is the output when I use the 0.3.0 nuget package.

"F:\git\PV\library\HS\packages\Embeddinator-4<IP_ADDRESS>\tools\Embeddinator-4000.exe" "F:\git\PV\library\HS\HIALib.Android\bin\Debug\HIALibAndroid.dll" --gen=Java --platform=Android --outdir=%E4K_OUTPUT% -c
1>  Parsing assemblies...
1>      Parsed 'HIALibAndroid.dll'
1>  Processing assemblies...
1>  Generating binding code...
1>      Generated: HIALibAndroid.h
1>      Generated: HIALibAndroid.c
1>      Generated: Mono.Android.h
1>      Generated: Mono.Android.c
1>      Generated: Java.Interop.h
1>      Generated: Java.Interop.c
1>      Generated: mscorlib.h
1>      Generated: mscorlib.c
1>      Generated: c-support.c
1>      Generated: c-support.h
1>      Generated: embeddinator.h
1>      Generated: glib.c
1>      Generated: glib.h
1>      Generated: mono-support.c
1>      Generated: mono-support.h
1>      Generated: mono_embeddinator.c
1>      Generated: mono_embeddinator.h
1>  Compiling binding code...
1>          In file included from F:\git\PV\library\HS\output\mono_embeddinator.h:32:0,
1>                   from F:\git\PV\library\HS\output\HIALibAndroid.h:10,
1>                   from F:\git\PV\library\HS\output\HIALibAndroid.c:7:
1>  F:\git\PV\library\HS\output\mono-support.h:187:26: fatal error: mono/jit/jit.h: No such file or directory
1>   #include <mono/jit/jit.h>
1>                            ^
1>  compilation terminated.

Can you paste the output with -verbose flag?

1>  "F:\git\PV\library\HS\packages\Embeddinator-4<IP_ADDRESS>\tools\Embeddinator-4000.exe" "F:\git\PV\library\HS\HIALib.Android\bin\Debug\HIALibAndroid.dll" --gen=Java --platform=Android --outdir=%E4K_OUTPUT% -c -verbose
1>  Parsing assemblies...
1>        Key HKCU\SOFTWARE\Novell\Mono for Android\AndroidSdkDirectory found:
1>      Path contains adb in \platform-tools (F:\Android).
1>        Key HKCU\SOFTWARE\Novell\Mono for Android\AndroidNdkDirectory found:
1>      Path contains ndk-stack in . (C:\ProgramData\Microsoft\AndroidNDK\android-ndk-r10e).
1>        Key HKCU\SOFTWARE\Novell\Mono for Android\JavaSdkDirectory found:
1>      Path contains jarsigner.exe in \bin (C:\Program Files\Java\jdk1.8.0_112).
1>      Found Android SDK. API levels: 21
1>      Parsed 'HIALibAndroid.dll'
1>  Processing assemblies...
1>      Pass 'Embeddinator.CheckReservedKeywords'
1>      Pass 'Embeddinator.Passes.GenerateObjectTypesPass'
1>      Pass 'Embeddinator.Passes.GenerateArrayTypes'
1>      Pass 'CppSharp.Passes.CheckIgnoredDeclsPass'
1>          Function 'new' was ignored due to ignored return decl
1>          Function 'CreateHearAidController' was ignored due to ignored param
1>          Function 'new' was ignored due to ignored return decl
1>          Function 'Java.Interop.IJavaObjectEx.get_KeyHandle' was ignored due to ignored return decl
1>          Function 'Java.Interop.IJavaObjectEx.set_KeyHandle' was ignored due to ignored param
1>          Function 'Java.Interop.IJavaObjectEx.set_IsProxy' was ignored due to ignored param
1>          Function 'Java.Interop.IJavaObjectEx.set_NeedsActivation' was ignored due to ignored param
1>          Function 'Java.Interop.IJavaObjectEx.ToLocalJniHandle' was ignored due to ignored return decl
1>          Function 'get_PeerReference' was ignored due to ignored return decl
1>          Function 'get_JniPeerMembers' was ignored due to ignored return decl
1>          Function 'get_Handle' was ignored due to ignored return decl
1>          Function 'Java.Interop.IJavaPeerable.get_JniManagedPeerState' was ignored due to ignored return decl
1>          Function 'Java.Interop.IJavaPeerable.SetJniIdentityHashCode' was ignored due to ignored param
1>          Function 'Java.Interop.IJavaPeerable.SetJniManagedPeerState' was ignored due to ignored param
1>          Function 'Java.Interop.IJavaPeerable.SetPeerReference' was ignored due to ignored param
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Explicit' was ignored due to ignored param
1>          Function 'op_Explicit' was ignored due to ignored param
1>          Function 'op_Explicit' was ignored due to ignored param
1>          Function 'op_Explicit' was ignored due to ignored param
1>          Function 'op_Explicit' was ignored due to ignored param
1>          Function 'op_Explicit' was ignored due to ignored param
1>          Function 'op_Explicit' was ignored due to ignored param
1>          Function 'op_Explicit' was ignored due to ignored param
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Implicit' was ignored due to ignored return decl
1>          Function 'op_Explicit' was ignored due to ignored return decl
1>          Function 'op_Explicit' was ignored due to ignored param
1>          Function 'op_Explicit' was ignored due to ignored param
1>          Function 'op_Explicit' was ignored due to ignored param
1>          Function 'op_Explicit' was ignored due to ignored param
1>          Function 'op_Explicit' was ignored due to ignored param
1>          Function 'op_Explicit' was ignored due to ignored param
1>          Function 'op_Explicit' was ignored due to ignored param
1>          Function 'op_Explicit' was ignored due to ignored param
1>          Function 'get_Class' was ignored due to ignored return decl
1>          Function 'Equals' was ignored due to ignored param
1>          Function 'Wait' was ignored due to ignored param
1>          Function 'Wait' was ignored due to ignored param
1>          Function 'get_Handle' was ignored due to ignored return decl
1>          Property 'Handle' was ignored due to ignored decl
1>          Function 'get_KeyHandle' was ignored due to ignored return decl
1>          Function 'set_KeyHandle' was ignored due to ignored param
1>          Function 'set_IsProxy' was ignored due to ignored param
1>          Function 'set_NeedsActivation' was ignored due to ignored param
1>          Function 'ToLocalJniHandle' was ignored due to ignored return decl
1>          Property 'KeyHandle' was ignored due to ignored decl
1>          Property 'IsProxy' was ignored due to ignored decl
1>          Property 'NeedsActivation' was ignored due to ignored decl
1>          Function 'SetJniIdentityHashCode' was ignored due to ignored param
1>          Function 'get_PeerReference' was ignored due to ignored return decl
1>          Function 'SetPeerReference' was ignored due to ignored param
1>          Function 'get_JniPeerMembers' was ignored due to ignored return decl
1>          Function 'get_JniManagedPeerState' was ignored due to ignored return decl
1>          Function 'SetJniManagedPeerState' was ignored due to ignored param
1>          Property 'JniIdentityHashCode' was ignored due to ignored decl
1>          Property 'PeerReference' was ignored due to ignored decl
1>          Property 'JniPeerMembers' was ignored due to ignored decl
1>          Property 'JniManagedPeerState' was ignored due to ignored decl
1>          Property 'Java.Interop.IJavaObjectEx.KeyHandle' was ignored due to ignored decl
1>          Property 'Java.Interop.IJavaObjectEx.IsProxy' was ignored due to ignored decl
1>          Property 'Java.Interop.IJavaObjectEx.NeedsActivation' was ignored due to ignored decl
1>          Property 'JniIdentityHashCode' was ignored due to ignored decl
1>          Property 'PeerReference' was ignored due to ignored decl
1>          Property 'JniPeerMembers' was ignored due to ignored decl
1>          Property 'Handle' was ignored due to ignored decl
1>          Property 'ThresholdClass' was ignored due to ignored decl
1>          Property 'ThresholdType' was ignored due to ignored decl
1>          Property 'Java.Interop.IJavaPeerable.JniManagedPeerState' was ignored due to ignored decl
1>          Property 'class_ref' was ignored due to ignored decl
1>          Property 'Class' was ignored due to ignored decl
1>      Pass 'Embeddinator.Passes.RenameDuplicatedDeclsPass'
1>          Renamed method Java_Lang_Object_op_Implicit_1
1>          Renamed method Java_Lang_Object_op_Implicit_2
1>          Renamed method Java_Lang_Object_op_Implicit_3
1>          Renamed method Java_Lang_Object_op_Implicit_4
1>          Renamed method Java_Lang_Object_op_Implicit_5
1>          Renamed method Java_Lang_Object_op_Implicit_6
1>          Renamed method Java_Lang_Object_op_Implicit_7
1>          Renamed method Java_Lang_Object_op_Implicit_8
1>          Renamed method Java_Lang_Object_op_Implicit_9
1>          Renamed method Java_Lang_Object_op_Implicit_10
1>          Renamed method Java_Lang_Object_op_Implicit_11
1>          Renamed method Java_Lang_Object_op_Implicit_12
1>          Renamed method Java_Lang_Object_op_Implicit_13
1>          Renamed method Java_Lang_Object_op_Implicit_14
1>          Renamed method Java_Lang_Object_op_Implicit_15
1>          Renamed method Java_Lang_Object_op_Implicit_16
1>          Renamed method Java_Lang_Object_op_Explicit_1
1>          Renamed method Java_Lang_Object_op_Explicit_2
1>          Renamed method Java_Lang_Object_op_Explicit_3
1>          Renamed method Java_Lang_Object_op_Explicit_4
1>          Renamed method Java_Lang_Object_op_Explicit_5
1>          Renamed method Java_Lang_Object_op_Explicit_6
1>          Renamed method Java_Lang_Object_op_Explicit_7
1>          Renamed method Java_Lang_Object_op_Explicit_8
1>          Renamed method Java_Lang_Object_op_Explicit_9
1>          Renamed method Java_Lang_Object_op_Explicit_10
1>          Renamed method Java_Lang_Object_op_Explicit_11
1>          Renamed method Java_Lang_Object_op_Explicit_12
1>          Renamed method Java_Lang_Object_op_Explicit_13
1>          Renamed method Java_Lang_Object_op_Explicit_14
1>          Renamed method Java_Lang_Object_op_Explicit_15
1>          Renamed method Java_Lang_Object_op_Explicit_16
1>          Renamed method Java_Lang_Object_Wait_1
1>          Renamed method Java_Lang_Object_Wait_2
1>      Pass 'CppSharp.Passes.CheckDuplicatedNamesPass'
1>      Pass 'Embeddinator.Passes.FieldToGetterSetterPropertyPass'
1>          Getter/setter property created from field HIALibAndroid_String_ApplicationName
1>          Getter/setter property created from field HIALibAndroid_String_Hello
1>      Pass 'Embeddinator.Passes.FixMethodParametersPass'
1>      Pass 'Embeddinator.CheckReservedKeywords'
1>  Generating binding code...
1>      Generated: HIALibAndroid.h
1>      Generated: HIALibAndroid.c
1>      Generated: Mono.Android.h
1>      Generated: Mono.Android.c
1>      Generated: Java.Interop.h
1>      Generated: Java.Interop.c
1>      Generated: mscorlib.h
1>      Generated: mscorlib.c
1>      Generated: c-support.c
1>      Generated: c-support.h
1>      Generated: embeddinator.h
1>      Generated: glib.c
1>      Generated: glib.h
1>      Generated: mono-support.c
1>      Generated: mono-support.h
1>      Generated: mono_embeddinator.c
1>      Generated: mono_embeddinator.h
1>  Compiling binding code...
1>      Invoking: C:\ProgramData\Microsoft\AndroidNDK\android-ndk-r10e\toolchains\arm-linux-androideabi-4.8\prebuilt\windows\bin\arm-linux-androideabi-gcc.exe --sysroot="C:\ProgramData\Microsoft\AndroidNDK\android-ndk-r10e\platforms\android-21\arch-arm" -fdiagnostics-color -DMONO_EMBEDDINATOR_DLL_EXPORT -I"C:\Program Files (x86)\Mono\include\mono-2.0" -L"F:\git\PV\library\HS\packages\Embeddinator-4<IP_ADDRESS>\external\Xamarin.Android\lib\xbuild\Xamarin\Android\lib\armeabi" -lmonosgen-2.0 -lmono-android.release F:\git\PV\library\HS\output\HIALibAndroid.c F:\git\PV\library\HS\output\Mono.Android.c F:\git\PV\library\HS\output\Java.Interop.c F:\git\PV\library\HS\output\mscorlib.c F:\git\PV\library\HS\output\c-support.c F:\git\PV\library\HS\output\glib.c F:\git\PV\library\HS\output\mono-support.c F:\git\PV\library\HS\output\mono_embeddinator.c --std=c99 -shared -o F:\git\PV\library\HS\output\android\jni\armeabi\libHIALibAndroid.so
1>          In file included from F:\git\PV\library\HS\output\mono_embeddinator.h:32:0,
1>                   from F:\git\PV\library\HS\output\HIALibAndroid.h:10,
1>                   from F:\git\PV\library\HS\output\HIALibAndroid.c:7:
1>  F:\git\PV\library\HS\output\mono-support.h:187:26: fatal error: mono/jit/jit.h: No such file or directory
1>   #include <mono/jit/jit.h>
1>                            ^
1>  compilation terminated.

Do you have this folder C:\Program Files (x86)\Mono\include\mono-2.0?
If not, you might need to install the Mono SDK for Windows

I don't have it, I assume I have to install the 32-bit version?

Yeah 32 bit, I tried to see if there was a way to get by without installing Mono, but Xamarin.Android doesn't ship the Mono headers (b/c they don't need them).

Yup, that fixed it! Could we add it to the documentation perhaps? Thank you!

It does say it at the top here: https://mono.github.io/Embeddinator-4000/getting-started-java
But there isn't anything saying: if you get error X do Y.
Maybe a Troubleshooting Guide is in order?

Maybe! I tend to assume mono components are the same as Xamarin, which I really should not be doing, especially when you called out Xamarin.Android later on the page.

I'll improve this in the driver next week so we issue a proper error for this

Will be fixed with https://github.com/mono/Embeddinator-4000/pull/506


Mock issues in Go 1.5

Several of our tests using github.com/Shopify/sarama/mocks are failing in Go 1.5.1 due to count mismatches between expected/actual offsets and the like. The same test suite passes when run with Go 1.4.2.
Have you seen any difference in test code that uses mocks with Go 1.5?

@wvanbergen ?
Off the top of my head it sounds like a race condition exposed by 1.5's change to the default GOMAXPROCS. Does adding -race to the test expose anything? Is this producer or consumer?

I'm seeing the test failures in the file that covers our sarama extraction -- both the producer and consumer are used there.
A race condition is likely. I commented out all but the first test, and saw a panic due to nil pointer at first. After adding a logging statement to the sarama source, then removing it, the test now fails with no panic. And running with -race made the test pass. Very odd.

I just saw it fail, and then pass, with the -race flag and no changes.
Further evidence of a race condition:
	<autogenerated>:31: Unexpected offset when calling ConsumePartition for test/0. Expected 4, got 1.
	<autogenerated>:31: Unexpected offset when calling ConsumePartition for test/1. Expected 1, got 4.
	buffer_test.go:258: Next offset expected to be 4; actual: 1
	buffer_test.go:263: Next offset expected to be 1; actual: 4

It's not super-clear to me, but based on those logs could it be an actual bug in your code that's been uncovered? The mock code involved is fairly simple and protected by a mutex: you're telling it to expect test/0 with offset 4, and then actually calling ConsumePartition with offset 1... and vice-versa for test/1.

@eapache I have found a race condition in my code; I was naively assuming loop index order was preserved.
I have another race condition which is not so simple however. Tests now pass most of the time, but sometimes, some of the messages inserted with mocks.PartitionConsumer.YieldMessage() are not ready when I check partitionConsumer.Messages(). Is there any way to ensure that the test messages have been added to the channel?

I don't see one off the top of my head. @wvanbergen why does YieldMessage go through handleExpectations instead of just writing straight to messages?


Fantasy league scoring settings cannot be modified outside of pre-draft state

Acceptance Criteria

The scoring settings cannot be modified when the fantasy league is not in pre-draft status
An error message is returned indicating why the request failed

blocked  on #189


Could not move Obsidian's window after its v1.0

Obsidian ignores dragging while ninja-cursor is enabled.
SYSTEM INFO:
	Obsidian version: v1.0.0
	Installer version: v0.14.6
	Operating system: Windows 10 Pro 10.0.19044
	Login status: not logged in
	Insider build toggle: off
	Live preview: on
	Legacy editor: off
	Base theme: dark
	Community theme: none
	Snippets enabled: 0
	Restricted mode: off
	Plugins installed: 24
	Plugins enabled: 7
		1: Self-hosted LiveSync v0.16.0
		2: Obsidian42 - BRAT v0.6.35
		3: TagFolder v0.15.5
		4: Workaround keyboard v0.0.5
		5: Calendar v1.5.10
		6: Screwdriver v0.0.3
		7: Templater v1.14.3

RECOMMENDATIONS:
	Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

Fixed at 0.0.8.

Fixed at 0.0.8.


openalSoft: support cross-compilation

Motivation for this change
It failed with 'missing gnu/stubs-32.h'.
Adding glibc to buildInputs helps when cross-compiling.
Things done

Built on platform(s)

[x] x86_64-linux (output tree appears to be the same)
[x] aarch64-linux (cross-compiled)
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Should also target staging.

Rebuilding now on staging, not expecting any issues.


Add ColPali as reranker

Description
PR to add ColPali as reranker.
Fixes # (issue)
New Package?
Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

[ ] Yes
[ ] No

Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[ ] Yes
[ ] No

Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

[ ] I added new unit tests to cover this change
[ ] I believe this change is already covered by existing unit tests

Suggested Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I ran make format; make lint to appease the lint gods

Yup. It does not work right. Because we cannot use postprocessor with retrievers.

View entire conversation on ReviewNB


app is not working

after first authentication (admin) page 'boards' opened and suddenly redirected to the sign in page again

I see the same issue.
From firebug I can see that the authenticate call is failing and the error is
"{"message":"Invalid token.","data":null,"alerts":[{"type":"error","text":"Unable to load user. Please try again."}]}"
Is there any logs being written which can provide more information about this.

this is the log written by apache
AH01630: client denied by server configuration: C:/apache/Apache24/htdocs/TaskBoard-master/.htaccess, referer: http://localhost/


rank not visible on AMR kmers from classifier

We don't seem to be showing the rank associated with each classifier prediction.  This is EXTREMELY important for understanding the relevance of a given kmer and the basis of the prediction.  I am worried about presenting this to the program officer on Wednesday if we don't get this fixed ASAP.  I have talked to Jim, and he is equally dismayed by not showing the rank.

This is addressed by #1284

Harry, this is important for Jim and I like to review the UI functionality with him and make sure it meets his expectations before we close the ticket.
-Maulik


One off errors

There is a one off error either in the engine, kit, or visualizer.
E.g. visualizer shows the first turn as turn 0 and actually renders the end of the turn 0.
Kits are 1-indexed (due to engine starting at turn 1).

Actually looking more into it, the engine runs 361 turns, not 360, and first day/night cycle has an extra turn of day...

I submitted a pull request to remove the extra day in the engine code.
https://github.com/Lux-AI-Challenge/Lux-Design-2021/pull/36


Initial Directory for Exporting Database

Loading the initial directory from the config file does not work.  Though a bug, its fix is not critical for the function of exporting.

Pretty sure I accidentally fixed this.


refactor(button): migration to signals

PR Checklist
Please check if your PR fulfills the following requirements:

[X] The commit message follows our
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Which package are you modifying?

[ ] accordion
[ ] alert
[X] alert-dialog
[ ] aspect-ratio
[ ] avatar
[ ] badge
[X] button
[ ] calendar
[ ] card
[ ] checkbox
[ ] collapsible
[ ] combobox
[X] command
[ ] context-menu
[ ] data-table
[ ] date-picker
[ ] dialog
[ ] dropdown-menu
[ ] hover-card
[ ] icon
[ ] input
[ ] label
[ ] menubar
[ ] navigation-menu
[ ] pagination
[ ] popover
[ ] progress
[ ] radio-group
[ ] scroll-area
[ ] select
[ ] separator
[ ] sheet
[ ] skeleton
[ ] slider
[ ] sonner
[ ] spinner
[ ] switch
[ ] table
[ ] tabs
[ ] textarea
[ ] toast
[ ] toggle
[ ] tooltip
[ ] typography

What is the current behavior?

Closes #439
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

updated buttons to use signals
updated other components that use signals to set defaults using a provider as we can no longer set signal input values programmatically

LGTM and nice workaround for setting the input!
I think this could be rated as a potentially breaking change, if someone used to set the inputs like we did in e.g. spartan-nav-link.directive this won't work anymore.
Should we document this workaround somehow, what do you think?

LGTM and nice workaround for setting the input! I think this could be rated as a potentially breaking change, if someone used to set the inputs like we did in e.g. spartan-nav-link.directive this won't work anymore. Should we document this workaround somehow, what do you think?

I agree. But thanks for introducing this pattern @ashley-hunter! I really like it! e2e tests seem flaky, but not related to this. I can check those out!

I agree. But thanks for introducing this pattern @ashley-hunter! I really like it! e2e tests seem flaky, but not related to this. I can check those out!

Thanks, yes, it seems to be the select e2e test - which I believe you mentioned to me the other day, although it runs fine locally 🙄.
Theres discussion here about documenting these cases if you have any input:
https://github.com/spartan-ng/spartan/pull/445#discussion_r1834341341

Thanks all, review feedback should now be addressed.


Set the version number to 0.1.0

This is not an official release, but various libraries can start
implementing versioning support. There may be still breaking changes in
the 0.x series.
Signed-off-by: Geneviève Bastien<EMAIL_ADDRESS>

Are we ready for this?


Payoneer Mobile App

Hey,
I'm the lead developer of the Mobile App for Payoneer (Android, iPhone coming soon) and we are using Ember.js as our framework for the mobile app.
Let me know what data you need to add that :)

Just submit a pull request. You can use this one as an example.


shippingInstructions mandatory

Elegant that you have include the shippingInstructions within the TransportDoc - that clearly indicates data originating from the shipper versus what is added by the carrier. Well done.
But I suppose shippingInstruction should be mandatory, shouldn't it?

@nissimsan thanks for noticing this - of course it should be mandatory - this has been fixed in: https://github.com/dcsaorg/DCSA-OpenAPI/pull/70


add primary key to github_event table

fixes #34
I ended up just adding a simple version of the raw sql migration here since I couldn't import a newer version of grafana/grafana and the syntax is the same for both mysql and postgres

Since the code already issues a DELETE by id before the insert we couldn't have duplicates anyway.
https://github.com/grafana/devtools/blob/9a3982ee7d0d5bcb70f68604eb34d9397a4b4faf/pkg/archive/archive.go#L310-L316

Yeah good point :smile: :+1:


Can you add API for wave array (array of number that represent the wave) ?

I need the hook of useAudioPlayer in src/hooks/useAudioPlayer.tsx
they have extractWaveformData
what i need is the hook can be accessed via import like this
import { useAudioPlayer } from "@simform_solutions/react-native-audio-waveform"

Thanks for making this amazing library

Can you please elaborate more on this? Why actually do you need that hook exported globally or what information do you need?

i need the wave data to perform audio analysis

Can you please elaborate more on this? Why actually do you need that hook exported globally or what information do you need?

Hello, in my case need prepare button MUTE.
import { useAudioPlayer } from '@simform_solutions/react-native-audio-waveform/lib/hooks/useAudioPlayer'
const { setVolume } = useAudioPlayer()
setVolume(0)


Video memory leak

Repro, on a machine without extravagant amounts of VRAM.

Go to debug mode
Screenshot all of the everything

This segfaults for me consistently after so many screenshots. Changing the order of the maps doesn't seem to matter. Running with gdb reveals:
#4  0x00007ffff3972839 in  () at /usr/lib/x86_64-linux-gnu/dri/iris_dri.so
#5  0x00007ffff3972b8e in  () at /usr/lib/x86_64-linux-gnu/dri/iris_dri.so
#6  0x00005555561744b7 in widgetry::drawing::GfxCtx::redraw ()
#7  0x00005555560ea7d9 in <map_gui::render::road::DrawRoad as map_gui::render::Renderable>::draw ()

aka, we're redrawing an existing buffer, and the video driver blows up with a memory allocation problem.
I'll see if I can dig up some tooling/glow calls to get the current video memory usage, to debug further. And time to sanity check all our buffer alloc/dealloc logic.

@michaelkirk mentioned some good ideas for solving this "properly" -- making DrawMap keep around some kind of LRU cache of zoomed-in Drawables. The size of the cache would ideally be related to the available VRAM, though not sure how to actually fetch that with OpenGL calls. This'd be good to implement eventually, but it's unlikely a regular user will manage to trip this on most maps.


win,fs: fix problems with passing file names to uv_fs_statfs

fixes #2683.

[ ] Add test.
[ ] Need to consider symbolic links?

Closing this, as https://github.com/libuv/libuv/pull/2695 landed.


Global Variable Access page 5530 "Item Availability by Event" (and suggestion for an interface).

Basically we need access to the global variables "ItemNo, LocationFilter, VariantFilter" at the time they are changed.
Setting these variables to protected would already help us a lot.
I would also like to make the following optional suggestion, which would make my life a bit easier in this case.
Creation of a new observer interface
interface "Item Availability by Event Observer"
{
    procedure SetItem(var NewItem: Record Item);
}

Extension by a listener list including a procedure to fill it.
page 5530 "Item Availability by Event"
...
var
        Item: Record Item;
        TempInvtPageData: Record "Inventory Page Data" temporary;
        CalcInventoryPageData: Codeunit "Calc. Inventory Page Data";
        ItemAvailFormsMgt: Codeunit "Item Availability Forms Mgt";
        ItemNo: Code[20];
        LocationFilter: Text;
        VariantFilter: Text;
        ForecastName: Code[10];
        PeriodType: Option Day,Week,Month,Quarter,Year;
        LastUpdateTime: DateTime;
        SelectedDate: Date;
        [InDataSet]
        IncludePlanningSuggestions: Boolean;
        [InDataSet]
        IncludeBlanketOrders: Boolean;
        [InDataSet]
        Emphasize: Boolean;
        [InDataSet]
        EnableShowDocumentAction: Boolean;
        // start new variable
        ItemAvailabilityByEventObservers: List of [interface "Item Availability by Event Observer"];
        // stop new variable

    // start new procedure
    procedure AddListener(var ItemAvailabilityByEventObserver: interface "Item Availability by Event Observer")
    begin
        ItemAvailabilityByEventObservers.Add(ItemAvailabilityByEventObserver);
    end;
    // stop new procedure

Calling the listeners
page 5530 "Item Availability by Event"
...
 procedure SetItem(var NewItem: Record Item)
    var
        ItemAvailabilityByEventObserver: interface "Item Availability by Event Observer";
    begin
        Item.Copy(NewItem);
        UpdateItemRequestFields(Item);
        // start code modification
        foreach ItemAvailabilityByEventObserver in ItemAvailabilityByEventObservers do
            ItemAvailabilityByEventObserver.SetItem(NewItem);
        // stop code modification
    end;

My page extension would look like this.
pageextension 50000 ItemAvailabilityByEventExt extends "Item Availability by Event" implements "Item Availability by Event Observer"
...
  trigger OnOpenPage()
    var
      ItemAvailabilityByEventObserver: interface "Item Availability by Event Observer";
    begin
        ItemAvailabilityByEventObserver := CurrPage;
        AddListener(ItemAvailabilityByEventObserver );
    end;

    procedure SetItem(var NewItem: Record Item)
    begin
      //My implementation
    end;

Codeunits and Enums can implement an interface, pages and page extensions can't.
We could add an event OnAfterSetItem() in the end of procedure SetItem() of page 5530.
Would it help you?

Yes, that would help if Item is passed as a parameter like this
    procedure SetItem(var NewItem: Record Item)
    begin
        Item.Copy(NewItem);
        UpdateItemRequestFields(Item);
        // >>>>>>>>>>>>>>>>>>>>
        OnAfterSetItem(Item);
        // <<<<<<<<<<<<<<<<<<<
    end;

    // >>>>>>>>>>>>>>>>>>>>
    [IntegrationEvent(false, false)]
    local procedure OnAfterSetItem(var Item: Record Item)
    begin
    end;
    // <<<<<<<<<<<<<<<<<<<

I just need to figure out how to transport the information to the page extension.

Yes, that would help if Item is passed as a parameter like this
    procedure SetItem(var NewItem: Record Item)
    begin
        Item.Copy(NewItem);
        UpdateItemRequestFields(Item);
        // >>>>>>>>>>>>>>>>>>>>
        OnAfterSetItem(Item);
        // <<<<<<<<<<<<<<<<<<<
    end;

    // >>>>>>>>>>>>>>>>>>>>
    [IntegrationEvent(false, false)]
    local procedure OnAfterSetItem(var Item: Record Item)
    begin
    end;
    // <<<<<<<<<<<<<<<<<<<

I just need to figure out how to transport the information to the page extension.

"ItemNo, LocationFilter, VariantFilter" are already protected vars on the page.
We will add the event OnAfterSetItem(Item: Record Item) in the end of procedure SetItem().

"ItemNo, LocationFilter, VariantFilter" are already protected vars on the page.
We will add the event OnAfterSetItem(Item: Record Item) in the end of procedure SetItem().

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


feat: Expose "form" attribute on inner button of ion-button

Feature Request
Ionic version:
[x] 4.11.4
Describe the Feature Request
HTML buttons have a form attribute that allows you to attach a button to a form that it is not a descendant of. This is useful, for example, if putting a submit button in an ion-footer where the form is inside the ion-content of a page.
Describe Preferred Solution
When specifying <ion-button form="formId">, the form attribute should be proxied to the button inside the <ion-button>'s shadow DOM.
Describe Alternatives
No sane alternatives are available in terms of appeasing form accessibility. Forms are required to have at least one submit input/button attached to them per WAI-ARIA 2 spec. Only real way around this is putting a submit button inside the form which is hidden by styles in such a way that it is still accessible to screen readers (tabbable). Then, proxy the click from the external button in the <ion-footer> to the hidden button inside the form. This is a big hack.
Related Code
<ion-button form="formId">

Any update on this feature please?

Thanks for the issue. I am going to close this in favor of a newer issue for the same bug: https://github.com/ionic-team/ionic-framework/issues/21194


How to run webcraft on MacOS

Hi
I am trying to run: go run ./main.go
But I have this error on the terminal, please help
# runtime/cgo
In file included from gcc_darwin_amd64.c:6:
/usr/local/include/pthread.h:331:6: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
/usr/local/include/pthread.h:200:2: note: expanded from macro '_PTHREAD_SWIFT_IMPORTER_NULLABILITY_COMPAT'
/usr/local/include/pthread.h:331:6: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
/usr/local/include/pthread.h:200:34: note: expanded from macro '_PTHREAD_SWIFT_IMPORTER_NULLABILITY_COMPAT'
/usr/local/include/pthread.h:540:6: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
/usr/local/include/pthread.h:200:2: note: expanded from macro '_PTHREAD_SWIFT_IMPORTER_NULLABILITY_COMPAT'
/usr/local/include/pthread.h:540:6: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
/usr/local/include/pthread.h:200:34: note: expanded from macro '_PTHREAD_SWIFT_IMPORTER_NULLABILITY_COMPAT'

go version
go version go1.16.6 darwin/amd64

I just found the solution in an issue https://github.com/golang/go/issues/38876
and add
export CGO_CPPFLAGS="-Wno-error -Wno-nullability-completeness -Wno-expansion-to-defined -Wno-builtin-requires-header"

Thank you so much!


HDDS-3705. [OFS] Implement getTrashRoots for trash cleanup

What changes were proposed in this pull request?
Implement getTrashRoots for trash cleanup
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3705
How was this patch tested?
Will add a new test.

I'm rebasing the branch since the last update is a while ago. Also there were some flaky ozone-recon robot test in the first run.

This PR is ready for review.

The new test contaminated the results of other tests in the same test class. Fixing this.

Codecov Report

Merging #1089 into master will increase coverage by 0.11%.
The diff coverage is 89.65%.

@@             Coverage Diff              @@
##             master    #1089      +/-   ##
============================================
+ Coverage     73.34%   73.46%   +0.11%
- Complexity     9962    10035      +73
============================================
  Files           969      974       +5
  Lines         49470    49714     +244
  Branches       4859     4892      +33
============================================
+ Hits          36285    36520     +235
+ Misses        10869    10863       -6
- Partials       2316     2331      +15

Impacted Files
Coverage Δ
Complexity Δ

...va/org/apache/hadoop/ozone/client/ObjectStore.java
89.85% <ø> (ø)
22.00 <0.00> (ø)

...op/fs/ozone/BasicRootedOzoneClientAdapterImpl.java
70.12% <89.28%> (+1.50%)
58.00 <10.00> (+10.00)

...he/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java
74.48% <100.00%> (+0.07%)
51.00 <1.00> (+1.00)

...iner/ozoneimpl/ContainerScrubberConfiguration.java
81.81% <0.00%> (-18.19%)
7.00% <0.00%> (-1.00%)

...rg/apache/hadoop/hdds/scm/pipeline/PipelineID.java
88.88% <0.00%> (-5.23%)
12.00% <0.00%> (+1.00%)
:arrow_down:

...ent/algorithms/SCMContainerPlacementRackAware.java
76.69% <0.00%> (-3.01%)
31.00% <0.00%> (-2.00%)

...rg/apache/hadoop/hdds/conf/OzoneConfiguration.java
69.14% <0.00%> (-1.64%)
17.00% <0.00%> (+1.00%)
:arrow_down:

...p/ozone/container/keyvalue/helpers/ChunkUtils.java
85.45% <0.00%> (-0.91%)
30.00% <0.00%> (-1.00%)

.../org/apache/hadoop/hdds/scm/pipeline/Pipeline.java
86.30% <0.00%> (-0.85%)
48.00% <0.00%> (+2.00%)
:arrow_down:

...hadoop/ozone/om/ratis/OzoneManagerRatisServer.java
79.29% <0.00%> (-0.79%)
35.00% <0.00%> (-1.00%)

... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d13b4f...e163f2c. Read the comment docs.

LGTM, +1 pending CI.

Thanks @xiaoyuyao  for the review. Will merge shortly.


5.4 Visualizing what convnets learn，why convolution is green when visualizing images

Why convolution is green when visualizing images?

 plt.imshow(display_grid, aspect='auto', cmap='viridis')

Hi, please take a look at the last sentence. display_grid is a numpy 2D array which is not RGB data. So the programmer have to use cmap to appoint the style. And virdis represents  blue-green-yellow. Here is part of the matplotlib documentation.
cmp:cmapstr or Colormap, optional
The Colormap instance or registered colormap name used to map scalar data to colors.
This parameter is ignored for RGB(A) data. Defaults to rcParams["image.cmap"] (default: 'viridis').

So actually the color has nothing to with the color of the input image, because it has been processed to a 4D tensor before inputting to the convnet.
谢谢~

Your answer is very helpful to me, thanks

A big compliment to you.@ @XZLeo


creating a release with v2 cli fails after creating release with v1 cli

We often use routing-release repo to generate dev releases using v1 cli; bosh create release.
Now we're using the cf-deployment manifest, which includes routing release to provide source for gorouter. When we set version: create and deploy using v2 cli, generating dev release on the fly, the deploy fails with mysterious error:
21:02:54 | Error: Action Failed get_task: Task 0440f4c4-ac01-4f16-73d2-1cbdb118f537 result: Compiling package golang1.7: Running packaging script: Running packaging script: Command exited with 2; Stdout: , Stderr: + VERSION=1.7.4

After consulting with @cppforlife, the solution seemed to be some combination of bosh2 reset-release and bosh2 remove-blob.
The issue was apparently that blobs downloaded by the v1 cli cannot be reused by the v2 cli or cf-deployment manifest? We would like to see either:

v2 cli able to use or replace blobs downloaded by v1 cli
A better error message that clearly indicates how to solve the problem, or at least what the real problem is.

+1 we have the same problem.  My blobs are being deleted from the blobs dir when I try to build a --force release with cli2

We encountered this problem today and wasted a lot of time tracking it down. We finally noticed it when we unpacked the release and found that the blobs were all symbolic links.
It'd be great to have this process fail fast; i.e. the v2 CLI ought to inform at the time of create-release that the blobs previously downloaded by the v1 CLI are incompatible.

@idoru There is already a PR for it https://github.com/cloudfoundry/bosh-cli/pull/259. Let's hope this gets merged soon and will lead to a new CLI version

PR has been merged and its functionality is available as of version 2.0.30. Closing.


Update .eslintignore queen-attack issue #399

@slippa91 is this PR replaced by #510?  I am unclear why there are 2 PRs.


OpenSSL 1.1.0e on AIX arg list too long

When trying to build OpenSSL 1.1.0e on AIX (version 5200-08 and a required perl 5.10), during the make depend phase I run into a "The parameter or environment lists are too long." error. I tried increasing the stack size to a large value but same result. The configure arguments are: threads aix64-cc -no-mdc2 -no-idea -no-rc5 -no-asm

Not sure the stack size makes a difference, but then I don't know what shell you're using...
It's likely that this line is the cause of your trouble:
	    for f in $(DEPS); do \

Not sure if it's make complaining or if it's the shell that has to take that command.
Have you tried with a different shell (if there is one)?  Can be done like this (replace /path/to/shell appropriately):
$ make SHELL=/path/to/shell

It could be the operating system complaining about the size of the command line and environment.  I've only got access to a later AIX (7100-01) and on this machine the following program prints the size limit of 4194304 bytes:
#include <stdio.h>
#include <unistd.h>

int main() {
        printf("%ld\n", sysconf(_SC_ARG_MAX));
        return 0;
}

From the sysconf man page:

   _SC_ARG_MAX
        Specifies the maximum byte length of the arguments for one of the
        exec functions, including environment data.

Pauli

Thank you.


Remove flaky E2E test from current set

Setup

Rancher version: 2.6.5
Browser type & version: CI

Describe the bug
We currently have several blocking errors generated by the E2E, preventing to merge or slowing it down, as the test needs to be restarted.
To Reproduce
Create PR to master.
Result
https://github.com/rancher/dashboard/actions/workflows/e2e.yaml?query=is%3Afailure
Expected Result
No errors or test successful.
Screenshots
Additional context

We have 3 different cases in 2 tests.
1.
"Home Page > Displays changelog section"
tests/pages/home.spec.ts
CypressError: Timed out retrying after 4050ms: 'cy.click()' failed because this element is detached from the DOM.
'<li data-v-3fcb6f81="" class="user-menu-item">...</li>'

(e.g.)
AssertionError: Timed out retrying after 4000ms: Expected to find element: `.user-menu-item`, but never found it. Queried from element: <div#page-actions.actions>

(e.g.)
2.
"Side navigation: Cluster > Can close first menu groups on click"
tests/navigation/side-nav/product-side-nav.spec.ts
AssertionError: Timed out retrying after 4000ms: Too many elements found. Found '1', expected '0'.

(e.g.)

This is not an issue for QA to test - closing


Recipe Book failing to find new tech added by updating another mod

Describe the Bug
Hi raiguard, I got a report on the Logistic Network Channels mod page about a crash when trying to load a savegame using both Logistic Network Channels and Recipe Book after updating to the new Logistic Network Channels release.  After analyzing the error, I think there may be an issue in Recipe Book where it's not checking in all cases for new technologies being added to a map.
From the crash report, it appears that there is a call to handle_research_updated, where it is crashing because the technology_data local has a nil value.  I believe this is happening because the latest version of my mod adds a new technology, and somehow this technology is not getting added to your globals table; so when the new tech gets researched, the handler ends up performing a nil index.
It looks to me like maybe the core problem is that build_recipe_book didn't get called when my mod was updated.  I can see in your on_configuration_changed that you call global_data.build_recipe_book(), but it looks like it only gets called if the configuration change was for your mod.  Maybe it should be rebuilding the recipe book for all configuration changes instead?  Since new technology, recipes, etc. can be added by any mod change, not just Recipe Book config changes.
To Reproduce
Steps to reproduce the behavior:

Create a map save using both Logistic Network Channels 1.0.12 and Recipe Book
Update Logistic Network Channels to version 1.1.0
Check in mod settings that "Logistic Network Channels > Channels require research" is disabled (may or may not matter, but it is the setting I used when I reproduced it)
Attempt to load the map save from the previous version
See error

Save file & Username
Save file is attached.  In-game username is 'ceresward'
Log file
Log file is attached.

factorio-current.log
logiNetChannels 1.0.12_rb-bug.zip

Thanks for the report. on_configuration_changed is working just fine, it's just that Logistic Network Channels gets the event before Recipe Book does, and it updates stuff there. I added a nil check for the next release, which should fix it.


Spatial material roughness/env map issues

Godot version:
3.1 alpha 1
OS/device including version:
Win10 960m
Issue description:
This is a continuation of issue #18880 which is a long thread that discussed roughness values in Substance as compared to Godot. As a result, @reduz added this commit : https://github.com/godotengine/godot/commit/62233423c7310a155e8c948c053701dba248dcdb
Here is a comparison to the previous 3.0.6 result and the same scenes in Substance and Blender/eevee.

The metallics do look a little better, but there is still almost no distinction between roughness levels in the metallics at levels 0.1/0.2 and 0.3/0.4 as compared to the smooth gradation in Substance and Blender. The blurring in general does not look very smooth as compared to Substance...not sure if this is the amount of the blurring or the technique used?
However, the highlight reflections for the dielectric materials (in orange) in Godot do now look better then eevee, in comparison to Substance . Also, the blue rings on top/bottom look very close now compared to the Substance render.
More strangely though is the general shading of the orange dielectrics in 3.1 alpha now. Not sure if it is because of the recent env map changes, but the material is almost looking like a flat luminant material now, as the shading has almost disappeared. Look at the darker non facing parts between the orange rings in the previous renders as compared to now.
Note that there are no lights or SSAO in this scene, just the hdri providing all lighting info.
Here is a zipped file that contains the Godot, Blender and Substance Painter project files:
roughness_test_3_1alpha1.zip
EDIT: the more I looked at this image, it became clear that the correct solution is about halfway between what 3.0.6 and 3.1 alpha are doing. I mocked this up in an image editor so that the 3.1 render was overlaid over the 3.0.6 render at exactly 50% opacity. It looks very close to the Substance render for the dielectric! Reduz, if you can get that cubemap angle at only 50% of what you changed it from, this could be the solution?

Just did a quick render comparison between 2.0.6 (on left) and 3.1 alpha 1 (on right) and they look identical. Nothing has broken on the shading side, as this scene uses only giprobe and luminant textures to light it (no hdri). I would guess that the strange result above is due to the recent env map commit.

Yes, I still have to manually edit roughness maps that I export from Substance Painter, cranking the brightness up, because it looks way too glossy in Godot even with the roughness set to 1.0.

By the way, I have a similar kind of a problem with the transmission texture also. Just like it is the case with the roughness value, assigning a moderately bright grayscale image to the transmission slot makes the material looks extremely bright.
If it was possible to adjust such a value from 0 to 1.0 before, assinging a texture feels like it's stuck at  0.95-1.0 (or 0.0-0.05 for the roughness).
I'm not sure if I should report a separate issue for this, but I'm beginning to wonder if there could be the same type of a bug across material parameters regarding a texture map input.

Is this better after #27898?

This is what I got without changing anything. just for curiosity.

I ran the demo locally and can confirm it looks the same as on @volzhs' screenshots.

hm.... my personal project seems broken...
all material is too bright now :(

this looks similar to mine with current master.

I found that looks fine without Omni/Spot/Directional light.
But with those light sources, it makes too bright.

@volzhs The GLES2 and GLES3 backends are not expected to look the same, when switching between them you need to change the light intensities to account for the difference between the way each renders objects. Godot doesn't use physically based units for lighting, so you always have to fudge the numbers a little bit. It is expected that rough materials will appear slightly brighter than they did previously
Here is a picture of various roughness/metallic settings on a sphere. You can see that the rough spheres (especially the rough metal) appears way darker than the rest.
http://docs.godotengine.org/en/latest/_images/PBR.png
This was because the previous behaviour was losing light on rough materials (especially metallics) the solution was to make the brdf energy conserving. But if it's no longer losing light, then it is going to appear a little brighter.

I guess we'll need to add a project setting for this then. It should probably be disabled by default, but it'd be good if the project version conversion code could enable it automatically.

As surface illumination gets brighter there is a loss in saturation(washout if you will). Might be though that the washout/effect is too strong perhaps? Might be up to tone-mapping, too. Will likely require further investigation to see what the underlying issue is, if there really is one.

Tried reverting #27898, but the issue is still there. Im getting it in my test scene now too.

I've been playing around with this issue a little bit lately. I'm starting to see some good results. Increasing number of samples and decreasing the size of the radiance map gives really good results and is faster.

The above image uses 1024 samples (current is 512 for desktop, but because of a bug desktop was using 64) and a radiance size of 128 (default is 512, but with proper samples the visual difference between 128 and 512 is negligible).

@clayjohn thanks a lot for looking into this issue! Good to hear that you are one the case :)
The metallics on levels 0.3/0.4  definitely looking better and closer to the substance reference. Any idea why metallic 0.3/04 are looking almost identical, whereas when you look at the substance reference there is a noticeable increase in roughness over all 5 levels.
Levels at 0 roughness look incorrect on on both metallic and dielectric as you can barely even see the hdri reflection. Any idea why?
The roughness reflections also are looking better on the dielectrics, but in general they are still looking strange as compared to godot 3.0.6. If you look at the reference comparison image, there is no falloff on the 90 degree faces, and it almost looks like it has a fake sss/backlit look. I actually thought that the 3.0.6 version looked much better. Not sure what reduz changed exactly..was it the way the cubemaps are blurred?

any idea why metallic 0.3/04 are looking almost identical, whereas when you look at the substance reference there is a noticeable increase in roughness over all 5 levels.

Not sure exactly, the results now are more similar to the ones in eevee. It is likely due to using a different brdf. Or maybe substance takes the power of roughness.

Levels at 0 roughness look incorrect on on both metallic and dielectric as you can barely even see the hdri reflection. Any idea why?

My camera was in the wrong position! I actually fixed that after. Moving the camera around really affects the way that they appear.

The roughness reflections also are looking better on the dielectrics, but in general they are still looking strange as compared to godot 3.0.6

I think it is also a result of the brdf that we use when rending and not in the production of the radiance map.

Oh yeah, I just used an orthographic front view for all of the screengrabs, to make sure that they looked as similar as possible between applications.
So I am guessing that radiance map size is Quality/reflections/Atlas size? What about the atlas subdiv?
The big change in dielectric appearance that occured between 3.0.6 and 3.1 via 6223342 looks like it only changed the cubemap filter. I don't think that the brdf changed in the this timeframe?

So I am guessing that radiance map size is Quality/reflections/Atlas size? What about the atlas subdiv?

Its actually a property in the sky itself http://docs.godotengine.org/en/latest/classes/class_sky.html#class-sky-property-radiance-size

The big change in dielectric appearance that occured between 3.0.6 and 3.1 via 6223342 looks like it only changed the cubemap filter. I don't think that the brdf changed in this timeframe?

I don't know. I'm not familiar with how things were in 3.0 as I wasn't heavily involved back then. I'll be looking into improving the radiance map stuff further though.

Cheers! Yeah, there was definitely something funky that happened with that particular commit. Maybe it was the normalize removed from vec3 L = normalize(2.0 * dot(V, H) * H - V) ? The math is beyond me, but there was a visible regression with this commit.
As noted in my photoshopped comparison image in the first post, the correct looking result (aside from the actual quality of the roughness) seemed to be somewhere between what 3.0.6 and 3.1 were doing when it comes to the cubemap filtering code.

@clayjohn I have been playing around with the roughness demo in the current master. The changes you have made do make the metallics look better, but there are still issues with the dielectric materials.
I made an attempt to compare the old cube filter code and the current one by reverting 6223342 and changing the 2 x multiplier in line 247 so that it reads: vec3 L = normalize(4.0 * dot(V, H) * H - V);
This gives a much better appearance to the dielectrics and is very close to the substance reference, but the metallics don't look as good as the current master. As can be seen in this image.

I am way out of my league here, so maybe you know how the cubefilter could be changed to get the best of both of these worlds ?

@fracteed I wish I could say it was that easy. The L = normalize(2.0 * dot(V, H) * H - V) is standard code, it's not really a tweakable parameter. It has a very clear meaning in the context of PBR rendering.
While that change does make it look nicer it is likely doing it for the wrong reasons. There is something else that is being done wrong but I can't find what it is. The dielectrics do look waaaay better though. Im just wondering if there is something going on with the actual rendering of the materials using the map. Or maybe it has something to do with the way the texture array works. You'll notice if you change your project setting to use a single mip-mapped texture things go bonkers. Or in GLES3 certain resolutions make the environment map go crazy.
Anyway, the point of all that is that there is a lot of work to be done on the environment maps.

Ha, yes it was just a cheap hack on my part :) Thanks for the link, as I had no idea what the code was based on. That is a very nice website, so at least try to wrap my head around the theory at least.
You are right that the problem probably lies elsewhere, so I hope that you can keep digging into the problem! If I had a choice I do prefer the previous look before that reduz commit and would revert it. Most scenes tend to have more dielectric surfaces than pure metallic ones, so I would prefer having the dielectrics to look more accurate if it was one way or the other.
I am still developing my game in 3.0.6 but have noticed when I test it on 3.1 or later that my outdoor levels (which use a HDRI) look somewhat worse. The surfaces have less definition and look more stylized as can be seen in the roughness demo comparison. Not sure if all of this will be rewritten for Vulkan anyway, or if it will inherit the same issues...time will tell.
Btw, I tried upping the radiance from the default value on this demo scene to 512 or 1024 and get an instant crash (this is only my old win7 laptop with a pitiful hd4000), but I thought I would at least mention it.

I get the crash too on higher resolution maps with my low-end device too. Intel devices tend to quit early if they suspect the GPU of hanging. Mine usually crashed on 1024, and always crashed on 2048 previously and now always crashes on 1024. To be honest though, you don't need above 128 for most scenes, I would only go up to 512 if I had a lot of large objects with high metallic and no roughness.
For Vulkan this will all be rewritten. So reduz doesn't have a huge interest in fixing stuff up. For GLES3 I am just trying to focus on bugs and low-hanging fruit. My focus is mostly on GLES2 now (although GLES2 will need to be substantially rewritten for 4.0 too).

Agreed that 128 radiance is fine, and I don't usually change the default. Sounds like crashes from high values are not a new phenomena. Does make me wonder if there is any point to having those presets that go above 512.
I plan on shifting my games over to Vulkan at the end of the year, or whenever there is an alpha of 4.0. Am happy to mostly stick with 3.0.6 for the moment, so I am not overly concerned about the cubemap/roughness issues. It may not be noticed by many devs anyway, unless they are using properly authored PBR assets with outdoor scenes lit by a HDRI. The majority seem to be doing more stylised low poly games.

@akien-mga  can you please re-open this issue. Although the change by @clayjohn did improve the metallics appearance, there is still a noticeable regression from 3.0.6 to 3.1 as noted in the original post that has still not been addressed.
No doubt this issue will have to be revisited when Vulkan builds appear in a few months, so it would be better to leave this open as a point of reference.

@fracteed Im making some good progress :)
Looks like specular highlights are still too bright on non-metallics though. Just as pointed out in #33616

Thanks @clayjohn I really appreciate you looking into this matter! Yes, this is looking closer. I look forward to your progress :)

Updated Progress.

 This is looking very close to the substance reference on the dielectrics now. The main thing that stands out now is the white halo around the grazing edges of the top/bottom rings.
Are you going to apply the radiance map changes you made to the metallics as well, to get them a bit smoother looking?

The main thing that stands out now is the white halo around the grazing edges of the top/bottom rings.

Ive been working on this all day. I still cant figure out the cause. One thing that I noticed is that it only appears this strongly when using an orthogonal camera. With the normal perspective camera the effect is a lot more subtle and appropriate.

Are you going to apply the radiance map changes you made to the metallics as well, to get them a bit smoother looking?

The irradiance map only applies to dielectrics. I did some other work to smooth out the metallics. :)
At this point I think I will make a WIP PR so you can test out the current changes. I still need to copy all the work over to GLES2 as well.
Current iteration (Orthogonal):

Current iteration (Perspective):

You have done an amazing job here @clayjohn! I was probably just nitpicking about the grazing edges :) This hdri is quite extreme anyway, which is why I chose it for this test scene. Overall it is looking fantastic, and I am impressed with how much better the metallics are looking. It is actually looking much closer to the substance look than eevee, so I look forward to trying it out.
On a related note, when the time comes, it would be great for you to make these kind of changes to the vulkan branch. The IBL is quite broken in the vulkan branch.


Test: Hide SCM commit input box

Related to #51808

[ ] anyOS @RMacfarlane
[ ] anyOS @isidorn

Complexity: 2
When authoring an extension which contributes an SCM Provider, one can now hide the SourceControlInputBox from the UI using the visible property: https://github.com/Microsoft/vscode/blob/1d55212ec0ff49c9274da54fb775d13126dba5cf/src/vs/vscode.proposed.d.ts#L780

@ThomasNolte this are test plan items which are tested internally by vscode team members. If you would like to contribute look for issues with good-first-issue and help-wanted


Facing ipmi login issue for Baremetal OpenBMC system

ipmi login failing for OpenBMC machine
Error Log:
# ./op-test --run testcases.RunHostTest.RunHostTest -c ./machine_test.conf
Logs in: /var/www/html/ltckvmci/nodes/ltc-wspoon14/op-test/test-reports/test-run-20240610021931
2024-06-10 02:19:31,178:op-test:setUpLoggerFile:INFO:Preparing to set location of Log File to /var/www/html/ltckvmci/nodes/ltc-wspoon14/op-test/test-reports/test-run-20240610021931/20240610071931178050.main.log
2024-06-10 02:19:31,178:op-test:setUpLoggerFile:INFO:Log file: /var/www/html/ltckvmci/nodes/ltc-wspoon14/op-test/test-reports/test-run-20240610021931/20240610071931178050.main.log
2024-06-10 02:19:31,178:op-test:setUpLoggerDebugFile:INFO:Preparing to set location of Debug Log File to /var/www/html/ltckvmci/nodes/ltc-wspoon14/op-test/test-reports/test-run-20240610021931/20240610071931178541.debug.log
2024-06-10 02:19:31,178:op-test:setUpLoggerDebugFile:INFO:Debug Log file: /var/www/html/ltckvmci/nodes/ltc-wspoon14/op-test/test-reports/test-run-20240610021931/20240610071931178541.debug.log
2024-06-10 02:19:31,179:op-test:do_testing_setup:INFO:TestCase Log files: /var/www/html/ltckvmci/nodes/ltc-wspoon14/op-test/test-reports/test-run-20240610021931/*
2024-06-10 02:19:31,179:op-test:do_testing_setup:INFO:StreamHandler setup normal
2024-06-10 02:19:37,782:op-test:__init__:INFO:Running Local HMC tests
runTest (testcases.OpTestFlash.FSPFWImageFLASH) ... skipped 'FSP In-band firmware Update test'
runTest (testcases.OpTestFlash.BmcImageFlash) ... skipped 'BMC image not provided, so skipping test'
runTest (testcases.OpTestFlash.PNORFLASH) ... skipped 'PNOR image not provided, so skipping test'
runTest (testcases.OpTestFlash.OpalLidsFLASH) ... skipped 'No custom skiboot/kernel to flash'

----------------------------------------------------------------------
Ran 4 tests in 0.001s

OK (skipped=4)
runTest (testcases.RunHostTest.RunHostTest) ... command-line line 0: Unsupported option "afstokenpassing"^M
^M~.
2024-06-10 02:19:39,999:op-test.common.OpTestUtil:check_nvram_options:INFO:No NVRAM utility available to check options
~.command-line line 0: Unsupported option "afstokenpassing"^M
^M~.
2024-06-10 02:19:42,207:op-test.common.OpTestUtil:check_nvram_options:INFO:No NVRAM utility available to check options
~.command-line line 0: Unsupported option "afstokenpassing"^M
^M~.
ERROR

======================================================================
ERROR: runTest (testcases.RunHostTest.RunHostTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/www/html/ltckvmci/nodes/ltc-wspoon14/op-test/testcases/RunHostTest.py", line 52, in setUp
    self.console_thread = OpSOLMonitorThread(1, "console")
  File "/var/www/html/ltckvmci/nodes/ltc-wspoon14/op-test/common/OpTestSOL.py", line 63, in __init__
    self.c = self.system.console.get_console(logger=self.logger)
  File "/var/www/html/ltckvmci/nodes/ltc-wspoon14/op-test/common/OpTestSSH.py", line 205, in get_console
    self.connect(logger)
  File "/var/www/html/ltckvmci/nodes/ltc-wspoon14/op-test/common/OpTestSSH.py", line 185, in connect
    self.check_set_term()
  File "/var/www/html/ltckvmci/nodes/ltc-wspoon14/op-test/common/OpTestSSH.py", line 196, in check_set_term
    self.util.setup_term(self.system, self.pty,
  File "/var/www/html/ltckvmci/nodes/ltc-wspoon14/op-test/common/OpTestUtil.py", line 1680, in setup_term
    raise ConsoleSettings(before=pty.before, after=pty.after,
common.Exceptions.ConsoleSettings: Setting the prompt or logging in for the console was not successful, check credentials and review the following for more details
Expect Before Buffer="
~."
Expect After Buffer="<class 'pexpect.exceptions.EOF'>"
Message="Getting login and sudo not successful, probably connection or credential issue, retry"

----------------------------------------------------------------------
Ran 1 test in 6.629s

FAILED (errors=1)
2024-06-10 02:19:46,419:op-test:<module>:INFO:Exit with Result errors="1" and failures="0"
2024-06-10 02:19:50,445:op-test.common.OpTestUtil:cleanup:INFO:OpTestSystem Starting to Gather BMC logs
~.command-line line 0: Unsupported option "afstokenpassing"^M
^M~.
~.command-line line 0: Unsupported option "afstokenpassing"^M
^M~.
2024-06-10 02:19:54,862:op-test.common.OpTestUtil:cleanup:WARNING:OpTestSystem encountered a problem cleaning up BMC /tmp files, you may want to check.
2024-06-10 02:19:54,862:op-test.common.OpTestUtil:cleanup:INFO:OpTestSystem Completed Gathering BMC logs, find them in the Log Location
2024-06-10 02:19:54,862:op-test.common.OpTestUtil:cleanup:INFO:OpTestSystem Starting to Gather ESEL's
2024-06-10 02:19:55,686:op-test.common.OpTestUtil:cleanup:INFO:OpTestSystem Completed Gathering ESEL's, find them in the Log Location
2024-06-10 02:19:55,686:op-test.common.OpTestUtil:dump_versions:INFO:Log Location: /var/www/html/ltckvmci/nodes/ltc-wspoon14/op-test/test-reports/test-run-20240610021931/*debug*
2024-06-10 02:19:55,686:op-test.common.OpTestUtil:dump_versions:INFO:
----------------------------------------------------------
OpTestSystem Firmware Versions Tested
(if flashed things like skiboot.lid, may not be accurate)
----------------------------------------------------------
None
----------------------------------------------------------
----------------------------------------------------------

Manual Login through ipmi is sucessful
# ipmitool -I lanplus -H <bmc-ip> -U <bmc-user> -P <bmc-password> sol activate
Unable to Get Channel Cipher Suites
[SOL Session operational.  Use ~? for help]

ltc-wspoon14 login: <host-user>
Password: <host-password>
Last login: Thu Jun  6 03:54:42 from <ip>

machine_test.conf file for the system
[op-test]
bmc_type=OpenBMC
bmc_ip=<bmc-ip>
bmc_username=<bmc-user>
bmc_usernameipmi=<bmc-user>
bmc_password=<bmc-password>
bmc_passwordipmi=<bmc-password>
host_ip=<host-ip>
host_user=<host-user>
host_password=<host-password>
host_cmd_timeout=360000
host_cmd_file=./test.conf
machine_state=OS

@misanjumn @harihare , seems the system has disabled rest API, but when in conf file  OpenBMC  given as BMC type so  it will go and try to login using  rest API , so if system connecting with IPMI please use FSP as BMC Type and let me know result

@PraveenPenguin
I tried using FSP as bmc_type, and it did not work.
But using SMC as bmc_type worked!
Now I'm able to run the following optest command with no issues
# ./op-test --run testcases.RunHostTest.RunHostTest -c ./machine_test.conf
However, th optest command for Boot to OS is still throwing the error even with SMC as the bmc_type
./op-test --run testcases.BasicIPL.BootToOS -c ./machine_upstreamkernelbuild.conf

runTest (testcases.BasicIPL.BootToOS) ... 2024-07-21 05:05:09,453:op-test.common.OpTestSystem:run_POWERING_OFF:INFO:System is in standby/Soft-off state
Unable to Get Channel Cipher Suites
> Error: no response from RAKP 1 message
Error: Received an Unexpected RAKP 2 message
> Error: no response from RAKP 1 message
Error: Received an Unexpected RAKP 2 message
> Error: no response from RAKP 1 message
Error: Received an Unexpected RAKP 2 message
> Error: no response from RAKP 1 message
Get HPM.x Capabilities request failed, compcode = d4
ERROR

======================================================================
ERROR: runTest (testcases.BasicIPL.BootToOS)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/data/jenkins/workspace/kvmci/common/OpTestSystem.py", line 721, in run_IPLing
    petit_r, petit_reconnect = self.wait_for_it(expect_dict=self.petitboot_expect_table, reconnect=self.petitboot_reconnect,
  File "/data/jenkins/workspace/kvmci/common/OpTestSystem.py", line 540, in wait_for_it
    sys_pty = self.console.connect()
  File "/data/jenkins/workspace/kvmci/common/OpTestIPMI.py", line 310, in connect
    raise CommandFailed('sol activate',
common.Exceptions.CommandFailed: Command 'sol activate' exited with '-1'.
Output
IPMI: pexpect.TIMEOUT while trying to establish connection, command was 'ipmitool -H ltc-wspoon14-bmc.aus.stglabs.ibm.com -I lanplus -U root -P S0undCraftUI24r  sol activate'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/data/jenkins/workspace/kvmci/testcases/BasicIPL.py", line 170, in runTest
    self.cv_SYSTEM.goto_state(OpSystemState.OS)
  File "/data/jenkins/workspace/kvmci/common/OpTestSystem.py", line 389, in goto_state
    self.state = self.stateHandlers[self.state](state)
  File "/data/jenkins/workspace/kvmci/common/OpTestSystem.py", line 745, in run_IPLing
    raise my_exception
common.Exceptions.UnknownStateTransition: Something happened system state="2" and we transitioned to UNKNOWN state.  Review the following for more details
Message="OpTestSystem in run_IPLing and the Exception=
"Command 'sol activate' exited with '-1'.
Output
IPMI: pexpect.TIMEOUT while trying to establish connection, command was 'ipmitool -H ltc-wspoon14-bmc.aus.stglabs.ibm.com -I lanplus -U root -P S0undCraftUI24r  sol activate'"
 caused the system to go to UNKNOWN_BAD and the system will be stopping."

ah ok it turn as Super micro system @misanjumn thanks for trying suggestion , please close this issue

Latest Logs
OS: Fedora40
(Note: Manual ipmi login command working in the jenkins system)
machine_test.conf
# cat machine_test.conf
[op-test]
bmc_type=OpenBMC
bmc_ip=<bmc-ip>
bmc_username=<bmc-user>
bmc_usernameipmi=<bmc-user>
bmc_password=<bmc-password>
bmc_passwordipmi=<bmc-password>
host_ip=<host-ip>
host_user=<host-user>
host_password=<host-password>
host_cmd_timeout=360000
host_cmd_file=./test.conf
machine_state=OS

test.conf file
# cat test.conf
echo 'Testing the machine using the inputs provided...'
uname -a
date
echo 'Working fine ...'

Using OpenBMC as machine_type, this is the following error
# ./op-test --run testcases.RunHostTest.RunHostTest -c ./machine_test.conf
Logs in: /var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/test-reports/test-run-20240826021227
2024-08-26 02:12:27,260:op-test:setUpLoggerFile:INFO:Preparing to set location of Log File to /var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/test-reports/test-run-20240826021227/20240826071227260063.main.log
2024-08-26 02:12:27,260:op-test:setUpLoggerFile:INFO:Log file: /var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/test-reports/test-run-20240826021227/20240826071227260063.main.log
2024-08-26 02:12:27,260:op-test:setUpLoggerDebugFile:INFO:Preparing to set location of Debug Log File to /var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/test-reports/test-run-20240826021227/20240826071227260523.debug.log
2024-08-26 02:12:27,261:op-test:setUpLoggerDebugFile:INFO:Debug Log file: /var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/test-reports/test-run-20240826021227/20240826071227260523.debug.log
2024-08-26 02:12:27,261:op-test:do_testing_setup:INFO:TestCase Log files: /var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/test-reports/test-run-20240826021227/*
2024-08-26 02:12:27,261:op-test:do_testing_setup:INFO:StreamHandler setup normal
2024-08-26 02:12:33,758:op-test:__init__:INFO:Running Local HMC tests
runTest (testcases.OpTestFlash.FSPFWImageFLASH) ... skipped 'FSP In-band firmware Update test'
runTest (testcases.OpTestFlash.BmcImageFlash) ... skipped 'BMC image not provided, so skipping test'
runTest (testcases.OpTestFlash.PNORFLASH) ... skipped 'PNOR image not provided, so skipping test'
runTest (testcases.OpTestFlash.OpalLidsFLASH) ... skipped 'No custom skiboot/kernel to flash'

----------------------------------------------------------------------
Ran 4 tests in 0.001s

OK (skipped=4)
runTest (testcases.RunHostTest.RunHostTest) ... command-line line 0: Unsupported option "afstokenpassing"^M
^M~.
2024-08-26 02:12:35,975:op-test.common.OpTestUtil:check_nvram_options:INFO:No NVRAM utility available to check options
~.command-line line 0: Unsupported option "afstokenpassing"^M
^M~.
2024-08-26 02:12:38,183:op-test.common.OpTestUtil:check_nvram_options:INFO:No NVRAM utility available to check options
~.command-line line 0: Unsupported option "afstokenpassing"^M
^M~.
ERROR

======================================================================
ERROR: runTest (testcases.RunHostTest.RunHostTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/testcases/RunHostTest.py", line 52, in setUp
    self.console_thread = OpSOLMonitorThread(1, "console")
  File "/var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/common/OpTestSOL.py", line 63, in __init__
    self.c = self.system.console.get_console(logger=self.logger)
  File "/var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/common/OpTestSSH.py", line 205, in get_console
    self.connect(logger)
  File "/var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/common/OpTestSSH.py", line 185, in connect
    self.check_set_term()
  File "/var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/common/OpTestSSH.py", line 196, in check_set_term
    self.util.setup_term(self.system, self.pty,
  File "/var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/common/OpTestUtil.py", line 1680, in setup_term
    raise ConsoleSettings(before=pty.before, after=pty.after,
common.Exceptions.ConsoleSettings: Setting the prompt or logging in for the console was not successful, check credentials and review the following for more details
Expect Before Buffer="
~."
Expect After Buffer="<class 'pexpect.exceptions.EOF'>"
Message="Getting login and sudo not successful, probably connection or credential issue, retry"

----------------------------------------------------------------------
Ran 1 test in 6.630s

FAILED (errors=1)
2024-08-26 02:12:42,395:op-test:<module>:INFO:Exit with Result errors="1" and failures="0"
2024-08-26 02:12:46,438:op-test.common.OpTestUtil:cleanup:INFO:OpTestSystem Starting to Gather BMC logs
~.command-line line 0: Unsupported option "afstokenpassing"^M
^M~.
~.command-line line 0: Unsupported option "afstokenpassing"^M
^M~.
2024-08-26 02:12:50,855:op-test.common.OpTestUtil:cleanup:WARNING:OpTestSystem encountered a problem cleaning up BMC /tmp files, you may want to check.
2024-08-26 02:12:50,855:op-test.common.OpTestUtil:cleanup:INFO:OpTestSystem Completed Gathering BMC logs, find them in the Log Location
2024-08-26 02:12:50,856:op-test.common.OpTestUtil:cleanup:INFO:OpTestSystem Starting to Gather ESEL's
2024-08-26 02:12:51,704:op-test.common.OpTestUtil:cleanup:INFO:OpTestSystem Completed Gathering ESEL's, find them in the Log Location
2024-08-26 02:12:51,705:op-test.common.OpTestUtil:dump_versions:INFO:Log Location: /var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/test-reports/test-run-20240826021227/*debug*
2024-08-26 02:12:51,705:op-test.common.OpTestUtil:dump_versions:INFO:
----------------------------------------------------------
OpTestSystem Firmware Versions Tested
(if flashed things like skiboot.lid, may not be accurate)
----------------------------------------------------------
None
----------------------------------------------------------
----------------------------------------------------------

@PraveenPenguin @abdhaleegit
Thank you for the solution.
Login successful after adding the following changes in the ssh config file
# cat .ssh/config
Host *bmc*
    HostKeyAlgorithms=ssh-rsa
    PubkeyAcceptedKeyTypes +ssh-rsa

Test Run
# ./op-test --run testcases.RunHostTest.RunHostTest -c ./machine_test.conf
Logs in: /var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/test-reports/test-run-20240826040312
2024-08-26 04:03:12,601:op-test:setUpLoggerFile:INFO:Preparing to set location of Log File to /var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/test-reports/test-run-20240826040312/20240826090312601292.main.log
2024-08-26 04:03:12,601:op-test:setUpLoggerFile:INFO:Log file: /var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/test-reports/test-run-20240826040312/20240826090312601292.main.log
2024-08-26 04:03:12,601:op-test:setUpLoggerDebugFile:INFO:Preparing to set location of Debug Log File to /var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/test-reports/test-run-20240826040312/20240826090312601758.debug.log
2024-08-26 04:03:12,602:op-test:setUpLoggerDebugFile:INFO:Debug Log file: /var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/test-reports/test-run-20240826040312/20240826090312601758.debug.log
2024-08-26 04:03:12,602:op-test:do_testing_setup:INFO:TestCase Log files: /var/www/html/ltckvmci/nodes/ltcwspoon14/op-test/test-reports/test-run-20240826040312/*
2024-08-26 04:03:12,602:op-test:do_testing_setup:INFO:StreamHandler setup normal
2024-08-26 04:03:19,182:op-test:__init__:INFO:Running Local HMC tests
runTest (testcases.OpTestFlash.FSPFWImageFLASH) ... skipped 'FSP In-band firmware Update test'
runTest (testcases.OpTestFlash.BmcImageFlash) ... skipped 'BMC image not provided, so skipping test'
runTest (testcases.OpTestFlash.PNORFLASH) ... skipped 'PNOR image not provided, so skipping test'
runTest (testcases.OpTestFlash.OpalLidsFLASH) ... skipped 'No custom skiboot/kernel to flash'

----------------------------------------------------------------------
Ran 4 tests in 0.001s

OK (skipped=4)
runTest (testcases.RunHostTest.RunHostTest) ... command-line line 0: Unsupported option "afstokenpassing"^M

[console-expect]#which bash && exec bash --norc --noprofile
PS1=\[console-expect\]#
which bash && exec bash --norc --noprofile
/usr/bin/bash
bash-5.2# PS1=\[console-expect\]#
[console-expect]#which stty && stty cols 300;which stty && stty rows 30
which stty && stty cols 300;which stty && stty rows 30
/usr/bin/stty
/usr/bin/stty
[console-expect]#export LANG=C
export LANG=C
[console-expect]#

[console-expect]#date
date
Mon Aug 26 04:03:52 CDT 2024

Closing this issue now.


Adds default RStudio auto-save settings

Adds a default auto-save, specific to SWB, to ensure that files are saved so users don't lose work when check-idle script executes an on idle shutdown signal.
Deployed to aim-ahead-dbmi-dev already.
Checklist:

[X] Have you successfully deployed to an AWS account with your changes?

Ticket: ALS-4005
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Reviewed in office hours today.


backport of 2122

Backport of #2122

jenkins test luminous-ansible2.4-centos7_cluster

jenkins test luminous-ansible2.4-centos7_cluster

osp12 backport

Needs to be discussed as this is a feature backport.

Just observing that we need this for OSP 13: I see a comment 'osp12 backport' which is why I mention this.

jenkins test luminous-ansible2.4-centos7_cluster


Iskcon page

Updated the iskcon page
Clears #76

Navbar is left, will open a beginners issue for the same


fix(build:icons script): Fix error of build:icons script

Which nodejs version are you using? The old handling worked well for me: https://github.com/mittwald/flow/issues/784#issuecomment-2374005257


Stage 3D disappears in 8.4.0 release

It happens because of using the same stencil for both display list masks and stage 3d.
Here is a sample project to reproduce this issue.
Stage3DBug.zip

I just did a quick patch that fixes it, thinking about the longer-term fix to these GL state issues, though. Thank you :smile:


Basic Dynamic Search Control using the command

Search using a search command:
msg.payload = { command:{search:"us10"} };
and clearing it using the following:
msg.payload = { command:{search:"clear"} };

Hi apologies - didn't know you were going to do this directly - so the package.json has moved on already :-)... best not to edit versions in there.
Also index.html has also been updated more recently.

Hi @dceejay,
I have update the fork with the requested and reviewed changes!
Best,
Muhammad Rohan Ali Asmat

Looks good - will check it more thoroughly tomorrow then release.
Many thanks for you contribution.

Hi - looking at it some more - I have changed the clear to be an empty string "" and added a check to see that the search is a string. Pushed to master - not quite released. :-)

Long as it works for you will push it out now

Great! Many Thanks!


issue with Context.deepdiveHome

Hi all,
I am working through the tutorial, and running this inference rule (http://deepdive.stanford.edu/doc/basics/walkthrough/walkthrough.html#inference_rules), fails with this error (cannot find tobinary.py):
http://pastebin.com/5XWLcMGm
It looks like the error comes from scala/org/deepdive/inference/datastore/SQLInferenceDataStore.scala on line 918:
val cmd = s"python ${Context.deepdiveHome}/util/tobinary.py ${groundingPath}
It looks like Context.deepdiveHome is being set to "/home/ec2-user/" instead of "/home/ec2-user/deepdive". In scala/org/deepdive/Context.scala, this happens if the "DEEPDIVE_HOME" environment variable is not found.
But DEEPDIVE_HOME is set:
$ echo $DEEPDIVE_HOME
/home/ec2-user/deepdive
I am running Deepdive from the latest master branch.
I am also running the inference rule independently as its own task in a pipeline.
    "f_has_spouse_features"
]```

```pipeline.run: "current"```

Thoughts?

Thanks,
Sam

@zifeishan Do you have any idea on this?

I figured it out. tutorial_example/step1-basic/run.sh exports DEEPDIVE_DIR with an extra ../. It is the right number when you run it from the examples directory, but too many if you copy it to app/spouse.
The tutorial made it seem like I should make $APP_HOME and $DEEPDIVE_HOME into global environment variables, so I was surprised that they were overwritten.


Upgrade to GHC 9.4.4

https://discourse.haskell.org/t/ghc-9-4-4-is-now-available/5481

[ ] I manually tested the code locally to make sure that it works.
[ ] If there is documentation, I made sure it's accurate and up to date.
[ ] If possible, I wrote automated tests for the new behavior.

Blocked by #21.


Cropping without showing the UI?

Hi,
Is it possible to crop an image without showing the UI? By preserved Transformation information.

Currently, it is not supported by Mantis.
It might be possible, but I need to take a look at it later.

Hi @guoyingtao
Thank you for your answer.
Currently I'm opening an transparent CropController and get the result back from it, but it doesn't feel good to do that.
So I would appreciate if you can spend some time on this.
cropViewController.modalPresentationStyle = .overCurrentContext
cropViewController.delegate = self
cropViewController.view.isOpaque = false
cropViewController.view.backgroundColor = .clear
cropViewController.view.isHidden = true
viewController.present(cropViewController, animated: true)

DispatchQueue.main.asyncAfter(deadline: DispatchTime.now() + 0.5) {
     cropViewController.crop()
}

I will take a look at it this weekend but I am not sure if I can make it.

I found there is already an API for cropping in Mantis but I forgot to provide a way to export CropInfo 😂
public func getCroppedImage(byCropInfo info: CropInfo, andImage image: UIImage) -> UIImage?

I think if I update CropViewControllerDelegate by adding CropInfo for exporting crop information, then you can use Mantis.getCroppedImage(byCropInfo:andImage:) to crop images without showing UI
func cropViewControllerDidCrop(_ cropViewController: CropViewController,
                                   cropped: UIImage,
                                   transformation: Transformation,
                                   cropInfo: CropInfo)

Wonderful, so please expose that method.

@Mehdi-Sohrabi0 I released Mantis 1.9.0 which exposes crop info in cropViewControllerDidCrop. Then you can use Mantis.crop(image:by:) to get the cropped image by exposed crop info.
Please let me know if you have any questions.

tnx a lot.


Backport 1.3: Resource leak fix on windows

Fix a resource leak on windows platform, in mbedtls_x509_crt_parse_path,
in case a failure. when an error occurs, goto cleanup, and free the
resource, instead of returning error code immediately.

Back ported from https://github.com/ARMmbed/mbedtls/pull/738

Reviewed, approved, tested and merged with mbedtls-1.3.


docs(): add instructions for mac apps

Closes https://github.com/jwilm/alacritty/issues/687

Copy has been update from feedback.

Thanks for the PR!


[server] Ensure pak size fit MAX_INT instead of silent truncate

downloadSize is int, but FS::offset_t is int64_t.
So pak of size > INT_MAX is silently truncated to int one and may contain bad data.
MSG_WriteLong accepts int, so can't just change downloadSize to int64. Also client contract uses int.

Looks OK, will merge when 0.52 release is finialized.


Update Electron and TypeScript to last versions

This pull request, update all dependencies to latest versions, and fixes some vulnerabilities. Also this use new API for load file.

Thanks 👍


Handle error condition where schema field can not be found in TableSchemaBuilder.

I ran into an NullPointerException with the database I am running Debezium against.
This seems to fix it. Will create an JIRA issue too

Thanks! When filing the Jira issue, can you please add the stacktrace you
get and then also reference the issue number in the commit message. Thanks
again.

Ok, so I've logged https://issues.redhat.com/browse/DBZ-2166 and will reword the commit message to reference it. Note this only will make for a more meaningful error message, the underlying issue is still an open question: why do we receive a column value for an unknown columns. If you could share steps for reproducing this, that'd be appreciated very much. Thanks!

Rebased and applied. Thanks, @mozinator!


feat: proxy for browser to systems

better ready ping

Looks good! Just have a read through my comments before merging. When receiving data from the UI we should make it so it receives a JSON/Dictionary object:

yea i'm down, should i set that up in a different PR or this one?

Yeah just add it to this PR and we’ll be good for merge after another
review!
On Thu, Mar 18, 2021 at 1:24 PM DhyeyLalseta @.***>
wrote:

Looks good! Just have a read through my comments before merging. When
receiving data from the UI we should make it so it receives a
JSON/Dictionary object:
[image: image]
https://user-images.githubusercontent.com/14501811/111684756-b8f49380-87ec-11eb-8441-e179ba5e9969.png
yea i'm down, should i set that up in a different PR or this one?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/relectric-car-team/systems/pull/43#issuecomment-802224641,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADOUPM5QGKDQ75SG6UTE6E3TEJHP5ANCNFSM4ZNHFE2A
.


Compile with O2

Compile with O2 instead of Os for better performance.

A previous PR was made for O3 optimizations, but O2 is much more stable and has faster compile times.


Update Introduction.md with latest nuget naming

Change from deprecated version to current.

Docs for Toolkit PR #
What changes to the docs does this PR provide?

References non-deprecated nuget.

Learn Build status updates of commit 86604e3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/mvvm/Introduction.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Hi @xtrsys, sorry for the delay in looking at this PR. This doc has been migrated to our new docs repo: https://github.com/MicrosoftDocs/CommunityToolkit/blob/main/docs/mvvm/Introduction.md - I believe all the package names were updated as part of that move, but would you mind checking if this fix still needs to be applied there? Thanks!


[tests-only] refactor json test

Related: Fixes #https://github.com/JankariTech/Technical/issues/156

Re-implemented on https://github.com/cs3org/reva/pull/1043
Closed because of accidentally forced push!

why the changes in go.mod go.sum and .drone.yml?

That was because the branch wasn't rebased with the lastest master properly! Fixed now!

@kiranparajuli589 PR https://github.com/cs3org/reva/pull/1014 was merged.
So I guess this PR can be closed?


Failed to load mod

Invalid Parameter.
Using the latest version of the mod (1.2.7) on Factorio version 1.160

Any help appreciated

I think the zip file was corrupted. I beleive I have fixed this by cloning the git repository and recreating the zip file.

Could've gotten corrupted while downloading? Can't find anything obviously wrong with 1.2.7 .zip in the mod portal. I don't know if Factorio validates checksums of downloads but it migh even be a dying storage problem?
Also try updating to 1.2.8 in-game or from mod portal, I forgot to push the fix commit so this repo is still 1.2.7


fix: Argo events generate workflow name using epoch time cause duplicate name.

Fixes #6732
This code remove wf.name and leave wf.generateName do it.
Signed-off-by: Thisadee Preeyawongsakul<EMAIL_ADDRESS>

I think this probably needs to use create a random name in the same way that a deployment would - i.e. random hex suffix. Thoughts @jessesuen @whynowy

This has been fixed in another PR.