Add a yaml file to manage session level configuration When the kyuubi service supports accessing multiple engine clusters

Why are the changes needed?

When a kyuubi service connections to multiple engine clusters, we can only explicitly specify relevant parameters after the URL, for example:
beeline -u 'jdbc:hive2://<IP_ADDRESS>:10009/?kyuubi.engineEnv.FLINK_HOME=/opt/flink;kyuubi.ha.namespace=kyuubi-ns-c;kyuubi.engine.type=FLINK_SQL'
This method is extremely unfriendly to users, and it is extremely unsafe to expose namespaces to users.
So I added a yaml file(engine-cluster-env.yaml) to manage the engine clusters, so that we can use this cluster only by specifying a unique engine name, for example:
use cluster-a:
beeline -u 'jdbc:hive2://<IP_ADDRESS>:10009/?kyuubi.engine.cluster.name=cluster-a'
use cluster-c:
beeline -u 'jdbc:hive2://<IP_ADDRESS>:10009/?kyuubi.engine.cluster.name=cluster-c'
engine-cluster-env.yaml configuration is as follows:

cluster-a:
  conf:
    "kyuubi.ha.namespace": kyuubi-ns-a
    "kyuubi.engine.type": SPARK_SQL
    "kyuubi.engine.pool.balance.policy": POLLING
  env:
    SPARK_HOME: /opt/spark
    HADOOP_CONF_DIR: /opt/hadoop_conf_dir

cluster-b:
  conf:
    "kyuubi.ha.namespace": kyuubi-ns-b
    "kyuubi.engine.type": SPARK_SQL
    "kyuubi.engine.pool.balance.policy": POLLING
  env:
    SPARK_HOME: /opt/spark2
    HADOOP_CONF_DIR: /opt/hadoop_conf_dir2

cluster-c:
  conf:
    "kyuubi.ha.namespace": kyuubi-ns-c
    "kyuubi.engine.type": FLINK_SQL
    "kyuubi.engine.pool.balance.policy": POLLING
  env:
    FLINK_HOME: /opt/flink

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

It looks like kyuubi.session.conf.tag instead of cluster.

It looks like kyuubi.session.conf.tag instead of cluster.

Sorry for the trouble caused by the inappropriate title, which has been corrected

Codecov Report

Merging #3742 (51729d1) into master (f21ad83) will decrease coverage by 0.04%.
The diff coverage is 25.00%.

:exclamation: Current head 51729d1 differs from pull request most recent head b524c22. Consider uploading reports for the commit b524c22 to get more accurate results

@@             Coverage Diff              @@
##             master    #3742      +/-   ##
============================================
- Coverage     52.57%   52.52%   -0.05%
  Complexity       13       13
============================================
  Files           492      492
  Lines         27705    27729      +24
  Branches       3830     3836       +6
============================================
  Hits          14566    14566
- Misses        11751    11773      +22
- Partials       1388     1390       +2

Impacted Files
Coverage Δ

...ain/scala/org/apache/kyuubi/engine/EngineRef.scala
65.33% <10.00%> (-8.52%)
:arrow_down:

...in/scala/org/apache/kyuubi/config/KyuubiConf.scala
97.47% <100.00%> (-0.07%)
:arrow_down:

...apache/kyuubi/engine/JpsApplicationOperation.scala
77.41% <0.00%> (-3.23%)
:arrow_down:

...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala
89.27% <0.00%> (-0.70%)
:arrow_down:

...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala
80.74% <0.00%> (-0.63%)
:arrow_down:

...he/kyuubi/ha/client/etcd/EtcdDiscoveryClient.scala
67.64% <0.00%> (-0.59%)
:arrow_down:

...g/apache/kyuubi/operation/BatchJobSubmission.scala
74.64% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Could you use guava local cache？

done

Could you use guava local cache？

done

Some confusion on the pr description:

and it is extremely unsafe to expose namespaces to users.

Customer can check it on spark UI, environments tab.
Customer can check it with sql command set spark.kyuubi.ha.namespace.

Some confusion on the pr description:

and it is extremely unsafe to expose namespaces to users.

Customer can check it on spark UI, environments tab.
Customer can check it with sql command set spark.kyuubi.ha.namespace.

removed

Thanks @ychris78 and all reviewers, merging to master

Thanks @ychris78 and all reviewers, merging to master

thanks, merged to master


Move BCFTOOLS convert to vcf extract

Description of feature
Generate and use only one posfile format.
### Tasks

Future improvements should include creating a posfile that can be used by all tools with the least amount of transformation steps.
We could only convert once the panel then use the generate posfile for all imputation subworkflow and in each of them convert to the right format.


change the ladders in towers to water with structure voids

this would be to fix towers being unplayable as 2 of the teams in 4 teams mode

DONE


Title: Monopoly Game using javascript

Is your feature request related to a problem? Please describe.
Monopoly is a classic board game where players compete to acquire wealth through buying, renting, and trading properties. The objective is to drive opponents into bankruptcy, thus becoming the richest player by the end of the game.
Describe the solution you'd like.
Players: 2 to 8 players.
Board: The board consists of 40 spaces, including 28 properties, 3 Chance spaces, 3 Community Chest spaces, 4 railroads, 2 utilities, a "Go" space, a "Jail" space, a "Free Parking" space, and a "Go to Jail" space.
Tokens: Each player selects a token to move around the board.
Money: Players start with a set amount of money.
Describe alternatives you've considered.
Turns: Players take turns rolling two six-sided dice.
Movement: Players move their tokens the number of spaces indicated by the dice roll.
Property Transactions:
Buying: If a player lands on an unowned property, they can buy it.
Rent: If the property is owned, the player must pay rent to the owner.
Chance and Community Chest: Players draw cards that can result in various outcomes, such as paying fines, earning money, or moving to different board spaces.
Special Spaces:
Go: Players collect $200 each time they pass "Go".
Jail: Players can be sent to jail and must either roll doubles, use a "Get Out of Jail Free" card, or pay a fee to get out.
Free Parking: A neutral space where nothing happens.
Go to Jail: Sends the player directly to jail.
Development: Players can build houses and hotels on their properties to increase the rent they can charge.
Trading: Players can trade properties, money, and cards.
Bankruptcy: When a player cannot pay what they owe, they go bankrupt and are out of the game. Their assets are distributed to their creditors or returned to the bank.
Winning: The game ends when all but one player is bankrupt, or a set time limit is reached, and the wealthiest player wins.
Add any other context or screenshots about the feature request here.

Assign this project to me under GSSOC

@Damini2004 Thank you for providing your insight but it is not required as of now


Import doesn't work.

Hi, there is an issue with the import.

Using:
import filterReplace from 'vite-plugin-filter-replace';

P.S it works if I use the plugin like this:

I'm not able to get this plugin to work in my Vite setup.
When using import filterReplace from 'vite-plugin-filter-replace'; as shown in the instructions, I get this error:

TypeError: replace is not a function

When using import filterReplace from 'vite-plugin-filter-replace'; like above, I get this error:

TypeError: filterReplace is not a function

When using import filterReplace from 'vite-plugin-filter-replace'; along with filterReplace.default() it builds OK, but I get the eslint error below and the replacement doesn't happen:

Property 'default' does not exist on type '(replacements?: Replacement[], options?: Options) => Plugin_2'.

@ikeq help

The docs seem to be updated now. Try:
‘import replace from 'vite-plugin-filter-replace';’

based on the tip from @thdoan above i modified for current docs. this worked:
  plugins: [
-   replace([
+   replace.default([
      {
        filter: /\.json$/,
        replace: {
          from: /__formula__/g,
          to: "foo",
        },
      },
    ]),
  ],

Fixed in latest commit - https://github.com/ikeq/vite-plugin-filter-replace/commit/b2a46729c2f7cd24336356677a8322717a2e9134


fix(upgrade,ndm): component ndm label on 0.9-1.0 pre-upgrade script

Fix this error message when executing pre-upgrade.sh from 0.9 to 1.0
Failed to get ndm daemonset name in namespace: openebs

The label used openebs.io/component-name=ndm is for deployment, for the pods is component=ndm.

@sdelrio thanks for pointing out the changes , there are some label changes has been done in openebs stable/charts as part of  0.9.2 chart version, that means user has to update to 0.9.2 chart version, before upgrading to 1.0.0 openebs version.
Deployed openebs helm chart version can be verified using helm list command.
$ helm list
NAME      REVISION        UPDATED                   STATUS          CHART           APP VERSION     NAMESPACE
openebs      3      Mon Jun 24 20:57:05 2019        DEPLOYED        openebs-0.9.2   0.9.0           openebs

I have updated the upgrade steps as part of PR https://github.com/openebs/openebs/pull/2647 with more information.

After updateing to 0.9.2 went lot better.
Thank you very much @prateekpandey14 !
$ helm ls openebs
NAME    REVISION        UPDATED                         STATUS          CHART           APP VERSION     NAMESPACE
openebs 13              Tue Jun 25 17:48:33 2019        DEPLOYED        openebs-0.9.2   0.9.0           openebs

$ kubectl get pod -n openebs -l openebs.io/component-name=ndm
NAME                READY   STATUS    RESTARTS   AGE
openebs-ndm-cqr4x   1/1     Running   0          2m21s
openebs-ndm-sm6sv   1/1     Running   0          2m1s

$ ./pre-upgrade.sh openebs helm
customresourcedefinition.apiextensions.k8s.io/blockdeviceclaims.openebs.io unchanged
Pre-Upgrade is successfull Please update openebs components


feat: make cache eviction configurable in init container

Change the cache eviction to a setting we can configure using parameter store

bors r+


Possibly partition tests that hit the OpenAI API from those that don't

I'd noticed that running the full test suite uses the OpenAI API, which consumes a modest amount of credits. It also takes a little while for the requests to go through, since it's hitting an external service.
This is just a proposal, so feel free to decline and close this if you disagree. Anyway, what if we were to partition the tests into, say, full integration tests that could potentially cost money, and non-integration tests that just test our code? If a non-integration test needs an API response, we could mock it or otherwise return a locally-cached response. I imagine we could iterate more quickly and also integrate it safely into a CI/CD system if we could run just the subset of tests that test our code.

This is an important point that needs to be addressed (maybe in the next iteration?). In the current code, I tried to do something like this by putting all unit tests that hit the API into test_model_revision.py, so that could be a quick and dirty solution to this issue.
Nonetheless, I think that using unit tests to test prompts is not the best idea. One possibility is to try something like OpenAI Evals, as briefly described here.

Just wanted to upvote this idea, I think it'd be useful to distinguish the OpenAI tests. Maybe pytest's custom markers could be used here with the existing test suite structure? This could also be extended to account for additional markers beyond the scope of just this issue and be configured with certain defaults, etc.

I'm inclined to completely remove any prompt testing that involves hitting an external, expensive API from the unit tests, and only leave tests that can be run locally for free. The current unit tests that do that should probably be moved to another framework for prompt evaluation such as OpenAI Evals. We could potentially leave some small integration tests that hit a local model and use pytest functionality to run them or not depending on whether the host has a GPU or not.

Agreed about moving the tests that run at cost to another framework. In the meantime, just to show how @d33bs's suggestion about using markers would work, I went ahead and implemented them in PR #33 and marked all the tests in test_model_revision.py as "cost". We can use that implementation as a starting point for, say, your GPU testing idea, @miltondp. We can probably infer whether the user has a GPU and use that as the default value, but it's still IMHO nice for users to be able to conditionally enable/disable the feature.

#51 might be useful here


AuthenticationProvider dynamically add/change extraQueryParams

Hello,
I want to dynamically change extraQueryParams in the AuthenticationProvider. Depending on my user clicking register or login I want to set a specific query param in the redirect to the identity server so when I call the consumer login, that specific param would be set.
Is there anyway to handle this or has someone come across this before?
Thanks!

I was actually looking to do the same. Did you close the issue because you found out a solution?

I was actually looking to do the same. Did you close the issue because you found out a solution?

Well, actually after trying out few things, I realized that it's working as expected. Even if not part of the code, nor the example, oidc-client will automatically picked up the extraQueryParams from the configuration. Just in case someone have the same issue, it should look like that:
const configuration = {
    authority: ...,
    client_id: ...,
    extraQueryParams: {
      key: value
    },
    ...
  }
 <AuthenticationProvider
      configuration={configuration}
      isEnabled={true}
      UserStore={InMemoryWebStorage}>
   <Provider store={store}>
       <BrowserRouter >
          <App />
       </BrowserRouter>
   </Provider>
</AuthenticationProvider>

Well, actually after trying out few things, I realized that it's working as expected. Even if not part of the code, nor the example, oidc-client will automatically picked up the extraQueryParams from the configuration. Just in case someone have the same issue, it should look like that:
const configuration = {
    authority: ...,
    client_id: ...,
    extraQueryParams: {
      key: value
    },
    ...
  }
 <AuthenticationProvider
      configuration={configuration}
      isEnabled={true}
      UserStore={InMemoryWebStorage}>
   <Provider store={store}>
       <BrowserRouter >
          <App />
       </BrowserRouter>
   </Provider>
</AuthenticationProvider>

Our project originally had two separate buttons in our react-app one for registration and login that needed to open a separate page on our IM. I wanted to able to edit the extraQueryParams after the AuthenticationProvider was established. I did find a way to change the settings, but I can't find the code anymore. We ended up moving the login/register buttons into IM itself and have a single button in the react-app.
If you really need to update them after the AuthenticationProvider is created, I can try to find my changes. I vaguely remember updating something like .settings.extraQueryParams.

Our project originally had two separate buttons in our react-app one for registration and login that needed to open a separate page on our IM. I wanted to able to edit the extraQueryParams after the AuthenticationProvider was established. I did find a way to change the settings, but I can't find the code anymore. We ended up moving the login/register buttons into IM itself and have a single button in the react-app.
If you really need to update them after the AuthenticationProvider is created, I can try to find my changes. I vaguely remember updating something like .settings.extraQueryParams.


Why the web... "Long lasting"

This might need to be changed a bit because all browsers deprecate features etc showModalDialog for example.

@pbakaus can you please address

I think this one holds true. Sure, there are exceptions, but very few if you look closely. The paragraph is worded in a way that doesn't explicitely promise backward compability ("it means that your users will probably be able to use your site 20 years from now"), so I think it's OK.

(accidentally closed, close if you think this addresses your concern).


Error casting nested type of maps to string

RETURN cast(cast("{{1=1}={2=2}}", "MAP(MAP(INT64, INT64), MAP(INT64, INT64))"), "STRING"); causes Assertion failed in file "kuzu/src/common/type_utils.cpp" on line 52: KU_UNREACHABLE
And after adding
case LogicalTypeID::MAP:         return TypeUtils::toString(*reinterpret_cast<const map_entry_t*>(value), valueVector); to type_utils.cpp
Assertion failed in file "kuzu/src/include/common/types/types.h" on line 385: type->getLogicalTypeID() == LogicalTypeID::MAP

I can no longer reproduce this so I assume the bug has been fixed.


Make react a peer dependency

The react dependency should be put to the peerDependency segment of the packages.json. Projects with different react versions cannot use this lib:
http://blog.nodejs.org/2013/02/07/peer-dependencies/

@tbo, Moved react to peer dependency.

@akiran Could you also move react-dom to a peer dependency?


ReflectiveValidatorIndex fails when option java_multiple_files=true

When the protobuf option java_multiple_files=true is set, generated protobuf type names no longer align with what ReflectiveValidatorIndex expects.
Work around: remove java_multiple_files=true
Fixes #185

So does this mean if someone has this option set in their source, they won't be able to use PGV?

Yes, but I'm working on a fix.

🎉 I was able to fix Java multiple-file validation by making the Java generator produce the same file hierarchy as protobuf. Since the type hierarchy lines up, everything works.

Is it updated in oss.sonatype.org? Or will do that a bit later?
Because "https://oss.sonatype.org/content/repositories/snapshots/io/envoyproxy/protoc-gen-validate/protoc-gen-validate/0.1.0-SNAPSHOT/" seems a bit older and generated code looks same as before, but maybe I just trying to fast.

It will be updated on the SNAPSHOT repo once this PR is merged.

@rodaine Does this look ready to merge 😁

@rmichela Hit with the issue? Can we please merge the fix?

@rodaine Small nudge :D


Implement AudioControl

See Mozilla Bug 1167690 and the wiki. This should hopefully allow Firefox to show a sound playing indicator in the near future.

Are there any browsers with that feature support, by any chance?

See the Mozilla Bug and some of its blockers/dependencies. They are actively working on implementing this.

Implemented in https://github.com/i-rinat/freshplayerplugin/compare/a317c4cc528a3fc868e5768071737117e633dc94...5251ec7c9b9195fe48525747b18ead5e26ac248f.

Browser-side code is already in Firefox Nightly, so you could check it out.


Remove auth exclusion test

This PR is the next part of #6056 that already remove mtlsExcludeServices flag. Tests in tests/e2e/tests/pilot/authn_policy_test.go already cover the same functionalities of this test.

/assign @baodongli

@diemtvu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8ebe88f9b4397ad70d1cee087c81f6bf6a08074e
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: baodongli, diemtvu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS [baodongli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@diemtvu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8ebe88f9b4397ad70d1cee087c81f6bf6a08074e
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Search returns empty array

Followed the usage example, just returns [] for everything. Doesn't seem to be working for me.

La librairie renvoie un tableau vide depuis la dernière mise à jour, vous pouvez prendre le commit https://github.com/appit-online/youtube-search/commit/20cb72b131f2db418ee83f25ef5d12bd06ed95a2 qui marche très bien pour moi

The library returns an empty array since the last update, you can take the commit https://github.com/appit-online/youtube-search/commit/20cb72b131f2db418ee83f25ef5d12bd06ed95a2 which works fine for me

I just updated to v1.1.0 and it returned an empty array but still, but the previous version still works fine. I'll stick to that for now

Same error on the lastest version, just degraded to 1.0.7 and all fine!

same error here!
changed version to 1.0.7 worked previously but now it returns an empty array as well!
any news ?

same here

switched to 'usetube'

i copy some functions and make my own version, you can take look at https://github.com/dimaslanjaka/yt2mp3

usetube

@dimaslanjaka
Poorly Documented

usetube

@dimaslanjaka
Poorly Documented

downloader https://github.com/dimaslanjaka/yt2mp3/blob/master/src/YTDL-downloader.js
search query https://github.com/dimaslanjaka/yt2mp3/blob/56d0740fa2ed4d51c03a98d9502cdd6a9e900268/src/YTDL.js#L209


Use Lychee directly instead of going through Baler

This workflow has been tested in https://github.com/eecavanna/nmdc-schema-temp/commit/e3fc8235bdb7cfcad1fce98f85fb66f715b8aeb6 (it works). It basically does the same thing as the Baler-based would have done. Baler uses this (Lychee) under the hood.
This workflow takes about 90 seconds to run.

Here's an example of a GitHub Issue created by it: https://github.com/eecavanna/nmdc-schema-temp/issues/2. We can go through that report and come up with some Lychee configuration that ignores certain types of errors. I'd prefer to have this be merged in, run it in this repo (its trigger is still a manual one), then create an issue about customizing Lychee's configuration to be tolerant of whatever you consider to be a false positive.

Thanks, @sujaypatil96. I am excited, too. Once it is merged in, any of us will be able to run it on demand (via the "Actions" tab here on GitHub).
Once it is merged in and has been run, we can create an ticket about tweaking lychee's configuration/parameters so that it doesn't report so many (or any) false positives.
Once the configuration has been tweaked like that, we could make it so that the GHA workflow is triggered by more events, such as PRs being created or merged. That way, the link checking would happen in response to code changes and not just when people click a button on the GitHub GUI.


repositories added with apt::ppa are purged by apt

Describe the Bug
I have set these options:
class { 'apt':
  purge  => {
    'sources.list'   => true,
    'sources.list.d' => true,
  }
}

then I add:
apt::ppa { 'ppa:deadsnakes/ppa': }

the repo name is taken here: deadsnakes-ppa
and every time Puppet runs the repo is added and then it's removed, again and again.
Expected Behavior
it should not purge the repository added through apt::ppa
Steps to Reproduce
see above
Environment

puppetlabs/apt version: 9.0.0
puppet agent and server version: 7.xx
Platform: Ubuntu 20.04

Additional Context
N/A

solved by #1069


Location error callback not triggering when Android/iOS permission is withdrawn

The location error callback method is not firing whenever iOS or Android permissions are withdrawn. Is this the intended behavior?

Hey @gijsstegehuis just implemented this on Android and iOS, try latest commit.


Detroit - Remove SRO's from filters

As a resident,
I no longer want to see SRO
Because it's not a viable option in Detroit
Acceptance Criteria

When I open the filter for unit types, then I will no longer see SRO as an option
When I open the unit group modal in Partners, it should be removed there too

Notes

Check if any current listings have SRO set - if any, might need migration

QA Notes:
Start here: https://detroit-public-dev.netlify.app/listings

Click Filter
You should notice that the SRO option is no longer available
Then go to the partner's side: https://detroit-partners-dev.netlify.app/
Sign in
Click add a listing
Scroll down and click to create 'add a group'
Notice that the SRO classification is not available there either.

LGTM


Test not passed

-We appreciate your business. And we hope you'll check out our new products [http://example.com/] !
+We appreciate your business. And we hope you'll check out our new products [http://example.com/]!

Don't worry this test has to fail. This is a known bug where currently no solution is available for.

Later for pr


cas 194 - remove threshold at community level

Removes threshold from DB, Community Struct and community model methods.
Checks Tests

Community Struct and column in DB had two fields proposal_threshold and threshold, of different types. Also the Contract struct has also a threshold field.
The front end only uses proposal_threshold field as payload, so this dup threshold field was creating confusion. enforceCommunityRestrictions parses proposal_threshold and does nothing with Community.threshold. It does use Contract.threshold, as intended.
N.B
I'm Unable to test through the front end at the moment due to this error I'm getting when I run yarn start``Error: Cannot find module @babel/helper-get-function-arity, I have ran yarn install inside /frontend.

don't merge yet, checking another case with this.


Deprecation warning when compiling base

When building the project, a warning pops up in the console:
<...>/base/base/generated/main/java/com/google/protobuf/compiler/PluginProtos.java:1206: warning: [deprecation] PARSER in FileDescriptorProto has been deprecated
                  input.readMessage(com.google.protobuf.DescriptorProtos.FileDescriptorProto.PARSER, extensionRegistry));

Note that the warning points to a generated class from the Protobuf standard library.

We can add @Generated manually after protoc finishes. It should make Error Prone happy.
See related issues in:

Protobuf: https://github.com/protocolbuffers/protobuf/issues/2513

No longer relevant.


Document Windows installation

The Windows installation is surprisingly simple, at least with VS.

Tried this and not building for me, but could have missed something obvious.
git clone https://github.com/microsoft/vcpkg
.\vcpkg\bootstrap-vcpkg.bat -disableMetrics
.\vcpkg\vcpkg install libheif
.\vcpkg\vcpkg integrate install

# System restart

set LIB="C:\Users\Chris\projects\vcpkg\packages\libheif_x86-windows\lib"
set INCLUDE="C:\Users\Chris\projects\vcpkg\packages\libheif_x86-windows\include"

pip install pyheif --user

Errors with:
Installing collected packages: pyheif
  Running setup.py install for pyheif ... error
  error: subprocess-exited-with-error

  × Running setup.py install for pyheif did not run successfully.
  │ exit code: 1
  ╰─> [9 lines of output]
      running install
      C:\Program Files\Python310\lib\site-packages\setuptools\command\install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
        warnings.warn(
      running build
      running build_py
      running build_ext
      generating cffi module 'build\\temp.win-amd64-3.10\\Release\\_libheif_cffi.c'
      building '_libheif_cffi' extension
      error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure

I have all the build tools, and just installed fresh x86 and 64 redists to be sure as well.

I also tried without the quotes around the lib / include and then the linker doesn't find what's needed:
    Creating library build\temp.win-amd64-3.10\Release\build\temp.win-amd64-3.10\Release\_libheif_cffi.lib and object build\temp.win-amd64-3.10\Release\build\temp.win-amd64-3.10\Release\_libheif_cffi.exp
    _libheif_cffi.obj : error LNK2001: unresolved external symbol __imp_heif_get_version_number_minor
    _libheif_cffi.obj : error LNK2001: unresolved external symbol __imp_heif_image_handle_release
    ...
    build\lib.win-amd64-3.10\_libheif_cffi.pyd : fatal error LNK1120: 71 unresolved externals
    error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\VC\\Tools\\MSVC\\14.29.30133\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120

You wiped out your compiler's LIB and INCLUDE by erasing the %LIB%; and %INCLUDE%; in those lines. It should also not be quoted, though I think it might be able to handle that anyway.

Sorry, I didn't see edit 2. Hm. Good question. Both x86 and x64 toolchains can cross-compile, but it'd still be necessary to set a specific target.


chore(*): ignore files with .example.ts extension

Description
Allow for .example.ts files to be included in src, but ignored by the TypeScript compiler.
Breaking Changes
None
JIRA Link
N/A
Checklist

[ ] Updated the Readme.md (if required) ?

I did this for the approval signing manager already. This makes it consistent across the managers.

:tada: This PR is included in version<EMAIL_ADDRESS>:tada:
The release is available on:

npm package (@latest dist-tag) :package::rocket:
GitHub release :package::rocket:

:tada: This PR is included in version<EMAIL_ADDRESS>:tada:
The release is available on:

npm package (@latest dist-tag) :package::rocket:
GitHub release :package::rocket:

:tada: This PR is included in version<EMAIL_ADDRESS>:tada:
The release is available on:

npm package (@latest dist-tag) :package::rocket:
GitHub release :package::rocket:

:tada: This PR is included in version<EMAIL_ADDRESS>:tada:
The release is available on:

npm package (@latest dist-tag) :package::rocket:
GitHub release :package::rocket:


Correct commit message formatting

Title message and full commit message must be delimited with an empty line,
otherwise CLI tools take full commit message as a part of title message.
Signed-off-by: Jakub Filak<EMAIL_ADDRESS>

Okay, do you have an example where it does not work?

Here you are:
$ git show --pretty=short 1c4769be135ebe92df26c9c6dabe9586f75848d8
commit 1c4769be135ebe92df26c9c6dabe9586f75848d8
Author: XXX<EMAIL_ADDRESS>
    Short message
    Body

$ git log --oneline
1c4769b Short message Body

However, the expected output is the following:
$ git log --oneline
1c4769b Short message

I'll write more verbose commit messages next time ;)

did some testing, will need to look through some more code to check that this fix will not cause problems somewhere else


Pre-defined "soft" and "hard" podAntiAffinity in default starter ?

In kube-prometheus-stack chart, we can see "soft" and "hard" pre-defined podAntiAffinity in prometheus.yaml. I've seen this in several charts before. Is it possible to have this in default helm starter (helm create) ? It would be useful because generally, podAntiAffinity use the same labels as selectorLabels, so we could use _helpers.tpl to template the default "hard" and "soft" podAntiAffinity with the app.kubernetes.io/name and app.kubernetes.io/instance default selector labels. Without that, the selector labels could be changed but not the podAntiAffinity.
Maybe define a "ready to custom" chart is not the default starter goal. I can see the probes are hard-coded in the default deployment.yaml. So maybe my question doesn't make sense.

This may be useful. Perhaps if the default values disable this by default

In general, the default chart that is generated by helm create is there to serve as a good launch point for users new to the Kubernetes ecosystem. It is not intended to be the "ultimate starter chart" that will handle everyone's use case. For that we have starter charts: https://helm.sh/docs/topics/charts/#chart-starter-packs
The resources in the default starter chart intend to provide sane defaults for someone looking to build their first chart. Think "hello world". If it doesn't fit the case where a first-time user of Helm needs to set pod anti-affinity to create their first app, I would avoid adding it to the default starter chart.

Thank you for your reply. Hope there is an "ultimate starter chart" somewhere. :) Anyway, I will do my own starter chart.


BUG: scipy.stats.nbinom.logcdf returns wrong results when some cdf values are below & others are above 0.5

Describe your issue.
The function scipy.stats.nbinom.logcdf returns wrong results for some arguments. By trying out (and looking at the implementation), this seems to happens when the input arguments would lead to an array result that mixes values larger and smaller than log(0.5). (In the implementation, there is a cond = cdf > 0.5 mask).
For example, for
n=np.array([2, 100])
p=np.array([0.1, .8])
k=np.array([ 17, 12])

we have CDF-values of
In [49]: nbinom.cdf(n=np.array([2, 100]), p=np.array([0.1, .8]), k=np.array([ 17, 12]) )
Out[49]: array([0.57973502, 0.00662863])

So we expect to find the logarithm of these two values as output of nbimon.logcdf, i.e.
In [50]: np.log(nbinom.cdf(n=np.array([2, 100]), p=np.array([0.1, .8]), k=np.array([ 17, 12]) ))
Out[50]: array([-0.54518414, -5.0163566 ])

However, something in the masking seems to be off, as the result turns out to be an array with two identical numbers:
In [48]: nbinom.logcdf(n=np.array([2, 100]), p=np.array([0.1, .8]), k=np.array([ 17, 12]) )
Out[48]: array([-0.54518414, -0.54518414])

That is, the first value has been rolled out on the entire array.
In this second example, the last two values of k have CDF < 0.5, and in the logcdf they are being assigned values from parameters that lead to CDF > 0.5:
In [55]: nbinom.cdf(n=4, p=0.3, k=np.array([ 17, 12, 8, 4, 2]) )
Out[55]: array([0.9143943 , 0.75414414, 0.50748423, 0.19410435, 0.07047   ])

In [56]: nbinom.logcdf(n=4, p=0.3, k=np.array([ 17, 12, 8, 4, 2]) )
Out[56]: array([-0.0894934 , -0.28217177, -0.67828965, -0.0894934 , -0.28217177])

In [57]: np.log(nbinom.cdf(n=4, p=0.3, k=np.array([ 17, 12, 8, 4, 2]) ))
Out[57]: array([-0.0894934 , -0.28217177, -0.67828965, -1.63935938, -2.65256819])

There was recently a PR modifying scipy.stats.nbinom.logcdf, which might be related : https://github.com/scipy/scipy/issues/16159
but I can't reproduce the above issue with scipy v1.6.3. I.e. in scipy v 1.6.3, this issue does not occur; it seems that in 1.7.x the issue is present.
Reproducing Code Example
import numpy as np
from scipy.stats import nbinom
np.testing.assert_array_almost_equal(nbinom.logcdf(n=np.array([2, 100]), p=np.array([0.1, .8]), k=np.array([ 17, 12]) ), np.log(nbinom.cdf(n=np.array([2, 100]), p=np.array([0.1, .8]), k=np.array([ 17, 12]) )))

Error message
840         err_msg += '\n' + '\n'.join(remarks)
    841         msg = build_err_msg([ox, oy], err_msg,
    842                             verbose=verbose, header=header,
    843                             names=('x', 'y'), precision=precision)
--> 844         raise AssertionError(msg)
    845 except ValueError:
    846     import traceback

AssertionError:
Arrays are not almost equal to 6 decimals

Mismatched elements: 1 / 2 (50%)
Max absolute difference: 4.47117246
Max relative difference: 0.8913187
 x: array([-0.545184, -0.545184])
 y: array([-0.545184, -5.016357])

SciPy/NumPy/Python version information
1.8.1 1.22.4 sys.version_info(major=3, minor=8, micro=5, releaselevel='final', serial=0)

Duplicates of gh-16159, i think? Fixed by gh-16160. Please confirm, @maltet21 but coding in the meantime.

you are right @mdhaber , it's just another manifestation of gh-16159, (the PR gh-16160 was merged on May 16th, the day of the release of 1.8.1, which is why I had thought scipy 1.8.1 would already contain that fix, but that PR was merged after the release; sorry for the noise). Looking forward to 1.9.0.


DNS Resovler tests should be more explicit about ndots

Motivation:
The DNS resolver may use default configuration inherited from the environment. This means the ndots value may change and result in test failure if the tests don't explicitly set the assumed value.
Modifications:

Explicitly set ndots in resolver-dns unit tests so we don't fail if the environment overrides the search domain and ndots

Result:
Unit tests are less dependent upon the enviroment they run in.
Fixes https://github.com/netty/netty/issues/6966.

@carl-mastrangelo - PTAL

As in, if I tried using DnsNameResolver do I have to set ndots there too?

If you don't set values programmatically we attempt to inherit them from the environment. If you need to be explicit for a particular use case (e.g. ignore the environment) then you should programmatically set the desired values.

4.1 (b249714a2)


Provide documentation for RequiredMode

I am updating a project from Swagger v2. I found that the required attribute of @Schema is deprecated, and requiredMode should be used instead. The default value of requiredMode is AUTO, but the javadocs don't explain what that means. Please update the documentation.

If the requiredMode parameter is set to AUTO, swagger will check upstream whether your field is marked with @NotBlank or @NotNull or ... to set the requiredMode to REQUIRED or NOT_REQUIRED otherwise.
For example :
public class Test{
    @JsonProperty("property")
    @Schema(description = "My property")
    private String property; //this field will be NOT_REQUIRED because it's not marked as @NotBlank or @NotNull or ...

    @NotBlank
    @JsonProperty("property_2")
    @Schema(description = "My property_2")
    private String property2; //this field is REQUIRED as it is marked as @NotBlank
}


Type constraints on generics

I want to use the type constraint <A> to make sure that function fn and function fn2 should return the same type A as the argument output, which specifies what is type A.
So I expect the following code to throw error, but didn't get any error.
flow try
declare function convert <A>(
  output: A,
  fn: (query: string) => A,
  fn2: (query: string) => A
): void;

// Expected errors, but didn't get
convert(
  1, // <- this value specifies type A to be number
  function(a: string) { return 1; },
  function(a: string) { return '1'; } // <- here it returns a string which is a wrong type, but flow didn't get it
);

Did I miss anything?

This comment is wrong:

this value specifies type A to be number

Flow is inferring A to be of type number | string, as you can verify by doing
declare function convert <A>(
  output: A,
  fn: (query: string) => A,
  fn2: (query: string) => A
): A;

const x: number = convert(
  1,
  function(a: string) { return 1; },
  function(a: string) { return '1'; }
);

Thanks @gabro!
Is there a way to say A is not an optional type?

You mean a union type?

You mean a union type?

Yes a union type.
I want a way to add type constraints so that the type can be either all number or all string, but not all number | string.
Is it possible?

I want a way to add type constraints so that the type can be either all number or all string, but not all number | string.

Is it possible?

No, it's not possible

Maybe with some bounded polymorphism trickery one could express type-level equality (which is what you're asking), but I can't think of a solution right now.

Maybe with some bounded polymorphism trickery

type _ExtractCodomain<B, F: (a: any) => B> = B;
type ExtractCodomain<F> = _ExtractCodomain<*, F>;

declare function convert <B, F: (query: string) => B>(
  fn: F,
  fn2: (query: string) => ExtractCodomain<F>
): B;

const x = convert(
  function(a: string) { return 1 },
  function(a: string) { return '1' } // <= string. This type is incompatible with number
)

@gcanti but why does it work? Seems to be a type inference bug

@zhangchiqing well, that's the equivalent or writing
declare function convertNumber(
  output: number,
  fn: (query: string) => number,
  fn2: (query: string) => number
): void;

so not very useful as you would need to explicitly enumerate the types you want to work with.

About @gcanti's hack, I need more coffee.

Ok, I got it. Yes, I agree with @vkurchatkin, I wouldn't expect it to happen.
It seems that if you move the type resolution of B "far enough" the type unification stops before being widened to a union type.
Not sure whether this is intended behavior...

Not sure but if F: (query: string) => B and F is (query: string) => number then B <: number, so B = number

Oh right, it makes sense! The trick is to create a dependency between the type of fn and the type of fn2. In the OP's example both types would contribute equally, but in your example F is inferred before, and that's why it works.
It seems legit!

Well, Flow fails to infer that F is (query: string) => number | string in this case

Well, given
const x = convert(
  function(a: string) { return 1 },
  function(a: string) { return '1' } // <= string. This type is incompatible with number
)

the type of function(a: string) { return 1 } is (a: string) => number.
The "trick" is to require that type to be resolved before trying to unify it with the type of the other function.

What I mean, is that I think inferring (query: string) => number | string for fn would be a mistake.

How is that different from original example? In general type inference should provider the lowest possible types that satisfy all constraints. If it's not possible, than the code doesn't type-check. In this case it's definitely possible, so I'd say that type inference fails to do its job

mm, yes, you may be right. It could just be a limitation of the type unification algorithm.

I think what we need here is a way to instantiate the type at the call location, like convert<string>(output, f1, f2).

@samwgoldman Would that in effect be per call location?
I.E. could someone annotate one call with string and one with number and both would check?
Then if there was a third call without an annotation would that coalesce somehow with the first two?

@samwgoldman I agree with @jgrund. Type definition at call-site would be lovely for a number of reasons, but I don't see how it would help in this case.

convert<string> would substitute string for T in a single call. convert<number> would substitute number for T, but the two instantiations would not interact. convert without a parameterization would behave as it does today. None of the calls would interact.

@samwgoldman true that, however it's way more limiting than the desired OP requirement, i.e. make sure that two types are exactly the same, and having the type inferred at the same time.

@vkurchatkin

How is that different from original example? In general type inference should provider lowest possible types that satisfy all constraints. If it's not possible, then the code doesn't type-check. In this case it's definitely possible, so I'd say that type inference fails to do its job

Does that mean that in the following code, Parsed should be widened to {text: string}|number and not fail? (Related: #2618)
// parser.js
/* @flow */
type _$ReturnType<B, F: (...args: any[]) => B> = B;
type $ReturnType<F> = _$ReturnType<*, F>;
export default function parser(el: HTMLElement) {
  return {text: el.textContent};
}
export type Parsed = $ReturnType<typeof parser>;

// foo.js
/* @flow */
import type {Parsed} from './parser';
const x: Parsed = 9;

I use the pattern in parser.js a lot and find the current behavior where I can infer the function's own return type in isolation very desirable.

supporting convert<number> makes sense to me.
For now, I prefer my workaround, as it's easier to understand and don't have to modify the polymorphic convert function.
Please feel free to close this issue. Or leave it open for more discussion.

@samwgoldman Thanks for explanation. Seems like that would be generally useful.

@gabro This particular behavior of Flow is a design choice. The reason we infer number | string here is the same reason we infer number | string as the return type of the following function:
function f(b) {
  if (b) {
    return 0;
  } else {
    return "";
  }
}

That is, Flow tries pretty hard to find a type that makes your program valid. If you didn't intend the union return type, an inconsistency will be discovered when you try to use the returned value as either exactly a string or a number.
One way of looking at is: inference assumes the program is correct, and tries to find a type under that assumption. You can use type annotations to make Flow work the "other way," which is why parameterizing the call has the desired effect.

@samwgoldman all clear, thanks.
I'd like to stress that I think the type unification using union types is a wonderful feature (Scala is introducing it in dotty, for example, I think it's great news). So my comment wasn't aimed to critique the type inference algorithm, at the contrary!
What I'm say is: due to how the type inference works, in order to solve the A == B problem the OP posed, we would need some extra construct, in order to constrain the inference.
In other terms, this is a simplified example of what the OP wants:
declare function foo<A>(a: A, b: A)
foo(42, 42)      // A == number, ok!
foo("foo", "foo) // A == string, ok!
foo(42, "foo")   // A == number | string, ok!

// The <A == B> constraint is imaginary syntax
declare function bar<A, B, A == B>(a: A, b: B)
foo(42, 42)      // A == B number, ok!
foo("foo", "foo) // A == B string, ok!
// $ExpectError
foo(42, "foo")   //  A == number != string == B. Flow complains!

The "typelevel equality" constraint is the missing part.
What I didn't understand of your answer is how refining a type at call site can help in the general case where I don't know the specific type I'm expecting, but I just care they are exactly the same one.

@gabro yeah, it would definitely be useful to express constraints like that on type params. This is something we're thinking about, but not near-term stuff.

@samwgoldman got it, thanks! Back to the original problem, should we consider the "hack" proposed by @gcanti (https://github.com/facebook/flow/issues/2630#issuecomment-253854124) a bug? If yes, maybe we should mark it explicitly, or people may start relying on this buggish behavior.

For me when I use a polymorphic type variable in a function the desired functionality is to constraint the type:
function eq<A>(x: A, y:A) : boolean {
    return (x === y)
}
eq(1,1)                  // Ok. A = number
eq(1,true)               // Ups, Flow no errors, A = number | boolean

Flow accepts eq(1,true), but my expectation is that Flow rejects that expression,
in this case, for me, the type is useless, equivalent to
function eq(x: any, y:any) : boolean {
    return (x === y)
}

Also, I can't check in functions things related, like if a key of type Key<A> is related whit an object of type A, etc.
function update<A>(key : Key<A>,elem : A) {
...
}

Additionally, is strange that behavior of polymorphic type variables are different in classes (invariant) than in functions (unifying with union types):
class Example<A> {
  eq(x : A, y: A) : boolean { return (x === y) }
}
let x : Example<number> = new Example();    // A instantiated to number
let eqNumber = x.eq  // eqNumber = eq(x : number,y : number)
eqNumber(1,1)       // A == number, OK
eqNumber(1,true)    // A == number, boolean != number, REJECTED.

Creating and instantiating polymorphic classes solves the problem allowing instantiation of the type variable, but I don't like this solution. For me, invariant type variables is the desired behavior and  maybe special notation for union types unification, like variant and covariant case, is more intuitive and clear for programmers.

@gcanti 's trick boils down to just:
type Exact<T> = T;

Then you can use it in
function eq<A>(x: A, y:Exact<A>) : boolean {
    return (x === y)
}

or in the original case of function return types.
But beware of subtyping, isSame({a:1}, {a:1, b:2}); will typecheck, but isSame({a:1, b:2}, {a:1}); not.

Look like Exact just bypasses type infer and making things work.
Following code will even work for isSame({a:1, b:2}, {a:1}); case.
const strictEq = <T>(one: T, two: Exact<$Exact<T>>) => one === two;

How to compare first argument in functions? I try $Exact, but it doesn't work for function arguments.
function a(v: string, s: number) {}
function b(v: number, s: string) {}
function c(v: string, s: string) {}

declare function f<Arg>(
    fn1: (arg: Arg, ...args: any[]) => any,
    fn2: (arg: $Exact<Arg>, ...args: any[]) => any
): any;

// $ExpectError
f(a, b)

// No error
f(a, c)

@theKashey
const strictEq = <T>(one: T, two: Exact<$Exact<T>>) => one === two; will complain about strictEq(0, 1) which should pass typecheck


Moving away from the NamedTuple to instead use argument splitting.

...we may move away from the NamedTuple to instead use argument splitting.

Originally posted by @seabbs in https://github.com/CDCgov/Rt-without-renewal/pull/61#pullrequestreview-1894180933

Current API
At the moment, we have the priors for any process abstracted as a NamedTuple, e.g. priors = (sigma_prior = some_dist,). These priors are then given to the Turing model constructors as a NamedTuple. At a high level, the Turing model constructors are not exposed to the user, and if users are happy to use default priors then the priors are invisible.
Problem
Our view is that it is safer code practise to have lower level functions depend as little on the hierarchy of code options as possible so that each level can be tested/iterated in as robust manner as possible.
Solution
At the lower Turing model constructor level to change the ingestion of priors into splatted keyword argument, with each prior distribution being defined as a kwarg in kwargs.... This change will be invisible to high level users because the NamedTuple of priors will be splatted to kwargs.


Fix geo bounding box with strings

Pull Request
When sending a document with one geofield of type string (i.e.: { "_geo": { "lat": 12, "lng": "13" }}), the geobounding box would exclude this document.
This PR fixes this issue by automatically parsing the string value in case we're working on a geofield.
Related issue
Fixes https://github.com/meilisearch/meilisearch/issues/3973
What does this PR do?

Automatically parse the facet value iif we're working on a geofield.
Make insta works with snapshots in loops or closure executed multiple times. (you may need to update your cli if it panics after this PR: cargo install cargo-insta).
Add one integration test in milli and in meilisearch to ensure it works forever.
Add three snapshots for the dump that mysteriously disappeared I don't know how

bors merge


Support for sqlite3_column_text16

Does sqlite3pp API supports sqlite3_column_text16 ?  Does it plan to support sqlite3_column_text16 ? Please clarify. Thank you!

The upstream C API is used in sqlite3pp.ipp.  There are no references to sqlite3_column_text16() in there.  Only sqlite_column_text().
But I can see how this could be easy to add:
  inline char const* query::rows::get(int idx, char16_t const*) const
  {
    return reinterpret_cast<char16_t const*>(sqlite3_column_text16(stmt_, idx));
  }

Thank you!  Is there any plan to add the support for char16_t to query::rows::get and statement::bind in future release ?

get() and bind() added. please let me know if it has issues.


Update project to use ruff for formatting and linting

Closes #77
Update formatting and linting to use ruff.
This is based on top of handicaps-refactor branch in anticipation of #78 being merged soon.
It took me a while to get my head around ruff and play with it.
I like how configurable it is, but the fact that rules from an existing package (i.e. pylint) may be spread between other rulesets to avoid duplicates makes it tricky to get the same behaviour/how you want it.
I added some rules/rulesets that seemed sensible but didn't trigger anything - it is possible something will trigger in future with code that that feels sensible, so I am open to adding exceptions with good reason.

custom config for this project written in pyproject.toml

Apply pylint to match previous linting
Apply a bunch of flake-8 to catch pylint rules not covered by the pylint ruff extension
Apply isort
Apply pydocstyle with numpy
Apply whitespace linting
Apply ruff rules because why not
Ignore if/else -> ternary and ambiguous characters

Applied rules to code
Updated workflows to use ruff and removed old tools
Added blackdoc as ruff does not apply to .rst files

Notes:

Duplicate code warnings no longer appear, perhaps will in a future update?

ruff does not work on non-python files so needed to add blackdoc for docs.

[X] Source code updated to address issue

[X] Style and formatting applied

[x] ~Tests written to cover changes~

[x] ~Docstrings included/updated in code~

[X] Project documentation updated as necessary

@TomHall2020 I have been a bit naughty with git magic, but the tuple error messages should be gone now.
Still not entirely sure how they got in... I think I was using an older version of ruff at one point that had this as a bug (and the new version can't spot it). The ruff installed by my system package manager was overriding the one in my virtual environment. -_-

@TomHall2020 Rebased on top of main after merging your #76 and my #80 if you are now happy with this going in?

@TomHall2020 Rebased on top of main after merging your #76 and my #80 if you are now happy with this going in?

Despite the pain of thinking about rebasing #59 yet again, yeah this looks good, and I definetly won't miss waiting 10 seconds for pylint to run before each commit in the future

Despite the pain of thinking about rebasing #59 yet again, yeah this looks good, and I definitely won't miss waiting 10 seconds for pylint to run before each commit in the future

Yeah, sorry, hopefully it isn't too painful...
I think I'd prefer it this way round as linting commits are 'bad' since they touch lots of files, but not in a very useful way when trying to look back over git history to see what changed when and why.


hide "connected to"

I'm not sure what purpose this serves.

If you have multiple notebooks open with the same dataframe names then kind of nice to know you're looking at the right notebook?


Deliverable Due: Web Development Beta

[@bully]  We might need to touch base with them on the archival system next week. Let's setup a meeting so we can touch base on that

Gotcha I'll email Sarah now [@jodie]


Where does the data for translation training come from?

Hi,
I need to be able to tell where the data sets on http://ufallab.ms.mff.cuni.cz/~helcl/neuralmonkey-example-data/translation/ come from. But I didn´t found the information anywhere.
Best,
Stoyan

Hi,
I am not sure, but I think the data are a part of the EN-DE WMT data. Note
that this dataset is not complete and should not be used for any real
experiments..
J
2017-10-21 15:36 GMT+02:00 StoyanVenDimitrov<EMAIL_ADDRESS>
Hi,
I need to be able to tell where the data sets on
http://ufallab.ms.mff.cuni.cz/~helcl/neuralmonkey-example-
data/translation/ come from. But I didn´t found the information anywhere.
Best,
Stoyan
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ufal/neuralmonkey/issues/558, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABwcs8jTxrBDC4NDLsVK8DWwLpVvYS3sks5sufN5gaJpZM4QBkQY
.

Ok, then I'll take the WMT14 dataset, it will also be comparable with the results of your paper. But the link  http://www.statmt.org/wmt14/translation-task.html doesn´t work. Any idea where I can get the data from?
Best,
Stoyan

Hi,
I see here  http://www.statmt.org/wmt14/translation-task.html  multiple news corpora. Which one do you used exactly to test the NM?
Best,
Stoyan

Hi,
for the Neural Monkey paper, we used the newstest2014 FR->EN dataset (
https://ufal.mff.cuni.cz/pbml/107/art-helcl-libovicky.pdf)
J
2017-10-23 10:45 GMT+02:00 StoyanVenDimitrov<EMAIL_ADDRESS>
Hi,
I see here http://www.statmt.org/wmt14/translation-task.html multiple
news corpora. Which one do you used exactly to test the NM?
Best,
Stoyan
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ufal/neuralmonkey/issues/558#issuecomment-338589596,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABwcs785YPWKDH905Mj0IdtX1hswXEUtks5svFI9gaJpZM4QBkQY
.

Do you mean exactly the 2.3 GB 10^9 French-English corpus

No I mean the TEST set for the 2014 task. It should be few thousand
sentences at most, definitely under 5 MB.
2017-10-23 10:53 GMT+02:00 StoyanVenDimitrov<EMAIL_ADDRESS>
Do you mean exactly the 2.3 GB 10^9 French-English corpus
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ufal/neuralmonkey/issues/558#issuecomment-338591492,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABwcs70TGgTKy5UA-R6mV4E_JKAj7Uroks5svFP0gaJpZM4QBkQY
.

All right, thank you. And any idea which set you used for training:  Europarl, UN Corpus...?

For the numbers in the paper, I think we used all the data available from
the WMT website (including europarl, UN, news commentary, and others)
2017-10-23 13:29 GMT+02:00 StoyanVenDimitrov<EMAIL_ADDRESS>
All right, thank you. And any idea which set you used for training:
Europarl, UN Corpus...?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ufal/neuralmonkey/issues/558#issuecomment-338629522,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABwcs6I5OYuRYtLHtB_jsi3HvBscFRfnks5svHiHgaJpZM4QBkQY
.

Thanks, I guess I'll take only one of them... in order to finish at least a whole epoch :D

Hi, how did you converted the test set from .sgm? I have a lot of troubles with running the wrap_xml.perl from Moses and am looking for an alternative.

I think that script is used when you want to convert text to sgm, not the other way around. From SGM, it suffices that you strip the tags and leave the text.
Here's a ranfom python function that does it:
https://github.com/tensorflow/tensor2tensor/blob/9bdc801e23586321e04e743fc61dd66b10adbc1d/tensor2tensor/data_generators/translate.py#L172

You are right. Now I have everything. Thanks!


flyctl: 0.0.306 -> 0.0.308

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/flyctl/versions.
meta.description for flyctl is: "Command line tools for fly.io services"
meta.homepage for flyctl is: "https://fly.io/"
meta.changelog for flyctl is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/i4wr60wr7pcgfn36ih8y897p9df4jqyg-flyctl-0.0.308/bin/flyctl had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 0.0.308 in filename of file in /nix/store/i4wr60wr7pcgfn36ih8y897p9df4jqyg-flyctl-0.0.308

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
flyctl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/i4wr60wr7pcgfn36ih8y897p9df4jqyg-flyctl-0.0.308 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A flyctl https://github.com/r-ryantm/nixpkgs/archive/3b9915ca3f8b321a11f704740f77f969dafdb0e1.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/i4wr60wr7pcgfn36ih8y897p9df4jqyg-flyctl-0.0.308
ls -la /nix/store/i4wr60wr7pcgfn36ih8y897p9df4jqyg-flyctl-0.0.308/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

flyctl

Maintainer pings
cc @aaronjanse @jsierles @kalbasit for testing.

Result of nixpkgs-review pr 165862 run on aarch64-darwin 1

1 package built:

flyctl


Move components names to Ruler, Compactor, Querier (-er)

It's maybe a minor but we should be consistent on naming. In the documentation, code and thanos command we have rule, compact, downample, query vs in some docs, deployments and most of the presentations we are leaking Querier, Ruler, Compactor
This conflicts a bit with Store Gateway but we already have some discussion about renaming it: https://github.com/thanos-io/thanos/issues/1646
I would vote -er as it's more correct (aka go way of naming objects as well) and it avoids name collisions like rule (recording/alerting rule) vs rule (the component responsible for evaluating rules).
AC:
< to agree>
Any thoughts?

Makes sense, I agree.

Why not also change store to gateway or proxyer whilst making changes?

Same for receive -> receiver I guess (:

Anyone work on this issue? I guess I can take this 😆

Thanks. We need to decide what to do with metrics as well as they are all over the place with query rule etc, should we rename at once? @brancz any tips? (:

I think we need to be careful here as this minor consistency naming change might be not worth everywhere when introducing so many breaking changes ): Things like metrics, components will make our user life harder when upgrading.

I think updating the metrics now might not be a good option. Just update the docs first.

:+1:

I feel like for how disruptive renaming the components would be, the gain would be too small. Yes we should be consistent in the metrics and component names, but in docs and presentations for the flow of the language we can use querier, ruler, etc. but otherwise the existing component names work just fine in my opinion and don't require changing.

@kakkoyun any process about this?

Due to compatibility issues I would say we stick to docs, new places we name things like Alert names, deployment names etc.
Metrics, command, and component names in code should stay for now.

@daixiang0 This week I'll start working on this and primarily focus on docs.

I am not sure is this still valid?

@yeya24 Maybe we should break this into pieces. Like thanos-mixin/compact -> thanos-mixin/compactor,  docs/compact   -> docs/compactor and cmd/compact -> cmd/compactor etc.
WDYT?

My understanding from this issue was, we would eventually move to *tor naming schema, thus my changes.
And it's more clear now.
Just to recap. we will keep structural build blocks (code references, filenames etc.) as in commands and only rename documentation (user guideline, alert message etc). Am I right?

Definitely, we have to find something consistent (:

only changing language in sentence form
keep technical references

What exactly this means? I assume:

User -er -or in:

While speaking about components
Presentations
Documentation
Code comments (?)
Log messages, traces?

Keep the old way (and revert things that were made -er -or:

Metrics
Flags, configuration?
Code methods/structs
Package names

There are some gray areas like logging e.g which are not really tricky to change. I think we need to just put some list and agree on this. Anything else I missed?

That sounds perfect to me. I'll start applying that. Maybe it's worth documenting this in our CONTRIBUTING.md ?

Definitely will add - and let's make sure we keep it up to date

Done: https://github.com/thanos-io/thanos/pull/2094
To close this issue we probably have to look through those items and ensure consistency. I know for sure there are metrics that are sometimes compact sometimes compactor etc.

I think we’re pretty close to having all the changes down for this. Only a few metric names have to be fixed I think.


Code breaking while preprocessing context embedding file.

python jcs/text2numpy.py lexsub_contexts lexsub_contexts_out
File "/home/user/PycharmProjects/lexsub-master/jcs/text2numpy.py", line 30, in
new_matrix[i, :] = matrix[word]
ValueError: could not broadcast input array from shape (600) into shape (1)

My guess is that the reason for this is that the embeddings file you're using has a header line. If so, try to delete it and run the code again.

My guess is that the reason for this is that the embeddings file you're using has a header line. If so, try to delete it and run the code again.

i've tried removing header file and ran the same, followed by other error
Traceback (most recent call last):
File "/home/user/Software/pycharm-community-2017.3.2/helpers/pydev/pydev_run_in_console.py", line 52, in run_file
pydev_imports.execfile(file, globals, locals)  # execute the script
File "/home/user/PycharmProjects/lexsub-master/jcs/text2numpy.py", line 30, in
new_matrix[i, :] = matrix[word]
ValueError: could not broadcast input array from shape (288) into shape (600)

This seems to indicate that your embeddings file is corrupted in the sense that it contains a line with only 288 numerical values, although the dimensionality is 600.

This seems to indicate that your embeddings file is corrupted in the sense that it contains a line with only 288 numerical values, although the dimensionality is 600.

Figured it out, somehow its corrupted.
Its working fine now :+1:


Quartic extension of Babybear field

Add quartic extension of babybear field
Description
This PR adds a quartic extension field for babybear as requested in issue #539. It is based on the quadratic field extension of babybear presented in PR #629.
Type of change

[x] New feature

Checklist

[x] Linked to Github Issue
[x] Unit tests added

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cd957b1) 96.23% compared to head (dbfb503) 96.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   96.23%   96.25%   +0.01%
==========================================
  Files         133      134       +1
  Lines       29801    29879      +78
==========================================
+ Hits        28678    28759      +81
+ Misses       1123     1120       -3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@MauroToscano there is no way as far as I know to check if a field element is a quadratic nonresidue in non-prime fields without doing a brute force search. I did a short test to check if that [-1,-1] is a quadratic nonresidue.
#[test]
fn test_quadratic_nonresidue() {
    let mut result = false;
    for i in 0..2u64.pow(31) - 2u64.pow(27) + 1 {
        for j in 0..2u64.pow(31) - 2u64.pow(27) + 1 {
            let elem = QuadraticBabybearFieldElement::new([
                -FieldElement::<Babybear31PrimeField>::from(i),
                -FieldElement::<Babybear31PrimeField>::from(j),
            ]);
            if elem.pow(2u32) == QuadraticBabybearField::residue() && i != 0 && j != 0 {
                result = true;
                break;
            }
        }
        if result {
            break;
        };
    }
    assert!(!result);
}

This is stale. I am closing it for the time being


Issue with ng-app from angular-2.0.0-alpha is not working

Please see the highlighted areas, is it aa bug in the angular 2.x , I am confused.

The angular 2.x api is very different from angular 1.x. You might want to take a look at some of the examples from https://github.com/angular/angular/tree/fbd6851860a04c923efbf8f0e785929f012417a6/modules/examples/src


Pass the portforward errors to caller

This is first attempt to add retry mechanism to creation of working client.

Meant to create a draft PR :man_facepalming:

Closing this since disabling autoupdates on the nodes has solved the issue.


Provide direct 'go install' method to use as standalone cli.

Typically with go tools, its better to use the go install setup/install method, as I definitely do not what to have to clone the repo of every tool I use.

Hello @PylotLight, thank you for your comment.
I developed this project just to learn about Golang & its concurrency feature using goroutines and channels. After that I'm not able to actively work on this.
Regarding installation, you may build & install as explained in following resources (hopefully these would be useful) —

How To Build and Install Go Programs (DigitalOcean)
How To Build and Install Go Program? (GeeksforGeeks)

Thanks! :)


Modulo of scalars possibly wrong for negative arguments

I'm seeing flaky test failures in sapply(testsBasicMath, test_math), i.e., failures unless the random seed is set to lucky value.
### Testing modulo of scalars ###
function (arg1 = double(0), arg2 = double(0))
{
    out <- arg1%%arg2
    return(out)
    returnType(double(0))
}
clang++ -Qunused-arguments -I/usr/share/R/include -DNDEBUG  -I -DEIGEN_MPL2_ONLY=1 -I"/home/fritz/R/x86_64-pc-linux-gnu-library/3.4/nimble/include" -Wno-misleading-indentation -Wno-ignored-attributes -Wno-deprecated-declarations     -fpic  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -c P_202_rcFun_202.cpp -o P_202_rcFun_202.o
warning: unknown warning option '-Wno-misleading-indentation'; did you mean '-Wno-missing-declarations'? [-Wunknown-warning-option]
1 warning generated.
warning: unknown warning option '-Wno-misleading-indentation'; did you mean '-Wno-missing-declarations'? [-Wunknown-warning-option]
1 warning generated.
clang++ -Qunused-arguments -shared -L/usr/lib/R/lib -Wl,-Bsymbolic-functions -Wl,-z,relro -o P_202_rcFun_202_06_30_15_39_15.so P_202_rcFun_202.o /tmp/RtmpLkxMpS/nimble_generatedCode/nimble-tensorflow_06_30_15_32_52.so -L/usr/lib/R/lib -lR
 Show Traceback

 Rerun with Debug
 Error: Test failed: 'modulo of scalars'
* `out` not equal to `out_nfC`.
1/1 mismatches
[1] -0.106 - 0.114 == -0.22
Test of math (direct R calc vs. C nimbleFunction): modulo of scalars

Note that another test in mathTestLists.R comments that "probably ... modulo of vecs doesn't work".

Oh yeah.  IIRC, R and C behave differently for modulo with negative arguments.  We could override one or the other but never made a decision to do so.
The quote from another test seems to be out of context.  It does not say "probably" modulo of vecs doesn't work.  It says "probably" the underlying source of failure of a larger expression is known lack of modulo of vecs.  But the bigger issue is there are several known limitations that previously were written into tests as comments.  Now that we have better practices for including expected failures in tests, we should re-write those as expected failures.  I could update those tests if you don't beat me to it.

I've updated the modulo of scalars test in cleanup_testing branch so that using a positive and negative together is tested and is a known failure, as well as having a test of modulo of two positives that should success.
Also explicitly set up so modulo involving vectors is a known failure.


fix footnotes for chapters 03-06

This issue will be closed when someone has updated the footnotes in these chapters and someone else has reviewed the pull request.

[x] chapter 3 reviewed
[x] chapter 4 reviewed
[x] chapter 5 reviewed
[x] chapter 6 reviewed

@nicholasjhorton will review Adam's work.

https://github.com/STAT325-S24/HistoryAmherstCollege/commit/01ff335da89f95f84321cc38f7894042639775d9
There is a footnote on page 63 that I cannot find. Also, there is a random "5" at the bottom of page 65. It's also in the pdf, so I left it. There was also a missing page heading for page 72 that I added in

I saw a lot of random numbers at the bottom of pages in my chapters too, and they seemed to be counting up (18, 19 ...).  Does anyone know what these are?

@nicholasjhorton, have you reviewed this work?  If it looks good could you please close this issue?

This looks great, modulo two minor comments. @arogers24 can you please the two remaining issues I tagged in your commit then close this issue?

@nicholasjhorton I only saw one comment for the typo "presideint." I committed and pushed the change (https://github.com/STAT325-S24/HistoryAmherstCollege/commit/3faef5eaa84c8d14111535d9cb92709696b78b63). You said there was another one, but I couldn't find it.

Thanks!
I concur that I could only see one comment. I'm closing the issue.


Update October2018Update.md

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/release-notes/commercial/October2018Update.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/release-notes/CurrentCommercial.md
:white_check_mark:Succeeded

windows-iotcore/release-notes/commercial/October2018Update.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


WIKI Updater Tasks : Error  The path used to clone the repo vsts

Azure DevOps Extension you are using
WIKI Updater Tasks
Where are you running it?
You can run the extensions in the cloud or on-premise

Azure DevOps Service (VSTS)

Version of Extension/Task
Last public
Expected behaviour and actual behaviour
tasklog_6.log
Steps to reproduce the problem

The log shows it is a security issue, the agent account has no permissions to access the repo
019-06-03T14:06:36.6689654Z fatal: unable to update url base from redirection:
2019-06-03T14:06:36.6690228Z   asked for: https://buildagent:***@dev.azure.com/lcouveignes/POC_Deploiement_Function_Azure/_wiki/wikis/POC_Deploiement_Function_Azure.wiki/info/refs?service=git-upload-pack
2019-06-03T14:06:36.6693434Z    redirect: https://spsprodweu2.vssps.visualstudio.com/_signin?realm=dev.azure.com&reply_to=https%3A%2F%2Fdev.azure.com%2Flcouveignes%2FPOC_Deploiement_Function_Azure%2F_wiki%2Fwikis%2FPOC_Deploiement_Function_Azure.wiki%2Finfo%2Frefs%3Fservice%3Dgit-upload-pack&redirect=1&aadinmsa=true&hid=f8f09c97-638f-4bd9-b7b1-bb766e8a977c&context=eyJodCI6MiwiaGlkIjoiYWU1OGMxODktNzI0ZC00OTJkLTlmYjUtZmE1OWVlNGIwMTgyIiwicXMiOnt9LCJyciI6IiIsInZoIjoiIiwiY3YiOiIiLCJjcyI6IiJ90#ctx=eyJTaWduSW5Db29raWVEb21haW5zIjpbImh0dHBzOi8vbG9naW4ubWljcm9zb2Z0b25saW5lLmNvbSIsImh0dHBzOi8vbG9naW4ubWljcm9zb2Z0b25saW5lLmNvbSJdfQ2
2

You need to grant the build agent user at least read permissions, or provide a PAT in the password field, see

the agent account has permissions to access but he write the release note file to $(System.DefaultWorkingDirectory)

To use the built in security you have to enable OAUTH for the release, see the wiki, but the key point is

UseAgentToken - If true the task will use the built in agent OAUTH token, if false you need to provide username & password/PAT". Note for use of the OAUTH token to work you must allow the pipeline to access the OAUTH Token and grant contribute access to target Azure DevOps WIKI to the Project Collection Build Service user (assuming this is the account the pipeline is running as). The default is false

Here are the permissions of my agent.
.

I think you missed the point.
On the wiki updater task select to use the agent creds

And for the agent stage make sure oAuth is configured

You can see a sample on my release pipeline for this extension in the test stage at https://dev.azure.com/richardfennell/GitHub/_releaseProgress?_a=release-pipeline-progress&releaseId=1420

Here is my configuration of my release

A quick search of Stackoverflow shows the error your log shows is usually down to a bad repo url
Given this not sure about your target Git url
Variable: Repo [dev.azure.com/lcouveignes/POC_Deploiement_Function_Azure/_wiki/wikis/POC_Deploiement_Function_Azure.wiki]
should it not be
Variable: Repo [dev.azure.com/lcouveignes/POC_Deploiement_Function_Azure/_git/POC_Deploiement_Function_Azure.wiki]
as this is the form of my test one
Variable: Repo [dev.azure.com/richardfennell/GitHub/_git/GitHub.wiki]

This is a git repository, I want to put it on a TFS repository...

Do you mean TFVC?
... if so the tool only support Git based repos, as the documentation says either on GitHub or Azure DevOps. if you want to upload to any other location you will need to write some PowerShell or find another task.
Otherwise I can assure you the sample I sent to is a WIKI hosted on Azure DevOps.

OK thanks you

As per my standard practice I am closing this issue as I have heard nothing for a while. If this issue remains a problem please do not hesitate to re-open it


:bug:  Fix metrics battery

Summary
Fixes bit of ordering (not a bug) in metrics and add namespace tags where they needed
Related issue(s)
Fixes #
Release Notes

Fix metrics battery bug

/kind bug


fix semanticContentAttribute not updating

Fixes #77.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Watch can't evaluate member variable

Its not just this scope, cant evaluate any member variable in any struct
PS: Same with hover
version: 0.9.12 ALPHA 44fb752

Is this still happening after the other various this fixes?

(Checked via Discord, all fixed up now!)


TAJO-1486: Tajo should be able to skip header and footer rows when creating external table

Two table meta options are added .

text.skip.headerlines
text.skip.footerlines

This feature is only for delimited text files.

@eminency
Thanks for your contribution.
If there is a unit test case for a plain text file, it would be more better.

@blrunner
I see, I will try to add it.

Guys,
In my opinion, skipping the footer would be good after block interation is added

+1 Looks great to me
I will move the headerLineNum to local variable before commit it

@jinossy It looks good


"Meta packages" do not specify versions

I just tracked down a weird bug to the codeceptjs-webdriverio package.
It seems to depend on * (any version) of its two components (see package.json):
  "dependencies": {
    "codeceptjs": "*",
    "webdriverio": "*"
  },

Is this intentional? It means if you upgrade your codeceptjs-webdriverio dependency, and then run npm install or yarn, it may not actually upgrade either of the sub-dependencies, because * covers anything, and it will just follow your lockfile. In my case this means installing<EMAIL_ADDRESS>gets me very old versions of both codecept and webdriverio.
I'm not clear on the benefit of these meta-packages in general. I initially assumed they contained some kind of compatibility layer between codecept and the driver, but it seems they don't do anything besides pull in other packages. I can't see any advantage of npm install codeceptjs-webdriverio over npm install codeceptjs webdriverio.

But we had lots of people complaining about hard installation.

But how is npm install codeceptjs-webdriverio any easier than npm install codeceptjs webdriverio? It's just switching a space for a hyphen.

This can be easier if we do global installation. At least in this case the dependencies would be matched.
But maybe you are right and the same can be achieved without extra packages...

Meta packages were removed from documentation.


Doesn't work on twitch.tv

It's working here:

Floating Player won't work with Twitch homepage, only with channels and VODs.


Ensure allocated timestamps are valid.

Fluo uses the first three bits of the Accumulo timestamp for its own metadata.  Therefore when allocating timestamps its important to ensure that the first three bits are always zero.  A good place to do this check would be the Stamp constructor.  The check should ensure that the passed in stamps are zero when anded with ColumnConstants.PREFIX_MASK.  The check could be done using Guava preconditions.

I posted this on Apache's https://helpwanted.apache.org/.  Anyone coming from there and wishing to attempt this task, please feel free to ask any questions you have here.

Hello Keith-turner, I would be interested in working on this issue. Is guava dependency added already to this project?

@adepuravikrishna yes, guava is already a dependency.

Should it throw IllegalArgumentException when the a & b condition result is does not satisfy the 3 zeros condition?  and also should this check applies to both stamp, gcStamp variables?

Should it throw IllegalArgumentException when the a & b condition result does not satisfy the 3 zero bits in the beginning condition?

yes, with a good error message.

and also should this check applies to both stamp, gcStamp variables?

yes, the check should be done for both

@keith-turner Thanks a lot for quick response. Currently I am running mvn package but having issues with building the project. Hopefully I can figure it out myself.

Currently I am running mvn package but having issues with building the project.

Feel free to post a link to your branch or share the error messages you are seeing from maven.

@keith-turner Just created a pull request. Could you please review and comment the changes?


Docker/OpenShift template

Kompose can be used to convert from docker-compose to OpenShift.

Closed with #16


Fix small issue in guild::build_json()

json field afk_timeout addition was depending on another field's validity.

thanks for the contribution!


Netdisco DLNA problem with Netgear router?

Feature requests should go in the forum: https://community.home-assistant.io/c/feature-requests
Home Assistant release (hass --version):
0.17.3
Python release (python3 --version):
3.4.3+
Component/platform:
Ubuntu
Description of problem:
While DLNA is on on my Netgear router, no actual media is present at the moment and thus it is not really used. Nonetheless, Netdisco throws an error when detecting the DLNA:
INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): <IP_ADDRESS> INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): <IP_ADDRESS> INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): <IP_ADDRESS> **ERROR:netdisco.ssdp:Error fetching description at http://<IP_ADDRESS>:8200/rootDesc.xml** INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): <IP_ADDRESS> INFO:homeassistant.components.discovery:Found new service: netgear_router ('R7000', '<IP_ADDRESS>') INFO:homeassistant.core:Bus:Handling <Event platform_discovered[L]: discovered=('R7000', '<IP_ADDRESS>'), service=netgear_router> INFO:homeassistant.components.discovery:Found new service: DLNA http://<IP_ADDRESS>:8200/rootDesc.xml INFO:homeassistant.components.device_tracker.netgear:Logging in INFO:pynetgear:Get attached devices INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): routerlogin.net INFO:homeassistant.components.device_tracker.netgear:Scanning INFO:pynetgear:Get attached devices INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): <IP_ADDRESS> INFO:homeassistant.components.device_tracker.netgear:Scanning INFO:pynetgear:Get attached devices

That's not a problem with netdisco. Netgear is reporting a url with info that is not accessible. It's fine to ignore it


[BUG] Copy code doesn't work on the first time

Description
The copy code button doesn't work when pressed the first time, even though it shows on screen, "Copied to Clipboard" it only actually copies to "Clipboard" on the second clip/second time it shows "Copied to Clipboard".
While this is no problem, it makes it inconvenient for users at times.
Screenshots
No response

duplicate issue to this #73

oh sorry, my bad.
On Sat, 20 Aug 2022 at 21:32, Dunsin @.***> wrote:

duplicate issue to this #73
https://github.com/Dun-sin/trick-generator/issues/73
—
Reply to this email directly, view it on GitHub
https://github.com/Dun-sin/trick-generator/issues/114#issuecomment-1221355409,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUGJUTNXNGBD4HDYIJ6PFCDV2D6SPANCNFSM57DNRYJA
.
You are receiving this because you authored the thread.Message ID:
@.***>


fix: move empty artifact error up

I would often get the prereleases are not allowed error, questioning what that meant but now I see why that was :sweat_smile:

This is actually very strange. Do you have a repro of when this happens?

No I don't have that at the moment. Wasn't aware it was that strange, so I didn't write it down. But that was probably while I was trying to break some stuff so I expected errors. Just assumed that was a good error at that time.

Should we change the "should never happen" errors to something that is asking the user to share its repro with us?

I think this change still makes sense.


refactor: refactor code tab split

Motivation
Fix #1260 to allow html/xml comments in code tabs.
Unsure if this would be considered a refactor or a fix since it changes the way the tabs are parsed.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Only tested it locally, ensuring the code tabs on page /docs/en/doc-markdown still worked.
Would like to get the logic approved before getting too far into testing.
Use cases involving whitespace still need to be tested.

@endiliey Added comments

Yeah, I'll create unit tests.

@endiliey @yangshun Added a quick unit test; let me know if looks good. If it does I'll add more.

@endiliey Added fix for #1279

I like the fact that you put test on it. So far LGTM, I will test it out again locally tonight. cc @yangshun

@zachbadgett
I just tried this out. This is awesome.
Great job on fixing #1260 🎉 . However, the #1279 will only works if it's written with indentation
For example, this does not work

1. Do this
<!--DOCUSAURUS_CODE_TABS-->
<!--tab1-->
```
some code
```
<!--tab2-->
```
some other code
```
<!--END_DOCUSAURUS_CODE_TABS-->
1. Do that

What do you think ?

@endiliey that might be an issue with remarkable. Adding a code block in between the list items  on the online demo (https://jonschlinkert.github.io/remarkable/demo/)  shows the same result.

Cool. Actually I don’t mind at all, I was just testing the expected behavior reported on #1279.
Anyway, this is already a huge improvement. Thank you very much.
cc @yangshun, looks good to you ? lgtm


Multiple empty spans with select2-hidden-accessible appended to body

Every select2 instance is creating an empty span in the body, resulting in a whole bunch of these:

It looks like the culprit is https://github.com/ivaynberg/select2/blob/master/select2.js#L685
        this.liveRegion = $("", {
                role: "status",
                "aria-live": "polite"
            })
            .addClass("select2-hidden-accessible")
            .appendTo(document.body);

It's not entirely clear when it is used, but the noise could be reduced with any of:
* part of the .select2-container for each select2
* have a single top-level tag that all select2 elements share
* only be created when they are needed (i.e. when non-empty)

@izharaazmi thanks

After selecting type and garage, When the user will click on stock field, ther previously selected value will be put on the clicked stock, But my code gives me the same as first and second times
Please check my fiddle where is my mistake, First one is ok, But when I select the second one, it gives me the first data as output, but why ?
Demo http://jsfiddle.net/kabircse/kzgvcsyk/

I fix that with this code:
        if($(".select2-hidden-accessible").length){
            this.liveRegion = $(".select2-hidden-accessible");
        }
        else{
            this.liveRegion = $("", {
                role: "status",
                "aria-live": "polite"
            })
                .addClass("select2-hidden-accessible")
                .appendTo(document.body);
        }

instead of this:
        this.liveRegion = $("", {
            role: "status",
            "aria-live": "polite"
        })
            .addClass("select2-hidden-accessible")
            .appendTo(document.body);

+1

saf


python3Packages.pg8000: 1.19.0 -> 1.19.2

Motivation for this change
Update to latest upstream release 0.19.2
Change log: https://github.com/tlocke/pg8000#version-1-19-2-2021-04-07
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 120152 run on x86_64-linux 1

4 packages built:

python38Packages.pg8000
python38Packages.testing-postgresql
python39Packages.pg8000
python39Packages.testing-postgresql

Result of nixpkgs-review pr 120152 at cfe1ac35 run on x86_64-linux 1

4 packages built successfully:

python38Packages.pg8000
python38Packages.testing-postgresql
python39Packages.pg8000
python39Packages.testing-postgresql

1 suggestion:

warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'scramp==1.3.0' doesn't match anything in file 'setup.py'
Near pkgs/development/python-modules/pg8000/default.nix:31:0:
   |
31 |     description = "Python driver for PostgreSQL";
   | ^

Result of nixpkgs-review pr 120152 run on x86_64-linux 1

4 packages built:

python38Packages.pg8000
python38Packages.testing-postgresql
python39Packages.pg8000
python39Packages.testing-postgresql


[Model] Add support for xverse

Add support for xverse models.
We tested the xverse 7B/13B/65B chat models and the quantized GPTQ model locally, and vllm responses are normal.
You can verify by downloading xverse models from Hugging Face (https://huggingface.co/xverse) or Modelscope (https://www.modelscope.cn/search?search=xverse).
Furthermore, before the PR, we executed format.sh.
Request: After the current PR is merged, can we add a new tag so that the latest version of the package supports inference of xverse models via pip installation.

What is the difference of arch between llama and xverse?

What is the difference of arch between llama and xverse?

Nice question.
The current xverse model architecture is no different from llama, and it is expected that xverse will add moe features within two weeks and merge them into xverse.py.
To maintain an independent update progress, it is necessary to separately support the xverse architecture in VLLM.

Hello @WoosukKwon ,
I've submitted a PR #3610 and I would greatly appreciate your help with reviewing the code changes  and provide your feedback.
Thank you for your time and assistance.
Best regards,
willhe.

@hxer7963 Could you please fix the formatting error by running pip install -r requirements-dev.txt; ./format.sh?

Can we simply use this: "XverseForCausalLM": ("llama", "LlamaForCausalLM")?

Can we simply use this: "XverseForCausalLM": ("llama", "LlamaForCausalLM")? Will the new moe model use the same name with XverseForCausalLM?
Yes, the new moe model will use the same name with XverseForCausalLM, so we want to add a new name.

Can we simply use this: "XverseForCausalLM": ("llama", "LlamaForCausalLM")? Will the new moe model use the same name with XverseForCausalLM?

Yes, the new moe model will use the same name with XverseForCausalLM, so we want to add a new name.

Hello @WoosukKwon ,
I've addressed all the feedback in the PR, and all checks have passed.
Could you please take another look at the code changes and provide your review?
Thank you for your time and assistance.
Best regards,
hxer7963.


since 10.1.0, cannot assign the same IPv4 to 2 interfaces anymore

As per log below:
Oct 24 20:33:16 u1400 dhcpcd[676]: dhcpcd-10.1.0 starting
Oct 24 20:33:16 u1400 dhcpcd[679]: DUID 00:01:00:01:2c:91:da:a1:00:1c:23:28:c9:4f
Oct 24 20:33:17 u1400 dhcpcd[679]: wlp12s0: waiting for carrier
Oct 24 20:33:17 u1400 dhcpcd[654]: enp9s0: waiting for carrier
Oct 24 20:33:19 u1400 dhcpcd[679]: wlp12s0: carrier acquired
Oct 24 20:33:19 u1400 dhcpcd[679]: wlp12s0: connected to Access Point: 715517
Oct 24 20:33:19 u1400 dhcpcd[679]: wlp12s0: IAID e0:36:99:1b
Oct 24 20:33:19 u1400 dhcpcd[679]: wlp12s0: adding address fe80::9f61:80bd:9b17:ccf0
Oct 24 20:33:19 u1400 dhcpcd[679]: wlp12s0: soliciting a DHCP lease
Oct 24 20:33:19 u1400 dhcpcd[679]: wlp12s0: offered <IP_ADDRESS> from <IP_ADDRESS>
Oct 24 20:33:19 u1400 dhcpcd[679]: wlp12s0: probing address <IP_ADDRESS>/16
Oct 24 20:33:20 u1400 dhcpcd[654]: enp9s0: carrier acquired
Oct 24 20:33:20 u1400 dhcpcd[654]: enp9s0: IAID 23:28:c9:4f
Oct 24 20:33:21 u1400 dhcpcd[654]: enp9s0: soliciting a DHCP lease
Oct 24 20:33:21 u1400 dhcpcd[654]: enp9s0: offered <IP_ADDRESS> from <IP_ADDRESS>
Oct 24 20:33:21 u1400 dhcpcd[654]: enp9s0: probing address <IP_ADDRESS>/16
Oct 24 20:33:21 u1400 dhcpcd[679]: wlp12s0: 00:1c:23:28:c9:4f(00:1c:23:28:c9:4f) claims <IP_ADDRESS>
Oct 24 20:33:21 u1400 dhcpcd[679]: wlp12s0: DAD detected <IP_ADDRESS>
Oct 24 20:33:21 u1400 dhcpcd[654]: enp9s0: soliciting an IPv6 router
Oct 24 20:33:21 u1400 dhcpcd[679]: wlp12s0: soliciting an IPv6 router
Oct 24 20:33:21 u1400 dhcpcd[654]: enp9s0: Router Advertisement from fe80::5022:e24d:b9fa:2d57
Oct 24 20:33:21 u1400 dhcpcd[679]: wlp12s0: Router Advertisement from fe80::5022:e24d:b9fa:2d57
Oct 24 20:33:21 u1400 dhcpcd[679]: wlp12s0: adding address 2001:14ba:a00e:1905:b8c3:d439:7b3b:26f1/64
Oct 24 20:33:21 u1400 dhcpcd[679]: wlp12s0: adding route to 2001:14ba:a00e:1905::/64
Oct 24 20:33:21 u1400 dhcpcd[679]: wlp12s0: adding default route via fe80::5022:e24d:b9fa:2d57
Oct 24 20:33:21 u1400 dhcpcd[654]: enp9s0: adding address 2001:14ba:a00e:1905:6883:ff76:955e:d5c9/64
Oct 24 20:33:21 u1400 dhcpcd[654]: enp9s0: adding route to 2001:14ba:a00e:1905::/64
Oct 24 20:33:21 u1400 dhcpcd[654]: enp9s0: adding default route via fe80::5022:e24d:b9fa:2d57
Oct 24 20:33:22 u1400 dhcpcd[679]: wlp12s0: soliciting a DHCP lease
Oct 24 20:33:26 u1400 dhcpcd[654]: enp9s0: leased <IP_ADDRESS> for infinity
Oct 24 20:33:26 u1400 dhcpcd[654]: enp9s0: adding route to <IP_ADDRESS>/16
Oct 24 20:33:26 u1400 dhcpcd[654]: enp9s0: adding default route via <IP_ADDRESS>

Basically, DAD mistakenly prevents 2 interfaces on the same host from using the same address. This wasn't the case before.

This feature has been removed. Maybe what you need is interface bonding (Linux) or link aggregation (BSD)?
This gives a more sane picture to the OS of what you really want rather than playing tricks at the L3 level.
Also, only one DHCP server (ISC DHCPd) actually allows this and all others I've used (kea, which supersedes ISC DHCPd), dnsmasq and whatever ships with my Ubiquiti router actively deny this ability.

Oh, I didn't know that about dnsmasq.
The point of removing the feature was that kernel level ARP replies (which I can't control) sometimes send out the MAC of the non preferred interface giving a poor experience. With bonding you can say which is the master interface so the kernel always sends out for the correct ARP reply.

I would really ask you to reinstate the feature. Having to configure bondage just to have a host switch interface on the fly is really not desirable.

I'll consider it.
But think about this - you have to configure something somewhere.
It's generally better to configure the client than the server.

Thanks.
The server already is configured to provide the same IPv4 address to any MAC address matching that hostname. This setup has worked fine as-is for many years.
The only thing that is no longer working is at dhcpcd's end.

I would kindly urge you to revert this ASAP.

I need to make some changes in NetBSD to try to accommodate your need for this.


Create codeql-analysis.yml

Testing this Github feature.
It's ready to be merged, but maybe should wait until after the packages are upgraded.

I'm going to quickly merge this in to the old code to get it out of the way.


Allow querying the fee details from transaction payment

Currently, the compute_fee() of transaction payment only exposes the value of the final total fee, we can add a new API like compute_fee_details() that returns the details of the final fee. ChainX now uses a workaround transaction-fee pallet for this purpose but has to copy-and-paste partial transaction-payment code. If transaction-payment can have the built-in fee details support, we could avoid the copy-and-paste.

@liuchengxu do you plan to make a PR for this? Pretty sure we would happily accept one.

Thanks @shawntabrizi , will surely send a PR.

Hi @shawntabrizi can you have a look at this https://github.com/paritytech/substrate/pull/7692?


Broken git-node v8 backport

$ git node v8 --v8-dir ~/git/chromium/v8/v8 backport 80bbbb143c2449f7a2109424a937d1887043c9ee
✔ Update local V8 clone
❯ V8 commit backport
  ✔ Get current V8 version
  ✔ Generate patches
  ❯ Apply and commit patches to deps/v8
    ❯ Commit 80bbbb143c24
      ✖ Enquirer is a peer dependency that must be installed separately.
      ◼ Increment embedder version number
      ◼ Commit patch
✖ Enquirer is a peer dependency that must be installed separately.

I have this problem too.