Add details for distance requests in MoneyRequestView

Details

Held and based on https://github.com/Expensify/App/pull/24235

Fixed Issues
$ https://github.com/Expensify/App/issues/22713
Tests

Log into NewDot and request money from another user. This will create a transaction
Log into OldDot and find the expense
Retract the report
Add a receipt (you probably need to disable WARP for this)
Change the merchant to something like 171 miles @ $0.55 / mile
Find the transactionID (eg. while editing the expense, inspect g_megaEdit.expense.transactionID in the JS console)
From the CLI run scripts/sql.sh
Run the following query, substituting the transactionID from above in order to turn that transaction into a distance request

UPDATE transactions SET comment = '{"customUnit":{"customUnitID":"63601da0a9e55","customUnitRateID":"63601da0a9e58","quantity":"3.41","name":"Distance"},"type":"customUnit","comment":"The description of this distance request.", "waypoints":{"waypoint0":{"lat":37.7886378,"lng":-122.4055329,"address":"ExpensifyLounge,KearnyStreet,SanFrancisco,CA"},"waypoint1":{"lat":37.8040257,"lng":-122.4675914,"address":"CrissyField,1199EBeach,SanFrancisco,CA94129"}}}' WHERE transactionID = '<TRANSACTION_ID>';

View the money request report
Verify the description has the 171 miles @ $0.55 / mile text (refresh if needed)
Select the transaction to view the details
Verify the last menu item is titled "Distance" and has the 171 miles @ $0.55 / mile text

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Please let me know if C+ review is not required.

@parasharrajat not needed since an internal setup is required to test

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.57-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@arosiclair Can you pls share steps for QA if we need to QA this PR

Sorry forgot to specify no QA needed for this since distance requests cannot be created outside of dev yet.

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.58-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.57-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


fix wrong variable name, openChannelNameDialog on ctrl+t, give focus to new split

the _currentValue should fix scrollbar (atleast it does for me), without it cannot scroll with mousewheel plus dragging the scrollbar with mouse is kinda bugged too

Looks good to me :1st_place_medal:


[.NET Migration Guide Revamp] [Phase 1] Move content 'Retarget to .NET Framework 4.7.2' content from 'Port libraries' page.

For details on revamp see: https://github.com/dotnet/docs/issues/23561
New TOC: https://github.com/dotnet/docs/issues/23215

[x] Retarget to .NET Framework 4.7.2 (MOVE) This section needs to be moved to a new location in the new TOC and updated as needed.

name: Migration guide
items:

name: Overview
href: ../core/porting/index.md
name: General Information
items:
name: Pre-Migration
items:

name: Needed changes before porting code
href: ../core/porting/premigration-needed-changes.md

Completed with #24630


[core] Add TimeTravelUtils to resolve snapshot from scan params

Purpose
Add TimeTravelUtils to resolve snapshot from scan params

Linked issue: close #xxx

Tests

API and Format

Documentation

Expansion ：We can support more scan startup mode, like timestamp.

Expansion ：We can support more scan startup mode, like timestamp.
Add parameters ： consumer.scan.startup.mode = snapshot/timestamp

Thanks @LinMingQiang ,Good reminder, had added timestamp config, but mode not add due to user not need add two config if they use snapshot or timestamp.

Maybe you want /*+ OPTIONS('consumer-id'='myid', 'scan.snapshot-id'='3', 'consumer.ignore-progress') */?

Maybe you want /*+ OPTIONS('consumer-id'='myid', 'scan.snapshot-id'='3', 'consumer.ignore-progress' = 'true') */?

Yes, it is a direct way, I had test for it, can query right snapshot and reset consumer. Thanks @JingsongLi

@wwj6591812 had addressd, Thanks.

+1


Cannot download models behind a proxy

Seems like #769 doesn't catch all the corner cases when users are behind a proxy. Both @reactivetype and I can reproduce in 0.1.3 and 0.1.5.
$ ollama -v
ollama version 0.1.5
$ ollama pull llama2
pulling manifest
Error: pull model manifest: Get "https://registry.ollama.ai/v2/library/llama2/manifests/latest": dial tcp: lookup registry.ollama.ai on xxx.xxx.xxx.xxx:53: read udp xxx.xxx.xxx.xxx:49613->xxxx.xxx.xxx.xxx:53: i/o timeout
$ curl https://registry.ollama.ai/v2/library/llama2/manifests/latest
{"errors":[{"code":"MANIFEST_INVALID","message":"manifest invalid","detail":{}}]}

Without divulging private information, can you describe your proxy configurations? e.g. what kind of proxy, how it's set, authentication, etc. It will help immensely with fixing this issue

Sadly I don't know either, it's a black box managed by IT. I do have to set http_proxy and https_proxy in my shell to get connectivity. My Go is very poor so I could be wrong but I don't see anything in client.go where these environment variables are taken into account.
If that's not valid maybe I see that UDP is mentioned in the error message. I can't quite find why UDP is being used, but I have a feeling that all UDP traffic is blocked.

Thanks for the response. client.go does use HTTP_PROXY and HTTPS_PROXY environment variables through http.ProxyFromEnvironment and sets the proxy URL in the http.Client.Transport

Good to know. Mine were in lowercase so I added the uppercase version but it still doesn't work.
In case it helps I changed the values of the IP to show when they are the same and when they are different.
$ ollama pull llama2
pulling manifest
Error: pull model manifest: Get "https://registry.ollama.ai/v2/library/llama2/manifests/latest": dial tcp: lookup registry.ollama.ai on xxx.xxx.xxx.xxx:53: read udp yyy.yyy.yyy.yyy:58915->xxx.xxx.xxx.xxx:53: i/o timeout
$ env | grep -i http
https_proxy=http://zzz.zzz.zzz.zzz:3128
HTTPS_PROXY=http://zzz.zzz.zzz.zzz:3128
HTTP_PROXY=http://zzz.zzz.zzz.zzz:3128
http_proxy=http://zzz.zzz.zzz.zzz:3128

same thing #689 #676

Error: pull model manifest: Get "https://registry.ollama.ai/v2/library/llama2/manifests/latest": dial tcp: lookup registry.ollama.ai on xxx.xxx.xxx.xxx:53: read udp yyy.yyy.yyy.yyy:58915->xxx.xxx.xxx.xxx:53: i/o timeout

Does the proxy server have DNS and can it resolve registry.ollama.ai? A local test using mitmproxy works mostly as expected with just setting https_proxy or HTTPS_PROXY. I ran into similar errors messages when the mitmproxy container had bad networking configurations and couldn't resolve the ollama.ai hostname.

Interestingly, while dig doesn't resolve the domain, I can get to registry.ollama.ai with cURL but I'm still getting the error with the ollama CLI. Do you know if the GoLang library you are using doesn't something different than cURL?
$ dig registry.ollama.ai
;; communications error to <IP_ADDRESS>#53: timed out
$ curl -I https://registry.ollama.ai
HTTP/1.1 200 Connection established

HTTP/2 404
content-type: text/plain; charset=utf-8
date: Thu, 02 Nov 2023 15:07:14 GMT
content-length: 9
via: 1.1 google
alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000
$ curl -s https://registry.ollama.ai | grep -i '<title>'
    <title>Ollama</title>
$ ollama pull llama2
pulling manifest
Error: pull model manifest: Get "https://registry.ollama.ai/v2/library/llama2/manifests/latest": dial tcp: lookup registry.ollama.ai on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:35379-><IP_ADDRESS>:53: i/o timeout

Having the same proxy issues after installing locally.
I suspect the dockerized container had issues  behind the corporate proxy, but it only displayed a generic error message.
It would be cool if the ollama run and ollama pull commands read http_proxy (and related vars) from the environment, or if the proxy could be set via CLI arg or a config file.

I am also having this issue. It's specifically HTTP_PROXY. If it's set, I get a "Something went wrong, please see the ollama server logs for more information"

Rebooting my VM and running the install script again solved the problem for some reason.

I'm running it a docker container, with no luck. It works with the regular install script. However, I need it in Docker.

Ollama works with forward proxies when configured with *_PROXY. Here's the FAQ on how to set it up: https://github.com/jmorganca/ollama/blob/main/docs/faq.md#how-do-i-use-ollama-behind-a-proxy

Following the FAQ and other information and it seems there are some troubles when being behind a proxy:
luca@wanda:~$ HTTPS_PROXY=http://proxyout.nims.go.jp:8888 ollama pull llama2:70b-chat
pulling manifest
Error: pull model manifest: Get "https://registry.ollama.ai/v2/library/llama2/manifests/70b-chat": read tcp <IP_ADDRESS>:39158-><IP_ADDRESS>:443: read: connection reset by peer

I'm not sure where to start to investigating this 😭

Please refer to this link: issues1859
I solved this in my server(company network which should set proxy to download modles)


Encoded password does not look like BCrypt

I create register controller
I use         user.setPassword(passwordEncoder.encode(registerRequest.getPassword()));
When login get above error

Closed, because I published a complete new version.


CycloneDDS crashes when subscribing to a topic with large messages

Description
When using @foxglove/rtps as a subscriber to a topic published by CycloneDDS with large messages, in the right environment CycloneDDS will crash with the following error:
Error:
[cam-2] python3: /tmp/binarydeb/ros-galactic-cyclonedds-0.8.0/src/core/ddsi/src/ddsi_entity_index.c:411: entidx_lookup_proxy_reader_guid: Assertion `is_reader_entityid (guid->entityid)' failed.
[ERROR] [cam-2]: process has died [pid 3848, exit code -6, cmd '/home/sh/ws/flir-wrapper_ws/install/flir_wrapper/lib/flir_wrapper/cam --ros-args -r __node:=cam_727 -r __ns:=/cam_727 --params-file /tmp/launch_params_5fvheszt'].

This can be reproduced on an Ubuntu 20.04 desktop running ROS Galactic with the default CycloneDDS RMW and a ROS 2 node publishing topics from a RealSense D435i.

I'd like to share what I have found so far:
during the ros2 node crash, the call stack is:
libddsc.so.0!entidx_lookup_proxy_reader_guid(const struct entity_index * ei, const struct ddsi_guid * guid) (\home\someone\github\cyclonedds\src\core\ddsi\src\ddsi_entity_index.c:412)
libddsc.so.0!handle_NackFrag(struct receiver_state * rst, ddsrt_etime_t tnow, const NackFrag_t * msg, SubmessageKind_t prev_smid, struct defer_hb_state * defer_hb_state) (\home\someone\github\cyclonedds\src\core\ddsi\src\q_receive.c:1556)
libddsc.so.0!handle_submsg_sequence(struct thread_state1 * const ts1, struct ddsi_domaingv * gv, ddsi_tran_conn_t conn, const ddsi_locator_t * srcloc, ddsrt_wctime_t tnowWC, ddsrt_etime_t tnowE, const ddsi_guid_prefix_t * const src_prefix, const ddsi_guid_prefix_t * const dst_prefix, unsigned char * const msg, const size_t len, unsigned char * submsg, struct nn_rmsg * const rmsg, _Bool rtps_encoded) (\home\someone\github\cyclonedds\src\core\ddsi\src\q_receive.c:3013)
libddsc.so.0!do_packet(struct thread_state1 * const ts1, struct ddsi_domaingv * gv, ddsi_tran_conn_t conn, const ddsi_guid_prefix_t * guidprefix, struct nn_rbufpool * rbpool) (\home\someone\github\cyclonedds\src\core\ddsi\src\q_receive.c:3295)
libddsc.so.0!recv_thread(void * vrecv_thread_arg) (\home\someone\github\cyclonedds\src\core\ddsi\src\q_receive.c:3510)
libddsc.so.0!create_thread_wrapper(void * ptr) (\home\someone\github\cyclonedds\src\core\ddsi\src\q_thread.c:241)
libddsc.so.0!os_startRoutineWrapper(void * threadContext) (\home\someone\github\cyclonedds\src\ddsrt\src\threads\posix\threads.c:165)
libpthread.so.0!start_thread(void * arg) (\build\glibc-SzIz7B\glibc-2.31\nptl\pthread_create.c:477)
libc.so.6!clone() (\build\glibc-SzIz7B\glibc-2.31\sysdeps\unix\sysv\linux\x86_64\clone.S:95)

in function of handle_submsg_sequence(), the sm->smhdr.submessageId is (enum SubmessageKind)SMID_NACK_FRAG = 18.
in function of int is_reader_entityid (ddsi_entityid_t id), id.u is: 0x0
normal case:
sm->smhdr.submessageId is: 14
sm->smhdr.submessageId is: 6
is_reader_entityid returns 4, id.u is: 0x1404
is_reader_entityid returns 4, id.u is: 0x304
is_reader_entityid returns 4, id.u is: 0x404
sm->smhdr.submessageId is: 14

crash case:
sm->smhdr.submessageId is: 18
is_reader_entityid returns 0, id.u is: 0x0

from code src.entityid = msg->readerId;, I can find that msg->readerId.u is 0 then the node crashes, only at case of SMID_NACK_FRAG.
I may need help from here.

just by coincidence, if I run
sudo sysctl -w net.core.rmem_max=26214400
sudo sysctl -w net.core.rmem_default=26214400
sudo sysctl -w net.ipv4.udp_mem=26214400

as shown in the readme, the crash is gone!!
I'm not sure if this is expected or bug.
Anyway, if someone is trying to reproduce the bug, don't change the udp configurations, then it can be reproduced almost every time!

@felixf4xu I believe the crash is related to @foxglove/rtps sending one or more NACK_FRAG packets, which are sent when there is packet loss. Packet loss happens with large RTPS messages and the default Ubuntu (18/20/22) kernel UDP receive buffer size. If there's no packet loss, there's no bug.

I would like to debug into this, but a very stupid question first: how to compile a debug version of foxglove/rtps along with foxglove/studio (or any other way to compile my local foxglove/rtps into a running foxglove/studio)?
I have checked foxglove/studio's source code a little bit, but I didn't find any dependencies of foxglove/rtps, only one line of code
import { Durability, Reliability } from "@foxglove/rtps";

it's weird, would yarn automatically detect the dependency of foxglove/rtps?

@felixf4xu I think the "correct" answer here involves yarn link. Since Studio uses yarn v2 and @foxglove/ros2 + @foxglove-rtps use yarn v1 I have run into problems with this workflow before, and ended up running yarn build in @foxglove/rtps then copying the dist/ output into the node_modules/@foxglove/rtps folder of Studio then rebuilding with yarn desktop:serve. Very hacky.
A better approach that makes debugging this much easier is to ignore Studio and connect directly to your ROS 2 DDS network using the @foxglove/rtps package. The example script at https://github.com/foxglove/rtps/blob/main/examples/listener.ts can be tweaked to subscribe to the topic you are using to reproduce the crash.

We have deprecated the direct ROS 2 connection in Foxglove Studio in favor of our new foxglove_bridge WebSocket server, which provides more stability and a better user experience. As such we are no longer actively maintaining this package. You can find instructions to use the WebSocket bridge here: https://foxglove.dev/docs/studio/connection/ros2#live-connection


Things to do before neurips

[ ] Create two separate datasets to distribute, one CC-BY, one CC-BY-SA.
[ ] Rerun yamnet on the entire dataset. This means we need to make it more performant See #40
[ ] Send data to be hand-transcribed.

[ ] Optionally, do audio-based deduplication first.

[ ] Add text deata deduplication to the data creation pipeline.
[ ] Train kaldi and/or nemo models on the dataset. Provide fixes to the dataset, based on this work.
Adding more as time goes on...

Poster + 3 minute talk due: Oct 18th
Camera-ready paper due: November 6th
Neurips (dataset release): Early December


Fire Emblem locks up during startup

Notably this is SRAM not EEPROM or Flash so I can't blame it on EEPROM annoyances

I can't reproduce this any more but haven't done anything I would expect to fix it. Maybe some of the work on timing has solved the problem?


deleting snapshot hangs forever

Steps to reproduce

create volume
create snap A
create snap B
delete snap A

sfold seems to hang or take forever. im deleting this snap on an empty volume.
see this in the sync-agent logs:
time="2016-08-01T21:49:12Z" level=info msg="Running /proc/self/exe [sfold volume-snap-63a9c04a-02d7-43dd-a317-aa65fe783e28.img volume-snap-a905e1c6-c817-4668-bf49-f272d8e1a3fd.img]"

Need longhorn integration test for the case.


Error while calling TFLite interpreter - cannot import name cloud

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Raspbian Stretch
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: Not Applicable
TensorFlow installed from (source or binary):whl file
TensorFlow version: 1.12.0
Python version: 3.5
Installed using virtualenv? pip? conda?: Pip3
Bazel version (if compiling from source): Not applicable
GCC/Compiler version (if compiling from source): Not applicable
CUDA/cuDNN version: Not applicable
GPU model and memory: Not applicable

Describe the problem
I'm using a Raspberry Pi 3B+, with Raspbian Stretch as my OS.
I installed Tensorflow 1.12 using this guide, I downloaded the latest versions of TensorFlow and Protobuf, but as I was trying out this guide, I hit an error:
File "/usr/local/lib/python3.5/dist-packages/tensorflow/contrib/__init__.py", line 39, in <module>     from tensorflow.contrib import cloud ImportError: cannot import name 'cloud'
Provide the exact sequence of commands / steps that you executed before running into the problem
The steps that I had followed are based off of the guide linked above, I had used the updated compiled TensorFlow wheels and the updated Protobuf as well.
Here are the exact steps I took:
TensorFlow Lite Guide
You may do the following in the RPi itself, or connect via SSH
If you encounter the “Remote Host Identification has changed” message, you may have to edit the ~/.ssh/known_hosts file.
sudo nano ~/.ssh/known_hosts
remove the line for the IP Address of the RPi

Delete bloatware
$ sudo apt-get purge wolfram-engine
$ sudo apt-get purge libreoffice*
$ sudo apt-get clean
$ sudo apt-get autoremove

Install Dependencies
$ sudo apt-get update
$ sudo apt-get dist-upgrade

Install Tensorflow
$ mkdir tf && cd tf

check: https://github.com/lhelontra/tensorflow-on-arm/releases
for latest tensorflow releases
$ wget https://github.com/lhelontra/tensorflow-on-arm/releases/download/v1.12.0/tensorflow-1.12.0-cp35-none-linux_armv7l.whl
$ sudo pip3 install /home/pi/tf/tensorflow-1.12.0-cp35-none-linux_armv7l.whl
$ sudo apt-get install libatlas-base-dev
$ sudo pip3 install pillow lxml jupyter matplotlib cython
$ sudo apt-get install python-tk

Install OpenCV
$ sudo apt-get install libjpeg-dev libtiff5-dev libjasper-dev libpng12-dev
$ sudo apt-get install libavcodec-dev libavformat-dev libswscale-dev libv4l-dev
$ sudo apt-get install libxvidcore-dev libx264-dev
$ sudo apt-get install qt4-dev-tools
$ pip3 install opencv-python

Install Protobuf
$ sudo apt-get install autoconf automake libtool curl
check https://github.com/protocolbuffers/protobuf/releases/
for latest releases
$ wget https://github.com/google/protobuf/releases/download/v3.6.1/protobuf-all-3.6.1.tar.gz
$ tar -zxvf protobuf-all-3.6.1.tar.gz
$ cd protobuf-3.6.1
$ ./configure
$ make
$ make check
$ sudo make install
$ cd python
$ export LD_LIBRARY_PATH=../src/.libs
$ python3 setup.py build --cpp_implementation
$ python3 setup.py test --cpp_implementation
$ sudo python3 setup.py install --cpp_implementation
$ export PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=cpp
$ export PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION_VERSION=3
$ sudo ldconfig
$ protoc
$ sudo reboot now

$ cd ~
$ mkdir tensorflow1 && cd tensorflow1
$ git clone --recurse-submodules https://github.com/tensorflow/models.git
$ sudo nano ~/.bashrc
Add: export PYTHONPATH=$PYTHONPATH:/home/pi/tensorflow1/models/research:/home/pi/tensorflow1/models/research/slim
$ cd /home/pi/tensorflow1/models/research
$ protoc object_detection/protos/*.proto --python_out=.
$ cd /home/pi/tensorflow1/models/research/object_detection
$ wget http://download.tensorflow.org/models/object_detection/ssdlite_mobilenet_v2_coco_2018_05_09.tar.gz
$ tar -xzvf ssdlite_mobilenet_v2_coco_2018_05_09.tar.gz
Then I ran:
$ python3

from tensorflow.contrib.lite.python import interpreter as interpreter_wrapper
But I hit an error, as shown below:

Any other info / logs
File "", line 1, in
File "/usr/local/lib/python3.5/dist-packages/tensorflow/init.py", line 24, in
from tensorflow.python import pywrap_tensorflow  # pylint: disable=unused-import
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/init.py", line 47, in
import numpy as np
File "/home/pi/.local/lib/python3.5/site-packages/numpy/init.py", line 187, in
from .testing import Tester
File "/home/pi/.local/lib/python3.5/site-packages/numpy/testing/init.py", line 10, in
from unittest import TestCase
File "/usr/lib/python3.5/unittest/init.py", line 64, in
from .main import TestProgram, main
File "/usr/lib/python3.5/unittest/main.py", line 7, in
from . import loader, runner
File "/usr/lib/python3.5/unittest/runner.py", line 8, in
from .signals import registerResult
File "/usr/lib/python3.5/unittest/signals.py", line 1, in
import signal
File "/usr/local/lib/python3.5/dist-packages/tensorflow/contrib/signal/init.py", line 42, in
from tensorflow.contrib.signal.python.ops.mel_ops import linear_to_mel_weight_matrix
File "/usr/local/lib/python3.5/dist-packages/tensorflow/contrib/init.py", line 39, in
from tensorflow.contrib import cloud
ImportError: cannot import name 'cloud'
I've checked the init.py code, and I'm kind of clueless as to what or how to approach this. I'm not sure if it's safe to just comment the line out.
Has anyone solved this issue?

Unfortunately we can't support external builds like https://github.com/lhelontra/tensorflow-on-arm/releases, since we're not in control of how they're built.

Hi @Zeit42,

File "/usr/local/lib/python3.5/dist-packages/tensorflow/contrib/init.py", line 39, in  from >tensorflow.contrib import cloud ImportError: cannot import name 'cloud'

I have the same error, would you please kindly share your insights? Thanks.
My system infor
tensorflow-1.13.1-cp35-none-linux_aarch64.whl
Linux firefly 4.4.52 #16 SMP Thu Apr 27 17:56:29 HKT 2017 aarch64 aarch64 aarch64 GNU/Linux
rk3399
Hi  @petewarden,

can't support external builds like https://github.com/lhelontra/tensorflow-on-arm/releases,

Noted. Thanks.
    interpreter = tf.contrib.lite.Interpreter(model_path=tflitefile)   File "/media/root/usb16g1/venv/tf1.13/lib/python3.5/site-packages/tensorflow/python/util/lazy_loader.py", line 61, in __getattr__     module = self._load()   File "/media/root/usb16g1/venv/tf1.13/lib/python3.5/site-packages/tensorflow/python/util/lazy_loader.py", line 44, in _load     module = importlib.import_module(self.__name__)   File "/media/root/usb16g1/venv/tf1.13/lib/python3.5/importlib/__init__.py", line 126, in import_module     return _bootstrap._gcd_import(name[level:], package, level)   File "<frozen importlib._bootstrap>", line 986, in _gcd_import   File "<frozen importlib._bootstrap>", line 969, in _find_and_load   File "<frozen importlib._bootstrap>", line 958, in _find_and_load_unlocked   File "<frozen importlib._bootstrap>", line 673, in _load_unlocked   File "<frozen importlib._bootstrap_external>", line 665, in exec_module   File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed   File "/media/root/usb16g1/venv/tf1.13/lib/python3.5/site-packages/tensorflow/contrib/__init__.py", line 30, in <module>     from tensorflow.contrib import cloud ImportError: cannot import name 'cloud'


Fix bad accounts request on kovan

Run
ETHEREUM_NETWORK=kovan yarn workspace @augurproject/ui dev

and open in an incognito window.

@justinbarry will test this very soon


Does it has demo ?

I just want to see how it works..
Thanks!

Hi,
no, there is no demo. This is just a library, not a ready to run application. In the example folder you find some examples how this code should be used.


Search left pane (dumb)

@MarcoPolo
cc @keybase/react-hackers

:mag_right: These commits introduced some visual changes:

Changed: user_search-Normal (before) (after)

:mag_right: These commits introduced some visual changes:

Changed: user_search-Normal (before) (after)

:mag_right: These commits introduced some visual changes:

Changed: user_search-Normal (before) (after)

:mag_right: These commits introduced some visual changes:

Changed: user_search-Normal (before) (after)

👍


Fixed #24976 - Issue with missing label for inline admin formset.

Updated InlineAdminFormSet to use the value of label_for_field as label
for fields when the field itself does not define a label.
https://code.djangoproject.com/ticket/24976

buildbot, add to whitelist.

merged in 12aeed8c949925488a36f0a3b3bf25dfc9407cbf, thanks!


fix test stage error

IBM Cloud toolchain: Delivery Pipeline deployed products to nyu-devops-products, including commit 24ef6be59093a656500a36d67ef6112854117e97


Improve dependency management.

Pin dependency versions to the major ones at least to reduce risk of plugin breaking by dependency update.
Use requirements files for dependency definition to enable GH vulnerability detection and IDE support.
We can follow kedro-mlflow implementation as an example.

enable dependabot

enable dependabot


[ FSU ] Enabls Asynchronos FSU for forwarding

This PR enables asynchronos mode for FSU (flash storage utilization)
for better performance.
It splits the load and unload tensors which make difficult to handle.
Also fix the inference execution order when it is in INFERENCE mode
and change the trainable option to false when it calls the request
weights and tensors.
Add the new function to load and unload tensors as well as check load
complete.
It also considers weight pool and tensor pool differenetly according
to the ExecutionMode. It is not use FSU mode for tensor pool for the
INFERENCE Mode.
Resolves:
Self evaluation:

Build test:	 [X]Passed [ ]Failed [ ]Skipped
Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: jijoong.moon<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2813. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.


[SR-21] Standardize NSURL / NSPathUtilities behavior

Previous ID
SR-21

Radar
rdar://problem/22424272

Original Reporter
@jtbandes

Type
Improvement

Additional Detail from JIRA

Votes
0

Component/s
Foundation

Labels
Improvement

Assignee
@parkera

Priority
Medium

md5: bcd1290e284ffe9fda05487cde2ea447

Issue Description:
The methods provided in NSPathUtilities / NSURLPathUtilities categories adhere mostly to RFC 1808.
NSURLComponents, on the other hand, uses the more-modern RFC 3986 behavior.
My view is that continuing to expose RFC 1808–style behavior is harmful to users. Results may be unexpected:
NSURL(string: "http://one/two;three/four")!.URLByAppendingPathComponent("five")
// This returns "http://one/two/five;three/four".

// Paths whose last component starts/ends with a dot (.) also have problems:
let url = NSURL(fileURLWithPath: "/path/to/.file")

// Expected: ???
// Actual: ""
let ext = url.pathExtension!

// Expected (based on pathExtension being ""): "/path/to/.file"
// Actual: "/path/to/"
url.URLByDeletingPathExtension!

// Expected: same as original URL
// Actual: "/path/to./"
url.URLByDeletingPathExtension!.URLByAppendingPathExtension(ext)

// <rdar://18421068>, only recently resolved in El Capitan, was a similar issue in NSURLComponents.

This has produced some problems in Apple system behavior (see <rdar://23241861>), let alone latent bugs in third-party code.
These sorts of things should be hard to get wrong, rather than easy. I think the Foundation APIs could use some love here.

This is done - URL and URLComponents now use the same parser under the hood.

Done already? And it's not even 10 years old! 😄   Thanks 🙌


flutter list crashes on linux

It appears to try and call iOSCode on linux.
%flutter list                                                                                [/src/engine/src]
Updating flutter tool...
severe: To work with iOS devices, please install ideviceinstaller. On Ubuntu or Debian, you can install it with "$ apt-get install ideviceinstaller".
ProcessException: No such file or directory
  Command: /usr/bin/xcrun simctl list devices
severe:
Exception:
dart:io                                                           Process.runSync
package:flutter_tools/src/base/process.dart 86                    _runWithLoggingSync
package:flutter_tools/src/base/process.dart 66                    runCheckedSync
package:flutter_tools/src/ios/device_ios.dart 283                 IOSSimulator._getRunningSimulatorInfo
package:flutter_tools/src/ios/device_ios.dart 334                 IOSSimulator.getAttachedDevices
package:flutter_tools/src/commands/list.dart 60                   ListCommand.runInProject.<async>
dart:async                                                        _Completer.completeError
package:flutter_tools/src/commands/list.dart 70                   ListCommand.runInProject.<async>
dart:async                                                        Future.Future.microtask
package:flutter_tools/src/commands/list.dart                      ListCommand.runInProject
package:flutter_tools/src/runner/flutter_command.dart 53          FlutterCommand.run.<async>
dart:async                                                        Future.Future.microtask
package:flutter_tools/src/runner/flutter_command.dart             FlutterCommand.run
package:args/command_runner.dart 178                              CommandRunner.runCommand.<fn>
dart:async                                                        Future.Future.sync
package:args/command_runner.dart 131                              CommandRunner.runCommand
package:flutter_tools/src/runner/flutter_command_runner.dart 159  FlutterCommandRunner.runCommand
package:args/command_runner.dart 105                              CommandRunner.run.<fn>
dart:async                                                        Future.Future.sync
package:args/command_runner.dart 105                              CommandRunner.run
package:flutter_tools/executable.dart 80                          main.<async>.<fn>.<async>
package:stack_trace                                               Chain.capture
package:flutter_tools/executable.dart 79                          main.<async>

It looks like _getRunningSimulatorInfo needs to use _checkForCommand? @chinmaygarde @devoncarew

Turns out there is actually an ideviceinstaller package for ubuntu.  But after installing it I still get the same message. :)

Fixed in https://github.com/flutter/flutter/pull/1350

We ran into this issue trying to build for Android on a Mac that didn't have Xcode installed.

I think our tools behave better now. You can use Flutter for Android without Xcode now. Please reopen if this isn't correct today.


eosio-cpp spoiled abi file and run abigen without option

Hello.
I run
eosio-cpp  ${contractdir}/$contract.cpp -o ${contractdir}/${contract}.wasm
${contractdir} also contains ${contract}.abi and running of the command is rewriting my abi file without -abigen option.

See #513, a new flag will be coming that allows you to disable abi generation. Closing in favor of the earlier issue.


Sample code works only for one tenant

The sample code works for only one tenant. Ex:- localhost:60000 works. But if i enter Tenant 2 url: localhost:60002 it just says unable to connect. It doesn't break in TenantResolver either.
I haven't change a single line of code.
Am I doing something wrong?

Which sample project are you running?

It's AspNetMvcSample.
In the downloaded code, by default it's set to use SqlLiteContext. I
changed it to SQLServer and when run under port:60000, the db for Tenant1
is getting created and all is fine.
However if I try with port:60002 which is Tenant2, it says unable to
connect.
Should I configure something else?
Thanks/
On Sun, Jul 16, 2017 at 5:08 PM, Ben Foster<EMAIL_ADDRESS>wrote:

Which sample project are you running?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/saaskit/saaskit/issues/75#issuecomment-315603346, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIAPkxhwTnEJ5y3H1-LVCrDrYQ_BrV6jks5sOfYagaJpZM4OZOsg
.

Any input on this?

Does it work for you with SQLite?

Sorry man,
I was on vacation for few days... hibernated :) . Yep got it to work! I have missed the URL configuration part!
All works fine. There is another advice needed but I will add it as a separate thread so others might also find it useful.


Added fix for network next_available_ip with a supporting test case.

Please review and merge.

Thanks for the quick review :+1:  . Let me explain my issue:
When I call the code
JSON.parse(connection.post(resource_uri + "/#{network}?_function=next_available_ip", post_body).body)["ips"]
I get : ["<IP_ADDRESS>"]
But when I call with the old code
JSON.parse(connection.post(resource_uri + "?_function=next_available_ip", post_body).body)["ips"]
I get:
Infoblox::Error: Error: 400 { "Error": "AdmConProtoError: Invalid reference: ",
"code": "Client.Ibap.Proto",
"text": "Invalid reference: "
}
So if I just print the string part ( resource_uri + "?_function=next_available_ip" ) , It returns me
=> "/wapi/v1.0/network?_function=next_available_ip") , where there is no network provided. So I added the #{network} explicitly, to get the string something like this :  "/wapi/v1.0/network/ZG5zLm5ldHdvcmskMTAuMTAuNzAuMC8yNC8w:<IP_ADDRESS>/24/default?_function=next_available_ip"
If you are getting ips without providing #{network}, It must be that the network is there in the resource_uri, part. Can you please provide your resource_uri ? I mean if it contains the network ref there?
I referred this link too: https://community.infoblox.com/forum/ddi/definitive-list-rest-examples,
Please help me with any better API docs if you have.

According to the docs you linked, you need the ref to do that function.  The ref is loaded when you query the API for the network object first.  This code works for me (using the current version):
connection = Infoblox::Connection.new(username: '...',
                                      password: '...',
                                      host:     '...',
                                      logger:   Logger.new(STDOUT))
network    = Infoblox::Network.find(connection,
                                   network: '<IP_ADDRESS>/24').first
puts network.next_available_ip

Is there some reason you can't do it this way?

Thanks @unclebilly , Infoblox::Network.find approach worked. You can close the PR, or if you want I can revert the change and keep just the network_spec.rb after updating it.

OK @prabhu-das - I'm thinking this is a feature that can be documented better. I'll update the README with an example.


Revamp base image

Normal alpine? Install S6 ourselves?

Maybe we can get away with just flock+cron+mbsync+curl and no S6.


Reposition Post back button outside of Post border

What does this pull request aim to achieve? 💯
Centering the back button outside of the post border box.

Please be concise and link any related issue(s):
#804

[x] I have checked that no one else is working on similar changes.
[x] I have read the latest README and understand the development workflow.
[x] The name of this branch is: feature/<branch_name> (need to have cloned the repo not forked).
[x] This branch is rebased/merged with the latest master.
[x] There are no merge conflicts.
[x] There are no console warnings and errors.
[x] On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".

@ppagarawal let me know if this looks good :)

@nr431207 @idjevm Please check the alignment of the button. It appears to be fine for a few posts but not for all.

Any comments on the styling @ppagarawal ? I noticed that there is some mix up coloring happening on active and on hover. https://share.getcloudapp.com/OAuBG8bN

These will be addressed in future releases. These changes on mouse over and click is common across the platform.


Disable Compression

Hello I am looking for a way to disable compression, is it possible?
I am doing compression for my own with other library and I would like to use it because I am doing a double compression right now, with PhotoEditor and later with my own library.
Regards.

I am watching PhotoEditor code and this could be a problem too:
private Bitmap captureView(View view) {
        Bitmap bitmap = Bitmap.createBitmap(
                view.getWidth(),
                view.getHeight(),
                Bitmap.Config.ARGB_8888
        );
        Canvas canvas = new Canvas(bitmap);
        view.draw(canvas);
        return bitmap;
    }

This is the way to build the final image and it could be a problem because bitmap resolution is the resolution of the view, and view is a PhotoEditorView, so if an user has a low resolution mobile, bitmap will be a low resolution image.
Any help to get a hight quality image from editor?

This library is not designed to handle that. This issue is discussed here #10


Consider using BatchGetItem instead of Query for MultiQuery KCVStore API

+1 to this idea.
We are using the multi-item model to store information about "products". Each product is an edge with 12 attributes on the edge. A "domain" is stored as a node, and each domain can have multiple products.
To satisfy a "get all products for a domain" call, we start with a domain node and ask for all edges (products in this case).
This results in 102 queries to Dynamo when there are 100 products in one domain. Each edge is retrieved with a Query API call to Dynamo. Ideally, we could use BatchGetItem to retrieve a large number of edges. The problem is that to use BatchGetItem we need to first get a list of "rk" values for each product attribute. Since those values are shared amongst all edges, we should be able to make 1 call to get the "rk" values, and then use those to create requests in BatchGetItem. I proved this with a quick and dirty proof of concept locally.
I'm wondering out loud if we want to bubble up the option to get BatchGetItem? Does it always use BatchGetItem? Once a threshold is crossed (a node has >= 20 edges), do we transition to BatchGetItem?


Feature Request: Workspace Symbols

It would be really nice to have workspace symbols... I have a lot of pl/sql packages and having to do a file search for a procedure of a particular name is annoying. I'd much rather use "Go To Workspace Symbol".

Similar request of #41.
It's a missing feature I want to implement,


Update user-management.md

Updated the description according to the latest kotaemon version.
Description

Please include a summary of the changes and the related issue.
Fixes # (issue)

Type of change

[ ] New features (non-breaking change).
[X] Bug fix (non-breaking change).
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected).

Checklist

[X] I have performed a self-review of my code.
[ ] I have added thorough tests if it is a core feature.
[ ] There is a reference to the original bug report and related work.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] The feature is well documented.

When using TeiFastReranking as the reranking method, if a string exceeding the Max Tokens supported by the Reranker Model specified on the TeiFastReranking Server side is passed, the server returns an error. As a result, an error warning would also be displayed on the kotaemon interface. Although the is_truncated option was present in the kotaemon code, no processing was implemented for it. To address this, functionality was added to allow specifying the max_tokens option alongside the is_truncated option. If a string exceeding the specified max_tokens is passed, the string will now be truncated accordingly.


Add better CodeMirror folding options

Add XML fold to Response and Body. Add count of object directly inside of fold.  Include hotkeys Ctrl-Y to fold and Ctrl-I to unfold all XML/JSON data.
Description
Fix #315 by adding these hotkeys:
Ctrl-Y: fold all
Ctrl-I: unfold all
This is to create a tree-view like functionality that can completely fold XML/JSON data in Response and Body. The ability to fold XML data is helpful and only requires 1 line of code. There is no UI button to fold/unfold all but that can be added if users are looking for it.
https://github.com/usebruno/bruno/assets/115114979/5e04fbad-c6d0-46ba-bec9-f7d48c3e72be
Contribution Checklist:

[x] The pull request only addresses one issue or adds one feature.
[x] The pull request does not introduce any breaking changes
[x] I have added screenshots or gifs to help explain the change if applicable.
[x] I have read the contribution guidelines.
[x] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.

Welcome @n00o !
This is cool!
Thanks for adding this to Bruno! Merged!


DOC: update user manual for functions that ~moved from shapely.ops to shapely

From shapely 2.0, many functions that were in shapely.ops before, became available directly in the shapely namespace, I suppose in the spirit of Flat is better than nested. Some functions were also renamed to be more consistent with GEOS/PostGIS.
However, the user manual wasn't updated to reflect this. This PR tries to incorporate these changes.
I expected this to be a mainly cosmetic change, but while making the changes I encountered many more differences between the functions than I was expecting, so to be discussed how to deal with this:

line-like input versus explicit iterables of Linestrings: line oriented functions in shapely.ops support line-like input, but the equivalent functions in shapely don't . I changed the doc to reflect that, but maybe this is not wanted? Relevant functions:

shapely.ops.polygonizevsshapely.polygonize`
shapely.ops.polygonize_full vs shapely.polygonize_full

shapely.line_merge is a vectorized function and expects a (arraylike of) MultiLineStrings as input. Hence, many merge operations can be done in one call. shapely.ops.linemerge expects an iterable of line-line elements as input, and will merge those, so only one merge operation can be done per call.
some functions return slightly different results, e.g.:

shapely.shortest_line returns a LineString vs shapely.ops.nearest_points returns a Tuple of 2 Points

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 88.055%

Totals

Change from base Build<PHONE_NUMBER>1:
0.3%

Covered Lines:
2617

Relevant Lines:
2972

💛  - Coveralls

@theroggy Correct, the 1.x API (which still exists in some form in shapely.ops) had functions that accepted coordinate sequences and implicitly converted them to geometries, but the 2.x API doesn't promote this anymore and it's good to remove this usage from the manual.


Feature: try out different models and training strategies using notebooks and document them

We would like to test out different AI models and methods for the eye tracking process. We ask you to save your test and findings on notebooks inside the repository. The idea is to make simple proof of concepts so we can comparte the different methods.

can i do thus one , i am good at modelling

sure thanks a lot @KarinePistili

hey @KarinePistili i tried different models on the data we generate through calibration process , the accuracy and error rates are all depends on how perfect the user calibrate so their data dispersion becomes less.
the question arises here in my mind is what exact goal are we trying to accomplish using different models because more or less accuracy and errors are dependent on how user interact in test so even if we change various model , superiority of data will always be high
please clarify my doubt
thankyou


[modify] cms guide import feature

Coverage decreased (-0.2%) to 84.374% when pulling b6253d7c406e2298b496f12c7ab7c9bd8f2cb49b on feature/cms-guide into 7bfdddb082cd74ff394b39d06021af60cf2d4bea on master.


used a better name for Vehicle abstraction

I think Vehicle would be a better name here, as it would better replace Car and Bicycle. A Traveler would be more of a human being to me.

Than you


Icon request: Porkbun

URL of the site or app (required):

https://porkbun.com

Logo resources for the icon (optional, but recommended):

SVG Logo from their homepage
Official branding page: https://porkbun.design

Here you go!
https://github.com/krisu5/aegis-icons/blob/master/PNG/Porkbun.png


fixed NaN-bug in custom date field when value is 0000-00-00

Description
Please describe your pull request:

When article has a custom field of date-type and is saved without an input in said field, the value '0000-00-00' is saved. When article is opened again in backend, it shows 'NaN.NaN.0NaN'. This 'value' however can not be saved in the date-type-field since this is not valide input.
This fix checks if the value creates a NaN-Output. If it does, null is returned. If not, the valid date is returned.
No known side effects.

Questions
Answers

BC breaks?
unknown

Tests pass?
unknown

Related tickets?
unknown

How to test?
Create custom field for article of type "date". Create new article and leave said field empty. Reopen the new article: the custom field displays NaN. Now article can't be saved until NaN is deleted from the field. With this fix however, the NaN-output is catched and null is returned instead.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-17960.
Please use this issue to track the state of your pull request.


Request: Sawmill Factories

Given the common tree farm's production output, a sawmill factory just  makes sense.  Not to mention after watching a tutorial video on the Logistical Sorter, now more than ever do I want this to be a thing.

++ to this!

++ Sawmill factory would be very nice, given how much wood is used in crafting all kinds of stuff.

If this were to become reality at this point, what is the likelihood of it being a 1.7.10 v9 feature?

@MyNameIsKodos 0.01%

Request was put in literally over a year ago so meh. Was hoping Aidan would toss it in but he made factory versions of a bunch of other stuff instead. Kind of surprised really.

On Apr 8, 2017, at 9:19 AM, Kodos Macarthur<EMAIL_ADDRESS>wrote:
If this were to become reality at this point, what is the likelihood of it being a 1.7.10 v9 feature?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Meh alright. I'm just gonna close this. I honestly don't care whether they're added or not if they're not being put into 1.7.10 at least.


TemplateLinks for layers need to partially replace templated path variables

Consider the following example:
type Api = "api" :> "add" :> Capture "x" Int :> Capture "y" Int :> Get '[JSON] Int

ghci> :k!  Server (Resourcify (MkLayers MyApi) (HAL JSON))
= (Int -> Handler (HALResource Intermediate))
  :<|> (Handler (HALResource Intermediate)
        :<|> (Handler (HALResource Intermediate)
              :<|> (Handler (HALResource Intermediate)
                    :<|> Tagged Handler EmptyServer)))

Created layers and server are correct.
However, in the instance BuildLayerLinks where the next layer is a Capture, we always only create a fully templated RelationLink.
This is wrong, because the endpoint of the layer itself may have taken an argument, like (Int -> Handler (HALResource Intermediate)) in above example.
Therefore the following request mistakenly returns the template to the next capture y without adding the provided value for x:
GET http://localhost:8080/api/add/5

{
    "_embedded": {},
    "_links": {
        "self": {
            "href": "/api/add/5"
        },
        "y": {
            "href": "/api/add/{x}/{y}"
        }
    }
}

This can be fixed by creating a Link for the layers endpoint (consuming all handler arguments) and then converting that Link to a RelationLink, adding a placeholder for the children.

Above PR made it work:
GET http://localhost:8080/api/add/5

{
    "_embedded": {},
    "_links": {
        "self": {
            "href": "/api/add/5"
        },
        "y": {
            "href": "/api/add/5/{y}",
            "templated": true
        }
    }
}


lax.conv_transpose has different convention than TF, document it and make switching easy?

See screenshot:

Though the example uses Haiku, Haiku is just calling through to lax.conv_transpose.
The difference is in reversing the spatial axes of the kernel.
We can do at least two things to make this less surprising and more easily fixable:

document the difference, and
add an argument to lax.conv_transpose to instead use the TF convention.

Hi @mattjj,
I was looking at this issue and found this documentation on line 293 of jax/_src/lax/convolution.py:

transpose_kernel: if True flips spatial axes and swaps the input/output
  channel axes of the kernel. This makes the output of this function identical
  to the gradient-derived functions like keras.layers.Conv2DTranspose
  applied to the same kernel. For typical use in neural nets this is completely
  pointless and just makes input/output channel specification confusing.

Any chance 2 has been implemented already? I agree the documentation could be more conspicuous.
Thank you!

@mattjj Hi, I find it as good first issue. I want to contribute this repo for the my first github contribution. Do u have something I can help?

Hi @mattjj I have taken a look at this issue regarding the difference in reversing the spatial axes of the kernel between Haiku's call and lax.conv_transpose. I understand the potential sources of confusion and believe that the proposed solutions, both documenting the difference and adding an argument for the TF convention, are valuable.
I'm eager to contribute and work on this issue.


feat(points): Implement Points Home screen

Description
For ACT-1022. Adds in the Points home screen and sets up Statsig to store points config information.
See the Statsig Dynamic Config here. Points visibility is gated by the feature gate here.
Note that at the moment, this PR is complete except for:

The actual Points logo/icon - I'm waiting on a high-quality vector image before adding it to the branding repo.
Some copy on the Swap bottom sheet.

I added in the functionality to automatically create "sections" on the home screen for different point values - we won't need this immediately, but it was kinda fun to add to figured why not :)
Test plan
Unit and manual tested. See video below.
https://github.com/valora-inc/wallet/assets/569401/c854b3d3-31c8-4d54-92f2-e65ed6bc2b76
Related issues

Fixes ACT-1022.

Backwards compatibility
Yes.
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will:

[X] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

@jophish looks like the touchable area for the header info icon is overlapping with the others. We should wrap the icon similarly what's done in src/components/QrScanButton.tsx and include it along with others in ACT-1136. This seems fine as a follow up to me.


Too Many Error In your Code.

No defense but your code are such mass. First when I run cd chatbot && python3 bottrainner.py it says:
Traceback (most recent call last):
  File "bottrainer.py", line 20, in <module>
    from chatbot.tokenizeddata import TokenizedData
ModuleNotFoundError: No module named 'chatbot'

So I run python3 chatbot/bottrainer.py then it says:
self.text_set = self.text_set.concatenate(src_tgt_dataset)
AttributeError: 'RepeatDataset' object has no attribute 'concatenate'

obviously, this is totally nonsense line of:
self.text_set = self.text_set.concatenate(src_tgt_dataset)

I uncomment the concatenate line, and it goes this error:
Traceback (most recent call last):
  File "chatbot/bottrainer.py", line 142, in <module>
    bt = BotTrainer(corpus_dir=corp_dir)
  File "chatbot/bottrainer.py", line 30, in __init__
    tokenized_data = TokenizedData(corpus_dir=corpus_dir)
  File "/Volumes/xs/CodeSpace/ng/ai/experiment/ChatLearner/chatbot/tokenizeddata.py", line 72, in __init__
    self._convert_to_tokens(buffer_size)
  File "/Volumes/xs/CodeSpace/ng/ai/experiment/ChatLearner/chatbot/tokenizeddata.py", line 249, in _convert_to_tokens
    output_buffer_size=buffer_size)
  File "/usr/local/lib/python3.6/site-packages/tensorflow/contrib/data/python/ops/dataset_ops.py", line 813, in map
    return MapDataset(self, map_func, num_threads, output_buffer_size)
  File "/usr/local/lib/python3.6/site-packages/tensorflow/contrib/data/python/ops/dataset_ops.py", line 1436, in __init__
    self._map_func.add_to_graph(ops.get_default_graph())
  File "/usr/local/lib/python3.6/site-packages/tensorflow/python/framework/function.py", line 619, in add_to_graph
    self._create_definition_if_needed()
  File "/usr/local/lib/python3.6/site-packages/tensorflow/contrib/data/python/framework/function.py", line 167, in _create_definition_if_needed
    outputs = self._func(*inputs)
  File "/usr/local/lib/python3.6/site-packages/tensorflow/contrib/data/python/ops/dataset_ops.py", line 1422, in tf_map_func
    ret = map_func(*nested_args)
  File "/Volumes/xs/CodeSpace/ng/ai/experiment/ChatLearner/chatbot/tokenizeddata.py", line 248, in <lambda>
    (self.case_table.lookup(src), self.case_table.lookup(tgt)),
  File "/usr/local/lib/python3.6/site-packages/tensorflow/contrib/lookup/lookup_ops.py", line 186, in lookup
    self._table_ref, key_tensor, self._default_value, name=scope)
  File "/usr/local/lib/python3.6/site-packages/tensorflow/python/ops/gen_lookup_ops.py", line 288, in _lookup_table_find
    name=name)
  File "/usr/local/lib/python3.6/site-packages/tensorflow/python/framework/op_def_library.py", line 767, in apply_op
    op_def=op_def)
  File "/usr/local/lib/python3.6/site-packages/tensorflow/contrib/data/python/framework/function.py", line 81, in create_op
    data_types, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/tensorflow/python/framework/function.py", line 361, in create_op
    **kwargs)
  File "/usr/local/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 2506, in create_op
    original_op=self._default_original_op, op_def=op_def)
  File "/usr/local/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 1250, in __init__
    input_types))
TypeError: In op 'hash_table_Lookup', input types ([tf.string, tf.string, tf.string]) are not compatible with expected types ([tf.string_ref, tf.string, tf.string])

I have no idea how you write your code, but this is really not worth to waste time on this buggy project.

Do you have an environment variable PYTHONPATH setup? I ran this in Windows, and if the project root is C:\Python\ChatLearner, I set PYTHONPATH to be: C:\Python\ChatLearner. This way, any relative module import (modules inside this project) should work.
Please let me know if you see any other problems after that.

@jinfagang , no problem. Please let me know if you see any other issues.


Verbose logging

For each experiment, UpGrade should allow the user to enable verbose logging.
Under verbose logging, UpGrade logs any API calls (as "info" log messages). For example, when getAllExperimentConditions is called, each experiment that is in verbose mode should log something like:
INFO: getAllExperimentConditions: experiment: "experimentName", user: "userID", condition: "conditionCode", enrollmentCode: "code"
We should always use verbose logging in preview mode but also allow it to be turned on in other statuses.

@nirmalpatel can you explain what the new "logging" checkbox provides and whether all UpGrade user roles can use/see it?

@amurphy-cl when you turn on "logging" for an experiment, it will start logging /assign and /mark calls for that experiment into the backend's running terminal. This is to help with QA/debugging.


Add --system config commands, elevate install config to system scope when root/packaged

These changes modify the packaged install experience, pulling-up config changes currently made in the current user "global" config (~/.gitconfig), to instead be made at the "system" config (/etc/gitconfig).  That way, Git LFS is installed once per-system, and does not require additional configuration should a different user start using Git LFS and therefore require the smudge/clean filters.
Note that these changes presume that it is safe to have the Git LFS filters installed and that they do and will continue to run as fast noops in non-Git LFS repos.
The elevation from global-to-system occurs automatically provided:

The installation runs as root
--local is not specified.

Additionally, post-install and pre-remove scripts are added to deb and rpm packages.  Since these run as root, they automatically elevate and install to /etc/gitconfig.
I don't know how this plays-out on Windows.

I guess I was envisioning --system and --global, and hadn't really thought of it detecting root access. Should the output of the command change to match?
$ git lfs install
Git LFS initialized to system config.

@andyneff Do the debian and rpm changes look good?
@shiftkey: Does Git for Windows run as an admin? May be a moot point if the maintainer wants to keep hard coding the config values.
@strich: Would the Windows Installer need any changes to take advantage? We'd have to confirm that it can detect windows admin access.

Would the Windows Installer need any changes to take advantage? We'd have to confirm that it can detect windows admin access.

The Windows installer already requests admin elevation, so that'll be fine.

RPM :+1:
Don't know about deb, @ssgelm ?
FWIW, I would prefer a --system or --global instead of ever detecting root and acting differently, just to match how other git operations normally work.

I think the deb changes are fine.

Also +1 to having a --system flag instead of magic.

Considering this is an install command, I think assuming root makes sense. I wouldn't expect users to read the docs to decide if they want git lfs install --global or git lfs install --system. That said, I agree with @strich's concerns about compatibility across all our platforms (expressed in chat).
What if we did both? By default, it installs to the system config, or global config if you don't have access. Then add --global and --system options to force those without checking user access (in addition to the existing --local flag).

Is there an issue, or a wiki, tracking the roadmap-detail for installation-experience?  There's been a number of suggestions around user-experiences around the installation workflow and timing of the installation and configuration of LFS, especially as it relates to when they cloned a repo with LFS-pointers etc.  A reasonable number of user-issues relate to install/timing and install-config scope etc. e.g. #1167 .
Some thoughts:

Expect that most users on Linux will install via a RPM or DEB package, and expect that wherever possible a) this completes the installation process, no-need to run git lfs install to obtain user-default or system-level installation/configuration/activation and b) whatever config is done is done equally for all users.
There might be a form-factor issue here with git lfs install, because correct me if I am wrong, but it needs to install the filters per this issue, which can be performed at various scopes, but it also needs to install the pre-push hook, which can only be done within the scope of a local repo/working-copy.  This raises for me the question - should there be an install-time pre-config step at all?  Is it possible to simply detect a) a repo with Git LFS artifacts in it and b) the first Git LFS command run within a repo, and set local configuration accordingly?  That might be too difficult - are there any root-level marker files?  Is it possible to simply catch everything just-in-time and create the appropriate LFS filters and hooks?  The main impact of course is the clone-workflow, since you can't set the filters locally before fetching the clone, unless you inspect it remotely.  But it might be reasonable for that workflow to require a second command to then resolve the binaries?
This change seems necessary as things stand now, since "global" Git config is in-fact user-config, and this doesn't look right for system-wide RPM or DEB installation, and having to run an additional command post-install to "install" is confusing.  But if the above held, and we were able to perform just-in-time configurations, preferably at local/clone scope only, perhaps requiring some different user-workflows for initial clones etc., then this change makes no sense.  In other words, if we could avoid static configuration outside of a working-copy, that seems preferable.  And if at least some common-enough end-user workflows would require a git lfs install --local in the repo before they can work properly, then there's still a confusing issue present.  And we might stop using the word "install" for repo-level operations, if it confuses with binary/runtime-level operations.  "activate"?  If auto-activation can't be achieved.
Perhaps the system-level filter that gets installed could be a meta-filter, that is capable of detecting LFS clones and installing all required configuration locally-only? Very much thinking out-loud here ...

@technoweenie

Does Git for Windows run as an admin? May be a moot point if the maintainer wants to keep hard coding the config values.

The installer does, but there is also a PortableGit version that doesn't require elevation - it just unpacks itself to a directory and does the bare essentials to give you a Git environment...
With respect to the hard-coded configuration values - we can switch that out to use a git lfs ... command in a future update but that will run at packaging time, not when the end user runs the installer. We just need to ensure we handle install/update/uninstall correctly and everything should be :sparkles:...

@javabrett Great points!

Expect that most users on Linux will install via a RPM or DEB package, and expect that wherever possible a) this completes the installation process

With my suggestion here, they can just run git lfs install --system and git lfs uninstall --system.

should there be an install-time pre-config step at all? Is it possible to simply detect a) a repo with Git LFS artifacts in it and b) the first Git LFS command run within a repo, and set local configuration accordingly?

It is possible. But I wouldn't want it to setup the filters in the local git config. The problem here is that git lfs uninstall can't work without scanning user data for LFS repositories. The nice thing with the current system is that the only per-repo thing people need to do is delete the .pre-push hook. It tells you how to do that when it fails due to git-lfs not existing.
Also, without any LFS filters setup, it's too easy to add and push files that should be in LFS if it's not installed.

One side-note - I looked at:
// InstallOptions serves as an argument to Install().
type InstallOptions struct {
        Force bool
        Local bool
}

... noticing the bool for Local, false implying Global and that we now need a third System, and then looked at how go implements an enum, which then seemed beyond my go-chops.  Is that what would be required, promoting this boolean to an enum?

Note to self more than anything - part of the issue with enforcement of LFS processes, or at least issuing warnings when something is missing, is that there is no option to have Git itself issue a warning or failure if a filter is missing or not-configured.  Git treats this condition as a no-error noop.

Added another commit to:

add the --system option, making in mutually-exclusive to --local
remove the euid detection and auto-promotion to system-config
replace it with --system in the package post-install commands.

You can test the new switch with sudo git lfs install --system.
While testing this I ended up shaving yaks trying to work-out what on earth goes on with error-swallowing in subprocess/SimpleExec, when you get say a permissions-error trying to SetSystem as non-root.  Those methods are swallowing errors, but that's not the only problem, there's something in SimpleExec too.  Perhaps many git commands return non-zero status and tests need to ignore that?
I decided not to let it hold-up review of the additional commit.  You will notice that if you run without sudo, so git lfs install --system as a regular user, LFS will report success, but there will of course be no change to /etc/gitconfig due to not being root.  I compensated by leaving one euid check in now to print a warning about likely failure if you are not root.
I'll ask about the error-swallowing separately and link to here.

Fixed the SimpleExec problem and stopped throwing-away Config Set errors (Config Unset needs to be ignored in terms of git config --unset return code, since it returns 5 if missing), so that failures are now nicely reported e.g.:
Error running git [config --system filter.lfs.clean git-lfs clean -- %f]: '' 'error: could not lock config file /etc/gitconfig: Permission denied' 'exit status 255'

Looks like I've unintentionally used something new in Go 1.6 API - ExitError Stderr.

Fixed so it compiles with Go 1.5 by pulling-down a couple of utility methods from Go 1.6 (in a single commit so it can be easily reverted to a Go 1.6 version).  Removed the nasty bool for optional swallow-error in SimpleExec - it now properly returns an error but ensures that the Output string return is "" in such cases.  I suspect this wrapper was/is compensating for commands which failed whilst writing guff to stdout instead of stderr.

Global currently remains the default scope (and there's no explicit switch for it yet) for install.
Will it matter that having run a --system level install (either explicitly or as part of a package post-inst script), later install commands at either default global or --local scope will duplicate the filters at that lower scope?  It appears that is what git config does.  So you could end-up with filters installed in all of system/global/local scope.
Matters because I expect an in-repo install is still required at least once to install the pre-push hook.  Is anything being worked-on to either auto-install that, or produce warnings when it is missing etc.?  Should we be splitting install into components, since filters will now hopefully be commonly auto-installed at system-level, but a manual repo-level command remains.  Or should filter install manually check higher scopes to see if it is even required?

Doh, I don't know why this was left out of v1.3. Sorry for dropping this on the floor.

Matters because I expect an in-repo install is still required at least once to install the pre-push hook.

Hooks are installed in the following commands: clean, fsck, push, smudge, track, and untrack. It can be added to more commands with lfs.InstallHooks(false).
There's also a git lfs update command that installs hooks.  Ideally, people don't have to run git lfs install on every repo. I think checking for existing filter values before setting them makes sense too.

I fixed a merge conflict so we can ship this in v1.4: #1460. I couldn't think of a suitable shortcut for --system (since --skip-smudge is using -s), so I'm keeping it blank.

@javabrett Thanks again for tackling this :metal:


Switcher Window Shows up too small

When I press Cmd+E, sometimes the extension shows up in appropriate size, but also it appears to be overly small in many other tiems.

Unfortunately this seems to be a bug in Chrome, see #91, please feel free to bring this to the developers attention as it's an old one :|


Feature : The group link text area grabber should be disabled

Is your feature request related to a problem? Please describe
No

Describe the solution you'd like
The text area of the group invite link can be increased as much as you want.But it would be disabled ,so that no one can change it's size.
Describe alternatives you've considered
No response
Additional context
No response
Are you working on this?
Yes

Hi @sahiladit
I have looked into the issue and yes the text area is extending to a very long size which is pretty much unnecessary.
So the address the issue, i came up with two ways to correct this problem-

To give the text area a fixed size and keep the overflow link text hidden.
To avoid overflow clipping we can set height such that it will fit content dynamically

I think the second method would be suitable for this issue as the whole link will be visible without requiring user interaction or manual resizing.
if there is some more information regarding this issue can you please share it, i would love to work on this issue and have a better outcome.
Thanks

we can do resize none.

@sahiladit can we also please make sure that the text of the link is not overlapping with the copy SVG? You can probably move that icon outside the textarea div, right next to it.

@sahiladit can we also please make sure that the text of the link is not overlapping with the copy SVG? You can probably move that icon outside the textarea div, right next to it.

Sure


Filter items in relation field by default

I'd like the ability to filter a relation field to only display items that match a certain field.

Can you give an example?

I have two folder collections called Products and Product Categories. I have a few product categories, two of which are "electronics" and "accessories". I have a relation field to choose the product category but I also have another relation field to select multiple accessories for that product.
I want to be able to limit or filter the products that you can select in the accessories relation field to only products that have the category relation field set to "accessories".
I'd like to display a section at the bottom of my product page that lists the accessories available for that product. Because these accessories are also products, the user can click any of them to view these products using the products template just like any other product.
Here is a snippet in my admin config.yml.
collections:
  - name: "productCategories"
    label: "Product Categories"
    folder: "src/pages/product-categories"
    create: true
    slug: "{{fields.slug}}"
    fields:
      - { label: "Product Category Name", name: "title" }
      - { label: "Slug", name: "slug", required: true, pattern: ["^[a-z0-9]+(?:-[a-z0-9]+)*$", "Cannot contain spaces, capital letters, or special characters. You may separate words with dashes and numbers are allowed."], hint: "This will be used in the URL." }
  - name: "products"
    label: "Products"
    folder: "src/pages/products"
    create: true
    slug: "{{fields.slug}}"
    fields:
      - { label: "Product Name", name: "title" }
      - { label: "Slug", name: "slug", required: true, pattern: ["^[a-z0-9]+(?:-[a-z0-9]+)*$", "Cannot contain spaces, capital letters, or special characters. You may separate words with dashes and numbers are allowed."], hint: "This will be used in the URL." }
      - { label: "Category", name: "category", widget: "relation", collection: "productCategories", searchFields: ["title"], valueField: "slug", displayFields: ["title"] }
      - { label: "Overview", name: "overview", widget: "markdown" }
      - { label: "Price", name: "price" }
      - { label: "Accessories", name: "accessories", widget: "relation", collection: "products", searchFields: ["title"], valueField: "slug", displayFields: ["title"], multiple: true, required: false }
      - { label: "Related Products", name: "relatedProducts", widget: "relation", collection: "products", searchFields: ["title"], valueField: "slug", displayFields: ["title"], multiple: true, required: false }

Let me know if you need any clarification.

Sounds like it’s related to https://github.com/netlify/netlify-cms/issues/565

Yep, this is a duplicate of #565, please thumb that issue up and subscribe to get updates 👍

@erquhart @tomrutgers I think you might be misunderstanding what I am saying. From what I can tell this is a separate issue from #585 which advocates for conditional fields.
I am proposing a relation field displaying a filtered collection based on fields in each item in the collection being referenced.
In this context, I only want to display products in the relation field dropdown that are associated with the accessory category (where categories are its own folder collection). Are you following me?

Right - if we have conditional fields, you can set up two relation fields and display only one based on the value of the first relation field.
Sent with GitHawk

That is not what I am saying at all. Let me try to explain better.
In product edit screen, I want to have a relation field called accessories that lists other products, but only lists the products in the accessory product category.
Product Categories is a folder collection, each category is an item within that collection.
Consider the following...
Categories:

Electronics
Clothing
Accessories

Products:

iPhone (category: Electronics)
iPhone Case (category: Accessories)
T-shirt (category: Clothing)

If I go to edit the iPhone product, I see the following fields:

Title
Category (relation to Product Categories collection)
Price
Description
Accessories (relation to self - Products)

When I click on the accessories drop down, I only want to see iPhone case because this product has a category of accessories. I don’t want to see iPhone and Tshirt as they do not have accessories set as their associated product category. Does that make more sense?

Ah you're totally right, I was thinking you had different collections for each product category rather than a single product collection. We could add filtering to the relation widget with the same approach taken for the filter property on collections themselves: https://www.netlifycms.org/docs/collection-types#filtered-folder-collections
We would just need to treat the filter value as a template, so you could do:
  - label: "Related Products"
    name: "relatedProducts"
    widget: "relation"
    collection: "products"
    searchFields: ["title"]
    valueField: "slug"
    displayFields: ["title"]
    filter:
      field: category
      value: "{{category}}"
    multiple: true
    required: false

Thoughts?

You are on the right track! I’d do something like this...
  - label: "Related Products"
    name: "relatedProducts"
    widget: "relation"
    collection: "products"
    searchFields: ["title"]
    valueField: "slug"
    displayFields: ["title"]
    filters:
      - field: category
        values: ["accessories", "add-ons"]
      - field: colors
        values: ["red", "blue"]
    multiple: true
    required: false

This allows multiple filters and values to allow more flexibility.

Allowing multiple filters could work, but keeping it simple and using existing logic makes this low hanging fruit. You'll want to use template strings rather than hardcoding, hence my use of {{category}} rather than "accessories", as you need the current value of the field as the filter.
Sent with GitHawk

Related to this, it would be great if it'd be possible to filter on the existence of a field, so something like filter: {field: "myfield"} means "any value".

this feature would be awesome, so we could filter a relation by language for example

I was also looking for a feature like this, but it was not implemented yet even after so many years. I then created my own custom relation widget a couple weeks ago, which works exactly as @austincondiff mentioned, using:
filters:
  - field: category
    values: ["accessories", "add-ons"]
  - field: colors
    values: ["red", "blue"]

But I think this feature would be really nice to have in the relation widget by default. Could I pick this up?

Super cool that filters were added, but I don't think the current version covers the initial requirements on this issue. I don't see a way to filter the options based on a sibling field, only on a child field.
I want to have two relation fields next to each other, where the values of the second one are filtered based on the selected value of the first one. I believe that's what this comment above was referring to.

You'll want to use template strings rather than hardcoding, hence my use of {{category}} rather than "accessories", as you need the current value of the field as the filter.

Is this currently possible, or could it be possible?

It sounds like you could use variable types for that. Depending on the use case it might be a little cumbersome but I think it's work.


Box: make dataTestId an explicit prop

As a follow-up to #2451, this PR adds an explicit dataTestId prop to Box. Previously we've relied on the passthrough nature of Box to allow users to use data-test-id. However, this is a leaky abstraction, as the user has to be aware of the implementation of Box to know that they can pass through this undocumented "prop". By making this prop explicit, we ensure that users who are unfamiliar with Gestalt are able to easily add the test ids needed.
Note: though this is not technically a breaking change, as passing data-test-id will still work, this PR includes a codemod to change existing data-test-id props to dataTestId. In the future, we may remove the possibility to pass through data-test-id, which would be a breaking change.
CODEMOD
yarn codemod modifyProp ~/path/to/your/code --component=Box --previousProp='data-test-id' --nextProp=dataTestId

I think this implementation overrides any existing data-test-id. I think it’s a breaking change anyway. Can you double check?

I think I'm going to try a different approach for this at some point. Closing this for now


CORDOPLUG-238

Android code changes look good for me

For android automated tests are passing, so the MR can be closed as soon as iOS part is fixed

For me they succeed. Please make sure that you have configured the example app with the test environment (msp-snapshot-test.onegini.io). See also the internal docs on running the tests.


Add Gateway API v1.1 Blog Post

Add blog post announcing Gateway API v1.1 release, to be activated 5/13/24.
Preview: https://deploy-preview-45971--kubernetes-io-main-staging.netlify.app/blog/2024/05/13/gateway-api-v1-1/
cc @robscott

@candita, I just made a bunch of copyediting-type suggestions for consistency in how we refer to various things. Please don't take that as in any way indicative of a lack of appreciation of your work! 🙂

/label tide/merge-method-squash

Thanks @candita!
/lgtm on behalf of Gateway API maintainers.

So normally for release announcements, we only merge them once the release has actually happened. Would that fit here @candita?
I can LGTM and approve this and then let a SIG Network person unhold this PR once the release is confirmed.
/hold
Gateway API v1.1 isn't released yet. OK to unhold once the release has happened, provided the publication date is the same day or in the future.

@sftim publishing it on May 13 was what we expected.  If we can publish it earlier, do you think we need to change the publish date embedded in the folder name?

If we can publish it earlier, do you think we need to change the publish date embedded in the folder name?

Yes, you should change both places.

v1.1 released here: https://github.com/kubernetes-sigs/gateway-api/releases/tag/v1.1.0
/hold cancel
/lgtm


Add missing link blob label migration

This PR adds a missing migration to link blob labels, although it seems like this should have already been set in #2416.
Additions

Added missing migration auto generated by manage.py makemigrations.

Review

@sebworks

Checklist

[X] Changes are limited to a single goal (no scope creep)
[X] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[X] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

👍 why our angst? the streamfield changes are one-liners.

@higs4281 only 13,000+ characters wide! 😭


Feature Request: Add support for characters with Powerful Build trait/ which in turns requires size based calculations for carrying capacity.

"Powerful Build. You count as one size larger when determining your carrying capacity and the weight you can push, drag, or lift."
Currently everything assumes a medium sized character.
Each size category step increases or decreases (ignoring size Small) carrying capacity by a factor of 2. PHB p176: "Lifting and Carrying"
So just some simple math and a couple lines of code to look for creature size and if they have the powerful build trait flag in the character sheet's special traits.

Support has been added and is available in the 0,1,4 release!


normalize_estimator function trying to access non-existent attribute

See thread here: https://github.com/dask/dask-ml/issues/667
Proposing a change to subclass AttributeError to make it clear that you're accessing a non-existent attribute when calling the normalize_estimator function before training.

@blinickg I believe this should go in https://github.com/dmlc/xgboost, not here :) That's where the XGBoostError is raised.

Ah, OK. Thanks @TomAugspurger


[analyzer] Include arch subdirectories in LD_LIBRARY_PATH for logging

The issue with logging (see https://github.com/Ericsson/codechecker/issues/4360 for details) came up on my Ubuntu24 machine, where only specifying the <data_files>/ldlogger/lib in the LD_LIBRARY_PATH was not enough for the dynamic loader to load the ldlogger.so inside <data_files>/ldlogger/lib/x86_64, so I observed there is no implicit architecture resolution in the logic of the loader. There were other tests on other distributions where this implicit architecture resolution seems to exist (rhel7, rhel8, ubuntu22, among others).
The solution implemented by this patch is adding all <data_files>/ldlogger/lib/* folders in addition to the current  <data_files>/ldlogger/lib folder to the LD_LIBRARY_PATH.
I have tested it on Ubuntu24, and the multiple .so files that are possibly reachable due to all of them being added are not an issue. The logger works as expected, and if I remove only the relevant ldlogger.so (x86_64 for my machine) but keep the others, the CodeChecker log command correctly detects that I meet neither the ld-logger nor the intercept-build requirement.

The issue with logging (see #4360 for details) came up on my Ubuntu24 machine, where only specifying the <data_files>/ldlogger/lib in the LD_LIBRARY_PATH was not enough for the dynamic loader to load the ldlogger.so inside  <data_files>/ldlogger/lib/x86_64, so I observed there is no implicit architecture resolution in the logic of the loader. There were other tests on other distributions where this implicit architecture resolution seems to exist (rhel7, rhel8, ubuntu22, among others).
The solution implemented by this patch is adding all <data_files>/ldlogger/lib/* folders in addition to the current  <data_files>/ldlogger/lib folder.
I have tested it on Ubuntu24, and the multiple .so files that are possibly reachable due to all of them being added are not an issue. The logger works as expected, and if I remove only the relevant ldlogger.so (x86_64 for my machine) but keep the others, the CodeChecker log command correctly detects that I meet neither the ld-logger nor the intercept-build requirement.

sounds good. did you test this on older distros? (ubuntu 20, 22,rhel8,rhel9)

You may want to try out this implmentation on the following test
test.c:
int main(void){
  return 0;
}

builder.c:
#include<stdlib.h>
int main(void){
  const char* command="gcc ./test.c";
  system(command);
  return 0;
}

gcc -m32 ./builder.c -o builder32
CodeChecker log -b ./builder32 -o compile_command32.json

Hi, I have tested with the suggested method, and both logs have the correct content.
I tested the above approach but modified the builder to make it even more convoluted like this:
#include<stdlib.h>
int main(void) {
  system("/path/to/32bitcompiler/bin/clang -o test_build_with_clang32 test.c");
  system("/path/to/64bitcompiler/bin/clang -o test_build_with_clang64 test.c");
  return 0;
}

Then, build this to builder32 and builder64, and log them like this:
strace -fte trace=%process,%file CodeChecker log -b './builder32' -o ccdb32.json 2>&1 | tee strace_log32
strace -fte trace=%process,%file CodeChecker log -b './builder64' -o ccdb64.json 2>&1 | tee strace_log64

Then, the contents of BOTH ccdb32.json and ccdb64.json:
[
	{
		"directory": "...",
		"command": "/path/to/32bitcompiler/bin/clang -o test_build_with_clang32 test.c",
		"file": "test.c"
	}
	,
	{
		"directory": "...",
		"command": "/path/to/64bitcompiler/bin/clang -o test_build_with_clang64 test.c",
		"file": "test.c"
	}
]

All in all, I see this is the expected behaviour.

@dkrupp Thanks for the suggestions. I implemented and verified all of them on Ubuntu24 and this Ubuntu20 test environment.


Can I run jstify without browserify?

I'd like to use require(./my_template.jst); from the server, not using browserify. Is this possible?

Now you can. I just published<EMAIL_ADDRESS>and it adds a require hook. https://github.com/zertosh/jstify/commit/c186b8c06489f03f8474a14f00c5aa4f26a723ea


Update to Rust 2018 Edition

The main goal here is to fix a few no_std issues:

Fix some no_std compilation errors
Update no_std to use hashbrown rather than hashmap_core
Update no_std support to work more like Cranelift's no_std support works, which uses Rust 2018.

Thank you for the patch!


Update RFC with outcomes from blueprint discussion

Link to rendered markdown:

https://github.com/rerun-io/rerun/blob/663ca33458c19bcc11286b9d9c855b9699430024/design/blueprint_store.md

Checklist

[ ] I have read and agree to Contributor Guide and the Code of Conduct
[ ] I've included a screenshot or gif (if applicable)

PR Build Summary: https://build.rerun.io/pr/2302

Docs preview: https://rerun.io/preview/663ca33/docs

Added some suggestions regarding "tile" -> "view naming which I think we should use for now. Also added some regarding the meaning of a "Data blueprint", but don't know if I caught all of it

Thank you!