404 on index page

Description
When I navigate to the index page for my app, it loads everything fine, then renders a 404 once the JS kicks in. (You can see the result here).
I have a feeling it's to do with the site being served from a heavily nested subdir, but I'm not sure why exactly. I've correctly set the publicPath in the settings as it's being propagated to all the CSS and JS links.
It works on a lesser nested route when I deploy to there, so I know the publicPath works in that case at least. Maybe it's the /-/ parts inthe url that are throwing it off?
Steps to reproduce
You can see the project over on GitLab and the failing build here. If needed I can provide the artifacts of the built site too.
You should be able to fork that project and tests the builds if you have a GitLab account.
Expected result
It should render the index page as normal
Actual result
The index page loads, then the JS kicks in and displays a 404 message.

As is usually the case with these things. I have found the source of the issue 5 minutes after posting the issue itself.
It seems the app is accessing the ENV file at two different points during the build. Once when generating the HTML and again when generating the JS. When generating the HTML it has access to the ENV variables I need and is setting the paths for the JS correctly. But when the JS is being generated, it doesn't have access to them and is sending an incorrect publicPath to the Vue Router.
I'll do a bit more digging to see why it's getting two different values during the same build process, but it may be an issue outside of this repo.

It may be an issue with this line in the router file. Changing it to the below might help, though testing it against my build is proving difficult
 base: config.pathPrefix || process.env.PUBLIC_PATH,

When it comes to SEO it's not a good idea to make the same page accessible from different routes, unless you add a permanent redirect from the index.html route or something. To me it feels like a non-issue that index.html returns a 404, because I doubt any user would access that page directly.

The page isn't accessible from different routes. It's only accessible from /index.html on the server side. But it's only accessible from / on the vue-router which is where the confusion comes from.
My suggestion would be to be able to configure whether the home page is at / or at /index.html in the router. That way you can have whichever server setup you like and gridsome won't break it.

You said:

"The issue is because I was accessing the page at example.com/index.html instead of example.com/ and vue router didn't have an entry for index.html, which explains the flashing and the redirect to a 404.
I'm not sure if this is something that should be covered with Gridsome, given that it does generate a page at index.html but no corresponding vue-router route."

Which led me to believe that you wanted the Vue router to acknowledge and route index.html as well. But maybe I misunderstood. Because that would make the page accessible from different routes.


@hitparry work with exact damage rather than %

Can we make the trigger work with raw numbers rather than %? or can we get the raw damage being applied as an argument so we can determine a % we'd like to block?

Thank You guys, awesome as always.


Split up/Refactor constants file

Right now the constans file is very large, this should be split up into smaller files (e.g addresses, boost, contracts) to make it easier to manage

closed by #591


Chromium: Drawing Buffer Problem on Ultra-HD Resolutions

Chrome limits the drawing buffer with and height to a specific value. Therefore, ultra HD resolutions cause a broken aspect ratio. The issue is reported at the chromium project (see  issue 445542). Fortunately, the bug is already fixed, but not yet committed to a release build. Some automatic tests still causes errors with the new logic.

Bug is now fixed for Chrome Canary.  Resolution up to 5k are supported now (4096x4096 total amount).


Update Dome versions

Update gazebo and transport versions for Dome.
Signed-off-by: Nate Koenig<EMAIL_ADDRESS>

This requires:

[ ] https://github.com/ignitionrobotics/ign-gazebo/pull/262
[ ] An ign-gazebo4 nightly release with :point_up:
[ ] A homebrew-simulation commit update

@osrf-jenkins run tests please

I think we just need these:

https://github.com/osrf/homebrew-simulation/pull/1063
https://github.com/ignitionrobotics/ign-dome/pull/2

@osrf-jenkins run tests please

Ok, all CI is happy except:

ubuntu_auto: needs patching, running the test for the fix here
Action for Focal: it requires fixes from ign-launch2 branch. It's going to be much easier to merge this first and do the forward port after.

There is only one cmake warning left in the CI that require a bit more of work to be fixed.
Ubuntu should be fixed after https://github.com/ignition-tooling/release-tools/pull/259. Ready  to merge.

Copied the fix from https://github.com/bombela/backward-cpp/pull/165 on f52c9f3 to fix the Focal build.


License

Hey,
thanks for your awesome work. Can you add a license (e.g. MIT license) to your work? This would allow other people to build on top of your code.
Thanks!

Thanks for the reminding. Added.


Pulling hashicorp image with specific tag to avoid E2E test failure

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Does this PR introduce a user-facing change?

Additional Notes for your reviewer:
Review Checklist:

[ ] Follows the developer guidelines
[ ] Relevant tests are added or updated
[ ] Relevant docs in this repo added or updated
[ ] Relevant carvel.dev docs added or updated in a separate PR and there's
a link to that PR
[ ] Code is at least as readable and maintainable as it was before this
change

Additional documentation e.g., Proposal, usage docs, etc.:

/cherry-pick 0.57.x


Class canceled seems to have hung

Class canceled seems to have hung.  noted that the logs hung up on a waiting student. changed the waiting students to canceled then ran again and it succeeded.

made updates to the class cancel to address this issue will need to reopen if happens again.


Migrate Language Files & Localization

Details

I've updated the description and code in the "From .NET" section, to use dependency injection.
I also removed the initial "~" in the Package language files and User language files section, since there now is a folder named "~"  which might cause some confusion.
I updated the folder path in "Core language files" to match the new folder names
I haven't updated the links to other articles, since they haven't been migrated yet, and therefore doesn't exist.

I also removed the initial "~" in the Package language files and User language files section, since there now is a folder named "~"  which might cause some confusion.

Just to make it clear. This folder ~ is unintended.  ~ used to mean the virtual root of the application, but this is really a Webserver thing (IIS). Kestrel only supports one root, so  ~ is always empty. That means your change is still correct :)


Doesn't work under TMUX od SCREEN session

I get this when I run under tmux or screen session:
injector: injector.c:1410: main: Assertion `!mprotect(packet_buffer,4096,0x1|0x2|0x4)' failed.

Surprisingly, I get this error running inside of Gnome Terminal, without tmux.

I also get:
File "./sifter.py", line 842, in <module>
                                                                                main()
                                                                                File "./sifter.py", line 833, in main
                                                                                gui = Gui(ts, injector, tests, args.tick)
     File "./sifter.py", line 376, in __init__
                                                  self.init_colors()
                                                                      File "./sifter.py", line 423, in init_colors
                                                                                self.COLOR_BLACK
                                                                                _curses.error: init_pair() returned ERR

export TERM=xterm-256color before running. I ran into this problem with urxvt and a vty

@mjsmith707  This fixes PuTTY as well.


Improve the whole ui of the website

i can show you the sample of how it will look

i can show you the sample of how it will look

yes please.

https://github.com/user-attachments/assets/02a2a2e4-fb9f-4c4b-a8e1-d2026fb08338

Untitled.video.-.Made.with.Clipchamp.12.mp4
@vishanurag Kindly tell me if this will work there are several functions in the current one which doesn't work I have fixed them..

I have assigned this issue to you. But remember that navbar, footer and other options should be present.

Untitled.video.-.Made.with.Clipchamp.12.mp4
@vishanurag Kindly tell me if this will work there are several functions in the current one which doesn't work I have fixed them..

I have assigned this issue to you. But remember that navbar, footer and other options should be present.

Yes for sure don't worry I will finish this by tonight I'm in college right now


Can I use "Arbitrary values" for variants and slots?

I would like to use the Tailwind CSS "Arbitrary values" in variants and slots, but I couldn't figure out how to write it. Is there any documents or reference code?
const styles = tv({
  variants: {
    focusable: {
      true: 'some-classes',
    },
    tabbable: {
      true: 'some-classes',
    },
  },
  compoundVariants: [
    {
      focusable: true,
      tabbable: true,
      className: `max-h-[${someArbitaryValue}]`,
    },
  ],
})

// Can you pass `someArbitaryValue` to styled?
<SomeComponent className={styles({ focusable, tabbable })} />

I couldn't figure it out from the documents so I surpassed it by writing the following.
const styles = tv({...})
const maxHeightStyle = focusable && tabbable ? `max-h-[${someArbitaryValue}]` : ''

<div className={`${styles(...)} ${maxHeightStyle}`} />

That is not valid Tailwind code, so this is not something that tailwind-variants will support. See the Tailwind docs about dynamic class names for why this is not valid.
https://tailwindcss.com/docs/content-configuration#dynamic-class-names

The class="w-[32rem]" is valid, but you think you don't need to use Tailwind if you write it dynamically in the style?
https://tailwindcss.com/docs/width#arbitrary-values

@uknmr The issue is with how Tailwind includes class names in the built CSS file. Take a look at the docs I linked to understand more, but basically it's looking for exact strings, but something like max-h-[${someArbitaryValue}] isn't an exact string, thus tailwind can't statically analyze what class names should be included in the output.

Thanks!!! I understood it by actually writing and outputting it.


Merge latest redirects to live

Docs Build status updates of commit fb775a0:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docset/winserver2016-ps/remotedesktopservices/Convert-License.md
:warning:Warning
View (WindowsServer2016-ps)
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docset/winserver2012-ps/remotedesktop/Add-RDServer.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Add-RDSessionHost.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Add-RDVirtualDesktopToCollection.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Disable-RDVirtualDesktopADMachineAccountReuse.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Disconnect-RDUser.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Enable-RDVirtualDesktopADMachineAccountReuse.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Export-RDPersonalVirtualDesktopAssignment.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDAvailableApp.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDCertificate.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDConnectionBrokerHighAvailability.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDDeploymentGatewayConfiguration.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDFileTypeAssociation.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDLicenseConfiguration.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDPersonalVirtualDesktopAssignment.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDPersonalVirtualDesktopPatchSchedule.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDRemoteApp.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDRemoteDesktop.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDServer.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDSessionCollection.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDSessionCollectionConfiguration.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDSessionHost.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDUserSession.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDVirtualDesktop.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDVirtualDesktopCollection.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDVirtualDesktopCollectionConfiguration.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDVirtualDesktopCollectionJobStatus.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDVirtualDesktopConcurrency.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDVirtualDesktopIdleCount.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDVirtualDesktopTemplateExportPath.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDWorkspace.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Grant-RDOUAccess.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Import-RDPersonalVirtualDesktopAssignment.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Invoke-RDUserLogoff.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Move-RDVirtualDesktop.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/New-RDCertificate.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/New-RDPersonalVirtualDesktopPatchSchedule.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/New-RDRemoteApp.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/New-RDSessionCollection.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/New-RDSessionDeployment.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/New-RDVirtualDesktopCollection.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/New-RDVirtualDesktopDeployment.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/RDMgmt.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Remove-RDPersonalVirtualDesktopAssignment.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Remove-RDPersonalVirtualDesktopPatchSchedule.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Remove-RDRemoteApp.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Remove-RDServer.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Remove-RDSessionCollection.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Remove-RDSessionHost.md
:white_check_mark:Succeeded
View (winserver2012-ps)

This comment lists only the first 50 files in the pull request.

docset/winserver2016-ps/remotedesktopservices/Convert-License.md

Line 0, Column 0: [Warning-file-not-found] Invalid file link: '../rdmgmt/Get-RDLicenseConfiguration.md'.
Line 0, Column 0: [Warning-file-not-found] Invalid file link: '../rdmgmt/Get-RDSessionHost.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit aff3174:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docset/winserver2016-ps/remotedesktopservices/Convert-License.md
:warning:Warning
View (WindowsServer2016-ps)
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docset/winserver2012-ps/remotedesktop/Add-RDServer.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Add-RDSessionHost.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Add-RDVirtualDesktopToCollection.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Disable-RDVirtualDesktopADMachineAccountReuse.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Disconnect-RDUser.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Enable-RDVirtualDesktopADMachineAccountReuse.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Export-RDPersonalVirtualDesktopAssignment.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDAvailableApp.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDCertificate.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDConnectionBrokerHighAvailability.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDDeploymentGatewayConfiguration.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDFileTypeAssociation.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDLicenseConfiguration.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDPersonalVirtualDesktopAssignment.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDPersonalVirtualDesktopPatchSchedule.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDRemoteApp.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDRemoteDesktop.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDServer.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDSessionCollection.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDSessionCollectionConfiguration.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDSessionHost.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDUserSession.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDVirtualDesktop.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDVirtualDesktopCollection.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDVirtualDesktopCollectionConfiguration.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDVirtualDesktopCollectionJobStatus.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDVirtualDesktopConcurrency.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDVirtualDesktopIdleCount.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDVirtualDesktopTemplateExportPath.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Get-RDWorkspace.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Grant-RDOUAccess.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Import-RDPersonalVirtualDesktopAssignment.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Invoke-RDUserLogoff.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Move-RDVirtualDesktop.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/New-RDCertificate.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/New-RDPersonalVirtualDesktopPatchSchedule.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/New-RDRemoteApp.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/New-RDSessionCollection.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/New-RDSessionDeployment.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/New-RDVirtualDesktopCollection.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/New-RDVirtualDesktopDeployment.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/RDMgmt.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Remove-RDPersonalVirtualDesktopAssignment.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Remove-RDPersonalVirtualDesktopPatchSchedule.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Remove-RDRemoteApp.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Remove-RDServer.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Remove-RDSessionCollection.md
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/winserver2012-ps/remotedesktop/Remove-RDSessionHost.md
:white_check_mark:Succeeded
View (winserver2012-ps)

This comment lists only the first 50 files in the pull request.

docset/winserver2016-ps/remotedesktopservices/Convert-License.md

Line 0, Column 0: [Warning-file-not-found] Invalid file link: '../rdmgmt/Get-RDLicenseConfiguration.md'.
Line 0, Column 0: [Warning-file-not-found] Invalid file link: '../rdmgmt/Get-RDSessionHost.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Missing license

Hi,
Do you have any plans for introducing specific license to this project?
I'd like to use a part of this library in my open source project if possible, though lack of license makes it a bit unclear if I can do so, especially that I don't really want to depend on the whole package, only on the ecliptic curve algorithm implementation.

Thanks for pointing that out. I thought I included a license from the beginning. I just added the MIT license (#16), mostly because it's what Vapor itself uses. Does that suit your need?

Sure it does, thanks!


Zhangli20 dev

Codecov Report

Merging #23 (68d25c1) into master (c09862b) will increase coverage by 0.04%.
The diff coverage is 1.96%.

@@            Coverage Diff            @@
##           master     #23      +/-   ##
=========================================
+ Coverage    0.00%   0.04%   +0.04%
=========================================
  Files          14      14
  Lines        2339    2362      +23
=========================================
+ Hits            0       1       +1
- Misses       2339    2361      +22

Impacted Files
Coverage Δ

datafusion-ext/src/batch_buffer.rs
0.00% <ø> (ø)

datafusion-ext/src/jni_bridge.rs
0.00% <0.00%> (ø)

datafusion-ext/src/lib.rs
0.00% <ø> (ø)

datafusion-ext/src/shuffle_reader_exec.rs
0.00% <0.00%> (ø)

datafusion-ext/src/shuffle_writer_exec.rs
0.00% <ø> (ø)

plan-serde/src/from_proto.rs
0.00% <0.00%> (ø)

src/lib.rs
1.05% <5.00%> (+1.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c09862b...68d25c1. Read the comment docs.


Nav UI route stats/turn instruction misbehavior

Describe the bug
I used openpilot navigation on a drive from Cincinnati to St. Louis. It worked fine in the beginning, but some time into the drive, the nav UI began some manner of freakout. I don't know what triggered it. I was engaged and driving normally, and I don't think I was interacting with the UI when it started.

The above GIF shows it rapidly cycling between different versions of the travel time, estimated time of arrival, distance remaining, and next turn instruction. I think it may have been cycling through future navigation plan segments. The references to I-70 toward St. Louis were along my planned route, but an hour or more in the future.
What hardware does this issue affect?
comma three
Provide a route where the issue occurs
3cfdec54aa035f3f|2021-12-18--05-01-39
openpilot version
master @ e4de82f90636a551a2490ccda1abc30a9b7f30b1
Additional info
The misbehavior, and my attempts to reset and troubleshoot, are in the 05:15-05:30 range of the above route.
I was able to cancel navigation just fine, but on restarting navigation to the same place in St. Louis, the UI misbehaved immediately in the same way. I then tried navigation to two other destinations, one of which was a direct U-turn back home, and the same misbehavior continued. IIRC it was still showing basically the same stats/turn info in rotation, which means it was still stuck from the prior nav destination. I wasn't all that far from home yet, and I-70 wouldn't have been involved in a return route.

This bug turned out to be quite tricky to reproduce. Turns out that for that specific stretch of route the mapbox API doesn't always return the same list of coordinates. I assume due to a bug somewhere on their end or in the Qt parsing code of the polyline. When the response is different one of the coordinates in the path is replaced by the previous one, which in turn breaks the distance_along_geometry function, which is used to transition to the next maneuver and showing the distance.
This function internally uses minimum_distance(a, b, p) which computes the shortest distance from p to a line segment a -> b. If a and b are the same point the result is wrong and always returns 0. I'll add a check for this specific case, which should also fix this bug.

Nice work, that would have taken me an eternity to track down.
Should you ever need a second repro case, 3cfdec54aa035f3f|2022-02-12--23-02-29 somewhere in the segment 28-29-30 area does it again on an entirely different road. It was on my to-do list to write up and add here. The display freakout self-resolved as I came up on the next turn in the planned route, and that behavior aligns well with your explanation and fix.

Let me know if you see it again on latest master! There might be other bugs that would cause the same behavior.


Fix bug for miniupnpc > 1.6

Resolve the following error for user of miniupnpc > 1.6 :
g++ -c -O2  -pthread -Wall -Wextra -Wno-ignored-qualifiers -Wformat -Wformat-security -Wno-unused-parameter -g -DBOOST_SPIRIT_THREADSAFE -DUSE_SECP256K1 -I/root/ION/ion/src -I/root/ION/ion/src/obj -DUSE_UPNP=0 -DENABLE_WALLET -I/root/ION/ion/src/leveldb/include -I/root/ION/ion/src/leveldb/helpers -DHAVE_BUILD_INFO -fno-stack-protector -fstack-protector-all -Wstack-protector -D_FORTIFY_SOURCE=2  -MMD -MF obj/net.d -o obj/net.o net.cpp
net.cpp: In function 'void ThreadMapPort()':
net.cpp:1153:74: error: invalid conversion from 'int*' to 'unsigned char' [-fpermissive]
     devlist = upnpDiscover(2000, multicastif, minissdpdpath, 0, 0, &error);
                                                                          ^
net.cpp:1153:74: error: too few arguments to function 'UPNPDev* upnpDiscover(int, const char*, const char*, int, int, unsigned char, int*)'
In file included from net.cpp:26:0:
/usr/include/miniupnpc/miniupnpc.h:62:1: note: declared here
 upnpDiscover(int delay, const char * multicastif,
 ^
make: *** [obj/net.o] Error 1

LGTM (same as the bitcoin patch)

Again looks good. Same reasoning as @IngCr3at1on

In the previous PR I said it but I forgot to repeat that thing 😂

https://github.com/ionomy/ion/pull/5#issuecomment-220094326

Here's the original patch :
https://github.com/bitcoin/bitcoin/commit/9f3e48e5219a09b5ddfd6883d1f0498910eff4b6.patch

Yep, it's in a bunch of coins. Not nitpicking at all but you probably could have just cherry-picked that commit directly @SherlockStd


Error with make carla

Hi!
This issue is solved, but logging it here in case it is helpful to others.
I am using a Windows machine.
I had an error with the first ("make carla") command of DReyeVR after cloning DReveVR via GitHub desktop. Once I recloned DReyeVR with WSL, as Gustavo advised, this error went away.

@aureliuszi thanks for the note! Yeah, when you git clone something in Windows CMD (ie. batch) or GitHub desktop the default behaviour is to convert the files to the host machine's file ending format (LF for Unix-line, CRLF for MS-DOS). Therefore, since our bash scripts are expected to to be in LF mode, you might run into these \r errors unless you clone from WSL (or another bash terminal).
This is a good note to make, we'll probably work on either batch scripts or a better method for installation on Windows soon.


controlPlaneEndpoint not used by kubevirtcluster controller

What steps did you take and what happened:
I've tried to bootstrap a new cluster with a specific Control Plane endpoint (for testing purpose) and contrary to the "KubevirtCluster" CRD, My static endpoint is not used and ClusterIP Service address appear in controllers logs.
Here is my configuration:
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha1
kind: KubevirtCluster
metadata:
  name: sailor-test
  namespace: sailor-test
spec:
  # Remote Kubevirt Cluster
  infraClusterSecretRef:
    apiVersion: v1
    kind: Secret
    name: kubevirt-kubeconfig
  controlPlaneEndpoint:
    host: <IP_ADDRESS>
    port: 32443

What did you expect to happen:
I expect that the bootstrap controller use my host and port (<IP_ADDRESS>:32443) to reach api-server of the new cluster. But currently controllers used ClusterIP addr.
This line in your code replace controlPlaneEndpoint values with LB external IP :
https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/controllers/kubevirtcluster_controller.go#L164
Environment:

Cluster-api version: v1.3.2
Cluster-api-provider-kubevirt version: v0.1.4
Kubernetes version: (use kubectl version): v1.26.1
KubeVirt version: v0.58.0
OS (e.g. from /etc/os-release): Ubuntu 22.04.1

/kind bug

Thank you Alan for your issue,
We discussed it today during the bi-weekly community meeting and we agree that the KubevirtCluster’s controlPlaneEndpoint should not be overridden if it is set by the user. It looks like this would require making this field a pointer and then checking for nil before setting it in both:

The LoadBalancer case you indicated controllers/kubevirtcluster_controller.go#L164
The CusterIP case right bellow controllers/kubevirtcluster_controller.go#L176

Is this a fix you would be willing to contribute?
Thanks

Thank you Alan for your issue,
We discussed it today during the bi-weekly community meeting and we agree that the KubevirtCluster’s controlPlaneEndpoint should not be overridden if it is set by the user. It looks like this would require making this field a pointer and then checking for nil before setting it in both:
* The LoadBalancer case you indicated [controllers/kubevirtcluster_controller.go#L164](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/controllers/kubevirtcluster_controller.go#L164)

* The CusterIP case right bellow [controllers/kubevirtcluster_controller.go#L176](https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/blob/main/controllers/kubevirtcluster_controller.go#L176)

Is this a fix you would be willing to contribute?
Thanks

Hi,
Thanks for your reply. Yes, i would be very happy to contribute to your project.
There is a particular way to contribute to this repo ? I haven't seen any specific instructions in the main Readme.
Thanks

Thanks Alan, that would be awesome.
The instructions are described in the CONTRIBUTING.md doc and, effectively follow the CNCF guidelines.
I am only a contributor and not a maintainer of the project, but I'm sure @davidvossel or @agradouski , can help if needed.
Thanks


how to add thumb up/down icon on the Chainlit UI to collect users' feedbck?

not sure if Chainlit has this feauter or not. If yes, doesn anyone know how ?

https://docs.chainlit.io/chat-data/feedback

hello @willydouhard  Regarding the data persistence, how to deploy in a coporate GCP enviroment? FYI, We are able to deploy our own postsql database. Any otherthing we need to do?

If you don't want to use the SaaS, you will have to fill the enterprise form to get access to the commercial docker image.


YARN BUILD Error

Hello
I tried to yarn install and build candy-machine-mint but I got this error: https://pastebin.com/XLJEaVxa
So I typed this command and "npm i postcss-safe-parser && yarn add postcss-safe-parser"
And I got this new error: https://pastebin.com/35Q94aYx
Can you help me?
Thanks a lot!

Yeah I'm seeing this as well

I got around this by installing an older version of node (from 17.x down to 16.x via n lts).

For reference the error:
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/tokenize' is not defined by "exports" in /tmp/workspace/node_modules/postcss-safe-parser/node_modules/postcss/package.json
is because<EMAIL_ADDRESS>has postcss-safe-parser pinned to 5.0.2, create-react-app have updated the dependencies, but haven't released.
Details: https://github.com/postcss/postcss-safe-parser/issues/29

Seeing this exact same error!

i'm using 14.x and have no problem

Hey guys!
I'm having this error: Update this package.json to use a subpath pattern like "./*".


TE-5.1: NextHop Index for Static Protocol is used as alphanumeric string instead of integer string

While executing get_rpc_test.go script, it is observed that during the below call of GetOrCreateNextHop, the index is passed as alphanumeric string -
static.GetOrCreateNextHop("AUTO_0").NextHop = telemetry.UnionString(atePort2.IPv4)
Considering it is an index, should it be a numeric (as a string like "0") ?
During execution script is hitting below error -
[InvalidArgument] failed to set .network-instance{.name=="DEFAULT"}.next-hop-groups.group{.name=="oc-static-<IP_ADDRESS>/26"}.nexthop{.index==0}.index - Invalid value "AUTO_0": Must be an integer in range 0..65535

Can you help translate your thought/suggestions to a PR and link here? Thanks. I'll help review or triage the review. Thanks!

Sure. Let me llink a PR for your review here. Thanks!

PR raised for this - https://github.com/openconfig/featureprofiles/pull/692

PR Merged.


Modified the Modal component to allow modalRoot to also be the target…

… of scroll locking styles. I created a alt-modal-root demo page as well to see the changes in action.
Description
[Include a summary of the changes and the related issue.]
[Also include relevant motivation and context.]
How has this been tested?
[How did you test to verify your changes?]
[How can reviewers test these changes efficiently?]
[Check for unexpected visual regressions, see CONTRIBUTING.md for details.]
Documentation changes
[Do the changes include any API documentation changes?]

[ ] Yes, this change contains documentation changes.
[ ] No.

Related Links
[Attach any related links/pull request for this change]

Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness

[ ] Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
[ ] Changes do not include unsupported browser features, see CONTRIBUTING.md.
[ ] Changes were manually tested for accessibility, see accessibility guidelines.

Security

[ ] If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

[ ] Changes are covered with new/existing unit tests?
[ ] Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

As discussed in the linked issue, https://github.com/cloudscape-design/components/issues/423#issuecomment-1303755859, this change is not needed


About Evaluation

Hi, thanks for releasing the code.
During training, SP-GAN uses a different data normalization approach (instance-wise normalizing the points to fit a unit ball) comparing to prior works such as PointFlow (zero-mean per axis and unit-variance globally). How about during the evaluation, how is the data preprocessed?
Would you release the evaluation code, or share how you preprocess/post-process the point cloud before evaluation?
Thank you!

The only processing is on the training point set (normalizing the points to fit a unit ball), which is a common operation in most point cloud-based analysis. No other processing is needed before evaluation.
The evaluation part is the same as PointFlow and latent GAN.
https://github.com/stevenygd/PointFlow/tree/master/metrics

Thank you for responding!
Since the model is trained with normalized data, the generated point cloud is also expected to be within the same normalized scale. If no other processing is needed for evaluation, how can the evaluation metrics (e.g., chamfer distance) be accurate?
https://github.com/stevenygd/PointFlow/blob/master/test.py#L114
As shown above, PointFlow denormalizes the generated shape back to the original scale before evaluation.
Please correct me if there is any misunderstanding. Thank you!

Hello, it's a great job. I also have some issue about metrics. The paper doesn't seem to mention the test set, so after training with the training set, I use the generated results to calculate the data in the training set. I generated 1000 results and performed calculations with 6000 results in the training set. The results of the calculation are as follows:
COV 9.08822661552
MMD 8.834443055093288
JSD 0.023300660444105503
As you can see, mmd is relatively close, and cov is far away. I want to know, where may I have not calculated correctly.

Thank you for responding!
Since the model is trained with normalized data, the generated point cloud is also expected to be within the same normalized scale. If no other processing is needed for evaluation, how can the evaluation metrics (e.g., chamfer distance) be accurate? I feel there are two possible solutions: 1. the testing data is also preprocessed which is normalized to a unit cube 2. de-normalize the generated point cloud back to the original scale.
https://github.com/stevenygd/PointFlow/blob/master/test.py#L114 As shown above, PointFlow denormalizes the generated shape back to the original scale before evaluation.
Please correct me if there is any misunderstanding. Thank you!

Hi, have you got the number reported in the paper?


Check for broken links and add redirects

This task will be performed after the docs-a-thon has finished.
As part of the docs revamp, we may end up with broken links due to deleted/renamed docs. We should do a pass to identify any such links and set up redirects to the updated content in their place.

So far I have the following:

[X] jest/support.html is now jest/help.html, redirect set up in #2700.


Cannot show more than 7 days of data

grafana-2.1.3-1.x86_64
grafana-zabbix 2.1.0-rc1
zabbix-2.4.6.tar.gz of Package installation

Trends has been disable

See #78 also. Which period you store in Zabbix history?

Zabbix History storage period was set in 7 days.
Trend storage period was set in 365 days.
Differs from  zabbix2.4.4, zabbix 2.4.6 seems not to have a corresponding trends Patch.  ZBX-9429

By default Zabbix API can return only history data. You need install trend patch for view more than 7d.


Edit, delete pull request review comments

In this PR will not add the feature (#1677) to Edit and Delete pull request review comments because of #337.
However, I added the code to support both of these actions if viewerCanDelete and viewerCanUpdate are enabled accordingly to the user in GithubClient+PullRequestReviewComments.
Additionally I fixed some SwiftLint warnings.

Closing as its stale


Please place maven artifacts into provided scope

Hi,
Maven requires all maven provided artifacts from their distribution (ie maven itself) to be listed in provided scope since it provides them.  This reduces junk in m2 repository.
My current notes have that this plugin had maven core and maven plugin api both in compile scope.  They need to be placed into provided.  Could you please do so and get a release out?
You may have to adjust the usage, I use Eclipse which helps see the resolution better.  If you need assistance here I can help.
Thanks.

Thank you for noticing this..


Remove isort and pydocstyle setting from pyproject.toml

Overview

Remove isort and pydocstyle setting from pyproject.toml.

Details

Follow up of #346

@pyvista-bot LGTM


Implement a Service Worker integration?

I know this is probably out of the scope of this project, but there's one feature I think would be sweet which is service worker integration. Currently I am using next-pwa, but it doesn't really fulfill my needs. Here's basically the service worker I need (I am considering just coding my own custom worker, but it would be cool to see an integration here):
The worker needs to cache the entire website when I press the download button (kind of like next-offline, but I couldn't get it to work properly). The reason I am doing this is because I am deploying my site as a progressive web application, so that people with limited internet connectivity can get reliable access to the site. The problem is that if I deploy the website in a large number of languages that's going to skyrocket the download size, hence the need to download the entire site, but only in the language selected by the user. This is why I think there's a need for integration between service workers and next translation solutions.
I'm not sure if this would mean implementing an entirely custom service worker for this library, or potentially providing an integration with an existing solution like next-pwa. Either way this is just an idea and you're welcome to decide whether this falls inside of the scope you have for this project or not.

I might consider this suggestion in a few months. But...
this.consider = async function () {
  try {
    let attempts = 0
    while (attempts < TOO_MUCH) {
      const result = await headache() // May take hours or days
      if (result && Math.random() > NEARLY_ONE) {
        return result
      }
      attempts++
    }
  } catch (error) {
    throw new Error(`Impossible: ${error.message}`)
  }
  throw new Error(`F**k`)
}


Automate the testing of the kafka plugin examples

We provide a fair number of example code blocks in the README.md which are not appropriately tested. We should dynamically extract each example from the markdown and insert them into individual e2e runs.

Blocked on https://github.com/SeisoLLC/zeek-kafka/issues/7


Add the Rust validator/runtime to crates.io

Build new crates for each version bump that is promoted to a release

Auto-build in travis
May include "develop" crates

I am able to successfully perform the dry run of the addition of our code to crates.io. However, crates.io needs every crate to be reliant only on other crates. For this reason, our architecture of having the JSON prototypes outside both the validator-rust and runtime-rust is problematic. One option is to move the prototypes directory into validator-rust and modify build.rs to stop referencing relative links outside the validator-rust crate. Another would be to create a third crate solely for the purposes of holding the prototypes, and referencing that crate from within validator-rust.

Another issue is that our package metadata value, readme, points to a relative path outside the crate. It appears that there may be a preference on the part of crate.io to have a one-to-one relationship among crates and git repositories. We may consider creating three repositories, one for runtime-rust, one for validator-rust, and one for the prototypes material. We may also consider simply copying the README.md currently found in the top-level whitenoise-core repository into every cargo crate within that git repository.

Another issue is that the runtime-rust crate references the validator via a relative path outside the crate. This can be fixed once validator-rust is a published crate, and can be directly referenced in the package metadata value, whitenoise-validator, without the relative path outside the runtime-rust crate.

Created branch of code changes which can publish successfully:
https://github.com/opendifferentialprivacy/whitenoise-core/tree/iss149_mphelan
Steps to reproduce:
(get a login key from crate.io)
cargo login
rustup update
cd shitenoise-core/validator-rust
cargo publish --dry-run

I'm really happy to see this, thanks @mikephelan.
There is a group of packages here that sit in one repository:
https://github.com/danburkert/prost
You can see there is a top-level cargo.toml that references other packages in the workspace. From what I understand, this seems to allow them to develop on the packages without adjusting paths or uploading to cargo within the developer cycle. I'm fine with moving prototypes into the validator.

I've examined the multi-layer cargo implementation of prost and agree this is a better way to go. I'll make the modifications to my solution.

The new plan is to programmatically search for the prototypes directory via environmental variable and several other means, within the main function of build.rs in validator-rust, similar to how prost defines the location of protoc.

I've implemented the principles of the prost multi-layer cargo implementation in validator-rust, and made sympathetic changes to runtime-rust. validator-rust now locates the prototypes directory by means of an environmental variable. The target files within the prototype directory are built with the environmental variable as their base.
This solution is able to be published to crates.io successfully (in dry-run mode). We will need to determine a few things in order to merge this successfully to develop and master. We need to verify which type of license we want to use for our code base (crates.io requires that field in the Cargo.toml). We need to create a README.md for validator-rust that we can live with, as I don't think having an exact copy of the whitenoise-core README.md is really what we want to use. We will need to verify that the build is truly yielding the same results it was yielding previously, as config.compile_protos and some other areas are now working rather differently than they were previously. My testing thus far has been limited to building the project in cargo and publishing the project using crate publish (with lenient arguments turned on to dodge errors).

As per request of @raprasad at white noise stand-up on 20200421, here are the remaining tasks for pushing this crates publication issue onward to Valhalla:

Determine a feature set and formalize it into a release branch, then reference that branch in the TOML
Determine a license for the code, then reference that license in the TOML

nice to have:

Update/verify documentation (to) include(s) references to the WN_PROTO_DIR environmental variable so we do not break the build experience
resolution of #26 which would affect changes on this solution

Depends on license #173

additional minor code change was necessary, see pull request #177

With initial release 0.1.0 completed
https://github.com/opendifferentialprivacy/whitenoise-core/commit/b1ec509bfc94dfc319072c8f427dcdd49965a547
we are now able to build our initial crates for WhiteNoise.
One issue is that we write to src/docs/components.rs from build.rs, which is frowned upon by the Cargo folks. They say writing to anyplace but $OUT_DIR can result in bewildering errors. I imagine that writing documentation is unlikely to lead to such errors, but I thought it was worth acknowledging.
The steps for us to publish crates are ready to go.  Will email


Pre-fill custom transactions through URL deplinking

What is this about?
Deep linking or a way to pre-fill the custom transaction form.
Something like: https://gnosis-safe.io/safes/0xmultisig_address_here/#custom-transaction?to=0xto_address&value=1234&data=0xhex_encoded_data
Why are we doing this?
tbd

closing since currently not a prio on our roadmap


How to DoCkeR

Hey, I don't know this DOCKER thing... could you help me, PLOX?

Hey @cky1337 !
Check out the getting started guides: https://docs.docker.com/get-started/
:)

Aw thanks mate... that worked a treat :)


url_launcher canLaunch false for mailto links containing subject on iOS

Steps to Reproduce

create a flutter application with the url_launcher plugin (url_launcher: 5.1.4)
run app on iOS device (simulator supposedly does not work for mailto link handling)
canLaunch returns true for a link without a subject

await<EMAIL_ADDRESS>== true

canLaunch returns false for a link with a subject

await canLaunch('mailto:placeholder@google.com?subject="Test Subject"') == false

From apple's documentation it seems mailto links with a subject field are supported.

Target Platform: ios
Target OS version/browser: 12.4.1
Devices: iPhone SE
Logs

[+2344 ms] flutter: launching mailto:support@storybridgeapp.com?subject="Test Subject"
[        ] flutter: can launch email? false

[+1809 ms] flutter: launching<EMAIL_ADDRESS>[        ] flutter: can launch email? true

# flutter analyze
   info • This class (or a class which this class inherits from) is marked as '@immutable', but one or more of its instance fields are not
          final: Provider.bloc • lib/src/blocs/provider.dart:7:7 • must_be_immutable
   info • The value of the field '_observer' isn't used • lib/src/blocs/services/analytics_service.dart:19:29 • unused_field

2 issues found. (ran in 6.1s)

# flutter doctor -v
[✓] Flutter (Channel stable, v1.9.1+hotfix.4, on Mac OS X 10.14.6 18G95, locale en-US)
    • Flutter version 1.9.1+hotfix.4 at /Users/corey/flutter
    • Framework revision cc949a8e8b (11 days ago), 2019-09-27 15:04:59 -0700
    • Engine revision b863200c37
    • Dart version 2.5.0

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/corey/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/corey/Library/Android/sdk
    • ANDROID_SDK_ROOT = /Users/corey/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.1, Build version 11A1027
    • CocoaPods version 1.7.5

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 40.0.2
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.38.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.5.1

[✓] Connected device (1 available)
    • Omnivor iPhone SE • 4723c97b1224bdc089fdce505d12715f1a3bf37c • ios • iOS 12.4.1

• No issues found!

That's not a valid URL, since it contains a space. Does it work if you properly encode the URL component?

Thank you @stuartmorgan! I fixed the problem following advice from https://github.com/flutter/flutter/issues/10032
Do you think url_launcher should encode the uri automatically for iOS? This would make it a consistent API for both iOS and Android. In my opinion, it is kind of a weird flutter developer experience that android accepts non-encoded spaces and iOS does not.
At the very least, we should add to the the readme on the package page that instructs developers to use Uri.encodeFull() for a consistent experience on both iOS and Android.

It's impossible to correctly encode an arbitrary string correctly without knowing how it was constructed and what the intent is; see my comments on the PR and other issue.
(Not to mention that encoding a URI isn't idempotent, so doing that even as a "best effort" would corrupt URLs that had already been correctly encoded.)

Moving our discussion from #10032 to here to not spam notifications on a dead thread.

it's not clear to me how building it into url_launcher make sense. That would add complexity for those who are fine with the existing APIs, while at the same time making it impossible for people to use it in other contexts

My proposal is not a breaking change. The existing method that takes an arbitrary encoded url string would still exist.

it seems like a good solution would be to make a package that provided special-case construction for whatever specific schemes you are interested in, and then people who don't like the existing Uri APIs could use your package to make URIs instead

Interesting idea, but in my opinion this increases total complexity, while adding a wrapper method in the url_launcher package itself would reduce total complexity (for a beginner flutter developer using the url_launcher API). I think me and you look at complexity in different ways, and that's okay :)
My only goal is to make flutter accessible to all: both seasoned native/systems developers and beginner junior developers starting their app development journey with flutter.
I think we agree the most actionable item at the moment is for me to fix my documentation example PR following your recommendations. I will verify it works in my app with the Uri constructor.

My proposal is not a breaking change.

I never said it was.
I think you are probably reading "complexity" to mean something like the opposite of "simple to use". I'm actually taking about the technical concept of API complexity: an API that builds N ways of doing something into the API surface has higher complexity than an API with one way of doing that thing (which may or may not make it easier to use in isolation). And as a system, APIs that don't allow composition have higher complexity than those that do because of the resulting proliferation of similar clusters of methods. (Consider the case where the are three plugins that take these kinds of URLs, and imagine how your proposal scales. Now repeat with ten or more.)
I would encourage you to consider your proposal in the context of the design of Flutter as a whole. Consider, for instance, the way padding is done via widget composition rather than by having a padding argument in every widget. It's the same principle.

Thank you for the extended explanation. The composition argument makes sense and the comparison to the Padding widget is an illuminating example for me. I agree now that any wrapper methods should be separated into a different package built on top of url_launcher. But, I think better documentation will prevent the need to build any wrappers.
On the documentation front, unfortunately, the Uri constructor isn't seamlessly compatible. I need to remove the "//" that it adds into the String:
final Uri _emailLaunchUri = Uri(
  scheme: 'mailto',
  userInfo: 'smith',
  host: 'example.com',
  queryParameters: {
    'subject': 'Example Subject & Symbols are allowed!'
  }
);
final String _emailLaunchString = _emailLaunchUri.toString();
// toString() == "mailto://smith@example.com?subject=Example+Subject+%26+Symbols+are+allowed%21"
// this url with the // is incompatible with url_launcher
// because the url_launcher includes those slashes in the "To" field for the email
final String _emailLaunchStringCleaned = _emailLaunchString.replaceFirst(RegExp(r'//'), '');
// removing the // makes it work as intended
// ...
canLaunch(_emailLaunchStringCleaned);
launch(_emailLaunchStringCleaned);

I'm not sure I would want to recommend this method in the documentation either. Am I missing something here?
Thanks again for all the help and patience @stuartmorgan, I really appreciate it :)

RFC 3986 gives a mailto example, and indicates that the email address constitutes the path; your constructor should be:
final Uri _emailLaunchUri = Uri(
  scheme: 'mailto',
  path<EMAIL_ADDRESS>  queryParameters: {
    'subject': 'Example Subject & Symbols are allowed!'
  }
);

// this url with the // is incompatible with url_launcher

This has nothing to do with url_launcher, that's just not a valid mailto URL.

I agree now that any wrapper methods should be separated into a different package built on top of url_launcher.

That was not what I was suggesting, actually; there's no reason for such a package to involve url_launcher at all. I was suggesting that you make a package that constructs URLs (either Url or String, as you prefer) using whatever structured input you want. Then the result can be passed to anything that uses a URL, including url_launcher.


Fix Status in Automagic

Added a function called canSetStatus which checks whether a Pokemon can be inflicted with a particular status condition. This should prevent activation of Automagic when a Pokemon cannot be statused by the seconadary effect of a move. @TheImmortal

wait wait dont merge yet

Shouldve figured this out earlier. mb


Relationship Description / Technology Rendering

Hi,
I recently pulled the latest docker image (tag: 3020) and have noticed that rendering of a relationship's description and technology are overlapping when the font size is increased. This wasn't the case previously (although I'm afraid I can't tell you which version introduced the change as I haven't pulled the latest for some time).
Here's an example using fontSize=45 and a width=400: -

In the previous version there was a point where this overlap occurred (due to the description being split over multiple lines) and increasing the width fixed it so that it was workable. In the recent version changing the width seems to have no impact with the overlap and even with a single line of text in the description (as in the example above) this occurs.
Is it a known issue? It's making a lot of my views rather hard to read.

You're welcome - thanks for including an appropriate amount of detail in the issue!


⚠ Bofrost.fr has degraded performance

In 6190e5c, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1784 ms

Resolved: Bofrost.fr performance has improved in bb223dc after 10 minutes.


Annotations should error out on empty Frame

Right now, I get back a new SFrame without an annotation column
In [16]: aa = tc.image_classifier.annotate(sf[0:0])

In [17]: aa
Out[17]:
Columns:
	path	str
	image	Image

Rows: 0

Data:
	[]

@znation Please assign this ticket to me as I would like to try fixing it and contribute .Thanks in advance!

Thanks @dhivyaaxim!


Ported RedundantBaseContructorCall

Green tests
Logic seems a tiny bit better with the argumentList and arguments check

@mkrueger

can be merge @mkrueger

This analyzer grays out the whole constructor althrough removing the base() part only.

Another issue: If the opening brace is on separate line, this code fix destroys formatting.


correct spec section in project overview

Description
Make slight correction to the section about the ocm-spec.

@ccwienk I took over the last sentence from the com-spec introduction https://github.com/open-component-model/ocm-spec/blob/main/README.md#open-component-model-ocm. Please check.


Add a Grafana dashboard showing Bouncer errors

This is to help measure the impact of Platform Health team work to reduce Bouncer errors. I've added a target of 50% of the current 30 day average.
Trello

Any idea why this creates two dashboards, and why the former defaults to an October-November 2019 date range?

https://grafana.production.govuk.digital/dashboard/db/platform-health-q2-20-21-bouncer-errors?orgId=1
https://grafana.production.govuk.digital/dashboard/file/platform_health_Q2_20-21_bouncer_errors.json?orgId=1

The db one can be deleted as it's a temporary one held in the local Grafana database. The file one is the one generated by Puppet part of this PR.

The db one is the one that has a Target (once you change the time range to 90d), but the file one doesn't 🤔
Also how does one delete it? Is that just done in Grafana UI? I assume that involves signing in, but I can't see any credentials in govuk-secrets.


NYX robot issue

INFO:denso_robot:Mounting: A 8^M
2022-06-16 13:24:48,912 denso_robot INFO     Mounting: A 8
ERROR:denso_robot:Exception during mount step: Can't mount 8A: failed to mount: traceback: Traceback (most recent call last):^M
File "/nsls2/software/mx/daq/lsdc_nyx/denso_robot.py", line 33, in mount^M
yield from self.robot.mount(denso_puck_pos, denso_pin_pos)^M
File "/opt/conda_envs/lsdc-server-2022-2.2/lib/python3.9/site-packages/nyxtools/robot.py", line 149, in mount^M
raise RuntimeError(f"Can't mount {sample_str}: failed to mount")^M
RuntimeError: Can't mount 8A: failed to mount^M
^M
2022-06-16 13:25:20,445 denso_robot ERROR    Exception during mount step: Can't mount 8A: failed to mount: traceback: Traceback (most recent call last):
File "/nsls2/software/mx/daq/lsdc_nyx/denso_robot.py", line 33, in mount
yield from self.robot.mount(denso_puck_pos, denso_pin_pos)
File "/opt/conda_envs/lsdc-server-2022-2.2/lib/python3.9/site-packages/nyxtools/robot.py", line 149, in mount
raise RuntimeError(f"Can't mount {sample_str}: failed to mount")
RuntimeError: Can't mount 8A: failed to mount
INFO:bluesky.RE.state:Change state on <bluesky.run_engine.RunEngine object at 0x7fe81bb94b20> from 'running' -> 'idle'^M
2022-06-16 13:25:20,446 bluesky.RE.state INFO     Change state on <bluesky.run_engine.RunEngine object at 0x7fe81bb94b20> from 'running' -> 'idle'
INFO:bluesky:Cleaned up from plan <generator object DensoRobot.mount at 0x7fe810096890>^M
2022-06-16 13:25:20,446 bluesky  INFO     Cleaned up from plan <generator object DensoRobot.mount at 0x7fe810096890>
ERROR:denso_robot:Failure during mount/unmount. Spindle_occupied: expected: 1 actual: 0. Puck num: expected: 0 actual: 0 Sample num: expected 7 actual: 7^M
2022-06-16 13:25:20,453 denso_robot ERROR    Failure during mount/unmount. Spindle_occupied: expected: 1 actual: 0. Puck num: expected: 0 actual: 0 Sample num: expected 7 actual: 7

closing as they no longer use the old denso robot


adding numRows attribute to segment metadata query expected results

fixes the integration test failure caused by https://github.com/druid-io/druid/pull/1995

:+1:

:+1:


Search only works in Safari (iOS/desktop)

I've tried implementing this on a production server, and noticed that the search highlights only work in Safari both on Mac and iPhone. Chrome and Firefox seem to be the odd ones out here.

I'll try to check it out, but in the meantime PRs welcome :)

CloudFlare's rocket loader was breaking the script. For some reason whatever they did to it it caused Chrome and FIrefox to not like it. Thanks again for the prompt response.

Ah, very interesting. Good to know, though!


[Godot 4] Fix tests

GUT has been upgraded to a version that supports Godot 4, however many of the tests in /test are still broken.

Partially fixed by 98b42733fbeb9a27dcf0a69d3e929b9d43618540, but still many tests to fix.


Revert "Add imagestream for driver-toolkit"

Reverts openshift/driver-toolkit#60
/cc @stevekuznetsov
/cc @wking

/lgtm
Unblocks openshift/kubernetes CI which is building machine-os-content but not setting a machine-os version label (yet).


Can pywps be installed with pip?

Description
I am wondering if pywps is supposed to be installable using pip. Currently pip only finds an old version not installable using python 3.4
Environment

operating system:
Ubuntu 14.04
Python version:
Python 3.4.3
PyWPS version:
source/distribution
[ ] git clone
[ ] Debian
[ ] PyPI
[ ] zip/tar.gz
[ ] other (please specify):
pip
web server
[ ] Apache/mod_wsgi
[ ] CGI
[ ] other (please specify):

Steps to Reproduce
$ pip3 install --user pywps==4.0.0
Downloading/unpacking pywps==4.0.0
  Could not find a version that satisfies the requirement pywps==4.0.0 (from versions: 3.2.6)
Cleaning up...
No distributions matching the version for pywps==4.0.0
Storing debug log for failure in /home/abarth/.pip/pip.log

without requiring any version:
 pip3 install --user pywps
Downloading/unpacking pywps
  Downloading pywps-3.2.6.tar.gz (123kB): 123kB downloaded
  Running setup.py (path:/tmp/pip_build_abarth/pywps/setup.py) egg_info for package pywps
    Traceback (most recent call last):
      File "<string>", line 17, in <module>
      File "/tmp/pip_build_abarth/pywps/setup.py", line 32
        print "Compiling template "+template_file+" in "+base
                                  ^
    SyntaxError: Missing parentheses in call to 'print'
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

  File "<string>", line 17, in <module>

  File "/tmp/pip_build_abarth/pywps/setup.py", line 32

    print "Compiling template "+template_file+" in "+base

                              ^

SyntaxError: Missing parentheses in call to 'print'

----------------------------------------
Cleaning up...
Command python setup.py egg_info failed with error code 1 in /tmp/pip_build_abarth/pywps
Storing debug log for failure in /home/abarth/.pip/pip.log

Additional Information

I am getting similar errors, even though the PyPi repository reports 4.0.0 as the latest version.

Thank you, for checking.
Am 18.01.2017 8:23 nachm. schrieb "Luís de Sousa"<EMAIL_ADDRESS>
:

I am getting similar errors, even though the PyPi repository
https://pypi.org/project/pywps/#history reports 4.0.0 as the latest
version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/geopython/pywps/issues/227#issuecomment-273573909,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJbHg4528JfdaY0icvLoEvMjHYfPGEQSks5rTmakgaJpZM4Lm7O8
.

No idea :-( http://stackoverflow.com/questions/41757965/pip-installs-old-version-of-package

I answered your question at https://stackoverflow.com/a/44249121/386327.  The current pypi list contains only .egg files for new releases. These are not supported by pip. So it finds the old .tar.gz file, which is supported. I suggest to also upload .whl files. Please let me know if you need some help with this.

ok guys, that was the trick - use bdist_wheel
sorry it took so long, pywps-4.0.0 should be installable via pip install now (can you prove?)

Tested with an empty 3.5 virtual env. It works fine now, pywps-4.0.0-py3-none-any.whl got installed.


A few broken text for Logic

Description
There's some areas with broken text around the logic functionality - see screenshots.
Steps to reproduce
Area one:

Go to "Add a rule"
Scroll down to the bottom of the Modal
See error

Area two:

Go to the Branching tab
See error in panel

Details

Browser: Chrome
Operating system: Mac
Environment: Staging
Language: English

Expected behaviour
Plain language text
Screenshots or videos
When you open up the modal:

Navigating to a Page in Logic view:

Opening up a new form and navigating to the Logic tab:

A few more instances:


Dynamic route serving as index route when index.svelte is not present

Is your feature request related to a problem? Please describe.
In my project I have configured the routes /complexes/:id and /complexes to render the same component.
However when doing it the traditional way (/complexes/index.svelte & /complexes/[id].svelte), the component gets remounted when navigating from /complexes to /complexes/example which is unfortunately not what I'm looking for (data fetching, transitions etc. all happens again).
To get around this I have [...slug].svelte at the root of my project which conditionally renders on wether the first param is complexes. This works but is not ideal.
Describe the solution you'd like
Ideally when there is no index route present the dynamic route page would be rendered with undefined (or null?) params.
Or maybe an additional naming scheme for routes like index[slug].svelte to indicate this behaviour.
How important is this feature to you?
It's not stopping me from getting further in my project, so I can't honestly say it should take high priority.

Can you have a complexes/$layout.svelte component that contains whatever logic needs to be shared between complexes/index.svelte and complexes/[id].svelte?

Doing it this way introduces some very random behaviour.
My file structure:

index.svelte and [complexId].svelte are both empty
$layout.svelte

Navigating from /complexes/complex1 to /complexes won't trigger load.

Landing on either /complexes or /complexes/complex1 and navigating from there will remount layout but only after the first navigation, from then on it won't. However this only occurs sometimes and stops after restarting the dev server.

Landing on /complexes will only fire the load function once and never again upon navigation.

Landing on /complexes/complex1 and from there navigating to /complexes/complex2 works correctly, but navigating back to /complexes won't trigger the load function, however going back again to /complexes/compex1 does fire load now.

The dev server stops working randomly even after restarting it.

Editing any of the files and wether or not there is a slot component in layout randomizes all the behaviour described above, sometimes it happens, sometimes it won't, in some cases layout was remounting upon every navigation.

update
(2) seems to happen for any dynamic routes and related layouts regardless of anything.
(2) only occurs after editing a file, simply writing a comment and saving will cause this issue and disappears after restarting the dev server.
(1), (3), (4) and (5) are very random issues and I can't always 100% reproduce them but it seems related to having a load function and wether it returns props or not. Sometimes load will never run.

Closing this since this feature won't be needed when these bugs are fixed.


new-log-viewer: Requesting next page switching too frequently can cause the view to jump back to a previous page.

Bug
#54 added a Monaco editor instance and page switching can be achieved via keyboard shortcuts.
It was found that requesting the next page too frequently can cause the view to jump back to a previous page.
yscope-log-viewer version
fefbff744d51a480bd39bb3741d0d942fb916a05
Environment
Windows
Node.js 22 which runs the dev server
Microsoft Edge Version 129.0.2792.12 (Official build) stable app, beta channel (64-bit)
Reproduction steps

Launched dev server and loaded an example file (refer to #46).
Held down Ctrl + ] on the keyboard to request next page switching multiple times in a short period.
Observed pageNum changed from 1 -> 2 -> 3 -> 4 -> 3 -> 2 or a similar pattern where the view jumps back to a previous page although only "next" pages are requested.

@davemarco
Has this been fixed by #76 ?


forwarding-refs: concrete example for function name

Followup on facebook/react#15100
The named render function example in the forwarding refs guide was using a very generic name. Hope this clarifies the use case.
Preview: https://deploy-preview-1832--reactjs.netlify.com/docs/forwarding-refs.html#displaying-a-custom-name-in-devtools

Hello @eps1lon, thank you for contributing!
As the parts modified in this PR as no longer present in the react.dev docs, let me close this PR as outdated.


Model - CVT - remove SKOS requirement

SKOS relations of the URI to the current term aren't helping, and until someone can demonstrate their usefulness in inferrence we should hard-remove them.

Blocks #1561


Feature: export data proto buf format

Hi! First, thanks for this amazing tool. I love it.
I'm trying to collect data from multiple instances, on a rolling basis. And then I need to post-process the data so that I can retrieve meaningful information out of it.
Looking at the way Google's pprof[https://github.com/google/pprof] work, I was wondering if would be possible to add the protobuf capability (or something alike). Why so? Because it would make serialization and deserialization straightforward and avoid having to parse text output.

With collapsed stack format you don't need to parse output, you can just join multiple text files.

Please take a look at the following comments:

https://github.com/jvm-profiling-tools/async-profiler/issues/297#issuecomment-582201329
https://github.com/jvm-profiling-tools/async-profiler/issues/248#issuecomment-633311384

Hopefully they explain my position about new formats.
In short, async-profiler already supports two formats that should cover all use cases:

collapsed - the simplest text format that requires almost no parsing;
jfr - full-fledged binary format; Java standard; supported internally by JDK as well as by many external tools and libraries.

Thanks guys!


Nm 650 most viewed products

ping @vincentbz can you check this pull request asap ?
Fixes: http://forge.prestashop.com/browse/NM-650

Oldie but goodie! 😁

:sunglasses:

964 days after, merry Christmas @mickaelandrieu :) 🎅


Nested concat taking days to parse.

Actual Behavior
JSQLparser is unable to parse sql with more than 20 nested concats.
Expected Behavior
Should be able to parse the nested sql statements.
Steps to Reproduce the Problem
Input sql
select concat(concat(concat(concat(concat(concat(concat(concat(concat(concat(concat(concat(concat(concat(concat(concat(concat(concat(concat(concat('1','2'),'3'),'4'),'5'),'6'),'7'),'8'),'9'),'10'),'11'),'12'),'13'),'14'),'15'),'16'),'17'),'18'),'19'),'20'),'21'),col1 from tbl t1
The following code block takes a lot of time to process.

   Statement statement = CCJSqlParserUtil.parse(content);

Specifications

Version: 1.4
Platform: MAC with java 1.8
Subsystem: UNIX

That is an official problem, that JSqlParser has a hard time parsing those nested bracket constructs.

Can't it be optimised ?
Or is there a possibility to restructure the sql at runtime to select concat('1','2','3','4','5','6','7','8','9','10','11','12','13','14,'15','16','17','18','19','20','21'),col1 from tbl t1 ?

Restructuring the sql would surely be a solution, but I consider this simply a hack. As I told you, it is already a known problem. The right solution is to adapt JSqlParser to parse it fast :). I can tell you, that JSqlParser is somehow stuck within recursive lookahead calls.
There is another project within JSqlParser organisation that aims to provide some performance test tools. Nevertheless it is very technical.
Do you want to investigate more? I could give you more informations or you keep on waiting a little bit more, because I am already on it without knowning, how long it will take?

I was using jsqlparser 1.4  which couldn't parse a single query in an hour but now when i changed back to version 1.2, I could find that the query was successfully parsed in 20 -30 seconds.
Could you please have a look into it ?

Could you check it. I just deployed a new 2.1-SNAPSHOT. Your statement is parsed within 3 secs on my computer. This seems to be a huge achievement to days. ;)


Compute gossip port as offset from RPC port

The gossip protocol only includes the RPC port and does not explicitly
say what port is used for gossip, so other parts of our system assumes
it is the RPC port +1. Thus, we change the actondb default to also be
based on RPC port +1.
The long term solution is to make the gossip port configurable and to
propagate that information in the gossip protocol. Meanwhile, since we
do not support any other port than +1, we make it impossible to
configure but leave most of the argument parsing code in so that it's
easy to change one day.

@aagapi FYI I improved it a bit further by making the default value an offset from the RPC port rather than a fixed default, so now if you do actondb -p 1234 we get a gossip port of 1235. It is still possible to override but you get a stern warning...


#388 memcpy_s removal

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Changes the memcpy_s instances to use memcpy directly but adds asserts for debug time issues and if applicable nullptr checks on the destination/source
Is there an open issue that this resolves? If so, please link it here.
What is the current behavior? (You can also link to an open issue here)
N/A
What is the new behavior (if this is a feature change)?
N/A
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking change for the end user
Other information:
N/A

Changes the memcpy_s instances to use memcpy directly but adds asserts for debug time issues and if applicable nullptr checks on the destination/source

Why? What's the reasoning for not using an official C/C++ API in favor of rolling our own equivalent?

Why? What's the reasoning for not using an official C/C++ API in favor of rolling our own equivalent?

Because we can't actually use it in all locations and the errno_t stuff is additional faff I can't be arsed with, to put it flatly. It's easier for us to just validate the memcpy call is correct and be done. Only windows supports memcpy_s and I'd rather not maintain two branches of the code in this case.

On the case of reusing a selfmade method for the assertions: Technically I could add a method that we can reuse like memcpy_validation but since we don't use memcpy that often I figured asserting it at the start of a method where we expect certain things to be passed in is cleaner. Ofc if we want a single method that does the assertion as well as the memcpy I'm not opposed to that but in this case I feel this is safer.

Ofc if we want a single method that does the assertion as well as the memcpy I'm not opposed to that but in this case I feel this is safer.

Rolling your own validation logic, especially logic that has to be duplicated at each callsite, is almost never safer ;)
Centralizing the checks to one place such that things can be correctly accounted for and will always be accounted for is the safest thing you can do.
In this case, if for some reason memcpy_s isn't available (such as GCC/Clang decided to not implement Annex K) then it'd be better to simply define a memcpy_s shim with the right surface area and to place the validation logic in that.
If for some reason you don't want to handle errno_t at each call site, then likewise define some C++ MemoryCopy utility that wraps memcpy_s, checks errno_t, and throws a proper exception on failure.

So why not define our own MemoryCopy that wraps the right APIs where available and does the checks otherwise.
This centralizes everything, allows easy modification in the future if we need (say we want to disable the checks in release builds), allows ensuring consistent behavior (such as throwing C++ exceptions for failures or asserting correct results), etc.

That is a possible solution. The original GH issue was just the minimally required work and I kind of wrote it out of frustration mid-Vulkan pipeline fixing ages ago. That's probably why. :D

Ah, I missed that there was an issue at all.
Would be helpful to have it show as a regular issue https://github.com/novelrt/NovelRT/issues/388 and not as link it here
I think it would be much better/safer/extensible to make our own wrapper method in such cases. Having manually placed validation at each memcpy callsite is overall error prone and easy to forget to do. Wrapper ensures it always happens, can do the relevant kind of checks, expose the right kind of errors, and can easily change behavior for all callsites based on perf, security, or other needs.

Frankly, we should update memcpy calls to std::copy over a std::span/gsl::span. In addition, the APIs that return raw pointers should be updated to also use a span type - the C API would translate this to something along the lines of void* fn(size_t* size) and write the span's size to the size parameter if it's non-null, as is typical for C APIs.


In fmt[], % becomes two %%

For example in cpu load:
        .add(Delayed::new(
             Duration::from_secs(1),
             || System::new().cpu_load_aggregate().unwrap(),
             move |res| match res {
                 Ok(cpu) => bfmt![bg[sep.bg] fmt["  {:.1}% ", (1.0 - cpu.idle) * 100.0]],

                 Err(_) => bfmt![bg[sep.bg] text["error"]],
             }))

It shows two % signs.

fmt literally just calls the format! macro. Which doesn't seem to use % in any way… maybe this happens further along the way — in the lemonbar stuff?

It's probably because of this: https://github.com/myfreeweb/unixbar/blob/master/src/format/lemonbar.rs#L13
Maybe it's from an older version of lemonbar - nowadays I think you just write '%' for '%'.

Oh.
/// Turn off escaping for e.g. lemonbar-xft
pub fn new_noescape() -> LemonbarFormatter


If previous sync failed, sync again without checking last updated time

Nope. If it failed it's probably a problem with the data or something crashing in our side that won't be fixed by retrying probably. Closing.


VS Code test  failed for todo-java-postgresql-terraform

Describe the issue:
Hit F1 Run Task Start API and Web, Debug API Failed.
The error message as follows:

Repro steps:

Run azd auth login
Run azd init -t todo-java-postgresql-terraform -b staging
Run azd up
Hit F1 Run Task start API and Web

Environment:
OS: Windows desktop, MacOS desktop, Linux desktop, DevContainer in VS Code.
Template: todo-java-postgresql-terraform
Branch: staging
Azd version: 0.9.0-beta.2-daily.2786873 (commit de89effa931a89e8125e520e5bc3ff473f014fb5)
Expected behavior:
Run task start API and Web success.
@rajeshkamal5050 for notification.

@blow-hey does this still repro with the latest bits and templates?
@yiliuTo can you triage this with @blow-hey

@rajeshkamal5050  sure

@rajeshkamal5050 This issue can be reproduced in the following cases：
Environment:

OS: Windows desktop, MacOS desktop, Linux desktop and Devcontainer in VS Code.
Template: todo-java-postgresql-terraform
Branch: staging
Azd version: azd version 1.1.0-beta.1-daily.2845223 (commit https://github.com/Azure/azure-dev/commit/9e11674b30a1b0c456fbd8a042d6f5af77ec6188)

Hi @v-jiaodi and @rajeshkamal5050 , I am using azd version 1.0.2-daily.2861384 (commit bb510e6f0bd9083210ac640f43b1bcff622d07b4) retrying to reproduce this error, however, before running to the provision stage, I encountered error in the provision stage:

Could you check which hosting do you use? App service or Spring Apps?

Hi @v-jiaodi and @rajeshkamal5050 , I am using azd version 1.0.2-daily.2861384 (commit bb510e6) retrying to reproduce this error, however, before running to the deploy stage, I encountered error in the provision stage:
Could you check which hosting do you use? App service or Spring Apps?

@yiliuTo , make sure that 'az cli' is set to to use the account/subscription that you are using with azd.
Run 'az account show' and see if the subscription you see there is the one used with azd.
If not the same, run 'az account set --subscription xxxxx' .
Then continue the test.

@vhvb1989 thanks your solution works. And after reproducing this issue, I found the cause should be that this application lacks some environment variables for the application configuration:
https://github.com/Azure-Samples/todo-java-postgresql-terraform/blob/3ccadf24336d8a207a5eacf95c8513667559b447/src/api/src/main/resources/application.properties#L8-L9
When running in azure app services, those env vars can be configured through terraform, however, when debugging with vscode, those vars are not configured:
https://github.com/Azure-Samples/todo-java-postgresql-terraform/blob/3ccadf24336d8a207a5eacf95c8513667559b447/.vscode/tasks.json#L16-L18.
And since those vars involve the resource information generated after azd provision, thus I am wondering are there any solutions to configure vscode environment vars with AZD environment vars? @vhvb1989 do you have any suggestions on this?

@yiliuTo , the tasks.json uses the dotenv type to pull all variables from azd-env when launching services.
What you are missing is to make terraform to output the env-vars you need here: https://github.com/Azure-Samples/todo-java-postgresql-terraform/blob/3ccadf24336d8a207a5eacf95c8513667559b447/infra/output.tf#L1
There is already a value: AZURE_POSTGRESQL_ENDPOINT as output. After azd provision, this env var is set into azd-environment and it set when launching the api-service locally.  However, the api is looking for AZURE_POSTGRESQL_URL . So, you should consider using AZURE_POSTGRESQL_ENDPOINT for the api-config (unless the endpoint is different than the URL).
Since you are using Passwordless configuration (assigning access-roles to the webapp to access https://github.com/Azure-Samples/todo-java-postgresql-terraform/blob/3ccadf24336d8a207a5eacf95c8513667559b447/infra/main.tf#L123) , I think you will also need to create passwordless configuration for the current local-user (maybe that's already happening... )
So, try setting AZURE_POSTGRESQL_USERNAME and AZURE_POSTGRESQL_URL as output variables here: https://github.com/Azure-Samples/todo-java-postgresql-terraform/blob/3ccadf24336d8a207a5eacf95c8513667559b447/infra/output.tf#L1.  That should do the trick.
Note: If the Username and/or url are somehow sensitive info, consider creating a Key Vault and setting those values there. Then make the api-code to connect to KeyVault and pull the values from there.  This is what we do for the java template we have on Azure-Samples here: https://github.com/Azure-Samples/todo-java-mongo/blob/main/src/api/src/main/resources/application.properties#L8   .  The Spring app uses Key Vault as application-config, making all secrets available for the app as env-vars

@rajeshkamal5050 This issue can be reproduced in the following cases：
Environment:

OS: Windows desktop, MacOS desktop, Linux desktop and Devcontainer in VS Code.
Template: todo-java-postgresql-terraform
Branch: staging
Azd version: azd version 1.0.3-beta.1-daily.2905893 (commit https://github.com/Azure/azure-dev/commit/a7126c9e3b8573d3874c47adf0caad927a551d76)

I think you will also need to create passwordless configuration for the current local-user (maybe that's already happening..

hi @vhvb1989. Now the passwordless configurations is setting for Azure Service(via Managed Identity), not for the current local-user.
Adding passwordless configurations for local-user could resolve the issue. As we know, the template could be used in different scenarios:

In the local env, local-user means the current login user
In Github action, local-user means the AAD service principal

The logic in terraform local-exec should cover both scenarios (Maybe there are some other scenarios). It's a little complex for developers and also not easy to implement.
Thus, to make the template be simple, I will remove passwordless feature and use KeyVault to replace it.

Removing passwordless may be a better option for now. Passwordless postgresql implementation requires additional developer education and app coding to request the scoped token and pass it along as DBPASSWORD when establishing a database connection.
The only downside is non-trivial zero-downtime production secret rotations, but that hasn't been a primary focus of our current templates.


Mapping Conflict

Some values are defined as several types (string, int, float).
Check correct type and repair index.

Mapping fixed.


Reset password for a User via ForceClient

I'm trying to use the following method for resetting a password for a User:
https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/dome_sobject_user_password.htm
I'm failing to see how can I call that API route and get the new password response with this toolkit, as JsonHttpClient's DeleteAsync methods return bool, overriding the BaseClient's DeleteAsync which returns string.
I have thought of several alternatives, but I'm not sure which one, if any, would be accepted as a pull request. Please let me know if there's a way I missed to call and get the response for resetting a password, or which approach would be considered okay.

Hi @koide, any progress on this issue? I'm trying to set / reset password but cannot find a way to do this

I did it outside the library with direct requests to the API, @leobel, see https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/dome_sobject_user_password.htm
I reused the Authentication client from the library to get the AccessToken, ApiVersion and InstanceUrl. Then I just did a DELETE request to $"{_auth.InstanceUrl}/services/data/{_auth.ApiVersion}/sobjects/User/{id}/password" with a regular HTTP library, adding the Authorization header with the Token. {id} is the Salesforce Id of the user you want to reset the password to.


Refactoring to simplify fetching y offset

Even if row_number is 0 or 1, sum() will do the right thing.

That's, cool. I didn't know you could do that. Thanks.


Occlusion query fixes for M1

Fixes #1385.
Per discussion in issue, this PR allows a single Metal visibility buffer to be used for all render encoders in a single MTLCommandBuffer.

The first commit in this PR fixes the issue across multiple Metal render encoders in a single Vulkan command buffer.
The second commit here extends this to an entire Vulkan submit (multiple Vulkan command buffers, one Metal command buffer).
Third commit cleans up some syntax around tracking query locations in the visibility buffer to make it clearer how the mapping works.

I'm trying to understand what happens when we overflow the buffer. Suppose we only have one slot left in the visibility buffer and we begin a render pass, start a query, draw, end query and start another one, draw again, end, get the results. I'm likely missing something, but:

Shouldn't we use a new MTLRenderPipelineState after we've ran out of space and made a new buffer? The buffer is baked into it.
We only get the newest buffer in MVKOcclusionQueryCommandEncoderState::endMetalRenderPass, so shouldn't we also force an accumulation step when we change buffers? Or, better, remember which one was used for each query?
If the answer to above is that in the end we only use the new buffer for the whole Metal render pass during which the old buffer overflowed, we still seem to have old (high) offsets in the query array, which might get accidentally reused later?

I'm guessing that the Metal render pass is ended somehow in this scenario, or things happen in some different order than I think they do.

Shouldn't we use a new MTLRenderPipelineState after we've ran out of space and made a new buffer? The buffer is baked into it.

Not MTLRenderPipelineState. The visibility buffer is baked into MTLRenderCommandEncoder, which is created on boundaries of Vulkan subpasses (BeginRenderpass or NewSubpass).
The incrementMTLVisibilityResultOffset that triggers the need for a new buffer occurs at the end of an occlusion query. The creation of that new buffer occurs at the beginning of a render pass.
So the situation you describe would be the end of an occlusion query but before the next renderpass. Subsequent queries in that renderpass would overwrite the beginning of the visibility buffer (which may or may not cause a validation error depending on the platform). Subsequent render passes would use the new visibility buffer.

We only get the newest buffer in MVKOcclusionQueryCommandEncoderState::endMetalRenderPass, so shouldn't we also force an accumulation step when we change buffers? Or, better, remember which one was used for each query?

Yes. Perhaps we should track the visibility buffer in the OcclusionQueryLocation. But I think the same situation I described above would occur. The new visibility buffer would not make it into the current renderpass encoder, and queries used in that renderpass would overwrite the beginning of the visibility buffer.
Or...in both cases, maybe we could detect that the buffer has changed and avoid those overwrites in the current renderpass.
Another simpler and predictable option could be to just use one visibility buffer and permit only up to the maximun numbers of queries per MTLCommandBuffer, and just trigger a Vulkan error when it is exceeded.

Maybe we could simply restart the encoder (MVKCommandEncoder::beginMetalRenderPass?) when we overflow the buffer? We'd accumulate all queries, resume any active ones with the offsets they had assigned and move on - we shouldn't ever reach these old offsets and still need them, as that would mean the render pass limit of queries was exceeded.

In the end I decided to keep this simple until we have a definite need to do further gymnastic workarounds.
I have reverted to just supporting one Metal visibility buffer per MTLCommandBuffer, outputting an error log and safely halting visibility tracking within the MTLCommandBuffer if the visibility buffer becomes exhausted.

Maybe we could simply restart the encoder

Hmmm...this sounded fraught with side effects, so I didn't dig into it. It remains a possibility if we identify that we need more flexibility with tracking larger numbers of occlusion queries in a single Vulkan submit.

we could track the need to allocate a new visibility buffer for a render pass before we start encoding it

So we have #1256 proposing a finer level of tracking the need for a visibility buffer. But again, it appears to be a fairly complex solution to an ill-defined need. Something for the future if needed.


Use Math.round to calculate whole-step points

Math.ceil truncates negative numbers towards zero, e.g. 3.9 gets truncated to 3 instead of rounded to 4.

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Index Sorting: Case Insensitive

(problem encountered using Asciidoctor PDF, see #928).
In the Index of a PDF document converted via Asciidoctor PDF, the entries for each letter are sorted Asciibetically, instead of alhpabetically.
Entries in uppercase are listed before entries in lowercase, which leads to differently cased same-entries to be separated by other entries which would normally come after them:
AAA
BBB
CCC
aaa

... where one would expect "aaa" to directly follow "AAA".
This makes looking up entries in the Index troublesome, as the reader is forced to jump up and down the entries list to check differently cased entries are available for a given term — needless to say, it could lead to missing out many entries that are actually indexed.

Oops, looks like we both filed the same issue. Duplicate of #1405.


doc/feature: add/remove node to cluster

Thank you for this repo! I plan to use this for an "app cluster" in which one service will be running continuously, and another task will run periodically (once daily). I don't want to have to provision a backing node to support the periodic task; rather, I'd like to have a 2nd scaling group that I can scale up when I need it and then scale down. (2nd ASG because different type of node needed. Automatic autoscaling via cluster autoscaler would be even better, but not sure if possible easily outside of EKS.)
Perhaps a "recipe" for this could be added to the doc? Can I just copy the node pool and node code, and use it?
hmm... it seems the cluster_token is not part of the outputs. Maybe as well as a recipe, a few changes could be made to enable this?
Alternately, you could support multiple autoscaling groups directly.

Hi @shaunc, I would need some time to recall it, haven't been working on AWS for a year now.

Can I just copy the node pool and node code, and use it?

Sure, I don't see why not.

Alternately, you could support multiple autoscaling groups directly.

The original intention of this project is for independent app clusters, and I am hesitant to complicate it further. As it is, it can be easily forked and customized to suit various needs.

Ok -- yes; indeed its simplicity was what attracted me. Ok -- closing. But if I have a simple version of what I want perhaps I'll submit a PR for your consideration. (?)