js801: test gogs client [1.5d]

/opt/code/github/jumpscale/jumpscale_core8/lib/JumpScale/clients/gogs/GogsClient.py
implement
    def test(self):
        # compile gogs (using cuisine golang, ...)
        # start gogs using process manager j.core.... in subprocess
        # create orgs
        # create users
        # list orgs/users
        # create issues
        # list issues
        # delete issues
        # delete users
        # delete orgs

is in the client

i think most of this already works, lets just test

just needs to be closed & verified, is needed to automate our process which is urgent

Client is working against latest gogs
https://github.com/Jumpscale/jumpscale_core8/commit/35c3fb67b04135522a85936fb39b309efb94a3e9https://github.com/Jumpscale/jumpscale_core8/commit/35c3fb67b04135522a85936fb39b309efb94a3e9
CuisineGogs is responsible for building/installing gogs and applying itsyouonline integration (currently there's an issue with tmux processmanager but the command it runs works fine)
https://github.com/Jumpscale/jumpscale_core8/commit/0a992c9ef6dff03b05aa3e266836c3ca72e1ce48


Unify IF and CASE expressions

What is the problem the feature request solves?
DataFusion provides CaseExpr for CASE WHEN and Comet has a custom IfExpr for IF(expr, true_expr, false_expr).
IF(a, b, c) is semantically equivalent to CASE WHEN a THEN b ELSE c END, so why do we have two different implementations? We should at least have common code that is used from both, and we should upstream the IF support into DataFusion.
Describe the potential solution
No response
Additional context
No response

Based on the benchmark results in https://github.com/apache/datafusion-comet/pull/681 I don't think this is a high priority for now, but I plan on working on it at some point.


Add more Font Awesome detection

Adding detection for the new kit.fontawesome link and script.
Removing version detection for the script cause of false positives.

fixes #3335.

Thanks!


raise AuthenticationRequiredError on Net::HTTPForbidden

Backport of https://github.com/bundler/bundler/pull/3260 to 1-7-stable branch

Sorry, but I'm reverting this from 1-7-stable for now... caused too many problems for other users.

This is fixed and re-instated with the merge of #3342.


methods general issue

General issue for merging new methods related work.
See https://github.com/tgbugs/pyontutils/tree/master/development/methods.
Existing issues.
https://github.com/SciCrunch/NIF-Ontology/issues/127
https://github.com/SciCrunch/NIF-Ontology/issues/100
https://github.com/SciCrunch/NIF-Ontology/issues/87
https://github.com/SciCrunch/NIF-Ontology/issues/64
https://github.com/SciCrunch/NIF-Ontology/issues/1

Sampling strategies at the cellular and organism phenotypic/population levels.


Transform f1_accumdepr_prvsn dbf + xbrl

PR Description

Mapped DBF rows to XBRL factoids for the f1_accumdepr_prvsn table.

PR Checklist
Before requesting a review of your pull request, please make sure you've done the following:

[x] Merge the most recent version of dev
[x] Do your own review of the PR. Highlight areas where reviewers should focus their attention or you need help.
[x] Verify that all of the CI checks on your PR are passing.
[x] Write good docstrings for any new modules, classes, functions.
[ ] Ensure that new functions / methods / classes have at least basic unit tests.
[x] Update the release notes.
[x] (N/A) Make sure new analyses include defensive sanity checks that will catch unexpected data issues.
[x] (N/A) Ensure that the full data validation tests pass locally.

@cmgosnell I think I've addressed all the issues that we discussed. Please take another look! Hopefully the CI passes.


Add tests

For now, the documentation itself serves as tests for the current features, but this doesn't test (for example) the use of symlinked directories. We should have a proper test suite for the extension.

I think there are two options for this:

Unit test: mock everything (Sphinx app and config objects, etc.), and test individual classes and functions
Integration test: Use a full build environment with some test source files, and compare output

Option 1 would probably be more straightforward to write (without much knowledge of Sphinx internals), but option 2 would be more thorough. I'm not sure how best to set up a build environment for testing, but I'm curious, so I'm willing to look into it.
Sphinx has a sphinx.testing subpackage that doesn't appear to be documented, but looks potentially useful: https://github.com/sphinx-doc/sphinx/tree/master/sphinx/testing

sphinx.testing looks like the best option for most of the things we would want to test. If that sounds good to you, I'll plan on getting that started with a few basic tests.

I'd be happy to see that, thanks!


added some hints if you are using google colab

I think i changed the wording @markusbkoch This should probably be closed tho since there was a new rewrite?

@GriffGreen
Are you sure?

@GriffGreen
Are you sure?

Yes, I think Griff is right - we should close this PR and deal with all things related to Google Colab in the demos repo (eg https://github.com/cadCAD-org/demos/issues/3).
Once we merge https://github.com/cadCAD-org/demos/pull/2 (I'm working on it) we should be able to reopen this same PR there.

@GriffGreen
Thanks for your contribution!
tutorials are now in another repo.
please re-submit your PR here: https://github.com/cadCAD-org/demos


interaction between "provably inferior abstractions" and --num-inventions > 1

Technically if you were looking for >1  invention candidates (which we havent yet in any situation) provably inferior abstractions would throw out some things that are actually reasonable.  However ofc theyd be  just slightly lamer versions of ones you  already have?

Yeah itd be the top 100 modulo these subsumptions

This actually seems pretty desirable in many cases! But important to note still. In the paper we dont talk about num_inventions though so it's not relevant to that. Worth just noting in the commandline arg description

added to arg description


short article about smart pointers

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

Someone with more C++ experience will have to review this.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


Extract chat log

Hi
Is it possible to extract chat log from a demo with this application?
If not, would you consider adding such a feature?

Hi, is the option to extract chat really added, if so, where can I do that? Can't find it for cs2 demos.

see https://github.com/akiver/cs-demo-manager/discussions/731


Issues loading/installing Python extension

Type: Bug
Extension version: 2022.20.2
VS Code version: Code 1.75.0 (Universal) (e2816fe719a4026ffa1ee0189dc89bdfdbafb164, 2023-02-01T15:24:42.903Z)
OS version: Darwin x64 22.3.0
Sandboxed: No
Initially experienced an infinite Python extension loading message. Uninstalled and when trying to reinstall to the latest version/pre-release version got this stacktrace:
2023-02-08 08:09:30.968 [error] XHR failed,UnhandledException: Error: XHR failed,UnhandledException
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:89578
    at Array.reduce (<anonymous>)
    at E (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:89564)
    at ne.D (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:80916)
    at async ne.z (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:88:78417)
    at async ne.install (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:90:158273)

Also cannot install the extension manually from vsix package (with the same trace).
Should also mention I can successfully install other extensions (XHR made me think proxy issue but not sure why it would only affect this extension)

It was a proxy issue. Closing.


Use denque-based Queue

Update Queue to be based on denque rather than deque.  Apparently, denque is an updated approach that performs better on newer engines.
Here's a representative result:
❯ babel-node --presets env ./zip.js
zip 2 x 100000 integers
-------------------------------------------------------
most                118.98 op/s ±  0.87%   (71 samples)

~/Projects/cujojs/@most/core/packages/core/test/perf use-denque-zip* 3m 25s
❯ babel-node --presets env ./zip.js
zip 2 x 100000 integers
-------------------------------------------------------
most                135.29 op/s ±  0.53%   (72 samples)

I've run it numerous times, and the difference is consistently around 15%.  There's a small difference in library size, but unless you're actually using zip (or zipArray), Queue will be tree-shaken, so you won't notice.
I also updated the perf tests to get the all running again.

All the perf tests work again 😃

@Frikki I extracted the two constants (2 and 10000) and wrote some comments about them.  I don't know why those particular values were chosen, so I just tried to document as much as I could based on how they were being used.  I cleaned up _copyArray as well.


Maximum water Container

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
C code to determine the maximum water Container.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(#900 )

Kindly review @HarshCasper @SKAUL05 @iamrajiv


Add retry logic for VS19 extensions installation

The last 2 days VS extension marketplace returns Error 429, which breaks image building.
==> vhd: Provisioning with powershell script: C:\agent\_work\2\s\images\win/scripts/Installers/Windows2019/Install-AnalysisExtenstion.ps1
    vhd: Downloading Microsoft.DataTools.AnalysisServices.vsix extension
    vhd: Installing Microsoft.DataTools.AnalysisServices.vsix extension
    vhd: Exception calling "DownloadFile" with "2" argument(s): "The remote server returned an error: (429)."

This PR adds retry logic for extension download process.
Changes:

Add Install-VsixExtension function
Change Install-Wix and Install-AnalysisExtenstion scripts to use the helper function

Maybe it makes sense to combine Install-AnalysisExtenstion.ps1 and Install-Wix.ps1 into one script something like - Install-VSExtension.ps1

Maybe it makes sense to combine Install-AnalysisExtenstion.ps1 and Install-Wix.ps1 into one script something like - Install-VSExtension.ps1

I'd prefer to leave Wix-extension in the same script where wixtoolset is installing.


[FLINK-10921] [kinesis] Shard watermark synchronization in Kinesis consumer

What is the purpose of the change

This pull request makes adds support for source synchronization to the Kinesis consumer. Source synchronization aligns shard consumption based on the per-shard watermark.

Brief change log

Adds global watermark aggregation to track the current low watermark across subtasks
Adds record emitter to prioritize per-shard queues and align the shard consumers through back pressure
Above components are designed to be reusable for the upcoming support in the Kafka consumer.
Integration into KinesisDataFetcher

Verifying this change
This change added tests and can be verified as follows:

This is a back port from Lyft internal codebase where it has been tested extensively and at scale.
PR includes test for consumer and basic tests for emitter and watermark tracker.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (yes)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (user documentation will be added separately)

@flinkbot approve all


Add documentation for dataframe metadata

Add a prose section to the documentation on dataframe metadata. Related to #1512.

Addressed all comments.

Generally this looks great to me


Oop implementation

Closes #1

This feature should be tested against the lexical scoping to ensure that it works

This feature should be tested against the lexical scoping to ensure that it works

As the lexical scoping will be on hold for now, this feature just needs further testing and then can be integrated.


About the dmg

I want create a dmg for drag app to the Applications dir,how can I do for this?
Thanks very much.

Have you read the documentation on the wiki:
https://github.com/crotwell/gradle-macappbundle/wiki/Intro
Do you have a problem setting up the configuration or running gradle createDmg?

I want like this...

Use a background image with your arrow like:
backgroundImage = "doc/macbackground.png"
the Applications folder will be liked as well.
Also you can use appIconX, appIconY, appFolderX, and appFolderY to position them. You may also need to manually set backgroundImageWidth and backgroundImageHeight if the window is not sized correctly.
I probably should separate those two steps so a background image can be used without also linking Applications, hopefully in the next version.

Thanks!
I will try it.

How to make the window height and width is current,I don't want the scrollbar.
Thanks very very much...

The window should be sized to match the image, so try making the image larger.
Also, you may need to manually set backgroundImageWidth and backgroundImageHeight if the window is not sized correctly.

OK,it works well.Thanks very.


onedrivegui: add wayland support

Description of changes
Use makeQtWrapper and add qtwayland dependency to allow onedrivegui to run on native wayland.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Adding qt6.qtwayland to environment.systemPackages also solves the issue, while onedrivegui is not the only pyside6 application without qt6.qtwayland wrapped.


[ANTLR] subroutineCall should take a indexIdentifierList instead of expressionList

Currently, subroutineCall takes a expressionList .
subroutineCall
    : Identifier ( LPAREN expressionList? RPAREN )? expressionList

I guess that this expressionList should be replaced with indexIdentifierList as quantumGateCall does.
quantumGateCall
    : quantumGateModifier* quantumGateName ( LPAREN expressionList? RPAREN )? indexIdentifierList
    ;

This is correct, thanks @hhorii. Please add a PR with the fix and a test and we can get it merged it.

I just had an issue related to this, which I state here in case it helps others.
If I try to parse a subroutine which contains
return a - b;
it gets parsed as subroutineCall (a is the subroutine Identifier and -b is the expression passed as an argument).
With the fix you suggested here it gets parsed correctly.


feat(RHTAPREL-435): refactor slack notification

revert to using webhook integration.
using the postMessage API in slack requires a bot scope that sometimes can be hard to obtain by IT security teams.
secret name and key name within secret are now specified within the data structure.

2nd attempt - using webhook
This is re-creation of #258 since the source repo/branch were deleted my mistake.

fixed scoheb fork reference


Improve anno logging

This does 2 things (each in its own)

DRY out the logic for running transforms and logging them into new private APIs. They're not great, but at least the code duplication is gone
Fix a bug where compilation would crash if you have an annotation that json4s can't serialize and have log-level trace

(2) should be backported to 1.2.x but (1) won't apply so I'll have to fix it up manually.
Contributor Checklist

[ ] Did you add Scaladoc to every public function/method?
[ ] Did you update the FIRRTL spec to include every new feature/behavior?
[x] Did you add at least one test demonstrating the PR?
[x] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[x] Did you add text to be included in the Release Notes for this change?

Type of Improvement

bug fix
code cleanup

API Impact
No impact on public API
Backend Code Generation Impact
No impact
Desired Merge Strategy

Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you mark as Please Merge?

Note: this PR, as written, is backportable to 1.3.x, but not 1.2.x. 1.2.x doesn't have firrtl.stage.transforms.UpdateAnnotations.

Note: this PR, as written, is backportable to 1.3.x, but not 1.2.x. 1.2.x doesn't have firrtl.stage.transforms.UpdateAnnotations.

Yeah that's right, I'll have to manually fixup the backport for 1.2.x


ListChangeRecord.added gives incorrect results

Looking at the source for ListChangeRecord:
http://google3/third_party/dart/observable/lib/src/records/list_change_record.dart?l=69&rcl=139922884
The 'added' method uses object.getRange(index, addedCount), which is incorrect because getRange takes a start index and end index. The result is a thrown error if index > addedCount. Correct logic should probably be object.getRange(index, index + addedCount).

Thanks!

This change was reverted I believe.


change(rpc): Return an error from getblocktemplate RPC if Zebra is still syncing lots of blocks

Motivation
Mining pools may use getblocktemplate RPC method to check if the node is synced to the tip so we want to check that Zebra is likely close to the network chain tip before responding with a block template.
Closes #5675.
Solution

Add a ChainSyncStatus trait to zebra-chain.
Add sync_status field to GetBlockTemplateRpcsImpl.
Return an error from get_block_template method if !sync_status.is_close_to_tip().
Add a MockSyncStatus for tests.

Review
Part of regular scheduled work.
Reviewer Checklist

[ ] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[ ] Are the PR labels correct?
[ ] Does the code do what the ticket and PR says?
[ ] How do you know it works? Does it have tests?

Follow Up Work

Hide MockSyncStatus and other test-only code behind #[cfg(test)]?

@mergifyio update

@mergifyio update


Added searching for the D Programming Language

Added the D language source files .d and .di
https://dlang.org/

Looks good. I vote for merging this trivial change.


Move codegen translators to sub-directory

Right now src/include/codegen has almost all of the code for the codegen component. I think that we should move the translators to src/include/codegen/translators to clean up this directory at bit.
I can do this tomorrow on my train ride up to MIT.
@pmenon @seojungmin -- Thoughts?

@apavlo  I agree that it is an issue, and moving translators into a subdirectory would be a good, first move.
There are other potential candidate files to think about moving into a subdirectory, such as LLVM utility class header files(If/Loop/FunctionBuilder) and maybe proxies, later on. @pmenon What were the other candidates you mentioned last time?

@apavlo Yea, I think that makes sense, especially as we continue to add more stuff.
I was thinking of having a subdirectory for operator, expression, and proxy for operator translators, expression translators, and all the proxy classes, respectively.

I'll take care of this. I'm trying to get started on understanding the LLVM engine.


[Bug]: meilisearch error when running scripts

What happened?
For some reasons, some scripts are affected by an error related to meilisearch. Tested both local and docker, and both linux and windows
Steps to Reproduce
as least 2 scripts are affected:

npm run create-user
&
npm run ban-user
(on windows passing the arg directly to "ban-user" seems to work)

Relevant log output
> node:internal/process/promises:289
            triggerUncaughtException(err, true /* fromPromise */);
            ^

MeiliSearchCommunicationError: fetch failed
    at Object.fetch (node:internal/deps/undici/undici:11576:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  errno: undefined,
  code: undefined
}

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I tested on a third pc (windows) and on that 3rd one it is working, which surprised me since all were tested on the latest LibreChat update with the same .env file 🤷♂
Side note, the "create-user" script, does not write the new user to the db when "successful"

And what the solution to fix the bug?

And what the solution to fix the bug?

This specific issue has been fixed afaik


Landing page for docs violates a11y animation requirements

There is an accessibility issue in the main page of the docs - there's a a11y standard to make sure animation doesn't last more than 5 seconds or it can be paused by a button.
We had a similar animation in maplibre.org but were told we should remove it.
Just FYI :-)

Thanks for letting me know about that, gonna getting rid of the background animation as soon as possible.


Implement gedis client for remaining endpoints

Gedis client has been implemented for identityd only. We still need to implement all the other BCDB endpoints:

[ ] provisiond : https://github.com/threefoldtech/zosv2/blob/master/modules/provision/remote_store.go
[ ] capacityd : https://github.com/threefoldtech/zosv2/blob/master/modules/capacity/store.go
[ ] networkd : https://github.com/threefoldtech/zosv2/blob/master/modules/network/tnodb/store.go (wait on this one since networkd is under heavy change at the moment #278 )

Okay, my plan was to actually use the gedis api schema to auto-generate the client, since we already can generate types from data schema.
Unfortunately the api uses property serialization format which is harder and more time consuming to implement. hence we will instead build the API by hand, and generate the types from the jsx schema only.
We will use the schemas from there locations:

directory
workload
others ?

others ?

Nop, so far this is all the schema we uses.

https://github.com/threefoldtech/zosv2/pull/281


Add material-icons to typography

Originally added by Surma in commit e2d090e58d14877d9ccf5c7c067ab4dfe29a3c49. Was never pulled into master from mdl-1.0 as needed. This adds it into master for the 1.1 release.

Good find. Thanks @Garbee


check topic existence at creation

I think it shouldn't allow users to create topics with the same name because it will be confusing although they might have different descriptions.

Merged. Thanks :smile:


[INFINITY-1185] Rename DefaultPlanFactory to DeployPlanFactory

I'm not feeling dogmatic either way, but by this logic, should DefaultPlan also be moved to DeployPlan? The downside is that there would no longer be an obvious target to override for developers who want to reuse that logic in their custom plan definitions, which probably isn't worth the naming consistency between the factory and its product.

DefaultPlan isn't only used for deploys.  The HDFSRecoveryPlanManager uses it.

retest this please

The tests failed with some error during kafka install, but the logs are too sparse to diagnose.  Running again to repro.

network error

retest this please


Static backdrop

Is there a way to do this with SvelteStrap? https://getbootstrap.com/docs/5.0/components/modal/#static-backdrop -- so that the modal does not close when you press escape or hit a key
Thanks

Not currently but looks like would be simple addition, can look this week!

Thanks so much!

Hi @msummers68 , this was released in v5.3.1.
(FYI the "bump" warning animation is missing but will be addressed in #296)


[SMALLFIX]Add javadocs for setupMasterCluster

Add javadocs for JournalShutdownIntegrationTest#setupMultiMasterCluster and JournalShutdownIntegrationTest#setupSingleMasterCluster

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14592/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14602/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14638/
Test PASSed.


Provide additional support for Python 2.7 installations

For #2929

Background
Seeing errors around the ipykernel>=5.1.2 requirement and providing a substitute installation.

Coverage remained the same at 82.461% when pulling 4e1c13ad0d621a03d7ef6082b6601f90eabd8bc3 on ajd/python27-support into 67f3b7cfe4239442f2f5cc7a93ce4c3ea289aef7 on master.


Show warning that Safari mobile view is required when registering iOS devices on iPad

Describe the solution you'd like
When the my devices page is viewed on an iPad with the desktop view mode enabled, there needs to be a warning that iOS device registration will not work unless you switch to mobile view mode.
Describe alternatives you've considered
Support iOS device registration on iPad with either Safari desktop or mobile view mode.
Additional context
This issue has wasted a lot of time for our support team - a simple warning would have resolved the problem immediately.

I encountered the same problem.


Username OID Mapping [BUG]

Username OIDC Mapping - If I have the preference set "Username OIDC Mapping" and specify the claim "onpremisessamaccountname".  It maps the literal name "onpremissessamaccountname".
xCreds 4.1 (6346)

Found that this occurs when logging in with a user for the first time on OIDC.  It does not use the onpremisessamaccountname claim, however logging in with the AD login creates the username correctly.

Closing this as I have recreated the preferences mobileconfig file and the issue doesn't seem to be present, will recreate if I run in to it again.  Thanks!


How to change annotation results?

Hi,
I have 3 questions:

Is there a way to change the final labeling results? For example, if we recognize a mistake in labeling, can we correct it?
I need to label LiDAR data for trajectory prediction. Can I use this labeling method for this type of problem?
For evaluating results, do I need to compare the camera data and LiDAR labeled data one by one? Or do I need to create ground truth labels for them with other applications first?

thank you.
(I didn't close the other issue, I will reply by showing the error that I got. )

Hi, sorry for the late reply

No, that would require a separate program more suited for labelling such as CVAT. However this could be the initial starting labels.
This repo is a 3d object detection auto-labelling work I.e. 3d bounding box auto-labelling, which is fundamentally different from trajectory prediction labels.
You could compare the camera data, that would definitely help to visually validate the labels. I don't have that code implemented but it's not too hard to do. If you're just testing ms3d with waymo or nuscenes, they already have gt labels for you to compare against.

Thank you for your response.


resource apstra_datacenter_routing_zone does not allocates Leaf Loopback ip's

inherit from blueprint or create a resource apstra_datacenter_routing_zone_resource_pool_allocation

creating a routing zone with this code:
resource "apstra_datacenter_routing_zone" "routing_zone" {
  name              = var.routing_zone_name
  blueprint_id      = apstra_datacenter_blueprint.this.id
  vlan_id           = var.routing_zone_vlan_id
  vni               = var.routing_zone_vni
}

does not allocates leaf loopback ip's.
possible solutions:

add a parameter to apstra_datacenter_routing_zone
inherit from blueprint
foresee a resource apstra_datacenter_routing_zone_resource_pool_allocation

As in the Web UI, a resource pool needs to be allocated for assigning loopback addresses within each routing zone.
You can do this using the apstra_datacenter_resource_pool_allocation resource with the optional routing_zone_id attribute:
resource "apstra_datacenter_resource_pool_allocation" "routing_zone" {
  blueprint_id    = apstra_datacenter_blueprint.this.id
  routing_zone_id = apstra_datacenter_routing_zone.routing_zone.id
  role            = "leaf_loopback_ips"
  pool_ids        = [ apstra_ipv4_pool.something.id ]
}

Including routing_zone_id makes the apstra_datacenter_resource_pool_allocation resource behave the way you probably imagined apstra_datacenter_routing_zone_resource_pool_allocation would behave.

Hello,
Thanks for the quick response. Exactly what I need!
Maybe you can add a notice in the documentation regarding this setting on:
https://registry.terraform.io/providers/Juniper/apstra/latest/docs/resources/datacenter_routing_zone


Change Watches to WatchesMetadata.

Fixes: https://issues.redhat.com/browse/ACM-14605
WatchesMetadata doesn't unmarshal the data part and save a lot of memory.
Tested with 200 managedcluster, the base memory usage(0 managed cluster) is 145Mb:

Watches uses 400Mb
WatchesMetadata uses 174Mb.

/assign @zhujian7

/lgtm


ReferenceError: describe is not defined

The describe function is not being imported properly from the Jest module. For some reason, the generated JS code does not append the Jest prefix, so somehow it's considered to be globally available.
However, after hand-modifying the code to use Jest.describe instead of just describe, the function is still undefined.
Somehow, the describe function is not getting imported, or perhaps the compiled JS code does not even define it in the library.
I am currently using bs-platform version 7.0.1. I would be happy to supply examples if necessary.

Are you running it with the jest command-line tool? It's not intended to be run as a stand-alone node script.

Assuming the comment above fixed it, but let me know it did not.

Sorry for the delayed reply. Yes, that was problem and the correct solution. Thanks for the help!


Do/end matching is not strict enought

As you can see below, currently package highlight do/end pairs even if they are part of another word. I think it would be better to ensure that do and end keywords is surrounded by whitespaces before highlighting them.

:+1: thanks for your awesome work, @wende!

There is new issue, howewer, as you see screnshot below.

New regex captures unnesesary whitespace symbols around the keywords (something like do\n) and many conditions below (for example here) stop working.

Yes. I made mistake by commiting without checking.
The problem right now is, that if it matches \n then it extends range by one row. But if it's any other character it extends by column.
I've got to think of something clever to fix that

I didn't realize that such thing as word boundary (\b) exists in regex. Well what do you know! :grinning:
v1.5.12 should fix that.
Merry Christmass :gift:

@wende thanks, and you too :smile:


[Q&A] What is the differences between ScrollControls vs r3f-scroll-rig

May i know the differences of @react-three/drei ScrollControls and r3f-scroll-rig.
Seems like both able to achieve the same results?

Hi @liho00 - thanks for the question. I think it's important to answer this question as you can achieve the same result but with a fundamental difference.
With ScrollControls you use empty HTML divs to allow the page to scroll, and then design your layout completely with WebGL. There is no semantic HTML content for screenreaders to find or search engines to index. You can use something like https://github.com/pmndrs/react-three-a11y to add accessibility but it comes with a performance overhead.
If you are building small website for a WebGL-only audience, this might be the simpler approach.
r3f-scroll-rig on the other hand, is based on the principle of progressive enhancement. You can use HTML/CSS for all the content and layout - and then enhance specific components with WebGL if the client supports it. This also makes it easy to render a simple mobile friendly website without any extra WebGL stuff.
Part of your team could focus on layout for the pages and another creative team could work in parallal to sprinkle WebGL effects on top.
Suggested reading: Progressive Enhancement with WebGL and React

Part of your team could focus on layout for the pages and another creative team could work in parallal to sprinkle WebGL effects on top.

Thanks for your explanations, appreciated.
After read the blog, I think the idea that you guys propose and build are great.
Im gonna start learning and build with it.
But, I found a link was outdated on the blog that you shared.

Could you help update or share the link to me here?
Thank you.


Strange problem with Gorilla and serialization of "nested" data structure.

I openeded an issue for the nippy library here:
https://github.com/ptaoussanis/nippy/issues/57
But It might be a Gorilla repl problem. I cannot reproduce it in a non-Gorilla repl (Emacs or leiningen).

Not sure what's going on here. I'll make some comments on the nippy issue.


reorganize tests to make sure they do not depend on more than needed #49

Test cases that were depending on util have been moved to the utilTest
project (which obviously depend on util). The tests project does not
depend anymore on util, proving that some of macwire features do not require
this extra dependency.
Another change is that util is now a provided dependency of macros.

thanks!


Typescript?

This project currently has no typescript definitions, would you consider a PR to convert the entire thing to typescript?

I was curious about this exact thing as well. Is there a way to use typescript with this project?


File "scripts/demo.py", line 7, in

Traceback (most recent call last):
File "scripts/demo.py", line 7, in
import tensorflow.compat.v1 as tf
File "/usr/local/lib/python3.7/dist-packages/tensorflow/init.py", line 102, in
from tensorflow_core import *
File "/usr/local/lib/python3.7/dist-packages/tensorflow_core/init.py", line 28, in
from tensorflow.python import pywrap_tensorflow # pylint: disable=unused-import
File "", line 1019, in _handle_fromlist
File "/usr/local/lib/python3.7/dist-packages/tensorflow/init.py", line 50, in getattr
module = self._load()
File "/usr/local/lib/python3.7/dist-packages/tensorflow/init.py", line 44, in _load
module = _importlib.import_module(self.name)
File "/usr/lib/python3.7/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "/usr/local/lib/python3.7/dist-packages/tensorflow_core/python/init.py", line 52, in
from tensorflow.core.framework.graph_pb2 import *
File "/usr/local/lib/python3.7/dist-packages/tensorflow_core/core/framework/graph_pb2.py", line 7, in
from google.protobuf import descriptor as _descriptor
File "/usr/local/lib/python3.7/dist-packages/google/protobuf/descriptor.py", line 40, in
from google.protobuf.internal import api_implementation
File "/usr/local/lib/python3.7/dist-packages/google/protobuf/internal/api_implementation.py", line 104, in
from google.protobuf.pyext import _message
TypeError: bases must be types

Pls let us know your enviroment.

Pls let us know your enviroment.

Google colab

Google colab

@mem0rz Pls use this fork. The bug you have should be fixed in this fork.
https://github.com/zxkmm/gpt2-ml-fixed

Actually , this is the fork which I use.

Actually , this is the fork which I use.
Thank you! I’ll merge it.


Extract shell script out of ~/.tmux.conf

The main idea here was to extract the embedded shell script of tmux.conf out on it's own file.
This way the code is more maintainable and performs better.
This lead to the need of splitting tmux.local.conf to 2 files, a property file and a tmux conf file (because it's sourced from both tmux, and shell).
It should be now possible to split the shell script into smaller parts that can be used individually (a bit more performance optimization).
I also added an installed. I think it's good for many reasons (reproducible results, easier integration with dotbot, less readme)
Thanks for your initial idea, it's really awesome. I believe this PR will help the project to mature further.
(NOTE-1: I haven't changed any of your configs, just moved them around)
(NOTE-2: I haven't updated the README)
(NOTE-3: Consider renaming your repo to oh-my-tmux :) )

Hello @Kidlike,
It seems you put a lot of efforts in this PR and to honor that I'm going to review it.
But first, I believe you should contact maintainers before engaging into such major refactoring. A key value proposition of my configuration is being self contained: you just copy around tmux.conf and it just works. Splitting it into script and dependencies is how everybody else is doing it and I don't want to take that route. That sole perspective makes your PR rather moot.

The main idea here was to extract the embedded shell script of tmux.conf out on it's own file.
This way the code is more maintainable and performs better.

"more maintainable" is highly subjective and "performs better" is hypothetical.

This lead to the need of splitting tmux.local.conf to 2 files, a property file and a tmux conf file (because it's sourced from both tmux, and shell).

I read it as "it makes things more complex".

It should be now possible to split the shell script into smaller parts that can be used individually (a bit more performance optimization).

This is again hypothetical ihmo.

I also added an installer. I think it's good for many reasons (reproducible results, easier integration with dotbot, less readme)

Small nitpicking first: I don't believe .bsh is an accepted convention for Bash scripts extension.
Then I prefer people realize what they're doing while following the 4 tiny install steps. They are optional anyways and as mentioned above copying around tmux.conf from machine to machine just works.
Having an install script also tends to make people believe they can curl install.sh | bash but your install script starts with some introspection to locate itself on the filesystem.

Thanks for your initial idea, it's really awesome.

Thank you!

I believe this PR will help the project to mature further.

I'm sorry but I personally believe it doesn't. I know you invested time in this but this is taking a direction I don't approve of.

(NOTE-1: I haven't changed any of your configs, just moved them around)

From what I can see, that's not entirely true. You changed colors and attributes. You removed comments (e.g. the comments about Powerline which I ended up adding because too many people were confused about whether they should install some Powerline thing first).

All in all, I won't accept this pull request. Thank you for your understanding. I hope we're still friends.

Monica, no feelings at all.
I made these changes for me firstmost, and I will keep them on my fork (although that one contains more changes).

more maintainable

Not subjective. Having a shell script behind a comment-wall, makes it difficult to read, difficult to write, syntax checkers to fail, highlighters to fail, etc...
 AND has the potential to become more optimized whereas right now that's an impossibility (it can only grow).

tmux.local.conf split

Now this IS subjective. IMO it actually makes things more clear, the one is a property file that you set colors etc that are used by oh-my-tmux, and the other is just a tmux config file that has really no relation to this project - but some generic defaults. (probably the file naming should be better).

install script

If you had ONLY 1 file, I could understand your argument, but you don't. You have 2, so it's not just "copy around" tmux.conf. This is a non-argument.

Having an install script also tends to make people believe

That's just an assumption. People are doing both.

NOTE-1

Nope, I haven't changed the content. Just removed the in-line comments. They could be added on next or previous lines if they are essential.

I know that when someone makes changes to your code is hard to accept it because you are attached to it; it's essentially an attack to your personality.
Because who we are if not stand by our opinions :)
I hope one day you will realize and learn.
Feel free to close this.
No hard feelings, I made these changes for me firstmost, and I will keep them on my fork (although that contains more changes).

more maintainable

Not subjective. Having a shell script behind a comment-wall, makes it difficult to read, difficult to write, syntax checkers to fail, highlighters to fail, etc...

Ever wondered why you are the only contributor to this project, even though it has so many stars and forks?

performs better

Not hypothetical. cut -c3- larger-file | sh -s function CANNOT perform better than sh smaller-file function. AND has the potential to become more optimized whereas right now that's an impossibility (it can only grow).

tmux.local.conf split

Now this IS subjective. IMO it actually makes things more clear, the one is a property file that you set colors etc that are used by oh-my-tmux, and the other is just a tmux config file that has really no relation to this project - but some generic defaults. (probably the file naming should be better).

install script

If you had ONLY 1 file, I could understand your argument, but you don't. You have 2, so it's not just "copy around" tmux.conf. This is a non-argument.

Having an install script also tends to make people believe

That's just an assumption. People are doing both.

NOTE-1

Nope, I haven't changed the content. Just removed the in-line comments. They could be added on next or previous lines if they are essential.

I know that when someone makes changes to your code is hard to accept it because you are attached to it; it's essentially an attack to your personality.
Because who we are if not stand by our opinions :)
But this is not how open source works.
Have you realized how bad your project is that it has so many stars and forks and only 1 contributor and 1 accepted PR ?
I hope one day you will realize and learn.
Feel free to close this.

Not subjective. Having a shell script behind a comment-wall, makes it difficult to read, difficult to write, syntax checkers to fail, highlighters to fail, etc...

It indeed depends on what I'm used to. That being said cut -c3- ~/.tmux.conf | shellcheck -s sh works just fine.
Also while developing. You're not obliged to do it in tmux.conf directly.

Not hypothetical. cut -c3- larger-file | sh -s function CANNOT perform better than sh smaller-file function. AND has the potential to become more optimized whereas right now that's an impossibility (it can only grow).

If cut -c3- larger-file | sh -s function becomes unbearably slow, it's a clear indication it's time to stop piling up stuff. I don't believe I've reached that point. I reckon that's also subjective.

Have you realized how bad your project is that it has so many stars and forks and only 1 contributor and 1 accepted PR ?
I hope one day you will realize and learn.

Now you're being rude.

Truth hurts :)
Anyway, have a good one.


Fix /for real/ the use of atomic inc for the client ID

While re-factoring the code to use logrus, I noticed we were still racy in our use of atomic operations. This time we should be good!

Coverage increased (+0.5%) to 71.055% when pulling 59078db5eca7a45bde1c0a43aa9e509d94d5e712 on dlespiau:20170517-atomic-inc-continued into 800cc89e68c488d7c994c1139973ed06d05ff66f on clearcontainers:master.

lgtm

LGTM

lgtm


Livestream AFK

Description
This PR is a brainstorming and starting one.
We want to enable Livestream Nostr.

[ ] Create a way to push run your camera, share screen, enable camera and micro.
[ ] Save and upload your live into IPFS.
[ ] This stream is a Nostr event, your room is an AFK URL everyone can access.
[ ] Enable Livechat with NIP

Docs of the NIP:
https://github.com/nostr-protocol/nips/blob/master/53.md

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I have substantial expertise working with multimedia streaming and frontend applications using Go, JavaScript, TypeScript, Solidity, and Cairo. My experience creating WebRTC and media capture features makes me well-suited for this Nostr livestreaming implementation.
How I plan on tackling this issue
I'd approach the livestreaming feature systematically. First, use WebRTC to create essential media capture functionality, including camera and screen sharing. Then, add IPFS storage for recorded streams to provide effective chunking and storing of media data. The Nostr event integration would manage room creation and discovery, while the live chat would be done according to NIP requirements. I'd prioritize having a consistent user experience with appropriate error handling for varying device capabilities and network situations.
:) ETA 48Hrs

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hi, I'm Collins a frontend and blockchain developer, and an active contributor on OnlyDust. You can check out my profile here: https://app.onlydust.com/u/0xdevcollins. This is my first time contributing to this repository, and I’m excited about the opportunity to contribute. Looking forward to collaborating!
How I plan on tackling this issue
To enable Livestream Nostr, I will implement features for camera and screen sharing, allowing users to access their camera and microphone while sharing their screens. I’ll also integrate IPFS to save and upload livestreams for decentralized storage, and create a Nostr event that generates a unique AFK URL for the livestream room. Additionally, I will implement live chat functionality using NIP for real-time interaction. I’ll ensure to reference the NIP documentation to maintain compliance and best practices.


"Copy to subsequent media" does not work if depicts Wikidata place

Steps to reproduce:

Take several pictures near a Wikidata place
Upload both together.
When asked whether the pictures depict the place, say yes.
Write a caption/description
Tap "Copy to subsequent media"
Tap "Next"
Expected: The caption/description from step 4 has not been copied. Problem: The caption/description is from the Wikidata place.

Workaround: Tap "Previous" and tap "Copy to subsequent media" again. This time it works.

Interesting, there may be special conditions I have not thought of.

Hi @nicolas-raoul  Could I please work on this issue? Pls assign me. Thank you:)

@junhaow1 Yes thanks! First, please let us know whether you are able to reproduce the issue.

Can I work on these issue if @junhaow1 not working ?

@arinmodi Feel free to work on it, thanks!

@nicolas-raoul, not able to reproduce

@nicolas-raoul As suggested by you, I will be trying to work on this issue first :)

@nicolas-raoul
When I reproduce the issue, I am not getting any bug occurrence. The captions and description is getting copied to the whole batch without having tapped the previous. Am I missing something here?

When setting the development environment, I am getting the following errors

@ayushanand308 For such errors I recommend searching the web for these error messages.

@arinmodi @ayushanand308 I just tried and was able to reproduce the issue the first time. Make sure you are getting the popup at step 3. If not, edit the pictures' EXIF to be at the location of the Eiffel Tower, then select both and share to the Commons app.

@nicolas-raoul  I followed what you said and was able to successfully reproduce the issue.

@ayushanand308 Great! Do you want to be assigned to this issue? 🙂

@nicolas-raoul Yes!

@ayushanand308 It is yours! Please let us know about your progress every few days. Thanks! :-)

Is this how it is actually supposed to work?
https://user-images.githubusercontent.com/99035102/222404635-dbdeb5fb-677d-4904-9c4a-88ff6fd316df.mp4

Yes exactly 🙂

@nicolas-raoul  I have made a PR. Can you kindly review it. :-).

@ayushanand308 Did you get a chance to look at my pull request feedback at https://github.com/commons-app/apps-android-commons/pull/5163#issuecomment-1464584775 ? Thanks! If you have no time, we can unassign you and someone else will build upon your pull request, no problem. :-)


(WIP) Added hooks + some webserver stuff and some database stuff

The idea behind hooks is separate the core of the bot while being able to create extensions, as you will notice while reviewing the /scripts folder (all the python files inside scripts are automatically executed. the /scripts/utils is not automatically executed). And there is some database / website wip code too

I've replied messaged to the user above on discord and we discussed it.


Support for intesection of 3 sets?

Hi,
Is intersection of 3 sets supported? It seems from my experiments that it isn't - am I missing something? Here's a modified simple.html I used to test my assumption:
<!doctype html>

    <meta charset="utf-8">
    <title>Simple venn.js example</title>

Thanks,

g.

Right now we are assuming that if you leave out the size information for any pair of sets, that the desired size between those sets is 0: https://github.com/benfred/venn.js/commit/050d9adf9c2bd85c98374d25c93cedc524e2bbf7#diff-677d382da9f8d81f61d50af24f937b32R74
Adding the missing pair-wise set intersection data should make this work:
var sets = [ {sets: ['A'], size: 12},
             {sets: ['B'], size: 12},
             {sets: ['C'], size: 12},
             {sets: ['A','B',], size: 2},
             {sets: ['B','C',], size: 2},
             {sets: ['A','C',], size: 2},
             {sets: ['A','B',], size: 2}];

var chart = venn.VennDiagram();
d3.select("#venn").datum(sets).call(chart);


Bugfix / Supervision: removeFollower should remove the last follower(s) first

Adresses #4924

@kvahed fyi


Generate method

This PR updates the method generator to use the ne MissingMethodFinder and act on the entire document:

Invoking the code action anywhere offers the possiblity to geneate missing methods
Diagnostics are enabled.

@BladeMF note that as we no longer use the parser, the tests have been simplified, the deleted test cases could be moved to code-transform however.
I also notice that, at least for me, generating methods in a foreign class does not place the method in the correct place (probably the source or offset is being wrongly mapped).

What I suggest is at least make it an option to turn those off

You can turn them off: https://phpactor.readthedocs.io/en/master/reference/configuration.html#language-server-diagnostics-on-update but I guess you mean more granularly?

I don't mind adding some mechanism to specific diagnostics. Generics AND an extension would solve this, but generics are still a long way away (I would need weeks of dedicated time probably)

Not sure what to do either. Probably a "turn off diagnostics for undefined methods" setting would be the easiest solution.


Instana customer is getting 502s "upstream_reset_before_response_started{protocol_error}" due to special Server-Timing response header format

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
The customer is using an istio sidecar proxy and this one is coupled with a Java web application based on HTTP. As soon as Instana Java tracing is enabled, istio fails requests with 502s "upstream_reset_before_response_started{protocol_error}". Every Instana tracer sets a Server-Timing response header containing the following format:
intid;desc=<64-hex-char-trace-id>
The format should be correct as of https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Server-Timing and https://w3c.github.io/server-timing/#the-server-timing-header-field.
So we really think that the issue is in istio.
The reason why we need that response header is the requirement to pass the trace ID to the web client for end-user monitoring (EUM).
Can you please point us to the related code parts and work on a fix? TIA
Version
Kubernetes version: 1.29.2
istio: proxyv2:1.22.1-distroless
Envoy: 1.30.2

Additional Information
No response

It is not for all requests. Envoy has an http2 client flood detection test which is checking for that error:
https://github.com/envoyproxy/envoy/blob/aa8d0f7d7a2866b5f81dfe46e975b80de26a0669/test/integration/http2_flood_integration_test.cc#L195
But there was not much instrumented traffic visible. We will try letting Envoy drop our response header and to tcpdump this.

I tried to reproduce this with: curl echo -H "Server-Timing: intid;desc=ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff" --http2-prior-knowledge, no success. is there any way we can reproduce this to inspect more?
else trace logs during a failure (https://github.com/istio/istio/wiki/Troubleshooting-Istio#collecting-information-2) would help

Thanks, John. Still investigating on our side and collecting further information.
We've seen the following possibilities for the 502 protocol_error issues in Envoy code:

encoding/decoding issue (actual protocol/data format issue)
HTTP2 client flooding
response size too big/small
invalid response header name

Closing for now. Handled by another team on our side. Thanks.


Update to use Docker for Mac/Windows

Removed sections about using Docker Toolbox with virtualbox and added links to Docker for Mac/Windows.
Docker for Mac/Windows uses native virtual machines instead of virtualbox and introduces many improvements.
See: https://blog.docker.com/2016/03/docker-for-mac-windows-beta/
Resolves: #706

👍

"Docker for Mac/Windows uses native virtual machines instead of virtualbox and introduces many improvements."
It also requires moving a lot of stuff around since the "usual places" on Linux are restricted access on Mac.  I think this should be added to the doc and the stuff about the original setup retained.
I work on a Mac in Docker and use VirtualBox to avoid the artificial constructs required to use Docker Mac.

What "usual places" are you talking about? You can add pretty much anything via the GUI to be mounted on VM start.

I'm talking mostly about shared volumes.  OS X doesn't allow /var/www, for example -- it's owned by root:wheel, so you have to put things in non-standard places.


feat: Update near packages

What?
#Notion/ Trello
Why?
How?
Testing?

[ ] Run tests locally

Screenshots (optional)
0
Anything Else?


Backporting again Solve the missing files mystery during stage out

1.0.12 version of #6695

@ticoann also good to go. There is no need for a new tag, I refuse to install this agent version again :)


Question about the VQVAE embedding indices

Hello! Thank you for sharing your work. I ran the VQVAE model with the following parameters:
--no_levels=4
--downsample_parameters='((4, 2, 1, 1), (4, 2, 1, 1), (4, 2, 1, 1), (4, 2, 1, 1))'
--upsample_parameters='((4, 2, 1, 0, 1), (4, 2, 1, 0, 1), (4, 2, 1, 0, 1), (4, 2, 1, 0, 1))'
--no_res_layers=3
--no_channels=256
--num_embeddings='(2048,)'
--embedding_dim='(256,)'

My input is shape (1,1,96,128,96) and the output of the encoder is shape (1, 256, 6, 8, 6). Given 256 channels, I would expect to receive 256 embedding indices from the quantizer (expected shape (256, 6, 8, 6)). However, the output of the function index_quantize yields embedding indices of shape (1, 6, 8, 6).

Could you help me understand why there is one set of indices for 256 features?
I see in the paper you say you get up to 1400 tokens for a single input. What parameter allows for that representation here?

Hi @tlasmanbotch,
Thank you for your interest in our work.
Regarding your questions, let's outline the structure of a VQ-VAE. A VQ-VAE is formed by an Encoder that takes the input image [B,C,H,W,D] and projects it into the encoder space of size [B,c,h,w,d]. Then the quantizer takes the encoder space [B,c,h,w,d] and projects it first to an index quantized [B,1,h,w,d] and then back into quantized [B,c,h,w,d] by mapping each vector of the encoder space to the closest element in its codebook.

Could you help me understand why there is one set of indices for 256 features?

The index that you received from the index_quantize method is the index of the codebook element to which the vector of the encoder space representation is mapped to. This index-based representation is used for training transformer-style networks.

I see in the paper you say you get up to 1400 tokens for a single input. What parameter allows for that representation here?

The 1400 tokens representation is calculated based on the input size and network structure. In our work, we have an input of shape [160, 224, 160] which after four downsamples it gets to [10, 14, 10] and after flattening (cuz transformers work on sequences) it ends up being a sequence of 1400 tokens. In your case you ended up with an index-based representation of size [6,8,6] which will become a sequence of size 288.

If you have any other questions please let me know. If you want we can set up a meeting and clarify everything. Otherwise if all is good please close the issue.
Cheers,
Dan

Hi Dan,
Thank you for your detailed reply - I greatly appreciate the help! This all makes sense and apologies for my misunderstanding. I am closing this issue.
Best,
Tommy


Fix hyperlinks and update some descriptions.

Fix hyperlinks and update some descriptions.

The custom skulls is no separate package implementation.What format should I write in better?

Big thanks for fixing those!


Restore bash completion for riff

Code was lifted from riff v0.0.7.
Fixes #747

Adapted and merged as bd063c03


fix: doc

:tada: This PR is included in version 0.1.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


$transaction doesn't roll back in NestJS when we pass method from external service

Bug description
$transaction works incorrectly in NestJS when we pass method from external service, but works well if it uses method from current service.
It doesn't roll back as expected.
Example:
// UserService
@Injectable()
export class UserService {
  constructor(private readonly prismaService: PrismaService) {}

  addMoney(userId: number, value: number) {
    return this.prismaService.user.update({
      where: { id: userId },
      data: {
        money: {
          increment: value,
        },
      },
    });
  }
}

// InventoryService
@Injectable()
export class InventoryService {
  constructor(
    private readonly prismaService: PrismaService,
    private readonly userService: UserService,
  ) {}

  async sell(userId: number, itemId: number) {
    const write1 = this.prismaService.userItem.delete({
      where: { ... },
    });

    // external service method
    const write2 = this.userService.addMoney(...);

    await this.prismaService.$transaction([write1, write2]);
  }

  addMoney(userId: number, value: number) {
    return this.prismaService.user.update({
      where: { id: userId },
      data: {
        money: {
          increment: value,
        },
      },
    });
  }
}

If write2 will fail - write1 doesn't rollback.
But... rollback will work as expected if write2 refers to the current service method. (this.addMoney)

How to reproduce
https://github.com/revivalme/nestjs-prisma-transaction-test
Bug reproduction section

Expected behavior
Transaction write1 should rollback as transaction write2 failed.

Prisma information

Environment & setup

OS: Windows 10
Database: SQLite, PostgreSQL
Node.js version: v14.15.4
Prisma version:

prisma               : 2.17.0
@prisma/client       : 2.17.0
Current platform     : windows
Query Engine         : query-engine 3c463ebd78b1d21d8fdacdd27899e280cf686223 (at<EMAIL_ADDRESS>Migration Engine     : migration-engine-cli 3c463ebd78b1d21d8fdacdd27899e280cf686223 (at<EMAIL_ADDRESS>Introspection Engine : introspection-core 3c463ebd78b1d21d8fdacdd27899e280cf686223 (at<EMAIL_ADDRESS>Format Binary        : prisma-fmt 3c463ebd78b1d21d8fdacdd27899e280cf686223 (at<EMAIL_ADDRESS>Studio               : 0.353.0

Conversation from Public Slack here

Thanks @revivalme for the report. We'll have a look at this!

I can confirm this. From the logs, it looks like transaction flag is not set correctly here and writes are not running in a transaction.

@revivalme Could you try out williamluke4:patch-1

@revivalme Could you try out williamluke4:patch-1 ?

Yeah, for some unknown reason it works, but shouldn't. UserModule has exports array with UserService, so whenever I import UserModule into other modules - I already have access to UserService without manually add this service to providers array.
(same info here https://docs.nestjs.com/modules#shared-modules)
The especially weird part of this is that in both cases, with/without manually add service to providers array, addMoney method of UserService invokes.
Also both cases have similar errors:
[Just with module import]
Invalid `prisma.user.update()` invocation:

  An operation failed because it depends on one or more records that were required but not found. Record to update not found. +5117ms
Error:
Invalid `prisma.user.update()` invocation:

  An operation failed because it depends on one or more records that were required but not found. Record to update not found.
    at cb (C:\Users\revivalme\Desktop\nestjs-prisma-transaction-test\node_modules\@prisma\client\runtime\index.js:78689:17)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async Promise.all (index 1)
    at async InventoryService.sellItem (C:\Users\revivalme\Desktop\nestjs-prisma-transaction-test\dist\src\inventory\inventory.service.js:56:9)
    at async C:\Users\revivalme\Desktop\nestjs-prisma-transaction-test\node_modules\@nestjs\core\router\router-execution-context.js:46:28
    at async C:\Users\revivalme\Desktop\nestjs-prisma-transaction-test\node_modules\@nestjs\core\router\router-proxy.js:9:17

[Module import with manual add service to providers]
InterpretationError("Error for binding \'0\'", Some(QueryGraphBuilderError(RecordNotFound("Record to update not found.")))) +5902ms
Error: Error occurred during query execution:
InterpretationError("Error for binding \'0\'", Some(QueryGraphBuilderError(RecordNotFound("Record to update not found."))))
    at C:\Users\revivalme\Desktop\nestjs-prisma-transaction-test\node_modules\@prisma\client\runtime\index.js:27103:19
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

So, given the above, guess it's too early to close this issue

@revivalme Both your logs above seem unrelated to this issue. They seem to be a result of you trying to update a record that does not exist in the database

An operation failed because it depends on one or more records that were required but not found.

And

Record to update not found.

Hey @revivalme, I'm going to close this issue, if you feel like the problems you are experiencing are still related to this specific issue then feel free to reopen it explaining why.


update k8s dependency to stable version

https://github.com/tensorflow/k8s/pull/215 is working on  refactor the TfJob to use K8s libraries, before we merge that, we should first to update k8s dependency to stable version.

now the dependency for k8s is not the release version and when I work on https://github.com/tensorflow/k8s/pull/215, the code-generator is something wrong because the dependency is too old and I switch the version to kubernetes 1.8.X.
Once this is get merged, https://github.com/tensorflow/k8s/pull/215 can go on.
After https://github.com/tensorflow/k8s/pull/215 get merged, then I can begin refactor the controller

@jlewi Any thoughts? can you take a look at this?

This change is

Overall looks good; just one minor question about a new dependency.

Reviewed 17 of 18 files at r1.
Review status: 17 of 18 files reviewed at latest revision, 1 unresolved discussion.

glide.lock, line 78 at r1 (raw file):

- name: github.com/pborman/uuid
  version: a97ce2ca70fa5a848076093f05e639a89ca34d06
- name: github.com/peterbourgon/diskv

Do you know why this dependency got added? Do we use it directly or is it a transitive dependency?

Comments from Reviewable

/ok-to-test

@jlewi That is a transitive dependency and it is auto added when I run glide update. And I resolve the conflicts just now and then I run glide-cleanup to remove some unused dependency.


How to support libe_sqlite3.so for mips64 ARCH ?

How to support libe_sqlite3.so for mips64 ARCH ?

I don't currently build e_sqlite3 for mips64.
The build system for e_sqlite3 is in a separate repo:
https://github.com/ericsink/cb
What platform are you needing?  Linux?  Android?

Thank you very much. I need to build it on Linux

I have not finded makefile and source code of sqlite3 in repo https://github.com/ericsink/cb . Can you tell me how to build cb on Linux platform for support mips64 ?

It is not a simple task at all, but here are a few tips if you really want to try:
The build files are generated by a program, the source code for that program is in cb.cs.
Compiling cb.cs is done by simply running csc or mcs.  There is no csproj file.
There are no Makefiles.  Each script is either a bash script of .bat file, depending on the platform.
cb.cs has virtually no comments to help.  But the basic idea is to modify cb.cs to also generate linux mips64 stuff.
You'll need to figure out which ubuntu packages have the cross-compilers for mips64 and how to invoke them.  I have no idea about this.
The source code for sqlite is in the cb/sqlite.  It's sqlite3.c.
You could skip the whole cb step by just figuring how to invoke the right cross-compiler and then drop the resulting .so file in the right place.
Then you'll need to modify the nuspec scripts in the SQLitePCL.raw repo to include the new file.  And so on.
This will be extremely difficult.  These parts of SQLitePCL.raw were never designed to be easy for others to work on.  As far as I know, nobody else has ever modified these scripts.

@ericsink I have support  libe_sqlite3.so libe_sqlcipher.so for mips64 architecture on Linux platform , and I has a PR on epo https://github.com/ericsink/cb . Can you review it ? Thank you very much.

I am on it.
Thanks,
Leslie Zhai

What is the RID for linux mips64 for .NET Core?

What is the RID for linux mips64 for .NET Core?

linux-mips64

@ericsink Can you rebuild SQLitePCL.raw for support linux-mips64? Thanks very much

Yes, I’m planning to do a 2.0.4-pre release soon, which should include the mips64 builds.

@sunny868 Please verify that the linux-mips64 builds for e_sqlite3 and e_sqlcipher in 2.0.4-pre20200828111558 are working properly.  These are not the builds you committed, but rather, were re-done by my build system.

ok ,I will verify  as soon as possible.


About some update and delete operation in the code.

Hello, I have a question to ask. I don't see the function of modifying or deleting the affected cache when updating records in the document and source code,
For example, when I update a document, theoretically, I should clear the cache records of the document. There is no schema in the source code The function of post ('update ', xxx).
In addition, if I use deleteMany or deleteOne to delete documents, the source code only executes schema Post ('remove ', xxx), but no schema Post ('deleteOne ', xxx), etc

Hello @YanxinNet ! Thanks for using speedgoose!
If i understand you correctly you're asking for additional events for SpeedGooseCacheAutoCleaner? Good point! I will extend plugin auto-clear to support more events.  However I'm not sure how with actions like updateMany and deleteMany etc. I will see how much information can I find in those hooks.
I will try to make it this week.

Hello @YanxinNet ! Thanks for using speedgoose! What is your current experience of using it? If i understand you correctly you're asking for additional events for SpeedGooseCacheAutoCleaner? Good point! I will extend plugin auto-clear ability to support more events. However, I'm not sure how with actions like updateMany and deleteMany etc. I will see how much information can I find in those hooks. I will try to make it this week.

I think your plugin is good, It make me learn more.
To be honest, when it comes to deleteMany, I have no idea how to update the cache, so the current practice is to add a prefix of model to each cache, and when a model has new or deleted data, delete all caches related to this model.

I've just finished testing of new mongoose events :) . List of currently supported events was added to readme.


Prepare for Minecraft v1.13

Minecraft 1.13 will have many changes in identifiers for blocks, items, materials, etc. We've already seen the trend in recent releases and Mojang wants to do away with magic numbers. I've looked at ways to generate the blocks.js file, or a similar file to build and export definitions.

PrismarineJS for Node.js generates detailed JSON files to define game artifacts. The source data is the Minecraft wiki. Scraping like this is precarious and I see that they have minor inconsistencies similar to those in ScriptCraftJS with manual updates to block.js. Rather than trade one set of problems for another I'd rather skip that option.
I spoke with Spigot developers. When 1.13 is available it will have "minecraft:name" identifiers and the Spigot team will probably generate maps for features already described in Bukkit. So even if Mojang defines something like red_hamster and Spigot has a hamster_red, both should still work. That's the plan for now.

Given that this is in the air, I recommend deferring any effort on item definitions until 1.13 development releases hit the streets. Coding to existing underpinnings, or using existing code, would seem to be a waste of near-term effort.
As this topic evolves I recommend adding info to this ticket so that we can prepare for the changes.

Some links to read about the transition :
https://www.spigotmc.org/threads/minecraft-1-13-what-to-expect.288714/
https://www.spigotmc.org/threads/bukkit-craftbukkit-spigot-bungeecord-1-13-pre7-development-builds.328883/

I did a quick test with the latest published Spigot version, which is compatible with 1.13-pre7. ScriptCraft loaded OK and the /js command worked fine for basic stuff (e.g. /js 1+1) but as expected, the Drone can't put down any block because it uses the deprecated (and now removed) Block.setTypeIdAndData method.

#388 is what I have working so far.


[Bug]

Describe the Bug
 So just randomly this message started popping up "Animated Status: Error. Report at github.com/toluschr/BetterDiscord-AnimatedStatus". I did not change anything or trigger anything
To Reproduce

Expected Behavior
 I mean.. I expected my status to be changing without the red text popping up
Screenshots

Discord Version

Stable 97097 (0ca818c)
BetterDiscord 1.2.1
Host 0.0.263 OS X 10.10.5 (14.5.0)
Additional Context

not one of ours. that's a selfbot


WebGL context is created with antialias: undefined

This looks like a mistake since there is no antialias property in game.config.
https://github.com/photonstorm/phaser/blob/22901a1b05abf5c37ff1e6fd0c4c7974d90d6017/src/renderer/webgl/WebGLRenderer.js#L42

A bug in the API: 3.2.1

This isn't actually used internally anyway, so it safe to remove from the webgl context config.

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


Breaking: Consistency across all settings

Nothing here is set in stone. Tagged with help wanted so I can get users thoughts and input
Please keep comments related to this issue. Want something else adding/sorting? Please open a new issue

Bought to light in #22. The new forceBaseDirectory setting is inconsistent with other settings in the extension. Upon reviewing the setting I think it would be handy to force consistency across all settings.
Issue

New setting causing confusion as it conflicts with other settings in the extension

forceBaseDirectory = "path/to/folder/"
Others = "/path/to/folder"

Other setting could have better pattern management for:

Consistency
Help keep the programme running at it's optimal

Resolution
All setting that relate to paths will have the same pattern:

A leading slash
No ending slash

The includeFiles setting, which relates to files, will have the following restrictions:

A leading slash
Must end in .sass or .scss

Documentation changes are required

Error detection change
try{ if (!fs.statSync(baseDirectory).isDirectory()) { /*err not folder*/ } } catch { /* err doesn't exist*/ }

Edit: Updated to reflect changes across the settings as a whole (not just the new one in v4.4)

Should I change all patterns so they must start with a slash but not end with one?

Should I change all patterns so they must start with a slash but not end with one?

That would be the best (my vote).

Closing as change is accessibly from the v5 tree by downloading and installing the live-sass-5.0.0-alpha.#.vsix file (where # is the current alpha revision)

Still open for discussion until official v5 release - comment here for any issues, queries or concerns

FYI: alpha-2 is available here

Exclude setting hasn't had pattern matching applied

Fixed in rc2


Grouping of controllers with NSwag

is it possible to group controllers with NSwag? I have Series of Controllers that specific for Web applications and some specific for mobile.  I want some kind of grouping mechanism that I can use to categorize the controllers. so that the mobile/ web developers don't have to look at everything from swagger just to find a mobile endpoint.

You could add a separate open API document for each group. I have done it this way, the code looks something like this:
// add separate Open API document for "my project" XYZ" to reduce complexity
services.AddOpenApiDocument((options, s) =>
{
    options.DocumentName = "my-project/v1";
    options.Title = "My project APIs";
    options.AddOperationFilter(operationProcessorContext =>
    {
        return operationProcessorContext.ControllerType == typeof(Controllers.MyProjectController);
    });
});


Could you give this a try while we update installation instructions?
brew uninstall complexity
brew install complexity --without-mimalloc

@albertoferro given the current M1 usage which I anticipate will increase over time, I've updated our Homebrew formulae so that this should work out of the box for both Intel and Apple silicon.
Want to give this another go and let me know what happens?

@joshuaclayton works perfect thanks


Get API approval for 7.2.0

Get approval for the API additions for 7.2.0.

https://apiview.dev/Assemblies/Review/98d0d26f3d5c484cbef9de9c2b4430c0?diffRevisionId=3ce09324d8a247e3b3053c8788131302&doc=False&diffOnly=True


Permutation Function for FactorVAE

According to the original paper by Kim et al., the permutation function permutes across the batch for each dimension. In the case here, if B, D = z.size(), def permute_latent(self, z: Tensor) should permute z along the dimension of B, i. e., z[i, j] = z[new_indices[i], j], where new_indices = torch.randperm(B).

I also think this is an error. The permutation should be applied to the batch dimension, rather than the factor dimension.


fix: remove duplicate export star from version.ts

Which problem is this PR solving?
Exporting twice from the same file causes issues in bundlers like webpack.
Fixes #4217
Short description of the changes
Remove duplicated export from version.ts file
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
N/A
Checklist:

[x] Followed the style guidelines of this project
[ ] Unit tests have been added
[ ] Documentation has been updated

Please add a changelog entry

Seems like something might be wrong with CI. it should have finished by now

Last workflow run failed for node-tests 14 and up with the message
Error: The operation was canceled.

Maybe related to Daniel's comment? Could we re-trigger the workflow?

Looks like someone did re-trigger but it is not any better

Still no luck with the tests. They fail with the cancel message :(
I've tried to run same scripts to see if I can reproduce but no error
npm install --ignore-scripts
npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --ignore @opentelemetry/selenium-tests
npm run compile
npm run test

all green. I guess some maintainer will work soon.


MINOR: test PR for conbench github information

Do not merge.
I'll use this PR to test a recent change to how we report GitHub information to Conbench on Arrow pull requests.

@ursabot please benchmark name=file-write lang=Python

@ursabot please benchmark name=file-write lang=Python

Thanks, it worked!


DataExtractor and French language

it doesnt work well, cant extract itemsearchname.dbc i think it doesnt support utf8
Unhandled Exception: System.IO.InvalidDataException: Found invalid data while decoding.    at System.IO.Compression.Inflater.DecodeDynamicBlockHeader()    at System.IO.Compression.Inflater.Decode()    at System.IO.Compression.Inflater.Inflate(Byte[] bytes, Int32 offset, Int32 length)    at System.IO.Compression.DeflateStream.Read(Byte[] array, Int32 offset, Int32 count)    at System.IO.Stream.InternalCopyTo(Stream destination, Int32 bufferSize)    at CASC_Lib.CASC.Handlers.DataFile.LoadBLTEEntry(IndexEntry idxEntry, BinaryReader readStream)    at CASC_Lib.CASC.Handlers.CASCHandler.ReadFile(RootEntry[] rootEntries, Locales locales)    at DataExtractor.Program.ExtractClientDBData()    at DataExtractor.Program.Main(String[] args)

Which client? 7.1.0?
I just installed french on 7.1.0 and 7.1.5 where it works fine. Have you tried to repair your client?

7.0.3, can you give me itemsearchname.dbc, because its only file i need.

If it's not working with frFR, your installation is broken. You should download the latest live client and extract the db2 file there.

it works fine with enUS in same client, it doesnt work when i change it to FR


Node.js 12 actions are deprecated on GH actions

See https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ for details.
Could you please update the action to use node16?

Wow, that was fast! Thank you!

No problem, thanks for reporting!


[Improvement] Show remaining time for the refresh token expiration

Insomnia Version: 5.15.0
Operating System: Arch Linux

Details
Hi there!
In the OAuth2 tab, Insomnia calculates the remaining time for the access token, but does not for the refresh token, as you can see here:

Would be possible to calculate and show the remaining time for the refresh token as well? If the refresh token has exp claim, show remaining time, else, don't.
Also, looks like the expired label is wrong:

Shouldn't it be "Expired a few seconds ago"?
Best regards,
Rafael Pacheco.

This should remain open.

Hi Greg,
I would like to contribute on implementing the mentioned improvement.

I'm not actually sure if there is a way to know the refresh token expiry date. The OAuth 2.0 RFC states that the response looks like this:
{
   "access_token":"2YotnFZFEjr1zCsicMWpAA",
   "token_type":"example",
   "expires_in":3600,
   "refresh_token":"tGzv3JOkF0XG5Qx2TlKWIA",
   "example_parameter":"example_value"
}

The expires_in key relates to the access_token and it doesn't look like there is anything else that would indicate the expiry of the refresh token.
Perhaps someone with more OAuth 2.0 experience could clarify this?

I'll do a more research as well. Thanks.

The expiration time is actually in the refresh token. For example, we have the following refresh token:
eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJlbXByZXNhX2lkIjoxLCJ1c3VhcmlvX2lkIjoxLCJ1c2VyX25hbWUiOiJhZG1pbiIsInNjb3BlIjpbInJlYWQiLCJ3cml0ZSJdLCJhdGkiOiJjYmI2NGNkNC1lMzlmLTQ4MjQtYTE1OS1hZTAxMDM3ZDMyZGMiLCJub21lIjoiQWRtaW5pc3RyYWRvciIsImV4cCI6MTU0MDIxNTg0NiwianRpIjoiZGM4NzFhMzUtMTJmZS00ODZmLWI0MjUtNGFmMDYzZTEyMTU0IiwiY2xpZW50X2lkIjoidWFhLWNsaWVudCJ9.abc

If you decode that (https://jwt.io/), you can see that there is a claim called exp, which is a Registered Claim Name at RFC 7519, so it is not a magical string. Also it is not mandatory, which means the refresh token may or may note have it. So, if the exp claim is present in the refresh token, Insomnia will be able to show the expiration time in the UI.

Thanks @rafaelrenanpacheco

@rafaelrenanpacheco it's my understanding that JWT is not part of the OAuth 2.0 standard. It's possible that an API might use JWT as convention but is not common.

@gschier you are right, JWT is just one of many possibilites to generate access and refresh token. I'm so used to use OAuth2 with JWT that I forgot that.
As you said about the OAuth 2.0 RFC, there's nothing about refresh token expiration. It is entirely up to the backend to accept it indefinitely, to blacklist it or refuse it after some period.
I'm closing this issue, thanks for your attention :+1:

I appreciate the insight @rafaelrenanpacheco 😄


JSON ABI doesn't include custom type T when defined in an array [T; n]

Let the following Sway contract:
contract;

struct Person {
    name: str[4]
}

abi TestContract {
    fn return_array_of_structs(param: [Person; 2]) -> [Person; 2];
}

impl TestContract for Contract {
    fn return_array_of_structs(param: [Person; 2]) -> [Person; 2] {
        param
    }
}

After building this contract, I would expect the JSON ABI to include the definition of that struct Person. But this is what is outputted:
[
  {
    "type": "function",
    "inputs": [
      {
        "name": "param",
        "type": "[struct Person; 2]",
        "components": null
      }
    ],
    "name": "return_array_of_structs",
    "outputs": [
      {
        "name": "",
        "type": "[struct Person; 2]",
        "components": null
      }
    ]
  }
]

And it doesn't tell me what's inside Person. This breaks the SDK because it tries to abigen Person but it doesn't have enough information.

Alright so, how about this:
contract;

struct Person {
    name: str[4]
}

struct Wrapper {
    name: Person,
}

abi TestContract {
    fn return_array_of_structs(param1: [Person; 2], param2: Wrapper ) -> [Person; 2];
}

impl TestContract for Contract {
    fn return_array_of_structs(param1: [Person; 2], param2: Wrapper) -> [Person; 2] {
        param1
    }
}

Gives us:
[
  {
    "type": "function",
    "inputs": [
      {
        "name": "param1",
        "type": "[struct Person; 2]",
        "components": [
          {
            "name": "name",
            "type": "struct Person",
            "components": [
              {
                "name": "name",
                "type": "str[4]",
                "components": null
              }
            ]
          }
        ]
      },
      {
        "name": "param2",
        "type": "struct Wrapper",
        "components": [
          {
            "name": "name",
            "type": "struct Person",
            "components": [
              {
                "name": "name",
                "type": "str[4]",
                "components": null
              }
            ]
          }
        ]
      }
    ],
    "name": "return_array_of_structs",
    "outputs": [
      {
        "name": "",
        "type": "[struct Person; 2]",
        "components": [
          {
            "name": "name",
            "type": "struct Person",
            "components": [
              {
                "name": "name",
                "type": "str[4]",
                "components": null
              }
            ]
          }
        ]
      }
    ]
  }
]

Yeah, I think that should work just fine!

There are other problems related to the function selector encoding. Remember the whole s(..) v.s. e(..)? well... arrays are not handled at all. Working on fixing that as well.

Hahaha glad we caught this all up now!


Gabriel findbydate command

resolves #128

Coverage decreased (-3.2%) to 74.267% when pulling a8106f09f685908ac26047af50772d11ffdb2245 on gabriel-finddate into 149b9365aa07cd74a3bc64395addeb10445cac43 on v0.5rc.


Setting The status bar colour

I have added a few codes under the themes value to adjust the colour of the status bar so it isn't in contrast with the app background as requested. I ran into errors when i used the navigationbarcolour in the code provided to us, so i had it replaced with statusbarcolour after a few more researches. Attached is an image of it in my android emulator.

screenshot of the changes shown in services

Change reflected in survey app


docs: add docs and move fatcher/docs to here

Codecov Report

Merging #144 (5a850b6) into master (b52a679) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   69.53%   69.53%
=======================================
  Files          33       33
  Lines         279      279
  Branches       55       55
=======================================
  Hits          194      194
  Misses         73       73
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b52a679...5a850b6. Read the comment docs.


Groundwork for calibration using pyFAI within xraylarch framework

Minimal changes. Adds functionality to perform x-ray detector calibration with pyFAI package in gse_mapviewer GUI. (Will be useful for addressing detector flip associated with Dioptas but not in pyFAI base package.)

Looks great.  Should we merge now, or wait?

Looks Good!


[DATA-835] Add PackageService with Create/Delete/Get/ListPackage endpoints to API

Mostly just nit suggestions for shorter gRPC method descriptions. Nice work!


Webhooks are listed only for portus admin

A regular user can create a webhook and edit it later (if he uses a deep link e.g. from the dashboard).

I'm not able to reproduce this. As a regular user, I can create/edit webhooks only if I'm an owner, and I can view webhooks (including the "Show webhooks") even if I'm a viewer.
Could you tell me a combination in which you can reproduce this ?

Meanwhile I found out, that I can see the hooks on Namespaces I'm a member of (in each of the thre roles) but I cannot see the hooks in my personal namespace. I made my space public before I did the webhook tests.

Meanwhile I found out, that I can see the hooks on Namespaces I'm a member of (in each of the thre roles)

Yeah, that is expected behavior.

but I cannot see the hooks in my personal namespace. I made my space public before I did the webhook tests.

Just tried that and I cannot reproduce it. Could you give more details ?

My collegue did the following:

access portus as a new (LDAP) user
select namespace tab
created a new webhook via "show webhooks" -> "Create new webhook"
go to namespaces again and find the webhook listed there (as number "1" wir the link to the webhooks page)
Click the link and find no hook listed (unexpected, seeing one webhook is expected)

However it gets further:
6. Add another member as viewer into your personal namespace
7. This member can see the webhook under the same URL (.../namespaces/12/webhooks) under which the owner cannot see it!

Now I was able to reproduce this! Thanks for the patience :sweat_smile:

Moreover, adding to this issue, this issue can only be reproduced for personal namespaces. That was probably the part that I was missing before being able to reproduce this bug :grin:

@holgerreif implemented and merged. Does this help with your issue ?


feat: add certification info to table selector

SUMMARY
The current table selector only gets table names from the database engine itself, and leaves out any additional metadata a user may have provided to a physical dataset. This merges the tables list returned from the database with any extra metadata from the datasets so we can display certification status in table selectors throughout the product
AFTER SCREENSHOTS

TEST PLAN

View tables in the selector with certification status and see the icon + tooltip
View tables in the selector without certification and see no icon
See the certification icon after a table is selected

ADDITIONAL INFORMATION

[x] Has associated issue: https://github.com/apache/incubator-superset/issues/10591
[x] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

to: @ktmud @graceguo-supercat @bkyryliuk

Codecov Report

Merging #11785 (75bc949) into master (db73869) will decrease coverage by 12.78%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master   #11785       +/-   ##
===========================================
- Coverage   67.20%   54.41%   -12.79%
===========================================
  Files         903      411      -492
  Lines       43719    14528    -29191
  Branches     4199     3730      -469
===========================================
- Hits        29380     7906    -21474
+ Misses      14235     6622     -7613
+ Partials      104        0      -104

Flag
Coverage Δ

cypress
54.41% <0.00%> (-0.62%)
:arrow_down:

javascript
?

python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ontend/src/components/CertifiedIconWithTooltip.tsx
0.00% <0.00%> (-66.67%)
:arrow_down:

superset-frontend/src/components/TableSelector.tsx
35.77% <0.00%> (-46.53%)
:arrow_down:

...uperset-frontend/src/dashboard/util/dnd-reorder.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...rset-frontend/src/dashboard/util/getEmptyLayout.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...dashboard/components/resizable/ResizableHandle.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/dashboard/util/getFilterScopeFromNodesTree.js
0.00% <0.00%> (-93.48%)
:arrow_down:

...src/dashboard/components/gridComponents/Header.jsx
10.52% <0.00%> (-86.85%)
:arrow_down:

...rc/dashboard/components/gridComponents/Divider.jsx
13.33% <0.00%> (-86.67%)
:arrow_down:

...ontend/src/dashboard/util/getDashboardFilterKey.ts
14.28% <0.00%> (-85.72%)
:arrow_down:

...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx
14.70% <0.00%> (-82.97%)
:arrow_down:

... and 747 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db73869...75bc949. Read the comment docs.


Show the copyright dot only if there is a copyright

Also use · instead of a non-ascii character in the code.

Can you rebase?


Materila UI: Customisation Theme. Impacts Post Job and Tasks CSS

[x] Change Date time format to UK (set locale to UK)
[x] Change colour on date picker to Bildt colour
[x] Removing padding from bottom of slider div
[x] Upload button opens file picker
[ ] Add badges to tasks page

Alot of this can be done by adding a material UI theme to our file and working out how to pass it in > http://www.material-ui.com/#/customization/themes

This badge is proving more difficult that I thougt.... LOL

It's an enhancement, and looks good with out. Leave it if it's hard to make it look good!


fancy markdown equation updates, attempt #2

Updated equations to be in markdown.  Attempt #2 merge request (i'm still learning).

I don't know how to update this pull request code, to the latest and greatest readme code with comments incorporated.  So, going to close this pull request and open a new one I guess.

I don't know how to update this pull request code, to the latest and greatest readme code with comments incorporated. So, going to close this pull request and open a new one I guess.


Mitigate against a late CompleteMovement retry which is a Bad Thing

This may resolve a large number of "login-status-is-completely-screwed" cases, as well as Mantis #3287.  This CompleteMovement request is handled with PacketHandlingDisposition.HandleSynchronized however it has an async section at the end, and no protection from queuing up the duplicate request for serial processing once the first call is complete. We're tracking AgentInRegion status here so just avoid resetting it at the start, and instead, use it to recognize the duplicate.

I've done the practical run-time tests as well now, with breakpoints, delays etc. and confirmed it is coming in as None and should not be anything but, unless it's a (previously destructive) redundant duplicate call already processed (or still being finished in the async part).
Thanks for the quick review.


Hello, I encountered a problem with UI debugging or description during the development process

Hello, I encountered a problem with UI debugging or description during the development process, but I didn't find the corresponding description. I don't know if there is a solution description for the iOS APP?

Could you elaborate on what you tried to achieve? the debugging should be similar to debugging a normal UICollectionView


Tags going out of page

Description:
On creation of multiple tags in the publisher console of APIM 2.2.0, the tags are going out of the layout.
In the Publisher's overview tab of the relevant API tag field going out of the page.
Suggested Labels:

Suggested Assignees:

Affected Product Version:
AM-2.2.0
OS, DB, other environment details and versions:
Steps to reproduce:
Create an API with quite a number of tags.
Related Issues:

This is fixed.
Fixed version : 3.0.0