IMPROVEMENT - Change output firmware file name

@LulinPollux
I propose you to change the default scheme for firmware file saving
Currently ex. for Samsung S10 Plus - SM-G975F (ITV) the info about firmware are
SamFirm v1.3.0
Checking firmware for SM-G975F/ITV/G975FXXS3ASJG/G975FOXM3ASJD/G975FXXS3ASJA/G975FXXS3ASJG
Model: SM-G975F
Version: G975FXXS3ASJG/G975FOXM3ASJD/G975FXXS3ASJA/G975FXXS3ASJG
OS: Pie(Android 9)
Filename: SM-G975F_1_20191028103127_vseyqod81a_fac.zip.enc4
Size:<PHONE_NUMBER> bytes
LogicValue: nx5habv1lq8u7e0n
and the output file name is
SM-G975F_1_20191028103127_vseyqod81a_fac.zip.enc4
My proposal is to chnage it to a scheme like
Samsung_DeviceName_CountryCode_Date(YYYY.MM.DD)_IDComponents
Ex.
Samsung_SM-G975F_ITV_20191028_975FXXS3ASJG-G975FOXM3ASJD-G975FXXS3ASJA-G975FXXS3ASJG.zip
What do you think about it?
In this way is clear in teh file the info about
Device Name
Country Code
Release Date
Components version
Thanks.

Hello.
Thank you for giving me the improvement.
I will update the program as you proposed.
Ex:
SM-G965N_KOO_20191021_G965NKSU2CSJ1-G965NOKR2CSJ1-G965NKOU2CSI1-G965NKSU2CSJ1.zip
Thanks.

I updated the program to version 1.4.0.
https://github.com/LulinPollux/SamFirm-continued/releases

@LulinPollux
Thanks for teh update.
After the use I believe that in teh output file name could be better to have as main info after the model name the firmware reelase date (and then after Country code).
SM-G965N_20191021_KOO_G965NKSU2CSJ1-G965NOKR2CSJ1-G965NKOU2CSI1-G965NKSU2CSJ1.zip
What do you think about it?

I think it seems to be better too.
I updated the program to version 1.4.1.

Thank for new version 1.4.1.
@LulinPollux
Please consder to improve it (when you can - is not necessary now just for this) as
SM-G965N_2019.10.21_KOO_G965NKSU2CSJ1-G965NOKR2CSJ1-G965NKOU2CSI1-G965NKSU2CSJ1.zip
Change Releaase date in file name from YYYYMMDD to YYYY..MM.DD
What do you think about it?

I don't recommend that.
Because if there is a dot in the file name, there can be problems that can be misrecognize as an extension.
So most of them use YYYYMMDD format a lot.

@LulinPollux
Right. Thanks.


Formatting corrections to RSS feed generation

Reference: https://support.google.com/news/publisher-center/answer/9545420?hl=en and https://validator.w3.org/feed/
I had to strip the query parameters off images as they would cause the validation to fail (namely q=70)
ALL PUBLISHED CONTENT:

WEBSITE SCHEDULED CONTENT:

 Get RSS Feed set up for Google Publisher Center and Google News for all Brand Sites

@Shinsina why do query params need to be stripped from the images?

@zarathustra323 The RSS feed validator I am using (per Google Publisher Center recommendation seems to catch part of the query params as invalid citing this error which frankly doesn't really say anything other than "out of spec" https://validator.w3.org/feed/docs/error/SAXError.html


Is it a bug? if more than two arguments in a function of the .thrift file, the codes generated will be lack of commas.

@fireapproval

some things also wrong happens in service dictionary which generated by cwgo server --type RPC  , the all unit test file lack symbol , in parameter of method

Thanks for the feedback, we'll fix it as soon as possible.

The problem should be that the case of multiple parameters is not handled correctly

cc @chaoranz758

Can you provide the content of the thrift file and the commands to be executed when error occurs？ @lilhammer111


Substreams Sink Postgres tutorial

We had content in the initial Sink documentation about Substeams Sink Databases, we should bring it back. It should give general database consumptions guidelines (the expected output format is the same between Postgres and mongodb for example). Most of the concepts are the same.
The tutorial should give clear information on how one can take a Substreams and transform it so it's consumable by Postgres. This is a more advanced tutorial, so we give quick overview of the commands with quick explanation. We give instructions from zero to hero. There should be validation instructions at the end (some SQL queries mainly) to ensure everything is working as expected.
Here a first draft outline:

Overview (discuss about transformation required to fit expected model, that the sink consumes this and populate a database.)
Prepare your Substreams (how to respect database changes format, examples and explanations, how to check https://github.com/streamingfast/substreams-eth-block-meta for examples of the format).
Dependencies requires (Docker compose to launch a local Postgres instance, schema population)
Run and configure substreams-sink-postgres (launching, flags, output, inspect, results)

Discussion about where Substreams cursor is saved (in a table)
Discussion about batching of writes (each 1000 blocks when not live, still need to be determined when we will be live)

Conclusion

The final outline and approach used for the files-sink tutorial should be followed for this documentation. Refer to the following link to find content and the process for creating that page/doc.
https://github.com/streamingfast/substreams/pull/116

Initial content started and draft created. New branch made for PR available at: https://github.com/streamingfast/substreams/pull/147


Issue With Transparent Sync Dependencies

In this project, I have two configs - one with transparent sync enabled and one without.  The one with transparent sync contains all of my templates.  The other one has some items that use those templates.  Whenever I try to sync the second config through the Unicorn control panel (this is an initial sync - the items do not yet exist in my database), it fails with an error that the template doesn't exist.  Although it does (it's in the transparent sync config and I can see a template with that ID in Sitecore).
Here's a snippet of the log from the control panel:
Once Configuration is being synced.
[A] master:/sitecore/content/XXX Website (6f40b18c-2f55-4ab5-8043-027987c995d5)
[A] master:/sitecore/content/XXX Website/home (37ea87c4-345c-478c-9aa7-730a6b91d0ec)
[A] master:/sitecore/content/XXX Website/shared-content (82246e6a-7c5d-4f30-b7f4-c7cad4ff0e12)
[A] master:/sitecore/content/XXX Website/site-settings (af91e57f-aa12-4efd-a42f-5084fe78ad59)

... this continues for a lot of items before the error occurs ...

281 errors occurred during deserialization. Earlier log messages for items below should be ignored; an error occurred that was retried and failed to correct.
master:/sitecore/content/XXX Website (6f40b18c-2f55-4ab5-8043-027987c995d5)
C:\Projects\XXX\src\items\Once\XXX Base Content\Content\XXX Website.yml
> DeserializationException: Template {9D585E79-FD65-4982-9BA6-DE8B6322E14A} for item /sitecore/content/XXX Website not found
master:/sitecore/content/XXX Website/home (37ea87c4-345c-478c-9aa7-730a6b91d0ec)
C:\Projects\XXX\src\items\Once\XXX Base Content\Content\XXX Website\home.yml
> ParentItemNotFoundException: Exception of type 'Sitecore.Data.Serialization.Exceptions.ParentItemNotFoundException' was thrown.

Template {9D585E79-FD65-4982-9BA6-DE8B6322E14A} does exist - it's part of the transparent sync config, and I can see it in Sitecore.
I have not been able to reproduce this with a super simple clean install, so it may be something I have configured incorrectly on this project or may be something special about one of the hundreds of items I'm trying to sync.  I will keep poking at a simple reproduction and add more info if I'm able to make it happen consistently outside of this one project.

OMG.

I thought this issue seemed really familiar as one that I'd fixed. Sure enough, I had. But I hadn't got the config change to activate the fix into the 3.0.0 config. #fail
See the commit diff, you won't need to upgrade to get this fixed as the code is in 3.0.0 just not activated.

Thanks, @kamsar!  I just tested this with my original setup and that one config change definitely fixed the issue.


[Patterns] Component Generation

Description
Component generation is failing.
Expected Behavior
Components should dynamically generate and register with Meshery Server
Screenshots/Logs
time="2021-09-29T17:48:14Z" level=info msg="Listing Operations" app=traefik-mesh-adaptor
time="2021-09-29T17:48:14Z" level=info msg="Creating instance" app=traefik-mesh-adaptor
time="2021-09-29T21:10:46Z" level=info msg="Adaptor Listening at port: 10006" app=traefik-mesh-adaptor
time="2021-09-29T21:10:46Z" level=info msg="lstat /.meshery/templates/oam/traits: no such file or directory" app=traefik-mesh-adaptor
time="2021-09-29T21:10:48Z" level=info msg="Registering latest workload components for version v1.3.2" app=traefik-mesh-adaptor
Looking for kubeopenapi-jsonschema in  /root/.meshery/bin
time="2021-09-29T21:10:49Z" level=info msg="exit status 1" app=traefik-mesh-adaptor
time="2021-09-29T21:11:24Z" level=info msg="Creating instance" app=traefik-mesh-adaptor
time="2021-09-29T21:11:24Z" level=info msg="Listing Operations" app=traefik-mesh-adaptor

Environment:

Meshery Version: v0.5.62
Adapter Version: v0.5.10

Contributor Resources
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

@leecalcote  check and confirm if this still fails after my most recent PR. It works as expected on my system

@leecalcote  After the latest PR:

i can see only v1.3.2 on mine

i can see only v1.3.2 on mine

My pr is not merged.
Are you doing gh checkout on this PR?

Oh no sorry, my bad, I thought it was merged.

This issue was solved


flink on alluxio execute wordcount show Failed to cache(Permission denied)

Alluxio Version:
2.0.1
Describe the bug
flink on alluxio , execute command:
fink run -m yarn-cluster example/batch/wordcount.jar --input alluxio://{host-name}/test/testFile
--output alluxio://{host-name}/test/outFile
err:
caused by : java .io.IOException: Failed to cache : {alluxio.worker.tieredstore.level0.dirs.path}/alluxioworker/.tmp_blocks/310/3423542352-3f3f3f1324343 (Permission denied)
To Reproduce
fink execute wordcount job
Expected behavior
fink can write data to alluxio,but now fink only can read data from alluxio
Urgency
flink can not work
Additional context

we have execute chmod 777 {alluxio.worker.tieredstore.level0.dirs.path}

we execute fink run -m yarn-cluster example/batch/wordcount.jar --input alluxio://{host-name}/test/testFile is running well

someone help me?

@jinhang it will depend upon how your yarn cluster is configured and which nodes your job is scheduled on. Are you in a single node or multi-node setup? have you executed chmod 777 <alluxio.worker.tieredstore.level0.dirs.path> on every single worker?

@jinhang it will depend upon how your yarn cluster is configured and which nodes your job is scheduled on. Are you in a single node or multi-node setup? have you executed chmod 777 <alluxio.worker.tieredstore.level0.dirs.path> on every single worker?

yes, I have executed chmod 777 for <alluxio.worker.tieredstore.level0.dirs.path>

But have you done it on every node in the cluster?
Additionally, you can alleviate this by either disabling short-circuit writes (alluxio.user.short.circuit.enabled=false) or by enabling domain sockets. Following either of those two suggestions should alleviate the error you're seeing, but might cause a slight performance hit.
Otherwise, I'll need more information about your cluster configuration. If you have multiple nodes in your cluster, you'll need to chmod the worker's data folder on every node, for all configured Alluxio worker tiers.

Will close it for now, feel free to reopen it and contact us if this is still valid


esophagus versus oesophagus

Related to #2691
Any MP term that contains the word esophagus/esophageal in it should have a synonym that replaces esophagus/esophageal with oesophagus/oesophageal.
esophagus hypoplasia
esophagus stenosis
esophagus hyperplasia
esophagus fibrosis
abnormal esophagus morphology
dilated esophagus
enlarged esophagus
small esophagus
abnormal esophagus development
esophageal inflammation (inflammation of esophagus)
absent esophagus
abnormal esophagus topology

Done!


Variables are lost when variables window closed

I added variables by toggling the variables window and then adding them.  When I close the variables window the variables are lost.
Is there a way to persist this setting?  Or perhaps there is an external .json file I need to create to hold the variables?

This isn't supported at the moment. A PR would be great :)

I'd also like a variable file, I'm importing existing content so I'd need it to store the values, typing them by hand isn't reliable in my case, but a good option for scripting

The upcoming 2.0.1 release no longer clears the variables editor when closing it.
There are still some open questions:

If persistence is involved, how is cleanup and validation handled?
If variable files should be supported, how are they linked to the queries in a way that is intuitive and supported by the editing UI?
What if there are multiple queries in the same graphql file?
Would it make sense to type the variables using the GraphQL language, but then have JSON conversion actions? The existing GraphQL completion and error highlighter could then be applied to the variables editor.

The way I see it for my use case would be as follow:

Have a "template" without values (use variable references) in a file
Have an "implementation" that somehow references a template and define the values to be used against that template (could handle "a set/array" of variables, to run the template multiple times through the same "implementation" file, nice-to-have)
Make the "implementation" file executable by the plugin

This way, it would be very customisable, the template could be generated dynamically or manually, same goes for the implementation. It could be tracked by git, and could be used to manage utility scripts such as importing predefined content.
I would typically use this for migrating data, basically write the templates by hand and the iterate over existing data to generate the "implementation" files and be able to run them again by hand (several at once? nice-to-have)
I would also use it to write my own utility suite of scripts to perform redundant actions much faster.

I would also be super happy to store my editor variables so I can test quickly my queries after I rest the IDE

Is it possible to store variables as json file and associate them to query?

As a possible solution, maybe it is possible to store variables as json file and associate them to query?

I was about to open up an issue with this suggestion. It would be nice to keep variables in a file for posterity reasoning. Right now we're keeping in variables in separate json file and a contributor has to manually move them to the variable window to test the queries :|
as @Starkom pointed out the variables are already in /GraphQL.variables.json file? I can't find it anywhere and creating one in root directory (next to config) doesn't make a difference.

Love this extension. Really super powerful, I use it a lot. Thanks for doing this!
Seeing that the readme for v4 mentions variables, I was digging deeper into this and from what I can tell now variables are supported by a project root 'graphql.variables.json' file?
When selecting the yellow V from the GraphQL toolbar nothing happens, but reading the source code I understood this is the expected file name (?)
Defining key-value pairs in this file however does not have any effect - does it need to be included or activated somehow?
WebStorm 2023.1, Build #WS-231.8109.174.
Runtime version: 17.0.6+10-b829.5 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS ventura 13.1

@olof-nord Oh, looks like we have an issue with 2023.1 😮. It's expected to work like that, and it works in 2022.3, but not in 2023.1. I'll check it.
https://user-images.githubusercontent.com/10243762/233806816-82418f3e-42fa-4812-9e8e-4402353582c5.mp4

It seems the panel appears but does not expand. If you look closely, after clicking the V shows a fraction of a blinking cursor just below it, and it moves when typing on the keyboard, but you can't see what you write in. I honestly think this is a major issue, hoping for a quick fix.

Just upgraded to 4.0.1 and the variables editor is working. Thank you!

Hello, is there any chance variable persistence will be implemented in the future?
It is really frustrating to enter variables again and again from time to time.


Handle invalid payload from Taipy

Taipy refuses invalid json payload. we should catch their error and do a valid notification for user.
WebSocket disconnected due to:  parse error Error: invalid payload
    at Et.decodeString (taipy-gui-base.js:1:29186)
    at Et.add (taipy-gui-base.js:1:27972)
    at St.ondata (taipy-gui-base.js:1:39667)
    at B.emit (taipy-gui-base.js:1:5590)
    at at.onPacket (taipy-gui-base.js:1:22078)
    at B.emit (taipy-gui-base.js:1:5590)
    at websocket.onPacket (taipy-gui-base.js:1:6892)
    at websocket.onData (taipy-gui-base.js:1:6862)
    at ws.onmessage (taipy-gui-base.js:1:11334)
taipy-gui-base.js:1 WebSocket reconnected

run
velib_real_time_demo.py

to reproduce it.

It's done. (see the taipy_integration branch)
Error handler has been added.

Thanks Ghiles !


Make copy_dir() return copied pathes

This patch makes the copy_dir() function return the pathes it copied (targets, not sources).
This is needed so the fn is more useful when using it to rewrite copy functionality later.

Note that if you merge #198 and this afterwards, master does not compile anymore because #198 removed the std::path::PathBuf import, but this patch makes use of that type.
So after merging #198, this clearly needs a rebase.

I am rebasing this PR :)


Updated validations.py python script.

Updated validations.py python script.
Closes: #1
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@sathwik-2100030447


implement sdf_persist()

For use as a wrapper to the Spark Dataset persist API.
In particular, we need to make it simple to use + access the different StorageLevels, and perhaps make the 'default' storage level user configurable.

+1

This is implemented now, but we should make it easy to learn what the available storage levels are.


Feature request: Add option for arrow key behavior

vim or neovim?

[x] vim
[ ] neovim

VIM - Vi IMproved 8.1 (2018 May 18, compiled Sep 17 2018 11:18:15)
Included patches: 1-401
Compiled by somebody
Huge version without GUI.
Hello, I know there is a feature request that use arrow to navigate history.
https://github.com/Yggdroot/LeaderF/issues/213
However, it's not friendly for people who already use arrow keys to
navigate result list for a long time(and I believe it's more frequently
used). Could you please add an option for us to define the
behavior of arrow keys?
BTW, I tried to add the following line but it seems not work.
let g:Lf_CommandMap = {'': [''], '': ['']}
Thanks you
Steps to reproduce

:LeaderfFile
Use arrow key up/down to navigate result list

Actual behaviour
search history
Expected behaviour
can navigate result list

Sorry it seems github filter my g:Lf_CommandMap
let g:Lf_CommandMap = {'<Up>': ['<C-K>'], '<Down>': ['<C-J>']}


Update all Airbnb listings

with new wifi info:
SSID: InvisibleCollege (or InvisibleCollege_5G)
Pass: arcology

review check-in instructions and add instructions to download and install the August Smartlock app for your smartphone (Google Play Store or iPhone App Store).

all set


group68-PR

Hello Priyanka,
I am so sorry to disturb you but I am not sure how to change my pull request. Should I just make a new pull request?
Best,
Josua


Add support for native polls

[ ] Add Poll struct
[ ] Add sendPoll request
[ ] Add stopPoll request
[ ] Add MessageKind::Poll variant
[ ] Add Update::Poll variant

Add Update::PollAnswer variant


fix: off by one in sibling stack pop

#98  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rphmeier and the rest of your teammates on  Graphite


distutils.errors.CompileError: command 'C:\Users\86178\vs2019\VC\Tools\MSVC\14.29.30133\bin\HostX86\x64\cl.exe' failed with exit status 2

Hello, I have encountered a problem recently. This problem has been bothering me all the time. How can I solve this problem：distutils.errors.CompileError: command 'C:\Users\86178\vs2019\VC\Tools\MSVC\14.29.30133\bin\HostX86\x64\cl.exe' failed with exit status 2

Do you have any code to replicate the problem

Hello, I don't think it's the reason for the code, because this is a duplicate code given in a paper. The paper is vem, and the link is:. https://github.com/YiqinYang/VEM.I think it's the reason for some environment configurations. But I really don't know how to solve it

Where in the code is failing, what do you run? What environments?
For alot of RL work, they only work on linux and macos, generally not windows, which could do the issue but I don't know

OK, thank you very much. I run the code under Windows, which may be the reason. I will study it myself!
------------------ 原始邮件 ------------------
发件人:                                                                                "Farama-Foundation/D4RL"                                                                                @.>;
发送时间: 2022年9月18日(星期天) 下午5:41
@.>;
<EMAIL_ADDRESS>主题: Re: [Farama-Foundation/D4RL] distutils.errors.CompileError: command 'C:\Users\86178\vs2019\VC\Tools\MSVC\14.29.30133\bin\HostX86\x64\cl.exe' failed with exit status 2 (Issue #174)
Where in the code is failing, what do you run? What environments?
For alot of RL work, they only work on linux and macos, generally not windows, which could do the issue but I don't know
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Hi, have you solved the bug? I met the same problem, and I hope to get some suggestions from you! Thank you so much.


fix: template should use correct table name for user-provider-database.txt

Proposed changes
Current template of config in partial user-provider-database.txt uses inappropriate table name for usersTable var (after install this var just empty string):

Current PR fixes this by using usersTableName template var's value, which fulfilled during installation steps of @adonisjs/auth
Types of changes
What types of changes does your code introduce?

[x] Bugfix (non-breaking change which fixes an issue)

Checklist

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes

Thanks for finding these small hidden inconsistencies :)


update links

Some links won't work ("Virtual PC Guy’s blog" or "5 easy and powerful Excel features you may not know about").

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7e18760a-7e18-d71b-3d45-3be5f6b366c7
Version Independent ID: 275cab7d-5037-029b-7b3f-5d2a2f6fc107
Content: Content planning - Microsoft Style Guide
Content Source: styleguide/content-planning.md
Product: non-product-specific
GitHub Login: @pallep
Microsoft Alias: pallep

Also, links outdated in the section "Learn or increase knowledge and skills related to a product, service, technology, or business concept".

Hi,
Thanks for letting us know. We have an update planned for this article, with updated links.
If you have any suggestions--any Microsoft content that you think illustrates the guidelines in this article--we'd love to hear them!


Add IDE service focused integration tests

These tests would be a lot like our existing baseline tests where they would indicate how a specific service would act at a certain point in the document.

Duplicate of: https://github.com/aspnet/Razor/issues/1093


Update AI_Car.csv

提升正體中文翻譯品質

請根據下面wiki的方法更改翻譯文本，不能直接更改csv文檔
https://github.com/krzychu124/Cities-Skylines-Traffic-Manager-President-Edition/wiki/Localisation

All translations are automatically generated by Crowdin webapp. Sign up (free account) to be able to contribute with translation process.
Here is the link to the string you want to change: https://crowdin.com/translate/tmpe/46/en-zhtw (log in required)

Closing in favor of #599


Wedge updates for v1.38.

Expose general parameters in advanced.
Expose choice of parameter to sample (supports int, float, vec2, vec3, color3, vec4, color4) now vs only float before.
Support more than tga in file dialog.
Add in additional command line arguments to avoid having to interactively perform this:
--cameraZoom  : Amount of user zoom to apply 1.3 seems to get a close fit.
--envSampleCount  : Default is 16 but 64 is a good fidelity number.

Snapshot of new UI with sample material:

Sample result:

This change is looking nearly ready, and my two remaining concerns are with the UI for wedge rendering:

When I test the new UI on the Standard Surface Default material, the combo box for Wedge Property is so large that I can't select "specular_roughness".  One option would be to make this a string rather than a combo box, since the user can easily find the list of available properties in the Property Editor.
It's challenging to discover the option for modifying the Wedge Property, since it's on a different page from the other wedge options.  Now that you've added a Wedge Rendering Options section, should Wedge Property be there as well?

Yes. I've run into the same issue for selection and it occurs for all pop-up menus. I'll look at alternatives.
For organization,  I think it's a good idea to keep all the options in one place but the input to wedge is dynamic based on selected material so will need to rejig this a bit.

Sounds good, thanks @bernardkwok!  The simpler approach, where the wedge property is a simple string (e.g. "specular_roughness"), would also be fine for now, and wouldn't introduce dependencies between two different combo boxes.


Make content optional to avoid 500 pages

Who is this for?
Everyone
What is it doing for them?
Adding event to content lists made the page return a 500. I tweaked the content accordingly, but would love someone that's more comfortable with the events content structure to ensure it makes sense.
Related to #10051

Whoops wrong one 😅


H8-H9 documentation

Write the documentation for the H8 and H9 backend. The priority is to finish H9 before H8.

substituted by the new documentation issues


Improve generation script

Summary
This PR aims to improve the generation script by providing a more stable command to look up changed file after generating the typescript files.
In the last scheduled generation  the script was unable to recognize that their were more then one changed files and did not created a PR for the generated files.
Testing:

Pull this repo
Make a change in src/connectors/mod.ts
run the following sh command [[ $(git ls-files --other --modified --exclude-standard) == "src/connectors/mod.ts" ]] && { echo "No real changes. Do not commit."; exit 1; } -- the output should "No real changes. Do not commit."
Make a change in another file in the repo
run the following sh command [[ $(git ls-files --other --modified --exclude-standard) == "src/connectors/mod.ts" ]] && { echo "No real changes. Do not commit."; exit 1; } -- their should be no output

This generation GitHub action was triggered from this branch and shows that the changes work.
Requirements

[x] I've read and understood the
Contributing Guidelines
and have done my best effort to follow them.
[x] I've read and agree to the
Code of Conduct.

Merging this since it is a small change to the generation script and is blocking the release


[RELEASE] Release 2.10.5

Is it possible to get patch release of the client for the change in #1034, please? 🙏

I cut the next auto-release instead of cherry picking this change to 2.10.x


[Custom] lazy load getImageAsset

When I call getImageAsset it takes 3 minutes to get a result from my device.
I have lots of images there...
How can I make it work faster?
Some kind of lazy loading the assets or a function that just gets the album name without the images.
And also when i click on the album I want to get the images by chunks not awate to get all of them.
How can I do that ?
Thank you!

I don't know why you encounter such a problem.
Because the API for reading photos is provided by the android/iOS sdk, and
my device iOS/android has thousands of pictures, and the loading speed will not exceed 3 seconds.

Hi @CaiJingLong
See this video and look how long it takes to get the images (about 30 seconds)

That is why I think it will be a good idea to get the images by chunks.
I got this idea from the cordova-plugin-photo-library.
See there explanation:
https://github.com/terikon/cordova-plugin-photo-library#chunked-output
What do you think?

This problem has always existed, and many people have given feedback, but I don't know how to fix it.
Unless it can be reproduced on my device.

It may take a long time. I may need to completely refactor the underlying code to see if paging can be used to solve this problem.

Hi,
It takes ~20 seconds for me also.
Would appreciate improving performance, it's a great library.

#94 can resolve the problem.
I will close this issue after uploading the next version.

Update version to 0.4.1.


Replace Mapbox Tiles by a different Tile Layer Provider (e.g. Carto)

As we have currently issues with the Mapbox tiles, I would suggest the following:
https://leaflet-extras.github.io/leaflet-providers/preview/ shows some alternative background layer provider (not all listed are still working resp. free accessible)
Personally I prefer the CartoDB_Voyager style (code is shown when selecting on https://leaflet-extras.github.io/leaflet-providers/preview/):
var CartoDB_Voyager = L.tileLayer('https://{s}.basemaps.cartocdn.com/rastertiles/voyager/{z}/{x}/{y}{r}.png', {
	attribution: '© OpenStreetMap contributors © CARTO',
	subdomains: 'abcd',
	maxZoom: 19
});

Nice, do you want to pick this up?

Sure, will do so in the evening, maybe selecting a style that fits to color style of our hole site.

Resoled in #212

Resoled in #212


[WIP] Extension Mechanism Implementation

This is an initial POC of the extension mechanism. Goals are to provide a public api of a pluggy interface for managing stages and subcommands. With this work the goal is that a majority of what is Nebari becomes a collection of extensions.
Key interfaces to review:

nebari.hookspecs.NebariStage this is base class for all Stages
_nebari.stages.base.NebariTerraformStage is a subclass on NebariStage which implements convenience features to allow terraform stages to be more concice.

TODO: nebari.hookspecs.Subcommand interface to be created.
As of writing the plugin work is not fully connected but the stages are. The idea is that for deploy, render, destroy etc.
import contextlib

stage_outputs = {}
stages = get stages ()

with ExitStack() as stack:
       for stage in stages:
               stack.enter_context(stage.deploy(stage_outputs))

Similar code for render and deploy. Notice how nebari can finally be oblivious to what is happening in the stages! (We'll see if this works out as well as planned).

From discussion with @iameskild we need significant control over how and when certain stages are chosen. For example here are some use cases that need to be considered:

How does a user replace a given stage(s)? (What happens when 3+ plugin hooks all say they want to replace the stage)
How at runtime do we allow certain stages to be excluded from the run?

A proposal (from me) is to use priority/name.

pytest uses tags/markers (maybe a good idea?)

@iameskild is suggesting a plugin hook to be added which will modify the ordering of the hooks
There should be a pre/post for check, maybe nice to have to render/deploy/destroy.
def pre_check(stage_name: str):
      .... # run this before stage

There should be a way to have a schema for that given stage as input and output.
Schemas everywhere. @iameskild mentioned that the NebariTerraformStage should have validation on internal methods e.g. input_vars.
Some areas next steps:

schema fixing that up
subcommands
wrapper implementation for nebari

Subcommand build in to read arbirarry python module nebari --import-module asd.qwer.mystage render should be possible

@costrouc here is a basic POC of what an outer priority manager plugin object might do. If you change the priority level of either MyStage1 relative to YourStage1, the order will switch.
From here we can implement more complex logic that handles replacing plugins for the same stage, resolves conflicts if the priority level is the same, etc.

Thanks @iameskild checkout https://github.com/nebari-dev/nebari/blob/extension-mechanism/src/_nebari/stages/base.py#L89-L106 for the basic implementation in here. I don't have plans to make any additions to this function so I definitely think we should add some of the capabilities that you mentioned with being able to filter stages etc.
I've done the initial work (still somewhat broken) of moving all commands to a nebari_subcommand hookspec.
Also the stages seem to sorta work. I've been able to successfully run the render and validate command.
Also spent a lot of time working on the schema (still needs a lot more work) and removing all config['...'].get(...) and replacing with config.value.key since with schema validation we have guarantees on the schema.

Further work was able to get about midway through a local deployment (to kubernetes ingress).

As I've been working on the schema (the main schema and the ones specific to the InputVars), it got me thinking that it might make more logical sense to stages (plugins) that are specific to cloud providers as well.
At the moment, the infrastructure stage is one stage that passes different input_vars based on the cloud provider. When I see this kind of conditional, it makes me think that these need to be broken out into separate stages, one per cloud provider.
Another example is the cluster_autoscaler which is specific to AWS but is being created within a stage that also creates Traefik resources, nvidia installers and container registries, it might make more sense to have each of these be a separate plugin.
Although more work upfront, I see the benefits in the future when others want to (natively) support new cloud providers. Another possible downside to this approach is that the number of current plugins will likely grow quite quickly which might reduce the speed with which we can deploy the whole cluster (given the overhead of each terraform init, terraform plan required for each plugin. That said, I see the benefits being that each stage (plugin) only performs one specific job and can be more easily swapped out should we need or want to in the future.
The tricky part of this entire extension-mechanism work seems to be how we handle prioritizing and swapping out plugins.
cc @costrouc

At the moment, the infrastructure stage is one stage that passes different input_vars based on the cloud provider. When I see this kind of conditional, it makes me think that these need to be broken out into separate stages, one per cloud provider.

Another example is the cluster_autoscaler which is specific to AWS but is being created within a stage that also creates Traefik resources, nvidia installers and container registries, it might make more sense to have each of these be a separate plugin.

@iameskild I think these are great ideas. This work will make "stages" much cheaper to create. I think it absolutely makes sense. The questions I have here is about stages and how they get selected. In the case you are suggesting here we would have certain stages that only apply when a certain config value is set. How do we want to expose that?

More thoughts on the schema.
If and when we break out the Kubernetes Services (ie. Argo-Workflows, conda-store, etc.) and cloud providers into their own plugins, the main schema will need to be modified (namely removing their sections from the main schema). We might want to make it so the main schema is extendible based on the plugins that are installed. This would require a dynamic schema; pydantic has just the tool for this, create_model.
This gist gives a taste for how this might be accomplished. In the long run this would reduce the size and scope of the main schema to only those components that are used throughout the deployment (name, domain, etc.) and everything else is the responsibility of the plugin to managed.
The InputVars schema we've been including would ultimately become a new section in the config itself.
cc @costrouc

More thoughts on the schema.

If and when we break out the Kubernetes Services (ie. Argo-Workflows, conda-store, etc.) and cloud providers into their own plugins, the main schema will need to be modified (namely removing their sections from the main schema). We might want to make it so the main schema is extendible based on the plugins that are installed. This would require a dynamic schema; pydantic has just the tool for this, create_model.

Thank you for thinking about this! YES this is something that needs to be addressed. I think it is important from the start that we get this part right. I would really appreciate you doing some more research about that.
Thoughts that I had each stage would have a "reserved" part of the schema
stages:
   mystage: { } # arbitrary dict for given stage name. Stage could pass it's own schema

I'm struggling on thinking how the stages could collaborate on what the schema would look like.

And mystage extension would claim mystage and othervalue as keys which that stage manages. At runtime we do a check that no stages collide on keys that they manage. This approach would match more of what we have curently. So sort of a merge at the root level.

wouldn't it make more sense to namespace the keys by the stage name so they can never clash.

Backwards compatibility isn't a huge issue for me as long as we have a clean messaging and upgrade path. Our install base is small enough to be manageable and we have relationships with folks using it.

@dharhas I'm fine with us making this move. I think this schema per stage will need to happen in another PR then. I'd like to make this PR focus on not changing anything and locking down the current schema. We can create a PR which makes this move and I think it will be extremely beneficial.
As of now I have this PR working on all clouds. So now I'd say this PR needs cleanup and checking the features are preserved.

I've been thinking quite a bit about this after the initial presentation in one of our syncs. My biggest concern was that the way the extension mechanism is too flexible. While this is usually a good thing for power users, on the flip side it easily gets detrimental for regular ones. Since nebari is about making stuff easy, I would err on the side of the regular users.
I would propose something that hopefully also covers all use cases, but is a little simpler:

Each stage as we currently have it, has a fixed input and output scheme. It can be replaced, by at most one extension that abides by the input and output contracts. If multiple extensions try to replace the same stage, we refuse to deploy and error out.
Between each stage as well as before the first and after the last, we have some hooks. They will be called with the output of the previous stage (the raw nebari config for the very first) and can (maybe?) modify the values, but not the structure. In contrast to the stage replacing hooks, we can have an unlimited amount of these, i.e. multiple extensions can hook into the same thing.

As it stands, this will then limit nebari to k8s. However, we don't need the full flexibility proposed by this PR to remove this limit again: since the number of deployment targets is fairly low (right now I can think of k8s, HPC, and local), we could just build sets of fixed stages for all the targets that we want to support and within them go with the scheme I proposed above.

This took a long time to properly rebase since I had to incorporate #1832 and #1773. The only errors that exist are the ones that we see in the develop branch currently https://github.com/nebari-dev/nebari/actions/runs/5742626558/job/15565133390

The final (hopefully) rebase has been completed.
The Digital Ocean provider tests are failing and this is expected given that they recently deprecated kubernetes version 1.24.
The kubernetes tests is failing and when I deployed Nebari to AWS, everything worked except for the DNS auto-provision.

@aktech I'm going to merge this PR but it will require some work to get it back to running the test_deployment code you wrote.


Feature: Enable / Disable Shadow DOM via  Debug Component

Jira
N/A
Summary
Adds a new <bolt-shadow-toggle> helper component (based off of the upcoming <bolt-radio-switch>) that allows devs to globally enable / disable Shadow DOM rendering while developing in Bolt.
No more <form> tag workarounds!

Details
Adds a new feature flag to @bolt/core to carefully allow the default Shadow DOM feature detection check results to be overwritten while debugging / testing.
Uses Modal to tuck away the config options while not in use.
How to test
Try the new helper component out!

Closing in lieu of #1646 1646


proposal: syscall: reconsider entire package

So far syscall package holds tons of constants, a bit abstracted and raw functions that
wrap syscalls especially for networking stuff.

E.g.,
Constants assigned by IANA (IPPROTO, IFType,), other standard bodies (could be moved
into each specific package)
Set/Getsockopt for Windows
Set/GetsockoptInt,Facilites for Unix variants
Routing sockets, constants for BSD variants
Netlink sockets, constants for Linux

We can reconsider the package shape even under the Go 1 contract.
(and make things easy for bridging btw Go1 and Go2.)

For Go 2, we should decide whether to simply remove the syscall package from the standard library, and direct people to use golang.org/x/sys instead.  We could have a slightly smaller version of the current syscall package in internal/syscall for use by runtime, os, net, and whatever other standard library packages need syscall support.
Our vote is to do this: to remove syscall entirely from Go 2, and use an automated rewriter to change all current uses to use golang.org/x/sys instead.

Upon further consideration, there are clear uses for the syscall package.  Simply removing it isn't feasible.


Resolves #723 by completing convertTablespoonsToTeaspons method and adding randomInRange skeleton & tests

Closes #723

[x] Running yarn lint does not trigger any linter errors
[x] The test of the method you have fixed is passing
[x] You have written a new skeleton method for someone else to work on!
[x] You have written tests to accompany your skeleton method

New issue created. Thanks!


encountered memory overflow

I am planning to integrate a new project into the library, but during my testing phase on my personal account, I've been consistently facing memory overflow errors.
Here is a brief timeline of what happened:
The last successful build was logged as follows (insert the log here).
When I added two templates, the memory consumption spiked dramatically. Here is the first failure log： actions log
I then increased the allocated memory to 4GB, but the issue persisted. This is the second failure log ：actions log.
Finally, I bumped up the memory allocation to 8GB, yet the memory overflow occurred again. Here is the most recent failure log actions log
Thank you for your attention and hard work maintaining this valuable resource.

Thank you so much, let me check your PR!


Errors after updating to TypeScript 2.7.1

Every usage of vuex-class causes the error Property 'xxx' has no initializer and is not definitely assigned in the constructor. after updating TypeScript from 2.6.2 to 2.7.1.

Please read TypeScript 2.7 features. You need definite assignment assertions since decorated properties does not have initializers.
https://blogs.msdn.microsoft.com/typescript/2018/01/31/announcing-typescript-2-7/#stricter-class-property-checks

Thanks @ktsn! While I could fix this issue new ones arrived in combination with an already known bug in vue-test-utils. https://github.com/vuejs/vue-test-utils/issues/73


doc: adding Documentation for Cairo Error Types

Description
The current codebase defines several error types within Cairo, but lacks comprehensive documentation for these error types. Adding detailed documentation for each error type will improve the clarity and understanding of potential issues within the codebase.
https://github.com/keep-starknet-strange/cairo-zig/blob/main/src/vm/error.zig
Requested Enhancement
Enhance the codebase by providing comprehensive documentation for each major error type, and include detailed documentation for each specific error within every error type.
Expected Outcome
Developers and contributors will have a clearer understanding of potential errors, leading to more effective debugging and maintenance.

Hi, I'd like to work on this.

Hi, I'd like to work on this.

@ndcroos Assigned


[HOLOCENE] L1BlockInfoTx::Holocene derivation

Overview

[!NOTE]
Depends on #595

As a part of holocene, the L1BlockInfoTx has a new variant. L2ChainProvider::system_config_by_number relies on OpBlock::to_system_config to fill out the SystemConfig, and we will need to add the new variant into the match here.

Pending: https://github.com/ethereum-optimism/specs/pull/404

cancelled


Generate PDFs of trainings with only hands-on boxes

Can we generate a PDF with only the hands-on steps - tools and parameters?

Use case?

If the handouts are to keep as a reference after the course, then without the explanations they are not very useful. If they are to be used during the course, I think they can be more of a distraction (trainees will just do what's on the handout without listening and/or understanding).

Afaik the use-cases we talked about were:

have a simply cheat-sheet for instructors if you don't have two monitors (one Galaxy, one training-material)
have a simple summary for people running around and helping - they very often needs to check parameters and such

generating those PDFs regularly would be expensive (since it requires chrome-headless), so I think this is not a priority currently, since it's just wasting CPU time to constantly rebuild them, if no one is using them regularly.
We could merge this https://github.com/galaxyproject/training-material/compare/onlyhandson?expand=1  and have a URL parameter if you like?


Appearance of scrollbar in Firefox 52

Hi, there.
Thank you for awesome theme. I use this theme on my blog.
I found the issue in Firefox v52.
the theme sets the -moz-scrollbars-none to overflow-y of .main-container.
It seems that the value is not available to overflow-y. it ordinary is overflow.
However , you can use -moz-hidden-unscrollable instead of it.
Cheers.

Hello asciian,
Thanks for your feedback and I’ll take a look into the issue shortly.
Cheers

Hi asciian,
I found that the overflow-x and overflow-y properties of .main-container takes no effect after several tests. So I merged these properties into a single overflow: hidden and I think it would work well.
Related commit: ba295b4046bcb5d7abb423cad674134b1732987a
Any further comments are welcomed.
Thanks again for your feedback and have a nice day.


[WIP] Fix clone forked repository

fix #187

ci build

Pull Request Test Coverage Report for Build 1027

10 of 10 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 91.481%

Totals

Change from base Build 1025:
-0.01%

Covered Lines:
1106

Relevant Lines:
1209

💛  - Coveralls


UI UX DESIGN

ui ux is needed

I want to design the sign up page using Figma , Assign me @duraanali

@hananabshir23 , We're using duolingo.com website UI for now, someone already created the sign up page but if you want to create ui for other pages, please create an issue for it and I will assign it to you.


cni.dev does not have any document for vlan plugin

https://www.cni.dev/plugins/ does not have any section about vlan plugin https://github.com/containernetworking/plugins/tree/master/plugins/main/vlan
This might be because vlan pluign does not have any README file since it is created...

This might be because vlan pluign does not have any README file since it is created...

That's very likely -- when I moved the docs across to the website, I only moved README files, I didn't create any new pages.


Storage metrics for log report

What was wrong?
Progress on #530
Want to report on storage usage
Bonus issue: Bespoke calculation of metrics for log couldn't be reused for online metrics report
How was it fixed?
Changes are small, but there are several of them. I recommend reviewing commit-by-commit.

Always track the database statistics, whether or not we report them online (since we always report them to log now)
Combine all storage metrics into a single loggable string
Internally track whenever the radius changes (both, setting storage.radius and updating storage.metrics.report_radius())
Correctly generate the starting radius, when reusing an existing database
Bonus fix: the first log was getting double-reported for unknown reasons, this went away in local testing.

To-Do

[ ] Add entry to the release notes (may forgo for trivial changes)
[ ] Clean up commit history

Failure is:
test test::test_launches ... FAILED

failures:

---- test::test_launches stdout ----
thread 'test::test_launches' panicked at 'called `Result::unwrap()` on an `Err` value: AlreadyReg', trin-core/src/portalnet/storage.rs:741:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

failures:
    test::test_launches

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.20s

error: test failed, to rerun pass `-p trin --test self_peertest`

I believe this is the first test that runs multiple instances with metrics turned on. I think registering the same metric twice in the same process is causing a duplicate metrics error.

This is a lovely improvement.


"/getting-started/templates" Page doesn't exist

On the sample website.
In the get Getting Started > Installation page (https://mudblazor.com/getting-started/installation), there is a note about pre-configured templates, with a link to https://mudblazor.com/getting-started/templates.
This templates link is returning 404.

Now it works.

Now it works.

Don't know why you say that, the link still doesn't work.
To clarify, broken link in question is:

It fixed, it works on dev.mudblazor.com, and will work on website after next release.

@mckaragoz thank you for the clarification and looking into it.


Customizing Django Admin

Brief Summary:
The Django framework comes with its own admin templates.With some know-how its possible to customize it into suiting your project even more.
Key Takeaways:

How to access the Django admin page.
Identifying some of the features that can be  customized.
Customizing the Django admin to suit their project.

References:
Django Admin Cookbook

good topic @Sajeyks  - approved. Please be mindful of readability/grammar as you're composing your article. We do not provide editing services and require that all articles be polished for grammar/readability prior to submitting a draft for review. If in doubt, we suggest having one of your peers review the draft prior to opening a PR. Thank you.

@ninjaginja  does the readability concern have anything to do with my PR that is yet to find a reviewer?

No, that comment was solely based on the description that you provided in this issue. Our team of reviewers is working through the backlog of articles as quickly as possible. Thanks for your patience.

Thanks for your time

@Sajeyks just wanted to check if there was any update on this article topic

I will be submit the PR b4 Sunday.


Add class strategy for selecting dark theme

Description
This PR updates the theme application strategy.
In the previous implementation, dark class variants were applied whenever the user prefers-color-scheme dark based on their OS preferences. So the dark class variants would be applied even when the user had manually set the theme to light.
The change in this PR sets the dark class variants based on the manually selected theme. We default the theme on first interaction to the OS preference, which means the dark styles will be correctly applied then as well.
Note that the dark-theme part of the fix is because that is the mechanism that daisyUI uses for setting themes.
Type of change

[x] Bug fix (non-breaking change that fixes an issue)

Screenshots/Screencaps
Dark theme (note the borders)

Light theme (no borders)

LGTM - any issues should be followups.


Don't force syck on 1.9.3; it's not there

Unless there's a better way to solve this?

Hi Jay,
Thanks so much for this contribution!  I did not merge it directly, as you had some other unrelated changes in there, but I made a similar commit which is now on the 3.3.2_dev branch on our github repo.  It will also be in the next release.
Thanks!


[BUG]  The type initializer for 'SkiaSharp.SKImageInfo' threw an exception in .NET Core 3.1 nanoserver docker container

Description
In a .NET Core 2.2 project that includes SkiaSharp, SkiaSharp.NativeAssets.NanoServer, building and running on mcr.microsoft.com/dotnet/core/sdk:2.2-nanoserver-1803 worked fine.
In a .NET Core 3.1 project that includes SkiaSharp, SkiaSharp.NativeAssets.NanoServer, building and running on mcr.microsoft.com/dotnet/core/sdk:3.1-nanoserver-1803 does not work.  The exception is:
_The type initializer for 'SkiaSharp.SKImageInfo' threw an exception.
Unable to load DLL 'libSkiaSharp' or one of its dependencies: The specified module could not be found. (0x8007007E)
Unhandled exception. System.TypeInitializationException: The type initializer for 'SkiaSharp.SKImageInfo' threw an exception.
---> System.DllNotFoundException: Unable to load DLL 'libSkiaSharp' or one of its dependencies: The specified module could not be found. (0x8007007E)
at SkiaSharp.SkiaApi.sk_colortype_get_default_8888()
at SkiaSharp.SKImageInfo..cctor()
_
Code
Just this one line will do it:
var bitmap = new SKBitmap(100, 100);
Expected Behavior
No exception
Actual Behavior
This exception:  The type initializer for 'SkiaSharp.SKImageInfo' threw an exception.
Unable to load DLL 'libSkiaSharp' or one of its dependencies: The specified module could not be found. (0x8007007E)
Unhandled exception. System.TypeInitializationException: The type initializer for 'SkiaSharp.SKImageInfo' threw an exception.
---> System.DllNotFoundException: Unable to load DLL 'libSkiaSharp' or one of its dependencies: The specified module could not be found. (0x8007007E)
at SkiaSharp.SkiaApi.sk_colortype_get_default_8888()
at SkiaSharp.SKImageInfo..cctor()
Basic Information

Version with issue:  <IP_ADDRESS>
IDE: .NET Core 3.1 SDK on mcr.microsoft.com/dotnet/core/sdk:3.1-nanoserver-1803

The newer 1809 tags of just 3.1 and 2.2 show the same result.
I tried comparing both containers' forward DLLs and using NanoServerApiScan.exe but got the same results for both (FONTSUB.dll - CreateFontPackage).  Tried to dig deeper into the nativeassets and how that all worked but couldn't quite piece it together.

The sample does work, however, using the Windows ServerCore container (mcr.microsoft.com/windows/servercore:ltsc2019).
Seems they stripped out some key component from the 3.1 nanoserver (which is only ~737MB versus ~1.68GB for 2.2 nanoserver).

Ok.  I just now came across this in the main description:
ExcludeAssets="native"
Which seems to fix it.
Somehow I failed to stumble upon this sooner!

Ah, that is good news! Glad you were able to solve it. Maybe I should make things more obvious. I really need a Getting Started with explicit directions for each platform - and any caveats or things of note...


Deprecation warning and object error in console (Ember 2.7) - dropping a file object

Can this be used to drop a file from outside the browser window as the dropped object?
When I try to do that, I see these errors in the console:
DEPRECATION: The length property of <(unknown mixin):ember442> is an Ember.Binding connected to contentLength, but Ember.Binding is deprecated. Consider using an alias computed property instead. [deprecation id: ember-metal.binding]
See http://emberjs.com/deprecations/v2.x#toc_ember-binding for more details.
trekclient.js:451 Uncaught no obj for key getObj @ trekclient.js:451getObject @ trekclient.js:400handlePayload @ vendor.js:87221handleDrop @ vendor.js:87228acceptDrop @
451 Uncaught no obj for key

Unfortunately this addon is only intended to allow internal dragging and dropping.  Give Dropzone a try.


docs: zerops deployment guide

🔗 Linked issue

❓ Type of change

[x] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
https://zerops.io/ documentation guide
Home of Zerops Team: https://discord.gg/xxzmJSDKPT

ahh time for nitro preset

Pr for nitro preset ✅


parq output to CSV

you asked for suggestions for the parq command:
Output to CSV would be very useful. I recocognize that parquet can have more complex datasets that CSVs generally allow for, however lots of the parquet datasets can easily be converted to CSV.
Maybe even with an optional range: ie, if the dataset is a timeseries, output between 2 dates... or output between 2 row numbers.

we can output to CSV as long as parquet file doens't have complex types, or simply skip complex types, is that acceptable?

definitely


Refactoring credentials api interface

This change brings the web5-js credentials package more in line with the web5-kt credentials package api interface.
This simplifies the creation of VCs and moves signing into a separate function call:
const vc = VerifiableCredential.create("ExampleCredential", "did:issuer", "did:subject", myData)
const signedVc = vc.sign(signOptions)

This also moves Presentation Exchange into its own object to do anything with Presentation Exchange:
const presentationResult = PresentationExchange.createPresentationFromCredentials(vcJwts, presentationDefinition)

Pending feedback from @andresuribe87 / @mistermoe / @nitro-neal


issues/29: add support for http sessions

What:

add support for http sessions

Why:

Fixes: https://github.com/komuw/ong/issues/29

Codecov Report
Base: 70.78% // Head: 71.08% // Increases project coverage by +0.29% :tada:

Coverage data is based on head (f3db6f6) compared to base (c457439).
Patch coverage: 74.25% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   70.78%   71.08%   +0.29%
==========================================
  Files          28       30       +2
  Lines        1965     2058      +93
==========================================
+ Hits         1391     1463      +72
- Misses        506      526      +20
- Partials       68       69       +1

Impacted Files
Coverage Δ

middleware/log.go
78.88% <20.00%> (ø)

cookie/cookie.go
76.14% <50.00%> (ø)

middleware/session.go
57.14% <57.14%> (ø)

sess/sess.go
88.88% <88.88%> (ø)

middleware/middleware.go
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


feat: Add React Plugin

Which problem is this PR solving?

#84

Short description of the changes

Adding plugin for React instrumentation + docs and tests
This plugin instruments the lifecycle methods of a React component as defined here: https://projects.wojtekmaj.pl/react-lifecycle-methods-diagram/
Note: Constructor & getDerivedStateFromProps are not instrumented because they are static methods.  getDerivedStateFromProps is considered an extremely rare use case

Usage
Once the tracer is defined, statically set logger & tracer:
BaseOpenTelemetryComponent.setLogger(logger);
BaseOpenTelemetryComponent.setTracer("name", "version");

Component definitions:
class export Component1 extend BaseOpenTelemetryComponent { ...}
class export Component2 extend BaseOpenTelemetryComponent { ...}

Any component extending BaseOpenTelemetryComponent will be instrumented.
Example Traces
Example Attributes:

Mounting Flow:

Updating Flow:

Unmounting Flow:

Has this been tested with preact? Would be interested to see if it works, and would be a nice addition to the README.

React is still having some problem, although the XMLHttpRequest is getting a correct parent,
but as you can see you spans are splitted into 2 groups and also the click event is not a parent for start group.
Why those 2 groups are not connected whereas in preact it works fine
WIth regards to click event for me it looks like the react might either have some addition life cycle that the plugin is not taking into consideration or something else.

Finally the react should look like preact and I'm enclosing you the image how it should look like
https://imgur.com/SpLw3nQ

After investigating a bit, I found that if the button handler is added directly using addEventListener like:
 document.getElementById('id').addEventListener('click', () => this.buttonHandler(this))

instead of setting the handler using the onClick method as part of the button, the React traces get nested under the the click span as expected.
As discussed, we think this is likely due to some React optimizations or a bug in zone.js, and out of scope of this PR.


Skype channel embed on website not displaying chat bubble

Skype chat bubble isn't displayed anymore. It was working fine and now i don't see the chat bubble on my website anymore. Tried on Firefox, Chrome and Safari.
Here is my embed code:

I noticed GET error on https://swc.cdn.skype.com in browser's console. Screenshot below,

Any idea?

This CDN (the one that controls the skype bubble) is controlled by Skype, not the Bot Framework unfortunately.
https://swc.cdn.skype.com/sdk/v1/sdk.min.js


Isolated scope property for directive is being re-digested in version 1.4.1

Hi,
the issue is not reproducible in 1.4.0 and appears only in 1.4.1 as you can see in the link below
http://plnkr.co/edit/kbIJflj4sL5kcCcYPzw7?p=preview
The problem is when scope property is changed in directive's controller then in the next digest cycle it's being rewritten.
Regards,
Andrew
@kikhtenko

+1

+1

+1

+1

It's probably a6339d3.

Probably. Doesn't happen with = ..

+1

This issues is reopened as the fix was reverted.

@petebacondarwin missing a link/reason for the revert

@caitp https://github.com/angular/angular.js/issues/12259
(If material relied on buggy behavior, we should fix it there rather than in core)

+1 @Narretz
It seems quite bizarre that we reverted a fix to a (rather serious imo) bug/regression, because the fix broke an external module.
IS anyone looking into why ngMaterial broke with the fix ?

I was looking into it earlier, but I can't get any tests to fail when the angular module has the revert reverted, and i couldn't find any demos that behaved weirdly (under tabs or autocomplete)

I'm not actually sure where the material tests are, because the file in the test directory just has a bunch of matchers, no tests

nvm, found em :> there's a ddescribe() in there preventing tests from running, sending pr

Thanks for looking into this everyone. I agree if material relied on buggy behaviour then it should be fixed there.

But since angular-material is a first class citizen of the Angular team then we ought to have a process in place to run angular-material tests before we do a release.

The main problem I'm seeing is that they're using =? isolate scope bindings to represent boolean attributes, which doesn't make a lot of sense. It doesn't die in the reverted version because the reverted version ignores expressions valued at the empty string, if they're optional (which we can probably still do)

All of the angular-material tests pass for me (with the revert reverted) with the following change:
           case '=':
             if (!hasOwnProperty.call(attrs, attrName)) {
               if (optional) break;
               attrs[attrName] = void 0;
             }
+            if (optional && isString(attrs[attrName]) && !attrs[attrName].trim()) {
+              break;
+            }

I don't know if there are still other problems, but if there are, they aren't causing test failures (there are 2 disabled tests in the tree still)


Remove API compatibility references to Knative in docs

Changes
Remove references in the API compatibility docs regarding Knative resources
Remove clusterRole references to Knative resources

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Includes tests (if functionality changed/added)
[x] Includes docs (if user facing)
[ ] Commit messages follow commit message best practices

See the contribution guide
for more details.
Release Notes

release-note

Good call, thanks for updating this @vtereso !! 🙏 @pmorie has a good point re. saying "Knative Build" vs just "Build" but I'd like to merge this in as is before it gets into a state where it conflicts with master
/lgtm
/approve
/meow space

I0619 22:31:25.737] 2019/06/19 22:31:25 Published gcr.io/tekton-prow-4/tpipeline-e2e-img/controller-10a3e32792f33651396d02b6855a6e36@sha256:11b2c2f66e29ba4e6cf217ab29e481425666aa75cbbdde2c2decd66a3b95d76a
I0619 22:31:52.361] 2019/06/19 22:31:52 error processing import paths in "config/controller.yaml": unsupported status code 502; body: <!DOCTYPE html>
I0619 22:31:52.362]
I0619 22:31:52.362]   <meta charset=utf-8>
I0619 22:31:52.362]   <meta name=viewport content="initial-scale=1, minimum-scale=1, width=device-width">
I0619 22:31:52.362]   <title>Error 502 (Server Error)!!1</title>
I0619 22:31:52.362]
I0619 22:31:52.363]
I0619 22:31:52.363]
502. That’s an error.
I0619 22:31:52.364]
The server encountered a temporary error and could not complete your request.
Please try again in 30 seconds.  That’s all we know.
I0619 22:31:52.465] ERROR: Build pipeline installation failed

waaaaaat

/test pull-tekton-pipeline-integration-tests


chore: fix share copy LESQ-488

Description
Music year: 2007

Add margin to the mobile view share text copy

Issue(s)
Fixes #LESQ-488
How to test

Go to https://deploy-preview-2121--oak-web-application.netlify.thenational.academy
Click on ______
You should see ______

Screenshots
How it used to look (delete if n/a):

How it should now look:

Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

:tada: This PR is included in version 1.310.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


generic-array v0.14

This crate presently pulls in both generic-array v0.12 and v0.13.
It'd be nice to also support v0.14, and potentially toggle off v0.12 and/or v0.13 support unless they're really still needed.
Related: #2

On a side-note, as soon as stable get const generics this crate will most likely remove the generic_array dependency


[Draft] Adopt a threading model for smoke tests.

Motivation
(Write your motivation for proposed changes here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/libra/developers.libra.org, and link to your PR here.)

/land

@JoshLind :exclamation: This PR is still missing approvals, unable to queue for landing

let's close this for now

@davidiw, agreed. I think there's too many things blocking us from deploying this well enough. Perhaps I'll revisit it later at some point 😄. Thanks!


Env CPU Rendering

Hello, looks like a cool project.
Is it possible to fully render the env on CPU only?
thanks

Yes, I think this should be possible. It is pretty much what is happening if you run the game on the virtual display without enabling Vulkan or compatibility mode (Proton). The performance will probably be quite bad, though - you should expect no more than ~ 10 fps. However, I have not tested so far, whether it is necessary to have at least a GPU installed to start.
If you have any concrete problems or suggestions, please let me know.

@iksnagreb
I'm not sure you still active on this repo, but I've been learning python with chatGPT lately to create an AI that would be trained to play Guilty Gear Strive. I came up with a solution using GeforceNow Ultimate membership, and DXcam library to capture up to 240 fps screen grabs and running python up to 3.9 ( this is the highest pytorch supported version, gymnasium supports up to 3.11) on windows using CUDA.
This way I use little to no resources to run the game, around 400MB of ram and not much CPU so my GPU can fully be leveraged by the training.
Point is, let me know, if you are open to mentor me a bit and make this environment better as well as the one for GGST as well, cause I don't know jack**** about AI and not much python either, yet.
Best regards


Failed to generate resource table for split ''

Hi,
I'm having a strange issue coming of nowhere when compiling the project. It has been working well so far until today where this error came up:
Unknown source file : Failed to generate resource table for split ''
/home/cloud/Escritorio/mobile_android/node_modules/react-native-dialogs/android/build/intermediates/exploded-aar/com.github.afollestad.material-dialogs/core/<IP_ADDRESS>/res/values-v11/values-v11.xml:17:54-92 : No resource found that matches the given name (at 'android:actionModeCloseDrawable' with value '@drawable/abc_ic_ab_back_mtrl_am_alpha').

EDIT: It comes from the afollestad library
It has been solved here: issue
Could you fix the issue on the lib please?
That would be great, thanks :)

I'm sorry I didn't see there was a pull request for it :+1:

Solvedf with version 0.0.13, thanks!


Add OrderBook and Ticker methods to Bybit Spot API

Pull request checklist

[ ] Did you bump the project version?
[ ] Did you add a description to the Pull Request?
[ ] Did you add new tests?
[x] Did you add reviewers?

Hi! Thank you a lot for contributing. I've suggested a minor change to docs. Otherwise, the PR looks good to me!

Please don't forget to update minor in Project.toml.
Thank you for your PR!

Codecov Report
Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 2.82%.  Consider uploading reports for the commit 58fb757 to get more accurate results

Files
Patch %
Lines

src/Bybit/Spot/API/Ticker.jl
0.00%
6 Missing :warning:

src/Bybit/Spot/API/OrderBook.jl
0.00%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #18      +/-   ##
=========================================
- Coverage    2.86%   2.82%   -0.04%
=========================================
  Files          57      59       +2
  Lines         804     814      +10
=========================================
  Hits           23      23
- Misses        781     791      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


vJunos-EVO: remove error in init file that prevents loading it

plus remove config for ZTP as per console log message:
2024-12-31 09:11:40 INFO: ZTP: remove "chassis auto-image-upgrade" from config to abort ZTP

thanks @ssasso
@vista- does it look good to you as well?

Hi @ssasso , thanks for the contribution!
I swear I have double-checked that this fix for the inet6 typo made it into the branch 🤦
However, I'm not sure how you're ending up with chassis auto-image-upgrade in your config.
admin@vjunosevo> show configuration | display inheritance
## Last commit: 2024-12-31 15:19:27 UTC by root
version 23.2R2.21-EVO;
system {
   host-name vjunosevo;
   <snip>
}
interfaces {
   <snip>
}
routing-instances {
   <snip>
}

admin@vjunosevo> show configuration chassis | display inheritance
<empty>

Is it possible the startup config you're loading has this config stanza in it? The normal behaviour for vJunosEvo nodes is to load override the default configuration with the one provided by containerlab and the user.

However, I'm not sure how you're ending up with chassis auto-image-upgrade in your config.

I did not notice that there's the override in place, I only noticed the log when my instance was unable to load the config so I (wrongly) assumed that could be useful.
Btw I will update this PR in the upcoming days removing that.


Licence file

Hi, it seems that they is no licence file for this repository. Can you please add one? Mit is a good choice imo

Great,thanks !


Fix systemctl is active

A fix for this issue
https://github.com/pytest-dev/pytest-testinfra/issues/748

I'd like to see this fixed.  It's affecting a project with which I'm involved at work (#775).  I suppose I'll have to do some lame workarounds. :-(

@philpep Hi Philippe, is this project looking for maintainers/reviewers? Seems like the open PRs are a bit stuck..

@martinhoyer
This also applies to is_enabled, might be a good idea to get a fix in for that too.


Drupal v7.90 [0.5h]

https://www.drupal.org/project/drupal/releases/7.90

Deployed to live (through Pantheon):

PR with core version update merged.
This is done... Closing.


[Bundle Size] Offload lodash dependency

Description
This PR removes lodash dependency from stacks.js packages.
lodash minified size is around 69KB out of which stacks.js is using around 10KB of its modules. This will help to reduce the bundle size. In the subsequent pr, further dependencies can be removed to reduce the bundle size further.
For details refer to issue #1120
Type of Change

[ ] New feature
[X] Bug fix
[ ] API reference/documentation update
[ ] Other

Does this introduce a breaking change?
No
Are documentation updates required?
No
Testing information

npm run test

Checklist

[X] Code is commented where needed
[X] Unit test coverage for new or modified code paths
[X] npm run test passes
[ ] Changelog is updated
[X] Tag 1 of @yknl or @zone117x for review

I'd prefer if we simply changed the dependency to be just the cloneDeep() method from Lodash, rather than implementing our own.
https://www.npmjs.com/package/lodash.clonedeep


Add Designer Options to list of Xaml UI shortcuts.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ide/default-keyboard-shortcuts-in-visual-studio.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


mysub:10: command not found: my sub

My sub is called cmal and is installed at ~/Dropbox/Dropbox/Config/sub/cmal
My .zshenv contains:
PATH=$PATH:$HOME/.rvm/bin # Add RVM to PATH for scripting
eval "$($HOME/Dropbox/Config/sub/cmal/bin/cmal init -)"

Whenever I open a new terminal, and run cmal I get cmal:10: command not found: cmal
If I then run source ~/.zshenv followed by cmal I correctly get the usage.
But every time I open a new terminal window I'm back to square one. Any idea what could be going on?

Looks like #32


Automatically test memory soundness of the core

The current refactoring test suite does a memory soundness check, running the MIM core under valgrind for one n-layer example and one reduced gravity example.  This is both unpleasant, because running under valgrind is slow, and inadequate, because I don't think those examples constitute reasonable coverage for detecting memory access problems in the whole code (at the very least, an ideal such test suite should cover every syntactic array access, to check for reads and writes off the end).
Ergo, I think it appropriate to define a separate build, possibly entrusted to Travis so it gets run without the developers needing to manually run it all the time, which runs a fuller suite of examples under valgrind.  It might also be possible to bootstrap that into measuring the rate of memory leaks (which we may or may not be able to hold to zero, possibly depending on the platform on which the build is run).
The examples need not be high-resolution or long-duration to cover this purpose; they just need sufficient branch coverage.

I've just submitted a pull request ( #41 ) that runs the current test suite on Travis-CI. It runs in under a minute, so I'm not sure we need to worry too much about its speed just yet.
We should however expand the test suite to cover the other features described in #6.


d3admin: Allow for multiple expiration paths

Currently, you can only supply one path for an expiration, which means that it's not possible to set expirations for cases when you install multiple apps with one package, such as with Microsoft Office. Being able to comma-separate paths in the expiration path field would be great, so you can still set an expiration that resets if any of the listed apps has been used.

duplicate of #25


chore: Adding release plz

Signed-off-by: Todd Baert<EMAIL_ADDRESS>

Codecov Report

Merging #98 (e92a1bd) into main (a7897a2) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head e92a1bd differs from pull request most recent head eed9ef6. Consider uploading reports for the commit eed9ef6 to get more accurate results

@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   96.17%   96.17%
=======================================
  Files           9        9
  Lines         445      445
  Branches       57       57
=======================================
  Hits          428      428
  Misses         17       17

Help us with your feedback. Take ten seconds to tell us how you rate us.


How to format portfile.cmake and other cmake files?

What is the format of the cmake file? Is there a cmake-format file, or when pulling a request, add a bot to automatically format it?

Sorry, currently we only support the command formatting of vcpkg.json, and do not currently support the formatting of portfile.cmake and other cmake files.


HIVE-23682 : TestMetrics is flaky

What changes were proposed in this pull request?
HIVE-23682
Why are the changes needed?
To enable test in testsuite
Does this PR introduce any user-facing change?
NO
How was this patch tested?
testcse

Flakey test jenkins job is successful
http://ci.hive.apache.org/job/hive-flaky-check/656/console

Is it not flaky anymore?

http://ci.hive.apache.org/job/hive-flaky-check/656/console


Add update method

Added .update() method to enable efficient object merging

I think one of the tests may be flaky, but I can't figure out how to make it fail. I guess we'll deal with that when we come to it.

Can you also please edit the sample code in README.md
results.append -> results.add

@kennethmorton done


why you refuse to answer

import axios from 'axios'
import * as types from '../mutation-types'
// post
export const state = {
post: []
}
// getters
export const getters = {
post: state => state.post
}
// mutations
export const mutations = {
[types.FETCH_POST_SUCCESS] (state, { post }) {
state.post = post
},
[types.FETCH_POST_FAILURE] (state) {
state.post = null
}
}
// actions
export const actions = {
// auth/fetchPost
async post ({ commit }) {
try {
const { data } = await axios.get('/api/post')
commit(types.FETCH_POST_SUCCESS, { post: data })
} catch (e) {
commit(types.FETCH_POST_FAILURE)
}
}
}

What's your issue here?


Add pipenv --support instead of python -m pipenv.help

When homebrew is used to install python, the debug help command doesn't work.
pipenv --support will now be the flag to invoke when getting diagnostic information.

i'm guessing we want to keep .help too and just leave it as a thin wrapper around the new command

pipenv --support and python -m pipenv.help are both supported now with pipenv --support being preferred.


Avoid plotting too-short arrows

This removes a visual bug, shown in the attachment.  In this visualization, short arrows go past where they should end.  And one arrow is plotted with length zero, which seems to result in a vertical line.  This PR just avoids plotting any arrows until there is enough space for them in the plot (second screenshot).

Looks good thanks!
Presumably we should merge this and some other recent changes into the FA16 branch too, the one linked from the book.


Adapt to use new DatePicker implementation.

https://github.com/droolsjbpm/kie-wb-common/commit/fddace221bf7b837f11e857e49d94d2dbf03cbcd


Initial conformity tester

fixes: https://github.com/creek-service/creek-test/issues/2
Comes with two checks:

CheckModule: checks the module is not automatic or unnamed.
CheckApiPackagesExposed: checks all api packages are exported in module-info.java.

Reviewer checklist

[x] New Modules have module-info.java files.
[x] Public types are well-designed:

[x] no public constructors.
[x] prefer interface or impl.

[x] Ensure relevant issues are linked (description should include text like "Fixes #")
[x] Ensure any appropriate documentation has been added or amended

Coverage increased (+1.7%) to 96.585% when pulling d98361fab441441a2650e0aa680fc227ff4aa47e on conformity into 7d4ea239294602dac5eb071a9c2f970d9849f4c4 on main.


add perplexity with Mistral model

Only regarding the name, not sure if it will be easier to parse it was: metrics.rag.context_relvance.mistral that way all the context_relvance metrics will be in the same directory dedicated to context_relvance metrics.

This would require to also change the existing metrics.rag.context_relevance to metrics.rag.context_relevance.flan_t5_small.
Didn't do it for backwards compatibility, but I can change it if you prefer.


1.10.0 - Targets marked as don't code-sign by default

What
After the changes in https://github.com/yonaskolb/XcodeGen/pull/324, framework targets are not code signed by default and must be explicitly marked.
Effects
If codeSign: true is not specified for framework target dependencies, deploying to device will result in an error “No code signature found”
Proposed Solution
Like discussed here, the logic could be modified slightly to disable code signing based on:

The destination (i.e. plugins) or
Whether the target is an app extension or not (borrow logic from here:)

https://github.com/yonaskolb/XcodeGen/blob/c79a205339a150ef3000985cc542ccb6564f8a4f/Sources/XcodeGenKit/PBXProjGenerator.swift#L458

Fixed in #333
I tried using app extension or plugin destination but it missed some cases (for example iMessage apps aren't extensions but require code signing to be off)
I've changed the heuristic to code sign all dependencies except executables. Leave your comments in the PR


Release 1.3.0-beta.6

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.015%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1606

Relevant Lines:
2087

💛  - Coveralls


Enforce InfiniteMPOHamiltonian to be square

After further consideration, for now the easiest solution is to enforce InfiniteMPOHamiltonian to be square. This addresses #214 .

With the current implementation, it probably makes no difference.


Building container images from source

How do we drive a container build from source control to a registry? Provide guidance on how a user may easily implement a CI task to build a container on Github, Gitlab, or other with tools like Dockerfiles, Cloud Native Build packs, or other.

@craigtracey is this in flight or should it be moved back to the "To Do" column of the backlog?


Variant's reference count is inconsistent

Godot version
4.0 alpha11
System information
Linux x64
Issue description

The reference count is not increased  when construct a Variant with a RefCounted pointer but decreased by the destructor.
The refernece count is increased when assign a pointer of RefCounted to a Variant

I'm confused about the implementation of the constructor Variant::Variant(const Object *p_object). Can someone help me explain the intent of this code ?
https://github.com/godotengine/godot/blob/b438859d04dfea6de72d52e04bef2f57fb369d7a/core/variant/variant.cpp#L2692-L2699
Steps to reproduce
The numbers annotated in the sample code below are the reference counts I expect
RefCounted ref;  // 1
ref.reference(); // 2
ref.reference(); // 3
ref.reference(); // 4
print_line("RefCounted ref count: " + itos(ref.reference_get_count()));
{
	Variant v(&ref); // 5
	print_line("RefCounted ref count: " + itos(ref.reference_get_count()));
} // 4
print_line("RefCounted ref count: " + itos(ref.reference_get_count()));
{
	Variant v;
	v = &ref; // 5
	print_line("RefCounted ref count: " + itos(ref.reference_get_count()));
} // 4
print_line("RefCounted ref count: " + itos(ref.reference_get_count()));

The results are not consistent with what I expected
RefCounted ref count: 4
RefCounted ref count: 4
RefCounted ref count: 3
RefCounted ref count: 4
RefCounted ref count: 3

Minimal reproduction project
No response

This is not a bug. The first time RefCounted is referenced, it must be with init_ref.

This is not a bug. The first time RefCounted is referenced, it must be with init_ref.

@neikeq What is the usage of init_ref ?
As the code snippt above shown the Variant change down the reference count.
Do you think this is correct?

The initial refcount of a RefCounted object is 1. The reason it's 1 and not 0 is because reference() does a conditional increment that fails if refcount is already 0. I think this is to avoid data races (accidentally killing and reviving an object from two different threads).
However, because of this, the first time you reference the object, the refcount becomes 2 instead of 1. This is wrong because there's only one reference. init_ref() handles this case by checking if it's the first time an object is being referenced, and decrementing refcount by one in that case.
Why not make reference() private and make init_ref() the only public API to avoid these kinds of mistakes? I don't know, maybe for performance (avoids an extra check). Keep in mind, you are not supposed to call these manually, any way. Only special scenarios need to do that, like script language bindings.

We could add a debug-only check in init_ref() to print an informative error when it's not used properly. That should help to avoid confusion in the future.

Keep in mind, you are not supposed to call these manually, any way. Only special scenarios need to do that, like script language bindings.

I'm making JavaScript language binding when pass a RefCounted back as an Variant the referece count is decrease in this situation.

If you want to be safe, just call init_ref() always, never use reference(). If you want to avoid an extra check, you can look for places where it's ok to use reference().
You have to be very careful about manually handling the refcount. C# has had many leaks in the past because of this.


csp: add raw.githubusercontent.com for refills

Instead of adding raw.githubusercontent.com we should just add anything we need to the warehouse/static/ directory and serve it from there.


Add ThirdPartyNotice for the simulator font

@guillaumejenkins can you add more information. I don't understand this issue.

Our OSS request for the simulator font was approved. To use the font, we need to add a ThirdPartyNotice to the repo, which includes a reference to the font and its license.

@guillaumejenkins  Here: https://github.com/Microsoft/pxt-arcade/pull/188/commits/af772c748ae6ee3e1e5d027a203e52931444b618
Can you add the right license to this file?

@guillaumejenkins any update here?

Fixed in #196


Add two columns Settings layout

Fixes #578
This PR changes the Settings layout by adding a sidebar to the left.
As previously suggested, I split the Settings into one category for Providers, GPT Models and Temperature, then I moved everything else into a "Customization" category.
I moved Web Handlers into Settings and, for consistency, I moved the Default System Prompts as well.
Desktop preview:

Mobile preview:

This is exciting to see happening!

It's ready for review!

@menghif can you rebase this to pick up the changes on main?

Rebased. I made some changes last night based on @Amnish04 feedback but that's still a work in progress.

I'm loving this.  There are some things I think we need to do after this (e.g., split providers from models, show your list of providers on the left under "Providers"), but none of it needs to block this.
I'll let you iterate with @Amnish04, but this is really coming along nicely.  Thank you!

@menghif can you rebase this to pick up the changes on main?

Rebased. I made some changes last night based on @Amnish04 feedback but that's still a work in progress.

@menghif I saw that you are embedding the settings type selection list into an Accordion on smaller screens.
I was wondering if we could hide the already selected item from the drop list, as it feels redundant.

We can land this as is and iterate on mobile tweaks incrementally.

Agree, @menghif file a follow-up for whatever is left and get this in.  It's awesome.

I was working on this yesterday and made the change to set the Modal's height as fixed and only allow the inner body to scroll.
I still have an overflow bug with the Web Handlers body but I can include that in a follow up issue.
It's ready for a final review now!

@menghif land this when you're ready and anything else can happen in follow ups.
Amazing work getting this done so fast.

@menghif this is a huge improvement in my life :)


Bot stuck

when the bot stuck then retry then stop
hope is be stuck > retry > sleep for 30sec > retry > sleep for 1min > etc

The bot is already retrying twice when stuck and waiting up to 10 seconds for the server synchronization.
I don't think waiting more would change anything. If the bot is 100% stuck, reconnecting is probably the only solution.