kata-check: do not require nested vt

We do not really require nested VT to run kata containers. Let's not
depend on it being there.
Let's see if it fixes the recent nested vt related CI issues.

If we run in a VM, do we still need this check to print a waring/error?

@caoruidong No, the option is to allow guest to be able to use kvm in nested mode. kvm is working on the host w/o it so we can still launch kata containers inside a vm. I think some cloud vendors might want to disable it in the host kernel code but still allow kvm-intel to be present, which is likely what we saw recently in CI.

@bergwolf Got it. What we want to check is the host environment but we cannot check it from guest. So we don't need this.
LGTM

/test

@marcov

for users wanting to run kata with in a VM with kvm, it would be useful to check if nested kvm is setup properly.

Nested kvm is only needed when users want to run nested guests within their own guests, which in kata containers case, translates into running nested guests within kata containers. I'm not sure that is a common use case that we want to support. E.g., we do not enable CONFIG_KVM in kata containers default kernel right now. I agree that there might be people wanting to run kata containers within kata containers, but that feels like a very uncommon use case and such customized expert users should be able to check and enable proper host and guest kernel configs on their own.

@bergwolf I was referring to users running kata-containers runtime inside a VM that is managed  e.g. with libvirt.
If nesting mode is not enabled on the host, then kata-check reports an error when checking "Virtualization Support". In this case, it would be nice to have an hint that nesting should be enabled on the host.

If nesting mode is not enabled on the host, then kata-check reports an error when checking "Virtualization Support". In this case, it would be nice to have an hint that nesting should be enabled on the host.

However, this should not be handled by this PR.
lgtm

/test

/test

/test

/test

CI machine kvm enablement should now be fixed... let's try that test again...
/test

Of the latest five CIs tests, four of them failed kata-check due to missing vhost kernel module. The remaining one failed on boot time and memory foot print test:
19:06:23 time="2018-10-16T11:06:23Z" level=warning msg="Failed Maxval (8.140000 < 8.470350) for [boot-times]"
19:06:23 time="2018-10-16T11:06:23Z" level=warning msg="Check for [boot-times] failed [Failed]"
19:06:23 time="2018-10-16T11:06:23Z" level=warning msg=" with [[*F* boot-times 90.0% 114.5% 110.0% 20.0% 110.8% 116.4% 5.1% 1.3% 20]]"
19:06:23 time="2018-10-16T11:06:23Z" level=warning msg="Failed Minval<PHONE_NUMBER>00 ><PHONE_NUMBER>00) for [memory-footprint]"
19:06:23 time="2018-10-16T11:06:23Z" level=warning msg="Check for [memory-footprint] failed [Failed]"
19:06:23 time="2018-10-16T11:06:23Z" level=warning msg=" with [[*F* memory-footprint 92.3% 89.9% 107.7% 15.4% 89.9% 89.9% 0.0% 0.0% 1]]"

@bergwolf metrics boot time is a known issue I need to look at - I have a feeling something changed or got merged recently - we have had a string of those.
metrics memory footprint is a new one, so we will have to keep an eye on that one.

I added modinfo vhost and modinfo vhost_net commands to the beginning of the jenkins job. As you can see in:
http://jenkins.katacontainers.io/job/kata-containers-runtime-ubuntu-16-04-PR/977/console
at the very beginning of the log, both modules are present.
filename:       /lib/modules/4.4.0-128-generic/kernel/drivers/vhost/vhost.ko
description:    Host kernel accelerator for virtio
author:         Michael S. Tsirkin
license:        GPL v2
version:        0.0.1
srcversion:     4B2C406DD45508EBDDC1500
depends:
retpoline:      Y
intree:         Y
vermagic:       4.4.0-128-generic SMP mod_unload modversions retpoline
parm:           max_mem_regions:Maximum number of memory regions in memory map. (default: 64) (ushort)
filename:       /lib/modules/4.4.0-128-generic/kernel/drivers/vhost/vhost_net.ko
alias:          devname:vhost-net
alias:          char-major-10-238
description:    Host kernel accelerator for virtio net
author:         Michael S. Tsirkin
license:        GPL v2
version:        0.0.1
srcversion:     6C8BD745CFC0DA445E95381
depends:        vhost,macvtap
retpoline:      Y
intree:         Y
vermagic:       4.4.0-128-generic SMP mod_unload modversions retpoline
parm:           experimental_zcopytx:Enable Zero Copy TX; 1 -Enable; 0 - Disable (int)

But then it fails when running the kata-check tool.  Found that the CI is running the tool without sudo, which is required by  modprobe.
https://github.com/kata-containers/tests/blob/master/.ci/install_runtime.sh#L39
I'll open a PR in tests repo to run it with the correct permissions.
And maybe in this PR we can add more information to the log about what went wrong, so a user knows if it was a problem with permissions.

@bergwolf ping.

https://github.com/kata-containers/tests/pull/823 is merged. Let's restart CI.

/test

@bergwolf @chavafg
Just need some clarifications here. Do we have nested virtualization checks part of the CI now?
Correct me if I'm wrong but you want to remove the nested check from Kata itself, and move it to the responsibilty of the environment running Kata tests?

@chavafg @bergwolf should we simply close this PR?

@sboeuf The idea is that nested kvm is only required on L1 hypervisor if we want make the guest a L2 hypervisor. I'm trying to reduce the requirement because we do not need nested kvm on the host to run kata containers. One possible use case of nested kvm is to run kata containers inside kata containers. But I don't think we support that. And even if we do, we do not need to fail kata-check on platforms that do not support nested kvm.

@bergwolf makes sense!
LGTM

We can ignore the metrics CI (I could hand-trigger just that if we really needed, but I don't think it relates to this PR), and the codecov reduction is trivial - so, I think we could merge this. Maybe one of @marcov @chavafg @jodh-intel would like to confirm and force merge?


Need some permalink

I want to share some stories in http://rejected.us/. Is there any permalink or anchor that I can use?

They don't have permalinks right now. People have requested it before. I'll definitely add that if I get some time but PRs are welcome if anyone else has time :)


Draw line between markers

Is there a possibility to connect two marker locations with a line?

just use ModelRenderable.Builder.

Do you gave any example of that?
LocationMarker point1 =  new LocationMarker(
20.501925,
44.792181,
new AnnotationRenderer("point1 ")
);
LocationMarker point2 =  new LocationMarker(
20.502972,
44.790873,
new AnnotationRenderer("point2 ")
);

you can do it like this -
Vector3 point1, point2;
point1 = lastAnchorNode.getWorldPosition();
point2 = anchorNode.getWorldPosition();
Node line = new Node();
/* First, find the vector extending between the two points and define a look rotation in terms of this
Vector. /
final Vector3 difference = Vector3.subtract(point1, point2);
final Vector3 directionFromTopToBottom = difference.normalized();
final Quaternion rotationFromAToB =
Quaternion.lookRotation(directionFromTopToBottom, Vector3.up());
final Renderable[] lineRenderable = new Renderable[1];
/ Then, create a rectangular prism, using ShapeFactory.makeCube() and use the difference vector
to extend to the necessary length.  /
MaterialFactory.makeOpaqueWithColor(this, color)
.thenAccept(
material -> {
lineRenderable[0] = ShapeFactory.makeCube(new Vector3(.01f, .01f, difference.length()),
Vector3.zero(), material);
});
/ Last, set the world rotation of the node to the rotation calculated earlier and set the world position
to the midpoint between the given points . */
line.setParent(anchorNode);
line.setRenderable(lineRenderable[0]);
line.setWorldPosition(Vector3.add(point1, point2).scaled(.5f));
line.setWorldRotation(rotationFromAToB);


if comment_empty is set to false, also check if line length is less than  1 and return

I'm not sure what use case this is for, could you help me understand?

yeah, so say you have a block above or below the cursor, but have a few empty lines between the cursor and the start of the block, this will prevent those additional empty lines from ending up as part of the block's comments. Also, if you have lines between a block with only whitespace (not empty, but white), it will be considered as part of the block, but not leave a comment. This is how Tim Pope's plugin behaved. Good job btw. Thanks for your work.

As far as use cases, it just allows you to be a little more loose with block comments. Instead of moving the cursor all the way to the block to get the perfect lengthed comment, you can do it from where you are as long as that block is your next neighbor. I use block comments all the time so I noticed this right away. I left comment_empty as true since I figured you wanted this as default behavior, but if you set it to false, it should see the difference.

My bad dude. I just switched back to your copy and now the comment_empty is working as expected. It must have been an issue on my end. I've been working out a lot of kinks in my lua config so I can't even figure out what my issue was now. Disregard. Great job btw. Thanks for your work.


It should be easier to deconstruct a list

I have some data that looks something like this:
{
   "foo": [1, 2]
}

And I'd like to deserialize it into a model like:
class Points(BaseModel):
    left: int
    right: int

class TheFoo(BaseModel):
    foo: Points

In particular, I know that the list will always contain 2 values and I'd like the first to become the value of left and the 2nd to be the value of right. I think it's somewhat common to have JSON APIs return lists with a fixed number of values like this where each value has a meaning.
I tried to get this to work using an @root_validator but that does not behave as I expect:
class Point(pydantic.BaseModel):
    left: int
    right: int

    @pydantic.root_validator(pre=True)
    def deconstruct(cls, v):
        assert len(v) == 2
        return {'left': v[0], 'right': v[1]}

class Foo(pydantic.BaseModel):
    foo: Point

def test_foo():
    val = {'foo': [1, 2]}
    f = Foo(**val)
   assert f.foo.left == 1

But that gives me:
E   pydantic.error_wrappers.ValidationError: 1 validation error for Foo
E   foo
E     value is not a valid dict (type=type_error.dict)

I did some looking at the custom data types an __get_validators__ stuff but didn't have much luck with that either.

Your use case looks rather close to the example for NamedTuple as a type: https://pydantic-docs.helpmanual.io/usage/types/#namedtuple
In [1]: from typing import NamedTuple
   ...:
   ...: from pydantic import BaseModel, ValidationError
   ...:

In [2]: class Point(NamedTuple):
   ...:     left: int
   ...:     right: int
   ...:

In [3]: class Foo(BaseModel):
   ...:     foo: Point
   ...:

In [4]: def test_foo():
   ...:     val = {'foo': [1, 2]}
   ...:     f = Foo(**val)
   ...:     assert f.foo.left == 1
   ...:     return f
   ...:

In [5]: test_foo()
Out[5]: Foo(foo=Point(left=1, right=2))

Would that work for your case?

Thanks for the quick response @StephenBrown2. That does seem to do the trick in this case. It seems like there's a valid use-case for being able to manually construct truly arbitrary fields from a list and/or support something like this without requiring a NamedTuple. I think the only thing preventing that kind of flexibility is that pydantic requires that the values passed to parse_obj are a dict and not a list before the @root_validator gets called. For example, the following works:
class Example(pydantic.BaseModel):
    x: int
    y: str
    z: int

    @pydantic.root_validator(pre=True)
    def doit(cls, values):
        return {'x': values['x'], 'y': values['y'], 'z': 2 * values['x']}

then Example.parse_obj({'x': 22, 'y': 'foo'}) returns Example(x=22, y='foo', z=44). But trying to do something similar where it expects values to be a list fails:
class Example(pydantic.BaseModel):
    x: int
    y: str
    z: int

    @pydantic.root_validator(pre=True)
    def doit(cls, values):
        return {'x': values[0], 'y': values[1], 'z': 2 * values[0]}

But then Example.parse_obj([22, 'foo']) fails with:
ValidationError: 1 validation error for Example
__root__
  Example expected dict not list (type=type_error)

What do you think about adding something like a skip_type_check option to the Config?

It seems you can't put a validator on a NamedTuple which is another reason it might be nice to allow the root_validator to handle lists.

Hi @oliverdain
You're right pydantic handles dicts by default hence the class workaround with custom root types
class Example(BaseModel):
    x: int
    y: str
    z: int

class ExampleRoot(BaseModel):
    __root__: Example

    @validator('__root__', pre=True)
    def doit(cls, values):
        return {'x': values[0], 'y': values[1], 'z': 2 * values[0]}

assert ExampleRoot.parse_obj([22, 'foo']).__root__ == Example(x=22, y='foo', z=44)

If you really want to do it inside Example, there is a dirty workaround for now:
class Example(BaseModel):
    __custom_root_type__ = True

    x: int
    y: str
    z: int

    @root_validator(pre=True)
    def doit(cls, values: dict[str, list]) -> dict[str, object]:
        if set(values) == {'__root__'}:
            values = values['__root__']
            return {'x': values[0], 'y': values[1], 'z': 2 * values[0]}

        return values

assert Example.parse_obj([22, 'foo']) == Example(x=22, y='foo', z=44)

As you can see you need to add __custom_root_type__ to tell pydantic to act like __root__ was here. If it's not it will automatically be added. And then you need to handle both cases in your root_validator to still support default init.
My recommendation would be to use first example but depends on you ;)
Hope it helps!

Thanks @PrettyWood. Very helpful!

BTW: Personally I'd vote to keep __custom_root_type__. It seems much nicer to be able to refer to example.x rather than ExampleRoot.__root__. In my particular case the thing I want to construct via a list is nested so I wouldn't be able to do: example = ExampleRoot.parse_obj([...]).__root__. I'd end up having to do the_thing.nested_thing.__root__.x everywhere which is a big ugly.


Error message about NVCC and CXX flags

When compiling the CUDA kernel in MICM, I got the following warning message:
nvcc warning : The -std=c++20 flag is not supported with the configured host compiler. Flag will be ignored.

This may be an issue from CMake side.

Just ran a test build and it looks like this is only an issue when we compile *.cu files.  The rest of the library looks to build fine with -std=c++20 and doesn't have the error.
My suspicion was that it was a combination of cmake not giving it the proper flag (https://docs.nvidia.com/cuda/cuda-compiler-driver-nvcc/index.html#std-c-03-c-11-c-14-c-17-c-20-std) and nvcc but apparently, even even compiling with --std flag instead of -std still produces the error:
> nvcc -forward-unknown-to-host-compiler -DDEFAULT_VECTOR_SIZE=4 -DUSE_JSON -O3 -DNDEBUG --std=c++20 --generate-code=arch=compute_70,code=[compute_70,sm_70] -MD -MT test.cu.o -MF test.cu.o.d -x cu -c test.cu -o test.cu.o
nvcc warning : The -std=c++20 flag is not supported with the configured host compiler. Flag will be ignored.

This warning message is not observed in the GitHub Actions (e.g., https://github.com/NCAR/micm/actions/runs/9457328891/job/26050928184). Thus it seems to be a Derecho-specific issue (the nvhpc compiler is not built with the newer gcc version).


ENV['HOSTS'] filter ignores role restricted tasks

Given the following deploy.rb:
role :web, "one"
role :app, "two"
role :db,  "three"

task :foo, :roles => [:app, :web] do
  puts "Foo: #{find_servers_for_task(tasks[:foo]).map(&:host).map(&:to_s).join(',')}"
end

task :bar do
  puts "Bar: #{find_servers_for_task(tasks[:bar]).map(&:host).map(&:to_s).join(',')}"
end

task :baz, :roles => [:db] do
  puts "Baz: #{find_servers_for_task(tasks[:baz]).map(&:host).map(&:to_s).join(',')}"
end

before :bar, :foo

Then run the following:
$ cap bar
  * executing `bar'
  triggering before callbacks for `bar'
  * executing `foo'
Foo: two,one
Bar: three,one,two

$ cap bar HOSTS=three
  * executing `bar'
  triggering before callbacks for `bar'
  * executing `foo'
Foo: three
Bar: three

Why is it now invoking foo for three? So if I use the HOSTS filter, it will now ignore any task restrictions based on role. Certainly that cannot be the intended behavior with the HOSTS filter.

Using HOSTS means it runs every task against a given server. HOSTFILTER is what you want, but that does not appear to work in the latest capistrano release for me.

Looks like the host has to be the fully qualified domain name, not an alias in your /etc/hosts file. For example, the following does not work:
HOSTFILTER=foo bundle exec cap production deploy

But this does:
HOSTFILTER=foo.example.com bundle exec cap production deploy

HOSTS works as expected, as it gets returned since the check hosts.any? returns true and it doesn't go through extra filtering.


Add More Cpp Algorithms and Also try Some other Languages.

Try to add different algorithms in languages like-
1.Python
2.Java
3.Javascript
Create different folders for all the algorithms.
The code should be complete and clear.

Assign me.

Please assign me, I will add some CPP codes.

hello, Can you assign me this issue. I can do it all in C++.


Tower Road Canoe/Kayak Rental title showing up on map

Are there are any activities that you want names on the map for now?

No, I think the long term goal is to have a basemap with some helpful labels for rec waterbodies and larger preserves. Rendering the name adds to the clutter and I'm not sure it adds a lot that we couldn't accomplish more elegantly with the basemap.


Make debugging of ribasim_api easier

Martijn suggested we could add API to dump model state and extract from Python

@visr : can you add your ideas to this issue?

I don't really have many concrete ideas. It really depends on the kind of issues that couplers are running into. If those issues arise we can create concrete issues, and close this.
One issues that will help with this is #1351.


[Refactor] We may need a pre-processor for SQL component

For now, we have sql, manifest.json and post-processor.js for every SQL component, the configs in manifest.json file is used to render SQL query and report text.
But as the template engine(pope) we use is not powerful enough to handle complex data structure, so we may need a pre-processor.js file to process the configs to strings that can be directly used by SQL renderer which will give us more ability to form complex SQL.
Related to #251

/self-assign


FTI test seem to deadlock on github/centos

See https://github.com/pdidev/dockerfiles/runs/1535809938

CentOS tests removed


Bug-fix: attempting to update review comment from issue branch

There seems to be a call to update a review comment under the issue comment branch which leads to issue #47
This PR has been packaged and tested.

npm install could not run due to internal artifactory,
package-lock.json was regenerated with the same versions
the changes in dist/ might be incorrect


How is Kinetic Merge packaged?

The workflow tries to be as automatic as possible, and all interaction for resolving code motion divergences as per #6 uses a command line interaction - so presumably we just want a command that can be invoked from the shell.
Deliverable: a command kinetic_merge that uses some Scala or Java code to yield a successful status back to the shell.

The original plan was to build an uberjar with either sbt-assembly or sbt-proguard, but scala-cli seemed intriguing ... after a lot of faffing around, a project was set up with the core Scala sources being built by SBT, with a sibling scala-cli project that pulled in a published reference to the core artefact and produced a standalone executable.
That worked after a fashion, but the split wasn't really what I was after, and IntelliJ doesn't get on with the BSP definition generated by scala-cli. The build process also involved manual steps.
As it turns out, scala-cli delegates to Coursier to build a standalone executable, and it is is fairly straightforward to set up an SBT-only project that has a task that depends on publishLocal and then invokes Coursier to build the same kind of standalone executable from the locally published artefact.
So there is no longer any need to split the sources, and the build can be fully automated. Result.

Pushed out Git SHA: 7e86b699305d4a5d4f847bd0db87089bb7c652ab to complete this.


preset config option not recognized when there are projects

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
preset property in project config is ignored. Repro steps:
npm install -g jest
git clone -b jest-6026 https://github.com/melissachang/repro-issues.git
cd repro-issues
npm install
jest

Test fails because preset in package.json is not recognized.
 FAIL   e2e  tests/e2e/test.js
  ● Test suite failed to run

    ENOENT: no such file or directory, open '/tmp/jest_puppeteer_global_setup/wsEndpoint'

      at PuppeteerEnvironment.setup (node_modules/jest-environment-puppeteer/lib/PuppeteerEnvironment.js:32:37)

package.json:
  "jest": {
    "projects": [
      {
        "displayName": "unit",
        "testMatch": [
          "<rootDir>/tests/unit/*.test.js"
        ]
      },
      {
        "displayName": "e2e",
        "preset": "jest-puppeteer",
        "testMatch": [
          "<rootDir>/tests/e2e/*.js"
        ]
      }
    ]
  }

What is the expected behavior?
preset should be recognized when running tests/e2e/test.js.

Move preset out of projects:

  "jest": {
    "projects": [
      "preset": "jest-puppeteer",
      {
        "displayName": "unit",
        "testMatch": [
          "<rootDir>/tests/unit/*.test.js"
        ]
      },
      {
        "displayName": "e2e",
        "testMatch": [
          "<rootDir>/tests/e2e/*.js"
        ]
      }
    ]
  }

jest still fails. preset is still not recognized when running tests/e2e/test.js.

Delete projects:

  "jest": {
    "preset": "jest-puppeteer"
  }

Finally, jest passes. preset is recognized.
There are several bugs, besides this one, with project configuration: #5938, #5597, #5441, #5260. I'm sure some subset are dupes.
Please provide your exact Jest configuration
jest: v22.4.3
Run npx envinfo --preset jest in your project directory and paste the
results here
/tmp/repro-issues (jest *): npx envinfo --preset jest
npx: installed 1 in 1.381s
(node:23443) UnhandledPromiseRejectionWarning: TypeError: Cannot read property '1' of null
    at e.darwin.process.platform.linux.process.platform.c.run.then.e (/usr/local/google/home/melchang/.npm/_npx/23443/lib/node_modules/envinfo/dist/cli.js:2:94297)
    at <anonymous>
(node:23443) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:23443) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I am facing the same problem. Using two projects, where one specified a jest-puppeteer preset, I can observe the following:
. ENOENT: no such file or directory, open '/var/folders/6l/y62_166d6bgby7fpd_rzgfwh0000gp/T/jest_puppeteer_global_setup/wsEndpoint'

at PuppeteerEnvironment.setup (node_modules/jest-environment-puppeteer/lib/PuppeteerEnvironment.js:32:37)

It looks like this is not an issue with the preset option itself. If I copy the preset config directly into the project configuration the same error happens
{
  "devDependencies": {
    "jest-environment-node": "^22.0.0",
    "jest-puppeteer": "^2.3.0",
    "puppeteer": "^1.3.0"
  },
  "jest": {
    "projects": [
      {
        "displayName": "unit",
        "testMatch": ["<rootDir>/tests/unit/*.test.js"]
      },
      {
        "displayName": "e2e",
        "globalSetup": "jest-environment-puppeteer/setup",
        "globalTeardown": "jest-environment-puppeteer/teardown",
        "testEnvironment": "jest-environment-puppeteer",
        "setupTestFrameworkScriptFile": "expect-puppeteer",
        "testMatch": ["<rootDir>/tests/e2e/*.js"]
      }
    ]
  }
}

Duplicate of https://github.com/facebook/jest/issues/6292


[mesheryctl] Add prerequisite on docker daemon running status

Signed-off-by: Hussaina Begum Nandyala<EMAIL_ADDRESS>Description
mesheryctl: Add prerequisite on docker daemon running status
Modify start/stop/update/perf commands to run the PreReqCheck
to see if docker is running or not. Display appropriate informational
message if docker is not running or docker-compose command is not present.
This PR fixes #1697
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@leecalcote @Nikhil-Ladha @NupurThakur27 @sladyn98, Can you review the changes? I modified PreReqCheck function signature so that multiple mesheryctl system sub-commands can reuse the code.


adding convert button

json & wire convert button

Codecov Report

Merging #275 (fcdc8e9) into master (2580d55) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #275   +/-   ##
=======================================
  Coverage   74.82%   74.82%
=======================================
  Files          73       73
  Lines        8601     8601
=======================================
  Hits         6436     6436
  Misses       1593     1593
  Partials      572      572


FEATURE - schema changelog incremental materialization

Are you a Fivetran customer?

fivetran made issue, from TR
Is your feature request related to a problem? Please describe.

this model doesn't change after data is loaded into it, and it draws from the very hefty stg_fivetran_log__log model, so let's make it incremental
Please indicate the level of urgency and business impact of this request

Are you interested in contributing to this package?

[x] Yes, I can do this and open a PR for your review.
[ ] Possibly, but I'm not quite sure how to do this. I'd be happy to do a live coding session with someone to get this work implemented.
[ ] No, I'd prefer if someone else did this.  I don't have the time and/or don't know how to incorporate the changes necessary.

Hi all,
Just wanted to provide an update here that this is currently a working and functional branch that properly adds incremental logic to the changelog. Currently this issue has not been closed and the corresponding PR #35 has not been merged because there has not been enough interest into this feature.
If you would like this Feature added to a future release of this package, please comment below. Thanks!


vcpkg manifest mode silently fail if build path includes backslash

Describe the bug
vcpkg manifest mode silently fail if build path includes backslash
Environment

OS: Windows

To Reproduce
Create project that includes vcpkg.json (manifest mode)
Build using:
cmake.exe -B build\x64 -S . -D CMAKE_TOOLCHAIN_FILE='/vcpkg/scripts/buildsystems/vcpkg.cmake'
note backslash in build\x64. vcpkg.json won't be found and build will silently fail.
Expected behavior
This works in a non-vcpkg build, and cmake will put targets in the build\x64 folder, creating it if it doesn't exist.

PS E:\testsample\test_manifest> cmake -B build\x64 -S . -DCMAKE_TOOLCHAIN_FILE='E:/vcpkg01/scripts/buildsystems/vcpkg.cmake'
-- Building for: Visual Studio 17 2022
-- Running vcpkg install
Detecting compiler hash for triplet x64-windows...
The following packages will be built and installed:
    fmt[core]:x64-windows -> 9.0.0 -- E:\vcpkg01\buildtrees\versioning_\versions\fmt\9268e89cdadcbb0a54357f47b343004200970a02
    sqlite3[core]:x64-windows -> 3.39.1 -- E:\vcpkg01\buildtrees\versioning_\versions\sqlite3\ccab102efea1120dc2140b4c0519676a65c055b6
  * vcpkg-cmake[core]:x64-windows -> 2022-07-18 -- E:\vcpkg01\buildtrees\versioning_\versions\vcpkg-cmake\a7b618b7782f3c841d7fd2d84a6ba3619815362a
  * vcpkg-cmake-config[core]:x64-windows -> 2022-02-06#1 -- E:\vcpkg01\buildtrees\versioning_\versions\vcpkg-cmake-config\8d54cc4f487d51b655abec5f9c9c3f86ca83311f
    zlib[core]:x64-windows -> 1.2.11#11 -- E:\vcpkg01\buildtrees\versioning_\versions\zlib\ad5b59cd3722af26f09921297562dfc76c83dbf8
Additional packages (*) will be modified to complete this operation.
Restored 5 package(s) from C:\Users\monica\AppData\Local\vcpkg\archives in 201 ms. Use --debug to see more details.
Installing 1/5 vcpkg-cmake-config:x64-windows...
Elapsed time to handle vcpkg-cmake-config:x64-windows: 7.21 ms
Installing 2/5 vcpkg-cmake:x64-windows...
Elapsed time to handle vcpkg-cmake:x64-windows: 17.5 ms
Installing 3/5 fmt:x64-windows...
Elapsed time to handle fmt:x64-windows: 213 ms
Installing 4/5 sqlite3:x64-windows...
Elapsed time to handle sqlite3:x64-windows: 56.2 ms
Installing 5/5 zlib:x64-windows...
Elapsed time to handle zlib:x64-windows: 76.9 ms
Total install time: 571 ms
The package fmt provides CMake targets:

    find_package(fmt CONFIG REQUIRED)
    target_link_libraries(main PRIVATE fmt::fmt)

    # Or use the header-only version
    find_package(fmt CONFIG REQUIRED)
    target_link_libraries(main PRIVATE fmt::fmt-header-only)

sqlite3 provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(unofficial-sqlite3 CONFIG REQUIRED)
    target_link_libraries(main PRIVATE unofficial::sqlite3::sqlite3)

The package zlib is compatible with built-in CMake targets:

    find_package(ZLIB REQUIRED)
    target_link_libraries(main PRIVATE ZLIB::ZLIB)

-- Running vcpkg install - done
-- Selecting Windows SDK version 10.0.22621.0 to target Windows 10.0.19045.
-- The CXX compiler identification is MSVC 19.35.32216.1
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found ZLIB: optimized;E:/testsample/test_manifest/build/x64/vcpkg_installed/x64-windows/lib/zlib.lib;debug;E:/testsample/test_manifest/build/x64/vcpkg_installed/x64-windows/debug/lib/zlibd.lib (found version "1.2.11")
-- Configuring done
-- Generating done
-- Build files have been written to: E:/testsample/test_manifest/build/x64

I'm also using backslashes, doesn't seem to be the problem with it.
I noticed that there seems to be something wrong with the path of your CMAKE_TOOLCHAIN_FILE.

cmake.exe -B build\x64 -S . -D CMAKE_TOOLCHAIN_FILE='/vcpkg/scripts/buildsystems/vcpkg.cmake'

If the issue persists, please attach a detailed error log.

@JeffMill

i've moved onto some other work at the moment. When I get a chance, I'll create an error log. thanks!


Remove connect function and remove it from the docs as well

We don't need it. It is an extra step that is unnecessary since we don't have persistent connections. We are stateless.

One big thing I would consider is backward compatibility and also right now we need it to connect to a specific database. Plus, it will ping the server to check if it exists (see dev branch) and if the db exists. So I cannot agree with the point for it being unnecessary.

The issue was created because the connect function in the JavaScript isn't needed, but it is used in Python, and it is documented. So, we will not change this now.


IMPORT/RESTORE rate limiting

Context: If we use 100% of available IO capacity to do bulk IO in IMPORT or RESTORE, we currently make nodes temporarily slow or even unhealthy (liveness failures). This can interfere with those operations directly -- e.g. IMPORT will start over currently, and may be unable to finish -- but in general though, IMPORT jobs are likely to be run on production clusters, where we should try to avoid impacting the health of the cluster or its ability to serve traffic.
To avoid this, we default to limiting the write rate of bulk IO operations with a setting, but the correct value for this setting depends on the hardware's IO capacity for any individual cluster, any other tasks using that IO capacity, the other load on the cockroach nodes, etc. so a one-size-fits-all value is hard to pick here.
We're going to pick a default rate limit based on the expected performance of our recommended cloud hardware

[ ] In the recommended hardware docs, we should note that if your hardware is different, you may want to tune the setting accordingly.
[ ] In IMPORT docs, we should note that if your cluster is under heavy production load, you may want to lower the limit, such that it does not exceed your spare IO capacity.
[ ] A RESTORE operation might want to go as fast as possible, regardless of impact on cluster health / ability to serve other traffic, e.g. if you're recovering from backup to get back online or provision a new cluster. In the RESTORE docs, we should note that you can up the setting to let the restore go faster in these cases.

We might also want to provide an example of how to tune the setting (cc @mberhault for ideas here):

benchmarking your device's throughput with something like dd and taking some percentage of that
looking at utilization with something like iostat or other monitoring to determine if you need to lower it

@dt, @dianasaur323, I think it's realistic to get the 3 checkbox items covered for 2.0 but not the detailed guidance around how to benchmark and tune the setting. That's too involved for the time we have left, given the other projects on our plate. OK if I split that work into a separate issue for 2.1?

Also, @dianasaur323, it'd be great to represent this work on the roadmap, if possible, that is, picking and implementing a default rate limit for 2.0.

oh, and yeah, I don't think we need to have examples of how to tune the setting in the docs by 2.0, it'd just be nice to have in the bulk io docs at some point. In the short term, I imagine we'll have a GitHub issue where we (eng) figure what that process even is, and we can point anyone who asks at that until we have something we think is ready to doc.

Some additional things to capture here are in interaction between the write_rate limit and the concurrent request limits -- e.g. we don't let too many import requests in at once since they'd all fetch and buffer data just to then wait to write it.

We have closed this issue because it is more than 3 years
old. If this issue is still relevant, please add a comment and re-open
the issue. Thank you for your contribution to CockroachDB docs!


lib/src/structs.dart:614:7: Error: Field 'hPhysicalMonitor' should be initialized because its type 'int' doesn't allow null.

dart version
2.12.0-205.0.dev
When I run example ,shows below
lib/src/structs.dart:614:7: Error: Field 'hPhysicalMonitor' should be initialized because its type 'int' doesn't allow null.
int hPhysicalMonitor;
^^^^^^^^^^^^^^^^
lib/src/structs.dart:3011:7: Error: Field 'Internal' should be initialized because its type 'int' doesn't allow null.
int Internal;
^^^^^^^^
lib/src/structs.dart:3014:7: Error: Field 'InternalHigh' should be initialized because its type 'int' doesn't allow null.
int InternalHigh;
^^^^^^^^^^^^
lib/src/structs.dart:3016:11: Error: Field 'pointer' should be initialized because its type 'Pointer' doesn't allow null.

'Pointer' is from 'dart:ffi'.
'NativeType' is from 'dart:ffi'.
Pointer pointer;
^^^^^^^
lib/src/structs.dart:3019:7: Error: Field 'hEvent' should be initialized because its type 'int' doesn't allow null.
int hEvent;
^^^^^^

Temporary solution

Temporary solution

Yeah, thanks -- that's a regression that I hadn't tested for. Should be fixed now.

Yeah, thanks -- that's a regression that I hadn't tested for. Should be fixed now.


Add nginx-route how-to docs

Add nginx-route relation how-to to the charm.

This PR will have to wait for https://github.com/canonical/nginx-ingress-integrator-operator/pull/91 to be merged before being merged as it mentions nginx-ingress-integrator for the ingress relation


Do I need fastify-sentry if I am using @sentry/opentelemetry?

I am not clear whether fastify-sentry is needed if I am already using @sentry/opentelemetry, and my goal is to just capture performance traces. As far as I understand, @opentelemetry/auto-instrumentations-node already handles instrumentation for us.

Hey @md384 this is intentional! When you set instrumenter: 'otel' to be the configuration in your Sentry.init, we expect you to use the otel APIs to create/read span, and not rely on startTransaction or getTransaction.

https://github.com/getsentry/sentry-javascript/issues/7985#issuecomment-1529060940


clean-yarn-cache: Remove the active yarn cache if its bit older.

Link to CZO Thread
Testing plan:
Tested it locally ✅ .
GIFs or screenshots:

@Riken-Shah are you up for rebasing this? I was recently reminded of it from someone complaining about a giant yarn cache in production.

Closing, since we migrated off Yarn to pnpm.


Upgrading jackson versions (#216)

Upgrading jackson versions

Signed-off-by: Sagar Upadhyaya<EMAIL_ADDRESS>
Fixing dockerfile typo issue

Signed-off-by: Sagar Upadhyaya<EMAIL_ADDRESS>Signed-off-by: Sagar Upadhyaya<EMAIL_ADDRESS>Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Upgrading jackson versions (#216)
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #219 (3ed6e9f) into 2.2 (f4a149d) will decrease coverage by 0.00%.
The diff coverage is n/a.

:exclamation: Current head 3ed6e9f differs from pull request most recent head 3167314. Consider uploading reports for the commit 3167314 to get more accurate results

@@             Coverage Diff              @@
##                2.2     #219      +/-   ##
============================================
- Coverage     71.53%   71.52%   -0.01%
+ Complexity     2987     2985       -2
============================================
  Files           380      380
  Lines         18952    18952
  Branches       1463     1463
============================================
- Hits          13557    13556       -1
+ Misses         4800     4799       -1
- Partials        595      597       +2

Impacted Files
Coverage Δ

...nalyzer/rca/net/handler/PublishRequestHandler.java
73.46% <0.00%> (-10.21%)
:arrow_down:

...ceanalyzer/rca/store/rca/hotshard/HotShardRca.java
86.13% <0.00%> (-1.00%)
:arrow_down:

...performanceanalyzer/collectors/StatsCollector.java
92.59% <0.00%> (-0.75%)
:arrow_down:

.../org/opensearch/performanceanalyzer/core/Util.java
70.83% <0.00%> (+8.33%)
:arrow_up:

...nceanalyzer/rca/samplers/MetricsDBFileSampler.java
84.09% <0.00%> (+9.09%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

updateShas will pass after this PR is merged.


Whats about Minecraft? Its a Game everybody has, why not? For PVP I could be nice :D

Whats about Minecraft? Its a Game everybody has, why not? For PVP I could be nice :D

It's been a while since I've made a Minecraft mod. I can look into it, but I don't know if it will work very well.

Just use the Razer Minecraft mod with the Aurora Razer wrapper? (There is also a mod for Steelseries Gamesense.)
I don't know if Razer ChromaSync works with the Razer wrapper.

I would love this.
I think of displaying health, hunger, and perhaps the keyboard background color adapting to the current time of the day (fading from blue to bright yellow e.g.)

that would be awesome, I tried to find a way to use the chromacraft mod with aurora but since my experience with code is nonexistent I got no luck

Support has been added with PR #1213


convolve function added

Description
This function combines both convolve_rows and convolve_cols into a single call for user convenience.
The need for such function came into the sight when @miralshah365 was implementing adaptive_threshold and encountered error due to multiple calls to convolve function with the same source instead of using the result of the first convolution as the source for other.
Tasklist

[ ] Add test case(s)
[x] Ensure all CI builds pass
[x] Review and approve

I believe the names are a bit misleading. My first impression was that kernel is allowed to be 2D, but user would have to wait for compilation error or figure out the logic by some other way. Some combination of words "pipe", "2dir" or something like that would be helpful.
It might be me being a bit picky though, looks good otherwise.

@simmplecoder

I believe the names are a bit misleading.

What names?

My first impression was that kernel is allowed to be 2D,

A KernelConcept would have been helpful indeed.

@mloskot
I mean function and kernel names. May be being a bit more specific would help, but I cannot think of a succinct enough name

@simmplecoder Right. TBH, I did not find the function names too confusing myself, but I did find the kernel_2d{_fixed} not well documented or intuitive. Well, that's how original authors from Adobe defined it. It's our job to improve it :)


Start implementing static react page and components

Creating the react app and installing the necessary dependencies for our project (Chart.js, express.js, postgre-sql, axios, react-router-dom)


fix: add token expires for system

What does this PR do?
add token expires for system
Motivation
Additional Notes

@WaterLemons2k 看下


feat(MenuItem): add new prop icon

FX-3128
Description
Add new prop icon to Menu.Item to allow rendering any icon inside the Dropdown menu
How to test

check temploy and compare with design
check Happo changes

Screenshots

Development checks

[x] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Make sure that additions and changes on design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[x] Annotate all props in component with documentation
[x] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
[x] Covered with tests

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-anvil ping reviewers

I haven't test the code, code looks fine for me


:arrow_up: Upgrade pydid (pydantic v2)

Testing pydid upgrade to pydantic v2: https://github.com/Indicio-tech/pydid/pull/72
Edit: Great! All checks have passed. Marking as draft until pydid update is released

@ff137 I think this should be ready for review now; would you be able to regenerate the lock file?

@dbluhm Nice! I missed that 0.5.0 was released. I'll rebase 👍
One thing to keep in mind is that the acapy-plugins will need to also be upgrade to pydantic v2, to ensure compatibility.

@jamshale @amanji heads up on @ff137's point. Do you anticipate any challenges with the plugins you maintain?
I think there would be a conflict with the pickup plugin we maintain. We haven't done major updates to that plugin in a while though so maybe it's just time to retire it.

I don't think it would affect DRPC

FWIW the redis-events plugin uses pydantic v1, and we did an upgrade for that when testing this release. So I can contribute pydantic V2 for that one plugin. Can help with the others too, because I've memorised a lot of the migration steps :-)

Yes. I think some plugins will need to be updated. I know the oid4vci plugin has a pydantic dependency.
We have the release management system merged for the plugin repo just now, so the upgrades could be prepared and then merged after the aca-py release.

This is why the release management should help. If we don't update a plugin and retire it. It is now tagged with 0.12.1 (All plugins are currently passing). It can just be left behind unless we chose to upgrade it. No need to remove it or anything.


Add schema support for jsconfig.json to TypeScript extension

VSCode Version: 1.7.2

Looks like this has already been added to the JavaScript extension: https://github.com/Microsoft/vscode/blob/master/extensions/javascript/package.json#L101
I confirmed that we get validation for jsconfig.json files.

Cool. Thanks.

Verified that this is in vscode\extensions\javascript\package.json


Truncate automatically for the embeddings endpoint

System Info
I would like to suggest an important improvement for the "text-embedding-inference" repository, specifically for the "embeddings" endpoint.
Currently, the endpoint calculates text embeddings based on the input tokens. However, when the number of tokens in a given sentence exceeds the maximum token limit, the endpoint sends a error back to the user, e.g. "Input validation error: inputs must have less than 512 tokens. Given: 527". This make it difficult for users to find the right number of words or cutting point in a given sentence.
To improve user experience and ensure better transparency, I propose adding a warning mechanism to the "embeddings" endpoint replacing the error and returning the embedding based on the truncated sentence. This would notify users when their input sentences are truncated due to the maximum token limit being reached. However, the endpoint can still have the openai compatible form.
Thank you for considering this suggestion. I am looking forward to your feedback and the potential implementation of this feature.
Best regards,
Sebastian
Information

[ ] Docker
[X] The CLI directly

Tasks

[ ] An officially supported command
[ ] My own modifications

Reproduction
curl -X 'POST'
'https://<IP_ADDRESS>/v1/embeddings'
-H 'accept: application/json'
-H 'Content-Type: application/json'
-d '{
"model": "bge-large-en-v1.5",
"input": [
"Sure, Id be happy to help you generate a text of around 500 words. Here is an example of a text on the topic of 5G technology and its potential impact on various industries Sure, Id be happy to help you generate a text of around 500 words. Here is an example of a text on the topic of 5G technology and its potential impact on various industries Sure, Id be happy to help you generate a text of around 500 words. Here is an example of a text on the topic of 5G technology and its potential impact on various industries Sure, Id be happy to help you generate a text of around 500 words. Here is an example of a text on the topic of 5G technology and its potential impact on various indsSure, Id be happy to help you generate a text of around 500 words. Here is an example of a text on the topic of 5G technology and its potential impact on various industries Sure, Id be happy to help you generate a text of around 500 words. Here is an example of a text on the topic of 5G technology and its potential impact on various industries Sure, Id be happy to help you generate a text of around 500 words. Here is an example of a text on the topic of 5G technology and its potential impact on various industries Sure, Id be happy to help you generate a text of around 500 words. Here is an example of a text on the topic of 5G technology and its potential impact on various indsSure, Id be happy to help you generate a text of around 500 words. Here is an example of a text on the topic of 5G technology and its potential impact on various industries Sure, Id be happy to help you generate a text of around 500 words. Here is an example of a text on the topic of 5G technology and its potential impact on various industries Sure, Id be happy to help you generate a text of around 500 words. Here is an example of a text on the topic of 5G technology and its potential impact on various industries Sure, Id be happy to help you generate a text of around 500 words. Here is an example of a text on the topic of 5G technology and its potential impact on various indsSure, Id be happy to help you generate a text of around 500 words. Here is an example of a text on the topic of 5G technology and its potential impact on various industries Sure, Id be happy to help you generate a text of around 500 words. Here is an example of a text on the topic of 5G technology and its potential impact on various industries Sure, Id be happy to help you generate a text of around 500 words. Here is an example of a text on the topic of 5G technology and its potential impact on various industries Sure, Id be happy to help you generate a text of around 500 words. Here is an example of a text on the topic of 5G technology and its potential impact on various inds"
],
"user": "string"
}'
Error Message:
{
"message": "Input validation error: inputs must have less than 512 tokens. Given: 598",
"code": 413,
"type": "Validation"
}
Expected behavior
Here are some possible solutions:

Return a warning message in the API response, indicating that the input sentence was truncated and how many tokens were retained.

Hi, a header is a flag I have to set when executing "text-embeddings-router"?
However, any possibility to set a truncation without enforcing the user to
calculate the right number of words would be very helpful.
Thank you very much, your
Sebastian Engel
OlivierDehaene @.***> schrieb am Mi., 27. März 2024,
12:03:

We can add a header if you want but the API will not change.
Would a x-truncated=86 (86 being the number of truncated tokens) header
be enough for your use case?
—
Reply to this email directly, view it on GitHub
https://github.com/huggingface/text-embeddings-inference/issues/218#issuecomment-2022488591,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMVYJSLY7KBHSH5N2FJARRLY2KKNLAVCNFSM6AAAAABFJHLZ52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRSGQ4DQNJZGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi, thank you very much for the implementation. However, i still have the same tuncation error when i set the auto-truncate flag. I.e. i have used the following command to start the embedding application (i.e. used --auto-truncate):
text-embeddings-router --port 3000 --tokenization-workers 8 --auto-truncate --pooling cls --model-id WhereIsAI/UAE-Large-V1 --revision cf14327dbfe6270e4f6feb5fd0f436d85f90c4cc
The service starts and when i use the "v1/embeddings" endpoint i still get the token size error as described above.
Error:
{
"message": "Input validation error: inputs must have less than 512 tokens. Given: 1038",
"code": 413,
"type": "Validation"
}
For the request (to v1/embeddings):
{
"input": "string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strinstring strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strinstring strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strinstring strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strinstring strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strinstring strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strinstring strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strinstring strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strinstring strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strinstring strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strinstring strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strinstring strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strinstring strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strinstring strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strinstring strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strinstring strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strinstring strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin string strin strin strinstrinstrin strin strin",
"model": "WhereIsAI/UAE-Large-V1",
"user": "null"
}

Oh yes I went a bit too fast my bad.

Hi, Thank you very much :)
Am Do., 4. Apr. 2024 um 10:35 Uhr schrieb OlivierDehaene <
@.***>:

Oh yes I went a bit too fast my bad.
—
Reply to this email directly, view it on GitHub
https://github.com/huggingface/text-embeddings-inference/issues/218#issuecomment-2036538923,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMVYJSKXDA44NM2F5KAKCITY3UGGHAVCNFSM6AAAAABFJHLZ52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZWGUZTQOJSGM
.
You are receiving this because you authored the thread.Message ID:
@.***>


Why is taggable_id incrementing so fast?

I retrieved 54 items from my database:
items = Item.where(condition)
items.count == 54
and then:
items.each {|i| i.tag_list.add("tag")}
But:
ActsAsTaggableOn::Tagging.pluck(:taggable_id)
Returns this array of taggable_id:
[0, 0, 1, 1, 2, 2, 4, 4, 5, 5, 6, 6, 7, 7, 9, 9, 15, 15, 18, 18, 24, 25, 25, 32, 32, 38, 38, 49, 49, 74, 74, 93, 93, 96, 96, 99, 99, 363, 363, 583, 583, 854, 926, 926, 939, 939, 5276, 5276, 22118, 22118, 48474, 48474, 80172, 624486, 624486, 28184633, 28184633]

No idea , that application specific. It the ids of your items.

May the problem be that i'm using strings in my items primary key?

yes. AR will cast them to match the taggable_id field type.


Rework CLI interface

This reworks the CLI of the tool to allow specifiying or overriding the function parameters of the tool on the command-line.
To make this feasible, I needed named parameters for the jsonToGo() function. In order to not break existing integrations, I named the new function jsonToGov2(). This is currently fully backwards compatible (as the tests show).
@mholt What do you think about the change? Do you have a better name in mind? This is particular about the first commit 4fad829245d692386fc4a3a24b75e93f9c55a941
The other commits are just improvements on the CLI, as well as a backwards-compatibility integration of v1: 0f504683d468d866c3939f2ea4358b4c2b35463f

If you prefer a single file solution (because someone has embedded this into their project using a raw GitHub link to the file), we can of course also create a wrapper function that checks if the second argument is type object and then goes the v2 route, else goes the v1 route.
Let me know what you think.


Custom Properties does not work in polyfilled browsers

As you can see here https://github.com/Starcounter/underwear.css/blob/master/underwear.css#L1
Build process joins :host{ and :root{rules, to:host,:root{`
What totally breaks any app in polyfilled browser.

Done in https://github.com/Starcounter/underwear.css/pull/49.


Added margin on page where content is hidden

title :  Upper content get hidden under navbar
Issue No. : #362
Code Stack :
Close #362
https://github.com/user-attachments/assets/58f51a45-9498-4727-8141-330a27361810
Checklist:

[ X] I have mentioned the issue number in my Pull Request.
[ X] I have commented my code, particularly in hard-to-understand areas
[ X] I have created a helpful and easy to understand README.md if its a new page/tech stack
[ X] I have gone through the  contributing.md file before contributing

Additional context (Mandatory )
Are you contributing under any Open-source programme?

[ X] I'm a GSSOC-EXT contributor
[ X] I'm a HACKTOBERFEST contributor

@Sawan-Kushwah resolve conflicts

@jeevan10017 i have resolved conflicts


Failed to detect null derreference in nested C block

Please include the following information:

[x] The version of infer from infer --version.
[x] Your operating system and version, for example "Debian 9", "MacOS High Sierra", whether you are using Docker, etc.
[x] Which command you ran, for example infer -- make.
[x] The full output in a paste, for instance a gist.
[x] If possible, a minimal example to reproduce your problem (for instance, some code where
infer reports incorrectly, together with the way you run infer to reproduce the incorrect
report).

When trying this example:
#define NULL 0
#define KABOOM()  *(char*)(NULL) = 'a'

typedef int GUID;
typedef int EFI_HANDLE;
typedef int EFI_STATUS;
typedef unsigned int UINTN;

static const int someConstant = 0x74D936FA;
extern int gVar2;
extern int gVar1;
#ifndef __fastcall
#   define __fastcall
#endif

struct
{
    EFI_STATUS (*funPtr)(const GUID* guid, int arg, int* outProtocol);
} *gVar3;

EFI_STATUS __fastcall SmiHandler(EFI_HANDLE DispatchHandle, const void *Context, void *CommBuffer, UINTN *CommBufferSize)
{
    KABOOM();
    if ( CommBuffer && CommBufferSize && !gVar1 )
    {
        if ( !gVar2 )
        {
            if ((gVar3->funPtr)(&someConstant, 0, &gVar2) < 0 )
            {
                KABOOM();
            }
        }
    }
    (void)DispatchHandle;
    (void)Context;
    return 0;
}

infer correctly detects the first null derreference (KABOOM), but not the second.
Infer version: 1.1.0
OS: WSL 2, Ubuntu 22.04.1, downloaded linux binary
Command: infer run --starvation --linters --biabduction --bufferoverrun --siof --pulse --annotation-reachability --liveness --loop-hoisting --quandary --uninit -- clang -c bug_infer.c
Output:
bug_infer.c:23: error: Nullptr Dereference
  Pulse found a potential null pointer dereference  on line 23.
  21. EFI_STATUS __fastcall SmiHandler(EFI_HANDLE DispatchHandle, const void *Context, void *CommBuffer, UINTN *CommBufferSize)
  22. {
  23.     KABOOM();
          ^
  24.     if ( CommBuffer && CommBufferSize && !gVar1 )
  25.     {

Found 1 issue
                Issue Type(ISSUED_TYPE_ID): #
  Nullptr Dereference(NULLPTR_DEREFERENCE): 1

CC @qequ

Datum: infer does detect an uninitialized read instead of the null pointer derref.

The analysis stops after errors such as null dereference so no memory bug will be detected after the first KABOOM(). If I comment it out I get a report about the second one by both pulse and biabduction. However, since it depends on the values of global variables, pulse classifies it as "latent" and biabduction gives it a low-confidence bucket (B5):
$ infer --pulse-only -F -g  --biabduction -- clang -c issue1685.c
issue1685.c:30: warning: Biabduction Analysis Stops
  exception: NULL_DEREFERENCE.
  28.             if ((gVar3->funPtr)(&someConstant, 0, &gVar2) < 0 )
  29.             {
  30.                 KABOOM();
                      ^
  31.             }
  32.         }

issue1685.c:30: error: Null Dereference
  null (last assigned on line 28) is dereferenced.
  28.             if ((gVar3->funPtr)(&someConstant, 0, &gVar2) < 0 )
  29.             {
  30.                 KABOOM();
                      ^
  31.             }
  32.         }

issue1685.c:30: error: Null Dereference
  [B5] pointer `*null` could be null and is dereferenced at line 30, column 17.
  28.             if ((gVar3->funPtr)(&someConstant, 0, &gVar2) < 0 )
  29.             {
  30.                 KABOOM();
                      ^
  31.             }
  32.         }

Found 3 issues
                              Issue Type(ISSUED_TYPE_ID): #
                      Null Dereference(NULL_DEREFERENCE): 1
            Null Dereference(NULLPTR_DEREFERENCE_LATENT): 1
  Biabduction Analysis Stops(BIABDUCTION_ANALYSIS_STOPS): 1

The reason that pulse and biabduction stop the analysis on such errors is because they model the memory behaviour of the program precisely and when something goes wrong like null is dereferenced then it's not clear how to recover a coherent abstract state. Also, if the analysis is right and there is a null deref then nothing after it will get executed, and if it's wrong then it is already confused about what's happening and so it's probably better to stop there too.

@dgutson maybe on 1.1.0 pulse doesn't find the issue for some reason, I tried with the latest main branch (which should be stable enough to use as a rule) with your command and the error does get reported.
Note that --biabduction --pulse-only will run only pulse as command line arguments are interpreted in sequence.

@jvillard what do you mean by "interpreted in sequence"? Does it mean that order matters? That would be a bit unexpected that the analysis changes depending on the order of the cli args.
Am I missing something?


"Watched Repositories" in settings or something

Would be great to be able to admin your watched repos all in one view. I think this would belong in settings?

I think this should be part of the user tab once we get that! (User profiles)
Sent with GitHawk


[Staging] Acceptance Stores not available

Describe the bug
On staging the acceptance stores can't be opened. The popup doesn't show up and the detail view does not work
To Reproduce
Steps to reproduce the behavior:

Go to "Über"
Enable staging
Go to Map
Click on an acceptance store
Check no acceptance stores

Expected behavior
The popup opens and you can click on it to see details of the stores

https://git.tuerantuer.org/DF/salt/pulls/70

@michael-markl hm now we can see the stores under search but on the map are no clusters nor acceptance stores on staging. any ideas about that? I added the staging url in this salt pr above but this seem not to work?
Or is this related to the mapStyleUrl ?
https://api.staging.entitlementcard.app/project/bayern.ehrenamtskarte.app/map
The content seem to be fine

No, I am not sure what happens. However, I am bit confused: If I switch to the staging endpoint on the production app and restart the app, it does not keep using the staging endpoint. Is this a bug?

hm are you on 3.1.4? just tested this on ios and i'm still on staging after restart

Oh, it does seems to work now. No idea, what happened, probably I was just somehow confused 😅
But the map does not show accepting stores for me too. Not idea why currently.

this was fixed by @svenseeberg :)
related to some missing permission of the martin database


As a curator I want to see "inferred combination" under "unpublished" invalid taxon names in Task - Browse nomencalture

By concensus we will experiment with adding the text under or beside a invalid (yellow header) name.

We can experiment with the title. Use more detailed lable, something like:
Aus bus Author now Bus cus (Author).
Where Aus bus - original combination of a synonym or a subsequent combination,
Bus cus - current combination of the valid name.

Everyone (8+ people) agreed to try the simple "inferred combination".  Let's try that first.

Well, there are two things to consider:

do not display this message if the type is "Combination"
do not display this message if the type is Protonym and cached_primary_homonym == cached_secondary_homonym.


[BUG] Module not found when using latest version

Are you using the latest version of this library?

[X] I verified that the issue exists in the latest next-safe-action release

Is there an existing issue for this?

[X] I have searched the existing issues and found nothing that matches

Describe the bug
After updating from 7.1.3 to 7.2.1 I get the following error:
 ⨯ ./node_modules/next-safe-action/dist/index.mjs:1:1
Module not found: Can't resolve './adapters/zod'
> 1 | import { zodAdapter } from "./adapters/zod";
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  2 | import { SafeActionClient } from "./safe-action-client";
  3 | import { DEFAULT_SERVER_ERROR_MESSAGE } from "./utils";
  4 | import {

Reproduction steps
Server action with zod schema.
Expected behavior
No error.
Minimal reproduction example
Private repo
Operating System
Windows 11
Library version
v7.2.1
Next.js version
15.0.0-canary.72
Additional context
No response

Need a minimal reproduction example, because I can run and build the project fine, even with Next.js 15:

Yeah, but I need a link to a repo to investigate on this issue, otherwise it's pretty difficult, since it works fine for me. Should be pretty easy to set up a minimal project.

Update: please let me know if v7.2.2-beta.1 solves your issue, thanks. You can install it with:
npm i next-safe-action@beta # or pnpm, yarn

I re-enabled bundling, Windows might not like it turned off.

The issue only happens when using --turbo. The same code without --turbo works.

Ah, that's very interesting, thank you for your feedback! Gonna merge beta into main right now and release v7.2.2 stable.

Thank you!


Reword HIR intro

Fix #116
@Michael-F-Bryan @3442853561 Let me know what you think.

Great! I like this version. You can ask @KiChjang 's opinion. He also speaks Chinese

@3442853561 @KiChjang Thanks for the feedback!


Error detected while processing pre-vimrc command line when enable bat as default previewer

Info

Operating System: macOS
Shell: fishshell
Terminal: alacritty
nvim --version:
NVIM v0.9.0-dev-726+gddd69a6c8-dirty
Build type: Release
LuaJIT 2.1.0-beta3
fzf --version: 0.36.0 (brew)

[ ] The issue is reproducible with mini.sh

fzf-lua configuration

require('fzf-lua').setup({
-- all default settings except
-- ...
    preview = {
        default = "bat"
        -- ...
    }
})

Description
Bat command is available when directly use in terminal.
Here I just move the config into another file and require it from the init.lua file for lazy.nvim.
-- init.lua
return {
    "ibhagwan/fzf-lua"
    config = function()
        require("plugins.fzf.config").setup()
    end
}

-- config.lua
local M = {}
M.setup = function
    -- ...
    require('fzf-lua').setup({
        -- all default settings except
        -- ...
        preview = {
            default = "bat" -- everything works fine if use the builtin previewer
            -- ...
        }
    })
    --...
end

return M

Few questions:

Does the default builtin preview work?
Does this happen on all files or just neovim files?
Does config.lua contain a neovim modeline?
What happens if you try to run bat ~/.config/nvim/config.lua in the shell?

Yes, with the default builtin previewer

All files

Not truly understand the question, but this is the config file. Barely nothing just call the setup function.

It works as expected with bat path/to/config.lua

There was an error message in the preview section: E5107: Error loading lua [string ":lua"]:1  ')' expected near '=' when navigating between files with arrow keys, but quickly disappeared.

I can’t seem to reproduce this with fish shell, more questions:

What’s the output of fish --version
Can you try setting the previewer to bat_async instead?
Can you try running export SHELL=/bin/bash before running neovim?
Can you try with the latest stable neovim 0.8.2 (can download an app image quickly from here?

fish, version 3.6.0
setting bat_async works

Would try the other two later if necessary.

If you’re satisfied with the bat_async workaround that’s ok, I’d still like to the get to why this happens as opposed to applying a workaround.

If you’re satisfied with the bat_async workaround that’s ok, I’d still like to the get to why this happens as opposed to applying a workaround.

issue persists
issue persists

I guess this isn’t fish related, can you run :FzfLua files previewer=bat debug=true and then press F3 to enable the preview line wrap (so I can inspect the full command) and post a screenshot of the preview debug info?
Should look like this:

I guess this isn’t fish related, can you run :FzfLua files previewer=bat debug=true and then press F3 to enable the preview line wrap (so I can inspect the full command) and post a screenshot of the preview debug info?
Should look like this:

Hi, I was unable to wrap it. I saw F3 is only for builtin previewer? Function keys are bounded on macOS. I changed it to S-down, but didn't work, I guess this is all the commands?

Hi, I was unable to wrap it. I saw F3 is only for builtin previewer? Function keys are bounded on macOS. I changed it to S-down, but didn't work, I guess this is all the commands?

Given we’re using the bat previewer which is using the fzf preview capability only the preview binds under keymap.fzf would work, Fzf does have a toggle-preview-wrap bind and would have worked under keymap.fzf but it wouldn’t matter much here since I don’t see the debug output at all in the preview window.
The way the bat previewer works is by running bat <args> $(neovim --headless … <selected line>), the latter part used to extract the filename from the entry (strip icons, lines, columns, etc) and the command fails with the error you’re being displayed, I’m trying to think of new ways  else to debug this without a special branch with extra debug outputs.

Another way to enable preview line wrap with Fzf  is to set winopts.preview.wrap = 'wrap' (default is nowrap) , maybe there is a more insightful error message after the  …pre-vimrc command line: error?

Another way to enable preview line wrap with Fzf is to set winopts.preview.wrap = 'wrap' (default is nowrap) , maybe there is a more insightful error message after the …pre-vimrc command line: error?

Still the same, the error message is like mentioned here, couldn't capture it cause it only showed when navigating between files.
You can see the opts in the background. Tried both setting wrap and also remapping the keys.

There was an error message in the preview section: E5107: Error loading lua [string ":lua"]:1 ')' expected near '=' when navigating between files with arrow keys, but quickly disappeared.

I tried re-installing the plugin, but it still persists. I previously used Linux and worked fine. I would try switching back to Linux using the same config later.

I tried re-installing the plugin, but it still persists. I previously used Linux and worked fine. I would try switching back to Linux using the same config later.

I doubt this is an installation issue and also pretty sure this will work fine on your Linux box, when I get access to my computer I’ll send you a few commands to test from the command line that would hopefully help us isolate the issue.

Can you test all of the below and tell me which one (if any) fails on your setup from a fish shell?

The preview window should display the filename, complexity of preview command increases as you go down in the list, the last command is similar to what is being run with the bat previewer

rg --files | fzf --preview-window=nohidden:right:50% --preview="echo {}"
rg --files | fzf --preview-window=nohidden:right:50% --preview='sh -c "echo {}"'
rg --files | fzf --preview-window=nohidden:right:50% --preview='sh -c "echo $(echo inner {})"'
rg --files | fzf --preview-window=nohidden:right:50% --preview='sh -c "nvim --headless --clean --cmd \"lua io.stdout:write({});os.exit(0)\""'

Another thing that will help is if you can run the bat preview and have it fail and while the fzf-lua is open run ps -ef | grep fzf and paste here the entire fzf command, that way we can see what exactly fails on your system.

Hello,
all 5 commands were working fine run in fish.
the output from last command

I didn't understand the exact steps in the 2nd part, so not sure if this is the expected output.

all 5 commands were working fine run in fish.

Tysm for testing!

I didn't understand the exact steps in the 2nd part, so not sure if this is the expected output.

Sorry for not being more clear, I want to see what is the exact background command that's running while the bug is present, hopefully these are clearer instructions:

Restore fzf-lua config to use bat (so that the preview fails)
Have 2 terminal windows open (Side by side or different desktops, doesn't matter)
In one terminal run neovim and open fzf-lua, navigate to a file where it the preview fails
While fzf-lua is open on one terminal run ps -ef | grep fzf on the other terminal and post the output

Actually don't worry about it any longer, I was able to reprpduce this, the soluition will be fast tracked from here on :-)
Ty for your help! I'll keep you posted when this is solved.

Can you update to the latest commit (https://github.com/ibhagwan/fzf-lua/commit/c25c3f210670b5539ccff527e9702127d27cc322) and let me know if this solves the issue for you?

Can you update to the latest commit (c25c3f2) and let me know if this solves the issue for you?

Great, it's fixed with this commit. Thanks!

Can you update to the latest commit (https://github.com/ibhagwan/fzf-lua/commit/c25c3f210670b5539ccff527e9702127d27cc322) and let me know if this solves the issue for you?

👍 Thanks, this fixed for me.

Can you update to the latest commit (c25c3f2) and let me know if this solves the issue for you?

👍 Thanks, this fixed for me.

Ty for the update, we can finally close this :)


[SERVICE_STARTUP_FAILED] [wait: http://<IP_ADDRESS>:4444/wd/hub does not respond in 30s]

Anyone can help me? All container are in the same network... I've already used the service-startup-timeout command, and if it helps at all, I'm on Ubuntu 22. PLEASE HELP ME
Always I have this issue when running a python code for connect with selenoid:
selenoid           | 2024/08/09 17:06:23 [-] [NEW_REQUEST] [unknown] [<IP_ADDRESS>]
selenoid           | 2024/08/09 17:06:23 [-] [NEW_REQUEST_ACCEPTED] [unknown] [<IP_ADDRESS>]
selenoid           | 2024/08/09 17:06:23 [1] [LOCATING_SERVICE] [chrome] [127.0]
selenoid           | 2024/08/09 17:06:23 [1] [USING_DOCKER] [chrome] [127.0]
selenoid           | 2024/08/09 17:06:23 [1] [CREATING_CONTAINER] [selenoid/chrome:127.0]
selenoid           | 2024/08/09 17:06:23 [1] [STARTING_CONTAINER] [selenoid/chrome:127.0] [32ce8eb9f57fbcad31c79427ae376101e8b4d261d985694196b8f5dd62a375b4]
selenoid           | 2024/08/09 17:06:23 [1] [CONTAINER_STARTED] [selenoid/chrome:127.0] [32ce8eb9f57fbcad31c79427ae376101e8b4d261d985694196b8f5dd62a375b4] [0.42s]
selenoid           | 2024/08/09 17:06:53 [1] [REMOVING_CONTAINER] [32ce8eb9f57fbcad31c79427ae376101e8b4d261d985694196b8f5dd62a375b4]
selenoid           | 2024/08/09 17:06:54 [1] [CONTAINER_REMOVED] [32ce8eb9f57fbcad31c79427ae376101e8b4d261d985694196b8f5dd62a375b4]
selenoid           | 2024/08/09 17:06:54 [1] [SERVICE_STARTUP_FAILED] [wait: http://<IP_ADDRESS>:4444/wd/hub does not respond in 30s]

python code to connect:
from selenium import webdriver
from selenium.webdriver.chrome.options import Options

capabilities = {
    "browserName": "chrome",
    "browserVersion": "127.0",
    "enableVNC": False,
    "enableVideo": False
}

options = Options()
options.set_capability("browserName", capabilities["browserName"])
options.set_capability("browserVersion", capabilities["browserVersion"])
options.set_capability("enableVNC", capabilities["enableVNC"])
options.set_capability("enableVideo", capabilities["enableVideo"])

driver = webdriver.Remote(
    command_executor="http://localhost:4444/wd/hub",
    options=options
)

python error:
WebDriverException: Message: wait: http://<IP_ADDRESS>:4444/wd/hub does not respond in 30s
selenoid-test/selenoid/browsers.json:
{
    "chrome": {
      "default": "127.0",
      "versions": {
        "127.0": {
          "image": "selenoid/chrome:127.0",
          "port": "4444",
          "path": "/wd/hub"
        }
      }
    }
}

My docker-compose.yml:
version: '3'

networks:
  selenoid:
    external:
      name: selenoid

services:
  selenoid:
    networks:
      - selenoid
    image: aerokube/selenoid:1.10.0
    container_name: selenoid
    ports:
      - "4444:4444"
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
      - ./selenoid/:/etc/selenoid/:ro

  selenoid-ui:
    networks:
      - selenoid
    image: aerokube/selenoid-ui:latest
    ports:
      - "8080:8080"
    command: --selenoid-uri http://selenoid:4444
    depends_on:
      - selenoid

  selenoid-chrome:
    networks:
      - selenoid
    image: selenoid/chrome:127.0

Docker logs when start:
selenoid-chrome_1  | 2024/08/09 17:03:33 [INIT] [Listening on :7070]
selenoid           | 2024/08/09 17:03:33 [-] [INIT] [Loading configuration files...]
selenoid           | 2024/08/09 17:03:33 [-] [INIT] [Loaded configuration from /etc/selenoid/browsers.json]
selenoid-chrome_1  | Connection failure: Connection refused
selenoid-chrome_1  | pa_context_connect() failed: Connection refused
selenoid-chrome_1  | Waiting X server...
selenoid           | 2024/08/09 17:03:33 [-] [INIT] [Video Dir: /opt/selenoid/video]
selenoid-chrome_1  | Waiting X server...
selenoid           | 2024/08/09 17:03:33 [-] [INIT] [Did not manage to determine your Docker API version - using default version: 1.41]
selenoid           | 2024/08/09 17:03:33 [-] [INIT] [Timezone: UTC]
selenoid           | 2024/08/09 17:03:33 [-] [INIT] [Listening on :4444]
selenoid-chrome_1  | Logging to: /dev/null
selenoid-chrome_1  | Waiting X server...
selenoid-chrome_1  | Starting ChromeDriver 127.0.6533.72 (9755e24ca85aa18ffa16c743f660a3d914902775-refs/branch-heads/6533@{#1760}) on port 4444
selenoid-chrome_1  | All remote connections are allowed. Use an allowlist instead!
selenoid-chrome_1  | Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
selenoid-chrome_1  | ChromeDriver was started successfully.
selenoid-ui_1      | 2024/08/09 17:03:34 [INIT] [Listening on :8080

@jfholanda you are all constantly doing the same error. Docker network where Selenoid is running should be the same as -contaner-network flag value. Otherwise Selenoid will not be able to connect to created containers and this error happens. In docs we give ready to use and working docker compose configuration (https://aerokube.com/selenoid/latest/#_option_2_running_selenoid_in_custom_docker_network). Research about any errors you get on customized configurations you do are your responsibility.

Works. Thank you! I hadn't seen that little detail.


How can I customize the speed of ripple effect when long clicking?

Everything works fine with single-tapping, but the animation on long-clicking is too slow, which makes it looks very weird.

Something new on this one?


Typescript error

Describe the bug
After npm create svelte@latest my-app with typescript, I get the following error on the browser.
Uncaught (in promise) TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at companion-bubble.js:1465:19726
    at Generator.next (<anonymous>)
    at Ln (companion-bubble.js:1465:19144)

Reproduction
npm create svelte@latest my-app
✔ Which Svelte app template? › Skeleton project
✔ Add type checking with TypeScript? › Yes, using TypeScript syntax
✔ Add ESLint for code linting? …  Yes
✔ Add Prettier for code formatting? … Yes
✔ Add Playwright for browser testing? …  Yes

cd my-app
npm install
npm run dev -- --open
open DevTools on your browser and confirm the error.
Logs
No response
System Info
System:
    OS: macOS 12.4
    CPU: (8) arm64 Apple M1
    Memory: 98.39 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.0 - /usr/local/bin/node
    npm: 8.19.2 - /usr/local/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Safari: 15.5
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.86
    @sveltejs/kit: next => 1.0.0-next.532
    svelte: ^3.44.0 => 3.52.0
    vite: ^3.1.0 => 3.2.2

Severity
annoyance
Additional Information
No response

I believe this is unrelated to SvelteKit. Do you use the Loom Chrome extension? https://stackoverflow.com/questions/74281137/companion-bubble-js-in-the-console

@hughest64 Yes, the loom extension was installed. After uninstalling, the error disappeared! Thank you.


Sequencing in UI Pack doesn't work on display: none if not the last item

animSequence = [
// Hide the spinner
{
e: $spinner,
p: { opacity: 0 },
o: {
duration: 150,
display: "none"
}
},
// Show the button
{
e: $btn,
p: { opacity: 1 },
o: {
duration: 150,
visibility: "visible"
}
}
];
$.Velocity.RunSequence(animSequence);
The spinner won't get display: none. Although, if it goes after the button, everything works correctly.

A fiddle would be most appreciated.

Here's a fiddle: http://jsfiddle.net/AlexeyGorokhov/gjLft5ch/2/

Thanks! @julianshapiro looks like a bug.

This looks to be linked to issue #413

I'll look into fixing this tomorrow.


Fix correct name to "Vim script"

The late Mr. Bram stated this clearly:
https://groups.google.com/g/vim_dev/c/3Z5yM8KER2w/m/wAqws0QSEAAJ

"Vim script" is the short form.

The language label on GitHub is also wrong, so I created a new discussion about it.
https://github.com/orgs/community/discussions/141314
P.S.
I'll make a pull request for EditorConfig later.

Should "script" still be capitalized in a title?

I think we should always write "Vim script".

thanks

thanks


Improve documentation panel

Make the documentation panel better than the previous one.

Tags as in the new design (different colors, sorting, collapsing, custom rendering)
Examples as in the design (buttons instead of code samples)
Hide private entries
Protection against XSS attacks because of v-html

Protection against XSS attacks because of v-html

I'd imagine rehype-sanitize would be sufficient for this


Faster serial with binary mode

Switch from using the pico-sdk serial functions to more directly using TinyUSB for serial communication to the computer.
This switch makes existing serial functions ~10x faster.
This pull request also introduces an adm command that specifies the number of instructions to transfer at the start of the command, then reads a binary encoding of those instructions (2 bytes for the output, 4 bytes for reps). This is a further ~10x faster than using the more user friendly ascii commands, but harder to read.
This maintains backwards compatibility with the current (at time of opening) version of prawn_digital_output_labscript.

Well this is great! Talk about a massive improvement. Just to add confirmation of improvement, on my rig with 1000 instructions I have 455 ms with old add, 347 ms with new add and a whopping 17.9 ms with new adm! I honestly wonder if we are going to find that in practice, we should basically always re-write the entire table instead of doing line-by-line writes.
Anyway, this looks good to me. Not that it super matters, but could we go ahead and bump the version to 1.2.0 and recompile? I say go ahead and merge once that's done.

As you probably saw in the prawn_digital_output_labscript pull request, it is probably good to add a heuristic to favor the binary add except for very small line-by-line rewrites (although perhaps we should also add a binary set command; it will necessarily be 1/3 slower due to the address specification, but that is not a sever penalty).


Design interim solution for downloading expression matrices

@pdugan20 commented on Mon Aug 10 2020
This will be the UI that supports this eng requirement.
This will in part borrow from the earlier revisions @liaprins-czi did, which can be viewed here.
Borrowed from the eng ticket:

For the original data set the format is limited to one standard format:
H5AD - because the curation process creates an H5AD as part of creating a CXG

For the remix data set, the formats are:
AnnData
Loom
Seurat v3 RDS

Current UI lives here:
https://www.figma.com/file/hy3wOqrKbunH1C3lA7CuP6/download-dataset?node-id=0%3A1

Designs for this live here: https://www.figma.com/file/hy3wOqrKbunH1C3lA7CuP6/download-dataset?node-id=0%3A1
..and I also added an invision flow here for more detail: https://chanzuckerberg.invisionapp.com/share/K6YKM66VU8J


Field Summ

The Summary of the Building is on the Mainplanet wrong. (Each Player) the colonys Summary is right,

Did you add or remove bulidings via admin panel?

not on each player. (Did they not be listet if they come from admin menue?)

maybe one of the buildings doesnt require space?

Can not verify this.


Add inline statements

Needed to do this to make it actually header-only

Oops, sorry this was supposed to go to the vgteam/gfakluge


Update kubernetes utils packages

This PR updates the kubernetes utils packages
we are using. we had hit an issue in xfs_repair
as this is fixed in recent kubernetes utils
we are updating it for the same reason
more info at https://github.com/kubernetes/utils/issues/141
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>fixes #859
updates https://github.com/rook/rook/issues/4914

@Madhu-1 the complete dependency PR will carry this change as discussed, which I am doing rebasing to master now. thanks.

Can this be closed? The dependency update to k8s 1.18.0 is already merged.


controllers: remove storageclaim from manager and move functionality

first cut of removal of storageclaim controller and moving the work over to the storageclient controller. Existing resources that are owned by storageclaims will become unmanaged but protected against deletion due to finalizer for which current expectation is to be removed manually
no provider changes done atm and the expectation is, provider would send info that it used to send for storageclaim now to storageclient and any opportunity to change the message struct will be made and corresondingly a new PR will be raised.

/hold
Against any accidental approvals.

closing in favour of #295


style(ast): move crate doc comment to top of file

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#6890  👈
#6863
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


Unable to build with CMake: Corrosion fails to parse Rust toolchain version

I've come back to a tree that I had left for a few weeks and something has changed -- I'm no longer able to build, with perplexing errors coming out of the Corrosion cmake package (this is on Linux/x86-64, Ubuntu 20.04 with latest Rust installed):
cfallin@cfallin-tower:~/work/starlingmonkey% cmake -S . -B cmake-build-weval -DCMAKE_BUILD_TYPE=Debug -DUSE_WASM_OPT=OFF -DWEVAL=ON

[ ... ]

CMake Warning (dev) at deps/cpm_cache/corrosion/669353a7bb342a135df6ffd28fcfd62298f03c5f/corrosion/cmake/FindRust.cmake:343 (message):
  Unexpected output from `rustc --version` for Toolchain
  `1.77.1-x86_64-unknown-linux-gnu`: ``.

  Ignoring this toolchain.
Call Stack (most recent call first):
  deps/cpm_cache/corrosion/669353a7bb342a135df6ffd28fcfd62298f03c5f/corrosion/cmake/Corrosion.cmake:63 (find_package)
  deps/cpm_cache/corrosion/669353a7bb342a135df6ffd28fcfd62298f03c5f/corrosion/CMakeLists.txt:73 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Rust Toolchain:
CMake Error at deps/cpm_cache/corrosion/669353a7bb342a135df6ffd28fcfd62298f03c5f/corrosion/cmake/FindRust.cmake:23 (message):
  Could not find toolchain ''

  Available toolchains:

    `stable-x86_64-unknown-linux-gnu`
    `nightly-x86_64-unknown-linux-gnu`
    `1.61.0-x86_64-unknown-linux-gnu`
    `1.68.2-x86_64-unknown-linux-gnu`

Call Stack (most recent call first):
  deps/cpm_cache/corrosion/669353a7bb342a135df6ffd28fcfd62298f03c5f/corrosion/cmake/FindRust.cmake:449 (_findrust_failed)
  deps/cpm_cache/corrosion/669353a7bb342a135df6ffd28fcfd62298f03c5f/corrosion/cmake/Corrosion.cmake:63 (find_package)
  deps/cpm_cache/corrosion/669353a7bb342a135df6ffd28fcfd62298f03c5f/corrosion/CMakeLists.txt:73 (include)

I've attempted to spelunk cmake sources for a bit but am coming up empty; rustup toolchain list --verbose, which Corrosion invokes, returns
cfallin@cfallin-tower:~/work/starlingmonkey% rustup toolchain list --verbose
stable-x86_64-unknown-linux-gnu (default) (override)    /home/cfallin/.rustup/toolchains/stable-x86_64-unknown-linux-gnu
nightly-x86_64-unknown-linux-gnu        /home/cfallin/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu
1.61.0-x86_64-unknown-linux-gnu /home/cfallin/.rustup/toolchains/1.61.0-x86_64-unknown-linux-gnu
1.68.2-x86_64-unknown-linux-gnu /home/cfallin/.rustup/toolchains/1.68.2-x86_64-unknown-linux-gnu
1.77.1-x86_64-unknown-linux-gnu /home/cfallin/.rustup/toolchains/1.77.1-x86_64-unknown-linux-gnu

Has anyone seen this issue before?

Actually, this would probably explain it (though it helps me not at all):
cfallin@cfallin-tower:~/work/starlingmonkey% /home/cfallin/.rustup/toolchains/1.77.1-x86_64-unknown-linux-gnu/bin/rustc
zsh: no such file or directory: /home/cfallin/.rustup/toolchains/1.77.1-x86_64-unknown-linux-gnu/bin/rustc
cfallin@cfallin-tower:~/work/starlingmonkey% ls -l /home/cfallin/.rustup/toolchains/1.77.1-x86_64-unknown-linux-gnu/bin/rustc
-rwxr-xr-x 1 cfallin cfallin 2885552 Jul 25 15:34 /home/cfallin/.rustup/toolchains/1.77.1-x86_64-unknown-linux-gnu/bin/rustc

(no missing libraries in the ldd output either)

Argh -- file this one under "nix home-manager ruins my morning yet again": it appears that a nix-patched rustup somehow patches (patchelf?) the downloaded toolchains and the ELF interpreter (ld-linux...so) for rustc had been garbage-collected by a recent nix-collect-garbage. (I live in the future and it is sometimes broken. Apologies.)


Startup is very slow

Describe the bug
The startup of Headlamp is very slow, especially on Windows.
At the same time, we could add some techniques to make the startup perceived as faster (like a splash screen if necessary).
To Reproduce
Steps to reproduce the bug:

Open Headlamp from cold start on Windows -> measure how long it takes till the logo shows up in the top bar

Environment (please provide info about your environment):

Installation type: all desktop version but especially on Windows
Headlamp Version: 0.26.0 (but also many more before this one)

Additional Context
Let's use this section to add any sub-items related to this.

I've looked into the generated JS bundles and there's a LOT of code that we don't need on startup but that is loaded

Biggest chunk is the monaco editor, which should be lazy loaded
One big problem with lazy loading it is that we expose monaco editor (and others) in pluginLib so it's loaded on app load, solution here is to remove direct reexports from pluginLib and only provide lazy loaded editor react component. Same thing with recharts.
Another issue is that we're rendering popups even if they're closed.
Here's a Create/Apply popup when it's not opened

Another thing we should do is get rid of circular imports, that will allow us to lazy load our code for different routes. Currently we have a bunch of barrel files that import/export everything so splitting by lazy loading won't work

Yeah, agree with that.
In the performance monitor you can see a big DOM node count at the beginning and then a lot that disappears.
In this PR I started to investigate some of these things... and it makes quite a big difference even without unravelling Monaco (which is the main slowdown but requires some code rearrangement gymnastics to untangle things). Splitting all the views is mainly good for seeing the size of the individual parts. There's a codemod script somewhere to automate a bunch of those changes. Didn't try it on vite to see if it has the same benefit compared to webpack... but I guess so.

https://github.com/headlamp-k8s/headlamp/pull/1961

Additionally we have the plugin performance issues to address:

https://github.com/headlamp-k8s/headlamp/issues/1518
https://github.com/headlamp-k8s/headlamp/issues/1521
https://github.com/headlamp-k8s/headlamp/issues/1520

It's quite easy to include a different version of an existing library and blow up the download size. I know one of the third party plugins is itself 1.5MB or so, and these issues arose from those discussions.  Also, for a plugin that only renders on for example a node details page... lazy loading would help a lot. So it would be good to provide examples for those, and an "analyze" command in headlamp-plugin.
We should also probably bisect to see if there's something additional to all this because it got quite a lot worse on windows somewhere between 0.23 and 0.26 (I haven't tried more than that).
Maybe we can do some sort of loading spinner/indicator Electron side to help. I do get app-not-responding message, so that won't be sufficient... but it could probably help in the short term?

Yeah. Also, with the adoption we are getting, looks like we should prioritize this, to not have new users eventually pushed away.


Typo in the documentation for single_observation_space

Description
Fixed a copy/paste typo in the documentation for single_observation_space
Type of change
[x] Bug fix (non-breaking change which fixes an issue)

Thanks for the contrib!


rollouts: add ready condition to remote root sync

This pull request updates the rollouts proof of concept, adding a ready condition to the remote root sync status. This condition allows us to understand if the remote root sync has connectivity to the target cluster.

@ChristopherFry Do we want to do anything here or close this out ?

Closing this pull request in favor of #3849.


Fix overflow issue

Describe your changes
When assigning pointers to labelArray, if the file had a final, empty newline, the last element of labelArray would try to be assigned to a pointer to labelsData + labelsFileSize + 1, which can cause a warning that can disrupt inference:
malloc(): invalid size (unsorted)

I also removed the replacement of the final '\n' with '\0' because it is always done in the loop.
Checklist before requesting a review

[X] I have performed a self-review of my own code
[X] I have verified that the code builds perfectly fine on my local system
[ ] I have added tests that prove my fix is effective or that my feature works
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have verified that my code follows the style already available in the repository
[X] I have made corresponding changes to the documentation

Thank you @mentoc3000  for your contribution, it's very appreciated!


maxFieldsSize 2097152 exceeded

Discussed in https://github.com/adonisjs/core/discussions/3231

Originally posted by freirejandre October  8, 2021
hello, i'm having problems with the multipart/form-data limit and it seems the limit doesn't work
response from error 'PayloadTooLargeError  maxFieldsSize 2097152 exceeded'
my configs:
` multipart: {
autoProcess: true,
processManually: [],
encoding: 'utf-8',
convertEmptyStringsToNull: true,
maxFields: 10000000,
limit: '9999999999mb',
types: ['multipart/form-data'],
}

`

I've the same issue with my content field, it can have a base64/binary, I'm also modified config/bodyparser.ts but still got this error. Any help?

Seems like an issue with the fieldSize in bytes and not the number of fields. I will have to expose another configuration option for it.

Ah okay, thanks so much @thetutlage , can't wait for the next enhancement :)


Fix cache policy on service-worker.js

Coverage remained the same at 94.402% when pulling ef0246095ea93e68f91a7e137e05b68524f1618e on cody-service-worker-caching into e8f2bdfa92ea5fa00320c8d76c4f231d7f9961b7 on main.


WIP: Improve IR, loop parsing, and internal data structures

This PR introduces a more flexible IR format that can be used across the analysis, which makes it easier to implement different algorithms and analysis.
This is still a work in progress some ways from completion, but I figured it's good to put the PR up as it has by now diverged significantly from the main branch.
For reference, w/ respect to the diff, there are currently <10k lines of code in include.

This has diverged enough from main that I think it makes more sense to have main reflect this WIP.


Added option to the run distributed task to consider standalone dta agent

Added option to the run distributed task to consider standalone dta agent

:shipit:

:shipit:


[Issue]: BionicDupe Can't Use Mechanics Station

Description of the bug/crash
Bionic Dupes can't use Mechanics Station even if they have machinery  booster.
Steps To Reproduce
Just create a Bionic Dupe with machinery booster and a Machine Stop.
Player.log
There is no crash in my game.

fixed in 1.4.1 mod version


Add Drugs by Sonic Mine

Song Name
Drugs
Artist Name
Sonic Mine
Source
Youtube
Youtube Link
Sonic Mine  Drugs (TURBOXWAVE, Viral Remix 2024, TikTok)
Direct File Link
No response
Song ID
684300
Start Offset [ms]
2024
Extra
Created from Auto Nong.
Created for level: 30219145

reject
thats not a link