feat: add missing upstreams fields

Codecov Report
Patch and project coverage have no change.

Comparison is base (99a165d) 52.75% compared to head (5963c2f) 52.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage   52.75%   52.75%
=======================================
  Files          69       69
  Lines        5093     5093
=======================================
  Hits         2687     2687
  Misses       1832     1832
  Partials      574      574

Flag
Coverage Δ

2.1.4
36.16% <ø> (ø)

<IP_ADDRESS>
?

2.2.2
36.16% <ø> (ø)

2.3.3
36.32% <ø> (ø)

<IP_ADDRESS>
47.31% <ø> (ø)

2.4.1
36.40% <ø> (ø)

<IP_ADDRESS>
47.39% <ø> (ø)

<IP_ADDRESS>
47.39% <ø> (ø)

2.5.2
36.40% <ø> (ø)

2.6.1
36.40% <ø> (ø)

<IP_ADDRESS>
?

2.7.2
36.40% <ø> (ø)

<IP_ADDRESS>
48.92% <ø> (ø)

2.8.3
36.40% <ø> (ø)

<IP_ADDRESS>
?

3.0.2
35.85% <ø> (ø)

<IP_ADDRESS>
?

3.1.1
37.34% <ø> (ø)

<IP_ADDRESS>
?

3.2.2
37.40% <ø> (ø)

<IP_ADDRESS>
?

community
37.95% <ø> (ø)

enterprise
51.52% <ø> (ø)

enterprise-nightly
50.97% <ø> (ø)

integration
52.75% <ø> (ø)

nightly
37.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

kong/upstream.go
0.00% <ø> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


http transparent endpoint support,

hello, I asked before to add http endpoint support, because some of the http proxies failed, so please review changes.

@trustin PTAL

@vitaliy-kuzmich Left a few comments.

@trustin what do you mean 'protected final' ? should I move 'transparent' to the ProxyHandler? but then I am not sure about Socks proxy.
code style?

@vitaliy-kuzmich please address my comments and then squash the commits + adjust the commit message to match our template:
http://netty.io/wiki/writing-a-commit-message.html

As you know your code better, please fix HttpProxyServer, read "HTTP tunneling without using CONNECT" for more details, https://en.wikipedia.org/wiki/HTTP_tunnel.

I'm not sure I understood the intention of this PR. What do you want to achieve with this? Netty's HttpProxyHandler is meant to use CONNECT and nothing else.

hmm okay then, just cut commit then.

@trustin how can I cut this commit?


See also: https://scientific-python.org/specs/spec-0001/
Originally posted by @agriyakhetarpal in https://github.com/pybamm-team/PyBaMM/issues/3475#issuecomment-1786894302

Hey can I look into it?

Hi @prady0t, thanks for helping us. Doing this would be much appreciated, but it would be better to start after #3475 gets completed. While we need import pybamm to be faster, the expected outcome is that there must not be any changes to the user-facing API.

Thanks for replying. I will be looking at other issues in the meantime.

See also: https://docs.python.org/3/library/importlib.html#implementing-lazy-imports; a rather crude, bare-bones implementation for delaying imports

I can look into this now. Keeping in mind that it is not a beginner level issue and @prady0t is occupied with other one.

Hey @AbhishekChaudharii, thanks for showing your interest on this but I am currently on it and going to open up a PR in a couple of days. Feel free to look into other issues 🙂

Sure no problem :)

@arjxn-py Can we close this now?

I would say we should keep it open (other, large packages are able to make it work – maybe we can too), but yes, it is @arjxn-py's call after all

I thought the consensus was that it was not a major bottleneck so the work/code required to do it was bigger than the problem

Right, maybe let's not close it because it's still within scope but lower down the priority for now – I'll change the labels.

But this is a recurring problem, isn't it? I just tested this in a fresh notebook/kernel without sys.modules being cached and it took ~20 seconds to import PyBaMM – so it's probably still valid. At least for organisational purposes it would be nice to keep open

I just noticed that https://github.com/scientific-python/lazy_loader is now being recommended for Python versions 3.11 and later, and that too, with very specific minimum patch versions to avoid races, say 3.11.9, for example. Python 3.11 being the lowest version for us will be quite many years away at the time of writing (at least four). It sucks that I would have liked to have seen this done for PyBaMM but I don't think we have a viable choice at this time, I think we can close this and re-open later (or open a new issue, whichever way works). A better and more reliable way would be to profile PyBaMM's import and see which of the bigger modules are causing the bottleneck, and if needed then implement minor breaking changes or lazy loading at the functionality level manually at the time of use of a function, so that we aren't importing a lot of those functions when one runs import pybamm. So I'm agreeing with @kratman here and closing this issue, please feel more than free to re-open later, @arjxn-py, or to suggest an alternative enhancement to speed up the import (whose slowness remains very much a valid problem – it's just not suited to be done for the entire public API).


gradient builder helper utility

in which your call to gradient doesn't have to contain two vaguely related arrays of colors and positions but can instead be created with something like
gui.gradient("background", gui.colorPoint(0xFF0000, 0.0f), gui.colorPoint(0x00FF00, 0.5f), gui.colorPoint(0x0000FF, 1.0f))

perhaps this can be made private now? it hasn't been published yet so no user should be angry
public PGraphics gradient(String path, int[] defaultColors, float[] defaultPositions)

yeah, it's hidden for now


@react macro expansion fails when using traits

So I have a component:
@react class MyComponent extends StatelessComponent with MyTrait
This fails to expand with error message:
"@react must annotate a class that extends Component"

I'm marking this as an enhancement since it's not previously supported behavior. I think this can make it in with a 0.5.x release though.

I just ran into the same issue 👍

@shadaj i just tried 0.5.1 and for me this issue has been fixed 🎉

Closing because this has been resolved


Prettify and re-order settings entries

Trying to make our settings a bit more organized and prettier.
TODOs:

[x] fix flake8 tests failing: some weird things happen over there -- @browniebroke would you mind helping me out on this? To reproduce, $ tox -r.

UPDATE 2: upgrading flake8 to the latest one helps, but now there's a number of F... and E...s. This has already been addressed in  #1528.
UPDATE 1: tox -- --full-traceback says:
b'Traceback (most recent call last):
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/bin/flake8, line 11, in <module>
    sys.exit(main())
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/flake8/main.py, line 36, in main
    report = flake8_style.check_files()
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/flake8/engine.py, line 181, in check_files
    return self._retry_serial(self._styleguide.check_files, paths=paths)
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/flake8/engine.py, line 172, in _retry_serial
    return func(*args, **kwargs)
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/pep8.py, line 1841, in check_files
    self.input_dir(path)
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/pep8.py, line 1877, in input_dir
    runner(os.path.join(root, filename))
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/flake8/engine.py, line 126, in input_file
    return fchecker.check_all(expected=expected, line_offset=line_offset)
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/pep8.py, line 1575, in check_all
    self.check_ast()
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/pep8.py, line 1521, in check_ast
    checker = cls(tree, self.filename)
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/flake8/_pyflakes.py, line 62, in __init__
    withDoctest=withDoctest)
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/pyflakes/checker.py, line 294, in __init__
    self.handleChildren(tree)
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/pyflakes/checker.py, line 567, in handleChildren
    self.handleNode(node, tree)
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/pyflakes/checker.py, line 609, in handleNode
    handler(node)
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/pyflakes/checker.py, line 567, in handleChildren
    self.handleNode(node, tree)
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/pyflakes/checker.py, line 609, in handleNode
    handler(node)
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/pyflakes/checker.py, line 567, in handleChildren
    self.handleNode(node, tree)
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/pyflakes/checker.py, line 609, in handleNode
    handler(node)
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/pyflakes/checker.py, line 567, in handleChildren
    self.handleNode(node, tree)
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/pyflakes/checker.py, line 608, in handleNode
    handler = self.getNodeHandler(node.__class__)
  File /home/webyneter/Projects/cookiecutter-django/.tox/py36/lib/python3.6/site-packages/pyflakes/checker.py, line 462, in getNodeHandler
    self._nodeHandlers[node_class] = handler = getattr(self, nodeType)
AttributeError: \'FlakesChecker\' object has no attribute \'JOINEDSTR\'

Apparently, this is a known issue.

Wow the change is huge.

@sfdye don't worry, I've already resolved merge conflicts in #1528 :)

@webyneter Yeah I saw that 😃


[BUG] NanoGraphRAG TypeError: 'NoneType' object is not subscriptable

Description
I'm running NanoGraphRAG via docker against local Ollama.  I pulled the main-full docker image this morning ... it was tagged as 10 days old.
I run this image with USE_NANO_GRAPHRAG=true but saw an error, so I installed Nano via the Readme.
Simple reasoning Chats with File Collection backed by Ollama work.  The Information Panel is populated with indexed docs.
Chat with NanoGraphRAG Collection errors out in the UI.  I've pasted the log below.  The error ends with:
 TypeError: 'NoneType' object is not subscriptable
What else can I check for finding out the root cause of this?
Reproduction steps
1. Go to Chat->NanoGraphRAG
2. Click on a Search in Files->select a file
3. Switch to Chat window, and prompt for "Please summarize"
4. See error

Screenshots
![DESCRIPTION](LINK.png)

Logs
INFO:httpx:HTTP Request: POST http://localhost:11434/v1/embeddings "HTTP/1.1 200 OK"
GraphRAG embedding dim 768
INFO:nano-graphrag:Load KV full_docs with 0 data
INFO:nano-graphrag:Load KV text_chunks with 0 data
INFO:nano-graphrag:Load KV llm_response_cache with 8 data
INFO:nano-graphrag:Load KV community_reports with 0 data
INFO:nano-graphrag:Loaded graph from /app/ktem_app_data/user_data/files/nano_graphrag/580ad20d-9321-4e5c-9c93-707181e1976c/input/graph_chunk_entity_relation.graphml with 1 nodes, 0 edges
INFO:nano-vectordb:Load (1, 768) data
INFO:nano-vectordb:Init {'embedding_dim': 768, 'metric': 'cosine', 'storage_file': '/app/ktem_app_data/user_data/files/nano_graphrag/580ad20d-9321-4e5c-9c93-707181e1976c/input/vdb_entities.json'} 1 data
INFO:httpx:HTTP Request: POST http://localhost:11434/v1/embeddings "HTTP/1.1 200 OK"
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/gradio/queueing.py", line 575, in process_events
    response = await route_utils.call_process_api(
  File "/usr/local/lib/python3.10/site-packages/gradio/route_utils.py", line 276, in call_process_api
    output = await app.get_blocks().process_api(
  File "/usr/local/lib/python3.10/site-packages/gradio/blocks.py", line 1923, in process_api
    result = await self.call_function(
  File "/usr/local/lib/python3.10/site-packages/gradio/blocks.py", line 1520, in call_function
    prediction = await utils.async_iteration(iterator)
  File "/usr/local/lib/python3.10/site-packages/gradio/utils.py", line 663, in async_iteration
    return await iterator.__anext__()
  File "/usr/local/lib/python3.10/site-packages/gradio/utils.py", line 656, in __anext__
    return await anyio.to_thread.run_sync(
  File "/usr/local/lib/python3.10/site-packages/anyio/to_thread.py", line 56, in run_sync
    return await get_async_backend().run_sync_in_worker_thread(
  File "/usr/local/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 2441, in run_sync_in_worker_thread
    return await future
  File "/usr/local/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 943, in run
    result = context.run(func, *args)
  File "/usr/local/lib/python3.10/site-packages/gradio/utils.py", line 639, in run_sync_iterator_async
    return next(iterator)
  File "/usr/local/lib/python3.10/site-packages/gradio/utils.py", line 801, in gen_wrapper
    response = next(iterator)
  File "/app/libs/ktem/ktem/pages/chat/__init__.py", line 812, in chat_fn
    for response in pipeline.stream(chat_input, conversation_id, chat_history):
  File "/app/libs/ktem/ktem/reasoning/simple.py", line 741, in stream
    docs, infos = self.retrieve(message, history)
  File "/app/libs/ktem/ktem/reasoning/simple.py", line 517, in retrieve
    retriever_docs = retriever_node(text=query)
  File "/usr/local/lib/python3.10/site-packages/theflow/base.py", line 1097, in __call__
    raise e from None
  File "/usr/local/lib/python3.10/site-packages/theflow/base.py", line 1088, in __call__
    output = self.fl.exec(func, args, kwargs)
  File "/usr/local/lib/python3.10/site-packages/theflow/backends/base.py", line 151, in exec
    return run(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/theflow/middleware.py", line 144, in __call__
    raise e from None
  File "/usr/local/lib/python3.10/site-packages/theflow/middleware.py", line 141, in __call__
    _output = self.next_call(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/theflow/middleware.py", line 117, in __call__
    return self.next_call(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/theflow/base.py", line 1017, in _runx
    return self.run(*args, **kwargs)
  File "/app/libs/ktem/ktem/index/file/graph/nano_pipelines.py", line 385, in run
    entities, relationships, reports, sources = asyncio.run(
  File "/usr/local/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "uvloop/loop.pyx", line 1518, in uvloop.loop.Loop.run_until_complete
  File "/app/libs/ktem/ktem/index/file/graph/nano_pipelines.py", line 158, in nano_graph_rag_build_local_query_context
    use_text_units = await _find_most_related_text_unit_from_entities(
  File "/usr/local/lib/python3.10/site-packages/nano_graphrag/_op.py", line 772, in _find_most_related_text_unit_from_entities
    all_text_units = truncate_list_by_token_size(
  File "/usr/local/lib/python3.10/site-packages/nano_graphrag/_utils.py", line 74, in truncate_list_by_token_size
    tokens += len(encode_string_by_tiktoken(key(data)))
  File "/usr/local/lib/python3.10/site-packages/nano_graphrag/_op.py", line 774, in <lambda>
    key=lambda x: x["data"]["content"],
TypeError: 'NoneType' object is not subscriptable

Browsers
Firefox
OS
Linux
Additional information
I've tried with 2 different PDF files.

Hmm, I see another error in the UI.  Under Files->Upload Info windows, after I upload new Files for Nano, I see this error at the bottom of the window:
[GraphRAG] Creating index... This can take a long time.
[GraphRAG] Indexed 0 / 648 documents.
Error: EmptyNetworkError

The docker runtime terminal of the Kotaemon app does not have this kind of error.  Here is what I see at the end of its output after uploading files for Nano:
Would you like me to extract more entities?
 --------------------------------------------------
⠼ Processed 4 chunks, 12 entities(duplicated), 0 relations(duplicated)
INFO:nano-graphrag:Inserting 10 vectors to entities
INFO:httpx:HTTP Request: POST http://localhost:11434/v1/embeddings "HTTP/1.1 200 OK"
INFO:nano-graphrag:[Community Report]...
INFO:nano-graphrag:Writing graph with 10 nodes, 0 edges

Hi, we have that kind of error too. There is a FAQ about it https://github.com/gusye1234/nano-graphrag/blob/main/docs/FAQ.md

Hi, we have that kind of error too. There is a FAQ about it https://github.com/gusye1234/nano-graphrag/blob/main/docs/FAQ.md

OK, I re-tested with Qwen and the EmptyNetworkError went away.
A different error appears in the UI after indexing, but the file does look to be indexed.  Below is the snippet.
What is your setup?
I'm curious if you have setup the NanoGraphCollection differently than me.
Indexing [1/1]: IPCC_AR6_SYR_LongerReport.pdf
 => Converting IPCC_AR6_SYR_LongerReport.pdf to text
 => Converted IPCC_AR6_SYR_LongerReport.pdf to text
 => [IPCC_AR6_SYR_LongerReport.pdf] Processed 136 chunks
 => Finished indexing IPCC_AR6_SYR_LongerReport.pdf
Error: name 'EmbeddingFunc' is not defined


Make WMIC invocation work under some XP machines

Hi @salsifis, can you help me understand what the change is doing?

Hi @vocatus,
I had this problem on an old XP SP3 machine. On that machine, wmic.exe would never return. What is strange is that, outside of a batch file, when the command line was run directly, the commands would succeed. When in a batch file, process explorer would show that wmic had been running for hours.
Ensuring that the input for wmic is closed, such as piping an empty file or redirecting nul to its stdin, solved the problem in my case.
You can find related issues here:

https://stackoverflow.com/a/10999727/457352
https://stackoverflow.com/a/40385787/457352

Great find and thanks for putting in the work to update all the files. Approved.


fix: peer dependencies

This should remove useless warnings that we get in the wallet when installing dependencies:

As those packages update so often, it's best not to pin specific versions.

@chrisling-dev this would be great to get merged or a version of this.


Support using downstream TCP destination port for SNI dynamic forward proxy upstream connection

Title: Support using downstream TCP destination port for SNI dynamic forward proxy upstream connection
Description:
Currently the SNI dynamic forward proxy allows setting a port_value to be used for the upstream TCP connection if the SNI host does not have a port embedded. It'd be useful if this filter supported using the destination port of the downstream TCP connection (maybe when the port_value is zero/unset). As far as I know most TLS clients do not embed the port in the SNI host anyway.
By using IPTables redirection together with the listener filter envoy.filters.listener.original_dst this feature would allow Envoy to proxy TLS traffic dynamically to any port depending on which port the client used to connect to Envoy.

@lizan WDYT?

/no stalebot

/nostalebot


Noticket global scripts

Force load order with dynamic scripts in both local dev and final build paths

Looks good, but no tests? :maple_leaf:

Looks good, but no tests? 🍁
Yeah - back when these were originally added we found it impossible to write a test around webpack functionality so decided dev / build scripts didn't need them

Possibly worth having another go now in the Jest world but think will do that in a separate ticket so we can get this fix to Aerian.


Merge VS2017Conversion branch changes

@paulmon,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Serializer/Deserializer in Pin.cs

Extend writepindata method with serializer and add newpinmode
Add readpindata method with serializer and desirializer

pushed adaptions of Pin.cs and Arduino Sketch


Should Linux binaries also be compiled with Python 3.10?

Linux binaries are compiled with Python 3.8 while Windows and BSD binaries are already compiled with Python 3.10. Should Linux follow? If possible with Xubuntu 20.04, it should...
Edit: Ubuntu repositories don't offer Python 3.10 - as that version needs to be compiled from source and Python 3.9 has proven to be buggy right now, Python 3.8 will still be used for Linux binaries until Xubuntu 22.04 can be confirmed as usable.
Edit 2: Until Xubuntu 22.04 is confirmed as usable, I decided that Linux binaries will temporarily be compiled with both Python 3.8 and Python 3.10 if compiling from source works.
Edit 3: As I failed in installing tkinter for the version of Python on Xubuntu 20.04, I am forced to compile Linux binaries with Python 3.8 until further notice.
Edit 4: I installed Kali Linux into a virtual machine and compiled the Linux binaries for TTP 2.0.0 Alpha 2 with Python 3.9. It is hoped that we can upgrade to 3.10 while maintaining compatibility with Xubuntu 20.04.

It has been noted that Linux binaries HAVE to be compiled with Python 3.8 as that worked on most configurations. It will stay that way for now...


FIX 1.16.5

In order to listen to channel from Origins we need to load listener AFTER not BEFORE simple as that :D

Fixes: https://github.com/DragonsPlusMinecraft/origins-accessibilities/issues/7

Thanks for the work


Low contrast versions of themes

Hey, would you mind to elaborate the request?
Thank you so much.
/Mike

Low contrast versions of themes, ie, no contrast between terminal, sidebar, main panel, etc.

Superb, got ya. Let me look into it.
Thank you .

Some good points and comparison.

I think that it should look like this (the contrast):

as you can see, no contrast at all.

Ok, let me see what I can do

Hey Milo, @Milo123459 I just pushed the low contrast versions. You can update the theme and reload VS Code. It might take some minutes to update though.

Thanks, will test

Beautiful!

really hapy it helped!


buildGoModule: fix enableParallelBuilding

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@zowoq please target staging.

please target staging.

Intentionally targeting master as we usually do for go.

Result of nixpkgs-review pr 129205 at 214ee12c run on x86_64-linux 1

810 packages skipped due to time constraints:

_3mux
act
aerc
age
agebox
air
alertmanager-bot
alertmanager-irc-relay
amass
amfora
...

2 packages built successfully:

boringssl
nginxQuic

Can we default this to true by any chance?

This is already set to true.


Fix wrong locale format

Related example is not working properly. Because  the 'ss' format doesn't exist in locale file.
Example
https://runkit.com/tolgacesur/5eeb8a2dd16b9e00131d4baf

I'll close this pr. Feel free to reopen if you have updates on this


Az rest with --uri-parameters

This is autogenerated. Please review and update as needed.
Describe the bug
Hello, I trying to use az cli to automate tasks, in special with this command az rest when I pass --uri-parameters on az rest command I receive an error when I construct URI with parameters it works. This error occurs on cloud shell, windows terminal, PowerShell all I trying to use.
Command Name
az rest
Errors:
not enough values to unpack (expected 2, got 1)
Traceback (most recent call last):
azure\cli\core\util.py, ln 281, in shell_safe_json_parse
CLI2\lib\json\__init__.py, ln 354, in loads
    return _default_decoder.decode(s)
CLI2\lib\json\decoder.py, ln 339, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
CLI2\lib\json\decoder.py, ln 355, in raw_decode
    obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 1 column 2 (char 1)

...

cli\command_modules\resource\custom.py, ln 2283, in rest_call
azure\cli\core\util.py, ln 599, in send_raw_request
ValueError: not enough values to unpack (expected 2, got 1)

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
Error occour
az rest --uri "https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/webhooks/generateUri?api-version=2015-10-31"  --uri-parameters '{"subscriptionId":"","resourceGroupName":"","automationAccountName":""}'  -m POST

Ok when don't use --uri-parameters
az rest --uri "https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/{automationAccountName}/azautoxp/webhooks/generateUri?api-version=2015-10-31" -m POST
Expected Behavior
https://docs.microsoft.com/en-us/rest/api/automation/webhook/generateuri
Environment Summary
Windows-10-10.0.18362-SP0
Python 3.6.6
Installer: MSI

azure-cli 2.3.1

Additional Context

add to S169

add to S171

@EwertonJordao I can't reproduce this problem in both version 2.3.1 and the latest version (2.7.0) of CLI. Will this problem still occur in your side? (you can upgrade the CLI version and try again)
If so, please add --debug to the original command and email the printed information to me~
My email address is<EMAIL_ADDRESS>thanks~

Ok, I'll send the email.
Thanks.

@EwertonJordao Hi, could you show me the debug level logs? If only the log information of info level is not specific enough.
Since I have used the CLI of 2.3.1 in multiple environments but I can't reproduce this problem, I would like to ask you two more questions:

What is your specific execution environment? PowerShell or CMD or something else?
Could you change to another automationaccounts and execute this command to see if there are the same problems?

I found with --debug.
The parameter --uri-parameter use to query parameters and not to change values of a uri https://management.azure.com/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}?api-version=2019-10-01 i the document about az rest --uri-parameters
Space-separated queries in KEY=VALUE format or JSON string. Use @{file} to load from a file.
it's not clear what is uri-parameter use to query parameters. I think is more clear if uri-parameter rename query-parameter it's more clear what it's.
I would like to suggest a new parameter for change dynamically parameters with this patter {parameter_name} of a uri.
Thank you for your attention.

@EwertonJordao Thank you very much for your nice suggestion. My thoughts on this are as follows:

The specification of the existing --uri-parameters is not clear, we will modify the document to explain its usage in more detail and add some new examples for it. But we don't rename this parameter because it will cause a breaking change to the customers.
As for adding new parameters to support placeholder replacement in uri, I personally think this may introduce the complex problem of confusing placeholders with input parameters that contain placeholder text, and it will make the entire command longer. If there is more customers feedback about this requirement, we will consider supporting it.

What do you think of that?

@zhoxing-ms thanks for all.
About documentation, I can help too make some samples with uri-parameter.
I think about it's work the same way of the other command --body or --uri when you define a @{json.json} read a file and change some values,, when we interact with azure resource manager API it's a good help because some times we make a logic for string builder of uri, with this feature won't require to make this.

@EwertonJordao OK, thank you very much for the helpful suggestions. Welcome to provide us with the examples of uri-parameter, which we will probably refer to it ~

Because there is no reply to this question for a long time, I will close it temporarily. If you have any questions, please feel free to let us know.

@EwertonJordao any feedback for the example?

That's cool.
I'll make a post in a few days on my blog about how to consume other API that's not Azure Resource or test some Azure Functions http trigger.
Thanks for attention

The PR for adding examples has been merged, so I close this issue first. If you have any supplementary examples, please feel free to let us know~


[MonologueAgent] Step 0 takes longer than other steps

Describe the bug

When running a new task via the UI, there's generally a very long pause before the first step is completed.
I suspect we're doing something like starting the sandbox container, or initializing something. We could do this much sooner (e.g. on the initialize event, or on first connection, or on startup) to improve latency.
Setup and configuration
Current version:

❯ git log -n1
commit 73fb4843a39e65cc6298f8c47efeb3ed0807adf2 (HEAD -> main, origin/main, origin/HEAD)
Author: Exlo<EMAIL_ADDRESS>Date:   Mon Apr 8 16:36:04 2024 +0200

My config.toml and environment vars (be sure to redact API keys):
LLM_MODEL="gpt-3.5-turbo-1106"
LLM_API_KEY="sk-..."
LLM_EMBEDDING_MODEL=""
WORKSPACE_DIR="./workspace"

My model and agent (you can see these settings in the UI):

Model: gpt-3.5-turbo-1106
Agent: MonologueAgent

Commands I ran to install and run OpenDevin:
make build
npm run start -- --port 3001 --host <IP_ADDRESS>
poetry run uvicorn opendevin.server.listen:app --port 3000 --host <IP_ADDRESS>

Steps to Reproduce:

Start with default settings
Run a task
Time step 0 vs subsequent steps

Did some more investigation here.
The issue is that we call _initialize() on the MonologueAgent in the first step. This adds many new documents (the initial monologue) to the chromadb index. Each one takes ~500ms.
We could hypothetically call _initialize() earlier, but we need the task text first.
Best solution here would probably be to do a multi-insert

More info: I tried removing the chromadb dependency, and using from_documents to initialize the memory. That seems to drop init time from ~38s to ~29s. Better, but still pretty terrible ☹
It's possible we'll just need to cope with the slowness of building an index...

Is chromadb only used with the Monologue agent?

The initial monologue is more or less static, I wonder if there's a way to snapshot chromadb and use that at _initialize()

LLM_EMBEDDING_MODEL=""

I did some tests tonight, and it was inserts with openai embeddings that got around 20 sec, but not with local. With local embeddings it was 10x less, e.g. around 2-3 seconds at most. 😕 The difference is so significant, are you sure these tests were with local?
This was the total time of inserts in _initialize. Each insert includes getting embeddings for that sentence. I think that explains the difference.
The round-trip is probably only a part of that. I suppose it's also that text-embedding-ada-002 model has 1,536 dimensions vs 383 or so for BAAI/bge-small. I don't know yet how much each matters.
Apart from multi-insert, which I assume would still mean getting embeddings per sentence... I wonder if we can get embeddings once for some bigger chunk of the monologue, like several related sentences, and save those?

Using BAAI/bge-small could be a serious improvement!


My Workplans - Assessment Phase Colours

the colour of Intake is white. it cannot be seen on Work cards!!!!

(If yes, list here)
Screenshot
(Link above will always be the most up-to-date version.)

hmmm does need a design decision from @maria-kuzmenko?

@jadmsaadaot, no, we have the colour phase in Dev it somehow didn't merge for Prod
PROD view

DEV view

@dinesh-aot this is in Dev but not in Prod, does this mean that we just need to deploy?

@jadmsaadaot  You are right. I am expecting this would be resolved after a deployment to the production. I am waiting for getting a test sign off from test environment for updating the prod. So we can park this ticket for a while and wait for the next production release.

hey @dinesh-aot!, I noticed this is in the sprint backlog now, any update on the above discussion?

The issue is still there in prod after the latest release. So this is something to be investigated.


chore: Revert "chore: Reserve memory for native shuffle writer per partition (#988)"

This reverts commit e146cfa1676fedcfb3003c2e3f1da1578d6b664b.
Which issue does this PR close?

Closes #.
Rationale for this change

There is an issue https://github.com/apache/datafusion-comet/issues/1019 caused by the patch. Reverting the patch temporarily to unblock other works.
What changes are included in this PR?

How are these changes tested?

TPC-H ran clean for me on this PR. Thanks for the quick help!


[SPARK-30949][K8S][CORE] decouple requests and parallelism on kubernetes drivers

What changes were proposed in this pull request?
spark.driver.cores configuration is used to set the amount of parallelism in kubernetes cluster mode drivers. Previously the amount of parallelism in the drivers were the number of cores in the host when running on JDK 8u120 or older, or the maximum of driver containers resource requests and limits when running on JDK 8u121 or newer. This will enable users to specify spark.driver.cores to set parallelism, and specify spark.kubernetes.driver.requests.cores to limit the resource requests of the driver container, effectively decoupling the two
Why are the changes needed?
Drivers submitted in kubernetes cluster mode set the parallelism of various components like RpcEnv, MemoryManager, BlockManager from inferring the number of available cores by calling Runtime.getRuntime().availableProcessors(). By using this, spark applications running on JDK 8u120 or older incorrectly get the total number of cores in the host, ignoring the cgroup limits set by kubernetes. JDK 8u121 and newer runtimes do not have this problem.
Orthogonal to this, it is currently not possible to decouple resource limits on the driver container with the amount of parallelism of the various network and memory components listed above.
Does this PR introduce any user-facing change?
Yes. Previously the amount of parallelism in kubernetes cluster mode submitted drivers were the number of cores in the host when running on JDK 8u120 or older, or the maximum of driver containers resource requests and limits when running on JDK 8u121 or newer. Now the value of spark.driver.cores is used.
How was this patch tested?
happy to add tests if my proposal looks reasonable

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Test build #118933 has started for PR 27695 at commit 2b3ad5b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23681/

Test build #118933 has finished for PR 27695 at commit 2b3ad5b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118933/
Test PASSed.

Ping @holdenk since the flakiness of Test basic decommissioning is observed again.
- Test basic decommissioning *** FAILED ***
  The code passed to eventually never returned normally. Attempted 121 times over 2.01174358735 minutes. Last failure message: "++ id -u

Gentle ping, @onursatici .

In my experience the K8s tests have all been flaky but I’ll dig into them & decom as well this coming week

IIUC this issue also affects Standalone cluster mode?

@dongjoon-hyun, what are the next steps? Does it look fine from your perspective?

@onursatici . One thing I'm thinking is the deprecation of 8u120 and the older at 3.0.0. Until now, 3.0.0-preview2 gave some early warning (not official deprecation yet) for 8u92 like the following.

https://spark.apache.org/docs/3.0.0-preview2/

Java 8 prior to version 8u92 support is deprecated as of Spark 3.0.0

Since this also affects Standalone cluster, I'd suggest we only exclude Mesos backend in the case match.

Hi, @jiangxb1987 . What do you mean by this? This PR or this old JDK bug?

Since this also affects Standalone cluster, I'd suggest we only exclude Mesos backend in the case match.

I mean the JDK bug mentioned in this PR.

@jiangxb1987 do you recommend to do that in this PR? I think changing the stand-alone driver core count behaviour would broaden the scope of this PR such that it might warrant a separate discussion.
Does this change make sense for k8s? Any blockers @dongjoon-hyun?

It's fine if you want to focus on the k8s behaviour here, I can submit another PR to fix the Standalone backend after this is merged.

retest this please

Test build #120369 has started for PR 27695 at commit 2b3ad5b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/25078/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/25078/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25078/
Test PASSed.

Test build #120369 has finished for PR 27695 at commit 2b3ad5b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120369/
Test FAILed.

retest this please

Test build #120398 has started for PR 27695 at commit 2b3ad5b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/25107/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/25107/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25107/
Test FAILed.

Test build #120398 has finished for PR 27695 at commit 2b3ad5b.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120398/
Test FAILed.

retest this please

Test build #120434 has started for PR 27695 at commit 2b3ad5b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/25142/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/25142/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25142/
Test PASSed.

Test build #120434 has finished for PR 27695 at commit 2b3ad5b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120434/
Test PASSed.

@dongjoon-hyun do you mind taking a look at this? I have revised the PR description

@onursatici . I'm still not sure about this approach.

First, K8s environment is different from on-prem environment. I don't think the user of Apache Spark 3.1.0 will use old JDKs (JDK 8u120 or older).
Second, even in old JDKs, this original YARN code is made by the following PR for Netty. In K8s environment, the available number of core is the same with the requested amount.

https://github.com/apache/spark/pull/21885 ([SPARK-24926][CORE] Ensure numCores is used consistently in all netty configurations)

So, do you want to have bigger parallelism on the small container?

How do you think about the above comment, @onursatici ? I'm wondering your opinion.

Gentle ping, @onursatici .

Hey @dongjoon-hyun , sorry for the late response. You are right that the feature I wan't with this PR is to mainly increase parallelism while keeping the cpu resource requests low in K8S.
spark.driver.cores controls the number of threads in various components, including some network components that are mainly blocked by I/O. The ability to increase this while keeping the cpu requests the same would allow users to better utilise their K8S clusters, especially if their workloads are I/O bound

Got it. Thanks, @onursatici .


Wifi tooling

Create wifi management tooling, and hook it into netctl

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

31 of 74 (41.89%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-4.4%) to 76.462%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bin/cmd/wifiConnect.go
3
11
27.27%

bin/cmd/wifi.go
3
16
18.75%

bin/cmd/wifiAdd.go
5
27
18.52%

Totals

Change from base Build<PHONE_NUMBER>:
-4.4%

Covered Lines:
510

Relevant Lines:
667

💛  - Coveralls


fix(card): corrected footerStyles in card footer

Closes #
📝 Description

Add a brief description

⛳ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Thank you! @bobbychan good catch!


Perimordials is not defined

Hello!
I tried to run this beautiful dashboard but after npm install I tried to start npm start command and this happened:
><EMAIL_ADDRESS>start
> gulp

fs.js:42
} = primordials;
    ^

ReferenceError: primordials is not defined
    at fs.js:42:5
    at req_ (D:\Skola\Vysoka\projektak\dashboard\shards-dashboard\node_modules\natives\index.js:143:24)
    at Object.req [as require] (D:\Skola\Vysoka\projektak\dashboard\shards-dashboard\node_modules\natives\index.js:55:10)
    at Object.<anonymous> (D:\Skola\Vysoka\projektak\dashboard\shards-dashboard\node_modules\vinyl-fs\node_modules\graceful-fs\fs.js:1:37)
    at Module._compile (node:internal/modules/cjs/loader:1155:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
    at Module.load (node:internal/modules/cjs/loader:1033:32)
    at Function.Module._load (node:internal/modules/cjs/loader:868:12)
    at Module.require (node:internal/modules/cjs/loader:1057:19)
    at require (node:internal/modules/cjs/helpers:103:18)

My version of node is managed by NVM and I ran it with version 12.22.12 and latest (16.18.0).
Thank you in an advance for your replies!

Okay, I found it out. I just downloaded the 4 year back old version of node - 6.8.0 with which I can run the dashboard!


Llama Compatible InternLM2 Release [Feature]

Describe the feature
Going to echo what I posted here: https://huggingface.co/internlm/internlm2-chat-20b/discussions/1

I'm not sure how different the architecture actually is, but could you change the config to be llama compatible instead of requiring custom runtime/tokenizer code?

Custom code is a huge blocker to the highly optimized llama architecture infrastructure the community already uses... To be blunt, I can run Yi 34B 200K with a fraction of the resources it takes to run this 20B model, for the moment, and finetune it just about as efficiently with llama focused frameworks.

Yi itself already went through this ordeal, and "llamafied" their release for broader compatibility: https://huggingface.co/01-ai/Yi-34B/discussions/11

On second thought, the internlm deployment framework is pretty interesting, albeit not quite right for my personal and work use cases.

Thank you for your suggestion. We are planning to offer a script that facilitates conversion between InternLM2 and LLaMA. However, we recommend using InternLM2 when feasible, primarily for its enhanced efficiency. InternLM2, which is adapted from LLaMA, streamlines the process by integrating the Wq, Wk, Wv weight matrices into a single matrix. This integration leads to approximately a 5% speed increase during training. Given the substantial costs associated with pre-training, this efficiency boost can result in significant savings.

https://github.com/InternLM/InternLM/pull/627 Add a convert2llama script, which can help to convert huggingface internlm2 into huggingface llama format.

#627 Add a convert2llama script, which can help to convert huggingface internlm2 into huggingface llama format.

https://github.com/InternLM/InternLM/issues/771
The inference results of the scripts before and after the conversion are not completely consistent

#627 Add a convert2llama script, which can help to convert huggingface internlm2 into huggingface llama format.

#771 The inference results of the scripts before and after the conversion are not completely consistent

Have you solved this problem yet?


Complete setup of project

add a couple more steps needed for successfully setting up app
tweak formatting

@gcaprio Not sure where ls folder came from, should I maybe add it to .gitignore and re-commit?

Nevermind, I realized what I had done and where that folder came from. removed!

Awesome, thanks!

@gcaprio What about the security thing?

@gabivoicu oh sorry totally missed that. So that was added by Django 1.7 by default? it's not in my local project. So yeah, for now maybe add something about removing it.


Solves : Keep typeahead open if even the user tabs away(7535)

I reopened the PR #8106 here as I was having a lot of problems in my earlier fork.
short summary for those who landed directly here...

Simply  adding a check if (window.focus == true) makes it work as expected.
The  typehead is not lost if user switches tabs. But if user wants to keep  busy with using zulip then that search_box is narrowed with  search_string as per narrow_state.search_search_string().
Its working this way in my dev environment.

@SatyendraBanjare can you post a video of this working?  It seems to not work for me when trying to mention someone.

@timabbott video-link
as can be seen the type head is not lost if you switch tabs. but if you want to interact more with the application... only then the type head is lost

Hmm, weird.  Can you post an explanation for why this change should be correct?  I can't make sense of what you're doing here, and maybe understanding it would help me review this.

Because the source repository for this pull request was deleted, this pull request has been automatically closed by GitHub as an unintended side effect of renaming our default Git branch. If this change is still desired, please open a new pull request, referencing this one in the description.


[SP-3827] Backport of PDI-16010 - In Excel Input Step, trimming of sp…

…ace doesn`t happen when Spoon is opened in Japanese preferred language

translated trim type strings in jp resource file to fix mapping between ui values set and trim type code inside the step

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/steps/excelinput/messages/messages_ja_JP.properties

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.3% :small_red_triangle_down:
Line Change: -3.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Method Change: -1% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -2.1% :small_red_triangle_down:
Complexity Change: -2.1% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:
Line Change: -0.7% :small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.9% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Instruction Change: -0.1% :small_red_triangle_down:

@stepanovdg please review


Query based on selected input dates from a user while using Datatables as a service

In my blade file I want to display data based on a user's selected from & to dates. I don't know how to do that while using datatables as service. In my blade file {{ $dataTable->table() }} data should be based on a user's selected dates. I've tried hard but can't quite figure out how to go about it. Thanks!
System details

OS Linux Peppermint
Php 7.1
Laravel 5.2.*
Datatable ~6.0

[ ] #


Add BaseModelView.table_prefix_html for insert some HTML above list t…

Demo:

It's a bit useful to the end-user of website.
Hope help.

@ufo911 How about merge this one?

@pedia
Sorry I am not maintainer

@mrjoes
How about this PR?

I'm not sure this is all that useful. For adding your own content to the builtin views, rather take this approach: https://flask-admin.readthedocs.io/en/latest/introduction/#working-with-the-built-in-templates
I updated the 'sqla' example app, so that you can see this in action.


ZIP-155: Parse addrv2 in Zebra and the DNS seeders

Motivation
ZIP-155 will require support for parsing inbound addrv2 messages.
But nodes can still keep sending addr messages.
We'll need to implement addrv2 parsing in both Zebra (in Rust) and the DNS Seeders (in Go).
Current Implementation
The DNS seeder's are currently using a fork of btcsuite/btcd:

[ ] https://github.com/ZcashFoundation/dnsseeder/blob/master/go.mod#L14
[ ] https://github.com/ZcashFoundation/coredns-zcash/blob/master/Dockerfile#L20

btcsuite/btcd currently disconnects from peers on unknown messages, including addrv2:

https://github.com/btcsuite/btcd/pull/1671
https://github.com/btcsuite/btcd/blob/master/wire/message.go#L29

Since they're Bitcoin-focused, they're unlikely to implement addrv2, because it's not required by Bitcoin. (But it is required in Zcash.)
So we might have to implement addrv2 in Go ourselves.
Deadline
ZIP-155 activates as of the NU5 mainnet activation network protocol version.
(On both mainnet and testnet.)

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @teor2345 @upbqdn


Finish Setup Shell File

Time update does not seem to work
Need to setup permanent Internet over USB
Needs to add main.py to startup

not technically needed


[$1000] [HOLD for payment 2023-03-01] Create "Contact method" menu in Profile page & "Contact methods" page

Part of the bigger "Account Settings" project - https://github.com/Expensify/Expensify/issues/182122
This is part 1 of our plan, where we're breaking the process into 4 steps (see tracking issue ^)
Goals for this issue: Edit Profile page & put old LoginField in Contact methods page, skipping "add contact method" and everything else for now
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0194cea0cb70786833
Upwork Job ID:<PHONE_NUMBER>769167872
Last Price Increase: 2023-03-07

PR for this is here, and it's in review: https://github.com/Expensify/App/pull/15039
Not exactly sure why the link preview didn't show in this issue 🤷

Job added to Upwork: https://www.upwork.com/jobs/~0194cea0cb70786833

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

Sorry @0xmiroslav - @Santhosh-Sellavel was already assigned as a C+ on the related PR

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.75-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/15039

If no regressions arise, payment will be issued on 2023-03-01. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

📣 @MelvinBot! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@Beamanator Assign a BugZero here thanks!

Current assignee @Santhosh-Sellavel is eligible for the Internal assigner, not assigning anyone new.

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@slafortune added Bug label just to get you assigned! :D Please can you help pay out @Santhosh-Sellavel as the C+ on my internal PR?

@Santhosh-Sellavel has been paid now 👍

I think this is good to close now @Beamanator

Oofda I am sorry for not mentioning this, but my PR actually got reverted yesterday due to this regression (https://github.com/Expensify/App/issues/15725) 🙃

@aldo-expensify is helping workin on a fix here: https://github.com/Expensify/App/pull/15751


sig#805 - Align portal-shared-components documentation structure with updated TRG 1

Description
To enhance the consistency and ease of understanding of our products for the open community, TRG 1 was updated.
Make sure to comply with the updated structure:
repository
└─── docs/
    └─── architecture/
    └─── admin/
    └─── user/
    └─── api/
    └─── README.md

Please TRG 1.05-1.08 for more information:
https://eclipse-tractusx.github.io/docs/release/trg-1/trg-1-05
https://eclipse-tractusx.github.io/docs/release/trg-1/trg-1-06
https://eclipse-tractusx.github.io/docs/release/trg-1/trg-1-07
https://eclipse-tractusx.github.io/docs/release/trg-1/trg-1-08
Acceptance Criteria

[ ] Adjust the repo related documentation based on trg 1.05 - gather all architecture documentations into docs/architecture
[ ] Adjust the repo related documentation based on trg 1.06 - gather admin related docu into docs/admin
[ ] Adjust the repo related documentation based on trg 1.07 - gather end-user related documentation into doc/user
[ ] Adjust the repo related documentation based on trg 1.08 - Clarify the setup with Evelyn ;)
[ ] Adjust the docs/README.md regarding your changes
[ ] Ensure that all documentation is in English

Additional Information

@evegufy  would you have a look and close the story ?


Submitted to VLN test server

Dear Sir:
Hello!I'm writing to consult you that could you please release the code for "Submitted to VLN test server" in order to evaluation the result?Thank you very much!

Dear Sir:
Hello!I'm writing to consult you that could you please release the code for "Submitted to VLN test server" in order to evaluation the result?Thank you very much!


Update README.md

Fixed some corrupted formatting

Duplicate of #174. Please actually read through the list of open PRs before submitting!

Well, sorry, I didn't notice. But I think I made better edits... Anyway, I can just close this request as well, it doesn't seem as if this project is getting any maintenance at all...


Unused type declaration in typescript

Hi
I am using genType to auto-generate typescript bindings and I noticed that some type declarations in the .gen.tsx files are unused. For example given the following Index.rei file:
module BgPrimaryReason: {
  [@genType]
<EMAIL_ADDRESS>  let make: (~text: string) => ReasonReact.reactElement;
};

I get the correspnding Index.gen.tsx file like so:
/* TypeScript file generated from Index.rei by genType. */
/* eslint-disable import/first */

// tslint:disable-next-line:no-var-requires
const IndexBS = require('./Index.bs');

// tslint:disable-next-line:interface-over-type-literal
export type Props = { readonly text: string };

export const BgPrimaryReason_make: React.ComponentType<{ readonly text: string }> = IndexBS.BgPrimaryReason.make;

export const BgPrimaryReason: { make: React.ComponentType<{ readonly text: string }> } = IndexBS.BgPrimaryReason

As you can see the type Props = { readonly text: string }; is not used anywhere, where it should actually be used to type the React.ComponentType like so React.ComponentType<Props>
Is this happening for a reason (no pun intended) or is it actually a bug ?
Thank you so much for this great product

@hamza0867 I’ve now remembered. The type Props was used in the generated code in the past, then had to be inlined for technical reasons.
I left it in case client code wants to write e.g.: this value has type: “the type of the props of that component”.
It’s kind of niche I guess, though it does not cost anything. If I knew nobody uses that I might remove it.

Ok makes sense. Thank you


Upgrade to accessibility-developer-tools 2.9.0-rc1

@rileyjshaw && @MichelleTodd,
I've updated package.json to use the latest version of Accessibility Developer Tools, which includes a bunch of fixes for which we no longer need workarounds, yay!
I also updated the ContrastPlugin to use the new axs.color module.
Test plan:
$ npm run live-test
// http://localhost:8080/test/

Verify that the contrast plugin works :)

lgtm!


feat(ingestion/redshift): support auto_incremental_lineage

@siddiquebagwan-gslab looks like there's merge conflicts on this - it's my bad for not merging it earlier


admin: expose host locality to hosts in cluster_status

Issue Template
Title: For a multiple localities cluster. it'd be nice if we can show the locality information of hosts in the cluster.
Description:
Show host locality information in the admin/cluster/ dump.

/assign stevenzzzz


Enable AutoScaling on EMR Cluster

I must commend the maintainers of this library. This has been very useful for adhoc analysis when launching an EMR cluster.
This is not a problem but an enhancement. Would it be possible to support EMR autoscaling within this library.  This would be a nice feature to have.

This feature request already is open for a while but we didn't receive any PR or had time to work on. We will close it until we had more concrete plains to evolve it.

This feature request already is open for a while but we didn't receive any PR or had time to work on. We will close it until we had more concrete plains to evolve it.


Token revoked

Traceback (most recent call last):
  File "/usr/bin/i3-agenda", line 33, in <module>
    sys.exit(load_entry_point('i3-agenda==1.4', 'console_scripts', 'i3-agenda')())
  File "/usr/lib/python3.9/site-packages/i3_agenda-1.4-py3.9.egg/i3_agenda/__init__.py", line 99, in main
  File "/usr/lib/python3.9/site-packages/i3_agenda-1.4-py3.9.egg/i3_agenda/__init__.py", line 273, in connect
  File "/home/tomer/.local/lib/python3.9/site-packages/google/oauth2/credentials.py", line 200, in refresh
    access_token, refresh_token, expiry, grant_response = _client.refresh_grant(
  File "/home/tomer/.local/lib/python3.9/site-packages/google/oauth2/_client.py", line 248, in refresh_grant
    response_data = _token_endpoint_request(request, token_uri, body)
  File "/home/tomer/.local/lib/python3.9/site-packages/google/oauth2/_client.py", line 124, in _token_endpoint_request
    _handle_error_response(response_body)
  File "/home/tomer/.local/lib/python3.9/site-packages/google/oauth2/_client.py", line 60, in _handle_error_response
    raise exceptions.RefreshError(error_details, response_body)
google.auth.exceptions.RefreshError: ('invalid_grant: Token has been expired or revoked.', '{\n  "error": "invalid_grant",\n  "error_description": "Token has been expired or revoked."\n}')

If you revoked the token, or it was automatically revoked for some reason, you will need to re-initialize it

Solution:
rm  ~/.i3agenda/i3agenda_google_token.pickle
i3-agenda -c ~/.google_credentials.json
Your browser should open, grant access to your account, that's it


Spelling mistakes in Privacy Policy

The Privacy Policy (German) may still have some spelling mistakes. Proof reading required.

Any PR regarding this issue is welcomed. Thanks.

I did not notice any spelling mistakes but only minor punctuation errors. Please see my pull request #433 for details.

Please also integrate the result of https://github.com/corona-warn-app/cwa-documentation/issues/207 when it's available.


Merge pull request #1 from Jagroop2001/master

#20 HOVER EFFECTS ON NAV BAR
In the navigation bar, an engaging and dynamic user experience is crafted through thoughtfully designed hover effects on the buttons. When a user hovers over the navigation links, a seamless transition occurs, transforming the appearance of the anchor tags for an added visual impact.
Color Transition:
Initial State: The text color of the navigation links is set to white, providing a clean and minimalist look.
Hover State: Upon hovering, a subtle color transformation takes place. The white text elegantly transitions to a vibrant shade of blue, instantly drawing attention and indicating interactivity. Also the cursor changes to pointer.
Underline Animation:
Initial State: The anchor tags have no underlines by default, maintaining a sleek and modern design.
Hover State: A sophisticated underline emerges from centre dynamically during the hover state. This animated underline effect not only reinforces the selected link visually but also introduces a touch of fluidity to the user interaction.
sample-

@smritig26 , there is no code changes available in the PR.

i'll make a pr again
On Mon, Jan 22, 2024, 8:52 PM Jagroop @.***> wrote:

@smritig26 https://github.com/smritig26 , there is no code changes
available in the PR.
—
Reply to this email directly, view it on GitHub
https://github.com/Jagroop2001/AcmeRockets/pull/40#issuecomment-1904232675,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AY56SNFQJBDI4TM2YJUMJPTYPZ73HAVCNFSM6AAAAABCED5NAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBUGIZTENRXGU
.
You are receiving this because you were mentioned.Message ID:
@.***>


dynamically set keycloak

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I want to create a login page in my react application, which dynamically set the realm id for the keycloak, but since the keycloak provider wraps my entire application, the application throws error for empty realm string. I don't want to set realm until the user enter realm input on the login page.
Describe the solution you'd like
In the Login page , after entering realm (input) for the keycloak realm onclick a button the keycloak will dynamically initialize with {realm: (whatever input was submitted)}. On a success realm it will redirect to private route, which I should have access to keycloak object with "withKeyclock" HOC.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
index.js**
ReactDOM.render(
KeycloakProvider keycloak={keycloak} keycloakConfig={keycloakConfig}
Provider store={store}
Router
App
Router
Provider
KeycloakProvider,
document.getElementById("root")
App.js*****
class App extends Component {
render() {
return (
div
PrivateRoute
Switch
Route exact path="/" component={LoginForm}
Switch
div
);
}
}

Hi @davirk21 ,
Thanks for your feedback.
Thinking about your issue, I came up with a solution like this
const keycloakProviderInitConfig = {
  onLoad: 'check-sso',
};

class App extends React.PureComponent {
  constructor(props) {
    super(props);

    const keycloakRealm = localStorage.getItem('kcRealm');

    this.state = {
      keycloak: !!keycloakRealm ? new Keycloak({ realm: keycloakRealm }) : null,
    };
  }

  setupKeycloakWithRealm = keycloakRealm => {
    // ... Validate Keycloak realm...

    // Store Keycloak realm name
    localStorage.setItem('kcRealm', keycloakRealm);

    // Setup a Keycloak instance
    this.setState({
      keycloak: new Keycloak({ realm: keycloakRealm }),
    });
  };

  onKeycloakEvent = (event, error) => {
    console.log('onKeycloakEvent', event, error);
    // On Logout
    if (event === 'onAuthLogout') {
      // Cleanup stored Keycloak realm name
      localStorage.removeItem('kcRealm');

      // Cleanup keycloak instance
      this.setState({
        keycloak: null,
      });
    }
  };

  onKeycloakTokens = tokens => {
    console.log('onKeycloakTokens', tokens);
  };

  render() {
    const { keycloak } = this.state;

    if (!keycloak) {
      return (
        <KeycloakRealmInput onKeycloakRealm={this.setupKeycloakWithRealm} />
      );
    }

    return (
      <KeycloakProvider
        keycloak={keycloak}
        initConfig={keycloakProviderInitConfig}
        onEvent={this.onKeycloakEvent}
        onTokens={this.onKeycloakTokens}
      >
        <AppRouter />
      </KeycloakProvider>
    );
  }
}

export default App;

Basically your context is initialised after entering the Keycloak realm name in the KeycloakRealmInput (which you can implement as an input box or a select), you can then validate it inside setupKeycloakWithRealm method and if valid you create a Keycloak instance for that realm.
The localStorage bits are required to store the keycloak realm to allow reinitialising it after a successful login, otherwise the user will be forced to re-enter the realm name after keycloak redirect.
Let me know if this helps you.

How do i invoke the keycloak.login method to once the user submit the realm Id from the RealmForm.
Once the Login happen the user will be redirected to the privateRoute
If the user already authenticated he will be redirected to the privateRoute main
App.js*********
`render() {
console.log("State", this.state.keycloak);
const { keycloak } = this.state;
if (!keycloak) {
  return (
    <RealmForm
      setupKeycloakWithRealm={this.setupKeycloakWithRealm}
      onKeycloakEvent={this.onKeycloakEvent}
    />
  );
} else {
  return (
    <KeycloakProvider
      keycloak={keycloak}
      initConfig={keycloakProviderInitConfig}
      onEvent={this.onKeycloakEvent}
      onTokens={this.onKeycloakTokens}
    >
      <Router>
        <AppRouter />
      </Router>
    </KeycloakProvider>
  );
}

}`
AppRouter.js************
class AppRouter extends Component {   componentDidMount() {     if (this.props.keycloak.authenticated === false) {       this.props.keycloak.login({         redirectUri: ${process.env.REACT_APP_BASE_URL}/user/vehicles`,
kcLocale: "en-US"
});
}
}
render() {
console.log("KEYCLOAK IN APP ROUTER", this.props.keycloak);
if (this.props.keycloak.authenticated) {
return (

);
}
}
}
export default withKeycloak(AppRouter);`
PrivateRoute.js*********
`class PrivateRoute extends Component {
state = {
keycloak: null,
authenticated: true
};
render() {
console.log("KEYKLOACK", this.props.keycloak);
if (this.props.keycloak.authenticated) {
localStorage.setItem("realm", this.props.keycloak.realm);
localStorage.setItem("id_token", this.props.keycloak.idToken);
localStorage.setItem("access_token", this.props.keycloak.token);
localStorage.setItem("refresh_token", this.props.keycloak.refreshToken);
// this.props.history.push("/user/vehicles");
}
const { component: Component, ...rest } = this.props;

return (
  <Route
    {...rest}
    render={props =>
      this.props.keycloak.authenticated ? (
        <Component {...props} />
      ) : (
        <Redirect
          to={{
            pathname: "/",
            state: { from: this.props.location }
          }}
        />
      )
    }
  />
);

}
}`

If you need to login the user as soon as keycloak is ready you can set onLoad init option to login-required so you don't need to invoke it explicitly, like this:
const keycloakProviderInitConfig = {
  onLoad: 'login-required',
};

Hello Panz3r,
Thank you for the quick responses. Unfortunately I am having a some difficulty setting this up for my application. If you do have some free time please feel free email at<EMAIL_ADDRESS>Maybe if you have free time we can do a video call. I appreciate all the feedback you have given so far.

this.state = {
keycloak: !!keycloakRealm ? new Keycloak({ realm: keycloakRealm }) : null,
};
This code require clientID, when I do pass a clientID it goes into an endless loop.
After initialization I try calling the login method through this.state.keycloak.login, but I recieve an error saying .login is undefined. I also tried to call in in my AppRouter component, this works but has a weird bug. So once I call it, I have to comment out the method and do a hard refresh.
In your component how do you maintain keycloak state? Once it does get initialized then should  renders the other condition.

Hi @davirk21 ,
Sorry for the late answer, I had little to no time in the past weeks.
I just uploaded a new branch sample/dynamic-keycloak to test out my initially proposed solution plus some fixes to add missing data on Keycloak setup.
I made some testing and can confirm it to works.
Let me know if this helps you.

any idea why keycloak-js 7.0.0 does not work?

Hi @xtrasmal ,
Can you please open a new issue about your problem.
Thanks.

@xtrasmal keycloak-js 7.0.0 is buggy. It's a known issue: https://issues.jboss.org/browse/KEYCLOAK-11187
Looks like it was patched though (https://github.com/keycloak/keycloak/pull/6279), we're just waiting on the new release.


Feature stability between versions documentation

Temporarily addresses #315 and #311 by alerting users that features created in one version of Featuretools are not necessarily compatible with other versions. A longer-term fix would be advised.

Looks good. Merging


Add 5.0.4-rc0 and 5.1.0-rc3

We keep running into the following for 5.0+ RCs, so I think it's time to address it:
+ apt-get install -y mongodb-org=5.0.4~rc0 mongodb-org-server=5.0.4~rc0 mongodb-org-shell=5.0.4~rc0 mongodb-org-mongos=5.0.4~rc0 mongodb-org-tools=5.0.4~rc0
Reading package lists...
Building dependency tree...
Reading state information...
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 mongodb-org : Depends: mongodb-mongosh but it is not installable
E: Unable to correct problems, you have held broken packages.
Removing intermediate container 87166299d7cf
The command '/bin/sh -c set -x 	&& export DEBIAN_FRONTEND=noninteractive 	&& apt-get update 	&& ln -s /bin/true /usr/local/bin/systemctl 	&& apt-get install -y 		${MONGO_PACKAGE}=$MONGO_VERSION 		${MONGO_PACKAGE}-server=$MONGO_VERSION 		${MONGO_PACKAGE}-shell=$MONGO_VERSION 		${MONGO_PACKAGE}-mongos=$MONGO_VERSION 		${MONGO_PACKAGE}-tools=$MONGO_VERSION 	&& rm -f /usr/local/bin/systemctl 	&& rm -rf /var/lib/apt/lists/* 	&& rm -rf /var/lib/mongodb 	&& mv /etc/mongod.conf /etc/mongod.conf.orig' returned a non-zero code: 100

I'm going to have to remove 5.1 here.... :facepalm:
E: The repository 'http://repo.mongodb.org/apt/ubuntu focal/mongodb-org/5.1 Release' does not have a Release file.

and if I remove the 5.1 bucket, I get back to mongodb-mongosh being unavailable...
Welcome back, SERVER-57939.

Added 5.1-rc back with the 5.0 pocket, which pulls in mongosh version 1.1.1.

That CI failure is a bug in MongoDB itself :weary:
I've put up a PR to them at https://github.com/mongodb/mongo/pull/1428 (although I have no idea what their timeframe on fixing it might end up being).  I guess these are both RCs so it doesn't hurt to just let them both wait while this gets figured out?


visqol_lib_py.so

Hello! Please how to fix "modelscope.hub.errors.NotExistError: The file path: visqol_lib_py_windows_py37.so not exist in: pengzhendong/visqol"?

Hi, it only supports python 3.8, 3.9, 3.10, 3.11, and 3.12 now.

Hi, it only supports python 3.8, 3.9, 3.10, 3.11, and 3.12 now.

Thanks！I found your models in modelscope，but it's pity that there isn't a fit model to windows. Can you teach me how to generate a windows model?

I follow this repo to build the libraries with github actions: https://github.com/pengzhendong/visqol


Question about label and legens

Hi, I have noticed that since version 0.8.1 there have been some changes between legend and labels, mostly in arrays of fieldset. Now some titles are not showing as before.
Is this change done intentionally ? or it is a bug?
Thank you

More concretely, the change is done between release 0.8.4 and 0.8.5
Version 0.8.4:

And version 0.8.5:

Thank you !

@AlexAlbala I am working through neglected issues it would really help me a lot if you could find the commit that changed the tag in the decorator, then I can enquire with the developer why the change was made. If the tags are the same then there may have been a change in the version of bootstrap used.


Can we use something else as a label tag for placeholder?

as the title says, im having trouble using label tag as placeholder, cause i want to show some html, and this destroys all the css, so the text is not gray anymore.

Pass placeholder_tag property to change the type of tag. I updated the test.html file with this example.


pre-recorded scenario JSON file

As you writed  "What emulator did, is try to REPLAY the IPC messages between sender and receiver. Which means that you have to PRE-RECORD from a real Google Cast device to get these IPC message", if there is not Google Cast Device then can't to test receiver. That's a pity.

@fix-six Indeed, the emulator so far is trying to reduce the number of redundant efforts during the receiver app development by automated replaying the IPC messages for you.
Would you like to share an example of your requirement so that we may evaluate if there's a possibility for further implementation?

@fix-six I'm going to close the in-active issue. Any further suggestions are still welcomed.


All commands fail on Sierra because [Please enable Spotlight indexing for /Applications.]

I cannot run a single command because each fails with the same message Please enable Spotlight indexing for /Applications. Although Applications are being indexed.

I am also experiencing this problem

Maybe try running sudo mdutil -i on / to reindex spotlight? It takes a few hours for the indexing to complete.

That shouldn't be necessary, and i explicitly don't want to have spotlight constantly indexing my hard drive.

There has been some discussion around using an alternative approach to Spotlight (https://github.com/KrauseFx/xcode-install/issues/204). I'm open to reviewing and merging it, but don't have the time to look into this myself unfortunately.


Handle selection in grid view

This includes highlighting the current selection, changing the current selection, and not crashing when the next/prev buttons are pressed.

The bigger architectural question is how does grid view convey back that some random image was clicked on.

I think that the gridview can simply let the click event percolate down, and we can wrap whatever the image container ends up being in a Gtk.EventBox and let it handle updating itself. If the grid view needs to do anything, it can also handle the click event (just so long as we let it pass it down as well). I think the GTK eventing framework has this all built in.


/boot/config.txt moved to /boot/firmware/config.txt

Sorry I don't know anything about pull requests.  In Raspberry Pi OS for the last couple of years at least the config.txt file is now at /boot/firmware/config.txt.
In your repo etc/install-respeaker-drivers.sh line 59 you have config='/boot/config.txt' which needs to change to config='/boot/firmware/config.txt' or some fancy bash if statement.
Thanks though the driver works.

Also, it looks as though you're compiling for the 6.1 kernel - but RasPi OS Bookworm uses v6.6 kernel


Build error with SIM_NETUSRSOCK.

When SIM_NETUSRSOCK is enabled, the simulator build fails.
I get the following error:
/usr/bin/ld: up_usrsock_host.o: in function `usrsock_host_loop':
/path/nuttx/arch/sim/src/sim/posix/up_usrsock_host.c:514: undefined reference to `usrsock_event_callback'
collect2: error: ld returned 1 exit status

up_usrsock_host.c

I try to build adb, which enabled SIM_NETUSRSOCK by default and get success result.
Did you upgrade your codebase to latest master?

@ethanlcz I just tried with 6b7fe6ea8e2916f6c06a77c965bcce2d1e53e011 and it still fails.
Can you please share your config, to check for any differences?

usrsock config is already enabled in daily build:
https://github.com/apache/incubator-nuttx/blob/master/boards/sim/sim/sim/configs/adb/defconfig#L37-L40
Please compare yours with the upper.

NET_USRSOCK_CUSTOM is needed for this to build successfully.
Unfortunately, SIM_NETUSRSOCK cannot select NET_USRSOCK_CUSTOM since the later is a choice.
I don't think that there is anything more to do on this.


Use vrapi_GetPredictedDisplayTime instead of 0.0f for improved camera positioning

Seems to be helping but what I can notice is is in the fast moving case.


Fix typo preventing example code from running.

Ironically, there was a typo in my commit message as well.

:+1:


Added german translation

I didn't compiled the app to test the translation, so you need to look if it works. I will improve the translation over time, after I saw it in the app.

Thank you for your help. I added one more file (StoreListing.md) to the repo. I will be grateful for your help in translating it.


Throttling on automatic build triggered by upstream source change

No priority.
Limit the build frequency when the upstream may change frequently.

Are you proposing the increment of time between polling on upstream resource, or are you suggesting that there should be a way to skip some updates?
Can you please elaborate a bit more.


cpp-unit-test plugin should make dependencies of component under test visible to the test binaries

The implementation dependencies of the component under test should be visible to the test binaries at compile, link and runtime.

Fix is here: https://github.com/gradle/gradle/pull/5210


Update security policy doc to reflect 4.6.0 release

Describe the bug
The security policy page in the GitHub repo : https://github.com/coreruleset/coreruleset/security/policy
should be updated to reflect the 4.6.0 CRS release today. I imagine by adding 4.6.0 and deprecating suport for 4.4.0
Steps to reproduce
Visit https://github.com/coreruleset/coreruleset/security/
Expected behaviour
It should list the 4.6.0 release and whether or not it's supported
Actual behaviour
The most recent release listed is 4.5.0

hi @gene1wood,
thanks for reporting, we will fix that soon.
Thanks again!

Closing as completed via #3805.
Thank you again!


SSL_accept() fails in server with handshake error where SSL_connect() succeeds

I am using openssl (1.1.1c) in my server-client model project for data communication. When we use client authentication (use SSL_CTX_set_verify(SSL_VERIFY_PEER | SSL_VERIFY_FAIL_IF_NO_PEER_CERT in server), and client did not provide a certificate, SSL_accept() on server side fails with error “peer did not return a certificate” (but server won’t die, it  will wait for next connection).
But SSL_connect() on client side gets return code as 1 which is success.
When an SSL handshake fails in the server, how can a  client receive SSL_Connect as success.
Please help me to find out anything am missing or is it a bug?
Thank you for your bug report. If this is your first one,
please take the time to read the following lines before posting it.

You will need to provide some more details about what the issue is. Are you saying on the client side, SSL_connect() is successful, but the server for the same connection SSL_accept() failed? What error do you get? Did you call SSL_get_error() to find out why it returned an error?

[edited original post to move the useful content outside of the comment block]

I'm facing the exact same issue but it happens to me only when TLSv1.3 is being used. With TLSv1.2 SSL_Connect returns -1 as expected.
Is this because in TLSv1.3 the SSL Client authentication happens after the Handshake and so SSL_connect returns success ??
If this is case, then what API should I call on the client after SSL_connect to know if the client authentication was successful before trying to check the server verification using SSL_get_verify_result.

TLS 1.3 client authentication still (can) happens during the handshake, and the post-handshake offering requires extra code so I assume you're not using it.
I don't have enough information about what API calls you're making and what they are returning, let alone what SSL_get_error() is returning, in order to give advice about how to modify your code to achieve your desired result.

@kaduk  Briefly, these are the calls that are made on the client and server...
      Client                                                 Server
===============================                  =====================================
const SSL_METHOD *meth;                          const SSL_METHOD *meth;
SSL_CTX *ssl_ctx;                                SSL_CTX *ssl_ctx;
meth = TLS_client_method();                      meth = TLS_server_method();
ssl_ctx = SSL_CTX_new( meth );                   ssl_ctx = SSL_CTX_new( meth );
...                                              ...
...                                              SSL_CTX_set_verify( ssl_ctx, SSL_VERIFY_PEER | SSL_VERIFY_FAIL_IF_NO_PEER_CERT | SSL_VERIFY_CLIENT_ONCE , NULL );
SSL_CTX_set_verify_depth( ssl_ctx, 2 );          SSL_CTX_set_verify_depth( ssl_ctx, 2 );
...                                              SSL_CTX_set_num_tickets(ssl_ctx, 0 );
...                                              ...
SSL *ssl = SSL_new(ssl_ctx );                    SSL *ssl = SSL_new( ssl_ctx );
nSSLIORetVal = SSL_connect( ssl )                nSSLIORetVal = SSL_accept( ssl );
==========================================================================================
When using TLSv1.2, SSL_connect returns -1       For both TLSv1.2 and TLSv1.3, SSL_accept
When using TLSv1.3, SSL_connect returns 1        returns -1 with Err_get_error=337100999
                                                 (Peer did not return a certificate)

I use SSL_CTX_set_max_proto_version(ssl_ctx, TLS1_2_VERSION); to make it negotiate it to TLSv1.2.
So what is not clear to me is that with the same code why does SSL_connect behave differently for TLSv1.2 and TLSv1.3.
Can you let me know if I need to add few APIs on the client side so that it behaves the same with TLSv1.2 and TLSv1.3 ?

The problem is due to a difference in the way TLSv1.3 works. Here is what a TLSv1.2 handshake looks like  from RFC5246:
      Client                                               Server

      ClientHello                  -------->
                                                      ServerHello
                                                     Certificate*
                                               ServerKeyExchange*
                                              CertificateRequest*
                                   <--------      ServerHelloDone
      Certificate*
      ClientKeyExchange
      CertificateVerify*
      [ChangeCipherSpec]
      Finished                     -------->
                                               [ChangeCipherSpec]
                                   <--------             Finished
      Application Data             <------->     Application Data

             Figure 1.  Message flow for a full handshake

So, the server sends a CertificateRequest. In your case the client ignores it and continues without sending a Certificate back. So it just sends ClientKeyExchange, CCS and Finished. The server then aborts the handshake without ever sending its "Finished" message and SSL_accept fails. From the client perspective the handshake is not done until it has both sent and received a Finished message. Because this never happens SSL_connect also fails.
Compare this with a TLSv1.3 handshake from RFC8446:
       Client                                           Server

Key  ^ ClientHello
Exch | + key_share*
     | + signature_algorithms*
     | + psk_key_exchange_modes*
     v + pre_shared_key*       -------->
                                                  ServerHello  ^ Key
                                                 + key_share*  | Exch
                                            + pre_shared_key*  v
                                        {EncryptedExtensions}  ^  Server
                                        {CertificateRequest*}  v  Params
                                               {Certificate*}  ^
                                         {CertificateVerify*}  | Auth
                                                   {Finished}  v
                               <--------  [Application Data*]
     ^ {Certificate*}
Auth | {CertificateVerify*}
     v {Finished}              -------->
       [Application Data]      <------->  [Application Data]

The server sends its CertificateRequest and its Finished message in the same flight - and trusts that the client will send the certificate as requested. The client fails to do so and just sends a finished message back. The server aborts the handshake at this point because it hasn't got the certificate it was expecting - hence SSL_accept fails. From the client perspective though it has already sent and received its Finished messages. So the client believes the handshake is "done", and so SSL_connect succeeds. It won't realise that there was a problem until such time as it attempts to read data from the server. At this point it will discover the failure alert and the SSL_read() call will fail.

Thank you @mattcaswell for the detailed explanation.
From a client perspective, what can I do after SSL_connect succeeds in order to check if the server has closed down the connection?
Is there a way I can make the SSL_connect fail, by setting some flags, in case it does not send the requested certificate from the server ?
Basically I want my client to stop in case the server side has closed down just like with TLSv1.2. What can I do to get this behaviour ?

Is there a way I can make the SSL_connect fail, by setting some flags, in case it does not send the requested certificate from the server ?

No - there isn't such an option at the moment.

From a client perspective, what can I do after SSL_connect succeeds in order to check if the server has closed down the connection?

The only thing you can do is attempt to read data from the server via SSL_read(). Unfortunately if your protocol means that the client writes first (as is often the case) and the server doesn't send anything until it's received client data then its a difficult problem to solve. If the server was expecting a certificate that it didn't get then it will abort immediately and send an alert. Calling SSL_read() will detect that an report and error. However if SSL_read() doesn't read anything (SSL_ERROR_WANT_READ) then you don't know if its because the server was successful and is waiting for the client to send it something, or whether it actually failed but the alert hasn't arrived yet.

Is there a way I can make the SSL_connect fail, by setting some flags, in case it does not send the requested certificate from the server ?

No - there isn't such an option at the moment.

It seems like the client_cert_cb ought to be able to decide to abort the connection in preference to continuing without a cert, though the current documented behavior doesn't suggest this and if you peek into the implementation to decide to return NULL cert and key then the resulting error message is a bit weird.

Is there a way I can make the SSL_connect fail, by setting some flags, in case it does not send the requested certificate from the server ?

No - there isn't such an option at the moment.

From a client perspective, what can I do after SSL_connect succeeds in order to check if the server has closed down the connection?

The only thing you can do is attempt to read data from the server via SSL_read(). Unfortunately if your protocol means that the client writes first (as is often the case) and the server doesn't send anything until it's received client data then its a difficult problem to solve. If the server was expecting a certificate that it didn't get then it will abort immediately and send an alert. Calling SSL_read() will detect that an report and error. However if SSL_read() doesn't read anything (SSL_ERROR_WANT_READ) then you don't know if its because the server was successful and is waiting for the client to send it something, or whether it actually failed but the alert hasn't arrived yet.

Oh that's unfortunate ... I think like ours, other apps if using client authentication would break when using TLSv1.3 because we now need to modify application logic to tackle TLS layer. It gets a bit more complicated when we have to maintain backward compatibility.
It would be great if we have a way to detect if the Client Authentication was successful by calling another API like SSL_get_verify_result instead of  trying to do an SSL_read/write to detect socket closure on the other side.

Well, at the protocol level, it's up to the server to decide whether the client authentication is successful.  If the server thinks the authentication was unsuccessful, your application isn't going to be able to pass any data, and calls to SSL_read()/SSL_write() will (eventually) reflect the TLS alert from the server that aborts the connection.  So I don't know that your client-side logic needs to change other than by being prepared to handle error returns properly.

Error with TLS Call Home connection using netopeer2-cli
Describe the issue:
I am encountering an error when attempting to listen for a TLS Call Home connection using netopeer2-cli. Below is the command and the error log I receive:
Command:
listen --tls
Error Log:
cmd_listen: Waiting 60s for a TLS Call Home connection on port 4335...
nc ERROR: Communication socket unexpectedly closed.
cmd_listen: Receiving TLS Call Home on port 4335 failed.
Here are the relevant logs from the netopeer2-server:
[INF]: LN: Trying to connect via IPv4 to <IP_ADDRESS>:4335.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: [INF]: LN: Successfully connected to <IP_ADDRESS>:4335 over IPv4.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: Successfully connected to <IP_ADDRESS>:4335 over IPv4.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: Session 822 (user "root", CID 56) created.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: [INF]: SR: Session 822 (user "root", CID 56) created.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: Session 823 (user "root", CID 56) created.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: [INF]: SR: Session 823 (user "root", CID 56) created.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: Session 824 (user "root", CID 56) created.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: [INF]: SR: Session 824 (user "root", CID 56) created.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: Cert verify: depth 1.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: [INF]: LN: Cert verify: depth 1.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: [INF]: LN: Cert verify: subject<EMAIL_ADDRESS>Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: [INF]: LN: Cert verify: issuer<EMAIL_ADDRESS>Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: [INF]: LN: Cert verify CTN: cert fail, cert-to-name will continue on the next cert in chain.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: [INF]: LN: Cert verify: depth 0.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: [INF]: LN: Cert verify: subject<EMAIL_ADDRESS>Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: [INF]: LN: Cert verify: issuer<EMAIL_ADDRESS>Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: [INF]: LN: Cert-to-name unsuccessful, dropping the new client.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: [ERR]: LN: Client certificate error (application verification failure).
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: [ERR]: LN: SSL accept failed (certificate verify failed).
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: Cert verify: subject<EMAIL_ADDRESS>Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: Cert verify: issuer<EMAIL_ADDRESS>Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: Cert verify CTN: cert fail, cert-to-name will continue on the next cert in chain.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: Cert verify: depth 0.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: Cert verify: subject<EMAIL_ADDRESS>Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: Cert verify: issuer<EMAIL_ADDRESS>Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: Cert-to-name unsuccessful, dropping the new client.
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: Client certificate error (application verification failure).
Aug 08 09:45:01 13266--SW--MCP7 netopeer2-server[41237]: SSL accept failed (certificate verify failed).
Aug 08 09:45:03 13266--SW--MCP7 netopeer2-server[41237]: Call Home client "default-client" endpoint "endpoint-tls" failed connection attempt limit 3 reached.
Aug 08 09:45:03 13266--SW--MCP7 netopeer2-server[41237]: [INF]: LN: Call Home client "default-client" endpoint "endpoint-tls" failed connection attempt limit 3 reached.
Aug 08 09:45:03 13266--SW--MCP7 netopeer2-server[41237]: [INF]: LN: Call Home client "default-client" endpoint "endpoint-tls" connecting...
Aug 08 09:45:03 13266--SW--MCP7 netopeer2-server[41237]: [INF]: LN: Trying to connect via IPv4 to <IP_ADDRESS>:4335.
Aug 08 09:45:03 13266--SW--MCP7 netopeer2-server[41237]: [INF]: LN: getsockopt() error (Connection refused).
Aug 08 09:45:03 13266--SW--MCP7 netopeer2-server[41237]: Call Home client "default-client" endpoint "endpoint-tls" connecting...
Aug 08 09:45:03 13266--SW--MCP7 netopeer2-server[41237]: Trying to connect via IPv4 to <IP_ADDRESS>:4335.
Steps to Reproduce:

Start the netopeer2-server.
Run listen --tls command from netopeer2-cli.
Observe the error log.

Expected Behavior:
The TLS Call Home connection should be established successfully.
Actual Behavior:
The connection fails with the error: SSL accept failed (certificate verify failed).
Any help resolving this issue would be greatly appreciated.
regard
aarti

Please create a new discussion item for this question rather than adding to a long closed old issue:
https://github.com/openssl/openssl/discussions/new?category=q-a


Should Add Docstrings

In preparation for proper docs, each module, class and method should have reasonable documentation describing functionality, allowed parameters, expected response objects, and possible exceptions. As this is done, it can be extracted and published to ReadTheDocs.

(Provisionally assigning myself to this in case I have some spare time.)

Could I do some of those for the "hacktoberfest"? Is it just adding comments to the things in https://github.com/Nexmo/nexmo-python/blob/master/nexmo/init.py ?

I would like to start work on this!


First draft of team roll call

"team" looked sad and empty, and so I spent a little time doing a H.I. crawl of podcastindex.social for posters, adding most everyone in a randomish order as I followed through threads here and there.

Oh wow. Mike, thanks so much for spending time doing this. What a great contribution this is. 😍

Hm, we should add an "Add me to a random position on the list" button... :-)

@saerdnaer , I don't disagree.  My skills pretty much limit me to reading through what I can see/follow on Mastadon, rudimentary Markup, and hoping I don't screw up anything while doing the commit/pull request. :)