[Bug] Bestow Curse Concentration

Hello,
I've discovered that upon casting Bestow Curse at third level, the Concentration Active Effect does not recognize the spell it is supposed to be linked to:

Which implies that when concentration is lost on the source actor, a target affected by the spell will not lose the spell effect on its Active Effect list. Not that this is a big deal, its just kind of annoying.
However, if the effect is manually deleted from the target effect list, concentration is automatically lost on the source actor.
Don't know why it does not work both ways, but it might be interesting to look into it.
I'm using v11.308 and DnD5e 2.3.1. This can be reproduced with only the required modules.

Update: it seems there's something wrong with Midi-QOL concentration automation as of 11.0.18. This might be why I got an unlinked concentration effect. I've posted the problem on the Midi project page, so I'll keep you guys updated if anything changes.

The latest release of midi and dae were released right before the bossman went on a mini vacation and he had given us a warning that there was a chance some breakages would occur with effect application due to a dramatic rework.  I can't confirm/reproduce but if you are experiencing this problem, you can always step down, but if you do, go down in both midi and dae 1 major version.

I stepped down to Midi 10.0.60 and DAE 10.0.38, even tried Midi 11.0.17 and DAE 11.0.12 for good measure and unfortunately it did not solve the issue. I might be wrong, but it seems to be directly related to the way the function for Bestow Curse triggers concentration on the source actor. Midi doesn't seem to be involved in this case, as I first thought.

Fixed in the newest update.


Feature: Setup/Teardown groupings for Before/After hooks

This change represents Cucumber Before/After hooks as Setup/Teardown steps within the Allure2 report.
To do this, I add the hooks as provided by the supportCodeLibrary from Cucumber's Formatter as a property so methods can access it, then for each step I test if the line & uri can be found among either Before or After hooks.
If the step can be identified as a Before or After hook, it then tries to name it by its function name.
Example:
Before(function initializeTestClients(scenario, callback) {
    // Do stuff
});

The resulting step will be named Before: initializeTestClients. If a function name is not available (anonymous functions), then it falls back to the existing uri:line representation.
I've also removed the console log. You could use this.log to output to console or dummy.txt, but using console.log clutters the formatter I'm outputting to stdout if I have this formatter outputting to a dummy file.

Hi, sorry, I was off the grid for a couple of days. Will have a look at this soon.

Please add some code into the features folder that will test what is added in this PR.
I think it should be at least 4 test cases: before named + unnamed, after named + unnamed.

👍 I'll step to that later today

@korobochka I've added tests in commit d1e71c1. The report as generated looks like this:

Before/After hooks are added to the Set up & Tear down collections, and are ordered per their actual execution timing when joined with Background steps.
Before/After hooks are prefixed with Before/After keyword similarly to all other steps prefixed by their respective Given/When/Then keywords
Before/After hooks may be named in test code as shown by setupTestCase and teardownTestCase, or left anonymous to be represented as uri:line as before this change.
Before/After hooks are hidden/non-expanded by default, leaving the test report showing only relevant Test Body at a glance.

Tested this a bit, looks good!
Thank you for the contribution.
Only comment is that you have a couple of unneeded ! in the code after explicit check for undefined, but I will remove them.
Example: location.actionLocation!. ...


Using Customize(..) for defaults

I've been using AutoFixture for sometime now and only recently discovered Customize<T>(..). Which, by my understanding can be used for setting build/generation rules on a higher level. To avoid having to set With and Without on each Build<T>(..).
My question is:
If I customize with: Fixture.Customize<MyObj>(x => x.Without(y => y.ID))
and later I wish to set the ID property with a Build<MyObj>().With(x => x.ID), it throws an exception saying "The specimen created for assignment is not compatible with System.Int64". Is this a bug or expected behavior? I can set the property with Build<MyObj>().With(x => x.ID, fixture.Create<long>()), but that means more typing ^^
Is there another way of setting default values?
Sorry if I am posting this on the wrong forum.

@LazyTarget, do you consider your question answered?

This didn't answer my question, but we can close this as I am working on other projects now

I may have misread the original question, then; I've now edited the question to format code as code, so that the generic type arguments are visible. I'll take a look later today.

Hmm... This actually looks like a bug, although I've still not gotten to the bottom of the issue. However, using the type definitions posted by @moodmosaic above, this test seems to reproduce the issue:
[Fact]
public void Repro()
{
    var fixture = new Fixture();
    fixture.Behaviors.Add(new TracingBehavior());
    fixture.Customize<Route>(x => x.Without(y => y.Id));
    var r = fixture.Build<Route>().With(x => x.Id).Create(); // throws
    Assert.NotEqual(default(long), r.Id);
}

The output of running this test is:
Test 'ClassLibrary1.Tests.Repro' failed: System.InvalidOperationException : The specimen created for assignment is not compatible with System.Int64.
	at Ploeh.AutoFixture.Kernel.BindingCommand`2.CreateAnonymousValue(ISpecimenContext container)
	at Ploeh.AutoFixture.Kernel.BindingCommand`2.Execute(Object specimen, ISpecimenContext context)
	at Ploeh.AutoFixture.Kernel.Postprocessor`1.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Kernel.Postprocessor`1.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Kernel.FilteringSpecimenBuilder.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Dsl.NodeComposer`1.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Kernel.RecursionGuard.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Kernel.TracingBuilder.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Kernel.TraceWriter.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Dsl.CompositeNodeComposer`1.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Kernel.SpecimenContext.Resolve(Object request)
	at Ploeh.AutoFixture.Kernel.SeedIgnoringRelay.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Kernel.FilteringSpecimenBuilder.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Dsl.NodeComposer`1.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Kernel.CompositeSpecimenBuilder.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Kernel.RecursionGuard.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Kernel.TracingBuilder.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Kernel.TraceWriter.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Dsl.CompositeNodeComposer`1.Create(Object request, ISpecimenContext context)
	at Ploeh.AutoFixture.Kernel.SpecimenContext.Resolve(Object request)
	at Ploeh.AutoFixture.SpecimenFactory.Create[T](ISpecimenContext context, T seed)
	at Ploeh.AutoFixture.SpecimenFactory.Create[T](ISpecimenContext context)
	at Ploeh.AutoFixture.SpecimenFactory.Create[T](ISpecimenBuilder builder)
	at Ploeh.AutoFixture.SpecimenFactory.Create[T](IPostprocessComposer`1 composer)
	Code.cs(33,0): at ClassLibrary1.Tests.Repro()

Output from ClassLibrary1.Tests.Repro:
  Requested: Ploeh.AutoFixture.Kernel.SeededRequest
      Requested: ClassLibrary1.Route
        Requested: Int64 Id
        Created: Ploeh.AutoFixture.Kernel.OmitSpecimen

As we can see from the trace, the request is correctly for an Int64 property called Id, but the returned value is an OmitSpecimen, which very strongly suggests that the customization is still in effect. This hypothesis is confirmed by removing the Customize<Route> call:
[Fact]
public void Works()
{
    var fixture = new Fixture();
    var r = fixture.Build<Route>().With(x => x.Id).Create();
    Assert.NotEqual(default(long), r.Id);
}

This test passes.
As the documentation of the Build method states

the Build method chain is best understood as a one-off Customization. It bypasses all Customizations on the Ploeh.AutoFixture.Fixture instance.

Thus, the observed behaviour seems to be incorrect.

Hi,
I'm having a similar question as the OP. I was hoping to use Customize in the way I was using a extension method before. This is the code I used to have:
Fixture fixture = new Fixture();
fixture.MyModelBuilder().With(x => x.Attr1, "AnotherValue").....Create();

Inside MyModelBuilder I'm setting default values for some properties. I was hoping I could use the Customize method and then later if I use fixture.Build<MyModel> the same customization applied. But after reading the documentation for the build method I know realize is impossible to use Build for this purpose.
I'm pretty sure there must be a valid reason for why Build cannot use the build used on the customization, but my question is this: Is it possible to access it somehow?
The other option I have is just to go ahead with the customization and do something like this:
Fixture fixture = new Fixture();
fixture.Customize<MyModel>(x => x
    .With(....) )
var myModel = fixture.Create<MyModel>();
myModel.Attr1 = "Another Value";
... // more customizations

a bit of boilerplate code on the example, I'm not really using the fixture like this because I have it as a DataAttribute with the customization applied, but the idea is that I can create the Object and change whatever value I need without the builder.
I don't know if this is the way to go, but if you have any recommendation it will be greatly appreciated.


How to stop user from pasting image directly inside editor?

I want user to provide image only through link. So i want to prevent from direct copy and pasting image inside editor. How to do this. Otherwise user may mistakenly paste a lots of image directly , which will slow down netowrk query or sometimes it may stop network query.

There are no related options.
You can prevent it in the following way:
editorInstance.core._setClipboardComponent = function (e) {
  e.preventDefault();
  e.stopPropagation();
  return;
}

But this doesn't make much sense because you can copy with range selection.

There are no related options. You can prevent it in the following way:
editorInstance.core._setClipboardComponent = function (e) {
  e.preventDefault();
  e.stopPropagation();
  return;
}

How to do this in react with typescript. This is important thing because user could mess up by pasting lots of images in a document directly herby increasing document size.

editorInstance.onPaste =  (e, cleanData, maxCharCount, core) => {
    const dom = core._d.createRange().createContextualFragment(cleanData);
    const chilren = dom.childNodes;
    let html = '';
    chilren.forEach(v=> {
        html += core.util.isComponent(v) ? '' : (v.outerHTML || v.textContent);
    })
    return html;
}

Does this stops pasting everything or only image?


Fuzz test profiling

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.

Codecov Report
Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 65.99%. Comparing base (1ecd94c) to head (780e258).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
- Coverage   66.17%   65.99%   -0.19%
==========================================
  Files         187      188       +1
  Lines       23171    23476     +305
==========================================
+ Hits        15334    15492     +158
- Misses       7837     7984     +147

Components
Coverage Δ

crashtracker
19.34% <ø> (ø)

datadog-alloc
98.37% <ø> (ø)

data-pipeline
51.45% <ø> (ø)

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
81.52% <ø> (+0.29%)
:arrow_up:

ddcommon-ffi
74.93% <ø> (ø)

ddtelemetry
53.72% <ø> (ø)

ipc
81.27% <ø> (ø)

profiling
76.75% <0.00%> (-0.09%)
:arrow_down:

profiling-ffi
60.05% <ø> (ø)

serverless
0.00% <ø> (ø)

sidecar
31.75% <51.32%> (+2.07%)
:arrow_up:

sidecar-ffi
0.00% <0.00%> (ø)

spawn-worker
54.98% <ø> (ø)

trace-mini-agent
69.12% <ø> (ø)

trace-normalization
97.79% <ø> (ø)

trace-obfuscation
95.74% <ø> (ø)

trace-protobuf
25.64% <ø> (ø)

trace-utils
68.85% <ø> (ø)


fix(core): fix the remote column inferring and disable simplify expression rule

Description
This PR fixed multiple issues.
Disable SimplifyExpressionRule
This rule will simplify an expression to another expression if it can be evaluated. For example, current_date would be simplified to the real value like CAST('2024-10-31' DATE). However, we should execute this function on the DataSource side to make sure the time or timezone issue can be aligned.
Fix the Remote Column inferring
The remote column has some bugs. I missed to apply this way when generating the ModelSourceNode.
Fix the isHidden field
We always serialize the field name using camelCase style.

@goldmedal Could you check the transformed SQL is changed for Postgres?

@goldmedal Could you check the transformed SQL is changed for Postgres?

The planned SQL is
SELECT
  orders."timestamp",
  orders."timestamptz",
  orders.order_cust_key,
  orders.o_custkey,
  orders.o_orderdate,
  orders.o_orderkey,
  orders.o_orderstatus,
  orders.o_totalprice
FROM
  (
    SELECT
      CAST(
        '2024-01-01T23:59:59' AS TIMESTAMP
      ) AS "timestamp",
      CAST(
        '2024-01-01T23:59:59' AS TIMESTAMP WITH TIME ZONE
      ) AS "timestamptz",
      concat(
        CAST(
          public.orders.o_orderkey AS VARCHAR
        ),
        '_',
        CAST(
          public.orders.o_custkey AS VARCHAR
        )
      ) AS order_cust_key,
      public.orders.o_custkey AS o_custkey,
      public.orders.o_orderdate AS o_orderdate,
      public.orders.o_orderkey AS o_orderkey,
      public.orders.o_orderstatus AS o_orderstatus,
      public.orders.o_totalprice AS o_totalprice
    FROM
      public.orders
  ) AS orders
LIMIT
  1

The dialect SQL is
SELECT
  orders."timestamp",
  orders."timestamptz",
  orders.order_cust_key,
  orders.o_custkey,
  orders.o_orderdate,
  orders.o_orderkey,
  orders.o_orderstatus,
  orders.o_totalprice
FROM
  (
    SELECT
      CAST(
        '2024-01-01T23:59:59' AS TIMESTAMP
      ) AS "timestamp",
      CAST(
        '2024-01-01T23:59:59' AS TIMESTAMPTZ
      ) AS "timestamptz",
      CONCAT(
        CAST(
          public.orders.o_orderkey AS VARCHAR
        ),
        '_',
        CAST(
          public.orders.o_custkey AS VARCHAR
        )
      ) AS order_cust_key,
      public.orders.o_custkey AS o_custkey,
      public.orders.o_orderdate AS o_orderdate,
      public.orders.o_orderkey AS o_orderkey,
      public.orders.o_orderstatus AS o_orderstatus,
      public.orders.o_totalprice AS o_totalprice
    FROM
      public.orders
  ) AS orders
LIMIT
  1

It seems to generate TIMESTAMPTZ, so the result has a UTC suffix.


FloatingPanel: Migrate to swift 4.2

This is an attempt to migrate FloatingPanel's codebase to Swift 4.2. @SCENEE Let me know if I missed anything or any suggestions that you may have for this PR to get merged.

Could you please see PR https://github.com/SCENEE/FloatingPanel/pull/121?

Makes sense!


[FLINK-15332][jepsen] Copy flink-s3-fs-hadoop* into /plugins directory instead of lib

What is the purpose of the change
We can no longer copy the flink-s3-fs-hadoop* jars into lib as they contain un-relocated
Hadoop 3.1.0 dependencies.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Thanks for the review @carp84 & @GJL. Merging this PR now.


Opening Pdfs with Password fails

09 September 15 th July PW 6BA065200.pdf
While making a call to ToImage method in Conversion with the correct password  as shown below
using var inputStream = new FileStream(pdfFilePath, FileMode.Open, FileAccess.Read);
var image = Conversion.ToImage(inputStream, password, page: 0);
the code fails with the an Exception PDFtoImage.PdfiumViewer.PdfException: 'Password required or incorrect password'
at line 30 in file PDFtoImage\PdfiumViewer\PdfFile as after call to NativeMethods.FPDF_LoadCustomDocument in line 28
var document = NativeMethods.FPDF_LoadCustomDocument(stream, password, _id);
if (document == IntPtr.Zero)
throw new PdfException((PdfError)NativeMethods.FPDF_GetLastError());
*Attached a PDF file with password to test. Please use password 6BA065200 to test

Hi @kumar-vasan, thank you for reporting this! I could reproduce this issue and am working on a bugfix.

@kumar-vasan PDFtoImage 2.4.1 is available now, please give it a try!

Thanks a lot @sungaila .


win version

any chance to see and opensourced win version either ?

There are currently no plans to open source the Windows versions.

@MarioHewardt ,
but, may be possible make it open source, but with any 'closed' licence..?
so, people could pull patches for it..


[Rust][Fix] Memory leak

I found a really dumb memory leak that was probably introduced by @mwillsey and I refactoring the Function and Object system and debugging memory issues. The old drop implementation was now invalid in the new owned function model.
Instead of replicating RC behavior I added an inner owned pointer which drops the underlying allocation and wrapped it in an Arc.
cc @Lunderberg @schell

Thanks @jroesch and @Mousius !


Webpack 2.0 feature: treeshaking / native-module supported?

Hi @mxstbr thanks for making such an amazing boilerplate! I noticed the webpack version in package.json is 2.0+ and seems to be able to support treeshaking. Is this feature already built into react-boilerplate?

Yeah, it is!


Add files via upload

New Workbook for Sensitive Operations in Azure Activity Logs Review

@ITSec365 : Please resolve the validation errors

After deploying the workbook in our environment, we could see below

Updated filenames with Black and White. Also added those files with new names.

@ITSec365 : Thanks for providing the images.
We could see empty after deploying the workbook, please add at least 4 charts / graphs in the workbook.

Please remove the one .json from workbook metadata from below

Updated the template relative path in metadata file.

Regarding the blank workbook, can you close the workbook and retry again (open workbook from deployment page). Sometimes, it may take few min to load the data.

@ITSec365 : Please address the above comments


Release 0.0.1

@all-contributors add @aloubyansky  for code and maintenance

@all-contributors add @aloubyansky  for code and maintenance


mc_pos_control: delta_t needs to be positive

this bug only occurred during transition from downward flight to altitude engaged

tested outside and can be merged. the setpoint is now set correctly when flying downward and entering altitude engaged


Investigate alternative ways to storing geometry data from project table

Currently, the districts column is stored as a jsonb field which stores JSON/GeoJSON on the project level. It holds derived districts data and can change through update transactions. jsonb has the flexibility of storing objects with non-fixed property/key list. Storing coordinates along with properties conforms with GeoJSON standards and allows geometry related operations. Meanwhile, such un-encoded coordinate data can be bulky to store and may take longer time in frequent update transactions.
This issue is to investigate alternative ways to storing geometry data from project table and check/test with some examples/instances if such alternative(s) can alleviate the above mentioned potential bottlenecks. An ideal result of this issue would be to have such alternatives listed out and be ready for more discussions in an ADR.

To @maurizi @BryanQuigley @dmcglone : please feel free to share more details and have discussions here

I think this would be a good situation for a bake-off; if I recall correctly, the GeoJSON-in-jsonb approach was taken to avoid high processing costs associated with encoding / decoding GeoJSON from/to PostGIS geometries, which has caused problems for us on other projects. So we might want to prototype a different approach to make sure that it doesn't just trade one set of problems for a different set.


Status API endpoint and improved switching between APIs

Adds the server_status to the APIs so that we can check whether we've restarted from an upgrade and call start_consensus.  Removes the need for passing in an upgrade arg and the upgrade.sh test.
Also found a solution that fixes #2264 (figured out how to force the server to stop via the TaskGroup handler).  May also fix #2262?

@dpc think I addressed all your feedback now?


Is it possible to use HTML Table tag inside BodyAsHtml on iOS/Android

	public void SendForm(string to, string subject, List<string> data, string cc, List<string> bcc, List<string> filePath) {
		var emailTask = MessagingPlugin.EmailMessenger;
		var email = new EmailMessageBuilder ();

		email.To (to);
		email.Subject (subject);
		email.BodyAsHtml ("

T1	T2

T3	T4

T5	T6/td>

T7	T8

span 2

");
		emailTask.SendEmail (email.Build ());
	}

I have tried something like this on my native side (I am building a cross-platform application). But I cannot see the table generated inside Gmail or Native email apps on my ASUS Zenfone 2 only the content of the table (just like "T1T2T3T4T5T6T7T8span 2".

The plugin doesn't do anything special with regards to html formatting.  I'm not sure which tags are supported on the different platforms and what workarounds are required to get it working.  As there is nothing that the plugin can do about this, I'm closing the issue.


[WIP] Adding mixin classes for pyro training and posterior sampling

This PR aims to add classes mixin classes for pyro training and posterior sampling.

Interestingly, the last test works but cell2location with full data and non-amortised inference gives an error which I do not quite understand. See HTML attached (can be reproduced by taking this notebook to colab).
cell2location_analysis_3_scvi_ln_full_data.html.zip

Accidentally merged pyro-cell2location and reverted that.

Sorry for the accidental merge again, I don't get why this merge happened. I am trying to merge pyro-mixin into pyro-cell2location branch using GitHub pull request web interface. For some reason, that seems to create a merge commit from pyro-cell2location into pyro-mixin.

@adamgayoso after talking to @martinjankowiak I think the default optimiser should be Adam, not ClippedAdam. I can change that. Should I modify this branch/PR or create a new one?


Promote crossplane

A few improvements:

promoting to crossplane and crossplane-runtime latest libraries
making build folder a submodule, rather than checking in as code (the current state)
adding debug option

Created release v0.1.1 including this PR.
Also built and pushed stack image as turkenh/stack-existing-cluster:v0.1.1.


flutter_gallery_3d not scrolling when used inside a pageview

I am using your package inside a pageview and facing a issue is that flutter_gallery_3d view is not scrolling anymore
When I tried to scroll it, then main pageview is navigating but flutter_gallery_3d is not scrolling.
I just simply want that flutter_gallery_3d view should normally scroll as normal list and when I scroll outside then it must be navigate to next pageview screen.

I fixed it,you can try flutter_gallery_3d: ^1.0.5

I fixed it,you can try flutter_gallery_3d: ^1.0.5

working like a charm !!!

Can you please look at this issue as well
https://github.com/pharous-flutter/drawer_swip/issues/3#issue-1501753007

emmm,show me you code?

emmm,show me you code?

Yes sure here it is..
      extendBody: true,
      endDrawerEnableOpenDragGesture: false,
      key: _scaffoldKey,
      body: LiquidPullToRefresh(
        key: _refreshIndicatorKey,
        color: AllColors.appColor,
        backgroundColor: Colors.white,
        onRefresh: _handleRefresh,
        showChildOpacityTransition: true,
        child: SwipeDrawer(
          radius: 20,
          key: drawerKey,
          hasClone: false,
          bodyBackgroundPeekSize: 30,
          backgroundColor: Colors.red,
          drawer: buildDrawer(context),  // side drawer widget

          child:   buildBody() ,   // whole screen body
        ),
      ),
    );```


Update dependency org.mongodb:mongo-java-driver to v3.10.2

This PR contains the following updates:

Package
Update
Change

org.mongodb:mongo-java-driver
patch
3.10.1 -> 3.10.2

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


contracts: handleBlockchainEvents should run repeatedly

When an endpoint does multiple things handleBlockchainEvents should deal with all the requests instead of just one (which is why you often need multiple handleBlockchainEvents)

#1574


disable devel build for vrpn package

Disable devel build for the third party package vrpn.

This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/patching-mechanism-for-releasing-third-party-package-in-ros2/26491/3


has_content on edit does not match

Rails 3.1.2 app.  I can do a new action go to the show page and find elements not problem.  when I have an object then go to the edit screen the matcher does not find the text.  I can do a save_and_open_page and the text is in the view.
scenario "Problem Edit" do
@problema = Factory.create(:problem, :name => 'Type II Diabetes')
visit edit_problem_path(@problema)
save_and_open_page
page.should have_content("Type II Diabetes") --> Not seeing it even though the save and open shows it.
end

I think the problem you are having might be that has_content ignores the values of input boxes, if I recall correctly. You should probably find the input field and then call the .value method on it.
If you need more help, I recommend asking on the mailing list. This issue tracker is meant for reproducible bugs only.


Missing new resource aws_eks_pod_identity_association in 6.13.0

What happened?
Hi,
Release https://github.com/pulumi/pulumi-aws/releases/tag/v6.13.0 states it's using https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.29.0
In 5.29.0, there's a new resource named aws_eks_pod_identity_association but it doesn't appear in this provider newest release. Was there anything that prevented the new resource from being imported in the new release?
Example
n/a
Output of pulumi about
n/a
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Looks like this is originating from
https://github.com/hashicorp/terraform-provider-aws/blob/master/internal/provider/fwprovider/provider.go#L376
This code performs tags schema check and filters out resources that don't meet the schema check.  Unfortunately the errors are sent as warnings via tflog and that is completely missed in our provider at the moment, which makes it skip out this resource.
The reason that the check started failing is because as a consequence of https://github.com/pulumi/pulumi-aws/issues/2895 we moved tags handling to Pulumi level and edited the schema of resources to change the Computed attribute on tags.

@aureq thanks for reporting. We are looking into the issue. Perhaps as a workaround you can try using the resource from the
native provider? https://www.pulumi.com/registry/packages/aws-native/api-docs/eks/podidentityassociation/

`tags_all` attribute must not be Computed: aws_docdbelastic_cluster
`tags_all` attribute must not be Computed: aws_eks_pod_identity_association
`tags_all` attribute must not be Computed: aws_s3control_access_grant
`tags_all` attribute must not be Computed: aws_s3control_access_grants_instance
`tags_all` attribute must not be Computed: aws_s3control_access_grants_location

More resources affected here.


Wait for listener callbacks to finish when removing listener

Before this change it was possible that a callback was executing even after the call to remove a listener has returned.
This is a problem if the callback context is immediately destroyed after the listener has been removed. The callback might continue to access the now invalid context.

Thanks for your clarification. I am talking with the team to get opinions the issue, the expected behavior of the removing token function, and the PR. Will get back to your ASAP.


Multiple datasets not working when remote data sources used (introduced in latest release)

I am having the same issue as described here: https://github.com/twitter/typeahead.js/issues/104
I'm not sure whether I should be commenting in there, or creating a new issue, but since that was closed over a year ago I've chosen the latter.
The Typeahead example page shows how to use multiple datasets with Typeahead/Bloodhound. It works great when a local or prefetch data source is used, but it does not work with a remote data source.
I posted my problem on StackOverflow before stumbling across the above issue: http://stackoverflow.com/questions/24727145/multiple-datasets-not-working-with-twitter-typeahead-bloodhound-when-remote-data
I am using the latest version of Typeahead and Bloodhound from here: http://twitter.github.io/typeahead.js/releases/latest/typeahead.bundle.min.js

Hello,
i am using bloodhounds js to bind autocomplete textbox. I am using cascading autocomplete just like select county & retrieve corresponding state.
When i select first country i got data in state autocomplete & again i select another country then same data display in state field.
bloodhounds data source is not returning update data. it returns old data.I am using local Storage option in bloodhounds  js.
kindly suggest.
Thanks,
Sachin


newton and newton cg freeze rather than stopping

I've seen a few times while developing that newton and newton cg will hang indefinitely sometimes in the case of non-convergence, pegging the CPU with no output.

Thank you for reporting! Could you provide a minimal example to reproduce the issue, please?

I think I've run into a similar issue with BFGS. I think the issue may be with the solvers starting a new optimization problem for the linesearch in the next_iter function, without passing on things like max_iters or timeout. So a single step may run essentially forever for more complex problems as the default of u64::MAX is used. I would think those options should be passed on even though the linesearch problem should be easier to solve.

In my case, changing the width tolerance of the linesearch also solved the issue, suggesting that this is in fact the root cause.


add orange as cell highlight for reserved

This was a feature wished by some of our volunteers:

Highlight the status in the items tab if it's reserved. This makes it harder to accidentially give out items that are reserved.

I don't think we need this for any other status, as they either indicate it is not there anway (i.e. cannot be given out accidentially), or is available, so can be given out.

@skjerns I think this is because the tests also test for the background color which you changed. I think you have to add the new color in the expected test data.

suddenly the test... passes?

ping @daniel17903 😇


identify if pokemon game is in a battle/cutscene or not

If it is in a battle enable the gifs, otherwise it's just a movement and gif is not necessary
(also don't need to progress game by x frames if nothing is happening)

Fixed in #11, using PIL to identify if the game is still progressing, if not stop ticking the clock


Environment variable substitution doesn't check properties files

Describe the bug
Properties defined in env/default cannot use substitutions from properties defined an environment (e.g.  env/foo)
For example: We want to define property templates in default and have values substituted for each environment the specs are executed in
E.g.
env/default/global.properties
TEMPLATE=something.${MYVAR}

env/foo/some.properties
MYVAR=testing

When you run with --env foo you would expect the property TEMPLATE to resolve to "something.testing"
However you get the error below
'MYVAR' env variable was not set

The issue is due to the function below never checking against the properties already loaded from properties files (envVars) and only checking the system environment variables
func substituteEnvVars() error {
	for name, value := range envVars {
		contains, matches := containsEnvVar(value)
		// if value contains an env var E.g. ${foo}
		if contains {
			for _, match := range matches {
				// check if match is from properties file
				// if not, get from system env
				envKey, property := match[0], match[1]
				// error if env property is not found
				if !isPropertySet(property) {
					return fmt.Errorf("'%s' env variable was not set", property)
				}
				// get env var from system
				propertyValue := os.Getenv(property)
				// replace env key with property value
				value = strings.Replace(value, envKey, propertyValue, -1)
			}
			// overwrite the envVar value
			envVars[name] = value
		}
	}
	return nil
}

I can submit a PR with tests to fix this issue
What command(s) did you run when you found the bug?
gauge run specs --env foo

Output, stack trace or logs related to the bug
gauge run --env foo specs
Error ----------------------------------
'MYVAR' env variable was not set
Get Support ----------------------------
Docs:          https://docs.gauge.org
Bugs:          https://github.com/getgauge/gauge/issues
Chat:          https://gitter.im/getgauge/chat
Your Environment Information -----------
windows, 1.0.6
go (0.1.2), html-report (4.0.8), java (0.7.2), python (0.3.5), screenshot (0.0.1), spectacle (0.1.3), xml-report (0.2.1)
Versions
Issue is present in current code base
Gauge (Output of gauge -v)
gauge -v
Gauge version: 1.0.6
Plugins
go (0.1.2)
html-report (4.0.8)
java (0.7.2)
python (0.3.5)
screenshot (0.0.1)
spectacle (0.1.3)
xml-report (0.2.1)
Node.js/Java/Python/.Net/Ruby version
NA
Operating System information
NA
IDE information
NA

@opursail A PR to fix this will be great.
It might also solve an earlier issue that was reported around something similar https://github.com/getgauge/gauge/issues/1428

Yes it would solve the issue for #1428  without changing the existing syntax
Example
service_url=http://service.com
api_url=${service_url}/api/endpoint


[FEATURE] Implement Rainbow DQN

Feature: Implement Rainbow
Rainbow (paper) is a combination of several DQN variations:

[x] Vanilla DQN (Q-learning + CNN)
[x] Double DQN
[x] Prioritized Experience Replay (via Flashbax)
[x] Dueling DQN
[ ] DQN with multistep bootstrap targets (is this currently supported?)
[x] Distributional DQN
[ ] Noisy DQN (paper)

Checklist:

[ ] Implement Noisy DQN
[ ] Implement n-step DQN (if not already supported)
[ ] Define Rainbow as:

A quantile-regression DQN with a multistep distributional loss
Use double Q-learning to the loss function
Prioritize experience replay w.r.t the KL loss
Use a dueling network adapted for return distributions
Replace linear layers with their noisy equivalent

[ ] Sanity check: the resulting algorithm should outperform its individual components

So I guess the first step would be to define new linear layers as:
$$\begin{align*}
y&=(\mu^w+\sigma^w \odot \epsilon^w)\cdot x + \mu^b + \sigma^b \odot \epsilon^b \
\
&\begin{cases}
\text{weight } &= \mu^w+\sigma^w \odot \epsilon^w \
\text{bias } &= \mu^b + \sigma^b \odot \epsilon^b \
\mu^w,\mu^b, \sigma^w, \sigma^b&: \text{learnable parameters} \
\epsilon^w, \epsilon^b&: \text{noise random variables}
\end{cases}
\end{align*}$$
Any recommendations to get started with this?

So I guess the first step for Noisy DQN would be to define new linear layers as:
y=(μw+σw⊙ϵw)⋅x+μb+σb⊙ϵb{weight =μw+σw⊙ϵwbias =μb+σb⊙ϵbμw,μb,σw,σb:learnable parametersϵw,ϵb:noise random variables
Any recommendations to get started with this?

Hey, so yeah basically, i imagine something like that. I guess structurally we can create a new file in the networks folder called layers.py and put a noisy linear layer in there. Then a new network in torso.py that is a noisy MLP torso.
Additionally, regarding "DQN with multistep bootstrap targets (is this currently supported?)" the easiest short term solution for this is to use a trajectory buffer instead of a item buffer. That will allow us very easily to construct the n-step targets and is most likely how i would do it if i had to code it right now.


Can't sell items from containers

Selling items by dragging them from a container into a merchant loot sheet doesn't do anything.

FVTT 0.7.7
PF1e 0.76.6
Loot Sheet 1.7.1

Version 1.9.0 has limited support for containers but doesn't support drag-and-drop from a container yet.

I'll close this issue for now because I don't plan to implement it for now (too busy with my other modules).


Add basic reprojection documentation

Still something of a work-in-progress as I haven't tested the WCS tools nor gotten all the .rst syntax right.
cc @e-koch

Codecov Report

Merging #776 (e8d3506) into master (1f67a8f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #776   +/-   ##
=======================================
  Coverage   77.86%   77.86%
=======================================
  Files          24       24
  Lines        5811     5811
=======================================
  Hits         4525     4525
  Misses       1286     1286

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f67a8f...e8d3506. Read the comment docs.

OK I think all the links work now


Quick fix for "impl Trait"

Remove "TODO" conversion
Add a couple of simple test cases

Fixes #1154
Fix courtesy of @singaraiona

Looks good, thanks!


fix(package): update modern-logger to version 1.4.8

Closes #462

Coverage remained the same at 8.135% when pulling 679dbbdc720b36e55d57d5ac32a99525d3285e6e on greenkeeper/modern-logger-1.4.8 into 2fa6047cdcf2f062d1cbf795e4f773786f3e3712 on master.


General code review

I did this library all alone in my journeys home/office, so it would be a pleasure if you want to share your opinion with me and do a code review about the structure or another part.
We can refactor any part of the code or get rid off if you think that it is horrible.

@edgarordonez
Fixed in this PR: https://github.com/edgarordonez/d3-stencil/pull/43
I recommend to close this issue and make a new one that includes
planning for D3-Stencil v2.0.0 future and website development.


Add documentation for C++

Mainly added two pages: one for C++ tools and one for C++ Core API. Split them from Java parities.

@omalley @majetideepak @xndai
This patch adds the documentation for C++ tools and core API. Please take a look when you have time. Thanks!

I just committed this. Thanks @majetideepak for review!


Making BigtableOptions serializable, and adding equals and toString().

A minor thing, otherwise LGTMed.

Fixed the equals method.  Merging.


[bug]

Description (bug summary)
(lldb) dyld[14557]: Library not loaded: @rpath/libswiftCore.dylib
Step to reproduce (how to reproduce the bug)

pubspec.yaml add screen_brightness: ^0.2.2
project run to device (I haven't written the code yet)
add the “usr/lib/swift” path to the Runpath Search Paths. Under debugging, the problem can be solved, but ad hoc or flash back

Platform (Android/iOS/macOS/Windows)
iOS

@zhuwei  Thanks for pointing out the issue, I will check it later.

@zhuwei  I don't have any problem after import the library. Could you share a full error log? I am guessing you import the library while running your app?

@aaassseee Sorry, the problem has been resolved.
After I added a new swift file with space in xcode, it will be fine


Unable to connect to Kinect Sensor Camera

Azure Kinect viewer does not show the connected device.
When I try to refresh I see these errors
[ error    ] : usb_cmd_read(). Read command(00000115) ended in failure, Command status 0x00000012
[ error    ] : usb_cmd_read(depthmcu->usb_cmd, DEV_CMD_DEPTH_READ_PRODUCT_SN, NULL, 0, (uint8_t *)temp_serial_number, sizeof(temp_serial_number) - 1 , &bytes_read) returned failure in depthmcu_get_serialnum()
[ error    ] : depthmcu_get_serialnum(device->depthmcu, serial_number, &serial_number_size) != K4A_BUFFER_RESULT_SUCCEEDED returned failure in k4a_device_open()
I have checked the device manager all seems ok.
I have a constant white light at the back of the device.
Followed all the troubleshooting steps mentioned here - https://docs.microsoft.com/en-us/azure/Kinect-dk/troubleshooting section "Azure Kinect Viewer fails to open"
Have done factory reset too.
When I try to update the firmware for the first time below error messages were generated -
C:\Program Files\Azure Kinect SDK v1.4.0\tools>AzureKinectFirmwareTool.exe -u firmware\AzureKinectDK_Fw_1.6.108079014.bin
== Azure Kinect DK Firmware Tool ==
Loading firmware package firmware\AzureKinectDK_Fw_1.6.108079014.bin.
File size: 1294306 bytes
This package contains:
RGB camera firmware:      1.6.108
Depth camera firmware:    1.6.79
Depth config files: 6109.7 5006.27
Audio firmware:           1.6.14
Build Config:             Production
Certificate Type:         Microsoft
Signature Type:           Microsoft
Device Serial Number:<PHONE_NUMBER>12
Current Firmware Versions:
RGB camera firmware:      1.2.24
Depth camera firmware:    1.2.19
Depth config file:        5006.27
Audio firmware:           0.3.4
Build Config:             Debug
Certificate Type:         Test
Please wait, updating device firmware. Don't unplug the device. This operation can take a few minutes...
Resetting Azure Kinect S/N:<PHONE_NUMBER>12
[2020-04-14 00:23:24.282] [error] [t=51396] D:\a\1\s\extern\Azure-Kinect-Sensor-SDK\src\usbcommand\usbcommand.c (733): usb_cmd_io().  Error calling libusb_bulk_transfer for initial tx, result:LIBUSB_ERROR_IO
[2020-04-14 00:23:24.317] [error] [t=51396] D:\a\1\s\extern\Azure-Kinect-Sensor-SDK\src\usbcommand\usbcommand.c (900): usb_cmd_io(usbcmd_handle, cmd, p_cmd_data, cmd_data_size, NULL, 0, p_data, data_size, NULL, &cmd_status) returned failure in usb_cmd_write()
[2020-04-14 00:23:24.318] [error] [t=51396] D:\a\1\s\extern\Azure-Kinect-Sensor-SDK\src\depth_mcu\depth_mcu.c (462): usb_cmd_write(depthmcu->usb_cmd, DEV_CMD_RESET, NULL, 0, NULL, 0) returned failure in depthmcu_reset_device()
[2020-04-14 00:23:24.320] [error] [t=51396] D:\a\1\s\extern\Azure-Kinect-Sensor-SDK\src\firmware\firmware.c (302): depthmcu_reset_device(firmware->depthmcu) returned failure in firmware_reset_device()
ERROR: Failed to send the reset command to device S/N:<PHONE_NUMBER>12.
When I try to query the current firmware on the device -
C:\Program Files\Azure Kinect SDK v1.4.0\tools>AzureKinectFirmwareTool.exe -q
== Azure Kinect DK Firmware Tool ==
[2020-04-14 00:33:10.167] [error] [t=39576] D:\a\1\s\extern\Azure-Kinect-Sensor-SDK\src\usbcommand\usbcommand.c (809): usb_cmd_read(). Read command(00000115) ended in failure, Command status 0x00000012
[2020-04-14 00:33:10.168] [error] [t=39576] D:\a\1\s\extern\Azure-Kinect-Sensor-SDK\src\depth_mcu\depth_mcu.c (126): usb_cmd_read(depthmcu->usb_cmd, DEV_CMD_DEPTH_READ_PRODUCT_SN, NULL, 0, (uint8_t *)temp_serial_number, sizeof(temp_serial_number) - 1 , &bytes_read) returned failure in depthmcu_get_serialnum()
[2020-04-14 00:33:10.171] [error] [t=39576] D:\a\1\s\extern\Azure-Kinect-Sensor-SDK\src\firmware\firmware.c (486): firmware_get_serial_number(). Failed to get serial number length
[2020-04-14 00:33:10.585] [error] [t=39576] D:\a\1\s\extern\Azure-Kinect-Sensor-SDK\src\usbcommand\usbcommand.c (809): usb_cmd_read(). Read command(00000115) ended in failure, Command status 0x00000012
Desktop (please complete the following information):

OS with Version: <! Windows 1903 -->
SDK Version:
Firmware version:

Device Serial Number:<PHONE_NUMBER>12
Current Firmware Versions:
RGB camera firmware: 1.2.24
Depth camera firmware: 1.2.19
Depth config file: 5006.27
Audio firmware: 0.3.4
Build Config: Debug
Certificate Type: Test

This is a firmware version that we have never shipped before. So there is something wrong with your device or there is something wrong with how its connected to the PC and we are not able to reliably read it. Do you have a 2nd device you could try out. I am going to assume this is the version reported after factory resetting the device (which can only be performed once - until a new image is successfully installed).
Make sure you are using the factory cables and factory power supply to power the device while confirming the device works as expected.
What USB Host controller are you connected to (https://github.com/microsoft/Azure-Kinect-Sensor-SDK/issues/1088#issuecomment-590762715)? Try different USB ports on your PC.
If you think the firmware version reported is accurate, then I would recommend exchanging the device for a new one.


Tenants

Adding support for tenants.

Blocked by #31 because Tenant management functions are expected to run inside a db.run

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 39 (12.82%)  changed or added relevant lines in 3 files are covered.
19 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.3%) to 74.221%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

foundationdb-bindingtester/src/main.rs
5
16
31.25%

foundationdb/src/database.rs
0
11
0.0%

foundationdb/src/tenant.rs
0
12
0.0%

Files with Coverage Reduction
New Missed Lines
%

foundationdb-bindingtester/src/main.rs
1
89.04%

foundationdb/src/directory/mod.rs
2
94.12%

foundationdb/src/directory/directory_layer.rs
6
92.9%

foundationdb/src/directory/directory_partition.rs
10
81.34%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
4264

Relevant Lines:
5745

💛  - Coveralls

Codecov Report

Merging #70 (a77e107) into main (22ac03c) will decrease coverage by 0.45%.
The diff coverage is 12.82%.

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   82.74%   82.29%   -0.46%
==========================================
  Files          26       27       +1
  Lines        4956     4993      +37
==========================================
+ Hits         4101     4109       +8
- Misses        855      884      +29

Impacted Files
Coverage Δ

foundationdb/src/database.rs
76.92% <0.00%> (+1.65%)
:arrow_up:

foundationdb/src/lib.rs
100.00% <ø> (ø)

foundationdb/src/tenant.rs
0.00% <0.00%> (ø)

foundationdb-bindingtester/src/main.rs
89.03% <31.25%> (-0.55%)
:arrow_down:

foundationdb/src/directory/directory_layer.rs
92.90% <0.00%> (-1.02%)
:arrow_down:

foundationdb/src/directory/mod.rs
94.11% <0.00%> (-0.74%)
:arrow_down:

foundationdb/src/directory/directory_partition.rs
81.34% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Good start.
I think a TenantDatabase type with create_trx, run and transact* methods could be nice.

Good start. I think a TenantDatabase type with create_trx, run and transact* methods could be nice.

I agree :smile: Currently focusing on the bindingTester, but that should be next :rocket:

I have started some work with another pr because I think something is wrong on bindingTester.

Blocked by bindingTester issue. More details here

Given tenant are highly experimental and won't be stable in a short-term, I propose that:

we add more warning about the state of tenants in fdb,
we allow failure on bindingTester when running it with tenant enabled.

Like this, we will be able to merge this work

Maybe put it behind a feature flag.

Maybe put it behind a feature flag.

Sorry for the late reply, i was busy on other subject. You are right, I will do that, once I'm back from holiday 🎄

Ready to be reviewed.
We have used the tenant's feature internally in Clever Cloud, so things are working as expected.
Please bare in mind that this is an experimental feature


Flutter app crashes if calling GoogleMapController.takeSnapShot() before layout complete

Steps to reproduce
Using

google_maps_flutter 2.6.0
google_maps_flutter_android 2.7.0

if I run this code in a callback:
final GoogleMapController controller = await _mapControllerCompleter.future;
final mapImageSnapshot = await controller.takeSnapshot();

and the UI tree layout has not yet completed, the entire app crashes, with this exception:
I/Google Maps Android API( 7700): Google Play services package version: 225014047
I/Google Maps Android API( 7700): Google Play services maps renderer version(legacy): 203115000
I/PlatformViewsController( 7700): Hosting view in a virtual display for platform view: 1
I/PlatformViewsController( 7700): PlatformView is using SurfaceProducer backend
I/GoogleMapController( 7700): No TextureView found. Likely using the LEGACY renderer.
W/wa      ( 7700): File created: _google_maps_sdk_crash_count_2
W/wa      ( 7700): Marker deleted: _google_maps_sdk_crash_count_1
W/wa      ( 7700): Couldn't create marker: _google_maps_sdk_crash_
D/HostConnection( 7700): createUnique: call
D/HostConnection( 7700): HostConnection::get() New Host Connection established 0x7242e1891090, tid 7989
E/AndroidRuntime( 7700): FATAL EXCEPTION: androidmapsapi-Snapshot
E/AndroidRuntime( 7700): Process: app.clicksocial, PID: 7700
E/AndroidRuntime( 7700): java.lang.IllegalArgumentException: width and height must be > 0
E/AndroidRuntime( 7700): 	at android.graphics.Bitmap.createBitmap(Bitmap.java:1111)
E/AndroidRuntime( 7700): 	at android.graphics.Bitmap.createBitmap(Bitmap.java:1078)
E/AndroidRuntime( 7700): 	at android.graphics.Bitmap.createBitmap(Bitmap.java:1028)
E/AndroidRuntime( 7700): 	at android.graphics.Bitmap.createBitmap(Bitmap.java:989)
E/AndroidRuntime( 7700): 	at com.google.maps.api.android.lib6.impl.a.d(:com.google.android.gms.dynamite_mapsdynamite<EMAIL_ADDRESS>(190800-0):2)
E/AndroidRuntime( 7700): 	at com.google.maps.api.android.lib6.impl.bh.run(:com.google.android.gms.dynamite_mapsdynamite<EMAIL_ADDRESS>(190800-0):1)
E/AndroidRuntime( 7700): 	at java.lang.Thread.run(Thread.java:1012)
W/Parcel  ( 7700): Expecting binder but got null!
I/Process ( 7700): Sending signal. PID: 7700 SIG: 9
Lost connection to device.

I understand why the failure is happening, but this should not crash the whole app! At worst, an exception should be thrown back in the Dart code, or a null value should be returned.
Expected results
A Java exception should not crash the Flutter runtime, ever! This is horrible behavior.
Actual results
A Java exception takes down the whole Flutter app.
Code sample
--
Screenshots or Video
--
Logs
--
Flutter Doctor output
Doctor output
$ flutter doctor -v
[✓] Flutter (Channel main, 3.21.0-16.0.pre.11, on Fedora Linux 39 (Workstation Edition) 6.7.7-200.fc39.x86_64, locale en_US.utf8)
    • Flutter version 3.21.0-16.0.pre.11 on channel main at /opt/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6807eacb33 (4 days ago), 2024-03-27 18:31:44 -0400
    • Engine revision 73c145c9ac
    • Dart version 3.4.0 (build 3.4.0-279.0.dev)
    • DevTools version 2.34.0-dev.12

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /home/luke/Android/Sdk
    • Platform android-34, build-tools 33.0.1
    • Java binary at: /opt/android-studio/jbr/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 17.0.6 (Fedora 17.0.6-2.fc39)
    • cmake version 3.27.7
    • ninja version 1.11.1
    • pkg-config version 1.9.5

[✓] Android Studio (version 2022.2)
    • Android Studio at /opt/android-studio
    • Flutter plugin version 73.0.2
    • Dart plugin version 222.4582
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.87.2)
    • VS Code at /usr/share/code
    • Flutter extension version 3.85.20240301

[✓] VS Code (version 1.88.0-insider)
    • VS Code at /usr/share/code-insiders
    • Flutter extension version 3.79.20231130

[✓] Connected device (3 available)
    • sdk gphone x86 64 (mobile) • emulator-5554 • android-x64    • Android 13 (API 33) (emulator)
    • Linux (desktop)            • linux         • linux-x64      • Fedora Linux 39 (Workstation Edition) 6.7.7-200.fc39.x86_64
    • Chrome (web)               • chrome        • web-javascript • Google Chrome 122.0.6261.94

[✓] Network resources
    • All expected network resources are available.

• No issues found!

I'm doing this right now, but I don't even know if this will catch all the ways the app could crash:
  /// Take a snapshot of the map as the event creator saw it
  Future<Uint8List?> takeSnapshot() async {
    // Whole app crashes if map widget is not built when calling
    // mapController.takeSnapshot(), so double-check this
    if (!_mapControllerCompleter.isCompleted) {
      // Map controller is not initialized, so map is not built
      return null;
    }
    final mapController = await _mapControllerCompleter.future;
    if (!mounted ||
        SchedulerBinding.instance.schedulerPhase ==
            SchedulerPhase.persistentCallbacks) {
      // Widget is not mounted, or is in the process of being built
      return null;
    }
    // Take snapshot of map and return it
    return await mapController.takeSnapshot();
  }

Also I don't understand why the legacy renderer is being used here. I am using the latest google_maps_flutter package, which should already use the new renderer, according to @darshankawar in https://github.com/flutter/flutter/issues/143917 .

Thanks for the report @lukehutch

and the UI tree layout has not yet completed, the entire app crashes, with this exception:

I think since the layout isn't rendered yet, then takeSnapShot() won't have any UI elements to fetch.

I'm doing this right now, but I don't even know if this will catch all the ways the app could crash:

Can you take a look at onMapCreated() and check if it helps in your case ?
onMapCreated: (GoogleMapController controller) {
          _controller.complete(controller);
        },

Thanks for the update. Keeping the issue open for team's input / tracking.

@stuartmorgan made this comment: https://github.com/flutter/flutter/issues/73117#issuecomment-854112851 -- does this mean that calls through MethodChannel are in fact supposed to throw exceptions back to Dart, if the Java code throws an exception? If so, why is it not working for this Maps API call?

does this mean that calls through MethodChannel are in fact supposed to throw exceptions back to Dart, if the Java code throws an exception?

If it throws an exception within the handler, yes.

If so, why is it not working for this Maps API call?

Please see my next comment in that thread. Your exception stack shows it happening in a different thread.

@stuartmorgan OK, so based on the comment you linked, whoever works on the Maps Android library would need to fix this, maybe by putting a check in the FFI thread for this condition, before offloading work to the other thread?

I'm not sure what the "FFI thread" you are referring to is, but I would expect that this can likely be fixed in the plugin by not calling snapshot on the map in this scenario, and instead returning method channel error.

I'm not sure what the "FFI thread" you are referring to is

The Java thread that MethodChannel runs code in, which has Flutter in its stacktrace.

I would expect that this can likely be fixed in the plugin by not calling snapshot on the map in this scenario, and instead returning method channel error.

OK. So I assume this will be seen by the Maps team, since it was triaged and tagged with "p: maps".

From android triage: the fix here is to modify the plugin code so that takeSnapshot simply does nothing when called too early.

Just wondering if the Android team has looked at this (beyond triage) yet? This is a pretty severe issue. I had to put all sorts of protections in place (checking that the map widget was properly initialized, laid-out, and rendered) so that my app doesn't trigger this.

@lukehutch Please see https://github.com/flutter/flutter/blob/master/docs/contributing/issue_hygiene/README.md#do-not-add-me-too-or-same-or-is-there-an-update-comments-to-bugs and https://github.com/flutter/flutter/blob/master/docs/contributing/issue_hygiene/README.md#escalating-an-issue-that-has-the-wrong-priority


Unexpected results when moving an Explorer folder onto itself

When trying to Move an Explorer folder, it is possible to set the destination to the same folder as the source.
This results in an error message being displayed:

After the tree cache is refreshed, the source folder appears as a root element, outside System:

Closed by #3224

Closed by #3224


[CHANGE ME] Re-generated  to pick up changes in the API or client library generator.

This PR was generated using Autosynth. :rainbow:
Here's the log from Synthtool:
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:3b8f7d9b4c206843ce08053474f5c64ae4d388ff7d995e68b59fb65edf73eeb9
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/iot/artman_cloudiot.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeviceState.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/PublicKeyCertificate.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/GetDeviceRequestOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ListDeviceRegistriesRequest.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/Device.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ListDeviceStatesResponse.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/UpdateDeviceRegistryRequest.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/UnbindDeviceFromGatewayResponse.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/UpdateDeviceRequest.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeviceManagerProto.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeviceConfig.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ModifyCloudToDeviceConfigRequest.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ListDeviceStatesRequestOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/UnbindDeviceFromGatewayResponseOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ModifyCloudToDeviceConfigRequestOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/RegistryCredentialOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/RegistryCredential.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/SendCommandToDeviceRequest.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/HttpConfigOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/UnbindDeviceFromGatewayRequest.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ListDeviceConfigVersionsResponseOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeleteDeviceRegistryRequestOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/UpdateDeviceRequestOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/GetDeviceRegistryRequestOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/CreateDeviceRegistryRequest.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/PublicKeyCertificateOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/X509CertificateDetailsOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/MqttConfigOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeleteDeviceRequestOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/StateNotificationConfig.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/X509CertificateDetails.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/HttpState.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeviceOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeleteDeviceRequest.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/GatewayAuthMethod.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/SendCommandToDeviceResponse.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ResourcesProto.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ListDeviceStatesResponseOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeviceCredentialOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ListDeviceRegistriesRequestOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/GatewayListOptions.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/BindDeviceToGatewayResponse.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/PublicKeyFormat.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/SendCommandToDeviceRequestOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ListDevicesResponse.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ListDevicesResponseOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ListDeviceConfigVersionsRequestOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/PublicKeyCertificateFormat.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeleteDeviceRegistryRequest.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeviceRegistry.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/GetDeviceRegistryRequest.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/CreateDeviceRequest.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/SendCommandToDeviceResponseOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/PublicKeyCredential.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/EventNotificationConfig.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ListDeviceRegistriesResponseOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/EventNotificationConfigOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ListDevicesRequestOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/BindDeviceToGatewayResponseOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/MqttState.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ListDeviceConfigVersionsResponse.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ListDeviceStatesRequest.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/GatewayType.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeviceCredential.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/LogLevel.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/MqttConfig.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/HttpConfig.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeviceRegistryOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/GatewayConfig.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/UnbindDeviceFromGatewayRequestOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/CreateDeviceRegistryRequestOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/GatewayListOptionsOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ListDevicesRequest.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/CreateDeviceRequestOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/PublicKeyCredentialOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/BindDeviceToGatewayRequest.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/GatewayConfigOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/StateNotificationConfigOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/BindDeviceToGatewayRequestOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeviceStateOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/GetDeviceRequest.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ListDeviceConfigVersionsRequest.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/UpdateDeviceRegistryRequestOrBuilder.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/ListDeviceRegistriesResponse.java.
synthtool > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeviceConfigOrBuilder.java.
synthtool > Replaced '/\\*\n \\* Copyright 2018 Google LLC\n \\*\n \\* Licensed under the Apache License, Version 2.0 \\(the "License"\\); you may not use this file except\n \\* in compliance with the License. You may obtain a copy of the License at\n \\*\n \\* http://www.apache.org/licenses/LICENSE-2.0\n \\*\n \\* Unless required by applicable law or agreed to in writing, software distributed under the License\n \\* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express\n \\* or implied. See the License for the specific language governing permissions and limitations under\n \\* the License.\n \\*/\n' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeviceRegistryName.java.
synthtool > Replaced '/\\*\n \\* Copyright 2018 Google LLC\n \\*\n \\* Licensed under the Apache License, Version 2.0 \\(the "License"\\); you may not use this file except\n \\* in compliance with the License. You may obtain a copy of the License at\n \\*\n \\* http://www.apache.org/licenses/LICENSE-2.0\n \\*\n \\* Unless required by applicable law or agreed to in writing, software distributed under the License\n \\* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express\n \\* or implied. See the License for the specific language governing permissions and limitations under\n \\* the License.\n \\*/\n' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/LocationName.java.
synthtool > Replaced '/\\*\n \\* Copyright 2018 Google LLC\n \\*\n \\* Licensed under the Apache License, Version 2.0 \\(the "License"\\); you may not use this file except\n \\* in compliance with the License. You may obtain a copy of the License at\n \\*\n \\* http://www.apache.org/licenses/LICENSE-2.0\n \\*\n \\* Unless required by applicable law or agreed to in writing, software distributed under the License\n \\* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express\n \\* or implied. See the License for the specific language governing permissions and limitations under\n \\* the License.\n \\*/\n' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/proto-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeviceName.java.
synthtool > Replaced 'package com.google.cloud.iot.v1;' in /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java/grpc-google-cloud-iot-v1/src/main/java/com/google/cloud/iot/v1/DeviceManagerGrpc.java.
synthtool > Running java formatter on 11 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 89 files
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.github/PULL_REQUEST_TEMPLATE.md
.github/release-please.yml
.kokoro/build.bat
.kokoro/build.sh
.kokoro/coerce_logs.sh
.kokoro/common.cfg
.kokoro/continuous/common.cfg
.kokoro/continuous/dependencies.cfg
.kokoro/continuous/integration.cfg
.kokoro/continuous/java11.cfg
.kokoro/continuous/java7.cfg
.kokoro/continuous/java8-osx.cfg
.kokoro/continuous/java8-win.cfg
.kokoro/continuous/java8.cfg
.kokoro/continuous/lint.cfg
.kokoro/continuous/propose_release.cfg
.kokoro/continuous/propose_release.sh
.kokoro/dependencies.sh
.kokoro/linkage-monitor.sh
.kokoro/nightly/common.cfg
.kokoro/nightly/dependencies.cfg
.kokoro/nightly/integration.cfg
.kokoro/nightly/java11.cfg
.kokoro/nightly/java7.cfg
.kokoro/nightly/java8-osx.cfg
.kokoro/nightly/java8-win.cfg
.kokoro/nightly/java8.cfg
.kokoro/nightly/lint.cfg
.kokoro/presubmit/clirr.cfg
.kokoro/presubmit/common.cfg
.kokoro/presubmit/dependencies.cfg
.kokoro/presubmit/integration.cfg
.kokoro/presubmit/java11.cfg
.kokoro/presubmit/java7.cfg
.kokoro/presubmit/java8-osx.cfg
.kokoro/presubmit/java8-win.cfg
.kokoro/presubmit/java8.cfg
.kokoro/presubmit/linkage-monitor.cfg
.kokoro/presubmit/lint.cfg
.kokoro/release/bump_snapshot.cfg
.kokoro/release/bump_snapshot.sh
.kokoro/release/common.cfg
.kokoro/release/common.sh
.kokoro/release/drop.cfg
.kokoro/release/drop.sh
.kokoro/release/promote.cfg
.kokoro/release/promote.sh
.kokoro/release/publish_javadoc.cfg
.kokoro/release/publish_javadoc.sh
.kokoro/release/snapshot.cfg
.kokoro/release/snapshot.sh
.kokoro/release/stage.cfg
.kokoro/release/stage.sh
.kokoro/trampoline.sh
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
README.md
codecov.yaml
java.header
license-checks.xml
renovate.json
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

Note: this is failing to compile b/c it's missing a DeviceName class.


Is this just "require" for the browser?

It seems to me that the combination of top level await and dynamic import have essentially recreated "require" for the browser.
With require:
const { blah } = require('./foo');

With top level await:
const { blah } = await import('./foo');

The choice to pursue a static binding module system instead of a more dynamic "asyncified require" was made a long time ago during the ES6 development cycle. Are we sure it's a good idea for JavaScript to support two styles of importing?

It's worth noting that this is only the case if await is blocking - if it instead behaves consistently with await in an async function, then it wouldn't be the same thing as require.

Note that there's other things you might want to do with top-level await that have nothing to do with import() at all e.g. instantiating WebAssembly functions for synchronous use:
const complexMathWasmUrl = new URL('./complexMath.wasm', import.meta.url)

const response = await fetch(complexMathWasmUrl)
if (!response.ok) {
  throw new Error(`Failed to load complexMath wasm`)
}

const buffer = await response.arrayBuffer()
const wasmInstance = await WebAssembly.instantiate(buffer)

export default class Complex {
  #re
  #img
  constructor(re) {
    this.#re = re
    this.#im = im
  }

  multiply() {
    // use wasm.exports.multiply to create a new complex number
  }

  static sin(complexNumber) {
    // use wasm.exports.sinApproximation somehow to create a new Complex
    // number, etc
  }
}

Ultimately if people use const foo = await import('./some-module.js') over import * as foo from './some-module.js' then that's a penalty they pay. Linters can easily add rules to disallow that sort've thing so I think it's  a big concern.

Aren't we going to use loaders for supporting things like WASM loading? Do we need async initialization semantics for that?

The whatwg loader hasn't seen much attention in a while and I don't know if the browsers were ever that keen on implementing it which is why I thought top-level await was fairly popular.
Certainly if userland loaders were implemented I don't see any reason we can't do anything we would want to do with top-level await (or vice versa). So I suppose the question would be what do browsers actually want to implement?
NOTE: WebAssembly loading specifically is still an ongoing work but I haven't seen any intent to implement userland loaders for arbitrary types in recent times.

About WebAssembly, the current idea (sorry, not 100% written down yet) is to check for the appropriate mimetype when HTML is loading a module, and go into a built-in WebAssembly loading path in that case. Actually, this path will need to yield during Evaluate() (which is when Wasm module compilation will happen), so the proposal kind of takes a dependency on top-level await.

I wouldn't encourage people to use top-level await in the way listed at the top of this post. The current explainer tries to avoid this direction, and describes use cases that don't relate to it. When writing documentation (e.g., for MDN), I hope we can explain clearly why people should continue to use static import statements when they make sense. Does this resolve the issue?

@littledan It does indeed.

Closing per https://github.com/tc39/proposal-top-level-await/issues/30#issuecomment-487139837


install error

Traceback (most recent call last):
File "/usr/local/src/flash-attention/setup.py", line 163, in
setup(
File "/usr/lib/python3/dist-packages/setuptools/init.py", line 153, in setup
return distutils.core.setup(**attrs)
File "/usr/lib/python3.10/distutils/core.py", line 148, in setup
dist.run_commands()
File "/usr/lib/python3.10/distutils/dist.py", line 966, in run_commands
self.run_command(cmd)
File "/usr/lib/python3.10/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/usr/lib/python3/dist-packages/setuptools/command/install.py", line 74, in run
self.do_egg_install()
File "/usr/lib/python3/dist-packages/setuptools/command/install.py", line 116, in do_egg_install
self.run_command('bdist_egg')
File "/usr/lib/python3.10/distutils/cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "/usr/lib/python3.10/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/usr/lib/python3/dist-packages/setuptools/command/bdist_egg.py", line 164, in run
cmd = self.call_command('install_lib', warn_dir=0)
File "/usr/lib/python3/dist-packages/setuptools/command/bdist_egg.py", line 150, in call_command
self.run_command(cmdname)
File "/usr/lib/python3.10/distutils/cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "/usr/lib/python3.10/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/usr/lib/python3/dist-packages/setuptools/command/install_lib.py", line 23, in run
self.build()
File "/usr/lib/python3.10/distutils/command/install_lib.py", line 109, in build
self.run_command('build_ext')
File "/usr/lib/python3.10/distutils/cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "/usr/lib/python3.10/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/usr/lib/python3/dist-packages/setuptools/command/build_ext.py", line 79, in run
_build_ext.run(self)
File "/usr/lib/python3.10/distutils/command/build_ext.py", line 340, in run
self.build_extensions()
File "/usr/local/lib/python3.10/dist-packages/torch/utils/cpp_extension.py", line 499, in build_extensions
_check_cuda_version(compiler_name, compiler_version)
File "/usr/local/lib/python3.10/dist-packages/torch/utils/cpp_extension.py", line 387, in _check_cuda_version
raise RuntimeError(CUDA_MISMATCH_MESSAGE.format(cuda_str_version, torch.version.cuda))
RuntimeError:
The detected CUDA version (12.1) mismatches the version that was used to compile
PyTorch (11.8). Please make sure to use the same CUDA versions.
Ubuntu 222.94
Python 3.10.6
CUDA 12.1
pytouch 1.8

As suggested by the error message, if your Pytorch was compiled with CUDA 11.8, you'd need to use CUDA 11.8 to install the extension.

  Using cached flash_attn-1.0.4.tar.gz (2.0 MB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-d350b0x0/flash-attn_3a57c7ab5809463fa2fa1dcec5d16223/setup.py", line 11, in <module>
          import torch
      ModuleNotFoundError: No module named 'torch'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.```

How to solve this error?

RuntimeError: Error compiling objects for extension
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for flash_attn
Running setup.py clean for flash_attn
Failed to build flash_attn
Installing collected packages: flash_attn
Running setup.py install for flash_attn ... |
I face the following error, could you recommend me a solution?
I use conda environment, ubuntu 22.04, python 3.9


fix tvOS Swift packaging

Otherwise get this when running sh build.sh package-tvos-swift:
	zip warning: name not matched: Realm.framework
  adding: RealmSwift.framework/ (stored 0%)
  adding: RealmSwift.framework/071A9353-A9D3-3243-91A9-BD46CD7EF709.bcsymbolmap (deflated 87%)
  adding: RealmSwift.framework/_CodeSignature/ (stored 0%)
  adding: RealmSwift.framework/_CodeSignature/CodeResources (deflated 76%)
  adding: RealmSwift.framework/B621124F-2946-3BFE-AE58-DC93B8A77465.bcsymbolmap (deflated 88%)
  adding: RealmSwift.framework/Headers/ (stored 0%)
  adding: RealmSwift.framework/Headers/RealmSwift-Swift.h (deflated 74%)
  adding: RealmSwift.framework/Info.plist (deflated 29%)
  adding: RealmSwift.framework/Modules/ (stored 0%)
  adding: RealmSwift.framework/Modules/module.modulemap (deflated 17%)
  adding: RealmSwift.framework/Modules/RealmSwift.swiftmodule/ (stored 0%)
  adding: RealmSwift.framework/Modules/RealmSwift.swiftmodule/arm64.swiftdoc (deflated 80%)
  adding: RealmSwift.framework/Modules/RealmSwift.swiftmodule/arm64.swiftmodule (deflated 67%)
  adding: RealmSwift.framework/Modules/RealmSwift.swiftmodule/x86_64.swiftdoc (deflated 80%)
  adding: RealmSwift.framework/Modules/RealmSwift.swiftmodule/x86_64.swiftmodule (deflated 67%)
  adding: RealmSwift.framework/RealmSwift (deflated 64%)

This wasn't detected during local testing because we run all steps on the same machine, so Realm.framework was already available in that case. But since CI runs these steps in parallel, we have to explicitly call this.


How to change time format for file as well as for display?

I am beginner and I really searched the docs, but I don't understand this. Can you help me?

How can I change the time format (and only the time format) for the file as well as for the display? I want the keep the colors and everything else in their default format.
How can I only show certain levels in the display, while saving all levels in the file?

I tried to create additional handlers, but then I loose the default format and I find it hard to recreate that.

Is there any quick how-to regarding formatting? it's not clear


Allow multiple table of same type either by using schemas or allow creation of multiple databases

If can't be achieved please provide documentation of using serialization layer to serialize List<List< dynamic >> returned by queries

Can you describe your use case and perhaps there is an alternate solution you can use for now?

For example we manage employee data of two companies

I would recommend adding an organization id in the employee table. Plus having another table with extended user info that contains both the userId and any associated company id. Then there is no need to pass the organization id through the API, rater first fetch the users extended data, then fetch the correct company information.

Thank your for the suggestion I will try

No need to close, it may be a feature we will implement in the future.


docs: add link to list of available timezones

according to this post, the list of timezones can be found here:
https://raw.githubusercontent.com/node-cron/tz-offset/a67968ab5b0efa6dee296dac32d3205b41f158e0/generated/offsets.json

Pull Request Test Coverage Report for Build 318

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 300:
0.0%

Covered Lines:
270

Relevant Lines:
270

💛  - Coveralls


Added pipe redirection

This is a fix for issue #298. Simple pipe redirection was not working; this makes it instead keep track of the stream past redirects.

@defunctzombie Interested in merging a PR for this? Pretty major issue that pipes don't work with redirects, would def send one if you OK it.

Yes, that looks like an important fix

@pornel It looks like this was fixed by TJ already a while back. Should be reclosed.
My issue was different, attaching 'data' listeners to a streaming request doesn't work so it isn't a real stream, it just has the pipe function. Threw me off, may need clarifying in the docs that pipe is just a sugar fn and it isn't a real stream.


Upgrade Statefulset with new image:tag fails

I've installed a redis statefulset via helm in our cluster:
https://github.com/helm/charts/tree/master/stable/redis
Today, the helmchart-version and image-version increased and my CI pipeline fails. normally i do the upgrade like this:
helm upgrade --install --recreate-pods redis stable/redis --values values.redis.yaml

If the chart is not installed helm will install it - if the chart is already installed, helm does just recreate the pods. Today, after the new helmchart got released i see the following error message:
Error: UPGRADE FAILED: Deployment.apps "redis-slave" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{"chart":"redis-4.0.1", "release":"redis", "role":"slave", "app":"redis"}: `selector` does not match template `labels` && StatefulSet.apps "redis-master" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', and 'updateStrategy' are forbidden.

Shouldn't the upgrade work with the --recreate-pods flag? Shouldn't helm be able to rollout the new version?
Output of helm version: 2.10.0
Output of kubectl version: 1.10.8

Hi @discostur
I would think this would work but something appears to be wrong. I would compare the final manifests from each version to see what has changed. Also I noticed this recent change with update strategy, could that be related? https://github.com/helm/charts/pull/7619/files#diff-30e182e3b12b994b9ab3ff39cf0dd42b

I'm going to close this ticket due to inactivity, but please re-open if this still needs to be addressed. Thanks!