Multiple versions of the same image when original asset isn't large enough

When using the Imager plugin and creating responsive images using srcset and sizes? Any ideas on how to avoid creating multiple versions of the same image if the original asset uploaded is smaller than the set transforms? I added the setting 'allowUpscale'       =>      false, but this has resulted in 7 versions of the same image (same dimensions etc)
/imager/resources/general/359/Golden-Retriever-Isolated_b4a9cbfcf0e16c2bbe8891faf2f17377.jpg 302w,
/imager/resources/general/359/Golden-Retriever-Isolated_46442a24ab3b20705cf025765c954564.jpg 302w,
/imager/resources/general/359/Golden-Retriever-Isolated_dc3d89e10897fe49613e23ec867b72c7.jpg 302w,
/imager/resources/general/359/Golden-Retriever-Isolated_13d85085a2b68d4289e86166bdc76d2f.jpg 302w,
/imager/resources/general/359/Golden-Retriever-Isolated_033ae678b7fe3957fc7ac9eab98c2dac.jpg 302w,
/imager/resources/general/359/Golden-Retriever-Isolated_78f5cce99e1c3c7765fb260eb99fceaa.jpg 302w,
/imager/resources/general/359/Golden-Retriever-Isolated_3907e8c0ed1757af4be1f9f097fb579b.jpg 302w,
/imager/resources/general/359/Golden-Retriever-Isolated_6e4e16791425f7dfc1ab06a09cd800f4.jpg 302w,
/imager/resources/general/359/Golden-Retriever-Isolated_042ca14a1382a40b78a83ee7d3f8e3dd.jpg 300w

Here is my code for reference:
{% case "image" %}
{% set image = block.image.first() %}
{% set transformedImages = craft.imager.transformImage(image, [
        { width: 1680 },
        { width: 1430 },
        { width: 1350 },
        { width: 1150 },
        { width: 840 },
        { width: 715 },
        { width: 660 },
        { width: 450},
        { width: 300}
    ], { mode: 'fit' })
%}
<figure{%- if block.position != "full" %} class="img-{{ block.position }}--small"{% endif -%}>
    <img
        src="{{ craft.imager.transformImage(image, { width: 715, mode: 'fit' }) }}"
        srcset="{{ craft.imager.srcset(transformedImages) }}"
        sizes="{{ (block.position == 'full') ? '(max-width: 60em) 100vw, 61.5vw' : '(max-width: 37.5em) 100vw, (max-width: 81.25em) 30vw, 400px'  }}"
        alt="{{ image.altText ?: image.title }}"
    />
    {% if block.caption|length %}
    <figcaption class="figcaption">
        {{ block.caption }}
    </figcaption>
    {% endif %}
</figure>

This proved to be a particulary tricky problem to solve.
The filename is created based on the transform string passed in, which is why the filenames are different, while the size being the same. The filename has to be created before the image is opened, because opening the image is a resource intensive operation which would seriously decrease performance.
Trying to figure out if the image needed to be created without opening it is possible, except, you want to create one image that has the maximum possible size. The problem is knowing if this has been created or not. Creating multiple images in one Imager method call, that creates several images that have the exact same size, is a completely valid use-case. So, actually knowing if the transform created different images or not isn't simple.
Anyways, creating different duplicate images have two problems; 1) it wastes disk-space, and 2) it makes the browser load more images than necessary when used as a srcset.
Disk-space isn't really a concern I had when creating Imager, the whole point was to make something file-based that was optimized for speed.
The second issue is a more serious issue. To counter this, I've implemented a fix in the craft.imager.srcset template variable that only outputs sizes that haven't already been output, since it never makes sense to have several images with the same width in an srcset. This will be included in the next version of Imager.
So, that fixes 2) but not 1). I'll have this in mind when I (have to) refactor Imager for Craft 3, but for now I won't do anything more in regards to this.


Please make a new release

The 1.0.0 release has a serious bug, which causes compilation of the library to fail on computers that run an operating system with a case-sensitive filesystem (e.g., Linux):
https://github.com/luisllamasbinaburo/Arduino-I2CScanner/issues/1
The bug has been fixed (https://github.com/luisllamasbinaburo/Arduino-I2CScanner/commit/edeb636a575e6c79053c0742eaab376f9c95fe68), but there hasn't been a release since that time. The Arduino Library Manager system only distributes release versions of libraries, so this means the users who install the library via Library Manager, or use Arduino Cloud Editor (which has all the Library Manager libraries pre-installed) still suffer from this bug. For example:

https://forum.arduino.cc/t/arduino-h-no-such-file-or-directory-where-am-i-supposed-to-fix-it/1296243
https://forum.arduino.cc/t/i2cscanner-problem-or-is-it-me/1195559

I see the version field of library.properties has already been bumped, so the only action required to make a new release is to publish a new GitHub release or push a Git tag to this repository.

:+1:
This bug cost me about 4 hours yesterday.


Incompatible provider version error on m1 macOS

Incompatible provider for m1 mac, terraform init command fails.
❯ terraform init

Initializing the backend...

Initializing provider plugins...
- Finding latest version of hashicorp/aws...
- Finding latest version of hashicorp/template...
- Installing hashicorp/aws v5.80.0...
- Installed hashicorp/aws v5.80.0 (signed by HashiCorp)
╷
│ Error: Incompatible provider version
│
│ Provider registry.terraform.io/hashicorp/template v2.2.0 does not have a package available for your current
│ platform, darwin_arm64.
│
│ Provider releases are separate from Terraform CLI releases, so not all providers are available for all
│ platforms. Other versions of this provider may have different platforms supported.

solved in #9


.withPartitionConstraint operation type

I am not big fan of free text on the operation. the second parameter should be an enum.

Criticism of my hard work is not allowed


what is the difference between kinetics and activitynet datasets?

Thanks for your interest in Activitynet and Kinetics.
Kinetics is a trimmed video dataset suitable for action recognition. ActivityNet, on the other hand, is an untrimmed dataset suitable for temporal action localization. Please refer to the original papers of each dataset for more details.
Cheers!

Thanks for your interest in Activitynet and Kinetics.
Kinetics is a trimmed video dataset suitable for action recognition. ActivityNet, on the other hand, is an untrimmed dataset suitable for temporal action localization. Please refer to the original papers of each dataset for more details.
Cheers!


Look set height not work in android device ?

<QRCodeScanner
cameraStyle={{
width: 300,
height: 170,
alignSelf: 'center',
}}
........
/>
What's happening?

I try set height but look like not work on android device but on iOS working
Build details?

"react-native-qrcode-scanner": "^1.5.5"
"react-native": "0.66.3"
"react-native-camera": "^4.2.1"

I have also encountered this problem, is there a solution? Thank you


mgmt: smp: Fix race condition by using same work queue

Fix possible race condition where SMP client might release the network buffer before system worker queue has processed it.
In smp_client uses shared resources like worker queue linked list and network buffers without maintaining any thread safety.
For unknown reasons, retry timeout handling is pushed into system worker queue while the actual transmission is handled from SMP work queue.
Fix the issue by using the same SMP work queue
for both delayable timeout handling as well as
transmission handling.

Fixed the style problem.

Error visible without this fix is a nullpointer fed into CRC16 function

My assumption for the reason is in zephyr/subsys/mgmt/mcumgr/smp_client/src/client.c:smp_client_transport_work_fn()
} else if (entry->retry_cnt) {
   /* Increment reference for re-transmission */
   entry->nb = net_buf_ref(entry->nb);
   entry->retry_cnt--;
   entry->timestamp = time_stamp_ref + CONFIG_SMP_CMD_RETRY_TIME;
   k_fifo_put(&entry->smp_client->tx_fifo, entry->nb); // <---- PUSHED TO FIFO HERE
   k_work_submit_to_queue(smp_get_wq(), &entry->smp_client->work); <--- SUBMIT TO SYSTEM WORKER
   continue;
  }

  cb = entry->cb;
  user_data = entry->user_data;
  smp_client_cmd_req_free(entry); // <-- BUT SMP work QUEUE might run this part before

@SeppoTakalo how about becoming the maintainer of smp_client code (can split it out in maintainers file)?

I'm a bit hesitant about that.. I don't really use it. This was just out of one internal bugreport.
It is true that the client was developed in my team, but the developer have left and we don't use this in our current work.
But if there is really a need, I can be a collaborator and at least review the code.


Visual Scripting: Getting Started

Create a 2D game using only visual scripting

Could you also:

Mention upfront who visual scripting is for: designers, non-devs
You can create custom nodes from gdscript, to create project-specific, designer-friendly nodes
Mention the limitations of this language at the moment

See https://docs.godotengine.org/en/latest/getting_started/scripting/visual_script/getting_started.html
You can keep the game simple, even reuse a project from another tutorial, as VS becomes heavy quickly. Even just basic character movement in a platformer would be fine (move and jump)


[release-1.26] [occm] ensure octavia monitor is always updated

This is a cherry-pick of #2373
/assign kayrus
[occm] Ensure Octavia health monitors are updated on `UpdateLoadBalancer` k8s service controller call.

/lgtm
/approve

/override openstack-cloud-csi-manila-e2e-test-release-126


Add "Open in MATLAB Online" button to README

To make your repo accessible, please add the following markdown code to your README.
[![Open in MATLAB Online](https://www.mathworks.com/images/responsive/global/open-in-matlab-online.svg)](https://matlab.mathworks.com/open/github/v1?repo=NerdsWithAttitudes/WarpFactory&file=README.md)

This code will add the following button to your README, and people who click on it will be able to pull your repo into MATLAB Online and be able to run your code, whether they have the license or not.

Button added. Thanks for the info!


Remove logged output

This line throws TypeError: Converting circular structure to JSON and there's no way to disable it, even though the config that's used it perfectly valid.
Check that your description matches the automatic change-log format:
http://karma-runner.github.io/latest/dev/git-commit-msg.html
then delete this reminder.

Or we can switch to flatted: https://www.npmjs.com/package/flatted
That would seem to be the best, we can replace json3:
https://github.com/karma-runner/karma/search?q=json3&unscoped_q=json3
and solve your issue as well.


requirements version

Thank you for uploading the code! What is the version of each environment dependency package?

This worked for me
torch==1.1.0.post2
torchvision==0.3.0
imageio==2.5.0
scipy==1.3.0
argparse==1.4.0
tensorflow==1.14.0
Pillow==6.0.0
sacred==0.7.5
easydict==1.9
pymongo==3.8.0
pyyaml==5.1.1


[Feature request] SecurityContext

Hello,
I need to have the possibilities to set securityContext for my deployment (due to security policy requirement in my company).
A bloc like this one could be added in spec/template/spec for deployment-operator and deployment webhook
  {{- if .Values.securityContext }}
  securityContext: {{ toYaml .Values.securityContext | nindent 8 }}
    {{- end }}

Since v0.5.0 we restrict the Security Contexts for Operator components as much as possible.

Hello,
I saw that the security context has been updated for the pod. But my company policy also required that I specify the following values runAdGroup, runAdUser, supplemtalGroups:
securityContext:
fsGroup: 20000
runAsGroup: 10000
runAsNonRoot: true
runAsUser: 10000
supplementalGroups: [10000]
That s why I requested the possibility to set a securitycontext at container level.

Moreover, regarding this helm chart, I also have another issue. The liveness check are set to /livez but they are exposed at /healthz
In https://github.com/Dynatrace/dynatrace-operator/blob/master/Dockerfile at raw 53: COPY --from=k8s.gcr.io/sig-storage/livenessprobe:v2.6.0 /livenessprobe /usr/local/bin
https://github.com/kubernetes-csi/livenessprobeLiveness :
The liveness probe is a sidecar container that exposes an HTTP /healthz endpoint, which serves as kubelet's livenessProbe hookhttps://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#container-probes to monitor health of a CSI driver.
If I change the template replacing /livez by  /healthz it works.
Regards,
Maud
De : Christoph Muellner @.>
Envoyé : 9 mai 2022 08:16
À : Dynatrace/dynatrace-operator @.>
Cc : Vandevelde, Maud @.>; Author @.>
Objet : Re: [Dynatrace/dynatrace-operator] [Feature request] SecurityContext (Issue #765)
EXPÉDITEUR EXTERNE - Attention aux liens et aux pièces jointes
EXTERNAL SENDER - Beware of links and attachments
Since v0.5.0 we restrict the Security Contexts for Operator components as much as possible.

Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDynatrace%2Fdynatrace-operator%2Fissues%2F765%23issuecomment-1121022814&data=05|01|maud.vandevelde%40ssq.ca|ca4a0331ae1f43ece12b08da31b5abad|5ad62f8ada9a4f5eb9c1649756c550ca|0|0|637876953583444896|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=b4405Vgy4zUm9XP9I4Z6lm4Dt5TUiUVI2dylT7jhJBQ%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVXMIVYDBCATVJ4DWUROVBTVJD6XXANCNFSM5U7DXQHA&data=05|01|maud.vandevelde%40ssq.ca|ca4a0331ae1f43ece12b08da31b5abad|5ad62f8ada9a4f5eb9c1649756c550ca|0|0|637876953583444896|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=17fcsF0QBzIldP9TsJsb87fy%2BwYly2I2nZO%2FpEXNshA%3D&reserved=0.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>
Ce message et tous les fichiers attachés sont confidentiels et s'adressent exclusivement au(x) destinataire(s) indiqué(s) ci-dessus. Si vous recevez ce message par erreur, veuillez le retourner à l'expéditeur et le détruire. Tout usage, copie ou distribution non autorisés de ce courriel sont strictement interdits.
This message and any attachments are confidential and intended solely for the above-mentioned recipient(s). If you have received this message in error, please return it to the sender and delete it from your files. Unauthorized use, copying or distribution of this e-mail is strictly prohibited.

Hi,
Regarding the second issue, I finally solve it changing version and appversion from 0.4.2 to 0.6.0 in https://github.com/Dynatrace/dynatrace-operator/blob/master/config/helm/chart/default/Chart.yaml
Regards,
Maud
De : Vandevelde, Maud
Envoyé : 9 mai 2022 10:03
À : Dynatrace/dynatrace-operator @.>
Cc : Vallée, Michel @.>
Objet : RE: [Dynatrace/dynatrace-operator] [Feature request] SecurityContext (Issue #765)
Hello,
I saw that the security context has been updated for the pod. But my company policy also required that I specify the following values runAdGroup, runAdUser, supplemtalGroups:
securityContext:
fsGroup: 20000
runAsGroup: 10000
runAsNonRoot: true
runAsUser: 10000
supplementalGroups: [10000]
That s why I requested the possibility to set a securitycontext at container level.

Moreover, regarding this helm chart, I also have another issue. The liveness check are set to /livez but they are exposed at /healthz
In https://github.com/Dynatrace/dynatrace-operator/blob/master/Dockerfile at raw 53: COPY --from=k8s.gcr.io/sig-storage/livenessprobe:v2.6.0 /livenessprobe /usr/local/bin
https://github.com/kubernetes-csi/livenessprobeLiveness :
The liveness probe is a sidecar container that exposes an HTTP /healthz endpoint, which serves as kubelet's livenessProbe hookhttps://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#container-probes to monitor health of a CSI driver.
If I change the template replacing /livez by  /healthz it works.
Regards,
Maud
De : Christoph Muellner<EMAIL_ADDRESS>Envoyé : 9 mai 2022 08:16
À : Dynatrace/dynatrace-operator<EMAIL_ADDRESS>Cc : Vandevelde, Maud<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Objet : Re: [Dynatrace/dynatrace-operator] [Feature request] SecurityContext (Issue #765)
EXPÉDITEUR EXTERNE - Attention aux liens et aux pièces jointes
EXTERNAL SENDER - Beware of links and attachments
Since v0.5.0 we restrict the Security Contexts for Operator components as much as possible.

Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDynatrace%2Fdynatrace-operator%2Fissues%2F765%23issuecomment-1121022814&data=05|01|maud.vandevelde%40ssq.ca|ca4a0331ae1f43ece12b08da31b5abad|5ad62f8ada9a4f5eb9c1649756c550ca|0|0|637876953583444896|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=b4405Vgy4zUm9XP9I4Z6lm4Dt5TUiUVI2dylT7jhJBQ%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVXMIVYDBCATVJ4DWUROVBTVJD6XXANCNFSM5U7DXQHA&data=05|01|maud.vandevelde%40ssq.ca|ca4a0331ae1f43ece12b08da31b5abad|5ad62f8ada9a4f5eb9c1649756c550ca|0|0|637876953583444896|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=17fcsF0QBzIldP9TsJsb87fy%2BwYly2I2nZO%2FpEXNshA%3D&reserved=0.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>
Ce message et tous les fichiers attachés sont confidentiels et s'adressent exclusivement au(x) destinataire(s) indiqué(s) ci-dessus. Si vous recevez ce message par erreur, veuillez le retourner à l'expéditeur et le détruire. Tout usage, copie ou distribution non autorisés de ce courriel sont strictement interdits.
This message and any attachments are confidential and intended solely for the above-mentioned recipient(s). If you have received this message in error, please return it to the sender and delete it from your files. Unauthorized use, copying or distribution of this e-mail is strictly prohibited.


Add phone number rule for UK numbers

Please can you add a UKPhoneNumberRule which is identical to PhoneNumberRule but with character limit set to 11 and not ten.   A typical UK cell phone number might be something like:<PHONE_NUMBER>1

I'm not going to lie this project took off and I'm pretty overwhelmed by it. I no longer actively code in Swift and I need help from more contributors in order to keep this project relevant. I'd like to find someone to transition as lead maintainer or help this codebase find a happy home with a company.
The codebase for this project is relatively small and focused project for who is looking to contribute. It does one thing, and does it pretty well. It has pretty high test coverage and good adoption. I think my ideal maintainer / contributor would work for a company that actively uses SwiftValidator in their production application.
If you're interested in helping out please comment on #204


[Model] Pipeline parallel support for Mixtral

Take from #6403. Co-authored by @binxuan
cc @youkaichao

Tested locally with PP=8 and worked.

can you test the correctness locally, using https://github.com/vllm-project/vllm/blob/main/tests/distributed/test_pipeline_parallel.py ?

Passed with the following configures. Note that I tested it on 8xL4 so I have to use 8 GPUs to host the model.
    "TP_SIZE, PP_SIZE, EAGER_MODE, CHUNKED_PREFILL, MODEL_NAME",
    [
        (2, 4, 0, 1, "mistralai/Mixtral-8x7B-Instruct-v0.1"),
        (2, 4, 1, 0, "mistralai/Mixtral-8x7B-Instruct-v0.1"),
        (1, 8, 0, 1, "mistralai/Mixtral-8x7B-Instruct-v0.1"),
        (1, 8, 1, 0, "mistralai/Mixtral-8x7B-Instruct-v0.1"),
    ])

Also fixed some issues in the test file:

Use TP_SIZE x PP_SIZE as the TP size of the reference. The current max(TP_SIZE, 2) doesn't work for larger models.
Do not use 0's as the token ID. This may generate random outputs for certain models/tokenizers.


Documentation  Women Rights (ak)

@swapnilsparsh  pls kindly add the level tag also since the DWOC and level tags are required to be added both in issues and PR


[di] Once we have exclusively borrowed self, if we go down the non-fo…

…rmal evaluation path, copy instead of asserting.
We can only do this for two reasons:

There is a code path that should have gone through the non-exclusively
borrowed self entrypoints, but they were not implemented.
We are trying to access self for an argument.

By copying the value, we preserve invariants around ownership and also make it
easy for DI to catch 2 and not blow up in the case of 1. It is better to error
in DI incorrectly, than to hit an unreachable (especially since in non-assert
builds, we don't trap at unreachables and just continue to the next function in
the text segment).
SR-5682
rdar://35402738

@swift-ci test

@swift-ci test

@swift-ci Please Test Source Compatibility

@swift-ci Please Test Source Compatibility


Adding delete message service

A simple service that allows for other developers to make their cog's bot responses deletable. It allows for multiple messages to be deleted at once as well as only allowing users with certain roles to delete the bot responses.

Im going to merge this and add the final review items manually


support border radius percent

Simple detection and implementation of % in border radius

Oops I already submitted a PR for this...


Testing db

Switched to oop and added some files.

Looks like we need to modify the paddle tests a bit to get them passing.


Deploy to OpenShift with otelcol and jaeger operators

For this we can to use a branch for example deploy, with that we can keep the main branch as simple as possible.

@pnaik1 in case you finish this first please add a comment here :+1:

@pnaik1 let's use the main branch and avoid that deploy, wdyt?

okay @helio-frota , yeah it will be better

let's use the main branch and avoid that deploy, wdyt?

My previous comment from 2 weeks ago probably related to the odo+devfile situation, trying to minimize any extra efforts. But in fact we are going with the deploy branch. I already added some modifications there related to the express-server deployment.

I'm going to close this issue here.

We can deploy both front-end and back-end already using oc command.
This was created more than 1 month ago Dec 7, 2022 and we changed our strategy.
The full description is missing as we moved forward doing other things.
The remaining part is related to the Tech Preview otelcol that needs to be updated to the latest version of upstream.


[App Service] az webapp deployment slot create: Allow overriding container settings

Description

Allows overriding the container settings deployment_container_image_name, docker_registry_server_password, and docker_registry_server_user from the configuration_source slot when creating a new slot.
Also changes a bunch of instances where CLIError is being raised to specific error types
Testing Guide

azdev test WebappContainerScenarioTests
History Notes

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] The PR title and description has followed the guideline in Submitting Pull Requests.

[X] I adhere to the Command Guidelines.

[X] I adhere to the Error Handling Guidelines.

Also, @seligj95 / @panchagnula  should there be a functionapp equivalent for this functionality?

App Service

@zhoxing-ms since I am working on updating SDK - can we skip this change for this milestone please .i.e don't merge. Thanks!

@panchagnula Can we merge this PR in this sprint?


Add some getters and unstable_raw feature

as_raw for Group, Channel and User under "unstable_raw"
is_animated and is_spoiler for Document media type
is_spoiler for Photo media type
access_hash and file_reference for Photo and Document media types under "unstable_raw"

Thanks!


Expand round trip api to ETH-protocol receipts

Builds on https://github.com/ethereum/py-evm/pull/1149
What was wrong?
The round trip API for peer request/responses had not been implemented for block receipts.
How was it fixed?
Expanded the API to cover receipts and integrated the new api into the FastChainSyncer.
Cute Animal Picture

Closing in favor of doing all the PR cleanup in https://github.com/ethereum/py-evm/pull/1169 which includes this PR.


[Q] CSV String to XLSX conversion?

I use Express.js  to generate CSV! But i want also to convert these CSV strings to excel!
How i can do that?

In Express - For CSV string (buffer)
async/await
   const { Readable } = require("stream");
   const ExcelJS = require("exceljs");

   router.get("/export", async function (req, res) {
      const workbook = new ExcelJS.Workbook();

      const csv_string = "......";
      const csv_stream = Readable.from(csv_string); // create stream from buffer
      await workbook.csv.read(csv_stream); // read the csv stream - prepare it to excel conversion
      await workbook.xlsx.write(res);
   }


Fix handling project meta-data for requirements.txt projects

Please have a look at the individual commit messages for the details.

This change is

Reviewed 5 of 5 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

analyzer/src/funTest/assets/projects/external/spdx-tools-python-expected-output.yml, line 86 at r2 (raw file):

  declared_licenses:
  - "MIT"
  - "MIT License"

Shouldn't "MIT License" be removed?

analyzer/src/main/kotlin/managers/PIP.kt, line 146 at r1 (raw file):

it so

Unrelated, but should be "is to", now that you are cleaning up anyway.

analyzer/src/main/kotlin/managers/PIP.kt, line 116 at r2 (raw file):

        // List all packages installed locally in the virtualenv. As only the plain text pipdeptree output shows the
        // hierarchy of dependencies, but the JSON output is easier to parse, we unfortunately need both.

This comment should be added in the commit before.

Comments from Reviewable

Review status: all files reviewed at latest revision, 3 unresolved discussions.

analyzer/src/funTest/assets/projects/external/spdx-tools-python-expected-output.yml, line 86 at r2 (raw file):
Previously, mnonnenmacher (Martin Nonnenmacher) wrote…
Shouldn't "MIT License" be removed?

Good point. This actually comes from the other meta-data field where I'm not doing the stripping yet. I'll add it there, too.

analyzer/src/main/kotlin/managers/PIP.kt, line 146 at r1 (raw file):
Previously, mnonnenmacher (Martin Nonnenmacher) wrote…

it so

Unrelated, but should be "is to", now that you are cleaning up anyway.

Done.

analyzer/src/main/kotlin/managers/PIP.kt, line 116 at r2 (raw file):
Previously, mnonnenmacher (Martin Nonnenmacher) wrote…
This comment should be added in the commit before.

Done.

Comments from Reviewable

Reviewed 3 of 3 files at r3, 3 of 3 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Add ability to pass withRef: true to connect()

I need to be able to create a ref for an enhanced component but I can't do it since connect needs to be called with withRef. Unfortunately there's no way to do it currently. Thoughts?

Sorry for the late @satazor , waiting for a redux-polyglot 1.0 release candidate, you can directly use connect from react-redux using getP in the mapStateToProps function

Because #79, translate hoc will be deprecated soon.
@satazor: Are you ok with using getP directly with connect here ?
Can I close this issue ?


Not able to find terraform tasks for confluent cloud provider in the Azure devops pipeline

We are trying to create new pipeline for confluent terraform tasks for automation in Azure devops yaml pipeline, but there is no confluent provider available under Terraform tasks. We can see only 3 providers (aws,azurerm & gcp). Please advise how could we find the confluent provider to fulfill our project requirement.
Also, we don't see confluent cloud in service connection under project settings to establish a connection from Azure devops.

Unfortunatly there is no support for confluent cloud in the extension.
My suggestion is to use the terraform installer task and then use standard CLI tasks to issue the terraform commands needed.


modified driving behavior by our controllers

at junctions, the car following behavior is dictated by the simulator instead of us
if a car just enters, in new sumo it may not be subscribed. Added a fix to support new sumo in the near future

Note: these features are especially helpful when using the minicity scenario

Pull Request Test Coverage Report for Build 2769

3 of 4 (75.0%)  changed or added relevant lines in 1 file are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.09%) to 86.946%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

flow/controllers/base_controller.py
3
4
75.0%

Files with Coverage Reduction
New Missed Lines
%

flow/core/kernel/vehicle/traci.py
2
90.28%

flow/envs/base_env.py
5
72.8%

Totals

Change from base Build 2767:
-0.09%

Covered Lines:
7400

Relevant Lines:
8511

💛  - Coveralls

Cares need to be taken to override this PR if one tries to write a dedicated controller for intersection. But this looks good for now.


Add pre-load stage loading screen

With heavy DI and logging we now have a reasonable delay before the application is actually shown. It'd be better if we showed the stage asap with some sort of loading screen

done in 0.2.7


:0: error: Swift does not support the SDK 'MacOSX10.14.sdk'

Toolchain v0.4.0
macOS 10.14.5
Xcode 10.2.1

After passing through the path, when I launched swift on Terminal, I got <unknown>: 0: error: Swift does not support the SDK 'MacOSX 10.14 .sdk'.
Do I need macOS 10.15 beta or Xcode 11, by any chance?

Try the following
export SDKROOT=/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk

If it does work, you can add it to your ~/.bash_profile or ~/.zshrc.

I fixed this error by:

Install the Xcode 11 beta from https://developer.apple.com/download/
Make sure the app Xcode-beta is in your Applications folder (I had to move it from downloads)
run sudo xcode-select -s /Applications/Xcode-beta.app from the command line.

I had also set SDKROOT as mentioned above but without step 3 above this did not resolve the error.

I fixed this error by:

Install the Xcode 11 beta from https://developer.apple.com/download/
Make sure the app Xcode-beta is in your Applications folder (I had to move it from downloads)
run sudo xcode-select -s /Applications/Xcode-beta.app from the command line.

I had also set SDKROOT as mentioned above but without step 3 above this did not resolve the error.

It was solved after you put your solution into practice! THANK YOU!!

If you don't want to download the Xcode beta and wish to continue using Xcode 10, you can solve this by
export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/

@bendecoste , I have Xcode 10.3, and your solution doesn't work for me :(, other suggestions what can be done?


enhance(repo): pr event customization

Part of the effort to address issue 159.
After reading through this issue as well as some of its comments, I arrived at the idea of giving users the option to customize their PR events using 4 consequential subevents: opened, synchronize, edited, and approved*.
The way I envision this getting implemented is replacing AllowPull with:
AllowPullOpen // for PRs being opened
AllowPullEdit // for PR base branch edits as well as title edits
AllowPullSync // for pushed commits to PR
AllowPullApprove // for PR approvals

I wanted to start with just AllowPullEdit and keep AllowPull unchanged to get a temperature check on the overall idea as well as the naming. Would love to hear your thoughts!

Note: approved is actually a state of the submitted action under the pull_request_review event, but for our purposes, I figured we could lump it in as a pull_request event and handle the complications server-side.

Before we add these should we step back and look like what some of the YAML changes would look like as well?


B 19889 UI estimatedprice int

Agility ticket
This branch does have commits from B-19888 in it.
To test:

Run make tasks_save_ghc_fuel_price_data. If you don't run this, you won't see a price for the Fuel Surcharge (FSC) service item.

Create a shipment in the prime sim, and make sure to provide an estimated weight.

Approve the shipment as the TOO.

Check the MTO page and scroll down to the service item section. You should see the estimated price for the service items, as long you provided an estimated weight as the prime.

For DLH, DSH, FSC , DOP, DDP, DPK, and DUPK, you should see prices.

Make another shipment, without providing an estimated weight.

Approve as TOO, check out the MTO page. You should see "Estimated Price: -" instead of prices for the above service items.

Screenshots

Check those ppm booking  pages on happo

Check those ppm booking pages on happo

Weird.. checking this one out. Didn't think I'd changed anything that would impact that page, wonder if I brought that in from main somehow


Example project?

Is there example project?

Ok, I slapped together some meshes and custom (ugly) animation, and setup Melee Trace system (that was surprisingly easy). Works great! Do you want the example project?

Hi @unreal79, I have my pet project where I test my changes however I cannot make it publicly available due to license issue as I'm using some other marketplace assets.  If you have a project and can make it available on GitHub I am more than happy to link it in the README description!

Here is the example project: https://github.com/unreal79/Melee-Trace-Example-1 -- if you wish, you may fork it.
Thanks a lot for your hard work with the plugin. Really appreciate it!


[Bug]: False positive on efs_not_publicly_accessible

Steps to Reproduce
Running on single AWS account:
prowler --checks efs_not_publicly_accessible --verbose

Expected behavior
No findings
Actual Result with Screenshots or Logs
Executing 1 check, please wait...

Check ID: efs_not_publicly_accessible - efs [critical]
	FAIL us-east-1: EFS fs-abc123 doesn't have any policy which means it grants full access to any client

How did you install Prowler?
Docker (docker pull toniblyx/prowler)
Environment Resource
Pod running in EKS
OS used
Amazon Linux 2
Prowler version
3.5.3
Pip version
23.1.2
Context
If I run the aws cli for the failed EFS  resource I get the policy as expected:
$ aws efs describe-file-system-policy --file-system-id fs-abc123
{
    "FileSystemId": "fs-abc123",
    "Policy": "{\n  \"Version\" : \"2012-10-17\",\n  \"Statement\" : [ {\n  <redacted>  ]\n}"
}

Hi @kenske, how are you?
I'm trying to reproduce your issue but I'm not being able to, could you please share the policy present in your EFS?
This is the scenario where I'm testing the issue, please modify it to mimic your environment and I could test it again.
EFS Policy:
{
    "Version": "2012-10-17",
    "Id": "efs-policy-wizard-44f078aa-4fc7-42ac-989d-6bc6a35dc635",
    "Statement": [
        {
            "Sid": "efs-statement-40e8d185-6847-4a57-a2e0-35ceb3a928e2",
            "Effect": "Allow",
            "Principal": {
                "AWS": "arn:aws:iam::111111111111:root"
            },
            "Action": "",
            "Resource": "arn:aws:elasticfilesystem:eu-west-1:111111111111:file-system/fs-060254d4ca4928555"
        }
    ]
}

Thanks for using Prowler 🚀

@jfagoagas thanks, here is the policy I'm using:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "",
            "Effect": "Allow",
            "Principal": {
                "AWS": "arn:aws:iam::<redacted>:role/<redacted>"
            },
            "Action": [
                "elasticfilesystem:ClientWrite",
                "elasticfilesystem:ClientRootAccess",
                "elasticfilesystem:ClientMount"
            ],
            "Resource": "arn:aws:elasticfilesystem:us-east-1:<redacted>:file-system/fs-<redacted>",
            "Condition": {
                "Bool": {
                    "elasticfilesystem:AccessedViaMountTarget": "true"
                }
            }
        },
        {
            "Sid": "",
            "Effect": "Allow",
            "Principal": {
                "AWS": "arn:aws:iam::<redacted>:role/<redacted>"
            },
            "Action": "elasticfilesystem:TagResource",
            "Resource": "arn:aws:elasticfilesystem:us-east-1:<redacted>:file-system/fs-<redacted>"
        }
    ]
}

HI @kenske, I've pasted your policy into my testing EFS and Prowler raises a PASS.
As you can see in the following images I can't reproduce it.

Are you using the latest version of Prowler?
If you can, please join our Slack https://join.slack.com/t/prowler-workspace/shared_invite/zt-1whii3rzb-QqMuv0XMums9QO5K~m7h1w to talk about this issue. Open a conversation with @sergargar and @n4ch04 too.
Thanks!

Thanks @jfagoagas , I figured it out
I was missing the elasticfilesystem:DescribeFileSystemPolicy permission for the prowler role. I was able to see the error when I set the log level to DEBUG. It would be helpful if prowler surfaced those kinds of errors by default.


Updates to hub guides

Copied content over to guides_draft manually since the parent directory structure changed, causing rebase grief. Merged


TEMPEST 2023 inventory update

Includes a few corrections to previous years' data. Draft b/c I think we missed three trees; will check.

Thanks @aestearns01 @wilsonsj100


[Bullet] KinematicBody (3D) move_and_collide fails to return KinematicCollision with small velocity

Godot version
3.5.rc4.official [e047c5006]
System information
Win10, GLES3, Bullet Physics
Issue description
When using move_and_collide, it will fail to return a KinematicCollision if the collision resulted from a small velocity. This is a regression from the version of Godot I currently use, 3.4.4 stable.
I have a KinematicBody with a Cylinder CollisionShape which I will move into a StaticBody with a Cube CollisionShape.
With the following code:
func _physics_process(delta):
    var col = move_and_collide(Vector3.DOWN * 0.1 * delta);
    if (col):
        print("Collision");

you will never see "Collision" printed to the output. However, if I change that 0.1 to a 5.0, you will see "Collision" printed.
I've created a minimal repro project to demonstrate.
Steps to reproduce
Load the provided repro projct.
Press play
Note the cylinder touches the cube and does not produce any output. If you want, you can even breakpoint line 18 in KinematicBody.gd and see that the execution never pauses.
Now hop into KinematicBody.gd and modify the 0.1 to be 5.0.
Play the project again and note that we now get the expected collision.
Minimal reproduction project
move_and_collide_problem.zip

@elim2g Can you reproduce this in any of the 3.5 betas and RCs to determine when the regression started?
Also, can you reproduce this after switching the 3D physics engine to GodotPhysics in the Project Settings?

This issue is isolated to Bullet, I cannot reproduce it with GodotPhysics. Will get back shortly with when the regression first appeared.

This regression first appears in beta5 (3.5.beta5.official [815f7fe63]. beta1 - beta4 behave as expected. beta5 and every RC reliably reproduce the issue.

Hi, the issue is caused by this commit: https://github.com/godotengine/godot/commit/65b3200a163388088cce9f373fd986b515cff341
Specifically the line in physics_body.cpp: KinematicBody::_move() function,
if (collided && col.collision_safe_fraction < 1)

It appears that in Bullet, with small velocities, it's possible for collided to be true while col.collision_safe_fraction to equal 1, therefore failing the evaluation. If I had to take a guess, this is probably due to margins but that's purely speculation. If I build from source and remove the && col.collision_safe_fraction < 1 part of the conditional, the problem is resolved.
Hope this helps, thanks

The mentioned commit https://github.com/godotengine/godot/commit/65b3200a163388088cce9f373fd986b515cff341 causes collisions generated only from recovery not to be reported by move_and_collide, which I think is a good change (it fixes issues). The problem here is that Bullet doesn't detect a collision during the motion. This is caused by the final argument to convexSweepTest here https://github.com/godotengine/godot/blob/db5550a3b747112c4ee543d252e5817bd22ef42d/modules/bullet/space_bullet.cpp#L988 namely allowedCcdPenetration, being equal to the (relatively large) constant 0.04.
Setting that parameter to 0.001 fixes this issue. Setting it lower breaks things. I'm not sure what's the best general solution.

I would like to add that I'm encountering a similar issue right now in rc4, but instead of being triggered by small movements it's being triggered by using either GodotPhysics or Bullet in combination with a high Physics FPS, such as 120, and the angle of the collision also matters. The lower the Physics FPS or the more direct the collision (as opposed to at a shallow angle) the less likely this problem occurs.
For instance, I have a player character able to shoot pulses from a weapon. At a physics rate of 20 FPS, move_and_collide() does its job at all times, but at 120 FPS if the angle of the pulse's movement relative to the surface it hits is only a difference of about 20 degrees, the pulse will just slide along the surface instead. At 240 FPS physics the pulse needs more than a 40 degree angle of impact to not start sliding!

Can confirm this is an absolutely game-breaking regression for me.  Effectively, move_and_collide almost never returns a result, even though there is a collision.  I've attached a sample project here:
test_3x_kinematic_collision.zip
On frames where there's a collision, the box turns red.  What's interesting is that I also tried doing an additional test_move_and_collide() which has a movement LARGER than the margin, and it still fails to collide.
I'm not really sure why this change to add && col.collision_safe_fraction < 1 was introduced.  Removing it appears to fix the issue for me as well. The bugs the pull request referenced seemed to be for 2D stuff, which is completely different.  The 3D bug shown in the pull request can be fixed by doing multiple steps of move_and_collide in one frame, adjusting the velocity after there's a collision.
I should probably sync more often. 😅

Fixed by #64875.

Problem still exists in 2D of 3.5.1, which includes the #64875  update.
Attached is the project above, with 3D objects converted to 2D and the problem present:  move_and_collide_problem.zip
Vector2.DOWN * 4 * delta and lower velocity does not trigger the collision response
Vector2.DOWN * 5 * delta and higher velocity does
As with the OP, the problem does not exist in 3.4.4
Godot Engine v3.5.1.stable.official.6fed1ffa3 - https://godotengine.org
OpenGL ES 3.0 Renderer: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2


[BACKLOG-37531] Exclude BC dependencies from plugin lib folder.

:white_check_mark: Build finished in 10m
Build command:
mvn clean verify -B -e -Daudit -amd -pl plugins/core/impl

:ok_hand: All tests passed!
Tests run: 79, Failures: 0, Skipped: 1    Test Results

:information_source:  This is an automatic message


Fix TestScopedSpillInjection::testingSpillPoolRegExp

TestScopedSpillInjection::testingSpillPoolRegExp should return a reference which
is a typo from previous tsan build fix.

@duanmeng Would you explain what's going on here?
@xiaoxmeng Meng, would you help review this fix?

@mbasmanova it is a fix for a typo from previous tsan build fix.


Corect readme file

Correct png icon path in readme file in branch v1.4.0. What path should be used when changing branch. Should be stored outside github? Or there is same place in github?

change to


Fix unittests build, when all-in-one is enabled.

JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély<EMAIL_ADDRESS>

ALL_IN_ONE=ON make unittests produces the following error:
[100%] Built target unit-test-parser
jerryscript/jerry-core/ecma/builtin-objects/ecma-builtin-string-prototype.cpp: In function ‘ecma_builtin_string_prototype_object_replace_loop’:
jerryscript/jerry-core/ecma/builtin-objects/ecma-builtin-string-prototype.cpp:770:39: error: ‘index_of’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
       context_p->match_end = index_of + ecma_string_get_length (search_string_p);

LGTM

Looks good to me.


Adding PaulBouchiers covariance changes

Regarding covariance generation in Issue #17
I've plucked the covariance changes made by Paul which never got merged (https://github.com/ros-drivers/nmea_navsat_driver/pull/19)
It uses GST covariance where available, otherwise uses default covariances estimated from fix type.
I've tested it on a ublox C94-M8P.

Done!

This change looks good to me, and I didn't observe any regressions testing with my USB device.
If no one objects before 21:00 UTC (5 PM US Eastern time) on Monday August 27, I'll merge this change.
I'm not sure if the change can be backported to current versions, because users may be depending on the existing covariance calculation. If the change isn't backported, it would be released in ROS N in Spring 2019. In the mean time, anyone who wants the improvement can build the package from source.


Pass credentials around with context

Overview
My higher goal is to have State not store the workspace, context, nor credentials.
We store Context and Credentials separately in the database. So it makes sense to keep them separate.
But having a single container that holds all runtime state simplifies matters.
Before
Passed Context and Credentials separately.
The State accessed them using State#workspace#context and `State#workspace#credentials.
If we go towards removing State#workspace, run_nonblock(context, credentials) will provide that data.
After
Context contains the context and Context#to_h returns the same value. But Context#credentials will contain the sensitive credentials.
The State accesses them using State#workspace#context and `State#workspace#context#credentials.
If we go towards removing State#workspace, run_nonblock(context) will be able to provide that data.

update:

rebased

update:

rebase


🔀 use min/max enum value for min/max

Unsorted enums in message specifications do not result in correct
min/max values per the protobuf spec for cpp code:
https://developers.google.com/protocol-buffers/docs/reference/cpp-generated#enum
The google cpp compiler uses the min/max value in the message spec, so
this patch updates nanopb to do the same.
Example input:
syntax = "proto3";

enum Language {
    UNKNOWN = 0;
    ENGLISH_EN_GB = 12;
    ENGLISH_EN_US = 1;
    FRENCH_FR_FR = 2;
    ITALIAN_IT_IT = 3;
    GERMAN_DE_DE = 4;
    SPANISH_ES_AR = 13;
    SPANISH_ES_ES = 5;
    SPANISH_ES_MX = 14;
    SWEDISH_SV_SE = 6;
    DUTCH_NL_NL = 7;
    KOREAN_KO_KR = 8;
    JAPANESE_JA_JP = 9;
    CHINESE_SIMPLIFIED_ZH_CN = 10;
    CHINESE_TRADITIONAL_ZH_TW = 11;
}

I'll add a test to cover this particular case ASAP!

Seems reasonable.
@isotes What do you think?

Updated with some tests.

Thanks a lot!

Sounds good to me!


Move log file(s) to log-directory?

I'm on v1.8.27, running it in docker not connected to HA (i run OpenHab).
I want to have linux rsyslog read the log file and notify my syslog server with errors, and today i do that by binding the volvo2mqtt.log log file that resides in the main directory. That log file just wrapped around (> 100kb in size) and i ran into docker issues mapping that 2nd file.
Any chance you can move the log file to a local directory (like "log" in the main directory) i can bind to instead of binding to the file?

Permission issue with the bind mount?

I'd rather avoid:
volumes:
  - type: bind
    source: ./logs/volvo2mqtt.log
    target: /volvoAAOS2mqtt/volvo2mqtt.log
  - type: bind
    source: ./logs/volvo2mqtt.log.1
    target: /volvoAAOS2mqtt/volvo2mqtt.log.1
  - type: bind
    source: ./logs/volvo2mqtt.log.2
    target: /volvoAAOS2mqtt/volvo2mqtt.log.2
  - type: bind
    source: ./logs/volvo2mqtt.log.3
    target: /volvoAAOS2mqtt/volvo2mqtt.log.3

....

No, logging to volvo2mqtt.log works.
It was some time since i got the error, so can't remember exactly what error i got. But it was when volvo2mqtt.log was full (100k) and was gonna be moved to volvo2mqtt.log.1 and a new volvo2mqtt.log created.
So then i thought: "why do i have to map each file, can't they be put in a log directory instead?"

can the docker container create a new file or does it not have write permissions?
what does your docker-compose.yml look?

  - type: bind
    source: ./logs/volvo2mqtt.log
    target: /volvoAAOS2mqtt/volvo2mqtt.log
  - type: bind
    source: ./logs/volvo2mqtt.log.1
    target: /volvoAAOS2mqtt/volvo2mqtt.log.1
  - type: bind
    source: ./logs/volvo2mqtt.log.2
    target: /volvoAAOS2mqtt/volvo2mqtt.log.2
  - type: bind
    source: ./logs/volvo2mqtt.log.3
    target: /volvoAAOS2mqtt/volvo2mqtt.log.3

But i'd rather have this:
volumes:
  - type: bind
    source: ./logs/
    target: /volvoAAOS2mqtt/logs/

i.e. i don't want to single-bind a log file. This ticket isn't about write permission, it's about log dir structure.

Looks like if you run this as a Home Assistant addon you do get the log in /logs
https://github.com/Dielee/volvo2mqtt/blob/907440b81e8e2ba54dd11426b7328dd1070701c7/src/util.py#L44
I'm not sure why ypu can't just do?
 - type: bind
    source: ./logs/volvo2mqtt.log
    target: /volvoAAOS2mqtt/

I do not run HomeAssistant (see first post).
Never bound a container file to a host directory. But no matter if it works or not, it will still force me to bind each and every log file in the docker-compose file.

Never bound a container file to a host directory. But no matter if it works or not, it will still force me to bind each and every log file in the docker-compose file.

I'm not sure why it would require you to create every file if the container had the correct host permissions but I don't feel that I have anything else to add.
Good luck.

Please bind every single file. It will work and you don't even need five versions from the log, in my opinion.


New feature request. Temp basal duration configuration

It would be great if user could change duration of temp basal = 0 (when smb is planned).
Reason: today night iaps set temp basal = 0 for 90 minutes. 5 minutes later iaps connection to pump was failed and it was “red loop” for the whole night.
Because of some cob I had bg increase untill basal wasn’t started and insulin started acting.

This is the whole point os SMB, to deliver insulin as small boluses instead of temp basals, thus when delivering insulin as an SMB the basal is shut off. If you don't like the dosing to only happen via SMBs you can decrease the SMB basal minutes or turn of SMBs, to increase the use of temporary basal insulin instead.


CASM-3760: Skip images that are already uploaded

Summary and Scope
This change modifies the behavior of the
ImsHelper.image_upload_artifacts() method to skip uploading images
which have already been uploaded. The method now checks if there is an
image in IMS which has the same name as the desired image, and if it has
associated artifacts, then it is skipped. Empty images are uploaded and
patched.
Issues and Related PRs

Resolves CASM-3760

Testing
Tested on:

mug

Test description:
Test on internal system by uploading artifacts to empty images, creating
new images, and attempting to re-upload existing images using a test
harness script.
Run unit tests.
Test output here: https://gist.github.com/jack-stanek-hpe/ed2c8cd22ec5892c69162bc96d6fbb74
Risks and Mitigations
Newer version can be contained to use only with IUF version of ims-load-artifacts for now.
Pull Request Checklist

[x] Version number(s) incremented, if applicable
[x] Copyrights updated
[x] License file intact
[x] Target branch correct
[x] CHANGELOG.md updated
[x] Testing is appropriate and complete, if applicable
[x] HPC Product Announcement prepared, if applicable

I am a little uncomfortable using name alone to figure out if the image is the same. I would rather see a size and md5sum comparison as well, but since this is optional we can probably let it go for now.

I am a little uncomfortable using name alone to figure out if the image is the same. I would rather see a size and md5sum comparison as well, but since this is optional we can probably let it go for now.

I agree, it isn't ideal in the general case and it would be better to compare by checksum. For IUF though, since this is an RC, I'll be merging this as-is, and I've moved out the change to compare by checksum into CASM-3868.


rr crash , external network can not access k8s pod ip  immediately

rr crash , external network can not access k8s pod ip  immediately，it is dangerous ！！！

Hi @timchenxiaoyu, could you please provide more information on your issue and setup (environment, expected/current behavior, steps to reproduce, etc)?
Our docs do mention to run at least 2 route reflectors for redundancy (https://projectcalico.docs.tigera.io/networking/bgp#route-reflectors), did your have only one running or 2 of them crashed? Do you know what caused the crash?


std::min and std::max on Windows

Fyi, I was getting some compilation errors in pocketpy.h related to std::min and std::max on Windows. This is a well known issue (see Stackoverflow on this): basically because windows has min and max macros defined.
The solution is quite simple to wrap std::min and std::max in brackets: std::min -> (std::min)  etc..

Which version are you using now? This was already fixed in the main branch.
#ifdef min
#undef min
#endif

#ifdef max
#undef max
#endif

I'm using 1.0.9 (the last release)

Looks this was fixed in 1.10. Thanks!


Edge WebView is going to be available in Win32 apps

As announced today:
https://blogs.windows.com/buildingapps/2018/03/07/three-things-need-know-windows-developer-day/#Wow5hpZziABxbccC.97

I'm closing this issue since Microsoft is going to rewrite Edge with Chromium.


Mobile wallet issue !

Hello Decred.
I get this error message from the android wallet.

could someone help
regards

A directory lock usually indicates the app is still running in the background despite your OS's attempt to relaunch it. I suggest you make sure the app is fully quit before attempting to start it.

@C-ollins not sure why this has occasionally reoccurred. Possibly we can catch this condition before the OS does and display better instructions to the user.

A directory lock usually indicates the app is still running in the background despite your OS's attempt to relaunch it. I suggest you make sure the app is fully quit before attempting to start it.

Done, working fine. thank you a ton ^^'


Table entries that include * don't show in list when filtered

I have a multi select column filter on a column that has * in the text.
Using select drop downs or free text filters I can't get it to work.
On this page : https://www.tablefilter.com/exact-match-by-column.html
Inspect source and edit the bottom 2 Sydney entries to be Sydney*B
Search for Syd
No results because exact matching is on
Search for Syd*
and it will match all Sydney and Sydney*B
Search for Sydney*
and it will match all Sydney and Sydney*B
Search for *B
and it will match only Sydney*B
This is all as expected.
Now search for Sydney*B
and it will match none, despite it being an exact match for the rows containing Sydney
We have "Grades A*-C" and "D-F" as a table entries.  We can search for the latter but not the former.
The same happens on https://www.tablefilter.com/exact-match.html
We're on version 0.6.39
This is similar to https://github.com/koalyptus/TableFilter/issues/30 but there the * character was at the end of the search string not in the middle.

Hi @cjohnsonuk, the * operator gets stripped off from the filter query to be able to have partial matches on cell string. It misbehaves with the Sydney*B case because the * gets removed as a result it is searching for SydneyB, it doesn't know the user intention is to not use the * operator. It probably makes sense to disable it when exact match behaviour is on. Why would you let search with the * operator if you enforce an exact match in the filter? ... What you reckon?
By the way, you can change the exact match operator to be something else, in above demos:
tf.lkOperator = '(*)';

and you would have matches only with Sydney and Sydney*B terms.

Thanks for the swift response. I'll give that a try on Monday! 😀


Issue downloading on Mac

OS: MacOS 12.0.1
Docker: 20.10.10
Docker Compose: 1.29.2
Steps to reproduce:
git clone --depth 1 https://www.github.com/terra-money/LocalTerra
cd LocalTerra
docker-compose up
Error:
Traceback (most recent call last):
  File "urllib3/connectionpool.py", line 670, in urlopen
  File "urllib3/connectionpool.py", line 392, in _make_request
  File "http/client.py", line 1255, in request
  File "http/client.py", line 1301, in _send_request
  File "http/client.py", line 1250, in endheaders
  File "http/client.py", line 1010, in _send_output
  File "http/client.py", line 950, in send
  File "docker/transport/unixconn.py", line 43, in connect
FileNotFoundError: [Errno 2] No such file or directory

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "requests/adapters.py", line 439, in send
  File "urllib3/connectionpool.py", line 726, in urlopen
  File "urllib3/util/retry.py", line 410, in increment
  File "urllib3/packages/six.py", line 734, in reraise
  File "urllib3/connectionpool.py", line 670, in urlopen
  File "urllib3/connectionpool.py", line 392, in _make_request
  File "http/client.py", line 1255, in request
  File "http/client.py", line 1301, in _send_request
  File "http/client.py", line 1250, in endheaders
  File "http/client.py", line 1010, in _send_output
  File "http/client.py", line 950, in send
  File "docker/transport/unixconn.py", line 43, in connect
urllib3.exceptions.ProtocolError: ('Connection aborted.', FileNotFoundError(2, 'No such file or directory'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "docker/api/client.py", line 214, in _retrieve_server_version
  File "docker/api/daemon.py", line 181, in version
  File "docker/utils/decorators.py", line 46, in inner
  File "docker/api/client.py", line 237, in _get
  File "requests/sessions.py", line 543, in get
  File "requests/sessions.py", line 530, in request
  File "requests/sessions.py", line 643, in send
  File "requests/adapters.py", line 498, in send
requests.exceptions.ConnectionError: ('Connection aborted.', FileNotFoundError(2, 'No such file or directory'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "docker-compose", line 3, in <module>
  File "compose/cli/main.py", line 81, in main
  File "compose/cli/main.py", line 200, in perform_command
  File "compose/cli/command.py", line 60, in project_from_options
  File "compose/cli/command.py", line 152, in get_project
  File "compose/cli/docker_client.py", line 41, in get_client
  File "compose/cli/docker_client.py", line 170, in docker_client
  File "docker/api/client.py", line 197, in __init__
  File "docker/api/client.py", line 221, in _retrieve_server_version
docker.errors.DockerException: Error while fetching server API version: ('Connection aborted.', FileNotFoundError(2, 'No such file or directory'))
[45761] Failed to execute script docker-compose

docker-compose cannot connect to docker daemon. please check docker daemon is alive and your account is authorized(by usergroup)


create-vite: add scaffolding to support vscode extensions

Description
As a developer starting to use Vite, I would like to have create-vite take advantage of the fact two vscode add-ins have been written that can speed and simplify development.
Suggested solution
This is easy.  Templates should simply generate a JSON file .vscode/extensions.json with content like:
{
    "recommendations": [
        "antfu.vite",
        "antfu.browse-lite"
    ]
}

From there, vscode does the rest, asking if the developer wants to use recommended extensions to the IDE.
Alternative
Is there some sort of template inheritence mechanism so this doesn't need to go in each template?
Additional context
I note that the template-svelte & template-svelte-ts both already include a, vscode/extensions.json file, but it includes for a different, svelte-specific extension.
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

I think we should have these added by users themselves as it's not necessarily needed when working in a Vite project. The Svelte and Vue templates have recommended extensions as it's almost essential when working on a Svelte and Vue projects.


Passenger 5.0.22 now filtering header with underscore

Very annoying "bug" because https://blog.phusion.nl/2015/12/07/cve-2015-7519/
SSL header was not set at all and any agent cannot connect to master.

@vbauchart Are you sure that this CVE is the issue? It says in the report that NGINX and Passenger are unaffected. Have you tested this fix?

Hi!
I was unable to run puppet into my docker build until I made this change.
It says that nginx already fixed this... so it should have never work ?
Btw yes it does fix my issue.

My apologies for the delay, merging now. Crazy busy week at work.
To be clear for all future users: according to the CVE report by upstream, NGINX is not affected by the vulnerability. This pull request simply fixes an issue with the NGINX configuration.


The strings on the search box overlap if resize the preview editor

Storage Explorer Version: 1.33.0 (97)
Build Number: 20240225.5
Branch: rel/1.33.0
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.3(Apple M1 Pro)
Architecture: x64/x64/x64
How Found: From running test case
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> Blob Containers.
Create a blob container -> Upload one .txt file as block blob.
Preview the blob -> Focus on the preview editor.
Press 'Ctrl+F' -> Resize the preview panel.
Check the strings on the search box do not overlap.

Expected Experience
The strings on the search box do not overlap.

Actual Experience
The strings on the search box overlap.

This is Monaco's search box and not ours, so is there anything really actionable on our side?

Ya, nothing we can do. We'll won't fix for today.


minimap2-coverage fatal error: zlib.h: No such file or directory

Hi, I tried to compile minimap2-coverage within the cloned LongQC repo and seems to be missing a file
cd LongQC/minimap2-coverage && make cc -c -g -O2 -Wall -Wc++-compat -DHAVE_KALLOC  minimap2-coverage.c -o minimap2-coverage.o minimap2-coverage.c:4:10: fatal error: zlib.h: No such file or directory     4 | #include <zlib.h>       |          ^~~~~~~~ compilation terminated. make: *** [Makefile:29: minimap2-coverage.o] Error 1
Any ideas?

I was missing the development support files for zlib so had to run
sudo apt-get install libz-dev
and make then ran without issues


Touch Inputs

This input library is very useful! Although i was wondering if you plan to implement touch inputs like the love.touchpressed and love.touchreleased functions

I have no interest in supporting mobile myself. If you'd like to you can try to implement those functions yourself and I'll merge them in.


ARROW-18367: [C++] Enable the creation of named table relations

changes also include fixes from running IWYU over the directory cpp/src/arrow/engine/substrait

@westonpace Thanks for the great suggestions! I'll fix them and update the PR.

I have a few requests. This seems like a fairly clever way to produce named table relations.
The Substrait serializer works on declarations. There is no need for a declaration to have a node factory (or even have a corresponding exec node). Would it be simpler to do something like:
/// Declare a named table, there is currently no way to consume this node
class NamedTableOptions {
  public:
    std::vector<std::string> names;
    std::shared_ptr<Schema> table_schema;
};

...

Declaration named_tbl{"named_table", NamedTableOptions{{"table", "1"}, schema}};

...

Result<compute::ExecNode*> MakeNamedTableNode(compute::ExecPlan* plan,
                                               std::vector<compute::ExecNode*> inputs,
                                               const compute::ExecNodeOptions& options) {
  return Status::Invalid("The named table node is for serialization purposes only and can never be converted into an exec plan or executed");
}
...

DCHECK_OK(registry->AddFactory("named_table", MakeNamedTableNode));

Yes, I believe this is a better way to solve this.

I'm not caught up on the Substrait work. I believe Weston has just been busy lately and should be able to catch up. @westonpace, let me know if you want me to step in here instead.

I'm not caught up on the Substrait work. I believe Weston has just been busy lately and should be able to catch up. @westonpace, let me know if you want me to step in here instead.

Thanks for your response.

@westonpace thanks for the fix!


Use old Mutex constructor to deal with redist incompatibility

Microsoft is a very cool company that tests their stuff.

Tested by two different people on Discord and confirmed working

I figured I should probably explain the issue at hand:
a newer release of the Windows SDK ships a new version of the STL.
It changed the Mutex constructor to be constrexpr by default
#ifdef _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR
    _Mutex_base(int _Flags = 0) noexcept {
        _Mtx_init_in_situ(_Mymtx(), _Flags | _Mtx_try);
    }
#else // ^^^ defined(_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR) / !defined(_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR) vvv
    constexpr _Mutex_base(int _Flags = 0) noexcept {
        _Mtx_storage._Critical_section = {};
        _Mtx_storage._Thread_id        = -1;
        _Mtx_storage._Type             = _Flags | _Mtx_try;
        _Mtx_storage._Count            = 0;
    }
#endif // ^^^ !defined(_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR) ^^^

https://github.com/microsoft/STL/blob/e36ee6c2b9bc6f5b1f70776c18cf5d3a93a69798/stl/inc/mutex#L35-L46
This is the opposite of the original behavior, where it was opt-in instead of opt-out.
The non constexpr constructor calls _Mtx_init_in_situ which is implemented as follows:
_CRTIMP2_PURE void __cdecl _Mtx_init_in_situ(_Mtx_t mtx, int type) noexcept { // initialize mutex in situ
    new (&mtx->_Critical_section) _Stl_critical_section;
    mtx->_Thread_id = -1;
    mtx->_Type      = type;
    mtx->_Count     = 0;
}

https://github.com/microsoft/STL/blob/e36ee6c2b9bc6f5b1f70776c18cf5d3a93a69798/stl/src/mutex.cpp#L41-L46
its almost the same as the new constructor, except that _Critical_section is being heap allocated.
The type of _Critical_section changed between versions and was previously just a pointer and now a struct with two pointers for ABI compatibility
struct _Stl_critical_section {
    void* _Unused       = nullptr; // TRANSITION, ABI: was the vptr
    _Smtx_t _M_srw_lock = nullptr;
};

https://github.com/microsoft/STL/blob/e36ee6c2b9bc6f5b1f70776c18cf5d3a93a69798/stl/inc/__msvc_threads_core.hpp#L30-L33
in the constexpr constructor the _Unused member is never allocated thus resulting in a crash.

Why does Northstar still work for some users then?
Microsoft tried updating the STL while attempting to not break ABI by expanding the existing data type and leaving existing stuff as is.
But this didn't quite work.
Old versions of msvcp140.dll ship the following code
if (mtx->thread_id != static_cast<long>(GetCurrentThreadId())) {
    mtx->_get_cs()->lock();
}

https://github.com/microsoft/STL/blob/28a6aab88a37e5cceef1fb16045296935f6ac53b/stl/src/mutex.cpp#L100
This will attempt to dereference the _Critical_section._Unused causing a NULL dereference and thus crashing.
a newer version of the redist uses this code
if (mtx->_Thread_id != current_thread_id) {
    AcquireSRWLockExclusive(get_srw_lock(mtx));
}

https://github.com/microsoft/STL/blob/e36ee6c2b9bc6f5b1f70776c18cf5d3a93a69798/stl/src/mutex.cpp#L93-L95
which does not reference the old pointer.

Fixes to this are:

downgrading the compiler (not feasible since the GH Actions Runner no longer has the previous build.
forcing the use of a static runtime library /MT (#702, was tested and apparently did not work, retrying to see if that was user error)
using the old constructor (this PR)


Locate / install ipykernel for raw launches

For #11307

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[x] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[x] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #11341 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #11341      +/-   ##
==========================================
- Coverage   61.00%   60.98%   -0.02%
==========================================
  Files         606      606
  Lines       33448    33448
  Branches     4730     4730
==========================================
- Hits        20404    20398       -6
- Misses      12021    12025       +4
- Partials     1023     1025       +2

Impacted Files
Coverage Δ

...client/datascience/raw-kernel/rawJupyterSession.ts
69.84% <100.00%> (ø)

src/datascience-ui/react-common/arePathsSame.ts
75.00% <0.00%> (-12.50%)
:arrow_down:

src/client/common/utils/platform.ts
64.70% <0.00%> (-11.77%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0.00%> (-0.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8fd21c...3d906f7. Read the comment docs.

Made some bigger changes from the initial review based on resolved conversation with Don above, so adding @rchiodo  @DavidKutu  @DonJayamanne  if anyone wants to take a second look.


On support for private repositories

I have a pretty rare use-case which is having private packages in a git repo that wouldn't make sense to be published to AUR.
As far as I understand, support for fetching from outside official AUR is only possible by using AUR_LOCATION, but that means I would have to have a separate git repo per package. Alternatively, I could use AUR_MIRROR and AUR_FETCH_MIRROR and have a single git repo with branches pointing to different packages.
Is that correct? Do you have any other suggestions for this workflow?

You could git clone the monorepo to say, packages and then do aur fetch packages from the parent directory. However since you control the contents of the repository (no upstream changes from other authors), a simple git -C packages pull should suffice.

One advantage of having a separate git repo (or branch) per package is that you can easily run aur-build whenever some revisions changed. aur-fetch already supports this with --results:
aur fetch --sync=merge --results=/tmp/foo <packages>
to_update=()

while IFS=: read -r mode rev_old rev path; do
  path=${path#file://} name=${path##*/}

  if [[ $rev != "$rev_old" ]]; then
    to_update+=("$name")
  fi
done

if (( ${#to_update[@]} )); then
  aur build --arg-file <(printf '%s\n' "${to_update[@]}") -srn
fi

in general, you'use git rev-parse --verify HEAD before and after running git pull.
With a monorepo, there are some extra steps:
#!/bin/bash
# get new upstream revisions
git fetch

# check which package directories were modified upstream
to_update=()
for pkg in packages; do
  git diff -q HEAD origin/main -- "$pkg" || to_update+=("$pkg")
done

# run aur-build in parent directory, with updated packages as arguments
if (( ${#to_update[@]} )); then
  aur build --arg-file <(printf '%s\n' "${to_update[@]}") -srn
fi

https://github.com/AladW/aurutils/commit/99726635c8706c054bd20c1a34096af06eb7f3cd allows aur-fetch to work with repositories that don't have master as the default branch.


pfs-refactor Make sure we test MakeDirectory() w conflict

Fuse test TestCreateFileInDir now passes w newly implemented MakeDirectory() but we should make sure we have a test case covering the case where a file already exists in that path.

Fixed.


Added PDB file loading support for extensions

Previously if you included a file with a .pdb extension in RustDedicated_Data/Managed it would be ignored by the extension manager.

Why is this necessary?

Most developers don't work with extensions and I've personally never had any of the core oxide extension produce any errors so this really isn't a necessary change. I moved my main plugin over to an extension recently because the code base got very large and I needed access to some restricted namespaces. Once I finally made the switch I decided I might as well add support for PDB files which made the debugging process much least time consuming. It just nice to immediately know what's causing an issue while developing rather than guessing based on the exception.

I apologize for that this is my first PR. I will definitely make a new branch next time I want to submit a PR.

No worries, and thanks for the contributions. :) I did pull your first commit, but the 2nd I'll likely hold off on as we'll be merging the CSharp extension into the core soon.


Unhappy prompt to install extension after just installing it

run ext install
find an extension and press the little install button and see how it shows progress
press the readme-button which takes you the website
:boom: returning to VS Code prompts me to (1) restart after installing X
and (2) also if I want to install X

Ugh. Been like this for months. Wouldn't promote it to stable candidate.

Fixed!


Typo "Azure function"→"Azure Function"

https://docs.microsoft.com/en-us/azure/digital-twins/how-to-create-azure-function

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

The  update in the pull request doesn't align with internal style guidance. But, neither does the original, so we're checking on how to process the PR.  #hold-off

This commit has been moved to the private repo for merging. We'll close this pull request. Thanks.


Access files in Meteor public folder

Just discovered storybook and it's pretty neat!
I'm using it together with a Meteor project. Also, I'm using static images in some stylesheets. The images are in the /public folder. Is it somehow possible to add this folder to the webpack configuration?

Yes that's possible. See: https://github.com/kadirahq/react-storybook/blob/master/docs/configure_storybook.md#static-directory

Very neat! It works like a charm. Great job!


Don't use another copy of  page_update_higher_textequiv_levels()

I use another copy of ocrd_tesserocr's page_update_higher_textequiv_levels() here, the same I used in ocrd_calamari.
I'd like to have this in OCR-D's standard library.

👀 @kba @bertsky

Filed an issue at ocrd/core#988.


What is the model different btw ATM-S and ATM-E?

What is the model different btw ATM-S and ATM-E?
I don't find the detail in your v5 paper,
is something maybe I have misunderstood?

Hi, @ChiShengChen, thank you for your careful review. We did not clarify this in the manuscript and we are about to release the latest version of the arxiv paper.
In fact, ATM is a flexible architecture in which the plug-and-play TS convolution modules are arbitrarily replaced:
1.ATM-S uses a ShallowNet structure for the TS convolution module.
2.ATM-E uses an EEGNetV4 structure for the TS convolution module.
Moreover, our experimental results show that the structure of the temporal-spatial convolution may not be important. In our framework, either structure can achieve advanced performance in EEG visual decoding tasks.


ENH truncate files, add named ctors

Upgrade file/update to 1.5, which includes "truncate".
1.4 added quickkey/folder path option instead of only identifying a file
by quickkey.  As this affects the potential constructors a Request can
have, we need a way to safely and correctly construct a request that has
disjoint union of requirements by the cloud.  Quickkey and file path are
both strings, so either we use named constructors, or force strong
typing for quickkeys or file paths.  Since named constructors is the
less intrusive change for users, it is more ideal to use that pattern.

Do check and instant fail for zero byte files in versions less than 1.5? I don't see that anything but the version changed.


Improve request parser for better compatibility with Socket Mode

This pull request improves the internals to be compatible with Socket Mode payloads.
Category (place an x in each of the [ ])

[x] slack_bolt.App and/or its core components
[x] slack_bolt.async_app.AsyncApp and/or its core components
[ ] Adapters in slack_bolt.adapter
[ ] Document pages under /docs
[ ] Others

Requirements (place an x in each [ ])
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch - Hi. I am using the slack_bolt package and started getting a new error. Looking at the logs, I traced back to this PR on the same part of the code. I am getting this when I am trying to send a message-shortcut. (I can't pinpoint why the change you made would cause the issue but the timing is curious. Can you please help?
Let me know how I can get more logs to help.
Here is the error.
Exception happened during processing of request from ('<IP_ADDRESS>', 44298)
Traceback (most recent call last):
  File "/usr/lib/python3.7/socketserver.py", line 316, in _handle_request_noblock
    self.process_request(request, client_address)
  File "/usr/lib/python3.7/socketserver.py", line 347, in process_request
    self.finish_request(request, client_address)
  File "/usr/lib/python3.7/socketserver.py", line 360, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib/python3.7/http/server.py", line 646, in __init__
    super().__init__(*args, **kwargs)
  File "/usr/lib/python3.7/socketserver.py", line 720, in __init__
    self.handle()
  File "/usr/lib/python3.7/http/server.py", line 426, in handle
    self.handle_one_request()
  File "/usr/lib/python3.7/http/server.py", line 414, in handle_one_request
    method()
  File "/app/.local/lib/python3.7/site-packages/slack_bolt/app/app.py", line 881, in do_POST
    body=request_body, query=query, headers=self.headers
  File "/app/.local/lib/python3.7/site-packages/slack_bolt/request/request.py", line 43, in __init__
    self.context = build_context(BoltContext(context if context else {}), self.body)
  File "/app/.local/lib/python3.7/site-packages/slack_bolt/request/internals.py", line 114, in build_context
    enterprise_id = extract_enterprise_id(payload)
  File "/app/.local/lib/python3.7/site-packages/slack_bolt/request/internals.py", line 54, in extract_enterprise_id
    elif "id" in org:
TypeError: argument of type 'NoneType' is not iterable

@bharat-rangan Can you upgrade to v1.1.1? The fix by this PR is included in the version.

hmm.... I did a force pip-installed and it worked. Sorry if this was a distraction

aha. Just saw your message. Thanks for contributing to this package :)


<EMAIL_ADDRESS>Creating a deep vs shallow copy of an object in Java

Creating a deep vs shallow copy of an object in Java. Example code is present in the class.

Closing down the pull request as it was asked to immediately do so. Thanks.


unable to connect to server

I just upgraded to 1.2.72  and after that i am unable to connect to server.
Synapse Console says Failed to open the project
and error.log file is empty.

protocol : SFTP
port : 22
passphrase authentication
I am able to connect & edit files with notepad++, so no connectivity issues there.

thx for detail info.I understood my mistake on export error funcs thunks.
plz tell me could you connected to the server via the sftp before updated?

before updating i was able to connect and view files
but was not able to upload.

do you remember the version before update?

it was 1.2.71

sorry one more question.
you said use passphrase.
Is the passphrase for it is key authentication?
or
did you choose password authentication via the SFTP?

and now 1.2.73 available.
please try again.
and please confirm error log when the error occured.

I am using password authentication for SFTP.
still unable to upload the file on save.
The error.log file is empty


Kepler with K3s on Virtual machine

Describe the bug
Hi,
I am trying to install kepler on a k3s s Virtual machine Ubuntu 20 (kernel 5.15) , however it would appear that kepler is unable to expose container metrics, when I made "curl http://<IP_ADDRESS>:9102/metrics | grep container"
I receive no metric about container

@EmilioIppoliti can you check if your VM is running cgroup v2, i.e. mount |grep cgroup?
On the VM, kepler uses cgroup stats to estimate energy consumption. Currently only cgroup v2 is supported.

yes, this looks familiar to the issue I used to meet, maybe related to cgroupv2
and Ubuntu seems should work but I think CentOS might be a better starting point

I really thank you for you answers , anyway I checked the correct version of my cgroups in my linux distro ,
I think they are mounted correctly , it could be something related to virtualisation or k3s ?

Thank you for your support

@EmilioIppoliti can you turn on verbosity to v=5 in kepler daemonset and share the log? How is your k3s configured? Does it use cri-o or containerd? If you can get the containers' cgroup path, that'll help us to check if the paths are expected by kepler, e.g. when using cri-o, you can use crictl to inspect the pod/containers:
# crictl inspect 5cad2f004420c |grep -i cgroup
          "destination": "/sys/fs/cgroup",
          "type": "cgroup",
          "source": "cgroup",
        "cgroupsPath": "kubepods-burstable-pod1a0de199_47c2_4db5_a593_0121bcd42e96.slice:crio:5cad2f004420cf8cdc11f8e4813dec9c658a85851645c14d126e518178d038ff",
            "type": "cgroup"

and usually the startup logs can provide some key wording about settings and potential issue about metric report, so can you restart the pod and wait for around 1 min then paste startup logs in addition to above output as well?
kubectl rollout restart ds/kepler-exporter -n kepler
kubectl logs ds/kepler-exporter -n kepler  -c kepler-exporter

I really Thank you for your answer ,  I set the verbosity of the log to ten .
But I was able to get more metrics , installing kepler from source code and not from the helm chart .
Maybe the source code and the helm chart have some differences?

Cool! We'll update the chart
cc @jiangphcn

thanks for report. I will work on this.

@jiangphcn any update on this?

New helm chart has tested on VM with k3s

I tried the ney helm chart and i really thank you for your support , I think that this request can be closed

thanks for verification


Don't provide GardenerShootName AvS tag

Description
Changes proposed in this pull request:
The GardenerShootName AvS Tag is not publicly available in all the KCP environments' respective AvS groups which KEB connects to. Moreover the tag is superfluous as the shoot name is already provided via the ShootNameTagClassId
This PR removes support from configuring the shoot name in AvS tags via the GardenerShootNameTagClassId.
Related issue(s)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


add a link on the the back to github

It seems like https://ducalis-rb.github.io/ has no backlink to the GitHub project

@tmaier , thank you, done:
http://ducalis-rb.github.io/
https://github.com/ducalis-rb/ducalis-rb.github.io/commit/770150d884395c6aa08ec13cbf971e55993452ec


Choose default directory for runtime files (counters, etc)

Let us choose a well-defined default naming scheme for temporary data files created by Snabb Switch processes. This will make it easy to store information (e.g. counters from traffic processes) and to read and aggregate it (e.g. from snabbtop #472 or netsnmp).

[x] Choose a suitable root directory on the filesystem.
[ ] Choose a naming and directory structure within the root.

For a root directory one idea would be to look at the Filesystem Heirarchy Standard and see which standard location best matches our requirements. For example, if we would like a ramdisk then /var/run/ could be suitable.
How about the naming scheme? Subdirectories named by pid, for example?

@lukego I hacked something up that generally works: https://github.com/eugeneia/snabbswitch/compare/snabbtop...eugeneia:snabbtop-fs
It implements the /var/run/snabb/<pid>/<resource> scheme. snabb top will either select the only running instance or expect the user to specify one (by pid). Both core.app and snabb top agree on using a shared "resource" ("core-stats").
There is one (recurring) problem though: We need a reliable way to run cleanup code on abnormal exits. In this case its important that the  directory is deleted when snabb is killed so that we don't leave behind stale resources. That probably mean reading a signalfd during pace_breathing?

I like this scheme.
Perhaps we could even have an optional name that would create/update a symlink? So you could write snabb top snabbnfv-traffic-01:00.0 to attach to the latest incarnation of the named process. (symlink like /var/run/snabbnfv-traffic-0 -> 90210).
Cleanup is interesting. Yes, we need to clean up old files to avoid using unbounded space, particularly on a RAM disk. On the other hand, the state of a given process might actually be especially interesting after it has crashed/terminated. So it might be nice to have a scheme that would somehow expire old directories to keep the space usage within bounds but without being too eager to delete data?

Here is another idea:
Suppose that we used a symbolic name instead of a PID. Then we could avoid leakage by using a reasonably small set of names. The decision then would be what happens when we start and the directory already exists: do we delete it, archive it, or use it?

I'll play the UNIX's advocate here. I think using the PID (publicly) is smart because the process starting Snabb can get it without much knowledge about Snabb internals. Furthermore the calling process is generally in a better spot to manage the instances resources:

It can easily tell when Snabb exits
It can create symlinks for arbitrary purposes (snabb top doesn't care whether the identifying string is a PID or "foo")
It can archive / snapshot the resources
Enabling arbitrary management of the instance resources would require as little as an option to snabb: "Don't cleanup the instance directory."

While I see the merits of the behaviors you propose, I think they don't need to be implemented by Snabb Switch. I'd say: have a simple and functional default behavior and enable independent extension. The idea here is: Operators love simple interfaces and flexibility.

There is a precedent for keeping it simple and leaving such details to others: the init scripts. Snabb NFV is not pushing people to use standard startup scripts and instead leaving that to people doing packaging for distributions. They are the experts on how they want things done (sysv, upstart, systemd, logging, file ownership, etc) and we don't care so much at the moment. The best approach seems to be to let people take care of this downstream and then pull good solutions upstream in the future if that makes sense.
I am not sure about this case though. As a user I want a simple and uniform way to monitor and control the Snabb Switch processes that are running. The processes can be started in a bunch of different ways:

Throw-away instance started in an interactive shell.
Persistent instance started in a shell running under tmux or screen.
Started by script e.g. init.d or bench_env.

If we push work onto the code that is starting Snabb Switch processes that it would seem to complicate all of those scenarios and make it harder to control Snabb Switches in a consistent way that is independent of how they started. That sounds negative to me.
I would also like to drastically simplify the bench_env scripts. They are complex and a lot of that comes from boring details like keeping track of which processes have been started and making sure they are terminated together. So if we would do more in the Snabb Switch core it could potentially make these scripts simpler too.
The notion I have in mind is a bit like the Erlang -sname foo argument that assigns a name to a process that is unique to the local machine. That seems to work fairly well in practice.

Here is something I did not really consider: it could be that it is hard to automatically choose a suitable name.
For example, if the traffic process would self-assign itself the name snabbnfv-traffic-01:00.0 then that seems simple on the surface but how will the name change if we have one process handling multiple ports or one port shared by multiple processes? Then we are potentially making life more complicated than if the startup scripts would manually assign a name that suits them (e.g. nfv-1).
So I start to come around to your way of thinking.
I wonder if we could have a command like snabb gc that would clean up old directories in a good way and could be easily called from scripts or cronjobs that want to adopt a default behavior?

I suppose also that over time snabb top could  be made quite flexible about how it chooses which instance to monitor. For example instead of always having to be told the pid or symlink name perhaps it could do a simple search of the available directories. Then naming becomes less of a big deal if a user can say snabb top nfv 01:00.0 and it finds the right instance heuristically. That may not be the best example but at least I see now that we are not so heavily dependent on a symbolic name or lack thereof.

Closing this issue. I think you have all the context to decide what you think is the best way to do this for snabb top.


Fix of UBI and Python version used for Jupyter TrustyAI image

This is a similar fix as the #199 was. Was brought in via #164 that was merged later.

Description

How Has This Been Tested?

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

/ok-to-test

/override ci/prow/notebooks-e2e-tests
/override ci/prow/images


Make Fancy Zone's Appearance have a more "Windows 11" style

Description of the new feature / enhancement
I don't know if it would be possible, but I would really love more apps to use the "Mica" effect, but at the very least, make the zones have rounded corners.
Scenario when this would be used?
When switching between zones. It would be nice to possibly have a "Windows 10 default" and then a "Windows 11 default", along with custom colors option.
Supporting information
No response

Would have to look what the overlay for snapping does but my gut says it is acrylic.

The effect is known as Mica. Mica was created for Windows 11, which is a more performant based version of their Windows 10 Acrylic effect.

Dialogs and flyout tend to use Acrylic, full-screen backgrounds (e.g. the blur effect at the top of Notepad) use Mica.
I think moving to WinUI 3 will enable us to use both where appropriate :)!

https://docs.microsoft.com/en-us/windows/apps/design/signature-experiences/materials

/dup #13421


feat: finalize polygon support

support in place, going to close this and can make follow up prs if needed


Add .yarn/ folder

@ratahtatah any links to StackOverflow discussions or other documentation about this change?

I think this is an over-the-top version of #3327
The relevant documentation is provided by the yarn homepage itself.

@drothmaler thanks for spotting the related PR.
I'm going to close this out as #3327 covers most of the value in this PR, and the author is no longer contactable.


Creation mode switching bugfix

More explicitly determines what changes will cause disabling the current editing process.  Changes to the track type or other values shouldn't cause the in process annotation to disable and reset.   Changes to the editType, selectedTrack or selectedKey will cause the editAnnotationLayer to disable and switch to a different mode.
I'm using the existing changeData stuff for line creation to skip updates when data not relevant to the current editing Type (line,rectnagle, poly) or selectedKey isn't changed.  So if track types are changed it won't kick it out of editing mode.
I found another issue in here related to continuous head/tail mode that has to do with rectangleLayer selecting the previously created mode on mouse release right after creation causing the older trackId to be reselected instead of the new one.

Sorry for the delay.  I'm really trying to get my head back around how these parts of the code work again.

Sorry for the delay. I'm really trying to get my head back around how these parts of the code work again, beyond just what these small changes do.

I fully understand.  It was hurting my head the other day even attempting to wrap my mind about the data flow during the annotation editing/creation process and how it can be interrupted by changing annotation Types, Track Types or other reactive changes that can cause a call to updateLayers inside of the LayerManager.


fix coverage for pipeline jobs

sadly it is still throwing cast exception with jacoco. I haven't been able to figure out how to get the publishers from a WorkflowJob.

Is the jacoco plugin causing the issue? I am working on making an alternative workflow available for jacoco where the phab jenkins plugin will read the xml report directly and does not require installation or use of the jenkins jacoco plugin to publish coverage reports. That might help?

the problem is here:
    private JacocoPublisher getJacocoPublisher() {
        Project<?, ?> project = (Project<?, ?>) ((AbstractBuild) build).getProject();
        return (JacocoPublisher) project.getPublisher(JacocoPublisher.DESCRIPTOR);
    }

with this:
20:45:59 java.lang.ClassCastException: org.jenkinsci.plugins.workflow.job.WorkflowRun cannot be cast to hudson.model.AbstractBuild
20:45:59 	at com.uber.jenkins.phabricator.coverage.JacocoCoverageProvider.getJacocoPublisher(JacocoCoverageProvider.java:119)
20:45:59 	at com.uber.jenkins.phabricator.coverage.JacocoCoverageProvider.readLineCoverage(JacocoCoverageProvider.java:126)
20:45:59 	at com.uber.jenkins.phabricator.BuildResultProcessor.processCoverage(BuildResultProcessor.java:296)
20:45:59 	at com.uber.jenkins.phabricator.PhabricatorNotifier.perform(PhabricatorNotifier.java:257)
20:45:59 	at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:80)
20:45:59 	at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:67)
20:45:59 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1$1.call(SynchronousNonBlockingStepExecution.java:50)
20:45:59 	at hudson.security.ACL.impersonate(ACL.java:290)
20:45:59 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1.run(SynchronousNonBlockingStepExecution.java:47)
20:45:59 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
20:45:59 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
20:45:59 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
20:45:59 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
20:45:59 	at java.lang.Thread.run(Thread.java:748)

Also there is no getProject on WorkflowRun, you can getParent, but it it returning WorkflowJob and it has no methods to get the publishers, only the actions, so it is possible to get JacocoBuildAction without any problem.


Honour flags

Some lessons have flags. We pass them in but currently don't honour them.

ignore_characters (list of characters)
case_sensitive (boolean)
require_spaces (boolean)

I don't know much about what they do. Look in HaxePloverLearn to find out.

From the original README.ml:

The recognized settings are:

case_sensitive : requires user to match uppercase and lowercase. False by default.
require_spaces : requires user to generate spaces at the end of each word.
False by default. Mostly only useful for fingerspelling exercises.
ignore_characters : ignores specified characters such as hyphens in prefix lesson.
warning_message : arbitrary message at the top of the lesson title screen.
notice_spaces

"notice_spaces" isn't documented but is used. What it appears to do: if require_spaces is set, it proceeds as normal except that the target string has a space appended (this looks like a workaround for something). Otherwise, IF the target string ends in any of ". ? ! ; :" THEN all spaces are removed from the input.

"case sensitive" fixed

"require spaces" fixed

"ignore characters" fixed

I'll check whether "notice_spaces" and "warning_message" do anything actually useful.