Update unit tests to use @Test attribute, descriptive names

Is your feature request related to a problem? Please describe.
Many of the unit tests in the Q# standard and domain-specific libraries predate the existence of the new @Test() attribute, and should be updated. The legacy method of discovering tests (namely, functions and operations in allow-listed namespaces whose names end in "Test") is more difficult to use with functionality such as test filtering and reporting, and doesn't allow for running tests on a variety of simulator targets.
For example, the existing ReverseTest function is written as:
function ReverseTest () : Unit {
    let array = [1, 2, 3];
    Ignore(Mapped(EqualityFactI(_, _, $"Reversed failed."), Zipped([3, 2, 1], Reversed(array))));
}

Using the new @Test attribute would allow for giving this test a more descriptive name that helps when reading test failure logs:
open Microsoft.Quantum.Diagnostics;

@Test("QuantumSimulator")
function ReversedIsCorrect() : Unit {
    AllEqualityFactI(Reversed([1, 2, 3]), [3, 2, 1], "Reversed([1, 2, 3]) was incorrect.");
}

@cgranade I would be happy to help with this. :)
Just wondering if there is a naming convention regarding the test names which you would recommend me to follow?

Thanks for the help. @ihristova11! Following the Q# style guide, my suggestion would be to name unit tests implemented by functions after the condition being checked (e.g.: ReversedIsCorrect in the above snippet) and unit tests implemented by operations after the action being taken to perform the check, as in the example from DistinguishabilityTests.qs below.
One thing to watch out for is that if you use @Test("QuantumSimulator") and the name of the test callable ends in Test, then the test may get run twice due to both the legacy and attribute-based testing harnesses discovering the test.
Thanks again for the help, and please let me know if there's anything I can answer!
@Test("QuantumSimulator")
operation CheckOverlapBetweenPlusAndOne() : Unit {
    let prep1 = ApplyToEachCA(H, _);
    let prep2 = ApplyToEachCA(X, _);

    EqualityWithinToleranceFact(
        EstimateRealOverlapBetweenStates(
            NoOp<Qubit[]>, prep1, prep2, 1, 1000000
        ),
        1.0 / Sqrt(2.0),
        0.02
    );
    EqualityWithinToleranceFact(
        EstimateImagOverlapBetweenStates(
            NoOp<Qubit[]>, prep1, prep2, 1, 1000000
        ),
        0.0,
        0.02
    );
    EqualityWithinToleranceFact(
        0.5,
        EstimateOverlapBetweenStates(
            prep1, prep2, 1, 1000000
        ),
        0.02
    );
}


outputFieldMappings should be fieldMappings

outputFieldMappings should be fieldMappings

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bb2033b3-6dfa-9eaa-c474-e0651e9c2e83
Version Independent ID: a06ac4ed-59a2-7fd6-6404-96c1480024b7
Content: Extract text from images - Azure Cognitive Search
Content Source: articles/search/cognitive-search-concept-image-scenarios.md
Service: cognitive-search
GitHub Login: @HeidiSteen
Microsoft Alias: heidist

error when submitting issue, there is indeed a outputfieldmapping section also

@levalencia
It looks like your issue is resolved since you closed this thread.
If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


chat.hide()

at open-chat-manager.ts
current code:
let res = await this.Client.NetworkManager.requestPacketRes(new PacketRewriteReq(channel.LinkId, channel.Id, logId, Math.floor(Date.now() / 1000), FeedType.OPENLINK_REWRITE_FEED));
Math.floor(Date.now() / 1000) should be fixed to 1.
I captured the loco packet and it sends 1, not current unix.
The hide function will not work sometimes if sent current unix.

@starlesssss 이슈 양식 맞춰서 다시 넣어주세요.


League\OAuth2\Client\Provider\Exception\IdentityProviderException

Hi, i'm trying to get photo from microsoft graph, and need microsoftgraph accessToken ..
Here is the code that I'm using:
            $headers = $request->header('Authorization');
            $provider = new Azure($this->userConfig);
            $authorization = explode(' ', $headers);
            $accessToken = $authorization[1];

$graphAccessToken = $provider->getAccessToken('jwt_bearer', [
                'resource' => 'https://graph.microsoft.com/v1.0/',
                'assertion' => $accessToken,
                'requested_token_use' => 'on_behalf_of'
            ]);

            $me = $provider->get('https://graph.microsoft.com/v1.0/me/photo/$value', $graphAccessToken);
            print_r($me);

but i'm get bad Request response at: League\OAuth2\Client\Provider\Exception\IdentityProviderException
any solutions?
Many thanks,

Does the application, you are calling the API with, have access to the Graph permissions including user impersonation? What's the token like - the one that arrives to the API (don't post the whole token here - for security reasons - just pull the JWT body of the token through jwt.io and paste the body here pls).

Hi !
I have the same problem on the same request.
I have User.Read + profile permission from user consent.
The Header Token use is :
{
"typ": "JWT",
"alg": "RS256",
"x5t": "i6lGk3FZzxRcUb2C3nEQ7syHJlY",
"kid": "i6lGk3FZzxRcUb2C3nEQ7syHJlY"
}
The Payload is :
{
"aud": "https://graph.windows.net/",
"iss": "someiss",
"iat": number,
"nbf": number,
"exp": number,
"acr": "1",
"aio": "some aio",
"amr": [
"pwd"
],
"appid": "ea754f22-de25-466d-b9ca-d22816fbb2f7",
"appidacr": "1",
"family_name": "somemame",
"given_name": "somemame",
"ipaddr": "some addr",
"name": "somemame",
"oid": "someiod",
"onprem_sid": "onprem_sid",
"puid": "somepuid",
"scp": "User.Read",
"sub": "IvAQENVrWFEusColcGnhz0T0gpH48nir5-mutAEGNg4",
"tenant_region_scope": "EU",
"tid": "af134d43-12d4-4b2f-9e07-cc32d3c4d413",
"unique_name": "someuniquename",
"upn": "someupn",
"uti": "2L-_AtK9M0KoMyL08WofAA",
"ver": "1.0"
}
@hajekj Have you a idea of the problem ?

After a lot of search, they are 2 microsofts graph
https://graph.microsotf.com and https://graph.windows.net
The first is for the Microsoft server but the second is for Azure Cloud. Photo is only available for Organization & Schools so the photo is only available on the  https://graph.windows.net
This Framework seems to be not for the second graph....


v0.6.1 only works if debug mode is enabled

Continues #11.
I tried v0.6.1 and it now only works if I have debug mode enabled:
Syncing back files
/usr/bin/rsync -uzrtopg  runner@<IP_ADDRESS>:work/ /Users/runner/work
rsync: link_stat "/Users/runner/work/dkml-c-probe/dkml-c-probe/runner@<IP_ADDRESS>:work/." failed: No such file or directory (2)
rsync error: some files could not be transferred (code 23) at /AppleInternal/BuildRoot/Library/Caches/com.apple.xbs/Sources/rsync/rsync-54.120.1/rsync/main.c(996) [sender=2.6.9]
Terminating VM
/usr/bin/sudo kill -s TERM 1469

I think it is because with an empty syncVerboseFlag:
https://github.com/cross-platform-actions/action/blob/52ad2be2afbddaeb29083cf99497bb159942b0f4/src/action/action.ts#L225-L227
in
https://github.com/cross-platform-actions/action/blob/52ad2be2afbddaeb29083cf99497bb159942b0f4/src/action/action.ts#L235-L242
you would get the second argument (this.syncVerboseFlag) as an empty string.
rsync will see the empty string and try to sync that.
Originally posted by @jonahbeckford in https://github.com/cross-platform-actions/action/issues/11#issuecomment-1175683402

I would have hoped the empty string would be ignored but I guess that only works when executing the command through a shell, which is not happening here.

Hmm, I think the CI pipeline for this project runs in debug mode, that's why it passed.

Please try 0.6.2 now.

Works. Thx!


Charge someone per tattoo

Hello, I would really think the system could benefit from including the this ability, also being able to charge someone each time they apply a tattoo rather than only once.

You will need to add
config.tattoos = false
Right before this line:
https://github.com/iLLeniumStudios/fivem-appearance/blob/d46d6ad26e7edbf76fd09942669283b850190435/client/client.lua#L163

can it be made to charge per tattoo at the shops rather than one time payment?

Not for now. Maybe later it will be supported @Monkerai

Implemented in #205
@Monkerai @peppinoita @zZOGZz


until parameter only accept values in hours, not in minutes

https://github.com/jabrena/raton-loco/pull/15


when block not highlighted as input/output etc

The when block is not identified in the same way as the input/output/script/shell/exec blocks
Guessing it can be added to the matching in:
https://github.com/nextflow-io/atom-language-nextflow/blob/cf1ea6d773477a6a4cb8d80b4846deab611d9ab0/grammars/nextflow.cson#L48

This seems to be fixed @pditommaso?
https://github.com/nextflow-io/atom-language-nextflow/blob/40387695d768dc7c9ab7b8594cd2c925fd254e47/grammars/nextflow.cson#L48

Indeed!


Liquibase quality checks: add into CI

Starting with version 4.5.0 liquibase has quality checks, which are like static analysis for liquibase changesets. We should investigate possibilities and integrate into our CI. It's a low-priority infra-related issue.

If you got a chance to work with latest liquibase - @nulls @icemachined may be you will be able to give suggestions related to this

@akuleshov7, nope, I'm not familiar with latest liquebase


Revisions to the Email Received After Adopting One Drain

[ ] Change the first email subject to: Thanks for adopting a drain, [Name]!

[ ] Include the image below as the header of the email and center it.

[ ] Replace the existing text with the text and images below using Arial 12 pt font.

Dear (NAME),
Thank you for adopting one of San Francisco's 25,000 catch basins/storm drains and keeping it free of leaves and debris. You are joining your neighbors in helping to protect the environment, manage stormwater, and minimize flooding.
How to Care For Your Adopted Drain
•	If possible, clear the drain before and after it rains.
•	Put leaves and other natural material in the green compost bin.

•	Clear about 10 feet on both sides of the drain.
•	Medical waste or needles? Construction debris? Drain clogged underneath the grate? Report to 311 to have it handled by the City.
Drain Cleaning Safety Tips
•	Never try to lift the drain grate.
•	Clear from the sidewalk, not the street.
•	Wear reflective clothing so vehicles can see you.
•	Always wear gloves and be very careful of sharp objects.
•	Use a rake, broom, or shovel - not your hands.

Adopt a Drain VIP event [GitHub note: --> use Arial 10 pt font]
Keep an eye out for an email invitation to attend one of our VIP Volunteer events, where you will be able to receive drain cleaning tools and training. We also send periodic email reminders to clear your drains.
Thanks again, [Name], for adopting a drain in San Francisco. When each of us helps out a little, it makes a big difference!
Sincerely,
SFPUC Adopt a Drain Team
415-554-3289
<EMAIL_ADDRESS>Remember, the City and County of San Francisco won't be held responsible for anything that happens to you or others in service of maintaining your drain. Please be careful.
If you move or are no longer able to tend to your drain, please abandon it on adoptadrain.sfwater.org. Thank you. [GitHub note: --> use Arial 11 pt font]

[ ] Insert and hyperlink the buttons as shown below.

[ ] Insert the button below  and hyperlink it to https://facebook.com/sfwater.

[ ] Insert the button below  and hyperlink it to https://twitter.com/sfwater.

[ ] Insert the button below
 and hyperlink it to https://instagram.com/sfwater.

[ ] Insert the button below
 and hyperlink it to https://www.youtube.com/user/SFPUCcommunications.

[ ] Insert the button below
 and hyperlink it to https://www.linkedin.com/company/sfpuc.

@jasonlally What is the status of this request?

@jszwedko It does not appear this email has been updated. We checked the staging site and the live site. I'll send you an email.

@jszwedko It does not appear this email has been updated. We checked the staging site and the live site. I'll send you an email. @jasonlally can you help with this request?

Closing this since #250 was released


List protected consistency groups in VRG and DRPC

When protecting standalone PVCs, we are displaying flat list of protected PVCs in both VRG and DRPC. When working with consistency groups, we want to display the list of protected consistency groups each one with it's protected PVCs for better understanding the hierarchy
Sample of DRPC showing protected consistency group with list of PVCs:

  resourceMeta:
    generation: 1
    kind: VolumeReplicationGroup
    name: deployment-rbd-drpc
    namespace: deployment-rbd
    protectedcgs:
    - name: rook-ceph-dr1-1deployment-rbd-drpc
      protectedpvcs:
      - extra-pvc
      - busybox-pvc
    resourceVersion: "350102"

Sample of VRG, showing protected consistency group with list of PVCs:

protectedCGs:
- accessModes:
  - ReadWriteOnce
  conditions:
  - lastTransitionTime: "2024-11-11T12:04:22Z"
    message: PVC in the VolumeReplicationGroup is ready for use
    observedGeneration: 1
    reason: Ready
    status: "True"
    type: DataReady
  - lastTransitionTime: "2024-11-11T12:04:22Z"
    message: PV cluster data already protected for PVC extra-pvc
    observedGeneration: 1
    reason: Uploaded
    status: "True"
    type: ClusterDataProtected
  - lastTransitionTime: "2024-11-11T12:04:19Z"
    message: PVC in the VolumeReplicationGroup is ready for use
    observedGeneration: 1
    reason: Replicating
    status: "False"
    type: DataProtected
  csiProvisioner: rook-ceph.rbd.csi.ceph.com
  labels:
    app: deployment-rbd
    app.kubernetes.io/part-of: deployment-rbd
    appname: busybox
    ramendr.openshift.io/consistency-group: rook-ceph-dr1-1
    ramendr.openshift.io/owner-name: deployment-rbd-drpc
    ramendr.openshift.io/owner-namespace-name: deployment-rbd
  lastSyncBytes: 81920
  lastSyncDuration: 0s
  lastSyncTime: "2024-11-11T12:14:00Z"
  name: rook-ceph-dr1-1deployment-rbd-drpc
  namespace: deployment-rbd
  protectedPVCs:
  - extra-pvc
  - busybox-pvc
  replicationID:
    id: ""
  resources:
    requests:
      storage: 1Gi
  storageClassName: rook-ceph-block
  storageID:
    id: rook-ceph-dr1-1
state: Primary

@ELENAGER This PR only has the api changes, it would be better to see the code that adds this information to the status in the same PR.
Also, I am still wondering if a consistency group is a hierarchy level or just an attribute on the protectedPVC. What are you thoughts @BenamarMk @ShyamsundarR

Also, I am still wondering if a consistency group is a hierarchy level or just an attribute on the protectedPVC. What are you thoughts @BenamarMk @ShyamsundarR

There is (at present) no hierarchy for the groups. PVCs are protected as a group, thereby having some additional properties (like consistency across these PVCs data). The need is to reflect back to the user, which PVCs were grouped together during protection, in case it is seen as an inadequate grouping the user can take subsequent action to group them as desired.

@ShyamsundarR , @BenamarMk, I found out that there is an additional persistentVolumeClaimsRefList field in the VGR Status, so I can use it to reflect grouping in VRG and DRPC.


[REL] PyPi Nightly Releases

We should have a nightly PyPi release to build new use cases in a more user friendly way.
Presently, individuals can install the superduperdb package using the command pip install superduperdb, but it installs version 0.1, which lacks numerous recent updates. To address this, proposing a nightly release after each major/minor change. Fr example: we can have 4-5 nightly releases in between one major release. This way, users can build their notebooks by specifying the nightly release and its corresponding version. Besides, as it is a nightly release people will forgive us for some bugs which we may have overlooked!
We can pin down our notebooks with our nightly releases.

Don't agree - there's not enough action to make this necessary yet.


[Question] About project collaboration

Let's say I have an application DiscImageChef.
Let's say my application needs to decompress data, from several algorithms, that may or may not, have ever been used in an archiver (e.g., ADC, Teledisk).
Let's say I would like to use your library and implement those algorithms for the sake of your greatness (and not reinventing the wheel).
Let's say sometimes those algorithms will be ugly, propietary, or need to be reimplemented (no copy&paste, but read&understand&rewrite) from archaic libraries in other opensource licenses (GPL and LGPL)
Let's say I need pull requests to be accepted as fast as possible.
What can I do to satisfy your needs so you can satisfy my needs and we all get happy along together forever 😃

Let's say I'm very much looking for real collaboration :)
Ideally, I'd start accepting pull requests, smallish at first but then accept large ones with a common style.  I'd definitely make reviewing a priority.  I'd like to get to the point where I'd share ownership of the project as well.  I've wanted to do that for years.
As for what you want to do, I guess we can talk about items in issues or example pull requests.  I always try to be responsive to people providing actual code.
As for the licenses, I'm not a lawyer but I'd rather not get sued :). Other than that, anything goes.
Let me know what you think.

That now I only need to understand your API a little ;)
Do you need everything to have a stream or do you suffice with something like decompress(byte[] input, byte[] output)?
I have two algorithms prepared to be glued to SharpCompress as long as I know where and how!

For actual algorithms they should be Stream objects.  It's only way to really interact with bytes from arbitrary sources.
There should be plenty of examples for that.  Of course how the algorithm functions is always different but surely they act on chunks.

Being mostly algorithms used for disk images they are mostly chunk based. Not only that I need them to return the whole chunk at a time. I tried to check deflate and bzip2 as examples but they are several orders of magnitude more complex than what I have (160 lines in a static class). I'll try something and send a pull request and let's see how good it fits.

There you have #168 tell me what you think.

I may suggest a series of ideas, I've seen used in big projects, that may do easier for others to collaborate.
Usually there are a series of rules in a CODING file so I'll enumerate the ones I think the most important:
1.- Define a coding style, and use it extensively. VS2015 provides reformatting and templates to apply these. Choose your favorite.
2.- Define a standard header, so all files can be known, at a glance, their license and copyright owners.
3.- Include all applicable licenses. I've seen you have files in MPL and only MIT is included in the project root.
4.- Remember that only compatible licenses can be mixed and the most restrictive one is used. For example code containing LGPL, MIT and BSD generates an LGPL library. LGPL and APSL cannot be mixed.
5.- Write down your idea of an API and code organization. You know where to add an archiver, where to add a compression algorithm. You can write it down in seconds, external collaborators need minutes or hours to find out.
With this I think you'll attract more collaborators imho.
In the meantime thanks for accepting my patch, I'll prepare a few more in the next weeks.

I've tried to put things in a Resharper DotSettings file but you're right I haven't explicitly done anything about documenting how to contribute.
Feel free to suggest things like what you said in a PR :)


[Bug]: GitHub sign in redirects to localhost

What happened?
Tried to sign in using GitHub, got redirected to http://localhost:3000/api/auth/callback/github?error=redirect_uri_mismatch&error_description=The+redirect_uri+MUST+match+the+registered+callback+URL+for+this+application.&error_uri=https%3A%2F%2Fdocs.github.com%2Fapps%2Fmanaging-oauth-apps%2Ftroubleshooting-authorization-request-errors%2F%23redirect-uri-mismatch&state=REDACTED
Steps to reproduce the problem

Go to https://civitai.com/login
Press "GitHub"

What should have happened?
A successful sign-in.
What platforms do you use to access the site?
No response
What browsers do you use to access the site?
No response
Additional information, context and logs
No response

Fixed. Sorry about that. Looks like the GitHub oAuth tokens weren't quite right after our server migration 2 days ago.
Thanks for the heads up.


removed 'use Bitwise', updated deps

use Bitwise is depracated

I hope this PR gets merged soon.

The repository has not been updated in over 5 years. Don't expect that from this library.

any chance of this being merged? @zyro ?


Wrangler publish misses some files

🐛 Bug Report

Environment

operating system: windows 10 pro v1909 (18363.535)

Steps to reproduce
Generate workers site project, set account id, api access granted using workers site template permissions.
Static file export of Wordpress site, placed in ./public folder
Run wrangler publish
Some css and js and font files are not uploaded (as seen by http 500 error in chrome dev tools for those resources)
I suspect this is because the files are in a deep folder structure, because when these files are moved to root public folder or 1 folder deep, wrangler does not skip them and they are successfully deployed.
What did you expect to see?
I expect ALL files in ./public folder to be deployed
What did you see instead?
Some files are skipped during wrangler publish process

Hey @lighterpl - my guess is that these assets are actually being uploaded and they're just linked incorrectly from within the application.
That being said this is just a hunch, and it's very possible that they are not being uploaded! The best way for us to help here is if you could point us to a repository that reproduces the problem and then we can investigate :)

Seems that it happens when there is a subfolder anywhere inside the ./public directory named “dist” all files inside are ignored.

Aha! It seems that Wrangler is not uploading files in the .gitignore for some reason. I'm pretty sure this is a bug! While we work on a fix for this, you should be able edit your .gitignore file - it should have dist in it, you can change this to /dist so it only ignores the top level dist directory, and not the directory in your public folder. Hope this helps!


Certain MP3 files don't keep looping when using sf::Music

Certain MP3 files not looping
Certain mp3 files are not looping correctly when playing them with sf::Music and looping enabled. One of them doesn't loop at all (issue 1), the other stops looping after the first time (issue 2).
Your environment

Windows 10 Pro
SFML 2.6.X
VS 17.3.3 Pro, MSVC C++ 20
Static linking

Steps to reproduce
#include "sfml/Audio/Music.hpp"

#include <Windows.h>

using namespace std;

int main(int argc, char *argv[])
{
	sf::Music music;
	music.setLoop(true);
	music.setVolume(10);

	// This file stops playing after the first playthrough (issue 1)
	//if (music.openFromFile("SIERRA - UNBROKEN (mp3cut.net).mp3"))
	//	music.play();

	// This file stops playing after the second playthrough (issue 2)
	if (music.openFromFile("Feeling - Tung Wasabi (mp3cut.net).mp3"))
		music.play();

	MSG msg = {};
	while (GetMessage(&msg, 0, 0, 0))
	{
		TranslateMessage(&msg);
		DispatchMessage(&msg);
	}

	return 0;
}

Expected behavior
The music should never stop playing.
Actual behavior
The file "SIERRA - UNBROKEN (mp3cut.net).mp3" stops playing after the first playthrough (issue 1), the file "Feeling - Tung Wasabi (mp3cut.net).mp3" stops playing after the second playthrough (issue 2).
Analysis
In both cases the problem is that SFML only loops a file if the expected EOF point is reached and minimp3 doesn't reach it, instead it fails reading more data.
Regarding issue 1, I believe the file may report the incorrect number of samples and minimp3 takes it at face value, then just stops streaming too early when EOF is reached. Since I currently needed a solution to this, I made a workaround for myself so SFML continues looping when EOF is reached too early: https://github.com/Biohazard90/SFML/commit/bcd67988848fe76c0e498fdc8778fd38428b8612 Note, this is not a fix I am proposing, it's just to illustrate the issue and how I'm solving it since I cannot fix the mp3 files I'm working with.
Regarding issue 2, minimp3 seems to be incorrectly seeking to 0 and I proposed a fix here already: https://github.com/lieff/minimp3/issues/101
Here are the two mp3 files that have these issues:
Example mp3 files

SFML supports the audio file formats WAV, OGG/Vorbis and FLAC. Due to licensing issues MP3 is not supported.

SFML supports the audio file formats WAV, OGG/Vorbis and FLAC. Due to licensing issues MP3 is not supported.

No, MP3 is supported by SFML 2.6.X. The last patents have expired in 2017.

You're right, didnt know it was added to SFML 2.6.x.
Reproduced your issue and checked whether AL was processing the stream buffers correctly and it is indicating that there are none processed. So loop looks to be working fine, but likely the seek to Time::Zero once the mp3 is finished is not working.
Not knowledgeable enough to edit minimp3, but I did try to verify your solution and did not see it working for me.

Looks like @lieff is currently not responding, as such, I don't see us fixing this for the up coming SFML 2.6 release and I'll move it to SFML 2.6.1 in hopes they come back at one point.

Hey @eXpl0it3r, at this point it is kind of safe to assume that minimp3 is abandoned, is it maybe possible that the SFML team creates a fork of it and maintains that separate fork for future bug fixes? I am not sure what the best-practice is in such a case, but it is a bit of a shame that this cannot be fixed due to an abandoned repo.

I've tested the provided files with the dr_mp3 implementation and they loop without issues. dr_mp3 uses most of the minimp3 implementation with some API improvements and is written and maintained by the same person that wrote miniaudio and they're still quite active.
It's been a while but if anyone here wants to test the #2995 PR, @Biohazard90 / @TiEul

@eXpl0it3r Thanks, we don't have the resources to verify it right now but we'll add it to our to-do list and we'll provide feedback here.


Add shader reflection

There are lots of code used to create PiplineState and DescriptorSetLayout inside examples/. IIRC, both Vulkan and Metal supports shader reflection. I think it can help to reduce those scary PipelineState init code. Is it reasonable to add inside gfx-hal or framework based on it like wgpu or game engine, etc.?

How Vulkan supports shader reflection? Is there a function to query info from shader module?

Relection would be provided via SPIRV analysis, which is IMO out of scope of gfx-hal.
You might want to look at spirv-reflect which provide such utility.

I think this is clearly out of scope here. There are tools to work with SPIR-V, we don't stand in the way of using them.


On GEV maximum likelihood estimation and MCMC with pyextremes

I used the MATLAB 'gevfit' command to get the location parameter and the the scale parameter. These are the same as those fitted by 'pyextremes'(MCMC AND MLM), but  the shape parameter k obtained from 'gevfit' is negative, and  the shape parameter k'  obtained from  'pyextremes'(MCMC AND MLM) are  positive value which is the absolute value of the k by a lucky coincidence. Does the program 'pyextremes'(MCMC AND MLM)  not set the display for parameter negative value? Or doI need to set something else?
THANKS!

@Goddysen pyextremes uses scipy.stats distributions internally, I suggest reading documentation here. Different software has different convention for shape parameter in GEVD (and others). You can always subclass scipy.stats.rv_continous if you want custom distribution (e.g. GEVD as it is implemented by Matlab) and pass your class to the model.
Another thing you should note is that pyextremes fits distributions to transformed extremes, not to extremes as they are. You can read more here: https://github.com/georgebv/pyextremes/blob/master/src/pyextremes/extremes/transformation.py

Thanks! I obtained the geV probability density form from SCIPY and learned that its convention with the general GEV probability density form about  the sign of the shape parameter c is negative of  shape parameter k.

THANKS FOR ANSWER!


Support for nested types

I will be working on this these days

Initial version finished at #54 :)

Closing this as nested types are supported, thanks @fmrico for implementing them back then :)


Let Customers Ask Chatbot for Shipping Price

Tutorials: https://developers.sap.com/tutorials/cai-bot-shipping-3-price-parcel.html
Step 1 Point 2:
It says, the user should download a .csv file from https://raw.githubusercontent.com/SAPDocuments/Tutorials/master/tutorials/cai-bot-shipping-3-price-parcel/parcel-sizes.csv[]
This .csv and the folder cai-bot-shipping-3-price-parcel does not exist anymore.
Same for Tutorial: https://developers.sap.com/tutorials/conversational-ai-faq-chatbot-beginner.html#
Step 2:
Requires https://github.com/SAPDocuments/Tutorials/raw/master/tutorials/conversational-ai-faq-chatbot-beginner/HowToBuildAChatbot.csv
And for Tutorial: https://developers.sap.com/tutorials/conversational-ai-faq-chatbot-beginner.html
Step 2:
https://github.com/SAPDocuments/Tutorials/raw/master/tutorials/conversational-ai-faq-chatbot-beginner/HowToBuildAChatbot.csv

@MarvinSzyperski I have updated and fixed -- the second and third files listed seem to be the same. Did I misread? Did you just copy that twice? Let me know and feel free to reopen.


Add nodemailer

Tests pass but the app doesn't run!

Tests pass and app sends login email correctly.


Download buttons not working

Bug description
Nothing happens when I press any of the three download buttons at the bottom: "Get Selected", "Get this page", "Get all".

Steps to reproduce

Search a tag
Click on "Get All"
Nothing happens

Expected behavior
Images to be downloaded
System information

OS: Windows 11
Grabber version: 7.10.1

Additional Context
downloading individual images works when i click "save"
selecting multiple images then right clicking and choosing "Download Selected" works

Found the reason it didnt start downloading. After you press those buttons the download wont automatically start, you need to then go into the Downloads tab, find the job in the list, right click and press download.


Fix use of fallback AutoTVM knobs in default scheduling

Previously knob values depended on order of explicit cfg update and cfg.define_split calls in fallback mode
I.e. schedule depend where and when default KNOB values are defined. I.e. for dense x86 we define a split space and then if we are in fallback mode, we manually point some heuristic factors. And everything works well. But for batch_matmul x86 we define certain values in case of fallback in compute func first and only then in schedule these values will be overwritten by first pair from search space that is (-1,1).
This fix makes any order of execution reuse predefined values in fallback mode

@comaniac will try to add the test

That PR looks pretty good. Ping for update :-)

Thanks @elvin-n @comaniac! The PR is merged :-)


monitor: Move PolicyMatchType into pkg/monitor/api

This type is used by external components. Move it into pkg/monitor/api
to reduce additional dependencies being pulled in.

Coverage decreased (-0.02%) to 46.96% when pulling db467694e6438053d27ebcf65913e51ecb237d03 on pr/tgraf/move-policy-match-type into 418500bad872814fd9582ba6eb30b9819e4ee3b6 on master.

test-me-please


feat: [BD-46] added prop to manage modals zIndex

implemented the solution to support nested modals by default
JIRA: https://openedx.atlassian.net/browse/PAR-669

Thanks for the pull request, @vlasovmichael! I've created BLENDED-1141 to keep track of it in Jira.   More details are on the BD-46 project page.
When this pull request is ready, tag your edX technical lead.

@vlasovmichael 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.

:tada: This PR is included in version 19.13.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Added spacer.dart to widgets

Added a new ui widget, a very simple spacer that allows for an adjustable spacer that can be implemented in ten characters of code. I was encouraged to push this by several people in Gitter.

looks like #15802?

no worries!

should i close those one?

Sure, it'll be a little bit before I can get back to it


Final forbidden semicolon in frontmatter ignored

Before You File a Bug Report Please Confirm You Have Done The Following...

[X] I have tried restarting my IDE and the issue persists.
[X] I have updated to the latest version of the packages.

What version of ESLint are you using?
8.33.0
What version of eslint-plugin-astro are you using?
0.23.0
What did you do?

A final semicolon in the frontmatter of an `*.astro` file is not flagged as a warning despite forbidden by a rule.
This is the eslint configuration file.
```jsonc
{
  "root": true,
  "parser": "@typescript-eslint/parser",
  "plugins": [
    "@typescript-eslint"
  ],
  "extends": [
    "eslint:recommended",
    "plugin:@typescript-eslint/eslint-recommended",
    "plugin:@typescript-eslint/recommended",
    "plugin:astro/recommended",
  ],
  "overrides": [
    {
      "files": [
        "*.astro"
      ],
      "parser": "astro-eslint-parser",
      "parserOptions": {
        "parser": "@typescript-eslint/parser",
        "extraFileExtensions": [
          ".astro"
        ],
      },
      "rules": {
        // override/add rules settings here, such as:
        // "astro/no-set-html-directive": "error"
      },
    },
  ],
  "rules": {
    "quotes": [
      "warn",
      "single"
    ],
    "semi": [
      "warn",
      "never"
    ],
    "@typescript-eslint/ban-ts-comment": [
      "error",
      {
        "ts-ignore": "allow-with-description"
      },
    ],
    "@typescript-eslint/no-non-null-assertion": "off",
  },
}
```
Please find the Astro file below.

What did you expect to happen?
Running eslint should show 2 warnings about both semicolons and eslint --fix should remove them.
What actually happened?
With eslint only one warning is shown and eslint --fix only removes the first semicolon.
pnpm lint

><EMAIL_ADDRESS>lint C:\Lokal\DYNAMITE\dynamite-cv\astro-web
> eslint .

...\astro-web\src\pages\semi.astro
  2:61  warning  Extra semicolon  semi

✖ 1 problem (0 errors, 1 warning)
  0 errors and 1 warning potentially fixable with the `--fix` option.

Link to Minimal Reproducible Example
---
console.log('This semicolon is flagged as a warning ->')
console.log('This one isn\'t 🤷♂ ->');
---
Don't look up!

Additional comments
No response

duplicate of #102


Maximum Vin

I want to use the Vin pin to power NodeMCU, but it's not clear which is the maximum value we can use.
In the rear of the PCB it's written "Vin +5v recommended, +10V MAX".
But in this pdf, in the "POWER" section is written:
"Max Supply Voltage: 20V"

Looking at the datasheet of the power regulator
Vin should be between 4.75V and 10V

Hi @adrianlzt.
I'm working on a project with the NodeMCU v1.0. Together with the Node I have an Arduino Nano running. Thus, to simplify my hardware design, I want to power the NodeMCU from a 5Volt external power source (the same that powers the Nano board).
Since you closed this issue, did you tried to power the NodeMCU from its Vin pin?
Were there any performance issues?
What's the version of the NodeMCU board you used?
Thank you in advance!

I was just exploring how can I power the NodeMCU, but haven't done it yet, sorry.

Hello everyone,
@adrianlzt @miguelpom I'm working with NodeMCU for over 5 month, and it's time to test it on Maxell 9V alkaline battery. From 5 to 10 Vin is perfect solution.

Thanks for the information.I was looking for the input voltage.The board pins more or less matches arduino Nano.

I can confirm that 15.5V will kill the board ... from experience.

Very bad experience with 12V.... works fine 1 minute.... :-(

However, after that 1 minute at 12v, you have a lovely bench heater, again from experience!!!

Thanks for the comments guys. I thought that i can handle up to 18V .. Yet, burned out at 16v :(

This thread is useful. Thanks, guys!

I had a NodeMCU in my attic working just fine for 6 months on 5V ... replaced it with 12V and ever since then it has been cyclic rebooting, it will work fine for a few minutes (maybe 5min) then reset itself. Converted back to 5V and back to working fine again ... Thanks to this Thread! I too thought i could use upwards of 12v, seems not to be true

I have a NodeMCU Amica powered with 16V (the voltage of my doorbell) and it's working fine for two months now. I guess even though the voltage is a bit too high the ampere might be pretty low and thats the reason it works without problems.

Hello everyone,
@adrianlzt @miguelpom I'm working with NodeMCU for over 5 month, and it's time to test it on Maxell 9V alkaline battery. From 5 to 10 Vin is perfect solution.

Did it work?

Mine turned to a heater at 8Volt?

Im having trouble with a 5v power supply in at Vin. With power applied to board doesn’t work until reset button is pushed and then it works fine until next power cycle. Then it requires a reset again.
Going to rewire and supply 9v to Vin

My NodeMCUs have AMS1117 3.3 onboard step-down regulator which has a Max Vin of 15 Volts DC (taken from the device spec sheet). I've been bench running a unit at 14 Volts for 24+ hours with no excessive temperature rise, or operational issues.  I in about 50mA, therefore Power dissipation of about 0.6 Watts in the regulator as it's a linear device.
For use in a vehicle where battery charging can push, or even exceed 15 Volts from the vehicle's alternator, this is a 'little close to the wind'. A quick and dirty solution is to stick a couple of rectifier diodes in the supply lead (each will give approx 0.6Volt drop each. Might want to add a reservoir capacitor after the diodes just to smooth things out. (100uF or so.)
Disclaimer:  Use the above info at your own risk, yada, yada. If you don't understand it, don't do it!

I want to use the Vin pin to power NodeMCU, but it's not clear which is the maximum value we can use.
In the rear of the PCB it's written "Vin +5v recommended, +10V MAX".
But in this pdf, in the "POWER" section is written:
"Max Supply Voltage: 20V"

boards like Arduino and nodemcu all share common voltage regulator called AMS1117 that can support upto 18V its specifically optimized to run in 12v lead acid voltage ranges ie: it cuts of at 10v(min voltage) so go ham and plug a car battery to it :)

My experience shows that powering it with ~10.6V will kill the board (after like 15 Minutes of continuous operation) after that the board is only good for using it as a pocket warmer that can be powered by usb or to light up your room using the red and blue onboard LEDs

Sorry, I'm late for the party. But please make it simple for me.
But still, how do I power my NodeMCU 1.0 (ESP-12 E Module) / LoLin NodeMCU. What are current and voltage requirements? Are there any power modules available?
From my research, I have options:
Voltage: 4.5V-10V or 5V or 3.3V
Current: 500mA or 1A

Hi
Vin pin between 4,5 and 10 V MAX  but  5V is better... more safe!
Best regards

That is very helpful @mbfac. The conclusion is

Vin pin expects anything between 4V to 10V,  500mA - 1A. (5V recommended)
MicroUSB input expects: 5V, 500mA

The regulator on the board is a linear regulator. It has to dissipate heat equal to the current multiplied by the voltage difference. For 5V->3.3V, that's not a lot. For 15V->3.3V, that's going to be a whole lot more (almost seven times as much). It's only a small device with no heatsink.
If you're wanting to run off 12+V and you're doing anything that draws any power, you might want to consider using a beefier regulator to drop the voltage first (15->5 for example) or replace the regulator with something beefier or non-linear like a buck converter.

Looking at the datasheet of the power regulator
Vin should be between 4.75V and 10V

Just to say, I had a look at that datasheet and I think you're misinterpreting it. Though it does seem anecdotally that 10V is the limit.


config/v1/types_cluster_operator: Explain that conditions cover components

Builds on #995; consider reviewing that one first.
Some operators have no configured operands (e.g. the bare-metal operator on non-metal platforms, or the image-registry operator when the admins have configured managementState:Removed).  Some operators have many configured operands.  Operators writing ClusterOperator conditions should not limit the conditions to speak about just the operator, or just a particular operand.  Instead, operators should speak about the component as a whole.  Is something about the service that the component provides gone?  If so, Available=False (midnight admin page).  Is something about the service that the component provides not hitting its service-level objectives? If so, Degraded=True (working-hours admin queue).  Doesn't matter if that thing is "the operator is having trouble talking to the API to figure out how the operands are doing" or "the operator is super-happy, and sees that some operand is sad".  That's all stuff that can be distinguished in the reason/message.

Rebased onto master with a3258e83 -> f99f4bb2 now that #995 has landed.

still looks reasonable to me but this seems worthy of a second set of eyes.
/approve

looks great to me, really helps clarify things for baremetal :+1:

@wking Thanks for providing this clarification for the various CO states. Here are some remaining questions specific to the cluster-baremetal-operator.
Disabled state is not mentioned in the API, so that is probably still not a supported state.
The cluster-baremetal-operator (CBO) is responsible for deploying the metal3 pod when the Provisioning CR is present and when the platform is "Baremetal". Let us consider the follwing scenarios:

CBO running on Unsupported platforms - We do not expect the Provisioning CR to be present or for the metal3 pod to be deployed. Would this mean that the ClusterOperator for CBO reports its status as "Available=True"? In this case, the Operand is not running but it is not expected to be running either. (CBO currently uses "Disabled=True" and "Available=True" to indicate this state.)
CBO running on Supported platforms without Provisioning CR - When the Provisioning CR is not present, the operand (metal3 pod) cannot be deployed. Based on the current documentation for the ClusterOperator Api, should CBO report the CO status as "Available=False"? (CBO currently uses Disabled=False, Available=False to indicate this state). But, this not a "page-the-admin" situation because Provisioning CR can be added on Day-2 to then deploy the operand (metal3 pod) and start provisioning Baremetal hosts.

CBO running on Unsupported platforms - We do not expect the Provisioning CR to be present or for the metal3 pod to be deployed. Would this mean that the ClusterOperator for CBO reports its status as "Available=True"? In this case, the Operand is not running but it is not expected to be running either. (CBO currently uses "Disabled=True" and "Available=True" to indicate this state.)

yes.  CBO is doing exactly what it is expected to be doing in this scenario, so it is available=true.  (note: if a CR is created, but CBO is actively ignoring the CR because of the platform type, it would be appropriate for the CBO to include some sort of message in its status conditions that make this clear, like "Available=true Reason=NonMetalPlatform Message=operator is functioning normally, although there is a CR, the CR is ignored because the platform is not metal")

CBO running on Supported platforms without Provisioning CR - When the Provisioning CR is not present, the operand (metal3 pod) cannot be deployed. Based on the current documentation for the ClusterOperator Api, should CBO report the CO status as "Available=False"? (CBO currently uses Disabled=False, Available=False to indicate this state). But, this not a "page-the-admin" situation because Provisioning CR can be added on Day-2 to then deploy the operand (metal3 pod) and start provisioning Baremetal hosts.

I don't see why it would be available=false.  The function that is expected to be provided is being provided.
Available=true, Reason=NoProvisionRequested Message="CBO is running and responding to requests, however no provisioning is currently requested"
It's only when a CR exists but the request can't be fulfilled that available=false would make sense.  That is the point at which the CBO(and its operands) are not providing the functionality it is expected to provide.  (or in other cases where things are going wrong w/ the operator or operand)

CBO running on Unsupported platforms - We do not expect the Provisioning CR to be present or for the metal3 pod to be deployed. Would this mean that the ClusterOperator for CBO reports its status as "Available=True"? In this case, the Operand is not running but it is not expected to be running either. (CBO currently uses "Disabled=True" and "Available=True" to indicate this state.)

yes. CBO is doing exactly what it is expected to be doing in this scenario, so it is available=true. (note: if a CR is created, but CBO is actively ignoring the CR because of the platform type, it would be appropriate for the CBO to include some sort of message in its status conditions that make this clear, like "Available=true Reason=NonMetalPlatform Message=operator is functioning normally, although there is a CR, the CR is ignored because the platform is not metal")

+1. We are also currently setting Disabled=True. Do we stop doing that?

CBO running on Supported platforms without Provisioning CR - When the Provisioning CR is not present, the operand (metal3 pod) cannot be deployed. Based on the current documentation for the ClusterOperator Api, should CBO report the CO status as "Available=False"? (CBO currently uses Disabled=False, Available=False to indicate this state). But, this not a "page-the-admin" situation because Provisioning CR can be added on Day-2 to then deploy the operand (metal3 pod) and start provisioning Baremetal hosts.

I don't see why it would be available=false. The function that is expected to be provided is being provided.
Available=true, Reason=NoProvisionRequested Message="CBO is running and responding to requests, however no provisioning is currently requested"
It's only when a CR exists but the request can't be fulfilled that available=false would make sense. That is the point at which the CBO(and its operands) are not providing the functionality it is expected to provide. (or in other cases where things are going wrong w/ the operator or operand)

+1 for this too. Since the operand wasn't running, we were setting Disabled=False, Available=False. As you pointed out, CBO is behaving exactly as expected, even when the CR is absent. So, we will go ahead and set Available=True with an appropriate Reason and not use the Disabled flag at all.

+1. We are also currently setting Disabled=True. Do we stop doing that?

it is up to you.  It has no official api meaning or implications for upgrades/alerts/etc, so you can set it or not set it as you like.

/lgtm
Thanks for making these updates and answering all my questions.

/hold
@bparees not sure if you were looking for approvals from more team/individuals.

@wking let's give it another day or two in case anyone else cares enough to weigh in, and then i'd say you can remove the hold.

/lgtm
Thanks for making this more clear

/hold cancel


Add attest-blob command

Built on top of https://github.com/sigstore/cosign/pull/1265, thank you mlieberman85!
This is just the signing piece, we will need cosign verify-attest-blob as well which I'll do in a follow-up PR.
Once that's in I'll add in the unit and integration tests!

Codecov Report

Merging #2286 (3173ce7) into main (d720f04) will decrease coverage by 0.32%.
The diff coverage is 0.00%.

:exclamation: Current head 3173ce7 differs from pull request most recent head d530294. Consider uploading reports for the commit d530294 to get more accurate results

@@            Coverage Diff             @@
##             main    #2286      +/-   ##
==========================================
- Coverage   29.02%   28.70%   -0.33%
==========================================
  Files         131      133       +2
  Lines        7872     7960      +88
==========================================
  Hits         2285     2285
- Misses       5275     5363      +88
  Partials      312      312

Impacted Files
Coverage Δ

cmd/cosign/cli/attest_blob.go
0.00% <0.00%> (ø)

cmd/cosign/cli/commands.go
0.00% <0.00%> (ø)

cmd/cosign/cli/options/attestblob.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thanks so much for doing this! Would it be possible to add an e2e test for this functionality like here (hopefully mainly copy&paste if we want a new test leg, or just add a new test case in the existing one (sign/verify) (not worrying about the now overbaked testfile name :) ):
https://github.com/sigstore/cosign/blob/main/.github/workflows/kind-verify-attestation.yaml#L91
I'd be happy to add this myself but might not get to it for day or twoish

Oh, absolutely, that's perfetto!


Clarify Neo4j enterprise edition definition in docs.

This change targets the documentation page for the Neo4j module.

Clarify that the Neo4j test module also supports Neo4j 5 images.
Describe how to use enterprise images without the built-in feature .withEnterpriseEdition().

Minor things: Wording and version maintenance for the Java driver.

Thanks for your contribution, @meistermeier !


Socket Error Seems to be Raised Incorrectly

According to "https://docs.python.org/2/library/socket.html#socket.error" a socket error should be raised with either a string, or a pair (errno, string).
I seem to be getting error: 104 from:
https://github.com/Lukasa/hyper/blob/070dd32ec9caafebe7fa766fe9e73ff85babf07a/hyper/ssl_compat.py#L130
which suggests that the error is being raised with just the error code and therefore the errno property is not available to compare to a constant in the errno module.

Ah, in Python 3 socket.error is an OSError which is why the code is written this way.
If you can write a failing test for Python 2 I'd be happy to add a fix for this.


Inference time increases linearly with batch size

❓ Questions and Help
I tested the batch inference，this is result
batch size      time
1               0.22
2               0.42
4               0.84
6               1.2
8               crash OOM
Why big batchsize doesn't save time?

Hi,
This is a great question, and I've also noticed that in the past.
I believe it might be because some operations in our model are not super efficient for batch mode, but I'm not 100% sure as I have not done an extensive profiling.
@slayton58 do you know by chance a bit more about this?

hi~@kakaluote ，sorry to bother you ,  could you tell me how to  batch inference..I can only infer one by one ....

hi~@kakaluote ，sorry to bother you , could you tell me how to batch inference..I can only infer one by one ....

a little changes in coco_demo's  run_on_opencv_image function

Pass the image list to the function
transform each one image,then to_image_list
trans_im_list = []
for im_one in im_list:
trans_im_one = self.transforms(im_one)
trans_im_list.append(trans_im_one)
image_list = to_image_list(trans_im_list)
image_list = image_list.to(self.device)
after inference,process each one in predictions, same code with orignal in a  for loop
for pred_one in predictions:
pred = pred_one.to(self.cpu_device)
pred = self.post_process(pred, width, height)
pred = self.select_top_predictions(pred)
...
down

you can the code "prediction = predictions[0]"  in compute_prediction.

thanks for reply.
but I think this is actually  tested one by one. Not like the kind of batch_size..NWH*C

i guess the reason of batch inference not effective is custom operations,like nms, roipool
i found this in  nms.cu
// boxes is a N x 5 tensor
at::Tensor nms_cuda(const at::Tensor boxes, float nms_overlap_thresh)
it's one image nms, but N maybe different between images, it looks like can not make batch

i guess the reason of batch inference not effective is custom operations,like nms, roipool
i found this in nms.cu
// boxes is a N x 5 tensor
at::Tensor nms_cuda(const at::Tensor boxes, float nms_overlap_thresh)
it's one image nms, but N maybe different between images, it looks like can not make batch

youdaoli!

In order to know for sure what are the bottlenecks, I'd recommend using Nvidia Visual Profiler to identify the operations which are suboptimal during batching


Can't update to 0.11

OS: Win10 19041
Old enhancer version 0.10.2
What is happening?
run npm i -g notion-enhancer in cmd
but did not get update
What should be happening?
Enhancer version should be update to 0.11
Screenshots (if applicable):

This looks like a cache issue on your side - 0.11.0 is the current version in the npm repository: https://www.npmjs.com/package/notion-enhancer.
However, manual installation is currently bugged (see https://github.com/notion-enhancer/desktop/issues/684) and using notion-repackaged instead is recommended.

ok, Thanks, anyway @dragonwocky


Clean up local and CI Docker builds

With #6 we saw that building cross-platform Docker images can be slow, which is inconvenient for local development and testing. This PR makes build.sh single-platform and documents the change in CONTRIBUTING.md (also making a minor change to the Git clone instructions along the way). The multi-platform build is moved to cross.sh, which is now used by CI in a matrix job so that future tools are easier to add.

Looks good! So locally we can now run it on a single platform but actions still runs both?


fix typo of field name 2. reduce cyclomatic complexity(golint)

Signed-off-by: kelvinji<EMAIL_ADDRESS>

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   17.56%   17.56%
=======================================
  Files          41       41
  Lines        3575     3575
=======================================
  Hits          628      628
  Misses       2918     2918
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f9563...37b48f7. Read the comment docs.

@junxiong Done.


NME Fixes

-Fix for inputLineComponents
-Name change for Light -> Lights
-Fix for popup not appearing

Updated comment to better overview the changes.


Can update data more easier?

I select a collection and execute  there will have the result  :

So, can I modify password directly？ I have tried to change the value of password， but it's value not modified.
I can do it like this

I think it is better to be able to directly modify instead of updateOne.

Hello,
that's definitely in queue. Can you have a look at Easy Edit section, maybe it can be more helpful for you.
Cheers


Update DG

[x] Update architecture diagrams based on changes to clear,  exit commands etc.
[x] Add implementation details for ViewUpcomingEventsCommand
[x] Update use case (Adding events no longer require profile as parameter)
[x] Update instructions for manual testing

Codecov Report
Base: 74.07% // Head: 74.07% // No change to project coverage :thumbsup:

Coverage data is based on head (d9447e2) compared to base (e61c343).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #188   +/-   ##
=========================================
  Coverage     74.07%   74.07%
  Complexity      814      814
=========================================
  Files           109      109
  Lines          2546     2546
  Branches        315      315
=========================================
  Hits           1886     1886
  Misses          567      567
  Partials         93       93

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update to engine 1.13, compose 1.10

Note: these versions aren't released yet, but are expected to be very shortly (going through final RC testing).
notes:

some patches needed removing, others needed updating.
we now need golang 1.7 to build, but there doesn't appear to be an official deb for it so i used an existing PPA
docker now produces separate client and daemon binaries

cc @lool @andrewhsu

Both are released + tagged now, merging this!

Both are released/tagged now, @lool would you mind merging this? then we can see about getting some 1.13 builds into the store :)

Sorry for the delay, am currently travelling – back Friday

Would you be able to push this to the edge channel?


apple m1 ventura onnx import error

protobuf should be removed from direct dependencies for pip install -e .'[testing]' to work painlessly on m1 ventura.
pip install onnx~=1.12.0 => builds from source and requires protobuf compiler
brew install protobuf
pip install protobuf~=3.19.0 onnx~=1.12.0

=> import onnx fails, (maybe because it is built against a different protobuf version from brew)
solutions:

keep onnx 1.12.0

brew install protobuf
pip install onnx~=1.12.0

=> works but installs protobuf 3.20.1
=> remove direct dependency on protobuf from setup.py / update the dependency to protobuf 3.20

update onnx to 1.13.0, but it depends on protobuf<4,>=3.20.2
=> doesnt build from source, universal2 wheel available

I think upgrading onnx should be fine, want to submit a PR?

Thanks, merged!


14 run batches

Per source_id (drager/programma), collect input in a Dataset.
Apply model in batches to the input, concatenate batch output and write to file (torch.save)

NB: merged without review!


Determine how to add a problem specification to the RO-Crate

The Workflow Run RO-Crate infrastructure currently (to the best of our knowledge) does not support an entity that describes the reason for the RO-Crate. For simulation output this would related to the problem definition or problem specification. For a more general RO-Crate, this might be some sort of motivation for its existence.
The head node for an RO-Crate is a "DataSet", but his could possibly have two types if an appropriate type can be identified, but we probably need to remain within the confines of Workflow Run RO-Crate standards.
This question should be asked on the Workflow Run RO-Crate discussion channel.

After some discussion with @ztrautt it seems there are some options for this. There are three fields in CreativeWork that might serve this purpose,

about
isBasedOn

This field would appear in the top level ./ entity and point to another CreativeWork (which is a superset for DataSet), which is the problem definition. The keywords field would then have list of our DefinedTerms to pin down the phase field problem category.


Can't run tryhaskell

[callen@delphi ~/code/tryhaskell]$ env PATH=./.cabal-sandbox/bin:$PATH \
  GHC_PACKAGE_PATH=$(cabal sandbox hc-pkg list | grep '^/.*\.cabal-sandbox') \
  TMPDIR=/tmp/tryhaskell ./dist/build/tryhaskell/tryhaskell
ERROR: mueval startup failure:
mueval-core: Time limit exceeded
 ExitFailure 1

cabal sandbox add-source'd current version of mueval.
Side note: I had to fix a couple of dependency versions before Cabal could find a solution.
Suggest setting aeson >= <IP_ADDRESS> and bytestring >= <IP_ADDRESS> to lend Cabal some guidance.

In the end, the problem was simple — tryhaskell was passing -t 1 to mueval, which was not enough time for mueval to do anything interesting.

Good enough for me.

how  to solve  the  issue    'In the end, the problem was simple — tryhaskell was passing -t 1 to mueval, which was not enough time for mueval to do anything interesting.'

@a820366174: Pass an appropriate timeout to mueval. If you’re trying to run tryhaskell, you can set the MUEVAL_TIMEOUT environment variable, since https://github.com/mietek/tryhaskell/commit/582fce7ff3c6f537e5bd4ac2b25018941075bb8b.

@bitemyapp   I meet  the same problem with  you ,how did you solve you  problem.
mueval -e '1+2'
:
Could not find module âTest.QuickCheckâ
Use -v to see a list of the files searched for.
@chrisdone

@mietek thank you . I  have another  problem. I  install   all package right.
but
mueval -e '1+2'
:
Could not find module â��Test.QuickCheckâ��
Use -v to see a list of the files searched for.
All the requested packages are already installed

@a820366174: tryhaskell still depends on mueval <IP_ADDRESS>, while the first release of mueval that declares the previously-missing dependency on QuickCheck is <IP_ADDRESS>.1. (https://github.com/gwern/mueval/pull/5, https://github.com/gwern/mueval/commit/c41aa40ed63b74c069d1e4e3caa8c8d890cde960) Solution: install the QuickCheck package manually.


Dependabot uses the wrong registry when trying to update a dependency

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
npm
Package manager version
9.3.1
Language version
Node 18
Manifest location and content before the Dependabot update
/package-lock.json
dependabot.yml content
version: 2
registries:
  npm-github:
    type: npm-registry
    url: https://npm.pkg.github.com
    token: ${{secrets.MY_SECRET}}
updates:
  - package-ecosystem: "npm"
    directory: "/"
    schedule:
      interval: "weekly"
    open-pull-requests-limit: 20
    registries:
    - npm-github

Updated dependency
No response
What you expected to see, versus what you actually saw
It looks like dependabot is looking for the most updated version in the correct registry, but once it finds a diff - it looks for it in the wrong registry (the private registry some of our private packages reside on).
You can see the example in the included log.
If it might help - we recently migrated from yarn (and yarn.lock) to npm and package-lock.json respectively. Dependabot worked flawlessly with the same dependencies and configuration with yarn.
Please let me know if more information is required from our side. Thanks!
Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
Logs:
updater | INFO <job_587325717> Checking if npm-check-updates 16.6.2 needs updating
  proxy | 2023/01/24 09:33:59 [124] GET https://registry.npmjs.org:443/npm-check-updates
  proxy | 2023/01/24 09:33:59 [124] 200 https://registry.npmjs.org:443/npm-check-updates
  proxy | 2023/01/24 09:33:59 [126] GET https://registry.npmjs.org:443/npm-check-updates/16.6.3
  proxy | 2023/01/24 09:33:59 [126] 200 https://registry.npmjs.org:443/npm-check-updates/16.6.3
updater | INFO <job_587325717> Latest version is 16.6.3
  proxy | 2023/01/24 09:34:33 [128] GET https://npm.pkg.github.com:443/npm-check-updates
  proxy | 2023/01/24 09:34:33 [128] * authenticating npm registry request (host: npm.pkg.github.com, token auth)
  proxy | 2023/01/24 09:34:33 [128] 404 https://npm.pkg.github.com:443/npm-check-updates
  proxy | 2023/01/24 09:34:33 [130] GET https://npm.pkg.github.com:443/npm-check-updates
  proxy | 2023/01/24 09:34:33 [130] * authenticating npm registry request (host: npm.pkg.github.com, token auth)
  proxy | 2023/01/24 09:34:33 [130] 404 https://npm.pkg.github.com:443/npm-check-updates

npm-check-updates section in package-lock.json:
    "node_modules/npm-check-updates": {
      "version": "16.6.2",
      "resolved": "https://registry.npmjs.org/npm-check-updates/-/npm-check-updates-16.6.2.tgz",
      "integrity": "sha512-J/L90a+NDDWscBQGKIsPKer+qbQEQRJDpK+BPsVZf9YWDN5DCAMicPqRb+Emnxfi8QboiNmvDJWRUFFWRQzDMg==",
      "dev": true,
      "license": "Apache-2.0",
      "dependencies": {
        "chalk": "^5.2.0",
        "cli-table": "^0.3.11",
        "commander": "^9.4.1",
        "fast-memoize": "^2.5.2",
        "find-up": "5.0.0",
        "fp-and-or": "^0.1.3",
        "get-stdin": "^8.0.0",
        "globby": "^11.0.4",
        "hosted-git-info": "^5.1.0",
        "ini": "^3.0.1",
        "json-parse-helpfulerror": "^1.0.3",
        "jsonlines": "^0.1.1",
        "lodash": "^4.17.21",
        "minimatch": "^5.1.2",
        "p-map": "^4.0.0",
        "pacote": "15.0.8",
        "parse-github-url": "^1.0.2",
        "progress": "^2.0.3",
        "prompts-ncu": "^2.5.1",
        "rc-config-loader": "^4.1.1",
        "remote-git-tags": "^3.0.0",
        "rimraf": "^3.0.2",
        "semver": "^7.3.8",
        "semver-utils": "^1.1.4",
        "source-map-support": "^0.5.21",
        "spawn-please": "^2.0.1",
        "untildify": "^4.0.0",
        "update-notifier": "^6.0.2",
        "yaml": "^2.2.0"
      },
      "bin": {
        "ncu": "build/src/bin/cli.js",
        "npm-check-updates": "build/src/bin/cli.js"
      },
      "engines": {
        "node": ">=14.14"
      }
    },

Smallest manifest that reproduces the issue
No response

This is probably related to #6270. Downgrading the lockfile version to 2 using npm i --lockfile-version 2 solved the issue.
I'm closing it but please let me know if more information from our side can help solve the root issue.


Support documentation on swiftpackageindex.com

Got to add this file it seems https://github.com/RevenueCat/purchases-ios/blob/main/.spi.yml
https://swiftpackageindex.com/SwiftPackageIndex/SPIManifest/1.5.1/documentation/spimanifest/commonusecases

added, waiting spi to update before I close this


UI Enhancement: Improve Homepage Layout and Navigation

The current design of the Canvas Editor homepage could be enhanced to improve usability and overall visual appeal. This includes several UI adjustments such as adding a website icon, reorganizing the navigation bar, adjusting colors, and aligning elements consistently.
Add a Favicon (Website Icon):
Include a recognizable icon for the website in the browser tab to improve branding and make it easily identifiable.
Navigation Bar Improvements:
Enhance the color contrast of the navigation bar for better readability.
Adjust button sizes and spacing for a cleaner layout.
Consider adding hover effects for navigation links to improve interactivity.
Button Styling and Alignment:
Style action buttons (like Pencil, Marker, Eraser) for a modern look and ensure they are evenly spaced.
Add tooltips for each button so users can quickly understand each option.
Footer Enhancements:
Improve the footer section design by increasing color contrast and centering the elements.
Add social media icons or other links as relevant to enhance footer functionality.

Go ahead but remember navbar related issue is already assigned to someone else. You can work on homepage layout only

Closed via #1115


Bundle linter in the core

Atom is a Code Editor/IDE for Developers and those developers make mistakes. A base linter provider is something that everyone needs. There was a time when linter API and codebase wasn't shiny enough for it to be made a part of core.
But now we have rebuilt the linter package from the ground and consumed the latest technologies (i.e services) to provide API to linters. It's API and other docs can be found in the linter-plus wiki. It's API is inspired from the awesome autocomplete-plus. The rewrite also features a completely new UI based on suggestions from the AtomLinter Org members and styles from @simurai . Furthermore it accepts anonymous objects as messages allowing the providers to write unit-tests.
It also has a UI to show errors from the current file or project. Which is very important for the Nuclide IDE and project-based languages like FlowJS, HackLang and others. and the Error Objects can contain traces that expand over the lines. It is also extremely easy to style. and It doesn't have to save a temp file to disk to lint files. It also supports lintOnFly and onSave linters.
It even exports it's self service to packages who have daemons in separate processes and want to trigger lint without waiting for a save or change in the buffer. Also in the tooltip and bottom panel are positions that user can click on and be directed to the file:line:col instead of just jumping to the next error.
All these features remove all of the known limitations of old linter package.
Note: It's also backward compatible, so all the linters using the old API will still work.
Here is how it looks like at the moment

There are a lot of packages that have re-invented the wheel and written their own error UIs. If we merge linter in the core, all those packages can consume a similar API and eventually reduce their code complexity.
Things to be done

[ ] Make the code shine bright (We have been working hard on this one)
[ ] Move it to the atom org.

Let us know what you guys think.

cc @atom/feedback

:100: Every other package needs this feature. Almost as much as autocomplete-plus was needed.

So I was the person who initially thought this would be a good idea while the new API was being created.
To see a good part of the story behind this proposal please see these issues:

AtomLinterPlus/linter-plus#1
AtomLinter/linter-plus#47

About two weeks ago we had an internal power struggle at AtomLinter, it was not pretty. I was on my way home and my phone had blown up with notifications coming from GitHub and Gitter. Reading over the notifications and all the weight they carried an idea occurred to me, we're all trying to ensure the best for this project because we all believe it essential to the Atom coding experience. Soon I began to realize something. Knowing where issues exist in your code is essential to coding, therefore it should be an essential part of an editor. Embedding the core linting package in the editor allows us to better serve a wider community of people trying to accomplish the same essential goal, knowing where issues in your code exist.
Looking at the past two issues this conversation were contained in, you will be able to see that there are a decent number of people in support of this integration; people who would be better served by a central way to display errors in the editor.

Being able to detect and display errors in code seems like it is an excellent candidate for inclusion as a part of the core product of Atom, especially given:

This project will be used by nearly everyone using Atom (at least the people Doing It Right)
Linting has the potential to have a significant impact in terms of performance and user experience (both negatively and positively)
Linting has an ecosystem which would significantly benefit from a stable, well-designed and documented API

To be super clear, I'm not saying that the current project is failing in these last two regards! Only that these two items are particularly important to Atom as a product

:+1: Various IDE packages could benefit from this a lot.

Great to see linting being considered for core - I know some people had lags with the current linting packages.

:+1: excellent idea

:+1: /cc @benogle we should discuss this on Thursday :simple_smile:.

Related: https://discuss.atom.io/t/canonical-linter-for-atom/14091

@mnquintana btw, this new linter is fast as hell :smiley:

I feel we should settle the issue of a view API before anything like this is considered. If this is a necessary component, which I agree with @paulcbetts that it is for anyone Doing It Right™, then that means to me that its underpinnings are necessary too. One of the main things this is intended to provide, to my understanding, is UI for linters and related tools. Shouldn't we standardize the basic UI API first?
There are other things that I feel are higher priority than merging anything into core:

Releasing v1.0
Font measurement, CJK and other high Unicode support
Better international support, including keyboards

I feel we should be fixing the things that we all agree are broken before we go about adding to the Core Team's support burden.

@lee-dohm Please beware of making this (linter in core) seem like a mutually exclusive thing when comparing it to the items you mentioned (1.0 / unicode / internationalization, etc.) - or something that can only be done serially, after those you mentioned.
By way of example: this discussion about autocomplete-plus making it into core started about 5-6 months prior to it being included. Getting a rough :+1: from the core team that this (even if not currently the priority) will become a priority is critically important to those doing the work, and it also generally causes that team to seek input from the core team for key design decisions. These are good things in my opinion.
This discussion should happen now, with the knowledge that actual inclusion in core requires a core team member to "internalize" the package(s) to be included in core and potentially modify some portions of them such that they can be supported on an ongoing basis.
A core linter package might not be the  top priority right now, but I think the linter team is looking for a guarded :+1: (or an outright :-1:) from the core team, with no strings attached for the actual schedule for core inclusion.

One of the main things this is intended to provide, to my understanding, is UI for linters and related tools. Shouldn't we standardize the basic UI API first?

Actually, the most important part of linter is not the UI - it's the API it provides, and its ability to dispatch linter requests and collect results (info / warning / error messages). This ensures that whenever a UI API is finalized, a change is required in only one place instead of n places. I don't see the UI portion of this to be a blocking factor.

@joefitzgerald In fact our current API isn't even limited to info, warning, and error messages anymore. You can pass any message of any type to it and it will display/react accordingly. One could use the current API and pass a Result message from a build system, for example.

In fact our current API isn't even limited to info, warning, and error messages anymore. You can pass any message of any type to it and it will display/react accordingly. One could use the current API and pass a Result message from a build system, for example.

That's pretty cool, but it makes me think that linter-plus might be due for a name change at some point, since its use cases are expanding beyond just linting.

@mnquintana Any suggestions for a new name? Could be something to do if we do get inclusion in the core.

[...] it makes me think that linter-plus might be due for a name change at some point, since its use cases are expanding beyond just linting.

Agreed. In the abstract, the packages takes events (save, keystroke, file), matches them with registered things to run, runs things, collects results, and optionally displays the results.

We'll talk about this in our weekly meeting tomorrow. The whole team will be traveling to a conference and/or working on 1.0 next week so we probably won't go in depth on it but hopefully we'll at least come up with a response for this thread.
Also, we plan to work out the ~6month roadmap in mid July. It's good to talk out the details now but by then we should be able to say something decisive in the range from "yes, and the core team will work with you on it" to "we think it belongs in a package" to "keep doing what you're doing and we'll revisit it with you in a few months after XYZ"

OK, short answer is this: we're interested in bundling a linter service in core. :tada::sparkles::+1::100:
Linter-plus seems like a great place to start.
We're most comfortable with a process that looks like the following: at some point in the future someone from the core team will work closely with the linter-plus developers for a few days to work out what might need to be changed, improved, or cut for us to feel comfortable supporting it in core - we'll work out a spec together and then the linter-plus team can polish up the code, and when we agree it's ready we can ship a new major version and put it in core. (This is similar to the process @joefitzgerald et al. went through with @benogle on autocomplete-plus, though likely less hands-on as the linter API surface / codebase is pretty small.)
If you have plans in place to make linter-plus better today, by all means keep on doing what you're doing. We'll revisit this in more detail down the road. I encourage you to keep the scope of the linter service reasonable and resist adding lots of features, because I think we'll be focused on keeping the service simple for consumers, focused on the traditional lint use case, and having UI components with really well-polished design.

Awesome! Thank you for the great news!

Thank's guys, looking forward to have your advices. :clap:

Is this actually happening now?

@steelbrain took sole ownership of the linter, so I'm thinking it seems unlikely. He's in the middle of extracting the whole UI into a separate package.
https://github.com/atom-community/Linter is now https://github.com/steelbrain/linter

I want to make it clear to everyone that the repo has only moved location and nothing else. I still plan on bundling this in core eventually.

I don't want to turn this issue into a big argument. If details are relevant I'm usually on slack or my email is easy to find. I certainly don't want to work with @steelbrain on anything and anyone considering it should be careful what he has access to.

@damieng?

With the release of the Atom IDE set of packages, we've added the desired functionality to Atom core. In addition, the Atom IDE system supports the language server protocol with a standard UI for a number of additional features. Check out the Atom IDE minisite to get started.


运行报错去掉热修复就没问题Execution failed for task ':exmgl:applyRocooDebugPatch'.

Execution failed for task ':exmgl:applyRocooDebugPatch'.

Process 'command 'D:\studiosdk\build-tools\25.0.0\dx.bat'' finished with non-zero exit value 3

就是出现在编译修复版本的时候


Warnings on load with PhantomJS + es5-shim

Repro case in a Gist: https://gist.github.com/mkscrg/62d624a118e2722313fe
Immutable produces some odd warnings when loaded in PhantomJS with es5-shim:
<!doctype html>
<html>
  <head>
    <script src="node_modules/es5-shim/es5-shim.js"></script>
    <script src="node_modules/immutable/dist/immutable.js"></script>
  </head>
  <body></body>
</html>

> phantomjs test.js

iterable.length has been deprecated, use iterable.size or iterable.count(). This warning will become a silent error in a future version. Error:
    at file:///Users/mike/Development/sandbox/phantom-es5shim-immutable-warnings/node_modules/immutable/dist/immutable.js:4602
iterable.length has been deprecated, use iterable.size or iterable.count(). This warning will become a silent error in a future version. Error:
    at file:///Users/mike/Development/sandbox/phantom-es5shim-immutable-warnings/node_modules/immutable/dist/immutable.js:4602
iterable.length has been deprecated, use iterable.size or iterable.count(). This warning will become a silent error in a future version. Error:
    at file:///Users/mike/Development/sandbox/phantom-es5shim-immutable-warnings/node_modules/immutable/dist/immutable.js:4602
iterable.length has been deprecated, use iterable.size or iterable.count(). This warning will become a silent error in a future version. Error:
    at file:///Users/mike/Development/sandbox/phantom-es5shim-immutable-warnings/node_modules/immutable/dist/immutable.js:4602
iterable.length has been deprecated, use iterable.size or iterable.count(). This warning will become a silent error in a future version. Error:
    at file:///Users/mike/Development/sandbox/phantom-es5shim-immutable-warnings/node_modules/immutable/dist/immutable.js:4602
iterable.length has been deprecated, use iterable.size or iterable.count(). This warning will become a silent error in a future version. Error:
    at file:///Users/mike/Development/sandbox/phantom-es5shim-immutable-warnings/node_modules/immutable/dist/immutable.js:4602

(I'm not sure this is actually a problem with immutable!)

This is to be expected. We use console.warn to alert to misuse, and test cases often test that length is in fact reporting this error.
In a future version, this warning will be removed and code that relies on the behavior of using length will  break.

Phantom.js emulates a browser which is why the warns show their way through.

We use console.warn to alert to misuse ...

Phantom.js emulates a browser ...

Understood!
I'm confused by the warnings because immutable.js is the last script to be loaded in that page. It's triggering its own warnings?

I got the same error (with PhantomJS 1.9.7 and es5-shim) and it's not from a test case verifying the error.
The warnings are generated by the following lines in immutable.js:
mixin(KeyedSeq, KeyedIterable.prototype);
mixin(IndexedSeq, IndexedIterable.prototype);
mixin(SetSeq, SetIterable.prototype);
mixin(KeyedCollection, KeyedIterable.prototype);
mixin(IndexedCollection, IndexedIterable.prototype);
mixin(SetCollection, SetIterable.prototype);

and more specifically, the Object.keys(methods) call inside the mixin function.
I'm guessing either es5-shim or PhantomJS uses .length in its Object.keys implementation.

may be just add to immutablejs flag like process.env.DISABLE_IMMUTABLE_WARNING_ABOUT_LENGTH? it is so annoying =(

@mjomble Yes. es5-shim's Object.keys calls isArguments which looks like this.
var isArguments = function isArguments(value) {
    var str = toStr(value);
    var isArgs = str === '[object Arguments]';
    if (!isArgs) {
        isArgs = !isArray(value) &&
          value !== null &&
          typeof value === 'object' &&
          typeof value.length === 'number' &&
          value.length >= 0 &&
          isCallable(value.callee);
    }
    return isArgs;
};

Which it does so it knows if it should array_slice.call on the value before calling $Object.keys.


pickTranslucentDepth Crashes Cesium

Sandcastle example: https://sandcastle.cesium.com/#c=bY9BSwMxEIX/SsipgmTxbLoI9VhQUDzlkmZHGzo7WTKTLVX872ZTUNHO7b33vWEmJGJRc4QjZLVWBEe1AY5lNC/NWzkdmt4kEh8JstNXt44chdb8UByAQH3W8nlLDZtlphgOz9kTY6la7mGSfaUkF/hmCkPzHysb6e0n1tfaspwQekeqzV0cp5RFlYwrYzqBcUIvwN2uhAOICczLYQtqu99VO8RZxWF94RMV0DPX5LUgPsV3cLq3XeX/VTH5oR74MENGf1qw/U2/PZvGGNtVebkpKeHO5z+bvwA
Browser: Chrome / Safari (assumed all)
Operating System: MacOS
Using the pickTranslucentDepth property of Scene crashes Cesium. https://cesium.com/learn/cesiumjs/ref-doc/Scene.html?classFilter=Scene#pickTranslucentDepth
Reproduction has (for me) been simple and consistent. In the sandcastle example all you need to do is zoom in, the error shortly follows:
https://github.com/CesiumGS/cesium/assets/62380558/3f1d85ad-13c0-40c9-b58a-b8861755b536
This is a critical bug as without pickTranslucentDepth enabled I can't use scene.pickPosition on transparent 3D tiles to get an accurate position.
An error occurred while rendering.  Rendering has stopped.
DeveloperError: This object was destroyed, i.e., destroy() was called.
Error
at new DeveloperError (https://sandcastle.cesium.com/CesiumUnminified/Cesium.js:10398:13)
at Imagery.throwOnDestroyed (https://sandcastle.cesium.com/CesiumUnminified/Cesium.js:27463:13)
at TileImagery.freeResources (https://sandcastle.cesium.com/CesiumUnminified/Cesium.js:200765:25)
at GlobeSurfaceTile.freeResources (https://sandcastle.cesium.com/CesiumUnminified/Cesium.js:197114:22)
at QuadtreeTile.freeResources (https://sandcastle.cesium.com/CesiumUnminified/Cesium.js:206323:17)
at TileReplacementQueue.trimTiles (https://sandcastle.cesium.com/CesiumUnminified/Cesium.js:206358:20)
at processTileLoadQueue (https://sandcastle.cesium.com/CesiumUnminified/Cesium.js:207186:37)
at QuadtreePrimitive.endFrame (https://sandcastle.cesium.com/CesiumUnminified/Cesium.js:206648:5)
at Globe.endFrame (https://sandcastle.cesium.com/CesiumUnminified/Cesium.js:207960:21)
at render (https://sandcastle.cesium.com/CesiumUnminified/Cesium.js:227540:19)

Hi @cyber-tomahawk, I am able to reproduce the error.
I can confirm that the error is caused by accessing resources which were destroyed in a previous frame. However, I think this is symptom of an issue processing globe tiles the frame after a pick when pickTranslucentDepth is true.
As another side effect, you can see the imagery flashing around the poles when zooming. That is very atypical behavior.
I'm not sure what the root cause here is yet. What is actually causing the globe tile processing issue will need some further investigation.

@lilleyse Do you have any insight as to why setting pickTranslucentDepth may interfere with globe tile processing?

In the meantime @cyber-tomahawk, would you mind elaborating on the reason pickTranslucentDepth is needed?
There may be possible workarounds, such as using drillPick or turning on pickTranslucentDepth before the needed pick, then off afterwards:
// picking the position of a translucent primitive
viewer.screenSpaceEventHandler.setInputAction(function onLeftClick(movement) {
     scene.pickTranslucentDepth = true;
     const worldPosition = scene.pickPosition(movement.position);
     scene.pickTranslucentDepth = false;
}, Cesium.ScreenSpaceEventType.LEFT_CLICK);

Also reported in https://github.com/CesiumGS/cesium/issues/11495.

Also reported in https://github.com/CesiumGS/cesium/issues/12005.


Create branded thumbnails for static and shelved datasets

It would be nice, at a glance, to be able to tell the status of a dataset without having to look at the tags. Using our brand thumbnail with static or shelved text on it would be a nice enhancement.
e.g. https://utah.maps.arcgis.com/home/item.html?id=110d43fbfacc411b8e74f4d12b63d881

I like this idea. Couple of questions:

My first idea is to make the shelved thumbnail mirror the others. Should we try creating a periodic-table-style shelved icon, or should we go for something different in that area, or do a completely different style of thumbnail altogether?
Static items should be getting their standard category icon. Are we ok to keep that? They're still considered part of the main, curated set of items.

I wonder if we change the color of the border and/or replace the Lo Location with maybe a calendar and the text shelved below? I also think we should append some text to the description that says

This data is marked as Shelved since it has historical relevance but is not the most recent data

This thumbnail seems to be the consensus favorite.


autostart option / service / systemd

If ineo is installed by root, it would be really nice to also install a service (e.g. systemd) to allow instances to get started automatically.
Maybe a system that LXC is using. There each instance can define, if it wants to get started by the service. LXC uses these optional parameter to decide if and how to start a container:
# auto start container
lxc.start.auto = 1
lxc.start.delay = 10
lxc.start.order = 20
lxc.group = prod

When introducing this, i would actually change the way ineo stores metadata information for an instance (.version and .edition) because those are getting more and more. Maybe we can combine all metadata information in a file .ineo within an instance? A big question is, which format to use? ini format or just bash "readable" format?
ini format (needs parser):
[general]
version=1.2.3
edition=community

[start]
auto=1
delay=2
...

bash variables (can be included):
neo4j.version=1.2.3
neo4j.community=community
ineo.start.auto=1
ineo.start.delay=2
...

The service in general would be really nice, because all necessary instances would be available after reboot and the service could also define, when to start and what it needs to do so (e.g. filesystem, firewall, network, ...)

@ogmueller
This would be a nice feature, but perhaps we should make it optional with some switch like -S, otherwise, I think, Ineo could be intrusive and that could be annoying for some users, even using root.


[ZEPPELIN-411] JDK8 support

What is this PR for?
Build, test and run with JDK8
What type of PR is it?
Improvement and Documentation
Todos
N/A
What is the Jira issue?
[ZEPPELIN-411]
How should this be tested?
Travis, test with maven:
export MAVEN_OPTS="-Xmx2g -XX:MaxMetaspaceSize=1024m" && mvn clean verify -Drat.skip=true
Screenshots (if appropriate)
N/A
Questions:

Does the licenses files need update? - No
Is there breaking changes for older versions? - Older versions can run with JDK8
Does this needs documentation? - Documentation updated

Could anybody who has write access merge .travis.yml ?

In case that you encounter conflicts, you have to rebase your changes onto the base branch you start working on. AFAIK, ASF doesn't allow write permission through Github.

And concerning your contribution, we discussed it before and concluded it's too early to move JDK8. If you think it's right time to move on, please start discussion again in dev@ and user@

@jongyoul Should I close ZEPPELIN-411 as "wont fix"?

You don't have to do it because we eventually will move to further JDK version

@jongyoul May be make sense just create PR only for try moving to JDK8 and test this with Travis? Anyway nobody will not merge it to zeppelin without approve.

I'm not sure who think what now, I just let you know the history. If you really want to move JDK8, open discussion and reach a "consensus" with community first. I think moving to JDK8 doesn't have any technical hurdle but needs to do it with Apache way.


Support formatting parser.Identifier values.

The switch statement's type assertion doesn't classify parser.Identifier as a
string so this case needs to be specifically handled. Otherwise, the generator
panics with:
unsupported value type parser.Identifier

Also, parser.Identifier strings shouldn't be quoted.

Thanks for all the patches


Open With in Finder is not working anymore since the last update

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior

Open With in Finder is not working anymore since the last update. It worked before. You could even send files to Caption with Lauchbar and Alfred
Steps to Reproduce (for bugs)

in Finder, secondary click a file and try Open With menu.

Context
Your Environment

Tech
Version

app version
2.01

OS
10.13.2

etc

We removed this on purpose, since it also changed the default program for MKV-files into Caption instead of a video player.

damn, it was a useful feature.
is there a way to work around that?

@gustavomd @vernondegoede with a workaround, it could be done when a CLI is available (see #31). You could use the app Service Automator by following the same kind of instructions I did for my Subify CLI. It would not be plug and play, but it works perfectly.

Thanks Mathieu, that's a very elegant solution.


PHP 7 RealTimeClient connection issue

Hi,
Lib been working really well in PHP5. Gave my app a go on PHP 7 today but couldn't get it to work. As far as I can tell everything is the same, except the PHP version, has anyone else had success running the RealTimeClient in PHP7?
The WebSocket appears to be connecting, but nothing happens after that. Waiting for ->on('hello') or ->on('error') nothing happens. Eventually the react loop seems to stop and the script exits.
Will try to debug further, but not had much luck pinpointing it so far. Throwing this out there in case anyone has any suggestions?

I can't verify this yet, but it could very well be an incompatibility with Devristo/phpws and PHP7. This is the package I have been using for WebSocket functionality, but the package has been sort of unmaintained for a while and has some outstanding issues.
I can look into this more, but I don't plan on fixing this issue if that is the source of the problem, as I plan on rewriting the backend of the package to use Icicle anyway. See #10.

Thanks Stephen, I'll try to take another look with fresh eyes tomorrow.
Hopefully it's something trivial.
Saw #10, sounds interesting!
On 10 Dec 2015 11:58 pm, "Stephen Coakley"<EMAIL_ADDRESS>wrote:

I can't verify this yet, but it could very well be an incompatibility with
Devristo/phpws https://github.com/Devristo/phpws and PHP7. This is the
package I have been using for WebSocket functionality, but the package has
been sort of unmaintained for a while and has some outstanding issues.
I can look into this more, but I don't plan on fixing this issue if that
is the source of the problem, as I plan on rewriting the backend of the
package to use Icicle anyway. See #10
https://github.com/coderstephen/slack-client/issues/10.
—
Reply to this email directly or view it on GitHub
https://github.com/coderstephen/slack-client/issues/14#issuecomment-163790494
.

Yup, looks like an issue in Devristo/phpws. The connection is fine, and messages are received, but as far as I can tell they aren't being decoded properly. None of the "frames" are ever marked as final, and so the messages aren't emitted to slack-client.
Trying to figure out which bit is going wrong, and will open an issue upstream.
This is what I'm seeing with some hacky debugging messages in Devristo\Phpws\Protocol\WebSocketTransportHybi:
string(19) "connector handshake"
string(27) "connector transport connect"
string(10) "handleData"
string(18) "�{"type":"hello"}"
string(27) "creating message from frame"
string(20) "message taking frame"
string(20) "message taking frame"
string(20) "message taking frame"
string(20) "message taking frame"
string(20) "message taking frame"
string(20) "message taking frame"
string(20) "message taking frame"
string(20) "message taking frame"
string(10) "handleData"
string(67) "�A{"type":"presence_change","user":"U0FBK5BJQ","presence":"active"}"
string(20) "message taking frame"
string(20) "message taking frame"
string(20) "message taking frame"
string(20) "message taking frame"
string(20) "message taking frame"

Found the issue, list() does not unpack in PHP7. Opened issue upstream https://github.com/Devristo/phpws/pull/76
If that project is dead, would you consider using a forked version until #10?
(Many thanks for your help and the lib btw!)

Yeah, I'd be willing to use a forked version. It's not like the original project even has any stable releases anyway...

I'll run the tests and then maybe slack-client could use https://github.com/rb-cohen/phpws for now? I suppose I'd need to rename the composer name for packagist and tag a version?
I'll look at removing the Zend\Logger requirements first too.

This should be fixed by running composer update Devristo/phpws to update composer.lock. I don't have time to do that right now.


Better key handling in terminal

The terminal (as presented within the Azure Functions panels) is pretty good given it's in a web page. While I'm not expecting full VT200 emulation some of the key handling is a constant source of annoyance.
Would be it be possible to at least add

Right arrow moving cursor - not printing a character
Tab key auto completion (you capture the Tab key anyway)

Thanks

It sounds like you are referring to the Console in the Azure Portal, which is not part of Kudu. That one is indeed more limited. Can you try using the one in Kudu instead? It supports the two things you list.

@davidebbo  thanks my reason was @christopheranderson  said it WAS kudo!!! :)

yes, happy to use kudo one as only an extra click or 2.

Here is the deal; the Console in the portal uses Portal UI and keyboard logic, but does use a Kudu API on the backend. While the one in Kudu itself is all Kudu, and is a more 'real' command line (though still a far cry from a full ssh shell with terminal emulation).

OK. So defo sounds like a portal issue for the features I want :)
AFAiK portal is not open source so I can't do any more than nag Chris :)


Add functionality to filter based on whether the repo already uses a validator

(Spawned from #1)

We need to decide whether we want to automate this. Blocked by #13


allow call as valid subscope for call scoped rules

naive fix
questions?

does this suffice / result in unwanted side behavior (current tests pass)
add new tests?
update docs?

Checklist

[ ] No CHANGELOG update needed

[ ] No new tests needed

[ ] No documentation update needed

ran local tests comparing results, so going ahead here


Require github notifications api

Watch https://github.com/KnpLabs/php-github-api/pull/238

Temporary workaround by overriding repository in composer.json.
https://github.com/dennisdegreef/lonelypullrequests.com/commit/00e10d960c7eecb9522c49a7714a9c0114c507db

New release https://github.com/KnpLabs/php-github-api/releases/tag/1.4.3 should be integrated into composer.json without workaround.


The method "getConsumerAddressNum" in ServiceCheckUtils doesn't check all registries

[x] I have searched the issues of this repository and believe that this is not a duplicate.
[x] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

Dubbo version: 2.7.12
Operating System version: Mac OS 10.12.1
Java version: 12.0.2

Steps to reproduce this issue
https://github.com/apache/dubbo/blob/149d1f68e53e7809eb5e8bdde6a9d04dfbaca522/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/command/util/ServiceCheckUtils.java#L45-L47
As is said in the statement starting with "// TODO", when the system wants to get the number of consumer service addresses, the number obtained may be inaccurate in the case of multiple registries.
When using Qos(Quality of Service), a tool used to query and control services dynamically in Dubbo, the number will be 0 even if the consumer has some addresses.

Expected Result
The system should be able to handle the situation of multiple registries when getting the number of consumer service addresses.

Similar issues：https://github.com/apache/dubbo/issues/7406


Fix Issue #83: Issue with event firing on unmounted component.

This is a pretty terrible hack which resolves the problem I am seeing in issue #83. React considers this solution to be an anti-pattern. However, I don't see how to change the cleanup code to avoid the problem.

Any idea when this commit is gonna be merged with the base branch?

I emailed the maintainer saying I would be happy to take over and he has never responded.

I died.
It is hacky but looks like some people need it so it's fine for a temp solution at the very least.

Thanks for the PR by the way!

@loktar00 could you release a new version on npm? 😄

@srn done