orchestra/remote.py: raise if ensure_online() fails

see also http://pulpito.ceph.com/kchai-2020-03-25_08:14:01-rados-wip-kefu-testing-2020-03-25-1220-distro-basic-smithi/4888710/

@susebot run deploy

@vasukulkarni @tchaikov this change introduced a regression for us

Your issue was like:
2020-03-25T09:00:47.044 INFO:teuthology.orchestra.remote:Trying to reconnect to host
2020-03-25T09:00:47.045 DEBUG:teuthology.orchestra.connection:{'username': 'ubuntu', 'hostname': 'smithi088.front.sepia.ceph.com', 'timeout': 60}
2020-03-25T09:00:47.046 DEBUG:teuthology.orchestra.remote:[Errno None] Unable to connect to port 22 on <IP_ADDRESS>
2020-03-25T09:00:47.046 ERROR:teuthology.run_tasks:Saw exception from tasks.
Traceback (most recent call last):
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/run_tasks.py", line 89, in run_tasks
    manager.__enter__()
  File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/task/internal/lock_machines.py", line 78, in lock_machines
    os_version, arch)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/lock/ops.py", line 147, in lock_many
    update_nodes(reimaged)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/lock/ops.py", line 33, in update_nodes
    inventory_info = remote.inventory_info
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/remote.py", line 475, in inventory_info
    node['arch'] = self.arch
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/remote.py", line 459, in arch
    self._arch = self.sh('uname -m').strip()
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/remote.py", line 242, in sh
    proc=self.run(**kwargs)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/remote.py", line 198, in run
    r = self._runner(client=self.ssh, name=self.shortname, **kwargs)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/run.py", line 412, in run
    transport = client.get_transport()
AttributeError: 'NoneType' object has no attribute 'get_transport'

Please explain how is this change relevant to the stack trace above?

The reason of the failure was that after an unsuccessful try to reconnect:

There was no checked the return code of a reconnect call .reconnect()

Your issue was like:
2020-03-25T09:00:47.044 INFO:teuthology.orchestra.remote:Trying to reconnect to host
2020-03-25T09:00:47.045 DEBUG:teuthology.orchestra.connection:{'username': 'ubuntu', 'hostname': 'smithi088.front.sepia.ceph.com', 'timeout': 60}
2020-03-25T09:00:47.046 DEBUG:teuthology.orchestra.remote:[Errno None] Unable to connect to port 22 on <IP_ADDRESS>
2020-03-25T09:00:47.046 ERROR:teuthology.run_tasks:Saw exception from tasks.
Traceback (most recent call last):
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/run_tasks.py", line 89, in run_tasks
    manager.__enter__()
  File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/task/internal/lock_machines.py", line 78, in lock_machines
    os_version, arch)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/lock/ops.py", line 147, in lock_many
    update_nodes(reimaged)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/lock/ops.py", line 33, in update_nodes
    inventory_info = remote.inventory_info
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/remote.py", line 475, in inventory_info
    node['arch'] = self.arch
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/remote.py", line 459, in arch
    self._arch = self.sh('uname -m').strip()
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/remote.py", line 242, in sh
    proc=self.run(**kwargs)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/remote.py", line 198, in run
    r = self._runner(client=self.ssh, name=self.shortname, **kwargs)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/orchestra/run.py", line 412, in run
    transport = client.get_transport()
AttributeError: 'NoneType' object has no attribute 'get_transport'

Please explain how is this change relevant to the stack trace above?

i hope the commit message could help:

for better readability, and to have better errors when we fail to connect to remote.

The reason of the failure was that after an unsuccessful try to reconnect:
2020-03-25T09:00:47.046 DEBUG:teuthology.orchestra.remote:[Errno None] Unable to connect to port 22 on <IP_ADDRESS>

There was no checked the return code of a reconnect call .reconnect()

thanks for the insights. but what is your intention here?

The reason of the failure was that after an unsuccessful try to reconnect:
2020-03-25T09:00:47.046 DEBUG:teuthology.orchestra.remote:[Errno None] Unable to connect to port 22 on <IP_ADDRESS>

There was no checked the return code of a reconnect call .reconnect()

thanks for the insights. but what is your intention here?

This change introduced a regression https://tracker.ceph.com/issues/45255

@tchaikov This PR introduced a regression https://tracker.ceph.com/issues/45255

ack. will try to understand the root cause of the issue.

@tchaikov I spend some time for investigation, seems like this patch is really making a new connection all the time which is wrong because it removed the feature of reusing connection and doing the ensure_online always, which is wrong, example:
worker@teuth-kyr:~/src/teuthology_master> python
Python 3.6.10 (default, Jan 16 2020, 09:12:04) [GCC] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from teuthology.orchestra.remote import Remote as r
>>><EMAIL_ADDRESS>>>> t.sh('uptime')
2020-05-08 10:39:18,066.066 INFO:teuthology.orchestra.run.target-kyr-001:> true
2020-05-08 10:39:18,804.804 INFO:teuthology.orchestra.run.target-kyr-001:> uptime
2020-05-08 10:39:18,862.862 INFO:teuthology.orchestra.run.target-kyr-001.stdout: 10:39:18 up 2 min,  0 users,  load average: 0.15, 0.12, 0.04
' 10:39:18 up 2 min,  0 users,  load average: 0.15, 0.12, 0.04\n'
>>> t.sh('uptime')
2020-05-08 10:39:22,298.298 INFO:teuthology.orchestra.run.target-kyr-001:> true
2020-05-08 10:39:22,310.310 INFO:teuthology.orchestra.run.target-kyr-001:> uptime
2020-05-08 10:39:22,366.366 INFO:teuthology.orchestra.run.target-kyr-001.stdout: 10:39:21 up 2 min,  0 users,  load average: 0.13, 0.11, 0.04
' 10:39:21 up 2 min,  0 users,  load average: 0.13, 0.11, 0.04\n'
>>>

As you can see the 'true' is running before each command, it should be only running once or if the connection gott lost.

Originally the usage should be looking like:
python
Python 3.6.10 (default, Jan 16 2020, 09:12:04) [GCC] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from teuthology.orchestra.remote import Remote as r
>>><EMAIL_ADDRESS>>>> t.sh('uptime')
2020-05-08 10:44:38,979.979 INFO:teuthology.orchestra.remote:Trying to reconnect to host
2020-05-08 10:44:39,090.090 INFO:teuthology.orchestra.run.target-kyr-001:> true
2020-05-08 10:44:39,874.874 INFO:teuthology.orchestra.run.target-kyr-001:> uptime
2020-05-08 10:44:39,925.925 INFO:teuthology.orchestra.run.target-kyr-001.stdout: 10:44:39 up 7 min,  0 users,  load average: 0.00, 0.03, 0.01
' 10:44:39 up 7 min,  0 users,  load average: 0.00, 0.03, 0.01\n'
>>> t.sh('uptime')
2020-05-08 10:44:43,069.069 INFO:teuthology.orchestra.run.target-kyr-001:> uptime
2020-05-08 10:44:43,080.080 INFO:teuthology.orchestra.run.target-kyr-001.stdout: 10:44:42 up 7 min,  0 users,  load average: 0.00, 0.03, 0.01
' 10:44:42 up 7 min,  0 users,  load average: 0.00, 0.03, 0.01\n'
>>>

it removed the feature of reusing connection

i don't think "true" is called using a new connection.

it removed the feature of reusing connection

i don't think "true" is called using a new connection.

@tchaikov the "true" is called because 'ensure_online' is added, which call 'is_online' in turn.

@tchaikov and probably you right, there might be no new connection, but the extra run("true") which does not make sense.

#1468


✨[Feature Request]: feature adding Improvement in the Appointment page.

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I think if the appointment section had a border-bottom in every text item so it would have better UI .I would also like to make it responsive.
Please Assign me this issue with the label of GSSOC.
Use Case
had a border-bottom in every text item so it would have better UI of the website .
Benefits
No response
Add ScreenShots
Before:

After:

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

We already have an issue for it #273

Closing as duplicate of #263


helm: allocate resources in the specified namespace

This PR fixes https://github.com/IBM/the-mesh-for-data/issues/25

Can you please separate it to two PRs?

Done. Adding  "wait" will be a part of another PR including changes in blueprint reconciler as well.


add helm configuration for loading the healthcheck bundle

Fixes #2544
Add the healthcheck via an init container, and define the marketplace configuration.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[x] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[ ] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[x] Checked that related changes are merged.

coverage: 47.169% (-0.02%) from 47.187%
when pulling bab46087b5dab9f1be219e9453152f99c9416614 on init-container
into a4ed59fd6cd444336f87105b4c53625cb6b204b6 on main.


Swift 5.5 support

We unintentionally dropped Swift 5.5 (Xcode 13.2) support with the release of the ReducerProtocol due to differences in Swift concurrency and sendability.
While it's possible to work around these issues to get things building (see first commits of #1491), the new protocol does not appear to be usable at all in Swift 5.5: any attempt will quickly lead to cryptic "circular reference" build failures.
We don't plan on supporting Swift 5.5 or even Swift 5.6 for the long term, but we'd welcome continual support in the meantime if anyone from the community is interested!

Going to close this out. It hasn't been an issue brought up by anyone, and we now have Swift 5.8 officially out, so supporting the 3 most recent versions of Swift seems good to us.


fix(aws-lambda): use matched route expression as resource field in gateway compatible input

This PR fixes the problem that the resource field is missing when using the aws-lambda plugin with 3.0's new ATC router.

Summary
The awsgateway_compatible config field in the aws-lambda plugin provides a way to wrap lambda request content to make it looks like AWS API gateway request. One field in this "compatible" request content, named resource, is used to store the resource identifier content. Currently, the value of the resource field equals to ngx.ctx.router_matches.uri, which is the value of the matched route entity's path/path regex.
When using the ATC router, the ngx.ctx.router_matches.uri is not set(and of course, cannot be provided by the new router because it uses expression grammars instead of simple path or path regex), which causes the absence of this resource field in the Lambda's request input.
This PR fixes this issue by checking the presence of ctx.route.expression and taking it as the resource identifier if it exists. If not then the resource identifier value falls back to ctx.router_matches.uri.

Checklist

[ ] The Pull Request has tests
[ ] There's an entry in the CHANGELOG
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

[Implement ...]

Issue reference
Fix FTI-4598

Closing because of lack of activity. We would like to accept this contribution if anyone wishes to pick this back up.


Error: Unable to boot

Hi,
Unfortunately unable to boot.

Develop and test by @hoomanist.

We have this problem and we can not move.
Can you guide and help?
Thanks,

The old script was dropped.
And we wrote another script from the beginning.
Esmaeel was someone who helped a lot.
Thanks to him for the experiments he did on the virtual machine.
The new bash script works, and the ISO file produced.


suggestions

put your suggestions on how to give everyone good education here.

@Mysterious-Entity a suggestion would be to give everyone a nice teacher, not strict ones.


How do I cancel "load" request?

I have a scenario where html video tag is completely removed from DOM but playback (sound) is still running.
Explanation: I'm creating a player on top of Shaka Player, and when I call load and almost immediately after call unload it doesn't work.
My question is, is there a way to cancel the promise returned by load?
itaas.player.ShakaPlayer.prototype.load = function (mediaInfo) {
		if (!mediaInfo)
			throw '[itaas.player.ShakaPlayer] "mediaInfo" is required';

		var source = this.createVideoSource(mediaInfo.url);

		this.player = this.createPlayer();
		this.loadPromise = this.player.load(source);

		this.$media.on('playing', this.onMediaPlaying);
		this.$media.on('pause', this.onMediaPause);
		this.player.addEventListener('bufferingStart', this.onMediaBuffering);

		this.publishLaunchingEvent();
	};

itaas.player.ShakaPlayer.prototype.close = function () {
                 // REJECT "this.loadPromise" SOMEHOW???

		this.onPlayingCallbacks = [];
		this.onLaunchingCallbacks = [];
		this.onPauseCallbacks = [];
		this.onBufferingCallbacks = [];
		this.publishClosingEvent();

		this.$media.off('playing', this.onMediaPlaying);
		this.$media.off('pause', this.onMediaPause);

		if (this.player) {
			this.player.removeEventListener('bufferingStart', this.onMediaBuffering);
			this.player.unload(); //DOESNT WORK IF LOAD IS NOT DONE
		}
	};

In your scenario, since you are removing the video from the DOM, you should call destroy() on the corresponding Player instance just before doing so.  This should stop playback and release the Player's reference to the video element such that the browser can GC the video.


chore: upgrade duckdb to 1.0.0

Upgrade duckdb to 1.0.0 following todays release

@antonycourtney Can you approve and merge if this version bump is ok with you?

Thanks!

No problem! @Y-- I don't see any CICD pipelines that will publish it to npm - are these hidden/private, or does some manual action need to happen?

Sorry for the delay, should have been published now!


Two failure cases of FastDeserializerGenerator

We have seen two FastDeserializer generation failure cases -

Record with Nested Map fields
Record that holds union a branch of which is the record itself

These two issues have been fixed in the following PR:
https://github.com/linkedin/avro-util/pull/46
Can you take a look of this PR to see if you need this fixup?

Hi,
Thank you for pointing this out. I'll try to replicate these issues in our branch and provide fixup similar to yours. We haven't run into such issues so far, probably because none of our production schemas contain above scenarios.

Should we take another look at whether this fast-avro project should remain split between the RTB House and LinkedIn forks?
Since the last time we checked in about a year ago (in a discussion on issue #6), we've continued to invest significantly in this project to improve stability, performance and compatibility. We've got a few people from 3-4 teams contributing various improvements on the side. Since then, we also dropped our proprietary fork and migrated our internal projects to use the open-source one, so I believe the code is getting a good amount of production hardening.
If I understand correctly, the LI fork is a superset of the original on pretty much all dimensions, except for the fact we disabled the code gen cache (for reasons discussed in issue #6). If the cache is a mandatory feature to unify the two communities, I believe we could implement it in a way that's version-aware such that the concerns we cited are addressed.
We could do a video conference if you're interested in syncing up.

Hi,
Sure, we can schedule a conference. In fact lately we don't invest much effort into this project as it fully meets our internal needs, except for occasional bugs.


[HUDI-6588] Fix duplicate fileId on TM failover and recovery

Change Logs
Fixes #8892 where a failover when performing a BucketStreamWrites to MOR tables will not perform rollbacks, causing multiple log files with the same bucketId to be created.
This PR is co-authored by @danny0405.
Impact
Describe any public API or user-facing feature change or any performance impact.
None
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
None
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[X] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Some of the ITs requires cleaning up, need to rename them, will do it tomorrow, submitting the PR first to let the CI run.


Type Error with html 5 canvas

Hello, I get a type error with backbone 1.2 from the cdnjs when rendering a model from within a view...
$(document).ready(function(){
var Box = Backbone.Model.extend({defaults: {x: 0,y: 0, w: 1,h: 1,}
});
var BoxSet = Backbone.Collection.extend({model:Box });
var BoxView= Backbone.View.extend({
render : function() {var model=this.model, ctx=this.options.ctx;}
});
var SetView= Backbone.View.extend({
initialize: function() {this.collection.on("all",this.render,this);},
render: function() {var canvas=this.$el.get(0) , ctx=canvas.getContext("2d");}
});
var c=new BoxSet();
c.add({x:10,y:10,w:100,h:100});
var v=new SetView({el:$("canvas"),collection :c});
v.render();
})

We no longer attach options to the view. You're error is in your #render trying to access the ctx property.

Thanks
Sent from my Sony Xperia™ smartphone
---- Justin Ridgewell wrote ----

We no longer attach options to the view. You're error is in your #render trying to access the ctx property.
—
Reply to this email directly or view it on GitHub.￼


repeated builds are not deterministic

ok the head.modified changes every time (and checksums would also change accoridngly), but I would not expect other things to differ when I compare ttx dumps of font files that were freshly built from the same source file using the same copy of fontc.
It turns out there are some differences in things like GDEF and GPOS (as noted in https://github.com/googlefonts/fontc/pull/644#discussion_r1425331084, this one possible regression introduced with #642), as well as in GSUB (in the FeatureParamsStylisticSet nameIDs).
Also when doing ttx -l to show the table directory, the gvar table seems to have different checksums each time round, even though the length is the same.. But diffing its ttx repesentations gives no differences, so it might be the bytes themselves are serialized differently each time, for some reasons.

forgot to mention - I was able to notice these diffs on repeated builds of GoogleSans.designspace, I didn't try other fonts.

In the past I have seen things like this arise when using collections that provide a non-deterministic iteration order (e.g. hashmaps) so that would be one thing I would look into first. I have done some work in the past in this regard (for instance #561) and it's very possible there are other places where we've missed this.

I think here it's also to do with the fact that we split some tasks in parallel threads that may complete at different times and then we gather their result in some other collection where the order does matter

yes that is totally possible as well.

Good catch. Can we reproduce in a test with our test files? - that should make it easy to fix and keep fixed.

I don't think our test files contain enough kerning pairs to trigger this..

Let's fix this after we land https://github.com/googlefonts/fontc/pull/644. We can add a test file with lots of kerns or a knob to help it trigger with fewer kerns if necessary.

In IM @anthrotype noted "the GPOS vary in size between 106684 bytes and 4384362, an order of magnitude different.."; that's mildly alarming

Reproduction:
$ for i in {0..9}; do rm -rf build/ && cargo run ../googlesans/source/GoogleSans/GoogleSans.designspace && ttx -l build/font.ttf > run$i.ttxl; done
$ grep -H GPOS run?.ttxl
run0.ttxl:    GPOS  0xE96ECCD8   4384230     18876
run1.ttxl:    GPOS  0x45C3186D   4384236     18880
run2.ttxl:    GPOS  0xF17589DD   4384230     18876
run3.ttxl:    GPOS  0xB16C1453    106684     15152
run4.ttxl:    GPOS  0xA721CEE8   4384236     18876
run5.ttxl:    GPOS  0x1E2BB2BF   4384230     18880
run6.ttxl:    GPOS  0xB8849B8C   4384236     18876
run7.ttxl:    GPOS  0xB16C1453    106684     15152
run8.ttxl:    GPOS  0x2B12F05E   4384194     18876
run9.ttxl:    GPOS  0x0E7DA5D9   4384188     18876

https://github.com/googlefonts/fontc/issues/647#issuecomment-1854748451 repro is fixed, new repro:
f=../googlesans/source/GoogleSans/GoogleSans.designspace; \
export SOURCE_DATE_EPOCH=$(date +%s); \
cargo build --release && rm -rf build/ \
&& target/release/fontc $f && cp build/font.ttf build/first.ttf \
&& target/release/fontc $f && cp build/font.ttf build/second.ttf \
&& diff -u <(fonttools ttx -o - -l build/first.ttf | tail -n +2) <(fonttools ttx -o - -l build/second.ttf | tail -n +2)

# GSUB and gvar report same length and offset but different contents

The UINameID diff is fixed, table is now the same length, same offset, but binary different run to run. Steps to reproduce:
f=../googlesans/source/GoogleSans/GoogleSans.designspace; \
export SOURCE_DATE_EPOCH=$(date +%s); \
cargo build --release && rm -rf build/ \
&& target/release/fontc $f && cp build/font.ttf build/first.ttf \
&& target/release/fontc $f && cp build/font.ttf build/second.ttf \
&& diff -u <(fonttools ttx -o - -l build/first.ttf | tail -n +2) <(fonttools ttx -o - -l build/second.ttf | tail -n +2)

To dig further I have a fonttools hack. To view the code see https://github.com/fonttools/fonttools/compare/main...rsheeter:fonttools:main. To use it:
# Example assumes your currend directory is the root of fontc

# onetime setup
$ (cd .. && git clone git@github.com:rsheeter/fonttools.git fonttools_rs)
$ python3 -m venv venv
$ source venv/bin/activate
$ pip install -e ../fonttools_rs/
$ pip install absl-py

# Run the steps to reproduce (start of this comment). Should report GSUB mismatch, checksums differ, same length and offset
$ python ../fonttools_rs/Snippets/compare_table.py build/first.ttf build/second.ttf --noprint_eq
# should print a bunch of things with different offsets, abbreviated example follows
font["GSUB"].table.LookupList.Lookup[1383].SubTable[0].ExtSubTable.SubstLookupRecord[0].offset Value 86398 != 114938
font["GSUB"].table.LookupList.Lookup[1391].SubTable[1].ExtSubTable.SubstLookupRecord[0].offset Value 86838 != 98408
font["GSUB"].table.LookupList.Lookup[1395].SubTable[0].ExtSubTable.ChainSubRuleSet[0].ChainSubRule[2].SubstLookupRecord[0].offset Value 94840 != 113000
font["GSUB"].table.LookupList.Lookup[1395].SubTable[0].ExtSubTable.ChainSubRuleSet[0].ChainSubRule[3].SubstLookupRecord[0].offset Value 94854 != 113014
font["GSUB"].table.LookupList.Lookup[1395].SubTable[0].ExtSubTable.ChainSubRuleSet[1].ChainSubRule[0].SubstLookupRecord[0].offset Value 94784 != 112944
font["GSUB"].table.LookupList.Lookup[1395].SubTable[0].ExtSubTable.ChainSubRuleSet[1].ChainSubRule[1].SubstLookupRecord[0].offset Value 94798 != 112958
font["GSUB"].table.LookupList.Lookup[1408].SubTable[0].ExtSubTable.ChainSubClassSet[1].ChainSubClassRule[22].SubstLookupRecord[0].offset Value 79246 != 87712

Passing to @cmyr to dig into packing

https://github.com/googlefonts/fontations/pull/738 fixed indeterminism in GSUB table, however the gvar table is still changing each time fontc is run on GS (same length, different bytes/checksum) see #656

to clarify my previous comment, only the gvar table bytes are different, its high-level content as dumped with ttx is the same at each re-run.

oh dear.. I can't reproduce locally. No idea what is going on :(

baging my head, still can't repro, but I can say that main also fails with the same issue, not just after https://github.com/googlefonts/fontc/pull/674 so the clippy fixes are unrelated to the GS repeatable build fail.
I just re-run the CI jobs that had previously passed on main after #673 got merged and now they failed:
https://github.com/googlefonts/fontc/actions/runs/7501018748/job/20428708156

This is the shell script I'm using to attempt to reproduce locally what the CI is doing, I tried on both my glinux workstation and on my macbook pro, both are using the latest rust toolchain 1.75.0, I did cargo update, even cargo clean, I still can't reproduce, this script always ends without error and the files are identical.
WTH is going on?!
#!/bin/bash

# clean up
rm -rf first-roman.ttf second-roman.ttf first-italic.ttf second-italic.ttf
rm -rf build

echo "Installing fontc"
(cd fontc && cargo install --path .)
which fontc

echo "Building the first roman"
time fontc ../googlesans/source/GoogleSans/GoogleSans.designspace
mv build/font.ttf ./first-roman.ttf

echo "Building the first italic"
time fontc ../googlesans/source/GoogleSans/GoogleSans-Italic.designspace
mv build/font.ttf ./first-italic.ttf

echo "Building the second roman"
time fontc ../googlesans/source/GoogleSans/GoogleSans.designspace
mv build/font.ttf ./second-roman.ttf

echo "Building the second italic"
time fontc ../googlesans/source/GoogleSans/GoogleSans-Italic.designspace
mv build/font.ttf ./second-italic.ttf

echo "diff {first,second}-roman.ttf"
diff -u <(ttx -l first-roman.ttf | tail -n +2) <(ttx -l second-roman.ttf | tail -n +2)
cmp first-roman.ttf second-roman.ttf

if [ $? -ne 0 ]; then
  echo "error: non repeatable build :("
fi

echo "diff {first,second}-italic.ttf"
diff -u <(ttx -l first-italic.ttf | tail -n +2) <(ttx -l second-italic.ttf | tail -n +2)
cmp first-italic.ttf second-italic.ttf

if [ $? -ne 0 ]; then
  echo "error: non repeatable build :("
  exit 1
else
  echo "success! :)"
  exit 0
fi

i'm going crazy chasing this heisenbug 🤯
In #676 I added a shell script (so that I can try to run the same commands locally and on CI) that builds a font twice and diff the ttx -l and cmp the binary fonts but now I can't seem to reproduce the failure any more on the CI even (locally, I never managed to repro).

and to add insult to injury, my repeatable-builds.sh script is now failing with Oswald, complains the gvar bytes changed!
$ resources/scripts/repeatable-builds.sh ../OswaldFont/sources/Oswald.glyphs
$ which fontc
/usr/local/google/home/clupo/.cargo/bin/fontc
$ fontc ../OswaldFont/sources/Oswald.glyphs -o build/Oswald.ttf
$ fontc ../OswaldFont/sources/Oswald.glyphs -o build/Oswald#1.ttf
$ ttcmp build/Oswald.ttf build/Oswald#1.ttf
build/Oswald.ttf build/Oswald#1.ttf differ: byte 177, line 3
--- /dev/fd/63	2024-01-12 16:03:31.330910933 +0000
+++ /dev/fd/62	2024-01-12 16:03:31.330910933 +0000
@@ -10,7 +10,7 @@
     cmap  0x8D57590D      6212     38860
     fvar  0x8D346992        84     45072
     glyf  0xDEF86C47     43674     45156
-    gvar  0x50120D8C     71016     88832
+    gvar  0xD0128D8C     71016     88832
     head  0x1ACDE23F        54    159848
     hhea  0x08AE0978        36    159904
     hmtx  0xFFDF6CD1      3532    159940
Error: build/Oswald.ttf and build/Oswald#1.ttf are different

But only sometimes.. 😢
$ resources/scripts/repeatable-builds.sh ../OswaldFont/sources/Oswald.glyphs
Success: build/Oswald.ttf and build/Oswald#1.ttf are identical

I can reproduce GS build instability locally as follows:
rm -f *.ttxl threads*.svg && for i in {0..4}; do rm -rf build/ && cargo run ../googlesans/source/GoogleSans/GoogleSans.designspace --emit-timing && cp build/threads.svg ./threads_$i.svg && ttx -l build/font.ttf > run$i.ttxl && grep GPOS *.ttxl; done

Looking at the threads_#.svg for a failure (small GPOS) shows we are running gather BE kerning before we generate it:
0ms (0.00%) Be(GatherBeKerning) run at 7527ms done at 7528ms

195ms (1.81%) Be(KernFragment(0)) run at 7690ms done at 7886ms
...etc...

I managed to isolate the gvar indeterminism, it's the shared tuples array that may end up being sorted differently each time because we are use a HashMap to count how many times a given tuple is shared among glyph tuple variations, and then use sort_unstable_by_key to take the max, but the sorting method does not preserve the order of equal elements (and HashMap also is inherently unsorted so iteration order isn't guaranteed either). If I use IndexMap::sort_by_key the order is stable and builds are reproducible again. I'll send a PR shortly.


Empty main

I have split the repo into 2.8 and 2.9 branches.  This MR is to wipe out the main branch of anything except for the README.md file, which will serve as a pointer to the other branches.

This looks good. Moving forward we might want to add a "develop" branch for unreleased WIP.


40076 update adjust viewport

Details
Fixed Issues
$ https://github.com/Expensify/App/issues/40076
PROPOSAL: https://github.com/Expensify/App/issues/40076#issuecomment-2053463203
Tests

Open any chat
Tap on the composer to open the keyboard
Tap on the emoji keyboard on the native iOS keyboard (If issue is not reproducible change the iOS settings > Screen > Text Size to largest font size)
Verify the native emoji keyboard appears without issues for the chat screen

[x] Verify that no errors appear in the JS console

Offline tests
QA Steps

Open any chat
Tap on the composer to open the keyboard
Tap on the emoji keyboard on the native iOS keyboard (If issue is not reproducible change the iOS settings > Screen > Text Size to largest font size)
Verify the native emoji keyboard appears without issues for the chat screen

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

iOS: mWeb Safari
https://github.com/Expensify/App/assets/11959869/0d1db2fc-11ff-4083-b0cb-5f9680a6ce0b

This change only happens for mWeb/Safari with the condition Browser.isMobileSafari() at this line so will not affect to another flatform

Android: Native

Android: mWeb Chrome

iOS: Native

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.62-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Make this crate into a library / publish binary to crates.io

Hi,
Publishing it will make installing easier and allow developers to embed the crate in their applications.
Just cargo install cce
I am very interested in this project
Thanks

Ah that's a good idea. I'll try this a bit later.

I am going to do the publishing part today, but I am happy to take PRs for making it into a library.

Okay so the binary is now available on crates.io: https://crates.io/crates/cce
I'll edit the title and leave this open if someone wants to make this a library.

I could try refactoring the existing code into a library, seems fairly possible...

Go for it!

@ethanhs Hi, I had a busy week, I am getting into it now...

@AregevDev no worries! I'm pretty busy myself so I probably won't be able to review things until Thursday.


Update readme

 //add ksp generated class path into sourceSets
   android {
       //...
       sourceSets {
           main {
               java.srcDirs += ['build/generated/ksp']
           }
       }

Is redundant, because ksp folder is already included as sources. It contains generated classes for debug and for release build, so I got errors on full build:
e: build/generated/ksp/debug/kotlin/com/bumptech/glide/GeneratedAppGlideModuleImpl.kt: (15, 16): Redeclaration: GeneratedAppGlideModuleImpl
e: build/generated/ksp/debug/kotlin/com/bumptech/glide/GeneratedRequestManagerFactory.kt: (12, 7): Redeclaration: GeneratedRequestManagerFactory

and so on…

ksp {
    arg("GlideModule", "com.bumptech.glide.integration.webp.WebpGlideLibraryModule")
}

Also, I've spent a lot of time to figure out to place this in the root section of the build.gradle (not .kts), not on dependencies block (got example in room repository)

According to https://kotlinlang.org/docs/ksp-quickstart.html#use-your-own-processor-in-a-project you dont't need to modify root build.gradle, it's enough to add versioned plugin to module app/build.gradle and apply ksp processing:
plugins {
    …
    //id 'org.jetbrains.kotlin.kapt'
    id 'com.google.devtools.ksp' version '1.6.10-1.0.2'
}

dependencies {
    …
    implementation "com.github.bumptech.glide:glide:$glide_version"
    //kapt "com.github.bumptech.glide:compiler:$glide_version"
    ksp "com.github.mistletoe5215:glide-ksp:0.0.2"
}

ksp {
    arg("GlideModule", "com.bumptech.glide.integration.webp.WebpGlideLibraryModule")
}

in fact,although the   generated sources are included by the ksp plugin,it still need to void the sourceSets dirs, in order to let the ide recognize them , then u can  get the code by indexing;since the generate task wasn't variant awareness, u may need to clean  project to clear the previous buildType variant artifacts before u begin to run ksp compile task @ArtRoman

       sourceSets {
           main {
               java.srcDirs += ['build/generated/ksp']
           }
       }

Building without this is OK, but IDE is missing generated classes. I'm using glide via wrapper, so I've got all errors in one file.
But I don't know how to handle this the most correct way.

android.applicationVariants.all {
        kotlin {
            sourceSets {
                getByName(name) {
                    kotlin.srcDir("build/generated/ksp/$name/kotlin")
                }
            }
        }
    }

is mentioned in ksp issues and is not working because it's for kts (not groovy), and my module is android library (not android application).

androidComponents.onVariants { variant ->
        kotlin.sourceSets {
            def name = variant.name
            getByName(name) {
                kotlin.srcDir("build/generated/ksp/$name/kotlin")
            }
        }
    }

can't get usable because onVariants has several declarations, one via VariantT, another via Action.

buildTypes.all { variant ->
        sourceSets {
            main.kotlin.srcDirs += "build/generated/ksp/${variant.name}/kotlin"
        }
    }

This looks more correct, but all sources are connected to main, and re-declaration error still occurs.

sourceSets {
        main.kotlin.srcDirs += 'build/generated/ksp/debug/kotlin'
    }

Even with attaching debug sources for every build type, debug build is ok, but release build without project clean will produce redeclaration error. I think it should be handled by AGP plugin or by IDE itself.

yeah，so i just wrote the parent directory path 'build/generated/ksp',sigh...

yeah，so i just wrote the parent directory path 'build/generated/ksp',sigh... @ArtRoman

Yes, and it's also breaks build making debug after release, or release after debug without clean.
And I think it's best solution for now, until AGP or IDE will handle this itself.

What about my second comment? I believe you shouldn't apply plugin to full project according to manual if you have glide only in one module.
This is enought for me (in app/build.gradle):
plugins {
    id 'com.google.devtools.ksp' version '1.6.21-1.0.5'
}

sourceSets {
    main.kotlin.srcDirs += 'build/generated/ksp/'
}

dependencies {
    ksp "io.github.mistletoe5215:glide-ksp:1.0.0"
}

ksp {
    arg("GlideModule", "com.bumptech.glide.integration.webp.WebpGlideLibraryModule")
}

What about my second comment? I believe you shouldn't apply plugin to full project according to manual if you have glide only in one module.
This is enought for me (in app/build.gradle):
plugins {
    id 'com.google.devtools.ksp' version '1.6.21-1.0.5'
}

sourceSets {
    main.kotlin.srcDirs += 'build/generated/ksp/'
}

dependencies {
    ksp "io.github.mistletoe5215:glide-ksp:1.0.0"
}

ksp {
    arg("GlideModule", "com.bumptech.glide.integration.webp.WebpGlideLibraryModule")
}

cuz my project has multi modules,as u know, my router spi  framework also used ksp;if i followed yours ,which means  i 'll need to  declare the plugin  with version '1.6.21-1.0.5'  in my each module.Obviously,it will be more convenient if i declare plugins {     id 'com.google.devtools.ksp' version '1.6.21-1.0.5' apply false } in my root build.gradle and don't apply it, then ,in each module, i just need to add plugins {     id 'com.google.devtools.ksp'  } in  the module's build.gradle  convention scope. @ArtRoman

This issue is just about readme.md as instruction for people who will use this library, this is only recommendations to make it usable in easy way, with less changes. Of course I'm not talking about applying this build settings to the project itself.

ok, i've update it ,appreciate your recommendations ~,QAQ.~ @ArtRoman

Thank you! 👍


Add help and version info to the CLI

Just some basic support for the -h, --help, -v, and --version flags, potentially with some simple information about the available environment-variable-based settings.
Version info should be generated by Goreleaser, similar to how we're doing it here:
https://github.com/charmbracelet/charm/blob/main/main.go#L53-L64
https://github.com/charmbracelet/charm/blob/main/.goreleaser.yml#L14

Closed via #30.


python312Packages.homeassistant-stubs: 2024.5.2 -> 2024.5.3

https://github.com/KapJI/homeassistant-stubs/releases/tag/2024.5.3
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 310817 run on aarch64-linux 1

2 packages built:

python312Packages.homeassistant-stubs
python312Packages.homeassistant-stubs.dist


ValueError: cannot reshape array of size 924786624 into shape (1981161,512)

Getting this error when running this code in the notebook
import pandas as pd
import numpy as np
Load the photo IDs
photo_ids = pd.read_csv("unsplash-dataset/photo_ids.csv")
photo_ids = list(photo_ids['photo_id'])
Load the features vectors
photo_features = np.load("unsplash-dataset/features.npy")

I encountered the same issue. I think it is caused by damaged features.npy.
I reran the cell for downloading files and the error is resolved!


[Feature Request] App icon notification badge for selected tags

Hello,
it would be very nice to have app icon badges for the number of documents with a specific tag (e.g. the inbox tag or a "reminder" tag) to be able to see the number of documents right on the homescreen.

Hey @auer1329,
this could be possible, but to make it update even if the app is not open, it would require background app refresh. That's a larger development, but definitely sounds interesting.


glances: disable tests on aarch64

Description of changes
Test 105 and 107 fail on aarch64 for unknown reasons. See upstream issue on https://github.com/nicolargo/glances/issues/2819 and https://hydra.nixos.org/build/262259380/log
This fixes the build on aarch64.
Also the filesystem and network stats work flawlessly.
Glances doesn't use a standard pytest call, but a custom unittest from setup.py (https://github.com/nicolargo/glances/blob/13e2f73738f633a22277f366fd0411dc560319c4/setup.py#L98-L115). Trying to invoke the test with unittestCheckHook fails with import failures so I opted to just delete the assertion from the test.
Maintainers:
@jonringer @primeos @k0ral
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 318070 run on x86_64-linux 1

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 318070 run on aarch64-linux 1

2 packages built:

glances
glances.dist

Result of nixpkgs-review pr 318070 run on aarch64-darwin 1

2 packages built:

glances
glances.dist

Since this seems to be fixed upstream now, how difficult would it be to cherry-pick the relevant commits instead?

@Luflosi relatively easy. I'll revise this PR probably tomorrow

Since this seems to be fixed upstream now, how difficult would it be to cherry-pick the relevant commits instead?

It seemed this was more work than anticipated. It is not enough to just pull in the upstream patch (see revised PR description), but should work  now without issues on all tested systems.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4110

Thanks @gador


Installer starts after upgrade to <IP_ADDRESS>

I have upgraded from version <IP_ADDRESS> to <IP_ADDRESS>. After that I wanted to log in as admin. Instead of the admin page, the Shopware installer started. What happened there? I do not want to do a reinstallation. I then ran the installer with a second new database. After that everything was ok again and the old database was active. But when I recreated the container, the installer was there again.

Can you set SHOPWARE_SKIP_WEBINSTALLER=1 as environment variable?

See also README. I don't recommend using this Docker image anymore for Shopware 6.5.
You should checkout https://github.com/FriendsOfShopware/production-docker and create your own Docker image from your project

Can you set SHOPWARE_SKIP_WEBINSTALLER=1 as environment variable?

Ok, that worked. Thank you.

See also README. I don't recommend using this Docker image anymore for Shopware 6.5. You should checkout https://github.com/FriendsOfShopware/production-docker and create your own Docker image from your project

Looks complicated. Can I migrate my current installation?


Hui

1.1.3

This looks unintentional?

I was thinking about pulling request a wrong spelt word.
It's a mistake I pulled my branch to you.
Hope not bother


Added msgs for Optimize

Related to https://github.com/prisma/docs/pull/6020/files

@jharrell, adding you as a reviewer, re: these promos :) Just need an approval to merge, this is already on /docs :)


0 is plural in english

+1 came here to report this. In case it's not clear, OP is talking about the %!D %!H %!M etc. formatters.


error while setting Sharing settings

@megoth as discussed, this is what the dev tools show for the failure to make this doc public.

Hmm, looks like an CORS error while fetching the svg icon for the globe (which you tried to drag and drop onto the read category) - strange, haven't seen that before.
Thanks for creating an issue ^_^

yeah it's weird because the globe is actually showing


GitHub (Local) hides GitHub identity provider

I have built and deploy this plugin under Keycloak 9.0.3.
When I try to add a new identity provider, I only see "GitHub (Local)", the "GitHub" identify provider is not in the list.
Could it be because LocalGitHubIdentityProviderFactory.getId() returns "github"? should that be changed to return "github-enterprise" or "github-local" or something like that.
Another thing, should LocalGitHubIdentityProviderFactory.getName() return "GitHub (Enterprise)" instead of "Git (Local)"?

These are excellent suggestions.  It's been awhile since I've looked at the GitHub integration, but I recall that value returned by "getId()" to be important on the Apicurio side of things.  If that is changed in the extension then it might not be usable from Apicurio Studio.  If you want to support GH Enterprise and GitHub Online simultaneously in the same Apicurio Studio server, then we will need to make some additional changes in the studio repo.

That said - the name change we can probably make immediately. :)

you are right, I tried switch the id and it causes issue in creating this identity provider since it requires theme/base/admin/resources/partials/realm-identity-provider-*.html in the keycloak installation dir. I did successfully workaround that, but it requires more steps during the installation procedure... not sure if it is worth it, so will close this ticket. I think a better thing is to update the GitHubIdentityProvider in the keycloak code base to support our desired functionality.

FYI: if the provider id is different, the redirect URI is also different (since it contains the provider id in it), so then the GitHub OAuth App setting for "Authorization callback URL" would need to changed.


Switch to api service to provided.al2 Lambda runtime

This is completed. Skipped over al2 and went to al2023


impossible to save : float division by zero

Hi,
Does not want to record labels. I have tried with several versions, nothing works.
How to fix ?
I only have two very large images. High-precision satellite photo (15kX15k). I have to get more than 1000 labels per photo
Img: C:\Users\wkn\Documents\IA\ortoIA\images\png5ca3a3d5e5635f000690af6b.png -> Its txt: C:\Users\wkn\Documents\IA\ortoIA\labels\png5ca3a3d5e5635f000690af6b.txt
Traceback (most recent call last):
  File "<string>", line 1291, in saveFile
  File "<string>", line 1320, in _saveFile
  File "<string>", line 808, in saveLabels
  File "Z:\home\darrenl\tmp\labelImg\build-tools\build\labelImg\out00-PYZ.pyz\libs.labelFile", line 83, in saveYoloFormat
  File "Z:\home\darrenl\tmp\labelImg\build-tools\build\labelImg\out00-PYZ.pyz\libs.yolo_io", line 64, in save
  File "Z:\home\darrenl\tmp\labelImg\build-tools\build\labelImg\out00-PYZ.pyz\libs.yolo_io", line 36, in BndBox2YoloLine
ZeroDivisionError: float division by zero

Thx !

Windows 10 64
3.7:

can you show your xml file?because its mean your size is zero

i faced the same problem, this happens due to transparency in the some images, i dnt know what kind of transparency is this,......but it can be solved by opening the image with opencv and saving it again, it worked for me.
i wrote this python file :--
import cv2
import os
def loadImages(path = "."):
return [os.path.join(path, f) for f in os.listdir(path) if f.endswith('.jpg')]

filenames = loadImages()
images = []
for file in filenames:
images.append(cv2.imread(file, cv2.IMREAD_UNCHANGED))
num = 0
for image in images:
cv2.imwrite(str(num)+".jpg",image)
num += 1
it will open every file in the directory and save it again!!

What image format are you labelling? I had the same error when I was labelling .png images. It only worked for me with .jpg images.


Rename emit('created') to 'site-created'

hydroserver2/hydroserver#219
I think the problem is likely a naming conflict with Vue's lifecycle hooks. 'Created' is a lifecycle hook, so I'm thinking having an event emit with the same name is causing unexpected behavior. The 'loadData()' function in the Sites.vue parent component never gets called despite the child component emiting 'created'. This change renames the emited event to 'site-created'.

After deploying to dev.hydroserver.org, this change did indeed fix the problem.


Add CategoryRefs to Link

Links, just like nodes, should support multiple categories.

Thanks for your contribution. I merged your pull request and released a new version (OpenSoftware.DgmlBuilder 2.1.0) on nunet.org


Train_with_pruning.py tinystories/prepare_char.py tinystories/prepare_tiktoken.py

Train_with_pruning.py: Train.py with pruning. change pruning_p to change pruning rate.
tinystories/prepare_char.py: prepare the data of tinystorise @ char level. Chage number to Chage data_url
tinystories/prepare_tiktoken.py: prepare tinystories with tiktoken (from OpenAI). Chage number to Chage data_url

Has changed

chages has been done

After running the code, came across an error related to the configurator.py file, seems we'll have to remove the dependency on configurator.py before we add additional arguments.
Created an issue for this, and will attempt to finish a pull request tomorrow with the changes (and sooner the better):
https://github.com/chipGPT/nanoGPT/issues/20
Afterwards adding options for pruning, tensorboard options, etc. will be unblocked.

Update, as mentioned the last comment, the configurator.py file doesn't get along with argparse at all, creating #21 that refactors the original procedural train.py into a Trainer class and handles cli configuration settings via argparse.
Now it is much much easier to add features.
Feel free to add the pruning features now within the parse_args function, and the corresponding sections of our newly parameterized  train.py

@777yifei Thanks for your patience! : D
The repo is finally ready for additional train.py parameters to be added in.
Let's work together to bring these changes into the repo, I'll probaby give a shot tonight, and will share questions tomorrow.


Http server fixes

Some follow up fixes/improvements from @davidvgalbraith comments in pr #224.
All these pertain to the http_server adapter. Here's the skinny

Added support for -rootPath option
Fix improperly scoped format variable
Use Promise.try instead of a million try/catch blocks.
Add link to http_server documentation, in adapter index

Huh, well I thought I +1ed this one before lunch but must have been hallucinating again. +1


TinyXML-2 Library Licensing

Hello!
I am working on a game engine for my future game projects and am gradually getting closer to developing the first demo scene. And so I asked myself the question of licensing the libraries that I used to implement my game engine. The engine is developed exclusively for their own needs and only games made on it will be distributed. What conditions must be met in order not to violate the license to use this library?
To begin with, I indicated the use of this library in the user manual and in the future it will be so in all manuals. If you can provide a vector logo for the library, I will add it to the user manual. I also placed a copy of your license in the "documents / licenses" directory and would like to clarify if I took the correct text. If the text is different, please give the correct one.
Below I am attaching the license file and user manual for the future demo scene (one page is incomplete).
TinyXML-2 License.txt
manual EN.pdf
Sincerely, Daniil Petrov.

On the page with logos on the texts of the titles, added hyperlinks to the sites.
manual EN.pdf


SystemC 2.3.3 support

I am interested in using bsmedit with SystemC 2.3.3.
What changes were made to SystemC 2.3.1 to support bsmedit?

Hi wpeet,
Basically you will need to:

add everything in folder "systemc/src/sysc/bsm"
update files in "systemc/src/sysc/communication/" (e.g., sc_signal.h) (you can search "bsm_")

Thank you for your response.


refactor: make opening book seed randomized by default

consistent with cutechess
fix https://github.com/Disservin/fast-chess/issues/572

As part of this PR I would suggest to adjust the change from https://github.com/Disservin/fast-chess/pull/551, and make fast-chess always behave the same as far as the inputs are concerned, whether in cute mode or not. For example, let the order be random by default, but throw an error when -order is not specified in cute mode. This can be achieved by setting a boolean read_order_success in cute mode in cli.cpp.

As part of this PR I would suggest to adjust the change from #551, and make fast-chess always behave the same as far as the inputs are concerned, whether in cute mode or not. For example, let the order be random by default, but throw an error when -order is not specified in cute mode. This can be achieved by setting a boolean read_order_success in cute mode in cli.cpp.

I see, for this id like to make it a seperate pr

i don't like this.. id prefer a deterministic tournament config/setup unless the user actively specifies it differently

i don't like this.. id prefer a deterministic tournament config/setup unless the user actively specifies it differently

perhaps order=sequential as default? because i agree with robert that if someone specifies order=random they typically want it to be non-deterministic and already have the seed randomized

made it so that the default order is sequential so default behavior will still be deterministic

i don't like this.. id prefer a deterministic tournament config/setup unless the user actively specifies it differently

Would you be happy to have sequential order as default then? Would be consistent with cute chess and do what you want.
At present cute chess and fast chess behave fundamentally differently for the same input options. That is not ideal.

i really think you should consider adding this, rn the only way to get a randomized seed in fastchess is through the use of -randomseed , but this isnt available in native cutechess, so tools who will use fastchess' cutechess build will still have to revise their command builder. this defeats the purpose of the cutechess build

@Disservin so whats the status with this pr? do i just close it or is there something i need to fix?


Xcode/VsCode build for iOS is too much slow

Can we reopen this issue: https://github.com/flutter/flutter/issues/37582
I'm facing same in latest version. After removing firestore it's perfectly fine.

@thapli9A
The issue you linked is very old so we recommend not to open that.
Check this issue and see if it helps in your case.


getInt/getFloat Syntax help

i cant get convars working in my code, is there something i have to do with it else?
int crosshairR = interfaces->cvar->findVar("cl_crosshaircolor_r");
error on text "interfaces" =
a value of type "ConVar *" cannot be used to initialize an entity of type "int"
so im looking for how to initialize it.
Is " static_cast " helpful here? if so how do i use it?
Thank you in advance anyone :)
//
(even if i use " auto " on crosshairR not int i will get the same error down the line later in code that tries to int it like here
interfaces->surface->setDrawColor(crosshairR, crosshairG, crosshairB, 255);
it wants int but gets ConVar and freaks out.
//
I can change the value directly with ->setValue but im having trouble when trying to read it, and set a int/bool/whatever with a ConVar.

https://github.com/danielkrupinski/Osiris/blob/master/Osiris/SDK/ConVar.h

ftfy

I saw that get func, but i must be missing something simple then aswell, because this code for example does not work, maybe my syntax is wrong?
                                                                                ////////
const float viewmodel_offset_x   = interfaces->cvar->findVar("viewmodel_offset_x")->getFloat;
                                               //// error here //////
if (viewmodel_x_default != viewmodel_offset_x) { viewmodel_x_default->setValue(viewmodel_offset_x); };

expression must have a pointer type
Prob im just doing something simple wrong as always, but this is how i learn xd
/////////
I have made stuff with the limited knowledge i have, check it out if you want to :)
https://gist.github.com/RyDeem/3c77986be70802742b02d9e51b0537d1
(its a Viewmodel changer XYZ GUI interface with cl_righthand integration as well)

interfaces.cvar->findVar();

interfaces.cvar->findVar();

Yes but that just returns the ConVar raw, its is still
" ConVar .function name. value "
not
" float/int/bool/ .function name. value "
Or maybe you are commenting on ConVar in general.

interfaces.cvar->findVar()->getValue();

interfaces.cvar->findVar()->getValue(); = Convar has no member getValue();
and
interfaces.cvar->findVar()->getfloat();   = expression must have a pointer type error
there also is an arrow between interfaces->cvar as well?

https://github.com/danielkrupinski/Osiris/blob/00b4a657d547e6a3df2734bd2107c1297ed4db8f/Osiris/Hacks/Esp.cpp#L195

static auto gameType{ interfaces->cvar->findVar("game_type") };
static auto survivalMaxHealth{ interfaces->cvar->findVar("sv_dz_player_max_health") };
        const auto maxHealth{ (std::max)((gameType->getInt() == 6 ? survivalMaxHealth->getInt() : 100), entity->health()) };

More than enough info

i seem 2 have found the issue.
I thought i can add the getInt() to the
static auto survivalMaxHealth{ interfaces->cvar->findVar("sv_dz_player_max_health") };
like
static auto survivalMaxHealth{ interfaces->cvar->findVar("sv_dz_player_max_health")->getInt };
but i gotta do it next step down the line.
Thank you for your input kind sirs.


chore(deps): update module github.com/gruntwork-io/terratest to v0.41.2

This PR contains the following updates:

Package
Type
Update
Change

github.com/gruntwork-io/terratest
require
patch
v0.41.0 -> v0.41.2

Release Notes

gruntwork-io/terratest
v0.41.2
Compare Source
What's Changed

support buildkit for dockcer-compose by @hongil0316 in https://github.com/gruntwork-io/terratest/pull/1201

Full Changelog: https://github.com/gruntwork-io/terratest/compare/v0.41.01...v0.41.2

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.0.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


flux-local action failure: Could not open requirements file for requirements.txt

The actions in https://github.com/allenporter/flux-local-action fail trying to pull the requirements they need from the code owners repo rather than its own repo.
ERROR: Could not open requirements file: [Errno 2] No such file or directory: '/home/runner/work/home-ops/home-ops/pr/requirements.txt'
Error: Process completed with exit code 1.

This is fixed with https://github.com/allenporter/flux-local-action/commit/92ca917951836265f9a20d71fea94d6e8ff8388b


AMBARI-23680 Installing hive with "New mysql database" fails

What changes were proposed in this pull request?
The whole problem originates from removing mysql-java-connector package install from hive install.
Hive already has a mechanism for downloading drivers from the Ambari Server. Added this to the hive.py for the default path.
I think the 'ambari-server setup --jdbc....' did not work properly. Added a symlink for the installed custom driver. The symlink is named as described in default_connectors_map. This is how the rest of the system is looking for it.
How was this patch tested?
unit tests, manual testing
Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1999/
Test FAILed.
Test FAILured.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2001/
Test PASSed.

@swagle @miklosgergely @aonishuk please review this


Add CSV support

Add support for reading CSV files

Seems to be working in the WIP branch, got to solve some CVE issues before I'll be able to run the integration tests for the specific sources.


Error starting server

yarn run v1.22.22
$ medusa develop
info:    Watching filesystem to reload dev server on file change
redisUrl not found. A fake redis instance will be used.
warn:    Local Event Bus installed. This is not recommended for production.
warn:    No default locking provider explicit defined. Using "in-memory" as default.
warn:    Failed to load countries, skipping loader. Original error:
warn:    Failed to load currencies, skipping loader. Original error:
error:   Could not resolve module: Payment. Error: Loaders for module Payment failed:
error:   Error starting server
Error: Loaders for module Payment failed:

Sorry, didn't run the migration. closed


Skip the provided block at fetch method if write nil value.

This PR is to skip the provided block in fetch method if write nil value.
The behavior same as ActiveSupport::Cache::MemoryStore.
cache.write('short-key', nil)
result = cache.fetch('short-key') { 'skip this block' } # => expect nil

Coverage remained the same at 100.0% when pulling dd07e18b546d817cd2b747d993a5c693bf1c500c on satoruk:feature/skip_write_in_fetch_if_exist into 654fc11e6772bd07a0d5a9d8338e56cd7f0f2f54 on sorentwo:master.

Coverage remained the same at 100.0% when pulling e6aeccce85eb2d10da7d1c49f20dc94f876e8625 on satoruk:feature/skip_write_in_fetch_if_exist into 654fc11e6772bd07a0d5a9d8338e56cd7f0f2f54 on sorentwo:master.

This difference is intentional, as noted in the README:

Like other ActiveSupport::Cache implementations it is possible to cache nil as a value. However, the fetch methods treat nil values as a cache miss and re-generate/re-cache the value. Caching nil isn't recommended.

Oops, Sorry 😭


Why Inline_Button doesn't work in channel?

hi!
there is a problem in inline button when I send it to a channel via my bot.
when i click that button through my channel i get this error:

PHP Catchable fatal error:  Argument 1 passed to Longman\TelegramBot\DB::insertUser() must be an instance of Longman\TelegramBot\Entities\User, null given, called in /home/mybotpro/public_html/FumTweet/vendor/longman/telegram-bot/src/DB.php on line 723 and defined in /home/mybotpro/public_html/FumTweet/vendor/longman/telegram-bot/src/DB.php on line 335

this is my callbackquerycommand file:
CallbackqueryCommand.php.zip
this is my DB.php file:
DB.php.zip
I'm really looking forward a kind friend to help me!

Please just put your code into the issue directly, not as zip files.
Also, are you adding custom code to your DB.php?
You should never touch core files, as an update will delete all your changes!
The error shows that something is wrong in your DB.php, so i suggest you use the latest version of the bot and try again.

thanks @noplanman !
I fixed the problem by just updating DB.php
but i got a new problem!
I'm using a shared hosting for my bot. and it has limitation of 60 requests per second.
i created a rating ability for my channel posts. the channel has 8k members.
when i launched this new ability, the inline buttons were too slow, and all actions got lag.
and I don't know why! What can it be? and how can i solve this problem?
sorry for my poor English !

Maybe your server is too slow. Can you check to see if your server resources are enough to handle all the requests?


Transaction aggregation

Work in progress PR. Transaction aggregation / building a block.

Codecov Report

Merging #56 (6514703) into main (ec89dbc) will decrease coverage by 2.79%.
The diff coverage is 2.32%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   60.77%   57.98%   -2.80%
==========================================
  Files          14       14
  Lines         872      914      +42
==========================================
  Hits          530      530
- Misses        280      321      +41
- Partials       62       63       +1

Impacted Files
Coverage Δ

node/node.go
41.88% <2.32%> (-23.46%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec89dbc...6514703. Read the comment docs.

Replaced by #82.


Leetcode: 871. Minimum No. of Refueling Stops (Hard-DP)

A car travels from a starting position to a destination which is target miles east of the starting position.
Along the way, there are gas stations.  Each station[i] represents a gas station that is station[i][0] miles east of the starting position, and has station[i][1] liters of gas.
The car starts with an infinite tank of gas, which initially has startFuel liters of fuel in it.  It uses 1 liter of gas per 1 mile that it drives.
When the car reaches a gas station, it may stop and refuel, transferring all the gas from the station into the car.
What is the least number of refueling stops the car must make in order to reach its destination?  If it cannot reach the destination, return -1.
Note that if the car reaches a gas station with 0 fuel left, the car can still refuel there.  If the car reaches the destination with 0 fuel left, it is still considered to have arrived.
Input: target = 1, startFuel = 1, stations = []
Output: 0
Problem link: https://leetcode.com/problems/minimum-number-of-refueling-stops/
Programming language
Java
As a participant of LGMSOC I have created this issue and would like to work on it.
@Ayush7614 Kindly assign me this issue.

I would like to add  C++ solution to this problem as a participant of LGM SOC 21. @Ayush7614  please assign me this issue.

@Anuradha0501 please complete ur assigned issues

@Amit366  @Ayush7614 Atleast assign me in any one issue under LGMSOC21
I want to do this in c or cpp

please assign me the above problem statement in Python


fr.locale

Part translated fr.locale, should continue if OK for you !
This is my first time translating CodeCombat on GitHub, please can y ou tell me if the procedure is ok, so i should continue with the reste of the file ?
Translated part of the home page, beginning of the file.

CLA signed

Thank you, you can merge ! i'll cotinue futher on


haskellPackages.lsp-client: unmark broken

Description of changes
I maintain this package upstream. I've verified that it is no longer broken on x86_64 and aarch64 linux and darwin.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Great, thanks.
You might consider entering yourself as a maintainer for the Haskell packages you care about in our main.yaml file.

Cherry picked onto haskell-updates as a034c0b57a59e9379f67e78c09596d42f2eaa176.


Updating OneSignal Partner Source Documentation

Proposed changes

Updating events and properties in the OneSignal source doc

Merge timing

ASAP once approved

@rchinn-segment I'm currently seeing object cloud source for this source. I believe this is because the last time this page was built the integration was hidden.

Running make catalog corrects for this locally, but just want to ensure this is corrected when merged and deployed

@tcgilbert - Thanks for calling this out. We'll run make catalog before deploying this along with the rest of the docs


ImportError for huggingface_hub.errors

Yesterday I have encountered the following error:
ImportError: cannot import name 'LocalEntryNotFoundError' from 'huggingface_hub.errors' (/usr/local/lib/python3.10/dist-packages/huggingface_hub/errors.py)
Before, I was able to run it smoothly but now I cannot load pipeline components:

Please find attached the gist here
Could there be any particular change causing this?

After speaking with huggingface_hub contributors it turned out that huggingface_hub needs to be the newest version + diffusers==0.29.0. I think, the file requirements.txt needs to be updated because it was messing up.


Facet selections remain applied after closing Facet when rows have been deleted

Describe the bug
Under some circumstances closing a Facet does not refresh the list of rows displayed in the data table
To Reproduce
Steps to reproduce the behavior:

Create a text facet and select a value to get a subset of rows
Remove the rows from the project ("All->Edit Rows->Remove all matching rows")
See no rows now appear (expected)
Close the facet by clicking the 'cross' at the top left of the facet panel
Note that still no rows appear even though you've removed the facet and there are still rows in the project

Current Results
The data  table was not refreshed to show the remaining rows in the project after the facet was removed
Expected behavior
The data table should refresh to show all the rows remaining the project
Screenshots

remove the filtered rows - note you can see in the facet there is still one row remaining

Close the facet with the cross at the top left - still no rows display

OpenRefine (please complete the following information):

3.1 Beta

Datasets
If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our mailing list
Additional context
Add any other context about the problem here.

@ostephens I can't reproduce this at the moment - do you have any errors in the JS console maybe? Could that be browser-dependent?

No JS Console errors. Happens on both Safari and Chrome. Not tested on Ff yet - can do later.

Also occurs using FF

@ostephens This is resolved somehow in 3.1 trunk... I just followed your exact steps and things are fine in FF with Trunk... however you are correct that in 3.1 Beta release, the problem you observed can be reproduced by me as well.  Good news is that this is fixed in 3.1 trunk... but leaving it to you guys to figure out why and how. :-)

Ah indeed! Sorry I was trying from master, not from 3.1-beta. I suspect this was solved by the other fix about facets (empty facet choices disappearing). Let's close this then?

Ah - sorry - should have tested from master


[Bug]:CSS Properties of Google Translate Bar are not being reflected properly

Bug:-
In the navbar below the translate searchbar "Powered By" is written whose sense is incomplete without "Powered by Google".
Upon inspecting I found that CSS has been written to hide it, "Google Translate" img is hidden by that but it is not being reflected on "Powered By", it is being overridden by some other properties.
I have fixed that issue.
Screenshots

Expected behavior
The "Powered By" Text should also be removed.

Can I work on this issue?


spirv-fuzz: Add support for OpConvert to TransformationEquationInstruction

Part of #3440.

(2) is not technically required for this transformation to work but I've recalled your comment (https://github.com/KhronosGroup/SPIRV-Tools/pull/3447#discussion_r444645306) from the previous review. We might need more than one fresh id if, for example, we are inserting OpConvertSToF instruction and there is no suitable result type in the module. In that case, we might need to create a new OpTypeFloat instruction and, possibly, an OpTypeVector of float components.
The return type of other instructions, supported by this transformation (e.g. OpIAdd etc), is equal to the return type of their operands which implies that it always exists in the module.

Added a PR for fuzzerutil::FindOrCreate* #3479.

Converted to draft since some functionality needs adjustment.

@Vasniktel Bots failing due to:
/tmpfs/src/github/SPIRV-Tools/source/fuzz/fact_manager.cpp:750:76: error: unused parameter 'dd2' [-Werror,-Wunused-parameter]
    const protobufs::DataDescriptor& dd1, const protobufs::DataDescriptor& dd2,


Inferring and typeof at the same time loses inference

Bug Report
If you both infer a value from usage and use a typeof, it loses it's inference capability
🔎 Search Terms
infer, typeof

🕗 Version & Regression Information
Present on all versions I used (4.8.4, 4.4.2). It doesn't crash, it just fallback to the method inference extension.
⏯ Playground Link
Playground link with relevant code
💻 Code
function update (key: string, value: any) {

}

function builder<Methods extends Record<string, any>>(cb: (ctx: { update: typeof update }) => Methods) {
    return cb({ update })
}

const result = builder(ctx => ({ test: "john", test2 () {} }))

🙁 Actual behavior
result's type returns Record<string, any>>
🙂 Expected behavior
result's type should return { test: string; test2(): void }, for this to happen, you just need to remove update: typeof update of the code

This is a duplicate of #48134. It is fixed in the nightly builds and will be in 4.9.


Weekdays have to start with Upper case when editing JSON schedule in ADF GUI

Just noticed an issue while following the JSON examples provided. I edited the schedule object in the JSON file via the ADF GUI using e.g. {"hours":[17], "weekDays":["saturday"]}.
Apparently the week days have to start with upper case, otherwise they are not recognized in the visual editor, i.e. {"hours":[17], "weekDays":["Saturday"]}.
Not sure if this is a bug or expected behavior, would be great if you could clarify in the documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 89177180-caeb-e2e1-5614-60719f593672
Version Independent ID: a3352be5-2343-ae87-38d0-32312a62d2b1
Content: Create schedule triggers in Azure Data Factory
Content Source: articles/data-factory/how-to-create-schedule-trigger.md
Service: data-factory
GitHub Login: @sharonlo101
Microsoft Alias: shlo

Sorry for the delay in response! This documentation is correct and the behavior you are experiencing is a UX bug. I opened a work item that will be resolved in the near future. In the mean time, please use the workaround of capitalizing weekdays if you are working via the UX
Thanks,
Daniel
#please-close


Modbus fails if in between http request and response

Problem

(x ) bug report

Not sure if this is a problem with node red, or with this package, so, feel free to close it, if it is a node red problem.
Current behavior
I have a http in node, which gets a request, transforms this to a payload modbus-getter understands and then want to pass the modbus response on as the http-response.
Node now fails with
"TypeError: Cannot set property listening of #<Server> which has only a getter"

Which seems to be related to the fact, that both http-in and modbus-getter set the msg.req object.
I see, that modbus sends out the message, and receives an answer, but when sending out the message, it fails.
If the input comes from an inject node, there is no problem.
Minimal reproduction of the problem with instructions

Create a flow like in the image (issue does not allow json upload). Inject node is working. HTTP get is not.
Transform function:
msg.payload = Object.assign({}, msg.req.params);
return msg;

Your Environment
Please tell us about your environment:

Description of the connecting Modbus system:

Name   : a somehow working python script, but not the issue here.

node-red-contrib-modbus version: v5.8.0
21bb78a
Modified the finally statement to work with Node-8

Node: (min. 10.x)
node --version = v8.16.1 (I know, it is not supported, but I hope, that is not the problem here)

@gumulka you need 5.11.0 and the new keep properties option - see the new example for HTTP via Node-RED import -> Examples -> ...

I don't see the 5.11 tag here on github, only 5.10.1. Is it missing?

Oh it was - normally it gets pushed automatically. Fixed

Okay, I updated to newest master code, used the example flow provided by your package and just changed the modbus-serial connection to my own.
TypeError: Cannot set property listening of #<Server> which has only a getter    at _clone (/usr/lib/node/node-red/node_modules/clone/clone.js:162:16)    at _clone (/usr/lib/node/node-red/node_modules/clone/clone.js:162:18)    at _clone (/usr/lib/node/node-red/node_modules/clone/clone.js:162:18)    at _clone (/usr/lib/node/node-red/node_modules/clone/clone.js:162:18)    at _clone (/usr/lib/node/node-red/node_modules/clone/clone.js:162:18)    at clone (/usr/lib/node/node-red/node_modules/clone/clone.js:202:10)    at Object.cloneMessage (/usr/lib/node/node-red/node_modules/@node-red/util/lib/util.js:91:17)    at Object.node (/usr/lib/node/node-red/node_modules/@node-red/runtime/lib/nodes/Node.js:410:61)    at BREAK (/usr/lib/node/node-red/node_modules/node-red-contrib-modbus/modbus/maps/modbus-getter.js:58:11)    at /usr/lib/node/node-red/node_modules/node-red-contrib-modbus/modbus/maps/core/core/modbus-client-core.js:66:11

My bad, did not install 5.11, but 5.8 again... Did a messup in git. It is now working with 5.11.0 Thank you


Add CNN-MLP Model

To have a clean A/B kind of model, this PR factors out the CNN input stage and the final FC stage.  This highlights the differences between the two models clearly.
The specific CNN-MLP implementation has been taken from yangky11's fork.  However, since my branch was taken after the '10x speedup' patch, it includes that too.
RN @ epoch 20 :
   Test set: Relation accuracy: 87% | Non-relation accuracy: 99%
CNN-MLP  @ epoch 100 :
   Test set: Relation accuracy: 66% | Non-relation accuracy: 69%

It's also now Python3-ready, and there are some other minor tweaks.
What do you think?

I am very sorry for late reply. I have been on military training until now. I cannot check your pr now. But it seems your code works beautifully. Thank you for your code! Next reply should be in 3 weeks later :)

Great - and thanks for coming up with the original code so quickly.  I used it as the basis of my presentation at the first PyTorch event in Singapore, which wasn't videoed but my slides are here.
Stay safe!


SystemVMs won't start with error "no usable volumes found for the VM" after upgrading to 4.17.2

ISSUE TYPE

Bug Report

COMPONENT NAME

Upgrade, SystemVM

CLOUDSTACK VERSION

4.17.2

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

Once you destroy the SystemsVMs after upgrading CloudStack from an older version to 4.17.1/2 the SystemVMs fails to get created with an error “no usable volumes found”. This is appearing since the newly added SystemVM template entries in the vm_template are missing 'size' , it would be null. The same would be seen in the template_store_ref as well. This appears if you choose not to register the systemVM template and use the new "automatic registration of systemVM templates".
While allocating the volumes of SSVM and CPVM it hits a NPE and skips allocating the volume. This VM remains and the next run of the secstorage-1 or consoleproxy-1 thread detects these as stopped SystemVMs then tries to start them with error "no usable volumes found for the VM"
A workaround would be to set a size on both vm_template and template_store_ref tables for the new systemVM template, we can get the value from the templates.properties in the secondary storage for the template.
java.lang.NullPointerException
        at org.apache.cloudstack.storage.datastore.db.TemplateDataStoreVO.getSize(TemplateDataStoreVO.java:280)
        at com.cloud.template.TemplateManagerImpl.getTemplateSize(TemplateManagerImpl.java:2007)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

STEPS TO REPRODUCE

1. Upgrade CloudStack (I used 4.14) to 4.17.1 using "automatic registration of systemVM templates"
2. Destroy SystemVMs

EXPECTED RESULTS

SystemVMs should come up after destroying

ACTUAL RESULTS

SystemVMs didn't come up

@rajujith I'm not able to reproduce this. I tried with a Xen env and 4.15.2 to 4.17.2. Template entries were correctly updated with size. If you still have the env, can you please check the contents of template.properties on the secondary store for the automatic registered template?

@shwstppr  The env is upgraded and it had the size in the templates.properties. I copied the same value to update the DB.

@rajujith , i try to fix if the Long size is null and retrieved as long in https://github.com/apache/cloudstack/pull/7691
I am not sure if this is the whole issue though.

I meet the similar problem:
But  the  management-server.log does not have TemplateManagerImpl.getTemplateSize key words.
# grep -ri "TemplateManagerImpl.getTemplateSize" management-server.log

The issue is: https://github.com/apache/cloudstack/issues/7720

fixed via #7691


Exceptions at the start of the game

I honestly don't have any luck with your game. A few months ago when I tried to run it, I couldn't get to the gameplay neither. Please try to keep your master branch in the playable state at all times otherwise it just puts off any potential contributors.

After pressing Start Game, creating a Wizard and pressing Begin!:

After pressing Test Map in the main menu:

True!
I'm quite sorry about it, my master branch is quite borked right now.... I won't be able to fix all issues right now, but give me just a few more months and you will be able to at the very least start the game!

This specific issue is already fixed in my latest feature branch, but that branch will take a while to be merged, since it's still in the process of being developed

But for some months yet, please consider the game broken, unplayable and probably ugly. Not specifically in that order!

And thank you for your interest in this game of mine!

Fixed by #39


PLT-1604: Add some benchmarks for summing using 'data lists'

Matthias says that Aiken encodes all structured data as Data. I was very surprised that this is performant at all, so I thought I would write a benchmark to test.
I wrote a variant of our existing list benchmarks that just uses explicit operations on Data to mimic a list of integers.
Indeed, "data lists" seem to be significantly worse (3-4x) than both Scott-encoding and builtin lists. That's not terribly surprising, since deconstructing a list encoded using Data requires at least four builtin operations:

UnConstrData to get the Constr args
Fst to get the tag
Snd to get the args
Head to get the first arg
... additional Head/Tails to get further args

I do think my benchmark is slightly worse for data lists than other usage, since it is working with a list of integers, rather than Data objects, so we have to do another builtin operation to extract the final integer. But I think the size of the difference is large enough that this is unlikely to be decisive.

Pre-submit checklist:

Branch

[x] Tests are provided (if possible)
[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[ ] Changelog fragments have been written (if appropriate)
[x] Relevant tickets are mentioned in commit messages
[x] Formatting, PNG optimization, etc. are updated

PR

[ ] (For external contributions) Corresponding issue exists and is linked in the description
[x] Targeting master unless this is a cherry-pick backport
[x] Self-reviewed the diff
[x] Useful pull request description
[x] Reviewer requested

There's an opportunity for an argument about terminology here. Usually when I hear the word "benchmark" I think of something like Criterion benchmarks which run a program and see how much real-world time it takes.  Quite a few of the things we call benchmarks measure the cost of a PLC script, which is different (although we hope not too different), and we don't usually put them under benchmark in the cabal files.   Maybe we should call them something else, although I don't know what.

I have thought about that a bit. I do think they're benchmarks, they just happen to be deterministic benchmarks. And for deterministic benchmarks you can treat them like golden tests, which has the advantage that you get a very clear signal of when they change.


Worse performance when including test object in training

When I include the test object in the training data, performance is actually worse. How could this be? I tested this with object pill in MVTec.

We did not conduct the experiments in the setting you mentioned because it is not what this work focuses on. But I guess something went wrong for your experiments. Or I guess your training is overfitting or collapsing. I remember that pills in MVTec are all centered and have a similar orientation and thus easier to overfit. If you need more discussion you are welcome to email me.


v10 plans

For v10, I'm planning to use a function instead of a mixin. The main reason is the min() technique described in #110 doesn't need to generate a media query any more. I'm thinking about a function called rfs() or responsive() (which might be a bit clearer). Or maybe work with an alias like we do now.
Other positive side effects are:

We can use the same syntax in every language (sass, scss, less, stylus & PostCSS)
The function can be used with every property, like height, padding or margin.
It's a bit more predictable than the mixin because you know it's going to a value and not "some lines of code"
Mixins don't work with plugins like stylelint-order, the function would fix this.
Custom properties (css variables) can be set to a value which can be reused in css.

Only downside is that the disabled/enabled classes won't work anymore, but I don't think that's really an issue.
So what would this look like?
.title {
  padding: rfs(2rem);
  font-size: rfs(4rem);
}

would generate:
.title {
  padding: min(2rem, calc(1.325rem + 0.9vw));
  font-size: min(4rem, calc(1.525rem + 3.3vw));
}

Browser support
Browser support is still an issue. Browser support so far:

[x] Safari
[ ] Chrome
[ ] Firefox
[ ] Edge

True, the current browser support is still a pity, but compared to the ancient topic for a so called "parent selector", which is at least raving for 19 years now, I guess we might see min(), max() and even clamp() still within our life time. 🥳

Closing this since https://github.com/twbs/rfs/issues/110 also addresses this.


WIP: fix using interface in constructor

As reported here, in addition to there being an issue with enums in constructors, there's similarly a couple issues with interfaces in constructors.

installing module with an interface in the constructor results in following error

Stderr:
Error: failed to generate code: input: moduleSource.withContextDirectory.withDependencies.asModule resolve:
failed to create module: select: failed to update codegen and runtime: failed to generate code: failed to get
schema introspection json during module sdk codegen: failed to get schema for module "mallard": failed to
install constructor: failed to create function: failed to find mod type for function "" arg "d" type

developing module with an interface embedded in the struct results in the following errors

Stderr:
Error: failed to get module SDK: input: moduleSource.withContextDirectory.asModule resolve: failed to create
module: select: failed to update codegen and runtime: failed to generate code: failed to get modified source
directory for go module sdk codegen: select: process "codegen --output /src --module-context-path /src
--module-name mallard --introspection-json-path /schema.json" did not complete successfully: exit code: 1

Error: generate code: template: module.go.tmpl:79:3: executing "_dagger.gen.go/module.go.tmpl" at
<ModuleMainSrc>: error calling ModuleMainSrc: failed to parse method XXX_GraphQLType: failed to find decl
for method XXX_GraphQLType: no decl for XXX_GraphQLType

When the enum bug is addressed, I can test whether it also fixes the interface issue or issues. Chances are that it might fix the module install issue but not the struct embedding issue.

I will revisit what I was attempting to do here when https://github.com/dagger/dagger/issues/8030 lands. The issue that spurred this investigation is fixed, but the usage of interfaces is still somewhat hampered.


Builds

Windows:
ModularFungi-0.6.0-win.zip
Linux:
ModularFungi-0.6.0-lin.zip

You might use the "releases" feature of GitHub to make these more findable. Of course if they are going in the plugin manager it will be moot.

Good plan.

Mac:
ModularFungi-0.6.0-mac.zip

Thank you


Update master for pre-release v1.0.0-rc1

Feel free to approve, but do not merge this PR. It needs to be done manually on the command line as per instructions in the wiki.
Clarification: we actually need 3 approvals on this to go ahead.

Sure, I volunteer.
(Unless someone feels very strongly about it, I suggest that the normal procedure is that the one posting the PR also does the merging.)


testing/ostest: make sure that signets and pthread_rwlock tests are executed properly

Summary
Make sure that signets and pthread_rwlock tests are executed properly.
The issues has been found during working on https://github.com/apache/nuttx/pull/7464
Impact
ostest is even more reliable
Testing
Pass sim:ostest

@xiaoxiang781216 could you please merge this PR?


Add ignore for deleted needles warning

https://progress.opensuse.org/issues/29289

Full ACK on your concern. PR updated accordingly.