I am trying to follow the instruction to run the code, however, after resolving some errors, there are some errors I cannot fix

The command I exexuted :
$ cd $CALVIN_ROOT/calvin_models/calvin_agent
$ python training.py
errors I got after fixing some errors.
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.7/site-packages/hydra/_internal/utils.py", line 573, in _locate
raise ImportError(f"Error loading module '{path}'") from e
ImportError: Error loading module 'lfp.utils.transforms.NormalizeVector'
I investigate the github, and I found out that this file is from here: which is missing

python /home/hermannl/repos/learning_from_play/lfp/training.py
In addition, I need to modify utils.transforms.py to get to this point.
I modify ScaleImageTensor to this:
class NormalizeVector(object):
"""Normalize a tensor vector with mean and standard deviation."""
def __init__(self, mean=0.0, std=1.0):
    **if isinstance(mean, float):
        mean = [mean]
    if isinstance(std, float):
        std = [std]**
    print("success")
    self.std = torch.Tensor(std)
    self.std[self.std == 0.0] = 1.0
    self.mean = torch.Tensor(mean)

def __call__(self, tensor: torch.Tensor) -> torch.Tensor:
    assert isinstance(tensor, torch.Tensor)
    return (tensor - self.mean) / self.std

def __repr__(self):
    return self.__class__.__name__ + "(mean={0}, std={1})".format(self.mean, self.std)

I also modify add depthNoise to this:
class AddDepthNoise(object):
"""Add multiplicative gamma noise to depth image.
This is adapted from the DexNet 2.0 code.
Their code: https://github.com/BerkeleyAutomation/gqcnn/blob/master/gqcnn/training/tf/trainer_tf.py"""
def __init__(self, shape=1000.0, rate=1000.0):
    self.shape = torch.tensor(shape)
    self.rate = torch.tensor(rate)
    self.dist = torch.distributions.gamma.Gamma(torch.tensor(shape), torch.tensor(rate))

def __call__(self, tensor: torch.Tensor) -> torch.Tensor:
    assert isinstance(tensor, torch.Tensor)
    multiplicative_noise = self.dist.sample()
    return multiplicative_noise * tensor

def __repr__(self):
    # return self.__class__.__name__ + f"{self.shape=},{self.rate=},{self.dist=}"
    **return self.__class__.__name__ + "(self.shape={0}, self.rate={1}, self.dist={2})".format(self.shape, self.rate, self.dist)**

Hello @nikepupu ,
are you trying to train with a slurm cluster or directly? Because the hermannl repo is inside the slurm script directories, but in the beginning you say you try to run python training.py
If you are trying to train directly, could you just post the log and the errors you get without any other modifications please?

The first error is the following:
Error executing job with overrides: []
Traceback (most recent call last):
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.7/site-packages/hydra/_internal/utils.py", line 585, in _locate
import_module(mod)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.7/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1006, in _gcd_import
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "", line 724, in exec_module
File "", line 860, in get_code
File "", line 791, in source_to_code
File "", line 219, in _call_with_frames_removed
File "/mnt/research/calvin/calvin_models/calvin_agent/visualization/tsne_plot.py", line 85
n := np.where(labels == -1)[0], replace=False, size=int(len(n) * self.plot_percentage)
^
SyntaxError: invalid syntax
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "training.py", line 136, in
wrap_train(conf)
File "training.py", line 64, in wrap_train
train()
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.7/site-packages/hydra/main.py", line 52, in decorated_main
config_name=config_name,
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.7/site-packages/hydra/_internal/utils.py", line 378, in _run_hydra
lambda: hydra.run(
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.7/site-packages/hydra/_internal/utils.py", line 214, in run_and_report
raise ex
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.7/site-packages/hydra/_internal/utils.py", line 211, in run_and_report
return func()
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.7/site-packages/hydra/_internal/utils.py", line 381, in
overrides=args.overrides,
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.7/site-packages/hydra/_internal/hydra.py", line 111, in run
_ = ret.return_value
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.7/site-packages/hydra/core/utils.py", line 233, in return_value
raise self._return_value
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.7/site-packages/hydra/core/utils.py", line 160, in run_job
ret.return_value = task_function(task_cfg)
File "training.py", line 40, in train
callbacks = setup_callbacks(cfg.callbacks)
File "training.py", line 68, in setup_callbacks
callbacks = [hydra.utils.instantiate(cb) for cb in callbacks_cfg.values()]
File "training.py", line 68, in
callbacks = [hydra.utils.instantiate(cb) for cb in callbacks_cfg.values()]
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.7/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 180, in instantiate
return instantiate_node(config, *args, recursive=recursive, convert=convert)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.7/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 240, in instantiate_node
target = _resolve_target(node.get(_Keys.TARGET))
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.7/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 104, in _resolve_target
return _locate(target)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.7/site-packages/hydra/_internal/utils.py", line 589, in _locate
) from e
ImportError: Encountered error: invalid syntax (tsne_plot.py, line 85) when loading module 'calvin_agent.visualization.tsne_plot.TSNEPlot'
I am using Anaconda on Ubuntu 18.04 with python3.7 with a RTX 3090 if that helps

After switching to python3.8, the above issue can be resolved. However, the next issue still exists, which is the modification I mentioned in the first post.
Using 16bit native Automatic Mixed Precision (AMP)
GPU available: True, used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
Error executing job with overrides: []
Traceback (most recent call last):
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 62, in _call_target
return target(*args, **kwargs)
File "/mnt/research/calvin/calvin_models/calvin_agent/utils/transforms.py", line 23, in init
self.std = torch.Tensor(std)
TypeError: new(): data must be a sequence (got float)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "training.py", line 62, in train
trainer.fit(model, datamodule=datamodule)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 737, in fit
self._call_and_handle_interrupt(
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 682, in _call_and_handle_interrupt
return trainer_fn(*args, **kwargs)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 772, in _fit_impl
self._run(model, ckpt_path=ckpt_path)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1133, in _run
self._call_setup_hook()  # allow user to setup lightning_module in accelerator environment
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1433, in _call_setup_hook
self.datamodule.setup(stage=fn)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/core/datamodule.py", line 474, in wrapped_fn
fn(*args, **kwargs)
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/play_data_module.py", line 62, in setup
self.train_transforms = {
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/play_data_module.py", line 63, in
cam: [hydra.utils.instantiate(transform) for transform in transforms.train[cam]] for cam in transforms.train
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/play_data_module.py", line 63, in
cam: [hydra.utils.instantiate(transform) for transform in transforms.train[cam]] for cam in transforms.train
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 180, in instantiate
return instantiate_node(config, *args, recursive=recursive, convert=convert)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 249, in instantiate_node
return _call_target(target, *args, **kwargs)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 64, in _call_target
raise type(e)(
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 62, in _call_target
return target(*args, **kwargs)
File "/mnt/research/calvin/calvin_models/calvin_agent/utils/transforms.py", line 23, in init
self.std = torch.Tensor(std)
TypeError: Error instantiating 'calvin_agent.utils.transforms.NormalizeVector' : new(): data must be a sequence (got float)
Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.

thanks for the report @nikepupu . I have updated the instructions and made a minor fix. The problem is that the path for the dataset was being incorrectly set. I have updated the default to dataset/task_D_D, could you try starting the training with and without overriding the argument?
So once:
python training.py
and once:
python training.py datamodule.root_data_dir=/path/to/dataset/

This is what I am getting:
python training.py
/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/defaults_list.py:251: UserWarning: In 'config.yaml': Defaults list is missing _self_. See https://hydra.cc/docs/upgrades/1.0_to_1.1/default_composition_order for more information
warnings.warn(msg, UserWarning)
Global seed set to 42
[2021-12-19 17:34:59,653][calvin_agent.models.decoders.logistic_policy_network][INFO] - Loaded action bounds from /mnt/research/calvin/calvin_models/calvin_agent/dataset/task_D_D/training/statistics.yaml
[2021-12-19 17:34:59,673][main][INFO] - Training with the following config:
callbacks:
rollout:
tasks:
target: calvin_env.envs.tasks.Tasks
tasks:
rotate_red_block_right:
- rotate_object
- block_red
- -60
rotate_red_block_left:
- rotate_object
- block_red
- 60
rotate_blue_block_right:
- rotate_object
- block_blue
- -60
rotate_blue_block_left:
- rotate_object
- block_blue
- 60
rotate_pink_block_right:
- rotate_object
- block_pink
- -60
rotate_pink_block_left:
- rotate_object
- block_pink
- 60
push_red_block_right:
- push_object
- block_red
- 0.1
- 0
push_red_block_left:
- push_object
- block_red
- -0.1
- 0
push_blue_block_right:
- push_object
- block_blue
- 0.1
- 0
push_blue_block_left:
- push_object
- block_blue
- -0.1
- 0
push_pink_block_right:
- push_object
- block_pink
- 0.1
- 0
push_pink_block_left:
- push_object
- block_pink
- -0.1
- 0
move_slider_left:
- move_door_rel
- base__slide
- 0.15
move_slider_right:
- move_door_rel
- base__slide
- -0.15
open_drawer:
- move_door_rel
- base__drawer
- 0.12
close_drawer:
- move_door_rel
- base__drawer
- -0.12
lift_red_block_table:
- lift_object
- block_red
- 0.05
- table
- base_link
lift_red_block_slider:
- lift_object
- block_red
- 0.03
- table
- plank_link
lift_red_block_drawer:
- lift_object
- block_red
- 0.05
- table
- drawer_link
lift_blue_block_table:
- lift_object
- block_blue
- 0.05
- table
- base_link
lift_blue_block_slider:
- lift_object
- block_blue
- 0.03
- table
- plank_link
lift_blue_block_drawer:
- lift_object
- block_blue
- 0.05
- table
- drawer_link
lift_pink_block_table:
- lift_object
- block_pink
- 0.05
- table
- base_link
lift_pink_block_slider:
- lift_object
- block_pink
- 0.03
- table
- plank_link
lift_pink_block_drawer:
- lift_object
- block_pink
- 0.05
- table
- drawer_link
place_in_slider:
- place_object
- table
- plank_link
place_in_drawer:
- place_object
- table
- drawer_link
stack_block:
- stack_objects
unstack_block:
- unstack_objects
turn_on_lightbulb:
- toggle_light
- lightbulb
- 0
- 1
turn_off_lightbulb:
- toggle_light
- lightbulb
- 1
- 0
turn_on_led:
- toggle_light
- led
- 0
- 1
turn_off_led:
- toggle_light
- led
- 1
- 0
push_into_drawer:
- push_object_into
- - block_red
- block_blue
- block_pink
- table
- base_link
- table
- drawer_link
target: calvin_agent.rollout.rollout.Rollout
recursive: false
env_cfg:
target: calvin_env.envs.play_lmp_wrapper.PlayLMPWrapper
skip_epochs: 1
rollout_freq: 1
video: true
num_rollouts_per_task: 10
check_percentage_of_batch: 1
ep_len: 120
empty_cache: true
log_video_to_file: false
save_dir: ./videos
start_robot_neutral: false
add_goal_thumbnail: true
min_window_size: ${datamodule.datasets.vision_dataset.min_window_size}
max_window_size: ${datamodule.datasets.vision_dataset.max_window_size}
id_selection_strategy: select_longest
lang_folder: ${datamodule.datasets.lang_dataset.lang_folder}
checkpoint:
target: pytorch_lightning.callbacks.ModelCheckpoint
save_top_k: 3
verbose: true
monitor: tasks/average_sr
mode: max
dirpath: saved_models
filename: '{epoch}'
every_n_epochs: ${callbacks.rollout.rollout_freq}
tsne_plot:
target: calvin_agent.visualization.tsne_plot.TSNEPlot
perplexity: 40
n_jobs: 8
plot_percentage: 0.2
opacity: 0.3
marker_size: 5
kl_schedule:
target: calvin_agent.utils.kl_callbacks.KLConstantSchedule
datamodule:
datasets:
vision_dataset:
target: calvin_agent.datasets.npz_dataset.NpzDataset
key: vis
save_format: npz
batch_size: 32
min_window_size: 16
max_window_size: 32
proprio_state: ${datamodule.proprioception_dims}
obs_space: ${datamodule.observation_space}
pad: true
lang_folder: lang_annotations
lang_dataset:
target: calvin_agent.datasets.npz_dataset.NpzDataset
key: lang
save_format: npz
batch_size: 32
min_window_size: 16
max_window_size: 32
proprio_state: ${datamodule.proprioception_dims}
obs_space: ${datamodule.observation_space}
skip_frames: 1
pad: true
lang_folder: lang_annotations
transforms:
train:
rgb_static:
- target: torchvision.transforms.Resize
size: 200
- target: calvin_agent.utils.transforms.ScaleImageTensor
- target: torchvision.transforms.Normalize
mean:
- 0.5
std:
- 0.5
- target: calvin_agent.utils.transforms.AddGaussianNoise
mean:
- 0.0
std:
- 0.01
rgb_gripper:
- target: torchvision.transforms.Resize
size: 84
- target: calvin_agent.utils.transforms.ScaleImageTensor
- target: torchvision.transforms.Normalize
mean:
- 0.5
std:
- 0.5
- target: calvin_agent.utils.transforms.AddGaussianNoise
mean:
- 0.0
std:
- 0.01
depth_static:
- target: torchvision.transforms.Resize
size: 200
- target: calvin_agent.utils.transforms.AddDepthNoise
shape:
- 1000.0
rate:
- 1000.0
- target: calvin_agent.utils.transforms.AddGaussianNoise
mean:
- 0.0
std:
- 0.01
depth_gripper:
- target: torchvision.transforms.Resize
size: 84
- target: calvin_agent.utils.transforms.AddGaussianNoise
mean:
- 0.0
std:
- 0.01
rgb_tactile:
- target: torchvision.transforms.Resize
size: 70
- target: torchvision.transforms.RandomCrop
size: 64
- target: calvin_agent.utils.transforms.ScaleImageTensor
- target: torchvision.transforms.Normalize
mean:
- 0.5
std:
- 0.5
- target: calvin_agent.utils.transforms.AddGaussianNoise
mean:
- 0.0
std:
- 0.01
depth_tactile:
- target: torchvision.transforms.Resize
size: 64
- target: torchvision.transforms.Normalize
mean:
- 0.1
std:
- 0.2
- target: calvin_agent.utils.transforms.AddGaussianNoise
mean:
- 0.0
std:
- 0.01
robot_obs:
- target: calvin_agent.utils.transforms.NormalizeVector
- target: calvin_agent.utils.transforms.AddGaussianNoise
mean:
- 0.0
std:
- 0.01
scene_obs:
- target: calvin_agent.utils.transforms.NormalizeVector
- target: calvin_agent.utils.transforms.AddGaussianNoise
mean:
- 0.0
std:
- 0.01
val:
rgb_static:
- target: torchvision.transforms.Resize
size: 200
- target: calvin_agent.utils.transforms.ScaleImageTensor
- target: torchvision.transforms.Normalize
mean:
- 0.5
std:
- 0.5
rgb_gripper:
- target: torchvision.transforms.Resize
size: 84
- target: calvin_agent.utils.transforms.ScaleImageTensor
- target: torchvision.transforms.Normalize
mean:
- 0.5
std:
- 0.5
depth_static:
- target: torchvision.transforms.Resize
size: 200
depth_gripper:
- target: torchvision.transforms.Resize
size: 84
rgb_tactile:
- target: torchvision.transforms.Resize
size: 70
- target: torchvision.transforms.RandomCrop
size: 64
- target: calvin_agent.utils.transforms.ScaleImageTensor
- target: torchvision.transforms.Normalize
mean:
- 0.5
std:
- 0.5
depth_tactile:
- target: torchvision.transforms.Resize
size: 64
- target: torchvision.transforms.Normalize
mean:
- 0.1
std:
- 0.2
robot_obs:
- target: calvin_agent.utils.transforms.NormalizeVector
scene_obs:
- target: calvin_agent.utils.transforms.NormalizeVector
proprioception_dims:
n_state_obs: 8
keep_indices:
- - 0
- 7
- - 14
- 15
robot_orientation_idx:
- 3
- 6
normalize: true
normalize_robot_orientation: true
observation_space:
rgb_obs:
- rgb_static
depth_obs: []
state_obs:
- robot_obs
actions:
- actions
language:
- language
target: calvin_agent.datasets.play_data_module.PlayDataModule
recursive: false
root_data_dir: dataset/task_D_D
action_space: 7
num_workers: 4
action_max:

1.0
1.0
1.0
1.0
1.0
1.0
1.0
action_min:
-1.0
-1.0
-1.0
-1.0
-1.0
-1.0
-1
shuffle_val: false
model:
perceptual_encoder:
vision_static:
target: calvin_agent.models.perceptual_encoders.vision_network.VisionNetwork
input_width: 200
input_height: 200
activation_function: ReLU
dropout_vis_fc: 0.0
l2_normalize_output: false
visual_features: 64
num_c: 3
vision_gripper: {}
depth_static: {}
depth_gripper: {}
proprio:
target: calvin_agent.models.perceptual_encoders.proprio_encoder.IdentityEncoder
proprioception_dims: ${datamodule.proprioception_dims}
tactile: {}
target: calvin_agent.models.perceptual_encoders.concat_encoders.ConcatEncoders
recursive: false
plan_proposal:
target: calvin_agent.models.plan_encoders.plan_proposal_net.PlanProposalNetwork
perceptual_features: ???
latent_goal_features: 32
plan_features: 256
activation_function: ReLU
min_std: 0.0001
plan_recognition:
target: calvin_agent.models.plan_encoders.plan_recognition_net.PlanRecognitionNetwork
in_features: ???
plan_features: 256
action_space: ${datamodule.action_space}
birnn_dropout_p: 0.0
min_std: 0.0001
visual_goal:
target: calvin_agent.models.encoders.goal_encoders.VisualGoalEncoder
in_features: ???
hidden_size: 2048
latent_goal_features: 32
l2_normalize_goal_embeddings: false
activation_function: ReLU
language_goal:
target: calvin_agent.models.encoders.goal_encoders.LanguageGoalEncoder
language_features: 384
hidden_size: 2048
latent_goal_features: 32
word_dropout_p: 0.0
l2_normalize_goal_embeddings: false
activation_function: ReLU
decoder:
target: calvin_agent.models.decoders.logistic_policy_network.LogisticPolicyNetwork
n_mixtures: 10
hidden_size: 2048
out_features: ${datamodule.action_space}
log_scale_min: -7.0
act_max_bound: ${datamodule.action_max}
act_min_bound: ${datamodule.action_min}
dataset_dir: ${datamodule.root_data_dir}
policy_rnn_dropout_p: 0.0
load_action_bounds: true
num_classes: 256
perceptual_features: ??
latent_goal_features: 32
plan_features: 256
optimizer:
target: torch.optim.Adam
lr: ${training.lr}
target: calvin_agent.models.play_lmp.PlayLMP
recursive: false
kl_beta: ${loss.kl_beta}
replan_freq: 30
loss:
kl_beta: 0.001
training:
lr: 0.0001
trainer:
gpus: 1
precision: 16
val_check_interval: 1.0
max_epochs: 100
logger:
target: pytorch_lightning.loggers.WandbLogger
save_dir: .
name: play_lmp
group: play_lmp
log_model: false
project: multi_play
id: ???
seed: 42
log_dir: ../
slurm: false

WARNING uncommitted modified files: calvin_env
[2021-12-19 17:34:59,796][main][INFO] - Repo commit hash: 23ce311bb14a07d284b87589842f0a542ab0a6fa
[2021-12-19 17:34:59,835][main][INFO] - * CUDA:
- GPU:
- NVIDIA GeForce RTX 3090
- available:         True
- version:           11.3

Packages:

numpy:             1.20.3
pyTorch_debug:     False
pyTorch_version:   1.10.1
pytorch-lightning: 1.5.6
tqdm:              4.62.3
wandb: Currently logged in as: nikepupu (use wandb login --relogin to force relogin)
wandb: Tracking run with wandb version 0.12.9
wandb: Syncing run 2021-12-19/17-34-59
wandb:  View project at https://wandb.ai/nikepupu/multi_play
wandb:  View run at https://wandb.ai/nikepupu/multi_play/runs/2021-12-19_17-34-59
wandb: Run data is saved locally in ./wandb/run-20211219_173500-2021-12-19_17-34-59
wandb: Run wandb offline to turn off syncing.

wandb: logging graph, to disable use wandb.watch(log_graph=False)
Using 16bit native Automatic Mixed Precision (AMP)
GPU available: True, used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
Error executing job with overrides: []
Traceback (most recent call last):
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 62, in _call_target
return target(*args, **kwargs)
File "/mnt/research/calvin/calvin_models/calvin_agent/utils/transforms.py", line 23, in init
self.std = torch.Tensor(std)
TypeError: new(): data must be a sequence (got float)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "training.py", line 62, in train
trainer.fit(model, datamodule=datamodule)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 737, in fit
self._call_and_handle_interrupt(
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 682, in _call_and_handle_interrupt
return trainer_fn(*args, **kwargs)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 772, in _fit_impl
self._run(model, ckpt_path=ckpt_path)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1133, in _run
self._call_setup_hook()  # allow user to setup lightning_module in accelerator environment
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1433, in _call_setup_hook
self.datamodule.setup(stage=fn)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/core/datamodule.py", line 474, in wrapped_fn
fn(*args, **kwargs)
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/play_data_module.py", line 62, in setup
self.train_transforms = {
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/play_data_module.py", line 63, in
cam: [hydra.utils.instantiate(transform) for transform in transforms.train[cam]] for cam in transforms.train
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/play_data_module.py", line 63, in
cam: [hydra.utils.instantiate(transform) for transform in transforms.train[cam]] for cam in transforms.train
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 180, in instantiate
return instantiate_node(config, *args, recursive=recursive, convert=convert)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 249, in instantiate_node
return _call_target(target, *args, **kwargs)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 64, in _call_target
raise type(e)(
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 62, in _call_target
return target(*args, **kwargs)
File "/mnt/research/calvin/calvin_models/calvin_agent/utils/transforms.py", line 23, in init
self.std = torch.Tensor(std)
TypeError: Error instantiating 'calvin_agent.utils.transforms.NormalizeVector' : new(): data must be a sequence (got float)
Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.
wandb: Waiting for W&B process to finish, PID 7029... (failed 1). Press ctrl-c to abort syncing.
wandb:
wandb: Synced 6 W&B file(s), 0 media file(s), 0 artifact file(s) and 0 other file(s)
wandb: Synced 2021-12-19/17-34-59: https://wandb.ai/nikepupu/multi_play/runs/2021-12-19_17-34-59
wandb: Find logs at: ./wandb/run-20211219_173500-2021-12-19_17-34-59/logs/debug.log
wandb:

I can modify this torch.Tensor to torch.tensor like other functions in this file to get rid of this error :
class NormalizeVector(object):
"""Normalize a tensor vector with mean and standard deviation."""
def __init__(self, mean=0.0, std=1.0):
    self.std = torch.Tensor(std)
    self.std[self.std == 0.0] = 1.0
    self.mean = torch.Tensor(mean)

def __call__(self, tensor: torch.Tensor) -> torch.Tensor:
    assert isinstance(tensor, torch.Tensor)
    return (tensor - self.mean) / self.std

def __repr__(self):
    return self.__class__.__name__ + "(mean={0}, std={1})".format(self.mean, self.std)

However, the next error still exits, which is the error in the first post:
Error executing job with overrides: []
Traceback (most recent call last):
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/utils.py", line 570, in _locate
module = import_module(mod)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1011, in _gcd_import
File "", line 950, in _sanity_check
ValueError: Empty module name
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "training.py", line 62, in train
trainer.fit(model, datamodule=datamodule)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 737, in fit
self._call_and_handle_interrupt(
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 682, in _call_and_handle_interrupt
return trainer_fn(*args, **kwargs)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 772, in _fit_impl
self._run(model, ckpt_path=ckpt_path)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1133, in _run
self._call_setup_hook()  # allow user to setup lightning_module in accelerator environment
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1433, in _call_setup_hook
self.datamodule.setup(stage=fn)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/core/datamodule.py", line 474, in wrapped_fn
fn(*args, **kwargs)
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/play_data_module.py", line 62, in setup
self.train_transforms = {
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/play_data_module.py", line 63, in
cam: [hydra.utils.instantiate(transform) for transform in transforms.train[cam]] for cam in transforms.train
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/play_data_module.py", line 63, in
cam: [hydra.utils.instantiate(transform) for transform in transforms.train[cam]] for cam in transforms.train
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 180, in instantiate
return instantiate_node(config, *args, recursive=recursive, convert=convert)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 240, in instantiate_node
target = _resolve_target(node.get(_Keys.TARGET))
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 104, in _resolve_target
return _locate(target)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/utils.py", line 573, in _locate
raise ImportError(f"Error loading module '{path}'") from e
ImportError: Error loading module 'lfp.utils.transforms.NormalizeVector'
source of error
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/play_data_module.py", line 63, in
cam: [hydra.utils.instantiate(transform) for transform in transforms.train[cam]] for cam in transforms.train

I think this is because you have a statistics.yaml file under the training folder and that file requires lfp.utils.transforms.NormalizeVector

I can get rid of this error by modifying statistics.yaml in both training and evaluation folder.
However, there is a new error showing up
trying to load lang data from:  /mnt/research/calvin/calvin_models/calvin_agent/dataset/task_D_D/training/lang_annotations/auto_lang_ann.npy
Error executing job with overrides: []
Traceback (most recent call last):
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 62, in _call_target
return target(*args, **kwargs)
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/npz_dataset.py", line 43, in init
) = self.load_file_indices_lang(self.abs_datasets_dir)
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/npz_dataset.py", line 149, in load_file_indices_lang
assert end_idx >= self.max_window_size
AssertionError
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "training.py", line 62, in train
trainer.fit(model, datamodule=datamodule)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 737, in fit
self._call_and_handle_interrupt(
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 682, in _call_and_handle_interrupt
return trainer_fn(*args, **kwargs)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 772, in _fit_impl
self._run(model, ckpt_path=ckpt_path)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1133, in _run
self._call_setup_hook()  # allow user to setup lightning_module in accelerator environment
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1433, in _call_setup_hook
self.datamodule.setup(stage=fn)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/core/datamodule.py", line 474, in wrapped_fn
fn(*args, **kwargs)
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/play_data_module.py", line 73, in setup
train_dataset = hydra.utils.instantiate(
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 180, in instantiate
return instantiate_node(config, *args, recursive=recursive, convert=convert)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 249, in instantiate_node
return _call_target(target, *args, **kwargs)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 64, in _call_target
raise type(e)(
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 62, in _call_target
return target(*args, **kwargs)
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/npz_dataset.py", line 43, in init
) = self.load_file_indices_lang(self.abs_datasets_dir)
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/npz_dataset.py", line 149, in load_file_indices_lang
assert end_idx >= self.max_window_size
AssertionError: Error instantiating 'calvin_agent.datasets.npz_dataset.NpzDataset' :
Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.

After removing the assertion, I encountered another error
Using 16bit native Automatic Mixed Precision (AMP)
GPU available: True, used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/core/datamodule.py:121: LightningDeprecationWarning: DataModule property train_transforms was deprecated in v1.5 and will be removed in v1.7.
rank_zero_deprecation(
/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/core/datamodule.py:140: LightningDeprecationWarning: DataModule property val_transforms was deprecated in v1.5 and will be removed in v1.7.
rank_zero_deprecation(
/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/core/datamodule.py:114: LightningDeprecationWarning: DataModule property train_transforms was deprecated in v1.5 and will be removed in v1.7.
rank_zero_deprecation(
/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/core/datamodule.py:133: LightningDeprecationWarning: DataModule property val_transforms was deprecated in v1.5 and will be removed in v1.7.
rank_zero_deprecation(
[2021-12-19 21:46:20,396][calvin_agent.datasets.base_dataset][INFO] - loading dataset at /mnt/research/calvin/calvin_models/calvin_agent/dataset/task_D_D/training
[2021-12-19 21:46:20,396][calvin_agent.datasets.base_dataset][INFO] - finished loading dataset
[2021-12-19 21:46:20,410][calvin_agent.datasets.npz_dataset][INFO] - Found "ep_start_end_ids.npy" with 1 episodes.
self.training_dir  /mnt/research/calvin/calvin_models/calvin_agent/dataset/task_D_D/training
[2021-12-19 21:46:20,434][calvin_agent.datasets.base_dataset][INFO] - loading dataset at /mnt/research/calvin/calvin_models/calvin_agent/dataset/task_D_D/validation
[2021-12-19 21:46:20,434][calvin_agent.datasets.base_dataset][INFO] - finished loading dataset
[2021-12-19 21:46:20,436][calvin_agent.datasets.npz_dataset][INFO] - Found "ep_start_end_ids.npy" with 1 episodes.
train_dataset <calvin_agent.datasets.npz_dataset.NpzDataset object at 0x7f18f197b610>
[2021-12-19 21:46:20,461][calvin_agent.datasets.base_dataset][INFO] - loading dataset at /mnt/research/calvin/calvin_models/calvin_agent/dataset/task_D_D/training
[2021-12-19 21:46:20,461][calvin_agent.datasets.base_dataset][INFO] - finished loading dataset
trying to load lang data from:  /mnt/research/calvin/calvin_models/calvin_agent/dataset/task_D_D/training/lang_annotations/auto_lang_ann.npy
self.training_dir  /mnt/research/calvin/calvin_models/calvin_agent/dataset/task_D_D/training
[2021-12-19 21:46:20,475][calvin_agent.datasets.base_dataset][INFO] - loading dataset at /mnt/research/calvin/calvin_models/calvin_agent/dataset/task_D_D/validation
[2021-12-19 21:46:20,475][calvin_agent.datasets.base_dataset][INFO] - finished loading dataset
trying to load lang data from:  /mnt/research/calvin/calvin_models/calvin_agent/dataset/task_D_D/validation/lang_annotations/auto_lang_ann.npy
train_dataset <calvin_agent.datasets.npz_dataset.NpzDataset object at 0x7f18f1984280>
Error executing job with overrides: []
Traceback (most recent call last):
File "training.py", line 62, in train
trainer.fit(model, datamodule=datamodule)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 737, in fit
self._call_and_handle_interrupt(
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 682, in _call_and_handle_interrupt
return trainer_fn(*args, **kwargs)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 772, in _fit_impl
self._run(model, ckpt_path=ckpt_path)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1133, in _run
self._call_setup_hook()  # allow user to setup lightning_module in accelerator environment
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1433, in _call_setup_hook
self.datamodule.setup(stage=fn)
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/pytorch_lightning/core/datamodule.py", line 474, in wrapped_fn
fn(*args, **kwargs)
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/play_data_module.py", line 79, in setup
train_sampler = get_sampler(train_dataset, shuffle=True)
File "/mnt/research/calvin/calvin_models/calvin_agent/datasets/play_data_module.py", line 119, in get_sampler
return RandomSampler(dataset, generator=torch.Generator().manual_seed(int(os.environ["PL_GLOBAL_SEED"])))  # type: ignore
File "/home/nikepupu/anaconda3/envs/calvin/lib/python3.8/site-packages/torch/utils/data/sampler.py", line 102, in init
raise ValueError("num_samples should be a positive integer "
ValueError: num_samples should be a positive integer value, but got num_samples=0
Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.
It seems this is because RandomSampler requires to pass in an argument of num_samples

Thanks for the logs. This is a bit weird because I checked the statistics inside the zip files and the paths for the statistics.yaml appear to be correct. Did you download the dataset recently? And do you get the same errors when you start the training by specifying the dataset with python training.py datamodule.root_data_dir=/path/to/dataset/
Also note that we tested the code with pytorch lightning 1.4.9, you might need to make changes if you want to user PL > 1.5 as you log indicates.

Just to clarify, you downloaded the dataset as specified in the readme like this?
$ cd $CALVIN_ROOT/dataset
$ sh download_data.sh D | ABC | ABCD

I only did sh download_data.sh D

Okey, my suspicion is that you are not loading the correct dataset. In the code, we download a minimal dataset of 50 steps, which we used to run CI tests during development, when no dataset path is given and the default location is empty.
https://github.com/mees/calvin/blob/main/calvin_models/calvin_agent/datasets/play_data_module.py#L56

I see, when I run my code the first time., I do observe it's downloading something.

Yes, I will fix that. But you should try running python training.py datamodule.root_data_dir=/path/to/dataset/ where the dataset i s the path where you downloaded the dataset with the download script. Does this work for you?

I have fixed that problem, can you try again please? python training.py datamodule.root_data_dir=/path/to/dataset/

It's working now. Thanks


Bump node exporter to 1.0.1

Bumps node exporter version to 1.0.1 and renames deprecated CLI argument (see https://github.com/prometheus/node_exporter/blob/master/CHANGELOG.md#breaking-changes).

please rebase on master

Closing bumped to 1.1.2 https://github.com/ernestas-poskus/ansible-prometheus/commit/6cb8b304c7a2831d914ea565dfe8bc9a8dee8601


refactor(support): convert PathHelper to immutable class

Closes #697

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

97 of 122 (79.51%)  changed or added relevant lines in 19 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 81.944%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Tempest/Console/src/Initializers/LogOutputBufferInitializer.php
0
1
0.0%

src/Tempest/View/src/Renderers/TempestViewCompiler.php
0
1
0.0%

src/Tempest/Console/src/ConsoleApplication.php
0
2
0.0%

src/Tempest/Core/src/Kernel/LoadDiscoveryLocations.php
10
12
83.33%

src/Tempest/Http/src/HttpApplication.php
0
2
0.0%

src/Tempest/Support/src/NamespaceHelper.php
39
44
88.64%

src/Tempest/Support/src/PathHelper.php
21
33
63.64%

Totals

Change from base Build<PHONE_NUMBER>9:
-0.1%

Covered Lines:
7847

Relevant Lines:
9576

💛  - Coveralls

Tests are failing because of component-dependencies


Update removing corr genomes

Hi @dkoslicki, this PR includes:

update the function for removing the close related genomes with the same method that is used in the matrix method.
remove the 0.9 factor for calculating the containment.
update the README.md file for this change.
update the test_workflow.py

Oh, and since it's new, I thought it worth pointing out: SonarCloud does have some helpful suggestions (eg. unused variables) and some that can be disregarded (it doesn't like f-strings, oddly). But please have a look at the Code Smells as usually these are quite fast and easy to address


W2D5 - Broken image links

Section 2.1 and 2.3 in Tutorial 2 have broken image links

Hi @dungscout96,
Can you elaborate on what links in W2D5T2 are broken?
Everything seems fine on my end?
Thanks.

I was looking at the main webpage version: https://deeplearning.neuromatch.io/tutorials/W2D5_TimeSeriesAndNaturalLanguageProcessing/student/W2D5_Tutorial2.html#section-2-1-text-generation-and-language-modelling

Thank you, @dungscout96, for catching this. We have updated the notebook on GitHub (PR https://github.com/NeuromatchAcademy/course-content-dl/pull/743), and the changes will be reflected on the jupyterbook later on.


PNG image support

Add support for non-interlaced PNG images to pdfioFileCreateImageObject.

Mostly done, just need to add support for the gAMA, tRNS, and cHRM chunks and fix CRC validation.

All done.


Wallpaper Feature

This requires unsplash's api key:- https://unsplash.com/developers

tnx man appreciate your effort


MM-18099 Correctly set channel type based on permissions in create channel modal

Summary
This was caused by the fact that we allow the creation of private channels by any user on the contributors team but not public channels. It wasn't letting George create the channel when he opened the modal because there was state initialization bug where it would show "Private" as the type in the modal but still try to create a public channel when the user clicked submit.
Based on that I think the correct fix is to still show the "Create New Channel" button but fix the fact that the modal would still try to create a public channel, not a private one.
@esethna can you confirm if that's correct or if I should do what the ticket originally asked for (see ticket description at the bottom for original report)?
Ticket Link
https://mattermost.atlassian.net/browse/MM-18099

Agree with the comments from GG in the ticket regarding the UX. I don't think the button should exist in the modal header of the public channel list, since it's not obvious that that leads to a modal that creates private channels given the entry point.
cc// @wiersgallak since this is permissions related ^

@esethna ok cool I can update it if @wiersgallak agrees

@jwilander I definitely agree.  It is a confusing experience to initiate a create event from a screen labelled specifically as public and then actually create a private channel. My recommendation is to remove the button and the confusion .  Thanks!

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-3552.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Test server destroyed


font-awesome_4: Was removed, add again

Motivation for this change
Version 5 is incompatible for some icons, so projects that depend on it
need to actively convert the symbols, see:
https://github.com/greshake/i3status-rust/issues/130
Reintroducing the old version lets us use those programs that haven't
been updated.
Was removed in 0a393f53a9702cea04a6afea506c3a91a1a2bf60
cc @Mic92 and @baldo
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

The "nicer" way to solve this is a generic build function for font awesome that takes the version and sha256 as parameters (refer to to unifi or vala for some examples). Might also be good with a comment that explains why we have the _4 version.

What about this? :)


If fieldsets are changed to sections for the grid theme, disabling inputs needs to be fixed

if the branch is a fieldset, than setting property disabled to true, won't disable anything (just hide the branch).

This has happened, and has not been fixed. Not super urgent.
I'm hoping we can switch back to fieldsets in future.


Fixes to comment action bar & use bin as delete icon

The current delete icon is a cross (x) but I think that we associate a cross more with close. Therefore, I think the bin icon expresses 'delete' better than a cross.
For some reason the hygiene script was not happy with my copyright comment. Because I noticed that other PRs didn't add a copyright when editing icons, I chose to do the same.
I also changed the comment action bar to hiding instead of removing itself if the comment is not hovered. Furthermore, the action bar used to not show on focus. I fixed this bug as well.

Depends on #4050 because I want to align the secondary button on comments to the right as well because the user needs less eye movement to see both buttons.
Before:

After:

This would be a lot easier with <ButtonGroup>

Depends on #4066

I'm seeing a misalignment of the buttons when editing a comment:

What do you mean by misalignment?
If you are referring to both buttons now being on the right, this is intentional:

I want to align the secondary button on comments to the right as well because the user needs less eye movement to see both buttons.

@Thomas1664 I'm referring to the lack of padding around the buttons in the bottom right corner. They are right up against the comment thread border.

After:

Normal comment:

Here's what I'm seeing. The text area is crammed up against the edges, as are the buttons:

The case where a comment is being edited inline is special in that the form actions need different padding rules to fit nicely within their container. I suggest we give this form 16px padding to match the normal content rendered in a comment. As a second step, we should remove the padding-bottom: 10px from the form-actions here to avoid double padding below the form.


uuid dependency

README says:

no dependency

Yet there is uuid:
https://github.com/notelix/web-marker/blob/538e6ed42b9a6a398f1b9bb0d0fac1ab5955ab9f/package.json#L14-L16
Not a big deal either way. Just wanted to point it out.

😃 Maybe I should state it as "almost zero dependency"

So I decided to remove the uuid dependency instead..
https://github.com/notelix/web-marker/commit/5289273e3393cc8e34b8aa065f580d5847c5fe70


Class Tune

Before submitting (must do checklist)

[x] Did you read the contribution guide?
[x] Did you update the docs? We use Numpy format for all the methods and classes.
[x] Did you write any new necessary tests?
[x] Did you update the CHANGELOG?

Proposed Changes

See #1024
Closing issues

closes #1024

Here is a list of details of my implementation that I think should be stated:

Typing of BaseMixin.set_params() was changed. Now the method returns type of object, from which it was called (instead of always returning "BaseMixin"). In Python 3.11 this can be implemeted easily using Typing.Self. So when Etna updates Python version it operates on, I think this implementation should be changed as well.
The implementation of BaseMixin.set_params() helper-function BaseMixin._update_nested_dict_with_flat_dict() altered to ...
(!!!) Current implementation of Tune is base on assumption that params_to_tune yields transforms in format "transforms.i.x" instead of "transform.i.x". This decision of mine also affects test_can_handle_transforms in test/test_auto/test_tune.py. There are my reasons:

"transforms" is the name by which list of transforms is passed when constructing object  from .to_dict() method output. I think there should be consistency around the code in dict elements naming, having it "transforms" in one place and "transform" in others could confuse contributors.
"transforms.i.x" notation is interpretable - it is understandable that there are multiple transforms, and i refers to number of concrete transform. On the other hand, it is unclear whether i in "transform.i.x" refers to indice of transform or to indice of something inside one transform object.
implementation-wise i think it is better to have the same processing pipeline for transforms coming from .to_dict() and from .params_to_tune(). I don't think that checking if coming arguments are "transform" or "transforms" and then directing them into one of two distinct pipelines is a good idea.
If you think that my decision is wrong, please explain why. I'm ready to re-write my code if you provide your vision on implementation of Tune based on keeping "transform.i.x" notation.

Codecov Report

:exclamation: No coverage uploaded for pull request base (automl-2.0@447a032). Click here to learn what that means.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##             automl-2.0   #1200   +/-   ##
============================================
  Coverage              ?   7.77%
============================================
  Files                 ?     177
  Lines                 ?   10517
  Branches              ?       0
============================================
  Hits                  ?     818
  Misses                ?    9699
  Partials              ?       0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

There is also 1 problem:
As you can see, I've declared dict_of_distrs right inside objective function.
I don't think that's good, as it creates dict_of_distrs every time objective is called, yet I don't know a better place to put dict_of_distrs declaration.
Please provide with suggestion where it should be put.

Ok, it is also possible to import Self from typing_extensions, but our current mypy version doesn't support it, as I understand.
I fixed this in this PR: #1201.
I agree about transforms, but don't really see where it was said to use transform.

Some tests are also failing. Probably, they can be debugged locally.

Hi, @GooseIt! Are there any news about fixes of the PR?

I'll take my time fixing this PR on this weekend, and I'll report no later than Sunday 23:59.

I'm sorry, I've overesrimated my coding pacing. I'm looking into the issue, but it will take one or two more days to fix everything

I get the message below when running pytest tests/test_auto/test_auto.py inside poetry shell.
E       RuntimeError: The runtime optuna version 2.10.1 is no longer compatible with the table schema (set up by optuna 3.1.0). Please try updating optuna to the latest version by $ pip install -U optuna.
The problem is, it is not exclusive to the branch I'm currently working in. I've checkout into master, and I there get the same error when running above mentioned command.
Do you get this error on your end as well?
If not, what do you think is the cause? Is there any problem with my virtual environment on your mind?

@Mr-Geekman, could you please reply to my E       RuntimeError: The runtime optuna version 2.10.1 is no longer compatible with the table schema (set up by optuna 3.1.0). Please try updating optuna to the latest version by $ pip install -U optuna. error message?
This manifestation makes it hard for me to debug tests locally, as all tests dependent on optuna.storages.RDBStorage throw errors

Have you seen somewhere in the tests the file with a name test.db? I have a suspicion that error is due to this file schema.

Yes, all the tests fail on yield RDBStorage("sqlite:///test.db") from optuna_storage fixture

Have you tried to remove it? Or it isn't present on the file system?

I think this file is created somewhere in test_auto.py or somewhere around the fixture that creates it.

@GooseIt , how are you doing with the task?

@Mr-Geekman, can this task wait for two weeks?
I think that this time will be more than enough for me to resolve my current schedule and have nothing else on my hands.

@GooseIt , do you have any news about the task? Are you ready to continue?

@GooseIt , do you have any news about the task? Are you ready to continue?

Dream scenario for me would taking a break until 18 May inclusively - that's my last deadline's date. After that I can dedicate multiple days in a row to this issue solely.
Are you in somewhat a hurry, or can we wait this long?

I wanted to finish this track next week. Until this week the task wasn't a blocker, but it seems like now it is. As I can see there are very small changes left. May be you can find an hour to make the fixes?

@Mr-Geekman, I will do my best to find these hours in the next three days.

I'm dedicating today to solving the issue.

I'm still having problem with local debugging of error because of test.db.
Here are steps that reproduce the issue:

Pull automl-2.0 branch
Run poetry shell
Run pytest tests/test_auto/test_auto.py

The output can be seen here
The issue seems not to be caused by my coding of this issue. From my perspective, there was no error until a moment when it spontaneously showed up.
test.db file is present in my system, yet it is untied to Git.
Could you provide me with possible solutions? As example, maybe you can send me your 'test.db` and I shall try running same commands with it?

Your solution worked. Thanks a lot)

It seems for me like everything except CHANGELOG.md is fixed.
Please review

The last commit name is misleading - everything excessive was removed.
Only relevant changes are now is this branch.
Please review

Last commit is ready to being reviewed

I'll do the replacement, will report tomorrow.

For hyperparameter suggestion logic in _objective' to work, set_params` is mandatory.
set_params is defined for class BaseMixin in etna/core/mixins.py. Nor AbstractPipeline nor  BasePipeline support it.
Should I inherit one of these classes from BaseMixin, and if yes, which one?

As I can see, BasePipeline already inherits BaseMixin.

The PR is ready to be reviewed.

I've moved all classes in auto.py from Pipeline class to BasePipeline class.
I think that both Tune and Auto classes should be able to work with any user-defined pipeline structure, not only instances of Pipeline class.

I'm merging it.

Thank you for bearing with me during this issue's completion.
I'm grateful for your assistance and reviewing.
I'll take a break from committing into Etna for a while. I don't know if or when I'll come back, but if I do, I will be happy to work with you once again.


🐛 Unable to see firebase analytics data on DebugView

In the debug view I can't see any firebase analytics data, on the other hand, the terminal says log event uploaded!

resolved. Issue was with wrong google-service.json


support ssh_config file?

hi!, i've been trying to pass a different port to slex using --option Port=XXXX but it says it can't connect to "host:22"...
since i have to give it other options, is there a possibility for it to support the ssh_config file?

@fauno could you retry the --option Port=XXX with the latest master branch?

I had the same issue. I think the cleanHost call overrides the port coming form the config file/-option flag.


Disable management server support

Purpose
Fixes https://github.com/wso2/apk/issues/486
This PR will address following

disable management server grpc and xds connections
disable sending system apis to management server
add tls for management server xds
cleanup and reformat management server configs

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email<EMAIL_ADDRESS>to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to<EMAIL_ADDRESS>and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

Unit tests

Code coverage information

Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Codecov Report
Base: 29.78% // Head: 29.79% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (90b94fc) compared to base (d43c5d0).
Patch coverage: 24.36% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #531   +/-   ##
=======================================
  Coverage   29.78%   29.79%
=======================================
  Files         125      125
  Lines       14371    14467   +96
  Branches     3676     3615   -61
=======================================
+ Hits         4280     4310   +30
- Misses       9897     9963   +66
  Partials      194      194

Impacted Files
Coverage Δ

...er/internal/operator/apis/dp/v1alpha1/api_types.go
100.00% <ø> (ø)

...rtal/devportal-domain-service/ballerina/apiDAO.bal
0.00% <0.00%> (ø)

...portal-domain-service/ballerina/applicationDAO.bal
0.00% <0.00%> (ø)

...ortal-domain-service/ballerina/subscriptionDAO.bal
0.00% <0.00%> (ø)

...domain-service/ballerina/devportal-api_service.bal
12.32% <19.04%> (+2.85%)
:arrow_up:

...ortal-domain-service/ballerina/applicationImpl.bal
64.76% <30.00%> (-7.58%)
:arrow_down:

...tal/devportal-domain-service/ballerina/apiImpl.bal
75.00% <41.66%> (-7.36%)
:arrow_down:

...rtal-domain-service/ballerina/subscriptionImpl.bal
88.33% <83.01%> (+10.72%)
:arrow_up:

...admin-domain-service/ballerina/apiCategoryImpl.bal
96.15% <0.00%> (-3.85%)
:arrow_down:

adapter/internal/oasparser/model/http_route.go
0.00% <0.00%> (ø)

... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


font bluring when click on print icon in chrome browser

Hi all,
In below html pdf url. I have got one issue in chrome.
https://github.com/mozilla/pdf.js
i.e : when i downloaded the pdf & given print page then i got perfect font.
When I click on print icon in open pdf url then print page generating with font bluring.
you can test this by using above url.
How can i fix this print icon issue? Please can anyone suggest me the best print pdf choices

Which PDF file do you mean exactly? Is it the default Tracemonkey PDF?

Closing as incomplete until more information is provided.


Update release notes.

Summary
Add this update for the0.16.9 release #412

You'll find the 0.16.9 release notes here:
http://ka-lite.readthedocs.io/en/0.16.x/installguide/release_notes.html

@mrpau-eduard - I think this PR still needs further release notes to be added. As there are no release notes in #429, you should perhaps conclude this by

Adding 0.16.9 here
Rebasing #429 on 0.16.x
Force-pushing #429
Add 0.17.0 release notes in #429

This PR is outdated @mrpau-richard create another release notes summary for the new installer updates. Closing this PR.


in solidity contracts

in the land contract file there is a error which can lead to gas limit issue , in the MyLands, MyReceivedLandRequest, and MySentLandRequest are storing arrays of values. If these arrays grow too large, it could lead to gas limit issues.we can instead use mapping of structs
please assign under gssoc'24 @jaibhedia

Could you please upload the contract file screenshot to check the issue.

I was just trying to help by looking at the code. Anyway, lets leave it.

Hey! @kairveeehh  you have been assigned the issue, please start working on it.


UDPComponent broken UE5.5 Mac

Hello!
This is a super nice plugin! I tried to get it work on UE 5.5 and Mac. The Plugin Compiles and I can add the Sensor to the World but I guess I get no output. So I checked the Blueprint and I saw that the UDPComponent was "Empty" for example if I add a new Ump component there are all the options for IP etc.. I tried to work me along the cpp and h files and I tried to replicate the at a flow with the blueprint functions. Send Socket opened -> Receive Socket Opens -> Emit Bytes but there I don't know what bytes to emit? because I can't find the GetDataPacket function of the sensor. Any guess on whether where I can get the emitting bytes from or how the c++ class can be modified so the UDP works again? In my opinion the OS shouldn't be a problem because as I saw you calculate the sensor points and send them over UDP, maybe the Engine version is? Or maybe I did something wrong with the UDP Component I don't know..
Thanks in advance and maybe we can get it to work!
https://github.com/user-attachments/assets/c8eb92b0-0a0d-4cdc-b2b4-764983923570

Hi @kwcnldnsldskcls!
Sorry for the late response. UDPComponent is come from plugin called UDP-Unreal. I am afraid that it does not supports UE5.5 yet.

Hi @james-yoo
it turned out I wasn‘t starting the project with UE5.5 instead I used 5.4.4 but it makes no  difference. The main problem was that the UDP plugin works just fine if I put the normal UDP component into the blueprint per hand but the automatic generated UDP Component from the C - Class of the Lidar just don’t work or is not correctly implemented. In the video you can see I can’t access the UDP information from the menue which I can when I set the UDP component by hand. Any ideas how to solve this?
Thanks for the reply!🙏🏼

Hi @kwcnldnsldskcls
I have no idea about this issue and no room for testing.

Hi @james-yoo,
no problem! Maybe I find a solution or if you have time sometime else you can comment here.
Thanks for the reply!


Replace Index.html

Hi there,
I am new both with arduino and involts, so sorry if this question sounds silly.
I am developing web based app for kiosk. And since it is requiring to access arduino so this project should be awesome. I have tried it and it works so awesome so easy to communicate with arduino.
I am facing difficulty on how to replace index.html with our existing web files & structures. I'd like to know whether it is possible on how to make connection to the arduino without needing the index.html, since we have our own index file and config page. That connection parameter should be there in the our config page along with other config parameters to make the kiosk works, not just the arduino.
Thank for the great job!

Involt has two html files - index.html is used to communicate with device and app.html is responsible as homepage layout of your app (which communicate with index). The app.html is put within iframe so pagination while holding the connection is possible without any tricks.
You just can't remove the index.html file but you can put your existing index as app.html (or even as other index.html file but in other folder).
Maybe you can partially put your project elements into Involt index.html?
I've made a quick test if existing Involt version is easy to put all scripts files into single html without changing them but it's not :/ Some changes in bridge.js and variable scopes are required.
PS. older versions uses single file without iframe but it requires single-page layout plus the most recent version have major improvements and syntax changes so I don't recommentd to use it.

I just wonder whether I can just use the javascript files and remove anything else. But, same with as you said, it seems to be complicated since it requires some changes in javascript files which they have access to the html element and styling.
I believe our app can be put into iframe without a problem. I just try to avoid the app to not become 'complicated' with 'strange' structures. Also to avoid future development from being stuck with other script requiring the app to put into another iframe :)
So far I have move all javascript files in core folder to the folder in our existing files structures and have make the involt works to connect to the desire COM port. The rest still not working. Dev console showing error 'involtApp' is undefined which I believe is the iframe element in which the script take control for communication between arduino with the gui.
Do you have a suggestion on how I can edit 'involtApp'? Maybe apply it into a div instead of iframe?
Thank you.

Ok, I understand. Is your app already a single-page layout or it has subpages in multiple html files?
Well, it's some kind of drawback when using Involt and I can't do much about that. I can check later if it's easy to adapt the existing files but you must know that single-page layout is a must in this case.
Considering further development of Involt - for 99/100 users removing the iframe and going back to single-page layouts (only) would be a huge step back so I will not consider this as future improvement. However, it would be nice to make this easier for such thing but I don't know if it's doable with existing structure.


Unable to access section setting in sections.scss file

Problem
I am unable to reference a sections settings from the section.scss file
Replication steps

Add following to src/sections/header.liquid
{
"type": "color",
"id": "announcement_bg_color",
"label": "Announcement BG Color",
"info": "info"
},

Add following to src/snippets/css-variables.liquid
:root {
....existing entries
--annbar-bg-color: {{ settings.announcement_bg_color }}
}

Add following to assets/styles/variables.scss
// Announcement bar
$annbar_bg_color: var(--annbar-bg-color);

Add following to assets/styles/sections/announcement.scss
background-color: $annbar_bg_colour

Any additional information which might be helpful.
I get an error saying
Try opening assets/layout.theme.styleLiquid.scss.liquid in the template editor to fix the error below:
Undefined variable: "$annbar_bg_color". at 10

This technically wouldn't be an issue with Slate, but rather how Shopify's sections fundamentally work.  Section settings and block information are isolated and only accessible inside the section.  This allows for quick partial reloads in the customize theme menu.
The right approach is to set colors or other values directly in the section's markup with classes, data attributes for JavaScript or <script> tags.  starter-theme has several good examples of this.
https://github.com/Shopify/starter-theme/blob/master/src/sections/header.liquid#L131

As @jonathanmoore mentioned, this is not a problem with Slate rather a challenge in building themes in general. Closing.


Error handling: Generalize the use of the recoverer from AbstractBinder

Use the recoverer configured in the core retryTemplate and use an ErrorMessageSendingRecoverer as an option for sending errors to the error channel instead of the DLQ. Also, make this a general feature so that different binder implementations can operate in a similar fashion.

Duplicate of #913


Add files via upload

uploading v1.1.56 release note image for render lineage
Description & motivation

To-do before merge

Prerelease docs
If this change is related to functionality in a prerelease version of dbt (delete if not applicable):

[ ] I've added versioning components, as described in "Versioning Docs"
[ ] I've added a note to the prerelease version's Migration Guide

Checklist
If you added new pages (delete if not applicable):

[ ] The page has been added to website/sidebars.js
[ ] The new page has a unique filename

If you removed existing pages (delete if not applicable):

[ ] The page has been removed from website/sidebars.js
[ ] An entry has been added to _redirects

@mirnawong1 I don't see any changes here. Were they in another PR possibly?

i think you're right @runleonarun and closing this pr


[Bug?] Issues with player / ped detection

Hey,
So we use shell (props) for housing, i a person dies with in a shell, we cant target them via ox_target in any way, it's like the shell prop creates some sort of issue picking op the target, qtarget did not have this issue, so not sure if the method used to identify targets, is off in some way.

If you haven’t then update to the latest version

Okay found a nother issue with newest version tho
Not sure if this is by design, before the update they picked up fine, now i have to extend the box outside of the desk
https://user-images.githubusercontent.com/3528000/202849803-929ad147-142f-400d-98a6-60a8676cf1f6.mp4
https://user-images.githubusercontent.com/3528000/202849807-7fecbbcb-b37e-40a7-bbdc-303699d2813f.mp4

why is it a box zone

Since before it would not pick up the peds either, it refused, so we had to make it in to a box zone.

Seems to me like there's still collision in the gap.


tlsConfig.BuildNameToCertificate is deprecated

go vet fails with:
internal/puppetdb/puppetdb.go:76:3: tlsConfig.BuildNameToCertificate is deprecated: NameToCertificate only allows associating a single certificate with a given name. Leave that field nil to let the library select the first compatible chain from Certificates.  (SA1019)

Fixed in v0.13.0.


how to set threshold / confidence for prediction?

Hi
How can I set confidence threshold value while testing the model ? I want to experiment with different confidence values to see how the predictions change.

i have same problem..

hi, do you guys find the solution? i'm also finding this


[feature/qir-submission] Qiskit QIR - Frontpage example not working

When running the frontpage example:
from qiskit import QuantumCircuit
from qiskit_qir import to_qir

circuit = QuantumCircuit(name="my-circuit")
circuit.h(0)
circuit.cx(0, 1)
circuit.cx(1, 2)
circuit.measure([0,1,2], [0, 1, 2])

qir = to_qir(circuit)

following output occurs:
% python generate_circuit.py
Traceback (most recent call last):
  File "/Users/tfr/Documents/Projects/qat/develop_env/lib/python3.9/site-packages/qiskit/circuit/quantumcircuit.py", line 1084, in _bit_argument_conversion
    ret = [in_array[bit_representation]]
IndexError: list index out of range

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/tfr/Documents/Projects/qat/qir/qir-validation-tests/qiskit/generate_circuit.py", line 5, in <module>
    circuit.h(0)
  File "/Users/tfr/Documents/Projects/qat/develop_env/lib/python3.9/site-packages/qiskit/circuit/quantumcircuit.py", line 2760, in h
    return self.append(HGate(), [qubit], [])
  File "/Users/tfr/Documents/Projects/qat/develop_env/lib/python3.9/site-packages/qiskit/circuit/quantumcircuit.py", line 1220, in append
    expanded_qargs = [self.qbit_argument_conversion(qarg) for qarg in qargs or []]
  File "/Users/tfr/Documents/Projects/qat/develop_env/lib/python3.9/site-packages/qiskit/circuit/quantumcircuit.py", line 1220, in <listcomp>
    expanded_qargs = [self.qbit_argument_conversion(qarg) for qarg in qargs or []]
  File "/Users/tfr/Documents/Projects/qat/develop_env/lib/python3.9/site-packages/qiskit/circuit/quantumcircuit.py", line 1124, in qbit_argument_conversion
    return QuantumCircuit._bit_argument_conversion(qubit_representation, self.qubits)
  File "/Users/tfr/Documents/Projects/qat/develop_env/lib/python3.9/site-packages/qiskit/circuit/quantumcircuit.py", line 1106, in _bit_argument_conversion
    raise CircuitError("Index out of range.") from ex
qiskit.circuit.exceptions.CircuitError: 'Index out of range.'

It looks like the sample is missing the classical and quantum register definitions. Thanks for catching this!


Support both latest version and LTS version of QGis

This ticket is a followup on the discussion started in  #147262.
Currently, nixpkgs maintains a port of the Long Term Release (LTR) of QGis.  Updates to the LTR series only include bug fixes.  Alongside with the LTR releases, upstream also provides Latest Releases (LR) which provide new features (See here for details)
There is growing demand to support LR releases in nixpkgs.
The proposition is:

Keep the current LTR version in nixpkgs and rename it qgis-lts in all-packages.nix (qgis-unwrapped gets renamed qgis-lts-unwrapped)
Introduce a new derivation for QGis-LR named qgis (with qgis-unwrapped) .

One down-side of doing this is that it is possible that somewhere in the lifecycle of a nixpkgs release, QGis LR requires updates (incl in its dependency tree) that we would not want to force on a stable branch (which is only supposed to receive bug and security fixes). This means that the LR variant of QGis could be stuck at some point without bugfixes in release branch, while LTR still receives such fixes.
This point might be discussed further when a PR is created for this.
Note: Given the release schedule, 21.11 will continue to only have one version of QGis which is LTR, while master and subsequent releases will have both versions.
cc @erictapen, @willcohen
Project description
QGis is a a Free and Open Source Geographic Information System.
Metadata

homepage URL: https://qgis.org/en/site/
source URL: https://github.com/qgis/QGIS
license: gpl2+
platforms: linux, darwin

Yes please.
QGIS 3.18 adds support for viewing point cloud data, that was released in February.
There are also two shortcomings with the QGIS as packaged that I know about.

grass is not enabled, which severally limits the processing algorithms you can use. I know I fixed this at some point so it's a shame that this support has regressed.
The 3D viewer doesn't work.

I have fixed the grass issue and 3D issue locally, I will test the build tomorrow.
@lsix Are you preparing a patch which packages more recent versions of qgis? I am keen to get point cloud support.

For QGIS >= 3.18 we need to set the WITH_PDAL=TRUE cmake variable.
See https://github.com/archlinux/svntogit-community/blob/packages/qgis/trunk/PKGBUILD#L48

Another issue with the current QGIS package is that the -DGRASS_PREFIX7 is set incorrectly.
-DGRASS_PREFIX7=${grass}/${grass.name}

This resolves to <nix store path>-grass/grass but the correct directory is <nix store path>-grass/grass78.

@lsix I packaged qgis-3.22.1 and introduced the other fixes I described on this thread.
https://github.com/mpickering/nixpkgs/tree/wip/grass

Hi @mpickering
Thanks for working on this! I started looking into having qgis-3.22.1 working, and did it only locally (actually, this was more an assessment of what should be done). This only include qtlocation support in pyqt and version bump in qgis, so your branch is far head!
I just glanced at your branch (I am unfortunately quite busy ATM), and here are the few remarks I would have:

I fill that the wrapper should not have to handle grass. It should be enabled directly in the unwraped derivation, and obey the withGrass parameter.  The wrapper (as it is) is mainly used so users can have a QGis with any python dependency they want without recompiling all the c++ code.
I am not sure we need to introduce pyqt5_with_qtlocation in pythonPackages.  It is possible to do a local override in the python derivation with something like:

{}:
let
  localPython3Packages = python3Packages.python.override {
    packageOverrides = self: super: {
        pyqt5 = super.pyqt5.override { withLocation = true; };
    }
  };
  pythonBuildInputs = with localPython3Packages; [ ... ];
in ... {

   passthru = {
    inherit pythonBuildInputs;
    python3Packages = localPython3Packages;
  };

}

What do you think?

I changed the wrapper to be applied in the unwrapped.nix script but didn't make the qtlocation change as I couldn't get that to work. The pyqt_with_location follows the pattern for the other optional arguments (which is why I did it in the first place).

Closing with #156747


Steam legality

Would an old N64 game be able to go on steam if it was natively recompiled with N64Recomp? I was thinking Since N64Recomp relies on libultra as the primary lib that the games use, which belongs to Nintendo iirc. I've also been thinking if there was any sort of loophole to get Zelda64 on steam either as a steam workshop mod for an emulator that is already on there, or if the N64Recomp tool itself plus some custom code with no art or UI can go on there classed the same as an emulator, launcher, or tool, I would like my first question answered the most out of the 2, the second was just an unlikely afterthought since Steam could then hold the save and maybe even rom so we don't have to manually transfer between devices.
Thanks

No, this will never happen.

No, this will never happen

My first question was about the developers of the original games, say for example the Croc remaster was built off of a recompiled version of Croc made with N64RECOMP, would that be legally OK to put on Steam?


(403) Forbidden Error when using Create Online Dev. Environment

I am receiving an error when trying to create a  new online environment, even though the app authentication is a success. The following is the log from the step Create Developer Environment:
Run<EMAIL_ADDRESS>Run try { D:\a\_actions\microsoft\AL-Go-Actions\v2.4\CreateDevelopmentEnvironment/CreateDevelopmentEnvironment.ps1 -actor $ENV:_actor -token $ENV:_token -parentTelemetryScopeJson $ENV:_parentTelemetryScopeJson -environmentName $ENV:_environmentName -adminCenterApiCredentials $ENV:_adminCenterApiCredentials -reUseExistingEnvironment ($ENV:_reUseExistingEnvironment -eq 'Y') -directCommit ($ENV:_directCommit -eq 'Y') } catch { Write-Host "::Error::Unexpected error when running action ($($_.Exception.Message.Replace("`r",'').Replace("`n",' ')))"; exit 1 }

Cloning into 'cicd-test'...
Switched to a new branch 'uci44hvp.ml4'
Downloading BcContainerHelper latest version from CDN
BcContainerHelper version 4.0.14
BC.HelperFunctions emits usage statistics telemetry to Microsoft
Reading .AL-Go\settings.json
Analyzing repository
Checking project dependencies
Checking appDependencyProbingPaths
...........
Authenticated from 172.177.[188](https://github.com/cegekaJG/cicd-test/actions/runs/4543928614/jobs/8009362958#step:7:190).107 as user ********<EMAIL_ADDRESS>Authenticated to common, using tenant id 42151053-0193-47aa-9e81-effd81f772cc
Error: CreateDevelopmentEnvironment action failed. Error: The remote server returned an error: (403) Forbidden. Forbidden  (ms-correlation-x = 0576d82a-69ba-38c6-5430-b4eff0db1f1f) Stacktrace: at Get-BcEnvironments, C:\Users\runneradmin\AppData\Local\Temp\1ce72797-9913-462f-a2c5-cfc2321a265a\BcContainerHelper\Saas\Get-BcEnvironments.ps1: line 32 at CreateDevEnv, D:\a\_actions\microsoft\AL-Go-Actions\v2.4\AL-Go-Helper.ps1: line 1621 at <ScriptBlock>, D:\a\_actions\microsoft\AL-Go-Actions\v2.4\CreateDevelopmentEnvironment\CreateDevelopmentEnvironment.ps1: line 40 at <ScriptBlock>, D:\a\_temp\5818f785-df57-4dff-982c-84468e224265.ps1: line 2 at <ScriptBlock>, <No file>: line 1
AL-Go action ran: CreateDevelopmentEnvironment Telemetry Correlation Id: a58b1bc6-3bdf-4e02-9126-ee38eff48ccf
Removing BcContainerHelper
Error: Process completed with exit code 1.

If looks like the user used for the authentication doesn't have access to get environments???
How did you create the authentication context?

I get prompted to enter my credentials with the regular login window. I know the username and password are valid because I can use them to create a container with Windows authentication using BcContainerHelper directly.

Does your Windows Credentials have access to the Business Central Admin Center?
Maybe we should setup a Teams call ?
It seems like you have some challenges, which we might be able to resolve faster this way.
If you invite freddyk at microsoft dot com on Friday 10:00 or 11:00 - then we can maybe get to the bottom of things?

Friday should work, thanks.

Oh, my mistake - I've sent you an invite.

I'd like to reopen this issue, as it's still occurring for me.
All apps and test apps will be compiled and published to the environment in the development scope.
The script will also modify launch.json to have a "Cloud Sandbox (<name>)" configuration point to your environment.

Environment name
----------------
Please enter the name of the environment to create (default J******-sandbox) ******-sandbox
******-sandbox selected

What if the environment already exists?
---------------------------------------
a Recreate environment
b Reuse existing environment

Select behavior (default a)
Recreate environment selected

Downloading BcContainerHelper latest version from CDN
Using 7zip
BcContainerHelper version 5.0.1
BC.HelperFunctions emits usage statistics telemetry to Microsoft
Running on PowerShell 7
Checking type
Checking appFolders, testFolders and bcptTestFolders
Application Dependency <IP_ADDRESS>
Updating app- and test Dependencies
Analyzing Test App Dependencies
Checking project dependencies
Checking appDependencyProbingPaths
WARNING: No test apps found in testFolders in .AL-Go\settings.json
WARNING: No apps found in appFolders in .AL-Go\settings.json
Repository is empty
Attempting authentication to https://api.businesscentral.dynamics.com/user_impersonation offline_access using device login...
To sign in, use a web browser to open the page https://microsoft.com/devicelogin and enter the code ****** to authenticate.
Waiting for authentication.....
Authenticated from <IP_ADDRESS> as user J******<EMAIL_ADDRESS>Authenticated to common, using tenant id 42151053-0193-47aa-9e81-effd81f772cc
Get-BcEnvironments Telemetry Correlation Id: e8b56a86-f691-46ab-a8e3-4031cb298371
Removing BcContainerHelper
Error: Response status code does not indicate success: 403 (Forbidden).
Stacktrace: at Get-BcEnvironments, C:\Users\J******\AppData\Local\Temp\d5541b9b-dd2c-434f-bd89-050cb8f03560\BcContainerHelper\Saas\Get-BcEnvironments.ps1: line 44
at CreateDevEnv, C:\Users\J******\AppData\Local\Temp\tmp772D.tmp.ps1: line 1637
at <ScriptBlock>, C:\Users\J******\Documents\clients\Cilit\CLT.Base\.AL-Go\cloudDevEnv.ps1: line 75
at <ScriptBlock>, <No file>: line 1

If you use the latest BcContainerHelper and run this code locally:
$authContext = New-BcAuthContext -includeDeviceLogin
Get-BcEnvironments -bcAuthContext $authContext

What happens?
Do you get a list of your environments?

The problem is likely that you have a secret, where the value is your username.
Do you know which secret this is?

What happens? Do you get a list of your environments?

No, I am getting the same error as before. And this repository's only secret is that of the GitHub workflow token.

OK, so you manually replaced your user name with J****** ?
The credentials you are using, is that the AAD credentials, which gives you access to The Business Central Admin Center?

Yes, I replaced it manually.
Reading the guide again, it says that step #7 has to have been completed. Does that mean it's not possible to create a sandbox using AL Go without an Azure Keyvault?

like:

Likely this URL: https://businesscentral.dynamics.com/42151053-0193-47aa-9e81-effd81f772cc/admin

Okay, I don't have permission. I'll try a different account.

Which is likely the reason for this error:
Error: Response status code does not indicate success: 403 (Forbidden).


Cancel Action Button to Close Notifications

Is your feature request related to a problem? Please describe.
There isn't a direct cancel button to exit the notification. I know with both button arguments you can create custom actions for them.
Describe the solution you'd like
A button_cancel argument that executes to cancel/exit/close the notification.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Said argument should have the system notification to exit out.
Additional context
Add any other context or screenshots about the feature request here.

Maybe make them alert style notifications.

That's not quite how notifications work.
You have control over the notification type so you can make it alert or banner style as you see fit, either manually or with a config profile.
v 2.4 has notification actions which can perform an action based on what options is selected. Clicking a notification or selection an action dismisses the notification. what happens after that depends if you have defined any actions to take.

I just realized that 2.4.0 is still in beta. I'm on 2.3.3

I just released 2.4 as the latest version (same build as RC 1)
there's no built in "make a noise" functionality. If you want to do that then you will need to play a sound or something as part of your script.

Sure thanm you. I wanted to confirm since i believe dialog is silent by default. Wanted to confirm it doesnt play sounds or if it did if there was a setting for it.

Not intentionally 🙂

No worries, would be good to have, especially for sending out important system notifications. On another note, is the --notification argument a boolean or a string?

--notification is a bool condition that causes swiftDialog to send message, title etc as a system notification instead of as a pop up dialog.


Remove support for .NET 6

Description
This PR removes multi-targeting against .NET 6. This means that from now on, Steeltoe requires .NET 8 or higher.
Aside from that, several small refactorings were applied. See the commit messages for details.
Closes #1249
Closes #1123
Quality checklist

[x] Your code complies with our Coding Style.
[x] You've updated unit and/or integration tests for your change, where applicable.
[ ] You've updated documentation for your change, where applicable.
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
[x] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
[x] You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

/azp run Steeltoe.All

/azp run cleanup-code


V3 updates

Any chance at updating this for V3? If not I can clone it and make the updates and send a PR, but it looks like they changed quite a bit.

Hey!
I probably won't be updating it any time soon unfortunately, but would happily look over and merge a PR. I don't actively use this lib anymore, but would love to see it updated. Maybe I'd get to it someday, but it isn't something I have planned anytime soon.

I am doing it right now :)


Feature: Digital Clock in Java

Is your feature request related to a problem? Please describe.
Create a digital clock in Java
Describe the solution you'd like
Create a clock that changes every second like a real digital clock

Please assign it to me?


Environment don't loaded

🐞 Bug report
Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [x] config
- [ ] help
- [ ] version
- [ ] doc

Description
I have three environment whit this properties
environment.ts
HASVIDEOCALL: {
    VIDEOCALLURL: 'https://trial.herokuapp.com'
  },
environment.prod.ts
HASVIDEOCALL: {
    VIDEOCALLURL: 'https://trial.herokuapp.com'
  },
environment.costumer.ts
HASVIDEOCALL: false

in angular.json I have
        "costumer": {
          "fileReplacements": [
            {
              "replace": "src/environments/environment.ts",
              "with": "src/environments/environment.hasis.ts"
            },

And use this variable in some service like opentok.service.ts with this:
  getSessionConfig(room) {
    if (environment.HASVIDEOCALL) {
      let url = environment.HASVIDEOCALL.VIDEOCALLURL + '/room/' + room;
      return this.http.get(url);
    }
  }

And now I try to start this enviroment with this:
ng serve --configuration=costumer
but the Terminal says:

src/app/services/opentok.service.ts(21,42): error TS2339: Property 'VIDEOCALLURL' does not exist on type 'true'.
i ｢wdm｣: Failed to compile.

But as you can see, the type its not true.
An still more extrange it's if I modify any file, only with a console.log, when I save it, automatically rebuild the app and it's works without problems.
Do you know how it happens?
So sorry if this is not the forum to ask for it, but I thought this is a bug...

This is expected as TypeScript won't allow that and type-checking will fail during compilation. The type of HASVIDEOCALL  is indeed true in this case. This is because when replacing the file the source code will look like;
As the replaced source will look like;
const environment = {
  HASVIDEOCALL: false
}

if (environment.HASVIDEOCALL) {
  let url = environment.HASVIDEOCALL.VIDEOCALLURL;
}

Closing as this is working as expected.
This issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular-cli.
If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.


Envoy /stats/prometheus?filter not working with prometheus due to url percent encoding.

When a prometheus job is configured to scrape envoy using filter query arg, it sends the requests with the params url percent encoded:
GET /stats/prometheus?filter=upstream%7Cdownstream HTTP/1.1
Host: X.Y.Z.Q:8524
User-Agent: Prometheus/2.15.2
Accept: application/openmetrics-text; version=0.0.1,text/plain;version=0.0.4;q=0.5,*/*;q=0.1
Accept-Encoding: gzip

upstream%7Cdownstream doesn't get urldecoded properly and no metrics are returned.
upstream|downstream works fine, but prometheus can't be configured to not url percent encode the params from its scrape requests.
I'm willing to work on this if it's considered a bug and not expected behaviour. Assuming there already are some bits that do urldecoding in envoy, i think it's approachable even for someone that doesn't know c++ well (me).
Later edit:
use case: On large enough envoy deployments, we can't fit all the metrics we get from all envoys on just one prom box without eventually trashing it. So we're forced to rely on stats filtering so that each prom sees just a subset of the metrics. The lack of url decoding for |-based regex filters forces us to do quite a few unnecessary scrape jobs and various workarounds.

I'm not sure we have URL decoding anywhere, but it's definitely not happening in the handler from prom stats.

This is really a problem as we use envoy as the ingress proxy in a large kubernetes cluster. Thousands of endpoints are registered to envoy so the statistics of them are so many, make it takes too much time for prometheus to pull all the metrics. We use the 'filter' parameter to filter the statistics on the envoy side so that it can lower the duration of pulling.
However, the value of request query parameters from prometheus is urlencoded, and envoy does not recognize it:
# without urlencode, got response from envoy
curl -s '<IP_ADDRESS>:10002/stats?filter=(cluster.upstream_(rq_total|rq_time_sum|rq_time_count|rq_time_bucket|rq_xx|rq_complete|rq_active|cx_active))|(server.version)'
cluster.dynamic_forward_proxy_cluster.upstream_cx_active: 0
cluster.dynamic_forward_proxy_cluster.upstream_rq_active: 0
cluster.dynamic_forward_proxy_cluster.upstream_rq_completed: 0
cluster.dynamic_forward_proxy_cluster.upstream_rq_total: 0
cluster.envolve_mate_cluster.upstream_cx_active: 0
cluster.envolve_mate_cluster.upstream_rq_active: 0
cluster.envolve_mate_cluster.upstream_rq_completed: 0
cluster.envolve_mate_cluster.upstream_rq_total: 0
cluster.envolve_xds_cluster.upstream_cx_active: 1
cluster.envolve_xds_cluster.upstream_rq_active: 1
cluster.envolve_xds_cluster.upstream_rq_completed: 2
cluster.envolve_xds_cluster.upstream_rq_total: 1
cluster.local_envoy_admin_cluster.upstream_cx_active: 10
cluster.local_envoy_admin_cluster.upstream_rq_active: 2
cluster.local_envoy_admin_cluster.upstream_rq_completed: 22
cluster.local_envoy_admin_cluster.upstream_rq_total: 24
cluster.local_envoy_http1_cluster.upstream_cx_active: 0
cluster.local_envoy_http1_cluster.upstream_rq_active: 0
cluster.local_envoy_http1_cluster.upstream_rq_completed: 0
cluster.local_envoy_http1_cluster.upstream_rq_total: 0
cluster.local_envoy_http2_cluster.upstream_cx_active: 0
cluster.local_envoy_http2_cluster.upstream_rq_active: 0
cluster.local_envoy_http2_cluster.upstream_rq_completed: 0
cluster.local_envoy_http2_cluster.upstream_rq_total: 0
server.version: 6166960

# no response with urlencode
curl '<IP_ADDRESS>:10002/stats?filter=%28cluster.upstream_%28rq_total%7Crq_time_sum%7Crq_time_count%7Crq_time_bucket%7Crq_xx%7Crq_complete%7Crq_active%7Ccx_active%29%29%7C%28server.version%29'

It is very helpful if someone can fix this or give some suggestion to make prometheus not to send request with urlencode.


copy/paste keyboard shortcuts not working in Decker web editor

open any text area in Decker web and select some text
shortcuts ^c/^v/^x do not work for the selected text.

In what browser/OS?

firefox/windows

From the manual,

Copying, cutting, and pasting from the keyboard must be done using the native OS/Browser keyboard shortcuts. Copying and pasting using the menus may require you to confirm the action with a browser modal. When pasting via the keyboard, it may be possible to paste images and sounds from the OS clipboard. Clipboard access is very flaky and inconsistent between browsers: Web-Decker tries several strategies to interact with the OS clipboard, but if nothing works it will store clipboard contents in a local window-only clipboard instead, accessible via the browser console as the local_clipboard variable.

In my experience, Firefox has the worst/flakiest clipboard support of any browser I've tested. Command+C/V/X seem to work for Firefox in OSX.

Can you copy and paste within Decker, but not interact with the system clipboard?
Does copying and pasting from menus work?
Do you get anything suggesting an error in the JS console?
Is local_clipboard set JS-side after a copy?
Are you running any browser plugins which could potentially interfere with Decker?

ok, did some more testing.
keyboard shortcuts also do not work in Chromium and Edge (no plugins).
using the menu to copy sets the local_clipboard variable
using the menu to paste shows the external clipboard after accepting the modal in Chromium/Edge (no modal in Firefox)
no errors in JS console

This really threw me for a loop, but I think I tracked it down; In OSX keyEvent.metaKey is set for cut/copy/paste events, but on Windows it's keyEvent.ctrlKey. Naturally, the one place I forget this is the source of my woes.

yep, that fixed it. thanks.

Thanks for reporting. Given the severity of the problem I'm very surprised this wasn't found earlier.


[Question] Adldap\Auth\BindException: Can't contact LDAP server get Host

Laravel Version: 5.7
Adldap2-Laravel Version: 5.1.1
PHP Version: 7.3
LDAP Type: ActiveDirectory

Hi,
I'm using Adlap2-Laravel to provide some kind of self-service, which allows users to unlock their accounts.
We're using 12 Domain Controllers accross different locations, so I have written a Job to Unlock Users.
I'm looping over an array of DC Hosts and dispatch a Job for each host. Sometimes I see a Adldap\Auth\BindException: Can't contact LDAP server in the failed_jobs table.
But the Exception doesn't specify which Host failed.
Any idea how to get the Host which failed?

Hi @HepplerDotNet, unfortunately not in the current release, but you will be able to in the next major release of Adldap2-Laravel (v6.0) which is coming in a couple weeks (on vacation at the moment until March 4th).
Logging is included with Adldap2 v10.0 which will be included with v6.0 of Adldap2-Laravel. You will also be able to register listeners on LDAP binding events to perform your own logging or logic depending on what occurs:
https://adldap2.github.io/Adldap2/#/events
I'll leave this open and close once this v6.0 has been released.

v6 has been released. You can now register a listener to retrieve the host / connection of the binding failure:
$dispatcher = \Adldap\Adldap::getEventDispatcher();

$dispatcher->listen(Binding::class, function (Failed $event) {
    $event->connection->getName(); // Returns 'default'
    $event->connection->getHost(); // Returns 'ldap://<IP_ADDRESS>:389'
});


Fix database migration versions table

What was the error?

Oh duplicate rows

Wait, was that the problem?

---- db_migrations::tests::test_migration_versions stdout ----
thread 'db_migrations::tests::test_migration_versions' panicked at 'assertion failed: (left == right)
left: Some(1),
right: Some(0)', src/db_migrations.rs:99:8
---- db_migrations::tests::test_multiple_migration stdout ----
thread 'db_migrations::tests::test_multiple_migration' panicked at 'assertion failed: migrate(&mut conn).is_ok()', src/db_migrations.rs:109:8

Yeah, I kinda expected REPLACE to work... but it wasn't doing what I expected...

There was basically nothing to trigger a conflict that would result in a replace. Could have also added an "id" primary key column or something that was always "1".  /shrug