WIP: Replace Scala parser combinators with fastparse

Pull Request Description
This PR replaces Scala parser combinators with fastparse.
Here's a comparison of fastparse to other parsers. In benchmarks it is 2-300x faster than Scala's own parser combinators.
Important Notes

I only saw the PR which seems to introduce a new parser after doing the code changes, so I'm not sure if this PR is still relevant at all...
The PR is WIP, as most tests don't yet pass. I'll comment once they do.

Checklist
Please include the following checklist in your PR:

[ ] The documentation has been updated if necessary.
[ ] All code conforms to the Scala, Java or Haskell style guides as appropriate.
[ ] All code has been tested where possible.

Thank you so much for your interest and contribution, Martin. I’m very sorry to say that the parser that this replaces was only ever intended for preliminary testing while we waited for the proper parser to land, so this work is essentially obviated now. Work is currently ongoing to integrate the new parser as the front-end to a flexible static transformation framework, so this temporary parser will be gone in the next few weeks.


Enforce HTTPS

Currently manually typing and entering jupyter.org in the browser address bar might sometimes redirect to http://jupyter.org instead of https://jupyter.org :
jupyter-org-https.webm
It would be nice to enforce HTTPS by default.
Normally this can be done via the repo settings. I don't have access to the settings of this repo, but this is what it looks like with another repo:

Of note some browsers like Firefox might upgrade to HTTPS automatically:

thanks @jtpio , done!


Logs are Empty

It better say it is testing with xyz param and also found no tests etc..

Can you pl. share how to configure log level so that if I increase log level, would it print more clues on why no tests are run

Please follow the HelloWorld example repo.
Clone and run the tests locally, you should be fine with logs etc there.
You can control the logs from logback XMl file. See the examples


onnxruntime_genai.onnxruntime_genai.OrtException: Non-zero status code returned while running GroupQueryAttention node. Name:'/model/layers.0/attn/GroupQueryAttention' Status Message: cos_cache dimension 1 must be <= head_size / 2 and a multiple of 8.

I built onnxruntime_genai from source with the cuda execution provider then installed the python wheel.
I tried to run the model microsoft/phi-2 but it seems there is a problem with the GroupQueryAttention node.
Here is the command to build the phi-2 model from Hugging Face :
python -m onnxruntime_genai.models.builder -m microsoft/phi-2 -e cuda -p int4 -o ./example-models/phi2-int4-cuda
Here is the python code to reproduce the error :
import onnxruntime_genai as og
import time

prompt = '''def is_prime(n):
    """
    Determine if n is prime or not
    """'''

model=og.Model(f'example-models\phi2-int4-cuda')

tokenizer = og.Tokenizer(model)

tokens = tokenizer.encode(prompt)

params=og.GeneratorParams(model)
params.set_search_options(max_length=100)
params.input_ids = tokens

start_time = time.time()

output_tokens=model.generate(params)[0]

end_time = time.time()

text = tokenizer.decode(output_tokens)

print(text)

Here is the error that I obtain :
onnxruntime_genai.onnxruntime_genai.OrtException: Non-zero status code returned while running GroupQueryAttention node. Name:'/model/layers.0/attn/GroupQueryAttention' Status Message: cos_cache dimension 1 must be <= head_size / 2 and a multiple of 8.

OS : Windows 10
Architecture : x64
Language : Python
Onnxruntime version : 1.17.1
Onnxruntime_genai version  : 0.3.0-dev
Cuda version : 12.3

Hi, can you please try with ONNX Runtime version 1.18.0?
https://github.com/microsoft/onnxruntime/releases/tag/v1.18.0

Thank you @natke , that solved the issue.


ObjectEnum from protocollib has been refactored and causes ClassDefNotFoundErrors

https://github.com/aadnk/ProtocolLib/commit/1be94aad784913aa8b85d7733491461b446d69b0#diff-0333981e516a8aa0251a04d986666843 is the commit where it changed.

This issue should have been fixed with the latest MundoSK BETA versions. If it is still occurring, please post the specific error you are receiving.


Fix SIGSEGV when client subs to multiple fields

This fixes a SIGSEGV panic which can happen when a client attempts to subscribe to more than one field.

@pavelnikolov Would you consider merging this? It's a simple fix and it's all tested and ready to go :)


Handle conflicting autofix instructions

If we have a line like:
x: Union[int, Option[str]]

Then if the relevant rules and Python version permit it, we'd like to autofix that line to:
x: int | str | None

However, as-is, that requires two overlapping fixes, which we don't support. So Ruff will fix the outer rule (to x: int | Option[str]), then fix the inner rule if you re-run it (x: int | str | None).
We need to implement an autofix strategy that's amenable to multiple "concurrent" fixes.
This will also apply to import sorting: we want to be able to remove unused imports and re-sort imports in a single pass.

I don't know how to implement this yet. I need to do some research. But a few ideas come to mind:

Structure it as a CRDT-like concurrent editing problem. Use CRDTs or similar to enable us to reconcile these kinds of concurrent edits.
Re-write rules to batch these changes. For example, above, maybe we just surface a single error with the autofix for the entire expression, rather than emitting an error for Union and an error for Option. This is pretty limiting, as it wouldn't work for (e.g.) the unused import + re-order import case.
Make the fix API more AST-aware? Enable some kind of composition semantics, such that if we know we're replacing a list of Statements with a list of Statements, then we should allow any edits of the form Statement -> Statement.

Have you worked with LibCST? I like how that handles modification to the ast/cst. Basically you implement a visitor that takes two nodes as input, node and updated_node, and returns a node. The node parameter is the parsed node from source and the updated_node parameter is the output from the previous visitor. So depending on the rule you can decide to consider previous modifications or not completely ignore them.
I also think that would work fine for the example above here. You could have two visitors; one that does Optional[X] -> X | None and a one that does Union[A, B] to A | B. It wouldn’t really matter what order these are run in, the output should always be the same. Either Union[A, Optional[B]] -> A | Optional[B] -> A | B | None or Union[A, Optional[B] -> Union[A, B | None] -> A | B | None
This would probably not fix the remove unused import issue, though that could maybe be considered a separate issue? If I’m not mistaken libcst handles that through a special hook where you can mark imports as unused/potentially unused after a modification has been made. I assume those imports are then removed in a second pass, which could run before the sorting runs

Yeah! We use LibCST internally to power some (not all) of our autofix operations. However, I think that LibCST's visitor API is entirely defined on the Python side, so I haven't used it before (we just use the CST parser and the ability to generate code from a modified CST struct)...
I do like what you're describing here. The main challenge, as-is, is that we don't actually create a CST for every module -- we create them eagerly, since CST generation is quite expensive. When we want to autofix something via LibCST, we extract the source code (using the delimiters defined by the AST), pass it to LibCST, generate the modified source, and then treat that source-to-source replacement as the "fix".
In other words, as-implemented, the individual fix operations have access to a CST, but there's no concept of passing the modified code or CST from check to check. (That's not to say we can't use this approach; rather, that it would take work.)
I do think we probably need to do something AST-aware (or CST-aware) in order to solve this problem.

In the Union[A, Optional[B]], another way to look at it would be as a series of sequential edits.
So, to get rid of the Union:

"Remove Union[
"Retain A"
"Remove ,"
"Insert  |"
"Retain  Option[B]"
"Remove ]"

Then, to get rid of the Option, you do a similar thing.
If fixes were defined as those kinds of atomic operations, I believe you could reconcile them using CRDT-like operations. But it may not apply as cleanly to over kinds of collisions.

Ah, then I'd misunderstood how ruff works. I naively assumed it built up a cst of the source code and then traversed that. As a developer that's at least an interface that is great to work with and one benefit is that you can share a lot of code between linting and fixing.
The visitor pattern in libcst is indeed implemented in Python. It's documented here and basically mirrors the visitors from the ast library with extensions for modifying the tree.

The way that pyupgrade handles this is somewhat interesting. They have a roundtrip tokenizer, and they implement all fixes as lazy transformations on the token stream. I don't see how that's completely safe, but it does work for the cases they implement.

Hmm, does it have to be lazy?
My (new) understanding is that ruff builds up an ast of the file being checked, if that's correct it would be great to be able to build both checkers and fixers on top of the ast.
If we can keep both the tokens and the ast in memory and link them, then it should based on my naive understanding be possible to use the ast to detect where changes are needed, get the tokens for that ast and update them, and then based on the updated tokens update the ast representation again.
I'm a bit rusty when it comes to compiler theory, but I assume the ast is built up from the tokens, so we should have everything available. The hard part here would probably be to deal with certain things that don't map direly to ast nodes like white space, commas etc

Maybe we just want to apply a non-conflicting subset of the fixes, then repeatedly rerun the entire linter on the file until it converges?
I doubt we’re ever going to be able to guarantee that enough operations commute to make any other strategy work correctly.

Yeah, I think that's very likely what we'll have to do.


fix the error in README and docker_compose

Type of Change
fix the error in README and docker_compose
Description
modified two files:

README.md
docker_compose.yaml in ChatQnA/microservice/xeon/

Thanks for your PR, those issue has been fixed in main branch.


Max memory setting ignores container overhead

When I set a memory limit for Redis pods using the provided redis-cluster chart, it appears to take the exact number I provide for the memory limit and place that in redis.conf on the maxmemory line.  This neglects the overhead of Redis itself, the redisnode executable, and any other miscellanea that Kubernetes includes in its overhead accounting.  In my setup, this adds up to about 40 MB that the container will use beyond Redis's memory limit.  Thus, when Redis approaches capacity, the container's memory usage exceeds its configured resource limit, and Kubernetes kills the pod.  I've been working around this by manually updating Redis's maxmemory to 100 MB less than the resource limit, which solves the problem.  It would be nice if this could be automated so that resource limits work as expected.

@showermat unforutnately the operator will need to do much better than that for long-term stability. Redis admin docs specify:

If you are using Redis in a very write-heavy application, while saving an RDB file on disk or rewriting the AOF log Redis may use up to 2 times the memory normally used. The additional memory used is proportional to the number of memory pages modified by writes during the saving process, so it is often proportional to the number of keys (or aggregate types items) touched during this time. Make sure to size your memory accordingly.

So for 100MB of data capacity in Redis, you'll need to specify 200Mi in the k8s resource limit, and potentially 240Mi as per your use-case to be 100% safe. If you need 1GB of data capacity then the scale remains (1GB -> 2GB), but the overhead (~40MB) is pretty consistent.
Unless you're going crazy with writes you're probably okay with simple doubling for your resource limit, since that will allow for the binary overhead and will have spare capacity padding for approximately doubling the touched-keys allocations.


Failed to set the 'innerHTML' property on 'Element': This document requires 'TrustedHTML' assignment.

Describe the bug
There are some suspicious errors in the developer tools
To Reproduce
Steps to reproduce the behavior:

In Chrome/Chromium-based browser
Open DevTools

Unhandled rejection: TypeError: Failed to set the 'innerHTML' property on 'Element': This document requires 'TrustedHTML' assignment.
Expected behavior
I don't think it is normal behavior, but I can't know what is broken...
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: MacOS
Browser [e.g. chrome, safari] Arc (Chromium Engine Version 129.0.6668.59)
Version [e.g. 22]

Additional context
Seems related to https://developer.mozilla.org/en-US/docs/Web/API/Trusted_Types_API
I think it is possible to just bypass those like this userscript: https://greasyfork.org/zh-CN/scripts/433051-trusted-types-helper/code

@codehz Thank you for reporting the issue. I have known about this for a while it has to do with the hide scrollbar feature. I'm going to fix it eventually.


Option for data default with full country name?

Hi I also noticed that I cannot use full country name in data default, can it be added in this script like data-default="Denmark" ? :)

No, you'll need to "translate" your name into a ISO_3166-2 country code like e.g. "DK".


Retry should only resubmit idempotent methods with pure bodies

Retry middleware should never resubmit a POST or other non-idempotent methods.
Retry middleware should only resubmit if it can verify that the body is pure.  Code for this already exists in FollowRedirect, which we can abstract out.  Right now, it just blanks out the body, which is bad.

I imagine this is all binary compatible and suitable for release-0.14.x.

the other thing I feel is missing from Retry is when to retry since the function you can pass only takes an Int .... it can't inform if retry should be done for example ... if you get a 400 ... you shouldn't retry

I think this is not binary compatible, but also a good idea.

Was this broken the last time that retry logic was touched? I recall discussing why the body was examined to determine if it was a halt.

I think that discussion was on the follow redirect?

Yeah, your probably right.
On Sep 16, 2016 12:57 PM, "Ross A. Baker"<EMAIL_ADDRESS>wrote:

I think that discussion was on the follow redirect?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/http4s/http4s/issues/712#issuecomment-247693944, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACz9mqCTWzUjgaSeQGZUQlf4VyZaKLKpks5qqvSegaJpZM4J_NfP
.

We should also be honoring the Retry-After header.

Retry-After is now honored.
I think we should be checking the idempotence of the method, but not the purity of the body.   We should assume and document that rerunning the body stream is idempotent.  I think unsafeRetriable should be the default behavior.  Of course, it's all parameterized now, because needs vary.

This got support for the IdempotencyKey header and more customizable policies.  Closing.

Though maybe this has interesting interactions with #4509, which does allow the detection of pure bodies. :thinking:

This issue was addressed in #6379.


data url cannot work

Hi, there!
#1
i found something very strange when i downloaded the arctic-viewer with npm i -g arctic-viewer. And something goes wrong when i typed http://tonic.kitware.com/data/head-ct. The error info is shown as follows:
Got error: getaddrinfo ENOTFOUND tonic.kitware.com

So i entered the source code files to find an answer. The url address in the source code is as follows and i entered every links in the code but the url address seems to be expired.
[
...
  {
    "title": "Diskout Ref - Composite",
    "filesize":"40 MB",
    "thumbnail": "http://tonic.kitware.com/arctic-viewer/diskout-composite.png",
    "url": "http://tonic.kitware.com/arctic-viewer/diskout-composite.tgz"
  }
...

#2
i typed mkdir ArcticData && cd $_ and ArcticViewer --download-sample-data in the cmd shell and wanna download one of the sample datasets kitware offered. But when i entered the number 4 and pressed the Enter. There is no response in the cmd no matter how many times i pressed the Enter

These are some errors i found when i was developing a vis app. it's very nice of you if you can reply me and give some solutions.
Thanks!

Besides, my os is win10

Sorry about that, we turn-off the sever that was serving some sample file. Although, you can find them here:
https://github.com/Kitware/arctic-viewer/issues/36


Testimonials & Milestones added

Fixes Issue

Changes proposed
Update Profile

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers
Review this and help me to update this to my profile

Let it be merged

Let it be merged

@RockingSNP writing this is not necessary. All maintainers receive notifications - please do not forget that maintainers are in different timezones and have other commitments.
I will merge your Pull Request but the point of Testimonials is not to give one to yourself, but to give one to other members of the community.  You may want to take a look at our Testimonials docs here: https://linkfree.eddiehub.io/docs/how-to-guides/testimonials

Let it be merged

@RockingSNP writing this is not necessary. All maintainers receive notifications - please do not forget that maintainers are in different timezones and have other commitments.
I will merge your Pull Request but the point of Testimonials is not to give one to yourself, but to give one to other members of the community.  You may want to take a look at our Testimonials docs here: https://linkfree.eddiehub.io/docs/how-to-guides/testimonials

Yes, next time I'll keep that in mind. & Thank You!


Neofetch colors don't withstand resize

Environment
Windows build number: Microsoft Windows [Version 10.0.18362.959]
Windows Terminal version: 1.1.2021.0
WSL: Debian GNU/Linux 10 (buster) on Windows 10 x86_64

Steps to reproduce

install neofetch on WSL Debian
run neofetch
resize the Windows Terminal window

Expected behavior
Colored boxes are part of the neofetch output, and appears correctly.
If you resize the windows they correctly stay displayed.
Actual behavior
Colored boxes are part of the neofetch output, and appears correctly.

But if you resize the windows they vanish instantly...

Oh man, you've stumbled across one of the oldest bugs in the console: #32
There's more info in #4300:

Since the console buffer can't know the difference between "no character" and "space", when the console buffer resizes, it doesn't know to copy that color information over.

/dup #32

My bad, I tried the resize and neofetch keywords without luck, so I posted the issue.

No problems! That one's fairly tricky to find in the list of issues ☺


chore: Set snippet-bot alwaysCreateStatusCheck to true

So snippet bot will submit a status check

Caveat:
We changed a default value of snippet-bot's config aggregateChecks to true.
This means, snippet-bot is submitting one single check named snippet-bot check. If you want to use it in branch protection rule, please use that one.


[mgmt] kubernetesconfiguration release

https://github.com/Azure/sdk-release-request/issues/4466

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-arm-kubernetesconfiguration


Listing Duplication - Front End

As a user in the Doorway Partners Portal,
I want to be able to copy a listing I have access to,
So that I can easily pull over information (like, units) from existing listings
Notes:

Design
You should be able to copy a listing in any status, but the copy should default back to draft and be required to go through the approval process.
This ticket should handle the FE work of this feature.

AC:

Listing Duplication tab here

QA Notes: https://partners.staging.housingbayarea.mtc.ca.gov/sign-in
Select any listing, clicking copy, and ensure that the form matches the design above, requires an original name and the includeUnits checkbox appropriately determines the copied listing result.

Do we want to extend this validation to all name fields (ie, no one can create a listing with a duplicate name)

Ideally, but maybe out of scope
Can the only check be that the name of the listing is the same as the listing being copied?
Yes
If this applies to all listings and types, should lottery results be carried over
No, no app or lottery

Split into two tickets - BE work & FE work

BE - will need to do some data cleanup as a part of the copying, since there are some fields that won't apply. Not complicated, per se, but time consuming. We can't just be like "get me the listing" because  some stuff isn't needed
FE - more minimal, call with the listing id, new name, units flag

do this in core and pull it over

Some AC updates and further details:
In Doorway:
All user types should be able to copy a listing
ONLY admins should be able to edit a closed listing
There should be no option, for any user type, to reopen / republish a listing.
In Core:
Only admins and jurisdictional admins should be able to copy a listing
Any user type should be able to to reopen / republish a listing (the partner experience should stay the same as it is rn).
Doc Showing Partners Portal Button Options: https://docs.google.com/document/d/1y0xn59Juc2sjmGUXnTHnh1sbpE29i_ob4qy1TCz7W4o/edit

Ok, looked into this in Core and Doorway, and just noticed one thing in HBA. I'm not seeing "reopen" as an option on closed listings for jurisdictional admins or Partners - see example here

Another few things to discuss before releasing -

Noticed that the "Published date" on some open listings is "None." How is that possible?

I noticed that if the listing has the same name as the original + a space character, it counts as unique. So I could have "Sarah Listing" and "Sarah Listing " as two listings since the name is technically unique but it looks the same otherwise. I wonder if we should trim the space there?

Update on reopen / republish behavior for HBA - Any user type should be able to to reopen / republish a listing


Breaks DelayedJob and Resque

What is the nature and/or behavior of this issue?

This breaks DelayedJob and Resque for some weird ActiveSupport reason.

(I am experiencing an unusual behavior and wondering if this issue may be related)

Hmm I honestly can't remember. I think I commented that out to get some tests to run but it was a long time ago!


Eval and Binding not working on nested styles

We only support data evaluation and binding on the first level of a widget's styles. Need to support nested expressions also.
e.g.
Column:
  styles:
    backgroundImage:
      source: ${myUrl}background.jpg
      fit: ${fitVariable}

Either changes to URL or fitVariable need to reload the backgroundImage.

This has been completed. Closing.


feat: copy button on yaml configuration parts

Closes DOC-309

Enable users and support staff to quickly copy vCluster-config YAML from config sections.
Makes it easier to work with configurations by allowing copy-paste, helping users get started with vCluster more efficiently.

Config reference Preview
Short clip showing how to use the feature

I see a copy button already on all yaml sections even before this change. I am not sure what we're adding.

Can you show me where you can see the copy button on the config reference here?


High Enery Lab: wrong probe launch speed

In pancake mode the probe launcher is equipped automatically because of an interaction zone (I think?). This makes the probe launch slower. In VR this isn't happening.

Fixed by #237


Fix code signing

This does indeed commit the strong name private key to the repo. According to MS docs strong name signing doesn't really do anything, and this is the recommended approach for open source projects.
The nuget packages need to be signed on windows, hence the two-stage build.

@einarmo do you have a link that explains it a bit more? especially the part that says that committing the key is ok

Strong name signing essentially doesn't do anything anymore, it's an old thing that doesn't really apply, but some customers require it, despite it being functionally useless.
It also can make it impossible to make a reproducible binary, which is problematic for open source, so microsoft recommends just committing the key:
https://learn.microsoft.com/en-us/dotnet/standard/assembly/strong-named

If you are an open-source developer and you want the identity benefits of a strong-named assembly for better compatibility with .NET Framework, consider checking in the private key associated with an assembly to your source control system.


Auto-call necessary commands & allow some uncommon calls

Updates:
1.) Ignore Case when checking if calls match
2.) Allow calls that are unnamed and the same number to call the numbered item
3.) If a call does not exist, it will check if the call can happen every time a command is queued

I've essentially rewritten the call system at this point. I'll go ahead and remake the PR after the new system is tested on my stream for a few days.


Please add the regular expression modifier function

Please add the regular expression modifier function
/gmsi

We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the VS Code Marketplace. Just in case, in a few simple steps you can get started writing your own extension. See also our issue reporting guidelines.
Happy Coding!


Getting started documentation could use more clarification

user feedback:
"1. Which Visual Studio version? Maybe add a link?
2. Unity: Is this a min or a max spec?
3. The optional items are confusing. Let's be more precise:
If you want to develop for HoloLens (2): Windows 10.0.18362.0 SDK + Unity UWP plugin"
I ran into the issue that I didn't have the Unity Android extension at first (oops ) and then I noticed that I didn't have Android Studio . Again it would be nice to add links for convenience."

we added comments stating there were more robust setup steps in getting started. We can reopen this issue as needed.


PR 1, read PR 2 for more information.


feat(cast): get logs

Motivation
It is often very useful to watch for events or get logs using specific topics.
Solution
Added a command that works in two ways.
cast logs --from-block 1234122 --to-block latest --address 0x0000000 SIG [ARGS]
cast logs --from-block 1234122 --to-block latest --address somename.eth TOPIC_0 [TOPICS]

Example:
cast logs --from-block 15537393 --to-block latest 'Transfer (address indexed from, address indexed to, uint256 value)' 0x2e8ABfE042886E4938201101A63730D04F160A82

- address: 0xdAC17F958D2ee523a2206206994597C13D831ec7
  blockHash: 0xa23f0f6f8cd60e489a5a9853b56dbef9deabe3cd41c03431e5cbc981a3c29581
  blockNumber: 16895421
  data: 0x0000000000000000000000000000000000000000000000000000000028fa46c3
  logIndex: 350
  removed: false
  topics: [
  	0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef
  	0x0000000000000000000000002e8abfe042886e4938201101a63730d04f160a82
  	0x000000000000000000000000e16dc9e130239d096d554a04ce6ddff5a78a774a
  ]
  transactionHash: 0xed77e9d350b15695f1d5e3a213c3aafee7055c422671e2779003f34cbebe1b19
  transactionIndex: 225
- address: 0xdAC17F958D2ee523a2206206994597C13D831ec7
  blockHash: 0x4e6b93493ce559a8264c82c8b3f8914c8ff0d381fd82c9e856c706d121c772b4
  blockNumber: 16895424
  data: 0x0000000000000000000000000000000000000000000000000000000000000000
  logIndex: 12
  removed: false
  topics: [
  	0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef
  	0x0000000000000000000000002e8abfe042886e4938201101a63730d04f160a82
  	0x000000000000000000000000e16adb7bcdf5df419fdd48cd092a058f68a4774a
  ]
  transactionHash: 0x3f83518d1b4d2b83f98df18c26dc3387731a50bf56421b9177b4a9f39a78f1eb
  transactionIndex: 12

Equivalent command using just topics:
cast logs --from-block 15537393 --to-block latest 0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef 0x0000000000000000000000002e8abfe042886e4938201101a63730d04f160a82

Logic is that the signature of the event is TOPIC_0 anyways. So the position argument still is kind of consistent. The arguments for when specifying a signature are the indexed arguments of the signature and are converted to topic hashes.
I am still up skilling with Rust so opening a draft PR to get feedback while I work on adding some tests.
Also realised I still need to handle empty arguments (any) when using a signature.

It would be nice to have a --json flag to make it easy to pipe to jq, other commands have the --json flag

A few other thoughts:

It would be nice to abi decode things, not sure if that should be the default behavior or behind a --pretty flag
seth has the ability to watch for new logs, it probably uses eth_subscribe under the hood, not sure how useful that is in practice and probably adds complexity to the implementation

A few other thoughts:

It would be nice to abi decode things, not sure if that should be the default behavior or behind a --pretty flag
seth has the ability to watch for new logs, it probably uses eth_subscribe under the hood, not sure how useful that is in practice and probably adds complexity to the implementation

The --json flag is already implemented.
Think the --pretty makes a lot of sense to do decoding.
Already created issues to support eth_subscribe: #5022 #5023. I expect that the build_filter logic implemented here could be reused. Does it make sense to add the helper functions to utils.rs so long?


Better document the model factory, especifically the fit method

Unspecific. With @jhlegarreta's efforts, documentation has improved substantially and he is filing targetted issues with specific documentation gaps. Closing in favor of that (better) approach.


Error in documentation - missing ','

In the documentation there is an example:
const pageResult = await client.logs.getRequestsList(1, 20, {
    filter: 'status >= 400'
    sort: '-created'

it is missing a comma:
const pageResult = await client.logs.getRequestsList(1, 20, {
    filter: 'status >= 400', //here
    sort: '-created'

Site in question: https://pocketbase.io/docs/api-logs under 'List request log'.

Thank you. I've fixed it locally. It will be available with the new documentation changes for the upcoming v0.8.0 release.


Updated operator-sdk to v0.4.1

I'm currently facing a problem with the fakeClient when working on #193, which is solved in newer versions of the controller-runtime library. As the operator-sdk also depends on that library, I'm bumping the operator-sdk to 0.4.1, which brings the controller-runtime 0.1.8.
The e2e tests for this PR are passing:
$ make test
Running unit tests...
?   	github.com/jaegertracing/jaeger-operator/cmd	[no test files]
?   	github.com/jaegertracing/jaeger-operator/cmd/manager	[no test files]
ok  	github.com/jaegertracing/jaeger-operator/pkg/account	0.030s	coverage: 100.0% of statements
?   	github.com/jaegertracing/jaeger-operator/pkg/apis	[no test files]
ok  	github.com/jaegertracing/jaeger-operator/pkg/apis/io/v1alpha1	0.016s	coverage: 16.7% of statements
?   	github.com/jaegertracing/jaeger-operator/pkg/cmd/start	[no test files]
?   	github.com/jaegertracing/jaeger-operator/pkg/cmd/version	[no test files]
ok  	github.com/jaegertracing/jaeger-operator/pkg/config/sampling	0.014s	coverage: 94.1% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/config/ui	0.021s	coverage: 94.1% of statements
?   	github.com/jaegertracing/jaeger-operator/pkg/controller	[no test files]
?   	github.com/jaegertracing/jaeger-operator/pkg/controller/deployment	[no test files]
ok  	github.com/jaegertracing/jaeger-operator/pkg/controller/jaeger	3.039s	coverage: 64.3% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/cronjob	0.016s	coverage: 93.5% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/deployment	0.011s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/ingress	0.057s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/inject	0.008s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/route	0.027s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/service	0.036s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/storage	0.010s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/strategy	0.008s	coverage: 99.4% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/util	0.006s	coverage: 100.0% of statements
?   	github.com/jaegertracing/jaeger-operator/pkg/version	[no test files]
Formatting code...
Building...
Sending build context to Docker daemon  128.3MB
Step 1/4 : FROM alpine:3.8
 ---> 196d12cf6ab1
Step 2/4 : USER nobody
 ---> Using cache
 ---> 18305c5b670d
Step 3/4 : ADD build/_output/bin/jaeger-operator /usr/local/bin/jaeger-operator
 ---> 53c42e543d6d
Step 4/4 : ENTRYPOINT ["/usr/local/bin/jaeger-operator"]
 ---> Running in ff2885b6079f
Removing intermediate container ff2885b6079f
 ---> 9aa523e9eb9b
Successfully built 9aa523e9eb9b
Successfully tagged jpkroehling/jaeger-operator:latest
Pushing image jpkroehling/jaeger-operator:latest...
Running end-to-end tests...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	350.887s

Signed-off-by: Juraci Paixão Kröhling<EMAIL_ADDRESS>

This change is


Haskell/just static executables

This code was getting copy-pasted in 4 places so I factored it out.
cc @peti @copumpkin @LnL7

I assume this is related to https://github.com/NixOS/nixpkgs/issues/22810.

@LnL7 nope, it's just reducing closure size.


Samtools error when installing bcbio genome data in bcbio:  error while loading shared libraries: libcrypto.so.1.0.0: cannot open shared object file: No such file or directory

Version info

bcbio version (bcbio_nextgen.py --version): 1.2.8
OS name and version (lsb_release -ds): Ubuntu 20.04.3 LTS

To Reproduce
Exact bcbio command you have used:
bcbio_nextgen.py upgrade -u skip --genomes sacCer3 --aligners bwa --aligners bowtie2 --aligners hisat2 --aligners star

This results in the following:
Saccharomyces_cerevisiae.R64-1-1.dna.toplevel.fa.gz  100%[=====================================================================================================================>]   3,61M  3,76MB/s    in 1,0s

2021-11-14 20:56:19 (3,76 MB/s) - written to stdout [3786555]

Sorted contigs saved to "seq/sacCer3.fa" ...
samtools: error while loading shared libraries: libcrypto.so.1.0.0: cannot open shared object file: No such file or directory
Traceback (most recent call last):
  File "/home/user/bcbio/anaconda/bin/bcbio_nextgen.py", line 228, in <module>
    install.upgrade_bcbio(kwargs["args"])
  File "/home/user/bcbio/anaconda/lib/python3.7/site-packages/bcbio/install.py", line 107, in upgrade_bcbio
    upgrade_bcbio_data(args, REMOTES)
  File "/home/user/bcbio/anaconda/lib/python3.7/site-packages/bcbio/install.py", line 359, in upgrade_bcbio_data
    args.cores, ["ggd", "s3", "raw"])
  File "/home/user/tmpbcbio-install/cloudbiolinux/cloudbio/biodata/genomes.py", line 354, in install_data_local
    _prep_genomes(env, genomes, genome_indexes, ready_approaches, data_filedir)
  File "/home/user/tmpbcbio-install/cloudbiolinux/cloudbio/biodata/genomes.py", line 480, in _prep_genomes
    retrieve_fn(env, manager, gid, idx)
  File "/home/user/tmpbcbio-install/cloudbiolinux/cloudbio/biodata/genomes.py", line 875, in _install_with_ggd
    ggd.install_recipe(os.getcwd(), env.system_install, recipe_file, gid)
  File "/home/user/tmpbcbio-install/cloudbiolinux/cloudbio/biodata/ggd.py", line 30, in install_recipe
    recipe["recipe"]["full"]["recipe_type"], system_install)
  File "/home/user/tmpbcbio-install/cloudbiolinux/cloudbio/biodata/ggd.py", line 62, in _run_recipe
    subprocess.check_output(["bash", run_file])
  File "/home/user/bcbio/anaconda/lib/python3.7/subprocess.py", line 411, in check_output
    **kwargs).stdout
  File "/home/user/bcbio/anaconda/lib/python3.7/subprocess.py", line 512, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['bash', '/home/user/bcbio/genomes/Scerevisiae/sacCer3/txtmp/ggd-run.sh']' returned non-zero exit status 127.

This suggests an older version of samtools is being used at some point. There are multiple versions of samtools installed in bcbio:
find bcbio -name samtools
bcbio/anaconda/pkgs/manta-1.6.0-h9ee0642_1/share/manta-1.6.0-1/libexec/samtools
bcbio/anaconda/pkgs/pysam-0.15.3-py27hbcae180_3/lib/python2.7/site-packages/pysam/include/samtools
bcbio/anaconda/pkgs/samtools-1.10-h2e538c0_3/bin/samtools
bcbio/anaconda/pkgs/pysam-0.15.4-py36h873a209_1/lib/python3.6/site-packages/pysam/include/samtools
bcbio/anaconda/pkgs/samtools-1.7-1/bin/samtools
bcbio/anaconda/pkgs/pysam-0.17.0-py37h45aed0b_0/lib/python3.7/site-packages/pysam/include/samtools
bcbio/anaconda/pkgs/multiqc-1.11-pyhdfd78af_0/site-packages/multiqc/modules/samtools
bcbio/anaconda/pkgs/samtools-0.1.19-h270b39a_9/bin/samtools
bcbio/anaconda/pkgs/samtools-1.13-h8c37831_0/bin/samtools
bcbio/anaconda/pkgs/samtools-1.12-h9aed4be_1/bin/samtools
bcbio/anaconda/pkgs/strelka-2.9.10-h9ee0642_1/share/strelka-2.9.10-1/libexec/samtools
bcbio/anaconda/pkgs/bioconductor-rsamtools-1.34.0-r351hf484d3e_0/lib/R/library/Rsamtools/include/samtools
bcbio/anaconda/lib/python3.7/site-packages/pysam/include/samtools
bcbio/anaconda/lib/python3.7/site-packages/multiqc/modules/samtools
bcbio/anaconda/bin/samtools
bcbio/anaconda/envs/htslib1.10/bin/samtools
bcbio/anaconda/envs/python2/share/manta-1.6.0-1/libexec/samtools
bcbio/anaconda/envs/python2/share/strelka-2.9.10-1/libexec/samtools
bcbio/anaconda/envs/python2/lib/python2.7/site-packages/pysam/include/samtools
bcbio/anaconda/envs/python2/bin/samtools
bcbio/anaconda/envs/bwakit/bin/samtools
bcbio/anaconda/envs/python3.6/lib/python3.6/site-packages/pysam/include/samtools
bcbio/anaconda/envs/python3.6/bin/samtools
bcbio/anaconda/envs/htslib1.12_py3.9/bin/samtools
bcbio/anaconda/envs/r35/lib/R/library/Rsamtools/include/samtools
bcbio/anaconda/envs/r35/bin/samtools
bcbio/anaconda/envs/samtools0/bin/samtools
bcbio/tools/bin/samtools

My PATH is configured like this:
export PATH=/home/user/bcbio/anaconda/bin:/home/user/bcbio/tools/bin:$PATH

And the main version of Samtools on my system, given the above, seems to be v1.13:
$ which samtools
/home/user/bcbio/anaconda/bin/samtools
$ samtools --version
samtools 1.13
Using htslib 1.13
Copyright (C) 2021 Genome Research Ltd.

There also seems to be an older version of Samtools getting symlinked in my bcbio tools directory. My guess is that this is probably being picked up somehow when installing the genome data.
$ /home/user/bcbio/tools/bin/samtools
/home/user/bcbio/tools/bin/samtools: error while loading shared libraries: libcrypto.so.1.0.0: cannot open shared object file: No such file or directory
$ ls -l /home/user/bcbio/tools/bin/samtools
lrwxrwxrwx 1 user user 42 nov 14 20:04 /home/user/bcbio/tools/bin/samtools -> ../../anaconda/envs/python3.6/bin/samtools

Removing this symlink from the tools directory got things working for me and I managed to install the genome data using the command mentioned above.

Hi @amizeranschi !
Thanks for the detailed reporting and sorry about the issues!
This last update https://github.com/chapmanb/cloudbiolinux/pull/387 unfortunately, can' be applied by bcbio_nextgen.py -u skip upgrade - you'd better re-install the code and tools from scratch and link the data.
https://bcbio-nextgen.readthedocs.io/en/latest/contents/intro.html#install-bcbio-python-package-and-tools
There might be samtools issues as well, since we now have multiple htslib environments - please update here if you still see the error in the new instllalation.
Sergey

Hi Sergey,
Thanks for the reply. Everything I reported here was based on a fresh install of bcbio, completely from scratch, on a new machine. This was done on the 14th of November and I followed the documentation you linked above.
The update you mentioned seems to be from the 28th of October, so I'm guessing that my install should have used the updated code. Here's what I did:
cd ${HOME}
wget https://raw.githubusercontent.com/bcbio/bcbio-nextgen/master/scripts/bcbio_nextgen_install.py
python3 bcbio_nextgen_install.py ${HOME}/bcbio --tooldir=${HOME}/bcbio/tools --nodata
## add the locations to the bcbio-nextgen dependency executables to the system's $PATH variable
echo "export PATH=${HOME}/bcbio/anaconda/bin:${HOME}/bcbio/tools/bin:\$PATH" >> ~/.bashrc
source ~/.bashrc
## download genome data for sacCer3
bcbio_nextgen.py upgrade -u skip --genomes sacCer3 --aligners bwa --aligners bowtie2 --aligners hisat2 --aligners star

I can retry the installation within the following days, but is there any reason to believe there should be a different outcome, regarding the Samtools errors I mentioned above?

Update:
As advised, I tried reinstalling Bcbio from scratch, but it didn't make any difference. I am still in the same situation as outlined above.
When I try installing the data, Bcbio tries to use the old samtools version that gets symlinked in the tools/bin directory and runs into the error mentioned in the title.

Update 2:
As mentioned in https://github.com/bcbio/bcbio-nextgen/issues/3561, I've upgraded bcbio to the latest development version. Unlike there, however, this didn't fix the issue mentioned here.
I can hack around it by renaming or removing the samtools symlink from the tools directory, but it might still be good to solve this before the next stable release.

HI @amizeranschi !
Thanks for the follow up and for the patience!
Yes, indeed this old samtools should not be called.
Please unlink it:
cd /home/user/bcbio/tools/bin/
unlink samtools

I've pushed a fix that it won't be linked in the first place anymore:
https://github.com/chapmanb/cloudbiolinux/pull/393
Let me know if that helps with the installation.
Sergey

Hi @naumenko-sa
Strangely enough, I still seem to be getting this issue. Once again, on a completely fresh bcbio install, from scratch. Upgrading bcbio and tools to development didn't help.
This time, the culprit samtools executable is in bcbio_dir/anaconda/bin:
[a.mizeranschi@haswell-wn30 ~]$ which samtools
~/bcbio-nextgen/anaconda/bin/samtools
[a.mizeranschi@haswell-wn30 ~]$ samtools
samtools: error while loading shared libraries: libcrypto.so.1.0.0: cannot open shared object file: No such file or directory

[a.mizeranschi@haswell-wn30 ~]$ mamba list | grep samtools
bioconductor-rsamtools    2.10.0            r41h619a076_1    bioconda
perl-bio-samtools         1.43            pl5321h7132678_3    bioconda
samtools                  1.7                           1    bioconda

Any help here would be much appreciated.

I'm seeing this as well with the current stable release. Working on debugging.

Yeah it's installing samtools 1.7 on my machine as well. Seeing if pinning to 1.13 works, as you mentioned.

As mentioned in https://github.com/bcbio/bcbio-nextgen/issues/3632, we likely need to double check the pinning of bcftools as well.

This hotfix seems to be working for me so far:
/opt/koopa/opt/bcbio-nextgen/install/anaconda/bin/mamba install \
    --name 'base' \
    'bamtools==2.5.1' \
    'samtools==1.15'

Transaction

  Prefix: /opt/koopa/app/bcbio-nextgen/1.2.9/install/anaconda

  Updating specs:

   - bamtools==2.5.1
   - samtools==1.15
   - ca-certificates
   - certifi
   - openssl

  Package          Version  Build           Channel                    Size
─────────────────────────────────────────────────────────────────────────────
  Change:
─────────────────────────────────────────────────────────────────────────────

  - fastp           0.23.2  h79da9fb_0      installed
  + fastp           0.23.2  hb7a2d85_2      bioconda/linux-64          3 MB
  - libtiff          4.3.0  hf544144_1      installed
  + libtiff          4.3.0  h542a066_3      conda-forge/linux-64     Cached
  - r-base           4.1.1  hb67fd72_0      installed
  + r-base           4.1.1  hb93adac_1      conda-forge/linux-64      25 MB
  - staden_io_lib  1.14.14  h7c09d56_1      installed
  + staden_io_lib  1.14.14  h0d9da7e_3      bioconda/linux-64        792 KB

  Upgrade:
─────────────────────────────────────────────────────────────────────────────

  - bcftools          1.13  h3a49de5_0      installed
  + bcftools          1.15  h0ea216a_2      bioconda/linux-64        852 KB
  - cyvcf2         0.30.11  py37h31aceb7_2  installed
  + cyvcf2         0.30.15  py37h6841c58_0  bioconda/linux-64        929 KB
  - gsl                2.6  he838d99_2      installed
  + gsl                2.7  he838d99_0      conda-forge/linux-64     Cached
  - htslib            1.13  h9093b5e_0      installed
  + htslib            1.15  h9753748_0      bioconda/linux-64        Cached
  - lerc             2.2.1  h9c3ff4c_0      installed
  + lerc               3.0  h9c3ff4c_0      conda-forge/linux-64     Cached
  - libdeflate         1.7  h7f98852_5      installed
  + libdeflate        1.10  h7f98852_0      conda-forge/linux-64     Cached
  - pysam           0.17.0  py37h45aed0b_0  installed
  + pysam           0.18.0  py37h8fe4cdf_2  bioconda/linux-64          3 MB
  - samtools           1.7  1               installed
  + samtools          1.15  h1170115_1      bioconda/linux-64        392 KB
  - tk              8.6.10  hbc83047_0      installed
  + tk              8.6.12  h27826a3_0      conda-forge/linux-64     Cached
  - zstd             1.5.0  ha4553b6_1      installed
  + zstd             1.5.2  ha95c52a_0      conda-forge/linux-64     Cached

  Summary:

  Change: 4 packages
  Upgrade: 10 packages

  Total download: 33 MB

Trying to pin bamtools to 2.5.2 fails due to case dependency on 2.5.1

Still not working, now seeing this error on an RNA-seq run: samtools sort: failed to read header.
Trying to pin against 1.13 instead to see if that works.

Yeah still hitting this error: samtools sort: failed to read header from "/dev/stdin"

@mjsteinbaugh
FYI, I couldn't reproduce the samtools sort error you mentioned above. I'm testing using the RNA-seq scenario described in my older issue report, here: https://github.com/bcbio/bcbio-nextgen/issues/3565#issuecomment-997212051
However, my Samtools version is 1.15. What I did is, right after a fresh bcbio install, I upgraded bcbio and tools to development and then installed samtools>=1.13, which ended up installing v. 1.15. Here's the exact commands that I ran:
cd ${HOME}
wget https://raw.github.com/bcbio/bcbio-nextgen/master/scripts/bcbio_nextgen_install.py
python3 bcbio_nextgen_install.py ${HOME}/bcbio-nextgen --tooldir=${HOME}/bcbio-nextgen/tools --nodata --mamba
## add the locations to the bcbio-nextgen dependency executables to the system's $PATH variable
echo "export PATH=${HOME}/bcbio-nextgen/anaconda/bin:${HOME}/bcbio-nextgen/tools/bin:\$PATH" >> ~/.bashrc
source ~/.bashrc
## upgrade bcbio and tools to the latest development version
bcbio_nextgen.py upgrade -u development --tools
## make sure to have a recent samtools in the main conda environment
mamba install -c bioconda "samtools>=1.13" --yes
## download genome data for sacCer3
bcbio_nextgen.py upgrade -u skip --genomes sacCer3 --aligners bwa --aligners bowtie2 --aligners hisat2 --aligners star

P.S. Are you any closer to making a new release for r-acidgenomes in bioconda? It would be great to have bcbiornaseq working within bcbio once again.

Alright, thanks for the update, I've tracked those pull requests.
If you do try to run the code I've linked, you will first need sacCer3 genome data available in bcbio. This is pretty small and you can get it via:
## download genome data for sacCer3
bcbio_nextgen.py upgrade -u skip --genomes sacCer3 --aligners bwa --aligners bowtie2 --aligners hisat2 --aligners star

You'd also want to comment out lines 217-220, which enable bcbiornaseq.

Hi @mjsteinbaugh and @amizeranschi !
Sorry, I dropped the ball, you've heard - the world changed a bit.
Interestingly, my ~january 1.2.9 installation received samtools 1.13 in the base env, as needed.
But the fresh one indeed received samtools1.7 in the base.
It has to be 1.13, not 1.15, I fixed it with
mamba install samtools=1.13
it is weird why conda solved it like that, bcftools was pinned to 1.13.
I pinned samtools as well:
https://github.com/chapmanb/cloudbiolinux/blob/master/contrib/flavor/ngs_pipeline_minimal/packages-conda.yaml#L113
I appreciate if anybody tests.
Sergey

I've tried another fresh install and now it ends up with bcbio-nextgen 1.2.8 at the end. Here's what I tried:

cd

wget https://raw.githubusercontent.com/bcbio/bcbio-nextgen/master/scripts/bcbio_nextgen_install.py

python3 bcbio_nextgen_install.py /home/test/bcbio-test --tooldir=/home/test/bcbio-test/tools --nodata --mamba

export PATH=/home/test/bcbio-test/anaconda/bin:/home/test/bcbio-test/tools/bin:$PATH

bcbio_nextgen.py --version

This reports 1.2.8. Having a look at the output, I see the following:
  Downgrade:
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

  - bcbio-nextgen                                                1.2.9  pyh5e36f6f_2            installed
  + bcbio-nextgen                                                1.2.8  pyh5e36f6f_0            bioconda/noarch            2 MB

A collaborator, @marianastase0912, had a similar thing happen to her fresh bcbio install.
Upgrading to the latest development version doesn't fix this, either, as the same downgrade happens at some point near the end of the install.

Thanks for testing @amizeranschi
Yes, it replicates for me as well in the fresh installation.
The workaround for now:
mamba install openssl=1.1.1l bcbio-nextgen=1.2.9
I am fixing bcbio recipe to solve this issue
https://github.com/bioconda/bioconda-recipes/blob/master/recipes/bcbio-nextgen/meta.yaml#L43
I pinned openssl, because new openssl3.0 shifts a lot of packages
openssl1.1.1n is released, and I think conda downgrades bcbio instead of keeping openssl 1.1.1l
Sergey

Fixing it here:
https://github.com/bioconda/bioconda-recipes/pull/34746

Awesome thanks @naumenko-sa , happy to help test this out on an AWS instance.

Yeah still hitting this error: samtools sort: failed to read header from "/dev/stdin"
Update: this only happens when running STAR

@mjsteinbaugh
I know that I am late here.. But I have had the same problem with STAR ..
After a lot of "suffering" , I have discovered that this is a RAM problem.. STAR uses a lot of RAM, and if the resources are not managed properly.. you will get this exact error.


Add mypy + some other misc. changes

Resolves #53
Changes
Docstring clarification for FivetranSensor
I added this because I thought I was working on #49 when I first started coding.
In any event, I added language clarifying how FivetranSensor works more specifically than what was there.
Type-checking
A lot of hooks.py was un-annotated, so I made sure to get the whole thing annotated.
I then added Mypy to the pre-commit. I also added mypy to the CI.
_do_api_call() and _do_api_call_async() API changes
I made these more plainly wrap the requests.request() and asyncio.ClientSession.request APIs. It did not seem like there was much reason for these APIs to deviate. Deviations include:

It had a parameter called json that maps to either the data=json or params=json kwargs in the requests.request() call. This seems less desirable than just passing data=data, params=params, or json=json. Specifically, the json kwarg is confusing from the perspective of the requests and aiohttp APIs: in those APIs, json= expects a dict and data= expects a string, but in the FivetranHook API, json= is a string that gets mapped to data=.
The first 2 args were a tuple for method and URL, whereas these could just be args (like requests.request())
For the internals: it is unnecessarily burdensome from a Mypy perspective, and also inflexible from a future-proofing perspective, to do an if-elif on the method to get the implementation when requests.request() can do that for you.

That said, changing this is probably annoying for users as there may be many users using this function. So I made sure the old API works and gave a deprecation warning via the following:
if is_container(method) and len(method) == 2:
    import warnings
    warnings.warn(
        "The API for _do_api_call() has changed to closer match the"
        " requests.request() API. Please update your code accordingly.",
        DeprecationWarning,
        stacklevel=2
    )
    method, endpoint = method
elif endpoint is None:
    raise TypeError(
        f"{self.__class__.__name__}._do_api_call() missing 1 required"
        f" positional argument: 'endpoint'"
    )

Lastly, I removed the test for "UNKNOWN". The reason why is because requests.request() can handle any method passed in, and the Fivetran API itself should be in charge of rejecting bad methods. (Note that this is the only nontrivial test change I made; all other test cases pass with essentially no changes, meaning my code is more or less a refactor.)
TLDR:

_do_api_call() now matches requests.request()
I made this backwards compatible with a DeprecationWarning

"Breaking" changes
I put "breaking" in quotes because these are very minor API features that were not being used by anything. That said they still constitute breaking changes, in some sense, if we consider changing the FivetranHook's method return types to constitute breaking changes (even if those return types are not so useful).

FivetranHook.check_connector now returns the connector_details dict object. (So that prep_connector can avoid making an unnecessary 3rd API call.)
FivetranHook.prep_connector now returns None instead of Literal[True].

Use hook as cached property
It is more idiomatic in Airflow code for the hook for an operator to be called as a cached_property, so I swapped the operator and sensor code to implement this pattern, and added a deprecation warning for _get_hook().

CI failed because isort moved the type: ignore[import] comment... 😅 Fixed!

No problem, thanks for the merge. I will work on #49 next.


kubevirt cdi-importer is slow in our dev environments (qemu-img convert)

we are seeing slow performance from the importer-osp-controller-baseimage container in our dev environments. As are dev environments use NFS for openshift storage this is likely related.
Kubevirt recently added support for preallocation for the data importer:
https://github.com/kubevirt/containerized-data-importer/blob/master/doc/preallocation.md
Initial tests seem to show that this would speed things up greatly in our dev environments. The fix is simple (simply adding this new flag) but it would require a recent (2.7) version of kubevirt which is not yet stable/released.

Importing the ubuntu cloud img is too slow:
https://cloud-images.ubuntu.com/mantic/current/mantic-server-cloudimg-amd64.img
I0626 17:31:18.192858       1 importer.go:103] Starting importer
I0626 17:31:18.193003       1 importer.go:168] begin import process
I0626 17:31:18.854773       1 data-processor.go:379] Calculating available size
I0626 17:31:18.855288       1 data-processor.go:391] Checking out file system volume size.
I0626 17:31:18.855551       1 data-processor.go:399] Request image size not empty.
I0626 17:31:18.855782       1 data-processor.go:404] Target size<PHONE_NUMBER>.
I0626 17:31:18.856731       1 util.go:38] deleting file: /data/lost+found
I0626 17:31:18.882173       1 nbdkit.go:302] Waiting for nbdkit PID.
I0626 17:31:19.383391       1 nbdkit.go:323] nbdkit ready.


Struct() argument 1 must be string, not unicode in colored_loggin_handler.py

Expected Behavior
Bot should start and run successfully
Actual Behavior
Traceback (most recent call last):
  File "pokecli.py", line 530, in <module>
    main()
  File "pokecli.py", line 96, in main
    bot.tick()
  File "/home/pi/PokemonGo-Bot/pokemongo_bot/__init__.py", line 458, in tick
    if worker.work() == WorkerResult.RUNNING:
  File "/home/pi/PokemonGo-Bot/pokemongo_bot/cell_workers/move_to_fort.py", line 67, in work
    data=fort_event_data
  File "/home/pi/PokemonGo-Bot/pokemongo_bot/base_task.py", line 27, in emit_event
    data=data
  File "/home/pi/PokemonGo-Bot/pokemongo_bot/event_manager.py", line 65, in emit
    handler.handle_event(event, sender, level, formatted_msg, data)
  File "/home/pi/PokemonGo-Bot/pokemongo_bot/event_handlers/colored_logging_handler.py", line 130, in handle_event
    terminal_width = self._terminal_width()
  File "/home/pi/PokemonGo-Bot/pokemongo_bot/event_handlers/colored_logging_handler.py", line 171, in _terminal_width
    struct.pack('HHHH', 0, 0, 0, 0)))
TypeError: Struct() argument 1 must be string, not unicode

Steps to Reproduce
Just run run.sh, maybe wait for a couple of minutes
Other Information
OS: Raspbian
Git Commit: 8b5af8d766ac161be926932b05e3fc785a33661d
Python Version: 2.7.3

Fix in, can be closed.


fix: weird encoding bug

What I did and How I did it
Fixes https://github.com/ApeWorX/ape-cairo/issues/14
For some reason, in that user's project (the one linked in the ticket), the source files bytes are different than its text encoding as utf8. The source content parameter is text, and that is what the checksum has to be based on. So the only solution I could think of was to first read the text as utf8, then encode, and then compare checksums. Now things work.
How to verify it
When you compile https://github.com/supsam89/game_guilds/tree/main/contracts multiple times,
it recognizes that the content has not changed.
Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

[ ] try adding test

Ok, I found the strange characters that are showing up:
>>> bsplit[0]
'%lang starknet\r'
>>> tsplit[1]
''
>>> tsplit[0]
'%lang starknet'
>>>

the bytes version contains return characters for some reason!


fix tuple issue for pip for python < 2.7

pip install fails with:
Collecting dynamic-dynamodb
Using cached dynamic-dynamodb-2.0.0.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 20, in
File "/tmp/pip-build-XB7_kB/dynamic-dynamodb/setup.py", line 36, in
install_requires=return_requires(),
File "/tmp/pip-build-XB7_kB/dynamic-dynamodb/setup.py", line 19, in return_requires
install_requires.append('ordereddict >= 1.1')
AttributeError: 'tuple' object has no attribute 'append'

Facing the same issue trying to install dynamic-dynamodb. Python version 2.6.9.

I already fixed this in #260, which @sebdah has merged into a hotfix branch but hasn't released yet apparently.

Missed that, I should look more carefully.


v2: generating code only for the last query inside a file

I have a ts file with multiple queries like this
import { gql } from "graphql-request";

export const GET_EVENTS = gql`
  query getEvents {
    events {
      items {
        id
        slug
        title
      }
    }
  }
`;

export const GET_EVENTS_BY_SLUG = gql`
  query getEventsBySlug($slug: String) {
    events(slug: $slug) {
      items {
        code
        description
        end_date
        hero_image
        id
        main_video
        slug
        start_date
        title
        sessions {
          description
          end_date
          host_name
          id
          start_date
          title
          webex_id
          webex_pass
        }
      }
    }
  }
`;

export const GET_IMAGE_BY_ID = gql`
  query getImageById($id: Int!) {
    image(id: $id) {
      id
      image
      src
      title
    }
  }
`;
export const GET_FILE_BY_ID = gql`
  query getFileById($id: Int!) {
    file(id: $id) {
      id
      src
      title
    }
  }
`;
export const GET_LINK_BY_ID = gql`
  query getLinkById($id: Int!) {
    link(id: $id) {
      href
      id
      target
      title
    }
  }
`;
export const GET_MODELTHREED_BY_ID = gql`
  query getModelthreedById($id: Int!) {
    modelthreed(id: $id) {
      id
      src
      title
    }
  }
`;

my codegen.yml is like this:
overwrite: true
schema: ".../tetrapak_graphql"
documents:
  - "src/gql/**/!(*.generated).{ts,tsx}"
generates:
  src/gql/generated-types.ts:
    plugins:
      - "typescript"
  src/gql/:
    preset: near-operation-file
    presetConfig:
      extension: .generated.ts
      baseTypesPath: generated-types.ts
    plugins:
      - "typescript-operations"
      - "typescript-react-query"
    config:
      fetcher: graphql-request
      exposeQueryKeys: true

before version 2 my generated files had the code for all queries, but since version 2, the generated files contains only the code for the last query, in the case above getModelthreedById
import * as Types from '../../generated-types';

import { GraphQLClient } from 'graphql-request';
import { useQuery, UseQueryOptions } from 'react-query';

function fetcher<TData, TVariables>(client: GraphQLClient, query: string, variables?: TVariables) {
  return async (): Promise<TData> => client.request<TData, TVariables>(query, variables);
}
export type GetModelthreedByIdQueryVariables = Types.Exact<{
  id: Types.Scalars['Int'];
}>;

export type GetModelthreedByIdQuery = { __typename?: 'Query', modelthreed?: Types.Maybe<{ __typename?: 'Modelthreed', id: number, src?: Types.Maybe<string>, title?: Types.Maybe<string> }> };

export const GetModelthreedByIdDocument = `
    query getModelthreedById($id: Int!) {
  modelthreed(id: $id) {
    id
    src
    title
  }
}
    `;
export const useGetModelthreedByIdQuery = <
      TData = GetModelthreedByIdQuery,
      TError = unknown
    >(
      client: GraphQLClient,
      variables: GetModelthreedByIdQueryVariables,
      options?: UseQueryOptions<GetModelthreedByIdQuery, TError, TData>
    ) =>
    useQuery<GetModelthreedByIdQuery, TError, TData>(
      ['getModelthreedById', variables],
      fetcher<GetModelthreedByIdQuery, GetModelthreedByIdQueryVariables>(client, GetModelthreedByIdDocument, variables),
      options
    );
useGetModelthreedByIdQuery.getKey = (variables: GetModelthreedByIdQueryVariables) => ['getModelthreedById', variables];

is there a new way to configure the codegen.yml or is a bug?
woking in
"@graphql-codegen/cli": "^1.21.8",
"@graphql-codegen/introspection": "^1.18.2",
"@graphql-codegen/near-operation-file-preset": "^1.18.6",
"@graphql-codegen/typescript": "^1.23.0",
"@graphql-codegen/typescript-operations": "^1.18.4",
"@graphql-codegen/typescript-react-query": "^1.3.5",
not working with
"@graphql-codegen/cli": "^2.0.1",
"@graphql-codegen/introspection": "^2.0.0",
"@graphql-codegen/near-operation-file-preset": "^2.0.0",
"@graphql-codegen/typescript": "^2.0.0",
"@graphql-codegen/typescript-operations": "^2.0.1",
"@graphql-codegen/typescript-react-query": "^2.0.0",

Can confirm this behavior.
CodeSandbox link
src/test.ts containts 2 queries (GetLanguages, GetCurrencies). but generated file (src/graphQLTypes/test.ts) contains types only for the last query.
After restricting package versions of @graphql-codegen/* to ^1 everything is fine.

Any update on this? Or an idea where to start?  We are also seeing this issue and it is blocking us from upgrading

Fixed in @graphql-tools/code-file-loader with this commit;
https://github.com/ardatan/graphql-tools/commit/1c6fb01a94ca5314071890a38e0aa7f4378aca01
It'll be available soon once GraphQL Codegen is released with the newer version of GraphQL Tools

This is now released 😇


Memory Leak on 1.93.1 with no extensions; eventually caps RAM and freezes computer

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.93.1
OS Version: Windows 11 Pro 23H2 (22631.4169)

Steps to Reproduce:

Launch VS Code with no extension enabled
Wait

What happens:

RAM usage constantly increases
Developer: Process Explorer does not report any usage increase on any of the code main items
Eventually the RAM usage caps out, the computer becomes unresponsive, and I have to hard reset it

Screenshot while opened, showing the slow increase:

Screenshot after closing:

Seems to be fixed on 1.94.0. Can't reproduce it.

Re-opening, I just had my computer crash on 1.94.0. Not sure how it didn't seem to be the case yesterday.

Still happening on 1.94.1.

Still happening on 1.95.1.
Additional context: I run VSCode from a folder that is synced through Dropbox, maybe it creates an issue?
I also have synced settings enabled.

Taken today. The memory usage goes down right after I close VS Code without a single file opened.

This makes the program always a risk to use because when it fills the RAM, the computer basically becomes unresponsive and a hard reset is the fastest and easiest way to fix it.
This feels like a P0, or P1 at least, as there is a massive amount of memory leakage happening which makes me question what other parts of the program are susceptible to this issue.

Tested again on 1.95.3 and still happening.
I have:

Downloaded a new copy of VSCode as a .zip file
Extracted it on my Desktop
Started the software
Waited

My RAM usage constantly increase with no other user action. I can just stare at the RAM getting filled.
This makes the usage of the editor an impossibility since it will eventually cap out and freeze my computer, making it unusable.

VSCode being a multi process application it would help to know the offending process triggering this issue, can you share the full command line of that process.

I'm currently away from home and unable to get that info. Also the whole process takes the amount of memory. It's a bit aggravating to see this bug closed within a week when ot took 3 months to get a reply.
I'll file a new bug with additional info when I'm back from vacation.


Consider Adding Topic: HTML5 (and HTML5 markup skeleton)

See #265

I actually think we've already got this covered:
https://webguide.ucsb.edu/html/

I'll close this for now, but let me know if I should reopen!

Thanks, @loganfranken!


Neo Plug Firmware not updating

Tried it now with a few different ones but all give Error Unknown and similar debug as in #659? I put the logs in the old one.

Better to continue in old issue


Provide a fast way to validate packit.yaml

We already have this using the validate-config command:
$ packit validate-config
2022-12-14 11:09:48.242 validate_config.py INFO   .packit.yaml is valid and ready to be used

Although folks may not be familiar with this command, or even Packit CLI in general. At minimum, we should provide documentation how to validate the config without the need to create a new PR, ideally do it locally (pre-commit hook).

Error state can suggest trying Packit locally.

We already have a pre-commit hook and documented it here: https://packit.dev/posts/pre-commit-hooks


check and clean codes

[ ] Key
[ ] Partitions
[ ] ArrayOp
[ ] MyF
[ ] binom
[ ] SeqOp
[ ] CH
[ ] F0Table
[ ] HirTable
[ ] Complexity
[ ] ChDecreaseCheck
[ ] F0DecreaseCheck
[ ] test

[ ] change output directory location to CH6/output
[ ] check the range of generating series in CH and F0 list series T_alpha for Ialpha <= 4, and all terms with degree <= 5 and wdeg <= 10

match the loops in complexity to new range

Find memory leak? Install http://www.oracle.com/splash/java.net/index.html


Python: Rechunk/Take by passing chunked array into __getitem__

E.g. you should be able to do
import pyarrow as pa

chunk1 = pa.array([1, 2, 3])
chunk2 = pa.array([4, 5, 6])
chunked_array = pa.chunked_array([chunk1, chunk2])
rechunked = geo_table[chunked_array]
# output table has two chunks with three rows each

It should maybe also be possible to pass in a list of slices?
geo_table[0:3, 3:6]

though I'm not overly excited about that syntax because it feels too much like array slicing

I don't like this API. It should be clear with methods. Regardless, these general rechunk/take methods are implemented in arro3 now.


Increase default toast duration to 6 seconds

GitHub Issue
Add a link to the GitHub issue.
Changes
Increase toast duration to 6 seconds
Packages Added
n/a
Checks
Before making your PR, please check the following:

[x] Critical lint errors are resolved
[x] App runs locally
[ ] App builds locally (run the build command for any impacted package and check for any errors before the PR)

This PR closes https://github.com/HausDAO/daohaus-monorepo/issues/604


Add Kubernetes resource specs

ping @dpp

I like to add livenessProbes and readinessProbes to all Deployment specs since those help Kubernetes be smarter about managing pods.  I didn't add those here since there was nothing equivalent in the Mesos config, but should I add those now?


Feature: generate fillables

Add an option to generate types based on model's fillables. This is useful for typing editable versions of models when you are for example creating a new model and want to describe the type that contains the editable attributes of the model.
Also updated command options section of readme to include all options from the command signature.
Add two options:

--fillables
--fillable-suffix

Example model:
class Model extends Model
{
    protected $fillable = ['name', 'type'];
}

Example command:
php artisan model:typer --fillables --fillable-suffix=Editable
Example output:
export interface Model {
    name: string
    type: string
}
export type ModelEditable = Pick<Model, 'name'|'type'>

excellent idea @nonetallt and thanks for the PR!
Will review/merge ASAP

@nonetallt Thanks for the contribution (and the tests)! We'll review this and get back with any feedback if needed.


made version of minikube configurable

@sebastian-toepfer thank you for this PR do u mind adding pull upstream ?
and sorry for the late review

@medyagh: done, if this pr is done, i will pull upstream for the macos one

@medyagh sry, but whats about this pr? would be very nice to get this and the macos one merged and a quick release - so we must no longer used the fork.


Can't change command name inside command:before hook.

I have hook for prettify command names
  app.addAppHook('command:before', (app: MojoApp, _args: string[]) => {
    app.cli.commands = _.mapKeys(app.cli.commands, (_value, key) => key.replaceAll('_', ':'));
  });

but it's not work, because hook start before all command load

The command:init hook now exists.


Add alternate list-based event view

toggle-button above calendar switches to list-based event view
starts at oldest-existing event, newer ones below (this view would also make it easy to mass-delete old, completed events
dates with events attached are stacked vertically, with all applicable events listed below the appropriate date
can delete / edit events in this view
no zoom levels
limit box height, overflow creates vertical scrollbar

use JavaScript media queries to set the default event view to the list-type at very small page sizes
https://www.w3schools.com/howto/howto_js_media_queries.asp


Address issue with extension breaking for some users

After some use, the extension stops working for some users:

browser history is not recorded
pop up stops appearing

And domain interaction history seems to stop being collected at the same time as browsing history. So, essentially, the whole backend connection seems gone at this point.
@chunyuema says:

It is likely that the service worker goes to sleep and never wake up in the cases when all information suddenly stops. I believe that this is a known issue for the MV3. I added a piece of code to send some messages from the content script to the service worker to keep it alive but maybe that is not working completely.

It seems difficult to find out why some users report that they have installed our extension, but we do not seem to receive complete data. Closing this for now as this could also be an issue on the users' end. We have to see ...


Remove v1alpha1 CRDs and related bits

I think it's time to remove collections, since we're about to support reading devfiles which are pretty far removed from collections (or I guess closer to collections depending on how you look at it).  Stacks have been available since 0.6.0 which gives users four releases to migrate, and two releases of a certain downstream project to migrate.
Some things that need to change:

Collection CRD, and Kabanero v1alpha1 CRDs, can be removed.  This is accomplished by removing the pkg/apis/kabanero/v1alpha1 directory, I think.
The Kabanero CSV should remove the Collection CRD from its owned section, as well as any other place in there that references Collection
The Makefile needs to stop copying the Collection CRD to the operator registry.  This may happen automatically once the pkg/apis/kabanero/v1alpha1 directory is removed, but we should verify that this is the case.
The Kabanero controller should stop deploying the collection controller.  There is not any point in deploying the collection controller when the Kabanero CR instance is coded for a lower version, because the CRD won't be there.  We could choose to print a message in the Kabanero CR status explaining this, but I don't think that will be necessary (we can wait until someone asks us for it, or is confused).
Any code in the kabanero controller that attempts to migrate CR instances from v1alpha1 to v1alpha2 can be removed
The code in the kabanero controller that attempts to read pipeline information from the collection yaml and copy it into the stack object, can be deleted.  The pipeline information should come only from the Kabanero CR instance now.
The admission webhook implementation for v1alpha1 should be deleted
The YAML for the admission webhook should not try to register for v1alpha1 objects anymore
Anything else I forgot ;-)

This was fixed in #760


Add GigSmart and the Gig Economy Industry

Please review our Contribution Guidelines to ensure your changes abides by it.
Changes should be made to the end of the file.
Review your changes and complete the checklist below.

[x] Company name
[x] Industry
[x] Company location
[x] Company description
[x] How Elixir is used
[x] GitHub / blog links
[x] Job listings

Howdy @jwaldrip and fellow Denverite! 👋
Wonderful to have this addition!


Sound

Hey pal, can you make it so the music used in video, using from another source such ISRC, sound on or even tiktok sounds library?

You can choose the music with the background, but on tiktok webapp, you can't choose a sound, whereas you can upload on tiktok android/ios and set your music.


[PE-D][Tester A] Tagging as a separate command

currently, the group command is used repeatedly for both grouping and tagging. as a user, I may want a separate command for tagging since the functionality is primarily different from grouping. The current implementation may seem a bit confusing for the general users

Labels: severity.High type.FeatureFlaw
original: ChocoRagdoll/ped#12

Since the command already allows for grouping by just the tag, it is unnecessary to craft a new command. Although, id is not optional and the UG needs to be updated

May put under planned enhancements


Type 'boolean is not assignable to 'never'

Describe the bug
Hey 👋 and thanks a lot for yet-another-great-package!
react-photo-album was perfect for my usage, and now a lightbox on top was just what I wanted!
However, after copying your example, I get TypeScript complains on all props.
With a simple //@ts-ignore before any prop, everything works as expected!
Expected behavior
Types to be understood correctly by tsc and give warnings when they are wrong
How to reproduce

npm install<EMAIL_ADDRESS>in a ts-based project
Import { Lightbox } from "yet-another-react-lightbox"
Try to use it in render and add props
See faulty types

Screenshots / Logs

Lightbox's listed types

Additional context
No response

Hi! Thank you for reporting this issue. What version of TypeScript are you using?

Just a quick update here. I tried reproducing this issue but haven't been successful so far. I tried downgrading to React 17 and TypeScript all the way down to 3.9, but in all my tests tsc type checks just fine. Can you provide some additional details about your project environment?
node -v
npm ls --depth=0 react react-dom @types/react @types/react-dom typescript
cat tsconfig.json

Also, do you see this error in tsc output or just in the IDE?

Thanks for checking it out!
I get the error both in VSCode and through tsc.
Node version
v18.0.0
TypeScript version
Version 4.5.2
Other packages
Output of npm ls --depth=0 react react-dom prop-types @types/react @types/react-dom @types/node typescript:

TSConfig
  "compilerOptions": {
    "target": "esnext",
    "lib": [
      "dom",
      "dom.iterable",
      "esnext"
    ],
    "allowJs": true,
    "skipLibCheck": true,
    "strict": false,
    "forceConsistentCasingInFileNames": true,
    "noEmit": true,
    "esModuleInterop": true,
    "module": "esnext",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "jsx": "preserve",
    "incremental": true,
    "moduleResolution": "node",
    "baseUrl": "./"
  },
  "include": [
    "next-env.d.ts",
    "**/*.ts",
    "**/*.tsx"
, "components/NewDesign"  ],
  "exclude": [
    "node_modules"
  ]
}

Thank you! Can you also tell me your prop-types version?
npm ls prop-types

Thank you! Can you also tell me your prop-types version?
npm ls prop-types

Sure! It is 15.8.1

I was finally able to reproduce it! Changing strict to true in tsconfig.json solved the issue.
"strict": true,

Let me dig into why this is happening when strict is set to false...

Fixed in v1.2.3

v1.2.3 works like a charm! Thank you so much for fixing it so fast!

My pleasure!


bug:

Describe the bug:
https://imgur.com/olqYTyM
https://imgur.com/BhHeqfy
https://imgur.com/KA6hbEs
When running the command !mcserver server port I am prompted with this
Code:
Please put any code related to the issue within these backticks
`const util = require('minecraft-server-util');

module.exports = {
    name: 'mcserver',
    description: 'get information about a minecraft server',
    execute(client, message, args, Discord){
        if(!args[0]) return message.channel.send('Please enter a minecraft server ip');
        if(!args[1]) return message.channel.send('Please enter a minecraft server port');

        util.status(args[0], {port: parseInt(args[1])}).then((response) =>{
            console.log(response);
            const embed = new Discord.MessageEmbed()
            .setColor('#BFCDEB')
            .setTitle('Mc server status')
            .addFields(
                {name: 'Server IP', value: response.host},
                {name: 'Online Players', value: response.onlinePlayers},
                {name: 'Max Players', value: response.maxPlayers},
                {name: 'Version', value: response.version}
            )
            .setFooter('Mc server util by dev');

            message.channel.send(embed);
        })
        .catch ((error) =>{
            message.channel.send('there was an error finding this server');
            throw error;
        })
    }
}``

**Expected behavior:**
Once I entered my !mcserver ip port I expected it to give me the data on that server, instead it errored

**Additional context**
Add any other context about the problem here

The reason you are getting that error is because you updated the library without changing your code. Major version 5.0.0 contains breaking changes that aren’t compatible with previous changes.


image name problem after docker pull succeeds

name: Question about Dragonfly
about: Ask whatever you want to know or confusion about Dragonfly

Question

I deployed the supernode and df-client according to the documentation.
After testing, I can use the dfget to pull the images successfully.
But there is a difference in the namespace of image names  after docker pull.
Images of registry with different namespace, library and testnasp.
<IP_ADDRESS>:5000/library/nginx:0.1
<IP_ADDRESS>:5000/testnasp/nginx:0.1
Results of docker pull in the peer node:
<IP_ADDRESS>:5000/library/nginx:0.1 --> docker.io/nginx:0.1
<IP_ADDRESS>:5000/testnasp/nginx:0.1 --> docker.io/testnasp/nginx:0.1
It would be appreciated if I could get some professional guidance.
$ docker pull library/nginx:0.1
Trying to pull repository docker.io/library/nginx ...
0.1: Pulling from docker.io/library/nginx
2da35ff30a7d: Pull complete
831fb1a65ced: Pull complete
7a63da4e8a19: Pull complete
Digest: sha256:2de9d5fc6585b3f330ff5f2c323d2a4006a49a476729bbc0910b695771526e3f
Status: Downloaded newer image for docker.io/nginx:0.1

$ docker pull testnasp/nginx:0.1
Trying to pull repository docker.io/testnasp/nginx ...
0.1: Pulling from docker.io/testnasp/nginx
2da35ff30a7d: Pull complete
831fb1a65ced: Pull complete
7a63da4e8a19: Pull complete
Digest: sha256:2de9d5fc6585b3f330ff5f2c323d2a4006a49a476729bbc0910b695771526e3f
Status: Downloaded newer image for docker.io/testnasp/nginx:0.1

docker version of peer node:
$ docker info
Containers: 2
 Running: 0
 Paused: 0
 Stopped: 2
Images: 15
Server Version: 1.13.1
Storage Driver: devicemapper
 Pool Name: docker-253:2-100665953-pool
 Pool Blocksize: 65.54 kB
 Base Device Size: 10.74 GB
 Backing Filesystem: xfs
 Data file: /dev/loop0
 Metadata file: /dev/loop1
 Data Space Used: 987.8 MB
 Data Space Total: 107.4 GB
 Data Space Available: 20.45 GB
 Metadata Space Used: 1.36 MB
 Metadata Space Total: 2.147 GB
 Metadata Space Available: 2.146 GB
 Thin Pool Minimum Free Space: 10.74 GB
 Udev Sync Supported: true
 Deferred Removal Enabled: true
 Deferred Deletion Enabled: true
 Deferred Deleted Device Count: 0
 Data loop file: /docker/devicemapper/devicemapper/data
 WARNING: Usage of loopback devices is strongly discouraged for production use. Use `--storage-opt dm.thinpooldev` to specify a custom block storage device.
 Metadata loop file: /docker/devicemapper/devicemapper/metadata
 Library Version: 1.02.107-RHEL7 (2015-10-14)
Logging Driver: journald
Cgroup Driver: systemd
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
Swarm: inactive
Runtimes: docker-runc runc
Default Runtime: docker-runc
Init Binary: /usr/libexec/docker/docker-init-current
containerd version:  (expected: aa8187dbd3b7ad67d8e5e3a15115d3eef43a7ed1)
runc version: 5eda6f6fd0c2884c2c8e78a6e7119e8d0ecedb77 (expected: 9df8b306d01f59d3a8029be411de015b7304dd8f)
init version: fec3683b971d9c3ef73f284f176672c44b448662 (expected: 949e6facb77383876aeff8a6944dde66b3089574)
Security Options:
 seccomp
  WARNING: You're not using the default seccomp profile
  Profile: /etc/docker/seccomp.json
Kernel Version: 3.10.0-327.el7.x86_64
Operating System: CentOS Linux 7 (Core)
OSType: linux
Architecture: x86_64
Number of Docker Hooks: 3
CPUs: 2
Total Memory: 1.051 GiB
Name: node1
ID: V2DG:JHUG:G45I:DDHW:57YD:6LIU:R2IT:WPIF:55XR:CVTE:QFNX:MELQ
Docker Root Dir: /docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/0
 <IP_ADDRESS>/8
Registry Mirrors:
 http://<IP_ADDRESS>:65001
Live Restore Enabled: false
Registries: docker.io (secure)

This's resolved by #389


sst_import: support multiple ranges in a single switch mode request

What is changed and how it works?

Issue Number: Close https://github.com/tikv/tikv/issues/14916
What's Changed:

support multiple ranges in a single switch mode request

Related changes
https://github.com/pingcap/kvproto/pull/1148
Check List
Tests

Unit test
Integration test

Release note
None

/merge

/merge

/merge


number of the slide

Issue description:
Can you tell me how to show the number of the slide below the slider?
Demo link/slider setting:
Tiny-slider version:   v2.9.1
Browser name && version:  n/a
OS name && version:   n/a

There is a .tns-liveregion element in the slider tells user which slide is currently active.
You could remove class "tns-visually-hidden" or update CSS to make it visible.

@ganlanyuan is there a way to translate .tns-liveregion content?

@AnthonySGeorge and @ganlanyuan Also You can use .getInfo() and show the information you need where you need it.

Would be nice for the "slide" part of the text to be a configurable keyword. E.g. Video 1 of 4, Hilarious Joke 0 of 0, etc.
As it stands I just need it removed so I guess getInfo() is my only option - modifying the content trips up getLiveRegionStr() and it never updates, as it's looking for an exact match on the innerHTML.


HDFS-16154. TestMiniJournalCluster failing intermittently because of …

…not reseting UserGroupInformation completely
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
JIRA:
https://issues.apache.org/jira/browse/HDFS-16154

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
30m 52s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 13s

trunk passed

+1 :green_heart:
shadedclient
16m 19s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 51s

the patch passed

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  9s

the patch passed

+1 :green_heart:
shadedclient
16m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
231m 29s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

315m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3270/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3270

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux a3264e739081 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 193b21b7e2376b68f6fa151a2c6078f1dbde8e9a

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3270/1/testReport/

Max. process+thread count
3339 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3270/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Printing top K values instead of just single max value

Currently WinMLRunner prints top value in the result float tensor. This change is to output top K values instead:
Here is the sample output:
Creating Session with GPU: AMD FirePro W4100 Graphics Adapter
Binding (device = GPU, iteration = 1, inputBinding = CPU, inputDataType = RGB_Image, deviceCreationLocation = WinML)...[SUCCESS]
Outputting top 5 values
Feature Name: resnetv23_dense0_fwd
index: 409, value: 6.74914
index: 769, value: 5.66233
index: 664, value: 5.62002
index: 585, value: 5.48044
index: 872, value: 5.29839
Evaluating (device = GPU, iteration = 1, inputBinding = CPU, inputDataType = RGB_Image, deviceCreationLocation = WinML)...[SUCCESS]

Looks good to me! Can you update the usage in README.md to show this flag as well?


job.tty on Windows

For example, term_gettty() return like below on Windows.
\\.\pipe\winpty-conout-17412-2-1d30c5e50c282b0-ca5201ff60a6c1a8d8d5d8d061d38d8f

Ah, sorry. I want to change this behavior. Please wait.

I changed format of job.tty on Windows like
winpty://[winpty-process-id]

Codecov Report

Merging #1929 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1929      +/-   ##
==========================================
+ Coverage   75.08%   75.09%   +<.01%
==========================================
  Files          76       76
  Lines      125301   125301
==========================================
+ Hits        94088    94099      +11
+ Misses      31213    31202      -11

Impacted Files
Coverage Δ

src/if_xcmdsrv.c
83.33% <0%> (-2.23%)
:arrow_down:

src/os_unix.c
57.25% <0%> (-0.15%)
:arrow_down:

src/ex_cmds2.c
79.92% <0%> (-0.11%)
:arrow_down:

src/channel.c
83.78% <0%> (-0.1%)
:arrow_down:

src/term.c
52.93% <0%> (-0.06%)
:arrow_down:

src/gui.c
45.53% <0%> (-0.06%)
:arrow_down:

src/libvterm/src/screen.c
74.63% <0%> (+0.02%)
:arrow_up:

src/gui_gtk_x11.c
47.5% <0%> (+0.05%)
:arrow_up:

src/ex_cmds.c
77.71% <0%> (+0.08%)
:arrow_up:

src/window.c
81.29% <0%> (+0.36%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3a90a...a4ef76f. Read the comment docs.

Yasuhiro Matsumoto wrote:

I changed format of job.tty on Windows like
winpty://[winpty-process-id]

Doesn't this break the test that checks term_gettty() returns an empty
string?
--
f y cn rd ths thn y cn hv grt jb n cmptr prgrmmng
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Library release removal request

Library name
Arduino_PortentaMachineControl
Version to remove
1.0.0

Hi @leonardocavagnis. I am confirming your request.
Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will close this issue when it is done. You will get a notification from GitHub at that time.
After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager


Reproducible builds support

Does snyth support reproducibly built packages through SOURCE_DATE_EPOCH? If SOURCE_DATE_EPOCH is set to the TIMESTAMP in distinfo when pkg create is called, it should allow for a number of packages to be reproducible.

I can't find current documentation on SOURCE_DATE_EPOCH.  I assume the
ports tree sets it under specific circumstances, probably a make.conf
variable or the setting of an environment variable.  If you tell me how
it's done for poudriere, I can likely tell you how to set it on synth too.
John
On Wed, Feb 23, 2022 at 1:48 PM sometato @.***> wrote:

Does snyth support reproducibly built packages through SOURCE_DATE_EPOCH?
If SOURCE_DATE_EPOCH is set to the TIMESTAMP in distinfo when pkg create
is called, it should allow for a number of packages to be reproducible.
—
Reply to this email directly, view it on GitHub
https://github.com/jrmarino/synth/issues/206, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAISZ5SQIKAW4KHH2CDFOQ3U4U2YHANCNFSM5PFLAH4Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

you could actually have a script update an environment file that synth picks up.
from man page
<profile>-environment
		       This is an optional, user-provided file.	It contains a
		       list of name-value pairs	joins with an equals sign
		       (e.g. HTTP_PROXY=http://proxyserver:8888/), one pair per
		       line.  If the file exists, these	variables will be de-
		       fined in	the builder environment.  For the default pro-
		       file, the file would normally be	located	at
		       /usr/local/etc/synth/LiveSystem-environment

so you can set SOURCE_DATE_EPOCH yourself in that file


No provider for NgModel when trying to implement pagination

Trying to implement pagination but cannot get past this error. I've followed exactly what's showing on https://valor-software.com/ng2-bootstrap/#/pagination.
My template shows
<pagination [totalItems]='totalItems' [(ngModel)]='currentPage' (pageChanged)='pageChanged($event)' class='pagination-sm'></pagination>
Here's my component
import { Component, AfterViewInit, ViewChild } from '@angular/core';
import { MODAL_DIRECTVES, BS_VIEW_PROVIDERS, ModalDirective, PAGINATION_DIRECTIVES } from 'ng2-bootstrap/ng2-bootstrap';
import { ValidationFormComponent } from '../validation-form/validation-form.component';
import { UserTemplateComponent } from '../../user-template/user-template.component';
import { User } from '../../../../services/user/user.model';
import { TranslateService, TranslatePipe } from 'ng2-translate/ng2-translate';
import { CORE_DIRECTIVES } from '@angular/common';
import { REACTIVE_FORM_DIRECTIVES, NgModel } from '@angular/forms';

@Component({
  moduleId: module.id,
  selector: 'app-results',
  templateUrl: 'results.component.html',
  pipes: [ TranslatePipe ],
  directives: [MODAL_DIRECTVES, ValidationFormComponent, PAGINATION_DIRECTIVES, CORE_DIRECTIVES, REACTIVE_FORM_DIRECTIVES],
  viewProviders:[BS_VIEW_PROVIDERS],
})

Am I missing something? Anyone else running into this issue?

Yes, I'm having the same issue.
No provider for NgModel (" [ERROR ->]<pagination #pagination [totalItems]="activeData.length" [itemsPerPage]="settings.pageSize" [(ngModel")

the same issue

Same here

I am having following error
BaseException {message: "No value accessor for ''", stack: "Error: No value accessor for ''↵    at new BaseExc…idges/assets/scripts/polyfills.bundle.js:9320:23)"}

@Vasant2411 i have the same problem with Datepicker too even when used without the pagination. #822

Same issue with Timepicker as well, here's a stack overflow link explaining the issue I am seeing.
http://stackoverflow.com/questions/38796011/how-to-use-new-forms-with-ng2-bootstrap-timepicker

+1

+1 (Angular2 RC4)

I had this same issue with pagination: No value accessor for ''
The answer, for me, was that I was still including NgModel:
@Component({
    ...
    directives: [ FORM_DIRECTIVES, NgModel ]
    ...
})

Once I got rid of the NgModel reference, it worked fine:
@Component({
    ...
    directives: [ FORM_DIRECTIVES ]
    ...
})

Hope this helps someone out!

Just an update: I think that pagination might be broken for other reasons. It seems that the pageChanged event isn't firing. Perhaps this is related to #821. I'm not sure what exactly is happening, but this issue does not relate to the issues at hand here.


[WIP] [not-for-merging] [COLRv1] Exploring/discussing PaintScale, PaintLocation

This adds PaintScale, PaintVarScale as well as PaintLocation and PaintVarLocation, to explore and evaluate googlefonts/colr-gradients-spec#277 and googlefonts/colr-gradients-spec#279

I suggest you split the two changes and ask Rod that the Scale one be merged soon.

I suggest you split the two changes and ask Rod that the Scale one be merged soon.

Ok, thanks, will do!

Closing, as it's stale and half redundant as PaintScale became official. The other half (PaintLocation) will redone later.