DiagPart Operator

Implemented the get diagonal GetDiag operator #824
I believe numpy is also trying to have two different operators, but they are using diagonal and diagflat for their names.  GetDiag sounds reasonable to me, but discussion welcome.

Can one of the admins verify this patch?

Thank you for the contribution!  I added a bunch of comments.  Let me know when I should take another look.

wow, thanks a lot for the detailed comments.  I'll work on the fixes and resubmit.  Since it hasn't merged yet, is it ok if I do a force push to squash the commits or leave them separately?

A force push is good.

Seems like a forced push erases your line comments, unfortunately.  I have addressed your concerns earlier.  Including indentation issues, removed unnecessary template parameter, documentation, and test matrices.
One thing I realized from looking at numpy code, shouldn't diagonals be where all the indices are the same instead of how it is now?  I mostly reversed the diag operator for this commit though.
Thanks.

Thanks, getting much closer!  I guess add commits for now if forcing removes old comments, and once everything is good we can squash into one.

I was thinking if get_diag a good name for the operation ?  reading the doc and having diag and get_diag feels a bit confusing

@Mistobaan: I don't much like it either, but I haven't thought of something good yet.  Do you have suggestions?

Ah, got it!  diag_part.

Diagflat in numpy is actually the "diag" operation here, (which diagflat doesn't make sense to me either).  Having diag_part might be confusing to numpy users.  I thought of using ExtractDiag for this commit and CreateDiag for the existing "diag" operation, but not sure if you wanted names that long.

diag_part is mathematically unambiguous and matches common usage ("the diagonal part of A").  It's unfortunately that numpy is different, but get_diag is just as bad there.

Ok, give me a few minutes to finish working on the rintop pull request and
I'll change the name in this one.
On Wed, Mar 2, 2016, 1:28 PM Geoffrey Irving<EMAIL_ADDRESS>wrote:

diag_part is mathematically unambiguous and matches common usage ("the
diagonal part of A"). It's unfortunately that numpy is different, but
get_diag is just as bad there.
—
Reply to this email directly or view it on GitHub
https://github.com/tensorflow/tensorflow/pull/1265#issuecomment-191439791
.

Thanks for the time spent reviewing the code!  Hopefully this is good for now.
Should I add offset in the future in both diag and diag_part?

Looks good, thank you!  @vrv: How does one run tests and get this merged?

Yep, an offset would be a reasonable addition for a future CL, but it has the unfortunate issue that it would ideally be an input rather than an attr, and adding new inputs is awkward to do in a backwards compatible way.
Also, before we merge (but perhaps after the tests?) we should squash this into one commit.  Thanks for keeping it separated for now to make it easier to incrementally review.

@girving I think you just say "jenkins, test this please" and it will trigger the tests.
So, should I work on offset for this first before we merge?
Also, for both of these operations should there be a value to indicate the diagonal that is created and extracted?
For example:
dim=0 => A[i, i, i, i, i, i]
dim=1 => A[i, j, i, j, i, j]
dim=2 => A[i, j, k, i, j, k]
etc.

only admins can trigger it :)
@tensorflow-jenkins: test this please

Let's leave generalizations to a separate CL.  The symmetry of your existing change is good, since it doesn't change the existing op and adds it's one sided inverse.

I just squashed the commits.

@tensorflow-jenkins: test this please

Merged


Protocol tests issue 31

Description

This PR fixes DOTNET-7357 issue 31. Issue 31 Rest-XML Requests, not setting the xmlNamespace on individual member values

(Review manual changes) commit ac7f65da382 - Fixes for issue 31.
(Reference generated changes) commit 0f424130564 - Generated changes for issue 31.

MERGE into protocol-tests feature branch only
Builds on prior PR: https://github.com/aws/aws-sdk-net/pull/3261
Merge order: 110 (I'm going to start mine from 100 and increment to keep separate from Bo's)
Ticket: DOTNET-7357
Motivation and Context

Testing

N/A - the test cases are the protocol tests. A final dry-run will be done on the protocol-tests feature branch once everything is merged into the feature branch.
Screenshots (if appropriate)
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have read the README document
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

License

[x] I confirm that this pull request can be released under the Apache 2 license

For real services, there are only whitespace changes. Only the test services have real changes


Fix FindCommand bug

Codecov Report

Merging #226 (0d3e8ba) into master (90a3e8d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

:exclamation: Current head 0d3e8ba differs from pull request most recent head 3495648. Consider uploading reports for the commit 3495648 to get more accurate results

@@             Coverage Diff              @@
##             master     #226      +/-   ##
============================================
+ Coverage     79.58%   79.60%   +0.01%
  Complexity      707      707
============================================
  Files            92       92
  Lines          2116     2118       +2
  Branches        275      277       +2
============================================
+ Hits           1684     1686       +2
  Misses          384      384
  Partials         48       48

Impacted Files
Coverage Δ

...java/seedu/address/logic/commands/FindCommand.java
92.85% <100.00%> (+0.54%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90a3e8d...3495648. Read the comment docs.


enumerateToAssignBlocksForUploadTask

Trying to use .enumerateToAssignBlocksForUploadTask and am continually getting the following error:
Cannot assign value of type 'AutoreleasingUnsafeMutablePointer<AWSS3TransferUtilityUploadProgressBlock?>' (aka 'AutoreleasingUnsafeMutablePointer<Optional<(AWSS3TransferUtilityUploadTask, Int64, Int64, Int64) -> ()>>') to type '(@convention(block) (AWSS3TransferUtilityUploadTask, Int64, Int64, Int64) -> Void)?'

Tried following https://github.com/awslabs/aws-sdk-ios-samples/issues/28
transferUtility?.enumerateToAssignBlocksForUploadTask({ (task, var progress, var completion) -> Void in
            NSOperationQueue.mainQueue().addOperationWithBlock() {
            if self.currentUploadTask == nil {
                self.currentUploadTask = task
            }
            if self.currentUploadTask?.taskIdentifier == task.taskIdentifier {
                var uploadProgressBlock: AWSS3TransferUtilityUploadProgressBlock? = {
                    (task,bytesSent,totalBytesSent, totalBytesExpectedToSend) in
                    NSOperationQueue.mainQueue().addOperationWithBlock() {
                        let progressValue = Float(totalBytesSent)/Float(totalBytesExpectedToSend)
                        self.uploadProgressView.progress = progressValue
                    }
                }
                var completionBlock:AWSS3TransferUtilityUploadCompletionHandlerBlock? = {
                    (task, error) in
                    NSOperationQueue.mainQueue().addOperationWithBlock() {
                        self.currentUploadTask = nil
                        self.uploadProgressView.progress = 0
                        self.checkForUploadingTasks()
                    }
                }
                let progressPointer = AutoreleasingUnsafeMutablePointer<AWSS3TransferUtilityUploadProgressBlock?>(&uploadProgressBlock)
                let completionPointer = AutoreleasingUnsafeMutablePointer<AWSS3TransferUtilityUploadCompletionHandlerBlock?>(&completionBlock)
                progress.memory = progressPointer
                completion.memory = completionPointer
                }
            }
            }, downloadTask: nil)

Hi aTylerRice, you could achieve it by using progress.memory = progressPointer.memory

I am using almost identical code to what is above.  For the following lines:
progress!.memory = uploadProgressBlock
completion!.memory = completionBlock

I get the error "Cannot assign to property: 'memory' is a get-only property."  I have tried explicitly unwrapping progress and completion (as shown here), and also leaving them as optionals.  I get a compiler error if I don't use ! or ?
Is this newly broken?  Thanks.


tmux plugin autocompletion produces segfault

I'm getting a segfault when try to use the first tab completing using the tmux plugin.
The segfault is so similar with the issue #2044 but It's for taskwarrior plugin and it has been fixed zsh-users/zsh@844e569.
This only happens on urxvt. I already tested it on xfce4-terminal and terminator and works well.
urxvt: 9.22
zsh: zsh 5.3.1 (x86_64-unknown-linux-gnu)
tmux: 2.3
distro: archlinux
Some clue ?

forgot about it.
It's a urxvt bug using tmux. I just figured it out.
GNU gdb (GDB) 7.12.1
Copyright (C) 2017 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from urxvt...(no debugging symbols found)...done.
(gdb) run
Starting program: /usr/bin/urxvt -e .builds/vim/src/vim
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
0x000000000041cf44 in rxvt_term::scr_refresh() ()
(gdb) bt
#0  0x000000000041cf44 in rxvt_term::scr_refresh() ()
#1  0x000000000041ea22 in rxvt_term::flush() ()
#2  0x0000000000439bce in ev_invoke_pending() ()
#3  0x000000000043a61d in ev_run ()
#4  0x00000000004192e3 in main ()
(gdb)


Arrow Flight format support for StringViewArray and BinaryViewArray

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
This is part of the larger project to implement StringViewArray -- see https://github.com/apache/arrow-rs/issues/5374
This ticket tracks adding Arrow Flight support
Describe the solution you'd like
Since Arrow Flight is based on the IPC format,  https://github.com/apache/arrow-rs/issues/5506 may be sufficient.
To close this ticket, we should add tests that demonstrate sending  / receiving StringViewArray and BinaryViewArray over Arrow flight (e.g. using FlightDataEncoder)
Describe alternatives you've considered

Additional context

I can take a look at this (as a way to teach myself some arrow flight knowledge). I have limited bandwidth though, so feel free to bypass me and pushing this forward.

Thanks @XiangpengHao  -- I think the first thing to do is write a test for StringViewArray and BinaryViewArray for the data encoder/decoder:  https://github.com/apache/arrow-rs/blob/master/arrow-flight/tests/encode_decode.rs (I think you can just follow the existing examples)
It may be the case that it "just works" 🙏

label_issue.py automatically added labels {'arrow'} from #5481


attrib command reference is not up-to-date

We need to update https://docs.microsoft.com/windows-server/administration/windows-commands/attrib
because it is too old.
Recently we have File-On-Demand function in OneDrive, and we can control the file attributes such as "online", "off-line" etc.
to use the command "attrib";
e.g. "attrib +U -P /s".
But "+U" or "-P" options are not mentioned in the reference page;
https://docs.microsoft.com/windows-server/administration/windows-commands/attrib
Actually this page was updated on Oct-2017 (so old), and we need to update this page to include these new options.
We have many options for ATTRIB function;
ATTRIB
[+R | -R] [+A | -A] [+S | -S] [+H | -H]
[+O | -O] [+I | -I] [+X | -X] [+P | -P] [+U | -U]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 62650d46-4208-8880-2c41-1d7220bfdd89
Version Independent ID: 9577a78a-7c08-0e57-d507-a7e96a335660
Content: attrib
Content Source: WindowsServerDocs/administration/windows-commands/attrib.md
Product: windows-server
Technology: manage-windows-commands
GitHub Login: @coreyp-at-msft
Microsoft Alias: coreyp

Fair point. Lots of the Windows Commands pages could be updated to contain more precise and up to date information from the help text in the command itself.
Please note that it will be necessary to point out where any parameter or argument specific to online services or cloud solutions will be described, in contrast to local filesystem command usage.
Feel free to open a Pull Request for the changes you would like to see in the documentation page, or simply post a comment here containing the text & format of your suggested change.

Hey AjayvFTC,
Thanks again for contacting Microsoft. We value your feedback.
A documentation update has been made adding the missing parameters for attrib and will be live after the next business day. We will now be closing this thread.
Thank you and have a most pleasant day.
#please-close


Some problem about your paper and code

Hello ! Your work for ood detection is wonderful ! But I notice that you don't mention how you get a ood counter-part of an id object in your paper. Could you please tell me how you distill an ood object in your code? Thanks !

hi, @HopeFinder , thanks for your interest in our work!
please see in section 3.1 of the main paper to get a sense of the method.
for code, please see https://github.com/deeplearning-wisc/stud/blob/main/src/modeling/self_supervised/cycle_energy_direct_add_all.py for details.

hi, @HopeFinder , thanks for your interest in our work!
please see in section 3.1 of the main paper to get a sense of the method. for code, please see https://github.com/deeplearning-wisc/stud/blob/main/src/modeling/self_supervised/cycle_energy_direct_add_all.py for details.

By reading your paper and code carefully, I know the answer. Thank you !


added categories in school

@aksanoble @vibhutipratapsingh @harisibrahimkv  - are the categories coming from the database?


Request to add my school to JetBrains

@IAmLifeIsGames maruapula.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@IAmLifeIsGames I am sorry, I have to close the request without merging, because you made a mistake in a request and did not specify any filepath. Please ensure that you are familiar with this repository rules located at the bottom of this page and make a new correct request. Thank you for the understanding!

Oh, sorry


adapter-node Middleware + entryPoint example does not work as expected

Describe the bug
I tried to create a SvelteKit app based on the Middleware example currently in adapter-node README (1.0.0-next.53) but the '/no-svelte' route does not get triggered as expected.
https://github.com/sveltejs/kit/tree/master/packages/adapter-node#middleware
when you make a src/server.js file the same and run it the '/no-svelte' GET endpoint just outputs the 'Hello world!' middleware function to console and returns a 404 to browser
Reproduction
demo repo:
https://gitlab.com/drschwabe/sveltekit_middleware-bug
server file and code that is not running when attempting GET on /no-svelte
https://gitlab.com/drschwabe/sveltekit_middleware-bug/-/blob/master/src/server.js#L15
Logs
No response
System Info
System:
    Memory: 2.15 GB / 15.58 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 16.10.0 - ~/n/bin/node
    Yarn: 1.22.10 - ~/n/bin/yarn
    npm: 7.24.0 - ~/n/bin/npm
  npmPackages:
    @sveltejs/adapter-node: ^1.0.0-next.53 => 1.0.0-next.53
    @sveltejs/kit: next => 1.0.0-next.178
    svelte: ^3.42.6 => 3.43.1

Severity
annoyance
Additional Information
No response

I checked it on my local machine and it appears to be working fine both polka and express with using app.all('*', assetsMiddleware, prerenderedMiddleware, kitMiddleware);.
But I'm not sure this statement is natural or easy to understand for express users.
(I would like to know other users' opinions.)

But I'm not sure this statement is natural or easy to understand for express users.

As an Express user I understand what this does, but I would wonder why it was done this way. Can we add a comment to the example?
// SvelteKit middleware comes after your own middleware / routes and only runs when your app didn't handle the request already.
app.all('*', assetsMiddleware, prerenderedMiddleware, kitMiddleware);.

// If you are using Express you can also use regular middleware syntax, as in Polka the order is different.
// See https://github.com/lukeed/polka#middleware-sequence
// app.use(assetsMiddleware, prerenderedMiddleware, kitMiddleware);


iobroker.deconz crash on scene recall..

Ich habe gerade in der 1.2.5 entdeckt, dass ein szenen recall den adapter crasht:
Ich habe gerade in der 1.2.5 entdeckt, dass ein szenen recall den adapter crasht:
deconz.0 2020-02-10 14:09:15.213 info (16240) Code 404: Ressource not found get devices: []
deconz.0 2020-02-10 14:09:15.206 debug (16240) Code 200: Request succeded get all groups: {"11":{"action":{"bri":127,"colormode":"hs","ct":0,"effect":"none","hue":0,"on":false,"sat":127,"scene":null,"xy":[0,0]},"devicemembership":[],"etag"
deconz.0 2020-02-10 14:09:14.946 debug (16240) Code 200: Request succeded get all sensors: {"1":{"config":{"configured":true,"on":true,"sunriseoffset":30,"sunsetoffset":-30},"etag":"164aea2cc7392f5aec9684535f72e544","manufacturername":"Phi
deconz.0 2020-02-10 14:09:14.565 debug (16240) Code 200: Request succeded get all lights: {"1":{"ctmax":454,"ctmin":250,"etag":"83c947395a7054d6fc1e34485bf108a6","hascolor":true,"manufacturername":"IKEA of Sweden","modelid":"TRADFRI bulb E
deconz.0 2020-02-10 14:09:14.509 info (16240) deConz Version: 2.5.72; API version: 1.16.0
deconz.0 2020-02-10 14:09:14.498 debug (16240) Code 200: Request succeded get config: {"UTC":"2020-02-10T13:09:14","apiversion":"1.16.0","backup":{"errorcode":0,"status":"idle"},"bridgeid":"00212EFFFF03B313","datastoreversion":"60","devic
deconz.0 2020-02-10 14:09:14.241 info (16240) starting. Version 1.2.5 in /opt/iobroker/node_modules/iobroker.deconz, node: v10.17.0
deconz.0 2020-02-10 14:08:40.683 info (13477) Terminated (NO_ERROR): Without reason
deconz.0 2020-02-10 14:08:40.681 info (13477) terminating
deconz.0 2020-02-10 14:08:40.672 debug (13477) Websocket connection closed
deconz.0 2020-02-10 14:08:40.667 error (13477) TypeError [ERR_INVALID_ARG_TYPE]: The first argument must be one of type string or Buffer. Received type object at write_ (_http_outgoing.js:595:11) at ClientRequest.write (_http_outgo
deconz.0 2020-02-10 14:08:40.666 error (13477) uncaught exception: The first argument must be one of type string or Buffer. Received type object
deconz.0 2020-02-10 14:08:40.613 debug (13477) dp: recall; id:Groups.47.Scene_1
deconz.0 2020-02-10 14:08:40.612 debug (13477) stateChange Groups.47.Scene_1 {"val":true,"ack":false,"ts":1581340147512,"q":0,"from":"system.adapter.admin.0","user":"system.user.admin","lc":1581162661852}

Fehler war nicht nur auf scene recall beschränkt und sollte mit der 1.2.6 behoben sein.


[Event Request] Table 5896 "Inventory Adjmt. Entry (Order)" CalcDiff

Hello,
in table 5896 "Inventory Adjmt. Entry (Order)", function CalcDiff, please add the following event:

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


UUID bug on Bungeecord Servers

Hey Guys,
I already had this bug with PermissionsEX and thought it would work with LuckPerms, but it doesn't.
So if I give myself the Admin Rank I've got in on the Lobby-UUID only and not on the other Servers like CityBuild. I know you can fix that problem with RedisBungee, but I wanted to ask if there's another option (a free one).

This sounds more like a request for support which would be far more suited for the discord

Check that you actually setup BungeeCord properly, as in enabling bungeecord in the spigot.yml on all servers and enabling ip-forwarding in the config.yml of the BungeeCord.
Servers, that aren't setup properly will create and use their own UUIDs based on the name of the player, rather than using the one provided through ip-forwarding, as this is how Offline-mode servers work.

ah thanks :dagger:

Thank you so much <3


chore: upstream norm_cast attributes and tests

Unfortunately, the test file is broken, and so far I can't work out why.
Standalone repro (which maybe shouldn't work on master, because of missing attributes, but I hope will work here):
example (an bn : Nat) : (an : Int) ≠ (bn : Int) ↔ an ≠ bn := by norm_cast

is failing with unsolved goals.
So far my attempt to understand what has changed is running
import Std.Tactic.NormCast
import Std.Tactic.ShowTerm
import Std.Data.Int.Init.Lemmas

example (an : Nat) : (an : Int) ≠ 0 ↔ an ≠ 0 := by show_term norm_cast

on Std's main branch. This prints
exact Eq.mpr (id (congrArg (fun x => ¬x ↔ ¬an = 0) Std.Data.Int.Init.Lemmas._auxLemma.3)) Iff.rfl
which is unfortunate: the trailing .3 in the name makes it hard to see what this lemma is. (I know @kmill? had a tool for inspecting these numeric named declarations, but I can't find it.)
At least this gives a clue that it is a lemma in Std.Data.Init.Init.Lemmas that is missing. However I'd verified that the 5 @[norm_cast] attributes there are faithfully reproduced in this PR.

@semorrison Here might be what I shared before:
import Lean

open Lean Meta Elab

/-- Whether the lemma has a name of the form produced by `Lean.Meta.mkAuxLemma`. -/
def Lean.Name.isAuxLemma (n : Name) : Bool := n matches .num (.str _ "_auxLemma") _

/-- Unfold all lemmas created by `Lean.Meta.mkAuxLemma`. These end in `_auxLemma.nn` where `nn` is a number. -/
def Lean.Meta.unfoldAuxLemmas (e : Expr) : MetaM Expr := do
  deltaExpand e Lean.Name.isAuxLemma


Update GLTFImporter.cs

Importing a model that reuses an instance of a mesh several times will throw an InvalidOperationException. This renders the asset invalid (no import settings show up). Skipping this error with try/catch leaves no errors.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

CI check failed due to "Aborting batchmode due to failure: Asset not found: Assets/UnityGLTF".
But why?...


ARROW-1413: [C++] Add include-what-you-use configuration

This adds iwyu make target to run include-what-you-use on all changed files of the current branch. As suggested in the ticket https://issues.apache.org/jira/browse/ARROW-1413 I took the code of apache-kudu as a starting point and added a few modifications.
While it works fine locally, I'm struggling to get it to work (i.e. build is failing) on travis. Somehow the check isn't performed without raising an error. I expect that clang doesn't have the iwyu properly installed but I couldn't verify it, yet.
Also, the tool requires a compile_commands.json to be present including all the files to be checked which is why I added the export CMAKE_EXPORT_COMPILE_COMMANDS=1 to the travis_env_common.sh
This may be an issue since we are partially compiling multiple times but never the full codebase which is why I included the make/ninja iwyu twice.

I don't think it's necessary to run this on every build in Travis as it will primarily inflate our build times, only that we do a manual cleanup periodically (e.g. a couple times a release cycle)

@fjetter can you capitalize the "Arrow" in the PR title? I will take this for a spin when I can and then merge, sometime in the next couple days

I took this for a spin and I'm not really sure this produces the expected results. At least we need to tune the iwyu configuration a lot.

We definitely should not be applying automated changes. iwyu does require a ton of tuning

@wesm I'd remove the travis stuff again or do you want to keep it? Currently it doesn't do anything.

Can you remove it ("ninja iwyu", etc.) from the Travis scripts for now?

Forgot I have push permissions on your fork, I can take it from here

+1. I will wait for the build to pass

@wesm if you want to invoke it on the whole code base you can simply add cmake -DCMAKE_CXX_INCLUDE_WHAT_YOU_USE=iwyu <iwyu args> to the cmake arguments. It takes care for you of the compilation database and prints the output of iwyu to stdout
c.f. https://cmake.org/cmake/help/v3.9/prop_tgt/LANG_INCLUDE_WHAT_YOU_USE.html?highlight=include
For including it in the build chain, though, I would've preferred a partial check.


[Bug Report] Enviroment create by create_venv.sh fails to initialize PyTorch

Describe the bug
Currently a completely new environment created by create_venv.sh will install numpy 2.0. However the installed torch 2.1.0 is not compatible with it. Leading the the following error upon import ttnn.
Python 3.10.12 (main, Jul 29 2024, 16:56:48) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import ttnn
2024-08-17 00:03:14.053 | DEBUG    | ttnn:<module>:82 - Initial ttnn.CONFIG:
Config{cache_path=/home/marty/.cache/ttnn,model_cache_path=/home/marty/.cache/ttnn/models,tmp_dir=/tmp/ttnn,enable_model_cache=false,enable_fast_runtime_mode=true,throw_exception_on_fallback=false,enable_logging=false,enable_graph_report=false,enable_detailed_buffer_report=false,enable_detailed_tensor_report=false,enable_comparison_mode=false,comparison_mode_pcc=0.9999,root_report_path=generated/ttnn/reports,report_name=std::nullopt,std::nullopt}

A module that was compiled using NumPy 1.x cannot be run in
NumPy 2.0.1 as it may crash. To support both 1.x and 2.x
versions of NumPy, modules must be compiled with NumPy 2.0.
Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.

If you are a user of the module, the easiest solution will be to
downgrade to 'numpy<2' or try to upgrade the affected module.
We expect that some modules will need time to support NumPy 2.

Traceback (most recent call last):  File "<stdin>", line 1, in <module>
  File "/home/marty/Documents/tt-metal/ttnn/ttnn/__init__.py", line 229, in <module>
    import ttnn.operations
  File "/home/marty/Documents/tt-metal/ttnn/ttnn/operations/__init__.py", line 11, in <module>
    _module = loader.find_spec(module_name).loader.load_module(module_name)
  File "/home/marty/Documents/tt-metal/ttnn/ttnn/operations/binary_backward.py", line 8, in <module>
    from ttnn.operations.complex_binary_backward import (
  File "/home/marty/Documents/tt-metal/ttnn/ttnn/operations/complex_binary_backward.py", line 6, in <module>
    import torch
  File "/home/marty/Documents/tt-metal/python_env/lib/python3.10/site-packages/torch/__init__.py", line 1477, in <module>
    from .functional import *  # noqa: F403
  File "/home/marty/Documents/tt-metal/python_env/lib/python3.10/site-packages/torch/functional.py", line 9, in <module>
    import torch.nn.functional as F
  File "/home/marty/Documents/tt-metal/python_env/lib/python3.10/site-packages/torch/nn/__init__.py", line 1, in <module>
    from .modules import *  # noqa: F403
  File "/home/marty/Documents/tt-metal/python_env/lib/python3.10/site-packages/torch/nn/modules/__init__.py", line 35, in <module>
    from .transformer import TransformerEncoder, TransformerDecoder, \
  File "/home/marty/Documents/tt-metal/python_env/lib/python3.10/site-packages/torch/nn/modules/transformer.py", line 20, in <module>
    device: torch.device = torch.device(torch._C._get_default_device()),  # torch.device('cpu'),
/home/marty/Documents/tt-metal/python_env/lib/python3.10/site-packages/torch/nn/modules/transformer.py:20: UserWarning: Failed to initialize NumPy: _ARRAY_API not found (Triggered internally at ../torch/csrc/utils/tensor_numpy.cpp:84.)
  device: torch.device = torch.device(torch._C._get_default_device()),  # torch.device('cpu'),

To Reproduce
Steps to reproduce the behavior:

Delete existing environment
Create a new one using create_venv,sh
Activate the environment
Run python and enter import ttnn
See error

Expected behavior
Torch should not fail to install
Screenshots
If applicable, add screenshots to help explain your problem.
Please complete the following environment information:

OS: Ubuntu 22.04
Commit: fd4691f9469aecd08c3db921f130039841a778f4

Additional context
If failing to create a new env. Please see my workaround

Here is the following workaround:

Numpy Compatibility Issue:
During the initial setup, there was an error related to the version of numpy. This was resolved by downgrading the numpy package as follows:

pip install "numpy<2"

Issue with ttnn Import in Pytest:
While importing torch in the Python shell worked fine, running tests with pytest resulted in an import error:

E   ImportError: cannot import name 'ConcatMeshToTensor' from 'ttnn' (unknown location)

To resolve this, I un-commented the previously commented section in the create_venv.sh script and ran it again, which downgraded the pip version:
echo "Forcefully using a version of pip that will work with our view of editable installs"
pip install --force-reinstall pip==20.1.1

will look into this today

https://github.com/tenstorrent/tt-metal/issues/11144#issuecomment-2318184316

@tt-rkim for this PR. I think it's a different problem then the pip one. Can we simply add numpy<2 to the requirements and close this issue?

Can we close this @marty1885 ? It's now on main.
Pls check

Thanks. Closing


[WIP] Pulse, SamplePulse, & ParametricPulse moved to pulse/types.py & imports updated

Summary
Fix #4074
Details and comments
Created pulse/types.py and moved Pulse, SamplePulse, and ParametricPulses to types. Removed from pulse_lib, pulse.py and sample_pulse.py. Removed ParametricPulses class from parametric_pulses.py and left remaining code.
Updated all __init__.py files and any affected imports in any of the .py files under pulse. Removed the empty channels dir. Left the mostly deprecated commands dir.

I still don't think types is the right name for a file of Pulses. If anything, there could be a type module with all "types" not just one @taalexander

@taalexander I'm still unconvinced that this is an improvement, but maybe this would be a compromise:
pulse/channels.py
    # Contains DriveChannel, AcquireChannel, MeasureChannel, ControlChannel
pulse/pulses.py
    # Contains SamplePulse, Constant, Drag, Gaussian, GaussianSquare
pulse/types.py
     # contains class Pulse, ParametricPulse, and class Channels

it's closer to what you want while being transparent about what things are and where they are.

I am ok with this, although maybe it makes sense for the Parametric pulse implementations to lives in library. MemorySlot and RegisterSlot could also live in types.
Another option:
Have a types package with:

base (Pulse, Channel, Register)
pulses (Waveform, Parametric, Gaussian, ...)
channels (...)

A final option would be to put all of these in a single module types.

So, your first rec would look like:
pulse/pulse_lib/          # soon to be 'library'
    ...
    sample_pulse.py       # soon to be 'waveform.py'
    parametric_pulses.py  # Gaussian, Drag, Constant, etc
pulse/channels.py
pulse/types.py  # contains Pulse, Channel, MemorySlot, RegisterSlot

I like this option a lot ^

It makes it clear where to get pulses from and keeps all the waveform-related stuff in one place: the pulse library
Thus, it's easy to find documentation for pulses in the API ref for library
It makes it easy to find available channels both in the code base and in the API ref
This doesn't require any deprecations to the user import paths (in this PR at least, since pulse_lib -> library will require user changes)
keeps each module focused on one subject
*** It satisfies the original task, which is to group together the types that are operated on by instructions in Pulse: Channels, Pulses, and classical memory.
Moving these classes to types will also improve the API Reference: when you are learning about types, you want a high level overview: you want to know what all the pieces are and how they fit into the big picture. When you are on a module level reference such as pulse.channels, you want to know what each channel does specifically and how to use it

The only change I might be hesitant to make is to have ParametricPulse and Waveform in types. They seem fundamental to me.

Yeah, I'd be hesitant about that, too, thinking about the user experience. I agree that keeping it in pulse.library is a nicer experience for them :)

Yeah, I'd be hesitant about that, too, thinking about the user experience. I agree that keeping it in pulse.library is a nicer experience for them :)

Could you please elaborate on the ways it is nicer? My thoughts are that library is a location of things that use preexisting class, like a standard library. However, Waveform and ParametricPulse are fundamental types that without these nothing in library could be defined.

@taalexander. I see there are some new issues, #4167, #4168, related to this. Are changes moving in that direction and if so, is this branch still relevant? Thanks.

@taalexander Do you mean Pulse? I agree that Pulse makes sense in types. Waveform is just a specific kind of Pulse that needs to be used and instantiated by the user, like Gaussian. The library creates Waveforms and ParametricPulses use the library. If you want library to be something that only uses pulse and not the other way around, we should move all the waveform related stuff somewhere else. Not sure a better name for that, though. pulse.pulses seems on the verge of losing meaning. Can you think of a better name?

@taalexander. I see there are some new issues, #4167, #4168, related to this. Are changes moving in that direction and if so, is this branch still relevant? Thanks.

It seems we are not quite clear on the scope of the required changes yet. I do believe your work is relevant, however, we should nail down the expected changes before we move forward to prevent additional frustration for you. Please bear with us.

@taalexander Do you mean Pulse? I agree that Pulse makes sense in types. Waveform is just a specific kind of Pulse that needs to be used and instantiated by the user, like Gaussian. The library creates Waveforms and ParametricPulses use the library. If you want library to be something that only uses pulse and not the other way around, we should move all the waveform related stuff somewhere else. Not sure a better name for that, though. pulse.pulses seems on the verge of losing meaning. Can you think of a better name?

I don't think everything must be in the perfect place. I still think types is the best place for keeping Waveform in the root pulse namespace, I would like to avoid putting it in library as it is fundamental enough that it should be available from pulse without in a sense having to call out to an external source. However, if you insist that it goes in library over types that is fine and we can move forward.

@enavarro51 @lcapelluto @taalexander : let me know what needs to be done on #4167  #4168 issues that I'm working and you have made a suggestion. to push it or not?

This [WIP] PR seems stalled for some time already, without any update. Does it make sense to keep it open?
ping @enavarro51 @lcapelluto @taalexander .

@1ucian0 I believe these changes were incorporated in #4662, so this PR can probably be closed. You may want to get confirmation from @taalexander or @lcapelluto.


fix flaky test caused by timing issue

Description
The eventhub test triggered by core-ci is failed. It's a flaky test.
According to the other tests https://github.com/Azure/azure-sdk-for-java/blob/cf84f4b8930cfb87b1362df258c0095583718e19/sdk/servicebus/azure-messaging-servicebus/src/test/java/com/azure/messaging/servicebus/ServiceBusProcessorTest.java#L412-L414
I found that processEvent and endSpan have the timing issue in https://github.com/Azure/azure-sdk-for-java/blob/cf84f4b8930cfb87b1362df258c0095583718e19/sdk/eventhubs/azure-messaging-eventhubs/src/main/java/com/azure/messaging/eventhubs/PartitionPumpManager.java#L275-L284
I take the same approach just like the other tests.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

https://github.com/Azure/azure-sdk-for-java/issues/26759

@lmolkova

LGTM.

@ZejiaJiang thanks you!


fix(fx-2865): hides default sort label for improved artwork filters flag

The type of this PR is: Bugfix
This PR resolves FX-2865
Description

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

#squashongreen


Solrizer pinned to 3.1.x

The Solrizer gem is pinned to a 2013 version, we should be able to relax it to ~> 3.1

I think #6 addressed this (perhaps more than you'd like?). We still would need to cut a release.

yes, fixed in 1388c03c80d1699e27d163c68d4fa4f12782ea9e


Fix new package XCTest file formatting and include throws keyword

Motivation: Fix formatting of the XCTest source file in newly init'ed library packages, and include the
throws keyword on the example XCTest method as a convenience to users and to promote use of throwing
XCTest methods.
Changes:

Fix a bug in the formatting of XCTest source files in InitPackage, where the closing """ string
terminator was outdented one level too far, which resulted in the file contents being indented unnecessarily.
Include the throws keyword on func testExample() in the new Library type package template.
Modify an existing test to validate these improvements.

rdar://77209458
rdar://77209464

@swift-ci please test

@swift-ci please smoke test

Looks like there's something broken in swift-driver?

/Users/buildnode/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/swiftpm/.build/checkouts/swift-driver/Sources/SwiftDriver/Jobs/Planning.swift:188:31: error: variable used within its own initial value

cc @artemcm

@swift-ci please smoke test macOS platform

Sorry, this was due to compiler version mismatch between swift-driver CI and self-hosted SwiftPM CI.
Patched in: https://github.com/apple/swift-driver/pull/617

@stmontgomery thanks for this! please note we would need another cherry-pick PR into release/5.5 if you want to include this in 5.5


Added vscode extension recommendation

Title: Add Visual Studio Code Extension Recommendation
Description
This PR introduces a .vscode/extensions.json file to the project, aimed at recommending the Vetur extension for Visual Studio Code users working on this Vue.js project. It addresses #343
Changes

Created a .vscode directory at the root of the project (if it didn't already exist).
Added an extensions.json file within the .vscode directory.
Specified "octref.vetur" as a recommended extension in extensions.json, encouraging contributors to install Vetur for enhanced Vue.js development support in VS Code.

Additional Notes

The extension that is recommeded supports vue version 2 .
The official docs recommend volar ( vue 3 ) which even works for vue 2 but for vue vesions lesser than 2.6.14 , some configs need to change

Extension page

If needed I will change the vue extension version from ve

@jvJUCA , sure

I have set prettier as the default formatter using settings.json file , do you want me to remove extensions recommendation then ?

Changes made in the latest commit :

Added prettier as the default formatter
Removed the extension recommnedation

Congratulations! 🎉 Your pull request has been accepted! Thank you for your valuable contribution.
Your changes have been merged successfully and will be included in the develop branch. Your effort in improving our project is greatly appreciated.
Thanks again for your contribution, and we look forward to your continued involvement in our project!
Best regards,
@jvJUCA


Fix contributing link

The link to the contributing docs in the readme is broken!

          1 Warning

:warning:
Found 6 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

121
301
http://www.markdowntopdf.com/ redirects tohttps://www.markdowntopdf.com/

133
301
https://ia.net/writer/ redirects tohttps://ia.net/writer

180
302
https://www.gitbook.com/ redirects tohttps://www.gitbook.com/?t=1

182
301
https://notehub.org/ redirects tohttps://topproreviews.com/

183
Error
https://stacktile.io/  SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed

191
301
http://commonmark.org/ redirects tohttps://commonmark.org/

  Generated by :no_entry_sign: Danger


getText(): one character short

It appears that there is one character short of the text in content editable component when getText() is invoked.
I simply attached the events config below into the fiddle at https://jsfiddle.net/glui2001/ukLaz8cm/
events: {
         keypress: function (editor, event) {
           console.log(editor.html());
           console.log(this.getText());
         }
}

See bug https://github.com/mervick/emojionearea/issues/30
only keyup event return real value
your fiddle with keyup
https://jsfiddle.net/ukLaz8cm/6/


Integration sheet models added: whereabouts, victoria-metrics-k8s-stack, velero-s3-deployment, vela-workflow

Notes for Reviewers
This PR fixes #5898
Signed commits

[x] Yes, I signed my commits.

@Jougan-0 the update command only deals with the latest component version... @SAHU-01, you updated the older manually, and did not use mesheryctl for this, right?

@Jougan-0 the update command only deals with the latest component version... @SAHU-01, you updated the older manually, and did not use mesheryctl for this, right?

I used the following mesheryctl commands for this:
./mesheryctl registry generate --spreadsheet-id "1ldfTx29vRmPOz95DJLyR5KeClHtxeYoEqaXpkKS3bsA" --spreadsheet-cred  $cred --model "model name"
./mesheryctl registry update -i ../server/meshmodel --spreadsheet-id "spreadsheet-id"  --spreadsheet-cred $cred

I suspect this PR might be out of date and no longer necessary. Is that the case, @SAHU-01 @Jougan-0?

I suspect this PR might be out of date and no longer necessary. Is that the case, @SAHU-01 @Jougan-0?

Yes, this is no longer required, I've added these on the main sheet, it will reflect on another PR tommorow


"Invoke Lambda Function" is not listing all lambda functions

When I am trying to Invoke Lambda Function on file in S3 bucket I am not able to see all the lambdas that I have in the drop down list.

Do you see some but not all functions in the control?

Yes.

Version <IP_ADDRESS> of the toolkit came out today which now lists all the functions not just the first page of functions returned by Lambda.

Version <IP_ADDRESS> of the toolkit came out today which now lists all the functions not just the first page of functions returned by Lambda.

I am with <IP_ADDRESS> and still facing the issue?

Sounds like you are using the preview VS 2017 version. For VS 2017 you need redownload the preview from original post which will install version <IP_ADDRESS>
https://aws.amazon.com/blogs/developer/preview-of-the-aws-toolkit-for-visual-studio-2017/


Update README.md

Replace all the "URL into a PDF file" to "Web Page into PDF file" from README.md

Thank you for the PR, don't forget to give a star. Your star would help increase the visibility of the project.


valueAtTime() to dynamically get a Path from a shape layer

Hey Hernan,
I'm trying to make a little letter writing exercise interactive.
Got started here: http://www.daandirk.com/write-on-test/
(Touchscreen version works in chrome.)
I was hoping to get the shape of the letter from a shape layer path with an expression:
thisComp.layer("lettershapes").content("Path 1").path.valueAtTime(thisComp.layer("#writeon").effect("current letter")("Slider")/25)
But bodymovin breaks on trying to make the json.
First i tried with Masks, but that doesn't work either, maybe because the paths aren't closed?
Otherwise i would have to resort to a very long not so dynamic if statement:
if(c+f==f){thisComp.layer("A").content("Path 1").path}else  if(c+f==f+1){thisComp.layer("a").content("Path 1").path}else if(c+f==f+2){thisComp.layer("B").content("Path 1").path}else  etc.
Is there another way to work around this?
Or what can I do to help?

That link doesn't seem to have the json working.
http://www.daandirk.com/wp-content/uploads/letters.json returns not found.

Oh sorry, my bad, was planning to replace it when i ran into the expression problem.

Where does it break? exporting the json file or when playing?
Also, instead of the long if statement, can't you do an array with all the characters and do something like:
var characters = ['a','b','c','A','B','C'];
thisComp.layer(characters[c+f]).content("Path 1").path

assuming c+f starts at 0 in this case.

Bodymovin breakdances when rendering the json.
If I try:

c = 0;
f = thisComp.layer("#writeon").effect("current letter")("Slider")/25;
var characters = ['a','b','c','A','B','C'];
thisComp.layer(characters[c+f]).content("Path 1").path

After Effects keeps telling me:

Path (line 4) of layer 2 ('#writeon') in comp 'letters', layer named 'a' is missing or does not exist. It may have been renamed etc.
Which is weird because it does. But maybe i can't reference a path that way?

Oh wait that does work.

I figured i can use index more easily.
Which does work in AE if i refer to the numbers from the Array, otherwise not.

c = thisComp.layer("#writeon").effect("first")("Slider");
f = thisComp.layer("#writeon").effect("current letter")("Slider");
var characters = [8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40];
thisComp.layer(characters[c+f]).content("Path 1").path

Unfortunately i get these errors with both types of Arrays:

firefox: TypeError: keyPropS.i[j] is undefined [Learn More]  bodymovin470.js:3215:25

chrome: Uncaught TypeError: Cannot read property '0' of undefined
at KeyframedShapeProperty.interpolateShape [as getPreValue] (bodymovin470.js:3215)

Any ideas?

can you send me the exported json?

Yes.

I updated to 4.7.1, but it is the same.
Here it is: http://www.daandirk.com/wp-content/uploads/letters.json

Looks like I got mixed up by the layer index in bodymovin starting with zero.
Also had some keyframes on a path that I wanted to reset that I think prevented me from doing that.


added logic for InsertionSort and unit tests. Updated readme

Your visual is awesome! Great work! Code looks good as well. Keep it up!


Fix bug where cached flagged transactions collapses into single lit, rather than separate lists for user types

Bug resolved.


POST json not stringified

According to docs:
json: true // Automatically stringifies the body to JSON

However that is not the case for me (3.0.0 and earlier). I need to manually call json.stringify on my body object and set json: true. Failure to do both causes body to be sent unencoded.
I did my testing by accessing the iContact API and using mock to dump out the requests where I can see when it fails and can see if the body is escaped or not.

Weird. This is my test code and it works as expected:
var express = require('express');
var bodyParser = require('body-parser');

var app = express();
app.use(bodyParser.json());

app.post('/json', function (req, res) {
    res.json({ more: req.body.some });
});

var server = app.listen(3333, function () {

    var rp = require('request-promise');

    var options = {
        method: 'POST',
        uri: 'http://localhost:3333/json',
        body: {
            some: 'payload'
        },
        json: true // Automatically stringifies the body to JSON
    };

    rp(options)
        .then(function (parsedBody) {
            console.dir(parsedBody.more);
        })
        .catch(function (err) {
            console.error(err);
        })
        .finally(function () {
            server.close();
        });

});

Hmm. I was using nock to dumo the requests and now i wonder if my errors were not related and that nock somehow parses my json making me think it was not stringified. Not being able to see the server requests its hard to debug so lemme close that and go have a beer.

Enjoy your beer! 🍻


Removes the usage of createClass and retrieving prop types from the main React package

@luislikescoffee There are conflicts


fix compensate num rows filtered in ExchangeNode

Proposed changes
Currently the success load rows is calculated by:
num_success_rows = num_total_rows - num_filtered_rows - num_unselected_rows.

When shuffle is on, ExchangeNode may filter some rows and increase num_filtered_rows and num_unselected_rows.
And OlapTableSink is unaware of those rows and won't count them in num_total_rows.
This PR fixes this problem by compensating filtered rows and unselected rows in ExchangeNode.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Implement isConnected() and setProvider() calls

What was wrong?
The Web3.isConnected() and Web3.setProvider() calls were not fully implemented.
How was it fixed?
Implemented and tested them.
Cute Animal Picture

Awesome work.

Merged and release as 1.1.0  (also apologies if you have to force pull.  I mucked up a merge)

Thanks!


Depend on Hlint as a library

This problem is discussed in HIE #1143.
If you depend on hlint as a library, it demands that the location of its data-files are known at compile-time.
This is fine, if you are using binary packages of hlint or build it with cabal/stack from source.
However, if you depend on hlint as a library, and want to distribute a static executable of your application, hlint will usually fail, because the location of its data-files is known at compile-time and baked into the application. Thus, it might happen that the data-files are not present on the installation system at the expected location.
To solve this problem, the following approaches can be chosen:

The application is responsible for distributing the data-files and configuring hlint correctly to find it.

Problem: How to configure the paths correctly?

Patch hlint to provide the data-files via source code, e.g. translate the hlint.yaml into a haskell source record and drop the data-files required for hlint. For customisation, a hlint.yaml can be written to $XDG_CONFIG_HOME on startup.

Problem: Might bloat the executable?

Applications should not depend on hlint as a library and create a run-time dependency for it.

Problem: Opens applications up for version conflicts.

What is your view on this issue? Which way would you suggest, and is there another, possibly better, way to address this issue?

My current mental model is the first one. I believe HLint already looks at several places for the data files, and there is a flag --datadir which let's you specify where to find data files. There are also places in the API that let you specify where files are.
I'm not such a fan of anything TH related as my experience is TH makes things deeply unpleasant - failures on users systems, slow compile, version changes etc.
Does that work for you?

We can make it work, it is a bit complicated though, since we have to distribute the data-files somehow.
I was thinking about using file-embed, to embed the data-files at compile-time and write them into some location and configure hlint accordingly. But this requires TH and, afaik, increases compile-time even more.
Another way, we can transform the data-files into default values ourselves in the project and write them to disk when we need them and configure hlint accordingly. This might, however, introduce a new hazard to keep hlint configurations up to date with upstream.
What may be the more sensible way?
To patch hlint, I wouldn't have thought about using TH, but rather replacing the data-files needed at run-time with default values in the executable.

The data values are quite large, so that would be a little unpleasant. file-embed does seem to be the cleanest approach... Where is the difficulty in just distributing the HLint data files directly? (I'm sure there is, I'd just like to understand it)

Maybe I got something wrong: When you use data-files and use cabal to find them at run-time, the data-file location is compiled into the executable, e.g. ~/.cabal/store/package/data/.... In the case of stack, it might also be <project>/.stack-work/.... I think it can be different locations as well, but dont know how specify that. If you delete the data folder, or move the executable to a different system, then these libraries are no longer present and the program fails. Moreover, it exposes information about the build system.

@fendor - somewhat. You can:

Use an environment variable hlint_datadir to override the data directory at runtime. That's available on all programs.,
You can pass --datadir=... to HLint and it will use that location instead. That's a feature I built into HLint to make it easier.
HLint will also look in . if it doesn't find good stuff in datadir.

Wasn't aware of the first option, that can be very helpful, thank you!
This is a good start, but for a fully functioning binary distribution still a hassle. It requires us to redistribute the data-files ourselves, which is, of course, a valid solution. This is the reason I created this issue, to learn the possibilities.
However, it still has the problem of exposing parts of the build environment, e.g. compile-time file location, if I see that correctly?
The last option is not really an alternative, since the defaults are not known then, right? Moreover, we have found that if the default files are not present, hlint throws an IOException. Is that correct or did we do something wrong?

The behaviour when HLint can't find its files is unspecified. If you want a particular behaviour I can change it, but my guess is it's not super useful regardless of what it does.
For HIE don't you typically compile it on a users computer? If so, isn't HLint not a problem? Or are you trying to change that?

We are trying to change that since the compile-times are quite long. Thus, we want to be able to distribute binaries, see #1068
Hlint was identified of having run-time dependencies (data-files) that we want to solve. You are right, it is not a problem if hie has been built from source.

Makes sense. I don't have a good way to solve this. If HLint had a command to copy its data files to some location, could you use that when compiling to generate a redistributable package that worked nicely?

I am not sure.
What would that imply?
Would it be required to install hlint as an executable on the user system? This is actually another totally valid solution, turning hlint into a full-fledged run-time dependency for hie.
I am also not sure about having a separate hlint.yaml for a potential global hlint and the hlint that is used by hie.

I meant during HIE building you build HLint in as a library. Run hlint --gather-deps=hie_install_dir, and then pass --data-dir=hie_install_dir when running on a users machine (or the equivalent in API form).

Yes, this would work, but I think this is already possible, right? With more template haskell, though.
Still, is it acceptable for the user to have two hlint.yaml's that influnece their lints, in your opinion?

I think HLint uses the first hlint.yaml it finds, and doesn't worry about the others, so that should be fine.

@ndmitchell I will try to add hlint --gather-deps=hie_install_dir to the packaging-process and let hie set the data-dir flag correctly.

Note there is no --gather-deps at the moment. There could be though (PR welcome). Or maybe you'd just want a mode that prints out the data dir and exits, letting you do a recursive copy.

This option seems a bit unnecessary. You can get the data-files directly by unpacking the release tarball. (cabal get hlint)

I will propably solve this using cabal get and --datadir=. Feel free to close.

Thanks, let me know if it doesn't work nicely.

@ndmitchell would you reconsider the TH approach?
It's not just nicer for using hlint as a library it's nicer when using the executable too. I'm on a 256G laptop and I delete ~/.stack when ever it gets past 10G. I install hlint using stack install, so when I delete ~/.stack hlint has to be rebuilt, just to get 3 data files.
Here's a commit using file-embed. The TH is relegated to one file. The executable actually gets slightly smaller 48117184 to 48020968 (GHC 8.8).

ping @ndmitchell


Startup and keep alive the analyzer/Kai runtime

Startup and keep alive the analyzer/Kai runtime
The plugin is responsible for managing the runtime (start, stop, restart) and for reporting its status.
Story highlights

After initial install / start of the extension, decide what needs to be done:

attempt to start the embedded servers with default configs, OR
open the configuration view to force user interaction to verify configuration

Configuration view should have a 'Test' button to:

verify the configuration is valid (according to some static criteria / schema validation),
verify the agent server can be started,
verify the server can receive initialization configuration and the response is a positive ack

Status indication on vscode's status bar

Show "status bar item" for the whole workspace

When an action is running, have a visual indicator (spinner)
Hovering the status shows brief information
Clicking the status indicator ...

Open relevant command palette?
Open configuration view?

Show "status bar item" for an open file

When changes for a file are being processed, have a visual indicator
Hovering the status shows a count of issues in the file
Clicking the status indicator ...

Open relevant command palette?
Open configuration view?

Provide logs to a selectable Output view

one log for any server being managed by the plugin
any other trace logging that could be useful

Command Palette

Open configuration view
Restart server (for each server that is manageable)

Considerations
...

This issue's stories are captured in doc https://github.com/konveyor/editor-extensions/blob/main/docs/roadmap/stories/02-manage_runtime.md
Further work towards implementing the stories and related wireframes should be opened as well bounded specific issues.


Anglo-centricism

If I wanted to praise Elon in non-Roman scripts like Japanese (イーロン) or Chinese (伊隆) I wouldn't get any points. What gives?

makes sense, given that Elon's rule of Twitter has been very Anglo-centric so far


Wrong migration schema generated when adding value to Enum

Describe the bug
To alter a column, the migration generator for SQLite creates a temp table, moves all existing data, and then renames the table. When using an enum column in SQLite, the CHECK directive is used with an IN to limit the values that can be inserted.
When adding a new value to an enum type, incorrect schema gets generated, example when adding a single value:
    this.addSql('CREATE TABLE `_knex_temp_alter011` (`id` integer PRIMARY KEY AUTOINCREMENT NOT NULL, `t` text check (`t` in (\'a\', \'b\', \'c\')) NOT NULL CHECK (`t` in(\'a\' , \'b\')));');

Reproduction
https://github.com/chrisbenincasa/reproduction-populate-hint/tree/enum-type-migration
Steps I took:

Create an Enum with 2 string values
Define an Entity with an Enum column and use the Enum from step 1
Generate an initial migration schema. At this point we'll have something like this:

    this.addSql('create table `a` (`id` integer not null primary key autoincrement, `t` text check (`t` in (\'a\', \'b\')) not null);');

Add a new string value to the Enum
Generate a new migration. This produces the 'temp table' migration, but the new table definition includes the CHECK statements for both the previous incarnation of the Enum and the new one:

    this.addSql('CREATE TABLE `_knex_temp_alter011` (`id` integer PRIMARY KEY AUTOINCREMENT NOT NULL, `t` text check (`t` in (\'a\', \'b\', \'c\')) NOT NULL CHECK (`t` in(\'a\' , \'b\')));');

What driver are you using?
@mikro-orm/sqlite
MikroORM version
6.2.9
Node.js version
20.11.1
Operating system
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Slack.
[X] The provided reproduction is a minimal reproducible example of the bug.

I stumbled on this while getting a reproduction for another bug. I'll document it here but let me know if you'd like me to open a new issue instead.
The second bug I found is that when adding an index to an entity (column or entity level) while also changing enum values, the enum value changes get dropped in the generated schema, despite the snapshot DB json getting updated (which can lead to some pretty wild behavior later on)
I've branched the reproduction from the initial bug to preserve its state: https://github.com/chrisbenincasa/reproduction-populate-hint/tree/new-index-no-enum

Those are most likely bugs in knex, that is what creates the temp table.

Ah yep. Looks like the first issue is there already: https://github.com/knex/knex/issues/4450
Not sure about the second issue though where some migrations aren't generated at all.

yeah, lol, and 3 years are gone and they ignore it completely. yet another reason to drop knex.
i will see what i can do, in the end, what knex is doing is a proper black magic which we don't need since we have all the necessary metadata in place. i think we could replace that with custom implementation relatively easily - there wont be major roadblocks, but it will be a lot of work.

No problem, I appreciate the effort (and have experienced your pain with an unwieldy but core dependency in other projects)!

So I came up with this workaround: #5683. I am not entirely happy with what I did there, but replacing the whole knex based implementation would be way too time-consuming.,


Add key rotation functionality

This will need:

[x]  gcloud integration to create new key + delete old one
[x]  aes-256-gcm-kms reencrypt capability
[x]  git integration (to update the source file)

fixed by #5


Cleanups after changes in ItemList signals

rmb_clicked replaced with empty_clicked
_file_list_rmb_pressed renamed to _file_list_empty_clicked
added additional arguments and check for the pressed button.
_file_list_rmb_clicked renamed to _file_list_item_clicked
removed extra argument from EditorFileDialog::_items_clear_selection (empty_clicked expects 2 arguments)

Continuation of the work done in #59720.

Are you sure that this code is not meant to be used? There was likely different logic based on whether a right click is done on an item (file or folder specific context menu) or empty space (actions that can be done in the current folder).

The method:
https://github.com/godotengine/godot/blob/e3371a53f845079e7f2bf67bbd76ace26c080978/editor/filesystem_dock.cpp#L2668-L2689
has not been used anywhere except here:
https://github.com/godotengine/godot/blob/e3371a53f845079e7f2bf67bbd76ace26c080978/editor/filesystem_dock.cpp#L3138
As far as I understand, this is a reworked version:
https://github.com/godotengine/godot/blob/e3371a53f845079e7f2bf67bbd76ace26c080978/editor/filesystem_dock.cpp#L2640-L2666
@Vitika9, can correct me here if I'm wrong.

This was not supposed to be removed. My PR included changing 'rmb_clicked(position)' and 'nothing_selected' to 'empty_clicked(position, mouse_button)'. Therefore, what you need to do is

replace 'rmb_clicked' with 'nothing_clicked'
change the name of '_file_list_rmb_pressed'   to '_file_list_empty_clicked' and adding a MouseButton parameter named p_mouse_button_index to it
add an early return to '_file_list_empty_clicked' if mouse button is not right.

This was not supposed to be removed. My PR included changing rmb_clicked(position) and nothing_selected to empty_clicked(position, mouse_button. Therefore, what you need to do is

replace rmb_clicked with nothing_clicked
change the name of _file_list_rmb_pressed to _file_list_empty_clicked and adding a MouseButton parameter named p_mouse_button_index to it
add an early return to _file_list_empty_clicked if mouse button is not right.

Yes, I thought about that too. Also, I would like to double-check everything again to make sure that I correctly understand how everything works and that I did not miss anything.

Initially, I misunderstood how the code works, because I experimented with normal FileSystem dock mode, but I needed to test it in the split mode.
By the way, I found an additional problem, I'll try to fix it.
https://user-images.githubusercontent.com/10379487/167605348-8a67485f-c8e0-4c97-940f-e2a600071056.mp4

By the way, I found an additional problem, but I think it can be fixed in another PR.

I can't seem to reproduce it in the current master branch (ccb583be091d3baf55365235cb35d4487ea3e911), so it might actually by these fixes. But it's not a big deal indeed so it can be left for a follow-up PR.

I can reproduce it in the current master branch (https://github.com/godotengine/godot/commit/ccb583be091d3baf55365235cb35d4487ea3e911) and in v4.0-alpha7.

I can reproduce it in the current master branch (https://github.com/godotengine/godot/commit/ccb583be091d3baf55365235cb35d4487ea3e911) and in v4.0-alpha7 on Windows 11

Thanks!

#60921


feat(cli) add --encoding option for open()

UnicodeDecodeError can be caused by windows console's the default charset -  my windows 7 korean console's charset is 'cp949(euc-kr)' and my python file is encoded in utf-8. so I've added encoding parameter (optional) to be passed to open() function.
UnicodeDecodeError: 'cp949' codec can't decode byte 0x9a in position 1782: illegal multibyte sequence

Can you fix the tests please? I will merge it after that


Long deletion GRCH37:chr4:113568635:ATCAAAAGTAAAGAAAATTAT:A in JSONL that is not accessible by REST endpoint

Describe the bug
The variant GRCh37:chr4:113568635:ATCAAAAGTAAAGAAAATTAT:A is visible in the JSONL but not accessible through the annonars web service.
To Reproduce
Steps to reproduce the behavior:

Obtain recent copy of annonars clinvar rocksdb database
Run query to annos/variant?genome_release=grch37&chromosome=4&pos=113568635&reference=ATCAAAAGTAAAGAAAATTAT&alternative=A
See no entry in "clinvar" key.

Expected behavior
We should have the clinvar variant information in there.
Additional context

https://github.com/bihealth/reev/issues/124

It turns out that the coordinate above is shifted and actually 113568636. So there is no such error after all.


Creating 4-3 Stacks in MLB with Fanduel

Can anyone chime in on what im doing incorrectly?
Heres the error:
SolverInfeasibleSolutionException         Traceback (most recent call last)
~\anaconda3\lib\site-packages\pydfs_lineup_optimizer\lineup_optimizer.py in optimize(self, n, max_exposure, randomness, with_injured, exposure_strategy)
383             try:
--> 384                 solved_variables = solver.solve()
385                 lineup_players = []
~\anaconda3\lib\site-packages\pydfs_lineup_optimizer\solvers\pulp_solver.py in solve(self)
55             invalid_constraints = [name for name, constraint in self.prob.constraints.items() if not constraint.valid()]
---> 56             raise SolverInfeasibleSolutionException(invalid_constraints)
SolverInfeasibleSolutionException: ['_C393', '_C507', '_C511', 'min_teams', 'total_players', 'budget']
During handling of the above exception, another exception occurred:
GenerateLineupException                   Traceback (most recent call last)
 in
32 lineups = optimizer.optimize(n=10, max_exposure=.4)
33 optimizer.set_min_salary_cap(34700)
---> 34 for lineup in lineups:
35     print(lineup)
36 optimizer.export(r"C:\Users\brand\Desktop\MLB\FD.csv")
~\anaconda3\lib\site-packages\pydfs_lineup_optimizer\lineup_optimizer.py in optimize(self, n, max_exposure, randomness, with_injured, exposure_strategy)
399                     constraint.post_optimize(variables_names)
400             except SolverInfeasibleSolutionException as solver_exception:
--> 401                 raise GenerateLineupException(solver_exception.get_user_defined_constraints())
402         self.last_context = context
403
GenerateLineupException: Can't generate lineups. Following constraints are not valid: min_teams,total_players,budget
heres the code creating it:
from pydfs_lineup_optimizer import get_optimizer, Site, Sport, CSVLineupExporter
from pydfs_lineup_optimizer.stacks import TeamStack, PositionsStack, PlayersGroup
from pydfs_lineup_optimizer import AfterEachExposureStrategy
optimizer = get_optimizer(Site.FANDUEL, Sport.BASEBALL)
optimizer.load_players_from_csv(r"C:\Users\brand\Downloads\FanDuel-MLB-2021 ET-04 ET-01 ET-56054-players-list.csv")
optimizer.restrict_positions_for_opposing_team(['P'], ['C', 'SS', 'OF', '1B', '2B', '3B'])
optimizer.add_stack(TeamStack(4, for_teams=['DET', 'PHI', 'NYY', 'CHC']))  # stack 4 players from any of specified teams
optimizer.add_stack(TeamStack(3, spacing=2))  # stack 3 players close to each other in range of 2 spots.**
devers_jd_xander = PlayersGroup([optimizer.get_player_by_name(Nickname) for Nickname in ('Rafael Devers', 'J.D. Martinez', 'Xander Boegarts')], max_exposure=0.5)
optimizer.add_players_group(devers_jd_xander)
bieber = optimizer.get_player_by_name("Shane Bieber")
optimizer.add_player_to_lineup(bieber)
bieber.max_exposure = .5
#cole = optimizer.get_player_by_name("Gerrit Cole")
#optimizer.add_player_to_lineup(cole)
#cole.max_exposure = .1
#darvish = optimizer.get_player_by_name("Yu Darvish")
#optimizer.add_player_to_lineup(darvish)
#darvish.max_exposure = .2
#giolito = optimizer.get_player_by_name("Lucas Giolito")
#optimizer.add_player_to_lineup(giolito)
#giolito.max_exposure = .1
#scherzer = optimizer.get_player_by_name("Max Scherzer")
#optimizer.add_player_to_lineup(scherzer)
#scherzer.max_exposure = .1
lineups = optimizer.optimize(n=10, max_exposure=.4)
optimizer.set_min_salary_cap(34700)
for lineup in lineups:
print(lineup)
optimizer.export(r"C:\Users\brand\Desktop\MLB\FD.csv")
import pandas as pd
df= pd.read_csv(r"C:\Users\brand\Desktop\MLB\FD.csv")
Changing my stack to a 3-3 works, or a 4-2 works, but not 4-3, which still meets the roster requirement of 4 different teams if my Pitcher is a diff player.  Wanting 4 man, 3 man, 1 off, and my P type lineups.
also a secondary Q.  I had to comment my pitchers out as it didnt like have all the exposures like that.  Is there a way to do that?

I'm having the same issues as you.  I have seen that setting multiple max or min exposure to over 5-6 players that compete for the same position usually gives a Unable To Solve error.  I run into this setting lineups and doing the same wheel of exposures over defense often where I really don't have a favorite.  I tried TotalExposureStrategy, AfterExposureStrategy.  I went through the code line by line trying to see where setting too many min or max might toss the error.  I just can't figure it out.  Just seems to be no way to do more or five min or max for any single player.  I find min.exposure to be more picky than max where I often can get only 3-4 and never try to total them up to 100% as you did above.  I get the best luck when I have 20% or so leftover.
As far as the stacks, I also had the exact error today on FanDuel stacking.  Seems like anything that effects 7 players is a fail.  It's solvable and I can come up with my own lineups that meet all requirements, but getting the error as you.
Such as huge part of baseball so I haven't given up searching for a fix.  Hoping its all related to some constraint that we can modify.  I'll continue to update if I find anything, but if anyone else out there can pinpoint what causes this to fail, it would be greatly appreciated!

We just got an update that fixed a position bug with FanDuel.  Since that update my 4-3 stacks and any other stacks I attempt work fine.  I am certain that position bug is what affected the stack bug for FanDuel baseball.  I think you should update PYDFS and try again and I bet you you'll see it work.

will try today my man. Thanks @bigboyz

I  also can confirm that the update fixed these errors.

Can i pick one of your brains @Owen-Slater @bigboyz ..  I dont know how to message you guys on here, but ive re ran it and it seems the stacks to be working as you guys said, but if i wanted to say run gerrit cole out tonight in 30 pct of my lineups, how would i go about doing that?

Thanks guys.  Still having issues setting exposure to more than 1 Pitcher on a slate,
LineupOptimizerException: You're already select all P's
what are your thoughts on this?

Personally, what I do is use the min and max exposure ability on the CSV file.  Then just put .30 Cole or whatever.  Sounds like the error is FanDuel and you locked a pitcher, but than tried to add another even though 1 is limit.

@bigboyz how do i message you on here.  Id like to learn more if you got time?
feel free to email me<EMAIL_ADDRESS>

LineupOptimizerException: Unable to build lineup.  was working for a tad.

@lightninglarry  Hi ,so I partially retract my statement regarding the original issue. It is fixed with the update, but it looks like when you create no Pitcher vs Batters optimizer.restrict_positions_for_opposing_team(['P'], ['C', 'SS', 'OF', '1B', '2B', '3B']) there may sometimes be an issue. I'm not 100% sure though.  Try removing this constraint if you have it and let me know if it works.

LineupOptimizerException: Unable to build lineup. was working for a tad.

Can also confirm the issue seemed to be fixed for a day or two. Then I think a second update was made and the issue seems to be back. I have a very large pool of players and right now only 23 lineups are being generated before it throws the "unable to build lineup" error.

still issue comes up.  I was able to create 7 lineups before unable to build lineup occurred.

How do you run optimizer? What stacks do you use? I tried to generate 150 lineups with 4-3 team stacks for today's contest and it didn't throw me error

@DimaKudosh, ive tried just to leave it empty and let projections dictate my stacks.
Tried tonight and it spit out 11 until it faulted out.
from pydfs_lineup_optimizer import get_optimizer, Site, Sport, CSVLineupExporter
from pydfs_lineup_optimizer.stacks import TeamStack, PositionsStack, PlayersGroup
from pydfs_lineup_optimizer import AfterEachExposureStrategy
optimizer = get_optimizer(Site.FANDUEL, Sport.BASEBALL)
optimizer.load_players_from_csv(r"C:\Users\brand\Downloads\FanDuel-MLB-2021 ET-04 ET-19 ET-57413-players-list.csv")
optimizer.restrict_positions_for_opposing_team(['P'], ['C', 'SS', 'OF', '1B', '2B', '3B'])
optimizer.add_stack(TeamStack(4, spacing=1, max_exposure=0.3))
optimizer.add_stack(TeamStack(3, spacing=1, max_exposure=0.3))
lineups = optimizer.optimize(n=150, max_exposure=.5, exposure_strategy = AfterEachExposureStrategy)
optimizer.set_min_salary_cap(34200)
optimizer.set_max_repeating_players(7)
for lineup in lineups:
print(lineup)

I noticed you are using spacing=1.  I have 57413 as I played that slate today, but can you post the exact file you used?  I want to compare it to mine.  I noticed when I download a file early the Batting Order is omitted from many teams.  If your copy did not have it for all teams it may very well be unsolvable with those constraints.

no, on that i waited till after lock to use the file just to test it out.  All lineups were in.

@lightninglarry @bigboyz  is it possible that the dual positions on FD are creating this issue? I haven't investigated it in the script yet, but I noticed I do miss some stacks that should be generated.
So for instance if you have a 4 stack,  spacing =1 for ['C', '2B', 'OF', '1B', '3B', 'SS'] ..... and the only way you can achieve a spacing of 1 is by using a player designated as 3B/1B or  2B/SS ... then this will throw an error (?) or stop the optimization? ... Not sure here, just throwing out a suggestion.

@lightninglarry @bigboyz is it possible that the dual positions on FD are creating this issue? I haven't investigated it in the script yet, but I noticed I do miss some stacks that should be generated.
So for instance if you have a 4 stack, spacing =1 for ['C', '2B', 'OF', '1B', '3B', 'SS'] ..... and the only way you can achieve a spacing of 1 is by using a player designated as 3B/1B or 2B/SS ... then this will throw an error (?) or stop the optimization? ... Not sure here, just throwing out a suggestion.
I know that this issue was fixed in an update, but maybe the spacing needs to be addressed. Again, I haven't gone through the script yet to verify this.

So if i leave spacing out, your thinking it works @Owen-Slater ?  If so thats cool, but still spacing would need to be addressed I think.

I took the spacing code part out, only created 1 lineup before it crashed tonight using the above code

I think ive got it working, thanks for all the help.
One more question though.  Wanting to add randomness say by like 10 pct, or 25 pct to my projections.
1- is this syntax correct, and 2- how do u incorporate randomness as a percentage?
optimizer.add_stack(TeamStack(4, for_teams=['DET', 'PHI', 'NYY', 'CHC'] spacing=1, max_exposure=0.3)) # stack 4 players from any of specified teams
optimizer.add_stack(TeamStack(4, for_teams=[‘ARI', 'STL', 'NYM', 'BOS'] spacing=1, max_exposure=0.6)) # stack 4 players from any of specified teams
optimizer.add_stack(TeamStack(4, for_teams=['ATL', 'SF', 'LAD', 'BAL'] spacing=1, max_exposure=0.8)) # stack 4 players from any of specified teams
Also for anyone who uses Fanduel, if the team lineup hasnt been out yet, and you want them in your stack, do you put a # for batting order for player?  or if u leave it blank does it still spit it out at you anyways if there is a projection? @bigboyz


fix: Fix misc spelling and grammar issues

The main aim of this PR is to clean up any spelling and grammar issues in the spec. I also reworded some sentences for added clarity and modified section headers so they'd be consistent. Technical writing is not my strong suit, so I'm sure there's even better ways to phrase some things, but I hope this at least marginally improves clarity and readability.
I added comments for any larger changes -- some of these could be extracted into separate PRs if that'd be more appropriate.

Sorry for the late review. This is amazing. I really would like to leave any comment or disagree but changes are really resolving major grammar flaws and ambiguities. Amazing work!
Thank you so much for this amazing contribution!


Optimize Travis build matrix

When #14 is merged, we will have three builds per push/PR, for the node versions 4, 5, and the latest. But all of them run the karma browser tests, which is nonesense. Ideally, we would have those three builds running the tests only for node (using mocha) and either

one additional build that tests all browsers (using karma), or
multiple additional builds that each run tests for exactly one browser

Literature: https://docs.travis-ci.com/user/customizing-the-build/#Build-Matrix


How to add Domain Hint in custom policies?

Is there any way to add domain hint in custom policies? I was able to add Domain hint in built-in user flows by following this article https://docs.microsoft.com/en-us/azure/active-directory-b2c/tutorial-add-identity-providers . How to do the same using custom policies?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2b8cd351-ffd7-d9f4-2894-b31bd903915d
Version Independent ID: 72118a2f-53cf-aaed-c655-b98f114eb0d5
Content: Tutorial: Add identity providers to your apps - Azure AD B2C
Content Source: articles/active-directory-b2c/tutorial-add-identity-providers.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@yashwanth-yenugu Thank you for reaching out.
We are actively investigating and will get back to you soon.

Please check Set up direct sign-in using Azure Active Directory B2C article.
Hope that clarifies your question. Should you have any questions, please don’t hesitate to contact us.


support coexistence of SaaS and all namespace mode

@horis233 @ZhuoxiLi
It is ready for merging, please review it when you are available~


Clean up toService cases

Since it's already possible to compose Router with RequestReader (see #334 ) as well as with functions A => B and A => Future[B], we don't need the following cases:

Future[A: EncodeResponse]
Future[Response]
Future[RequestReader]

As part of this issue, we can also cleanup the code arrond ToService type-class, since it might be removed in 0.9.

This has been fixed in https://github.com/finagle/finch/commit/2580194663974ec92eb1453c9e7085cdfaed6fcb.


Unable to build library with AngularCompilerPlugin, no declarations created in the output

🐞 Bug report
Command (mark with an x)

[ ] new
[x] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?

 Yes, the previous version in which this bug was not present was: ....
I haven't tried it before
Description
 A clear and concise description of the problem...
Since this is still not working: https://github.com/angular/angular/issues/34027
I'm trying to build an Angular Library with our current Webpack setup.
When using AngularCompilerPlugin with Webpack declaration files are not generated.
So I'm unable to import the built library.
From webpack.config
new AngularCompilerPlugin({
    tsConfigPath: helpers.rootPath('tsconfig.build.json'),
    mainPath: helpers.rootPath('src/index.ts')
}),

From tsconfig.build.json
{
  "extends": "../../tsconfig.json",
  "compilerOptions": {
    "strictNullChecks": true,
    "noImplicitReturns": true,
    "rootDir": "./src",
    "declaration": true,
    "declarationMap": true,
    "declarationDir": "./dist",
    "outDir": "./dist"
  },
  "files": [
    "./src/index.ts"
  ]
}

From tsconfig.json
{
  "compilerOptions": {
    "rootDir": ".",
    "baseUrl": ".",
    "target": "es5",
    "module": "commonjs",
    "moduleResolution": "node",
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "removeComments": false,
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "noEmitHelpers": true,
    "noEmitOnError": false,
    "importHelpers": true,
    "noImplicitAny": false,
    "strictNullChecks": false,
    "strictPropertyInitialization": false,
    "pretty": true,
    "sourceMap": true,
    "declaration": false,
    "preserveConstEnums": true,
    "downlevelIteration": true,
    "lib": [
        "dom",
        "es2015",
        "es2017.object",
        "es2017.string"
    ],
    "typeRoots": [
        "./typings/",
        "./node_modules/@types"
    ],
    "paths": {
      "@oas/web-lib-core": ["./packages/web-lib-core/dist"],
      "@oas/web-lib-common": ["./packages/web-lib-common/dist"],
      "@oas/web-lib-angular-js": ["./packages/web-lib-angular-js/dist"],
      "@oas/web-lib-angular": ["./packages/web-lib-angular/src"],
      "@oas/web-lib-angular-2": ["./packages/web-lib-angular-2/dist"],
      "@oas/internal-lib-e2e": ["./packages/internal-lib-e2e/dist"],
      "rxjs/*": ["./node_modules/rxjs/*"],
      "zone.js/*": ["./node_modules/zone.js/*"],
      "@angular/*": ["node_modules/@angular/*"]
    }
  },
  "compileOnSave": false,
  "buildOnSave": false
}

🔬 Minimal Reproduction

https://github.com/JonWallsten/monorepo-new (might contain sensitive data from our organisation, so please ask to be a collaborator)
Follow the instructions in the monorepo root ReadMe and check dist folder for packages/web-lib-angular-2
🌍 Your Environment

Angular CLI: 9.0.0-rc.7
Node: 12.14.0
OS: win32 x64

Angular: 9.0.0-rc.7
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.900.0-rc.7
@angular-devkit/build-optimizer   0.900.0-rc.7
@angular-devkit/core              9.0.0-rc.7 (cli-only)
@angular-devkit/schematics        9.0.0-rc.7 (cli-only)
@angular/cdk                      9.0.0-rc.6
@angular/http                     8.0.0-beta.10
@angular/material                 9.0.0-rc.6
@ngtools/webpack                  9.0.0-rc.7
@schematics/angular               9.0.0-rc.7 (cli-only)
@schematics/update                0.900.0-rc.7 (cli-only)
rxjs                              6.5.3
typescript                        3.6.4
webpack                           4.41.4

Oh, you're supposed to use ng-packagr for creating Angular Libraries?

AngularCompilerPlugin is meant to be used to bundle application which don’t need typescript deceleration files.
For libraries, you need to use ng-packagr or if you use the CLI you can you the @angular-devkit/build-ng-packagr.
To generate a new library within the cli use:
`ng g lib .
More info can be found: https://angular.io/guide/libraries


Permission denied applying the them on MacOS 10.14.5

? Please select an command Apply theme
Adding One Dark Theme Code to Slack...
(node:10482) UnhandledPromiseRejectionWarning: Error: EACCES: permission denied, copyfile '/Applications/Slack.app/Contents/Resources/app.asar' -> '/Applications/Slack.app/Contents/Resources/app.asar.backup'
at Object.copyFileSync (fs.js:1731:3)
at Object.exports.apply (/Users/hans/Projects/slack-one-dark-theme/lib/command.js:39:6)
at exports.execute (/Users/hans/Projects/slack-one-dark-theme/lib/command.js:67:12)
at main (/Users/hans/Projects/slack-one-dark-theme/main.js:19:3)
at processTicksAndRejections (internal/process/task_queues.js:85:5)
(node:10482) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:10482) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

You need to run the script with sudo

I don't often run a script dowloaded from the Internet as sudo. Will it have a side effect, just for sure?

Does not look very good to me with Slack version 4.0.0 :(


Move dependencies to peer dependencies

✏ Description

Using the UI components (example: Inbox) breaks because react navigation and safe area context are dependencies in the SDK, so they get installed in the package's own node_modules (node_modules/@iterable/react-native-sdk/node_modules).  The makes the components look for navigation context and safe area context from an instance in its own node_modules, instead of the consumer's project.

Removed react-hooks package (unused in SDK)
Moved lint packages from dependencies to devDependencies
Moved packages from dependencies to peerDependencies, using major versions as minimum

Approved.  Looks good to me.

This also address #596

@lposen @johnhaup exciting change. I'd love to incorporate this into my project because I'm looking to upgrade react-native-safe-area-context from v4 to v5 and this change will allow me to avoid having two versions installed or needing to add a manual resolution to the version of my choosing.
Can you let me know if this will be available in a new release soon (ie this week) or not?


Error with VimDebuggerLoad and snipmate

Launching MacVim through the terminal (mvim) shows these error messages.
I'm not sure how to fix them.
Error detected while processing function <SNR>15_VimDebuggerLoad:
line    2:
E117: Unknown function: <SNR>15_VimDebuggerInit
Error detected while processing function DefPython:
line  550:
Traceback (most recent call last):
  File "<string>", line 547, in <module>
  File "<string>", line 397, in __init__
NameError: global name 'VimDebugger' is not defined
Error detected while processing /Users/jtsandlund/dev/spf13-vim/.vim/bundle/snipmate/plugin/snipMate.vim:
line   31:
E117: Unknown function: funcref#Function
E116: Invalid arguments for function get(s:snipMate, 'get_snippets', funcref#Function("snipMate#GetSnippets"))
E15: Invalid expression: get(s:snipMate, 'get_snippets', funcref#Function("snipMate#GetSnippets"))

fjk's fix worked for me as well

thaks @pythonsnake it works for me! :)

@danybmx
Cool.
You should thank fjk, the solution is from him. I just explained it :-)

Hi guys,
I am using the latest version of spf13-vim and I still have the error:
Error detected while processing function 13_VimDebuggerLoad:
line    2:
E117: Unknown function: 13_VimDebuggerInit
Error detected while processing function DefPython:
line  550:
Traceback (most recent call last):
File "", line 547, in
File "", line 397, in init
NameError: global name 'VimDebugger' is not defined
Anyone can help?

Open file ~/.vim/bundle/VimDebugger/plugin/VimDebugger.vim
Just move line 41 "call s:VimDebuggerLoad()" to line 77, between "endfunction" and "function! g:__dbg_WatchFoldText()"
Above fix worked for me.
Thanks.

Great. Will upgrade to vim 3.0
Thanks.


Getting an AttributeError in Python 2.6 with sys.version_info.major

In Python 2.6 sys.version_info doesn't have a major attribute.
Here is the stack trace and output:
>>> import html2markdown
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/data/rally_jira_sync/venv/lib/python2.6/site-packages/html2markdown.py", line 10, in <module>
    if sys.version_info.major > 2:
AttributeError: 'tuple' object has no attribute 'major'
>>> import sys
>>> sys.version_info
(2, 6, 6, 'final', 0)
>>> sys.version_info.major
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'tuple' object has no attribute 'major'
>>> dir(sys.version_info)
['__add__', '__class__', '__contains__', '__delattr__', '__doc__', '__eq__', '__format__', '__ge__', '__getattribute__', '__getitem__', '__getnewargs__', '__getslice__', '__gt__', '__hash__', '__init__', '__iter__', '__le__', '__len__', '__lt__', '__mul__', '__ne__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__rmul__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', 'count', 'index']

The line in question could be changed from:
if sys.version_info.major > 2:

To:
if sys.version_info[0] > 2:

To support Python 2.6.
Not sure how supported this library is, but just submitting the issue to see if I get a reply.
Thanks

Thanks. I added the change you suggested.
https://github.com/dlon/html2markdown/commit/24444fd1e6f360bdb0175e6bfb280607e43fe668

Great. Thank you.


Problems with LSP mode

Following #46 , I created this issue to list the problems currently in the LSP mode (at least compare with the Prometheus mode).
Good: Prometheus

Current bugs in LSP mode:

[ ] Matched text is not highlight
[ ] Function's score is lower than metrics (actually I think the problem here is fuzzy score is not used?)
[ ] No snippet

Function's score is lower than metrics (actually I think the problem here is fuzzy score is not used?

It's on promql-langserver side. So filtering and scoring are not coming from cmn since it's on the server side to provide these features. @slrtbtfs can talk a bit more about it I believe :)

In the PR https://github.com/prometheus-community/codemirror-promql/pull/8 that implements the autocompletion using LSP, there is a bunch of suggestions to improve it. Snippet was mentionned at this time.
There is certainly some code to do here, but also on promql-langserver side.
Hope it helps to clarify a bit the history of this mode / the situation

The sorting order in the LSP mode is provided by the language server, in a way that functions appear first.
Maybe the code in this repo reverses that order, this would explain why the function appears last.

Doesn't seem like this library uses the score returned by the language server: https://github.com/prometheus-community/codemirror-promql/blob/9e43058bd1341e8b52b0d8dcf1698a59e693b891/src/lang-promql/complete/lsp.ts#L74

moving to cmn v12 should have fixed the first 2 points

Yes I confirm the first 2 are fixed :D

on this particular point, snippet should be implemented on server side. Nothing to do here ;).

I think we can close this issue then :+1:


Stable driver analysis tracking issue

Of the four drivers we're choosing to stabilize initially, we need to analyse them and determine a number of things.

Does the driver meet all expectations in the API-GUIDELINES document?

This is not just limited to the driver itself, but any substructs, configs, helpers - everything

Does the driver encapsulate the hardware it's designed to drive?

Does it offer an API that utilizes all hardware features?
If it doesn't, will the current API prevent us from adding that additional support in the future?

We should analyse the TRMs and find extra modes / alternate operation features
This is really important to think about, once we commit it will be a long time before we can change anything.
We don't need to support everything in 1.0, but we must design a driver that it extensible beyond 1.0 (without breaking changes)

Can the driver as a whole be stabilized?

Perhaps some parts/modes are not a polished and stable as other parts of the driver
Could we partially stabilize some of this
We should be conservative at first, and we can relax some unstable flags as the beta phase progresses before 1.0

Please note that this is analysis work that needs to be done, here we will analyse what's wrong. Once the analysis is complete, we can do the following:

Depending on the result of some parts, fix the code (light refactors, like naming etc)
Mark part of the driver as unstable

Remember this is not 1.0 yet, we can relax some of these prior to 1.0

#2492
#2495
#2493
#2494

Will this include trait implementations?
For example, Spi implements e-hal 0.2 traits. Will these impls be considered stable too?
e-hal aside what about other trait libraries that are not themselves stable?

We should probably do a review of the common bits as well. For example Peripheral/PeripheralRef are in violation of C-SMART-PTR - if they count as smart pointers.

Types should be UpperCamelCase, but peripheral instances are UPPERCASE (SCREAMING_SNAKE_CASE?). We should probably mention these as exceptions.


[sysrst_ctrl] Adding dedicated WP_L function

This is something that is missing from the current design.
Two functions from sysrst_ctrl need to be dedicated and active immediately when the device is powered up.
These are EC_RST_L and FLASH_WP_L.  EC_RST_L is already implemented, however FLASH_WP_L is missing.
FLASH_WP_L behavior is as follows:

at power up, drive 0 onto the dedicated pin
afterwards, keep driving 0 until configured by software to do otherwise.

Basically, FLASH_WP_L behaves "almost" like a GPIO but must be actively driven immediately after power-up.

LGTM. This should be the correct behavior.

@cindychip @sriyerg @weicaiyang @matutem FYI

Ack. Will update the chip testplan accordingly.

See PR #7800 - let me know if anything needs to change.

This has been implemented as part of #7829.


One MAS task assigned but two MAS tasks requested in the time slot for<PHONE_NUMBER>00

For :
t<PHONE_NUMBER>00 Acolyte  MAS MAS Reader1 Reader2 EMHC
I have requested two MAS tasks but only one has been assigned - see the image and the result file.
a2t_result.txt

You have three agents that can do 'MAS'
Two of them are assigned to 'MAS' in timeslot<PHONE_NUMBER>30 so they are unavailable for timeslot<PHONE_NUMBER>00 leaving just one.

Sorry. You are right.


add nix support and installation instructions for nix

Not sure why this took me so long to get to 😅
I'll see what I can do, I've been meaning to package my first app for nixpkgs for a while now!

Not sure why this took me so long to get to sweat_smile I'll see what I can do, I've been meaning to package my first app for nixpkgs for a while now!

https://github.com/NixOS/nixpkgs/pull/180959
Fingers crossed :)

NixOS/nixpkgs#180959
Fingers crossed :)

Thanks a lot! Also how to update the flake ?

Every time the flake is built/installed, it'll fetch from the latest version in the git repository. You can update the versions of the dependencies the flake pulls by running nix flake update, which also updates the lockfile so anyone building from the flake will always pull the same versions of said dependencies