Scroll to hash anchor

What is the preferred way to implement a hash/anchor-link scrolling behavior as in https://github.com/rackt/react-router/issues/2144#issuecomment-153899046 ? So far I found 2 solutions:

continue using history.listen (although using setTimeout in order to wait for the router behavior to evaluate seems pretty unreliable)
create a useHashScroll decorator function using the /utils of this repo

It should be part of the "standard" scroll behavior here IMO.

Known missing feature.

@ihinsdale @taion
Why this commit is not already merge? Cause scrollIntoView browser compatibility?

What commit are you talking about?

@ihinsdale commit: https://github.com/ihinsdale/scroll-behavior/commit/0f54595b3e66d270d077c2cf6b3fb95688679e5f
sorry!  I don´t see is 21 hours old :-)
could be valid for anchor hash scrolling?

Created a PR based on solution 1 to keep the discussion going. #47

I got this working by using the following shouldUpdateScroll, along with Velocity for smooth scrolling:
import Velocity from 'velocity-animate';

const SCROLL_TRANSITION = {
  duration: 500,
  easing: 'ease-in-out'
};

const scrollToTop = () => {
  if (window.scrollY === 0) return false;
  Velocity.animate(document.body, 'scroll', SCROLL_TRANSITION);
  return false;
};

const scrollToEl = (el) => {
  Velocity.animate(el, 'scroll', SCROLL_TRANSITION);
  return false;
};

export default (oldLocation, newLocation) => {
  if (oldLocation &&
    (oldLocation.pathname + oldLocation.hash === newLocation.pathname + newLocation.hash)
  ) {
    return scrollToTop();
  }
  if (newLocation.hash) {
    const targetEl = document.querySelector(newLocation.hash);
    if (!targetEl) return false;
    return scrollToEl(targetEl);
  }
  return scrollToTop();
};

That works. I don't plan on integrating with Velocity here, but I do want to handle the "base" case of scrolling to hash anchors.

Thought so, but it's easy enough to remove right?

Hopefully.

Just noticed this fails when you switch to another route with a hash. The targetEl isn't available yet, so it bails with return false;. I added a retry function for my own code, but do you think there's a more elegant solution maybe?
Retry:
const retry = (hash) => setTimeout(
  () => {
    const targetEl = document.querySelector(hash);
    return targetEl ? scrollToEl(targetEl) : null;
  },
  200
);

I'm not sure. With the router, it's supposed to be the case that those changes have already been flushed to the DOM. Try forcing a reflow, maybe? Otherwise I can't think of anything better than what you have.

You mean on the element or on some container?

Before trying to grab the element.

No dice. I'll stick to the retry approach for now. Cheers!

I think requestAnimationFrame is more appropriate then a timeout of 200ms. In my app the target element seems to be found on the next frame, but I kept a retry just in case.

function shouldUpdateScroll (oldLocation, newLocation) {
  if (newLocation.hash && newLocation.action !== 'POP') {
    window.requestAnimationFrame(() => scrollToHash(newLocation.hash))
    return false
  } else {
    return pageChanged(oldLocation, newLocation)
  }
}

function scrollToHash(hash) {
  const el = document.querySelector(hash)
  if (!el) {
    retry(() => scrollToHash(hash))
  } else {
    const { top } = el.getBoundingClientRect()
    window.scrollTo(0, window.pageYOffset + top)
  }
}

const retry = (fn) => window.requestAnimationFrame(fn)

function pageChanged(oldLocation, newLocation) {
  return (oldLocation && oldLocation.pathname) !== newLocation.pathname
}

I think an issue I posted to React is relevant here. https://github.com/facebook/react/issues/7889

@kjs3 thanks for linking to the React issue :+1:. That is a good thing to be aware of.
@0x80 you are completely correct!  I have switched to using https://github.com/taion/react-router-scroll and this is my middleware:
const scrollRouterMiddleware = useScroll((prevRouterProps, {routes, location}) => {
    if (some(routes, 'ignoreScrollBehavior')) {
        return false
    }

    if (some(routes, 'scrollToTop')) {
        return [0, 0]
    }

    if (conformsTo(location, {hash: negate(isEmpty), action: (a) => a !== 'POP'})) {
        invoke(window, 'requestAnimationFrame', () => {
            const node = document.getElementById(location.hash.substr(1))
            if (node) {
                node.scrollIntoView()
            }
        })
    }

    return true
})

(N.B. some, invoke, conformsTo, negate are lodash functions)

@aij @taion Thanks for this!


[REVAMP]: LIST ITEMS DESIGN ON HOMEPAGE 🪄

Description

I would like to revamp the design of list items present on the Homepage of new Grabtern UI.
The current design not looks good in terms of UI, i can revamp the design.
I already made a sample revamp changes on browser itself to share the screenshots to you for your comparison.
Make sure to properly review the below table, if this needs to be done then you can assign me to complete this work.

Screenshots

CURRENT STATE
DESIRED STATE

MOBILE
DESKTOP

MOBILE
DESKTOP

Hey there @anmode 👋🏻
Please make sure to assign this issue to me asap to make the work done!
Thank you.

yeah, some places it needs... ok go for it


rotation not working

When rotating the map The button position will be moving.

The rotation support was just recently added to flutter_map. It rotates all layers and as far as I know, there is no support yet to avoid that. I guess there is further work required in flutter_map to add better support for that. That nothing we can fix in the plugin itself. That's why rotation is disabled in the examples:
https://github.com/Xennis/flutter_map_location/blob/e9afc03d3351da87ffc01d6e27922b9d1e62fbed/example/lib/pages/default.dart#L34

@zozeei flutter_map adding now support to not rotate certain layers. I've added basic support for it in #43 . PS: That will end up on the dev branch because flutter_map did not released a new version yet.


iowndoiwanidownad

sdfghjukilo;p'[

Please describe the issue, attach the logs, show crash reporter etc anything helpful


Torque Heat - Change Threshold menu name to Opacity

Ha, actually the CSS property it changes is marker-fill-opacity, but we thought that threshold would sound a bit more photoshop-ish and a bit more centric to heatmaps. @saleiva what do you think?

Uhm... good question. Don't mind switching to Opacity in reality,...

Cool, let's do that.

Changed as of #2248.


Make SqlAlchemy pool_recycle and pool_size configurable

The databases in our environment have short timeouts. I need to be able to configure sql_alchemy_pool_recycle from the configuration file.

:+1:


Which network I should connect to for tests?

It mentions, Hardhat does not support EIP-3074 at the moment. All testing is done on a live network.
Does any live network support invokers (AUTH and AUTHCALL)
I remember trying out puxi testnet many months ago. Do I need a specific setup?

same question as ⬆

I am not currently aware of a public testnet with 3074 activated, though there is hope that there might some in the future...
In order to get a local network running, you'll need a modified version of the EVM. EthereumJS has an implementation accessible behind a flag (link), alternatively you might be able to use Quilt's Geth fork (link). If you're looking to go the serious route, Ansgar has a workshop on how to implement the EVM changes here.
Hardhat does not yet implement an easier way to do this, though it is on their roadmap. Foundry is unlikely to have support soon, as their EVM implementation as already expressed that they have no plans to add 3074 support unless there is more serious interest shown about it in the Ethereum community. (link
I hope that helps - lmk if there's something I can add

This is a quick hack that should get EIP-3074 activated in Hardhat. I'm not sure how to test it, so let me know if doesn't work.
Add this to your Hardhat config.
const { Common } = require("@nomicfoundation/ethereumjs-common");
const originalCustom = Common.custom;
Common.custom = (params, opts) => {
  return originalCustom.call(Common, params, {
    ...opts,
    eips: [...(opts.eips ?? []), 3074],
  });
};

thanks @alcuadrado ! We'll try this out on our end too, if it works, we'll merge it in.

Forgot to mention this here, but we will move away from ethereumjs vm soon. We'll be using REVM, which is the same vm that foundry uses, so this hack will stop working in ~1-2 months.

Initial tests with @alcuadrado work on our end - note that if you're using the tests in the repo that they assume a private key in a .env, and you'll need to fund the account with test ETH if you want to use it.

Okay, it looks like the snippet works (the opcode doesn't revert as unrecognized), but auth is giving us out-of-gas errors even from funded accounts. We're looking into it.

just wanted to mention that we have not forgotten about this, this issue has spawned a rather ridiculous rabbit hole of exploration and debugging, but it looks like we're getting closer to the source
s/o to the Hardhat, EthereumJS, and Quilt teams for their support


Feature requests (Playlists, Mass export, etc)

Playlists: Allow a user to select .nbs files, and the program will play those in order or shuffle.
Mass export: Export many .nbs files in a playlist to .mp3, .midi (from previos request), or any other common formats.
Mass import: Import many .midi files.
Song tabs: A tab system to easily switch between songs.
Dark theme: We need this <----
These are just a bunch of suggestions I thought of.

The program is designed with 1 open song in mind, so many of these features require rewriting of the original application. Which I'm not going to do.
Dark theme seems doable though :)

I understand that many of those would take a lot of rewriting and stuff.  The main ones I'm wanting are the midi export and dark mode. 👍

Then I'll consider this feature request as dark theme. Please open up a separate issue for each request from now on, as it's meant to work that way.

Ah alright, sorry. I'll do that next time.
On Tue, May 7, 2019 at 11:23 AM Hielke<EMAIL_ADDRESS>wrote:

Then I'll consider this feature request as dark theme. Please open up a
separate issue for each request from now on, as it's meant to work that way.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/HielkeMinecraft/OpenNoteBlockStudio/issues/21#issuecomment-490126756,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIIXU3CPVSTW3Z5SOHNDN7TPUGNF5ANCNFSM4HJRI3NQ
.


GH-2140 Unions can have specified new scope

GitHub issue resolved: #2140
Briefly describe the changes proposed in this PR:
Unions are introduced when parsing queries with alternate paths. These are again optimized by the QueryModelNormalizer with new Unions. None of these Unions need to introduce a new scope, as they were not introduced by the user.
Added an option for specifying scope to Unions.

PR Author Checklist:

[ ] my pull request is self-contained
[ ] I've added tests for the changes I made
[ ] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change
[ ] every commit has been signed off

Note: we merge all feature pull requests using squash and merge. See RDF4J git merge strategy for more details.

What do you think about this approach @jeenbroekstra ?

Can change it to use this instead: https://github.com/eclipse/rdf4j/blob/d2a301dabcf9c051b019e3434327c15c29fc321e/core/queryalgebra/model/src/main/java/org/eclipse/rdf4j/query/algebra/GraphPatternGroupable.java
Does isGraphPatternGroup:true mean that we variables enter a new scope?

I'd prefer to use existing information (such as GraphPatternGroupable) for this, rather than introduce a new flag.
Please note that I have a draft PR for this same issue up (see #2141) , which I intend to continue work on.

I've got an alternative approach for this pushed to #2141, I think we can close this.

Ok. I propose we wait until you've merged your branch, then we can delete this PR and branch.

I've got my PR merged now, so if you rebase you should be able to run this test after my changes.

Looks good!


feat(api): add support to pass custom request header

Add support to pass custom request header. Resolves #52, Resolves #44, Resolves #43
Add createEWalletPayment. Resolves #17

@kahirul Thank you so much for your contribution

@kevindavee Please help release as 1.7.0 after requested change has been made

I'm not familiar with release process. Do you have docs about this somewhere?

I know this is not a support page.
But just curious how long will it take for this changes to land in Xendit bintray repository?
@kevindavee

Hi @kahirul .
It's not that long. But I'm away from my computer right now. Do you mind to wait at worse 4.30 PM Jakarta Time? I'll get to my computer as soon as possible

@kevindavee awesome. That's fine for me. Thank you

@kahirul xendit-java version 1.7.0 has been published. Thanks for contributing to this library!


Fix a typo in libffi detection code

Hello,
There is a typo in the code that detects libffi. It causes the detection to fail when providing LIBFFI_{CFLAGS,LIBS}. Please see the attached fix.
Thanks!

Thanks!  This will be in the next point release.


CLOUDSTACK-8380: Adding automation test cases for VM/Volume snapshot testpath

CLOUDSTACK-8380: Adding automation test cases for VM/Volume snapshot testpath

@pritisarap12 looks good, but not a test guru to review/merge it

@gauravaradhye is it good to merge?

Hi Rohit,
I am yet to review updated pull request.
Regards,
Gaurav
On Thu, Mar 19, 2015 at 2:22 PM, Rohit Yadav<EMAIL_ADDRESS>wrote:

@gauravaradhye https://github.com/gauravaradhye is it good to merge?
—
Reply to this email directly or view it on GitHub
https://github.com/apache/cloudstack/pull/117#issuecomment-83426630.

Also please add the test case execution results.

Integrated review changes:
Testcase result:
Test Volume (root) Snapshot ... === TestName: test_01_volume_snapshot | Status : SUCCESS ===
ok

Ran 1 test in 3265.552s
OK

Will review remaining changes tomorrow. A quick question, running the test suite should not leave anything behind in the setup. Is this taken care of?

Done with rebasing the branch with upstream master.


Connections setup from clients that use the additional native_trasport_shard_aware_port - are not all to that port

Please answer these questions before submitting your issue. Thanks!
What version of Scylla or Cassandra are you using?

2021.1.5 (scylla-cloud)

What version of Gocql are you using?
1.5.0
What version of Go are you using?
1.16.9
What did you do?
update scylla-bench to use gocql 1.5.0
connected with scylla-bench to a cluster
./scylla-bench -workload sequential -mode write -nodes XXX  -username XXX -password XXX

accessed one of the servers
support@ip-172-31-0-108:~$ netstat  -an | grep 9042
tcp        0      0 <IP_ADDRESS>:19042           <IP_ADDRESS>:*               LISTEN
tcp        0      0 <IP_ADDRESS>:9042            <IP_ADDRESS>:*               LISTEN
tcp        0     15 ip1:19042      ip2:32810    ESTABLISHED
tcp        0     30 ip1:19042      ip2:32788    ESTABLISHED
tcp        0      0 ip1:19042      ip2:32821    ESTABLISHED
tcp        0      0 ip1:19042      ip2:32818    ESTABLISHED
tcp        0      0 ip1:19042      ip2:32820    ESTABLISHED
tcp        0     15 ip1:19042      ip2:32819    ESTABLISHED
tcp        0      0 ip1:9042       ip2:55714    ESTABLISHED
tcp        0     15 ip1:19042      ip2:32815    ESTABLISHED
tcp        0      0 ip1:19042      ip2:32823    ESTABLISHED
tcp        0      0 ip1:19042      ip2:32813    ESTABLISHED
tcp        0      0 ip1:9042       ip2:55712    ESTABLISHED
tcp        0     15 ip1:19042      ip2:32822    ESTABLISHED
tcp        0      0 ip1:19042      ip2:32811    ESTABLISHED
tcp        0      0 ip1:19042      ip2:32812    ESTABLISHED
tcp        0      0 ip1:19042      ip2:32814    ESTABLISHED

as can be seen there are:

13 connections to 19042
2 connections to 9042

I expected the control connection to be on 9042 and all the rest of the connections (actually sending traffic) to be on 19042
Maybe the first connection is not the control connection ?
I guess there is an explanation for this -  yet am not sure what it is.

Although it's an old issue, I'm familiar with the implementation and I can answer what is going on here.
This is intended behavior. gocql maintains separate connection pools for each node. A pool first tries to establish a single connection to the non-shard-aware port. During handshake, the pool learns about the shard-aware port, and from now on directs new connections to the shard-aware port. The pool doesn't attempt to close the first connection and re-open it to the shard-aware port as it isn't really necessary. Until the first connection will be reopened due to other reasons, it will stay connected to non-shard-aware port.
In addition to this, the driver maintains a single control connection which isn't a part of any pool. I don't think the driver bothers to use the shard-aware port for it at all.
Assuming N nodes and S shards, you should have N + 1 non-shard-aware connections and (S - 1) * N shard-aware connections. I suppose here N = 1 and S = 14, so there should be 2 non-shard-aware connections and 13 shard-aware ones.


Fix code in Google Cloud Storage Integration Wiki Page

I have copied the example code you have in the Google Cloud Storage Integration Wiki page, and it worked flawlessly when uploading single image. However, I had problems when using it with files with subversions (such as when generating thumbnails with the example in the Image Processing page) - specifically it was uploading the original file twice.
I think the issues lies in here:
onAfterUpload: function(fileRef) {
    // In the onAfterUpload callback, we will move the file to Google Cloud Storage
    var self = this;
    _.each(fileRef.versions, function(vRef, version){
      // We use Random.id() instead of real file's _id
      // to secure files from reverse engineering
      // As after viewing this code it will be easy
      // to get access to unlisted and protected files
      var filePath = "files/" + (Random.id()) + "-" + version + "." + fileRef.extension;
      // Here we set the neccesary options to upload the file, for more options, see
      // https://googlecloudplatform.github.io/gcloud-node/#/docs/v0.36.0/storage/bucket?method=upload
      var options = {
        destination: filePath,
        resumable: true
      };

      bucket.upload(fileRef.path, options, function(error, file){
...

it's using _.each to go through each version of the file, but when specifying the source file to upload it uses 'fileRef.path' which is the same for each version. To upload the correct file, it should be using vRef.path, which is the specific path for that version.
This is further confirmed by looking at the object structure of the fileRef object passed to the function:
{ size: 829970,
  type: 'image/png',
  name: 'Picture1.png',
  meta: {},
  ext: 'png',
  extension: 'png',
  extensionWithDot: '.png',
  mime: 'image/png',
  'mime-type': 'image/png',
  _id: 'vu6rreiCgvBChc5Gp',
  userId: 'f4v3Bo4qTsdYbwFAR',
  path: 'C:/Test\\vu6rreiCgvBChc5Gp.png',
  versions:
   { original:
      { path: 'C:/Test\\vu6rreiCgvBChc5Gp.png',
        size: 829970,
        type: 'image/png',
        extension: 'png' },
     thumbnail:
      { path: 'C:/Test/thumbnail-vu6rreiCgvBChc5Gp.png',
        size: 18945,
        type: 'image/png',
        extension: 'png',
        meta: [Object] } },
...

Does this make sense? It started working correctly for me after I made this fix, I think this is the expected behaviour. Happy to make a PR to the docs if you give me the green light.

@leoncvlt any news on your end, shall we wait for PR?

https://github.com/VeliovGroup/Meteor-Files/pull/698

Fixed by #699,
Feel free to reopen it in case if the issue is still persists on your end.


python3 compatibility

just to execute the snippet on python 3 without crashes :)

Traceback (most recent call last):
File "xmppgcm_test.py", line 17, in onSessionStart
xmpp.send_gcm('your_device_token', data, options, onAcknowledge)
File "/usr/local/lib/python3.5/site-packages/xmppgcm/gcm.py", line 142, in send_gcm
for key, value in options.iteritems():
AttributeError: 'dict' object has no attribute 'iteritems'

@romainhk apologies for late response. Is this still relevant?

If you plan to support python 3, yes :)

Can you fix the conflicts if possible? Also let me know if you would like a separate branch.


Set self.loader to first configured loader

Prior to this commit, the user is still prompted for .p12 information even if pem information is already in a user's .mypki file.

Good catch!

Thanks! Do you typically increment the version number or would you like me to, in a separate pull request?

I just upped the micro version number since this is a bug fix.  It's now available on PyPI as version 0.8.1: https://pypi.org/project/pypki2/#history

Thanks! I'll go update!
On Nov 15, 2017 3:20 AM, "Bill"<EMAIL_ADDRESS>wrote:

I just upped the micro version number since this is a bug fix. It's now
available on PyPI as version 0.8.1: https://pypi.org/project/
pypki2/#history
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nbgallery/pypki2/pull/14#issuecomment-344518546, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ALiGWpqQnOrB7Uujot2fJIXzaDZu-fIaks5s2p69gaJpZM4QTOs0
.


What differs uni-core from fairseq.

This is absolute a good framework. But it's very similar to fariseq. I am wondering if there are anything different from fairseq that makes uni-core standing out, easy-to-use? fast?
Best,
Zhangzhi

As written in the readme, this is derived from fairseq. But Uni-Core only keeps its framework, excluding its many sequence models and many dependencies. This change is to make Uni-Core a pure and clean framework for developing various models.
Besides, the efficiency is further improved.

Sounds good! fairseq is really too tedious to follow.


aes256

I have a question, can the minimum data buffer be at least 16 bytes?

A minimum data block is 16 bytes for EBC and 1 byte for CTR.


config.css is being loaded but not found

GET http://localhost:4500/config.css net::ERR_ABORTED 404 (Not Found)

Closed in cc15ad26eb977cd00ceddca9628ec2ac1975b31f


fix compound predicate need cast children to boolean (#27649)

pick from master
PR #27649
commit f0dbce4cf58ec829734175e05bf2188c7158078d
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


[Usage]: How to release GPU of vLLM model in python code

Your current environment
llm = LLM(model=model1_path, tensor_parallel_size=torch.cuda.device_count())
llm = LLM(model=model2_path, tensor_parallel_size=torch.cuda.device_count())

It will cause CUDA out of memory when execute the second line.
How would you like to use vllm
I want to use two model in pipeline in one python code to infer. When finish inference on the first model, how to release this model and release GPU memory to load another one, since directly reloading may cause CUDA OUT OF MEMORY for it doesn't release the first one.

Please see #5716. For now, you have to do it manually as follows (based on the code in tests/conftest.py:
import contextlib
import gc

import torch
from vllm.distributed import (destroy_distributed_environment,
                              destroy_model_parallel)
from vllm.utils import is_cpu

def cleanup():
    destroy_model_parallel()
    destroy_distributed_environment()
    with contextlib.suppress(AssertionError):
        torch.distributed.destroy_process_group()
    gc.collect()
    if not is_cpu():
        torch.cuda.empty_cache()

llm = LLM(...)
del llm
cleanup()

Please see #5716. For now, you have to do it manually as follows (based on the code in tests/conftest.py:
import contextlib
import gc

import torch
from vllm.distributed import (destroy_distributed_environment,
                              destroy_model_parallel)
from vllm.utils import is_cpu

def cleanup():
    destroy_model_parallel()
    destroy_distributed_environment()
    with contextlib.suppress(AssertionError):
        torch.distributed.destroy_process_group()
    gc.collect()
    if not is_cpu():
        torch.cuda.empty_cache()

llm = LLM(...)
del llm
cleanup()

It works! Thanks for your help~

Hi~ Does this also work with multiple-GPUs?

It should work in theory.


Enable array loading via dynamic type loader

Add canonical templates for arrays to the generic type template map.
The native layout for array templates uses Array. Remove several places that were getting the Array template and only fetch it when needed in the native layout type template.
Re-enable the assert for Array EEType detection for RyuJitNodeFactory to keep ourselves honest during type loader bring-up.
Properly emit variance info for all array interface types in the array template native layout (those interfaces had the variance set on their EEType previously in https://github.com/dotnet/corert/commit/3b66085793b54ae425e4bbebf13706906e857c52 and it was not agreeing during EEType creation at runtime).

Code change looks good, but it appears not to pass tests...

@davidwrighton PTAL


[WIP] Migrating to React 16

Motivation
Sadly Docusaurus is still using the old React 15 :(. With many major improvement and features that react v16 offers, I think this is the right time to update.
Fixes https://github.com/facebook/Docusaurus/issues/539
Have you read the [Contributing Guidelines on pull requests]
Yes

Thanks for doing this @gedeagas! I wanted to wait till we had some tests in place before upgrading to React 16, but I guess it if builds it should be fine 😄
Just to be clear, Docusaurus generates static output in the build step using React and is more of a website rather than a web app, so we don't really benefit too much from the perf improvements in React 16.
I'll do a little more extensive testing before approving.

Wow - that is all it takes to upgrade? I thought it would have taken a bit more 😄

Hi @yangshun I know, we use react renderToStaticMarkup right? I am planning to change the function to renderToStaticNodeStream but I guess it outputs the same thing and we don't need to change it.
Maybe any of the guys here want to use fragments or other feature that would be available in the next release ?. I know for our use case upgrading to v16 doesn't offer us many features or improvements.
Btw I didn't do much research on this but isn't renderToStaticMarkup on v16 is a bit faster than on v15?

@yangshun please test it, That is the reason why I tag this as WIP. If you guys find something fishy or wrong I will be happy to work on it.

Tested it locally and it worked great. Thanks for the help!


ft(client-side ideas): add client-side feature for ideas

What does this PR do?

move test mock data to seperate file

Description of Task to be completed?

add action and reducers to get all public ideas

add form to create Ideas

add page to show public ideas

add action and reducers to get user ideas

add page to show user  ideas

add action and reducers to show ideas by categories

add page to show Ideas by category

add action and reducer to update idea

add edit Idea form

How should this be manually tested?

check folder on Github

Any background context you want to provide?

feedback from scoreCard

What are the relevant pivotal tracker stories?
-https://www.pivotaltracker.com/story/show/153046003
Screenshots (if appropriate)

not applicable

Questions:

none

(finishes #153474663)

Changes Unknown when pulling 936d813699972247cb2ed7a8be84363ea2ac3d7f on ft-client-side-idea-153474663 into ** on development**.


[SDK] Get Job Pods Events

Our SDK should provide a better visibility to debug/monitor Training Operator Jobs for our users.
Users should not use kubectl to get information about their Training Jobs.
For example, Pod might stuck in Pending/ContainerCreating status for a few minutes (especially if image is huge or pod can't be scheduled to the Node) and user has to use kubectl to understand it.
Therefore, SDK should provide an API to expose Training Operator Job's Pods Kubernetes Events to give users better visibility.
I propose to extend get_job_logs() API to return Pod Events in addition to Pod logs.
For example, the return might look as follows:
$ client.get_job_logs(name, container="pytorch", is_master=False)

The events of Pod train-pytorch-master-0:
2023-07-14T13:21:11INFO Age: 0:04:20 Reason: Pulling Message: Pulling image "docker.io/pytorch/pytorch"
2023-07-14T13:21:11INFO Age: 0:00:20 Reason: Message: Successfully pulled image "docker.io/pytorch/pytorch" in 4m58.407916634s (4m58.407923916s including waiting)
2023-07-14T13:21:11INFO Age: 0:00:18 Reason: Created Message: Created container pytorch
2023-07-14T13:21:11INFO Age: 0:00:18 Reason: Started Message: Started container pytorch

The logs of pod train-pytorch-master-0:
2023-07-14T13:21:11Z INFO     Start training for RANK: 0. WORLD_SIZE: 3
2023-07-14T13:21:11Z INFO     Train Epoch: 0 [0/60000 (0%)]	loss=2.3084
2023-07-14T13:21:12Z INFO     Train Epoch: 0 [420/60000 (1%)]	loss=2.2995

The events of Pod train-pytorch-worker-1:
2023-07-14T13:21:11INFO Age: 0:04:20 Reason: Pulled Message: Container image "docker.io/alpine:3.10" already present on machine
.....

The logs of pod train-pytorch-worker-1:
2023-07-14T13:21:11Z INFO     Start training for RANK: 0. WORLD_SIZE: 3
2023-07-14T13:21:11Z INFO     Train Epoch: 0 [0/60000 (0%)]	loss=2.3084
2023-07-14T13:21:12Z INFO     Train Epoch: 0 [420/60000 (1%)]	loss=2.2995

What do you think @kubeflow/wg-training-leads @tenzen-y @kuizhiqing ?

Good idea. +1

It sounds good!
Also, at the same time, showing the event of FrameworkJob (e.g., TFJob) at the top might be helpful.
@andreyvelich WDYT?

Should this be a different API for providing more clarity ?

It would be helpful!
Maybe we should add new API get_job_events to print events of job and pods. And we add new arg with_events=False in API get_job_logs to make it possible to get all the information in the same API.

Also, at the same time, showing the event of FrameworkJob (e.g., TFJob) at the top might be helpful.

@tenzen-y That sounds good. The question is how to identify which Job user created ? get_job_logs doesn't have job_type as an input argument, and we just check which pod has these labels:
training.kubeflow.org/job-name=my-job
training.kubeflow.org/job-role=master

The same labels could have multiply jobs (e.g. PyTorchJob, XGBoostJob).
That ties to my other question, if we are going to introduce mandatory job_type argument to our  get_job_logs API, should we follow the same pattern for all APIs ?
E.g. instead of get_pytorchjob, get_tfjob, we are going to have a single API called: get_job which takes job_type as a mandatory argument and we are going to get appropriate job based on this type.
We can do the same for all other APIs: create_job, create_job_from_func, get_job, delete_job`, etc.
After refactoring our SDK: https://github.com/kubeflow/training-operator/pull/1719, I noticed that it is very confusing for the user that we have some CRUD operations job specific (e.g. create_tfjob), but some of them are not (e.g. get_job_pod_names, get_job_logs).
I can create separate issue to discuss this, and I am going to provide more feedback from the users soon.
cc @kubeflow/wg-training-leads

Should this be a different API for providing more clarity ?

I am not sure, if users who are not familiar with Kubernetes should know differences between events and logs.
Usually, when Data Scientists create a ML Job, they want to directly check the logs from this job (e.g. run get_job_logs API).
Otherwise, we should somehow explain them if get_job_logs API fails, they should run get_job_events API.
WDYT @johnugeorge ?

+1 Agree with you @andreyvelich

The same labels could have multiply jobs (e.g. PyTorchJob, XGBoostJob).
That ties to my other question, if we are going to introduce mandatory job_type argument to our get_job_logs API, should we follow the same pattern for all APIs ?
E.g. instead of get_pytorchjob, get_tfjob, we are going to have a single API called: get_job which takes job_type as a mandatory argument and we are going to get appropriate job based on this type.
We can do the same for all other APIs: create_job, create_job_from_func, get_job, delete_job`, etc.
After refactoring our SDK: https://github.com/kubeflow/training-operator/pull/1719, I noticed that it is very confusing for the user that we have some CRUD operations job specific (e.g. create_tfjob), but some of them are not (e.g. get_job_pod_names, get_job_logs).
I can create separate issue to discuss this, and I am going to provide more feedback from the users soon.

@andreyvelich Thanks for the clarification.
I agree with you. Let's work on events for XXXJob in another issue.

/assign @andreyvelich

/assign @andreyvelich


Designdoc/batching

Design document for creating and fetching batches. Closes #10
Also fixed a couple of issues in the delegation design doc.

Options:

No Delegation on chain, you are on your own for inside the batch BatchMessage(signer_has_msa_id)
No delegation on chain, but the schema MUST have msa_id BatchMessage(signer_has_msa_id)
Allow batch message on chain to have a signer and msa_id, but DSNP requires signer == chain's msa_id BatchMessage(signer_has_msa_id ?? msa_id), but DSNP wants ==
Option on schema to force signer == chain's msa_id BatchMessage(signer_has_msa_id == msa_id)

We like 1.

Simple
Cannot enforce it anyway because batches are off-chain
Flexible on the schemas


deleted_at is nil with db.Create

I'm trying to define a simple model and save an object using the model, however I'm getting the error using unaddressable value because deleted_at is nil when saving to the database. My expectation is that I don't have to pass deleted_at every time I create or update a record.
package main

import (
	"github.com/jinzhu/gorm"
	_ "github.com/jinzhu/gorm/dialects/sqlite"

)

type Event struct {
	gorm.Model
	Name string
}

func main() {
	db, err := gorm.Open("sqlite3", "test.db")
	if err != nil {
		panic("failed to connect database")
	}
	db.LogMode(true)

	db.AutoMigrate(&Event{})
	event := Event{Name: "test"}
	db.Create(event)
}

go run test.go

(/Users/ezra/dev/go/src/cr/test.go:23)
[2016-04-30 14:50:55]  using unaddressable value

(/Users/ezra/dev/go/src/cr/test.go:23)
[2016-04-30 14:50:55]  [1.26ms]  INSERT INTO "events" ("created_at","updated_at","deleted_at","name") VALUES ('0001-01-01T00:00:00Z','0001-01-01T00:00:00Z','<nil>','test')

Passing event by reference resolves the issue. Still, it seems reasonable to save an object without passing by reference without this error.


Visual Studio Code - Insiders installer does not feature directory context menu option; file context menu option does not work

Summary
Today, the Visual Studio Code - Insiders installer (both that obtained through winget install Microsoft.VisualStudioCode.Insiders -i and from the website at https://code.visualstudio.com/insiders) features only an option to "Add 'Open with Code - Insiders' action to Windows Explorer file context menu".
This is unlike the Visual Studio Code installer, which additionally features an "Add 'Open with Code' action to Windows Explorer directory context menu" option.
In addition to this missing option, the file context menu option that does exist does not in fact add such an option to the file context menu. This does work with the current Visual Studio Code installer (both that obtained through winget install Microsoft.VisualStudioCode -i and from the website at https://code.visualstudio.com/download).

The directory and file context menu are covered by single appx package, hence it has been merged into single item in the installer.
As for the context menu option not appearing with insiders, can you provide your OS build info and also the output of the following command Get-AppxPackage -Name Microsoft.VSCodeInsiders

OS build info:
OS Name	  Microsoft Windows 11 Pro
Version	  10.0.22621 Build 22621

Output of Get-AppxPackage -Name Microsoft.VSCodeInsiders:
RunspaceId             : 48a57680-b4c5-4e9e-9269-7f7fe0f4d68f
Name                   : Microsoft.VSCodeInsiders
Publisher              : CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US
PublisherId            : 8wekyb3d8bbwe
Architecture           : Neutral
ResourceId             :
Version                : <IP_ADDRESS>
PackageFamilyName      : Microsoft.VSCodeInsiders_8wekyb3d8bbwe
PackageFullName        : Microsoft.VSCodeInsiders_<IP_ADDRESS>_neutral__8wekyb3d8bbwe
InstallLocation        : C:\Program Files\WindowsApps\Microsoft.VSCodeInsiders_<IP_ADDRESS>_neutral__8wekyb3d8bbwe
IsFramework            : False
PackageUserInformation : {}
IsResourcePackage      : False
IsBundle               : False
IsDevelopmentMode      : False
NonRemovable           : False
Dependencies           : {}
IsPartiallyStaged      : False
SignatureKind          : Developer
Status                 : Ok

the appx package is installed, did you restart the file explorer (even restart the OS would be good) ? The appx package injects a DLL into the file explorer which sometimes requires the explorer service to be restarted.

I have attempted an OS reboot, which did not help. For what it's worth, the Visual Studio Code installer adds these options without even requiring an Explorer restart.

I think this issue is being tracked over in #183297

I'm getting the same issue. AppxPackage is installed but nothing shows on W11 context menu (after reboot):

For users still facing this issue please follow the steps in https://github.com/microsoft/vscode/issues/171911#issuecomment-1882892289 to move this issue forward, thanks!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Not supporting multi arch build images

Description
it doesnt appear that you support multiarch builds within ECR
Expected Behavior
You should
Actual Behavour
ECR is returning unauthorised.
Steps to Reproduce
This github action pipeline:
name: Build, Push to ECR, and Deploy to ECS

on:
  workflow_call:
    inputs:
      domain-name:
        required: true
        type: string
permissions:
      id-token: write   # This is required for requesting the JWT
      contents: read    # This is required for actions/checkout

env:
  AWS_REGION: ap-southeast-2  # Change this to your AWS region
  ECR_REPOSITORY: my-ecr-repo  # Change this to your ECR repository name
  ECS_CLUSTER: ecs-cluster  # Change this to your ECS cluster name
  ECS_SERVICE: ecs-service  # Change this to your ECS service name
  CONTAINER_NAME: ecs
  CRITICAL_THRESHOLD: 6
  HIGH_THRESHOLD: 8
  MEDIUM_THRESHOLD: 9
  LOW_THRESHOLD: 10
  OTHER_THRESHOLD: 20

jobs:
  deploy:
    runs-on: ubuntu-latest
    timeout-minutes: 60
    steps:
      # checkout the repository containing our Dockerfile
      - name: Checkout this repository
        uses: actions/checkout@v4

      # Setup prerequisites for docker/build-push-action
      - name: Set up docker build prereqs (QEMU)
        uses: docker/setup-qemu-action@v3

      - name: Set up docker build prereqs (Buildx)
        uses: docker/setup-buildx-action@v3

      - name: Cache Docker layers
        uses: actions/cache@v4
        with:
          path: /tmp/.buildx-cache
          key: ${{ runner.os }}-buildx-${{ github.sha }}
          restore-keys: |
            ${{ runner.os }}-buildx

      - name: Configure AWS credentials
        uses: aws-actions/configure-aws-credentials@v4
        with:
          role-to-assume: ${{ secrets.OICD_ROLE }}
          role-session-name: gh-${{ github.repository_id}}-${{ github.sha }}
          aws-region: ${{ env.AWS_REGION }}

      - name: Rolechain into deployment role
        uses: aws-actions/configure-aws-credentials@v4
        with:
          role-to-assume: ${{ secrets.DEPLOY_ROLE }}
          role-session-name: gh-d-${{ github.repository_id}}-${{ github.sha }}
          aws-region: ${{ env.AWS_REGION }}
          role-chaining: true

      - name: Login to Amazon ECR
        id: login-ecr
        uses: aws-actions/amazon-ecr-login@v1

      # build the image you wish to scan
      - name: Build Docker image
        uses: docker/build-push-action@v6
        with:
          context: .
          file: ./Dockerfile
          push: true
          build-args: |
            GIT_SHA=${{ github.sha }}
          tags: |
            ${{ steps.login-ecr.outputs.registry }}/${{ env.ECR_REPOSITORY }}:latest
            ${{ steps.login-ecr.outputs.registry }}/${{ env.ECR_REPOSITORY }}:${{ github.sha }}
          platforms: linux/amd64,linux/arm64
          cache-from: type=local,src=/tmp/.buildx-cache
          cache-to: type=local,dest=/tmp/.buildx-cache

      - name: Scan built image with Inspector
        uses: aws-actions/vulnerability-scan-github-action-for-amazon-inspector@v1
        id: inspector
        with:
          artifact_type: 'container'
          artifact_path: '${{ steps.login-ecr.outputs.registry }}/${{ env.ECR_REPOSITORY }}:${{ github.sha }}'
          critical_threshold: ${{ env.CRITICAL_THRESHOLD }}
          high_threshold: ${{ env.HIGH_THRESHOLD }}
          medium_threshold: ${{ env.MEDIUM_THRESHOLD }}
          low_threshold: ${{ env.LOW_THRESHOLD }}
          other_threshold: ${{ env.OTHER_THRESHOLD }}

The build output is:
Run aws-actions/vulnerability-scan-github-action-for-amazon-inspector@v1
/usr/bin/docker run --name ba3aa5675718851b04fbc868d1b775616f669_1ebd3d --label 1ba3aa --workdir /github/workspace --rm -e "AWS_REGION" -e "ECR_REPOSITORY" -e "ECS_CLUSTER" -e "ECS_SERVICE" -e "CONTAINER_NAME" -e "CRITICAL_THRESHOLD" -e "HIGH_THRESHOLD" -e "MEDIUM_THRESHOLD" -e "LOW_THRESHOLD" -e "OTHER_THRESHOLD" -e "AWS_DEFAULT_REGION" -e "AWS_ACCESS_KEY_ID" -e "AWS_SECRET_ACCESS_KEY" -e "AWS_SESSION_TOKEN" -e "INPUT_ARTIFACT_TYPE" -e "INPUT_ARTIFACT_PATH" -e "INPUT_CRITICAL_THRESHOLD" -e "INPUT_HIGH_THRESHOLD" -e "INPUT_MEDIUM_THRESHOLD" -e "INPUT_LOW_THRESHOLD" -e "INPUT_OTHER_THRESHOLD" -e "INPUT_DISPLAY_VULNERABILITY_FINDINGS" -e "INPUT_OUTPUT_SBOM_PATH" -e "INPUT_OUTPUT_INSPECTOR_SCAN_PATH" -e "INPUT_OUTPUT_INSPECTOR_SCAN_PATH_CSV" -e "INPUT_OUTPUT_INSPECTOR_SCAN_PATH_MARKDOWN" -e "INPUT_OUTPUT_INSPECTOR_DOCKERFILE_SCAN_PATH_CSV" -e "INPUT_OUTPUT_INSPECTOR_DOCKERFILE_SCAN_PATH_MARKDOWN" -e "INPUT_SBOMGEN_VERSION" -e "INPUT_SCANNERS" -e "INPUT_SKIP_SCANNERS" -e "INPUT_SKIP_FILES" -e "INPUT_TIMEOUT" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_REPOSITORY_OWNER_ID" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_REPOSITORY_ID" -e "GITHUB_ACTOR_ID" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKFLOW_REF" -e "GITHUB_WORKFLOW_SHA" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "GITHUB_STATE" -e "GITHUB_OUTPUT" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_ENVIRONMENT" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e "ACTIONS_ID_TOKEN_REQUEST_URL" -e "ACTIONS_ID_TOKEN_REQUEST_TOKEN" -e "ACTIONS_RESULTS_URL" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/example-ecs-fargate-pipeline/example-ecs-fargate-pipeline":"/github/workspace" 1ba3aa:5675718851b04fbc868d1b775616f669  "--artifact-type=container" "--artifact-path=xxx.dkr.ecr.ap-southeast-2.amazonaws.com/my-ecr-repo:e4ec5a89a346c47eb8f81af9a4109e0d7e436521" "--display-vuln-findings=disabled" "--out-sbom=./sbom_11199528445.json" "--out-scan=inspector_scan_11199528445.json" "--out-scan-csv=inspector_scan_11199528445.csv" "--out-scan-markdown=inspector_scan_11199528445.md" "--out-dockerfile-scan-csv=inspector_dockerfile_scan_11199528445.csv" "--out-dockerfile-scan-md=inspector_dockerfile_scan_11199528445.md" "--sbomgen-version=latest" "--thresholds" "--critical=6" "--high=8" "--medium=9" "--low=10" "--other=20" "--scanners=''" "--skip-scanners=''" "--skip-files=''" "--timeout=600"
time="2024-10-06 06:21:29" level=info msg="downloading and installing inspector-sbomgen version latest" file="orchestrator.py:14"
time="2024-10-06 06:21:30" level=info msg="generating SBOM from artifact" file="orchestrator.py:18"
time="2024-10-06 06:21:30" level=info msg="Amazon Inspector SBOM Generator v1.5.0 - linux amd64 - Copyright 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved" file="cli.go:157:"
time="2024-10-06 06:21:30" level=info msg="[/usr/local/bin/inspector-sbomgen container --image xxx.dkr.ecr.ap-southeast-2.amazonaws.com/my-ecr-repo:e4ec5a89a346c47eb8f81af9a4109e0d7e436521 --outfile ./sbom_11199528445.json --disable-progress-bar --timeout 600]" file="cli.go:158:"
time="2024-10-06 06:21:30" level=info msg="writing log file to: /github/home/.inspector-sbomgen/logs/inspector-sbomgen-log_2024-10-06_06-21-30.txt" file="cli.go:159:"
time="2024-10-06 06:21:30" level=info msg="initializing target artifact" file="coreV1.go:77:"
time="2024-10-06 06:21:30" level=info msg="created temporary staging directory: /github/home/.inspector-sbomgen/artifact-cache17119907[37](https://github.com/bjss/example-ecs-fargate-pipeline/actions/runs/11199528445/job/31132001285#step:12:38)" file="stagingdir.go:62:"
time="2024-10-06 06:21:30" level=info msg="checking if image is a tarball" file="imageInit.go:28:"
time="2024-10-06 06:21:30" level=info msg="checking if image exists in the local Docker daemon" file="imageInit.go:37:"
time="2024-10-06 06:21:30" level=info msg="checking if image can be downloaded from a remote registry" file="imageInit.go:46:"
time="2024-10-06 06:21:30" level=info msg="downloading remote container image: xxxx.dkr.ecr.ap-southeast-2.amazonaws.com/my-ecr-repo:e4ec5a89a346c47eb8f81af9a4109e0d7e436521" file="imageInit.go:191:"
time="2024-10-06 06:21:31" level=info msg="cleaning up any file system artifacts" file="artifactContainer.go:202:"
time="2024-10-06 06:21:31" level=info msg="deleting staging directory; please wait" file="stagingdir.go:113:"
time="2024-10-06 06:21:31" level=info msg="deleted staging directory: /github/home/.inspector-sbomgen/artifact-cache1711990737" file="stagingdir.go:122:"
2024/10/06 06:21:31 [ImageDownloadFailed]: failed to load image from tarball, local, or remote sources: GET https://xxx.dkr.ecr.ap-southeast-2.amazonaws.com/v2/my-ecr-repo/manifests/e4ec5a89a346c47eb8f81af9a4109e0d7e436521: unexpected status code 401 Unauthorized: Not Authorized
time="2024-10-06 06:21:31" level=error msg="unable to generate SBOM with inspector-sbomgen" file="orchestrator.py:442"

Other Information
Please provide any additional information such as logs or screenshots.
I see the e4ec5a89a346c47eb8f81af9a4109e0d7e436521 in my ecr:

When just doing this build action:
      # build the image you wish to scan
      - name: Build Docker image
        uses: docker/build-push-action@v6
        with:
          context: .
          file: ./Dockerfile
          push: true
          build-args: |
            GIT_SHA=${{ github.sha }}
          tags: |
            ${{ steps.login-ecr.outputs.registry }}/${{ env.ECR_REPOSITORY }}:latest
            ${{ steps.login-ecr.outputs.registry }}/${{ env.ECR_REPOSITORY }}:${{ github.sha }}

          cache-from: type=local,src=/tmp/.buildx-cache
          cache-to: type=local,dest=/tmp/.buildx-cache
          ```

(eg without any `Platform`) the scan would work. Given I see the image in ECR, it seems to suggest that the problem is not understanding that it is a multi-arch image?

So I think the big is somewhere within imageInit.go.

Hello, thank you for submitting the issue.
I understand you are having difficulty scanning a multi-arch image.
Multi-arch images are unsupported by this action at this time.
I am presently researching this to determine the level of effort involved in supporting the feature.
Additionally, I am exploring possible work-arounds for your consideration.
I will report back with additional guidance after I've validated work-arounds.

I'd imagine the only viable workaround would be to do this via some tagging standard. Eg
${ECR}:/${Some identifier}-${architecture}
      # build the image you wish to scan
      - name: Build Docker image
        uses: docker/build-push-action@v6
        with:
          context: .
          file: ./Dockerfile
          push: true
          build-args: |
            GIT_SHA=${{ github.sha }}
          tags: |
            ${{ steps.login-ecr.outputs.registry }}/${{ env.ECR_REPOSITORY }}:${{ github.sha }}-${arm64}
          load: true
          platforms: linux/amd64
          cache-from: type=local,src=/tmp/.buildx-cache
          cache-to: type=local,dest=/tmp/.buildx-cache

          ...

@tnh Hi there, I wanted to let you know that I was out most of last week with pneumonia - thank you for your continued patience. I'm resuming work on this feature again.
Now, I'm presently working on a PoC for supporting multi-arch images.
That said, I am interested in feedback for this use case if you have any to share.
May I ask, how would you like to scan multi-arch images with this action or in general?
Is it sufficient to add a new field that lets the user specify the image arch to scan?
Something like this:
platform: "linux/amd64"

Update: we have a pull request in progress that allows users to specify the container image platform they wish to scan:
https://github.com/aws-actions/vulnerability-scan-github-action-for-amazon-inspector/pull/102
We are planning on shipping this with our next release, ETA early November.
Feel free to let us know if you have questions or feedback.

@ethanr-bjss Hello, thank you for the follow-up.
Our intent is to publish a new release of this action within the next two weeks.
We may adjust those timelines if we feel more testing is warranted.

@ethanr-bjss @tnh
We have released a new version of this Action that supports multi-arch images.
Please see here for details:
https://github.com/aws-actions/vulnerability-scan-github-action-for-amazon-inspector/releases/tag/v1.2.0
Please feel encouraged to open an issue if you encounter any problems or have feedback.
Thank you!

Marking this issue as resolved.
Please re-open if this does not resolve your problem.


Added note about password updates on argon2 attributes change.

@wontonst Thanks :+1: Welcome aboard :boat:


Implemented Signed Pow Hint

Fixes: #441

Some nitpicks, but overall, looks good!

@TAdev0 , @MaksymMalicki , is there anything else that needs to be rectified ? Else, it would be great if you could approve and I will merge then.


Huzaifaahmed20 - added my duck

Description
Here my contribution to "The Duck Gallery".
You must respect the following conditions

Your contribution must respect the code of conduct
It's your first PR to this repository
You have added your image of the duck downloaded from https://pimpmyduck.zenika.com
You have not changed the image of the duck
The image filename must be your GitHub username (ex: your-username.png)
You are using your own GitHub user and it's the same as the PR author
Into the contributors.js file, the message must be short and respect the code of conduct

If the PR doesn't respect those conditions, it will be closed

My PR got accepted and merged into master, but why hacktoberfest site showing this


Extract minimal set of lima and qemu files to install on a clean machine

Installing qemu via homebrew installs 846MB of stuff under /usr/local/Cellar, 571MB of which are the qemu cellar alone.
This is clearly excessive for bundling lima with an app that simply wants to deploy VMs.
The attached script uses dtrace to observe which files are actually opened by lima and qemu, and then collects just those. It collects the corresponding symlinks and also modifies all Mach-O binaries to reference dylibs relative to the path of the executable, so the files can be relocated anywhere (the /usr/local prefix is stripped from all filenames).
There are still hard-coded paths to things under /usr/local inside the binaries, but testing shows that lima works with the bundled files as-is on a freshly installed Catalina VM (from memory, so may contain typos):
$ ssh-keygen
(enter, enter, enter)
$ touch ~/.ssh/known_hosts
$ mkdir ~/lima
$ cd ~/lima
$ tar xfvz ~/Downloads/lima-and-qemu.tar.gz
$ export PATH=~/lima/bin:$PATH
$ limactl start --tty=false

Compressed tarball is 18MB and contains the following files
/usr/local/Cellar/gettext/0.21/lib/libintl.8.dylib [58K]
/usr/local/Cellar/glib/2.68.3/lib/libgio-2.0.0.dylib [1.7M]
/usr/local/Cellar/glib/2.68.3/lib/libglib-2.0.0.dylib [1.2M]
/usr/local/Cellar/glib/2.68.3/lib/libgmodule-2.0.0.dylib [51K]
/usr/local/Cellar/glib/2.68.3/lib/libgobject-2.0.0.dylib [336K]
/usr/local/Cellar/gmp/6.2.1/lib/libgmp.10.dylib [437K]
/usr/local/Cellar/gnutls/3.6.16/lib/libgnutls.30.dylib [1.6M]
/usr/local/Cellar/jpeg/9d/lib/libjpeg.9.dylib [214K]
/usr/local/Cellar/libffi/3.3_3/lib/libffi.7.dylib [69K]
/usr/local/Cellar/libidn2/2.3.1/lib/libidn2.0.dylib [167K]
/usr/local/Cellar/libpng/1.6.37/lib/libpng16.16.dylib [173K]
/usr/local/Cellar/libslirp/4.6.1/lib/libslirp.0.dylib [160K]
/usr/local/Cellar/libssh/0.9.5_1/lib/libssh.4.8.6.dylib [394K]
/usr/local/Cellar/libssh/0.9.5_1/lib/libssh.4.dylib → libssh.4.8.6.dylib
/usr/local/Cellar/libtasn1/4.17.0/lib/libtasn1.6.dylib [103K]
/usr/local/Cellar/libunistring/0.9.10/lib/libunistring.2.dylib [1.5M]
/usr/local/Cellar/libusb/1.0.24/lib/libusb-1.0.0.dylib [136K]
/usr/local/Cellar/lzo/2.10/lib/liblzo2.2.dylib [113K]
/usr/local/Cellar/ncurses/6.2/lib/libncursesw.6.dylib [306K]
/usr/local/Cellar/nettle/3.7.3/lib/libhogweed.6.4.dylib [289K]
/usr/local/Cellar/nettle/3.7.3/lib/libhogweed.6.dylib → libhogweed.6.4.dylib
/usr/local/Cellar/nettle/3.7.3/lib/libnettle.8.4.dylib [268K]
/usr/local/Cellar/nettle/3.7.3/lib/libnettle.8.dylib → libnettle.8.4.dylib
<EMAIL_ADDRESS>[2.3M]
/usr/local/Cellar/p11-kit/0.24.0/lib/libp11-kit.0.dylib [975K]
/usr/local/Cellar/pcre/8.45/lib/libpcre.1.dylib [474K]
/usr/local/Cellar/pixman/0.40.0/lib/libpixman-<IP_ADDRESS>.dylib [550K]
/usr/local/Cellar/pixman/0.40.0/lib/libpixman-1.0.dylib → libpixman-<IP_ADDRESS>.dylib
/usr/local/Cellar/qemu/6.0.0/bin/qemu-img [1.4M]
/usr/local/Cellar/qemu/6.0.0/bin/qemu-system-x86_64 [13M]
/usr/local/Cellar/qemu/6.0.0/share/qemu/bios-256k.bin [256K]
/usr/local/Cellar/qemu/6.0.0/share/qemu/edk2-x86_64-code.fd [3.5M]
/usr/local/Cellar/qemu/6.0.0/share/qemu/efi-virtio.rom [157K]
/usr/local/Cellar/qemu/6.0.0/share/qemu/kvmvapic.bin [9.0K]
/usr/local/Cellar/qemu/6.0.0/share/qemu/vgabios-virtio.bin [39K]
/usr/local/Cellar/snappy/1.1.9/lib/libsnappy.1.1.9.dylib [74K]
/usr/local/Cellar/snappy/1.1.9/lib/libsnappy.1.dylib → libsnappy.1.1.9.dylib
/usr/local/Cellar/vde/2.3.2_1/lib/libvdeplug.3.dylib [52K]
/usr/local/bin/limactl [10M]
/usr/local/bin/qemu-img → ../Cellar/qemu/6.0.0/bin/qemu-img
/usr/local/bin/qemu-system-x86_64 → ../Cellar/qemu/6.0.0/bin/qemu-system-x86_64
/usr/local/opt/gettext → ../Cellar/gettext/0.21
/usr/local/opt/glib → ../Cellar/glib/2.68.3
/usr/local/opt/gmp → ../Cellar/gmp/6.2.1
/usr/local/opt/gnutls → ../Cellar/gnutls/3.6.16
/usr/local/opt/jpeg → ../Cellar/jpeg/9d
/usr/local/opt/libffi → ../Cellar/libffi/3.3_3
/usr/local/opt/libidn2 → ../Cellar/libidn2/2.3.1
/usr/local/opt/libpng → ../Cellar/libpng/1.6.37
/usr/local/opt/libslirp → ../Cellar/libslirp/4.6.1
/usr/local/opt/libssh → ../Cellar/libssh/0.9.5_1
/usr/local/opt/libtasn1 → ../Cellar/libtasn1/4.17.0
/usr/local/opt/libunistring → ../Cellar/libunistring/0.9.10
/usr/local/opt/libusb → ../Cellar/libusb/1.0.24
/usr/local/opt/lzo → ../Cellar/lzo/2.10
/usr/local/opt/ncurses → ../Cellar/ncurses/6.2
/usr/local/opt/nettle → ../Cellar/nettle/3.7.3
<EMAIL_ADDRESS>→<EMAIL_ADDRESS>/usr/local/opt/p11-kit → ../Cellar/p11-kit/0.24.0
/usr/local/opt/pcre → ../Cellar/pcre/8.45
/usr/local/opt/pixman → ../Cellar/pixman/0.40.0
/usr/local/opt/snappy → ../Cellar/snappy/1.1.9
/usr/local/opt/vde → ../Cellar/vde/2.3.2_1
/usr/local/share/lima/lima-guestagent.Linux-x86_64 [6.6M]
/usr/local/share/qemu → ../Cellar/qemu/6.0.0/share/qemu

@AkihiroSuda I'm not sure if you want this script in your repo; let me know. I probably need a place to host downloadable bits for Rancher Desktop elsewhere anyways, as we'll eventually need to sign the bits (at least for ARM), and probably want to build from source, eventually. So I could always keep the script in a separate repo.

Alternative idea: just remove obviously unneeded files
$ ls qemu-system-* | egrep -v "(x86_64|aarch64)" | du -hs
351M    .

Alternative idea: just remove obviously unneeded files

I would argue that that is just what I'm doing. Files that are not being opened while lima starts up/runs/shuts down are obviously unneeded... 😄
I'm interested in getting the smallest possible package size because we want to include all of these in Rancher Desktop.app. With this script, the unpacked size of all needed qemu files is just 28MB (without lima and without EFI), which is significantly less than the 220MB you are left with after deleting the "obviously unneeded" files for other architectures.


Usage Example?

It would be great to get a full usage example, all the way to rendering in Maya / ImageArray.
I am not all that familiar with type-level recursion and so have not figured out how to combine createCode or drawHypertexture with the actual instances in Examples.hs.
Thanks.

Thanks for the suggestion!
I was in the midst of creating a new version of this project when I caught corona and everything ground to a halt :disappointed: . So since a big API breaking change is coming when I recover I won't release a full example using this code, but I will ensure I create a full end to end example for the new version.
However, in the meantime here is a little example of how to print out a cross section of a fireball:
writePGM 50 50 $ -- produces a PGM file
  drawHypertexture 50 50 25 $ -- this captures the full length and breath, taking a crosssection of the middle
    cata alg (fireball (0,50) (0,50) (0,50) 40)

No need to be familar with the recursion. All you have to do is use cata alg on your Hypertexture and the correct instance will be generated. Here it infers the type of a Fuzzy Set instance due to the context of drawHypertexture.

NOTE:- if you want to create something with the Maya instance you will only have access to the language parts in the MELLang subsection.


[NewPacket] MapEventState

To enable/disable visual effect for events like red dragon invasion, golden dragon invasion.

Thanks, looks perfect 👍


Check CI flags

High Level Description
Exit 0 when CI_FLAGS env var is set. Commit cherry-picked from master with no changes: aa4bcd4cb2214f6dcfbcba019537e0e3cfbe9db7 See https://github.com/dcos/dcos/pull/1373 for original review.
Related Issues
DCOS-14580
https://jira.mesosphere.com/browse/DCOS-14580
Checklist for all PR's

[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and Review Process
What is the review process and when will my changes land?
All PRs require 2 approvals using github's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

Ready for review @spahl @amitaekbote

@branden or @orsenthil can you take a look at the code-quality failure here? For some reason it was expecting 1.9-dev and got 1.9.0-rc4... either a problem with the test or we missed a version bump somewhere.
cc: @spahl

@lingmann We missed a version bump. We need to bump the version that test expects when we bump the version in gen/calc.py.

Oops, my bad

IOW, the code-quality is actually a unit-test failure.


Add cpp filetype support

Just adding the cpp filetype as a builtin that trevJ can handle.

Awesome! :tada:
Would you mind rebasing, it seems I also fixed the indentation :)
Btw, should this be the same as for c-filetype? If so, I'm wondering if it would be good to bundle them? Not sure how important it would be but would require a slight restructure of how it's currently handled.

No problem :) Yeah that makes sense, could you maybe move out the table for cpp and make it a variable and assign it to both c and cpp in the containers table?
local make_c_containers = function()
  return {...}
end

local settings = {
  containers = {
    c = make_c_containers()
    cpp = make_c_containers()
    ...

Thanks!


[Bug] Back button after bank transfer completion leads to error

Describe the bug
A donor  chooses a campaign, clicks on Support, chooses to use bank transfer, then receives the code and clicks next. Then clicks back, because he didn't copy his code.
I suppose the back button breaks the session, because the error message is
"За съжаление, възникна проблем!"

@Juicebgs I can't reproduce the error. Can you check if I'm doing the right steps?
Screencast from 14.08.2022 19:43:54.webm

The problem is in the interpretation of the query parameter for success -> when not passed, it is assumed as false and the error is shown.
Check for the logic related to this line in Steps.tsx
const success = router.query.success === 'true' ? true : false.

I cannot reproduce the issue. It seems to be fixed?
@igoychev could you recheck please?

Closing this issue as fixed.
Tested on Chrome and Firefox.


Transaction gossiping

Transaction gossiping, using

lazyledger-core/tendermint mempool
libp2p GossipSub on P2P layer

Resolves #3.
Depends on #17 and #30.

Codecov Report

Merging #29 (cc64246) into main (2ec85bb) will decrease coverage by 31.04%.
The diff coverage is 31.57%.

@@             Coverage Diff             @@
##             main      #29       +/-   ##
===========================================
- Coverage   71.81%   40.77%   -31.05%
===========================================
  Files           3        4        +1
  Lines         110      233      +123
===========================================
+ Hits           79       95       +16
- Misses         16      121      +105
- Partials       15       17        +2

Impacted Files
Coverage Δ

rpcclient/local.go
6.25% <0.00%> (ø)

p2p/client.go
70.47% <63.15%> (+1.32%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ec85bb...cc64246. Read the comment docs.

It seems the nodes are not really connected with each other now.


Latest build (1.13.0) breaks react native project

Describe what happened
Build error: app/build/generated/datadog/buildId/devRelease/datadog.buildId: Resource and asset merger: Duplicate resources
Steps to reproduce the issue:
app build.gradle file:
plugins {
    (...)
    id("com.datadoghq.dd-sdk-android-gradle-plugin") version "1.+"
}

datadog {
    checkProjectDependencies = "none"
}

apply from<EMAIL_ADDRESS>(...)

Describe what you expected:
Build breaks with error: app/build/generated/datadog/buildId/devRelease/datadog.buildId: Resource and asset merger: Duplicate resources
Downgrading com.datadoghq.dd-sdk-android-gradle-plugin to 1.12.0 fixes the issue.

Hi @andresousa! Thanks for reporting it. Can you please share with us version of the our React Native SDK you are using?

Hi I'm having same issue with
 "react-native": "0.72.5",
 "@datadog/mobile-react-native": "^2.2.0"

Hope this helps

This should be fixed now in 1.14.0 release, please try it out.


Switch to back cam in Mobile

My phone has two cameras.
One in the front, and other in the back; nothing crazy.
Though, I'd like to switch between the front camera to the back camera with just a button.
Is this possible?

IIRC firefox mobile lets you choose which camera to use. You'd need to use mediaDevices.enumerateDevices to get a list of cameras and then provide a way to change the stream. The library that's used for establishing the peer connection did not support dynamic switching of streams, meaning the user would have to reconnect (or refresh the page). I don't currently have the time to implement that but you're welcome to implement it and create a pull request. Check the CONTRIBUTING.md file if you're interested.

I'll checked and tried but nothing came up just yet 👎

By the way, in which files do you have the camera settings and all that so I can look further?
Help me out with that so I can contribute, I'm short in time as well, but I'll do my best

https://github.com/feross/simple-peer/issues/114#issuecomment-269812335

https://github.com/feross/simple-peer/issues/114#issuecomment-269812335
We would end-up refreshing everything anyways and load another code just to get this done. That seems pretty rough.
Any ideas, @jeremija?

This should work since 0a40e72 (not in production yet). Users can now select audio and video input source before connecting. I still need to add the ability to show the configuration menu after connecting.

Switching camera dynamically after connecting has been possible since ef55c5c (v4.0.0)


feat: Auth vue setup and configure tailwind

closes #8
Signed-off-by: talwinder.kaur<EMAIL_ADDRESS>

The page looks good!

Agreed - thanks @talwinder50 !

@talwinder50 this UI is not being served by the backend

@talwinder50 has agreed to do this in a followup PR


Only count Statements caused by specific statement

First thank you this library. It really works well :)
It would be nice to have also the possibility to assert sql selects/inserts/.. for a specific statement like
assertSelectsBy(() -> myRepository.findAll(),10)

I would love to use this as well, since I often tests in the style where there is some test specific setup done inside the test, and I don't really want to assert those, but a single controller call or service call.
It should be possible to have such methods like assertSelectsBy that record the count in the beginning of the call and compare those to the count at the end and assert it.

It could be just as simple as the following methods.
public class Assertions {

	public static void assertSelects(Runnable runnable, int expectedCount) {
		int size1 = HibernateStatementInspector.getStatistics().getSelectStatements().size();
		runnable.run();
		int size2 = HibernateStatementInspector.getStatistics().getSelectStatements().size();
		int realCount = size2 - size1;
		if (expectedCount != realCount) {
			String errorMessages = "Expected " + expectedCount + " select, but got " + realCount;
        	throw new HibernateAssertCountException(errorMessages);
		}
	}
}

Thanks for the use case, I will look at it

Added in 2.1.0, hope that suits your needs 😄


Empty mustache tag values should return nothing

For example, if you have the following as part of your instructions:

amenity={{amenity}}
name={{name}}
source={{source}}

and the value of {{name}} in your source is empty, your contributor will see something like:
amenity=fire_station
name={{name}}
source=Bureau of Fire Protection

While ideally, one could expect something like:
amenity=fire_station
name=
source=Bureau of Fire Protection

Maybe empty mustache tags should return nothing, instead of the tag itself.

This behavior changed recently, and now an empty variable returns the a string, "null." Would it be possible to just returning nothing, like:
amenity=fire_station
name=
building=yes

Instead of
amenity=fire_station
name=null
building=yes

which used to be
amenity=fire_station
name={{null}}
building=yes

They should now show empty if missing, e.g.
amenity=fire_station
name=

Hi again. I was drafting a new challenge today, and noticed that this behavior is back.
When a empty value is encountered for a mustache tag, it again returns "null"

PR #1465 overhauls the implementation of the templating system used in the Task Instructions, and should permanently address this issue.


change kubevrit cert secret type from Opaque to kubernetes.io/tls

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://github.com/kubevirt/kubevirt/issues/6729
Special notes for your reviewer:
Release note:

change kubevrit cert secret type from Opaque to kubernetes.io/tls

/test all

According to the k8s doc the only requirment to have a valid kubernetes.io/tls type is to use the following secret keys: tls.crt and tls.key which we do. If the tests are fine with it too, the change is fine by me. :+1:

/lgtm
/approve
/retest

Thanks!

/retest

/hold
@zhhray I think your changes in the production code are fine, but some unit-tests are injecting faulty vaules into the secret to validate that we can recover. The injected data is now rejected by the apiserver due to the new type.
Can you have a look at the affected tests: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/6730/pull-kubevirt-e2e-k8s-1.20-sig-compute/1456228553010974720?

/hold
@zhhray I think your changes in the production code are fine, but some unit-tests are injecting faulty vaules into the secret to validate that we can recover. The injected data is now rejected by the apiserver due to the new type.
Can you have a look at the affected tests: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/6730/pull-kubevirt-e2e-k8s-1.20-sig-compute/1456228553010974720?

OK, I'm try to fix it.

/hold
@zhhray I think your changes in the production code are fine, but some unit-tests are injecting faulty vaules into the secret to validate that we can recover. The injected data is now rejected by the apiserver due to the new type.
Can you have a look at the affected tests: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/6730/pull-kubevirt-e2e-k8s-1.20-sig-compute/1456228553010974720?

/retest

/ok-to-test

/lgtm

/unhold

@zhhray once all tests are happy, can you squash all changes into a single commit?

@zhhray once all tests are happy, can you squash all changes into a single commit?

OK, that's exactly what I was thinking.

@rmohr I wonder why the ca-bundle in configmap kubevirt-ca was not updated in the e2e test report. Could someone please help to check the reason?

@rmohr I wonder why the ca-bundle in configmap kubevirt-ca was not updated in the e2e test report. Could someone please help to check the reason?

Could you be more specific? Maybe pointing to the job and the message?

@rmohr I wonder why the ca-bundle in configmap kubevirt-ca was not updated in the e2e test report. Could someone please help to check the reason?

Could you be more specific? Maybe pointing to the job and the message?

I mean, unit tests fail for the following reasons:
Tests Suite: [Serial][sig-compute]Infrastructure [rfe_id:4102][crit:medium][vendor:cnv-qe@redhat.com][level:component]certificates [test_id:4099] should be rotated when a new CA is created
tests/infra_test.go:249
Timed out after 10.001s.
the new CA should be added to the config-map
Expected
    <bool>: false
to be true
tests/infra_test.go:282

In the case of unit test, after updating secret data named kubevirt-ca as nonsense content, according to the previous logic, theoretically cert-Manager will automatically rebuild CA, including Secret Data and ConfigMap Data.
But I don't know why the unit test failed.

/retest

In the case of unit test, after updating secret data named kubevirt-ca as nonsense content, according to the previous logic, theoretically cert-Manager will automatically rebuild CA, including Secret Data and ConfigMap Data.
But I don't know why the unit test failed.

I think we have even an issue for this flaky unit test. Let's see what the tests say now.
/lgtm

I mean, unit tests fail for the following reasons:

Oh wait, this is not a unit- tests. You meant a functional test. That test has to work. We can not skip it.

@rmohr I have squashed all the commits. Now we need to wait for tests to be happy.

/retest-required

@rmohr Is it ok to approve now.

@rmohr Is it ok to approve now.

Now it looks like I would have expected and tests are passing. Thanks :)
/lgtm

@rmohr Is it ok to approve now.

Now it looks like I would have expected and tests are passing. Thanks :)
/lgtm

Thanks!


How to obtain the logs of "Building flutter tool..." ?

1.Run "flutter upgrade --verbose" in terminal
2. Everything logs fine until the part where "Building flutter tool..." stays there [works without logging anything ], when it reaches a certain point my system freezes . It might be a package installed in my system that is doing some shady work with flutter so i wanna fix it since i have searched for this particular error everywhere and it seems to be pc-related so it's not in the search results -.-
So... is there a way of logging what happens when flutter "builds" it's tool ?

Please include the output of flutter doctor -v.
When building the flutter tool, we're using the dart compiler's ability to generate a snapshot of code. There are no logs generated by this process, as it is only doing compilation and not, say, downloading binaries.
It definitely shouldn't be freezing though

When it freezes my system i have to "REISUB" ir, so when the pc boots again and type any flutter related command , it says "Building flutter tool..." again and then freezes again.
The only solution i have found is to manually download the zip from https://flutter.dev/docs/development/tools/sdk/releases and then replace the content in my flutter folder with that.
However, when using flutter commands, the freeze is random, it can happen when i run an app , i attach an app, i analyze a file,etc so i think i should buy a new computer ;-;.
I have tried using a fresh instalation of lubuntu 18.10 and 19.04 , using multiple flutter versions [manually downloaded] , i even thought it was my bios so i update it . I don't know what flutter or dart does but it's freezing my pc D: it doesn't happen with other program or at least i have not found it , if it happens with other program then at least i would like to know what is dart doing to my system .
The doctor output seems normal [replaced sensitive information]

[✓] Flutter (Channel dev, v1.5.4, on Linux, locale ....UTF-8)
• Flutter version 1.5.4 at /home/.../flutter
• Framework revision b593f5167b (2 days ago), 2019-04-22 07:51:33 -0700
• Engine revision ca31a7c57b
• Dart version 2.3.0 (build 2.3.0-dev.0.1 cf4444b803)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /home/.../Android
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• ANDROID_HOME = /home/.../Android
• Java binary at: /home/.../Java/jdk1.8.0_212/bin/java
• Java version Java(TM) SE Runtime Environment (build 1.8.0_212-b10)
• All Android licenses accepted.
[!] Android Studio (not installed)
• Android Studio not found; download from https://developer.android.com/studio/index.html
(or visit https://flutter.dev/setup/#android-setup for detailed instructions).
[!] Connected device
! No devices available
! Doctor found issues in 2 categories.

Using script to capture some extensive logs i have found that the las that i can get is this part

MSG : Precompiling executables...
IO  : Writing 33 characters to text file ./.dart_tool/pub/bin/sdk-version.
FINE: Contents:
| 2.3.0-dev.0.1.flutter-1f1592edce
IO  : Deleting directory ./.dart_tool/pub/bin/kernel.
IO  : Deleting directory ./.dart_tool/pub/bin/coverage.
IO  : Deleting directory ./.dart_tool/pub/bin/dart_style.
IO  : Deleting directory ./.dart_tool/pub/bin/completion.
IO  : Deleting directory ./.dart_tool/pub/bin/linter.
IO  : Deleting directory ./.dart_tool/pub/bin/archive.
IO  : Deleting directory ./.dart_tool/pub/bin/test.
IO  : Deleting directory ./.dart_tool/pub/bin/csslib.
IO  : Deleting directory ./.dart_tool/pub/bin/build_runner.
IO  : Spawning "/home/User/flutter/bin/cache/dart-sdk/bin/dart --packages=file:///home/User/flutter/packages/flutter_tools/.packages --snapshot=./.dart_tool/pub/bin/kernel/count_breakdown.dart.snapshot.dart2 file:///home/User/flutter/.pub-cache/hosted/pub.dartlang.org/kernel-0.3.14/bin/count_breakdown.dart" in /home/User/flutter/packages/flutter_tools/.
IO  : Spawning "/home/User/flutter/bin/cache/dart-sdk/bin/dart --packages=file:///home/User/flutter/packages/flutter_tools/.packages --snapshot=./.dart_tool/pub/bin/kernel/dump.dart.snapshot.dart2 file:///home/User/flutter/.pub-cache/hosted/pub.dartlang.org/kernel-0.3.14/bin/dump.dart" in /home/User/flutter/packages/flutter_tools/.
IO  : Spawning "/home/User/flutter/bin/cache/dart-sdk/bin/dart --packages=file:///home/User/flutter/packages/flutter_tools/.packages --snapshot=./.dart_tool/pub/bin/kernel/size_breakdown.dart.snapshot.dart2 file:///home/User/flutter/.pub-cache/hosted/pub.dartlang.org/kernel-0.3.14/bin/size_breakdown.dart" in /home/User/flutter/packages/flutter_tools/.
IO  : Spawning "/home/User/flutter/bin/cache/dart-sdk/bin/dart --packages=file:///home/User/flutter/packages/flutter_tools/.packages --snapshot=./.dart_tool/pub/bin/kernel/split.dart.snapshot.dart2 file:///home/User/flutter/.pub-cache/hosted/pub.dartlang.org/kernel-0.3.14/bin/split.dart" in /home/User/flutter/packages/flutter_tools/.
IO  : Spawning "/home/User/flutter/bin/cache/dart-sdk/bin/dart --packages=file:///home/User/flutter/packages/flutter_tools/.packages --snapshot=./.dart_tool/pub/bin/kernel/transform.dart.snapshot.dart2 file:///home/User/flutter/.pub-cache/hosted/pub.dartlang.org/kernel-0.3.14/bin/transform.dart" in /home/User/flutter/packages/flutter_tools/.
IO  : Spawning "/home/User/flutter/bin/cache/dart-sdk/bin/dart --packages=file:///home/User/flutter/packages/flutter_tools/.packages --snapshot=./.dart_tool/pub/bin/kernel/type_check.dart.snapshot.dart2 file:///home/User/flutter/.pub-cache/hosted/pub.dartlang.org/kernel-0.3.14/bin/type_check.dart" in /home/User/flutter/packages/flutter_tools/.
IO  : Spawning "/home/User/flutter/bin/cache/dart-sdk/bin/dart --packages=file:///home/User/flutter/packages/flutter_tools/.packages --snapshot=./.dart_tool/pub/bin/coverage/collect_coverage.dart.snapshot.dart2 file:///home/User/flutter/.pub-cache/hosted/pub.dartlang.org/coverage-0.12.4/bin/collect_coverage.dart" in /home/User/flutter/packages/flutter_tools/.
IO  : Spawning "/home/User/flutter/bin/c

as you may notice the last line is incomplete because the script didn't had enought time to write it to the file . However if i try reconstructing it it would be like

Spawning "/home/User/flutter/bin/cache/dart-sdk/bin/dart --packages=file:///home/User/flutter/packages/flutter_tools/.packages --snapshot=./.dart_tool/pub/bin/build_runner/graph_inspector.dart.snapshot.dart2 file:///home/User/flutter/.pub-cache/hosted/pub.dartlang.org/build_runner-1.3.1/bin/graph_inspector.dart" in /home/User/flutter/packages/flutter_tools/.

That's the last thing that pub returns in the console -.-
I think i'm gonna use another computer for flutter since i don't want to deal whit this problem that nobody has. Thank you 7u7

I also encountered this problem.

This is my solution :

delete ~/flutter/bin/cache
run flutter doctor
a few minutes later,  the flutter tool will be built .

Using script to capture some extensive logs i have found that the las that i can get is this part

MSG : Precompiling executables...
IO  : Writing 33 characters to text file ./.dart_tool/pub/bin/sdk-version.
FINE: Contents:
| 2.3.0-dev.0.1.flutter-1f1592edce
IO  : Deleting directory ./.dart_tool/pub/bin/kernel.
IO  : Deleting directory ./.dart_tool/pub/bin/coverage.
IO  : Deleting directory ./.dart_tool/pub/bin/dart_style.
IO  : Deleting directory ./.dart_tool/pub/bin/completion.
IO  : Deleting directory ./.dart_tool/pub/bin/linter.
IO  : Deleting directory ./.dart_tool/pub/bin/archive.
IO  : Deleting directory ./.dart_tool/pub/bin/test.
IO  : Deleting directory ./.dart_tool/pub/bin/csslib.
IO  : Deleting directory ./.dart_tool/pub/bin/build_runner.
IO  : Spawning "/home/User/flutter/bin/cache/dart-sdk/bin/dart --packages=file:///home/User/flutter/packages/flutter_tools/.packages --snapshot=./.dart_tool/pub/bin/kernel/count_breakdown.dart.snapshot.dart2 file:///home/User/flutter/.pub-cache/hosted/pub.dartlang.org/kernel-0.3.14/bin/count_breakdown.dart" in /home/User/flutter/packages/flutter_tools/.
IO  : Spawning "/home/User/flutter/bin/cache/dart-sdk/bin/dart --packages=file:///home/User/flutter/packages/flutter_tools/.packages --snapshot=./.dart_tool/pub/bin/kernel/dump.dart.snapshot.dart2 file:///home/User/flutter/.pub-cache/hosted/pub.dartlang.org/kernel-0.3.14/bin/dump.dart" in /home/User/flutter/packages/flutter_tools/.
IO  : Spawning "/home/User/flutter/bin/cache/dart-sdk/bin/dart --packages=file:///home/User/flutter/packages/flutter_tools/.packages --snapshot=./.dart_tool/pub/bin/kernel/size_breakdown.dart.snapshot.dart2 file:///home/User/flutter/.pub-cache/hosted/pub.dartlang.org/kernel-0.3.14/bin/size_breakdown.dart" in /home/User/flutter/packages/flutter_tools/.
IO  : Spawning "/home/User/flutter/bin/cache/dart-sdk/bin/dart --packages=file:///home/User/flutter/packages/flutter_tools/.packages --snapshot=./.dart_tool/pub/bin/kernel/split.dart.snapshot.dart2 file:///home/User/flutter/.pub-cache/hosted/pub.dartlang.org/kernel-0.3.14/bin/split.dart" in /home/User/flutter/packages/flutter_tools/.
IO  : Spawning "/home/User/flutter/bin/cache/dart-sdk/bin/dart --packages=file:///home/User/flutter/packages/flutter_tools/.packages --snapshot=./.dart_tool/pub/bin/kernel/transform.dart.snapshot.dart2 file:///home/User/flutter/.pub-cache/hosted/pub.dartlang.org/kernel-0.3.14/bin/transform.dart" in /home/User/flutter/packages/flutter_tools/.
IO  : Spawning "/home/User/flutter/bin/cache/dart-sdk/bin/dart --packages=file:///home/User/flutter/packages/flutter_tools/.packages --snapshot=./.dart_tool/pub/bin/kernel/type_check.dart.snapshot.dart2 file:///home/User/flutter/.pub-cache/hosted/pub.dartlang.org/kernel-0.3.14/bin/type_check.dart" in /home/User/flutter/packages/flutter_tools/.
IO  : Spawning "/home/User/flutter/bin/cache/dart-sdk/bin/dart --packages=file:///home/User/flutter/packages/flutter_tools/.packages --snapshot=./.dart_tool/pub/bin/coverage/collect_coverage.dart.snapshot.dart2 file:///home/User/flutter/.pub-cache/hosted/pub.dartlang.org/coverage-0.12.4/bin/collect_coverage.dart" in /home/User/flutter/packages/flutter_tools/.
IO  : Spawning "/home/User/flutter/bin/c

as you may notice the last line is incomplete because the script didn't had enought time to write it to the file . However if i try reconstructing it it would be like

Spawning "/home/User/flutter/bin/cache/dart-sdk/bin/dart --packages=file:///home/User/flutter/packages/flutter_tools/.packages --snapshot=./.dart_tool/pub/bin/build_runner/graph_inspector.dart.snapshot.dart2 file:///home/User/flutter/.pub-cache/hosted/pub.dartlang.org/build_runner-1.3.1/bin/graph_inspector.dart" in /home/User/flutter/packages/flutter_tools/.

That's the last thing that pub returns in the console -.-
I think i'm gonna use another computer for flutter since i don't want to deal whit this problem that nobody has. Thank you 7u7

How did you get these logs, please?


Use pub_updator for serverpod_cli

Discussed in https://github.com/serverpod/serverpod/discussions/606

Originally posted by shan-shaji February  2, 2023
https://pub.dev/packages/pub_updater
I believe it would be nice to give the developers a prompt to update the package if a new version of the package is updated in pub.dev.

@vlidholt  Hi. I made a possible solution for it. Without adding additional lib pub_updater
I have added only one pub Logger. But it can be easily replaced by making an in-house print.
The current output result is:

Please feel free to propose any changes!

Perhaps copy the style of Flutter to make it feel more familiar.
┌─────────────────────────────────────────────────────────┐
│ A new version of Flutter is available!                  │
│                                                         │
│ To update to the latest version, run "flutter upgrade". │
└─────────────────────────────────────────────────────────┘

The update instructions are a bit more involved with Serverpod as you will need to add the new version to:

The tooling, update by running dart pub global activate serverpod_cli
Add the new version to your server, client, and flutter packages.

@vlidholt Hello. Thanks for the update. this message style can be printed without an additional lib. I can create a PR with these changes if you approve the text.
┌───────────────────────────────────────────────────────────────────────────────────────┐
│ A new version of Serverpod is available!                                              │
│                                                                                │
│ To update to the latest version, run "dart pub global activate serverpod_cli".        │
│ Also, do not forget to update packages in your server, client, and flutter projects.  │
└───────────────────────────────────────────────────────────────────────────────────────┘

Looking good.

Hey @damienissa!
Starting from your commits I'll push this over the finish line.
Might postpone some of the nice error messaging and do that as part issue #1042. Then we can do an overhaul on all messaging and logging for the Cli.


Update Monaco standalone editor icons

Fixes #77416
This updates all of the icons in the Monaco standalone editor so they match our new style. I also fixed some of the CSS that wasn't showing icon in high contrast mode.
Dark

Light

High Contrast

Thanks! Verified in standalone on macOS.


yurt-tunnel and yurt-controller-manager component are deprecated

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement
What this PR does / why we need it:
because yurt-tunnel and yurt-controller-manager are deprecated, so remove them in trivy to improve efficiency.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

/lgtm
/approve

/approve


Infer array element type for newly created variable when assigning to a new empty array

Suggestion
🔍 Search Terms
array assignment infer
empty array

List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily and help provide feedback.
✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

When creating an array variable using const or let and assign it to an array after another typed array variable, type should be inferred from the variable:
class Foo {

    foo: number[];

    doSomething() {
        const a = this.foo = []; // a is now any[] or never[]
        const b: number[] = this.foo = []; // b is number[] but we have to repeat the type declaration
    }

}

There seem to be inconsistency between IDEs as well, for VS Code it's any[] while for playground, it's never[]. See my question on StackOverflow about this
📃 Motivating Example
Right now, the above code would result in compile error if --noImplicitAny is specified (at least for VS and VS Code). You also do not have strongly typed variables for the array's element. With this feature implemented, you can now write:
class Manager {

    foo: Employee[];

    doSomething() {
        const foo = this.foo = []; // a should be Employee[]

        for (let item of arr) { foo.push(item); }

        foo[0].role = "manager"; // Elements are now strongly typed.
    }

}

💻 Use Cases
I use this code a lot when writing HTML templates for small projects without frameworks like Angular. For example:
export class MyComponent extends HTMLElement {

    // Others
    items: ListItem[];

    set(list: ListItem[]) {
        // This would result in error currently in VS Code with noImplicitAny
        const items = this.items = [];
        for (let item of items) {
            // Other code
            items.push(item);
        }

        // Work with items
        for (let item of items) {
                // item is any currently, not ListItem
        }
    }
}

Aside: it is probably compiler options and not IDE that is responsible for never[] vs any[].  Might just be --strictNullChecks?


Removing unneccessary slash when working with root directory

fixes #19491
@MuazmaZ @gapra-msft I've opened a pull request with a possible solution

Closing as this Pr was subsumed by the one mentioned in the thread and the issue is resolved.


Better flat-fielding

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

85 of 86 (98.84%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 86.728%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

mirar/pipelines/winter/models/_fp_astrometry_stats.py
59
60
98.33%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
10410

Relevant Lines:
12003

💛  - Coveralls


Initial implementation, just to get something in, parallel processing using records

First of all: Nice work running such a competition, love it.
My implementation is: [CalculateAverage_royvanrijn.java]
Using the default installed JDK on my machine (21.0.1-zulu) on an M2 Macbook Pro (32 GB), it runs in +/- 0m54.437s

Very nice, thank you so much for submitting something so quickly! Can confirm it's definitely faster than the baseline, congrats for taking over the leaderboard :) Running it as we speak, will update the board in a bit.

Squashed the two commits into one and merged. Thanks again, @royvanrijn! Congrats on taking over the leaderboard :)


Make build pass on JDK11

This patch allows you to build KOP on JDK11.
Without this patch the build fails with this error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project kafka-client-factory: Compilation failure: Compilation failure:
[ERROR] /Users/enrico.olivelli/dev/kop/kafka-client-factory/src/main/java/io/streamnative/kafka/client/api/KafkaClientFactoryImpl.java:[33,20] cannot access org.apache.kafka-1-0-0.clients.producer.KafkaProducer
[ERROR]   class file for org.apache.kafka-1-0-0.clients.producer.KafkaProducer not found
[ERROR] /Users/enrico.olivelli/dev/kop/kafka-client-factory/src/main/java/io/streamnative/kafka/client/api/KafkaClientFactoryImpl.java:[41,20] cannot access org.apache.kafka-1-0-0.clients.consumer.KafkaConsumer
[ERROR]   class file for org.apache.kafka-1-0-0.clients.consumer.KafkaConsumer not found
[ERROR] -> [Help 1]
[ERROR]

Modifications
do not use '-' in the package name
As I do not have signed an ICLA with this repo, I would like to state explicitly that I am sending this patch according to the terms Apache License v2.

Thanks for your contribution. It makes sense to me.
But I have a concern that some version number may have two digits like Kafka <IP_ADDRESS>. If we supported these versions in future, what's the best way to name the package? kafka01000?

The getStringSerializer and getStringDeserializer should also be modified, for example,
    public String getStringSerializer() {
        /* ... */
        return String.format("org.apache.kafka-%s.common.serialization.StringSerializer", name);
    }

should be modified to
    public String getStringSerializer() {
        /* ... */
        return String.format("org.apache.kafka%s.common.serialization.StringSerializer", name);
    }

It also applies to getStringDeserializer() because they will use the relocated class path to load classes of different Kafka versions.

Hi @eolivelli , could you apply my comments to fix the broken tests?

sure @BewareMyPower
doing it now

thank you !


Add Travis CI support

Let's see if I can get this on the first try!

It didn't work on the first try :c


Remove recommendations from AMO

Recommendations are show on about:addons:
https://www.dropbox.com/s/mm547te9vs1pmk9/Screenshot 2016-01-04 13.12.50.png?dl=0
The actual recommendations aren't great and they don't get a huge amount of traffic. I don't think the feature is worth the effort. It would be nice if we could be certain how much traffic before making that call.
This might be a big bug but we should remove:

the Recommended pane from about:addons
the cron job that slows everything down
everything in between

Is this specifically about recommendations on about:addons, or in general? Featuring add-ons has historically given add-ons a noticeable boost in downloads and usage, but maybe that's more due to the blog posts.

Recommended add-ons seem to be different from Featured add-ons, which are chosen by the community board and get the boost in downloads. Methinks the boost comes from being on the homepage of AMO, blog post, social media promos, and Firefox & You newsletter.

Recommendations, not features.

Verified as fixed : http://screencast.com/t/ajFdJHoI


Update base.h unit to unsigned int

Changed uint to unsigned int to address error when building from source.

Hi @EnragedAntelope thank you for the contribution - some next steps

Can you merge or rebase to main to avoid the regression test failure
Can you please sign the CLA agreement otherwise we won't be able to merge this
Can you make it clearer what kind of device, operating system, gpu etc.. you're running such that you're getting from source installation errors?

@msaroufim See #951, likely Windows/MSVC. Very similar issue to the changes made in FP6 which used some non-standard types like 'u_int8_t`.

Hi @EnragedAntelope thank you for the contribution - some next steps
1. Can you merge or rebase to main to avoid the regression test failure

2. Can you please sign the CLA agreement otherwise we won't be able to merge this

3. Can you make it clearer what kind of device, operating system, gpu etc.. you're running such that you're getting from source installation errors?

Hi,
Happy to help but sorry I won't sign that agreement, it requires actual name etc. I haven't been asked that for open source github before.
If there's a way to proceed without that I'm happy to try again with latest base.
For 3, I am running Windows 11 on a PC with 4090 GPU. Python 3.11.9.

@EnragedAntelope you can read more about CLAs here https://github.com/github/github-ospo/blob/main/policies/contributor-license-agreements.md but the intent is to say you give us the permission to use your contribution. It's quite common for projects managed by larger companies. Unfortunately I wouldn't even be able to copy paste your contribution since it's yours

Thanks for the additional info. I signed the agreement and updated my fork. Should be good to go.


[resotocore][feat] Remove deprecated cmd line args

Description

remove cmd line args that are available via configuration
api config now supports web-hosts, web-port and web-path
remove deprecated db migrations
json array is able to coerce non array values
web api can be mounted on a sub-path

To-Dos

[x] Add test coverage for new or updated functionality
[x] Lint and test with tox

Issues Fixed

Fixes #XXXX

Code of Conduct
By submitting this pull request, I agree to follow the code of conduct.

Codecov Report

Merging #753 (a065a7a) into main (d0e9f15) will increase coverage by 0.04%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
+ Coverage   89.71%   89.76%   +0.04%
==========================================
  Files          69       69
  Lines        9761     9749      -12
==========================================
- Hits         8757     8751       -6
+ Misses       1004      998       -6

Flag
Coverage Δ

resotocore
89.76% <88.23%> (+0.04%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

resotocore/resotocore/__main__.py
87.59% <ø> (ø)

resotocore/resotocore/model/model.py
93.51% <60.00%> (-0.26%)
:arrow_down:

resotocore/resotocore/core_config.py
96.47% <78.94%> (-1.96%)
:arrow_down:

...esotocore/resotocore/config/core_config_handler.py
76.54% <100.00%> (ø)

resotocore/resotocore/db/graphdb.py
93.94% <100.00%> (+0.73%)
:arrow_up:

resotocore/resotocore/dependencies.py
85.95% <100.00%> (+1.89%)
:arrow_up:

resotocore/resotocore/message_bus.py
97.39% <100.00%> (ø)

...otocore/task/start_workflow_on_first_subscriber.py
96.87% <100.00%> (ø)

resotocore/resotocore/task/task_handler.py
85.67% <100.00%> (-0.12%)
:arrow_down:

resotocore/resotocore/web/api.py
66.77% <100.00%> (+0.20%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0e9f15...a065a7a. Read the comment docs.