Enhance OpenVPN Experience with Seamless MFA During Network Transitions

Goal
The primary objective is to refine the user experience with OpenVPN, particularly in the context of Multi-Factor Authentication (MFA). We aim to establish a more seamless transition that doesn't necessitate re-authentication when there's a change in the network environment. This enhancement is especially critical in mobile scenarios where network switches are frequent and inevitable.
Problem Statement
Currently, users face a significant challenge when their network environment changes while connected to an OpenVPN server with MFA enabled. For instance, consider a scenario where a user is connected to the VPN over a home WiFi network. As soon as the user leaves the vicinity of their WiFi and their device switches to a mobile data, the VPN connection requires re-authentication. This process does not just introduce inconvenience but often fails, leading to disruptions in connectivity and secure access.
Use Case
This issue predominantly affects mobile users who frequently transition between different networks (e.g., from WiFi to mobile data or between different WiFi networks). The need to manually re-authenticate each time not only hampers productivity but also affects the overall user experience negatively.
Proposed Solution
Using session token mechanism. When a user successfully authenticates with MFA, we generate a session token (a unique, temporary identifier) that is valid for a specific duration (would be nice to set it in the configuration). This token is then used to validate subsequent connections without requiring MFA again, as long as the token is still valid.
Potential Benefits
Implementing this feature could significantly enhance the user experience by providing a more stable and uninterrupted connection, reducing the need for technical support related to connection issues, and ensuring secure access remains consistent regardless of the network environment.

Hi @Niroda
OpenVPN-UI do supports MFA with Authenticator app, out of the box, you could try it.

Hi @d3vilh
I'm aware of that! Have you read the problem statement in the feature request? The issue arises when a mobile device switches from Wi-Fi to mobile data; the VPN server requires re-authentication, necessitating a new MFA code, which results in the connection being lost. I've managed to tweak it with some scripts to track and manage sessions, but it would be great if you could implement this solution in the main repo/image and offer it as an optional feature. This way, if someone wants it, they can enable it on demand. I'm pretty sure many mobile users would greatly appreciate this feature.

It is fine, I just read first sentence got it was kind of AI generated and ignore the rest, (sorry, too much AI spam happening around me :) )
Yes, your suggestion is very valid. I'll check if OSS OpenVPN Server version supports this functionality. If it is - will be in one of the next releases.

No problem. Everything can be done in /opt/app/bin/oath.sh.
First, we need to modify the certificate creation form:

An optional checkbox to indicate whether this certificate's session shall be tracked.
Specify how long the session should be tracked in seconds/minutes/hours/days.

Then, in /opt/app/bin/oath.sh, upon the first successful MFA authentication, we can create a session and track it for the time provided in the second option.
Once the user disconnects and reconnects, in the same file /opt/app/bin/oath.sh, before requiring the user for authentication and MFA code, we can check whether a session is present and valid. If so, just terminate the script with exit 0 to indicate the user is authenticated.

Would you like to push new changes in dev branch, or share the link patched oath.sh?
It will speedup all the development.
I did a test with 2FA functionality while driving today between provinces it is indeed may be annoying to re-auth if IP is changing dynamically.


Update schema from 5.0 to 5.1

We never supported v5.0, see? It's all v5.1 around here.
Pivotal story

Looks like all the test-resources/xml/v5-*.xml files still say "5.0".

Looks like all the test-resources/xml/v5-*.xml files still say "5.0".

I see that - it's not a quality we test.

LGTM!


ActivityPub => ATProto: handle usernames with _ and ~ chars

This is a fun one. First user with an underscore in their username signed up just now, https://me.dm/@punkscience_ns , @punkscience. (Hi Darryl! Sorry for the trouble!)
We translated the fediverse address<EMAIL_ADDRESS>to the bridged Bluesky handle punkscience_ns.me.dm.ap.brid.gy and created the DNS TXT record _atproto.punkscience_ns.me.dm.ap.brid.gy, which is serving fine. PLC directory has it in https://web.plc.directory/did/did:plc:di27vbfe6wutukod4g36kovz.
However, ATProto handles don't allow the underscore character. 🤦 (Also see https://github.com/swicg/activitypub-webfinger/issues/9) So, I guess we need to translate underscores to maybe dashes, and hope we don't hit a collision between eg x_y and x-y on the same instance.

Also need to handle tildes (~). Probably even less common, but theoretically possible.
Related: #744, #830

Got another one: https://mastodon.social/users/_dmh , @dmhowcroft. (Sorry Dave!)

Thanks! Looking forward to seeing it resolved :)

And https://darmstadt.social/users/ceol_agus_ol, did:plc:xry5u23qftlcaysecxbhuv4m.

https://mastodon.social/users/carb_uncle, did:plc:oegzpinpvkhf5sv5oj4f7mq7

Implemented and deployed. Next, fixing these users ^ manually.

Woo, first profile I've seen this work on! https://wetdry.world/@mary_ext => https://bsky.app/profile/mary-ext.wetdry.world.ap.brid.gy

What happens now if there's a collision? Is the second user not bridged or do they just not get a friendly handle?

They're not bridged.
I honestly couldn't predict if we hit that collision in a week, or a quarter, or five years, or never. I suspect closer to five years. We'll cross that bridge when we come to it.

Need to do a bit more here: ATProto handles can't begin or end with -. https://mastodon.gamedev.place/users/DenisProdan and https://warpday.net/users/98ftq556kb<EMAIL_ADDRESS>failed this.

Is my underscore-initial username bridged to ATP now?

@dmhowcroft sadly no, sorry, and honestly I don't yet have a plan to support usernames that begin or end with underscores or dashes.

OK, I think we're set here. _ and ~ are converted to - except if they're at the beginning or end, where they're not supported, and that's now documented. I've filed #1005 for that.


Introduce the S3 Prefix to represent separate upload folders

S3 prefixes will map to different users of the system.
I have fixed this now because it was impacting my testing. Codeship build where deleting files I was uploading locally.
To use the prefix, you should add: s3_prefix = vasyl/ is aws-test-secrets

The multipart uploads are also being looked up by using the prefix.


error PHP OTHER_ERROR: SQLSTATE[42S02]

Server is tired when using [ Topics with your posts ] link
2023-11-21 13:16:34 error PHP OTHER_ERROR: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'abolus_forkbb3.forum_topics' doesn't exist in .../app/Core/DB.php:[398]

I don’t see such an error on your forum for my account (Maybe I don't have enough topics?). It's not in the forum logs either.
If you are moving the database to another server, then look at this question and answers: https://stackoverflow.com/questions/7759170/mysql-table-doesnt-exist-but-it-does-or-it-should

Then show here the full log (with trace) of this error.

Fixed it. Thanks for the report!

Fix number 2


Refactor js

Corrected Boolean query in line 5 which by itself returns truthy or falsy hence eliminating the need for explicit values.

I have removed the name attribute from the input element since it is not being POST-ed. I have also corrected the accidentally modified file.

I have removed the name attribute from the input element since it is not being POST-ed. I have also corrected the accidentally modified file.

this is mostly redundant with other PRs merged. closing it up for now. Thanks!


[Map] DM-Aim

Hash: 352db2f37d8e1973b7dafcdf2b9c3413b836b80b
Current name: DM-Aim
According to the readme, Walm is another name for Markus "MarkusW" Wallmuller

Updated


Fix breaking change from algebra/poly

Introduced by https://github.com/arkworks-rs/algebra/pull/843

@Cesar199999 @Antonio95 wait shouldn't we wait for the arkworks PR to get merged?

Who knows when that will happen, right? This is a change we want to use in Aurora and I think dependencies could be annoying if we leave this in a non-main branch (perhaps that would involve changing the algebra dependency in our HCS repos that depend on HCS/algebra which we use in Aurora? Or does that get handled automatically if you only patch Aurora; what I mean is: A depends on B and C, and B depends on C; do A and B have to point to the same branch of C?).
If you prefer us to keep the branch here and point to it, and restore main to its state before the merge, just let us know

I agree @Antonio95, this is the easiest way to deal with the dependencies, but we undo it if you prefer.
Also, even if we rollback the changes from algebra, this won't be a problem as we are just writing the reference explicitly.

Oh yep, maybe that's an important point which wasn't clear: the tiny change we added here works with both the new (to-be-merged) and the old (current main) algebra; whereas the previous code only worked with the old algebra.

what I mean is: we don't even depend on our fork of algebra where this is supposed to be introduced?

Oh yep, maybe that's an important point which wasn't clear: the tiny change we added here works with both the new (to-be-merged) and the old (current main) algebra; whereas the previous code only worked with the old algebra.

Ah, I see, so this change is forward compatible? then all good

Yes, this change is everything-compatible :)


Issue autocomplete breaks after unexisting issue number

Extension version: v0.54.0
VSCode Version: 1.73.0
OS: MacOS Ventura

Steps to Reproduce:

Type # and then an unexisting issue number in Commit Message field.
Delete the issue number (but not #) using Backspace.
Type an existing issue number.
Autocomplete is broken now.

https://user-images.githubusercontent.com/511242/200513854-3713d922-c156-464e-848d-d189e7e9d757.mov

This is how VS Code suggest works, even for other suggestions and suggest locations.

@jrieken in case I'm missing something.

even for other suggestions and suggest locations
@alexr00 I've checked HTML tag autocomplete. It works as expected and doesn't break after invalid tag name. Did I miss something?

https://user-images.githubusercontent.com/511242/204447097-303d4df0-7194-46c6-84d9-ebc448bb92b7.mov

@alexr00 thank you for detailed explanation. Should I create an issue in VSCode instead?

I would wait to hear the response to https://github.com/microsoft/vscode-pull-request-github/issues/4166#issuecomment-1329367405 first.

Yes - automatically triggered suggestions (e.g those that just show up while typing) hide when not having a match. @ris58h you can counter this by manually suggesting completions via ctrl+space in that mode the UI won't hide when typing something that doesn't match


Various improvements and cleanups

Clarified pointer usage in some spots (removed a bunch of pointers). I've seen a very slight speed increase in things that make frequent use of ionic (dereferencing is slow), but I haven't benchmarked it to figure out exactly how much.
Added functions for storing an IonClient in a context
Added a context field to the IonClient itself, mostly to facilitate request tracing
Deprecates the New and NewWithClient methods in favor of NewWithOptions. The two deprecated methods are still available to be used, but things should switch to the new one to facilitate less painful upgrades in the future.

This is a breaking change to ionic's API, so when services update, they will need to update their usage of Ionic.

Holding until discussion on Tuesday (2022/01/25)


Tool names in machine-tool-def.json

I will add to this issue for now its just a place holder while I am thinking of it. I was trying to enter new names and dimensions for my metric cutters and MonkeyCAM was hating on the names I was using, I will try again and add detail to this issue......
Its probably finger trouble but I thought my editing skills were better than that, do I need to use "vi" editor I think I can still remember how.......haha!!!
cheers
Rich
Tools
The tools section has an entry for each tool which will be used by the generated G-Code programs. Each tool is given an id which is used to reference the tool from other parameters, and is called the tool number in the documentation for those parameters.
"tools":
[
{
"id": 1,
"name": "Quarter Inch Upcut Spiral",
"diameter": 0.247,
"G-code #": 1
},
{
"id": 2,
"name": "Quarter Inch Straight",
"diameter": 0.250,
"G-code #": 1
},
]

@splitn2 Hey man, do you have any more detail on this. I know it's old, but if there's something I can do to make this easier lemme know.

must have been finger trouble @mikemag , last time I edited machine defs it worked fine....... , issue can be closed..... cheers


Comparison is flaky

I have got a test running using cypress-image-snapshot
I see a lot of flakiness around . Currently my cypress tests are set to retry:1 on failures which means it will run twice if first fails
On first run it caught it correctly

On second run the test passes , i have ben trying to reolve it from past few days can't get thorugh
Here is my setup :
addMatchImageSnapshotCommand({
    e2eSpecDir: 'cypress/e2e',
    comparisonMethod: 'pixelmatch',
    failureThreshold: 0.01,
    failureThresholdType: 'percent',
    customSnapshotsDir: 'snapshots',
    //config options for Cypress.screenshot()
    capture: 'fullPage',
    // blackout: ['[data-gui="trustpilot-rating"]'],
    disableTimersAndAnimations: true,
    allowSizeMismatch: true
})

blackout was initially there to generate the image and then i want it to purposely fail but there seems flakiness

I have ran my tests on local vs docker , keep having these rendering differences
Is there any way to tackle this?

How do you mean local vs Docker? Is that snapshot taken outside of Docker and compared against one taken inside Docker?

I have the run the test locally on my machine using cypress runner & then run the cypress test via docker as well. I can see a difference in the images being generated

I'm going to close this as I don't think this a problem with this plugin, but feel free to continue any discussion here


Master branch has unreleased changes

Please, publish the new release to NPM registry.
I assume that something did not work out 8 hours ago with the last commit that added semantic release. If it proves to be a time consuming change, maybe let's do that in a simpler way this week.
I'm sorry if I remind here the obvious things but it will be easier to track the progress on this.
Many thanks in advance!

I was referring to this specific build:
https://travis-ci.org/benbria/bunyan-debug-stream/jobs/407329371
Looks like it does not have push access to the git.

Sorry; I had to run last night - my daughter is at parkour camp this week, and I had to pick her up on time, because they charge like $15 per 10 minutes I'm late.  :P  So I pushed to Travis and crossed my fingers.  Just sorted it all out.  Everything should be in 1.1.0 now.

You are :crown: , thank you so much!

No problem.  Sorry I didn't fix it last night.  :P

@jwalton, no need to apologize! I'm already enormously happy and grateful that you gave me an opportunity to switch the bunyan-debug-stream version in package.json from my fork to your mainstream one. Otherwise, I would have been sitting on Plan B, decaffeinating the lib and inserting into the existing codebase, plus making sure all the legal acknowledgments are in place - not fun, I'd say.
You saved me a good couple of hours for sure!
https://github.com/wix/detox/blob/noomorph/powerlogs/detox/package.json#L42

Haha.  I started decaffeinating this just a couple of weeks ago, actually, but then decided to switch to Winston.  ;)

Good for you :+1:
I also tried out Winston, but my experience was far from satisfying. The Bunyan's killer feature of easy .child({ ... }) logger metadata creation was missing, and to my great displeasure, I wasn't so lucky to find or implement a quick workaround.
Did you hit that issue too? Or you don't create child loggers that much?


useFetch data is null in some case depending on the query param type.

Environment
Nuxt project info:                                                                                12:16:19

Operating System: Windows_NT
Node Version:     v18.12.1
Nuxt Version:     3.8.1
CLI Version:      3.9.1
Nitro Version:    2.7.2
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools, nitro
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-k5ugr3?file=pages%2Fabout.vue
Describe the bug
two ways to give a param to useFetch

give a pure string
give a computed vary

two way to go into "about" page

click about link in home
in about page and refresh to reload

when get about page from other page by route, both useFetch get correct data
when refresh the about page, a pure string param will get a real data immidiate, but a ref make it null.
both useFetch will get data finally if just render in template or shown somewhere, But if the code below rely on the data to make a special logic, it need to always need a watch "pending" to run the logic later, it's a bug or a design?
this will get null data in client console
const { data } = await useFetch('/api/user', { query: { param1: id } });

this get the correct data
const { data } = await useFetch('/api/user', { query: { param1: id.value } });

// null or [1,2,3]
// the log in ssr server console is always right.
console.log('data', data.value);
Additional context
No, just run the reproduction
Logs
server logs is correct. client logs get null

reproduction updated. adding request headers will lead this too.


Bug: resolve-parent

Description
resolve-parent does not get passed onto the container (base?) runners. This results in commands using the resolve-parent flag in the descriptor to mount the full file path and fail.
Steps to Reproduce

Use graphrunner
Run any command with resolve-parent (e.g. eddy)

Expected Results
Should pass resolve-parent flag to parent
Actual Results
Command errors out with a failing to mount error with singularity (and presumably Docker) runners.
Additional Notes
No response

fixed in 425f0f81d78782e6ae2f41e2db05ab6f23b3d11c


Code | Alphabetic Pattern 185

@aryashah2k can i work on this?

@aryashah2k my all earlier PR's will it also be considered under SWoC -21? (asking because there were no tags that time)

I will try adding SWOC Labels there if SWOC Team allows me, I hope you saw  the Discord message addressing the same:

If the PR's in the first week cannot be counted then dont worry, I will consider it for the PatternHouse Swag Pack since that is something I have control over.
Actually the thing is that the instructions to project admins were not clear and even you participants was not clear so so you guys started creating PRs and I started merging them. Then when the meeting for admins was held, they said not to merge PRs in the first week till they finalize their projects. So if I can find some way to add labels to existing PRs I will try my best to do that.

@aryashah2k and that means I should create a PR now if I want it to considered under SWOC ?
thanks for the help. :)

I would suggest you stay active in your swoc channel for participants or ask any friends or someone who is also a participant and if they have any information, we have a meeting tomorrow for project admins and many things should be cleared by then.
Also as of now the SWOC Team has told you can start merging PRs


Integration Test - Release - 2018/08/08 15:03:16

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@PRMergerTest1 : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.


install-command command is only used for installing the PR but not base revision

Is there any reason why the base installation proceeds via a hardcoded pip install . -U instead of via the install-command input like the PR revision installation?

I actually no longer need this now that I found a different way to fix the issue I mention at the end of #5 - still curious if there is a reason why the commands should differ, though.

Thanks for reaching out! Nice to see that this is actually used by someone other than me :D
No, there's no reason, I guess I just missed it. thanks for pointing it out and even sending a PR!


Document that project wiki delete is not supported

Project wikis cannot be deleted. We need to add a note to state that in the docs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c227edda-7233-5b74-0bfb-1e8faa440794
Version Independent ID: 48f498df-c32a-d994-baa3-d0250125ee5d
Content: Manage wikis in Azure DevOps - Azure DevOps
Content Source: docs/project/wiki/manage-wikis.md
Product: devops
Technology: devops-collab
GitHub Login: @chcomley
Microsoft Alias: chcomley

Thanks @edglas, I've created a user story to address this!

yah,  ran into the same dead end catastrophe after a few long days of writing a Powershell solution for managing automated doc entry.  I am always open to an alternate solution if it exist if we can actually do this and missing a simple switch, etc.

@MellyDawgKY -- thank you for your followup.  Please consider these resources:

Azure DevOps Services
Azure DevOps on Stack Overflow


Support display operator metrics

Signed-off-by: yeya24<EMAIL_ADDRESS>Fixes https://issues.redhat.com/browse/OSD-3954
Usage
osd-utils-cli metrics -h
display metrics of aws-account-operator

Options:
      --account-namespace='aws-account-operator': The namespace to keep AWS accounts. The default value is
aws-account-operator.
      --route='aws-account-operator': The route created for aws-account-operator
      --sa='aws-account-operator': The service account name for aws-account-operator

Usage:
  osd-utils-cli metrics [flags] [options]

Use "osd-utils-cli options" for a list of global command-line options (applies to all commands).

@rogbas @clcollins please give it a try in hive-stage and comment

Add another flag -m to optionally specify the aws-account-operator metrics URL, used in local debug case.

This one is rebased. Please do a test, thank you! @clcollins
The basic usage is osd-utils-cli metrics if you are at openshift environment

/hold
@yeya24 Can you add you v3/v4 fix to this PR and squash, and then we can test and merge it.


FFMPEG In-built Support

Please describe the changes this PR makes and why it should be merged:
Added in-built support for FFMPEG without disturbing createAudioResource function.
Created a whole new function in audio - resource file. [ createFFMPEGResource() ]
Status and versioning classification:
Resolves #143 , #117 , #141 , #124.

🤔 imo options like reconnect, reconnect_time, seek should be handled by the users since this api provides arguments option? Users should have full control over this 😕

I know about this.
Options like reconnect, reconnect_time, seek are for those users who particularly don't know much about setting up FFMPEG args.
It will be easier for people who have just shifted from discord voice old module to find seek option. Moreover, FFMPEG has some issues with connection drops. So I added reconnect args only to help to fix that issue.
arguments allow users to have full control what they need to pass and what not to pass. [ without options like reconnect, reconnect_time, seek ]

Thanks, I got my reply for re-review.

Let's see how much time will it take to merge

can you merge this? it would be very helpful

can you merge this? it would be very helpful

I am going to make another pull request soon. So wait till then.


Wordpress implementation gives error .button is not a function

I've been trying to switch to this from version 1 which has been working great for me, but on upgrading to this version I get an error "Uncaught TypeError: $(...).addClass(...).attr(...).attr(...).button is not a function" That suggests to me it's a jquery ui issue but as far as I can tell jquery and jquery ui are both loading correctly

This happens because WordPress is loading Jquery-ui partially.
If you are in the backend you should have already the core library, but if you are in frontend you should load this:
wp_enqueue_script('jquery-ui-core');

But this is not enough, in this case mutliselect wants also "button", then you add this:
wp_enqueue_script('jquery-ui-button');

Now multiselect should work.


Replace Phloem's Blob with Collenchyma's SharedTensor

Cuticula still depends on Phloem - but Phloem is deprecated in favor of Collenchyma's SharedTensor. This blocks #18

Resolved by f01ea26a3b742735c2b3bdb03ebc82432f0220f3


Fixed memory leak in computed property xmlString

I found a memory leak in the computed property xmlString:

This pull request resolves this issue ;)

Hey thanks, it's merged now.


Fix: Disabled state button transition time

SUMMARY
Transition time was off between the SVG icon and the Run button. Used css transition delays to make it much smoother.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/48933336/107261063-d7f15000-6a0c-11eb-9825-0ce6afe41a7a.mov
TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:https://github.com/apache/superset/issues/12979- [ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

:) Thank you, though that was Elizabeth's suggestion!
On Mon, Feb 8, 2021 at 1:13 PM Beto Dealmeida<EMAIL_ADDRESS>wrote:

@betodealmeida approved this pull request.
https://camo.githubusercontent.com/ccb7068a31492e3e9e8ec7ee0dc2d17a634b8636ae07f7f45412135dbd4b39e0/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f4a5664463134435151483767732f736f757263652e676966
In superset-frontend/src/SqlLab/components/RunQueryActionButton.tsx
https://github.com/apache/superset/pull/13008#discussion_r572260895:

@@ -91,25 +91,32 @@ const RunQueryActionButton = ({
? (DropdownButton as React.FC)
: Button;

const isDisabled = !sql.trim();

Nice, this is way more readable now, and the intent is clear!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/superset/pull/13008#pullrequestreview-585782852,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALVKTWA7NZYY6NG2QKB3P7TS6AST5ANCNFSM4XJOAE2Q
.

--
Arash Afghahi

@AAfghahi we just need a rebase on this before we can merge it.

@AAfghahi we just need a rebase on this before we can merge it.

Ok, will do first thing in the morning.

@AAfghahi we just need a rebase on this before we can merge it.

I think it should be good now?

Tested manually and it looks great. Thanks @AAfghahi!
🏷 ready-to-merge


start_vent_collector includes metadata of desired dev_hash

This PR resolves #258
Basically, the payload posted with start_vent_collector now includes metadata for the addressed dev_hash.

I've just see that the tests are not passing, I'm on that!

Codecov Report

Merging #268 into master will decrease coverage by 0.6%.
The diff coverage is 20%.

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage   59.79%   59.19%   -0.61%
==========================================
  Files          22       22
  Lines         985      990       +5
  Branches       88       88
==========================================
- Hits          589      586       -3
- Misses        388      396       +8
  Partials        8        8

Impacted Files
Coverage Δ

poseidon/poseidonMonitor/poseidonMonitor.py
17.94% <20%> (-1.71%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe4cb8...4f17a5f. Read the comment docs.

Thanks!


Executable isn't returning failure code when a failure occurs

I'm using NuKeeper as a task within Azure DevOps. When the executable never gives a failure return code the task doesn't fail and I never know when my automated process needs attention.

Just to document some failure modes, here's a failure when restoring packages that returns a 0 exit code:
Updating 'Microsoft.CodeAnalysis.VersionCheckAnalyzer' from 2.9.4 to 2.9.8 in 1 projects
Nuget restore on d:\a\1\s\Source\NODEJSPROJECT packages.config
Updates failed NuKeeperException : Command C:\hostedtoolcache\windows\nukeeper\0.26.0\x64\NuGet.exe failed with exit code: 1

MSBuild auto-detection: using msbuild version '<IP_ADDRESS>4' from 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\bin'.

Unable to locate project file for 'd:\a\1\s\Source\NODEJSPROJECT\packages.config'.

Attempted 3 updates and did 0
##[section]Finishing: NuKeeper

For collaboration commands (repo, global, organization), this should now be fixed by https://github.com/NuKeeperDotNet/NuKeeper/pull/1058


cpp: stringizers

Examples on using stringizers so assertion messages in C++ tests are more meaningful.

To save you some clicking, here's the deploy preview of the page: https://deploy-preview-138--reverent-edison-2864ea.netlify.app/languages/cpp/igloo/stringizers/
Would appreciate any review.
Thanks!


feat(router): add experimental support for markdown as routes

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/analogjs/analog/blob/main/CONTRIBUTING.md#-commit-message-guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Which package are you modifying?

[ ] vite-angular-plugin
[ ] astro-angular
[ ] create-analog
[x] router

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Markdown files can be used directly as routes
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Hi @brandonroberts, hope you don't mind me jumping in on this Pr. After some work I've done at Scully I've seen a lot off people use markdown files for blogs. Most off the blogs used a peace of code. I think that something like Prismjs would have value for the support.
What do you think off this idea?
P.s. no idea how analog works atm so can't say if this is easy or not to add. Keep up the work going to experiment with your project.

Hey @Jefiozie thanks for jumping in. I agree and I think it's a good idea to add support for that. I was thinking of separating the content rendering from the Markdown component into a service that has support for Prism, and would also allow the service to be overridden.
Thoughts?

Yes, I think the rendering "logic" should be separated from the cmp logic.
I would even say that any file has his own handler based on the extension. The component would only render the ui based on the injected render service that works for that type of file handler.
Maybe this approach is for now a step too far (and I don't know how the internals work at analogjs).
For now, a service that would generate the content with a simple configuration for settings (to enable highlighting via primsjs)  will work and can be overriden if people have the need to do that.
Happy to review it when you have a first setup if you like? Then I can try out analogjs 🙃😎

Sure, I like where that could head. I'll get some initial support in for Prism w/markdown and then we can go from there.
Right now the logic is pretty straightforward. If it's a markdown file extension, I use the markdown component as the route component and it tenders from there.
The file glob inclines the content of the markdown but getting lazy loading working with it is also on the list. Lazy loading the content works client side but not with SSR at the moment.

Hi @brandonroberts, I've try to give it a spin but I'm having some issues running the repo. IIs tis something that is expected as the PR is not "ready" yet?

Based on the code, I think this is a great setup!


refactor: manage EntryForm with react-hook-form

Difficult to know, without tests if, whether this actually breaks everything.

Added <form> element
Abstracted EntryForm into shared component for AddPage and EditPage
Added react-hook-form dependency

This looks so much clearer, nice one. A couple of bugs:

If you edit a toilet (https://gbptm-git-form.neontribe.now.sh/loos/c36ddb71db1202ad5cf28c47/edit) and then move the map, the lat and lng fields change values correctly but the submit button does not become enabled as it should

Trying to add a toilet results in some GraphQl errors:

I only added a title to the toilet so it may be a problem with the default values

@stphnnnn (2) other than the $location error (the first one listed there, which I've now resolved), all these errors seem to also occur on the base branch.


Ignore mypy erorrs and skip tests that don't work on MacOS

Description
This PR makes two changes:

os.sched_(get/set)affinity is not supported on MacOS. This PR ignores mypy errors from code blocks that touch on affinity that are not used in MacOS.
Skip tests that touch on affinity that are not expected to work on MacOS.

Type of change
Choose which options apply, and delete the ones which do not apply.

Bug fix
Code maintenance/cleanup

this is breaking in CI

@yadudoc i just pushed a possible fix for the most recent mypy error on Linux - I haven't tested if this works on OS X.

@benclifford This works on OSX. Let's get this merged?

I'm a bit uncomfortable with this test style of "we know this test fails so we ignore that failure" and I've been pushing a bit to make developers explicitly acknowledge that some tests are not being disabled... there is no "skip" in CI, just pass or fail, and this style forces this test to "pass" in the sense of not failing, on platforms without sched_getaffinity.
@pytest.mark.skipif('sched_getaffinity' not in dir(os), reason='System does not support sched_setaffinity')


Text box improvements

This change makes TextBox borders highlighted when you focus them for more responsiveness (except for the help TextBox):

It also fixes a bug where the cursor is not visible.

That's a very nice addition! Will merge it once I hear from you about the outlined change

It looks like the picture above where there is no cursor, but I can send a video later if you'd like.

This is what it looks like on my end without the padding (windows 11):
https://github.com/user-attachments/assets/85b819fa-e088-40d0-b7c8-17ccdb8dee58
I think this might have something to do with display scaling because when I change my display scale, the cursor is visible.


Implementation of bubble sort using recursion in c++

I like to add the code for bubble sort using recursion in c++.
please assign this issue to me.
/assign

/assign


add SHIP, BUOY and AMDAR topics

I
U
A

Single level aircraft reports (automatic)
4
0
AMDAR

I
U
O

Profiles of aircraft observations in ascending/descending
2
20
AMDAR

I
O
B

Buoy observations
1
25
BUOY

I
S
C
46-59
Climatic observations from marine stations
1
20
CLIMAT SHIP

I
S
S
01-19
Synoptic observations from marine stations
1
0
SHIP

I
U
J
40-59
Upper wind from marine stations (entire sounding)
2
2
PILOT SHIP (Parts A, B, C and D)

I
U
K
40-59
Radio soundings from marine stations (up to 100hPa)
2
5
TEMP SHIP (Parts A, B)

I
U
S
40-59
Radiosondes/pibal reports from marine stations (entire sounding)
2
5
TEMP SHIP (Parts A, B, C and D)

I
U
U
46-59
Monthly statistics of data from marine stations
2
26
SHIP

I
U
W
40-59
Upper wind from marine stations (up to 100 hPa)
2
2
PILOT SHIP (parts A, B)

@tomkralidis

I am not a data expert so I am not sure what is the difference between IUA and IUO AMDAR, but I have learned that when it comes to upperair soundings, the differentiation between "entire sounding" and "up to 100 hPa" is largely unnecessary. Typically a balloon is lunched twice (few times) per day, the size of the resulting observation is in order of 10kB so sending it to two different topics would be useless - same as was assigning different TTAA heading part for it.

One question, should we be perpetuating the keywords from the old alphanumeric codes such as SHIP, TEMP, SYNOP, BUOY?
Data from some of the moored buoys is more similar to the data from the ships in terms of parameters reported.

Note: as part of ocean data publication activities (with Scripps), we are experimenting with .../weather/experimental/surface-based-observations/buoy.

closing because these are addressed in issue #147


Java doc missing

Where can I find the Java Documentation about this project ?

It is currently not available but will be added at a later date

Javadoc has been added and is viewable here: http://martinwithaar.github.io/Encryptor4j/

Thanks


spring oauth2.0 login page unauthorized

spring cloud + security oauth 2.0, login-page url is unauthorized,i needn't the url  that is authorized. When the login is successful， get token, and authorized successfully.

@godpit please provide more information. What is your configuration, what version of spring cloud are you using?
Can you provide a complete, minimal, verifiable sample that reproduces the problem?

spring cloud Finchley.M7,

class WebSecurityConfig extends WebSecurityConfigurerAdapter,

Please don't past screenshots.

Can you provide a complete, minimal, verifiable sample that reproduces the problem?

A little difficult to provide，Please tell me if I can enter the login page without authorization.

i enter the url of 'http://localhost:9060/oauth/authorize', it redirect to http://localhost:9060/login.but it show me  unauthorized

i got it, by adding the matcher of url  '/login'.
@Configuration
@EnableResourceServer
public class ResourceServerConfig extends ResourceServerConfigurerAdapter {
@Override
public void configure(HttpSecurity http) throws Exception {
    http.csrf().disable()
            .exceptionHandling()
            .authenticationEntryPoint((request, response, authException) ->
                    response.sendError(HttpServletResponse.SC_UNAUTHORIZED)
            ).and()
            .authorizeRequests().antMatchers("/login").permitAll()
            .anyRequest().authenticated()
            .and()
            .httpBasic();
}

}

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Missing information as location of the settings button as the reference to the request limits

Hi there,
I was looking around to see what the limits are for using flow but for as far I have seen in the community people are giving different values, so I don't know what limits there are with all the changes going on lately and such.
So that's why I came to this page and since there was a section explaining this I thought that it would be usefull, but it only says for free plans to click on a settings button as shown on the picture but not which settings button that actually is and where to find it. Also, the picture doesn't explain anything about where or on what page you can find this button.
Because is this the settings button from power automate because it isn't showing anything related, or is it from powerapps homepage or from within a powerapp or is this from dynamics? Honestly I have no clue where I am supposed to look. I would add a caption or something like that to this image so that you can display more information about the location of the settings button.
I would also refer to the following page, so users can easily calculate those limits in case they don't know where to look:
https://docs.microsoft.com/en-us/power-platform/admin/api-request-limits-allocations#request-limits-based-on-user-licenses
This way it's easier to find the information that the user is looking for.
Thanks in advance!
Kind regards,
Billy Cottrell
PS: If I'm too aggressive or too "pushy" in my speech or so my apologies, I just think that documentation is really crucial for everyone, so when things are missing in my opinion I might get a bit harsh here and there, without me noticing it. So again my apologies!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1947fd4e-170f-6392-e309-5fd05082ffb8
Version Independent ID: 79ccd9e1-0998-bc4e-004c-ffbe57291196
Content: Billing and metering questions - Power Automate
Content Source: articles/billing-questions.md
Service: flow
GitHub Login: @MSFTMan
Microsoft Alias: deonhe

@BillyCottrell Thanks for sharing your thoughts. We will look into this issue and update the docs.

@BillyCottrell We've update the document to clarify that you must first sign into Power Automate before you see the settings button.


fix: Edge SDK Release brings improvements to documentation 5.1.0 Version

When next version of the typescript sdk change, we are introducing code examples and a new menu structure that requires a change in the docusaurus.config.js file.
Once the Typescript SDK version 6.0.0 which includes cross platform verification. this PR can be merged and we can proceed with the next Docs site deployment.

@elribonazo , this PR seems to be in conflict with the merged https://github.com/input-output-hk/atala-prism-wallet-sdk-ts/pull/213: could you check and decide which is more appropriate? If this PR is to be closed or not.


Can't open the application

Hello and thanks for continuing with the project!
I would like to report that I am trying a clean install with your version, however the setup opens and closes immediately, without opening the application GUI.
Could you verify?

did you manage to solve it?

Nope

Sorry all - It's missing some dependency.    @Zennehad see my post here.  https://github.com/dwiza3962/mff_auto/issues/10.    I'll see if I can figure out what the dependency issue is or it's complaining about.      Did you all use this before it was archived?

it's complaining about Traceback (most recent call last):
File "app_gui.py", line 5, in
from PyQt5 import QtCore, QtWidgets
ModuleNotFoundError: No module named 'PyQt5'
So it's pretty much stuck in python requirements hell when building the dependencies - working through it.

Guys I mucked with the requirements file because I wasn't aware that was generally bad.   I just pushed up a new release 0.15.0 let me know if this one actually runs.     I'll hope to have some more updates in a few days.

Its working like a charm! Thanks a lot!

Está funcionando como um encanto! Muito obrigado!

what version of nox are you using?


roc-obj searches for llvm-tools in wrong place

Using roc-obj in current 5.2.3 gives an error
~/$ /opt/rocm/bin/roc-obj -d test
error: could not find llvm-objdump in /opt/rocm-5.2.3/bin /opt/rocm-5.2.3/bin/../../llvm/bin or PATH

Inspection shows that the search path is wrong, it should be /opt/rocm-5.2.3/bin/../llvm/bin. Line 140
  for dir in "$BASE_DIR" "${HIP_CLANG_PATH:-"$BASE_DIR/../../llvm/bin"}"; do

of roc-obj script should be fixed to
  for dir in "$BASE_DIR" "${HIP_CLANG_PATH:-"$BASE_DIR/../llvm/bin"}"; do

After such a change it runs smoothly.

Hi @Melirius, please check latest ROCm6.0.2 to see if your issue still exists.  Please close the ticket if your issue has been fixed.  Thanks.

Closing the ticket as no response from @Melirius.  Please re-open the ticket if your issue still exists with latest ROCm 6.0.2.  Thanks.


Publish the library onto Maven Central

The library in its current form cannot be consumed by others as a TestNG listener.
It needs to be published on to Maven central so that others can consume it as well.
To integrate with Travis, you can refer to https://github.com/marketplace/travis-ci
You can follow the below steps to get Travis to publish into Maven Central
https://github.com/making/travis-ci-maven-deploy-skelton

@krmahadevan I have tried to follow the steps mentioned here. I was strucked at openssl commands:
I have tried installing ssl but no luck still I'm getting errors in my machine like :
~/.gnupg/pubring.gpg: No error
13932:error:02001003:system library:fopen:No such process:.\crypto\bio\bss_file.c:356:fopen('~/.gnupg/pubring.gpg','rb')
13932:error:20074002:BIO routines:FILE_CTRL:system lib:.\crypto\bio\bss_file.c:358:

Is there any other way to upload artificats to maven central repo.

@adiralashiva8 - Nope. I am not aware of alternatives. But you can google up. I am pretty sure there must be other ways as well. I found this way to be easy enough. You just need to first setup your gpg and then the rest should be straight forward.  I am not sure what OS you are on.

Mine is windows. I have gone through steps available in couple of websites. Since I dont have much knowledge I couldnot make it out.
FYI created issue in sonartype and it got approved - https://issues.sonatype.org/browse/OSSRH-46347

I have uploaded repo to nexus repo. You can find here - https://oss.sonatype.org/content/repositories/snapshots/com/github/adiralashiva8/testng-metrics/
I have gone through steps metioned in https://stackoverflow.com/questions/28846802/how-to-manually-publish-jar-to-maven-central - Answer By - Benoit Vanalderweireldt
Waiting for sync of repo. Thanks a lot @krmahadevan

Need to do some changes in report - holding upload artifact to central

Central sync is activated for com.github.adiralashiva8. For more info please refer ticket - https://issues.sonatype.org/browse/OSSRH-46347

Now artifact is in maven repository - https://mvnrepository.com/search?q=com.github.adiralashiva8


Fix sort for XCScheme.BuildableReference values

Related to #573.
This enforces a sort order for XCScheme.BuildableReference values. This should minimize unintended diff changes in the fixtures.

@brentleyjones I would like to merge this PR before #809.


fix(vega): add v4 mime type

The v4 mime type is what is currently supported out of the box by Jupyter, v3 requires an extension to be installed.
This PR adds the v4 mime type to the lists of supported mime types.  MIME"application/vnd.vega.v3+json" was left for backwards compatibility.  Vega recently released v5, so I expect this will need to be updated again in the near future.
I am concurrently putting in a PR for VegaLite.jl to update the mime type on that end too.

  Why don't they put the version number into the JSON content rather than continually updating the MIME type?

@stevengj Ironically, they do both... It looks like VegaLite also just released v3. So it probably makes sense to do the comprehension for both mime types vegalite from 2:3 and vega from 3:5.  I'll get that added.


[Bug] ValueError: Plane vertices are not coplanar. (box3d_overlap)

Prerequisite

[X] I have searched Issues and Discussions but cannot get the expected help.
[X] I have read the FAQ documentation but cannot get the expected help.
[X] The bug has not been fixed in the latest version (dev-1.x) or latest version (dev-1.0).

Task
I'm using the official example scripts/configs for the officially supported tasks/models/datasets.
Branch
main branch https://github.com/open-mmlab/mmdetection3d
Environment
System environment:                                                                                [1085/1460]
sys.platform: linux
Python: 3.8.17 (default, Jul  5 2023, 21:04:15) [GCC 11.2.0]
CUDA available: True
MUSA available: False
numpy_random_seed:<PHONE_NUMBER>
GPU 0,1: NVIDIA A100-SXM4-80GB
CUDA_HOME: /mnt/lustre/share/cuda-11.0
NVCC: Cuda compilation tools, release 11.0, V11.0.221
GCC: gcc (GCC) 5.4.0
PyTorch: 1.12.1
PyTorch compiling details: PyTorch built with:

GCC 9.3

C++ Version: 201402

Intel(R) oneAPI Math Kernel Library Version 2023.1-Product Build 20230303 for Intel(R) 64 architecture applications

Intel(R) MKL-DNN v2.6.0 (Git Hash 52b5f107dd9cf10910aaa19cb47f3abf9b349815)

OpenMP 201511 (a.k.a. OpenMP 4.5)

LAPACK is enabled (usually provided by MKL)

NNPACK is enabled

CPU capability usage: AVX2

CUDA Runtime 11.3

NVCC architecture flags: -gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_61,code=sm_61;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_80,code=
sm_80;-gencode;arch=compute_86,code=sm_86;-gencode;arch=compute_37,code=compute_37

CuDNN 8.3.2  (built against CUDA 11.5)

Magma 2.5.2

Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=11.3, CUDNN_VERSION=8.3.2, CXX_COMPILER=/opt/rh/devtoolset-9/root/usr/bin/c++, CXX_FLAGS= -fabi-version=11 -Wno-deprecated -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -fopenmp -DNDEBUG -DUSE_KINETO -DUSE_$
BGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -DEDGE_PROFILER_USE_KINETO -O2 -fPIC -Wno-narrowing -Wall -Wextra -Werror=return-type -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-unuse$
-parameter -Wno-unused-function -Wno-unused-result -Wno-unused-local-typedefs -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-psabi -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostic$
-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Werror=cast-function-type -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_VERSION=1.12.$
, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=OFF, USE_MPI=OFF, USE_NCCL=ON, USE_NNPACK=ON, USE_OPENMP=ON, USE_ROCM=OFF,
TorchVision: 0.13.1
OpenCV: 4.9.0
MMEngine: 0.10.3

Reproduces the problem - code sample
In embodiedscan/structures/bbox_3d/euler_box3d.py#L134
_, iou3d = box3d_overlap(corners1, corners2, eps=eps)

Reproduces the problem - command or script
sh tools/mv-grounding.sh

Reproduces the problem - error message
04/01 21:32:20 - mmengine - INFO - Epoch(train)  [5][1300/2001]  base_lr: 5.0000e-04 lr: 5.0000e-04  eta: 10:10:27  time: 2.5333  data_time: 0.1731  memory: 29459  grad_norm: 35.8510  loss: 8.8971  loss_cls: 1.0159  loss_bbox: 0.4671  d0.loss_cls: 1.0471  d0.loss_bbox: 0.46$
5  d1.loss_cls: 1.0285  d1.loss_bbox: 0.4565  d2.loss_cls: 1.0182  d2.loss_bbox: 0.4596  d3.loss_cls: 1.0093  d3.loss_bbox: 0.4628  d4.loss_cls: 1.0077  d4.loss_bbox: 0.4638
Traceback (most recent call last):
  File "tools/train.py", line 133, in <module>
    main()
  File "tools/train.py", line 129, in main
    runner.train()
  File "/mnt/lustre/huangchenxi/anaconda3/envs/visual/lib/python3.8/site-packages/mmengine/runner/runner.py", line 1777, in train
    model = self.train_loop.run()  # type: ignore
  File "/mnt/lustre/huangchenxi/anaconda3/envs/visual/lib/python3.8/site-packages/mmengine/runner/loops.py", line 96, in run
    self.run_epoch()
  File "/mnt/lustre/huangchenxi/anaconda3/envs/visual/lib/python3.8/site-packages/mmengine/runner/loops.py", line 112, in run_epoch
    self.run_iter(idx, data_batch)
  File "/mnt/lustre/huangchenxi/anaconda3/envs/visual/lib/python3.8/site-packages/mmengine/runner/loops.py", line 128, in run_iter
    outputs = self.runner.model.train_step(
  File "/mnt/lustre/huangchenxi/anaconda3/envs/visual/lib/python3.8/site-packages/mmengine/model/wrappers/distributed.py", line 121, in train_step
    losses = self._run_forward(data, mode='loss')
  File "/mnt/lustre/huangchenxi/anaconda3/envs/visual/lib/python3.8/site-packages/mmengine/model/wrappers/distributed.py", line 161, in _run_forward
    results = self(**data, mode=mode)
  File "/mnt/lustre/huangchenxi/anaconda3/envs/visual/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/mnt/lustre/huangchenxi/anaconda3/envs/visual/lib/python3.8/site-packages/torch/nn/parallel/distributed.py", line 1008, in forward
    output = self._run_ddp_forward(*inputs, **kwargs)
  File "/mnt/lustre/huangchenxi/anaconda3/envs/visual/lib/python3.8/site-packages/torch/nn/parallel/distributed.py", line 969, in _run_ddp_forward
    return module_to_run(*inputs[0], **kwargs[0])
  File "/mnt/lustre/huangchenxi/anaconda3/envs/visual/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/mnt/petrelfs/huangchenxi/EmbodiedScan/embodiedscan/models/detectors/sparse_featfusion_grounder.py", line 666, in forward
    return self.loss(inputs, data_samples, **kwargs)
  File "/mnt/petrelfs/huangchenxi/EmbodiedScan/embodiedscan/models/detectors/sparse_featfusion_grounder.py", line 507, in loss
    losses = self.bbox_head.loss(**head_inputs_dict,
  File "/mnt/petrelfs/huangchenxi/EmbodiedScan/embodiedscan/models/dense_heads/grounding_head.py", line 637, in loss
    losses = self.loss_by_feat(*loss_inputs)
  File "/mnt/petrelfs/huangchenxi/EmbodiedScan/embodiedscan/models/dense_heads/grounding_head.py", line 668, in loss_by_feat
    losses_cls, losses_bbox = multi_apply(
  File "/mnt/lustre/huangchenxi/anaconda3/envs/visual/lib/python3.8/site-packages/mmdet/models/utils/misc.py", line 219, in multi_apply
    return tuple(map(list, zip(*map_results)))
  File "/mnt/petrelfs/huangchenxi/EmbodiedScan/embodiedscan/models/dense_heads/grounding_head.py", line 711, in loss_by_feat_single
    cls_reg_targets = self.get_targets(cls_scores_list,
  File "/mnt/petrelfs/huangchenxi/EmbodiedScan/embodiedscan/models/dense_heads/grounding_head.py", line 258, in get_targets
    pos_inds_list, neg_inds_list) = multi_apply(self._get_targets_single,
  File "/mnt/lustre/huangchenxi/anaconda3/envs/visual/lib/python3.8/site-packages/mmdet/models/utils/misc.py", line 219, in multi_apply
    return tuple(map(list, zip(*map_results)))
  File "/mnt/petrelfs/huangchenxi/EmbodiedScan/embodiedscan/models/dense_heads/grounding_head.py", line 398, in _get_targets_single
    assign_result = self.assigner.assign(
  File "/mnt/petrelfs/huangchenxi/EmbodiedScan/embodiedscan/models/task_modules/assigners/hungarian_assigner.py", line 113, in assign
    cost = match_cost(pred_instances=pred_instances_3d,
  File "/mnt/petrelfs/huangchenxi/EmbodiedScan/embodiedscan/models/losses/match_cost.py", line 108, in __call__
    overlaps = pred_bboxes.overlaps(pred_bboxes, gt_bboxes)
  File "/mnt/petrelfs/huangchenxi/EmbodiedScan/embodiedscan/structures/bbox_3d/euler_box3d.py", line 134, in overlaps
    _, iou3d = box3d_overlap(corners1, corners2, eps=eps)
  File "/mnt/lustre/huangchenxi/anaconda3/envs/visual/lib/python3.8/site-packages/pytorch3d/ops/iou_box3d.py", line 159, in box3d_overlap
    _check_coplanar(boxes1, eps)
  File "/mnt/lustre/huangchenxi/anaconda3/envs/visual/lib/python3.8/site-packages/pytorch3d/ops/iou_box3d.py", line 66, in _check_coplanar
    raise ValueError(msg)
ValueError: Plane vertices are not coplanar
srun: error: SH-IDC1-10-140-24-25: task 1: Exited with exit code 1
srun: launch/slurm: _step_signal: Terminating StepId=3342784.0
slurmstepd: error: *** STEP 3342784.0 ON SH-IDC1-10-140-24-25 CANCELLED AT 2024-04-01T21:32:52 ***

Additional information
In https://github.com/facebookresearch/pytorch3d/issues/992, they suggest increasing EPS. Will this problem occur under your default setting of 1e-4? If so, how do I adjust the EPS value? And this happened in my 5th epoch, with randomness, what is the reason for this?

But when I increase the value of eps, the error "Planes have zero areas" will be reported, that is, _check_coplanar() and _check_nonzero() will conflict.

Yes, that is the case. The EPS for your two mentioned check operations is in conflict. You may need to tune the optimizer settings to make the training more stable. I notice you only use two GPUs and you may need to reduce the learning rate by 2 or 4 accordingly.

Please see #22 for more explanations about this bug.

Thanks, I will try it again.

Thanks, I will try it again.

Hi, @mrsempress , did you solved this issues?

@EricLee0224 No, I don't solve this issue. I only keep the original value and retrain from the beginning. Sometimes, it can train completely.

Hi all, we have just sorted out the occupancy prediction baseline recently. While open-sourcing those parts, we will have a closer look at this problem, particularly for the visual grounding baseline. We will try to address it in two weeks.

Hi, I solved this issue in https://github.com/OpenRobotLab/EmbodiedScan/issues/40#issuecomment-2058598322
please have a check


Runtime penalty with fields that have expensive inits

I was surprised about the runtime of a posterior estimation I was coding. Here is a MWA to reproduce the issue:

import jax.numpy as jnp
import equinox as eqx
import distrax

class Parameter(eqx.Module):
    value: jnp.ndarray
    prior: distrax.Distribution

    def log_prior(self):
        return self.prior.log_prob(self.value)

v = jnp.zeros(10)
mu = jnp.ones(10)
sigma = jnp.ones(10)
p0 = distrax.MultivariateNormalDiag(mu, sigma)
p = Parameter(v, p0)

# test with some data
import optax
from jax import random
key = random.PRNGKey(0)
data = random.normal(key, (10,))

@eqx.filter_value_and_grad
def loss_fn_with_grad(model, data):
    neg_log_like = 0.5 * ((model.value - data)**2).sum()
    return neg_log_like - model.log_prior()

@eqx.filter_jit
def make_step(model, data, opt_state):
    loss, grads = loss_fn_with_grad(model, data)
    updates, opt_state = optim.update(grads, opt_state)
    model = eqx.apply_updates(model, updates)
    return loss, model, opt_state

learning_rate=1e-1
optim = optax.adam(learning_rate)
opt_state = optim.init(eqx.filter(p, eqx.is_array))

for step in range(100):
    loss, p, opt_state = make_step(p, data, opt_state)
    loss = loss.item()
    print(f"step={step}, loss={loss}")

The runtime for a single call to make_step is about 75 ms on a single core. This drops to 100 µs when the prior is declared static:
class Parameter(eqx.Module):
    value: jnp.ndarray
    prior: distrax.Distribution = eqx.static_field()

    def log_prior(self):
        return self.prior.log_prob(self.value)

The issue, I think, is that in the first case, filtering creates new instances of prior:
params, static = eqx.partition(p, eqx.is_array)
print(p)
print(params)
print(static)

yields
Parameter(
  value=f32[10],
  prior=<distrax._src.distributions.mvn_diag.MultivariateNormalDiag object at 0x13e9ae9d0>
)
Parameter(
  value=f32[10],
  prior=<distrax._src.distributions.mvn_diag.MultivariateNormalDiag object at 0x15b82c400>
)
Parameter(
  value=None,
  prior=<distrax._src.distributions.mvn_diag.MultivariateNormalDiag object at 0x15bd2d370>
)

In the case of prior: distrax.Distribution = eqx.static_field() it's the same instance. I suspect that the cost to init the new instances is what's dragging down the performance. This is probably the intended behavior here but I was surprised by it because in neither case prior is treated as a tree leaf, which I thought is what get's altered for each gradient update.
I might be doing this wrong, but if not it would be good to clarify the use of static_field in the docs, where it's generally discouraged.

Okay, this is interesting. Thanks for opening this issue!

First of all, to establish a baseline. On my machine, I get:
%timeit make_step(p, data, opt_state)
30.4 ms ± 3.48 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)  # baseline

Now, the dev branch of Equinox removes the ability to specify a full filter specification for how to dynamically/statically partition the tree. (The reality was that this simply wasn't used much, as the default of dynamically-trace-all-arrays and static-everything-else is what we want nearly all the time.) This simplification gives us, amongst other things, a noticeable speed improvement:
11.6 ms ± 426 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)  # dev branch

So, hurrah, that's an improvement that's worth something!
But it's still a fair bit slower than what you were reporting when using static_field. Once again, baseline:
171 µs ± 30.1 µs per loop (mean ± std. dev. of 7 runs, 1,000 loops each)  # static_field (+ dev branch)

Let's see if we can track down where this is coming from. It's not the flattening of prior:
%timeit jax.tree_util.tree_flatten(p.prior)
1.51 µs ± 33.6 ns per loop (mean ± std. dev. of 7 runs, 1,000,000 loops each)

But the unflattening does seem very costly:
flat, treedef = jax.tree_util.tree_flatten(p.prior)
%timeit jax.tree_util.tree_unflatten(treedef, flat)
1.7 ms ± 79.2 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

Adding a quick print statement to Distrax's unflattening rule Jittable.tree_unflatten, we see that it prints out five times for a single (compiled) run. Now 5 * 1.7ms isn't far off 11.6ms, so it seems that Distrax's unflattening rule is what is accounting for pretty much the entire performance cost.
This looks like a Distrax bug: I tried writing a quick analogue in Equinox and it unflattens in:
2.56 µs ± 67.7 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)

What are the paths forward?
Option 1
Fix Distrax.
Unfortunately, the library seems semi-unmaintained. (In fact, in the process of debugging this, I came across this this Distrax issue, which seems to indicate that the master version of Distrax has several other issues beyond that discussed here.)
So I'm honestly not sure if Distrax is a great choice of library to be using. Maybe switch away from it, or write your own competing library instead.
Option 2
It's definitely a hack, but just marking the Distrax distribution as a static_field seems to work. This is essentially equivalent to capturing the static'd object via closure, e.g. you can't differentiate it.
Incidentally this only actually works because of a different bug in Distrax. (Those JAX arrays you're passing into it aren't hashable, and static data needs to be hashable.)
But -- as long as that works for you, then go for it.
Option 3
Specifically when running a repeated training loop, then it's possible to "cancel out" the flattening/unflattening that's happening in the loop. (i.e. the unflattening at the end of filter_jit followed by the flattening at the start of filter_jit).
In this case model and opt_state are nontrivial PyTrees, so you can do:
import jax.tree_util as jtu

...

flat_p, treedef_model = jtu.tree_flatten(p)
flat_opt_state, treedef_opt_state = jtu.tree_flatten(opt_state)

@eqx.filter_jit
def make_step(flat_model, data, flat_opt_state):
    model = jtu.tree_unflatten(treedef_model, flat_model)
    opt_state = jtu.tree_unflatten(treedef_opt_state, flat_opt_state)
    ... # as before
    flat_model = jtu.tree_leaves(model)
    flat_data = jtu.tree_leaves(data)
    return loss, flat_model, flat_data

for step in range(100):
    loss, flat_p, flat_opt_state = make_step(flat_p, data, flat_opt_state)

This is a generic trick that's useful for every training loop. (Library idea: perhaps it'd be worth writing some kind of PyTorch-Lightning-style training loop library that does this kind of thing automatically.)
This has quite a dramatic effect for us, since unflattening is so costly in our case. With this trick in place, we get down to a tidy:
%timeit make_step(flat_p, data, flat_opt_state)
74.2 µs ± 12.7 µs per loop (mean ± std. dev. of 7 runs, 10,000 loops each)

Hopefully that helps!

Awesome! Thanks for the suggestions. Option 3 looks like the way to go.
Btw, I'm not at all sold on Distrax, it was just the first thing I tried for a toy model. In practice I'll have my own distribution models, the problem above came up during testing.

In your option 3 example, make_step returns loss, flat_model, flat_data, but in step loop the variables are loss, flat_p, flat_opt_state. Did you mean this?

Good catch! You're correct.

It's still in very preliminary stages, but something you might be interested in is distreqx: https://github.com/lockwo/distreqx. I can't get an exact benchmark since when I run the distrax code on my machine I see a very large ValueError: Mismatch custom node data: error. But I can say
import jax.numpy as jnp
import equinox as eqx
from distreqx import distributions

class Parameter(eqx.Module):
    value: jnp.ndarray
    prior: distributions.AbstractDistribution

    def log_prior(self):
        return self.prior.log_prob(self.value)

v = jnp.zeros(10)
mu = jnp.ones(10)
sigma = jnp.ones(10)
p0 = distributions.MultivariateNormalDiag(mu, sigma)
p = Parameter(v, p0)

# test with some data
import optax
from jax import random
key = random.PRNGKey(0)
data = random.normal(key, (10,))

@eqx.filter_value_and_grad
def loss_fn_with_grad(model, data):
    neg_log_like = 0.5 * ((model.value - data)**2).sum()
    return neg_log_like - model.log_prior()

@eqx.filter_jit
def make_step(model, data, opt_state):
    loss, grads = loss_fn_with_grad(model, data)
    updates, opt_state = optim.update(grads, opt_state)
    model = eqx.apply_updates(model, updates)
    return loss, model, opt_state

learning_rate=1e-1
optim = optax.adam(learning_rate)
opt_state = optim.init(eqx.filter(p, eqx.is_array))

_ = make_step(p, data, opt_state)

%%timeit
_ = make_step(p, data, opt_state)

yields much faster than 32 ms: 727 µs ± 17.4 µs per loop (mean ± std. dev. of 7 runs, 1,000 loops each).
And if you mark it as static you see 102 µs ± 950 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each)


[FIX] Fix references being deleted with jupyter-upgrade

Closes #261

Sorry, I had a typo that made the tests fail

This looks good! Could you do one thing before merging, which is to add a short test to make sure that the behavior we get is expected?
You could add a _bibliography folder here: https://github.com/jupyter/jupyter-book/tree/master/jupyter_book/tests/site
and then run a similar check to what we do for requirements.txt: https://github.com/jupyter/jupyter-book/blob/master/jupyter_book/tests/test_create.py#L140
Does that work?

Sure! I will try it

Could the test be failing because CI is not taking into account commit
dfb6bba? It doesn't appear here.

yesss - this looks great! Just double-checking, are you ready for this one to 🚀 ?

Cool! From my side I think its ready!

Then thanks for contribution number 2!! wohoooo 🎉🎉🎉


Handle push rejection message in Merge & Web Editor

Merge push rejection due to pre-receive hook failure should not necessarily result in 500.
Fix: #10322

Codecov Report

Merging #10373 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #10373      +/-   ##
==========================================
- Coverage   43.69%   43.66%   -0.03%
==========================================
  Files         585      585
  Lines       81024    81077      +53
==========================================
+ Hits        35400    35404       +4
- Misses      41233    41280      +47
- Partials     4391     4393       +2

Impacted Files
Coverage Δ

routers/api/v1/repo/pull.go
34.82% <0%> (-0.36%)
:arrow_down:

services/pull/merge.go
49.45% <0%> (-0.99%)
:arrow_down:

models/error.go
29.7% <0%> (-1.26%)
:arrow_down:

routers/repo/pull.go
28.37% <0%> (-0.33%)
:arrow_down:

modules/process/manager.go
74.69% <0%> (-3.62%)
:arrow_down:

models/unit.go
37.03% <0%> (-2.47%)
:arrow_down:

models/issue.go
53.82% <0%> (-0.13%)
:arrow_down:

services/mirror/mirror.go
19.4% <0%> (+0.65%)
:arrow_up:

modules/log/event.go
65.64% <0%> (+1.02%)
:arrow_up:

models/repo_mirror.go
12.76% <0%> (+10.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 194ef0b...e35d315. Read the comment docs.

Because this PR fixes the sanitization of the error message in the Web editor I've marked this as backport/v1.11

pleace send backport


Dedupe Postgresql example.

 Which code should i preferably use and what values (i.e threshold etc.) should i change to get the desired result??

This would be a good question for https://stackoverflow.com/ These issue tracker is for bugs and feature requests.


v4.0.5 Crash in -[ApptentiveBackend migrateLegacyCoreDataAndTaskQueueForConversation:conversationDirectoryPath:]

Here is a link to the Crashlytics details: http://crashes.to/s/48a1700e30e

We have released a new tag that should address this issue: https://github.com/apptentive/apptentive-ios/releases/tag/v4.0.6-rc.
If you are able to reproduce this crash it would be helpful to make sure it is no longer occurring.

We now have an official release incorporating these fixes.

I am closing this for now. If you see additional instances of this crash with 4.0.6 or later, please re-open.


Allow to pass custom height

Currently widget only accepts visual parameter, but sometimes I need a playlist view but without visual.
So it should be like this:
{
    height: this.props.height || (this.props.opts.visual ? "450" : "166"),
}

Forgot to close this, 55d4ab82303fe093333796888b65edc5942029af


Add TypeScript declarations

Depends on davidtheclark/focus-trap#41

@TedDriggs @kiliancs Following up on https://github.com/davidtheclark/focus-trap/pull/41 I'm happy to give this a chance. Are in disagreement, though, about whether this is correct?

@davidtheclark I made a commit to address @kiliancs' feedback. He should confirm, but I believe this now exactly matches what we're using internally.

Thanks @TedDriggs @kiliancs. Published in 3.1.0.


[Experiment] Remove Cuda

Problem

Nobody uses the cuda implementation
We have to maintain cuda implementation
The interfaces around cuda are making changes we want difficult

Summary of Changes

Experiment to just see how much code we can remove if we remove cuda stuff

Fixes #

Any interest in possibly switching to https://github.com/Rust-GPU/rust-gpu/ instead?

Any interest in possibly switching to Rust-GPU/rust-gpu instead?

No, that doesn't solve anything here.


Introduce a MapId object containing the DataMap prefix

This PR facilitates further improvements to the rocksdb prefix setup. An immediate benefit is that it'll also be harder to make a typo when picking a context/prefix and to have their full list in a single spot.

The CI failure is unrelated.

Cc https://github.com/AleoHQ/snarkOS/pull/1417.

Looks like CI is unhappy with one of the tests.


ConnectionSettings.ServerCertificateValidationCallback does not use System.Net.Security.RemoteCertificateValidationCallback

For stringent certificate handling it would be helpful if ConnectionSettings.ServerCertificateValidationCallback would use the standard RemoteCertificateValidationCallback delegate from the framework. Currently it uses a slightly different func that would need extra lifting in a centralized certificate handling scenario.
Yours
Func<object, X509Certificate, X509Chain, SslPolicyErrors, bool> callback
vs
public delegate bool RemoteCertificateValidationCallback(object sender, X509Certificate? certificate, X509Chain? chain, SslPolicyErrors sslPolicyErrors);
The only difference seems to be the nullability of the certificate and chain. So i don't see the why it needs to be different from the standard here.
Proposal:
Keep ConnectionSettings.ServerCertificateValidationCallback as it is for backward compatibility and add another RemoteCertificateValidationCallback property to ConnectionSettings conforming to the standard delegate from the framework.

Hi, @Another-Ralf. We specifically do not depend on the framework type in order to provide an abstraction that can work across our target frameworks. The library also targets net461, for example, where the signature of the framework types is different. Specifically, in this case, nullable reference types are not available on all targets. Our method needs to be independent of the target framework. While we could technically add framework dependent overloads, it because hard to maintain over time. For the same reason, we provide our own ITransport abstractions which decouple the public API of the library from the underlying HTTP implementation.
In your case, could you not provide a function somewhere to convert as necessary. A simple local function like this should be sufficient and doesn't feel like much extra lifting:
static Func<object, X509Certificate, X509Chain, SslPolicyErrors, bool> Interop(RemoteCertificateValidationCallback callback)
	=> (a, b, c, d) => callback(a, b, c, d);

If this is not practical, I'd like to understand your scenario further if you can share more details.

Wasn't aware that the callback signature isn't consistent over all frameworks. Good Argument.
I was already doing something along the line of your code sample. It is practical but felt unnecessary at first.


Add eosio.contracts documentation content to release/1.8.x

Change Description
Introduces new documentation content layout, two options, one in docs and one in docs_v2, we shall pick one of these two.
Deployment Changes

[ ] Deployment Changes

API Changes

[ ] API Changes

Documentation Additions

[x] Documentation Additions

wrong approach, closing.


fix Xero action modal positioning and display circle icon instead

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/45607
PROPOSAL: https://github.com/Expensify/App/issues/45607#issuecomment-2233429531
Tests

Precondition:

Workspace is connected to Xero
Delayed submission is enabled in Workflows

Go to workspace chat
Submit an expense
In the main chat, click on the pay elsewhere dropdown
Pay elsewhere the report
Click on the Xero action dropdown
Verify that the action dropdown not overlap with the composer
Verify that the icon on action dropdown is circle

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Hmm the position of the context menu still feels like it's not correct. Shouldn't it be either left or right aligned to the button below it?

Hmm the position of the context menu still feels like it's not correct. Shouldn't it be either left or right aligned to the button below it?

I think it should be aligned on the right? Because the right arrow-side of the button is what would be spawning this menu.

Dang, that also seems broken. I agree with Danny that it should be right-aligned to the button.

I feel like this must be a regression from somewhere personally... I don't recall it ever being like that?

Are we ready for a review from @aimane-chnaif?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.15-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.15-9 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


root-signing-staging maintainer permissions not working

After a few attempts the pulumi update from merging https://github.com/sigstore/community/pull/355 (https://github.com/sigstore/community/actions/runs/6656388104) seems to have succeeded, so the root-signing-staging maintenance permissions should now be good...
Unfortunately I'm not seeing that:

I don't seem to have even triage on GitHub as I can't label or assign issues
I can't push a branch to the project

The yaml files in this project seem correct to me but I think I have no visibility to how pulumi sees them -- so I don't know if the issue is connecting the team to "maintain" role on the project  or my membership in the team. I could have an incorrect team id in repositories.yaml but I took it from @cpanato in https://github.com/sigstore/community/pull/350.

Fredrik mentioned that he does have the permissions in the project so the issue seems to be my membership in the team?

those are the teams in the root signing staging repo

you should not able to push the main branch, only via PR

tuf-root-signing-staging-codeowners should have 3 members (me, haydentherapper and kommendorkapten). Looks like my membership has an issue, but I can't figure out what it is...

Would it be possible to see who is the members of tuf-root-signing-staging-codeowners? I would guess me and Hayden.

Apparently the issue was that I had not been invited to sigstore org. @bobcallaway invited me now, I've accepted, and I've now been added to the team as well.
I'm going to close this. I think the root cause was:

I did not realize that adding a user to the config in this project does not add that user to the org
My PR #348 ended up closing #347 so I was never added to the org. I supose adding me to the team then silently failed

I don't know if there's something that could be done to improve the process -- could the pulumi update process check that the user is actually a member in the org? Currently it seems to just silently fail to add the user to a team in that case


feat: add phalcon 5.3.1 release

update phalcon with release 5.3.1

:tada: This PR is included in version 1.203.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Cosmos hotfix - RU metrics fixes

API change check
API changes are not detected in this pull request.


Update client-go to >0.17.x

client-go 0.18.0 adds context in method signatures. Also, it adds new metrics but changes the interface for metrics export.

client-go 0.20 has breaking changes for fake cluster :(

client-go is updated to 0.19.11 in #289


Unable to start cgw-web

Description
How to set the env when we are not able to start the container?
Stop using the public docker image and pull from this repo instead?
not even under
https://github.com/safe-global/safe-infrastructure/blob/main/container_env_files/cgw.env
Reproduction steps
root@containers:/opt/safe-infrastructure# docker compose up -d cgw-web
[+] Running 2/2
 ✔ Container safe-infrastructure-cgw-redis-1  Healthy                                                                                0.6s
 ✔ Container safe-infrastructure-cgw-web-1    Started                                                                                0.8s
root@containers:/opt/safe-infrastructure# docker logs -f safe-infrastructure-cgw-web-1
/dist/src/config/configuration.validator.js:19
    throw Error(`Configuration is invalid: ${errors}`);
          ^

Error: Configuration is invalid: INFURA_API_KEY Required; RELAY_PROVIDER_API_KEY_ARBITRUM_ONE Required
    at default_1 (/dist/src/config/configuration.validator.js:19:11)
    at Object.validate (/dist/src/config/configuration.module.js:27:70)
    at ConfigModule.forRoot (/node_modules/@nestjs/config/dist/config.module.js:78:45)
    at ConfigurationModule.register (/dist/src/config/configuration.module.js:25:39)
    at AppModule.register (/dist/src/app.module.js:97:60)
    at bootstrap (/dist/src/main.js:7:94)
    at Object.<anonymous> (/dist/src/main.js:12:6)
    at Module._compile (node:internal/modules/cjs/loader:1358:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
    at Module.load (node:internal/modules/cjs/loader:1208:32)

Node.js v20.14.0

docker-compose.yml
  cgw-web:
    image: safeglobal/safe-client-gateway-nest:${CGW_VERSION}
    env_file:
      - container_env_files/cgw.env
    depends_on:
      cgw-redis:
        condition: service_healthy

Expected behavior
able to start and set the env under
https://github.com/safe-global/safe-infrastructure/blob/main/container_env_files/cgw.env
Additional information
No response

add ourself on cgw.env lol

Sorry for being late, but this is fixed by https://github.com/safe-global/safe-infrastructure/pull/144

Sorry for being late, but this is fixed by safe-global/safe-infrastructure#144

okay thanks,
desperately need help on
https://github.com/safe-global/safe-client-gateway/issues/1692
https://github.com/safe-global/safe-infrastructure/issues/143


fix: as_simple_carret should check for empty compartors before borrowing

relates #3
This corrects the length check to prevent for borrowing in a case where the length of the comparators is 0.

Thanks for the PR—this has been fixed thanks to #4 and https://github.com/mainmatter/cargo-autoinherit/commit/35325140f0bb15dc1fbff29bf262bfe477b59625


CHOMP DistanceFieldManager should honor DOF resolutions

The CHOMP DistanceFieldManager generates a "key" struct to check whether the currently-loaded distance field is valid. This key includes the body's kinematic-geometric hash, which links are enabled, and any DOF values that effect the enabled links. Unfortunately, this means that any change in DOF values, including to floating point error, can invalidate the current distance field.
We should only invalidate the distance field if the DOF value changes by more than the DOF resolution. Similarly, we should use the same resolution to discretize the current DOF values when writing the distance field to disk.

Floating point precision issue was fixed by #317.


Unify & optimise serialization in v0.7

You are probably wondering how I got here Background: earlier today I opened #140, where @survived suggested either to wait a couple of months or open a PR. The former is not a viable option for us, hence here comes the latter.
Resolves #138 and #140 in v0.7:

unify & optimise serialization of BigInt;
optimise serialization of Secp256k1Point (compressed form).

The main question here is if you consider serialization format public API or not. I am very tempted to say that it is not, and the only publicly guaranteed invariants are Deserialize(Serialize(Point)) = Point and Serialize(Deserialize(String)) = String.
However, my opinion is clearly biased, and there are different approaches to this issue. For example, one may argue that if they got a file on a hard drive produced by the former version of Serialize, then they won't be able to Deserialize it by the current version of Deserialize, which is not ideal, to say the least.
However, #139 appears to be a bug-fix either way, so the situation above can occur in the current setting as well (when using different BigInt backends), so I assume it has to be addressed somehow...

The main question here is if you consider serialization format public API or not

Indeed, we should freeze serialization format at some point in the future. It's not expected that bumping curv v0.7.1 to v0.7.2 will invalidate all serialized points/bigints. However, we do not follow any policy regarding serialization format, so it may be considered unstable.

LGTM!

I added only the basic requested changes yesterday and still want to change from hex to raw bytes, so please don't merge it in yet. Thank you for your patience. 🙏🏼

BigInt deserialization implementation has been improved in latest curv, it was not compatible with serde_json. See the PR: #145. Points/scalars deserialization has been changed as well: #143


Add dimensions to OpenAIEmbedding(query)

Description
I observed that the embedding dimensions in GraphRAG are currently fixed and not editable, with a default value of 1536. To enhance flexibility, I've introduced an option to alter these dimensions within the OpenAIEmbedding located in query/llm/oai/embedding.py. This improvement is aimed at assisting developers who wish to utilize different dimensions for embeddings.
Related Issues
[Reference any related issues or tasks that this pull request addresses.]
Proposed Changes
introduced an option to alter these dimensions within the OpenAIEmbedding located in query/llm/oai/embedding.py
Checklist

[ √] I have tested these changes locally.
[ √]] I have reviewed the code changes.
[ √]] I have updated the documentation (if necessary).
[ ] I have added appropriate unit tests (if applicable).

Additional Notes
[Add any additional notes or context that may be helpful for the reviewer(s).]

@microsoft-github-policy-service agree [company="{shiyanjia}"]

@microsoft-github-policy-service agree
@microsoft-github-policy-service agree company="shiyanjia"

I've made a new PR in #1041 ,which already includes all the changes from the this one.


Update for new link text on "Ask a question" page

If a user is already logged in then they now see the link text "Ask a question" rather than "Log in to ask a question", which is only shown when no user is logged in.

:+1:


Android with Qt 6.4.3 ERror

the example QML Barcode reader crashed
E EGL_emulation: eglQueryContext 32c0  EGL_BAD_ATTRIBUTE
E EGL_emulation: tid 1898: eglQueryContext(2160): error 0x3004 (EGL_BAD_ATTRIBUTE)
W libQmlBarcodeReader_x86_64.so: Qt has caught an exception thrown from an event handler. Throwing
W libQmlBarcodeReader_x86_64.so: exceptions from an event handler is not supported in Qt.
W libQmlBarcodeReader_x86_64.so: You must not let any exception whatsoever propagate through Qt code.
E libc++abi: terminating with uncaught exception of type std::out_of_range: Requested row is outside the image
F libc    : Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 1871 (QThread), pid 1791 (mlbarcodereader)

I'm closing this issue as for now it has the same symptom as this one: link
Probably the same cause.


fix to support completing paths including non-keyword

add faq sectoin about windows space paths to doc
fix to switch backward serach pattern depending on mode source param
fix to support completing paths including non-keyword

last commit resolves https://github.com/LumaKernel/ddc-file/issues/4

(coloring is spell check)


Storage drawers issue specific to the inventory panel.

Issue Description:
Thank you and apologies to Tterrag for directing me here. Sadly i am not able to provide as much information as i would like to on these issues as the files are gone, but i am still posting this in the hopes it may be helpful. Also i see there have been a few updates to Ender IO since i was last able to play so some of this may have been resolved, however is case it hasnt im going to give as much information as i can.
These issues are specific to the inventory panel working with the storage drawers mod. The reason i say this is that 2 other inventory mods were tested at the same time(logistic pipes and AE2) both of those mods were able to accurately read the storage drawers inventory, only the inventory panel had an issue. I have seen this happen through multiple versions of ender io and through multiple modpacks.
Inventory panel will report multiple items, from several other mods, as different items. Inventory panel will sometimes pull items for recipes incorrectly.
First time posting here so forgive me if i mess anything up.
What happens:
This happened with several blocks when using an inventory panel hooked up to storage drawers, but say i wanted a draconic core. if i looked in the inventory panel for that it would not be there but in reality it was there but the inventory panel was reporting it as another item, in this case i think it was a sky stone block from AE2. there were many other blocks that had similar issues but this one stuck out in my memory. also there were times where you would pull a recipe into the inventory panel from nei and it would pull all the needed items but not put the recipe in the correct order in the crafting grid.
What you expected to happen:
Steps to reproduce:
Unfortunately i am unable to provide the steps to reproduce this. as all the files are gone in a windows reformat where i forgot to backup the minecraft directory. This did happen in Infinity evolved(i understand that was heavily modified and may not be relevant)  and in both sky factory 2.4 and 2.5(once again a modpack but i have my reasons for reporting it here so please do not be irritated)

Affected Versions (Do not use "latest"):

EnderIO:  EnderIO-1.7.10-<IP_ADDRESS>1.jar   -   EnderIO-1.7.10-<IP_ADDRESS>4_beta
EnderCore:    -    EnderCore-1.7.10-<IP_ADDRESS>_beta
Minecraft: 1.7.10 some similar issues seen on the 1.10 versions being streamed by those on the forgecraft server.
Forge:  <IP_ADDRESS>8 - <IP_ADDRESS>4

Your most recent log file where the issue was present: unable to provide due to the aforementioned windows reformat.
I hope that some of this helps. i know its not much to work with(darn windows 10 reformat).
[pastebin/gist/etc link here]

This has been fixed recently.

Maybe. I think it's at worth investigating if it's still an issue as I'm not sure the recent fix addresses this.

I have also experienced this.


billingContact and shippingContact for Apple Pay

What about it?
https://developer.apple.com/documentation/passkit/pkpaymentrequest

Hi, @urusai88 I'm already working on this

Hi, @urusai88 I'm already working on this

Oh, me started to work on this too

@urusai88, Added options for Apple Pay #6 (also updated 2.0.2 on pub). I will close the issue.


show mouse pointers axis on image

Hello Alexey,is there a way that you can add this functionality to show mouse pointers axis' on image when annotating,it would make annotations much more easier =)
Thanks.

Hi, I added it. To enable mouse coordinates - press m button.


About the latest release?

👋 it looks like 1.2.1 is not marked as latest release, create this issue to confirm if I missed anything. Thanks!
relates to https://github.com/Homebrew/homebrew-core/pull/133764

sorry it is the latest release, just I haven't finished writing release notes. I defer clicking latest release until I've done the paperwork :) I'll try to do it faster next time!

https://github.com/tetratelabs/wazero/releases/tag/v1.2.1

Thanks!! :)


Mgmt generate

sdk/cosmos/mgmt-v2020_04_01/src/main/java/com/microsoft/azure/management/cosmosdb/v2020_04_01/implementation/NotebookWorkspacesInner.java:[345,207] cannot find symbol
[ERROR]   symbol:   variable notebookCreateUpdateParameters
[ERROR]   location: class com.microsoft.azure.management.cosmosdb.v2020_04_01.implementation.NotebookWorkspacesInner
It would also need some fix, so I think it is ok to flatten 1.

I mean set to 0.
https://github.com/Azure/azure-sdk-for-java/pull/13977/commits/881a0e4e3b6070332564bfa69b407ac88c9a6449#diff-6000727318bb365e75a30e66c1468425

Yes, my comment is the compile error by using flatten 0 generator. There is no difference for such two flatten in track 1.