Does --filename needs to be relative path to .luachekrc?

Hi, I am trying to fix luacheck on Emacs flycheck in this PR
And I wanna confirm that when luacheck reads data from stdin, if we want the following config to work
files['spec'] = { std = '+busted' }

we need to pass the relative path of the target file to --filename option.
If yes, can you help to leave a comment in that PR, so that I can get flycheck author's help to fix the issue?

Hi,
luacheck detects the config by iterating from current directory up to filesystem root, looking for config from each directory using path passed using --config or default .luacheckrc. All paths inside a config are then adjusted as if luacheck was run from the directory the config was found from. As an effect, if --config is used with direct path to config, paths are not adjusted at all, and it's necessary to pass relative path from actual project root to the checked file using --filename.
So, it's better to avoid using --config and let config detection do its thing. To ensure that it works start luacheck from the directory containing the checked file.

@mpeterv Thanks a lot for your clear explanation, it's very helpful. The issue on Flycheck side is now fixed, so I am closing this issue too :)


[JS] Incorrect private method suggestion

VSCode Version: 1.52.1
OS Version: Windows 10

Steps to Reproduce:

Create a .js file
Create a class
Create a private method like this
Create anothe instance method called abcMethod
Type this. from abcMethod

Expected Behavior:
The suggestion should be #privateMethod
Actual Behavior:
The suggestion is "__#<SomeNumber>@#privateMethod"
https://user-images.githubusercontent.com/15051871/103283826-9d54ca80-49ff-11eb-908a-b5c628a9645f.mp4

Does this issue occur when all extensions are disabled?: Yes

/duplicate of #106351


refactor: rename Catalog to ApplicationCatalog

What does this PR do?
Rename the Catalog interface to ApplicationCatalog as we want to have later a dedicated ModelCatalog. See https://github.com/projectatomic/ai-studio/issues/447 for details
Screenshot / video of UI

What issues does this PR fix or reference?
Fixes https://github.com/projectatomic/ai-studio/issues/488
How to test this PR?

[x] existing tests ensure no regression

Reference

Sorry I included a previous commit that should not have been here. Fixed

@jeffmaury rebased ✅

cc @jeffmaury


Remove AWS Service Operator

@chrisfarms we'll need someone with IAM admin permissions to do that... Let's discuss this elsewhere :)


added links to video recordings to projects page, deleted dropped projects

Shall we actually keep the dropped projects? It seems a good idea to keep them for future inspiration.

To the extent that this page will become the 2021 projects page (see https://oceanhackweek.github.io/pasthackweeks.html), I would say no. We do have this 2021 information preserved in a Google Doc, just like for 2020. Maybe there's room for a separate page that compiles project ideas/proposals that didn't take off?

Yes I think it'll be good to have a separate page for the project ideas/proposals that didn't take off. It is still effort from participants, so would be good to document that.


Custom hover disappears before you can mouse over into it

Have a status bar contribution with an actionable tooltip, like Rust Analyzer's contribution in a repo with Rust code (like vscode) or Joh's PR pinger
Hover over the status bar entry and try to move your mouse to interact with it
It disappears 🐛

This seems like a recent regression to me because for the window zoom status entry this used to work recently.
@benibenj can you see if its maybe something you changed?

Unless it's explicitly indicated as not hoverable any hover with markdown will allow it. I do notice hideOnHover is set to true in the new workbench hover delegate which is surprising to me, not sure why it wouldn't be using the default which is dynamically selected:
https://github.com/microsoft/vscode/blob/ead483888530303c5914f7078bcf0ed6ce17cf0d/src/vs/platform/hover/browser/hover.ts#L285-L292
@benibenj has been making a lot of hover changes recently.

@benibenj please cc me on workbench hover-related PRs so I can track changes going in. It's good you're taking some ownership but I just want to make sure I'm kept up to date 🙂

So this is a bug. I noticed it a while ago and just got used to keeping Alt pressed (using Windows).

@alexandruavadanii some hovers intentionally cannot be moused over so I'm glad you discovered alt 👍

Initially the new WorkbenchHoverDelegate was introduced to have a simple way to replace the native hover. Due to this it made sense to set hideOnHover: true to make sure the behaviour is similar to the native one.
It afterwards turned out that using the WorkbenchHoverDelegate was a nice way to clean up some of the existing custom hover code such as the one in the status bar.
It makes sense to switch back to the default behaviour for hideOnHover.


Question regarding plugin_loaded() method

When reloading submodules does/can this call plugin_loaded() if it is present?

why not trying yourself? (and the answer is yes).

Sorry if I wasn't clear. It seems to me that if a .py file containing a plugin_loaded() function is in a package subfolder, and is reloaded by this plugin, plugin_loaded() isn't called on the reload. (And it is called by ST on initial package load.)
I asked the way I did because I don't understand what you are doing well enough to know for sure what is and isn't happening :)

I don't think plugin_loaded()  in .py file insider a subfolder will be ever loaded in the first place.

Thanks for looking at this. If you have a top level file that imports bar, so:
Test
└── bar
    └── __init__.py
└── testme.py

testme.py:
from . import bar

plugin_loaded() in bar/__init__.py will be called when ST first loads.
Maybe that's a crazy structure? :smile: But at any rate, that is what I was hoping could happen on reload.

Oh, I think it is an issue of Sublime Text itself.
https://github.com/twolfson/sublime-files/blob/441067288c2e035cf05295a79e3f8385ac5d0f77/sublime_plugin.py
Check the difference between reload_plugin and on_api_ready.
on_api_ready is launched at startup and finds all plugin_loaded.
reload_plugin is used to reload top level plugins, e.g., reload_plugin("Test.testme") and only reload plugin_loaded in testme.py.
My suggestion is to rename all plugin_loaded in subdir to something and export the calls to top level and include them
from .bar import call1
from .foo import call2

def plugin_loaded():
     call1()
     call2()

Makes sense, and thanks for explaining it to me!


docs: Clarify information about Github tokens and secrets

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@c560303). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage        ?   53.54%
=======================================
  Files           ?        4
  Lines           ?      127
  Branches        ?        0
=======================================
  Hits            ?       68
  Misses          ?       59
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c560303...e0b8d57. Read the comment docs.

FYI I do not yet make use of the GH_SECRET.


Extension file 'tensorflow/core/platform/default/rules_cc.bzl' has errors when install tflite-support-0.4.2 using Bazel 4.2.2

Click to expand!
Issue Type
Bug
Source
source
Tensorflow Version
tf 2
Custom Code
No
OS Platform and Distribution
Raspbian Buster
Mobile device
No response
Python version
3.7
Bazel version
4.2.2
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
I tried to install tflite-support-0.4.2 using bazel on my Raspberry Pi (Raspbian Buster) since I can't install it directly using pip3. I expected that installing from bazel will result in complete installation of tflite-support. However when I try to build the package it gives me this error. I tried several time but the result is still the same.

`
ERROR: Traceback (most recent call last):
        File "/home/pi/.cache/bazel/_bazel_pi/e377461fba63f25ab8757a7080bd56fe/external/org_tensorflow/tensorflow/core/platform/default/rules_cc.bzl", line 6, column 28, in <toplevel>
                _cc_shared_library = native.cc_shared_library
Error: no native function or rule 'cc_shared_library'
ERROR: Analysis of target '//tensorflow_lite_support/tools/pip_package:build_pip_package' failed; build aborted: error loading package '@org_tensorflow//tensorflow': in /home/pi/.cache/bazel/_bazel_pi/e377461fba63f25ab8757a7080bd56fe/external/org_tensorflow/tensorflow/tensorflow.bzl: in /home/pi/.cache/bazel/_bazel_pi/e377461fba63f25ab8757a7080bd56fe/external/org_tensorflow/tensorflow/core/platform/rules_cc.bzl: Extension file 'tensorflow/core/platform/default/rules_cc.bzl' has errors`

The code in 'tensorflow/core/platform/default/rules_cc.bzl' is:

`"""Provides an indirection layer to bazel cc_rules"""

load(
    "//tensorflow/core/platform/default:rules_cc.bzl",
    _cc_binary = "cc_binary",
    _cc_import = "cc_import",
    _cc_library = "cc_library",
    _cc_shared_library = "cc_shared_library",
    _cc_test = "cc_test",
)

cc_binary = _cc_binary
cc_import = _cc_import
cc_library = _cc_library
cc_shared_library = _cc_shared_library
cc_test = _cc_test`

Standalone code to reproduce the issue
I just use this command (no custom code):

`bazel build -c opt tensorflow_lite_support/tools/pip_package:build_pip_package` that I learned from https://github.com/tensorflow/tflite-support/issues/755

The command runs OK but eventually FAILED: Build did NOT complete successfully (7 packages loaded, 10 targets configured).

Thanks

Relevant log output
No response

Hi @febrifahmi !
Could you check the below command with Bazel 5.1.1 .
bazel build -c opt //tensorflow_lite_support/tools/pip_package:build_pip_package .
Thank you!

Unfortunately, I can't install Bazel 5.1.1 on my Raspberry Pi, as per information stated in Bazel documentation page installation on Raspberry Pi is using the latest Bazel ARM version supported by Bazel on arm package, which is now AFAIK only support Bazel version 4.2.2.

I'm unable to bootstrap Bazel 5.3.0 from the source. I will try another workaround to install tflite-support.

Hi @febrifahmi !
You can also install tflite-runtime or check the wheel from pintoo. for rasberry usage.
Thank you!

Thanks.. I'll try it. But it seems the binary are only for armv7l while my pi is the old armv6l.

@febrifahmi !
We are checking to see whether you still need help in this issue . There is also documentation on CMake through which you can cross compile with tool chains (Including Armv7 and Armv6) different to host os.
I suggest you to check these channels too ( CMake,Tflite-runtime,Pinto's wheel, TFlite-micro repo) to customize your builds.
Thank you!

Still has no luck with the building process of tflite-support using Bazel or Bazel on Arm, and I think I will skip the CMake method since I don't want to download all Tensorflow src to my pi while I only need selected features of tflite-support/tflite-runtime. Also, I cannot install tflite-runtime using virtualenv with both Python 3.7 and Python 3.9, and unfortunately, I don't use microcontrollers in this research project.

@febrifahmi !
Sorry for the inconvenience.
@sachinprasadhs !
Could you look at this issue.
Thank you!

Hi @febrifahmi
As this comment suggests, the PyPi wheels for tflite-support has been updated and the issue has been fixed.
Could you please try and let us know if you are still facing the issue?
Thanks.

I think we can close this issue for now.
Thanks.

Thanks for the confirmation. Please reopen if you'd like to work on this further.


[BUG] Payment failed, then ok, then pending. Sats never got returned to wallet after invoice expired.

Describe the bug
Hey guys, something strange happened to me a few days ago. I scanned an invoice with the web interface on my cell and got error 502. Next I used BlueWallet (connected to same LNbits wallet using LndHub) and the payment was marked as OK by BlueWallet.
However, the payment never went through (wallet balance shows that amount as withdrawn) and it stayed marked as pending on the web interface (<...>) and also in the database, in table apipayments. There's a row with that payment hash marked as pending [v].
Checking the node shows:
lncli trackpayment 195c2bad015dbd91f559ad750a9e3e6fc096b94fd419883b899a2793ca12eb41
[lncli] rpc error: code = NotFound desc = payment isn't initiated

So the payment never left the LN node.
To Reproduce
Can't reproduce as I don't know what happened to stop that payment going trough.
Expected behavior
I expect the sats to return to my wallet/balance and the transaction marked as failed after invoice expired.
Screenshots

Desktop (please complete the following information):

LNbits version: 0.10.9
Database: postgres

Additional context
I don't know if this is a bug or not. It could be a problem related to LndHub when it comes to BlueWallet acting as if the payment actually went through.
However, I expect the sats to be returned to my wallet and be shown in my balance after a pending invoice expires and the payment never got to leave the node.

hm, that previous message was kinda weird... is this issue resolved yet? i see its been a year since you reported it, we are now at 0.12.8

hm, that previous message was kinda weird... is this issue resolved yet? i see its been a year since you reported it, we are now at 0.12.8

Never got answered so not resolved for me. Any ideas?

We were not able to reproduce this issue and other users did not report it.
Closing it. Feel free to open it if it happens again.


CoTV_grid  example can't use sumo strategy playback

in ubuntu
Loading configuration... done.
***Starting server on port 48535 ***
Loading net-file from '/tmp/flow/debug/cfg/CoTV_1x1grid_20240522-1050491716346249.6291587.net.xml'... done (2ms).
Loading additional-files from '/tmp/flow/debug/cfg/CoTV_1x1grid_20240522-1050491716346249.6291587.add.xml'... done (23ms).
Loading done.
Simulation started with time: 0.00
Error: Could not build output file 'None/CoTV_1x1grid_20240522-1050491716346249.6291587-3-ssm.xml' (没有那个文件或目录).
Quitting (on error).

how to solve this issue

Hi Dr.Guo,
I'm running into the above issue when I'm using SUMO to visualize CoTV grid. The command I'm using _is _python _flow/visualizer_rllib.py /home/yl/ray_results/CoTV_1x1grid/PPO_CoTV-v1_adf813ac-2024-05-16_14-08-131egbi7e6 10  --horizon 20 , are you experiencing this kind of problem？and I'm looking forward to your guidance.
Thank you and good wishes.

Thank you,  I have already solved this problem.


Fixes falsy key value for batch get.

Related issue: #378

Pull Request Test Coverage Report for Build 577

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.09%) to 83.971%

Files with Coverage Reduction
New Missed Lines
%

lib/Table.js
2
77.05%

Totals

Change from base Build 576:
-0.09%

Covered Lines:
1844

Relevant Lines:
2124

💛  - Coveralls


Optimistic Concurrency strategy raise exception or try to merge documents

Currently when a save conflict is detected an exception is raised (if optimistic concurrency is enabled). Maybe we could minimize a conflict situation by adding an option to the merge the conflicted documents into one document and only raise an exception when a conflict is found during merging.
I think this option should have a documentstore default and can be overriden at document level or session level (or during SaveChanges(..) )
Something like this https://github.com/khalidsalomao/SimpleHelpers.Net/blob/master/docs/objectdiffpatch.md or https://github.com/wbish/jsondiffpatch.net could help with function

I'd vote to make that a completely semantically different operation.
Sounds like a great pull request;)


test: add canny test with blur

Coverage increased (+0.6%) to 95.359% when pulling 106675a3e2c6f79ea4a5b88bf3648724e0eda410 on canny_test into 1fc40ecfb5cd1eed68ebb18e736ae96c9d196b43 on master.

Coverage increased (+0.6%) to 95.359% when pulling ff58a65d1564bfe74f16fcc71c11a3c12496cabc on canny_test into 1fc40ecfb5cd1eed68ebb18e736ae96c9d196b43 on master.


No IDF Syntax Highlighting

I am unable to get the syntax Text Color and Highlighting feature to work for files with the extension .idf. I installing the language-energyplus package through the Atom Package Manager. The highlighting appears to be correct for .err, .idd, and ModelKit but the highlighting is missing for .idf.
I also tried uninstalling and reinstalling. Is this a know issue? Is there a simple fix?
Below are the language options I see when I try to change the language.

Hi @JShultz89, thanks for posting this issue. To apply syntax highlighting to IDF files, you should use the "Modelkit - EnergyPlus v9.0" language at the bottom of your screen shot. If that doesn't help, then we can set up a webinar so that you can share your screen and I can help you troubleshoot.

Hi @aaron-boranian even with the ModelKit-EnergyPlus v9.0 selected I do not see syntax highlighting. I am trying to load an EnergyPlus 8.9.0 file, could that be causing a problem?

No, loading a v8.9 IDF shouldn't impact the color highlighting (see screen shot below of a v8.9 IDF that I opened in Atom).

However, I will note that all of the auto-completed objects that are inserted by the package are for v9.0, which could have made changes to input fields (removing some, shifting them to different order, etc.) of objects you are using and cause your simulation to fail.
One other possibility is that your IDF is very large, and it's just taking Atom a while to load the file and apply the highlighting. However, you mentioned that you saw syntax highlighting in the IDD file, which is massive, so that may not be the culprit.
If you want to set up a webinar, my email address is<EMAIL_ADDRESS>

You might be onto something with the size of the file. I just checked the IDD file and realized that isn't loading either. I assumed it was because I saw the syntax highlighting option in the menu of my first message. I would love to setup a webinar to discuss more.


Customize row theme based on data

Hi,
I already use the customization of the theme like this:
var theme = createMuiTheme({       overrides: {         MUIDataTableBodyCell: {           root: {             fontSize: ".9rem",             fontWeight: "bold",           }         },         MUIDataTableBodyRow: {           root: {           }         }       },     });
but now I need to customize the row based on content like : column "date_end" is different from "" so backgroundColor: red.. I have found how do it possible based on the index but not we the data. Someone can help me? Thanks

@CaldeDaniele , did you find a way to change the background color based on the data in the grid. Appreciate if you can provide some insights

@AdminCortex take a look at this https://github.com/gregnb/mui-datatables/pull/307


Spikes Brave 5 conversion

This is CAMEL-10725
I still think the instrumentation could use revisiting, but the point of this change isn't to do that, rather to port the code to the new apis.
I would love for someone to pick this up and carry it over the finish line if possible.

Thanks a lot @adriancole for all the help with camel-zipkin here at ASF Camel.

For any remainder work you think is needed, you are welcome to post some details, create a JIRA or what it easiest for you. Then we know the outstanding work. And we sure welcome you to help - feel free to change what you think is the best for zipkin and camel-zipkin. The old code was outdated and its best we get help from such an expert as you - many thanks.

I'm trying the PR :-)

No worries folks. I'll probably spike another thing to take care of the service name mapping deal. Basically, the only way in-process propagation will work well is if there's one instance of tracing being used (most importantly one instance of CurrentTraceContext, which is provided by Tracing). The way things are written now, no other apps can read the traces. I will try to get something together to make it possible.


Enabling MacOS & iOS CI for example project

This lets us run MacOS & iOS CI for the example project.
Will update description with build link as soon as I'm kicking it off.

We really do need a common scripting language


Update API documentation

What's needed?
The API documentation needs to be updated, to expand it, and make it consistent with proposed updates in other Frequenz APIs. Refer to https://github.com/frequenz-floss/frequenz-api-dispatch/issues/60 and https://github.com/frequenz-io/api-weather-spec/issues/6 for the documentation style.
Proposed solution
No response
Use cases
No response
Alternatives and workarounds
No response
Additional context
No response

When writing docs, I strongly recommend trying out how it is rendered doing before merging stuff:
pip install -e .[dev-mkdocs]
mkdocs serve

Remember Markdown is used.


Init clean up and monkeypatch fix

__init__.py clean up and fix monkey-patches.
This should supercede PR #948 #951 #952

[x] Have you provided a meaningful PR description?
[x] Have you added a test, reproducer or referred to an issue with a reproducer?
[x] Have you tested your changes locally for CPU and GPU devices?
[x] Have you made sure that new changes do not introduce compiler warnings?
[x] If this PR is a work in progress, are you filing the PR as a draft?

Merging based on public CI.


Should default to current process when given no arguments

e.g. appear run without arguments should appear the pane with the current shell

Still fails on my box in 1.1.0:
kverdieck@kverdieck3-mbp:~/code/bedrock$ appear
/usr/local/lib/ruby/gems/2.3.0/gems/appear-1.1.0/lib/appear/command.rb:60:in `Integer': base specified for non string value (ArgumentError)
        from /usr/local/lib/ruby/gems/2.3.0/gems/appear-1.1.0/lib/appear/command.rb:60:in `execute'
        from /usr/local/lib/ruby/gems/2.3.0/gems/appear-1.1.0/bin/appear:11:in `<top (required)>'
        from /usr/local/bin/appear:23:in `load'
        from /usr/local/bin/appear:23:in `<main>'


RFC 1001: Update vs upgrade

There are two concerns that RFC 1001 covers:

The process of updating the installed server packages, which is done via edgedb server install --update in the current version of the RFC.

The process of upgrading an EdgeDB server instance (i.e a data directory) to a new (major) EdgeDB version, which is done via edgedb server upgrade in the current version of the RFC.

@ambv pointed out that a lot of the options in edgedb server install do not actually apply to the --update mode (e. g. you cannot do --docker --update if the initial install was ran without --docker). Hence, the suggestion to have a separate command for installed package updates: edgedb server update.  That, however, is very close to edgedb server upgrade and would be an endless source of confusion.  Another idea from @vpetrovykh is to name the package update command as edgedb server patch.
Also, worth noting that edgedb server install --update is intended to update the installed package to the most recent minor version for a given major version.
Open questions:

Should update be a standalone command or part of install?
If standalone, what is the best name?
What is the exact interaction of server upgrade with install and update?

I still think that keeping it in the install makes sense:

It's what you teach in tutorial: edgedb server install. --help will help you update installation. I would say that we should have edgedb server install --latest in the tutorial to update and/or install latest major (I assume that install will bail out as soon as any single version is present).
We should have server upgrade --install-latest for effortless upgrade, especially in docker (upgrade --patch can work, but since upgrade works with data, it's less clear what "patch" means)
I don't see updating the installation as a very different operation, I think this is an installation of a new version (rather than "patching")

I'd like to add a few words In defence of calling an update to the latest minor version a "patch". This procedure effectively gets you the latest patches to your current version, overwriting it. It is not possible to install several minor versions in parallel, so again, they are more like patches of a fundamentally same entity. They also don't require any fuss with data. Whereas major version upgrades are none of these things: major versions can coexist in parallel and they may require doing something to the data.
Rule of thumb is that you generally want to get patches ASAP, but may not necessarily want an upgrade in most software products and it seems to me that minor and major versions work like that for edgedb, too.

@vpetrovykh I agree with what you're saying. But I'm not sure that "patch" as a software update makes a lot of sense for developers who recently joined the field.

For the record, my suggestion for this was as follows:
e s install

enables to install a new specified version, you can say --latest if you don't know what that is
if a given version is already installed, idempotently declare success (return code 0)
if a given version cannot be installed side-by-side, return code 1 and direct people towards using e s upgrade
after successfully installing a version, we could always just add (unless --quiet) that "3 more versions installed" and/or "2 instances can be migrated to this version"

e s upgrade

by default upgrades all installed versions to their newest bugfix releases
if a higher non-bugfix release is available, informs: "a major version upgrade is possible, use --major to start it and migrate your instances"
it should be called "upgrade" because we might want to have "downgrade" in the future and "update" has no good equivalent

e s list [installed]

lists installed versions (and instances?)

e s list available

lists available versions

Why I think this is a good idea
Having one way to upgrade instances is safe. People won't run the wrong thing. And if they did mean --major and ran --minor by mistake, no foul, that should be entirely compatible. Plus, the tool will tell you that there's an available major upgrade path.
Having commands that only do one thing is easier to understand. It avoids combinations of arguments which don't make sense. It helps users state intent better. When they install a new vesion, the tool will tell them that this action did not upgrade their instances. They just have more versions available.
Other unsolved questions
e s upgrade --major would automatically migrate all instances from the old version to the new version. But if we ran e s install $NEW_VERSION before, should e s upgrade --major also migrate all instances?
I'm leaning towards yes but wanted to highlight this.

I actually like @ambv's approach, it makes sense to me.  I would add an option to do selective per-instance --major upgrade, though.

Admit it, you just liked my masterful use of Markdown.
But yeah, we should do selective --major upgrades, that makes sense to me.

Admit it, you just liked my masterful use of Markdown.

Guilty as charged :wink:

Also +1 to @ambv's way.

Having one way to upgrade instances is safe

This is the key. Having two separate commands to update to minor and to major seems confusing to me.

OK, so it seems we have emerging consensus.  I'll amend the RFC accordingly.


make routes in map

we need to make routes in this map  as uber applications

Direction is not supported in this plugin. You need to implement Google Directions API, then parse the result, and draw the route.
Many people do that easily.


fix: upgrade to version 3.0.714

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign ccojocar
You can assign the PR to them by writing /assign @ccojocar in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
d8940273c9a3d21c1d198cdec65103006295e1a8
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
d8940273c9a3d21c1d198cdec65103006295e1a8
link
/test gsm

vault
d8940273c9a3d21c1d198cdec65103006295e1a8
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Moved the To-Do list in the README

I think I agree that the TODO would make more sense in the main README (and actually better yet just become individual github issues?) but I think this would have to be re-submitted since the TODO files has changed.

I think GitHub issues would be the best way

@shiffman I updated the list to reflect the current one


Detect hand signal for domestic abuse

https://www.vicnews.com/news/video-this-hand-signal-alerts-others-to-domestic-abuse-without-a-word/

https://www.vogue.com/article/signal-for-help-womens-funding-network-abuse-coronavirus


Add 1024x600 resolution, please

Can you please make basic driver with 1024x600 resolution. Intel GMA 3600 doesn't have proper driver for win10, though basic driver is satisfying, but doesn't have apropriate resolution. Thanks in advance.

Can you please explain us how to add custom resolutions, or add SXGA+ (1400x1050) for my Centrino laptop now running Win10?

@arpcpro Seems that author had some possibility to sign altered driver and it was only for Win7. Now you (and me also) have no possibility to make driver ourselves, it will be unsigned which means always disable driver signing in win10. The only solution for me is just use Win7

Thank you Ginn13. But I would not mind to launch everytime Win10 in testmode. As long as I remember not to download and install all kinds of drivers in that mode it should be ok.

I'd also like this for 1024 x 600, I tried with IDA and found the PAGE: line but couldn't see the mov dword or how to edit it.

To the original poster: the hack described in this repository only edits the headless mode, which resolution was hard coded as 640x480 inside the driver. For physical monitors attached, the basic display driver supports the video modes defined by the VESA video BIOS of your device. And your device's manufacturer seems to be too lazy to present the proper video mode entries... this is not @microsoft 's fault. To support your laptop's device resolution which is absent from your video BIOS, you need to hack the video BIOS or its shadow RAM. 915resolution module from GRUB2 may help you do the latter; I had my GMA950 (had buggy driver not doing well under Win10 1703 & later) worked under 1440x900.
https://wiki.archlinux.org/index.php/GRUB/Tips_and_tricks#915resolution_hack

To the original poster: the hack described in this repository only edits the headless mode, which resolution was hard coded as 640x480 inside the driver. For physical monitors attached, the basic display driver supports the video modes defined by the VESA video BIOS of your device. And your device's manufacturer seems to be too lazy to present the proper video mode entries... this is not @microsoft 's fault. To support your laptop's device resolution which is absent from your video BIOS, you need to hack the video BIOS or its shadow RAM. 915resolution module from GRUB2 may help you do the latter; I had my GMA950 (had buggy WDDM1 driver not doing well under Win10 1703 & later) worked under 1440x900. https://wiki.archlinux.org/index.php/GRUB/Tips_and_tricks#915resolution_hack

@alicaccs i have the same issue and wanted to try what you propose, but the 915 resolution hack doesn't seem to be compatible with my hardware (see screenshot below), do you have any other idea to workaround this video BIOS issue?

@alicaccs i have the same issue and wanted to try what you propose, but the 915 resolution hack doesn't seem to be compatible with my hardware (see screenshot below), do you have any other idea to workaround this video BIOS issue?

8086:1237 seems to be (emulated) 440FX chipset... If it really resides in a VM, you should first check if you have proper VM integration inside your client Windows installation, like the Extension Pack of VirtualBox.


(maint) Make regex matching lazy for syntax highlighting

The regex used to match regexes in puppet uses (.+) to match one or more of
anything in between two slashes. However, if there is another slash anywhere
on the line after the regex the (.+) will match between the first slash of the
regex and the other slash that's not part of the regex.
An example:
/puppet-agent-5..*/ => 'puppet5/',
In that line the syntax highlighter will match everything between the first
slash of the regex and the slash in the string as one regex.
This commit changes the match to the following:
1: The (.+) matcher is made to be 'lazy' so that it matches the smallest
string possible.
2: The final matcher (?:/) is updated to include the negated set including
the backslash so that the final matcher matches a final slash with a
preceeding token that's anything except .
This should make the regex match the smallest possible string that begins with
/ and ends with / but does not end with /.

Thanks @McdonaldSeanp !!  Even has a test!! I'll look at this on Monday


Connect various analysis mode components

As we discussed today, we need to connect the various components to each other in the program flow (e.g., the Do Not Sell link analysis, current GPC status, sending GPC signal, ...). @kalicki1 will take the lead on this and @stanleymarkman and @OliverWang13 will chime in.

@OliverWang13, @stanleymarkman and I met today to discuss where we will be heading in the near future. Part of our discussion in how to connect all of our analysis components was to break down what type of data we will be saving and how to format it. A tentative outline for an analysis object structure is as follows:
{
  "wired.com": {  // DOMAIN LEVEL
    0: {
      "FIRST": {  // All of the info here will be scraped if privacy flag found
        "COOKIES": {},
        "DO_NOT_SELL_LINK_EXISTS": false,
        "HEADERS": {},
        "URLS": {},
        "USPAPI": {},
        "USPAPI_LOCATOR": {}, // Not sure if we need this here
        "THIRD_PARTIES": {
          "https://eus.rubiconproject.com/usync.html?us_privacy=1---": {
            0: {
              "FIRST": {
                "COOKIES": {},
                "HEADERS": {},
                "URLS": {},
                "USPAPI": {},
                "USPAPI_LOCATOR": {}
              },
              "SECOND": { ... }
            }
          }
        }
      },
      "SECOND": { ... }
    }
  }
}

A more expansive version with some example data filled in would look like:
{
  "wired.com": {  // DOMAIN LEVEL
    0: {
      "FIRST": {  // All of the info here will be scraped if privacy flag found
        "COOKIES": {
          "usprivacy": {
            domain: "www.wired.com",
            expirationDate:<PHONE_NUMBER>,
            firstPartyDomain: "",
            hostOnly: true,
            httpOnly: false,
            name: "usprivacy",
            path: "/",
            sameSite: "lax",
            secure: false,
            session: false,
            storeId: "firefox-default",
            value: "1---"
          }
        },
        "DO_NOT_SELL_LINK_EXISTS": false,
        "HEADERS": {},
        "URLS": {},
        "USPAPI": {
          "uspString": {
            uspString: "1---",
            version: 1
          }
        },
        "USPAPI_LOCATOR": {}, // Not sure if we need this here
        "THIRD_PARTIES": {
          "https://eus.rubiconproject.com/usync.html?us_privacy=1---": {
            0: {
              "FIRST": {
                "COOKIES": {},
                "HEADERS": {},
                "URLS": {
                  "us_privacy": "1---"
                },
                "USPAPI": {},
                "USPAPI_LOCATOR": {}
              },
              "SECOND": { ... }
            }
          }
        }
      },
      "SECOND": { ... }
    },
    1: { ... }  // 2nd time visiting wired.com for an analysis cycle
  }
}

As a note, the "FIRST" and "SECOND" keywords refer to the order in which we pull the us privacy string and other privacy flags in relation to sending the GPC signal. I.e., "FIRST" is the data collected from the site without the GPC signal, and "SECOND" refers to the site data collected after the site is refreshed with the GPC signal.

That is a good starting point. A few comments:

A lot of the data, e.g., httpOnly,sameSite, headers, ... we do not need. The data probably comes for free, and so we can collect it. But if there is implementation effort involved, I would suggest to only collect what we need.
The "FIRST" and "SECOND" keywords, do not really describe what they refer to, right? Wouldn't "BEFORE_GPC" and "AFTER_GPC" or something like that be better?
The object structure should also be extensible to accommodate other flags, e.g., OptanonConsent cookie (#225), Complianz CMP cookie ((#227), ...

Stanley is currently working on that.

Sub-issues of this issue are #225, #227, #228, and #229 ,and they will be addressed as part of this issue.

We are opening issue #233 in order to simplify our data so the frontend does not have to do any analysis of its own when rendering our results.

This issue is an architectural issue and dependent on resolving #225, #227, #228, and #229 first. Once they are essentially done, this issue will be connecting all the different functionalities from those.
#233 is not a dependency here but important in this context.
So, @kalicki1 will come back to this issue once the other ones are addressed.

Since this is essentially resolved sans handling signals from CMPs (the four issues mentioned above), I will go ahead and close this issue and leave those four particular issues open as their own stand-alone things.


Stack Overflow on sending message

Hey. I saw other stack-overflow issue, but it was related to different part of the code. I still have this issue reproducible on windows with Visual Studio toolchain (2022 Preview, rust version 1.61.0, Windows 10 21H2). API response serialization fails after sending message.
This is happening at telegram_api_impl.rs:51:
    pub fn decode_response<T: serde::de::DeserializeOwned>(response: Response) -> Result<T, Error> {
        match response.into_string() {
            Ok(message) => {
                let json_result: Result<T, serde_json::Error> = serde_json::from_str(&message); // < here

Here is (slightly modified) message that was causing this. It isn't even that large.
"{"ok":true,"result":{"message_id":101,"from":{"id":661885372,"is_bot":true,"first_name":"________________","username":"________________"},"chat":{"id":281814033,"first_name":"____","last_name":"__________","username":"_________","type":"private"},"date":1654353153,"reply_to_message":{"message_id":98,"from":{"id":281814033,"is_bot":false,"first_name":"____","last_name":"__________","username":"_________","language_code":"uk"},"chat":{"id":281814033,"first_name":"____","last_name":"__________","username":"_________","type":"private"},"date":1654352592,"text":"doom"},"text":" Doom \ud83d\uddd7  \nMain Story: 11\u00bd Hours \nMain + Extra: 16 Hours \nCompletionist: 26 Hours \n\nDoom \ud83d\uddd7  \nMain Story: 5 Hours \nMain + Extra: 7 Hours \nCompletionist: 9 Hours \n\nDoom Eternal \ud83d\uddd7  \nMain Story: 14 Hours \nMain + Extra: 19 Hours \nCompletionist: 26 Hours \n\nDoom II Hell on Earth \ud83d\uddd7  \nMain Story: 7 Hours \nMain + Extra: 9\u00bd Hours \nCompletionist: 14 Hours \n\nDoom 3 \ud83d\uddd7  \nMain Story: 11 Hours \nMain + Extra: 12\u00bd Hours \nCompletionist: 16 Hours","entities":[{"offset":0,"length":1,"type":"text_link","url":"https://howlongtobeat.com/games/doom_2016.jpg"},{"offset":1,"length":4,"type":"bold"},{"offset":6,"length":2,"type":"text_link","url":"https://howlongtobeat.com/game?id=2708"},{"offset":84,"length":4,"type":"bold"},{"offset":89,"length":2,"type":"text_link","url":"https://howlongtobeat.com/game?id=2701"},{"offset":163,"length":12,"type":"bold"},{"offset":176,"length":2,"type":"text_link","url":"https://howlongtobeat.com/game?id=57506"},{"offset":253,"length":21,"type":"bold"},{"offset":275,"length":2,"type":"text_link","url":"https://howlongtobeat.com/game?id=2711"},{"offset":351,"length":6,"type":"bold"},{"offset":358,"length":2,"type":"text_link","url":"https://howlongtobeat.com/game?id=2704"}]}}"

It looks like that json size may become pretty large if you have a lot of links, I would assume that relaying on having enough stack-size isn't ideal.
When running under my Debian WSL it is working fine, but I presume that larger messages may fail there as well.

@amadare42 thanks for reporting. I'll work on this tomorrow.
I hoped https://github.com/ayrat555/frankenstein/commit/abab2128a4296a0aeec13f6820f1283a317a8c91 fixed the problem.
but probably we need to resolve https://github.com/ayrat555/frankenstein/issues/63
btw are you sure you're using the latest version of the library?

@ayrat555 sorry, I somehow forgot to mention version of library itself.
I was using version 0.15.0. Does 0.15.1 have fix for this issue?

no, unfortunately, it doesn't
can you please also share the method and params that you used so I can try reproducing it

Here is branch with application where this issue reproducible: https://github.com/amadare42/rust-hltb-bot/tree/so-issue
Steps are simple:

Set API_KEY env parameter
Send message "doom" to your bot

@amadare42 I was able to reproduce the issue.
I created a pr which fixes the problem
can you please confirm that it works for you?

@ayrat555 yep, that fixed it - issue isn't reproducible for me anymore. Thanks!

Great. Let's wait for @EdJoPaTo's review and then I'll merge it

@ayrat555 update: I managed to get SO on get_updates. :)
I guess, adding serde-stacker there as well would be good idea as well. I updated my so-issue branch - steps are the same.

I implemented another fix.
can you please try it?

@ayrat555 yep, now it is working. Thank you again! :)

released in 0.16.0


add hint to explain how to enter time between updates

I was very confused by defining time between updates while I was playing with Portainer, so here is my proposal. Tested with Docker 17.06.0-ce

Just read contribution guidelines, let me propose this fix in a proper way.


Forking the repository produces Invariant Violation: View config getter callback for component RNSVGGroup must be a function (received undefined).

Help
For an app i'm currently working on i need to add some little things to this library, so i tried forking the repository then i added the local dependency to a react native app in package.json like that:
"react-native-svg": "../react-native-svg"
But if i try to run the app on the android emulator this is the result:

And i can't understand why, installing the library from npm works fine and i haven't changed anything yet

How do you solve it?

If i remember right the problem was that i was doing npm install inside the package directory, i tried without doing it and it worked

Thank you for your fast response, you're saving my life. It looks like we (or at least I) can't add these package as a direct dependency in a module.


Fixed typo in README.md

Thanks @cvibhagool!  We need the capacity to get a release out. I'll rebuild it when we have the resources.

Thank you very much!


Begin adding spanned metadata to parses

Introduction
This PR makes a breaking API change that begins adding spanned parse results to each parser and expecting enumerated input for the parse data.
Linked Issues
#60
Dependencies

[ ] Fix Doc tests

Test

[ ] Tested Locally
[ ] Documented

Review

[ ] Ready for review
[ ] Ready to merge

Deployment

Going to rework the implementation a bit more. I think there is no need for the SpanndedMatchStatus. This was a poor design decision


Need option to download old versions of VSC portable

There is no option do download older versions of VSC portable just .exe to install.
https://code.visualstudio.com/updates/v1_45
I need this due that VSC is hudge, new changes made that many extension not runing own changes on the time and mode complications.
The best is to offer some release versions on github maybe.

Simply take the following URL and replace with the desired version:
https://update.code.visualstudio.com/1.37.1/win32-x64-archive/stable

@joaomoreno thx
HVR in case when I working on v 1.44.2 and exist version betwen this as 1.45, 1.46 we see in portable option to Download new version, but not sure what as 1.45, 1.46 in case I'm waiting maybe 1.47 or 1.48. I know that I can check on website, etc. but it's good to know maybe to check on VSC what we can update.


Backwards compatibility

https://github.com/gibson042/ecma262-proposal-well-formed-stringify#backwards-compatibility states this change is backwards compatible. That’s only true if we assume JSON.stringify output only ever gets consumed by spec-compliant JSON.parse implementations or userland alternatives.
I wouldn’t be surprised if this change ends up breaking something. I’d suggest rephrasing the FAQ section to state as much. Let’s explicitly acknowledge that we’ll really only know if/when a browser tries to ship it.

Man, you beat me to this. I was on my phone and it was too much typing.

Let’s explicitly acknowledge that we’ll really only know if/when a browser tries to ship it.

It's unfortunately not at all backwards compatible. AMP's codebase will break due to this, and I'm sure hundreds of others. It's very common to assert the JSON.stringify output is equal to some string, as hacky deep equality equals. Anything that uses a surrogate pair will then be broken.
const obj = {
  example: "test💩"
};

assert.equals(JSON.stringify(obj), `{"example":"test💩"}`);

We _might_ be able to get away with encoding lone surrogates (I don't think I've ever created one on purpose). But paired will definitely cause problems.

Hmm… I’m worried mostly about production code, and am not terribly concerned about test suites (especially if they use hacks like the above, and even less so when they’re actively maintained).
Options:

In its current version, the proposal escapes every single surrogate, regardless of whether it’s a lone surrogate or part of a surrogate pair.
We could extend this to escape every symbol that is not printable ASCII. This would make JSON.stringify’s output ASCII-safe.
We could be more conservative and only escape lone surrogates. This would complicate the spec slightly, as we’d need to peek at the next code unit for every high surrogate.

Oops, it was a mistake on my part. The intent is to replace only unpaired surrogates with escape sequences. Will fix shortly.


docs: move BigQuery to user docs

Per #16541.

Might be surprising to find this under "API Reference", should we rename that to be "APIs & Datasets" or something similar?

SGTM!


pull request for e2e test at 12/28/2016 11:56:06

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


npm run dev无法启动

The following dependencies are imported but could not be resolved:
highlight.js (imported by /Users/keyin/code/vite/vue-admin-box/src/views/main/components/mdEditor/index.vue?id=0)
Are they installed?
出现上面的提示

the first thing you need to do is : yarn or npm install;

Thank you.
I had used npm install, it looks not like a npm problem.

use yarn can help you to fix it.


Is there any way to let laravel-mix transpile third party js files?

Laravel Mix Version: 0.9.2

Node Version (node -v):  v6.9.4

NPM Version (npm -v):  3.10.10

OS: Cent OS 7.3

Description:
I am new to Laravel and Vue. and currently I use Larave5.4 + Vue 2.0 to develop a website.
I imported a third party UI component, which is from vue-strap.
Everything goes well on Chrome, Safari and Firefox.
However, because IE11 doesn't support ES6, and the js files in vue-strap lib are written in ES6,
there are erros on IE11.
I thought Laravel-mix will compile all the file into ES5 format.
But when I check the app.js file, those js files in vue-strap lib are not transpiled into ES5.
My .babelrc in the root is as below.
{
"presets": [
["es2015", { "modules": false }],
],
"plugins": ["transform-es2015-destructuring", "transform-object-rest-spread"]
}
My understanding is that laravel-mix will compile all the js and vue files including those imported from the third party lib based on .babelrc into public/js/app.js. Am I right?
But in my case, it seems that larabel-mix only compile the js and vue file of own project.
Thus, I have to manually compile third those js file into ES5 format,then run [npm run dev] to complie all js files into app.js. This will solve the problem.
My question is that is there any way to let laravel-mix compile all imported js and vue files from third party lib as well?

Can you try deleting your custom .babelrc file entirely and trying again? Does that change the output?

@JeffreyWay Thanks for your reply. I have tried but no luck.

I met the same problem.Use babel app.js -o app.es5.js, but it's not cool...233

You do not need the .babelrc file because Laravel Mix handles ES6 compilation on its own.
Check package.json and the babel-loader is already in there.
And here is all that's needed.

@ruchern The question is not all scripts are compile into ES5 format, if you delete .babelrc or not.

Add {     test: /\.js$/,     loaders: ['babel-loader']   },
in your webpack.config.js , it works!
@larryu

@Anluis Thanks mate. This works. Seems a good way to solve this issue.


ci: skip some CI builds when only changed to documents and OWNERS files

What problem does this PR solve?

Issue Number: ref PingCAP-QE/ci#2129

PingCAP-QE/ci#2129

What is changed and how it works?
update check and build and cdc integration test github workflows: skip triggering when only changes to markdown files or OWNERS files.
Check List
Tests

No code

Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note
None

/label ?

/label needs-cherry-pick-release-7.1

/retest

/check-issue-triage-complete

/retest

/run-check-issue-triage-complete

/run-check-issue-triage-complete
/check-issue-triage-complete

/cc hi-rustin


Crash when refreshing browser in 4.1.0/4.1.1

Our node app seems to work fine regarding refreshing from the broser in v0.12.7 of node, even when the npm install was done on node v4.1.0, however, the same application with no other changes than switching to use v4.1.0 or v4.1.1 of node crashes nearly always when trying to do a refresh.  The crash is :
assert.js:89
throw new assert.AssertionError({
^
AssertionError: false == true
at ServerResponse.resOnFinish (_http_server.js:474:7)
at emitNone (events.js:67:13)
at ServerResponse.emit (events.js:166:7)
at finish (_http_outgoing.js:529:10)
at doNTCallback0 (node.js:407:9)
at process._tickDomainCallback (node.js:377:13)
I am stumped from this point, not knowing the internals of sails or node well enough to know what is going on, nor whether even the problem is with sails, or with node.  Given it seems to be crashing inside _http_server.js, I am guessing that no matter what it shouldn't be doing this from any sort of request the browser might make, so I am leaning to thinking it is a problem with node.  But an opening the issue here to see if anyone has any thoughts/suggestions.
Thanks!

Found out I had a very old sails v0.10.4 installed outside of nvm which I forgot entirely about, once I removed it, all seems to be good!

Just a quick note to anyone else who might come across this issue.  The issue was actually NOT the very old sails v0.10.4 that I had lurking around I think, but rather related to this issue : #3221
This seemed to not manifest with crashes in node 0.12.7, just the browser hanging.  But when I ran under node 4.1.1, it was crashing node with the error above.  Switching to sails v0.12.0-rc3 fixed the problem, so I am imagining that the version of express used in 0.11.x of sails was the root of the problem.  Not to mention the browser no longer sometimes hangs so the application is pretty snappy on a refresh again.

Just to confirm with you @robgrimball Sails works under Node 4.1.1 with v0.12.0-rc3 (and possibly higher) of Sails?

Sorry for the late reply.  I actually found we were having too many other issues with 4.1.1 and sails 0.12.0-rc3 to warrant continued use, so we backed off to node 0.12.7 and sails 0.11.2 I believe.  This crash did seem to be greatly reduced when using sails 0.12.0-rc3, but not totally eliminated, but also the problem seems to be more of an express/node issue than sails.

related https://github.com/balderdashy/sails/issues/3221


UIFontIcons.ttf Update Process

Hi:
I want to add some icons to this file but it would be great to have specifics in terms of icons used, configurations and in general how to update this file.
Thanks,
Luis

Hi Luis,
Greetings from Syncfusion.
For your information, most of the web tools to enhance the icons support are not supporting to edit the existing ttf/otf file to include desired icons. In case of urgency, please share your desired icons file as ai or SVG, we will work for you and update.
Regards,
Yuvaraj

Here are the ones I would like.
Desktop.zip

Hi Luis,
Thanks for your patience.
As per your requirement, we have included the provided font icons in our existing font icon file (UIFontIcons.ttf). Please fine that from the below link.
FontIcon
Regards,
Yuvaraj


Fix spelling errors

i dont think its ready to be merged, i might need a second opinion

seems to have some merge issues might fix later

dont know if this is ready to be merged yet

might fix later

this might be ready to merge, still preparing main branch

no dsicrption proided

no dsicrption proided

I see!

hi

LBTM (looks bood to me)

Lstm (looks Sarah to me)

LSTM (let's steal the monstitution)

This PR sounds pretty cool. Any thoughts/

@CEO-Chair thoughts: revoke

hi

@CEO-Chair, can we get a review before merging? LGTM

can we get a review before merging?

yeah sure


Is it possible to generate visual observation corresponding to the textual observation?

Thanks for your help!

@PeterAJansen can correct me if I'm wrong, at the moment there's not easy way to generate a visual observation from the textual description.

Sorry to be slow responding to this one.  I can't think of an easy way of doing this in ScienceWorld, but we have just released DiscoveryWorld that includes both text (i.e. JSON) and proper visual (2D tile-based) observations.  Here's the link for DiscoveryWorld: https://github.com/allenai/discoveryworld
If it /must/ be ScienceWorld that has the visual observations, the potential ways forward that come to mind are:

Manually build a visualizer that has every object in it.  This is similar to how DiscoveryWorld works, and the various Nethack/etc visualizers.
Try to put together something automatic with Dall-E/etc., that takes the text observation as input, and produces an image as output, with some bias to whatever past generations looked like to try and make it somewhat consistent across steps.


Connectivity - AD Connect NAT to DC Not supported

Please confirm and add requirement...
Question: I have a multi-forest environment and the network between the two forests is using NAT (Network Address Translation). Is using Azure AD Connect between these two forests supported?
Answer: Using Azure AD Connect over a NAT is not supported.
From <https://cloudblogs.microsoft.com/enterprisemobility/2015/12/18/azure-ad-mailbag-syncing-with-azure-ad-connect/>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a763c4bd-b754-f8e2-2c34-a3972a583fbb
Version Independent ID: 7be77d14-5d29-948b-ff20-24bfd046f7e9
Content: Azure AD Connect: Prerequisites and hardware
Content Source: articles/active-directory/connect/active-directory-aadconnect-prerequisites.md
Service: active-directory
GitHub Login: @billmath
Microsoft Alias: billmath

Thanks for your feedback! We will investigate and update as appropriate.

Hi, I'm sorry but I am having trouble understanding - what exactly is your feedback? As you said, AD Connect over a NAT is not supported.

Hi @MarileeTurscak-MSFT it might be helpful if this added to this page so it is clearly called out. Just an idea. :) 👍

@billmath are you looking into this? Can we close this issue?

@MarileeTurscak-MSFT and @JBines
Yes thank you for this.  This is scheduled to get added but it may not be until after Ignite.  We have some high-pri items for Ignite and using Azure AD Connect over NAT is not very common.  I will leave this open until it has been added.  Feel free to ping me in a few weeks if it hasn't been added yet.  Thanks!

Thanks @billmath for the update

@kenoby-dev actually yes.  This change is scheduled for today once I get final confirmation from engineering.  Because the list of what is "not" supported can get quite long, we avoid putting this in the pre-req docs and only document what "is" supported.  So this will be going into the FAQ here:  https://docs.microsoft.com/en-us/azure/active-directory/hybrid/reference-connect-faq
I will follow-up later today once it is merged and ready to go out.

Thanks @billmath I see the FAQ has been updated which is the right place for this good call! I believe it is more common than we are aware of (at least I have seen it more than once) so it’s good to see it called out more clearly. a good question for the raas/rap perhaps.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Bill Mathers<EMAIL_ADDRESS>Sent: Friday, November 2, 2018 3:04 pm
To: MicrosoftDocs/azure-docs
Cc: Joshua Bines; Mention
Subject: Re: [MicrosoftDocs/azure-docs] Connectivity - AD Connect NAT to DC Not supported (#13678)
@kenoby-devhttps://github.com/kenoby-dev actually yes. This change is scheduled for today once I get final confirmation from engineering. Because the list of what is "not" supported can get quite long, we avoid putting this in the pre-req docs and only document what "is" supported. So this will be going into the FAQ here: https://docs.microsoft.com/en-us/azure/active-directory/hybrid/reference-connect-faq
I will follow-up later today once it is merged and ready to go out.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/13678#issuecomment-435390229, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AmLUwoQ5GJeZblMnjw0Sco8fGSM-9l3oks5urFDlgaJpZM4WD9_q.

@JBines, @kenoby-dev Thanks for the feedback!
This is now live.
#please-close


Upgrade Go to 1.21

This includes updating the Go ref in go.mod as well as selected Go versions in .github workflows.
Note that, due to the change in import and init func ordering changing in Go 1.21, the grpc proxy proto codec is  no longer registered after the grpc internal proto codec definition, meaning the dapr custom definition will not be registered and will cause errors. The custom proto needs to be either re-registered at runtime, or change its name in order to fix this.
There is likely other errors which need resolving when upgrading to 1.21.

/assign

CLI upgrade PR https://github.com/dapr/cli/pull/1331

@JoshVanL you mentioned you'll do the runtime Go 1.21 migration correct?
I completed the contrib Go 1.21 migration: https://github.com/dapr/components-contrib/pull/3251
We will not be able to pin contrib anymore until runtime is also migrated, so it's high priority now.
You may want to use the updated linter configuration from here: https://github.com/dapr/components-contrib/blob/main/.golangci.yml
For consistency, please switch to Golangci-lint v1.55.2 which we now use in contrib. You will need to switch linter version for Go 1.21 support.


ERR_PACKAGE_PATH_NOT_EXPORTED

I'm trying to run this package on a project and have been running into this error:
✖ Nuxt Fatal Error                                                                                │
│
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './module' is not defined by "exports" in
<EMAIL_ADDRESS>I have tried many different versions of node, npm and nuxt with no success. I am unable to use Nuxt 3 as it is for a project that requires stability.
Here are my dependencies in package.json:

and how I have it configured in nuxt.config.js:

Does anyone have a solution to this? It's driving me crazy.

Yes. You need to install the previous version of @nuxtjs/sanity: ^0.1.1. Docs for this version are available at https://v0.sanity.nuxtjs.org/.

I had done my install per the setup instructions per that doc and I was trying to find any mention of versioning and couldn't find that.
Thanks for the answer. That fixed it!


Expose a python-based client API

Description
This PR implements #48, to define a python-based client API to read and write messages from a Kafka broker. The way it's done is to have a small wrapper around the genesis client, allowing us to implement different defaults and further down the line, control which messages are allowed without expecting the genesis client to do so.
In doing so, I have also implemented data classes for GCN Circulars and VOEvents to define the structure of messages, which are used within scimma publish for the circulars.
Additionally, there has been some restructuring in the test suite to avoid repeating code.
This can merged independently of #5, and the test suite restructure may help out there as well.
One example:
    from scimma.client import stream
    with stream.open("kafka://hostname:port/topic", "r", format="json") as s:
        for idx, msg in s:
             print(msg)

    with stream.open("kafka://hostname:port/topic", "w", format="json") as s:
        s.write({"my": "message"})

Checklist

[x] All new functions and classes are documented and adhere to Google doc style (3.8.3-3.8.6 of this document)
[x] Add/update sphinx documentation with any relevant changes.
[x] Add/update pytest-style tests in /tests, ensuring sufficient code coverage.
[x] make test runs without errors.
[x] make lint doesn't give any warnings.
[x] make format doesn't give any code formatting suggestions.
[x] make doc runs without errors and generated docs render correctly.
[x] Check that CI pipeline run on this PR passes all stages.
[ ] Review signoff by at least one developer.

NOTE: If this PR relates to a release, open and reference an issue with the Release checklist template.

This looks good from the tests -- I ran them all and it passed. But following the commands from the quickstart, I couldn't read/write messages to the broker (the Python prompt would hang). I'm not sure if this is an issue with my environment, so I'll look into this more.
I didn't test the VOEvent data model yet, which would be good to try since it isn't included in the tests (or publish.py) so far.

@bfc5288, great, thanks for looking this over. As for the quickstart example, did you spin up the server with the --noSecurity option or with SSL enabled? There's some funny business using the client (and not limited to this, with kafkacat as well) where the client would hang if the SSL configuration was either misconfigured or due to having issues with the container.
As for the VOEvent model, I wouldn't get too hung up on that yet. I added that in there in preparation for #43 and #44, and don't have a good way of verifying the schema without making headway on those issues. I don't expect issues with the dataclass itself but possibly in how the schema is structured.

I redid the quickstart with the --noSecurity option to remove that variable (I had it enabled during the first test). The write functionality works, as:
with stream.open("kafka://scimma-server_noSec:9092/gcn", "w", format="json") as s:
    s.write({"my": "message"})

I can read the message with kafkcat: kafkacat -C -b scimma-server_noSec:9092 -t topic, but not with the read functionality:
with stream.open("kafka://scimma-server_noSec:9092/topic", "r", format="json") as s:
    for idx, msg in s:
        print(msg)

(this hangs without returning the message as expected).
And that's fine about VOEvent -- we can look at that later when we're working with that format.

Yeah, so I realize now that the quickstart would be confusing now without some context as to what's going on. There's an extra option needed if you want to read in messages sent before you spun up the consumer as follows:
with stream.open("kafka://localhost:9092/test", "r", format="json", start_at="earliest") as s:
    ...

I'll edit the quickstart accordingly and add more context so users aren't confused by the hanging feature.


Add workflows for PRs and releases

The release one isn't quite right yet, just need to figure out the right trigger for it.

That should fix it now.

Copy and paste got me there. I'll get that fixed and add Mac too. I'd left it off initially as I didn't see support for it in upx but might have overlooked it, though its probably worth building them anyway and letting people get them from github if needed.


cuda 8.0 and cudnn 5.1 (or 5.0) installation problem

there seem to be a few users with this issue.
new gtx 1070, installed cuda 8.0 and cudnn 5.1 ( echo $LD_LIBRARY_PATH gives /usr/local/cuda-8.0/lib64 and the files are in there) yet I get this error using cudnn as backend:

84: /home/rayset/torch/install/share/lua/5.1/cudnn/ffi.lua:1597: 'libcudnn (R5) not found in library path.
Please install CuDNN from https://developer.nvidia.com/cuDNN
Then make sure files named as libcudnn.so.5 or libcudnn.5.dylib are placed in your library load path (for example /usr/local/lib , or manually add a path to LD_LIBRARY_PATH)

I've tried all day, I'm on ubuntu 16 so I had to mess with gcc and g++.
Firstly I installed cudnn 5.1, then I added (but not removed the old ones) cudnn 5.0. could this be the problem? @jcjohnson says he managed to install cudnn on his titan x and 1080, so I guess it's doable.
thanks for any help :)

I haven't tried it with cuda 8.0, especially because it's still a release candidate.
Have you tried it with 7.5?
Also, cudnn 5.1 shouldn't give an error in my experience.

I read that cuda 7.5 doesn't work with pascals. Am I wrong?
Il 07/set/2016 23:56, "Besir Kurtulmus"<EMAIL_ADDRESS>ha
scritto:

I haven't tried it with cuda 8.0, especially because it's still a release
candidate.
Have you tried it with 7.5?
Also, cudnn 5.1 shouldn't give an error in my experience.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jcjohnson/neural-style/issues/319#issuecomment-245432164,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AI-W1xZ9dwhzWVdP3qngRyOEzdncwi7Gks5qnzMQgaJpZM4J3TDI
.

anyway here's what is in my cuda folders, maybe it can help:
cuda-8.9/include: http://pastebin.com/1wuDgPmp
lib64: http://pastebin.com/bMKuXCk6
the files with the same name should all be from cudnn 5.0
here's my path:
/usr/local/cuda/lib64:/usr/local/cuda-8.0/lib64:/home/rayset/torch/install/lib:/home/rayset/torch/install/lib:

it seems the solution was quite simple. I will write it here so future users can find it.

`export CUDNN_ROOT="/usr/local/cuda-8.0/lib64/libcudnn.so.5" # you can maybe add this line into ~/.bashrc for future use
luarocks install cudnn`

if you don't know how to edit  bashrc  just  enter in terminal
gedit ~/.bashrc
and add that line at the end.


fix(schema) service url should cleanup existing url components

Summary
Issue #5313 opened by @granularmike1 describes a bug in admin api where patching a service with service.url does not cleanup existing data.
E.g.
http PATCH :8001/services/my-service url=http://example.test

Doesn't clean service.path if it was previously specified. This is unexpected when the url sugar parameter is used.
Issues resolved
Fix #5313

This should have been merged to master, not next :(


Client Allocation Request for: qjkx

Client Allocation Questions
Core Information

Name: qjkx
Website / Social Media: qjkx, (qjukx, qjkx)
Region: Africa
DataCap Requested: 192 GiB
Addresses to be Notarized: f56484568454
Notary Requested: Simon

Application created via filplus.storage

This user’s identity has been verified through filplus.storage


Door sensor choice

Maybe in my situation:

2 door sensor with thermometer feature.
1 door sensor without thermometer

This page has a comparison in tabular format http://darwinsden.com/best-of-the-z-wave-door-and-window-sensors/
After having some thoughts, there may not be many differences feature-wise. So I'm trying 1 for with/out thermostat and see how they work.

Ring com gen2 is $29 and verified that it works with non ring controller. I might stick with it.


API for setting password

GraphQL mutation to set/change password.
For a regular user require existing password to be provided (as well as new password).
For an admin no existing password is needed.

Assume for now that we don't need to offer the capability to sign out all sessions/devices as part of calling this mutation.
i.e. no need for a replacement for the logout_devices option of POST /_matrix/client/v3/account/password

API should look like this:
mutation {
  setPassword(input: { userId: "ID", currentPassword: "pwd", newPassword: "pwd" }) {
    status,
    user { .. }
  }
}

Where currentPassword is needed when the requested doesn't have admin capabilities.
To implement this, one would need to:

put the PasswordManager in the mas_graphql::State. This is particularly annoying, as this currently lives in the mas_handler crate, which isn't accessible from the mas_graphql crate because else there would be a dependency loop
add a mutation in crates/graphql/src/user.rs
it should check if the requester is admin or is accessing their own user
if the requester is not admin:

it should check that the SiteConfig allows password change
it should check that the currentPassword was provided and validate it


Alert capture count

Fixes Count according to Capture.ID and add warning to the UI when capture.count is equal to 0

rerun functional-tests-backend-orientdb

LGTM

tested by adding and removing node, working cool. thanks!


Updated Readme.md to include Print Our Home

Adding start-up Print Our Home aiming to print habitations using ecological 3D printing technologies.

Thanks for adding us!

woot

Don't forget to add yourself, @dionnel666!


Missing golems.parts package

The thaumcraft.api.golems.parts package is missing, though it's depended on by IGolemProperties.

This repository doesn't seem to be up to date with the latest API published on the MinecraftForums thread.  Probably best for now to get the .zip of that and unpack it into your source tree.
Thread:
https://www.minecraftforum.net/forums/mapping-and-modding-java-edition/minecraft-mods/1292130-thaumcraft-6-1-beta13


s3-Not-Found-Issue

Found that from the file_api that the stow.ErrNotFound was not getting returned for files that don't exist.

nice find 👍


Connection pool hangs if authentication fails

When using a connection pool with tokio_postgres, the connection hangs until a TimedOut error is returned if the password is incorrect. This behaviour is undesirable and should just result in authentication failure.
To re-produce, simply try connect to any database using an incorrect password and the connection will hang until it times out.

I've spent a bit of time looking into this while debugging some TLS connection issues.  It is decidedly not a simple fix, unfortunately.  There are a few things that I've been doing to make life a little bit easier, however:

If your deployment allows it, set Builder::min_idle to require at least one open connection before considering the Pool ready.  Consider testing the connection parameters on startup with a short-lived pool and very low timeout.
Be sure to register an ErrorSink with the method Builder::error_sink which will give you an opportunity to log errors that otherwise would fall off the table.
Also, I'll be taking a look at using the crate bb8_failsafe here for more proactive connection error management.

The touchpoint for the issues is at PoolInner::add_connection here: https://github.com/djc/bb8/blob/573773618af310b31dd248abbc6153a26389e007/bb8/src/inner.rs#L199-L225  This is the code that ultimately calls into the ManageConnection impl to make the connection, and (in the case of an error) keeps trying until it gets one successfully or the pool's connection timeout expires.
The right behavior in the general case is to delay returning any error until the timeout, but it would be great if there were a way to identify particular classes of errors that shouldn't wait for the timeout.  It seems like that would require cooperation from the ManageConnection impl, which means it would require a new trait method (say something like fn error_is_fatal(&self, e: Self::Error) -> bool { return false; } which could then be used to exit early.  Then we could override the default impl of that trait method where appropriate.  Unfortunately for my use-case (bb8-postgres) the tokio-postgres crate does not expose error details in a way that could reasonably be used for this purpose.  Long story short, doing this would be a lot of work.

As a side note @djc or anyone else looking more deeply, this call stack is Pool::get => PoolInner::get => PoolInner::make_pooled => PoolInner::spawn_replenishing_approvals raises my eyebrows.  In particular, it seems like the waiter ought to be a Result channel so that a root cause can bubble back up.  As it is, we lose the original error even in cases where we are actively waiting for the connection, which does not seem to be the intent of spawn_replenishing_approvals.
https://github.com/djc/bb8/blob/573773618af310b31dd248abbc6153a26389e007/bb8/src/inner.rs#L138-L139

As a side note @djc or anyone else looking more deeply, this call stack is Pool::get => PoolInner::get => PoolInner::make_pooled => PoolInner::spawn_replenishing_approvals raises my eyebrows. In particular, it seems like the waiter ought to be a Result channel so that a root cause can bubble back up. As it is, we lose the original error even in cases where we are actively waiting for the connection, which does not seem to be the intent of spawn_replenishing_approvals.

That sounds sensible. Want to propose a PR?

That sounds sensible. Want to propose a PR?

Happy to work something up.  Since the waiter is stored in internals::PoolInternals and the error pops up in inner::PoolInner::spawn_start_connections, I think the move is to replace this line that throws to the error_sink https://github.com/djc/bb8/blob/573773618af310b31dd248abbc6153a26389e007/bb8/src/inner.rs#L67
with a call to a new method on SharedPool that looks roughly like:
impl<M: ManageConnection> PoolInternals<M> {
    fn forward_error(&self, err: M::Error) {
        let mut locked = self.internals.lock();
        while let Some(waiter) = locked.waiters.pop_front() {
            match waiter.send(Err(err)) {
                Ok(_) => return,
                Err(e) => err = e,
            }
        }
        self.statics.error_sink.sink(e);
    }
}

Might be worth an issue against tokio-postgres? I would definitely be open to adding an error_is_fatal() like hook to the ManageConnection trait.

It looks like it has been discussed a few times (sfackler/rust-postgres#571, sfackler/rust-postgres#583, sfackler/rust-postgres#790), though usually in a different conted.  There's even another project that is trying to do exactly the same thing: https://github.com/palfrey/wait-for-db/blob/c3fb9dbad94f06f91f83d6ef9e4af0b93ef64083/src/pg.rs#L34
In at least one case a PR was merged that exposed a limited interface to the error kind (sfackler/rust-postgres#739) so it's reasonable to think a similar PR would be well received.

Yeah, the forward_error() approach seems reasonable. Should probably verify all sink() callers (at least in PoolInner) to see if they should use this.

Hmm, it's not so easy, I guess.  The above strategy works, but only if the user has configured retry_connection(false).  If not, in practice we hit the "outer" timeout on the waiter channel here: https://github.com/djc/bb8/blob/03f95c9cc2848f02f548bb830b98d52e873b7a18/bb8/src/inner.rs#L142 before we exhaust the "inner" timeout on the retry loop here: https://github.com/djc/bb8/blob/03f95c9cc2848f02f548bb830b98d52e873b7a18/bb8/src/inner.rs#L216
After a quick review I don't immediately see a great way to get these to line up that doesn't feel like a hack (i.e. make the outer one "a little bit longer" or some such).  The outer timeout can't really be removed, since we're relying on that in the face of pool contention.  The inner timeout in the context of the retry loop looks locally correct, and it's hard to picture what would need to change really.
I'll go ahead and submit a PR to bubble up the error for the case of a pool configured with retry_connection(false), since that at least makes a little bit of progress here.


Tap element by image shows as passed while the element is not tapped in some cases where a delay needs to be introduced

solved with the latest release.
introduced matching accuracy, retries, and three new algorithms for element identification.
will fail if all three attempts didn't find the element and will attach both the reference and current screenshots, instructing the user to either fix the scenario or crop the current screenshot to get a valid reference image


Invalid value passed for authtoken

I'm getting error below when running it using your docker image. I tried to docker exec into the container to print the env vars and etc but couldn't. I know my client ID, client secret, and refresh token are correct b/c I wrote an exporter as well using Python and it's working correct. The command I ran is below as well.
14:06:11 [ERROR] ApiUnknownError("Invalid value passed for authtoken.")
docker run \
    -p 9803:9803 \
    -e ZOHO_CLIENT_ID=1000.MASKED\
    -e ZOHO_CLIENT_SECRET=MASKED\
    -e ZOHO_REFRESH_TOKEN=1000.MASKED\
    svenstaro/site24x7_exporter --site24x7-endpoint site24x7.com

$ docker exec -it 2316b5a8a948 env
OCI runtime exec failed: exec failed: container_linux.go:349: starting container process caused "exec: \"env\": executable file not found in $PATH": unknown

$docker exec -it 2316b5a8a948 /bin/ls
OCI runtime exec failed: exec failed: container_linux.go:349: starting container process caused "exec: \"/bin/ls\": stat /bin/ls: no such file or directory": unknown

All the env vars are strings and below are the first portion of my client ID, secret, and refresh token.
-e ZOHO_CLIENT_ID=1000.EPYFP3LOQIOLOREMOVED \
-e ZOHO_CLIENT_SECRET=58cd08727bf19829eREMOVED \
-e ZOHO_REFRESH_TOKEN=1000.352d73815d1245REMOVED.5c3a6105b1cREMOVED

Thanks for the report. I'm adding some debug output so you can check all things here yourself. However, in the mean time, are you absolutely sure this is the correct endpoint and that you made the refresh token for the same endpoint?

According to Zoho documentation I have to use https://www.site24x7.com/api for API endpoint and https://accounts.zoho.com/oauth/v2/token refresh token. I'm using those values in my Python exporter and it works correctly.

Here's the debug log from version 0.1.0.
13:34:41 [DEBUG] (2) hyper::proto::h1::io: flushed 149 bytes
13:34:42 [DEBUG] (9) rustls::client::tls13: Ticket saved
13:34:42 [DEBUG] (9) rustls::client::tls13: Ticket saved
13:34:42 [DEBUG] (2) hyper::proto::h1::io: read 769 bytes
13:34:42 [DEBUG] (2) hyper::proto::h1::io: parsed 15 headers
13:34:42 [DEBUG] (2) hyper::proto::h1::conn: incoming body is chunked encoding
13:34:42 [DEBUG] (2) hyper::proto::h1::decode: incoming chunked header: 0x75 (117 bytes)
13:34:42 [DEBUG] (2) reqwest::async_impl::client: response '401 Unauthorized' for https://www.site24x7.com/api/current_status
13:34:42 [DEBUG] (2) hyper::proto::h1::conn: incoming body completed
13:34:42 [DEBUG] (2) hyper::client::pool: pooling idle connection for ("https", www.site24x7.com)
13:34:42 [DEBUG] (2) site24x7_exporter: JSON received from server:
{
  "error_code": 1102,
  "message": "Invalid value passed for authtoken."
}
13:34:42 [ERROR] ApiUnknownError("Invalid value passed for authtoken.")
13:34:42 [DEBUG] (2) hyper::proto::h1::io: flushed 149 bytes
13:34:42 [DEBUG] (9) hyper::proto::h1::io: read 0 bytes
13:34:42 [DEBUG] (9) hyper::proto::h1::conn: read eof
13:35:10 [DEBUG] (2) rustls::session: Sending warning alert CloseNotify
13:35:10 [DEBUG] (2) hyper::proto::h1::io: read 0 bytes

I'll try to make a .com account and debug there.

I just tested this on site24x7.eu and site24x7.com with virgin accounts following my own README and it really seems fine. :/
I can only guess that perhaps you use a slightly different curl command to get the refresh code or maybe it's some weird encoding problem. I added some more debug to the current master which you should be able to easily get from DockerHub at the latest tag.
On that new version, if you pass --log.level debug (and just pass nothing else as the defaults work fine for .com), then you should see all exact tokens and URLs and endpoints that it tries to use. This should give us quite a bit of information on what's going on.

Like I mentioned above, I use https://accounts.zoho.com/oauth/v2/token to get new access token. I referred to Part 3: Generate Access and Refresh Token section of https://www.site24x7.com/help/api/#authentication to get new access token. The new debug log says that it successfully got an access token (line 3-4), however, it looks like your code somehow messed it up when using it?
14:17:49 [DEBUG] hyper::client::pool: pooling idle connection for ("https", accounts.zoho.com)
14:17:49 [DEBUG] reqwest::async_impl::client: response '200 OK' for https://accounts.zoho.com/oauth/v2/token
14:17:49 [INFO] Successfully acquired access token
14:17:49 [DEBUG] site24x7_exporter: Access token value: 1000.MASKED.MASKED
14:18:03 [DEBUG] hyper::proto::h1::io: read 85 bytes
...
14:18:04 [DEBUG] hyper::proto::h1::io: flushed 198 bytes
14:18:04 [DEBUG] rustls::client::tls13: Ticket saved
14:18:04 [DEBUG] rustls::client::tls13: Ticket saved
14:18:04 [DEBUG] hyper::proto::h1::io: read 627 bytes
14:18:04 [DEBUG] hyper::proto::h1::io: parsed 15 headers
14:18:04 [DEBUG] hyper::proto::h1::conn: incoming body is empty
14:18:04 [DEBUG] hyper::client::pool: pooling idle connection for ("https", site24x7.com)
14:18:04 [DEBUG] reqwest::async_impl::client: redirecting 'https://site24x7.com/api/current_status' to 'https://www.site24x7.com/api/current_status'
14:18:04 [DEBUG] reqwest::connect: starting new connection: https://www.site24x7.com/
14:18:04 [DEBUG] hyper::client::connect::dns: resolving host="www.site24x7.com"
14:18:04 [DEBUG] hyper::client::connect::http: connecting to <IP_ADDRESS>:443
14:18:04 [DEBUG] hyper::client::connect::http: connected to <IP_ADDRESS>:443
14:18:04 [DEBUG] rustls::client::hs: No cached session for DNSNameRef("www.site24x7.com")
14:18:04 [DEBUG] rustls::client::hs: Not resuming any session
14:18:04 [DEBUG] rustls::client::hs: Using ciphersuite TLS13_AES_256_GCM_SHA384
14:18:04 [DEBUG] rustls::client::tls13: Not resuming
14:18:04 [DEBUG] rustls::client::tls13: TLS1.3 encrypted extensions: [ServerNameAck, Protocols([PayloadU8([104, 116, 116, 112, 47, 49, 46, 49])])]
14:18:04 [DEBUG] rustls::client::hs: ALPN protocol is Some([104, 116, 116, 112, 47, 49, 46, 49])
...
14:18:04 [DEBUG] hyper::proto::h1::io: flushed 149 bytes
14:18:05 [DEBUG] rustls::client::tls13: Ticket saved
14:18:05 [DEBUG] rustls::client::tls13: Ticket saved
14:18:05 [DEBUG] hyper::proto::h1::io: read 873 bytes
14:18:05 [DEBUG] hyper::proto::h1::io: parsed 16 headers
14:18:05 [DEBUG] hyper::proto::h1::conn: incoming body is chunked encoding
14:18:05 [DEBUG] hyper::proto::h1::decode: incoming chunked header: 0x75 (117 bytes)
14:18:05 [DEBUG] reqwest::async_impl::client: response '401 Unauthorized' for https://www.site24x7.com/api/current_status
14:18:05 [DEBUG] hyper::proto::h1::conn: incoming body completed
14:18:05 [DEBUG] hyper::client::pool: pooling idle connection for ("https", www.site24x7.com)
14:18:05 [DEBUG] site24x7_exporter: JSON received from server:
{
  "error_code": 1102,
  "message": "Invalid value passed for authtoken."
}
14:18:05 [ERROR] ApiUnknownError("Invalid value passed for authtoken.")
14:18:05 [DEBUG] hyper::proto::h1::io: flushed 149 bytes

Sorry, I looked at this further and I think at this point the only way I can make progress on this if I can actually check this out with your credentials. Is there any chance you can make a new application in Zoho with no privileges or maybe we can do some pairing on this? I'd really like to get to the bottom of this but with my .eu and .com credentials that I made exactly according to README instructions, it works just fine. :/

I tried to create a new Self client in Zoho but unfortunately it's greyed out and I can't share the one I currently use for production. What Scope did you give your grant token when created it? I only gave mine certain scope, no admin scope I don't think. Although with the scopes I've given with this grant token, I was able to talk to Site24x7 API for the things that I need.

I use Site24x7.Reports.Read scope and it works just fine. Also, you can apparently indeed not create a second Self Client which is a pity. However, you can create multiple refresh tokens. I solved the problem by creating a second user with whom I did the testing.

I am encountering this as well.  I've tried it with two different accounts, and the Site24x7.Reports.Read scope, and everything works great until I try to grab /metrics.
This is with the v4.4.0 tag.
I'm happy to help debug this but I don't have too much more time to work on this tool.

That's entirely surprising to me considering I tested this and it's in active use right now. The only thing I can conceive is that the way we generate tokens is different and somehow badly documented by me. I'm sorry but I'm really not sure how to debug this for you guys as I was pretty thorough the last time I looked into this and even made a fresh account on a different realm and it worked just fine.
@spads-spads you can try enabling debug mode (see above) and looking at the output. You can also poke around in the code a little and see whether you can find a problem. I'm really unhappy that this doesn't appear to be working for you guys. :/

I have used --log.level debug in v0.4.4 and it reported successfully using the refresh token to get the auth token, but gets the same 401 on /metrics.  I think you may be correct that this is something in our accounts that's funny.  Perhaps we have old accounts with some deprecated flag set?  I've been on Site24x7 for years now, so perhaps that's it?  I've tried it with two different accounts of the same vintage and got the same symptoms.

I'm getting the same error with the current release when I try and access /metrics. I followed the instructions to the letter using the .com endpoint and the reports.read scope. Any updates on this issue? I also ran into an issue on deployment with regards to the tokio version.

Well, I still can't reproduce it and so far no one has taken me up on my offer to dive into this in-depth. I'd love to get it fixed and would offer all the support I can. As for me, I've been running this exporter for many months now with absolutely no issues.

I'd be interested in troubleshooting this further with you. What timezone are you in and what would you need?

Let's take this to email. Could you mail me at<EMAIL_ADDRESS>I'm in CET.

First of all, thank you @svenstaro for sharing this work.
Unfortunately, I did have the same error as well. I used the Docker image, and tried the following tags : latest, 0.5.1 and 0.4.4
Starting the container works fine. With debug mode enabled, I get to this point :
s24x7-exporter_1  | 19:57:37 [INFO] Successfully acquired access token
s24x7-exporter_1  | 19:57:37 [DEBUG] site24x7_exporter::api_communication: Access token value: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

When I take that same access token from the container logs, and use it directly to curl the S24x7 API, it works just fine. I get a 200 with the expected results :
curl "https://www.site24x7.com/api/current_status" \
    -X GET \
    -H "Accept: application/json; version=2.0" \
    -H "Authorization: Zoho-oauthtoken XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"

However when I visit http://localhost:9803/metrics, I get the same error mentioned by everyone :
s24x7-exporter_1  | 19:58:05 [DEBUG] reqwest::async_impl::client: redirecting 'https://site24x7.com/api/current_status' to 'https://www.site24x7.com/api/current_status'
s24x7-exporter_1  | 19:58:05 [DEBUG] reqwest::async_impl::client: response '401 Unauthorized' for https://www.site24x7.com/api/current_status
s24x7-exporter_1  | 19:58:05 [DEBUG] site24x7_exporter::parsing: JSON received from server:
s24x7-exporter_1  | {
s24x7-exporter_1  |   "error_code": 1102,
s24x7-exporter_1  |   "message": "Invalid value passed for authtoken."
s24x7-exporter_1  | }

Again, using curl, that same Access token works fine on that same endpoint : https://www.site24x7.com/api/current_status
I wonder if it's not the "redirecting to ..." that's causing the issue, causing the token to be lost or something along those lines.
I'd by happy to share any more info that you need, or even have a quick chat if it can help.
Cheers.

2935% git diff src/main.rs
diff --git a/src/main.rs b/src/main.rs
index 8d430de..5d54b46 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -93,7 +93,7 @@ async fn main() -> Result<()> {
         std::env::var("ZOHO_REFRESH_TOKEN").context("ZOHO_REFRESH_TOKEN must be set")?;

     let site24x7_client_info = site24x7_types::Site24x7ClientInfo {
-        site24x7_endpoint: format!("https://{}/api", args.site24x7_endpoint),
+        site24x7_endpoint: format!("https://www.{}/api", args.site24x7_endpoint),
         zoho_endpoint: format!(
             "https://accounts.zoho.{}",
             args.site24x7_endpoint.splitn(2, '.').last().unwrap()

I wonder if it's not the "redirecting to ..." that's causing the issue, causing the token to be lost or something along those lines.

I did have the same error as well.

@s5unty That's a cool discovery! @chungktran @wileycrider @spads-spads, could you check whether that works for you?

Do I need to apply the diff?
On Fri, Mar 26, 2021 at 9:38 PM Sven-Hendrik Haase @.***>
wrote:

@s5unty https://github.com/s5unty That's a cool discovery! @chungktran
https://github.com/chungktran @wileycrider
https://github.com/wileycrider @spads-spads
https://github.com/spads-spads, could you check whether that works for
you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/svenstaro/site24x7_exporter/issues/3#issuecomment-808616919,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR6Y3IS4SBQ4GDO7ZSVCJWTTFUZHVANCNFSM4OJOBHTQ
.

--
Wiley Crider

@wileycrider Yeah, basically you only really need to add a www. to the string so it can easily be done manually. If you're not comfortable compiling Rust, I could produce a binary for you with the new URL and you could check.

That would be great if you could prove a binary
On Sat, Apr 3, 2021 at 2:01 PM Sven-Hendrik Haase @.***>
wrote:

@wileycrider https://github.com/wileycrider Yeah, basically you only
really need to add a www. to the string so it can easily be done
manually. If you're not comfortable compiling Rust, I could produce a
binary for you with the new URL and you could check.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/svenstaro/site24x7_exporter/issues/3#issuecomment-812902251,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR6Y3ITG6VRD2VHBDZQPSJLTG5JXPANCNFSM4OJOBHTQ
.

--
Wiley Crider

I was actually, at last, able to repro this somehow! I can confirm that the redirect magically breaks this. I'll make a new patch release with the fix. Thanks @s5unty!

Version 0.5.2 should have the fix - please test. :)

Hi Sven,
It's working now! I'm able to connect via the exporter and see the metrics
when I curl over HTTP. Now I just have to integrate it with our prometheus
deployment. Since we're using the operator it's not as straightforward.
Thanks for getting this resolved!
On Mon, Apr 5, 2021 at 2:41 AM Sven-Hendrik Haase @.***>
wrote:

Version 0.5.2 should have the fix - please test. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/svenstaro/site24x7_exporter/issues/3#issuecomment-813223087,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR6Y3ITDLAPD5TSP3H3QO2LTHFLQLANCNFSM4OJOBHTQ
.

--
Wiley Crider

Glad to hear it's fixed for you!


Quorum cleanup: further cleanup options

Splitting portion of #6274 out that I'm not targeting to complete in the same timeline:
From Vlad:

Move IQuorum, IQuorumEvents from protocol-definitions into container-definitions - that's purely client centric interfaces.
Move part of Quorum class implementation to client. I.e. server (or common) to provide shared code, but any client-specific code (specifically - QuorumProxy) should not be in server. This will improve speed of changes if we need to change API, but would also reduce the need for client to need latest version of server

it's possible that the best course of action it to move shared quorum code out of server into its own package, and make client & server depend on it. This makes more sense if that's the only real dependency between client & server. It also more clear on what's the goal of this package implementation - it encodes protocol assumptions, and thus can't likely change over time (in its behavior).

Also see #6730 for debate on whether item 1 should be done.  Probably some restructuring is needed, but needs more deliberation on appropriate layering.

Tracked in ADO


Fix numpy 2.1 strings

Not sure this is great, but it does seem to work?

Thanks for looking at this @keewis and fixing with #9403!


investigate difference in net get from generation_eia923 vs generation_fuel_eia923 tables

gen table = generation_eia923
gen_fuel = generation_fuel_eia923
I assume this is all a vestige of reporting requirements.

is gf always bigger?
It is nearly always bigger.

when both tables are grouped at the plant/year level and merged together, the net gen in the gen_fuel table is larger or = in 87% of the records
85% of the "missing" net gen (net gen that doesn't show up in in the gen table) is from plants that just don't show up in the gen table at all

what is the scale of the difference?

58% of the net gen reported in the gen_fuel is reported in the gen table
About 9% of plants have records which both have data in both tables and have a non-zero difference between the net gen.

does it change over time?

It looks like it gets much cleaner after 2014 (i know, i know this graph is very ugly)

stacked version:

how often are the missing gens different PMs?

% of records w/ gen v gen_fuel diff that have >1 prime mover: 91.39%

Have you made a plot of the annual ratio of generation reported in one table vs the other?

It is kinda hard to see in one graph:

But here they are broken out by these chunks of time:

I was thinking just a line plot, with time on the x axis, and ratio on the y axis.

Okay great, so it seems like the overwhelming majority of the issue here is the lack of combustion turbine reporting prior to May 2014.

Hm.. well, no. This is only the plants which had some reporting to the gen table. I remade it w/ a note.. and made the second w/ all of the missing net gen. Maybe it is going up over these last few years due to more gas on the system?


#160: added multipage pdf saving

added close functions to analysis
fixed description of visualizer
added pdf_name option to visualizer
figsize is now in pixels instead of inches
added PdfMerger to visualizer

I have no clue why testing CI cannot find pyzerolog even though it installs it without any problems


wxPython: 4.2.0

Add wxPython v4.2.0
Disable wxPython v4.1.1 for Python v3.10, because https://github.com/wxWidgets/Phoenix/issues/2016
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@jamesdbrock I think it's better to use wxgtk32 instead of wxgtk31. wxgtk32 was included in nixpkgs https://github.com/NixOS/nixpkgs/pull/191729

It looks like this PR might be redundant after #190587
That PR uses wxgtk32.

wxPython_4_2 was added in #190587


Expand System Control support

Does windows support any other usages in system controls? Particularly 'System Speaker Mute' (0xA7), 'System Microphone Mute' (0xA9) and the follow on LED 'System Microphone Mute' (0x57) are of interest. I'm having a hard time finding what is supported and what isn't.

I can't find these Usages mentioned in the public documentation, so they are unlikely to be currently supported.  I wouldn't suggest building anything using them.


add google maven repo required by appcompat-v7 26

add google maven repo required by appcompat-v7 26
Test Plan
CI will download appcompat-v7 version 26.0.2

Warnings

:warning:

:clipboard: Release Notes - This PR appears to be missing Release Notes.

  Generated by :no_entry_sign: dangerJS