ETH drivers with custom registers read write API .   (IDFGH-11553)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
Hi,
IDF version : 5.1.2
We are using eth LAN8720 for a product in production.
due to the issue of LAN chips clock interfering with boot strapping on pin GPIO0 of esp32.
we have revised the new board with RTL8201 chip.
The the issue is LED indicators, as the default led behavior of the both the ethernet chips are different
Is their any option in the driver to set the led properties as per the requirements, as The RTL chip has the option to set the led similar to LAN8720.
if we could write LED_sel[1:0]	with value of "0x01"  the led will be same as lan 8720 chip.
From the RTL datasheet
LED  Function Selection RTL8201
Address: 19:5~4  LED_sel[1:0]
[LEDSel == Page 7 Register 19 (Interrupt, WOL Enable, and LEDs Function Registers ]

LED_sel[1:0]	00		01		10		11 (default)
LED0		ACTALL		LinkALL/ACTALL	Link10/ACTALL 	LINK10/ACT10
LED1		LINK100		LINK100		LINK100		LINK100/ACT100

LAN8720 default
LED 0   LinkALL/ACTALL
LED 1   LINK100/LINK10

Thanks and Regards
Mrutyunjay

Option to read/write PHY custom PHY registers has been actually recently added to ESP-IDF, please check https://github.com/espressif/esp-idf/commit/78f791d4d5072f084196d015ad8ddd682d6fd853
Will soon synced to v5.1 too.

@kostaond am i correct in understanding you can only read/write registers up to 0x1F ?
for a project that i'm working on, i need read access to registers 0x171 to 0x018A of the PHY,
but when i try that the returned data is incorrect.
i'm not familiar with the esp-idf codebase, but after a bit of digging around,
i think the reg address is limited to 5 bits (so max 0x1F) here:
https://github.com/espressif/esp-idf/blob/76923a7a7f92ef81a2599d44c93c038143cc55f9/components/soc/esp32/include/soc/emac_mac_struct.h#L75

Closing the issue since infrastructure to access custom Ethernet PHY registers is already in place. Feel free to reopen if you face any issue to access it.

hi ,
for IDF 5.1 Added  following coed to achieve the led control settings. until we port the code to IDF 5.3x

add new function to idf components files
esp-idf-v5.1\components\esp_eth\include\esp_eth_phy_802_3.h
esp-idf-v5.1\components\esp_eth\src\esp_eth_phy_802_3.c
esp_err_t esp_eth_phy_802_3_update_ledFunction(phy_802_3_t *phy_802_3, uint32_t *ledfn )
{
    esp_err_t ret = ESP_OK;
    esp_eth_mediator_t *eth = phy_802_3->eth;
    uint32_t led  =0;
    uint32_t cpage=0;
    uint32_t mpage=0;
    uint32_t dpage=0;

		//ledfn valid values 0x0,0x1,0x2,0x3(default).

    // Applicable for RTL8201 led function
    // set address to read write to page 7 , write to reg 31(0x1F) value 7(0x07).
    // Read page7 register19 and clear bits 4,5 : AND ing with 0xFFCF to set bit4 bit 5 as 00 (1100 1111).
    // set the bit 4,5 accordingly : OR ing with 0x0X00,X=0,1,2,3'
		//Write back to page7 register 19.
		//read current page value.
    ESP_GOTO_ON_ERROR(eth->phy_reg_read (eth, phy_802_3->addr, 31, &cpage   ), err, TAG, "read  reg 31  failed"   );
    //write to set up to read write to page to 7.
		mpage= 0x0007;
    ESP_GOTO_ON_ERROR(eth->phy_reg_write(eth, phy_802_3->addr, 31, mpage    ), err, TAG, "write reg 31 0x07 failed");
    //Read Page7 register19.
    ESP_GOTO_ON_ERROR(eth->phy_reg_read (eth, phy_802_3->addr, 19, &led     ), err, TAG, "read Ledfn failed"   );
    //ESP_LOGE("ETH_PHY_802_3_reg","LEDfn      read =0x%08X",led);
    // Clear bits 4,5
    led = led & 0xFFFFFFCF;// 0b1111 1111 1100 1111 == FFCF
  //ESP_LOGE("ETH_PHY_802_3_reg","LEDfn 4,5 clear =0x%08X",led);
    // read =0x0000C034   // 0b1100 0000 0011 0100 default
    // set bits 4,5       // 0b0000 0000 00XX 0000
    // select any one of following 4 values for bit 4,5
    //led = led | 0x00000000 ; // ledfn XX00XXXX 0  LED0=ACT-ALL              LED1=LINK100
      led = led | 0x00000100 ; // ledfn XX01XXXX 1  LED0=LINK-ALL/ACT-ALL     LED1=LINK100
    //led = led | 0x00000200 ; // ledfn XX10XXXX 2  LED0=LINK-10 /ACT-ALL     LED1=LINK100
    //led = led | 0x00000300 ; // ledfn XX11XXXX 3  LED0=LINK10/ACT10         LED1=LINK100/ACT100
  //ESP_LOGE("ETH_PHY_802_3_reg","LEDfn     write =0x%08X",led);
    ESP_GOTO_ON_ERROR(eth->phy_reg_write(eth, phy_802_3->addr, 19, led  ), err, TAG, "write Ledfn failed");
    ESP_GOTO_ON_ERROR(eth->phy_reg_write(eth, phy_802_3->addr, 31, cpage), err, TAG, "Write page2 failed");
  //ESP_LOGE("ETH_PHY_802_3_reg","cpage = 0x%08X mpage =0x%08X dpage=0x%08X ledval=0x%08X ", cpage, mpage, dpage , led );

    *ledfn = led ;

    return ESP_OK;
err:
    return ret;
}

modify the function in the file, To call the above new function function
esp-idf-v5.1\components\esp_eth\src\esp_eth_phy_rtl8201.c

static esp_err_t rtl8201_init(esp_eth_phy_t *phy)
{
    esp_err_t ret = ESP_OK;
    phy_802_3_t *phy_802_3 = esp_eth_phy_into_phy_802_3(phy);

    /* Basic PHY init */
    ESP_GOTO_ON_ERROR(esp_eth_phy_802_3_basic_phy_init(phy_802_3), err, TAG, "failed to init PHY");

    /* Check PHY ID */
    uint32_t oui;
    uint8_t model;
    uint32_t ledfun;

    ESP_GOTO_ON_ERROR(esp_eth_phy_802_3_read_oui(phy_802_3, &oui), err, TAG, "read OUI failed");
    ESP_GOTO_ON_ERROR(esp_eth_phy_802_3_read_manufac_info(phy_802_3, &model, NULL), err, TAG, "read manufacturer's info failed");
    ESP_GOTO_ON_FALSE(oui == 0x732 && model == 0x1, ESP_FAIL, err, TAG, "wrong chip ID");

    /* Set RTL8201 LedFun to Desired value *********************/
    ESP_GOTO_ON_ERROR(esp_eth_phy_802_3_update_ledFunction(phy_802_3, &ledfun), err, TAG, "update ledfun  failed");
    ESP_LOGE("ESP_ETH_PHY_RTL8201.C","RTL8201 Ledfunction Value = 0x%08X ", ledfun );
    return ESP_OK;
err:
    return ret;
}

Regards
Mrutyunjay


Remove extra traling comma in support hash

The trailing comma after the bugtracker item in the support hash makes
the file invalid JSON.  This change corrects the issue.

thanks @paultcochrane!


Feedback - move from a "default" user flow to a custom flow

Hi there,
I'm diving into IEF and B2C, and the documentation contains a link to some starterpacks.
My use case (and probably the use case of my others) is that I want to add an extra claim to the user (based on a REST api elsewhere). In order to do this, I need a rest API claimsprovider.
What I really want to know:
Is it possible to "export" a "default user flow", such as the recommended "SignIn V3" policy, and make my modifications on top of that, or do I need to start from scratch, basically rebuilding an already default policy in the new TrustFrameworkBase.xml, TrustFrameworkExtensions.xml and SignInPolicy.xml?
If this is not possible, explain the steps how to go, because moving away from the "default user flows" into this custom implementation is quite a leap, and I'd like it to be as painless as possible.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 33489541-1210-69d0-4a45-5ba306d254fc
Version Independent ID: 4dd79b67-4004-f7d0-d59d-d3c94677b36e
Content: Azure Active Directory B2C custom policy overview
Content Source: articles/active-directory-b2c/custom-policy-overview.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@las3r
Thanks for your feedback! We will investigate and update as appropriate.

Hi @las3r,
There is no a migration path from user flows to custom policies. Yes, you do need to start from scratch. Please follow the steps below:

Prepare your environment. Tip use the IEF Setup App to deploy the necessary components.
Then add the REST API to your policy.

Note: you can export the user flows. But, the xml files contains a small part of the "internal" policy.

Closing due to inactivity
#please-close


[Android] Validate floating-point values for Input.Number

Related Issue
Fixes #5278
Description
Update shared model to support floating-point values for min, max, and value properties on Input.Number element. Update Android library accordingly and perform proper validation.
Sample Card
v1.3/Tests/Input.Number.Float
How Verified
Updated existing automated Android tests to support double.
Added test card with floating min, max, value for manual testing:

Microsoft Reviewers: Open in CodeFlow

Update: iOS reinterprets the double as int, so need to make the changes on iOS (and likely UWP, too) to avoid regressions. Moving out so we can ship the fix for all platforms at once

Update: iOS reinterprets the double as int, so need to make the changes on iOS (and likely UWP, too) to avoid regressions. Moving out so we can ship the fix for all platforms at once


feat(experiences): add separate banner component

Summary
adds a separate banner "widget" (uses connectHits) and ensures banner doesn't show inside hits

Result
FX-3002

This implementation doesn't read from renderingContent.widgets.banner but instead relies on an explicit banner block, is that right?


Add dropdown to control who can create web-public streams

Similar to with other classes of streams, we should have a setting for who can create web-public streams.
This setting should only be visible if the setting introduced in #20277 and WEB_PUBLIC_STREAMS_ENABLED are enabled, just like the option for creating web-public streams in "Stream settings".  (Actually we should double-check the logic is correct there and live-updates appropriately).
We may want to only allow moderators and above as options: If all accounts can create web-public streams in an open organization, it's a potential reservoir of abuse (where someone creates a web-public stream and uses it to post their malicious content to be hosted to the Internet).
@sahil839 @amanagr FYI; it's possible Sahil should take this issue since it's entirely a settings subsystem project.

Oh hmm, we actually have some of the plumbing for this; I guess the remaining issue is to integrate it properly with #20277 with the live-update working properly.

I have gone through the discussion on #20277. Can start working on this.


Install Command line does not the same last commit

I Installed Command line

pip install robotframework-excellib

So, Version control is 1.1.0 but I found last commit version 2.0.0 is not not the same.
Could you please update ? Thank you.

@Lev-v please update release version in pypi.
@lachesschoc you can temporarily install the package from the master branch directly.
pip install https://github.com/peterservice-rnd/robotframework-excellib/archive/master.zip

@ailjushkin @lachesschoc Thank you, I fixed the issue, last version can now be installed using default pip command as it should be.

That's awesome, man. Thank you


Digital Miner mines NuclearCraft byproducts in Silk Touch mode.

The Digital Miner mines NuclearCraft byproducts in Silk Touch mode.
So when it mines Coal Ore it can also "mine" Beryllium Dust and Sulfur. Lapis Ore it also gets Fluorite, and with Redstone Ore it mines Rhodochrosite.
When mining with any tool (not Silk touched) you are supposed to have a chance to get these byproducts, but not with Silk Touch.
Steps to reproduce:

Place Digital Miner, set to Ore Dictinary ore, set Silk Touch mode

Version (make sure you are on the latest version before reporting):
Forge: <IP_ADDRESS>11
Mekanism: 1.12.2-<IP_ADDRESS>0
NuclearCraft: 2.9d--1.12.2

They're not checking silk touch correctly in their event handler.


[Keep] Import annotations

If you paste in a link to some webpage or youtube video, Keep will create an annotation on the bottom of the note.
This info is present in both the HTML and JSON files when exported, but not present in the Obsidian note.
Here's how it looks like.

Is the link still inline in the body of the note?

I usually delete the URL from the body of the note so that I'm only left with the annotation.
Obviously if it's in the body it would import just fine, forgot to mention that.

In that case it seems like Importer is working as expected.
I am not sure if Keep exports include these annotations. Either way we'd need to figure out what is the appropriate way to convert them to Markdown, maybe just a list at the end of the note. Are annotations linked to a specific part of the note?

A list at the end of the note is a good idea!
And yes, it does export them, even if the URL isn't in the Keep note body.
Here's an example in the exported JSON file (though it's also in the HTML).
   "annotations":[
      {
         "description":"",
         "source":"WEBLINK",
         "title":"Submitting a Complaint to ICANN Contractual Compliance - ICANN",
         "url":"https://www.icann.org/compliance/complaint"
      },
      {
         "description":"Here at Cloudflare, we make the Internet work the way it should. Offering CDN, DNS, DDoS protection and security, find out how we can help your site.",
         "source":"WEBLINK",
         "title":"Cloudflare - The Web Performance & Security Company",
         "url":"https://www.cloudflare.com/"
      }
   ],

Annotations aren't linked to a specific part of the Keep note, just the note in general.


python37Packages.howdoi: 2.0.10 -> 2.0.12

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.howdoi is: "Instant coding answers via the command line"
meta.homepage for python37Packages.howdoi is: "https://pypi.python.org/pypi/howdoi"
meta.changelog for python37Packages.howdoi is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.0.12 with grep in /nix/store/555dk4r6r7swhn7bqwgb5277kbmnnr9j-python3.7-howdoi-2.0.12

directory tree listing: https://gist.github.com/cf3b6a69714664c422f2b7f3df358dc7

du listing: https://gist.github.com/276eac03cd11dca7a08bdf5e429bd703

Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python37Packages.howdoi
python38Packages.howdoi
python39Packages.howdoi

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/555dk4r6r7swhn7bqwgb5277kbmnnr9j-python3.7-howdoi-2.0.12 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.howdoi https://github.com/r-ryantm/nixpkgs/archive/37ce0485ffe9437321012154eb60afc67e019b96.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/555dk4r6r7swhn7bqwgb5277kbmnnr9j-python3.7-howdoi-2.0.12
ls -la /nix/store/555dk4r6r7swhn7bqwgb5277kbmnnr9j-python3.7-howdoi-2.0.12/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

python37Packages.howdoi
python38Packages.howdoi
python39Packages.howdoi

Maintainer pings
cc @costrouc for testing.

Result of nixpkgs-review pr 113759 at 37ce0485 run on aarch64-linux 1

3 packages built:

python37Packages.howdoi
python38Packages.howdoi
python39Packages.howdoi

Broken due to missing imports in pyquery.

Was superseded by #116376.


[no-jira] Fixed bug with CloudSearch not accepted booleans in JSON

@clicktravel-basharat : Even though I was not assigned to this PR I had time to look at it before I left and it looks good to me.


inference error during predict_on_batch

environment is the same as the requirements.txt
code for loading model and test image:

turns out my GPU MEM is not sufficient. so I close this issue

Hello
You met this issue but solved by adding this code at the start of script.
import tensorflow as tf
from tensorflow.compat.v1.keras.backend import set_session
config = tf.compat.v1.ConfigProto()
config.gpu_options.allow_growth = True  # dynamically grow the memory used on the GPU
sess = tf.compat.v1.Session(config=config)
set_session(sess)
I hope that this will help you.


ChoicePrompt Slider Button causes page refresh

Issue
seems very similar to #1741
The slider buttons for the choice options are causing the page to be refreshed.

I'm currently using the master branch.

@Jhanbury thanks for reporting this! I'll investigate and get back to this issue asap.

Will be fixed when we bump to<EMAIL_ADDRESS>@corinagum could you help?


Add CROSS JOIN functionality (issue #124)

New feature:

Let user create CROSS JOIN queries between two tables

Thanks.


Impossible to get the latest stable version of Meilisearch

Describe the bug
A clear and concise description of what the bug is.
When run curl -L https://install.meilisearch.com | sh
show:
Impossible to get the latest stable version of Meilisearch
To Reproduce
run curl -L https://install.meilisearch.com | sh
macos and debian all show this.

Hi @theowenyoung. I ran a quick test and cannot reproduce the problem. It seems to work fine. What version of meilisearch was installed? Did you encounter any errors? See result of my test below:

For me, it's like this:
 curl -L https://install.meilisearch.com | sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  6620  100  6620    0     0   7527      0 --:--:-- --:--:-- --:--:-- 13213

ERROR: Impossible to get the latest stable version of Meilisearch.
Please let us know about this issue: https://github.com/meilisearch/meilisearch/issues/new/choose

 curl https://pastebin.com/raw/f6YFU9Hd | grep -E '"tag_name":|"draft":|"prerelease":'

it seems this line does not work for me...
But this line works:
curl https://pastebin.com/raw/f6YFU9Hd | json_pp | grep -E '"tag_name" :|"draft" :|"prerelease" :'

Note, I added a <space> before the colon

Hello @theowenyoung
Indeed it's probably related to your local environment. On macOS with zsh, I still couldn't reproduce the problem. Do you mean you've been able to fix this with the changes above?

yes, I have fixed it by this.

Hello @theowenyoung
Thanks for the investigation! However, I'm very confused because your fix creates a bug on my machine...
Can you tell us a little bit more about your machine, your environment...etc? It would be really helpful
Thanks in advance! 🙏

@curquiza sorry, I mean I fixed the  github api json parsing by this, I just tried to figure out the whole bash, it seems that I also need to change the loop order:
get_latest() {
    temp_file='temp_file' # temp_file needed because the grep would start before the download is over

    if [ -z "$GITHUB_PAT" ]; then
        curl -s 'https://api.github.com/repos/meilisearch/meilisearch/releases' > "$temp_file" || return 1
    else
        curl -H "Authorization: token $GITHUB_PAT" -s 'https://api.github.com/repos/meilisearch/meilisearch/releases' > "$temp_file" || return 1
    fi

    releases=$(cat "$temp_file" | json_pp | \
        grep -E '"tag_name" :|"draft" :|"prerelease" :' \
        | tr -d ',"' | cut -d ':' -f2 | tr -d ' ')
        # Returns a list of [tag_name draft_boolean prerelease_boolean ...]
        # Ex: v0.10.1 false false v0.9.1-rc.1 false true v0.9.0 false false...
    # echo $releases;
    # echo yes
    i=0
    latest=''
    current_tag=''
    for release_info in $releases; do
        #echo $release_info
        if [ $i -eq 2 ]; then # Checking tag_name
            if echo "$release_info" | grep -q "$GREP_SEMVER_REGEXP"; then # If it's not an alpha or beta release
                current_tag=$release_info
            else
                current_tag=''
            fi
            i=0
        elif [ $i -eq 0 ]; then # Checking draft boolean
            if [ "$release_info" = 'true' ]; then
                current_tag=''
            fi
  			i=1
        elif [ $i -eq 1 ]; then # Checking prerelease boolean
            if [ "$release_info" = 'true' ]; then
                current_tag=''
            fi
            i=2
            if [ "$current_tag" != '' ]; then # If the current_tag is valid
                if [ "$latest" = '' ]; then # If there is no latest yet
                    latest="$current_tag"
                else
                    semverLT $current_tag $latest # Comparing latest and the current tag
                    if [ $? -eq 1 ]; then
                        latest="$current_tag"
                    fi
                fi
            fi
        fi
    done

    rm -f "$temp_file"
    return 0
}

The whole script is here

Hello @theowenyoung, sorry for the late answer, I've opened a PR trying to fix this. I have to ensure it works as expected for every machine.
Thanks for sharing your script!!


Out of ordered lists, only non-empty starting with 1 can interrupt paragraphs

See https://spec.commonmark.org/0.30/#example-305
Follows #70

The corresponding unit test is testfiles/CommonMark_0.30/lists/005.test:
%   ---RESULT--- "example": 305,
%
%
The number of windows in my house is

%

%
The number of doors is 6.

%

%
%   ---\RESULT---

<<<
The number of windows in my house is
1.  The number of doors is 6.
>>>
documentBegin
interblockSeparator
olBeginTight
olItemWithNumber: 1
olItemEnd
olEndTight
documentEnd

Here is the result of running git checkout commonmark; cd tests; ./test.sh "testfiles/CommonMark_0.30/lists/005.test":
Testfile testfiles/CommonMark_0.30/lists/005.test
  Format templates/plain/
    Template templates/plain/input.tex.m4
      Command pdftex   --shell-escape                  --interaction=nonstopmode  test.tex
*** test-expected.log	2022-12-22 11:48:55.739015156 +0100
--- test-actual.log	2022-12-22 11:49:02.378957086 +0100
***************
*** 1,7 ****
  documentBegin
- interblockSeparator
- olBeginTight
- olItemWithNumber: 1
- olItemEnd
- olEndTight
  documentEnd
--- 1,2 ----

The issue seems related to the PEG patterns for parsing lists (1, 2), which use the rules for Gruber's Markdown, rather than CommonMark.
Similarly to options blankBeforeBlockquote, blankBeforeCodeFence, blankBeforeDivFence, and blankBeforeHeading, we should add option blankBeforeList with default value of false, which would control this behavior. See also https://github.com/Witiko/markdown/issues/29.


[SPARK-27752][Core] Upgrade lz4-java from 1.5.1 to 1.6.0

What changes were proposed in this pull request?
This PR upgrades lz4-java from 1.5.1 to 1.6.0. Lz4-java is available at https://github.com/lz4/lz4-java.
Changes from 1.5.1:

Upgraded LZ4 to 1.9.1. Updated the JNI bindings, except for the one for Linux/i386. Decompression speed is improved on amd64.
Deprecated use of LZ4FastDecompressor of a native instance because the corresponding C API function is deprecated. See the release note of LZ4 1.9.0 for details. Updated javadoc accordingly.
#134 #137 Changed the module name from org.lz4.lz4-java to org.lz4.java to avoid using - in the module name. (severn-everett, Oliver Eikemeier, Rei Odaira)
Enabled build with Java 11. Note that the distribution is still built with Java 7. (Rei Odaira)

How was this patch tested?
Existing tests.

Test build #105469 has started for PR 24629 at commit 1481cf7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10731/
Test PASSed.

Looks OK for Spark 3 if it brings minor improvements and fixes and is more reliably compatible with Java 11.

Test build #105469 has finished for PR 24629 at commit 1481cf7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105469/
Test PASSed.


Update QueueCheck.php

BUG: DispatchQueueCheckJobsCommand is dispatching a HealthQueueJob Job. But as per the code in the QueueCheck.php file, it's taking based on the driver from the config/queue.php there is no any key named driver.
I have changed it to queue.default so as per the configuration default driver will be used.

Could you rebase with main to make the tests pass?

Sorry @freekmurze I will update and make another PR.


Accessing content in modal box?

Hi, I want to access content within the modal box like this, but it's not working, any idea?
$(document).delegate('*[data-toggle="lightbox"]', 'click', function(event) {
event.preventDefault();
var name = $(".vp-name").text();
$(this).ekkoLightbox({
onShown: function() {
var lb = $(".modal-body").find("span");
$(lb).text(name);
}
});
});
best regards

Look at using onContentLoaded instead

Thanks for answering my question so quickly. Unfortunately onContentLoaded nothing happend at all. I was testing this with a simple alert("")...
I tried this but it isn't working as well:

...
$(this).ekkoLightbox({
onContentLoaded: function() {
var lb = this;
$(lb.modal_content).css("background","red")
}
});
...

Do you have an simple working example :)

All the docs (http://ashleydw.github.io/lightbox/) have events for onShown and onContentLoaded.


Feat: Add NPM package support for the smart contracts

Summary
Enhance the inventory packaging to seamlessly integrate the Solidity code and ABI. This will enable other projects to conveniently import them into their Solidity projects. Once this is accomplished, we can explore packaging an additional utility that generates TypeChain interfaces, simplifying client usage.
Acceptance Criteria
Proper packaging of Solidity code and ABI to facilitate imports.
Successful installation using either npm install @lootledger/inventory-contracts or npm install @lootledger/inventory.

Resolved: https://www.npmjs.com/package/@lootledger/inventory


New Discord.js Error?

Just started outa nowhere, i even updated Discord.js module...

i also faced it

I just ran the bot and it still functioned with no issues. Can you walk me through the steps you took to get that error?

i used repl.it

it gives Linux ig

i have it too
how to fix it

ig this comes in linux

What steps did you take to reach that point?

how to fix it

Hey y'all, Discord updated their application with a new channel type which broke version 11 of the Discord.js library, which is needed for selfbots. I found a workaround and published it in the v11 branch of my discord.js fork, and pushed the changes to this project.
Thanks for letting me know about the issue, sorry it took so long to resolve. Cheers :)


Website

Anyone good at making Single Page sites? I'm working on a concept for vorpal.js.org, but I don't have too much experience on responsive front-end sites, so it'll probably take me a bit.
If you're interested in helping, let me know and I'll shoot you what I've got cooking so far!

I've done some before and I certainly wouldn't have a problem doing it. However, I know another web designer who is much, much better than me and just getting started freelance. I'll see if she's interested and cover the expenses out of my own pocket if you like :).

Wing me an e-mail to<EMAIL_ADDRESS>with the specs and anything else you need, along with a provisional deadline if you think one is appropriate and I'll make sure it gets done.

Thanks @Shakyamuni177te , as gone over in email.

I got the domain registered based on Vorpal gh-pages branch, and put up a very basic starting template for site. Suggestions / contributions appreciated!
http://vorpal.js.org/

The site looks very good as is but I will have a look at the code this weekend when I'm off work and hopefully there is something I can improve further -- I have a feeling there are some subtle improvements we can make to the stylings :). Also, I will see if there is a way Vorpal.js will help with the website we're putting together at work.

Okay great! Yeah there's room for a ton of improvements!

Okay, I've got the basics for the site done, and just submitted to HN, wish me luck! :smile:

Spoke to the web designer and she says she'll take a look at the project over the weekend to see if there's anything she can do to fix it up. We agree there is a potential "White Space" issue but are unsure how to proceed at present. Will seek additional consultation. Just looking into issues with promises myself at the moment, spurred partly by the promises within your own code;

Thanks! Appreciate it!


Update dependencies (and make it easier to do so)

Fixed

Update dependencies (and make it easier to do so)

make update is longer than npm update :)

But requires node on the host machine. I'm still holding out on polluting my machine with that garbage!

Yes, for consistency, we want to use Node in a docker container so that we're all using the same version of node when updating the dependencies (and ideally the same version of Node that we're running in production). 🙂


Importing group commands from separate module

Hi there.
I have two modules. My driver, cli.py, and then another, parser.py, which is in a subdirectory, commands.
I know one can create a group as follows:
@click.group()
def cli():
    pass
@cli.command()
def foo():
    click.echo("sup")

and so forth.
However, according to the docs, if I were to define my subcommands in a separate module (as I have), I must add them as such in cli.py:
from myModule.commands import foo, bar

@click.group()
def cli():
    pass
cli.add_command(foo)
cli.add_command(bar)

and so forth.
Is there any way to avoid the above and instead declare my subcommands like in the first example while also keeping them in a separate module?
Importing my driver cli into parser.py seems to trigger a circular dependency and tells me AttributeError: module 'myPackage' has no attribute 'cli' when I attempt using decarators like @cli.command(). Actual code as follows:
from quoteBot.quoteBot import cli

@cli.command()
def extractTXT(file):
    """Extracts quotes from a .txt file.

    :param file: the file being parsed
    """
    click.echo("extractTXT called!")

Using import quoteBot.quoteBot syntax throws the same error, FYI.
This is not a "make or break" issue, I am just interested to know if such logic is possible. Thank you for your time.

Could you clarify the folder structure of your .py files?
Is it?
-cli.py
-myModule/
    -commands/
        -parser.py

It's a bit hard to tell what the issue might be.

My bad, that is clearly something I should have included. Here is the package:
├── LICENSE
├── MANIFEST.in
├── quoteBot
│   ├── commands
│   │   ├── authenticate.py
│   │   ├── __init__.py
│   │   ├── parser.py
│   │   └── tweet.py
│   ├── __init__.py
│   ├── __main__.py
│   └── quoteBot.py
├── README.rst

My naming might have slightly changed since the original post. cli is inside quotebot.py and is still the driver.
Thank you for taking the time to respond :slightly_smiling_face:


Is Using the program as an Emulator with a different langage program

Payment service provider
Visa
Payment terminal
ingenico
Communication Logs
No response
More information
Hello, i'd like to know if it's possible to use the program as an emulator? I do not use c# but i can add .dll libraries to my project. The more i read the code and the information i try to wonder if it's possible to use it as an emulator or you need a real EPT ?
Thank you, sorry for the bother I'm a begginer and I have a task to code a EPT communication but I cannot test it :/

Hi, sorry this project is not a simulator, it need a real hardware.

thank you very much for your fast anwser, the project is very cool maybe i'd get to use it if i get a real hardware.
best wishes


Clean up build files

We currently have many files doing redundant things including:

[ ] multiple Dockerfiles
[ ] multiple 'run-x.sh' files

Would be good to merge some of these.

blocking for now - want to stabilize frontend build


Default .imgbotconfig

@dabutvin I'd like to suggest a couple of related .imgbotconfig ideas:

[ ] I'd like to store a default .imgbotconfig on imgbot.net to be used when the target repo hasn't 1.
[ ] I'd like an option to include that .imgbotconfig as part of the commit that 🖼🤖 PRs.

GREAT IDEAS 🎉 🎉 🎉

Evidence video intercepted from identity thieving cyber criminals

and how about a default .imgbotconfig in the .github repo of the user/organization?


Add paper: Collage Diffusion

A work from Stanford University that applied text-conditional diffusion models.
Thanks, heejkoo!

I updated the paper. Thank you!


New rule: Accessibility rule around emoji

It's very easy to make emoji inaccessible and @LJWatson wrote a very nice and short article about it: https://tink.uk/accessible-emoji/
eslint-plugin-jsx-a11y has a rule for this that we could emulate: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/accessible-emoji.md

(changing difficulty from Medium to Easy because the source rule is relatively simple... and I love emojis)

Hi! I'd love to give this a shot for Hacktoberfest and improve accessibility on the web.

💀 It's time! 💀
TSLint is being deprecated; therefore, it and tslint-microsoft-contrib are no longer accepting pull requests for major new changes or features. See #4534. 😱
If you'd like to see this change implemented, you have two choices:

Recommended: Check if this is available in ESLint + typescript-eslint ✅
Not Recommended: Fork TSLint or tslint-microsoft-contrib locally 🤷♂

👋 It was a pleasure open sourcing with you!
If you believe this message was posted here in error, please comment so we can re-open the issue!


What's new in webpack 2.1?

Thank you for this awesome work.
I noticed that the beta version was updated to 2.1.
Why not 2.0? Is there any ChangeLog for this version?
@sokra

because of #2004


Ci fix golint

Current coverage is 79.68% (diff: 100%)

Merging #68 into master will not change coverage

@@             master        #68   diff @@
==========================================
  Files            10         10
  Lines           753        753
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            600        600
  Misses          105        105
  Partials         48         48

Powered by Codecov. Last update d6e617f...9addf68


Increase frame buf size

This PR increases the frame name buffer size from 800 bytes to 1kb, and also changes the truncation of the method signature to use the remaining capacity of the buffer instead of 255 const.

Hi @guybortnikov - I'm curious what the motivation for this change is - could you add it to the PR description please?

@richardstartin

Hi @guybortnikov - I'm curious what the motivation for this change is - could you add it to the PR description please?

Thanks for the feedback, added the motivation to the PR description.

It's not the first time I see this issue, however, up to the moment it wasn't a real problem. My point is, text-based output formats (including collapsed format) are designed mainly for visualization for end user (who doesn't parse 1KB strings by eye anyway). For computer processing, there is a jfr format.
On the other hand, the suggested PR does not fix the root cause, just makes the issue appear less often.

I committed the fix to allow unlimited length signatures in collapsed format.


Update index.md

completion of the solution to the problem

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[ ] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

Hi can you please take a look at our Guidelines for Contributing

My pull request has a descriptive title (not a vague title like Update index.md)

Thanks.

I suggest adding a specific title...

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Thank you and happy coding.


Meta Dashboard for Manipur- error in Patient by Age

https://mn-data.10bedicu.in/public/dashboard/e4a58566-ade1-4f20-9ff5-fc5b572a4f4f
Here the total number of patients shown are 215, However, in the section with "Patient by Age" the number in the center of the Pie Chart is 2148. This is incorrect.
Correct this number to reflect total number of patients.

Issue resolved by Gigin

@aparnacoronasafe You can close the issue if it's resolved 😄


fix: side panel label scroll

With a label added to the side panel scrolling leaves too much below the collapsed title.
https://ibm-products.carbondesignsystem.com/?path=/story/ibm-products-components-side-panel-sidepanel--slide-over&args=size:md;labelText:asdf
Initially

After scroll

With fix

What did you change?
Use of translateY for margin-top
How did you test and verify your work?
Storybook

Stopped happening locally, not sure why


Remove duplicates

This PR removes duplicated definitions of type_annotation_separator and type_bound_colon.
Also fixes a typo in the document of src/lists.rs.

Tests are also failing. You can run cargo test locally to check tests. I think you only need to reformat your code.

@nrc Thanks! I was embarrassingly running cargo test on master branch...
Fixed & Rebased.

Thanks!


Accessing both Photos and Videos on Android

Description
Cannot access both Videos and Photos in the Android Gallery.
Solution
Make it behave similarly to iOS with the 'mixed' type on the mediaType option

Any success on this?

Any progress or news about it?


The descheduler supports limiting the total number of pods evicted per rescheduling cycle

The MaxNoOfPodsToEvictTotal serves to prevent scenarios where an unintended issue, such as a software bug or incorrect usage of Pod Disruption Budgets (PDBs), could result in a substantial number of pods being evicted simultaneously, potentially compromising the availability of services.
Fixes #1449

/kind feature

/ok-to-test

/approve
/lgtm
Thank you

@zhifei92 can you also open a separate PR and extend https://github.com/kubernetes-sigs/descheduler?tab=readme-ov-file#top-level-configuration?

@zhifei92 can you also open a separate PR and extend https://github.com/kubernetes-sigs/descheduler?tab=readme-ov-file#top-level-configuration?

I'm happy to do this and will probably complete it by the end of this week.


Error when using config from @tamagui/config/v2 on web with Vite

Current Behavior
When using config from @tamagui/config/v2 the site crashes with: uncaught SyntaxError: The requested module '/node_modules/react/index.js?v=d7830096' does not provide an export named 'useEffect'
Expected Behavior
No response
Tamagui Version
1.80.4

Platform (Web, iOS, Android)
web

Reproduction
https://github.com/kaladivo/tamagui-export-error

Run `yarn install && yarn dev`

System Info
System:
    OS: macOS 14.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 578.75 MB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.18.2 - ~/.nvm/versions/node/v18.18.2/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.18.2/bin/yarn
    npm: 9.8.1 - ~/.nvm/versions/node/v18.18.2/bin/npm
    pnpm: 8.13.1 - ~/.nvm/versions/node/v18.18.2/bin/pnpm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Browsers:
    Chrome: 120.0.6099.129
    Safari: 17.1
  npmPackages:
    @manypkg/cli: ^0.19.1 => 0.19.2
    @pmmmwh/react-refresh-webpack-plugin: ^0.5.10 => 0.5.11
    @tamagui/config: 1.80.4 => 1.80.4
    @tamagui/core: ^1.80.4 => 1.80.4
    @tamagui/polyfill-dev: ^1.80.4 => 1.80.4
    @tamagui/vite-plugin: 1.80.4 => 1.80.4
    @types/react: ^18.2.46 => 18.2.46
    @vitejs/plugin-react-swc: ^3.3.0 => 3.5.0
    async-retry: 1.3.1 => 1.3.1
    babel-polyfill: ^6.26.0 => 6.26.0
    css-loader: ^5.2.4 => 5.2.7
    esbuild-loader: ^3.0.1 => 3.2.0
    esbuild-register: ^3.4.2 => 3.5.0
    file-loader: ^6.2.0 => 6.2.0
    html-webpack-plugin: ^5.5.0 => 5.6.0
    mini-css-extract-plugin: ^2.7.2 => 2.7.6
    react: ^18.2.0 => 18.2.0
    react-dom: ^18.2.0 => 18.2.0
    react-refresh: ^0.14.0 => 0.14.0
    style-loader: ^3.3.1 => 3.3.3
    tamagui: 1.80.4 => 1.80.4
    tamagui-loader: 1.80.4 => 1.80.4
    thread-loader: ^3.0.4 => 3.0.4
    url-loader: ^4.1.1 => 4.1.1
    vite: ^5.0.2 => 5.0.10
    webpack: ^5.74.0 => 5.89.0
    webpack-bundle-analyzer: ^4.5.0 => 4.10.1
    webpack-cli: ^4.9.2 => 4.10.0
    webpack-dev-server: ^4.8.1 => 4.15.1

I saw this and tried fixing it a few ways but no luck so far. It's a very weird error. I'll check again soon.

Node 20 / react 18 / vite 5.0.12 / tamagui 1.88.13
in vite.config
    optimizeDeps: {
      include: ["react-dom", "@react-native/normalize-color"],
    }

We've improved how we publish things, adding mjs files and paths-specific imports. Any luck?

This is fixed with latest version of Tamagui


Update README.md to mention Bun

Add better list of supported libraries, make note about Bun support.

See #692


[MM-20420]Migrate 'components/add_groups_to_channel_modal' module and associated tests to TypeScript

Summary

This convert the components/add_groups_to_channel_modal module and associated tests to TypeScript
Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/16154

Hello @Ampit,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook

/update-branch

/update-branch

Error trying to update the PR.
Please do it manually.

Error trying to update the PR.
Please do it manually.

Thank you @Ampit and apologize for delay in getting to this PR.
There is an error when updating, can you please take a look. Thanks.

Thank you @Ampit and apologize for delay in getting to this PR.
There is an error when updating, can you please take a look. Thanks.

@Ampit there's a conflict with master can you please resolve?

@Ampit there's a conflict with master can you please resolve?


Crash while attempting to reforge Mythic Botany Mjoellnir

Attempted affix reforging with Mythic Botany's Mjoellnir, and it caused the client to crash. The Apotheosis version being used is 7.4.2, which last I checked, was the latest offered.
Crash log:
crash-2024-09-23_21.31.08-client.txt

Use the adventure module config to force a type override for Mjoellnir.  They have an IMC message to force the type but it seems to not be working sometimes.


Link to react-admonitions in the README

See issue #18.
https://github.com/nebrelbug/react-admonitions links back to this repo in its README

Awesome 👍


Dataset metadata storage UI

UI part isolated for review.
Based and dependent on merge of https://github.com/epfml/disco/pull/568
We can discuss how we should present this feature to the user (naming, interface...)

Closing along with #568.


#54923 (Timesheet > TimesheetDetail: Update working day for all)

Rename: Done -> PM confirm timesheet done
Click out Popup does not close
Click Edit All  and >= 20 row -> show Working day for all: input -> text change -> update for all row

https://github.com/ncc-erp/ncc-erp-project/assets/153600705/5b93e07f-55ed-4d1b-b6f6-d9a34e81b687


Update troubleshoot-hybrid-join-windows-current.md

Added error for cert urls in mex

@RavennMSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@RavennMSFT: I'm sorry - only the author of this article, @MicrosoftGuyJFlo, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@MicrosoftGuyJFlo can you sign off on this PR

#sign-off


Need measures in numbers!

Need measures in numbers!

Start from

http://stackoverflow.com/questions/2125076/unit-conversion-in-python
https://media.readthedocs.org/pdf/python-measurement/latest/python-measurement.pdf
https://pint.readthedocs.io/en/0.7.2/
http://www.drdobbs.com/jvm/quantities-and-units-in-python/240161101
http://stackoverflow.com/questions/2125076/unit-conversion-in-python
http://www.southampton.ac.uk/~fangohr/blog/physical-quantities-numerical-value-with-units-in-python.html
https://pypi.python.org/pypi/numericalunits
https://pypi.python.org/pypi/measurement
https://github.com/katerina7479/python-units-of-measure


Column 'licenseid' cannot be null after accepting the order

Describe the bug
Every time a customer (in my case a test customer) books a license via the system, I get the following error message as soon as I release the order.
Error: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'licenseid' cannot be null (SQL: insert into mod_tekbase_licenses (serviceid, customerid, licenseid, licensekey, siteip, siteurl, sitepath, version, cms, shop, gwislots, rwislots, swislots, updated_at, created_at) values (31, MeMpbFwD3e8q, ?, Not retrieved yet.
To retrieve the License Key make sure you've set url and path at the settings!, , domain/tekbase/, /var/www/vhosts/domain/httpdocs/tekbase/, private, ?, ?, 1, 1, 1, 2022-02-10 13:35:27, 2022-02-10 13:35:27))
domain is replaced with the correct values in the original error message and is only entered here for anonymization.
I hope you can help me to solve the problem.
To Reproduce
Steps to reproduce the behavior:

Create an order as an customer
As Admin, try to accept the order. As soon as you try it the error is displayed
See error

Versions:

WHMCS: 8.4.0
tekbase-whmcs: latets downloadable version

Logs:
10.02.2022 13:35 {"StatusCode":"500","Message":"Server replied with an error."}
10.02.2022 13:35 Module Create Failed - Service ID: 31 - Error: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'licenseid' cannot be null (SQL: insert into mod_tekbase_licenses (serviceid, customerid, licenseid, licensekey, siteip, siteurl, sitepath, version, cms, shop, gwislots, rwislots, swislots, updated_at, created_at) values (31, MeMpbFwD3e8q, ?, Not retrieved yet.To retrieve the License Key make sure you've set url and path at the settings!, , domain/tekbase/, /var/www/vhosts/domain/httpdocs/tekbase/, private, ?, ?, 1, 1, 1, 2022-02-10 13:35:27, 2022-02-10 13:35:27))

Has been fixed in the new Release =)


Please add support for device "qmi.plug.psv3"

Device model
qmi.plug.psv3
Device name
Xiaomi Smart Power Strip 2 (5 outlets)
Does the device require a MiCloud connection?
Do not know
Anything special about the device?
Does it already work with the plugin with a limited scope (can be controlled using the auto created switch)?
Not working at all, however the tile appears on Homekit correctly but I can not control it.  When I click on the tile, the tile will show "No Response".  This device is a Bluetooth device connected to Xiaomi Smart Home Hub 3 using its Bluetooth mesh.  I can control the device from Xiaomi App nicely.
Best regards,
Ung Sing

Unfortunately it is not possible right now to control Bluetooth devices. The plugin only works with wifi devices.


Raw Data Display

I am using my Huawei Watch to run your Android Wear app; however, I am stuck with this "getting data" view. Any idea how I might go about fixing this so I can view the raw data and see the shake/rotation detection like you did in your video?

Do you see anything when in the Android Studio console output that might provide a clue? Unfortunately, I don't have an Android Wear device anymore to test with, so it'll be for me to debug on this end...


Fix the metaspace leak that occurs every time a policy is evaluated or a policy set is created

Summary: Instantiate a new GroovyConditionShell instead of using it as a Spring-managed bean so that it's garbage-collectible when it goes out of scope.
Changes:

[x] Increase Groovy compilation performance by using its invoke dynamic support; internally, it uses the invokedynamic bytecode instruction that underpins Java 8 lambdas.
[x] Remove @Component from GroovyConditionShell and directly instantiate it where necessary so that, once it's used in the scope of a request, it is electable for garbage collection instead of being held onto by Spring IoC as a managed bean. The memory effects of this refactoring are that the metaspace and heap will grow similarly instead of the former being asymmetrically higher than the latter.
[x] Always remove any loaded classes from the underlying Groovy shell's ClassLoader after parsing or execution is complete.
[x] Remove the unnecessary ConditionShell interface; rather than having multiple implementations of the Groovy shell, there will only ever be one: GroovyConditionShell.
[x] Move the Groovy Script compilation and caching logic from PolicySetValidatorImpl#validatePolicyConditions to GroovyConditionShell#parse where it more closely belongs (and is easier to manage).
[x] Clean up code in classes touched by this PR.
[x] Update Maven dependencies so that tests execute with latest versions of JDK 8.
[x] Update the Jenkinsfile as follows:

Use the migration Kubernetes pod for now until a custom Docker image is created with Keti-specific dependencies.
Switch from parallel to sequential stages (at the expense of longer test runs) so that Jenkins jobs run properly on newer Eclipse jnlp slaves that have less memory.

Notes:
Before the fixes in this PR were applied, unit tests were ran using the public Maven profile on the master branch and the following YourKit memory profile was recorded (with GCs forced every 30 seconds or so to simulate memory pressure):

After the fixes in this PR were applied, the following YourKit memory profile was recorded (with GCs forced every 30 seconds or so to simulate memory pressure):

Note that in the "after" screenshot above, the number of total unloaded classes is drastically greater than in the "before" screenshot.

@sanjeevchopra:

I've added before/after memory profiles to the PR description.
The PR build has been failing since Eclipse moved us to a new CI server. It's fixed as part of changes in this PR.


Ux manage servers

Before submitting, please confirm you've

[x] read and understood our Contributing Guidelines
[x] completed Mattermost Contributor Agreement
[x] executed npm run lint:js for proper code formatting

Please provide the following information:
Summary
Adds a button to the Tab Header which allows the user to add a new team without opening the settings page. Use the new Modal in the settings view as well.
Issue link
#400, #401
Test Cases
Add a new server from the tab header and the settings page.
I added multiple specs that test if newly added teams are being persisted and if the modal behaves as expected in general.
I'm not sure if the way I do error handling is a good idea, I just saw that #400 defines an area where the error message should be displayed - I think that it's best to have the message next to the input that is incorrect but I could change it (might be a good idea to discuss).

Somehow CircleCI didn't build the PR (probably due to preferences). So I made the artifacts in my fork. https://circleci.com/gh/yuya-oc/desktop/132#artifacts

What's going on with the tests? It worked for me locally...

That was pretty obvious... :+1:

Testable artifacts are available. https://circleci.com/gh/mattermost/desktop/839#artifacts

Yay, this is great @jnugh! Will test it out today! 🎉

Thanks @jnugh! This is really well done! I've been testing it out yesterday and today.
There are a few notes / pieces of feedback to consider when you have the chance - even though they might seem like a lot, it's just mostly small UX notes. Functionally everything is working really well! Love it :)
1) "Add Server" dialog

Proposals (based on #400, part 3):
VISUAL:
1a) Change title from Add a new Team to Add Server --> a new team sidebar was added to Mattermost Server 3.6, which allows you to display all your teams on the single interface. So you no longer need a separate tab for your teams, only for your servers
1b) I feel Please specify a server name and a valid Mattermost URL is redundant since we give help text below the input boxes - we could consider removing that sentence from the modal, what do you think?
1c) Update https://example.org to https://example.com (it'll be consistent with other similar examples in Mattermost)
FUNCTIONALITY:
Propose that when a user presses
1d) Enter, the "Add" button action is taken
1e) Esc, the "Cancel" button action is taken
1f) Clicking outside of the modal closes the dialog (carries out the "Cancel" button action) --> I'm not sure how hard this would be to implement, so definitely okay making a separate improvement ticket for it
1g) After hitting "Add" on the dialog (when pressing the "+" icon, not on the Settings page), and the new server appears on the right-most tab of the navigation bar, propose automatically activating that tab for the user.
ERROR HANDLING:
1h) Propose that errors aren't displayed until the user hits the "Add" button or hits Enter. This is consistent with other Mattermost dialogs, and is more forgiving to the user (we want to avoid telling the user they made a mistake, unless they actually made one).
When the user hits "Add" and if there's an error that prevents adding the server, then

highlight the input field in red only (no highlights for the title or help text)
show the error message below the input field, but above the help text, similar to when creating a new channel (see below)

1i) Error messages (from #400)

If no name is provided, show text “Name is required."
If no URL is provided, show text “URL is required.”
If URL is provided but is missing http:// or https://, show text “URL should start with http:// or https://.”

2) "Edit Server" dialog
It looks like clicking "Edit" on the Settings page opens the same "Add Server" dialog without pre-populated information.
Propose that

fields are pre-populated with the previously specified server display name and server URL
title is "Edit Server" instead of "Add Server"
pressing "Cancel" undoes changes and closes the modal
pressing "Save" closes the modal and saves the changes

3) "+" icon
3a) Propose removing the border around the "+" icon in server navigation tab bar -- it makes it look a bit prominent (I noticed that my eyes keep getting drawn to it). (Propose we keep the hover effect though)
3b) To follow the "obvious" design principle, propose we add a tooltip when hovering over the "+" icon, similar to Google Chrome (see below) with text New server.

4) Miscellaneous
This is just something that came to mind during testing and would probably be a separate improvement ticket:
If there is only one server tab, then the "+" icon isn't visible since the server navigation bar is hidden automatically. Hence, it's not obvious how to add a new server in that case.
I'm not a huge fan for showing the tab bar when there is only one server, and I think we should continue to hide it. Otherwise, it would just be wasted space on the app window for those who only have one server.
However, we could consider adding a new option in the menu bar such as Sign in to Another Server or Add a New Server, perhaps under File or Window, which opens the "Add Server" dialog when clicked. That way it'll at least be more discoverable.
Other ideas would be welcome.

Alright, most of these things should be pretty easy to change.
Regarding error handling: There is still some stuff to do but I didn't want to focus on the actual behavior before discussing where to place the message (there is this mockup where it goes to the bottom left):
So when I change the style for invalid inputs, that would would be a general change for all inputs in the desktop app (not inside the web view) - To be honest I'm not sure if we highlight invalid input somewhere else yet - if we do these places would change as well. But as this would be consistent with the Mattermost platform I feel like this should actually be the best way to go.
1a-g) :+1:
1h-i) See above :+1:
2) Nice catch, didn't even notice that I changed the behavior of the server edit function. We could still keep the old edit behavior - might make sense when we add drag/drop reordering...
3) I change the + button into a link - let's see.
4) Would be very easy to add :+1:

Thanks for your response! All sounds good.
1h-i): Ah, you're right. Yes, let's add it at the bottom left instead. User's eyes are drawn towards the "Add" button and hence you notice the error message more easily if it's close to it.
That way you also don't have to move the help text down if there's an error message present.

Yeah, I think using the "Edit Server" dialog would be better for a consistent experience. Also, right now the 'edit server' input fields appear at the bottom of the server list, which isn't necessarily clear to users (it looks like you're adding a new server).

This would also cover part 4 of #400 ticket.
3): Let me know if that's tricky to change, happy to discuss it
4): Awesome, can you help add it in that case? We can add it under File > Sign in to Another Server, which just performs the same exact action as the "+" icon.
Propose adding it as the first item on the File drop-down list.

By the way, @yuya-oc, if you have any feedback about my proposals, please let me know.
Same for you @jnugh, please don't hesitate to suggest other options

Almost was done in above discussion 👍
So I added a review in code.

Thanks for the continued progress @jnugh!

Hey @jnugh! Just checking how things are going? :)

Here comes another bunch of changes :) From what I see, the only thing missing is to change the plus sign... I tried a usual link but that does not match the layout at all. So some more Styling is needed here.

Awesome! :tada:
Let me know if you need any help with CSS on the plus sign styling, I can ask our UI designer to help take a look too.

Please let me confirm. Is the part 4 of #400 intended in this PR? I could not close the modal which is opened by "Edit". And if I click the outside of modal or "Cancel", the server is unexpectedly duplicated.
Repro steps:

Click "Edit" in settings page. ("Add Server" modal opens. This should be "Edit Server".)
Click "Cancel" or outside of the modal.
Click "Add". (should be "Save")
The server is duplicated as a new server.

If the step 2 is skipped, the modal correctly works.
However the key functionality (especially modal) would be done in this PR. So I feel that I can take over the rest though, how do you feel?

That should be fixed now :)
I guess it can be merged if you have no further additions or changes. The Plus button can be changed afterwards...

Thanks @jnugh! Let me test it out as well, thanks for all your help here!

The feature looks working 👍

Thanks @jnugh! Looking great!
Just minor notes:

Team URL should actually be "Server URL". I missed this on the first review

Can we make the whitespace between
a. top line and Server Display Name
b. bottom line and The URL of ... help text

equal?

Animation when closing the dialog

We have a really nice animation for the "Add Server" dialog when it appears (yay!).
However, the same animation doesn't happen when the dialog closes. It's more abrupt.
Wondering if this is easy to update so the experience is consistent?

I noticed the error handling for http:// isn't correct: it actually accepts a URL with just http:

I couldn't reproduce it with our 3.5 release, so seems it might be caused by this PR.

icon: How likely do you think you'll have time to update the styling of the "+" icon? We're considering to cut the release candidate for 3.6 on Feb 7th.

I could ask our UI guru (asaad) to take a look. It might be quick for him and we' be able to apply it already on this PR.

: I use https://www.npmjs.com/package/valid-url, I might switch to something different - any other ideas?
: Yeah if he has time he can definitely do this a lot faster then I could. Would be awesome!

4 - What did we use before? @yuya-oc any suggestions?
5 - I'll touch base with him 👍
Thanks @jnugh for your continued help!

Update: I tested 1) and 2), looks good!
The commit for 3) seems to break the build, so I couldn't test it yet: https://github.com/mattermost/desktop/pull/415/commits/1343dce0edaaba110334f3a52f327130a91b94fc
Also asked Asaad to take a look at 5)

Tests were not waiting for animation - fixed that one.
4) I will use the regex which was used before, drop valid-url.

@jnugh I tested 3) and 4), works great.
@asaadmahmood will take a look at the styling of the "+" sign once this PR has merged.
@yuya-oc please feel free to merge if this looks good to you

Looks good. Thanks @jnugh many times!


declare AnimateImageView as open

Enable inheriting from AnimatedImageView

Current coverage is 76.44% (diff: 0.00%)

Merging #442 into master will decrease coverage by 0.09%

@@             master       #442   diff @@
==========================================
  Files            20         20
  Lines          2106       2106
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           1612       1610     -2
- Misses          494        496     +2
  Partials          0          0

Powered by Codecov. Last update 2c8ebc8...a2f3367


Update data science link

Fixes #711.

[Current coverage][cc-pull] is 99.66%

Merging [#714][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.32%

File ...ookiecutter/utils.py (not in diff) was modified. more

Misses +2
Partials 0
Hits -2

@@           master       #714   diff @@
========================================
  Files          13         13
  Lines         583        583
  Methods         0          0
  Messages        0          0
  Branches        0          0
========================================
- Hits          583        581     -2
- Misses          0          2     +2
  Partials        0          0

[][cc-pull]

Powered by Codecov. Last updated by [cfeece5...b975edf][cc-compare]
[cc-base-branch]: https://codecov.io/gh/audreyr/cookiecutter/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/audreyr/cookiecutter/compare/cfeece5dfb8b95556ffde603dd454954bbe96910...b975edfe096be2aa51ac44d64ffbd1556b2125de
[cc-pull]: https://codecov.io/gh/audreyr/cookiecutter/pull/714?src=pr

@tephyr Thanks for making this change. It looks good to me.
Maintainers, this is ready for final merge review.

Thank you @tephyr for picking this up and @willingc for the review! 🙇


one other mod

challenge-edd
only cause i just want to prank my friend with eduardo lol
plus i just love the mod i’m a eduardo fanatic

uh sure

challenge-edd
only cause i just want to prank my friend with eduardo lol
plus i just love the mod i’m a eduardo fanatic

you sure do ask for alot lmao

yeah lmao but dw man we gotchu, we will work on it

yup.

 Since its using lua

lua to haxe easy

dope, maybe you can show me how to do it

actually not easy im going to kill myself ive been doing so many fucking ports from lua to haxe im tired of fucking things up and making them harder i hate everything

ah

tbh i just need it for backgrounds

im gonna try another way of adding songs to the shit

ah okay, imma try to make lua to haxe for some cuphead shit

since i dont know who

like reading lua is easy if its properly formatted

lets take for example the stage lua from challenge hank folder from the pending folder from the repo

function onCreate()

    makeLuaSprite('city', 'nevada/nevada_city', -600, -100) --the background
		addLuaSprite('city', false);
			setProperty('city.scale.x', getProperty('city.scale.x') + 0.6);
			setProperty('city.scale.y', getProperty('city.scale.y') + 0.2);

    makeLuaSprite('stage', 'nevada/nevada_stage', -400, -220); --the stage where everybody sings!
		addLuaSprite('stage', false);
			setProperty('stage.scale.x', getProperty('stage.scale.x') + 0.6);
			setProperty('stage.scale.y', getProperty('stage.scale.y') + 0.8);

	if not lowQuality then
		makeLuaSprite('foreground', 'nevada/nevada_foreground', -970, -215); --the foreground, aka tent with the word MADNESS on it
			addLuaSprite('foreground', true);
				setProperty('foreground.scale.x', getProperty('foreground.scale.x') + 0.75);
				setProperty('foreground.scale.y', getProperty('foreground.scale.y') + 0.8);

		makeLuaSprite('hill', 'nevada/nevada_hill', -200, 100) --the hill that deimos and sanford occupy.
			addLuaSprite('hill', false);
				setProperty('hill.scale.x', getProperty('hill.scale.x') + 0.8);
				setProperty('hill.scale.y', getProperty('hill.scale.y') + 0.6);
				setLuaSpriteScrollFactor('hill', 0.94, 0.94);
	end
end

hm okay

the function onCreate() is executed when the engine calls the lua on the exact time

as the lua file we are currently talking about is a stage then you have to go to playstate and the place where you create stages

so would you remove that?

here

we read the lua file and we analyze it

ah i see, so for the makeLuaSprite we would have to rename that?

 makeLuaSprite('city', 'nevada/nevada_city', -600, -100) --the background
by reading the FunkinLua.hx file (from newer versions) we can guess that makeLuaSprite its creating a sprite so in haxe it would be like this:

wait

this is better

i see

if we keep reading the lua file we can see that addLuaSprite('city', false); the sprite lua created is being added so thats what the add line does (i forgot what the boolean does there)

ah, so ill let you know if i sorta got i, and if you need to fix it

if we keep reading the lua file (even more) we see this

setProperty changes some property from a lua object in this case a sprite, in haxe it would be like this:

lua is easy if the file you are reading and analyzing is properly formatted and you have a reference of what the functions do (You can open another tab of FunkinLua.hx from your respective Psych Version and search the function throughout the file)

okay

got this in

you gotta translate it to haxe code

ik ik, sorry i hid it so ppl cant get your things,

ok so wait send me the link of what website you’re using for this. i wanna try this out on my laptop!

also can you guys use a seperate issue
you’re blowing up my watch

ik ik, sorry i hid it so ppl cant get your things,

password protected remember

also can you guys use a seperate issue
you’re blowing up my watch

sorry bro

ah lol, sorry


Add launcher sbatch script a cleanup task

Catch the signal sent by scancel, to cleanup /scratch data

Done


re-write test cases: remove global template

The test cases are not quite readable with global template, it's unfriendly for new contributors. And it sometimes messes up with global variables unexpectedly.

@guolinke btw, I think the default early stopping round should be 0 instead of -1; the index of best score is best_iteration - 1, which should be -1 if not meets early stopping

@wxchan I don't got it.
using 0 is ok, but what is problem of using -1 ?

@guolinke we can directly use eval_result[best_iteration - 1] to get best_score (eval_result[-1] is the last element of eval_result list); but I am a little messed up with default best_iteration, default early stopping and the default num_iteration for prediction, not sure which one should be changed.

you want to use eval_result[-1 - early_stopping_round] to get the best_score ?
I think you can open a PR and adapt your change, and we can discuss how to change them.

@guolinke I think only changing default best_iteration = 0 is ok, a simple example:
# coding: utf-8
import lightgbm as lgb
from sklearn.datasets import load_boston
from sklearn.metrics import mean_squared_error
from sklearn.model_selection import train_test_split

X, y = load_boston(True)
X_train, X_test, y_train, y_test = train_test_split(X, y, test_size=0.1, random_state=42)
params = {
    'learning_rate': 0.1,
    'metric': 'l2',
    'verbose': -1
}
lgb_train = lgb.Dataset(X_train, y_train)
lgb_eval = lgb.Dataset(X_test, y_test, reference=lgb_train)

# meet early stopping criterion
evals_result = {}
gbm = lgb.train(params, lgb_train,
                num_boost_round=100,
                valid_sets=lgb_eval,
                verbose_eval=False,
                early_stopping_rounds=5,
                evals_result=evals_result)
ret = mean_squared_error(y_test, gbm.predict(X_test))
ret2 = mean_squared_error(y_test, gbm.predict(X_test, num_iteration=gbm.best_iteration))
print(ret, ret2, gbm.best_iteration, evals_result['valid_0']['l2'][gbm.best_iteration - 1])

# change early_stopping_rounds = 10
# not meet early stopping criterion
evals_result = {}
gbm = lgb.train(params, lgb_train,
                num_boost_round=100,
                valid_sets=lgb_eval,
                verbose_eval=False,
                early_stopping_rounds=10,
                evals_result=evals_result)
ret = mean_squared_error(y_test, gbm.predict(X_test))
ret2 = mean_squared_error(y_test, gbm.predict(X_test, num_iteration=gbm.best_iteration))
print(ret, ret2, gbm.best_iteration, evals_result['valid_0']['l2'][gbm.best_iteration - 1])

output:
7.00593043978 7.00593043978 61 7.00593042305
6.62207310513 6.62207310513 -1 6.62833727028

evals_result['valid_0']['l2'][gbm.best_iteration - 1] not equal to ret here; instead, it's the result of num_boost_round-2 rounds
if change default gbm.best_iteration = 0:
7.00593043978 7.00593043978 61 7.00593042305
6.62207310513 6.62207310513 0 6.62207310293


[5.3] Numerical keys are preserved during validation

My controller has the following method which is accessible via /foo
public function foo(Request $request)
{
    $this->validate($request, [
        '1' => 'required'
    ]);

    return "success!";
}

If I call /foo?1=enter the requests fails. While /foo?0=enter works fine.
The problem only occurs if the field name can be converted to a numerical value:
PHP silently converts array keys to the corresponding integer if possible, e.g. ['123' => 'bar'] is converted to [123 => 'bar']. And the array_merge() function does not preserve numerical keys: array_merge([], [123 => 'bar']) is converted to [0 => 'bar'].

I suggest using alphabetical keys.


add initial support for Python 3.13

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8ee0a14) 99.76% compared to head (5510ccc) 99.76%.
Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   99.76%   99.76%
=======================================
  Files           5        5
  Lines        1277     1277
=======================================
  Hits         1274     1274
  Misses          3        3

Flag
Coverage Δ

unittests
99.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


translate action pickup background color

currently all images use transparent backgrounds for the fill
while this fits my initial use it can be improved

maybe another action to pad based on color


fix macos sim nsh break, fix missing ops in psedofile_ops, fix no -mcmodel=medium in clang.

Summary
after this patch #13498, we add new
  CODE ssize_t (*readv)(FAR struct file *filep, FAR const struct uio *uio);
  CODE ssize_t (*writev)(FAR struct file *filep, FAR const struct uio *uio);

in struct file_operations.
but
static const struct file_operations g_pseudofile_ops
did not update, as there is a pseudofile_unlink in last ops.
case sim:nsh break.
after #14466, add -mcmodel=medium witch is not supported in clang.
-mcmodel=large, should both support  gcc & clang.
case sim:nsh break in makefile.
Impact
change from -mcmodel=medium to -mcmodel=large maybe cause larger codesize? not sure if it's a critical index.
sim:nsh in macos will ready to work with both make and cmake after fix.
Testing
ci-test, local macos with cmake sim:nsh & makefile sim:nsh.

Hi @jasonbu  are there any updates on this PR ?
macos workflow is broken
====================================================================================
Configuration/Tool: sim/configdata
2024-11-06 09:58:37
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Building NuttX...
clang: error: invalid argument 'medium' to -mcmodel=
ERROR: cc failed: 1


TAJO-1576: Sometimes DefaultTajoCliOutputFormatter.parseErrorMessage() eliminates an important kind of information

After the patch is merged, some syntax error message is displayed like the following.
Before the patch :
ERROR: syntax error at or near '('

After the patch:
ERROR: syntax error at or near '('
LINE 31:4      (select *
               ^

Now there is no test for error line number.
It will be added while I work on TAJO-1580.
Please consider it.


[vcpk-ci] Trigger some test ports from vcpkg.cmake changes

What does your PR fix?
The vcpkg.cmake toolchain file is not part of ABI hashing, but changes must trigger at least some testing.
In particular, there must be a test with the minimum supported version of cmake, to avoid issues like #23402.

Which triplets are supported/not supported?

Bumping the port version does trigger the rebuild. But this is not how vcpkg ci is meant to work.

why vcpkg.cmake is not part of abi hashing? i'd consider it as necessary, isn't it?

Cache misses detected but nothin being rebuilt?

Right. We only want to build what is affected by the curent change.
So this is how vcpkg ci is supposed to work.
I just didn't consider the effect of having no change wrt the parent hash.

why vcpkg.cmake is not part of abi hashing? i'd consider it as necessary, isn't it?

This is not a new observation. I guess there is an intention to avoid a world rebuild. (However, given that even documentation changes to maintainer scripts invalidate many artifacts, this strategy isn't applied consistently.)
Anyways, changing this is out of scope for this PR.

Anyways, changing this is out of scope for this PR.

it is, imho. Instead of copying vcpkg.cmake file here and there just to trigger an abi change, why not including it directly in the files computed for abi?

Anyways, changing this is out of scope for this PR.

it is, imho. Instead of copying vcpkg.cmake file here and there just to trigger an abi change, why not including it directly in the files computed for abi?

It is out-of-scope. Make a separate PR if you want to change ABI hashing.

/azp run


windowWidth.toFixed is not a function in viewerMain  [failed to load image]

i have some issues of app in my local host
TypeError: windowWidth.toFixed is not a function
and am not changed anything of code just upgrade node.js

I have the same problem. Did y'all get this problem by running yarn run dev? I worked around it by giving APP_CONFIG some value other than default.j, but I would also like some explanation on what is happening here.

Did anyone find the solution or explanation for this?

According to issue #2138 there is a work around.
I did what @gccgomes and @bianyueyan suggested. I am pretty sure it is not a fix but it is a workaround for CT images

I have the same problem. Did y'all get this problem by running yarn run dev? I worked around it by giving APP_CONFIG some value other than default.j, but I would also like some explanation on what is happening here.

i think the problem come from upgrading some functions on cornerstone library , problem show in CT ,  CT/PT images

I have the same problem. Did y'all get this problem by running yarn run dev? I worked around it by giving APP_CONFIG some value other than default.j, but I would also like some explanation on what is happening here.

i think the problem come from upgrading some functions on cornerstone library , problem show in CT , CT/PT images

How about other image files like DICOM? Did you get them to work?

just SM images work
after changing var wwwc = "W: ".concat(windowWidth.toFixed(0), " L: ").concat(windowCenter.toFixed(0)); into var wwwc = "W: ".concat(Number(windowWidth).toFixed(0), " L: ").concat(Number(windowCenter).toFixed(0));var wwwc = "W: ".concat(windowWidth.toFixed(0), " L: ").concat(windowCenter.toFixed(0)); into var wwwc = "W: ".concat(Number(windowWidth).toFixed(0), " L: ").concat(Number(windowCenter).toFixed(0));
in the ./node_modules/react-cornerstone-viewport/dist/index.umd.js.

I have the same problem. Did y'all get this problem by running yarn run dev? I worked around it by giving APP_CONFIG some value other than default.j, but I would also like some explanation on what is happening here.

i think the problem come from upgrading some functions on cornerstone library , problem show in CT , CT/PT images

How about other image files like DICOM? Did you get them to work?

just SM images work after refactor code in node-modules according to issue

@swederik modifying react-cornerstone-viewport to consider both number / strings resolves the issue: https://github.com/cornerstonejs/react-cornerstone-viewport/pull/115

@swederik modifying react-cornerstone-viewport to consider both number / strings resolves the issue: cornerstonejs/react-cornerstone-viewport#115

i wanna to show , this bug come after last commit team have made in in last version of ohif , i solve it when i reuse older version of ohif and modifying react-cornerstone-viewport to consider both number / strings  it solved but in last version this solution not working

@swederik modifying react-cornerstone-viewport to consider both number / strings resolves the issue: cornerstonejs/react-cornerstone-viewport#115

i wanna to show , this bug come after last commit team have made in in last version of ohif , i solve it when i reuse older version of ohif and modifying react-cornerstone-viewport to consider both number / strings it solved but in last version this solution not working

Can you show which commit introduced the bug?

@swederik modifying react-cornerstone-viewport to consider both number / strings resolves the issue: cornerstonejs/react-cornerstone-viewport#115

i wanna to show , this bug come after last commit team have made in in last version of ohif , i solve it when i reuse older version of ohif and modifying react-cornerstone-viewport to consider both number / strings it solved but in last version this solution not working

@brikjr Can you show which commit introduced the bug?

i don't know exactly which commit , but it's not working in version of 9 mar

I have the same question

I’ll open a PR today to bump react-cornerstone-viewport version in OHIF, this should solve the problem for now. Later I’ll open another that fix the issue in the OHIF metadata level.

I downloaded the latest version of OHIF Viewer, and I still have the same problem in 2D MPR
If you can reply to me, I will thank you very much.

I downloaded the latest version of OHIF Viewer, and I still have the same problem in 2D MPR
If you can reply to me, I will thank you very much.

Looks like this is not a toFixed issue. It could be related but it's a different error in a different OHIF extension that needs investigation, can you create the issue for it with this screenshot?

OK , thank you very much.

Fixed in the latest version!


Folder icon change wont update in Files

Description
Hi,
If I used Files app to change the icon of a folder, it will be shown correctly in windows default explorer, while in Files it will still show the yellow default folder before changing icon. Even if you refresh, close and open again, still nothing.
Steps To Reproduce
Change icon of a folder
Refresh Files
Check Windows File Explorer
Expected behavior
Show correct icon after changing it through Files.
Files Version
Version: <IP_ADDRESS> OS Version: 10.0.22000.556
Windows Version
Windows 11 Pro Version	21H2 OS build	22000.556 Experience	Windows Feature Experience Pack 1000.22000.556.0
Relevant Assets/Logs
NA

You will need to upload the logs files directly to github. You can get them in files settings > about > open log folder.

2022-03-21 00:06:34.1375|ERROR|UnhandledExceptionTrapper|Process with an Id of 14468 is not running.
	System.ArgumentException: Process with an Id of 14468 is not running.
   at System.Diagnostics.Process.GetProcessById(Int32 processId, String machineName)
   at System.Diagnostics.Process.GetProcessById(Int32 processId)
   at FilesFullTrust.Program.TerminateProcess(Int32 processId)
   at FilesFullTrust.Program.HandleCommandLineArgs()
   at FilesFullTrust.Program.Main()
   at FilesFullTrust.Program.<Main>()
2022-03-21 00:43:07.9851|INFO|OnConnectionRequestReceived|Argument: ShellLibrary
2022-03-21 00:43:08.0050|INFO|OnConnectionRequestReceived|Argument: DetectCloudDrives
2022-03-21 00:43:08.0058|INFO|OnConnectionRequestReceived|Argument: NetworkDriveOperation
2022-03-21 00:43:08.0097|INFO|OnConnectionRequestReceived|Argument: GetSelectedIconsFromDLL
2022-03-21 00:43:08.1770|INFO|OnConnectionRequestReceived|Argument: GetSelectedIconsFromDLL
2022-03-21 00:43:08.2406|INFO|OnConnectionRequestReceived|Argument: GetIconWithoutOverlay
2022-03-21 00:43:08.2924|WARN|StartSTATask|The system cannot find the file specified. (0x80070002)
	System.IO.FileNotFoundException: The system cannot find the file specified. (0x80070002)
   at Vanara.PInvoke.HRESULT.ThrowIfFailed(String message)
   at Vanara.PInvoke.Shell32.ShellUtil.GetShellItemForPath(String path)
   at Vanara.Windows.Shell.ShellItem..ctor(String path)
   at FilesFullTrust.Win32API.GetFileIconAndOverlay(String path, Int32 thumbnailSize, Boolean getOverlay, Boolean onlyGetOverlay)
   at FilesFullTrust.MessageHandlers.Win32MessageHandler.<>c__DisplayClass3_0.<ParseArgumentsAsync>b__1()
   at FilesFullTrust.Win32API.<>c__DisplayClass0_0`1.<StartSTATask>b__0()
2022-03-21 00:43:09.2139|INFO|OnConnectionRequestReceived|Argument: GetIconWithoutOverlay
2022-03-21 00:43:09.2483|INFO|OnConnectionRequestReceived|Argument: GetIconWithoutOverlay
2022-03-21 00:43:09.2625|INFO|OnConnectionRequestReceived|Argument: DetectQuickLook
2022-03-21 00:43:09.2763|INFO|OnConnectionRequestReceived|Argument: GetNewContextMenuEntries
2022-03-21 00:43:09.6158|INFO|IgnoreExceptions|Attempted to perform an unauthorized operation.
	System.UnauthorizedAccessException: Attempted to perform an unauthorized operation.
   at Microsoft.Win32.RegistryKey.Win32Error(Int32 errorCode, String str)
   at Microsoft.Win32.RegistryKey.InternalSubKeyCountCore()
   at Microsoft.Win32.RegistryKey.GetSubKeyNames()
   at FilesFullTrust.Helpers.ShellNewMenuHelper.GetShellNewRegistryEntries(RegistryKey current, RegistryKey root)
   at FilesFullTrust.Helpers.ShellNewMenuHelper.GetShellNewRegistryEntries(RegistryKey current, RegistryKey root)
   at FilesFullTrust.Helpers.ShellNewMenuHelper.GetNewContextMenuEntries()
   at Files.Shared.Extensions.SafetyExtensions.IgnoreExceptions[T](Func`1 action, Logger logger)
2022-03-21 00:43:09.7675|INFO|CheckQuickLookAvailability|QuickLook detected: False
2022-03-21 00:43:12.5063|INFO|OnConnectionRequestReceived|Argument: FileOperation
2022-03-21 00:43:12.7516|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:12.9534|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:12.9641|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:12.9649|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:12.9706|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:12.9901|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:12.9927|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:12.9968|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:12.9973|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:12.9979|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:14.5115|INFO|OnConnectionRequestReceived|Argument: LoadContextMenu
2022-03-21 00:43:18.5998|INFO|OnConnectionRequestReceived|Argument: FileOperation
2022-03-21 00:43:23.9465|INFO|OnConnectionRequestReceived|Argument: GetFolderIconsFromDLL
2022-03-21 00:43:31.3737|INFO|OnConnectionRequestReceived|Argument: GetFolderIconsFromDLL
2022-03-21 00:43:34.4295|INFO|OnConnectionRequestReceived|Argument: LoadContextMenu
2022-03-21 00:43:35.8037|INFO|OnConnectionRequestReceived|Argument: FileOperation
2022-03-21 00:43:35.8630|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:35.9566|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:35.9575|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:35.9802|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:35.9816|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:35.9845|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:36.0197|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:36.0203|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:36.0375|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:36.0508|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:37.6588|INFO|OnConnectionRequestReceived|Argument: LoadContextMenu
2022-03-21 00:43:38.7256|INFO|OnConnectionRequestReceived|Argument: FileOperation
2022-03-21 00:43:38.7820|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:38.9894|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:38.9979|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:39.0074|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:39.0220|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:39.0306|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:39.0403|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:39.0517|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:39.0628|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay
2022-03-21 00:43:39.0737|INFO|OnConnectionRequestReceived|Argument: GetIconOverlay```

Is this still an issue in <IP_ADDRESS>?

Its fixed.


Remembering that we should have only 1 branch on this feedstock repository.

Comment:
I've just remembered that we should only have the main branch on this feedstock repository. @mabraham, and @xiki-tempula, can I delete your two branches, and we'll try those as PR's from remote repositories again?

Thanks - just wanted to make sure you weren't surprised by me deleting it :)

thanks


feat!: enforce single pfb per blobtx

Overview
part of #388, split apart from #1154
This PR refactors enforcement of only allowing a single PFB per sdk.Tx and, per feedback in #1154, adds a new block validity rule where all transactions must be decodable!
Checklist

[x] New and updated code has appropriate documentation
[x] New and updated code has new and/or updated testing
[x] Required CI checks are passing
[x] Visual proof for any user facing features like CLI or documentation updates
[x] Linked issues closed with keywords

Codecov Report

Merging #1195 (7584357) into main (4e3b307) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1195      +/-   ##
==========================================
- Coverage   48.17%   48.11%   -0.06%
==========================================
  Files          72       72
  Lines        4056     4061       +5
==========================================
  Hits         1954     1954
- Misses       1930     1935       +5
  Partials      172      172

Impacted Files
Coverage Δ

app/process_proposal.go
0.00% <0.00%> (ø)

x/blob/types/blob_tx.go
19.69% <0.00%> (+2.12%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Create Database for codes to access templates.

[x] Create a database on MongoDB using MLab.
[x] Connect the database to the project code.
[x] Be able to add/remove elements from the database.

issue #4 addressed. + 150 pts.


Cannot build with WKWebView

Not sure if this is a plugin error or a Telerik WKWebView plugin error:
mobileapp/platforms/ios/ZK/Plugins/nl.x-services.plugins.socialsharing/SocialSharing.m:33:24: error: no visible @interface for
'UIView' declares the selector 'stringByEvaluatingJavaScriptFromString:'
return [self.webView stringByEvaluatingJavaScriptFromString:@"window.plugins.socialsharing.iPadPopupCoordinates();"];
http://pastebin.com/Gy9sFRnC
I have Cordova 4.3.0 and "dev" platform.

Hi David, which version of WKWebView plugin are you on? I just created a new CLI project with the master branches of both and it worked fine on my iPad 8.3 emulator.
Or is your cordova-ios plaform perhaps 4.x? I have 3.8.

ddahl$ cordova platform
Installed platforms: ios 4.0.0-dev
Should I be on 3.8 instead?

4.0.0 seems to have some more nasty issues (so I heard).
This particular issue is caused by the fact that cordova-ios now uses a superclass of UIWebView to make it easy to swap in/out WKWebView. This means plugin authors like myself need to change some code to be compatible with the cordova-ios 4 release.
I'd recommend using 3.8 for now unless you want to be the canary in the colemine for other plugins as well.
But I thank you for reporting this, because obviously I need to change a few bits for cordova-ios 4.

Ok, looks like my build works with the Telerik wkwebview plugin & platform 3.8.x, but I cannot get a build working with the cordova one. Thanks!

Thanks for helping me out! I remember meeting you in Mountain View at Moz once! I'll see you around as I am doing a bunch of Cordova stuff;)

I'm having a similar  issue, but I'm using cordova iOS 3.8.
no visible @interface for 'SocialSharing' declares the selector
'cycleTheGlobalMailComposer'
[self cycleTheGlobalMailComposer];
(followed by many other failures)
I had to install my plugin manually, as it was not recognized.

I usually remove the platform and add it again then add plugin build, add plugin build till it breaks

Thank!
I tried that and it worked!


treewide: move to by-name

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Apologies for being annoying, but in order to be more accurate and avoiding some confusion ("oh someone migrated all packages already???"), reword the commit as treewide: move packages maintained by aaronjheng to by-name.

Done


Date Range Filter

Hey! I love Mongo Datatables, it made it a lot easier to implement.
There was a few things i'm still trying to figure out how to add. One of them is how to add a calendar that would let someone pick a date range to search for. I've got the dates stored in the backend as datetime objects, and right now have a class for decoding the datetime objects before they get sent to front end.
I was also looking to figure out how to have a drop down for certain columns so that you can see all the unique values in that column and then pick one to filter on.
I'm only using Flask, if you have any ideas on how to do this let me know :+1:
Thanks!

Hey @uBadRequest! Thanks for the message. I've have had good luck with daterangepicker, which I've used as part of the Bootstrap AppStack theme, for selecting start/end dates and sending it to the server. However I didn't integrate it with DataTables, which seems like an interesting challenge.
The column drop-down isn't something I've considered, but I think @reinoldus, who contributed to mongo-datatables last year, did something similar--adding a search box for each column. Here's that discussion.
https://github.com/pauljolsen/mongo-datatables/issues/2
Hope this helps!


gN doesn't work with 'nowrapscan' when cursor is after last instance

Create new file:
foo
bar
foo
baz

search for 'foo':
gg*

move to last line:
G

type gN with wrapscan; it works correctly (foo on 3rd line is visually selected)
set wrapscan
gN

unset wrapscan, move back to last line and type gN; cursor doesn't move, nothing is selected;
set nowrapscan
G
gN

I'll have a look

posted a patch https://groups.google.com/d/msg/vim_dev/mUAC1Iy3mQw/UieNp_kACAAJ

fixed https://github.com/vim/vim/releases/tag/v8.0.1148


(chore): [LL] CVS v3 migration on Market

✅ Checklist

[x] npx changeset was attached.
[ ] Covered by automatic tests.
[x] Impact of the changes:

New API

📝 Description
The main objective of this PR is to use CVS v3 on the MArket part in all LL.
Redesign of certain functions in live-common
Use in LLM

List / details
Use in LLD
List / details
Improvements to the UI

More details in Jira ticket
❓ Context

JIRA or GitHub link: LIVE-11753

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

/generate-screenshots


New Contribution

Contributor: [polymaer]
SSH Public key:  ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIP/kDKGSKxj5g2WxMr9Q6mwFt3NdK48YxwrUMhyLWtGS
Attestation: [any form of attestation for contribution (e.g., signature) - Optional]

Finally it turns to me🙂

I'm ready😉

Start download

Start contribute process

On uploading process

@zvorcuit Hi sir, upload process complete, please check it.

0x6d2e9f09aae4ad1eec01881e866407d47ce58f87
Thanks!


API under / is not rendered properly

Hi
I've setup urls like below:
urlpatterns = [
    url(r'^docs/', include('rest_framework_swagger.urls')),
    url(r'^uk_postcode/', include(postcodes_urls)),
    url(r'^/', include(postcodes_urls))
]

postcodes_urls is as follows:
urlpatterns = [
    url(r'^/$',
        UKPostcodeValidateView.as_view(),
        name='validate_uk_postcode'),
]

Problem:

Rendering is invalid:

/api/docs response contains lists of apis (including / ) :

{"info":{"description":"","license":"","title":"","contact":"","termsOfServiceUrl":"","licenseUrl":""},"basePath":"http://<IP_ADDRESS>:8000/docs/api-docs","swaggerVersion":"1.2","apiVersion":"0.1","apis":[{"path":"/"},{"path":"/uk_postcode"}]}

and when iterating over nested apis documents (/docs/api-docs/uk_postcode) it calls again /docs/api-docs/
is it valid issue?

I am not sure I understand the problem. However, the schema generation has changed in v2 and is now handled by Django REST Framework.