prepare for embassy-time 0.3.1 release

A release a day, keeps the doctor away.
This adds a convenience script I've been using to bump crate versions. I'd like to improve on this, maybe converting it to a project-specific crate that discover the dependency trees for a crate in the repo and bump it that way, but for now it's better than nothing.

bender run


Update ci build for ubuntu

build this

this was set to force-fail as a test. New PR should build.


Image doesn't support redirects

If I set the source to http://graph.facebook.com/XXXXX/picture?type=large, no image shows up.
How should I support (max)redirects?

It looks like a bug in the Android HTTP client (works fine on iOS). I added a reproduction project here:
https://github.com/hdeshev/nativescript-image-redirect

This issue was moved to NativeScript/NativeScript#2176


Cannot find module "styled-jsx/inject"

Module not found: Error: Can't resolve 'styled-jsx/inject'

At styled-jsx v0.0.5
Using it with preact and webpack 2. Here is the code.

Same error here, with React and Webpack 1.
My component:
function List(props) {
  return (

      {props.comments
        .map(comment =>

            <FormattedMessage id="comment" values={{ text: comment.text }} tagName="h1" />

        )
      }

  );
}

My .babelrc:
{
  "presets": [
    "latest",
    "stage-2",
    "react"
  ],
  "plugins": [
    "styled-jsx/babel"
  ]
}


Add forceShutdown core management operation

This is a proposal of an operation to shutdown not just the artemis server but the JVM itself. This feature would allow us to avoid creating a parent process to control the JVM lifecycle. Apologies if there is already some way to do this remotely.

Closing this as https://github.com/apache/activemq-artemis/pull/727 fixes my issue.


app for Symbian OS

Original issue 30 created by darkwarez.pl on 2011-02-15T03:33:27.000Z:
What steps will reproduce the problem?

try to download authenticator for symbian
try to download authenticator for symbian
try to download authenticator for symbian

What is the expected output? What do you see instead?
I want symbian os authenticator, i see void instead
What version of the product are you using? On what operating system?
i cant use any version, im using symbian os nokia
Please provide any additional information below.
please tell me if authenticator for symbian on is planned?

It's 2016, I don't see anyone writing a new app for Symbian.
Seems you have a solution anyway.
For both of these reasons, I'm closing the bug.


How to use on Windows?

Dear Daniel,
I want to use it on my window system, but it seems that it cannot connect to my smart card? Any suggestions?
Or can you provide me with some samples code?
I can’t even connect to my smart card now when I only call establishContext() method.
thank you.

Hi,
Please have a look at the Prerequisites section of the README. There's no implementation of this API on Windows yet.


add a full breadcrumb trail across packages

via @mato in mirage/mirage#609
A "Path" navigation header with the full hierarchy. E.g. rresult/Result.html currently has "Up", which takes me to the package's index.page but I can't go "Up" from there to the main package list.

I don't think I'll add a full breadcrumb, choice is not necessarily more efficient from an UI point of view.
What I'd like is on each page:

A direct link to the list of packages
A direct link to the root of the current package
A consistent Up link located at the same place on the trail that brings you from the current page to the package list.

But for this I need https://github.com/ocaml-doc/odoc/issues/14

Consistent up-link until you hit the package index has been implemented in both backends, though in the ocamldoc backend you may have to move your pointer because of https://caml.inria.fr/mantis/view.php?id=6928


Pushes to gitlab fail with SSL error

from https://github.com/bazelbuild/rules_docker/issues/820:
When attempting to run a docker push through a container_push rule to a registry.gitlab.com target, I am recieving the following error:
registry.gitlab.com/gauntletwizard/bazel-go:{BUILD_EMBED_LABEL} was resolved to registry.gitlab.com/gauntletwizard/bazel-go:foo
F0430 20:27:05.873595 4586 fast_pusher_.py:194] Error publishing registry.gitlab.com/gauntletwizard/bazel-go:foo: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:727)
Users report they have made no change to their dependencies. Error is coming from containerregistry libraries so posting here. My suspicion is something changed in registry.gitlab.com that makes it so that containerregistry is no longer being able to validate certificates.

@nlopezgi Is there a way to set PYTHONHTTPSVERIFY property in bazel, such that it trickles down to containerregistry? (found this thread to turn off cert verification in python: http://blog.pengyifan.com/how-to-fix-python-ssl-certificate_verify_failed/)
Also is it possible to figure out for which URL cert verification is failing? The SSL cert for https://registry.gitlab.com seems to be fine - current cert is valid from March 23rd, 2019 - May 22nd, 2020.

The issue is coming from httplib2. You can reproduce the issue using the following python code:
`import httplib2
h = httplib2.Http()
h.request('https://registry.gitlab.com')
`
And the issue can be resolved by adding the root certificate to the Http definition.
`import httplib2
h = httplib2.Http('./USERTrustRSACertificationAuthority.crt')
h.request('https://registry.gitlab.com')
`
The root certificates used by httplib2 are coming from the cacerts.txt file.
(https://github.com/httplib2/httplib2/blob/master/python2/httplib2/cacerts.txt)
registry.gitlab.com probably switched the root CA last week and that has triggered the problem.
I don't see any option in the containerregistry registry code to specify a CACerts file.
I see three open PRs related to configuring CA Certs.

https://github.com/google/containerregistry/pull/52
https://github.com/google/containerregistry/pull/134
https://github.com/google/containerregistry/pull/89

However, they have been open for a while. Is there any workaround for this problem that others have used?

I'll try updating httplib2 for containerregistry.

Until support is available in httplib2, use an http_archive patch: https://gist.github.com/arcticwaters/d3310d2b6e362a277501615c6ff07878. This patch works for gitlab.
Containerregistry won't register that repository if one is already defined so it has to go at the top of your WORKSPACE. Downside: you'll have to remember to update when containerregistry updates httplib2.

I came up with my own hack to get it to work. But the patch approach seems better. Thanks for sharing!

This is still a problem. Is anybody looking into it?


Create Watcher

Interact with faucet

Motivation
(Write your motivation here)
Test Plan
(If you changed any code, please provide clear instructions on how you verified your changes work.)
Related PRs
(Link any related PRs here)

Please add sufficient context to PRs.


FR: adding support for pagent

Hi there,
sine i use do not allow password access to my SSH server, i use pagent on Windows to access my server. Can you please add support for pagent or keybased access also on Windows? I would prefer setup via pagent other a path to the keyfile.

Yes, i know. But the readme says, that i should set "agent": null. If i do this, i get [sftp] All configured authentication methods failed. However, i could successfully connect via putty and winscp with pagent.

Ok, if i understand this correctly, i should use
{
    "protocol": "sftp",
    "host": "<IP_ADDRESS>",
    "port": 22,
    "username": "user",
    "uploadOnSave": true,
    "remotePath": "/path/to/folder",
    agent: pageant
}

instead of my current code with the quotes:
{
    "protocol": "sftp",
    "host": "<IP_ADDRESS>",
    "port": 22,
    "username": "user",
    "uploadOnSave": true,
    "remotePath": "/path/to/folder",
    "agent": "pagent"
}

{
  "agent": "pagent"
}

Ahhhh.... now it works... many many thx. I use "agent": "pageant"


[terra-dropdown-button] - Primary action is not interactable while menu is open

Bug Report
Description

The primary action of the SplitButton is non-interactable while the menu is open.
Steps to Reproduce

Click on the Split Button.
While the Menu is open click the primary action on the Button itself.
Observe the primary action is not invoked and the menu remains open

Additional Context / Screenshots

Clicking Reply will not invoke the primary callback and the menu will remain open.
Expected Behavior

Clicking the primary action while the dropdown menu is open should invoke the primary action callback and close the dropdown menu.

This is a dup of #2572.

@nramamurth The descriptions of these two issues are slightly different. This issue specifically targets the primary action not being fired when the button is clicked.
Will the solution proposed in #2572 resolve the primary action not being invoked or will it only resolve closing the Menu when the primary action is clicked?

@StephenEsser
As far as I know, @lokesh-0813 is working on resolving both the issues - the primary action not being invoked as well as closing the menu.

Had a talk about this earlier with @neilpfeiffer during weekly webEx call. Recommended behaviour was upon clicking primary button, the menu should be closed and the primary button action not be fired.

Correcting previous comment @lokesh-0813:

UX does want the primary action to be invoked/fired when pressed, even if the menu is open, and then closes the menu after pressing.
Focus would then be returned to the primary button (instead of the caret button as it does currently after programmatically closing the menu.
All other buttons and UI surrounding the split button would be covered by an overlay, does not honor clicking when the menu is open, and closes the menu if attempting to click anything around the primary button, caret button, or menu.

Correcting previous comment from @lokesh-0813 and confusing wording listed above, whether the primary button SHOULD or SHOULD NOT be able to be pressed and be fired:

UX DOES want the primary action to be invoked/fired when pressed, even if the menu is open, and then closes the menu after pressing.
Focus would then be returned to the primary button (instead of the caret button as it does currently after programmatically closing the menu).
All other buttons and UI surrounding the split button would be covered by the clear-overlay, they do not honor any clicking when the menu is open (captured by the overlay), and then closes the menu if user clicks anything around the primary button, caret button, and menu. (which means the overlay needs to be below everything else inside the split-button component, including the primary button)

Hopefully this clears up the miscommunication?

I will have the overlay implementation cover the split button. This approach should solve more than one issue. Thank you.


refactor(vis-type: bar): use echarts for bar chart

Closes https://github.com/datavisyn/visyn_core/issues/89
Developer Checklist (Definition of Done)
Issue

[ ] All acceptance criteria from the issue are met
[ ] Tested in latest Chrome/Firefox

UI/UX/Vis

[ ] Requires UI/UX/Vis review

[ ] Reviewer(s) are notified (tag assignees)
[ ] Review has occurred (link to notes)
[ ] Feedback is included in this PR
[ ] Reviewer(s) approve of concept and design

Code

[ ] Branch is up-to-date with the branch to be merged with, i.e., develop
[ ] Code is cleaned up and formatted
[ ] Unit tests are written (frontend/backend if applicable)
[ ] Integration tests are written (if applicable)

PR

[ ] Descriptive title for this pull request is provided (will be used for release notes later)
[ ] Reviewer and assignees are defined
[ ] Add type label (e.g., bug, feature) to this pull request
[ ] Add release label (e.g., release: minor) to this PR following semver
[ ] The PR is connected to the corresponding issue (via Closes #...)
[ ] Summary of changes is written

Summary of changes

Screenshots
Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

The last commit computes the correct data for each facet bar chart.

It also works in combination with grouping.

Current status with scrollable facets and correct chart height depending on the grouping and facets.

Incoming selections are highlighted in the bars

Group by numerical columns: values are binned and displayed as categories

Tooltip on hover in Mantine colors

I truncated the labels of the group axis if they are longer than 50 characters. For the screenshot I reduced the length to 10 characters to show the effect:

You can also see that the bar height of non-grouped bars is fixed (and higher now).

If I open up the bar chart in a freshly loaded tissue workbench, all bars are at 100 %

If I switch to a different Aggregate type, e.g. Average, and then back to "Count", then it looks right

Vertical looks weird

Grouping doesn't do anything. The grouping options also list Name (STRING) and Age (NUMERICAL), which I don't know if it makes sense
https://github.com/user-attachments/assets/002bec35-fe7a-4ea7-b9f0-72c48e30f481

Faceting doesn't work. It only lists the headers

When I click on a bar to select, there is a little "0" visible

When I click on a bar and hover over the others, there is a flickering
https://github.com/user-attachments/assets/0284f38f-0ea5-4c61-b862-f171a2a32e1d

Sentence case

If we have many categories, the legend overflows and also the numbers overplot. I think we could remove the numbers by default and only show then on hover. I don't know if I needed to scroll down, but the max bar length could be wider

If I set a Group attribute (Gender in this case), the chart is actually stacked instead of grouped. I need to switch to Stacked and then back to grouped to get the actual grouped bar chart

then it works

Closing in favor of #497


Password change from .ini file is not working

Password change from .ini file is not working. But when generated manually, and database edited, it works.

The problem might be a double hashed password.


ExpiresFilter enhance should-not-cacheable verification

Skip response with Cache-Control: no-store.
Introduce "ExpiresIncludedMethods", "ExpiresIncludedResponseStatusCodes" initial parameters to improve configurability.
Testcase added.

This doesn't need to be this complicated.
RFC 9110 does not define the list of cacheable status codes, it defines a list of "heuristically cacheable" status codes. Also, the filter already has a mechanism to exclude some status codes.
For the purposes of this filter it is sufficient to only add the cache headers for GET and HEAD. I don't see a need to make that list configurable.
If the application has set any sort of Cache-Control header, this filter shouldn't be adding to or changing that.

Having looked at the spec again, we don;t need to be that strict about Cache-Control headers set by the application.

Commit c65d66d has prevented most of unexpected cases.


Changed original survey-multi-choice plugin to include data for each …

…question in a separate row.

Do you know why it's not possible to see changes from the older file? Did you do something strange?

It's probably because this is a new file. The original plugin is in the plugins directory. This is in the custom_plugins. They work exactly the same except for the data they output

ah, I see. The folder is different. Is this a standard or a custom_plugin? (Before it was in "plugins" I believe)

This guy:
https://github.com/expfactory/expfactory-battery/blob/master/static/js/jspsych/plugins/jspsych-survey-multi-choice.js

It seems confusing to have both - can we choose one? And make sure all the experiments that use the plugin have the paths updated in their config.json

I created it in the custom_plugins folder and kept the original one in the plugins folder (similar to the jspsych-multi-stim-multi-response.js plugin where there is both an original in the plugins folder and a slightly modified one in the custom_plugins folder)

It is slightly confusing I agree. I just modeled it based on how the multi-stim-multi-response plugin was placed. The config files specify the correct one and keeping it this way others can simply change the folder there. Do you think that makes sense?

Hmm, I want to suggest that we have a README.md in the custom_plugins folder that, for each custom plugin, details the original functionality, and how the modified one is different. My worry with the current structure / redundancy is that it will get confusing very fast what the custom scripts are doing, and how they are different. Would that be possible to add to this PR?

That's a great idea and I think we should have it not just for the modified but all the custom_plugins. I'll start it for the plugins i have written or modified mirroring the jspsych documentation as much as I can and add it to the pr

awesome! Now that we have all these updated experiments (45 valid!) I'm going to see if I can update expfactory.github.io. This isn't a huge priority, but I think (soonish) we should switch to some view that can explore tasks based on Cognitive Atlas stuffs.

@vsoch finished documentation for a bunch of the custom plugins as well as completed updating the custom plug in surveys with new name. Made sure to resolve conflicts with the most recent version of master. Am I missing anything?

I think it looks ok - and this is rebased, etc? @IanEisenberg can you take a look and make sure everything looks ok? When you guys are satisfied, feel free to merge!

Yes should be rebased. @IanEisenberg let me know if all is good so we can start testing surverys


finish command line reading

hi @BrooklinJazz !
so as happened during our meeting last week, i had to manually change the "command-line-reading" entry in the progress.json file for git to be able to compare the command-line-reading branch with others and thus create the pull request. hope to resolve this issue asap!

I'm not sure I understand why you had to manually change the file. You should never have to manually change that file. 🤔
If there's no diff to compare, that usually means you have already merged the change in.

Lets take a moment to chat about this tomorrow when we have a chance

Sure thing! Thank you for your attention.


Release of Ansys client in Q3D and HFSS Renderers

Information

Qiskit Metal version:
Python version: 3.7.8
Operating system: Windows

What is the current behavior?
No functionality to disconnect from HFSS or Q3D at the renderer level. Release is handled in the pinfo from pyEPR and only for Ansys renderers. This causes Ansys to not be able to close except through the task manager.
Steps to reproduce the problem
Create a project in HFSS or Q3D using
q3d = design.renderers.q3d or hfss = design.renderers.hfss
Open a connection to Ansys using
q3d.open_ansys_design() or hfss.open_ansys_design()
Try to close Ansys manually once a connection is successfully established.
There are no high level commands to terminate this connection at the level of the renderer.
The HFSS project can be closed with hfss.pinfo.disconnect() which is built into pyEPR, but performing such on a Q3D project results in an error saying that there is no HFSS session added. This is due to an assert clause in the disconnect function of pyEPR requiring an HFSS setup to be connected to.
What is the expected behavior?
The renderer for both HFSS and Q3D should have a function to close the connection to a project and release it for the user.
Suggested solutions
The connection to the Ansys server could be moved up in the hierarchy to the Ansys renderer, or add a change to pyEPR to better handle the deliniation between HFSS and Q3D

There does not seem to be an easy way to do this. Current plan is to wait for the conversion to the official Ansys pyAEDT library and see if the problem goes away.
@warrench , any thoughts/preferences?

We are working on the pyaedt renderers.  This problem goes away for Ansys when we switch to pyaedt renderers.


BSO Quest cape

Since the master cape icon is on the new Capes CL, suggestion to change the ability to buy the quest cape back to 280qp (or current QP limit on osrs if that's changed) and make the master cape buyable when you hit 5k QP.

This has been fixed.


ci: fix kuttl test

This PR

fixes failure on kuttl test by making sure to wait for the right job and labeling the app differently

We're making double work here :-) https://github.com/open-feature/open-feature-operator/pull/446


i64 arithmetic on JS?

WebAssembly has a 64 bits float and integer type.
Even if we won't have interactions with >53bits integers between JavaScript code and the WebAssembly runtime (#21).
Our interpreter is still written in JavaScript and we need to handle it somehow, here's a few solutions:

Emulate 64 bits arithmetic over 32 bits (what asm.js does)

We probably need a AST pass to tranform all i64 into i32.

Compile your program with the 32 bits mode? Which adds a restriction to use our project.

asm.js does it already, here's are a few notes that I found:

Unity in particular mentioned that emulation of 64-bit arithmetic in asm.js is really really slow

Since JS uses IEEE double precision floating point numbers (64bit), f32 and f64 are no problem. Short integers i32 are no problem either, since they are representable with double precision doubles. The only type that requires extra handling is i64.

Maybe long.js is an option? That's what Fable uses. https://github.com/dcodeIO/long.js

Thanks @alfonsogarciacaro! That is looking good. Do you know how it affects Fable's performance?
I'm wondering if we could only apply this to numbers > 53bits, so that < 53bits number doesn't suffer from the overhead.

We haven't measured but I guess we could run a bunch of operations with i32 and i64 numbers and see how they compare (example).
About discriminating numbers, it may be a bit difficult when you need to operate on them. For example, adding two <53 bits numbers that will result in a >53 bits number, etc.

Im with @alfonsogarciacaro, I think the necessary logic to detect the need for >53 bit would produce more overhead and potential bugs than value. Performance will also be more predictable if all i64 values are affected the same way.

Ok, that makes sense.

Maybe this is too simplistic, but I just thought about this: For all nodes that hold i64 values we store two values lower and upper and define its value as lower + upper * 2^32? Because these values are only internal to the wasm computation and cannot be passed in or out to host environment ( #21 ) we never need to represent the complete number in the interpreter. Instead of + we use a custom add64 function that produces two values representing upper and lower.
Is that essentially what long.js would do for us or am I missing more benefits of using the library?

Interesting https://developer.mozilla.org/en-US/docs/Mozilla/js-ctypes/js-ctypes_reference/UInt64, but only on unsigned.

That looks really good, basically the functions we need to implement in order to avoid long.js. But I think we'd need the signed version? I found something on his profile, but it looks like it is not done at all:
https://github.com/aureooms/js-int64
I don't see multiplication, division and remainder at all though?


Xray not capturing stack traces in latest version of Flask

The after_request handler is closing the segment before the teardown_request handler is called so the stack trace isn't captured.
It looks like this behavior changed as of Flask v1.1.0 (specifically https://github.com/pallets/flask/pull/3266)
Currently using:

aws-xray-sdk v2.6.0
flask v1.1.2

Here is our current work around:
app = Flask(__name__)

def wrap_exception_handler(handler):
    def wrapped_function(exp):
        if not isinstance(exp, HTTPException) or exp.code >= 500:
            try:
                stack = stacktrace.get_stacktrace(
                    limit=xray_recorder.max_trace_back,
                )

                xray_recorder.current_segment().add_exception(exp, stack)
            except Exception:
                app.logger.error('Failed to add stack trace to xray segment')

        return handler(exp)
    return wrapped_function

app.handle_user_exception = wrap_exception_handler(app.handle_user_exception)

Hi @ianmetcalf
Thanks for identifying the issue and the root cause. You're right that the _handle_exception method which is the teardown_request handler is called after the segment is closed in _after_request and is failing silently while trying to add the exception.
I believe there could be two options here.

Do not close the segment in _after_request if the response.status_code is 500. Then the _handle_exception method will add the exception and close the segment.
Add a handle_user_exception handler method to the app similar to your workaround and add the exception there.

I'll test both the options and put out a fix soon.

Hi @ianmetcalf
Thanks for identifying the issue and the root cause. You're right that the _handle_exception method which is the teardown_request handler is called after the segment is closed in _after_request and is failing silently while trying to add the exception.
I believe there could be two options here.

Do not close the segment in _after_request if the response.status_code is 500. Then the _handle_exception method will add the exception and close the segment.
Add a handle_user_exception handler method to the app similar to your workaround and add the exception there.

I'll test both the options and put out a fix soon.

Did some digging into why the unit tests didn't catch this behavior change. It turns out that if we enable the testing mode, the after_request is not called in case of an unhandled exception which results in segment being still available in the handle_exception method and the test passes.
When I disabled the test mode by setting app.config['TESTING'] = False, the test began to fail as expected. I think for our use case, we can keep disable the TESTING config as disabled since it is required only to propagate the exception to the test_client which we don't really need.
I think the simple fix can the option 1 mentioned above rather than setting the handle_user_exception becuase that could override the customer's application exception handling.


Document automatic docs publishing in the release process

@brancz FYI as the current release shepherd.

If nothing needs to be done, can we remove it from this file?

Agree, I would remove it.

Fair enough, done.


[WIP] Preload changes

This PR allows use of Accelerate on macOS + changes preload options for ND4J CPU backend top reflect openblas changes.

I don't think it's a good idea to start using multiple versions of BLAS and different versions depending on the platform. I'm not going to approve this pull request. If you insist on going down this road, you'll do it without my support.

I see, thanks.

Looks like recent issues are not causing by recent changes.


AudioPlayer not paused while wake up on PlaybackStarted status

The problem is easy to come up with,  and it will result in multiple sounds.
Reproduction：
1、first play Music loop or play book.
2、wake up and talk with AudioPlayer playing.

Could you clarify what you mean by "multiple sound"?  Does it mean that AudioPlayer will kept on playing in the background after a barge-in?  If that's the case, then we should have a fix for this issue in our next software release.

Hello jacky-ge,
There has been no answer to the last posted question for a long time, so I am closing this issue.  If I have closed it in error, please feel free to re-open it.
Thank you,
-SWH


Compiler Error

I tried to use Piwik iOS SDK 4.4. Unfortunatelly I got a Compiler Error with Xcode 9.1.
Pods/PiwikTracker/PiwikTracker/Application.swift:4:27: 'bundleDisplayNameForCurrentApplication' is inaccessible due to 'private' protection level
Solution:
private methods from extensions should be fileprivate.

Hi @mkrajcir, thanks for your report. Unfortunately I wasn't able to reproduce your issue. What exactly can be done to reproduce it? The iOS Example in the repository works well and doesn't show this issue. Thanks in advance!

@brototyp I get the same issue. Just install the latest version of the pod and try to compile it. You don't actually need to implement the code to get the issue. 4.4 is useless as of now.

Same for me - I was on
pod 'PiwikTracker', '4.2.0'
and updating to
pod 'PiwikTracker', '4.4.0'
gives a lot of build errors:

/myfunnyapp/Pods/PiwikTracker/PiwikTracker/Application.swift:4:27: error: 'bundleDisplayNameForCurrentApplication' is inaccessible due to 'private' protection level
let displayName = bundleDisplayNameForCurrentApplication()
^
/myfunnyapp/Pods/PiwikTracker/PiwikTracker/Application.swift:30:25: note: 'bundleDisplayNameForCurrentApplication()' declared here
private static func bundleDisplayNameForCurrentApplication() -> String? {
^
/myfunnyapp/Pods/PiwikTracker/PiwikTracker/Application.swift:5:20: error: 'bundleNameForCurrentApplication' is inaccessible due to 'private' protection level
let name = bundleNameForCurrentApplication()
^
/myfunnyapp/Pods/PiwikTracker/PiwikTracker/Application.swift:35:25: note: 'bundleNameForCurrentApplication()' declared here
private static func bundleNameForCurrentApplication() -> String? {
^
/myfunnyapp/Pods/PiwikTracker/PiwikTracker/Application.swift:6:26: error: 'bundleIdentifierForCurrentApplication' is inaccessible due to 'private' protection level
let identifier = bundleIdentifierForCurrentApplication()
^
/myfunnyapp/Pods/PiwikTracker/PiwikTracker/Application.swift:40:25: note: 'bundleIdentifierForCurrentApplication()' declared here
private static func bundleIdentifierForCurrentApplication() -> String? {
^
/myfunnyapp/Pods/PiwikTracker/PiwikTracker/Application.swift:7:23: error: 'bundleVersionForCurrentApplication' is inaccessible due to 'private' protection level
let version = bundleVersionForCurrentApplication()
^
/myfunnyapp/Pods/PiwikTracker/PiwikTracker/Application.swift:45:25: note: 'bundleVersionForCurrentApplication()' declared here
private static func bundleVersionForCurrentApplication() -> String? {
^
/myfunnyapp/Pods/PiwikTracker/PiwikTracker/Application.swift:8:28: error: 'bundleShortVersionForCurrentApplication' is inaccessible due to 'private' protection level
let shortVersion = bundleShortVersionForCurrentApplication()
^
/myfunnyapp/Pods/PiwikTracker/PiwikTracker/Application.swift:50:25: note: 'bundleShortVersionForCurrentApplication()' declared here
private static func bundleShortVersionForCurrentApplication() -> String? {

I can verify this behaviour on Xcode 9.2 with Swift 4. Seems like private is visible to extensions in the same file when it is declared in the declaration. private properties in extensions on the other hand are not visible to the declaration.
See Apples Swift Programming Language documentation for more details.

der ganze thread voller leute aus berlin 😆

Thanks everyone, I am on the same page as you all. Still I am not sure why I am not able to reproduce this issue. Neither in the iOS Example Application in the repository, nor the following way:

Create a new project in Xcode 9.2
pod init
Add the pod 'PiwikTracker' to the Podfile
pod install // make sure the 4.4 is installed
build and run the project

The project is Xcode 9.2 and it is Swift 4 but it builds like a charm. I just want to add test so this issue will not happen again. Can anyone reproduce the issue the way I've written it down here? (You can download the test project here)

I think I got the issue: my Podfile still contained the following post install script:
post_install do |installer|
    installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
            config.build_settings['SWIFT_VERSION'] = '3.2'
        end
    end
end

When I add this to your test project @brototyp I get the same errors.

So the issue is, that the SDK is compiled as a Swift 3 Library, while it actually is a Swift 4 Library, right? Does it work if you set the SWIFT_VERSION to 4? If so, I think we found the solution for this issue.

I removed the whole post install script, as there weren't any other pods in the app and that worked. As not setting a Swift version explicitly makes the pod using the projects Swift version, yes, this was the solution.

Lovely. Thanks for checking that. I will close this thread for now. Please comment if you encounter any other issues.

For users who have not upgraded their projects to Swift 4.0,
post_install do |installer|
installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
config.build_settings['SWIFT_VERSION'] = '4.0'
end
end
end


Can't retrieve vector representation of cref

As described in the title :-)
Live example
e.g.,
{
  Get {
    Article(limit: 1) {
      title
      _additional {
        vector
      }
      inPublication {
        ... on Publication {
          name
        	_additional {
            vector
          }
        }
      }
    }
  }
}

Hm, I'm surprised this is even in the API, _additional properties are only defined at the root level. Is this something we could provide in general, @antas-marcin?

Fixed in the meantime, just validated.


Set a default task for all files with given extension

As far as I know,  you have to add a task.json file in every project (for example in c++). I think that, especially for beginners or to build and run a single file, it will be very useful to set a default task.json for all files with a given extension - I mean - build and run task for .cpp files, another for .c files and so on. There is that feature in Geany, for example. In this way, after the first set-up, VSCode automatically could build the file you are working on and run the executable in the terminal. Without the necessity for project. But if you have specific need, you could set a specific task.

Duplicate of #1435


Compatibility with gtm4wp Product ID prefix

This is a tricky one so hopefully I explain it correctly :)
gtm4wp (our main data layer source for a WP/Woo store) has a Product ID prefix field

which is very useful to ensure gtm4wp is compatible with WooCommerce product feeds plugins like Google Product Feed which adds the woocommerce_gpf_ to all products in the feeds it produces.
the gtm4wp data layer for GA4 eCommerce events then includes this prefix in the items.id key while preserving the original product id in the items.item_id key

This presents a problem for me as your facebook capi tag will use item_id rather than the id key
      if (d.item_id) content.id = d.item_id;

Rather than setting up my own custom vars/events, I was able to easily solve this by simply replacing the line above with
if (d.id) content.id = d.id;
which ensures the prefixed version gets sent on to the server side.
I'd rather not have to maintain my own fork of your excellent tag :) So I'm wondering if there's some way to add an option to set which key a user would prefer to use (e.g. id vs. item_id) which would ensure no breaking changes for your other customers but also improve compatibility with most common WooCommerce extensions that produce feeds with prefixes?
Thanks.

@colmtroy Hi! I have added pr that added the ability to specify custom itemIdKey

@kHorozhanov fantastic! Thanks so much for that.


web3call provider validation on start

Do you want to request a feature or report a bug?
bug
What is the current behavior?
When provider of type web3call specified, graph-node doesn't validate it on start. So you can specify any non-existing URL and graph node will not notice it until the first eth_call call.
I guess the issue is that EthereumNetworks::flatten() method that's used for provider validation, omits call_only_adapters field
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
Add a provider with non-existing url:
{ label = "calls", details = { type = "web3call", url = "http://asdf", features = [ "archive" ] }},
What is the expected behavior?
Should drop that provider on start.

Thanks @YaroShkvorets - I think the challenge here is that the provider validation relies on a non "eth_call" method cc @leoyvens @maoueh but I wonder if that could be changed (or maybe it does rely on a method supported by the EVMX?)

Pretty sure validation relies on 2 calls: net_version and eth_getBlockByNum: here and here
EVMX supports both: here and here
EVMX doesn't support eth_getBlockByHash but I don't think it's needed for validation.
We have a mainnet EVMX running. If somebody from your team wants to use it for testing dm me on Slack.

EVMX indeed supports the validation methods used by graph-node. I think the validation was removed when web3call was implemented, it could be brought back from web3call no problem.


Update readme with instructions for running tests

From @mr-c on Matrix,
tox -e py39-pydocstyle
make diff_pydocstyle_report
make install-deps

I think this can go to the README.md?

Awesome. Thanks

remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: 16 of 16 required status checks are expected.
To github.com:common-workflow-lab/wdl-cwl-translator.git
 ! [remote rejected] main -> main (protected branch hook declined)
error: failed to push some refs to 'github.com:common-workflow-lab/wdl-cwl-translator.git'

I can't seem to push to the main branch. Do I need to create a new branch first?

Looks like @Th3nn3ss . Can you create a branch and a pull request, please? When you create the PR, try the following: start the pull request with "Closes #108". You will notice GitHub adds some underline in "Closes".
The pull request will be linked to this issue, and once merged, this pull request will be automatically closed :+1:

If you are on main, and you have committed changes, you can try the following:

git checkout -b new-branch-name (choose a good name for your branch)
git push -u origin new-branch-name

Then create the pull request, and fix your main branch:

git checkout main
git reset --hard origin/main

I think this might work? Or you can start from scratch on a new branch, up to you.

This is amazing. Will do that.

make install-deps throws an error because it should be make install-dep.

make install-deps throws an error because it should be make install-dep.


 (D> 0E - D 0 - 0<E whatever this is)
List (LP/EP/SP/RND) - can customize
and other tailored types for specific efx events (here i used lofi as a reference because it has all 20 parameters used up)


feature requirements should fail the feature if the step fails, not skip

example:
   channel_test.go:51: Skipping feature 'Knative Channel Specification - Data Plane/Delivery Spec 0' assertions because requirement "wait until done" failed

results in a skipped step and a PASS, but the test did not run or pass. These should FAIL.

maybe a duplicate of https://github.com/knative-sandbox/reconciler-test/issues/166?


Install fails on remnux-perl-packages

I am trying to instal remnux as an addon to my ubuntu 20.04 vm. I've tried both remnux install --mode=addon and remnux upgrade --mode=addon. Both commands fail at remnux-perl-packages
Distributor ID: Ubuntu
Description: Ubuntu 20.04.2 LTS
Release: 20.04
Codename: focal
saltstack.log

Same issue here

Thanks for reporting this, @msaltini and @Dleau. The issue was due to PyInstaller Extractor changing. I updated the distro to reflect the new version.


Add package websitecreator

A website management tool - website creator.

Wow. Very nice!

Thank you @dom96. And thank you for the inspiration on https://github.com/nim-lang/nimforum.


How can I add JS and CSS files to the plug-in?

Plugins don't do anything special with the filesystem, so do it the same way you would add files to a regular .NET project.

This is more or less possible to do using Microsoft.Extensions.FileProviders.Embedded.
Add the following to your plugin.csproj:
  <PropertyGroup>
    <GenerateEmbeddedFilesManifest>true</GenerateEmbeddedFilesManifest>
  </PropertyGroup>

  <ItemGroup>
    <EmbeddedResource Include="Resources/**" />
  </ItemGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.Extensions.FileProviders.Embedded" Version="3.0.1" />
  </ItemGroup>

I added a file test.html to the Resources directory under my plugin. It may be a good idea to use unique names on this directory to make sure it doesn't collide with other plugins (Plugin1/Resources). This process makes sure we add all our resources to the plugin-dll and a manifest with a list of the files will be created out of the box.
I also added the following to my web project:
  <ItemGroup>
    <PackageReference Include="Microsoft.Extensions.FileProviders.Embedded" Version="3.0.1" />
  </ItemGroup>

Ok. Now we need to create instances of IFileProvider that maps to our plugin. We also want to keep the original WebRootFileProvider since our plugins will not be alone resolving static resources.
I refactored the MvcPluginExtensions class a bit.
var plugins = new List<Assembly>();
...
var pluginAssembly = pluginLoader.LoadDefaultAssembly();
plugins.Add(pluginAssembly);

Now we have a list of all the plugin assemblies. Now we need to update the WebRootFileProvider.
var allProviders = new List<IFileProvider>();
// Keep the existing provider
allProviders.Add(_env.WebRootFileProvider);
// Add a manifest provider for each plugin
allProviders.AddRange(plugins.Select(p => new ManifestEmbeddedFileProvider(p)));

// Replacing the previous WebRootFileProvider by our new composite one
_env.WebRootFileProvider = new CompositeFileProvider(allProviders);

This is a bit tricky to do since the loading of the assembly are made in an extension method and the updating of the WebRootFileProvider are best done somewhere else. I just refactored (moved) this extension method to be a part of my Startup.ConfigureServices, since I want my plugins to be able to register services anyway..


File not found in cloud

Hi,
I am facing strange issue where dvc is unable to pull file from cloud when configured in jenkins. Below are the logs. Not sure, How can i debug this.
aws s3 ls s3://rahul-dvc/data/xyz/
2018-04-01 14:11:55          0
2018-04-03 10:15:53      69474 18\4b9aee2f5df48f1ed2cf22d3c33d07
2018-04-03 10:15:49     128425 22\7fd4cfec8ca7afff7115041d1d23d0
2018-04-03 10:15:50    3304188 41\8721169c96ea6dee8e13709e0fd4c4
2018-04-03 10:15:50      32763 42\4e1fc9ad54266a6246850286b75b45
2018-04-03 10:15:53      97861 5f\b9105c342df2de330913ae8e3767a7

dvc pull -v
File '/var/jenkins_home/workspace/dvcbuild/.dvc/cache/22/7fd4cfec8ca7afff7115041d1d23d0' does not exist in the cloud
File '/var/jenkins_home/workspace/dvcbuild/.dvc/cache/41/8721169c96ea6dee8e13709e0fd4c4' does not exist in the cloud
File '/var/jenkins_home/workspace/dvcbuild/.dvc/cache/18/4b9aee2f5df48f1ed2cf22d3c33d07' does not exist in the cloud
File '/var/jenkins_home/workspace/dvcbuild/.dvc/cache/42/4e1fc9ad54266a6246850286b75b45' does not exist in the cloud
File '/var/jenkins_home/workspace/dvcbuild/.dvc/cache/5f/b9105c342df2de330913ae8e3767a7' does not exist in the cloud

Hi @rahulguptajss !
Could you show us your .dvc/config please?

[Core]
Supported clouds: AWS, GCP
Cloud = AWS
Log levels: Debug, Info, Warning and Error
LogLevel = Info
[AWS]
CredentialPath = ~/.aws/credentials
Profile = default
StoragePath = /rahul-dvc/data/xyz/
Region = us-east-2
[GCP]
StoragePath =
ProjectName =

i tried downloading files directly from s3 but still dvc checkout doesn't identify my files.

aws s3 ls s3://rahul-dvc/data/xyz/
2018-04-01 14:11:55          0
2018-04-03 10:15:53      69474 18\4b9aee2f5df48f1ed2cf22d3c33d07
2018-04-03 10:15:49     128425 22\7fd4cfec8ca7afff7115041d1d23d0
2018-04-03 10:15:50    3304188 41\8721169c96ea6dee8e13709e0fd4c4
2018-04-03 10:15:50      32763 42\4e1fc9ad54266a6246850286b75b45
2018-04-03 10:15:53      97861 5f\b9105c342df2de330913ae8e3767a7
aws s3 sync s3://rahul-dvc/data/xyz/ .dvc/cache
Completed 32.0 KiB/3.5 MiB (249.3 KiB/s) with 5 file(s) remaining
download: s3://rahul-dvc/data/xyz/42\4e1fc9ad54266a6246850286b75b45 to .dvc/cache/42\4e1fc9ad54266a6246850286b75b45
Completed 32.0 KiB/3.5 MiB (249.3 KiB/s) with 4 file(s) remaining
Completed 99.8 KiB/3.5 MiB (677.5 KiB/s) with 4 file(s) remaining
download: s3://rahul-dvc/data/xyz/18\4b9aee2f5df48f1ed2cf22d3c33d07 to .dvc/cache/18\4b9aee2f5df48f1ed2cf22d3c33d07
Completed 99.8 KiB/3.5 MiB (677.5 KiB/s) with 3 file(s) remaining
Completed 195.4 KiB/3.5 MiB (1.1 MiB/s) with 3 file(s) remaining
Completed 320.8 KiB/3.5 MiB (1.8 MiB/s) with 3 file(s) remaining
download: s3://rahul-dvc/data/xyz/22\7fd4cfec8ca7afff7115041d1d23d0 to .dvc/cache/22\7fd4cfec8ca7afff7115041d1d23d0
Completed 320.8 KiB/3.5 MiB (1.8 MiB/s) with 2 file(s) remaining
download: s3://rahul-dvc/data/xyz/5f\b9105c342df2de330913ae8e3767a7 to .dvc/cache/5f\b9105c342df2de330913ae8e3767a7
Completed 320.8 KiB/3.5 MiB (1.8 MiB/s) with 1 file(s) remaining
Completed 576.8 KiB/3.5 MiB (2.9 MiB/s) with 1 file(s) remaining
Completed 832.8 KiB/3.5 MiB (3.7 MiB/s) with 1 file(s) remaining
Completed 1.1 MiB/3.5 MiB (4.6 MiB/s) with 1 file(s) remaining
Completed 1.3 MiB/3.5 MiB (5.4 MiB/s) with 1 file(s) remaining
Completed 1.6 MiB/3.5 MiB (6.2 MiB/s) with 1 file(s) remaining
Completed 1.8 MiB/3.5 MiB (7.1 MiB/s) with 1 file(s) remaining
Completed 2.1 MiB/3.5 MiB (7.8 MiB/s) with 1 file(s) remaining
Completed 2.3 MiB/3.5 MiB (8.6 MiB/s) with 1 file(s) remaining
Completed 2.6 MiB/3.5 MiB (9.4 MiB/s) with 1 file(s) remaining
Completed 2.8 MiB/3.5 MiB (10.1 MiB/s) with 1 file(s) remaining
Completed 3.1 MiB/3.5 MiB (10.9 MiB/s) with 1 file(s) remaining
Completed 3.3 MiB/3.5 MiB (11.6 MiB/s) with 1 file(s) remaining
Completed 3.5 MiB/3.5 MiB (12.1 MiB/s) with 1 file(s) remaining
download: s3://rahul-dvc/data/xyz/41\8721169c96ea6dee8e13709e0fd4c4 to .dvc/cache/41\8721169c96ea6dee8e13709e0fd4c4
ls .dvc/cache
18\4b9aee2f5df48f1ed2cf22d3c33d07
22\7fd4cfec8ca7afff7115041d1d23d0
41\8721169c96ea6dee8e13709e0fd4c4
42\4e1fc9ad54266a6246850286b75b45
5f\b9105c342df2de330913ae8e3767a7
ls data/
CombinedSummary.csv.dvc
TestSet.csv
dvc checkout
'.dvc/cache/22/7fd4cfec8ca7afff7115041d1d23d0(data\feature.p)': cache file not found
'.dvc/cache/18/4b9aee2f5df48f1ed2cf22d3c33d07(data\train.p)': cache file not found
'.dvc/cache/42/4e1fc9ad54266a6246850286b75b45(data\vectorizer.pkl)': cache file not found
'.dvc/cache/41/8721169c96ea6dee8e13709e0fd4c4(data\RandomForest_classifier.pkl)': cache file not found
'.dvc/cache/5f/b9105c342df2de330913ae8e3767a7(data/CombinedSummary.csv)': cache file not found
ls data/

Hm... And can you confirm that .dvc/cache files exist after dvc checkout?

Yes, it is present.

I did dvc checkout in jenkins docker container as well and its same issue.

@rahulguptajss Hm... One more thing, could you please run dvc checkout -v (notice the -v flag) and show the output?

Yes attached is the output. Weird that it says it got changed.

And can you also show the contents of your *.dvc files please?

Attached are all dvc files
dvcfiles.zip

Thank you! I'm not yet able to reproduce this issue =( I have a few more questions:

Try running this simple example alongside your project:

mkdir myrepo
cd myrepo
git init
dvc init
echo foo > foo
dvc add -v foo
dvc remove -v foo
dvc checkout -v
cat foo

Is this a cygwin you are running with docker image inside?

This might be some weird path bug, so could also try replacing windows path's with *nix paths in all of your *.dvc files and run 'dvc checkout' once more to see what happens?

I have found the issue. It's related with the way windows pushes this cache folder in s3.
In below screenshot, highlighted 18\4b9aee2f5df48f1ed2cf22d3c33d07 should have been a folder structure instead of file name. If you see d5 in screenshot, that's what got pushed from a unix system to s3.
Example: From unix machine a\b is pushed as filename while from unix it is pushed as a (folder)-> b (filename)


Is it possible to provide a like Unity3d UI editor

Issue title
Description
Many features are difficult to develop without a Ui editor
Version

Platform

Web Version [X]
Windows [X]
Linux [X]

Hi
By UI do you mean buttons, text, radio buttons etc for menus inside lets say a game?
I think i may be able to implement that, but i dont think it is a priority since it is possible to use HTML for all of that.
Thanks a lot for the idea.

@tentone
Do you have a tutorial on how to display HTML text, buttons and radio inside NunuStudio?
Thanks.

Yes there is a tutorial, the first script tutorial explains about that.

@tentone
I figured it out. Thanks. It is very flexible that you can leverage CSS for the UI. This is simply amazing.


docs: update README.md

Entire credit goes to CHATGPT :)!
I commented out the #Features section, cause I don't believe this application does all of that as of now, @TechStudent10, I request you to add those features. Further, this repo should have the MIT license, as we mentioned in the #License section that Proton Designer is released under the MIT License.

Are you sure that chatGPT was trained on a recent model? We no longer use Electron, in favor of Tauri.

Are you sure that chatGPT was trained on a recent model? We no longer use Electron, in favor of Tauri.

No, It was trained using an old model.. I told it to include Electron as the previous (current) README.md said that y'all used electron.

@TechStudent10 are we going to merge?

Tbh the project isn't even at this stage of features yet, so I'm not gonna merge.


Middleware on / are applied to server components

Environment

Operating System: Windows_NT
Node Version:     v18.15.0
Nuxt Version:     3.5.0
Nitro Version:    2.4.0
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/nuxt-starter-2qejrb?file=pages%2Ftest.vue,middleware%2Fbreak.global.ts,components%2FHello.server.vue,app.vue,nuxt.config.ts
Describe the bug
when reviewing #20894 , I'm 100% sure that middlewares (at least global ones) are applied to server components. Middlewares shouldn't be applied to server components
Additional context
No response
Logs
No response

One thing to note is that it's possible to call a server component with a 'context' of a particular route, and if that route context is set, it may be important to allow router/route middleware to run.
I think if the url isn't set from the context we probably could skip middleware.

I see :+1:, do you think a check on nuxtApp.ssrContext.url should be enough ?

I think maybe we can set it here:
https://github.com/nuxt/nuxt/blob/83cb5d6f5414378b2dbc43b2937cb4ca5edc843e/packages/nuxt/src/core/runtime/nitro/renderer.ts#L152-L159


Appstudio update rhtap-demo-component-jynj

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: rhtap-demo-component-jynj-on-pull-request-
creating pipelinerun rhtap-demo-component-jynj-on-pull-request- in namespace rhtap-demo-dev-hlcx-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
51475f0 -> 45f17e6

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.39.4 -> v1.39.7

go (source)
toolchain
patch
1.23.1 -> 1.23.2

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.39.7
Compare Source
Bug Fixes

deps: update gomod (#874) (f8fa2c3)

v1.39.6
Compare Source
Bug Fixes

Add custom Logger and implement for projects tests(#873) (78d99dc)

v1.39.5
Compare Source
Bug Fixes

add documentation for projects test (#872) (06ff82d)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

ℹ Artifact update notice
File name: tests/go.mod
In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

4 additional dependencies were updated

Details:

Package
Change

github.com/gruntwork-io/terratest
v0.47.1 -> v0.47.2

golang.org/x/crypto
v0.27.0 -> v0.28.0

golang.org/x/sys
v0.25.0 -> v0.26.0

golang.org/x/text
v0.18.0 -> v0.19.0

/run pipeline

/run pipeline

ℹ Artifact update notice
File name: tests/go.mod
In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

4 additional dependencies were updated

Details:

Package
Change

github.com/gruntwork-io/terratest
v0.47.1 -> v0.47.2

golang.org/x/crypto
v0.27.0 -> v0.28.0

golang.org/x/sys
v0.25.0 -> v0.26.0

golang.org/x/text
v0.18.0 -> v0.19.0

/run pipeline

/run pipeline

ℹ Artifact update notice
File name: tests/go.mod
In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

4 additional dependencies were updated

Details:

Package
Change

github.com/gruntwork-io/terratest
v0.47.1 -> v0.47.2

golang.org/x/crypto
v0.27.0 -> v0.28.0

golang.org/x/sys
v0.25.0 -> v0.26.0

golang.org/x/text
v0.18.0 -> v0.19.0

/run pipeline

/run pipeline

ℹ Artifact update notice
File name: tests/go.mod
In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

4 additional dependencies were updated

Details:

Package
Change

github.com/gruntwork-io/terratest
v0.47.1 -> v0.47.2

golang.org/x/crypto
v0.27.0 -> v0.28.0

golang.org/x/sys
v0.25.0 -> v0.26.0

golang.org/x/text
v0.18.0 -> v0.19.0

/run pipeline

/run pipeline

ℹ Artifact update notice
File name: tests/go.mod
In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

4 additional dependencies were updated

Details:

Package
Change

github.com/gruntwork-io/terratest
v0.47.1 -> v0.47.2

golang.org/x/crypto
v0.27.0 -> v0.28.0

golang.org/x/sys
v0.25.0 -> v0.26.0

golang.org/x/text
v0.18.0 -> v0.19.0

/run pipeline

/run pipeline

:tada: This PR is included in version 2.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Feature Request: Add option to suppress alert in testing

First of all, thanks for the work! The package helps me a lot!
I'm building a website with Node.js and have recently come across the "issue" that when I run mocha tests, alerts fire on top of the code editor which is rather annoying. I'm using alerts to express errors in the user registration process, which I test quite thoroughly, and, as a result, get a bunch of alerts from it that I have to manually close.
I've fixed the issue for myself with my own little wrapper:
const alert = require('alert');

var generateAlert = module.exports = function(msg) {
    if (process.env.NODE_ENV == "development") {
        alert(msg);
    }
}

When testing, I set NODE_ENV  to test which suppresses the alert.
So I was thinking of building a feature where a user can pass options to alert() to determine in which environments alert should or should not fire. thingToUse could also be an option, and not setting the options parameter would of course not change anything.
Something like:
alert("Username already in use", { thingToUse: "yad", env: ["development", "production"]})
It would then read from process.env.NODE_ENV to find the value set by the user.
Wondering if this is of interest or if it just adds unnecessary size to the package. If it is, I'll get on it right away!
Cheers!

Rather than adding another option, would an env var work? Something like DISABLE_ALERT, which would be used like NODE_ENV=test DISABLE_ALERT=1 jest?

Even better! Don't know how that didn't come to mind. Should I do that? I guess it's just a matter of wrapping it all in an if statement

Sure if you'd like to! The check can probably go at the bottom of node.js, just conditionally exporting either getAlert or a noop.

Got you!

Submitted the PR - just added a ternary operator to the last line in node.js and a line in README about it

Released in v4.1.0


Clear primary bistream when it's deleted- Fix issue #9099

References
Add references/links to any related issues or PRs. These may include:

Fixes #9099

Description
This PR fixes issue #9099.
Instructions for Reviewers
The description for reviewing and testing it's on the issue #9099
To Reproduce
Steps to reproduce the behavior:

Create a new item
Upload several files into the item and fill the required data
Deposit the item
As an admin, Edit that Item and promote one bitstream to be Primary Bitstream (this will reference that bitstream at the bundle level)
Please take note of that bitstream's UUID
Delete that bitstream that we promote to primary
Check the database (please consider your UUID here):

SELECT * FROM bundle WHERE primary_bitstream_id='814aefff-4874-4a97-a7aa-b654172e7a40'

You should expect to see the primary_bitstream_id as null

List of changes in this PR:

I've changed the bundle to force a setModified()
I've created a new test to address the issue
I've created a migration sql script to fix existing deleted primary bitstreams

Thanks @paulo-graca! This works as described. I tested on DSpace 7.6 by adding a bitstream, setting it as primary, and deleting it. Before the patch the bitstream ID remains referenced in the bundle. After the patch it is correctly removed.
I also see that the migration ran successfully. This is +1 by testing for me as well. Only remains to address review comments by @toniprieto.

Thank you all for reviewing. I've just added the test to use bitstreamService to ensure delete also removes the primary bitstream.


fix(tab): remove margin between Tabs in iOS and Mac

:tada: This PR is included in version 3.0.0-beta.8 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


open /dev/shm some files error：permission denied

if /dev/shm/ directory has some dirs not files and these dirs have 750 permissions，pilot-agent will error and then will delete
config file envoy-recv0.yaml.It will make envoy not work.

Sorry, this seems like a problem with the file permissions on your setup, or even how pilot-agent (outside of the envoy project) deals with your local filesystem. I am not sure how the envoy maintainers can assist you.

Oracle is installed on my server, and Oracle contains a directory with 750 permissions. This error was reported when I installed pilot agent on this machine. In this case, I can't install pilot agent on this machine.

I understand that /dev/shm is a public shared memory directory, so pilot-agent should not prevent other applications from installing or accessing it

@feimeng1029 Can you create an issue in github.com/istio/istio and close this one?


vkCreateDebugReportCallbackEXT, vkDestroyDebugReportCallbackEXT and vkDebugReportMessageEXT

Those 3 need the "[UnmanagedFunctionPointer(CallingConvention.StdCall)]" otherwise GC marshalling will fail in some scenarios.

Can you elaborate in which scenarios this may be a problem?

Now I'm using your VulkanCore lib, should be considered closed, I thought the issue was to missing UnmanagedFunctionPointerAttribute.


Implement wasm-based seed conversion for HD-Wallet native

Description
Mobile devices spend around 3.5s on app boot converting the mnemonic to a BIP32 seed. Looking into the HDWallet source code we see a TODO to reimplement it:
packages/hdwallet-native/src/crypto/isolation/engines/default/bip39.ts

Additional details
The existing implementation of pbkdf2_sha512_singleblock may be replaceable with pbkdf2 from hash-wasm, for example:
import { createSHA512, pbkdf2 } from "hash-wasm";

// ...

const out = await BIP32Engine.Seed.create(
      Buffer.from(
        await pbkdf2({
          password: mnemonic,
          salt,
          iterations: 2048,
          hashLength: 64,
          hashFunction: createSHA512(),
          outputType: "binary",
        })
      )
    );

Acceptance criteria

Native wallet can connect / disconnect / transact as normal
Improved app boot time

HDWallet PR: https://github.com/shapeshift/hdwallet/pull/648


Instance-id

Hi Team,
I am wring terraform script for  AWS ALB, so i want to know how to get instance-id using tags.
Please some one help me.

Hi @sharathmankala !
Please ask general Terraform questions on https://discuss.hashicorp.com/ or stackoverflow.
Here is an ALB module you can use - https://github.com/terraform-aws-modules/terraform-aws-alb/
Here is a data-source which you can use to find EC2 instances by tags - https://www.terraform.io/docs/providers/aws/d/instances.html
Closing this issue.


multiple queries with warnings in one execute()

sql = "DROP PROCEDURE IF EXISTS test; CREATE PROCEDURE test() SELECT 1"
yield db.execute(sql)

The DROP would cause a warning if procedure not existed, but CREATE would succeed. result.warning_count would not be 0, but conn.show_warnings() would be empty.
Resulting uncaught exception.

won't fix.  Go Python3 & asyncio.


navbar dropdown menu color

Hi There
Is there a way to make the navbar dropdown menu color the same as the currently selected theme color?
Cheers

not sure if this is the best approach but how i achieved it was by adding custom css
/yellow/
.skin-yellow .mynav .dropdown-menu {
background-color: #f39c12;
}
.skin-yellow .mynav > .dropdown-menu > li > a {
color: white!important;
background-color: #f39c12;
}
.skin-yellow .mynav > .dropdown-menu > li > a:hover {
color: white!important;
background-color: #FFB62C!important;
}


Missing variable declaration in template netdev

The driver_netdev.c template is missing the declaration of the variable state in the function _send.
@@ -28,6 +28,7 @@
 static int _send(netdev_t *netdev, const iolist_t *iolist)
 {
     {{ driver.name }}_t *dev = ({{ driver.name }}_t *)netdev;
+    netopt_state_t state;

     uint8_t size = iolist_size(iolist);

Or maybe you want to combine the declaration and the assignment below.

This is fixed by 009be2659960d1ec284c6c23ddf51cad0d57a1fb (sorry the latency)


could these log "strange errors" means something bad?

hey @2bbb,
thanks a lot for this addon!
I am adding your addon to my new addon https://github.com/moebiussurfing/ofxBeatClock as another sync/clock source.
But I am getting these rare errors I paste below.
I get these errors when running your example and with my own code too. And it seems that is affecting and dropping down the fps performance...
Does it have any sense to you? Any idea of what could be happening or how to avoid it?
The thread 0x2953c has exited with code 0 (0x0).
The thread 0x218bc has exited with code 0 (0x0).
'ofxAbletonLinkExample.exe' (Win32): Loaded 'C:\Windows\System32\nvspcap64.dll'. Symbol loading disabled by Include/Exclude setting.
'ofxAbletonLinkExample.exe' (Win32): Loaded 'C:\Windows\System32\winsta.dll'. Symbol loading disabled by Include/Exclude setting.
'ofxAbletonLinkExample.exe' (Win32): Loaded 'C:\Windows\System32\cryptbase.dll'. Symbol loading disabled by Include/Exclude setting.
'ofxAbletonLinkExample.exe' (Win32): Loaded 'C:\Windows\System32\nsi.dll'. Symbol loading disabled by Include/Exclude setting.
'ofxAbletonLinkExample.exe' (Win32): Loaded 'C:\Windows\System32\dhcpcsvc6.dll'. Symbol loading disabled by Include/Exclude setting.
'ofxAbletonLinkExample.exe' (Win32): Loaded 'C:\Windows\System32\dhcpcsvc.dll'. Symbol loading disabled by Include/Exclude setting.
'ofxAbletonLinkExample.exe' (Win32): Loaded 'C:\Windows\System32\dnsapi.dll'. Symbol loading disabled by Include/Exclude setting.
'ofxAbletonLinkExample.exe' (Win32): Loaded 'C:\Windows\System32\TextInputFramework.dll'. Symbol loading disabled by Include/Exclude setting.
'ofxAbletonLinkExample.exe' (Win32): Loaded 'C:\Windows\System32\iertutil.dll'. Symbol loading disabled by Include/Exclude setting.
'ofxAbletonLinkExample.exe' (Win32): Loaded 'C:\Windows\System32\mswsock.dll'. Symbol loading disabled by Include/Exclude setting.
Exception thrown at 0x00007FFF91DDA799 in ofxAbletonLinkExample.exe: Microsoft C++ exception: std::system_error at memory location 0x000000000B73F2E0.
The thread 0x4da0 has exited with code 0 (0x0).
Exception thrown at 0x00007FFF91DDA799 in ofxAbletonLinkExample.exe: Microsoft C++ exception: std::system_error at memory location 0x000000000B73F2E0.
The thread 0x22d8c has exited with code 0 (0x0).
Exception thrown at 0x00007FFF91DDA799 in ofxAbletonLinkExample.exe: Microsoft C++ exception: std::system_error at memory location 0x000000000B73F2E0.
The thread 0x22db0 has exited with code 0 (0x0).
The thread 0x228cc has exited with code 0 (0x0).
The thread 0x1a40 has exited with code 0 (0x0).
The thread 0x2776c has exited with code 0 (0x0).
The thread 0xecb8 has exited with code 0 (0x0).
The thread 0x296b0 has exited with code 0 (0x0).
The thread 0x3814 has exited with code 0 (0x0).
The thread 0xbd68 has exited with code 0 (0x0).
The thread 0xc9b0 has exited with code 0 (0x0).
The thread 0x21934 has exited with code 0 (0x0).
The thread 0xeed4 has exited with code 0 (0x0).
The thread 0x20378 has exited with code 0 (0x0).
The thread 0xb188 has exited with code 0 (0x0).
The thread 0x9e10 has exited with code 0 (0x0).
The thread 0x22ae8 has exited with code 0 (0x0).
The thread 0x29600 has exited with code 0 (0x0).
The thread 0x21490 has exited with code 0 (0x0).
The thread 0x29348 has exited with code 0 (0x0).
The thread 0x21e50 has exited with code 0 (0x0).
The thread 0x29488 has exited with code 0 (0x0).
The thread 0x297a8 has exited with code 0 (0x0).
Exception thrown at 0x00007FFF91DDA799 in ofxAbletonLinkExample.exe: Microsoft C++ exception: std::system_error at memory location 0x000000000B73F1F0.
The thread 0xe058 has exited with code 0 (0x0).
Exception thrown at 0x00007FFF91DDA799 in ofxAbletonLinkExample.exe: Microsoft C++ exception: std::system_error at memory location 0x000000000B73F1F0.
The thread 0x219d0 has exited with code 0 (0x0).
Exception thrown at 0x00007FFF91DDA799 in ofxAbletonLinkExample.exe: Microsoft C++ exception: std::system_error at memory location 0x000000000B73F1F0.
The thread 0x29338 has exited with code 0 (0x0).
The thread 0x9f0c has exited with code 0 (0x0).
The thread 0xe94c has exited with code 0 (0x0).
The thread 0x683c has exited with code 0 (0x0).
The thread 0x22b3c has exited with code 0 (0x0).
The thread 0x1b658 has exited with code 0 (0x0).
The thread 0x23184 has exited with code 0 (0x0).
The thread 0x1b4b0 has exited with code 0 (0x0).

Hi
I have the same errors and also experience lag.
Did you fix it somehow?

please describe your env.

In my case, I was using Windows/OF 0.11. Not tested yet more recently using OF 0.12

I am using Windows/OF  0.12
Your example works fine. I 1:1 replicate to my project, and then i get the errors.


[Backend Issue]:  Add nodemon to Dev Dependencies for Easier Development

Description
The development process can be streamlined by adding nodemon to the project's dev dependencies. nodemon automatically restarts the server when file changes are detected, making development faster and more efficient.
Steps to Reproduce

Start working on the project.
Make changes to backend files.
Notice that the server needs to be manually restarted after each change.

Tech stack required

Node.js
Familiarity with nodemon for auto-restarting the server during development

Are you participating in GSSoC?

[x] Yes
[ ] No

already there


Fixes 'NoneType' object is not iterable

Description of changes:
The previous fix worked on the first cloudformation creation only and the lambda failed everyday after that. this will fix it permanently.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Make sense. Merging. Thanks


Multi-line support

While entering text I found that if I press Enter then the respective cell will be updated. But, is there any multi-line support? Some people might like to enter paragraphs in a cell.
Thanks

You can custom it via css, check following:
<TableHeaderColumn dataField='name' tdStyle={ { whiteSpace: 'normal' } }>Product Name</TableHeaderColumn>


feat(catalog): add detailPanel prop to CatalogTable

Hey, I just made a Pull Request!
Added the detailPanel prop to the CatalogTable forwarding it to the underlying Table.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Hi. How do you envision this being used?
When reviewing contributions that involve UI changes, we often look for community buy-in first.
If you feel this is something that could improve the Backstage experience please open up an issue for community discussion.

Hi. How do you envision this being used? When reviewing contributions that involve UI changes, we often look for community buy-in first. If you feel this is something that could improve the Backstage experience please open up an issue for community discussion.

Hey @Edje-C,
thank you for the response. This isn't really an UI change, but more a extension of the API to allow more customization to the CatalogTable.
For example at our company we need this to show some details about services when clicking on them in the catalog table. Currently we have to copy and paste the complete CatalogTable code just to use this minor addition because it is not exposed through the API.
Adding this would remove redudandant code, which is hard to maintain when updating from upstream. And as I take from the docs, customizing the catalog table is something that should be done.
I can post a more concrete example if needed.

Hi. How do you envision this being used? When reviewing contributions that involve UI changes, we often look for community buy-in first. If you feel this is something that could improve the Backstage experience please open up an issue for community discussion.

Hey @Edje-C, thank you for the response. This isn't really an UI change, but more a extension of the API to allow more customization to the CatalogTable.
For example at our company we need this to show some details about services when clicking on them in the catalog table. Currently we have to copy and paste the complete CatalogTable code just to use this minor addition because it is not exposed through the API.
Adding this would remove redudandant code, which is hard to maintain when updating from upstream. And as I take from the docs, customizing the catalog table is something that should be done.
I can post a more concrete example if needed.

I understand that addition seems minor but as this is something that would go out to all Backstage users, we’d like to understand if there’s a broader need for such an extension first.


Fixed bug in Israel Holidays

Fixed bug in Purim holiday + adding tests for Purim

Pull Request Test Coverage Report for Build 1015

7 of 7 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 979:
0.0%

Covered Lines:
9364

Relevant Lines:
9364

💛  - Coveralls

Pull Request Test Coverage Report for Build 1015

7 of 7 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 979:
0.0%

Covered Lines:
9364

Relevant Lines:
9364

💛  - Coveralls

@dr-prodigy I'll resolve the conflicts with the beta branch in the next couple of days unless you've already started to

@dr-prodigy I've rebased the code

Merged in beta.. Thank you 👍


Add on option to keep lir open after opening a file in a split or tab

This adds an optional quit_lir parameter to split, vsplit and tabedit. Default behavior remains unchanged, but passing false to those actions will prevent the quit action from being called after a new file is opened.
I updated the docs in lir.txt. Unfortunately my Japanese isn't good enough to update lir.jax.

Thank you!
As for the Japanese documentation, I will make the changes later.


copr: add ISO 8601 support for time parsing

What problem does this PR solve?
Problem Summary: previously in TiDB https://github.com/pingcap/tidb/pull/20534 , we supported parsing time string in ISO 8601 format, but the change has not yet ported to TiKV, and this PR gets the job done.
What is changed and how it works?
What's Changed:
Related changes

Need to cherry-pick to the release branch 4.0.

Check List
Tests

Unit test
Integration test, see https://github.com/pingcap/tidb-test/pull/1149

Side effects

Performance regression

Consumes more CPU

Release note

port ISO8601 parsing from TiDB to TiKV's coprocessor.

/label status/can-merge

/label status/can-merge

/type bug

/type bug

/remove-type bug

/remove-type bug

/run-all-tests tidb-test=pr/1149

/run-all-tests tidb-test=pr/1149

/run-all-tests tidb-test=pr/1149

/run-all-tests tidb-test=pr/1149

ping @skyzh to decide whether merge or not.

/merge

Why is this PR not merged?

@skyzh @Xuanwo    There was a problem with the server network in the server room yesterday, so the bot did not respond /merge correctly, please try again.

/merge

@hi-rustin Maybe we need a seperate status page for our bot.

@hi-rustin Maybe we need a seperate status page for our bot.

It's not actually the bot that's down, because the bot is in GCP's k8s cluster, it's the underlying service it depends on that's down.
We will be migrating the underlying services to AWS eks and should not have this problem.

Why is this PR not merged?

By the way, if you encounter problems next time you can come to sig-community-infra to give feedback, this PR is just what I happen to subscribe to.

Why is this PR not merged?

By the way, if you encounter problems next time you can come to sig-community-infra to give feedback, this PR is just what I happen to subscribe to.

OK, I got it.


Hi is there any way through which we can prevent download of my PDF through the applications like, (IDM) by using JavaScript project

PDF Viewer

 Prev Page

      Next Page

      Page  of

Sorry, but this isn't really an actionable/valid issue! When opening an issue, please provide all of the information requested in https://github.com/mozilla/pdf.js/blob/master/.github/ISSUE_TEMPLATE.md and please also see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.

Generally speaking, if a document can be viewed is can also be downloaded (by e.g. tech-savvy users). Furthermore, we don't support any Internet Download Managers here (which I'm guessing is what the abbreviation means).
Finally, please do not use this GitHub repository as a CDN since that's really not intended; see https://mozilla.github.io/pdf.js/getting_started/#including-via-a-cdn


[Question] Is it possible to delete files/directories in parallel ?

Title describes all.
Simply: I have huge sized directories with thousands of files in them ( Such as AOSP codebase) . When I try to delete the directory, almost all disk analyzer tools handle this task in single thread. Is it possible to remove a directory with hundreds of thousands of files in them in multiple threads?
What I am looking for is something like this:

We are using os.RemoveAll from standard Go library which really does the job in a single thread.
I guess we might be able to dive into first level of the being-deleted directory and run deletion on each item in parallel 🤔

Will deletion on background solve the situation for you? https://github.com/dundee/gdu/issues/293

Will deletion on background solve the situation for you? #293

Well, to be honest, no.
If my understanding is correct, even if we delete in the background, it will be still single thread, is my understanding correct?

BTW, Chatgpt offered me goroutines, such as:
package main

import (
    "fmt"
    "os"
    "path/filepath"
    "sync"
)

func deleteFile(path string, wg *sync.WaitGroup, mutex *sync.Mutex) {
    defer wg.Done()

    err := os.Remove(path)

    // Handle errors or log them as needed
    if err != nil {
        mutex.Lock()
        fmt.Printf("Error deleting file %s: %s\n", path, err)
        mutex.Unlock()
    }
}

func deleteFilesInDirectory(directory string, numWorkers int) error {
    var wg sync.WaitGroup
    var mutex sync.Mutex

    err := filepath.Walk(directory, func(path string, info os.FileInfo, err error) error {
        if err != nil {
            return err
        }

        if !info.IsDir() {
            wg.Add(1)
            go deleteFile(path, &wg, &mutex)
        }

        return nil
    })

    if err != nil {
        return err
    }

    // Wait for all goroutines to finish
    wg.Wait()

    return nil
}

func main() {
    directory := "/path/to/your/directory"
    numWorkers := 10 // Adjust the number of workers based on your system's capabilities

    err := deleteFilesInDirectory(directory, numWorkers)
    if err != nil {
        fmt.Printf("Error: %s\n", err)
    }
}

Do you think that it is feasible to implement such thing ?

Yes, we can try somethink like that. I will first implement the deletion in background and then focus on this one.

@dundee  thank you very much, I tried this just now:
How did I built gdu in my ubuntu 22.04 host:
#add ubuntu 22.04 ppa golang 1.22: https://go.dev/wiki/Ubuntu#using-ppa
git clone https://github.com/dundee/gdu.git
make build-static

copy dist/gdu to /usr/bin and check version:
stulluk ~ $  gdu --version
Version:	 v5.27.0-33-gbece451
Built time:	 Mon Apr 15 02:16:28 AM +03 2024
Built user:	 stulluk
stulluk ~ $

Add parallel delete to yaml:
stulluk ~ $  cat .gdu.yaml
delete-in-parallel: true
stulluk ~ $

My Hardware:
Ryzen 5700G ( 8 core 16 threads )
64G RAM
Samsung 980Pro NVME
and here is my result:

As you see, it only uses 4 cores, it is because number of mutex locked directories (hardware limitation) or am I missing something here?

It was using 4 physical threads which doesn't need to mean it was running only 4 internal Go threads (goroutines). Go starts only as many physical threads as it could utilise and it runs the internal threads in the physical ones as possible (if some of them is able to run).
Gdu uses maximum of 3 * GOMAXPROCS internal threads for deletion. Default value of GOMAXPROCS is the number of cores.

So if I understand correctly, we couldn't get much benefit from this change ?
As you see above, basically CPU was almost doing nothing while disk write was at 84.4MBps ? ( Which is weird imho, given that Samsung 980Pro is able to handle 500+ MBps easily ? )
But thanks for implementing this anyway.

Interesting. I would guess we should get more disk write speed here. Maybe it's slowed down by some other constraint.
I will give it more testing to see if the implementation is not missing something.

That would be a great help, thanks!
I will try use tracing to see where the time is really spent.

I was tracing deletion of directory with 16 items and it really spawned 16 internal threads. But it created threads not only for directories but files as well, which is not wanted, I will fix it.
I will also perform more benchmarks to see what benefit we are getting from this.

From the initial benchmark (https://github.com/dundee/gdu/pull/344/files) it unfortunately seems that the gain is very small or even negative. I am not an expert on Linux kernel, but I guess there is some locking happening that blocks the operations from running faster in parallel.
Trace for deletion in single thread:

Deletion in multiple threads:

There were two big files in separate directories, which could have been deleted faster in parallel theoretically, but the hypothesis was most likely wrong.

@dundee  thanks for looking at it. But what I see from your unit test code was that you are creating two 1Gbyte huge file, and tracing it how fast it deletes.
My use-case is different: I have hundreds of thousands of a few megabyte sized files in tousands of directories.
Should I create a test script to measure this use-case, or do you think it is better to do it with your unit test way ?
Pls let me know, I am ready to support.

@stulluk I think you can use my branch to try deleting your files both in parallel and sequential way (go run ./cmd/deleter/main.go --parallel ...) and measure the speed.

@dundee  Here is the performance of my system:

Here is a comparison of running your test code with "--parallel" argument  ( 10x speed improvement in 100Gbyte directory with 100.000 files with 1megabyte size with random content)

Thank you so much for your kindness & support. I think we are done now.

BTW, here was my simple & hacky script to create "testdir" (if anyone is interested):
#!/usr/bin/env bash

set -euo pipefail

NUMDIRS=100
NUMFILES=1000
EACHFILESIZE=1M

mkdir testdir
pushd testdir

#Create 100 directories and put 1000 files inside each

for dirno in $(seq 1 1 ${NUMDIRS})
do
	printf "this is directory number %d\n" "${dirno}"
	mkdir "dir-${dirno}"
	pushd "dir-${dirno}"
	curdir=$(pwd)
	for fileno in $(seq 1 1 ${NUMFILES})
	do
		printf "creating file number %d\n" "${fileno}"
		#touch "file-${fileno}"
		dd if=/dev/urandom of="${curdir}/file-${fileno}" bs="${EACHFILESIZE}" count=1 conv=fdatasync status=none &
	done
	wait
	popd

done
popd
sync


Update stored emails

If a Mail is loaded into storage, and some other client changes flags on these mails...our mail client wont update his flags. We need to figure out a smart way, how to reflect changes on the server into our already loaded mails.
"In that case pressing update will load the locally stored email. And the locally stored email does not know about any changes on the other device. For similar reason I initially never stored and loaded the flags locally, but always loaded from the server (thus, there was never a reason to store them). But this caused bad performance, so I changed it in this issue again..."

There is actually an easy way to solve this issue. In case of an email that is loaded from your local disk, we will nevertheless retrieve the flags from the server. But everything else (body, subject etc.) is still loaded from the local file, thus, performance should be fine.
This works fine for the update after your first login (I tested it). But after the first login, pressing the update button will only load those emails that are new on the server and not yet listed in UI. So any changes to emails listed in the UI will be ignored. Maybe we should reconsider the logic of "Update" (and reverse some changes done in fixing_leonard?). Leonard, what do you think?

Should be closes with #155


Cannot get world-space normal in fragment shader

Tested on Godot 2.0.4, Windows 10 64 bits
I need to get the world-space normal of the model in a fragment shader, however all my attempts have failed so far.
There is no access to SRC_NORMAL, which is only available in the vertex shader.
I also tried to use the formula indicated in the documentation:
// Use reverse multiply because INV_CAMERA_MATRIX is world2cam
vec3 world_normal = NORMAL * mat3(INV_CAMERA_MATRIX);

However this throws an error:
Error precompiling shader: Invalid arguments to function/constructor: mat3

Note: if it's actually possible, maybe it's a documentation issue because the above line doesn't works.

Related to #5232

Documentation says the INV_CAMERA_MATRIX is mat4 so the example is probably wrong. Btw, did you try put the SRC_NORMAL to VAR1 or VAR2 and get the normal in FS?

@GlaDOSik yes I use that instead, it does the job pretty well (although VARs are limited). The documentation should be updated.

Not critical for the upcoming 2.1, so moving to the next milestone.

are you sure the example in documentation isn't telling you to do something more:
vec4 invcamx = INV_CAMERA_MATRIX.x;
vec4 invcamy = INV_CAMERA_MATRIX.y;
vec4 invcamz = INV_CAMERA_MATRIX.z;
vec4 invcamw = INV_CAMERA_MATRIX.w;

mat3 invcam = mat3(invcamx.xyz, invcamy.xyz, invcamz.xyz);

vec3 world_normal = NORMAL * invcam;

;)

Ah, looks like the documentation has been updated since, because I cannot find the initial example anymore.

So, I understand that was fixed in the docs.

i can't now find this in the docs and keep forgetting, for the record here the world normal, useful for making say cliff top shader (green on top, rocky at sides), is:
vec3 WORLD_NORMAL = (INV_VIEW_MATRIX * vec4(NORMAL.xyz, 0.0)).xyz;


Import statements in Examples are wrong

When I tried to run the SINDy: Van Der Pol Oscillator example on my local machine the imports didn't work.
For example from pySINDy.sindy import SINDy should be from pysindy import SINDy
Besides that I couldnt figure out how from pySINDy.utils.generator import van_der_pol_generator
Installed PySINDy with pip install...

Seems like the Issue lies within the installation with pip. Installing from source solved my issues.

Hey Philipp, thanks for the feedbacks!
And actually this repo is experiencing an upgrade recently ... You can see the latest (official) version here: https://github.com/dynamicslab/pysindy


FindFieldsWithType is finding a local variable

I have a recipe that wants to add a field if one doesn't already exist. In one class I ran it against, it broke the code. I was able to narrow it down to FindFieldsWithType returning a variable.
I added this test in rewrite-java-tck/src/main/kotlin/org/openrewrite/java/search/FindFieldsOfTypeTest.kt to demonstrate the issue - it is failing.
    @Test
    fun findFieldNotVariable(jp: JavaParser) = assertUnchanged(
        jp,
        recipe = FindFieldsOfType("java.io.File"),
        before = """
            import java.io.*;
            public class Test {
                public static void main(String[] args) {
                    File f = new File("/dev/null");
                }
            }
        """
    )

Thanks :)


Add support for commenting systems

With the goal of getting octopress 3 at an MVP state, are you interested in simple disqus support in the theme itself? I know it's not ideal, but better hard-coded in the example theme than in the framework itself, and at some point someone can figure out the right abstraction to make it pluggable. Basically, I just pulled what was in octopress 2 in: https://github.com/ludwick/genesis-theme/commit/96ff6c642477c5e98f363a5c043567a8fee6d87c

It'd be cool to make the commenting system pluggable rather than embedded into any theme itself. Abstract away the engine (like Disqus or what have you) from the UI.

Yes, I plan to add generic support for comments. I only really have experience with disqus and it has been a while since I last looked at their documentation. Basically I'd like to make it easy for people to inject scripts into the template after their posts. It seems like this and being able to add a comments link to blog index pages should take care of it. What do you think @ludwick?

Something pluggable would be great. When I first commented I was on a mental track of "it sure would be nice to get just the basics out!"
I'll see if I can work something out. I played with genesis-theme enough that I ended up deciding to fork (and rename) it to make a theme of my own which gives incentive to come up with a slightly more generic way of doing it.

Okay, step 1: factor out into octopress ink plugin.
https://github.com/ludwick/octopress-basic-comments
Configuration goes in one's website repo at _plugins/octopress-basic-comments/config.yml with the convention. Right now the template has to include the specific comment plugin (example) but that seems easily fixable.

Feel free to comment on anything. While I know ruby pretty well now for work-internal stuff, jekyll, gem packaging, exactly how ink work, etc. are pretty new to me as with octopress 2 I didn't really (need to) dig into how any of it worked.

I've added support for Disqus and Facebook commenting systems by integrating the octopress-social plugin. Configure that plugin and set comments: disqus or comments: facebook in your _plugins/theme/config.yml and posts will have comments in their footer.


Tags Not Working

Just got started with the template, and with the sample posts and all the tags aren't showing, any reason why this might be failing? Console log isnt showing any errors though. Attached screenshot below.
Edit: The Jekyll Drops was me trying to debug the site.tags

Hi. On your blog post in between the header meta data surrounded by --- have you included tags: [mytag1, mytag2, etc]

yes I have! the tags metadata is already present in the sample posts.
Best,
Syed Mohammad Sualeh Ali
On Fri, Jul 3, 2020 at 4:04 PM Corrie Green<EMAIL_ADDRESS>wrote:

Hi. On your blog post in between the header meta data surrounded by ---
have you included tags: [mytag1, mytag2, etc]
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/renyuanz/leonids/issues/96#issuecomment-653490949,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFS5WPJWNNNXDKDX6UZAFKTRZW3KZANCNFSM4OPO5UEA
.

Resolved, was a typo . sorry for the trouble :)


Help Wanted: Display code copy button for all inline code formatted text

Problem space
Currently, visitors on the product documentation site can only use the copy code option for code blocks. This option isn't available for inline formatted code text lines.
Code block copy option in published documentation:

Inline code text with no copy option:

Target audience
All users, and particularly system admins, developers, and integrators.
Goal
Enable the copy code option on all code samples across the product documentation site.
Delivery expectations

1 PR with all proposed changes
Comment in the PR to request a generated preview of your work. The Docs team will add the appropriate labels to your PR.

Tech needed

Sphinx
RST, MD formats
See the documentation PR that introduced the code copy extension to the tech stack and the documentation site for details.
The request is to extend this functionality so that the copy code option appears on inline formatted code as well as code blocks.

Affected repository
mattermost/docs
Where to get help
Join the Mattermost Docs team on the Mattermost Community Server in the ~Documentation Working Group channel to discuss this ticket, or feel free to comment in this docs ticket.

Hello, I would like to work on this issue.

Thanks @jpphilips - I've assigned the issue to you. Let @cwarnermm know if you have any questions :)

If I understand the issue correctly, I'm supposed to modify the sphinx extension to effect the change. yes?
Specifically, I need to add the selector for the inline code text.
Going through the documentation, sphinx adds the copy button to the code block because it matches the selector "div.highlight pre" while the inline code is a span with a class of "pre".
What i'm thinking is to set the selector to "div.highlight pre, span.pre"

@jpphilips - I'm excited to see what you come up for this documentation ticket! I suspect that modifying the copy/paste extension code is a good way through. What I'm less sure about is how that the copy copy option will look on the page once applied to inline formatted code examples.

I made a PR. Pls check and see if I made the PR the right way

@neflyte - Are you open to reviewing this PR from a technical perspective?

@neflyte, the PR is here (I couldn't add you as a reviewer for some reason): https://github.com/mattermost/docs/pull/5927

Closing this ticket because it intended to introduce a copy/paste option for inline code text across the product documentation site. We're going to change direction on this and look to convert these code examples to code blocks for consistency and predictability instead.