Fan stuck at 0 RPM

a couple days ago I was having shutdown issues and after some digging, found out the GPU fan was stuck at 0 RPM (measured by HWInfo/RTSS and confirmed upon visual inspection) when controlled by fancontrol, even if fancontrol showed a PWM percent.
fan curve is set to linear with GPU core temp (or even hotspot temp). core temp wasn't that high but hotspot temps were in the 90s. (Celsius)
disabling the fancontrol control and restoring settings in adrenaline fixed it, but only because now it's adrenaline who controls the fan, not fancontrol.
GPU is 6650xt, driver is up to date, OS is a fresh install of W11 (was working seemingly fine before the reinstall).

What PWM percent was it?

IIRC 30-40%, definitely high enough for it to spin up.
On Wed, Apr 17, 2024 at 4:34 PM Rem0o @.***> wrote:

What PWM percent was it? Might it be too low?
—
Reply to this email directly, view it on GitHub
https://github.com/Rem0o/FanControl.ADLX/issues/35#issuecomment-2061410667,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQQWWB4MLLOAQKZVPJUJBDY52CABAVCNFSM6AAAAABGK5XTKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGQYTANRWG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

--

niky45 <<

definitely high enough for it to spin up.

Are you actually sure?
At what % does it start spinning from a stop?

when set to follow the hotspot, hotspot was at like 90+C, and curve is
supposed to reach 100% speed at ~90C, so I'm very sure it was above start
speed.
as for what % does it take so start, I'd say it's 20, but might be ~30.
I can do more testing if you want, just tell me what tests you want me to
run (including logs, either through fancontrol of through HWInfo), because
I 100% want to help get this fixed -- the default curve starts too late and
then makes too much noise, and I could adjust it in adrenalin, but it
doesn't seem to support a stopped fan when on a custom curve. also would
rather control all my fans through the same util.
On Wed, Apr 17, 2024 at 6:14 PM Rem0o @.***> wrote:

definitely high enough for it to spin up.
Are you actually sure?
At what % does it start spinning from a stop?
—
Reply to this email directly, view it on GitHub
https://github.com/Rem0o/FanControl.ADLX/issues/35#issuecomment-2061682208,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQQWWHSYJPJYSBNO4MDJ3TY52NSJAVCNFSM6AAAAABGK5XTKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGY4DEMRQHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--

niky45 <<

UPDATE: just ran the "detect fan start % automatically" -- it said 6%.
also, running some more tests, I can confirm that it doesn't happen
"always". have to figure out when it happens.
On Wed, Apr 17, 2024 at 6:51 PM niky 45 @.***> wrote:

when set to follow the hotspot, hotspot was at like 90+C, and curve is
supposed to reach 100% speed at ~90C, so I'm very sure it was above start
speed.
as for what % does it take so start, I'd say it's 20, but might be ~30.
I can do more testing if you want, just tell me what tests you want me to
run (including logs, either through fancontrol of through HWInfo), because
I 100% want to help get this fixed -- the default curve starts too late and
then makes too much noise, and I could adjust it in adrenalin, but it
doesn't seem to support a stopped fan when on a custom curve. also would
rather control all my fans through the same util.
On Wed, Apr 17, 2024 at 6:14 PM Rem0o @.***> wrote:

definitely high enough for it to spin up.
Are you actually sure?
At what % does it start spinning from a stop?
—
Reply to this email directly, view it on GitHub
https://github.com/Rem0o/FanControl.ADLX/issues/35#issuecomment-2061682208,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQQWWHSYJPJYSBNO4MDJ3TY52NSJAVCNFSM6AAAAABGK5XTKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGY4DEMRQHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--

niky45 <<

--

niky45 <<

I think I ran in similar issue. I have a RX 6950XT ASRock Phantom Gaming. By default it runs 20% minimum which gives me about 1075 RPMs. Using the MorePowerTool I finally managed to lower the minimum RPMs to 15% witch relates to 825 RPMS and noticeable lowers the fan noise.
This card has three fans. The middle one stops when the PWM is set to 13%. For the 12% all three fans stops. The strange point of this situation:

for 14% PWM all fans are spinning but RPM readings in FanControl are strange - shows 787, or 1047 or 1586 (+/-),
for 13% PWM middle fan stops and RPM readings is about 1515 RPM (but the real fan speed is a way slower, so the reading is incorrect, maybe it is a sum of both spinning fans?).

Anyway from the time when I changed the minimum fan speed I have ran into an issue when sometimes my PC is not completely powering off - the system is off, but the RGBs and fans are still spinning. Not sure it is related to the FanControl but I was using the FanControl before changing the minimum fans speed and it does not happened to me then.

Give https://github.com/Rem0o/FanControl.ADLX/releases/tag/V0.1 a try

will certainly do, thanks so much for all the effort you're putting into
making our lives better
On Sat, Apr 27, 2024 at 6:32 PM Rem0o @.***> wrote:

Give https://github.com/Rem0o/FanControl.ADLX/releases/tag/V0.1 a try
—
Reply to this email directly, view it on GitHub
https://github.com/Rem0o/FanControl.ADLX/issues/35#issuecomment-2081031588,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQQWWAYUQA6HZSDMJJYPV3Y7PHILAVCNFSM6AAAAABGK5XTKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRGAZTCNJYHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--

niky45 <<

@niky45  hope it works out. Been using the plugin myself for a day with a new GPU, had no weird issues so far.

seems to be working, as in, it has been active and I've had no crashes or
anything.
On Sat, Apr 27, 2024 at 7:04 PM Rem0o @.***> wrote:

@niky45 https://github.com/niky45 hope it works out. Been using the
plugin myself for a day with a new GPU, had no weird issues so far.
—
Reply to this email directly, view it on GitHub
https://github.com/Rem0o/FanControl.ADLX/issues/35#issuecomment-2081096837,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQQWWCVJEISE2AB3DHL5Z3Y7PLBNAVCNFSM6AAAAABGK5XTKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRGA4TMOBTG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

--

niky45 <<


Add conda install instructions

Advertise conda availability in README.
No code changes.

Good point, though the command won't work without -c conda-forge or
conda config --add channels conda-forge

for users who haven't already set up conda-forge as one of their channels. (It's not one of the default ones.)


Fix issues with null pointers on jobResponse

Description
I was doing some additional testing on my change in https://github.com/apache/druid/pull/14001, and realized that I missed some logic to handle the null job in  getJobDuration. This causes a null pointer exception to be thrown when a job is manually shut down.
Release note

FIx bug with manual task shutdown in the KubernetesTaskRunner

Key changed/added classes in this PR

Explicitly pass null as the job parameter to the JobResponse constructor

Add a log for when the job has been manually cleaned up

Check job null status when grabbing name for logs

[X] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.

[ ] a release note entry in the PR description.

[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.

[ ] added or updated version, license, or notice information in licenses.yaml

[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.

[X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.

[ ] added integration tests.

[X] been tested in a test Druid cluster.

When you say, job is manually cleaned up, do you mean someone cancelling the task from console (or from druid API) or someone terminating the pod manually?

When you say, job is manually cleaned up, do you mean someone cancelling the task from console (or from druid API) or someone terminating the pod manually?

either cancelling the task or terminating the k8s job manually will do this (terminating the pod will cause the job to restart it iirc)


Remove jQuery dependency

Seems like the snapshot.js file is currently dependent on jQuery. We are in the process of removing jQuery from our Ember add ons and applications and it would be nice to be able to run tests without jQuery as well.

@mm2ha Can you explain a bit more of the context here please?

percySnapshot dies with the following error if jQuery.ajax is not available.
TypeError: _ember.default.$.ajax is not a function
    at http://localhost:7357/assets/vendor.js:132928:27
    at Backburner.run (http://localhost:7357/assets/vendor.js:18121:36)
    at Object.run$1 [as run] (http://localhost:7357/assets/vendor.js:35529:27)
    at percySnapshot (http://localhost:7357/assets/vendor.js:132926:23)
    at Class.<anonymous> (http://localhost:7357/assets/tests.js:543:35)
    at http://localhost:7357/assets/vendor.js:52350:19
    at isolate (http://localhost:7357/assets/vendor.js:53470:17)
    at onFulfillment (http://localhost:7357/assets/vendor.js:53407:16)
    at tryCatch (http://localhost:7357/assets/vendor.js:61448:14)
    at invokeCallback (http://localhost:7357/assets/vendor.js:61461:15)

This also happens if someone includes the jQuery "slim" version without the ajax method.

There is a bit of momentum behind removing the need for jQuery since Ember doesn't rely on it anymore. I think Miguel's article contributed quite a bit and shows a practical path to removing jQuery in testing: http://miguelcamba.com/blog/2017/04/11/the-future-of-embers-testing-and-the-beheading-of-jquery/
I think it would be great if Percy didn't rely on jQuery and from a quick search it looks like it's currently only being used to make a request with the snapshot, is this correct? If so, could ember-fetch be used instead? Are you open to the idea and would a pull request help?
Thanks!

Definitely open to the idea! There might also be a path where we can include it specifically only in tests, for the case where people want to remove jQuery from their production builds but don't mind if it's still included in tests (which is the only place that this addon needs Ember.$).
We rely on jQuery for a few specific uses: making ajax calls (from the tests to /_percy middleware on the node process), but also for .clone() to capture the DOM snapshot, manipulating it, and serializing it to HTML (see the Ember.$ references in here: https://github.com/percy/ember-percy/blob/master/addon/snapshot.js). Not something that ember-fetch will completely take care of, but doable if we can maintain backwards compatibility. @jeffjewiss if you're interested in exploring a PR for this we'd definitely be up for working through it with you. The tests in here are mostly integration tests with percy itself, so they usually require running against a Percy project and then looking at the snapshots to see if anything changed — you can easily set up a percy trial and run the tests locally with the right env vars exported, or we can help set up something else.

Okay great, thanks for the explanation on the parts that would need updating.
I think it might be a bit too complicated to have jQuery still included in tests due to the recommendation of doing:
  let app = new EmberAddon(defaults, {
    vendorFiles: { 'jquery.js': null }
  });

in ember-cli-build.js, which removes it completely. Users would have to remember to set this up so that jQuery isn't removed from the test environment, which may also cause some inconsistencies in the app itself. Personally, I think it would be best if Percy didn't rely on jQuery at all (if it could be made backwards compatible). Does that sound reasonable?
I'm interested in exploring a PR for this. I'd likely need some help setting up testing locally, but I do have a personal site setup using ember-percy.
I'll get a fork and PR created soon and start on using ember-fetch instead of .ajax and go from there. Is there documentation on setting up the testing environment locally? Do I just need to npm link this package to my project that uses ember-percy?
Thanks!

Ah that makes sense. So an easy workaround for now would be to wrap that EmberAddon block with an environment check to see if it's building for tests. Hacky, but would allow you to keep jQuery out of your main app.
Yes you can npm link the addon, or actually just run the addon's tests itself as it has a dummy app with some basic snapshots that get sent up. Most of the tests for ember-percy itself rely on just looking at the percy snapshots in Percy itself, making sure they're the same and have captured the same information, so if you have a project or trial available you can just run ember-percy's own tests with the PERCY_TOKEN and PERCY_PROJECT tokens available and see what happens in Percy. Let me know if that doesn't make sense!

Having jQuery in test environment but not dev/prod sounds like a tiny footgun to me, tests might pass with jQuery usage while the actual build might try to use jQuery and fail. While there is an eslint-plugin-ember which detects jQuery usage, I think not everybody is using it.

Just FYI, we're going to start moving this forward and getting rid of jQuery in ember-percy.

@jeffjewiss there is great interest in landing it, we just haven't had time to really dig in and prioritize and test it. Since we only have a very lightweight amount of jQuery we actually need, I attempted at one point to have a vendorized jquery-lite specific for ember-percy that would allow us to not change any of the existing code but still allow users to remove their own jquery dependency. Didn't get far enough with that to do anything with it but I think it's still an ok idea to make sure this package maintains backwards compatibility.

This has been officially fixed and released in v1.4.0.  You can now use ember-percy with Ember apps that strip jquery.
Thanks all!


MXNet official tutorial model to tensorflow

Platform (like ubuntu 16.04/win10): ubuntu16.04 Anaconda
Python version:3.6
Source framework with version (like Tensorflow 1.4.1 with GPU):1.8 with GPU
Destination framework with version (like CNTK 2.3 with GPU): MXNet 1.2.1 with GPU
Pre-trained model path (webpath or webdisk path): https://drive.google.com/drive/folders/1MQUYEPYnvWRmGBPh338Le5DFYnq-yr7Z?usp=sharing
(this model is got from the MXNet official tutorial Saving and Loading Gluon Models
Running scripts:
 python -m mmdnn.conversion._script.convertToIR -f mxnet -n lenet-symbol.json -w lenet-0001.params -d resnet --inputShape 1 28 28

Error:
el_names=['softmax_label']) but input with name 'softmax_label' is not found in symbol.list_arguments(). Did you mean one of:
        data
  warnings.warn(msg)
Warning: MXNet Parser has not supported operator null with name data.
Warning: convert the null operator with name [data] into input layer.
infer_shape error. Arguments:
  data: (1, 1)
Traceback (most recent call last):
  File "/home/csf/anaconda3/envs/tf18/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/csf/anaconda3/envs/tf18/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/csf/anaconda3/envs/tf18/lib/python3.6/site-packages/mmdnn/conversion/_script/convertToIR.py", line 199, in <module>
    _main()
  File "/home/csf/anaconda3/envs/tf18/lib/python3.6/site-packages/mmdnn/conversion/_script/convertToIR.py", line 194, in _main
    ret = _convert(args)
  File "/home/csf/anaconda3/envs/tf18/lib/python3.6/site-packages/mmdnn/conversion/_script/convertToIR.py", line 117, in _convert
    parser.run(args.dstPath)
  File "/home/csf/anaconda3/envs/tf18/lib/python3.6/site-packages/mmdnn/conversion/common/DataStructure/parser.py", line 22, in run
    self.gen_IR()
  File "/home/csf/anaconda3/envs/tf18/lib/python3.6/site-packages/mmdnn/conversion/mxnet/mxnet_parser.py", line 262, in gen_IR
    func(current_node)
  File "/home/csf/anaconda3/envs/tf18/lib/python3.6/site-packages/mmdnn/conversion/mxnet/mxnet_parser.py", line 424, in rename_Convolution
    self.set_output_shape(source_node, IR_node)
  File "/home/csf/anaconda3/envs/tf18/lib/python3.6/site-packages/mmdnn/conversion/mxnet/mxnet_parser.py", line 281, in set_output_shape
    arg_shape, output_shape, aux_shape = sym.infer_shape(data = self.data_shape)
  File "/home/csf/anaconda3/envs/tf18/lib/python3.6/site-packages/mxnet/symbol/symbol.py", line 990, in infer_shape
    res = self._infer_shape_impl(False, *args, **kwargs)
  File "/home/csf/anaconda3/envs/tf18/lib/python3.6/site-packages/mxnet/symbol/symbol.py", line 1120, in _infer_shape_impl
    ctypes.byref(complete)))
  File "/home/csf/anaconda3/envs/tf18/lib/python3.6/site-packages/mxnet/base.py", line 149, in check_call
    raise MXNetError(py_str(_LIB.MXGetLastError()))
mxnet.base.MXNetError: Error in operator hybridsequential0_conv0_fwd: [09:51:51] src/operator/nn/convolution.cc:143: Check failed: dshp.ndim() == 4U (2 vs. 4) Input data should be 4D in batch-num_filter-y-x

Stack trace returned 10 entries:
[bt] (0) /home/csf/anaconda3/envs/tf18/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x31f81a) [0x7f03434c581a]
[bt] (1) /home/csf/anaconda3/envs/tf18/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x31fe41) [0x7f03434c5e41]
[bt] (2) /home/csf/anaconda3/envs/tf18/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x54a1e1) [0x7f03436f01e1]
[bt] (3) /home/csf/anaconda3/envs/tf18/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x24de24a) [0x7f034568424a]
[bt] (4) /home/csf/anaconda3/envs/tf18/lib/python3.6/site-packages/mxnet/libmxnet.so(+0x24e0b40) [0x7f0345686b40]
[bt] (5) /home/csf/anaconda3/envs/tf18/lib/python3.6/site-packages/mxnet/libmxnet.so(MXSymbolInferShape+0x15aa) [0x7f03456008ba]
[bt] (6) /home/csf/anaconda3/envs/tf18/lib/python3.6/lib-dynload/../../libffi.so.6(ffi_call_unix64+0x4c) [0x7f0371dc1ec0]
[bt] (7) /home/csf/anaconda3/envs/tf18/lib/python3.6/lib-dynload/../../libffi.so.6(ffi_call+0x22d) [0x7f0371dc187d]
[bt] (8) /home/csf/anaconda3/envs/tf18/lib/python3.6/lib-dynload/_ctypes.cpython-36m-x86_64-linux-gnu.so(_ctypes_callproc+0x2ce) [0x7f0371fd6e2e]
[bt] (9) /home/csf/anaconda3/envs/tf18/lib/python3.6/lib-dynload/_ctypes.cpython-36m-x86_64-linux-gnu.so(+0x12865) [0x7f0371fd7865]

Hi @ShoufaChen ,The error shows "Input data should be 4D in batch-num_filter-y-x". you may need to use:
--inputShape 1,28,28
not
--inputShape 1 28 28

Hi @ShoufaChen , if you are using Gluon not the original MXNet. The name of weights and bias is different . You can refer to this https://github.com/Microsoft/MMdnn/issues/208

@ShoufaChen I also have the same problem as you. When changing the -- input shape as 3,112,112,  I also got the same problem as you. Have you fixed you problem?

Hello @hellolingling , if you are using Gluon not the original MXNet. The name of weights and bias is different . You can refer to this https://github.com/Microsoft/MMdnn/issues/208

Hi, @namizzz thank you for your reply!
But, I referred to #208, and changed the code as suggested. And I am not using Gluon. I met the same problem as shown below:
Input：
python -m mmdnn.conversion._script.convertToIR -f mxnet -n model-symbol.json -w model-0000.params -d model-descr512 --inputShape 3,112,112
<mmdnn.conversion.mxnet.mxnet_parser.MXNetParser object at 0x7fdd6b129f10> Warning: MXNet Parser has not supported operator null with name data. Warning: convert the null operator with name [data] into input layer. Traceback (most recent call last):   File "/home/zhulingling/anaconda2/lib/python2.7/runpy.py", line 174, in _run_module_as_main     "__main__", fname, loader, pkg_name)   File "/home/zhulingling/anaconda2/lib/python2.7/runpy.py", line 72, in _run_code     exec code in run_globals   File "/home/zhulingling/workspace/model_conversion/MMdnn/mmdnn/conversion/_script/convertToIR.py", line 207, in <module>     _main()   File "/home/zhulingling/workspace/model_conversion/MMdnn/mmdnn/conversion/_script/convertToIR.py", line 201, in _main     ret = _convert(args)   File "/home/zhulingling/workspace/model_conversion/MMdnn/mmdnn/conversion/_script/convertToIR.py", line 121, in _convert     parser.run(args.dstPath)   File "mmdnn/conversion/common/DataStructure/parser.py", line 22, in run     self.gen_IR()   File "mmdnn/conversion/mxnet/mxnet_parser.py", line 264, in gen_IR     func(current_node)   File "mmdnn/conversion/mxnet/mxnet_parser.py", line 400, in rename_FullyConnected     weight = self.weight_data.get(source_node.name.replace("fwd","weight")).asnumpy().transpose((1, 0)) AttributeError: 'NoneType' object has no attribute 'asnumpy'
Can you help solve the problem?

Hi, @namizzz ,according the issue https://github.com/Microsoft/MMdnn/issues/231.
I changed the
File "mmdnn/conversion/mxnet/mxnet_parser.py", line 401, in rename_FullyConnected     weight = self.weight_data.get(source_node.name + "_weight").asnumpy().transpose((1, 0))
into
weight = self.weight_data.get("fc1_weight").asnumpy().transpose((1, 0)).
This worked, thank you!

#231


KeyError: 'input_ids_j' in training

Thanks for your wonderful project!
I got an error during training with custom dataset:
 11%|██████████████                                                     | 125/1125 [1:04:25<8:30:35, 30.64s/it]
Traceback (most recent call last):
    "input_ids": feature["input_ids_j"],    "input_ids": feature["input_ids_j"],

KeyErrorKeyError: : 'input_ids_j'

There is no empty value in my chosen and rejected data. I don't understand why it happens.

In build_dataset(tokenizer, train_path, eval_path) and ds = ds.map(tokenize, num_proc=8), we should add the feature 'input_ids_j' for each sample. Can you provide a minimal script to reproduce the error?

Sorry, I noticed that the passed independent validation data was not properly processed .
Solved. Thank you again.


Merging multiple pdf option

Currently, if a user creates a pdf he needs to merge them then we should have the option.
create a new pdf merging two pdfs. below is a sample attached there. create a new tab in the navbar for this.

hey, I would like to work on this issue.

hey @anushbhatia
i am interested to contribute to this issue.
please assign me this issue

hey @anushbhatia
i am interested to contribute to this issue.
please assign me this issue

Please understand that once a participant has been assigned an issue, at least within the next 24 hours (excluding certain circumstances) the issue won't be reassigned

hey, I would like to work on this issue.

Assigned for 4 days.
Please ensure:

The title of the PR is short and meaningful
You refer to the respective issue in the PR description Resolves # issue_number
Attach screenshot(s)/clip of the result of your changes
(In bullet points) describe your changes

For the PR:

Do not mess up the code for the other pages
Create a new page
Update the navbar
Do the routing properly (Do not give a PR with routing w.r.t local host. I will immediately close it)
Keep the page simple
Have a section called merge PDFs (put an appropriate heading)
The functionality is self-explained
Have an option to download (perhaps trigger it once it is done)
Set the limit to 20 PDFs


Unable to build micro-ros-agent : DDS_CDR

Issue template

Hardware description: Ubuntu 22.04 with ROS2 Humble.
RTOS: no rtos
Installation type:  micro_ros_setup
Version or commit hash: humble

Steps to reproduce the issue
Follow the steps in installing micro_ros shown here : https://micro.ros.org/docs/tutorials/core/first_application_linux/
Start the build process
Expected behavior
Package builds successfully
Actual behavior
Get the following output :
Starting >>> rosidl_typesupport_microxrcedds_c_tests

--- stderr: micro_ros_agent

Cloning into 'xrceagent'...

Switched to a new branch 'ros2'

HEAD is now at c25243c Enable Domain Override on Reference and XML Participant (#351)

CMake Warning (dev) at /usr/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:438 (message):

  The package name passed to `find_package_handle_standard_args` (tinyxml2)

  does not match the name of the calling package (TinyXML2).  This can lead

  to problems in calling code that expects `find_package` result variables

  (e.g., `_FOUND`) to follow a certain pattern.

Call Stack (most recent call first):

  cmake/modules/FindTinyXML2.cmake:40 (find_package_handle_standard_args)

  /opt/ros/humble/share/fastrtps/cmake/fastrtps-config.cmake:51 (find_package)

  CMakeLists.txt:153 (find_package)

This warning is for project developers.  Use -Wno-dev to suppress it.

/home/n0sc3tipsum/microros_ws/src/uros/micro-ROS-Agent/micro_ros_agent/src/agent/graph_manager/graph_typesupport.cpp: In member function ‘virtual bool uros::agent::graph_manager::ParticipantEntitiesInfoTypeSupport::serialize(void*, eprosima::fastrtps::rtps::SerializedPayload_t*)’:

/home/n0sc3tipsum/microros_ws/src/uros/micro-ROS-Agent/micro_ros_agent/src/agent/graph_manager/graph_typesupport.cpp:57:33: error: ‘DDS_CDR’ is not a member of ‘eprosima::fastcdr::Cdr’

   57 |         eprosima::fastcdr::Cdr::DDS_CDR);

      |                                 ^~~~~~~

/home/n0sc3tipsum/microros_ws/src/uros/micro-ROS-Agent/micro_ros_agent/src/agent/graph_manager/graph_typesupport.cpp:64:54: error: ‘class eprosima::fastcdr::Cdr’ has no member named ‘getSerializedDataLength’; did you mean ‘get_serialized_data_length’?

   64 |         payload->length = static_cast<uint32_t>(scdr.getSerializedDataLength());

      |                                                      ^~~~~~~~~~~~~~~~~~~~~~~

      |                                                      get_serialized_data_length

/home/n0sc3tipsum/microros_ws/src/uros/micro-ROS-Agent/micro_ros_agent/src/agent/graph_manager/graph_typesupport.cpp: In member function ‘virtual bool uros::agent::graph_manager::ParticipantEntitiesInfoTypeSupport::deserialize(eprosima::fastrtps::rtps::SerializedPayload_t*, void*)’:

/home/n0sc3tipsum/microros_ws/src/uros/micro-ROS-Agent/micro_ros_agent/src/agent/graph_manager/graph_typesupport.cpp:80:33: error: ‘DDS_CDR’ is not a member of ‘eprosima::fastcdr::Cdr’

   80 |         eprosima::fastcdr::Cdr::DDS_CDR);

      |                                 ^~~~~~~

/home/n0sc3tipsum/microros_ws/src/uros/micro-ROS-Agent/micro_ros_agent/src/agent/graph_manager/graph_typesupport.cpp: In member function ‘virtual bool uros::agent::graph_manager::MicrorosGraphInfoTypeSupport::serialize(void*, eprosima::fastrtps::rtps::SerializedPayload_t*)’:

/home/n0sc3tipsum/microros_ws/src/uros/micro-ROS-Agent/micro_ros_agent/src/agent/graph_manager/graph_typesupport.cpp:149:33: error: ‘DDS_CDR’ is not a member of ‘eprosima::fastcdr::Cdr’

  149 |         eprosima::fastcdr::Cdr::DDS_CDR);

      |                                 ^~~~~~~

/home/n0sc3tipsum/microros_ws/src/uros/micro-ROS-Agent/micro_ros_agent/src/agent/graph_manager/graph_typesupport.cpp:156:54: error: ‘class eprosima::fastcdr::Cdr’ has no member named ‘getSerializedDataLength’; did you mean ‘get_serialized_data_length’?

  156 |         payload->length = static_cast<uint32_t>(scdr.getSerializedDataLength());

      |                                                      ^~~~~~~~~~~~~~~~~~~~~~~

      |                                                      get_serialized_data_length

/home/n0sc3tipsum/microros_ws/src/uros/micro-ROS-Agent/micro_ros_agent/src/agent/graph_manager/graph_typesupport.cpp: In member function ‘virtual bool uros::agent::graph_manager::MicrorosGraphInfoTypeSupport::deserialize(eprosima::fastrtps::rtps::SerializedPayload_t*, void*)’:

/home/n0sc3tipsum/microros_ws/src/uros/micro-ROS-Agent/micro_ros_agent/src/agent/graph_manager/graph_typesupport.cpp:172:33: error: ‘DDS_CDR’ is not a member of ‘eprosima::fastcdr::Cdr’

  172 |         eprosima::fastcdr::Cdr::DDS_CDR);

      |                                 ^~~~~~~

gmake[5]: *** [CMakeFiles/micro_ros_agent.dir/build.make:118: CMakeFiles/micro_ros_agent.dir/src/agent/graph_manager/graph_typesupport.cpp.o] Error 1

gmake[4]: *** [CMakeFiles/Makefile2:137: CMakeFiles/micro_ros_agent.dir/all] Error 2

gmake[3]: *** [Makefile:146: all] Error 2

gmake[2]: *** [CMakeFiles/micro_ros_agent.dir/build.make:86: micro_ros_agent-prefix/src/micro_ros_agent-stamp/micro_ros_agent-build] Error 2

gmake[1]: *** [CMakeFiles/Makefile2:111: CMakeFiles/micro_ros_agent.dir/all] Error 2

gmake: *** [Makefile:91: all] Error 2

---

Failed   <<< micro_ros_agent [7min 39s, exited with code 2]

Aborted  <<< rosidl_typesupport_microxrcedds_c_tests [21.7s]

Additional information

Duplicated https://github.com/micro-ROS/micro_ros_setup/issues/705


Hello, I have a question for you

Hello, thank you very much for the code you provided, but I would like to ask, why sometimes adding RevIN in SCINet performs better when the length of the input sequence is different from the length to be predicted for my own data set, but in the same data Under the set, change the length of the input sequence, and the performance of adding RevIN is not good.

RevIN utilizes the statistics of the input sequence to derive the current distribution of the time series. This implies that the length of the input sequence can impact RevIN's performance. Although we demonstrated in the paper that RevIN is robust to changes in the input sequence length, there may exist an optimal length for capturing the current distribution of the time series. Furthermore, the optimal length may vary across different time series datasets.


Add specs for Array#reject!, delete_if 2.3 change

From #175:
Array#select!, Array#keep_if, Array#reject!, and Array#delete_if
no longer changes the receiver array instantly every time the
block is called. Feature #10714
Note, select! and keep_if's behavior seems to be unchanged with 2.3.
I tested with 2.3.1, 2.2.5, 2.1.8, and 2.0.0-p648 and they don't mutate the
receiver after each block, only after all blocks.

Thanks a lot, looks good!

@eregon Updated.  I didn't want to change unrelated block variables to e also since others use i so I kept it only to my changes.  I agree, it makes more sense.

The changes while iterating in keep_if/select! can also be observed, but it's trickier as the size is only changed at the very end. The elements however might be reassigned while iterating:
[1] pry(main)> a = [1,2,3,4,5]
=> [1, 2, 3, 4, 5]
[2] pry(main)> a.keep_if { |e| p a; e.even? }
[1, 2, 3, 4, 5]
[1, 2, 3, 4, 5]
[2, 2, 3, 4, 5]
[2, 2, 3, 4, 5]
[2, 4, 3, 4, 5]
=> [2, 4]
[3] pry(main)> RUBY_VERSION
=> "2.2.3"

You are right though it seems there is not much difference between latest 2.2 and 2.3.
Maybe there was a change in between which never got in a release.

Thank you for your contribution, it's much appreciated!
If you feel on a roll, you can try spec'ing keep_if/`select! in more details according to my previous comment 😃

I didn't want to change unrelated block variables to e

Yes absolutely, I meant only those in your changes.
Then it's my job to maintain the rest :)


Not an android app

Would be a great thing to release an android version of the app since not everyone has access to a mac or an Iphone or an apple watch or an apple tv, but for the rest the app looks nice

Working on it... :)


Minor, partial FindBugs cleanup

Relates to https://github.com/lightbody/browsermob-proxy/issues/638

Thanks for keeping an eye out for defects. I've updated the Files.toString usage with the suggested guava alternative.
Regarding defensive copies of the Date objects in CertificateInfo, that's a harmless change a theoretical benefit, but practically speaking it won't matter. CertificateInfos are meant to be used in builder-like situations where it wouldn't really matter whether the caller were modifying the dates, even though they shouldn't be. I'm going to be converting CertificateInfo to use java.time in the very near future, but if you feel passionate about these defensive date copies, feel free to submit a new PR with them.
Regarding the X509 array clone, TrustSource is intentionally not returning a clone. That array can be rather large, and Netty uses that array when creating an SSL context, which happens a lot. Callers should not modify the array, and some documentation to that effect would be reasonable, but in practice I think it's quite unlikely to occur. Besides, even returning a clone doesn't prevent the caller from modifying the underlying X509 objects.
Thanks again! Good PR.


TODO: verbosity vs debug changes

provision

smallcaps
run command: indent

verbose

box ++
vagrantfile --
Trying to enable: QEMU user session --

debug
prepare

run command: indent

verbose

how: ??
action: ?? # adding playbook etc

debug

Adding into Vagrantfile -> yellow

Most of the provision and prepare output inconsistencies covered by #218.

Not for Vagrant, but as this was just a note for me, I'm fine with keeping it closed (I'll get back to this when converting the plugin).


LIIKUNTA-158 | Show location selections in collections

Description
Issues
Closes
LIIKUNTA-158:
Related
Testing
Automated tests
Manual testing
Screenshots
Additional notes

Codecov Report

Merging #99 (102be8b) into main (15c83d0) will decrease coverage by 2.02%.
The diff coverage is 61.29%.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   71.45%   69.42%   -2.03%
==========================================
  Files          70      106      +36
  Lines        1219     1668     +449
  Branches      297      383      +86
==========================================
+ Hits          871     1158     +287
- Misses        347      509     +162
  Partials        1        1

Impacted Files
Coverage Δ

src/common/components/card/CollectionCard.tsx
0.00% <ø> (ø)

src/common/components/card/CondensedCard.tsx
0.00% <0.00%> (ø)

src/common/components/card/LargeCollectionCard.tsx
0.00% <ø> (ø)

src/domain/collections/collectionFragment.ts
100.00% <ø> (ø)

...llections/collectionsGrid/CollectionCountLabel.tsx
0.00% <0.00%> (ø)

src/domain/graphql/event/eventSchema.ts
100.00% <ø> (ø)

src/domain/graphql/services/TprekDataSource.ts
89.47% <ø> (ø)

src/domain/graphql/venue/venueSchema.ts
100.00% <ø> (ø)

src/common/components/card/Card.tsx
15.62% <10.00%> (+0.10%)
:arrow_up:

src/domain/graphql/createApolloServer.ts
66.66% <66.66%> (ø)

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15c83d0...102be8b. Read the comment docs.


Document how to use R.swift together with SPM

have used swift package manager for R.swift but i can't see any document for generating R.generated.swift using Swift package manager

We'll have to write a proper documentation in the Readme.
In short:

Use SPM to add https://github.com/mac-cain13/R.swift.Library to your project
Use rswift executable in some other way. It's currently not possible to use development dependencies in SPM (like devDependencies in NPM)

have used swift package manager for R.swift but i can't see any document for generating R.generated.swift using Swift package manager

There's a walkthrough setting up R.swift with SPM here :) https://blog.apptekstudios.com/2019/12/spm-xcode-build-tools/

Is it possible to use R.swift with resources inside SPM packages? This was added in Xcode 12.

@szotp yes, you can embed resources in your Swift Package and the R.generated.swift will work fine when adding the dependency R.swift.Library, that means someone, or yourself can use you packaged containing R.swift-referenced resources. (You might need a "ResourceBundle hack" so that it uses Bundle.module
However as @tomlokhorst said, Use swift executable in some other way. It means you'll have to run the "generate" command manually when adding new resources to your Swift package. Where in the past, your framework likely was maintained by an Xcodeproj with a Script Build phase.
Ideally what I would love to see for a Swift package opened in Xcode, is an Xcode extension running R.swift generate on your current target sources...
..and ideally, the same for SwiftLint ;)

Any update on this ? I would love to stop maintaining xcodeproj and only focus on Package.swift, however R.swift cannot generate R.generated.swift without an Xcodeproj file... !

@tomlokhorst I've worked on a branch that allows usage of R.swift to work on a given Swift Package & target name, without using Xcodeproj. It may not be perfect but it seems to do the job. I'm happy to work a bit more on it but would gladly accept your advice on what to Unit Test & which command-line arguments would be preferred.
See here https://github.com/quentinfasquel/R.swift/tree/feature/generate-swift-package-resources

I don't know if this can work like SwiftFormat. For example: https://github.com/nicklockwood/SwiftFormat#using -swift-package-manager
It does this by creating a BuildTools folder and working in it

have used swift package manager for R.swift but i can't see any document for generating R.generated.swift using Swift package manager

There's a walkthrough setting up R.swift with SPM here :) https://blog.apptekstudios.com/2019/12/spm-xcode-build-tools/

I refer to SwiftFormat and report an error when running build phases.
it report:
An error occurred: Missing value for `SDKROOT

my Package.swift :
// swift-tools-version:5.4
import PackageDescription

let package = Package(
    name: "BuildTools",
    platforms: [
        .macOS(.v10_11)
    ],
    dependencies: [
        .package(url: "https://github.com/mac-cain13/R.swift", from: "5.4.0"),
        .package(url: "https://github.com/nicklockwood/SwiftFormat", from: "0.48.10")
    ],
    targets: [
        .target(name: "BuildTools", path: "")
    ])

and my script :
# Type a script or drag a script file from your workspace to insert its path.
cd BuildTools
SDKROOT=(xcrun --sdk macosx --show-sdk-path)

#Temporarily uncomment the following line to update your packages (based on the versions defined in BuildTools/Package.swift)
#swift package update

#Run your build tool - using swiftformat as an example
swift run -c release rswift generate "$SRCROOT/generated/R.generated.swift"

I guess R.swift not yet support SPM with resources bundle?


Absolute co-ordinates don't seem to work for teleporting

Teleporting to absolute co-ordinates does not seem to work using Makecode for Minecraft Education v1.0.28. For instance, the following command does not have any effect:
player.onChat("tp", function () {
    player.teleport(positions.createWorld(0, 10, 0))
})

Note that both of the two examples below DO work:
// Explicit command
player.onChat("tp", function () {
    player.execute("/tp @s 0 10 0")
})

// Relative co-ordinates
player.onChat("tp", function () {
    player.teleport(positions.create(0, 10, 0))
})

The above is for the player, the same is also the case for teleporting the builder.

That's odd indeed; I'll investigate

Hmm, it appears related to the 0 in the world position. Using arbitrary numbers works fine:

Wow, coordinates 0 in world positions have never worked at all! Funny that we never caught that. Thanks for the feedback!
Issue is fixed and will be in our next release; for now the best thing to do is either use world positions without a 0 or use player.execute like you did above.

Thanks. When is next release?

On Jun 14, 2018, at 5:21 PM, Guillaume Jenkins<EMAIL_ADDRESS>wrote:
Closed #4460.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Later today!


Add Missing Sensors (Outdoor Temperature, flow in/out temperature)

Hello,
I updated from the 2023.03 version. I miss some sensors. Could you please add them. (The sensor circulation_pump_heating I found in the list of deactivated sensors, the others unfortunately not):

outdoor_temperature
outdoor_temperature_average
flow_out_temperature
flow_out_temperature_target
flow_in_temperature ("Vorlauf", I'm not sure about the sensor name

Thanks
Albert

Please ensure the latest beta integration if you use HA 2023.8 or higher.

I have selected yesterday the main branch. That should be the latest version, or?

home-assistant_2024-02-28T06-10-56.037Z.log
This is my log file. Does this give any hints?

@Albert994 Please try now the main branch.

@BenPru : Works with the fix. Thanks!


Assets mismatch after upgrade from 1.x

Describe the bug
After upgrade from 1.x to 2.1.0, the assets indicated to the client actually does not exist.
To Reproduce

Upgrade from 1.x: https://docs.postalserver.io/install/upgrade-to-v2
Access to postal from your browser

Expected behaviour
A clear and concise description of what you expected to happen.
Screenshots
Indicated assets:

Actual assets:

Environment details

OS: Ubuntu 16.04 (server)
Browser: Edge (new)
Version: 2.1.0
Type: laptop

Temporary fix
So, what I've done so far is to copy the assets to what is expected by the browser. Like this:

Finally, I get this on the web application.

When you're upgrading, you need to rewrite the nginx configuration. This is not currently documented but I would like to add a mention when I have some time to do so.
Have a look at https://github.com/postalserver/postal/issues/1668#issuecomment-954657653


Should we update our streamflow notebook to write directly to S3 or replaces with new NWM rechunking?

Notebook 1 of the streamflow evaluation workflow currently writes to a local file. Should we update it to write directly to S3?
I think notebook 1 will be replaced by my rechunking of the NWM data. Maybe we should modify notebook 2 to read from this new file once it is created.

@amsnyder , yes, great idea to write directly to s3.     I've modified this notebook to write a subset to s3://nhgf-develoment/workspace:
https://jupyter.qhub.esipfed.org/hub/user-redirect/lab/tree/shared/users/rsignell/repos/hytest-development/gallery/conus404_subset_to_zarr.ipynb

Success in writing in parallel direct to S3 in the OSN appliance.
The demo/tutorial for streamflow does just that (see the notebook at https://github.com/hytest-org/hytest/blob/main/model_evaluation/tutorials/nwm_streamflow/01_Data_Prep.ipynb)
I had some challenges in getting the cluster workers authenticated correctly to write to the OSN bucket. In the end it worked fine, so long as I did not trust ebdpy.py to do anything.  It snuck in extra environment variables which confused the botocore profile/credentials API.
--gt


Catch interactive call

Catch interactive call and fail if no url has been specified.
This change avoid the script waiting on stdin if you execute it with no arguments but still allow to use pipes like:
cat ./runck | ./runck -c <sha256sum> -- -h

Rebased from master and updated


Update icon on codebase

@Aniket965 can you update the latest logo on the codebase? We will then trigger a build for a beta release with new logo


option to disable autoconnect wallets

Hi,
I was trying to use the lido-js-sdk for wallet connection, I'm facing the issue when both metamask and coinbase wallet extensions are installed in the browser. Coinbase pops up on every reload.
Can we have an option of disabling autoconnect feature?
https://github.com/lidofinance/lido-js-sdk/blob/main/packages/web3-react/README.md#auto-connect
@alx-khramov @avsetsin

Hi, @ashish-pcode
It is possible, but are you sure? Without autoconnect a wallet will disconnect really often.
Maybe the issue can be fixed by some better way than disabling autoconnect?
For example, https://stake.lido.fi/ uses lido-js-sdk/web3-react, but I'm not able to reproduce your issue using our widget.
Not sure what is the reason for this issue. Coinbase and MetaMask wallets are trying to use the same window.ethereum object, but Coinbase overrides MetaMask. But they use different connectors: WalletLink for Coinbase against EIP-1193 (injected).
I checked the Coinbase docs, and it looks like our Coinbase-related code is a bit outdated. They changed how the wallet works along with other wallets, so the autoconnect feature stopped to work with Coinbase when the extension is installed with MetaMask.
I plan to update our code for Coinbase in the nearest future, so it can possibly fix the issue.

Thanks for the detailed explanation @alx-khramov
I have attached the screenshot on my https://stake.lido.fi/, this is when I don't have metamask or coinbase installed but not connected to the website.

@ashish-pcode Is this Coinbase Wallet window opens by itself or did you click "Connect wallet => Coinbase" buttons to open it? The behavior on the screenshot looks expected for me, what am I missing?

@alx-khramov it opens up by itself on every reload. Just refreshing the page opens up the pop.

@ashish-pcode okay, I see, thank you for reporting this. I will look how I can fix it.

@alx-khramov sounds good, feel free to close the issue.

@ashish-pcode Hi! This PR #67 probably fixes the issue.


Flame thrower fix

TEST PLAN
Go to staging 1 and equip the flamethrower in desktop. The animation should look realistic with avatar arm outstretched and flamethrower in hand pointing forward. Check that both hands have the correct animation and gun position.
https://highfidelity.fogbugz.com/f/cases/18880/Equipping-items-in-the-Spot-uses-wrong-positioning

@RebeccaStankus let me know when this is QA ready

We checked this in the spot, so when we get a code review on this, we could test again when you make as QA ready.

I have tested this and this is QA Approved.
In Desktop:
The animation should look realistic with avatar arm outstretched and flamethrower in hand pointing forward. - PASS
Check that both hands have the correct animation and gun position. - PASS


Creating site from existing directory breaks other site that uses same directory

Operating system:
MacOS
This is:

[x] a bug
[x] general feedback

I'm not sure if there's going to be reasonable solution to this problem but even preventing from creating such conflict would be better.

What version of Beaker?
This is would be some kind of issue with the sync algorithm. There's no reason that having multiple dats on the same local dir should cause them to do anything other than converge on the same content.


[SILGen] Recognize swift_newtype-ed CF foreign class types

What's in this pull request?

Teach isClangTypeMoreIndirectThanSubstType about swift_newtype-ed
typedefs, which may be of CF foreign class type. In these cases, we
should reason about the underlying, wrapped type. Includes
refactoring of common logic and tests.

Resolved bug number: (SR-)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

Teach isClangTypeMoreIndirectThanSubstType about swift_newtype-ed
typedefs, which may be of CF foreign class type. In these cases, we
should reason about the underlying, wrapped type. Includes
refactoring of common logic and tests.

@swift-ci please test

@jckarter please review

LGTM


Io register viewer #33

Engine A hasn't been finished yet (need to work with bits too)

Also, remove bin and obj folder. I will add some lines in .gitignore to ommit these directories.


[CI] Update GitHub Action to push docker images

Close #371

We don't need docker.yml, e2e-images.yml, init-e2e-images.yml anymore.>
All have in push-docker-images.yml
Update GitHub action logic
Change set-output command

Hi, Link result test here:
Workflow when push with tag v17.0.0: https://github.com/anhductn2001/juno/actions/runs/3522320778
Workflow when push with tag v16.0.1: https://github.com/anhductn2001/juno/actions/runs/3522289624
Result image in ghcr.io: https://github.com/anhductn2001?tab=packages


Update index.md

Code sample currently shows under The Index.cshtml file contains markup to create a delete button for each customer contact:
<a asp-page="./Edit"<EMAIL_ADDRESS>|
<button type="submit" asp-page-handler="delete"

see https://docs.microsoft.com/en-us/aspnet/core/razor-pages/?view=aspnetcore-6.0&tabs=visual-studio-mac#:~:text=The Index.cshtml file contains markup to create a delete button for each customer contact%3A
Updating it to push it one line, and expand it one line in order to show:
                        <button type="submit" asp-page-handler="delete"
<EMAIL_ADDRESS>                        </button>

which I suspect was the intention.

Thanks for your contribution, @lvalencia. Be sure to check What's New early next month, where you'll see yourself listed as a valued contributor.


bump optimize-js

@neophob don't need this change. https://docs.npmjs.com/misc/semver#caret-ranges-123-025-004


Split billing emails to separate mailbox

Describe the Issue
We have created a new billing mailbox in order to untangle the different kinds of emails we get as they are all mixed in together and giving several people access to the same mailbox we use for team and event calendaring leads to situations were events get reverted, overwritten or deleted.
Additional Context
Add any other context, attachments or screenshots
Acceptance Criteria

Set up the new mailbox in Outlook
Create the same invoicing folder structure as cloud.pathfinder
Make sure the PO, our Financial Admin (Shiho), and our Division Admin (Dana) all have access to the new mailbox (iStore tickets?)
With the PO, create rules to auto-filter the incoming invoices to the right folders.
With the PO, create rules to forward the incoming invoices to the appropriate Admin above.

Extra Template Info
Definition of Ready
These set of conditions will need to be met in order to bring a ticket into the sprint and start work. Protects the team from unclear requirements.
Issues (Task/Story/Spike) aligned to an EPIC and linked appropriately.
Assigned to the appropriate CPF MEMBER (and is not left blank in ZenHub) at the start of sprint (1st day of the sprint)
Acceptance has been defined for the issue and has been reviewed with CPF team and approved by the necessary approver.
Has been sized and estimated by the delivery team.
Detailed breakdown of the steps required to complete the story in the additional context
Any additional specifications have been documented, reviewed with CPF and approved by the necessary approver.
Acceptance Criteria
A set of pre-defined requirement that need to be met in order to mark the user story as “done”.
It should be testable with no room for interpretation
It should be either “pass” or “fail”
It should be clear enough for business stake holders to understand
As part of the user story, it should be written from the user perspective
A well written acceptance criteria is great for

managing expectations
defining scope
reducing ambiguity
establishing testing criteria for QA
Given (Pre-condition)
When (Action)
Then (Outcome)

Definition of Done
These set of conditions are met for work to be considered as complete on an issue.
All acceptance criteria(s) have been validated.
All the necessary documentation for the issue has been uploaded to Teams.
Functionality has been tested when applicable.
Functionality has been demonstrated to the relevant stakeholders (where applicable).
Story has been scheduled for a Sprint Demo/community update and impacted teams invited to the Demo.
Stories accepted by PO and documented for potential sharing with impacted users.

Documented = Captured in Community Update (CU) deck
Release notes = aspirational goal of providing a bulleted list of features and changes that our users can touch. Was going to store them in our Cloud Pathfinder repo. Can also display to users in the CU

GCP done

Done everything except SSC (will coord with others first)


xy_plot_tool_spec should test for link multiple dataset button

The xy_plot_tool_spec needs to look for the newly configured buttons when testing runs on example-config-subtabs unit

@bacalj , @bgoldowsky beat you to it on this one 😊 , he has this exact same fix in https://github.com/concord-consortium/collaborative-learning/pull/2125


remove Peter Uhe (pfu599) from accessdev administrator

resolution_fixed   |    by<EMAIL_ADDRESS>
Need to update puppet/hieradata/project.yaml
Are there any implication elsewhere?
(I am just trying out accessdev admin with Say and using this as a example item for consideration)

Issue migrated from trac:152 at 2024-01-31 18:08:53 +1100

<EMAIL_ADDRESS>changed status from new to closed

Scott Wales<EMAIL_ADDRESS>committed [4]

In [changeset:"4edd9c452bfe2ddb5e6b400a2791ecd702f682f9/puppet"]:
#CommitTicketReference repository="puppet" revision="4edd9c452bfe2ddb5e6b400a2791ecd702f682f9"
Remove Peter Uhe from admins

Thanks for your help Peter

Fixes #152

<EMAIL_ADDRESS>changed resolution from `` to fixed

<EMAIL_ADDRESS>commented

Fixed in 4edd9c4

Scott Wales<EMAIL_ADDRESS>changed owner from `` to Scott Wales<EMAIL_ADDRESS>


Powermock Configuration

A user(developer) should has a way to configure some feature which will be added so to PowerMock, such like:

make each test class loaded by separate class loader  (#609)
throw exception on mockStatic if the class wasn't prepared for test (#604)
throw exception on when(Class c) if class wasn't prepared for test  (#622)

And so on. I think, different configuration will be added.
Also we need decide how the user(developer) will be able configure PowerMock

via annotation for test class
via class in classpath which extends some interface
via class in classpath which is annotated

Level of configuration:

Project (global)
Test class
Test method

I think one should be a bit careful with too fine grained configuration. This will make the code base more difficult to maintain and eventually the API may become too difficult to use and there will be more support. For example right now I don't think that you should be able to configure if we should "throw exception on mockStatic if the class wasn't prepared for test". I believe that this is a choice that we should make (i.e. also throw exception) since this is probably what the user wants (when would you not want this?)
When it comes to issue 609 I agree. But this is somewhat already possible. You can define @PrepareForTest on the method level and then that method is loaded from a different classloader. But It would be nice if you could indicate it at the class level as well since today I don't think that @PrepareForTest at the class-level creates a new classloader (for performance reasons).
What do you think?

I agree that too fine grained configuration adds complexity to code and this code hardly support.
My pointed that we need at first implement feature that will give:

for developer as user change configuration/behaviour of PowerMock
for developer who develops PowerMock easy way to get configuration for current test at each place of code.

Then we could discuss what will be added into configuration. Also we need take into account such feature as #604, because it could brake test then a user should have a way to switch it off until it test will be fixed or it should disabled by default for first release.

Regarding #604, I'm still dubious regarding need for not having an exception to be thrown if the class not prepared for test? If the user want to switch the test of for some reason why not simply used @Ignore?


Corrupt dist/** files with bower package

The dist files are all empty , seems like bower package is corrrupt , kindly check ! thanks , nice package though !

I am not sure what you mean. I did a new installation via Bower and all the files are available. Could you clarify the issue please?


Proguard issue: Warning:there were 2 unresolved references to program class members.

I'm unable to build my app when I add card.io.  I'm using Android Studio 1.5.1, building on OSX, targeting SDK 22 (not yet 23 for Marshmallow), building separate APKs for Armeabi, Armeabi-v7a, x86.
Warning:io.card.payment.CardIOActivity: can't find referenced method 'int checkSelfPermission(java.lang.String)' in program class io.card.payment.CardIOActivity
Warning:io.card.payment.CardIOActivity: can't find referenced method 'void requestPermissions(java.lang.String[],int)' in program class io.card.payment.CardIOActivity

Warning:there were 2 unresolved references to program class members.
         Your input classes appear to be inconsistent.
         You may need to recompile the code.
         (http://proguard.sourceforge.net/manual/troubleshooting.html#unresolvedprogramclassmember)
Warning:Exception while processing task java.io.IOException: Please correct the above warnings first.
:app:transformClassesAndResourcesWithProguardForFreeArmeabiRelease FAILED
Error:Execution failed for task ':app:transformClassesAndResourcesWithProguardForFreeArmeabiRelease'.
> java.io.IOException: Please correct the above warnings first.

Here is my proguard file
# Add project specific ProGuard rules here.
# For more details, see http://developer.android.com/guide/developing/tools/proguard.html

# Uncomment these when DEBUGGING
#-dontobfuscate
#-optimizations !desc/simplification/arithmetic,!field/*,!class/merging/*,!desc/allocation/variable

# For Crashlytics to work around their bug where they don't deobfuscate exceptions
-keep public class * extends java.lang.Exception

# iText/droidText/PDF stuff
-keep class com.lowagie.text.** { *; }
# iTextAsian
-keep class com.itextpdf.** { *; }

# Fix for Samsung Galaxy Lite 4.2.2 bug: https://desc.google.com/p/android/issues/detail?id=78377
-keep class android.support.v7.widget.** { *; }
-keep interface android.support.v7.widget.** { *; }

# Restoring a stack trace with line numbers
# -renamesourcefileattribute ProGuard (adb: turned this off to improve Fabric issue where "Proguard" shows up)
-keepattributes SourceFile,LineNumberTable

# For PlugPDF and its dependencies
-keep class com.epapyrus.plugpdf.core.** { *; }
-dontwarn fi.harism.**

# For Parse
-dontwarn com.facebook.**
-keepattributes *Annotation*
-keepattributes Signature
-dontwarn com.squareup.**
-dontwarn okio.**

# For OpenCSV
-dontwarn com.opencsv.**

# Universal image loader
-keep class com.nostra13.** { *; }
-keepclassmembers class com.nostra13.** { *; }

# Keep field names for our DAO objects so we can serialize up to Parse.com nicely
-keepclassmembers class com.aadhk.woinvoice.bean.** { private <fields>; }

# Fix cause I ripped out org.bouncycastle from DroidText.jar and com.lowagie.text.pdf.fonts.cmaps
-dontwarn com.lowagie.text.pdf.fonts.cmaps.**
-dontwarn repack.org.**

# Card.io
-keep class io.card.**
-keepclassmembers class io.card.** { *; }

I added this line to solve the problem:
-dontwarn io.card.**

Cool


Add e2e tests setup

https://wix.github.io/Detox/docs/introduction/project-setup.

blocked by https://github.com/wix/Detox/issues/3970.


Incremental timings included with PhaseResults

We'd like to time how long we spend computing each PhaseResult.
When PhaseResults print in the REPL, we'd print the timing of each phase along with the RenderTree. If we're not in debug mode, we'd print the sum of the times of each phase (not just the time of the last phase).
(Note to self: does anything of value happen not during a PhaseResult?)
This will greatly aid in debugging performance issues in queries as we'll know which phases are the culprits just by running the query in the REPL.

“does anything of value happen not during a PhaseResult?” – Yes. The actual query evaluation. Currently the REPL prints out how long the query took and I’m not sure whether that includes all the compilation time or not. Also not sure if it includes the time to read the results. Ideally, we should have a time for when we first get a cursor back (in Mongo, this can actually take a while, I think, because we sometimes need to make multiple sequential requests, and we don’t get a cursor until the final request is made after the others have actually completed), and a time when we first get results back.


RC Test: gravity-and-orbits/1.5.0-rc.1, to test phet-io infrastructure changes

Placeholder for upcoming RC test now that dev lite is complete in https://github.com/phetsims/QA/issues/654.
UPDATE:

@arouinfar @kathy-phet @KatieWoe, gravity-and-orbits/1.5.0-rc.1 is ready for RC testing. This is the first RC for the
"upgradeable" batch of PhET-iO sims. Document issues in https://github.com/phetsims/gravity-and-orbits/issues/ and
link to this issue.
Dev-lite testing completed in https://github.com/phetsims/QA/issues/660
Assigning to @kathy-phet and @KatieWoe for prioritization.

General RC Test

What to Test

Click every single button.
Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.

If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Test all query parameters on all platforms. (See QA Book
for a list of query parameters.)
Download HTML on Chrome and iOS.
Make sure the iFrame version of the simulation is working as intended on all platforms.
Make sure the XHTML version of the simulation is working as intended on all platforms.
Complete the test matrix.
Don't forget to make sure the sim works with Legends of Learning.
Test the Game Up harness on at least one platform.
Check this LoL
spreadsheet and notify AR or AM if it not there.
If this is rc.1 please do a memory test.
When making an issue, check to see if it was in a previously published version
Try to include version numbers for browsers
If there is a console available, check for errors and include them in the Problem Description.
As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if
there is a problem.

Focus and Special Instructions
The PhET brand simulation is hopefully not too different from the last PhET brand publication.  Most of the known changes were in PhET-iO.

Link(s)

Simulation
iFrame
XHTML
Test Matrix

PhET-iO RC Test

What to Test

Make sure that public files do not have password protection. Use a private browser for this.
Make sure that private files do have password protection. Use a private browser for this.
Make sure standalone sim is working properly.
Make sure the wrapper index is working properly.
Make sure each wrapper is working properly.
Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
sure the simulation loads without crashing or throwing errors.
For an update or maintenance release please check the backwards compatibility of the playback wrapper.
Here's the link to the previous wrapper.
Load the login wrapper just to make sure it works. Do so by adding this link from the sim deployed root:/wrappers/login/?wrapper=record&validationRule=validateDigits&&numberOfDigits=5&promptText=ENTER_A_5_DIGIT_NUMBER

Further instructions in QA Book
Conduct a recording test to Metacog, further instructions in the QA Book. Do this for iPadOS + Safari and one other random platform.
Conduct a memory test on the stand alone sim wrapper (rc.1).
Test one platform combination with ?phetioDebug on the Studio and State wrapper.
If Pan/Zoom is supported, make sure that it works when set with PhET-iO State.
If filled in by issue creator, please test the diff wrapper against https://phet-io.colorado.edu/sims/gravity-and-orbits/1.4/
Test that the sim works offline:

Go to https://phet-dev.colorado.edu/html/gravity-and-orbits/1.5.0-rc.1/phet-io/gravity-and-orbits-phet-io-1.5.0-rc.1.zip
download it
unzip it to a spot locally
Open index.html by double clicking it on your desktop or in a finder-view.
It should look like the standalone version of the sim in PhET-iO brand.

Focus and Special Instructions
This test is primarily to regression test recent changes to PhET-iO, particularly around studio and save/load and API files.

Additional checks

[x] Please use the diff wrapper to compare against prior version: https://phet-io.colorado.edu/sims/gravity-and-orbits/1.4/

Link(s)

Wrapper Index
Test Matrix

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

Please be aware of https://github.com/phetsims/phet-io-wrappers/issues/405#issuecomment-844208633 which may impact how the diff wrapper can be tested.

QA is done

I opened a milestone for tracking work that should be done for this release (in this branch with cherry picks).  Closing and will continue in https://github.com/phetsims/gravity-and-orbits/milestone/4.  I'll also create a new note to indicate upcoming testing for rc.2.

I opened a milestone for tracking work that should be done for this release (in this branch with cherry picks).  Closing and will continue in https://github.com/phetsims/gravity-and-orbits/milestone/4.  I'll also create a new note to indicate upcoming testing for rc.2.

Reopening.  There are still problems being found with this RC, like https://github.com/phetsims/joist/issues/725.

I created sim-specific issues for the 1.5 milestone for the new issues as appropriate.  Closing, but please let me know if further issues are discovered.


Update !update_status Keywords

game, listen and watch were poor choices.
Should just catch and use what the actual status messages are
!update_status watching TV
!update_status playing Elden Ring
!update_status listening to The Decemberists

@jp00p resolved this in #167


feat(remix-dev): Add loaders config for 3d models

Adds support for importing .glb, .gltf and .hdr files.
Closes: #4430
Testing Strategy:
I was able to import .glb and .hdr files and use them in google model viewer linked using its CDN.
import model from "../../public/mod/Hololens.glb";
import env from "../../public/mod/Neutral.hdr";
const Model = () => {
  return (
    <model-viewer
      style={{ height: "100vh", width: "100vw" }}
      src={model}
      shadow-intensity="1"
      camera-controls
      touch-action="pan-y pinch-zoom"
      environment-image={env}
      camera-orbit="calc(-0.25rad + env(window-scroll-y) * 12rad) calc(90deg + env(window-scroll-y) * 45deg) calc(10m - env(window-scroll-y) * 10m)"
    />
  );
};
export default Model;

@machour Have made the appropriate changes.

@machour Can you please review the code and approve it it is okay, as we need these loaders for our project.

@ikarus-akhil there seem to be a conflict with the changeset file, other than that looks good to me. 👌🏼
Someone from the Remix team will eventually attend this.
In the mean time, if you can't wait any longer, I suggest using https://www.npmjs.com/package/patch-package to apply these changes on your project.
You might also be interested in this proposal https://github.com/remix-run/remix/discussions/4549 that will turn into an RFC soon and hopefully make it to Remix.

@machour  I have resolved the conflict, can you please merge this code.

@machour Sorry for the delay and all the trouble, was having problem with the changeset but now I think it should be good.

Looks like this was shipped in 1.11, resolved in https://github.com/remix-run/remix/pull/5030. I'm going to close this but I'll add @ikarus-akhil to our contributors list since we dropped the ball on reviewing in a timely manner. Sorry about that!


net: tcp2: Verify that options are read correctly

Remove the static buffer for TCP options. Make sure that the
options were read properly to temp buffer.
Fixes: #25729
Coverity-CID: 210056
Signed-off-by: Jukka Rissanen<EMAIL_ADDRESS>

Reverted the last change as that was causing NULL pointer access in tests.


Substitution Value of ${workspaceFolder} Not As Expected

VSCode Version: 1.20.1
OS Version: Windows 10 Pro

See resolved issue from PHP Debug repo:
https://github.com/felixfbecker/vscode-php-debug/issues/240
The issue there was resolved, but it seems like it might be an issue with VSCode variable substitution.
Essentially I'm trying to get PHP Debug to work over docker, I have a launch.json file of:
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Listen for XDebug",
            "type": "php",
            "request": "launch",
            "pathMappings": {
                "/var/www/html": "${workspaceFolder}/htdocs"
            },
            "port": 9000,
            "log": true
        },
    ]
}

However, I expected ${workspaceFolder} to be my workspace root folder, something like:
c:/path/to/folder
That doesn't seem to be the case. When I define my VSLaunch code with absolute paths, everything works.
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Listen for XDebug",
            "type": "php",
            "request": "launch",
            "pathMappings": {
                "/var/www/html": "c:/path/to/folder/htdocs"
            },
            "port": 9000,
            "log": true
        },
    ]
}

Are there any way I can figure out the value of "${workspaceFolder}" to see what's its substituting with?

@oniisaki currently we do not have builtin support to show the value of ${workspaceFolder} and other variables.
What I suggest is to create a task which simply prints out the value of a ${workspaceFolder}.
Another alternative is to simply launch this javascript launch.json. Have a simple one line javascript file, and you will see in the the debug console something like (where the last part is the workspaceFolder resovled)
node --inspect-brk=30275 sdadsadsa/test.js /Users/isidor/Development/w/new
{
    "version": "0.2.0",
    "configurations": [
        {
            "type": "node",
            "request": "launch",
            "name": "Launch Program",
            "program": "${file}",
            "args": [
                "${workspaceFolder}"
            ]
        }
    ]
}

If you find that $workspaceFolder is not resolved as expected please give us more details so we can investigate. What is the expected value, what is the actual value and steps to reproduce

I'm also experiencing the same issue as @oniisaki after experiencing some issues with the felixfbecker xDebug extension. I followed the suggestions made by @isidorn and created as task to print out the values of ${workspaceFolder} as follows:
{
  "version": "2.0.0",
  "tasks": [
    {
      "label": "echo",
      "type": "shell",
      "command":
        "echo workspaceFolder: ${workspaceFolder} \n workspaceRoot: ${workspaceRoot}"
    }
  ]
}

I receive the following output when executed:
> Executing task in folder myproject.local: echo workspaceFolder: C:\Users\kevin\Development\___webroot\myproject.local; workspaceRoot: C:\Users\kevin\Development\___webroot\myproject.local;
  ...
  ...

I performed some further tests and found that the xDebug configuration is initialised, as per the following output from the xDebug extension
{ command: 'setBreakpoints',
  arguments:
   { source:
      { name: 'tests_controller.php',
        path: 'c:\\Users\\kevin\\Development\\___webroot\\myproject.local\\app\\controllers\\tests_controller.php' },
     lines: [ 43, 44, 45 ],
     breakpoints: [ { line: 43 }, { line: 44 }, { line: 45 } ],
     sourceModified: false },
  type: 'request',
  seq: 4 }

As you can see, it looks like the lowercase drive letter is referenced here. I went ahead and set this as a hard value in my launch.json xDebug configuration:
  ...
   "pathMappings": {
       "/var/www/myproject.local": "c:\\Users\\kevin\\Development\\___webroot\\myproject.local
    }

When executed, the code execution stopped on the correct breakpoints. I then changed the drive letter to an uppercase 'C', re-launched the debugger and this time the code execution was not stopped on my specified breakpoints.
I hope you find the above information helpful and let me know if you need anything else.

Seems like a duplicate of https://github.com/Microsoft/vscode/issues/43959
fyi @weinand @dantup


[WIP] Slow Deploys

RFC
https://app.clickup.com/14205595/v/dc/dhgmv-10741/dhgmv-9921
Motivation
The current deploy script has high concurrency, submitting many transactions at a time for a single chain. There are two challenges with this:

For lower-quality chains, there are often nonce-related errors thrown (despite using NonceManager) - the mempool / nodes for the chain often don't handle this gracefully
For lower-quality RPCs, the number of concurrent requests can often cause rate limiting

Solution
Add a boolean flag to the deploy script which introduces the option to reduce intra-chain concurrency.
If this flag is set to true, the transactions submitted for each chain will be submitted sequentially, while concurrency will be maintained where possible between chains.
Example: all transactions to Rinkeby will be awaited one-by-one. Transactions to Goerli can be executed at the same time as transactions to Rinkeby.

PR Checklist

[ ] Added Tests
[ ] Updated Documentation
[ ] Updated CHANGELOG.md for the appropriate package

TODO:

[ ] add boolean flag which switches between concurrent & slow deploys

Closing as stale


Team with no captain

Causes a NoMethodError in UserRequestsController#create when trying to join a team as there is no Team Captain to send the request email to.
To reproduce:
Create two accounts, PersonA and PersonB.
Have PersonA create a team.
Have PersonB join the team.
Have PersonA navigate to Edit Team page.
Have PersonB delete their account.
WITHOUT RELOADING have PersonA transfer captaincy to PersonB.
Team Captain is now null and will throw the error when anyone else requests to join the team.
Issue also occurs if PersonB leaves the team instead of deleting their account.

Fixed by #62


Added automaticTopologyRecovery to Fs2RabbitConfig

TopologyRecovery feature in amqp-client is sometimes strange. I prefer to have it disabled. This PR adds the needed configuration option to Fs2RabbitConfig.
This change is not backwards compatible in Fs2RabbitConfig constructor. It is not possible to add a default - only one apply method can have defaults defined. I could try to add some additional methods to keep compability.
Also, I fixed a small compilation error (unrelated).

This change is not backwards compatible in Fs2RabbitConfig constructor

This isn't a problem I'd say

P.S. Ignore the CI error, there is a PR to fix it and it isn't related to your changes


updating SDK version

I have updating the SDK & gradle version

Thanks for your contribution. I've already merged another pull request which bumps up the SDK version too.


typo alertIOS Docs

'All your data belongs to us.' instead of 'All your data are belong to us.'
no code was changed

Ah, this is just a silly reference to an old meme. I believe it's intentional.


⚠ Bofrost.at has degraded performance

In d58722b, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1181 ms

Resolved: Bofrost.at performance has improved in 28f4f1e.


3.x → 4.x Migration Guide

Converting a 3.x project to 4.0, some common patterns emerge. These should be captured in the Readme before the 4.0 release.

[x] glossary mapping old terms to new
[x] common use cases

Closed by https://github.com/Raizlabs/BonMot/pull/241


ingress: Set the default value for max_stream_timeout

For all routes in CiliumeEnvoyConfigs, set the timeout to 0s to disable the route upstream timeout. This timeout defaults to 15 seconds if not set and is not compatible with streaming responses.
Something changed in the 1.15 release that changed the behavior of envoy, making it so the default 15 second upstream timeout is now enforced, making streaming responses unusable. This is a breaking change in behavior that I'm not sure how to nail down. This PR maybe way off but its the simplest way I could find to enforce the disabling of this particular timeout.

Easy Way to Reproduce 15 Second Timeout
Here is a simple script to spin up a local kind cluster, install cilium and an app named httpbin to test with.
#!/bin/bash

cat << EOF > kind-cluster-config.toml
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
- role: control-plane
- role: worker
  extraPortMappings:
  - containerPort: 30000
    hostPort: 8080
networking:
  disableDefaultCNI: true
EOF

kind create cluster --config kind-cluster-config.toml
rm kind-cluster-config.toml

helm repo add cilium https://helm.cilium.io/
helm upgrade cilium cilium/cilium --version 1.15.2 --install \
   --namespace kube-system \
   --set image.pullPolicy=IfNotPresent \
   --set ipam.mode=kubernetes \
   --set ingressController.enabled=true \
   --set ingressController.service.type=NodePort \
   --set ingressController.service.insecureNodePort=30000 \
   --set ingressController.loadbalancerMode=shared

cat <<'EOF' | kubectl apply -f -
apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app: httpbin
  name: httpbin
spec:
  replicas: 1
  selector:
    matchLabels:
      app: httpbin
  template:
    metadata:
      labels:
        app: httpbin
    spec:
      containers:
      - env:
        - name: MAX_DURATION
          value: 300s
        image: mccutchen/go-httpbin
        name: go-httpbin
        ports:
        - containerPort: 8080
          name: http
          protocol: TCP
---
apiVersion: v1
kind: Service
metadata:
  labels:
    app: httpbin
  name: httpbin
spec:
  ports:
  - name: 8080-8080
    port: 8080
    protocol: TCP
    targetPort: 8080
  selector:
    app: httpbin
  type: ClusterIP
---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: httpbin
  namespace: default
spec:
  ingressClassName: cilium
  rules:
  - host: httpbin.test.com
    http:
      paths:
      - backend:
          service:
            name: httpbin
            port:
              number: 8080
        path: /
        pathType: Prefix
EOF

When the resources are healthy run curls against the httpbin app causing the app to take more than 15 seconds to respond or finish a streaming response.
# make the http response take 20 seconds sending 20 bytes, returning headers immediately
curl -v -H 'Host:httpbin.test.com' 'http://localhost:8080/drip?duration=20&numbytes=20&&delay=0'
# returns a 200 but then the tcp connection is terminated before the response is completed

# make the http response take 40 seconds sending 20 bytes, not sending headers for 20 seconds
curl -v -H 'Host:httpbin.test.com' 'http://localhost:8080/drip?duration=20&numbytes=20&&delay=20'
# returns a 408

Redeploy the helm chart with a 14 release and the responses are completed (no 15s timeout)

This is a blocker for our usage of cilium so if this code change is in the wrong direction please let me know. I'd be happy to put more effort into a different solution if some guidance is provided. Thanks

This seems like the right approach to take to me - although I'm not sure how we actually allow setting these timeouts atm off the top of my head. @sayboras, @mhofstetter, any thoughts?

IMO ingress annotation to control this is better, as we can increase the timeout just for service who need it while keeping the default configurable via operator flag.

@mhofstetter
what about handling that in ingestion.Ingress, and add support for default flag and annotations?

Thank so much for the feedback and direction.To clarify, the http-request-timeout currently only works for GatewayAPI?
I @a5r0n like your idea are you interesting in implementing it if that direction is approved?

I'll do my best.. I'm not very familiar with the codebase but I think it's pretty straightforward

@mhofstetter I've update the PR to reflect what I believe you meant by the quick fix.
I might be able help out with a more configurable solution whether that is annotation based and/or a global default argument that you pointed to above.

+1 on setting an Ingress-specific stream timeout instead.

I appreciate you looking deeper into this! I'm glad to see the source of the change has been found. Feel free to circumvent this PR as I don't want to slow things down. I wanted to get some eyes on the issue and that has been accomplished.

It looks like Envoy decides to use the newer per-try-timeout over the global-timeout if max_stream_duration is configured on the route itself. If not set (that's what we changed from 1.14 -> 1.15) - it falls back to the global timeout.

https://github.com/envoyproxy/envoy/blob/885768f7bfb4608698040a182232e20fd022de2b/source/common/router/router.cc#L168-L192
https://github.com/envoyproxy/envoy/blob/main/source/common/router/config_impl.cc#L545

This results in the upstream timeout.
[2024-04-04 11:35:21.826][23][debug][router] [external/envoy/source/common/router/router.cc:1070] [Tags: "ConnectionId":"22","StreamId":"14209269293983868039"] upstream timeout

Even though the documentation mentions that max_stream_duration on the route only overrides the default max_stream_duration on the corresponding HttpConnectionManager (that we also (and still) set to 0s). Kind of confusing.

The route MaxStreamDuration proto can be used to override the HttpConnectionManager’s max_stream_duration for individual routes as well as setting both limits and a fixed time offset on grpc-timeout headers.

https://www.envoyproxy.io/docs/envoy/latest/faq/configuration/timeouts#route-timeouts
@tskinn as mentioned in the inline comment - we should be good to go if we set the max_stream_duration on the route back to 0s if neither backend-timeout or request-timeout are set in the internal model (e.g. set by Gateway API timeout config)  - instead of the timeout itself (even though it might not make that much of a difference - but at least it would align to what we have in 1.14 and what we set on the Envoy HCM).

@mhofstetter Thanks! Updated.

/test

@tskinn looks like some tests need to be adapted accordingly
https://github.com/cilium/cilium/actions/runs/8785249230/job/24105313102
│  FAIL   │  0.23s  │ github.com/cilium/cilium/operator/pkg/model/translation                                                        │  2.2%  │  75  │  9   │  0    │
│  FAIL   │  0.26s  │ github.com/cilium/cilium/operator/pkg/model/translation/gateway-api                                            │  1.2%  │  4   │  29  │  0    │
│  FAIL   │  0.32s  │ github.com/cilium/cilium/operator/pkg/model/translation/ingress                                                │  1.2%  │  5   │  7   │  0    │

/test

@tskinn seems like there's an issue do the the branch being outdated.
contrib/scripts/builder.sh make build -j 4: 1: contrib/scripts/builder.sh: not found in the commit check due to a different PR being merged in the meantime.
Could you please rebase the PR to main. Thanks and sorry for the circumstances

/test

/test


Add abstraction layer

I think a direct interface layer for delegation overview will improve the usage of DICCS. It's easier to use, and it's faster to use, so many more people out there will use DICCS.

Direct Interface Layer for Delegation Overview System will never replace DICCS, never


Install and setup-project issue

Hi,
The npm install command seemed to to run eternally, I stopped it with Ctrl+C. The setup-project command failed, it does not know "import" instruction... What must I do ? I'm rather a PHP developper ... ^^'
`(master) $ npm install
npm WARN deprecated<EMAIL_ADDRESS>gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
npm WARN deprecated<EMAIL_ADDRESS>🙌  Thanks for using Babel: we recommend using babel-preset-env now: please read babeljs.io/env to update!
npm WARN deprecated<EMAIL_ADDRESS>please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
npm WARN deprecated<EMAIL_ADDRESS>ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130
npm WARN deprecated<EMAIL_ADDRESS>Use uuid module instead
npm WARN optional dep failed, continuing<EMAIL_ADDRESS>npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated<EMAIL_ADDRESS>to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN optional dep failed, continuing<EMAIL_ADDRESS>npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js

<EMAIL_ADDRESS>install /home/ubuntu/workspace/JS/SyntaxHighlighter/node_modules/codecov/node_modules/execSync
node install.js

[execsync v1.0.2] Attempting to compile native extensions.
[execSync v1.0.2]
Native code compile failed!!
npm WARN optional dep failed, continuing<EMAIL_ADDRESS>/
^C
olimeunier:~/workspace/JS/SyntaxHighlighter (master) $ npm update
olimeunier:~/workspace/JS/SyntaxHighlighter (master) $ ./node_modules/gulp/bin/gulp.js setup-project
[07:44:32] Failed to load external module @babel/register
[07:44:32] Failed to load external module babel-register
[07:44:32] Failed to load external module babel-core/register
[07:44:32] Failed to load external module babel/register
/home/ubuntu/workspace/JS/SyntaxHighlighter/gulpfile.babel.js:1
(function (exports, require, module, __filename, __dirname) { import gulpHelp from 'gulp-help';
^^^^^^
SyntaxError: Unexpected reserved word
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:373:25)
at Object.Module._extensions..js (module.js:416:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Module.require (module.js:353:17)
at require (internal/module.js:12:17)
at Liftoff.handleArguments (/home/ubuntu/workspace/JS/SyntaxHighlighter/node_modules/gulp/bin/gulp.js:116:3)
at Liftoff.execute (/home/ubuntu/workspace/JS/SyntaxHighlighter/node_modules/gulp/node_modules/liftoff/index.js:203:12)
at module.exports (/home/ubuntu/workspace/JS/SyntaxHighlighter/node_modules/gulp/node_modules/liftoff/node_modules/flagged-respawn/index.js:51:3)`

That's ok, sorry, after retrying.

THe setup-project command still says an error :
$ ./node_modules/gulp/bin/gulp.js setup-project
[08:49:22] Failed to load external module @babel/register
[08:49:22] Requiring external module babel-register
[08:49:28] Using gulpfile ~/workspace/JS/SyntaxHighlighter/gulpfile.babel.js
[08:49:28] Starting 'setup-project:clone-repos'...
[08:49:28] 'setup-project:clone-repos' errored after 1.87 ms
[08:49:28] TypeError: loadReposFromCache(...).error is not a function
at loadRepos (/home/ubuntu/workspace/JS/SyntaxHighlighter/build/setup-project.js:39:48)
at Gulp. (/home/ubuntu/workspace/JS/SyntaxHighlighter/build/setup-project.js:48:5)
at module.exports (/home/ubuntu/workspace/JS/SyntaxHighlighter/node_modules/gulp/node_modules/orchestrator/lib/runTask.js:34:7)
at Gulp.Orchestrator._runTask (/home/ubuntu/workspace/JS/SyntaxHighlighter/node_modules/gulp/node_modules/orchestrator/index.js:273:3)
at Gulp.Orchestrator._runStep (/home/ubuntu/workspace/JS/SyntaxHighlighter/node_modules/gulp/node_modules/orchestrator/index.js:214:10)
at Gulp.Orchestrator.start (/home/ubuntu/workspace/JS/SyntaxHighlighter/node_modules/gulp/node_modules/orchestrator/index.js:134:8)
at /home/ubuntu/workspace/JS/SyntaxHighlighter/node_modules/gulp/bin/gulp.js:129:20
at nextTickCallbackWith0Args (node.js:420:9)
at process._tickCallback (node.js:349:13)
at Function.Module.runMain (module.js:443:11)

duplicated #428


EasyPermissions.hasPermissions  is not correct ，can you help me

Basic Information
Device type: Red mi note4x
OS version: 7.0
EasyPermissions version: 2.0.0
Describe the problem
why the result of EasyPermissions.hasPermissions not the same PermissionChecker.checkPermission()
What happened?  What did you expect to happen?
i use EasyPermissions to require Camera permissions bug Denied by the MIUI not the system
in system setting show that ,i have the camera permissions
however i use EasyPermissions.hasPermissions  the result is wrong
I use PermissionChecker.checkPermission()  ,the result is right
Code and logs
 String permissionCamera = Manifest.permission.CAMERA;
        String permissionAudio = Manifest.permission.RECORD_AUDIO;

        if (PermissionChecker.checkSelfPermission(mContext, permissionCamera) != PackageManager.PERMISSION_GRANTED ||
                PermissionChecker.checkSelfPermission(mContext, permissionAudio) != PackageManager.PERMISSION_GRANTED) {
            if (!ActivityCompat.shouldShowRequestPermissionRationale((Activity) mContext, Manifest.permission.CAMERA)) {
                Toast.makeText(mContext, R.string.permission_tips, Toast.LENGTH_LONG).show();
            } else {
                String[] permissions = new String[]{Manifest.permission.CAMERA, Manifest.permission.RECORD_AUDIO};
                ActivityCompat.requestPermissions((Activity) mContext, permissions, PERMISSION_CAMERA_CODE);
            }
        } else {
            startCameraActivity();
        }

------------------------------------ i am  a line --------------------------------------
 if (EasyPermissions.somePermissionDenied(mActivity, CAMERA_AND_AUDIO_PERM)) {
            if (mActivity != null) {
                new AppSettingsDialog
                        .Builder(mActivity)
                        .setTitle(R.string.rationale_title)
                        .setNegativeButton(R.string.rationale_negative)
                        .setPositiveButton(R.string.rationale_positive)
                        .setRationale(R.string.rationale_camera_content)
                        .build()
                        .show();
            }
        } else {
            if (EasyPermissions.hasPermissions(mActivity, CAMERA_AND_AUDIO_PERM)) {
                startCameraActivity();
            } else {
                EasyPermissions.requestPermissions(mActivity, PERMISSION_CAMERA_CODE, CAMERA_AND_AUDIO_PERM);

            }
        }

@martin-huang could you show the problem with a slightly simpler example?  Also what happens if you use ContextCompat directly?

No response for 28 days, so closing this issue as not reproducible.


Conflicting requestCode

It seems that react-native-braintree-xplat and react-native-image-picker are using the same requestCode in android, this causes the error below:

09-21 20:40:59.763  1906  1906 E AndroidRuntime: java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=1, result=-1, data=Intent {  }} to activity {com.gostudentmobile/com.gostudentmobile.MainActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String com.braintreepayments.api.models.PaymentMethodNonce.getNonce()' on a null object reference

Would be nice if either of you used more unique numbers, so they wouldn't conflict. Is it possible to change it?
Conflicting lines:
https://github.com/marcshilling/react-native-image-picker/blob/master/android/src/main/java/com/imagepicker/ImagePickerModule.java#L61
https://github.com/kraffslol/react-native-braintree-xplat/blob/master/android/src/main/java/com/pw/droplet/braintree/Braintree.java#L23
Thanks!
Cross issue: https://github.com/marcshilling/react-native-image-picker/issues/327

Hi!
I'll look into fixing it today.

From react-native-image-picker:
In react-native-braintree-xplat they have to check if there callback isn't null before continuing.
After all the process they just need to set callback = null
It's for me the most simple way to check if the result don't came from an other package :)

Fixed by @kylejones in #19


Add topic visibility button/indicator to Inbox view

Like Recent conversations, the Inbox view should show have a button/indicator to control topic visibility.

This was completed in 3131d21703528d5cdaf75d3fbadd1575a8b18962.


Shared transitions

This isn't my library but I think it should be on the list.
https://github.com/GiampaoloGabba/Xamarin.Plugin.SharedTransitions

:)

Added


Chat with History

Continue on #832 but merge with the newer release of gpt-researcher. I think the plan for this branch would be to allow user to chat with the report. When we have a vector_store, we can chat with the crawl data too.

Tested and works great


app stops working when google icon logo is clicked

Expected behavior
I should be able to add cluster from my google account
Actual behavior
I was unable to add cluster from my gmail account  each time I try to ,the app stops working it force closes
How to reproduce
*Download
*Install
*Launch
*Click on add cluster
*Finally ,if you have a google account on your phone it will automatically want to use any of the google accounts you have ,so just click on the gmail app Logo
and wait for the error..
*Cabin 0.5.0
*Android 7.0 nougat
Recording of the bug
https://youtu.be/joZ2NcztWE4
Posted on Utopian.io -  Rewarding Open Source Contributors

Not related to this project


[Storage] Idempotent commits to allow failures in StateSync

We had a series of discussions related to the attacks, in which state synchronization is exploited in a way that an honest node is stuck and not be able to finish its state synchronization.
We realized that it would be very nice if Storage would allow us commit the same transactions more than once.
Consider a case with LedgerInfo and accumulator at version 10. StateSynchronizer starts retrieving the chunks up to version 50 with LedgerInfo of version 100, and then fails.
At that moment storage carries a LedgerInfo of version 10 and accumulator with transactions up to version 50.
We'd like to allow consensus to try to commit the "very same" transactions via the regular consensus protocol flow starting from version 10. For example, it could commit transactions with the new LedgerInfo of 70. In this case storage would know how to handle the fact that transactions 11-50 are already present and would apply transactions 51-70 only.

In this case storage would know how to handle the fact that transactions 11-50 are already present and would apply transactions 51-70 only.

Basically storage would ignore txns 11-50 and tries to commit 51-70. If txns 11-50 from consensus are not consistent with what storage has, the commit will fail.

Consider a case with LedgerInfo and accumulator at version 10. StateSynchronizer starts retrieving the chunks up to version 50 with LedgerInfo of version 100, and then fails.
At that moment storage carries a LedgerInfo of version 10 and accumulator with transactions up to version 50.
We'd like to allow consensus to try to commit the "very same" transactions via the regular consensus protocol flow starting from version 10. For example, it could commit transactions with the new LedgerInfo of 70. In this case storage would know how to handle the fact that transactions 11-50 are already present and would apply transactions 51-70 only.

Quick question as I was trying to understand the attack: do we save the LI at version 100 (i.e. before state synchronizer starts saving tx 11-50). A LI at 100 implies that at least f+1 honest nodes have transactions up to 100 (they may need to be given the 100 LI to commit them -- but this is true without a restart)
Stated differently -- if you save the highest LI you've seen restarting puts you in the same position you were in before, so it seems to avoid a need for a different code path.

close as #1627 was merged.


fix(s2n-quic-transport): make small Ack + Padding packets not congestion controlled

Description of changes:
Currently, it is almost impossible for s2n-quic to construct a packet that is not congestion controlled, despite this statement from the RFC:

Packets only containing ACK frames do not count toward bytes_in_flight to ensure congestion control does not impede congestion feedback.

This is because we enforce a minimum indistinguishable packet len that ends up being 53 bytes. Since an Ack frame is often less than 53 bytes, we add padding, which then makes the whole packet count against congestion control:

PADDING frames cause packets to contribute toward bytes in flight without directly causing an acknowledgment to be sent.

The result is that we seem to almost always have at least 53 bytes in flight (due to the ack delay timer), even during application idle periods. This has consequence for BBR in that it prevents BBR from performing some specific actions it is supposed to take when resuming from idle, since it specifically checks for bytes_in_flight == 0.
This change makes it so that packets that were not congestion-controlled prior to adding a small amount of padding, continue to be not congestion-controlled after padding.
Testing:
Local testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thinking about this more I wonder if we should make padding frames non-congestion controlled.

Thinking about this more I wonder if we should make padding frames non-congestion-controlled. We will never send a packet with just padding. The congestion-controlled property is binary, so any packet with padding should inherit the status of the other frames in it.

I considered that, though it felt a bit more directly opposite the requirement from the RFC. I think the only case it would make a difference would be when we're sending Initial packets and padding them to 1200, if we wanted to send an ACK-only initial, that would be 1200 bytes that wouldn't count against congestion control. We can do it though, as its definitely a little cleaner, just not sure if that case matters much