Request Enumerables Solution Review

Advanced Enumerables Solution.
We built some of ruby's own enumerables like:
my_each
my_each_with_index
my_select
my_all?
e. t. c...

Hello Dear, I am not sure to understand that you are not able to see our enumerable file because after checking I saw that the file actually exists

Hello Dear, I am not sure to understand that you are not able to see our enumerable file because after checking I saw that the file actually exists

Hello Dear, I am not sure to understand that you are not able to see our enumerable file because after checking I saw that the file actually exists

Hello @pacyL2K19 Thank you for reaching out for clarifictaion, actually the problem is not the file, the file is there and I saw aal of your enumerables, the problem is that the Pull Request you submitted doesn't have commits in which you worked on those enumerables, so kindly make sure that whenever you submit a code review request, make sure that PR you submit contains the commits in which you have worked on the project you are submitting, otherwise you would be violating git/github flow

Hello Dear, I am not sure to understand that you are not able to see our enumerable file because after checking I saw that the file actually exists

Hello @pacyL2K19 Thank you for reaching out for clarifictaion, actually the problem is not the file, the file is there and I saw aal of your enumerables, the problem is that the Pull Request you submitted doesn't have commits in which you worked on those enumerables, so kindly make sure that whenever you submit a code review request, make sure that PR you submit contains the commits in which you have worked on the project you are submitting, otherwise you would be violating git/github flow


Depth of a subset of paths

A minor complication is possible in depth: instead of querying the depths of nodes where a crossing by any path counts, we now accept a list of paths that should be included in this depth calculation. This PR beefs up slow-odgi's implementation of depth in exactly this way.

The docs explain the flag nicely. We are doing -s here, but I don't follow how that differs from -R.


Feature Request: Custom Amount of Quotes in a Book

An interesting addition to this mod would be the possibility to change the amount of qoutes, which are written in one book.
For example change the command from:
.kanye
to:
.kanye x
Where x is some number between 1 and a maximum amount of quotes (e.g. 50). In addition, error handling must be performed to resolve invalid inputs.

Feature is implemented in version 1.1


Functions with fewer arguments should be accepted as a param/field for functions with more arguments

How are you using the lua-language-server?
NeoVim
Which OS are you using?
Linux
What is the issue affecting?
Type Checking
Expected Behaviour
--- @param f fun(a: number)
local function test(f)
  f(42)
end

this should work
test(function() end)

Actual Behaviour
this doesn't work: This function requires 1 argument(s) but instead it is receiving 0.
test(function() end)

this works, even though they are equivalent
test(function(_) end)

Reproduction steps
--- @param f fun(a: number)
local function test(f)
  f(42)
end

test(function() end)

Additional Notes
The same should apply to @field and maybe @type as well
Log File
No response

Hello 👋
Change your annotation to the following and your issue should be resolved:
--- @param f fun(a?: number)
local function test(f)
  f(42)
end

I added a ? after the a param. This tells the server that it is optional.

test(function() end)
this works, even though they are equivalent
test(function(_) end)

These two are not equivalent. The first one is passing nothing, the second one is passing a "throwaway variable" which is not nothing, but has no real meaning when it comes to the execution of the code.

I added a ? after the a param. This tells the server that it is optional.

This will cause user to check nil when using this parameter.


fix HMR

We have to add the patch of react-hot-loader after our one, otherwise HMR doesn't work at all :(

HMR not working at all in mater and in current stable tag (1.2.3)
Win 7, latest node


Don't compile commands if disabled

Rather than wrapping whole files in "ifndef OPENSSL_NO_xxx" we handle
the changes in build.info
Spurred by @mattcaswell's comment at https://github.com/openssl/openssl/pull/11142#discussion_r387906007 and because I'm waiting for some PR's to be merged and reviewed.
I will do another PR to fix the libs and remote that macro completely.

I will probably do another commit, and it is likely that the macro will have to remain (cf crypto/ebcdic.c)

Build failure is YATT
(yet another travis timeout)

needs a rebase.

rebased.  the only change was apps/rsa.c removing pre-processor indents to fix the merge conflict.

This issue is in a state where it requires action by @openssl/committers but the last update was 30 days ago

Given the age, a rebase and rerun of the CI is probably in order.

This sat here for a month.  And now I am being asked to rebase/wait because nobody else on the project had time or interest to review this.  GitHub claims there are no conflicts.  I'm not going to do it.  The project needs to understand the costs to the community of letting things just sit.  So, no.

Sorry Rich I am with you.
Just give me a few minutes for a nap.

do not rebase.
I will do that locally and send a [WIP] for that.
I dont like any re-base after an approval FWIW

I'll approve if #11506 succeeds. How about that?

Given that master never succeed, I'll approve if it does not get worse.
Is that also an 1.1.1 issue?

I'll approve if #11506 succeeds. How about that?

It already has two approvals, so perhaps you -1 if it doesn't succeed.  Or feel free to take this over, or just let it drop.  (There are many PR's that are far older than this one, and way more important. The project team should also be looking at those.)

there was a force-push after Richards approval, how am I going to know?
Anyway, I will approve and this time it will count.

Relax, one thing is for sure, I will never let you drop.

Is that also an 1.1.1 issue?

In most cases, the project hasn't considered "code cleanup" to valid for backporting.
Yes, @levitte needs to reconfirm.  Or someone else needs to approve.  When I force-pushed I explained what changed in https://github.com/openssl/openssl/pull/11250#issuecomment-596542020 but yes, I could be mistaken or deceitful.

No I need to approve, pauli did already approve that is 1+1=2

Please do not force push.  I can handle that. relax.

merged to master               1ae56f2
Thanks!

do we need this in 1.1.1 too?

Request a review from me when you do that, I might miss this otherwise.

Thanks @bernd-edlinger .  This is code clean-up which has usually not been seen as a bugfix, so no backport IMO.

Maybe I disagree.

I see no code cleanup in 3.0 at all.

So what's the point in not trying to keep 1.1.1 maintainable since it is LTS ?

So what's the point in not trying to keep 1.1.1 maintainable since it is LTS ?

That's not for me to say, it's up to the project to decide if they want this for 1.1.1 (and find someone to do it, I suppose).


Remove feature flags for stable features

Given that clippy detects the use of stabilized features, this is unnecessary.


Return "None" for unseen values in categorical dicts.

What
This is a breaking change updating how categorical dicts are used.
Version updates to 0.3.0.

You now MUST pass a list of categorical columns expected to be
covered by the categorical dicts.
Any "unseen" values will return None by default. Setting a default_unseen value is also supported.

Why

This is more in line with how categorically transformed columns are used in practice
eg. LightGBM

Agreed. Should split into separate cases in future.


config for not asking a billing address?

Is there a config for not asking a billing address? If we do not send anything as mail just email why do we as a billing address?
Thanks!

Heya, sorry, this is only documented in the changelog atm: https://github.com/stripe/stripe-firebase-extensions/blob/next/firestore-stripe-subscriptions/CHANGELOG.md#version-018---2020-11-19
[feat] - The extension now defaults to collecting the customer's billing address during checkout and sets it as the address on the Stripe customer object. If you don't want to collect it, you can pass billing_address_collection: auto to the checkout session doc creation.


Error correction

I think error correction should be later in the pipeline e.g after the decontamination step.
tedpole has a quite aggressive error correction, which is optimized for spades according to Brian, but this might not be the best solution for megahit and downstream analysis, e.g. SNP calling.
rRNA reads should be excluded from error correction, I think.

Error correction is optional and if errors are present in sequences it will affect their ability to map to decontaminant reference sequences. That was my thought anyways. SPAdes will perform an additional step of error correction in its protocol.

For publication, you normally want to upload raw reads. But at least for human metagenomics one should remove the reads from the host for confidentiality reasons. That was a second thought to put the decontamination step first and all the quality filtering and error correction later?

That definitely makes sense in that context.
We now force users to either start with single- or paired-end after de-interleaving their own reads using reformat.sh. It seems like a simple switch and I'm open to it.

The rule order has been updated to reflect corrections highlighted in the original issue.


EnforceBytecodeVersion: check if the package name is valid

Apply a regex such as "^[a-z]+(.[a-z][a-z0-9])$" to check if a given classfile entry has a valid package name.
The gradle-api-* JARs do not follow the MR-JAR constraints and contain entries such as org/gradle/internal/impldep/META-INF/versions/9/org/junit/platform/commons/util/ModuleUtils.class which cannot be loaded as their package name is invalid. Entries like this should not be scanned.
See https://github.com/gradle/gradle/issues/23002

Released in v0.12.0 -> https://github.com/kordamp/enforcer-gradle-plugin/releases/tag/v0.12.0


Remove version number from files under ./FreeRTOS/Demo

As subject, substitute "FreeRTOS Kernel V10.3.0" with "FreeRTOS Kernel" for all files under ./FreeRTOS/Demo.
###Related PR:
https://github.com/FreeRTOS/FreeRTOS/pull/6

Please don't leave the version number blank - if it is the head revision rather than a tagged version then use something like "tip revision" or "head revision".  Additionally it is important that the version string is identical in any file so we can update all the version numbers is one go simply by using an unambiguous string replacement script.


Added json for norway

Created json for Norway. Following up with issue #816, assuming that the conversion script has been ran on the files and the CSV files are stored at [http://data.openaddresses.io/cache/no.zip] (http://data.openaddresses.io/cache/no.zip).
Please review the json and let me know if any changes need to be made. Thanks!

I'd love to see some sort of provenance information for these bits of data that we store in the data.openaddresses.io bucket. Is there a script or process you went through to create it that we can reference in this JSON metadata?

The Norwegian data is located at: http://data.kartverket.no/download/content/elveg-utm-33-hele-landet behind a registration wall. The archive consists of 400+ zip files using Norway-specific SOS format.
I wrote the script to convert SOS to CSV located: https://gist.github.com/oeon/6a57826b660f380240c2
It takes a zip file as a command line argument, unzips everything and converts all Adresser.SOS into their respective CSV files.
$ bash script.sh {target zip file}

All the CSV files will be in a newly created folder named SOStoCSV.

Awesome, thanks for writing that up. As part of this pull request, can you add a no/ directory to scripts/ in this repo, put your script in it and add what you just wrote as a readme?

Yup, okay I just added it. How's it look now?

Awesome, thanks!

Currently working on getting the no.zip source into shape -- stay tuned


standardize_weights doesn't work with return_sequences=True and sample weights

as of the backend change, standardize_weights doesn't work correctly with return_sequences=True.
assuming I have a mini-batch size of 1600, and my y.shape == (1600, 20, 1000), and my weights.shape == (1600, 20, 1) if I call standardize_weights(y, None, None) I get weights with shape (1600,), but If I call  standardize_weights(y, weights, None) I get weights with shape (32000,), e.g. my weights are just flattened and returned.
What is the purpose of the flatten call?

sample_weights are for samples, and therefore there should be a 1:1 mapping between samples and weights. You cannot pass 3D weights or 4D weights, they must always be 2D.

@fchollet right, but I have 20 samples / time-steps per input. Should I not be able to weight specific time-steps?

No, a "sample" in the context of 3D time data would be a 2D sequence.

So this means that the weights are applied equally to each item in the sequence? In earlier versions of keras I was using sample_weights to mask padding values in my sequences. It looked like it was working. Can you think of another way I can replicate this functionality?

You can incorporate your timestep weights (!= sample weights) into your targets (y) and write a custom loss function...

@fchollet okay thanks I'll give that some thought.

So, I think the document is  outdated which says

For time-distributed data, there is one weight per sample per timestep, i.e. if your output data is shaped (nb_samples, timesteps, output_dim), your mask should be of shape (nb_samples, timesteps, 1). This allows you to mask out or reweight individual output timesteps, which is useful in sequence to sequence learning."

Right. I just updated the docs.
On 22 January 2016 at 18:26, Ke Ding<EMAIL_ADDRESS>wrote:

So, I think the document http://keras.io/models/ is outdated which says
For time-distributed data, there is one weight per sample per timestep,
i.e. if your output data is shaped (nb_samples, timesteps, output_dim),
your mask should be of shape (nb_samples, timesteps, 1). This allows you to
mask out or reweight individual output timesteps, which is useful in
sequence to sequence learning."
—
Reply to this email directly or view it on GitHub
https://github.com/fchollet/keras/issues/1537#issuecomment-174111465.


Add sanic_openapi/swagger support

https://github.com/channelcat/sanic-openapi

Looks like we may need to switch to use function views instead of class views. Could write a function that generates the function for us? https://github.com/channelcat/sanic/blob/master/docs/sanic/routing.md


Excessive properties are not checked if variable is passed

Bug Report
EDIT: ok, reproducer works even without generics
🔎 Search Terms
may only specify known properties
🕗 Version & Regression Information
/shrug
Please keep and fill in the line that best applies:

This is the behavior in every version I tried, and I reviewed the FAQ for entries about everything

⏯ Playground Link
💻 Code
// My code goes here

type Foo = {
    x: number
}

const bar = (baz: Foo) => {
    console.log(baz)
}

const qux = {x: 1, y: 2}
bar(qux) # OK
bar({x: 1, y: 2}) # KO

Playground Link
🙁 Actual behavior
It doesn't typechecks when variable is passed
🙂 Expected behavior
Argument of type '{ x: number; y: number; }' is not assignable to parameter of type 'Foo'. 	just like when object is passed directly

This is working as intended. Excess property checks only applies to object literals.

um, but why? I'm passing the same object, so typechecking should be consistent?

Excess property checks is more of a linter feature. TypeScript is structurally typed, if the structure of the types are compatible you can assign it. Your object with the two properties is compatible with the parameter type.

Ah, got it, but is my initial bugreport with
export type Exact<T> = {[K in keyof T]: K extends keyof T ? T[K] : never};

type Foo = {
    x: number
}

const bar = (baz: Exact<Foo>) => {
    console.log(baz)
}

const qux = {x: 1, y: 2}
bar(qux)
bar({x: 1, y: 2})

stands then? AFAIU it should enforce that excessive properties are not passed.
Playground Link

TypeScript is structurally typed. TypeScript is structurally
The type of {x: 1, y: 20} is compatible with the type Exact<Foo>, so passing it to the function is allowed.


now dev breaks when using TypeScript files within folders on Windows

Title says it all. My app was working for me with now dev on Monday, but updates released since then broke any routes based on TypeScript files that are nested within folders.
For example, if http://localhost:3000/api-broken is configured to point to zeit/api/api-handler.ts, this is the output I get:
> GET /api-broken
> Building @now/node@canary:zeit/api/api-handler.ts
downloading user files...
download complete [1ms]
installing dependencies for user's code...
Found `engines` in `package.json`, selecting range: 10.x
installing to C:\Users\Tyler Church\Desktop\vanilla-from-wsl\zeit\api
npm WARN<EMAIL_ADDRESS>No repository field.

audited 2 packages in 0.375s
found 0 vulnerabilities

install complete [4083ms]
running user script...
script complete [3ms]
tracing input files...
Using TypeScript 3.5.2 (now internal)
trace complete [1219ms]
> Built @now/node@canary:zeit/api/api-handler.ts [6s]
Cannot find module './zeit/api/api-handler.ts'
1) If you want to compile the package/file into executable, please pay attention to compilation warnings and specify a literal in 'require' call. 2) If you don't want to compile the package/file into executable and want to 'require' it from filesystem (likely plugin), specify an absolute path in 'require' call using process.cwd() or process.execPath.
Did you forget to add it to "dependencies" in `package.json`?

If I move the relevant .ts file to the root folder and update now.json to reflect this, things work. But obviously this is not ideal from a code organization standpoint.
The problem seems to have something to do with the built .ts file not getting copied or renamed or something. When the .ts file is in the root folder, the build output looks like this:

But when I've got it in a folder, it looks like this:

Notice that the .ts file is missing in the second image, but a .js file is there in its place.
I'm running:

Windows 10 v1903
Node.js v10.16.0
Now CLI v15.8.7
NPM v6.9.0
Yarn v1.17.3
TypeScript v3.5.3

A repo that reproduces the issue is here: https://github.com/tylerc/zeit-now-ts-debugging
That app running is available here: https://zeit-now-ts-debugging.tylerc.now.sh
Luckily it seems to be working when deployed, but it makes development difficult on Windows machines.
I suspect that something related to this is the cause of this problem: https://github.com/zeit/now-builders/issues/855 I had to update my now.json to use @now/node@canary to fixed the error mentioned in that issue. But after doing so I ran into this new error.
If there's anything you'd like me to try, or any more information I can provide, please let me know.

Thank you for the detailed repro steps @tylerc. We are looking into this.

To help determine if this is related to node-file-trace, can you try it with<EMAIL_ADDRESS>and let us know if that works or not?

@TooTallNate Yes! That does work! Switching to<EMAIL_ADDRESS>makes things work on both my test repo and in the app where I originally ran into this error.


Release as a template

With Typst 0.11.0 and Typst Universe, template packages are now accepted in the package repository.
I'd love to use this for my packages to get a clean and uniform look, but I'm not exactly thrilled about installing it locally, especially because this needlessly complicates my CI workflows too.
If you don't have time to prep this for release as a template, I'd be happy to write a PR that makes it template-ready.

Thanks for your input. I'm definitely going to do this. Currently, I'm working on updating some of my other packages to 0.11, but after that, I will take a look at Mantys.

Actually, I decided to just publish the current version right away.
I want to do some work on the template, but I can still do that after it is published, I guess.
It should be available in the next few days.


Hardcoded cluster domain name

Hi,
cluster domain name is hardcoded as cluster.local
If  your cluster domain name is different, then you cant resolve names of pods
func generateKafkaAddress(cluster *v1beta1.KafkaCluster) string {
	if cluster.Spec.HeadlessServiceEnabled {
		return fmt.Sprintf("%s.%s.svc.cluster.local:%d",
			fmt.Sprintf(kafka.HeadlessServiceTemplate, cluster.Name),
			cluster.Namespace,
			cluster.Spec.ListenersConfig.InternalListeners[determineInternalListenerForInnerCom(cluster.Spec.ListenersConfig.InternalListeners)].ContainerPort,
		)
	}
	return fmt.Sprintf("%s.%s.svc.cluster.local:%d",
		fmt.Sprintf(kafka.AllBrokerServiceTemplate, cluster.Name),
		cluster.Namespace,
		cluster.Spec.ListenersConfig.InternalListeners[determineInternalListenerForInnerCom(cluster.Spec.ListenersConfig.InternalListeners)].ContainerPort,
	)
}

Describe the solution you'd like to see
Adding DomainName parameter in KafkaClusterSpec struct and overwrite hardcoded string cluster.local in all required files.
https://github.com/banzaicloud/kafka-operator/blob/master/api/v1beta1/kafkacluster_types.go#L33

@mp-007 thank you raising this issue. Are you open to take it a stab and create a PR with the proposed change?

Hi @stoader
I would like to work on this enhancement.
Can you please guide me through the process ?
Thanks,
kaushik

Hi @kaushiksrinivas,
We are glad to hear you are interested in the project.
In the master branch the apis are moved to pkg/sdk.
The above suggested modification sounds good.
I would make the DomainName parameter omitempty to keep backward compatibility.
Please give a default value cluster.local to the newly created parameter.
I hope these infos are sufficient to start to work on this.
If not, we are happy to help if you have more questions.
Here is the developer docs if you need help for building the project: https://banzaicloud.com/docs/supertubes/kafka-operator/developer/.
Thanks

I believe this one is fixes with #361


using im2rec.cc in VS2013  with the error of ">im2rec.obj : error LNK2019: 无法解析的外部符号 "public: static class dmlc::Stream * __cdecl dmlc::Stream::Create(char const *,char const * const,bool)" (?Create@Stream@dmlc@@SAPEAV12@PEBDQEBD_N@Z)，该符号在函数 main 中被引用"

Hello everyone:
I want to transform the data form to rec.It is only the tool of im2rec.cc that can transform data with multilabels in one picture.However I don't know how to use it.
I open the MxnetTestApp.sln in VS,and add the im2rec.cpp in it. It goes with the errors following.
ERROR---------------------------------------------------------------------------------------------------
1>im2rec.obj : error LNK2019: 无法解析的外部符号 "public: static class dmlc::Stream * __cdecl dmlc::Stream::Create(char const *,char const * const,bool)" (?Create@Stream@dmlc@@SAPEAV12@PEBDQEBD_N@Z)，该符号在函数 main 中被引用
1>im2rec.obj : error LNK2019: 无法解析的外部符号 "public: static class dmlc::InputSplit * __cdecl dmlc::InputSplit::Create(char const *,unsigned int,unsigned int,char const *)" (?Create@InputSplit@dmlc@@SAPEAV12@PEBDII0@Z)，该符号在函数 main 中被引用
1>im2rec.obj : error LNK2019: 无法解析的外部符号 "public: void __cdecl dmlc::RecordIOWriter::WriteRecord(void const *,unsigned __int64)" (?WriteRecord@RecordIOWriter@dmlc@@QEAAXPEBX_K@Z)，该符号在函数 main 中被引用
1>D:\MXNet\windows\vs\MxnetTestApp\x64\Debug\MxnetTestApp.exe : fatal error LNK1120: 52 个无法解析的外部命令
========== 生成:  成功 0 个，失败 1 个，最新 0 个，跳过 0 个 ==========

try im2rec.py

@piiswrong
There's no parameter of "label_width" in im2rec.py which can transform data with multilabels in one picture.    im2rec.py  and  im2rec.cc  are not the same.

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


Add link to Colab notebook

Fixes #230. Let me know if you have any feedback on the notebook itself: https://colab.research.google.com/github/google/mesop/blob/main/notebooks/mesop_colab_getting_started.ipynb

Also good to know the procedure for adding Colab examples to Mesop. I was about to ask you how that worked before I got started with the version of LLM Playground for Colab.


HYP 158 What We Do Section

name: What We Do Section
about: Added the what we do pop up section
Summary
This is in connection to the Jira ticket HYP-158

Motivation
To make the GUI as close as the design as possible

Describe alternatives you've considered
Close button without X

Additional context
A pop up / dialog box will appear when the top navigation bar “What We Do” is clicked.
The pop up box will have green header, and the box will be light background, with text on top.
A close button on the bottom to close the dialogue box OR a X on the top right. Added BOTH close and x-button

Updated styles and layout to make things simpler
https://github.com/digicatapult/sqnc-hyproof-client/assets/29942957/06191831-b879-45f1-8399-1f1c16f2d20e


New internet labs proposal dry run

1 - App Redirection: I saw the dry run last month and found out that Dmails No Redirect score is 0, meanwhile the app has no redirection, i wonder if New internet labs identify the landing page as a part of the app or not, for example dmail's Links:
Landing page: https://dmail.online/
App: https://app.dmail.online/
The user can only authenticate through the app, i wonder how can i reproduce the issue of redirection, since i tried the NIL Extensions and i found that Preventing Evil and Reporting Evil are active.
2 - The Third Parties: I am also having a problem with third parties it always gets red using the blockstack gaia, for example here in dmail i am trying to get users images from the gaia and it always gets red!

3 - Cookies: Somehow when getting another users images from user's gaia blockstack sets a cookies into the app how to prevent that?

4 - I need to know what are preventing evil and reporting evil flags refers to?
@larrysalibra

This questions might fit better the extension github repo: https://github.com/newinternetlabs/new-internet-extension/issues
The images issue has been address already there, for example.

@sdsantos Thanks i've added the issue there!
https://github.com/newinternetlabs/new-internet-extension/issues/9


fix: update dependencies to avoid vulnerability alerts

PR summary
This PR updated package-lock.json to bump dependencies and avoid vulnerability alerts.
PR Checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

:tada: This PR is included in version 0.19.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Eq 412 2016 census schema

What is the context of this PR?
This PR adds the Census 2016 Household Test questions
How to review

Checkout the branch
Run the unit tests
Run the app and go to the dev console
Select 0_hh2016.json from the list of surveys
Fill in the questionnaire

[ ] Do all commits have sensible commit messages?
[ ] Is all new code unit tested?
[ ] Are there integration tests if needed?
[ ] Is there sufficient logging?
[ ] Is there documentation or is the code self-describing?

Who worked on the PR
@weapdiv-david worked on this, so it will need to be reviewed by someone else

LGTM apart from link issue mentioned above but need to get @ajmaddaford & co to check.

Updated the schema to remove the link...
@ajmaddaford has a copy of the schema (with link) as well as a copy of the data submission generated from this by eQ.
Awaiting feedback

LGTM 👍


Bump dash and fzf.

Installed manifest of package
Manifests unchanged.
Existing package

[x] I am the maintainer of this package.

One PR per package for future.


TFSI partial charge in bpytfsi and py14tfsi

The partial charges for tfsi atoms in tfsi.itp in bpytfsi and py14tfsi folder are different. While in ff.itp in both shows a total charge of -1 (which should be the case), in the individual tfsi.itp files, they do not add up to -1. There seems to be a problem with the partial charges.

It looks like those files were contributed by Vitaly Chaban some years ago. You may have better luck as to the source of this discrepancy by contacting him directly


After Upgrade errors

Hi
After and upgrade from 2.0 to latest release i get the following errors
Migration error: inventoryitem: SQLSTATE[42000]: Syntax error or access violation: 1071 Specified key was too long; max key length is 1000 bytes
Migration error: network: SQLSTATE[42000]: Syntax error or access violation: 1071 Specified key was too long; max key length is 1000 bytes
Using MySQL
Thanks

MySQL complains that a key is too long. This could be either serialnumber or name+version. If you have access to your MySQL database, please run:
select id, serial, CONCAT(name, version), CHAR_LENGTH(CONCAT(name, version)) as keylength from inventoryitem order by keylength DESC LIMIT 10

This will give you the top 10 entries with the longest name+version strings.
Likewise you could run a query for the longest serial_number:
select id, serial, CONCAT(name, version), CHAR_LENGTH(serial) as keylength from inventoryitem order by keylength DESC LIMIT 10

Hi here is the output
| id      | serial       | CONCAT(name, version)
| keylength |
+---------+--------------+-------------------------------------------------------+-----------+
| 8457159 | C02NT3TVG3QP | License Transfer Utility(Simplified
Chinese)<IP_ADDRESS>.0 |        53 |
| 8265958 | C02N26GDG3QD | License Transfer Utility(Simplified
Chinese)<IP_ADDRESS>.0 |        53 |
| 4854453 | W8050018HE6  | License Transfer Utility(Simplified
Chinese)<IP_ADDRESS>.0 |        53 |
| 8460623 | C02M41VJFD59 | Default
aohghmighlieiainnegkcijnfilokake36.0.1985.125 |        53 |
| 8234437 | C02HFGVWDV7L | Default
bepbmhgboaologfdajaanbcjmnhjmhfn35.0.1916.114 |        53 |
| 8444714 | C02N837UG3QP | Default
ngljgiikbpkpfacabheampboanbppiee38.0.2125.122 |        53 |
| 8444607 | C02N837UG3QP | Default
fahmaaghhglfmonjliepjlchgpgfmobi38.0.2125.122 |        53 |
| 8444648 | C02N837UG3QP | Default
fahmaaghhglfmonjliepjlchgpgfmobi38.0.2125.122 |        53 |
| 8209948 | C02N14QMFD57 | License Transfer Utility(Simplified
Chinese)<IP_ADDRESS>.0 |        53 |
| 8280426 | W80489GEDAS  | Default
aohghmighlieiainnegkcijnfilokake35.0.1916.114 |        53 |
+---------+--------------+-------------------------------------------------------+-----------+
looks like this is the issues
On Mon, Feb 2, 2015 at 10:35 AM, Arjen van Bochoven <
<EMAIL_ADDRESS>wrote:

MySQL complains that a key is too long. This could be either serialnumber
or name+version. If you have access to your MySQL database, please run:
select id, serial, CONCAT(name, version), CHAR_LENGTH(CONCAT(name, version)) as keylength from inventoryitem order by keylength DESC LIMIT 10
This will give you the top 10 entries with the longest name+version
strings.
Likewise you could run a query for the longest serial_number:
select id, serial, CONCAT(name, version), CHAR_LENGTH(serial) as keylength from inventoryitem order by keylength DESC LIMIT 10
—
Reply to this email directly or view it on GitHub
https://github.com/munkireport/munkireport-php/issues/197#issuecomment-72436029
.

--
Adam Barnett

Your longest key is 53 that is less than 1000, could you run the other query as well?
select id, serial, CONCAT(name, version), LENGTH(serial) as keylength from inventoryitem order by keylength DESC LIMIT 10

mysql> select id, serial, CONCAT(name, version), LENGTH(serial) as
keylength from inventoryitem order by keylength DESC LIMIT 10;
+---------+---------------------------+-------------------------------+-----------+
| id      | serial                    | CONCAT(name, version)         |
keylength |
+---------+---------------------------+-------------------------------+-----------+
| 8273895 | VMWVk1p9AQmtHLcDORVh3j5IQ | dynamiclinkmanager7.1.0       |
25 |
| 8273908 | VMWVk1p9AQmtHLcDORVh3j5IQ | Microsoft Query12.0.0         |
25 |
| 8273854 | VMWVk1p9AQmtHLcDORVh3j5IQ | LogTransport1.0               |
25 |
| 8273905 | VMWVk1p9AQmtHLcDORVh3j5IQ | dynamiclinkmediaserver7.0.1   |
25 |
| 8273859 | VMWVk1p9AQmtHLcDORVh3j5IQ | ImporterREDServer7.1.0        |
25 |
| 8273858 | VMWVk1p9AQmtHLcDORVh3j5IQ | relaunch1.0                   |
25 |
| 8273906 | VMWVk1p9AQmtHLcDORVh3j5IQ | Microsoft Upload Center14.3.9 |
25 |
| 7807857 | VMWVk1dY3wpRaTxH2s3Jv2Vew | EPSON Scanner5.6.0            |
25 |
| 7807865 | VMWVk1dY3wpRaTxH2s3Jv2Vew | Microsoft Clip Gallery14.3.9  |
25 |
| 7807864 | VMWVk1dY3wpRaTxH2s3Jv2Vew | Microsoft Query12.0.0         |
25 |
+---------+---------------------------+-------------------------------+-----------+
10 rows in set (0.16 sec)
On Mon, Feb 2, 2015 at 11:14 AM, Arjen van Bochoven <
<EMAIL_ADDRESS>wrote:

Your longest key is 53 that is less than 1000, could you run the other
query as well?
select id, serial, CONCAT(name, version), LENGTH(serial) as keylength from inventoryitem order by keylength DESC LIMIT 10
—
Reply to this email directly or view it on GitHub
https://github.com/munkireport/munkireport-php/issues/197#issuecomment-72440826
.

--
Adam Barnett

What version of MySQL?

I did a restart of mysql and it all seems fine now
Thanks
On Mon, Feb 2, 2015 at 11:50 AM, Arjen van Bochoven <
<EMAIL_ADDRESS>wrote:

What version of MySQL?
—
Reply to this email directly or view it on GitHub
https://github.com/munkireport/munkireport-php/issues/197#issuecomment-72444508
.

--
Adam Barnett

Hmm, maybe closed too early. What do you mean by 'all seems fine now' Did you actually migrate?

Yes. I am now running the new version and the migration completed

On 2 Feb 2015, at 18:43, Arjen van Bochoven<EMAIL_ADDRESS>wrote:
Hmm, maybe closed too early. What do you mean by 'all seems fine now' Did you actually migrate?
—
Reply to this email directly or view it on GitHub.

Ok, thanks!

Hi
This error has come up again after doing an upgrade
Same output for the command as above
Any ideas?

Restart MySQL?

Do you get both inventoryitem and network migration errors?
Could you post the output of:
SHOW TABLE STATUS LIKE 'inventoryitem';
SHOW CREATE TABLE `inventoryitem`;

mysql> SHOW TABLE STATUS LIKE 'inventoryitem';
+---------------+--------+---------+------------+--------+----------------+-------------+-----------------+--------------+-----------+----------------+---------------------+---------------------+---------------------+-----------------+----------+----------------+---------+
| Name          | Engine | Version | Row_format | Rows   | Avg_row_length | Data_length | Max_data_length | Index_length | Data_free | Auto_increment | Create_time         | Update_time         | Check_time          | Collation       | Checksum | Create_options | Comment |
+---------------+--------+---------+------------+--------+----------------+-------------+-----------------+--------------+-----------+----------------+---------------------+---------------------+---------------------+-----------------+----------+----------------+---------+
| inventoryitem | MyISAM |      10 | Dynamic    | 113429 |            187 |    21325052 |<PHONE_NUMBER>10655 |      2020352 |     10668 |       10805517 | 2014-07-01 09:11:53 | 2015-03-13 16:11:10 | 2014-07-01 09:11:54 | utf8_general_ci |     NULL |                |         |
+---------------+--------+---------+------------+--------+----------------+-------------+-----------------+--------------+-----------+----------------+---------------------+---------------------+---------------------+-----------------+----------+----------------+---------+

+---------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Table         | Create Table                                                                                |
+---------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| inventoryitem | CREATE TABLE `inventoryitem` (
  `id` int(11) NOT NULL AUTO_INCREMENT,
  `serial` varchar(255) DEFAULT NULL,
  `name` varchar(255) DEFAULT NULL,
  `version` varchar(255) DEFAULT NULL,
  `bundleid` varchar(255) DEFAULT NULL,
  `bundlename` varchar(255) DEFAULT NULL,
  `path` varchar(255) DEFAULT NULL,
  PRIMARY KEY (`id`),
  KEY `inventoryitem_serial` (`serial`)
) ENGINE=MyISAM AUTO_INCREMENT=10805517 DEFAULT CHARSET=utf8 |
+---------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)


sendMessage freeze if I try send more than 20 message / per minute for different users

Hello! I try to send a message to all bot users. In the documentation, I see the only 30/sec limit. But when I try to send, if I send more than 20/min sendMessage freeze for 30 sec. And I can send more than 20/per minute to separate users. Does anyone get this limit?

Yep, I thinks it's a Telegram side protection against spam.


12-hour clock format isValid with military time?

I'm seeing a strange issue where
moment('21:35 pm', 'h:mm a', true).isValid() evaluates to true.
I checked this against
new Date('2015/01/01 21:35 pm') which yields an invalid date
I feel it should return false in this case
I'm seeing this issue in 2.8.3

Agreed

Fixed in 2.8.4: https://github.com/moment/moment/pull/2003


--manager flag to join the swarm cluster as manager

I think you should use docker swarm join --manager ... in the loop that creates the additional managers. Without that option, they will join the cluster as workers.

Removed option for additional managers (for now) after switching to Managed Instance Groups. Will need to figure out the best way how to re-enable multi-managers setups with a Managed Instance Group.


Multimedia keys doesn't work NuvolaAppYandexMusic

Basic information

Your Linux distribution and its version: Fedora 30

Your desktop environment: Gnome 3.32

The web app you use and its version: NuvolaAppYandexMusic

Nuvola Runtime version:

$ flatpak list
Name                                    Application ID                        Версия Ветка  Origin      Установка
Nuvola Apps Service                     eu.tiliado.Nuvola                            stable nuvola      system
Yandex Music • Nuvola App               eu.tiliado.NuvolaAppYandexMusic              stable nuvola      system
Intel                                   org.freedesktop.Platform.VAAPI.Intel         18.08  flathub__1_ system
html5-codecs                            org.freedesktop.Platform.html5-codecs        18.08  flathub__1_ system
GNOME Application Platform version 3.32 org.gnome.Platform                           3.32   flathub__1_ system
Adwaita dark GTK theme                  org.gtk.Gtk3theme.Adwaita-dark               3.22   flathub__1_ system

Describe the bug
Multimedia keys doesn't work.
Steps to reproduce the behavior

Install fedora 30
Install by manual Nuvola
Try press play\pause button.

Expected behavior
Multimedia keys work properly.

Hello @AlexGluck. Thanks for reporting the issue. Could you provide me with following details to help me to investigate the issue further?

The version of Nuvola Runtime (you provided only a branch). You can get it from About dialog, click Menu button, then About.
The version of NuvolaAppYandexMusic. You can get it from About dialog, click Menu button, then About.
Debugging output. See Bug Reporting Guidelines for instructions on how to get a debugging log. then save it as a text file (*.txt) and attach it to the bug report using the Attach files by dragging & dropping or selecting them. feature available under the textbox.

The version of Nuvola Runtime.
The version of NuvolaAppYandexMusic.
Debugging output.  eu.tiliado.NuvolaAppYandexMusic.debug.txt

I think this can help

UPD
gnome at wayland media keys work properly before sleep or hibernate
After sleep or hibernate media keys not working

I use gdm on wayland and gnome at xorg.
...
gnome at wayland media keys work properly before sleep or hibernate

Do I understand correctly that media keys in GNOME/Xorg never work while they always work in GNOME/Wayland before sleep/hibernate?

Yep

I could not reproduce the issue on my system yet but I have a few ideas for test scenarios.

Is this issue still present in the latest Nuvola (4.16.30)?

I removed app, because needed feature not worked and pay for testing feature i can't. Sorry.

I understand that. I'm sorry that I haven't managed to reproduce and fix the issue for you.


VS Code is stuck with infinite loading on Safari v16 and lower

ADD ISSUE DESCRIPTION HERE
It does not matter which file I load or opem, it is stuck with infinite loading
Version: 1.84.0
Commit: d037ac076cee195194f93ce6fe2bdfe2969cc82d
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Embedder: codespaces

I have the same issue. I've done some investigations and found out the problem is here https://github.com/microsoft/vscode/blob/7425fbc5f30456a4d1c17698a60274f6d48b6baf/src/vs/base/common/tfIdf.ts#L92 . It doest works with Safari < v17 because of error invalid group specifier name.

I do have an older macOS VM, but it doesn't seem to be booting right now. My current macOS device is on Safari 17.
@raphaeldn28 @Raubzeug is the issue fixed for either of you?
One way to test is to launch https://insiders.vscode.dev, and then to search just "a" in the Settings editor while having GitHub Copilot Chat disabled or not installed. If the Settings editor is able to finish the search, then the fix worked.

@rzhao271 Hi! I've just checked with Safari 15 and 16 and https://insiders.vscode.dev doest'n work. The problem is here now:

By the way, it works properly with Safari 17.

I finally confirmed the unexpected token issue with a VM, but I'm unsure which part of the code it comes from.


Move SelectOption interface to core

See issue: https://github.com/xh/hoist-react/issues/3274
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[x] Caught up with develop branch as of last change.
[x] Added CHANGELOG entry, or determined not required.
[x] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[x] Updated doc comments / prop-types, or determined not required.
[x] Reviewed and tested on Mobile, or determined not required.
[x] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@TomTirapani we need a changelog entry for this one

all set on this one -- I added
On Wed, Feb 8, 2023 at 1:56 PM Anselm McClain @.***>
wrote:

@TomTirapani https://github.com/TomTirapani we need a changelog entry
for this one
—
Reply to this email directly, view it on GitHub
https://github.com/xh/hoist-react/pull/3275#issuecomment-1423091694, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AARTL2MVSBKUGGQJDNOX77LWWPT4DANCNFSM6AAAAAAUQL4CTY
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


fix: fix scatter chart legend icon inheritance

Brief Information
This pull request is in the type of:

[x] bug fixing
[ ] new feature
[ ] others

What does this PR do?
Allow legend icons to inherit style from series icon.
Fixed issues

fix #17350

Details
Before: What was the problem?
As is specified here, a judgement is only satisfied for LineSeriesModel, so icon style can only be inherited in line charts but not in scatter charts. This judgement is whether the model has the method getLegendIcon().

After: How does it behave after the fixing?
The way to solve this is simply add the same function getLegendIcon() to ScatterSeriesModel. It is not used in any other function by now so it's safe to add it just to allow icon style inheritance. But if we need to use this function for scatter model, further tests are needed.

Document Info
One of the following should be checked.

[x] This PR doesn't relate to document changes
[ ] The document should be updated later
[ ] The document changes have been made in apache/echarts-doc#xxx

Misc
ZRender Changes

[ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs
N.A.
Others
Merging options

[ ] Please squash the commits into a single one when merging.

Other information

When can we expect this to be available?

Hi,
When can we expect this to be available? Is there a blocker or something ? Why the changes are not yet merged?
Can some one please let us know the latest update on this? We are also eagerly waiting for this fix,
Thanks in advance

Hi, this problem seems still existed today in 5.0.0, does anyone know the latest process on this issue?

Hi, this problem seems still existed today in 5.5.0, does anyone know the latest process on this issue?
PS: To anyone else who find this issue, you can use SVG datapath in symbol, I have checked that at least this works normal in 5.5.0 for legend icons.

Hi,
When can we expect this to be available? Is there a blocker or something ? Why the changes are not yet merged?
Can some one please let us know the latest update on this? We are also eagerly waiting for this fix,
Thanks in advance


SVG symbol tags should be transformed into functions

I have a map image with a lot of repeating symbols, so I put them inside an SVG symbol tag, so that the same drawing instructions don't have to be repeated over and over again. The result of the code generation process is just a one long code block (sometimes divided into several render functions), which does not take advantage of the fact that the exact same drawing instructions could be grouped together as functions. This way it would be easier to make changes in the code. It would also make the code shorter (the same symbols wouldn't have to be repeated). The only problem with this solution is that you have to keep in mind that each symbol instance may have different matrix transformations, but it shouldn't be too hard to code up (I did it with my generator and it worked well).

The idea is great, however, that structural level what you are referring to doesn't exist on the code render level, because it was interpreted by the android-svg library code already.
With some changes on the original library code it is possible to pass more information to the code render and recognize those parts which were processed already. This is rather complicated with the current structure, the concept of subroutines has to be introduced to code render.


[Arith] Support Analyzer.int_set(expr) in python and add RewriteSimplifier rules

This PR:

Supports Analyzer.int_set(expr) from python side. That is, exposing this API from C++ side. Previously we only support Analyzer.int_set(expr, dom_map).
Adds some RewriteSimplifier rules for simplifying certain expressions:

min/max(x +- y, x) where y>=0 or y<0
Supporting symbolic analysis in comparision expressions. That enables simplifying x // 2 < y where x < y * 2 to True

cc @spectrometerHBH @tqchen

Needs more consideration on symbolic analysis


Added IsInInlineEditOrAddState flag to the RadzenDataGrid.razor.cs

Came across a small bug in the RadzenDataGrid component where if the grid is in inline edit mode and the user is adding or editing a row and accidentally clicks on the cell header the grid sorts and the edits disappear. I added the IsInInlineEditOrAddState Boolean flag to the gird which is set by edit/insert state and unset after a save or cancel

Hey @ksli78,
I'm afraid this is how the DataGrid works - there are other operations like filter, group, page, etc. and the editing will be canceled explicitly.  This is also a breaking change in the behavior of the DataGrid and not all users will be happy - we cannot accept this pull request. You can implement the same in your case outside of the DataGrid component.

That’s fair ! But then is there a way to make the new record appear at the bottom row instead of at the top so close to the cell header? My reason was I have many users with accessibility issues and I testing we noticed that they would click on a sort during an edit/new operation. I can fix it only I my app but I figure it may be something others would need. Perhaps I went about it the wrong way maybe it could be a property on the grid that that can be enabled or disabled by the developer and it can have a default value of allowing the sort to happen this way it won’t break anyone. Sent from my iPhoneOn Mar 10, 2023, at 1:19 AM, Vladimir Enchev @.***> wrote:
Hey @ksli78,
I'm afraid this is how the DataGrid works - there are other operations like filter, group, page, etc. and the editing will be canceled explicitly.  This is also a breaking change in the behavior of the DataGrid and not all users will be happy - we cannot accept this pull request. You can implement the same in your case outside of the DataGrid component.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


S3 crt client HeadObject call freezes.

Describe the bug
We are running a service where we read data from s3 parallelly(multithreading), one day we saw all the threads are still running as head response from S3 freezes with no response ever returned(All new threads are also in struck state leading to accumulation of lot of threads). However this issue is fixed once we restarted the service.
Unfortunately, we have not been able to reproduce this issue since. While investigating, we found a similar issue in the AWS SDK for JavaScript here. Could you please confirm if this is indeed a similar issue? The suggested solution in that case was to configure an HTTP timeout.
We considered doing the same, but we discovered that the S3 CRT client does not honor timeout configurations, as mentioned in this issue. Could you provide information on when the AWS S3 CRT client will support timeout configurations? This support is crucial to ensure that we do not encounter S3 API call freezes in the future.
Expected Behavior
HeadObject call shouldnot freeze
Current Behavior
HeadObject call freezes.
Reproduction Steps
Unable to reproduce, but its better to configure HTTP timeout
Possible Solution
No response
Additional Information/Context
No response
AWS CPP SDK version used
1.11.269
Compiler and Version used
gcc (GCC) 4.8.5
Operating System and version
CentOS Linux and version 7

Thanks for taking the time to look for older similar issues, but it's hard to tell if your situation is similar to the 10 year old js-v1 issue. I don't have any timeline for when timeout configurations might be supported by the CRT client. I would recommend that you 👍 the feature request, because that helps us when prioritizing new feature requests.
We can also look more into why you are seeing the HeadObject call freeze if you give us more info:

a minimal, reproducible example
trace level logs

Hello,
Unfortunately we are unable to reproduce this issue regularly so we plan of running some overnight testing with aws cpp SDK trace level logging enabled. Luckily same issue is seen again.
You can find trace level logs from this link this(expires in 7days).
NOTE: Issue started happening from the below log
2024-09-04T13:09:31+05:30	2024-09-04T07:39:31.129857333Z stdout F Sep  4 13:09:31.129 668_001 app: ,INFO, com.amagi.darti.s3_reader.buffered_reader, Opening s3://amagicloud-onecp-sigma8/Media/S3/668/+240211472001XA+.mxf
Note above mentioned log is our custom log for headobject call this is just there for reference.

What version of Curl are you building against and can you try building against newer curl.
From logs it looks like, curl is trying to establish a new connection, sees existing one in the pool, but determines its dead, so it tries to obtain new ips from dns and gets stuck in the loop there. We dont have a lot of custom code around dns resolution in cpp sdk, so it might be due to some sort of bug in curl.
Note: for s3 crt client, crt is only used in the put/get apis, all the other apis still go through the regular curl based implementation (and timeout settings will apply to those as usual)

@DmitriyMusatkin

we are using curl version curl 7.29.0
So configuring timeouts will cancel curl based operations if it gets struck and eventually headobject call will return with error? and this applies even for crt client?

curl 7.29.0 is over a decade old at this point. i would not be surprised if it has some issues with mva dns.
yes, timeout should apply in this case. looks like its having issue with obtaining ips to establish connection, so connection timeout should stop it attempting.
as i mentioned HeadObject in s3-crt cpp client does not actually use crt under the covers and goes through regular s3 client path.

Hi @DmitriyMusatkin but we are using centos7 for which curl 7.29.0 is the latest version in centos7.
I also configured timeout configs still headobject freeze issue is seen.
Can you please suggest some solution to fix this?

Im not sure there is an easy fix for this. From the logs it looks like curl acquires connection from a pool, realizes that it has been closed (because it probably hit idle timeout on s3 side), tries to acquire a new connection and then stops after dns resolution. We haven't observed this behavior with newer versions of curl and we don't automatically test versions of curl that old.
So unfortunately, it sounds like the only path forward would be for someone to repro it with that version of curl and figure out whats going on curl side and see if sdk can do any mitigations to avoid that behavior.


Savings calculation

Some stores want to show savings as a percentage.
This needs to update on variant change incase the savings percentage varies.

This won't be required with the new version.


Fix minor module glitches

Added template macros to the SolusVM page as was required with CentovaCast - this fixes at least the issue of config options not showing up. (potentially solves #1293 on the old repository. I do not have a test environment to debug any further - but SolusVM's API has not changed substantially since 2013 (this seems to have been last updated in 2015) so should be fine after this patch?
Fixed the login URL given by the Plesk module as it was incorrect, Provides a fix for one of the comments on #1188  on the old repository.  As an aside, Plesk module works fine on the latest version of BoxBilling and Plesk in my environment.

Thanks. :)


Follow up issue Intellisense stop running on v1.88.1

Type: Bug
Follow up issue marked up as complete https://github.com/microsoft/TypeScript/issues/58198#issue-2243951381 with no reason!
Intellisense stop running on v1.88.1,

with detail About below:
Version: 1.88.1
Commit: e170252f762678dec6ca2cc69aba1570769a5d39
Date: 2024-04-10T17:42:52.765Z (1 wk ago)
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Darwin x64 23.4.0

when I cmd+click react-native import, vscode opening index.js in path <my_project>/node_modules/react-native/index.js, if I remember correctly, it should pointing to vscode cache folder with .tsx extension.

As previously requested, please create a sample project which demonstrates the problem.  Then open a new issue against TypeScript  with that example project


Replaced deprecated assertEquals with assertEqual

Coverage remained the same at 89.403% when pulling 84f157c315913d676d8bdf03a337168d2d9f1f88 on atombrella:assert_deprecated into 05274549a39e29748f7649c3455707d32fe08a15 on uber:master.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


I have find this !

Hello,
To avoid writing the embedded dll in disk you can probably use this:

https://github.com/fancycode/MemoryModule
And the rust bindings:
https://github.com/indygreg/rs-memory-module-sys

Sorry for my bad english !

Oh I have heard about this, didn't know there is rust bindings too. Definitely worth trying.

I have testing to use it in #5
It's work but you can probably improve the code ;)


Update Emissary-ingress to use the latest Envoy 1.17.3 release

We need to update Emissary-ingress to use a more recent version of Envoy to make new features available to our users. Our first step will be to upgrade to the latest version of Envoy 1.17.

We released Edge Stack 1.14.0 on Thursday, August 19th.


Error using DAVIS driver as nodelet

The DAVIS ROS driver currently clears the event array within the message immediately after publishing. This seems to cause problems when the driver is run as a nodelet as the subscriber receives a pointer to the original message, which now has an empty event array. Storing the event array in a separate variable which is copied into the message and then cleared seems to resolve the issue.

Thanks, @alexzzhu! It would be great if you could create a pull request with the change.

thanks, @morloy


Support conversion of multi-Xprivs into multi-Xpubs

Possible when all hardened derivation steps are shared among all paths (or if there are none). Errors otherwise.

Would like @sanket1729 to take a quick look at this before acking to sanity-check it.
In particular this forbits multixpubs where there are hardened derivations after the split. I assume this is a requirement to be a legal multixpub? Because there isn't any obvious reason we should be forced to have this limit.

assume this is a requirement to be a legal multixpub? Because there isn't any obvious reason we should be forced to have this limit.

Correct, this is a limitation imposed by the current DescriptorMultiXKey structure (can only have one concrete pubkey as the base for derivations) and not something inherent. But supporting it would require some pretty invasive changes and it seemed to me that in the typical case hardened derivation steps are usually shared, and that it can be good enough with that limitation.

Added another commit with some formatting changes that also updates the existing DescriptorXKey::to_public(). Let me know if you'd like me to squash or drop that commit.


Oof there are a bunch of really high GCM peak temps

From Sam:

I think you might have filtered out observed temps >40, but there are 58k peak_temp >40 in lake_temperature_metrics_GLM_GCM.csv

low priority. could respond with "we applied published models to vetted driver dataset and report all model output"

Replied with something along these lines in the reconciliation document.

Yes, these high peak temperatures do exist and represent ~1% of the peak temps in this file, however, we applied published models to vetted driver datasets and are reporting all model output.


Wrong model: ollama run llama3 runs instruction-finetuned model

I just have noticed that ollama run llama3 runs Llama 3 8B Instruct (the instruction-finetuned variant) instead of Llama 3 8B:
https://ollama.com/library/llama3/blobs/6a0746a1ec1a
These are different models:
Llama 3 8B: https://huggingface.co/meta-llama/Meta-Llama-3-8B
Llama 3 8B Instruct: https://huggingface.co/meta-llama/Meta-Llama-3-8B-Instruct
Would it be possible to fix this?

I don't know if it's policy, but it seems that the plain model name in the ollama library usually references the finetuned model, and the base model is usually <model>:text or <model>:base, eg llama3:text

Oh, wow, thanks! Very intuitive from my pov...

But it is indeed odd why there is a :text for llama3, but there isn't for llama3.1. Maybe this is indeed an oversight?

I have been assuming that it's just because llama3.1 is still too new, and it takes time to do format conversion and quantization and so forth.
(Note that, in addition to defaulting to the instruct-tuned model, ollama also defaults to a 4-bit quantization of the model. I think this makes sense, because otherwise most people would waste a ton of bandwidth downloading the full-sized version, and then not be able to run it. But it's worth inspecting the specific quantization levels yourself; I don't recommend ever downloading the default option.)

I have been assuming that it's just because llama3.1 is still too new, and it takes time to do format conversion and quantization and so forth.

Might be, but actually llama3.1 is already provided (llama3.1), and the instruction-finetuned variant most likely won't have a different architecture. So idk... And I would be surprised if this process isn't automated to some point tbh.

(Note that, in addition to defaulting to the instruct-tuned model, ollama also defaults to a 4-bit quantization of the model.

Yeah, seems to be q_4 by default


Issue with empty table cell () using ConverterExtra

Hi and thank you for this great Markdown converter!
Here is how to reproduce the issue (please note the empty 	):
$converter_extra = new Markdownify\ConverterExtra;

echo $converter_extra->parseString('

  First Header
  Second Header

  Content Cell
  Content Cell

  Content Cell

');

The above PHP code outputs that same HTML table.
Expected output:
| First Header | Second Header |
| ------------ | ------------- |
| Content Cell | Content Cell |
|              | Content Cell |

Please note that adding a space ( 	) fixes the issue.

Hi @francoisjacquet!
Thanks for reporting this issue with an explicit test case :+1:
I made a fix, it will be available in the next: v2.1.11 published few minutes ago.
If you can not update your library, you can force table conversion by setting the attribute keepHTML to false.
$converter_extra->setKeepHTML(false);

Cheers,
Thomas.


Light build imports everything

Importing the light build like the readme suggests results in a bundle that contains all languages.
import { PrismLight as SyntaxHighlighter } from 'react-syntax-highlighter'

Importing with the line below results in the desired behaviour -- the bundle contains only the explicitly imported languages.
import SyntaxHighlighter from 'react-syntax-highlighter/dist/esm/prism-light'

I'm using version 11.0.2, bundling with webpack.

webpack drops unused code only in production mode 😸

It happens in production builds as well.

I am seeing the same issue.

@seldomU @LarsDenBakker
I wrote a webpack-starter that use react-syntax-highlighter, and didn't have your problem. Maybe you should check it out.


Popper updates

This is a refactor of how we handle absolutely positioned elements that reference other elements. It still uses Popper.js for this, but swaps out our own implementation for react-popper.
I've included a few other related updates along with this:

Adds react-transition-group as a dependency. This will be useful for other components that have a lifecycle to them (open/close, expand/collapse, etc.).
Updates Popover and Tooltip to use the new implementation.
Adds the showDelay to all components that can use it. This addresses NDS-7.
Sets a default showDelay of 500ms and a default hideDelay of 0 for icon-only buttons. This ensures that adjacent icon buttons don't display overlapping tooltips.
Adds a fade CSS transition, now used by Popover and Tooltip by default (this can be overridden).

Still todo:

[ ] Write new Popper-specific tests (packages/react/src/components/Popper/index.test.tsx).
[ ] Update failing tests where appropriate. Notably, the change to make icon-only buttons display their tooltip after a 500ms delay is causing failures that need to be updated, likely using waitFor.
[ ] Merge in the isomorphicLayoutEffect fix. Builds are failing currently because this is being imported from a place where it doesn't exist.
[ ] Update Dropdown to use the new Popper. This could be done in a follow-up PR.
[ ] Remove BasePopper. This could also be done in a follow-up PR.

I went through every uncovered line in https://github.com/wwnorton/design-system/pull/158/files#diff-d09fcf0c2d2a8a73280859b3b533428c07e5493fde7fe9eec8b77a7a48bdc39c, and each line is related to the popper's physical rendering (position, size, distance from reference). There's no way for us to effectively test these with our current testing environment (JSDOM) because it doesn't have a rendering engine.
With that in mind, I'm going to merge this even with the 90.14% patch coverage (failing by 1.54%). We may want to consider adding an end-to-end testing layer like Cypress, Puppeteer, Playwright, or WebDriver.


fix: debounce bug

This pull request fixes the debounce bug

related to issue #38
@ShayAdler @NoamGaash

Hi, about the reason why I used useLayoutEffect. First, I tried with useEffect but when I chose the details of the bus number and moved to another tab in the navigation (where this component is also used) , I saw the change of this input filed from the place holder to the lineNumber data. So, I decided to useLayoutEffect which fires before the browser repaints the screen which helps to render the initial lineNumber content. However,  I can create a Loading instead,  if you prefer.

@NoamGaash Pls, Tell me if you prefer that I will change to useEffect with Loading instead of using useLayoutEffect.

@ShayAdler @ArkadiK94
I'm not sure why the test isn't passing.
I've tried fixing and enhancing the tests on this branch -
https://github.com/hasadna/open-bus-map-search/pull/45
I'll try to fix it there.


tabbing through a multiselect with a value already set

I have a vanilla instllation of vue-multiselect and I have made a video of my issue you can see here:
https://youtu.be/DJ28zFdX0F0
Basically what happens is if a user has set a value on a multiselect and then sets the focus "BRFORE" it and starts tabbling, when the multiselect gets focus,  the value gets reset to the topmost or bottommost value in the list depending where the mouse is located/.

Thanks for reporting. Will try to fix it before 3.0 :)


Support windows

What would you like to be added?
TODO
Why is this needed?
TODO

Fixed by #646
/close


Security threats and Countermeasures

Review and Discover security threats (defined by OWASP).
Document and Implement protection against vulnerabilities.

First stage is done


Add the I rules to enable import sorting

Fixes

Fixes #3695 by @stacimc
Description

This PR adds the missing ruleset for isort (I) to Ruff. This reenables import sorting and creates a pretty big diff. Also it adds test (which is our own module) to known, first-party packages so that makes the diff even longer.
PS: I created #3546 so I knew where to look.
Testing Instructions

Verify the changes in pyproject.toml and ensure that lint checks are passing. You can try to repro the link issue and verify it cannot be reproduced on this branch. Running the following command should reorder imports (almost immediately!) after you've moved them around.
just lint ruff

Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Duplicated effort. I should've seen #3698.


Labels in Nodes and Ports

Hi, this project is really cool.
Is it possible to add a label to the node and next to the in/out ports, similar to what react diagrams do?
Thanks!

Hi @brunovacare, you can see in the code the DefaultNodeComponent and the way it's implemented here:
https://github.com/DanielNetzer/ngx-diagrams/tree/3bcfe40bb04b846096e9b088a1c0219d0793aa62/projects/ngx-diagrams/src/lib/defaults/components/default-node
in a similar manner you can create a custom node with anything you'd like.
to create a Label you can just do:
import { ..., DefaultLabelModel } from 'ngx-diagrams';
...
const someLinkModel = new DefaultLinkModel();
const capsLabel = new DefaultLabelModel('LABEL!');
someLinkModel.setLabel(capsLabel);


Examine Envoy and Istio as a potential NginX replacement

Envoy proxy and Istio look like mature enough modern way to handle microservices, and might be better fir for Mainflux project.
Some research is needed to see wha't the effort and benefits from switching to Istio.
Take care especially on the binary size and cross-compiling complexity, as Mainflux should be runnable on ARM IoT gateways as well.

It would definitely be a better fit. I take a quick look, there is a lot of benefits (they are both intended for distributed systems).  Looks very interesting I will help with research :+1:

While I totally support using envoy to create a service mesh, wouldn't you need to use contour (which is built on envoy) in order to replace nginx as an ingress controller?
https://github.com/heptio/contour

@sking2600 This is good suggestion, worth of considering.
I am currently checking Istio project Which is also built on top of envoy and can be used together with Kubernetes. There is no doubt if Istio is good or not, I am more investigating benefits and downsides of usage in current Mainflux stack.
More lean and light solution would be to just replace nginx with envoy and use K8 ingress such as contour.


Injection broken on Rootless Palera1n since Update 0.6.1

Heyya
Got a few reports from my users, that the tweak didnt inject anymore. After some debugging, we found that as soon they Update Ellekit in Sileo to anything after 0.6-1 (so 0.6.1 and up) it doesnt load any tweak anymore.
Downgrading and it works directly again.
Most of the Users are on ios 15.x
Do you have any log file that gets generated or something, that can help you with finding the issue?

Fixed in 0.6.2

But its broken on 0.6.2 and 0.6.3 too, thats why i reported it. Something changed in that versions so it doesnt load correctly anymore it seems, as downgrading and using the same tweak works fine


Docker build fails with the error: failed to create SCM: file does not exist

What version of Turborepo are you using?
1.6.0
What package manager are you using / does the bug impact?
Yarn v1
What operating system are you using?
Linux
Describe the Bug
Building examples/with-docker/ fails with the error failed to create SCM: file does not exist
turbo looks for a .git folder, which is not present in the docker image, and fails somehow. possibly introduced in 87cfbe9af166991b7b0f5f3603933a4e14f59751
Expected Behavior
This worked in 1.5.6 (with the libc6-compat package added)
To Reproduce
Building the with-docker example fails
Fix the examples/with-docker/apps/*/Dockerfile to make turbo run in the installer stage
 # Add lockfile and package.json's of isolated subworkspace
 FROM node:alpine AS installer
+RUN apk add --no-cache libc6-compat
 RUN apk update
 WORKDIR /app

cd examples/with-docker
yarn install # generates the required yarn.lock

Perform the documented build step in the example
# Build prod using new BuildKit engine
COMPOSE_DOCKER_CLI_BUILD=1 DOCKER_BUILDKIT=1 docker-compose -f docker-compose.yml build --parallel

And the build fails like this:
#0 0.531 $ /app/node_modules/.bin/turbo run build --filter=web...
#0 0.610  ERROR  run failed: failed to create SCM: file does not exist

I can confirm this isn't limited to Docker, got the same issue with a normal build. Also only happens to 1.6.0, downgrading to 1.5.6 worked again.

Also started experiencing the same issue in docker today, can confirm downgrading does fix the problem.

Hey y'all, we're on it!

This change is released in 1.6.1!

Thanks! 1.6.1 works for me


Block size of the model

Hi Luis, for processing the training data, it looks like the average token per cif file is smaller than the block size (768M tokens for 2.2M cif files; block size is 1024 or 2048). In that case, the sequence is very likely to contain information from two or even more cif files. However, information from different cif files are not strongly correlated, so it may not contribute to better reasoning ability of the model. Do you think it is more reasonable to decrease the block size to focus more on the local information in the current cif file?

Hi @ChangwenXu98 ,
Thanks for asking this question. In the datasets I've worked with, the mean tokenized length of a CIF is ~350 tokens, but the distribution can range from less than 200 tokens to up to ~6000 tokens. I performed several experiments early on to understand how the block size affects the results. I found that doubling the block size from 1024 to 2048 didn't result in a large difference in the model's performance. By doubling the block size, we are processing more tokens per iteration, but the GPU memory requirements are doubled, and training takes longer (for the same number of iterations). I also tried two approaches to constructing the input block: randomly sampling a start index from anywhere inside a CIF (from the list of concatenated tokenized CIFs), or randomly sampling a start index that represents the first token of a CIF. I found that there isn't much difference to either approach. The only difference I seemed to notice was in the ability of the large model to generate longer CIFs (in terms of tokenized length) more successfully when a 2048 block size was used and we sampled start indices representing the beginning of a CIF.
It would be reasonable to try a smaller block size, such as 512. You'd probably want to train for twice as many iterations to see the same number of tokens as when training with a 1024 block size. But I suspect the model would have more difficulty generating longer CIFs.
Regards,
Luis


Create nicer UI for initial checklist creation

The current flow presents simple question-answer flow with no visual flair. This does not match the rest of the program and should be enhanced.

For one to two questions, I cannot thing of a better UI at present.


full_event doesn't do nesting

We may need full_event to be more flexible as we access multiple levels in the dict.

Closed by #60


[RHOAIENG-10305]: Apply token theming to RegisteredModelListView.tsx

WIP, towards RHOAIENG-10305. Working on applying theming to split button dropdown and fixing UI issues with toolbar alignment

Closing - these updates will be migrated to https://github.com/kubeflow/model-registry as part of https://issues.redhat.com/browse/RHOAIENG-11419


[To rel/1.2] Pipe: drop HeartbeatEvent when pipe is stopped to avoid OOM (#10977)

(cherry picked from commit f1a4012424fef30509ed13e33e1b641ffc5d4ba9)

coverage: 47.683% (-0.004%) from 47.687% when pulling 5059ebb0617afb39baa160b655e44ffeafe787b5 on pipe-he-reduce into 9f31e15a3d59f80345c0ad9cada255e5ee5da2da on rel/1.2.


Can not pass the verify with Arduino uno R4 wifi board in Arduino IDE.

Describe the bug
As title.
Environment info

IDE w/version [Arduino IDE 2.2.1]
Platform/Board: [Arduino Uno R4 Wifi]
Network controller :  board embedded

Expected behavior
Pass the verification at least.
Failure log
In file included from c:\Users\sam\Documents\Arduino\libraries\mWebSockets\src\base64\Base64.cpp:2:0:
c:\users\sam\documents\arduino\libraries\mwebsockets\src\platform.h:33:4: error: #error "Unsupported platform"
 #  error "Unsupported platform"
    ^~~~~
c:\Users\sam\Documents\Arduino\libraries\mWebSockets\src\base64\Base64.cpp:9:12: fatal error: pgmspace.h: No such file or directory
 #  include <pgmspace.h>
            ^~~~~~~~~~~~
compilation terminated.

exit status 1

Compilation error: exit status 1

Additional context

Arduino UNO R4 support is available on the master branch.

Arduino UNO R4 support is available on the master branch.

Thanks very much for your information!
R4 wifi looks pretty cool, although I've just finished testing the ESP32S3.


Lack of trailing newline makes it difficult to write content under a JSX component

Given the JSX example (http://localhost:61000/?story=jsx--example), you'll notice that it's impossible to click below the BlockNode in the rich text view to continue writing content underneath:

Using the diffSourcePlugin, you're able to click away to the raw markdown view to add a newline/write some text, but it would be great if the rich text editor was a little more flexible in this regard. Not exactly sure how to solve this, perhaps adding a trailing newline would work in most cases, or another way to insert the cursor after a component.

Agreed, that's not perfect. One thing which I've taken into account is that, if you click in the JSX component and you press down arrow, a new paragraph is inserted below it. Another thing that can be done is to automatically insert a paragraph when a JSX node is inserted as the last child. However, the auto-trimming of the markdown will negate this.
I will give this some more thought.

I got this fixed at some point, if the last node is special, an empty paragraph is kept.


Is there anyway to access/invoke dte command from out-of-process extension?

I search the out-of-process extension docs without finding a way to tell visual studio invoke command.
I could invoke command with a dte object like dte.ExecuteCommand("some command", "args in string") with the in-process extension, but in-process is .net framework only.
Please, docs are needed if we can manage to do it.

Thank you for your feedback!  Can you tell us more about how programmatically supporting invoking a command would benefit your extension scenarios?  For example, would you want to programmatically invoke an existing platform command (perhaps VSCT based), or a remote command that you create for your extension?  Instead of being able to invoke any command, would it be the same if we were to offer APIs that did what the command does?  For example, instead of allow you to invoke the Save command, we offer an API that you can call to Save a document.  What that suit your needs better?

Greetings.
More precisely, the command is "DebugAdapterHost.Launch /LaunchJson:{json_file_path}", we are building a custom debugger extension for visual studio.
The debugger client itself is a .NET 7.0 standalone application.
However .NET is not compatible with .NET framework, though we managed to pack the debugger client and the visual studio extension into one vsix, but is in a wonky way. Will be great if these projects could be unified under .NET 7.0, so we try out the out-of-process extension solution. But we haven't find a way to send the debug adapter launch command to visual studio with out-of-process extensibility.
If we have API to invoke the command above, I'd love to dig more into it. Otherwise a wrapper like "context.extensibility.DebugAdapterHost" is acceptable for adding to the extensibility? Could use it like
var dap = context.extensibility.DebugAdapterHost;
dap.Launch(json_path);

Hi @AlexeiNaabal, are you calling in to DebugAdapterHost.Launch command to start a debug session for a specific project or the solution as part of your own command in VS? Thanks!

@BertanAygun Greetings.
We use the debugger to debug arbitrary mono project, with the mono soft debugger and soft debugger wire format
The simplified workflow is like, first the mono project will be launched with a listening port for further debugger connection,
then we invoke the DebugAdapterHost.Launch command, connecting the visual studio debug adapter with the debugger,
finally the debugger connect to the mono project using the listening port, we can send debug event like setbreakpoints and
receive debug event like hit breakpoints then.
So it is not for debugging a specific project, we can debug arbitrary mono application launched with a debug listening port.
I'm not sure what "the solution as part of your own command in VS" means, could you explain it a little?

While I think that first class support for commands is great, I think that's an impossible goal to achieve since VS will never know about all commands beforehand.  I think providing an API method similar to the current way, ie dte.ExecuteCommand("some command", "args in string") is necessary to be able to cover all scenarios.  Restated: for common/built-in VS commands I think the goal should be to provide first class support, but for all others there needs to be a way to invoke any command.  Just my 2 cents ;)

We're moving feature suggestions and requests over to our Developer Community site so we can track them better.
This issue has been moved over to this ticket: [VisualStudio.Extensibility] Support programmatic command execution. Please continue the discussion in the new ticket.

We're moving feature suggestions and requests over to our Developer Community site so we can track them better.
This issue has been moved over to this ticket: [VisualStudio.Extensibility] Support programmatic command execution. Please continue the discussion in the new ticket.


improve room_avatar function

RoomAvatarResponse is a type of url from hosie-server. So, we should change FileBox type.

Thanks for your code review. Let's go ahead to other modules.


[Question]: why is lineHeight not responsive?

Hello,
I really love this library, I have been using it on all my projects however I always find myself making a responsive lineHeight.. very useful and goes very well with fontSize={[...]}. Usually you need different lineHeights for different breakpoints so am I miss understanding something?
Thanks for everything, let me know if i can help with a PR!

@brandtnew i simply use responsiveStyle
const lineHeight = responsiveStyle({
  prop: "lineHeight",
  cssProperty: "lineHeight"
})

Related jxnblk/rebass#377

It's not something I commonly use, but I'd accept a PR to make the lineHeight function responsive

i can see this being an issue if you're not using unitless line heights. but in that case, why?! :)

@jessehart I often follow designs from Sketch files that have very specific line heights on desktop and mobile, and i found that to get it pixel perfect I was better off simply copy pasting the "PX" value and adding breakpoints rather than trying to estimate it with a unitless line-height. Regardless, I think this lib should provide the option.
@jxnblk sounds good, ill see what i can do later today!


Use this if you have Phosphor Problems

https://www.curseforge.com/minecraft/mc-mods/mixinbootstrap

However, there might be a chance there an OpenGL error or maybe it's my modpack


Add script of firmware update process

There seemed to be some confusion on exactly what needed
to be run to update the firmware. In order to help clarify I've
added a list of the commands needed.
Amos King @adkron<EMAIL_ADDRESS>

This is absolutely needed. Thanks @adkron!


Enable keeps

This PR enables keeps, since our clients should reliable enough now.
I currently don't really like the naming "keep left onto ROAD_NAME". I think in this case only on would be better, but this would require a special case for keeps, so I am not sure if this is worth the change, whereas the German translation with auf would be fine.
We also need a symbol for the front-end.

Well until lanes support! :slightly_smiling_face:

This PR enables keeps, since our clients should reliable enough now

We have to postpone this minor change as only recent versions of the clients are reliable enough.

Ok, sure, no problem :).

Ok, we can merge this here now. @boldtrn would you mind update to the latest master? Sorry for the hassle ...

Ok, we can merge this here now. @boldtrn would you mind update to the latest master? Sorry for the hassle ...

Done :)

I think we also need images for keep :) !
https://graphhopper.com/maps/?point=49.464164%2C11.248755&point=49.460203%2C11.245108

I think we also need images for keep :) !

Yes I know, but I don't know where the GraphHopper images come from or how to produce them? For Kurviger we use this image. I like it and it's CC0. We will also need a u-turn image.

We will also need a u-turn image.

Note: this would probably need to be without arrow, since the instruction is generic "Make a U-turn".

but I don't know where the GraphHopper images come from or how to produce them

From here created via inkscape from existing arrows (as svg converted to png)

Have added the necessary images

Do you have a (quick) example where a U turn is created?

Any inner city one way primary or secondary should work. Place one waypoint at one side the other at the other side or look at the PathTest example.

Do you have a (quick) example where a U turn is created?

Sorry I just briefly commented yesterday from my mobile device. This would be one example. Finding them is actually quite easy, as they are usually generated in cities on a bigger primaries or secondaries.


flake-20230709-1: mesa, sway, wlroots, yuzu-ea

:fish: What?
Bump our packages
:fishing_pole_and_fish: Why?
We do this (almost) daily.

Yuzu needs a newer version of vulkan-{header,loader} again. I'll resurrect vulkan-*-next after my nap.


Visual shader translates in generated shader

Godot version:
aad4d8648b4593b5edb479e85984730770e77c70
OS/device including version:
OSX 10.14
Issue description:
The visual shader is translated in comments and then saved in the shader. Should autogenerated shaders translate?
https://github.com/godotengine/godot/blob/aad4d8648b4593b5edb479e85984730770e77c70/scene/resources/visual_shader.cpp#L247-L256
https://github.com/godotengine/godot/blob/aad4d8648b4593b5edb479e85984730770e77c70/scene/resources/visual_shader.cpp#L1602
Translations should not be in auto-generated shader code. The generated code should be the same between different languages.
This is bad because it causes merging flip-flops.
This behavior is also not standard across every visual shader.
Steps to reproduce:
Use a translated language and create a shader.

Yeah, seems like a bug


[BUG]

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
the problem is that it is not working starting bloxstrtap

Can you provide a Bloxstrap log file?

I'm assuming that details were provided in #1262


Pressing enter inside an input on a multi-step form with a submit handler will submit the form, rather than advancing it

Reproduction
https://formkit.link/980e8770e49ab3e4adc6997272e76cda
Describe the bug
Pressing enter inside an input on a multi-step form with a submit handler will submit the form, rather than advancing it.
This happens on any of the steps.
A hacky workaround to intercept this in your submit handler can be done like so (assuming you have two steps, modify it if you have more than that):
const submitForm = async (fields, handlers) => {
  console.log("submitForm", fields)

  let lastPage = true;

  handlers.children[0].walk(child => {
    if (child.name === "account_info") {
      // Increment to the next page if the user pressed enter on the first page.
      if (child.context.isActiveStep) {
        lastPage = false
        child.context.handlers.next()
      }
      console.log("account_info", lastPage, child.context)
    }
  })

  if (lastPage) {
    // rest of your submit handler
  }
}

Do note that this workaround does not focus the first input inside your next page, and when fixing this bug I think that will also need to be fixed explicitly, code-wise.
Environment
• OS: Linux
• Browser Firefox, Chrome
• Version: 0.16.x any, 0.17.x beta

I am also not able to reproduce #601 on 1.16.4 or 1.17.x, but it seems somewhat related.

Slightly more hacky workaround that actually focuses the input.
  handlers.children[0].walk(child => {
    if (child.name === "account_info") {
      // child.context.handlers.incrementStep(1, child.context)()
      // Increment to the next page if the user pressed enter on the first page.
      // This is necessary because
      if (child.context.isActiveStep) {
        lastPage = false
        makeUserInputActive = true
        child.context.handlers.next()
      }
    }

    // Focus the next text input if the user presses enter
    if (child.name === "user_info" && makeUserInputActive) {
      setTimeout(function () {
        const el = document.getElementById(child.context.node.children[0].props.id)
        el.focus()
        el.click()
      }, 20)
    }
  })

The reason why it does submit, is because your submit at the step 3 is in the DOM when you click, even tho you're only looking at the first step visually.
So instead of using a submit use a button and programatically call submit on the form node https://formkit.link/2eaa3e5ea4d5bee480a3b905fe67ddb4

Thank you! That solves the actual "bug", it would probably be good to make it more explicit in the plugin's docs.
It would be nice to have advancing form steps when the user hits enter implemented properly, rather than the hacky workaround, but that would be more of a feature request on it's own.


Support for type hints

Added type hints for all methods.
In addition, variables whose type cannot be recognized automatically have been annotated. This applies to variables of type list. An explicit annotation of the exact list type (example: list[str]) is clear

Thank you!