Extract spreadsheet ID from URL if provided

Resolves #2709
Change-Id: I45fe7ccd74457413669d6caf37d3453340e23b89

@mit-cml/core-reviewers This technically solves #2709, but the challenge is that it does not follow an expectation that if I set property X and then read property X that it is the same value. An alternative, but slightly more complicated approach, would be to store the value as a separate field and return that rather than using spreadsheetID as potentially both ID and URL.


SortedIndex baseline implementation

This PR introduces a new Sorted Index that keeps an actively sorted b-tree (github.com/tidwall/btree) for a column of the user's choosing (currently limited to string-type only). The index holds one b-tree that is not copied between transactions (mutexed, but could still violate consistency).
Todos

copy btree on txn.init
add custom "Less" rule for custom sorting
improve index checking loop

Hello @kelindar, I have a few questions regarding next steps to getting a sorted index into the project.

Should the b-tree be copied for each new transaction?
DML speed - each insert/update/delete requires a full scan due to the commit.Reader not differentiating between Insert/Update, and Delete commits not containing the row's data to find the key (which makes sense). How would you recommend speeding these up? This also applied to the index check in SortedRange().

Thanks!

Should the b-tree be copied for each new transaction?

I'm not sure, ideally not because it will slown down the transaction. But then, what exactly happens if another txn is updating the b-tree while you're iterating over it? (or even when you're updating while iterating).

DML speed*

Isn't b-tree already O(log n) for the lookup?


Bug when toFill matcher try to clear input of type number

🐛 Bug Report
toFill matcher fails when input type is number
To Reproduce
<input id="input" type="number">

await expect(page).toFill('#input', '2018')
await expect(page).toFill('#input', '2018')

Expected behavior
Clear value before fill new value
Technical details
The error occurs on selectAll method. When line 8 is executed it through this error:

Then the code: elementHandle.focus() is executed but it seems that content is not selected.
I confirm that this code on my chrome / firefox console, does not work either:

I'm runing test on chrome headless using jest-puppeteer 5.0.3
Possible alternatives
await page.click(selector, {clickCount: 3})
await page.keyboard.press('Backspace')

This should be fixed in v5.0.4 :tada:

I'm still encountering this issue using 10.0.1.  Regression perhaps?


new version 4.73

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Add PHP7.4 support

Hello, is it possible for PHP7.4 support to be added... it's an awesome library, and i have a legacy code which still uses php7.4 and i'd really love if we had a 7.4 support

@Ghostscypher unfortunately I would have to remove all promoted properties, scalar type hints, and any other PHP8 features. Basically it would be a separate major branch and that's beyond my capacity to be able to support.
You are welcome to fork and patch as a 7.4 version.


python311Packages.aemet-opendata: 0.4.7 -> 0.4.8

Diff: https://github.com/Noltari/AEMET-OpenData/compare/refs/tags/0.4.7...0.4.8
Changelog: https://github.com/Noltari/AEMET-OpenData/releases/tag/0.4.8
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 289953 run on x86_64-linux 1

2 packages marked as broken and skipped:

python312Packages.aemet-opendata
python312Packages.aemet-opendata.dist

1 package failed to build:

home-assistant-component-tests.aemet

2 packages built:

python311Packages.aemet-opendata
python311Packages.aemet-opendata.dist


GoogleMaps.h file not found from GMUClusterManger.h while archiving xcode project

Everything works perfectly on the simulator and when building on devices from xcode however this error keeps persisting when I archive my project. My bridging header path is indicated to the correct one, I don't see how i can resolve the issue

Can you please upload a minimal reproduction case to GitHub so that I can investigate?

I'm getting this same issue whenever I try to build my project with Google Maps. I used the instructions to build for Swift here: https://github.com/googlemaps/google-maps-ios-utils/blob/master/Swift.md.
I'll upload a reproduction case when I can.

Hi,
I am also getting this error (File not found, see screenshot) when trying to Build, my pod file has pod 'GoogleMaps', not sure what is still missing, please advice.

I'd still appreciate a repro case. Thanks!

Getting exact same error after updating pods on exact same place

was encountering this issue earlier on, would like to share how I found and fix the issue.
Chances are your GoogleMaps dependency is not installed properly during pod install process, which you can verify by tapping on the "Pods" project within  your Xcode, then expand "Pods > GoogleMaps", you should see a few folders and files under GoogleMaps. If you don't, that means it's not installed properly.
I then updated my Podfile to replace pod 'GoogleMaps', '2.5.0' to pod 'GoogleMaps' - remove the fixed version, which will install latest one, v2.7.0 as of this comment date. Then I did these:

pod repo update
pod install
clean the project and re-build again.

hope it helps.

Started to get this error when updated from Xcode 10.1 to 10.2

Started to get this error when updated from Xcode 10.1 to 10.2

Same here. Had to rollback to the previous verison of GoogleMaps to keep it works.

I am getting the same error after I updated from XCode 10.1 to 10.2.....?....Any workarounds for this....?

Started to get this error when updated from Xcode 10.1 to 10.2

are you able to solve this.....?

Same here GoogleMaps.h still not found :(

Is this still an issue for folks?

Closing this issue. Please reopen and specify repro steps if it still occurs.

Im having this same issue

@movezapp
What package manager are you using? Can you provide steps to repro?


Lost membership feature

Affected platform
Launcher
Describe the bug
I'm so delighted this game is back,. Thank you.
Is there a way to play this game as a member - I was playing as a member up to yesterday, but now I"m just getting told that my password is incorrect.
Expected behavior
I'd love to get the feature back. And I'd be happy to pay a member ship fee.
Additional information
That's all - thanks

Hi! Thanks for the report.
This is not a bug - we are in the process of introducing registration feature, which will allow you to set passwords for accounts. Yesterday we have re-enabled the password verification.
I will update the READMEs shortly.
This change allows players to fully own their wins and scores, ensuring that they are tied to your account alone.
We are posting updates about such changes in our Discord server in which you can register by using our bot.
Best regards

FYI the prompt that password is incorrect is shown both when the password is actually incorrect and when the username you're using does not exist yet.


Add issue template

Can we please add an issue template to the repository?
I want it to be as short as possible! The only things I can think of to add (at this point) would be the following
Use issues for anything. They can be for features, questions, ideas, or just to say hi.
We will close issues we think no longer require work, and we might change issue titles or descriptions to help other users find what they need. We love you, and think your issue title is great, but we sometimes know what the underlying bug is, and can relabel it accordingly.

If you submit a bug, include any information you think is relevant to recreate, or analyze.

**But most importantly... share your version (git commit sha) in your issue!**

Closing because of #230 and #232


Added docs

I added the docs that I generated with jazzy @jpotts18 .

@davepatterson Are you interested in being a contributor on this project? I am not longer as active in Swift as I used to be and would like to see it continue. If you are interested please comment in #81. You seem to have a really good understanding of the whole project due to your extensive documentation.

#89 Replaces this.


`formatter=': Formatter 'NyanCatFormatter' unknown

After using nyan-cat-formatter there is an error:
i use rspec-core-2.0.0.beta.12
/rspec/core/configuration.rb:183:in `formatter=': Formatter 'NyanCatFormatter' unknown -  maybe you meant 'documentation' or 'progress'?. (ArgumentError)
Greetings

rspec 2.0.0 is probably too old to use this with. Try upgrading your rspec version.

Have you tried rspec 2.0.0?  I believe this error is specific to rspec 2.0 beta.


Support PostgreSQL's FETCH clause

Use case:
Certain PostgreSQL-compatible tools send queries with a FETCH clause to the server:
SELECT *
FROM usertable
ORDER BY ycsb_key
FETCH FIRST 2 ROWS ONLY;

In this particular case, the query originates from the YCSB benchmark suite.
On PostgreSQL, the query succeeds. On CrateDB, the query fails as the FETCH clause is not supported.
Feature description:
PostgreSQL supports a FETCH clause as part of its SELECT command:
SELECT [...]
    [ LIMIT { count | ALL } ]
    [ OFFSET start [ ROW | ROWS ] ]
    [ FETCH { FIRST | NEXT } [ count ] { ROW | ROWS } { ONLY | WITH TIES } ]

According to the documentation, it's part of the SQL standard:

SQL:2008 introduced a different syntax to achieve the same result, which PostgreSQL also supports.

Except for the WITH TIES part, the same functionality can be achieved in CrateDB via a LIMIT clause. But special treatment is needed in client tools like YCSB that make use of FETCH to restore compatibility with CrateDB.

I'd like to take a look at this.

Opened a new issue  for supporting the WITH TIES.


hhsearch problem, _cs219.ffdata, Could find neither hhm_db nor a3m_db!

Dear users,
For some time I'm fighting with af2 and hhsearch. Let me define the problem:

ERROR
hhsearch -i ./sylwia1.fasta -d /alpha2/xukui/alphafold/pdb70

09:56:43.878 INFO: Search results will be written to ./sylwia1.hhr
09:56:43.878 ERROR: Could find neither hhm_db nor a3m_db!

SUCCESS
hhsearch -i ./sylwia1.fasta -d /alpha2/xukui/alphafold/pdb70/pdb70

09:57:06.444 INFO: Search results will be written to ./sylwia1.hhr
09:57:06.533 INFO: ./sylwia1.fasta is in A2M, A3M or FASTA format

This is with the system hhsearch in version 3.2.
So I've decided to compile from the source version 3.3. (the same with conda)

ERROR
~/hh-suite/build/src/hhsearch -i ./sylwia1.fasta -d /alpha2/xukui/alphafold/pdb70/

10:00:39.455 INFO: Search results will be written to ./sylwia1.hhr
10:00:39.455 ERROR: In /home/lukasz/hh-suite/src/ffindexdatabase.cpp:11: FFindexDatabase:
10:00:39.455 ERROR:   could not open file '/alpha2/xukui/alphafold/pdb70/_cs219.ffdata'

SUCCESS
~/hh-suite/build/src/hhsearch -i ./sylwia1.fasta -d /alpha2/xukui/alphafold/pdb70/pdb70

10:02:30.372 INFO: Search results will be written to ./sylwia1.hhr
10:02:30.459 INFO: ./sylwia1.fasta is in A2M, A3M or FASTA format
10:02:30.463 INFO: Searching 80799 database HHMs without prefiltering

In the run_docker.py I have this:
# Path to the PDB70 database for use by HHsearch.
pdb70_database_path = os.path.join(FLAGS.data_dir, 'pdb70', 'pdb70')

[I've got the same errors running alphafold with docker after 10 min of computation]
So, the question is, what should I change in the docker file to make it work....

The path in run_docker.py is correct - it has to include not only the directory where the HHSearch database is, but also the common filename prefix shared by all of the 6 HHSearch database files. That is why we append the pdb70 twice.
Is it possible you are getting slightly different error when running AlphaFold, i.e. the error when running AlphaFold is not caused by a wrong HHSearch database path?

I0215 13:06:02.384482<PHONE_NUMBER>97568 run_docker.py:247] - 12:06:02.376 ERROR: In /tmp/hh-suite/src/ffindexdatabase.cpp:11: FFindexDatabase:
I0215 13:06:02.384616<PHONE_NUMBER>97568 run_docker.py:247]
I0215 13:06:02.384788<PHONE_NUMBER>97568 run_docker.py:247] - 12:06:02.376 ERROR:  could not open file '/mnt/pdb70_database_path/pdb70_cs219.ffdata'
permission problem, chmod a+r......


Please backport CVE-2020-8116 security fix to 4.x.

Based on the severity of CVE-2020-8116 and the fact that 4.x is still very commonly used as a dependency, I would like to kindly request for the fix to be backported to 4.x and released as (presumably) v4.2.1.
Would this be possible? Many thanks in advance.

+1
Please consider reopening #61 . The v4 release line may be old but it's still used by many packages and is installed millions of times each week.
As a CVSS-high-severity vulnerability, we have had no option but to manually resolve to v5, introducing breaking changes to dozens of projects

I was trying to open a pull request for https://github.com/sindresorhus/dot-prop/compare/v4.2.0...Trott:sec-fix and came across this. I know it's an annoyance and that Node.js 6 and 8 are end-of-life, but that means users of upstream dependencies like serverless have to wait for a breaking change to get the security fix--even if they are running the latest Node.js and have been security-conscious otherwise. And then they have to endure the anxiety of a major release upgrade instead of a security patch. And it's not the user's fault. They've been staying up-to-date, etc.
I totally get the argument for not patching old release lines generally, and you certainly don't owe it to anyone, but if you can be persuaded to release a 4.2.1 in this particular instance, I think it would be a good thing.
And if not, hey, thanks for reading anywa.

we're going to have to patch this for npm@6 so I'm proposing the idea of maintaining a legacy fork in order to be able to fix vulns warnings such as this for legacy release lines, it might be an ephemeral fork though it should stay around (in terms of receiving active maintenance) for as long as npm@6 is still around 😊  To get it:
npm install dot-prop@npm:dot-prop-legacy@latest

@sindresorhus I'd much prefer consolidating maintenance so let me know if you're open to have folks publish these versions over here in dot-prop itself instead of a fork 😄 but it's fine otherwise.

Thank you @ruyadorno for creating the legacy fork! It seems to already be very popular (52,171 downloads in less than 2 days).

Sure. I didn't anticipate how many problems this would cause. I've published https://github.com/sindresorhus/dot-prop/tree/v4 as 4.2.1 (on the legacy dist tag).

That's awesome! ❤ Thanks Sindre!

@sindresorhus I noticed the tag hasn't been pushed to the repo, maybe you want to push that in the future, just in case

Awesome!!! Big Thank You!


DOC: special: remove jn from the refguide (again)

This was done previously in gh-3684, but it crept back in
somehow. Closes gh-7741.

Failures appear to be https://github.com/scipy/scipy/issues/8016.


Debug Training Script

Debug training script in repo

Bug has been fixed. Should we add sample submission to this https://github.com/Imageomics/HDR-anomaly-challenge-sample/tree/main

Bug has been fixed. Should we add sample submission to this repo

Yes, please update it.

Bug has been fixed. Should we add sample submission to this repo

Yes, please update it.

Added


Feature Request: AddPeer

It'd be awesome if this SDK had a WebTorrent style AddPeer feature for adding peers manually.
It'd be extra awesome if it accepted simple-peer instances too (like WebTorrent) for WebRTC peers.

Ooo, that'd be awesome.
I think it'd be nice to have an API added to corestore-swarm-networking which accepted a duplex stream for connections (there's a private one already), and then expose that API inside the SDK.
From there you could use anything that provides a duplex stream including webrtc based stuff.
PRs would be very much welcome!


[bug] not playing well with discovering unittests

Currently all the unit tests use the paradigm cd tests; python -m unittest discover ., however a perfectly reasonable alternative is python -m unittest discover tests. However, the latter fails with error messages like
Traceback (most recent call last):
  File "/home/runner/work/pympipool/pympipool/pympipool/backend/mpiexec.py", line 90, in <module>
    main()
  File "/home/runner/work/pympipool/pympipool/pympipool/backend/mpiexec.py", line 46, in main
    input_dict = interface_receive(socket=socket)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/miniconda3/envs/test/lib/python3.11/site-packages/pympipool/shared/communication.py", line 147, in interface_receive
    return cloudpickle.loads(socket.recv())
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'test_meta'
Error: The action has timed out.

As can be seen in #238 Unittests_by_path.
To the best of my understanding, this is a result of these lines in the backend:
https://github.com/pyiron/pympipool/blob/2c616aced49e8d513f3fd18aefda6f2d0d41f4e8/pympipool/backend/serial.py#L22-L26
Since in the latter case "." is the parent path from which discover is invoked, and not the path where the actual test files reside.
This can be fixed by adding the test directory(ies) to the path (also demonstrated in #238 Unittests_by_path_with_env and Unittests_by_path_with_pythonpath which both run fine), but it still seems to me like something that should be fixed at the source rather than patched over in github workflows. In particular, I worry that if unittest discover has this sort of problem, other ways users invoke the executors might be similarly bugged.
It's not clear to me whether or not there is a good solution to this problem.
Aside: the comment in the snippet above says this is necessary for flux, but if this is really the relevant line for this issue that would imply it is important for all the executors, or?

@jan-janssen do you have any insight here? The solutions I see, in decreasing order of desirability, are:

Change the centralized CI to accommodate pympipool (eg by always adding a bunch of directories to the python path)
Abandoning the centralized CI altogether for any repo using pympipool executors
Not use pympipool executors

But frankly even the best of those is not particularly nice.
It's not clear to me how the insertion of "." to the path could be made universally robust, but this would be the "right" solution if it's possible.

@liamhuber I am in the same position, I am not aware of a way to transfer the classes. We could try to always pickle by value rather than by reference, but that is not as computationally efficient, so I do not want this as the default. Also changing the tests sounds annoying to me. Maybe somebody can take a look what kind of references cloudpickle receives when unittest is executing a test, we could try to recognise classes from unittest and then always pickle by value.


Sortable snap between elements of different height

Thank you for creating plain draggable!!!
I've got a question: How can i make planDraggable work when elements have different heights?
I've tried adjusting the height of each block, but it makes not difference:
items = elmItems.map(function(elmItem) {
            return new PlainDraggable(elmItem, {
            snap: {
                y: {step: elmItem.getBoundingClientRect().height},
                side: 'start'
            },
            onDrag: function(moveTo) {
                if (!moveTo.snapped) { return false; }
                sort(this, moveTo.top);
                return true;
            }
            });
        });

ITEM-A

            ITEM-B

hello there

ITEM-C

ITEM-D

ITEM-E

https://user-images.githubusercontent.com/29523682/214658186-9c9e4932-7476-4a01-ba02-1eb2f538439e.mp4

Hi @psociety, thank you for the comment.
The step property copies the horizontal line repeatedly using specified intervals that was passed as height.
That is, you did NOT adjust the height of each block. You specified SAME number to all snap points.
See document: https://anseki.github.io/plain-draggable/#snap

You can specify each snap points for different height.
For example: https://jsfiddle.net/x0aw3vzh/

Thank you for the explanation and the example!
I will study it so i can properly apply PlainDraggable :)
https://www.youtube.com/watch?v=eG-BOuN41vU

:smile:


Fix  #85 - callback associated with button in Alert.alert not working

Hi, i try to fix alerts callback and it's work now, but i don't understand some variables in RCTAlertManager.m:
NSMutableArray<NSAlert *> *_alerts;
NSMutableArray<RCTResponseSenderBlock> *_alertCallbacks;
NSMutableArray<NSArray<NSString *> *> *_alertButtonKeys;

So if you can explain for what it, i'll complete it =)
Thanks

Thanks for fix. This comes straight from React Native, I barely touched it. Alerts in RN can have multiple buttons (like OK, Cancel or Try Again, Ignore), thus each button should have callback. See https://facebook.github.io/react-native/docs/alert.html

@ptmt Should i clear code from unused variables ?
How to fix travis checks ?

Don't worry, Travis is on me, it needs update from upstream.


ignoreDirectoryPattern have unexpected behavior

ignoreDirectoryPattern ignore files in subfolders in the directory but not files and create/delete subfolder actions.
MacOS.

A PR has been created: https://github.com/mikeal/watch/pull/148


Support sampling config in network profiling

Codecov Report

Merging #171 (d7e6451) into master (602ebe5) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head d7e6451 differs from pull request most recent head b93f732. Consider uploading reports for the commit b93f732 to get more accurate results

@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   26.20%   26.20%
=======================================
  Files          22       22
  Lines         458      458
=======================================
  Hits          120      120
  Misses        328      328
  Partials       10       10

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Sedivy/#6 blueprints

Following merged PRs but for PROD
Will need to be deployed together with https://github.com/hubmapconsortium/gateway/pull/243

Replaced by https://github.com/x-atlas-consortia/ubkg-api/pull/19


fix: hard-coded chinese

close https://github.com/cloudtty/cloudtty/issues/286

@youhonglian thanks for doing this.
/lgtm


How to !

Hi dear friend
How did you get your PHP laravel project into a Desktop ? The tool you used could be shared with us. Thanks.

This PHP code is just the backend, the UI desktop is using an Angular  and Electron.


STYLE: Use bit_cast to convert random seeds from uint32_t to int32_t

Instead of doing *reinterpret_cast<const int32_t *>(&seed), which appears
more complicated.

We might consider static_cast<int32_t>(seed) rather than bit_cast<int32_t>(seed), in these two cases. With C++20, static_cast<int32_t>(seed) is guaranteed to behave exactly like  std::bit_cast<int32_t>(seed): it will do the conversion "bit by bit".
With C++14, the behavior of static_cast<int32_t>(seed) is officially still "implementation-defined", in case of overflow. However, in practice it will just behave the same as bit_cast<int32_t>(seed) (but possibly faster).
For details, see the comments by Jonathan Wakely at https://github.com/isocpp/CppCoreGuidelines/issues/1517#issuecomment-1114564409
So what do you think in this case, bit_cast or static_cast?

To restate the obvious:

The problem with reinterpret_cast is that, theoretically, a pointer to uint32_t might not be a legal pointer to int32_t; e.g., if for some unfathomable reason the compiler chose different rules for alignment such as the former has to have an address that is multiple of 4 but the latter has to be a multiple of 16.  I estimate the probability of this problem actually arising in practice as somewhere between zero and never.
The problem with static_cast is that, theoretically, prior to C++20, a uint32_t value that is in excess of MAX_INT32, when cast to int32_t, could be set to, say, MAX_INT32, rather than having its bit pattern interpreted as a negative int32_t.  I estimate the probability of this problem actually arising in practice as a little bit higher, perhaps between 5*never and 10*never.
The problem with bit_cast is that it might use something slower, like memcpy, if the compiler (or our substitute implementation) can't figure out that it should instead be implemented using, effectively, reinterpret_cast or static_cast (because on that system it is already verified that these implementations actually work).

I'd use bit_cast.  I can't imagine that this will ever be a performance issue.  If speed somehow becomes an issue in some circumstance then we can try to use some template magic with bit_cast to implement it as static_cast when that is appropriate (with a slew of static_asserts to verify that it is doing what we want).

Thanks for your reply, @Leengit First of all, avoiding undefined behavior is not merely a theoretical problem. The optimizer might do all kinds of clever optimizations, based on the assumption that the program does not have undefined behavior. For example, GCC optimized away the if (ptr == nullptr) in the following code, just because it assumes that int val = *ptr has no undefined behavior:
int GetValue(int* ptr) {
    int val = *ptr;
    if (ptr == nullptr) return 0;
    return val;
}

https://godbolt.org/z/jo9693Was
However, you're right, apparently this particular reinterpret_cast does not have undefined behavior, as I just understood from https://github.com/isocpp/CppCoreGuidelines/issues/1517#issuecomment-1114830775 (A. Jiang) as well, referring to https://eel.is/c++draft/basic.lval#11.2
So apparently it's just a matter of style  😺 My preference is still to replace the reinterpret_cast, one way or the other, as reinterpret_cast is often frowned upon. With full C++20 support I would prefer static_cast. For now, itk::bit_cast would also be OK to me.

The optimizer might do all kinds of clever optimizations, based on the assumption that the program does not have undefined behavior.

A concrete example related to the present case would be great if you have it!  I am thinking that in
unsigned int
f(int i)
{
  unsigned int u = static_cast<unsigned int>(i);
  if (u > INT_MAX)
    return 0;
  return u;
}

there are 0 compilers that will optimize away the if statement on the premise that it is true only when the previous statement is undefined behavior.

there are 0 compilers that will optimize away the if statement on the premise that it is true only when the previous statement is undefined behavior.

@Leengit But in your example, I don't see undefined behavior either. static_cast<unsigned int>(i) should be well defined, even when i itself is negative. Right?

With C++14, the behavior of static_cast<int32_t>(seed) is officially still "implementation-defined", in case of overflow.

I should certainly do so 😺 So I hope I did.
auto maxUint = static_cast<unsigned int>(-1); // OK: UINT_MAX
auto i = static_cast<int>(maxUint); // Implementation-defined with C++14, just -1 with C++20
auto f = reinterpret_cast<const float&>(maxUint); // Undefined behavior

Right?  https://godbolt.org/z/rTYedj61v

I should certainly do so smiley_cat So I hope I did.

Thank you for the clarification.  I missed that the first time.


Make documentation and fix issues with self-distance array python layer

Fill out documentation and make some changes to the self-distance array code which was returning NXN instead of N*(N-1) // 2

Hello @hmacdope! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file distopia/tests/test_distopia.py:

Line 194:5: E303 too many blank lines (2)
Line 208:5: E303 too many blank lines (2)


Adding liberty plugin to init.gradle failing.

Anyone got the liberty plugin working from init.gradle?
Thanks,
H
$ cat ~/.gradle/init.gradle
allprojects{
buildscript {
repositories {
mavenCentral()
}
dependencies {
classpath 'io.openliberty.tools:liberty-gradle-plugin:3.0'
}
}
apply plugin: 'liberty'
}
$ gradle libertydev
Starting a Gradle Daemon (subsequent builds will be faster)
FAILURE: Build failed with an exception.

Where:
Initialization script 'C:\Users\hanym.gradle\init.gradle' line: 11

What went wrong:
Plugin with id 'liberty' not found.

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 6s

I found if I applied the plugin as follows (with the implementation class) it worked. Can you verify this fixes your issue?
initscript {
   repositories {
      mavenCentral()
   }
   dependencies {
      classpath 'io.openliberty.tools:liberty-gradle-plugin:3.0'
   }
}
allprojects {
  apply plugin: io.openliberty.tools.gradle.Liberty
}

Looks like this may be a known issue with Gradle.
https://github.com/gradle/gradle/pull/9594
https://github.com/gradle/gradle/issues/1322

works. Thanks.


Can't comment on changeset via OSMCha

I'm submitting a bug report
Brief Description

I'm trying to send a changeset discussion to someone regarding their edit via OSMCha and got this error.

What  is the current behaviour, (attach relevant screenshots) ?
Got warning message "It was not possible to post your comment." and message not sent.
What  is the expected behaviour ?
I can send a changeset comment/message directly via OSMCha
When does this occur ?
This is my first time got this error, but my colleague reported they observed the same issue since couple days
How do we replicate the issue ?

Open one of changeset
Send a messaage to the editor
Got the error "It was not possible to post your comment."

Please tell us about your environment:

Firefox 125.0.3 (64-bit) Windows 11

Apparently logging out and back in will resolve the issue for you: https://github.com/OSMCha/osmcha-frontend/issues/720#issuecomment-1997663273.


The Ability to Specify Image Sequence Frame Range

Firstly, thank you for creating MRV2. It's amazing!
I searched the MRV2 documentation and could not find any reference to the ability to specify an image sequence frame range.
It would be helpful to be able to launch mrv2 on the linux command line with a specified image sequence, start frame and end frame.
This could be implemented as command line options.
e.g. to start on frame 100 and end on frame 200, with an EXR image sequence that's padded to 5 digits:
mrv2 -s 100 -e 200 myImageSequence.#####.exr
Alternatively, it could be specified as part of the image sequence character string itself:
mrv2 myImageSequence.#####.exr[100-200]

You can already do it, but it is a tad less intuitive as it uses OpentimelineIO time ranges, like:
mrv2 -inOutRange start/end/fps yourseq.0001.exr
For example (in your example this should work):
mrv2 -inOutRange 100/200/30 yourseq.0001.exr

That works.
In that case, could you add documentation to the --help command line option?
Could you also point me to the OpenTimelineIO documentation that describes this in detail?
Thanks

In that case, could you add documentation to the --help command line option?

I'll try to remember to add it.

Could you also point me to the OpenTimelineIO documentation that describes this in detail?

Sadly, the OpenTimelineIO documentation is, shall we say, very sparse and orientated towards programers.  You really need to see the printout of TimeRange in C++ or in Python code.
https://opentimelineio.readthedocs.io/en/stable/tutorials/otio-serialized-schema-only-fields.html#timerange-1

Cool.
Lol.
How do I mark this feature request as closed?
Thanks again.

How do I mark this feature request as closed?

At the bottom of the Add comment section there should be a "Close Issue" button.  If you start typing, there should be another button that says "Close with comment".

I'm only seeing a Comment button, not "Close with comment".

Can you close this issue for me?
Thanks


Apple Silicon MacOS Monterey Missing OS Dependencies

bundle doctor reports the following:
The following gems are missing OS dependencies:
 * nokogiri: /usr/lib/libSystem.B.dylib
 * nokogiri: /usr/lib/liblzma.5.dylib
 * nokogiri: /usr/lib/libobjc.A.dylib

gem "nokogiri"

That's how to reproduce it in the Gemfile.
➜ nokogiri -v
# Nokogiri (1.12.5)
    ---
    warnings: []
    nokogiri:
      version: 1.12.5
      cppflags:
      - "-I/Users/rich/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/nokogiri-1.12.5-arm64-darwin/ext/nokogiri"
      - "-I/Users/rich/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/nokogiri-1.12.5-arm64-darwin/ext/nokogiri/include"
      - "-I/Users/rich/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/nokogiri-1.12.5-arm64-darwin/ext/nokogiri/include/libxml2"
      ldflags: []
    ruby:
      version: 2.7.4
      platform: arm64-darwin21
      gem_platform: arm64-darwin-21
      description: ruby 2.7.4p191 (2021-07-07 revision a21a3b7d23) [arm64-darwin21]
      engine: ruby
    libxml:
      source: packaged
      precompiled: true
      patches:
      - 0001-Remove-script-macro-support.patch
      - 0002-Update-entities-to-remove-handling-of-ssi.patch
      - 0003-libxml2.la-is-in-top_builddir.patch
      - 0004-use-glibc-strlen.patch
      - 0005-avoid-isnan-isinf.patch
      - 0006-update-automake-files-for-arm64.patch
      - 0007-Fix-XPath-recursion-limit.patch
      libxml2_path: "/Users/rich/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/nokogiri-1.12.5-arm64-darwin/ext/nokogiri"
      memory_management: ruby
      iconv_enabled: true
      compiled: 2.9.12
      loaded: 2.9.12
    libxslt:
      source: packaged
      precompiled: true
      patches:
      - 0001-update-automake-files-for-arm64.patch
      - 0002-Fix-xml2-config-check-in-configure-script.patch
      datetime_enabled: true
      compiled: 1.1.34
      loaded: 1.1.34
    other_libraries:
      zlib: 1.2.11
      libiconv: '1.15'
      libgumbo: 1.0.0-nokogiri

Please let me know if you need anything else.  Cheers

@daBee Hi, thanks for reporting this. Is there a functional problem with Nokogiri once it's installed? If so, can you please provide more information on what output you're seeing?

At the moment, nothing is working.  I tripped over this while troubleshooting my stack.  I'm making a test site that I will post somewhere.  Unfortunately, what is above is all I have.  I can't get my websites to work at the moment.  All of this is currently much larger than nokogiri.

OK an update.  StringIO has a default core gem at version 0.1.0.  Their current version is 3.0.1.  The loading procedure is confusing the two somehow...I'm not well versed on this stuff.  Anyway, the devs are on it.
But bundle doctor comes up with this report, which might give an indication that a boatload of gems aren't considering the new front for the Apple world, with Apple Silicon and MacOS 12.0.1 Monterey:
The following gems are missing OS dependencies:
 * argon2: /usr/lib/libSystem.B.dylib
 * bcrypt: /usr/lib/libSystem.B.dylib
 * date: /usr/lib/libSystem.B.dylib
 * ffi: /usr/lib/libSystem.B.dylib
 * ffi: /usr/lib/libffi.dylib
 * json: /usr/lib/libSystem.B.dylib
 * libxml-ruby: /usr/lib/libSystem.B.dylib
 * libxml-ruby: /usr/lib/libxml2.2.dylib
 * murmurhash3: /usr/lib/libSystem.B.dylib
 * nokogiri: /usr/lib/libSystem.B.dylib
 * nokogiri: /usr/lib/liblzma.5.dylib
 * nokogiri: /usr/lib/libobjc.A.dylib
 * openssl: /usr/lib/libSystem.B.dylib
 * pg: /usr/lib/libSystem.B.dylib
 * racc: /usr/lib/libSystem.B.dylib
 * rmagick: /usr/lib/libSystem.B.dylib
 * stringio: /usr/lib/libSystem.B.dylib
 * unf_ext: /usr/lib/libSystem.B.dylib
 * unf_ext: /usr/lib/libc++.1.dylib
 * websocket-driver: /usr/lib/libSystem.B.dylib

Same results of nokogiri -v as above.
If this is a large warning about outdated system libraries as dependencies, is there a way of notifying maintainers about this?  I'm on Apple Silicon with the most recent OS.  I find it odd that these gems are relying on some libs that are not there, and have been known to be gone for years now.

@daBee Again, I need to ask: what specifically is broken with Nokogiri? If you can run nokogiri -v then it's likely installed correctly and is able to find all its libraries. Help me understand what's failing?

Side note:

a boatload of gems aren't considering the new front for the Apple world, with Apple Silicon and MacOS 12.0.1 Monterey

I and other contributors have spent many hours working on arm64-darwin support, precompilation, and testing. It feels unkind to hear you imply that we haven't considered this platform.
It may turn out that there's a problem here with the gem that we can and should fix -- in which case we absolutely will do so! But in the meantime please consider that there have been 157,000+ downloads of the arm64-darwin precompiled Nokogiri gem and this is the first time this problem has been reported; and that you have not yet helped us understand what the functional problem is to allow us to reproduce it.

This is definitely not a nokogiri issue, it works great on M1!
If anything, it's a bundle doctor issue. Apparently, the existence of paths printed by otool -L (which bundle doctor uses under the hood) can no longer be trusted to find missing shared libraries. As per Big Sur release notes:

New in macOS Big Sur 11.0.1, the system ships with a built-in dynamic linker cache of all system-provided libraries. As part of this change, copies of dynamic libraries are no longer present on the filesystem. Code that attempts to check for dynamic library presence by looking for a file at a path or enumerating a directory will fail. Instead, check for library presence by attempting to dlopen() the path, which will correctly check for the library in the cache. (62986286)

So unless we can find another way to do it, we should just skip this bundle doctor check on newer MacOS.

Sorry, was unavailable.  Hey I don't doubt effort has been put in.  I'm just reporting what I've found with the software that other people have put their time into.  I have no reason to attack any packages out there, nor would anybody else.  Can you explain how I would want to do that?  If it's not broken, then it doesn't make sense to show up in reports designed to tell people things are missing.  It should only be expected that these reports be reported.

@daBee  I have no doubt that you meant well, thank you for reporting this!
However, I want to encourage you to keep in mind some of the differences between intent (which is your state of mind, how you think and feel) and impact (which is how your words or actions make another person feel).
If I have responded to the facts of your report, and then also tell you how your choice of words impacted me, please understand that I am simply reporting something back to you in an attempt to make our next interaction feel more constructive for everyone involved. My sincere hope is that you hear that feedback as an act of kindness.
Cheers, and thanks again for the report.

My reason for reporting is that I feel it's my duty to report things I find.  If it means I need to bounce over to the Bundle devs, then so be it.  It's another headache avoided for the lot of us when these pop up.  I found it odd that something the size of nokogiri would show up having three libraries reported missing, but had to report it.  I am a scientist, so feelings have little to do with being objective.  My intent was that I was reporting just that, a report.  I don't mean to make people feel uncomfortable at all.  I have no reason, nor time to having bad intentions nor impact on anybody.  Cheers


\Grav\Common\GPM\Response::setReponse() is overridden

Since config setting system.gpm.method is always set by default, the expression $config->get('system.gpm.method', self::$method)on Line 128 always ignores any setting from the class instance, making the setMethod() method futile.
To reproduce, try using setMethod() to set it to 'curl'.
I would provide a PR, but I'm not sure what the desired expression should be. Possibly a non-'auto' value should always take precedence.

I need to go back and dig through this. It should still be pulling the preferred setting from system.gpm.method and only falling back to self::$method if that setting does not exist.  This was done this way for backwards compatibility. if you were running a previous version of Grav where you had 'saved' the old gpm settings without this method attribute.  It would not merge the second level down from the new system defaults.


change ReatT to Double in generated api

This remove use of RealT in favor of Double in generated API code, according to #185
I am not able to test it right now as I encounter linking error on OSX, when compiling samples:
  "_godot_color_set_r", referenced from:
      _godot_gdnative_godot_color_set_r_wrapper3 in libgodot-library-cinterop-gdnative-cache.a(result.o)
     (maybe you meant: knifunptr_godot_gdnative3_godot_color_set_r, _godot_gdnative_godot_color_set_r_wrapper3 )
  "_godot_string_to_int64", referenced from:
      _godot_gdnative_godot_string_to_int64_wrapper691 in libgodot-library-cinterop-gdnative-cache.a(result.o)
     (maybe you meant: knifunptr_godot_gdnative691_godot_string_to_int64, _godot_gdnative_godot_string_to_int64_wrapper691 )
  "_godot_string_char_uppercase", referenced from:
      _godot_gdnative_godot_string_char_uppercase_wrapper708 in libgodot-library-cinterop-gdnative-cache.a(result.o)
     (maybe you meant: knifunptr_godot_gdnative708_godot_string_char_uppercase, _godot_gdnative_godot_string_char_uppercase_wrapper708 )
  "_godot_pool_string_array_invert", referenced from:
      _godot_gdnative_godot_pool_string_array_invert_wrapper232 in libgodot-library-cinterop-gdnative-cache.a(result.o)
     (maybe you meant: knifunptr_godot_gdnative232_godot_pool_string_array_invert, _godot_gdnative_godot_pool_string_array_invert_wrapper232 )
  "_godot_quat_new_with_euler", referenced from:
      _godot_gdnative_godot_quat_new_with_euler_wrapper73 in libgodot-library-cinterop-gdnative-cache.a(result.o)
     (maybe you meant: knifunptr_godot_gdnative73_godot_quat_new_with_euler, _godot_gdnative_godot_quat_new_with_euler_wrapper73 )
ld: symbol(s) not found for architecture x86_64

I have the same behaviour with master-merge branch.
Can you test it on Linux and Windows ? As I am away from home I only have a macbook with me.

I tested on Linux and there i have no problem.
But if I can test on MacOs this evening.
But i guess it does not affect this PR. The fix would have to be together with the issue you created for it.

Yep, this the osx link issue is not linked to this PR. I just mentionned it as I can't test samples from osx.


Asynchronous model saving

So far, when the model is being dumped, the whole process of training blocks and waits until the dump is finished which takes ~30s for simple recurrent models.
It would be nice to dump the model in a separate thread/process in order to speed up this process. However, there are few issues that need to be resolved

Dumping might take more time than finishing one epoch and BestSaverHook might conflict with previous instance
The model is mutable. While dumping, it might (and usually is) modified by the training loop. We probably need to create a deep clone of the model. Where is the model stored (GPUmemory/RAM)? How fast is that?

Removing the critical label as it is not really an issue. At the moment, saving a mediocre model takes a few seconds which happen to be <0.5% of the time spent training.

This is actually a back-end specific issue. cxflow just calls the model save method.
Note.: for cxflow-tensorflow check out https://stackoverflow.com/questions/41192282/is-there-a-way-to-write-tensorflow-checkpoints-asynchronously


merge data-residency-working

Docs Build status updates of commit f8cbeca:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Articles/PartnerDocs/DataResidency.md
:white_check_mark:Succeeded

Articles/PartnerDocs/Images/data-residency-geo-boundaries.png
:white_check_mark:Succeeded

Articles/TOC.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Issue with CAYW scannable-cite format export

Hi,
I am experiencing an issue with pulling scannable-cite citations through CAYW. I have been using zotpick's scripts to open BBT to Scrivener both by using davepwsmith's app and by making my own automation service. (https://github.com/davepwsmith/zotpick-applescript/blob/master/zotpick-scannable-cite.applescript) The CAYW UI opens without any issues and I'm able to pick Zotero items. But in every case, BBT exports the following message instead of exporting the scannable-cite citation:
"CAYW failed: TypeError: item.uri is undefined
Scannable-cite@chrome://zotero-better-bibtex/content/better-bibtex.js:81160:15"
Every other format query seems to work just fine (pandoc, mmd, ...), so I'm guessing this is an issue with the scannable-cite format?
Below I attached a debug log. I would very much appreciate your help!
What I tried:
-accessing the CAYW through terminal (same outcome)
-reinstalling BBT and zotpick scripts (same outcome)
-clearing Zotero cache (no effect)

Application: Zotero 5.0.97-beta.59+abe8c39c5 en-US
Platform: MacIntel Intel Mac OS X 10.16
87XAHELY-euc.zip

Can you install 1904, do that again, and send a new log?

Just updated to 1904, the issue is still present unfortunately. Here is the log.
SUH5RA6U-euc.zip

I know it's still present, this just adds logging.
Is the reporting facility not working properly for you? If you click submit you ought to see the ID presented in red, that will give me the logs. The zip files work, but I have tools that pick up the log based on the id, and those make it easier to create test cases when needed. Not wholly relevant to your case, as I don't expect I will need to add a testcase for this, but if the reporting is broken I'd need to fix it.

Oh very sorry about that. I was able to submit it now, it was greyed out before. ID: DZHAPAVG-euc

strange

Can you try 1906?

Just did that. There is still an error but the error message changed:
CAYW failed: Error: No formatted citation found for zu:0:QPJVRHFM
scannable-cite@chrome://zotero-better-bibtex/content/better-bibtex.js:81168:17
I reshared a log: 6TXF2E5L-euc.

can you get me a new log with 1908?

Here you go. Error message:
CAYW failed: Error: No formatted citation found for “zu:0:QPJVRHFM” in [“zu:6371466:QPJVRHFM”]
scannable-cite@chrome://zotero-better-bibtex/content/better-bibtex.js:81168:17
Log ID: XNZQ3SJV-euc

build 1909 removes the dependency on the ODF-scan plugin being installed.

Great! The export seems to work now, this is the message: { | Berry, 1975 | | | zu:0:ITEMKEY }
But it seems that the item key is not being exported properly?
Log ID: GZ6FNBVE-euc

you are running BBT in test mode. Set translators.better-bibtex.testing to false (which is the default, not sure how it got turned on for you) and you will get the key.

Oh I see. not sure how this happened. I am getting the key now, but there is still an undefined part: { | Berry, 1975 | | | zu:6371466:undefined }
Not sure if this will affect the citation?
Log ID:N7CFKKL9-euc

Just checked and ODT scanner does recognize the citations, so I guess it should be fine?

Actually, the item key that is exported is the same for every item...
And I just checked, although ODF scan recognizes the citations, Zotero is not able to change the format of the citation because "it is no longer in the Zotero Database."

I need to find out why you're getting an undefined.

1913 seems to have solved it. Thank you!!!
Interestingly though, options such as adding page numbers are not getting exported, while this is not the case for pandoc?

1915 should solve that

yes, everything works well now! Again, thank you so much!!


error on set foldexpr

set foldexpr=nvim_treesitter#foldexpr()

set_statement [26, 0] - [27, 0]
  set_item [26, 4] - [26, 39]
    option: option_name [26, 4] - [26, 12]
    value: set_value [26, 13] - [26, 39]
      ERROR [26, 13] - [26, 39]
        identifier [26, 13] - [26, 37]

Note: other values mentioned in :h fold-expr examples also produce errors

Hi, this might be caused by the # symbol, but I am not sure yet.

Hey I can't seem to reproduce this issue in latest master for some reason, could you check that is disapeared for you too.
I added tests to ensure that this behavior is kept though.


feat: Added UDTs for disks and ability to give a custom name to a disk - avm/res/compute/virtual-machine

Description
This pull request adds UDTs for OS disk and data disk. Also, included the option to give a custom name to either disk.
Pipeline Reference

Pipeline

Type of Change

[ ] Update to CI Environment or utlities (Non-module effecting changes)
[ ] Azure Verified Module updates:

[ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] Breaking changes and I have bumped the MAJOR version in version.json.
[ ] Update to documentation

Checklist

[ ] I'm sure there are no other open Pull Requests for the same update/change
[ ] I have run Set-AVMModule locally to generate the supporting module files.
[ ] My corresponding pipelines / checks run clean and green without any errors or warnings

@AlexanderSehr @rahalan
While running tests I got this error which I can't place. It looks good to me, name is optional and it is checked with coalesce and it still expecting the name property. Do you have any idea what this can be?

Implemented PR feedback. Running Actions for tests now.
@rahalan Yesterday I had a capacity error for the Nvidia test. What region do you suggest to set when I get this error again?

Implemented PR feedback. Running Actions for tests now.
@rahalan Yesterday I had a capacity error for the Nvidia test. What region do you suggest to set when I get this error again?

You can't. Just ignore the test. To get it running you need to ask for a quota of the VM type.

Implemented PR feedback. Running Actions for tests now.
@rahalan Yesterday I had a capacity error for the Nvidia test. What region do you suggest to set when I get this error again?

You can't. Just ignore the test. To get it running you need to ask for a quota of the VM type.

Ok will do!
@AlexanderSehr @rahalan How do we deal with key vaults that already exist somewhere in the Azure world? Deployment name could be used with a unique string.

@johnlokerse because of that e have the TOKEN_NAMEPREFIX. Maybe try a different one.

@johnlokerse I can't see the actions in your fork, thus cannot see the workflow run. Can you please check the permissions on that? Thanks!

@johnlokerse I can't see the actions in your fork, thus cannot see the workflow run. Can you please check the permissions on that? Thanks!

My best guess is that the actions are simply disabled.

@johnlokerse I can't see the actions in your fork, thus cannot see the workflow run. Can you please check the permissions on that? Thanks!

My best guess is that the actions are simply disabled.

I don't think so, as a link to the run is at the top of this PR. I only get a 404 when clicking it.

@AlexanderSehr @rahalan I have made several contributions to AVM and once made a mistake which caused some workflows to deploy to my personal Azure environment without me knowing and generating costs. This is why I disable the workflows when I am not working on them.
I have enabled the actions now. I am seeing unreliable test deployments, for example, sometimes I get 404 errors, key vault name already in use, resources that cannot be deleted in the post deployment stage and so on. Every test deployment is different so I can't reproduce it. Still got some work to do before merging 😄

@AlexanderSehr @rahalan I have made several contributions to AVM and once made a mistake which caused some workflows to deploy to my personal Azure environment without me knowing and generating costs. This is why I disable the workflows when I am not working on them.
I have enabled the actions now. I am seeing unreliable test deployments, for example, sometimes I get 404 errors, key vault name already in use, resources that cannot be deleted in the post deployment stage and so on. Every test deployment is different so I can't reproduce it. Still got some work to do before merging 😄

Hey @johnlokerse,
this sadly makes 110 % sense - but - there is good news

Regarding the 'xzy already in use' error I recommend to change the namePrefix secret to something even more ludicrous
Regarding the costs, there is a workflow mentioned in the tip box here - but in short: I highly recommend to run the avm.platform.toggle-avm-workflows.yml workflow, which will essentially allow you to disable/enable workflows in one swift swoop (by default disable all res & ptn workflows)

Otherwise the schedule that runs once a week will indeed eat your credits away like its candy.

@AlexanderSehr @rahalan I have made several contributions to AVM and once made a mistake which caused some workflows to deploy to my personal Azure environment without me knowing and generating costs. This is why I disable the workflows when I am not working on them.
I have enabled the actions now. I am seeing unreliable test deployments, for example, sometimes I get 404 errors, key vault name already in use, resources that cannot be deleted in the post deployment stage and so on. Every test deployment is different so I can't reproduce it. Still got some work to do before merging 😄

Hey @johnlokerse, this sadly makes 110 % sense - but - there is good news

Regarding the 'xzy already in use' error I recommend to change the namePrefix secret to something even more ludicrous
Regarding the costs, there is a workflow mentioned in the tip box here - but in short: I highly recommend to run the avm.platform.toggle-avm-workflows.yml workflow, which will essentially allow you to disable/enable workflows in one swift swoop (by default disable all res & ptn workflows)

Otherwise the schedule that runs once a week will indeed eat your credits away like its candy.

Didn't know about the toggle to enable/disable workflows. This is great! Will take a look at the namePrefix, thanks 😄
@rahalan @AlexanderSehr Did you also encounter this error? https://github.com/johnlokerse/bicep-registry-modules/actions/runs/8590236271/job/23537534815#step:4:1187
I think we probably are missing a check somewhere in Invoke-ResourcePostRemoval.ps1.

I can't say I have, but you're right it looks like it. 🤔

@johnlokerse I can see your workflow runs now, thanks.

Green workflow (except for Nvidia):
https://github.com/johnlokerse/bicep-registry-modules/actions/runs/8687076991
It didn't include the static validation step because I replaced the value of #_namePrefix_# for testing purposes... builds without the #_namePrefix_# are rejected. So I tried to rerun it with the original value (#_namePrefix_#) and it failed at the deployment of the key vault due to the name that is not globally unique:
https://github.com/johnlokerse/bicep-registry-modules/actions/runs/8687839244
Would you like me to wait until I can run all the steps for a green workflow?

@johnlokerse regarding the nameprefix: the name prefix needs to be a secret in your GH, see 3.1 https://azure.github.io/Azure-Verified-Modules/contributing/bicep/bicep-contribution-flow/#31-set-up-secrets

@johnlokerse regarding the nameprefix: the name prefix needs to be a secret in your GH, see 3.1 https://azure.github.io/Azure-Verified-Modules/contributing/bicep/bicep-contribution-flow/#31-set-up-secrets

@rahalan Oh right completely forgot about that... will run the tests with updated prefix tomorrow. FYI; Also need to revert the backup service guid

Hey @johnlokerse, I could help but also take a peak as I was mentioned in a comment (as per my notifications). Commented a couple other things aside the GUID that you already mentioned that I'd suggest to change/fix soon.

@AlexanderSehr @rahalan Yes I will pick this up, will be my first thing to do tomorrow!
Didn't expect a merge this quick, so my bad.

@johnlokerse @AlexanderSehr I didn't review good enough, my bad. I will change the GUID back to the correct one in my already open PR


GH about section: Available to sponsors only

This is no longer the case.

And thanks again, fixed!


Tag is on wrong commit

When I release a minor version the tag is added to the "start next development iteration .." commit instead of the "version .." commit, for example:
commit ... (HEAD -> master, tag: v0.1.10, origin/master, origin/HEAD)

    (cargo-release) start next development iteration 0.1.11-alpha.0

commit ...

    (cargo-release) version 0.1.10

If this is on purpose, can it be configured in a way that the tag is added to the first commit instead of the second? This is currently breaking my CI setup.

This is weird. What version of cargo-release you were using?
We do git tag before the version bump commit.
If you check cargo-release's github page, you can find those tags on right commits.

I'm currently at work, and I released this at home yesterday. I'm running Debian and I updated all cargo packages yesterday so it should be the current version (0.12.4). I can verify this later today.

I was correct, I'm running cargo-release 0.12.4 installed through cargo. My shell is Bash.
  Operating System: Debian GNU/Linux bullseye/sid
            Kernel: Linux 5.2.0-3-amd64
      Architecture: x86-64
             Shell: GNU bash, version 5.0.3

Could you also post any relevant release.tomls and the command line used in case we're hitting some weird scenario.

The command line I used was just cargo release. I'm not using a custom release.toml.

I've now just done another release on the same machine without updating and the tag is placed on the right position. The last release I went from 0.1.10-beta.3 to 0.1.10 and the tag was misplaced, now I went from 0.1.10 to 0.1.11 and the tag is placed correctly.

Going ahead and closing this since you couldn't reproduce this.  Feel free to re-open if you run into it again!


PERF-#4445: Stop recomputing both indices for axis-wide applies.

Signed-off-by: mvashishtha<EMAIL_ADDRESS>
What do these changes do?
Stop recomputing both indices for axis-wide applies. These changes make the slow computation in the snippet from https://github.com/modin-project/modin/issues/4445#issue-1228486253 asynchronous.

[x] commit message follows format outlined here
[x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] signed commit with git commit -s
[x] Resolves #4445
[ ] tests added and passing
[ ] module layout described at docs/development/architecture.rst is up-to-date
[x] added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

@mvashishtha I like the idea of splitting the functionality like this, but maybe we need a new operator instead of handling it like this?

The difference between the new operator and the current apply_full_axis seems small. I have a slight preference for making the change this way. The extra code is only 7 lines. @YarShev what do you think?

If we do not want to pass lengths from the QC to the core dataframe, I would suggest renaming func_may_change_complementary_index_size to preserve_opposite_lengths and passing it apply_full_axis to broadcast_apply_full_axis, where we would handle it.

@mvashishtha For the algebra, typically there are two things that qualify an operator:

Unique handling of metadata
Unique handling of data

We typically want each operator to have certain guarantees without requiring too much information from upper layers. This is why I believe it should be a different operator, since both metadata and data can change at the same time, which isn't something the current operators explicitly support.

@devin-petersohn The new param I introduced to apply_full_axis in this PR seems nearly identical in purpose to preserve_labels in broadcast_apply. Should broadcast_apply also be split into two methods, one of which assumes labels change, and the other of which assumes they do not? https://github.com/modin-project/modin/blob/cca9468648521e9317de1cb69cf8e6b1d5292d21/modin/core/dataframe/pandas/dataframe/dataframe.py#L2101-L2102

@mvashishtha for now, let's keep this fix local to the axis-wide apply. we should revisit after.


feat(#1005) - API key auth

Description
Contribution Checklist:

[x] The pull request only addresses one issue or adds one feature.
[x] The pull request does not introduce any breaking changes
[x] I have added screenshots or gifs to help explain the change if applicable.
[x] I have read the contribution guidelines.
[x] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.

Thanks for this PR. I see that it is stuck somehow. Is there anything I can do to help? (yes this is my first message on this project, I'm that optimistic :))

@sanjai0py what is missing from this PR so that you can move forward?

Hey @bobylito, thanks for your interest in this feature. Unfortunately, I won't be able to work on it at the moment as there are too many conflicts to solve in the PR. I apologize for any inconvenience this may cause.


GroupKeyManagement server: Added validation against groupKeySetID == 0.

Problem

Fixes #16621

Change overview
Added missing validation on WriteGroupKeyMap
Testing

Project built successfully
Group, and GroupKeyManagement tests ran successfully

/rebase


Replace bloom filter with address tree

With the new address tree data structure we might be able to get rid of the bloom filter (given the compact representation of IP addresses)

Turns out it ain't so compact. Nahhhh

:) been there.
bloom/cuckoo filters are super cool frankly.


[BUG] Error occurred: Message: no such execution context

Before submitting a bug report...

[X] This bug wasn't already reported.
(I have checked every bug report on GitHub)

Title

[X] The title is no longer "[BUG] Title" and I edited it with the right error name.

Describe the bug
This occurs every time I run it...
I am currently running on MacOS with M2 Chip. I am also using python 3.11
Copy and paste your error
2024-03-28 23:11:32,213 [INFO]<EMAIL_ADDRESS>2024-03-28 23:11:34,150 [INFO] Using default request storage
2024-03-28 23:11:34,165 [INFO] Created proxy listening on ::ffff:<IP_ADDRESS>:59792
2024-03-28 23:11:34,166 [INFO] Using undetected_chromedriver
2024-03-28 23:11:35,886 [INFO] patching driver executable /Users/user/Library/Application Support/undetected_chromedriver/undetected_chromedriver
2024-03-28 23:11:39,973 [INFO] Screen size: 2277x1447
2024-03-28 23:11:39,973 [INFO] Device size: 2222x1296
2024-03-28 23:11:40,671 [INFO] [LOGIN] Logging-in...
2024-03-28 23:11:48,098 [WARNING] Error occurred: Message: no such execution context
(Session info: chrome=123.0.6312.87)
Stacktrace:
0   undetected_chromedriver             0x0000000100f7c128 undetected_chromedriver + 4596008
1   undetected_chromedriver             0x0000000100f73e93 undetected_chromedriver + 4562579
2   undetected_chromedriver             0x0000000100b77225 undetected_chromedriver + 381477
3   undetected_chromedriver             0x0000000100b6028a undetected_chromedriver + 287370
4   undetected_chromedriver             0x0000000100b5f14a undetected_chromedriver + 282954
5   undetected_chromedriver             0x0000000100b5f5df undetected_chromedriver + 284127
6   undetected_chromedriver             0x0000000100b6e674 undetected_chromedriver + 345716
7   undetected_chromedriver             0x0000000100b832cb undetected_chromedriver + 430795
8   undetected_chromedriver             0x0000000100b8858b undetected_chromedriver + 451979
9   undetected_chromedriver             0x0000000100b5fbdf undetected_chromedriver + 285663
10  undetected_chromedriver             0x0000000100b82f0d undetected_chromedriver + 429837
11  undetected_chromedriver             0x0000000100c0325f undetected_chromedriver + 954975
12  undetected_chromedriver             0x0000000100be2ee3 undetected_chromedriver + 823011
13  undetected_chromedriver             0x0000000100bb3be4 undetected_chromedriver + 629732
14  undetected_chromedriver             0x0000000100bb479e undetected_chromedriver + 632734
15  undetected_chromedriver             0x0000000100f42042 undetected_chromedriver + 4358210
16  undetected_chromedriver             0x0000000100f46c8d undetected_chromedriver + 4377741
17  undetected_chromedriver             0x0000000100f46603 undetected_chromedriver + 4376067
18  undetected_chromedriver             0x0000000100f46f35 undetected_chromedriver + 4378421
19  undetected_chromedriver             0x0000000100f2ba65 undetected_chromedriver + 4266597
20  undetected_chromedriver             0x0000000100f472bd undetected_chromedriver + 4379325
21  undetected_chromedriver             0x0000000100f1e0b0 undetected_chromedriver + 4210864
22  undetected_chromedriver             0x0000000100f64af8 undetected_chromedriver + 4500216
23  undetected_chromedriver             0x0000000100f64c71 undetected_chromedriver + 4500593
24  undetected_chromedriver             0x0000000100f73ad3 undetected_chromedriver + 4561619
25  libsystem_pthread.dylib             0x00007ff80346818b _pthread_start + 99
26  libsystem_pthread.dylib             0x00007ff803463ae3 thread_start + 15
. Retrying... |<EMAIL_ADDRESS>Screenshots
The browser just ends up closing. I cant take a screenshot, but it runs normally, until it crashes, and the window closes.
Value of dashboard variable

It seems like this is error is unique to macos. I ended up creating a linux vm on UTM with this guide. Its a little complicated, so lmk if you need any help.
https://docs.getutm.app/guides/ubuntu/


Singularity performance improvements

This is a first pass at updates to the scheduler internals to improve the speed of offer processing, status updates, and other processes that contend for the scheduler lock. The main theme here is parallelizing things that were previously sequential.
The biggest change in this PR that still needs additional testing is the removal of the global scheduler lock in favor of many smaller locks. There are now three classes of locks. One lock for the scheduler state, one for accessing/processing offers, and one ConcurrentHashMap of request locks such that only one process can be updating the state or tasks for a request at a time. This change lets offers, status updates, deploy checks, pending request processes, and more run in parallel.
Other changes include:

More async handling of status updates. Instead of auto-acking a status update when we receive it, then processing it before grabbing the next, we will kick off an async process for each status update, with concurrency being limited by the AsyncSemaphore class (copied here in the short term until we open source the library)
Parallelize many processes in offer processing and remove the extra while loop. Base on the first pass over the logic it seemed we were doing many more loops than needed through certain sections of offer processing. This still needs more testing to confirm there is no regression
parallelize pending request and deploy check processes now that we are locking at a request level
remove the task credit system. This was originally for debugging. But, given the disabled actions capabilities the extra checks are unneeded overhead

The request level locking along with our proxy to leader code opens us up to some better UI experiences in the future as well. Instead of waiting for pollers, we can more easily execute many actions like bounces or task kills at request time and immediately return results to the UI.
Further TODOs include finishing off fixing tests, running additional benchmarks of the new code, and cleaning up some rough edges (like hard coded values that should instead be configurable)
@darcatron @baconmania @pschoenfelder

Additional improvements:

Calculate more slave usage scores up front instead of recalculating on each pending task loop so that the number of calculations there is liner with number of offers not with numOffers*numPendingTasks
Also consider cached offers when resourceOffers is called, not only in the scheduler poller

Test updates:

Most tests rely on there being no offer cache in place. I now bind the SingularityNoOfferCache by default except for a specific test class which leverages the offer cache to test it

🚢


Add web fonts mime types to MimeType inner map

Hi,
As Spark will be guessing some mime types, would be nice to have web fonts mime types too.
Best regards.

Good idea. Coul you add .woff2 while you're at it?

Added woff2 mime type =D

Thanks!


Bump version to 2.4.0rc0.

The latest failure is because I haven't yet included the commit that pins pillow. Rather than attempting to advance the version number in isolation I think it will be best to put everything together locally then submit as a working PR (or several).


Gif Creator

It will be made using Python. It make a video to gif.

@pranjay-poddar please assign me thism


Added support for custom filenames for logging and updated quickstart docs.

This commit adds support for custom log filenames as added to pystorm in the following PR:
https://github.com/pystorm/pystorm/pull/25
I'm pretty sure this isn't as complete as it could/should be, since the tail cli functionality currently relies on hardcoded filename patterns for matching.

Thanks for this!


Resolve incomplete coroutine initialization

#6
tmp node not initizlized causing ASan to shutdown workers.

Thank @JoshuaLee0321 for contributing!


Short Resistors in Magic Spice Extraction

Updated Magic to 952b20d
Added new variable, MAGIC_EXT_SHORT_RESISTOR to Magic.SpiceExtraction,
disabled by default

Originally reported by @urish, @tnt

Congrats on moving to beta!

Now that there are unit tests to prevent me from breaking things dramatically, I'm more comfortable calling this a beta :rofl:


Fix a panic in the gsFlag String implementation. [phab:D1242]

Created by fromberger at 2017-01-10 17:32:23:
The Go flag package instantiats a zero of the flag type for rendering purposes
(since 1.6 or 1.7, I think), and that leads to a nil indirection in the String
implementation. Check for the nil first to avoid this.
The Go team closed my https://github.com/golang/go/issues/16694 as WAI, though
I still argue this was a spurious violation of the compatibility guarantee.  So
we work around it.

zarko accepted this revision at 2017-01-10 17:39:01

fromberger closed via commit 6d9792df1f99c837ae8dbc8776de3526967c8bdc at 2017-01-10 17:41:43


iOS Autofill magic code not working

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:   9.0.27-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1725292622506979
Action Performed:

Sign in with mobile number on IOS
Wait to receive magic code suggestion in keyboard suggestion
click on suggestion

Expected Result:
Magic code pasted in Input correctly
Actual Result:
Only 1 digit of magic code pasted in Input. Last digit gets pasted in first magic code entry field
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/08d8f220-a217-4c46-bc01-2862863d7506
https://github.com/user-attachments/assets/4bdbbfb9-0e15-40a8-a365-8278a434b762
Add any screenshot/video evidence

View all open jobs on GitHub

https://expensify.slack.com/archives/C9YU7BX5M/p1725893743202769

Still able to reproduce.
https://github.com/user-attachments/assets/55c3ee2e-667c-4951-b2fc-88921d0badfb

Waiting for proposals

Heading out on parental leave, thank you for taking this over @abekkala

Because this is VSB (on hold) and this wasn't one picked up right away. We can just close and Not Priority

Ready to fix this :wave:

Just adding here that this also happens on safari mWeb - going to fix both platforms ofc

PR is ready here:

https://github.com/Expensify/App/pull/54253

Not yet merged.
NOTE:
I will be ooo until Monday - Jan 06. I will still be periodically checking in on GHs in the event this one comes up for payment before Jan 06.

PR with a fix has been merged. A separate issue has been identified while working on this one:

https://github.com/Expensify/App/issues/54658


Invalid screenshot in the doc - user account lock

Document: https://docs.wso2.com/display/IS550/Locking+a+Specific+User+Account
Section: Using the management console
Step 6 - screenshot
It should be corrected as below.

Type/Docs
Affected/5.5.0-Alpha
Priority/High
Severity/minor

I think this not a bug. We don't have the ability to figure out whether this is a boolean value or not when there is no value for this particular field. This is a limitation we do have. Hence for the first time it will show a text box. If we update does with this image it gives a wrong impression to a person who is initially filling this.


Max number of IP restriction rules is not listed

The page is missing information about how many rules can be created. It would be great if the limits are posted for both app service and its SCM. Also, if the limit is shared between app service and SCM (e.g. "total number of rules between app service and SCM is XYZ rules") then it should be documented as well.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d90bbf62-44f9-30a6-d6ea-bbf776f6efc5
Version Independent ID: b3961eac-6c70-b345-f48c-e4c0ec67059c
Content: Restrict access - Azure App Service
Content Source: articles/app-service/app-service-ip-restrictions.md
Service: app-service-web
GitHub Login: @ccompy
Microsoft Alias: ccompy

@gaikovoi Thanks for the feedback! We are currently investigating and will update you shortly.

Any update on this?

@gaikovoi are you able to provide the maximum number of IP Restrictions allowed?

Today we don't have specific limit (only the technical limit of the config db), we will soon release a 1000 rules limit like NSG rules, and will add augmented rules too.

#please-close


Support upserting entities on PUT requests

Feature Request
It seems that today PUT requests don't create resources that don't already exist (unless they were previously deleted).
Could we support creating resources on all PUT requests?
Motivation
The current behavior is a bit out of line with standard rest behavior that expects PUT requests to create a resource if it doesn't already exist https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/PUT.
Proposal
Enable upserting from PUT endpoints.
The resources that would see the most upserting are probably:

Applications
Endpoints
Event types

Alternatives
It's possible to get the same behavior today with try/catch'ing a POST and PUT, but this is extra boilerplate that doesn't offer any distinct advantage or flexibility for many use cases.

Hey @BarakW, forgot to comment but this is a great suggestion and I started taking a look at it earlier today. We'll ping you on this thread when we merge a PR for this!

Hi @BarakW happy to inform you a PR resolving this has been merged! On main, PUT method requests to Application, Endpoint, and Event Type will now create an entity and return 201 if a record matching the provided ID doesn't exist -- otherwise, the existing entity will be updated and the server will return 200.


Dining Card: All HDH Vendors Are Missing From The Dining Card

All of the HDH dining vendors are missing from the dining card.
The data for all of the following restaurants is not included in the data returned to the app when fetching the dining vendors data:

64 Degrees
64 North
Cafe Ventanas
Canyon Vista
Club Med
Food Trucks
Foodworx
Johns
Oceanview
Pines
Restaurants at Sixth
Rogers
Roots
Seventh Market
Sixth Market
The Bistro

Debugging Steps

[ ] Reproduce the bug
[ ] Fix the bug
[ ] Test locally on a device

Thanks for reporting, @tkiyohar
I've created a ticket directed to the service owner internally. Closing.


tiny user profile page

You can use these metrics to gauge a lot of useful stuff!  I suggest these should be only seen to ops/admins.  It allows them to see who is contributing the most (or not).


fatal error while editing view cartocss

happened on homolog env while changing the color (live map updates) for a point layer:
TypeError: Cannot set property 'grainstore' of undefined
    at EventEmitter.module.exports (/root/DomeGIS/src/services/tiles-new/index.js:32:19)

error while editing layer KAZA_protected_areas

this issue could be related to trying to create map without the sync being complete, there should be proper callback that doesn't crash the server


"admin.components" is not allowed for Globals

Documentation Issue
Both the documentation and the typescript types say that you can provide a custom component for a global's edit view, but the globals validation schema doesn't seem to allow it.
When providing a custom component for a global edit view i get the following error:
1: Globals "test_global" > "admin.components" is not allowed

Hey @zcylla — thank you for the report! This is fixed and will be released shortly!


added workflow as mentioned in issue #116

Related Issue
Fixes #116
Description
This feature aims to solve the problem of inconsistent and delayed communication following the merging of PRs. By automating the commenting process, it ensures that contributors receive timely feedback and acknowledgments. It also reduces the administrative burden on maintainers, allowing them to focus more on code reviews and other critical tasks
Type of PR

[ ] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Checklist:

[X] I have performed a self-review of my code
[X] I have read and followed the Contribution Guidelines.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

@Asymtode712 read contributors.md please

@subhadeeproy3902 have commented the code and hence carried out all the tasks, please review and merge this PR

@subhadeeproy3902 Also add the labels to this PR
Thank You!

@Asymtode712 PRs are not labeled only issues are .... but please do check the contributors.md. Its clearly written ... go through the README first !

@subhadeeproy3902 the program manager has clearly stated that PR as well as Issues both must be label, open discord and check it once

@Asymtode712 I have already talked to project managers of mine !
So please, dont question about this !
the issue was labeled from the first and u please do check CONTRIBUTING.md file


a language other than English

If you use a language other than English for a survivor name or annotation (eg Korean) and then save and load it, the language will be broken. can i know how to solve it??

I actually have no idea how TTS handles localization. It may have to do with how they save their files, or with how they display text. To determine which one it is, I'd try this: name your survivor with a Korean name, then save your game. Go in your save game folder (C:\Users<your name>\Documents\My Games\Tabletop Simulator\Saves), then open up the .json file for your save (it will probably be the most recently changed one). Open it as a text file. Search for your survivor's name. If you find it, then it means TTS is saving the name properly, but displaying it improperly. If you don't find it, then it means TTS isn't saving it correctly. Regardless of which, I'd report this bug on the official TTS forums, since there's not much the mod can do to fix it.


mqtt: SERVER: The connection was closed because MQTT keep-alive check failed.

GCP IoT Core showing error: mqtt: SERVER: The connection was closed because MQTT keep-alive check failed." Error Message: [link] https://imgur.com/2Aragbp
Under the monitoring tab, I can see data sent/received, however I believe the above error is preventing the data being sent to firebase.
Have tried rebuilding the avr-iot device, which indicate data is being sent with no errors.
Is there a specific reason why I might be getting this error?
@mattgif @Yitaek @ericsibored @alvarowolfx

There's an error getting your data through IoT Core. Is this an out-of-the-box device, or have you modified the payload or settings beyond those listed in the setup guide?
Possible issues include:

MQTT payload too large
Registry region / device region mismatch (the setup assumes US-CENTRAL1)
Billing not enabled in GCP

thanks for the reply @mattgif ,
I haven't made any modifications to the device, only followed the setup guide. A couple of months ago, when I initially tried the guide it worked perfectly.
For payload size, are you referring to this item?
#define TOPIC_SIZE 100      // Defines the topic length that is supported when we process a published packet
#define PAYLOAD_SIZE 200       // Defines the payload size that is supported when we process a published packet
#define NUM_TOPICS_SUBSCRIBE 1 // Defines number of topics which can be subscribed
I've checked under the GCP project, I can see its under US-CENTRAL1.
I've also upgraded billing to the blaze version.
I should note that the device works as I can connect it to the microchip default https://avr-iot.com/device/{device ID}, obviously thats before I started following the guide etc.
I also tried creating a new project and following the guide again, with no luck unfortunately.
Your help would be appreciated :)

I was having the same issue but managed to fix it by deleting all pub/sub configurations and IoT Core Registries and began again. I also copied and pasted the device pub key instead of uploading it. Likely this didn't actually do anything though.
I am using:
Registry ID: AVR-IOT
Project ID: Something that I specified
Location: us-central1
within header IoT_Sensor_Node_Config.h the configuration must match what is setup in your GCL.
#define CFG_PROJECT_ID "your_project"
#define CFG_PROJECT_REGION "us-central1"
#define CFG_REGISTRY_ID "AVR-IOT"
#define CFG_MQTT_HOST "mqtt.googleapis.com"

Still no luck, here is what I have tried so far:
Delete existing registries, projects etc - Started from scratch.
Followed the guide;
lights are: blue (ON all the time), green (ON all the time) and yellow blinking.
I also checked the Config.h to make sure it contains same info as the ones provided.
Checked to make sure region is us-central1 and other details match.
it seems that the realtime database within the firebase project has not been created (Billing has been upgraded to Blaze).
Only error that popped up during script installation were;
i  deploying functions Error: There was an error reading ./functions/package.json:  Engines field is required but was not found in ./functions/package.json. To fix this, add the following lines to your package.json:       "engines": {         "node": "8"       }
also this issue came up, not sure if it would affect the outcome;
found 2 vulnerabilities (1 moderate, 1 high)   run npm audit fixto fix them, ornpm audit` for details
Creating a production build of the UI (this may take a few minutes)...

<EMAIL_ADDRESS>build /home/my_dir/microchip-avr-iot/setup/ui
webpack --progress --config webpack.config.prod.js

Failed to load ./.env.
Hash: c5cb8acdca35f21537d8
Version: webpack 4.31.0
Time: 103140ms
Built at: 07/06/2019 3:41:21 AM`
Not sure if there's anything else I can try at this point, hopefully its something trivial

Hello guys,
I hope this help you...
Node.js 6 has deprecated you need to update your code.
Regards

Hello guys,
I hope this help you...
Node.js 6 has deprecated you need to update your code.
Regards

I've tried something similar to that with no luck.

I haven't been able to reproduce this error on my end. I pushed up a version with the Node 8 update and other dependency updates. Can you scrap the repo from your cloud shell, remove the existing cloud functions, and try it fresh from the new build?

I haven't been able to reproduce this error on my end. I pushed up a version with the Node 8 update and other dependency updates. Can you scrap the repo from your cloud shell, remove the existing cloud functions, and try it fresh from the new build?

Hey Mat,
tested it again, works perfectly, it seems that the node + functions dependency update was preventing it from working. thanks

Phew! Glad to hear it.


input props overrides props from ...register() in react-hook-forms

Not sure if it's an issue because i don't know if there is a reason for useTextField's "inputs props" to override the value prop . But I spent hours trying to figure this out, so i think it may help others.
In case you're using both react-hook-forms and react aria , remember to use react aria first and then spread the register so it overrides whatever react aria is doing to the values:
const { inputProps, labelProps, errorMessageProps, descriptionProps } =
    useTextField({ label, ...props }, ref);

   <input
          type={type}
          {...inputProps} // must be used before ..register so register can override some stuff
          {...register("yourvar")}
          aria-invalid={error ? 'true' : 'false'}
/>

hope it elps somebody or there is way to avoid react aria overiding value props
Thanks!

This setup will likely break some accessibility.
Instead, you can use our mergeProps function if it's just event listeners like onChange, but there's a bit more to it than that, because there's also a ref and a name, and our hooks should be aware of those things too. see the return type for register here https://react-hook-form.com/api/useform/register and our hooks options as well as return types here https://react-spectrum.adobe.com/react-aria/useTextField.html#api
A better approach could be to create the input as a component with the aria hook. This would then be reusable across your site. When you use the component in your form, you'd then register using https://react-hook-form.com/api/usecontroller which is how React Hook Forms recommends integrating with other UI libraries or Design Systems
See https://github.com/adobe/react-spectrum/issues/1860#issuecomment-840125913 for more information on this kind of integration as well.

Closing for now, feel free to reopen if there are any further issues.

Thanks! Will definitively take a look at it!


TS1256: A rest element must be last in a tuple type

Describe the issue/behavior that seems buggy
When compiling with tsc v4.9.3, it fails with the following error:
> tsc

node_modules/highlight.js/types/index.d.ts:55:54 - error TS1256: A rest element must be last in a tuple type.

55             either: (...args: (RegExp | string)[] | [...(RegExp | string)[], RegexEitherOptions]) => string,
                                                         ~~~~~~~~~~~~~~~~~~~~~~

Found 1 error.

Expected behavior
Compiling should not fail.
Additional context
At index.d.ts:55, if you swap RegexEitherOptions and ...(RegExp | string)[], the error is resolved.
i.e.
<<<<<<
            either: (...args: (RegExp | string)[] | [...(RegExp | string)[], RegexEitherOptions]) => string,
======
            either: (...args: (RegExp | string)[] | [RegexEitherOptions, ...(RegExp | string)[]]) => string,
>>>>>>

Same here with tsc 3.9.7.

Can someone recommend the right way to type this?
https://github.com/highlightjs/highlight.js/blob/main/src/lib/regex.js#L77
The type of args is literally (RegExp | string)[] except the last params can optinally be a RegexEitherOptions.

type RegexEitherOptions =
{
    more: boolean;
}

    interface PublicApi {
        regex: {
            concat: (...args: (RegExp | string)[]) => string,
            lookahead: (re: RegExp | string) => string,
            either: (...args: (RegExp | string)[] | [...(RegExp | string)[], RegexEitherOptions]) => string,
            optional: (re: RegExp | string) => string,
            anyNumberOfTimes: (re: RegExp | string) => string
        }
    }

Seems to work in the 4.9.5 playground without issue?

This snippet also seems to work just fine:
    type RegexEitherOptions = {
        capture?: boolean
    }

export function either(...args: (RegExp | string)[] | [...(RegExp | string)[], RegexEitherOptions]) {
  const opts : RegexEitherOptions = stripOptionsFromArgs(args);
  args = args as (RegExp | string)[];
  const joined = '('
    + (opts.capture ? "" : "?:")
    + args.map((x) => source(x)).join("|") + ")";
  return joined;
}

function stripOptionsFromArgs(args: (RegExp | string)[] | [...(RegExp | string)[], RegexEitherOptions]) : RegexEitherOptions {
  const opts = args[args.length - 1] as RegexEitherOptions;

  if (typeof opts === 'object' && opts.constructor === Object) {
    args.splice(args.length - 1, 1);
    return opts;
  } else {
    return {};
  }
}

export function source(re : RegExp | string) {
  if (!re) return null;
  if (typeof re === "string") return re;

  return re.source;
}

I'm sure this comment won't endear me to the rest of the Typescript community, but usability is more important than technical compliance. Perhaps you could use an interim any.

So right now I can't reproduce this error with the web version - is it no longer an issue in the latest TS versions?

VS Code 1.76 uses 4.95 but I can't tell from here what version of tsc is used by gulp in my CICD, I'll have to look into that after work.

I only write the types to use the linting features in VS Code... so if it worked when I wrote it - and evidently it works in the latest tsc - does that make 4.95 sound like perhaps a bug or regression?

Closing for lack of activity.


metadata build/check: ensure designer key is a simple short name

The designer key in METADATA should be 4 space separated words or less, and contain no comma or period.
Eg,
FAIL: ofl/biryani/METADATA.json:  "designer": "Dan Reynolds and Mathieu Réguer",
FAIL: ofl/poetsenone/METADATA.json:  "designer": "Rodrigo Fuenzalida, Pablo Impallari",
If the test fails, then the string should be Multiple Designers

[ ] make the metadata-checker check for this, with an autofix
[ ] make the metadata-build script use this rule

I edited the issue text a little


Add shortcut option to setup

Add option to create an application shortcut to start QuickLaunch and what keys to use. Currently, this has do be performed manually. It should probably be enabled by default, as launching QuickLaunch manually defeats its purpose.

Awesome tool, makes me much more productive on Haiku.

I didn't see the need for re-implementing this in the Quicklaunch settings, when there's a systemwide preference panel for that

Doing it in the Shortcuts settings is cumbersome. I would bet that most users don't know what to enter under "application", namely /boot/system/apps/QuickLaunch/QuickLaunch (just QuickLaunch doesn't cut it!).

But actually the best solution would be if this came pre-installed and pre-configured in the default Haiku installation.

Indeed, there is a ticket about that https://dev.haiku-os.org/ticket/14841

Doing it in the Shortcuts settings is cumbersome. I would bet that most users don't know what to enter under "application", namely /boot/system/apps/QuickLaunch/QuickLaunch (just QuickLaunch doesn't cut it!).

Yeah, the Shortcuts prefs have been in need of an overhaul for many years (decades really, if we go back to its origin "SpiceyKeys"). :)
It does use a file dialog to help find the app to shortcut to, so it's not that hard to do.

Actually, there is no file dialog in Shortcuts anymore.

Oh, Actually there is a file dialog there is you right click a list in Application column. I think double click there should open it instead of this tiny window.

Agreed. As said, the Shortcuts prefs would be a prime target for changes... :)

Actually there is a file dialog there is you right click a list in Application colum

No one is gonna find that ;-)

Actually there is a file dialog there is you right click a list in Application colum

No one is gonna find that ;-)

Yep, I never knew that was there!! I always wondered why the box was so small, and there was (apparently) no file dialog.

Really? Haiku's ubiquitous use of context menus has me right-clicking any objects on any OS/in any app right away...


Input isn't recognized accurate

The following tex:
\input{lib/tables/kostenmatrix.tex}
is converted to:
\input{lib/tables/kostenmatrix.tex
It should disappear completely

This is fixed with pull request #5.