Example validation is not done against the schema

Describe the bug
redocly is not able to detect that the sample provided does not respect the schema ( given the schema is not perfect)
here the issue is that the oneOf is wrong , as not discriminant enought
when leveraging a json schema validator the sample is set as invalid
I would expect that Redocly validate each sample toward the schema  (at object or endpoint level)
To Reproduce
given this API specification
sample.json
redocly reply 'Woohoo! Your API description is valid. 🎉"
Expected behavior
i would expect that the example is validated against the schema , and so here that there would be a warning , or even an error mentionning that the sample is wrong , please correct sample our double check your schema defintiion
version
redocly --version
1.17.1

this is invalid JSON Schema because the oneOf doesn't have unevaluatedProperties: false defined.  thus, both schemas are valid.
Try this.
 "components": {
        "schemas": {
            "Pet": {
                "type": "object",
                "oneOf" : [
                    {
                        "properties" : {
                            "pim" : {"type":  "string"}
                        }, "unevaluatedProperties": false
                    },
                    {
                        "properties" : {
                            "pam" : {"type":  "string"}
                        }, "unevaluatedProperties": false
                    }
                ],
                "example" :
                {
                    "pam" : "nop"
                }
            }
        }
    }

based on your other request to require type keyword (#1614), this schema would also flag a warning because it does not consider the type: object defined as a sibling to oneOf.  each oneOf sub-schema is considered a separate schema.

Btw, the rules do work correctly for this example.
rules:
  no-invalid-schema-examples: warn

This gives me a warning f

or invalid example

if you're using extends: [recommended] ruleset.  this particular rule is turned off.  you need to set it manually in your rules
https://github.com/Redocly/redocly-cli/blob/4c3d8cf84f0c831777660f8d328c15fb71163f14/packages/core/src/config/recommended.ts#L35C6-L35C41

@jeremyfiel thanks a lot for the investigation , I apologize for the disturb
i did not realize that there was some rules off when doing redocly lint ,
you may consider to enable it by default in recommended , the rational is that example can be use in various use case such as generate postman , or bruno collection where they would input wrong statement , or when doing a static mock
having sample in line with the schema looks usefull in those scenario .
Thanks again for your great tool , i let you closing the ticket or use it to update if you beleive it should the level

This rule is off because it's recommended to use media-type examples as mentioned by @tatomyr .
You can update your schema like this:
{
    "openapi": "3.1.0",
    "info": {
        "title": "this is the title",
        "description": "this is the description",
        "license": {
            "name": "nothing",
            "url": "nowhere"
        },
        "version": "1.0"
    },
    "security": [],
    "servers": [
        {
            "url": "https://api.server.test/v1"
        }
    ],
    "paths": {
        "/test": {
            "post": {
                "summary": "Pet",
                "operationId": "getTest",
                "requestBody": {
                    "content": {
                        "application/json": {
                            "schema": {
                                "$ref": "#/components/schemas/Pet"
                            },
                            "examples": {
                                "pet_request": {
                                    "$ref": "#/components/examples/pet"
                                }
                            }
                        }
                    }
                },
                "responses": {
                    "200": {
                        "description": "testOK",
                        "content": {
                            "application/json": {
                                "schema": {
                                    "$ref": "#/components/schemas/Pet"
                                },
                                "examples": {
                                    "pet_response": {
                                        "$ref": "#/components/examples/pet"
                                    }
                                }
                            }
                        }
                    },
                    "400": {
                        "description": "input issue"
                    }
                }
            }
        }
    },
    "components": {
        "schemas": {
            "Pet": {
                "type": "object",
                "oneOf": [
                    {
                        "type": "object",
                        "properties": {
                            "pim": {
                                "type": "string"
                            }
                        },
                        "unevaluatedProperties": false
                    },
                    {
                        "type": "object",
                        "properties": {
                            "pam": {
                                "type": "string"
                            }
                        },
                        "unevaluatedProperties": false
                    }
                ]
            }
        },
        "examples": {
            "pet": {
                "summary": "a sample pet object",
                "value": {
                    "pam": "nop"
                }
            }
        }
    }
}

Thanks for the kind words, @LasneF!
I'll close the issue since it's up to you which rule you want to use 🙂. You can explore the rules and create and share your own ✨best-in-the-world✨ ruleset that can then be reused in any other project simply by using the extends option.
@jeremyfiel thanks for chiming in and for the detailed explanation!


Add an option for enforcing gc for line comments only and gb for block comments only

Current behaviour
Performing gc on a text object that is within a single line's bounds puts it in a block comment.
Expected behaviour
Performing gc will always comment selected range line-wise. For block comments, I can always use gb. kommentary has prefer_single_line_comments option, which does exactly that.
Some examples

gcl
▏ return function() end

Result:
 --[[   ]]return function() end

Expected:
  -- return function() end

gcaf (w/ tree-sitter)
▏
  return function() end

Result:

  return --[[ function() end ]]

Expected:

  -- return function() end

Proposed solution
Modify block_x definition to include the option for enforcing comment type.
    local block_x = partial_block and same_line and not (cfg.enforced_type and ctype == U.ctype.line)

The behavior you want is already achievable with gcc.
And IMO, the current behavior is expected and should be the default. And I don't want to add some niche options to the plugin :)

Fair enough. I proposed this, because of the following issue. If it's not convincing, you can freely close this issue.
Increased mental load because of inconsistency

Commenting objects with gca{/gcia(ts)/gcaf(ts)/... results in a block comment if the object is on single line, yet, for multi-line, it's line-wise.

Same can be said about motions, e.g. gcl vs gcj.

gc - line comment, gb - block comment is easy to remember subconsciously, gc - line/block comment, gb - block comment is not.

I constantly find myself doing comment undos, because I mindlessly comment without thinking whether the object is multi-line or single-line. Considering my tree-sitter text object workflow, this is very annoying. Getting used to block comments for certain object types, yet sometimes they don't work. Or vice versa. This "unpredictability" and having to stop to think about what keybind I should press partially defeats the purpose of vim-workflow.

 In a sense that it's always predictable [action][motion/text_object] with actions:
gc - apply comment to whole line
gb - apply comment to range
Working with this approach for the last 3 days has been much more pleasant.

I did that because most user starts commenting with gc and pressing gc{left/right motion}  like gcw gc$ should use block comments even if gc means line comments. I am also getting where you are coming from, it's just no one complained about this behavior before.
Still, I need to balance the sane defaults and customizability of the plugin :)


remove axiom: local field potential recording has-input that is located only in brain

This interesting paper (h/t @jamesaoverton) finds a problem with OBI:
https://www.semantic-web-journal.net/system/files/swj3245.pdf
'local field potential recording':
(has_specified_input some
((tissue and (’located in’ only brain))
and (’has role’ some ’evaluant role’))),
I think the reasons it finds this are interesting (difference between RO and BFO-FOL) but are not relevant for OBI
What it does reveal however, is an anti-pattern:
located-in only is almost always unintentional and wrong. We already know that universal restrictions must be avoided with transitive relations like part-of. It's not appreciated that they should also be avoided with certain kinds of role chain structures.
Consider

tissue1 located-in [a brain]
[a brain] part-of [a body] (from uberon)
located-in o part-of => located-in (from ro)

entails:

tissue1 located-in [a body]

violating the condition
I think this should be uncontroversial that this should be removed, as should any other located-in only axioms
(I am not sure why standard OWL reasoning didn't catch this)
I would go further, my own personal experience is that universal restrictions are almost always useless for reasoning, always cause confusion, and can almost always be rewritten as simpler to understand and computationally and mentally reason with existential axioms, but YMMV.

I am not sure I am completely following, but I presume the problem detected
is that tissue 1, when removed from a body, is no longer part of it? If so,
I thought that would be addressed by correctly modelling specimens as being
former body parts. But  I suspect that I am not getting something.

Bjoern

On Fri, Sep 16, 2022 at 12:50 PM Chris Mungall @.***>
wrote:

This interesting paper (h/t @jamesaoverton
https://github.com/jamesaoverton) finds a problem with OBI:
https://www.semantic-web-journal.net/system/files/swj3245.pdf
'local field potential recording':
(has_specified_input some
((tissue and (’located in’ only brain))
and (’has role’ some ’evaluant role’))),
I think the reasons it finds this are interesting (difference between RO
and BFO-FOL) but are not relevant for OBI
What it does reveal however, is an anti-pattern:
located-in only is almost always unintentional and wrong. We already know
that universal restrictions must be avoided with transitive relations like
part-of. It's not appreciated that they should also be avoided with certain
kinds of role chain structures.
Consider

tissue1 located-in [a brain]
[a brain] part-of [a body] (from uberon)
located-in o part-of => located-in (from ro)

entails:

tissue1 located-in [a body]

violating the condition
I think this should be uncontroversial that this should be removed, as
should any other located-in only axioms
(I am not sure why standard OWL reasoning didn't catch this)
I would go further, my own personal experience is that universal
restrictions are almost always useless for reasoning, always cause
confusion, and can almost always be rewritten as simpler to understand and
computationally and mentally reason with existential axioms, but YMMV.
—
Reply to this email directly, view it on GitHub
https://github.com/obi-ontology/obi/issues/1595, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJX2IVYJQ33QMDGIDYNUETV6TFRFANCNFSM6AAAAAAQOTZD7Y
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Bjoern Peters
Professor
La Jolla Institute for Immunology
9420 Athena Circle
La Jolla, CA 92037, USA
Tel: 858/752-6914
Fax: 858/752-6987
http://www.liai.org/pages/faculty-peters

I added some uberon axioms and hermit reveals the issue:

Let me know if this still isn't clear. I know it's easy to get lost in either the details of the OWL or of the biology, but it should be uncontroversial that this is wrong, and this is a a blocker for interoperation.

Sorry Chris, this is perfectly clear, and your follow-up is valuable as we didn't have anyone assigned to fixing it. I used to fix such things myself, but with the technological evolution and my intellectual decline, everything non-trivial takes me hours to get right.
I hope Hector can implement this fix from 'only' to 'some' as spelled out below.

Bjoern

OLD:
'local field potential recording':
(has_specified_input some
((tissue and (’located in’ only brain))
and (’has role’ some ’evaluant role’))),
NEW:
'local field potential recording':
(has_specified_input some
((tissue and (’located in’ some brain))
and (’has role’ some ’evaluant role’))),

And I should point out that this and other issues have triggered a broader re-discussion on how we model specimens, which may well be different from what we have here. But this specific issue is just wrong, and needs to be fixed now, no matter what we decide later for broader design patterns.

You are right that I missed your point Chris. Agree on removing the 'only'
restriction here, and on transitive properties in general, and beyond see
if any of our uses are actually doing what we intended.

Bjoern

On Mon, Sep 19, 2022 at 8:41 AM Chris Mungall @.***>
wrote:

I think you're thinking about it too deeply. It has nothing to do with
difficult issues around things changing in time.
You can think of this as purely a structural issue, not a biological
modeling one. Replace "tissue" with "foo" and brain with "bar", body as
"baz", there is still a problem.
In fact the reason is even simpler than the one I have: located-in is
transitive, transitive object properties should almost never be used with
universal restrictions.
Here is the full superclass expression (it looked like the paper only
reported a fragment);
(realizes
https://ontobee.org/ontology/OBI?iri=http://purl.obolibrary.org/obo/BFO_0000055
some (evaluant role
https://ontobee.org/ontology/OBI?iri=http://purl.obolibrary.org/obo/OBI_0000067
and (role of
https://ontobee.org/ontology/OBI?iri=http://purl.obolibrary.org/obo/RO_0000081
some (tissue
https://ontobee.org/ontology/OBI?iri=http://purl.obolibrary.org/obo/UBERON_0000479
and (located in
https://ontobee.org/ontology/OBI?iri=http://purl.obolibrary.org/obo/RO_0001025
only brain
https://ontobee.org/ontology/OBI?iri=http://purl.obolibrary.org/obo/UBERON_0000955)))))
and (has_specified_input
https://ontobee.org/ontology/OBI?iri=http://purl.obolibrary.org/obo/OBI_0000293
some (((tissue
https://ontobee.org/ontology/OBI?iri=http://purl.obolibrary.org/obo/UBERON_0000479
and (located in
https://ontobee.org/ontology/OBI?iri=http://purl.obolibrary.org/obo/RO_0001025
only brain
https://ontobee.org/ontology/OBI?iri=http://purl.obolibrary.org/obo/UBERON_0000955)))
and (has role
https://ontobee.org/ontology/OBI?iri=http://purl.obolibrary.org/obo/RO_0000087
some evaluant role
https://ontobee.org/ontology/OBI?iri=http://purl.obolibrary.org/obo/OBI_0000067
)))
IMO this is really hard to mentally reason with, I don't think this is
just me as the problematic structure has been lurking inside this
complexity for some time
—
Reply to this email directly, view it on GitHub
https://github.com/obi-ontology/obi/issues/1595#issuecomment-1251197106,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJX2IT3A2FMESXV4EZ7723V7CCTVANCNFSM6AAAAAAQOTZD7Y
.
You are receiving this because you commented.Message ID:
@.***>

--
Bjoern Peters
Professor
La Jolla Institute for Immunology
9420 Athena Circle
La Jolla, CA 92037, USA
Tel: 858/752-6914
Fax: 858/752-6987
http://www.liai.org/pages/faculty-peters


RO Store Create floods the Log with error messages

Creating a RO store queries for an existing store, which
fails with StoreNotFoundException. This exception is logged with call
stack, which floods the logs on every store creation.
This may trick the alerting system into treating this as error.
Not logging a call stack and reducing the log to info, when such
exceptions are logged.

Left a minor nitpick. Feel free to ignore if you disagree. LGTM.


feat: rename to aspera SDK

We can always improve the incode docs (TBH the docs shouldn't have so much use of Aspera this and that since in the context of coding that it clear.
But I need to get a build to AOC otherwise we will end up having to wait until next prod push and not be able to get the new Safari stuff in app.


README & docs refresh

Improve README and docs around using envbuilder

I took a look at the README and I actually don't see a ton of room for improvement besides linking to the #335

Closes in #357


feat(grid-list): add grid-list component

r: @jelbourn
In this PR:

[x] Ported Jeremy's existing code from core
[x] Removed Dart facades and Dart-specific patterns
[x] Refactored to use new constructs like @ContentChildren and removed deprecated syntax
[x] Split out TileStyler into its own class
[x] Various bug fixes (e.g. hostbinding issue, rowspan edge case, etc)
[x] Added usability improvements

[x] Friendly error when cols property is missing
[x] Default rowHeight to 1:1 instead of silent fail
[x] Use px by default if no units instead of silent fail
[x] Set height automatically for fixed/ratio mode

Still TODO (next PR):

Unit tests
Docs
Responsive layout
Grid tile header and footer
Sass review/refactor

Ref: #99

LGTM

Ouff
Envoyé de mon iPhone

Le 10 mai 2016 à 18:42, Kara<EMAIL_ADDRESS>a écrit :
Merged #405.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

Cool this tool jelbournalyzer.


Allow only some fields of a struct to be integer

This PR fixes #10. I also make the default objective a function that returns 0 instead of nothing.

Codecov Report

Merging #11 (4adb85b) into master (d8cfe6b) will increase coverage by 0.75%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   49.58%   50.34%   +0.75%
==========================================
  Files          12       12
  Lines         851      864      +13
==========================================
+ Hits          422      435      +13
  Misses        429      429

Impacted Files
Coverage Δ

src/models/model.jl
51.64% <100.00%> (+0.53%)
:arrow_up:

src/functions/functions.jl
100.00% <0.00%> (ø)

src/functions/counting_function.jl
100.00% <0.00%> (ø)

src/models/flatten.jl
72.12% <0.00%> (+1.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8cfe6b...4adb85b. Read the comment docs.


IPFS gateway hardening

Currently, the IPFS gateway (NGINX proxy) allows any content to be uploaded (with a 2MB max payload). If anything can be uploaded from anywhere, there are potential hazards, among them:

spam content / listings
inappropriate content
illegal content

There are many ways to harden the gateway, for example:

Formatted loglines, log handling, and some sort of log monitoring would give visibility into what is being uploaded through the gateway
Validating uploaded data (adheres to schema, file formats for binary fields, etc)
Authentication (ex. integration with ERC725, API keys to ensure uploads come from applications and services built by known developers, etc.)
Spam filtering on the text content
Image recognition for offensive content

Thanks for this @ambertch.
@DanielVF reminded me that we also need to add more redundancy to our IPFS gateway and have at least a second server that is constantly pinning our content. We're currently running a single gateway server and there's no guarantee that anyone else will ever pin our stuff without the appropriate incentive. @cuongdo can you own this?

@joshfraser Yes, I'll take on adding IPFS gateway redundancy.
@ambertch Thanks. I'll put in my comments later today.

@ambertch These are good ideas. I don't currently have access to the IPFS gateway, but these are some other ideas in order of my priority for them:

Adding a second IPFS gateway
Have IP-based ACLs for certain operations, such as pinning and unpinning. I'm not aware of a legitimate use for someone else pinning (outside of the auto-pinning that happens when objects are added) or unpinning stuff on a public gateway. Taking this further, there could be just a set of whitelisted operations. I'm a little worried that the various features of the IPFS gateway could make it a vector for attacks.
Basic monitoring for low disk space, etc.
Have a "shadow" IPFS server whose only job is to have pinned copies of IPFS objects that correspond to listings. No external access would be allowed. This ensures that there's always one IPFS server that has the content that's not exposed to external attacks.
Rate-limiting of external requests or some other form of DOS/DDOS protection

Of the ideas @ambertch suggested, I believe that adding better logging and validating uploaded data are the short-term priorities.

It sounds like besides application development, provisioning has to be done for the gateway server (configure logging, install agents for monitoring and alerting, writing the Nginx configs). If there are multiple gateway servers, a system like ansible can also deploy changes to all servers, and provision/configure servers identically (tags and variable allow for variations in deploys, ex. if the shadow server is mostly the same but has a different setting to make it a read replica of sorts)

The following issues track the above:

Adding a second IPFS gateway (https://github.com/OriginProtocol/origin-devops/issues/5, https://github.com/OriginProtocol/origin-devops/issues/2)
Have IP-based ACLs for certain operations, such as pinning and unpinning (TODO)
Basic monitoring for low disk space, etc. (https://github.com/OriginProtocol/origin-devops/issues/1)
Have a "shadow" IPFS server whose only job is to have pinned copies of IPFS objects that correspond to listings. No external access would be allowed. This ensures that there's always one IPFS server that has the content that's not exposed to external attacks.(https://github.com/OriginProtocol/origin-devops/issues/11)
Rate-limiting of external requests or some other form of DOS/DDOS protection (https://github.com/OriginProtocol/origin-devops/issues/3)

For the setup and configuration of the servers, https://github.com/OriginProtocol/origin-devops/issues/10

In addition, profiling of upload and download times as well as optimization of those: https://github.com/OriginProtocol/origin-devops/issues/9


Add support for OAuth IdP

For future use by mobile applications that may or may not ever exist

Alternative for mobile apps - add Google OAuth SP for easier login on Android devices. Dunno about iOS.

Implemented in #1764


speed up Base64 decoding

code (@MartinNowak) reported this on 2015-03-31T19:31:28Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=14384
CC List

r9shackleford

Description
We're slower than Rubinius here :(.

https://github.com/kostya/benchmarks/tree/a2d10ddfeea208309fd53d666a533445a97ae264/base64

A promising attempt would be to replace the translation table with explicit code and to process strings in register sized chunks instead of byte-wise.

r9shackleford commented on 2015-04-01T02:19:46Z
dmd* is slow, gdc is faster than every other implementation in the benchmark.

http://forum.dlang.org/thread/kdxidecfhivdmonazrra@forum.dlang.org?page=2#post-kgolgxdoptsikvtxfrrp:40forum.dlang.org

is this bug still valid?

code (@MartinNowak) commented on 2015-04-05T23:27:50Z
Sure, the 2 things I named are still valid ideas to speed up the function.


If State & Country Picklists are enabled and Contact Address is Overridden, Mailing State  not updated on changed Address

Thread: https://powerofus.force.com/0D580000034dUdS
Steps to reproduce:

Enable State & Country Picklists (standard settings are fine)
Create Contact with Mailing Address
Edit Contact - check 'Address Override' and change the address, making sure to change the State

Result: Contact has correct new Address:

However Address Record still has Mailing State from previous address (Account).

**lurch: add

Included in beta release 3.107 (Beta 3)

Included in production release rel/3.107


String not always tokenized correctly

Checklist

[ ] This problem exists even with the setting "C_Cpp.enhancedColorization": "Disabled"
[ ] This bug exists for C
[x] This bug exists for C++
[ ] This bug exists for Objective-C
[ ] This bug exists for Objective-C++

The code with a problem is:
class TMyClass {
	QUERY_BEGIN("first part" MY_CONSTANT "second part");
}

It looks like:

It should look like:

Originally reported in https://github.com/microsoft/vscode/issues/128333 by @LaseriumFloyd

fixed


Images causing formatting issues

Places where an image is added have formatting issues:

See:
https://github.com/istio/istio.github.io/blob/master/_includes/figure.html
https://github.com/istio/istio.github.io/blob/master/_docs/tasks/installing-istio.md

I just looked at ipad and various desktops and this looks OK to me on a mac in chrome + FF. I don't see a layout issue.

I removed used of figure.html since it's not compatible with markdown's "semanrtic indenting" model. :-(


removed lib subdirectory from package.json ref

Hi,
I encountered an issue where my runtime requires weren't finding the plugin.js file.
Node was looking to postcss-nested-props/dist/lib/plugin.js as per the package.json, but the actual installed location was postcss-nested-props/dist/plugin.js.
I attempted various other machine-specific fixes:
reinitialized the containing docker container
removing and reinstalling my node_modules in the application
Neither of these resolved the issue.
I am unsure why there hasn't been any other noise on this, and I am additionally confused as my configuration was working not three days ago without the below modification.
This modification resolves this issue by pointing the main and types parameters to the appropriate issue. After this modification, node require can successfully find the plugin.js file.
Thank you for this project. Please let me know if I am errant in anything including the premise of this PR.

Thanks! I'll get this in right away. I had been reorganizing some file structure and missed this spot. Sorry!

Published @ v1.1.7.


feat(freespace_planning_algorithms): Tools for Python wrapper of freespace planning algorithms

Description

Debug tools for Python wrapper of freespace planning algorithms. New features are as follows:

GUI to generate manual costmap
Search for trajectory to goal on grid
GUI to visualize the searched results and the trajectories

See README for the detailed explanation.
Related links

Python wrapper of A* algorithms PR#6398
Interface changes
There are no changes in interfaces.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

I closed this PR because of some problem in the code temporarily.
Soon I will reopen it I fix it.


ARROW-11914: [R] [CI] r-sanitizer nightly is broken

This resolves the sanitizer error (thank you @lidavidm for the c++ solution!). I also added a step to print testthat.out if RDsan fails which we weren't doing before. Hopefully that helps diagnose these a bit easier in the future.

@github-actions crossbow submit test-ubuntu-18.04-r-sanitizer

@github-actions crossbow submit test-ubuntu-18.04-r-sanitizer

@github-actions crossbow submit test-ubuntu-18.04-r-sanitizer

This is failing, though now for a different reason: https://issues.apache.org/jira/browse/ARROW-12103

Can you rebase so that the tests run? Since you had WIP in the title, they weren't run on push.

The AMD64 Conda Integration test failure might be unrelated https://github.com/apache/arrow/pull/9814/checks?check_run_id=2205470543#step:8:4716
+ npm install
npm WARN tar ENOSPC: no space left on device, write
npm WARN tar ENOSPC: no space left on device, write
npm ERR! code ENOSPC
npm ERR! syscall write
npm ERR! errno -28
npm ERR! nospc ENOSPC: no space left on device, write
npm ERR! nospc There appears to be insufficient space on your system to finish.
npm ERR! nospc Clear up some disk space and try again.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-03-26T22_10_59_913Z-debug.log
228
Error: `docker-compose --file /home/runner/work/arrow/arrow/docker-compose.yml run --rm conda-integration` exited with a non-zero exit code 228, see the process log above.

The AMD64 Conda Integration test failure might be unrelated

I think so, I saw that on another PR yesterday. Would you mind making a JIRA for that if there isn't one?


add datastore-cluster to GlobalOpts

What this PR does / why we need it:
Introduce the datastore cluster to the global opts
None

/approve
/lgtm


Don't save uninitialized sessions to the store

See https://github.com/expressjs/session#saveuninitialized for detail

@petschekr Hold up this doesn't seem to have fixed the problem


Chaincode Package API FE BE not match

Now BE requires api/v1/chaincodes/chaincodeRepo, but the FE requires api/v1/chaincodes/package. Need to match either of them.
The payload is not match as well. FE sends the payload chaincodePackage: and description: but BE requires file: and description:

mentioned by #598


Forms, incl. Board's create item flow and a11y improvements

Open in Storybook ↗
Specs in Figma
• Fluent UI forms ↗
• Forms in MS Teams UI design kit ↗
• Board in “App Samples” ↗

@vikramjit-singh-chug I've resolved input alignment issues; accessibility has remained the same. Could you please re-review this PR and approve?


Unable to claim address immediately after ring is formed

host1$ weave reset
host2$ weave reset
host1$ weave launch $HOST2
host2$ weave launch $HOST1
host2$ docker $(weave config) run --rm -e WEAVE_CIDR=<IP_ADDRESS>/12 -ti alpine true
docker: Error response from daemon: Unable to claim: address <IP_ADDRESS>/12 is owned by other peer 0e:2a:9b:8e:23:fd (host1)

It appears that the unicast request for space arrives before the broadcast of the initial ring.

A unicast message is encoded before the call to send it, whereas a broadcast is encoded by a call back into the Allocator, which has to wait for the actor, so actually we will always send unicasts before broadcasts from the same actor.
By the same reasoning, the Sleep in Shutdown is pointless.


Temporary branches not removed

Using (a fork of) Autorebase, I now see this in our repo:

I think this happens when there is a merge conflict, btw.

The project has a test covering merge conflicts.
This test successfully executes on CircleCI targeting https://github.com/tibdex/github-apps-test. You can see in this repo that even when there is a merge conflict, github-rebase and its dependency github-cherry-pick clean up after themselves. Indeed, they both use this try/finally logic.
The only reason I can see for the temporary branches not being deleted would be because you're hitting GitHub REST API's rate limit.

Closing because I can't reproduce and there are already tests covering this.


build: ensure msrv 1.80.1 and upgrade dependencies

This refers to #8

thread 'test_macro_properties' panicked at fastrace/tests/lib.rs:758:5:
assertion `left == right` failed
  left: "\nroot []\n    bar_async []\n    foo_async [(\"k1\", \"v1\"), (\"a\", \"argument a is 1\"), (\"b\", \"Bar\"), (\"escaped1\", \"Bar{}\"), (\"escaped2\", \"{ \\\"a\\\": \\\"b\\\"}\")]\n"
 right: "\nroot []\n    bar []\n    bar_async []\n    foo [(\"k1\", \"v1\"), (\"a\", \"argument a is 1\"), (\"b\", \"Bar\"), (\"escaped1\", \"Bar{}\"), (\"escaped2\", \"{ \\\"a\\\": \\\"b\\\"}\")]\n    foo_async [(\"k1\", \"v1\"), (\"a\", \"argument a is 1\"), (\"b\", \"Bar\"), (\"escaped1\", \"Bar{}\"), (\"escaped2\", \"{ \\\"a\\\": \\\"b\\\"}\")]\n"

Seems the same problem as https://github.com/fastracelabs/fastrace/issues/9 but on linux.

@andylokandy Then perhaps merge this one and debugging the macro issue later?

Then perhaps merge this one and debugging the macro issue later?

Yes, was just waiting for ci to rerun


cm/abi: add the missing F32ToU64() and U64ToF32() join functions

closes #163

@Mossaka can you rebase and update changelog?

Done


refactor!: make modules the main focus, move files into module folders

Less clutter overall
A lot of the bling was unmaintained and underutilized
This part of the transition being discussed here: https://github.com/ublue-os/main/issues/476

This is a breaking change that removes features, features that were unmaintained and undocumented (or badly documented).

Looks very good.
Maybe we can remove ublue-os backgrounds rpm related stuff here too?

Maybe we can remove ublue-os backgrounds rpm related stuff here too?

I was thinking that'd be a later PR but I can do it now too, sure.

https://github.com/ublue-os/bling/blob/refactor/modules/bling/bling.sh#L12
This one needs to be:
export BLING_DIRECTORY="/tmp/modules/bling"

This one needs to be: export BLING_DIRECTORY="/tmp/modules/bling"

Good catch! This doesn't need to be at all, the $MODULE_DIRECTORYvar (supplied by build.sh, but also manually set just in case) is used instead.

I would approve


feat(lib): add "not" logical operator support

The not operator ! can be used with parenthesized expressions and will negate the result of the expressions.
Pratt parser is not used for this prefix operator because that would make:
! a == 1

Possible, which may cause confusions. Instead, this was implemented on the parenthesized expressions rule only so you can only write ! (a == 1).
KAG-3605

Which one do you like better? ! (a == 1) or not (a == 1)?

Which one do you like better? ! (a == 1) or not (a == 1)?

@dndx As we now have || and && instead of or and and in our grammar, IMO ! looks more consistent than not.

1 for ! which is more concise


[Bug]: Can't build android app

Application
Outline Client
Describe the bug
Using official docs I've setup an environment and try to build.
Requirements output (I don't think android target impact this bug):
Requirements check results for android:
Java JDK: installed 11.0.0
Android SDK: installed true
Android target: not installed
Command failed with exit code 1: avdmanager list target
Exception in thread "main" java.lang.NoClassDefFoundError: javax/xml/bind/annotation/XmlSchema
        at com.android.repository.api.SchemaModule$SchemaModuleVersion.<init>(SchemaModule.java:156)
        at com.android.repository.api.SchemaModule.<init>(SchemaModule.java:75)
        at com.android.sdklib.repository.AndroidSdkHandler.<clinit>(AndroidSdkHandler.java:81)
        at com.android.sdklib.tool.AvdManagerCli.run(AvdManagerCli.java:213)
        at com.android.sdklib.tool.AvdManagerCli.main(AvdManagerCli.java:200)
Caused by: java.lang.ClassNotFoundException: javax.xml.bind.annotation.XmlSchema
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:582)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
        ... 5 more
Gradle: installed C:\Gradle\bin\gradle.BAT

Steps to reproduce

Clone git
Switch to node 18
Install go 1.21
Install android requireements
Run npm run action client/src/cordova/build android

What did you expect to happen?
Build apk
What actually happened?
Error building
Outline Version
latest from github
What operation system are you using?

    BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.
        Do changes to assets earlier, e. g. in Compilation.hooks.processAssets.
        Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.
    (Use `node --trace-deprecation ...` to show where the warning was created)
  ▶ action(client/src/www/build): 🎉 Success! (18297ms)
  ▶ action(client/go/build):
    Running [node '--trace-uncaught' 'D:\outline\outline-apps\client\go\build.action.mjs' 'android']...
    Running [go 'run' 'github.com/go-task/task/v3/cmd/task' '-v' 'client:tun2socks:android']...
    task: [D:\outline\outline-apps] Not found - Using alternative (Taskfile.yml)
    task: "client:tun2socks:android" started
    task: "client:tun2socks:gomobile" started
    task: [client:tun2socks:gomobile] mkdir -p "D:\outline\outline-apps\client\output\build\bin"
    "mkdir": executable file not found in $PATH
    exit status 127
    exit status 1

    ERROR(spawn_stream): go run github.com/go-task/task/v3/cmd/task -v client:tun2socks:android failed with exit code 1.}
    Printing stderr:
    task: "client:tun2socks:android" started
    task: "client:tun2socks:gomobile" started
    task: [client:tun2socks:gomobile] mkdir -p "D:\outline\outline-apps\client\output\build\bin"
    "mkdir": executable file not found in $PATH
    exit status 127
    exit status 1

    node:internal/process/esm_loader:40
          internalBinding('errors').triggerUncaughtException(
                                    ^
    task: "client:tun2socks:android" startedtask: "client:tun2socks:gomobile" startedtask: [client:tun2socks:gomobile] mkdir -p "D:\outline\outline-apps\client\output\build\bin""mkdir": executable file not found in $PATHexit status 127exit status 1
    Thrown at:
        at loadESM (node:internal/process/esm_loader:40:33)
        at processTicksAndRejections (node:internal/process/task_queues:95:5)

    Node.js v18.20.4
    ERROR(spawn_stream): node --trace-uncaught D:\outline\outline-apps\client\go\build.action.mjs android failed with exit code 1.}
    Printing stderr:
    task: "client:tun2socks:android" started
    task: "client:tun2socks:gomobile" started
    task: [client:tun2socks:gomobile] mkdir -p "D:\outline\outline-apps\client\output\build\bin"
    "mkdir": executable file not found in $PATH
    exit status 127
    exit status 1
    ERROR(spawn_stream): go run github.com/go-task/task/v3/cmd/task -v client:tun2socks:android failed with exit code 1.}
    Printing stderr:
    task: "client:tun2socks:android" started
    task: "client:tun2socks:gomobile" started
    task: [client:tun2socks:gomobile] mkdir -p "D:\outline\outline-apps\client\output\build\bin"
    "mkdir": executable file not found in $PATH
    exit status 127
    exit status 1

    node:internal/process/esm_loader:40
          internalBinding('errors').triggerUncaughtException(
                                    ^
    task: "client:tun2socks:android" startedtask: "client:tun2socks:gomobile" startedtask: [client:tun2socks:gomobile] mkdir -p "D:\outline\outline-apps\client\output\build\bin""mkdir": executable file not found in $PATHexit status 127exit status 1
    Thrown at:
        at loadESM (node:internal/process/esm_loader:40:33)
        at processTicksAndRejections (node:internal/process/task_queues:95:5)

    Node.js v18.20.4
  ▶ action(client/go/build): ❌ Failed.
  ERROR(spawn_stream): node --trace-uncaught D:\outline\outline-apps\client\src\cordova\build.action.mjs android failed with exit code 1.}
  Printing stderr:
    (node:6856) [DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated.
    BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.
        Do changes to assets earlier, e. g. in Compilation.hooks.processAssets.
        Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.
    (Use `node --trace-deprecation ...` to show where the warning was created)
    task: "client:tun2socks:android" started
    task: "client:tun2socks:gomobile" started
    task: [client:tun2socks:gomobile] mkdir -p "D:\outline\outline-apps\client\output\build\bin"
    "mkdir": executable file not found in $PATH
    exit status 127
    exit status 1
    ERROR(spawn_stream): go run github.com/go-task/task/v3/cmd/task -v client:tun2socks:android failed with exit code 1.}
    Printing stderr:
    task: "client:tun2socks:android" started
    task: "client:tun2socks:gomobile" started
    task: [client:tun2socks:gomobile] mkdir -p "D:\outline\outline-apps\client\output\build\bin"
    "mkdir": executable file not found in $PATH
    exit status 127
    exit status 1

    node:internal/process/esm_loader:40
          internalBinding('errors').triggerUncaughtException(
                                    ^
    task: "client:tun2socks:android" startedtask: "client:tun2socks:gomobile" startedtask: [client:tun2socks:gomobile] mkdir -p "D:\outline\outline-apps\client\output\build\bin""mkdir": executable file not found in $PATHexit status 127exit status 1
    Thrown at:
        at loadESM (node:internal/process/esm_loader:40:33)
        at processTicksAndRejections (node:internal/process/task_queues:95:5)

    Node.js v18.20.4
    ERROR(spawn_stream): node --trace-uncaught D:\outline\outline-apps\client\go\build.action.mjs android failed with exit code 1.}
    Printing stderr:
    task: "client:tun2socks:android" started
    task: "client:tun2socks:gomobile" started
    task: [client:tun2socks:gomobile] mkdir -p "D:\outline\outline-apps\client\output\build\bin"
    "mkdir": executable file not found in $PATH
    exit status 127
    exit status 1
    ERROR(spawn_stream): go run github.com/go-task/task/v3/cmd/task -v client:tun2socks:android failed with exit code 1.}
    Printing stderr:
    task: "client:tun2socks:android" started
    task: "client:tun2socks:gomobile" started
    task: [client:tun2socks:gomobile] mkdir -p "D:\outline\outline-apps\client\output\build\bin"
    "mkdir": executable file not found in $PATH
    exit status 127
    exit status 1

    node:internal/process/esm_loader:40
          internalBinding('errors').triggerUncaughtException(
                                    ^
    task: "client:tun2socks:android" startedtask: "client:tun2socks:gomobile" startedtask: [client:tun2socks:gomobile] mkdir -p "D:\outline\outline-apps\client\output\build\bin""mkdir": executable file not found in $PATHexit status 127exit status 1
    Thrown at:
        at loadESM (node:internal/process/esm_loader:40:33)
        at processTicksAndRejections (node:internal/process/task_queues:95:5)

    Node.js v18.20.4
  ▶ action(client/go/build): ❌ Failed.
▶ action(client/src/cordova/build): ❌ Failed.

    task: [client:tun2socks:gomobile] mkdir -p "D:\outline\outline-apps\client\output\build\bin"
    "mkdir": executable file not found in $PATH
    exit status 127
    exit status 1

It seems you don't have mkdir installed. Can you confirm you are using the default PowerShell instead of a customized shell?

Hi there,
We're closing this issue due to inactivity. We haven't heard back from you in a while, and aim to keep our issue tracker organized.
If you're still experiencing this problem or have any additional information to share, please feel free to reopen this issue or create a new one.
Thank you for your understanding!


Add Documentation For View

CalendarView SwiftUI
Reason:
Changes:

What's change?
Why change?

Impact:

[x] Build Passing?
[x] Build On Real Device?

✅ Unit Test Success! <3

✅ Unit Test Success! <3

✅ Unit Test Success! <3


Throttle AudioIndicator animation

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

[x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details
JIRA link(s):

AHOYAPPS-554

Description
It appears that the recent addition of the Audio Indicator component may have increased the CPU usage of some users.  This PR throttles the computation of audio levels from ~60fps to ~20fps. It uses the interval function from D3's timer module, which is like setTimeout, but it uses requestAnimationFrame under the hood.
Burndown
Before review

[ ] Updated CHANGELOG.md if necessary
[ ] Added unit tests if necessary
[ ] Updated affected documentation
[x] Verified locally with npm test
[x] Manually sanity tested running locally
[ ] Included screenshot as PR comment (if needed)
[x] Ready for review

Before merge

[ ] Got one or more +1s
[ ] Re-tested if necessary

I added two more optimizations. I lowered the fftsize from 1024 to 512. This halves the number of samples to sum during each frame. I also moved new Uint8Array() outside of the animation loop so that one Uint8Array is created per component, instead of per frame.


How can I use it?

Sorry for lame question (I'm new to lua modules).
But can you be so kind to add step-by-step tutorial for your module?
Big thanks anyway!

I suppose LUA's 'require' automatically calls "luaopen_%module_name%" for native modules? Am I right?

Hi, thanks for notice this module :)
So, what kind of tutorial you want? basicly, after you install this module, you can run test.lua to see it works properly. and look into this file to know how to use it.
it just a thin wrapper for nanovg library, so documents of nanovg can used, you can go to [NanoVG][https://github.com/memononen/nanovg] to see details.
for install it, you can build nanovg and nvg.dll (for windows) or nvg.so (for *nix) yourself, but the easier way is using luarocks:
luarocks install glfw
luarocks install nanovg

after that, you can run test.lua directly, and try other functions yourself. :)
btw, the module name is after luaopen_, and replace _ with ., e.g. luaopen_pb_buffer can be in pb.dll and use require "pb.buffer" to include it.

Thanks for clearing this out! (Module wasnt published at luarocks 7 days ago :) )


A text file uploaded from windows is in modified status just after opening it.

As of late July, codemirror has a new option called 'lineSeparator',
which seems relevant to this problem.
Though the option may not solve our problem completely, it could still be useful.

@happibum
Please update codemirror folk as a latest version.
Then #707  will work.
Thanks.

Resolved by both #707 and #738


python311Packages.s3fs: 2023.9.0 -> 2023.9.1

Changelog: https://github.com/fsspec/s3fs/raw/2023.9.1/docs/source/changelog.rst
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 256383 run on x86_64-linux 1

16 packages built:

browsr
browsr.dist
dvc-with-remotes
dvc-with-remotes.dist
ome_zarr (python310Packages.ome-zarr)
ome_zarr.dist (python310Packages.ome-zarr.dist)
python310Packages.dvc-s3
python310Packages.dvc-s3.dist
python310Packages.s3fs
python310Packages.s3fs.dist
python311Packages.dvc-s3
python311Packages.dvc-s3.dist
python311Packages.ome-zarr
python311Packages.ome-zarr.dist
python311Packages.s3fs
python311Packages.s3fs.dist


No registered env with id: Nsmr-v1

can't run it

Please check the following two points.
・ Did you install nsmr?
pip install nsmr
・ Did you import nsmr in the program?
・・・・
import gym
import nsmr

・・・・


Implement RBF and CPFP with new fees package and add pending transactions view in @caravan/coordinator

This commit lays foundation of introduction of significant enhancements to be done to the transaction management capabilities of caravan/coordinator, focusing on Replace-By-Fee (RBF) and Child-Pays-For-Parent (CPFP) functionalities, along with a new pending transactions view.
Key changes Expected:

Pending Transactions View:

Add new component 'PendingTransactionsView' in src/components/Wallet/
Implement basic layout showing transaction ID, amount, recipient, and timestamp
Integrate view into main Wallet dashboard

Enhanced Transaction Information:

Add 'TransactionDetails' component to display comprehensive tx info
Implement time-pending calculation and display
Add current fee rate vs market rate comparison
Include estimated blocks until confirmation based on current mempool state

Fee Bumping Possibility Indicators:

Add RBF status indicator to transaction details
Implement change output detection and display
Calculate and show estimated cost for potential fee bump

UI Support for Manual RBF:

Modify existing transaction creation flow to support RBF
Add RBF toggle in transaction creation form (OutputsForm.jsx)
Implement logic to replace existing transaction when RBF is selected

Fee Bumping Interfaces:

Add 'CancelTransaction' button and associated logic
Implement 'AccelerateTransaction' functionality
Create 'DownloadPSBT' option for RBF/CPFP transactions
Modify transaction authoring page to support pre-filled RBF/CPFP data

Integration with new fees package:

Import and utilize functions from @caravan/fees for fee calculations
Implement FeeManager class to handle fee-related operations

State Management Updates:

Add new reducers for managing pending transactions and fee bump operations
Implement new actions for RBF and CPFP operations
Update selectors to support new state structure

Added RBF toggle to transaction creation (Step 1 of RBF/CPFP implementation) .... :)

This is how the functional Pending Tx Tab looks like ...


[#noissue] add break condition

add break condition for ConnectFuture.awaitUninterruptibly method

Codecov Report

Merging #4316 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4316      +/-   ##
==========================================
- Coverage   40.97%   40.95%   -0.03%
==========================================
  Files        2397     2397
  Lines       74786    74786
  Branches    10085    10086       +1
==========================================
- Hits        30647    30632      -15
- Misses      41323    41339      +16
+ Partials     2816     2815       -1

Impacted Files
Coverage Δ

...m/navercorp/pinpoint/rpc/client/ConnectFuture.java
89.47% <100%> (ø)
:arrow_up:

...rp/pinpoint/rpc/control/ControlMessageDecoder.java
64.28% <0%> (-14.29%)
:arrow_down:

...nitor/DefaultDataSourceMonitorRegistryService.java
77.77% <0%> (-11.12%)
:arrow_down:

.../pinpoint/rpc/client/PinpointClientHandshaker.java
60% <0%> (-6.43%)
:arrow_down:

...vercorp/pinpoint/web/vo/ApplicationAgentsList.java
72.3% <0%> (-3.08%)
:arrow_down:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
82.92% <0%> (-2.44%)
:arrow_down:

...corp/pinpoint/rpc/stream/StreamChannelManager.java
70.68% <0%> (-1.73%)
:arrow_down:

...m/navercorp/pinpoint/test/OrderedSpanRecorder.java
72.11% <0%> (ø)
:arrow_up:

...point/rpc/client/DefaultPinpointClientHandler.java
71.38% <0%> (+0.32%)
:arrow_up:

...java/com/navercorp/pinpoint/rpc/DefaultFuture.java
74.16% <0%> (+1.66%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e621dc7...372f47f. Read the comment docs.


Allow disabled addons to be omitted from .config

When running make config or make menuconfig, options that are disabled don't necessarily go into .config with values of n. In some versions of kconfig-frontends, like the one in this repo's Docker image, comments get stored instead:
# .phase3.dashboard is not set

Without this change, attempting to run make addons or even just phase3/do gen chokes on these values, since jsonnet can't find configuration for them. With the change, it treats addons omitted from .config as disabled.
This should also help upgrade-proof clients that automate the creation of .config, so upstream additions of new addons don't render old .config files broken.

looks good.
Verified change.

LGTM. Thanks @divyenpatel for testing.


feat: Use new issue forms instead of templates

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Bug - Observatory List Items

Saw a bug come in that @georgiamoon caught and documented in issue #138.  Excellent catch BTW!
I think there are some other cases of conflicting styles happening between codebases on that page (i.e. - the main nav, no footer, etc), so we can probably tighten this up even more as well.  But this is one item that I know I introduced with the SASS styling cutover, so wanted to get this fix in at least since I know exactly what was causing that.
This fix changes the class to an id & renames it so we shouldn't have to worry about any specific classes for native pages overriding the submodules styling.  The only issue now would be base classes from each codebase, so needed to target the list items within that new section id to get it back to the intended submodule styling.

This change is

Comments from the review on Reviewable.io


issue-27. Add circle references support

Codecov Report

Merging #35 (972c4b0) into main (01482c4) will increase coverage by 0.28%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   88.77%   89.06%   +0.28%
==========================================
  Files          15       15
  Lines         766      777      +11
==========================================
+ Hits          680      692      +12
+ Misses         86       85       -1

Impacted Files
Coverage Δ

pythogen/renderer.py
86.15% <50.00%> (-1.95%)
:arrow_down:

pythogen/models.py
98.99% <100.00%> (+<0.01%)
:arrow_up:

pythogen/parsers/schemas.py
93.10% <100.00%> (+3.17%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Custom auth breaks subsetdiff

[opc@bastion tanka]$ tk diff environments/default/ --diff-strategy subset
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
Error from server (NotFound): deployments.extensions "kube-state-metrics" not found
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
Error from server (NotFound): configmaps "grafana-config" not found
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
Error from server (NotFound): services "grafana" not found
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
Error from server (NotFound): clusterrolebindings.rbac.authorization.k8s.io "kube-state-metrics" not found
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
Error from server (NotFound): clusterroles.rbac.authorization.k8s.io "kube-state-metrics" not found
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
Error from server (NotFound): deployments.extensions "nginx" not found
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
Error from server (NotFound): deployments.extensions "grafana" not found
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
Error from server (NotFound): serviceaccounts "kube-state-metrics" not found
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
Error from server (NotFound): services "nginx" not found
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
Error from server (NotFound): configmaps "grafana-datasources" not found
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
Error from server (NotFound): services "kube-state-metrics" not found
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
Error from server (NotFound): configmaps "grafana-notification-channels" not found
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
Error from server (NotFound): daemonsets.extensions "node-exporter" not found
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
Error from server (NotFound): configmaps "grafana-dashboard-provisioning" not found
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
Error from server (NotFound): configmaps "nginx-config" not found
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.
Error from server (NotFound): configmaps "dashboards" not found
calculating subset: getting state from cluster: exit status 1
[opc@bastion tanka]$

The error line breaks our "kubectl error detection" (strings.HasPrefix)

Here, this is using Oracle's OKE, which, like Amazon's EKS, uses an auth tool, referenced in kubeconfig, like so:
users:
- name: some-user
  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1beta1
      args:
      - ce
      - cluster
      - generate-token
      - --cluster-id
      - xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
      - --region
      - us-xxxxxxx-1
      command: oci
      env: []

Obviously the oci auth tool is spitting out a stderr method that is breaking things:
WARNING: OCI CLI now requires Python 3.5+. Please install or upgrade your version of Python to 3.5+ before February 13, 2020 to avoid interruption to CLI usage.


1.0

Breaking changes!
Modifying all return values from functions to match what is idiomatic Elixir. For example:
# Successful
{:ok, response}

# Error
{:error, 404, "list not found"}

# Connection Error
{:connection_error, "nxdomain", "Connection error."}

This should make a lot more sense to users as they will no longer have to handle any raised exceptions.
If I missed any changes to documentation please shoot an email over to me or open an issue on this repo 😄

Coverage decreased (-1.5%) to 95.556% when pulling b029094b90ab7242291ddd462cf35024954795fc on 1.0 into 049cc41bacd3b50b9c214a3d170379ceff12897b on master.

Coverage increased (+0.2%) to 97.175% when pulling d3f8b5285c5c562def56d9065da9b324b62c3fce on 1.0 into 049cc41bacd3b50b9c214a3d170379ceff12897b on master.

Coverage increased (+0.2%) to 97.175% when pulling de8fa3285965bb04b04e543988c0ccd2b2958eea on 1.0 into 049cc41bacd3b50b9c214a3d170379ceff12897b on master.

Coverage increased (+0.2%) to 97.175% when pulling<PHONE_NUMBER>20c1590b5b45a5cc398cc07c84ea32 on 1.0 into 049cc41bacd3b50b9c214a3d170379ceff12897b on master.

Coverage increased (+0.2%) to 97.175% when pulling e2485fb4cfe2a1d6dadeba3e5d36196376e6e6c2 on 1.0 into 049cc41bacd3b50b9c214a3d170379ceff12897b on master.

Eggcellent 👍


[ISSUE-1324] advertize that subaddressing is supported

We need to have the front automatically detecting if the backend supports subaddressing or not.
thus i modified the urn:apache:james:params:jmap:mail:shares capability to add a subaddressingSupported property (boolean). the front will be so that if this property is not defined, then it assumes it is not supported.

Question 1: Why do we need this?
Question 2: Why isn't the doc updated? ( https://github.com/apache/james-project/blob/master/server/protocols/jmap-rfc-8621/doc/specs/spec/mail/rights.mdown#defined-capability )
Question 3: Why ISSUE-1324? THis is NOT an ASF bugtracker. Can we git inspect to find a related issue where we could explain what we do here? And use it as a PR title / commit message prefix?


updated default name

What are the issues this pull addresses (issue numbers / links)?
#579
Did you add tests to cover your changes (yes/no)?
No
Did you update the documentation accordingly (yes/no)?
No
Did you read the CONTRIBUTING document (yes/no)?
Yes
Summary
Default param name for "name" for QComponent is class name
Details and comments

Regarding Zlatko's above comment, this if param_name is not None: is currently used only to rename the default "name" argument to be, for example, TransmonPocket-654 or NGon-342


sh: 1: python: not found

When i tried to start the backend i got this error "sh: 1: python: not found".
I've installed it in ubuntu. What i can do?

https://askubuntu.com/questions/1144446/python-installed-in-ubuntu-but-python-command-not-found


restore the fix for 24928

Signed-off-by: Chunxi Luo<EMAIL_ADDRESS>https://github.com/stolostron/backlog/issues/24928
cherry-pick to release-2.6

/cc @KevinFCormier

/lgtm


Added zeroconf instance passing.

Home Assistant has a builtin integration which provides an initialized Zeroconf instance, and recommends not initializing a new one. This instance can be obtained through homeassistant.components.zeroconf.async_get_instance(hass) when the integration's manifest has the zeroconf dependency.
For this purpose, the discover_devices function now takes an optional parameter called zeroconf_instance in which you can pass this instance. If not set (or set to None) the function will initialize a new instance automatically.

Running pre-commit manually and committing again, not sure why it did not run.


ARM template example

It might be useful to link an ARM template example.
I added a comment to a github issue to show how I did it: https://github.com/MicrosoftDocs/azure-docs/issues/19171#issuecomment-863070474

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0509cf1e-09a8-5cca-aaaa-2dede16e18ef
Version Independent ID: 1524b0e5-9328-120a-c7cf-e47bfc60f624
Content: Azure Event Grid - Diagnostic logs for topics or domains - Azure Event Grid
Content Source: articles/event-grid/diagnostic-logs.md
Service: event-grid
GitHub Login: @spelluru
Microsoft Alias: spelluru

@qualitas-software, Thanks for the feedback! We are taking a look into this and will get back to you soon.

Hello @qualitas-software, apologies for the delay here. We have assigned this issue to the author to review further and take the next course of action.
@spelluru, could you please have a look at this issue? and confirm if we can add the ARM template example referenced. Thank you!

@qualitas-software - Thank you for sharing your example. I have updated the following article.
https://docs.microsoft.com/en-us/azure/event-grid/enable-diagnostic-logs-topic#use-azure-resource-manager-template
#sign-off

#please-close


Multiple du-scrollspy directives not working

It looks like you cannot have multiple du-scroll spy directives active at the same time.
Image as TOC as follows. Only the first instance of ng-repeat will work with scrollspy - the other 2 will do nothing.

{{section}}

{{section}}

{{section}}

This also caused problem on my project... having to abandon this library because of this issue.

Did you guys tried to add an offset?

Works fine for me. You may need a {{du-spy-context}} though:

Perhaps one other difference, I'm not passing the target ID to scrollspy, but to smooth-scroll:

You also only have one instance AFAICS.
You will notice mine has 3 ng-repeats. It works with one, just not more than one.

In fact I have multiple ng-repeats because they are repeated themselves.
Even more: I have nested ng-repeats that each have scrollspys.
I didn't want to throw the whole block of code at you, but since it might help, here it is (I'll try and cut the irrelevant parts):

If you wonder about du-spy-context="questionnaire" that's some custom functionality that I added in a fork for a specific use case, but it will work without it.

I seem to be having the same issue. Is there any workaround?


Remove hover option for Filters

Acceptance Criteria
Scenario 1:
GIVEN Workplan page is open
WHEN I hover over in-grid filters such as 'Type', 'Start Date', 'End Date', 'Days', 'Assigned', 'Responsibility', 'Progress'
THEN I don't see the hover option

Only title, assigned and responsibility column should need to have hover options as per the current requirement.


Increase default value of maxBuffer (and make it configurable)

resolves #39

Hi and thanks @Mogztter  for this bugfix. Will the UNXHR_MAX_BUFFER environment variable be configureable (as well) via a kroki-xyz setting in the asciidoc document or may be set in the asciidoc vs plugin?
... or is it this environment variable - period? :)
Cheers,
Mario :)

Hey @mariotoffia

Hi and thanks @Mogztter for this bugfix. Will the UNXHR_MAX_BUFFER environment variable be configureable (as well) via a kroki-xyz setting in the asciidoc document or may be set in the asciidoc vs plugin?

No, it will only be an environment variable but 100 MB should be more than enough.
This hard limit is specific to Node.js (JavaScript runtime) and not tied to Kroki or Asciidoctor so it does not make sense to introduce a setting or an AsciiDoc attribute.
If you are working with diagrams that are larger than 100 MB then you probably need to fine tune your runtime environment (Node.js) hence the environment variable.


Cropping a Dolby Vision video breaks tone mapping

Setup (please complete the following information):

OS: Windows 11 22H2
Player: mpv
Player Version: 0.35.0-210-ge439ddc0
Video Quality: 1080p HEVC Dolby Vision Profile 5

Describe the bug
This is a very specific use case and is definitely not common, but I figured I'd mention it here anyway. While the dynamic crop script does work perfectly in cropping black bars, if the video needs tone mapping of any kind, such as with vo=gpu-next and target-colorspace-hint=yes, this script makes it no longer possible. I'm assuming this is due to the fact that its using LAV filters to determine the black bars, and the images the filters are grabbing are not tone mapped.
I've tried using vf-append or vf-pre to add the correct tone mapping filters back to the video after cropping, but that did not work either.

Hello, do you use hardware decoding ? it can be the cause for color issue (cropdetect auto insert a pixel format conversion, and we lose 10bit color), try hwdec=no.
Also make sure to have the most up to date mpv version.
Then i'm going to need the logs of mpv if it's still an issue, i can only replicate it with the HEVC DolbyVision video i have and hwdec=auto-copy like explain above.

It looks like that was the culprit, thank you! I'm surprised that shaders and tone mapping still work with HW decoding being disabled. It didn't drop any frames either.

(cropdetect auto insert a pixel format conversion, and we lose 10bit color)

Does pixel format conversion only happen in hardware decoding or HDR video?
Will 10bit SDR be affected?

(cropdetect auto insert a pixel format conversion, and we lose 10bit color)

Does pixel format conversion only happen in hardware decoding or HDR video? Will 10bit SDR be affected?

Pixel format conversion is more likely to happened with HW dec and for HDR/SDR/8bit/10bit I'm not sure.
Looks fine with recent mpv/ffmpeg build (without the ffmpeg patch provided in this repo), can't be sure it's the case for everyone.
You have to try different setup.
my mpv.conf: (with RX7900XT)
vo=gpu-next
gpu-api=vulkan
hwdec=vulkan-copy
fbo-format=rgba16hf


Sass Error when changing breakpoints.

I get a compilation error when changing breakpoints using the example code.
$breakpoints: (
small: rem-calc(0),
medium: rem-calc(640),
large: rem-calc(1024),
xlarge: rem-calc(1200),
xxlarge: rem-calc(1440)
);
Libsass 3.4.1
--
bower_components/foundation-sites/scss/util/_unit.scss
Error: argument $number of unit($number) must be a number
   Backtrace:
   	bower_components/foundation-sites/scss/util/_unit.scss:49, in function `unit`
   	bower_components/foundation-sites/scss/util/_unit.scss:49, in function `-zf-bp-to-em`
   	bower_components/foundation-sites/scss/util/_breakpoint.scss:146, in function `-zf-bp-serialize`
   	bower_components/foundation-sites/scss/foundation.scss:52
    on line 49 of bower_components/foundation-sites/scss/util/_unit.scss

@if unit($value) == 'px' or unit($value) == '' {
------^

Hey @christianmagill - i got the same error when i tried to create my own breakpoints. All you have to do is to add one breakpoint more into your $breakpoints and don't add it to the $breakpoint-classes.
In your example just add something like xxxlarge:rem-calc(9999) and compile again. Or just remove the xxlarge from your $breakpoint-classes.
I will check the Code later, becuase I don't know if it is a bug or a feature. ;)

Try using pixel values instead and see if that fixes it. (They still get converted to em for the media queries.)
$breakpoints: (
  small: 0,
  medium: 640px,
  large: 1024px,
  xlarge: 1200px,
  xxlarge: 1440px,
);

Wondering if the pixel value helped in this situation?

Looking at this closer, I realize it's happening because rem-calc() is not defined in your Sass code yet, so the breakpoint converter is trying to convert the value rem-calc(640) instead of, say, 40rem. Verify that _settings.scss has @import 'util/util' at the top; this is what will load rem-calc() into your Sass.
If that doesn't work, if you revert to pixel values, the error will go away. Any value you put in there is converted to ems at the end.
Related: #7021

I don't have custom breakpoints declared and I'm running into this error.
{ [Error: node_modules/foundation-sites/scss/util/_unit.scss
Error: argument $number of unit($number) must be a number
   Backtrace:
   	node_modules/foundation-sites/scss/util/_unit.scss:57, in function `unit`
   	node_modules/foundation-sites/scss/util/_unit.scss:57, in function `-zf-bp-to-em`
   	node_modules/foundation-sites/scss/components/_visibility.scss:9, in mixin `show-for`
   	resources/assets/sass/_frame.scss:9
    on line 57 of node_modules/foundation-sites/scss/util/_unit.scss
>>   @if unit($value) == 'px' or unitless($value) {

_frame.scss:9 is @include show-for(medium up);. I'm not sure what's wrong. I have just upgraded from Foundation 5 but my other project (Foundation 6 fresh start) doesn't have this problem.


README about programatically toggle the menu isn't correct

Using the latest in the master branch, the toggle code examples don't work (https://github.com/godot-extended-libraries/godot-debug-menu#usage).
If I do that, I get errors that the Canvas does not have those properties.
If I instead do this:
var debug_menu = DebugMenu.get_node("DebugMenu")
debug_menu.style = debug_menu.Style.VISIBLE_COMPACT

Then as well the NONE should be HIDDEN instead
var debug_menu = DebugMenu.get_node("DebugMenu")
debug_menu.style = debug_menu.Style.HIDDEN

I'm not sure if this is expected behavior or not, if it is I could open a PR for some README changes.

This was likely changed by https://github.com/godot-extended-libraries/godot-debug-menu/commit/2d1bf27e5901186080e0fde5adc56df65dd9c583.
The correct fix is to put the script on the CanvasLayer instead of a child Control node, so that you can set properties directly on DebugMenu instead of having to use get_node(). Feel free to open a pull request for this :slightly_smiling_face:

Ah gotcha, I'll see if I can make that work locally and if so provide a PR soon.

Created a PR in https://github.com/godot-extended-libraries/godot-debug-menu/pull/16


value changed loop

typing two or more characters simultaneously can cause aurelia mask to go into a loop where the value oscillates between two different values.
Seems to occur with current aurelia. Not sure when this started being a thing, but I have an older aurelia cli project with<EMAIL_ADDRESS>where I am not getting this behavior

looks like removing valueChanged fixes it, which I think is only necessary to accomplish two way binding. If there is a way to make valueChanged not respond to UI events, that would be ideal, otherwise two way binding will be getting the axe.

this is fixed in 2.0.0


C++ modules should start using setters and getters

Describe your use case
C++ Basilisk modules sometimes have user configurable variable foo defined as a public variable set, and thus set through
mod.foo = 1.0

Some modules use setters and getters where the module variable is set using
mod.setFoo(1.0)

Describe alternatives solutions you've considered
Going forward we should have all new C++ Basilisk module variables be private and user setter and
getter methods.  The setter method should check if the variable is being given valid number(s).  Required variables
can still be checked in the module Reset() method.   This way the python code with throw an immediate error if a
variable is set to an invalid value.
Further, if the use of a variable is being depreciated, the associated setter and getter methods can be gracefully
depreciated.  If the variables are public class variables, there is now way to catch all the ways this variable could be set.
Additional context
All the instructions need to be updated to discuss using setters and getters in C++ modules, the makeDraftModule.py
script needs to be updated, the C++ template modules need updating.  Further, with private variables it the regular
module variable logger cannot be used.  Documentation needs to be updated on how to log a private class variable.

@juan-g-bonilla , Iust pushed my setter/getter branch to feature/bsk_715_setterGetter.  I'm able to log the private variables now with the get method.  However, I wonder if we should make a new utility function in sys_model.i  called loggerGet() that logs specifically a variable foo with the method getFoo()?  If setters and getters are becoming the norm, then I feel we should make this logging process easier.
Or, can we expand the logger() functionality to see if the variable can be accessed via mod.foo.  If not, then try using mod.getFoo().  If that doesn't work, then throw the current error message?  That way the logging interface for public variables and getter accessible private variables remains the same?

bsk_715_setterGetter

I see the issue now. The thing is that because we are using raw C arrays, we need to return them from functions as pointers:
double * getFoo();

but then SWIG does not have enough information to transform that into a Python type (because it doesn't know the length of the data). There is really no way to return something like this in C++:
double[3] getFoo();

So we would need to use a more information rich type. I've added some commits with a switch to using std::array<double, 3> and SWIG changes to support that. I've also updated .logger with your idea about automatically finding getters, and it seems to work pretty good. As long as the documentation explains what's going on, I think it's a good change. Feel free to reset and play around with my changes.
Changing from C arrays to std::array might require some code churn, but I think it's step in the right direction anyway. Of course C arrays will still be necessary in C messages, but intermixing C arrays and std::array is pretty painless.


Decide what to do with jme3-awt-dialogs

Decide what to do with jme3-awt-dialogs. Should we include it by default to a new Gradle project? Without this dependency the resolution dialog does not show. Basically it comes down to these options:

Include it
Don't include it
Only include if LWJGL 2 is selected (since here it doesn't cause any problems)

Our new Gradle wizard is cool and all. We just need to make it aware that jME 3.6 and up would have this. This is slightly related to https://github.com/jMonkeyEngine/sdk/issues/371. As with that, we also have access to Maven. So we could make the check so that if it is available for this and this version, mark it (and include it).

A quick fix is to add a numerical version (3.5, 3.51, 3.52, 3.6 etc) to the JMEVersion enum, and then add a conditional check that JME version >= 3.6 (and/or LWJGL version = 2) in the build.gradle.ftl FreeMarker template and add in the dependency on jme3-awt-dialogs
I was going to update the enums with latest versions when JME3.6 was released, so can smash this out super quick :+1:
TBH, I currently avoid Maven like the plague in NB, due to the issue @neph1 describes in #451 - if you enable Maven support, NB will download and unpack the entire Maven central index to your user cache, and use that for searching.  This can take several minutes, and I think is a frustrating experience for new users just trying to create a project?  If NB is ever updated to just search Maven repos online, I would feel much better about this option.
Another long term option is to combine forces with the jMonkey Initilizer and call the Initilizer API from the new project wizard?  I think this is how the Spring Boot NB plugin works with the Spring Boot Initializer.
The downside to the initializer is it doesn't currently create an /assets folder which the ProjectAssetManager in the SDK expects - but the SDK could probably be updated to create the Assets node off the resources folder and listen there for new assets to make available e.g. in texture browser immediately.
Also. the Initializer structure of having a core app module, then different 'launcher' modules for Windows, Linux, Android etc. is probably very sensible for 'serious' JME projects, but maybe a bit complex for new users just trying to get started??
Anyways, whatever the long term solution is, I'm happy to contribute :+1:

Ive already started with https://github.com/jMonkeyEngine/sdk/issues/371.
The branch should be linked on the issue. I used the Maven Search API as I
didnt find a way to utilize any internal NB platform functionality. Do you
know anything about this?
I also will change a bit how the versions and libraries are coded. Or
already changed rather. Didnt get to jME versions yet though.
On Sat, 28 Jan 2023, 12:26 Pete Whelpton, @.***> wrote:

A quick fix is to add a numerical version (3.5, 3.51, 3.52, 3.6 etc) to
the JMEVersion
https://github.com/jMonkeyEngine/sdk/blob/master/jme3-templates/src/com/jme3/gde/templates/gradledesktop/options/JMEVersion.java
enum, and then add a conditional check that JME version >= 3.6 (and/or
LWJGL version = 2) in the build.gradle.ftl
https://github.com/jMonkeyEngine/sdk/blob/master/jme3-templates/src/com/jme3/gde/templates/files/freemarker/build.gradle.ftl
FreeMarker template and add in the dependency on jme3-awt-dialogs
I was going to update the enums with latest versions when JME3.6 was
released, so can smash this out super quick 👍
TBH, I currently avoid Maven like the plague in NB, due to the issue
@neph1 https://github.com/neph1 describes in #451
https://github.com/jMonkeyEngine/sdk/issues/451 - if you enable Maven
support, NB will download and unpack the entire Maven central index to your
user cache, and use that for searching. This can take several minutes, and
I think is a frustrating experience for new users just trying to create a
project? If NB is ever updated to just search Maven repos online, I would
feel much better about this option.
Another long term option is to combine forces with the jMonkey Initilizer
https://start.jmonkeyengine.org/ and call the Initilizer API from the
new project wizard? I think this is how the Spring Boot NB plugin works
with the Spring Boot Initializer.
The downside to the initializer is it doesn't currently create an /assets
folder which the ProjectAssetManager in the SDK expects - but the SDK could
probably be updated to create the Assets node off the resources folder and
listen there for new assets to make available e.g. in texture browser
immediately.
Also. the Initializer structure of having a core app module, then
different 'launcher' modules for Windows, Linux, Android etc. is probably
very sensible for 'serious' JME projects, but maybe a bit complex for new
users just trying to get started??
Anyways, whatever the long term solution is, I'm happy to contribute 👍
—
Reply to this email directly, view it on GitHub
https://github.com/jMonkeyEngine/sdk/issues/460#issuecomment-1407368301,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB7VJPQHOPCCIPB5Q4TSTSLWUTX6DANCNFSM6AAAAAAUH6ZX7Q
.
 Gradle was too close to the heart now.

A quick fix is to add a numerical versions (Major = 3, Minor = 5, Patch = 0) to the JMEVersion enum, and then add a conditional check that JME major version >= 3 and minor >= 6 (and/or LWJGL version = 2) in the build.gradle.ftl FreeMarker template and add in the dependency on jme3-awt-dialogs
I was going to update the enums with latest versions when JME3.6 was released, so can smash this out super quick 👍
TBH, I currently avoid Maven like the plague in NB, due to the issue @neph1 describes in #451 - if you enable Maven support, NB will download and unpack the entire Maven central index to your user cache, and use that for searching. This can take several minutes, and I think is a frustrating experience for new users just trying to create a project? If NB is ever updated to just search Maven repos online, I would feel much better about this option.
Another long term option is to combine forces with the jMonkey Initilizer and call the Initilizer API from the new project wizard? I think this is how the Spring Boot NB plugin works with the Spring Boot Initializer.
The downside to the initializer is it doesn't currently create an /assets folder which the ProjectAssetManager in the SDK expects - but the SDK could probably be updated to create the Assets node off the resources folder and listen there for new assets to make available e.g. in texture browser immediately.
Also. the Initializer structure of having a core app module, then different 'launcher' modules for Windows, Linux, Android etc. is probably very sensible for 'serious' JME projects, but maybe a bit complex for new users just trying to get started??
Anyways, whatever the long term solution is, I'm happy to contribute 👍

@peedeeboy I have merged the Maven API automation things. And there I changed how the versions are interpreted. They can be now quite accurately be compared. And the enums can still be manually updated. Manually entered enums always override the automation. Which may or may not work always :)


Is it possible to add filters on tags?

Problem
It would be really helpful
Solution

Additional details
No response

Added in 6.8.0


option to prepend or append channels in channelwise op

Small update of ChannelwiseOperator: Sometimes the channel dimension is the first one and sometimes it can be the last one. Previously ChannelwiseOperator would always prepend the channel dimension. With this update, the user can now give an input dimension to say whether to prepend or append the channel dimension. This came about when doing colour inpainting in which the channel dimension is the last one, so the previous ChannelwiseOperator would not work, unless cumbersome permutation with subset was done back and forth. Note that this update is required for
https://github.com/vais-ral/CIL-Demos/pull/41
to work.

Yes, I figured prepending would be a good default, but needed append for a colour image had channels last. I guess if we keep using prepend and append for now, then later if needed we could also added the option that dimension could be a nonnegative integer to specify which number the dimension should be. One could still have prepend and append for convenience and to not lose backward compatibility.


desktop version: navbar spacing

great work 💯
A suggestion:

in the spacing between the logo and the nav bar they are kinda close to each other ...try to give it some spacing.

Spaces between the logo nav bar has been set


Update performance test results for Ballerina v1.0.1

Purpose
This PR updates the performance test results for Ballerina v1.0.1.
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #19345 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19345   +/-   ##
=======================================
  Coverage   15.71%   15.71%
=======================================
  Files          47       47
  Lines        1266     1266
  Branches      197      197
=======================================
  Hits          199      199
  Misses       1054     1054
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efa5d9f...49d0bbb. Read the comment docs.


utils prop in the HOC is way too generic

Hello! While saying thank you for all your effort, i may have an humble suggestion
Is your feature request related to a problem? Please describe.
<MuiPickersUtilsProvider utils={DateFnsUtils}>
utils is definitely a too much generic name. In fact I have problems using this lib because everywhere i mien everywhere in my app I have something imported as utils, which obviously conflicts. Date pickers are just a part of bigger applications (except for small demo apps) having an utils prop "reserved" at high priority it's not an ideal scenario IMHO.
I solved positioning the HOC as close as the pickers, but this can load to bad code practices such has repetition etc...
Another solution may be switching to hooks
Describe the solution you'd like
My solution is simply to call this prop in another way, something like muiPickersUtils.
thank you for your time

It is already renamed in v4

ok sorry, currently using v3, did not know

The new name is dateAdapter.


in my jobs i see a job that is not in the list anymore

when i go to My Jobs tab, i see a job+build assigned to me, but when i enter it, i get an empty page... when i go to the test, and search for that build, it doesn't exist anymore (the last one in the list), here:

and when i open the job, i see this:

how can i either check that build, or to remove it from my assigned jobs?

The arrow link opens it in a new tab and is most likely using old url, that is a bug.
You can click "Open" instead to open it inline and see that job.

~The arrow link opens it in a new tab and is most likely using an old url, that is a bug.~ EDIT: Workspace page only shows latest 10 jobs with no way currently to provide additional runs unlike my jobs inline page or external jobs link. You can click "Open" instead to open it inline and see that job.

I suffer from same issue, i'm the owner of this week short longevity, and all of a sudden any old unassigned run are on my name.
some of them are old, and not in the 10 last runs, and I can get to them, not even when clicking the open in a different window button
http://<IP_ADDRESS>/test/15be1195-ceeb-4b3b-ad9b-e5ec1e4221c2/runs?additionalRuns[]=f462d0a4-a39e-4d6a-b11d-f3e483bfcc23


pixsfm cameras of Campus dataset

Hi, seems the camera parameter link of Campus has broken (https://storage.cmusatyalab.org/mega-nerf-data/campus-pixsfm.tgz). Could you please update the link so we could fully test on the datasets? Thank you very much.

Not sure where that link is from but there is no campus-pixsfm.tgz dataset.
I can see the following files,

campus-pixsfm-8.pt
campus-pixsfm-grid-8.tgz
campus.tgz

I don't know which one you need, looking at the naming of the other datasets it may be that campus-pixsfm.tgz has not been uploaded (yet?).

@jaharkes Hi, thank you for your response. The link is from the README.md
https://github.com/cmusatyalab/mega-nerf/blob/76d8d76b66d70f8a0819defc0cef4fb9aa251672/README.md?plain=1#L66
Similar to other dataset, we need campus-pixsfm.tgz for better camera parameters. But the link seems broken. Would you mind to reupload the this dataset? Thank you very much!

I have the same question about 'the link'.  Could you help me?  Thank you very much!   #28

hey folks - the link should work now - sorry for the delay


Tee Object Respects WhatIf Despite Not Impementing WhatIf

Tee should either implement a WhatIf flag that I can set to -WhatIf:$False or completely ignore WhatIf
Steps to reproduce
https://windowsserver.uservoice.com/forums/301869-powershell/suggestions/15374424-tee-object-doesn-t-work-in-scripts-functions-that
function Test-Tee {
    [Cmdletbinding(supportsshouldprocess)]
    Param()
    $true|tee -Variable b
    $b
}

Test-Tee

Test-Tee -WhatIf

Expected behavior
Return true for both
PS H:\> Test-Tee
True
True

PS H:\> Test-Tee -WhatIf
True
True

Actual behavior
PS H:\> Test-Tee
True
True

PS H:\> Test-Tee -WhatIf
True
What if: Performing the operation "Set variable" on target "Name: b Value: True".

Environment data

Name                           Value
----                           -----
PSVersion                      5.1.17134.48
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17134.48
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Name                           Value
----                           -----
PSVersion                      6.0.2
PSEdition                      Core
GitCommitId                    v6.0.2
OS                             Microsoft Windows 10.0.17134
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Issue is with ShouldProcessParameters in common and is repro in latest nightly build,

Is this not simply expected behaviour? If I implement a function that doesn't have ShouldProcess support, which then calls a function that does... I should be able to wrap my original in a function that does support ShouldProcess in order for PS to echo that call down to the function that actually supports it:
function Test-NotSP {
    Set-Variable -Name "Test" -Value "Testing..."
    $Test
}
function Wrap-WithSP {
    [CmdletBinding(SupportsShouldProcess)]
    param()
    Test-NotSP
}

Wrap-WithSP -WhatIf

So... Don't use Set-Variable where you don't need it, then? Just do regular variable assignment.

I don't think you're getting the point.
With Set-Variable because it does have a settable -WhatIf I can choose to manually exclude it from any wrapping ShouldProcess however Tee-Object is lacking that parameter I cannot chose to exclude it and thus cannot use it in any function that implements ShouldProcess

Seems fair. Shouldn't be overly difficult to have it respect -WhatIf by the looks of it, then; most likely it would simply be adding the attribute parameter.

+1 just encountered this while trying to implement WhatIf on my own cmdlet.


[bug]: Generated form with only drop down form fields has missing methods and multiple errors

Describe the bug
When running stacked generate with a form consisting of only dropdown fields, the generated form.dart contains missing methods.

The method '_updateFormData' isn't defined for the type $View
The method 'validateForm' isn't defined for the type 'FormStateHelper'

If you add these methods back from another generated form with some text fields, the methods are resolved.  I think the current code must expect at least one TEXT form field before it adds the _updateFormData and validateForm methods in them.
FYI: My annotation definitions are:
@FormView(
  fields: [
    FormDropdownField(
      name: 'goal1Priority',
      items: AppGoal.all,
    ),
    FormDropdownField(
      name: 'goal2Priority',
      items: AppGoal.all,
    ),
    FormDropdownField(
      name: 'goal3Priority',
      items: AppGoal.all,
    ),
  ],
  autoTextFieldValidation: false,
)

With an AppGoal defined as:

class AppGoal {
  static const List<StaticDropdownItem> all = [
    StaticDropdownItem(title: '1st', value: '1'),
    StaticDropdownItem(title: '2nd', value: '2'),
    StaticDropdownItem(title: '3rd', value: '3'),
  ];
}

What operating system do you use?
macOS
Information about the installed tooling
[✓] Flutter (Channel stable, 3.19.2, on macOS 13.6.4 22G513 darwin-arm64, locale en-NZ)
    • Flutter version 3.19.2 on channel stable at /Users/dan/Library/CloudStorage/Dropbox/Development/Projects/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (8 weeks ago), 2024-02-27 16:51:22 -0500
    • Engine revision 04817c99c9
    • Dart version 3.3.0
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/dan/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/dan/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15C500b
    • CocoaPods version 1.15.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.88.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.86.0

[✓] Connected device (3 available)
    • iPhone 15 Pro (mobile) • 5708553D-16CB-425E-852B-D3F752379C47 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-17-2 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 13.6.4 22G513 darwin-arm64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 124.0.6367.61

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Steps to reproduce the issue

create a new stacked view with the following annotations:

@FormView(
  fields: [
    FormDropdownField(
      name: 'goal1Priority',
      items: AppGoal.all,
    ),
    FormDropdownField(
      name: 'goal2Priority',
      items: AppGoal.all,
    ),
    FormDropdownField(
      name: 'goal3Priority',
      items: AppGoal.all,
    ),
  ],
  autoTextFieldValidation: false,
)

With AppGoal defined as:

class AppGoal {
  static const List<StaticDropdownItem> all = [
    StaticDropdownItem(title: '1st', value: '1'),
    StaticDropdownItem(title: '2nd', value: '2'),
    StaticDropdownItem(title: '3rd', value: '3'),
  ];
}

run stacked generate
note the generated form.dart contains the missing methods and are marked in the IDE with multiple errors.

Expected behavior
No errors in generated file and methods present
Screenshots

Additional Context
No response

Hey @FilledStacks, same issue and fix with only FormDateField 😇
Any particular reason why you removed those features to keep only FormTextField? Any incompatibilities or related issues?

@n0mad-d3v It wasn't used as much so I just didn't spend time updating it when form text field got it's updates over the years.
Then it just fell out of support and since it's very rare that anyone asks for it I know it's not used very much.
If you're willing to work on the generator you can make a fix for it and I'll merge it in :D

@n0mad-d3v It wasn't used as much so I just didn't spend time updating it when form text field got it's updates over the years.
Then it just fell out of support and since it's very rare that anyone asks for it I know it's not used very much.
If you're willing to work on the generator you can make a fix for it and I'll merge it in :D