reflect official 2.0 API

.. any plans to do this one? https://github.com/lifx/lifx-protocol-docs

Hey, thanks for reaching out.
Do you mean:
(1) do I plan to support the existing feature set for 2.0 bulbs?
or (2) do I plan to extend the feature set to cover more of the features described in that document?
If it's (1), there is already support on a branch called 2.0 -- see near the top of README.md where it says "Support for 2.0 is on a branch". Your mileage may vary, but I've been using what support is there for a while now at home without any issues, and I do plan on eventually merging this into master.
If it's (2), I'm open to doing that. Are there specific things you're looking for?

Hi Matt,
Thanks for the quick reply! My main question was regarding re-aligning with
the official 2.0 API documentation - I was assuming that being of an early
release than the official API, your 2.0 is still reverse-engineered. Is
that not correct?
I am personally after very basic stuff - simple, local REST API to change
colour of my bulbs (the API should also verify that the colour change
happened etc.)
On Wed, Aug 12, 2015 at 3:44 PM, Matt Papi<EMAIL_ADDRESS>wrote:

Hey, thanks for reaching out.
Do you mean:
(1) do I plan to support the existing feature set for 2.0 bulbs?
or (2) do I plan to extend the feature set to cover more of the features
described in that document?
If it's (1), there is already support on a branch called 2.0 -- see near
the top of README.md where it says "Support for 2.0 is on a branch". Your
mileage may vary, but I've been using what support is there for a while now
at home without any issues, and I do plan on eventually merging this into
master.
If it's (2), I'm open to doing that. Are there specific things you're
looking for?
—
Reply to this email directly or view it on GitHub
https://github.com/mpapi/lazylights/issues/4#issuecomment-130310694.

Ah, got it, thanks for clarifying.
I can definitely take a closer look at that doc and see what turns up. I'd encourage you to mess around with what's currently there on the 2.0 branch -- my hope is that it's usable to you in its current form, and that if the protocol doc does reveal anything, it won't require much (if any) change to the existing library interface.

Ok, great! Will take a look!
On Wed, Aug 12, 2015 at 4:11 PM, Matt Papi<EMAIL_ADDRESS>wrote:

Ah, got it, thanks for clarifying.
I can definitely take a closer look at that doc and see what turns up. I'd
encourage you to mess around with what's currently there on the 2.0 branch
-- my hope is that it's usable to you in its current form, and that if the
protocol doc does reveal anything, it won't require much (if any) change to
the existing library interface.
—
Reply to this email directly or view it on GitHub
https://github.com/mpapi/lazylights/issues/4#issuecomment-130317401.


Create tests

The tests are being created on branch https://github.com/cezarlz/boss-validator/tree/features/tests
I'm using mocha with chai expect (BDD style).
The tests are located on test folder.
To run tests install the dependencies with npm install and then npm test.
Thanks!

@cezarlz picked up it


Change search to default to boolean AND

Changes default search to boolean AND searches.
Additionally strips the + from the search for display in the search results.
Fixes #71

OK cool, so I did two things:

Trimmed down variable setting so you didn't have to re-convert the original query back after you'd processed it. The variable names should be a little easier to understand now too.
I noticed that searches for things like "works of art" were not pulling up items that had that phrase in them.  I've slightly tweaked the pre-processing of search terms so that we don't require stop words.

Ok, cool. Yeah, the variable stuff is something I'm still struggling with a a bit in JS.
I would not have known to check for those stop words...


Error handler: only return status code and short name

Long description is not that useful.
This PR modifies the error handler to only return status code and short name.
We might be better off not returning code and name at all, as the status code of the response speaks for itself, but oh well...

Coverage remained the same at 100.0% when pulling a6de06ea325930c5d33f006dbafa4c5061076ad3 on rework_error_handler_status into 57042c1741e7e11fbff1a9cae9de426162be5b78 on master.


Recognize binary name 'vimx'

Some distributions ship 'vim' without xterm_clipboard support. A separate
package vim-x11 or similar then ships another binary 'vimx' with that
support.
To support vim-tmux-navigator with such a binary name, adapt the pattern
check to allow an optional 'x'.

My kingdom for a more sane way to detect Vim. In the meantime, thanks for the update @patrickdepinguin!


commandergenius: 2.3.3 -> 3.5.0

The currently packaged version of Commander-Genius stopped building with GCC 13, because GCC stopped transitively pulling in a couple of standard headers in various scenarios. Among these is cstdint, which declares a couple of standard integer types like uint32_t.
At the same time, the currently packaged version is rather old already, and these build issues have been resolved upstream in newer versions.
This change updates Commander-Genius to the most recent upstream release, fixing said build issues in the process as a side effect.
Failing Hydra build: https://hydra.nixos.org/build/246237074
Hydra log: https://hydra.nixos.org/build/246237074/nixlog/1
Relevant log excerpt:
[ 27%] Building CXX object src/engine/refkeen/kdreams/CMakeFiles/refkeen_kdreams.dir/id_ca.cpp.o
In file included from /build/source/GsKit/base/utils/FindFile.h:28,
                 from /build/source/src/engine/refkeen/kdreams/id_ca.cpp:21:
/build/source/GsKit/base/utils/Unicode.h:16:9: error: 'uint32_t' does not name a type
   16 | typedef uint32_t UnicodeChar;
      |         ^~~~~~~~
/build/source/GsKit/base/utils/Unicode.h:1:1: note: 'uint32_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
  +++ |+#include <cstdint>
    1 | /*

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@hce FYI: I haven't yet had the opportunity to test whether this version actually runs properly. I started the patch while traveling and currently have only remote access to a headless NixOS system. I should be able to do so in a couple of days.

Also, I'm wondering: Does this update warrant a Release Notes entry? From what I can gather from the upstream repo page, version 3.0.0 was assigned rather arbitrarily, and I can't find any documented breaking changes. Should I still include a new entry simply because the the major version changed, or is that unnecessary?

@hce FYI: I haven't yet had the opportunity to test whether this version actually runs properly. I started the patch while traveling and currently have only remote access to a headless NixOS system. I should be able to do so in a couple of days.

Update: Tested with Commander Keen 1, builds and runs fine for me.

Result of nixpkgs-review pr 284039 run on x86_64-linux 1

1 package built:

commandergenius


how to make roulette to stop in the center of the prizeItem?

Hello, @tortuc. I implemented this feature in the package verison 2.1.2. Don't forget to update it. You should add this prop:
<RoulettePro
  ...
  options={{ stopInCenter: true }}
  ...
/>

Thank you @IvanAdmaers
It's been solved.


Create CSV with multiple headers

Trying to create an CSV file with multiple headers. Is there a way for this feature using this package.
Any help will be greatly appreciated.
Thanks.

I had to do this - only way I found was to manually write the header rows and separate multiple "tables" with empty rows.

I had to do this - only way I found was to manually write the header rows and separate multiple "tables" with empty rows.

Hey Max , can you point to an example to how you did it ?? i am trying to put two table data with different headers .. could you please help me with an example . any help is much appreciated


[WIP] anatoly/dcos 13698 navstar systemd scripts

High Level Description
Cleanup the navstar systemd init scripts
Related Issues

DCOS-13698 cleanup the systemd startup scripts.

Checklist for all PR's

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[ ] Read the DC/OS contributing guidelines
[ ] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and Review Process
What is the review process and when will my changes land?
All PRs require 2 approvals using github's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@GoelDeepak is there someone that can take over this PR?

Also FYI @asridharan

@GoelDeepak can you take over this PR?

I am pretty sure that this is superseded by recent efforts. Please reopen if this is still of use.


change is_logged_in to requires_auth decorator

for the sake of clean code is_logged_in has been refactored to be a docorator
sample usage is found in the auth/@me  routes

@Dev-wonderful
@Freeman-kuch
take note


[Question]: Using "Last camera picture URL" in HA

I see the sensor exists as part of my 8201 doorbell. The data in the sensor is " T8201XXXX~/mnt/userdata/video/h264_video_20230116_181919n.jpg"
How would I use that data to show the image in a picture entity card on HA?

This is not the correct place for this question, use custom integration repository. Before opening an issue, you have to check open ones there


[C++] unsigned conversion from ‘int’ to ‘uint64_t’

With -Wsign-conversion -Werror options I'm getting compilation error on m_index assign:
        inline void wrapForDecode(
            char *buffer,
            std::uint64_t *pos,
            const std::uint64_t actingVersion,
            const std::uint64_t bufferLength)
        {
[...]
            m_index = -1;
[...]
        }

It would be better to define m_index as std::int64_t. (but then hasNext() needs to be adjusted as well)

Just replaced -1 with the limit max that will preserve the behavior.


a button to move the window to the next virtual desktop (like Spaces in macos) and keyboard shortcuts

Description of the new feature / enhancement
an additional button next to the function of minimizing the window for this task
Scenario when this would be used?
it is very convenient for any job. especially with a virtual machine
Supporting information
No response

So you just want a function to move the window to a different virtual desktop, or you also want to move to that desktop simultaneously? Is this different from issue #16?


Fix race condition in peers listener

Motivation
Closes #2654
Changes

Fixes race condition
Properly prints stack in TestShutdown

Test Plan
N/A, fixes tests
TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed

DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

fixed it in https://github.com/spacemeshos/go-spacemesh/pull/2645


mariani to alumni

👷 Deploy Preview for gladia processing.

Name
Link

🔨 Latest commit
918cd1d383c8c4e8852317addc417ac37127b358

🔍 Latest deploy log
https://app.netlify.com/sites/gladia/deploys/6704d1de844f910008734f72


rm prep/sample constraints

This is what we discussed as a group to improve the delete speed.

gonna reopen against analysis-refactor


Remove deprecated options for 1.2.0

This removes the CMake options and code for:

HPX_WITH_LOCAL_DATAFLOW_COMPATIBILITY
HPX_WITH_GENERIC_EXECUTION_POLICY

because they have been deprecated since 0.9.99, and

HPX_WITH_ASYNC_FUNCTION_COMPATIBILITY

because it was deprecated since 1.0.0.
~In principle HPX_WITH_ASYNC_FUNCTION_COMPATIBILITY should also be removed according to the release procedures, but with more frequent releases and semver considerations I'm tempted to leave it. Any opinions?~

In principle HPX_WITH_ASYNC_FUNCTION_COMPATIBILITY should also be removed according to the release procedures, but with more frequent releases and semver considerations I'm tempted to leave it. Any opinions?

I'd say let's get rid of it.

In principle HPX_WITH_ASYNC_FUNCTION_COMPATIBILITY should also be removed according to the release procedures, but with more frequent releases and semver considerations I'm tempted to leave it. Any opinions?

I'd say let's get rid of it.

All right, I'll remove it. I'll add it still to this PR, so please don't merge until then.

For some reason I missed a whole bunch of other options that also need to be removed. I'll remove them asap.


cl_proxy_db=>load_by_abap_name is unknown or PROTECTED or PRIVATE

Actual version 1.84.0 can't be activated due to missing method in line 48060

which SAP_BASIS version are you on?
related: https://github.com/larshp/abapGit/issues/2365

731	0023

does methods cl_proxy_query=>get_hdr_by_abap_name and cl_proxy_db=>load exist in your system?

Both yes

@mfallen try this, https://github.com/larshp/abapGit/pull/2466

@larshp  - updated coding with your new version. Can confirm all is working as expected, no errors anymore! Thanks

thanks, merging changes, closing issue


update gitignore and remove ide files

I added some netbeans files to the gitignore and removed any vscode specific files from the project. I am pretty sure those are just cache files and such.

Starting to go through old PRs -- sorry for the delay. These particular files are actually Visual Studio (not vscode) project and solution files, and are necessary to compile the app on Windows! We definitely do not want to get rid of them. :)

Ah I don't use Visual Studio, but my point was mainly that these files are generated automaticaly when the project is built, so removing them from the repo won't actually break anything but will result in a smaller size and a less cluttered repo. These files can change with internal changes to VS and then git will pick them up and include the changes even though it isn't required for the project to function. I might have missed a few configuration files, but it's the difference between a settings.gradle file and a gradlew.bat file for Android Studio.


[PRED-2176] Add optional prediction threshold field to out csv

BATCH SCORING PULL REQUEST
This is a pull request into a public repository for Batch Scoring script maintained by DataRobot.
RATIONALE
After #154 we have new prediction decision field in the output CSV, but it's not obvious how it is calculated from probabilities of each class. Threshold, which is 0.5 by default, may be changed in deployment, so the new field to expose the threshold to output CSV was added.
CHANGES

New command line argument --pred_threshold=<column name> which is disabled by default
If the argument pred_threshold is given, a new column in output CSV appears with the threshold value. May be applied only for binary classification, otherwise an error will be showed.

TESTING

Functional tests were written
I ran script with and without new argument against real DR cluster for binary classification.

Coverage increased (+0.01%) to 84.026% when pulling 207ca44ed704fc71882d0895cc09c40f72ffe244 on rrader/PRED-2176-pred-threshold into c7f9897ee4915873c2ec61f0c81dd5b506c8ca1d on master.


The documentation on xoauth was wrong

I spent a couple hours tracing the error from imap on up, and finally figured out the documentation was wrong in the Readme. :(
Wil

This issue was moved to gmailgem/gmail#18


Add some missing CSS keywords

align-content, align-items, align-self
background-blend-mode
fill, font-kerning
ime-mode
justify-content
mask, mask-type
pointer-events
tab-size, text-rendering, text-underline-position
will-change

Are all of those a standard now or at least release candidate?

Yes, I'm using a number of them (the flexbox related stuff) in production work right now. The others all have support in multiple browsers.


Apply topic(s) to improve findability?

Hi Lars!
Several similar projects as yours have set the topic git-sync. Have you considered also applying that topic? There is also the repository-synchronization, albeit rarer.
Cheers!

Hi Katrin! Thanks for the hint! I've added those topics 👍 😊 !

Cool! Thank you :-)


Migration to 3.0.0

Since we are now working on 3.0.0, I would like to address the issues of migration.
We are planning to make breaking changes (I am thinking about handles specially).
Will we create all the migration code ?
I think we should and I would like to have everybody's opinion on that matter.

Are we talking migration of core or data?

Code + Data.
I mean, we need to first figure out if we want an upgrade path from 2.x to 3.x... And what should be included or not :smile:

Migration code (should we choose to help migrate things) will live in the migration file.
I think it will need to be approached on a case by case basis.

I think it will need to be approached on a case by case basis.

Yeah that's for sure. But can we all agree that we should try to make migration from 2.x to 3.x easy as possible ?

+1

Should be added to the 3.0.0 milestone.

I think we have to restructure the installers index.php and/or the bundle.php, making the updater more independent and run it as early as possible.
There's a new order column in the extensions_delegates table in 3.0.0. Problem is, the ExtensionManager class, with an SQL statement in its constructor that uses this new column, is called before the updater runs, resulting in a Symphony Fatal Database Error.
Not sure how to solve this, or if there are any other possible breaking points.

Finally, the migration will be possible only from 2.7.x LTS.
Lower version will need to first update to the LTS version, and then update to 3.0.0


Is there a way to customize the input decorations / style on the input fields?

This is a customization request, not an issue.

As of version 3.0.0 this issue was fixed


BUG: The cards in Cost efficient reading section are not of appropriate sizes

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
The cards in Cost Efficient reading section are not of appropriate sizes. The content is not wholly displayed, also there is no scroller.
Here's how it looks,

I can make the boxes of appropriate sizes and would look like:

Hello PA @anuragverma108 ,
Please assign me this issue under GSSOC24.
Thank You!
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Assigned!

Thank you for assigning me this issue, The same is the problem with environmental impact page, may I do the same for this too?


can support right click to select text?

i want to know it can support right click to select text or not?
like  press  ctrl+c then ctrl+v to to other places.
thanks

Dose it support  select text?


Feedforward

Problem:
Cirq currently only supports a single unrolled circuit.  Measurements results cannot be fed forward to influence the future execution of the circuit.  This leads to, for example, Cirq not being able to easily describe a teleportation experiment.  There are also use cases for simple feed forward in variational ansatz and simple quantum error correcting protocols.
Depends on feature: Classical data (#3231)
Rough requirements:

Define how classical data can influence future execution
how is control specified
what is changed by the result of the control
support of multiple cases
Fit in with the specification of data in the Classical Data feature.
Support serialization of the specification of control and of the action resulting from the control.

A previous feature request https://github.com/quantumlib/Cirq/issues/762 was closed as intended because we didn't know how the hardware was going to support this. Do we have more idea now? Any specific requirements due to hardware constraints?

@95-martin-orion @smitsanghavi @MichaelBroughton Initial RFC here: https://tinyurl.com/cirq-feedforward. I'm reasonably happy with it as a first draft.


Allow specific placement of debugger UI

If an element with id equal to microcosm-debugger exists, append the debugger to that element instead of document.body.

👍


Deprecate WildcardVersion::Major?

Hey,
I'm currently trying to do a comparison for when a VersionReq is a full wildcard: *.
For all intents and purposes, the following states of VersionReq appears to be equivalent:

predicates is empty, causing the all check to return true.
there is one predicate, whose op is Op::Wildcard(WildcardVersion::Major).

Both of these cases appears to match any version. Both of them are fmt::Display:ed in a way so that they show *.
I would like to discuss if we could either have VersionReq::any() return the same as when * is parsed (single WildcardVersion::Major predicate) to make comparisons viable. Or to completely deprecate the use of WilcardVersion::Major since its functionality is equivalent to an empty set of predicates.

This is a good question! I'm not sure.

For my specific problem, introducing a function like is_wildcard would also work:
https://github.com/udoprog/semver/commit/c27a8c9ebf1b3393f500cab05a5d5bd9c36b437b

I've accepted the underlying PR in semver-parser, so we can do this here too.

I've rebased #151. When version 0.8.0 of semver-parser is available it is good to go.
I've also closed #159 since you'll be taking this approach.
Thanks!

This is fixed in 1.0.0. The * requirement is now uniformly represented with an empty comparator set, and there is no WildcardVersion::Major.


Node.js  uvwasi team Meeting 2024-07-03

Time
UTC Wed 03-Jul-2024 18:00 (06:00 PM):

Timezone
Date/Time

US / Pacific
Wed 03-Jul-2024 11:00 (11:00 AM)

US / Mountain
Wed 03-Jul-2024 12:00 (12:00 PM)

US / Central
Wed 03-Jul-2024 13:00 (01:00 PM)

US / Eastern
Wed 03-Jul-2024 14:00 (02:00 PM)

EU / Western
Wed 03-Jul-2024 19:00 (07:00 PM)

EU / Central
Wed 03-Jul-2024 20:00 (08:00 PM)

EU / Eastern
Wed 03-Jul-2024 21:00 (09:00 PM)

Moscow
Wed 03-Jul-2024 21:00 (09:00 PM)

Chennai
Wed 03-Jul-2024 23:30 (11:30 PM)

Hangzhou
Thu 04-Jul-2024 02:00 (02:00 AM)

Tokyo
Thu 04-Jul-2024 03:00 (03:00 AM)

Sydney
Thu 04-Jul-2024 04:00 (04:00 AM)

Or in your local time:

https://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+uvwasi team+Meeting+2024-07-03&iso=20240703T1800
or https://www.wolframalpha.com/input/?i=06PM+UTC%2C+Jul+03%2C+2024+in+local+time

Links

Minutes Google Doc: https://docs.google.com/document/d/1HQxQ37XAEYVpDwL93rFHZ5d239U8enGQiOsO2R6FI3w/edit

Agenda
Extracted from uvwasi-agenda labelled issues and pull requests from the nodejs org prior to the meeting.
nodejs/node

WASI preview 1: fd_readdir ignores cookie argument #47193

nodejs/uvwasi

What's new with uvwasi in 2023 #201
Changes to WASI spec in snapshot_preview2 #59

Invited

uvwasi team: @nodejs/wasi

Observers/Guests
Notes
The agenda comes from issues labelled with uvwasi-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.
Joining the meeting

link for participants: https://zoom.us/j/91612484369
For those who just want to watch:
youtube admin page: https://www.youtube.com/my_live_events?filter=scheduled

As mentioned in the meeting today, if anyone is interested in participating in Jco discussions, we have a Zulip stream at https://bytecodealliance.zulipchat.com/#narrow/stream/409526-jco, and meetings every second Monday.


Failed to create the WebView control

Environment
Microsoft Windows [Versión 10.0.17763.1039]
PowerToys 0.18.1
Windows build number: [run "ver" at a command prompt]
PowerToys version:
PowerToy module for which you are reporting the bug (if applicable):

Steps to reproduce
Run PowerToys
Expected behavior
Open PowerToys
Actual behavior
Error:  Failed to create the WebView control
Screenshots

Still waiting

We migrated to a new Settings which requires Windows 10 version 1903 or above (build 18362)

Ok thanks. There's any build suitable for my system?

The Powertoys releases before 0.18 are suitable for your system. Unfortunately you won't be able to access PT Run or Keyboard Manager however.
closing this issue, reopen if the old releases cause an issue as well.


Fix bug where filenames with no extension cause an infinite loop

Thanks @rickyrobinett! Can you add a test for this, please?

@gasman will do

Merged in 9c0968ad1267045f6c8c6841086e64a55bc695ab - thanks!


Update config.json

Made it so instead of every 5 seconds its every 60 seconds, and that instead of just 1 in a stack it's 5.

I really like this mod, I'm just trying to make it less irritating.

mcwhoknew:patch-1

mcwhoknew:patch-1


[stable/mongodb-replicaset] Prometheus Metrics export

Original PR #5874
What this PR does / why we need it:
Adds Prometheus metrics to the mongodb-replicaset chart using the a readonly clusterMonitor mongodb account for metrics authentication.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Fixes from the previous PR

Uses clusterMonitor role for authenticating the metrics exporter into the replicaset
Fixes best practices for specifying images
Removed makefile (was originally intending for the Dockerfile to be hosted here but not necessary)

Need clarification on the Prometheus annotations.

Since I am using the annotations to also define the exporter port and path, should I leave those defined in the metrics container definition? Or would it be preferred to create separate values not tied to the annotations?

/assign @unguiculus

/assign

@ssalaues , you can find prometheus operator settings in the kafka chart example: https://github.com/kubernetes/charts/blob/master/incubator/kafka/values.yaml#L266-L278
There they automatically deploy the kafka exporter and ServiceMonitor CRD. I suggest this PR do something similar.

Thanks @agolomoodysaada ! I'll try that out

I just added a commit to move away from the always on annotations that was specified before and separate the metrics configuration (had it combined with the annotations before). This will make it easier to setup ServiceMonitor for Prometheus Operator and have it separate from traditional Prometheus Service Discovery.

@gianrubio Would you mind having a look as well?

Made the requested changes @unguiculus. Thanks!

/ok-to-test

/lgtm

Thank you for your help in getting this merged @unguiculus


Enabling "Enhanced Highlighting" causes atom to hang

Initial Repro:

Open a .cs file
Enable Enhanced Highlighting
Atom hangs

Further Repro:

Kill atom from task manager
Reopen atom
Open a .cs file
Atom hangs

Remedial action:

Kill atom from task manager
Reopen atom
Disable Enhanced Highlighting
Open a .cs file
Atom does not hang

Is the repo available to test against?  ( Highlighting has some fun edge cases :cry: )

Yep, it's here https://github.com/ParticularLabs/Uranium
I was opening src/Uranium.Console/Program.cs.

Happens to me as well, though only on certain files. Some could simply be a single class with no functions and still crash. Tried adamralph's repo and not a single file crashed for me, yet an empty one on my end did.

I've made a monkey patch (well enhanced highlighting is just a bug monkey patch anyway) but the editor should no longer lock up when enhanced highlighting is turned on.  It is possible that some enhanced bits, or normal highlighting bits might work incorrectly.  If they do let me know, but for now it shouldn't break the editor any longer.
I haven't noticed anything specifically, but that doesn't mean it can't happen.

@david-driscoll :+1: it does indeed seem to be fixed


Provide additional data for attachment_upload_to function / Attachment relationships

I've been experimenting with django-summernote for a bit now (thank you VERY much for the great package!).
I would like to construct my upload path based on additional data which does not appear to be available when it is called.  I have access to an instance of the Attachment model, but appear to have no way to get back to the original Model which actually contains the summernote field.
Ideally, I would like to construct an upload path containing metadata about the model being used instead of any date/time scheme.  Something like:
.../[app-name]/[containing-model-name]/[containing-model-pk]/[containing-model-field-name]/
For example:
.../some_app/SomeModel/123/some_field/
Then each app would have their own sub-directory, then each model therein, then each specific instance, and finally each field (if more than one field uses summernote).  In my opinion, that would be a more effective way to organize the attachment files, especially for large projects which might use summernote fields in multiple locations.
However, I do not appear to be able to get back to any of that data from the Attachment instance.

One approach to solving this is could be related to the discussion in issue #47 (How would you resize uploaded items?) which highlights some of the issues given there is currently no explicit relationship established between Attachments and the models which contains the fields to which they refer.  It's mentioned context type (generic relations) could be used to establish a ManyToMany relationship, but that does not appear to have been implemented yet.  If such relationships were in place, they could be traversed to gather the data in this case.
Referring to the chicken-and-egg scenario described in that issue (where the original model might not be saved at the time attachments are uploaded), a trivial solution might be to simply disallow attaching images until the model has been initially saved.  (Arguably not ideal, but I don't think it would be a horrible inconvenience and it would provide a practical gatekeeper to avoid the issue).
As a further aside, I'd mention that the absence of this relationship also makes it hard to clean up old Attachments (either Attachments not in use by the associated model fields or Attachments for model field instances which have been deleted).

Another approach might be to provide a unique attachment_upload_to function for each summernote field or widget when they are created.  This would obviously have to "filter down" somehow to the upload_attachment view and then change the Attachment FileField.upload_to attribute.  This might be a similar dead-end, since at the time the upload_attachment view is called, I don't believe it has any references back to the originating field the Attachment is being created for.

In the mean-time, for my projects I've simply set disable_upload = True in my SUMMERNOTE_CONFIG and am happy to use the base64 images, since that avoids all these issues with the obvious trade-offs.  I'm quite happy with that approach for now, though.  The editor is great, storage is cheap and networks are fast.  ;)

It's been a long time.
Anyway, Thank you for using summernote and django-summernote.


Add a InterruptedCollector to received thread interrupt request and exit search task early

Description
hi，
I try to submit a Lucene search task using multiple threads, and when I cancel the search thread, the search task complete normally. But Some search tasks are time-consuming, I wonder if I could exit the search thread early to improve thread utilization.
Expectation:
The expectation is to exit the search thread early when it has been  Interrupted
I have tried {@link TimeLimitingCollector} (https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/TimeLimitingCollector.java) , but the ticksAllowed can not be set too small, so there are some waste of thread utilization still. I wonder if I could add a InterruptedCollector to received interrupt and exit early

no. use of Thread.interrupt is not safe because if a thread is blocked on io it will close its file handle in java.

This won't work when the thread is blocked on I/O (e.g. when it reads from IndexInput). Java has the behaviour to close file handles for safety when a thread doing IO was interrupted. When you use this collector the file handle might get closed.
This won't negatively affect MMapDirectory (unless you interrupt at the time of opening the file), but all other implementations will fail.

hi, @uschindler  @rmuir
Thank you for reply
Yes, we use the MMapDirectory implementation mainly, and Interrupted collect seems to work fine so far.
I‘m sorry for not considering other implementations


git-scm.com is now served via cloudflare

Since yesterday morning, all git-scm.com traffic has been served through Cloudflare. I set this up to try to relieve some of the load on the Heroku setup, and also because it increases our flexibility for hosting the backend (e.g., if we do switch to a GH Pages site, then we'd probably need some kind of CDN in front of it anyway, at the very least for custom-domain SSL). The folks at Cloudflare were kind enough to give us a complimentary Business domain, so we shouldn't run into any limitations on scale or features.
Here's what it looks like from Cloudflare's side:

Unsurprisingly (since it's a static site), the vast majority of requests are served out of cache.
On the Heroku side, you can see the drop in requests as the caches filled (the cut-over was at Thursday ~1am):

The response time on Heroku jumped, but I think it's an artifact of the measurement. The 95th percentile went up because all of the easy requests are now served from Cloudflare, so the long requests are a much larger fraction. Here's the graph:

I was hoping that the dyno load on Heroku would lower, but I don't see a meaningful drop:

So my hypothesis is that the "easy" requests were already being served pretty quickly due to mem-caching on the Heroku side. If we're going to stick with a Rails app, there's probably some optimization that can be done. I played around with the Scout add-on, and it identified some N+1 queries that resulted in slow renderings (e.g., separate queries to load the section slugs for each book chapter). I don't have a lot of ActiveRecord experience, but my impression is that some well-placed includes() should make these go away.
As for the Cloudflare setup, it's fairly vanilla. I'm using one of their universal certs for the SSL now. That means that clients need to support SNI to connect that way. But it was the same on Heroku. We do have a cert for git-scm.com that's good through the end of the year. But if nobody is complaining about SNI, it seems easier to just stick with what's there.
If there are other Cloudflare settings that people think ought to be tweaked, let me know.

So what's left that is served without caching by CloudFlare? The HTML content? It seems that caching should also be active for most of the doc content (46c62fa).

Do ES queries hit the CF caches?

Everything goes through the CF caches, and it decides what to cache. I think its rules are by file-extension, and it doesn't cache the HTML by default. That would explain the hit-rates I'm seeing on Heroku, which are roughly proportional to the unique-visitors count (so somebody hits an HTML page, and that goes to Heroku but the rest of the assets are served statically).
I just tweaked the settings a bit to try to cache everything. I'll see what that does.
The ES queries should go be going through CF, too, though I suspect they were mostly not-cached until the tweak I just did. They should be OK cached because CF respects the query strings. I don't think search requests make up a large portion of the requests, though.

At least, now, the header for the html content are:
Cache-Control: public, max-age:14400

So the caching at the end point (the browser) is activated. But, I guess that CF can use such header because the internal policy is identical. So, this boils down to comparing the number of requests concerning HTML that reach Heroku to the one at CF. If they are still the same, then the caching is not active in CF, but only in the browsers.

The cache-control you're seeing comes from CF. The one from heroku is only 600 seconds, but I've instructed CF to use a blanket 1-hour ttl.
If you want to hit the heroku servers directly, you can do something like (or just stick an entry in your /etc/hosts for one of the heroku IPs that the herokudns name resolves to).
curl -v --connect-to git-scm.com:443:git-scm.com.herokudns.com:443 https://git-scm.com

The other thing you can check is the "CF" headers when the request goes through Cloudflare. So for example:
$ curl -v https://git-scm.com 2>&1 >/dev/null | grep CF-
< CF-Cache-Status: HIT
< CF-RAY: 33df0e1459a0576b-IAD

show that it was served out of cache.

It's been about 26 hours since I flipped the "cache everything" switch on Cloudflare. Here's what it looks like from Heroku's side:

The switch close the v501 deploy (the deploy didn't do it; that just happened to be when I was working on the site yesterday morning). The requests drop off naturally on the weekend, as you can see, but they shrink quite a bit more after the deploy.
Here's the dyno load during the corresponding period:

So those look pretty promising. I've scaled back to a single dyno for now (from three), and I'll keep an eye on it over the course of today (Sunday) to make sure it is keeping up with load. And then the real test will be how it behaves on a weekday.

This has been scaled back to one dyno for the past week. It seems fine, I think. That dyno stays reasonably busy, and the 95th percentile response times at Heroku sometimes hit a few hundred milliseconds. But those are a tiny fraction of all requests, as cloudflare is handling 95% of the requests straight from cache already, so it's effectively 99.75th percentile.
So I think I'll leave it like this indefinitely. I'm going to close this issue. There was never really any task to accomplish; I mostly just wanted to let people know of the ongoing experiments. I'll make a post to the mailing list, too, but there are a few other loose ends I want to tie up first.


ITMS-91108: Invalid privacy manifest in 1.20.3

Describe the bug
A clear and concise description of what the bug is.
SDK Version

Client: [e.g.  Swift]
Version 1.20.3

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Device (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

ITMS-91108: Invalid privacy manifest - The PrivacyInfo.xcprivacy file from the following path is invalid: “WalletConnect_WalletConnectModal.bundle/PrivacyInfo.xcprivacy”. In addition to the privacy manifest files in the locations outlined in the documentation, starting November 12, 2024, all privacy manifests you submit must have valid content. Keys and values in any privacy manifest must be in a valid format. For more details about privacy manifest files, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files and https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/adding_a_privacy_manifest_to_your_app_or_third-party_sdk.

Please correct the following issues and upload a new binary to App Store Connect.
ITMS-91056: Invalid privacy manifest - The PrivacyInfo.xcprivacy file from the following path is invalid: “WalletConnect_WalletConnectRelay.bundle/PrivacyInfo.xcprivacy”. Keys and values in your app’s privacy manifests must be valid. For more details about privacy manifest files, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files.
ITMS-91056: Invalid privacy manifest - The PrivacyInfo.xcprivacy file from the following path is invalid: “WalletConnect_Web3Wallet.bundle/PrivacyInfo.xcprivacy”. Keys and values in your app’s privacy manifests must be valid. For more details about privacy manifest files, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files.
ITMS-91056: Invalid privacy manifest - The PrivacyInfo.xcprivacy file from the following path is invalid: “WalletConnect_WalletConnectVerify.bundle/PrivacyInfo.xcprivacy”. Keys and values in your app’s privacy manifests must be valid. For more details about privacy manifest files, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files.
ITMS-91056: Invalid privacy manifest - The PrivacyInfo.xcprivacy file from the following path is invalid: “WalletConnect_WalletConnectPush.bundle/PrivacyInfo.xcprivacy”. Keys and values in your app’s privacy manifests must be valid. For more details about privacy manifest files, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files.
ITMS-91056: Invalid privacy manifest - The PrivacyInfo.xcprivacy file from the following path is invalid: “WalletConnect_WalletConnectPairing.bundle/PrivacyInfo.xcprivacy”. Keys and values in your app’s privacy manifests must be valid. For more details about privacy manifest files, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files.
ITMS-91056: Invalid privacy manifest - The PrivacyInfo.xcprivacy file from the following path is invalid: “WalletConnect_WalletConnectSign.bundle/PrivacyInfo.xcprivacy”. Keys and values in your app’s privacy manifests must be valid. For more details about privacy manifest files, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files.

hey @ngn999 are you using WalletConnectModal?

hey @ngn999 are you using WalletConnectModal?

Yes.

Ok, we are no longer supporting it, so I would recommend you to fork this repo and add PrivacyInfo manifest file in the same way it's added for every other package.
here you have a reference: https://github.com/WalletConnect/WalletConnectSwiftV2/pull/1414/files


integration-docs: Update for new format (Radarr, Raygun, Review Board, RhodeCode, Rundeck, Pivotal, Opsgenie)

Apply integration-docs' new format.
Fixes part of #29592.
Updates the following integration documentation pages:

Radarr
Doc link

Raygun
Doc link

Review Board
Doc link

RhodeCode
Doc link

Rundeck
Doc link

Pivotal
Doc link

Opsgenie
Doc link

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

I strongly based the Radarr integration on the recently updated Sonarr integration.
Most of the other docs are just format changes.
There were just a couple of instances where some content was moved into a warning or a tip, or a section link was added.

How does filtering work when it's just one event type, for RhodeCode? Are there other events that can't be filtered? Or do you get no events at all if you uncheck it?

I wonder how old the Pivotal v3 API is, and if the note and event filters are still useful.

Neither question is a blocker for getting this integrated. :)

For Pivotal, I think the question is whether Pivotal still lets you emit v3; if so we need to keep the support. I also have no idea if they have a newer version we might want to support.


This PR allows to upgrade flutter map to the last version

Basically it uses the latlong2 lib to substitute the latlong one.
Example works with flutter_map 0.13.1

LGTM. Thanks alot! We're now flutter_map 0.13.1 compatible. 👏

Thanks for the quick merge :-)

I'm going to release a new version soon. Will keep you updated with that!

Published 1.2.0 :-)


Rename Interaction::Clicked -> Interaction::Pressed (#8989)

Objective

Fixes #8989

Solution

Renamed Interaction::Clicked -> Interaction::Pressed
Minor changes to comments to keep clarity of terms

Migration Guide

Rename all instances of Interaction::Clicked -> Interaction::Pressed

Can you add a "Migration Guide" section to the PR description to address the breaking change?

Amended the Issue description, that single dot point should be enough I think but let me know if it needs expansion


Prevent BasicAuth when username/api_token are unset

Fix issue where "Authorization" header is set, even if "username" and
"api_token" are not set by the user.
Observed case where if username and api_token are not set,
HTTPBasicAuth is still invoked, setting header - Authorization: Basic Og== ("Og==" is base64 encoding of ":")
So only invoke HTTPBasicAuth when username AND api_token are set.

Tested in my Jenkins instance. All looks good. SFX smart agent started to send statistics about build executors, memory and jobs without username/password. Previously we had to use store username/password in the agent.yaml for the agent to work.

Thanks for the fix!


User Guide 03 - now with regridding

I added a fair amount of content in here. I ended up deciding that a lot of the stuff that I was talking with Philipp about yesterday and Jim today was actually not super important for this story. It'll be more of a big deal in 05 I think because there we will want to talk about images vs quadmeshes and that is where there could be some really big geoviews wins.

This approach is more logically sound, but sometimes global attribute data can be lost.

Can you explain what you mean in a way that people can act on that?  Here it's not clear how they will know when data is lost, which data gets lost, and so on.


Firebase Database suddenly stop working and send TimeoutException

Hi, all is in the title...
After some time (randomaly) the SDK doesn't want to send any update on my database. It send for each kind of request: setValueAsync(element) or updateChildrenAsync(element) a TimoutException.
My log for this error here:

What do solve the problem is to restart the server but it still not a real solution...
Is it possible my app is black-listed or something?
I'm using Google AppEngine standard for Java 8

What's your scaling mode?

A couple of things you can try out:

Switch to manual scaling and see if that helps (it's possible that basic scaling instances are turning off certain features after the idle timeout).
Enable debug logs for the SDK (recommended approach is to use SLF4J, but since you seem to be on 5.x you can also call FirebaseDatabase.enableLogging().

You should also share the code for initializing the SDK/Database and performing updates.

Switch to manual scaling and see if that helps (it's possible that basic scaling instances are turning off certain features after the idle timeout).

I'll investigate for some different type of scaling instance and return to you my test results, but I'm using this scaling mode:

	<instance-class>B1</instance-class>
	<basic-scaling>
	    <max-instances>1</max-instances>
	    <idle-timeout>10m</idle-timeout>
	</basic-scaling>

Maybe it's the problem, the instance class is too low or there isn't enough instances (maybe need more than 1).

Enable debug logs for the SDK (recommended approach is to use SLF4J, but since you seem to be on 5.x you can also call FirebaseDatabase.enableLogging().

I run the version 6.0.0:

	<dependency>
	  <groupId>com.google.firebase</groupId>
	  <artifactId>firebase-admin</artifactId>
	  <version>6.0.0</version>
	</dependency>

You should also share the code for initializing the SDK/Database and performing updates.

Here my code on initializing SDK/Database:
public class FirebaseInitListener implements ServletContextListener {

	/**
	 * @see ServletContextListener#contextInitialized(ServletContextEvent)
	 */
	public void contextInitialized(ServletContextEvent sce) {
		FirebaseOptions options = null;
		Map<String, Object> auth = new HashMap<String, Object>();
		auth.put("uid", "xxxxxxxxxxxxx");
		try {
			options = new FirebaseOptions.Builder().setCredentials(
					GoogleCredentials.fromStream(sce.getServletContext()
							.getResourceAsStream(
									"/WEB-INF/xxxxxxxxxxxxxxxxxxxx.json")))
					.setDatabaseUrl("https://rcm55-bagshop.firebaseio.com/")
					.setDatabaseAuthVariableOverride(auth)
					.build();
		} catch (IOException e) {
			e.printStackTrace();
		}
		FirebaseApp.initializeApp(options);
	}

	/**
	 * @see ServletContextListener#contextDestroyed(ServletContextEvent)
	 */
	public void contextDestroyed(ServletContextEvent sce) {}

}

Here the code using firebase database and throwing the timeout:
	private static void saveRTDB(Object o, String path) throws ApiException {

		DatabaseReference ref = FirebaseDatabase.getInstance()
				.getReference(path);

		try {
			ref.setValueAsync(o)
					.get(5, TimeUnit.SECONDS);
		} catch (InterruptedException e) {
			e.printStackTrace();
			log.severe(e.getMessage());
			throw new ApiException(500, "Error firebase, check server log");
		} catch (ExecutionException e) {
			e.printStackTrace();
			log.severe(e.getMessage());
			throw new ApiException(500, "Error firebase, check server log");
		} catch (TimeoutException e) {
			e.printStackTrace();
			log.severe(e.getMessage());
			throw new ApiException(500, "Error firebase, check server log");
		}

	}

Thank @hiranya911 for your help!

You find my problem I think. I checked and you're right I was using the old version (forgot to mvn clean).
Now I deed it and it doesn't seem to do the error again.
Other modification I figure out needed: I was using a old version of SLF4J (v 1.5.*) and it was causing an error on each /_ah/start request. I so update to v1.7 and now it seem more stable
Thank you for the fast response and problem handling!

Glad you made some progress. I will close this issue now. We can revisit it if the problems show up again.


Publish with reply

Is there way to publish message with providing replyTo subject? I don't need to subscribe on it, or wait a message on this reply. I just need this field filled out, because otherwise, the service I'm loading is trying to publish on an empty subject ("") and gets an error from nats: invalid subject

import java.nio.ByteBuffer
import java.util.Properties
import scala.concurrent.duration._

import proto.{Foo, Bar}
import com.logimethods.connector.gatling.to_nats._
import io.gatling.core.Predef._
import io.gatling.core.structure.ScenarioBuilder
import com.logimethods.connector.gatling.to_nats.NatsMessage

class DoBetSimulation extends Simulation {
  val props = new Properties()
  props.setProperty("io.nats.client.url", "nats://<IP_ADDRESS>:4222")
  val protocol = NatsProtocol(props, "")

  val scn: ScenarioBuilder = scenario("Test").repeat(1) {
    exec(NatsBuilder(new ProtoMessage()))
      .exec(pause(0.5.seconds))
  }
  setUp(scn.inject(rampUsers(20) over 5.seconds)).protocols(protocol)
}

class ProtoMessage extends NatsMessage {
  // I need to pass a subject for replying around here, I think
  def getSubject(): String = "test.subject"

  def getPayload(): Array[Byte] = {
    val bar = Bar(ID = "21266894", price = 155)
    val foo = Foo(amount = 100000,  `type` = 1, bars = Seq(foo))
    val buffer = ByteBuffer.allocate(foo.serializedSize)

    foo.toByteArray.foreach(buffer.put)
    buffer.array()
  }
}

There are no errors on a Gatling side, but for a relevant load I need to use NATS Request Reply approach. The only difference is that the reply-to subject is added to the message, but since this field is empty, the service that receives this message tries to reply to the empty topic and receives an error.
The main question is whether there is a way to set this parameter (replyTo subject) in a message?


Improve http_alerter (add headers, ignore ssl, basic auth)

add support for:

http_post_username/http_post_password for basic auth
add http_post_ignore_ssl_errors support
add http_post_headers

Can you resolve conflicts please :)

Can you resolve conflicts please :)


BUG : Virus definition logging bucket does not allow passing an imported bucket

What is the problem?
Cdk Serverless Clamscan construct does not accept an imported Bucket resource passed as a target for access logs created for Virus Definition bucket.
jsii.errors.JSIIError: Value did not match any type in union: Expected a boolean, got {"$jsii.byref":"aws-cdk-lib.aws_s3.BucketBase@10006"}, Object of type aws-cdk-lib.aws_s3.BucketBase is not convertible to aws-cdk-lib.aws_s3.Bucket

Reproduction Steps
#!/usr/bin/env python3
import aws_cdk as cdk
from aws_cdk import Aspects
from aws_cdk import aws_s3 as s3
from cdk_nag import AwsSolutionsChecks
from cdk_serverless_clamscan import ServerlessClamscan, ServerlessClamscanLoggingProps
from constructs import Construct

class BucketStack(cdk.Stack):
    def __init__(self, scope: Construct, construct_id: str, **kwargs) -> None:
        super().__init__(scope, construct_id, **kwargs)

        s3_access_logs_bucket = s3.Bucket(
            self,
            "rS3AccessLogsBucket",
            block_public_access=s3.BlockPublicAccess.BLOCK_ALL,
            bucket_name=f"s3-access-logs-{self.account}-{self.region}",
            encryption=s3.BucketEncryption.S3_MANAGED,
            enforce_ssl=True,
            versioned=True,
        )

        cdk.CfnOutput(
            self,
            "oS3AccessLogsBucketArn",
            export_name="oS3AccessLogsBucketArn",
            value=s3_access_logs_bucket.bucket_arn,
        )

class AntiVirusStack(cdk.Stack):
    def __init__(self, scope: Construct, construct_id: str, **kwargs) -> None:
        super().__init__(scope, construct_id, **kwargs)

        s3_access_logs_bucket = s3.Bucket.from_bucket_arn(
            self,
            "rS3AccessLogsBucket",
            bucket_arn=cdk.Fn.import_value("oS3AccessLogsBucketArn"),
        )

        ServerlessClamscan(
            self,
            "antivirus-scanning",
            defs_bucket_access_logs_config=ServerlessClamscanLoggingProps(
                logs_bucket=s3_access_logs_bucket,
                logs_prefix=f"s3-access-logs-{self.account}-{self.region}",
            ),
        )

app = cdk.App()
BucketStack(app, "BucketStack")
AntiVirusStack(app, "AntiVirusStack")

Aspects.of(app).add(AwsSolutionsChecks())
app.synth()

What did you expect to happen?
I expected the cdk construct to accept an imported bucket being passed as a target for access logging for the Virus Definitions bucket
cdk-serverless-clamscan version
2.1.26
Language
Python
Other information

Thanks for reporting and submitting a PR 😄


⚠ Avatar API Endpoint has degraded performance

In 9c8c2a5, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 4214 ms

Resolved: Avatar API Endpoint performance has improved in 5088c2f after 16 minutes.


Enhancement: Use .deb installer to install a specific virtualbox version

Closes #10
Previously, apt was used to install virtualbox. Although this means builds are less error prone and should work, it has downsides:

images version of virtualbox will mutate over time along with the upstream apt package
unknown and unpredictable virtualbox version in docker images
different virtualbox versions among distro variants e.g. apt package on ubuntu 18.04 was virtualbox 5, whereas apt package on ubuntu 20.04 was virtualbox 6

Now a specific version of virtualbox is installed by using official .deb pacakges. This keeps reliability of builds, while addressing all of above weaknesses.

Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 virtualbox-6.1 : Depends: libc6 (>= 2.29) but 2.27-3ubuntu1.4 is to be installed
                  Depends: libqt5core5a (>= 5.12.2) but 5.9.5+dfsg-0ubuntu2.6 is to be installed
                  Depends: libqt5widgets5 (>= 5.12.2) but 5.9.5+dfsg-0ubuntu2.6 is to be installed
                  Depends: libvpx6 (>= 1.6.0) but it is not installable
                  Recommends: libsdl-ttf2.0-0 but it is not going to be installed
                  Recommends: linux-headers-generic but it is not going to be installed or
                              linux-headers-generic-pae but it is not installable or
                              linux-headers-686-pae but it is not installable or
                              linux-headers-amd64 but it is not installable or
                              linux-headers-2.6-686 but it is not installable or
                              linux-headers-2.6-amd64 but it is not installable or
                              linux-headers
                  Recommends: pdf-viewer
E: Unable to correct problems, you have held broken packages.

trying to find an better way to install than the .deb packages than cannot resolve their dependencies.

prefer #18

closing in favor of #18


Spike: MobilityDatabase SEO Audit

After the first iteration of SEO change this task is meant to explore where the MobilityDatabase stands and where it can be further improved

Identify key searches for what we want high ranking seo results
Understand what google is currently crawling on the MobilityData website
See where MobilityDatabase currently ranks in our key searches
Explore SEO analysis tools
Create follow-up tasks to improve SEO results

Findings in google doc link: https://docs.google.com/document/d/1beFarbPOLr_RgWqJIlc1AtlGaoFSOXlShCUfYPPNedE/edit?usp=sharing


Feature Request : Visual flow editor

Design and run complex flows / State machines from FaaS functions.
Expected Behavior
The idea is similar to amazon step functions and states language.
See https://aws.amazon.com/fr/blogs/aws/new-aws-step-functions-build-distributed-applications-using-visual-workflows/
We could use a visual editor to chain functions.
Possible Solution
I'm willing to explore the node-red road : the blocks are highly configurable, do have properties, and the resulting flow can be saved as a Json file.
The node red editor is stable and used in several projects.
Functions are blocks, We'll need some structure control as well (parallelism, conditions, retries)
Context
I'd like to reduce friction when adopting FaaS, and allow non dev to build complex data flows.
Those are just some thoughts right now, but I'll try to demo something.

Thanks for the suggestion. @SylvainDeaure

Adding label - revisit, will come back to this and close for now. Feel free to re-open and add to the discussion.

fission which is a competitor ( ? ) to open-faas has fission-workflow. Argo is bound to containers but not to specific serverless stack does workflow and has a nice dashboard (just hard to find screenshots in their documentation). I don't think neither of those has a GUI to generate the workflows.

Just found this video that integrates open faas with node-red
https://www.youtube.com/watch?v=ndv1KFtxT38
Not sure if the integration between node-red and open-faas couldn't be made better. But it does look interesting.


Properly escape both username and password in auth url

Both the username and password may contain characters that are not valid
in HTTP basic auth, we want to escape both, and will assume that the
first colon is what should be split on.

@jurre CI should be fixed now 😅


[Toolkit feature]: Pause Toolkit rendering and halt its resources needs

Contact Details (Optional)
No response
What is the context of the feature/improvement?
Would love a button to pause Toolkit rendering and halt its resources needs, for allocating hardware resources to the game instead, or for Ingesting, or for AI PBR and Upscale missions. It's also references by another user over here, but as a bug:
https://github.com/NVIDIAGameWorks/rtx-remix/issues/314#issue-2094849079
Please describe the feature/improvement?
As described above
What would be your solution? (optional)
...
Version
2024.1.1

Filed as internal ticket REMIX-2688


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v4.4.293",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=28e016e02118917e50a667bc72fb80098cf2b460"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "28e016e02118917e50a667bc72fb80098cf2b460",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "usb: host: ohci-tmio: check return value after calling platform_get_resource()\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.4.293 by commit 28e016e02118917e50a667bc72fb80098cf2b460. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1002221


Automate updating runtime images by scanning Quay.io for newer tags

Following up with @phanikumv's comment https://github.com/astronomer/astronomer-providers/pull/1142#pullrequestreview-1446319186 on PR #1142,
the PR adds a new GitHub Actions workflow that automates the
process of updating the runtime image tag in the Dockerfile.astro_cloud
and Makefile files. It includes the following changes:

Adds a new workflow file .github/workflows/runtime-image-update.yaml to the repository.
Adds a Python script .github/scripts/get_latest_runtime_image_tag.py to fetch the latest tag from the Quay repository.

The workflow is triggered on a schedule and can also be manually triggered.
It performs the following steps:

Retrieves the current tag from the existing Dockerfile.astro_cloud using awk.
Calls the Python script to fetch the latest tag from the provided Quay.io repository.
If no Quay.io repository is provided, the default repository astronomer/astro-runtime is used.
Compares the current tag with the latest tag to determine if an update is needed.
If an update is required, it replaces the tags in the Dockerfile.astro_cloud and Makefile using sed.
Creates a pull request with the updated tag if changes were made.

Nice work @pankajkoti

Thank you Phani for the idea and support!


Maybe handle odd exceptions in verify_typing

So the frontend doesnt handle exceptions when we find something in verify_typing.  This will produce a list of elements from whats wrong:
https://github.com/ff14-advanced-market-search/saddlebag-with-pockets/assets/17516896/931a2a01-5ab7-4d7e-b0a5-d1acf9722433

The frontend cant handle this and only shows a response when elements is a string

However I'm not 100% sure we should have the FE tell people whats wrong, we dont want to point people in the right direction (i.e. tell people we are detecting their sql injection). Maybe if the elements is a list just tell people This request is invalid, please screenshot your input and contact us on discord to resolve the issue.

If you changed the error response type then the front end will need updating.
Have you thought of changing the responses to be REST responses?

One thing we could do is uniform all responses to have a response of :
{ success: true, data: {...} }  {.success: false, error: string }
Then you can have a dictionary of error strings you return.
And we can have a file we can reference and use and keep up to date:
{ invalid_input: "Required input missing or wrongly formatted", default_error: "Unknown problem occurred",  }


.NET build pipeline

Add .NET build pipeline in Travis. possibly using Cake build

I take.

CI up and running on AppVeyor now :) https://ci.appveyor.com/project/cpx/protoactor-dotnet-pr5pp
Will look into using Cake as well - e.g. for generating proto contracts, and packaging/pushing NuGet packages.

We should probably create an organizational account, but this'll do for now :)

Closing this since we have all important pieces working:

automatic build/test/package
versioning of pre-release packages
automatic push to myget feed


Add atmospheric extinction for Roque de los Muchachos observatory

Good to build this library of extinction curves up some!
I also reorg'd the resources subdir as a result:
https://github.com/jradavenport/pydis/commit/a4ef172e774ee733e39cd47b954e0c5d155aae65

On Tue, Dec 08, 2015 at 05:38:23PM -0800, James Davenport wrote:

I also reorg'd the resources subdir as a result:
https://github.com/jradavenport/pydis/commit/a4ef172e774ee733e39cd47b954e0c5d155aae65

That is a good idea.


Need to Rebuild phantomjs 2.1.1 for Windows.

Need to Rebuild phantomjs 2.1.1 for Windows.
I have Installed VS2015, ActivePerl 5.22.1 Build 2201, Git-<IP_ADDRESS>-64-bit.exe, Python 3.5...
Downloaded phantomjs-master in C:\
Now Please let me step by step details to Edit and Build phantomjs-master....
Please start from Beginning in depth Details....
Thank You in Advance

can some one make a Video and post...It will be better...I need it from beginning.

Thank you for submitting this ticket!
This issue tracker primarily serves as the tool to report and track bugs, defects, and development tasks.
For the general question, code review request, build problem, or other related discussion, please post it to either:

the official PhantomJS users mailing-list
Stack Overflow (with phantomjs tag)

If you have not read it yet, please check also a few tips on Effective Q&A.


RCTImageLoader

Hello guys,
I just update all my project to react-native 0.40, and
I'm trying to use your package but I got this error on xcode:
[RCTImageLoader _loadImageOrDataWithURLRequest:size:scale:resizeMode:progressBlock:partialLoadBlock:completionBlock:]_block_invoke.194 + 355
libc++abi.dylib: terminating with uncaught exception of type NSException
My dependencies: {
"gl-react": "^2.2.4",
"gl-react-image": "0.0.2",
"gl-react-native": "^2.40.1",
"react": "15.4.2",
"react-native": "<=0.40.0",
"react-native-camera": "git+https://github.com/lwansbrough/react-native-camera.git",
"react-native-image-cropper": "^0.3.0",
"react-native-router-flux": "^3.37.0"
}
Hope you can help me
regards,

Issue Solved few days after with npm i
;-)

clovs = clown? 😆


Week 2 hacks

Table/HTML fragments
Lists,dictionaries,loops
New theme

2.9
Very helpful
Very nice theme and background
Completed all tasks

2.9+

Did all of the tasks needed
experimented with a new remote theme
made a table
appealing website

2.8+
-Needed work is done
-Explored a lot of innovative options
-Creativity makes work apealing


The 1,000 workflows Logic Apps limit is confusing in terms of what is limited

On this docs page: https://docs.microsoft.com/en-us/azure/logic-apps/logic-apps-limits-and-config?tabs=azure-portal
There is a limit that is specified that looks like:
Workflows per regions per subscription - 1,000 workflows
What exactly does this mean? Does this mean that you can only create 1,000 Logic Apps per region per subscription? Or does this mean that a specific Logic App can only have 1,000 workflows inside of it per region per subscription?
Some clarification here would be greatly appreciated! Thank you!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 845c4db9-1f3a-26d1-5061-c018cb1fe336
Version Independent ID: c2a03981-a0aa-64a5-2659-e10202e5bb14
Content: Limits and configuration reference guide - Azure Logic Apps
Content Source: articles/logic-apps/logic-apps-limits-and-config.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

@KyleBastien Thank you for your feedback! We will review and update as appropriate.

#assign:@ecfan

@KyleBastien, a doc update will be published later today to clarify this entry.
For Consumption logic apps, where each logic app is limited to 1 workflow, you can have 1,000 logic apps per region per subscription.
For Standard logic apps, where each logic app can have multiple workflows, no specific limit exists, but the number of logic apps varies based on the selected hosting plan, app activity, size of machine instances, and resource usage.

@ecfan Thanks for this clarification! Looking forward to seeing the updated docs. So if I understand what you're saying for Standard logic apps, you can have 1,001 workflow definitions in the one Standard Logic App, but you couldn't have 1,000 Standard Logic App instances. Is that right?

@KyleBastien,
I'm saying that a Standard logic app instance can have multiple workflows with no fixed limit, but the number you can have varies based on the hosting plan and pricing tier that you select and other factors, such as resource usage and capacity.
There's also no fixed limit on the number of Standard logic app instances per region per subscription, but this number also varies based on the number of actual workflows that you're running as described above.
So, both numbers depend on the plan you select and the resources that your logic app workflows use in that plan.

Got it, thanks very much for that clarification @ecfan!

@KyleBastien,
The 1,000 threshold is only relevant to Consumption logic apps.


Error if pyk4a isn't installed

If pyk4a isn't installed, this line gets called anyway and causes an error.
Maybe we can make this line conditional on there being azures in the config?

Will be addressed in #40

Should be fixed


[docs] Flink CDC has supported many databases who supports MySQL protocol, we can list them to let user know

https://ververica.github.io/flink-cdc-connectors/master/content/about.html#supported-connectors

polardb
polardbx

@Cleverdada Would you like to take the task to help list the supported database in our document?

@Cleverdada Would you like to take the task to help list the supported database in our document?

sure, I'm goting to write a common document .


vendor: upgrade grpc/grpc-go to v1.7.4

To include upstream fix https://github.com/grpc/grpc-go/pull/1687.
Already backported to release-3.2, planning v3.2.11 sometime this week.
Should fix https://github.com/coreos/etcd/issues/8904.

lgtm

Will merge after all CIs pass (waiting for some others PRs to be merged, and will rebase).


Issue with Auth in Singularity 1.2.0

Hey
We're currently adding another layer of security into our current cluster, but have already faced several issues.
We've managed to add webhook into our, I'd say, thingy, which is serving login page and goes into LDAP for user verification.
Output is pushed into cookie and passed to Singularity.
First issue -- we were unable to feed that to Singularity through header, 'cause js scripts which are 'talking' to api were ignoring forwarded authorization header and used null instead -- that's why we've used cookie wrapping.
Second -- any emailed action doesn't have singularityUserId anymore (actually this is a long-runner, unrelated to current issue and is observed at least for last 12 months). Can singularityUserId be also parsed from http://URI/singularity/api/auth/user from user:id field if auth is enabled?
And the main issue is that I don't get how groups are working.
Users who are enrolled into jitaGroups+requiredGroups are unable to browse UI at all, everything blows up with something like
An error occurred while accessing /requests/ids?useWebCache=true&state=ACTIVE&state=PAUSED&state=SYSTEM_COOLDOWN&state=FINISHED&state=DEPLOYING_TO_UNPAUSE

Unable to authenticate using methods: [SingularityWebhookAuthenticator (Exception while verifying token: java.lang.RuntimeException: javax.ws.rs.WebApplicationException: HTTP 401 Unauthorized)]

Although everything is working as intended (I mean -- whole our machinery with blows and whistles).
Users who are enrolled into globalReadOnlyGroups+requiredGroups are able to pause/unpause jobs and edit anything (wut?).
Users who are enrolled into adminGroups+requiredGroups -- can do pretty much the same as RO users do.
Can you please clarify how this feature is working (or not)? Can we assign more granular rights to groups? Thanks!

So there is a bunch here and I can provide a more detailed response tomorrow. but some shorter highlights:

I totally acknowledge Singularity auth was an afterthought. As an internal-only tool it went from totally open for a small team of engineers to trying to figure out how to mesh an oss project with our internal home-built auth system
We recently added more granular permissions and updated how Singularity does its checks a bit in https://github.com/HubSpot/Singularity/pull/2092 . tl;dr on that one is that originally the old auth was aimed at 'is this person at least allowed to be in Singularity'. The options aren't quite as granular as I would want, but at least allow it to distinguish read/write/admin scopes on top of existing groups. (i.e. fixes the anyone in a valid group can do stuff issue). This will be in a 1.3.0 andI can try and get a public release out soon-ish if you're interested

Great news, thank you!
We'd happy to test new release as soon as it will be available 😄

1.3.0 jars should be on maven central in a bit, just released. Gonna close this one for now and we can open new/specific issues as they pop up 👍

Amazing, thank you!
We'll start testing asap.


Update hf baseline to remove repetition

fixed --without_fastseq_opt parameter to actually run the hf generation without any fastseq optimizations. This can now be used with the fastseq-generate-for-transformers command as a baseline.
removed run_eval_hf.py as it is no longer needed.

Thanks @JulianneKnott for the changes! In stead of adding multiple if fastseq_opt ... else ..., do you think it is better to use two functions to separately organize the code for the baseline and fastseq optimization?

Split it into two functions.


⚠ RPC server - Binance BSCT has degraded performance

In e3b360f, RPC server - Binance BSCT ($BINANCE_BSCT_RPC_URL) experienced degraded performance:

HTTP code: 504
Response time: 10723 ms

Resolved: RPC server - Binance BSCT performance has improved in d4afcfa.


Expose ability to get and set scaling limits on bounding box at runtime

We're making use of bounding boxes to manipulate dynamic content. Part of this involves dynamically querying the size characteristics of the content and deciding at runtime what the minimum and maximum scale factors should be. Another part of this scenario is detecting when the minimum/maximum are reached to display information to the user.
Exposing these values and the means to update them at runtime (and recalculate the cached parameters based on them) allows completion of this scenario. This also exposes the ability to have more precise control of scaling by setting it in either absolute or relative (default) terms.

/azp run mrtk_pr

@djohnsomsft thanks for the PR! We are trying to sure that each PR references an issue, could you please reference the issue you are fixing, or create a new one & reference it?


Set up the starter project

Simply start a new flutter project

The starter project has been created https://github.com/safeherven/safeherven_app/commit/46870a1d26b40f517a7f99293089cfe707baff1b


Bug Report: Kade Engine 1.2.2 and above not compiling on Windows properly due to Discord RPC, even when everything is installed correctly.

Title says it all. I installed everything correctly, every haxe library, every VS2019 dependency, everything. Nothing fixes this damn compiling issue that reads:
"source/Discord.hx:5: characters 8-30 : Type not found : discord_rpc.DiscordRpc
source/Discord.hx:14: characters 3-13 : Type not found : DiscordRpc
source/Discord.hx:24: characters 4-14 : Type not found : DiscordRpc
source/Discord.hx:29: characters 3-13 : Type not found : DiscordRpc
source/Discord.hx:34: characters 3-13 : Type not found : DiscordRpc
source/Discord.hx:39: characters 3-13 : Type not found : DiscordRpc
source/Discord.hx:75: characters 3-13 : Type not found : DiscordRpc"
If there is no way to fix this, you should make a Discord RPC-less Kade Engine for those who can't compile the engine with Discord RPC.

This was fixed in 1.4.3.

1.4.3 doesn't exist though??

Sorry, I'm really dumb, I meant 1.4.2. Edited

I was compiling 1.4.2 however.

did you follow the building instructions correctly? you might not have installed discord_rpc right (you do it through git, not haxelib install discord_rpc)

I did git install discord_rpc, the current master source code has the exact same error.

I did run it before, same error.


Add blogpost for js-ipfs release 0.23.0

Time to kick up the blog again. Very simple post describing the latest js-ipfs release.

@diasdavid @dignifiedquire please review this so we can publish this asap

Rendered version for easier review: https://github.com/ipfs/blog/blob/e0cc4886c2708d16ee7d19fd1f61c5e630eee43f/src/23-js-ipfs-0-23/index.md

Updated based on the reviews, will merge and publish this now.


Adding event subscribers to mikro-orm.config.ts causes cli to hang indefinitely

Describe the bug
Adding event subscribers to my MikroORM config, causes the CLI to never exit.
To Reproduce
Steps to reproduce the behavior:
Given a config with a simple subscriber and entity:
// db/config.ts
export const config: Options = {
  entities: [MyEntity],
  subscribers: [new MyEntitySubscriber()],
};

// mikro-orm.config.ts
import { config } from "./db/config"

export default config;

Expected behavior
When I run npx mikro-orm debug, the command should exit. But instead hangs indefinitely until I interrupt ^C (or CTRL+C).
Additional context
This issue happens with every single command in @mikro-orm/cli. It works again if I remove the subscribers array in my config.
Versions

Dependency
Version

node
v14.17.0

typescript
v4.3.2

mikro-orm
v4.5.6

your-driver
<EMAIL_ADDRESS>

Not reproducible on my end, can you provide executable repro?

Closing as stale, will be happy to reopen if you provide actual reproduction.

I figured it out.
I was importing a file that itself imported something from bullmq. When imported, that file performs a blocking task (spawning a queue).


Implement Gateway & Component management

Although I welcome this, it does expand the SDK beyond the current "app" scope. What would you suggest @johanstokking?

Yes, I can imagine it's very welcome but indeed this is beyond the application scope.
The application scope, on a high level, interfaces with the Handler through the Application Manager and Data API, and uses the Account Server for authentication. Gateway and component management is resource management on the Account Server.
I'd suggest introducing a new repository for this. Not sure what's common in the Java ecosystem though.

Well, since it's related to account, my opinion is that we could include this in the account library.
Then, we should rename this repo into something like java-sdk and just drop "app" ?
When building the project, all artifacts will be separated anyway and individually releasable, even if sitting in the same git repo.

OK sounds good

I guess how we deal with this also depends on the language and options to separate different parts of the SDK to keep it lightweight. For example, for Nodejs I'd suggest splitting it into ttn-data, ttn-account etc with ttn depending on all of them. Much like lodash, allowing you to also just depend on what you need instead of the all in one.


Registration of INotificationHandler<> in the Ioc Container causes messages to be handled twice

in the Ioc project the following
services.AddScoped<INotificationHandler, CustomerCommandHandler>();
causes the CustomerCommandHandler Handle method to run twice!

The IOC registration of command handler should be specific.
services.AddScoped<INotificationHandler<RegisterNewCustomerCommand>, CustomerCommandHandler>();

I think Thiago answered your doubt!


How do I group/nest by URL?

How can I have nested grouping by URL?
Here is an example of how I would like them nested.

identity

company

list => /identity/company/list/
manage => /identity/company/manage/{pk}

user

list => /identity/user/list/
manage => /identity/user/manage/{pk}

other_app

model

list => /other_app/model/list/

Here is how it is currently being rendered.

Identity

identity/company/list
identity/company/manage
identity/user/list
identity/user/manage

other_app

other_app/model/list

I have been messing with my own SchemaGenerator but no success getting it to render the way I want. Also, my URLs are well namespaced and in their separate files/apps.
I feel like I am running into #536 but I am on DRF 3.5.3 and DRS 2.1.0

same issue here

DRF 3.6.4 and DRS 2.1.2
Endpoints grouping not work for my

same issue, using drf 3.6.4 and drs 2.1.2


dynamic attributes in traits dont get evaluated in the expected order

trait :email do
  email {<EMAIL_ADDRESS>}
end

factory :user do
  name "Bill"
  email
  combined { "#{name} <#{email}>" }
end

Creating an instance of user sets combined to "Bill <>"  not the "Bill<EMAIL_ADDRESS>I would expect

Hey Thomas!
Yeah, this is an issue with the current system of using priority on attributes to sort execution order. I'm in the process of removing all this priority and sorting code and replacing it with an anonymous class that has methods defined on it; this allows FG to use Ruby to do all the lazy evaluation of attributes. The current work is being done on the refactor-proxy branch - you can see the work here. I'm going to try to get this wrapped up this weekend and push out version 2.3.2 of the gem once I'm done.
I even added this exact test case to the suite to make sure it passes (it does): https://github.com/thoughtbot/factory_girl/commit/781d2b3b383c29a57e699e8d47f1fff662ff2bde

@joshuaclayton -  Great -- thanks for the update

Thomas,
I also just cut gem version 2.3.2 of factory_girl, which includes the fix for this issue.
Thanks for your patience!


Update Azure AD SSO with Contentful tutorial

Include steps to set it up in Contentful
Change "Call Contentful support" to self-serve steps users can perform themselves in Contentful
Change certificate to download from Raw to Base64

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: domarku sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hi @domarku - Thank you for your contribution. Would you take a moment to sign the CLA? After the CLA is signed, someone will review your changes. Thanks!

@domarku : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi 👋 Are there any updates on the review of this PR?

Hi @jeevansd - Could you review the proposed changes? Thanks!

I see the changes are live, thank you!


update to openms 3.2.0

User description

PR checklist

[ ] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/quantms branch on the nf-core/test-datasets repository.
[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

PR Type
enhancement, dependencies

Description

Updated GitHub Actions upload-artifact version from v1 to v4, and modified artifact names to include GitHub run ID.
Upgraded OpenMS third-party conda package version from 3.1.0 to 3.2.0 across multiple modules.
Upgraded quantms-utils conda package version from 0.0.10 to 0.0.11 across multiple modules.
Updated nextflow.config version from 1.3.0dev to 1.3.1dev.

Changes walkthrough 📝
Relevant filesEnhancement1 files

ci.ymlUpdate GitHub Actions artifact version and naming

.github/workflows/ci.yml
Updated GitHub Actions upload-artifact version from v1 to v4.  Modified artifact names to include GitHub run ID.

+6/-6

Dependencies14 files

dev.configUpgrade OpenMS third-party package version

conf/dev.config
Updated OpenMS third-party conda package version from 3.1.0 to 3.2.0.

+1/-1

main.nfUpgrade quantms-utils package version

modules/local/add_sage_feat/main.nf

Updated quantms-utils conda package version from 0.0.10 to 0.0.11.

+3/-3

main.nfUpgrade quantms-utils package version

modules/local/diannconvert/main.nf

Updated quantms-utils conda package version from 0.0.10 to 0.0.11.

+3/-3

main.nfUpgrade quantms-utils package version

modules/local/extract_psm/main.nf

Updated quantms-utils conda package version from 0.0.10 to 0.0.11.

+3/-3

main.nfUpgrade quantms-utils package version

modules/local/extract_sample/main.nf

Updated quantms-utils conda package version from 0.0.10 to 0.0.11.

+3/-3

main.nfUpgrade quantms-utils package version

modules/local/generate_diann_cfg/main.nf

Updated quantms-utils conda package version from 0.0.10 to 0.0.11.

+3/-3

main.nfUpgrade quantms-utils package version

modules/local/ms2rescore/main.nf

Updated quantms-utils conda package version from 0.0.10 to 0.0.11.

+3/-3

main.nfUpgrade quantms-utils package version

modules/local/mzmlstatistics/main.nf

Updated quantms-utils conda package version from 0.0.10 to 0.0.11.

+3/-3

main.nfUpgrade OpenMS third-party package version

modules/local/openms/consensusid/main.nf
Updated OpenMS third-party conda package version from 3.1.0 to 3.2.0.

+3/-3

main.nfUpgrade OpenMS third-party package version

modules/local/openms/decoydatabase/main.nf
Updated OpenMS third-party conda package version from 3.1.0 to 3.2.0.

+3/-3

main.nfUpgrade OpenMS third-party package version

modules/local/openms/epifany/main.nf
Updated OpenMS third-party conda package version from 3.1.0 to 3.2.0.

+3/-3

main.nfUpgrade OpenMS third-party package version

modules/local/openms/extractpsmfeatures/main.nf
Updated OpenMS third-party conda package version from 3.1.0 to 3.2.0.

+3/-3

main.nfUpgrade OpenMS third-party package version

modules/local/openms/falsediscoveryrate/main.nf
Updated OpenMS third-party conda package version from 3.1.0 to 3.2.0.

+3/-3

main.nfUpgrade OpenMS third-party package version

modules/local/openms/filemerge/main.nf
Updated OpenMS third-party conda package version from 3.1.0 to 3.2.0.

+3/-3

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

@timosachsenberg PR https://github.com/OpenMS/OpenMS/pull/7326 apparently broke the workflow. Any idea?
I checked. We are not overwriting any correction factor. Defaults should be used. Apparently they do not work anymore.

@cbielow you have a deeper understanding of that code. Any idea?

I am guessing that isobaricanalyzer is broken in general and only works in our tests because we completely supply an ini file with prefilled correction matrix.
Probably taking the default is not working.

@jpfeuffer @timosachsenberg @cbielow Taking the default will not work because that option do not exist anymore by reading this https://github.com/OpenMS/OpenMS/blob/ff325fe8572c953a6dbad3eb14b7facebf5549e5/src/topp/IsobaricAnalyzer.cpp#L95 looks like we have to provide for every method the matrix (then the concept of default is gone). Where and how I can generate what it used to be default metrics/values?

@ypriverol do we specify that we want to do tmt11plex to IsobaricAnalyzer (e.g., given by the sdrf?)
in IsobaricAnalyzer the tmt11plex has a zero correction matrix. Does anyone know if this is correct? I would assume that this leads to an identity matrix and the mentioned error. If it is correct, then an identity matrix would indeed be fine and correction can be skipped.

support was added in: https://github.com/OpenMS/OpenMS/commit/f4cee4e78e450d973bb3e765fa73b42e773a2b05

If I look at some batch certificates e.g. A37725_ZF395505 it seems as if tmt11plex is similar to tmt10plex and not all zeros?
https://www.thermofisher.com/order/catalog/product/de/en/A34808
So my guess would be that the entries are not correct in OpenMS?
Can someone confirm (@cbielow or @jpfeuffer)

@ypriverol do we specify that we want to do tmt11plex to IsobaricAnalyzer (e.g., given by the sdrf?)
in IsobaricAnalyzer the tmt11plex has a zero correction matrix. Does anyone know if this is correct? I would assume that this leads to an identity matrix and the mentioned error. If it is correct, then an identity matrix would indeed be fine and correction can be skipped.

@timosachsenberg if you see how we call the method:
IsobaricAnalyzer \
      -type tmt6plex \
      -in TMT_Erwinia_1uLSike_Top10HCD_isol2_45stepped_60min_01.mzML \
      -threads 2 \
      -extraction:select_activation "auto" \
      -extraction:reporter_mass_shift 0.002 \
      -extraction:min_reporter_intensity 0.0 \
      -extraction:min_precursor_purity 0.0 \
      -extraction:precursor_isotope_deviation 10.0 \
       \
      -tmt6plex:reference_channel 126 \
      -out TMT_Erwinia_1uLSike_Top10HCD_isol2_45stepped_60min_01_iso.consensusXML \
      -debug 0 \
      2>&1 | tee TMT_Erwinia_1uLSike_Top10HCD_isol2_[45](https://github.com/bigbio/quantms/actions/runs/11147642102/job/30982471524?pr=423#step:7:46)stepped_60min_01_isob.log

  cat <<-END_VERSIONS > versions.yml
  "NFCORE_QUANTMS:QUANTMS:TMT:FEATUREMAPPER:ISOBARICANALYZER":
      IsobaricAnalyzer: $(IsobaricAnalyzer --version 2>&1 | grep -E '^Version(.*)' | sed 's/Version: //g' | cut -d ' ' -f 1)
  END_VERSIONS

We do provide from the sdrf the type of tmt experiment in the current failing github actions is tmt6plex.

Seems it also has all zeros for TMT6Plex:
https://github.com/OpenMS/OpenMS/blob/develop/src/openms/source/ANALYSIS/QUANTITATION/TMTSixPlexQuantitationMethod.cpp#L46-L58

@yasset as a temporary fix we need to specify the correction matrix in the ini file (to overwrite the correction matrix entries with zeros)
@jpfeuffer and @cbielow @poshul correct me if I am wrong, but I think we also need to update those correction matrix entries.
For tmt11plex see discussion: https://github.com/OpenMS/OpenMS/pull/4295#discussion_r337539997 why matrices were not averaged and we ended up with the default (zeros).

I see two possibilities to fix this in OpenMS:

allow zeros again
come up with a proper (averaged) matrix for the ones that are still zero

Then the problem is that we only make an exception for tmt11plex in the tool check. But not for tmt6plex which is apparently also all 0s.
I think we should definitely provide reasonable defaults, since it is very tedious (also just for testing) to specify long lists of strings on the command line.

My vote would be:

If there is a clear default for a kit use it (but allow overwrite)
If there is a reasonable default (most of the kits have that or if we can do some average), put it as default but warn
If there is not a reasonable default put 0s, allow them (either per default or maybe only through a force flag)

I am fine with having default tables that we can provide to the tool. But we have to know where they are and how they should be annotated. I can store them in quantms as additional data. Then, if the users have a different correction matrix they should be able to provide it. See also this discussion in SDRF about TMT matrices standardisation: https://github.com/bigbio/proteomics-sample-metadata/issues/723 I can do that right now, but I need the "default" matrices for our previous implementation.

They are in the TMT*QuantitationMethod.cpp files that Timo linked. The problem is we do not have them for every TMT type. You have to come up with a good default yourself (based on the values on the vendor's Kit sheet, see e.g. Thermo's website).
Sometimes you get a specific matrix when buying the kit (based on the batch).

Do you know what others uses as default MaxQuant and others?

No. I would guess identity matrix or fail per default (i.e. matrix is mandatory)

@timosachsenberg @jpfeuffer I found the response about FragPipe https://github.com/Nesvilab/FragPipe/issues/963

The algorithm has an option enable_isotopic_correction or similar. Maybe it can be disabled in the tool via command line option. On my phone right now…

@timosachsenberg @jpfeuffer Looks like it works?

@cbielow Thanks for the clarification. For now I'm first switching off (by default) and currently implementing a mechanism to provide a default matrix. BTW, Would be great if we can put somewhere (all the matrices) (not inside the code) to dynamically loaded by the user. Also for the user to know how to overwrite a matrix.

@timosachsenberg here is the first prototype about how the matrix should look like https://github.com/bigbio/quantms/blob/f1210fc56359f0e5f32268aa189f84d0b8a7000f/assets/tmt6plex_default_correction.matrix

I added one from existing lots: https://github.com/OpenMS/OpenMS/pull/7601
but one can of course just disable isotope correction. then it will be equivalent to your default one.
I did not implement loading from files in OpenMS but I think this is probably easier done with a script like yours that changes the ini.

I think for quantms it does't make sense now to have it in OpenMS, I will start adding some of the default matrices in assets and the users can select one of them if they want.

Does anyone know why it does not find the .nextflow.log anymore? Do we log to a different directory? Did nextflow change the default location?

Does anyone know why it does not find the .nextflow.log anymore? Do we log to a different directory? Did nextflow change the default location?

Well spot, let me find out.

Does anyone know why it does not find the .nextflow.log anymore? Do we log to a different directory? Did nextflow change the default location?

Solved.

The problem is that your ls -la does not show hidden files..
We would have found out, that the file is actually there and that the upload-action@v4 has a new parameter include-hidden-files.