pick up knative-serving 1.9.3 release

pick up knative-serving 1.9.3 release
Our queue proxy shutdown now performs a graceful shutdown (https://github.com/knative/serving/pull/13829, @dprotaso)

Codecov Report

Merging #95 (d38454a) into main (515b770) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head d38454a differs from pull request most recent head 4f00538. Consider uploading reports for the commit 4f00538 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   70.76%   70.76%
=======================================
  Files           4        4
  Lines         195      195
=======================================
  Hits          138      138
  Misses         40       40
  Partials       17       17

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


API Documentation and Behavior Mismatch

I'm looking at the documentation for V2 for listing all orders and I'm noticing a number of discrepancies in the documentation and how it performs http://woocommerce.github.io/woocommerce-rest-api-docs/?ruby#list-all-orders
For example the orderby and order flags seem to have no effect on what gets returned. Additionally the per_page options doesn't actually change the page size that comes back and after does not seem to have any effect on what comes back.
Here is an example script that should replicate the problems:
# Setup:
require "woocommerce_api"

woocommerce = WooCommerce::API.new(
    "http://example.com", # Your store URL
    "consumer_key", # Your consumer key
    "consumer_secret", # Your consumer secret
    {
        wp_json: true, # Enable the WP REST API integration
        version: "v2" # WooCommerce WP REST API version
    }
)

result1 = woocommerce.get("orders?order=asc&orderby=slug").parsed_response
result2 = woocommerce.get("orders?order=desc&orderby=date").parsed_response

if result1 == result2
  puts "FAIL: ordering should change the results that come back"
else
  puts "PASS: it looks like the ordering changed things which is good"
end

result1 = woocommerce.get("orders?per_page=10").parsed_response # This is the default value
result2 = woocommerce.get("orders?per_page=15").parsed_response

if result1 == result2
  puts "FAIL: page size should be different"
else
  puts "PASS: it looks like the page size is different which is good"
end

I believe this was mainly based on my confusion between the gem's documentation and the websites documentation. I opened a PR on the website documentation to resolve my issues: https://github.com/woocommerce/woocommerce-rest-api-docs/pull/112


TASK [Ensure internet-monitoring enviroment is running] error

Hi
I have this error but cant find out what is causing it
Im on Debian PI on a VM if that help

Thanks

Maybe just do a 'docker pull prom/blackbox-exporter' and see if you get more details why it's failing?


Update About

As a visitor, I want to dive deep into the who and why of James.

Why?
Short-term Goal
Community Highlights
Social reach stats
Online Media Kit
Work History

LInkts to top interacted v2


simple way to do LSB transmissions ?

I am using your library for a project but it's a console that sends LSB first.
Is there a simple way to change this as I'm having to convert everything at the moment, just making baby steps but this is a big issue for a beginner :P

Sorry for the late reply. Selecting MSB/LSB is the scope of master device. And most of the devices use MSB first by default, so I don't have a plan to do it. Please refer https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/peripherals/spi_master.html#transactions-with-integers-other-than-uint8-t

someone helped me fix this a few weeks back. line30 of slave CPP.
if_cfg.flags= SPI_SLAVE_BIT_LSBFIRST;
it seems to have worked as I've captured a lot of successful transmissions.


feat: adding unit tests for typography component

Description

Typography in AsyncAPI includes 3 main components :

Heading : This component has heading which has props like 'typeStyle' and 'textColor' , and levels , which when we pass to heading when required we can change it accordingly .
Here are the tests I have included for this component :

renders the heading with the default props
renders the heading with custom props

NOTE : For this component I have not included 'data-testids' since testing was required for specific level tag headings and already passed props .

Paragraph :  This component also has some textStyle and textColor Props .
The tests I have included here are as follows :

renders the paragraph with the default props
renders the paragraph with custom props

TextLink : For this component the tests I have included are as follows :

renders a link with the provided props and contentpassed

Related issue(s)
fixes #1792

/rtm


Change ThisAssembly access to Public

We've got an older ASP.Net Web Forms site we're migrating to ASP.Net Core, and along the way we're trying to implement GitInfo. The issue comes in when we go to publish the site, basically, because of the way the ASP.Net precompiler works, access to ThisAssembly is not available from the auto-generated DLLs. It would be nice to have a way to have ThisAssembly switch to public access to avoid these issues.

Dupe of #92.


set status to Idle if paused

"Paused" status is a bit confusing to show on the torrent list, especially since it means something different if on the player view.
This PR changes it to say "Idle" instead, which helps convey the torrent state better and avoids using the same word for two things.
...just floating this PR out as an idea. If its not something we should do go ahead and close it :)
Screenshot:

Also apologies in advance for breaking integration tests :trollface:

How about
[ ] Start

And np the integration tests are already borked :)
I'll update #962 once we decide on a ui

How about [ ] Start

The text next to the checkbox is the current status of the torrent. So, Downloading vs. Idle makes sense. Downloading vs. Start doesn't.
Actions like "Start" belong on buttons (or links), IMO

"Idle" is OK for torrents that have never been started, but doesn't make sense for paused downloads
How about
New torrent, like the default torrents when you first install the app
No label, just the checkbox
[ ]
Downloading
[x] Downloading [===   ] 60% . ...
Paused, not 100% done
[ ] Paused [===   ] 60% . ...
Seeding
No progress bar:
[x] Seeding 100% . ...
Paused, 100% done
[ ] Not seeding 100% . ...

It's a little more complex to implement but I like it @dcposch! Much clearer for the user.

PR here: #963

Thanks @dcposch :)


Buckaroo doesn't display numeric column names, no display

Checks

[X] I have checked that this issue has not already been reported.

[X] I have confirmed this bug exists on the latest version of Buckaroo.

What type of jupyter notebook were you using (VSCode notebook, google colab, Jupyter Lab, Jupyter notebook).  Select multiple if you can reproduce this in multiple environments.  If other, please add to description.
Jupyter Lab
Reproducible example
import pandas as pd
import buckaroo
df = pd.DataFrame([[1,2,3]])
df

Issue description
There is a js error. that prevents any display.  additionally there isn't a python error, this is confusing users.
Expected behavior
Buckaroo should display something.
Installed versions

```
Replace this line with the output of buckaroo.debug_packages(). Leave the backticks in place.
```

Jupyter Log output
No response

Fixed by #325
when a non unique column list is passed in, a DuplicateColumnsException is thrown and an error message is printed.


[SPARK-40350][Kubernetes] Use spark config to configure the parameters of volcano podgroup

What changes were proposed in this pull request?
Use spark config to configure the parameters of volcano podgroup
Why are the changes needed?
If we use spark config to specify the parameters of the podgroup, it will be much more convenient,we don't need configmap to mount static files
In our scenario, we need to dynamically specify the volcano queue, but it is not convenient to create a static podgroup configuration file to mount
Does this PR introduce any user-facing change?
add spark config
spark.kubernetes.scheduler.volcano.podGroup.spec.queue
spark.kubernetes.scheduler.volcano.podGroup.spec.minResources.cpu
spark.kubernetes.scheduler.volcano.podGroup.spec.minResources.memory
spark.kubernetes.scheduler.volcano.podGroup.spec.minMember
spark.kubernetes.scheduler.volcano.podGroup.spec.PriorityClassName

Can one of the admins verify this patch?

I studied your previous discussions, but  i  still think the change i pull request  is  useful，   i   investigative  this  document https://docs.google.com/document/d/1xgQGRpaHQX6-QH_J9YV2C2Dh6RpXefUpLM7KGkzL6Fg/edit#heading=h.1quyr1r2kr5n  ,  i known  spark will  support more  scheduler in the future,   but  the configuration i  add in this pr is just  for   volcano scheduler ,  and the change is  just in the   VolcanoFeatureStep.scala , and the configuration  prefixed with  spark.kubernetes.scheduler.volcano.podGroup ,  not  a  global  spark configuration for  all the  scheduler,
We can arbitrarily create queues in volcano,  and  In our scenario,   we need to dynamically specify the volcano queue，   our users can dynamically use different queues ,   if we must create a  template file Just to dynamically use the queue I created， it is very  inconvenient， i  must add some code to  create a file  or i  must use configmap to mount the  a new template file and restart the k8s  application,     it is no cool,
i  think  the  template file and the configuration is not conflict，

spark driver pod and executor pod can  use  template define  the pod resource,  and spark configuration can override the template file,  I think this usage is reasonable。

@Yikun    @dongjoon-hyun @holdenk

@zheniantoushipashi Much thanks for you feedback. Most of spark + volcano users who I have come into contact with before, they also configure each job through configuration items.
There is no doubt that PodGroupTemplate's mechanism will be greatly improved for generality. Another previous consideration is to reduce the frequent addition of configuration items.
But it is worth noting that PodGroupTemplate is different from PodTemplate: the CRD of Pod has a lot of options, but the CRD of PodGroup, especially the commonly used configurations, is relatively fixed (Therefore, configuration items will not be added frequently). Commonly used are queue, minResource, priority. BTW, please note that minMember is a bit special, because minMember is set to 1 to monitor the driver/job life cycle (see more in https://github.com/volcano-sh/volcano/pull/2038), then to ensure the accuracy of scheduling. Therefore, this parameter should not be set arbitrarily in spark + volcano case.
Therefore, I personally think it is reasonable to use PodGroupTemplate to cover the whole scene, and then increase flexibility through configuration items. But we still need more voice from spark community before this.

Let me close this PR for now. We can continue our discussion on this PR.

@Yikun @dongjoon-hyun   ok,   If in principle we can't wrap volcano's configuration in spark configuration,  then I can only implement this feature in our own version,  Because in our scenario, if the queue used by the scheduler cannot be dynamically configured, the scheduler is basically useless.  You can't imagine a resource manager compared to yarn, which can't dynamically specify queues when starting application

You can't imagine a resource manager compared to yarn, which can't dynamically specify queues when starting application

This is wrong because Apache YuniKorn is able to dynamically specify queues as you see https://github.com/apache/spark/pull/37877 via  the existing Apache Spark labels and annotations without any modification, @zheniantoushipashi .

Because in our scenario, if the queue used by the scheduler cannot be dynamically configured, the scheduler is basically useless.

That doesn't sound like a common valid scenario. If you need to create a queue per a single Spark job, what is the meaning of scheduling?

Let's distinguish creating queues from specifying queues. They are not the same.

sorry,   actually  I mean  specifying queues,   Is there a way to specify a queue dynamically  when using volcano to submit spark  applicaiton ?  do you mean  that we should follow the YuniKorn way to implement the dynamically specified queue of volcano  ?

@dongjoon-hyun


Meta: improve SEO

Improve SEO to rank up in search results from multiple search engines
(old issue #43)

Now our web app has been ranking very well for several months. I'm using the string "simulatore tol" with the 3 major search engines and here are the results:
Google: no 1
Bing: no 1
Yahoo: no 1
That is, without having implemented a robust SEO strategy. I'm going to close this issue, please let me know if you want to proceed differently.


there seems like a bug with docker-machine v0.12.2

i have 3 hosts inited by myself(3 vm and install os manually), hosta is swarm-manager, hostb and hostc are workers. And I want to use "docker-machine create" to init the docker env on hostb and hostc.
All hosts' os are centos7 1611 x64 minimal. In hosta i install docker, the hostb and hostc are only installed net-tools using yum.
I generate rsa file in hosta and make it login to hostb and hostc could without password.
So I use the command:
docker-machine create --driver generic --generic-ip-address=<IP_ADDRESS> --generic-ssh-key /root/.ssh/id_rsa --generic-ssh-user root worker1
but i got the error:
... Provisioning with centos... Copying certs to the local machine directory... Copying certs to the remote machine... Setting Docker configuration on the remote daemon... Checking connection to Docker... Error creating machine: Error checking the host: Error checking and/or regenerating the certs: There was an error validating certificates for host "<IP_ADDRESS>:2376": dial tcp <IP_ADDRESS>:2376: getsockopt: no route to host You can attempt to regenerate them using 'docker-machine regenerate-certs [name]'. Be advised that this will trigger a Docker daemon restart which might stop running containers.
The hostb's 2376 port is avaliable, but it is blocked by firewall, so when i stop the firewall the command was works!
note: net-tools maybe need you install manually, but sometimes it will installed by os automaticlly. I dont know why...

I'm not sure why you believe that is a bug - you acknowledge yourself that the firewall needs to allow traffic on port 2376 for docker-machine to check the installation.


Difference between Linux and Windows

Before submitting the issue

[X] I have checked for Compatibility issues
[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
This simple code returns different output from Linux and Windows :
nodes = np.array([1, 2, 3, 4], dtype=int)
scop_Nodes = dpf.mesh_scoping_factory.nodal_scoping(nodes)
print(scop_Nodes.ids)
It seems to come from the type int (int32/int64).
Would it be possible to fix the ouput in Linux or document the behaviour?
Steps To Reproduce
-Run the following code in Windows then in Linux :
nodes = np.array([1, 2, 3, 4], dtype=int)
scop_Nodes = dpf.mesh_scoping_factory.nodal_scoping(nodes)
print(scop_Nodes.ids)
Which Operating System causes the issue?
Linux
Which DPF/Ansys version are you using?
Ansys 2024 R1
Which Python version causes the issue?
3.8
Installed packages
ansys-dpf-core
ansys-dpf-post

Hello @CCHEMAI,
COuld you please let me know which version of ansys-dpf-core and ansys-dpf-post you have installed?


Monitoring dashboard

After this patch we will get the following dashboard

Please Add Scylla Manager header, making it clearer to the user
Can you add a capture with an actual running repair? it's hard to understand how this will look like

It does contain the manager header as the dashboard name I just cut a too small part of the screen.

Add a per cluster, per repair progress:
We need to add a progress bar for running repair:
Total: total segment to repair
Progress: how many segments were repaired, how long it took
Left: number of the segment, estimated time to completion


Update syntax to support zero scaling

Purpose

Update syntax to support zero scaling

Codecov Report

Merging #403 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #403   +/-   ##
======================================
  Coverage    82.6%   82.6%
======================================
  Files          29      29
  Lines         776     776
  Branches       54      54
======================================
  Hits          641     641
  Misses         95      95
  Partials       40      40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c99b15...19b9a77. Read the comment docs.


Add provider to file output

Adds the provider name to the file output. For example:
INFO OpenShift file "frontend-service.yaml" created
INFO OpenShift file "redis-master-service.yaml" created
INFO OpenShift file "redis-slave-service.yaml" created
INFO OpenShift file "frontend-deploymentconfig.yaml" created
INFO OpenShift file "frontend-imagestream.yaml" created
INFO OpenShift file "redis-master-deploymentconfig.yaml" created
INFO OpenShift file "redis-master-imagestream.yaml" created
INFO OpenShift file "redis-slave-deploymentconfig.yaml" created
INFO OpenShift file "redis-slave-imagestream.yaml" created

@cdrage code LGTM, also you will have to update the docs!

@surajssd Will do once this is merged! :)
@surajnarwade @kadel please review!


Retry downloads that fail on copying from S3

This PR bumps github.com/pivotal-cf/go-pivnet to v0.0.32 (ed7e2b7f78c9c367eb8bf96c1972466de21f61cb) and handles the returned retryable boolean from ExtendedClient#DownloadFile, attempting a maximum of three downloads if failures are retryable.
This is in response to https://github.com/pivotal-cf/pivnet-resource/issues/38.
NB: The final commit of this PR changes acceptance/lifecycle_test.go to remove the product_files prefixing of the S3_FILEPATH_PREFIX set for acceptance tests. This may break CI if product_files is not automatically prepended to s3 filepath prefixes.

Have you made this pull request to the develop branch?
Yes.

Yes.

capturing an offline conversation here: we agreed that we would not expose retryablefrom go-pivnet; instead callers will inspect the error and decide if they should retry
see also https://github.com/pivotal-cf/pivnet-cli/pull/2

@crawsible Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@crawsible I'm going to close this as it will probably be easier to start again than to add more commits here. See also pivotal-cf/pivnet-cli#2


Allow users to rename private/unpublished lists.

Fixes
Issue Number: https://github.com/lbryio/lbry-desktop/issues/6257

What is the current behavior?
Users can't rename private/unpublished lists.
What is the new behavior?
Users can rename private/unpublished lists.

Other information

PR Checklist

Toggle...
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[ ] I added a line describing my change to CHANGELOG.md
[x] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

Code looks good, but it's hard to use our bulky existing styles here. The real answer here is a large style refactor. Short term could be a new slim style. I can take a look soon.

Testing it some more, I think there isn't room for the rename on the card and it is best to do it on the edit page.
After you get it working on "view list" page, let me know and I'll adjust the styles if you like.


Fixed constructor to work without app context

In some configurations, extension object is constructed while there is no current application yet.
Without this fix, this extension doesn't support such setups.

✨🍰✨

sorry for the delay — you'd be shocked at how crazy my github notifications are.

also, added you as a collaborator. If you want to send me your pypi name, you can make releases too!

@kennethreitz great that you merged it. As for collaborating - I am currently not actively using this plugin but when I will then I'll try to help you with it. My pypi name is MarSoft.


Scanning is not possible due to a Python Index Error.

Describe the bug
Scanning is not possible due to a Python Index Error.
To Reproduce
Steps to reproduce the behavior:

Run to tern report
See error

Error in terminal
I use docker/Dockerfile
$ sudo docker run --rm ternd report -i debian:buster
2022-01-12 10:29:40,320 - DEBUG - __main__ - Starting...
2022-01-12 10:29:40,320 - DEBUG - prep - Setting up...
2022-01-12 10:29:40,321 - DEBUG - rootfs - Running command: chmod +x /usr/local/lib/python3.9/site-packages/tern/tools/fs_hash.sh
2022-01-12 10:29:40,330 - DEBUG - run - Starting analysis...
2022-01-12 10:29:40,331 - DEBUG - skopeo - Attempting to pull image "debian:buster"
2022-01-12 10:29:40,331 - DEBUG - rootfs - Running command: skopeo copy docker://debian:buster dir:/root/.tern/temp
2022-01-12 10:29:47,038 - DEBUG - rootfs - Running command: tar -tf /root/.tern/temp/9b99af5931b39ce167150ad668cfa57ddf7664697be9996cb7e0e6aebbf05843
2022-01-12 10:29:48,636 - DEBUG - rootfs - Running command: tar -x -f /root/.tern/temp/9b99af5931b39ce167150ad668cfa57ddf7664697be9996cb7e0e6aebbf05843 -C /root/.tern/temp/1/contents
2022-01-12 10:29:51,157 - DEBUG - rootfs - Running command: /usr/local/lib/python3.9/site-packages/tern/tools/fs_hash.sh /root/.tern/temp/1/contents
2022-01-12 10:30:08,674 - DEBUG - common - Reading files in filesystem...
Traceback (most recent call last):
  File "/usr/local/bin/tern", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.9/site-packages/tern/__main__.py", line 286, in main
    do_main(args)
  File "/usr/local/lib/python3.9/site-packages/tern/__main__.py", line 116, in do_main
    crun.execute_image(args)
  File "/usr/local/lib/python3.9/site-packages/tern/analyze/default/container/run.py", line 80, in execute_image
    cimage.analyze(full_image, args)
  File "/usr/local/lib/python3.9/site-packages/tern/analyze/default/container/image.py", line 81, in analyze
    default_analyze(image_obj, options)
  File "/usr/local/lib/python3.9/site-packages/tern/analyze/default/container/image.py", line 67, in default_analyze
    prereqs = single_layer.analyze_first_layer(image_obj, master_list, options)
  File "/usr/local/lib/python3.9/site-packages/tern/analyze/default/container/single_layer.py", line 148, in analyze_first_layer
    if not com.load_from_cache(image_obj.layers[0], options.redo):
  File "/usr/local/lib/python3.9/site-packages/tern/analyze/common.py", line 77, in load_from_cache
    layer.add_files()
  File "/usr/local/lib/python3.9/site-packages/tern/classes/image_layer.py", line 353, in add_files
    file_data = FileData(os.path.basename(file_info[2]),
IndexError: list index out of range

Expected behavior
https://github.com/tern-tools/tern/blob/723f43dcaae2f2f0a08a63e5e8de3938031a386e/tern/classes/image_layer.py#L349-L360
It is expected that only the format permissions|uid|gid|size|hard links|  sha256sum  filepath will be included in line.
But it actually has a different format.
Below is the result of print(line).
-rw-r--r--|0|0|498|1|  9d1817f3f797fbf564bf1a17d3de905a8cfc3ecd101d4004c482c263fecf9dc3  ./usr/local/lib/python3.10/site-packages/pip/_vendor/urllib3/util/queue.py

# file: usr/local/lib/python3.10/site-packages/pip/_vendor/urllib3/util/queue.py

security.selinux="system_u:object_r:container_share_t:s0"

-rw-r--r--|0|0|4123|1|  367cda10a4353dabb0e4c14c57a1e68043072137f402e6bd7d0bb38b6b99cc67  ./usr/local/lib/python3.10/site-packages/pip/_vendor/urllib3/util/request.py

# file: usr/local/lib/python3.10/site-packages/pip/_vendor/urllib3/util/request.py

security.selinux="system_u:object_r:container_share_t:s0"

The extra output is due to getfattr. (https://github.com/tern-tools/tern/blob/main/tern/tools/fs_hash.sh#L23)
You need to either remove getfattr (I don't know if you can remove it!) or restore the regex compiling that you deleted in
1551162c3f89a1edcb0c72e6d9a568ad1128d730 .
Environment you are running Tern on
Enter all that apply

Output of 'tern --version'

$ sudo docker run --rm ternd -v
Tern version 2.9.0
   python version = 3.9.9 (main, Dec 21 2021, 10:35:05)

Operating System (Linux Distro and version or Mac or Windows)

$ cat /etc/redhat-release
CentOS Linux release 7.9.2009 (Core)

Vagrant file No
Container OS python:3.9-slim-buster (docker/Dockerfile)
Python version (3.6 or higher) 3.9.9
Cloud environment (AWS, Azure, GCP) No

OK, I'm able to reproduce on a CentOS Vagrant Box. I get what you're saying now. I will submit a fix shortly.


redlense2.qml & vertexShader

I have commented out the vertexShader completely, and nothing has been changed. Do we really need it for this case?

In the first effect (effect1) our fragment shader does not need the texture information. Se we can modify the default shader to remove the texture information. This is more an optimization and only works because we fully red paint the color. But yeah, this is not really require and should not be in a introduction  chapter.


Add an internal-tests run-privileged-integration

status: Don't error out if not booted
For now, just print out nothing.  This helps a future integration
testing scenario.

Add an internal-tests run-privileged-integration
Add a feature to enable internal tests.  I originally started
by matching
https://github.com/ostreedev/ostree-rs-ext/commit/6543c855580da3a3f2a85bc8b4a294b4c92c2829
but since here the binary is really end user facing and not just
a demo, we shouldn't enable the feature by default.
If in the future we split off the tiny CLI bit out of the workspace,
then we could auto-enable but that seems not worth it.

/approve

/retest

Hmm, need to do some tweaks to the Prow config here; I don't think we want to use approve/lgtm, just CI tests.  (But this is obviously subject to a larger debate for consistency inside the containers/ GH org)


Fix linter warnings in no-vars.js

I noticed these warnings while running tests locally.

thanks. Should probably make eslint throw on travis..

Even if it throws, these were just warnings so it might not have thrown in this case.

I think you can error on warnings, right? :)

I think if you only have warnings, eslint will use an exit code of 0, which I think Travis will not fail on. You probably want to tell eslint to use errors instead of warnings for the things you care to enforce at CI.


docs: remove unnecessary version of express-generator

This was added because a lot of folks copy what is in the README into sites and books. When 4.x came out lots of things broke because there wasn't a version specifier. This was added from community feedback.

got it :)


Download passwords

This just downloads password hashes, not the passwords themselves. I'm trying to find the passwords that were used to generate these hashes. Are the passwords available for download somewhere? Calling this a PasswordDownloader is misleading.

You can't download the plain text passwords, here's why: https://www.troyhunt.com/understanding-have-i-been-pwneds-use-of-sha-1-and-k-anonymity/

@tire-fire download Collections #1-5 as a starting point if you want plain-text passwords and user/password dumps for data analysis and machine learning training. You can use https://github.com/p3pperp0tts/leaks_parser to deduplicate and consolidate them. Note, you will need at least a 500GB drive.

I see, I think you can't share the password lists that you have because hackers are bad at parsing and you can't trust them not to have PII in their data. This is done at the risk of having false positives which may happen in the form of hash collisions with non-password data.

It's not just parsing, some people deliberately put PII in their passwords. Hash collisions are practically impossible; of the more than 500M passwords loaded into HIBP before the ingestion pipeline was launched, no 2 hashes collided. With 16^40 different possible SHA-1 hashes and less than 1B passwords, it is for all intents and purposes near impossible to have a collision. If a collision occurs because a password is tested that results in the same hash already in the system, the impact of the false positive is merely that someone is told a password has been seen before when, in fact, it hasn't.
In summary, there is an infinitesimally small chance of a collision and the impact if that happens is of absolutely no consequence.

Thanks, but I still suggest a rename to PasswordHashDownloader, because there are no passwords downloaded by this software.

There are passwords downloaded. They’re stored as hashes. There’s so much extensive information out there about precisely how this service works, this is honestly the first time we’ve had this suggestion.

Maybe I'm alone in this thinking, but I would say that storing something in an unrecoverable format isn't a storage mechanism for the thing. So I would say there are no passwords downloaded, probably as a feature that you intended.
I apologize as I've never used this service before, but I was looking for a list of actual passwords and a PwnedPasswordDownloader sounds like it would fit what I was looking for. And I see now that the README says that it is just hashes that are downloaded.

And I see now that the README says that it is just hashes that are downloaded.

😊


fix type of replica-interface-name flag to string

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 63.672%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
801

Relevant Lines:
1258

💛  - Coveralls

@minchao Thank you very much for the fix


Problem with test case 2E

We have noticed that test case 2E is failing if we include our internal test code in addition to the LOINC code 14928-6. See message ID 4252 on the FHIR test server. Could you please fix the test condition?

@frederic-istace ,
the rule is modified and your latest message for 2E is reprocessed.


the RGBA values not correct while hover to image

it happens on Windows

Hum, this seems like a bug in ImGuiTexInspect
The code for this demo is simple calling ImGuiTexInspect::ShowDemoWindow, see below:
int main(int, char **)
{
    HelloImGui::SetAssetsFolder(DemosAssetsFolder());
    HelloImGui::SimpleRunnerParams runnerParams{.guiFunction = ImGuiTexInspect::ShowDemoWindow, .windowSize={1000, 1000}};
    ImmApp::AddOnsParams addOnsParams;
    addOnsParams.withTexInspect = true;
    ImmApp::Run(runnerParams, addOnsParams);
    return 0;
}

If you need to inspect pixel values, I advise you to use ImmVision instead. See ImmVision tab in the demo

Hello Andy,
This issue is fixed in https://github.com/pthom/imgui_bundle/issues/211. It was due to using a reduced demo image size (to save space for the emscripten demos).


extend config options to pagefind

Description

Closes #1364
This PR exposes astro config options to Pagefind UI to correctly format search result

size-limit report 📦

Path
Size

/index.html
5.26 KB (+1.04% 🔺)

/_astro/*.js
21.78 KB (+1.69% 🔺)

/_astro/*.css
13.05 KB (0%)

Should we add tests for this new striptrailingslash? I tested locally a few searchs. The only instance where it didn't work was when referencing an id #_top in the landing page. it strips the slash but chrome (I think) automatically adds it back because we are in the / page.


Build Docker container in Travis CI

@michelp Travis now builds the minimal Docker container from scratch.
Related to (but does not completely fix) #52.


Generalize HF datasets to a collection of HF datasets via hf_datasets

To support the following dataset configuration:
hf_datasets:
  - hf_dataset:
        name: "Open-Orca/OpenOrca"
        train_split: "train[:90%]"
        valid_split: "train[-10%:]"
        prompt_feature: "question"
        completion_feature: "response"
  - hf_dataset:
        name: "trl-lib/ultrafeedback_binarized"
        train_split: "train[:90%]"
        valid_split: "train[-10%:]"
        chat_feature: "chosen"

adding support for custom chat HF datasets (addressing #1088 and relevant for #513) and fixing (#1087)

Superseded by #1103

Superseded by #1103


Let _.bindAll accept an array of method names

So _.bindAll(moe, 'getName', 'sayHi'); would become equivalent to _.bindAll(moe,['getName','sayHi']);.
This is helpful in cases when method names are being dynamically generated or only need to be bound based on some criteria.

Nope -- most functions in JS that accept multiple arguments are also useful to call with arrays -- use JS' built-in .apply.

Right. Thanks.


Optimizing pagination

Hi,
As many of us, i can not really afford the full search on all the record before the pagination. Too much time spent in join and so on.
So basically i created a first query to get the total of record (skipping all order and some joins).
Then i make a limited search for the current chunck (draw).
All the query part works well, but  when i send the collection to Database::of, i can not find any way to overwrite the start parameter of the request. So far, it results in database returning empty data for every draw bigger than one.
It is similar to issue412, but i m still missing some part.
My code looks like this
$allInvoicesQuery = Invoice::
           join('contacts', 'contacts.id', '=', 'invoices.contact_id')
           ->join('customers', 'customers.id', '=', 'invoices.customer_id')
           ->more joins

       /** Filters */
       if (isset($searches['customer_id']) && $searches['customer_id'] > 0) {
           $allInvoicesQuery->where('invoices.customer_id', $searches['customer_id']);
       }

       /** @var optimized count before full query $allInvoicesQueryCount */
       $allInvoicesQueryCount = $allInvoicesQuery;
       $allInvoicesQueryCount = $allInvoicesQueryCount->count();

       if ($allInvoicesQueryCount > 0) {
           $allInvoicesQuery->select([
               '..my fields',
           ])
           ->skip($request->start)->take($request->length) // my chunk
           ->orderBy('invoices.created_at', 'DESC');
           $allInvoices = $allInvoicesQuery->get();

           $originalStart = $request->start;
           $request->merge( [ 'start' => 0 ] );

           $dataTable = Datatables::of($allInvoices)
               ->filter(function ($query) use ($request) {
                  $request->merge(['start' => 0]);
               })
               ->with([
                   'recordsTotal' => $allInvoicesQueryCount,
                   'recordsFiltered' => $allInvoicesQueryCount,
               ])
               ->make(true);

I do get that the DataBase is working with the original Request object but still, somehow, i should be able to overwrite this. As if i force the start value  to be 0 in the CollectionEngine::paging() function, Everythinf works as expected.
Thx for any tips

@hairmenu, I think you are using a wrong request instance. Datatables has it's own request instance that you should use. You may try using IoC or method injection to get the DT instance first then get the Request instance like on this demo.
    $datatables = app('datatables');
    $request = $datatables->getRequest();
    // do your request override and other stuffs.
    return $datatables->collection($invoices)->make(true);

Yup this totally made my day thx.


Improved Japanese translation.

Improved the Japanese translation. Some strings are still a bit too long for the UI, which could be fixed by using more kanji and fewer loanwords (which tend to be used on similar devices).

Great - thank you!


No Error or warning, but highlighted unrecognized component

System:
VS Code v1.64.2
Volar Extension v0.31.2

My custom component (Drawer) is shown in red as follows:

When I tried your volar-starter repo, I am getting the same behavior (With HelloWorld component):

Do you know what is the problem?

Could you show the code of the Drawer component?

When I tried your volar-starter repo, I am getting the same behavior (With HelloWorld component):

Please make sure you have install node_modules after clone the repo.

Thanks, I totally forgot to do npm install on volar-starter.
After comparing the two projects, the following caused the component to be labeled in red:
"useDefineForClassFields": false,
in tsconfig.json.


SAK-40209 add category statistics popup to GBNG

Added Category statistics popup in a dropdown menu on category columns

This is great, but I'm going to put a hold on it for the time being. I am making an update to the stats panels so that they can be shared across assignment/coursegrade and now categories. So bear with me then you should be able to throw a DescriptiveStatistics object at it and it will render.

Sounds good. I'll keep an eye out for it-- thanks!

#5736 contains the framework for this. Extend org.sakaiproject.gradebook.tool.stats.BaseStatistics and drop it into a modalwindow (like the AssignmentStatisticsPanel does). You can add additional markup to the panel as well (see CourseGradeStatistics). Let me know if you have any questions. Cheers.


artifactory role fails when run twice due to stopping artifactory service

Is this a request for help?:
No
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

Which installer:
Ansible
Which product and version (eg: ansible & collection version - 7.24.2):

ansible [core 2.14.6]
community.general 7.1.0
jfrog.platform 10.13.2

Which operating system and version(eg: ubuntu & version - 20.4):
Ubuntu 20.04
Which product license (Enterprise/Pro):
N/A
JFrog support reference (if already raised with support team):
What happened:
The artifactory service does not start if running a playbook a second time with the artifactory role, causing the "Make sure artifactory is up and running" task to fail. This makes the artifactory role non-idempotent.
This is due to the "Install Service" task running the second time the playbook runs (even though the service is already installed). Thus, the artifactory service is stopped if it is already running and there is no handler setup to start/restart the artifactory service in this scenario.
What you expected to happen:
I expect the artifactory role to be idempotent, so running a playbook with it a second time, if artifactory is already installed, to do no changes and the final task of the role to execute successfully.
How to reproduce it (as minimally and precisely as possible):
Run a playbook with the artifactory role twice. The first run will succeed, and the second run will fail on the "Make sure artifactory is up and running" task because the artifactory service has now stopped and has not been restarted. Worth noting is that the "Restart artifactory" tasks runs to flush all handlers, but this does nothing and does not start the service.
Anything else we need to know:
Optimal resolution: If the service is already installed, do not run the "Install Service" task to install the service since this will stop the service if its already running.

@PolaricEntropy Thanks for the issue , Let me investigate  this , Mean while is it possible for you a raise a PR with tentative fix , Happy to review it


Nebular Dialog Help

Issue type
I'm submitting a ...  (check one with "x")

[ ] bug report
[x] feature request
[ ] question about the decisions made in the repository

Issue description
Current behavior:

Are there any examples or steps for integrating the new Nebular NbDialogModule component into the admin template?  Perhaps an example/demo added to Menu List or under UI-Features category?
Expected behavior:

Attempting to import the -- Dialog "Name" Example on the Akveo Nebular example site into a Dashboard or Card.  Everything else is working great!
Steps to reproduce:

Related code:

insert short code snippets here

Other information:
npm, node, OS, Browser
<!--
Node, npm: `node --version` and `npm --version`
OS: Windows (7/8/10). Linux (incl. distribution). macOS (El Capitan? Sierra?)
Browser: Chrome/Safari/Firefox/etc?
-->

Angular, Nebular
<!--
Check your `package-lock.json` or locate a `package.json` in the `node_modules` folder.
-->

Hi @CaptnCrunchCode. See working examples and install guide for all nebular components in docs. You can find the code behind every example, by clicking <> button on the top right.


Set correct version numbers in assemblys from nuget.org

Expected Behavior
provided assembly's should contain the version number of the nuget package
Actual Behavior
WPFHexaEditor.dll version information shows <IP_ADDRESS> for all versions from nuget.org
Steps to Reproduce the Problem
View the version information of the assembly from explorer

Yes ! I will do on next nuget release
Thank for this info :)


Staging Mac bots are Dead for days

mac-10 is ssh'able.

Bots have been recovered. They required reboots or manually starting the swarming service.


Add as an option the data directory for cassandra like (eg: scylla)

@DeviaVir it's ok for you for this PR ?

great :)
Do you have an ETA to generate a new release ?


refactor traits for dependencies

Right now, stan::math fundamentally depends on stan/meta/traits.hpp, which brings in all of agrad::var and all of agrad::fvar.
We want to break this apart so that there's a base meta that doesn't depend on anything in agrad or Eigen or whatever.  And then have separate traits files within agrad/fwd and agrad/rev

This was fixed with the math refactor.


Update von-network related references.

Clarify the use of the Running the Network Locally instructions for demos and development.

Signed-off-by: Wade Barnes<EMAIL_ADDRESS>

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   70.67%   70.67%
=======================================
  Files         176      176
  Lines        7400     7400
=======================================
  Hits         5230     5230
  Misses       2170     2170


T3, R5, R5D, Z1D pricing shows 'unavailable'

I'm not sure why pricing for these specific new instance types are not available?  They're on the same AWS page as all the other instance types: https://aws.amazon.com/ec2/pricing/on-demand/

The pricing data comes from another source which is no longer being updated. Please follow #367 for more info. Thanks


Editor metadata ignored

It seems like currently the editor metadata is ignored when included in the metadata file.
The passed values are
editor:
  github_user: "xuanxu"
  name: Juanjo Bazán
  url: https://juanjobazan.com
  orcid: 0000-0001-7699-3983

sometimes all of the values will be null or empty (when compiling a draft before the review has an editor assigned), sometimes some of them will be null or empty (when editor has not provide url or orcid)

I made a few changes and uploaded a new image; PDF output should be fixed; JATS still pending.


Add Vyper compilation

Progresses https://github.com/EthWorks/Waffle/issues/206
I think next steps could be:

Add more .vy contracts for more solid tests, including library linking
Possibly rewrite to vyper all current .sol contracts like One.sol or Two.sol and then merge e2e.ts and e2e_vyper.ts together?

@sz-piotr Will you find a moment to look at this?

Missing readme and documentation

Readme and docs are missing on purpose - we don't want to announce this feature just yet, keep it experimental to easily do breaking changes if needed.
@sz-piotr Agree?

Closing, continue in #222


Define Ruby capabilities

Expected result
Have the section in the official KenticoCloud documentation (as it is for i.e. PHP)
Additional context
We would like to have the section filled for the Ruby SDK.
We need information/links to the page:

Link to the repository
Link to the package in package manager (gem)
Links to the documentation (readme) to be able to fill Supported features
Provide the link to the sample application
Provide link(s) to the blog post about the Ruby

Feature
Availability
Documentation

Retrieve content items
✔
View docs

Secure access
✔
View docs

✔
View docs

✔
View docs

✔
View docs

✔
View docs

✔
View docs

✔
View docs

✔
View docs

Feature
Availability
Documentation

Retrieve content items
✔
View docs

Secure access
✔
View docs

Preview unpublished content items
✔
View docs

Filter content items
✔
View docs

Localization
✔
View docs

Retrieve linked items and items in Rich text
✔
View docs

Retrieve content as strongly-typed models

Render components and items in Rich text
✔
View docs

Resolve links to content items in Rich text
✔
View docs

Retrieve taxonomy groups
✔
View docs

Custom elements
✔

Webhook support
✔

Not sure what "Custom elements" support should look like, but if it means you can request a custom element using https://github.com/Kentico/delivery-sdk-ruby#retreiveing-content-type-elements then it should work fine.

ability to retrieve data from custom elements (some SDKs were crashing when we added custom elements to the API)

Just add the note that Custom elements are supported to the Readme. And then link it to the table.
Thanks @kentico-ericd!

@Simply007 👍 done!

Awesome!
After it is closed, I think it is the time for 1.0.0 release - what do you think @kentico-ericd ?


Editing string content while maintaining formatting

Is there a way to change the content of a string and carry over the formatting?
For example, a user types in "hello world" into the editor but wherever the string "world" appears (regardless of formatting or casing) I'd like to replace with "Earth". So the desired text would look like "hello Earth" which maintains the bold and italics. I've figured out a way to replace the text but wondering if there's a way to get and apply the formatting/attributes to the new string? Perhaps I need to access the formatting file that's saved for the previous string and grab the attributes to apply to my updated string?
Thanks!

Can you grab the formatted string and paste it in its formatted form into the string?

I'm not sure I follow, maybe I'm just going about this the wrong way.
My initial attempt is to use a state variable called "text" to store the original string that's typed into the editor. Then, I update the "text" variable by using the ".replacingOccurences" method on the string, but doing this loses the formatting that was applied to the original string.
So my code looks something like this:
@State var text: NSAttributedString
text = NSAttributedString(string: text.string.replacingOccurrences(of: "world", with: "Earth"))
Is your solution something that would be done directly in the code or just a procedure that the user would perform in the text editor?

Oh, yes. In your code, you use text.string which gives you the raw string without formatting, then replace the occurrences, then create a new attributed string, which will then be based on the raw string that has no formatting.

I see, thanks for the explanation on that. Is there an alternative method to achieve the string replacement while maintaining the original formatting then?

I think you need to use an NSMutableAttributedString:
var nonMutable = NSAttributedString(string: "")
var mutable = NSMutableAttributedString(nonMutable)
b.replaceCharacters(in: <#T##NSRange#>, with: <#T##String#>)

Hmm that doesn't seem to work either. I run into errors that disallow casting variables from "NSAttributedString" to "NSMutableAttributedString". Are there any other methods you are aware of that could be worth trying?


Automatically add branch protection rule

It will be very useful, when configure the CLA for a repository, if it will add/update automatically the master branch protection rule and configure the status checks to pass before merging, as required.

@glucaci thank you for your proposal. Indeed some repository owners consider CLA as a mandatory requirement for taking over change proposals. But this is not the case for all users of CLA assistant. There are many of them, who prefer to be able to ignore CLA assistants check status and merge PRs despite unsigned CLA. Therefore I'd prefer to keep it optional

Optional is also good, but will be nice to can specify this option when the repository is linked with the CLA-Assistant.


Forms: Introduce new ignoreRecord argument for searchable selects

I think this is common enough in applications to add first-party support for it – save some lines of code and tidy things up a little.
When dealing with recursive relationships, e.g. Page in a CMS might be the child of another Page via a parent_id column, you quite often want to prevent selecting the current record as the parent.
The new ignoreRecord argument handles this for you by simply excluding the current record from the result set, saving yourself some lines of code that you'd normally write to do this via modifyQueryUsing.

I think its nice, but I don't like the fact that we're introducing a new argument into an already crowded method signature

I think its nice, but I don't like the fact that we're introducing a new argument into an already crowded method signature

Tell that to the unique() method!

Yeah... can you add some docs for this?

Yep, will do this afternoon.

@danharrin Docs updated.


Support for NetBox 3.5.4?

Support for NetBox 3.5.4?  I was getting an error when upgrading NetBox today to 3.5.4
It failed 2x, until I removed this from PLUGINS in the configuration.py for NetBox.
Applying database migrations (python3 netbox/manage.py migrate)...
Traceback (most recent call last):
  File "netbox/manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/core/management/__init__.py", line 446, in execute_from_command_line
    utility.execute()
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/core/management/__init__.py", line 440, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/core/management/base.py", line 402, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/core/management/base.py", line 448, in execute
    output = self.handle(*args, **options)
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/core/management/base.py", line 96, in wrapped
    res = handle_func(*args, **kwargs)
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/core/management/commands/migrate.py", line 97, in handle
    self.check(databases=[database])
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/core/management/base.py", line 475, in check
    all_issues = checks.run_checks(
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/core/checks/registry.py", line 88, in run_checks
    new_errors = check(app_configs=app_configs, databases=databases)
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/core/checks/urls.py", line 14, in check_url_config
    return check_resolver(resolver)
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/core/checks/urls.py", line 24, in check_resolver
    return check_method()
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/urls/resolvers.py", line 494, in check
    for pattern in self.url_patterns:
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/utils/functional.py", line 57, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/urls/resolvers.py", line 715, in url_patterns
    patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/utils/functional.py", line 57, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/urls/resolvers.py", line 708, in urlconf_module
    return import_module(self.urlconf_name)
  File "/usr/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 848, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/ebay/home/ebay/netbox/netbox/netbox/urls.py", line 8, in <module>
    from extras.plugins.urls import plugin_admin_patterns, plugin_patterns, plugin_api_patterns
  File "/ebay/home/ebay/netbox/netbox/extras/plugins/urls.py", line 31, in <module>
    urlpatterns = import_string(f"{plugin_path}.urls.urlpatterns")
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/utils/module_loading.py", line 30, in import_string
    return cached_import(module_path, class_name)
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/django/utils/module_loading.py", line 15, in cached_import
    module = import_module(module_path)
  File "/usr/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/netbox_kea/urls.py", line 4, in <module>
    from . import views
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/netbox_kea/views.py", line 17, in <module>
    from . import constants, forms, tables
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/netbox_kea/forms.py", line 12, in <module>
    from .utilities import is_hex_string
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/netbox_kea/utilities.py", line 83, in <module>
    class OptionalViewTab(ViewTab):
  File "/ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/netbox_kea/utilities.py", line 84, in OptionalViewTab
    def __init__(self, *args, is_enabled: Callable[[Any], bool], **kwargs) -> None:
TypeError: 'ABCMeta' object is not subscriptable

Did it work on NetBox v3.5.3 for you?
Could you try making the following changes to /ebay/home/ebay/netbox/venv/lib/python3.8/site-packages/netbox_kea/utilities.py:
-from collections.abc import Callable
 from datetime import datetime
-from typing import Any, Dict, List, Literal, Optional
+from typing import Any, Callable, Dict, List, Literal, Optional

 from django.http import HttpResponse
 from django.shortcuts import redirect

Your suggestion worked perfectly and so is the plugin!  Nice work and thanks for sharing!

one other thing, I think your command is not correct and should be
sudo ./manage.py migrate

would it also be possible to report on pool info and utilization for a given subnet?

server.dhcp4.statistic_get('subnet[1019156019].total-addresses')

KeaResponse(result=0, text=None, arguments={'subnet[1019156019].total-addresses': [[29, '2023-06-07 12:24:17.224493']]})

server.dhcp4.statistic_get('subnet[1019156019].assigned-addresses')

KeaResponse(result=0, text=None, arguments={'subnet[1019156019].assigned-addresses': [[12, '2023-06-07 12:47:29.204784'], [11, '2023-06-07 12:35:42.945926'], [10, '2023-06-07 12:34:32.895585'], [9, '2023-06-07 12:34:31.810025'], [8, '2023-06-07 12:34:30.858006'], [7, '2023-06-07 12:34:30.410463'], [6, '2023-06-07 12:34:08.498306'], [5, '2023-06-07 12:34:08.120871'], [4, '2023-06-07 12:34:03.850084'], [3, '2023-06-07 12:32:41.549737'], [2, '2023-06-07 12:32:39.650907'], [1, '2023-06-07 12:32:15.823833'], [0, '2023-06-07 12:24:17.224847']]})

pool info seems to be available with this call
test = server.dhcp4.cached_config
print(test['Dhcp4']['shared-networks'][0]['subnet4'][0]['pools'][0]['pool'])

<IP_ADDRESS>-<IP_ADDRESS>

Your suggestion worked perfectly and so is the plugin! Nice work and thanks for sharing!

Great! I've published v0.1.1 with the change so you can update to that.

one other thing, I think your command is not correct and should be

Fixed.

would it also be possible to report on pool info and utilization for a given subnet?

I think this is a good use case for Stork. I'm hesitant to implement this feature because Kea doesn't have a proper API to get pool/subnet information. Currently this plugin just uses config-get to get the list of subnets which may be expensive, (I haven't actually confirmed this myself). None the less, getting the configuration just to get the list of configured subnets/pools doesn't seem like a very good approach.

it appears that our company paid for the premium API support so we can make the direct API calls to pull subnet info
network = server.dhcp4.network4_get('sjc-lab-33-ztp-data')

print(network.name)
print(network.subnet4[0].subnet)
print(network.subnet4[0].pools[0].pool)

sjc-lab-33-ztp-data
<IP_ADDRESS>/26
<IP_ADDRESS>-<IP_ADDRESS>

FYI, I'm using this new wrapper
https://github.com/BSpendlove/pykeadhcp/blob/main/COMMANDS.md

One last question, I'm not seeing anything for DHCP Subnets.....curious if I'm missing something basic as I'm new to KEA.

The DHCP Leases is working great.

subnets_v4 = server.dhcp4.subnet4_list()

for i in subnets_v4:
    print(str(i.id).ljust(12), i.subnet )

416769625    <IP_ADDRESS>/25
440383492    <IP_ADDRESS>/26
593730608    <IP_ADDRESS>/28
602504513    <IP_ADDRESS>/25
605481152    <IP_ADDRESS>/28
830827846    <IP_ADDRESS>/26
1019156019   <IP_ADDRESS>/27
1818034871   <IP_ADDRESS>/25
1986588591   <IP_ADDRESS>/27
2086002595   <IP_ADDRESS>/26
2149123380   <IP_ADDRESS>/26
2192260479   <IP_ADDRESS>/26
2419609915   <IP_ADDRESS>/26
2444456677   <IP_ADDRESS>/27
2494219477   <IP_ADDRESS>/25
2541440121   <IP_ADDRESS>/25
2554840638   <IP_ADDRESS>/25
2910585232   <IP_ADDRESS>/26
2940872388   <IP_ADDRESS>/26
3013529256   <IP_ADDRESS>/26
3035992152   <IP_ADDRESS>/26
3179841559   <IP_ADDRESS>/27
3185248078   <IP_ADDRESS>/27
3436875955   <IP_ADDRESS>/25
3452549073   <IP_ADDRESS>/26
3473610783   <IP_ADDRESS>/25
3591900418   <IP_ADDRESS>/28
3784171495   <IP_ADDRESS>/27
3794378056   <IP_ADDRESS>/28
3801781281   <IP_ADDRESS>/26
3972899536   <IP_ADDRESS>/25
4030412670   <IP_ADDRESS>/26
4144329181   <IP_ADDRESS>/27
4179960509   <IP_ADDRESS>/26

Stork looks pretty cool but might be overkill for my needs, I already have so many tools setup :)

it appears that our company paid for the premium API support so we can make the direct API calls to pull subnet info.

I don't have access to that hook library so this plugin just pulls the list of subnets from the config.

One last question, I'm not seeing anything for DHCP Subnets.....curious if I'm missing something basic as I'm new to KEA.

Are you using a database to store your subnets? If so, this plugin grabs the lists of subnets from config-get so the subnets might not be in the configuration. I've only tested this plugin with subnets configured in the JSON config file.

Here you can see the DHCP info is available via the python calls.

It looks like this command uses the subnet4-list command (which is from the hook library).

Stork looks pretty cool but might be overkill for my needs, I already have so many tools setup :)

Yeah it does have quite a bit of functionality, mainly around monitoring.

KEA was setup using the databases for config, host and lease information AFAIK, I'm still learning this on the fly and did not set it all up myself, but we don't seem to have a configuration file we can edit like we did with the old DHCP server.
That said, The subnets do show in the configuration, but they were configured in "shared-networks".
'shared-networks': [{'name': 'sjc-ctlab-03-r208-mgmt1',
    'option-data': [],
    'relay': {'ip-addresses': []},
    'subnet4': [{'4o6-interface': '',
      '4o6-interface-id': '',
      '4o6-subnet': '',
      'id':<PHONE_NUMBER>,
      'next-server': '<IP_ADDRESS>',
      'option-data': [{'always-send': True,
        'code': 28,
        'csv-format': True,
        'data': '<IP_ADDRESS>',
        'name': 'broadcast-address',
        'never-send': False,
        'space': 'dhcp4'},
       {'always-send': True,
        'code': 1,
        'csv-format': True,
        'data': '<IP_ADDRESS>',
        'name': 'subnet-mask',
        'never-send': False,
        'space': 'dhcp4'},
       {'always-send': True,
        'code': 3,
        'csv-format': True,
        'data': '<IP_ADDRESS>',
        'name': 'routers',
        'never-send': False,
        'space': 'dhcp4'},
       {'always-send': True,
        'code': 15,
        'csv-format': True,
        'data': 'hwe.ebay.com',
        'name': 'domain-name',
        'never-send': False,
        'space': 'dhcp4'},
       {'always-send': True,
        'code': 119,
        'csv-format': True,
        'data': 'hwe.ebay.com.,vip.ebay.com.,ebay.com.',
        'name': 'domain-search',
        'never-send': False,
        'space': 'dhcp4'}],
      'pools': [{'option-data': [], 'pool': '<IP_ADDRESS>-<IP_ADDRESS>'}],
      'relay': {'ip-addresses': []},
      'reservations': [],
      'subnet': '<IP_ADDRESS>/26'}]},

I might have to setup stork, because who does not love more monitoring and cool grafana dashboards :)
Thanks for the tips and for developing this plugin, it's much appreciated.

I wonder how hard it would be to hack at your plugin to make the subnets and ID's show up for me since I have access to the premium hooks. It looks like it's a super simpler API call to grab this data and print it in NetBox.
This might be a nice way to ease into the plugin universe :)

The subnets do show in the configuration, but they were configured in "shared-networks".

I'll see if I can add support for that.

I wonder how hard it would be to hack at your plugin to make the subnets and ID's show up for me since I have access to the premium hooks.

I think you  just need to modify one method.

Thanks again for creating this plugin, it's working really well and much appreciated!


First Five Leaderboard Model Conversions

Add five models:

effnetb1_cutmixpatch_augmix_robust32_avge4e7_manylayers_324x288
focal net_tiny_in1k
effnetb1_272x240
effnetb1_cutmixpatch_SAM
cvt
effnetb1_cutmixpatch_augment

@mschrimpf Just an FYI: Two of the models, cvt and effnetb1_cutmixpatch_augmix, do not match the website scores.

@mschrimpf Just an FYI: Two of the models, cvt and effnetb1_cutmixpatch_augmix, do not match the website scores.

do we know why?


Yubikey sleeps after about 15 minutes, have to replug it in constantly

I'm not sure where the correct place to post this is, but it happens with several Yubikeys plugged into USB ports in Ubuntu 20.04 and 22.04, on a Dell T5600 workstation, and I believe on a Toshiba laptop. I could test it on a Window VM, but I'm not sure if using a USB passthrough would troubleshoot the issue.
Basically, as the title says it disconnects all the time, so I have to replug it in and there's no haptic feedback so I press it so many times until it works. I have it slot 1 and 2 swapped, but I think it happens on the ones without a swap (although usually those are used after a popup showing the system is looking for a key, which might issue a wake signal). It's a standard Yubikey 5 without NFC.

Yubico Authenticator version:
Operating system and version:
YubiKey model and version:
Bug description summary:

Steps to reproduce
[Please explain what you did when the bug appeared, and if and how you have been
able to reproduce it.]
Expected result
[What did you expect to happen when you did the above?]
Actual results
[What actually happened?]
Other info
[Anything else you would like to add?]

Sorry for the late reply. Is this still an issue for you?
I suggest you contact support at https://support.yubico.com
I will close this issue since it is not related to Yubico Authenticator.


Kotlin 1.8.0 Requirement

Is there any workaround for having Kotlin set to 1.8.0 and above for versions above 0.23.2?
@react-native-async-storage/async-storage fails with Kotlin version 1.8.0

Hey @enchorb, looks like your issue on the async-storage repo was resolved - I was also just stuck here.
The new versions of async-storage support kotlin 1.8.0
For future peoples: https://github.com/react-native-async-storage/async-storage/issues/948 .
I think the issue can be closed.


Webreg: Implement Calendar view for a specific term

This task is complete when:

The view displays the current week from Sunday to Saturday
The view displays the enrolled and waitlisted courses within the time range of the specific course

See UI Flow at https://www.figma.com/proto/hUluYT2dbw4VormTKyluEl/WebReg-shared?redirected=1&scaling=min-zoom&node-id=40%3A2423

This issue is being closed due to platform migration and may be revisited at a later date.


Error when trying to run an upgraded CRA 4 Typescript project

Describe the bug
When upgrading a Typescript project from CRA 3.4 to CRA 4.0, you get an error when running npm run start:
TypeError: Cannot add property noFallthroughCasesInSwitch, object is not extensible
    at verifyTypeScriptSetup ({...}/react-cra4-upgrade/node_modules/react-scripts/scripts/utils/verifyTypeScriptSetup.js:232:45)
    at Object.<anonymous> ({...}/react-cra4-upgrade/node_modules/react-scripts/scripts/start.js:31:1)

This appears to happen when scanning the tsconfig.json file and modifying it for suggested changes. Based on the error, it appears the object holding the ts config cannot be changed.
When I manually add the noFallthroughCasesInSwitch config item to the ts config it passes.
(Write your answer here.)
Did you try recovering your dependencies?
Yes

(Write your answer here.)
Which terms did you search for in User Guide?

(Write your answer here if relevant.)
Environment
current version of create-react-app: 4.0.0
running from /Users/elylucas/.nvm/versions/node/v12.13.0/lib/node_modules/create-react-app
System:
OS: macOS 10.15.6
CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Binaries:
Node: 12.13.0 - ~/.nvm/versions/node/v12.13.0/bin/node
Yarn: 1.22.4 - ~/.nvm/versions/node/v12.13.0/bin/yarn
npm: 6.14.8 - ~/.nvm/versions/node/v12.13.0/bin/npm
Browsers:
Chrome: 86.0.4240.111
Edge: Not Found
Firefox: 80.0.1
Safari: 14.0
npmPackages:
react: ^17.0.1 => 17.0.1
react-dom: ^17.0.1 => 17.0.1
react-scripts: 4.0.0 => 4.0.0
npmGlobalPackages:
create-react-app: 4.0.0

(paste the output of the command here.)
Steps to reproduce

(Write your steps here:)

Try creating a Typescript based app with react-scripts 3.4.X (here is a link to such an app: https://github.com/elylucas/react-cra4-ts-upgrade-issue).
Upgrade CRA by running npm i --save-exact<EMAIL_ADDRESS>Run npm run start and see the error.

Expected behavior
Based on the code in verifyTypeScriptSetup.js it looks like the user should see a message saying their tsconfig.json is being updated with the recommenced values, and then the app should start as normal.
Actual behavior

Get the following error when trying to start the app:

Reproducible demo

Link to a Ionic React app built with TS and CRA 3.4:
https://github.com/elylucas/react-cra4-ts-upgrade-issue

Possible work around:
add this to your tsconfig:
{
  "compilerOptions": {
    "noFallthroughCasesInSwitch": true,
    // ...
  }
  // ...
}

A question to ask here is why is CRA overwriting a tsconfig option like this. Its one thing to overrite the paths config because its supported, but this seems a bit too opinioned for CRA as it has nothing to do with the build pipeline CRA provides.

Possible work around:
add this to your tsconfig:
{
  "compilerOptions": {
    "noFallthroughCasesInSwitch": true,
    // ...
  }
  // ...
}

A question to ask here is why is CRA overwriting a tsconfig option like this. Its one thing to overwrite the paths configs because its not supported in the babel/webpack config, or set as a default in a new project, but this seems a bit too opinionated for CRA as it has nothing to do with the build pipeline CRA provides.
It treats fallthroughs in switch statements as errors:

Report errors for fallthrough cases in switch statement.

https://www.typescriptlang.org/docs/handbook/compiler-options.html

Yep, adding the noFallthroughCasesInSwitch fixes the problem, and yes, I agree that it should be up to the dev. This doesn't seem to be required to run React in TS so not sure why we "need" it in there.

Also fail when jsx is set to a different value of react in tsconfig.json

Stacktrace

> react-scripts test
/home/user/projects/todo-webapp/node_modules/react-scripts/scripts/utils/verifyTypeScriptSetup.js:239
appTsConfig.compilerOptions[option] = value;
^
TypeError: Cannot assign to read only property 'jsx' of object '#<Object>'
at verifyTypeScriptSetup (/home/user/projects/todo-webapp/node_modules/react-scripts/scripts/utils/verifyTypeScriptSetup.js:239:43)
at Object. (/home/user/projects/todo-webapp/node_modules/react-scripts/scripts/test.js:32:1)
at Module._compile (internal/modules/cjs/loader.js:1076:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1097:10)
at Module.load (internal/modules/cjs/loader.js:941:32)
at Function.Module._load (internal/modules/cjs/loader.js:782:14)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
at internal/main/run_main_module.js:17:47
npm ERR! Test failed.  See above for more details.

My previous tsconfig.json
{
  "compilerOptions": {
    "target": "es5",
    "lib": [
      "dom",
      "dom.iterable",
      "esnext"
    ],
    "allowJs": true,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "noEmit": true,
    "jsx": "preserve"
  },
  "include": [
    "src"
  ]
}

The required changes to upgrade:
diff --git a/tsconfig.json b/tsconfig.json
index 0980b23..7b1d3c6 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -12,12 +12,13 @@
     "allowSyntheticDefaultImports": true,
     "strict": true,
     "forceConsistentCasingInFileNames": true,
+    "noFallthroughCasesInSwitch": true,
     "module": "esnext",
     "moduleResolution": "node",
     "resolveJsonModule": true,
     "isolatedModules": true,
     "noEmit": true,
-    "jsx": "preserve"
+    "jsx": "react"
   },
   "include": [
     "src"

related #9868

@m-rutter , yea that's works! thank you

I am using LinguiJS for i18n in an application and it requires that "jsx": "preserve" be set in tsconfig.json in order to preserve JSX and tagged template literals for the lingui plugins (such as extracting/compiling message catalogs):
https://lingui.js.org/guides/typescript.html
As such, I can't set "jsx": "react", but without this change I cannot start a dev run server and get the same TypeScript error noted above:
$ npm start

><EMAIL_ADDRESS>start cra4
> react-scripts start

./node_modules/react-scripts/scripts/utils/verifyTypeScriptSetup.js:239
      appTsConfig.compilerOptions[option] = value;
                                          ^

TypeError: Cannot assign to read only property 'jsx' of object '#<Object>'
    at verifyTypeScriptSetup (./node_modules/react-scripts/scripts/utils/verifyTypeScriptSetup.js:239:43)
    at Object.<anonymous> (./node_modules/react-scripts/scripts/start.js:31:1)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32)
    at Function.Module._load (internal/modules/cjs/loader.js:878:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `react-scripts start`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

To reproduce:
npx create-react-app cra4 --template redux-typescript
Then modify tsconfig.json and change:
{
  "compilerOptions": {
    "jsx": "preserve",
    "target": "es2016"
  }
}

and npm start
Any thoughts on fixes or temporary work-arounds?
Thank you and best regards,

See this https://github.com/facebook/create-react-app/issues/10144

I am using LinguiJS for i18n in an application and it requires that "jsx": "preserve" be set in tsconfig.json in order to preserve JSX and tagged template literals for the lingui plugins (such as extracting/compiling message catalogs):
https://lingui.js.org/guides/typescript.html
As such, I can't set "jsx": "react", but without this change I cannot start a dev run server and get the same TypeScript error noted above:
$ npm start

><EMAIL_ADDRESS>start cra4
> react-scripts start

./node_modules/react-scripts/scripts/utils/verifyTypeScriptSetup.js:239
      appTsConfig.compilerOptions[option] = value;
                                          ^

TypeError: Cannot assign to read only property 'jsx' of object '#<Object>'
    at verifyTypeScriptSetup (./node_modules/react-scripts/scripts/utils/verifyTypeScriptSetup.js:239:43)
    at Object.<anonymous> (./node_modules/react-scripts/scripts/start.js:31:1)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32)
    at Function.Module._load (internal/modules/cjs/loader.js:878:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `react-scripts start`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

To reproduce:
npx create-react-app cra4 --template redux-typescript
Then modify tsconfig.json and change:
{
  "compilerOptions": {
    "jsx": "preserve",
    "target": "es2016"
  }
}

and npm start
Any thoughts on fixes or temporary work-arounds?
Thank you and best regards,

Update:
From my testing with latest create-react-app/react-scripts 4.0.1, it looks like LinguiJS is now working with React17+TypeScript 4+CRA 4.0.1 and I am no longer getting the runtime error Cannot assign to read only property 'jsx' of object '#<Object>'.
This is despite the tsconfig.json compilerOptions.jsx "preserve" option being overwritten with "react-jsx" when calling react-scripts (such as via npm start).
This has not been tested exhaustively, but has worked for me both in an existing app upgraded to React17+TS4+CRA 4.0.1 and in a new app bootstrapped using create-react-app.
For more details, please see:
https://github.com/lingui/js-lingui/issues/826


[fuzz-test] Arithmetic overflow occurs while using API Constraint::apply()

Description

I executed fuzzing to test tui-0.19.0 APIs. This reproduced on ratatui as well. I guess other variants of Constraint may overflow as well...
impl Constraint {
    pub fn apply(&self, length: u16) -> u16 {
        match *self {
            Constraint::Percentage(p) => length * p / 100,
            Constraint::Ratio(num, den) => {
                let r = num * u32::from(length) / den;   // overflow!
                r as u16
            }

To Reproduce

let mut self_obj  = Constraint::Ratio(fuzz_arg0, fuzz_arg1);
self_obj.apply(fuzz_arg2);

fuzz input : (589505315, 302, 8995)
Expected behavior

Adding assert statement or just explicitly mention panic condition on API doc

This does not apply to Ratatui.
https://github.com/ratatui-org/ratatui/blob/8135030c748bc386f723d599e67c348fa766870e/src/layout.rs#L125-L131


Fixed Typo in Readme

The ReadMe file has been changed to fix a typo in the text

Looks good to me


Tasks not respecting instance limit

Issue Type: Bug
VS Code version: Code 1.44.2 (ff915844119ce9485abfe8aa9076ec76b5300ddd, 2020-04-16T16:36:23.138Z)
OS version: Windows_NT x64 10.0.19041
Repro:
Using the following tasks.json:
{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "label": "run update.sh",
            "type": "shell",
            "command": "./update.sh",
            "options": {
                "shell": {
                    "executable": "bash.exe",
                    "args": [
                        "-c"
                    ]
                }
            },
            "group": {
                "kind": "build",
                "isDefault": true
            }
        }
    ]
}

Observed Behaviour:
Holding down Ctrl+Shift+B (run default build task) will result in multiple tasks running at the same time. This clogs up the "currently running tasks" list especially when a task hangs.
Expected Behaviour:
A notification should tell us that the task is already running. This is what I see using version 1.42.1.

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-6600K CPU @ 3.50GHz (4 x 3504)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

I've been seeing this too. This causes corrupted builds in my project since I'm in the habit of invoking builds frequently and the build is not safe to running in parallel with itself.

Thank you for reporting this! Duplicate of https://github.com/microsoft/vscode/issues/96999


Disposals chute make it go splat

About the PR
I added a new FragileComponent and have it being used in some places. Anything using this component will liquify upon leaving the disposals (or mail) chute. Currently eggs, watermelon, and tomatos will go splat.
Why / Balance
This is a feature I remember from ss13 that was really funny. Hopefully future mappers create distance between botany and the kitchen so they have to use a mail chute (and this will get used more).
Technical details

added FragileComponent with attribute puddle (puddle is the liquid that will form once it leaves the chute)
added check to disposals system (if fragile, go splat... else function as per usual)

Media
https://streamable.com/ryi7ip

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog
tweak: Flushing fragile items will destroy them! Better find a container.

dont egg and tomato already store their puddles in another component

dont egg and tomato already store their puddles in another component

I wanted watermelon -> watermelon juice... tomato -> tomato juice.... egg -> egg
Problem is there is no universal identifier to do this which is why I made my own. I removed what I had and am now using the SolutionContainerManager for everything (watermelon -> Nutriment, Vitamin, Water... tomato -> Nutriment, Vitamin, Water... egg -> egg)

I want to say that there would be a way to do the same thing using existing components/systems, but I might be misremembering.
Yep. DamageOnLandComponent -> SpillBehaviour (Damage Threshold)
The only major change would be making disposal chutes throw things slightly upon exit.

It would be cool because stuff like bottles would also break, but then disposal trunks will have some unexpected behavior. E.x. you are expecting stuff to get dumped out onto a conveyor belt but it's throwing them slightly off. I'll play around with this and see what happens.

conveyors automatically align items to the center so thats fine


other(pr template): pr template to request a run

The type of this PR is: DX

Description
I have added a new section on the PR template, you can see it below, called To the reviewers 👀. It can be used to give some hints to the reviewers. For now I have added a checkbox to say that the PR author would like one of the reviewers to actually run the PR on sim or device. To checkout the PR, run it, and check it there, and not just the code. That specific request can be for PRs that the author knows need more attention or more eyes on it or more QA or more anything else that a run would provide.
It could also be used to add hints for how to QA a PR if a run is needed. Or any other thing you wanna tell the reviewers, like "enjoy approving this 10k line deletion PR 😛".

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

#nochangelog
Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Warnings

:warning:

✅ No changelog changes

  Generated by :no_entry_sign: dangerJS against a90e7600fab5c6ceaef4c8f8465b171d14804ca1

yup. I was "stealthily" testing the new suggestion I'll show next week. I'll change it, but docs instead of chore 🤔


TiKV panic when running br backup due to "called Option::unwrap() on a None value"

Bug Report

What version of TiKV are you using?
[root@tc-tikv-0 /]# /tikv-server -V
TiKV
Release Version:   7.6.0
Edition:           Community
Git Commit Hash:   b8858b4d4939cc43aff1b6d0b465b744a42110b9
Git Commit Branch: heads/refs/tags/v7.6.0
UTC Build Time:    2024-01-15 07:53:16
Rust Version:      rustc 1.76.0-nightly (06e02d5b2 2023-12-09)
Enable Features:   pprof-fp jemalloc mem-profiling portable sse test-engine-kv-rocksdb test-engine-raft-raft-engine cloud-aws cloud-gcp cloud-azure trace-async-tasks openssl-vendored
Profile:           dist_release

What operating system and CPU are you using?
K8S
Steps to reproduce

A TiDB cluster with 20 TiKV nodes (16c64g)
Run br restore to restore a backup for 500k tables, and restore failed due to https://github.com/pingcap/tidb/issues/50477
Run br backup to backup the cluster (parameters: --concurrency=256)

What did you expect?

Backup should succeed

What did happened?
TiKV panic seen
[2024/01/16 04:29:51.886 +00:00] [FATAL] [lib.rs:478] ["called `Option::unwrap()` on a `None` value"] [backtrace="   0: tikv_util::set_panic_hook::{{closure}}\n             at home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tikv/components/tikv_util/src/lib.rs:477:18\n   1: <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc/src/boxed.rs:2029:9\n      std::panicking::rust_panic_with_hook\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:783:13\n   2: std::panicking::begin_panic_handler::{{closure}}\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:649:13\n   3: std::sys_common::backtrace::__rust_end_short_backtrace\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys_common/backtrace.rs:171:18\n   4: rust_begin_unwind\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:645:5\n   5: core::panicking::panic_fmt\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/panicking.rs:72:14\n   6: core::panicking::panic\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/panicking.rs:144:5\n   7: core::option::Option<T>::unwrap\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/option.rs:931:21\n      backup::endpoint::Progress<R>::forward::{{closure}}\n             at home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tikv/components/backup/src/endpoint.rs:812:60\n      core::ops::function::FnOnce::call_once{{vtable.shim}}\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:250:5\n   8: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc/src/boxed.rs:2015:9\n      raftstore::coprocessor::region_info_accessor::RegionCollector::handle_seek_region\n             at home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tikv/components/raftstore/src/coprocessor/region_info_accessor.rs:473:9\n      <raftstore::coprocessor::region_info_accessor::RegionCollector as tikv_util::worker::pool::Runnable>::run\n             at home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tikv/components/raftstore/src/coprocessor/region_info_accessor.rs:561:17\n   9: tikv_util::worker::pool::Worker::start_with_timer_impl::{{closure}}\n             at home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tikv/components/tikv_util/src/worker/pool.rs:517:25\n      <tracker::tls::TrackedFuture<F> as core::future::future::Future>::poll::{{closure}}\n             at home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tikv/components/tracker/src/tls.rs:64:23\n      std::thread::local::LocalKey<T>::try_with\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/thread/local.rs:270:16\n      std::thread::local::LocalKey<T>::with\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/thread/local.rs:246:9\n      <tracker::tls::TrackedFuture<F> as core::future::future::Future>::poll\n             at home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tikv/components/tracker/src/tls.rs:62:27\n      tikv_util::yatp_pool::future_pool::PoolInner::spawn::{{closure}}\n             at home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tikv/components/tikv_util/src/yatp_pool/future_pool.rs:220:28\n      yatp::task::future::RawTask<F>::poll\n             at rust/git/checkouts/yatp-e704b73c3ee279b6/5572a78/src/task/future.rs:59:9\n  10: yatp::task::future::TaskCell::poll\n             at rust/git/checkouts/yatp-e704b73c3ee279b6/5572a78/src/task/future.rs:103:9\n      <yatp::task::future::Runner as yatp::pool::runner::Runner>::handle\n             at rust/git/checkouts/yatp-e704b73c3ee279b6/5572a78/src/task/future.rs:387:20\n  11: <tikv_util::yatp_pool::YatpPoolRunner<T> as yatp::pool::runner::Runner>::handle\n             at home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tikv/components/tikv_util/src/yatp_pool/mod.rs:198:24\n      yatp::pool::worker::WorkerThread<T,R>::run\n             at rust/git/checkouts/yatp-e704b73c3ee279b6/5572a78/src/pool/worker.rs:48:13\n      yatp::pool::builder::LazyBuilder<T>::build::{{closure}}\n             at rust/git/checkouts/yatp-e704b73c3ee279b6/5572a78/src/pool/builder.rs:114:25\n      std::sys_common::backtrace::__rust_begin_short_backtrace\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys_common/backtrace.rs:155:18\n  12: std::thread::Builder::spawn_unchecked_::{{closure}}::{{closure}}\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/thread/mod.rs:529:17\n      <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/panic/unwind_safe.rs:272:9\n      std::panicking::try::do_call\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:552:40\n      std::panicking::try\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:516:19\n      std::panic::catch_unwind\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panic.rs:142:14\n      std::thread::Builder::spawn_unchecked_::{{closure}}\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/thread/mod.rs:528:30\n      core::ops::function::FnOnce::call_once{{vtable.shim}}\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:250:5\n  13: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc/src/boxed.rs:2015:9\n      <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc/src/boxed.rs:2015:9\n      std::sys::unix::thread::Thread::new::thread_start\n             at rust/toolchains/nightly-2023-12-10-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys/unix/thread.rs:108:17\n  14: start_thread\n  15: __GI___clone3\n"] [location=/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tikv/components/backup/src/endpoint.rs:812] [thread_name=region-collector-worker-0] [thread_id=0x5]

/component br


feat(ui): smart start view improvements

Add a way to easily switch to the node attached to a specific provisioning entry (either by opening a modal there or a link to control panel)
Add an info panel to explain some useful info about smart start entries
Fill node manufacturer/model/protool informations when missing from QR code but existing nodeId

Fixes #3674

Some feedback:

when including a node via SmartStart while the SmartStart page is open, the "link" to the node does not get updated. We need to be careful though in case the user is editing something, so we don't reload or discard their changes.
Should the info panel be there already? I don't see it.
The hover effect on the node ID link is too subtle IMO
maybe add a tooltip on the grayed out fields of an included node: "The node is already included, so editing its SmartStart settings is not possible."


Change name of ajax progress whirly modal to mo_ajax_progress

So it doesn't seem like it's only for the use of Naming ajax stuff.
This is the modal called by the MOEvents.whirly

Coverage: 93.549%. Remained the same when pulling 6d73637c12432efdfc82cfe004c3c6da800d8985 on nimmo-ajax-edit-naming into 13aebe0c8b605b1d5cf93676a1e5369eaa2b0426 on main.


ci: Update Ubuntu image

Fixes CI after Ubuntu 18.04 image was removed https://github.com/actions/runner-images/issues/6002

Superseded by https://github.com/pulp-platform/snitch/pull/486.


[Bug]: The nowrap code block have a low clarity in canvas

Bug Description
Steps to reproduce
Add a canvas card from file which embed the code block.
The theme which enable the code blcok nowrap and the card display the code block will reduce the card render clarity.

The right card have more clarity then the left card Obviously.

And you can drag the card to resize.
When the code block have no "hide", It became clear immediate.

When the code block have "hide", It became unclear immediate.

Expected result

The card which have nowrap code block render normally.
Actual result

The card which have "hide" code block have a low clarity.
Environment

Operating system: Apple M1

Debug info:

SYSTEM INFO:
	Obsidian version: v1.1.8
	Installer version: v1.0.0
	Operating system: Darwin Kernel Version 22.1.0: Sun Oct  9 20:14:30 PDT 2022; root:xnu-8792.41.9~2/RELEASE_ARM64_T8103 22.1.0
	Login status: not logged in
	Insider build toggle: off
	Live preview: off
	Legacy editor: off
	Base theme: adapt to system
	Community theme: Blue Topaz v20221221.1
	Snippets enabled: 0
	Restricted mode: off
	Plugins installed: 14
	Plugins enabled: 14
		1: Advanced Tables v0.18.1
		2: Calendar v1.5.10
		3: Copy Block Link v1.0.4
		4: Easy Typing v5.1.1
		5: Vimrc Support v0.8.0
		6: Tasks v1.20.0
		7: Style Settings v0.4.12
		8: Reminder v1.1.15
		9: Obsidian Memos v1.9.7
		10: Image Toolkit v1.3.1
		11: Icon Folder v1.4.3
		12: Excalidraw v1.8.6
		13: Editing Toolbar v2.2.3
		14: Admonition v9.0.5

RECOMMENDATIONS:
	Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
	Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

Relevant Screenshot
.
To Reproduce
.
Obsidian Version
1.1.8
Installer Version
1.0.0
In which mode(s) does the problem occur? (if applicable)

[ ] Source (Edit)
[X] Reading (Preview)
[ ] Live Preview

Which operating system?

[X] macOS
[ ] Linux
[ ] Windows
[ ] iOS
[ ] Android

Checklist

[X] I updated to the latest version of the theme (Settings → Appearance → Check for updates).
[X] When using the Obsidian Insider release, I have already checked out the insider-branch and the issue still occurs there.
[X] If the bug occurred after updating the theme, I read the last couple of entries in the changelog to make sure the bug is not an intentional change. (In that case, there will most likely be a style setting to turn it off again.)
[X] I made sure that the issue is related to this theme by checking that the problem does not occur with the default theme.
[X] In case I am missing an UI element, I have checked that it cannot be re-enabled with the Style Settings plugin.
[X] My issue concerns Obsidian version 1.0+ and I am not using the Legacy Editor (CM5). (Older Obsidian versions and the Lecacy Editor are not supported by this theme anymore.)

Good catch, is fixed


Flac Audio Option

Why isn't there a Flac option in the audio formats? I can see that youtube-dl already supports it? Thanks.

You can now enable the flac audio format under Audio formats in the Options > Formats tab.

Thanks for the fast response and change! I'm now just wondering if it's either not working correctly or if it takes time to become live on updates/windows installer? I updated the windows portable version but can't see the Flac option in Audio formats, I also tried out the windows installer and updated that with also no success.

That's because there is not a new release yet.
You can either wait for the next release or download and install from source master zip.

Ah I was thinking this is probably the case, thanks once again for the amazingly fast changes!

That's because there is not a new release yet.
You can either wait for the next release or download and install from source master zip.

Do you have instructions to build the portable version or is it the same procedure?

Sorry to revive an old thread, but I have the recent build of youtube-dlg (0.4), and I still don't see an option for FLAC under the Options > Formats tab.

Sorry to revive an old thread, but I have the recent build of youtube-dlg (0.4), and I still don't see an option for FLAC under the Options > Formats tab.

I can confirm it isn't there, sadly

What would the point of this be? Youtube does not store audio in FLAC format, therefore it is pointless to convert whatever format is obtained from the download to FLAC.
FLAC only makes sense when encoding lossless, uncompressed formats such as WAV.


Section of path that starts with a number results in Bolt error

A path with a particular section (i.e. that is delimited with a forward-slash) that begins with a number produces the "generic" error:
bolt:LINE_NUM:COL_NUM: Expected comment, end of input, function definition, path statement, type statement or whitespace but "p" found.

So the following path does not work:
path /a/path/to/1numberedObject {
  read() = true
}

I tried enclosing the entire path in quotes, but that didn't do the trick. Suggestions? I know Firebase keys can begin with numbers, but they must be stored as strings...

I think this was fixed in Bolt 0.7.0 (or 0.7.1) - it works for me.  Can you get the latest from npm and confirm? @mm-gmbd

I see the problem.  Bolt 0.7 is more strict about semicolons - you're missing one in the read() expression.  This is relaxed in 0.7.1 (this was unrelated to the path statement).


feat: Enable azure secret store webhooks

https://github.com/wandb/terraform-kubernetes-wandb/pull/44

Tested operations on https://azure-operator.wandb.ml/, and they seem to work (upsert, fetch, delete)

This PR is included in version 1.7.0 :tada: