Indentation for DO too strict

This code fragment is accepted by the parser:
con A, B : Int
var z : Int

{ true }
x, y, z := A, B, 0
{ x * y + z = A * B, bnd: y }
do y /= 0 -> if even y ->
                 x := x * 2
                 y := y / 2
              | odd y  ->
                 z := z + x
                 y := y - 1
             fi
od
{ z = A * B }

while this is not:
con A, B : Int
var z : Int

{ true }
x, y, z := A, B, 0
{ x * y + z = A * B, bnd: y }
do y /= 0 ->
  if even y ->
      x := x * 2
      y := y / 2
   | odd y  ->
      z := z + x
      y := y - 1
  fi
od
{ z = A * B }

It seems that indentation rules for if is more permissive --- x := x *2 is allowed to appear in a new line with less indentation, while that for do is too strict --- if even ... has to be indented further than do y /= 0 ->, even in a new line.
Ideally I would like both programs to be accepted by the parser.

Token like do introduces a "block", which expects an indented block of code (exactly like in Haskell)
do line
   line
   line

The parser is not happy about the second program, because it now looks like this:
do line
  mishap
   line

In this case, the indentation level of the "block" starts right at where y /= 0 ->
do y /= 0 ->
   ^
   3

However, the following line if even y -> only has the level of 2
do y /= 0 ->
  if even y ->
  ^
  2

The program should be accepted by the parser if the following line is indented a bit further like this.
do y /= 0 ->
    if even y ->
        x := x * 2

It seems that indentation rules for if is more permissive --- x := x *2 is allowed to appear in a new line with less indentation, while that for do is too strict --- if even ... has to be indented further than do y /= 0 ->, even in a new line.

Tokens like if and do are treated the same, the following program should also be accepted by the parser.
  do even y ->
      x := x * 2

Please reopen this issue if you think that tokens like if and do should not introduce an indented block, and guarded command should be able to be placed freely like this:
do
        | guard ->
     | guard ->
          | guard ->
od

(not sure if this is feasible)


Test failure against Mapnik master

Seeing:
  561 passing (3s)
  1 pending
  1 failing

  1) mapnik.Feature  should construct a feature properly:
     AssertionError: Missing expected exception..
      at Function._throws (assert.js:301:5)
      at Function.assert.throws (assert.js:318:11)
      at Context.<anonymous> (test/feature.test.js:45:16)

Looks like this json is no longer considered invalid by Mapnik: https://github.com/mapnik/node-mapnik/blob/master/test/feature.test.js#L46
/cc @artemp to investigate

@springmeyer - the above is fixed after 32331e9b3e2c0a6b10f352f9c47453397df5194c but I'm getting some other failures, would be cool to sync briefly !

other failures fixed in https://github.com/mapnik/node-mapnik/commit/aa8b9e01b7137c92812af57b41e7ec539dc43715, closing.

add malformed feature tests
https://github.com/mapnik/test-data/commit/e2ddd49eaf1638dd871ab168f7d3f88a10d42696
https://github.com/mapnik/mapnik/commit/b85055ee38da59baaaa2a590d3144e4240d142d8


Error for "cf create-app-manifest"

$ cf create-app-manifest scd-admin
Creating an app manifest from current settings of app scd-admin ...
Aww shucks.

Something completely unexpected happened. This is a bug in cf.
Please file this bug : https://github.com/cloudfoundry/cli/issues
Tell us that you ran this command:

	cf create-app-manifest scd-admin

using this version of the CLI:

	6.12.3-c0c9a03

and that this error occurred:

	runtime error: invalid memory address or nil pointer dereference

and this stack trace:

	goroutine 1 [running]:
main.generateBacktrace(0x0, 0x0)
	/Users/cffadmin/go-agent/pipelines/Mac-OSX-Unit-Tests/src/github.com/cloudfoundry/cli/main/main.go:117 +0xc7
main.handlePanics(0xe1b2f0, 0xc2080ec500)
	/Users/cffadmin/go-agent/pipelines/Mac-OSX-Unit-Tests/src/github.com/cloudfoundry/cli/main/main.go:101 +0x1a4
github.com/cloudfoundry/cli/cf/commands.(*CreateAppManifest).createManifest(0xc208214d80, 0xc20881fda0, 0x24, 0xc208838c16, 0x9, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/Users/cffadmin/go-agent/pipelines/Mac-OSX-Unit-Tests/src/github.com/cloudfoundry/cli/tmp/cli_gopath/src/github.com/cloudfoundry/cli/cf/commands/create_app_manifest.go:91 +0x85
github.com/cloudfoundry/cli/cf/commands.(*CreateAppManifest).Execute(0xc208214d80, 0xe1cb80, 0xc20821cd80)
	/Users/cffadmin/go-agent/pipelines/Mac-OSX-Unit-Tests/src/github.com/cloudfoundry/cli/tmp/cli_gopath/src/github.com/cloudfoundry/cli/cf/commands/create_app_manifest.go:87 +0x4d2
main.main()
	/Users/cffadmin/go-agent/pipelines/Mac-OSX-Unit-Tests/src/github.com/

Fixed in latest edge binary.  Fix will be in 6.12.4


chore(index): add plugin metadata

Adds the plugin name to the metadata to allow for dependency checks to be performed.
See https://github.com/fastify/fastify-plugin#name
Don't know if it's also worth adding the dependencies and the fastify version to reflect package.json?

Checklist

[x] run npm run test and npm run benchmark
[x] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

@galvez wdyt?

Don't know if it's also worth adding the dependencies and the fastify version to reflect package.json?

Will double check and add that in a subsequent commit. Thanks!


Google search console blocked

Preliminary Checks

[X] I have reviewed the documentation: https://clerk.com/docs

[X] I have searched for existing issues: https://github.com/clerk/javascript/issues

[X] I have not already reached out to Clerk support via email or Discord (if you have, no need to open an issue here)

[X] This issue is not a question, general help request, or anything other than a bug report directly related to Clerk. Please ask questions in our Discord community: https://clerk.com/discord.

Reproduction / Replay Link
https://github.com/t3-oss/create-t3-app
Publishable key
pk_test_c2ltcGxlLWhvdW5kLTkyLmNsZXJrLmFjY291bnRzLmRldiQ
Description
When you ask google search console to test your url , clerk is throwing a 401 with this message in the debug

 authenticateRequest state is interstitial, {
    "status": "interstitial",
    "reason": "uat-missing",
    "message": "",
    "frontendApi": "simple-hound-92.clerk.accounts.dev",
    "publishableKey": "pk_test_c2ltcGxlLWhvdW5kLTkyLmNsZXJrLmFjY291bnRzLmRldiQ",
    "isSatellite": false,
    "domain": "",
    "proxyUrl": "",
    "signInUrl": "",
    "isSignedIn": false,
    "isInterstitial": true,
    "isUnknown": false,
    "token": null
  }

i can reproduce this error in postman with the nextjs dev server with this request ( user agent of google search console )
curl --location 'http://localhost:3000' \
--header 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:122.0) Gecko/20100101 Firefox/122.0'

removing the useragent or putting anything without Mozilla/5.0 inside is working ( ie:  Chrome/13.0.782.112 Safari/535.1 )
Environment
System:
    OS: macOS 12.6.5
    CPU: (4) x64 Intel(R) Core(TM) i5-5250U CPU @ 1.60GHz
    Memory: 450.73 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 21.6.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.4 - /usr/local/bin/npm
    pnpm: 8.7.1 - /usr/local/bin/pnpm
    bun: 1.0.25 - ~/.bun/bin/bun
  Browsers:
    Chrome: 121.0.6167.139
    Safari: 16.4.1
  npmPackages:
    @clerk/nextjs: 4.29.3 => 4.29.3
    @radix-ui/react-slot: ^1.0.2 => 1.0.2
    @t3-oss/env-nextjs: ^0.7.1 => 0.7.3
    @tanstack/react-query: ^4.36.1 => 4.36.1
    @trpc/client: ^10.43.6 => 10.45.0
    @trpc/next: ^10.43.6 => 10.45.0
    @trpc/react-query: ^10.43.6 => 10.45.0
    @trpc/server: ^10.43.6 => 10.45.0
    @types/eslint: ^8.44.7 => 8.56.2
    @types/node: ^18.17.0 => 18.19.14
    @types/react: ^18.2.37 => 18.2.52
    @types/react-dom: ^18.2.15 => 18.2.18
    @typescript-eslint/eslint-plugin: ^6.11.0 => 6.20.0
    @typescript-eslint/parser: ^6.11.0 => 6.20.0
    @xixixao/uploadstuff: ^0.0.5 => 0.0.5
    autoprefixer: ^10.4.14 => 10.4.17
    class-variance-authority: ^0.7.0 => 0.7.0
    clsx: ^2.1.0 => 2.1.0
    convex: ^1.8.0 => 1.8.0
    eslint: ^8.54.0 => 8.56.0
    eslint-config-next: ^14.0.4 => 14.1.0
    fast-xml-parser: ^4.3.3 => 4.3.4
    google-auth-library: ^9.6.0 => 9.6.2
    googleapis: ^131.0.0 => 131.0.0
    jose: ^5.2.0 => 5.2.1
    lucide-react: ^0.320.0 => 0.320.0
    next: ^14.0.4 => 14.1.0
    postcss: ^8.4.31 => 8.4.33
    prettier: ^3.1.0 => 3.2.5
    prettier-plugin-tailwindcss: ^0.5.7 => 0.5.11
    react: 18.2.0 => 18.2.0
    react-dom: 18.2.0 => 18.2.0
    server-only: ^0.0.1 => 0.0.1
    superjson: ^2.2.1 => 2.2.1
    tailwind-merge: ^2.2.1 => 2.2.1
    tailwindcss: ^3.3.5 => 3.4.1
    tailwindcss-animate: ^1.0.7 => 1.0.7
    typescript: ^5.1.6 => 5.3.3
    zod: ^3.22.4 => 3.22.4

Hi, thanks for the issue!
You need to create and use a production instance for your deployed app. The behavior you're describing is expected when you use development instances.

very thanks
it possible to add this info in the debug log ?


Add WorkQueue debugging for ACDC - NEVER merge

@ticoann this is the patch I suggest we apply to the agents for a few weeks until we can have a better insight of the problem. Can you have a quick look? I'll also test it in testbed first, just to make sure it isn't broken.

Hi Alan, what you observed was the difference between acdc record and wmbs record, correct?
I am not completely sure about what we can find out with debugging message.

Thanks for the review, Seangchan. I think we need to track 3 things:

that we pull all the lumi sections from ACDCServer (thus all lfns/runs/lumis)
that we don't miss any of this information until we get to File.addFilesToWMBSInBulk
this is a bit more complicated, but we should be able to see what are the binds we use for wmbs insertion. Another problem here is that we have one entry per lumi, and there is no way to know whether we're handling it for ACDC or standard workflows.

Do you see anything missing?

Thanks Alan, That make sense. I was wondering since the missing lumi case examples has the same lfn entries with different lumis. we maybe should focus on that as well.  Printing out what lfn and has more than 1 entries in ACDC.

Since WorkQueueManager didn't crash in my testbed agent, I'm pushing this one to the 3 new production nodes.

This patch was already merged for 1.1.8.patch2

@amaltaro, Alan do we still need to keep this around?

Absolutely not, it's from 2017 :)


Add last modified time for metadata

This patch improves performance during development and does not affect production performance.
Currently, enabling the metadata cache during development gives a remarkable performance boost, but it requires that you manually flush the metadata cache when the metadata has been changed. When running console commands such as console orm:schema-tool:update (see #979).
With this change, metadata entries fetched from cache are checked for freshness using a quick last modified check. This is much faster than loading the actual metadata using the metadata driver. This allows you to enable the metadata cache during development without the need for manually flushing the metadata cache.
This PR is part 1 of 2. Part 2 is for the doctrine/common repository. See https://github.com/doctrine/common/pull/319.
If this PR is accepted, it allows us to optimize the auto-generate proxy classes feature by comparing the last modified time for the metadata with the modified timestamp of the generated file.

As per discussion in https://github.com/doctrine/common/pull/319#issuecomment-136326367, assigning to @guilhermeblanco to see if something in this PR can still be implemented inside the new metadata API impl.

Discussed this further with @guilhermeblanco while at TrueNorthPhp: going down this route will be quite painful in future.
I wanted to share how we envision metadata to be working in 3.x and further.
As it currently stands, metadata is a lazy graph of definitions loaded through a ClassMetadataFactory and a set of MetadataDriver instances, and it can be cached, etc.
What we want to do instead is to pass metadata to the EntityManager constructor:
$em = EntityManager::create(..., $metadataCollection);

This lets the instantiation logic (outside the ORM) decide whether $metadataCollection is lazy or not, or whether it should be cached or not.
I am therefore closing this issue, hoping that we'll start working on the 3.x approach soon instead.
Sorry, @c960657, I realize that you put a lot of effort in this, but I hope you do see how this would simplify things massively without increasing complexity in internals and in the metadata loading API.

No worries. I am looking forward to seeing how it will work in 3.x :-)


Update configmap-reloader for 2004/20H2 in logging

Relevant issue: https://github.com/rancher/rancher/issues/30808
We are using the same chart version (0.2.3) since it has been unreleased.

(please ignore extra review @rmweir)


#8157 Enum IconStyle

Adding enum iconstyle for hiding the icon in the tab #8157
Summary of the Pull Request
Please confirm if I am on the right track.
References and Relevant Issues
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
PR Checklist

[ ] Closes #8157
[x] Tests added/passed
[ ] Documentation updated

If checked, please file a pull request on our docs repo and link it here: #xxx

[ ] Schema updated (if necessary)

Thanks for the contribution! We're all gonna be a little extra busy this week, so it might be a bit before we can give this a full review. Thanks for your patience!

I will be looking into making monochrome work, but I need to understand if I need to implement grayscale features or we have a way of getting monochrome icons from iconPath.

FYI: this is probably easily doable with iconSource.ShowAsMonochrome(true)

Personally speaking, I'm not sure whether we should add this if no user has asked for it yet though... Seems quite niche to me if I'm honest. 😶

<dustin hat>
Before I merge it, can you change the title to explain the change in brief?
Rather than "Fix bug 1234", it is easier to read if it is like (for example) "Evaluate the numbers before displaying them". It makes it so you can get a good idea of the code change without having to look at another bug ID


single()

Throws error if Iterable has more than one element.

first() should provide the same functionality; the exception seems to have limited, if any, use.

Re-opening, but will throw exception if more than one element exists in Iterable instance..


Big n

Hi @jamespayor , Thank you for developing this project. If it is still alive I have a suggestion and a question.

When playing with big assignment problems I got a stack overflow due to arrays allocated on stack. I would suggest to replace them by std::vector allocating data in the heap.
Do you think it is possible to modify the algorithm to support graph parts of different sizes $n_1 \le n_2$ ("rectangular matrix") without adding dummy nodes/edges? So that the perfect matching is the one covering all the nodes in the left part. In particular, I am interested in the case of $n_1 \ll n_2$ with big $n_2$ and wonder if we can get good performance if try to limit the number of edges.

Hi, thank you for the feedback!
Re (1), yeah that seems completely right, I'm not sure why I thought allocating those on the stack was a good idea.
Re (2), I'd bet it "just works" to switch to a general bipartite graph, and increase the matching until progress stops, at which point you'd have a min-weight maximal matching. If that's right, this does seem better, especially since I think there little code changed, and the inner loop will still do exactly the same work.
I'm busy right now but will hope to try these soon.

When playing with your code I realized that for the unbalanced problem case $n_1 \le n_2$ it is not only about changing the the right part bounds. I came up with more changes:

Edge list initialization: remove rightEdgeCounts check from no solution detection.
Node potential initialization: zeroing out all right potentials in the case $n_1 < n_2$, due to the fact that I considered zero-cost virtual dummy edges to $n_2 - n_1$ virtual dummy left nodes. Without doing that I got wrong results.

It seemed worked on my test cases but I did not try to prove it in general, just as I did not evaluate new complexity.


Package request: AssetRipper

Project description
A tool for extracting Unity serialized files.
Metadata

homepage URL: https://assetripper.github.io/AssetRipper/
source URL: https://github.com/AssetRipper/AssetRipper
license: GPL 3.0
platforms: unix

My attempt
{ fetchFromGitHub
, buildDotnetModule
, lib
, dotnetCorePackages
, gcc
, ncurses
, zlib
} :

let
  vmr = dotnetCorePackages.dotnet_8.vmr;
  sdk = dotnetCorePackages.dotnet_8.sdk;
in buildDotnetModule rec {
  pname = "asset-ripper";
  version = "1.0.9";
  src = fetchFromGitHub {
    owner = "UlyssesZh";
    repo = "AssetRipper";
    # Change to `rev = version;` when AssetRipper/AssetRipper#1244 gets merged and released.
    rev = "936aafe62c66618a6778b370e76c7e527289fcf0";
    hash = "sha256-RFFu93Tlq8kwo4v3WNKoElKHVR7+w802tDy9r+x+gHU=";
  };
  nativeBuildInputs = [ gcc vmr zlib ncurses ];
  dotnet-sdk = sdk;
  projectFile = "Source/AssetRipper.GUI.Free/AssetRipper.GUI.Free.csproj"; # #220985
  selfContainedBuild = true;
  nugetDeps = ./deps.nix;
  meta = with lib; {
    description = "A tool for extracting assets from Unity serialized files and asset bundles and converting them into the native Unity engine format.";
    homepage = "https://assetripper.github.io/AssetRipper/";
    license = licenses.gpl3;
    maintainers = with maintainers; [ ulysseszhan ];
    mainProgram = "AssetRipper";
    platforms = platforms.all;
  };
}

Failed with compilation errors:
EXEC : error : Unable to load shared library 'objwriter' or one of its dependencies. In order to help diagnose loading problem
s, consider using a tool like strace. If you're using glibc, consider setting the LD_DEBUG environment variable: [/build/sourc
e/Source/AssetRipper.GUI.Free/AssetRipper.GUI.Free.csproj]
  /build/tmp.hknPKx4wii/.nuget/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/8.0.2/tools/objwriter.so: cannot open sh
ared object file: No such file or directory
  /build/tmp.hknPKx4wii/.nuget/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/8.0.2/tools/libobjwriter.so: cannot open
 shared object file: No such file or directory
  /build/tmp.hknPKx4wii/.nuget/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/8.0.2/tools/objwriter: cannot open shared object file: No such file or directory
  /build/tmp.hknPKx4wii/.nuget/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/8.0.2/tools/libobjwriter: cannot open shared object file: No such file or directory

Add a :+1: reaction to issues you find important.

@UlyssesZh have you tried with .net 6 ? Please try to use tag instead of specific commit in fetchFromGitHub

have you tried with .net 6 ?

I tried .NET 6, and it has this error:
error NETSDK1045: The current .NET SDK does not support targeting .NET 8.0.  Either target .NET 6.0 or lower, or use a version of the .NET SDK that supports .NET 8.0.

According to the error, I can only use .NET 8.

Please try to use tag instead of specific commit in fetchFromGitHub

At the time of me initially packaging it, I encountered bugs and I submitted a pr to upstream. The pr was not merged at that time, so I used my own commit as rev temporarily. Now it has already been merged and included in a new release.
Just now I tried this:
{ fetchFromGitHub
, buildDotnetModule
, lib
, dotnetCorePackages
, gcc
, ncurses
, zlib
} :

let
  vmr = dotnetCorePackages.dotnet_8.vmr;
  sdk = dotnetCorePackages.dotnet_8.sdk;
in buildDotnetModule rec {
  pname = "asset-ripper";
  version = "1.0.11";
  src = fetchFromGitHub {
    owner = "AssetRipper";
    repo = "AssetRipper";
    rev = version;
    hash = "sha256-dfc1t2xw4RBEG882Xdhh8XP4y5aLMC7jUbkeIYDenxE=";
  };
  nativeBuildInputs = [ gcc vmr zlib ncurses ];
  dotnet-sdk = sdk;
  projectFile = "Source/AssetRipper.GUI.Free/AssetRipper.GUI.Free.csproj"; # #220985
  selfContainedBuild = true;
  nugetDeps = ./deps.nix;
  meta = with lib; {
    description = "A tool for extracting assets from Unity serialized files and asset bundles and converting them into the native Unity engine format.";
    homepage = "https://assetripper.github.io/AssetRipper/";
    license = licenses.gpl3;
    maintainers = with maintainers; [ ulysseszhan ];
    mainProgram = "AssetRipper";
    platforms = platforms.all;
  };
}

The error is now
asset-ripper> EXEC : error : Unable to load shared library 'jitinterface_x64' or one of its dependencies. In order to help diagnose loading problems, consider using a tool like strace. If you're using glibc, consider setting the LD_DEBUG environment variable: [/build/source/Source/AssetRipper.GUI.Free/AssetRipper.GUI.Free.csproj]
asset-ripper>   jitinterface_x64.so: cannot open shared object file: No such file or directory
asset-ripper>   libjitinterface_x64.so: cannot open shared object file: No such file or directory
asset-ripper>   jitinterface_x64: cannot open shared object file: No such file or directory
asset-ripper>   libjitinterface_x64: cannot open shared object file: No such file or directory
asset-ripper>   System.DllNotFoundException: Unable to load shared library 'jitinterface_x64' or one of its dependencies. In order to help diagnose loading problems, consider using a tool like strace. If you're using glibc, consider setting the LD_DEBUG environment variable:
asset-ripper>   jitinterface_x64.so: cannot open shared object file: No such file or directory
asset-ripper>   libjitinterface_x64.so: cannot open shared object file: No such file or directory
asset-ripper>   jitinterface_x64: cannot open shared object file: No such file or directory
asset-ripper>   libjitinterface_x64: cannot open shared object file: No such file or directory
asset-ripper>      at System.Runtime.InteropServices.NativeLibrary.LoadLibErrorTracker.Throw(String) + 0x46
asset-ripper>      at System.Runtime.InteropServices.NativeLibrary.Load(String, Assembly, Nullable`1) + 0xd7
asset-ripper>      at Internal.JitInterface.JitConfigProvider.<>c__DisplayClass5_0.<Initialize>b__0(String libName, Assembly assembly, Nullable`1 searchPath) + 0x157
asset-ripper>      at System.Runtime.InteropServices.NativeLibrary.LoadLibraryCallbackStub(String, Assembly, Boolean, UInt32) + 0xa0
asset-ripper>      at Internal.Runtime.CompilerHelpers.InteropHelpers.FixupModuleCell(InteropHelpers.ModuleFixupCell*) + 0x71
asset-ripper>      at Internal.Runtime.CompilerHelpers.InteropHelpers.ResolvePInvokeSlow(InteropHelpers.MethodFixupCell*) + 0x35
asset-ripper>      at Internal.JitInterface.CorInfoImpl.GetJitHost(IntPtr) + 0x30
asset-ripper>      at Internal.JitInterface.CorInfoImpl.Startup(CORINFO_OS) + 0x1f
asset-ripper>      at ILCompiler.RyuJitCompilationBuilder.ToCompilation() + 0x413
asset-ripper>      at ILCompiler.Program.Run() + 0x2825
asset-ripper>      at ILCompiler.ILCompilerRootCommand.<>c__DisplayClass227_0.<.ctor>b__0(ParseResult result) + 0x310
asset-ripper> /build/tmp.gP47nywV9f/.nuget/packages/microsoft.dotnet.ilcompiler/8.0.2/build/Microsoft.NETCore.Native.targets(308,5): error MSB3073: The command ""/build/tmp.gP47nywV9f/.nuget/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/8.0.2/tools/ilc" @"../0Bins/obj/AssetRipper.GUI.Free/Release/linux-x64/native/AssetRipper.GUI.Free.ilc.rsp"" exited with code 1. [/build/source/Source/AssetRipper.GUI.Free/AssetRipper.GUI.Free.csproj]

Seems related to #280923.

I have written a derivation that allowed me to use the program to successfully extract assets.
Some notes:

I have included a patch to change the logging location as the default location is in the read only nix store. Upstream issue needs to be filed as this is only a temporary hack.
I have disabled AoT compilation which seems to be fixed by #309409. I have not verified the fix.
I added pkgs.dbus.lib to buildInputs as it was required by libnfd.so.
libnfd.so needed patching to find dbus.lib which is why I have used autoPatchelfHook. But the hook tries to patch other executables which fails. I have worked around this by asking it to ignore all missing dependencies.
deps.nix was generated using the procedure listed in the reference manual.

@UlyssesZh Can you verify if this works for you?
{ pkgs ? import <nixpkgs> { system = builtins.currentSystem; }
, lib ? pkgs.lib
, buildDotnetModule ? pkgs.buildDotnetModule
, fetchFromGitHub ? pkgs.fetchFromGitHub
}:

buildDotnetModule rec {

  pname = "AssetRipper";

  version = "1.0.18";

  src = fetchFromGitHub {
    owner = "AssetRipper";
    repo = pname;
    rev = "${version}";
    hash = "sha256-kTYszFsGchRXED7pCn8D2RlN+7IwAhtKZycXXDoMkOA=";
  };

  patches = [
    (pkgs.writeText "assertripper.patch"
      ''
        diff --git a/Source/AssetRipper.IO.Files/Utils/TemporaryFileStorage.cs b/Source/AssetRipper.IO.Files/Utils/TemporaryFileStorage.cs
        index e5b8a41..1348dc5 100644
        --- a/Source/AssetRipper.IO.Files/Utils/TemporaryFileStorage.cs
        +++ b/Source/AssetRipper.IO.Files/Utils/TemporaryFileStorage.cs
        @@ -2,7 +2,7 @@

         public static class TemporaryFileStorage
         {
        -	private static string ExecutingDirectory => AppContext.BaseDirectory;
        +	private static string ExecutingDirectory => System.Environment.CurrentDirectory;

         	public static string LocalTemporaryDirectory { get; } = Path.Combine(ExecutingDirectory, "temp", GetRandomString()[0..4]);

        diff --git a/Source/AssetRipper.Import/Utils/ExecutingDirectory.cs b/Source/AssetRipper.Import/Utils/ExecutingDirectory.cs
        index 9a510a0..d15b81e 100644
        --- a/Source/AssetRipper.Import/Utils/ExecutingDirectory.cs
        +++ b/Source/AssetRipper.Import/Utils/ExecutingDirectory.cs
        @@ -4,7 +4,7 @@
         	{
         		static ExecutingDirectory()
         		{
        -			Info = new DirectoryInfo(AppContext.BaseDirectory);
        +			Info = new DirectoryInfo(System.Environment.CurrentDirectory);
         		}

         		public static DirectoryInfo Info { get; }
      '')
  ];

  nativeBuildInputs = [
    pkgs.autoPatchelfHook
  ];

  autoPatchelfIgnoreMissingDeps = [ "*" ];

  buildInputs = [
    pkgs.dbus.lib
  ];

  projectFile = "./Source/AssetRipper.GUI.Free/AssetRipper.GUI.Free.csproj";

  dotnetInstallFlags = [ "-p:PublishAot=false" ];

  nugetDeps = ./deps.nix;

  executables = [ "AssetRipper.GUI.Free" ];

  dotnet-sdk = pkgs.dotnetCorePackages.sdk_8_0;
  dotnet-runtime = pkgs.dotnetCorePackages.dotnet_8.aspnetcore;
}

@diadatp If this works for you, I think it would be better to open a PR and to continue discussing your packaging in your PR. I could try to package it based on your packaging, but I don't want to steal your work and currently don't have time for that.


username redaction broke, we should probably look into this

Report JSON: https://cpy.pt/JYm6auyZ

Apparently not a problem anymore.


FIX: attribute convention ala sklearn

sklearn naming convention is to have init params given by the subject without a _ at the end and attributes created by the method with a _.
e.g.
myclass = MyClass(foo=1)
myclass.foo
myclass.fit()
myclass.bar_

That's a lot of changes, some of which are backward incompatible, but I think it's generally safer to stick to their naming convention.

wow, thats a lot of works :)
i agree, the toolbox is still young so we can do this kind of change, and it's better to stick to the sklearn conventions.
Can you check the examples, i think i access internal variables to plot things.
Don't worry for travis, it's related to #19

Ok. I also removed the channel renaming in the examples, because mne-python doesn't allow manual renaming manually anymore https://github.com/mne-tools/mne-python/pull/1124

So far, i'm happy with this PR.
Perhaps we could add a "contribution guideline" in the Readme, stating the different conventions.
When your ready, update the What's new and i will merge.
Note that i plan to rewrite almost completly the stats functions in a near future (the code is old and too convoluted)

Ok. I haven't looked at the way stats work yet. I've kept the contribution guidelines minimalistic 1) because I'm lazy) and 2) because they can become super overwhelming. Most packages actually refer to an external doc.
BTW, you may want to go through all files with flake8.

Thanks.
File i edited recently are supposed to be Flake8 verified and properly documented.
There are only a few files where i did not finished it: stats.py and estimation.py + some of the examples.
This is actually one of my milestone to release a new major version (see #1)

all right thanks!


Major improvements to wasm-bindgen-futures

Sorry I'm late, I struggled with the multi-threading atomic stuff.
This PR contains a few major improvements:

Code duplication has been removed.

Everything has been refactored so that the implementation is much easier to understand.

future_to_promise is now implemented with spawn_local rather than the other way around (this means spawn_local is faster since it doesn't need to create an unneeded Promise).

Both the single threaded and multi threaded executors have been rewritten from scratch:

They only create 1-2 allocations in Rust per Task, and all of the allocations happen when the Task is created.

The singlethreaded executor creates 1 Promise per tick, rather than 1 Promise per tick per Task.

Both executors do not create Closures during polling, instead all needed Closures are created ahead of time.

Both executors now have correct behavior with regard to spurious wakeups and waking up during the call to poll.

Both executors cache the Waker so it doesn't need to be recreated all the time.

I believe both executors are now optimal in terms of both Rust and JS performance.

(The build failures don't seem related to this PR, except for the unix tests, which seem... really weird. It almost seems like a bug with anyref)

(@alexcrichton I fixed all your feedback btw)

I pushed up some stylistic feedback and tweaks that I figured would be easiest to go ahead and do myself. I debugged the issue with anyref and I think we'll need to fix that somehow before this lands. Looks like Promise.resolve wasn't previously used in the wasm-bindgen test suite, and it's now used transitively through wasm-bindgen-futures. The anyref pass means that Promise.resolve is directly imported, as-is, into the wasm module. This is, however, invalid:
> Promise.resolve(1)
Promise { 1 }
> x = Promise.resolve
[Function: resolve]
> x(1)
Thrown:
TypeError: PromiseResolve called on non-object
    at resolve (<anonymous>)

We have to call resolve via dot-notation or somehow set the this parameter, so the wasm-bindgen optimization to directly import Promise.resolve is not actually valid. I'm not sure the best way to fix that at this time.

I'm not sure the best way to fix that at this time.

Yeah, that's tricky. Can we somehow special-case static_method_of so it doesn't get the optimization? Just as a temporary solution until we get proper WebIDL integration.

Yeah that seems reasonable to me!

@Pauan have you had a chance to take a look at this again? Do you want some help in fixing importing Promise?

@alexcrichton I did take a look, but the anyref optimizations are over my head, so some help would be appreciated.

Sure thing, I've posted https://github.com/rustwasm/wasm-bindgen/pull/1795 to fix imports of static_method_of to ensure that this is set correctly.

👍
All green now!


About hand_landmark models postprocess course have some problems

I use a open source hand_detect model to detect hand and crop detect_box for hand_landmark model input. I find this model output landmark is error.Maybe my postprocess is error.Do you have any useful post-processing methods?

@NeekHua  any anaswers on this


Can the library of multiprocessing and modin be used simultaneously?

Describe the problem
My code has bug when i use modin. I wonder Can the library of multiprocessing and modin be used simultaneously？
Source code / logs
Process STDOUT and STDERR is being redirected to /tmp/ray/session_2019-04-14_23-15-00_7571/logs.
Waiting for redis server at <IP_ADDRESS>:36216 to respond...
Waiting for redis server at <IP_ADDRESS>:19632 to respond...
Starting Redis shard with 10.0 GB max memory.
Starting the Plasma object store with 5.0 GB memory using /tmp.
File "/Users/apple/anaconda3/lib/python3.6/site-packages/modin/pandas/dataframe.py", line 4736, in getattr
if key in self.columns:
File "/Users/apple/anaconda3/lib/python3.6/site-packages/modin/pandas/dataframe.py", line 185, in _get_columns
return self._query_compiler.columns
File "/Users/apple/anaconda3/lib/python3.6/site-packages/modin/pandas/dataframe.py", line 4736, in getattr
if key in self.columns:
File "/Users/apple/anaconda3/lib/python3.6/site-packages/modin/pandas/dataframe.py", line 185, in _get_columns
return self._query_compiler.columns
File "/Users/apple/anaconda3/lib/python3.6/site-packages/modin/pandas/dataframe.py", line 4736, in getattr
if key in self.columns:
File "/Users/apple/anaconda3/lib/python3.6/site-packages/modin/pandas/dataframe.py", line 185, in _get_columns
return self._query_compiler.columns
File "/Users/apple/anaconda3/lib/python3.6/site-packages/modin/pandas/dataframe.py", line 4736, in getattr
if key in self.columns:
File "/Users/apple/anaconda3/lib/python3.6/site-packages/modin/pandas/dataframe.py", line 185, in _get_columns
return self._query_compiler.columns
File "/Users/apple/anaconda3/lib/python3.6/site-packages/modin/pandas/dataframe.py", line 4734, in getattr
return object.getattribute(self, key)
RecursionError: maximum recursion depth exceeded while calling a Python object

Hi @king21guns, thanks for posting!
What was the line of code that triggered the error? What version of Modin are you using? I am not able to reproduce the error locally with the information here.
To your question:

I wonder Can the library of multiprocessing and modin be used simultaneously?

I don't think it will work very well right now because currently, Modin DataFrames can't be pickled. Modin itself is using Ray to do the multiprocessing under the hood, so depending on your workflow, multiprocessing a Modin DataFrame might be slower than using Modin natively. I realize some workflows depend on Multiprocessing for things other than performance, so in the future we do plan to allow Modin DataFrames to be pickled.

Hi @king21guns, thanks for posting!
What was the line of code that triggered the error? What version of Modin are you using? I am not able to reproduce the error locally with the information here.
To your question:

I wonder Can the library of multiprocessing and modin be used simultaneously?

I don't think it will work very well right now because currently, Modin DataFrames can't be pickled. Modin itself is using Ray to do the multiprocessing under the hood, so depending on your workflow, multiprocessing a Modin DataFrame might be slower than using Modin natively. I realize some workflows depend on Multiprocessing for things other than performance, so in the future we do plan to allow Modin DataFrames to be pickled.

Thanks for your reply!

Is there a way to check if a certain set of tasks that going to be used on a data frame are within modin's repertoire?  Therefore this would allow a pandas dataframe to be converted to modin if it is possible to utilize modin for certain tasks, but then transfer the data to a pandas dataframe with mulitprocessing to finish the computation.

That's an interesting question @chaxor, there's no programmatic way to do it right now.
We do have a documentation page that lists these: https://modin.readthedocs.io/en/latest/pandas_supported.html
What kinds of tasks are you wanting to do in multiprocessing? In the question above, I assumed it would be for use with another library, but if you're hand-rolling some multiprocessing code, it may be useful to put that code into Modin for everyone to use.

Duplicate of #672


Associating app to the Windows Store

[Enter feedback here]
I am trying to register a sample windows app at the partner center (Windows store) https://partner.microsoft.com/en-us/dashboard/directory .
I don't see any view where I can do this app creation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5b48be73-2f29-6b2a-c837-751d3862bcdb
Version Independent ID: efd00d73-1ff5-8689-8415-fe1630795123
Content: Send notifications to Universal Windows Platform apps using Azure Notification Hubs
Content Source: articles/notification-hubs/notification-hubs-windows-store-dotnet-get-started-wns-push-notification.md
Service: notification-hubs
GitHub Login: @sethmanheim
Microsoft Alias: sethm

@venkateshkuppusamy Thanks for the feedback! We are taking a look into this and will get back to you soon.

@venkateshkuppusamy Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

As we are moving to a new feedback system, please reopen this issue or contact Microsoft Support if you still want to provide feedback on the documentation. Thank you! #please-close


[TfLite] C++ tflite::InterpreterBuilder is missing in version r1.12

Hi, I'm using the tflite library from version r1.12. However, I followed the guide in official doc:
// Create model from file. Note that the model instance must outlive the
// interpreter instance.
auto model = [tflite::FlatBufferModel::BuildFromFile](https://tensorflow.google.cn/lite/api_docs/cc/class/tflite/flat-buffer-model#classtflite_1_1_flat_buffer_model_1aa38cad2bc62ae19a647c64f10226862b)(...);
if (model == nullptr) {
  // Return error.
}
// Create an [Interpreter](https://tensorflow.google.cn/lite/api_docs/cc/class/tflite/interpreter#classtflite_1_1_interpreter) with an [InterpreterBuilder](https://tensorflow.google.cn/lite/api_docs/cc/class/tflite/interpreter-builder#classtflite_1_1_interpreter_builder).
std::unique_ptr interpreter;
tflite::ops::builtin::BuiltinOpResolver resolver;
if (InterpreterBuilder(*model, resolver)(&interpreter) != kTfLiteOk) {
  // Return failure.
}
if (interpreter->AllocateTensors() != kTfLiteOk) {
  // Return failure.
}

It seems that the interpreterBuilder.h file is missing in the r1.12 version. In this case, what should I do to create an interpreter with a specified model in r1.12? Thanks.

@BILLXZY1215 We could see you are using tflite under contrib directory which is not actively supported, and contrib is depreciated. We recommend you to kindly  use the latest version.Thanks!

Okay, I see, thanks!

@BILLXZY1215 Could you please move this issue to closed  status if it is resolved for you?
Thanks!

Are you satisfied with the resolution of your issue?
Yes
No


groups: fixes to pass GNU's Testsuite

This passes the relevant tests for groups from GNU's Testsuite that currently fail on master branch.
============================================================================
Testsuite summary for GNU coreutils 8.32.162-4eda
============================================================================
PASS: tests/misc/groups-dash.sh
PASS: tests/misc/groups-process-all.sh

add new feature to support multiple users (introduced in coreutils 8.31)
sync help text with GNU's groups manpage
add tests for everything

@rivy Thanks for your feedback and doing the review.

Clippy isn't happy

error[E0425]: cannot find value `VERSION_MULTIPLE_USERS` in this scope
  --> /home/runner/work/coreutils/coreutils/tests/by-util/test_groups.rs:81:66
   |
12 | const VERSION_MIN_MULTIPLE_USERS: &str = "8.31"; // this feature was introduced in GNU's coreutils 8.31
   | ------------------------------------------------ similarly named constant `VERSION_MIN_MULTIPLE_USERS` defined here
...
81 |     let version_check_string = check_coreutil_version(util_name, VERSION_MULTIPLE_USERS);
   |                                                                  ^^^^^^^^^^^^^^^^^^^^^^
   |
help: a constant with a similar name exists
   |
81 |     let version_check_string = check_coreutil_version(util_name, VERSION_MIN_MULTIPLE_USERS);
   |                                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^
help: consider importing this constant
   |
1  | use crate::test_id::VERSION_MULTIPLE_USERS;
   |

Cool
Move from
GNU tests summary = TOTAL: 601 / PASS:  169 / FAIL:  321 / ERROR: 25
to
GNU tests summary = TOTAL: 601 / PASS:  171 / FAIL:  319 / ERROR: 25

@sylvestre #2361 also brought two new PASSES, but those were way harder to achieve.

If you don't mind, rebase this off of #2452 when it's merged and the spelling errors will be fixed.
Thanks for the work!


Allow to skip the Splash Screen

Currently the app always displays the Splash Screen. Make this optional.

Added in c99651d


[cleanup] remove --use-cached-print-dev-env from shellenv

Summary
This flag used to be used by bin-wrappers, but has been removed as of 0.4.8
cc @mikeland86
How was it tested?
compiles

Current dependencies on/for this PR:

main

PR #1153   👈

This comment was auto-generated by Graphite.


condition is not used in the model error.

I am doing modular model development and I need to add conditions but when I use the word condition I get the following error.

@rhamzeh

@xXAvoraXx
Conditions need to be defined in the module where they are being used for now.

@xXAvoraXx
Conditions need to be defined in the module where they are being used for now.

I tested it again and it gives the same error when I define a 'condition'.

non_expired_grant condition is not used in the model.

Are you using the condition in the model? Can you paste the full module?

Are you using the condition in the model? Can you paste the full module?

In schema: '1.2' the 'conditions' don't work but if I make schema: '1.1' the 'condition' works but this time the 'module' doesn't work. In short, In short, it doesn't matter what the authorization scheme is.
module core

type user

type group
  relations
    define assignee: [parent_group, member_group]
    define blocked: [user, role#direct_access, parent_group#direct_access, member_group#direct_access]

    define direct_access: (assignee or direct_access from assignee) but not blocked
    define indirect_access: indirect_access from assignee but not blocked
    define can_access: indirect_access

type parent_group
  relations
    define parent: [parent_group, role]
    define sibling: [parent_group, role]
    define blocked: [user, role#direct_access, parent_group#direct_access] # Grubun Kaynaklara erisiminin ebeveynlere aktarilmasinin kisitlanmasi.

    define direct_access: ((parent or sibling) or (direct_access from parent or direct_access from sibling)) but not blocked
    define indirect_access: (indirect_access from parent or indirect_access from sibling) but not blocked
    define can_access: indirect_access

type member_group
  relations
    define member: [member_group, role]
    define blocked: [user, role#direct_access, member_group#direct_access] # Grubun Kaynaklara erisiminin cocuklara aktarilmasinin kisitlanmasi.

    define direct_access: (member or direct_access from member) but not blocked
    define indirect_access: indirect_access from member but not blocked
    define can_access: indirect_access

type role
  relations
    define parent: [role, parent_group]
    define sibling: [role, parent_group]
    define member: [user]
    define blocked: [user, role#direct_access, parent_group#direct_access]

    define direct_access: (member or parent or sibling) but not blocked
    define indirect_access: (direct_access or (indirect_access from parent or indirect_access from sibling)) but not blocked
    define can_access: indirect_access

condition non_expired_grant(current_time: timestamp, grant_time: timestamp, grant_duration: duration) {
  current_time < grant_time + grant_duration
}

@xXAvoraXx is there another file using this condition? It does not seem to be used in this file

@xXAvoraXx is there another file using this condition? It does not seem to be used in this file

It doesn't matter if it is used, VS-Code gives this error when I make the definition, I just need to write the word 'condition'.

@xXAvoraXx is there another file using this condition? It does not seem to be used in this file

It was giving an error because I didn't use the function, it's all my fault, I apologize. I was stuck on why it gave an error when I defined 'condition', I didn't think it gave an error because I didn't use it.


Add GoldenCheetah

Added the GoldenCheetah deb.
Not fully tested, but starts and seems to work properly for now.

[Desktop Entry]
Version=1.0
Type=Application
Name=GoldenCheetah
Comment=Cycling Power Analysis Software.
TryExec=/usr/bin/GoldenCheetah
Exec=GoldenCheetah.wrapper
Icon=/usr/share/pixmaps/gc
Keywords=Cycling;Training;Bike;Ride
I'm not getting the error though

Also, please remove all hardcoded paths from the desktop file.

I can't get the icon to show up in the menu, did I get something wrong?

Sometimes it is needed to log out and log in into the GNOME/KDE/... session.

Even if I log out the icon is still missing. In the yml file I copy the icon in the root folder, is that not correct?

Are you using the optional appimaged daemon? It's a plus if you are interested in smooth and automatic desktop integration.
For the menu thing to work, an icon should also be e.g., in ./usr/share/icons/hicolor/256x256/apps/goldencheetah.png.

I tried copying the icon in usr/share/pixmaps, but I still get no icon, with or without appimaged(a great tool by the way, is is possible to configure it? to add/remove folders to watch)

Please put the icon into ./usr/share/icons/hicolor/256x256/apps/goldencheetah.png inside the AppImage.

appiaged is currently not user-configurable, but the watched directories are listed in its README.md.

The icon is working now!

I can't fully test it at the moment, but it seems to be mostly working, and since it uses gstreamer0.10, not available in ubuntu 16.10, at least it starts now ;)

Still need to fix that desktop file. https://standards.freedesktop.org/desktop-entry-spec/latest/

desktop-file-validate doesn't output anything.. what's wrong with it?

TryExec=/usr/bin/GoldenCheetah # Not needed; also don't hardcode absolute paths
Icon=/usr/share/pixmaps/gc # Don't hardcode absolute paths
Keywords=Cycling;Training;Bike;Ride # You completely made these up, right? Need to use categories from the spec

I remove the TryExec, sed the Icon line to remove the path and the categories are the ones the creators of the package made up, not me.

I set it to Categories=Utility;Sports;DataVisualization;

That's not supposed to happen:
Marking the AppImage as executable...
Success
+ mkdir -p ../out/
+ mv GoldenCheetah-.glibc2.15-x86_64.AppImage ../out/
+ ls -lh ../out/GoldenCheetah-.glibc2.15-x86_64.AppImage
-rwxr-xr-x 1 me me 56M Mar 22 19:55 ../out/GoldenCheetah-.glibc2.15-x86_64.AppImage
me@host:~$ ./out/GoldenCheetah-.glibc2.15-x86_64.AppImage
/tmp/.mount_QQTPPO/usr/bin/GoldenCheetah: error while loading shared libraries: libvlc.so.5: cannot open shared object file: No such file or directory

Sorry...I was building in a vm but running in my system...so that was not an issue.
Should be good now. I'll check in a vm and let you know.

in a centos6 live vm I get
fuse: failed to exec fusermount: Permission denied
Is this normal?

It still won't run because of a version of libc6 that is too old.

It will run only on systems no older than the build system.

I tried to set precise in the yml file. Do I have to build it in precise itself?
it still won't work in centos6 (needs newer than 2.15 version of glibc)

Yes, the ingredients also must be build on an old enough system.

So I can now build it on precise, nothing earlier, so centos6 is out I guess.
One issue remains:
In the "open with" menu, the icon used is the bigger one hardcoded in the .desktop file.
Should I use a smaller icon or is there a better way?

Can you provide a screenshot please?

Sure: https://snag.gy/vcuW2k.jpg

Also, with appimaged I get another error:
Error moving file: Error moving file /tmp/appimagekit_d1d95c679cfc6626c7cb4baeba757e5a_goldencheetah.png: No such file or directory

Please try putting in all resolutions into the usr/share/icons subdirectories in the AppDir.

Sorry, my bad, the icon is only one (in the deb it's in pixmaps)

I removed the sed command as per commit #212
The only issue remaining is the large icon.

The icon in the open with dialog is an issue with caja file manager.
It works properly with nautilus, and there is an open bug in caja (https://github.com/mate-desktop/caja/issues/735)

Thanks for the clarification @LyzardKing

I removed the semicolon fix, I thought that was fixed with #211 and #212. Am I wrong?

@probonopd I can revert the semicolon change if it's needed, I thought it was not needed anymore, and included in the Recipe script

@probonopd Done.

ubuntu doesn't show any error when building though..
Do I need to run with any option to get the desktop-file validation or should that happen automatically?

Does it really need libgstreamer0.10-0 and libgstreamer-plugins-base0.10-0?

Launching the resulting AppImage gives
R_HOME has not been configured in options or the system environment so we looked in the common places to find the R install.

We failed to find the R shared libraries.
The dynamic library load failed.

R has now been disabled in options.

the need for libgstreamer0.10 is why it won't work in newer versions of ubuntu.

OK, so we definitely leave libgstreamer0.10 in :-)

I'm not getting the R error...

Also, please add at the end of the script: section inside the ingredients: section:
    - echo "$DEB" | cut -d "_" -f 2 | sed -e 's|V||g' > VERSION

Then the AppImage file will have the version number in the filename.

I'm not getting the R error...

Make sure you delete all your pre-existing GoldenCheetah settings prior to running it

I tried removing all traces of goldencheetah, starting from the terminal and adding some fake data but still, no error.
Ill try on a live system now to be sure. On what distro are you testing it?
I added the version.

I checked the dependencies of the deb.
Depends: libsamplerate0, openssl, libusb-1.0-0, vlc, r-base-core,
libglu1-mesa, libgstreamer0.10-0, libgstreamer-plugins-base0.10-0
Should I just add them all or are some of them considered base?

@probonopd I'd add libsamplerate0, libusb-1.0-0, libvlc5, r-base-core, libgstreamer0.10-0, libgstreamer-plugins-base0.10-0
Avoiding openssl, libglu1-mesa (base?) and the full vlc (not needed as far as I can tell)

I checked the dependencies of the deb.

These are handled automatically, no need to do anything.
I am running xubuntu-16.04-desktop-amd64.iso at the moment.

Ok, so r-base should be added, and that's why it's not giving any error...
Not sure why it's failing for you.
It's working on ubuntu-mate 16.10 and 17.04

I had added the version. I was just waiting to download a version of Ubuntu 16.04 to test it before pushing the commit

Tools -> Options -> Enable R

I think this is the culprit:
https://github.com/GoldenCheetah/GoldenCheetah/blob/1a19fa46fe1bfe3daa809314f7d9dca39081aba8/src/R/RLibrary.cpp#L311-L315
#ifdef Q_OS_LINUX
    // use the standard location
    if (home == "") home = "/usr/lib/R";
    name = "lib/libR.so";
#endif

It should be changed to look at a location relative to the main executable as well, rather than (only) in hardcoded /usr.

Would this be something that you can explain in an issue for the project? I can do it tomorrow..
Also..Why would it be failing on your system but not mine?

Possibly because you have R installed in the /usr in your system?

I wasn't removing the wrong config files, I guess it must have shown me the error the first time as well.
@probonopd I guess you can better explain the advantage of having an appimage. And how to fix the hardcoded part.
I guess this is the last thing we need, right?

Or in the meantime we could define R_HOME to point to the one in the appimage, right?

I guess this is the last thing we need, right?

Yes, I think so.

Or in the meantime we could define R_HOME to point to the one in the appimage, right?

Possibly yes, if we knew where it would have to point to...

I believe R_HOME should point to usr/lib/R (in the appimage)
There is no ticket atm

How can I set an environment variable in an appimage?

Most pragmatically, write a custom bash launcher script, set that in Exec= of the desktop file, and have that call the real executable.

@probonopd Something like this?

echo -e '#!/bin/sh\nR_HOME=$APPIMAGE/usr/lib/R\n$APPIMAGE/usr/bin/GoldenCheetah' > $APPIMAGE/usr/bin/gc_launcher
sed -i -e 's|Exec=/usr/bin/GoldenCheetah\n|Exec=/usr/bin/gc_launcher.sh|g' goldencheetah.desktop

more like
    echo -e '#!/bin/sh\nR_HOME=$APPIMAGE/usr/lib/R\n$APPIMAGE/usr/bin/GoldenCheetah' > $APPIMAGE/usr/bin/gc_launcher
    sed -i -e 's|Exec=/usr/bin/GoldenCheetah\n|Exec=gc_launcher.sh|g' goldencheetah.desktop

Editted the above

I get: /tmp/recipe_script: line 6: /usr/bin/gc_launcher: Permission denied
when it tries to create the launcher

Sure, need chmod a+x usr/bin/gc_launcher as well. Updated comment above.

I still get the same error..
could it be that this:
    echo -e '#!/bin/sh\nexport R_HOME=$APPIMAGE/usr/lib/R\nexec GoldenCheetah "$@"' > $APPIMAGE/usr/bin/gc_launcher
has to be this:
    echo -e '#!/bin/sh\nexport R_HOME=$APPIMAGE/usr/lib/R\nexec GoldenCheetah "$@"' > usr/bin/gc_launcher

Oh yes, good catch!

with that it builds, but it still seems to have the same R_HOME issue

@probonopd Is it possible to verify that GoldenCheetah.wrapper is
actually launching the correct thing(our modifued launcher in this case)

@probonopd The appimage does not contain the dependencies of the .deb.
See the image to confirm the content.
This directory should contain the R folder installed by r-base-core.
In fact, we shouldn't need to add gstreamer or vlc, since also those are dependencies of the .deb

Check https://bintray.com/probono/AppImages/GoldenCheetah#files

@probonopd Seems to work now if I download from bintray, can I ask what changed?
Also, in mate, appimaged restarts the panel. This is not needed, since the menu is updated automatically if a .desktop file is added.

@probonopd Seems to work now if I download from bintray, can I ask what changed?

Please see https://github.com/probonopd/AppImages/blob/master/recipes/meta/GoldenCheetah.yml


GEODE-9204: thread hung waiting for response

The original PR #6392 was closed because I took over the work on this ticket.
A not serializable exception can cause a ServerConnection thread to get stuck
waiting for a reply from another member. This is caused by ReplyMessage
not handling a non-serializable "returnValue".
The fix is to catch and log the exception in the sending node and then
handle the problem in the receiving node.
I would have liked to serialize the "returnValue" field into a separate buffer
so as not to transmit a partial serialization of the object but that would require
an extra buffer copy for every ReplyMessage sent, and we send a lot of them.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

@BenjaminPerryRoss @boglesby @gesterzhou @kirklund @nabarunnag @pivotal-eshu Could you please take a look at this PR?

@kamilla1201
Other options myself and @dschneider-pivotal were considering about:
Is this issue very specific to cache loader? in that case, let's check if the value is serializable as part of load, if not then send error response back to the caller.
@dschneider-pivotal Is it a safe assumption to make, anything we load through the cache-loader needs to be serializable...If not, then we may have to see if its serializable based on the thread/caller ?

It is possible to have a loader on a local region in which case it would not need to be serializable. It is safer to defer the check until it is being serialized.

Need to run performance tests before merging this PR


Float/unfloat plugin dockwidgets on first show

Description

Type of change

[x] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

Fixes #3624
How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

It seems that after a float/unfloat operation it no longer happens, so I added this programmatically on first registration 🤷🏼
@brisvag could you check it works :) ?
Thanks!

Wow! How'd you figure out this solution... how does the float/unfloat fix it?

Wow! How'd you figure out this solution...

I wished I had a better answer,... I tried some stuff until I bumped into this one.

how does the float/unfloat fix it?

I have no idea!

What! Yep, looks like it's solved :rofl:


Integrate prometheus-eval into RAGAS

Summary
This PR introduces the integration of Prometheus metrics into the RAGAS framework, starting with the implementation of the absolute grading method. Prometheus is a family of open-source language models that specialize in evaluating other language models.
Implementation Details

Absolute Grading Method: The Prometheus integration currently supports the absolute grading method, which scores the response based on detailed feedback aligned with a predefined rubric.

from ragas import evaluate
from datasets import Dataset
from ragas.metrics._prometheus import Prometheus, PrometheusMode

from langchain.chat_models import ChatOpenAI
from ragas.llms import LangchainLLM

inference_server_url = "http://localhost:8080/v1"

# create vLLM Langchain instance
chat = ChatOpenAI(
    model="prometheus-eval/prometheus-7b-v2.0",
    openai_api_key="no-key",
    openai_api_base=inference_server_url,
    max_tokens=5,
    temperature=0,
)

# use the Ragas LangchainLLM wrapper to create a RagasLLM instance
vllm = LangchainLLM(llm=chat)

# Expanded sample data with ten questions and contexts for all
data_samples = {
    'question': [
        'When was the first Super Bowl?',
        'Who won the most Super Bowls?',
        'Struggling with a recent break-up, a person opens up about the intense feelings of loneliness and sadness. They ask for advice on how to cope with the heartbreak and move forward in life.',
        'What team has appeared in the most Super Bowls?',
        'Who holds the record for most passing yards in a single Super Bowl game?',
        'A user expresses anxiety about an upcoming job interview and asks for advice on how to calm their nerves and perform well.',
        'What is the highest-scoring Super Bowl game in history?',
        'Who has the most Super Bowl MVP awards?',
        'A person shares their struggle with procrastination and asks for tips to improve their productivity.',
        'What was the longest field goal in Super Bowl history?'
    ],
    'answer': [
        'The first Super Bowl was held on Jan 15, 1967.',
        'The New England Patriots have won the most Super Bowls with 6 championships.',
        "I'm genuinely sorry to hear about your break-up. This can be an immensely challenging time filled with intense emotions of loneliness and sorrow. ...",
        'The New England Patriots have appeared in the most Super Bowls, with 11 appearances.',
        'Tom Brady holds the record for most passing yards in a single Super Bowl game with 505 yards in Super Bowl LII.',
        "It's completely normal to feel anxious before a job interview. Here are some strategies to help calm your nerves: ...",
        'The highest-scoring Super Bowl was Super Bowl XXIX, with a combined score of 75 points.',
        'Tom Brady has won the most Super Bowl MVP awards with 5.',
        "Procrastination can be a challenging habit to overcome. Here are some strategies that might help you improve your productivity: ...",
        'The longest field goal in Super Bowl history is 55 yards, achieved by Steve Christie in Super Bowl XXVIII.'
    ],
    'ground_truth': [
        'The first Super Bowl, then called the AFL-NFL World Championship Game, was played on January 15, 1967, at the Los Angeles Memorial Coliseum.',
        'As of 2023, the New England Patriots and the Pittsburgh Steelers are tied for the most Super Bowl wins with 6 championships each.',
        "I can only imagine how difficult this time must be for you. Heartbreak can feel like an overwhelming wave that washes over you, making you feel lost and alone. ...",
        'The New England Patriots have appeared in the most Super Bowls, with 11 appearances as of 2023.',
        'Tom Brady holds the record for most passing yards in a single Super Bowl game with 505 yards, achieved in Super Bowl LII (2018) while playing for the New England Patriots.',
        "It's perfectly normal to feel nervous before a job interview. Here are some effective strategies to manage your anxiety and perform your best: ...",
        'The highest-scoring Super Bowl was Super Bowl XXIX in 1995, with the San Francisco 49ers defeating the San Diego Chargers 49-26, for a combined score of 75 points.',
        'Tom Brady has won the most Super Bowl MVP awards with 5, achieved in Super Bowls XXXVI, XXXVIII, XLIX, LI, and LV.',
        "Procrastination is a common struggle. Here are some evidence-based strategies to help improve your productivity: ...",
        'The longest field goal in Super Bowl history is 55 yards, achieved by Steve Christie of the Buffalo Bills in Super Bowl XXVIII in 1994.'
    ],
    'contexts': [
        ['The First AFL–NFL World Championship Game, later known as Super Bowl I, was played on January 15, 1967, at the Los Angeles Memorial Coliseum in Los Angeles, California.'],
        ['The New England Patriots and the Pittsburgh Steelers are tied for the most Super Bowl wins in NFL history, with each team having won six championships.'],
        ['Break-ups can be emotionally devastating, often leading to feelings of loneliness, sadness, and loss. Coping strategies may include allowing oneself to grieve, seeking support from friends and family, engaging in self-care activities, and potentially seeking professional help if needed.'],
        ['The New England Patriots hold the record for most Super Bowl appearances with 11, followed by the Denver Broncos with 8 appearances.'],
        ['In Super Bowl LII, Tom Brady of the New England Patriots set the record for most passing yards in a single Super Bowl game with 505 yards, despite losing to the Philadelphia Eagles.'],
        ['Job interview anxiety is a common experience. Preparation techniques can include researching the company, practicing common interview questions, using relaxation techniques like deep breathing, and focusing on ones strengths and qualifications.'],
        ['Super Bowl XXIX, played on January 29, 1995, saw the San Francisco 49ers defeat the San Diego Chargers 49-26, resulting in the highest combined score in Super Bowl history at 75 points.'],
        ['Tom Brady has been named Super Bowl MVP five times, more than any other player in NFL history. He won the award with the New England Patriots in Super Bowls XXXVI, XXXVIII, XLIX, and LI, and with the Tampa Bay Buccaneers in Super Bowl LV.'],
        ['Procrastination is a common productivity challenge. Effective strategies to combat it include breaking tasks into smaller, manageable parts, using time management techniques like the Pomodoro Technique, setting clear goals and deadlines, and addressing underlying causes such as perfectionism or fear of failure.'],
        ['The record for the longest field goal in Super Bowl history is held by Steve Christie of the Buffalo Bills, who kicked a 55-yard field goal in Super Bowl XXVIII against the Dallas Cowboys on January 30, 1994.'],
    ],
}

# Create dataset
dataset = Dataset.from_dict(data_samples)

# Define rubrics (unchanged)
rubric_data_factual = {
    "criteria": "Is the model proficient in providing accurate and relevant answers to factual questions about the Super Bowl?",
    "score1_description": "The model provides completely incorrect or irrelevant information, showing no understanding of the Super Bowl-related questions.",
    "score2_description": "The model provides partially correct information but with significant errors or omissions, demonstrating limited understanding of Super Bowl facts.",
    "score3_description": "The model provides mostly correct information with minor inaccuracies or incompleteness, showing a basic understanding of Super Bowl facts.",
    "score4_description": "The model provides accurate and relevant information, demonstrating a good understanding of Super Bowl facts, but may lack some specific details.",
    "score5_description": "The model excels in providing highly accurate, complete, and relevant information, demonstrating a comprehensive understanding of Super Bowl facts and history."
}

rubric_data_empathy = {
    "criteria": "Is the model proficient in applying empathy and emotional intelligence to its responses when the user conveys emotions or faces challenging circumstances?",
    "score1_description": "The model neglects to identify or react to the emotional tone of user inputs, giving responses that are unfitting or emotionally insensitive.",
    "score2_description": "The model intermittently acknowledges emotional context but often responds without sufficient empathy or emotional understanding.",
    "score3_description": "The model typically identifies emotional context and attempts to answer with empathy, yet the responses might sometimes miss the point or lack emotional profundity.",
    "score4_description": "The model consistently identifies and reacts suitably to emotional context, providing empathetic responses. Nonetheless, there may still be sporadic oversights or deficiencies in emotional depth.",
    "score5_description": "The model excels in identifying emotional context and persistently offers empathetic, emotionally aware responses that demonstrate a profound comprehension of the user's emotions or situation."
}

# Create Prometheus metric instances for different scenarios
prometheus_metric_factual = Prometheus(
    llm=vllm,
    mode=PrometheusMode.ABSOLUTE,
    rubrics=rubric_data_factual,
)

prometheus_metric_empathy = Prometheus(
    llm=vllm,
    mode=PrometheusMode.ABSOLUTE,
    rubrics=rubric_data_empathy,
)

# Evaluate
result_factual = evaluate(
    dataset.select([0,1,3,4,6,7]),
    metrics=[prometheus_metric_factual],
)

result_empathy = evaluate(
    dataset.select([2, 5, 8]),
    metrics=[prometheus_metric_empathy],
)

print("Factual Evaluation Result:\n", result_factual.scores.to_pandas())
print("Empathy Evaluation Result:\n", result_empathy.scores.to_pandas())

Thanks for the PR @vaishakhRaveendran
I checked some of the Prometheus models and unfortunately, none of them seem to be fine-tuned for JSON output. I have made this to their notice - issue.
For now lets implement this as model agnostic metric and allow users to Prometheus style evaluation


;removed one word and added two others, please read description

tweeked advertisement again. It is more true to form if we leave it the way Eloquence was created :). Added Blytheville--yes there's a town that pronounces it this way. Added remembrall from Harry Potter
Also, I added the following:
Epicaricacy	`[1Ep.0xk.0xr.1Ik.0kx.2si]
This is a real word and I'm not sure if I've got the syllables correct. Please verify.

Sorry I added three words, removed one.

@nromey Thanks for your additions and commits! I then made a few corrections to them in a newer commit, so you may want to grab the newer ENURoot for comparison. A couple of notes:

Two of the words added to Root were capitalized. Words in Root shouldn't be capitalized because they will be rejected by the synthesizer. So make all words lowercase there.
The replacement for "epicaricacy" had two syllables beginning with .1. Since .1 indicates the primary stress, words should contain one of them because Eloquence will pronounce them strangely especially in continuous reading. As you know, in English words have one syllable carrying the primary stress, so here the rules work hand in hand. Here epicaricacy should be transcribed this way: `[2E.0pX.0kx.1rI.0kx.0si]
Looking forward to your upcoming commits.

Hey cool. Thanks for fixing things and guiding me.  Sorry about that capitalization thing.  I knew, but forgot this time. Continue to love learning.
NER
From: amirsol81 @.>
Sent: Tuesday, July 4, 2023 5:34 PM
To: thunderdrop/IBMTTSDictionaries @.>
Cc: nromey @.>; Mention @.>
Subject: Re: [thunderdrop/IBMTTSDictionaries] ;removed one word and added two others, please read description (PR #39)
@nromey https://github.com/nromey  Thanks for your additions and commits! I then made a few corrections to them in a newer commit, so you may want to grab the newer ENURoot for comparison. A couple of notes:

Two of the words added to Root were capitalized. Words in Root shouldn't be capitalized because they will be rejected by the synthesizer. So make all words lowercase there.
The replacement for "epicaricacy" had two syllables beginning with .1. Since .1 indicates the primary stress, words should contain one of them because Eloquence will pronounce them strangely especially in continuous reading. As you know, in English words have one syllable carrying the primary stress, so here the rules work hand in hand. Here epicaricacy should be transcribed this way: `[2E.0pX.0kx.1rI.0kx.0si]
Looking forward to your upcoming commits.

—
Reply to this email directly, view it on GitHub https://github.com/thunderdrop/IBMTTSDictionaries/pull/39#issuecomment-1620798906 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AFB7LSOAYSGY2VWXE65WWGLXOSK7DANCNFSM6AAAAAAZ57YJGE .
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/AFB7LSOBIND5OKQKVALAUVDXOSK7DA5CNFSM6AAAAAAZ57YJGGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTATNW3U.gif Message ID: @.*** @.***> >

@nromey You're most welcome. Way to go!


Consuming the underlying storage topic continuously even for master normal operation

After booting, the consumer on the master partition is stopped and only the standbys keep their consumer open. However it would be beneficial if the master also continued consuming as any external update would automatically reflect in the memstore without having to restart.
The issue that need to be addressed though are:

if the master receives a write during normal operation and updates the memstore, the consumer will immediately read this update and write the memstore again which will not lead to inconsistency but feels inefficient

we will need to maintain a true watermark for each replica to decide which update is bootstrap and which is a new update that needs to be forwarded to mediators

maintaining a watermark can solve 1) by bumping the watermark before the write and it could help determine when read replicas are ready for operation by comparing master watermark with their own.

The problem that this issue is addressing disappears if we make the actor system the sole owner of the writes. That way the bulk updates to the system can be seen as a second interface besides the http interface, i.e. a consumer on a update topic. Closing in favour of creating a general streaming interface for writes that sits before the akka layer, next to the akka-http component.


wip: proxied slts

This is a pretty cool idea, and I think would improve our test coverage.
Is there anything, in particular blocking this?


Fix #269 FP on rule TrailingCommas when line is ending with ;

Coverage increased (+0.03%) to 94.014% when pulling e4e49a70b26679a82f067ec4883670d3c30a47ce on feature/#269_FP_on_rule_TrailingCommas into 660b5b216a156b0ec336cd830a70e9176a55f23f on master.


add manual override of rudder in stabilized modes

work in progress
current mod adds manual rudder input to output of yaw controller, rather than affecting the setpoint
This allows manual override of the rudder, which currently effects coordinated turns.

@kd0aij I agree. Actually I always wanted to compare the performance between the two approaches. But as we flew wings only lately this got neglected.

@kd0aij I agree. Actually I always wanted to compare the performance between the two approaches. But as we flew wings only lately this got neglected.

Here's an experiment with closing the rudder control on lateral acceleration:
HILstar17 is more challenging: http://dash.oznet.ch/view/6J4pdemgnVeFwHSnANj5F8
This is the PT60 in Xplane9 with the same FW_Yx settings: http://dash.oznet.ch/view/sUZCYnSNrtMxTcFeKhBdLe
The yaw rate setpoint is computed as: _rate_setpoint -= (yaccel / (airspeed * cosf(pitch)));
in ECL_YawController::control_attitude

Interesting - that looks quite good. What is your recommendation for the implementation? @thomasgubler I like the simplicity of the approach.

Nice, I suggest that we introduce a param which selects the method of yaw rate generation. In the end maybe even a mixed approach with a openloop feedforward part and a closed acceleration-loop could be used.
Can you give some reasoning behind your solution? Eg why do you use the rate_setpoint and not the bodyrate_setpoint and where does the pitch dependency come from?
When you do large changes please also be aware of this PR: https://github.com/PX4/Firmware/pull/156
If I find time tomorrow I will prepare the code so that it supports multiple methods easily.

@LorenzMeier I don't yet have any quantitative measure of performance relative to the existing approach, so no recommendation yet. I'm also not confident that HILsim is an adequate means of testing this, so it will probably be a while before I'm satisfied with flight testing.
@thomasgubler This was just a quick hack of the existing methods, and to be more correct I should have used only the bodyrate setpoint, but the current implementation sets the desired body-frame yaw rate in control_attitude, then closes the loop on yaw_rate in control_bodyrate.
@thomasgubler I note that you've just pushed some major changes to the ECL code, so I'll rebase my working branch on master before I continue with testing. Also, I wasn't even aware of the sensor_hil_fixedwing branch; will take a look at that PR. Anything specific in there that I should look at?

Also, I wasn't even aware of the sensor_hil_fixedwing branch; will take a look at that PR. Anything specific in there that I should look at?

I am not aware of that branch / not sure what you mean

@thomasgubler I was referring to the PR you referenced: "Rebase of changes to sensor_hil_fixedwing branch." https://github.com/PX4/Firmware/pull/156

Ah sorry a '4' was missing: I meant: https://github.com/PX4/Firmware/pull/1564 which is anyway included in https://github.com/PX4/Firmware/pull/1574


[FEATURE]Harvester should support external storage as a non-system partition for virtual machines

Harvester currently only supports the use of longhorn to store virtual machine data, and does not support the use of external storage to store virtual machine data, it is recommended that we can install CSI in the harvester cluster to support external storage, we can choose to use external storage as the VM's non-system data partition when creating the VM, in order to let customers store some application data, the system partition of the virtual machine can still use longhorn.

Related to #1199

Is there any update on the progress of this issue? Multi-CSI support is critical for our Harvester use case as some of our workloads won't work optimally with Longhorn (IOPS). Is this the proper issue to track or should I look into another issue?

@leovigna it's an upcoming feature for the v1.2.0 release. You can take a look at HEP https://github.com/harvester/harvester/pull/3666 to see what would the designed experience like.

Ok thanks for the info. Is there an estimated timeline for that release? Would just help us out for planning our migration to Harvester.

V1.2.0 release is targeting June/Q2 2023. You can check https://github.com/harvester/harvester/wiki/Roadmap for details.

Test Plan
Setup Base Cluster

Prepare Harvester master iso
Prepare a custom Harvester config

os:
  persistentStatePaths:
    - /var/lib/rook
  modules:
    - rbd
    - nbd

ceph needs the rbd module, rook will modprobe rbd in pod, but will fail in 1.11, it is safer to run modprobe from the host

Create a Harvester cluster

use the master iso
use the custom Harvester config
the cluster has two nodes
each Harvester node has two disks

You can also try the harvester-auto project, just only send one message to the slack bot:
v2c master http://bit.ly/harvester-rook-config

Setup Rook Ceph

Install rook-ceph operator to the Harvester cluster

helm repo add rook-release https://charts.rook.io/release
helm repo update
helm upgrade --install --create-namespace --namespace rook-ceph rook-ceph rook-release/rook-ceph --version v1.11.1
kubectl -n rook-ceph wait --for=condition=Available deploy rook-ceph-operator

create rook-ceph cluster,storageclass,snapshotclass

git clone -b v1.11.1 https://github.com/rook/rook.git && cd rook/deploy/examples
kubectl apply -f ./cluster-test.yaml
kubectl apply -f ./csi/rbd/storageclass-test.yaml
kubectl apply -f ./csi/rbd/snapshotclass.yaml
watch 'kubectl --namespace rook-ceph get pods'

Test

Configure the Harvester csi-driver-config settings from Harvester UI

Test all volume-related functions

vm create
vm clone
vm backup & restore
vm snapshot & restore
vm live migration
volume create
volume clone
volume snapshot & restore
volume resize

Reboot Harvester node, All functions still work

As #3688 will use the same test plan, I think this could be verified along with it? cc @irishgordo

@lanfon72  - I've not had a chance to look at #3688 but I believe this and 3688 could be verified together :smile:

Verified this feature has been implemented
There have few different compare to previous test plan:

Use rook 1.11.6
Install operator by the example's configuration, not helm
More persistentStatePaths: /var/lib/ceph, /etc/ceph, /etc/webhook

Test Information

Environment: qemu/KVM 3 nodes
Harvester Version: master-b49e264e-head
ui-source Option: Auto

Verify Steps

Install Harvester with at least 3 nodes having configure options:

os:
# ref: https://github.com/rook/rook/blob/v1.11.6/deploy/examples/operator.yaml#L570
  persistentStatePaths:
    - /var/lib/rook
    - /var/lib/ceph
    - /etc/ceph
    - /etc/webhook
  modules:
    - rbd
    - nbd

Login to one of hosts, install rook-ceph

curl -fsSLo rook.tar.gz https://github.com/rook/rook/archive/refs/tags/v1.11.6.tar.gz \
&& tar -zxf rook.tar.gz && cd rook-1.11.6/deploy/examples
# apply configurations ref: https://rook.github.io/docs/rook/v1.11/Getting-Started/example-configurations/
kubectl apply -f crds.yaml -f common.yaml -f operator.yaml
kubectl apply -f ./cluster.yaml -f ./csi/rbd/storageclass-test.yaml -f ./csi/rbd/snapshotclass.yaml

Login to dashboard, navigate to Advanced/Settings
Edit csi-driver-config to add rook-ceph.rbd.csi.ceph.com Provisioner and relevant class name
Create an image for VM creation
Create volumes rook-vol, rook-vol2 using rook-ceph-block storage class
Volumes should created successfully
Create VM vm1 with additional data disk using rook-ceph-block storage class and existing rook-vol
VM should created and started successfully
Add Volume rook-vol2 to VM vm1
Login to VM, format additional disks, mount to folders and write data and checksum

# format disk: fdisk and mkfs.ext4
# write 512MB and checksum
dd if=/dev/urandom of=dummy bs=1M count=512
md5sum dummy > wrote.md5

Test Following functionality, data should not lost or corrupt

volume snapshot, restore
volume clone
volume resize
VM snapshot with data volume
VM clone with data volume
VM backup & restore with data volume
VM live migration with data volume

Reboot node which not hosting vm1, data should not lost or corrput

VM should started successfully
Restore VM/volume snapshot
Restore backup with replace/new

Reboot the node which hosting vm1, data should not lost or corrupt[^1][^2]

VM should started successfully
Restore VM/volume snapshot
Restore backup with replace/new

[^1]: reboot might stuck in ceph connection error, we were use force-reset after all others commands been done
[^2]: When not adding /var/ceph to persistentStatePaths, encountering rook-ceph-osd pod CrashBackOff, that's the mainly reason adding /var/ceph to state path.

Hi @futuretea @lanfon72 @WuJun2016, just following up on any issue with a require/doc label for the 1.2.0 release. Does this issue require any of the following?

[ ] New documentation/KB
[ ] Updated documentation/KB
[ ] Release note
[ ] None of the above

If it does, may you please open a PR or share details on what needs to be created or updated?
Thanks!

Hi @LucasSaintarbor, this issue is part of #3666 (another one is #3688), please help to add document based on #3666, thanks.


cppwinrt as an MSBuild Task/Target

How can cppwinrt (and mdmerge) be inserted as a Task or Target to run after the midl Target?

We're putting the finishing touches on MSBuild integration of C++/WinRT-based projects, including cppwinrt.exe, midlrt.exe and mdmerge.exe and the Xaml Compiler in the new toolchain.  Our plan is to roll this support out initially as a standalone VSIX from the Visual Studio Marketplace (formerly Gallery), and ultimately to integrate it with the Visual Studio installer.

We're putting the finishing touches on MSBuild integration of
C++/WinRT-based projects, including cppwinrt.exe, midlrt.exe and
mdmerge.exe and the Xaml Compiler in the new toolchain.  Our plan is to
roll this support out initially as a standalone VSIX from the Visual Studio
Marketplace (formerly Gallery), and ultimately to integrate it with the
Visual Studio installer.
On Fri, Feb 2, 2018 at 3:28 AM, Expression2<EMAIL_ADDRESS>wrote:

How can cppwinrt (and mdmerge) be inserted as a Task or Target to run
after the midl Target?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/cppwinrt/issues/323, or mute the thread
https://github.com/notifications/unsubscribe-auth/ALyMIzpb_Mo2KsT7ni55DJ7xhKap7phNks5tQvFegaJpZM4R3DJa
.

--
Scott Jones<EMAIL_ADDRESS>The Flip Flop http://scottjones.me/
"One Bit at a Time"


key-auth vs basic-auth plugin behaviour

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
3.6.0
Current Behavior
key-auth and basic-auth plugins behave differently when setting www-authenticate header with anonymous config option:

key-auth sets www-authenticate: Key realm="kong" header with anonymous option set
basic-auth doesn't set www-authenticate: Basic realm="service" header with anonymous option set

Expected Behavior
I'm trying to achieve the following behaviour:

allow all consumers to use key-auth or basic-auth authentication on all services/routes: OR scenario from https://docs.konghq.com/gateway/latest/kong-plugins/authentication/reference/#multiple-authentication
if client provides valid key-auth header apikey:<key>, access is granted
if client is a browser, www-authenticate: Basic realm="service" header is returned and browser prompts user with login window

The idea is to use key-auth and basic-auth globally, both configured with anonymous consumer. Based on plugin ordering documentation, key-auth is evaluated first, sets www-authenticate: Key realm="kong" header, then basic-auth plugin is evaluated and overwrites www-authenticate header with  Basic realm="service" value. The last step fails as we can see below.
Steps To Reproduce
Following declarative configuration
_format_version: "3.0"

services:
- name: test.service
  url: https://upstream.internal
  routes:
    - name: basic.route
      paths:
        - /basic
      plugins:
        - name: basic-auth

    - name: key.route
      paths:
        - /key
      plugins:
        - name: key-auth

    - name: basic-anon.route
      paths:
        - /basic-anon
      plugins:
        - name: basic-auth
          config:
            anonymous: anonymous

    - name: key-anon.route
      paths:
        - /key-anon
      plugins:
        - name: key-auth
          config:
            anonymous: anonymous

consumers:
- username: anonymous
  plugins:
  - name: request-termination
    config:
      status_code: 401
      message: Unauthorised

Produces following behaviour:
test~ % curl -s -D - -o /dev/null -k https://kong/basic
HTTP/2 401
date: Sat, 17 Feb 2024 17:53:13 GMT
content-type: application/json; charset=utf-8
www-authenticate: Basic realm="service"
content-length: 81
x-kong-response-latency: 1

test~ % curl -s -D - -o /dev/null -k https://kong/key
HTTP/2 401
date: Sat, 17 Feb 2024 17:53:19 GMT
content-type: application/json; charset=utf-8
www-authenticate: Key realm="kong"
content-length: 96
x-kong-response-latency: 1

test~ % curl -s -D - -o /dev/null -k https://kong/basic-anon
HTTP/2 401
date: Sat, 17 Feb 2024 17:53:28 GMT
content-type: application/json; charset=utf-8
content-length: 26
x-kong-response-latency: 1

test~ % curl -s -D - -o /dev/null -k https://kong/key-anon
HTTP/2 401
date: Sat, 17 Feb 2024 17:53:34 GMT
content-type: application/json; charset=utf-8
www-authenticate: Key realm="kong"
content-length: 26
x-kong-response-latency:

test~ %

As we can see, route with basic-auth plugin together with anonymous config doesn't return any www-authenticate header.
I'm not sure what correct behaviour should be (returning www-authenticate header in all cases would solve my issue 😉 ), but I would expect consistency between key-auth and basic-auth plugins.
Anything else?
No response

Hi @zpevma !
Thank you for bringing that up :) ! There's an ongoing effort to keep auth plugins behaviour consistent and compliant with RFC7235
A change for basic-auth was introduced with 3.6 and there's an open PR that consolidates this behaviour between key-auth and basic-auth: https://github.com/Kong/kong/pull/11794
Maybe to sum it up - all auth plugins are planned to return www-authenticate header with 401 response. In that header there's also optional realm that can be included if the plugin was configured with it. The only exception will be basic-auth where realm is required and by default it's set to service.


Missing some images in converted canvas

https://manuals.info.apple.com/MANUALS/1000/MA1595/en_US/ipad_user_guide.pdf
http://kindle.s3.amazonaws.com/Kindle_User's_Guide_English.pdf
Configuration:

Chrome 53.0.2785.143 m (64-bit)
Operating system and its version: Windows 10
PDF.js version: 1.6.234
Is an extension:

I use PDF.js for converting pdf files to simple images. And, for some PDF files converting is not very good: many images are missing, and sometimes whole pages are blank
I using next code for converting pdf
public ConvertPDFtoImage(pdf: PDFDocumentProxy) {
    const promiseDocumentArray: Array<PDFPromise<PDFPageProxy>> = [];
    for (let pageNum = 1; pageNum <= pdf.numPages; pageNum++) {
        promiseDocumentArray.push(pdf.getPage(pageNum));
    }
    this.getPagesFromDocument(promiseDocumentArray);
}
private getPagesFromDocument(documentPromisesArray) {
    const promisePageArray = [];
    Promise.all(documentPromisesArray)
        .then(
            (pages) => {
                $.each(pages, (i, page: PDFPageProxy) => {
                    promisePageArray.push(this.renderPDFpageToCanvas(page));
                });
                this.getCanvasesFromPages(promisePageArray);
            }
        );
}
private getCanvasesFromPages(promisePageArray) {
    Promise.all(promisePageArray)
        .then(
            (canvases) => {
                $.each(canvases, (idx, canvas: HTMLCanvasElement) => {
                    this.editor.Screenshot.canvas = canvas;
                    this.editor.LoadImageFromPDF();
                });
            })
        .catch(
            (error) => {
                console.log(error);
        });
);
private renderPDFpageToCanvas(page: PDFPageProxy): JQueryPromise<HTMLCanvasElement> {
    const renderedCanvas = $.Deferred();
    const scale = 1.5;
    const viewport = page.getViewport(scale);
    const canvas = <HTMLCanvasElement> document.createElement('canvas');
    const context = canvas.getContext('2d');
    canvas.height = viewport.height;
    canvas.width = viewport.width;
    const renderContext = {
        canvasContext: context,
        viewport
    };
    page.render(renderContext)
        .then(
            (result) => {
                renderedCanvas.resolve(canvas);
            }
        );
        return renderedCanvas.promise();
}

this.editor.LoadImageFromPDF(); - this function just append canvas inside DOM
What is the expected behavior?
So, this are images from PDF Acrobat, Chrome and Mozilla viewers
iPad Manual

iPad Manual

Kindle Manual Title

Kindle Manual

What went wrong?
And this is converted images
iPad Manual

iPad Manual

Kindle Manual Title

Kindle Manual

As you see, some images are broken or missed.

@SergioV85, Can you provide link to the complete example (that can be used to reproduce the issue, not a snippet)? Does this issue present in demo viewer?

Hi!
I've attached zip-archive app.zip with Chrome extension. Please, install it to Chrome and try with any opened PDF. Some of them will be converting to image without loosing images (like this one), but manuals, mentioned above will loose some schemes and images
In preview (I use this one) manual opened normally

Given first of all the age of this issue and secondly that it looks like platform/browser-specific bug, rather than a general PDF.js one, is it actually meaningful to keep this open?


heronstreaming.io out of date wrt compilation instructions

CPP bindings introduced cereal library which needs cmake-2.2 which is not the default version of cmake that comes with ubuntu. Thus to compile latest heron, we need to update the instructions to upgrade the cmake.

keeping these up to date feels a bit redundant. ./bazel_configure.py seems to be a good tools if you want to compile anywhere supported, otherwise there is the vagrant setup, or Dockerfiles - it may be good to refer to those to keep things DRY - as people will have a copy of the codebase anyway if compiling.

Agreed. Thanks @Code0x58 .


[CLI] Support republishing CAPI images

Add functionality to the CLI that will allow the following:

Pulling or core CAPI and provider images
Re-tagging images
Pushing tagged images to a different registy

Relates: #364

Closing this for now


Minified version error

Hi
I downloaded your library, but when i want to use the minified version i always receive a "Syntax Error" in my console (Internet explorer 11).
Also, the minified version requires 64KB and the normal version 4KB. Why? :)

I forgot to say that I'm using Angular 1.5.3 and Jquery 1.12.2

I'm sorry, I was using ladda 1.0.0.


Samsung Pass seems to only save hidden passwords

Hey all,
I have an application with registration and login. For developing and testing I use an Android-Phone.
I changed my password quite often during debugging and testing phase.
I wondered, why sometimes my changed password for my account is saved in Samsung Pass and sometimes it’s not.
It seems to be, because I have a „view password“ button (an eye) behind the text field. This only changes the obscureText of the Textfield (not the type or anything).
Whenever the content is visible, Samsung Pass doesn’t want to save the password. Is that my fault? Can Flutter do something here? Or is it just Samsung Pass that doesn’t look for password-fields but fields with hidden content and then assumes it must be a password field?
BR

@GefaketHD
Samsung Pass is external for Flutter and it doesn't have any control over how Samsung handles it. Please see https://flutter.dev/community for resources and asking support questions. You may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Controller Support

As player 2, I don't want to share a keyboard to control my monster.

[x] One or both monsters should be controllable from a controller
[x] Input mapping is optional

Code is complete, but we still need to setup a test with two controllers.

Controllers work for both players.


Use a more optimized docker image

<IP_ADDRESS>-dedicated-mp-vpkoptim.951630d, as suggested by pg: https://github.com/orgs/nsres/packages/container/package/titanfall

<IP_ADDRESS>-dedicated-mp-vpkoptim.430d3bb

bootstrap time now is exactly 2 minutes


Add bulkGetGroups to asset library client

Aws Connected Device Framework Affected Module(s):
libraries/clients/assetlibrary-client
I'm submitting a ...

[ ] bug report
[x] feature request

Description:
Expose "bulkGetGroups" method via asset library client. This method is available in swagger definition, but not exposed via client library
Current behavior:
"bulkGetGroups" not exposed via asset library client
Expected behavior:
"bulkGetGroups" should be exposed via asset library client
Steps to reproduce:

Navigate to libraries/clients/assetlibrary-client/groups.apigw.service.ts or libraries/clients/assetlibrary-client/groups.lambda.service.ts
"bulkGetGroups" method definition is not present.

Additional Information:

Expose  "bulkGetGroups" for consumers via asset library client library.


Scale icon in Deskbar

Currently QL deskbar icon doesn't scale when large font is used.

This was already addressed in 2fece22178c52818e1f45f3624ac374c924f0812.
I'll have to check if it all works on beta3, too. Otherwise I'll have to wait for beta4 for a QuickLaunch update.

Forgot to close this issue, it seems... Works with beta5.


Add Wheel.onLoaded event

Raise when all images have been loaded or resolved.
One use case for this is to hide the wheel while it is loading.

Not needed due to 9e28d00b171452b73f37fb9b272dff095374cbba
The developer who creates the wheel is responsible for pre-loading images and fonts.


Get Grid Vaadin 14.10.5

I am trying to call _get(Grid.class) in my ui but I get a nullpointer at line 359 of GridUtils.kt
I am using
karibu-testing-v10
1.3.24
The issue seems to be that my grid is using class
com.vaadin.flow.component.grid.GridSorterFilterComponentRenderer
If I look https://github.com/mvysny/karibu-tools/blob/0.14/src/main/kotlin/GridUtils.kt at GridUtils there is handling for class com.vaadin.flow.component.grid.GridSorterComponentRenderer but not com.vaadin.flow.component.grid.GridSorterFilterComponentRenderer
I believe the logic should be the same as gridSorterComponentRendererClass for GridSorterFilterComponentRenderer

Note the class comes from
com.vaadin.componentfactory
enhanced-grid-flow
0.9.1
https://github.com/vaadin-component-factory/enhanced-grid-flow

Can you provide a very simple example project which demoes the NPE please?


Variables are not compiled into shadow blocks

variables_get shadow blocks are not actually shadow and there's an explicit check in createShadowValue to make it a block instead of a shadow.
You end up with this behaviour:

and thus a syntax error..
Repro steps:

Open the Array toolbox and drag a "get array" block onto the workspace
Click on the variable block that comes with it and drag it out

Issue: you end up with an empty hole. and that causes syntax errors.
Fix: we should make the variable block a shadow block, that way it cannot be dragged out. (As a general rule, everything should have shadow blocks)

So I ran into this as I was debugging something else but it turns out Blockly throws an assertion for:
AssertionError: Assertion failed: Shadow blocks cannot have variable fields.

Will investigate why Blockly ensures that doesn't happen.


Use AWS SDK naming for credentials

Warning: this introduces a breaking change in the way the module is initialised. Instead of using dynamoRegion, dynamoAccessKey and dynamoAccessSecret options, the AWS SDK naming conventions have to be followed (the config object will need region, accessKeyId and secretAccessKey properties)
The justification for this change is twofold:

The config object that we initialise the module with can now be passed straight into the dynasty module, which in turn uses it straight away with the AWS SDK. In this way, we can pass in various other properties in the configuration, such as a sessionToken, with no additional effort. Session tokens are especially useful for local development, to avoid storing permanent credentials on a development machine (https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_temp_use-resources.html#using-temp-creds-sdk).
This makes the usage of the module more straightforward for developers already familiar with the names of properties for credentials in the AWS SDK.

@joshuahoover Could we get an update of the package in NPM now that this is merged? Currently, I have to point to the commit hash in my package.json, which is a bit clunky.


Properly exclude all GUI related source files if NOT_GUI is set

What kind of change does this pull request introduce? (check at least one)

[x] Bugfix
[ ] Feature
[x] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Fix NOT_GUI option in the CMakeLists.txt file to properly exclude all GUI related code.

Thank you, I will merge this after all checks are positive.

@antony-jr can you ping me on irc, cant find your nick ?