Fixes issue #30

Description
Made text visible in the text field in dark mode.
Issue Resolved
Fixes #30.
Screenshots
Checklist
Please make sure to review the following before submitting your PR:

[x] I have read the contribution guidelines.
[x] I have read the code of conduct.
[x] I have reviewed my submission in detail.

] I have reviewed my submission in detail.

@Nikhil7174  you also need to fix the text inside the textfields as that too is not visible properly, same needs to be done for the textfields in login page

I had tried to make the text inside the textfields visible before also but these textfields imported from MUI are very rigid and it is very difficult to add custom styling to its bg-color and labels especially in toggling dark mode as these textfields are inside the pages and not the components so i cannot even pass the theme as props to decide when to switch the colors.
So i manually tried to select a bg-color/label color which would look good both in dark and light mode. This is the best i can do right now with the styling of these textfields. Can you please add the 'medium' label in this issue?

@ken1000minus7 How do I target textfield border and background using input props?

For border color i think we'll have to go with the way u hv done the changes

Although that change in bg color of textfields isn't required so u can remove that

I mean the blog card not the blog creation page

Like the one in the screenshot i hv added in the issue


Clean up tests to use spread enumeration

PR with a bit of cleanup in the tests. [...ser.toArrow()] is redundant now that we have the Series[Symbol.iterator]() method, because it internally calls this.toArrow().

cc @mzegar


Extension does not parse css.liquid files correctly

In my assets folder I have a theme.css.liquid file and below is a snippet from the file
.flickity-button{
  position:absolute;
  border:none;
  color:{{ settings.color_button_text | default: "#fff" }};
  color:var(--colorBtnPrimaryText);
  background:{{ settings.color_button | default: "#000" }};
  background:var(--colorBtnPrimary);
  border-radius:50%
}

In the PROBLEMS tab I get these errors in relation to the above CSS snippet
[{
	"resource": "/.../assets/theme.css.liquid",
	"owner": "_generated_diagnostic_collection_name_#1",
	"code": "css-propertyvalueexpected",
	"severity": 8,
	"message": "property value expected",
	"source": "css",
	"startLineNumber": 243,
	"startColumn": 9,
	"endLineNumber": 243,
	"endColumn": 10
},{
	"resource": "/.../assets/theme.css.liquid",
	"owner": "_generated_diagnostic_collection_name_#1",
	"code": "css-ruleorselectorexpected",
	"severity": 8,
	"message": "at-rule or selector expected",
	"source": "css",
	"startLineNumber": 243,
	"startColumn": 58,
	"endLineNumber": 243,
	"endColumn": 59
},{
	"resource": "/.../assets/theme.css.liquid",
	"owner": "_generated_diagnostic_collection_name_#1",
	"code": "css-lcurlyexpected",
	"severity": 8,
	"message": "{ expected",
	"source": "css",
	"startLineNumber": 244,
	"startColumn": 35,
	"endLineNumber": 244,
	"endColumn": 36
},{
	"resource": "/.../assets/theme.css.liquid",
	"owner": "_generated_diagnostic_collection_name_#1",
	"code": "css-identifierexpected",
	"severity": 8,
	"message": "identifier expected",
	"source": "css",
	"startLineNumber": 245,
	"startColumn": 14,
	"endLineNumber": 245,
	"endColumn": 15
},{
	"resource": "/.../assets/theme.css.liquid",
	"owner": "_generated_diagnostic_collection_name_#1",
	"code": "css-rcurlyexpected",
	"severity": 8,
	"message": "} expected",
	"source": "css",
	"startLineNumber": 245,
	"startColumn": 15,
	"endLineNumber": 245,
	"endColumn": 16
},{
	"resource": "/.../assets/theme.css.liquid",
	"owner": "_generated_diagnostic_collection_name_#1",
	"code": "css-ruleorselectorexpected",
	"severity": 8,
	"message": "at-rule or selector expected",
	"source": "css",
	"startLineNumber": 245,
	"startColumn": 58,
	"endLineNumber": 245,
	"endColumn": 59
},{
	"resource": "/.../assets/theme.css.liquid",
	"owner": "_generated_diagnostic_collection_name_#1",
	"code": "css-lcurlyexpected",
	"severity": 8,
	"message": "{ expected",
	"source": "css",
	"startLineNumber": 246,
	"startColumn": 36,
	"endLineNumber": 246,
	"endColumn": 37
},{
	"resource": "/.../assets/theme.css.liquid",
	"owner": "_generated_diagnostic_collection_name_#1",
	"code": "css-identifierexpected",
	"severity": 8,
	"message": "identifier expected",
	"source": "css",
	"startLineNumber": 247,
	"startColumn": 17,
	"endLineNumber": 247,
	"endColumn": 20
}]

It's a large stylesheet so there's over 1000 PROBLEMS. Wondering if this is a bug or some configuration issue from my side?

Those diagnostics from the problem tab come from a different tool. Our tool provides diagnostics with "source": "theme-check".
It's a known issue that CSS + Liquid typically don't mix pretty well. The recommended way to go about this is to write pure CSS and have your liquid get "into" your CSS via CSS variables defined in your layout/theme.liquid inside a <style> tag.
Something like:
// layout/theme.liquid
<style>
  :root {
    --background-color: {{ some_drop_value }};
  }
</style>

And then in your assets/theme.css file, you reference those variables instead of the liquid:
// assets/theme.css

.page-container {
  background-color: var(--background-color);
}

The pros of this approach is that the CSS then is just CSS. So you can use tooling from the community to be more productive with it.
Resources

CSS + Liquid variables being defined Shopify/dawn's layout/theme.liquid
CSS variables being used in vanilla CSS files in Shopify/dawn

This was very helpful! Thanks so much @charlespwd!!


Add information about asynchronous zip deployment

This copies the description of asynchronous deployment from https://github.com/projectkudu/kudu/wiki/Deploying-from-a-zip-file-or-url and includes an additional description of why asynchronous deployment might be preferred (I.e. a timeout error). It also includes information about the expected result codes from the asynchronous result as proposed in https://github.com/projectkudu/kudu/issues/3305.

@daveaglick : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Do I need to do anything else here? The inactive message links to a contributor guide that presumably has further instructions, but it appears to be behind authentication and all I can see is “We are sorry, the page is forbidden.”

@cephalin Could you review the proposed addition to the article and let us know how to proceed?

#sign-off
#please-close
#hold-off

Thank you!
-PR review team


function Add-SshKey doesn't return an error if neither plink or ssh-add are available.

In GitUtils.ps1, the function Add-SshKey just hangs at the console if neither of the SSH agents are available.
I ran into this on a new Windows 10 machine with just git portable installed.

I believe this was fixed by https://github.com/dahlbyk/posh-git/pull/162


Android USB tethering + sudo apt-get update crashes the computer's network

Environment
Windows build number: Microsoft Windows [Version 10.0.19041.450]
Your Distribution version: Release:        20.04
Whether the issue is on WSL 2 and/or WSL 1: Linux version 4.19.104-microsoft-standard (oe-user@oe-host) (gcc version 8.2.0 (GCC)) #1 SMP Wed Feb 19 06:37:35 UTC 2020

Steps to reproduce
Use the android tethering & portable hotspot via USB tethering.
run sudo apt-get update in the WSL2
Expected behavior
the WSL2 should run the sudo apt-get update command without any problems
Actual behavior
When running sudo apt-get update, the command manage to execute for 1 second, and after that, the entire computer network crashes(WSL2's network + Windows's network are affected by the crash)

Please collect WSL logs and post the backlink to the feedback item here. Also please identify any third-party networking software that has been installed on Windows.

Same problem ...
WSL Logs: https://aka.ms/AAae48d

Same problem

Problem look like it got fixed for me.
Microsoft Windows [Version 10.0.19041.867]
Release:        20.04
Linux version 4.19.104-microsoft-standard (oe-user@oe-host) (gcc version 8.2.0 (GCC)) #1 SMP Wed Feb 19 06:37:35 UTC 2020

This issue is occurring once again, have submitted feedback using the steps suggested above.

This issue is occurring again on Windows 10 and Windows 11 in both the Ubuntu WSL and the Debian WSL while being tethered via USB.
I managed to temporarily fix the issue by switching to WiFi and running sudo apt-get update again


Simplify FastAnnotationReader implementation

At this time, FastAnnotationReader need useless extra steps to generate ClassDescription expression.
It transforms ClassAnnotationData in an InjectorClassVO with all its internal dependencies (InjectorMethodVO, InjectorPropertyVO and InjectorArgumentVO), before generating the final AST.
The goal is to remove all the extra processes, and gain some compilation speed and better readability.

This issue was moved to DoclerLabs/hexMachina#49


Realm 10.44.0 crash when filter an array of realm objects

How frequently does the bug occur?
Sometimes
Description
Hi after upgrading realm from 10.32.3 to 10.44.0 we are seeing this crash start to happening. It happened when doing a filter of the realm Object. The function that triggers the crash is shown in here
    private static func updateAccountList<T: Object>(_ list: List<T>, with objectIds: IdentifierDiff, realm: Realm) {
        let added: [T] = objectIds.addedIds.compactMap { realm.object(ofType: T.self, forPrimaryKey: $0) }
        let removed: [T] = objectIds.removedIds.compactMap { realm.object(ofType: T.self, forPrimaryKey: $0) }

        let addToAccount = added.filter { !list.contains($0) }
        list.append(objectsIn: addToAccount)

        removed.forEach { object in
            if let index = list.index(of: object) {
                list.remove(at: index)
            }
        }
    }

The line that trigger the crash is let addToAccount = added.filter { !list.contains($0) }
This function was called within a realm.write and it only start to having this crash after upgrade to 10.44.0.
Any help is much appreciated.
Stacktrace & log output
Fatal Exception: std::bad_alloc
0  myApp                          0x2f86ec FIRCLSProcessRecordAllThreads + 393 (FIRCLSProcess.c:393)
1  myApp                          0x2f8acc FIRCLSProcessRecordAllThreads + 424 (FIRCLSProcess.c:424)
2  myApp                          0x306520 FIRCLSHandler + 34 (FIRCLSHandler.m:34)
3  myApp                          0x306374 __FIRCLSExceptionRecord_block_invoke + 232 (FIRCLSException.mm:232)
4  libdispatch.dylib              0x3fdc _dispatch_client_callout + 20
5  libdispatch.dylib              0x13574 _dispatch_lane_barrier_sync_invoke_and_complete + 56
6  myApp                          0x305380 FIRCLSExceptionRecord + 234 (FIRCLSException.mm:234)
7  myApp                          0x305090 FIRCLSTerminateHandler() + 404 (FIRCLSException.mm:404)
8  libc++abi.dylib                0x10f28 std::__terminate(void (*)()) + 20
9  libc++abi.dylib                0x10ec4 std::terminate() + 56
10 myApp                          0x82aeb4 realm::NodeHeader::get_byte_size_from_header(char const*) + 116 (node_header.hpp:116)
11 myApp                          0x835798 realm::QueryStateBase::match_pattern(unsigned long, unsigned long long) + 53 (query_state.hpp:53)
12 myApp                          0x9c4b9c realm::Query::do_find_all(realm::QueryStateBase&) const + 1298 (query.cpp:1298)
13 myApp                          0xaab048 realm::TableView::do_sync() + 487 (table_view.cpp:487)
14 myApp                          0x9c4954 realm::Query::find_all(unsigned long) const + 1387 (query.cpp:1387)
15 myApp                          0x91c1d0 realm::Results::ensure_up_to_date(realm::Results::EvaluateMode) + 308 (results.cpp:308)
16 myApp                          0x92522c realm::Results::snapshot() && + 1027 (results.cpp:1027)
17 myApp                          0x64e88c -[RLMFastEnumerator initWithBackingCollection:collection:classInfo:] + 68 (RLMCollection.mm:68)
18 myApp                          0x66b92c -[RLMManagedArray fastEnumerator] + 484 (RLMManagedArray.mm:484)
19 myApp                          0x64efd0 RLMFastEnumerate(NSFastEnumerationState*, unsigned long, id<RLMCollectionPrivate>) + 184 (RLMCollection.mm:184)
20 Foundation                     0x336664 NSFastEnumerationIterator.next() + 184
21 myApp                          0xb8ec30 specialized _ArrayProtocol.filter(_:) + 991236 (<compiler-generated>:991236)
22 myApp                          0xb90d74 specialized static DataManager.updateAccountList<A>(_:with:realm:) + 600 (DataManager.swift:600)

Can you reproduce the bug?
No
Reproduction Steps
No response
Version
10.44.0
What Atlas Services are you using?
Local Database only
Are you using encryption?
No
Platform OS and version(s)
iOS 16 and 17
Build environment
Xcode version: ...
Dependency manager and version: ...

Well this one is hard to tell, but I think the data being filtered shouldn't be that large. But the check for contain can be relative big can be as much as 100K data

How much data is being filtered? I ask as those calls are high-level Swift functions which override the lazy-loadingness of Realm so if it's a big dataset, it could be a memory issue.

This one is hard to tell, the data being filtered shouldn't be that large, but the list to check if data is within the list can be big. The list can contain 100K+ of records but the size can also varies from a couple of thousands to 100K+

Note you may want to update your code to be RealmSwift.List when referring to Realm Lists - that avoids a collision with a Swift List construct.
If the bug is not reproducible it's going to be tough to track down. I suggest altering that filtering code to only use Realm filters and see if there is any difference - it could be a memory issue.

Note you may want to update your code to be RealmSwift.List when referring to Realm Lists - that avoids a collision with a Swift List construct.
If the bug is not reproducible it's going to be tough to track down. I suggest altering that filtering code to only use Realm filters and see if there is any difference - it could be a memory issue.

Hi @Jaycyn thank your for your input, just to confirm if this is what you are suggesting (extract only the necessary code)?
    private static func updateAccountList<T: Object>(_ list: RealmSwift.List<T>, with objectIds: IdentifierDiff, realm: Realm) {
        let added: [T] = objectIds.addedIds.compactMap { realm.object(ofType: T.self, forPrimaryKey: $0) }
        let addToAccount = added.filter { !list.contains($0) }
        list.append(objectsIn: addToAccount)
    }

I've made the list to use RealmSwift.List<T>. The actual filter is done on an Array of T where T is some Object. The list is only used to do the contains check.
Do you think this will make a difference?


Use distro name in config profile selection unless the profile is not a default created profile for a distro

@SirCmpwn we closing this?


Allow additional content in webhooks

This may be outside the scope of a webhook, but it would be cool to be able to customize the contents of the request body. It would allow nifty features like posting to a Slack or Discord channel when there is a failure event without setting up another server to bridge the two.

I think this is likely outside the scope of the webhook. I think if you want to intergrate with other services like Slack, you will need to create a small service to accept the webhook from Postal and then re-format it for consumption elsewhere.


Don't works with aws-sdk-php

The sign step Middleware that Aws (version 3) adds in every request concludes with a non fulfilled promise, short-cutting the middleware chain, so when an aws async method is requested, the invoke method of your HttpClientAdapter is not reached and the react loop queue remains empty.
This promise makes an http request (to validate credentials ?), and is added to guzzle internal queue. This promise will never resolve until run method queue's is executed.
You can see Aws\Middleware file signer method, where the promise is created, returned to Aws\CredentialProvider fromCredentials method.
In my point of view this is not a bug of react-guzzle-psr7, may be can be avoided adding another middleware step which runs the guzzle queue ?

Hey, I've just filed #27 that does this for when after the __invoke has been called. For before __invoke is called. You could do this, that will keep ticking off items from the queue ensuring everything is handled:
$timer = $this->loop->addPeriodicTimer(0.1, function () {
    \GuzzleHttp\Promise\queue()->run();
});

Be sure to cancel $timer when you don't have any left to do, or otherwise the loop keeps running.

Ok. Thanks.


ended event does not fire first time after an ad

We have discovered an issue where the ended event does not fire the first time a video ends after an ad is played. Currently, if an ad plays, and the video finishes, the ended event is not fired. If you then rewind a few seconds and hit play, this time, when the video finishes, an ended even is fired.
If the ima plugin is not initialized, the ended events fire as expected on video end the first time.
There are no errors listed in the console. If there is additional information that would be useful, please let me know.
VideoJS version 6.7.3
IMA Plugin version 1.3.0
VideoJS Contrib Ads version 6.0.0

FWIW, I noticed this fix for issue #559  in the 1.3.0 release notes, so thought I would give contentended a try. The contentended event fires without any trouble at the end of the video. That works for my situation as well, so I will use it.
I also noticed that using the dev tools Event Listener Breakpoints on the ended event pauses execution on the event. However, the event is not fired on the actual player until you rewind and it is fired a second time. Also worth noting is that after doing so, the player seems kind of in an odd state. For example, loading a new source and playing it is stalled for a few seconds before it seems to actually take. With the IMA plugin disabled, this behavior is not noticed.

We are still using the 6.0 release of contrib-ads. Do you find the issue goes away after upgrading to a new contrib-ads?

After upgrading to contrib-ads 6.2.0, and pointing to that version from the integration, the issue went away. So I would say the bug was i the ads plugin rather then the ima plugin.

Thanks for the info. I think we'll put in a change to contrib-ads 6.2.0 as soon as we can.

Closing the issue. It looks like it was discovered to be an issue with the contrib-ads plugin and not the videojs-ima plugin

We have discovered an issue where the ended event does not fire the first time a video ends after an ad is played. Currently, if an ad plays, and the video finishes, the ended event is not fired. If you then rewind a few seconds and hit play, this time, when the video finishes, an ended even is fired.
If the ima plugin is not initialized, the ended events fire as expected on video end the first time.
There are no errors listed in the console. If there is additional information that would be useful, please let me know.
VideoJS version 6.7.3 IMA Plugin version 1.3.0 VideoJS Contrib Ads version 6.0.0

Sadly, this is still happening with the latest version of VideoJS 8, Contrib Ads 7.3.2, VideoJS IMA 2.2.0 and VideoJS Playlist 5.1.0.

Hello @justinbeatz ,
When testing for the following events, I see both events fire when a post-roll is loaded and played. 'contentended' fires when the content video ends, and 'ended' fires when the post-roll finishes. Could you share any additional steps needed to reproduce the issue, and please reopen the issue as needed.
These are the events I set up:
player.on('contentended')
player.on('ended')

Thank you,
Jackson
IMA SDK team


Feature: lock with password

Lock and unlock with same password.

Why not use kebab case for file names?

It feels easier for me to know that this is a component.


Test target sensor set from targetId

It was very hard to see what has changed due to the many formatting and rename changes.
The one line change for the pr subject looks sensible.
The configure key renames I disagree with.
The formatting changes: no strong feelings.

Thanks for the updates @grkvlt. LGTM, merging.

Fixed a NPE in https://github.com/apache/brooklyn-server/commit/7dd9d1ba25b3c681efabfe911f9c1c645753ece4

@neykov thanks for the merge && the fixup!


Introduce "Dark Minima" skin

Resolves #143
Color palette based on https://primer.style/ (ref: https://github.com/jekyll/minima/issues/143#issuecomment-435308808)

@xxyzz Are you still interested in getting this pull request merged to master..?

Of cause, I have checked out this branch from the latest master branch. I'm trying to adjust some colors.

Note: Primer colors are defined in https://github.com/primer/primitives/blob/master/primitives/colors.json
Example implementation: https://github.com/primer/components/blob/master/src/theme.js

Hello everyone, since Minima's classic skin is primarily based on grayscale tones, I have modified this proposal to be based on grayscale tones, but from the opposite end of the spectrum.
I have also temporarily changed the skin on the preview deploy, so that you all can easily take a look at the current state by visiting: https://deploy-preview-335--jekyll-minima.netlify.com/
(The deploy will be switched back to the default skin prior to merging..)

Why does this need documentation..?

How do people know they can switch to Dark Mode?

The current README file already has a section explains how to set skin: https://github.com/jekyll/minima#skins

The current README file already has a section explains how to set skin

Yes. But ideally, it should also have a sub-section listing the available skins..

Thank you @xxyzz
@jekyllbot: merge +minor


Move unified view into a bottom panel, accessible by a status bar button

Hello!
I have been finding the interface with the split down very frustrating. Especially during debugging, as it can cause breakpoints to open the file inside the same panel as the Debugger, hiding the Debugger tab. To that end I took some inspiration from Linter, as I really like the way the linter uses a docked panel and a status bar icon.
This PR moves the unified view into a bottom panel and allows you to quickly toggle it with a status bar button. The panel is resizable (but doesn't yet remember the size.)
I also added a quick "Listening on port XXXX..." that turns into "Connected" when the debugger connects, so it's easier to see if things are working are not - otherwise, if you don't configure maps correctly, it almost looks like nothing is working (when really it is because its not finding the breakpoints due to maps.)
Lastly, I fixed the broken breakpoint highlighting on Atom 1.2.x on Mac (at least) where due to some tiling improvements in the editor the style wasn't getting applied.

I realise it is a fairly chunky PR, but I hope to hear your thoughts on this, as in my opinion it greatly increases usability. Any changes or cleanups required I'm happy to make.

Reviewing these changes now

Lastly, I fixed the broken breakpoint highlighting on Atom 1.2.x on Mac (at least) where due to some tiling improvements in the editor the style wasn't getting applied.

I can't seem to find any changes that would impact this in your PR.

Lastly, I fixed the broken breakpoint highlighting on Atom 1.2.x on Mac (at least) where due to some tiling improvements in the editor the style wasn't getting applied.

I can't seem to find any changes that would impact this in your PR.

Yep - you fixed it already in exactly the same way I did, so after rebase my change was unnecessary and skipped - I'll remove it from the description!
https://github.com/gwomacks/php-debug/commit/019f9ea4884b8fb1cf48cb3f09f36db5bee44611

Thanks! I'll try to test this locally over the next couple days and then merge.


Paths for external library shorcuts are out of date

:load underscore
results in:
Failed to load http://documentcloud.github.com/underscore/underscore-min.js
The following libraries are also out of date:

rightjs: Failed to load http://rightjs.org/hotlink/right.js
coffeescript: Failed to load http://jashkenas.github.com/coffee-script/extras/coffee-script.js

Closing as merged (see above).


XFail zippered.swift

Running into an issue finding llvm-readtapi. This change was merged on the 12th, so something is probably out of sync. XFailing for now in case it's just something out of sync.

rdar://113880049

Subsumed by https://github.com/apple/llvm-project/pull/7224


WorkManager problems with multiple workers

I am attempting to enqueue 27 workers to WorkManager with the following policy ExistingWorkPolicy.APPEND
It gets to a point where the workinfos are :
DownloadMediaWorker -  [RUNNING - 7] [SUCCEEDED - 20]
and then it never gets past this point.  Why would these workers remain in the running state?

Thanks for reporting this.
I'm closing this issue because this forum is for issues with the codelab.
You may take a look on how to configure WorkManager to increase its debug level as documented in this guides to get a better understanding of what is happening in your code. Also you can find a sample in this codelab.
If you still have this problem, Stackoverflow might be a better forum for this kind of questions.
If you think that this is a problem of the WorkManager library, please open a bug on the WorkManager public issue tracker: https://issuetracker.google.com/issues/new?component=409906&template=1094197


New copy everywhere

I made a little DSL for specifying boldness in the sidetext thing also.

Why not use  tags or something rather than a special dsl?

As discussed, there's something nice to not having to duplicate Style.Body.basic_big everywhere


Consistent, configurable logging in the JavaScript client

The JavaScript client (and indeed all the clients) needs to have configurable logging rather than just relying on console.log as it does right now.

This was originally being tracked here: https://github.com/aspnet/SignalR/issues/3 but a separate issue makes it more visible.

https://github.com/aspnet/SignalR/pull/484#issuecomment-303706786

For alpha1: add ability to turn off console.log lines (for node.js usage).
In the next milestone we'll design/implement the right abstraction for client side logging.

@moozzyk will also look into adding an options object at the HubConnection class.  We want to have a bool value for logging, a logger object and hub protocol.

Fixed in: e4c1b888ca65045e8ecde700c8289192e6eb5fc0 and 7db480b23e8d11a384b88a34704468341429c562


Fixed test_notafile_error to pass on Windows.

This test failed because a different error code is raised on Windows when
opening a directory. Since the particular message isn't as important to this
test as the fact that the original IOError is reraised, this fixes the test
by making the assertion more generic.

merged in fb7d681705a92c6d510b06822450d6a94ed1623f, thanks.


Don't trigger server deployment when changing the additional repos

What does this PR change?
Context
Currently, when the additional_repos parameter is added, removed, or modified in a server declaration, sumaform triggers the Salt stages. However, these stages run without actually adding the new repositories. Moreover, this process unnecessarily scans all repository files, which can take several hours, without making any meaningful changes.
After reviewing various pipeline scenarios, I found no use case where triggering the Salt event is necessary when modifying additional_repos. This behavior is particularly problematic in the redeployment feature I'm working on for BV (see PR #1292), as it significantly slows down the redeployment process without any tangible benefit.
Solution
To address this, I propose that we stop triggering the server deployment when changes are made to the additional repositories. This adjustment will streamline the process, eliminating unnecessary delays in deployment.

Currently, when the additional_repos parameter is added, removed, or modified in a server declaration, sumaform triggers the Salt stages. However, these stages run without actually adding the new repositories.

Interesting. I did not know that. I would have thought that it works properly.
I have 2 additional questions:

Is this the right place to remove the parameter? With your changes, will it not be removed for everything? What about removing it only from the server module/definition?
I am not sure about this one, but do we not use this parameter when we inject the MU repos in the BV? Or am I mixing this up?

Good remarks.
Some points :

Those triggers are only for existing deployment.
the additional repository parameter only impact the server ( manage by terracumber.terraformer.inject_repos )
if you use taint, it's going to delete completely the server
for me this trigger could be a bait. Those repositories are going to be added to the server, salt is going to update the packages BUT from what I can see, we don't have update / upgrade method in salt that's going to correctly update the server ( restart spacewalk, etc )

spacewalk-service:
  service.running:
    - name: spacewalk.target
    - watch:
      - file: spacewalk_search_config
    - require:
      - file: spacewalk_search_config

after some retesting, I can see the repositories are correctly added. Neverthe

Thank you for the detailed explanation and insight, Maxime.


Relax cmake python interpreter requirements to support Python3.

This removes the Python 2.7 interpreter requirement for cmake and fixes issues when build systems may be using nanopb but no longer support Python 2.
Steps to reproduce the issue

Run cmake . on a system without Python 2.7, or
Integrate into a build system that installs required packages for Python3

What happens?

cmake fails to find an appropriate python version, or
Building fails since required packages may not be installed for Python 2.7

What should happen?

cmake should use the default Python interpreter

Thanks, this seems reasonable. I still have to figure out whether to use Python 3 by default everywhere, but relaxing the version requirement in CMake definitely makes sense.


Feature request: Support file-globbing

It would be really nice, if the plugin would support glob-path like { files: ["./src/styles/props/*.css"] } for input. That, btw, would align with vscode's cssvars-plugin.

Proposal:

Use terkelg/tiny-glob.
Before reading the files, run

UserProps?.files
   .map((file) => glob(file))
   .reduce((flattenedFileList, files) => flattenedFileList.concat(files), [])

That's what I'm doing manually in my postcss.conf and it works fine.


Need some help getting the tftp page working properly with the latest version.

Was wondering if you were able to support me on getting this last issue resolved? I can upload my current file set. I was able to get everything working but the tftp page. it loads the page with the data from xmldefaults. When I hit submit I get error, file_get_contents(): Filename cannot be empty

$filename = "/tftpboot/$tftpdisplay.cnf.xml";
$tftpfile = file_get_contents($inputfile);
802.//
803.// I know this look crazy, but we pull the "" tags from the
error is on line 801.

Let me know if you are able to help and what you need from me. Thanks

Just double-checked. This should be working in 1.1.2


Getting response data from request call

Hello,
From the recommended way of doing requests,
let alamofireRequest = request.perform(withSuccess: { result in }, failure: { error in})
I can't seem to get the statusCode, header and meta data etc.. only the data. Is there a way to get these? I can't find it in the docs.

Usually it's not common to parse status code, headers and metadata yourself, since you mostly rely on response or error received. However, TRON provides several ways to access those

You can add plugin to request, which will be called on all stages of request happening. https://github.com/MLSDev/TRON/blob/master/Source/Core/Plugin.swift#L32

You can perform requests using this method:

let afRequest = request.performCollectingTimeline(withCompletion: { result in
    print(result.response.statusCode)
    print(result.response.allHeaderFields)
})

In case your request errors out, all request data is wrapped into APIError struct:

let alamofireRequest = request.perform(withSuccess: { result in }, failure: { error in
    print(error.response.statusCode)
   print(error.response.allHeaderFields)
})

Hope this clears out our intention of hiding all this data and leading you right to your data model.


Please fix - EditorField - Not Auto Resize - Windows and Android.

Hi @enisn
The EditorField does not auto resize when i wrote a long text.

It's my example:

It's yout example on project website:

My Code:
<material:EditorField          Title="Name"         Text="{Binding Name}"/>

Which platform are you working?
There is a known issue on windows, you can set HeightRequest on windows

I working on - Android and Windows. but it doesn't work on android either (I tried on project - sample project)
Do I need to set a fix HeighRequest? Does not work on automatically?


Add the spanish translated language around phone verification

https://docs.google.com/spreadsheets/d/1PZv9f1fbPTa1rldz5UqRoqKQibmnfTc6fky-xn9zWfo/edit#gid=1899596513
Look at verification part 1 and part 2

We are not implementing the updated phone verification after the study completion yet so for this story we are only going to do part 1


Add objc-class.h to objc headers

This one is pretty much equal to that other pull request for objc-runtime.h, but with a different header that just came up. :)

I'll merge this, though it would probably be better if we only exposed the APIs that the Apple runtime does from each of these headers, rather than exposing everything.


Restructure code as independent modules

Proposed changes
The objective is to separate modules for the sake of clarity when calling functions

Remove the global IAPWS.f90 module
Access directly the desired functions in the dedicated module e.g. iapwsG704_kh_water()
Create C API headers for each module
Translate the structure in the python wrapper as well e.g pyiapws.iapwsG704.kh_water()

The modules were separated and an automatic generation of kh and kd function for H2O and D2O for each gas was written i.e. IAPWS_g704_kx_y_z where x=(h or d), y=(H2O or D2O) and z=(gas). The C API and the pywrapper are also automatically generated.
Might be useful to generate a dispatcher for backward compatibility.


Rename Project Settings, Display, Window width and height, and test_width and test_height settings to match their function

As originally identified by @leonkrause here, the Project Settings display/window/size/test_width and test_height should be renamed to window_width and window_height to reflect their function. To avoid confusion, this PR also renames display/window/size/width and height to viewport_width and viewport_height to reflect their function too.
Part of #16863

I would rename them from test to override, because otherwise its still confusing as users won't know which is the actual setting to use. In reality, your display size is not warranted and supplying a "real"  window size is not portable (as it can't be ensured when you run on mobile, web, FS dedicated, etc), so other than users using this for scaling pixel art in desktop games it serves not a lot of purpose.

I don't think the word "override" reflects what it does. It doesn't override anything, it simply specifies the initial size of the window on desktop platforms. I've tried to make this clear in the documentation:

On desktop platforms, sets the game's initial window height.
Note: By default, or when set to 0, the initial window height is the viewport height. This setting is ignored on iOS, Android, and HTML5.

The window size can still be changed by the user (unless the Resizable property is disabled). How the viewport is displayed when these settings are used, or the window size is changed by the user, depends on the Stretch settings.
These settings are used to test what the viewport and stretch settings will look like on different mobile screen resolutions -- especially pixel art -- and I assume this is why it was called "test" initially, but ultimately it's the initial desktop window size.
Finally, the window_width and window_height are only available under Advanced Settings. They're not displayed by default; so it shouldn't confuse new users:

@smix8 The problem with "Project Resolution" is that the published game's actual resolution (including the height to width ratio) depends on the device that it's played on, and that is outside of your control. It's only on desktop platforms, when the game is not run at Fullscreen and Resizable is disabled that the final resolution can be controlled (and then you need to keep it a minimum expected size). In all other circumstances you need to specify how your Viewport size is converted to the actual screen or window resolution; using the stretch modes. This is explained in the tutorials: https://docs.godotengine.org/en/stable/tutorials/viewports/multiple_resolutions.html. Ultimately, by the time you publish your game, you need to understand what the Viewport is and specify how it's size is converted to the actual screen or window size. And, yes, that requires that the layout of your Control nodes is not "brittle". Until then, and to help beginners, when running the game from the editor, the window size is simply the Viewport size.
"Launch Window Size" is what this PR is proposing calling window_width and window_height, and it's specific to desktop platforms.

@LightningAA I've updated the documentation with slight modifications to your suggestions. Please let me know what you think.

@madmiraal I see your point, but having as you suggest is ambiguous. Adding override makes it clearer where the order of importance is. Worst case this could be called "window width/height override"

Renamed window_width to window_width_override and window_height to window_height_override as suggested.

We discussed this in a PR review meeting and approved the renaming of display/window/size/test_{width,height} to display/window/size/window_{width,height}_override. That part can be merged already.
For the other part which renames display/window/size/{width,height} to display/window/size/viewport_{width,height}, we agreed that there is merit to it from a technical point of view (it's more accurate/descriptive), but are still unsure whether it's a good change from a UX point of view.
One other thing that could be worth looking into is maybe separating display/window parameters and display/viewport parameters, if we see that it makes sense for users.
So we suggest opening a proposal to discuss that specific part further and include more users in the discussion, including tutorial makers, to use the opportunity to figure out the most natural structure for these settings (if we're breaking compat, we can take this opportunity to revisit this).

I've created https://github.com/godotengine/godot-proposals/issues/3769.

Thanks!


Fix compile warnings

Fix such compile warnings as -Werror=non-virtual-dtor, -Werror=double-promotion.
Here it is an errors that I have got during the compilation using the gcc 10.2.0 compiler.
error: implicit conversion from ‘float’ to ‘double’ to match other operand of binary expression [-Werror=double-promotion]
  123 |                 65536.0 * load_factor), 65535);

  error: implicit conversion from ‘float’ to ‘double’ to match other operand of binary expression [-Werror=double-promotion]
   85 |         static_cast<std::size_t>(65536.0 * loadFactor), 65535);

error: ‘class nudb::detail::store_base’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]
   17 | class store_base

cc1plus: all warnings being treated as errors

Thank you for the contribution, @Mr-Leshiy. Merged into 2.0.6

Thank you for the contribution, @Mr-Leshiy. Merged into 2.0.6


QUALIFY clause does not work with incremental models

Describe the bug
When using QUALIFY in an incremental model, the view dbt creates does not exist. This prevents dbt from doing the merge statement.
Steps To Reproduce
test.sql
{{ config(
    materialized = 'incremental',
    incremental_strategy = 'merge',
    unique_key = 'id',
) }}

with test as (
  select 1 as id
)
select *
from test
qualify row_number() over (order BY id) = 1

log results:
    create temporary view test__dbt_tmp as

with test as (
  select 1 as id
)
select *
from test
qualify row_number() over (order BY id) = 1

17:50:20.156423 [debug] [Thread-1  ]: Opening a new connection, currently in state closed
17:50:21.114806 [debug] [Thread-1  ]: SQL status: OK in 0.96 seconds
17:50:22.030437 [debug] [Thread-1  ]: Writing runtime SQL for node "model.lakehouse.test"
17:50:22.031221 [debug] [Thread-1  ]: Spark adapter: NotImplemented: add_begin_query
17:50:22.031552 [debug] [Thread-1  ]: Using databricks connection "model.lakehouse.test"
17:50:22.031835 [debug] [Thread-1  ]: On model.lakehouse.test: /* {"app": "dbt", "dbt_version": "1.0.4", "profile_name": "limebi", "target_name": "stg", "node_id": "model.lakehouse.test"} */

    merge into silver_limeade_platform.test as DBT_INTERNAL_DEST
      using test__dbt_tmp as DBT_INTERNAL_SOURCE

        on
                DBT_INTERNAL_SOURCE.id = DBT_INTERNAL_DEST.id

      when matched then update set *
      when not matched then insert *

17:50:22.578607 [debug] [Thread-1  ]: Databricks adapter: Error while running:
/* {"app": "dbt", "dbt_version": "1.0.4", "profile_name": "limebi", "target_name": "stg", "node_id": "model.lakehouse.test"} */

    merge into silver_limeade_platform.test as DBT_INTERNAL_DEST
      using test__dbt_tmp as DBT_INTERNAL_SOURCE

        on
                DBT_INTERNAL_SOURCE.id = DBT_INTERNAL_DEST.id

      when matched then update set *
      when not matched then insert *

17:50:22.579077 [debug] [Thread-1  ]: Databricks adapter: Query execution failed. State: ERROR_STATE; Error code: 0; SQLSTATE: None; Error message: org.apache.hive.service.cli.HiveSQLException: Error running query: org.apache.spark.sql.AnalysisException: Table or view not found: test__dbt_tmp; line 9 pos 12
	at org.apache.spark.sql.hive.thriftserver.HiveThriftServerErrors$.runningQueryError(HiveThriftServerErrors.scala:47)
	at org.apache.spark.sql.hive.thriftserver.SparkExecuteStatementOperation.org$apache$spark$sql$hive$thriftserver$SparkExecuteStatementOperation$$execute(SparkExecuteStatementOperation.scala:418)
	at org.apache.spark.sql.hive.thriftserver.SparkExecuteStatementOperation$$anon$2$$anon$3.$anonfun$run$2(SparkExecuteStatementOperation.scala:245)
	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
	at org.apache.spark.sql.hive.thriftserver.ThriftLocalProperties.withLocalProperties(ThriftLocalProperties.scala:123)
	at org.apache.spark.sql.hive.thriftserver.ThriftLocalProperties.withLocalProperties$(ThriftLocalProperties.scala:48)
	at org.apache.spark.sql.hive.thriftserver.SparkExecuteStatementOperation.withLocalProperties(SparkExecuteStatementOperation.scala:52)
	at org.apache.spark.sql.hive.thriftserver.SparkExecuteStatementOperation$$anon$2$$anon$3.run(SparkExecuteStatementOperation.scala:223)
	at org.apache.spark.sql.hive.thriftserver.SparkExecuteStatementOperation$$anon$2$$anon$3.run(SparkExecuteStatementOperation.scala:208)
	at java.security.AccessController.doPrivileged(Native Method)
	at javax.security.auth.Subject.doAs(Subject.java:422)
	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1878)
	at org.apache.spark.sql.hive.thriftserver.SparkExecuteStatementOperation$$anon$2.run(SparkExecuteStatementOperation.scala:257)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.spark.sql.AnalysisException: Table or view not found: test__dbt_tmp; line 9 pos 12
	at org.apache.spark.sql.AnalysisException.copy(AnalysisException.scala:71)
	at org.apache.spark.sql.hive.thriftserver.SparkExecuteStatementOperation.org$apache$spark$sql$hive$thriftserver$SparkExecuteStatementOperation$$execute(SparkExecuteStatementOperation.scala:410)
	... 16 more

Expected behavior
Expect view to be created and queryable to execute merge statement.
Screenshots and log output
If applicable, add screenshots or log output to help explain your problem.
System information
The output of dbt --version:
1.04
The operating system you're using:
WSL
The output of python --version:
Python 3.9.11
Additional context
Add any other context about the problem here.

Hi @binhnefits, thanks for the report!
I tried the query in my local, but I couldn't reproduce it.
Could you share more details about your environment?

What kind of cluster are you trying to use? e.g., SQL Endpoint or multi purpose cluster? What version if multi purpose cluster?
What version of dbt-databricks adapter are you using?

Thanks.

Hi @ueshin, thank you for looking into this issue.
Here is a screenshot of the SQL endpoint I'm using

Here is manifest.json configuration
    "model.lakehouse.test": {
      "raw_sql": "{{ config(\n    materialized = 'incremental',\n    incremental_strategy = 'merge',\n    unique_key = 'id',\n) }}\n\nwith test as (\n  select 1 as id\n)\nselect *\nfrom test\nqualify row_number() over (order BY id) = 1",
      "compiled": true,
      "resource_type": "model",
      "depends_on": {
        "macros": [
          "macro.dbt_spark.dbt_spark_validate_get_file_format",
          "macro.dbt_spark.dbt_spark_validate_get_incremental_strategy",
          "macro.dbt.should_full_refresh",
          "macro.dbt.incremental_validate_on_schema_change",
          "macro.dbt.load_relation",
          "macro.dbt.make_temp_relation",
          "macro.dbt.run_hooks",
          "macro.dbt.create_table_as",
          "macro.dbt.run_query",
          "macro.dbt.process_schema_changes",
          "macro.dbt_databricks.dbt_databricks_get_incremental_sql",
          "macro.dbt.statement"
        ],
        "nodes": []
      },
      "config": {
        "enabled": true,
        "alias": null,
        "schema": "silver_limeade_platform",
        "database": null,
        "tags": ["silver", "limeade_platform"],
        "meta": {},
        "materialized": "incremental",
        "persist_docs": { "relation": true, "columns": true },
        "quoting": {},
        "column_types": {},
        "full_refresh": null,
        "on_schema_change": "ignore",
        "file_format": "delta",
        "location_root": "/mnt/datalake/silver/limeade_platform",
        "incremental_strategy": "merge",
        "unique_key": "id",
        "post-hook": [
          { "sql": "VACUUM {{ this }}", "transaction": true, "index": null }
        ],
        "pre-hook": []
      },
      "database": null,
      "schema": "silver_limeade_platform",
      "fqn": ["lakehouse", "silver", "limeade_platform", "test"],
      "unique_id": "model.lakehouse.test",
      "package_name": "lakehouse",
      "root_path": "/home/binhpham/work/BI/lakehouse-dbt",
      "path": "silver/limeade_platform/test.sql",
      "original_file_path": "models/silver/limeade_platform/test.sql",
      "name": "test",
      "alias": "test",
      "checksum": {
        "name": "sha256",
        "checksum": "065d1ecb756a3c4b3fda53e0a514482de13e62610d0bc489c4b843712845fdc0"
      },
      "tags": ["silver", "limeade_platform"],
      "refs": [],
      "sources": [],
      "description": "",
      "columns": {},
      "meta": {},
      "docs": { "show": true },
      "patch_path": null,
      "compiled_path": "target/compiled/lakehouse/models/silver/limeade_platform/test.sql",
      "build_path": "target/run/lakehouse/models/silver/limeade_platform/test.sql",
      "deferred": false,
      "unrendered_config": {
        "persist_docs": { "relation": true, "columns": true },
        "file_format": "delta",
        "post-hook": "VACUUM {{ this }}",
        "tags": ["limeade_platform"],
        "location_root": "/mnt/datalake/silver/limeade_platform",
        "schema": "silver_limeade_platform",
        "materialized": "incremental",
        "incremental_strategy": "merge",
        "unique_key": "id"
      },
      "created_at":<PHONE_NUMBER>.1954176,
      "compiled_sql": "\n\nwith test as (\n  select 1 as id\n)\nselect *\nfrom test\nqualify row_number() over (order BY id) = 1",
      "extra_ctes_injected": true,
      "extra_ctes": [],
      "relation_name": "silver_limeade_platform.test"
    }

Also its worth mentioning that this works on clusters but not sql endpoints in my databricks environment.

I've been noticing this issue as well. I had seen that it results in the temp view being created but then on the next step it isn't found to select from. We noticed it was happening for some models but not others, but hadn't identified that the qualify statement seems to be the culprit. The models that fail are using it while the ones that work are not.
I also observed the failed models will run on a cluster but not a SQL endpoint.
Can't get any logs right now but if you need some additional input I can get them.

Hi @binhnefits, does it work if you remove the qualify clause?

Also its worth mentioning that this works on clusters but not sql endpoints in my databricks environment.

It would be helpful if you can click the name of the SQL endpoint you created and provide a screenshot of the SQL endpoint's configuration (the "Overview" tab).

@allisonwang-db
Yes this works without qualify, and using row_number with cte.
Here is SQL endpoint overview

@binhnefits Thanks for providing the info. This is a known issue with SQL endpoints and the team is actively working on fixing it (likely by the end of the month). Will give an update once the fix is rolled out to production.

Hi @allisonwang-db I was wondering if you had any updates. I noticed Datbricks released runtime 10.5 so wondering if that had the fix in it. Thanks!

@binhnefits the issue should be fixed! Please try it again and let me know if it is still not working.

hi @binhnefits any luck testing this out again? Does it work now?

Hi @allisonwang-db @superdupershant I have confirmed that it is working now. Thank you!


[BUG] Incorrect detection of file type

描述你的问题（Describe the bug）

It seems that uri passed to function FileSystemEditorComponentContribution.getFileType always returns fileType text
复现路径（To Reproduce）

Just open a non-text file, for instance, an image file.
预期表现（Expected behavior）

fileType of file with ext .jpg should be image, not text
问题截图（Screenshots）

Note: I have assigned the returning value of function getLanguageIdFromMonaco to a variable langID so that I can find out what it returns.
https://github.com/opensumi/core/blob/d6dc837dd21fc09c215c284315f6341dec48bcbe/packages/file-scheme/src/browser/file-scheme.contribution.ts#L163-L173
Opening file with extesnion .js

While opening file with extension .jpg, langID is "unknown"

环境信息（Environment）

OS: macOS 12.5.1 ARM
Browser: chrome
OpenSumi Version: 2.19.10

@situ2001 thanks for your report，we have fixed #1644

@situ2001 thanks for your report，we have fixed #1644

Thanks. May I add some unit tests for file-scheme.contribution?

@situ2001 thanks for your report，we have fixed #1644

Thanks. May I add some unit tests for file-scheme.contribution?

Welcome！


fix(docker): don't need to specify ${APP} twice in RUN ln due to nest-apps mono repo design update

What this PR does / why we need it:
Dockerfile build was failing as ${APP} is now redundant due to nestjs mono repo structural changes.

#1073 will shift-left migrated invalid artifact in the future.

LGTM


Upgrade to Chromium 68

What is your Test Scenario?
I'm running tests in an Alpine-based Docker container. It was working fine with Chromium v61 and we upgraded our Docker image to use v68.
What is the Current behavior?
Running the following:
testcafe "chromium:headless" __tests__/integration/**/*.test.js

The testcafe instance seems to start running for a few seconds, then exits with the following error:
ERROR Unable to establish one or more of the specified browser connections. This can be caused by network issues or remote device fa
ilure.

What is the Expected behavior?
Tests should run.
Your Environment details:

testcafe version:                   0.23.2
node.js version:                    10
command-line arguments:  testcafe "chromium:headless" tests/integration/**/*.test.js
browser name and version: Chromium68

Seems the best way to solve a blocking error is to open an issue, seems I missed the --no-sandbox flag.
testcafe \"chromium:headless --no-sandbox\" __tests__/integration/**/*.test.js


Disable pin on head for serve controller by default in service operator

Why are these changes needed?
This is needed to speedup serve controller recovery time due to raylet died. Otherwise, serve has to wait until GCS announce the node failure before start the controller.

Related issue number

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

lgtm. i restarted the failed job. It seems like to be some irrelevant failure. lets wait for new result

I will merge it since @wilsonwang371 already approve it


Add support for Xcode 9.3 coverage reports

As, specified in Release Notes, Xcode 9.3 comes with a new format for coverage reports together with a CLI tool (xccov) that can convert .xccovreport files to JSON.
We can use Xcode's xccov (call it from xcov-core) to support new coverage reports, while maintaining the support for the older format. The resulted JSON will be passed to xcov which will continue to do it's thing.
Just have to make the same JSON schema is used for both coverage formats.
@nakiostudio Any thoughts?

Hi @thelvis4 👋
Sorry for the late response, I haven't had time to test the Xcode beta until last night. I did some debugging and what xccov does is not very different to what xcov-core was doing before. Actually with few changes xcov-core is able to open xccovreport files so I think we can ignore xccov as it doesn't add much value.
Now... the changes on how IDESchemeActionCodeCoverageFile is unarchived make keeping both xccoverage and xccovreport support a bit difficult so I've come up with a solution that relies on IDEFoundation for this unarchiving.
The problem with this approach is that it creates a dependency between xcov-core and having Xcode in the machine it runs on.
Let me know what you think.

Would be great to see some action on this issue - currently blocking us from upgrading to Xcode 9.3 on a CI I work with.

Hi @RodBrown1988 👋
This is pretty much done, need to complete some testing and will release a new version soon.


*: update docs about task config

What is changed, added or deleted? (Required)

change comment of password config
add session config
add enable-ansi-quotes config

Which DM version(s) do your changes apply to? (Required)

[x] master (the latest development version, including v2.0 changes for now)
[x] v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Rest LGTM

@yikeke PTAL again

PTAL


Correctly build SQL string with filtered date

When filtering for dates, this happened:
django.db.utils.ProgrammingError: operator does not exist: date = integer
LINE 1: ...est_app_feature" WHERE ("test_app_feature"."date" = 2020-07-...
                                                             ^
HINT:  No operator matches the given name and argument type(s). You might need to add explicit type casts.

The reason is that  .format(features.query) calls the __str__ method of the sql.Query, which produces unparsed output.
https://github.com/submarcos/django-vectortiles/blob/70514bef851e955726e0b5db49c06c3e177045dd/vectortiles/postgis/mixins.py#L32
This PR aims to fix this issue, by correctly passing the params to the cursor.execute() function.

Thank you for your fix and your contrib. I hope to fix all these problems in future by writing a real custom SubQuery or Aggregate for this. #1 . Il will add many tests on each database type.

Thank you for merging so quickly! I'm looking forward to the new release so that I can easily use it in our project. :slightly_smiling_face:


Unable to open Project

Been getting this error, I've used this tool to extract the .bsa https://www.nexusmods.com/skyrimspecialedition/mods/974/

Additionally upon closing it deleted every file except for those in directory

/_1stperson
/animations

Thanks for the report, did you try to open the project using the "Open Packed Project" option? I'm adding more descriptive error messages for similar issues but I only see that message when attempting to open a packed project using the "Open Unpacked Project" or if the file itself is corrupted.


Remove helm update instructions in contributing.md ?

In contributing.md it has a line about running helm update on the jupyterhub repo. In a subsequent step, it then asks you to run an install script that seems to be calling the same thing:
https://github.com/jupyterhub/binderhub/blob/master/testing/minikube/install-hub#L40
Does that mean we can remove the lines about asking people to manually call helm update?

https://github.com/jupyterhub/binderhub/blob/master/CONTRIBUTING.md has changed a lot!


HDF5 export from HopsanCLI

[x] Move export code to separate library
[x] Call library from HopsanCLI

Also cmake build is missing, but I will add on my other branch where I have added hdf5 inclusion.
It makes no difference on this branch.

@robbr48  I think that I was able to solve the build issues when hdf5 is not available I have pushed some commits, two that you need to squash with previous work, and two new ones. The last is technically unrelated but it adds a nice speed improvement to the qmake build (no need to wait for subprojects to build one at a time) and since you added a new subproject I think it make sens to throw it in with this PR.

Hmm apperantly not quite done yet, CI still fail, possibly due to some misstake in.my speedup commit.


API Proposal: provide easier access to host and shadow root

Summary
A common pattern when working with custom web components is to have an event of some lower level control, and then need the host (to get attributes on the web-component) or the shadowRoot (to query elements inside the web-component).
For example:
define`
  <x-calc>

      <input id="calculation">
      <button onclick="calculate(event)">calc</button>

      Result: <input readonly value=${'result'}>

  </x-calc>
`

function calculate(event) {
  const xCalcShadow = event.target.getRootNode();
  const xCalcHost = event.target.getRootNode().host;

  const calculation = xCalcShadow.querySelector('#calculation').value;
  const result = eval(calculation);
  xCalcHost.setAttribute('result', result)
}

In particular, the pattern of
  const xCalcShadow = event.target.getRootNode();
  const xCalcHost = event.target.getRootNode().host;

is a common one, that will often get repeated for larger components over and over again. While not especially tedious, it is somewhat unruly to write out, and can be a barrier to entry for new developers that might be interested in developing web-components.
Potential Interface
A potential alternative could be something like the following:
  const { host, shadowRoot } = getRootComponent(event.target);

since we are moving more toward an HTML API first, closing this (at least, until there's more requests here to make this happen).


[SPARK-48218][CORE] TransportClientFactory.createClient may NPE cause FetchFailedException

What changes were proposed in this pull request?
This PR aims to add a check for TransportChannelHandler to be non-null in the TransportClientFactory.createClient method.
Why are the changes needed?
Line 178 synchronized (handler) , handler == null
org.apache.spark.network.client.TransportClientFactory#createClient(java.lang.String, int, boolean)
      TransportChannelHandler handler = cachedClient.getChannel().pipeline()
        .get(TransportChannelHandler.class);
      synchronized (handler) {
        handler.getResponseHandler().updateTimeOfLastRequest();
      }

org.apache.spark.shuffle.FetchFailedException
	at org.apache.spark.storage.ShuffleBlockFetcherIterator.throwFetchFailedException(ShuffleBlockFetcherIterator.scala:1180)
	at org.apache.spark.storage.ShuffleBlockFetcherIterator.next(ShuffleBlockFetcherIterator.scala:913)
	at org.apache.spark.storage.ShuffleBlockFetcherIterator.next(ShuffleBlockFetcherIterator.scala:84)
	at org.apache.spark.util.CompletionIterator.next(CompletionIterator.scala:29)

Caused by: java.lang.NullPointerException
	at org.apache.spark.network.client.TransportClientFactory.createClient(TransportClientFactory.java:178)
	at org.apache.spark.network.shuffle.ExternalBlockStoreClient.lambda$fetchBlocks$0(ExternalBlockStoreClient.java:128)
	at org.apache.spark.network.shuffle.RetryingBlockTransferor.transferAllOutstanding(RetryingBlockTransferor.java:154)
	at org.apache.spark.network.shuffle.RetryingBlockTransferor.start(RetryingBlockTransferor.java:133)
	at org.apache.spark.network.shuffle.ExternalBlockStoreClient.fetchBlocks(ExternalBlockStoreClient.java:139)

Does this PR introduce any user-facing change?
No
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No

Merged to master for Apache Spark 4.0.0-preview2-rc2.
Thank you, @cxzl25 , @mridulm , @yaooqinn .


Bug/question ResourceNotFoundException: No progress information found

What happened?
We have a pulumi stack that we've been successfully using for over a year. In one of our usual deploys we encountered this error:
aws:elasticsearch:Domain (<domain-name>):
    error: 1 error occurred:
    	* updating urn:pulumi:prod::api::aws:elasticsearch/domain:Domain::<domain-name>: 1 error occurred:
    	* ResourceNotFoundException: No progress information found

We also see this in our state file initErrors:
"initErrors": [
  "updating urn:pulumi:prod::api::aws:elasticsearch/domain:Domain::<domain-name>: 1 error occurred:\n\t* ResourceNotFoundException: No progress information found\n\n"
],

We confirmed that the resource does exist (we can see it in our aws console and in the state file) and we are correctly setting the region. Other resources are able to update with no problem.
Steps to reproduce
Unsure how to reproduce - part of the ask of this question/report is to understand how something like this could happen.
Expected Behavior
We expected the resource to update successfully.
Actual Behavior
Got a ResourceNotFound exception and we are unable to update our stacks.
Output of pulumi about
No response
Additional context
This question was posted recently on stack overflow and describes something very similar to what we are seeing.
We are hoping to understand what would cause this error to happen and steps on how to resolve.
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

We were able to temporarily get around the issue by using ignoreChanges to skip the update that fails. However, still looking for a fix for the root issue.

Hi @whwa
Please can you let us know what version of pulumi-aws that you are using? Does a pulumi refresh help in this space?
Paul

I would like to work on this issue. Reply ASAP.

Hi @Prayag-raj-sharma - thank you for your interest in contributing to Pulumi! We're more than happy to help you resolve this issue here. Feel free to get started and reach out with any questions. Thank you!

This issue looks stale with no clear repro details. I'll go ahead and close it. Please open a new one with a full repro and details about the versions, if the issue still persists today.


PHASE 1: Update invite screens

Update Title + text
Change the background color to #EEEEEE
Add shadow to the components:
Remove the "BAR" component.

*** RELEASE ONLY WHEN PHASE 1 IS LAUNCHED ***
https://xd.adobe.com/view/31a5fe4f-8ed5-4b78-af59-1bdedc47f99b-64f6/

@AnastasiiaOdnoshevna can be tested on dev

A new user was created through invite link (via custody)

Text on the mockup looks bolder than on the screen
The social buttons should be displayed on the full-width of card
Should be displayed the "Friends invited" text
The first letter of name should be displayed instead of the asterisc (letter of first and second name)
The name of the user should be displayed
The bottom of the card should not be cut off

@AnastasiiaOdnoshevna please provide both users credentials

@AnastasiiaOdnoshevna fixed. name not displaying is fixed for invites

@sirpy the demarcation line isn't displayed between invited friends
All mentioned above elements are displayed according to the requirement
Checked on DEV V0.25.3
LG V30+ // Android 8.0 // Google Chrome 83.0.4103.106
Desktop: Windows 10 // Google Chrome  83.0.4103.116

@sirpy all elements according to require
Checked on DEV V0.25.4-1
LG V30+ // Android 8.0 // Google Chrome 83.0.4103.106
Desktop: Windows 10 // Google Chrome 83.0.4103.116

Invite screen is displayed according to require
Checked on QA V0.25.6
LG V30+ // Android 8.0 // Google Chrome 83.0.4103.106
Desktop: Windows 10 // Google Chrome 83.0.4103.116


Dynamics 365 for outlook will be discontinued or not?

My CRM environment saying about dynamics 365 for outlook will be deprecated, but I did not find any documentation about this. Perhaps you should provide documentation teaching to disable this feature for every user in my organization.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 19f7a69b-4e8a-4500-426d-2617b07a08b0
Version Independent ID: 7d7a9021-5afb-6226-662b-70efc8963641
Content: Dynamics 365 for Outlook support
Content Source: ce/outlook-addin/admin-guide/support.md
Service: crm-online
GitHub Login: @mduelae
Microsoft Alias: mkaur

@ingd The deprecation announcement was added to the docs earlier this year:

https://docs.microsoft.com/dynamics365/outlook-addin/admin-guide/dynamics-365-for-outlook
https://docs.microsoft.com/power-platform/important-changes-coming#dynamic-365-for-outlook-is-deprecated

Thanks,
Mints


CLI there is a way to visualize output using graphana

What: The ability to visualize an output manifest file in graphana
Why: So we can find patterns in more complex scenarios
SoW:

Graphana config which shows data in a graphline.
Script to convert the manifest output file into a CSV which graphana loads.

This can be a POC for now, there is lots here to unpack and edge cases to figure out.

Each component in the manifest file is output to a CSV (every param is one line)
That CSV file is loaded by graphana.
Graphana can be configured to show only a subset of the fields that have been dumped into the CSV file.

cc/ @pazbardanl (can't assign you till you accept)

Paz demonstrated this featuire at IEF weekly call on 30/11/23
Will close this issue when we have merged a PR into IF repository
Keeping in progress into next sprint.

closing as complete (PR for python version merged, tasks for visualization guide and ts-native csv exporter assigned)


Jms ibl

merge ambient changes

sorry that made a bit of a mess...
if you just manually copy out the changes from pbr_functions.wgsl and pbr_ambient.wgsl you should be good to go.

Merged, thanks!


chore: bdd-nh-1584730744 to 0.0.1

chore: Promote bdd-nh-1584730744 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Accommodate adjusted multipliers for commercial meters

I have an EMU-2 that is pulling data from a commercial kV2c GE meter from ComEd. The problem is that commercial ComEd meters report a kWh value that must be multiplied by a certain value (in our case, 60x) to get an accurate kWh reading.
For example, the EMU-2 is currently reporting 0.75 kWh usage. Multiplied by 60, our building is actually using 45 kWh. (3 AC units across 10,000sq ft... in 80F weather)
Is this something that can be accounted for in the HCAS plugin? It seems like an unusual case and I am not sure how it would be worked around in HASS in a way where HASS's own energy tracker would record the correct usage. It may be easy to make a sensor that multiplied the data but that doesn't integrate well with the default HASS energy recorder.

You can use a template sensor to accommodate this, at least until it can be looked into more.

Yeah it's hard to know if this is an edge case or something relatively common. Maybe a setting to configure a multiple in the integration? Where does the 60x come from?
I agree with @HyperActiveJ, a template sensor would be the simplest method at this point.

Thanks, I successfully implemented a template sensor for this. The data is
still wrong in the “Energy” section but the template sensor works for what
we’re doing and I want to see about moving away from HA to pull this data
out of the EMU-2 eventually anyway. Can’t imagine many commercial customers
doing things this way, but we’re a makerspace trying to do this on a budget.
This situation only affects commercial meter customers.
A multiplier setting would be sufficient if this was implemented. The
commercial smart meter itself reports a value that doesn’t represent a true
kWh reading, the 60x is what the energy company (ComEd) uses to calculate
the true energy usage as stated on the bill. The EMU-2 itself isn’t smart
enough to accommodate this situation.
My guess is that on a commercial meter your readings can easily go beyond
1,000,000 aggregate kWh so they factor it down to keep the numbers
manageable. Then they multiply it in their billing system to charge the
true amount. Imagine my hour or so of confusion when the EMU-2 said a
building with 4 AC units was consuming 0.5 kWh. Turns out it’s more like
20-30 kWh. I did the math with a day’s worth of data on the multiplier and
it does roughly match up with our real reported usage.
On Tue, Jul 26, 2022 at 1:28 PM Ryan Winter @.***>
wrote:

Yeah it's hard to know if this is an edge case or something relatively
common. Maybe a setting to configure a multiple in the integration? Where
does the 60x come from?
I agree with @HyperActiveJ https://github.com/HyperActiveJ, a template
sensor would be the simplest method at this point.
—
Reply to this email directly, view it on GitHub
https://github.com/ryanwinter/hass-rainforest-emu-2/issues/21#issuecomment-1195835562,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI35QUFGIB7Z47IHGEA6KZ3VWAU4JANCNFSM54PC7OGA
.
You are receiv this because you authored the thread.Message ID:
@.***>

--
Sky Nova
CTO
Pumping Station: One https://pumpingstationone.org
Hack. Make. Craft.
3519 North Elston Ave
Chicago, IL 60647
Open House Tuesdays at 8pm https://pumpingstationone.org/events/


Bolts, Darts and Headless Arrows

Add data classes for bolt fletching and dart fletching
Add all fletchable bolts
Add all fletchable darts
Add level requirements and xp rewards to items in items.yml
Add FletchBolts.kt for handling bolt fletching
Add FletchDarts.kt for handling dart fletching
Add Arrows.kts to handle adding feathers to arrowshafts
Remove duplicate element in items.yml
Add animation id's for making bolts, darts, fletching log

Note: I was unable to find working animations for fletching, I used resources that Greg had already given me when working on Crashed stars and did a lot of research myself. When working on older content like a skill normally I can use Runelite to get player animations and they work but in this case the only animation ID that I was able to extract and work as intended was fletching_log which ID is 1248 I tried animation ID's around fletching_log and all animations I tried would make the character visually glitch.

hey yer im not sure i had a look and other sources but they just had -1 for anim i don't think it will be a gfx a render emote not sure don't think so  anyway atm osrs has a beta on worlds 585, 586, 587, 588 & 589 you can change skills to what ever level at any time and reset you acc thanks to greg for letting me know "Reset beta world save" under gameplay in the full settings. here is a little list maybe you mite find it useful for fletching
anim 6702 - Cut thing
anim 5756 - cut thing with knife in hand
anim 6678 - Fletch Shortbow
anim 6679 - Fletch Oak Shortbow
anim 6680 - Fletch Willow Shortbow
anim 6681 - Fletch Maple Shortbow
anim 6682 - Fletch Yew Shortbow
anim 6683 - Fletch Magic Shortbow
anim 6684 - Fletch Shieldbow
anim 6685 - Fletch Oak Shieldbow
anim 6686 - Fletch Willow Shieldbow
anim 6687 - Fletch Maple Shieldbow
anim 6688 - Fletch Yew Shieldbow
anim 6689 - Fletch Magic Shieldbow
anim 6671 - Fletch bow
anim 6672 - Fletch bow
anim 6673 - Fletch bow
anim 6674 - Fletch bow
anim 6675 - Fletch bow
anim 6676 - Fletch bow
anim 6677 - Fletch bow
anim 885 - Cut Dragonstone
anim 886 - Cut Diamond
anim 887 - Cut Ruby
anim 888 - Cut Sapphire
anim 889 - Cut Emerald
anim 890 - Cut Opal
anim 891 - Cut Jade
anim 892 - Cut Topaz
anim 2717 - Chisel onyx
anim 13225 - Fletch Tangle Gum Longbow
anim 13226 - Fletch Seeping Elm Longbow
anim 13227 - Fletch Blood Spindle Longbow
anim 13228 - Fletch Utuku Longbow
anim 13229 - Fletch Spinebeam Longbow
anim 13230 - Fletch Bovistrangler Longbow
anim 13231 - Fletch Thigat Longbow
anim 13232 - Fletch Corpsethorn Longbow
anim 13233 - Fletch Entgallow Longbow
anim 13234 - Fletch Grave Creeper Longbow
anim 13235 - Fletch Tangle Gum Shortbow
anim 13236 - Fletch Seeping Elm Shortbow
anim 13237 - Fletch Blood Spindle Shortbow
anim 13238 - Fletch Utuku Shortbow
anim 13239 - Fletch Spinebeam Shortbow
anim 13240 - Fletch Bovistrangler Shortbow
anim 13241 - Fletch Thigat Shortbow
anim 13242 - Fletch Corpsethorn Shortbow
anim 13243 - Fletch Entgallow Shortbow
anim 13244 - Fletch Grave Creeper Shortbow

Thank you very much, but may i ask how you found these, I think I'm doing something very wrong :laughing:  is there a specific way to get these id's from runelite or other sources? i went through many animation lists etc and i wasn't able to find much.

Yeah there's a identification plugin on runelite to display animation and gfx ids above players and npcs, jarry uses another plugin for vars and sound ids too but idk what those are called. The osrs ids should match up with most pre 2008 content

i just use runelite dev mode you just have to build it from source code.
anim like 8481 is in osrs but bugs on void so i don't no
i just got the anim from a file i had here it is also added a npc one there for rs3 tho https://github.com/jarryd229/rsps-info

anim like 8481 is in osrs but bugs on void so i don't no

Yeah if it bugs that's because it's a npc animation

Sorry for the delay in fixing the issues with this pull request I have been sick. Greg i know you had mentioned in an earlier response that if the animation is bugged it most likely is an NPC animation do you think Jagex maybe remade these animations? because i do notice that the animation id's have a large gap between for example;
FLETCHING_STRING_NORMAL_SHORTBOW = 6678;
FLETCHING_ATTACH_HEADS = 8480;
FLETCHING_ATTACH_FEATHERS_TO_ARROWSHAFT = 8481;

i just found an old YouTube video https://www.youtube.com/watch?v=73wGT9cNKO8 looks like there was no animations for both attach feathers at 3:15 in vid and 5:45 for attach arrow heads

i just found an old YouTube video https://www.youtube.com/watch?v=73wGT9cNKO8 looks like there was no animations for both attach feathers at 3:15 in vid and 5:45 for attach arrow heads

Ahhh i see that, so i presume Jagex added those after the fact, i will update that, thank you very much Jarry

Just to confirm I am still able to push new code to this request?

This is fletching completed, if i missed anything please tell me, just like Herblore i had left out the items that are related to Dungeoneering

Just to confirm I am still able to push new code to this request?

Yes I just rebased to keep it up to date with main

and again sorry for having this pull request open for alot longer than expected.

No worries it takes as long as it takes, you can always open Draft PR's if somethings not quite complete but you want early feedback on it

Just added a few fixes, hope it doesn't conflict

Just added a few fixes, hope it doesn't conflict

No it was fine :)

Looking good to me, if you have nothing else to add I'll merge it in

Looking good to me, if you have nothing else to add I'll merge it in

Nope, that's everything, and i was watching your commits and i noticed i made alot of small mistakes that i shouldn't have, i apologize for that.

Looking good to me, if you have nothing else to add I'll merge it in

Nope, that's everything, and i was watching your commits and i noticed i made alot of small mistakes that i shouldn't have, i apologize for that.

Great thanks! It's all good, that's what peer-reviewing is for! I went ahead and fixed them while I was fixing my own small mistakes with the item-on-item changes I made a few weeks back


double free crash for client mode in high concurrency mode

Hi,
Last year we met a crash when running in client mode under high concurrnecy scenario, reported a double free error.  It's been a long time so I can't remember the very details, but I'll try to describe it as clear as I can:
Suppose there is a session created in thread A, and A is using the session,  and the session is stored in clientSessionContext,  and then another thread B is creating a client mode sslEngine,  then thread B may be assigned the session(by tryAttachClientsideSession),  then do tls_process_client_hello, then it found the session is not valid, so thread B will create a new session and free this stored session,  At the same time, thread C may creating another clientmode engine, and thread C may trying to call removeCacheEntry(xxx, true)  and will free the session too.
This will cause a double free.
Besides, there is a potenial memory leak if store many session in sessions without removing them.

@machunhui, thank you for reporting this. Based on your description, I was able to reproduce the JVM crash due to the race in invalidating the sessions. I have submitted a PR with a potential fix https://github.com/wildfly/wildfly-openssl/pull/38.

Besides, there is a potenial memory leak if store many session in sessions without removing them.

I haven't been able to reproduce the memory leak yet. I'll probably have to look through the code a bit more if this is actually possible. Did you actually see this happening? If so, could you explain a bit more on how you reproduced it?

@jaikiran great!
I used to had a similiar patch, by using some synchronized condition to make sure it will can deleted once. But considering of our scenario, we don't need to store a client session to accelerate the speed of getting a session, and considering of the memory leak,  so I just removed the store of the client session.
Yes, I did see the memory leak.  In fact, from the code itself, you'll find there is only an interface of removing from sessions, and not called anywhere, so if an session is put in sessions, it may updated, but it will never get removed from the sessions(we can't rely on customer to call the interface, they don't know session was stored).  so, if there are too many "key“ in the sessions, the sessions will looks like a memory leak。

So the sessions that are maintained in the OpenSSLSessionContext get removed as and when the sessions are invalidated (through callbacks). Assuming the invalidation itself doesn't happen for whatever reason, these are further cleared when the cache maintained in the OpenSSLClientSessionContext either reaches the max size (defaulting to 100) or when it reaches the session timeout. So even if the invaliadtion doesn't happen, the sessions cache does keep getting cleaned as and when needed. If you are indeed seeing this reach beyond the expected size, then please let us know and we'll take a look.
P.S: The PR has been merged so you can try your tests against the latest upstream master branch.

@jaikiran oh, maybe your commit can fix the memory leak issue.
when removeCacheEntry,  the session will be removed from sessions， which was not removed from sessions before.

when removeCacheEntry, the session will be removed from sessions， which was not removed from sessions before.

That's correct. The commit that got merged a few days back made sure the removeCacheEntry does indeed end up removing the session from the sessions cache as well.


Fix yr_re_fast_exec on larger than 2GiB files

There was a silent integer overflow on the max_bytes_matched
calculation as input_forwards_size can be way more than what can fit
in a signed int. yr_re_exec doesn't suffer from the same issue as
a match there is bounded to YR_RE_SCAN_LIMIT which already fits into
an int just fine.

@plusvic when can we expect this to land in official releases of Yara ?

Yes, this has been fixed in v4.2.0-rc1, the release candidate before the official 4.2.0.


package proxychains is broken

Describe the bug
Failed to build pkgs.proxychains.
To Reproduce

add pkgs.proxychains in environment.systemPackages
nixos-rebuild switch

Expected behavior
Build successful.
Screenshots

Additional context
My configuration.nix
Notify maintainers
@siraben
Metadata

system: "x86_64-linux"
host os: Linux 5.4.96, NixOS, 21.03pre269485.a58a0b5098f (Okapi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.10
channels(root): "nixos"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

New warnings/error are introduced with new GCC releases.

@fruit-in, could you please give #112994 a try?

@fruit-in, could you please give #112994 a try?

Yes. It works.


Ntp-client changes

This PR does a few things:

make ntp-client use Win32-network library
fixes #1785 - the crux of the error is that one needs to bind before using recvFrom on Windows
fixes #1548 - test the ntp-client on Windows
fixing concurrency error handling:
when running the ntp client over ipv4 and ipv6 waitCatch on both threads
instead of using concurrently which would mean if one thread fails (e.g.
ipv6 sending fails) both thread will fail and wouldn't get any results.
make logging information more useful for debugging purposes
a bit of cleaning
documentation improvments

fixing concurrency error handling:
when running the ntp client over ipv4 and ipv6 waitCatch on both threads
instead of using concurrently which would mean if one thread fails (e.g.
ipv6 sending fails) both thread will fail and wouldn't get any results.

I think the old Version was also OK.
In the old version, both treads that were started concurrently did there own timeout and error handling.
For sure the old version could handle the case that either IPv4 or IPv6 failed.
I had tested for that.
Or more precisely I mostly tested without an IPv6 network setup
an IPv6 failed and only IPv4 was used.

In the old version, both treads that were started concurrently did there own timeout and error handling.
You're right there was tryIOError; Still, I think it's cleaner to handle errors as at the top of the stack, it could be something else why I didn't see any progress and only exceptions indicating that one cannot send ipv6 from my box.

@MarcFontaine I pushed a fix. Thanks that was a good catch. The problem could be catching AsyncExceptions (in particular UserInterrupt).

You could use (Either IOException a, Either IOException a) but ResultOrFailure is tighter.  The type constructor are very descriptive:
data ResultOrFailure e a
    = BothSucceeded !a
    -- ^ both threads suceeded
    | SuccessAndFailure !a !IPVersion !e
    -- ^ one of the threads errors. 'IPVersion' indicates which one.
    | BothFailed !e !e

This captures all the information we need for two purposes:

logging, just logging a term :: ResultOrFailure will make it clear what happened.
getting the results with the standard fold :: ResultOrFailure e a -> a

You're right, that it's  better to move  mkResultOrFailure to the function definition, it's quite specific to how the threads are combined.

Since I removed the Trace module, all of the ResultOrFailure can be local now in the Query module :).

bors: merge


Youku server reported error -6004: 客户端无权播放

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-F', '-v', 'https://v.youku.com/v_show/id_XNTk1MjQxNjQzMg==.html?']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dl version 2021.12.17
[debug] Python 3.11.3 (CPython 64bit) - Windows-10-10.0.22621-SP0 (OpenSSL 1.1.1t  7 Feb 2023, -)
[debug] exe versions: none
[debug] Proxy map: {}
[youku] XNTk1MjQxNjQzMg: Retrieving cna info
[youku] XNTk1MjQxNjQzMg: Downloading JSON metadata
ERROR: Youku server reported error -6004: 客户端无权播放,201; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "C:\Users\david\Downloads\youtube-dl-master\youtube_dl\YoutubeDL.py", line 824, in wrapper
return func(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\david\Downloads\youtube-dl-master\youtube_dl\YoutubeDL.py", line 845, in __extract_info
ie_result = ie.extract(url)
^^^^^^^^^^^^^^^
File "C:\Users\david\Downloads\youtube-dl-master\youtube_dl\extractor\common.py", line 535, in extract
ie_result = self._real_extract(url)
^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\david\Downloads\youtube-dl-master\youtube_dl\extractor\youku.py", line 189, in _real_extract
raise ExtractorError(msg)
youtube_dl.utils.ExtractorError: Youku server reported error -6004: 客户端无权播放,201; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Description

After fixing a bug with the ccode i got this error and now i have no idea what to do.

...a bug with the ccode ...

Please explain.
Does the URL actually end in ??
My testing with yt-dl gives -6001, while (sometimes at least) yt-dl appears to work.

Does the URL actually end in ??
The URL works with or without '?'.  ytdl works wizh neighter. Before i got a -6001 ccode error. I fixed it by searching the new ccode in chrome dev tools. Chnaged it and i got to this new error

You mean #32194? That matches what I reported above.
I guess the value you found needs other parameters to have corresponding values, different from those in the extractor. Try the value 0524 from yt-dlp instead, as above.


Page timing out

I tried project 10 on vps server and the page did not load in time. I checked the console and it said that the app was listening (i made the connection on port 5000 instead of 3037) , the bot was working , i had all the modules necessary. I cant see why the page is timing out. Do i need to write the domain name instead of localhost:5000 or am i missing something?
Edit: I checked and saw that it was the socket taking too long to connect with the user. Its probably because im using NGINX to reverse proxy requests (to setup https sertificate). Any suggestions how to fix it ?

If you're running it on a VPS, then yes, you'll need to use the server IP rather than localhost when navigating to it in your browser. localhost only accesses your local computer.


Cookie Error

Config is empty

Because you need to set it up. https://github.com/yogurtsyum/qbot/wiki/setup


Adding a config file to be able to generate a phar easily.

You know only need to do run "box build" using box-project.org
and then "chmod +x bower.phar" to have a usable phar archive.

Can you squash your commits?

done ;-D

Thank you


Speedup vcs 3

These are two small improvements:

Use the unaliased git in all cases
Avoid using subshells if possible

Great ideas, @dritter! Glad you thought of this =)


Return URL only storing path?

What is the reasoning behind only storing the path for the x_return_to, store_location.rb
I've got a use case where the user's original request is on a different subdomain than where they sign in. And because Devise strips off the domain, after authentication the user gets redirected to the path on the authentication subdomain rather than the originally requested subdomain and gets an error.
Environment

Ruby 2.7.5p203
Rails 6.1.7
Devise 4.8.1

The original commit isn't very clear<PHONE_NUMBER>dcf25dd26f460dfef1b1edbaf65608 and the related changelog not much helpful either, but I am guessing it was to make sure it was safer against open redirects to other domains, should something "bad" were to get stored there for a later redirect. (e.g. a user controlled param of some sort)
Maybe we never considered a use case of redirecting to the same "domain" but another "subdomain" though. Do you control the call to store_location, or are you relying on Devise internals entirely for that? I could potentially see exposing an option a-la Rails allow_other_host option from redirect_to, but I am not sure how to make something like that work by default within Devise off the top of my head right now, would probably need to do some more digging.

I'm facing a similar problem. Is there a workaround?
I have tried something like:

  def after_sign_out_path_for(_resource)
    # Attempt 1
    root_url(subdomain: nil)
    # error out with:
    # Unsafe redirect to "http://lvh.me:3000/", pass allow_other_host: true to redirect anyway.

    # Attempt 2
    redirect_to(root_url(subdomain: nil), allow_other_host: true); return
    # error out with:
    # Render and/or redirect were called multiple times in this action. Please note that you may only call render OR redirect, and at most once per action. Also note that neither redirect nor render terminate execution of the action, so if you want to exit an action after redirecting, you need to do something like "redirect_to(...); return".
  end

But I haven't figured it out.

@yorsant I think your issue is different, as it's not related to storing the URL for later retrieval during login / redirect afterwards.
You might need to override this method on your own sessions controller to do the redirect yourself, adding allow_other_host. If that doesn't work, please open a separate issue.


Provide Diagnosticable mixin to ButtonStyleButton buttons

Context: https://github.com/flutter/flutter/pull/99753#discussion_r824262494
Description
When refactoring FAB to include a ElevatedButton, flutter/dev/integration_tests/flutter_gallery/test/smoke_test.dart test fail with the following error, source
00:25 +33 ~1: /b/s/w/ir/x/w/flutter/dev/integration_tests/flutter_gallery/test/smoke_test.dart: Flutter Gallery app smoke test with semantics
debugDumpApp : /pesto : line 1790 of 1828 : found a class that does not have its own toString; nearby lines were:
└Offstage(offstage: false, renderObject: RenderOffstage#595a2 relayoutBoundary=up6)
└TickerMode(dependencies: [_EffectiveTickerMode], state: _TickerModeState#0b837(requested mode: enabled))
 └_EffectiveTickerMode(effective mode: enabled)
  └KeyedSubtree-[GlobalKey#c3307]
   └ElevatedButton(style: ButtonStyle#e700f(textStyle: MaterialStateProperty.all(TextStyle(debugLabel: (((englishLike labelLarge 2014).merge(blackMountainView labelLarge)).copyWith).copyWith, inherit: false, color: Color(0xffffffff), family: Roboto, size: 14.0, weight: 500, letterSpacing: 1.2, baseline: alphabetic, decoration: TextDecoration.none)), backgroundColor: MaterialStateProperty.all(MaterialAccentColor(primary value: Color(0xffff5252))), foregroundColor: MaterialStateProperty.all(Color(0xffffffff)), overlayColor: Instance of '_MaterialStatePropertyWith<Color?>', elevation: _EffectiveElevation#b22b4, padding: MaterialStateProperty.all(EdgeInsets.zero), minimumSize: MaterialStateProperty.all(Size(56.0, 56.0)), maximumSize: MaterialStateProperty.all(Size(56.0, 56.0)), shape: MaterialStateProperty.all(CircleBorder(BorderSide(Color(0xff000000), 0.0, BorderStyle.none))), mouseCursor: MaterialStateProperty.all(null), visualDensity: VisualDensity#bdc2a(h: 0.0, v: 0.0), tapTargetSize: padded, animationDuration: 0:00:00.200000, enableFeedback: true), dependencies: [MediaQuery, _LocalizationsScope-[GlobalKey#4bd84], _InheritedTheme], state: _ButtonStyleState#dc507(materialStates: {}))
    └Semantics(container: true, properties: SemanticsProperties, renderObject: RenderSemanticsAnnotations#9f356 relayoutBoundary=up7)
     └_InputPadding(renderObject: _RenderInputPadding#429a8 relayoutBoundary=up8)
      └ConstrainedBox(BoxConstraints(w=56.0, h=56.0), renderObject: RenderConstrainedBox#ead6b relayoutBoundary=up9)
       └Material(type: button, elevation: 6.0, color: MaterialAccentColor(primary value: Color(0xffff5252)), shadowColor: Color(0xff000000), textStyle.debugLabel: ((((englishLike labelLarge 2014).merge(blackMountainView labelLarge)).copyWith).copyWith).copyWith, textStyle.inherit: false, textStyle.color: Color(0xffffffff), textStyle.family: Roboto, textStyle.size: 14.0, textStyle.weight: 500, textStyle.letterSpacing: 1.2, textStyle.baseline: alphabetic, textStyle.decoration: TextDecoration.none, shape: CircleBorder(BorderSide(Color(0xff000000), 0.0, BorderStyle.none)), dependencies: [_LocalizationsScope-[GlobalKey#4bd84], _InheritedTheme], state: _MaterialState#5e512)
        └_MaterialInterior(duration: 200ms, shape: CircleBorder(BorderSide(Color(0xff000000), 0.0, BorderStyle.none)), elevation: 6.0, color: MaterialAccentColor(p

Solution
Provide Diagnosticable mixin to ButtonStyleButton buttons
Result after solution
✓ Flutter Gallery app smoke test (variant: TargetPlatform.android)
✓ Flutter Gallery app smoke test (variant: TargetPlatform.macOS)
✓ Flutter Gallery app smoke test with semantics

No longer need this change. https://github.com/flutter/flutter/pull/99976#discussion_r868284836


Where is CodeMirror.js?

lib only contains the css

Don't use the git repository as an installation source. Use the NPM package or get the .zip file from the website, both of which contain the built library.


Performance is extremely slow, browser is freezing, why?

I add 200 labels, browser seems freezing, I click reload button, refresh button on browser menu, it reload after 10 seconds.
obviously 200 labels make browser not responsive.
any advise?

i know why is slow,  200 marker with lable generate 200 overlay views,
to make it fast, how can i make 200 lable share only one overlay view?

if i draw 200 lines, i can draw 200 line in one polyline, fast
if i draw 200 line use 200 new polyline object, it will be slow

what is the zIndex means?
                       `  var new_marker_label = new MarkerWithLabel({

                              icon: " ",  // an empty string will hide the icon, only shows labels

                              position: ___position,

                              clickable: false,  // must set false, otherwise, can not use mouse to pan map, due to this marker label shade, only trigger marker click-drag event, pan map event will not trigger
                              draggable: false,  // must set false, otherwise, can not use mouse to pan map, due to this marker label shade, only trigger marker click-drag event, pan map event will not trigger

                              zIndex: 0,   // does not help, we want to all label in one single overlay view, instead of each label for a seperate overlay view.
                                           // all label in a single over lay view, should have best performance, each label in a seperate overlay view will slow down performance

                              map: map,

                              labelContent: "
" + ____text + "
", // can also be HTMLElement

                              //labelAnchor: new google.maps.Point(-90, -45),   // make sure label at center of marker, must set anchor as offset,
                              labelAnchor: new google.maps.Point(label_anchor_offset_vertical_y, label_anchor_offset_horizontal_x),

                              labelClass: "labels", // the CSS class for the label
                              labelStyle: { opacity: ___opacity },  // opacity is NOT working, instead, you can set opacity statically in labelClass: "labels", // the CSS class for the label, color: rgba(0,0,0,0.5);  /*  label text color  */
                              visable: false

                          })`

I createa 200 label with 200  new_marker_label = new MarkerWithLabel({.....})
I believe this will create 200 labels with 200 seperated overlay view.
That result in very low performance.
I decide to set zIndex to a fixed number, such as 999.
try to make 200 label use single overlay view, to speed up performance, however, it is same result, very slow.

We are having an similar issue with about 80 labels at the exact same position. It loops through all labels stacking the next on top which causes 80 * 80 action calls. The whole process takes about 5 seconds to complete which causes a flickering of the markers.


Update Crews.md

To solve :
I encountered an error while trying to use the tool. This was the error: DuckDuckGoSearchRun._run() got an unexpected keyword argument 'q'.
Tool duckduckgo_search accepts these inputs: A wrapper around DuckDuckGo Search. Useful for when you need to answer questions about current events. Input should be a search query.
refer : https://github.com/joaomdmoura/crewAI/issues/316

thanks!