Add nodeSelector to metal3's mariadb and baremetal-operator Deployment templates

At the moment in the metal3 chart Ironic communicates with MariaDB through localhost as configured here: https://github.com/suse-edge/charts/blob/079f28a17b5fe81481310821f3c6e5f1ec9d8f70/charts/metal3-deploy/0.1.0/charts/ironic/templates/configmap.yaml#L60
This works if Ironic and MariaDB Pods are running on the same node and with hostNetwork: true so in order to ensure the first condition this PR adds the nodeSelector field to the MariaDB Deployment template.
That field is added also to the Baremetal Operator Deployment template although in that case the communication with Ironic is done through the DNS name, so it's not mandatory for having it working but may be anyway useful https://github.com/suse-edge/charts/blob/079f28a17b5fe81481310821f3c6e5f1ec9d8f70/charts/metal3-deploy/0.1.0/charts/baremetal-operator/templates/configmap-ironic.yaml#L8

This is an issue that we became aware of recently and I'd need to test your fix but it can't be merged at the moment because of the way this repo is set up (referring to this which currently breaks the metal3-deploy).
I'll test this and add it temporarily to https://github.com/dbw7/charts sometime today so you can use it along with the other fixes


GameMode enum may be incorrect

Is the game mode enum correct? I have a simple bot that automatically switches to spectator mode at night time, something like:
    if (currentTime is >= 12_542 and <= 23_459)
    {
        if (player.GameMode is not GameMode.Spectator)
        {
            await chat.SendCommand("gamemode spectator");
        }
    }

This correctly sets the game mode, but the issue is that it runs the command every time through the loop, because player.GameMode reports as GameMode.Adventure not GameMode.Spectator.
Are these final two values correct, or should they be 2 and 3?
https://github.com/psu-de/MineSharp/blob/091d617b7f59aec1d98aa0aaddc35e0c714a1701/MineSharp.Core/Common/GameMode.cs#L18-L26
Update Game Mode doesn't have any notes here: https://wiki.vg/Protocol#Player_Info_Update but other sections have it defined, like here https://wiki.vg/Protocol#Game_Event
3 	Change game mode 	0: Survival, 1: Creative, 2: Adventure, 3: Spectator.

Yes, you're right. Thanks for pointing this out!


Poppy emoji

A symbol for UK Remembrance Day and opium, the (red) Poppy flower is widely known.
Petitions

change.org: Poppy
change.org: Poppy

Made and submitted a proposal to the Unicode Consortium for this Emoji citing these petitions. The GitHub repository is here: https://github.com/inferno986return/poppy-emoji-proposal


Shadow jewel node farther away than it should be for Intuitive Leap

See here for actual vs PoB

The next update will already be bringing an updated passive tree, including this change.


idea, unify sync/async code, use futures instead

@tomusdrw @rphmeier what do you think about that?

Using futures in core will also make a strict requirements about transports (as far as I understand you need an event loop at some point to use futures), it's not bad per se, but might not be as simple as refactoring small part of the library.
(actually I think it might be better to write the whole jsonrpc from scratch instead of refactoring current one:))

It would be nice to have this as futures-based but given that we have 3 mediums of transport to support this might be a really significant undertaking.

Using futures in core will also make a strict requirements about transports (as far as I understand you need an event loop at some point to use futures)

Actually not. Futures might be easily used from tokio event loop, although using it is completely optional.

It would be nice to have this as futures-based but given that we have 3 mediums of transport to support this might be a really significant undertaking.

We could take tokio for tcp and http (there is poc library called minihttp-tokio) or wait for tokio-based hyper release (afaik, it's on the roadmap). So the only transport that would have to be reimplemented is ipc


[WEB]: tx_bad_seq for any operation on PUBLIC net

Web!
Steps to reproduce:

clone https://github.com/rinat-enikeev/sfsdk_web_issue
run on chrome in release mode
press button

Expected:
Trustline established
Actual:
400 tx_bad_seq
final stellarSDK = StellarSDK.PUBLIC;
    final asset = Asset.createNonNativeAsset(
        'USDC', 'GA5ZSEJYB37JRC5AVCIA5MOP4RHTM335X2KGX3IHOJAPP5RE34K4KZVN');

    AccountResponse account =
        await stellarSDK.accounts.account(keyPair!.accountId);

    Transaction transaction = TransactionBuilder(account)
        .addOperation(
            ChangeTrustOperationBuilder(asset, '922337203685.4775807').build())
        .build();

    transaction.sign(keyPair!, Network.PUBLIC);

    SubmitTransactionResponse response =
        await stellarSDK.submitTransaction(transaction);

Resolved in release 1.8.3
Hello @rinat-enikeev,
thank you for adding this issue and the steps to reproduce. The issue has been solved in  release 1.8.3.
If you find any further issues on web, I would be pleased to receive your further issues. This will help us to provide full web support soon.
Thx C


Tests with Minimal Hosting Model

Updated Integration tests with minimal hosting modal configuration, setup and example.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: furoTmark sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@mkArtakMSFT  can you assign someone to review this? I'll clean it up after the review.

@halter73 can you review this PR ?

Moved to #24117


DO NOT MERGE Android: Use app:// protocol for local start_url

When packaging, look at the manifest.start_url field, and if it
is a relative url without protocol, rewrite it to use app://
Also make sure the referenced file does actually exist.
Example:
start_url: index.html becomes app://com.example.foo/index.html
BUG=APPTOOLS-160

@darktears Please give some insight about windows here. Should we just leave the start_url alone for windows?

Tested this locally with my crosswalk-test-suite fix, and it passed.
https://github.com/crosswalk-project/crosswalk-test-suite/pull/3610


Wait for pageant

Please post here if you'd like to work on this so that we can make sure that only one person is trying to fix this issue.
It would be nice to:

Wait for pageant to start
Wait for keys to be loaded in pageant

We'll used Pageant's built-in functionality to do this. For more information, see: http://the.earth.li/~sgtatham/putty/latest/htmldoc/Chapter9.html#pageant-cmdline-command


Graph.Api Authorization

Link to article:
https://docs.microsoft.com/en-us/graph/auth-v2-service
Problem:
5. Use the access token to call Microsoft Graph
After you have an access token, you can use it to call Microsoft Graph by including it in the Authorization header of a request. The following request gets the profile of a specific user. Your app must have the User.Read.All permission to call this API.
This section is missleading. To get a user over the http request Graph.Api User.Read access is suficient.

@Repcak Please submit feedback by clicking on button at the doc's bottom.


[WIP] Swift 3.0

This adds support to Swift 3.0. It's still WIP:

[x] Update core
[x] Update core tests
[ ] Update RAC
[ ] Update RAC tests
[ ] Update podspec
[x] Point OHHTTPStubs to https://github.com/AliSoftware/OHHTTPStubs/pull/201 or wait until that is merged
[x] Update tests to run on iOS 10: they seem to be failing on the Simulator with the same issue mentioned here: https://forums.developer.apple.com/thread/51071 and http://stackoverflow.com/questions/38456471/secitemadd-always-returns-error-34018-in-xcode-8-beta-4-in-ios-10-simulator I think this should be done on a later PR, since it'll probably need to create an app target so the unit tests could be run on a host app (with an Entitlements file)
[ ] Lock dependencies to releases (some of them are referring to branches)

Also, I chose to not mark the classes as open as the converter suggested, but that may be discussible

I think Circle hasn't update to the GM yet

So, the Mac and iOS builds are passing, but the Reactive Cocoa isn't. From what I've seen, 4.x won't support Swift 3, so we'd need to wait for 5.0. I have no idea if master is currently stable or not as I have little familiarity with RC.
What do you guys think?

hello @marcelofabri
thanks for your pr. 👍
we prefer to wait until ReactiveCocoa releases swift 3.0 support. Until then I would leave the pr in [WIP].

So, is there any plan to migrate Heimdallr to Swift 3.0?
I already use Xcode 8😔Recently I want to update my project to support swift 3.0.

Should we use https://github.com/ReactiveCocoa/ReactiveSwift instead of RAC 4? If so, there's already a 1.0.0-alpha.1 release we can use.

I've updated the dependencies now that Nimble and Quick have stable versions and also updated the code to use ReactiveSwift instead of ReactiveCocoa.
However, I had to comment all the Objective-C compatibility section from Heimdallr+ReactiveCocoa because I didn't know how to migrate that.

Excuse me, I don't have much details into the project but as a user of Heimdallr, I would like to understand why is there - historically - blocking dependencies still here?
There was already a problem with the JSON parser before (Argo).
And now RAC.
Or is it that we can DL this branch, exclude RAC, and get things working?

@BabyAzerty If you use CocoaPods, you can use my fork without the RAC subspec (it's optional), so you can migrate your project to Swift 3.0 while waiting this PR to be merged. Just change your Podfile:
pod 'Heimdallr', git: 'https://github.com/marcelofabri/Heimdallr.swift.git', branch: 'swift-3.0'

While I can't speak for the maintainers, I think it'd be useful to make the RAC extension another repository to make it easier to manage, but I don't know how complex that would make things.

I've updated the dependencies now that Nimble and Quick have stable versions and also updated the code to use ReactiveSwift instead of ReactiveCocoa.

Thank you so much for this and sorry for our late response here. We've been a bit busy the last couple of weeks but I would like to rekindle the discussion here again.

However, I had to comment all the Objective-C compatibility section from Heimdallr+ReactiveCocoa because I didn't know how to migrate that.

I think if we want to have full compatibility with Objc and Swift we'll require both ReactiveCocoa and the ReactiveObjCBridge now because the repository will be split up into multiple smaller ones for the upcoming release that brings Swift 3 compatibility.

While I can't speak for the maintainers, I think it'd be useful to make the RAC extension another repository to make it easier to manage, but I don't know how complex that would make things.

I like that idea! I believe it would make the project way easier to maintain. Since we are also internally moving away from heavy RAC usage in our project, it might be the right direction for Heimdallr as well. The reactive extensions can still live in a separate repository. I'll discuss it internally and comment here if we have made a final decision. Otherwise the Swift 3 migration would be blocked until we get a stable RAC 5.0 release.

We decided that we are fine with splitting up the repository and removing RAC as a dependency for this repository.
@marcelofabri Do you want to tackle that? I think you already provide a working Swift 3 fork without the RAC subspec? We'll create a second repository for the reactive extensions when we have a stable RAC release. Let me know if I can help you out in any way 😊

@bckr I'm currently traveling, so it's unlikely that I'm able to work on this for the next ~2 weeks. The fork currently have a RAC subspec, but it's just not working 100%.
I've allowed edits from maintainers, so feel free to start from my fork if you wanna handle this.

@marcelofabri Will do! Thanks!

Hi all,
what is the ETD on this update? Heimdallr is the only library that prevents me from being able to update my project from Swift 2.3 to Swift 3.0. Xcode 8.2 will be the last release that will support Swift 2.3 so we should migrate quickly to Swift 3.0.

Is there anything I can do to help the Swift 3 migration?


Adds settings for distributing projects in Sonatype

This PR adds setting for distribution of projects on Sonatype.
@dialelo @raulraja Could you take a look please? Thank you.

LGTM!  tagline can be separately addressed.


Fix Equals contract for Projects

Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

Hey, thanks for your contribution!
However, Project's equality/identity model has to be updated more extensively, than presented in the current PR. We have plans to do that in the observable future, as a part of Isolated Projects feature stabilization.


bug: e2e testing run failed due to huggingface rate limit

Given that
Huggingface API rate limit: https://huggingface.co/docs/api-inference/en/rate-limits
User Tier Rate Limit:

Unregistered Users: 1 request per hour
Signed-up Users: 50 requests per hour
PRO and Enterprise Users: 500 requests per hour

Issue encountered
e2e testing runs successfully and passes test cases, but if multiple PRs are executed within the same hour, some PRs will fail e2e testing due to the rate limit, and we have to wait an hour before rerunning for a pass.
Objective
larify whether this issue affects users. If it does, we need to discuss with the team about using the Huggingface API. If not, find a way to resolve this rate limit issue in CI.

cc @dan-homebrew @gabrielle-ong @0xSage @vansangpfiev

@hiento09 is there a PR for this e2e tests issue?

@hiento09 is there a PR for this e2e tests issue?

This PR @gabrielle-ong https://github.com/janhq/cortex.cpp/issues/1419

To clarify @hiento09,

With this token, we are now allowed 50 requests per hour?
On the clarification if it affects users - what scenario is this, eg when cortex scales and if we have users pulling >50 models an hour - will it hit this rate limit?
Do we have visibility on how often this error occurs (to monitor if it happens more frequently in the future)

To clarify @hiento09,

With this token, we are now allowed 50 requests per hour?
On the clarification if it affects users - what scenario is this, eg when cortex scales and if we have users pulling >50 models an hour - will it hit this rate limit?
Do we have visibility on how often this error occurs (to monitor if it happens more frequently in the future)

@gabrielle-ong I’d like to clarify something:

This rate limit issue isn't related to downloading models; it’s about making unauthorized calls to the Hugging Face API. Specifically, when we make many requests to the Hugging Face API without including a token in the header, we hit Hugging Face’s rate limit.
I searched on Google but couldn’t find Hugging Face mentioning the exact limit. The number I provided in the description applies to the API inference endpoint of Hugging Face; the API for getting models likely has a different limit.
We discovered this rate limit while writing our end-to-end tests, but we should definitely note this for users. It’s also worth mentioning that users will need a token for authentication when downloading private models from Hugging Face.

Thanks @hiento09 for explaining. Marking as complete, thanks for unblocking the e2e tests.
Will keep in mind if users get this error
Noted to add a note in docs that users need an authentication token when downloading private models from Hugging Face


Additional Exporting Features

When I export data to JSON or XML output data is limited compared to what is available in display in addon GUI. Some categories not exported include decay loss per reduction in exact amount, total decay for period requested, decay as a % instead of a whole number (reports as 25 instead of 25% or 0.25), raid attendance % per ID, raid attendance for period requested, weekly gains per ID, total spent per ID, total received per ID, total blocked per ID, total decayed per ID. Would also like to export as a CSV file in addition to XML and JSON.
It would be helpful to have this information included with exported data. It would be convenient for the exported data to be in CSV.
Not many alternative options exist to the suggestion.
Thank you for the consideration and hard work.

I agree with the request for adding a CSV export option. Our GM would like to be able to export data for specific raids as well, so if a method was added to export based on Raid that would be really appreciated!


Exclude image digest verification on nightly builds

Nightly builds can contain images with tags

Hi @jiridanek @jstourac we can close this merge request without merging.
Today I received info that nightly builds builds will be the same as RC builds once we onboard on konflux.
So, no need to to introduce such a new tag.


Code blocks do not show as bold when the user uses three Backticks

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

open any chat
start message with # and add space ,add a code block using three Backtick

Expected Result:
should show bold text
Actual Result:
text are not bold (with single Backtick text shows as bold)
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.2. 50-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/211117180-d924e6e2-c47c-443a-a1ac-806c4dfebee3.mov
https://user-images.githubusercontent.com/43996225/211117191-05e46919-3ecc-413a-b144-e45c4f6f6166.mp4
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1672998135151449
View all open jobs on GitHub

Oh yeah I can replicate this

I think this is external, personally

I think this should internal.
Sending
# ```test```

Is parsed and transmitted correctly as:

test

However when we get the pusher notification the transmitted message is malformed as:

test

Haven't had a chance to look into this yet but will check tomorrow to confirm @s77rt's comment

Yep, looks like we modify this in our internal sanitizeAndValidateComment() function here cc: @yuwenmemon as you last modified that logic

Not overdue

@muttmuure please remove Help Wanted Label!

@francoisl is taking this over. Because he is a hero among men.

It looks like the root issue is that putting a
 block inside an
 block is not valid according to the HTML specs.
You can test the following snippet on the W3 validator:

H1 text
pre
 rest of H1

and it shows an error

Our backend uses the HTMLPurifier lib, which cleans up the HTML input and reorganizes the tags to make them valid (example). I looked at the HTMLPurifier docs and I don't see a way to disable this behavior (and even if there was a way, I don't know if we'd want to disable that setting).
I think our options are:

Not parse the triple backticks into a
 block if we're inside a header. This is what we already do with quotations (>). It would look like this:

Instead of converting # to an
 block, use a different HTML like  or
, which would be stylized to have bigger font.

Haven't had time to work on this recently, hoping to get back to it soonish.

https://expensify.slack.com/archives/C01GTK53T8Q/p1676373597239839
I think we should close this and create a new issue different reproduction steps - the unexpected behaviour is that the bold appears then disappears from the code block. Codeblocks shouldn't be bolded

Tagged @kavimuru here with next steps: https://expensify.slack.com/archives/C049HHMV9SM/p1676480283232819?thread_ts=1672998135.151449&cid=C049HHMV9SM


Keep trailing whitespaces in commit message

Hi!
 However the commit hooks have a bit strange behavior: The text is only added to the end of the commit message if the commit message ends with a space (no idea why this is the case).
However this is no problem for me: I simply create a git commit message template that ends in a new line with a space. This works totally fine when using git commit from the command line. After the commit is done, the space is removed and the commit message looks as expected. But when I commit from within VS Code, it seems that the commit message editor removes trailing spaces before passing the message to git.
Can the behavior be disabled?
Thanks,
Torsten

Could you fix the commit hooks instead? It seems odd that we'd not trim the input here....

Not that easy, since the commit hooks are not maintained by me but by a different department. I could also think of other reasons to use the commit message unmodified, so I'd not consider this as a workaround for a bug in a different piece of software.

other reasons to use the commit message unmodified

Can you elaborate on this?

Sometimes whitespaces have a meaning. Perhaps this is only for formatting reason, perhaps some other tool like our commit hook is relying on this.
I just looked into the commit hook, but the logic is too complicated for me ;-)
Perhaps we can adapt the hook, there's some special handling of "footer" which I haven't heard before.
Nevertheless in my opinion there should be a way to pass user-defined input unmodified to underlying tools, regardless of which UI and which tool.

Perhaps we can adapt the hook, there's some special handling of "footer" which I haven't heard before.

Let me know how it goes.

Hi!
Today I learnt that the commit hook is not done by us, but taken from gerrit and only adapted to our needs. See here for the rationale:
https://gerrit-review.googlesource.com/Documentation/cmd-hook-commit-msg.html
I understand that there are some special marker in the commit message (e.g. signed-off) that need to be last. That's why the hook works in the way it does, resulting in this strange behavior. Of course someone could fix it (if he mastered the scripting magic of this hook), but I cannot, and also the colleagues I asked cannot fix this. The hook has a rather complicated logic, and changing things like the footer handling that we don't fully understand might have unforeseen impact.

Got it. In any case I don't think this warrants the change you're proposing in VS Code, so I'll close down the issue.


Invalid arguments in d3 with ie9

I detected that when I use your code is working for most of every browser but not for ie9 and it is because a quotation required and it is showing an error in d3 library.
The problem is in the lines 246 and 247.
in internet explorer 9 needs the quotation around the zeros as well the other properties, so if you change:
.style('top', 0)
.style('opacity', 0)
to
.style('top', '0')
.style('opacity', '0')
With this small change this code will work for all browsers since i9 and it will helps with the browser compatibilities

Thanks for reporting this.  I've added this bug fix to the latest version.
Note that I don't have ie9, so I cannot test the fix.  However, given the trivial nature of the change I'm assuming that the revised version will work right away.  If I'm wrong, please let me know!


Prevent refresh on connected clients

Is it possible to prevent clients apps from being refreshed with I do mup deploy?
E.g. I've got a screen where people will be having a video conference, similar to Google Hangout but in my own app. If their client refreshes they will loose communication. What would be the way around this?
Thanks,

You need to disable the hot code push. There are packages that do that:
https://atmospherejs.com/solderzzc/disable-hot-code-push
or you can do that manually
http://stackoverflow.com/questions/27682888/how-can-i-disable-live-reload-in-meteor


Settings-Archive-Admin-App - Sprint 1

Description:

Build the Screen using the style guide.
Integrate Screen with the Backend

@Vic-Orlands

@Vic-Orlands

I would like to work on this task.Thank you


(vim) Fix for issue #2390

Use Get-ChocolateyUnzip instead of Install-ChocolateyZipPackage to install Vim.
Description
As mentioned in #2390, I replaced Install-ChocolateyZipPackage with Get-ChocolateyUnzip in the installation script.
Motivation and Context
Fixes issue #2390, where auto-validation fails because of a missing checksum required with Install-ChocolateyZipPackage
How Has this Been Tested?
After applying the fix, I downloaded the Vim zip files and created a package with choco pack.
I installed this on a VM, and it installed Vim without errors.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[x] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[ ] I have updated the package description and it is less than 4000 characters.
[x] All files are up to date with the latest Contributing Guidelines
[x] The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.
[x] The changes only affect a single package (not including meta package).

:white_check_mark: Package verification completed without issues. PR is now pending human review

Btw, that virtualbox is horribly slow for some reason. Is that a known issue?

If you are on Windows and have any Hyper-V features enabled, then Virtualbox is very slow. It's a limitation of how Hyper-V works, that it prevents Virtualbox from directly accessing the native virtualization support on the processor.
https://docs.oracle.com/en/virtualization/virtualbox/6.0/admin/hyperv-support.html

Thank you for the PR @n3wjack


Better explain the building process

Currently, the Readme only explain how to compile the library Rust side.
No explanations are given on how to compile and run Java side.
The build_jar.sh script is very useful and we can use it, but we should move it outside the /ci folder and give further instructions in the Readme.

Done in 530fd625a6defd488b287e5e8b8591fc191f35a3


Traceback on Session Polling in main

Session polling was using an incorrect filter on InternetExchangePeeringSession.objects.get() causing the below traceback.
Traceback:
~/development/peering-manager main* ⇡ 6s                                                                                11:28:21
peering-manager ❯ ./manage.py poll_peering_sessions --all -v 3
Traceback (most recent call last):
  File "./manage.py", line 11, in <module>
    execute_from_command_line(sys.argv)
  File "/home/jamesditrapani/development/peering-manager/env/lib/python3.7/site-packages/django/core/management/__init__.py", line 419, in execute_from_command_line
    utility.execute()
  File "/home/jamesditrapani/development/peering-manager/env/lib/python3.7/site-packages/django/core/management/__init__.py", line 413, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/jamesditrapani/development/peering-manager/env/lib/python3.7/site-packages/django/core/management/base.py", line 354, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/jamesditrapani/development/peering-manager/env/lib/python3.7/site-packages/django/core/management/base.py", line 398, in execute
    output = self.handle(*args, **options)
  File "/home/jamesditrapani/development/peering-manager/peering/management/commands/poll_peering_sessions.py", line 40, in handle
    internet_exchange.poll_peering_sessions()
  File "/usr/lib/python3.7/contextlib.py", line 74, in inner
    return func(*args, **kwds)
  File "/home/jamesditrapani/development/peering-manager/peering/models/models.py", line 744, in poll_peering_sessions
    internet_exchange=self, ip_address=ip_address
  File "/home/jamesditrapani/development/peering-manager/env/lib/python3.7/site-packages/django/db/models/manager.py", line 85, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "/home/jamesditrapani/development/peering-manager/env/lib/python3.7/site-packages/cacheops/query.py", line 351, in get
    return qs._no_monkey.get(qs, *args, **kwargs)
  File "/home/jamesditrapani/development/peering-manager/env/lib/python3.7/site-packages/django/db/models/query.py", line 424, in get
    clone = self._chain() if self.query.combinator else self.filter(*args, **kwargs)
  File "/home/jamesditrapani/development/peering-manager/env/lib/python3.7/site-packages/django/db/models/query.py", line 941, in filter
    return self._filter_or_exclude(False, args, kwargs)
  File "/home/jamesditrapani/development/peering-manager/env/lib/python3.7/site-packages/django/db/models/query.py", line 961, in _filter_or_exclude
    clone._filter_or_exclude_inplace(negate, args, kwargs)
  File "/home/jamesditrapani/development/peering-manager/env/lib/python3.7/site-packages/django/db/models/query.py", line 968, in _filter_or_exclude_inplace
    self._query.add_q(Q(*args, **kwargs))
  File "/home/jamesditrapani/development/peering-manager/env/lib/python3.7/site-packages/django/db/models/sql/query.py", line 1396, in add_q
    clause, _ = self._add_q(q_object, self.used_aliases)
  File "/home/jamesditrapani/development/peering-manager/env/lib/python3.7/site-packages/django/db/models/sql/query.py", line 1418, in _add_q
    split_subq=split_subq, check_filterable=check_filterable,
  File "/home/jamesditrapani/development/peering-manager/env/lib/python3.7/site-packages/django/db/models/sql/query.py", line 1289, in build_filter
    lookups, parts, reffed_expression = self.solve_lookup_type(arg)
  File "/home/jamesditrapani/development/peering-manager/env/lib/python3.7/site-packages/django/db/models/sql/query.py", line 1115, in solve_lookup_type
    _, field, _, lookup_parts = self.names_to_path(lookup_splitted, self.get_meta())
  File "/home/jamesditrapani/development/peering-manager/env/lib/python3.7/site-packages/django/db/models/sql/query.py", line 1543, in names_to_path
    "Choices are: %s" % (name, ", ".join(available)))
django.core.exceptions.FieldError: Cannot resolve keyword 'internet_exchange' into field. Choices are: advertised_prefix_count, autonomous_system, autonomous_system_id, bgp_state, comments, created, enabled, encrypted_password, export_routing_policies, id, import_routing_policies, ip_address, is_route_server, ixp_connection, ixp_connection_id, last_established_state, multihop_ttl, password, received_prefix_count, service_reference, tagged_items, tags, updated

Fixed in a58e3d1


ZigZag Indicator, Sometime Showing Incorrect Waves for Deviation: 0.1% or more

Which version are you running? The lastest version is on Github. Pip is for major releases.
import pandas_ta as ta
print(ta.version)
0.4.19b0

Have you tried the development version? Did it resolve the issue?
$ pip install -U git+https://github.com/twopirllc/pandas-ta.git@development
Yes

Describe the bug
Sometime the ZigZag Waves are not formed correctly for Deviation: 0.1% or greater
To Reproduce
!pip install -U git+https://github.com/twopirllc/pandas-ta.git@development
from pandas_ta import zigzag
import pandas_ta as ta
import pandas as pd
import numpy as np
import plotly.io as pio
from datetime import date
from datetime import datetime, timedelta
from pytz import timezone
import plotly.graph_objects as go
import plotly.figure_factory as ff
import plotly.express as px
import plotly.io as pio
import yfinance as yf
# Define the stock ticker symbol (replace 'ES=F' with your desired stock symbol)
ticker = 'ES=F'
# Fetch the last 1 day of data with 1-minute intervals
data = yf.download(ticker, interval='1m', period='5d')
# Convert the datetime index from UTC to Eastern Time (US/Eastern)
data.index = data.index.tz_convert('US/Eastern')
df2 = data.copy()
# Flatten the MultiIndex and remove the ticker part (symbol name)
df2.columns = df2.columns.get_level_values('Price')

# Reset index to get a default integer-based index
df2.reset_index(drop=False, inplace=True)

# Using the Pandas-TA zigzag indicator (or other equivalent library like ta-lib or ta)
zigzag_result = ta.zigzag(
    high=df2['High'],      # High prices of the asset
    low=df2['Low'],        # Low prices of the asset
    close=df2['Close'],    # Closing prices of the asset
    legs=3,                # Minimum number of price points required for a significant trend change
    deviation=0.01,        # Minimum 1% price movement to form a new zigzag segment (1% deviation)
    retrace=True,          # Consider retraces before identifying new points
    last_extreme=True,     # Consider the last extreme point in the calculation
    offset=0               # No time offset, meaning Zigzag points will be calculated from the current time
)

df2 = df2.join(zigzag_result)

zigzag_result2 = ta.zigzag(
    high=df2['High'],
    low=df2['Low'],
    close=df2['Close'],
    legs=3,
    deviation=0.1, #0.07
    retrace=True,
    last_extreme=True,
    offset=0
)

df2 = df2.join(zigzag_result2,rsuffix='_zigzag')
df2 = df2.iloc[:-1]

# Filter non-NaN values in ZIGZAGv_0.01%_3 for plotting
valid_zigzag_data = df2[df2['ZIGZAGv_0.01%_3'].notna()]

# Create the figure
fig = go.Figure()

# Adding Candlestick trace
fig.add_trace(go.Candlestick(
    x=df2['Datetime'],  # Assuming `Datetime` is set as index
    open=df2['Open'],
    high=df2['High'],
    low=df2['Low'],
    close=df2['Close'],
    name='Candlesticks'
))

# Adding Zigzag line trace with dots
fig.add_trace(go.Scatter(
    x=valid_zigzag_data['Datetime'],  # Non-NaN indices
    y=valid_zigzag_data['ZIGZAGv_0.01%_3'],  # Non-NaN Zigzag values
    mode='markers+lines',  # Both markers (dots) and lines
    line=dict(color='rgba(0, 0, 255, 0.9)', width=2.5),  # Customize the line color and width
    marker=dict(color='red', size=4),  # Customize the dots color and size
    name='Wave Formation 0.01% DEV'
))

# Filter non-NaN values in ZIGZAGv_0.01%_3 for plotting
valid_zigzag_data2 = df2[df2['ZIGZAGv_0.1%_3'].notna()]
# Adding Zigzag line trace with dots
fig.add_trace(go.Scatter(
    x=valid_zigzag_data2['Datetime'],  # Non-NaN indices
    y=valid_zigzag_data2['ZIGZAGv_0.1%_3'],  # Non-NaN Zigzag values
    mode='markers+lines',  # Both markers (dots) and lines
    line=dict(color='yellow', width=2.5),  # Customize the line color and width
    marker=dict(color='red', size=4),  # Customize the dots color and size
    name='Wave Formation 0.1% DEV'
))

# Set up layout
fig.update_layout(
    title="Price with Higher High and Lower Low Patterns",
    xaxis_title="Date",
    xaxis=dict(
        rangeslider=dict(
            visible=True  # Set to True to make the range slider visible
        )),
    yaxis=dict(
        autorange=True,  # Enable dynamic Y-axis range adjustment
        fixedrange=False  # Allow zooming on the y-axis
    ),
    yaxis_title="Price",
    template="plotly_dark",
    showlegend=True,
    legend=dict(
        orientation='h',  # Horizontal legend
        yanchor='top',
        y=1.5,  # Position legend slightly above the plot
        xanchor='left',
        x=0.5,  # Center the legend horizontally
        font=dict(
            color="grey"  # Change the legend text color here (e.g., 'white', 'black', or any valid CSS color)
        )
    )
)

# Show plot
fig.show()

# Optionally, save the figure to an HTML file
pio.write_html(fig, file='Wave Pattern Formation 5d.html', auto_open=True)

Expected behavior
As Data is coming on 1min Basis, sometimes zigzag are plotted correctly as below.

Screenshots
While Rest of Time Zigzag is not plotted correctly, like below.

Could you share the dataset which results in inconsistent results? Perhaps you can make a temporary csv file to store results. My intuition is that maybe there are null values reported in dataset by yfinance. Did you try using other tickers? If yes, did you face occasional inconsistent results there too?

DataSet ES=F:
df2_output.csv
Output ScreenShot (Yellow Wave: Deviation: 0.1%):

My intuition is that maybe there are null values reported in dataset by yfinance.
No Null Values in OHLC Data, on df2_output.csv file

Datetime	0
Adj Close	0
Close	0
High	0
Low	0
Open	0
Volume	0
ZIGZAGs_0.01%_3	3460
ZIGZAGv_0.01%_3	3460
ZIGZAGd_0.01%_3	3460
ZIGZAGs_0.1%_3	5007
ZIGZAGv_0.1%_3	5007
ZIGZAGd_0.1%_3	5007

Current ScreenShot of ZigZag Waves on 0.1% Deviation for ES=F:

Did you try using other tickers? If yes, did you face occasional inconsistent results there too?

Yes, I check on Other Ticker: DS=F (Dow Futures) on 1 min interval, Same issue coming there.
Dow Futures DataSet Attached as well.

ds=f_output.csv

Hopefully @aligheshlaghi97 has some insight on this or how to fix perhaps? 🤷🏼♂

Hi @twopirllc
Thanks for mentioning me! I’ll take a look and try to address it during the next week.

Hi there everyone. After reviewing the data provided by @divyankm, I’ve come to the following conclusions:
1. Low legs values lead to inaccurate swing detection
When legs is set to very low values (e.g., legs=3), it often results in poor swing detection. For example, a minor bottom might be identified while the chart values are in their peak (or vice versa). Therefore, using very small legs values is not recommended.
2. Right-to-left swing calculation
My code, like TradingView's script, calculates swings from right to left. If the issue in point 1 occurs, the algorithm might fail to identify swings needed to form a proper zigzag. This can lead to large gaps in the chart. However, I couldn’t replicate this specific behavior using TradingView.
The data shared by @divyankm highlights an example of such gaps:

As shown in the chart, no valid peaks are possible after that bottom, leading to the gap.
Lastly, I couldn’t review all of the code in detail, but I would like to ask @twopirllc if there have been any major changes made since the previous code review that might be relevant to this issue.

@aligheshlaghi97
Usually I touch up PRs before pushing to development. Hopefully I didn’t make a mistake in that process. 😅
I’ll take a deeper look next week and compare the commits.
Thanks for helping. 😎


[BugFix] Remove Node permission requirements in WebBaseAction

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[x] Yes, this PR will result in a change in behavior.
[ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[x] 3.0
[ ] 2.5

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:disappointed: fail : 2 / 8 (25.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/http/action/WebBaseAction.java
2
8
25.00%
[182, 183, 222, 223, 224, 225]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:disappointed: fail : 2 / 8 (25.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/http/action/WebBaseAction.java
2
8
25.00%
[182, 183, 222, 223, 224, 225]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

@Mergifyio backport branch-3.2

@Mergifyio backport branch-3.1

@Mergifyio backport branch-3.0


Include libspng as dependency

In line with the Windows binaries. I've backported https://github.com/randy408/libspng/commit/b21b214b01ec6d52b8d733e473f1c6910db64d6f to help https://github.com/libvips/libvips/issues/1748.

Brilliant, thank you.


emailprivacytester.com FAIL

The sandboxed iframe does not protect enough from leaked information.
See https://www.emailprivacytester.com/test?code=5c94fc430dedd107e0336465

Thanks for bringing this up. I will definitely be investigating how this could be improved, however I don't see this as of critical importance considering iOS's built in mail app and gmail's web app still have some failures when testing using this site.
iOS Mail App:


Dupe issue with Smashing

https://github.com/BloodWorkXGaming/ExNihiloCreatio/blob/1.12/src/main/java/exnihilocreatio/compatibility/tconstruct/ModifierSmashing.java#L55
Smashing does not check if the item to be dropped still is in the drop list before putting its own result in. So if it was already moved out of there by another modifier, the block is duped.
Sadly there is no way to specify an execution order for modifiers and traits...

I don't fully understand what you mean, do you mind giving me a modifier combination which causes this to happen?

Sure. Both of these: https://github.com/SleepyTrousers/EnderIO/tree/master/enderio-integration-tic/src/main/java/crazypants/enderio/integration/tic/traits

Ohhhhhhh, I get it now.
However I am not sure how this could be fixed...?
Like I could check whether the list is empty and if it is then don't drop
stuff, but that would prevent blocks which don't drop anything to work.
Or I could check whether the broken block is in the list, but like
Redstone, a block doesn't have to drop itself.
What would he handy is like a droplist altered flag or something....
Any ideas?
Henry Loenwind<EMAIL_ADDRESS>schrieb am Mi., 14. März 2018,
02:27:

Sure. Both of these:
https://github.com/SleepyTrousers/EnderIO/tree/master/enderio-integration-tic/src/main/java/crazypants/enderio/integration/tic/traits
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/BloodWorkXGaming/ExNihiloCreatio/issues/68#issuecomment-372873809,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHwpZhZ2XtUk_7fFu0QNoTZ-zLvka1ICks5teHHugaJpZM4SpbfF
.

Currently no way good way I can think of to fix this, so the blacklist must be enough...


Where to set options?

I'm using the JSX PrettyDiff formatter, which per their docs, have a lot more options that can be set, such as formatObject. I cannot figure out where to set these extra options though.
I tried .jsbeautifyrc and .prettydiffrc but didn't seem to take.

Pretty Diff is growing all of the time. Currently Atom-Beautify supports many of the options and is missing others: https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/prettydiff.coffee#L10
If the option you want is unavailable, I recommend submitting a Pull Request to add support for it! I'd recommend taking a look at https://github.com/Glavin001/atom-beautify/blob/master/docs/add-languages-and-beautifiers.md to get started.

I'm going to close this as a duplicate of https://github.com/Glavin001/atom-beautify/issues/524 which details other Pretty Diff beautifier options that need to be added.


Refactor stats command

Resolves #225

Codecov Report

Merging #258 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #258      +/-   ##
============================================
+ Coverage     83.23%   83.24%   +0.01%
  Complexity     1080     1080
============================================
  Files           148      148
  Lines          3179     3175       -4
  Branches        381      383       +2
============================================
- Hits           2646     2643       -3
+ Misses          442      441       -1
  Partials         91       91

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/tutorspet/logic/util/LessonUtil.java
98.27% <ø> (ø)
8.00 <0.00> (ø)

...t/logic/commands/attendance/StatisticsCommand.java
93.61% <100.00%> (+2.44%)
15.00 <4.00> (+4.00)

...tutorspet/logic/util/AttendanceRecordListUtil.java
96.15% <100.00%> (-0.19%)
25.00 <0.00> (-1.00)

...ain/java/tutorspet/logic/util/ModuleClassUtil.java
91.45% <100.00%> (-0.09%)
37.00 <0.00> (-3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af3e6f9...61c341c. Read the comment docs.


Page Indicator to render with customised color. White background does not display non active indicators.

Feature Request

Why it is needed

Possible implementation

Code sample

Duplicated #98


can you develop similar plugin for obsidian

Didn't have other way to communicate with you.. but it would be great if you could develop similar plugin for obsidian .. if you have the time

I am sorry I will not make one for Obsidian because I have no plan to use Obsidian, but I think there is a similar one already? https://github.com/dhamaniasad/obsidian-rich-links


Add Changelog for new release

List changes between release 2.10.0 and upcoming release (assuming it will be named 2.11.0), as discussed here: https://github.com/jondot/sneakers/pull/372#issuecomment-445372953
Notes:

There were 3 successive commits dealing with the Bunny dependency: bump 2.9.2 to 2.10.0, bump to 2.11.x and, finally, bump and loosen dependency to ~> 2.12. I choose to mention only the last one, as it supersedes the previous two. I did mention the contributors though.
Non-functional changes (docs improvement, code style) are included in one summary, mentioning the contributors: even though they do not affect the functionality, so they do not require a detailed description in the changelog, these contributions do deserve credit
I did not bump up the Sneakers version, as this should be done by maintainers upon releasing, and I assumed the new release will be called 2.11.0. I think it's the appropriate version number, but if this changes the heading in the changelog must also be changed

Thanks everybody for the great work, hoping to see the new release in Rubygems soon :)

@gabrieljoelc is this PR helping you publishing a new release on Rubygems?
Given that the commits included in this release add one backward-compatible feature (support for :bind_arguments option), I think the semver release number should be 2.11.0.

@lucaong yes, this was so helpful. thank you! I will try to get doing the releases some time this week or next.

ugh, been super busy and didn't get to this. sorry! going to shoot for getting this done before 2019 😬


Use node16

Change to use node16 instead of 12 to close #38 Not sure how to test it

Can someone please review this? The warnings are super annoying 😅

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
NodeJS 12 will be deprecated by Summer 2023. Can someone review/merge this PR?

Can this be merged?

Can a maintainer please merge this? Is something still needed?

Any updates here? Because GitHub will soon move to Node16 on the 18th of May
https://github.blog/changelog/2023-05-04-github-actions-all-actions-will-run-on-node16-instead-of-node12/

As this repository seems to have been abandoned, this action should work instead: https://github.com/synopsys-sig/synopsys-action


[Question] Support captcha_rqdata param?

Hey that AI solver support rqdata (hcaptcha enterprise) param? For example Discord giving it in that form:
{
   "captcha_key":[
      "You need to update your app to join this server."


[iOS] 打包项目时遇到的问题与解决方案

在我自己的项目中引入的 IJKPlayer 为自定义编译，在项目打包时出现了以下问题，提供一些解决方案供大家参考
1.
=== BUILD TARGET Runner OF PROJECT Runner WITH CONFIGURATION Release ===
    Target 'Pods-Runner' of project 'Pods' was rejected as an implicit
    dependency for 'libPods-Runner.a' because its architectures 'arm64' didn't
    contain all required architectures 'armv7 arm64'

解决方案
在 Podfile 中添加以下代码：
post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['ARCHS'] = 'arm64'
      config.build_settings['ONLY_ACTIVE_ARCH'] = 'YES'
    end
  end
end

2.
=== BUILD TARGET Runner OF PROJECT Runner WITH CONFIGURATION Release ===
    Building AOT snapshot in release mode (ios-release)...
    arch: posix_spawnp:
    /Users/ray/Documents/flutter/bin/cache/artifacts/engine/ios-release/gen_snap
    shot: Bad CPU type in executable

    Dart snapshot generator failed with exit code 1

    Building App.framework for arm64...
    Building AOT snapshot in release mode (ios-release)...             65.7s
    Built to build/aot/.
    Snapshotting (IOSArch.armv7) exited with non-zero exit code: 1
    Snapshotting (IOSArch.arm64) exited with non-zero exit code: 0
    cp: build/aot/App.framework: No such file or directory
    error: cannot parse the debug map for 'build/aot/App.framework/App': No such
    file or directory
    Failed to generate debug symbols (dSYM) file for
    build/aot/App.framework/App.

解决方案
由于我升级到了 macOS 10.15 会出现该问题，Flutter 项目的 issue 中有解决方案：
参考Issues when using macos 10.15 & ios 13
3.
=== BUILD TARGET Runner OF PROJECT Runner WITH CONFIGURATION Release ===
    Undefined symbols for architecture arm64:
      "___isPlatformVersionAtLeast", referenced from:
          _vtbformat_init in IJKMediaFramework(IJKVideoToolBoxAsync.o)
          _vtbformat_init in IJKMediaFramework(IJKVideoToolBoxSync.o)
    ld: symbol(s) not found for architecture arm64
    clang: error: linker command failed with exit code 1 (use -v to see
    invocation)

解决方案
在 build iOS产物时，将 valid architecture 仅设为 arm64

Thank for issue.


mouseUp action: make element argument optional

When you performing mouseUp, it is not necessary to specify element. You can just release mouse where it has been pressed.
Sometimes driver.moveTo() call in that case may cause some webdriver issues, so it would be nice to make mouseUp work without arguments.

didn't find tests for mouseUp. Where can I add testcase for new feature?

@SevInf

@just-boris there is no tests for Actions right now so we can probably just igonre coveralls for this PR

Well, what do you think about that request? Nothing changed for existing tests, just new behaviour introduced.

Yes, it is save to merge it


feature complete platforms/doors

[ ] Trigger by direct User Interaction (By pressing "use")
[ ] Trigger by switch Interaction

[ ] When switch is pressed

[ ] When switch is active

[ ] When switch has deactivated

[ ] When another platform has begun moving

[ ] When  another platform has stopped

[ ] Trigger by stepping on platform

[ ] Platform trigger delay (for M1 strats)

[ ] Crush damage
[ ] Move along platforms
[ ] Ignore world collsions, do not ignore player/enemy collisions
[ ] Signals

[ ] Platform stopped

[ ] Platform started

[ ] Platform enabled

[ ] Platform disabled

Some notes about visual language:
MRC will need two classes of door:

gameplay doors, which replicate original M1 doors on maps

eye-candy doors, which demark new cosmetic rooms that branch off the original level layout, making environments feel large and purposeful for players who wish to explore the Deimos world fully but which do not impact gameplay and can be ignored by those who just want to run and gun along the original routes.

Simplest way to distinguish between them is for gameplay doors to open vertically (this way they preserve all their original behaviors, including crushing) while eye-candy doors slide or swing.
We will need concept designs for doors. Most Deimos doors are 1x1WU which allows us to standardize. Some are 0.5x1WU, e.g. the access hatch to the service tunnels. I cannot recall offhand where there are larger doors on later levels.
Aesthetically, I am using “Habitation”, “Science”, and “Engineering” as loose Environment categorizations corresponding to the 3 original Deimos texture sets. That being said, we can freely mix and match textures within a map; e.g. while the start of Arrival is “Habitation”, the service tunnels may be classed as “Engineering”.
While we only need to implement a couple doors for Arrival, we should plan all door designs now. We’ll need to prepare design sheets before we approach Bungie, so they can see how we intend to redecorate the other 26 levels. And by doing them all at the same time, we achieve final consistency when everything’s fitted together at the end.
M1 doors tend to be extremely simple in appearance, usually 1-poly. That’s something I improved on in Trojan, with recessed grooves and stripey borders. For MRC, we can afford to build door components with door frames included. Frames not only make doors look more visually interesting, they also simplify mapmaking as the frame covers any imperfect joins between walls and doors.
We can also build “locked” vs “unlocked” vs “inert” (dummy) status indicators into doors and/or door frames, e.g. small red/green/off lights, thereby indicating to players if a door that buzzes when TABbed does so because it’s locked (i.e. the player needs to unlock it) or because it never opens (because there is no map on the other side). For instance, of the first two doors in Arrival in the brightly lite anteroom, the west door (into the landing bay) cannot open, whereas the east door (into the exit room) is openable only once the player unlocks it (from the other side). Thus the landing bay door’s indicators would be off and the exit door’s indicators would be red. The service tunnel hatch (in the pattern buffer room) would have a green indicator, i.e. it can be freely opened by the player at any time.
–
As to platforms, best split those into a separate task as they will have their own set of  requirements and changes to consider.

yeah, in this case we talk mostly about the doors/platforms code-wise, they will be the same in the core, and we can integrate the features you just mentioned on top of it

Codewise they’ll be similar but not identical. e.g. We want true platforms/elevators, with open volume below as well as above, which will require obstruction detection underneath as well as above the moving ledge.
The simplest way to develop platforms is to create the Door class first, then duplicate that class and rename the duplicate Platform. We can then work on the Platform implementation independently and, if it ends up being 95% identical to the Door code, refactor into common base class plus 2 subclasses as the end.
…
Before we start implementing platforms we need to go through all maps, identifying all of the doors and platforms that currently exist, and categorizing them according to size, type, and gameplay role in a spreadsheet. That will tell us what we can build as standard reusable meshes and code, and what will be bespoke one-off scripted events. There are quite a few M1 door and puzzle platforms which have NOT aged well which we’ll want to replace with modern puzzle designs.
For example: We can replace Colony Ship’s notorious platforms with mobile ceiling cranes for lifting cargo containers, requiring the player to pick up and maneuver containers to form a floating suspended “walkway” from one end of the room to the other, which they can then run across to the exit door. This honors the spirit of Colony Ship without inflicting the original’s atrocious gameplay mechanics on modern gamers.
…
Fortunately, we can ignore platforms for Demo. There’s only 2 minor elevators in Arrival’s service tunnel. We’ll replace both with ladders, which will look a lot better and eliminate user frustration waiting for silly lifts to arrive.
For now, let’s just focus solely on getting common doors and door behaviors right. Arrival has 2 standard types of door: hab doors (1x1WU) and service hatches (0.5x1WU). I will do some visual designs today.
Also take a look at Wheeels’s Door classes, which implement basic behaviors such as direct vs remote triggering, keycard activation, animation sequences, and collision detection. There may be better ways to build doors (I am no Godot guru) but it’s a useful reference to start from.

Reportandome

@hhas About the doors/platforms, we have designed them in a way that these will be useful for either, will be able to fine tune their behaviour however we need/please and will allow us to just drag and drop three nodes at most, then the mesh can be whatever we want and it should work just fine, don't worry much about it


TV OS support

Please add a support for the tv os.

Also looking for this feature.

It looks like there is tvOS support for DVR if installed via Carthage. Not only is there a shared scheme in DVR.xcodeproj "DVR-tvOS", but I have successfully installed DVR via Carthage.
It does not, however, appear that there is a line in the podspec defining the build for tvOS via Cocoapods. This is probably not too difficult to fix.


release: New workflow

release: New workflow

:tada: This PR is included in version 1.0.48 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


"Future getSMSList(String url) async" never returns a list

"Future getSMSList(String url) async" in twilio_flutter/lib/models/sms.dart never returns a list. It always returns null because the function does not specify a Future return type.
Please see https://stackoverflow.com/questions/59027206/flutter-async-function-from-a-different-class-prints-okay-but-returns-null for a similar scenario.

Thank you. Will resolve.

Method deprecated in the latest release. Added another method for the same.


compile error on VC++ 2015

Hello, all the header files fail to compile to lines that use this declaration:
static_assert(std::is_floating_point<Vector2::Type>::value,	"Type must be floating-point");
with the following error:
'std::is_floating_point': 'dt::Vector2::Type' is not a valid template type argument for parameter '_Ty'	d:\programming\delaunay-triangulation-master\dt_test\dt_test\vector2.h
Any idea how to fix it? Thanks

Could you give me more context please? Is this from the example, the test or another file?

Hello, sorry for being vague. The error is related to header files, for example the vector2.h one.
The line
"static_assert(std::is_floating_point<Vector2::Type>::value,	"Type must be floating-point");"
will issue the error mentioned above. I'm using VC++ 2015.
If you want I can send the whole solution file to try...
Also, and more important, is there any way to make it support 3D delaunay triangulation?
Thanks

What I meant was where did this happened. Is this from a piece of code you wrote, or is this from compiling the tests or the example?

It's indeed from the original project files.


REST API return incorrect data

StackStorm version st2 3.6.0, on Python 3.6.9
Endpoint GET /api/v1/actions returns actions with parameters but some parameters are missing or incomplete.
Examples:

action HTTP  from core package in parameters that return the API endpoint doesn't have url parameter which is required.
action announcement from core package doesn't have all data for parameters (eg. type). Look at the pictures

This is is not an API bug per se, but "feature" of the webui.  The webUI will resolve the action metadata and, for completeness, the runner metadata and present it.  The st2 cli tools doesn't resolve runner metadata automatically, so you get the same output as a raw API call.
st2 action get -j core.announcement
{
    "description": "Action that broadcasts the announcement to all stream consumers.",
    "enabled": true,
    "entry_point": "",
    "id": "612cf0f24d30afa26ef56b8c",
    "metadata_file": "actions/announcement.yaml",
    "name": "announcement",
    "notify": {},
    "output_schema": {},
    "pack": "core",
    "parameters": {
        "experimental": {
            "default": true,
            "immutable": true
        },
        "message": {
            "description": "Message to broadcast.",
            "type": "object"
        }
    },
    "ref": "core.announcement",
    "runner_type": "announcement",
    "tags": [],
    "uid": "action:core:announcement"
}

st2 runner get -j announcement
{
    "description": "A runner for emitting an announcement event on the stream.",
    "enabled": true,
    "id": "612cf0f14d30afa26ef56b62",
    "name": "announcement",
    "output_schema": {},
    "runner_module": "announcement_runner",
    "runner_package": "announcement_runner",
    "runner_parameters": {
        "experimental": {
            "default": false,
            "description": "Flag to indicate acknowledgment of using experimental runner",
            "required": true,
            "type": "boolean"
        },
        "route": {
            "default": "general",
            "description": "The routing_key used to route the message to consumers. Might be a list of words, delimited by dots.",
            "maxLength": 255,
            "minLength": 1,
            "type": "string"
        }
    },
    "uid": "runner_type:announcement"
}

I don't think altering the API behaviour now is an acceptable solution.  Perhaps a new route could be added to the API that handles the action+runner metadata lookup to be returned in a single call.


Support for .NET Standard

Xamarin app development in Visual Studio 2017 is going to adapt .NET Standard libraries more and more. Most of the Xamarin.Plugin libraries that I'm using in my project were already ported to use .NET Standard (Geolocator, External Maps, Permissions, etc.). FilePicker is still using PCL, so I set out to port it to .NET Standard.
Here is a pull request with my porting efforts. Please check each commit and accept it, request modifications or cherry-pick changes as you like.
Unfortunately when developing with Visual Studio 2017, Microsoft dropped support for Windows 8.1 and Windows Phone 8.1, so I also had to remove it from the .sln file. The projects are still there.
I also moved and modified the .nuspec file, as in the current location no package could be built. I set the version to "2.0.0-beta", which should allow publishing the package to NuGet.org without disturbing users of previous versions.
The projects build without errors and the "nuget pack" generates a NuGet package that works in my Android-only project. As the platform-dependent projects weren't touched, I expect that other platforms work OK, too.
Finally, maybe this Pull Request should go into a "2.0" or "net standard" branch, since maybe more 1.3.x or 1.4.x versions are needed. I hope my contribution is useful for someone!
Note: This is adapted from the pull request on ArtjomP's fork of the FilePicker plugin: https://github.com/ArtjomP/FilePicker-Plugin-for-Xamarin-and-Windows/pull/4

I removed the old projects, as you suggested, commit b6fb674.

Great! Thanks!

Can anyone tell me how to resolve this issue as I am not able to use this IOS device

I'm sorry but I don't see what issue you are referring to by this PR. Please open an issue and fill out the template or raise a question on StackOverflow if you need help with consuming this library.

System.NotImplementedException: This functionality is not implemented in the portable version of this assembly

@ask-himanshu please read the README for this project, the exact issue is described in the troubleshooting section. Also check the sample project if that works on iOS and compare with your project. Thanks!


Larger M2 spacer hole on PCB to accomodate M2 Nylon Hex Type

Currently, the M2 spacer PCB hole can only accommodate brass type spacer (around 3.14mm diameter).
The nylon hex type (some people uses it for color coordination of black/white pcb/plate) like this one https://www.aliexpress.com/item/1005002263436936.html . This nylon spacer has 4.0mm diameter and can't go through the current hole size (4.3mm drill hole).
Even the Corne R2G edition has way larger hole for more spacer choices (https://groupbuys.mechboards.co.uk/wp-content/uploads/2021/07/HR2G_0000_20210603_112634.png).
Let me know where do you want to consolidate the discussion. Here or at https://github.com/foostan/crkbd/discussions/132
Cheers and thanks!

already fixed at v4


Load the user's ptpython config file

Load the user's ptpython config file when running the shell_plus command with the ptpython or ptipython REPLs. Refs django-extensions/django-extensions#711

thanks !

This commit might have introduced a bug,
python manage.py shell_plus --ptipython
Traceback (most recent call last):
File "/home/shane/.virtualenvs/sendbloom/local/lib/python2.7/site-packages/django_extensions/management/commands/shell_plus.py", line 273, in get_ptipython
from ptpython.ipython import embed, run_config
ImportError: cannot import name run_config

@sac2171 could you please try again with this patch ?

just saw this @trbs, that patch fixes the issue.

Great :)


an abused third-party chrome extension ?

sorry for my english ...
recently i downloaded a extension from chrome webstore , draw.io Desktop
now every time i access any website, it would insert a script and 3 statics to extcoolmake.xyz, when i turned this extension off, it disappears ...
i'm not sure what is it ...

This isn't ours, see the author. We don't produce any browser extensions.

@bear-shen The Chrome Web Store is a cesspool of malware. I strongly advise not using any extensions in Chrome.
@davidjgraph It'd probably be good to report malicious uses of your code and brand though.

We've tried multiple time, they won't remove anything unless we have a trademark on "draw.io".

@davidjgraph You'd think the fact that it's adware that injects malicious advertising into random websites the user visits would be reason enough for Google to act, but malware makes Google a lot of money, it seems. :|

Just way too big and they under-resource everything except search and cloud platform. Chrome Web Store has been DOA for years.


windows: support app store symbolic links

IO_REPARSE_TAG_APPEXECLINK are types of links that are created when
installing an application via the Windows App Store. The location
of these links is added to the Windows PATH and the system can
resolve them. This adds support for these links so go can resolve them.
Illustrated to work in oh-my-posh and confirmed by end-users.
To reproduce the current issue:

Install a Windows Store App like Python3.10
The executable is added to your PATH and can be called from any terminal python3 --version
Resolving the executable in PowerShell points to $Env:LOCALAPPDATA/Microsoft/WindowsApps/python3.exe which is a symbolic link
Trying to resolve the symbolic link in golang 1.17 results in an error as IO_REPARSE_TAG_APPEXECLINK isn't supported: os.Readlink(C:/Users/jan/AppData/Local/Microsoft/WindowsApps/python3)

With this change IO_REPARSE_TAG_APPEXECLINK is now supported  and os.Readlink(C:/Users/jan/AppData/Local/Microsoft/WindowsApps/python3.exe) returns the actual path to the executable.

JanDeDobbeleer:symbolic-app-store-links

JanDeDobbeleer:symbolic-app-store-links


[HTML5] Remove "fixed-size.html".

No longer used in 3.3+.
Closes #48484

Cherry-picked for 3.4.

Cherry-picked for 3.3.1.


How to include /lib/x86_64-linux-gnu/libc.so.6

Helllo, thank you very much for ruby-packer.
Now I see error
./rails: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.17' not found (required by ./rails)I think there is any extra flags to g++ for include it. Something like:-D__STDC_FORMAT_MACROS -std=c++11 -static -static-libgcc -static-libstdc++It maybe passed through option--make-args=ARGS`
But how?
Does anyone know little example for it?
And it maybe important: I built on Ubuntu 16 and try start it on Ubuntu 12

solve: build and run on Ubuntu 16.


[EventRequest] codeunit 6622 “Copy document mgt”,  RecalculatePurchLine [Local]

Please add a new publisher event OnBeforeRecalculatePurchLine in Codeunit 6622 on function RecalculatePurchLine and call it in the start of the function

Please add the corresponding Integration Event In the bottom of the codeunit

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

What is the status on this publisher, we can't seem to find it in the currentbuild 15.2 .


How Web Publishing In Visual Studio Works contains images referring to dnu publish

https://docs.asp.net/en/latest/publishing/web-publishing-vs.html has links to images that refer to dnu publish - e.g.:

@sayedihashimi @moozzyk @Rick-Anderson If it's just a matter of making those two images say "dotnet publish" (with a change of font to match the font used in the other boxes), would you like me to knock that out real quick? I'm certainly the least busy of four of us. :smile:

@GuardRex - thanks for fixing this!

@moozzyk np ... If I can help with the RTM docs push, let me know. :+1:


transmission-daemon stop working

Hello,
I use google-drive-ocamlfuse, version 0.6.21 and transmission-daemon 2.84 on a headless vps provided by 1&1. Transmission stop working when adding or seeding torrent after a short time, but the process isn't kill. So I set up incomplet directory in transmission and it works well, but seeding still no working.
I also use it with plex and got no problems.
I mount google drive with this: google-drive-ocamlfuse -label me -o allow_other gdrive/
Here is my .gdfuse/me/config

apps_script_format=json
apps_script_icon=
async_upload=true
cache_directory=
client_id=1258***
client_secret=4avF***
connect_timeout_ms=5000
curl_debug_off=false
data_directory=
delete_forever_in_trash_folder=false
docs_file_extension=true
document_format=odt
document_icon=
download_docs=true
drawing_format=png
drawing_icon=
form_format=zip
form_icon=
fusion_table_format=desktop
fusion_table_icon=
keep_duplicates=false
large_file_read_only=false
large_file_threshold_mb=16
log_directory=
lost_and_found=false
low_speed_limit=0
low_speed_time=0
map_format=desktop
map_icon=
max_cache_size_mb=512
max_download_speed=0
max_memory_cache_size=10485760
max_retries=8
max_upload_chunk_size=1099511627776
max_upload_speed=0
memory_buffer_size=1048576
metadata_cache_time=380
presentation_format=pdf
presentation_icon=
read_ahead_buffers=3
read_only=false
root_folder=
shared_with_me=false
spreadsheet_format=ods
spreadsheet_icon=
sqlite3_busy_timeout=5000
stream_large_files=false
umask=0o002
verification_code=

Here is my directory permissions:
gdrive mount directory drwxrwx--- 2 cadiyak debian-transmission 4096 Oct 14 20:42 gdrive
Is this an google-drive-ocamlfuse issues or is this transmission ? Or maybe it's just no possible to get this working.
Sorry for my bad english.

Downloading/seeding torrents is not really supported because Google Drive API doesn't work well with file chunks, but accepts only whole files.


usbfs: process uuu did not claim interface 0 before use

I get the following messages in dmesg:
hid-generic 0003:15A2:0080.002A: hiddev2,hidraw4: USB HID v1.10 Device [Freescale SemiConductor Inc  SE Blank 6ULL] on usb-0000:00:14.0-3/input0
usb 1-3: usbfs: process 17860 (uuu) did not claim interface 0 before use

Does it impact function or warning message?
what's your libusb version? which linux distribution do you running?

@nxpfrankli was this fixed for Ubuntu? Using the 1.2.135 release
dmesg:
[ 4156.049696] usb 1-1: New USB device found, idVendor=1fc9, idProduct=0134
[ 4156.049698] usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=0
[ 4156.049699] usb 1-1: Product: SE Blank M845S
[ 4156.049700] usb 1-1: Manufacturer: NXP      SemiConductors Inc
[ 4156.060513] hid-generic 0003:1FC9:0134.000B: hiddev0,hidraw0: USB HID v1.00 Device [NXP      SemiConductors Inc  SE Blank M845S ] on usb-0000:00:1d.7-1/input0

uuu
mfgtools/uuu$ ./uuu ../../L4.14.78_1.0.0_ga_images_MX8MQEVK/uuu.auto
uuu (Universal Update Utility) for nxp imx chips -- libuuu_1.2.135-0-gacaf035

Success 0    Failure 0

1:1      1/ 1 [=================100%=================] SDP: boot -f imx-boot-imx8mqevk-sd.bin-flash_evk

then nothing...

ehrm... realized I tried to flash 8MQ onto a 8MM EV-Kit
a nice thing would be an error message that compares the USB product-id and simply report if the build-tree mismatches what you're trying to flash

L4.14.78_1.0.0_ga_images_MX8MQEVK/imx-boot-imx8mqevk-sd.bin-flash_evk have not included chip information.

I've got the same problem with my Eaton 5P 850 running IPP on Ubuntu 18.04.  I keep getting dmesg such as :
[ 9288.709526] usb 1-1: usbfs: process 18322 (Eaton-IPP) did not claim interface 0 before use
[ 9299.567961] usb 1-1: usbfs: process 4375 (usbhid-ups) did not claim interface 0 before use
Ignore the process numbers and other data.
The Eaton 5p 850 is connected via its USB port
I've also got NUT installed and can access the 5P ok.
But IPP will connect and then fail with comms error but after some hours seems to reestablish the connection, some times.
lsusb gives:
Bus 001 Device 002: ID 0463:ffff MGE UPS Systems UPS
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
dmesg gives
dmesg |grep 0463
[    2.499855] usb 1-1: New USB device found, idVendor=0463, idProduct=ffff
[    9.860456] hid-generic 0003:0463:FFFF.0001: collection stack overflow
[    9.860462] hid-generic 0003:0463:FFFF.0001: item 0 1 0 10 parsing failed
[    9.860480] hid-generic: probe of 0003:0463:FFFF.0001 failed with error -22
where's Bus 001 Device 002 gone?  None of this looks right!
If I do:
sudo upsdrvctl stop
Network UPS Tools - UPS driver controller 2.7.4
If I then do:
sudo upsdrvctl start
I get:
Network UPS Tools - UPS driver controller 2.7.4
Network UPS Tools - Generic HID driver 0.41 (2.7.4)
USB communication driver 0.33
Using subdriver: MGE HID 1.39
I'm no expert in this area but it looks like the usbhid-generic and usbhid-ups are trying to both be allocated.
If anyone can help on this it'd most welcome.


applying remote font css, reverting some doc-specific overrides

 (1) Reactions: Use proxima nova from static.getambassador.com for demo site


Generate open api v3 spec from Spring MVC RestControllers code

Is your feature request related to a problem? Please describe.
We need to be able to extract the openapi specs from Spring MVC RestControllers code dinamically
Describe the solution you'd like
It would be nice to have the specs generated (json, yaml) from Spring MVC RestControllers with v3 annotations at build time.
Describe alternatives you've considered
We've tried Kongchen's plugin but seems like it does not support open api v3 specs yet
Additional context

Related to #37


doc: clarify onClick and onChange arg structure

More clearly show that onClick and onChange take objects as arguments.

Thank you!!!


[Fix #7161] Fix Style/SafeNavigation cop to preserve comments

Closes #7161.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@tejasbubane I think this is ready to merge if you just fix the conflicts.

@jonas054 Fixed merge conflicts. I think the build failure is unrelated.


Move example into Swift snippet

The example from the README would make a great snippet (as per this recently merged proposal).

Fixed in 76b530ad81d8e9728ceb1502593a08e49fcb4cc1


Add shortcut to relevant Ingress(es) and Service(s) from the workload detail page

Issue description:
The endpoint column in the workload overview links to the ingress-nginx service ip of the correlated controller or to one of the kubernetes nodes ip not the actual ingress URL in the hyperlink text.
Business impact:
Makes the UI a less reliable tool for their end-users and they have to jump through more hoops outside Rancher to get the same work done.
Troubleshooting steps:
Click endpoints on deployments in UI
Repro steps:

Create deployment with ingress/endpoints
Click the endpoint

Actual behavior:
Links to IP of the node or controller
Expected behavior:
Link to the actual mentioned endpoint

I believe this is the expected behavior because in Kubernetes, workloads aren't supposed to have any knowledge of DNS. There is an intentional decoupling of workloads, services and ingress because there's not necessarily a one-to-one correlation of endpoints to workloads in Kubernetes. The "endpoint" they see on the list of deployments is taken from the Pod spec and it should not have any reference to how you can access that workload from the outside world. For example in the below screenshot, the Longhorn UI is running on simply "80/HTTP" and that's correct.

Then if you have an ingress pointing to a service that points to the Longhorn UI (for example, example.com/longhorn), you do get a working URL. That's also correct:

What they are requesting is reasonable, but I would say that you should get information through the Related Resources tab. If anything, you should be able to:

Go to the Deployments list and click a Deployment name
Click the Related Resources tab. It might be useful if that tab listed Services that direct traffic to this Deployment through selectors. Currently that's not how it works - it only lists items that refers to this Deployment by name.
Hypothetically, if the Service was listed, you could click that. Then click the Related Resources of the Service and click related Ingresses. But again, Ingresses aren't going to be in the Related Resources tab because Ingresses refer to Services based on selectors instead of by name.
Then you could click the ingress you want and get to the endpoint from there.

I would say that for the person who opened this ticket, they would be better off going to the Ingresses list and accessing their endpoints from there. Then if we really to be able to work backward to endpoints from workloads, we could open a separate ticket for enhancing the Related Resources tab to also show items that are related based on selectors, but that would be more complicated.

Internal reference: SURE-3675. I'll provide this feedback and see what comes back.

Vince said this issue is an enhancement rather than a bug so I have opened a separate issue describing the enhancement https://github.com/rancher/dashboard/issues/4974

One option would be to make the displayed endpoint for a workload configurable as suggested here https://github.com/rancher/dashboard/issues/4707

Related or possibly duplicate issue https://github.com/rancher/dashboard/issues/4190

Neil removed the endpoint links in lists where there are a large number of workloads because it is expensive to get the endpoints for each workload. Today we discussed that the endpoints column is also misleading because users who are coming from an older version of Rancher expect the endpoint to be for an ingress, whereas in Rancher v2.6.x it's taken from the Pod spec. Any single endpoint could communicate an oversimplification of any Service(s) and/or Ingresses that are already set up. So we discussed that it would be better to put this information in the workload detail page where we can do it more justice.

QA Template
What was fixed, or what changes have occurred
In the workload detail page (this page is reused for Deployments, StatefulSets and ReplicaSets), the Services tab now lists all the Services that select Pods in the workload, while the Ingresses tab lists any Ingresses that would direct traffic to one of those Services.
Areas or cases that should be tested
To test this PR, this is what I did. I tested it on a downstream RKE2 cluster on EC2 with the Amazon cloud provider enabled.

Created this example Deployment, taken from the upstream Kubernetes docs.

apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app.kubernetes.io/name: load-balancer-example
  name: hello-world
spec:
  replicas: 5
  selector:
    matchLabels:
      app.kubernetes.io/name: load-balancer-example
  template:
    metadata:
      labels:
        app.kubernetes.io/name: load-balancer-example
    spec:
      containers:
      - image: gcr.io/google-samples/node-hello:1.0
        name: hello-world
        ports:
        - containerPort: 8080

Created a service exposing the Deployment. My Service YAML ended up looking like this:

spec:
  allocateLoadBalancerNodePorts: true
  clusterIP: <IP_ADDRESS>
  clusterIPs:
  - <IP_ADDRESS>
  externalTrafficPolicy: Cluster
  internalTrafficPolicy: Cluster
  ipFamilies:
  - IPv4
  ipFamilyPolicy: SingleStack
  ports:
  - nodePort: 31327
    port: 8080
    protocol: TCP
    targetPort: 8080
  selector:
    app.kubernetes.io/name: load-balancer-example

Created a basic Ingress with YAML like this:

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  annotations:
    field.cattle.io/publicEndpoints: '[{"addresses":["<IP_ADDRESS>"],"port":80,"protocol":"HTTP","serviceName":"default:my-service","ingressName":"default:test-ingress","hostname":"example.com","path":"/foo","allNodes":false}]'
  creationTimestamp: "2022-07-10T14:16:21Z"
  generation: 1
  name: test-ingress
  namespace: default
  resourceVersion: "199858"
  uid: 317155df-eef4-48cb-991a-b3ac0467bd53
spec:
  rules:
  - host: example.com
    http:
      paths:
      - backend:
          service:
            name: my-service
            port:
              number: 8080
        path: /foo
        pathType: Prefix

In Cluster Explorer, went to the detail page for the hello-world Deployment.
Went to the Services tab and confirmed that the newly created Service is listed:

Went to the Ingresses tab and confirmed that the newly created Ingress is listed:

Confirmed that if the user does not have permission to see Services or Ingresses, it explains that it is empty due to lack of permissions:

Confirmed that if you do have permission but the list is genuinely empty, it explains that no resources were found:

What areas could experience regressions?
The changes were limited to tabs on this detail page. I expect the other tabs to work the same as they did before.

@ronhorton  please work this ticket when you have time :) Thanks!

Verified using QA Template

In the workload detail page:

If the user has permission to see Services, the Services tab lists all the Services that select Pods in the workload
If the user has permission to see Ingresses, the Ingresses tab lists any Ingresses that would direct traffic to one of those Services


[FLINK-16532][core] Shouldn't trim whitespaces in Path

What is the purpose of the change
To fix the issue that Flink doesn't support trailing whitespaces for partition values, which is allowed in Hive.
Brief change log

Don't trim whitespaces in Flink Path.
Update related tests for Path.
Add test case for Hive connector.

Verifying this change
Existing and new test case.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): yes
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? NA

Ping @JingsongLi for review.
@fhueske It'd be great if you can have a look too.
Thanks.

@lirui-apache Can you change pull request and JIRA? This seems Path problem. But your title looks like hive bug.

@JingsongLi Thanks for your review. Updated title and commit message.

Thanks @lirui-apache for contribution, merging...


unhide custom settings option in protocol options

This has been implemented by https://github.com/envoyproxy/envoy/pull/9964
Commit Message:unhide custom settings option
Additional Description:unhide custom settings option in protocol options
Risk Level:N/A
Testing:N/A
Docs Changes:N/A
Release Notes:N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/retest

Reassigned @lizan as api shepherd

I don't have the original PR context, @alyssawilk did the deprecation PR described https://github.com/envoyproxy/envoy/pull/9964/files#r394441848 happen?

allow_connect doesn't look deprecated so I'm going with "no"
I think to unhide this, we should deprecate allow_connect, and config-check that if custom_settings_parameters is used, that allow_connect is not true, and update the comments for this field as well as relevant docs.

Oh. I did not know the dependency on allow_connect. Will close this PR.


Wait for it licence

The wait-for-it.sh script was introduced in fcad46fcd38fb67ecb0cb2631fb66b2904f582ed.
It looks like the version at https://github.com/vishnubob/wait-for-it/blob/8ed92e8cab83cfed76ff012ed4a36cef74b28096/wait-for-it.sh, whose licence is MIT and includes the clause:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

See: https://github.com/vishnubob/wait-for-it/blob/8ed92e8cab83cfed76ff012ed4a36cef74b28096/LICENSE.

MIT License is fine.

I don't think this is a choice...

There's no choice as far as whether we have to include the MIT license, we do. The choice is whether we can/should include MIT code in an Apache project. We can and we do.


We are able to save the old dates which are already passed.while adding special price  for any product

Issue Description
When we are applying Special Price in the Product from the Admin end, there when we fill the Start Date and End Date, there when we fill the old dates which are already passed and then when we save the Product. We are able to save the Product.
Bagisto Version
MASTER
Steps To Reproduce
1. Go to Admin -> Catalog -> Products -> Create/Edit -> Price -> Special Price -> End Date and Start Date.
2. Now Fill Old Date in both Start and End Date -> And Save the Product after filling necessary Fields.
3. In Store front we will not be able to see the special price related concern.
Actual Result
Please check the Video/Screenshot for a better understanding of the issue.
Video
https://user-images.githubusercontent.com/92721837/192497404-ff5b16a1-dca9-4f0a-817b-07574c5540df.mp4
Expected Result
Validation need to be imposed here as old dates should not be saved.

@jitendra-webkul
As we discuss this is not an issue so I am closing this issue.


 IF YOU DO NOT FOLLOW THE FORMAT OR MAKE A GENERIC TOKEN REQUEST YOUR ISSUE WILL BE DELETED WITHOUT COMMENT
YOUR JUSTLIST MUST FOLLOW THE JSON SPECIFICATION
https://github.com/justswaporg/justlists/example.justlists.ts
Checklist

[x] I understand that this is not the place to request a token listing.
[ ] I have tested that my JustList is compatible by pasting the URL into the add a list UI at justswap.org.
[ ] I understand that filing an issue or adding liquidity does not guarantee addition to the justlists website.

Please provide the following information for your token.
JustList URL must be HTTPS.
JustList URL: https://github.com/BobbyRad/1/blob/main/didcoinlist.json
JustList Name: Didcoin list
Link to the official homepage of the JustList manager: https://github.com/BobbyRad

Sorry, your issue will be closed as you did not submit your information in the correct format.


Some Architechture Concerns

Hey, @tshemsedinov
Let's look on the sample code.
async ({ countryId }) => {
  const fields = ['cityId', 'name'];
  const where = { countryId };
  const data = await db.select('City', fields, where);
  return { result: 'success', data };
};

It seems the same as an old-school express-handler:
export default async function countryCities({ locals: { db }, body: { countryId } }, res) {
  const fields = ['cityId', 'name'];
  const where = { countryId };
  const data = await db.select('City', fields, where);
  res.json({ result: 'success', data });
}

However, the last one contains the dependency contract but the first one requires code to be read and analyzied to get aware about the dependencies. Impress uses implicit service locator to inject dependencies, so the dependency contracts are always hidden.
Both samples implement business logic inside of the infrastructure level. More then the DB is accessed directly from the request controller,
I guess the good example for that should look like that:
./src/use-cases/get-cities-by-country-id.ts
import type { City } from "./domain";
import type { ICitiesByCountryIdProvider } from "./interfaces";

export const getCitiesByCountryId =
  ({ countryId }: { countryId: number }) =>
  ({ cities }: { cities: ICitiesByCountryIdProvider }): Promise<City[]> =>
      cities.getByCountryId(countryId);

So, what do you think about to make impress more freandly to clean architecture?

Import/export (common.js and esm modules) are actually far from clean architecture, because you need to know certain places where other modules located. It's a hardcoded paths (worst case) or dependency locator (best case). But we need dependency injection for low coupling. It's ok to me to have coupling with interfaces (but not from certain files). It's not acceptable to have coupling with not abstract code from certain files. We use v8 sandboxes for DI to build namespaces like domain.moduleName.methodName and we have auto loader for metarhia modules.
Last example is short so putting logic to api handler is ok, bit for larger apps we need domain services located in application/domain. All we wall to achieve with syntax in a first example is to have minimal code, even in if it will be implicit or magic, but it is clear and short.

we will never use explicit import/export in any syntax
we will never use typascript mixed with javascript code, we use schemas for domain code and autogenerated .d.ts files for metarhia internal modules
we will never use class for domain model
we will never support ORMs or allow something ORM-friendly

See also: https://github.com/metarhia/Manifesto/blob/master/RU/Technology.md

Import/export (common.js and esm modules) are actually far from clean architecture, because you need to know certain places where other modules located

it is not correct. To import some utilities from certain place doesn't counter the clean architecture. More then it is much better then inject (in any way) absolutely everything.
Clean Architechture doesn't mean absolutely low-coupled code. It means architecture supports incremental development without rewriting the existing code base

It's ok to me to have coupling with interfaces (but not from certain files). It's not acceptable to have coupling with not abstract code from certain files

What is an issue with importing interfaces from some specific file? It is a matter of compiler (transpiler). And actually it is dificult to imagine more abstract code then interface

Last example is short so putting logic to api handler is ok
The Express developers had such considerations too :)
The samples work as patterns.
The violation of principles in any specific project file causes the Broken Window Effect in the whole project

We use v8 sandboxes for DI to build namespaces like domain.moduleName.methodName and we have auto loader for metarhia modules

what if we need to run the code on the other engine?
what if we need to re-use some code in other nodejs project without impress?
domain.moduleName.methodName -- also refers to the specific file. More then it refers in runtime (I hope in some observable future we will have inlining for functions and for imported functions as well, so this approach could block this issue). IMHO, to import from some index file is better then to glue the file structure to module implementation. I'm using nextjs with file-structure-based routing -- it is a pain (because I cannot import whole page tree and have to import each page explicitly).

we will never use explicit import/export in any syntax

it makes learning curve steeper but gives any valuable benefit

we will never use typascript mixed with javascript code, we use schemas for domain code and autogenerated .d.ts files for metarhia internal modules

it makes runtime performance suffer.
the IO data should be verified with schemas but not the domain logic, so such verification should be performed on the infrastructure-layer (controller, repo/dao etc).

we will never use class for domain model

we don't use classes at all and so what?

we will never support ORMs or allow something ORM-friendly

I support this. Absolutely support. ORM-models tend to leak and to get ubiquitous


When is going to be availabe a new release 2.4.2?

The current version of master fixes some errors (see #201) that I need for my project. I'm using this library from bower so I'm wondering when it is going to be released a new version with this fixes (I know that the fixes are currently merged in master).
Do you have any available roadmap? Do you have some issues to fix before releasing a new version? Maybe I can help.

it would be very cool. i don't know what is it - roadmap


Power - Mod Power

Solution Added to the Repo : https://github.com/jarvismayur/Hackerrank-Problem-Solutions/blob/main/Python/Power - Mod Power/Power_-_Mod_Power.py

Docs are available here : https://github.com/jarvismayur/Hackerrank-Problem-Solutions/tree/main/Python#power---mod-power


Test against modern node versions

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Storage accounts and keys in source code is poor engineering practice

Please provide us with the following information:

This issue is for a: (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

In https://github.com/Azure-Samples/batch-python-quickstart/blob/master/src/python_quickstart_client.py there are a number of hardcoded global constants:
_BATCH_ACCOUNT_NAME =''
_BATCH_ACCOUNT_KEY = ''
_BATCH_ACCOUNT_URL = ''
_STORAGE_ACCOUNT_NAME = ''
_STORAGE_ACCOUNT_KEY = ''
_POOL_ID = 'PythonQuickstartPool'
_POOL_NODE_COUNT = 2
_POOL_VM_SIZE = 'STANDARD_A1_v2'
_JOB_ID = 'PythonQuickstartJob'
_STANDARD_OUT_FILE_NAME = 'stdout.txt'
This is terrible engineering practice.  Instead these should be fed from externalized config and secrets to the application.  Worse, our customers follow this sample, directly copy and pasting it into their solutions and this bad engineering practice is multiplied across all of them.
Any log messages given by the failure

Expected/desired behavior

Use externalized config and secrets to manage this.
OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

@timfpark - Thanks for the feedback. Agreed, passing secrets in clear text is not good engineering practice for production code. However, it is common in quickstart samples for this and other Azure services (for example, Storage), to focus on essential service features. I will follow up with engineering partners to see if they have examples of managing Batch secrets. Or we might mitigate by adding text note here and in related articles.

@dlepow i did a pull request for same could you let me know when it will be merged ?

@abhishekmishragithub - Abhishek, thanks for this contribution. It looks like a straightforward addition and I'll merge after running through it once. Cheers, Dan.

@dlepow Thanks 👍


HAITATON-17 Update email template johtoselvitys-valmis

Description
Change based on Gofore maintenance ticket HAITATON-17

Moi, https://github.com/City-of-Helsinki/haitaton-backend/blob/main/email/johtoselvitys-valmis.mjml -tiedosto pitäisi vaihtaa uuteen. Uudessa tiedostossa palautelinkin osoite ja allekirjoitus vaihdettu. Uusi tiedosto löytyy liitteenä.

Jira Issue:
Type of change

[ ] Bug fix
[ ] New feature
[x] Other

Instructions for testing
Please describe tests how this change or new feature can be tested.
Checklist:

[ ] I have written new tests (if applicable)
[ ] I have ran the tests myself (if applicable)
[ ] I have made necessary changes to the documentation, link to confluence
or other location:

Other relevant info
Please describe here if there is e.g. some requirements for this change or
other info that the tester/user needs to know.

Our email building is not working properly. The actual template isn't getting updated. Looks like Gradle has changed something without us noticing it.
Can you change line 158 of services/hanke-service/build.gradle.kts to:
        from(file("${layout.buildDirectory.get()}/mjml/main/"))

And then run ./gradlew copyEmailTemplates and add the changes to services/hanke-service/src/main/resources/email/template/johtoselvitys-valmis.html.mustache to this PR.

Also, there's a text version of the email in services/hanke-service/src/main/resources/email/template/johtoselvitys-valmis.text.mustache, which needs to be updated separately.

@AaroHuttula should I change something else other than links here: https://github.com/City-of-Helsinki/haitaton-backend/blob/HAITATON-17/update-email-johtoselvitys-valmis/services/hanke-service/src/main/resources/email/template/johtoselvitys-valmis.text.mustache

@martinkankaanranta Should the signature be changed to the updated one on this file as well?

@martinkankaanranta

Restore the branch or create a new branch with the same changes.
Open a PR for merging it to main.
Squash and merge the PR.
Azure DevOps -pipelines will build and install the changes to staging.
Test the changes to the emails. I added your Gofore-email to our whitelist, so you can use your own email for receiving the email.
Allow the DevOps-pipeline to continue to development.
Merge the changes from main back to dev, via a PR.