ENH: Handle error strings in a way that doesn't produce compile warnings

Compiler warnings are being elevated to errors when encountered by SimpelITKRInstaller - presumably a change of defaults in the package build process in more recent versions of R.
The various prints are all errors, so the calls have also been changed to REprintf

Please rebase the changes onto the release branch.
Also can we get more detains about the compatibility of these functions. We should be able to list compatibility with R versions of the R Rprintf and the new REprintf methods.

Hi @richardbeare,
Please provide more details in the commit message. Specifically, what build warning and at what version of R was it changed to an error. We want to be able to test these things on the development machines.
Also, I believe this change replaces printing to std::out with printing to std:err. The change makes sense in that the original code was printing to the wrong location, is this both a build fix and bug fix at the same time?

Will get onto the rebasing - apologies, I always forget where to begin the modifications.
Further details that will get included in the new PR.
Warnings/errors raised below, on ubuntu 22, R 4.4.1. The warnings are elevated to errors by R when installation via SimpleITKRInstaller is attempted.
There are two changes - string formatting and use of REprintf. @zivy zivy Do you prefer them to be separate commits in the next PR, or is documentation sufficient?
/tmp/RtmpSL0fo1/R.INSTALL1a911b1dcfc5df/SimpleITK/SITK/SimpleITK/Wrapping/R/sitkRArray.cxx: In function ‘SEXPREC* ImAsArray(itk::simple::Image)’:
/tmp/RtmpSL0fo1/R.INSTALL1a911b1dcfc5df/SimpleITK/SITK/SimpleITK/Wrapping/R/sitkRArray.cxx:54:15: error: format not a string literal and no format arguments [-Werror=format-security]
   54 |       Rprintf(error_msg);
      |               ^~~~~~~~~
/tmp/RtmpSL0fo1/R.INSTALL1a911b1dcfc5df/SimpleITK/SITK/SimpleITK/Wrapping/R/sitkRArray.cxx:207:15: error: format not a string literal and no format arguments [-Werror=format-security]
  207 |       Rprintf(error_msg);
      |               ^~~~~~~~~
/tmp/RtmpSL0fo1/R.INSTALL1a911b1dcfc5df/SimpleITK/SITK/SimpleITK/Wrapping/R/sitkRArray.cxx: In function ‘itk::simple::Image ArrayAsIm(SEXP, std::vector<unsigned int>, std::vector<double>, std::vector<double>, unsigned int)’:
/tmp/RtmpSL0fo1/R.INSTALL1a911b1dcfc5df/SimpleITK/SITK/SimpleITK/Wrapping/R/sitkRArray.cxx:237:13: error: format not a string literal and no format arguments [-Werror=format-security]
  237 |     Rprintf(error_msg);
      |             ^~~~~~~~~
cc1plus: some warnings being treated as errors
make[5]: *** [Wrapping/R/CMakeFiles/SimpleITK_R.dir/build.make:460: Wrapping/R/CMakeFiles/SimpleITK_R.dir/sitkRArray.cxx.o] Error 1
make[4]: *** [CMakeFiles/Makefile2:1855: Wrapping/R/CMakeFiles/SimpleITK_R.dir/all] Error 2
make[3]: *** [Makefile:156: all] Error 2
make[2]: *** [CMakeFiles/SimpleITK-build.dir/build.make:76: SimpleITK-prefix/src/SimpleITK-stamp/SimpleITK-build] Error 2
make[1]: *** [CMakeFiles/Makefile2:289: CMakeFiles/SimpleITK-build.dir/all] Error 2
make: *** [Makefile:91: all] Error 2
ERROR: configuration failed for package ‘SimpleITK’
* removing ‘/home/richard.beare/R/x86_64-pc-linux-gnu-library/4.4/SimpleITK’

See PR - #2207
This is branched from release.

Will get onto the rebasing - apologies, I always forget where to begin the modifications.
Further details that will get included in the new PR. Warnings/errors raised below, on ubuntu 22, R 4.4.1. The warnings are elevated to errors by R when installation via SimpleITKRInstaller is attempted.
There are two changes - string formatting and use of REprintf. @zivy zivy Do you prefer them to be separate commits in the next PR, or is documentation sufficient?
/tmp/RtmpSL0fo1/R.INSTALL1a911b1dcfc5df/SimpleITK/SITK/SimpleITK/Wrapping/R/sitkRArray.cxx: In function ‘SEXPREC* ImAsArray(itk::simple::Image)’:
/tmp/RtmpSL0fo1/R.INSTALL1a911b1dcfc5df/SimpleITK/SITK/SimpleITK/Wrapping/R/sitkRArray.cxx:54:15: error: format not a string literal and no format arguments [-Werror=format-security]
   54 |       Rprintf(error_msg);
      |               ^~~~~~~~~
/tmp/RtmpSL0fo1/R.INSTALL1a911b1dcfc5df/SimpleITK/SITK/SimpleITK/Wrapping/R/sitkRArray.cxx:207:15: error: format not a string literal and no format arguments [-Werror=format-security]
  207 |       Rprintf(error_msg);
      |               ^~~~~~~~~
/tmp/RtmpSL0fo1/R.INSTALL1a911b1dcfc5df/SimpleITK/SITK/SimpleITK/Wrapping/R/sitkRArray.cxx: In function ‘itk::simple::Image ArrayAsIm(SEXP, std::vector<unsigned int>, std::vector<double>, std::vector<double>, unsigned int)’:
/tmp/RtmpSL0fo1/R.INSTALL1a911b1dcfc5df/SimpleITK/SITK/SimpleITK/Wrapping/R/sitkRArray.cxx:237:13: error: format not a string literal and no format arguments [-Werror=format-security]
  237 |     Rprintf(error_msg);
      |             ^~~~~~~~~
cc1plus: some warnings being treated as errors
make[5]: *** [Wrapping/R/CMakeFiles/SimpleITK_R.dir/build.make:460: Wrapping/R/CMakeFiles/SimpleITK_R.dir/sitkRArray.cxx.o] Error 1
make[4]: *** [CMakeFiles/Makefile2:1855: Wrapping/R/CMakeFiles/SimpleITK_R.dir/all] Error 2
make[3]: *** [Makefile:156: all] Error 2
make[2]: *** [CMakeFiles/SimpleITK-build.dir/build.make:76: SimpleITK-prefix/src/SimpleITK-stamp/SimpleITK-build] Error 2
make[1]: *** [CMakeFiles/Makefile2:289: CMakeFiles/SimpleITK-build.dir/all] Error 2
make: *** [Makefile:91: all] Error 2
ERROR: configuration failed for package ‘SimpleITK’
* removing ‘/home/richard.beare/R/x86_64-pc-linux-gnu-library/4.4/SimpleITK’

Any idea on compatibility of this change?  With what version of R is it required? With what versions of R is it compatible? Will it break any older versions of R?

I don't anticipate problems with older versions of R. I have only
encountered the elevation of warnings with 4.4.1.
On Tue, Oct 22, 2024 at 12:40 AM Bradley Lowekamp @.***>
wrote:

Will get onto the rebasing - apologies, I always forget where to begin the
modifications.
Further details that will get included in the new PR. Warnings/errors
raised below, on ubuntu 22, R 4.4.1. The warnings are elevated to errors by
R when installation via SimpleITKRInstaller is attempted.
There are two changes - string formatting and use of REprintf. @zivy
https://github.com/zivy zivy Do you prefer them to be separate commits
in the next PR, or is documentation sufficient?
/tmp/RtmpSL0fo1/R.INSTALL1a911b1dcfc5df/SimpleITK/SITK/SimpleITK/Wrapping/R/sitkRArray.cxx: In function ‘SEXPREC* ImAsArray(itk::simple::Image)’:
/tmp/RtmpSL0fo1/R.INSTALL1a911b1dcfc5df/SimpleITK/SITK/SimpleITK/Wrapping/R/sitkRArray.cxx:54:15: error: format not a string literal and no format arguments [-Werror=format-security]
54 |       Rprintf(error_msg);
|               ^~~~~~~~~
/tmp/RtmpSL0fo1/R.INSTALL1a911b1dcfc5df/SimpleITK/SITK/SimpleITK/Wrapping/R/sitkRArray.cxx:207:15: error: format not a string literal and no format arguments [-Werror=format-security]
207 |       Rprintf(error_msg);
|               ^~~~~~~~~
/tmp/RtmpSL0fo1/R.INSTALL1a911b1dcfc5df/SimpleITK/SITK/SimpleITK/Wrapping/R/sitkRArray.cxx: In function ‘itk::simple::Image ArrayAsIm(SEXP, std::vector, std::vector, std::vector, unsigned int)’:
/tmp/RtmpSL0fo1/R.INSTALL1a911b1dcfc5df/SimpleITK/SITK/SimpleITK/Wrapping/R/sitkRArray.cxx:237:13: error: format not a string literal and no format arguments [-Werror=format-security]
237 |     Rprintf(error_msg);
|             ^~~~~~~~~
cc1plus: some warnings being treated as errors
make[5]: *** [Wrapping/R/CMakeFiles/SimpleITK_R.dir/build.make:460: Wrapping/R/CMakeFiles/SimpleITK_R.dir/sitkRArray.cxx.o] Error 1
make[4]: *** [CMakeFiles/Makefile2:1855: Wrapping/R/CMakeFiles/SimpleITK_R.dir/all] Error 2
make[3]: *** [Makefile:156: all] Error 2
make[2]: *** [CMakeFiles/SimpleITK-build.dir/build.make:76: SimpleITK-prefix/src/SimpleITK-stamp/SimpleITK-build] Error 2
make[1]: *** [CMakeFiles/Makefile2:289: CMakeFiles/SimpleITK-build.dir/all] Error 2
make: *** [Makefile:91: all] Error 2
ERROR: configuration failed for package ‘SimpleITK’* removing ‘/home/richard.beare/R/x86_64-pc-linux-gnu-library/4.4/SimpleITK’
Any idea on compatibility of this change? With what version of R is it
required? With what versions of R is it compatible? Will it break any older
versions of R?
—
Reply to this email directly, view it on GitHub
https://github.com/SimpleITK/SimpleITK/pull/2205#issuecomment-2426719224,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAF6RIMAY6QGZGHDKEBNEGTZ4T755AVCNFSM6AAAAABP2KC6PCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRWG4YTSMRSGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


docker 패키지 업데이트하면 Docker driver 빌드 실패

As-is:
❯ echo $GO111MODULE
on

cd cb-spider/cloud-control-manager/cloud-driver/drivers/docker-plugin
./build_driver_lib.sh
# Driver build successful

Update docker package:
go get -u -v github.com/docker/docker
git diff
-       github.com/docker/docker v0.0.0-20200309214505-aa6a9891b09c
+       github.com/docker/docker v1.13.1

Build Docker driver again:
❯ ./build_driver_lib.sh
# github.com/cloud-barista/cb-spider/cloud-control-manager/cloud-driver/drivers/docker/resources
../docker/resources/VMHandler.go:257:58: too many arguments in call to vmHandler.Client.ContainerWait
../docker/resources/VMHandler.go:257:94: undefined: container.WaitConditionNotRunning
../docker/resources/VMHandler.go:259:21: invalid operation: <-errCh (receive from non-chan type error)
../docker/resources/VMHandler.go:264:14: invalid operation: <-statusCh (receive from non-chan type int64)
note: module requires Go 1.13

#216 과 같은 내용입니다. 깜빡했습니다.


ruby case of inline 'compact block'

to prevent 'do|arg|' when using on *.map {(no whitespace)|arg| .....}

Thanks, I'm not even sure how I managed to not notice this issue for so long.


⚠ Bofrost.es has degraded performance

In 031ab8a, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1574 ms

Resolved: Bofrost.es performance has improved in 182457e after 6 minutes.


adding WezTerm

Added Wezterm

Do we know the title of a WezTerm window will contain "WezTerm"?

I installed it on my mac and it logged apps_used as "WezTerm"

And I juxst installed on linux and it reports " org.wezfurlong.wezterm" :-D


Injecting a validator instance is propagating trough the entire components tree

Versions

vee-validate: 2.1.3
vue: 2.5.17

Describe the bug
Automatic injection doesn't work properly anymore. Something is injecting the same $validator instance in virtually any existing component (even upstream, starting with Root).
Creating an isolated validation scope doesn't work anymore.
To reproduce
Just inject a $validator in any component, no matter its position in the parent-child tree.
Expected behavior
Should work according to the official documentation. Reverting to 2.0.0 (trying to pin point the exact version that introduced this issue) works as expected.

The issue doesn't manifest on 2.0.9 , but it's becoming an issue from 2.1 (I guess introduced by new Validation Components API)

Could you try to reproduce it on Codesandbox? I didn't observe this behavior so far.


kubernetes-metrics-server: 0.6.2 -> 0.6.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/kubernetes-sigs/metrics-server/releases.
meta.description for kubernetes-metrics-server is: Kubernetes container resource metrics collector
meta.homepage for kubernetes-metrics-server is: https://github.com/kubernetes-sigs/metrics-server
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.6.3 with grep in /nix/store/qwgji8ya35n9a7yzldvxzfkj4cdc2v0x-kubernetes-metrics-server-0.6.3
found 0.6.3 in filename of file in /nix/store/qwgji8ya35n9a7yzldvxzfkj4cdc2v0x-kubernetes-metrics-server-0.6.3

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
kubernetes-metrics-server

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qwgji8ya35n9a7yzldvxzfkj4cdc2v0x-kubernetes-metrics-server-0.6.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A kubernetes-metrics-server https://github.com/r-ryantm/nixpkgs/archive/21832bd52db3871501488777a6c2b98c63c0133a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qwgji8ya35n9a7yzldvxzfkj4cdc2v0x-kubernetes-metrics-server-0.6.3
ls -la /nix/store/qwgji8ya35n9a7yzldvxzfkj4cdc2v0x-kubernetes-metrics-server-0.6.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

kubernetes-metrics-server

Maintainer pings
cc @eskytthe for testing.

@ofborg build kubernetes-metrics-server kubernetes-metrics-server.passthru.tests

Good guess! Thanks!  And sorry should have checked that myself.


[$250] The delete/backspace key on our Big Number Pad is wrongly designed

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.58-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dannymcclain
Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs
Action Performed:

Launch the app
Tap the green FAB > Submit expense
Observe the delete/back space key

Expected Result:
The delete/backspace icon designed as  left-caret icon.
Actual Result:
The delete/backspace icon designed as text icon
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[x] iOS: Standalone
[x] iOS: HybridApp
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021855590465266571194
Upwork Job ID:<PHONE_NUMBER>266571194
Last Price Increase: 2024-11-10

Issue OwnerCurrent Issue Owner: @DylanDylann

Proposal
Please re-state the problem that we are trying to solve in this issue.
The delete/backspace icon designed as text icon
What is the root cause of that problem?
We're using < text in big number pad:
https://github.com/Expensify/App/blob/580bf69714fcb90fbf96026b3e2fc12f4b556eeb/src/components/BigNumberPad.tsx#L82
What changes do you think we should make in order to solve the problem?

Replace text with Expensicons.BackArrow icon by passing to icon prop of the Button (i.e., text={column === '<' ? undefined : toLocaleDigit(column)}).
Set iconFill={theme.text}.
Introduce a new param iconSize which can be [small, medium, large] to set the size of the icon:
https://github.com/Expensify/App/blob/ab40264dff9a6c21372617c8744b1013c22dd2d2/src/components/Button/index.tsx#L294-L301

Proposal
Please re-state the problem that we are trying to solve in this issue.
showing text instead of icon for back in the BigNumberPad
What is the root cause of that problem?
here:
https://github.com/Expensify/App/blob/580bf69714fcb90fbf96026b3e2fc12f4b556eeb/src/components/BigNumberPad.tsx#L30
we are not adding icon for <
What changes do you think we should make in order to solve the problem?
to the Button here:
https://github.com/Expensify/App/blob/580bf69714fcb90fbf96026b3e2fc12f4b556eeb/src/components/BigNumberPad.tsx#L76-L79
pass this prop:
                               icon={column === '<' ? Expensicons.BackArrow : undefined}

@Expensify/design As in the OP

The delete/backspace icon designed as left-caret icon

Could you guys please help to provide the correct design?

@Expensify/design What do you think about this output from @mkzie2's proposal?

Visually I think that looks correct to me. How tall are those buttons? I believe for buttons that are 52px tall, we use a 20px tall icon inside. So just want to confirm that little detail first before giving the thumbs up.

The solution is straightforward, let's go with @mkzie2's proposal because they go first
🎀 👀 🎀 C+ Reviewed

@shawnborton Ever since https://github.com/Expensify/App/issues/51355, we used 16x16 size for icons inside buttons.

This is the correct version—sorry, I included it in my bug report but didn't post it to the issue!
The icon should be 20x20px and use our icons color:

Ever since https://github.com/Expensify/App/issues/51355, we used 16x16 size for icons inside 52x52 (medium-sized) buttons.

52px is our large size for buttons, and they should use 20px icons as described in this comment from that other issue.

Introduce new params iconSize which can be [small, medium, large] to set the size of the icon:
Or separated iconSmall, iconMedium, iconLarge boolean attributes are also appropriate.

Can you explain this a bit more? We already have props to change the icon size (small, medium and large). Why do we need to add new props?

@dannymcclain I see that the arrow color does not match other numbers color. Is that intended? Can you add mockup for light mode as well?

Why do we need to add new props?

@arosiclair Those are only needed if we want a 16x16 icon (off the current standard). We won't need them if we go with 20x20.

From the mock above, I believe Danny wants the color to be theme.icon. Same color as all our other icons :)
Here's the light version:

Thanks. I got it.

Yup, that looks right regarding the icon color - thanks Jon!
Then for this one:

Those are only needed if we want a 16x16 icon (it's off the current standard). We won't need them if we go with 20x20.

As Danny mentioned, we don't want any special icon sizing here - we want the default icon size that is used for buttons that are 52px tall, and that is 20x20.

Cool let's just use the icon with the 20x20 size 👍

Paid

BugZero Checklist:

[ ] [Contributor] Classify the bug:

Bug classification

Source of bug:

[ ] 1a. Result of the original design (eg. a case wasn't considered)
[ ] 1b. Mistake during implementation
[ ] 1c. Backend bug
[ ] 1z. Other:

Where bug was reported:

[ ] 2a. Reported on production
[ ] 2b. Reported on staging (deploy blocker)
[ ] 2c. Reported on both staging and production
[ ] 2d. Reported on a PR
[ ] 2z. Other:

Who reported the bug:

[ ] 3a. Expensify user
[ ] 3b. Expensify employee
[ ] 3c. Contributor
[ ] 3d. QA
[ ] 3z. Other:

[ ] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:

[ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:

[ ] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:

Regression Test Proposal
Precondition:

Test:

Do we agree 👍 or 👎


Upgrading from 1.x to 2.x Confusion

Hello there. I'm using Sage 9 and working to upgrade the code to the latest version but sadly I can't seem to get it going. I've got the intervention.php in the theme root directory but I can't seem to figure out the code using the examples. Here is what I've got:
`<?php
return [
'wp-admin.{all}' => [
'common.adminbar',
],
];
`
Is that all I need to add into the file to get it to work?

Try remove the braces { } around “all”, that was in the docs to illustrate a variable. I will update the docs to make that more obvious tomorrow.

I have renamed {role} to $role for better clarity.

Thanks for that. Some feedback for the docs for dummies like me, I would suggest a sample file with a typical code set-up. You probably need 2-3 then a quick breakdown of things. There are lots of awesome sample code through the docs but having a working sample with the <?php at the start makes it easy to work off.
Also, you mention the file location for Sage 10. For those using Sage 9 it doesn't go in the theme root directory but it goes into /resources along with the other files like function.php.
Thanks again for your help getting me back on the right path!

Thanks @akasharkbow , I will create a demo file and mention the config file should be from the stylesheet directory versus root folder. Closing for now.


Problem importing sys

Running "KD-DTI" example results in error: src module not found. "BioGPT" directory needs to be added to the path...

Yes, if you run it from path other than the root path of BioGPT, you should add it to the PYTHONPATH


Update to EntityFramework 6.1.3

Is there a reason this library needs to newest? It's more flexible to leave it older and let hosting apps choose to grab the latest.

I don't think so.  I wasn't sure if there would be compatibility issues with not upgrading it.  I guess it's ok to leave it then.

I got some push back from others, thus my reason for asking. Thanks.


Generate 0.7.0 release candidate and update roadmap/release process

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

/lgtm


Stopping kopf takes too long (45+ seconds)

Expected Behavior
Pressing Ctrl+c to stop kopf should stop right away or couple of seconds.
Actual Behavior
Pressing Ctrl+c to stop kopf and it took 45+ seconds to quit. This is very tiresome during development.
Steps to Reproduce the Problem

Run kopf with or without --dev flag
Press Ctrl+c once or twice to stop kopf
Wait long time for kopf to completely stop

I am seeing the same behaviour in Mac OS

Duplicate of #142. This should be fixed with kopf>=0.23rc1 (try 0.23rc4) in #227 (previously attempted in #176 and #152).

@nolar How do I install 0.23r4? I cloned the repo and did a pip install ./kopf and it still installs 0.22. I downloaded the asset and did the same and it still installs 0.22. I tried python setup.py and it threw diff error about setuptools. Thanks.

@nolar I get the error below using 0.23r4 when running kopf with or without `--dev- flag.
$ kopf run release.py                                                                                1 ?
[2019-11-18 11:15:09,115] kopf.reactor.activit [INFO    ] Initial authentication has been initiated.
[2019-11-18 11:15:09,142] kopf.activities.auth [INFO    ] Handler 'login_via_pykube' succeeded.
[2019-11-18 11:15:09,167] kopf.activities.auth [INFO    ] Handler 'login_via_client' succeeded.
[2019-11-18 11:15:09,168] kopf.reactor.activit [INFO    ] Initial authentication has finished.
Traceback (most recent call last):
  File "/home/ctran/.venv/release/bin/kopf", line 8, in <module>
    sys.exit(main())
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/kopf/cli.py", line 31, in wrapper
    return fn(*args, **kwargs)
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/click/decorators.py", line 64, in new_func
    return ctx.invoke(f, obj, *args, **kwargs)
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/kopf/cli.py", line 78, in run
    vault=__controls.vault,
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/kopf/reactor/running.py", line 113, in run
    vault=vault,
  File "/usr/lib64/python3.7/asyncio/base_events.py", line 579, in run_until_complete
    return future.result()
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/kopf/reactor/running.py", line 153, in operator
    vault=vault,
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/kopf/reactor/running.py", line 239, in spawn_tasks
    standalone=standalone, namespace=namespace, name=peering_name,
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/kopf/engines/peering.py", line 116, in detect
    if await Peer._is_peering_exist(name=PEERING_DEFAULT_NAME, namespace=namespace):
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/kopf/engines/peering.py", line 158, in _is_peering_exist
    obj = await fetching.read_obj(resource=resource, namespace=namespace, name=name, default=None)
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/kopf/clients/auth.py", line 34, in wrapper
    return await fn(*args, **kwargs, session=session)
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/kopf/clients/fetching.py", line 57, in read_obj
    url=resource.get_url(server=session.server, namespace=namespace, name=name),
  File "/home/ctran/.venv/release/lib/python3.7/site-packages/aiohttp/client.py", line 442, in _request
    raise ValueError("Cannot combine AUTHORIZATION header "
ValueError: Cannot combine AUTHORIZATION header with AUTH argument or credentials encoded in URL
Task was destroyed but it is pending!
task: <Task pending coro=<_root_task_checker() running at /home/ctran/.venv/release/lib/python3.7/site-packages/kopf/reactor/running.py:418> wait_for=<Future pending cb=[<TaskWakeupMethWrapper object at 0x7f4895054250>()]>>
Task was destroyed but it is pending!
task: <Task pending coro=<_startup_cleanup_activities() running at /home/ctran/.venv/release/lib/python3.7/site-packages/kopf/reactor/running.py:496> wait_for=<Future pending cb=[<TaskWakeupMethWrapper object at 0x7f489503d490>()]>>
Task was destroyed but it is pending!
task: <Task pending coro=<_stop_flag_checker() running at /home/ctran/.venv/release/lib/python3.7/site-packages/kopf/reactor/running.py:447> wait_for=<Future pending cb=[<TaskWakeupMethWrapper object at 0x7f489503d090>()]>>

@chungktran Can you please create this as a separate issue? Please, put this stacktrace there.
And also, if possible, your ~/.kube/config — but please remove any passwords, tokens, secrets, hostnames from there. I would like to understand how both username+password AND a token happen do get there at the same time. If it is not possible — it is fine.

@nolar filed this ticket https://github.com/zalando-incubator/kopf/issues/242

I assume, the original issue is fixed (as it is fixed for our own operators).
If it reappears with kopf>=0.23.2, please re-open this issue or open a new one.


WMS source supported_srs not always respected

Mapproxy 1.12.0
In some cases, the supported_srs parameter for WMS sources doesn't seem to be respected correctly.
Relevant configuration part:
layers:
  - name: overlay_leaftype
    title: overlay_leaftype
    sources: [overlay_leaftype]
caches:
  overlay_leaftype:
    grids: [mercator]
sources:
  overlay_leaftype:
    type: wms
    req:
      url: https://image.discomap.eea.europa.eu/arcgis/services/GioLandPublic/HRL_DominantLeafType_2015/MapServer/WMSServer
      layers: '0'
      transparent: true
    supported_srs: ['EPSG:3857']
grids:
  mercator:
    base: GLOBAL_MERCATOR
    num_levels: 25
    sources: [overlay_leaftype]

Usually, when I have a cache in GLOBAL_MERCATOR and my WMS source is e.g. EPSG:25832, everything works fine. The WMS Source is requested in EPSG:25832 and mapproxy reprojects to GLOBAL_MERCATOR and caches.
However, this does not seem to work if the WMS source is EPSG:3857. In this case, MapProxy will NOT request in EPSG:3857, but instead, it will try to request the WMS in EPSG:900913, which the WMS does not support.
My EPSG File defines EPSG:3857 and EPSG:900913 equally:
# WGS 84 / Pseudo-Mercator
<900913> +proj=merc +a=6378137 +b=6378137 +lat_ts=0.0 +lon_0=0.0 +x_0=0.0 +y_0=0 +k=1.0 +units=m  +nadgrids=@null +wktext  +no_defs <>
# WGS 84 / Pseudo-Mercator
<3857> +proj=merc +a=6378137 +b=6378137 +lat_ts=0.0 +lon_0=0.0 +x_0=0.0 +y_0=0 +k=1.0 +units=m +nadgrids=@null +wktext  +no_defs <>

Sadly, I can't simply change my cache to be in GLOBAL_WEBMERCATOR (EPSG:3857), since I have quite a few users requesting tiles on tiles/1.0.0/overlay_leaftype/EPSG900913.
These users wouldn't be able to reach their tiles any more if I change the cache projection to EPSG3857.
It would be quite nice if mapproxy would allow to configure the cache in one projection and allow querying it in another projection (i.e. on the fly reprojection on cache access, not on source access).
That would allow me to have the cache in EPSG3857 and requests to EPSG900913 would still work.
But that's just a side-note. The original problem is that MapProxy queries the WMS in EPSG900913 instead of the EPSG3857 specified in supported_srs.
EDIT:
Just did some debugging and managed to fix the issue, even though I'm not sure if that's really a good fix - but it works:
diff --git a/mapproxy/source/wms.py b/mapproxy/source/wms.py
index 76a11a0d..507dcf1c 100644
--- a/mapproxy/source/wms.py
+++ b/mapproxy/source/wms.py
@@ -107,8 +107,15 @@ class WMSSource(MapLayer):
         if self.supported_formats and format not in self.supported_formats:
             format = self.supported_formats[0]
         if self.supported_srs:
-            if query.srs not in self.supported_srs:
+            request_srs = None
+            for srs in self.supported_srs:
+                if query.srs == srs:
+                    request_srs = srs
+                    break
+            if request_srs is None:
                 return self._get_transformed(query, format)
+            if query.srs.srs_code != request_srs.srs_code:
+                query.srs = request_srs
         if self.extent and not self.extent.contains(MapExtent(query.bbox, query.srs)):
             return self._get_sub_query(query, format)
         resp = self.client.retrieve(query, format)

EDIT2: Another fix would be changing the eq operator for SRS to not only make sure that the definition is equal, but also that the srs-code is equal. However, I'm not sure what implications that would have in other places...

should be fixed by #446


Conditionally use resource-scoped over provider-scoped project id for…

… serviceaccount resources
Description of your changes
This change allows for import of ServiceAccount resources that have been created in a project other than the one specified in the ProviderConfig. Creation always worked, but the external name template would not take the .parameters.project into account, and so would not Observe the correct resource for import, leading to errors when the provider would try to re-create an existing object.
This PR only addresses ServiceAccount objects, but other ManagedResources that have project as a parameter will likely benefit from a similar approach.
Fixes #263
I have:

[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Manual testing with cross-project service account creation and import after delete/orphan

/test-examples="examples/cloudplatform/serviceaccount.yaml"

Closing & reopening to trigger the Github workflow runs...

/test-examples="examples/cloudplatform/serviceaccount.yaml"


Uncaught TypeError: Cannot read property '0' of undefined

[Enter steps to reproduce below:]

...
...

Atom Version: 1.0.19
System: Mac OS X 10.10.5
Thrown From: spark-dev package, v0.0.31
Stack Trace
Uncaught TypeError: Cannot read property '0' of undefined
At /Applications/Particle Dev.app/Contents/Resources/app.asar/node_modules/spark-dev/node_modules/when/lib/decorators/unhandledRejection.js:80

TypeError: Cannot read property '0' of undefined
  at /Applications/Particle Dev.app/Contents/Resources/app.asar/node_modules/spark-dev/lib/spark-dev.js:790:58
  at tryCatchReject (/Applications/Particle Dev.app/Contents/Resources/app.asar/node_modules/spark-dev/node_modules/when/lib/makePromise.js:845:30)
  at runContinuation1 (/Applications/Particle Dev.app/Contents/Resources/app.asar/node_modules/spark-dev/node_modules/when/lib/makePromise.js:804:4)
  at Fulfilled.when (/Applications/Particle Dev.app/Contents/Resources/app.asar/node_modules/spark-dev/node_modules/when/lib/makePromise.js:592:4)
  at Pending.run (/Applications/Particle Dev.app/Contents/Resources/app.asar/node_modules/spark-dev/node_modules/when/lib/makePromise.js:483:13)
  at Scheduler._drain (/Applications/Particle Dev.app/Contents/Resources/app.asar/node_modules/spark-dev/node_modules/when/lib/Scheduler.js:62:19)
  at Scheduler.drain (/Applications/Particle Dev.app/Contents/Resources/app.asar/node_modules/spark-dev/node_modules/when/lib/Scheduler.js:27:9)
  at doNTCallback0 (node.js:416:9)
  at process._tickCallback (node.js:345:13)

Commands
     -0:28.4.0 spark-dev:append-menu (atom-workspace.workspace.scrollbars-visible-when-scrolling)
     -0:28.2.0 spark-dev:update-menu (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)
     -0:28.2.0 spark-dev:append-menu (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)
     -0:28.1.0 spark-dev:update-menu (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)
     -0:28.1.0 spark-dev:append-menu (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)
     -0:28.1.0 spark-dev:update-menu (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)
     -0:28.1.0 spark-dev:append-menu (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)
     -0:23.2.0 application:open-file (atom-text-editor.editor)
     -0:04.1.0 spark-dev:select-device (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)
     -0:03.1.0 spark-dev:update-core-status (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)
     -0:03.1.0 spark-dev:update-menu (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)
     -0:03.1.0 spark-dev:append-menu (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)
     -0:02.6.0 spark-dev:core-status-updated (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)
     -0:01.1.0 spark-dev:flash-cloud (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)
     -0:01.0 spark-dev:update-compile-status (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-one-dark-ui)

Config
{
  "core": {
    "themes": [
      "one-dark-ui",
      "monokai"
    ]
  }
}

Installed Packages
# User
No installed packages

# Dev
No dev packages

@az-ericso what are the steps to reproduce this issue?

@suda sorry for not being in details.  I just updated the description above.

I am getting the same error and here is what I did to get rid of it!!!
The error appears if I open the source files in a sub-folder like this:

Note the sub-folders under the main folder: "9_All_params_updated". My code is in the sub-folder "SourceFilesWONeoPixelWOSDCard"
Now if I close Particle Dev and reopen directly the folder "SourceFilesWONeoPixelWOSDCard" as shown here:

I am able to compile EXACTLY the same code for both Photon & Core.
So the problem is probably the code & files in other folders. Apparently Particle Dev sends all the sub-folders to Particle for compilation whereas it "should" send only the open folder. Of course, a case can be made for  sending all sub-folders as well. Enjoy!

That is correct, Dev will send whole project to be compiled. Implementing #39 could help specify what to include. But still exception above should be caught and shown in more human readable format.

I'm running into the same issue when trying to integrate httpsclient-particle with Particle Dev.  @puneetteja's workaround did not work for me as it probably has something to do with the httpsclient-particle library specifically.
To reproduce:

Clone the httpsclient-particle repository.
Remove everything with the exception of .c, .h, and .cpp files.
Add the resulting source as a project folder in Particle Dev.
Try to compile the source in the cloud.

Expected: Source compiles.
Results: This bug is referenced and the "compiling in the cloud..." spinning wheel never stops spinning.

@suda I appear to get this error from Spark Dev when my source code reaches an undetermined character threshold. I started hitting it after adding some functions. After trying to debug the functions, I realized that if I simply removed them and added about one hundred lines of white space to my source that it threw the same error.
For the record, I have about 3500 lines (3600+ gets this error). This is in addition to four libraries, three of them considerably large (FastLED, SdFat, and WebServer).
I'd be curious to learn if I get the same error with a local toolchain but I haven't had the time to try to set that up.

@Jerware that's interesting. What is result of CLI's compile command?

I've never successfully compiled from the CLI. I currently get:
Compile failed. Exiting.
undefined
I sent a zip of my source to the email on your profile, but I suspect a maximum payload size is at the root of this error so it's not my particular source code... just the amount of it. Just add a couple hundred lines to mine and it should throw the error.


[move-prover] add an option to ignore pragma opaque in internal functions (2)

Motivation
mvp --ignore-pragma-opaque -- when-possible will completely ignore any pragma opaque specified in functions that are not public or public(script) (i.e., all callers of the function can be found) do not have a [concrete] or [abstract] property in its function spec, Here, "completely ignore" means that the move-model builder will treat it as if the pragma does not exist in the AST level.
To support this, we added a new option type, ModelBuilderOptions, that will be inserted to GlobalEnv before the model builder is invoked and during the model building process, the options can be retrieved via GlobalEnv::get_extension().
This PR also replaces the is_public field in FunEntry with a visibility field, as we now have more than just public/private visibilities.
Test Plan

CI, everything should continue to verify.

This PR also adds a no_opaque test suite which will run the move prover tests, including verification on the diem framework,
with --ignore-pragma-opaque-when-possible on by default.

This will help us catch potential issues when eliminating specs for non-public functions. Currently everything works as expected with only two tests that requires a separate baseline .exp file:
opaque.move and inconsistency.move. This is totally expected.

Running inconsistency tests over the no_opaque testsuite does not trigger an issue as well:

MVP_TEST_INCONSISTENCY=1 cargo test -p move-prover --release

did not report any inconsistency.
NOTE: this PR subsumes https://github.com/diem/diem/pull/8842 so it might be a good idea to land
that PR first.

/canary

:sunny: Canary successful

/land


Investigate syncing issues (websocket and regular)

Time entry still runs in the app although it has been stopped in the web app.
Reported on mac.

Connected to #1665

Log in 243148

We should add more verbose error messages for websocket disconnects.

Reported also with #243338 (has logs if needed).

duplicate of #2051


Encounter error when running command react-native run-ios

Hi,
Does anyone encounter below error when running command react-native run-ios?
The following build commands failed:

	CompileC /Users/luan/work/ltt/projects/pet/repo/PetAppDev/ios/build/Build/Intermediates.noindex/SDWebImage.build/Release-iphoneos/SDWebImage\ iOS\ static.build/Objects-normal/armv7/FLAnimatedImageView+WebCache.o SDWebImage/FLAnimatedImage/FLAnimatedImageView+WebCache.m normal armv7 objective-c com.apple.compilers.llvm.clang.1_0.compiler

But when I build and run app via Xcode I do not encounter any error.
Thank you!

duplicate of #46


Add option to run delombok on java source code before generating AST

This PR adds a bare-bones implementation for running lombok before AST generation which is enabled with the --run-delombok flag. The JAVASRC2CPG_JAVA_HOME environment variable can be set to manually specify which Java version should be used to run delombok (since this does affect the results).

I think you also need to copy the lombok.jar like we do the astgen binaries for jssrc2cpg (https://github.com/joernio/joern/blob/master/joern-cli/frontends/jssrc2cpg/build.sbt#L77) or otherwise is wont be available in the packaged final distribution.

It looks like Lombok is on Maven. Is there any problem with adding it as a regular dependency that made you commit the .jar as a binary blob?

Oh good question @maltek!
If its actually available there and can be used as is we should just add it as dep and use its api.

There are 2 reasons I didn't use lombok as a regular Maven dependency. The most important is that delombok is only available as a task in a package private class, so actually executing the delombok task would require some hacky reflection stuff and even then I'm not sure if it'll work (since it uses further reflection and all of this just sounds like a headache waiting to happen). The second is that, by running the jar separately, we can decouple the java versions used to run joern and lombok.

Could we run s"/some/other/java -cp ${System.getProperty("java.class.path")} lombok.launch.Main ... after adding lombok as a dependency? (I don't really know enough about our deployment or the JVM compatibility story.)
I'll stop bickering if the answer is no.

That's a good thought. I'll give it a shot and update the PR one way or the other

Maybe github does not show me that you used git-lfs to add lombok.jar but if it is correct in that regard remove it and use git-lfs. In general: Do not add binary to our git repos without git-lfs. After you did that please make sure that the commits containing the binary are not referenced anymore so that they will not be delivered in future git-clone to keep the download size small.
I would also favor a solution which fetches lombok like a the other dependencies. To invoke it with a specific jvm version you will likely have to have a look at the sbt-native-packager and as well as our distro packaging in order to find our where the dependency jars end up.

I did not use git-lfs, so thanks for the heads up! I'll look the regular dependency fetching we do if the direct-through-maven approach doesn't work.

General note: please avoid using git-lfs. Github imposed a 1GB rule on bandwidth (!), i.e. each PR build and anyone downloading the repo (git fetch) will contribute towards that and very quickly we've rendered the repo unusable for everyone.
Example from joern: we added 150M files to git lfs on friday, and by sunday no one was able to fetch the repo any longer, until Fabs inserted some coins...


Select all code feature?

Does this library provide a "select all" button so it would be easier to copy & paste the highlighted code? Thanks.

No, that's outside of our scope.

That's fine. Anyway, I will happily implement and use this library tomorrow.


Milestone/Project 1 | animals table 🎫

🚩I have made the following changes to complete Vet Clinic - Milestone/Project 1
Here is a summary of what has been done
Type of files changed/added
, PNG
In this new Branch, I have ➕ADDED➕ the succeeding *📂 folders and/or **📄 files to complete this milestone's requirements.
*📂 root/

**📄 LICENSE ➕

I have added the MIT License to this project.

*📂 src/media/

**📄 vet-clinic-logo.png ➕

I have ✏MODIFIED✏ the succeeding *📂 folders and/or 📄** files
*📂 root/

**📄 README.md ✏

I have modified the documentation following the suggested guidelines.

**📄 data.sql ✏

This file contains the data inserted into the database.

**📄 queries.sql ✏

This file contains the queries made to the database.

**📄 schema.sql ✏

This file contains the database's animals table schema.

📸 Screenshots of queries made to the database

Click to expand!

Thank you for taking the time to review this PR ⭐

If you require additional information or have any questions, please contact me on Slack as Arturo (Arthur) Emanuel Guerra Iturres. I'll be happy to help you out. 🎯

Thank you @usorfaitheloho Faith again for having reviewed this PR 🙏🏼 😃. I wish you a great week and see you soon! 👩🏼💻 👨🏼💻


wrong TF cause robot model to not load properly in multi robot rviz

Hey,
I was trying to get the single rviz view to work and in doing so noticed a few bugs
Wanted to ask here before jumping to fixing them, just in case they have been addressed in some other branch.
Due to namespace error the tf frames are named as "robot0odom" "robot1odom" instead of "robot0/odom" "robot1/odom" etc.
This is tightly integrated with the reset of the launch files so changing it in simulation.launch.py will not help.
The issue arises because when name space is not specified you do not want any extra "/" but when you specify just the namespace it has to be specifically addressed and an additional "/" must be added if not there.
How do I go about fixing this?
Any suggestions?

I still don’t understand the problem. What are the exact bugs that we are talking about ?

So the issue I was having was because namespaces somehow not being correctly appended to the frameid's of tf transforms.
I deleted the entire workspace and set everything up again from scratch.
I think updating the neo_fleet_rviz2_plugin somehow fixed the issue.
And now all multirobot stuff works properly without errors in rviz!

Awesome. Feel free to open a new issue, if you find something.


Add nullcheck when calculating indentations for implort clause

Fixes #9411

can you add a test as well.

@mhegazy updated

👍


feat: simplify interface of authClient and add ctx / 简化 authClient 接口并增加 context

关联的Issues (Related Issues)

close https://github.com/filecoin-project/venus/issues/5547
改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)
在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

[x] 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
[x] 具有清晰明确的commit message / All commits have a clear commit message.
[x] 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
[x] 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
[ ] 通过必要的检查项 / All checks are green

Codecov Report

Merging #126 (0a09048) into master (59930e4) will decrease coverage by 0.48%.
The diff coverage is 59.04%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   45.42%   44.94%   -0.49%
==========================================
  Files          35       35
  Lines        3813     3807       -6
==========================================
- Hits         1732     1711      -21
- Misses       1868     1882      +14
- Partials      213      214       +1

Flag
Coverage Δ

unittests
44.94% <59.04%> (-0.49%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.


POC - Implementing Retries in TaskRun

Changes
This PR is a POC of the proposed solution of TEP-0121, it:

Adds a new Retries field in TaskRun.
Implement Retries in TaskRun.
Stops PipelineRun reconciler from using len(retriesStatus) to decide the termination of a TaskRun/CustomRun

Verified behavior:

Tekton CLI logs (tkn tr logs) works.
Retry a to-be-timedout TaskRun.
Retry a to-be-failed TaskRun.

Will open another to-be-merged PR.
Retry TimedOut TaskRun
Submit the following TaskRun
apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
  generateName: tr-retries-timeout-
spec:
  retries: 2
  timeout: "20s"
  taskSpec:
    steps:
    - image: "busybox"
      args: ['-c', 'sleep 23']

The status transition of the to-be-timedout TaskRun

NAME
SUCCEEDED
REASON
STARTTIME
COMPLETIONTIME

tr-retries-timeout-76hnb

tr-retries-timeout-76hnb
Unknown
Pending
1s

tr-retries-timeout-76hnb
Unknown
Running
3s

tr-retries-timeout-76hnb
Unknown
CompletedWithRetries

0s

tr-retries-timeout-76hnb
Unknown
Pending
0s

tr-retries-timeout-76hnb
Unknown
Running
3s

tr-retries-timeout-76hnb
Unknown
CompletedWithRetries

0s

tr-retries-timeout-76hnb
Unknown
Pending
0s

tr-retries-timeout-76hnb
Unknown
Running
4s

tr-retries-timeout-76hnb
False
TaskRunTimeout
20s
0s

Retry Failed TaskRun
Submit the following TaskRun
apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
  generateName: tr-retries-
spec:
  retries: 2
  taskSpec:
    steps:
    - image: "busybox"
      args: ['-c', 'exit 1']

Status transition of the to-be-failed TaskRun

NAME
SUCCEEDED
REASON
STARTTIME
COMPLETIONTIME

tr-retries-gsl2p

tr-retries-gsl2p
Unknown
Pending
2s

tr-retries-gsl2p
Unknown
Running
5s

tr-retries-gsl2p
Unknown
CompletedWithRetries

0s

tr-retries-gsl2p
Unknown
Pending
0s

tr-retries-gsl2p
Unknown
Running
6s

tr-retries-gsl2p
Unknown
CompletedWithRetries

0s

tr-retries-gsl2p
Unknown
Pending
0s

tr-retries-gsl2p
Unknown
Running
3s

tr-retries-gsl2p
False
Failed
5s
0s

Pods
tr-retries-gsl2p-pod              0/1     Error             0          3m15s
tr-retries-gsl2p-pod-retry1       0/1     Error             0          3m9s
tr-retries-gsl2p-pod-retry2       0/1     Error             0          3m1s

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including
functionality, content, code)
[ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/kind feature

Opened a PR for the actual implementation - https://github.com/tektoncd/pipeline/pull/5807. Closing this PR as it has accomplished its mission XD.


Add pvaneck as member

Currently active in the control plane for Kubeflow as a part of IBM
Some contributions include:
https://github.com/kubeflow/manifests/pulls?q=is%3Apr+author%3Apvaneck
https://github.com/kubeflow/kfserving/pull/1113

/cc @animeshsingh


Allow disk size and type to be configured for GCP

It would be great if we could just plumb through raw parameters such that as long as you put the name of a field in the GCP API it just passed through without us having to add code. Then we wouldn't need issues like this for every machine parameter that we might want to add in the future, but we could pull the ones that we think need some extra validation out into formal parameters as we need to.

/assign spew

/cc spew

/cc @spew
/assign @rsdcastro
Self-assigning as Rob (@spew) isn't in the K8s org yet.

Let's scope this bug to disk params for now, and track plumbing the raw parameters (which is a more general solution) as a separate issue.

PR request open in the new repo: https://github.com/kubernetes-sigs/cluster-api/pull/77

This issue was moved to kubernetes-sigs/cluster-api#84


cli: Scale processes to 0 before deleting app

By scaling down the processes before proceeding with deleting resources etc we can ensure they are no longer being used by the application.
This won't fix the case of trying to remove an in-use resource without deleting the app while the application still has processes running. This will need to be addressed on a per-provider/resource basis.
Refs #2376

LGTM


How to make dropdown wont auto open we first load our site?

when we see in the official site
https://nextra.site/docs
the dropdown isn't automatically open. but we tried to create from the template
https://nextra-docs-template.vercel.app/
it is automatically open. How to prevent that to happen?

when we see in the official site
https://nextra.site/docs
the dropdown isn't automatically open. but we tried to create from the template
https://nextra-docs-template.vercel.app/
it is automatically open. How to prevent that to happen?

@dzikrisyairozi  Change the value sidebar.defaultMenuCollapseLevel in your theme.config.tsx file to 2

If you are using theme.config.jsx, just do the same

it is weird because when i saw in the nextra docs, it says 1
  sidebar: {
    titleComponent({ title, type }) {
      if (type === 'separator') {
        return {title}
      }
      return <>{title}</>
    },
    defaultMenuCollapseLevel: 1, //here
    toggleButton: true,
  },

but when I tried copy that into my project it wont work. any other idea?

here is the link to the theme.config.tsx to help you out

@dzikrisyairozi Please provide a test link. I could help you out more if I knew what exactly I am working at.
Because, if u have done the above and it doesn't work, it's something else


get in touch

how could i contact your privately

For example telegram @toppe https://t.me/Toppe or Discord Toppe#4670 (just pm, no need to add)
If it's related to this project you can also email me support[at]getloyalty.app

@toppe is me?

Sorry didn't realize that would tag your github profile, I meant to say [at]Toppe is my telegram

For example telegram @toppe https://t.me/Toppe or Discord Toppe#4670 (just pm, no need to add)
If it's related to this project you can also email me support[at]getloyalty.app

@toppe is me?

Sorry didn't realize that would tag your github profile, I meant to say [at]Toppe is my telegram


Mocking final methods should fail early and with a descriptive error.

I've been informed of this second hand, it seems to be true. I'll try and come up with a test.

It's a limitation we found difficult to address because we didn't do bytecode rewriting. The difficulty is that jmock would have to override final methods in order to detect when they are called during an expectation -- but cannot because they are final.
Our opinion at the time was that it was only a problem in the "legacy" package, which provided support for getting legacy code under test. In that situation, nothing's perfect! If you're working on your own legacy code, it's safe to remove final modifiers or introduce interfaces. If mocking third party code, it could be worth introducing an interface between your code and the third party code.

Yep, good point. They can use an interface, and it's our final method, so we've got options.


Add VersioningOverride to StartWorkflowExecutionRequest

For canary tests in versioning-3 we need to specify target versioning information in the options when creating a workflow, so that we override the current default. See https://github.com/temporalio/api/pull/477 for details.

Merged in versioning-3 branch


Added logic to test bounding box statistics

I'm trying to get this to work through Jace, so I updated our unit tests as a sanity check...

Coverage decreased (-0.01%) to 31.71% when pulling d281caadf9b2b682f478b4d70a71eebcfe44149e on bbox-test into 5de3a16afd9bdfbccad1546bf89c5aedc61a17a3 on master.


🌱 cache: add replication tests for WorkspaceType resource

Summary

switch to dynamic clients
provide generic functions for creating replication scenarios
cover replication of WorkspaceType resource

Related issue(s)
replaces https://github.com/kcp-dev/kcp/pull/2449

/lgtm
I think it is a good improvement compared to what we have.
I am fine with factoring the parameters to replicateResource and separating the "create" and "update" definition from the function call in a later iteration.

/approve


Error:  Duplicate export 'default' (Note that you need plugins to import files that are not JavaScript)

My nuxt3 templates fails to build with a new nuxt version:
PR run: https://github.com/jojomatik/nuxt-3-base/runs/5617517319?check_suite_focus=true
[log] Nuxt CLI v3.0.0-2746048[9](https://github.com/jojomatik/nuxt-3-base/runs/5617517319?check_suite_focus=true#step:7:9).53fbca7
[warn] Error when using sourcemap for reporting an error: Can't resolve original location of error.
Error:  Duplicate export 'default' (Note that you need plugins to import files that are not JavaScript)
file: virtual:/home/runner/work/nuxt-3-base/nuxt-3-base/.nuxt/intlify.vuei18n.options.mjs:3:7
1:
2: export default () => Promise.resolve({"locale":"en","fallbackLocale":"en"})
3: export default () => Promise.resolve({"locale":"en","fallbackLocale":"en"})
          ^
Error:  Duplicate export 'default' (Note that you need plugins to import files that are not JavaScript)
  at error (node_modules/rollup/dist/shared/rollup.js:198:30)
  at Module.error (node_modules/rollup/dist/shared/rollup.js:[12](https://github.com/jojomatik/nuxt-3-base/runs/5617517319?check_suite_focus=true#step:7:12)477:[16](https://github.com/jojomatik/nuxt-3-base/runs/5617517319?check_suite_focus=true#step:7:16))
  at Module.tryParse (node_modules/rollup/dist/shared/rollup.js:12853:25)
  at Module.setSource (node_modules/rollup/dist/shared/rollup.js:12756:24)
  at ModuleLoader.addModuleSource (node_modules/rollup/dist/shared/rollup.js:222[20](https://github.com/jojomatik/nuxt-3-base/runs/5617517319?check_suite_focus=true#step:7:20):20)
Error: Process completed with exit code 1.

Works fine with previous version of nuxt3: https://github.com/jojomatik/nuxt-3-base/runs/5617504148?check_suite_focus=true
Diff: https://github.com/jojomatik/nuxt-3-base/pull/17/files
I've also tried to switch to @nuxtjs/i18n-edge as you recommended that in #44, but I could not get it working. I think it's propably a small change to switch the library, but I didn't find enought documentation unfortunately.

I had the same problem and managed to fix it by putting dependency override (I use pnpm) :
package.json
  "pnpm": {
    "overrides": {
      "@nuxt/kit": "npm:@nuxt/kit-edge@latest",
      "@nuxt/kit-edge": "latest"
    }
  }

If you don't use pnpm maybe a lock file resfresh is enough

If you don't use pnpm maybe a lock file resfresh is enough

Thanks @leo91000, recreating the lockfile after deleting /node_modules fixes the issue for me.
Do you have any insights why this happened? Is this an issue of how this project handles its dependencies or is npm just not working that well with these "weird" nuxt3 beta version numbers and all other related beta/ alpha/ rc versions?

I have no idea why this happens . Probably the fact that nuxt 3 is not released yet so it makes breaking changes to it's packages (in this case @nuxt/kit). Then you have two incompatible version because updating nuxt3 is not enough.

I believe this issue can be closed. Recreating the lockfile worked and I believe the bug does not occur with the newer versions of nuxt.


Added English Documentation [FIxes #13]

We need to check the conflicts and proceed with the merge.

@GeorgeApos But you have write access and you need to do that or open a new PR

@SH

@shivam-sharma7 We need at least 2 people to check these conflicts and accept PR.

@GeorgeApos How can I see these conflicts? for now I can't see any

Alright, I am closing this, please send a PR again. @shivam-sharma7


database/sql: update documentation to explain context cancellation in more detail

The documentation states in various places:
Drivers that do not support context cancelation will not return until after the query is completed.
The provided context is used until the transaction is committed or rolled back. If the context is canceled, the sql package will roll back the transaction. Tx.Commit will return an error if the context provided to BeginTx is canceled.
etc etc

My suggestion is the documentation makes clear that some drivers will cancel the execution of the query whilst others will only cancel waiting for the query results but the execution will still complete behind the scenes.
This is a very important distinction.

See: https://github.com/go-sql-driver/mysql/issues/863
@methane is one of the key contributors to the popular mysql driver.

I'll look into more detail in the documentation.

My suggestion is the documentation makes clear that some drivers will cancel the execution of the query whilst others will only cancel waiting for the query results but the execution will still complete behind the scenes.
This is a very important distinction.

Why is it very important?
Even though driver support cancelling query on the server, it only saves some CPU usage.
Canceling remote query is hard and nondeterministic problem.  You shouldn't rely on behaviour of canceling.
In case of go-sql-driver/mysql#863, you should use transaction.

Some drivers such as MySQL driver do support cancellation.
I was trying to make clear that even if the driver does support cancellation, the documentation should warn that successfully cancelling from Go's point of view does not imply that the query is cancelled from databases point of view.
In the case of MySQL, cancelling does not mean that MySQL has cancelled the execution of the query.


Improve design in alarm options dialog

On my tablet it looks like this (only "away" button text is modified for testing purposes):

So I modified the layout:

The dialog should have the same width on both sides.  I did this by making the TextView have a fixed width but this is an issue with certain text.  We can have an option to make the text less for other languages, elipse the text (...) to truncate it or increase the width of the TextView to accommodate all languages (have to test and least dynamic).

You are right, I didn't notice that, sorry. I think making the text less is a good idea. For Spanish, it would be a good idea to replace:
    <string name="text_arm_home">MODO "EN CASA"</string>
    <string name="text_arm_away">MODO "FUERA DE CASA"</string>

with
    <string name="text_arm_home">EN CASA</string>
    <string name="text_arm_away">FUERA DE CASA</string>

What do you think about it?

That's a temporary fix, depends entirely on the language translation.  I think I will add a custom TextView that adjust the font size automatically depending on the text to fit or use other method to elipse the extra text or wrap it.  If I wrap it I will always have to allow two lines for the text just to be safe.

That would be great! About the Spanish translation, I can confirm it's correct (I'm from Spain).


Config Options Documentation

Apologies as I was a bit too late to leave a comment in https://github.com/CreateAPI/CreateAPI/pull/52, but I would like to propose some improvements to the ConfigOptions.md generation since I do reference it a bit.
1 - Alphabetize options within their scope (general, comments, entities, etc.), but leave sections at the end, sorted by section name.
2 - Add examples under a dropdown
3 - Add dividers to be more easy on the eyes
I'm referencing SwiftFormat's Rules.md for these changes as I personally think they present their list of options well.
This issue could have help-wanted for the examples on the PR if this is approved as a change.

Thanks for raising this! I rushed to merge it all up to get the 0.0.5 release out but I agree with your feedback and using SwiftFormat for inspiration is a great idea 👍

Alphabetize options within their scope (general, comments, entities, etc.), but leave sections at the end, sorted by section name.

Makes sense. I did have a concern that maybe we'd want to create related options together, but we can instead just link to them using their anchor so that's fine 👍
This can be done by manually reordering the contents of CreateOptions.swift

Add examples under a dropdown

Oooh great idea!

Add dividers to be more easy on the eyes

Yes, I love this!

Since I started it, I'll tweak the template to add the dividers, reorder the properties and add a couple of examples for reference but we can leave a help wanted issue open for adding to it 👍

On the other hand actually, sorting alphabetically looks a little worse than I thought:

access
addedAcronyms
fileHeaderComment
ignoredAcronyms
indentation
isAddingDeprecations
isGeneratingEnums
isGeneratingSwiftyBooleanPropertyNames
isInliningTypealiases
isNaiveDateEnabled
isPluralizationEnabled
isReplacingCommonAcronyms
isSwiftLintDisabled
isUsingIntegersWithPredefinedCapacity
spaceWidth

I'm not sure if I'm a fan on having things like addedAcronyms and ignoredAcronyms separated, same with indentation and spaceWidth.
Similarly, all of the boolean isXXX properties get grouped together and I'm not sure if that's useful or not.
WDYT?

Ah, tt makes sense that related properties being separated is an issue and I didn't think about that. I actually brought up alphabetized sorting because of isXXX since there are quite a few. I'd overall be fine without the sorting.

I'll close this ticket since the main changes were made. If there are particular options that you think should have better Examples added to them, please can you open a Pull Request, or alternatively a ticket if it needs some prior discussion 🙏
Thanks again!


Feature/integrate DRM Acceptance dialog with Item

Checklist

[x] the [contributor license agreement][] is signed
[x] commit message follows [commit guidelines][]
[x] tests are included
[x] screenshots are included showing significant UI changes
[ ] documentation is changed or added

Description of change
This PR adds the support of showing DRM Acceptance dialog when users attempt to view an Item. On standard list mode, the dialog pops up when an Item link is clicked,  and on gallery mode the dialog pops up when an Info icon is clicked.
Once the terms are accepted, Item Summary page will be opened by different approaches, depending on whether in Selection Session or not.
https://user-images.githubusercontent.com/47203811/126739698-8e628e1c-e74c-48ff-b687-0971b440d790.mp4

The last three commits made significant changes, particularly on

How to do DRM check - now the check is centralised in DrmHelper which is consumed by SearchResult and GallerySearchItemTiles .

How to build URL and handler for Item Summary page. There were mixed approaches to do this, but now they are centralised in SearchPageHelper.


Schema and fields

Schemas are not used as model.fields as it is written in the doc. In order for it to work, I must write the fields by hand

Closed by 82543f2


Current snapshot is backing itself (backing store is self-referential)

Bug Report
Version of OpenNebula

[ ] 5.2.2
[ ] 5.4.0
[ ] 5.4.1
[ ] 5.4.2
[ ] 5.4.3
[ ] 5.4.4
[ ] 5.4.5
[ ] 5.4.6
[ ] 5.4.7
[ ] 5.4.8
[ ] 5.4.9
[ ] 5.4.10
[ ] 5.4.11
[x] 5.4.13
[ ] Development build

Component

[ ] Authorization (LDAP, x509 certs...)
[ ] Command Line Interface (CLI)
[ ] Contextualization
[ ] Documentation
[ ] Federation and HA
[ ] Host, Clusters and Monitorization
[ ] KVM
[ ] Networking
[ ] Orchestration (OpenNebula Flow)
[ ] Packages
[ ] Scheduler
[x] Storage & Images
[x] Sunstone
[ ] Upgrades
[ ] User, Groups, VDCs and ACL
[ ] vCenter

Description
When using disk snapshots on qcow2 files, it's quiet easy to end up with an unbootable VM because it's current disk has a backing file pointing to the same file.
Expected Behavior
snapshots should work as expected.
Actual Behavior
We have at least 2 situations:

with missing disk.# on the datastore. I don't know yet how to reproduction. In sunstone this snapshots can't be deleted and has a missing file size
VM can't boot, backing file is self-referential

How to reproduce
I will open a new issue for situation 1 with missing snapshot on datastore, as soon as I understand how to reproduice.
Here is for situration 2 with backing file that is self-referential:

Create a VM on a QCOW2 datastore
Stop the VM
In the storage tab, do 1 snapshot (let's call it origin)
Run the VM, do some stuff
Stop the VM
In the storage tab, do 1 new snapshot (let's call it snap2)
Run the VM, do some stuff
Stop the VM
In the storage tab, do 1 new snapshot (let's call it snap3)
Stop the VM
in the storage tab, revert to first snapshot (origin)
Run the VM, do some stuff
Stop the VM
in the storage tab, delete snap3
Run the VM, do some stuff
Stop the VM
in the storage tab, create a new snapshot (snap4)
Current disk.0.snap is self referential, VM can't boot.

juin 15 15:17:53 h003 libvirtd[2231]: 2018-06-15 13:17:53.922+0000: 2248: error : virStorageFileGetMetadataRecurse:3269 : internal error: backing store for /var/lib/one//datastores/104/5802/disk.0.snap/3 (/var/lib/one/datastores/104/5802/disk.0.snap/3) is self-referential
-(ven. juin 15 15:16:50)--(h003:/var/lib/one/datastores/104/5802/disk.0.snap)-
[root] # ll ..
total 392K
-rw-rw-r-- 1 oneadmin oneadmin 1,1K 14 juin  14:17 deployment.0
-rw-rw-r-- 1 oneadmin oneadmin 1,1K 15 juin  14:56 deployment.1
-rw-rw-r-- 1 oneadmin oneadmin 1,1K 15 juin  15:00 deployment.2
-rw-rw-r-- 1 oneadmin oneadmin 1,1K 15 juin  15:02 deployment.3
-rw-rw-r-- 1 oneadmin oneadmin 1,1K 15 juin  15:04 deployment.4
lrwxrwxrwx 1 oneadmin oneadmin   13 15 juin  15:07 disk.0 -> disk.0.snap/3
drwxrwxr-x 2 oneadmin oneadmin 4,0K 15 juin  15:05 disk.0.snap
-rw-r--r-- 1 oneadmin oneadmin 364K 15 juin  15:04 disk.1
-(ven. juin 15 15:17:30)--(h003:/var/lib/one/datastores/104/5802/disk.0.snap)-
[root] # qemu-img info 3
image: 3
file format: qcow2
virtual size: 8.0G<PHONE_NUMBER> bytes)
disk size: 200K
cluster_size: 65536
backing file: disk.0.snap/3
backing file format: qcow2
Format specific information:
    compat: 1.1
    lazy refcounts: false
    refcount bits: 16
    corrupt: false

It seems that snapshots management goes south as soon as we delete one of them. File numbers on datastore seem to not match the ID in sunstone. Not sure it's relevant with the problem.
Best regards
Edouard

After an upgrade VM metadata is updated but any previous VM presenting this issue will have a NEXT_SNAPSHOT that will overwrite an existing one:

Safety check in drivers to not overwrite in this situation
Add a manual upgrade procedure for this VMs.

As a reference existing VMs can be recovered by updating the metadata with onedb update-body and increasing the NEXT_SNAPSHOT value.


Improving the UX of editing routes

As noted in https://github.com/acteng/atip/pull/202#issuecomment-1572050592 I found the UX of editing routes especially when appending to routes is not the default slightly clunky and easy to accidentally delete red waypoints when trying to grab and move them.
I'd propose exploring the feasibility of:

Change the interaction that triggers a waypoint deletion i.e. right mouse click?
Make a click on a waypoint make it sticky to the cursor, so I don't have to drag I can just click and move it about (realise this would depend on changing waypoint deletion event)

It would also be worth getting some user feedback on these features to see how they'd like this to behave too.

Change the interaction that triggers a waypoint deletion i.e. right mouse click?

This sounds like the easier option in the short-term to me. Per https://github.com/maplibre/maplibre-gl-js/pull/2593#issuecomment-1563450492, right click may not be good from an accessibility perspective. Also as a sanity check -- can it be done on mac?

Make a click on a waypoint make it sticky to the cursor

This feels like it'd be intuitive to me, but not sure how we can predict if this'll be the right option without implementing it and doing a UX study.
And unfortunately, I'd rate the difficulty of this code change as moderate. Same reason as #159. I've been toying around with a way to visualize the states / interactions of all of our drawing tools, so we can express something like "state = added two points, action = click existing waypoint, effect = change to dragging waypoint state" both in a finite state machine diagram that's understandable to a UX designer, and to make the code more maintainable and testable (fuzzing states X interactions!)

Some notes in https://github.com/dabreegster/route_snapper/issues/13 about summarizing current behavior as a finite state machine. It's a difficult exercise, maybe not helpful.
https://github.com/dabreegster/route_snapper/pull/33 starts some unit tests. I want to get these covering all current behavior and use test-driven development for some of the next improvements we make, especially #159 (because it feels like an explosion of possible states to me, even fuzz testing could be an idea to consider)

#549 changes the UX and should address these problems


ensure recovery from any panics

A panic may happen during template generation from inner functions.  This change ensures that a panic never kills the process

Hi @anhowe, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Anthony Howe). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


BUG: auth doesn't work with dotnet list package --include-transitive --outdated

I have a package in a private registry which itself depends on another package in the same registry. I can successfully run dotnet restore --interactive and subsequently dotnet restore without interactive after installng this plugin.
The following however fails.
$ dotnet list package --outdated --include-transitive

The following sources were used:
   https://api.nuget.org/v3/index.json
   https://pkgs.dev.azure.com/redacted/_packaging/my-private-feed/nuget/v3/index.json

The given project `Redacted` has no updates given the current sources.
warn : The plugin credential provider could not acquire credentials. Authentication may require manual action. Consider re-running the command with --interactive for `dotnet`, /p:NuGetInteractive="true" for MSBuild or removing the -NonInteractive switch for `NuGet`
error: Response status code does not indicate success: 401 (Unauthorized).

Running the same command with --interactive keeps endlessly prompting me to do a device code login, which tells me that the plugin is activated but doesn't work right.

Yea, you couldn't have just copied the issue for me? sheesh never mind then

@StevenLiekens were you able to resolve this? I'm experiencing the same issue.

No, I think I have to reopen the issue somewhere else but I really just can't be fucked to do it. Sorry.

@StevenLiekens LMAO okay. So frustrating!

Yeah I'm not sure why they don't just disable issues for this repository. Perhaps Microsoft likes to keep us around as their menagerie of great apes looking for a large enough stick to scratch our own back.

@levimatheri I ran into even more issues that finally tipped the scale over. I figured my time is better spent ranting on the internet about shitty code than trying to make it work.
Behold, https://developercommunity.visualstudio.com/t/Azure-Artifacts-Credential-Provider-dele/10110841.


@thirdweb-dev/react-native sub-dependency expo-application is out of date

While attempting to upgrade our project to 0.74.5 we get a Gradle build error due to an older version of expo-application (5.8.3) which is installed as a dependency of @thirdweb-dev/react-native.
Is there a plan to update expo-application along with other outdated expo dependencies to support react native 0.74 and 0.75?
yarn.lock segment
"@thirdweb-dev/react-native@npm:latest":
  version: 0.8.0
  resolution: "@thirdweb-dev/react-native@npm:0.8.0"
  dependencies:
    "@aws-sdk/client-lambda": 3.549.0
    "@aws-sdk/credential-providers": 3.549.0
    "@coinbase/wallet-mobile-sdk": 1.0.13
    "@paperxyz/embedded-wallet-service-sdk": ^1.2.5
    "@shopify/restyle": ^2.4.2
    "@tanstack/react-query": ^4.36.1
    "@thirdweb-dev/chains": 0.1.106
    "@thirdweb-dev/react-core": 4.6.16
    "@thirdweb-dev/sdk": 4.0.77
    "@thirdweb-dev/storage": 2.0.14
    "@thirdweb-dev/wallets": 2.5.17
    abitype: 1.0.0
    amazon-cognito-identity-js: ^6.3.12
    aws-amplify: ^5.3.18
    expo-application: 5.8.3
    expo-clipboard: ^4.8.0
    expo-document-picker: ^11.10.1
    expo-file-system: ^16.0.8
    expo-secure-store: ^12.8.1
    react-native-aes-gcm-crypto: ^0.2.2
    react-native-camera: ^4.2.1
    react-native-inappbrowser-reborn: ^3.7.0
    react-native-modal: ^13.0.1
    react-native-quick-base64: ^2.1.0
    react-native-quick-crypto: ^0.6.1
    secrets.js-34r7h: ^2.0.2
    tiny-invariant: ^1.3.3
  peerDependencies:
    ethers: ">=5.5.1 <6"
    expo: ">=47"
    react: ">=18.0.0"
    react-native: ">=0.71.0"
    react-native-mmkv: ">=2.11.0"
    react-native-qrcode-svg: ">=6.3.0"
    react-native-svg: ">=15.1.0"
  dependenciesMeta:
    amazon-cognito-identity-js:
      optional: true
    react-native-aes-gcm-crypto:
      optional: true
    react-native-camera:
      optional: true
    react-native-inappbrowser-reborn:
      optional: true
    react-native-quick-base64:
      optional: true
    react-native-quick-crypto:
      optional: true
  checksum: 9f7002eeae4acf16f81b07e9b32102d861d88805287d1a931c292e8b1022486848b739134c74d9575508d935620e81b9330ff8465055032caa6b78bbc947480b
  languageName: node
  linkType: hard

hey @brien-crean, you have 2 options:

use yarn resolutions to override the dependency version
upgrade to thirdweb@5 react native docs react migration guide

@jnsdls thanks for the quick reply! I tried option 1) but it seemed to create more dependency problems as we also use a few other thirdweb dependencies.
We use thirdweb for MetaMask login but we also currently created an AbstractClientWallet adapter to connect to magic-link hence these extra dependencies below.
Is it still possible to connect to magic link with a custom wallet? We have existing users that have magic link wallets back when thirdweb natively supported magiclink.
"@thirdweb-dev/chains": "0.1.72",
"@thirdweb-dev/react-core": "4.4.8",
"@thirdweb-dev/react-native": "0.7.5",
"@thirdweb-dev/react-native-compat": "0.7.5",
"@thirdweb-dev/wallets": "2.4.10",

@jnsdls can you confirm if it is still possible to connect to magic link with a custom wallet with v5? We have existing users that have magic link wallets back when thirdweb natively supported magiclink. Thanks!

@jnsdls can I use thirdweb@5 along with the account interface to login with a custom wallet such as magic link as per this comment?
Any help is much appreciated as this is blocking us from upgrading react native.

Hey @brien-crean, sorry for the delay on this issue. We don't natively support MagicLink in v5, but we'd like to soon. I'll keep you updated as this feature gets built.


add support for weighted manifests

What this PR does / why we need it:
Allows overriding the default manifest sort order by annotation.
Closes https://github.com/helm/helm/issues/8439

The annotation: helm.sh/order-weight, if defined in a given manifest will influence the sorted order.
Lower weighted manifests will be applied prior to higher weighted manifests.
A value of 0 is assumed if the annotation is missing or not parseable.
Manifests of the same order weight will leverage the existing sorting logic.

Special notes for your reviewer:
Prior work:

https://github.com/helm/helm/pull/9534
https://github.com/helm/helm/pull/8448

If applicable:

[ ] this PR contains documentation
[x] this PR contains unit tests
[x] this PR has been tested for backwards compatibility

this will help us a lot too, especially for CRs

any news about that?

+1 this is awesome! it will save us a lot of problems.

+1 this is very useful

+1 this will help a lot, any ideas on when this will be merged?

I suspect this needs to go through the HIP process. There are a number of alternatives to weigh this against.
As-is, this is another proof of concept.

+1 on this. Is there any news when this will be merged and available?

+1 waiting for this from 2 years :/

+1 We are also waiting for this change. Thanks for working on it.

Did some digging on this:

HIP for custom resource ordering proposes adding the helm.sh/install-before annotation to help manage inter-dependent custom resources. This is only tangentially related, and doesn't solve ordering of resources of the same Kind.

This comment seems to indicate that maintainers may have concerns around how weighted manifests effect sub-charts. The commenter suggests another annotation helm.io/chart-weight is added to address this concern.

@crandles suggests this MR may require a HIP.

There's is some confusion around if the existing helm.sh/hook-weight should respect resource-type install order or if the documentation should be updated.

I feel that better support for ordering will resolve a lot of friction and open up new use-cases. I'd love to see this incorporated into the tool!
@bacongobbler @mattfarina do you have any guidance:

what's your intuition?
do you recall the exact concerns around sub-charts?
should a HIP be created? If not, what are the next steps?


Screen reader is not announcing new tab on APIs overview links

Expected Behavior
Screen reader notifies the user the needed information when page opens in new tab for 'View Source' link, 'Edit' button and 'Slack Channel' link.
Actual Behavior

Navigate to APIs from the side menu bar.
Navigate to the main section of the page (table component).
Select any link from the name column. A new page opens up.
Launch a screen reader and navigate to 'View Source' link, 'Edit' button and 'Slack Channel' link.
Verify whether the screen reader on focus announces that the clicked UI control opens in new tab or not.

Context
Screen reader users aren't aware of clickable links and some buttons that opens in a new tab as the ones mentioned above.
A11y Conformance Level: A
WCAG Success Criteria: 3.2.2
Environment
Browser Information:
Google Chrome v100.0.4896.127
Firefox 99.0.1
Safari 15.4
Screen readers used:
NVDA v2021.3

This is happening for any external link in Backstage.
WCAG reference https://www.w3.org/TR/2016/NOTE-WCAG20-TECHS-20161007/G201


Noted Difference Between Original

In the original FNF, a player could hold a note for however long and it would still count for long notes. It is not like that for this one though. Oh and here is a video I took. It should show you what I mean.
https://user-images.githubusercontent.com/80850329/111704725-01747700-8816-11eb-9cde-3adcdfc3b842.mp4
https://user-images.githubusercontent.com/80850329/111704975-57491f00-8816-11eb-8a3d-564f3b4abbea.mp4

I'll see what I can do to add this feature. 🤔


Unable to resolve _http_common (on meteor)

Subject of the issue
When installing x-ray on meteor via NPM, I´m getting this error message:
Unable to resolve some modules:
  "_http_common" in /Users/tom/Dev/lms/node_modules/http-context/node_modules/http-outgoing/index.js (os.osx.x86_64)

Could that have to do with the fact that meteor currently uses node 0.10?
Your environment
meteor --version
Meteor <IP_ADDRESS>
meteor node --version
v0.10.43
meteor npm --version
2.14.22
Steps to reproduce

Add x-ray to meteor  (in package.json under dependencies)
meteor npm install --save
try to use it with "xray = require('x-ray')()"
Shows the error in the server console

Expected behaviour
It should not throw errors ;)
Actual behaviour
The "Unable to resolve" message shows before even calling x-ray... when trying to use x-ray (example code) I´m getting:
Example code:
xxx = xray('github.com/stars/matthewmueller').select([{
		$root: '.repo-list-item',
		title: '.repo-list-name',
		link: '.repo-list-name a[href]',
		description: '.repo-list-description',
		meta: {
			$root: '.repo-list-meta',
			starredOn: 'time'
		}
	}]).limit(10).stream()

Error:
Exception in callback of async function: TypeError: Object function node(source2, fn) {
    if (arguments.length === 1) {
      fn = source2
    } else {
      source = source2
    }

    debug('params: %j', {
      source: source,
      scope: scope,
      selector: selector
    })

    if (isUrl(source)) {
      debug('starting at: %s', source)
      request(source, function (err, html) {
        if (err) return next(err)
        var $ = load(html, source)
        walkHTML($, next)
      })
    } else if (scope && ~scope.indexOf('@')) {
      debug('resolving to a url: %s', scope)
      var url = resolve(source, false, scope, filters)

      // ensure that a@href is a URL
      if (!isUrl(url)) {
        debug('%s is not a url. Skipping!', url)
        return walkHTML(load(''), next)
      }

      debug('resolved "%s" to a %s', scope, url)
      request(url, function (err, html) {
        if (err) return next(err)
        var $ = load(html, url)
        walkHTML($, next)
      })
    } else if (source) {
      var $ = load(source)
      walkHTML($, next)
    } else {
      debug('%s is not a url or html. Skipping!', source)
      return walkHTML(load(''), next)
    }

    function next (err, obj, $) {
      if (err) return fn(err)
      var paginate = state.paginate
      var limit = --state.limit

      // create the stream
      if (!stream) {
        if (paginate) stream = streamHelper.array(state.stream)
        else stream = streamHelper.object(state.stream)
      }

      if (paginate) {
        if (isArray(obj)) {
          pages = pages.concat(obj)
        } else {
          pages.push(obj)
        }

        if (limit <= 0) {
          debug('reached limit, ending')
          stream(obj, true)
          return fn(null, pages)
        }

        var url = resolve($, false, paginate, filters)
        debug('paginate(%j) => %j', paginate, url)

        if (!isUrl(url)) {
          debug('%j is not a url, finishing up', url)
          stream(obj, true)
          return fn(null, pages)
        }

        stream(obj)

        // debug
        debug('paginating %j', url)
        isFinite(limit) && debug('%s page(s) left to crawl', limit)

        request(url, function (err, html) {
          if (err) return next(err)
          var $ = load(html, url)
          walkHTML($, next)
        })
      } else {
        stream(obj, true)
        fn(null, obj)
      }
    }

    return node
  } has no method 'select'
  at server/gmail.coffee:66:51
  at runWithEnvironment (packages/meteor/dynamics_nodejs.js:110:1)

This happens when building with webpack too.
ERROR in ./~/x-ray/~/x-ray-crawler/~/http-context/~/http-outgoing/index.js
Module not found: Error: Cannot resolve module '_http_common' in ....../node_modules/x-ray/node_modules/x-ray-crawler/node_modules/http-context/node_modules/http-outgoing
@ ./~/x-ray/~/x-ray-crawler/~/http-context/~/http-outgoing/index.js 27:13-36

I'm also getting this issue when trying to require xRay via webpack... I get the same sort of notice:
ERROR in ./~/http-outgoing/index.js Module not found: Error: Cannot resolve module '_http_common'
Any advice on how to resolve this?

@sheixt
looks like this isn't meant for the browser. I stopped trying to build this with webpack and moved it to the server. Hope this helps.

@kasun thanks for the update. When you say you "moved it to the server" do you mean you stopped using x-ray entirely or just dropped Webpack as the module bundler?

no solution for this?

I didn't find a way around it. Ended up using a PHP script

That's sad :/
I'm considering this other libs.

https://github.com/rchipka/node-osmosis
https://www.npmjs.com/package/arachnod


Search for c++ packages does not work correctly

One of the "Featured topics" on https://fortran-lang.org/packages/ is c++.  However, the search page https://fortran-lang.org/packages/search/?query=c++ seems to list many packages that don't have c++ in their list of tags or descriptions.  Is it possible that the search inputs are not properly escaped?

The Featured topics has changed it to cpp as that '+' in c++ was being termed as a space replacer and to join a line of words
by the script thus only rendering the results for "c  " that is c with 2 spaces. that has been fixed by replacing c++ by cpp.
request to close this issue as it has been resolved.
Thanks and Regards,
Henil Panchal

@awvwgk  @jme52  This issue has been resolved thus request to close this issue #217.
Thanks and Regards,
Henil Panchal

I think this issue is still present, since we do not properly escape a search like c++ at the moment.

sir I can make the search code so should i contribute it.
Thanks and Regards,
Henil Panchal

The package search is implemented here: https://github.com/fortran-lang/fortran-lang.org/blob/master/assets/js/package_search.js


Vite plugin is not extracting the styles in CSS file when used in module federation setup

Describe the bug
I have a module federation setup with Vite using vite-plugin-federation. Also I am using vite-tsconfig-paths. When I try to build the apps, it doesn't compile/extract the styles in separate CSS file, instead it keeps them in JS files and when I run/preview the built app, I get this error: Uncaught Error: Styles were unable to be assigned to a file.
I noticed when I don't use vite-tsconfig-paths for the imports, the build output is correct.
I also tried to set vanillaExtractPlugin({ unstable_mode: 'transform' }) and that one also gives the correct build output.
Reproduction
https://github.com/smitev/vanilla-extract-vite-module-federation
System Info
System:
    OS: macOS 14.7.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 301.97 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.11.0 - /opt/homebrew/opt/node@22/bin/node
    Yarn: 4.5.1 - /opt/homebrew/opt/node@22/bin/yarn
    npm: 10.9.0 - /opt/homebrew/opt/node@22/bin/npm
  Browsers:
    Chrome: 131.0.6778.86
    Edge: 131.0.2903.51
    Safari: 18.1

Used Package Manager
yarn
Logs
Uncaught Error: Styles were unable to be assigned to a file. This is generally caused by one of the following:

- You may have created styles outside of a '.css.ts' context
- You may have incorrect configuration. See https://vanilla-extract.style/documentation/getting-started
    at getFileScope (__federation_expose_RemoteApp-GIBzU0Fx.js:3194:11)
    at generateIdentifier (__federation_expose_RemoteApp-GIBzU0Fx.js:4980:7)
    at style (__federation_expose_RemoteApp-GIBzU0Fx.js:5047:19)
    at __federation_expose_RemoteApp-GIBzU0Fx.js:5057:19

Validations

[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

I think both vite-tsconfig-paths and unstable_mode: 'transform' are red herrings. I've observed non-deterministic build output, regardless of whether or not the tsconfigPaths plugins is used.
Below is two builds performed one after another. One emits a CSS file, but the other doesn't. This can occur with or without the tsconfigPaths plugin. The CSS file is only occasionally generated. Usually it isn't generated.

Additionally, unstable_mode: 'transform' doesn't emit CSS files, so it "works", but that's because it's just loading the CSS at runtime via our runtime adapter, which is injected because VE is ending up bundled in the built module. This clearly isn't desirable.
I'm not sure what's causing this non-deterministic build, but for now I'm going to label this as an upstream issue and suggest you make an issue in vite-plugin-federation. If the maintainers of vite-plugin-federation can identify an issue within Vanilla Extract then we can proceed from there.


change data_id to something more meaningful

The encoder and decoder sections in the config would benefit if data_id were renamed to e.g. input_series.
What's your opinion?

Why not.

I'll do it all at one with other changes in names in config (if any).


Ripple Effect in other view like LinearLayout & RelativeLayout

How can have ripple effect on click in LinearLayout & RelativeLayout??
Or any other View ??
Can you pride code or help for the same ??

I would like to know aswell ^^

I add a transparent  ripple button


Why I have this error when create certificate

Error: Command failed: /usr/bin/certbot certonly --non-interactive --config "/etc/letsencrypt.ini" --cert-name "npm-20" --agree-tos --email<EMAIL_ADDRESS>--preferred-challenges "dns,http" --domains "haproxy.mydomain.com"
Saving debug log to /var/log/letsencrypt/letsencrypt.log
Plugins selected: Authenticator webroot, Installer None
Obtaining a new certificate
Performing the following challenges:
http-01 challenge for haproxy.mydomain.com
Using the webroot path /data/letsencrypt-acme-challenge for all unmatched domains.
Waiting for verification...
Challenge failed for domain haproxy.mydomain.com
http-01 challenge for haproxy.mydomain.com
Cleaning up challenges
Some challenges have failed.

    at ChildProcess.exithandler (child_process.js:308:12)
    at ChildProcess.emit (events.js:314:20)
    at maybeClose (internal/child_process.js:1051:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:287:5)

I have the same issue. The container becomes nonfunctional then. No one is answering this question, it has been posted so many times in different forums/threads.

Traceback (most recent call last):
File "/usr/bin/certbot", line 11, in
load_entry_point('certbot==1.4.0', 'console_scripts', 'certbot')()
File "/usr/lib/python3.8/site-packages/pkg_resources/init.py", line 490, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/usr/lib/python3.8/site-packages/pkg_resources/init.py", line 2862, in load_entry_point
return ep.load()
File "/usr/lib/python3.8/site-packages/pkg_resources/init.py", line 2462, in load
return self.resolve()
File "/usr/lib/python3.8/site-packages/pkg_resources/init.py", line 2468, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/usr/lib/python3.8/site-packages/certbot/main.py", line 2, in
from certbot._internal import main as internal_main
File "/usr/lib/python3.8/site-packages/certbot/_internal/main.py", line 16, in
from certbot import crypto_util
File "/usr/lib/python3.8/site-packages/certbot/crypto_util.py", line 30, in
from certbot import util
File "/usr/lib/python3.8/site-packages/certbot/util.py", line 23, in
from certbot._internal import constants
File "/usr/lib/python3.8/site-packages/certbot/_internal/constants.py", line 6, in
from acme import challenges
File "/usr/lib/python3.8/site-packages/acme/challenges.py", line 11, in
import requests
File "/usr/lib/python3.8/site-packages/requests/init.py", line 113, in
from . import packages
File "/usr/lib/python3.8/site-packages/requests/packages.py", line 7, in
locals()[package] = import(package)
File "/usr/lib/python3.8/site-packages/idna/init.py", line 2, in
from .core import *
File "/usr/lib/python3.8/site-packages/idna/core.py", line 1, in
from . import idnadata
ImportError: cannot import name 'idnadata' from partially initialized module 'idna' (most likely due to a circular import) (/usr/lib/python3.8/site-packages/idna/init.py)

@Jamyz @ragaimeena I ran in the same problem and I ended up creating a SSL wildcard certificate and works out fine. Just follow the instructions here  at time 4:35 https://www.youtube.com/watch?v=TBGOJA27m_0&t=343s
I hope this helps


Crash when joining the world ins specific blocks

version 1.20.1
seems to be something related to a position i left the game in.
When

Joining a world
Enter third person
Some situation

Crash report
java.lang.ClassCastException: class net.minecraft.class_4618 cannot be cast to class net.minecraft.class_4597$class_4598 (net.minecraft.class_4618 and net.minecraft.class_4597$class_4598 are in unnamed module of loader org.quiltmc.loader.impl.launch.knot.KnotClassLoader @72035809)
at net.minecraft.class_761.handler$cdk000$leawind_third_person$renderEntity_tail(class_761.java:30943)
at net.minecraft.class_761.method_22977(class_761.java:1575)
at net.minecraft.class_761.method_22710(class_761.java:1324)
at net.minecraft.class_757.method_3188(class_757.java:1110)
at net.minecraft.class_757.method_3192(class_757.java:880)
at net.minecraft.class_310.method_1523(class_310.java:1219)
at net.minecraft.class_310.method_1514(class_310.java:802)
at net.minecraft.client.main.Main.main(Main.java:250)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at org.quiltmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:557)
at org.quiltmc.loader.impl.launch.knot.Knot.launch(Knot.java:84)
at org.quiltmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:28)
at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:100)
at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)
Seems to be something related to tailing a entity... not sure?

Maybe it has been fixed in the latest 2.0.8-1.20.1
Could you update and try again see see?

Seems to be fixed

It's fixed in ff3dac80d90e8210705d26e1e27f96e2f23afa38