Add ability to skip the top level model snapshot

First of all great job with EF7. Now it can be used in team environment :).
If I understand correctly the top lelve CONTEXTNAMEModelSnapshot is not used by EF. Could you add an option to disable its generation? I'm happy for it to be disabled out of the box. I know why it is there but I would like to have fewer than more merge conflicts :).

Hey,
We actually always use the snapshot, that is how we detect what changed since the last migration. Merging the file is actually the whole point of having it there. In situations where you get a merge conflict is where you would have got incorrect behavior out of migrations in the past. Now you merge the conflicting changes to the model and migrations will work correctly.
~Rowan

See also the Model Snapshots section of EF7 Migrations: Design-time

@rowanmiller ok so my understanding was not correct. thanks for clarifying.
If you build a piece of infrastructure that makes conflicts more likely to happen than not then you are not following the "pit of success" mantra.
DbUp simplicity + automated migration generation is where EF could shine. Why can't this be done? If you optimize your process for devs who have no CI and tests then you are going to exclude quite a few people. I will repeat, I'm happy with your default safety nets, just let me get rid of them if I don't need them. Otherwise they simply slow me down.

If we implemented #1298, you could just add the file to your scm's ignore list.

Just to be clear though... any time you need to merge this file because another developer changed it is a scenario where migrations will not work correctly if we didn't have a central model snapshot. If developers make unrelated changes in the model then they should auto-merge just fine. This means scenarios were migrations would have behaved incorrectly on EF6 (because we used the snapshot from the last migration) now work correctly. However if there is a real merge conflict in the file that requires manual merging then you can merge it and migrations will continue to work.
Implementing #1298 and ignoring the snapshot from SCM would basically give you the same behavior as EF6... which would work fine for a single developer but would have all the same issues as EF6 for teams.

@rowanmiller I did a quick test with 2 branches. One added Property1 and the other one added Property2 and I ended up with a merge conflict in that file. Shared state has a tendency to cause problems like that.
DbUp(and most of other platforms) works just by relying on the order of migrations. Scary :)? In theory yes, but I've never seen this being a problem for a team that has half decent CI and tests.
The article, that @bricelam linked to, mentions that you embed a snapshot of the model in every migration. Could build the global snapshot of the model from them and store it a temp file so it doesn't clutter the source code? Migrations are immutable so having snapshot there does not cause any trouble.

@pawelpabich deriving the model based on the latest migration(s) suffers a lot of problems (only in team environments). This article goes over the technical details of that https://msdn.microsoft.com/en-us/data/dn481501.

@rowanmiller if we can not use snapshots then can we simply have a mode where we rely on the order of migrations and their content?
In short, what stops us from having DbUp like experience with Entity Framework ?

Have you considered dropping snapshots altogether?
Instead of using snapshot maybe rebuild the model in memory from all the migrations found and then generate the new migration.
This would be the most friendly method for distributed teams and branch per feature flows.

We use snapshots because we do a diff based on the EF model, not just the shape of the schema. The simplest example of this is if you change the column that a property maps to. If you just do a schema diff then all you see if a add/remove but if you diff at the model layer then you can see it's just a renamed property.
Running the up method of migrations would likely introduce performance issues, it also prevents the scenario where you modify the migration after it is generated (add a column that is transparent to EF, change a data type, etc.). Since we would be effectively diffing the current db schema migrations would always try and change back anything you modified. With the snapshot you just get what has changed since the last migration was generated.
Running up methods also begins to suffer the same issue with conflicts. If you Developer 1 deletes a property and Developer 2 modifies it, then this isn't immediately obvious when you merge and the behavior you get happens to depend on the order things are run.
@pawelpabich your scenario of adding two new properties to the same class is one of the few examples where you will get a merge conflict when there isn't really a conflict... but I'm assuming you also got a merge conflict on the entity class that you added the properties too. So it should be pretty obvious that you merge the snapshot in the same way you merge the entity class.
For non-team scenarios the snapshot should be completely transparent and you can just consider it an implementation detail. In team environments, for the most part you will only get a conflict if you get a conflict in your actual entity classes (or the DbContext code). And that will often be a legitimate issue that needs to be merged.

@rowanmiller I think I'm lost here a bit. Correct me if I'm wrong. From what you are saying it looks like the snapshots that are embedded in each migration can not be used to generate the global snapshot? If that's not true and the only concern is perf then can you generate it only when it does not exist? In this way only people that want this feature will pay the additional tax.

@rowanmiller regarding the merge conflict. You are 100% right. But what I've been trying to communicate here is that it adds friction. Every dev process has some level of friction and I would like to see it decrease not increase. And I really hope you don't optimize for non-team scenario. How many 1 person teams do you have at Microsoft :) ?
I did the experiment again and I ended up with 2 conflicts. One in the entity and one in the model snapshot. Have a look at the one in the entity. All I had to is to click right and left which means include changes from both and I was done. Now have a look at the merge conflict in the snapshot file. It's scary, isn't it?. And what is more when I simply clicked left and right I ended up with a file that does not compile. This is unnecessary friction in its purest form.
What would be your response If every time you wanted a cup of tea someone asked you to do 5 pushups. Would you just do them or maybe you would ask why? What value does it bring? This is how I feel about this forced safety net.
Entity:

Snaphost:

From what you are saying it looks like the snapshots that are embedded in each migration can not be used to generate the global snapshot? If that's not true and the only concern is perf then can you generate it only when it does not exist? In this way only people that want this feature will pay the additional tax.

The snapshots in the migration can not be used for the reasons covered in the article I linked to. They work fine for single developer scenarios but do not work in teams.

And I really hope you don't optimize for non-team scenario. How many 1 person teams do you have at Microsoft :) ?

The global model snapshot is only being introduced because of teams. In a single developer scenario it would be fine to remove it and rely on the snapshot from the last migration.

I did the experiment again and I ended up with 2 conflicts. One in the entity and one in the model snapshot. Have a look at the one in the entity. All I had to is to click right and left which means include changes from both and I was done. Now have a look at the merge conflict in the snapshot file. It's scary, isn't it?. And what is more when I simply clicked left and right I ended up with a file that does not compile. This is unnecessary friction in its purest form.

This is really good feedback and just means there is an issue with the layout we are using in the snapshot as it needs to be tweaked to work better with merging. We need to use something that yields a change/merge that is more consistent wit the corresponding change in the entity class. I've opened https://github.com/aspnet/EntityFramework/issues/2377 to address this.

It's a pity that this can't be fixed but it is what it is.
Thanks


TypeError in node-warc causes Squidwarc to crash

Are you submitting a bug report or a feature request?
Bug report.
What is the current behavior?

Running Squidwarc 1a19eed5a1ea0ab1c8b608c2bffe104c84771184 (latest master) using docker-compose up. After a long process, I receive a TypeError:
Attaching to squidwarc
squidwarc    | Running Crawl From Config File warcs/conf.json
squidwarc    | With great power comes great responsibility!
squidwarc    | Squidwarc is not responsible for ill behaved user supplied scripts!
squidwarc    |
squidwarc    | Crawler Operating In page-only mode
squidwarc    | Crawler Will Be Preserving 1 Seeds
squidwarc    | Crawler Will Be Generating WARC Files Using the filenamified url
squidwarc    | Crawler Generated WARCs Will Be Placed At /Squidwarc
squidwarc    | Crawler Navigating To https://www.instagram.com/visit_berlin/
squidwarc    | Crawler Navigated To https://www.instagram.com/visit_berlin/
squidwarc    | Running user script
squidwarc    | Crawler Generating WARC
squidwarc    | A Fatal Error Occurred
squidwarc    |   TypeError: Cannot read property 'software' of undefined
squidwarc    |
squidwarc    |   - warcWriterBase.js:204 PuppeteerCDPWARCGenerator.writeWarcInfoRecord
squidwarc    |     [Squidwarc]/[node-warc]/lib/writers/warcWriterBase.js:204:15
squidwarc    |
squidwarc    |   - puppeteer.js:249 PuppeteerCrawler.genWarc
squidwarc    |     /Squidwarc/lib/crawler/puppeteer.js:249:31
squidwarc    |
squidwarc    |   - puppeteerRunner.js:72 puppeteerRunner
squidwarc    |     /Squidwarc/lib/runners/puppeteerRunner.js:72:21
squidwarc    |
squidwarc    |   - next_tick.js:68 process._tickCallback
squidwarc    |     internal/process/next_tick.js:68:7
squidwarc    |
squidwarc    |
squidwarc    | Please Inform The Maintainer Of This Project About It. Information In package.json
squidwarc exited with code 0

What is the expected behavior?
To not crash.
What's your environment?

macOS 10.14.2, node.js 10.12.0, Docker 18.09.0, Squidwarc 1a19eed5a1ea0ab1c8b608c2bffe104c84771184
Other information

This is an odd error to crash on.:
    if (winfo.software == null) {
      winfo.software = `node-warc/${this._version}`
    }

Is this the most reliable way to check if the software property is defined on winfo? Isolating this code in a separate file and fabricating an example does not crash node, but executes gracefully, so I think something else is at play.

fixed via PR #47


sorting

Bug title
Sorting
Bug description
By default it opens the DApp with "Minted by" selected, but it should select "Id" by default and sort from the lowest to highest AID
To Reproduce
Steps to reproduce the behaviour:

Open Beam Asset Minter DApp

Current behaviour

Expected behaviour
sort by AID starting at the lowest and not by 'Minted by' ( Asset Minter )

Additional Information
RE https://t.me/beamdevsupport/11619

Hello! I will be handling this issue

Great, thank you!


Optimization: Make PeriodicTableService a Singleton Service

Description
This small update improves performance of MudTable examples by:

Changing the PeriodicTableService from a scoped service into a singleton service
Loading Elements.json into a static variable once instead of reloading as an instance variable repeatedly

How Has This Been Tested?
This was tested by running unit tests then interacting with the MudTable examples via the MudBlazor.Docs.Server and MudBlazor.Docs.WasmHost projects to ensure no concurrency issues.
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[X] I've added relevant tests.

Notes for Reviewers

This change only affects MudBlazor examples
This change increases performance of the PeriodicTableService but also increases memory use via a new static variable.

@danielchalmers @mikes-gh is this ready to merge?

lgtm

lgtm


[Bulk] validation: fix duplicate title issues LS2

This PR fixes 1 duplicate title issue.

Docs Build status updates of commit 45de9c9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/Trusted-Application-API/docs/RegistrationInAzureActiveDirectory.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@lindalu-MSFT
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you'd like to see. Thank you!

Docs Build status updates of commit 6bace13:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/Trusted-Application-API/docs/RegistrationInAzureActiveDirectory.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Identifiers validation failed for dataset HPL - Herbário do Jardim Botânico Plantarum

Identifier validation failed for the dataset HPL - Herbário do Jardim Botânico Plantarum:

Crawler attempt: 471
Publishing organization: Jardim Botânico Plantarum
Publishing country: BRAZIL
Installation: speciesLink Network / INCT-HVFF IPT
Number of occurrences indexed for this dataset at the time of the issue: 13661
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 13661 total records; 13661 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/4177367/step

New IDs sample:

Old IDs sample:

BRA:JBP:HPL:13727
BRA:JBP:HPL:13728
BRA:JBP:HPL:13729
BRA:JBP:HPL:13730
BRA:JBP:HPL:13731
BRA:JBP:HPL:13732
BRA:JBP:HPL:13733
BRA:JBP:HPL:13734
BRA:JBP:HPL:13735
BRA:JBP:HPL:13736

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the HPL - Herbário do Jardim Botânico Plantarum : https://doi.org/10.15468/ymks0x.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset HPL - Herbário do Jardim Botânico Plantarum:

Crawler attempt: 472
Publishing organization: Jardim Botânico Plantarum
Publishing country: BRAZIL
Installation: speciesLink Network / INCT-HVFF IPT
Number of occurrences indexed for this dataset at the time of the issue: 13661
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 13661 total records; 13661 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/4198771/step

New IDs sample:

Old IDs sample:

BRA:JBP:HPL:13727
BRA:JBP:HPL:13728
BRA:JBP:HPL:13729
BRA:JBP:HPL:13730
BRA:JBP:HPL:13731
BRA:JBP:HPL:13732
BRA:JBP:HPL:13733
BRA:JBP:HPL:13734
BRA:JBP:HPL:13735
BRA:JBP:HPL:13736

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the HPL - Herbário do Jardim Botânico Plantarum : https://doi.org/10.15468/ymks0x.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.


All memory components are missing (pre-release)

Describe the bug
All memory components are missing in the 1.0.0a24 build. Besides "Message History", but you can't connect that to Memory nodes.
Version

Version: 1.0.0a24  started via docker-compose

To Reproduce
Steps to reproduce the behavior:

Start the docker image with the tag "1.0-alpha" or "1.0.0a24"
Create a blank flow
Search for memory

Screenshots

I have the same issue!

Hello,
Sorry for the delay. Did you try using the new version? Does the error still persist?


No Start Menu shortcut XP

From<EMAIL_ADDRESS>on 2014-09-02T18:19:00Z
Hi
I've just installed pythonxy, but its on a work managed pc (XP) that always manages to lose shortcuts from the start menu. Can you please point me to the correct run file so that I can create a desktop shortcut?
Thanks
What steps will reproduce the problem?

What is the expected output? What do you see instead?
What version of the product are you using? On what operating system?
Please provide any additional information below
.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1956

From ccordoba12 on 2014-09-03T17:01:00Z
This is the file: https://bitbucket.org/spyder-ide/spyderlib/src/1eddd97b6f61a08cbeaf72b6d3bcb512d31ba529/scripts/spyder_win_post_install.py?at=default It will also create a desktop shortcut

From ccordoba12 on 2014-11-18T17:05:20Z
I think this solved :-)
Status: WontFix


Add docker compose

Add a docker-compose.yml file to the project

Hi, can you please assign this to me

Hi @dhananjay0610 , go ahead, make the changes and create the pull request.

Hi, @ dhananjay0610, it's been over a month since I assigned this issue to you on your request, but you might have gotten busy, and cannot create a pull request for this. So, I'm unassigning this issue for now for other devs to know that they can work on this issue. If in future you are available and want to work on this issue, kindly let me know. I will re-assign it to you again.


Update Moriarty.py

Xpath updation (in microsoft_mail function)

Could you please update what the changes are needed and how the changes are tested? @gokullan

Changes made - Xpath updated in lines 62 and 68 of Moriarty.py (see the 'Files changed' tab for the exact changes)
Basically these 2 lines 'generate' (not sure if this is the right word) clicks in the true caller login webpage (https://www.truecaller.com/auth/sign-in): the code on line 62 generates a click on the 'Next' button after you enter your Microsoft mail ID; the code in line 68 generates the 'Sign In' click made after you enter the password. The problem was that the Xpath to these 'Next' and 'Sign In' buttons were not correct (probably because Truecaller might have made some changes to the login page). So I got the correct Xpath of these buttons (using the Inspect option in Chrome) and updated it.
Why this change was made - to prevent the Time Out Error bug that arose due to line 62
And with regard to how the changes are tested - I was able to get results after updation of these 2 lines.


Random minutes function in console scheduling

I was working on a project of mine and I needed to run the command in every random amount of minutes. I didn't care how many minutes exactly so I wanted to add this function to laravel console scheduling.
It may not be very important but some people may need it like I needed it today.

Hmm, I dunno if I will be adding this right now.

@lilessam this wont work properly - because a schedule needs to be "static" - otherwise the mutex's will fail etc. That is because the cron expression is part of the mutex.
Your better option is creating a schedule that runs every minute (or every 5mins etc) - and then the command itself decides if it should continue or not.

@laurencei I thought that the schedule will take the random number for the first time and execute it.
So if random number in the first time was 9 the command will be executed ever 9 mins.
Anyway what if we create a function to specify how many minutes exactly? like ->every(3) So the command will be executed every 3 minutes. Would it be a good feature?

@laurencei I thought that the schedule will take the random number for the first time and execute it.
So if random number in the first time was 9 the command will be executed ever 9 mins.

No - it runs the randomising on every cycle - so the way it is now, it will be random on every cycle. So it might never execute.

No - it runs the randomising on every cycle - so the way it is now, it will be random on every cycle. So it might never execute.
Didn't know that before thanks for the information.

There is already everyMinute(), everyFiveMinutes(), everyTenMinutes() and everyThirtyMinutes() - that should really cover most situations?
Yes I know this covers most situations but why don't we cover ALL situations? xD What do you think if I make this function and make a new pull request would it be merged? There's maybe someone who needs to execute the command every 90mins not every hour .. maybe every 20mins etc. What do you think?

@lilessam You can do every 20 minutes like this: ->cron('*/20 * * * * *'); or ->cron('0,20,40 * * * * *');
You can do 90 minutes, too. There are examples online.
If you want something to happen at a random minute every hour, you could have an hourly task that dispatches a delayed job to the queue by telling it to wait a random length of time.

every 90mins not every hour

I dont think you can do that as a cron (without specifying all the minutes individually)?

@lilessam You can do every 20 minutes like this: ->cron('*/20 * * * * *'); or ->cron('0,20,40 * * * * *');

Oh, I saw that now didn't notice before, So that's already done. Great !

I dont think you can do that as a cron (without specifying all the minutes individually)?

Didn't understand you actually but anyway it seems this functionality already exists with ->cron() method.


Sort list of deprecated metrics

Moving from an unreadable string of dropped metrics to an array.
I did it in 2 steps which are reflected in 4 commits. The first step is converting a string of metrics into an array and adding storage_operation_errors_total to it. After this, I regenerated manifests for easier code review. The second step was a simple sort of metric in an array.
Dropping storage_operation_errors_total is necessary for e2e tests to pass on k8s 1.21 as the metric is deprecated in that version. This is also done in https://github.com/prometheus-operator/kube-prometheus/pull/1161
/cc @prometheus-operator/kube-prometheus-reviewers

Rebased and formatted.


RTMP

I have a rebroadcast of RTSP via RTMP. When I try to add RTMP it ways only RTSP stream is allowed. Can you point me to where to make modifications that would allow such RTMP streams.

I'm not a video specialist and I don't write video software. I used the binary from project:
https://github.com/deepch/RTSPtoWebRTC

Does this help ?

@gigabyteservice maybe. I don't promise anything. Very big and specific feature

I'll add a +1 to RTMP support!

Maybe this will help?🤞
https://github.com/pion/example-webrtc-applications/tree/master/rtmp-to-webrtc

Check my new project. It has RTMP support
https://github.com/AlexxIT/go2rtc


No Align alloc

Issue #, if available:
Description of changes:
Default allocator is aligned and in practice has some overhead in peak memory usage in header acquire/free scenarios.
Add no align allocator as alternative
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f705c61) 82.69% compared to head (9d5e6b6) 82.75%.

:exclamation: Current head 9d5e6b6 differs from pull request most recent head f9731d5. Consider uploading reports for the commit f9731d5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
+ Coverage   82.69%   82.75%   +0.06%
==========================================
  Files          54       54
  Lines        5708     5729      +21
==========================================
+ Hits         4720     4741      +21
  Misses        988      988

Files
Coverage Δ

source/allocator.c
97.93% <100.00%> (+0.56%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Publish binaries for release

Since most people that will use RSLint are going to be JavaScript / TypeScript developers, many of them will not have Rust installed. So it would be nice to add workflows to publish binaries for multiple platforms in every release and upload them to the specific GitHub release as an asset.

Yeah that is planned, i just have not gotten around to setting up CI to do that, and i don't really expect many people to use it as a prebuilt binary at this point since its got a lot of bugs and is still early in development.


Warning in TicTacToe SwiftUI demo: cycle detected through attribute 132648

Describe the bug
These errors appear in the debug logs for the SwiftUI:
=== AttributeGraph: cycle detected through attribute 352280 ===
=== AttributeGraph: cycle detected through attribute 351784 ===
=== AttributeGraph: cycle detected through attribute 351784 ===
=== AttributeGraph: cycle detected through attribute 340792 ===
=== AttributeGraph: cycle detected through attribute 340792 ===

To Reproduce

Clone the repo. I used "commit 11f215c3b6923dfcccec6d1de6a672963a0d3c6e"
Open TicTacToe.xcodeproj
Run the demo
On Login screen, type in anything to email and password and tap Log in button.
Filter Xcode debug input for cycle

Expected behavior
No warning.
Screenshots
N/A
Environment

Xcode Version 12.3 (12C33)
Simulator: iPod touch (7th generation), which is what I tested. Shouldn't matter which simulator though.

Hi @ivanmkc, thanks for the report.
This appears to be a SwiftUI bug :/ I was able to track it down to this one single line:
https://github.com/pointfreeco/swift-composable-architecture/blob/11f215c3b6923dfcccec6d1de6a672963a0d3c6e/Examples/TicTacToe/Sources/Views-SwiftUI/LoginSwiftView.swift#L83
Commenting that out avoids "cycle" logs. This line's purpose is to disable the enter login form while the login API request is in flight. It appears that messing with a NavigationLink's enabled/disabled state is problematic.
I'm inclined to leave the code in as-is, and perhaps try create a minimal repro case to file with Apple. Let me know if you're able to get such a minimal example.

Hi @ivanmkc, thanks for the report.
This appears to be a SwiftUI bug :/ I was able to track it down to this one single line:
https://github.com/pointfreeco/swift-composable-architecture/blob/11f215c3b6923dfcccec6d1de6a672963a0d3c6e/Examples/TicTacToe/Sources/Views-SwiftUI/LoginSwiftView.swift#L83
Commenting that out avoids "cycle" logs. This line's purpose is to disable the enter login form while the login API request is in flight. It appears that messing with a NavigationLink's enabled/disabled state is problematic.
I'm inclined to leave the code in as-is, and perhaps try create a minimal repro case to file with Apple. Let me know if you're able to get such a minimal example.

I'm going to close this issue but let us know if you have any other questions.

I think this bug might have something to do with disabling the TextField before resigning it as first responder. I posted about this issue in this stackoverflow article.


Sanjeev neupane

Assignment 1 and 2 added

Good one Sanjeev!!! Here's suggestion - Lets use only one iteration statement. You can Console.Writeline in first Forloop itself.


358 increase coverage

Extra unit test on disable enter key feature.
#358

Codecov Report

Merging #418 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   86.19%   86.19%
=======================================
  Files          35       35
  Lines        4352     4352
  Branches      355      355
=======================================
  Hits         3751     3751
  Misses        574      574
  Partials       27       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aafe5da...a2ccc26. Read the comment docs.

👍


Hi removed some warnings

I just removed some warnings from "characters" as they were depreciated and updated settings as XCode recommended.
I updated the version to 2.7.3
Nothing special indeed and thanks for the great pod.
-Fist

Thanks. LTGM


pass requester_group when creating requests

This gets the requester's group into a request
Then it can be accessible to automate request flow.
https://bugzilla.redhat.com/show_bug.cgi?id=1187777
/cc @gmcculloug just need a test to verify the workflow

@gmcculloug Who can review this PR?

@bdunne can help.  I am also working the @kbrock to review/test these changes.

Cool :+1: LGTM


Address some Dependabot security alerts

Update some insecure dependencies.
See https://github.com/jetstack/cert-manager/security/dependabot

These are mostly mechanical changes and the commands I ran are in the commit messages, except:
replace github.com/deislabs/oras => github.com/oras-project/oras v0.12.0

Which seemed to be necessary because that project has been moved to a different GitHub org.
NONE

/kind cleanup

I'm confused by this test failure:
I1001 10:55:00.965066   18666 watch.go:183] Stopping fake watcher.
--- FAIL: TestSync (5.94s)
    --- FAIL: TestSync/gateway-shim (3.03s)
        --- FAIL: TestSync/gateway-shim/if_a_Gateway_contains_two_listeners_with_different_Secret_names,_it_should_create_two_Certificates (0.13s)
            sync_test.go:2450: got unexpected events, exp='[Normal CreateCertificate Successfully created Certificate "foo-example-com-tls" Normal CreateCertificate Successfully created Certificate "bar-example-com-tls"]' got='[Normal CreateCertificate Successfully created Certificate "bar-example-com-tls" Normal CreateCertificate Successfully created Certificate "foo-example-com-tls"]'
I1001 10:55:00.965112   18666 reflector.go:225] Stopping reflector *v1.Certificate (10ms) from external/io_k8s_client_go/tools/cache/reflector.go:167
FAIL

It looks like the same events, but with different order, but the assertion uses EqualUnsorted to compare them, so the order shouldn't matter:
https://prow.build-infra.jetstack.net/view/gs/jetstack-logs/pr-logs/pull/jetstack_cert-manager/4484/pull-cert-manager-bazel/1443886273625329664
Test fails here:
https://github.com/jetstack/cert-manager/blob/cfbb32d8ce708f9cd03c709506a30197b22379b0/pkg/controller/certificate-shim/sync_test.go#L2449-L2451
https://github.com/jetstack/cert-manager/blob/cfbb32d8ce708f9cd03c709506a30197b22379b0/pkg/controller/test/context_builder.go#L225-L233

@wallrj I think it calls EqualSorted?
We had a discussion around whether it should not call EqualUnsorted instead with @maelvls some time ago

@wallrj I think it calls EqualSorted?
We had a discussion around whether it should not call EqualUnsorted instead with @maelvls some time ago

Doh! I misread it. Thanks.
I'll change it to EqualUnsorted. It fails quite reliably on my laptop.
$ go test ./pkg/controller/certificate-shim/... -run TestSync/gateway-shim -count=100 --failfast

--- FAIL: TestSync (2.77s)
    --- FAIL: TestSync/gateway-shim (2.77s)
        --- FAIL: TestSync/gateway-shim/if_a_Gateway_contains_two_listeners_with_different_Secret_names,_it_should_create_two_Certificates (0.13s)
            sync_test.go:2450: got unexpected events, exp='[Normal CreateCertificate Successfully created Certificate "foo-example-com-tls" Normal CreateCertificate Successfully created Certificate "bar-example-com-tls"]' got='[Normal CreateCertificate Successfully created Certificate "bar-example-com-tls" Normal CreateCertificate Successfully created Certificate "foo-example-com-tls"]'

Yeah I agree- I also don't think we should test in what order the events are thrown.

My earlier description said that we need, but that's not actually the case. I removed it:
replace github.com/deislabs/oras => github.com/oras-project/oras v0.12.0

This looks good to me 👍🏼
I that the updated version of helm now uses a yet differently named module for this 'oras' thing- oras.land/oras-go instead of github.com/deislabs/oras which is I suppose because the module was moved to its own org.
/lgtm
/approve


check: disk performance benchmark

use fio psync ioengine instead of libaio

@LinuxGit  Would you please let us know the reason why the PR has changed fio's ioengine to psync from libaio?

@dbjoa TiKV use pread and write syscall a lot, you can strace apply worker and store-read-pool thread.


Report syncer status through sync target conditions before it is ready

Debugging syncer problems is hard because it does not report anything until it is fully ready. We want it to set conditions much earlier.

Can you please assign this to me?
I would like to give it a try :)

@sm43 sure! Could you please write down a little bit about what/where you plan to implement the condition updates, so we can get rough agreement on the approach before you dive in to coding? Thanks!

hello, due to time constraints I won't be able to do this.
If this is urgent please unassign so that someone else can pick it up.
Sorry for the delay. If not urgent I will give it try soon. Thanks.

/unassign @sm43

/transfer-issue contrib-tmc


Jetstream: Adding a workload to execute the

jetstream suite of browser based tests.

Updated commit message to be one liner
Removed commented code
Added explicit path for xml dump
Fixed pylint errors
Fixed pep8 errors


UI: Fix filter width to display options

Description
This PR fixes the Filter display to fix the options length (tested on different views and Instances options were not properly displayed):
Before:

After:

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6325 (SL-JID-1483)


Sync envoyproxy/ratelimit

Tested: https://github.com/bufbuild/modules/pull/611, I will test this in the backend BSR syncer.


Proxy retry call to Laravel HTTP client

Allow for client retry to be passed to Laravel HTTP wrapper (https://laravel.com/docs/11.x/http-client#retries).
Prism::text()
  ->using(Provider::Anthropic, 'claude-3-5-sonnet-20240620')
  ->withClientRetry(3, 100)
  ->generate()

or
Prism::text()
  ->using(Provider::Anthropic, 'claude-3-5-sonnet-20240620')
  ->withClientRetry(3, 100, function (Exception $exception, PendingRequest $request) {
    // 529 - overloaded_error: Anthropic's API is temporarily overloaded.
    // https://docs.anthropic.com/en/api/errors
    return $exception->getCode() === 529;
  })
  ->generate()

This looks great! Thank you so much for the contribution!


Improve FE UT start cost

What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Improve FE UT start cost 40s -> 7s
And the log4j2 init cost 5s

What's the most effective improvement behind these code?

What's the most effective improvement behind these code?

Remove useless log4j configuration. 40s -> 30s
Remove BDBJe. 30s -> 15s
Remove BE services. 15s -> 10s
Remove find port. 10s -> 7s


Attempting to Create NPC with Attributes Lower Than 7 resets it to 7

I'm trying to create NPCs with attributes lower than 7 (A Targ from the CRB, p340), but when I try and set any of the values below 7, the sheet resets it to 7.
This wasn't an issue before the update to FVTT v10.

I just noticed the same thing. It's obviously helpful for players to have the values clamped in order to avoid accidentally entering invalid inputs, but there needs to be some way of overriding the default behavior.
A quick fix would be to check some sort of tag in the character name I've been using [Minor], [Notable], and [Major] to indicate NPC characters, but a simple [NPC] might do. Also the Child Characters options from the Player's Guide may result in a character having an Attribute under 7, so maybe a [Child] tag for that might be helpful as well.
A proper UI for additional character options would of course be nice, too. Some of the fields and the Reputation track at the top are quite unnecessary for NPCs.

Reopening because I must have accidentally hit close with comment before.
One idea I was mulling about was adding a system level Game Setting to just remove the attribute/discipline limits that are in place. This way the person running gets to decide what they prefer, using the tags that were added in with 1.1.10 or just turning that automation off entirely.

Definitely in support of the option to remove the hard limits. I had edited the JS file myself in previous versions to remove the lower limit so that the option was available, and of course was no incentive for my players to "cheat" by giving themselves lowered stats. In my opinion the tags solution is more cumbersome than it needs to be, the simple and more elegant solution to me is just being allowed to remove the limitations in the first place and letting the GM be the arbiter of the rules.

There are some creatures in some of the pre-written adventures, for instance the episode "Darkness" in "Strange New Worlds," that have attributes above 12. So having the ability to alter/ignore the min/max values would be nice.

Implementing a setting with the next release that will allow users to override these limits. Just go into system settings and select that you want to "Ignore normal Max/Min limits..." for whatever values you want that automation removed from. I'll get some screenshots up in a lil bit.


Scheduling around operation

This issue is a reminder to follow up with Chris B and David K regarding: Discuss FDA status - Contained in RTX KG2.
This will be discussed at the next Arch call.
More details needed.

Dupe of another issue


Istio rewrite to a different prefix does not work

Describe the bug
{{ Succinctly describe the bug }}
trying to use one port for GRPC in the ingress gateway, as well as 1 gateway .
I want to create a virtualservice for each service i deploy to K8S and to route to those services with 1 load balancer and one port but different api calls(prefix or virtual host like in nginx)
Expected behavior
{{ What did you expect to happen? }}
i want the end route to be to the one i rewrite
this is the route created, and you can see in the decorator that it does not get rid of the "trs-tulip" prefix:
and this way it does not get the traffic also.
"name": "http.24051",
        "virtualHosts": [
            {
                "name": "*:24051",
                "domains": [
                    "*",
                    "*:24051"
                ],
                "routes": [
                    {
                        "match": {
                            "prefix": "/trs-tulip"
                        },
                        "route": {
                            "cluster": "outbound|50051||trs-tulip.ud.svc.kube.am.taboolasyndication.com",
                            "prefixRewrite": "/",
                            "hostRewrite": "",
                            "timeout": "0.000s",
                            "maxGrpcTimeout": "0.000s"
                        },
                        "decorator": {
                            "operation": "trs-tulip.ud.svc.kube.am.taboolasyndication.com:50051/trs-tulip*"
                        },
                        "perFilterConfig": {

Steps to reproduce the bug
{{ Minimal steps to reproduce the behavior }}
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: trs-tulip-gateway
spec:
  selector:
    istio: ud-ingressgateway
  servers:
  - port:
      number: 24051
      name: grpc
      protocol: HTTP2
    hosts:
    - "*"

apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: trs-tulip-vsvc
spec:
  hosts:
  - "*"
  gateways:
  - trs-tulip-gateway
  http:
  - match:
    - uri:
        prefix: "/trs-tulip"
    rewrite:
      uri: /
    route:
    - destination:
        host: trs-tulip
        port:
          number: 50051

Version
{{ What version of Istio and Kubernetes are you using? Use istioctl version and kubectl version }}
istio: 1.0.1
k8s: v1.11.3
Installation
{{ Please describe how Istio was installed }}
helm charts
Environment
{{ Which environment, cloud vendor, OS, etc are you using? }}
vanilla kubernetes
Cluster state
{{ If you're running on Kubernetes, consider following the
instructions
to generate "istio-dump.tar.gz", then attach it here by dragging and dropping
the file onto this issue. }}

As @hzxuzhonghu , there is "prefixRewrite": "/" in the route definition. The path in the decorator does not mean that the prefix was not rewritten.
I would check the log of istio-ingressgateway istio-proxy and see which command appears there, with or without the path. Also would check the log of trs-tulip.ud.svc.kube.am.taboolasyndication.com which request it received.

and btw the decorator means how the request is going to reach to this service right ?
so the meaning of what im trying to do with prefix rewrite is eliminate the "trs-tulip" that I added in first place it was just for the routing.
and I will explain even more of what i'm trying to do:

I want to listen with my ingress gateway on only 3 ports, each for 1 protocol - HTTP,HTTP2,HTTPS
I want to control the routing to different services with an / added to the url, and with istio I want to take this add-on off so it will route only to the destination and the port, for example:
<IP_ADDRESS>:24051 . so maybe i'm trying to do this not in the right way, and you can spill some light here. or maybe it's impossible.. will be good to know

the decorator means how the request is going to reach to this service right

I do not think so, I guess it is just a "decorator", to mark the operation in statistics and logs, it is not related to routing.
What you are trying to achieve with the routing is totally reasonable and it should work in Istio.

interesting so yea if you say i'm doing it right so whats left is to check the logs

Please write the command you perform to test, e.g. curl, and what you see in the logs of istio-ingressgateway and trs-tulip.ud.svc.kube.am.taboolasyndication.com

I have a GRPC client trying to make a request, (it works when I try to match only by port)

Thanks for this info.. This should have been documented where.. Took some time to figure this out.. But yes this is a MUST if we want to expose a GRPC service outside of Istio - uri exact match directly to the pod ip.

So after we have talked offline about how to figure this out we came with the next steps:

We found out that GRPC client injects stuff to the uri by himself, it injects the "Service Name" and the method of the GRPC client request which was defined in the proto file(of GRPC in JAVA).
No matter what I tried to reach with my GRPC client it added this to the uri, so we had to find that uri it uses.
After we found the exact request that sent to istio, we change the virtualservice to this:

apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: trs-tulip-vsvc
spec:
  hosts:
  - "*"
  gateways:
  - trs-tulip-gateway
  http:
  - match:
    - uri:
        exact: /trs.TrsTulipRulesReaderService/GetTulipRule
    route:
    - destination:
        host: trs-tulip
        port:
          number: 50051

and we can see what match I used here, by the uri I found, and only than the route worked
Thank you very much @vadimeisenbergibm !

Can you please describe what is .. "/trs.TrsTulipRulesReaderService/GetTulipRule" ?
I understand "GetTulipRule" is some path/resource on server TrsTulipRulesReaderService is a service running on host "trs-tulip" what is trs. ?

I asked myself the same thing

/trs.TrsTulipRulesReaderService/GetTulipRule is the path defined in proto file


[full-ci] [tests-only] Sort out expected-failures for share expiration date

Description
The related issue is "Implement expiration date for shares"
The scenarios related to that issue had ended up in a couple of different places. This PR puts the scenarios together in the expected-failures file in 3 sections, for user, group and public link shares. This should make it easier when a developer starts to implement this some day.
Related Issue
#1250
How Has This Been Tested?
CI
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[x] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

Note: https://github.com/owncloud/core/pull/39120 will stop the lock breaker groups scenarios from running in oCIS CI. I will bump the commit id after that is merged to core master.


Add dashboard authentication

This adds http auth to the Rita dashboard endpoints, before any value
is set no password is requested, once a new value is set it will be
used from there on out.

setting the local password doesn't work and the sha digest doesn't seem to match sha3sum on the console (possible assci versus utf encoding issue?)

the issue was not using fixed length sha3 encoding and such. Also upgraded to 512

@asoltys  so we probably want to use a repo on the althea github, also your commit message for your unauthorized changed is really bad and should probably be expanded. Once we've got this setup to operate from the althea github and all that we should be good.

Ok I forked the repo and also rebased on master a little more cleanly so this should be ready to merge now. Just waiting on Travis.


Remove reactivesocket-local-transport

Problem
Nobody is using this code, and I start to be tired of maintaining it.
Solution
Remove it, git keep the code in its history if we need it.

👍
@robertroeser ok?

Based on offline discussions with @robertroeser we may need this.
@stevegury lets close this one and keep your branch in case we decide to remove.

Ok


Blank cell in Jupyter Notebook

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.93.1
OS Version: Ubuntu 22.04

The cell cannot be edited in any way and can only be deleted.
Steps to Reproduce: Appears occasionally during normal work.
Version: 1.93.1
Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
Date: 2024-09-11T17:20:05.685Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 6.5.0-21-generic

I am also having this issue
Version: 1.94.2 (Universal)
Commit: 384ff7382de624fb94dbaf6da11977bba1ecd427
Date: 2024-10-09T16:08:44.566Z
Electron: 30.5.1
ElectronBuildId: 10262041
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 23.5.0


IMO 2003 P6

Thanks! I moved a commend and the open Finset into the proof body in https://github.com/dwrensha/compfiles/commit/62085b1cc5ad98978ba94bd9d5c5a84a9562a7b2, so that they don't show up in the generated web page https://dwrensha.github.io/compfiles/problems/Compfiles.Imo2003P6.html.


Error when trying to load Tex files

I just installed vim-airline and have not yet changed any configuration settings. Airline works with most filetypes, but when trying to load a tex files, it spouts the following error:
Error detected while processing function <SNR>29_on_window_changed..<SNR>29_init:
line    4:
E117: Unknown function: airline#init#bootstrap
line    5:
E117: Unknown function: airline#extensions#load
line    6:
E117: Unknown function: airline#init#sections
Error detected while processing function <SNR>29_on_window_changed..<SNR>29_init..airline#switch_matching_theme:
line    7:
E121: Undefined variable: g:airline_theme_map
E116: Invalid arguments for function items(g:airline_theme_map)
E15: Invalid expression: items(g:airline_theme_map)
Error detected while processing function <SNR>29_on_window_changed..<SNR>29_init:
line    9:
E171: Missing :endif
Error detected while processing function <SNR>7_FTtex:
line   43:
E171: Missing :endif

is this still reproducible?

I don't remember seeing it in a long time. So I guess, somewhere along the line the issue was fixed. Can't say what fixed it though.


SCT logo does not appear correctly when using Docker FSLeyes

When using sct_pluging.py in FSLeyes via Docker, the logo is not displayed properly:

Version: sct-docker-4.2.1

Setting size of SCT logo by Scale method instead of SetSize before converting it to bitmap helped me on Debian 10:
https://github.com/neuropoly/spinalcordtoolbox/commit/8ee7318c9264bc8ee8eeda04469f1f2262f4252e


Unused outputs can be controlled by logic outside the module

Describe the bug
Unused outputs can be controlled by logic outside the module.
To Reproduce
import 'package:rohd/rohd.dart';

class Example extends Module {
  Logic get out => output(_out.name);
  late final _out = addOutput('out');
}

void main() async {
  final example = Example();
  final logic = Logic();
  example.out <= logic;
  await example.build();

  print(example.out.value);
  logic.put(1);
  print(example.out.value);
}

Expected behavior
The outputs are controlled only by the module itself.
Actual behavior
Unused outputs can be controlled by logic outside the module.
Additional: Dart SDK info
No response
Additional: pubspec.yaml
No response
Additional: Context
ROHD v0.4.2

ROHD actually is architected in a way that makes this hard/impossible to detect depending on how it is done.  The hierarchy of modules is defined by the connectivity of wires, not by where the logic is declared.  While the "normal" case is that you want all the logic associated with a Module to be declared "within" that Module, in reality logic could be generated by functions, classes, etc. that live anywhere and apply the logic to be connected within that module.
This can be leveraged as a strength, even in some sort of weird scenarios.  For example, imagine building up some hierarchy of hardware modules, then later wanting to generate logic that stitches something throughout the hierarchy from a utility that sits "outside" all of those modules.  As long as the connectivity lines up in a reasonable way (i.e. logic doesn't connect between modules without going through ports to get there), then that can be achieved legally.
Does this answer your concern?  Do you have any thoughts on a specific scenario where this methodology poses a problem?  Is there some check you wish was there that would prevent "bad" things without overly restricting "intentional" things?

Thank you for the clarification! I didn't even think about such use cases.

Does this answer your concern? Do you have any thoughts on a specific scenario where this methodology poses a problem? Is there some check you wish was there that would prevent "bad" things without overly restricting "intentional" things?

After you explained that ROHD uses a connectivity of wires to build the module hierarchy, I have nothing more to offer. I am not particularly familiar with the development of logic simulators/synthesizers and hardware, so I can point out supposedly “wrong” things that I don’t have enough experience and knowledge to understand. Thank you for being patient and talking about the design of this or that solution.
I think I will close the problem, since a detailed answer was received.

Glad it clarified, thanks for filing!  It's very helpful to hear feedback and concerns even if not all of them directly lead to a code change.  Perhaps some documentation could be improved somewhere to make this more intuitive.  It is a significant change from writing code in SystemVerilog, though.


[UNDERTOW-1471] unify secure uri processing for wss and https

Issue: https://issues.redhat.com/browse/UNDERTOW-1471
Upstream PR: #1054
2.1.x PR: #1093

We are waiting for clearance from CI in both master and 2.1.x PRs: #1054 and #1093


Incorrect selection of tiled monitor

When I use ddcci_plasmoid_backend on my tiled LG 5K monitor, the wrong "submonitor" seems to be selected for control:
$ ddcci_plasmoid_backend -d detect
DEBUG ddcci_plasmoid_backend.__main__: backend version: 0.1.6
DEBUG ddcci_plasmoid_backend.__main__: ddcutil version: 1.4.1
DEBUG ddcci_plasmoid_backend.__main__: argv: /usr/bin/ddcci_plasmoid_backend -d detect
DEBUG ddcci_plasmoid_backend.ddcci: Execute command: `ddcutil detect`
DEBUG ddcci_plasmoid_backend.ddcci: [code]   ddcutil detect: 0
DEBUG ddcci_plasmoid_backend.ddcci: [stdout] ddcutil detect: Invalid display
   I2C bus:  /dev/i2c-16
   DRM connector:           card0-eDP-1
   EDID synopsis:
      Mfg id:               SHP - Sharp Corporation
      Model:
      Product code:         5399  (0x1517)
      Serial number:
      Binary serial number: 0 (0x00000000)
      Manufacture year:     2021,  Week: 10
   DDC communication failed
   This is an eDP laptop display. Laptop displays do not support DDC/CI.

Display 1
   I2C bus:  /dev/i2c-19
   DRM connector:           card0-DP-3
   EDID synopsis:
      Mfg id:               GSM - Goldstar Company Ltd (LG)
      Model:                LG HDR 5K
      Product code:         30497  (0x7721)
      Serial number:        106NTWGDP049
      Binary serial number: 465049 (0x00071899)
      Manufacture year:     2021,  Week: 6
   VCP version:         Detection failed

Display 2
   I2C bus:  /dev/i2c-20
   DRM connector:           card0-DP-4
   EDID synopsis:
      Mfg id:               GSM - Goldstar Company Ltd (LG)
      Model:                LG HDR 5K
      Product code:         30497  (0x7721)
      Serial number:        106NTWGDP049
      Binary serial number: 465049 (0x00071899)
      Manufacture year:     2021,  Week: 6
   VCP version:         2.1
DEBUG ddcci_plasmoid_backend.ddcci: [stderr] ddcutil detect:

DEBUG ddcci_plasmoid_backend.ddcci: Found 3 entries at root level
DEBUG ddcci_plasmoid_backend.ddcci: Key Invalid display does not match pattern for valid display, so skip it
DEBUG ddcci_plasmoid_backend.ddcci: LG HDR 5K id=2: Duplicate monitor found and removed
DEBUG ddcci_plasmoid_backend.ddcci: Execute command: `ddcutil getvcp --bus 19 --brief 10`
DEBUG ddcci_plasmoid_backend.ddcci: [code]   ddcutil getvcp --bus 19 --brief 10: 1
DEBUG ddcci_plasmoid_backend.ddcci: [stdout] ddcutil getvcp --bus 19 --brief 10: VCP 10 ERR
DEBUG ddcci_plasmoid_backend.ddcci: [stderr] ddcutil getvcp --bus 19 --brief 10:

DEBUG ddcci_plasmoid_backend.__main__: Command 'ddcutil getvcp --bus 19 --brief 10' returned non-zero exit status 1.
DEBUG ddcci_plasmoid_backend.__main__: Detected 0 working monitor busses, 1 non-working bus.
{"command": "detect", "value": []}

The first display is my laptop screen, which is correctly ignored. Then the second and third represent the tiled monitor. However, only the second display has VCP enabled, but it is excluded as a duplicate. Of course, that is exactly the one that you would want to get picked.
Maybe the solution is to ignore displays that have "VCP version: Detection failed"?

Fixed in latest release 0.1.8, thanks for reporting!

Confirmed, the fix works. Thank you for the quick response.


Append something with repo name for GitOps to keep GitOps repo separate from source code

Summary
If someone uses the same organization in their git which has their source code and on devtron UI they use the same name as repo name, then devtron commits the app values yaml in their source code repository which is not good
Motivation
Whenever I use the same configuration as above, my source code repo will stay intact and I won't expose anything to the developers
Proposal
Devtron can append something like -devtron to the name of GitOps repos at backend to ensure that a new repo is created everytime user creates a new app

duplicate of https://github.com/devtron-labs/devtron/issues/933


Make copy button visible on code blocks

Hello,
copy button is not visible on code blocks. Here is a screenshot from official documentation (https://imfing.github.io/hextra/docs/guide/syntax-highlighting/):

This PR makes the button visible:

⚠ please note I'm not satisfied with the behavior: it looks like a check mark shall be displayed for 1s after click. This is still not the case. I've tried to hack the css and js but I must admit I do not know much about tailwind & css.
Thanks.

hi, thanks for the PR. The current behavior is intended.
Please use https://imfing.github.io/hextra/docs/advanced/customization/#custom-css to override the style based on your own need.

Hello thanks for your answer. In that case it's worth changing this on docs:

I will close the PR tomorrow if it stays as is.

@pchalamet thank you, I wasn't aware that this is a bug. The copy code button should be visible when the mouse is hovering over the code block.
This issue has been addressed in #323

Thanks.


SECOAUTH-179 improvement suggestions

Issue SECOAUTH-179 Improve extendability of RandomValueTokenServices by keeping storage separate from token creation
My few commits were related to the same improvements. They go a few steps further.
1 random tokenvalue and expiration date are calculated in RandomValueTokenServices and passed to a new createXXXToken method. Subclasses can override this new createXXXToken method to instantiate their own token class. This way RandomValueTokenServices is responsible for tokenvalue and expiration.
2 Optimized the TokenStore interface a little to have a more efficient store implementation. My CustomTokenStore does not use the tokenvalue as primary lookup key. With these changes I can pass around my custom primary key.

I think these changes are obsolete now.  If there's still something useful here, can you rebase onto master and re-submit as a single commit?  Sorry for the hassle.

Both points still stand. 2 is the most important one. The TokenStore interface makes a custom implementation very inefficient. The JdbcTokenStore works, but uses a schema which requires a lot of storage space and large indexes. I never get that past my DBA. Using the String tokenValue while the Object token is also available requires more work than needed. In my case I first have to lookup the token again and then do the action while RandomValueTokenServices just did a lookup a few statements earlier.

OK, fair enough.  I still need you to rebase and re-submit the pull request though.  Sorry again for the hassle.


Lack of documentation

I think that such a good tool needs a good manpage (or info). Also I will try to write it, if I can recall syntax.

Having a man/info-page would be really great. For now all we have are two doc pages in markdown format. There are a few tools that could convert MD into manpage. However, the source itself should be more man-like in its content, I suppose. So our best bet is to rework docs in more standard way, and set an autoconvertion tools do the job.

Finally we've got a man page, thanks to @Roguelazer!


add hover effect to button backgrounds

added a 'color'-btn class to the colors file so that you can change the background of buttons whilst maintaining the hover effect of lightening the background 5%.
Example usage - http://jotmagic-pl.azurewebsites.net/Basics/Buttons
(Note I use 12% lighten here)

Good idea, but shouldn't this be a part of the button module?

Your link isn't working :=)


updated to latest pytorch version; added "trace_and_dot" wrapper

hmm does not work me on pytorch nightly due to https://github.com/pytorch/pytorch/pull/29149 , it seems to be private now?

Ah, darn. I only updated it to work with the latest release 1.3.1, which is what's on PyPI currently.


(Improvement) O3-3594: Add Docker Logout Steps to GH Actions Workflow

https://openmrs.atlassian.net/browse/O3-3594
This PR adds steps to log out from DockerHub and GitHub Container Registry at the end of our GitHub Actions workflow. This helps keep our credentials safe and ensures proper cleanup. The logout steps only run if it's not a pull request.

@jayasanka-sack !, can u review that PR

@jayasanka-sack ! i've done those can u check

@jayasanka-sack ! Done

@ibacher I'm not sure if this repo is still in use. If it is, can you review and merge this PR? I don't have write permission.
Meanwhile @Bcoderx6, we don't use (improvement) as a commit label. (chore) would be the best option for this PR. Read more: https://o3-docs.openmrs.org/docs/frontend-modules/contributing.en-US#contributing-guidelines

No, this project isn't used anymore.


Rework filter support to have a common API for all platforms

Moves and provides all Filters to common code, to provide a uniform scanning experience on all platforms. Uses native filtering support (when available) and falls back to leveraging flow filtering (when not natively supported).
All Filters are supported on all platforms, except for Filter.Address, which is only supported on Android.

Filter
Android
Apple
JavaScript

Service
✓✓
✓✓*
✓✓

Name
✓✓
✓
✓✓

NamePrefix
✓
✓
✓✓

Address
✓✓

ManufacturerData
✓✓
✓
✓✓

✓✓ = Supported natively
✓ = Support provided by Kable via flow filter
✓✓* = Supported natively if the only filter type used, otherwise falls back to flow filter
Diff shows changes from #396; will rebase after #396 is merged to clean up the PR changes.

Note to self: escalate deprecations related to scanning/filtering.

Awesome changes, love the comments as always, makes it so much easier to follow


3.7.5 : is and js_is aliases conflict

Hi,
This is about latest version.
I think there is a conflict between "is" ans "js_is" aliases : "js_is" is replaced by "is" then replaced again by "py_is".
In the end "js_is" is translated in "py_is" (should be "is").
By the way py_is looks like not being defined.
Here is a very dirty workaround doing the job in my case, it just breaks the loop when "is" or "js_is" :
in compiler.py file :
    def filterId (self, qualifiedId):   # Convention: only called at emission time
        if self.idFiltering:
            for aliaser in self.aliasers:
                if re.match(aliaser [1], qualifiedId) and qualifiedId in ("is", "js_is"):
                    qualifiedId = re.sub (aliaser [1], aliaser [2], qualifiedId)
                    break
                else:
                    qualifiedId = re.sub (aliaser [1], aliaser [2], qualifiedId)
        return qualifiedId

Except this minor issue, everything works fine (for now) migrating from 3.6.101 to 3.7.5. The code is even shorter. I use bundle.js as recommended to get a monolitic file (better fit my use).
Congrats for this wonderful tool.

Thanks for the feedback!
We will look into this a.s.a.p.

this pragma for 3.6.101
__pragma__ ("alias", "js_is", "is")

if S("#page").js_is(":visible"):
	print("ok")

-b -n -e 5 main.py
		if (S ('#page').is (':visible')) {
			print ('ok');
		}

-b -n -e 6 main
if (S ('#page').py_is (':visible')) {
	print ('ok');
}

The problem is caused by the fact that the following default aliases were unfortunately omitted from 3.7.101:
        ('is', 'py_is'),                        ('js_is', 'is'),

You added a custom alias, which was the right thing to do.
However it bites the default aliases that have been added in 3.7.x,
since they are applied later, hence cause cyclic replacement.
If you're only using 3.7.x, you can leave out the alias for js_is, since it is now a default alias.
The code would then just be:
__pragma__ ("alias", "S", "$")

if S("#page").js_is(":visible"):
	print("ok")

If you want it to work both in 3.6.101 and 3.7.x,
the following should do the trick:
__pragma__ ("alias", "S", "$")

# remove default alias in 3.7.x
__pragma__ ("noalias", "is", "py_is")

# this pragma for 3.6.101
__pragma__ ("alias", "js_is", "is")

if S("#page").js_is(":visible"):
	print("ok")

Feel free to reopen if there are still problems with this.
KR
Jacques


How do I input a four-dimensional tensor into Mamba2?

For example, I have a four-dimensional tensor with shape [2, 56, 56, 96], where the four dimensions correspond to batch_size, height, width, and channels. If I directly set the parameters as follows:
d_model = width * height  # This is incorrect
d_state = 64,
d_conv = `4,`
expand = 2,

and create the Mamba2 module, it results in an error:
File "/root/anaconda3/envs/test/lib/python3.10/site-packages/mamba_ssm/modules/mamba2.py", line 157, in forward
batch, seqlen, dim = u.shape
ValueError: too many values to unpack (expected 3)

Mamba's input requires the format of [batch, seq_len, dim]. You can refer to the method of Vision Transformer to transform the data of [batch, c, h, w] into [batch, dim, patch, patch] using Conv2d, and then transpose it to the shape of [batch, patch * patch, dim] for input. The above satisfies seq_len=(h / patch) ^ 2.


Fix remove during loop

This should fix #1. I ran into this problem while writing tests in ssb-browser-core for using ssb-db2.

@staltz if you have time

@staltz if you have time

BOOYAH

BOOYAH


Use  for libraries.

This seems necessary with cordova-android v7.1.0 due to the changed directory structure, otherwise some "weird" errors will occur with totally unrelated plugins. See, for example https://travis-ci.org/tkem/openlap/builds/374557900

Bump.
This needs to be merge in order to support cordova 8 and and cordova android 7.

Please fix this

Sorry for the delay. That's done, and I published a 0.0.10 version of the plugin.
Have fun


_nf at field level not working for me

You must be getting sick of me by now.
I have tried to make the _nf (no filter) at field level work, with no success.  I have, for example, set up _nf the Auto increment field called Lead Index, on a table called Leads,  But it still appears as a filter option.  _nf works fine at view level, but not at field level.  And it is the same with prod or dev version selected.   Am I doing something wrong?
Here is the field in Builder

Here is the table in the app, before I click Add filters.  Note its latest KT:L version, but dev doesnt work either.

And here is the filter popup offering this field as a filter option.

LOL!!!  Not at all, quite the opposite.  You're contributing to making the KTL better - that's all.
Now it's very strange because no matter what I try, the _nf kw never fails here.  I tried Modal for example, because they're always in for a surprise.  But no, all is good.
Can you reproduce the issue in a public page, or one with a login for me?
Norm

Norm
https://berrell.knack.com/cooldrive#leads2/
if you go here you will access public pages with 2 grid views of the LEADS table.  This is all dummy data.  On that table I have marked 2 fields Lead Index and Lead Number with _nf in their description.
The first tab "leads" has no view level _nf entry, so in theory its reliant on those field level _nf tags.  But I can still see those 2 fields as filter options.  i.e this is the issue Im reporting - the field level _nf tags appear ineffective.
The second tab provides the same view of the same table but added a view level entry _nf=Lead Index,Lead Number,Lead Reference for Display.  That view does remove those fields from filter options.
Note there are 3 fields being stripped in the view level NF - the extra one being "Lead Reference for Display".  This is important, because its a "test":   I also notice that once I have viewed the second table - the one with the view level NF setting that removes that extra field, if I return to the first page the filter restrictions from the second page are applied to it too.  I know its the view level filters because that third field is removed.   Are the view level NF setting supposed to be just for a specific view?  or they will apply to all views of that table?  Is this another separate issue?
rgds, Leigh

Leigh,
In view_338, can you add a column for the Lead Index field please?
The code needs to have that field in the table to operate properly.
You can hide it using the _hc kw, like this: _hc=Lead Index
Norm

You have an interesting use case.  It should be possible to disable filtering on a field that is not part of the grid.
I will meditate on this...
Norm

Ive added that lead Index column to both views and left it visible for now.

I also put the name for Lead Reference back to original just so its not confusing.

I see now that Lead Index has been removed from the filter options due to the _nf in the field.
So I now understand that it works, for now, only if the field is in the grid.  Which sort of does go against my use case, as Im trying to remove things that I will likely never put in the grid - things that are never for display, and are only used for doing calculations or as a component of some other formula field.

But given it works at the view level, at least there is a current solution.

Good, that confirms what I thought.
So, I'll try to come up with a solution that works even when the filter parameter is not in the view.
Stay tuned,
Norm

Ok, this time I'm pretty sure I've got it.
The problem was: If the filter is set to All fields in table, I need to retrieve the fields from the Object instead of the View.
That's how it's done now.
Can you test the dev version please?
Norm

Dev version now appears to be working perfectly for both the view and field _nf options.
From: Cortex R&D Inc. @.>
Sent: Sunday, January 21, 2024 1:06 AM
To: cortexrd/Knack-Toolkit-Library @.>
Cc: LeighBerrell @.>; Author @.>
Subject: Re: [cortexrd/Knack-Toolkit-Library] _nf at field level not working for me (Issue #202)
Ok, this time I'm pretty sure I've got it.
The problem was: If the filter is set to All fields in table, I need to retrieve the fields from the Object instead of the View.
That's how it's done now.
Can you test the dev version please?
Norm
—
Reply to this email directly, view it on GitHub https://github.com/cortexrd/Knack-Toolkit-Library/issues/202#issuecomment-1902104303 , or unsubscribe https://github.com/notifications/unsubscribe-auth/BFHL2GLYC4U6Q5TUH6J4RQDYPPFMVAVCNFSM6AAAAABCBQAE5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGEYDIMZQGM .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/BFHL2GMBBCCE26Z27CSB23LYPPFMVA5CNFSM6AAAAABCBQAE5SWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTRL7HO6.gif Message ID: @.*** @.***> >


[new module] FFT implementation sketch

Considerations:

Name of module that will not conflict to Apple’s library.
What are the rules for naming the functions?

TODO:

[x] Test cases
[x] Real to complex transform
[x] In-place implements

ref: https://github.com/SusanDoggie/Doggie/blob/master/Sources/Doggie/Accelerate/CooleyTukey.swift

Why the path Source/Accelerate/Implements? Maybe "Implementation", but neither target Complex nor Real uses this file structure.

The functions requires the Real module for sin, cos functions. I am not sure should we implement the wrapper function for the non-splitting complex buffers.
for example:
public func vDSP_fft_zop(_ log2N: Int, _ input: UnsafePointer<Complex>, _ in_stride: Int, _ in_count: Int, _ output: UnsafeMutablePointer<Complex>, _ out_stride: Int) {
    input._reboundToDouble { _input in
 output._reboundToDouble { _output  in
 vDSP_fft_zop(log2N, _input, _input.successor(), in_stride << 1, in_count, _output, _output.successor(), out_stride << 1)
 }
 }
}

All the function completed
Should we rename all the function for clarity?
Here is the function list
vDSP_fft_zrip    // Real to Complex In-place FFT
vDSP_fft_zrop    // Real to Complex Out-of-place FFT
vDSP_fft_zip    // Complex to Complex In-place FFT
vDSP_fft_zop    // Complex to Complex Out-of-place FFT

Hi Susan!
First, I'm super-excited to see this. Structurally, there are two issues to address with this PR before we get any further:

This would be a new module, so it should be pitched as an issue, and then developed on a branch so that people can experiment for a while, rather than merged straight to master.
Accelerate is an Apple SDK framework, so we wouldn't use that name in this repo (for both copyright reasons and to avoid confusion).

What I'd like you to do: raise an issue to pitch adding an "FFT" (or maybe "Transforms"--would we also have a DCT etc. eventually?) module. You don't need to put a ton of work into this right away, just a couple sentences explaining what you want to add and why. Naming and scope can be discussed on that thread.
Once that discussion happens, I'll create a branch that work can happen on. Some quick other notes, based only on skimming the source:

Please avoid copying the vDSP naming. Both to avoid confusion with the Accelerate implementation (which is also available in Swift on Apple platforms), and because they are objectively bad names, inherited from a time when characters in identifiers were precious commodities hoarded as generational wealth.

These vDSP-style interfaces simply don't import very well into Swift. You've improved them a bit, but a module should really have public interfaces that avoid UnsafeBufferPointer as much as possible without compromising performance.

Again, I'm excited to see work in this direction, so open an issue to discuss adding a module, and we'll go from there.

Hi Susan!
First, I'm super-excited to see this. Structurally, there are two issues to address with this PR before we get any further:

This would be a new module, so it should be pitched as an issue, and then developed on a branch so that people can experiment for a while, rather than merged straight to master.
Accelerate is an Apple SDK framework, so we wouldn't use that name in this repo (for both copyright reasons and to avoid confusion).

What I'd like you to do: raise an issue to pitch adding an "FFT" (or maybe "Transforms"--would we also have a DCT etc. eventually?) module. You don't need to put a ton of work into this right away, just a couple sentences explaining what you want to add and why. Naming and scope can be discussed on that thread.
Once that discussion happens, I'll create a branch that work can happen on. Some quick other notes, based only on skimming the source:

Please avoid copying the vDSP naming. Both to avoid confusion with the Accelerate implementation (which is also available in Swift on Apple platforms), and because they are objectively bad names, inherited from a time when characters in identifiers were precious commodities hoarded as generational wealth.
These vDSP-style interfaces simply don't import very well into Swift. You've improved them a bit, but a module should really have public interfaces that avoid UnsafeBufferPointer as much as possible without compromising performance.

Again, I'm excited to see work in this direction, so open an issue to discuss adding a module, and we'll go from there.

Yes, I agree that we should rename all the functions. It's a draft for now.

How big of a deal is it for the FFT functions to work on memory buffers, instead of generic (Mutable)Collection?  If the algorithms are workable with general collections, maybe we could just do that and drop the accelerate-buffer protocols.
If we switch to general collections, we could use sub-sequences to describe portions of a collection, move the power-of-2 check to see if a sub-sequence’s count has one set bit, and transition the stride parameter to using collection wrappers that automatically skip elements.  But some of these changes are likely not worth it, especially for the effort required.

How big of a deal is it for the FFT functions to work on memory buffers, instead of generic (Mutable)Collection? If the algorithms are workable with general collections, maybe we could just do that and drop the accelerate-buffer protocols.
If we switch to general collections, we could use sub-sequences to describe portions of a collection, move the power-of-2 check to see if a sub-sequence’s count has one set bit, and transition the stride parameter to using collection wrappers that automatically skip elements. But some of these changes are likely not worth it, especially for the effort required.

Here are my working examples
https://github.com/SusanDoggie/Doggie/blob/master/Sources/Doggie/ImageFilter/ImageConvolution.swift
If we given a raw pixels in this format
[red, green , blue, alpha, red, green , blue, alpha, red, green , blue, alpha, ...]
It is easy to separate the interlaced channels when you using raw pointer with stride parameter without copy
red: [red, _ , _, _, red, _ , _, _, red, _ , _, , ...]
green: [, green , _, _, _, green , _, _, _, green , _, , ...]
blue: [, _ , blue, _, _, _ , blue, _, _, _ , blue, , ...]
alpha: [, _ , _, alpha, _, _ , _, alpha, _, _ , _, alpha, ...]

It is easy to separate the interlaced channels when you using raw pointer and stride parameter without copy
red: [ red, _ , _, _, red, _ , _, _, red, _ , _, _, ... ]
green: [ _, green , _, _, _, green , _, _, _, green , _, _, ... ]
blue: [ _, _ , blue, _, _, _ , blue, _, _, _ , blue, _, ...]
alpha: [ _, _ , _, alpha, _, _ , _, alpha, _, _ , _, alpha, ... ]

This particular thing wouldn't stop you from using Collections; you could pretty easily vend a strided view of a base collection like this (just like a slice). But we don't actually want to encourage operating on strided buffers like this in general; it's a performance hazard if you provide any API that has linear complexity.

It is easy to separate the interlaced channels when you using raw pointer and stride parameter without copy
red: [ red, _ , _, _, red, _ , _, _, red, _ , _, _, ... ]
green: [ _, green , _, _, _, green , _, _, _, green , _, _, ... ]
blue: [ _, _ , blue, _, _, _ , blue, _, _, _ , blue, _, ...]
alpha: [ _, _ , _, alpha, _, _ , _, alpha, _, _ , _, alpha, ... ]

This particular thing wouldn't stop you from using Collections; you could pretty easily vend a strided view of a base collection like this (just like a slice). But we don't actually want to encourage operating on strided buffers like this in general; it's a performance hazard if you provide any API that has linear complexity.

Yes, I have tried before. that was horribly slow.


ArcGIS Server, Service Account as a domain user

Great Chef Cookbooks at: arcgis-cookbook/cookbooks/arcgis-enterprise/
Thanks.
I am having some trouble with domain user names for the "run_as_user" account for ArcGIS Server.
Everything seems to be working very well for both single or HA installation.  I could have sworn that the installation with a domain account was working fine, and noticed that "domain\username" or "domain\username" or "username@domain" or something like<EMAIL_ADDRESS>didn't apply the user name to the arcgis service.
(note: this is a Windows Active Directory domain user, running Chef Cookbook Version = 3.10)
Can someone confirm if the recipes will correctly pass a domain user name to the ArcGIS Server setup.exe?

Yes they will.  I have done it.  Make sure permissions on the server are correct

@powersparks  were you able to resolve your issue? @jsthusker what the exact permission you have set for the domain account on the server. I'm having same issue, ive tried adding account in the admin group and updating the local login as service policy w/ no luck

The domain account is in the local server admin group. Here is some documentation detailing the permissions required. https://enterprise.arcgis.com/en/server/latest/install/windows/the-arcgis-server-account.htm
As long as the account has these permissions correct it should work.

@powersparks Have you fixed this issue?

please try with latest cookbook v3.5.0 and chef client 13 or 14.


Fix operating table test fail

About the PR
Dont merge unless the test fail for OperatingTable is gone. epic piras speedmerge ops
Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

i love how you and johnstation both don't know how to reset your branches so there isn't just a perpetually increasing log of commits on every PR

i love how you and johnstation both don't know how to reset your branches so there isn't just a perpetually increasing log of commits on every PR

I learn from the worst best there is


haskell: export haskellBuildInputs

In certain cases one needs the buildInputs of a package to be available, e.g.
for constructing a hoogle database (of which the provided ghc.withHoogle is a
special case).
Example:
hoogleLocal { packages = haskellPackage.somePkg.haskellBuildInputs; }

@peti followup. :)

This feels very ad-hoc'ish. Why do we expose haskellBuildInputs but not everything else? Also, all this information is readily available from the haskellPackages package set if one just passes an appropriate mkDerivation function. I don't feel like this belongs into the generic builder.

How would you say “give me all (haskell) dependencies of $package”? It’s something I need rather often.

For example:
(haskellPackages.async.override { mkDerivation = x: x; }).libraryHaskellDepends

Oh, nice. Didn’t think about overriding mkDerivation.


recorder: handle initial/non-settings load

Resolves an issue where the recorder widget might load without having a settings file, leading to:
>
Uncaught Error: Cannot read property 'forEach' of undefined
 at line 1 col 2805 in recorder.wid.js
...Recorders();settings.record.forEach(r=>{var recorder=recorders[r...
                                  ^
in function "getActiveRecorders" called from line 1 col 4959 in recorder.wid.js
...Headers(getActiveRecorders()).join(",")){options.force="new"...
                              ^
in function "setRecording" called from line 11 col 368 in recorder.app.js
...["recorder"].setRecording(v).then(function(){loadSettings();showMai...
                                     ^
in function called from system

Thanks! And yeah I see, if you check your watch's filesystem, does recorder.json either not exist, or if it does, does the JSON within it omit a record property? If so - I have a fix: #3100

Originally posted by @bobrippling in https://github.com/espruino/BangleApps/issues/3098#issuecomment-1813325293
No and no seems to be the answer:
{"recording":false,"period":2,"record":["bat","baro","bthrm","hrmint","bthrv","hrm","gps"],"file":"recorder.log20231115g.csv"}

I'll try your fix now anyway.

Thanks for checking - I've looked at the code more closely and I believe the issue is that settings isn't actually defined/in scope (but we don't get a ReferenceError because it's likely another widget/boot code might've left the variable lying around in the global scope).
To confirm - did you see similar console output after the initial test of this PR?
And I've pushed up a change, how does it go now?

That seems to do it, thanks for working it out! :)

To confirm - did you see similar console output after the initial test of this PR?

Yes.

I'm happy to merge if you want? :)

Ah great - yes merge away :) And thanks for testing again!


Create yaml vocabulary for each input file if none given

I think this should be an extension of the Vocab class.
Create yaml vocabulary for each input file filename if none given:

search for filename.{yml,json}, if exists load as vocab.

Else:

create a frequency list for that particular file,
sort by frequency
assign id from rank
create yml representation
dump representation to filename.yml

done. Add
--create-vocabs
WIll create the files specified by -v args if they don't exist


feat: add suggestion-nas-darts rockcraft project

Part of #17
Details are in https://github.com/canonical/katib-rocks/issues/17
base on #9
Katib ROCKs are part of main epic for building secure images using ROCKs.
ROCK for Katib suggestion-nas-darts is part of katib-config.
Summary of changes:
Initial version of suggestion-nas-darts ROCK.
Manual test:
sudo docker run --rm suggestion-nas-darts:rock exec bash -c 'export PYTHONPATH="/usr/local/lib/python3.10/dist-packages/:/opt/katib:/opt/katib/pkg/apis/manager/v1beta1/python:/opt/katib/pkg/apis/manager/health/python" && python3 /opt/katib/cmd/suggestion/nas/darts/v1beta1/main.py'

Pebble service
sudo docker run --rm suggestion-nas-darts:rock exec pebble restart suggestion-nas-darts

In version v0.15.0 original Dockerfile had GRPC binary /bin/grpc_health_probe installed to respond to K8S exec health check. As I see now, in v0.16.0 this part is gone, most likely due to change in K8S probe from exec to grpc.
Should we create an issue to track this development? In particular, testing of all ROCKs with new K8S health check.

I'd say this is a different effort, we should have a synced strategy for solving the change in the binary, but I don't think this image was affected.

As discussed, no need to keep  GRPC binary from v0.15.0
Appoved.


100% pane width Images not working?

I can't get 100% pane Width to work via either CSS or settings. I've tried setting it in both Minimal Theme Settings and Style Settings. I've also turned off each of those plugins to see if that helps.
This seems like a basic issue so maybe I'm doing something wrong? Dataview tables work great now. The screenshot here is in Live Preview but it looks the same in Reader mode.

I am not sure what I am looking at in the screenshot. Can you show what it looks like rendered?
Are you using the latest version of Contextual Typography?
Note that new layout features do not support Live Preview

I was using the global settings and updated plugins. However in the middle of creating a clearer example it started working all of a sudden (without any discernible change to the note). But most other notes still don't work. I haven't been able to figure out why unfortunately, I'm going to play around with this some more in real world usage and see what happens...

I have not seen the behavior you are describing... Other possibilities that I can think of:

Interference from a snippet or plugin
If you try to run both Minimal Settings and Style Settings at the same time you can run into conflicts

Also, you may want to quit and reopen Obsidian, sometimes that is needed to fully reset your plugins.

I just created a new vault with no plugins and all default settings except for Minimal as the theme, Light mode, and Source mode as the editor. I think the issue might be related to web links? Here is a minimal case that triggers it for me consistently:

---
cssClasses: img-100
---

![](https://media.cntraveler.com/photos/59d3a805ddaded4e04772233/16:9/w_1280,c_limit/Rome_GettyImages-841851056.jpg)

I hope this helps/makes more sense!

Ah I see. Yes there is an open issue for this, see #81
This is due to a limitation of the Contextual Typography plugin, seen here:
https://github.com/mgmeyers/obsidian-contextual-typography/issues/7

Note that remote images in Markdown format should now be working as of Minimal 4.2.2 — however for local images you need to use the Wikilinks syntax

This was very helpful context but the problem actually ended up being something else. Apparently there has to be a blank line between text and the image for it to work. I couldn't find anything about this being part of the spec and I'm not sure if it's an issue with Obsidian but I'll look into it some more later today. Here's a screenshot that illustrates it:


'pew' installs but lacks dependencies

Describe the bug
Adding 'pew' to systemPackages or installing it in a user environment succeeds, but 'pew' cannot then find 'virtualenv'.
To Reproduce
Steps to reproduce the behavior:

> $nix-env -iA nixos.pew
installing 'pew-1.2.0'
building '/nix/store/170459d2ii3hxifglq9g02ppd48p8pa2-user-environment.drv'...
created 18 symlinks in user environment

> $pew new test
/nix/store/v72cj06nk69cynckz2s12rhar25k1h7v-python3-3.8.5/bin/python3.8: No module named virtualenv
Error while trying to remove the /home/vtechev/.local/share/virtualenvs/test env:
No such file or directory

Expected behavior
New Python virtual environment named 'test' created and activated.
Additional context
I'm in the process of upgrading several systems from 19.03. Encountered this issue both upgrading directly from 19.03 to 20.09, and upgrading incrementally through 19.09 and 20.03, which required me to remove 'pew' for the upgrade to 20.03. I have not tried a fresh install of 20.09.
Note that I have a nixos 19.09 channel available in the metadata below. I was able to install pew 1.1.2 using the expression from nixos 19.09 successfully.
Notify maintainers
@berdario
Metadata

system: "x86_64-linux"
host os: Linux 4.19.116, NixOS, 20.09.2642.88f00e7e12d (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.10
channels(root): "nixos-20.09.2642.88f00e7e12d, nixos-19-19.09.2522.75f4ba05c63"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:
- pew

There is an open issue which seems to be about the same problem. This open PR should add support for Python 3.8.

There is an open issue which seems to be about the same problem. This open PR should add support for Python 3.8.


Support for ukranian language in Power Accent

Description of the new feature / enhancement
Since this was done for other languages, it would be nice to add Ukrainian language support to power accent.
examples:
VK_I => [...,і,ї],
VK_E => [...,є]
VK_G => [...,ґ]
Scenario when this would be used?
using in power accent.
Comfortable keyboard input in my language.
Supporting information
No response

/dup #26801


Handle breaking changes from 2.0 via json version check

We are introducing breaking changes as part of version 2, which may cause both contracts and zos.json files from previous versions to be incompatible with the current one, and viceversa. The main breaking changes are:

Support for multiple dependencies: this affects the App contract, which is incompatible with the one from 1.x. It also changes the format of zos.json files (both local and network), since the dependencies list is now an array, and not a single stdlib entry.
New Package contract interface, for compatibility with aOS: Packages will enforce semver, and have a different interface.

Note that 2 is still not implemented, but if it is, we would need to:

[x] Add a flag to all json files from version 2.0 indicating that they belong to the new version (implemented as zosversion: '2')
[x] Release a patch of 1.4.x that checks whether that flag is present in any zos.json file (local or network, from the project or a stdlib), and if it is, aborts execution.
[x] On version 2.x (master), check that zosversion is '2' on all zos json files, and refuse to use them otherwise.

Fixed in #162 and #163


feat: change arrow icon in send flow

Try out this version of the Hiro Wallet - download extension builds.

We used different components for header in send flow, which led to different styles for header icons, this pr fixes it.

LGTM!


Not Supported [Error: Failed to bind to the service.]

In-app review could not be triggered.
Obtaining the Error: Not Supported [Error: Failed to bind to the service.]
Package Version:
"react-native-in-app-review": "^3.3.1",
Environment Info:
npx react-native info : System:
OS: macOS 13.3.1
CPU: (8) arm64 Apple M1
Memory: 113.25 MB / 8.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 18.16.0 - /opt/homebrew/opt/node@18/bin/node
Yarn: 1.22.19 - /opt/homebrew/bin/yarn
npm: 9.5.1 - /opt/homebrew/opt/node@18/bin/npm
Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.12.1 - /Users/appName/.rvm/gems/ruby-2.7.6/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.1, iOS 16.1, macOS 13.0, tvOS 16.1, watchOS 9.1
Android SDK: Not Found
IDEs:
Android Studio: 2022.2 AI-222.4459.24.2221.9971841
Xcode: 14.1/14B47b - /usr/bin/xcodebuild
Languages:
Java: 11.0.19 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: ^17.0.2 => 17.0.2
react-native: ^0.66.5 => 0.66.5
Real device or simulator? In-App Review not visible in both.
My Development OS:
For development: Mac.
For the bug: Android and iOS, both.

I am also facing this issue. This issue is coming for Android only.


Added fixed log name support

See https://code.google.com/p/google-glog/issues/detail?id=209 - this is an updated version of that patch.
It adds a flag that allows to switch behavior from base_filename + filename_extension + time_pid_string to base_filename + filename_extension, while still defaulting to the current behavior to avoid breakage in existing code. This change would allow easier log rotation schemes and better control on what's written on disk.

I signed it

Can we get this merged?

I'm reverting this PR due to CI failures. Please revise and resubmit.


parking and park sort_key vals funky

Oops, parking needs to sort above most everything else, and there were two park values.

In the landuse layer


No module named 'ibm_db_sa.ibm_db_sa' on Python3 Ubuntu 18.04

Is Python3 not officially support for the SA Db2 driver? If not, I think we should add that.
Error:
$ python3 django-test.py
Traceback (most recent call last):
  File "django-test.py", line 3, in <module>
    import ibm_db_sa.ibm_db_sa
ModuleNotFoundError: No module named 'ibm_db_sa.ibm_db_sa'

On a fresh Ubuntu 18.04 virtual machine, I did this..
sudo apt-get update
sudo apt install python-pip
sudo apt install python3-pip
sudo apt-get install python-setuptools

pip3 install ibm_db
pip3 install camelcase # as a test to ensure pip3 is working
python3 testpy3.py

Hi,
Please install ibm_db_sa and try to execute the script using import ibm_db_sa.
pip3 install ibm_db_sa.
above command will install ibm_db_sa.


SSW.Rules Widget - Add to people page

CC: @jakebayliss @bradystroud @adamcogan
Currently, we have the SSW.Rules Widget which has been developed and published to NPM.
https://github.com/SSWConsulting/SSW.Rules.Widget
Now we need to integrate this widget on the main SSW.People profile pages.

[ ] Add the rules widget to people profile pages to display the last 10 rules an employee has updated

Figure: Put the rules widget here.
AB#64298

As per my conversation with @pierssinclairssw, @christianmorfordwaitessw and @tkapa we are closing this PBI due to the following issues at present:

Rate limit concerns - Need to investigate if this is rate limiting the Org
This will need further changes once the new history.json pipeline is implemented
Add graceful error handling to the Widget - Display if we are rate limited


Refactor workflow planning

There is logic for checking whether a particular site can run a particular step in components.step_runner.JobRun._is_legal() and also in components.orchestration.WorkflowPlanner.make_plans.may_run() and also in policy.evaluation.PermissionCalculator.calculate_permissions().
That looks like it should be refactored because the code looks very similar, even though they do slightly different things:

JobRun._is_legal() checks whether we are allowed to run the steps we are asked to run, and whether the sites we are asked to download inputs from are allowed to have them,
WorkflowPlanner.make_plans() checks at which sites a given step can be executed,
PermissionCalculator.calculate_permissions() determines which assets one needs access to, to be able to run each step.

Part of the problem is that make_plans() does two things, it figures out at which site each step can run, and it enumerates plans. Splitting that up would help. I like having a function that produces a Permissions object, so I'd rather not modify calculate_permissions() to become calculate_permitted_sites(), but we can add the latter to PermissionCalculator, wrapping the former. Then make_plans() can call that and generate plans from there.
What _is_legal() does is a subset of what make_plans() does. It's a bit less efficient, but we could have it call calculate_permitted_sites() and then check the plan against that. But maybe checking plans for validity should be the job of PermissionCalculator? That class is in charge of applying policies to workflows after all, and JobRun's scope is execution. So we should move _is_legal() to PermissionCalculator.is_legal(job, plan) and just have it check the whole plan for validity, why not.

Closed by #83.