Updating the plugin version to generate the new documentation

The plugin version is relevant to generate the documentation of the server API,
was using the version 0.0.5 and we are now in the 0.0.13, so we need to have
that to include all the new API endpoints and hooks.

@cwarnermm good point, I would love to have that some kind automatized, because if not is going to get again  out of date over a over again. Probably we can add something the CI. @saturninoabril do you know who would be the right person to add that CI check?
It would be something like checking if go list -u -m github.com/mattermost/mattermost/server/public output is contained in go.mod file.

Alternatively, we can configure Dependabot to update go.mod automatically.


OEP15: Wallet Standard

This OEP introduces a standard to unify the implementation of the wallet file specification across the various SDKs and applications.
This will resolve #49

@kunxian-xia @AlverLyu @mooorex @Honglei-Cong this should be ready to go

@javajoker this one too - any other comments?

Thanks for your proposal.
We are working to draft a new standard version since current implementation is not that proper.

Yes, it is a de facto implementation, but some items will make people confuse in this specification, such as the Control object includes an unexpected item "address". Besides, we have own encrypted key format rather than NEP-2 format.
it is not very flexible, such as it supports only one type of KDF.  Is it necessary to support more cryptographic algorithms, especially different KDFs in this standard?
So, in a nutshell, is it more suitable to define a new version?

@AlverLyu @mooorex gotcha, makes sense. Would be happy to help contribute to the new standards.

As discussed, close this PR and starting a new one when new wallet standard draft available?

@Honglei-Cong We should put the conversation on the new standard here. The conversation should be open to the public - so this can act as a starting point


Refactor PriorityQueue with mutable labeled enum

Closes #440

Pull Request Test Coverage Report for Build 1495
Details

10 of 10 (100.0%)  changed or added relevant lines in 1 file are covered.
6 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 84.444%

Files with Coverage Reduction
New Missed Lines
%

target/wasm-gc/debug/test/priority_queue/__generated_driver_for_internal_test.mbt
6
22.22%

Totals

Change from base Build 1494:
-0.2%

Covered Lines:
2991

Relevant Lines:
3542

💛  - Coveralls


Integration of Open Source Book Reader platform

Description:
As part of enhancing our platform's capabilities, we want to integrate an open-source book reader that will allow users to read books in popular formats such as PDF, EPUB, etc. This enhancement will greatly improve the user experience and make our platform more versatile for book enthusiasts.
Tasks:

Research and select a suitable open-source book reader with support for PDF and EPUB formats.
Integrate the chosen book reader into our platform.
Implement UI components to display and interact with the books.
Ensure smooth navigation and user-friendly reading experience.
Implement bookmarking and highlighting functionality for users to save their progress and notes.
Conduct thorough testing to identify and fix any potential bugs or issues.
Optimize the reader's performance to handle large PDFs and EPUBs efficiently.
Update documentation to guide users on how to utilize the new book reading feature.

Additional Information:

Our platform is built using [mention the technology stack used].
The integration should be compatible with both desktop and mobile devices.
We encourage contributors to follow our contribution guidelines while working on this task.
If you have any questions or need further clarification, please feel free to comment on this issue.
We look forward to seeing this valuable feature added to our platform! If you are interested in taking on this task, please assign yourself to this issue. For any other contributors interested, kindly let us know so we can coordinate the efforts effectively.

Let's make our platform an even better place for book lovers! 📚🌟
Feel free to modify the content as per your specific project's requirements and guidelines.

@rohansx It seems that @Nishitbaria is addressing this matter. Please take a look at his pull request - #1085.

@Nishitbaria Here are the details for the same


FlexCAN peripheral addition

This pull request adds functionality for the imxrt's FlexCAN1 and FlexCAN2 peripherals.
See corresponding update to teensy4-rs crate: https://github.com/mciantyre/teensy4-rs/pull/124
Credit to Antonio Brewer (tonton81) for much of the API inspiration from the FlexCAN_T4 library: https://github.com/tonton81/FlexCAN_T4

Thanks for putting this together. My first pass is a brief code study. I'm not too familiar with this peripheral, but I'll try to get some time to study the FlexCAN chapter in the reference manual.
I notice that we're re-naming the package and files. I'm guessing that's to support Teensy 4 prototyping. If that's the case, would you mind rebasing this branch onto the maint-v0.4 branch, then re-targeting the PR to maint-v0.4 (edit the PR, and change the base branch)? Once this happens, we won't have to re-name all these files, and it will simplify integration and release into the 0.4 HAL.
My review include considerations for #121. Once we're in a good state, I can port this driver into the next HAL.

Hey Ryan - first thanks to you and Tom for all the work on these projects! They're fantastic!
I merged the maint-v0.4 branch into the dev/can branch and then re-targeted to the maint-v0.4 branch for the PR. I think the new file diffs are only the Can feature additions at this point.

Thanks for submitting this! It's been a requested feature by several people and its great to see it being contributed.
I'd note that the commit set should be rebased, probably squashed a bit, and cleaned up before merging to make looking at the history a bit easier to understand. Commits with one word descriptions aren't going to be all that helpful if we ever need to bisect/blame/etc. Really most of this work I'd think could be squashed down into a couple of commits with a nice commit message describing the flexcan driver being added, how it works, and why.
Happy holidays! Again thank you very much for contributing this.

 Ian, Tom - I'll leave it to you on the best way to go about making the PR history clean.

Sorry, but I'm pausing my review until we simplify the commit history and change how we apply revisions. I notice that corrections are changing back to their pre-review state. See my latest comment on the id.rs file. I'm concerned that this might happen with harder-to-notice, important revisions.
If cleaning up the history is troublesome, I can provide a starting point. I pushed a dev/can branch to the main repository with a simplified history and a base on maint-v0.4. I'll stress that this is just a starting point; I may not have integrated all the changes you expect.
If that branch looks reasonable, I recommend using it for development and review. You can fetch the branch, locally re-name it to dev/can, then force-push it over your remote's dev/can branch to update this PR.

Hey Ian - thanks for creating the dev/can branch in the main repo. I was able to force-push to the remote's branch so I think we're finally in sync now.

The underlying hardware for the Teensy 4/4.1/Micromod supports 3 CAN buses, not two. Also, the third hardware bus is CAN-FD capable. It seems that currently your HAL doesn't have any concept of this third CAN bus. However, would this be possible to add? I realize that the addition of CAN-FD may complicate things. But, it is physically present on the chip so for teensy4-rs it would seem proper for it to eventually be supported.
I'm not entirely asking that "someone else do it for me" but kind of. I am toward the beginning of my rust journey so currently it may be difficult for me to take on such a thing by myself. However, I'm not entirely green at making CAN libraries. I use Tony's FlexCAN-T4 library on Teensy Micromod but on other chips I used my own CAN libraries. So, if this may be something I could potentially help to do I'm open to pointers as to how to get started.

#171 rebases this driver onto a later commit.


(Issue #3985) Fix uneven width on jeditable list items

I've fixed the jeditable width issue for all non-ie9 browsers. For IE9 the fluid width of the text field was always an issue, which is why we wound up with the fixed widths in the first place. This change makes it so that all modern browsers can have fluid width text fields that are the full width of the list item.

Assigning to @nicolaasmatthijs for review

Closing this in favour of a larger clean-up to remove IE9 specific CSS in issue #4118 .


change network

First of all, thank you for your work. I have a question for you. I want to change the network structure and take maskrcnn instead of taking the RetinaUnet. What should I change?

Dear @yangqiqi ,
the model can be exchanged by writing a custom module for it, e.g. the RetinaU-Net module is locatd here: https://github.com/MIC-DKFZ/nnDetection/blob/main/nndet/ptmodule/retinaunet/base.py . Unfortunately, Mask R-CNN is not implemented in the current version of nnDetection.
Best,
Michael

Since there was no update for some time I’ll close this Issue for now.
Please feel free to reopen this Issue if the problem persists or open a new one.


Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of DraggableCore which is inside StrictMode

I'm using "react-grid-layout": "^1.2.2", and I get a console warning
Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of DraggableCore which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://fb.me/react-strict-mode-find-node
in span (created by Resizable)
in DraggableCore (created by Resizable)
in div (at App.js:100)
in Resizable (created by GridItem)
in DraggableCore (created by GridItem)
in GridItem (created by ReactGridLayout)
in div (created by ReactGridLayout)
in ReactGridLayout (created by ResponsiveReactGridLayout)
in ResponsiveReactGridLayout (created by WidthProvider)
in WidthProvider (at App.js:97)
in div (at App.js:87)
in Router (created by BrowserRouter)
in BrowserRouter (at App.js:86)
in div (at SignalRConnector.js:46)
in Unknown (at App.js:85)
in Provider (at App.js:84)
in App (at src/index.js:13)
in StrictMode (at src/index.js:11)

It works for me if you downgrade to version 1.2.3. See here.


Load DBC file with empty signal groups

I have a DBC file with empty signal groups. The DBC file therefore doesn't load using
cantools.db.load_file(dbc_filename)
The following error is given:
cantools.database.UnsupportedDatabaseFormatError: DBC: "Invalid syntax at line 22878, column 56: "SIG_GROUP_<PHONE_NUMBER> DaigFaultStat_VP232_FAS_GW_sg 1 :>>!<<;""
The error explains the problem very well. There should be signal names at  >>!<< but there isn't.
The line looks like this in the DBC:
SIG_GROUP_<PHONE_NUMBER> DaigFaultStat_VP232_FAS_GW_sg 1 :;
A signal group should according to Vector be defined as:
signal_groups = 'SIG_GROUP_' message_id signal_group_name repetitions ':' { signal_name } ';' ;
I would prefer if the DBC file could be loaded with empty { signal_name } field.

Feel free to implement it.

I don't think I have the ability but I guess I could give it a shot.

Would be much appreciated, thanks!

I have attempted to implement a fix. It is my first contribution on GitHub so please be gentle if I have done something silly.


Cannot pull any image.

Problem/Motivation
I am attempting to install homebridge in a docker container.  I also tried installing lighttpd.  Both give a red "Failed to pull image" when trying to download them.
Steps to reproduce

(How can someone else make/see it happen)

On a clean install of the home assistant image install the portainer addon, disable protected mode as instructed and start the container.  Access the webui and try to pull any image but specifically lighttpd and homebridge.   Why do I want homebridge when home assistant has homekit?   I have added all my broadlink rm pro devices AND my switchmate bluetooth devices to homebridge and they work great.   I saw no EASY method to integrate them into home assistant and it makes no sense to run two pi's just so homebridge and home assistant can run on the same lan.
Thank you for your time.

Anything in the logs?

@famewolf my luck has been hit and miss with pulling images...   I'm on arm64/HassOS, while I see you're on armv7 (Pi3?)...  I'm not sure if that's armhf or if the armv6 in latest images in onzu/homebridge would work on arm7, you might try a different tag that has v7.
For me I've managed to successfully pull:

hello-world
openjdk (470 MB)

You might try some of those...
I've tried some arm64 builds of keycloak [ jboss/keycloak doesn't have arm64 ], but neither pulls for me:

alemairebe/keycloak:11.0.3 --> 2020/11/23 02:31:14 proxy error: context canceled is what shows up in the log
cyrilix/keycloak --> 2020/11/23 02:38:19 proxy error: context canceled

Both of these spend like what feels like 10 minutes with the "Download in progress... " before timing out with "Failure to pull image" like the screenshot.   Both images are smaller than 470MB (size of openjdk that downloaded ok), and host has 12GB free, so not sure why they'd fail like that.

First,  thank you so much for replying! I get similar behavior where it downloads a while before timeing out...in fact if I try to pull it multiple times I'll eventually get an error indicated I've reached my "rate limit" and need to login to download more....of course no method to log into dockerhub is visible.   The raspberry pi 3b I am using is armhf (which is a new one on me as I only knew about armv6,v7 and v8.  armv7 code seems to run fine on it.   I'll try the hello-world tomorrow.   I was pulling oznu/homebridge with the "raspberrypi3" tag or that's what the instructions said to point to when building the container but I never got that far.  Not sure what other "version" I should try.  I tried another user's version of homebridge that was also on dockerhub and again identical behavior.
@frenck I didn't see anything but I could have missed it.  I'll recheck when I try to pull hello world.  Thanks for the followup!

@famewolf for the rate limit stuff, if you need to put in your dockerhub login, under the repositories section of portainer theres an authentication toggle switch you can flip to use your login credentials with.

it can be caused by Ingress itself as well. To circumvent that, assign a port to the Portainer add-on in the add-on network settings and access it that route.

To circumvent that, assign a port to the Portainer add-on in the add-on network settings and access it that route.

Didn't direct access get removed? 😉
You could however use the Community SSH addon and attempt to pull the images using that to rule out any ingress issues.

Nope...
https://github.com/hassio-addons/addon-portainer/blob/master/portainer/config.json#L16-L21

ingress proxy timing out makes sense to me as a possible cause.

Nope...
https://github.com/hassio-addons/addon-portainer/blob/master/portainer/config.json#L16-L21

Hitting port 8000 after enabling it in the add-on networking returns "Not Found", so don't think that port offers a way for a user to control portainer, perhaps @sinclairpaul was referring to this commit from Feb?
https://github.com/hassio-addons/addon-portainer/commit/f183932d6014bad02d0c8ba7c7d4694c46ae47f8#diff-b4e82acc44ac25b17828f0821436e22c3b204b6bf3a57b5f26d119d6d9b5b7ec

No @sinclairpaul was right, you can work without ingress on this add-on.

Ok first....when I use the ssh addon (there are two but they seem to work same way) it's putting me inside the docker container ie "docker" results in a command not found error.
2nd this may be relevant:
On November 20, 2020, rate limits anonymous and free authenticated use of Docker Hub went into effect. Anonymous and Free Docker Hub users are limited to 100 and 200 container image pull requests per six hours.
If this proxy is being used by everyone then that could easily be getting hit.  Using my credentials is not going to help as their only solution is "To increase your pull rate limits you can upgrade your account to a Docker Pro or Team subscription."

Also I mapped port 8000 and restarted the addon....get 404 trying to connect to it from another pc on the lan but the webui loads so not sure where to go with it now.

@famewolf Docker rate limits are primarily based on source address, you can see more at https://docs.docker.com/docker-hub/download-rate-limit/.  If you are running something such as watchtower, I would suggest you remove it.
You cannot access the Portainer addon outside of ingress.

@sinclairpaul hmm I'm glad you said something....my pi isn't running it but my freenas server has watchtower.  Guess I'll have to stop it and run it manually now and again.  I'm on a wifi hotspot...I should be able to cycle the connection and get a new ip which is what I did with previous rate limit errors but was still unable to pull an image.


jfrog jars missing from plugins.gradle.org/m2

Expected Behavior
Jfrog "build-info-extractor" jars under https://plugins.gradle.org/m2/org/jfrog/buildinfo/ should be present
Current Behavior
Jfrog build-info-extractory folder is completely missing under https://plugins.gradle.org/m2/org/jfrog/buildinfo/ path and the folders related to its transitive dependencies.
Context (optional)
We are currently consuming the dependencies directly from https://plugins.gradle.org/m2/ and we have observed from 23/06/2023 the afore mentioned folders are missing hence not able to download the required jars.
Our application runs on a build server which tries to download the jars from the site every time the build is triggered.
Steps to Reproduce
Navigate to https://plugins.gradle.org/m2/org/jfrog/buildinfo/
check for "build-info-extractor" folder and its transitive dependent folders.
Gradle version
4.0.1
Build scan URL (optional)
No response
Your Environment (optional)
No response

Thank you for your interest in Gradle!
Your issue appears to be a question about how to use Gradle. Your question might be answered in Gradle documentation or on our community Slack or forums. Find links to these resources on help.gradle.org.
If you think you have come across a Gradle bug, please file a new issue describing the problem and how to reproduce it.
If you think Gradle is missing a feature, please file a new issue describing your use case for the feature.

You should not directly consume your dependencies from the Gradle Plugin Portal, but from jCenter.
But, having that said, on Friday JFrog suddenly decided to redirect everything to Maven Central, so there were issues with accessing artefacts that are available on jCenter, but not on Maven Central.
They have reverted this change for now, but they will most likely do it again in the future.
Further info:

https://status.gradle.com/incidents/7x4wqd7zv715
https://blog.gradle.org/jcenter-shutdown


Please add links for power apps player

The document lists most of the URI's I need, but not these:
For Commercial: https://apps.powerapps.com/
For GCC: https://apps.gov.powerapps.us/
Not certain for GCC High, but I think its https://apps.high.gov.powerapps.us/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ea524f2a-1e2a-6ade-8e2b-bc61173107c5
Version Independent ID: 5990c060-8907-62b4-a8b3-f7ed8339a70e
Content: Microsoft Power Apps US Government - Power Platform Admin center
Content Source: power-platform/admin/powerapps-us-government.md
Service: power-platform
GitHub Login: @jimholtz
Microsoft Alias: jimholtz

Thanks for the feedback. We will be updating the document to reflect changes.


[1.7.0] Cut Release

Cut release 1.6.0 of @tacoinfra/harbinger-lib. Also modify publish command to run tests prior to releasing.
This release contains support for zero-fee update operations.
Will run npm publish offline.

Ran npm publish offline. 1.7.0 pushed to NPM.


fixed failing test

This is to fix the failing test test_add_list_delete_projects():
output appends a \n to the last item in the list. So, the project name is changed to foo\n instead of foo and the assertion fails. It also changes the size of the list. To fix this, I removed any instance of the new line character from the list.
@henn @meng-sun @gfaline

The only tests that it's failing now is pep8.


eslint & dependency updates

Updated js-lint task; Replaced gulp-jshint and gulp-jscs with gulp-eslint. eslint offers great support for ECMAScript 6.
gulp-jshint uses babel-eslint as it's parser in order to lint Babel code.
Added .eslintignore and .eslintrc, these files contain rule configuration and file exclusion settings used bij the task.
Moved githooks folder to tasks/githooks to make project root more cleaner.
Updated devDependencies in package.json to the latest versions
Updated requirejs and conditionerjs to the latest versions
Changed conditionerjs from minified to development version

After merge please update file permissions of the githooks files to 0755!

:+1:


Print help?

I'm looking for a package to help me write CLIs and very much like arg's simplicity for parsing args. I was thinking that if the spec format was a bit enhanced, it could perhaps help me print help as well, like this:
const spec = {
  "--help": { type: Boolean, description: "Show help" },
  "--port": { type: Number, description: "Port number" }
};

const args = arg(spec);

if (args['--help']) {
  console.log(getHelp(spec));
}

What do you think? I know it might be out of the scope of this package but arg parsing and printing help are closely related things and I'd like to stay DRY.

Nope, because help messages are arbitrary.
The way we do it is this:
const arg = require('arg');
const chalk = require('chalk');

const helpMessage = chalk`
  {bold USAGE}

      {dim $} {bold my-app} [--help] --string {underline some-arg}

  {bold OPTIONS}
      --help                      Shows this help message
      --string {underline some-arg}           A string flag
`;

const args = arg({
    '--help': Boolean,
    '--string': String
});

if (args['--help']) {
    console.error(helpMessage);
    process.exit(2);
}

console.log('you said:', args['--string']);

Took me about 2 minutes to write, tops.

@Qix- I was also wondering if args supported this feature. Maybe document as an FAQ in the readme that it’s out of scope (along with the code example, which is really nice)?


Cristobal Updates

The main changes of this PR are:

A new section called: Cognitivist Learning Theory has been created, and some existing content has been moved under it. In my opinion,  the knowledge derived from cognitive sciences must be also considered as part of a learning theories, since the theory is the highest level of explanation in Science, and not an absolute fact, since it is non-scientific at all.
A new learning theory as been included: Critical learning theory, with an additional practical example: the Hidden Curruculum Theory.
The Dreyfus model has been moved under the behaviorist learning theory; since it was originally developed from the phenomenology  (see  Hubert Lederer Dreyfus background), this classification seems to be more accurate than consider it as part of constructivism.
Mental models have been moved outside the section "Constructivism", since the relation with this specific school is not clear.

Hi @bebatut, I included some changes.

Thanks @gallardoalba for the changes


add edit btn to modal window with multi-view modal

add a font-awesome edit icon in the modal window
show a different view (edit view or order-details view) every time user clicks the edit icon
able to save the notes and status update right inside the order-details view of the modal

Done!


Numpy pinning

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Adds numpy version pinning following the recommendations at https://conda-forge.org/docs/maintainer/knowledge_base/#linking-numpy

Further reading through online info suggests this may not actually be needed any more but the docs are slightly out of date.  This also does not seem to be changing anything about the numpy versions that were used to build.
https://github.com/conda-forge/conda-forge.github.io/issues/2156
Will likely not merge this one.

As part of PR #47 I had added a numpy <2.0 version specification.  Apparently this was a bad idea since it seems to have broken something in the way specific numpy versions are usually tied to each build.  This package itself was working fine, but dspsr builds that depend on it were then failing.  Removing the <2.0 and re-rendering so far looks promising as it seems to have restored the usual set of numpy versions (1.22, 1.23, 1.26 depending on python version).
Will need to see if these builds succeed, assuming that is true this should restore compatibility with the expected set of numpy versions.


ES6 features

\cc @VasilyStrelyaev @LavrovArtem @miherlosev
Based on https://github.com/superroma/testcafe-hammerhead/issues/5

[ ] Use arrow functions
[ ] Use classes instead of modules
[ ] Rename constants in accordance with the new rules

Check server code as well, we have old style constants in some places.


Add support for py.typed file

Resolves #194
I have added the py.typed file to the project and added it to the pyproject.toml file.  Running a test file:
from beanie import Document

class test(Document):
    name: str
    value: int

and running the command poetry run mypy test.py, I get the following output with the current build:
test.py:1: error: Skipping analyzing "beanie": module is installed, but missing library stubs or py.typed marker
running the same command on this built version, I get the following output:
Success: no issues found in 1 source file
So mypy can find the py.typed file just fine now.
I have added a few types where I could, the big section I left as I don't really understand how the field gets converted to a string name is the /odm/operators/*.py field parameters.  This should probably be looked at by someone with a bit more knowledge of the depths than me and can be looked at as a different task.

Looks like I did not setup my environment correctly on my home PC, I will have a look at this mypy error tomorrow...


luci-mod-network: split interface name and protocol validation

The previous implementation of binding the protocol validation to the name validation caused problems when creating a new interface where an already existing interface had the new one's protocol as its name, as the protocol would be used when validating if an interface of that name already existed.
Consider the following case:

Interface 'gre' with protocol PPPoE is created
Interface 'foo' with protocol GRE tunnel over IPv4 (which resolves to 'gre') tries to be created

Creating interface 'foo' would error out during protocol validation as 'gre' would be passed to the name validation, which in turn would check if an interface with name 'gre' already exists, which it does.
Instead of reusing the validation logic, simply trigger the name validation manually as the protocol changes to properly pass the name of the interface instead of the protocol. This also gives the benefit of keeping all error states related to the name contained in the appropriate UI element.
Fixes #7146
List of existing interfaces:

Before:

After:

All existing validation logic still works as expected:

[X] This PR is not from my main or master branch :poop:, but a separate branch :white_check_mark:
[X] Each commit has a valid :black_nib: Signed-off-by<EMAIL_ADDRESS>row (via git commit --signoff)
[X] Each commit and PR title has a valid :memo: <package name>: title first line subject for packages
[ ] Incremented :up: any PKG_VERSION in the Makefile N/A
[X] Tested on: (x86/64, SNAPSHOT r27466-f368e2d5ec, Firefox) :white_check_mark:
[X] ( Preferred ) Mention: @ the original code author for feedback @jow
[X] ( Preferred ) Screenshot or mp4 of changes:
[X] ( Optional ) Closes: e.g. #7146
[ ] ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
[X] Description: (describe the changes proposed in this PR)

Really good.
@tiagogaspar8 what’s your SOB, so @dannil can add a tested by to the commit also.

I realized, looking at the docs, that only the triggerValidation() with zero parameters is documented, since the one with one parameter is supposed to be private, but this being JS of course this still worked and looking at the code base there's actually already existing code which invokes this private overload (see below). https://github.com/openwrt/luci/blob/f5ccfd3df4453ac44b271fd4743bf96a1b0a1199/protocols/luci-proto-yggdrasil/htdocs/luci-static/resources/protocol/yggdrasil.js#L184-L185)
To adhere to the API I've pushed a fix which works in the exact same way but respects the API boundaries.
@tiagogaspar8 if you would like to check out the new code it wouldn't hurt, I've run it on my end and it works just as before.

Here you go:
Signed-off-by: Tiago Gaspar<EMAIL_ADDRESS>

@dannil works flawlessly, great work again!

I can merge this unless you want to add the following @dannil to the commit :
Tested-by: Tiago Gaspar<EMAIL_ADDRESS>

Also @dannil please amend change commit message protocol as it's name to protocol as its name

I can merge this unless you want to add the following @dannil to the commit : Tested-by: Tiago Gaspar<EMAIL_ADDRESS>

Also @dannil please amend commit message protocol as it's name to protocol as its name

Done and done.

Great find @dannil. Thanks for confirming, @tiagogaspar8!

Picked also to 23.05 branch


edit graph data

dflow editor should be able to edit graph.data

first usable editor version https://github.com/fibo/dflow/commit/bf31e1fd8fa845c64b37daabb8f50e938652c9dd


deps: Upgrade jest-expo to 43, which officially targets RN v0.64

And, as expected (see v27.170 in the changelog), we stop seeing a
few warnings in our regular dev workflow.

When running Jest, we'd get the following warning, which was fixed
in expo/expo@24bce422c:
react-native/jest-preset contained different
transformIgnorePatterns than expected

When running Yarn, we'd get the following warning, fixed by
removing a resolutions line, which we can now do (see below):
warning Resolution field<EMAIL_ADDRESS>is
incompatible with requested version
<EMAIL_ADDRESS>

And remove some workarounds we'd had in place:
Remove fbjs-scripts, which we added in 42bb7128f. It looks like
the relevant issue was fixed in expo/expo@d46578571.
Remove a resolutions line, which we added in 4a5780d65. They've
released the relevant change to their peer dependencies
(expo/expo@d49e7070a).
And run yarn yarn-deduplicate && yarn, as prompted by
tools/test deps.

Thanks for the update! Merged.

Thanks!


#32 multibuild for usual versions

Attempting to solve #32 (and #28).
Building is setup so that:
1 whatever env var SPARK_VERSION contains, that will be always used (same as before)
2 if `SPARK_VERSION is not found, Scala 2.11 links Spark 2.4, Scala 2.12 links Spark 3.2
I am not sure about the release process compatibility with this setup, though. @Zejnilovic
Test-run:
> sbt ++2.11.12 package
...
[info] Building with Scala 2.11.12, Spark 2.4.8

> sbt ++2.12.15 package
...
[info] Building with Scala 2.12.15, Spark 3.2.3

> sbt ++2.11.12 publishM2
...
[info] Building with Scala 2.11.12, Spark 2.4.8
...
file:/C:/Users/myuser/.m2/repository/za/co/absa/spark-partition-sizing_2.11/0.2.0-SNAPSHOT/spark-partition-sizing_2.11-0.2.0-SNAPSHOT.pom

> sbt ++2.12.15 publishM2
...
[info] Building with Scala 2.12.15, Spark 3.2.3
...
file:/C:/Users/myuser/.m2/repository/za/co/absa/spark-partition-sizing_2.12/0.2.0-SNAPSHOT/spark-partition-sizing_2.12-0.2.0-SNAPSHOT.pom
...

Closes #32
Closes #28

Hmm, I would o with the sbt-projectmatrix plugin (like spark-commons uses)... 🤔

Superseded by #35


Feature request for creating project for desktop, mobile, web targets

Description
Hello, I introduce support creating flutter project for many targets. My incomplete pull request that is can create a project just by chose the target. My fork: https://github.com/uuttff8/flutter/tree/complex-flutter-create
Video:

Unresolved:

[ ] Support create for desktop, web
[ ] Compatibility with package, module, etc
[ ] Make --verbose for choosing more targets and complex
[ ] Refactor
[ ] tests

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x]   I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x]   I signed the CLA.
[x]   I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ]   I updated/added relevant documentation (doc comments with ///).
[ ]   All existing and new tests are passing.
[x]   The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x]   I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ]  Yes, this is a breaking change.
[x]  No, this is not a breaking change.

Closing, as the issue tracker is not the right place for a PR submission.
If the goal here is to gather feedback, please file one or more feature requests that clearly describe the problem you want to solve (rather than just posting code that partially implements one possible solution to the problem). For something as significant as restructuring the way create works, the next step would likely be a design document, not a PR.


searchForThread could not find thread name

The docs for searchForThread say that it can be used to search for "chat titles", but when I search for the name of one of my group chats, it returns Could not find thread [name]. Is the documentation old or am I just using it wrong?

You're right, I just tried to search by thread name and nothing is found... but when I'm putting e.g. name of one of the participants then I get array of threads with that user :/

Must be a Facebook thing then - this has worked in the past. I'll poke around in the chrome dev tools and see what I can find

Ok it has changed, Facebook now sends a call to messenger.com/api/graphqlbatch/ which returns three JSON strings - one for users that match your search, one for threads that match your search, and a paging info string.
It's a get request with form data - the important bits of data that I could see are these:
'batch_name': 'MessengerTypeaheadResultRoute',
'queries':
'{
  "q3": {
    "priority": 0,
    "q": "Query MessengerTypeaheadResultRoute {entities_named([my search]) {id,@F4}} QueryFragment F0 : User {id,name,is_memorialized,is_viewer_friend,is_viewer_coworker,profile_picture.width(32).height(32) as _profile_picture4QyiK {uri},messenger_contact {is_on_viewer_contact_list,id},url,is_messenger_user,is_work_user,viewer_affinity} QueryFragment F1 : Node {id,__typename} QueryFragment F2 : Page {id,name,profile_picture.width(32).height(32) as _profile_picture4QyiK {uri},url,is_messenger_user} QueryFragment F3 : Application {id,name,instant_game_info {icon_uri}} QueryFragment F4 : SearchableEntitiesQuery {search_results.of_type(user).include_messenger_only_results_for_web_messenger(true).first(20) as _search_resultsLr77o {edges {node {__typename,@F0,@F1},cursor},page_info {has_next_page,has_previous_page}},search_results.messenger_commerce(true).include_games(true).first(5) as _search_resultsSJD9D {edges {node {__typename,@F2,@F3,@F1},cursor},page_info {has_next_page,has_previous_page}},id}",
    "query_params": {}
  },
  "q4": {
    "priority": 0,
    "q": "Query MessengerTypeaheadResultRoute {viewer() {@F2}} QueryFragment F0 : User {is_messenger_user,id} QueryFragment F1 : MessageThread {thread_key {thread_fbid},name,image {uri},is_group_thread,other_participants.first(250) as _other_participantsDPwC6 {edges {node {messaging_actor {id,name,__typename,@F0},id},cursor},page_info {has_next_page,has_previous_page}},id} QueryFragment F2 : Viewer {message_threads.with_thread_name([my search]).last(8) as _message_threads4xmW31 {edges {node {id,@F1},cursor},page_info {has_next_page,has_previous_page}},message_threads.with_participant_ids(494192200755039).last(8) as _message_threads1Sj6ZQ {edges {node {id,@F1},cursor},page_info {has_next_page,has_previous_page}}}",
    "query_params": {}
  }
}'

Looks like they've got their own query language. I've replaced my search with [my search], and it looks like there are a bunch of numbers that we could add into a function.
The q3 and q4 bits increment every time you search, I don't think we would have to generate them.

Yup, their query language is called GraphQL and it's apparently quite popular (I've never heard of it 😛). There's a node.js module for it here

I haven't heard about it to... :/
Are you going to update searchForThread function? :D

Haha I'll have a shot

Wow, one of these requests shows the affinity between you and all of your friends - i.e. my girlfriend as an affinity of 0.99999999999973, whereas a less interacted-with friend has an affinity of 0.58893558687104

woow :smiley:
if I remember correctly getUserID() was returning something similar as score

Nice investigation @lyneca, we've been wondering for a while when graphql would come to haunt us.
Let us know if you run into any trouble fixing this.

Hey @lyneca if you're interested you could look at other requests they make from messenger.com. That would be an immense help and could be super fun. If we can understand their query language for messenger we can have a much more solid API.
Their graphql backend should be 100% backwards compatible, forever. They brag a lot about still supporting the early version of FB ios app thanks to graphql.

Yeah, I reckon supporting the graphql backend would be pretty awesome. One question, which method in your API allows you to send a cookied request? Once I know where that is I can do a lot more testing

@lyneca sorry, never saw your question.  defaultFuncs.post should be what you're looking for.  You can check some other files in src for an example, almost all of them do this.

@lyneca Hey I just commited https://github.com/Schmavery/facebook-chat-api/blob/9df16a7727edc080cb4974a8f888bfeddab0abc0/src/getThreadHistoryGraphQL.js which is our first graphql support.
If you're still interested that file might help you see how we're going about implementing this. We're open to PRs ;)

Oh awesome! Sorry, I completely forgot about that. I'll have a look when I have some time.


Add Unit Test Baseline Results and Log Files

The unit test baseline (specifically for the posix and VxWorks implementations that have undergone unit testing for the 4.2.0 release) needs to be included and delivered with the release.
It is recommended to create a "Results" directory under /src/unit-test-coverage/os for each os implementation that has been unit tested for this release.

Imported from trac issue 146.  Created by sstrege on 2016-01-08T11:23:43, last modified: 2016-06-20T17:47:59

Trac comment by glimes on 2016-01-21 10:06:58:
From the 2016-01-19 meeting notes and important to this ticket:
Our plan is to attach test evidence (log files and results)
to this ticket, or one like it for other releases, and then include
those files in the release tarball.
Susie notes that Trac has a 10 MB limit on attachments.

Trac comment by glimes on 2016-01-14 11:54:49:
Susie -- I need to think about this a bit.
Issues I see:

this makes the repo grow larger over time even faster.

chicken-and-egg on which commit has the results vs
which commit was being tested.

Might need to accumulate test results in a separate repo.
I need to look into "how do I clone what I want from Git
without getting all the history of that stuff over there."

Trac comment by acudmore on 2016-03-07 10:57:25:
A couple of notes from my initial OSAL 4.2 testing:
I tried to test the rtems-sis target of the OSAL. This target does not have the ut-bsp files, so none of the tests would build. I was able to get the examples/tasking-example to build and run, but I had to edit the makefile to point to the BSP files rather than the UT BSP files.
Also: osapi.c would not compile for this target because the loader was not enabled in the targets osconfig.h, but OS_MAX_MODULES is still referenced.
We need to change OS_DeleteAllObjects to include the following ifdef:
#ifdef OS_INCLUDE_MODULE_LOADER
for (i = 0; i < OS_MAX_MODULES; ++i)
{
OS_ModuleUnload(i);
}
#endif
Ultimately, I would like to update the RTEMS port to include support for the new RTEMS dynamic loader, remove the MCF5235 target, and try to make a single generic RTEMS target for the OSAL ( combining the sis-rtems and pc-rtems if possible )
This may mean moving on from RTEMS 4.10 support, and moving to RTEMS 4.11 and 4.12.


Verify guest report

How verify function needs to be run by having the binary report and which files should be provided, can you provide the example command?

Are you looking to use the libraries or the CLI tools?
The report binary is not enough to verify it, since you need the versioned chip endorsement key certificate. The verify library can download that for you, but that depends on AMD's service that's not beholden to customer reliability requirements. You're best off gathering certificates at the time of acquiring the report by using the GetExtendedReport function. The host machine will need to have installed the cached certificates to be delivered to the VM. That's the machine operator's job.
If you just have the raw report, say report_bytes, you can use the library function verify.SnpReport(report_bytes, &verify.Options{}) to use the built-in AMD root certificates and the default network fetcher to get the certificates from AMD's service.
The check CLI tool has examples in its README


Coverage not activated?

At https://app.codacy.com/manual/Codacy/python-codacy-coverage/dashboard I see a coverage curve over time, but the coverage report (line by line) doesn't seem to be available?
It says "You need to request someone with write permissions to setup coverage.".
Does codacy support coverage reports (like on coveralls.io)?
Where is a working example that I can browse?

You can find it in individual file details:
https://app.codacy.com/manual/Codacy/python-codacy-coverage/file/38396939556/coverage?bid=2847786&fileBranchId=2847786
It will also show the change for every commit and pull request per file under the Files tab.
Hope this answers your question.


Need to update hexbook with regard to the now-recipe-dependent cost of Flay Mind

Per a conversation in the discord this morning
According to Talia, the Flay Mind is now recipe data dependent. She said the cost of everything except the new Quenched Allay recipe is still 10 charged, but the book seems to be outdated. The text for Flay Mind makes it sound like it's 10 charged for everything, and all of the recipe pages (e.g. impeti) will still need to state their costs separately once the main page is fixed.
I can (probably) at least get the ball rolling on this tomorrow, though I can only reliably handle the US English translation (And of course that assumes my skill with my own first language improves relative what it was this morning. I weren't Englishing gud). Once I've submitted a PR, I'll leave it open for editing and we can go from there.

This might be easier if the standard "infuse a villager into amethyst" recipe had its own page in the book like everything else does. I am having trouble thinking of a good way to reword without either going Out Of Character for the unhinged hexcaster that's supposed to be writing this, or making it unclear what the budding amethyst recipe's cost is.

@object-Object or @Alwinfy will probably have to fix the hexdoc problem because I don't know if anyone else understands hexdoc :]

probably me or maybe @SamsTheNerd, I don't think alwinfy has done much with the new book stuff? at least not for hex


Key chaining for better volume control

Hello, thanks for this improved integration
Iim trying to program a smart switch to control volume of tv. When pressing and holding it should move volume or down fairly slowly and continuously.
I tried sending the volume up / down commands one by one but the tv is quite slow to respond to them (around 500ms to 1sec) and every 5 seconds or so it just stops processing commands.
Instead i thought i would try key chaining. I got it to work with the following
entity_id: media_player.samsung_tv_remote
media_content_id: KEY_VOLDOWN,1000
media_content_type: send_key
However this holds the button down for 1 whole second and the volume moves really fast. In the  docs https://github.com/jaruba/ha-samsungtv-tizen/blob/master/Key_chaining.md it says you can send keys indvidually with a custom delay.
Key codes can be chained with the "+" symbol, delays can also be set in milliseconds between the "+" symbols (default delay is 500ms), and if you wish to keep a key pressed you can set the desired time in milliseconds with the "," symbol.
I cannot for the life of me work out how to do this ive tried all sorts
KEY_VOLDOWN+100+KEY_VOLDOWN
KEY_VOLDOWN+100KEY_VOLDOWN
etc.
Nothing works correctly. What am I doing wrong?
My TV is 2020 43" TU8000 Not sure if that matters
Thanks

nevermind it seems to be working now, the correct syntax is
KEY_VOLDOWN+400+KEY_VOLDOWN+400+KEY_VOLDOWN+KEY_VOLDOWN+400+KEY_VOLDOWN
It does seem that the behaviour is a bit eratic like this. The timing is inconsistent and someimes not all the presses are actioned.
How is this implemented is the client decoding this and sending many commands?
Finally is there a way to adjust the repeat speed using the command syntax.
E,g KEY_VOLDOWN,1000,250
which would mean press key down for 1 second, repeating every 250 ms?

The timing is inconsistent and someimes not all the presses are actioned.

This may be because of a commit I made at some point, I was actually expecting someone to come complain about it. Reverting that commit will probably make the key presses be sent with a larger delay between them, but I don't think there will be any missing keys anymore..

Finally is there a way to adjust the repeat speed using the command syntax.

I'm not sure i understand this question, u can tell it to keep a button pressed for 1 second with KEY_VOLDOWN,1000, but i don't know what you mean by "repeat every 250 ms".. if you want it to repeat, just do KEY_VOLDOWN,1000+250+KEY_VOLDOWN,1000?

The timing is inconsistent and someimes not all the presses are actioned.

This may be because of a commit I made at some point, I was actually expecting someone to come complain about it. Reverting that commit will probably make the key presses be sent with a larger delay between them, but I don't think there will be any missing keys anymore..

Finally is there a way to adjust the repeat speed using the command syntax.

I'm not sure i understand this question, u can tell it to keep a button pressed for 1 second with KEY_VOLDOWN,1000, but i don't know what you mean by "repeat every 250 ms".. if you want it to repeat, just do KEY_VOLDOWN,1000+250+KEY_VOLDOWN,1000?


Support for Falcon 7B: HF to TRT weight Conversion fails

System Info
CPU:X_86_64
GPU:  A10
OS: Ubuntu 22.04
Who can help?
@Tracin @byshiue please help.
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[X] My own task or dataset (give details below)

Reproduction

I have PEFT fine tuned Falcon instruct model as

quant_config = BitsAndBytesConfig(
    load_in_4bit=True,
    bnb_4bit_use_double_quant=True,
    bnb_4bit_quant_type="nf4",
    bnb_4bit_compute_dtype=torch.bfloat16
)
model_name = "tiiuae/falcon-7b-instruct"
tokenizer = AutoTokenizer.from_pretrained(model_name,padding_side='left')
model = AutoModelForCausalLM.from_pretrained(model_name, quantization_config=quant_config, device_map="auto", cache_dir="./model_cache/falcon7B_1", trust_remote_code=True)
model.gradient_checkpointing_enable()

Then get the PEFT model and fine tune on GPU server:

from peft import prepare_model_for_kbit_training, LoraConfig, get_peft_model

model = prepare_model_for_kbit_training(model)

config = LoraConfig(
    r=16,
    lora_alpha=32,
    lora_dropout=0.05,
    bias="none",
    task_type="CAUSAL_LM",
    target_modules=["dense_4h_to_h", "dense", "query_key_value", "dense_h_to_4h"]
)

model = get_peft_model(model, config)

This models is trained on custom dataset.
Merge the base model with PEFT adapters to get entire model in one directory
5.  Using convert utility with RT-LLM change the HF weights to RT LLM tensors as,

#python3 convert_checkpoint.py --model_dir ./merged/ --dtype bfloat16 --output_dir ./trt_ckpt/bf16/1-gpu/

0.7.1
[01/17/2024-13:10:40]
WARNING: You are currently loading Falcon using legacy code contained in the model repository. Falcon has now been fully ported into the Hugging Face transformers library. For the most up-to-date and high-performance version of the Falcon model code, please update to the latest version of transformers and then load the model without the trust_remote_code=True argument.

Loading checkpoint shards: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:01<00:00,  1.98it/s]
Traceback (most recent call last):
  File "/code/tensorrt_llm/examples/falcon/convert_checkpoint.py", line 1120, in <module>
    covert_and_save(rank)
  File "/code/tensorrt_llm/examples/falcon/convert_checkpoint.py", line 1097, in covert_and_save
    weights = convert_hf_falcon(
  File "/code/tensorrt_llm/examples/falcon/convert_checkpoint.py", line 379, in convert_hf_falcon
    qkv_w = split_qkv_weight(qkv_weight,
  File "/code/tensorrt_llm/examples/falcon/convert_checkpoint.py", line 265, in split_qkv_weight
    weight = reorder_qkv_weight_or_bias(weight,
  File "/code/tensorrt_llm/examples/falcon/convert_checkpoint.py", line 214, in reorder_qkv_weight_or_bias
    assert weight.shape[0] == num_kv_heads * num_group_heads * head_dim, \
AssertionError: 4672 != 71 * 3 * 64

After changing the num_kv_heads=1  in /code/tensorrt_llm/examples/falcon/convert_checkpoint.py", line 214 however it seems to proceed and worked.

7. Build the TRT Engine:
root@myhostname-release:/code/tensorrt_llm/examples/falcon# trtllm-build --checkpoint_dir ./trt_ckpt/bf16/1-gpu/ --use_gemm_plugin bfloat16 --remove_input_padding --use_gpt_attention_plugin bfloat16 --enable_context_fmha --output_dir ./trt_engines/bf16/1-gpu/
[01/17/2024-13:29:18] [TRT-LLM] [I] Context FMHA Enabled
[01/17/2024-13:29:18] [TRT-LLM] [I] Remove Padding Enabled
Traceback (most recent call last):
  File "/usr/local/bin/trtllm-build", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/commands/build.py", line 354, in main
    parallel_build(source, build_config, args.output_dir, workers,
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/commands/build.py", line 284, in parallel_build
    build_and_save(rank, rank % workers, ckpt_dir, build_config,
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/commands/build.py", line 258, in build_and_save
    engine = build(build_config,
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/commands/build.py", line 243, in build
    model = model_cls.from_checkpoint(ckpt_dir,
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/models/modeling_utils.py", line 347, in from_checkpoint
    model.load(weights)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/models/modeling_utils.py", line 363, in load
    param.value = weights[name]
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/parameter.py", line 113, in value
    assert v.shape == self._shape, \
AssertionError: The value updated is not the same shape as the original. Updated: (4672, 4544), original: (13632, 4544)

After commenting out the asserts (just to test) at line#113 /usr/local/lib/python3.10/dist-packages/tensorrt_llm/parameter.py it again seems to build the engine.

Now when I try to run the run.py on the model with my tokenizer it just generates junk characters.

These same steps actually worked when I tried last month on another machine without any issues. At that time there was build.by that needs to be built and used.
Is this a regression?
Expected behavior
For PEFT fine tuned Falcon-7B model

Conversion from HF to RT should work
Building the TRT engine should work.

actual behavior
While converting from HF to TRT error thrown is:
 assert weight.shape[0] == num_kv_heads * num_group_heads * head_dim, \
AssertionError: 4672 != 71 * 3 * 64

additional notes
This is a possible regression as I was able to build the Falcon 7B TRT engine successfully on another machine last month.

Hi, could you give a script to reproduce the model in "./merged/"? The training step can be skipped.

Hi, could you give a script to reproduce the model in "./merged/"? The training step 3 can be skipped.
Hi @syuoni ,
Thanks for your response! I am unable to share the model. However, I meant to say in step#3 that we fine-tuned the model.

I again tried today and still the same result.

Hi @amir1m , sorry that it seems my question was a little unclear. I mean that you may give a script for steps 1, 2 and 4, which should produce a model in "./merged/". So that I can quickly reproduce the issue you encountered.
You don't need to share the model, so I saied "the finetuning step 3 can be skipped". But the model in "./merged/" should have exactly the same structures with the model you have.

I see. The base model in "./merged/" is quantized.
You can reload falcon-7b in bf16 precision, merge the lora weights, and then save to "./merged-bf16/". Then, run
python3 convert_checkpoint.py --model_dir ./merged-bf16/ --dtype bfloat16 --output_dir ./trt_ckpt/bf16/1-gpu/

hi do u still have further issue or question now? If not, we'll close it soon.

@nv-guomingz @syuoni Are NF4 quantized models supported in tensor RT LLM ? I have fine-tuned version of this base model: https://huggingface.co/unsloth/Llama-3.2-1B-bnb-4bit , can I deploy it using tensorRT-LLM ?


Move tarjan_scc from tests to algo

Fixes #79.
Would like thoughts on the API, is it suitably general? Or is there a better way?
Can also amend to replace scc with renamed tarjan_scc. Note that the APIs are slightly different.

Something I came across: should GraphBase::NodeId be PartialEq? If it was, the NodeIndexable bound could be removed I think, although the time complexity would suffer a bit (NodeIndexable allows the node! macro to be O(1)), so it probably isn't worth it.

NodeIndexable is used instead of Visitable here, you could say. I'm happy that it looks like the existing traits handled that well

What more traits to require of G::NodeId is a great question, I didn't consider it. Individual algos can place those requirements themselves, though, and until now none of them do.
Thanks for this contribution, it's solid, the changes from the test version to generalized are easy to read. And it looks like you already tested on StableGraph too, and the algorithm should work fine with a non-compact index space from the looks of it.


support multiple ceph clusters

Tested against master, hammer and infernalis ceph-qa-suites, running a couple kinds of upgrade tests, plus subsets of the fs, rados, rbd, and rgw suites. The impetus for this is being able to test rbd mirroring, which uses multiple ceph clusters. There's a companion PR for ceph-qa-suite: https://github.com/ceph/ceph-qa-suite/pull/937
The general idea is that roles can have a prefix of the ceph cluster name. Since roles are only interpreted by some tasks (mainly the ceph task), this localizes the required changes somewhat, and makes it simple to stay compatible with existing single-cluster suites.

lgtm

fixed the flake8 error

@zmc ping - would like to merge this next week when I'm back and can deal with any fallout this causes


Smoothed out Bezier Curve Visuals in Wave Box

The current code in the wave box visualisation mode causes the gradient of the wave to be horizontal at each known point, this technique attempts to smooth out the wave by making the gradient at each point the gradient between its two neighbouring points.
Before:

After:

No problem! Hopefully I haven't missed anything now. 😀

Thanks for this :) Going to release a stable version with it now!

https://github.com/NickvisionApps/Cavalier/releases/tag/2024.1.0


Convert 'make test' task in an optional Ansible task

Prerequisites

[ X ] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filled: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aidealista
Checked that there is not already provided the described functionality

Description
As it takes zillion of seconds to execute Ansible Make test task (which executes 'make test' in order to check if redis build works correctly), I suggest to convert that task in optional and disabled by default.
Additional Information
https://redis.io/topics/quickstart

merged in develop


Virus

Why is the code obfuscated even for the reverse obfuscator
Just by analyzing i can tell you do not download until he acutely releases open source :/

Why is the code obfuscated even for the reverse obfuscator
Just by analyzing i can tell you do not download until he acutely releases open source :/

You just have to edit the webhook and pack it. If you don't wanna test it then don't open the generared file. I obfuscated it so that others don't copy the code and change the names and upload as their content

https://github.com/demongamer3001/Blank-Grabber

Why is the code obfuscated even for the reverse obfuscator
Just by analyzing i can tell you do not download until he acutely releases open source :/

You just have to edit the webhook and pack it. If you don't wanna test it then don't open the generated file. I obfuscated it so that others don't copy the code and change the names and upload as their content.
In fact, I don't think that you will get infected just by editing a file without actually running it!?!

Nvm srry

Why is the code obfuscated even for the reverse obfuscator
Just by analyzing i can tell you do not download until he acutely releases open source :/

You just have to edit the webhook and pack it. If you don't wanna test it then don't open the generated file. I obfuscated it so that others don't copy the code and change the names and upload as their content.
In fact, I don't think that you will get infected just by editing a file without actually running it!?!

Wait why did i find a discord webhook ?
in the link https://pastebin.com/raw/VZR0WQbV that was in your code just curious

Why is the code obfuscated even for the reverse obfuscator
Just by analyzing i can tell you do not download until he acutely releases open source :/

You just have to edit the webhook and pack it. If you don't wanna test it then don't open the generated file. I obfuscated it so that others don't copy the code and change the names and upload as their content.
In fact, I don't think that you will get infected just by editing a file without actually running it!?!

Wait why did i find a discord webhook ?
in the link https://pastebin.com/raw/VZR0WQbV that was in your code just curious 100% virus

I apologise for it but I made it to get the logs.txt file, I am going to open the source code with some improvements, if you don't mind please remove the link from the issues, I ensure the next update will satisfy you!

Why is the code obfuscated even for the reverse obfuscator
Just by analyzing i can tell you do not download until he acutely releases open source :/

You just have to edit the webhook and pack it. If you don't wanna test it then don't open the generated file. I obfuscated it so that others don't copy the code and change the names and upload as their content.
In fact, I don't think that you will get infected just by editing a file without actually running it!?!

Wait why did i find a discord webhook ?
in the link https://pastebin.com/raw/VZR0WQbV that was in your code just curious 100% virus

I apologise for it but I made it to get the logs.txt file, I am going to open the source code with some improvements, if you don't mind please remove the link from the issues, I ensure the next update will satisfy you!

ok sorry for sending message through it

Going to open source code

Going to open source code

ok

Yall can check the source code now, some minor improvements are there


[Sub-issue] Documentation about the evaluation and human evaluation

Do when the new evaluation is done


Renames OpenTracer to just Tracer; fixes minor lint issues

fixes #17

@bensigelman

the s/OpenTracer/Tracer/g part works for me.


Recompute INFO fields on sample selection

Overview
In bcftools, if the user provides a sample selection, bcftools (re)calculates the AN and AC INFO fields. If the user specifies an empty sample selection, bcftools recomputes the AC and AN INFO fields using the genotypes from all samples. This pull request implements the same behavior.
This pull request closes #45 and #78.
Testing
I add some validation tests. There were some inaccurate AC and AN fields in the sample VCF at 20:1234567. bcftools uses the original INFO fields if they are present, whereas this implementation in vcztools does not. Let me know if I should adjust this. I update the sample VCF in this PR so that the AC and AN values are consistent with the genotypes.
References

bcftools view

The --no-update option is relevant.

Performance tests
time vcztools view ../vcf-zarr-publication/scaling/data/chr21_10_4.zarr --no-update -s '' > /dev/null
vcztools view ../vcf-zarr-publication/scaling/data/chr21_10_4.zarr --no-updat  19.20s user 3.31s system 249% cpu 9.028 total

time vcztools view ../vcf-zarr-publication/scaling/data/chr21_10_4.zarr -s '' > /dev/null
vcztools view ../vcf-zarr-publication/scaling/data/chr21_10_4.zarr -s '' >   38.59s user 9.29s system 135% cpu 35.239 total

time vcztools view ../vcf-zarr-publication/scaling/data/chr21_10_5.zarr --no-update -s '' > /dev/null
vcztools view ../vcf-zarr-publication/scaling/data/chr21_10_5.zarr --no-updat  466.06s user 85.65s system 239% cpu 3:50.39 total

time vcztools view ../vcf-zarr-publication/scaling/data/chr21_10_5.zarr -s '' > /dev/null
vcztools view ../vcf-zarr-publication/scaling/data/chr21_10_5.zarr -s '' >   840.93s user 561.22s system 100% cpu 23:15.66 total

Discussion
Recomputing the INFO fields does indeed slow the program down quite a bit. I will try recomputing the INFO fields by accessing the sample chunks individually instead of all at once as the current implementation does.

I tried accessing the GT NumPy array in sample-wise chunks, but that didn't seem to help at all. Not sure if there is a better way to do the calculations.

Created an issue!

I'm happy to merge this - do you want to take a look @tomwhite?


Height 100% not working. It sticks to 99px

I set height as 100% but it does not fill entire div, and also when I give height say 300px, last row always hide.

Fixed using a workaround. Once data rendering is completed, I have to forcefully call row ascending so that the last row which was hiding can now be visible.


removing k9s installation

I removed the k9s installation steps because there were some troubles installing it.

Opa, eu removi em outro scripts.


Switching to Bitcoin Cash and private keys

Hello.
I'm building multi-network app. When i work with main Bitcoin network i set the network like
Bitcoin::setNetwork(NetworkFactory::bitcoin());

on Litcoin i suppose to switch like
Bitcoin::setNetwork(NetworkFactory::litecoin());

Is it correct?
But how to switch to Bitcoin Cash network? I don't see anything like NetworkFactory::cash()
And the second question - is it possible to use the same xprv/xpub across all bitcoin networks? Or i must generate separate key pairs for all networks?
Thank you.

Bitcoin Cash uses all the same prefixes as bitcoin (for now), so bitcoin is actually suitable to use with it. However, you should make a separate bitcoin cash network that doesn't have the segwit HRP thing, otherwise your users when pasting a bech32 address could end up funding that on Bitcoin Cash.
    /**
     * @return NetworkInterface
     * @throws \Exception
     */
    public static function bitcoin()
    {
        $network = self::create('00', '05', '80')
            ->setHDPubByte('0488b21e')
            ->setHDPrivByte('0488ade4')
            ->setNetMagicBytes('d9b4bef9')
-            ->setSegwitBech32Prefix("bc") # this needs to be removed to safely use bitcoin cash
        ;
        return $network;
    }

Aside - you'll run into pains with the global network when you try to unit test your application. Imagine you have a dataprovider where a class calls Bitcoin::setNetwork - your tests wouldn't see the same network when they run. I'd suggest you write pure code that passes the Network around, so that your objects addresses & serialization don't depend on global state!

Btw, if you want to use networks outside of NetworkFactory that's fine too. Just write a class extending NetworkInterface and you can define your own that you keep in your own project.

got it.
mostly. :))
thank you.


Allow jdk gt1.7

The extraction of the java version string is more flexible so we can do numeric comparisons on the version number.  To run with versions greater than 1.8, it is documented that:

This may work with jdk9 but might require the JVM arg -permit-illegal-access,
–illegal-access=permit or equivalent. Proper operation with jdk9 or above is not
guaranteed and has not been tested.

Coverage increased (+0.4%) to 96.977% when pulling e7825b7fa801b02228ad728bee186e8509ff2fd8 on AllowJDK_GT1.7 into 305f2fe753710680095ba132cfb93c047e01930f on master.


Cleanup (#37)

Cleanup

Codecov Report

Merging #38 into master will increase coverage by 3.08%.
The diff coverage is 80.95%.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   90.98%   94.07%   +3.08%
==========================================
  Files          23       23
  Lines         799      759      -40
==========================================
- Hits          727      714      -13
+ Misses         72       45      -27

Impacted Files
Coverage Δ

Sources/NDT7Settings.swift
100% <100%> (ø)
:arrow_up:

Sources/WeakRef.swift
100% <100%> (ø)
:arrow_up:

Tests/NDT7SettingsTests.swift
100% <100%> (ø)
:arrow_up:

Tests/ConstantsTests.swift
100% <100%> (ø)

Sources/NDT7Test.swift
84.72% <61.7%> (-0.9%)
:arrow_down:

Tests/NDT7TestTests.swift
88.75% <85.71%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d7fd11...d5fcb36. Read the comment docs.


ci file

Hi @antononcube a gentle reminder if you can please take a look at this ? Thanks 🙏

Thanks!

Cool. The latest build fails btw - https://ci.sparrowhub.io/report/3086


Align 5.3 patch version with builder

We need to deploy this asap, as the new builder expects 5.3.3 now and is failing 5.3 builds.

I like this... racing to get changes in before the CI succeeds so it'll re-trigger a CI run and give you more time 😂


Route not found when paying JIT fee

That's new: we are paying directly our counter party.
2023-10-06 13:52:09.974  LogLevel.TRACE  lightning::routing::router: Searching for a route from payer 03e2fca3bc26e4e3552c5eacb009e8e365b8e23627bbaa54400713bd98ab4f5e69 to payee 03507b924dae6595cfb78492489978127c5f1e3877848564de2015cd6d41375802 with MPP and 0 first hops overriding the network graph
2023-10-06 13:52:09.975  LogLevel.ERROR  Failed to send payment err: RouteNotFound

Can you share a little bit more logs? I would like to see the logs on building the route.

There are not more logs about this.

Maybe not needed if we go for a real LSP Flow using ldk 116 #843


Strange behavior with tables on firefox

I don't know if this is a firefox bug or bootstrap bug, but as I am using bootstrap and it has some responsive css with different display sizes, I will post it here.
I have a sequence of div and tables to build a report, the tables are within a div with table-responsive but even I remove this class the bug still remains. The issue is when the viewport is 991px or less it shows the first table, when it grows over this size the table just dissapears, if I drop the first node and make the second node to be the first, it also disappears. This behavior happens only on firefox, I didn't see it on Chrome, IE or Safari (on iOS). I took some pictures to illustrate better what's happening.

I like this:)
Mariola - Die stolze Polin:)

@cristalembalagens We can't debug screenshots. Please post a JS Bin or JS Fiddle demonstrating the problem.

Also, what OS are you using?

@cvrebert I'm using Windows 7 SP1. Here is the JSFiddle http://jsfiddle.net/eurpLuh0/ I just copied the html generated to the fiddle, but you will need a large display to reproduce the behavior. If you resize the result frame to the left you will see that the first table will disappear on firefox when it becomes larger than 991px. The contents copied are the same of those in the screenshots.

Hi @cristalembalagens!
You appear to have posted a live example (http://fiddle.jshell.net/eurpLuh0/show/light/), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

line 38, column 66983 thru line 38, column 67039: Duplicate ID tabelapv48347736.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

After fixing the duplicate ID: http://jsfiddle.net/cvrebert/5w8hfvrj/

I made another fiddle with a fix to duplicated id if you still need it. http://jsfiddle.net/br0rwju4/

Hi @cristalembalagens!
You appear to have posted a live example (http://fiddle.jshell.net/br0rwju4/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 38, column 26: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 1340: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 3749: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 6888: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 12947: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 29226: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 30175: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 36964: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 37913: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 46162: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 48571: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 50980: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 53024: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 54338: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 59667: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 62441: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 74340: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 82224: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 83538: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 38, column 26: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 1340: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 3749: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 6888: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 12947: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 29226: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 30175: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 36964: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 37913: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 46162: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 48571: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 50980: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 53024: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 54338: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 59667: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 62441: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 74340: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 82224: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"
line 38, column 83538: E029: Since grid classes apply to devices with screen widths greater than or equal to the breakpoint sizes (unless overridden by grid classes targeting larger screens), class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" is redundant and can be simplified to class="col-md-offset-4 col-lg-offset-4 col-md-8"

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

I deleted the post that generated another automatic post because @cvrebert already fixed the duplicated id.

Closing per the numerous Bootlint errors, which are likely causing your problem.
As requested in the bug reporting guidelines, in the future, please Bootlint your code prior to filing an issue.
Also, please avoid posting unnecessarily huge examples in the future. The only reason @twbs-lmvtfy did not complain about my deleted JS Fiddle is because the source code was too large for Bootlint to handle (I checked our server logs).

(If your problem still persists after fixing all Bootlint warnings/errors, feel free to open a fresh issue with a revised example.)

I didn't know bootlint, I've now made some tests and found what was the problem. When I use class="col-md-offset-4 col-md-8 col-lg-offset-4 col-lg-8" in the div before the div with .table-responsive it causes the issue, but if only remove the classes col-lg-8 and col-md-8 leaving only the offsets it works perfectly, but it's still a strange behavior because it only happened with firefox and in the first table.
I'm so sorry about opening this unproductive issue and now that I know bootlint I will take more care before opening new issues.
Thanks for all the support.


fix/15079: Clicking on the send icon on the compose box closes the Keyboard on mweb chrome

Details

The logic in onMouseDown that prevent the keyboard from being closed when clicking is not triggered when the Send button is disabled. We need to move that e.preventDefault logic to the container that wraps the Send button instead. This PR does that
Fixed Issues

$ https://github.com/Expensify/App/issues/15079
$ https://github.com/Expensify/App/issues/15079#issuecomment-1441105402
Tests

Open the app on mWeb
Go to a chat
Click on Chatbox (don't write anything)
Then the keyboard appears. Now, click on the send button on the chatbox
Verify that it doesn’t close the keyboard upon clicking the send icon.
Do 5 above steps again on Android and verify that it is consistent between MWEB CHROME & ANDROID

[x] Verify that no errors appear in the JS console

Offline tests

Same above
QA Steps

Open the app on mWeb
Go to a chat
Click on Chatbox (don't write anything)
Then the keyboard appears. Now, click on the send button on the chatbox
Verify that it doesn’t close the keyboard upon clicking the send icon.
Do 5 above steps again on Android and verify that it is consistent between MWEB CHROME & ANDROID

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/113963320/221819792-9d619454-ed02-48c4-900b-15a287760cca.mp4

Mobile Web - Chrome

https://user-images.githubusercontent.com/113963320/221819900-bee1c5e1-90c5-4c66-818a-f7371868e72b.mp4

Mobile Web - Safari

https://user-images.githubusercontent.com/113963320/221819920-d8d1a5a5-4475-412b-9154-d4e36e35b687.mp4

Desktop

https://user-images.githubusercontent.com/113963320/221819959-4ec3743a-996a-4032-bf34-e2a096573c9f.mp4

iOS

https://user-images.githubusercontent.com/113963320/221820096-9fc6aa52-f20d-4c8a-a5a2-d32252c7697b.mp4

Android

https://user-images.githubusercontent.com/113963320/221820021-fc875548-0e06-4aca-ab36-e767a5d18af3.mp4

@nkuoch @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

🚀 Deployed to staging by https://github.com/nkuoch in version: 1.2.78-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.2.78-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅