1.13 --> 1.14 user gw upgrade issues when autoscaleEnabled is true and .k8s.replicaCount is nonzero

Bug Description
1.13 user gateway is deployed by using istioctl with autoscaleEnabled is true and .k8s.replicaCount as 4, four gw pods are created and hpa takes care of gw scaling as per scaling rules
1.14 istioctl creates deployment without replicas when autoscaleEnabled is true, this is as per the changes but this behaviour involves downtime. As soon as 1.14 deployment objects are applied, replicas are removed, that makes replicas as default 1, k8 terminates three 1.13 pods at a same time which causes downtime because only 1 gateway keeps running for few seconds until 1.14 pods start
Version
$ istioctl version
client version: 1.14.1
istiod version: 1.13.5
istiod version: 1.14.1
data plane version: 1.14.3 (4 proxies)

$ k version --short
Flag --short has been deprecated, and will be removed in the future. The --short output will become the default.
Client Version: v1.24.3
Kustomize Version: v4.5.4
Server Version: v1.21.11

Additional Information
how to reproduce:
download gateway-config.zip which has 1.13 and 1.14 gateway override files.
deploy 1.13 user gw (adjust revision and discoveryAddress to match correct control plane):
$ ~/tmp/istio-1.13.2/bin/istioctl manifest generate -f gw_1.13.yaml | k apply -f -

# deploys 4 pods as expected with hpa

$ k get po,hpa
NAME                           READY   STATUS    RESTARTS   AGE
pod/test-gw-564644b76b-9sgks   1/1     Running   0          23s
pod/test-gw-564644b76b-fr4kl   1/1     Running   0          23s
pod/test-gw-564644b76b-ns5rf   1/1     Running   0          23s
pod/test-gw-564644b76b-qvfrb   1/1     Running   0          23s

NAME                                          REFERENCE            TARGETS         MINPODS   MAXPODS   REPLICAS   AGE
horizontalpodautoscaler.autoscaling/test-gw   Deployment/test-gw   <unknown>/80%   4         5         4          23s

upgrade user gw to 1.14 (adjust revision and discoveryAddress to match correct control plane):
$ ~/tmp/istio-1.14.3/bin/istioctl manifest generate -f gw_1.14.yaml | k apply -f -
k get pocomponents.ingressGateways[name=test-gw].k8s.replicaCount should not be set when values.gateways.istio-ingressgateway.autoscaleEnabled is true
serviceaccount/test-gw-service-account configured
deployment.apps/test-gw configured
Warning: policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
poddisruptionbudget.policy/test-gw configured
role.rbac.authorization.k8s.io/test-gw-sds configured
rolebinding.rbac.authorization.k8s.io/test-gw-sds configured
horizontalpodautoscaler.autoscaling/test-gw configured
service/test-gw configured

##### >>>>>>> replicas became 1 so 3 out of old 4 pods start terminating at same time
$ k get po
NAME                       READY   STATUS              RESTARTS   AGE
test-gw-564644b76b-9sgks   1/1     Terminating         0          62s
test-gw-564644b76b-fr4kl   1/1     Terminating         0          62s
test-gw-564644b76b-ns5rf   1/1     Running             0          62s
test-gw-564644b76b-qvfrb   1/1     Terminating         0          62s
test-gw-6657f58f7-w4g6x    0/1     ContainerCreating   0          0s

hpa increases 1.14 replicas to 4 as per the config
$ k get po
NAME                      READY   STATUS    RESTARTS   AGE
test-gw-6657f58f7-hklnr   1/1     Running   0          86s
test-gw-6657f58f7-p2kwv   1/1     Running   0          86s
test-gw-6657f58f7-sgstj   1/1     Running   0          86s
test-gw-6657f58f7-w4g6x   1/1     Running   0          99s

The reason of the changes was introduced to reset replicaCount when autoscaling is enabled. This change makes sense because we don't want the ReplicaSet controller and HPA controller to be fighting each other which align with how Kubernetes should work
You can find documentation that explicitly explain this behavior here: Horizontal Pod Autoscaling
So, what means that to you who uses replicaCount? You must migrate your deployment from using replicas to HPA controller
Here is how you should do it:
Edit the current deployment which has revision 1.13.5 This is a manual process to prevent the object at the server side be updated.
Run the following command:
kubectl apply edit-last-applied deployment/test-gw
Remove the replicas field and save it at this point the pods are still unchanged
On your gw-operator file with revision 1.14.1 remove the replicasCount field and then upgrade the gateway deployment
istioctl manifest generate -f gw_1.14.yaml | k apply -f -
Since the current deployment is already managed by the HPA controller this will allow you to upgrade the pods with the desire behavior and all the gw-pods will be running until the new ones are ready
This is a single migration task for any new release in the future there is no need to perform these steps, but the replicasCount should not be added to the manifest anymore


Special characters in world name cause crash on world load

OTG Plugin or Mod
[Please specify if it's about Forge Mod or Spigot server Plugin placing "x" into []]

[x] OTG Mod for Forge
[ ] OTG Plugin for Spigot

OTG Version
[Please specify the full OTG version that you are running by placing "x" into []]

[ ] 1.12.2_v8_r1
[ ] 1.12.2_v7_DEV_r26
[ ] 1.12.2-v6
[ ] 1.12.2-v5
[ ] 1.11.2-v8
[ ] 1.11.2-v9
[ ] 1.10.2-v21
[x] Other - 1.12.2-v9.3 (and a v8 version, issue is the same before and after updating)

What other plugins are you running?
A slightly modified version of the modpack UfoCraft 4 (found on curseforge) with a couple extra mods. According to the error and its solution, they are unrelated.
Description
When certain (non UTF-8?) special characters (specifically these characters in my case: じゃない) are in the world name, the game crashes on world load. This is caused by a YAML exception when reading [world name]/OpenTerrainGenerator/Config.yaml due to the world name doing something like producing invalid UTF-8. My guess is that these characters aren't in UTF-8 and when creating the YAML file, it tries to use it anyways.
Editing the YAML file so that it no longer contains these characters resolves the issue as far as I can tell, although an unrelated issue caused by a different mod is still preventing world loading in a later step.
What did you expect?
I expected the world to load
MRE:
Create a world with a name containing the example characters (or other similar characters) generated via OTG. Save and exit the world, then attempt to reload it. It may be the case that you have to restart minecraft for the crash, but this is unlikely.

Hey @MechaFinch , thanks for reporting this. It's a know issue, via the OTG world creation screen we prevent invalid input when creating worlds, and only allow simple characters/names. Preset creators make sure to name their presets appropriately. It's a legacy code thing, the world/preset names are used for some lookups. For 1.12.2 we've decided not to fix it and focus on 1.16 instead. For the other, unrelated issue with mods+OTG you're having, join us on the Discord as there are more users who can help. Thanks and cheers.


Protected field with same name in two classes messing up type constraint when narrowing array.

Bug Report
(I'm not even sure how to properly name that issue 🙃 )
🔎 Search Terms
typescript inheritance protected intersection
🕗 Version & Regression Information
Seen it recently in 4.6.2. Update to 4.7.3 without changing the behaviour (and 4.8.0 nightly in the playground). I don't know if it was here before.

I was unable to test this on prior versions because this triggered with unrelated change elsewhere in my code

⏯ Playground Link
Playground link with relevant code
💻 Code
class Foo {
  protected foo = 0;
}

class Bar {
  protected foo = 0;
}

type Nothing<V extends Foo> = void;

type Broken<V extends Array<Foo | Bar>> = {
  readonly [P in keyof V]: V[P] extends Foo ? Nothing<V[P]> : never;
};

🙁 Actual behavior
(error located at the V[P] in Nothing<V[P]>)
 Type 'Foo & V[P]' does not satisfy the constraint 'Foo'.
  Property 'foo' is missing in type 'Foo & V[P]' but required in type 'Foo'.

Changing foo from protected to public in either Foo or Bar makes the error disappear.
Removing (or renaming) protected foo = 0 from either Foo or Bar makes the error disappear.
Replacing the Array<Foo | Bar> in Broken by Array<Foo> makes the error disappear.
🙂 Expected behavior
Since V[P] is already in a type guard that is the same as the constraint for Nothing, this should not generate any typing error.

Workaround
type Broken<V extends Array<Foo | Bar>> = {
  readonly [P in keyof V]: V[P] extends (infer T extends Foo) ? Nothing<T> : never;
};

Thanks. Workaround works fine in the real code too 😄

It seems that the workaround breaks api-extractor 😢

@typescript-bot bisect good v4.6.4 bad v4.7.4

Hey this is the second bisect today that blames #48837 😅


Add an example of the ReAct pattern

I had trouble trying to get this working, but I must've just not provided enough examples. Here's the llama.cpp example!
https://github.com/ggerganov/llama.cpp/commit/a6956b25a1c783e5e96fe06c9c00438f846ef047
Should be as simple as adding that to examples/.

What is the ReAct pattern? Are you trying to create a sentient A.I.? 😄
I have to say though, I do like very much that Alpaca-30B has a personal opinion compared to ChatGPT. It feels more natural than the neutrality constantly provided by GPT-x.

Check out https://til.simonwillison.net/llms/python-react-pattern for more details :)

Wow. That is amazing. So when will we have Bing-like web searching capabilities in llama-rs? 😄
Anyway, keep up the good work, my friend.

hello


fix retry_interval: set it to 1 second instead of 1000 seconds

This looks like it was a typo introduced in https://github.com/Azure/azure-sdk-for-python/pull/5785#pullrequestreview-247892247
The review comment makes me think the author meant 1 second, but maybe thought it was milliseconds.
This retry_interval is fed to time.sleep and asyncio.sleep
Both these methods' arguments are in seconds
in #14067 we are experiencing timeouts after ~15 to 16 min (matching 1000 seconds) that are not solved by configuring timeouts in the client

/azp run python - core - ci

This looks unrelated to the issue I linked, I don't know where this code is used but it wouldn't hurt to fix it anyway

@vbarbaresi  Good catch and thanks for your contribution. :)


MWPW-135674 Set Modal Width & Height

Adding functionality to allow authors to set width and height on modals.
Resolves: MWPW-135674
Test URLs:

Before: https://main--milo--adobecom.hlx.page/?martech=off
After: https://mwpw-135674--milo--adobecom.hlx.page/?martech=off

I don't want to minimize how much work I think this will be, but I think this is the better authoring answer...

Semi-related nit: "dimensions" sounds clumsy to me.

I still think predefined styles are the better way, though. I think pushing this onto authors is going to create a lot of inconsistency in UX.

closing. this will allow for way too many variations of the modal


Zigbee light does not update state with zha

Home Assistant release with the issue:
0.90.0
Last working Home Assistant release (if known):
0.89.0
Operating environment (Hass.io/Docker/Windows/etc.):
Hass.io
Component/platform:
zha
Description of problem:
Soon after the update to 0.90.0, the state of the zigbee lights, in my case hue lights, do not change after a service call to turn off or turn on the light. For example, after a reboot one of my light is 'on' and after light.turn_off, the state remains 'on' even if the light itself turned off
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:

I think this is already fixed for 0.90.1 via #22222 but @dmulcahey can probably weigh in more confidently than I could.

Yep. The fix for this is already merged and will be in .90.1

I assume this is for all ZHA Lights, my Cree act the same way.

Yep, it’s a silly error on my part. Bulbs that report after commands (EX: sengled) hid the issue from me. Sorry for the inconvenience

Fixed in .90.1


translate_job_event_handler.py > event["Records"] doesn't exist?

Hello,
I am very new to AWS so my apologies if this is just a lack of knowledge on my part.
I actually ran into 2 issues, but the other ones seems to be more on the Transcribe side of things so I've posted that here.  It looks like it messes up the parser when these start at 0.
the other issue in the lambda_handler of translate_job_event_handler.py is failing at the "event['Records'][0]['Sns']['Message']" request.  The event structure seems to looks a bit different and I am wondering if the "Records" attributes still exist or if I need to adjust a setting to ensure it is included.
Message from cloud watch:
[INFO]	##### #### event: {'version': '0', 'id': '#####', 'detail-type': 'Translate TextTranslationJob State Change', 'source': 'aws.translate', 'account': '######', 'time': '#######', 'region': 'us-east-1', 'resources': [], 'detail': {'jobId': '#####', 'jobStatus': 'COMPLETED'}}

[ERROR] KeyError: 'Records'
Traceback (most recent call last):
  File "/var/task/translate_job_event_handler.py", line 88, in lambda_handler
    message = json.loads(event['Records'][0]['Sns']['Message'])

Thank you!

I'm having the same issue and trying to figure out to how to resolve it. Looks like the handler still expects to receive notifications from SNS, which was replaced by Eventbridge in the last commit.

How to use eventbridge notify job infomation? I'm just see event notify
{
"detail-type": ["Translate TextTranslationJob State Change"],
"source": ["aws.translate"]
}

ok! I fix SNS bug!
Code is here:
def lambda_handler(event, context):
logger.setLevel(logging.DEBUG)
request = {}
statusCode = "200"
message ="success"
request["delete_captionsin"] = os.environ["DELETE_INTERMEDIATE_FILES"]
try:
message = event
_jobId = message['detail']['jobId']
request["jobId"] = _jobId
status = message['detail']['jobStatus']
request["accountId"] = message['account']
# context.invoked_function_arn.split(":")[4]
translate_client = AwsHelper().getClient('translate')
response = translate_client.describe_text_translation_job(
JobId = _jobId
)
# logger.debug(">>>response: {}".format(response))
request["jobName"] = response['TextTranslationJobProperties']['JobName']
request["s3uri"] = response['TextTranslationJobProperties']['InputDataConfig']['S3Uri']
request["langCode"] = response['TextTranslationJobProperties']['TargetLanguageCodes']
if status == "COMPLETED":
processRequest(request)
# logger.debug(">>>request: {}".format(request))
elif status in ["FAILED", "COMPLETED_WITH_ERROR"]:
statusCode ="500"
message = "Translation Job failed"
logger.warn("Job ID {} failed or completed with errors, exiting".format(request["jobId"]))
except ValueError:
statusCode ="500"
message = "Error converting the XML document"
logger.error("Error occured loading the json from event:{}".format(event))
return {
"statusCode": statusCode,
"body": json.dumps(message)
}


Adding delimiter between the hash data components.

Issue #, if available:
#191
Description of changes:
Adding a delimiter between the hash components as best practice.
Description of how you validated changes:
make pr
Checklist:

[x] Write/update tests
[x] make pr passes
[ ] Update documentation
[ ] Verify transformed template deploys and application functions as expected
[ ] Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1060 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1060      +/-   ##
===========================================
+ Coverage    94.92%   94.93%   +<.01%
===========================================
  Files           69       69
  Lines         3253     3255       +2
  Branches       633      633
===========================================
+ Hits          3088     3090       +2
  Misses          87       87
  Partials        78       78

Impacted Files
Coverage Δ

samtranslator/model/apigateway.py
97.79% <100%> (+0.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df24a3...6da5e80. Read the comment docs.


Clarify Index behaviour

Surrounding a word in triple brackets, so that it is added to the index is causing the word to vanish?
Input:
This (((!vanishes))).

This also (((vanishes))).

Output
<t>This <iref item="vanishes" primary="true"/>.</t>

<t>This also <iref item="vanishes"/>.</t>

This seems counter-intuitive since one would expect the word that they index to remain.
Also:
*[not]: (((not)))

This does not go away.

will render with the "not"!

It is often necessary to go to a base form for an index entry, so most likely you'd wanted to say
This vanishes (((vanish)))

(This is also the way <iref is processed in RFCXML.)
The search-based syntax is indeed different: It is meant to apply itself to text that remains readable as markdown text.


COCOS-143 - Add agent service tests

What type of PR is this?
This is an enhancement because it adds agent service tests
What does this do?
Adds agent service tests
Which issue(s) does this PR fix/relate to?
Resolves #143
Have you included tests for your changes?
Yes, I have included tests.
Did you document any new/modified feature?
No, I have not updated the documentation because this change adds test cases for the already documented existing agent feature.


Taking screenshots causes FPS/UPS to halve per screenshot

I tried using this mod to create a timelapse of my base, but every time the mod takes a screenshot (default settings), the game freezes and I see the FPS/UPS halve.
I can launch nukes without the game lagging..so I don't understand why the performance drops. I have an SSD and a dedicated GPU with 2GB of VRAM which should be enough for 1080p screenshots

For each screenshot the game has to render the image for the provided resolution you use.
If the image is zoomed out a lot, it takes more effort to render (more objects/entities to process).
During the render the game if paused, so the render is consistent.
So a big(ger) base + a high resolution takes more time...
Which can be mitigated by faster CPU, GPU, RAM and (disk) storage.
You can try lowering resolution and/or taking screenshots with a smaller base/zoom factor to see if this helps speeding up.

Uhhh
I've got bad news..I set the res to 2560x1440 and the issue happened AGAIN.

that is the size of my fun map....and the large screenshots are harder to take but it's better than freezing up..
Any ideas on how to stop this? I want my whole base to be recorded. My normal world isn't nearly as large but I do not want to constantly increase image resolution once my world is large enough to warrant it because the lag will increase a lot (and it's already past the 1080p point)

The image resolution error occurs when the zoom factor is smaller than the game supports, you'd basically reached maximum zoom (in order to fit the base).
To mitigate this you'd need to increase to resolution (a bigger canvas can contain more details), so zooming out would (still) fit the base (again).
This (of course) would take even longer to take screenshots. So it won't solve you original problem.
I honestly don't know how to solve this. I guess big bases needs more (a lot) of CPU, RAM, GPU to keep running smooth. I guess same (+ fast disk/storage speeds) goes for taking screenshots of it...?

Ah, so it does do it seamlessly; awesome!
Gonna turn it into a timelapse today I suppose, and delete the images and also set the mod to use different folders per save lol

Oh nooo
Some of the screenshots are 0mb....
Shouldn't the mod warn you about this? Luckily it's not too much time lost before the first 0mb image appears, only about 46 screenshots (2 minutes of real world time or so) are 0mb....

The mod doesn't write the screenshots, Factorio is doing that.
I guess you could file a bug report/feature request on the forums asking to warn the player that saving a screenshot failed due to lack of storage space...?

Additionally I've never used ffmpeg and I did change TLBE to use 30 FPS

Me neither, except for the command I linked to...

added some new trackers/cameras. How do I assemble it into a timelapse with ffmpeg?

If you have multiple camera, you need to edit you video to switch camera streams, or show then next to eachother, or whatever your plan for the final video... :wink:

If you have multiple camera, you need to edit you video to switch camera streams, or show then next to eachother, or whatever your plan for the final video... 😉

How do I make sure ffmpeg assembles the images properly with multiple cameras/trackers? Are you sure it's completely seamless? (I say this referring to having multiple trackers/cameras and turning the first 90GB of screenshots into a proper timelapse, and then doing it again with another 90GB of screenshots and then editing the 2 separate timelapses together to look seamless)

each camera stores the screenshots with a different filename/prefix. So using something like
ffmpeg -framerate 25 -pattern_type glob -i 'camera1*.png' -c:v libx264 -pix_fmt yuv420p camera1.mp4
ffmpeg -framerate 25 -pattern_type glob -i 'camera2*.png' -c:v libx264 -pix_fmt yuv420p camera2.mp4

Gives you 2 timelapses (one from each camera)
How to edit the 2 timelapses into a single video is up to you:

Do you switch cameras once in a while?
Do you show a picture-in-picture kinda of video?
Something else?

No idea if ffmpeg can do this (it is pretty powerful, so probably it can), or you'd need some proper video editing software... (I am by no means an expert (or even an amateur) in video editing... :disappointed:

Even when you change the 'Save location' and make sure to confirm the changed settings?
It is (has been, I'll check when I am back home again) working fine on my side... :thinking:

True, the folder is used for all cameras/screenshots. On top of this, the camera name is used in the name of the screenshots (for that camera), so it is fairly easy to filter out the screenshots of each camera within the same save (folder).
See the ffmpeg example I wrote about (https://github.com/veger/TLBE/issues/26#issuecomment-945114506):  -pattern_type glob -i 'camera1*.png' should filter all screenshots for camera1 when it makes the video.


Required fields in embedded messages

When I set a field in an embedded message and there are required fields left to set, for example, in that case:
message Parent {
	optional Children children = 1;
}
message Children {
	required string name = 1;
	required uint32 age = 2;
}

import test
mother = test.Parent()

mother.children.age = 12
mother.children.name = "Camille"

This exception is thrown:
Traceback (most recent call last):
  File "use_it.py", line 5, in <module>
    mother.children.age = 12
  File "/usr/local/lib/python3.4/dist-packages/protobuf3/fields/base.py", line 82, in __set__
    self._convert_to_wire_type(value))
  File "/usr/local/lib/python3.4/dist-packages/protobuf3/message.py", line 168, in _set_wire_values
    msg._set_wire_values(number, FIELD_VARIABLE_LENGTH, self.encode_to_bytes(), idx)
  File "/usr/local/lib/python3.4/dist-packages/protobuf3/message.py", line 184, in encode_to_bytes
    self._check_required_fields()
  File "/usr/local/lib/python3.4/dist-packages/protobuf3/message.py", line 144, in _check_required_fields
    raise KeyError("Some required fields are missing: " + ", ".join(missing_fields))
KeyError: 'Some required fields are missing: name'

When we set the age, the name isn't set yet, so this error is thrown. Maybe it can be fixed with a temporary object that hold the age while waiting for the name to be chosen, and when every required field has gotten its value, set them all at once?

+1 for this issue. I haven't found any workaround besides modifying the fields to be optional.


Add ADRs about updating of experiments as part of the TSP

Contributes to #608
Signed-off-by: Bernd Hufmann<EMAIL_ADDRESS>

Thanks for the thorough review. I updated the files on my side. I put the PR back as draft, because I have some doubts on the proposed alternatives and need to investigate a bit further.

I updated the PR to have one ADR for update the experiment which focuses on the parameters passed when creating the experiment, i.e. name and list of trace UUIDs.  Other updates won't not part of this PR. They need dedicated investigations and ADRs.


add Reset to Defaults button and add space to settings activity

Fixes #3570 and #3650

I updated the look of the button to match the logs buttons


Create new release for the Spin shim with outbound MQTT support

https://github.com/spinkube/containerd-shim-spin/pull/55 added support for Spin 2.4, which introduced outbound MQTT support.
To support this workload (and to avoid the scenario for the Python SDK with apps failing to start because of the missing MQTT import — https://github.com/spinkube/spin-operator/issues/202#issuecomment-2070544367), we should create a new release of the shim.

The shim is now on Spin 2.6.  Should outbound MQTT just work now?


Addition of template defined Site Policies

Templates now allows to use the site policy specified in the
provisioning template to be used in favor of the one specified by the
classification.

Thx Wictor. We'll add notes to Nov readme around the change needed for the request list for this one, since existing deployments will otherwise be impacted.

Thanks Vesa! Overall we need to work out a better documentation for that sample since the default readme is now humongous

Absolutely agree on that. We are also just about to release new packaged version of similar solution under the PnP Partner Pack, which partly overlaps with this one. Whole point of the PnP Partner Pack is that it's more packaged and polished with proper documentation on setting it up to any tenant... slightly overlapping with this sample, but idea is that those are isolated. See dev branch under https://github.com/OfficeDev/PnP-partner-pack

I'd say that this is very unfortunate and not a good move for PnP, not for these solutions or the whole project in general. Now you're competing with yourself with no clear path forward. Just pushing out new projects, solutions, samples etc does no good, they need to be maintained...

Yes and no. This is now the first time we have clear plan and are starting to move to that direction. Whole point is to ensure that we have reusable solution which can be deployed easily cross any tenant. In the end PnP repo has huge amount of random samples, but it's really hard to find the most meaningful ones. PnP Partner Pack is the solution for this and whole point is that anyone can easily adapt the models.
We have not yet openly communicated on this, except in the monthly calls, but whole point is to ensure that we have proper fine tuned and polished solution, which has needed scripts and documentation for easy consumption... which has been lacking. So - this is first step towards more structural model. Finally.


Dev 2012 blog - Recommended field, filter views

@xPapp what was the scope of this PR? Do you need help to get this in?


chore: changed golang-related CI configuration and update document

Hi, I fixed golang-related document and CI configuration.

Updated README.md
Updated workflow files to use actions/setup-go v4

Using go-version-file inputs to get Golang version from go.mod file
Using v4 version

The v4 version is using cache: true on default
See https://github.com/actions/setup-go/releases/tag/v4.0.0

LGTM, thank you @ponkio-o!


Implement Branch Nodes in FlyteKit

Motivation: Why do you think this is important?
Statically declared WF branching allows users to write more concise flow control logic that can be visualized/debugged/analyzed statically.
Goal: What should the final outcome look like, ideally?
A pythonic-way of defining branches within a workflow that implements the full flyte IDL spec.
Flyte component

[ ] Overall
[ ] Flyte Setup and Installation scripts
[ ] Flyte Documentation
[ ] Flyte communication (slack/email etc)
[ ] FlytePropeller
[ ] FlyteIDL (Flyte specification language)
[X] Flytekit (Python SDK)
[ ] FlyteAdmin (Control Plane service)
[ ] FlytePlugins
[ ] DataCatalog
[ ] FlyteStdlib (common libraries)
[ ] FlyteConsole (UI)
[ ] Other

[Optional] Propose: Link/Inline
n1 = get_int(...)
node = flyte_if(n1).EqualsTo(5).then(task_1(...))
             .else_if().GreaterThan(10).then(lp_2(...))
             .else(default_case(...))

This is now part of v0.16.0b1

This is now part of v0.16.0b1


feat(release): use new plugin metadata updater

I'm working towards removing the custom go code that's included in https://github.com/armory-plugins/pluginRepository. This code gets copied around every time someone wants to make a new plugin repository.
Instead I'm hoping everyone will use this GitHub action: https://github.com/armory-io/plugin-metadata-updater.
Two things will happen:

The first time the GH action updates your metadata repo, the diff might be pretty big because the JSON format is slightly different (but better)
It's going to create a PR, rather than just committing the update. If you don't like that, we can set up mergify to auto-merge the PRs.

Pull Request Test Coverage Report for Build #45

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.813%

Totals

Change from base Build #41:
0.0%

Covered Lines:
243

Relevant Lines:
251

💛  - Coveralls


In my app (very WIP), if you navigate to /accessToken and enter a valid Deno Deploy access token, it will forward you to the very simple test.tsx route (/test).  This fails.  If I comment out the below two lines of code in my _layout.tsx, it successfully works.  Without partials, the forwarding and rendering work fine.
(below is only a snippet of _layout.tsx).  What is common between both commented out sections (which cause the Partial rendering to fail if uncommented) is the inline checks before rendering.  The tab bar in particular is very simple.

          {/* {deployUser ? <AvatarMenu deployUser={deployUser} /> : <UnknownAvatarMenu />} */}

            {/* {tabEnabledPath && <TabBar tab={path} connectionId={connectionId} />} */}
            <ctx.Component />

For example, if I uncomment the tabEnabledPath line, I get this error in the browser console.  It suggests I forgot to export my componet (I haven't) or mixed up default or named imports (I don't believe I have).  I've also tried both export default function TabBar and export function TabBar with no difference in results.
debug.js:10 Uncaught (in promise) Error: Undefined component passed to createElement()

You likely forgot to export your component or might have mixed up default and named imports<#text tab="test" connectionId="" />

  in #text

    at a.__b (debug.js:10:352)
    at a.__b (hooks.js:2:2247)
    at signals.mjs:2:1140
    at B (preact.mjs:2:4860)
    at ee (preact.mjs:2:1851)
    at ue (preact.mjs:2:8066)
    at B (preact.mjs:2:6870)
    at ee (preact.mjs:2:1851)
    at ue (preact.mjs:2:8066)
    at B (preact.mjs:2:6870)
a.__b @ debug.js:10
a.__b @ hooks.js:2
(anonymous) @ signals.mjs:2
B @ preact.mjs:2
ee @ preact.mjs:2
ue @ preact.mjs:2
B @ preact.mjs:2
ee @ preact.mjs:2
ue @ preact.mjs:2
B @ preact.mjs:2
ee @ preact.mjs:2
ue @ preact.mjs:2
B @ preact.mjs:2
ee @ preact.mjs:2
ue @ preact.mjs:2
B @ preact.mjs:2
ee @ preact.mjs:2
B @ preact.mjs:2
A @ preact.mjs:2
Promise.then (async)
I @ preact.mjs:2
W.setState @ preact.mjs:2
Ctor.setState @ VM94:3980
W.setState @ debug.js:5
applyPartials @ main.ts:844
await in applyPartials (async)
fetchPartials @ main.ts:557
await in fetchPartials (async)
(anonymous) @ main.ts:1087

I've tried to create a simple reproduction from a newly init'd Fresh project.  You can find that here: https://github.com/cknight/partial-forward-test.  Though this project does roughly similar things, it does actually render the Test route.  However, the URL does not update to the /test URL.  It remains on the / route.
Any help most appreciated.

I can confirm I'm having the same issue.
Was not present in 1.5, is present in 1.6.
My guess is it's somehow related to how the client navigation is handled because:

Even though the issue doesn't happen in 1.5, the manual redirect response actually causes a full-page reload (visible in browser), not a purely client side navigation change.
The issue goes away in 1.6 if I disable client navigation by removing the f-client-nav attribute.

I'm having this issue as well. I upgraded from 1.5.2 to 1.6.3 today and I get this error whenever I issue a redirect response from within a route handler. If I remove f-client-nav as @mzgajner suggests the error goes away.

I just wanted to follow up here that this issue is a blocker for us to upgrade to 1.6. Although removing partials is a workaround, this is not an option for us as we make wide use of them in our production app.


Adopt new tree in custom views

Fixes #63566

Note: This is still missing auto expanding of nodes, a feature that doesn't yet exist in the new tree. Once the functionality is available I'll add it before merging.

@alexr00 I had just one last comment otherwise LGTM

Auto expand is still missing. I'm merging now to start getting selfhost bugs.


major code cleanup

to increase security binary files should be owned by root not by user who executes that file
move user and group creation to server section as those aren't needed when only installing client
remove hacky installation of packages (do not use with_indexed_items)
rename ansible_support_packages to minio_ansible_support_packages as every variable starting from ansible_ should come from ansible itself, not from role.
remove python_sni_pip_dependencies and just list packages in task for better readability
remove systemd_units_dir and always use /etc/systemd/system value as is recommended by systemd
remove initd_conf_dir variable and only use its value for better readability

Do we want to add a cleanup for the old unit file location?

That's a good question. Adding this won't change anything in how it operates since files located in /etc/systemd/system takes priority over ones located in lib/systemd/system.
@atosatto WDYT?

It's perfectly fine to stick with systemd unit files in /etc/systemd/system


Update Removed Den #'s

Hello Leanny,
You seemed to miss the primary concern entirely with this update. The issue WAS NOT that the drop-down showed the individual Dens' numbers. (We were ALL HAPPY about that as PKHeX recently added the Raid Parameter Editor features in the December 26th update.) The issue we all had is because your list was missing the "Watchtower Lair" (as the game names in the in-game descriptions) that the numbering was off.
The NEW issue created is that the drop-down no longer shows the Den numbers at all!
For example, let's say I wanted to find the following Den in the Raid Parameter Editor... now I have to scroll through the SEED's:

It is VITAL that the Raid List viewer's drop-down lists the Dens by the Den number SHOWN in the Raid Parameter Editor.
EXAMPLE:

I have low Shiny Frame Advancement and want to use the Raid Parameter Editor to make the Den Active (since doing so in PKHeX doesn't re-roll the Shiny Frame Advancement.) How do you find that Den in the Raid Parameter Editor in a timely manner (when compared to how FAST it was in the previous version looking by Den number!!!)???
To conclude: all the active Issue posts you just closed were complaining that the number was off by 1 (because of the Missing Watchtower Lair location) NOT that you were using numbers. We want the drop-down for your Raid Viewer to be identical to the Raid Parameter Editor's drop-down!

(I've reverted to the previous version because this new one's drop-down is slowing me down tooooo much.)

My bad. The numbers were removed by accident when I copied over the new names. I will create a hotfix version that has the numbers in it as well


Improve ESD immunity

Glasgow is designed to withstand hotplugging, manually touching wires and so on on the port pins. But there are also other pins accessible from the outside: sync, aux, lvds. They currently aren't protected well. They don't have a series resistor like the ports, so the IC connected to them has to survive all the ESD energy.
The first thing I propose is to add a series resistors (I suggest 47 ohms) between the sync pin and it's '45 U32, and the aux pins and the ice40.
These series resistors help the ICs dropping the ESD voltage. They aren't perfect, but a small, cheap and easy method. In my experience they significantly improve esd immunity. Also they double as a series termination and help to reduce ringing.
The 74LVC1T45s used on the port pins just have an ESD rating of 2 kV HBM. That is not much for a pin connected to outside of the board and expected to be "abused", even with the series resistors in front. I suggest to add TVS diode arrays behind the series resistors to improve this.
My usual go-to part for this application is IP4220CZ6, I use them a lot on my boards. It protects 4 lines of USB HS speed level. But it is SOT23-6, so it wouldn't fit on the board. But there are many similar products available in smaller packages, e.g. D5V0F4U6V, XBP14E5UFN-G or you could even go crazy small with HSP051-4M5.
There are also some available for 8 lines in parallel. These are mostly designed for USB 3, HDMI and the like and could also be used for the LVDS port. For example ESD7016MUTAG,  ESD8008MUTAG or SP7538PUTG.
On the LVDS port I wouldn't add series resistors as this interferes with LVDS and isn't recommended. So just a TVS diode array there.

So, the AUX pins and the LVDS bank are not going to be populated as they come from the fab, and moreover, they will not be directly accessible under the case. That means you can't just touch them, and that's why they have no particular protection mechanisms; for LVDS specifically it is expected that for any real use, an add-on board will be connected that has the termination (as it stands, the "LVDS" bank can't really do LVDS, it requires external passives, a lot of them).
Regarding banks A and B and the Sync pin... it would be very tricky to fit. @marcan?

Adding series resistors for SYNC and AUX is trivial, that much we can do.
As for clamp diodes, it's worth noting that as far as I can tell the SN74LVC1T45s we're using only have low side clamp diodes (because they are 5V tolerant on inputs regardless of IO voltage). So to provide proper protection it makes sense to add external diodes hardwired to 5V and GND (not VIO); this maintains the 5V-tolerance on the inputs regardless of reference voltage (which is a good feature to have).
Now the question is whether we can fit this in at all. I might try something with the XBP14E5UFN, but either way, if we do this I'm pretty sure the ESD protection is going to have to go on the underside.

Okay, I can push things around just enough to put the XBP14E5UFN on the top side. Very rough layout test:

looking good to me. Thanks for picking this up.

Fixed in b9794b5.

Ah, not yet on SYNC.

Fixed in 59c960b.


JsonReaderException when deserializing Slack payload to the InteractionPayload model

Version
Microsoft.Bot.Builder 4.10.3
Describe the bug
JsonReaderException when deserializing Slack payload to the InteractionPayload model.
Problem: Newtonsoft.Json.JsonReaderException at Newtonsoft.Json.JsonTextReader.ReadStringValue
Message: Unexpected character encountered while parsing value: {. Path 'state', line 1, position 4505.
i.e. exception is thrown when a user selects an option from the Slack static select element.
Slack sends a dictionary of objects on state property and the Slack adapter library is trying to deserialize to a string.
Slack API reference: https://api.slack.com/reference/interaction-payloads/block-actions#fields
Microsoft.Bot.Builder.Adapters.Slack.Model.InteractionPayload class has the State property as a string property.
To Reproduce

Create a chatbot project using the Microsoft.Bot.Builder.Adapters.Slack.SlackAdapter
Configure the Slack app: set the Interactivity request URL to your chatbot endpoint
Post a message to Slack using the StaticSelectElement
Select an option from the select element
See the error happening on adapter.ProcessAsync

Expected behavior
Deserialize the model properly and send the activity to the ActivityHandler

Thank you for the report, @gabemilani
I'm having trouble following your repro steps. Could you provide a bit more information about how to reproduce the problem? What is a StaticSelectElement?

Hello @v-kydela
The StaticSelectElement is a class from the dependency library SlackAPI. Here you can find more information about it: https://api.slack.com/reference/block-kit/block-elements#static_select
Whenever I use this and select an option the SlackAdapter throws an exception while trying to process the request.

@gabemilani - Thank you for the link. I've found the source code here, but can you elaborate a bit more by showing a code example of an actual static select element and how you're posting it to Slack?

Here is a example:
var blocks = new List<IBlock>()
{
    new SectionBlock
    {
        text = new Text
        {
            type = "mrkdwn",
            text = "Select a fruit"
        }
    },
    new ActionsBlock()
    {
        elements = new []
        {
            new StaticSelectElement
            {
                placeholder = new Text { type = "plain_text", text = "Fruit" },
                action_id = "select-fruit",
                options = new [] {
                    new Option
                    {
                        text = new Text { type = "plain_text", text = "Apple" },
                        value = "select-fruit|apple"
                    },
                    new Option
                    {
                        text = new Text { type = "plain_text", text = "Orange" },
                        value = "select-fruit|orange"
                    }
                }
            }
        }
    }
};

Send a post request to the following API URL https://api.slack.com/methods/chat.postMessage#arg_blocks with that blocks payload

Now it's happening with ButtonElement too.
A quick fix is to change the property state from the InteractionPayload class to an object instead of a string.

@gabemilani - I have reproduced the error and I'm working on a fix

That's great! Would you know a prediction of when this will be released?
Let me know if I can help with anything else. Thanks for your work @v-kydela !

@gabemilani - The PR is awaiting a code owner review


Specify key names generated for keys with masks

Signed-off-by: Mihai Budiu<EMAIL_ADDRESS>Fixes #1138
This has been supported by the compiler for at least 5 years.

I assume you double checked that there was no other expressions missing from that table the compiler supports too?
Note I am only getting to the table and control plane parts of the specifications for my compiler so I am happy for this change, I just want to make sure I don't miss any others here.

@vgurevich will post comments.

The Barefoot compiler does not use these rules for masks and slices.


Updater doesn't consistently work

I don't have python2 installed so calling python in my terminal returns command not found. To start python, I need to call python3. I needed to change
update_success_status |= os.system('cd /tmp/{0}/ && sudo python setup.py install'.format(source_folder))

to this:
update_success_status |= os.system('cd /tmp/{0}/ && sudo python3 setup.py install'.format(source_folder))

to get the program to update correctly. (these edits are on main.py)
Possible solution:
use sys.version to get the version of python that is currently running and use the proper command

I don't have python2 installed so calling python in my terminal returns command not found. To start python, I need to call python3. I needed to change
update_success_status |= os.system('cd /tmp/{0}/ && sudo python setup.py install'.format(source_folder))

to this:
update_success_status |= os.system('cd /tmp/{0}/ && sudo python3 setup.py install'.format(source_folder))

to get the program to update correctly.
Possible solution:
use sys.version to get the version of python that is currently running and use the proper command

Thanks for filing this, let me check this once and fix this in the next release.


[BUG] Docker build fails currently due to a hash mismatch on the nvidia CUDA repository

🐛 Bug
0.463 Err:2 https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2004/x86_64  Packages
0.463   File has unexpected size (1127072 != 1126689). Mirror sync in progress? [IP: <IP_ADDRESS> 443]
0.463   Hashes of expected file:
0.463    - Filesize:1126689 [weak]
0.463    - SHA256:7cee2584ca6d97b2f07018ba4f9c3c473fb4e299ed170968a1f8c99c090cc59f
0.463    - SHA1:4ee24fac5518a3fcc3702590a0dab32c95484c54 [weak]
0.463    - MD5Sum:593faff511765d11055c9919bf2e3bf8 [weak]
0.463   Release file created at: Thu, 17 Aug 2023 19:03:05 +0000

3.996 Reading package lists...
4.592 E: Failed to fetch https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2004/x86_64/Packages.gz  File has unexpected size (1127072 != 1126689). Mirror sync in progress? [IP: <IP_ADDRESS> 443]

also reported here: https://github.com/NVIDIA/cuda-repo-management/issues/10
One quick solution, also maybe worth to do anyway would be to update the base image to nvidia/cuda:11.8.0-devel-ubuntu22.04

CUDA repository metadata mismatch is now resolved


[lit-next] @lit-labs/scoped-registry-mixin

Description
Exports points to a development scoped-registry-mixin.js but it's missing from published npm package.
"exports": {
    ".": {
      "development": "./development/scoped-registry-mixin.js",
      "default": "./scoped-registry-mixin.js"
    }
  },

@lit-labs/scoped-registry-mixin
1.0.0-pre.1
Compilation error
Could not load<EMAIL_ADDRESS>

Looking at the packages.json it looks like files is ignoring it.
  "files": [
    "/src/",
    "!/src/test/",
    "/scoped-registry-mixin.{d.ts,d.ts.map,js,js.map}"
  ],

Fixed by #1729


Multiple bots wont login - only the first

Hi,
I haven't had success trying to login with multiple bots and it might be a duplicate or similar issue to #319. My application uses the express.js framework however below I have tried to provide a simple example. I haven't been able to get around it but what happens is that only the first bot manages to login.
A minimal sample
// app.js
var Bot = require('./bot');

var bot1= new Bot();
bot1('bot1', 'pw123');

var bot2 = new Bot();
bot2('bot2', 'pw456');

And the bot
// bot.js
var Steam = require('steam');
var steamClient = new Steam.SteamClient();
var steamUser = new Steam.SteamUser(steamClient);
var steamFriends = new Steam.SteamFriends(steamClient);

module.exports = function() {
    return function (username, pw) {
        steamClient.connect();
        steamClient.on('connected', function() {
            steamUser.logOn({
                account_name: username,
                password: pw
            });
        });

        steamClient.on('logOnResponse', function(logonResp) {
            if (logonResp.eresult == Steam.EResult.OK) {
                steamFriends.setPersonaState(Steam.EPersonaState.Online);
                console.log('logged in as: ', username);
            }
        });

        steamClient.on('debug', function(msg) {
            console.log('debug:', msg);
        });

        steamClient.on('error', function(err) {
            console.log('error:', err);
        });
    };
};

Here the log output after running node.exe app.js
debug: connecting to <IP_ADDRESS>:27017
debug: socket timed out
debug: socket timed out
debug: socket closed
debug: socket closed
debug: connecting to <IP_ADDRESS>:27017
debug: connecting to <IP_ADDRESS>:27017
debug: socket timed out
debug: socket timed out
debug: socket closed
debug: socket closed
debug: connecting to <IP_ADDRESS>:27017
debug: connecting to <IP_ADDRESS>:27017
debug: connected
debug: connected
debug: encrypt request
debug: encrypt request
logged in as:  bot1
logged in as:  bot2

I appreciate any directions on this.
//Baha

From looking at the log output, it looks like both bots logged in?

Only the first one actually manages to login. After further logging it seems that they are getting the same client instance id, nonce and so on which I assume causes the mishap.
Extracting the steamClient, steamUser and steamFriends into the constructor function solved it.
// bot.js
var Steam = require('steam');

module.exports = function() {

var steamClient = new Steam.SteamClient();
var steamUser = new Steam.SteamUser(steamClient);
var steamFriends = new Steam.SteamFriends(steamClient);

    return function (username, pw) {
        steamClient.connect();
        steamClient.on(............

Thanks for node-steam @seishun
//Baha


Pending template PRs

There are a bunch of PRs that add a cookiecutter to the readme.
#423 #422 #374 #350 #307 #283 #278 #143 #131
Some of them cause merge conflicts or require additional work, others should be just fine.
I think we should try to address them asap and close the ones that are obsolete.
I decided to create this issue as I cannot add labels :blush:
https://github.com/audreyr/cookiecutter/labels/template
What's your opinion on this matter?

Should we review these or pull requests that add technical features?

I feel that we should try to ship http://cookiecutter.readthedocs.org/en/latest/advanced_usage.html#copy-without-render soon. :smiley:
Hence I'd rather have a few more templates in the release instead of additional features. Do you know of any critical issues that need to be tackled asap?

I was thinking about merging all of the template contributions in myself. What's your opinion on this matter? @audreyr @pydanny @pfmoore @michaeljoseph

:bell:

Go for it. I like to actually check the template to see if and how it works before merging, but it's not necessary.

These are all closed now.

@michaeljoseph 👍


Identify format option

This PR provides a raw option for identify function http://www.imagemagick.org/script/escape.php
Example: identify(@fixture, "'%[orientation]'")

Hi @talklittle, suggestions addressed.

Thanks for revision. Merged as a7e2d89db31d27a5b547ff890fec01960a665f55


fix Management.Sql sdk issue for customization elastic pool model

Description

Fix an small issue in Management.Sql sdk for customization elastic pool model in previous PR (https://github.com/Azure/azure-sdk-for-net/pull/4171). Simple fix,  no other changes. Related rest-api PR: (https://github.com/Azure/azure-rest-api-specs/pull/2734)
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please add REST spec PR link to the SDK PR
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda Hi Deepak, Can you please review this PR? We found an issue with the previous merged Management.Sql SDK, and this one fix the issue. We want to checkin this asap before the new SDK version 1.14.0-preview is published. Thanks!

@payiAzure if your package has been published already, you will need to bump the version before you publish

@dsgouda Thanks Deepak! The package has not been published yet.


Fix spelling

@rohityadavcloud I will take care of this. I'm updating the domainid description, I would add these as well.
Checkout the following pr please:
https://github.com/apache/cloudstack/issues/7776

Btw, I don't have a permission to assign PRs in this repository, feel free to assign this PR to me.

@jbampton I've added the changes in the generate/listApis.json file to the PR https://github.com/apache/cloudstack/pull/7876, can you please exclude them from your PR?

@rohityadavcloud My PR got merged, I would like to update the generated.go file but I couldn't find any docs about it. This is the only thing I found :D

The SDK relies on the  generate.go script to auto generate the code for all the supported APIs listed in the listApis.json file. The listAPIs.json file holds the output of listApis command for a specific release of CloudStack.

# Run it via the Makefile
make all

@soreana @rohityadavcloud if listApis.json is generated, should it be in the repository? As opposed to the generation script/command I mean.
@jbampton can you remove the file from your PR, please?

@soreana @rohityadavcloud if listApis.json is generated, should it be in the repository? As opposed to the generation script/command I mean.
@jbampton can you remove the file from your PR, please?

@DaanHoogland I'm not sure why they're there. I suppose the generated files are bundled so that the SDK knows what API calls are available.

I understand @soreana , but I'd expect it to be generated on build- or run-time. Maybe we can improve it that way?


Error in building xgboost in oracle linux

Hi Team,
I am trying to build xgboost in oracle linux server 6.7 (gcc 4.8.0) by following these commands:
git clone --recursive https://github.com/dmlc/xgboost
cd xgboost; make -j4
I am getting below error. Can you please let me know what i am missing here ?
g++ -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude   -Idmlc-core/include -Irabit/include -fPIC -fopenmp -MM -MT build/learner.o src/learner.cc >build/learner.d
g++ -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude   -Idmlc-core/include -Irabit/include -fPIC -fopenmp -MM -MT build/logging.o src/logging.cc >build/logging.d
g++ -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude   -Idmlc-core/include -Irabit/include -fPIC -fopenmp -MM -MT build/c_api/c_api.o src/c_api/c_api.cc >build/c_api/c_api.d
g++ -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude   -Idmlc-core/include -Irabit/include -fPIC -fopenmp -MM -MT build/c_api/c_api_error.o src/c_api/c_api_error.cc >build/c_api/c_api_error.d
g++ -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude   -Idmlc-core/include -Irabit/include -fPIC -fopenmp src/c_api/c_api_error.cc -o build/c_api/c_api_error.o
g++ -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude   -Idmlc-core/include -Irabit/include -fPIC -fopenmp src/logging.cc -o build/logging.o
g++ -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude   -Idmlc-core/include -Irabit/include -fPIC -fopenmp src/c_api/c_api.cc -o build/c_api/c_api.o
g++ -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude   -Idmlc-core/include -Irabit/include -fPIC -fopenmp src/learner.cc -o build/learner.o
g++ -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude   -Idmlc-core/include -Irabit/include -fPIC -fopenmp -MM -MT build/common/common.o src/common/common.cc >build/common/common.d
g++ -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude   -Idmlc-core/include -Irabit/include -fPIC -fopenmp src/common/common.cc -o build/common/common.o
g++ -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude   -Idmlc-core/include -Irabit/include -fPIC -fopenmp -MM -MT build/data/data.o src/data/data.cc >build/data/data.d
g++ -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude   -Idmlc-core/include -Irabit/include -fPIC -fopenmp src/data/data.cc -o build/data/data.o
g++ -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude   -Idmlc-core/include -Irabit/include -fPIC -fopenmp -MM -MT build/data/simple_csr_source.o src/data/simple_csr_source.cc >build/data/simple_csr_source.d
g++ -c -std=c++0x -Wall -O3 -msse2  -Wno-unknown-pragmas -funroll-loops -Iinclude   -Idmlc-core/include -Irabit/include -fPIC -fopenmp src/data/simple_csr_source.cc -o build/data/simple_csr_source.o
In file included from src/data/./sparse_page_source.h:12:0,
from src/data/data.cc:16:
dmlc-core/include/dmlc/threadediter.h: In lambda function:
dmlc-core/include/dmlc/threadediter.h:326:37: error: no matching function for call to ‘std::condition_variable::notify_all() const’
consumer_cond_.notify_all();
^
dmlc-core/include/dmlc/threadediter.h:326:37: note: candidate is:
In file included from dmlc-core/include/dmlc/concurrency.h:15:0,
from src/data/./sparse_batch_page.h:22,
from src/data/data.cc:9:
/usr/local/gcc-4.8.0/include/c++/4.8.0/condition_variable:83:5: note: void std::condition_variable::notify_all()
notify_all() noexcept;
^
/usr/local/gcc-4.8.0/include/c++/4.8.0/condition_variable:83:5: note:   no known conversion for implicit ‘this’ parameter from ‘const std::condition_variable_’ to ‘std::condition_variable_’
In file included from src/data/./sparse_page_source.h:12:0,
from src/data/data.cc:16:
dmlc-core/include/dmlc/threadediter.h:333:37: error: no matching function for call to ‘std::condition_variable::notify_all() const’
consumer_cond_.notify_all();
^
dmlc-core/include/dmlc/threadediter.h:333:37: note: candidate is:
In file included from dmlc-core/include/dmlc/concurrency.h:15:0,
from src/data/./sparse_batch_page.h:22,
from src/data/data.cc:9:
/usr/local/gcc-4.8.0/include/c++/4.8.0/condition_variable:83:5: note: void std::condition_variable::notify_all()
notify_all() noexcept;
^
/usr/local/gcc-4.8.0/include/c++/4.8.0/condition_variable:83:5: note:   no known conversion for implicit ‘this’ parameter from ‘const std::condition_variable_’ to ‘std::condition_variable_’
In file included from src/data/./sparse_page_source.h:12:0,
from src/data/data.cc:16:
dmlc-core/include/dmlc/threadediter.h:352:45: error: no matching function for call to ‘std::condition_variable::notify_all() const’
if (notify) consumer_cond_.notify_all();
^
dmlc-core/include/dmlc/threadediter.h:352:45: note: candidate is:
In file included from dmlc-core/include/dmlc/concurrency.h:15:0,
from src/data/./sparse_batch_page.h:22,
from src/data/data.cc:9:
/usr/local/gcc-4.8.0/include/c++/4.8.0/condition_variable:83:5: note: void std::condition_variable::notify_all()
notify_all() noexcept;
^
/usr/local/gcc-4.8.0/include/c++/4.8.0/condition_variable:83:5: note:   no known conversion for implicit ‘this’ parameter from ‘const std::condition_variable_’ to ‘std::condition_variable_’
make: *** [build/data/data.o] Error 1
make: *** Waiting for unfinished jobs....

i meet the same error!
system:centos
gcc:4.8
git clone --recursive https://github.com/dmlc/xgboost
cd xgboost; make -j4
error:
g++ -std=c++0x -Wall -Wno-unknown-pragmas -Iinclude   -Idmlc-core/include -Irabit/include -O3 -funroll-loops -msse2 -fPIC -fopenmp -MM -MT build/data/data.o src/data/data.cc >build/data/data.d
g++ -c -std=c++0x -Wall -Wno-unknown-pragmas -Iinclude   -Idmlc-core/include -Irabit/include -O3 -funroll-loops -msse2 -fPIC -fopenmp src/data/data.cc -o build/data/data.o
In file included from src/data/./sparse_page_source.h:12:0,
from src/data/data.cc:16:
dmlc-core/include/dmlc/threadediter.h: In lambda function:
dmlc-core/include/dmlc/threadediter.h:326:37: error: no matching function for call to ‘std::condition_variable::notify_all() const’
consumer_cond_.notify_all();
^
dmlc-core/include/dmlc/threadediter.h:326:37: note: candidate is:
In file included from dmlc-core/include/dmlc/concurrency.h:15:0,
from src/data/./sparse_batch_page.h:22,
from src/data/data.cc:9:
/usr/local/include/c++/4.8.0/condition_variable:83:5: note: void std::condition_variable::notify_all()
notify_all() noexcept;
^
/usr/local/include/c++/4.8.0/condition_variable:83:5: note:   no known conversion for implicit ‘this’ parameter from ‘const std::condition_variable*’ to ‘std::condition_variable*’
In file included from src/data/./sparse_page_source.h:12:0,
from src/data/data.cc:16:
dmlc-core/include/dmlc/threadediter.h:333:37: error: no matching function for call to ‘std::condition_variable::notify_all() const’
consumer_cond_.notify_all();
^
dmlc-core/include/dmlc/threadediter.h:333:37: note: candidate is:
In file included from dmlc-core/include/dmlc/concurrency.h:15:0,
from src/data/./sparse_batch_page.h:22,
from src/data/data.cc:9:
/usr/local/include/c++/4.8.0/condition_variable:83:5: note: void std::condition_variable::notify_all()
notify_all() noexcept;
^
/usr/local/include/c++/4.8.0/condition_variable:83:5: note:   no known conversion for implicit ‘this’ parameter from ‘const std::condition_variable*’ to ‘std::condition_variable*’
In file included from src/data/./sparse_page_source.h:12:0,
from src/data/data.cc:16:
dmlc-core/include/dmlc/threadediter.h:352:45: error: no matching function for call to ‘std::condition_variable::notify_all() const’
if (notify) consumer_cond_.notify_all();
^
dmlc-core/include/dmlc/threadediter.h:352:45: note: candidate is:
In file included from dmlc-core/include/dmlc/concurrency.h:15:0,
from src/data/./sparse_batch_page.h:22,
from src/data/data.cc:9:
/usr/local/include/c++/4.8.0/condition_variable:83:5: note: void std::condition_variable::notify_all()
notify_all() noexcept;
^
/usr/local/include/c++/4.8.0/condition_variable:83:5: note:   no known conversion for implicit ‘this’ parameter from ‘const std::condition_variable*’ to ‘std::condition_variable*’
make: *** [build/data/data.o] Error 1

Personally I think GCC 4.8.0 is not enough. Please upgrade your GCC.

xgboost-0.6a2 use pip install same error
change to g++-5
which g++-5
export CXX=/usr/bin/g++-5
pip install xgboost


mgmt, function app, setting for linux

fix https://github.com/Azure/azure-sdk-for-java/issues/32795
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Update the acronym list to use those from golint

List: https://github.com/golang/lint/blob/6edffad5e6160f5949cdefc81710b2706fbcd4f6/lint.go#L770
In order to avoid partial matches, I need to figure out how to handle UUID & UID.
Updating the logic to index the acronyms as reversed would solve ID v. UUID, GUID, UID but it would not address UUID v. UID.
One possibility is to return a set of matches.

implementing a trie


Updated offsets

I appreciate the interest and the PR but a couple things:

You converted the hex values to decimal values which is inconsistent with my other CS:GO repos and is also not standard for external memory editors.
I purposefully only update the offsets when I push a code change to add somewhat of a barrier to using these scripts. They're intended to be for learning.

Closing and marking as wontfix.

Thanks, i didnt convert them, haze dumper outputted them like that :)


ClassCastException - WeekView to MonthView

I am using this calendar inside row on RecyclerView. I am setting calendar's display mode to CalendarMode.WEEKS. This row is on top of list.
I scroll down the list and then on the top of the list, then there is class cast exception.
I am using view holder pattern. Imo this is viewholder fault.
java.lang.ClassCastException: com.prolificinteractive.materialcalendarview.WeekView cannot be cast to com.prolificinteractive.materialcalendarview.MonthView
                                                                                at com.prolificinteractive.materialcalendarview.CalendarPagerAdapter.getItemPosition(CalendarPagerAdapter.java:125)
                                                                                at com.prolificinteractive.materialcalendarview.WeekPagerAdapter.getItemPosition(WeekPagerAdapter.java:9)

Any solutions?

Can you include a pastebin/gist of how your adapter and layouts are set up? MonthView and WeekView are separate subclasses of CalendarPagerView.
But I have a hunch it is because RV recreates the MCV and by default it is using month mode, forcing you to call setCalendarMode(WEEKS) during onBind. I don't think this should crash, but it might be crashing if you are only calling setCalendarMode(WEEKS) during onCreateVH.
There's a potential enhancement here: add an attribute to set week/month mode in XML. I'll create an issue request and reference.

Im using my own typedViewHolderAdapter.
way to create it:
    private TypedViewHolderAdapter<BaseCinemaItem> createAdapter() {
        return new TypedViewHolderAdapter.Builder<BaseCinemaItem>()
                .addFactory(CinemaCalendarViewHolder.factory(this))
                .addFactory(ListErrorViewHolder.factory())
                .addFactory(MovieViewHolder.factory(this))
                .addFactory(MovieWithHoursViewHolder.factory(this))
                .build();
    }

Below source codes:
ViewHolder:
https://gist.github.com/kostaniakm/4c21c705539fcd57534e0fdc2b621dab
xml. layout:
https://gist.github.com/kostaniakm/3f09c04a53293841440a4e2f6dab4684
Im setting Calendar mode during onBind. According to me what you suspect is the cause of the crash.

I checked version from future-1.x branch and this is not solving my problem. Same exception.

Are you settingmcv_calendarMode="week" in your layout?

Yes, I am.

I'll try to reproduce the issue in a sample app or (if you already have one) feel free to upload to github/bitbucket and link me to it.

Please check out the example on my fork, specifically RecyclerViewActivity: https://github.com/ekchang/material-calendarview/tree/ec/rv_example
There I create 10 calendars as items (set to Week, via XML) with no problems while scrolling through. This doesn't seem to be an issue with MCV, perhaps you are casting when you don't need to during onBind? And make sure you are not using MonthView/MonthViewPager if you are only dealing with Weeks.

Okay, I hope you got the right one! I'm gonna check also your sample or do mine but later, it is very late at night right now (3 am now).

I will push a hotfix (for now) which will stop the crash but there is a deeper problem where I believe CalendarPagerAdapter#getItemPosition is giving the wrong value for Week mode (due to the internal way the position used to be calculated with months. I will close this when the crash issue is fixed and log a separate bug for wrong position.

That hotfix (I was talking about it from beggining) fixes crash problem but I also see the new problem right now. We need new way to calculate minDate for WeekMode. Thanks for help, I'll try to find solution too.

Yep, I'm aware that it's a problem and logged it as a separate bug in #292. If you find the solution, feel free to shoot over a PR. Closing this as the crash has been resolved.

Seems like the issue is coming from materialCalendarView#setFirstDayOfWeek(Calendar.WEDNESDAY);


SLAM poses, trans_world and pose_world

Hi, first of all thank you for making all of your work available for us. It's greatly appreciated :)
I had a few questions regarding the parameters that we can from demo/api.
When analyzing the camera poses (slam_results.pth), I can see that the first pose is [ Id | 0].
Convention seems to be [x, y, z, qx, qy, qz, qw] right?
However, I'm trying to find the translation and position in the real world coordinate of the root according to the camera pose.
It seems to me that this information is stored in 'trans_world' and 'pose_world' (by getting the root node) however loading them directly in blender I can see that they don't really match the camera poses given. The 'trans_world' information is really close to the origin.
Am I doing something wrong?

Hi, yes, when I ran DPVO, I also saved the data as [x, y, z, qx, qy, qz, qw].
Do you mean that trans_world (prediction from WHAM) is merely moving while x, y, z of SLAM results look reasonable? First of all, SLAM results lack the global scale, so it needs to be multiplied by some scalar. That's why WHAM's prediction does not necessarily match with SLAM output. Please let me know if I am misunderstanding your question.


After solving it keep retrying to solve?

After solving it keep retrying to solve. Any idea how to stop?

Can you show me some code?

GetTaskResultAsync returns the solution. It handles waiting and retrying if the task is still processing.

solved.


Unknown prop warning in React 15.2.0

Hi,
I'm seeing
(program):44 Warning: Unknown prop `_radiumDidResolveStyles` on <div> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
    in div (created by StyleRoot)
    in StyleRoot (created by App)
    in App (created by ConfiguredCatalogContext)
    in CatalogContext (created by ConfiguredCatalogContext)
    in ConfiguredCatalogContext (created by RouterContext)
    in RouterContext (created by Router)
    in ScrollBehaviorContainer (created by Router)
    in Router

on React 15.2.0 at my project and Catalog 2.2.9. Something near StyleRoot is leaking a prop most likely.

I can actually see this if I clone Catalog locally and then run make. It's the same error. So you can test it against that. Just make sure you have a fresh version of React.

I get this as well. Seems to be due to this change in React: https://github.com/facebook/react/commit/de1de9e18f8faf153ad673c8206a2918e3e81035 which is more clearly described in https://facebook.github.io/react/warnings/unknown-prop.html
I just checked and the latest version of Radium is from March, so I guess we just have to wait for this to get resolved in Radium.

Related issue if you want to track, https://github.com/FormidableLabs/radium/issues/759 .

Thanks, subscribed 😄

I'm closing this, since there's not really something we can do about it until Radium publishes a fixed version.


#906- Added Copy button on get-started page to copy different example texts and cdn link

Fixes #906
Changes:
Added buttons to copy the text of different example texts and cdn links.
Screenshots of the change:

Tagging @lmccart for review. Thanks!

I'm not 100% sure about the position of the button, it looks a bit out of place there and also potentially blocking part of the scrollbar (which someone may want to click on that portion of the scrollbar).

@limzykenneth  I have taken the placement of the button from the examples section webpage. In examples section all the buttons were placed on the bottom right side of the code, hence I followed a similar convention here. If changes are required I'll do them. Thanks!

For the examples, all of then have an associated sketch and the buttons are overlapped on the sketch instead of the code which is less of a problem.

@lmccart @limzykenneth I have made the above-mentioned changes, please have a look. Thanks!


I want to output error messages along with the function name that defines the architecture

Enhancement description
I'm using phpat to define our architecture.
I have separated test architecture functions.
I have many definitions and when an error occurs, I get a lot of the same error messages.
It's hard to tell which definition caused the error.
I thought it would be nice to display error message with test function name, like phpunit.
What I wanted to do:
sample test:
class MyFirstTest
{
    public function test_domain_does_not_depend_on_other_layers(): Rule
    {
        return PHPat::rule()
            ->classes(Selector::namespace('App\Domain'))
            ->shouldNotDependOn()
            ->classes(
                Selector::namespace('App\Application'),
                Selector::namespace('App\Infrastructure'),
                Selector::classname(SuperForbiddenClass::class),
                Selector::classname('/^SomeVendor\\\.*\\\ForbiddenSubfolder\\\.*/', true)
            );
    }
}

error message sample (before):
App\Domain\User\ValueObject\UserId should not depend on App\Domain\SuperForbiddenClass

error message sample (after):
test_domain_does_not_depend_on_other_layers: App\Domain\User\ValueObject\UserId should not depend on App\Domain\SuperForbiddenClass

Suggested approach or solution
The main fixes are as follows

When retrieving rules from test method names in TestParser, test method names are not discarded but carried
Three Wrapper classes are provided to carry test method names.

TestName
RuleWithName
RuleBuilderWithName

Add prefix %s:  to all error messages to show the function name
Added constant TEST_FUNCTION_NAME_DETECTED_BY_PARSER to tests in unit/rules

Named the function name to be the name of the test function in phpat.test

What I did not do

Retrieving class names

Because the error message could have been too verbose

I don't fix error of SonarCloud Code Analysis

Duplicated Lines (%) on New Code 5.0%  in test directory code.
I can't fix it.

PR
https://github.com/carlosas/phpat/pull/208

Hey sorry for the delay. Thank you for the contribution.
I have left some change requests in the PR https://github.com/carlosas/phpat/pull/208#pullrequestreview-1314735476
Don't worry about Sonar. I just disabled it, it's giving more issues than help and I will cover code quality in another way.

The PR reflecting the #208 review remarks is #211.

Thank you for your review and merge.

The option show_rule_names (note the plural) has been released in https://github.com/carlosas/phpat/releases/tag/0.10.4
Thanks for the contribution :)


Forced scaffold generation

Dear developers,
I have been tinkering around with Linkinvent, Libinvent and Reinvent, but I seem to have a question regarding forced substructures. I would like to force the substructure of bisphenol A to generate compounds with modifications like in the picture below:

However I seem not able to do both a linker change and modifications on the benzene/oxy group at the same time.
I have tried to reverse score the MatchingSubstructure penalty to make a bonus, but I really lose the substructure in that case.
Any advice?
Warm regards,
Wout

You would need to provide details of your config.  The penalty term is the
way to go.
On Mon, 25 Mar 2024, 17:17 Wout Van Eynde, @.***> wrote:

Dear developers,
I have been tinkering around with Linkinvent, Libinvent and Reinvent, but
I seem to have a question regarding forced substructures. I would like to
force the substructure of bisphenol A to generate compounds with
modifications like in the picture below:
image.png (view on web)
https://github.com/MolecularAI/REINVENT4/assets/99839278/36d1df08-72dd-49bc-b7c5-ba16cd45e947
However I seem not able to do both a linker change and modifications on
the benzene/oxy group at the same time.
I have tried to reverse score the MatchingSubstructure penalty to make a
bonus, but I really lose the substructure in that case.
Any advice?
Warm regards,
Wout
—
Reply to this email directly, view it on GitHub
https://github.com/MolecularAI/REINVENT4/issues/50, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB65UWW626XNKXEVVNXZCSLY2BEY7AVCNFSM6AAAAABFHJ5PLGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYDMMJTHA4TCNY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

This would be the configuration file I am using, but I am getting compounds with a transformed substructure score of 1, like in the figure:
RL.txt

It seems like I misread it; I need SMARTS instead of SMILES, so that fixed it.


[release-4.14] HOSTEDCP-1795,HOSTEDCP-1796: Customize the self-generated cert validity and rotation

This is a manual cherry-pick of https://github.com/openshift/hypershift/pull/4444

/lgtm

/retest-required

/retest


ARFrameMode Compile Errors

Seems to be a little error with the latest commit. When I attempt to compile:

@gheatley, I believe you're using Xcode 10 beta. If so, I'll investigate the issue when the Xcode 10 stable release is out. Otherwise, please let me know what version of Xcode you're using?

@gheatley, I just found where the issue is coming from, will push a new update in a few moments


Won't install

I'm having trouble installing this in VSCode 1.12.0-insider. When it click install, it hangs on "installing" for a while, and the install button is eventually re-enabled.
I tried installing it via the extension pack as well, and it just hangs on "installing".
Any ideas?

please file this on the vscode repo.


[Synapse]Build & Test failing in nightly runs

Synapse nightly test runs are failing with:

Error message:
Test Run Successful.
Total tests: 100
Passed: 64
Skipped: 36
Total time: 36.4401 Minutes
##[error]The operation was canceled.

For more details check here:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1949410&view=results
@jsquire for notification.

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Synapse:0.3410938,Storage:0.13140008,Azure.Identity:0.10213266'

This package is owned by the service team and has several outstanding test quality issues; closing this as there's no need to accumulate an issue for every test.


Crash Report: Reported element LatexCommandsImpl(COMMANDS)[STUB]{\includegraphics}...

Description
 is not from the file 'LaTeX source file' the inspection 'LatexMissingImport' (class nl.rubensten.texifyidea.inspections.latex.LatexMissingImportInspection) was invoked for. Message: 'Command requires graphicx package'.Element' containing file: LaTeX source fileInspection invoked for file: LaTeX source file [Plugin: nl.rubensten.texifyidea]
Reported element LatexCommandsImpl(COMMANDS)[STUB]{\includegraphics} is not from the file 'LaTeX source file' the inspection 'LatexMissingImport' (class nl.rubensten.texifyidea.inspections.latex.LatexMissingImportInspection) was invoked for. Message: 'Command requires graphicx package'.
Stacktrace
Do not have a stack trace. Do not know if it is a configuration problem
Please paste the full stacktrace from the IDEA error popup

Duplicate of #454. Fixed for b0.6.


Update PostGIS to 3.2.0+

Hi:
As postgis document said:

Enhanced: 3.2.0 srid as an extra optional argument was added. Older installs require combining with ST_SetSRID to mark the srid on the geometry.

Any plan to update the postgis plugin?

It's already 3.3.2 as per https://github.com/supabase/postgres/blob/develop/ansible/vars.yml


Overlay display should show Profile Pic

Let's add the profile picture next to the display name and date of the message on the overlay

Overlay should also display embedded pictures on the right side at full width.
Let's set a max height of 300px for the overlay display and set the background color to chromakey green (#009933)

On the overlay, we should apply the same grid layout for the header that we have in the cards now


MVP 4: Elementary Benchmark Functions

Acceptance Criteria

De Jong test suite
Other common functions: peek at the BBOB suite, or ECJ's ecsuite example.
Docs (with equations and graphs)
Unit tests

Lists of functions I aim to implement before closing this issue:
I need the MFA suite right now for my research, which means I'll be adding these:

Griewank
Ackley
Weierstrass

Then there are two other functions that are common to ecsuite and BBOB:

Langerman
Lunacek

There's plenty more, but if we want to, say, reproduce BBOB completely, etc., in the future, IMO that should be a separate issue.

Ope, I should also add Schwefel's function.  Got it mixed up with Shekel's foxholes for a second, which we already have.

Functions implemented, and their visualization examples all execute and look good, so I'll go ahead and close this.  But I've punted on unit testing for now (the current doctests only get us to 50%).  I've opened a new issue as a reminder to circle back on that later: https://github.com/AureumChaos/LEAP/issues/32


Remove the "pointer" from Zulip, part 1

This does substantial work towards removing the pointer as a concept in Zulip (#8994).  The goal is to get to a place where the server does not send a pointer parameter to clients and they don't send such a parameter to the server, either.
This isn't mergable yet, because:

The commit "pointer: Remove have_initial_messages code." breaks our node tests by making the message_fetch initialization code run the main code path.  @showell I'd love some help in figuring out how we want the ui_init.js tests to proceed here; one option would be to just skip message_fetch in that test; I'm not sure if that makes sense.
I'm not sure what to replace the last two remaining message_fetch references to page_params.pointer with; they appear only in this funny corner case where the home view has no messages in it after the initial fetch.
It needs some manual testing, and maybe some burn-in on chat.zulip.org.

But I'm otherwise pretty happy with this initial series of commits.  Next steps include:

Switching our analytics/ references to look at the "mark message as read" endpoints instead of the pointer endpoints.
Updating docs/subsystems/pointer.md to describe how unread messages work now, and maybe also rename it to unread.md.
Removing the webapp code to send pointer updates to the client (I have a draft commit that I left off this PR).  This will remove 2/3 of pointer.js; the rest (for marking messages as read on message selection) we'll end up moving somewhere more sensible, ideally deduplicating it with the similar code in narrows.
Deleting the fix_unreads management command and Inlining zerver/lib/fix_unreads.py into zerver/migrations/0104_fix_unreads.py so that the code properly lives within the single migration that needs it.
Removing the API endpoints for the pointer
Removing the pointer from events.
Removing the pointer field from the database.

@timabbott Can you update this commit message?
 pointer: Remove have_initial_messages code.

This was implemented in 2012 to avoid showing a loading indicator for
fetching messages for users with no message history.  However, the
Zulip onboarding UI always creates some message history, and fetching
history is fast, so this is likely clutter more than a useful
optimization.

This change results in the frontend tests for ui_init trying to do a
fetch, which is a unit testing mess.  Perhaps the direction I've been
attempting should be discarded and replaced with another approach?

The last paragraph doesn't really make much sense any more.  The commit now simply skips over the message_fetch step, which is fine.

I merged the first 3 commits after a bit more manual testing; so this is just that last commit (which needs work on the testing).  @amanagr can you prioritize this?  There's a bunch of follow-up work that I'd like to get into this release that blocks on it.

I am waiting on #15065 to proceed with tests, which I expect will be merged soon.

@15065 is getting to be a bit complicated; can you at least rebase this on master?

Rebased.

I guess I was a bit wrong, in that we merged #15065.

Fails node tests with this:
https://app.circleci.com/pipelines/github/timabbott/zulip/217/workflows/d19d04cf-cbe5-489b-aff8-4d192a45e732/jobs/1935

@amanagr I turned off CI on my CircleCI branch; hopefully that will make the PR run the build.
I think you should also just swap the order of the commits; the blueslip error commit should be able to be correct without the change to the pointer (and have a real commit message explaining how the case is impossible, etc.).

@timabbott updated this.

Great.  I'm test-deploying this on chat.zulip.org to get more intensive testing on it.

OK, I haven't seen instances of that blueslip.fatal error so far.  The main reason I hadn't merged a few hours ago was the vague concern we might be missing something in our assumptions and those code paths actually happen.  If they happen, they're rare enough that we can debug and fix forward.
Thanks @amanagr!  I'll open an issue for the next steps with removing the pointer more fully.


EJS support

The extension does not support EJS files it shows two error messages as notification in VS code:
"No Bootstrap CSS file was found in the specified paths."
"No Bootstrap CSS found to extract classes from."

Now in the new version you can select the bootstrap version manually yourself


Solution write-higher-order-arrow-functions.english.md

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@TheCaffeineDev, hope you don't mind, but I went ahead and made the changes myself. Thank you for your contribution! :+1: :+1:


runner example for --cloud-metadata

Thoughts on some help tags/examples for users.
for example; in with a GitHub actions example
cml runner ... \
  --cloud-metadata="repo=${{ github.repository }}"
  --cloud-metadata="ActionsRun=https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
  ...

From this, we should also document --cloud-metadata="Key with space=value with space" in https://cml.dev/doc/ref/runner


Perhaps don't change the indentation of raw strings?

Seems to be some kind of style to leave them 0-indented. Not sure if indenting them actually changes the semantics (in which case this would be a bug), but I think not. Not sure if we are making the formatting better or worse here.
         assert_eq!(result.unwrap(),
-r#"digraph single_edge {
+                   r#"digraph single_edge {
     N0[label="N0"];

Indenting them does change the semantics iirc. We should only reindent the first line if it is already indented.

Even the first line? (Indenting subsequent lines does).
Only indenting if already indented is a good heuristic here.

First line is fine.

Closing since on the current master rustfmt changes the indent of the first line of raw string.


no null check on ConnectionAccess.getChannel() causes crash with Create

when used with Create, placing a deployer crashes the game due to the fake networking resulting in a null channel.
https://github.com/Fabricators-of-Create/Create/issues/117

If you look at everywhere Connections are created in vanilla (the static factory methods in Connection, and net.minecraft.server.network.ServerConnectionListener.startTcpServerListener(), you'll see that every returned Connection object is initialized with a channel by the time the method returns. This is also supported by the fact that channel is an un-annotated field in a package Mojang has annotated with FieldsAreNonnullByDefault.
However, this issue has come up before -- see the discussion at https://github.com/gnembon/fabric-carpet/issues/1142. I expect as long as people continue rolling their own fake player systems, we'll see similar issues. Because of that, I think the most appropriate long-term solution to this issue is to get a fake player system added to Fabric API. I'll write up an issue there.

@zml2008 Any luck on that issue you wrote up to FAPI?

Cherry-pick this commit: https://github.com/iczero/adventure-platform-fabric/commit/7bce0fe896c1f7e8900888a901d764f2ae61a760
Rebuild adventure-platform-fabric (./gradlew build)
Copy build/libs/adventure-platform-fabric-<version>.jar into mods folder
Unzip conflicting mods, remove bad version of adventure-platform-fabric from META-INF/jars

Please don't enable bad mod development practices.

I am not a mod developer, only a mod player. I simply wish to use mods without conflicts.


SSL Inspection

I have a use case where App Proxy, it doesn't work with SSL inspection turned on, on my customer's F5.  Is this supported? If we turn it off, it works great. Thoughts?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 048716b1-980b-5de6-06fe-6466a21789f7
Version Independent ID: 48d9d416-b17a-b5f0-1905-8ca4f0035225
Content: Work with existing on-premises proxy servers and Azure AD
Content Source: articles/active-directory/application-proxy-working-with-proxy-servers.md
Service: active-directory
GitHub Login: @daveba
Microsoft Alias: daveba

@mikehall000 Thanks for your feedback! We will investigate and update as appropriate.

@mikehall000 We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.