AttributeError: 'NoneType' object has no attribute 'python_grad_func'

Hello,
I am trying to use Trill module by integrating it with the Keras Sequential model but I am facing an issue and I am not able to resolve it.

This is the error that I am facing.

This is the simple code that I wrote to test the integration of the module with a layer of LSTM and Dense layer. The Trill hub module gives output of [ batch size, time, features ].
I would appreacite if you could help me out with this issue or point me to the right sources so that I can understand the error and resolve it.
Thank you!

@nikunj95,
The code where you load Trill Module is missing. Can you please paste the code instead of Screenshot so that it would be easy for us to copy and reproduce it at our end? Thanks!

Thank you for your reply. Here's the sample code which will help you to reproduce the issue.
`import tensorflow as tf
import tensorflow_hub as hub
import numpy as np
Below code is just to reproduce the error - my X are output from wav file and y are label
X = tf.convert_to_tensor( np.sin(np.linspace(-np.pi, np.pi, 128), dtype=np.float32) )
X = tf.reshape( X, (1, 128) )
y = tf.convert_to_tensor( [1] )
y = tf.reshape( y, (1, 1) )
Load the Trill module into the Keras Layer
module = hub.load( 'https://tfhub.dev/google/nonsemantic-speech-benchmark/trill/3' )
hub_layer = hub.KerasLayer( module, arguments={ 'sample_rate': 16000 }, output_key='embedding', trainable=False )
Model
model = tf.keras.Sequential()
model.add( hub_layer )
model.add( tf.keras.layers.LSTM(100) )
model.add( tf.keras.layers.Dense( 8, activation='softmax' ) )
model.compile(
optimizer='adam',
loss='sparse_categorical_crossentropy',
metrics=['accuracy']
)
model.fit( X, y, epochs=3, verbose=1 )
ERROR-> AttributeError: 'NoneType' object has no attribute 'python_grad_func'`
Hope you can reproduce the error and help me resolve it.

Thanks for the clean repro @nikunj95!
TLDR: It is fixed in tf-nightly pip package and should eventually be in 2.4 when it is released.
Notes:

I verified it reproduces in the latest stable tensorflow release (2.3.1).
I verified it runs in the latest tf-nightly ("2.4.0-dev20201001").


Add dc and rack flags

It would be great to be able to pass in data center and/or rack flags and have those enable the GossipingPropertyFileSnitch and set the cassandra-rackdc.properties file accordingly.

Hmm. That will require a lot of flags. Can you mock up what the commands would look like to bring up a multi-dc cluster?

Are you referring to the command line flags?  I was thinking -name "My Cluster" -dc "DC1" -rack "RAC1" etc.
These two flags, if present, would trigger two configuration file changes:  (1) the two values would be substituted into the "dc" and "rack" values of cassandra-rackdc.properties and (2) the "endpoint_snitch" property in cassandra.yaml would be set to "GossipingPropertyFileSnitch".

This was closed by merging pull request #24 -- thanks for accepting the pull request!


[FEATURE REQ] Get group info from the JWT token.

Currently, aad-starter use OBO flow to access group-membership for the user. This is not required, group membership can be configured part of the token. Need to care about groups overage claim.
To keep compatibility, if groups not contained in token, we still need to get groups by graph api.
Refs:

https://docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-optional-claims#configuring-groups-optional-claims
https://docs.microsoft.com/en-us/azure/active-directory/develop/id-tokens#groups-overage-claim

FYI: https://github.com/MicrosoftDocs/azure-docs/issues/65368

Conclusion:

We should use appRoles in JWT token to create Authorities.
Use groupName to create Authorities is current implememtation. It is not recommended, because groupName is changable. So we should mark azure.activedirectory.user-group.allowed-groups as deprecated.
If our customer still need to use group information to create Authorities, use groupId instead of groupName.

What's the status of this issue @chenrujun? Are we okay to close it now?

What's the status of this issue @chenrujun? Are we okay to close it now?

Closing this issue.

Use groupName as authority is a released function, we can not delete this function.
Save all groupName in JWT is not supported, we can only save groupId in JWT.
Use groupId as authority is a new function, now we do not have plan to support it. If there are a lot of customer need this function, we can develop it in the future.

Closing this issue.

Use groupName as authority is a released function, we can not delete this function.
Save all groupName in JWT is not supported, we can only save groupId in JWT.
Use groupId as authority is a new function, now we do not have plan to support it. If there are a lot of customer need this function, we can develop it in the future.


bufr transformation error: Passed array is too small

The following error was reported by Yasmin from Brazil when ingesting the attached sample:
" 2023-10-30 15:06:37                raise ERROR_MAPerrid
2023-10-30 15:06:37 [2023-10-30T18:06:37Z] {/app/wis2box/handler.py:109} ERROR - Failed to transform file http://minio:9000/wis2box-incoming/bra/inmet/data/core/weather/surface-based-observations/synop/ISAI18_SBBR_300700_CCC.bufr : Passed array is too small"
ISAI18_SBBR_300700_CCC.zip
I've discussed the issue with Dave and will provide a fix.

For users that want to use the fix in wis2box-1.0b5 :
In wis2box-1.0b5/ edit the file 'docker-compose.yml' and replace on line 114
image: ghcr.io/wmo-im/wis2box-management:1.0b5
With:
image: wmoim/wis2box-management:bugfix
Then stop/start wis2box to use the new image


Slider stays on same page if slides items are changed

The subject line may not make sense, but I will try to explain the scenario in detail. See this example fiddle to see the issue in action.
In this demo, initially the slider shows 20 slides (3 per page). The idea is that if you click the button, it will generate a random number, which would be the new number of slides. The code is fairly simple and self-explanatory.
To reproduce the problem,

keep on clicking Next arrow until you reach the last slide.
click on the button that says 'Click' to generate a new random number of slides.

My expectation was that the slide will go back to the first slide but not to stay on the page where it previously was. Even worse, if the new number of slides is lower than the previous number, the user will see a black page with no slides. On clicking Previous error, he/she can go to the previous slides, and everything works normally but the initial display ruins the user experience.
Is there something I am missing to add in the code, or is this a bug?
Thanks,
Abhi.

you could use the slickGoTo prop after changing slides.
I think trying to handle this automatically could get complex (a lot of cases where the currently visible ones don't change but others do)


Docs/add database definitions

Closes #62
@intelhere hope this is what you were asking for! I also added the RLS policies in case you needed them.
I'm really glad you found my project useful! 😊 Just curious—how did you stumble upon it?

Hey @anthony-fdez,
Thank you for creating this PR! Yep, ty for adding the RLS policies too, they are great to learn from!
I stumbled upon your project via GitHub's search bar — I was searching for chat apps that used ReactJS and Supabase, and while there were some projects that did that, they were either incomplete, didn't have proper documentation, or just didn't work. I really liked your project after trying out the demo, and it's well put together + the excellent documentation is the cherry on top!! All of these factors are sweet for learning how they work and what great product's look like!


Add the key of the object to the log context

We don't log what we convert, but only what type it is.
And it's not very useful
So log all the stuff
/assign @dprotaso @mattmoor

PTAL

/lgtm
/approve


Fix slack ssl verification

https://github.com/Yelp/elastalert/pull/2760

According to these (unofficial) Python Requests docs, https://www.w3schools.com/python/ref_requests_post.asp, the verify parameter is indeed expecting a True argument if the intention is to verify certificates. Thanks for the submission.

According to these (unofficial) Python Requests docs, https://www.w3schools.com/python/ref_requests_post.asp, the verify parameter is indeed expecting a True argument if the intention is to verify certificates. Thanks for the submission.


Proposal: reduce size of CI matrix

Can we drop the Ruby versions which are EOLd from our CI matrix?

Definitely! That's good idea 👍

Implemented!


Function as Child Component

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Affected package
<EMAIL_ADDRESS>Steps to reproduce
Create a function as child component w/ some nesting, i.e.
<Foo arr={bleh}>
  {name =>
    <>
      <Bar>
        <Baz>{name}</Baz>
      </Bar>
    </>
  }
</Foo>

Actual behavior
Get a syntax error:

Expected behavior
No syntax error
Runtime
No response
Package manager
No response
Operating system
No response
Build and bundle tools
No response

Thanks for reporting and including a reproduction!
Cross reference: https://github.com/orgs/mdx-js/discussions/2514


Release August 2018 (v2018.08)

Release plan for the v2018.08 version of Saleor.
Prepare new release

[ ] All qualifying changes are merged to master and issues from the current milestone are resolved or moved to future milestones.
[ ] Update the demo branch to include changes from the current release
[ ] Add "preview" note in the new dashboard on demo
[ ] Make sure "readonly" mode and data anonymization works on demo

Release new version

[ ] Tag the master branch with: v2018.08 and push to Github.
[ ] Tag the demo branch with: demo/v2018.05 and push to Github.
[ ] Update master in saleor-demo if necessary.
[ ] Deploy the demo.
[ ] Configure JWT token expiration on demo

Publish release notes

[ ] Prepare screenshots and GIFs showing highlighted features.
[ ] Publish release notes on Github.
[ ] Publish the blog post.

After release

[ ] Update Github roadmap.
[ ] Update getsaleor.com page - link to the latest release and the roadmap.

are any plans to Saleor on Docker Hub (stable + current branches) how part of release?

@mmmcorpsvit We're not planning to tackle that in this release. Most of our efforts are focused on GraphQL API and the new dashboard.

New release is out:

Medium blog post
Github release


APIGOV-20810 - remove max app creds update ard create

I guess the target branch should be APIGOV-20810 instead of main

Yes, thanks


Make inverval and scrapeTimeout configurable on ServiceMonitors

This PR makes the interval and scrapeTimeout fields of the monitoring chart ServiceMonitors configurable.
This aligns with how it is done in the Kyverno chart:
https://github.com/kyverno/kyverno/blob/main/charts/kyverno/templates/admission-controller/servicemonitor.yaml#L25:L26

Hey, thanks for your contribution.
Could you please sign your commit to succeed the DCO?

Missed that, sorry 😄

The failed linting because of the version is fine. I bump the version when I release it.

Sorry for the delay, I released your changes today as 2.19.3


Help with _chunk_state_fwd.

Hello @tridao, first of all, congratulations on the great job you did with Mamba 2. Could you please explain the purpose and operation of the function _chunk_state_fwd function and its kernel?
states = _chunk_state_fwd(B, x, dt, dA_cumsum, seq_idx=seq_idx, states_in_fp32=True)

You can see the reference implementation:
https://github.com/state-spaces/mamba/blob/8ffd905c91d207f5c0cc84fc2a2fb748655094f0/mamba_ssm/ops/triton/ssd_chunk_state.py#L960


Update the commits for OS and OSD

Description
Update the commits for OS and OSD
Issues Resolved
Part of #3230
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #3439 (a91cab2) into main (ac0cfcf) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main    #3439   +/-   ##
=======================================
  Coverage   91.74%   91.74%
=======================================
  Files         172      172
  Lines        4991     4991
=======================================
  Hits         4579     4579
  Misses        412      412

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

The error is related to 2.8.0 manifest error, unrelated to the 2.7.0 changes in this PR.
Merge.


Use expression-bodied members

Replace code braces in properties with expression-bodied members in C# 6.
For example, this:
public static bool IsTraceEnabled
{
    get { return LogLevel.Trace >= LogLevel; }
}

becomes this:
public static bool IsTraceEnabled => LogLevel.Trace >= LogLevel;

thanks again!


mail being sorted according to recipient SMTP address not sender SMTP address

thundersort appears to be sorting mail according to the recipient SMTP address and not the sender SMTP address, which is what we really want.
How can I debug this or see where it is getting the SMTP address to process from?
Example, if my email address is<EMAIL_ADDRESS>and I receive an email from<EMAIL_ADDRESS>with the match rule "(.+)@([^.]+).([^.]+).([^.]+)$" and the replacement regex "$4.$3.$2@$1", thundersort is sorting the email into the folder "uk.co.mydomain@myusername" instead of "net.domain.dodgy@mr-spammer" as expected.

This plugin was originally meant for people using a different E-Mail address for different services. For example I sign up on github with<EMAIL_ADDRESS>and to google with<EMAIL_ADDRESS>- So the plugin does work as intended.
It is however a good suggestion to add support for sorting by sender instead of recipient addresses. - Both modes can be useful.

Ok, thanks so much for your reply. So I guess I misunderstood how it works?
For literally years I have been trying to find a mail client that could automatically move inbound mail to subfolders by sender domain. I was able to write VBA for Outlook to do it, but I have been trying really hard not to keep funding MS.
I remain dumbfounded that to date it appears that absolutely no one has thought to provide this very useful, and I would say very basic, means of organizing inbound mail. But....well maybe you can consider this a feature request then?
I tried working out how to write one my self, but I don't do web-dev so this is all quite out of my depth.
I just want to be able to:

extract the SMPT sender address from inbound mail upon arrival in my inbox, then use the regex (just like you have done) to create the folder name to store that message in, and
run the plugin on existing folders to automatically organize all existing messages the same way as new messages.

That certainly can be done.
I dunno if @networkException has the time for that - I just started school again today so my time is quite limited.
But the idea makes absolute sense - I think it would be a great addition to the plugin

It would be absolute awesome if I could make the username a subfolder to the domain folder. I would be more than happy to do the coding, I just don't know where to look and what to do, I'm sorry.
But thanks so much again...

I've implemented sorting based on senders, I hope this solves your issue.
I submitted a new release to the addon store, if you don't want to wait you can bundle the extension yourself by running the bundle.sh script

Thanks so much.

How long does publishing an add-on take usually?

I don't know sadly


Remove deprecated feature flags

Description
When switching to version 1.0 deprecated feature flags will be removed.
This PR removes them.
Removed feature flags:
dynatracev1beta1.AnnotationFeatureWebhookReinvocationPolicy,
dynatracev1beta1.AnnotationFeatureReadOnlyOneAgent,
dynatracev1beta1.AnnotationFeatureHostsRequests,
dynatracev1beta1.AnnotationFeatureActiveGateAuthToken,
dynatracev1beta1.AnnotationFeatureActiveGateRawImage,
dynatracev1beta1.AnnotationFeatureActiveGateReadOnlyFilesystem,

How can this be tested?

Run operator => nothing should have changed.
Removed feature flags should no longer be taken into account

Checklist

[x] Unit tests have been updated/added
[x] PR is labeled accordingly with a single label
[x] I have read and understood the contribution guidelines

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (fa32fdc) 64.73% compared to head (c18367b) 64.52%.

Files
Patch %
Lines

.../controllers/dynakube/connectioninfo/reconciler.go
50.00%
1 Missing and 1 partial :warning:

pkg/api/v1beta1/dynakube/properties.go
50.00%
1 Missing :warning:

...kube/activegate/internal/statefulset/reconciler.go
0.00%
0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2491      +/-   ##
==========================================
- Coverage   64.73%   64.52%   -0.22%
==========================================
  Files         245      245
  Lines       16252    16190      -62
==========================================
- Hits        10521    10446      -75
- Misses       4930     4939       +9
- Partials      801      805       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Question: Are we then completely removing the use cases of these feature flags?
I'm asking because I'm working on the new Activegate CRD spec, and if so, I shouldn't include these.


CLI doesn't do tab completion of dynamic data

Dynamic data, such as the name of pools, vrfs and so forth should be completed by the CLI tab completion but it isn't working. This is handled by helper-nipap and looking at the code I don't understand how this ever worked :(

Fixed by #845 - closing.


Documentation addon: Flow-Router example

Hi @arunoda
Due to a stackoverflow question today I made a simple MeteorPad for a Flow-Router example.
Maybe you like to add this to your README as a running example.
http://meteorpad.com/pad/Ba5DTe94NjFi3ZTPA/Playground_Flow-Router_Chat
Cheers
Tom

Thanks, We are working on a new guide.
Will add to that.


Feature/installer/catch no vm

Following on from https://github.com/ubuntu/microk8s/pull/1213
After testing on MacOS, seems like the VM check was broken.  Not what changed to broke it, but it's now fixed.

LGTM +1


Signature help

https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#signature-help-request

Hello,
I made a very crude attempt at implementing signature help.
It works well enough for me, but I did not create a PR, because:

To improve resolving I had to open the current file and do some seeking
I had to resort to using some custom token stacking logic on top of the Lexer class in order to find the active parameter which is an ugly hack and not very elegant.

Still, I thought I'd share, some parts may be useful:
https://github.com/vakata/php-language-server/commits/signatureHelp

Open a PR, it's better to discuss it there :)

Please let me know when this feature comes to VS Code?
I think that this feature is a most used feature by developers.
Thanks.

@codewp there's a subscribe button on the right side


Fixed Kafka-Exporter annotations typo

Kafka exporter should check for the value of .Values.prometheus.kafka.enabled instead of the jmx value (.Values.prometheus.jmx.enabled)

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/ok-to-test

/assign @benjigoldberg


Detecting invalid message with two field sizes defined by message size

A message specification where two field sizes are defined by the message size should not be accepted as valid.
package Test is

   type M is
      message
         A : Opaque
            with Size => Message'Size;
         B : Opaque
            with Size => Message'Size - A'Size;
      end message;

end Test;

This will be prevented by #555.

This will be prevented by #555.


Running test with the CLI option --runInBand differ from test.only()

🐛 Bug Report
I'm testing calls to a MongoDB server which runs in a Docker container.  I'm using Mongoose to make the calls and use Jest as a testrunner. In a Jest setup file I make sure that I delete all records from the DB before each test. When I run my tests one-by-one (using test.only()) all my tests work. However, when I run my tests in sequence (--runInBand) only some of my tests succeeds while others fail. This differs from what I expect as I expect all my tests to pass if they pass using test.only(). Is this a bug or am I doing something wrong?
To Reproduce
Steps to reproduce the behavior:

Set up a MongoDB Docker container
Create the following files + code:

package.json (test part):
"test": "jest --watch --runInBand",

jest.config.js :
module.exports = {
  preset: 'ts-jest',
  testEnvironment: 'node',
  coverageDirectory: "./coverage",
  collectCoverageFrom: [
      "./src/**"
  ],
  setupFilesAfterEnv: ["./jest.setup.ts"],
};

jest.setup.ts
import mongoose from 'mongoose';

beforeAll(async () => {
    await mongoose.connect(
        `mongodb://localhost:27017/jestTest`,
        {
            useNewUrlParser: true,
            },
    );
});

beforeEach(async () => {
    await Promise.all(
        Object.keys(mongoose.connection.collections).map(async (key) => {
        await mongoose.connection.collections[key].deleteMany({});
    }),
    );
});

afterAll(async () => {
    await setImmediate(async () => await mongoose.disconnect());
});

Link to repl or repo (highly encouraged)
Update: Added repo
https://github.com/pwrnrd/jest-error-reproduction .
Within the Jest set-up file (jest.setup.ts) I create a connection to a local MongoDB instance. If you don't have MongoDB installed on your machine you can create a MongoDB instance with Docker. To do so, execute the following commands in your CLI:
docker pull mongo:latest
docker run --rm -d -p 27017:27017 mongo

Expected behavior
If a test succeeds when running the test using test.only() the test should also succeed when running all tests with the option --runInBand.
Run npx envinfo --preset jest
    Node: 10.15.3
    Yarn: 1.13.0
    npm: 6.1.0

We'll need a minimal reproduction repo, otherwise there's too many unknowns like mongoose etc and there's no way to know if you're actually experiencing a Jest bug.
But one thing that looks odd to me is
await setImmediate(async () => await mongoose.disconnect());

which I'm pretty sure doesn't wait for anything since setImmediate returns a timer handle, not something you can await.

Please find the reproduction repo here: https://github.com/pwrnrd/jest-error-reproduction .
Within the Jest set-up file (jest.setup.ts) I create a connection to a local MongoDB instance. If you don't have MongoDB installed on your machine you can create a MongoDB instance with Docker. To do so, execute the following commands in your CLI:
docker pull mongo:latest
docker run --rm -d -p 27017:27017 mongo

I hope this helps, I will also update the initial message with the information above.
@jeysal , thank you for pointing that out! I updated my code accordingly.

Thanks for providing this repo. Running with test.only printed a bunch of errors for me:

  console.error node_modules/jest-jasmine2/build/jasmine/Env.js:289                                                        Unhandled error

  console.error node_modules/jest-jasmine2/build/jasmine/Env.js:290
    Error: expect(received).resolves.not.toThrow()

    Received promise rejected instead of resolved
    Rejected to value: [MongoError: server instance pool was destroyed]
        at expect (/tmp/jest-error-reproduction/node_modules/expect/build/index.js:138:15)
        at Object.test.only (/tmp/jest-error-reproduction/src/tests/userDAO.test.ts:45:3)
        at processTicksAndRejections (internal/process/task_queues.js:86:5)

Maybe those are related to the cause of the issues.
It definitely looks more like a problem with the mongoose setup to me than Jest behaving incorrectly. Perhaps you'd be better off asking about setting up mongoose with Jest on StackOverflow or something as we're not experts on that either.
If you manage to isolate an incorrect behavior of Jest itself (e.g. not invoking the beforeEach hooks etc correctly), feel free to open an issue for that though so we can look into it!

Thank you for testing it out! What you're pointing out is part of the problem, because Jest still indicates that this test passes, eventough the logs indicate it failed (see Image 1).
When I run the first test using test.only I receive the same error. However, I do not receive this error when I run all tests, which is add odds with the test.only result. In addition, all other test run using test.only succeed, while they fail if they are run together (see Image 2).
Image 1: run only results

Image 2: run all tests results:

@pwrnrd Oh well that part is simple - you need to await expect(something).resolves.toSomething();. Otherwise it just causes an uncaught error after the test has finished.

@jeysal thank you very much! I expected these functions .resolves and .rejects to be synchronous. As you indicate, they are not. For my understanding of Jest, is this is what happened?

Jest runs the first test. Since I'm not awaiting the resolved value, Jest continuous and runs the next test.
Jest fires beforeEach() before running the next test. However, since the request of the the first test is still in-flight, there is no way of telling that the actual database is empty, because the insert into the database, triggered by the first test, might arrive after the database has been cleared by the beforeEach call.

Is this what happens or am I missing something?

Can't tell you what exactly causes all the failures (e.g. if the unhandled promise rejections occurs while an unrelated test is running it'll probably make that test fail as well), but yeah the DB operations could pretty much happen at any time while any other test case may be running

@jeysal I'm trying to figure out if the issue is the same in my case. Tests pass but I get some extra errors before:

Script being run is here https://github.com/TrainingByPackt/Professional-JavaScript/blob/master/Lesson06/exercise08/result/tests/calc.test.js


Hardsuit light battery dies super quickly, and makes it close to useless.

Reported by @"Herbert Falsevor#3037"

Should hardsuit battery be a different entity if it can be removed? Instead of putting the biggest small cell in and science removing it for research.
Otherwise can buff it and make it non removable but slowly self charges. Thoughts?

Should hardsuit battery be a different entity if it can be removed? Instead of putting the biggest small cell in and science removing it for research.
Otherwise can buff it and make it non removable but slowly self charges. Thoughts?

I think you should do the 2nd option for now.

Will add it to my to do when I'm next free


chore: bump otel replace deprecated metricglobal

mainly address https://github.com/open-telemetry/opentelemetry-go/pull/3829

Hi @mahboubii, thanks for the PR.
This PR includes the otel v1.15.0-rc.2. I am not sure we need to include a release candidate.

Closing 👍


.finally() promise for $http throwing error on android 2.3

bug - angular 1.2.29 - 1.4.9 on android 2.3.6
using $http, the promise then() works as expected, but promise finally() throw error and stop angular from parsing the html.
bug - angular 1.5.3 on android 2.3.6
angular not working at all.

You mean if you are doing something like this:
myPromise.then(function() {}).finally(function() {})

That's because finally is a reserved keyword on Android 2.3. Try the bracket notation instead: ['finally'].


Set TWITTER_OAUTH_KEY and TWITTER_OAUTH_SECRET in your environment to use Twitter Agents.

The above is displayed every minute in the logs. I don't even have any twitter related agent configured / running.
I have yet to understand why Twitter is so important for Huginn it even assigns an own thread for it, even if no Twitter Agents are being used.

So you don't have any Twitter-related Agents at all?  This would be nice to fix.

No I don't, I even moved Agents I don't use out of the ./app/models/agents/ directory, in order to shorten the scrollable list which I need when I create a new agent (yes, I know I can also enter a search term).

@dsander, I think you mentioned something about it printing that more often than it needed to in a different thread?

@cantino Right, totally forgot about that, added it to the list for the weekend :smile:

Let me know if I can help.


Quota increase request

Quota Increase Request
Quota to Increase:
I'm testing this out on my own personal website with my personal azure account. Setting up the service on CI I seemed to make a mistake with the working directory. Still not sure what it should be but what I put was wrong and tests failed. Reverting back to using shards instead of service and tests passed. This mistake used up all my billing minutes and was charged €3.68 for tests that failed due to a bad configuration. It means my trial is now over and can't continue to test the service.
In image below bottom one was running the service with CLI and top one was on CI which I had to cancel workflow as it was taking so long and just failing.

Using<EMAIL_ADDRESS>for azure account.
workspace is called testservice
so two things - how do I get the service to actually work and how do I test the service without being billed?
repo with what went wrong is here:
https://github.com/debs-obrien/debbie.codes/pull/454/commits/7c9c49e4a36f86d492853c66230cf4a8e6827923
[Specify which quota you would like to increase]

[ ] Maximum number of workers for the workspace
[ ] Maximum number of workspaces per subscription
[ ] Throttling limits
[ ] Other

Business Justification:
[Please provide a detailed business justification for the quota extension. Explain why this increase is necessary for your project or use case.]
Requested New Quota Limit:
[Specify the new quota limit you are requesting. Please be specific about the quantity or value (e.g., 60 workers per workspace, 5 workspaces per subscription etc.).]
Additional Information:
[Include any additional information that may be relevant to your request, such as project deadlines, the impact of the quota increase on your work, etc.]
Setup Information:

Subscription ID: [Your Azure subscription ID]
Workspace ID: [ID of the workspace where you want to request quota increase]

Disclaimer:
Please note that while we will do our best to accommodate your quota extension request, we may not be able to fulfill every request due to resource constraints. We will review your request and provide a response as soon as possible.
AB#1905525

Hi @debs-obrien I forked your repo and able to repro the issue and able to make it working here is the PR https://github.com/debs-obrien/debbie.codes/pull/456
Test failure reason

Timeouts getting browser: Due to workflow trying to get 80 workers whereas quota is only 20 hence timing out after 30s
5s timeout during action: Service we have more workers trying to access localhost from CI machine, individual operations can sometime takes more time, hence we need to increase timeout
I played with your suite, and it seems like 8-12 worker is right tuning as we wont see much benefit going beyond it. Generally, this depend upon multiple factors like load on CI, webapp load

PS: I observe few tests are flaky even in local mode as well.
Let me know if you need help. We could increase your quota to high value if still needed.

Hi @debs-obrien, if the causes identified by @puagarwa didn't resolve your issue, please let us know. Closing this for now.
We appreciate your feedback regarding the possibility of failed test runs consuming your free trial minutes. In response, we're updating our documentation to better guide first-time users. As a new user, we recommend starting with a small number of tests to confirm that your configuration works correctly before scaling up to more extensive testing. This approach will help build your confidence in using the service.
Additionally, if you encounter any issues or concerns with billing, you can create a support ticket in the Azure Portal. The following steps will kick off the process:

Go to https://aka.ms/mpt/help-and-support
Click Create a support request
For Issue type, select Billing.


GitLab public repository support

This allows berks-api to scan GitLab repositories and index
them if they public.
It requires the :uri downloader in berkshelf v3.0.0beta8 or newer.
Closes #84

There is a patch https://github.com/berkshelf/berkshelf-api/pull/181 to this fork, that change gitlab "location_type" from :uri to :gitlab and works with both public and private repositories

This would be great! Hoping I can take the time to test this soon.


Not working

I downloaded the latest dev version for kcauldron and installed on my server, on the first time it appeared to be running fine but I tested only by few seconds alone on the server, then I tried to create a group to prioritize cars and vehicles from MCHeli and Vehicular Movement mods over other entities, so I changed the config file and restarted the server, but when the server restarted it was unplayable with an massive amount of lag and I was alone on the server exactly as my first contact, so I removed the blocks that I added to the config and rebooted the server again but the problem persisted. I tried to delete the config file, re-upload the mod JAR and reboot many times but the problem seems to be getting worst every time I restart the server....

I don't know why it was soo smooth on the first time and now it's just unplayable.

The tick time seems to be increasing if I leave the server running on this condition...

Turns out it caused a corruption in one mod that I don't know yet because the problem persisted after I removed TickDynamic from the mods dir, I'm going to investigate what happened exactly and I'll update this issue when I have more information.

Turns out it caused a corruption in one mod

Which mod exactly? the hash value of the mod that is on your server? (for both tickdynamic and this "corrupt" mod?
Did you actually read the release notes and set the values of max-tick-time for both ``tile&entityto1000within spigot.yml`?

Hey, thank you for taking the time to describe the problem you have =)
Looking at the first screenshot you provided, it seems that the lag happens not at any one Entity or TileEntity, as it seems to only allocate 1,88 ms(Should be much higher) to Overworld.
This tells me that there is something outside the ticking of Entities/TileEntities which is causing the lag.
It might be as you said, some corruption which uses time outside the normal ticking loop.
Were there any noticeable errors or unusual log output when you first added the TickDynamic groups which caused the problem?
Could you maybe paste the latest log on pastebin or something, and link it here?
Would it be possible for you to send me the world(And mods/config folder), or is the world too big?
If you can't send it, can you try backing up the world(Completely) and removing the mods MCHeli & Vehicular Movement(Try removing one at a time with a restart each) and see if that fixes the lag.
This would allow me to more accurately pin down what causes the problem. It seems that since it worked fine before you added that group, that it is in one of these mods.
Thank you for your time =)

Hi, the world has over 8 GB, it's too big.
The release notes didn't mention about max-tick-time:

The problem seems to be with Applied Energistics, it seems to be adding Callable objects on a queue.

The group sections that I added to the config doesn't seems to be the cause of the issue because I restored an earlier backup and I tried to the TickDynamic mod again with default configs and the lag problem started again.
I'm going to do more tests until I find the exact steps to produce this problem.

Yeah, I don't think I mentioned max-tick-time in the dev releases, but that doesn't seem to be the problem here.
I don't think the problem is with Applied Energistics, as that only seems to be what is causing a chunk to load. The problem seems to be in the NBTTagList. Most likely something was corrupted during the writing of NBT data for a block, entity or even the chunk itself, causing it to spend a lot of time trying to read the data.
This does indeed seem like a serious problem, but I'll have to dig deeper into it to figure out what TickDynamic could have done to cause it. The mod should have nothing to do with the reading or writing of NBT data at all.

There was always a known issue with rv2 that was fixed in rv3 in regards to
a ME drive cycling loading of the chunk it's in over and over.
Which version of AE2 is being used?
On 02/02/2016 6:29 PM, "wildex999"<EMAIL_ADDRESS>wrote:

Yeah, I don't think I mentioned max-tick-time in the dev releases, but
that doesn't seem to be the problem here.
I don't think the problem is with Applied Energistics, as that only seems
to be what is causing a chunk to load. The problem seems to be in the
NBTTagList. Most likely something was corrupted during the writing of NBT
data for a block, entity or even the chunk itself, causing it to spend a
lot of time trying to read the data.
This does indeed seem like a serious problem, but I'll have to dig deeper
into it to figure out what TickDynamic could have done to cause it. The mod
should have nothing to do with the reading or writing of NBT data at all.
—
Reply to this email directly or view it on GitHub
https://github.com/wildex999/TickDynamic/issues/25#issuecomment-178422899
.

I have tried to replicate this, placing a large AE2 network over multiple chunks, and then unloading/reloading the chunks. Nothing yet =/
What version of kCauldron do you use?

For the sake of testing remove tick dynamic fully reset configuration files wipe world and start a new test instance. If the issue persists then it's not a tick dynamic issue and this issue should be closed.

I have released development version 3 now, do you think you could try using that and see if it still corrupts the world?
https://github.com/wildex999/TickDynamic/releases

@wildex999 It worked fine with that version


Calls don't work

A connection seems established, but there is no audio during the call.

Sorry. This is a telegram bug. They are working on this.

@schors can you tell about it? I've never heard about this.

No. I can't

docker ps -a
docker stop tgdante
docker cp :/conf/dante.conf .
Add:
socks pass {
from: <IP_ADDRESS>/0
to: <IP_ADDRESS>/0
# udp.portrange: 40000-45000
command: udpassociate
log: error connect disconnect
}
socks pass {
from: <IP_ADDRESS>/0
to: <IP_ADDRESS>/0
command: udpreply
log: error connect disconnect
}
Save:
docker cp dante.conf :/conf/dante.conf
docker start tgdante
Add Iptables rules:
-A INPUT -p udp -m multiport --dports 40000:45000 -j ACCEPT
Save:
Complete!

@SatoshiNakamotoOfficial's solution works for me. There also was a bug in libtgvoip that prevented TCP fallback and I've fixed that recently. The fixed library is already in the Android app, and other apps will follow soon. While sending voice over TCP isn't generally a great idea, sometimes it's better than nothing.


add supported cryptographic primitives

Signed-off-by: Kyle Den Hartog<EMAIL_ADDRESS>

Ahh I broke the DCO when I committed the suggestion. Will get that fixed today.

DCO is fixed now.


SDK diff tests not triggered for failing VMR release builds

The SDK diff tests are now getting triggered on every VMR release build. If the said VMR build fails, the tests do not get triggered. This is a regression from how they used to behave before the trigger change, where the pipeline would run regardless of the latest build succeeding or not.
A potential issue here is that the VMR pipeline run consists of multiple different builds and there could be value in running the tests for those that did succeed even if the run itself fails. This could be done with either trying to limit the trigger to just one stage (like the Tag & Scan one) or falling back to triggering the tests from the VMR build.
CC: @MichaelSimons

[Triage] We believe the pipeline trigger is the better approach over a scheduled trigger.  If the pipeline fails and you want to run the sdk diff off of the failed build, you can queue it manually.  Closing as won't fix.


API Documents tab - React UI Components in Publisher

API Documents add/edit/view/delete support via React UI components

Fixed with  wso2/carbon-apimgt#4270 , wso2/carbon-apimgt#4295 , wso2/carbon-apimgt#4310
, wso2/carbon-apimgt#4352 ,wso2/carbon-apimgt#4387


Any/Nothing kills compiler

While playing with this stuff, I did something, which naturally does not work, but the issue is that it also kills the compiler . It's very simple to isolate:
build.sbt:-----------------
scalaVersion := "2.11.5"
libraryDependencies += "com.lihaoyi" %% "upickle" % "0.2.6"
------------------------------
object T {
  def foo(a:Any):String = {
    upickle.write(a)
  }
}
------------------------------

If I change it to foo(a:AnyRef), I get "Don't know how to pickle AnyRef; it's companion has no apply method", which is sensible, but with a:Any, the compiler churns forever.

Turns out that Any somehow gets passed to the macro as Nothing (???) and causes the same problem. It's some weird interaction with the implicits which causes this...

Fixed in master; it continues to loop forever, but now at least it makes noise when it does so


Default deploy directory on input

Changes
When calling the command to set the deploy directory without a path, set the default in the user input.
Checklist

[ ] have tested my change
[ ] updated relevant documentation
[ ] Remove any/all console.logs I added
[ ] eslint is not complaining
[ ] have added myself to the contributors' list in CONTRIBUTING.md
[ ] for feature PRs: PR only includes one feature enhancement.

Next step for this PR is to determine the best way to get the user's home directory. Converting to draft for now.

Looks like Seb actually solved in the tar re-write.


Additional Features: Type Hints, Lazy Evaluation, New Top Level Interfaces

What does this PR do?

adds some stubs to the underlying decorator that should help with type hinting in VSCode (via pylance/pyright).

changed packaging to reflect the stubs and partial type info

Additional interfaces to spock that make more sense:

ConfigArgBuilder --> SpockBuilder -- Can now be imported from top-level
@spock decorator now importable from the top-level
from spock import spock
from spock import SpockBuilder

Lazy Evaluation

the @spock decorator now has a boolean flag  that allows inherited classes to not be @spock decorated -- will automatically cast parent classes to a spock class by traversing the MRO

the ConfigArgBuilder now takes a  keyword argument that will attempt to lazily handle dependencies between @spock decorated classes thus preventing the need for every @spock decorated classes to be passed into *args within the  method

Checklist

[ ] Did you adhere to PEP-8 standards?
[ ] Did you run black and isort prior to submitting your PR?
[ ] Does your PR pass all existing unit tests?
[ ] Did you add associated unit tests for any additional functionality?
[ ] Did you provide documentation (Google Docstring format) whenever possible, even for simple functions or classes?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

78 of 93 (83.87%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 94.344%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

spock/addons/tune/config.py
8
9
88.89%

spock/backend/config.py
40
42
95.24%

spock/graph.py
16
28
57.14%

Totals

Change from base Build<PHONE_NUMBER>:
-0.5%

Covered Lines:
1668

Relevant Lines:
1768

💛  - Coveralls


Withdrawal transaction should use fee estimator

I emptied my wallet, but the fee is 0.00001 so it is taking too long to confirm.
At the time of writing bitcoin-cli estimatefee 1 returns 0.00077821 which is 77 times greater.
It would be great if Lighthouse could use the fee estimator so that transactions get into the next block.

The Bitcoin Core fee estimator produces garbage results, so the 77x figure doesn't mean much.
When you say "too long to confirm" how long was too long. How long did it take, in the end and how long did you want it to take?

It took 204 minutes: https://blockchain.info/tx/186e706ac5f8ce7ebbf4947b0da5174b578d71fa0f4c0da9ddd9929665cf2df7
I wanted it to be in the next block.
Do you know when the estimator will be working correctly? Are we supposed to round up the size to the next kilobyte boundary before multiplying by the fee?

The fee paid on that tx is identical to the fee paid on the two input txns, which confirmed much faster. I think the issue here is that the previous blocks were either abnormally large (i.e. they hit the 1mb limit) or abnormally small, so the Bitcoin network itself was hitting capacity. When that happens some people have to wait until block space frees up. Unless you had some extremely pressing need for the transaction to confirm immediately, you would have had to attach a much larger fee to try and outcompete other people in the next block and if we wallet authors just keep adjusting the default fee upwards, other people would also start paying more simultaneously, so it wouldn't make much difference (this is a slightly theoretical argument but you get the idea).
In the future we'll have sliders to let people pick how much they care about confirming soon, but really, the solution here is to raise the block size limit. There's no other solution that makes everyone happen.

Closing this as a duplicate of issue #46

Thanks for the info!


httplib.HTTPException: got more than 100 headers

When I run this command:

python google-images-download/google_images_download/google_images_download.py --keywords "blood moon" --print_urls --limit 300 --chromedriver ./chromedriver --o blood-moon --format jpg

I eventually get the following error (around image 141):

Completed Image ====> 141. b5ba5723-c77a-45af-b1d9-fc7035eed1b1-getty-490376722.jpg
Image URL: http://www.latimes.com/resizer/98_OZySBlPPTMdmxqUBRwqMVi-o=/1400x0/arc-anglerfish-arc2-prod-tronc.s3.amazonaws.com/public/X3ES6TPM5FDVBEOZ4UFQCKX2QE.jpg
Traceback (most recent call last):
File "google-images-download/google_images_download/google_images_download.py", line 792, in
main()
File "google-images-download/google_images_download/google_images_download.py", line 784, in main
response.download(arguments)
File "google-images-download/google_images_download/google_images_download.py", line 742, in download
items,errorCount = self._get_all_items(raw_html,main_directory,dir_name,limit,arguments)    #get all image items and download images
File "google-images-download/google_images_download/google_images_download.py", line 631, in _get_all_items
download_status,download_message,return_image_name = self.download_image(object['image_link'],object['image_format'],main_directory,dir_name,count,arguments['print_urls'],arguments['socket_timeout'],arguments['prefix'],arguments['print_size'])
File "google-images-download/google_images_download/google_images_download.py", line 518, in download_image
response = urlopen(req, None, timeout)
File "/usr/lib/python2.7/urllib2.py", line 154, in urlopen
return opener.open(url, data, timeout)
File "/usr/lib/python2.7/urllib2.py", line 429, in open
response = self._open(req, data)
File "/usr/lib/python2.7/urllib2.py", line 447, in _open
'_open', req)
File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
result = func(*args)
File "/usr/lib/python2.7/urllib2.py", line 1228, in http_open
return self.do_open(httplib.HTTPConnection, req)
File "/usr/lib/python2.7/urllib2.py", line 1201, in do_open
r = h.getresponse(buffering=True)
File "/usr/lib/python2.7/httplib.py", line 1136, in getresponse
response.begin()
File "/usr/lib/python2.7/httplib.py", line 485, in begin
self.msg = HTTPMessage(self.fp, 0)
File "/usr/lib/python2.7/mimetools.py", line 25, in init
rfc822.Message.init(self, fp, seekable)
File "/usr/lib/python2.7/rfc822.py", line 108, in init
self.readheaders()
File "/usr/lib/python2.7/httplib.py", line 312, in readheaders
raise HTTPException("got more than %d headers" % _MAXHEADERS)
httplib.HTTPException: got more than 100 headers

Any suggestions?

@jaredjohansen Not sure whats causing this exception. I will test this out later today and revert back. Can you tell me if you are:

on OSX or Linux?
does this happen on all the queries? or is this just intermittent?

I am using Linux (Ubuntu 16.04).
This happens intermittently.  Of the ~100 queries I've used, it only happened twice.  The first one went away the second time I used it.  The example provided above was repeatable.  I believe it occurred 3x.
No, I am not (knowingly) setting _MAXHEADERS anywhere in my environment.

@jaredjohansen sry for the delay. I have made some improvements in the lib so you should not see this error. I am not closing both the request as well as the file descriptor.
But if you do see this error after installing the latest version of this lib, do let me know.
closing this for now.

Hardik,
Haven’t seen anything.  If it pops up again, I’ll let you know.
Thanks for your great support!
Jared
From: Hardik Vasa<EMAIL_ADDRESS>Sent: Saturday, May 12, 2018 7:06 PM
To: hardikvasa/google-images-download<EMAIL_ADDRESS>Cc: jaredjohansen<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [hardikvasa/google-images-download] httplib.HTTPException: got more than 100 headers (#85)
@jaredjohansenhttps://github.com/jaredjohansen sry for the delay. I have made some improvements in the lib so you should not see this error. I am not closing both the request as well as the file descriptor.
But if you do see this error after installing the latest version of this lib, do let me know.
closing this for now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/hardikvasa/google-images-download/issues/85#issuecomment-388589396, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWX_Wb1xUwTzZPhEpE9PX_ymySM7TJMeks5tx2rXgaJpZM4ThuIL.


uv_buf_t size faulty on windows?

Hey guys, I was looking at the code of kestrel, in particular here: https://github.com/aspnet/KestrelHttpServer/blob/dev/src/Microsoft.AspNetCore.Server.Kestrel/Internal/Networking/Libuv.cs#L431
And I wondered, isn't sizeof(WSABUF) on windows 8/12 for 32/64 bit systems?
WSABUF consists of ULONG and a pointer, a ULONG according to http://stackoverflow.com/questions/384502/what-is-the-bit-size-of-long-on-64-bit-windows it is 4 bytes (or uint) even on 64bit windows.
I looked at the reference source code, and it seems to be a (int, intptr) too: http://referencesource.microsoft.com/#System/net/System/Net/_OSSOCK.cs,29
corefx: https://github.com/dotnet/corefx/blob/master/src/Common/src/Interop/Windows/Winsock/WSABuffer.cs#L12-L13
How is the current definition of uv_buf_t working on windows?

Alignment. There's 4 bytes of padding in WSABUF after len so buf is aligned to an 8-byte boundary.

What does the alignment?

A struct member will normally start at an address that matches it's alignment requirement. On 64-bit the pointer should be 8-byte aligned. Since the preceding member takes 4 bytes, the compiler inserts 4 bytes of padding after it so that buf starts at an 8-byte boundary.
Some code:
#include <WinSock2.h>

int main()
{
    WSABUF buf;
    printf("sizeof(WSABUF): %d\n", sizeof(WSABUF));
    printf("sizeof(WSABUF.len): %d\n", sizeof(buf.len));
printf("sizeof(WSABUF.buf): %d\n", sizeof(buf.buf));
    printf("WSABUF.len: %p\n", &buf.len);
    printf("WSABUF.buf: %p\n", &buf.buf);
    return 0;
}

Output:
sizeof(WSABUF): 16
sizeof(WSABUF.len): 4
sizeof(WSABUF.buf): 8
WSABUF.len: 000000475A7FF6C8
WSABUF.buf: 000000475A7FF6D0

So the jit does the same for this?
    [StructLayout(LayoutKind.Sequential)]
    internal struct WSABuffer
    {
        internal int Length; // Length of Buffer
        internal IntPtr Pointer;// Pointer to Buffer
    }

StructLayout(LayoutKind.Sequential) means maintain the order otherwise it may swap the two fields for tighter packing.
StructLayout(LayoutKind.Explicit) is for exact specified positioning when you additionally have to use FieldOffset attributes on the fields to specify their positions; and they can be overlapped for example in EventDescriptor

@txdv Yes:
[StructLayout(LayoutKind.Sequential)]
struct WSABuffer
{
    internal int Length; // Length of Buffer
    internal IntPtr Pointer;// Pointer to Buffer
}

class Program
{
    static unsafe void Main(string[] args)
    {
        var s = new WSABuffer();
        int* pLength = &s.Length;
        IntPtr* pPointer = &s.Pointer;
        IntPtr addrLength = (IntPtr)pLength;
        IntPtr addrPointer = (IntPtr)pPointer;

        Console.WriteLine(addrLength.ToString("x"));
        Console.WriteLine(addrPointer.ToString("x"));
    }
}

Output:
f3c1ffebc0
f3c1ffebc8

You are my hero!
Thank you very much.


add Bifrost Kusama

Hi! I'll check if that CLA is available and get back to you then! But it looks good for the other parts!


The style tag is empty at all

Hello
As far as I understood this plugin, all happens in the addStyle function, so it reads the rules and if this regex is false if (!(/^\s*@charset/i).test(rule)) { then it adds the rule
And that's the issue, because I have a CSS in which all the rules are passed by true, therefore no rule is passed on, and therefore the style tag remains empty

You're right, it is a bug. I found esifycss serializes @charset to wrong form. I'll fix it in https://github.com/kei-ito/esifycss/pull/105.
Thank you for your report!

I published v1.4.25 includes the fix. Please check it and open another issue if there's still a problem.


Support nested image paths

Changes

Support nested image paths

/kind bug
Fixes #398

@senthilnathan nice thanks! Do you think that you can add a test case for image path parsing?


[Bug]: Attempted import error: 'PineconeVectorStore' is not exported from 'llamaindex'

Bug Description
Attempting to construct PineconeVectorStore and running into an issue. On Typescript. Any help is much appreciated!
Here's my code:
import {
  Document,
  VectorStoreIndex,
  OpenAI,
  Settings,
  PineconeVectorStore
} from "llamaindex";

const pineconeVectorStore = new PineconeVectorStore({
  indexName: "defiai"
});

Here's my error:
./src/app/api/generate-answer/route.ts
Attempted import error: 'PineconeVectorStore' is not exported from 'llamaindex' (imported as 'PineconeVectorStore').

Import trace for requested module:
./src/app/api/generate-answer/route.ts

 ✓ Linting and checking validity of types
   Collecting page data  ..TypeError: eG.PineconeVectorStore is not a constructor

Version
"llamaindex": "^0.7.0",
Steps to Reproduce
Attempt to construct PineconeVectorStore
Relevant Logs/Tracbacks
No response

@dosu are you sure that's the import statement for typescript?

No i don't think that's right

@dosu that returns an import error. Are you sure this is the right import from Typescript? The documentation returns import {PineconeVectorStore} from 'llamaindex'


[Feature request] Loading List

Would be good to have a loading list.
it would be nice if one could go to, for example, YouTube and create a list of videos one wants to see
Similar feature is available in Mozilla's (soon to be disabled) Min Vid

Sorry, if you need full feature for playlist management ( UI that support add/delete/sort/share etc.), you should install Min Vid. Min Vid is a complicated add-on that MANY contributors work on it for two years (support youtube/vimeo/soundcloud).
If you open PopupVideo from youtube playlist, the PopupVideo will play all video in the list one by one.
PopupVideo is an lite weight add-on for watching video, I only provide the most basic feature on it.
I create PopupVideo because I don't need some functions that Min Vid provided.
Thank you.

I was not aware that opening PopupVideo from youtube playlist, the PopupVideo will play all video in the list one by one.
that will do the trick ;)
Still, would be good to add that trick in the addon's description.
thank you :D


[DO NOT MERGE][stdlib] Collection: switch to using '<' instead of '==' in some loop termination conditions

Note: This is just an experiment; we may well end up solving this problem in another way, or leaving it as is for now.
IndexingIterator.next(), Collection.distance(from:to:) and Collection.index(_:offsetBy:limitedBy:) algorithms currently use i != end as their termination condition. This works great when the indices are valid in the collection they run on, but it leads to unterminated loops in cases where a Collection type allows (or even encourages) substricting by index values that aren't members of indices.
Unfortunately we have a small handful of types in the Standard Library that encourage such sloppy indexing -- the big one is String, whose various encoding views all use the same Index (since SE-0180), but there isn't necessarily a one-to-one mapping between indices of one view and the next.
let s = "💩Cafe\u{301} Banana" // "💩" is encoded in four bytes, "\u{301}" is encoded in two

let start = s.utf8.index(s.startIndex, offsetBy: 2)
let end = s.utf8.index(s.startIndex, offsetBy: 8)

In this case, start and end aren't strictly valid in the regular String value (as they point to the middle of the "💩" emoji and to the second Unicode scalar of the decomposed "é" grapheme cluster, respectively), but String still sort-of-kind-of accepts them:
print(s[start]) // "💩"
print(s[end]) // "\u{301}" a.k.a. "́"
print(s[start ..< end]) //  "💩La Cafe", note no acute accent

The behavior seems to be somewhat sensible -- the indices are rounded to down to the nearest Unicode Scalar boundary, then a substring is constructed out of that.
However, this illusion breaks down when we iterate through the substring:
for c in s[start ..< end] {
  print(c)
}

// 💩
// C
// a
// f
// é
// Swift/Collection.swift:711: Fatal error: Out of bounds: index >= endIndex

for i in s[start ..< end].indices {
    print("Character: \(s[i]) Index: \(i)")
}

// Character: 💩 Index: Index(_rawBits: 1)
// Character: C Index: Index(_rawBits: 262401)
// Character: a Index: Index(_rawBits: 327937)
// Character: f Index: Index(_rawBits: 393473)
// Character: é Index: Index(_rawBits: 459521)
// Swift/Substring.swift:165: Fatal error: Cannot increment beyond endIndex

This is rather surprising. The issue is that Substring and DefaultIndices both use IndexingIterator as their iterator type, and IndexingIterator.next() is defined to stop when _position == _elements.endIndex. Because _elements.endIndex falls in between two reachable indices, the condition never triggers and we run off the end of the substring, skipping over our endIndex. Worse, the entire final grapheme cluster "é" is returned as if it was part of the substring, which it isn't, accoring to how the substring is printed.
Similar issues can be found when calling distance(from:to:) or index(_:offsetBy:limitedBy:). Besides String, LazyFilterCollection also suffers from similar index sharing issues with the base collection, although the expectations aren't that well documented there.
Now in String's case, we could choose to catch this and trap when the substring is created with these iffy indices; however, SE-0180 rejected this approach in favor of this passage:

With respect to subscripts, an index that does not fall on an exact boundary in a given String or Substring view will be treated as falling at its encodedOffset in the underlying code units, with the actual contents of the result being an emergent property of applying the usual Unicode rules for decoding those code units. For example, when slicing a string with an index i that falls between two Character boundaries, i.encodedOffset is treated as a position in the string's underlying code units, and the Characters of the result are determined by performing standard Unicode grapheme breaking on the resulting sequence of code units.

However, iterating through a substring with such irregular bounds therefore ought to behave as if we were iterating over a string composed of the same code units -- the current behavior is clearly violating this by overrunning the end index.
(A strict reading of this passage implies that s[start] should return the replacement character "\u{FFFD}", as it attempts to read an invalid (partial) sequence of UTF-8 code units. This does not seem desirable to me; the current rounding-to-nearest-scalar behavior is very likely to be more useful in practice. We can't really split scalars without violating String's fundamental invariant that its underlying encoding must always be valid, so rounding to the nearest scalar boundary is the best we can do.)
This PR updates IndexingIterator.next() and the default implementations of Collection.distance(from:to:) and Collection.index(_:offsetBy:limitedBy:) to compare indices using < instead of == in their termination conditions, thereby resolving this subtle issue. (Another potential benefit is an (anecdotal) code gen improvement in some integer-indexed collection types -- < seems to enable better code analysis in some cases.)
One huge potential drawback is that 'Index.<might be much slower thanIndex.==-- for example, a hypothetical collection type that implements a classic linked list (likestd::listin C++) would likely have an O(n)Index.<implementation while==` would take constant time. This does not seem like a strong enough objection to me -- linked lists aren't that practical (or popular) these days, and it doesn't seem too much of a burden for such collection types to provide custom iterator / index navigation implementations. (After all, they will need to deal with far trickier issues like ARC stack exhaustion while destroying long lists.)
(There are no such performance issues with more practical Collection implementations, such as tree-based containers.)
Tweaking the implementation of such basic functions can also turn out to be source-breaking (or even ABI-breaking) enough that we won't be able to ship this change. In that case, it might be worth special casing String.Index in the implementation of these methods.
rdar://88705758

@swift-ci test

@swift-ci benchmark

(Sadly I don't expect this would uncover anything that this might break)
@swift-ci test source compatibility

Build failed
Swift Test Linux Platform
Git Sha - 86bac5514943bba311e8ee6d186f58228c10713a

Performance (x86_64): -O

Regression
OLD
NEW
DELTA
RATIO

DropLastArray
11
17
+54.5%
0.65x

DropLastArrayLazy
11
17
+54.5%
0.65x

PrefixArrayLazy
35
52
+48.6%
0.67x

MapReduceAnyCollection
137
194
+41.6%
0.71x

MapReduce
139
196
+41.0%
0.71x

MapReduceClass2
15
20
+33.3%
0.75x

DropWhileArrayLazy
82
105
+28.0%
0.78x

XorLoop
381
477
+25.2%
0.80x

PrefixWhileArray
88
105
+19.3%
0.84x

ReversedArray2
171
200
+17.0%
0.86x

LazilyFilteredArrayContains
14500
16400
+13.1%
0.88x

StringComparison_ascii
649
729
+12.3%
0.89x (?)

Walsh
336
377
+12.2%
0.89x (?)

ReversedDictionary2
315
346
+9.8%
0.91x (?)

DictionaryBridgeToObjC_Access
956
1048
+9.6%
0.91x (?)

UTF8Decode_InitDecoding
188
203
+8.0%
0.93x (?)

Improvement
OLD
NEW
DELTA
RATIO

AngryPhonebook.ASCII2
188
88
-53.2%
2.14x

SequenceAlgosRange
3140
1880
-40.1%
1.67x

StringEqualPointerComparison
228
171
-25.0%
1.33x

LazilyFilteredRange
3410
2610
-23.5%
1.31x

Sim2DArray
800
614
-23.2%
1.30x

StringFromLongWholeSubstring
5
4
-20.0%
1.25x

DropWhileCountableRangeLazy
106
87
-17.9%
1.22x

RawBufferInitializeMemory
171
142
-17.0%
1.20x

Array2D
7504
6672
-11.1%
1.12x

Diffing.Similar
576
514
-10.8%
1.12x (?)

SubstringComparable
13
12
-7.7%
1.08x

RemoveWhereFilterString
332
308
-7.2%
1.08x (?)

DropLastSequence
586
544
-7.2%
1.08x (?)

String.replaceSubrange.Substring.Small
84
78
-7.1%
1.08x (?)

PrefixAnySeqCntRange
28
26
-7.1%
1.08x (?)

StringHasPrefixUnicode
57000
53000
-7.0%
1.08x (?)

RandomShuffleLCG2
480
448
-6.7%
1.07x (?)

PrefixWhileArray
88
105
+19.3%
0.84x

UTF8Decode_InitFromCustom_contiguous
188
222
+18.1%
0.85x (?)

UTF8Decode_InitDecoding
188
222
+18.1%
0.85x (?)

DataCreateEmpty
170
200
+17.6%
0.85x

DevirtualizeProtocolComposition
228
268
+17.5%
0.85x

StringEqualPointerComparison
171
200
+17.0%
0.86x

UTF8Decode_InitFromBytes_ascii
284
330
+16.2%
0.86x (?)

BucketSort
172
195
+13.4%
0.88x

ObjectiveCBridgeStubDateAccess
228
257
+12.7%
0.89x

ClosedRangeOverlapsClosedRange
90
100
+11.1%
0.90x

DataCountSmall
28
31
+10.7%
0.90x (?)

DataCountMedium
28
31
+10.7%
0.90x

RandomDoubleOpaqueLCG
469
516
+10.0%
0.91x

DropFirstAnyCollection
180
198
+10.0%
0.91x

Data.append.Sequence.809B.Count.RE.I
101
111
+9.9%
0.91x (?)

SequenceAlgosRange
3140
3430
+9.2%
0.92x (?)

SuffixArrayLazy
11
12
+9.1%
0.92x

SuffixArray
11
12
+9.1%
0.92x

ArrayAppendLatin1Substring
28512
31068
+9.0%
0.92x (?)

ArrayAppendUTF16Substring
27972
30456
+8.9%
0.92x (?)

ArrayAppendAsciiSubstring
27972
30456
+8.9%
0.92x

Improvement
OLD
NEW
DELTA
RATIO

AngryPhonebook.ASCII2
188
88
-53.2%
2.14x

AnyHashableWithAClass
124500
96000
-22.9%
1.30x

Sim2DArray
794
625
-21.3%
1.27x

ArrayAppendRepeatCol
1030
850
-17.5%
1.21x (?)

RawBufferInitializeMemory
171
142
-17.0%
1.20x

SubstringComparable
13
11
-15.4%
1.18x

RemoveWhereSwapInts
43
37
-14.0%
1.16x (?)

DataSubscriptMedium
71
62
-12.7%
1.15x

Set.subtracting.Seq.Empty.Box
261
228
-12.6%
1.14x

RandomShuffleLCG2
512
448
-12.5%
1.14x

SIMDReduce.Int32x4.Cast
73
66
-9.6%
1.11x (?)

ConvertFloatingPoint.MockFloat64Exactly2
11
10
-9.1%
1.10x

DataSubscriptSmall
34
31
-8.8%
1.10x

PrefixWhileAnyCollectionLazy
193
176
-8.8%
1.10x (?)

PrefixAnySeqCRangeIterLazy
193
176
-8.8%
1.10x

PrefixAnySeqCntRangeLazy
193
176
-8.8%
1.10x

Breadcrumbs.MutatedUTF16ToIdx.Mixed
288
264
-8.3%
1.09x (?)

SuffixCountableRange
12
11
-8.3%
1.09x (?)

RemoveWhereMoveInts
37
34
-8.1%
1.09x

LazilyFilteredRange
7920
7290
-8.0%
1.09x (?)

Breadcrumbs.MutatedIdxToUTF16.Mixed
293
270
-7.8%
1.09x (?)

StringUTF16SubstringBuilder
2700
2490
-7.8%
1.08x (?)

Array2D
7504
6928
-7.7%
1.08x

DropWhileCountableRangeLazy
94
87
-7.4%
1.08x

DistinctClassFieldAccesses
391
362
-7.4%
1.08x (?)

ArrayInClass
1940
1800
-7.2%
1.08x (?)

String.replaceSubrange.Substring.Small
84
78
-7.1%
1.08x (?)

ConvertFloatingPoint.MockFloat64ToInt64
50305
56490
+12.3%
0.89x (?)

String.replaceSubrange.String
25
28
+12.0%
0.89x (?)

StringUTF16SubstringBuilder
10580
11560
+9.3%
0.92x (?)

Breadcrumbs.MutatedIdxToUTF16.ASCII
12
13
+8.3%
0.92x (?)

Hanoi
12860
13910
+8.2%
0.92x (?)

Improvement
OLD
NEW
DELTA
RATIO

AngryPhonebook.ASCII2
190
90
-52.6%
2.11x

FloatingPointPrinting_Double_description_small
29000
23500
-19.0%
1.23x (?)

AnyHashableWithAClass
165500
136500
-17.5%
1.21x (?)

ArrayOfPOD
1148
1060
-7.7%
1.08x (?)

ProtocolDispatch2
9915
9221
-7.0%
1.08x (?)

DataToStringLargeUnicode
10500
9800
-6.7%
1.07x (?)

Set.isDisjoint.Seq.Int100
2393
2234
-6.6%
1.07x (?)

Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

Another potential benefit is an (anecdotal) code gen improvement in some integer-indexed collection types -- < seems to enable better code analysis in some cases.

It is relatively simple to demonstrate. In this example, compare the code generated for iterateOne and iterateTwo (which use a for loop and != termination condition respectively) against iterateThree, which uses a < condition. iterateFour is there to demonstrate that Array is full of delicately-tuned magic, so I'm not entirely surprised to see some regressions related to it. It may need some careful examination to determine exactly what is going on there.
I'd also recommend building a toolchain and benchmarking this with generic collections that don't use Array as their storage.
If this helps solve issues with String, that's great, but I think there is value to be unlocked via this change even if it turns out that String needs some other delicate workarounds.

The benchmark results are a wash, which is expected -- except for DropWhileAnySeqCRangeIter and DropWhileAnySeqCntRange which seem to have suffered what looks like an algorithmic slowdown.
These are testing a Sequence algorithm over AnySequence<Range<Int>>; this change is involved in that, as Range uses an IndexingIterator, but it's unclear how/why there could be such a large impact.
The correctness issue uncovered by the unit tests is more pressing, though.

(Note: Fixing Substring to correctly implement Collection is going to be the right fix to the original issue, not this PR. This means that this PR has lost most of its primary motivating case -- this does not mean that we won't/can't land it at some point, but its (considerable) risks need to be weighed against its potential benefits, and we need to find time to prioritize it.)

As far as integer-indexed collections go, I think the indices of most correct Collections ultimately boil down to some integer or another. Yes, there are linked-lists, but Collection already requires that its indices be Comparable, so they'd need to invent some clever indexing scheme to efficiently implement that anyway.
I've been mentioning this particular thing for some time, as I've seen really great improvements in my libraries by using it (especially together with other tweaks, such as unsigned integer indexes). But I also appreciate that the standard library maintainers have limited time and must prioritise correctness over performance. I just hope it stays on the radar for whenever there's time to work on it :)

I just hope it stays on the radar for whenever there's time to work on it :)

This is definitely on my radar -- I'll keep looking for an excuse to land it.
It's very difficult to ship potentially ABI breaking behavioral changes like this purely for performance reasons, especially if the performance benefits do not show up as a clear win in benchmarks. (The risk can be quite large -- debugging / dealing with binary compatibility issues tends to take a long time. Every minute spent on it takes resources away from more productive work, so we need to always weigh such risk against expected benefits.)


As a developer, I want to handle edge cases, add error handling, and perform refactoring in files of utils folder, as the functions in there can be used in critical parts of the software

Addressed by #23 and #24


feat(generator,gen_structs,tb_info,tb_column) :  Provide the ability to generate all and some tables of the database

Maybe we should add the GetTables to Gorm's migrator interface, but not gen.

OK, I'll submit it later


Automatically convert case

If characters are entered (or pasted) that do not match, but their
corresponding uppercase or lowercase characters do match, insert
the correct uppercase or lowercase characters.

FYI, this is my first pull request ever. Please let me know what to do if I did something wrong.


Enable Change Data Feed

We are developing an application for Azure Databricks. We are using DBR 8.3, which has the experimental feature of Change Data Feed.
For testing purposes, we have a dockerized local environment with Spark 3.1.2 and spark-delta 1.0.0. When we want to create a CDF enabled table, we use:
DeltaTable.createIfNotExists(spark).tableName("TableName").addColumns(schema).location(path).property("delta.enableChangeDataFeed", "true").execute()
When we try to execute that, we receive the error:
Configuration delta.enableChangeDataFeed cannot be set. Change data feed from Delta is not yet available.
Is there anyway to enable this for local testing purposes?

CDF is only available in Delta on Databricks right now. So using Delta 1.0 locally will not allow you to use CDF.

Thanks a lot for your response
Ok, I see.
Is it expected that eventually CDF could be used out of Databricks? Is there something in the works there?
Anyway, thanks a lot

Hi @TioLuiso - a great way to chime in is to vote in the Delta OSS 2021H2 Roadmap - here's the link specifically to CDF.  HTH!

@TioLuiso - see https://github.com/delta-io/delta/issues/1105.

Looking forward to adding CDF to Delta OSS! @dennyglee

Definitely!  We're marching towards Delta Lake 2.0 (the RC became available for testing in late June).  Test it out now if you can and provide us feedback, eh?! :)

2.0.0 has been released. Closing this as a duplicate of #1105


Upgrade to version 0.4.0

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@adrianeboyd @honnibal @ines
Please review, updated dependencies. This PR should be good to merge
Thank you and regards.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender


Rename MockServiceProvider::addDefinition() to setDefinition()

Seems, setDefinition() will be more logical, because definition can be overrided.

Going to fix this

Seems to be renamed already: https://github.com/yiisoft/yii-testing/blob/21eead563a806417bc446ce859df4a6c484bef4c/src/MockServiceProvider.php#L24


Current versions of bloomapi and bloomnpi not compatible

I've been trying to get a local instance of bloomapi running by following the instructions here. But the elasticsearch index created by bloomnpi seems to be different than that expected by bloomapi. I think I've gotten it to work by applying this patch:
diff --git a/handler/search_helper.go b/handler/search_helper.go
index 17a847d..fbb91d2 100644
--- a/handler/search_helper.go
+++ b/handler/search_helper.go
@@ -150,7 +150,7 @@ func Search(sourceType string, params *SearchParams, r *http.Request) (map[strin
 		api.AddMessage(r, experimentalSort)
 	}

-	result, err := conn.Search(sourceType, "main", nil, query)
+	result, err := conn.Search("source", sourceType, nil, query)
 	if err != nil {
 		switch terr := err.(type) {
 		case elastigo.ESError:

The change to bloomapi seems to have happened after the current bloomnpi. Is there a missing bloomnpi version?

I'd actually suggest making the reverse change in bloomnpi. Let me take a closer look at the whole project today to make sure everything's still working ok.

Thanks, I'll give that a try! We (Counsyl) have been using an older version internally for some time, just looking to bring things up to date.

Looks like it works OK to import data with this change -- I'll check , but the datasource itself doesn't update the /api/sources list ... this means you'll have to search with /api/search and find specific listings with /api/npis/:npi for now. I pushed this update just now with e743a5d78b3f964822df872b718e03a1eb9ddf4b.
As an aside, I decided to open source our production versions of this code over the weekend which includes many other datasources in addition to the NPI. This code does maintain the sources list correctly. I'm going to be putting a little more time into this this week to write some better documentation for it. You can find this at https://github.com/bloomapi/datasources.

Thanks very much!

Just pushed and tested some versions that make getting a running copy via docker significantly easier. E.g.

Download https://raw.githubusercontent.com/untoldone/bloomapi/master/docker-compose.yml
Run docker-compose up -d on a machine with docker (where Docker gets at least 4GB of memory)

I'm going to go ahead and close this issue, but let me know if this is enough for you to get going with or if you have any other questions.

Thank you very much!!

Regarding that 4GB for Docker -- how should that be divided up amongst the different containers? I assume the elasticsearch container needs the most?

In a prod environment, the more memory you feed ES the better (at least 2GB) -- PG needs the second most (at least 512MB-1G but would likely want more). The other containers should be relatively lean. Just as a warning, while it works with 4GB, I haven't tested it rigorously at this point and its possible 4GB isnt enough for a prod environment. For context, we used to run ES on a cluster of 3 machines each with 4GB of memory reserved for ES (12GB total). We recently moved to a single host with 16GB. If you are in a cloud environment, more memory for the DB will also dramatically increase the load times for the datasets as PG can put everything into memory/ cache rather than having to load everything from disk which can be super slow to load otherwise (we're talking 15 minutes vs 6+ hours).

That makes sense, thanks very much!


WIP: 7 adding testing framework

Pull Request
Added support for the Jest testing framework, along with adding jest framework setup support for coverage.
Requirements Added

Jest
Babel -> added for support for Jest with typescript
ts-jest -> added for support for Jest with typescript

Fixes #7
Type of change

[ ] A new feature
[ ] A bug fix
[ ] Documentation only changes
[x] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
[x] A code change that neither fixes a bug nor adds a feature
[ ] A code change that improves performance
[ ] Adding missing tests or correcting existing tests
[ ] Changes that affect the build system or external dependencies
[ ] Changes to our CI configuration files and scripts
[ ] Other changes that don't modify src or test files

Add description here
   - Added Jest framework as the test runner for the node src

Checklist

[x] My code follows the contributing guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@DarrellRichards Could you open this pull request against the Develop branch?

@Whamo12
My apologizes, I see it wasn't defaulted to develop.
I should have the last couple of changes up here in a moment.

@Whamo12
I pushed the updates to remove tsx and jsx (I wasn't sure if there was plans in the future).
Also, the tests fail with the command till we have a test wrote.


Report invalid HAML format as violation

HamlLint includes the line number in the exception when it encounters an
invalid Haml format. However, the line number is of the line before the
error, thus we need to add one to comment under the erroneous line in
the pull request.

LGTM :+1:


changes for 11256 stability

depends on https://github.com/pcmanus/ccm/pull/475 as well

I think these changes should be low impact to bring in, then I can do another repetition test before removing the known_failure tag.


WIP: Deprecate EDF

I added one commit on top of #5733 to show how things could pass (in theory) with stim_channel=None.

I had to mark two BDF tests xfail to get it there. @massich if we can get rid of those xfails, then we should be able to get rid of all of the stim_channel logic in edf.py like we did everywhere else.
One other thing is that we should probably deprecate find_edf_events, too. It shouldn't be needed anymore. Maybe we should put that in 0.17.1.
How come we don't do self.set_annotations(read_annotations(edf_path)) in RawEDF constructor? It would save a bunch of raw.set_annotations(read_annotations(edf_path)) lines in the tests and for users. In fact I was surprised when this did not just work:raw = read_raw_edf(path)
events, event_id = events_from_annotations(raw)

... because I needed the raw.set_annotations(read_annotations(path)) line in there, too.

According to @cbrnr in #5738 this very well might not be the right approach.

yes

raw = read_raw_edf(path)
events, event_id = events_from_annotations(raw)
should have worked :(
you should not need to set_annotations if it was present in the file. It
should just be there.

I'll check it out
On Wed, Nov 21, 2018, 23:32 Alexandre Gramfort<EMAIL_ADDRESS>wrote:

yes

raw = read_raw_edf(path)
events, event_id = events_from_annotations(raw)
should have worked :(
you should not need to set_annotations if it was present in the file. It
should just be there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/pull/5739#issuecomment-440831484,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGt-482j5zOL-DpPPrA5b5HHYfXWQblSks5uxdR9gaJpZM4Yt46P
.


escape backslash in backtick symbol matching

This fixes the backslash issue in the APL study.
It's a bit hacky as I said in the issue, if someone has a better idea please let me know.

Thanks for the PR - I actually noticed this this afternoon and popped in a more general fix (which is to escape all back-slashes).


'LC-16-Move-Whitelisted-Domains-from-Azure-App-Settings-to-MySQL'

Here's the code changes to read white lists from MySQL and no longer from Azure config

Unsaved files added - will create a new PR


Minor typo

@jangelfdez : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; thanks @jangelfdez.


HipMRI Study Using VQVAE - 47323254

This pull request introduces the VQVAE model designed for the HipMRI image study. It includes scripts for training, validation, and evaluation of the model, as well as a README file that documents the project overview and provides instructions for executing the scripts. The project is organised into three main directories: src, which contains all the scripts needed to train, validate, and evaluate the model; configs, which contains sample configuration YAML files for training and prediction; and images, which contains all the images used in the README.

Recognition problem: VQVAE on HipMRI ---- Hard Difficulty

Algorithm solves the problem:
Very clear and highly resembling reconstructed images, with an SSIM well above 0.9 (5 Marks)

Algorithm demonstrated and functions: (3 Marks)

Design:
Not bad design and good practice using utils script (1 Mark)

Commenting:
Sufficient docstrings but comments could be more specific (1 Mark)

Algorithm above Normal Difficulty: (5 Marks)

Algorithm is Hard difficulty: (5 Marks)

Suggestions:

It's really nice to have progressive experiments and hyperparameter tuning recorded with consequent detailed results :) (it would be better and easier to see the resulting plots if they load properly in README.md);
Images not shown properly on README.md due to incorrect path configuration;
It is ok to train and predict the way you did in train.py and predict.py, but it's better to have specific functions to do so for modularization purpose;
No need to delete recognition/README.md
Good project!

Additional suggestions for improvements:

While you've mentioned the reconstruction and commitment loss, explaining why these are used and how they contribute to model performance would be good.

Overall very good job.

Would it be possible to modify the implementation slightly? I'd like to add a commitment loss term (| z - sg(e) |^2) since, currently, I only have the reconstruction and codebook loss. I initially didn't included it because the GitHub code I referenced didn’t include it, and I didn’t encounter stability issues during training. However, upon further consideration, there is no reason to not include it as it ensures the training stability without much extra computation.

Reona Nakagawa

Good work. Cant merge because of conflicting changes to main repo files. Please update for merge, doesn't affect grade.


[Feature] Supports producers to automatically obtain partitions

Search before asking

[X] I searched in the issues and found nothing similar.

Version
2.7.3
Minimal reproduce step
create producer and don't close it, when server adjust partition producer still write data to old partion
What did you expect to see?
keep producer don't close , producer will write date to new partion
What did you see instead?
kafka client auto get new partion
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Did you mean when the partitions increased, the producer won't write messages to new partitions?
i.e. now it's
producer -> P0, P1, P2

After you add a P3, producer won't send messages to P3.

Did you mean when the partitions increased, the producer won't write messages to new partitions?
i.e. now it's
producer -> P0, P1, P2

After you add a P3, producer won't send messages to P3.

Yes, client dont't close producer, after pulsar server add new partion, client can't find new partion

It's weird. This should have been protected by tests. It's a very old feature I've added in https://github.com/apache/pulsar/pull/6732. Could you try to test like what the PartitionsUpdateTest does?

Do I need to recreate the producer when the partion changes?
Now the logic is that the producer is not released, saved in a map
    pulsar_message_t *message = pulsar_message_create();
    pulsar_message_set_content(message, (const void *)data.c_str(), data.length());
    pulsar_message_set_property(message, "message_key", key.c_str());
    pulsar_message_set_event_timestamp(message, beginTimestamp);
    pulsar_producer_send_async(producer, message, PulsarProducer::SendCallback, (void *)message);

Do I need to recreate the producer when the partion changes?

No. You can call setPartitionsUpdateInterval with 1 second to see if the producer detected the increased partitions.

I didn't find this function

application

This is my code
void PulsarProducer::SetProducerConfig(pulsar_producer_configuration_t *producerConf)
{
    if (m_pulsarCfg.m_producerCfg.m_maxPendingMessages > 0)
    {
        pulsar_producer_configuration_set_max_pending_messages(producerConf, m_pulsarCfg.m_producerCfg.m_maxPendingMessages);
    }

    if (m_pulsarCfg.m_producerCfg.m_maxPendingMessagesAcrossPartitions > 0)
    {
        pulsar_producer_configuration_set_max_pending_messages_across_partitions(producerConf, m_pulsarCfg.m_producerCfg.m_maxPendingMessagesAcrossPartitions);
    }

    if (m_pulsarCfg.m_producerCfg.m_sendTimeout > 0)
    {
        pulsar_producer_configuration_set_send_timeout(producerConf, m_pulsarCfg.m_producerCfg.m_sendTimeout);
    }

    if (m_pulsarCfg.m_producerCfg.m_batchingMaxMessages > 0)
    {
        pulsar_producer_configuration_set_batching_max_messages(producerConf, m_pulsarCfg.m_producerCfg.m_batchingMaxMessages);
    }

    if (m_pulsarCfg.m_producerCfg.m_batchingMaxAllowedSizeInBytes > 0)
    {
        pulsar_producer_configuration_set_batching_max_allowed_size_in_bytes(producerConf, m_pulsarCfg.m_producerCfg.m_batchingMaxAllowedSizeInBytes);
    }

    pulsar_producer_configuration_set_batching_enabled(producerConf, m_pulsarCfg.m_producerCfg.m_batchingEnabled);

    return;
}

pulsar_producer_t *PulsarProducer::newProducer(const std::string &topic)
{
    pulsar_producer_t *producer;
    producer = findProducer(topic);
    if (producer == NULL)
    {
        pulsar_producer_configuration_t *producer_conf = pulsar_producer_configuration_create();
        SetProducerConfig(producer_conf);

        pulsar_result err = pulsar_client_create_producer(m_client, topic.c_str(), producer_conf, &producer);
        if (err != pulsar_result_Ok)
        {
            LOG_ERROR("Failed to create producer: %s\n", pulsar_result_str(err));
            pulsar_producer_configuration_free(producer_conf);
            return NULL;
        }

        PulsarProducerObject *ptrPulsarProducer = new PulsarProducerObject();
        ptrPulsarProducer->m_producer = producer;
        ptrPulsarProducer->m_producer_conf = producer_conf;
        m_producers.insert(std::pair<std::string, PulsarProducerObject *>(topic, ptrPulsarProducer));

    }

    return producer;
}

int PulsarProducer::excuteProduce(const std::string &topic, const std::string &key, const string &data)
{
    pulsar_producer_t *producer = newProducer(topic);
    if (producer == NULL)
    {
        return -1;
    }

    pulsar_message_t *message = pulsar_message_create();
    pulsar_message_set_content(message, (const void *)data.c_str(), data.length());
    pulsar_message_set_property(message, "message_key", key.c_str());
    pulsar_producer_send_async(producer, message, PulsarProducer::handleSendCallback, (void *)producer);

    pulsar_message_free(message);
    return 0;
}

void PulsarProducer::handleSendCallback(pulsar_result result, pulsar_message_id_t *msgId, void *ctx)
{
    if (msgId == NULL)
    {
        return;
    }

    char *msg = pulsar_message_id_str(msgId);
    pulsar_producer_t *producer = (pulsar_producer_t *)ctx;
    pulsar_message_id_free(msgId);
    if (msg != NULL)
    {
        free(msg);
    }
}

reproduce

@BewareMyPower
How do I solve the partion problem？

Hello @BewareMyPower
When the producer is created, the number of partions is specified, so the server adjusts the producer of the partion client and cannot be synchronized to the latest one？
void ClientImpl::handleCreateProducer(const Result result, const LookupDataResultPtr partitionMetadata,
                                      TopicNamePtr topicName, ProducerConfiguration conf,
                                      CreateProducerCallback callback) {
    if (!result) {
        ProducerImplBasePtr producer;
        if (partitionMetadata->getPartitions() > 0) {
            producer = std::make_shared<PartitionedProducerImpl>(shared_from_this(), topicName,
                                                                 `partitionMetadata->getPartitions()`, conf);
        } else {
            producer = std::make_shared<ProducerImpl>(shared_from_this(), *topicName, conf);
        }
        producer->getProducerCreatedFuture().addListener(
            std::bind(&ClientImpl::handleProducerCreated, shared_from_this(), std::placeholders::_1,
                      std::placeholders::_2, callback, producer));
        Lock lock(mutex_);
        producers_.push_back(producer);
        lock.unlock();
        producer->start();
    } else {
        LOG_ERROR("Error Checking/Getting Partition Metadata while creating producer on "
                  << topicName->toString() << " -- " << result);
        callback(result, Producer());
    }
}

As I've explained before, this feature has been implemented and protected by the PartitionsUpdateTest.cc. Could you point out which case does this test not cover?
You can see https://github.com/apache/pulsar-client-cpp/blob/7bb6402bb15dbbf51d42cf8e54793d835db52a55/tests/PartitionsUpdateTest.cc#L37-L39
Reducing the interval to 1s can help detect the partitions change faster. The default interval is 120s (2 minutes). It could be better that you can show how to reproduce it and why the PartitionsUpdateTest doesn't cover the case.


test

Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)

Closes

Codecov Report

Merging #17 (979630a) into master (1f6fa2c) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 979630a differs from pull request most recent head a65613c. Consider uploading reports for the commit a65613c to get more accurate results

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   41.69%   41.69%
=======================================
  Files          68       68
  Lines        4758     4758
=======================================
  Hits         1984     1984
  Misses       2774     2774

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f6fa2c...a65613c. Read the comment docs.


Modify the artifact name with aligned version number and modify the e…

Modify the artifact name to be aligned with parent OAP project which is 0.8.1 and modify the enabling guide as per.

LGTM.

@Jian-Zhang Just updated commit, please try build again. I tested with version 0.8 before and didn't find issue. After short sync with test team we reach the agreement to change the version to 0.8.1, and I just updated the pom.xml without further verification. Howeveer, the issue happens because the combination between artifact oap-rpmem-shuffle and version 0.8.1 is duplicated both in rpmem shuffle parent project and java sub-project. I modified the sub-project's artifact ID with a "-java" suffix to distinguish it from parent project. Now, it should work find. Thanks.

LGTM.


<EMAIL_ADDRESS>breaks prod build

[x] Regression (a behavior that used to work and stopped working in a new release)

Hi! I updated akita-ng-router-store from 5.0.0 to 5.1.0 and my production(only) build broke
Here is the error:
ERROR Error: Uncaught (in promise): NullInjectorError: StaticInjectorError(AppModule)[AkitaNgRouterStoreModule -> RouterService]:
  StaticInjectorError(Platform: core)[AkitaNgRouterStoreModule -> RouterService]:
    NullInjectorError: No provider for RouterService!
NullInjectorError: StaticInjectorError(AppModule)[AkitaNgRouterStoreModule -> RouterService]:

Here are my deps:
    "@angular-devkit/build-angular": "~0.803.25",
    "@angular/animations": "^8.2.14",
    "@angular/cdk": "^7.3.7",
    "@angular/cli": "^8.3.25",
    "@angular/common": "^8.2.14",
    "@angular/compiler": "^8.2.14",
    "@angular/compiler-cli": "^8.2.14",
    "@angular/core": "^8.2.14",
    "@angular/forms": "^8.2.14",
    "@angular/material": "^7.3.7",
    "@angular/platform-browser": "^8.2.14",
    "@angular/platform-browser-dynamic": "^8.2.14",
    "@angular/router": "^8.2.14",
    "@datorama/akita": "^4.17.1"

Fixing version to<EMAIL_ADDRESS>solved the issue
What should I change to be able to use 5.1.0?

@NickLargen can you check it, please? v5.1.0 is with your changes only.

That's weird. Could you list how you are importing AkitaNgRouterStoreModule and what the difference is between your development builds and production builds?

@NickLargen its imported regulary in imports block.
This is where I import the class:
import { AkitaNgRouterStoreModule } from '@datorama/akita-ng-router-store'
Maybe the fact that it is imported in lazy loaded module, affects the build?
{
    path: 'path',
    canActivate: [AuthGuard],
    loadChildren: () => import('./moduleWithAkita.module').then(mod => mod.ModuleWithAkita),
  },

Unfortunately I can't easily update ng to 9, cause we have a huge project
here are builds:
 "build": {
          "builder": "@angular-devkit/build-angular:browser",
          "options": {
            "outputPath": "dist",
            "index": "src/index.html",
            "main": "src/main.ts",
            "tsConfig": "src/tsconfig.app.json",
            "polyfills": "src/polyfills.ts",
            "outputHashing": "all",
            "aot": true,
            "stylePreprocessorOptions": {
              "includePaths": [
                "src/assets/styles"
              ]
            },
            "assets": [
              "src/assets",
              "src/assets/favicon.ico"
            ],
            "styles": [
              "src/styles.scss"
            ],
            "scripts": [
              "src/assets/plugins/TweenMax.min.js"
            ]
          },
          "configurations": {
            "production": {
              "optimization": true,
              "outputHashing": "all",
              "sourceMap": false,
              "extractCss": true,
              "namedChunks": false,
              "aot": true,
              "extractLicenses": true,
              "vendorChunk": false,
              "buildOptimizer": true,
              "fileReplacements": [
                {
                  "replace": "src/environments/environment.ts",
                  "with": "src/environments/environment.prod.ts"
                }
              ]
            }
          }
        },

Is this the only place you import the module? Not in the AppModule?

yep, cause I only need it in one lazyloaded module

So v5 works with lazy, and 5.1 not?

yes, I can say so

In the meantime, use v5. I'll check it out when I can.

I just tried it in our playground, and it works fine.

If you can create a reproduction, I'll check it out.

@katyapavlenko any news here? It seems to work fine.

@NetanelBasal represented. Check readme for instructions
https://github.com/katyapavlenko/akita-bug

The problem is that akita is currently compiled with ngc version 9, which produces build files which aren't compatible with angular 8 when using buildOptimizer (default for --prod). The problem is that ngc version 9  renamed ngInjectableDef token to ɵprov when computing injectable dependencies. With buildOptimizer enabled in angular 8 all decoraters are scrubbed away and thus for the akita-ng-router-store package files, too. Therefore angular cannot not read any provider information from decoraters or static injectable tokens when using buildOptimizer.
There are two options that should solve this issue:

using ngc 8 to compile akita and its libs
only support angular 9 as peer dependency and don't support angular 8

Thanks @xbaun, I was about to say the same :)
We should take the first approach. It's not about Akita. Akita doesn't depend on Angular. We should do it for the Angular plugins.

@katyapavlenko try v5.1.6.


Add edited label to comment details

Closes #57
Added one extra field to the schema which is "lastEditedAt". As per how GitHub web does it, if the editor is different than the comments owner then it says "Edited by somebody" otherwise it just says "Edited". Long tapping will show a detailed view which says the name and the relative time of when it was updated.
Screenshots:
Different Editor
Same Editor
[intentional edit]

!!! @Sherlouk this is SO GOOD
You rock!