25X slower in-graph vs out-of-graph training loop on GPU in TF2.0

Describe the current behavior
When training using a fully in-graph training loop for a custom model (as described in the documentation), training is 25x slower than when training the same model with an out-of-graph training loop.
Describe the expected behavior
I would think in-graph training should be faster because we are not shuttling data back and forth between the gpu and python runtimes.
Code to reproduce the issue
import numpy as np
import tensorflow as tf
import tensorflow.keras as keras
import time
import os

os.environ['TF_CPP_MIN_LOG_LEVEL'] = '2'

class MyModel(keras.Model):

    def __init__(self):
        super(MyModel, self).__init__()
        self.conv1 = keras.layers.Conv2D(64, [3, 3])
        self.conv2 = keras.layers.Conv2D(64, [3, 3])
        self.flatten = keras.layers.Flatten()

    def call(self, inputs, training):
        images = inputs[0]
        targets = inputs[1]
        x = self.conv1(images)
        x = self.conv2(x)
        x = self.flatten(x)
        loss = tf.reduce_mean(x, axis=1) - tf.reduce_mean(targets, axis=1)
        return loss

def create_dataset():
    X = np.zeros([10, 224, 224, 3], dtype=np.float32)
    Y = np.zeros([10, 1000], dtype=np.float32)
    x_ds = tf.data.Dataset.from_tensor_slices(X)
    y_ds = tf.data.Dataset.from_tensor_slices(Y)
    ds = tf.data.Dataset.zip((x_ds, y_ds))
    ds = ds.batch(32)
    return ds

@tf.function
def train_one_step(model, optim, inputs):
    with tf.GradientTape() as tape:
        loss = model(inputs, training=True)
        loss = tf.reduce_mean(loss)
    grads = tape.gradient(loss, model.trainable_variables)
    grads_and_vars = zip(grads, model.trainable_variables)
    optim.apply_gradients(grads_and_vars)
    return loss

@tf.function
def in_graph_training_loop(model, optim, dataset):
    step = 0
    for inputs in dataset:
        loss = train_one_step(model, optim, inputs)
        step += 1

def out_graph_training_loop(model, optim, dataset):
    step = 0
    for inputs in dataset:
        loss = train_one_step(model, optim, inputs)
        step += 1

def main():
    model = MyModel()
    optim = keras.optimizers.Adam(1e-4)
    dataset = create_dataset()

    for i in range(5):
        t0 = time.time()
        in_graph_training_loop(model, optim, dataset)
        t1 = time.time()
        print('Time for in-graph training loop: %.3f secs' % (t1 - t0))

    print('-' * 20)

    for i in range(5):
        t0 = time.time()
        out_graph_training_loop(model, optim, dataset)
        t1 = time.time()
        print('Time for out-of-graph training loop: %.3f secs' % (t1 - t0))

if __name__ == '__main__':
    main()

Output:
python train/test.py
Time for in-graph training loop: 2.064 secs
Time for in-graph training loop: 1.031 secs
Time for in-graph training loop: 1.013 secs
Time for in-graph training loop: 1.018 secs
Time for in-graph training loop: 1.012 secs
--------------------
Time for out-of-graph training loop: 2.079 secs
Time for out-of-graph training loop: 0.014 secs
Time for out-of-graph training loop: 0.041 secs
Time for out-of-graph training loop: 0.041 secs
Time for out-of-graph training loop: 0.041 secs

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes but this is minimally divergent from stock examples in documentation
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):  Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.0
Python version:  3.6.8
CUDA/cuDNN version: 10.0

Issue is replicating on colab with Tf 2.0.
Please find the gist here. Thanks!

Thanks for testing.

@huyng @gadagashwini This issue is the same with my proposed recently, see https://github.com/tensorflow/tensorflow/issues/35206
I have a temporary solution, add tf.function for all main invoked functions for in_graph_training_loop. In this example, they are MyModel.call and train_one_step.
I suggest you use a large batch size for testing, and for out_graph_training_loop, do not add tf.function to train_one_step.
In  my testing, I enlarge the parameters, then in_graph_training_loop (add all tf.function) takes about 0.23s, while 0.39s for in_graph_training_loop (without any tf.function)

There is a known issue with datasets in for loops in the 2.0 release that was causing unnecessary bouncing to the CPU - #32138. That is fixed in tf-nightly. I'll have a closer look at the measurements.

@SummerRainET2008 @mdanatg thanks for the response. I tried modifying and testing my code based on your comments (See below).

@SummerRainET2008 , I tried decorating the MyModel.call w/ tf.function and it doesn't seem to resolve the issue. Here are the timings
Time for in-graph training loop: 1.478 secs
Time for in-graph training loop: 1.011 secs
Time for in-graph training loop: 1.019 secs
Time for in-graph training loop: 1.046 secs
Time for in-graph training loop: 0.991 secs
--------------------
Time for out-of-graph training loop: 2.412 secs
Time for out-of-graph training loop: 0.014 secs
Time for out-of-graph training loop: 0.016 secs
Time for out-of-graph training loop: 0.016 secs
Time for out-of-graph training loop: 0.016 secs

@mdanatg I tried adding iter(dataset) to my in-graph loop and it helped a lot! However, the in-graph loop is still 2x as slow as the out-of-graph loop:
modification:
@tf.function
def in_graph_training_loop(model, optim, dataset):
    step = 0
    for inputs in iter(dataset):
        loss = train_one_step(model, optim, inputs)
        step += 1

timing:
Time for in-graph training loop: 2.355 secs
Time for in-graph training loop: 0.031 secs
Time for in-graph training loop: 0.031 secs
Time for in-graph training loop: 0.028 secs
Time for in-graph training loop: 0.031 secs
--------------------
Time for out-of-graph training loop: 0.671 secs
Time for out-of-graph training loop: 0.014 secs
Time for out-of-graph training loop: 0.016 secs
Time for out-of-graph training loop: 0.016 secs
Time for out-of-graph training loop: 0.016 secs

I then tried adding tf.device context manager but the out-of-graph loop still seems to be fastest.
modification:
@tf.function
def in_graph_training_loop(model, optim, dataset):
    step = 0
    for inputs in iter(dataset):
        with tf.device('/device:GPU:0'):
            loss = train_one_step(model, optim, inputs)
            step += 1

timing:
Time for in-graph training loop: 2.356 secs
Time for in-graph training loop: 0.031 secs
Time for in-graph training loop: 0.032 secs
Time for in-graph training loop: 0.032 secs
Time for in-graph training loop: 0.032 secs
--------------------
Time for out-of-graph training loop: 0.674 secs
Time for out-of-graph training loop: 0.014 secs
Time for out-of-graph training loop: 0.016 secs
Time for out-of-graph training loop: 0.016 secs
Time for out-of-graph training loop: 0.016 secs

I increased the dataset size so that the training loop runs 10 iterations, rather than just a single one.
So when applying the workaround suggested in #32138 (writing for inputs in iter(dataset):), the speed becomes comparable:
Time for in-graph training loop: 0.928 secs
Time for in-graph training loop: 0.614 secs
Time for in-graph training loop: 0.624 secs
Time for in-graph training loop: 0.617 secs
Time for in-graph training loop: 0.615 secs
--------------------
Time for out-of-graph training loop: 1.050 secs
Time for out-of-graph training loop: 0.458 secs
Time for out-of-graph training loop: 0.459 secs
Time for out-of-graph training loop: 0.459 secs
Time for out-of-graph training loop: 0.457 secs
--------------------
Time for in-graph training loop using tf.while: 0.750 secs
Time for in-graph training loop using tf.while: 0.531 secs
Time for in-graph training loop using tf.while: 0.532 secs
Time for in-graph training loop using tf.while: 0.533 secs
Time for in-graph training loop using tf.while: 0.530 secs

In this case, we'd expect the performance to be comparable because the only difference between the in-graph and the out-of-graph training loops is whether the loop runs in Python or in the TF executor - otherwise, in both cases we have data flowing from one subgraph (the one created by the dataset) to another (the one created by train_one_step).
At head, they run at comparable speeds:
Time for in-graph training loop: 0.928 secs
Time for in-graph training loop: 0.614 secs
Time for in-graph training loop: 0.624 secs
Time for in-graph training loop: 0.617 secs
Time for in-graph training loop: 0.615 secs
--------------------
Time for out-of-graph training loop: 1.050 secs
Time for out-of-graph training loop: 0.458 secs
Time for out-of-graph training loop: 0.459 secs
Time for out-of-graph training loop: 0.459 secs
Time for out-of-graph training loop: 0.457 secs

@jsimsa @alextp @mhong @jaingaurav FYI
It's interesting to note that the out-of graph loop is still faster, which means that the TF runtime is a little slower than Pyhton at running basic loops. That will hopefully improve in the future.


Clarify roles required to run the online readiness assessment tool

Suggest to change the text
"Anyone with at least the Global Reader or Intune Administrator role will be able to run this tool, but two of the checks (Conditional access policies and Multifactor authentication require additional permissions."
to:
"The Intune Administrator role is required to run this tool, with Global Reader required for two of the checks (Conditional access policies and Multifactor authentication) "
basically both roles are required to run the tool.
If the Global Reader role is missing, the readiness tool will always show that CA and MFA checks fail.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2edbbcfe-6534-59d7-0607-c3de3ff3ccf2
Version Independent ID: ed5a4eab-c164-5cb7-51c1-3e9eab7d1dd3
Content: Readiness assessment tools - Microsoft Managed Desktop
Content Source: microsoft-365/managed-desktop/get-ready/readiness-assessment-tool.md
Service: m365-md
GitHub Login: @jaimeo
Microsoft Alias: jaimeo

@csruane Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/5109
Thanks
Sri

@csruane SMEs are checking and update .If you see ant other documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


[Lyrics] Add plex & plexamp Support

Extension
https://www.raycast.com/andrewjazbec/lyrics
Description
Hey yall,
currently grabbing lyrics for both Plex & Plexamp isnt working( or not implemented most likely?)
Who will benefit from this feature?
Plex Media Server Users
Anything else?
Great Plugin Idea btw

Thanks for reporting!
Currently the extension uses Apple Scripts to get the current track info from the specified program.
From what I can tell Plex and Plexamp don't support this functionality and the info would need to be pulled through an API.
Something like this would probably be better suited for a "Plex" specific extension. Sort of like this.

@raycastbot close this issue


Case study bisecting

This PR enables the smooth plot extender to bisect over whole revision history of a case study at once as described in se-passau/VaRA#519. This is done via the paper_config_overview plot.
This is still a manual process consisting of the following steps:

Generate an initial sample of revisions. Uniform sampling should be used for this. In addition, the initial revision as well as the latest revision should be included in the sample.
Run your experiment for each revision in the sample
Add new revisions via (This is the bisecting step):vara-cs ext <path_to_case_study> -p <project> smooth_plot --plot-type=paper_config_overview_plot [--report-type=<report_type>] --merge-stage=<stage_number>

If no new revisions were added, you are done.
Otherwise run your experiment for all new revisions (se-passau/VaRA#526 might help once it is implemented) and continue with 3.

In the end, you should be able to easily identify revisions that introduce changes that cause an experiment to fail (or to work again).
Note that this approach will not find all faulty revisions. It is instead intended identify changes that cause larger blocks of revisions to fail.
Since the overview plot now allows to specify the report type it should generate the overview for, I added the possibility to also pass this information to the extender. This could help us debugging failures of other experiments in the future. By default, EmptyReport is used, which corresponds to compilation only.
Resolves se-passau/VaRA#519.

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- varats/plots/paper_config_overview.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- varats/plots/paper_config_overview.py  1
- varats/plots/plot_utils.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- varats/plots/paper_config_overview.py  1
- varats/plots/plot_utils.py  1

See the complete overview on Codacy


Error React/ReactDOM is not defined

I was facing an issue where one of my MFEs was throwing 'React is not defined' and 'React-dom is not defined'.
I fixed it by modifying the .babelrc file contents to:
{
  "presets": [
    ["@babel/preset-react", { "runtime": "automatic" }],
    "@babel/preset-env"
  ],
  "plugins": [["@babel/transform-runtime"]]
}

Changing the runtime mode for preset react to automatic fixed the issue for me.
Should I open a PR for the same?

Sure, though I am surprised. Did you also upgrade the React version, or make any other changes?

I'd have to check.


typo in title

https://docs.microsoft.com/en-us/vsts/work/customize/process/manage-process?view=vsts you have typo in title 'Create and mange an...'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d547b364-45cc-35d2-bb13-ca93e5043259
Version Independent ID: ccb4a4ec-cabc-5ace-f42e-b5520e6d443e
Content: Create and mange an inherited process - VSTS
Content Source: docs/work/customize/process/manage-process.md
Service: devops
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@MrSucik Thanks for letting us know, this has been fixed in https://github.com/MicrosoftDocs/vsts-docs/pull/808 and should be live soon. Thank you.


[TensorIR][M1c] Lower and build TensorIR

The last PR of M1c, which enables the lowering and building for TensorIR.
Please note that this PR will change the building progress if we input an IRModule.
Previously, we assume that the IRModule has done all the passes if we try to build an IRModule to a runnable Module.
However, TensorIR regards IRModule as the schedule unit, so that we may want to build an IRModule at any stage. (has done no passes, some of the passes or all of the passes). We will apply all passes to an IRModule when we want to build it.
cc @tqchen @junrushao1994 @comaniac @jcf94 @xqdan

Let's fix the CI and get it merged :-)


typescript compiler error

> shx rm -rf dist && tsc -b

node_modules/@putdotio/api-client/dist/resources/Auth/types.d.ts:1:31 - error TS2307: Cannot find module 'utils/types' or its corresponding type declarations.

1 import { ISODateString } from 'utils/types';
                                ~~~~~~~~~~~~~

Found 1 error.

hey @jackalcooper! are you sure it's using tsconfig.json?
seems like it's not getting rootdir: src, and it's causing unresolved aliases.


Optimize session auth tag generation

I profiled my application and crypto/hmac.New was taking 5.71% of the
total CPU time. Since the session key does not change, you can call
crypto/hmac.Reset() instead of making a new object. This reuses previous
work done for the key.
name                 old time/op  new time/op  delta
EncryptRTP-8         2.17µs ± 4%  1.90µs ± 5%  -12.79%  (p=0.008 n=5+5)
EncryptRTPInPlace-8  2.14µs ± 4%  1.84µs ± 4%  -13.79%  (p=0.008 n=5+5)

btw, DecryptRTCP doesn't check the auth tag.

@kixelated
Blah thanks for catching that, would be awesome if you could fix + add tests for that also! Thanks so much


Update docs to specify that getNumberType only returns an answer IFF the number is valid

So that calling this function to check if a given string is of a mobile phone - won't need to also call "isValidNumber" :
public static boolean isValidMobileNumber(String phone) {
    if (TextUtils.isEmpty(phone))
        return false;
    final PhoneNumberUtil phoneNumberUtil = PhoneNumberUtil.getInstance();
    try {
        PhoneNumber phoneNumber = phoneNumberUtil.parse(phone, Locale.getDefault().getCountry());
        PhoneNumberUtil.PhoneNumberType phoneNumberType = phoneNumberUtil.getNumberType(phoneNumber);
        return phoneNumberType == PhoneNumberUtil.PhoneNumberType.MOBILE;
    } catch (final Exception e) {
    }
    return false;
}

?

Yep, you're right: if you ask for the type, and you get MOBILE, it is also
valid.
2017-01-18 9:47 GMT+01:00 AndroidDeveloperLB<EMAIL_ADDRESS>
So that calling this function to check if a given string is of a mobile
phone - won't need to also call "isValidNumber" :
public static boolean isValidMobileNumber(String phone) {
if (TextUtils.isEmpty(phone))
return false;
final PhoneNumberUtil phoneNumberUtil = PhoneNumberUtil.getInstance();
try {
PhoneNumber phoneNumber = phoneNumberUtil.parse(phone, Locale.getDefault().getCountry());
PhoneNumberUtil.PhoneNumberType phoneNumberType = phoneNumberUtil.getNumberType(phoneNumber);
return phoneNumberType == PhoneNumberUtil.PhoneNumberType.MOBILE;
} catch (final Exception e) {
}
return false;
}
?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/googlei18n/libphonenumber/issues/1512, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AIjis5_TBVMMMSobOOGn_GqGlTNPd6gZks5rTdG6gaJpZM4LmnPt
.

So no need to call isValidNumber , right?
Can you please update the docs about it?

Correct, no need.
Which docs would you like us to update in particular? Where did you look
for an answer?
2017-01-18 9:59 GMT+01:00 AndroidDeveloperLB<EMAIL_ADDRESS>
So no need to call isValidNumber , right?
Can you please update the docs about it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/googlei18n/libphonenumber/issues/1512#issuecomment-273419404,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIjis66-tGLg1Gh0oQQ8hO_sC4NfGGI0ks5rTdR7gaJpZM4LmnPt
.

For "getNumberType" ...

Feasible: in e.g. the US we can't tell, so we return FIXED_LINE_OR_MOBILE.

Changed this to an issue so we can track it.
In future, for questions please join the discussion group and send an email there.

Can you also update the docs to have a note about the US issue (or in general) ?
Does it occur only for US phones?

US, CA, some other countries, yes. There is a comment on the enum itself about this.

So this is why you wrote "whenever feasible" ? Because sometimes it's not possible to know?

Yes, because sometimes we don't know if it's mobile or fixed-line, so we can't return MOBILE, so we return FIXED_LINE_OR_MOBILE.

I see. That's too bad. Is there any way to overcome this?

Not using libphonenumber but you could try a pay-per-use option like
Pathfinder

jan. 2017 4.27 p.m. skrev "AndroidDeveloperLB"<EMAIL_ADDRESS>

:

I see. That's too bad. Is there any way to overcome this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/googlei18n/libphonenumber/issues/1512#issuecomment-273506148,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIjis51FsmkUcLD34K3ScXf24ecxeDnbks5rTi9VgaJpZM4LmnPt
.

Any option by Google? After all, Google has tons of information....

Nope.
2017-01-19 9:09 GMT+01:00 AndroidDeveloperLB<EMAIL_ADDRESS>
Any option by Google? After all, Google has tons of information....
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/googlei18n/libphonenumber/issues/1512#issuecomment-273707583,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIjis4L-obh9mNneV0haTC2BGUaY91luks5rTxpIgaJpZM4LmnPt
.

Too bad. Can you show the website of "PathFinder", please?

Hi @AndroidDeveloperLB, I did a Google search for "pathfinder phone numbers" and this was the second result: https://www.neustar.biz/communications/address-and-routing/pathfinder. Hope it's helpful!
I'd like to focus this issue on updating the javadoc, so if there are other non-issue questions please post them on the discussion group.

@keghani  OK thank you. Wonder what their prices are. I was told that it's very expensive.
Anyway, thanks.

Re-opening to track the javadoc.

The javadoc is updated as part of release 8.7.0.
Hence closing this as fixed.


log errors to stderr

Sorry for the delay @ebdrup this has been solved by #42 and will be in the next release

Very nice. Thanks... Look @eagleeye @jonatanpedersen

Ah, i didn't realize multiple people were in need, sorry about that again, let me know if there are problems, the tests i ran TeamCity fails if you check the "an error message is logged by build runner" box from the output.


Add sql to error messages.

We've been using this change on our project and it has greatly improved our debugging. We're using it in Loopback and we would often get errors straight from the mysql package, but not have any idea which query generated them.
The change is a little hacked in as is, but I'm open to modifying it as needed to get merged.

Hi @scottaj, I think adding the query makes sense (not not in the actual message). Can you follow this up with the additional work to get this into a state ready for us to accept?

Make sure no existing tests fail.
Add tests that cover your new feature.
Add documentation for your new feature.

Thank you!

I think adding the query makes sense (not not in the actual message)

Just to be clear, you think adding the query is okay, but not in the actual error message?
I'll work on the tests ASAP, I just wanted to get the change reviewed first.

Just wanted to post this as a point in favor of having the query in the error message. This is from a run of the project test suite, and the addition of the query text make the otherwise somewhat ambiguous error really obvious.

Hi @scottaj, yes, I meant to only put it in the .sql property and not the message. I absolutely disagree it helps in any way with your example, and it is going to lead to a lot of issues being in the message, as a query can be many kilobytes in size, and it is going to really mess up people's logging if a dozen KB string appears in there.

Fair enough, it's your call. Do you think there is any value into looking at adding it to the message under some type of config option, maybe in another PR? FWIW, keeping it out of the message means that my team will probably continue to use our own fork with it in there because for us it is a night and day difference as far as debugging goes.
I'll go ahead and move forward with pulling it out of the message and taking care of testing and documentation.
Speaking of testing, the CI build failed on about half of the node versions it ran on on a specific test with a timeout error. I can't seem to reproduce it locally. Is that a know issue with the CI suite, or is it likely a regression I added?

Do you think there is any value into looking at adding it to the message under some type of config option, maybe in another PR?

No, because that's not a good use of the Error object. I understand that you are probably using very simplistic error logging that only logs the error's .message property, and you may want to revisit that decision at some point. I can't image that you cannot add into your logging solution a if statement to append the .sql property to your logged message when logging an error object, at the very least.

Speaking of testing, the CI build failed on about half of the node versions it ran on on a specific test with a timeout error. I can't seem to reproduce it locally. Is that a know issue with the CI suite, or is it likely a regression I added?

I'm not sure, as I've never had that problem. You did alter the error message and we check that all over the tests, so are you sure that that doesn't have something to do with it? The master branch ran clean just 9 days ago when it was last run. If you can investigate why the failures are happening if you don't think it was your test, that would be useful as well :) It's possible something changed in Travis CI between now that then (and the issue would prevent me from merging any PR until I can get it addressed, anyway).

I absolutely agree with @dougwilson that the sql should not be in the message.
Thinking out loud - There are some security concerns to be mindful of.  The sql query itself can easily contain sensitive information (ssns, table structure, internal ids) that should not be exposed to someone who might receive the sql error (either the end client by accident, third party log analyzers etc).
One way to prevent this kind of a leak is to define the .sql property as enumerable: false - in which case the .sql does not show anywhere unless you specifically ask for it.
Object.defineProperty(err,'sql',{value: sql, enumerable: false});

In this the .sql wont show up through stringify or looping through keys.  The only way to look at the sql is by accessing it directly, i.e. err.sql (which you can easily do in a custom error logger)

I updated the code to remove the query from the error message. I also added a unit test and some documentation.
My CI build is still failing, and it looks like the other two most recent PRs are failing with the same issue, so I am pretty confident it is not a regression. It looks like it is some kind of race condition in test-connect-timeout. I tried to debug locally, but I could not reproduce it and I am not familiar enough with the code to trace down where it might be coming from easily. If someone could point me towards where I might start looking for the issue or tips on how I might reproduce it locally, I'd be happy to debug more.

My CI build is still failing, and it looks like the other two most recent PRs are failing with the same issue, so I am pretty confident it is not a regression. It looks like it is some kind of race condition in test-connect-timeout. I tried to debug locally, but I could not reproduce it and I am not familiar enough with the code to trace down where it might be coming from easily. If someone could point me towards where I might start looking for the issue or tips on how I might reproduce it locally, I'd be happy to debug more.

I think I have the issue fixed now, though I don't think it will reflect in your PR unless you rebase the changes on top of the current master.

No matter what way~ pls land this feature in the module 😂

How can I move along this?


Add PowerShell version of FhirImporter

The FhirImporter Azure Function in this repository is tremendously useful for bootstrapping environments for Azure API for FHIR. However, in some situations the overhead of setting up the function app, the RBAC rules, the storage account, etc. can be non-desirable, e.g. when setting up personal development environments and wanting to iterate quickly on data imports. As such, this pull request adds a PowerShell script that emulates the functionality of the FhirImporter Azure Function and pushes data files from the local drive into an Azure API for FHIR.
The script works nicely for data files generated by synthea, e.g. using this approach:
# generate synthetic data
git clone "https://github.com/synthetichealth/synthea"
Push-Location .\synthea
& .\run_synthea -s 1234 -p 25
Get-ChildItem .\output\bundle\fhir
Pop-Location

# import data into fhir server
git clone "https://github.com/microsoft/fhir-server-samples.git"
Push-Location .\fhir-server-samples
.\src\FhirImporter\FhirImporter.ps1 -FhirServerUrl https://<myaccountname>.azurehealthcareapis.com -BundlesDirectory ..\synthea\output\bundle\fhir
Pop-Location

@c-w, thanks for putting this up. I don't think we are going to be merging this in. There are other command line loader tools (e.g. https://github.com/hansenms/FhirLoader) that handle things such as parallelization, e.g. to get reasonable performance on the ingest. Moreover, we would have to add tests to make sure that this actually works, which would require additional infrastructure.
I think the tool has some merit, but should maybe live in a separate toolbox somewhere?

@hansenms Thanks for the pointer to the FhirLoader repo. Very useful. Would you be open to a pull request to FhirLoader that enables passing-in an access token so that the tool can be used in combination with Azure CLI as shown in the script in this pull request?

Sure, that sounds good. I think I even had a branch at some point that took in a token, but I never really got it merged in.


[CLU] Adding x-ms-client-names properties for confidenceScore

To ensure consistency with question answering, any mention of confidenceScore should be renamed to confidence in the SDK. Since the question answering SDK implements this using the swagger "x-ms-client-name" property, we would like to add it to the conversations swagger as well. This change should be considered after the release of the PuP later today.
Manually adding folks for review.
@heaths @ChongTang @annatisch
I've also caught the following bug:
The QuestionAnsweringTargetIntentResult references  the 2021-07-15-preview question answering swagger in this line of code, which does not have the renames for the confidenceScore properties. We would ideally like this to reference the stable question answering swagger. Should we bring the stable question answering swagger to this branch and reference it? Or should we add a static reference to the swagger on the other branch?

@AhmedLeithy The stable version of the Question Answering was not merged when I made this change. In the stable version, they removed the KnowledgeBaseAnswers definition and use the KnowledgeBaseAnswer as their response. Do you want me to create a PR to refer the stable version now? If I create a PR to update this, will it interrupt your work flow?

@AhmedLeithy Got it. I will create it soon.

@ChongTang you can safely change model names in the swagger as needed, but changing property names - if you don't have enough time in the service - can be done with x-ms-client-name that only impacts autorest-generated clients like the Azure SDKs.

Got it. For the confidence thing, we agreed to use "confidenceScore"
instead of "score". I am not sure how "confidence" appears. :)
On Wed, Nov 3, 2021 at 10:39 AM Heath Stewart @.***>
wrote:

@ChongTang https://github.com/ChongTang you can safely change model
names in the swagger as needed, but changing property names - if you don't
have enough time in the service - can be done with x-ms-client-name that
only impacts autorest-generated clients like the Azure SDKs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Azure/azure-rest-api-specs/pull/16646#issuecomment-959768313,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA3YR52GDDTIWA6QNYVGFDTUKF6VFANCNFSM5HIWWPKA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Got it. For the confidence thing, we agreed to use "confidenceScore" instead of "score". I am not sure how "confidence" appears. :)
…
On Wed, Nov 3, 2021 at 10:39 AM Heath Stewart @.***> wrote: @ChongTang https://github.com/ChongTang you can safely change model names in the swagger as needed, but changing property names - if you don't have enough time in the service - can be done with x-ms-client-name that only impacts autorest-generated clients like the Azure SDKs. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16646 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3YR52GDDTIWA6QNYVGFDTUKF6VFANCNFSM5HIWWPKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

During the archboard review of Question Answering, the architects want just confidence or confidenceThreshold (instead of confidenceScoreThreshold) for the SDK. You do not need to change the model properties, but we'll want to be consistent across the SDKS.

@ChongTang, given this is what the SDK archboard wants, do you have any objections? You don't need to change the service models.

@ChongTang, given this is what the SDK archboard wants, do you have any objections? You don't need to change the service models.

Sounds good to me.


First Draft of Trac migration to Pelican

This is my first try at migrating trac pages to RST Pelican.
So far 32 pages have been merged, including (I think) the most important ones about contributing.
I've used twisted.org as the main host, but can revert easily to twisted.github.io if need be.
There are still areas of improvement on the currently migrated pages:

a few links are broken
some title weights are incorrect
I have to fix the trac links currently labeled as fixme

Also I don't know which pages are obsolete and don't really need migrating.

CI pages seem obsolete
GSOC and WomenOutreach as well?
What about Infrastructure?

I plan on:

fixing the actual issues with the currently migrated pages
add new pages on a regular basis

twisted.github.io redirects to twisted.org so that should be ok?

@JudgeGregg thanks so much for your work on this! do you have somewhere I can preview the rendering of this?

Yes, just wanted to be sure :)
Also, the good news is that the files are almost pure RST, (apart from the internal pages links, specific to Pelican), so migrating to another Wiki should be easier if needed.

@JudgeGregg thanks so much for your work on this! do you have somewhere I can preview the rendering of this?
Yes, at
https://judgegregg.github.io/peliwiki/

I suspect we'll probably want something like this? https://github.com/marketplace/actions/github-pages-pelican-build-action
I've currently got the repo configured as a bare github pages project so I'll need to tweak the branch to gh-pages

It should work, although I'm not familiar at all with GH Actions.
Maybe GH_PAGES_BRANCH could be set to "main", that way we won't need gh-pages?

Maybe GH_PAGES_BRANCH could be set to "main", that way we won't need gh-pages?

I think this will cause the action to push to main recursively

the

Want to use Twisted for web development? Please read this page first!

link links to https://judgegregg.github.io/peliwiki/%7Bfilename%7D/pages/WebDevelopmentWithTwisted.rst

Ok I'll focus on T-Web next. Any page with "filename" in its url means it's a broken internal link, because the page hasn't been migrated, or it's a typo.

@JudgeGregg there's at least three threads of discussion here

eg how to go about building and automating deploying the content
what content to include/exclude eg legacy stuff about CI that's obsolete
technical details about the current implementation eg as you mentioned - typos, or broken links

I enabled "discussions" to facilitate this https://github.com/twisted/twisted.github.io/discussions

Ok thanks, I'll open the relevant discussions there :)

@JudgeGregg perhaps a "show and tell" discussion and I can start three nested threads there?

Thank you, I updated the sites with the new index page.
In order to summarize, so far we have:
https://judgegregg.github.io/peliwiki/ -> 37 wiki pages migrated to pelican RST like
https://judgegregg.github.io/sphinxwiki/ -> 37 wiki pages migrated to sphinx RST with Furo theme
I'll see if I can start working on a pelican theme based on the new index page, as per your suggestion (unless we stick to GH announcements).
However what should we do with the already migrated pages ? We can indeed integrate them with the existing RTD site, or simply ditch them.
Maybe glyph has another idea ?

Awesome work.
I think that if sphinxwiki is migrated we can just use Sphinx.
And the Furo theme looks awesome and comes with dark/light theme ... so more awesomeness :)

Most of the important and still relevant content from the Trac wiki should be migrated into the main documentation at https://docs.twistedmatrix.com/en/stable/

Many pages from Trac wiki are no longer relevant / outdated / and only have historical value.
We can keep them (and their history) using GitHub Wikis
https://github.com/twisted/twisted/wiki/TwistedCommunity

For the new https://twisted.org/ what I think is missing, are the blog posts from #8.
So rather than migration the wiki pages to pelican or Sphinx, I think that it would make more sense to migrate the blog post.
Just my view :)


Removing EL6 support

Description
EL6 is EOL. It is on extended support currently and while we debate supporting it, we need a release build of chef-17 to pass around to people to test with
Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
[ ] All new and existing tests passed.
[ ] All commits have been signed-off for the Developer Certificate of Origin.

Corrected, now closing this


Add support for mds without predefined attention mask

Changes
This PR enables reading mds data that does not have a predefined attention_mask.
As the attention mask is redundant to store in mds in our standard case (as it is just an array of ones with the same length as the input_ids), we have removed it in the new batches of data that we are processing. This PR accommodates this update, enabling training with this new format.
With this PR, supporting mds-data requiring less storage, the reads from disk is significantly reduced.
Additionally the conversion script of mds-data has been made more efficient.
Tests
I have taken mds-data with predefined attention masks, that I then have removed the attention masked from using the conversion script. Using the original data, and the new data without attention masks, I have achieved close to identical loss curves with and without predefined attention masks. I have verified this both with and without streaming.

LGTM


Formatting Issue (EOL, identation, quotes)

Case
Help Question
Issue
Trying to use this resume, npm run dev gives multiple errors.
Info

Operating System: Windows
Node-Version: 10.16.0

Reproduce
http://eslint.org/docs/rules/indent  Expected indentation of 4 spaces but found 2
src\pages\resume.vue:15:1
http://eslint.org/docs/rules/quotes  Strings must use singlequote
src\pages\resume.vue:14:30
http://eslint.org/docs/rules/linebreak-style  Expected linebreaks to be 'LF' but found 'CRLF'
src\terms.js:16:28
Getting over a 100 errors, unable to sit and fix each. What am i doing wrong?

Used solution from #323 to fix EOL
Tried something similar for quotes and indentation.
I get error using both indentation 2 and 4


Expose PrimesElem as #math.primes in Typst code

Hi - when writing packages I found sometimes I could not do content.func() == math.foo-bar before introspecting fields in  FooBarElem. This PR fixes this issue and adds a test.
In particular, the list added three missing elements: MathStyleElem (which motivated this PR), AlignPointElem, and PrimesElem.

Hi - since MathStyleElem is an implementation detail and therefore should be hidden from users, it probably shouldn't be an Elem at all? In the status quo, there's no good way to inspect the body of a MathStyleElem because the code can't check content.func() == math.math-style  first. This difficulty makes MathStyleElem not really "hidden".
For example, I'd like to write this. Without this PR, it will return different results for inputs a+b/2 and display(a+b/2), but users will expect the same result because display(..) just displays things a bit differently.
#let __is_add_sub_sequence(content) = {
  if not content.has("children") { return false }

  let impl(seq) = {
    // Only check the top level, don't descend into LR groups
    for child in seq.at("children") {
      if child == [+] or child == [#sym.minus] { return true }
    }
    return false
  }

  // Before https://github.com/typst/typst/pull/3063:
  return impl(content)
  // After https://github.com/typst/typst/pull/3063:
  // if content.func() == math.math-style {
  //   return impl(content.at("body"))
  // } else {
  //   return impl(content)
  // }
}

since MathStyleElem is an implementation detail and therefore should be hidden from users, it probably shouldn't be an Elem at all?

As said above, it is supposed to be removed in the future in favor of using the normal styling mechanisms. It is a hack.

This difficulty makes MathStyleElem not really "hidden": it has observable effects in coding.

That's what I mean with "unfortunately it can't be because there is no privacy concept".
In the future, display should result in a styled element, just like a normal set rule does.

Thanks! So this PR only adds the forgotten PrimesElem, and I modified the PR's title accordingly.
As for AlignPointElem: removed from the PR since you have not decided on a better name yet :) it's not that "urgent" to expose it - I guess there's not many use cases for it anyway. But long term, I believe it's better to expose it.
As for MathStyleElem: removed from the PR, since that elem will be refactored as mentioned above.

Great, thanks!


Sidebar improvements proposal

🐛 Bug Report
Whenever the Sidebar gets changed either by adding new links or reordering links. The Sidebar test will fail since it references hard-coded index locations of menu items. It might be better if the Sidebar tests, instead of expecting the menu items to be in specific locations (exception Dashboard (always first), Patients(always second), other modules then come, and then Incidents always last, since it is not linked to patients.
This was the modules links between the Patients and Incidents links can be reordered without breaking the tests
To Reproduce
Edit src\shared\components\Sidebar.tsx by reordering the modules links
Steps to reproduce the behavior:
Change for example this:
          {getMedicationLinks()}
          {getImagingLinks()

by reordering the function calls to be:
          {getImagingLinks()
          {getMedicationLinks()}

This reorders the links on the rendered Sidebar, breaking the Sidebar tests since the tests are hard coded to look for the links in specific index positions.
Expected behavior
Reordering the Sidebar links of modules other than the Dashboard, Patients, and Incidents links should not break the Sidebar tests.
We can maybe reorder the Sidebar links as below i.e. Dashboard (first), Patients(second), Incidents (last) and the rest can be in any order as long as its between Patients and Incidents links:
          {getDashboardLink()}
          {getPatientLinks()}
          {getAppointmentLinks()}
          {getLabLinks()}
          {getMedicationLinks()}
          {getImagingLinks()}
          {getIncidentLinks()}

Your Environment

node version: 6,8,10
fastify version: >=1.0.0
os: Mac, Windows, Linux
any other relevant information

Can I give it a shot ?

Absolutely @rsousaj

Just to be sure, I checked in last commit and Incident is not the last item on Sidebar.
This is the actual order:
      {getDashboardLink()}
      {getPatientLinks()}
      {getAppointmentLinks()}
      {getLabLinks()}
      {getIncidentLinks()}
      {getMedicationLinks()}
      {getImagingLinks()}

Said that, what should be the right approach ?

Hi @rsousaj, you can do it this way.
Dashboard
Patients
Appointments
Medications
Labs
Imaging
Incidents
Don't forget the Sidebar test as that's where things get interesting :)


Double Tap Commands

This is a wild suggestion, but maybe the ability to double tap certain non problematic keys can be used as shortcuts to some operations.
For instance, say you press ctrl and very quickly you press ctrl again, as some sort of double click but for a keyboard key. And doing this triggers a programmable action, like Go To Symbol or Toggle Sidebar for example.
I have implemented this myself, and it's actually not easy to do right, some things have to be taken into account as to reduce accidental triggers.
Just wanted to share the idea.

Possible duplicate of #5280

:+1: Given the similarity (repeated modifier only keybinding) I would suggest to track in #5280 .


Start using tree-sitter

I've tried out python-ts-mode and it gives better highlightning, need update config to make use of it automatically. Also have to figure out if it is possible to check if grammar is installed.

Added it to cmake, dockerfile, rust and go.


some moisture damage won't be obvious to player

In some situations, like when seahorses and crabs hit obstructions, they take moisture damage. If that happens to kill a unit, it's not obvious to the player what caused that death. Happens most often when sending units along the top or bottom border. The player wouldn't realize that strategy is extra dangerous.

may not be relevant. moisture and health have been combined.


Loading a script that uses it's own class_name creates orphans despite scripts being references

Godot version:
3.2.3.stable.custom_build (I got it from the AUR)
OS/device including version:
Using GLES3 video driver
OpenGL ES 3.0 Renderer: GeForce GTX TITAN X/PCIe/SSE2
Arch Linux (don't think it's relevant?)
Issue description:
You get a lot of orphan warnings when a script uses it's class name inside itself and it gets loaded without being used. Simply mentioning the class_name anywhere else will bubble up the issue.
ERROR: ~List: Condition "_first != __null" is true.
   At: ./core/self_list.h:112.
ERROR: ~List: Condition "_first != __null" is true.
   At: ./core/self_list.h:112.
WARNING: cleanup: ObjectDB instances leaked at exit (run with --verbose for details).
   At: core/object.cpp:2135.
Leaked instance: GDScriptNativeClass:824
Leaked instance: GDScript:1177 - Resource path: res://broken_class.gd
Hint: Leaked instances typically happen when nodes are removed from the scene tree (with `remove_child()`) but not freed (with `free()` or `queue_free()`).
ERROR: clear: Resources still in use at exit (run with --verbose for details).
   At: core/resource.cpp:477.
Resource still in use: res://broken_class.gd (GDScript)

Steps to reproduce:
# test.gd
extends Node
const SCRIPT_PATH := "res://broken_class.gd";
func _ready():
  var script := load(SCRIPT_PATH);

# broken_class.gd
class_name BrokenClass
extends Node

var variable := false;

func broken_function(BrokenClass: BrokenClass) -> bool:
  return variable == variable;

Minimal reproduction project:
engine_bug.zip

If this is actually intentional (much like you shouldn't use self.set_variable since it causes a recursive dependency) then maybe consider adding a clause in the static typing docs since I didn't see anywhere that there was a rule about using a classes name inside its own file. There's only one for using two classes that depend on each other (which has an in-editor warning and is fine).

Duplicate of https://github.com/godotengine/godot/issues/16959?

Duplicate of #16959?

Ah yes, the comments of that bug are certainly related, although the original post seems a little different.
Firstly, in that bug, using 'load' is listed as a work around, but it was the load that triggered the bug for me.
Secondly, that bug is about two scripts loading each other. This is about a script recursively loading itself due to class_name, triggered by a load.
Either way sorry for submitting if it is an issue. I didn't see that other one.

Either way sorry for submitting if it is an issue. I didn't see that other one.

I can leave this issue open, it sounds different enough.

Looks that it may be fixed in Godot 3.2.4(I can't reproduce leak)

Looks that it may be fixed in Godot 3.2.4(I can't reproduce leak)

That's promising news - I think the AUR is still using 3.2.3 so looking forward to fix these things! I guess I should close unless anyone has anything else to add.

The specific test project in the OP seems fixed in 3.2.4 RC 3 indeed.
There are still similar issues which are reproducible such as https://github.com/godotengine/godot/issues/16959#issuecomment-772524724 and #21461 though.


set['rbenv']['gems'] parsed incorrectly

This attribute:
set['rbenv']['gems'] = { '1.9.2-p290' => [
    { 'name'    => 'rbenv-rehash', 'version'=> '0.2' },
    { 'name'    => 'bundler', 'version' => '1.1.rc.7' },
    { 'name'    => 'chef', 'version' => '0.10.8' } ] }

Triggers this error:
Chef::Exceptions::ValidationFailed: rbenv_gem[global::rbenv-rehash] (system) (rbenv::system line 32) had an error:   Chef::Exceptions::ValidationFailed: Option rbenv_version must be a kind of String!  You passed false.

It seems that the hash key '1.9.2-p290' is not recognized as being the rbenv_version?

Came across this today actually :) Thanks!


BUG: Not sending CMCD data on manifest request.

What did you expect to happen?
For all the requests to the CDN that come out of the player to have CMCD data, including all audio/video and initial requests for the index range of a fragment.
What actually happened?
When a content is played the initial request asking for the manifest does not contain CMCD data in the URL (as queryparams). This causes the (our validator) app to report an error.

This will be fixed with the merge of the branch: https://github.com/montevideo-tech/videojs-cmcd/tree/21-bug-not-sending-cmcd-data-on-manifest-request


citation missing?

The README says that the centers and radius are taken as follows:
centers are taken uniformly from the bounding hyperrectangle of the inputs, and
radius = max(||x-c||)/sqrt(n_centers*2)

but citation [2] only talks about ELM, and [3] talks about RBF, but the centers and radius are taken in a different way. Is the solution in this implementation an idea of @dclambert or is there a citation missing?

There is a citation missing.  Unfortunately I’m not sure where I got this anymore.

It seems a pretty critical issue to describe why this implementation uses this particular model. Also none of those two papers seem to describe why the activations from both ELM-RBF and ELM-MLP are summed (https://github.com/dclambert/Python-ELM/blob/master/elm.py#L357). It may be useful to set alpha to 0 or 1 to select between both, but a weighted average seems unfounded without justification.


set kuberay apiserver version

Why are these changes needed?
Replace the nightly built image with the latest release one (v1.2.2)

@revit13 , please take a look, I changed the kuberay apiserver deployment, but none KFP test was executed.


Can not customize the mail components in HTML blade template (not Markdown template)

Laravel Version: 5.4.15
PHP Version: 5.6
Database Driver & Version: mysql

Description:
I want to customize the mail template components by following the guide of Laravel 5.4, but I get an Error after that:
ErrorException in FileViewFinder.php line 112:
No hint path defined for [mail]. (View: /resources/views/emails/html/order/confirmed.blade.php)
Reason for using HTML template instead of Markdown :
For markdown template, I was unable to embed image in the mail because of this bug:
https://github.com/laravel/framework/issues/17629
Steps To Reproduce:

php artisan make:mail OrderConfirmed
php artisan vendor:publish --tag=laravel-mail
create a html blade template in /resources/views/emails/html/order/confirmed.blade.php
use the blade template in App\Mail\OrderConfirmed.php

resources/views/emails/html/order/confirmed.blade.php:
@component('mail::message')

Order Confirmed

Your order is confirmed!

@component('mail::button', ['url' => $url])
View Order
@endcomponent

Thanks,

{{ config('app.name') }}

@endcomponent

App\Mail\OrderConfirmed.php:
<?php
namespace App\Mail;

use Illuminate\Bus\Queueable;
use Illuminate\Mail\Mailable;
use Illuminate\Queue\SerializesModels;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Support\Facades\URL;

use App\Order;

class OrderConfirmed extends Mailable
{
    use Queueable, SerializesModels;

    /**
     * The order instance.
     *
     * @var Order
     */
    public $order;

    /**
     * Create a new message instance.
     *
     * @return void
     */
    public function __construct(Order $order)
    {
        $this->order = $order;
    }

    /**
     * Build the message.
     *
     * @return $this
     */
    public function build()
    {
        return $this->view('emails.html.order.confirmed')->with(['url' => URL::to('order/show/'.$this->order->id)]);
    }
}

These views are used to render the HTML version of the markdown email, I know it may be confusing a bit but these views are only available when you're sending a markdown email.
When you send a markdown email laravel creates an HTML version as well as a markdown version of your email, the html views you are referring are not publicly available as a blade template, they're only accessible from within the markdown email.

@themsaid sorry it's my misunderstanding, I will give markdown mail another try, thanks.

Are you 'themsaid' saying blade rendering is only for markdown?

@themsaid thanks for clarifying this! But then why when I publish the mail assets for customization, the html version I get also uses components? It gives the idea that you can use components for pure HTML email messages. Thanks!


Restart immeadiatly after jailbreaking

Everytime try jailbreak, it manages to load the jailbreak, then it resprings, with the loading sign. When the respring finishes, like the loading sign goes away, it restarts, without ever showing the lock screen. Therefore, Cydia crashes as my device is in its unjailbroken state. It’s an ipad 6th gen, ios 12.1

i have a same problem like this

This better not be marked as fixed, this issue still persists in b34. I restored rootfs for b33 like Pwn advised and still getting this issue. Reload System Daemons must be turned off for it to not respring loop.

Hello there, I had the same problem after upgrading from b27 - b34 on iOS 11.4.1, today I upgraded again to b36 with hopes that the problem would solve itself, unfortunately it didn’t. However after doing some research I was able to fix the issue with a combination of all the suggestions and information I’ve gathered, in the end it turned out to be a simpler fix than expected.
Here was my fix;
Step 1: uninstall unc0ver b34 and download b36 (first try without this step) optional
Step 2: turn on Airplane Mode
(VERY IMPORTANT , I’ve never had to use airplane mode to jailbreak before but after wasting hours trying to fix this issue without airplane mode, it proved to be a vital in this fix)
Step 3: open unc0ver
Step 4: open Settings
Step 5: toggle Restore RootFS ON - toggle Reload System Daemons OFF
Step 6: toggle to the jailbreak screen and tap JailBreak
Step 7: (after Restore RootFS is successful and the device reboots) open unc0ver, select settings again and be sure that Reload Systems Daemons is still toggled OFF (keep Airplane mode ON)
Step 8: Tap on Jailbreak (your phone may/will reboot a couple times during this process, keep Airplane mode ON and go through the usual jailbreaking procedure)
I hope this fix works for you, I’ve wasted a lot of time constantly jailbreaking my device over the past couple of days only for it to reboot after 38/38 which kept my device in an unjailbroken state, it was mighty stressful. GOODLUCK everyone.

Hello there, I had the same problem after upgrading from b27 - b34 on iOS 11.4.1, today I upgraded again to b36 with hopes that the problem would solve itself, unfortunately it didn’t. However after doing some research I was able to fix the issue with a combination of all the suggestions and information I’ve gathered, in the end it turned out to be a simpler fix than expected.
Here was my fix;
Step 1: uninstall unc0ver b34 and download b36 (first try without this step) optional
Step 2: turn on Airplane Mode
(VERY IMPORTANT , I’ve never had to use airplane mode to jailbreak before but after wasting hours trying to fix this issue without airplane mode, it proved to be vital in this fix)
Step 3: open unc0ver
Step 4: open Settings
Step 5: toggle Restore RootFS ON - toggle Reload System Daemons OFF
Step 6: toggle to the jailbreak screen and tap JailBreak
Step 7: (after Restore RootFS is successful and the device reboots) open unc0ver, select settings again and be sure that Reload Systems Daemons is still toggled OFF (keep Airplane mode ON)
Step 8: Tap on Jailbreak (your phone may/will reboot a couple times during this process, keep Airplane mode ON and go through the usual jailbreaking procedure)
I hope this fix works for you, I’ve wasted a lot of time constantly jailbreaking my device over the past couple of days only for it to reboot after 38/38 which kept my device in an unjailbroken state, it was mighty stressful. GOODLUCK everyone.

When do we turn 'Reload System Daemons' back on?

Duplicate of #403


Improve configuration API for 1.23

The previous commit for configuration APIs has some nits to fix:

The client-authentication API has both v1beta1 and v1 supported.
We need to include both.
The kube-scheduler v1alpha1 is superceded by v1alpha3 which is new.
The links to some external type definitions should point to the 1.23
API rather than old versions.

/approve

Previews:
https://deploy-preview-30826--kubernetes-io-main-staging.netlify.app/docs/reference/#config-apis
https://deploy-preview-30826--kubernetes-io-main-staging.netlify.app/docs/reference/config-api/kube-scheduler-config.v1beta3/
https://deploy-preview-30826--kubernetes-io-main-staging.netlify.app/docs/reference/config-api/kubelet-config.v1beta1/

/lgtm


Update directed KATs with pure MLDSA

update this https://github.com/chipsalliance/adams-bridge/pull/50 with Pure MLDSA KATs


tcell hangs in go1.10

Looks like with the upgrade to Go v1.10, tcell programs hang at the end and require  an extra Ctrl-C (SIGINT) signal to be stopped. I haven't looked into the code in detail but I believe that Fini() does not return.
Just to be sure, I also tried it with Go v1.9.4 and it works there so it appears to be a Go-related change that's causing this.

Argh.  Ok, I'll look, thanks for letting me know.

I was just about to write an issue on this myself. I spent half a day debugging my own code until I checked out the tcell/_demos and realized it probably wasn't my fault this time. I hadn't noticed the go update.
On macOS, Fini() clears the terminal nicely, but then hangs and wait for input. A simple enter will make it exit as well as Ctrl-C of course.

I've done a little testing, and yeah, t.in.Close() is hanging.  This is a bug in golang.  They've refactored the close API for some reason, and Close no longer returns immediately.
I'll do a little more thinking on this.

Yeah, we should be getting io.EOF on the file being closed in the inputLoop, but with golang 1.10 that no longer occurs.  They've broken the underlying file behavior so it is no longer thread/goroutine safe.  Aargh.

Is this actually a bug in Go v1.10 or do you think this is an intentional breaking change? There is an entry in the release notes, is it related to this?

Also matching net.Conn, File's Close method now guarantee that when Close returns, the underlying file descriptor has been closed. (In earlier releases, if the Close stopped pending I/O in other goroutines, the closing of the file descriptor could happen in one of those goroutines shortly after Close returned.)

I don't know about everybody else but if this is a Go bug and by filing it, we can expect it to be resolved with v1.10.1, I'm ok waiting for that instead of working around it.

I've filed https://github.com/golang/go/issues/23943 against golang.

Actually, as I think about this... what we really need is a way for us to signal the inputLoop.  This is the source of much pain and suffering in tcell in the past.  Unfortunately, I don't think we have a way to poll() from a single thread / goroutine -- which means that the usual trick of using another file descriptor to wake the reader doesn't work here.  This trick is specifically needed on macOS, because the macOS terminal driver close behavior works like this.  In the past I did crazy things like using termios timeouts to poll on this, to work around busted macOS tty drivers.

Basically, all this comes down to is that the macOS tty driver has this long well-known bug.  I'm inclined to simply go ahead and remove (or background in goroutine) the close routine.  Backgrounding means that it might eventually clear up, but in the meantime application programs will "leak" the descriptor and the goroutine(s) used to service it.   This probably isn't a big deal, since most terminal programs on macOS basically only shut down when the application is terminating anyway.

I really wish I had a FreeBSD system handy to test this with.  I think only the macOS driver is busted this way.

Btw, if anyone with one of the other BSD encounters the same problem, please let me know -- the workaround will be the same.  (Although for the FOSS platforms we should fix any of their tty drivers that suffer similar bustage.)

Your change solved the issue for me. I only call Fini() at the very end before exiting so it should be ok.
Thanks for handling this so quickly!


Unable to build win64 gpl image using makeimage.sh script

Hello BtbN,
First of all thanks a lot for your work on these scripts, they make life much easier. After a successful build last week I've been trying to build ffmpeg again but I'm getting the following error:

Looks like I'm missing one json file that's not there. These are the contents of my .cache/images/base folder:

I created a symlink to a94e853951d497b13ec1c3936f4f0621bf392050e1cec1bf7625d5443a965e19.json as index.json and tried again, but I'm getting a different error:

Any idea how to proceed?

Appreciate the quick response, sorry about the screenshots.
I was running docker v20 for some reason, I updated to the latest version and it worked like a charm. Thanks a bunch!


Chrome not working

I tried to download a midi and it didnt work, no download was initiated

Please uninstall any extensions you got from here. Instead, use Tampermonkey and follow the instructions in the new repo, as this repo is no longer updated: https://github.com/LibreScore/dl-librescore


Rail fence decode does not appear to work as expected

Describe the bug
Text created with the 'Rail Fence Encode' does not appear to be decodable with 'Rail Fence Decode' with the same key and offset.
To Reproduce
Click on https://gchq.github.io/CyberChef/#recipe=Rail_Fence_Cipher_Encode(3,0)Rail_Fence_Cipher_Decode(3,0)&input=Sm9sbHlCcm9rZW4 to load it in the simulator, or alternatively:

Add a Rail Fence Encode with key 3 and offset 0
Add a Rail Fence Decode with key 3 and offset 0
Enter "JollyBroken" into the encode
The output does not contain "JollyBroken" but rather "JorlyBnoke l"

Expected behaviour
When using the same cipher to encode and decode data, I would expect to see the plaintext in the result unchanged.
Screenshots

Additional context
Taken on the version on the website at time of raising bug,
Version 9.21.4
Compile time: 22/01/2021 19:00:54 UTC

What's odd is that the input length is 11; if the decode is a key length of 2 then the length is 11, but if the key length is 3 then the decode length is 12 and an extra space appears.
If I use "JollyBroken " with a space afterwards, the decode works as expected.

What's odd is that the input length is 11; if the decode is a key length of 2 then the length is 11, but if the key length is 3 then the decode length is 12 and an extra space appears.
If I use "JollyBroken " with a space afterwards, the decode works as expected.

Could #1069 be related to your problem? If so, there is a pull request in to fix that so if you are building locally you could try and apply those changes 🙂 #1108 may also be related

It’s the same issue as #1108 but I don’t know that #1069 will solve the problem. When encoding “JollyBroken” it gets displayed as “JykolBoelrn” with no spaces, but although the output of encode says “Length: 11” for the text, it also says “Length: 12” for the output of the cipher, which I suspect is where the space is coming from.
Simply deleting spaces isn’t going to fix the problem — if you type “JykolBoelrn” (no spaces) into a Rail Fence decode with key 3, it produces the incorrect output whether or to the space is there in the output. The issue seems to be that the decode is ‘rounding up’ the length of the string (11) to the nearest multiple of the key (12) which then affects the algorithm.

I have just run #1071 against this example and it works. The PR is removing the rounding in the decode operation and so no additional spaces are being introduced, so the right output is achieved. Please let me know if you find any examples that this doesn't fix! 🙂

Yup, looks like #1071 will fix this issue as well.

BTW this came up because one of the questions in https://www.ncsc.gov.uk/cyberfirst/girls-competition uses a rail fence encoding and my daughter found this issue in CyberChef. Reproduced here with a different example so as not to give the game away :)

This should be closed by #1071

This works now on the website as of the build an hour ago


Provide same 'get' capabilities to mos-interface-jl as mos-interface-py

For example, mos-interface-py has functions like get_variable_state that mos-interface-jl does not have

get_calls branch underway to deal with this


merge upgrade docs

删除"CSI 驱动 v0.10 以下版本"的升级流程, 用户应该没动力从一个旧版升级到另一个旧版
合并内容, 梳理行文

Codecov Report
Base: 46.69% // Head: 46.69% // No change to project coverage :thumbsup:

Coverage data is based on head (e4ecfc9) compared to base (0b93696).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #468   +/-   ##
=======================================
  Coverage   46.69%   46.69%
=======================================
  Files          27       27
  Lines        2844     2844
=======================================
  Hits         1328     1328
  Misses       1417     1417
  Partials       99       99

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

内容变更获认可, 开始做英文部分.


MULTIARCH-4963: Update go to 1.22 and bump to k8s 1.30.4

Depends on https://github.com/openshift/release/pull/55728

/retest

/test e2e-gcp-multi-operator

The failure in the non-OLM case seems related to the changes in https://github.com/openshift/multiarch-tuning-operator/pull/228
  Warning  FailedCreate  25s (x6 over 105s)  replicaset-controller  (combined from similar events): Error creating: pods "pod-placement-controller-6b448c5d6-pp6nt" is forbidden: violates PodSecurity "restricted:latest": allowPrivilegeEscalation != false (container "kube-rbac-proxy" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "kube-rbac-proxy" must set securityContext.capabilities.drop=["ALL"]), restricted volume types (volumes "docker-conf", "containers-conf" use restricted volume type "hostPath"), runAsNonRoot != true (pod or container "kube-rbac-proxy" must set securityContext.runAsNonRoot=true)

/override "Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator-bundle"

Testing a fix for the non-OLM deployment at https://github.com/openshift/multiarch-tuning-operator/pull/240

/lgtm


add contributions to Maven

@aalmiray thanks for approving
but it seems I don't have karma for merging...


Add automated UI testing to CRviz

we should implement UI level test scripts.  We just had a bug that @lilchurro found when reviewing PR #73 where updating dependencies changed visual behavior.  It was minor and easily fixed but we need to prevent this kind of thing in the future.  It looks like the default for react is a combination of Jest and Enzyme but I'll dig into it more before I implement anything.  It looks like storybook is another popular option.

I'd check out selenium too.

selenium could be one aspect of it, but i'd also like something more granular.  Selenium is very good for saying that a particular path through an application is broken.  I'm hoping to find something that can tell up when a particular component or ui element is broken. I'd also like something that can tell us when a change messes up our css.

cool, that makes sense. i was only suggesting selenium, as that mimics the user's actual experience.

it's been a while since I've used selenium, but I'm pretty sure you can just specify a setup of which browsers you want to test against, and then write a single test that runs against the browsers that were setup, rather than tests specific to browsers.

so i looked into Jest for this and their approach is:
https://facebook.github.io/jest/blog/2016/07/27/jest-14.html
TLDR; they expect you to generate the expected html and then keep that in your repo as part of your testing.  this strikes me as a maintenance nightmare and also just kind of trivializing the whole thing.  essentially we are just printing the site out and asking if it still looks like the picture.

yikes, I'd down vote that choice too.


Create Article “tracking-time”

Automatically generated by Netlify CMS

👷 Deploy Preview for dynamic-cheesecake-5fbd8b processing.

Name
Link

🔨 Latest commit
862afdef052fd8d08bce75bea09a9f9c1a19c587

🔍 Latest deploy log
https://app.netlify.com/sites/dynamic-cheesecake-5fbd8b/deploys/62eed4a54fc6d30009aa078c


Allow setting single- or double-clicking items in Explorer

Although, it seems like we have to update a complicated bit mask, ShellState?

as you've pointed out modifying SHELLSTATE should work.


Support SSIS package store

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Can one of the admins verify this patch?

@HaoQian-MS
Adding new property to stable version could be breaking change. Please check whether it could be readonly, or whether it is handled for backward-compatibility.

@weidongxu-microsoft
It can be handled for backward-compatibility. No breaking change involved.

ADF team has made an agreement with ARM team to take it as exception temporarily that adding new properties are not taken as breaking changes until we establish a new process.
RE Please help review ADF swagger PR.zip

/azp run


Script doesn't function anymore sinse update.

I was playing this game on microsoft edge, and began to find it to hard. So I got searched for a way to cheat in the game. I found this code and did wat the video said. I also solved the "console disabled" issue. the only problem is that if i open the coding window, that the game will disapear, so i need to reaload it and do the work all over again. when I got the console enabled, i filled in the code. but then I get this error:
VM46:177 Uncaught TypeError: Cannot read property 'addEventListener' of null
at eval (eval at b._drawText (easeljs-NEXT.min.js:14), :177:8)
at String ()
at a.b._drawText (easeljs-NEXT.min.js:14)
at a.b.draw (easeljs-NEXT.min.js:14)
at Button.b.draw (easeljs-NEXT.min.js:13)
at Home.b.draw (easeljs-NEXT.min.js:13)
at a.b.draw (easeljs-NEXT.min.js:13)
at a.b.draw (easeljs-NEXT.min.js:13)
at a.b.update (easeljs-NEXT.min.js:13)
at Game.tick (Game.js:89)
Does anybody knows how to solve these 2 problems (highlited). Thanks very much in advance.
XGamer_GX13

@XGamerGX13 i can help

Oh no need, I already found an other way, plus I dont play the game any more.


⚠ Minecraft has degraded performance

In 29c8a3a, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 1314 ms

Resolved: Minecraft performance has improved in 6aa25ef.


JSON Static Configs with Multiple Objects not working - Unable to deserialize: Not an object

I have been attempting to use the file provider to create static alerts for multiple groups and services in a single file. Using the Example Multiple Object JSON from the Repository gives me the exact same error as my JSON below.  Not really sure what is going on. Has the JSON format changed?
WARN [autokuma::sync] Encountered error during sync: Unable to deserialize: Not an object
[     {         "description": "All DNS Servers",         "name": "ADGuard",         "type": "group"     },     {         "description": "All IP Cameras",         "name": "Cameras",         "type": "group"     } ]

Well, that explains a lot.  Thanks for the fast response on this.
Just switched my container to that after backing it up and the JSON is now working correctly.  Are any other parameters supported for options or notifications in the JSON format?

I'm not sure if I understand that correctly, are you looking for https://github.com/BigBoot/AutoKuma/blob/master/ENTITY_TYPES.md ?

Yep, that was exactly what I was looking for.  Did not see it linked on the main page anywhere, or I just missed it.
Thanks for the help and for all the effort in developing this.  It makes Kuma so much more dynamic.


Problems encountered while downloading the dataset

Hi,
I received this email, and then downloaded the data set according to the first link,

but it looked like this after downloading,

May I ask whether I made a mistake? How to download the dataset correctly?
Thank you!

Is your problem solved, thank you for your reply


Client error response [status code] 400 [reason phrase] Bad Request [url]

Keep getting this error back from guzzle (3.9), tried all sorts of configurations  (latest below). Is this a known issue with guzzle or a config issue?
$client = new \Guzzle\Service\Client(Config::get('config.restURL').'/rest/Account/');
$client->setDefaultOption('headers', array(
'Accept-Encoding' => 'gzip,deflate',
'Content-Type' => 'application/json'
));
    try {
       $response = $client->post('CreateAccount',[
        'body' => json_encode([
                'mvnoID' => '6',
                'CustomerId' => 'CUST0000903518',
                'RatePlanId' => 'NP',
                'Sim' => '8944110064810088876',
                'AccountStatus' => '2'
            ])
        ])->send();

    }catch (Exception $e) {
        print_r($e->getResponse());
    }

what shows print_r($e->getResponse())?

in particular $e->getResponse()->getBody()

Guzzle\Http\EntityBody Object ( [contentEncoding:protected] => [rewindFunction:protected] => [stream:protected] => Resource id #238 [size:protected] => [cache:protected] => Array ( [wrapper_type] => PHP [stream_type] => TEMP [mode] => w+b [unread_bytes] => 0 [seekable] => 1 [uri] => php://temp [is_local] => 1 [is_readable] => 1 [is_writable] => 1 ) [customData:protected] => Array ( ) )

that's the getBody() response, cheers!

(string) $e->getResponse()->getBody()

You might need to set a Content-Type on the request. If that does not work, you could try posting to the Guzzle Gitter channel or StackOverflow.

Hey, Was this issue resolved by adding Content-Type on the request? We are also having similar issues. It doesn't happen always, only occasionally some requests fail with this error. We are using Guzzle 3.9.3.

Can't remember exactly what solved it, but I'm now setting up the client as per below before posting the request:
    	```

$client = new \GuzzleHttp\Client();
$client->setDefaultOption('headers', array(
'Accept-Encoding' => 'gzip,deflate',
'Content-Type' => 'application/json'
));

Note that Guzzle 3 and 4 are EOL and unsupported.

Hey, Was this issue resolved by adding Content-Type on the request? We are also having similar issues. It doesn't happen always, only occasionally some requests fail with this error. We are using Guzzle 3.9.3.

I have same problem. sometimes it happens. can you please share how did you solve this issue?


Use errors.IsNotFound instead of message check

Please provide a description of this PR:
Addressing a late review comment: https://github.com/istio/istio/pull/43620#discussion_r1118978570
of previous PR.

@ymesika: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ipv6_istio
1715b53e512e603c9c902f3184f4c411213bf086
link
true
/test integ-ipv6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-ipv6


Convention for tensor names and assert statements

It is extremely helpful to stick to a uniform naming convention for all the tensors.  Since Python is dynamically typed, it is impossible to infer the dimensions of a given tensor and tensor type hints are uninformative as they stand currently.
Consider the following function:
def forward(tensor1: torch.Tensor, tensor2: torch.Tensor) -> torch.Tensor:
    new_tensor1 = torch.log1p(tensor1)
    new_tensor2 = new_tensor1 + tensor2.unsqueeze(-1)
    return new_tensor2

By inspecting this code, it takes a good while to understand that tensor2 probably one fewer dimensions that tensor1, and that the leftmost dimensions of tensor1 and tensor2 must match; or perhaps tensor2 is a scalar? My point is, the combination of PyTorch's extremely helpful broadcasting semantics and dynamic typing is recipe for unreadable code.
Now, consider the following alternative code:
def forward(raw_counts_ng: torch.Tensor, bias_n: torch.Tensor) -> torch.Tensor:
    """some description:
    :param raw_counts_ng: a 2d tensor with shape (n_cells, n_genes)
    :param bias_n: a 1d tensor with shape (n_cells,)
    """
    assert raw_counts_ng.ndim == 2
    assert bias_n.ndim == 1
    assert raw_counts_ng.shape[0] == bias_n.shape[0]

    log1p_counts_ng = torch.log1p(raw_counts_ng)
    biased_log1p_counts_ng = log1p_counts_ng + bias_n.unsqueeze(-1)
    return biased_log1p_counts_ng

We have suffixed our tensor names via a certain convention, e.g. we have used n for cell index and g for gene index, so that the reader would know the tensor raw_counts_ng is 2d, the leftmost dimension denotes the cell index, and the rightmost dimension denotes the gene index. The assert statements makes this very clear too.

[ ] Let us make sure we stick to such a naming convention going forward: every tensor variable should be named like <name>_<indices> where <name> is arbitrary and <indices> is a list of alphabets signifying different tensor dimensions. For example, my_tensor_n1g is a 3d tensor with shape (n_cells, 1, n_genes); or my_tensor_nk could be a 2d tensor with shape (n_cells, n_latents) where we have hopefully used the letter k to consistently refer to as the latent dimension.
[ ] Let us use assert statements as much as possible. The assert statements a extremely cheap, yet, they catch errors that are otherwise notoriously difficult to catch.
[ ] Let us go through the code we have written so far and implement these conventions.

@fedorgrab @kcibul Where would be a good place to document our coding conventions? Shall we start a separate markdown for that?

What would be the naming convention for subsampling?
# x_ng -> data with n cells and g genes
with plate("cells", ...) as idx:
    x_?g = x_ng[idx]

This issue is no longer needed as there's cellarium-ml library.


Properties of device lifecycle and twin change events are missing

Hi,
the page describes d2c and c2d system properties but not other events like device lifecycle and twin change (device and digital twin) events. The page title describes 'all' IoT Hub messages and not D2C and C2D messages only.
Can you please provide more information about that or give me a hint where I can find this documentation.
Thank you
BR
Andreas

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 444b04d6-717a-6416-08cd-7d8be860f6e8
Version Independent ID: ac2b3041-265b-f037-5ce5-9479bac169e0
Content: Understand Azure IoT Hub message format
Content Source: articles/iot-hub/iot-hub-devguide-messages-construct.md
Service: iot-hub
GitHub Login: @ash2017
Microsoft Alias: asrastog

@Suizi11 Thanks for the feedback!
I have assigned the issue to the content author for further review.

#assign @JimacoMS4

Hi @Suizi11 -- thanks for your feedback and apologies for the delayed response. FYI: Format for non-telemetry events can be found in the following places:

createDeviceIdentty/deleteDeviceIdentity here: Understand the Azure IoT Hub identity registry | Device and module lifecycle notifications
replaceTwin/updateTwin here: Understand Azure IoT Hub device twins | Back-end operations
updateDigitalTwin here: Service developer guide - IoT Plug and Play | Read digital twin change notifications and here: Understand IoT Plug and Play digital twins | Digital twin change events.
deviceConnected/deviceDisconnected: I don’t see a schema in our docs, but this blog seems to capture it: Azure IoT Device lifecycle events – Sander van de Velde (wordpress.com).

I'll work with the product team to make this information more available/discoverable in our documentation.
Thanks again for your feedback!
-Jimaco

#assign @jlorich

Hi @Suizi11 -- Thanks for your feedback! We've just published an update that, hopefully, will address your concerns. Please have a look here: https://docs.microsoft.com/en-us/azure/iot-hub/iot-hub-non-telemetry-event-schema. Let me know if you have any further questions/suggestions. I'll leave the issue open for a week or so if you want to respond.
Thanks again for your help in improving our documentation!
-Jimaco

Hi @Suizi11 -- thanks again for your feedback. Since this is a fairly old issue, As stated previously, a topic was added to address your concerns. At this point, I'm going to close this issue. If, after checking out the new topic, you feel additional content is needed, please open a new issue and reference this one.
Thanks again for taking the time to help us improve our documentation,
Jimaco
#please-close


[WIP] ESSIFI-13 add REST API details

I still feel I need to go over it once more to check if there is any parameter missing some where in the URLs or Request / Response.

we meant to see these in the code. So, we we can run the command mentioned in the above comment, generate the code and we should make sure that in code we are seeing the right thing.
A side note: The swagger UI display will still be imperfect. So, we want to see code being correct in this case.

In general it looks good, the README file needs to be updated. I couldn't find anything in the ticket to make sure that all needed endpoints are there. Could we run it with Swagger UI?

pushed the readme.


Minus plus

Asciimath had the +- symbol, but no -+.  Might be nice to add one.

You can fake the -+ by using: frac{}{+}

This is a better solution. Code -+ by using: bar +
for example:
asciimath:[(cos(theta +- phi) = cos theta cos phi bar + sin theta sin phi)]
will give you:


[bugfix] remove no labelSelectors svc for waypoint

Please provide a description of this PR:
When svc has no label, it will also be added to waypoint.
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[*] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

/ok-to-test

@yuri-lcy We no longer merge into the experimental branch. This should be changed to master.

@yuri-lcy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio_exp
e53d0a7251e30987e6e243b15c9703f56e9c0179
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yuri-lcy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio_exp
e53d0a7251e30987e6e243b15c9703f56e9c0179
link
true
/test integ-ambient

integ-security-istiodremote_istio_exp
e53d0a7251e30987e6e243b15c9703f56e9c0179
link
true
/test integ-security-istiodremote

integ-security_istio_exp
e53d0a7251e30987e6e243b15c9703f56e9c0179
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yuri-lcy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio_exp
e53d0a7251e30987e6e243b15c9703f56e9c0179
link
true
/test integ-ambient

integ-security-istiodremote_istio_exp
e53d0a7251e30987e6e243b15c9703f56e9c0179
link
true
/test integ-security-istiodremote

integ-security_istio_exp
e53d0a7251e30987e6e243b15c9703f56e9c0179
link
true
/test integ-security

integ-security-multicluster_istio_exp
e53d0a7251e30987e6e243b15c9703f56e9c0179
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[SPARK-48356][SQL] Support for FOR statement

What changes were proposed in this pull request?
In this PR, support for FOR statement in SQL scripting is introduced. Examples:
FOR row AS SELECT * FROM t DO
   SELECT row.intCol;
 END FOR;

FOR SELECT * FROM t DO
   SELECT intCol;
 END FOR;

Implementation notes:
As local variables for SQL scripting are currently a work in progress, session variables are used to simulate them.
When FOR begins executing, session variables are declared for each column in the result set, and optionally for the for variable if it is present ("row" in the example above).
On each iteration, these variables are overwritten with the values from the row currently being iterated.
The variables are dropped upon loop completion.
This means that if a session variable which matches the name of a column in the result set already exists, the for statement will drop that variable after completion. If that variable would be referenced after the for statement, the script would fail as the variable would not exist. This limitation is already present in the current iteration of SQL scripting, and will be fixed once local variables are introduced. Also, with local variables the implementation of for statement will be much simpler.
Grammar/parser changes:
forStatement grammar rule
visitForStatement rule visitor
ForStatement logical operator
Why are the changes needed?
FOR statement is an part of SQL scripting control flow logic.
Does this PR introduce any user-facing change?
No
How was this patch tested?
New tests are introduced to all of the three scripting test suites: SqlScriptingParserSuite, SqlScriptingExecutionNodeSuite and SqlScriptingInterpreterSuite.
Was this patch authored or co-authored using generative AI tooling?
No

Can we rebase first to include already merged changes regarding the label checks, logical plans, etc? And I'll review afterwards again?

@davidm-db @miland-db Rebased, you can review again

We can address comments later as they are kind of improvement. Let me merge it first. Thanks!

@cloud-fan Great, thanks. I will create follow up tasks for the improvements you suggested.


Add functions for updating and deleting projects.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

26 of 41 (63.41%)  changed or added relevant lines in 5 files are covered.
47 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-34.6%) to 44.0%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/cli/output.go
0
1
0.0%

cmd/main.go
0
3
0.0%

pkg/cli/octanap.go
7
18
38.89%

Files with Coverage Reduction
New Missed Lines
%

pkg/cli/octanap.go
9
25.93%

cmd/main.go
38
0.0%

Totals

Change from base Build<PHONE_NUMBER>6:
-34.6%

Covered Lines:
66

Relevant Lines:
150

💛  - Coveralls


7641 cancel export on modal close

Fixes #7641
Fixes #7639
Please CR @xavijam I feel you won't agree on the trigger class approach

Change package version.


recaptcha_en.js issue

We are running into issues with https://www.google.com/recaptcha/api.js. Specifically with recaptcha_en.js.  It seems there is an issue with these lines or maybe we're using the api incorrectly. Sorry in advance if this is a problem on our end.
It seems there might have been an update last week:
https://www.gstatic.com/recaptcha/api2/r20170613131236/recaptcha__en.js
Chrome and Firefox are broken.
Safari < 10 works.
Possibly broken code:
k.addEventListener("test", null, b);
k.removeEventListener("test", null, b);
The piece of code erroring out:
var Yd = !B || 9 <= Number(bc)
, Zd = !B || 9 <= Number(bc)
, $d = B && !E("9");
!D || E("528");
Nb && E("1.9b") || B && E("8") || Lb && E("9.5") || D && E("528");
Nb && !E("8") || B && E("9");
var ae = function() {
if (!k.addEventListener || !Object.defineProperty)
return !1;
var a = !1
, b = Object.defineProperty({}, "passive", {
get: function() {
a = !0
}
});
k.addEventListener("test", null, b);
k.removeEventListener("test", null, b);
return a
}();

We're also now getting this error

Closing super old issues. Please re-raise if still relevant.


Add method to set entity at location

This PR adds a method to BlockEntityRegistry that sets the entity at a given location. I've added it to this class because it already keeps track of entities linked with positions in the world.
This is something I wish to use for the multiblock style towers in my Tower Defense GSOC project but I can also see applications for it in modules like Simple Farming.
I also wish to note that this doesn't break the API as it only adds a method

Hooray Jenkins reported success with all tests good!

Merged, thanks! Although I just realized you had later added the WIP label so maybe I shouldn't have merged yet?
Fun fact: it is actually an API violation, but one that's very easy to turn into a minor enhancement: BlockEntityRegistry is API so adding a non-default method could lead to an implementer in a module failing as it no longer meets the contract defined by the interface.
In this case I checked a mega-workspace real quick and as expected there are no other implementers, so it is something we can forgive pretty easily at the moment :-)
The outright fix that would have avoided an API violation would be to provide a default implementation in the interface, that would have worked too. But we're in API free fire still so not a problem in either case!


Update Dutch translation

Changed 'volgt' to 'volgend'.
I think this is a better translation.
This is also how Instagram translates is.

Was updated in #1055


Add controls and pipes (terminal/logs) for hosts

This will greatly simplify administration tasks.
For logs we could use journalctl (or syslog).

Dupe of #1016 (tty for host)?
What controls can you think of for a host?

Dupe of #1016 (tty for host)?

Partly, I edited the description to include logs too.

What are host logs?  Unlike a container, there is very little standardisation here.   I'd say just offer a shell and allow people to tail -f /var/log/messages in them.

I'm going to close as dupe of #1016 here.

Please don't close this before at least create a separate ticket for the logs.

What are host logs? Unlike a container, there is very little standardisation here. I'd say just offer a shell and allow people to tail -f /var/log/messages in them.

I think we can potentially do better than that.


Add ilps22qs sensor support to lps2xdf driver

The ILPS22QS is an ultra-compact piezoresistive absolute pressure and temperature sensor from ST Microelectronics.
https://www.st.com/en/mems-and-sensors/ilps22qs.html
It is register compatible with lps2xdf, which already handles lps22df and lps28dfw, so we will use it to handle ilps22qs as well. During the implementation few issues/improvements have been found and fixed.
The new driver has been verified on STM steval_stwinbx1 board.

@jonas-rem can you please test lps28dfw on your boards? Thanks

@jonas-rem can you please test lps28dfw on your boards? Thanks

@avisconti that's what I ment in my review comment with "custom board". I tested the lps28dfw with my board and everything works well.

@jonas-rem can you please test lps28dfw on your boards? Thanks

@avisconti that's what I ment in my review comment with "custom board". I tested the lps28dfw with my board and everything works well.

Yes, sorry. Yesterday evening I was tired and I didn't see your feedback. Sorry. I'll review your inputs later on today. Thanks

@ubieda unfortunately I had to rebase and push again to solve merge issues on tests/drivers/build_all/sensor/i2c.dtsi.
Any other would like to review this work? Thanks in advance


[P2P] test: URL conversion with mockdns

Description
This was a TECHDEBT item that became trivial to do as work progressed on another task which also required use of mockdns (#576).
Issue
Not related to any specific issue.
Type of change
Please mark the relevant option(s):

[ ] New feature, functionality or library
[ ] Bug fix
[x] Code health or cleanup
[ ] Major breaking change
[ ] Documentation
[ ] Other

List of changes

Adds mockdns as a test dependency
Mocks DNS resolution in url_conversion_test.go
Adds regression tests to url_conversion_test.go for single- and multi-record DNS responses

Testing

[ ] make develop_test
[ ] LocalNet w/ all of the steps outlined in the README

Required Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have tested my changes using the available tooling
[x] I have updated the corresponding CHANGELOG

If Applicable Checklist

[ ] I have updated the corresponding README(s); local and/or global
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
[ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@deblasis Thanks for calling out that issue, I hadn't see it yet. :raised_hands: I think it would be best to tackle that one in a separate PR. I don't think it's as straightforward as adding another usage of mockdns.


Session not recovering problems

There are two problems

When I restart WalletConnect app I can't load previous session.
Metamask onboard popup doesn't appears again when I cancel it or request permission again.

You can check the captured video here.

I guess carefully the async OnApplicationQuit/Pause codes doesn't work as expected.
and there should be detection of canceling permission.
[Environment]
Project: https://github.com/WalletConnect/WalletConnectUnity (2021.11.9)
Unity3D version: 2020.3.21f (Mono Build)
Nox emulator version: <IP_ADDRESS> (Android 7)

PR #21 has been opened that addresses several issues with session resuming/restarting/disconnecting. Please let me know if this PR resolves your issue, I will be testing as well before merging the PR

PR #21 has been opened that addresses several issues with session resuming/restarting/disconnecting. Please let me know if this PR resolves your issue, I will be testing as well before merging the PR

I've confirmed that the session resume issue has been resolved.
Thank you 👍
But cancel/disconnect issue still remains.

Metamast onboard doesn't come up again after disconnect or canceled permission

#21 has been merged to main and should address this issue