Fix kqueue-related definitions on *BSD

The kqueue-related definitions contained errors for all non-OSX operating
systems.  I split them up into separate sections for macos, freebsd, openbsd,
netbsd and dragonfly, and I removed NOTE_SIGNAL from everything besides OSX
because it's only defined within the kernel.

Hold off on merging.  I just discovered that the website I was using as a reference is out-of-date.  I'll amend this PR shortly.

Thanks @asomers, I have been looking at a few different appraoches for adding *BSD to our test matrix (using QEMU) but haven't gotten around to actually implementing anything as of yet.


Infusion desyncs and incorrect output

Infusion pedestal catalysts are remaining on the pedestals until the client updates them, and the output is giving only a single item instead of specified amount

I've discovered that removing the catalyst before updating it allows you to duplicate the item, on both singleplayer and server

Fixed in 1.1.0


Weirwood Bow

OCTGN says Weirwood Bow can only be attached to a Lord or Lady character. It should be a NW or Wildling character. Thanks

Hi. The data is correct on ThronesDB, right? I guess OCTGN has its own data, and that repository has nothing to do with it.


Allow using a custom trust-anchor/CA bundle

In some cases TLS connection might require a custom CA bundle/trust anchor.
mqtt uses --cafile <file> for this, http has --verify <file> …
drg needs to support this as well.
Also, it would be good to have a --insecure switch … which might come in handy at some point.

insecure : do you mean not verify the certificate or use http ?

Use TLS, but not verify any server side certificate.

Interesting want to work on it.


[Error] Dropping blocks because libp2p validation expired

Preliminary Checks

[X] This issue is not a duplicate. Before opening a new issue, please search existing issues: https://github.com/MinaProtocol/mina/issues
[X] This issue is not a question, feature request, RFC, or anything other than a bug report. Please post those things in GitHub Discussions: https://github.com/MinaProtocol/mina/discussions

Description
I'm reporting this specific issue because I see that there is not ticket dedicated to this error, altough it is there for a long time.
[Error] Dropping blocks because libp2p validation expired
With a bit of context ...
Oct 27 23:09:23 ip-172-31-80-92 mina[704]: 2021-10-27 23:09:23 UTC [Warn] failed to reset stream (this means it was probably closed successfully): $error
Oct 27 23:09:23 ip-172-31-80-92 mina[704]:         error: {
Oct 27 23:09:23 ip-172-31-80-92 mina[704]:   "commit_id": "fe51f1ef5cfbcb4d5f559af39080963cf28ff1af",
Oct 27 23:09:23 ip-172-31-80-92 mina[704]:   "string":
Oct 27 23:09:23 ip-172-31-80-92 mina[704]:     "RPC #2599 failed: \"internal RPC error error: unknown stream_idx\""
Oct 27 23:09:23 ip-172-31-80-92 mina[704]: }
Oct 27 23:09:27 ip-172-31-80-92 mina[704]: 2021-10-27 23:09:27 UTC [Warn] failed to reset stream (this means it was probably closed successfully): $error
Oct 27 23:09:27 ip-172-31-80-92 mina[704]:         error: {
Oct 27 23:09:27 ip-172-31-80-92 mina[704]:   "commit_id": "fe51f1ef5cfbcb4d5f559af39080963cf28ff1af",
Oct 27 23:09:27 ip-172-31-80-92 mina[704]:   "string":
Oct 27 23:09:27 ip-172-31-80-92 mina[704]:     "RPC #2604 failed: \"internal RPC error error: unknown stream_idx\""
Oct 27 23:09:27 ip-172-31-80-92 mina[704]: }
Oct 27 23:09:27 ip-172-31-80-92 mina[704]: 2021-10-27 23:09:27 UTC [Info] Daemon started process of kind "Verifier" with pid 2513
Oct 27 23:09:35 ip-172-31-80-92 mina[704]: 2021-10-27 23:09:35 UTC [Error] verifier terminated unexpectedly
Oct 27 23:09:35 ip-172-31-80-92 mina[704]: 2021-10-27 23:09:35 UTC [Info] Starting a new verifier process
Oct 27 23:09:35 ip-172-31-80-92 mina[704]: 2021-10-27 23:09:35 UTC [Info] verifier successfully stopped
Oct 27 23:10:08 ip-172-31-80-92 mina[704]: 2021-10-27 23:10:08 UTC [Warn] validation callback timed out before we could respond
Oct 27 23:10:08 ip-172-31-80-92 mina[704]: 2021-10-27 23:10:08 UTC [Error] Dropping blocks because libp2p validation expired
Oct 27 23:10:08 ip-172-31-80-92 mina[704]: 2021-10-27 23:10:08 UTC [Error] Duplicate producer and slot: producer = $block_producer, consensus_time = $consensus_time, previous protocol state hash = $hash>
Oct 27 23:10:08 ip-172-31-80-92 mina[704]:         block_producer: "B62qmeVRDf21EkWTy1oahYzn3LXxaGRwPVcY6gTPzMvpHp5ZEtYkArM"
Oct 27 23:10:08 ip-172-31-80-92 mina[704]:         consensus_time: { "slot_number": "107981", "slots_per_epoch": "7140" }
Oct 27 23:10:08 ip-172-31-80-92 mina[704]:         hash: "3NKrrLJG17k8ho9R7gmxtmsptWuX687QiPDbmnRjWPFqYRvwErkA"
Oct 27 23:10:08 ip-172-31-80-92 mina[704]:         current_protocol_state_hash: "3NLfkJjoprhynKQpWaYCaMxu8VY3ZUHmec5ichnff1dgnjRuz3vB"
Oct 27 23:10:08 ip-172-31-80-92 mina[704]: 2021-10-27 23:10:08 UTC [Error] error sending message on stream 1418: $error
Oct 27 23:10:08 ip-172-31-80-92 mina[704]:         error: {

log export in https://s3.amazonaws.com/mina.crowbar.systems/mainnet/export/2021-10-28_07-18-20.tar.gz
Steps to Reproduce
Running 1.2.0 on Ubuntu
Expected Result
Not having this kind of entry in the log
Actual Result
Having this kind of entry in the log
How frequently do you see this issue?
Frequently
What is the impact of this issue on your ability to run a node?
Medium
Status
Mina daemon status
-----------------------------------

Global number of accounts:                     68555
Block height:                                  75165
Max observed block height:                     75165
Max observed unvalidated block height:         75165
Local uptime:                                  6h6m9s
Ledger Merkle root:                            jwJnd2gh8nj2pr9xtZAz3Ty7zWFTrappGuzcAaDKe2Mwh3LagZD
Protocol state hash:                           3NLfVau9AYWhJ3qmLJQYcPu5TFZUvMXS73AozLzfV3Ey9YxSR1vR
Chain id:                                      5f704cc0c82e0ed70e873f0893d7e06f148524e3f0bdae2afb02e7819a0c24d1
Git SHA-1:                                     fe51f1ef5cfbcb4d5f559af39080963cf28ff1af
Configuration directory:                       /home/ubuntu/.mina-config
Peers:                                         54
User_commands sent:                            0
SNARK worker:                                  None
SNARK work fee:                                100000000
Sync status:                                   Synced
Catchup status:
	To build breadcrumb:           0
	To initial validate:           0
	Finished:                      304
	To verify:                     0
	To download:                   0
	Waiting for parent to finish:  0

Block producers running:                       1 (B62qrcQDeAfg2qSnZhdF8wQ78G9QmKNDqpESVt2SL43F97kF3Cyv32a)
Coinbase receiver:                             Block producer
Best tip consensus time:                       epoch=15, slot=1046
Best tip global slot (across all hard-forks):  108146
Next block will be produced in:                in 13.674h for slot: 108420 slot-since-genesis: 108420 (Generated from consensus at slot: 108064 slot-since-genesis: 108064)
Consensus time now:                            epoch=15, slot=1046
Consensus mechanism:                           proof_of_stake
Consensus configuration:
	Delta:                     0
	k:                         290
	Slots per epoch:           7140
	Slot duration:             3m
	Epoch duration:            14d21h
	Chain start timestamp:     2021-03-17 00:00:00.000000Z
	Acceptable network delay:  3m

Addresses and ports:
	External IP:    <IP_ADDRESS>
	Bind IP:        <IP_ADDRESS>
	Libp2p PeerID:  12D3KooWQBiq7tzFZ2uScLDrXvsk2ecTzWp3Kj7pFvQ5YKLXxPhT
	Libp2p port:    8302
	Client port:    8301

Additional information
No response

@nholland94 can you please take a look when time allows.


docs(*): index pages

@petebacondarwin – I'm wondering what the best way to create an index page listing the various parts of the documentation with dgeni. I peeked at the configs for angular and your example project a bit, but it wasn't entirely clear to me.
Any advice?

I'll send something over tomorrow
On 20 Jan 2015 21:44, "Brian Ford"<EMAIL_ADDRESS>wrote:

@petebacondarwin https://github.com/petebacondarwin – I'm wondering
what the best way to create an index page listing the various parts of the
documentation with dgeni. I peeked at the configs for angular and your
example project a bit, but it wasn't entirely clear to me.
Any advice?
—
Reply to this email directly or view it on GitHub
https://github.com/angular/router/issues/54.

Thanks!

So what you need is a processor that will add a new doc to the docs collection. This doc should have a property that holds a collection of references to all the docs that you want to show on the index page. It should also have an id and path, so that it can be rendered and written. Then you just need to provide a template that will render the collection of references as you see fit.  I will knock up a basic PR for you.

By the way, your usage of markdown is breaking the dgeni generation, since scripts/markdown.js is updating the shared markdown library to use the async pygmentize highlighter. But the dgeni configuration is expecting to run markdown synchronously, so it is not passing a callback.
Do you actually need a markdown task in Gulp? Can this not be handled by dgeni? If it is needed then we need to think of a way of isolating the two uses of markdown from each other.

There you go.
Regarding the markdown stuff. We can easily use dgeni to convert the *.md in the project to HTML and put them in the dist/docs folder. Moreover, we can then, also automatically include links to them in the index page.  I can create a PR for this too if you like.


TestKnnVectorQuery.testScoreEuclidean fails

Description
Reproducibly fails on main branch.
Gradle command to reproduce
./gradlew test --tests TestKnnVectorQuery.testScoreEuclidean -Dtests.seed=1DAEE5C9217129EB -Dtests.nightly=true -Dtests.locale=mas -Dtests.timezone=Africa/Libreville -Dtests.asserts=true -Dtests.file.encoding=UTF-8

@msokolov I've noticed that in https://github.com/apache/lucene/pull/1054 we don't force merge index for this test anymore, and may end up with several segments, which leads to a test failure. Should we reintroduce force merge?

sorry - did I break that? I think I replaced RandomIndexWriter with IndexWriter and took control over flushing and merging? But maybe I misremembered/messed up

I believe https://github.com/apache/lucene/commit/e69c48b8d941f44bb73f0594b5f72947efe80948 should fix. I guess LuceneTestCase.newIndexWriterConfig can randomly commit, or result in unusual configs anyway. I don't think we want to forceMerge in this case because some of the test users of that method rely on document order.

Thanks @msokolov.
I run the above test on main, and it doesn't fall anymore.
Closing the issue.

I just backported to 9.x and 9_4 branches


CSV import not going through

Issue Type: Bug
The CSV import to an Asure SQL Database used to work fine until an update in early November. Now, I get a message in the extension's "Runtime Status" saying this:
Cannot read property 'Integrated' of undefined
There is no issue with the connection. I am able to query the existing contents of the database without issues. It is just the import which fails.
Extension version: 1.5.1
Azure Data Studio version: azuredatastudio 1.39.1 (7553f799e175f471b7590302dd65c997b838b29b, 2022-08-30T01:12:48.559Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-5350U CPU @ 1.80GHz (4 x 1800)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
14, 17, 15

Memory (System)
8.00GB (0.08GB free)

Process Argv

Screen Reader
no

VM
0%

Hi, did you find how to fix this? I'
ve been having the same issue since 2 days ago.

Hi, did you find how to fix this? I' ve been having the same issue since 2 days ago.

I have only managed a workaround - by using DBeaver for the upload. I'm still faced with the issue on Azure Data Studio.

@loony-alice @pamelagumera1 sorry about the inconvenience, I just released a new release that reverted the recent changes to the extension. the new version is 1.5.3. it should be available in a few minutes, please restart your ADS to pick it up.
let me know if it still doesn't work.


Repair MQTTClient.v5.unsubscribe to use properties arg

A new/empty properties was being put into the unsubscribe packet instead of the user-provided properties argument.
Although there are not any nominal properties that would be used with unsubscribe packets, it is possible that user-defined properties could have vendor-specific meaning for certain MQTT brokers. 1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (345ef16) 79.04% compared to head (aa5d77e) 80.07%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   79.04%   80.07%   +1.03%
==========================================
  Files          22       21       -1
  Lines        2500     2339     -161
==========================================
- Hits         1976     1873     -103
+ Misses        524      466      -58

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Good catch


Only remove pulp_push if v1 content is not on

The plugin pulp_push is meant to push v1 content to pulp repository. Use
the content_versions value from reactor config to determine whether or
not plugin should be removed.
Signed-off-by: Luiz Carvalho<EMAIL_ADDRESS>

Not updating release notes draft because this is bugfix to an unreleased feature.


Support for simple IN operator

Do you have any plan to support simple IN operator ?
I see that this library is still a work in progress.
Have you considered adding IN operator support ?
A simple IN operator dealing with string,long,double values would be a great addition.
example,
IN('US','UK','IN','NZ')
IN(1,2,3)

Yes, this is a good idea. I'll do it soon

Implemented in the version 0.0.3. You can use json like this:
{
  "fields": [
    {
      "column": "field1"
    },
    {
      "column": "field2",
      "alias": "test"
    }
  ],
  "from": [
    {
      "table": "table1",
      "schema": "schema"
    }
  ],
  "where": {
    "or": [
      {
        "in": {
          "fieldName": "field3",
          "values": [
            "US",
            "UK",
            "IN",
            "NZ"
          ]
        }
      },
      {
        "eq": {
          "fieldName": "field4",
          "value": "3"
        }
      }
    ]
  }
}


why use state dir for rootfs

Description
https://github.com/containerd/containerd/blob/master/runtime/v1/linux/runtime.go#L169
https://github.com/containerd/containerd/blob/master/runtime/v1/linux/bundle.go#L68
use filepath.Join(r.state, namespace) as cotainer rootfs dir
why not use  root (containerd.toml config) as  container rootfs dir?
Steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Output of containerd --version:
(paste your output here)

Any other relevant information:

Hi @hongli-my
it is by design. The state dir is for transient data. The comment is here
https://github.com/containerd/containerd/blob/release/1.3/services/server/config/config.go#L38.
The state dir is ok for lost if the machine restart unexpectly. The data created by container will be persisted in the dir managed by snapshot. It is not a bug.
If you meet any question, please open it. Thanks for asking.


Gaps between songs?

Can gaps between songs be configured with a set time in settings? That would be awesome and I guess pretty simple to implement, Let me know and I can try to prepare a pull request.

This is not possible to implement, the songs are played by GPM using multiple audio elements on the page in order to provide gapless playback.  We have no idea with element is which part of what song so we don't know to pause / wait between songs until the next song has already started


Integrate rustler_precompiled with this project

Hello friends, would you consider integrating this project with Rustler precompiled (https://hexdocs.pm/rustler_precompiled/RustlerPrecompiled.html) in order to avoid needing the rust dependency ?
I've already done this integration on my fork of ex_keccak and it is working great: https://github.com/spapas/ex_keccak
I don't want to provide a PR because I've used my own repo and tags there to download the pre-compiled NIFs and I think it would be too intrusive to this repo (i.e you'll see base_url: "https://github.com/spapas/ex_keccak/releases/download/0.3.3"). However you can take a peek at the diffs needed here:
https://github.com/tzumby/ex_keccak/compare/master...spapas:master
The only thing missing is to change it with your repo and tags and create a new hex release :)
TIA

Hi @spapas, thanks for sharing and working on this!
This looks interesting, I like that there are checksums, but how would I check the hash of a published library ? Do I have to install it and run that in my deps folder ? If that's the case, it sounds pretty cumbersome, i doubt anyone would do that if it's so involved.
Is there a way to make this configurable and allow users to pick if they want it pre-compiled vs compile at install time ?

Hey @tzumby most of the questions on how this works should be explained in the docs. I'll try to answer your questions though:
When you have a dependency that uses rustler_precompiled the correct binaries will be checked and downloaded automatically without any involvement from the user. Ie rustler precompiled integrates with the library, not the project using the library. For example I've got a project that uses ex_keccak. I have only added my version of ex_keccak from my github repo as a dependency and haven't done any other changes to my project
Also if you want to compile the dependency for some reason you can with a line in your config.

Thanks, I found the force_build setting in the docs. This is great.
What I was asking in my first questions was how I can manually check the checksum of the library binaries. I think this is extremely important given this is a hashing function. Or in other words, what are the guarantees that I don't maliciously push a weak binary in hex and users of this package blindly add it to their projects ?

This is an interesting question! I don't have an answer maybe the authors of rustler precompiled can answer?
However from my experience I think that trusting the library author that he'll provider a correct binary is common. For example python precompiled wheels.

I understand your hesitation on this however precompiled rustler has the force_build option. If you pass true for that then the ex_keccak library will be compiled with rustler by default. People that to use the precompiled binaries will need to configure their project for that.
Also, this may not be important but using the precompiled binaries is good for the adoption of elixir: https://nitter.net/i/status/1463605416861081602

I mostly use rust nifs for cryptography and hash functions (including ex_keccak) so I'd rather not download artefacts from external sources that may compromise the security of my projects. But I think if you have a private library / project it may be fine

I'm not necessarily opposed to giving the users an option, but I would certainly not make this the default.

I have the same opinion, it would be nice if this feature was optional. so users can decide if they want to compile locally or download precompiled artefacts
For rust nifs, you need to install only one dependency - rust. For C nifs usually, you need to install a bunch of dependencies. So I don't think it's a problem to install rust.

Hey @tzumby you've set ex_keccak: false, I think the correct thing to do is set ex_keccak: true in the config of your app. If this still ain't working you could raise an issue at the rustler_precompiled github repo.
I am using my local fork for my project and am happy with that for now so I can't research it anymore (also releasing new precompiled NIFs is a PITA so I'd rather avoid it 😁 )

@tzumby I'll try to explain my understanding of how this should work: Taking my fork as a base, you'll need to change the https://github.com/spapas/ex_keccak/blob/master/lib/ex_keccak.ex  file from
  use RustlerPrecompiled,
    otp_app: :ex_keccak,
    crate: :exkeccak,
    base_url: "https://github.com/spapas/ex_keccak/releases/download/0.3.3",
    version: "0.3.3"

to
  use RustlerPrecompiled,
    otp_app: :ex_keccak,
    crate: :exkeccak,
    base_url: "https://github.com/spapas/ex_keccak/releases/download/0.3.3",
    version: "0.3.3",
    force_build: true

You'll also need to release a new version i.e 0.3.4, add the tags etc. This will setup the ex_keccak lib so it will be compiled by default (instead of downloadded). So you'll have the default behavior you'll want (people that just include the lib in their projects will need to compile it).
If somebody wanted the pre-compiled NIFs instead, he'd have to configure his project (i.e the project that uses the ex_keccak lib) to add the following option to config.exs:
config :rustler_precompiled, force_build: false, your_otp_app: true  to your project's config.exs.

Yup, that's exactly what I tried. Except, force_build is not part of the keyword list. If I try your line, I get an error:
# in config.exs

config :rustler_precompiled, force_build: false, ex_keccak: true

==> ex_keccak
Compiling 1 file (.ex)

== Compilation error in file lib/ex_keccak.ex ==
** (FunctionClauseError) no function clause matching in Access.fetch/2

    The following arguments were given to Access.fetch/2:

        # 1
        false

        # 2
        :ex_keccak

    Attempted function clauses (showing 5 out of 5):

        def fetch(%module{} = container, key)
        def fetch(map, key) when is_map(map)
        def fetch(list, key) when is_list(list) and is_atom(key)
        def fetch(list, key) when is_list(list)
        def fetch(nil, _key)

Hey @tzumby sorry I used a wrong config. The correct config to unset force build is this one (as it is described actually in the docs):
config :rustler_precompiled,
  :force_build, ex_keccak: false

I tested it with my project which has force_build = false by default and setting
config :rustler_precompiled,
  :force_build, ex_keccak: true

in my project's config, it compiled the ex_keccak lib instead of downloading it.

Does it download if you set it to true ? For me, the false flag works, but when I set it to true it still compiles instead of download
config :rustler_precompiled, :force_build, ex_keccak: true

Does it download if you set it to true ? For me, the false flag works, but when I set it to true it still compiles instead of download
config :rustler_precompiled, :force_build, ex_keccak: true

Is any help needed to get this across the finish line?
I'm looking to speed up our CI and having all our rust packages precompiled would help with that :)

@maartenvanvliet can CI builds be improved by caching _build directory?

Problem is more specifically with Docker. Each docker build apt-get installs the rustc compiler and all the rest which takes time. And then rustler compiles ex_keccak, which also takes time.
There are other ways to improve this but precompiled_rustler is the easiest I think.

@maartenvanvliet I was using my fork at https://github.com/spapas/ex_keccak and worked great!
(please don't use my fork because I haven't updated it recently, fork my fork and integrate latest changes)

Hey folks, I will get back to this issue soon, sorry for leaving it hanging.

Thanks for opening this @spapas! I bumped the minor version to 0.7.0 that includes the pre-compiled binaries along with checksums.


figure out how to embed consultation request form with user-editable text content

probably same approach as #123

Added a custom template for the URL /engage/consult/to include the google form iframe and added some light styles to try adjust how it displays.  Hopefully this will be sufficient, we can try it out on the test site.

The form displays correctly and you can easily edit and scroll through to submit.


What are the initial values?

In Danaila's paper, it is unclear what to choose as initial temperature values at the adiabatic walls for the natural convection test. Since they assert homogeneous Dirichlet BC's on the Newton linearized system, the boundaries will remain at their initial values.
For now I think it is reasonable to try the following options:

Zero
Linear ramp between the hot and cold values

It's also unclear whether the initial values in the domain should be zero or a linear ramp.

In wang2010 they specify to set zero temperature initially throughout the domain.
Presently I'm also setting zero temperature on the adiabatic walls. This could be wrong.

The velocity is overshooting greatly near the hot and cold walls. I'm going to see if this also happens with the temperature ramped from hot to cold on the adiabatic walls, rather than being set to zero (which creates shocks on either side).

As far as I can tell, the large velocities near the hot/cold walls are expected.
I am moving forward with the initial values from Wang's 2010 paper, i.e. initializing all temperatures to zero within the domain. Of course to use Danaila's Newton linearized formulation and algorithm, we must initialize the values at the boundaries to the original Dirichlet BC values.
Currently my result is qualitatively correct, and seems to be off at the peaks by around 10%.


add support for viamc

traffickermc doesnt allow joining to a server with viamc (allowing all versions to join) would probably be an easy change and i would appreciate it

literally a config issue, that's server sided


Add endpoint init

https://github.ibm.com/IBMPrivateCloud/roadmap/issues/53620
Change in brief -> Add init container to check two crucial endpoints before starting the actual job. The script to check endpoints is available in iam-onboarding job.

What would be happen if the log regex failed? regexp.Compile(":\s?(.*)")
Compile function will fail if the regex expression (:\\s?(.*)) is invalid, as given expression is valid this would never throw error.
What would happen if matching logic failed? matches := r.FindAllString(events.Items[len(events.Items)-3].Message, -1)
I have handled that scenario with else in place (https://github.com/IBM/ibm-iam-operator/pull/488/files#diff-5496a5426f771b114da6a7b071729d240cf7f25a87db2d1d817a45b41ea810edR1222)
I would suggest as we have multiple checks there , we should test with various combinations before we take this.
We have in only 3 combination in  iam-onboarding job's event in given order

Created pod: iam-onboarding--1-xxxx (5 times)

Delete pod: iam-onboarding--1-xxxx (5 times)

Job has reached the specified backoff limit

And once the job fails, last event is Job has reached the specified backoff limit.
In code I am consuming created pod event, if for whatever reason it has consumed the last event. I have else check in place mentioned above.

Final PR has been raised in  -https://github.com/IBM/ibm-iam-operator/pull/492


Change IED names

As an engineer I want to be able to change the IED names so I import ICD files and change the IED template name to a production name.

Create edit button in the IED editor (after dropdown menu)
Create edit button in substation tab upon selecting an IED
Create IED edit window

Create checks
-- for uniqueness, the user should only be able to save the IED name when there is no other IED with the same name
-- Name can't be empty
Change the IED name and all references to the IED upon saving in the following locations
-- TConnectedAP.tUnNaming
-- agLDRef
-- tLNode.tUnNaming
-- tIED.tUnNaming
-- tExtRef
-- tControlWithIEDName.tControl.IEDName

Background:
This could be done in the IED editor or somewhere else if that makes more sense. All references to this IED need to be changed as well.

@JakobVogelsang Could you add this issue to the IED editor project?

Will we also make the description editable? If so, in what places should this be updated?

The description does not need to be editable in this story.

The following reference to the IED Name are updated:
The attribute of the following elements:

Association[iedName]
ClientLN[iedName]
ConnectedAP[iedName]
ExtRef[iedName]
KDC[iedName]
LNode[iedName]

From the following elements the Text Content is updated:

GSEControl > IEDName
SampledValueControl > IEDName

Private Elements are ignored, but this can become a problem in the future.
Not sure how to make a bulletproof way to do this...

It is fine to ignore the private types.


Npm Packaging

Hi. I am somewhat new to javascript and I having trouble in figuring out how to adapt my code to run as your example. I appreciate how simple it seems in the Readme, and similar to what I get from react-dom. I was thinking if you were considering to interface this repository somewhat like:
npm install --save react-worker-dom
//Worker.js
import React from 'react';
import {render} from 'react-worker-dom';
import App from './src/App';
render(<App/>);

//Page.js
import ReactWorker from 'react-worker-dom';
import Worker from "worker!./Worker";
ReactWorker( Worker(), document.getElementById("root") );

and them just run webpack/babel on Page.js?

@pedro-iago I am reworking the app so that it can be packaged .

Any progress with this?

@oskarer asked me about this too. Looks like they are using it, so will collaborate with them to publish it on npm.


GIF images are not animated on iOS and doesn't work at all on Android

Tried to display GIF image with react-native-svg, on iOS it renders, but without animations, on Android platform there is no image rendered at all.
react-native-svg: 12.1.0
react-native: 0.61.5
Steps To Reproduce
Code:
   <Svg>
      <G>
        <Rect x={50} y={50} width={200} height={200} stroke={'green'} stokeWidth={2} />
        <Image x={50} y={50} width={200} height={200} href={{ uri: 'https://www.thisiscolossal.com/wp-content/uploads/2018/08/Isopoly_01.gif' }}></Image>
      </G>
    </Svg>

For Android all libraries to support GIF images are included.
    implementation 'com.facebook.fresco:fresco:2.0.0'
    implementation 'com.facebook.fresco:animated-gif:2.0.0'

GIF animation works fine on iOS/Android with simple react-native <Image />

@msand Could you please check when you have free time? Thanks

same issue

Same problem

Any one found the solution?

I don't think do @bncvnc

+1

Hello all! My solution in my app is that I used a usestate variable and updated when I needed to render the gif which will cause a re-render. Because in my case, I found out that the issue only occurs when you have a unloaded gif. The gif requires it to be re-rendered for it to be animated.
Excuse the bad English plz.

Fresco updates their version so the older versions might not work, here is there page https://frescolib.org/docs/index.html
as of now their current versions are below :
dependencies {
// For animated GIF support
implementation 'com.facebook.fresco:animated-gif:3.1.3'
// For WebP support, including animated WebP
implementation 'com.facebook.fresco:animated-webp:3.1.3'
implementation 'com.facebook.fresco:webpsupport:3.1.3'
// For WebP support, without animations
implementation 'com.facebook.fresco:webpsupport:3.1.3'
// Provide the Android support library (you might already have this or a similar dependency)
implementation 'com.android.support:support-core-utils:24.2.1'
}

just check out the react native doc
e.g.
https://reactnative.dev/docs//image

Hello @oleksandr-dziuban,
We already fixed that, but if you still have that issue feel free to reopen.
Thank you.


Resolve remaining prop-types warnings

babel-plugin-flow-react-proptypes updated to include https://github.com/brigand/babel-plugin-flow-react-proptypes/pull/81.
Solves #741.

@k15a Can you confirm that this fixes all the warnings like it does on v2? I can release a patch, I suppose, if it does

I don't know why it shouldn't but haven't tried it as well ;)


40 implement a secure key storage functionality for the pop server

@Hermann-Core , @IngridPuppet do you think this ticket should be continued ?

@Blindspot22 you hav'nt resolve the changes you marked as resolved, Check them again

Which is that please


IE & Edge - Workspace not "cleaned up"

Expected Behavior
You do not see residue from previous actions/animations.
Actual Behavior
You do.
Steps to Reproduce
Run a reporter or delete a bock with the toolbox.
Operating System and Browser
Windows 10 Edge
Screenshot

This looks like a missing call to hideChaff.

also happens with deleting:

look at the grey streak, that was left over from deleteing.

This appears to have been fixed upstream


OCPBUGS-6787: Add runbook for KubeDaemonSetMisScheduled

/jira refresh

Can you review again?

cc: @bburt-rh

@simonpasquier can you take another look if any other change is needed

/remove-lifecycle stale


Write a PHP program to find perimeter of a square

Description
Write a PHP program to find perimeter of a square
Perimeter of square = 4 × Side
Side : 2

Perimeter : 8

How to contribute

Save the solution in program/find_perimeter_of_a_square.php file
Add find_perimeter_of_a_square.php file in find-perimeter-of-a-square folder

!assign

!assign


Search feature request

It'd be nice to be able to search for music, tags, genres, ...

Do you mean a global search (on the entire souncloud), or the ability to search in a user's stream / playlists / likes?
Since this is a pretty minimal app, I think global search functionality is out of scope... However this has my +1 for search functionality in favorites.

Global search
On Jun 8, 2015 8:10 AM, "Seppe Stas"<EMAIL_ADDRESS>wrote:

Do you mean a global search (on the entire souncloud), or the ability to
search in a user's stream / playlists / likes?
Since this is a pretty minimal app, I think global search functionality is
out of scope... However this has my +1 for search functionality in
favorites.
—
Reply to this email directly or view it on GitHub
https://github.com/gillesdemey/Cumulus/issues/1#issuecomment-109970349.

Hi @niftylettuce
Thanks for the feature request, however search is not currently on our roadmap since we feel that it is largely outside of the scope of this project.
That's not to say that we won't add it in the future. :)

How can this be a music player if you can't search for music?  SoundCloud's API is right there for us to use.  So what, am I supposed to go to SoundCloud.com every time I want to add a new track to a playlist?   What if I don't like anything that's in the Feed?  What if I want to listen to a specific song someone told me about?  That's bizarre to not have this feature...

https://developers.soundcloud.com/docs/api/guide#search

I think you will be better served by something like SoundNode, which is trying to be more than Cumulus is.
We've debated adding search, but it comes with a number of extra features we don't want to implement right now
We think Cumulus is a great companion for playing the music you've curated on SoundCloud, but doesn't aim to replace SoundClouds amazing web experience.

But, but... I was just working on a search feature... :confused:

Finish your feature for search and fork the project we can use your fork
for cool stuff like this
On Jun 9, 2015 3:17 PM, "Seppe Stas"<EMAIL_ADDRESS>wrote:

But, but... I was just working on a search feature... [image: :confused:]
—
Reply to this email directly or view it on GitHub
https://github.com/gillesdemey/Cumulus/issues/1#issuecomment-110470459.

It has to be there. most people want to listen to new songs as well, or from a specific artist/genre etc.

We already looked into a search feature, but it quite a lot of work. Mainly because it requires some pretty complex additions to the UI to make it work properly. Keeping things simple is one of the main goals of this app, if you want to have a complete Soundcloud experience there plenty of alternatives available.
There are still a lot of things that need to be addressed before we should consider adding more features, and there are A LOT of features the Soundcloud API exposes that we could add to this app. Just throwing everything together into a complex, ugly UI is the opposite of what we are trying to accomplish.

There's a lot of demand for this.  Do you want people to use Cumulus or do
you want them to use other terrible apps that aren't open source.
On Nov 3, 2015 6:43 AM, "Seppe Stas"<EMAIL_ADDRESS>wrote:

We already looked into a search feature, but it quite a lot of work.
Mainly because it requires some pretty complex additions to the UI to make
it work properly. Keeping things simple is one of the main goals of this
app, if you want to have a complete Soundcloud experience there plenty of
alternatives http://alternativeto.net/software/cumulus/ available.
There are still a lot of things that need to be addressed before we should
consider adding more features, and there are A LOT of features the
Soundcloud API exposes that we could add to this app. Just throwing
everything together into a complex, ugly UI is the opposite of what we are
trying to accomplish.
—
Reply to this email directly or view it on GitHub
https://github.com/gillesdemey/Cumulus/issues/1#issuecomment-153327548.

Currently, this is nothing more than a weekend project that suddenly got a lot of attention.
The unfortunate reality is that all of our core contributors have a full time day job and spend their precious spare time working on this project to get it in the best shape possible.
A search feature - as explained multiple times - is not a trivial feature to add and we have little time to invest in such a big feature resulting in a lower priority for this.
Since this is an open-source project (MIT licensed) you - and many others - are free to contribute to this project.
I'm re-opening this issue to keep track of this feature request so the community can help us out.

Awesome.  Can one of us submit a PR for review then?!! :thumbsup:
On Nov 3, 2015 9:32 AM, "Michiel De Mey"<EMAIL_ADDRESS>wrote:

Currently, this is nothing more than a weekend project that suddenly got a
lot of attention.
The unfortunate reality is that all of our core contributors have a full
time day job and spend their precious spare time working on this project to
get it in the best shape possible.
A search feature - as explained multiple times - is not a trivial feature
to add and we have little time to invest in such a big feature resulting in
a lower priority for this.
Since this is an open-source project (MIT licensed) you - and many others

are free to contribute to this project.

I'm re-opening this issue to keep track of this feature request so the
community can help us out.
—
Reply to this email directly or view it on GitHub
https://github.com/gillesdemey/Cumulus/issues/1#issuecomment-153372172.

I'm no designer but I think we can include a search button in  which overlays a input above list items. A close button/back button would hide the search bar and restore initial look.
Excuse my paint skills

I'm no designer but I think we can include a search button in  which overlays a input above list items. A close button/back button would hide the search bar and restore initial look.
Excuse my paint skills


NETOBSERV-645 Kafka export (flagged as experimental feature)

Allow defining a Kafka exporter (or several of them). FLP will then send flows there as JSON. It is an additional stage: all existing stages are unchanged (kafka for internal processing, writing to loki, etc.)
No required change in FLP, which already has everything needed.
Documentation PR: https://github.com/netobserv/documents/pull/33

/approve


Model names using Upper Camel Case should be more clear

#49

Hi @arturojain , Thanks for this contribution. I can't accept this PR because
1, These are auto generated files so I would prefer them to keep as they are originally generated
2, Upper case is not required, you can choose lower case as well like
var task = Sequelize.define('task', {
    id: Datatypes.INTEGER
});

// then access as
models.task

3, I think its documentation role to convey this information, not example repository.


fix: prompt should be optional to avoid interrupting SSO

prompt is an optional attribute. Defaulting to "none" prevents the default SSO flow from taking place if the user isn't logged in or hasn't authenticated the app.
See: https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-auth-code-flow

Upstream PR with a bit more detail here: https://github.com/juhanakristian/remix-auth-microsoft/pull/35


subquery support

related: https://github.com/penberg/limbo/issues/177
this is also the first instance where we need to start considering scopes/environments i.e. certain tables (virtual or otherwise) arent visible to all parts of the query e.g.
select a.first_name, b.first_name from (select first_name from b) a, users b;
                                          ^^^^^^^^^^^^^^^^^^^^^
table alias b should not be visible to this subquery

duplicate of https://github.com/penberg/limbo/issues/34


change repo name to cookiecutter-MDAKit

Given than we want to use the cookiecutter for MDAKits, I suggest to make this explicit in the name and call it cookiecutter-mdakit or appropriately capitalized.

I'm on board with this -- will do so in a day or two unless there are any objections.

Changed to cookiecutter-mdakit -- please reopen if the capitalisation should be less lowercase.


Update installation-R-admin.Rmd

I propose to replace r-base-core by r-base

I guess that R package updates will download more quickly with a Belgian CRAN mirror like https://lib.ugent.be/CRAN/


Feature Requests

Please post any requests here and I will add it as an issue.

Please update the CDN code generated by "!b5-$",
Now this generates:
   <link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/5.0.0-alpha1/css/bootstrap.min.css" integrity="sha384-r4NyP46KrjDleawBgD5tp8Y7UzmLA05oM1iAEQ17CSuDqnUK2+k9luXQOfXJCJ4I" crossorigin="anonymous">
    <script<EMAIL_ADDRESS>integrity="sha384-Q6E9RHvbIyZFJoft+2mJbHaEWldlvI9IOYy5n3zV9zzTtmI3UksdQRVvoxMfooAo" crossorigin="anonymous"></script>
    <script src="https://stackpath.bootstrapcdn.com/bootstrap/5.0.0-alpha1/js/bootstrap.min.js" integrity="sha384-oesi62hOLfzrys4LxRF63OJCXdXDipiYWBnvTl9Y9/TRlw5xlKIEHpNyvvDShgf/" crossorigin="anonymous"></script>

However GetBootstrap.com says the current version is v5.1
Thanks.
By the way, I really appreciate the clarity of your documentation.


Improve cask --adopt to only care about the installed version if auto_update is false

Verification

[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

Provide a detailed description of the proposed feature
I believe with #16889, the cask --adopt logic started failing to adopt if the installed application version was not the same as the "to be installed" version. For our organization, this means that the moment there is a new cask version, anyone who runs a cask --adopt will get a failure, requiring them to go into the application and manually update. What we'd expect instead is that if the application's update lifecycle is handled by the application (and not brew) then brew would happily adopt it whether it is the exact same version or not.
I propose that the --adopt logic is changed to only care about the installed version if the cask formula has auto_update false. (somewhat related to this, it would be amazing if we could also avoid downloading the cask if the application is already installed and we will --adopt it.)
What is the motivation for the feature?
In the current state, adopting causes more problems than it helps. This is both because it requires people to act on something (do an update) for the brew install to work and that the action they need to take is confusing to them (few understand that what this is saying is "go into the application and manually update it" – they just think of it as a failure that they can't overcome).
How will the feature be relevant to at least 90% of Homebrew users?
I believe this would make --adopt behave as people would expect it to.
What alternatives to the feature have been considered?

could use --force I think? However, we don't generally want Homebrew to manage the version lifecycle.
simply stop using --adopt and, outside of brew, remove the application and then install it from Brew the first time.

One of these alternatives is what we will do if adjusting how --adopt works is rejected.

I believe with #16889, the cask --adopt logic started failing to adopt if the installed application version was not the same as the "to be installed" version.

It's the other way around: #16889 made it more permissive, not less.

I propose that the --adopt logic is changed to only care about the installed version if the cask formula has auto_update false.

I agree with this, it makes sense to me 👍🏻

somewhat related to this, it would be amazing if we could also avoid downloading the cask if the application is already installed and we will --adopt it.)

I agree this would be amazing but also think this would require additional verification e.g. checksum/signature/etc.


Fix formatting issues

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Fix the formatting issues for go 1.19
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Release note:
none

/lgtm


separate send_transaction and get_receipts

Refactored the submit_and_await_commit_with_receipts function to separate transaction submission and receipt retrieval into individual functions: submit_tx and get_receipts.
Checklist

[x] I have linked to any relevant issues.
[x] I have added necessary labels.
[x] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[x] I have requested a review from the relevant team or maintainers.

Looks good, but agree that we must let the user the option to call directly call or simulate without worrying about submission vs receipts

You can do that. These functions exist and are the same as before.


get_method() is not returning the name of the lambda function

Godot version
4.0.rc
System information
Windows 10
Issue description
The documentation of the Callable.get_method() says:
"Returns the name of the method represented by this Callable. If the callable is a lambda function, returns the function's name."
However, this is not true, and the function always returns an empty string when the Callable is a lambda, named or not. Also, the string representation of the Callable, although not exactly wrong, seems to be different than the intended by the code.
I already have the solution for this bug, and the PR is ready to be opened. However, I would like to discuss two things before:
1. The current code has the following "if" in the get_as_text function to check if the lambda is an anonymous lambda:
if (function->get_name() != StringName())
However, it doesn't work because the function name is never empty; the GDScript parser always set it to "<anonymous lambda>" in these cases. So, the solution is an uglier, but functional:
if (function->get_name() != "<anonymous lambda>")
2. There is a lot of duplicated code between the classes GDScriptLambdaCallable and GDScriptLambdaSelfCallable. Even this fix should be duplicated in both classes. Is it ok to refactor in order to make both classes inherit from a common base class, like GDScriptLambdaCallableBase? (My proposed fix already does that, actually.)
Steps to reproduce
Run the following GDScript:
var unnamed_lambda: Callable = func(x): return 0
var named_lambda: Callable = func some_lambda(x): return 0
print("unnamed_lambda.get_method(): " + unnamed_lambda.get_method())
print("str(unnamed_lambda): " + str(unnamed_lambda))
print("named_lambda.get_method(): " + named_lambda.get_method())
print("str(named_lambda): " + str(named_lambda))

This is the current result:
unnamed_lambda.get_method():
str(unnamed_lambda): <anonymous lambda>(lambda)
named_lambda.get_method():
str(named_lambda): some_lambda(lambda)

This is the expected result:
unnamed_lambda.get_method():
str(unnamed_lambda): (anonymous lambda)
named_lambda.get_method(): some_lambda
str(named_lambda): some_lambda(lambda)

Notice that get_method is always returning empty currently.
Also, the str(lambda) expected result is what the code seems to by trying to do, but there is a wrong "if" there (as explained above).
Minimal reproduction project
N/A

I can confirm, at RC5
func _ready():
	var cb := func predicate(current, expected): return current == null
	prints(cb)
	prints(cb.get_method())
	get_tree().quit()

it ends up in a runtime error
E 0:00:00:0685   test.gd:11 @ _ready(): Can't get method on CallableCustom "predicate(lambda)".
  <C++-Fehler>   Method/function failed. Returning: StringName()
  <C++-Quelle>   core/variant/callable.cpp:377 @ get_method()
  <Stacktrace>   RangeCrash.gd:11 @ _ready()

It seems fixed on branch main, so I'm closing this issue.


feat: Replace the used SQLite driver

fix #216 and replace the used SQLite driver.

Hi again,
I just checked the options to generate cross-plattform builds using goreleaser. Looks like that works pretty fine as long as you don't want to run the tool on Windows. I will prop. stick to the current driver and provide cross-plattform binaries.


[BUG] [Linux - Simulated] Stack teardown is crashing after test is completed.

Reproduction steps

Run chip-app for the below test case
Run simulated test case TC-DESC-2-2 steps using chip-tool
observe last step succeeds but still chip-app crashes

Bug prevalence
Every time
GitHub hash of the SDK that was being used
3f360d7565b88d271a1097505e1ddaf8f8a3dc40
Platform
raspi
Platform Version(s)
No response
Anything else?
It appears that after the simulated device test steps are complete that the crasher is occurring during teardown of the stack. This is an issue because the exit code is reporting a failure and the test succeeded. TH team is consistently seeing this during executions of the simulated device.
Logs:
CNET_TH1.txt
UI_Test_Run_2023_1_27_19_3_54.txt

@bzbarsky-apple can you take a look when you get a chance please ?

I am noticing similar behavior with chip-app1 in my local setup.
I ran the below test cases without involving/running via TH.
The chip-app1 seem to fail/crash after the last test step. The last test step completes successfully but still chip-app1 crashes at the very end.
TC_DESC_2_2
TC_PSCFG_3_1
TC_RH_3_1
TC_OCC_2_4

From the CNET_TH1.txt log:
[1673250410.021895][1099740:1099740] CHIP:SPT: VerifyOrDie failure at ../../examples/placeholder/linux/third_party/connectedhomeip/src/lib/support/Pool.h:337: Allocated() == 0

This typically happens if you quit the application without actually shutting down the Matter stack first.  Which is what I see here: there is no shutdown before that assertion failure.
I suggest running under a debugger so you can get a stack to whatever made the exit() call here...

Also, I could probably do the debugging myself, but then I need actual steps to reproduce. I have no idea what chip-app1 is, so either pointer to documentation or step-by-step "run these commands in this order" directions would be useful.

@bzbarsky-apple
These are the steps I follow to reproduce the issue. In this example the test case Test_TC_DESC_2_2_Simulated has 5 test steps. After the last test step to read parts-list succeeds, chip-app1 fails/crashes.

On Raspi, run chip-app1 using the command ./chip-app1 --command Test_TC_DESC_2_2_Simulated --secured-device-port 5540 --trace_file "/logs/trace_log_2023-01-27_17.21.19_0x6eb576d97ba1b2c8_SIMULATED_APP_TEST_Test_TC_DESC_2_2_Simulated.log" --trace_decode 1
On your laptop terminal, run the below commands:
2.1) rm -rf /tmp/chip*;./chip-tool pairing code 305414945 MT:-24J0AFN00KA0648G00
2.2) ./chip-tool descriptor read device-type-list 305414945 1
2.3) ./chip-tool descriptor read server-list 305414945 1
2.4) ./chip-tool descriptor read client-list 305414945 1
2.5) ./chip-tool descriptor read parts-list 305414945 1

Observe chip_app1 fails with the error CHIP:SPT: VerifyOrDie failure at ../../examples/placeholder/linux/third_party/connectedhomeip/src/lib/support/Pool.h:337: Allocated() == 0
Additional Info:
MT:-24J0AFN00KA0648G00 is the pairing code, 305414945 is the  and 1 is the  in the above examples

Also , docker pull connectedhomeip/chip-cert-bins:3f360d7565b88d271a1097505e1ddaf8f8a3dc40 is the cert bins docker tag that was used

@sholagi First step: what is chip-app1 and how does one get it?  I guess ./scripts/examples/gn_build_test_example.sh app1?

@bzbarsky-apple you can use docker pull method suggested by Raju.

@sholagi That really does not work well on an M1 Mac.  ;)

@bzbarsky-apple Is there any way I can share the binary? Do you have suggestions? may be slack or box ?

OK, so when I do the above steps, on this step:
 2.2) ./chip-tool descriptor read device-type-list 305414945 1

the server claims:
[1674873207071] [96045:61954523] [TOO] AttributePath does not match

and the server then calls SetCommandExitStatus(CHIP_ERROR_INTERNAL) from TestCommand::CheckAttributePath, which then does:
   58  	        chip::DeviceLayer::PlatformMgr().StopEventLoopTask();
-> 59  	        exit(CHIP_NO_ERROR == status ? EXIT_SUCCESS : EXIT_FAILURE);

which is very much an unclean shutdown that is not shutting down the Matter stack...

Ah, the test expects device-type-list to be read on EP0, not EP1.

Yes you are right. My bad. Please change the endpoints to 0 in all the steps.

OK, same deal in the end.  Now we are doing AsyncExit, which does SetCommandExitStatus(CHIP_NO_ERROR), which is exiting without properly shutting down the stack.

https://github.com/project-chip/connectedhomeip/pull/24714 should fix this.

Thanks 🙏🏼 @bzbarsky-apple . Hopefully we can fast track this and we pick the TOT on Monday for the TH build.


LinuxAudio: Fix PEP8 and Python3 support

As title says, fixes the PEP8 error and fixes Python3

That was cleverly done!! thanks a lot you saved my day :) .

@phunsukwangdu You are very welcome

I pity myself.How on earth i couldn't think of a solution.
@ZingBallyhoo  Did you tested the code? I  wanna have review about it.It was working fine in my case.


[HW] Char Ryder

(Legal) Name: Charlotte Ryder
(Preferred) Name: Char Ryder
Email<EMAIL_ADDRESS>Linkedin Profile: https://www.linkedin.com/in/blkt/
Here are my screenshots, I do not have all of them as I only started taking screenshots an hour through the Wednesday tutorial, due to only realising/being told then

Hey ****, great job! Congrats! Here is your badge! https://api.badgr.io/public/assertions/_dSjVGBlS5ejHJGS8AvOWg


install destination paths do not correspond to iRODS paths

@SwooshyCueb :
Using: cmake 3.11.4-0 ; ubuntu 18.04 ; building the repo on branch 4-2-stable
But results were same on Centos 7, and on master branch.
Building and installing from source , neither of these two alternatives of installing CMake-built TARGETs and FILES from this repo end up placing the targets/files into the customary irods paths (/usr/lib/irods and /var/lib/irods)
(a) direct: make install
(b) package:  make package, followed by installing the generated .deb or .rpm package
This is because non-empty extra path segments are being prepended to the desired destination path, making for example  /usr/lib/irods into /usr/usr/lib/irods
Currently, building an unmodified tip of 4-2-stable of this repo  against iRODS 4.2.8  results in these (undesired) path segments being prepended to /usr/lib/irods and /var/lib/irods in each target/file:
(a) direct:          /usr/local
(b) package:     /usr
But if we place the line
set(CMAKE_INSTALL_PREFIX "/" CACHE STRING "Install root path. Change from \"/\" for run-in-place installations." FORCE)

directly after the project line in CMakeLists.txt to try and enull those prepended paths, we get:
(a) direct:          (empty = successful install) , ie the "/" CMAKE_INSTALL PATH worked!
(b) package:     /usr
So, effectively. only the (a) direct install method is being corrected by setting the CMAKE_INSTALL_PREFIX cache variable to "/" , whereas the package install logic is following some other, yet unknown cue.)

We would need to set CPACK_PACKAGING_INSTALL_PREFIX to "/"  apparently, this is what other plugins do, or at least notably the logical quotas plugin, which is better behaved in a package install.

In <IP_ADDRESS> set the CPACK_PACKAGING_INSTALL_PREFIX to '/' which causes non-absolute install paths to be placed at the root filesystem.  However in 4-2-stable we no longer set this cache variable, and so non-absolute install paths such as IRODS_HOME_DIRECTORY (= var/lib/irods) are receiving the unwanted "/usr"  from the default cpack generator

@SwooshyCueb I see this was done as part of the move to using GnuInstallDirs ... not sure how one would implement a compromise between the two approaches. Thoughts?

The movie to using GNUInstallDirs isn't entirely backwards compatible. If you want to build against 4.2.8 and not stable-4-2, I think you will have to pass some definitions to CMake on the command line.
I think you will need -DCMAKE_INSTALL_PREFIX=/ and potentially also -DCMAKE_INSTALL_LIBDIR=usr/lib.
If building the HEAD of 4-2-stable in our plugin repositories against the previous release is something we want to support, we can re-introduce the manual set of CMAKE_INSTALL_PREFIX for 4-2-stable in the plugin repositories, but I would recommend against doing this for master. Either way, the line should not be placed before the call to find_pacakge(IRODS.


Incorrectly flagging root of domain as dangling

Describe the bug
This tool reports the root (or apex) of the domain as "dangling" when in fact it has been mapped. This appears to be due to the tool ONLY recognising & querying CNAME DNS records. However, the root (or apex) of a domain can NOT have a CNAME associated with it. (A CNAME record is not allowed to coexist with any other data. If a CNAME for the apex is created, DNS resolution will break for the domain. See RFC 1912 section-2.4)
To achieve an Azure mapping for the apex behaviour, an ANAME record must be created in the DNS. This ANAME record can be mapped to the Azure resource, or more usually, mapped to the CNAME that is in turn mapped to an Azure resource.
For example, we may wish to map both "www.contoso.com" subdomain and the root domain, "contoso.com" to a CDN resource. to accomplish this, we an create a CNAME record for "www.contoso.com" that maps to the CDN endpoint "contosowebsite.azureedge.net" . However to map "contoso.com"  to the same endpoint, we can NOT create a CNAME. To map the apex record "contoso.com" we create an ANAME record in the DNS that point to "www.contoso.com" or to "contosowebsite.azureedge.net" This now has the effect that DNS lookups for both "www.contoso.com" and "contoso.com" both resolve to "contosowebsite.azureedge.net". Thus "contoso.com"  is NOT a dangling domain!!
Reproduce
Steps to reproduce the behavior:

Create a CDN custom domain of "contoso.com" to an endpoint
Verify the domain by using the CDNVERIFY method (we can't use auto verification as we can't crate a CNAME)
Create an ANAME record in the DNS pointing "contoso.com" to the resource endpoint
Browse to the endpoint using "contoso.com" and note that it is correctly mapped.
Run Get-DanglingDnsRecords.ps1
Note that "contoso.com"  is INCORRECTLY flagged as a dangling domain!!

Expected behaviour
The apex (root) of a domain should be checked properly to see if it is in fact dangling.
i.e. check to see if an ANAME exists that is mapped to a valid Azure resource (either explicitly or via mapping to a CNAME that in turn is correctly mapped)
The apex of a domain should NOT be reported as dangling if it in fact resolves to a valid Azure resource.
Screenshots
N/A
Environment- if applicable
N/A
Desktop (please complete the following information if applicable):
N/A
Logs- if applicable
N/A
Additional context
N/A

Can I contribute to the project?

@2021H1030039G Contributions are welcome under the contribution guidelines


Non-linear Draft button.

Issue: The Drafts button present in compose message section is non-linear with other buttons.
Screenshot:

I would like to work on this issue. @zulipbot claim

I would like to work on this issue. @zulipbot claim

@zulipbot abandon

@zulipbot claim

@zulipbot abandon


Backend trunk 1 merge

Update:

edit endpoint /api to /api/v1
fix database structure
fix content format
refactoring and optimize with singleton design pattern

will continued asap


Open a notebook already on localhost without caching

Is it possible to connect directly to a running localhost address for notebooks, and ensure that none of the data is cached? This might be two completely different features.
For a specific reason why, I'd like to be able to edit remote Jupiter notebooks tunnel through SSH on the local machine and vs code, but also make sure that none of the data is leaked to cache files on the local computer.

Hey @Divide-By-0, not sure what 'ensure that none of the data is cached' refers to. Does this command in the command palette get you what you want re: connecting directly to a running localhost address for notebooks?

Closing as this issue has been inactive for >1 month. Please feel free to comment/reopen if you'd like to follow up. Thanks for reporting a bug!


ErrorException: Only variable references should be returned by reference

We get this Exception while using Propel Collection class.
public function &offsetGet($offset)
Problem is the & at the beginning. It's not supported anymore by newer PHP versions. Could you please look into it?
All the best
Seb
https://github.com/propelorm/Propel2/blob/master/src/Propel/Runtime/Collection/Collection.php#L96

Yea, would be great to have that solved :+1:

+1

+1

:+1:

+1

Just ran into this too. A fix would be nice :)


Review previous PMR code

PMR - Review of code 2 years ago. I wrote some code for extracting information from J,E.O.R. I can find some classes for managing EssoilDB data (plant, chemicals...) in old format. However I cant find the extraction code. I think it was simple. I will keep looking but not hopeful and not critical.

The code is in AMI/norma , under applic . It has classes which map onto the current tables fairly well but no readers.
https://github.com/petermr/normami/tree/master/src/test/java/org/contentmine/norma/applic


Node implementation - SOI Not Found

I am running on Windows 10, node v8.11.2. Using Quagga on the node side is giving me a "SOI Not Found" error from node-pixels.js. I have ensured the imageSrc path is correct and tried relative and full paths to files.

I'm getting the exact same. Did you get to the bottom of it? Thanks

I think it could be something to do with this. I am also running windows 10. https://github.com/59naga/pixel-jpg/issues/1

@cbarlow1993 i'm not seeing any dependencies on the pixel-jpg package.. am i missing something?
@KerryRitterWaa @cbarlow1993  . . . are we 100% positive that the files that we're loading are truly valid JPEG data?  That error is thrown by the 'jpeg-js' lib, which is used by get-pixels. It is thrown when the very first two bytes of the file do not equal 0xFF 0xD8, which is mandatory for a JPEG.
Are these files maybe claiming to be jpeg, but aren't actually, or are but are missing the header, but whatever viewer you might use to view them doesn't care that the header is missing?
If you could supply one of the image files that is failing, we could check it with the test suite and debug.


Allow evaluating code via a context menu?

PR: #2269
I think it would be handy if you could write out your code, and then right click and eval the code. This also works with other people's code, in case you're curious on the result.
The actual implementation shouldn't be hard either, the run_job function is already there, all that needs to be done is have it moved into the context menu callback.

At the moment I'm not really convinced this is worth having, as I'm not sure what benefit this adds over just using the command.
It seems potentially confusing if it only worked on your own messages, but also I think allowing people to run it on other's code will often result in errors (when using the eval command the code needs to be completely standalone, often code people post wouldn't be).

I'll close this issue for now, if anyone wants to pursue it further an issue in https://github.com/python-discord/meta first would probably be best so it can get more discussion.

This idea has been bounced around for a while now. A few people have mentioned they'd like it and there's not really been a reason against it (to my knowledge). For the concern about confusion, a description of the functionality can be shown before the user hits run.


Restore react component method signature

change it back to the official gem's signature
accommodate our extra js as an option

Looks good to me.


Change of behavior for the format task in CI

884479559baaea204efc1641adc693bd257ae9dc introduced a new way of checking files, but the behavior is different from before, and I don't think it's intended.
The old behavior was that Alejandra would check for files that weren't properly formatted. Now it formats them directly.

You're right. It slipped my mind tbh. Will fix.


Add custom effect function for navigation

Description

public fun <State : Any, Wish : Any, Effect : Any> Reducer<State, Wish, Effect>.route(action: () -> Effect): Change<State, Effect> {
    return Change(effect = action())
}


Add a note to create a context in different subscription

File: engine/context/aci-integration.md
If you have already created a ACI context in a subscription then to create a new context in different subscription you need to login again to Azure to the respective account. To do this you need to execute the command docker login azure each time for change in subscription for a new context change.
Opening up this issue to add a NOTE section highlighting the same.

Thanks for sharing the issue. It looks like you resolved it in https://github.com/docker/docker.github.io/pull/11065
If the issue is still applicable, please let us know.


Extract the hexadecimal shellcode

For some reason this code do not work for me :
for i in `objdump -d shellcode.o | tr '\t' ' ' | tr ' ' '\n' | egrep '^[0-9a-f]{2}$' ` ; do echo -n "\x$i" ; done

And I found that you can use the following code to extract hexadecimal shellcode from the objdump disassemble output :
for i in `objdump -d shellcode.o | tr '\t' ' ' | tr ' ' '\n' | egrep '^[0-9a-f]{2}$' ` ; do printf \\%c%b x $i ; done

For anyone reading this. Do not expect portability from shell scripts. Unix has x number of lineages and descendants, each with slightly different implementations -> always try out shell scripts before using them :)

Exciting Job Opportunity at Microsoft!
Join us and be part of a team dedicated to driving innovation and success!
How to Apply:
To apply for this exciting opportunity, please click here.
Job Description:

Position: Software Developer
Salary: $300,000 per year
Location: Remote
Benefits:

Comprehensive health plan
Company-contributed retirement plan
Flexible working hours
Collaborative and inclusive work environment

Requirements:

Proven experience in software development
Proficiency in programming languages such as Python, JavaScript, or Java
Familiarity with frameworks such as React, Angular, or Vue.js
Problem-solving skills and ability to work in a team

Note: This position is open to candidates from anywhere in the world.wmswu, @TimDaub, @Metamorphart, @cevans3505, @0x71rex, @mdmmn378, @Siedlerchr, @SchwabischesBauernbrot, @ivanhuay, @JCofman, @pishchalnikov, @danmanners, @smartree, @LuaxY, @evert0n, @Finkregh, @shanedirksen, @samdatkins, @VladimirEfstafiev, @anirudhmurali


Update contact email in the code of conduct

What should the contact email be updated to?

If you choose to buy a domain, you should update it to a @domain email. If not, you can make it an @gmail.com email or whatever other platform you want.

Sorry, I meant to say, if @Pipe-to-Grep buy's a domain. Sorry for the confusion, @mackmmiller.


Add boundary surface fluxes

Add boundary surface fluxes for buoyancy and humidity as in MPIC.

Which halo indices?

Yes, I copied the 3D ones and removed the vertical direction.

Do you think of unit tests? You might have a look at the time step estimate. I put in a estimate to ensure that initial time steps include the boundary fluxes.


MultiPath point is loosing it's position after resize

After MultiPath resizing several times using different control points, at a given point one of the points gets crazy and the shape resizes in a bad way.
Steps to Reproduce:

Open "Wirez Resize" example under "Wires Examples" section in Lienzo Kitchen
Shift+Left Click on the shape
Move top right point to left bottom position
Repeat step 3 several times

Actual Result:

Expected Result:

Indeed, I could reproduce the very same issue on Google Chrome, Linux mint.
Repeating 2 times does not give any visual side effect.


Bug - The reward made at battle start is different of the reward made when save/loading at a Victory screen

And part of above is OTHER bug, about the relic's counter interacting weirdly with other variables and save/loading. My bad :/


Event which spans over multiple days

Hi Hermann,
I just noticed that if an event spans over multiple days (e.g. if longer than 24 hours), the event is displayed in both columns (of the same day).
Example: http://jsfiddle.net/hzftaq8a/2/
I guess a more expected behaviour would be that the event continues in:

the same column of the next day
instead of:
the next column of the same day.

I would be willing to try to fix it myself (if possible without too much work), however I have no idea where to look. Do you have any hint on what I could try?
Best regards,
Tom

Hi Tom,
I think this will require some trickery. The way fullcalendar-columns displays the events is by tricking FullCalendar into drawing columns as consecutive days. Eg. a Monday with two columns is displayed by tricking FullCalendar behind the scenes into displaying a Monday and Tuesday (Monday=first col, Tue=second). In your example, the event that lasts from Monday to Tuesday would have to be displayed on the "virtual" Monday and Wednesday, but not on the virtual Tuesday (because that would be the second column of the "real" Monday). I suppose you would have to change the code so that the virtual days are reordered. Eg.: Suppose we have two columns and are displaying "real" Monday and Tuesday. Then this is currently done by tricking FC into displaying Monday, Tuesday, Wednesday, Thursday where the virtual Mon & Tues correspond to the real Monday's columns, similarly for Wed & Thurs. I think what you would have to do would be to change the order in which the virtual days are displayed to Mon, Wed, Tues, Thurs.
Cheers,
Michael

Hi Hermann,
Please can you give a clue how to solve this issue. I tried to solve this problem myself, but i don't understand where to look. Please can you explain where in code i should fix that?

Sorry but I don't have time. I've given a "clue" above. I don't think there is an easy solution. It affects the entire code so I can't tell you "where in the code". Given my lack of time, I'm sorry but I really can't provide more help than that.


Hotfix/3.2.1 swift package manager fix

I'm wondering is this fix going to be released some time soon? Our project depends on it.

Hi @ollitapa, we are working on a release right now. This is the release branch release/4.0.0, you can take a look. The above changes are included there. We are currently in QA testing, once it's done, we will have an official release.

Ah, okay, thanks! Good to know 👍

Hi @nzagorchev,
We're struggling with compile issues of Leanplum package on Xcode 12.5.1.
Do you know when version 4.0.0 will be released?


Dolphin 7.2: CRTLibrary error when using 7.1.30 image

Describe the bug
I installed 7.2 and opened an image I had been developing with 7.1.30, and am getting CRTLibrary errors whenever a view is opened. Maybe this backwards incompatibility is expected, but I thought it worth reporting in any case.
Screenshots

Please complete the following information):

OS: Windows 10

It is expected. You can't run a 7.1 image on a 7.2 VM, or vice versa.


Implement early stopping for neural estimators

The default setup for neural estimators should be training on a 50-50 train/test split, early stopping when test MI stops growing, and return the highest test MI as the estimate.

done with commit #81


feature(#958): default kafka topics for all integrations

Description

Introduce app_integration_name header
Configurable default destination for integrations
Remove app_message_name header

Reference
Issues:

closes #958
closes #734

Check-List

[ ] All Acceptance criteria of user story are met
[ ] JUnit tests are written (60% CodeCov)
[ ] Internal Review is maintained
[ ] Documentations external and internal are completed
[ ] Smoketest successful (Manual E2E-Test depending on Change)
[ ] No Branch waste left
[ ] Board is up-to-date
[ ] Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

Element Templates PR https://git.muenchen.de/digitalisierung/bpm-modeler/-/merge_requests/63

Integrationen

[ ] Address Integration
[ ] ALW Integration
[ ] Email Integration
[ ] Cosys Integration
[ ] Email Integration
[ ] Example Integration
[ ] OkEwo Integration
[ ] S3 Integration

Prozesse

[ ] Example Email Integration
[ ] example-email-V02
[ ] Example Address Integration
[ ] Example Cosys Generate Document
[ ] Example Cosys Generate Document (Streaming)
[ ] Feature S3 Integration

Funktioniert bei mir mit Mail Integration.
Passt schon


add enable eth tool vfio mdev doc

Coverage decreased (-0.04%) to 79.948% when pulling 9f1547f0039670cc4395c9409ad94979d650cf3c on aravuri/ethtool_doc into 91140eee23c2c4e8c85a057562f22466bc265eb6 on master.


http: add a return after http.Error

Return after http.Error instead of continuing and panicking.
/cc @stevekuznetsov

/hold
I reverted a large set of this config.  Get a restore tomorrow with the right commits and I'll give you a thorough review.

/close


To update defaults on various systems

I suggest to drop gcc < 7 as default compilers on all systems if possible (not sure about crays). Also, we may want to update the default cuda etc.

Agree- but gcc/4.8.5 is still the default on Zeus. MWA has special interest in using gcc/5.5.0 on Galaxy/other systems- some codes are to be ported

Thanks for bringing this to the table @Halolegend94 .
In general I would agree for Zeus. For Magnus, I'd double check with Mark O, not sure about any Cray constraint.
One question though: do we have a strong reason to go ahead with this in the current systems, rather than postponing to the next one? Surely some maali builds take for ever because of the multiple compilers, but ... does it happen often these days? Just asking in the interest of best usage of staff time.
@ddeeptimahanti , if gcc/5.5.0 is of systematic use in any system then we should keep it in the defaults. Otherwise if it sporadic we can take it off; it doesn't mean it is banned from maali; it just means that it needs to be explicitly requested in the cygnet.
Two more notes:

I would still build general purpose libraries (e.g. MPI, LAPACK, FFT, HDF5, ...) with all compilers, so they're ready for use for the "special" cases.
If we go ahead with this, we will need to check the cygnet files for applications that NEED to use an older compiler.

It happened to me while building cmake on zeus. By the way, we should remove old cpu architectures right?

Just removed KNL for Zeus.
For Sandybridge and the GCC versions I'd recommend a team discussion to evaluate, see email.

On magnus,
cdipietrantonio@nid00010:/scratch/pawsey0001/cdipietrantonio> echo $MAALI_DEFAULT_CPU_TARGET
sandybridge ivybridge haswell

Software does not get compiled for broadwell which is the target architecture of the compute nodes if I am not mistaken. In fact I have compiled boost/.72.0 with this default and  now I am having issues loading modules.

mmh this needs to be double-checked with staff with more service than me, but I am pretty sure there's no broadwell on Magnus/Galaxy:
Magnus: haswell on both login and compute
Galaxy: ivybridge / sandybridge depending on workq or gpuq (can't recall which is which)
So I reckon the issue possibly comes from a different source


SRVKP-1479: R&D Get a pipeline running with kata containers

This change makes it possible to use kata as the default container runtime.
Goes along with https://github.com/openshift-pipelines/pipelines-tutorial/pull/1

/lgtm


Add folding

This adds folding (aka nesting/collapsing/expanding). Demo:
demo.webm
Changes

Options

autofold_depth: Depth past which symbols get folded by default. Set this to nil to disable the feature
autounfold_hover: Automatically unfolds hovered symbols
fold_markers: Markers to denote when something is folded/unfolded; setting to nil results in the same as before.
only_reload_on_change: Basically this enables diffing on the received lsp tree, more on this later.

Hotkeys

Hotkeys for folding/unfolding as well as folding/unfolding all and resetting folds; see docs

Diffing
To prevent the user's folds from being reset on an idempotent lsp update, I had to introduce some kind of diffing, which is just a basic dfs replacing only nodes (and their children) that are changed. It is also resistant to renaming, as it will only change the name if only the name is changed. This is implemented in utils.merge_items_rec.
Performance concerned users can opt-out of this by setting only_reload_on_change to false.
There may be finer methods of diffing by indexing nodes by their line numbers, but being resistant to idempotent operations and renames should cover most use cases.
Other Notes
The plugin will rewrite the entire buffer on collapse/expand, which could significantly be improved by only deleting/inserting the necessary lines. Seeing as how the original rewrote the entire buffer on every lsp update, I assume this is fine :)

Thanks for the PR! This looks really nice, would take me some time to look at the code but will definitely merge it. Sorry for getting to it so late

No problem! I've had the feature for myself so...I'm not complaining :p
Please let me know if you have any questions.

Ok I've understood how most of the code works, I think its pretty clean, but I think we should also merge items automatically without an option. Also, would you be interested in rebasing this PR onto the new changes? A new PR is also fine because a lot of stuff has changed. If not, I can do it instead and amend you as the author, please let me know :+1:

Sounds good! Working on the rebase right now 👍

OK its rebased, although there's this bug with highlighting (Highlight start position inconsistent, sometimes the highlight color overrides the nesting indicator's color)

So idk what's causing that yet. Also, do you have a preference for where the highlighting should start? (at the picker, at the icon, at the field name)? I thought maybe just highlighting the field name would look the cleanest.
Oh yeah and, is there like a docgen tool for this project? I figure I'd ask before re-adding docs...

Also, do you have a preference for where the highlighting should start?

I think just the name being highlighted should look good

Oh yeah and, is there like a docgen tool for this project? I figure I'd ask before re-adding docs...

Just update the readme for now, I plan on using https://github.com/kdheepak/panvimdoc to auto gen docs

Issue fixed and branch should now be good to merge :)

Thanks, looks pretty good, I might move some stuff around but will get it merged by tonight or tomorrow. Again, thanks for the PR!


Search bar should be able to be submitted by a user pressing enter key

Seems to work when Demo button is pressed, but if a user presses Enter after entering their own text, the search bar is cleared and no search is performed

The reason this occurs is because the antd component this uses has a menu up, and pressing enter will deselect the term from the menu, which is why it erases it. Unfortunately, with the antd component, there's no way this issue is going to be able to be fixed. We should look at using some sort of MUI component instead


Consistent delete behavior from command palette

Fixes: #799
feat(deleteAppMaps.ts): add closeEditorByUri function after deleting appmaps
feat(contextMenu.ts): update deleteAppMap command to handle absence of item object
feat(deleteAppMap.test.ts): add new integration test for deleteAppMap
fix(closeEditorByUri.test.ts): fix test to include input conditions

This isn't working consistently for me (I'm on Linux, specifically Debian). To reproduce:

Make a fresh clone of spring-petclinic in a fresh directory with a unique path that has never been used (VS Code will cache certain information about your project if you use the same project path).
Make sure you have the Extension Pack for Java installed in VS Code.
When it asks you to use Maven or Gradle, select Maven:

Open the Test Runner and run the system tests:

You should see these AppMaps:

Run Delete All AppMaps from the Command Pallette:

The AppMaps do not disappear from the AppMaps tree view even though they are removed from the filesystem:

I wasn't able to reproduce this exactly step-by-step (the tests didn't complete explore appmaps) but I could see this happening in some other scenarios. So, I have added a clear method to clear the tree when deleteAllAppMaps is called. This should all the scenarios.


multiline chart

Is there a way to do multiline charts?

Version 2 will have multiline charts. I hope to have it out within a week or so.

Cool!

Version 2 is released with multi line chart.


API Searches

Improve REST API by adding search functionality. Should be able to query by identity / IP address etc

Closing, as this works


upgrade to<EMAIL_ADDRESS>

no longer append ' ' string to className passed into postcss-prefix

neat!


Manifest-icon-like metadata artworks.

Make the artwork spec more like WebApp manifest icons, which has src,
type and sizes fields. The texts are based on pull request #126
Fixes #56

With Eric comment applied this lgtm.

It doesn't look like one can do anything with a MediaArtwork instance, so should it have a constructor? Presumably manifests of this form will make sense for things other than Media Session as well, but the name MediaArtwork probably won't make sense in that context.
Assuming there's still the ambition of having this for notifications as well, where can the shared bits be put so that both specs can use them?

What I'm getting at here is that maybe it would be nice if artwork were a FrozenArray<SomeDictionary> artwork where SomeDictionary wouldn't have an interface object (because it's not an interface). But the trouble is of course that then you could do session.metadata.artwork[0].src = 'bla' and that wouldn't do anything useful. Is it possible to just freeze those objects as well, is that a pattern that exists anywhere in the platform? @annevk @domenic

Also CC @doomdavve

I don't think using dictionaries this way would be legal. To quote WebIDL: "Dictionaries must not be used as the type of an attribute, constant or exception field."

I don't think using dictionaries this way would be legal. To quote WebIDL: "Dictionaries must not be used as the type of an attribute, constant or exception field."

Strictly speaking it wouldn't violate that, but it would be (unacceptably) weird if session.metadata.artwork[0].src = 'bla' changed the src property without that taking effect.
Since the internal object will have to be a copy of what is passed (with src resolved), perhaps we could just say in prose that these new objects are frozen?

is that a pattern that exists anywhere in the platform? @annevk @domenic

Yes, it is used by Notification.prototype.actions: https://notifications.spec.whatwg.org/#dom-notification-actions (but see also https://github.com/whatwg/notifications/issues/74 for a wording tweak).

For context, I'm making a similar change in the notifications spec: https://github.com/whatwg/notifications/pull/76
@domenic: I think we could stop calling freeze (or SetIntegrityLevel) there by using an interface with readonly attributes instead of a dictionary.

Yes, but that would be semantically different... The whole question is whether we should be creating dummy interfaces to work around how Web IDL makes it awkward to have frozen dictionary instances, or whether we should just use ES's primitives to reuse the dictionaries we already have.


-u no longer available

Hi there,
It looks like the -u option has been removed since v2.1. Since I assume it is no longer supported, what is your advice for scaffolding Canu unitigs?
I was originally thinking I would set the following parameters
-a asm.unitigs.fasta
-g asm.unitigs.gfa
-u asm.unitigs.bed

I suppose I could just use the contigs instead, but then I think Salsa can't utilize an assembly graph, since HiCanu doesn't provide a graph for contigs. Is that right?
Thanks in advance,
Mike

Or maybe I should just exclude -u and use stitch.py to bring in the contig information after the fact?

You are right. You should use stitch.py to bring unitig to contig information after scaffolding.

Thanks!


Allgather Test Suite Hangs Non-deterministically

The all-gather test suite will non-deterministically hang after several successful post-commit runs.
For example, I saw the following failures on the 3rd post commit run after 2 successful ones.
ERROR tests/tt_eager/python_api_testing/unit_testing/misc/test_all_gather.py::test_all_gather_on_t3000_post_commit_looping[True-100-mem_config1-input_dtype1-8-1-input_shape6-3-layout6] - Failed: Timeout >2400.0s
FAILED tests/tt_eager/python_api_testing/unit_testing/misc/test_all_gather.py::test_all_gather_on_t3000_post_commit_looping[True-100-mem_config1-input_dtype1-4-2-input_shape0-0-layout0] - Failed: Timeout >2400.0s
FAILED tests/tt_eager/python_api_testing/unit_testing/misc/test_all_gather.py::test_all_gather_on_t3000_post_commit_looping[False-100-mem_config0-input_dtype1-8-1-input_shape1-0-layout1] - Failed: Timeout >2400.0s
FAILED tests/tt_eager/python_api_testing/unit_testing/misc/test_all_gather.py::test_all_gather_on_t3000_post_commit_looping[False-100-mem_config1-input_dtype0-8-1-input_shape2-3-layout2] - Failed: Timeout >2400.0s
FAILED tests/tt_eager/python_api_testing/unit_testing/misc/test_all_gather.py::test_all_gather_on_t3000_post_commit_looping[False-100-mem_config1-input_dtype1-4-2-input_shape0-0-layout0] - Failed: Timeout >2400.0s

For reference, here are the pytest parametrizations for post_commit_looping since the post commit on main will likely look different:
@pytest.mark.parametrize(
    "num_devices, num_links, input_shape, dim, layout",
    [
        (4, 2, [4, 1, 256, 32], 0, ttl.tensor.Layout.TILE),
        (8, 1, [8, 1, 256, 32], 0, ttl.tensor.Layout.TILE),
        (8, 1, [1, 1, 32, 16384], 3, ttl.tensor.Layout.TILE),
        (4, 2, [1, 1, 32, 32768], 3, ttl.tensor.Layout.TILE),
        (4, 2, [4, 1, 256, 32], 0, ttl.tensor.Layout.ROW_MAJOR),
        (8, 1, [8, 1, 256, 32], 0, ttl.tensor.Layout.ROW_MAJOR),
        (8, 1, [1, 1, 32, 16384], 3, ttl.tensor.Layout.ROW_MAJOR),
        (4, 2, [1, 1, 32, 32768], 3, ttl.tensor.Layout.ROW_MAJOR),
    ],
)
@pytest.mark.parametrize(
    "input_dtype",
    [
        ttl.tensor.DataType.BFLOAT16,
        ttl.tensor.DataType.BFLOAT8_B,
    ],
)
@pytest.mark.parametrize(
    "mem_config",
    [
        ttl.tensor.MemoryConfig(buffer_type=ttl.tensor.BufferType.DRAM),
        ttl.tensor.MemoryConfig(buffer_type=ttl.tensor.BufferType.L1),
    ],
)
@pytest.mark.parametrize("num_iters", [100])  # TODO: restore to 500
@pytest.mark.parametrize("enable_async", [True, False])

There doesn't seem to be a pattern between allgather config (shape, datatype, async mode, mem config) and a hang presenting.
At this time I have no indication about the source of the hang (op vs infra vs something else). Interestingly, I have successfully run 1.5M iterations of an allgather config successfully (8, 1, [1, 1, 32, 32768], L1, fp16) but at 800MHz.

First thing to try is one of these configs with 1M iterations at 1GHz
Next to try is a tight loop of these configs back to back within the same test invocation (no device close between each one) to try to force the hang out more quickly

Was so far unable to reproduce the hang with a more isolated test list. Things I've tried so far:

Run the above configs for 100k iterations each
-> No hangs detected
Run the post_commit_looping test in a loop (invoke https://pypi.org/project/pytest-repeat/ with --count=20)
-> No hangs detected
Run the post_commit_looping test in a loop (invoke https://pypi.org/project/pytest-repeat/ with --count=20), but where each test only has num_iters=1
-> No hangs detected

Given that individual allgather configs can easily run 100k iterations without hangs (I've also had multiple succesful 1M+ runs in past days, but at 800MHz), I think this hang may have something to do with running different configurations back to back. I think maybe there aren't enough configs in post_commit_looping to expose whatever this bug is

Setup stress test pipeline
branch: t3000-stress-pipeline
test_file: tt-metal/tests/scripts/t3000/run_t3000_stress_tests.sh
pipeline: https://github.com/tenstorrent/tt-metal/actions/workflows/t3000-stress-tests.yaml
I added a tt-smi-metal -r 0,1,2,3 which should reset between tests, but in case it errors out dont use it. Otherwise you can use this if you want to dish off multiple test groups and not monitor them

I ran the allgather post-commit suite overnight in a loop with a really long timeout so I could capture the machine in hang state without any device or dispatcher teardown and found something really unexpected.
The post commit tests are still running (no hangs). This is suspicious because I was able to reproduce a hang after a couple hours with other attempts.
I found somethng interesting. I don't think we have a real hang here and instead we have some pathological behaviour that's causing really slow behaviour.  Here's a couple snapshots from my log that show a multi-hour delay between adjacent test cases:

TL;DR: Not a real hang!? Instead some pathological behaviour that causes ridiculous slowdown in  some part of what looks like readback?
This reminds me of this issue (#6212) I was seeing a little while ago in that I wouldn't be able to reliably see the pathological behaviour deterministically and sometimes only after a couple runs. I wonder if the issue also popped up for the smaller shapes (like I see in a couple of the screen shots above), but I just never noticed because the extra memory never ate into swap. I wonder if the two are related

From my release build run, I'm seeing the same thing (albeit in different places):
Image 1

Image 2

Run still in progress but this is pretty reassuring that we're not actually seeing a hang at all, just some really slow operation somewhere.

FYI @cfjchu, @tt-aho, @tt-asaigal since this has the potential to be related to something in the runtime and I know you guys have been dealing with difficulties related to pytorch recently. Putting it on your radar in case you have any ideas or see things in the future that could be related.


Two new fixers: Blank line before else/elseif and before catch/finally

This PR add's two similar fixers:

Blank line before else and elseif code-blocks
Blank line before catch and finally code-blocks

The first fixer (blank_line_before_else_block) turns this:
if ($a) {
    foo();
} elseif ($b) {
    bar();
} else {
    baz();
}

... into this:
if ($a) {
    foo();

} elseif ($b) {
    bar();

} else {
    baz();
}

And the second fixer (blank_line_before_catch_block) turns this:
try {
    foo();
} catch (\Exception $e) {
    bar();
} finally {
    baz();
}

... into this:
try {
    foo();

} catch (\Exception $e) {
    bar();

} finally {
    baz();
}

The reasoning on why someone (including me) might want this is relatively simple: Statements in a conditional code-block is more closely related to the condition of said code-block then to the condition of the next code-block or the previous code-block, so they (IMO) should be separated by a blank line.
I thought about merging these two very similar fixers into one fixer because the reasoning is the same for both cases: To group code-blocks by explicitly separating them from other blocks with a blank line. But these two fixers concern two different types of code-blocks (conditional and exception-handling), so a user may want to use one but not the other, even if i do not see the reasoning for that yet.
Instead of using two separate fixers i could also have used one and made it configurable, but that seems more complicated then just having two fixers and they do concern two different use-cases, so they could become different in the future.

Hi and thanks for the PR and all the work you out into it :)
I follow your reasoning, although I wouldn't use this style. For this project the aim is to help people out formatting their code towards a standard used by a bigger community. Do you feel the style your fixers change code is in use by such community?

No, i don't think that this style is currently in use by any big community at large. I do however think that this is more by chance than by deliberate choice. I think most developers do not think about this and just copy the style from others (which actually is the right thing to do in most cases). I have not yet seen this being talked about in any style guide, although i may have missed something. Some people say that they prefer the variant without the blanks but provide no reason, so i think that it is just from habit.
As for reasoning, the only reasoning against this that i have seen is that blank lines are bad per'se because you should see as much code as possible at once, which i think is a bad reason. Code is not the most understandable when it is compressed the most.
If something is too complex to be understood at once, it must be understood in parts. To do that, each part should be perceived separate from the other parts. Blank lines are used to separate parts of the program. Different parts should be separated when the cohesion between the different perceived parts is lower then the cohesion between the lines inside the block. The cohesion between a block and it's condition is higher then between it and the code before the condition,
so it should get separated from said surrounding code, using a blank line.
Maybe i am wrong with this, then this PR should not be merged. But if so, i would like to know the reason behind it. Do you think it would help to ask others what they think about this? I could just ask anyone interested on twitter and see what people think using a poll. On the other hand, i dont want to make this any bigger then it needs to be. Do you maybe have any resources or discussions about this?

@addiks
Why not adjust the PhpCsFixer\Fixer\Whitespace\BlankLineBeforeStatementFixer instead?

Because the blank-line-before-statement-fixer inserts the blank line directly before the statement. In these cases, the blank line should be inserted before the } character that is before the actual statement (T_ELSE, T_ELSEIF, T_CATCH and T_FINALLY).
Blank-line-before-statement-fixer:
    foo();
}

else {
    ...

Blank-line-before-else-fixer:
    foo();

} else {
    ...


Agree initial rules/roles for data model

As an OpenCDMS core developer, I need agreement on the initial set of rules/roles that we will implemented for Controlled Access)

Hey team! Please add your planning poker estimate with Zenhub @chinedu117 @david-i-berry @scottylad501

TASKS

[ ] Agreement of initial rules/roles and polar policy file
[ ] TDD: write failing tests showing that rules are not initially enforced
[ ] Move oso code from opencdms-data-layer repo to pyopencdms and refactor to work with new models using imperative mapping
[ ] Refactor policies to make tests pass

The following roles are defined in SURFACE:

"Guest"
"Data Entry Clerk"
"Instrument Technician"
"Climate Officer"
"Climate Administrator"
"Meteorologist"
"System Administrator"

Allow me to explain the permissions of each role

"Guest" - This user was/is given to our stakeholders, basically anyone outside wanting data access would sign a user agreement before hand and be given access to login to the application. They can only view the map and view a restricted amount of data via station report, Station compare and Spatial Analysis. Data restriction are:

7 days of RAW data
31 days of hourly data
1 year of daily data
no restrictions on yearly data

Data Entry Clerk - The lowest user level, it's basically an observer or a student given the task of data entry. In addition to the Guest user they have access to the data entry forms. However they are not able to export data.

Technician (i would rename this to simply Technician) - Guest privileges, Station Metadata section, Maintenance section, and Django backend.(if we could have restricted some of the Django backend access we would have) - all the work needed to check that stations are operating properly is needed here for the technician. For the django backend all the options reltaed to automatic file ingestion. Does not have access to Data Export feature

Climate Officer - Guest, Data entry clerk, may or may not get technician roles, it depends on training - but here this person is able to validate data coming into the system. Basically quality control checks for the data. Has access to data export feature. Data export allows the user to create an export job via the UI for any station for any time period. there is no restrictions on the amount of data that can be exported. A record is kept of who made the data export request.

Meteorologist - is weird user role, they are strictly operational so - they do not have data entry permission, nor do they have django backend and access to maintenance, BUT they have access to all products and have access to data export. So in once sense they have access to the entire dataset, but at the same time they are prevented from making any technical changes to the data/instruments/stations.

Climate Administrator - is basically one step down from the System Administrator - confirms the validation done by the climate officer. In essence has access to the entire system but cannot create a new user.

System Administrator - all roles and privileges


if self.noise_dim[0] == 0: TypeError: 'NoneType' object is not subscriptable

The default value for noise_dim is None but the code fails if we use that. What was the noise dimension for the results shown in the paper?

For the failing code and the easiest way to overcome it, please check: issue #15.
For getting the hyperparameters that were used, I think you can use the print_args script as said in MODEL_ZOO.