bump httpcomponents versions

note core and client are no longer kept in sync; latest version of each has been taken
this seems to fix strange problems with HttpRequestSensorYamlTest failing in maven but working in eclipse, presumably due to use of TestHttpServer using these components.  it does not however fix the JVM crash in that test under java 7 sadly.

This is probably ok, but we should double-check the conflicting dependencies (e.g. will it cause runtime errors in httpasyncclient:jar:4.1 (a dependency of cxf-rt-transports-http-hc, which is needed by winrm4j)).  Or might some dependent bundles have been built to depend on httpclient [4.4,4.5) (so fail to install, unless we include both versioned bundles in the karaf install)?

Another reason to upgrade - current version doesn't use system proxy passed through -Djava.net.useSystemProxies=true or -Dhttp.proxyHost

Can apply the changes on feature.xml as well.

LGTM. Feels like the right moment to merge this.

I have some failing tests locally:
  ApplicationResourceTest.testDeployApplicationFromBuilder:227->BrooklynRestResourceTest.waitForApplicationToBeRunning:157 expected [true] but found [false]
  UsageResourceTest.testGetApplicationUsage:161->createApp:309->waitForTask:351 task AsOhrOHp not finished expected [true] but found [false]
  UsageResourceTest.testListApplicationUsages:90->createApp:309->waitForTask:351 task R1AyyoGm not finished expected [true] but found [false]
  UsageResourceTest.testListMachinesUsageForApp:302 usages=[UsageStatistics{statistics=[UsageStatistic{status=RUNNING, id='oawydt4n04', applicationId='oawydt4n04', start='2016-12-16T19:12:57+0000', end='2016-12-16T19:12:57+0000', duration=7, metadata={}}], links={}}] expected [true] but found [false]

recent changes:  fixed one compatibility issue, refer to v0.11 not 0.10, and rebased on master . (see last two commits for these tiny recent changes)
i don't seem to get the failing tests @neykov reports so maybe that was a different issue
re karaf and impact on "httpasyncclient:jar:4.1 (a dependency of cxf-rt-transports-http-hc, which is needed by winrm4j)", as noted by @aledsage, i have not tested either.  i'll try to do this but others (cc @bostko re winrm4j) may be more efficient at doing that which is fine also!

I've tested this with winrm4j and it's not working. It's sending the wrong Content-Type, resulting in a 415 response code.
Bumping the cxf version to 3.1.9 works fine though and it brings in almost the same dependencies:
[INFO] +- org.apache.cxf:cxf-rt-transports-http-hc:jar:3.1.9:compile
[INFO] |  +- org.apache.httpcomponents:httpcore-nio:jar:4.4.4:compile
[INFO] |  |  \- org.apache.httpcomponents:httpcore:jar:4.4.4:compile
[INFO] |  \- org.apache.httpcomponents:httpasyncclient:jar:4.1.2:compile
[INFO] |     \- org.apache.httpcomponents:httpclient:jar:4.5.2:compile

Suggest upgrading cxf to 3.1.9 and downgrading core to 4.4.4.

See https://github.com/cloudsoft/winrm4j/pull/44 for another reason to upgrade to CXF 3.1.9.

Trying to test this (including the cxf upgrade to 3.1.9), it is failing when starting karaf with:
2017-01-06 15:29:40,191 ERROR  11 o.a.k.f.i.s.BootFeaturesInstaller [pool-7-thread-1] Error installing boot features
org.osgi.service.resolver.ResolutionException: Unable to resolve org.ops4j.pax.web.pax-web-jsp/4.2.4: missing requirement [org.ops4j.pax.web.pax-web-jsp/4.2.4] osgi.wiring.package; filter:="(&(osgi.wiring.package=javax.servlet.jsp.resources)(version>=2.2.0))"
        at org.apache.felix.resolver.ResolutionError.toException(ResolutionError.java:42)[org.apache.felix.framework-5.4.0.jar:]
        at org.apache.felix.resolver.ResolverImpl.resolve(ResolverImpl.java:404)[org.apache.felix.framework-5.4.0.jar:]
        at org.apache.felix.resolver.ResolverImpl.resolve(ResolverImpl.java:158)[org.apache.felix.framework-5.4.0.jar:]
        at org.apache.karaf.features.internal.region.SubsystemResolver.resolve(SubsystemResolver.java:216)[11:org.apache.karaf.features.core:4.0.4]
        at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:263)[11:org.apache.karaf.features.core:4.0.4]
        at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:259)[11:org.apache.karaf.features.core:4.0.4]
        at org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1089)[11:org.apache.karaf.features.core:4.0.4]
        at org.apache.karaf.features.internal.service.FeaturesServiceImpl$1.call(FeaturesServiceImpl.java:985)[11:org.apache.karaf.features.core:4.0.4]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_111]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_111]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_111]
        at java.lang.Thread.run(Thread.java:745)[:1.8.0_111]

Talking to @m4rkmckenna, it is likely that the error shown is not the underlying cause.
I'm going to try applying these changes incrementally (starting with the cxf 3.1.9 upgrade), to see if I can get karaf to start properly!

See https://issues.apache.org/jira/browse/BROOKLYN-423 for tracking the upgrade to cxf 3.1.9, and some initial findings. I'll look into this a little longer.

#547 is a better more holistic fix; closing here in preference to that


Geneating video with skeleton overlayed

Hi!
I was wondering if I could generate a video clip with the skeleton overlayed to get an idea of the performance of the network as in the supplementary video. Is there a tool as a part of the package and if not could you please give some pointers as to how this may be achieved.
Thanks!

Hi, @harshk95 . You can use the "View3D" option inside Label3D -- please see the Label3D (https://github.com/diegoaldarondo/label3d) docs for more detail.


updated to NPFS

Did you confirm that these updates do validate with the FHIR validator?

they passed validation 4 months ago,
i just replaced NPFSm with NPFS

thanks

did you mean to close the pull request?

in order to be sure i've runned the validator and they are valid resources. So we can close the pull request

yes i colsed this pull request because i updeted one of the resources that i have deleted.


Copy all files for review

Setup for code review
DRY
KISS
YAGNI

Hi @Theodoraldo ,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights
JavaScript best practices :heavy_check_mark:
DRY, KISS, and YAGNI rules :heavy_check_mark:
Cheers and Happy coding!👏👏👏


Stack routing failure

related to #690
fixed
test:

make install
amp pf stop
amp pf pull  (should pull appcelerator/haproxy:1.0.4)
amp pf start -v
amp stack up test1 -f ./examples/stacks/pinger/stack.yml
wait for stack started
curl url http://www.test1.local.axwaytest.net/ping -> "pong"
amp stack up test2 -f ./examples/stacks/pinger/stack.yml
wait for stack started
curl url http://www.test1.local.axwaytest.net/ping ->  "pong"
curl url http://www.test2.local.axwaytest.net/ping ->  "pong"
amp stack rm -f test1
wait for stack removed
amp stack up test1 -f ./examples/stacks/pinger/stack.yml
wait for stack started
curl url http://www.test1.local.axwaytest.net/ping -> "pong"
curl url http://www.test2.local.axwaytest.net/ping -> "pong"

regression tests:
make test

I am not sure this is fixed. I tested this pretty extensively and am getting mixed results. I can get it to fail consistently if I start and remove the stack multiple times. The following shows the behavior when I perform the sequence 6 times. 4 successful, 2 failures.
 Some else cold test?

I tried testing using the pinger example. It did work, however, I've been testing with the other examples and they still don't seem to be working? wasn't the issue originally that all the stack examples apart from the pinger weren't working? I've been testing the other examples with these changes and these are the outputs:
Counter:
[09:25] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ amp stack up test2 -f ./examples/stacks/counter/stack.yml
5b0bf77a90fb5a015ac2df83de160e0c7935eb722a78c51e33bd2a3c6672091d
[09:26] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ curl http://go.counter.local.atomiq.io
no server found for stack=counter service=go
[09:32] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ curl http://go.counter.local.atomiq.io
no server found for stack=counter service=go
[09:32] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ amp stack rm -f test2
5b0bf77a90fb5a015ac2df83de160e0c7935eb722a78c51e33bd2a3c6672091d
[09:33] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ amp stack up test -f ./examples/stacks/counter/stack.yml
0679d724a434b15395190c35be2e912f8b35176f5f6cca373f9315ed23fcdc25
[09:33] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ curl http://go.counter.local.atomiq.io
no server found for stack=counter service=go
[09:35] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ curl http://go.counter.local.atomiq.io
no server found for stack=counter service=go
[09:35] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ curl http://python.counter.local.atomiq.io
no server found for stack=counter service=python

Micro:
[09:40] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ amp stack rm -f test
bd1260714f364a6529ccc1312a7cde472001ab2d617ea1406dd851d3c0a18243
[09:40] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ amp stack up test -f ./examples/stacks/micro/stack.yml
rpc error: code = 13 desc = rpc error: code = 13 desc = Error response from daemon: network test-public not found
[09:40] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ amp stack up test -f ./examples/stacks/micro/stack.yml
ddf1875add7e8266c3a85a462920be15f735ccdf797c7d35990b98bf1327c628
[09:40] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ amp stack rm -f test
ddf1875add7e8266c3a85a462920be15f735ccdf797c7d35990b98bf1327c628
[09:41] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ amp stack up test -f ./examples/stacks/micro/stack.yml
rpc error: code = 13 desc = rpc error: code = 13 desc = Error response from daemon: network test-public not found
[09:41] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ amp stack up test -f ./examples/stacks/micro/stack.yml
d22b33f4d253f23250e81a025daad014f3e53dc714c0b467798bd4d01644355d

Micro would not startup...
mi2875c3pjnt  nats                running   replicated  1/1       0
ct3l8df6v6if  registry            running   replicated  1/1       0
ph1tv1caj3or  telegraf-agent      running   global      1         2
whhuere7zs8s  telegraf-haproxy    running   replicated  1/1       1
6snyl0wtj2hd  test-haproxy        running   replicated  1/1       0
6nrg505jfv03  test-micro          failing   replicated  0/1       4

Voting-App:
[09:44] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ amp stack up -f instavote ./examples/stacks/voting-app/stack.yml
open instavote: no such file or directory
[09:45] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ amp stack up instavote -f ./examples/stacks/voting-app/stack.yml
6fc397e27380155e64b994f9ffddfb791fb03dde6b7dbb4208c6e4597b109f2f
[09:45] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ amp stack rm -f instavote
6fc397e27380155e64b994f9ffddfb791fb03dde6b7dbb4208c6e4597b109f2f
[09:47] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ amp stack up instavote -f ./examples/stacks/voting-app/stack.yml
rpc error: code = 13 desc = rpc error: code = 13 desc = Error response from daemon: network instavote-public not found
[09:47] jgrahamjones@ITEM-AX40140:amp (stack-routing-issue $ u=) $ amp stack up instavote -f ./examples/stacks/voting-app/stack.yml
1f5ee2a904c82604e2df5c1c13916812a9bff052b52421345a51e2b6c064da4c
``

Same issue with micro...

mi2875c3pjnt  nats                running   replicated  1/1       0
ct3l8df6v6if  registry            running   replicated  1/1       0
ph1tv1caj3or  telegraf-agent      running   global      1         2
whhuere7zs8s  telegraf-haproxy    running   replicated  1/1       1
n3purqma0808  instavote-db        failing   replicated  0/1       4
9d30wgulszgk  instavote-haproxy   running   replicated  1/1       0
ikzmkk1ekdvn  instavote-redis     failing   replicated  0/1       4
lqa7xw8i56cu  instavote-result    failing   replicated  0/1       4
686icpjgg0gc  instavote-vote      failing   replicated  0/5       20
jdrlnjmbvvxm  instavote-worker    failing   replicated  0/3       12

I chatted with @freignat91 earlier and learned that he was running docker 1.12.6, while I was running docker 1.13.0-rc4. After, downgrading to 1.12.6, I retested all of the examples and everything is working as expected. I think for now, the prerequisite for these examples is 1.12.6.
@JosephGJ The instavote stack command you referenced above has the stackname and filename transposed. Also, the network error message you are receiving I believe is due to a prior stack removal still being in progress. I have encountered the Error response from daemon: network test-public not found message before, but it usually when I try to bring up the same stack before it has been fully removed. We may want to add a network dependency check to the stack rm, so this error does not occur. I will test further and open an issue if I can reproduce consistently.

The pinger app was working fine before. It was instavote and other stacks that were broken. I just tested with the PR and pinger still works fine, but if I curl the instavote app I get:
$ curl http://results.instavote.local.atomiq.io
no server found for stack=instavote service=results

$ amp stack ps instavote
NAME    IMAGE   NODE    DESIRED STATE   CURRENT STATE   ERROR   PORTS
redis.1.at39oawe16s2    redis:latest    moby    Running Running 3 minutes ago
result.1.zsftuqwk03me   danjng/example-voting-app-result:latest moby    Running Running 3 minutes ago
db.1.im8125gkwlh6       postgres:9.4    moby    Running Running 3 minutes ago
vote.1.kbzzy0m43r6e     docker/example-voting-app-vote:latest   moby    Running Running 3 minutes ago
vote.2.w3b2qi8x5dxh     docker/example-voting-app-vote:latest   moby    Running Running 3 minutes ago
vote.3.xq53yf4q1muk     docker/example-voting-app-vote:latest   moby    Running Running 3 minutes ago
vote.4.hu0gig0vv5rg     docker/example-voting-app-vote:latest   moby    Running Running 3 minutes ago
vote.5.cz7247bb20u2     docker/example-voting-app-vote:latest   moby    Running Running 3 minutes ago
worker.1.v67aaf7qhylf   docker/example-voting-app-worker:latest moby    Running Running 2 minutes ago
 \_ worker.1.t4aqn6zj1vjw       docker/example-voting-app-worker:latest moby    Shutdown        Failed 2 minutes ago    "task: non-zero exit (1)"
worker.2.882ofs6jvxec   docker/example-voting-app-worker:latest moby    Running Running 2 minutes ago
worker.3.re4x5djemcnc   docker/example-voting-app-worker:latest moby    Running Running 2 minutes ago
 \_ worker.3.rs11ckulcdqf       docker/example-voting-app-worker:latest moby    Shutdown        Failed 2 minutes ago    "task: non-zero exit (1)"

When I tried to run the counter stack it appeared to create the stack, but it didn't show up with amp stack ls and the stack was not available. However, when I tried to recreate the stack, the message said that the stack already existed. docker service ls didn't show anything related to the stack running. At that point I decided to restart amp.
After I restarted, it worked:
$ amp stack up -f stack.yml counter
aed95817756dca6ff11c0a996bdc1c02ca709cf4cdaadd67005feb98d9726622
$ amp stack ls
NAME      ID                                                                STATE
--------------------------------------------------------------------------------------
counter   aed95817756dca6ff11c0a996bdc1c02ca709cf4cdaadd67005feb98d9726622  Running
$ curl http://go.counter.local.atomiq.io
View Count:  1

Then, I stopped the stack, recreated it, and tested again and it failed.
$ amp stack rm -f counter
aed95817756dca6ff11c0a996bdc1c02ca709cf4cdaadd67005feb98d9726622
$ amp stack up -f stack.yml counter
rpc error: code = 13 desc = rpc error: code = 13 desc = Error response from daemon: network counter-public not found
$ amp stack up -f stack.yml counter
66fb2c724bb8d619db77bbdb0b756f086687d9c764a200108fae80b332469b49
$ amp stack ls
NAME      ID                                                                STATE
--------------------------------------------------------------------------------------
counter   66fb2c724bb8d619db77bbdb0b756f086687d9c764a200108fae80b332469b49  Running
counter (stack-routing-issue)$ curl http://go.counter.local.atomiq.io
no server found for stack=counter service=go

counter (stack-routing-issue)$ curl http://go.counter.local.atomiq.io
no server found for stack=counter service=go

counter (stack-routing-issue)$ curl http://python.counter.local.atomiq.io
no server found for stack=counter service=python

I created another counter stack:
$ amp stack create -f stack.yml counter2
1e20e6ca169bfa5acc0d61b6d5ca1d2fad7453557206dd06513bc762368e087a
$ curl http://go.counter2.local.atomiq.io

503 Service Unavailable

No server is available to handle this request.

My configuration:
Docker for Mac
Version 1.13.0-rc7-beta37 (15013)
Channel: Beta

It doesn't work on docker 1.13, I didn't test it on docker 1.13  considering we have to modify a lot stack management for docker 1.13. It can't work as it is for docker 1.12
So perhaps we can open a new Issue to make it works for docker 1.13 including the update to use native docker 1.13 stacks

@freignat91 Yes, I'm going to do that. I just didn't realize that our existing code would break, but thanks for the update.

@freignat91 The question is do we really need to merge this at this point? If it's broken for 1.13 anyway, then is it still relevant. If you still want to merge, just let me know.

Yes, i think  it's relevant because it improves the quality anyway. It lower a lot the issue frequency even on 1.13.
On the other hand, for sure the next "stack 1.13 amp version" will change so much the stack management that this fix won't be needed anymore.
So it's just in the meantime, for the ones using amp with its current stacks management.


Tatulli integration with Movies (times viewed) not working

I have setup Tatulli integration for both TV shows and Movies and i'm unable to get Movies to work correctly.  Note the difference of TIMES VIEWED vs TOTAL VIEWS in the rules of TV vs Movies.  I have confirmed that Movies being flagged by the rule do have a viewing number greater than 0 in Tautulli.
Tv Shows (working as expected)
Plex
Date added
before
amount of days
90
AND
Tatulli
Total views
equals
number
0
Movies (Not seeing total views correctly)
Plex
Date added
before
amount of days
90
AND
Tatulli
Times Viewed
equals
number
0

I have confirmed that Movies being flagged by the rule do have a viewing number greater than 0 in Tautulli.

Can you confirm the watch percentage of one of those movies? It will only count as a view if it's over the configured threshold which is set in Tautulli Settings -> General -> Watched Percent & Video Watched Completion Behaviour, OR the threshold configured under Tautulli watched percent override in the rule. The circle on the far right of the history row will be fully white when it's reached Tautulli's threshold.


Updates Swagger YAML for new added API.

Coverage decreased (-0.007%) to 51.119% when pulling e3f5e9e501b553c2a086246010a5d9602d62ba33 on wknet123:dev-update-swagger into 2119034c5c6f8917962aa3ff8ab6d457506d0fc1 on vmware:dev.


API docs for the stackclub library

Add a docs folder with an index.rst and a conf.py, and make the stackclub modules appear at
https://stackclub.readthedocs.io/en/latest/
sphinx-quickstart should get us most of the way there, then there'll be the inevitable fiddling with the modules bit. This is a sub-issue of #79, and could either be addressed in PR #80 or separately (depending on how quickly that gets approved).

Closed by #80 !


closure serialization

Right now we use webpack to do basic tree-shaking. I think pulumi's approach would be more efficient - they built their own closure serialization logic that will rip out only bits of the closure actually used at runtime (or AFAIK).
https://github.com/pulumi/pulumi/blob/master/sdk/nodejs/runtime/closure/createClosure.ts#L217

Closure serialization may no longer be necessary because the new Build and Run monads allow us to prune out expensive code. This is much simpler than serializing out a closure's code and data.
See: https://github.com/punchcard/punchcard/pull/53


Fix parameter validation for both libs (#202)

Description
Backport #202  to 1.2.
Check List

[X] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #203 (c33ea4f) into 1.2 (2657ea5) will increase coverage by 0.01%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##                1.2     #203      +/-   ##
============================================
+ Coverage     83.08%   83.10%   +0.01%
  Complexity      861      861
============================================
  Files           123      123
  Lines          3767     3771       +4
  Branches        361      361
============================================
+ Hits           3130     3134       +4
  Misses          475      475
  Partials        162      162

Impacted Files
Coverage Δ

...java/org/opensearch/knn/index/util/KNNLibrary.java
84.21% <87.50%> (+0.18%)
:arrow_up:

...index/codec/KNN80Codec/KNN80DocValuesConsumer.java
82.00% <100.00%> (+0.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2657ea5...c33ea4f. Read the comment docs.


feat(console): machine user accesstoken type

Closes #4208
### Definition of Ready
- [ ] I am happy with the code
- [ ] Short description of the feature/issue is added in the pr description
- [ ] PR is linked to the corresponding user story
- [ ] Acceptance criteria are met
- [ ] All open todos and follow ups are defined in a new ticket and justified
- [ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
- [ ] No debug or dead code
- [ ] Critical parts are tested automatically
- [ ] Where possible E2E tests are implemented
- [ ] Documentation/examples are up-to-date
- [ ] All non-functional requirements are met
- [ ] Functionality of the acceptance criteria is checked manually on the dev system.

Please add the new i18n keys to #5117

Please add the new i18n keys to #5117

Never mind, I added them.


Process for doing Releases (involving changeset)

We shouldn't bump a version of our packages with every commit or even every issue solved probably. And none of us should arbitrarily decide when to bump this version. We should somehow figure out the process of bundling our commits into releases.
https://docs.github.com/en/repositories/releasing-projects-on-github/about-releases
https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository

Right now we probably want a changeset per issue resolved (i.e. per average pull request). Bundling into releases is easy - you and I as product owners can decide when a release is ready and that point we bundle all changesets since last release into the latest release.
This is what i understood changeset helped us do https://github.com/changesets/changesets

The @changesets/cli package allows you to write changeset files as you make changes, then combine any number of changesets into a release, that flattens the bump-types into a single release per package, handles internal dependencies in a multi-package-repository, and updates changelogs, as well as release all updated packages from a mono-repository with one command.

There's more in https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md - in our case we are in a monorepo setup in that we have cli and the template. (NB: i think this implies we should have one central changesets  location rather than one per package - cf https://github.com/timlrx/pliny which has central .changesets folder).

@rufuspollock is it only about combining changesets files into changelogs and version bumps of the relevant packages or do we also need github releases for some reason?

@olayway i don't know - you get to choose and recommend the path we take.

@rufuspollock, since we're not publishing our template to npm, maybe creating GH releases, could actually be a good way of versioning it... but I'm not sure why we might want to do this at this point. I think it may (or may not) prove to be useful when we're working on the problem of template updates in the future. For now, I've only added some automation scripts and adjusted contributor docs.


vimPlugins.fastaction-nvim: init at 2024-10-26

Things done
Add fastaction-nvim vim plugin, an efficiency plugin designed to optimize code actions in Neovim.

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 352744

x86_64-linux

:white_check_mark: 2 packages built:

vimPlugins.fastaction-nvim
vimPluginsUpdater

aarch64-linux

:white_check_mark: 2 packages built:

vimPlugins.fastaction-nvim
vimPluginsUpdater

x86_64-darwin

:white_check_mark: 2 packages built:

vimPlugins.fastaction-nvim
vimPluginsUpdater

aarch64-darwin

:white_check_mark: 2 packages built:

vimPlugins.fastaction-nvim
vimPluginsUpdater

Tested briefly and everything looks good.

Thanks !


add command execution for motion and doorbell

Run a local shell command when motion or doorbell event is received

👍


Removes duplicate navbars for dates in tracks and rooms

Fixes #1206
Changes: Removes the duplicate navbars for dates in tracks and rooms page. Introduces a single unified navbar for dates and jump links in tracks and rooms page.
Screenshots for the change:
Before

After

Demo server : https://open-event-web-appp.herokuapp.com
@mariobehling @aayusharora @Princu7 Please review. Thanks.

Codecov Report

Merging #1223 into development will increase coverage by 0.09%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           development    #1223      +/-   ##
===============================================
+ Coverage        63.76%   63.86%   +0.09%
===============================================
  Files                9        9
  Lines             1482     1486       +4
  Branches           221      222       +1
===============================================
+ Hits               945      949       +4
  Misses             537      537

Impacted Files
Coverage Δ

src/backend/generator.js
71.79% <100%> (+0.41%)
:arrow_up:

src/backend/gulpfile.js
78.72% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c2210...fd7ff46. Read the comment docs.

Please read my comment here: https://github.com/fossasia/open-event-webapp/issues/1206#issuecomment-295333262
This change does not follow design principles as far as I can see. The same buttons need to perform the same actions across one app. We are changing that.


broken for latest stencil

Resources:
Before submitting an issue, please consult our docs.
Stencil version: (run npm list @stencil/core from a terminal/cmd prompt and paste output below):
 insert the output from npm list @stencil/core here

I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com
Current behavior:

Expected behavior:

Steps to reproduce:

Related code:
insert any relevant code here

Other information:

Thanks a lot, I have not followed the latest Stencil updates :)


Fixed skip version in rest-api-spec test search.highlight/30_max_analyzed_offset

Description

Adjusted skip version for test search.highlight/30_max_analyzed_offset from ' - 2.1.99' to ' - 2.12.99' as support for the 'max_analyzed_offset' parameter with plain highlighter began in version 2.13.

Note: The 2.x branch already has the correct skip version for this test case.

Related Issues
https://github.com/opensearch-project/OpenSearch/issues/10702, https://github.com/opensearch-project/opensearch-py/issues/686
Check List

~New functionality includes testing.~

[x] All tests pass

~New functionality has been documented.~

~New functionality has javadoc added~

[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
~Commit changes are listed out in CHANGELOG.md file (See: Changelog)~
~Public documentation issue/PR created~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saimedhi can you please dig up why the version was correct on 2.x and incorrect on main? did a PR get merged to 2.x instead of going to main and then get backported?

PR is fixed while backporting to 2.x


[Bug]: docker install puppeteer  Package google-chrome-stable is not available, but is referred to by another package.

Bug description
Running Puppeteer in Docker with
https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md#running-puppeteer-in-docker
terminal output：
15.15 Hit:1 http://security.debian.org/debian-security stretch/updates InRelease
15.15 Ign:2 http://deb.debian.org/debian stretch InRelease
15.34 Hit:3 http://deb.debian.org/debian stretch-updates InRelease
15.45 Get:4 http://dl.google.com/linux/chrome/deb stable InRelease [1811 B]
15.55 Hit:5 http://deb.debian.org/debian stretch Release
16.05 Get:7 http://dl.google.com/linux/chrome/deb stable/main amd64 Packages [1099 B]
16.08 Fetched 2910 B in 1s (1999 B/s)
16.08 Reading package lists...
16.43 Reading package lists...
16.75 Building dependency tree...
16.80 Reading state information...
16.80 Package google-chrome-stable is not available, but is referred to by another package.
16.80 This may mean that the package is missing, has been obsoleted, or
16.80 is only available from another source
16.80
16.81 E: Package 'google-chrome-stable' has no installation candidate
------

thanks
Puppeteer version
latest
Node.js version
node:12-slim
npm version
6
What operating system are you seeing the problem on?
Apple Silicon(M1)Mac
macOS Monterey
Relevant log output
No response

Currently encountering the same error on the MacBookAir m1 :(

I'm also facing this same issue

I'm facing the same error and also on MacBook Air M1.

This made the job for me:
docker build . -t my_service --platform=linux/amd64

@BrTkCa Thanks for the help, it works for me as well.

Unfortunately, @BrTkCa's solution didn't work for me :(
[MacBook Pro M1 Pro running macOS Monterey]

Have the same problem as  @islandjoe

Also using MacBook Pro M1 Pro running macOS Monterey and having the same issue 🙄

Also using MacBook Pro M1 Pro running macOS Monterey and having the same issue

Same problema here.

Same problem here, looking at the thread it's looking like an Apple silicon issue. Also using MacBook Pro M1 Pro running macOS Monterey 12.0.1 and having the same issue

El mismo problema :C

I have the same problem.

For those using docker-compose, add platform: linux/amd64 to your service definition

If I add --platform=linux/amd64 then the docker build command finishes but I get the following error when trying to use Puppeteer inside Docker container.
Error: Failed to launch the browser process!
qemu: uncaught target signal 5 (Trace/breakpoint trap) - core dumped
qemu: uncaught target signal 5 (Trace/breakpoint trap) - core dumped
[93:93:0728/082124.672818:ERROR:nacl_fork_delegate_linux.cc(311)] Bad NaCl helper startup ack (0 bytes)
qemu: uncaught target signal 5 (Trace/breakpoint trap) - core dumped
[38:38:0728/082124.730411:ERROR:browser_dm_token_storage_linux.cc(92)] Error: /etc/machine-id contains 0 characters (32 were expected).
[38:101:0728/082124.796418:ERROR:file_path_watcher_inotify.cc(329)] inotify_init() failed: Function not implemented (38)
[0728/082124.897969:ERROR:scoped_ptrace_attach.cc(27)] ptrace: Function not implemented (38)
Assertion failed: p_rcu_reader->depth != 0 (/qemu/include/qemu/rcu.h: rcu_read_unlock: 101)

TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md

    at onClose (/app/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserRunner.js:289:20)
    at ChildProcess.<anonymous> (/app/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserRunner.js:280:24)
    at ChildProcess.emit (events.js:412:35)
    at ChildProcess.emit (domain.js:475:12)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:285:12)

The same code works as expected on my old Intel Mac.

The above fix didn't work for me.
I had to upgrade to Node 14 to get this working.


When used in mobile. Default browser is not shown for the auth redirect of github

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: vscode.dev
OS Version: Andriod Edge

Steps to Reproduce:

Launch vscode.dev in edge of Andriod
Click on something which will trigger login auth via gihub. For instance sync settings.
Auth page is not directed to default browser when chosen to redirect links must be opened in new tab.

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

/gifPlease

I cannot create a gif easily as I am using mobile.

@Vankatavarun you should be able to record your screen on Android https://support.google.com/android/answer/9075928?hl=en
maybe it's not a gif, but video formats can also be uploaded here.

@TylerLeonhardt Just checking. Did you look at the steps to reproduce.

I did. I don't have an android device on me at the moment so it's probably easier for you to record your screen than for me to get an emulator working or something like that.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Color Table Tag Changes (#18445)

Description
Addresses most of #18444
Merge from RC
Docs!

@reviewers - please just take a look a the docs changes


Zqs 1097/build custatevec

Description
Include description of feature this PR introduces or a bug that it fixes. Include the following information:
Created wrapper function to execute CustateVec library through qsimcirq. This ensures that simulator always use GPU.
Please verify that you have completed the following steps

[X] I have self-reviewed my code.
[X] I have included test cases validating introduced feature/fix.
[X] I have updated documentation.

Codecov Report

Merging #19 (952f0de) into main (cb881b1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   94.98%   94.98%
=======================================
  Files           7        7
  Lines         319      319
=======================================
  Hits          303      303
  Misses         16       16

Impacted Files
Coverage Δ

...stra/integrations/cirq/simulator/qsim_simulator.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb881b1...952f0de. Read the comment docs.


require declaration syntax / closure compiler

One of the "fun" things about Closure Compiler on Advanced Optimizations is managing externs when you can't compile the whole page in one package. A really easy way to make Browserify's output play nicer with Closure is to simply update the way it sets the require variable, from require= to window["require"]=. It's then possible (and easy) to write a library for compilation by Browserify/ClosureAO by simply using a string literal to set all names that should not be changed.
module.exports = {
    minifed:        internalFunc,
    "notMinified":  exportFunc
};

or
myClass.prototype.unassumingTask = unimportantStuffFunc;
myClass.prototype["doImportantStuff"] = importantStuffFunc;

The only thing preventing this stress-free use of Advanced Optimizations right now is the syntax for setting "require". Temporarily I'm wrapping my output to correct it (and another couple leading/trailing patches for output I found to be missing)
(function(){ var

  // Browserify output here

; window["require"] = require;})();

still having trouble working with closure compiler+browserify
any news on adding good support for that?

I forgot to pay attention to this issue. @substack that's not a solution, closure still minifies when it finds window.require =. It absolutely positively must be a String literal.
This time I had better luck figuring out where the string in question comes from and patched it however, to get Master to work at all I had to rename prelude.js to _prelude.js and I dunno what's up with that.

@shenanigans: https://github.com/substack/browser-pack/pull/73 should have the side effect of fixing this also.


DigiCert is Symantec

The page lists Symantec as a source for the certs.  That being said, when you go there and click to open an account it sends you to DigiCert.  Apparently, after a Bing search, DigiCert bought Symantec's certificate business.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 93d3f097-d81b-66c2-4835-d63758687d34
Version Independent ID: fe9d1cdd-966e-89b5-c66b-60531b0ec655
Content: Get a code signing certificate - Windows drivers
Content Source: windows-driver-docs-pr/dashboard/get-a-code-signing-certificate.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @EliotSeattle
Microsoft Alias: eliotgra

Thanks for pointing this out, @Albert-Straub-CardinalPeak
I fixed the link and updated the instructions to match Symantec's actual site.
Pushed into our Main branch and should be live soon.
Eliot


[Improvement] Add optional environment variables

What changes were proposed in this pull request?
Added six optional environment variables:
# RSS_HOME, RSS home directory (Default: parent directory of the script)
# RSS_CONF_DIR, RSS configuration directory (Default: ${RSS_HOME}/conf)
# HADOOP_CONF_DIR, Hadoop configuration directory (Default: ${HADOOP_HOME}/etc/hadoop)
# RSS_PID_DIR, Where the pid file is stored (Default: ${RSS_HOME})
# RSS_LOG_DIR, Where log files are stored (Default: ${RSS_HOME}/logs)
# RSS_IP, IP address Shuffle Server binds to on this node (Default: first non-loopback ipv4)

Why are the changes needed?
Simplify service deployment
Does this PR introduce any user-facing change?
Added six optional environment variables.
With the default environment variables, the behavior is the same as before this PR.
How was this patch tested?
local test

Codecov Report

Merging #187 (01ef6f8) into master (5864420) will decrease coverage by 1.39%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #187      +/-   ##
============================================
- Coverage     58.37%   56.98%   -1.40%
+ Complexity     1270     1191      -79
============================================
  Files           158      149       -9
  Lines          8428     7930     -498
  Branches        782      751      -31
============================================
- Hits           4920     4519     -401
+ Misses         3255     3169      -86
+ Partials        253      242      -11

Impacted Files
Coverage Δ

.../apache/uniffle/coordinator/CoordinatorServer.java
60.21% <0.00%> (-5.38%)
:arrow_down:

...storage/handler/impl/DataSkippableReadHandler.java
81.25% <0.00%> (-3.13%)
:arrow_down:

...org/apache/spark/shuffle/RssSparkShuffleUtils.java

...k/shuffle/writer/WrappedByteArrayOutputStream.java

...ava/org/apache/spark/shuffle/RssShuffleHandle.java

.../java/org/apache/spark/shuffle/RssSparkConfig.java

...pache/spark/shuffle/writer/WriteBufferManager.java

...org/apache/spark/shuffle/writer/AddBlockEvent.java

...che/spark/shuffle/writer/BufferManagerOptions.java

...e/spark/shuffle/reader/RssShuffleDataIterator.java

... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

How about unify COORDINATOR_HOME and SHUFFLE_SERVER_HOME to RSS_HOME
All new environment variables can be defined in rss-env.sh

How about unify COORDINATOR_HOME and SHUFFLE_SERVER_HOME to RSS_HOME
All new environment variables can be defined in rss-env.sh

I think we can define RSS_HOME and RSS_CONF_DIR in rss-env.sh. I will modify the script later.

How about unify COORDINATOR_HOME and SHUFFLE_SERVER_HOME to RSS_HOME
All new environment variables can be defined in rss-env.sh

Done.
Would you mind take a look when you have some time? @colinmjj

LGTM, +1, thanks for the contribution, @izchen

Thanks for your review, @colinmjj @jerqi !


Graph view design

@waxlamp - This is a work in progress as I can't get the nodes into a v-list for some reason. Would you mind helping me review this?
Things I am planning to do once I get items in the list:
1.) two column view
2.) better pagination

@jtomeck has authorized me to merge this PR in his stead.


Update to MC Version 1.20.1

Update for latest MC version 1.20.1

Issue with parchment channel for now, will get back to this later

I'm closing all issues on this repo as I'm going to archive it today. I'm moving on to other projects as I'm just not really interested in continuing it. If you want a good alternative that is regularly updated. Please check out Mob Lassos https://www.curseforge.com/minecraft/mc-mods/mob-lassos by Fuzs.


Return phone type as a single char string in the API response

The response from endpoint still returned the phonetype as int values of the enum.
This would return the name of the constant defined in the enum.
Open to suggestions, comments and feedback on this approach

@humulla The enum is still there as the domain object still maps the phone type to the enum.
I can also change this but this felt like the smallest change to give us the desired result.
But open to completely removing the enum and returning the phone type as a string from the gateway.

@Renny4Real Yeh i feel like it should either be fully used throughout the API or not used at all, would be best to completely remove the enum in this case, but let's see what others think too

@humulla That makes sense. Couldn't remember if there was a reason we used the Enum at first but definitely up for removing it completely.

Merging this for now.
If we need to remove the entire enum, we could create another PR for it.


fix: Remove the duplicate ENABLE_SIP_VERIFICATION in ep_config.h

Either DatapathConfiguration.DisableSipVerification or SourceIPVerification option in endpoint can trigger macro ENABLE_SIP_VERIFICATION update in the ep_config.h. If DatapathConfiguration.DisableSipVerification value is not synced with SourceIPVerification, two value of macro ENABLE_SIP_VERIFICATION in ep_config.h may conflict.
This patch is to sync the value of DatapathConfiguration.DisableSipVerification and SourceIPVerification, remove one duplicate entry of ENABLE_SIP_VERIFICATION in ep_config.h

@oblazek Would you be able to verify that this still works for you? 🙏

sure, will test and get back to you

something is not right.. getting xx drop (Invalid source ip) flow 0x0 to endpoint 0, ifindex 20, file bpf_lxc.c:751, , identity 123734->unknown: fe80::f816:3eff:fe42:4d36 -> fe80::261:feff:feed:cafe NeighborAdvertisement
will take a deeper look

I can see #define ENABLE_SIP_VERIFICATION 1 in related /var/lib/cilium-state/state/1872/ep_config.h

@ChengyuanLiCY I left you some comments, once resolved I am super happy with this :)


Emberfire not working with Ember 3.4

Version info
e.g.
DEBUG: -------------------------------
DEBUG: Ember      : 3.4.x
DEBUG: Ember Data : 3.4.x
DEBUG: Firebase   : 3.4.1
DEBUG: EmberFire  : 2.0.10
DEBUG: -------------------------------

Test case
Start an Ember app with version 3.4
Steps to reproduce
Install current version of emberfire (2.0.10). And install Ember 3.4. Run it with ember serve. Site does not load.
Expected behavior
Side should load.
Actual behavior
Error in console
Uncaught Error: Could not find module `ember` imported from `emberfire/initializers/emberfire`
    at missingModule (loader.js:247)
    at findModule (loader.js:258)
    at Module.findDeps (loader.js:168)
    at findModule (loader.js:262)
    at Module.findDeps (loader.js:168)
    at findModule (loader.js:262)
    at requireModule (loader.js:24)
    at resolveInitializer (index.js:34)
    at registerInitializers (index.js:47)
    at exports.default (index.js:28)
```

@Ceany ember install ember-cli-shims should do the trick.

@fsmanuel That works perfectly. Thank you

you just have to execute the command in your ember app. than the ember addon will be installed.
That should do the trick to get the app back running

@mikespittal this link helped me figure out why ember-cli-shims was in my app. Hope it helps.

@mikespittal this link helped me figure out why ember-cli-shims was in my app. Hope it helps.

Thank you!


Would you mind providing a more detail on assembly ?

Hi,
It's a perfect soft.
When I used it to assemble my data, I could not understand the --read parameter, if I have data like R1_fq.gz, and R2_fq.gz， how to use it？
It can use like Spades.  -1,  -2, -U for input data?
Best wishes,
Deyuan

Hi @deyuanyang:
Thank ypu for using cuttlefish! I see that you're FASTQ inputs---in that case, you need to pass the --read argument. Besides, I also see that you're using the -f 1 argument, which specifies a specific output format among a few ones. When working with read sets, cuttlefish can only output the assembled maximal unitigs (i.e. contigs) for now, and so the -f option is not applicable.
I think for your example datasets mentioned above, you can use the following command:
cuttlefish build --seq <file-1> --seq <file-2> -k 33 -o <output-file> -t 8

Let me know if that solves the problem(s). Regards!


Microsoft.Build.Runtime still requires MSBuild Tools

I have an application using the Microsoft.Build nuget packages to compile some C# code. With MSBuild 2015 installed on the machine everything works fine. However I want to get rid of the MS Build Tools prerequisite and as I understand it Microsoft.Build.Runtime is supposed to solve that issue. In the description is says "This package delivers a complete executable copy of MSBuild. Reference this package only if your application needs to load projects or execute in-process builds without requiring installation of MSBuild.".
But if I run the code on machine without MSBuild Tools installed I get the same error message (Could not load file or assembly 'System.Threading.Tasks.Dataflow) even though I have included the Microsoft.Build.Runtime package. Have I misunderstood something or do I just need to Initialize the the Build.Runtime somehow?

You will still need the MSBuild tools installed.
This package will only carry the engine and some basic props/targets. You will still be missing a lot of things to be able to handle a variety of projects.


Add test that verifies the path

The following issue should not have happened: https://github.com/spring-cloud/spring-cloud-openfeign/issues/386
Add test for this area.

I will take a stab at this issue

I would like to resolve this issue. Please guide me to how to start

Hello, @Bhavya-official  The following bug was reported some time ago: https://github.com/spring-cloud/spring-cloud-openfeign/issues/386. The tests we had did not catch this regression. The bug was since fixed, but a test that would have caught the issue should be added as well. If you are an OpenForce 2022 participant, please contact mentors in spring cloud channel in OpenForce discord for if you need more help or have any questions.

@OlgaMaciaszek If any suggestions or modifications can be done, please let me know.


blog:bot helper CI job

cc @dims @sftim

@SubhasmitaSw this article looks like it should be published to the contributor blog - https://k8s.dev/blog/ - as its target audience is Kubernetes contributors.
Have I got that right?

yes, that's the intent.

/hold
This article should be submitted to the contributor site blog first - see #31919 (comment)

@sftim mistook it for the website solely, sorry for that. Should I redirect the changes to contributor-side repo?

You can keep this PR open @SubhasmitaSw, because once the blog article is published there, we want to mirror the article here. It's important to have contributor articles publish with https://k8s.dev/blog/* canonical URIs; that helps make the contributor site visible.

We actually won't mirror this one here. Thanks for publishing https://www.kubernetes.dev/blog/2022/03/15/k8s-triage-bot-helper-ci-job/ @SubhasmitaSw
/close


Landscape and portrait sensors are reversed

Hello. I am a user who is using your app usefully.
When I turn on the 'sensor rotation' while using the app on this device(SM-T536(Android 6.0.1), Perhaps the following problems arise because the device is long horizontally.), it is affected by the landscape sensor if I set the portrait sensor rotation, and the portrait sensor if I set the landscape sensor rotation. I hope there is a 'horizontal/vertical sensor switching feature' so that 'sensor rotation' can be used correctly in all devices. Thank you for developing this app and listening to my feedback!

There may be errors in English sentences because I used a translator app. I apologize for that.

Thank you.
You also sent me an email. I'm sorry I couldn't reply.
I've heard that some devices do have different default orientations and sensors have different orientations. However, I don't have such a device, so it's difficult to confirm... I will consider whether there is a good way.

I also understand very little English, so I'm writing this text using Google Translate and DeepL :wink:

Thank you.
You also sent me an email. I'm sorry I couldn't reply.
I've heard that some devices do have different default orientations and sensors have different orientations. However, I don't have such a device, so it's difficult to confirm... I will consider whether there is a good way.

I also understand very little English, so I'm writing this text using Google Translate and DeepL :wink:

Thank you.
You also sent me an email. I'm sorry I couldn't reply.
I've heard that some devices do have different default orientations and sensors have different orientations. However, I don't have such a device, so it's difficult to confirm... I will consider whether there is a good way.

I also understand very little English, so I'm writing this text using Google Translate and DeepL :wink:

Thank you for kind feedback!

Thank you.
You also sent me an email. I'm sorry I couldn't reply.
I've heard that some devices do have different default orientations and sensors have different orientations. However, I don't have such a device, so it's difficult to confirm... I will consider whether there is a good way.

I also understand very little English, so I'm writing this text using Google Translate and DeepL :wink:

Thank you for kind feedback!

I released 4.7.5 in open beta.
For this version, I tried to implement the ability to detect devices with landscape default and adjust the orientation of the sensor.
Since I don't have such a device, could you please check if it works correctly on your device if possible?

I released 4.7.5 in open beta.
For this version, I tried to implement the ability to detect devices with landscape default and adjust the orientation of the sensor.
Since I don't have such a device, could you please check if it works correctly on your device if possible?

It works great on my device!  Thank you for accepting my feedback.

It works great on my device!  Thank you for accepting my feedback.


Set dynamically default value of Time filter

apache superset 1.1.0
Time filter sets dynamic default values.
e.g.
"time range" : {
from: ‘The first day of this year‘
to: ‘now’
} @zhaoyongjie

Hi, there. Is it ?

Yep!


Profiles modules: undefined constants

Notice: Use of undefined constant BX_INFORMER_ALERT - assumed 'BX_INFORMER_ALERT' in /Users/alex/www/hihi/d8/modules/base/profile/classes/BxBaseModProfilePageEntry.php on line 64
Notice: Undefined index: BX_INFORMER_ALERT in /Users/alex/www/hihi/d8/template/scripts/BxBaseInformer.php on line 48

It happens just after Person (and maybe Organization) profile creation.


Mac OS X build compatibility

Hello Daniel,
I understand that you are not going to support building on OS X. I was wondering if you would mind including these minor changes nevertheless to make it easier to tinker around with the sources for those who prefer Mac OS environments.
This is my custom manifest to include the build system: https://gist.github.com/FeeJai/d4f8ba09ceb155dd6a9bba1904fca504

I switched to date -u, but I'd rather take a different approach for chrt since it can be missing on Linux too. It's also harmless for it be missing so it's just an annoyance right now.

How do you feel about something like this?
if command -v chrt >/dev/null 2>&1 ; then         gdate "$@" fi
Currently the script aborts execution if chrt is not available.


Version 2.1.2: Upgrade to Recon 2.5.1 from 2.3 (otp23 compat)

In order for instruments to be compatible with OTP 23, we need to use a more modern Recon. 2.5.1 fits the bill.

I think those old versions of OTP and Elixir aren't compatible with the newest version of Ubuntu. I'll dig more tomorrow.


Next

The next branch has the styles and JS from upstream master, and is merged into master on release


code-insiders 1.4.0 doesn't have 1.3.1's overflow icon when too many tabs are opened

VSCode Version: Code - Insiders 1.4.0-insider (f4780e67933164a2289b86f2c279aaa05fda672f, 2016-07-19T05:07:05.876Z)
OS Version: Windows_NT ia32 10.0.14390

Steps to Reproduce:

Open VS Code Insiders 1.4.0
Open a bunch of tabs to try to activate the overflow indicator
Observe that the indicator is not present in 1.4.0 as it was in 1.3.1

1.4.0:

1.3.1:

@dilijev please see #9159 for the reasoning behind the change.
@bpasero FYI.

We are still looking into tabs UX and might find a better way to restore this functionality without having a dedicated action.


add statistics to log file

add some small stats to the log file e.g.:

how many reads are in clean
how many reads are in contamination
percentage of contamination

Related to this, it would be great to get some detailed information for cleaning against a multi-species index. For example
23 % contamination
13 % human
5 % eco
5 % DCS
maybe this can be relatively easy done by counting the reads mapped to each single genome with samtools? something like
samtools view BAM -c contig_name

Or maybe there is already some statistics output from minimap2/bbduk possible?

Yes, I'm working on that.
bbduk has a nice build-in statistic; for minimap2 I didn't find something.

I have something like the HISAT2 summary in mind:
200000 reads in total; of these:
	1972 (0.98600%) reads were properly mapped; of these:
		1205 (0.60250%) aligned to Chromosome dna:chromosome chromosome:ASM80076v1:Chromosome:1:4558660:1 REF
		767 (0.38350%) aligned to gi|9626372|ref|NC_001422.1| Enterobacteria phage phiX174 sensu lato, complete genome

For minimap2 I am playing around with samtools idxstats. It gives you some numbers per contig. I'm not sure what I'm missing: the total number of reads somehow differs from the number of reads in the fastq file (this holds also for samtools flagstat where I don't sum up by hand).
samtools idxstats might count some reads multiple times if they are mapped more than once or in multiple fragments, but this does not explain fewer reads than in the fastq file.

Okay great, thanks for looking into this. An HISAT2-styled output would be great.
@samtools yeah, it's always tricky. All the time when I tried to do something with samtools+flagstats, at the end I was always not sure if things were counted correctly. Multiple mapped reads can be one issue. Or maybe unmapped reads are not counted and that's why you get a lower count than in the original FASTQ?

Uu, now I see that it is always more reads than the input!
secondary and supplementary from flagstat are counted as mapped in idxstats.
How should we handle this? Just go with "more reads than in the input"?

hm... can't you set some flag to only get unique reads counted? Our goal should be to have an exact percentage of decontaminated reads in the output.
another idea: can we tell minimap2 to only map a read once?  When a read hits the human genome it is contamination. Then the counting with samtools might be easier?

Okay, I have something:

with -N 0 we have no secondary alignments from minimap2

But we have still supplementary reads (Bit 0x800 indicates that the corresponding alignment line is part of a chimeric alignment.  A line flagged with 0x800 is called as a supplementary line), so:

run samtools idxstats on all mapped and not supplementary reads, and count the reads from the input fastq files

All properly mapped and not supplementary reads:

for fasta samtools view -b -F 2052 ${name}.sam
for nano samtools view -b -F 2052 ${name}.sam
for illumina  samtools view -b -f 2 -F 2048 ${name}.sam

(quite confusing and a bit ghetto, but it should work)
Are you OK with this implementation?

Sounds like a good solution to me!
So we will simply skip alignments that are flagged as supplementary?
How does such a supplementary (chimeric) alignment look like? One part of the read is mapping on pos X and the other on pos Y? And then per default two alignments (reads) are counted that we can avoid by setting 0x800? fine for me, then we can also state that supplementary alignments are not part of the reported statistic?

From the SAM Format Specification:

Chimeric alignment: An alignment of a read that cannot be represented as a linear alignment.  A chimeric alignment is represented as a set of linear alignments that do not have large overlaps.  Typically, one of the linear alignments in a chimeric alignment is considered the “representative” alignment, and the others are called “supplementary” and are distinguished by the supplementary alignment flag.  All the  SAM records in a chimeric alignment have the same QNAME and the same values for 0x40 and 0x80flags (see Section 1.4).  The decision regarding which linear alignment is representative is arbitrary.

So, disjunctive parts of a read align to different position and different orientations; one of these alignments is the representative one, the other x alignments are called supplementary. All of them are flagged as mapped and we end up with #normal aligned + x supplementary. To get rid of the supplementary alignments, we discard everything with 0x800 set.
Anyway, we count a read as one contamination read, whether it aligned once, or multiple times as chimeric. I'd say that serves the purpose.

Thanks for the explanation! I agree, that works for us!


Add material page, cupertino page, and transition page classes

Description
This is a spin off from the router PR https://github.com/flutter/flutter/pull/55316
During the router app rewrite, I figured it is non-trivial to write a page subclass where the route will reflect on page change. This is harder when trying to create a page with widget builder such as MaterialPageRoute or CupertinoPageRoute. This PR introduce several page classes for common use cases.
Related Issues
https://github.com/flutter/flutter/issues/45938
Tests
I added the following tests:
See files
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I signed the CLA.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[ ] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

@goderbauer can you take a look at this pr?

@goderbauer this is ready for another look

@goderbauer a friendly bump


Skip screengrab if NW isn't the active window

Just a small tweak to not screengrab when New World isn't the active window
Feel free to implement/change it however you like, consider this an idea

I'm a bit hessitant, because merging this would imply that we suddenly do start interacting with the actual game, which might have different implications regarding Amazon's stance on this (if they ever reveal them).


Functional Code Sharing

After a couple of months of work and testing with multiple parties, I think we are ready for the first big commit back into the main project.
Pretty extensive documentation in the main README about how to use the plugin and there is also pretty extensive documentation in the templating directory on how to extend and add templates into the project.
Please note that this PR does include built in options to allow the easy integration of Nativescript-Vue-Web, but it is not required for use in code sharing and it is not a default option either.

@rigor789 Can you please merge it?

Closes #2
Closes #6


Crash to desktop with no log on some Lua syntax errors (release build only)

It's not the first time that I make the mistake of using . instead of : for calling methods.
For example, I just typed Lara.GetState() instead of Lara:GetState() in a volume function script.
With a debug build of TombEngine, I get something like this in the logs, and no crash:
[2023-Jan-01 15:57:48] [error] Could not execute function LevelFuncs.Clockwork_OnMovePushblockWatermill: Scripts\Levels\Shambala.lua:61: sol: received nil for 'self' argument (use ':' for accessing member functions, make sure member variables are preceeded by the actual object with '.' syntax)
stack traceback:
        [C]: in field 'GetState'
        Scripts\Levels\Shambala.lua:61: in function <Scripts\Levels\Shambala.lua:59>
        [C]: in ?

However, with a release build, I only get a crash to desktop, and no error appears in the log (which is why I ran the debug build in the first place).

Fixed in 1.0.8. This particular error depended on a compiler flag which was not set in release mode.


i face an issue while create demo project in blazor

Severity	Code	Description	Project	File	Line	Suppression State
Error	CS0234	The type or namespace name 'FromResult' does not exist in the namespace 'Task' (are you missing an assembly reference?)	Task	C:\Users\hamee\source\repos\Task\Task\Data\WeatherForecastService.cs	17	Active

Do you have a small repro of the code/project that is generating this error?

@mairaw thanks for reply i resolved it.

Great to hear. Closing the issue then.


[V2.0] Assertion is added to check expected option is selected from dropdown

This assertion is need to write a Behat test for a scenario in PR https://github.com/Medology/www.healthlabs.com/pull/1026
This new assertion statement asserts whether the expected option in selected in a dropdown select menu.

Paging @Chekote to review the back-end work in this pull request!
Paging @ramsey-medology to review the testing work in this pull request!


Java Data Store

Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.
Is your feature request related to a problem? Please describe.
What the problem is. Example: I'm always frustrated when [...]
Describe the solution you'd like
What you want to happen.
Describe alternatives you've considered
Any alternative solutions or features you've considered.
Additional context
Any other context or screenshots about the feature request.

Applications need to build from start to finish !   There is nothing worse than getting thrown threw the big loop of distraction to try and get back where you  got stopped making progress


Incorrect Video URL still "loads"

If you put in an incorrect video URL you do not get redirected, nor do you get a flash message saying that the video is not found.  Instead you are taken to video display view with a video that never loads.
IE:
http://www.freecodecamp.com/videos/this-is-not-a-video
My expectation would be a redirect back to the map page with a flash message, if possible, same as a bad challenge link.

Which challenge is this in response to? Just want to look into it and see what I can do

This looks fixed; the link redirects back go /map.

Closing as resolved.


Xamarin Forms PinClick Problem

Hi,
I have a problem with PinClicked event, when i try to navigate to another page in this event nothing happens.
I have the same code to navigate in PinClicked event and button. When i the press button the navigation works but when i call navigate from PinClicked nothing happens
I create a repo to show this problem https://github.com/ptufail/TestingMapsuiIssue

Thanks for the reproduction project!

@ptufail I downloaded your example and try to test it, but get always an error. Both, on emulator and on device.
Unhandled Exception:
System.NullReferenceException: The current Activity can not be detected. Ensure that you have called Init in your Activity or Application class. occurred

Anything I have to change?

Hi,
I found the problem...
The PinClicked event need Device.BeginInvokeOnMainThread to navigate
Is supposed ?

Yes, everything related to the UI has to be done on the UI thread. This is not related to Mapsui.

So, your problem is solved and this can be closed?

So, your problem is solved and this can be closed?

Yes thanks


Rename server.js to a more specific name so that eslint is easily recognized by code --status

For tslint I´ve renamed the server.js to tslintServer.js

Good suggestion.


⚠ Hydeos has degraded performance

In 30540d2, Hydeos (https://hydeos.fr) experienced degraded performance:

HTTP code: 200
Response time: 1137 ms

Resolved: Hydeos performance has improved in 58b1b02.


About me tab needs an empty state

Closing as we're phasing out the vue frontend.

Closing as we're phasing out the vue frontend.


Add "book style" Title Case transformations

Feature request from 2020 Survey results:

Have real Title Case transforms that left articles like A, An, And, The lowercased as well as prepositions instead of capitalizing each word.

Libraries and News Org's definitely need that in the case of publications.  (Oxford Manual of Style, in general) https://en.wikipedia.org/wiki/Letter_case#Headings_and_publication_titles
The above was discussed in this mailing list thread

This is a totally non-trivial problem.
In addition to the Wikipedia page which describes the variation in general detail, there's also https://capitalizemytitle.com/ which enumerates some of the MANY variations just to deal with American English.
The British capitalise, not capitalize, their titles, but have similar variation, as do the French.
I don't know of any Java libraries. You could probably cobble something together using a combination of ICU4Js raw title case support followed by custom downcasing of words identified by a Part of Speech tagger along with a set of rules for each supported style, but it'd be a fair amount of work and probably would still require human cleanup afterwards for things like proper nouns, acronyms, and other things that an algorithm would have a very hard time getting correct.

Don't we already have title case transformation over here ? Or am I missing something ?

@kushthedude If you read the descriptions in the links, you'll see that the current transformation isn't the same.

@tfmorris Got that !


Improve and modernize the submodule cheat sheet

Overview
TL;DR
The "Submodules vs. Subtrees" cheat sheet was missing some important information about working with projects that have submodules, mainly that git pull and git checkout do not, by default, update the working directory of the submodule(s), causing much confusion and sorrow.
I also improved the other sections of this cheat sheet to add details and use more modern Git commands and flags. Each commit message explain the changes in details.

Questions
The submodule.recurse config is super useful, but it works correctly for git pull only starting with Git 2.15. Should that be mentioned ?

Thank you all! ✨


remove extra type casting in W3C TelemetryInitializer

W3CActivityExtensions.UpdateTelemetry is called from W3COperationCorrelationTelemetryInitializer.
This method is doing extra type casts (for every telemetry item) that I think are unnecessary.
I moved the if bracket to DependencyTelemetry and added a method to the abstract class OperationTelemetry

This is going to go away after we'll have W3C support in .NET platform, so unless it fixes some issue, I propose to keep it as is.
Also, it is now disabled by default.

@lmolkova Can you re-review this?
Most of the changes are to the UpdateTelemetry method which I see is referenced frequently in the WebSDK.

everything would be retired including the call from Web SDK


[Backport 2.x] Manual Backport of Dynamic tenancy configurations

Description
Manual Backport of Dynamic tenancy configurations to 2.x

Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
New feature

Issues Resolved

Relate https://github.com/opensearch-project/security/pull/2607
Cherry-picked from https://github.com/opensearch-project/security/pull/2693
Is this a backport? If so, please add backport PR # and/or commits #

Check List

[x] New functionality includes testing
[x] New functionality has been documented
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2696 (95b70e8) into 2.x (02633c5) will increase coverage by 0.07%.
The diff coverage is 76.13%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##                2.x    #2696      +/-   ##
============================================
+ Coverage     61.19%   61.27%   +0.07%
- Complexity     3259     3304      +45
============================================
  Files           259      268       +9
  Lines         18183    18335     +152
  Branches       3234     3242       +8
============================================
+ Hits          11127    11234     +107
- Misses         5488     5525      +37
- Partials       1568     1576       +8

Impacted Files
Coverage Δ

...earch/security/dlic/rest/api/MigrateApiAction.java
4.16% <0.00%> (ø)

...arch/security/securityconf/DynamicConfigModel.java
100.00% <ø> (ø)

...ch/security/securityconf/DynamicConfigModelV6.java
0.00% <0.00%> (ø)

...g/opensearch/security/support/ConfigConstants.java
94.44% <ø> (ø)

.../action/tenancy/TenancyConfigRetrieveResponse.java
54.16% <54.16%> (ø)

...ensearch/security/action/tenancy/EmptyRequest.java
60.00% <60.00%> (ø)

...ity/action/tenancy/TenancyConfigUpdateRequest.java
64.00% <64.00%> (ø)

...earch/security/privileges/PrivilegesEvaluator.java
72.95% <66.66%> (+0.57%)
:arrow_up:

...urity/action/tenancy/TenancyConfigRestHandler.java
77.77% <77.77%> (ø)

...search/security/securityconf/impl/v7/ConfigV7.java
74.55% <80.00%> (+0.61%)
:arrow_up:

... and 16 more

... and 7 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Not all NPM packages associated with builds as dependencies

Describe the bug
It appears that certain NPM packages are not being associated with the build when running jfrog rt npm-install --build-name=my-build --build-number=test
To Reproduce
Using the following package.json:
{
...
  "dependencies": {
    "@nguniversal/module-map-ngfactory-loader": "^8.2.6",
    "rxjs": "^6.6.7",
    "tslib": "^1.14.1",
    "zone.js": "^0.9.1"
  }

$ jfrog rt npm-install --build-name=my-build --build-number=test
...
[Debug] [Thread 2]  Fetching checksums for @nguniversal/module-map-ngfactory-loader : 8.2.6
[Debug] Searching Artifactory using AQL query:
items.find({"@npm.name":"@nguniversal/module-map-ngfactory-loader","@npm.version":"8.2.6"}).include("name","repo","path","actual_sha1","actual_md5")
[Debug] Sending HTTP POST request to: http://localhost:8082/artifactory/api/search/aql
[Debug] Artifactory response:  200 OK
[Debug] [Thread 2]  @nguniversal/module-map-ngfactory-loader : 8.2.6 could not be found in Artifactory.
[Debug] Saving data.
[Debug] Creating temp build file at: /tmp/jfrog/builds/UlRTTzItRGV2LU5pZ2h0bHlfdGVzdF8=/partials
[Warn] @nguniversal/module-map-ngfactory-loader:8.2.6
[Warn] The npm dependencies above could not be found in Artifactory and therefore are not included in the build-info.
Make sure the dependencies are available in Artifactory for this build.
Deleting the local cache will force populating Artifactory with these dependencies.
[Info] npm install finished successfully.

To resolve dependencies, the CLI is pointing to a virtual  Artifactory repository.
As shown above: The npm dependencies above could not be found in Artifactory and therefore are not included in the build-info. Make sure the dependencies are available in Artifactory for this build.
But the requested package physically exists in a local repository (which is aggregated to the corresponding virtual repo):

I have tried zapping or removing completely the cache, setting bypass HEAD request on the remote repo, running npm cache clear -f, but to no avail.
With further investigation, according to the AQL search above:
items.find({"@npm.name":"@nguniversal/module-map-ngfactory-loader","@npm.version":"8.2.6"}).include("name","repo","path","actual_sha1","actual_md5")
The CLI is looking for the artifact using its npm.name and npm.version properties. When looking into this artifact’s properties:

Because the version property appears to begin with a “v” prefix, AQL is unable to locate the corresponding artifact.
The issue was eventually resolved by manually removing the "v" from the property, and I was able to associate the specified artifact to the build using the CLI.
This is not exclusive to this specific package.
Expected behavior
The CLI should resolve version properties with prefixes
Versions

JFrog CLI version:  1.47.2
JFrog CLI operating system: Ubuntu 18.04
Artifactory Version: 7.17.5

Hi @vasily-sk
Thanks for reporting this issue!
This issue is resolved in the latest JFrog CLI 2.5.1. Feel free to upgrade.
We'd appreciate your feedback on that.


active storage support

thank you for this gem i am working with rails 5.2 and using active storage.
i am thinking of creating a gem for an active storage field as i was searching for such thing i stumbled upon this repo, currently viewing images work using this repo but other file types don't work.
if you are willing to add active storage support since it is in the stable branch of rails i am willing to contribute.
my suggestion is the following:

upload single file at first and then multiple files
adding image support through url_for to support 3rd party cloud storage.
use html 5 video element for video files
use html audio element for audio files
download link to other files

optional:

use preview variant for pdf and other office files with a download link

i am currently working on fixing this issue here contributors are welcome


In REPL, blank line twice cause overflow

Describe the bug?
Pressing enter twice causes overflow in REPL.
Reproducible code
Press enter twice in REPL
cargo run

Expected result
No overflow
>>>

>>>

>>>

Actual result
>>>

>>>
thread '<unnamed>' panicked at 'attempt to subtract with overflow', compiler\erg_compiler\codegen.rs:756:27
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Traceback (most recent call last):
thread '  File "<string>", line 18, in <module>
main' panicked at 'called `Result::unwrap()` on an `Err` value: Any { .. }', ConnectionAbortedError: [WinError 10053] 確立された接続がホ
スト コンピューターのソウトウェアによって中止されました。
src\main.rs:64:22
error: process didn't exit successfully: `target\debug\erg.exe` (exit code: 101)

Additional context
This is occurring in the following location.
https://github.com/erg-lang/erg/blob/998f267c6cfc404b89ca9fe5b45ec029afc5bed2/compiler/erg_compiler/codegen.rs#L755-L763
The following will prevent overflow, but is not a fundamental solution.
        let lasop_t_idx = self.cur_block_codeobj().code.len().saturating_sub(2);

If you run it in debug mode you will see this.
cargo rd
...
Disassembly of <code object <module> at 0xad171f9cb8, file "<stdin>", line 1>:
Name:              <module>
FileName:          <stdin>
Argument count:    0
Positional-only arguments: 0
Kw-only arguments: 0
Number of locals:  0
Stack size:        3
Flags:
Constants:
   0: Int(0)
   1: ["namedtuple"]
   2: ["path"]
   3: "\\?\C:\Users\username\.erg\lib\std"
   4: ["in_operator"]
   5: ["*"]
   6: None
Names:
   0: collections
   1: namedtuple
   2: ::#NamedTuple
   3: sys
   4: path
   5: ::#path
   6: append
   7: _erg_std_prelude
   8: in_operator
   9: ::#in_operator
lnotab: []
1:
              0 LOAD_CONST               0 (Int(0))
              2 LOAD_CONST               1 (["namedtuple"])
              4 IMPORT_NAME              0 (collections)
              6 IMPORT_FROM              1 (namedtuple)
              8 STORE_GLOBAL             2 (::#NamedTuple)
             10 POP_TOP
             12 LOAD_CONST               0 (Int(0))
             14 LOAD_CONST               2 (["path"])
             16 IMPORT_NAME              3 (sys)
             18 IMPORT_FROM              4 (path)
             20 STORE_GLOBAL             5 (::#path)
             22 POP_TOP
             24 LOAD_NAME                5 (::#path)
             26 LOAD_METHOD              6 (append)
             28 LOAD_CONST               3 ("\\?\C:\Users\username\.erg\lib\std")
             30 CALL_METHOD
             32 POP_TOP
             34 LOAD_CONST               0 (Int(0))
             36 LOAD_CONST               4 (["in_operator"])
             38 IMPORT_NAME              7 (_erg_std_prelude)
             40 IMPORT_FROM              8 (in_operator)
             42 STORE_GLOBAL             9 (::#in_operator)
             44 POP_TOP
             46 LOAD_CONST               0 (Int(0))
             48 LOAD_CONST               5 (["*"])
             50 IMPORT_NAME              7 (_erg_std_prelude)
             52 IMPORT_STAR
             54 LOAD_CONST               6 (None)
             56 RETURN_VALUE

[DEBUG] compiler\erg_compiler\compile.rs:0191: the compiling process has completed

Using saturating_sub(2) from earlier, it changes to this.
Disassembly of <code object <module> at 0xad171f9cb8, file "<stdin>", line 1>:
Name:              <module>
FileName:          <stdin>
Argument count:    0
Positional-only arguments: 0
Kw-only arguments: 0
Number of locals:  0
Stack size:        2
Flags:
Constants:
   0: None
lnotab: []
1:
              0 LOAD_CONST               0 (None)
              2 RETURN_VALUE

[DEBUG] compiler\erg_compiler\compile.rs:0191: the compiling process has completed

Erg version
Erg 0.5.11
Python version
python3.10.6
OS
Windows 10

if self.cur_block_codeobj().code.len() < 2 {
    return;
}
let lasop_t_idx = ...

is better.
Could you make a PR for this?


Fix DHCPv6 Status Code

Signed-off-by: Lehner Florian<EMAIL_ADDRESS>This PR fixes the issue mentioned in https://github.com/google/gopacket/issues/526

Thanks!


[testing, bug] allow for n_jobs support on methods without arguments

Description
Testing n_jobs support currently requires that the wrapped function take inputs. There are circumstances (in Incremental Algorithms) where onedal code may be called without an input to finalize a computation. Decorating these methods for n_jobs will lead to erroneous test failures.
Changes proposed in this pull request:

Add an inspect check on the method input, and branch test for methods which take args, and those that don't

/intelci: run

/intelci: run


Decouple GitClient and GitProviderClient; update GitFactory to support this

Issue #, if available:
https://github.com/aws/eks-anywhere/projects/9
Description of changes:
Last PR needed before we can start to incorporate the generic git provider flow into the FluxAddonClient. This decouples the responsibility for interacting with a hosted git provider API from the responsibility for interacting with a generic git repository on disk, and allows us to produce these clients based on the contents of the FluxConfig.

divide the responsibility of the GitProvider interface into a GitClient and a GitProviderClient interfaces. In the last pr, we split these up on the flux side; now, we're formally producing two different objects to use.
set up the gitFactory to return the three component parts needed by the fluxaddonclient: a GitClient a GitProviderClient, and a writer configured to write to the local git repository.
set up the gitFactory to build a provider based on the input flux config. only produces github for now, will add the generic provider case next.

next steps:

after https://github.com/aws/eks-anywhere/pull/1900 is merged, will update the FluxAddonClient to invoke FluxBootstrapGit if the Git provider is present
add a case which builds a generic git provider to the gitFactory.

Testing (if applicable):
create cluster
upgrade cluster
delete cluster
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


'Save screen grab' should suggest a filename

Suggest name of current document with '_screengrab' appended

Implemented for Windows and Linux. Qt does not allow this to be implemented for Mac.


Broken: TikTok download complete video gallery

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2022.05.18 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
US
Description
Up until last week I could use yt-dlp to download an entire User's TikTok video gallery. This no longer works.
All other capabilities including single files from the User's gallery (and other sites) works fine.
Verbose log
[debug] Command-line config: ['--verbose', '--config-location', 'G:\\00OSz\\12win10b zEnt-LTSC 1809 x64\\05Apps\\Multimedia\\Video\\Installed\\yt-dlp\\yt-dlp.conf', 'https://www.tiktok.com/@afrodita_22678']
[debug] | Config "G:\00OSz\12win10b zEnt-LTSC 1809 x64\05Apps\Multimedia\Video\Installed\yt-dlp\yt-dlp.conf": ['--ffmpeg-location', 'G:\\00OSz\\12win10b zEnt-LTSC 1809 x64\\05Apps\\Multimedia\\Video\\Installed\\ffmpeg\\bin\\ffmpeg.exe', '--audio-format', 'mp3', '--format', 'bestvideo[ext=mp4]+bestaudio[ext=m4a]/mp4', '--output', 'X:\\12X\\10Video\\Podcasts\\zzTikTok\\aaCompletes\\%(uploader)s\\%(uploader)s - %(view_count)s - %(title)s.%(ext)s']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.05.18 [b14d523] (win_exe)
[debug] Python version 3.8.10 (CPython 64bit) - Windows-10-10.0.17763-SP0
[debug] Checking exe version: "G:\00OSz\12win10b zEnt-LTSC 1809 x64\05Apps\Multimedia\Video\Installed\ffmpeg\bin\ffprobe" -bsfs
[debug] Checking exe version: "G:\00OSz\12win10b zEnt-LTSC 1809 x64\05Apps\Multimedia\Video\Installed\ffmpeg\bin\ffmpeg.exe" -bsfs
[debug] exe versions: ffmpeg 2022-01-06-git-2b541b8c1d-full_build-www.gyan.dev (setts), ffprobe 2022-01-06-git-2b541b8c1d-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.14.1, brotli-1.0.9, certifi-2021.10.08, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[debug] Proxy map: {}
[debug] [tiktok:user] Extracting URL: https://www.tiktok.com/@afrodita_22678
[tiktok:user] afrodita_22678: Downloading webpage
ERROR: [tiktok:user] afrodita_22678: Unable to download webpage: The read operation timed out (caused by timeout('The read operation timed out')); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "yt_dlp\extractor\common.py", line 642, in extract
  File "yt_dlp\extractor\tiktok.py", line 629, in _real_extract
  File "yt_dlp\extractor\common.py", line 933, in _download_webpage
  File "yt_dlp\extractor\common.py", line 801, in _download_webpage_handle
  File "yt_dlp\extractor\common.py", line 786, in _request_webpage

  File "yt_dlp\extractor\common.py", line 768, in _request_webpage
  File "yt_dlp\YoutubeDL.py", line 3596, in urlopen
  File "urllib\request.py", line 525, in open
  File "urllib\request.py", line 542, in _open
  File "urllib\request.py", line 502, in _call_chain
  File "yt_dlp\utils.py", line 1419, in https_open
  File "urllib\request.py", line 1358, in do_open
  File "http\client.py", line 1344, in getresponse
  File "http\client.py", line 307, in begin
  File "http\client.py", line 268, in _read_status
  File "socket.py", line 669, in readinto
  File "ssl.py", line 1241, in recv_into
  File "ssl.py", line 1099, in read
socket.timeout: The read operation timed out

This issue looks quite similar to #3776, I would check if that meets the description of your issue, and if so, keep your eye on that thread. Hope that helps.


Preprocessing EEGWindowsDataset

This PR:

Exposes the use_mne_epochs parameter of create_windows_from_events
warns when preprocessing an EEGWindowsDataset because the preprocessing steps will be applied on the raw data, not on epochs

Adding a use_mne_epochs  parameter to create_fixed_length_windows and create_windows_from_target_channels would be desirable but more complicated.
Closes #605

For me it's almost good @PierreGtch, just a few more tests to increase coverage and maybe a test for the function's behavior.

@bruAristimunha Done :)

Lgtm @PierreGtch, thank you for your contribution.


Save Theme in localStorage 💾

Save Theme in localStorage that the theme state is resisted over Site reloads.

don't forget to add ss in your pr with issue number


[SR-6981] @_implements doesn't work in extensions

Previous ID
SR-6981

Radar
None

Original Reporter
@xwu

Type
Bug

Additional Detail from JIRA

Votes
0

Component/s
Compiler

Labels
Bug

Assignee
None

Priority
Medium

md5: c2eb03bd88ab046fae58ebe4fa85ad8f

Issue Description:
PR #8735 adds supports for @_implements, which serves some niche but important purposes in the standard library.
Currently, we’re running into some potential source breakage with conditional conformances (for standard library types) for which @_implements would be perfect. However, it seems like this attribute simply doesn’t work inside extensions. By which I mean, the following compiles:
protocol P {
  func f(x:Int, y:Int) -> Int;
}

struct S : P {
  @_implements(P, f(x:y:))
  func g(x:Int, y:Int) -> Int {
    return 5
  }
}

…but adding the following doesn’t:
protocol Q {
  func f(x:Int, y:Int) -> Int;
}

extension S : Q { // Error: Type 'S' does not conform to protocol 'Q'
  @_implements(Q, f(x:y:))
  func h(x:Int, y:Int) -> Int {
    return 6
  }
}

This makes @_implements unusable for conditional conformances 🙁

Yes, this does appear to be resolved. Not sure what commit to attribute it to; it would be nice to know that there is a test to prevent regressions but as the feature has been used in more places I think it's fine to close out the PR.


CEC Single Diode model: gamma_r should be renamed gamma_pmp

The temperature coefficient of maximum power is currently titled "gamma_r" in the CEC model. This terminology does not appear to come from anything specific and is confusing, so we'd like to rename to gamma_pmp. The variable in pvsamv1 in SSC will also need to be renamed, which unfortunately could cause some backwards compatibility issues. This is likely a fairly low priority issue, however.

I agree, I'm trying to get a more uniform parameter labeling for all the CEC values. We have developed a more consistent scheme of parameters in the pv-terms project. The idea is to use a uniform parameter labeling as much as possible in the various pv analysis software packages.

Upon further investigation, the gamma_pmp value is an input to three compute modules:

6parsolve
pv6parmod
pvsamv1

However, it is only used in 6parsolve . Votes for removing it as an input from the other compute modules? I believe it could still live as a reference value in the GUI for the CEC library page, but I think it's confusing for it to be an input if it's not used.


Better document our BehaviorBase class with examples

We should differentiate how we differ from the Behavior class (should these be extensions in the future instead???), also provide more details on overrides and examples.

Thank you.