Add analyzer to analyze if vms have access to vsphere api server

Issue #, if available:
Description of changes:
To extent the functionality of support bundle by

adding a run-pod collector--vmsAccessCollector. It supposes to collect logs from vsphere cloud controller manager on control plane.

since the pod need to be deployed on control plane node, specific tolerations have been set.
It is also able to accept customized taints that given by user in cluster defination yaml.

adding a vmsAccess analyzer. Based on the log from the collector, the analyzer is able to analyze if the vms have access to vsphere api server.

Now, the analyzer starts to work from bootstrap cluster, although we expect that the analyzer only does its work on workload cluster. A clarification was temporarily added to the output to avoid confusion.

Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold

@YoyoTT can u please add PR description, also make it less generic of the PR title? Thanks!

/ok-to-test

/unhold


Add a member from IBM team

/cc @jinchihe , @jlewi , I wish to work as member is this great open repo.

This change is

Thanks @xauthulei
/assign @jlewi

/lgmt
/approve
Thanks @xauthulei After this PR is merged; please wait an hour for an invite to join the org. If you don't receive an invite after an hour please open an issue.

/lgtm

Thanks @jinchihe and @jlewi , now I have joined our org.


Simplify PushSource

Motivation
Currently implementing push source requires users implement an additional interface called setConsumer and then using that consumer in their loop. This pr just exposes a consume method from the pushSource abstract class that derived functions can make use of.
Modifications
Describe the modifications you've done.
Result
After your change, what will change.

@sijie @jerrypeng


Add username and password in 'Build and push' of configure-ci-cd.md

Proposed changes
I've added the username and password references in the 'Build and push' step of 'Set up the GitHub Actions workflow' in the Python language guide.
The 'CI to Docker Hub' action didn't  work for me without it.
The changes are inspired by 'GitHub Actions Tutorial - Basic Concepts and CI/CD Pipeline with Docker (YouTube)'
Unreleased project version (optional)

Related issues (optional)

Fixes parts of #13157 (description still not intuitively clear, but functionality is solved - as long as people understand what to do)

@crazy-max Could you PTAL?

Isn't that what the docker/login-action@v1 is for? 🤔 https://github.com/docker/docker.github.io/blame/d179ba05f96eb87f1924bc7d68622395ddd8b2f5/language/python/configure-ci-cd.md#L143-L147

It's done through the docker/login-action@v1 yes. username and password inputs don't exist in docker/build-push-action@v2.

@crazy-max
Thank you.
But can you then explain why the login seems to work with the changes I made but not with the original approach from the language guide?
I've described the Error in #13157 (below EDIT)

@Sammeeey

But can you then explain why the login seems to work with the changes I made but not with the original approach from the language guide?

I don't see how it could work. Do you have a link to your repo?

I don't see how it could work. Do you have a link to your repo?

Perhaps the repo is public, and removing the credentials from one step (therefore authentication not failing), and moving it to the other one (which ignores the username/password) makes it "work" because it's no longer authenticating, and just doing an anonymous pull?

Actually, that wouldn't work, because this is for pushing 🤔 ?

@Sammeeey

But can you then explain why the login seems to work with the changes I made but not with the original approach from the language guide?

I don't see how it could work. Do you have a link to your repo?

Yes, of course:
Here is the repo with the changes in the github_registry.yml

@Sammeeey Looking at your workflow you're using the login-action and Login succeeded with it:

Also as I said https://github.com/docker/docker.github.io/pull/13214#issuecomment-885530655,  username and password inputs don't exist in docker/build-push-action@v2 and it's clearly shown in the build output:

So I guess in the previous build that failed your credentials were incorrect.

@crazy-max
Okay, you are completely right - thank you!
I've removed the lines again and it works now.
I can't remember that I changed the credentials within the process before.
Hence this problem seems to be solved - since it's actually no problem.
However parts of the description in that part of the docs still seem not completely clear from my point of view.
Anyway they may not be meant to be discussed here - but rather in #13157

Thanks both, for getting to the root of this. Let me close this PR, and we can continue on https://github.com/docker/docker.github.io/issues/13157


feat: add erc-20 support to orderbook

Description
For #469
Work done so far:

Added initial setup for ERC-20 support.
Updated order and route types to support ERC-20.
Enhanced matching logic to handle new ERC-20 order types.
Added route checks for Limit orders and Market orders.

Work in progress

Creating matching logic dependent on required matching design

What type of PR is this? (check all applicable)

[x] 🍕 Feature (feat:)
[ ] 🐛 Bug Fix (fix:)
[ ] 📝 Documentation Update (docs:)
[ ] 🎨 Style (style:)
[ ] 🧑💻 Code Refactor (refactor:)
[ ] 🔥 Performance Improvements (perf:)
[ ] ✅ Test (test:)
[ ] 🤖 Build (build:)
[ ] 🔁 CI (ci:)
[ ] 📦 Chore (chore:)
[ ] ⏩ Revert (revert:)
[ ] 🚀 Breaking Changes (BREAKING CHANGE:)

Related Tickets & Documents

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 Documentation
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

PR Title and Description Guidelines:

Ensure your PR title follows semantic versioning standards. This helps automate releases and changelogs.
Use types like feat:, fix:, chore:, BREAKING CHANGE: etc. in your PR title.
Your PR title will be used as a commit message when merging. Make sure it adheres to Conventional Commits standards.

Closing Issues

@kwiss @ptisserand .
refactored code to use the existing design.


Lost connection to Web Socket: status: closing, will reconnect -- spamming logs

My hubitat sprinkler controller seems to be working fine, but every 30 minutes, all my zones report this in the log.  I have all logging turned off.  Not sure if this is normal behavior, and would like to have this silenced in the logs if it is normal, or help on resolving this if it isn't normal.

@apwelsh
You should be using https://github.com/dcmeglio/hubitat-orbitbhyve for Orbit-Hubitat integration, and if so, you need to move this issue to that repo.

The one I installed from Hubitat package manager does. It have a url,  it it has your name.  How do I know which one HPM installed?

I would remove the one that is currently installed in HE and start a new install with HPM using a keyword search of 'orbit' and look for the one by Dominick Meglio.

Oh, I think I misread your comment.  I read it as this integration on your site is available via HPM.  I will read out to the other developer. Thank you

No problem.  As I stated, my rough port from SmartThings to HE is not as robust or stable as the one that is currently in HPM that was based on my work but enhanced by Dominick.
Dominick did an outstanding job of adding Orbit command and control via HE's webhook integration.  So if you install that version via HPM, perhaps your log errors will be eliminated, if not and you have his port installed, then you can contact him via his GitHub or the HE community thread I listed above!


[examples] Add IterationStrategies to MultiDataLoader/Module

Stack from ghstack (oldest at bottom):

-> #94
#93

Introducing common.data.IterationStrategy interface and its implementations for 'constant', 'round_robin', 'random', 'size_proportional' and 'ratios'
For ratios we can specify probabilities per each datamodule, for that we need to keep name <-> dataloader => Changing specification of loaders not as a list but by dictionary.
Using OrderedDict to keep the insertion order for the round_robin iteration strategy. (Since python 3.7 default dictionaries are insertion ordered)
Testing:
Intruducing tests
test/common/data/test_multidata.py
test/common/data/test_iteration_strategies.py
cd examples
python -m unittest test/common/data/*.py

Differential Revision: D37188386

Codecov Report

:exclamation: No coverage uploaded for pull request base (gh/ivankobzarev/6/base@344a570). Click here to learn what that means.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             gh/ivankobzarev/6/base      #94   +/-   ##
=========================================================
  Coverage                          ?   89.08%
=========================================================
  Files                             ?       31
  Lines                             ?     1576
  Branches                          ?        0
=========================================================
  Hits                              ?     1404
  Misses                            ?      172
  Partials                          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344a570...bb58f7b. Read the comment docs.

@ivankobzarev has imported this pull request.  If you are a Facebook employee, you can view this diff on Phabricator.

@ivankobzarev has imported this pull request.  If you are a Facebook employee, you can view this diff on Phabricator.

@ivankobzarev has imported this pull request.  If you are a Facebook employee, you can view this diff on Phabricator.

@ivankobzarev has imported this pull request.  If you are a Facebook employee, you can view this diff on Phabricator.


corporate: Send a reminder email 2 months before the end date.

Commit 1: Set end_date for fixed-price plans.
Commit 2: Send a reminder email to<EMAIL_ADDRESS>2 months before the end_date.

We'll have to do a db migration to set the end_date of existing fixed-price plans. (I'll post in CZO & here)

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Updates in the recent push:

Addressed the review comments -- see respective comments
Added a prep commit (first commit) -- explanation in commit message.
Added a comment in the last commit to be explicit about what 62 means:

elif (
    plan.fixed_price is not None
    and not plan.reminder_to_review_plan_email_sent
    and plan.end_date is not None  # for mypy
+   # The max gap between two months is 62 days. (1 Jul - 1 Sep)
    and plan.end_date - plan.next_invoice_date <= timedelta(days=62)
):

Migration to run on cloud:

from corporate.models import CustomerPlan
from corporate.lib.stripe import add_months

fixed_price_plans = CustomerPlan.objects.filter(status=CustomerPlan.ACTIVE, fixed_price__isnull=False)
for plan in fixed_price_plans:
    assert plan.end_date is None
    assert plan.billing_cycle_anchor is not None
    plan.end_date = add_months(plan.billing_cycle_anchor, 12)
    plan.save(update_fields=["end_date"])

Updates in the recent push:

Addressed the review comment.
Added a migration file as discussed -- See 2nd commit.

Merged, since I'd like to be able to stack this with other work, but please consider https://github.com/zulip/zulip/pull/28934#discussion_r1498113277 as a potential follow-up.


Help with setup

Hello i've been trying all day to get this working for me and im still having a lot of problems figuring out what i need to do.  I hope its okay to ask for support here.
I installed the caddy 2 addon into home assistant and created the file /share/caddy/Caddyfile inside of that i added this where AAAA.com is the name of the domain name i purchased.
{
        email MyEmailAddress.com
}

homeassistant.AAAA.com {
    reverse_proxy localhost:8123    #HomeAssistant
}

plex.AAAA.com {
    reverse_proxy <IP_ADDRESS>:32400    #Plex
}

overseerr.AAAA.com {
    reverse_proxy <IP_ADDRESS>:5055    #Overseerr
}

sonarr.AAAA.com {
    reverse_proxy <IP_ADDRESS>:8989    #Sonarr
}

radarr.AAAA.com {
    reverse_proxy <IP_ADDRESS>:7878    #Radarr
}

lidarr.AAAA.com {
    reverse_proxy <IP_ADDRESS>:8686    #Lidarr
}

After that though i'm kinda confused on what to do there's the plugin configuration that i don't know what is supposed to go there. Does this even matter since i'm using the Caddyfile?
non_caddyfile_config:
  email: MyEmailAddress.com
  domain: AAAA.com
  destination: localhost
  port: 8123
args: []
env_vars: []
log_level: info

Next is my configuration.yaml for home assistant and im not sure what all needs to go here. With external_url do i need to put my duckdns url or my AAAA.com URL?
homeassistant:
  customize: !include customize.yaml
  external_url: https://AAAA.com
  internal_url: http://<IP_ADDRESS>:8123
  packages: !include_dir_named packages
  media_dirs:
    media: "/media"

http:
  use_x_forwarded_for: true
  trusted_proxies: <IP_ADDRESS>

After all of that what kind of changes need to be done with my domain provider? I purchased a cheap $1 domain through ionos.com. Do i need to do something with CNAME or subdomains?

Hello @ikrowni ,
Thanks for reaching out. Happy to help as good as possible.
First of all, your configuration looks good. There is nothing that seems wrong from a first view.
The only problem I could spot is your domain config at your domain provider.
Owning a domain is not enough. You will have to configure the domain provider in such a way that the domain provider can forward any requests from AAAA.com to your home.
In order to do so, configure the subdomains CNAME at your domain provider (ionos.com) like this:
homeassistant.AAAA.com -> yoursubdomain.duckdns.org (CNAME)
I assume your duckdns.org URL already works, and you have configured either your router or a service to update your IP at duckdns.org, so I won't explain this now.
There are better pages, like here: https://djajafer.medium.com/setting-up-duckdns-in-home-assistant-io-14c23316fcff
Please note that you won't have to follow the above instructions completely, as Caddy takes over all the certificate and proxy handling!
After setting up the CNAME, and waiting a bit, ensure that you have opened the necessary ports at your router (especially 443).
That's a rough guideline. I am happy to help further once you can access your home server via duckdns. :)
Let me know if above information helps, or where you get stuck.

Okay i think i got it in there correct. Am i supposed to add 1 for each service? I created one for plex to try out but will i also need to set another one for radarr, sonarr, etc?

My duckdns address has been working okay for the past couple of days. i can successfully navigate to home assistant.
I can see my home assistant when i enter in homeassistant.AAAA.com but it also says (Not Secure) next to the URL bar.
When i enter plex.AAAA.com it takes me to home assistant. I can't access plex or sonarr through duckdns address either.
does the url in external_url in configuration.yaml need to be https://homeassistant.AAAA.com or just https://homeassistant.AAAA.com

Am i supposed to add 1 for each service? I created one for plex to try out but will i also need to set another one for radarr, sonarr, etc?

Yes. At least, that's how I have setup my domain as well.

My duckdns address has been working okay for the past couple of days. i can successfully navigate to home assistant.

That's actually pretty cool, and simplifies the next steps, as there is some dependency.

When i enter plex.AAAA.com it takes me to home assistant. I can't access plex or sonarr through duckdns address either.

This sounds like a misconfiguration in your router. Please ensure that you forward the necessary ports from 80 to 80 and 443 to 443. In case you forward port 80 to 8123, please disable that forwarding!

does the url in external_url in configuration.yaml need to be https://homeassistant.AAAA.com or just https://AAAA.com

That would need to be https://homeassistant.AAAA.com

I can see my home assistant when i enter in homeassistant.AAAA.com but it also says (Not Secure) next to the URL bar.

It says "Not Secure", because it is not yet routed via Caddy. Sounds like the following route:
homeassistant.AAAA.com -> your.duckdns.org -> yourIP -> http://<IP_ADDRESS>:8123
Instead of, it should be the following:
homeassistant.AAAA.com -> your.duckdns.org -> yourIP -> http://<IP_ADDRESS> (assuming that you run the addon on the same host)
Also:
plex.AAAA.com -> your.duckdns.org -> yourIP -> http://<IP_ADDRESS>
I hope my explanations make sense. Please check your router. Sounds like you are close. :)

Huge progress being made i can access all of my media services now without issue. But after i switched the external_url from
  external_url: https://my.duckdns.org
to
  external_url: https://homeassistant.AAAA.com
I lost the ability to access home assistant by going to https://myduckdns.com all together and when i try to go to https://homeassistant.AAAA.com i get an error 400: Bad Request
But again all the other services are working as intended.


[OAP-CACHE] Decouple hearbeat message and use conf to determine whether to report locailty information

We are using external DB to store cache locality info, but the old OAP report mechanism still reports cache locality to the driver through RPC. Need to decouple this.
1:Using external DB => not report cache locality to the driver through RPC. But still, need to report cache metrics to the driver through RPC.
2:Using report mechanism =>follow current behavior.

As synced with Dingyu, this issue can be closed.


Some question about the data used in the data

Thank you for good work! I have some question about reproducing the work,
Dose the preprocessed eeg data ./Data/Things-EEG2/Preprocessed_data_250Hz/ is the [Preprocessed EEG data](https://osf.io/anp5v/) on the  paper [A large and rich EEG dataset for modeling human visual object recognition](https://www.sciencedirect.com/science/article/pii/S1053811922008758?via%3Dihub) 's OSF web: https://osf.io/3jk45/ ?
or you directly processing the data get from the web "Source EEG Data" or "Raw EEG Data"?

Hi, @ChiShengChen
I got the raw data and preprocessed it with some changes compared to the [Preprocessed EEG data]. You could refer to the preprocessing part of our code.

Hi, @ChiShengChen I got the raw data and preprocessed it with some changes compared to the [Preprocessed EEG data]. You could refer to the preprocessing part of our code.

Thanks for quick reply! It works well!


GitHub Actions with CLI

Improve documentation
Link
https://github.com/supabase/cli/tree/main/examples/tour
Describe the problem
No steps or docs on CI with CLI/migrations
Describe the improvement
I would like to add a section on how to setup GitHub to these docs
Hello,

I was wondering how I would make a CI flow with GitHub Actions.

The basic flow is the following:
(all after the installing, init, and start)
1. Local Changes to DB
2. Supabase CLI: supabase db commit <migration name>
3. Commit to source control (git)
4. Open a PR and reviewed
5. Once merged into the master/main branch, Github Actions runs a migration to Supabase project DB

I have come up with the following yml for the flow:

```yml
name: Migration for Prod DB

on:
  push:
    branches: [ master ]

jobs:
  changes:
    runs-on: ubuntu-latest
    outputs:
      migrations: ${{ steps.filter.outputs.migrations }}
    steps:
    - uses: dorny/paths-filter@v2
      id: filter
      with:
        filters: |
          migrations:
            - 'supabase/migrations/**'

  migration:
    needs: changes
    if: ${{ needs.changes.outputs.migrations == 'true' }}
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - name: Install Supabase CLI
        run: brew install supabase/tap/supabase
      - name: Set Remote DB
        shell: bash
        env:
          SUPABASE_PASSWORD: ${{ secrets.SUPABASE_PASSWORD }}
          SUPABASE_PROJECT_REF: ${{ secrets.SUPABASE_PROJECT_REF }}
        run: |
          supabase db remote set 'postgresql://postgres:"$SUPABASE_PASSWORD"@db."$SUPABASE_PROJECT_REF".supabase.co:5432/postgres'
      - name: Push Migrations
        run: supabase db push

Would this be the approach to take? If so, I will make a PR for it in the docs

Wow, this would be :100: @besteman!
Just a heads up: we'll be moving the tour (and other guides) to the Supabase Docs site, but you can place it here for now.

@soedirgo
Using the yml above, I got the following:

This is what I have in the supabase folder on master:
supabase.zip

@besteman I got the exact script of yours working on an empty project. The DX is now 💯!
My best guess is that you worked with the project beforehand? Did you try it with an empty project?

Can also confirm it works here, though I had to modify the yml a bit :+1:

We now have a GitHub Action app which documents how to setup Supabase CLI on your action runners. One benefit over brew install is that you can pin specific versions of the CLI for more reproducible builds.
Feel free to open new issues if you run into problems.
duplicates https://github.com/supabase/cli/issues/45


Investigate how to upload bench results to AWS

Motivation
GH has 90 days retention policy for all the artifacts. So the artifacts (bench-results.xml) that were created during benchmark workflow runs will be deleted after 90 days. This makes it difficult to maintain the bench_downloader script that generates the bench results website.
Let's investigate how difficult it is to upload benchmark results in the workflow run directly to AWS.
Issue created from comment:

Issues a warning if the user wants to download benchmarks that are expired according to the GH policy.

The default retention policy for all the artifacts is 90 days. Cannot be changed.

If we need to, it is rather straightforward to add a step to the benchmark job that not only uploads the results as a GH artifact, but also as a file to S3 - we already have/had such functionality. On S3 we can store the results indefinitely, if we want to.

Upload to S3 would be very nice, that would solve a lot of problems. Do you know how to do that? Or refer me to the point when we used to do that?

I've been writing this using the Github Actions a long time ago. I think we are still doing this, but I'm less familiar with the new Rust CI structure - I think https://github.com/enso-org/enso/blob/b8edf6a3582b35573dbd824ca04d21b39d4be910/build/build/src/aws.rs#L88-L123 may be a starting point but you may need to ask @mwu-tow for more details.
Originally posted by @radeusgd in https://github.com/enso-org/enso/issues/7599#issuecomment-1695381993

@PabloBuchu mentioned to me there is going to be a batch execution of Enso scripts including access to some DB in Enso Cloud. I'd be good to eat our own dog food.

@Akirathan I think this was covered by https://github.com/enso-org/enso/pull/9075?

@Akirathan I think this was covered by #9075?

@mwu-tow Yes, you are right. This issue is no longer relevant.


Use Slack invite link

See https://github.com/Qiskit/qiskit.org/issues/2863

Thanks for submitting the PR. This has been fixed in the https://github.com/Qiskit/qiskit_sphinx_theme/pull/68 that just got merged in to a feature branch. It may take a while to get deployed to the docs page though because we need to make first get the feature branch layout_refactor to merge into main, make a new release of the theme and rebuild the docs (which usually only happen when a new version of packages is released).
This is part of the reason we want to use the new unified menu web component in the docs. It will be faster to update and faster to deploy.

If this is urgent I think we can merge this one into the next release https://github.com/Qiskit/qiskit_sphinx_theme/pull/106 @1ucian0 What do you think?

It think it makes sense to merge it asap, indeed.

https://github.com/Qiskit/qiskit_sphinx_theme/pull/116 replaced the top menu and removed theme_variables.jinja. This should be fixed once we make a new release for the theme and when new docs are built for the individual docs projects.


Updating README to working dependency

Hi guys,
Is this PR going to be merged ? I've got the same issue, and beeing new to gradle I can't find a proper way to add the AAR dependency without beeing forced to save it into my soure code.
I've also tried to apply the commit https://github.com/cesine/pocketsphinx-android-demo/commit/f78626e9578e265e5623703539132565872855d5 on my gradle fine, but it seems gradle can't
Thanks !


Add support for Detection task type

Description
This PR adds the detection task type. This is mainly to support region-based models that produce bounding box predictions instead of / in addition to anomaly maps.
Changes
Major

Adds conversion utilities between masks and bounding boxes. This allows automatic generation of ground truth boxes for detection models. These utilities are also used to generate bounding box predictions when the model is of the segmentation type.
The detection task uses the thresholding and evaluation mechanisms from the segmentation task under the hood. This is achieved by converting the bounding boxes to segmentation masks or anomaly maps before evaluating the metrics.
Visualization functionality was added. This means that the predictions of any model capable of localization (segmentation or detection) can be visualized as detection predictions. For example, the following image was generated by passing detection as task type for a padim model training on MVTec bottle dataset:

Minor

Using enum instead of string to configure task type.
A new collate_fn function had to be implemented to allow collating the ground truth bounding boxes across batches.
connected component functions were moved to a separate module because these are used when converting boxes.

Known issues

No test cases
No inference support

Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which refactors the code base)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[x] My code follows the pre-commit style and check guidelines of this project.
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing tests pass locally with my changes

Using enum instead of string to configure task type.

I found a few str <--> enum conversion issues at some point when trying to use the cli with config files (somehow the string from the .yaml was not properly converted?).
So it made me wonder: are there tests covering this? (i.e. the different values of the enum work properly when being passed from the config file)

So it made me wonder: are there tests covering this? (i.e. the different values of the enum work properly when being passed from the config file)

I don't think the tests cover this explicitly at the moment. Which enum was causing problems at your end?

So it made me wonder: are there tests covering this? (i.e. the different values of the enum work properly when being passed from the config file)

I don't think the tests cover this explicitly at the moment. Which enum was causing problems at your end?

Honestly I don't remember because it was blocking me to use the new cli so I dropped the ball.
Anyway, just something to keep in mind : )

@ashwinvaidya17 @samet-akcay I've updated the PR based on your comments, and also added test cases and inference support. So it's ready for the next round of review.


Updated the path to the webpack vizualizer

Updated the path to the webpack vizualizer "./temp/stats/[solution-name].statshtml" instead of  "./dist/..."

Q
A

content fix?
yes

New article?
no

What's in this Pull Request?
Fixed outdated webpack vizualizer path

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

thx Yannick, appreciated.


Delete old combiner alerts

Only once old combiner is deprecated
Includes:

[ ]  alerts in Grafana (old combiner, monitor alerts)
[ ]  turn off old stackdriver alerting policies (mainnet, alfajores)

Moved to sprint backlog for now since this is on hold until we can actually delete the v1 endpoint


clang-format entire repo?

Would it be ok if I ran the roscpp style guideline-based clang-formater we use for MoveIt! on this repo also? I'm digging into the code and having a hard time not fixing all the inconsistencies I'm seeing.

I couldn't help myself... https://github.com/RethinkRobotics/baxter_simulator/pull/104

Resolved by #104


Broken links in README

I don't know if this is a known issue, but the link to the list of rules (https://stylecop.pdelvo.com/) in the main README file is broken at them moment. First, Chrome shows a NET::ERR_CERT_COMMON_NAME_INVALID error because the security certificate it's using is for a different domain (dfischer.xyz). And then, after clicking Proceed to stylecop.pdelvo.com (unsafe) it serves an 403 Forbidden page:

The "up-to-date source code" link is broken as well. It looks like the whole of pdelvo.com is down.

 Im currently working on my bachelor thesis which is now (mostly) done. Im now working on bringing these sites back up.

I fixed both websites

Thanks a lot!


A bit more space between buttons

I updated the margin on my css version but a bit more space between buttons would do good on SEO/mobile friendliness tests for tap targets for the small button size.
I think they recommend minimum 8 or 10 pixels space between buttons on mobile right?
I could be wrong, the issue might be the size of the buttons themselves but I like the small ones.
Love this tool btw!

Just edit the provided css or use your own classes.

Google's PageSpeed Insights recommends primary tap targets be at least 7mm x 7mm (approx. 48 css pixels), with 5mm space (32 css pixels) separating them from other tap targets.1. The buttons are currently 20px tall separated 16px.
@mrnagy88 this isn't going to impact SEO, at least with Google

Technically speaking, Google does not use the PageSpeed Insights tool to determine search engine ranking (but may do in the future).

but if we take their recommendation to heart it could be good to make the tap targets bigger and more spaced out on mobile with a @media query. The larger tap target could be a large visible button, or adding (transparent, clickable) padding to the links, or (my intuition is this would be best) a little of both. Submit a PR?
1 https://developers.google.com/speed/docs/insights/SizeTapTargetsAppropriately

I'm not sure but I got an error, I suspect it might be the little dashes that appear when you hover that is creating the error message then, or the way I had it set up on my page perhaps with other links nearby. Have you seen those hidden dashes?


Label color BLACK contrasts with Darkula theme

When a field gets in an error state, then on a good state, the label foreground colour is set to BLACK, which doesn't play nice with non-default themes.

Same thing happens for the Directory Name label. And we're possibly doing it elsewhere in the plugin.

Let's not change label styling to indicate a problem with a field.  I do like highlighting which field is causing problems, but I'm struggling to find examples in the IJ UIs that do this.


storm-1726: use Put#addColumn to replace the deprecated Put#add

Besides that, any plan to use Table to replace HTable, and use BufferMutation to cache ?

@lujinhong Can you file a jira to make the move. I think I have a patch lying around in my repo which brings some perf improvements in addition to moving the code to newer APIs.

https://issues.apache.org/jira/browse/STORM-1726?filter=12335179

+1
@Parth-Brahmbhatt Would you have a plan to submit your patch for the improvement?

@lujinhong Would you also craft pull request for 1.x-branch? I can also cherry-pick so please submit if you really don't mind.

@lujinhong Never mind. It would be better to cherry-pick since patch is really tiny.

cc. @ptgoetz @harshach Could you review this as well? Just want to check we're OK to drop support HBase 0.9x.


feat: dates before 2021

Prerequisites

[X] I have read the Contributing Guidelines.
[X] I agree to follow the Code of Conduct.
[X] I have searched for existing issues that already include this feature request, without success.

Describe the Feature Request
In the current version it's possible to select dates back to 2021.
The possibility to select dates in the years before 2021 would be great.
Describe the Use Case
Many milestones people would use the countup-function are many years ago. Best example is the birthday. Another example is the date of getting an important certificate (e.g. driving licence / work certificate)
Describe Preferred Solution
Possibility to select dates before 2021 in the existing menu.
Describe Alternatives

Related Code

Additional Information
No response

Thanks for your proposal! 👍
The restriction of the earliest date is set to avoid performance issues that may occur on low end devices. I think I will add a switch in settings which can loosen the years that can be chosen.


[owners] Update example owners file with owner modifiers

@rsimha is OOO for the next week, so for now I'm submitting so the documentation available to contributors is as up-to-date as possible. If you want more changes, I'll address them in a follow-up PR

Delayed LGTM. Thanks for working on this!


add unit tests for IsKubernetesVersionGe

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2936
Special notes for your reviewer:
If applicable:

[ ] documentation
[x] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@karataliu I added unit tests to validate that function does work for checking that 1.11.0-alpha.1 >= 1.6.0


Nominate @tiran for instructlab repo maintainers team

For details on how this process works, please see our contributor roles documentation
Which member are you nominating for a team change?

@tiran
Which team are you nominating for this member for?

instructlab/instructlab repository maintainers team (currently named cli-maintainers)
https://github.com/orgs/instructlab/teams/cli-maintainers
Make your case here: Why should the nominated member be on the proposed team?

@tiran has been deeply involved in the project for some time. He brings Python community expertise (as a Python core developer), and has done a lot of work for Linux training support, including support for various accelerators. For a full list of his PRs, see:
https://github.com/instructlab/instructlab/pulls?q=is%3Apr+author%3Atiran+
@nathan-weinberg has agreed to be the second sponsor of this nomination.

+1 for this nomination.

Thank you!


Using int as key fails

If your key is int or uint it fails in Put() with the following error binary.Write failed: binary.Write: invalid type int (https://play.golang.org/p/5U3qCrozRNJ) It is because encoding/binary is for fixed size data.

Fixed with commit 7c6a3dc6e9aef7b718382acdbadb86991ed77ab8. Thanks for reporting this 👍


Unable to create wlroots backend

Hi, I'm so keen to get cage working but am stuck at this error:
[jcake@jcake-edu cage]$ XDG_RUNTIME_DIR=/run/user/0 sudo -E ./build/cage obsidian
[sudo] password for jcake:
00:00:00.000 [backend/wayland/backend.c:592] Could not connect to remote display: No such file or directory
00:00:00.000 [../cage.c:299] Unable to create the wlroots backend

I'm trying to run obsidian on Cage. I've tried various combinations of search queries but haven't had much luck, but here's the gist of what I've tried:

I've installed all necessary dependencies: wlroots, xdgcommon and even one called wayland.
Built from source
Tried every combination of environment variable
screaming at my computer
changing OSes
stracing the cage process
installing obsidian from various sources

The error is referring to /run/user/1000/wayland-0 since that's what WAYLAND_DISPLAY is set to.
I'm hoping for a some insight into how I could debug this further.
Thanks

If WAYLAND_DISPLAY is set, wlroots will select the Wayland backend instead of DRM (so it will try to connect to a parent Wayland compositor and run cage in a nested window).
Note that it's not possible to start cage when another compositor is running. You need to start from a TTY.

Thanks for the speedy reply! I'm indeed running from a TTY, but even without the WAYLAND_DISPLAY environment variable I'm still getting an error, although a different one:
[jcake@jcake-edu cage]$ WLR_RENDERER_ALLOW_SOFTWARE=1 ./build/cage obsidian -- --enable-features=UseOzonePlatform --ozone-platform=wayland
00:00:00.001 [EGL] command: eglQueryDeviceStringEXT, error: EGL_BAD_PARAMETER (0x300c), message: "eglQueryDeviceStringEXT"
00:00:00.001 [EGL] command: eglQueryDeviceStringEXT, error: EGL_BAD_PARAMETER (0x300c), message: "eglQueryDeviceStringEXT"
pci id for fd 14: 1234:1111, driver (null)
MESA-LOADER: failed to open bochs-drm: /usr/lib/dri/bochs-drm_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)
pci id for fd 17: 1234:1111, driver (null)
MESA-LOADER: failed to open bochs-drm: /usr/lib/dri/bochs-drm_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)
00:00:00.044 [xwayland/server.c:454] Cannot find Xwayland binary "/usr/bin/Xwayland"
00:00:00.045 [../cage.c:515] Cannot create XWayland server
00:00:00.045 [../cage.c:548] Unable to open Wayland socket: Invalid argument

If it's at all possible to avoid Xwayland, that would be even better

"Unable to open Wayland socket: Invalid argument": this message is triggered by a misconfigured XDG_RUNTIME_DIR (probably cage cannot create a file in that dir).

I did run it previously with XDG_RUNTIME_DIR=/run/user/1000 but recall getting a similar error. I'll let you know when I'm back at my computer

Hi sorry for the non-response. I can confirm I get the same error

I am getting the same error and haven't quite figured it out yet. I have used cage on other systems just not my current pure Arch build so frankly, I assume I'm missing something somewhere.


Don't download Windows packages from GH release assets

https://github.com/ThePHPF/pie-design?tab=readme-ov-file#windows-binaries mentions that Windows packages should be downloaded from GH release assets. In my opinion, that is a bad idea for (a) security and (b) stability reasons.
Re (a): a malicious actor could register a useful extension via packagist, and then roll out Windows binaries as releases which may contain arbitrary malware (those binaries would not even need to be built from the GH repository sources). There is no way to verify the integrity of the binaries.
Re (b): even if we assume no malicious intententions, Windows binaries may be built against arbitrary dependendencies, and these may conflict with others. E.g. two different extensions might use the same dependency DLL and ship it; but the first one uses a newer version, and the second one an old version. The first one might rely on functions of the newer version, but if the second extension is installed after the first one, the DLL will be replaced, and the first extension will no longer work. Even if we assume that this won't happen, there may be subtle differences regarding the used Windows SDK etc.
I suggest to only download Windows binaries from PECL (i.e. from https://downloads.php.net/~windows/pecl/releases/). These are under the control of the PHP organization (particularly how they are built), and could be easily rebuilt in case of any conflicts (or withdrawn if need be).
cc @shivammathur

Firstly, thank you for your feedback, perhaps it could've come a little sooner though :) ... the design of PIE was discussed almost a year ago with public consultation, and the https://github.com/ThePHPF/pie-design repo has been worked on transparently and in public, with ample opportunity for much earlier feedback.
Both points (a) and (b), as far as I can tell, could equally apply to downloading from https://downloads.php.net/~windows/pecl/releases/ .
For example (a) less people have access, but that does not mean a bad actor could take advantage of a hypothetical vulnerability and place their own malicious binaries. This point also applies to any extension built from source, in practice, since (unfortunately) very few people using PECL (or PIE, eventually) will actually read the source before compiling anything.
(b) also applies because the extension binary is built against whatever libraries builds them... which may be different for each extension there. This issue doesn't seem any different when building for the official Windows binaries provided, versus any other way of providing binaries.
The recommended approach in PIE for building the Windows binaries is to use https://github.com/php/php-windows-builder ; which means the PHP organisation is already in control (as much as extension authors can opt in to using it) the stack on which extensions are built; but this gives extension authors the freedom to produce their own binaries, should they wish.
That said, there is scope in future for improvements, such as;

building Windows exts from source with PIE (in the same way as Linux exts are built from source)
uploading GH release assets to other repo hosts (such as Gitlab) etc.

I will move this into the PIE design repo.


Let AddURI() accept multiple uris and Fix MultiCall()

Make necessary changes where-ever required.

Please tag version info


Error in HA logs: play is not a function

Hi there, I'm using the latest version of the card (branch 4.1.0), and recently I noticed the following issue in my HA logs:
Logger: frontend.js.latest.202211080
Source: components/system_log/__init__.py:256
First occurred: 12:10:08 AM (6 occurrences)
Last logged: 9:51:15 AM

https://home.felipecrs.com/local/custom/frigate-hass-card/live-8d5f3a37.js:85:757 Uncaught TypeError: this._providerRef.value?.play is not a function
https://home.felipecrs.com/frontend_latest/core.0e377a7a.js:1:9578 Uncaught Error: Suspend promise not set

I didn't notice any side effect, but I suppose it's something to be aware of to be corrected when have time.

@felipecrs Have you seen this recently? If yes, would you mind syncing the 4.1 branch (which includes https://github.com/dermotduffy/frigate-hass-card/pull/953 ) and see if it makes any difference?

Actually I have not seen this since a long time. I'll close it, and if I notice something I get back.
Thanks!


feat(AztecMacro): Let function convey mutability

Currently it is not possible for a function to convey to other contracts, that it will not be manipulating state, e.g., that it should be called using a static_call.
It is currently the burden of the caller, to do a static_call when needed, instead of a call.
This means that for contract such as a token, other contracts that need to fetch a balance on that token, must explicitly use a static_call instead of having the interface it uses know that it should be static, if the contract was defined as
#[aztec(static)]
#[aztec(public)]
fn balance_of(owner: AztecAddress) -> U128;

Allowing this data to be easily conveyed makes it much less error prone to build on top, as it is now just required to remember the static at the interface, instead at every time you will make a call.
If a call is made to some user provided "token", and it is not static pain ensures as it could really be calling anything, and the control flow is passed on.

I think the name should align with whatever is used on AztecjS side

Nice. Would it be possible to limit static (contract) methods to only (external) call other static methods at compile time?

Nice. Would it be possible to limit static (contract) methods to only (external) call other static methods at compile time?

@fcarreiro it is very tricky to do at compile time since we don't have "storage modification opcodes", we just push stuff to the context inputs. However the way I've implemented it in #6338 only generates "Static" versions of the CallInterfaces for the functions that are marked as #[aztec(view)], so if users try to use the .call(&mut context) versions, they'll get a compile time error. Nothing prevents them from trying to do a low-level call, that will fail at runtime.


fixed file_browser extension

Ups sorry my bad. I went from top to bottom and just merged another PR that has done the same. I am so sorry

Hi @Conni2461 , could you check this PR?
I actually don't think the merged PR fixes the issue:
E5108: Error executing lua .../start/telescope.nvim/lua/telescope/_extensions/init.lua:10: 'file_browser' extension doesn't exist or isn't installed: m
odule 'telescope._extensions.file_browser' not found:
        no field package.preload['telescope._extensions.file_browser']
        no file './telescope/_extensions/file_browser.lua'
        no file '/usr/local/Cellar/luajit-openresty/2.1-20220310/share/luajit-2.1.0-beta3/telescope/_extensions/file_browser.lua'
        no file '/usr/local/share/lua/5.1/telescope/_extensions/file_browser.lua'
        no file '/usr/local/share/lua/5.1/telescope/_extensions/file_browser/init.lua'
        no file '/usr/local/Cellar/luajit-openresty/2.1-20220310/share/lua/5.1/telescope/_extensions/file_browser.lua'
        no file '/usr/local/Cellar/luajit-openresty/2.1-20220310/share/lua/5.1/telescope/_extensions/file_browser/init.lua'
        no file '/Users/ikerurda/.cache/nvim/packer_hererocks/2.1.0-beta3/share/lua/5.1/telescope/_extensions/file_browser.lua'
        no file '/Users/ikerurda/.cache/nvim/packer_hererocks/2.1.0-beta3/share/lua/5.1/telescope/_extensions/file_browser/init.lua'
        no file '/Users/ikerurda/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/luarocks/rocks-5.1/telescope/_extensions/file_browser.lua'
        no file '/Users/ikerurda/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/luarocks/rocks-5.1/telescope/_extensions/file_browser/init.lua'
        no file './telescope/_extensions/file_browser.so'
        no file '/usr/local/lib/lua/5.1/telescope/_extensions/file_browser.so'
        no file '/usr/local/Cellar/luajit-openresty/2.1-20220310/lib/lua/5.1/telescope/_extensions/file_browser.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
        no file '/Users/ikerurda/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/lua/5.1/telescope/_extensions/file_browser.so'
        no file './telescope.so'
        no file '/usr/local/lib/lua/5.1/telescope.so'
        no file '/usr/local/Cellar/luajit-openresty/2.1-20220310/lib/lua/5.1/telescope.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
        no file '/Users/ikerurda/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/lua/5.1/telescope.so'
stack traceback:
        [C]: in function 'error'
        .../start/telescope.nvim/lua/telescope/_extensions/init.lua:10: in function 'load_extension'
        .../start/telescope.nvim/lua/telescope/_extensions/init.lua:17: in function '__index'
        ...lescope-packer.nvim/lua/telescope/_extensions/packer.lua:108: in function 'key_func'
        ...k/packer/start/telescope.nvim/lua/telescope/mappings.lua:242: in function 'execute_keymap'
        [string ":lua"]:1: in main chunk

You right. I think i rebased your branch correctly and it should be fixed now. Can you validate after that i would merge. I dont use packer. I just look at these repos in the telescope org from time to time (because no one else currently does it)

Yes, this fixed the issue, thanks!


Tien/update video data

This PR adds:

The CVPR oral presentation.
Two new substitution scenes and results,

I found a text tag in the README.md which says "Everything Is AWESOME". I'm confused, what is that?

I tried some template to add Youtube video into markdown and forgot to change the tag.

on November 2022 -> in November 2022.

Done.


TargetProxy sslCertificates - KeyError

During elastic_load_balancer implementation it was discovered that the template does not support sslCertificates array (according to elastic_load_balancer.schema). Therefore separate implementation of all components has to be done (healthcheck, backend_service, url_map, target_proxy and forwarding_rule). There is a KeyError issue obtained during sslCertificates configuration of target_proxy. The template itself allows to provide sslCertificates in a format:
  ssl:
    sslCertificates:
        - <CERT1_URL>
        - <CERT2_URL>
        - <CERT3_URL>

but the error is obtained:
Manifest expansion encountered the following errors: Exception in target_proxy.py
Traceback (most recent call last):
return constructor[m](evaluation_context)
File "", line 160, in generate_config
File "", line 138, in get_https_proxy
File "", line 115, in get_secure_proxy
KeyError: 'certificate'
Please check if it's a bug. If it's not a bug please advise how to implement sslCertificates correctly.

I also found out the I cannot refer to url map resource in target proxy in target tag in $(out.<project>.<deployment>.<resource>.<output>) format. I can provide a direct url though. unfortunately it's not satisfactory since this dependency is required to make the whole deployment work.

Thank you for highlighting this!
The targetProcy template supports the sslCertificates url list:
target_proxy.py.schema#L92
However the External LoadBalancer schema  file does not allow this, which is clearly a bug, we will fix this shortly.
Let me look deeper into your other error.


Bootstrap with Laravel #6

Bootstrap with Laravel #6
It needs volume log review

FIX volumes
ignore log files


Test fastANI identity matrix - Issue 104

Would close #104.
Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)
[ ] This change requires a documentation update
[ ] This is a documentation update

Action Checklist

[x] Work on a single issue/concept (if there are multiple separate issues to address, please use a separate pull request for each)
[ ] Fork the pyani-plus repository under your own account (please allow write access for repository maintainers)
[x] Set up an appropriate development environment (please see CONTRIBUTING.md for this repository)
[x] Create a new branch with a short, descriptive name
[x] Work on this branch

[x] style guidelines have been followed (please see CONTRIBUTING.md for this repository)
[x] new code is commented, especially in hard-to-understand areas
[x] corresponding changes to documentation have been made
[x] tests for the change have been added that demonstrate the fix or feature works

[x] Test locally with pytest-plus -v non-passing code will not be merged
[x] Rebase against origin/master
[x] Check changes with linting/formatting tools before submission (please see CONTRIBUTING.md for this repository)
[x] Commit branch
[x] Submit pull request, describing the content and intent of the pull request
[x] Request a code review
[x] Continue the discussion at Pull requests section in the pyan-plus repository

My inclination here is to write a standalone script which parses the 9 sets of fastANI output into the various expected 3x3 matrices which we can check in as fixtures. i.e. Don't use pyANI v0.3 at all. It wouldn't be an independent implementation (if both written by me), but better than nothing as this script can then be used in future should we ever change the example sets.

The PR now tests the fastANI matrices produced via snakemake against fixtures generated by a standalone Python script without calling the unfinished method in pyANI v0.3 at all.
Currently it records an estimated alignment length. We could record None here, but that would mean a minor change to the DB ORM/schema. We could also report the number of orthologous matched fragments as the alignment length (not in base pairs like other methods).

I thought I found a way to silence Codacy's complaints about asserts in the test (adding a .bandit configuration file), and perhaps CodeFactor too. However, this failed. Even locally I could only get bandit 1.7.10 to read from an explicitly configuration file given at the command line (a possible regression).
For the record, bandit -c pyproject.toml ... worked nicely with this:
[tool.bandit]
# B324:hashlib - used for MD5 checksum
# B404:import_subprocess - unavoidable
skips = ["B324", "B404"]

[tool.bandit.assert_used]
# Skip B101 aka assert_used in our test files:
skips = ["*tests/*.py"]

In practice I think we get all the tests of interest via ruff anyway - see https://docs.astral.sh/ruff/rules/#flake8-bandit-s

I wasn't expecting a conflict, but have pulled out the ruff check change to #113 instead. I will rebase this once that's merged.

Rebased after #113 was merged, and updated to drop the # noqa: T201 bits on the print lines.

I'm going to rebase this for #114 (merged) and #116 (pending)...

Agreed to merge this after changing the estimated_aln_length as discussed above.


A lot of depreciations

the package doesn't install with npm because a lot of its dependencies are depreciated or moved to another address.
please address this issue asap
thanks.

@drchibs I'm sorry for late reply and couldn't take out my time to fix dependencies.
https://github.com/linkpreview/linkpreview/pull/16 Here's this PR should fix deprecations and warnings

Thank you @bring2dip
I'll check it out


Unable to Delete Application

Cannot delete an application.
jwaldrip at Jasons-MacBook-Pro in ~/dev/src/github.com/brandfolder/boulder (master)
$ deis apps:destroy

 !    WARNING: Potentially Destructive Action
 !          We should be ignoring missing key errors on app deletion.

We proposed that in an earlier bug but it was closed: https://github.com/deis/deis/pull/2865

After looking at #2685, I think it should be merged.  It's clearly an etcd issue, but it can also be triggered by out-of-band manipulation of the etcd keyspace -- something we shouldn't just barf on.  Not only would this resolve a 500 error users are clearly seeing in the wild, but it's also the right logic because the net effect of swallowing the KeyError is the same (no more key!).

@jwaldrip as a workaround, you should be able to etcdctl set /deis/domains/brandfolder-production then redo the apps:destroy.

@gabrtv I did etcdctl set /deis/domains/brandfolder-production foo re-ran the destroy and the error still occurred.


Migrate project from rnpm to react-native.config.js

Summary
Due to an update to the RN CLI we need to migrate from rnpm to react-native.config.js.
It gets rid of the following warning
warn The following packages use deprecated "rnpm" config that will stop working from next release:
  - react-native-google-signin: https://github.com/react-native-community/react-native-google-signin
Please notify their maintainers about it. You can find more details at https://github.com/react-native-community/cli/blob/master/docs/configuration.md#migration-guide.

+1

First, let me just say that the config option has been there for a long time and I'm not even sure if it needs to be there. Can someone verify if we need to include config for rn-cli?


Update the Dockerfile for .NET Core SDK 3.1.100

This seems to be the required version when using prepare-release.sh.

There also appears to be some linker issues /w some of the native bindings:
...Unable to load shared library 'git2-7ce88e6' or one of its dependencies. In order to help diagnose loading problems, consider setting the LD_DEBUG environment variable...

It seems moving this it 3.1.100-bionic gets rid of this. Would you like to use that Ubuntu image or set the envar. I can update this PR wither way.

Hmm, that's odd. If using bionic works, I'd go with that. Thanks! (I'm turning laptop off for now, but will be around tomorrow.)

Superceded by #4662.


Bounds from serde(default) are too aggressive

For example this struct:
#[derive(Deserialize)]
struct S<K, V> {
    #[serde(default)]
    map: HashMap<K, V>,
}

gives you:
impl<K, V> Deserialize for S<K, V>
    where K: Deserialize,
          V: Deserialize,
          K: Default,
          V: Default

Instead it should be:
impl<K, V> Deserialize for S<K, V>
    where K: Deserialize,
          V: Deserialize,
          HashMap<K, V>: Default

I did some research on this and found that the standard derivations (such as Clone, etc.) deliberately don't do this because it could expose a private item in the signature, or could leak details about a private field into the public signature. Would this be a sufficient workaround?
#[derive(Deserialize)]
struct S<K, V> {
    #[serde(default = "Default::default")]
    map: HashMap<K, V>,
}

Oh good call, I forgot about private types. We've had that problem in Serde before. I guess we'll stick to the workarounds - your approach with default = "Default::default" or with bound = "...".


Feature/notes endpoint tests

Description
The purpose of this PR is to fully validate and test notes API endpoint. To accomplish this object, the router, model, and middleware files are tested together using supertest and jest. For further detail tasks, please view the below treeelo link.
Feature/Notes Backend testing to confirm correct endpoint and middleware functionality and maintain standards in future edits
Video Link
https://www.loom.com/share/44e46edc9dd64b679c77d6981a56f5bc
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have removed unnecessary comments/console logs from my code
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings
[x] No duplicate code left within changed files
[x] Size of pull request kept to a minimum
[x] Pull request description clearly describes changes made & motivations for said changes

Looks good, I love seeing lots of commits!
too many commits?


Remove . from archive

Fixes #1112
none

Thanks ! can you fix the mac one too (few lines below/line 79)

done

/lgtm


Add all variants of the Roboto font as assets to Material Design apps

lgtm assuming that new fonts.zip has all the new fonts (i didn't check)

Changed the manifest to YAML and gated this behind a flag

LGTM

LGTM


cmake: sca: Add CodeChecker native support

Add CodeChecker as a static code analysis tool for zephyr.

Thanks @nordicjm for testing, fixed by using a different name for the output byproducts.

This is really awesome stuff. FWIW I gave this a huge shout-out in this week's Zephyr weekly update, and also recorded a demo video that showcases the CodeChecker server, which is very cool IMO (the tool, not my video ;-))
@pdgendt Please make sure to add an entry for this in the Release Notes!


[SPARK-15742][SQL] Reduce temp collections allocations in TreeNode transform methods

In Catalyst's TreeNode transform methods we end up calling productIterator.map(...).toArray in a number of places, which is slightly inefficient because it needs to allocate an ArrayBuilder and grow a temporary array. Since we already know the size of the final output (productArity), we can simply allocate an array up-front and use a while loop to consume the iterator and populate the array.
For most workloads, this performance difference is negligible but it does make a measurable difference in optimizer performance for queries that operate over very wide schemas (such as the benchmark queries in #13456).
Perf results (from #13456 benchmarks)
Before
Java HotSpot(TM) 64-Bit Server VM 1.8.0_66-b17 on Mac OS X 10.10.5
Intel(R) Core(TM) i7-4960HQ CPU @ 2.60GHz

parsing large select:                    Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------
1 select expressions                            19 /   22          0.0    19119858.0       1.0X
10 select expressions                           23 /   25          0.0    23208774.0       0.8X
100 select expressions                          55 /   73          0.0    54768402.0       0.3X
1000 select expressions                        229 /  259          0.0   228606373.0       0.1X
2500 select expressions                        530 /  554          0.0   529938178.0       0.0X

After
parsing large select:                    Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------
1 select expressions                            15 /   21          0.0    14978203.0       1.0X
10 select expressions                           22 /   27          0.0    22492262.0       0.7X
100 select expressions                          48 /   64          0.0    48449834.0       0.3X
1000 select expressions                        189 /  208          0.0   189346428.0       0.1X
2500 select expressions                        429 /  449          0.0   428943897.0       0.0X

Test build #59901 has started for PR 13484 at commit da79ec6.

LGTM
How big of a difference in the benchmarks?

About 20%, give or take.

Can you include some perf data in the description?

Updated.

Test build #59901 has finished for PR 13484 at commit da79ec6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59901/
Test PASSed.

Want to do more benchmarking to investigate something so don't merge yet.
On Thu, Jun 2, 2016 at 7:27 PM UCB AMPLab<EMAIL_ADDRESS>wrote:

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59901/
Test PASSed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/13484#issuecomment-223475688, or mute
the thread
https://github.com/notifications/unsubscribe/AADGPL8RubvbrRbIK6eH0tTW0I6_-jtdks5qH5D8gaJpZM4ItGFp
.

Test build #59946 has started for PR 13484 at commit b3e63bb.

LGTM too, probably this will be even more of a improvement once we get the other bottlenecks fixed

Test build #59946 has finished for PR 13484 at commit b3e63bb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59946/
Test PASSed.

LGTM2

Alright, I'm going to merge this into master and 2.0.


Rdd related helpers

adds sc: JavaSparkSession to KSparkSession
adds (Java)RDD.toDS() functions
includes tests

So, can I merge it? :) @asm0dey

You will hate me, @Jolanrensen, but I've added more comments :)

Alright, after this is done checking I'll merge it.


Improve functional test notifications

🗣 Description
This changes how notifications by email work when functional tests fail.  Instead of emailing the TCOs once per test plan failure, it now only emails once per product failure.  Additionally, it adds a link directly to the GitHub workflow job, making it easier for TCOs to review the failures.
💭 Motivation and context
The first goal is to reduce email fatigue.  The second goal is to make it easier for TCOs to find the problem.
Closes: #1365
🧪 Testing
Created a test workflow to identify how to create the URL and to send email only if one or more previous jobs failed.  Transferred this knowledge to the functional test workflow.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] PR targets the correct parent branch (e.g., main or release-name) for merge.
[x] Changes are limited to a single goal - eschew scope creep!

Almost.  I fixed a long-standing error in omit_policies.yaml where it had the wrong EOL marker.

[x] Changes are sized such that they do not touch excessive number of files.
[x] These code changes follow the ScubaGear content style guide.
[x] Related issues these changes resolve are linked preferably via closing keywords.
[x] All relevant type-of-change labels added.
[x] All relevant project fields are set.
[x] All relevant functional tests passed.
[x] All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

[x] PR passed smoke test check.
[x] Feature branch has been rebased against changes from parent branch, as needed
[x] Resolved all merge conflicts on branch
[x] Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

[ ] Feature branch deleted after merge to clean up repository.
[ ] Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@nanda-katikaneni


Optional markdown config

Hi!
Thanks a lot for the hardworking. I'm currently in the process of refactoring our company's shareable config to the new flat implementation and your repository has been really helpful.
While reading the code I noticed that in the src/presets.ts file, the markdown is imported and then spread inside the presetLangsExtensions array.
This array is itself spread into the basic array, but then you pass a param to your config as such markdown: enableMarkdown = true.
To my current understanding and knowledge, I believe this is currently having no impact since you're either using basic with the markdown or using basic with the markdown twice.

Fixed! Could you please try<EMAIL_ADDRESS>and test again?

looks good to me thanks!

If you don't mind me asking, I noticed some packages are wrapped in interopDefault() whereas others aren't, how do you know which one to wrap? do you explore the code to see how they are exported for each plugin/package?
I also see that you created a hasVue() util in src/env.ts
do you think it would be possible to do something like:
- if (enableVue) {
+ if (hasVue()) {
   configs.push(...vue)
 }

Good idea. Released as<EMAIL_ADDRESS>

For the first question, I just tried them one by one, until all worked well.


QuizDB API wrapper offline

having some problems with my personal server that's hosting my PHP wrapper for the bot, it's currently not function right now

What does the PHP wrapper do? Your comment says it bypasses Cross origin blocking. But couldn't you use it without the server by turning off the same origin policy on chrome?

I'm pretty sure it's a built in feature; to disable it, that has to be done from the server itself, which means i obviously wouldn't have access to Protobowls settings. That's why I wrote the wrapper.
Also, I've been lazy and haven't set up my server since it just crashed, I'll get it back up at some point

fixed, using a NodeJS wrapper now. the bot is now functional again


Wrong fio command breaks disk speed tests

I tried to run YABS on a system that I do not manage, and got the following output for the disk speed tests:
fio Disk Speed Tests (Mixed R/W 50/50):
---------------------------------
Block Size | 4k            (IOPS) | 64k           (IOPS)
  ------   | ---            ----  | ----           ----
Read       |                   () |                   ()
Write      |                   () |                   ()
Total      | 0.00 KB/s        (0) | 0.00 KB/s        (0)
           |                      |
Block Size | 512k          (IOPS) | 1m            (IOPS)
  ------   | ---            ----  | ----           ----
Read       |                   () |                   ()
Write      |                   () |                   ()
Total      | 0.00 KB/s        (0) | 0.00 KB/s        (0)

The culprit turns out to be a Python package called Fiona, which also has a fio command that has nothing to do with the one expected by the script:
https://github.com/Toblerity/Fiona/blob/master/docs/cli.rst
For this particular case, I think it would be useful to have a flag in YABS to force external binaries to be used even when local ones are detected.

Thanks for the bug report!

I think it would be useful to have a flag in YABS to force external binaries to be used even when local ones are detected.

Sounds like a good idea, I can add that in.

I've noticed that on some machines with low memory and an older version of fio (3.17) as supplied by the OS repos causes a fault which prevents the job from running.
I'd suggest, for repeatability and to avoid such issues, that YABS defaults to the provided binaries and only uses the OS binaries if requested.

In OSX, the problem is due to :

The image libaio is not supported

Some type the problem is due to the shared memory segment.

Fixed in 624e7e9
Added the -b option to allow users to specify that they wish to use the pre-compiled binaries in the repo rather than any locally installed packages.


[BUG] contract with borrowed items will not be prepared

Version & Platform

Version <IP_ADDRESS> (FS25 <IP_ADDRESS>)
SinglePlayer

Describe the bug
I try to accept a contract with borrowed items. The contract is then prepared but the preparation is not completed even after several minutes. It is then not possible to finish the contract or to accept any other contract because the field is not prepared.
The bug occures also when the only active mod is ContractBoost.
This error only occurs sometimes. Now this happens when I try to accept a plowing (Kubota M8-201, AGRO-MASZ POV 5 XL and TENWINKEL PAC-1000) or deadwood contract (John Deere 843L-II) in my attached savegame.
The only solution I found is to reload the savegame and accept the contract without borrowed items, deactivate ContractBoost or to manually edit and correct the missions.xml and vehicles.xml.
I have already observed this behavior in previous versions of this mod in single (Zilonka) and multiplayer (Riverband Springs).
To Reproduce

Start my savegame with only ContractBoost activated
Try to start the plowing or deadwood contract with borrowed items
See error in 'Active' tab ('Preparing contract ...')

Expected behavior
The contract should be prepared like other contracts with borrowed items.
Screenshots
If applicable, add screenshots to help explain your problem.

Log files
Attach your current log file here.
log.txt

savegame1.zip

@Brax-bit - thank you for the well written bug report! the inclusion of the savegame zip really helped and sped up the process for recreating this issue.
should be fixed in <IP_ADDRESS>


Video downloads are broken as of today?

Looks like instagram changed something.
edit: it appears that instagram reverted something, as it just werks again

It seems like the issue is back, as Instagram is having breaking changes.

Some videos are broken, others work, rather random indeed.

Thanks for your feedback.
I'm finding the new solution.

I also noticed that story images are sometimes not downloaded with the best resolution, the first one is from the download button, the second one from I get when using https://github.com/ehmorris/High-Resolution-Downloader-For-Instagram or jDownloader.

Thank you very much for looking into it! 🫠

I'm trying to figure a solution myself, but for some reason I can't figure out, the whole Instagram website is broken for me. Most of the time, a blank page would show up without any contents, unless the DevTools are opened.

Any progress on the issue?

I also noticed that story images are sometimes not downloaded with the best resolution, the first one is from the download button, the second one from I get when using https://github.com/ehmorris/High-Resolution-Downloader-For-Instagram or jDownloader.
Thank you very much for looking into it! 🫠

Care to share that photo's page in order to test it?

Just take any instagram story picture, the resolution difference compared to other download methods is consistently different (lower).
Random recent one that should work for the next 24 hours: https://www.instagram.com/stories/eileen_gu_/2857129420782403566/
Download button: 750x1333, 243kb
Other methods: 1170x2080, 488kb

This user script tries to get the original image from the srcset attribute first, then fallback to to the src attribute, if not available. src attribute seems to give the original image. Probably, at some point in the past, this wasn't the case.
Anyways, in the user script code, comment (add // at the start of the line) some lines in storyGetUrl function, to match the following
	function storyGetUrl(target, sectionNode) {
		let url = '';
		if (sectionNode.querySelector('video > source')) {
			url = sectionNode.querySelector('video > source').getAttribute('src');
		} else if (sectionNode.querySelector('img[decoding="sync"]')) {
			// let img = sectionNode.querySelector('img[decoding="sync"]');
			// url = img.srcset.split(/ \d+w/g)[0].trim(); // extract first src from srcset attr. of img
			// if (url.length > 0) {
			// 	return url;
			// }
			url = sectionNode.querySelector('img[decoding="sync"]').getAttribute('src');
		}
		return url;
	}

And see how the images compared to that extension's images, if they match, then it should be fixed.

I found that the media id is embedded in the post web page (i.e., https://instagram.com/p/XXX) html head. But I'm not sure if this method works in any environment.
I will release a beta version which uses the info api in the next few days.

That solves it then. I don't see why it wouldn't work anywhere.

I have updated the script which uses the Info API to fetch urls.
Please update the script and help to test the new method if you can.

The update changed nothing for me, some videos can't be downloaded (example: https://www.instagram.com/p/Ceq-PNxgRE5/ ), and story images are still grabbing a lower resolution (example: https://www.instagram.com/stories/anna__shcherbakova_/2858320975204717916/ - 1080x1919 instead of 1284x2282).

I found there is a bug in finding post id.
Could you replace line 397 (let match = link.match...) with let match = link.match(/^\/p\/([^/]+)\//); and try again?
Besides, this update(1.13) did not modify the Story part (maybe try to fix it in the next update).

With version 1.13.1 I can download all videos (or at least I tried 5 random ones and it worked every time), great!

Great. No issues in here.

I guess something must have changed, as most video downloads are broken again.
Example: https://www.instagram.com/p/Cex6Kw3FHNd/

Yes, there are some changes, but fortunately, not big changes.
I have updated the new script to fix it.
Please update and try again.

yeah video download on post and reels dont work for me

yeah video download on post and reels dont work for me

I'm also having the same issue now.

thas cool


My open letter

As I have no possibility to change anything on the website, I will post link to my open letter here. My open letter to the community of PhantomJS.
As I said on Skype yesterday @ariya - I have edited it.
Many thanks,

@NickolasBoyer: what are you confused with?

After a while, it is clear that @pixiuPL (=he) and I could not work together.
My side on the story:

He was never hampered to perform the usual tasks: committing code changes, triaging issues, reviewing and merging pull requests, and even making releases. Various access which he demanded was not a show-stopper, consequently I did not attend to that right away. I planned to address that at some point, just not right away (due to other life commitments).
Such unfulfilled demands were then blown up out of proportion, culminating in the open letter linked from the main landing page of phantomjs.org. From my perspective, this is passive aggressiveness. It indicated lack of trust and the ability to navigate and resolve conflicts, and it demonstrated a poor social skill, all of which are important (beyond just the technical prowess) in running a community project.

This is not my first rodeo in the open-source community nor my first time dealing with a team dysfunction.
As much as I tried to be as reasonable as possible, I do not believe that the situation sets a good precedent for any future healthy collaboration. Past great collaborators of this project, including @Vitallium who made an enormous, significant progress to PhantomJS for years and years, always put forth the great emphasis on helping each other, vs insisting on the claim of vanity, symbolic rights (repository transfer, forum admin, etc).
In all cases, considering our differences in the way we imagine the project must be handled, the case is solved amicably: I will archive this repository (#15344), he will continue working on a fork. I thank him for his contribution and wish him all the best.
Thank you for your understanding!

@ariya
As of my inability to lead:: please look at PR's. When I stepped in there was circa 50 of them; now there is none. What that suggests? That I have an ability to solve puzzles (oh yes, some of them were quite tricky)..... and I was serious about my contributions (I helped many users here as much as I could). But I have been blocked by lack of permissions you gave me (collaborator role is very limited in fact).  I have also mentioned that in Skype msgs as well as mails
I was never hampered to commit code changes? Seriously? Just look at commits list to find out how much code I commited, before trying to defame me!!
As of admin rights on forum.... I asked you for them, because I saw many spam posts across forums and I was not able to clean them as standard user. Thats it - nothing more...
You say you did not attend right away as you were busy with real-life.... OK I understand two, three days of latency, or even everything up-to-week isacceptable for me..... you say you wanted to give yourself time - OK, but you should have replied this, Instead there was no reply from you. And thats why I sent another Skype msg/mail.... I thought you miscathed it or sth alike......

@pixiuPL I'm not really a fan of using the Github issue system as social media or any other form of unnecessary discourse but I'll bite. I don't know anything about this situation but why is this necessary? This open letter seems almost solely aimed at portraying Ariya as a incompetent lazy lozer while facilitating your own ego trip, "it just needs good, devoted leader." what even is this, we're not building a sandcastle in 4th grade. Again don't know much about this situation but a bit more professionalism and tact would be nice.

@NickolasBoyer Im tactful, but (with all respect I have for Ariya) I think he is misunderstanding sth greatly here. As he said above:: we have two different conceptions of how we would go with PJS, thats it.....
And he started to defame me, its not professional nor tactful

PhantomJS is the reason I got into open-source in 2015. At that time I think Vitaly is maintaining the project. What Ariya created is so ahead of its time that so many years on, huge numbers of production systems are still running PJS scripts / code.
What I really really like about PJS is you just unzip and run, all dependencies are packaged into the binaries. When this monolithic effort is no longer maintainable by Vitaly, imagine how many people (including me), are pleasantly surprised when Pixiu started committing code intensively.
It looks like a resolution has been reached, and both gentlemen have my deep respect - the level of intensity simply shows how much they care about PhantomJS project!

@pixiuPL
I think you misunderstood what he wrote.
The word 'hamper' means restrict, so "never hampered" means "never restricted". He was saying that you were always able to "perform the usual tasks: committing code changes, triaging issues, reviewing and merging pull requests, and even making releases". He was not saying you failed to do those things.

@pixiuPL you joined github december 2017. Haven't done much in the open source world either. No one can find your profile in the internet. You have no right to make such accusation, have respect towards original creator. And please earn your respect first before making a rant like this.

Not to add additional banter here but I find it funny that you (@pixiuPL) added this commit.  Yet you would open an issue with this kind of language.
I would consider the way you communicate to the OSS community as it goes a long way.

This kind of things should be done in private @pixiuPL . Can't just bash people for being unresponsive, they have their own life too. If you can't continue maintaining the project, just apologize to the community and provides some positive feedback, no need to bash @ariya for not giving you power. I hope we all learn something from this issue.

@pixiuPL Oh, get off your high horse..  you just joined, clearly you are toxic to the community, and now you are demanding things? Looking at your "Open Letter" you close with:

Stay tuned for more....

You are just looking for attention to to start drama.. give it a break.  This type of actions should not be welcome in any time of open source community.

This letter is a shame. Sorry but such tone is unacceptable in general between human beings. @ahinkle post shows it's not the first time.. I understand why you're not getting the ownership. A pity for the project though.

@ariya Are you abandoning this project just because of @pixiuPL or is there any personal reason as well? Asking this cause if it is because of him, then you should just ignore/ditch him and continue your good work with the project.
Not all people in the open source community might be like him and you may find someone better if you stick to the project or reach out by may be posting in repos like this: https://github.com/pickhardt/maintainers-wanted
All the best.

 Przynosisz wstyd narodowi swoim spierdoleniem umyslowym. Twoje commity sa bezuzyteczne insprowadzaja sie do dodawania spacji/ spierdalania kodu pseudofaktoringiem. Usun konto gita i przestan sie osmieszac.

Along what @interatir said - @pixiuPL I wish that PL in your username wasn't an indication of my home country, cose you're a disgrace, politely put.

@ariya, as @tvvignesh put it, please do not archive this project just because of a random contributor's mental meltdown. Given its popularity, I am sure it is possible for phantomjs to find a new team of core contributors if you can't take it anymore.
Props to you for staying exceptionally professional despite the situation. You have the support of the OSS community! :ok_hand:

Hi everyone,
Instead of starting a flamewar against @pixiuPL , it would be a lot more productive to just report him for breaching the terms of service of GitHub, most notably:

harass, abuse, threaten, or incite violence towards any individual or group, including GitHub employees, officers, and agents, or other GitHub Users;

violate the privacy of any third party, such as by posting another person's personal information without consent.

Instead of taunting him, we should just collectively make sure he can never harrass open source contributors from now on.

 I hope that github will ban him.

@ariya please don't close this project i'm not good open source contributors but please don't close phantomJS just because this. please

Well, Pixel seems like he thinks a couple of months of removing carriage returns makes him lead developer.
This should have been resolved with a swift removal of rights, let him vent all over reddit, he'll just be roundly mocked.
Part and parcel of internet comms in OSS though. Attract all sorts.

come at the king you best not miss

Well we've reached the point in the drama where people are talking like Omar from "The Wire," so thanks everyone.

Well, there vanishes my hope of seeing PhantomJS coming back to life with full steam ahead. A sincere thanks to all that are involved in the project, and hopefully we'll see positive development soon.

I think there is an important lesson to be learnt here for open source projects and communities, that commit rights to the repo should not be given to people without any prior record of contribution. I mean I still do not understand how someone making a PR like this (https://github.com/twigphp/Twig/pull/2607) did manage to get contributor access to the repo. It shows what havoc a person in the hunt of building github stats can create at the cost of something valued by many.

@pixiuPL you joined github december 2017. Haven't done much in the open source world either. No one can find your profile in the internet. You have no right to make such accusation, have respect towards original creator. And please earn your respect first before making a rant like this.

@pixiuPL's commit 66102e5326244c12b08dc4c573d47184ac100e6b shows the committer email as nwolfe[ā]aptrinsic.com (see .patch).
His previous account seems to be @nwolfe-xx. For some reason he is not being as impolite on that account.
Quite interesting, he opened #13772, was asked to make changes and then merged the PR with his second account – without the changes he was asked for. (63cd19ad2c2760616f7742fca94b1b5dad3e0892 was also authored by @nwolfe-xx but commited by @pixiuPL)

@jomo I would disagree, this seems to be a forgotten commit from 2015 that was merged this january.
The commit 66102e5 you are referencing is a merge commit, made by pixi, with the changes from nwolfe.
Apart from that, I would suggest to not try doxxing pixiuPL, event though it is just digging for other online identities.
It's none of our business and it doesn't help in this situation. Just imaginge you are wrong and nwolfe-xx has nothing to do with this, it still will show up in his history and may look shady to people looking him up.

@3stadt I agree, also if you look at the commit quality, its quite questionable that it is the same person.

Report this guy, useless commit!

@3stadt you're right, I was a little confused by how GitHub displays these things.

@jomo: sorry for being so quiet on this, had no idea that my PR from 2015 was involved in this flame war.  It looks to me like pixiuPL merged it since I never responded to the requests for changes (various excuses for that...) . I used that original code change at my last job, it did exactly what we needed it to do, but if it's not needed by the community, I'm fine with that.

How did this guy become a collaborator in the first place? Almost all of his commits are either simplest changes (removing random empty lines WTF?) or bad merges, and then fixes for his bad merges. Just… wow. I'd say @ariya asked for this by granting this moron the write access to such an important repository.

I think "such an important repository" might be overstating the case a little, given the rapid decline in popularity of PhantomJS thanks to chrome-headless, jest, enzyme and recent evolutions in frontend testing.

AFAIK, PhantomJS is the one to start and inspire the rest, which sounds pretty important to me, but this is off-topic anyway.

Selenium might have that distinction

Hello any plans phantomjs support async/await. Please.

@revmischa you are right, most new stuff is/should be developed using headless chrome and the like, however A LOT of old projects like screenshot tools, ssl checks etc. are still done using old phantomjs implementations, so its still an important repository.
https://www.npmjs.com/package/phanton
Stats
5.339 downloads in the last day
26.717 downloads in the last week
146.731 downloads in the last month

Second what you said @MichaelErmer - this is the other PJS package by Medium
https://www.npmjs.com/package/phantomjs-prebuilt
Stats
106,885 downloads in the last day
595,314 downloads in the last week
2,470,571 downloads in the last month

@nwolfe-xx all good! Please ignore my original comment, I was mistaken and have already deleted it.

@kid-icarus Try to follow #15342 instead. While at it, please also read #14541.

I'd say @ariya asked for this by granting this moron the write access to such an important repository.

@phanan It doesn't mean that I didn't learn my lesson, but remember: hindsight is 20/20.

@ariya I think you should to reset the master branch to an earlier release as it and its commit history seems to be entirely broken, just look at stuff like this:
https://github.com/ariya/phantomjs/commits/master/src/config.cpp
https://github.com/ariya/phantomjs/commit/a242fb8d605d9aa4afe5bf8d1267c1ded15f157c#diff-498d06653ad4a59db94a430cfa6f3937
https://github.com/ariya/phantomjs/pull/15347

@MichaelErmer Already planned, please follow #15344.

@dabrowt1 Check ##15344 (releases are removed, master branch will be reverted).

@ariya Close this thread dude. Or wait, never mind. I will grab a popcorn.

The resolution has been reached. I'm closing this issue for now. Thanks everyone for your help!


Collision with sensors

Hi, i am trying to make collision with two sensors. When two sensors collision, i will print console "on".
I did something. But it says "on" in every collision with any item.
I just want with 2 sensors.
world.on("pre-solve", function(contact, oldManifold) {
    var manifold = contact.getManifold();

    var fixtureA = contact.getFixtureA();
    var fixtureB = contact.getFixtureB();

    var sensor = fixtureA.getBody();
    var infectedsensor = fixtureB.getBody();

    var sensorData = sensor.getUserData();
    var infectedsensorData = infectedsensor.getUserData();

    if (sensor && sensorData) {
      console.log("on");
    }
    else {
      console.log("off");
    }
  });

My sensors :
var a = world.createBody({
    type: "dynamic",
    angularDamping: 3.0,
    linearDamping: 4.0,
    position: Vec2(0.0, 10.0),
    angle: Math.PI,
    allowSleep: false
  });

var box = pl.Box(0.5, 0.5);

  var boxfix = a.createFixture(box, 2.0);

  sensor = a.createFixture({
    shape: pl.Circle(Vec2(0.0, 0.0), 2.0),
    isSensor: true
  });

  sensor1 = a.createFixture({
    shape: pl.Circle(Vec2(0.0, 0.0), 5.0),
    isSensor: true
  });

So far I've gotten around it by using a non-sensor body and in the 'pre-contact' event handler, doing
contact.setEnabled(false)
This makes the body not cause physical collisions so it acts similar to a sensor. If you find something else out I'd love to hear it though.

Contacts between sensors are not resolved, API doc for pre-solve already says that "Note: this is not called for sensors.". However, begin-contact is called for sensors, so you could use it.
Also in the code provided above both fixtures are added to the same body, and fixtures in the same body do not collide.
Here is the working code for listening to contacts between two sensor: https://piqnt.com/space/v0Tza2NVz


Android-native build broken...

After updating Kha I get this message in Android studio:

khacpp\src\hx\AndroidCompat.cpp:15:5: error: redefinition of 'rand'
Android/sdk/ndk-bundle/platforms/android-15/arch-arm/usr/include\stdlib.h:118:23: note: previous definition is here
  static __inline__ int rand(void) {

And the same for srand and atof.
This was added to HXCPP to fix problem when compiling with latest sdk targeting old phones. Detailed explanation of the problem can be found here https://code.google.com/p/android/issues/detail?id=73725
But I do not think we need to go that deep to fix the problem.
I'm not quite sure, but should not HXCPP_ANDROID_PLATFORM and SYS_ANDROID_API be the same? Now in kha korefile we have
project.addDefine('SYS_ANDROID_API=15');
project.addDefine('HXCPP_ANDROID_PLATFORM=23');

Which is strange: we are targeting android-15, but make hxcpp think we are targeting android-23.
Ok, I've changed HXCPP_ANDROID_PLATFORM to 15 and tried to compile.

Now I get this message:

Kha\Kore\Sources\Kore\Network\Socket.cpp:113:74: error: no member named 'S_un' in 'in_addr'

Which is because in_addr have different formats on different platforms and AFAIK S_un is available only on Windows.
After commenting this out I was able to compile my test project.

I believe it's very good idea to have some automated tests can check if empty project generated with 'kha --init' compiles and runs on all platforms or at least on some platforms...

It's a random error, haha.
Yes, we need more automated tests (currently Windows, macOS and Linux is compiled/checked for every commit).


更新TeaDSL描述文件:

更新python版本至1.3.4: 修改sql的kvpair默认分隔符为';'
更新golang版本至1.3.4: 修改sql的kvpair默认分隔符为';'

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Textfield - Update label position when value is added in an empty textfield

Related issue:
https://github.com/material-components/material-components-web/issues/822

Thanks for filling the issue, the fix will be integrated after the next mdc-web release.

Great! Will be looking forward to the next release. Thanks :)


KSF-82 Version set to Maintenace release 1.3.3

@ikulikov @rasendubi  Review please.

LGTM

(nitpick) squash your commits.
LGTM


Quick fix

rename Preset/doppler_8b_384_28.json -> Preset/doppler_8b_384_27.json
and rename nb_image_buffer_ var to buffer_part_count_

In phantom.ini there is a NbImagesPerBuffer = 8


feat: Refine headers and block channel size

Fix may address #369 but extra tests are required. It helped for my case.
Also, I've added some headers for CORS. Opened to discussion
I'm not sure every header is needed but all headers I have taken from kubo.

@ppodolsky could you make this green please? would love to get this in

@ppodolsky could you make this green please? would love to get this in

Done


Banded lights

There is a problem with rendering on the Oculus Quest 2 (standalone mode) using OpenXR GLES2, but not with Oculus VR Mobile GLES2.
The screenshots below of a scene with many spotlights illustrate this quite well.

First image is OVRM runtime

Second image is OpenXR runtime

Third image is the scene in the editor for reference

The root problem here that we've been trying to solve is that OpenXR requires us to render in linear color space while using an RGBA8 buffer, this looses too much color definition as it is converted (back to) sRGB color space for display inside of the headset, this is especially noticeable with darker colors.
For the Oculus mobile plugin everything is retained in sRGB mode and there is no color conversion that looses color definition.
Now there are sRGB color format buffers that supposedly fix this, and indeed with those we render properly when using SteamVR, but they do not seem to work on the Oculus hardware. I think this is because we are using GLES2 (as opposed to OpenGL 3 on desktop) not supporting these color formats properly.
I'm currently investigating if we can use RGB10A2 buffers so we can retain the color definition but so far it does not seem to work.

On a side node, Meta did add an extension in where you supposedly can specify the color format the color buffer is in, and supposedly we should be able to tell the runtime that we are offering it an sRGB buffer. So far though this does not seem to work. Hopefully we can get some feedback from Meta engineers on this. @m4gr3d ?

Nothing comes to mind yet, but I'll reach out and see if this is a known issue.

@m4gr3d it's really interesting because to me it makes no sense to use an 8bit per color channel format like RGBA8, to store colors in linear color space as it just doesn't have the precision. Its a bit of a weird choice on the part of OpenXR so I'm pretty sure we're missing a piece of the puzzle if everyone else uses this successfully.

Please test but I think #148 will fix this. Note that there are changes to the first person controller script that relate to the fix.

Banding and coloring issue should now be fixed through 148. There will always be some degradation in quality on mobile and GLES2 due to vertex shading being used. If there are still issues with the 1.2.0 release of the plugin, please open a new issue with screenshots of what is not working properly yet.


Tabs Component

I am trying to create a raw tabs component and for some reason, tab is not getting recognized by the browser.

In my stylesheets, I copied over the same exact styles as what is on react-toolbox's tab component source code just so I can see it working before adding my own.
In my inspect element:

I have no idea why Tab is not running and why my screen is blank!
Any suggestions will help :D thanks in advance.
BTW I am new to React so I'm sorry if there is an obvious solution.

I don't think you need two 'Tabs' components. It should be more like:
<Tabs ...>
    <Tab>
        {'Tab 1'}
    </Tab>
    <Tab>
        {'Tab  2'}
    </Tab>
</Tabs>