[SPARK-32890][SQL] Pass all sql/hive module UTs in Scala 2.13

What changes were proposed in this pull request?
This pr fix failed cases in sql hive module in Scala 2.13 as follow:

HiveSchemaInferenceSuite (1 FAILED -> PASS)
HiveSparkSubmitSuite (1 FAILED-> PASS)
StatisticsSuite (1 FAILED-> PASS)
HiveDDLSuite (1 FAILED-> PASS)

After this patch all test passed in sql hive module in Scala 2.13.
Why are the changes needed?
We need to support a Scala 2.13 build.
Does this PR introduce any user-facing change?
No
How was this patch tested?

Scala 2.12: Pass the Jenkins or GitHub Action

Scala 2.13: All tests passed.

Do the following:
dev/change-scala-version.sh 2.13
mvn clean install -DskipTests -pl sql/hive -am -Pscala-2.13 -Phive
mvn clean test -pl sql/hive -Pscala-2.13 -Phive

Before
Tests: succeeded 3662, failed 4, canceled 0, ignored 601, pending 0
*** 4 TESTS FAILED ***

After
Tests: succeeded 3666, failed 0, canceled 0, ignored 601, pending 0
All tests passed.

Test build #128712 has started for PR 29760 at commit f0d5880.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33336/
Test PASSed.

cc @srowen , this pr fix all failed test cases in sql/hive module. In this patch add test-2.13.jar to /Users/yangjie/SourceCode/git/spark-mine/sql/hive/src/test/resources/regression-test-SPARK-8489 path, the test-2.13.jar not a copy of test-2.12.jar, I try to generate test-2.13 as https://github.com/apache/spark/pull/22308 but failed because there is no spark 3.1.0-SNAPSHOT in maven repository, and I generate it as follow:

create a test module in spark source
copy Main.scala and MyCoolClass.scala to src/main/scala dir of test module
create a pom.xml use spark base pom.xml  as parent pom and add dependency

    <dependency>
      <groupId>org.apache.spark</groupId>
      <artifactId>spark-sql_${scala.binary.version}</artifactId>
      <version>${project.version}</version>
    </dependency>

mvn build test module with -am and rename original-test-2.13-3.1.0-SNAPSHOT.jar to test-2.13.jar

Jenkins test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33337/
Test PASSed.

Test build #128713 has started for PR 29760 at commit f0d5880.

Test build #128712 has finished for PR 29760 at commit f0d5880.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128712/
Test PASSed.

Test build #128713 has finished for PR 29760 at commit f0d5880.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128713/
Test PASSed.

Test build #128732 has started for PR 29760 at commit ce5c81b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33356/
Test PASSed.

Test build #128732 has finished for PR 29760 at commit ce5c81b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128732/
Test PASSed.

Merged to master


Could not find package sky_engine in the Flutter SDK (MacOS)

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
(Only on MacOS)

Install Flutter Master
Create New Project
Run Pub Get

Actual results
Hello,
For about a week, I can no longer use flutter on my macos runner. I have this error that keeps coming back.
Because every version of flutter from sdk depends on sky_engine from sdk which doesn't exist (could not find package sky_engine in the Flutter SDK), flutter from sdk is forbidden.
So, because jeemate depends on flutter from sdk, version solving failed.

For information this is only produced on macOS.
I tried flutter clean, reinstall flutter. So I come to you for some help.
Logs

Logs
flutter --verbose create foo

Flutter Doctor output

Doctor output

[✓] Flutter (Channel master, 3.11.0-10.0.pre.44, on macOS 13.4 22F66 darwin-x64, locale en-US)
    • Flutter version 3.11.0-10.0.pre.44 on channel master at /Volumes/SSD/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ab573048e7 (9 hours ago), 2023-05-20 11:32:26 -0400
    • Engine revision aac0919568
    • Dart version 3.1.0 (build 3.1.0-129.0.dev)
    • DevTools version 2.23.1

[!] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/thibaut.trarbach/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.1

[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] Connected device (1 available)
    • macOS (desktop) • macos • darwin-x64 • macOS 13.4 22F66 darwin-x64

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

The error you mentioned typically occurs when there is a problem with the Flutter SDK installation or when the dependencies within your project are not properly resolved.
Here are a few suggestions you can try to resolve the issue:
Verify Flutter SDK installation: Double-check that the Flutter SDK is installed correctly on your macOS runner. Ensure that you have downloaded the correct version of the SDK and that it is properly set up in your system's environment variables.
Update Flutter SDK: Make sure you have the latest version of the Flutter SDK installed. Run the following command in your terminal:
flutter upgrade
This command will update Flutter to the latest stable version.
Clear Flutter cache: Try clearing the Flutter cache to ensure that there are no corrupted or outdated files causing conflicts. Run the following command in your terminal:
flutter clean
This command will delete the build and cache directories.
Delete and reinstall dependencies: If the issue persists, you can try deleting the pubspec.lock file in your project's root directory and then running flutter pub get to reinstall the dependencies:
rm pubspec.lock
flutter pub get
This will force Flutter to resolve and reinstall the dependencies for your project.
Check for Flutter doctor output: Run flutter doctor in your terminal and check the output for any warnings or errors. The doctor command will help identify any issues with your Flutter installation or missing dependencies.
If there are any warnings or errors reported by the flutter doctor command, follow the provided instructions to resolve them.
Verify Flutter environment variables: Confirm that the necessary environment variables for Flutter are properly set up on your macOS runner. Specifically, check that the flutter command is accessible from your terminal and that the necessary paths are correctly configured.
Firewall or antivirus software: Sometimes, firewall or antivirus software can interfere with Flutter SDK's functionality. Temporarily disable any firewall or antivirus software on your macOS runner and check if the issue persists.
If none of these solutions resolve the problem, I recommend reaching out to the Flutter community for further assistance. The Flutter community is active and supportive, and you can find help on various forums, chat groups, or GitHub repositories dedicated to Flutter.
I hope one of these suggestions helps you resolve the issue and get back to using Flutter on your macOS runner.

Hello,
The error you mentioned typically occurs when there is a problem with the Flutter SDK installation or when the dependencies within your project are not properly resolved.

On this part, I can tell you that it does not come from my project. Because it happens even when you create a new project. And as for the flutter installation, I did it twice. It works with a master build from 2 weeks ago, but never with the latest ones
Verify Flutter SDK installation: Double-check that the Flutter SDK is installed correctly on your macOS runner. Ensure that you have downloaded the correct version of the SDK and that it is properly set up in your system's environment variables.

This has been done twice. And I think the variables are ok since it works on earlier versions of flutter master
Update Flutter SDK: Make sure you have the latest version of the Flutter SDK installed. Run the following command in your terminal:
flutter upgrade
This command will update Flutter to the latest stable version.

This order is made every day since I have the problem. I remember however that I am not in stable, but in branch master
Clear Flutter cache: Try clearing the Flutter cache to ensure that there are no corrupted or outdated files causing conflicts. Run the following command in your terminal:
flutter clean
This command will delete the build and cache directories.

I just did the test, it doesn't change the problem.
Delete and reinstall dependencies: If the issue persists, you can try deleting the pubspec.lock file in your project's root directory and then running flutter pub get to reinstall the dependencies:
rm pubspec.lock
flutter pub get
This will force Flutter to resolve and reinstall the dependencies for your project.

I want to do it, but it doesn't change much on existing projects and on brand new ones this command is not possible before the error
Check for Flutter doctor output: Run flutter doctor in your terminal and check the output for any warnings or errors. The doctor command will help identify any issues with your Flutter installation or missing dependencies.

If there are any warnings or errors reported by the flutter doctor command, follow the provided instructions to resolve them.

I provided you with the flutter doctor, for me it does not indicate a problem. But maybe on your side you have seen one?
Verify Flutter environment variables: Confirm that the necessary environment variables for Flutter are properly set up on your macOS runner. Specifically, check that the flutter command is accessible from your terminal and that the necessary paths are correctly configured.

On this part, yes it is accessible from everywhere. Which makes me wonder if you have read and looked at my first post. Or a lot of his answers were already in the information
Firewall or antivirus software: Sometimes, firewall or antivirus software can interfere with Flutter SDK's functionality. Temporarily disable any firewall or antivirus software on your macOS runner and check if the issue persists.

The machine is devoid of its 2 things during my test. So it can't come from there either
If none of these solutions resolve the problem, I recommend reaching out to the Flutter community for further assistance. The Flutter community is active and supportive, and you can find help on various forums, chat groups, or GitHub repositories dedicated to Flutter.

That's exactly why I created an issue here, to get help from the flutter community
Sincerely, Thibaut

@christopherfujino - not sure if we need help from the pub team to do this, but it seems like we should have a better error message if the Flutter installation is corrupt/invalid...

Hello,
By dint of doing tests, when I do a pub get I have in the new version of flutter the following error:
Rename failed: OS Error: Cross-device link, errno=18
Could this have caused the error in my ticket?
If so, any idea how to fix this? I tried to clean all the files in the location indicated by the logs, but that did not change much
Thanks in advance
Thibaut
[        ] executing: [/Volumes/SSD/flutter/] git ls-remote --get-url origin
[  +75 ms] Exit code 0 from: git ls-remote --get-url origin
[   +3 ms] https://github.com/flutter/flutter.git
[ +545 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[  +10 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +1 ms] Artifact Instance of 'LegacyCanvasKitRemover' is not required, skipping update.
[  +78 ms] Downloading package sky_engine...
[+1139 ms] Content https://storage.googleapis.com/flutter_infra_release/flutter/e04c14786d5a16467bb5d5fca8a1555bd9080df8/sky_engine.zip md5 hash: Ahfieens9bhLF8ZXqfQZSg==
[+1447 ms] Downloading package sky_engine... (completed in 2,493ms)
[  +32 ms] executing: unzip -o -q /Volumes/SSD/flutter/bin/cache/downloads/storage.googleapis.com/flutter_infra_release/flutter/e04c14786d5a16467bb5d5fca8a1555bd9080df8/sky_engine.zip -d
/var/folders/dw/9zk9tp0j0f91xwtn_t4r6bpc0000gn/T/flutter_tools.ywX3to/flutter_sky_engine.zip.xnTYiC
[ +252 ms] Exit code 0 from: unzip -o -q /Volumes/SSD/flutter/bin/cache/downloads/storage.googleapis.com/flutter_infra_release/flutter/e04c14786d5a16467bb5d5fca8a1555bd9080df8/sky_engine.zip -d
/var/folders/dw/9zk9tp0j0f91xwtn_t4r6bpc0000gn/T/flutter_tools.ywX3to/flutter_sky_engine.zip.xnTYiC
[  +22 ms] Rename failed: OS Error: Cross-device link, errno = 18
[  +49 ms] Downloading flutter_patched_sdk tools...
[  +87 ms] Content https://storage.googleapis.com/flutter_infra_release/flutter/e04c14786d5a16467bb5d5fca8a1555bd9080df8/flutter_patched_sdk.zip md5 hash: XwALij7bilSwQo9mZKMk6w==
[+1845 ms] Downloading flutter_patched_sdk tools... (completed in 1,931ms)
[  +10 ms] executing: unzip -o -q /Volumes/SSD/flutter/bin/cache/downloads/storage.googleapis.com/flutter_infra_release/flutter/e04c14786d5a16467bb5d5fca8a1555bd9080df8/flutter_patched_sdk.zip -d
/var/folders/dw/9zk9tp0j0f91xwtn_t4r6bpc0000gn/T/flutter_tools.ywX3to/flutter_flutter_patched_sdk.zip.GoLZXQ
[ +195 ms] Exit code 0 from: unzip -o -q /Volumes/SSD/flutter/bin/cache/downloads/storage.googleapis.com/flutter_infra_release/flutter/e04c14786d5a16467bb5d5fca8a1555bd9080df8/flutter_patched_sdk.zip -d
/var/folders/dw/9zk9tp0j0f91xwtn_t4r6bpc0000gn/T/flutter_tools.ywX3to/flutter_flutter_patched_sdk.zip.GoLZXQ
[  +89 ms] Rename failed: OS Error: Cross-device link, errno = 18
[  +39 ms] Downloading flutter_patched_sdk_product tools...
[  +74 ms] Content https://storage.googleapis.com/flutter_infra_release/flutter/e04c14786d5a16467bb5d5fca8a1555bd9080df8/flutter_patched_sdk_product.zip md5 hash: ZZg/6Y0yYbEvYENMGGb4Ig==
[+1839 ms] Downloading flutter_patched_sdk_product tools... (completed in 1,911ms)
[   +3 ms] executing: unzip -o -q /Volumes/SSD/flutter/bin/cache/downloads/storage.googleapis.com/flutter_infra_release/flutter/e04c14786d5a16467bb5d5fca8a1555bd9080df8/flutter_patched_sdk_product.zip -d
/var/folders/dw/9zk9tp0j0f91xwtn_t4r6bpc0000gn/T/flutter_tools.ywX3to/flutter_flutter_patched_sdk_product.zip.OctYnr
[ +129 ms] Exit code 0 from: unzip -o -q /Volumes/SSD/flutter/bin/cache/downloads/storage.googleapis.com/flutter_infra_release/flutter/e04c14786d5a16467bb5d5fca8a1555bd9080df8/flutter_patched_sdk_product.zip -d
/var/folders/dw/9zk9tp0j0f91xwtn_t4r6bpc0000gn/T/flutter_tools.ywX3to/flutter_flutter_patched_sdk_product.zip.OctYnr
[   +7 ms] Rename failed: OS Error: Cross-device link, errno = 18
[  +32 ms] Downloading darwin-x64 tools...
[ +127 ms] Content https://storage.googleapis.com/flutter_infra_release/flutter/e04c14786d5a16467bb5d5fca8a1555bd9080df8/darwin-x64/artifacts.zip md5 hash: nXzO+MJFaATJjbTme/6zWw==
[+10182 ms] Downloading darwin-x64 tools... (completed in 10.3s)
[   +3 ms] executing: unzip -o -q /Volumes/SSD/flutter/bin/cache/downloads/storage.googleapis.com/flutter_infra_release/flutter/e04c14786d5a16467bb5d5fca8a1555bd9080df8/darwin-x64/artifacts.zip -d
/var/folders/dw/9zk9tp0j0f91xwtn_t4r6bpc0000gn/T/flutter_tools.ywX3to/flutter_artifacts.zip.hdYXZX
[+1470 ms] Exit code 0 from: unzip -o -q /Volumes/SSD/flutter/bin/cache/downloads/storage.googleapis.com/flutter_infra_release/flutter/e04c14786d5a16467bb5d5fca8a1555bd9080df8/darwin-x64/artifacts.zip -d
/var/folders/dw/9zk9tp0j0f91xwtn_t4r6bpc0000gn/T/flutter_tools.ywX3to/flutter_artifacts.zip.hdYXZX
[  +15 ms] Cannot rename file to '/Volumes/SSD/flutter/bin/cache/artifacts/engine/darwin-x64/LICENSE.impellerc.md': OS Error: Cross-device link, errno = 18
[ +245 ms] executing: unzip -o -q /Volumes/SSD/flutter/bin/cache/artifacts/engine/darwin-x64/FlutterMacOS.framework.zip -d
/var/folders/dw/9zk9tp0j0f91xwtn_t4r6bpc0000gn/T/flutter_tools.ywX3to/flutter_FlutterMacOS.framework.zip.B6P1nQ
[ +691 ms] Exit code 0 from: unzip -o -q /Volumes/SSD/flutter/bin/cache/artifacts/engine/darwin-x64/FlutterMacOS.framework.zip -d
/var/folders/dw/9zk9tp0j0f91xwtn_t4r6bpc0000gn/T/flutter_tools.ywX3to/flutter_FlutterMacOS.framework.zip.B6P1nQ
[  +11 ms] Cannot rename link '/var/folders/dw/9zk9tp0j0f91xwtn_t4r6bpc0000gn/T/flutter_tools.ywX3to/flutter_FlutterMacOS.framework.zip.B6P1nQ/Resources' to
'/Volumes/SSD/flutter/bin/cache/artifacts/engine/darwin-x64/FlutterMacOS.framework/Resources': OS Error: Cross-device link, errno = 18
[  +20 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.

Interesting!
Sounds like the tool is picking a temp directory that is on a different partition from your intended installation directory. Does that sound plausible to you?

Specficially, where is your /var/folders/dw mounted? I'm assuming it is a different partition than /Volumes/SSD.
You can probably work around this by doing something like
mkdir /Volumes/SSD/tmp
TMPDIR=/Volumes/SSD/tmp flutter precache

Hello, As you think, yes, the SSD volume is indeed a second 1TB disk which contains all the data related to our project.
It is permanently mounted, since flutter itself is installed on this disk.
However your command seems to unlock the problem. Any idea why this behavior change?
And above all, why does this happen when the version of flutter changes?
The answer that I'm a black cat is allowed :)
Cordially
Thibaut

There was a regression in unzipping remote artifacts on macos that could lead to this behavior. Specifically the regression is that we will now quietly swallow FileSystemExceptions while unzipping artifacts, cc @vashworth

@ThibautTrarbach I wonder if this https://github.com/flutter/flutter/pull/127417 will give an earlier, more descriptive error.

ahh, yeah copy + delete seems safe?

Hello,
Following your feedback, I confirm that if it's on the same file system it's ok, but if it hits on different systems, it doesn't work anymore :)
If you need to test the copy + delete function, tell me how to do it and I will test it for you :)

I think the other questions are answered, but my work around helped because it told the flutter process (and subprocesses forked from it) to use a temporary directory on the same partition as the destination directory.
I'm a little curious if this is a dart:io bug - I can't remember what posix has to say about using renaming APIs across partitions or whether dart:io should be using a different one...

Hello @dnfield,
Yes that fixed it, but it's a temporary workaround.
So I left it open to find a more perennial solution. Unless you tell me that it will be the official workaroud :)

Just want to add one more data point: I am having the same issue when working on flutter master branch (doing this PR https://github.com/flutter/flutter/pull/127456)
/Volumes/MyExternal/ExternalRefCode/flutter/bin/flutter test test/painting/image_provider_network_image_test.dart
Downloading package sky_engine...                                  405ms
Downloading flutter_patched_sdk tools...                           926ms
Downloading flutter_patched_sdk_product tools...                   319ms
Downloading darwin-x64 tools...                                  2,635ms
Downloading darwin-x64/font-subset tools...                      2,036ms
Resolving dependencies...
Because flutter depends on sky_engine from sdk which doesn't exist (could not find package sky_engine in the Flutter SDK),
  version solving failed.


RxPaparazzo duplicate images when it selects from gallery

Hi guys,
I would like to know why paparazzo is creating new images when I select images from the gallery. Check the last question to find the stackoverflow's link to see the update. I uploaded a video that shows the duplication.
Thank for fixing the other issue so fast.

Hi @igiagante!,
I think it should be the right behaviour. Anyway take a look to this issue where I explain how the library works and how to deal with duplicate images.


[FIX] Update labeler.yml - change trigger to pull_request_target

The trigger pull_request can at most get read permissions from forks, thus PRs do not get labelled.
Using pull_request_target fixes it.

@ivonasto Thank you very much.


Missing RAID arrays

Hi, I have a RAID0 array that I wanted to use for my tmp folder.  However, ChiaPlotter is not seeing any RAID arrays.  I tried to check the code and potentially in function Get-ChiaMaxParallelCount when you use MSFT_Disk or MSFT_PhysicalDisk, those are unfortunately only returning physical drives, but not RAID arrays.  I tried to check MSoft docs for Get-CimInstance, but it looks like there is no way to query for RAID arrays, or most likely I missed it.
I did some searching, and one option would be to use MSFT_Volume (with Get-CimInstance), but that one doesn't indicate RAID type, just basic drive info.
Another option would be to use diskpart, and check for type (maybe NOT "Partition", or rather for exact type - in my case "Stripe" / RAID0).  Here is a link to a PS script that could be used to jump start this part: https://gist.github.com/schakko/4713248
Sorry, this is the first time I see PS code, so this is where my understanding ends.
As mentioned, this is the first time I am using PS, but your utility is a fantastic tool!

Hello
Switch in  Basic and write directly the path

Thank you @Sky1414.  I did that, and got "Exception calling ".ctor" with "1" arguments(s): ..." error message.  So, for whatever reason this is also no go for me.
I did try to rebuild the RAID array to use basic disks, but there was no option to do that.  The dynamic is selected by default, and looks like there is no way to change it (using Computer Management / Disk Management).
I also tried to use Storage Spaces, but that didn't work at all.  I couldn't create a pool, as selected NVMes were "not connected right" whatever it is.
So, at the moment, I cannot use Chia Plotter on that box (i9-10900, MSI Z490A Pro, Samsung 970 1TB NVMes).  Hopefully, the code can be modified to also recognize RAID arrays.
Thank you, Jacek

I did map that RAID0 array, and looks like that works.  It shows in "Plotting and Farming Drives" as well as I could start a job using it.
Also, the info provided by "Get-CimInstance -ClassName Win32_MappedLogicalDisk" is about the same as the one given by diskpart (from the link in the first post) - although it has both size and free space, where diskpart only provides the size.
I also tried to use \host\path format on the "Basic" section of directories, but ChiaPlotter is crashing with it.


Be explicit to work around K8S capability validation bug

Please provide a description of this PR:
We currently set allowPrivilegeEscalation: false in the ztunnel daemonset.
K8S docs state:

allowPrivilegeEscalation: Controls whether a process can gain more privileges than its parent process. This bool directly controls whether the no_new_privs flag gets set on the container process. allowPrivilegeEscalation is always true when the container:
is run as privileged, or
has CAP_SYS_ADMIN

Ztunnel sets privileged: false but does grant itself CAP_SYS_ADMIN - which means our manifest is lying, or the kube docs are.
This appears to be because there is an open K8S validation bug - their validator checks for CAP_SYS_ADMIN but not SYS_ADMIN -> they are exactly the same capability, so this is just a bug.
When that bug is fixed our manifest will start to fail k8s securityContext validation, so we should just fix it now so the manifest represents reality and is explicit about the actual real-world perms.

@bleggett: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2afbc86d1d691417f968b5b5e58bc061e2e0b83b
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/test release-notes

@bleggett: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
c85e6477e341f2b7ae94f0cdd20709bdcebb12e7
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


Missing certain sortablejs options in sortablejs-options.ts intrface

Hey,
I am trying to use preventOnFilter option of sortablejs and just figured out that this is missing in the sortablejs-options.ts interface (https://github.com/SortableJS/angular-sortablejs/blob/master/src/sortablejs-options.ts). Is it something not supported or we need to update the interface with all available options? Thanks in advance.

I guess this is some new option that was not existing when the lib was created; this should be working regardless of the interface. Could you make a pull request adding the property?

Yeah, this is working regardless of the interface. I will submit a PR. Thanks.

Hey @smnbbrv - please find the PR here.

Should be available from<EMAIL_ADDRESS>on


Spurious diffs with iOS-safari

This happens to us a lot:

In particular, it seems like iOS-safari frequently has diffs related to icon assets not loading consistently.
Any advice?

Hi @ahobson! Sorry about this -- these shouldn't be showing up like this. Do you have a link to a report I can look at? You can send it to<EMAIL_ADDRESS>I'll investigate to see what's up.

Okay, the theory right now is that we aren't waiting for background images on pseudo elements to finish before we take the screenshot. I'll update this thread once we have a fix. Appreciate the report @ahobson!

The theory was correct. A fix has been deployed to Happo's workers.

Thank you. We had a number of PRs from dependabot this morning and we didn't see this issue at all


Configuration is done via YAML files, as documented here.

It could be implemented like the alacritty module (attrs + toJSON), but should also allow the definition of multiple config files for mulitple dashboards.


bug(test): ConfigManager Tests for bypassing ZWAVEJS_EXTERNAL_CONFIG are broken

The tests "from the embedded config dir" and "from the deviceConfigPriorityDir (without ZWAVEJS_EXTERNAL_CONFIG)" are supposed to use the embedded config dir. Instead they create a new external config directory at path "./undefined".
The problem seems to be that the test setup sets the environment variable to the string "undefined", not undefined.
To test this, I modified syncExternalConfigDir in utils.ts to check extConfigDir == undefined || extConfigDir == "undefined". With this change, the tests appeared to run as expected.

The line you linked needs to be delete process.env.ZWAVEJS_EXTERNAL_CONFIG. I think I've fixed that in some branch but not sure where.

Yep, I was just about to add that / do a PR.


Unfriend message is not able to be changed as the code references the wrogn config section

Will be with version 4.4.0


Fix #359: Race conditions in LongGauge and DoubleGauge

LGTM. Follow up questions though:
Should LongGauge and DoubleGauge be deprecated? What value do they add over letting someone manipulate the AtomicLong or other Number implementation directly and just using the NumberGauge to report the value via servo?
Will the NumberGauge get cleaned up and removed from the registry if the number was collected?

I don't think DoubleGauge and LongGauge are needed, so they should be deprecated. I especially would love to get rid of DoubleGauge since it exposes AtomicDouble as part of its API and that makes it very hard to get rid of guava.
Unfortunately they're used in quite a few places, so it might take some time.
Currently NumberGauge will not be removed from the registry if the number is collected. It just keeps reporting NaN.


[BUG] [Upgrade] Elasticsearch settings hard-coded instead of read from existing configuration file

Describe the bug
In upgrade role the following Elasticsearch settings are hard-coded:

http.port: 9200
transport.port: 9300
network.host: "{{ ansible_default_ipv4.address | default(ansible_all_ipv4_addresses[0]) }}"

If any of them has custom value in config file, then epicli upgrade will fail.
How to reproduce
Steps to reproduce the behavior:

Deploy a cluster using old epicli version (e.g. v0.8.2).
Edit /etc/elasticsearch/elasticsearch.yml setting a custom value for any property from the mentioned above.
Run systemctl restart elasticsearch.service
Try to upgrade Elasticsearch using epicli v0.10.0.

Expected behavior
Mentioned settings should be read from existing config file.
Environment

Cloud provider: All
OS: All

epicli version: 0.10.0
Additional context
n/a

DoD checklist

[x] Changelog updated (if affected version was released)
[x] COMPONENTS.md updated / doesn't need to be updated
[x] Automated tests passed (QA pipelines)

[x] apply
[x] upgrade

[ ] Case covered by automated test (if possible)
[ ] Idempotency tested
[x] Documentation updated / doesn't need to be updated
[ ] All conversations in PR resolved
[ ] Backport tasks created / doesn't need to be backported

Upgrade role has been refactored, and this bug may be fixed by #2325

Fixed in PR #2341

✔ Successfully upgraded elasticsearch by following the scenario described above.

epicli upgrade from v0.8 to develop


Change repo name?

We're planning on implementing a wider range of numerical experiments in this repo than just large eddy simulations. So it probably makes sense to generalize the name. Some suggestions are:

OceanTurbulenceLibrary.jl
OceanTurbulenceArchive.jl

Those are a bit dry so if anyone has some suggestions that are a little more fun I think they'd be welcome...
cc @sandreza @navidcy

OCEANTURbrary - if you want something unique to google?

OceanTurbrary.jl... epic

I like @christophernhill's suggestion OceanTurbrary.jl. It's highly unique (so googleable) and continues the oceananigans.

@navidcy

Let's do it!


hosts backend is not parsing final line

New Fedora releases started failing tests. Found that is because default hosts file shipped does not contain final new line. IPv6 address of localhost is not terminated by newline. Backend does not parse it and it fails netresolve test. Fedora bug
Reproduce the issue:
echo "<IP_ADDRESS>   localhost localhost.localdomain localhost4 localhost4.localdomain4" > hosts
echo -n "::1         localhost localhost.localdomain localhost6 localhost6.localdomain6" > hosts

NETRESOLVE_SYSCONFDIR=. tests/test-netresolve.sh

Fails at the end with:
...
++ ./netresolve --node localhost --service ''
+ diff -u /dev/fd/63 ./tests/data/localhost
++ ./netresolve --backends hosts --node localhost
--- /dev/fd/63	2019-09-10 10:15:40.122352456 -0400
+++ ./tests/data/localhost	2016-03-15 18:35:28.000000000 -0400
@@ -1,5 +1,6 @@
 response netresolve 0.0.1
 name localhost
+ip ::1 any any 0 0 0 0
 ip <IP_ADDRESS> any any 0 0 0 0
 secure

Just merge the issue. Sorry for the gap, now I'm once again on GitHub much more often!


[AutoPR authorization/resource-manager] Forgot tiny clean-up

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6447

This PR has been merged into https://github.com/Azure/azure-sdk-for-java/pull/3584


Optimize repeated lookups of JobResult objects and related fields

Closes: #1515
What's Changed

Added prefetch_related to the UI JobResultListView.queryset and API JobResultViewSet.queryset to optimize caching of related fields
Added get_job_content_type() utility function to return a cached ContentType for extras.Job so that it can be used by callers to reduce spurious singular queries for this object

This does not yet collapse/remove the nautobot.extras.tables.JobResultTable.related_object column from list view, which is still resulting in extraneous ContentType lookups for extras.job for each row for some reason, but this makes a huge reduction in singular queries and greatly improves caching of JobResult list queries.
TODO

[x] Explanation of Change(s)
[ ] Attached Screenshots, Payload Example
[x] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
[ ] Example Plugin Updates (when adding/changing features)
[x] Outline Remaining Work, Constraints from Design

I'm happy with the look of these changes, though I haven't done any significant performance testing of the latest diffs - do you still have that data set handy?

As long as there are no follow-up questions: Yes.


Merge prTesting_201907031238 branch to master branch

Docs Build status updates of commit cea674d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update references to slack (odpi->lf ai & data)

We have 6 references to slack.odpi.org in our code base odpi/egeria.
We may also have other references in additional repos used by egeria
All need updating to point to the new LF AI & Data Slack team
cc: @mandy-chessell

Also need to check for odpi.slack.com (thanks @davidradl )

Also need to check for odpi.slack.com (thanks @davidradl )


fix(astro): pre scan components folder

Fixes #1937
It seems Astro, builds client-only components on a separate pipeline. Layers are already replaced on previous (SSR) pipeline. But it was only failing if the client pipeline has a CSS file to process, because of this check:
https://github.com/unocss/unocss/blob/65355361832c38ef6d8d8bcdac0585fbf7d2adbb/packages/vite/src/modes/global/build.ts#L185-L189
That's why Vue components without style blocks were not causing error. From now on we were supposed to encounter this error:
https://github.com/unocss/unocss/blob/65355361832c38ef6d8d8bcdac0585fbf7d2adbb/packages/vite/src/modes/global/build.ts#L191-L195
We didn't, because vfsLayers is shared across these build pipelines. I cleared this set on buildStart. And I moved replace variable to the upper scope to be sure we already replaced layers on the previous hook and don't need to show a warning.
But, those client-only components are only processed on the client pipeline and the server pipeline doesn't have the tokens defined in these files. So, I added a pre-scanning process on Astro plugin.

I think we should have a general mechanism, like via files options, inside the vite plugin. For that we could support HMR properly

I think we should have a general mechanism, like via files options, inside the vite plugin. For that we could support HMR properly

Initially, I was thinking to do the same but I didn't want to make too many changes in core packages for a solution for a single repository. I can't think of many scenarios where this option should be useful. Maybe it could be useful for solutions that use Vite as an asset bundler if some of their files are not processed through Vite's build pipeline.
I'm not sure what you mean by supporting HMR properly, but if we are talking about Astro's HMR it just works fine.

Unlike Tailwind and WindiCSS, UnoCSS reads the content from the build pipeline for efficiently, which works great in normal JS projects. But for some scenarios, you might have external assets that could be the source of tokens. I think it could be helpful to outside Astro, especially backend-integrated solutions. For HMR, I talking about, if we read the file using fs, we should register a fs watcher to update the token reflects their later changes.


Allow to close an editor (created by splitting without creating a group)

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.61
OS Version: Win 10

The new feature that lets you split editors without creating a group is great. However... how do you close the editor without closing the file and then reopening?


migrate-logs-to-log_entries err

server/store/datastore/migration/migration.go:171","message":"migration task 'migrate-logs-to-log_entries' failed but is not required"}
[xorm] [warn]  2023/06/14 02:58:23.234055 Table pipelines column pipeline_error db type is TEXT, struct type is VARCHAR(255)
[xorm] [warn]  2023/06/14 02:58:23.234088 Table pipelines column changed_files db type is TEXT, struct type is JSON
[xorm] [warn]  2023/06/14 02:58:23.265721 Table steps column step_error db type is TEXT, struct type is VARCHAR(500)
{"level":"fatal","error":"Sync error '*model.Step': pq: could not create unique index "UQE_steps_step_uuid"","time":"2023-06-14T02:58:23Z","caller":"/woodpecker/src/github.com/woodpecker-ci/woodpecker/cmd/server/setup.go:90","message":"could not migrate datastore"}

Is this happening when going from 0.15 to next?

Yes

(Postgresql)

#1949


Support incremental builds within buildSrc itself

I have a field in my buildSrc folder.
private static final String versionTail = "2";

Expected Behavior
When bumping the versionTail to "3", gradle should build this incrementally.

it does not affect the public API of the buildSrc output, so gradle should be able to build this incrementally

Current Behavior
Redeploying my android app after bumping the private static field (NOT INCREMENTAL):
BUILD SUCCESSFUL in 50s
242 actionable tasks: 239 executed, 3 up-to-date

When I do not make any changes in buildSrc and redeploy an already built application:
BUILD SUCCESSFUL in 2s
242 actionable tasks: 2 executed, 240 up-to-date

Duplicate of #2767

This is expected, because we don't analyze the source code, so we don't know that the constant didn't change. We only have finer grained detection for bytecode changes on the classpath.
Possible workarounds:

Make that constant private and expose a static method instead
Put it in a class that changes less often

@blindpirate This is something else.
@ZakTaccardi I think I don't quite understand your example.  versionTail is a static field used by a plugin in buildSrc?  The build script uses the output of buildSrc as a runtime dependency, so even though the API did not change, the implementation did and that can invalidate task execution.

Oops, my fault, reopened. Thanks @big-guy .

@big-guy no, not used by a plugin. for example, I have a method from a class in buildSrc that gives me a versionName (Required in Android projects).
the version name varies based on the environment, which I have represented as an enum in the buildSrc folder. below is what I would call from my build.gradle script.
// internally, this method utilizes the private versionTail field
android.productFlavors.qa.versionName =10 Environment.QA.getVersionName()

I can provide a better example next time I'm at my computer, too.

Your build logic has a runtime dependency on the code in buildSrc, so every detail matters, not just the API. The only way to make that incremental would be to track every change to any class in buildSrc and do full runtime instrumentation of your build logic to see when those classes are used. This is prohibitively expensive, so to keep things simple we consider every task out of date if its classpath (which includes buildSrc) has changed.


Editing project file

It would be great if running the bundler would add the generated files to the project as dependent files of the files they were generated from.  The main reason for this is because I don't like referencing files that are not part of the project.  Also I might want T4 to generate links to the file names if I decide to use one by itself at some point.

hmmm, this Nick character...
Sounds like a great idea for a first commit!
Looking forward to your future contributions in this area...


⚠ Bofrost.nl has degraded performance

In dbc751c, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1885 ms

Resolved: Bofrost.nl performance has improved in 2a2beba.


Animal table

FEATURES

Create the database for the vet clinic
Add values for the table
Add queries for search-specific values

First four queries

The last four queries

Note: I use the Pugglin PostgreSQL from Chris Kolkman for this project and that is the interface you see in the screenshots.

Thanks for the reply! here I left another screenshot with the change of data in the table from the vet_clinic-DB and the query change mentioned in the review.


convertToArray endlessly recursing through a child entity with a reference back to its parent (pt. 2)

This is a continuation of #2438 . I am not using the original issue authors mentioned plugin but have observed the same thing happening - this helper function enters into an infinite loop that never ends, causing the request to timeout. This original issue has been closed and I could not comment on it.
The issue primarily seems to be caused by an enum or spatie state relation being passed to this foreach — https://github.com/yajra/laravel-datatables/blob/master/src/Utilities/Helper.php#L175 Commenting out this loop allows my code to proceed and the result/JSON output is what I'd expect.
I have a lot of datatables in this application, and the primary work around is running the query outside of datatables and then passing only the raw result/flat array in.
I'm happy to submit a PR fix but wanted to fully understand what this code achieves first. It looks as though it converts all sub-arrays or objects to arrays on the parent $data array? the confusing part is that it then unset($value) ...

I can't recall why there is an unset there, but that function's purpose is to convert all values recursively to key-value pairs.
Also, I think one problem with that method is when a stdClass is being converted to an array. There are times that it doesn't work but may be invalid now.
Please submit a PR, if it passes the current tests I can merge it. Thanks!


Question about the project

Hello! I'm Drew, creator of the Godot fork Redot Engine. I'm wondering, do you plan on continuing work on this, or is it more of a test case project? I'd love to talk to you about it if I could. You can PM me on discord @Andevrs or X @Andevrs. If you'd rather you can email me at<EMAIL_ADDRESS>Thanks!

Hello! I'm Drew, creator of the Godot fork Redot Engine. I'm wondering, do you plan on continuing work on this, or is it more of a test case project? I'd love to talk to you about it if I could. You can PM me on discord @Andevrs or X @Andevrs. If you'd rather you can email me at<EMAIL_ADDRESS>Thanks!

I texted you on discord, my discord: @zbsnow


Spinner can be left up indefinitely

The indicator works great. However there's a threading issue in decrementActivityCount().
This has a line:
guard activityCount > 0 else { return }

To prevent the activityCount going negative. (I'm curious why this line was introduced.) I have a situation where the activityCount would go negative. The debugger hits the else part of the guard. I believe the timing hole is around AlamoFire's resume() method.
AlamoFire's Request.resume() method (I added the comments):
public func resume() {
    if startTime == nil { startTime = CFAbsoluteTimeGetCurrent() }

    task.resume()

    // TIMING HOLE HERE.
    // The task comes back fast (e.g. from cache) before we call postNotificationName.
    // The decrement is called in the result callback, and activityCount should go to -1. (But doesn't due to the guard > 0)
    // Then this thread resumes and posts its notification about the task starting.
    // Now the activity indicator's count is 1... forever above zero, so the indicator stays on.
    NSNotificationCenter.defaultCenter().postNotificationName(Notifications.Task.DidResume, object: task)
}

I see no reason for the guard activityCount > 0 line. Removing it would fix this hole.

Hi @graham-perks-snap,
I'll need to get back to you on this. I can't give you a good reason as to why the cap is there. Will need to investigate further. Hang tight.

Thanks, I understand you're a little busy with releases!
This problem shows when kicking off several concurrent requests, e.g. fetching live data for table rows as the user quickly scrolls new cells into view. IIRC I've also seen it when calls to AlamoFireImage's ImageDownloader.defaultInstance.downloadImages() is given many URLs.

I'm seeing the same symptoms, albeit not caused by that guard, when using SwiftyDropbox - on an otherwise idle system, when all Dropbox API requests are done, activityCount remains at 1.

Thanks for all the feedback here @graham-perks-snap and @gereons. I just pushed up 3bcb6917 to address the issue by removing the guard. This should go out in an official release here shortly.
Cheers. 🍻


Make sure to read the rendering intent before the CICP tag

The code that reads the CICP tag exits the function if it succeeds, but it should not skip reading the rendering intent, so make sure to have already done it by that point.

at least a partial fix for https://github.com/libjxl/libjxl/issues/2433


How is PSCID used in address translation algorithm?

In Section 2.4, "Process to translate an IOVA", the translation algorithm assigns a value to PSCID but does not appear actually to use it anywhere, not even for error reporting.  The purpose for this value should be explained.

So the purpose of this the PSCID and GSCID is for use to lookup and tag address translation caches. The purpose can be explained better.

Proposed text:
The process to translate an IOVA uses the hardware IDs (device_id and
if appliicable, the process_id) to locate the Device Context and if applicable,
the Process Context, to determine the page tables, PSCID, GSCID, and other
control parameters that affect the address translation and protection process.
When address translation caches are implemented, the translation process may
use the GSCID and PSCID to associate cached translations with their address
spaces.

Addressed in pull request #44
https://github.com/riscv-non-isa/riscv-iommu/pull/44

Approved in IOMMU TG - 9/22/22


Fix documentation typo

Coverage decreased (-0.2%) to 82.775% when pulling 4b76821e492223abe72b22f10b1bfade4cf1e2ad on Bi0T1N:patch-1 into 82ad633f788acf6ce1d24f672e6f4972ce1c72fa on Toblerity:master.

Thanks!


Lower VMware box to 2xCPU

Lowering VMWare box template to 2*vCPU to match the lowered virtualbox specs implemented in #12 .

thanks!


[RIP-10] Add test case for MQPullConsumerScheduleService

What is the purpose of the change
[RIP-10] Add test case for MQPullConsumerScheduleService
Brief changelog
MQPullConsumerScheduleServiceTest
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.05%) to 48.633% when pulling d51169db3af348b85ad1f167486f1afe6c97fa02 on ityongman:develop into 3e1a5ccd697616352119dc63b6b1c3ff716c6950 on apache:develop.


List Products

As an User
I need to discover all products
So that I can see what products are sold
Details and Assumptions

the website sells products
the list is open to any users (no need to log in or create account)

Acceptance Criteria
Given I am interested in the company's products
When want to see the products
Then all the products display

This looks good!


add ml-common into 2.0 manifest

Description
Add ml-common into 2.0 OS build manifest.
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1826 (ba99c62) into main (47a94f7) will increase coverage by 5.47%.
The diff coverage is n/a.

:exclamation: Current head ba99c62 differs from pull request most recent head 411cc76. Consider uploading reports for the commit 411cc76 to get more accurate results

@@              Coverage Diff              @@
##               main     #1826      +/-   ##
=============================================
+ Coverage     94.52%   100.00%   +5.47%
=============================================
  Files           176         6     -170
  Lines          3617       105    -3512
  Branches         27        19       -8
=============================================
- Hits           3419       105    -3314
+ Misses          194         0     -194
+ Partials          4         0       -4

Impacted Files
Coverage Δ

src/test_workflow/integ_test/integ_test_runners.py

src/test_workflow/perf_test/perf_test_cluster.py

src/test_workflow/bwc_test/bwc_test_suite.py

src/system/properties_file.py

src/assemble_workflow/bundles.py

src/test_workflow/perf_test/perf_test_suite.py

src/paths/output_dir.py

src/manifests/component_manifest.py

src/run_integ_test.py

src/assemble_workflow/assemble_args.py

... and 160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47a94f7...411cc76. Read the comment docs.


tandoor-recipes: fix build

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I think you should instead use packageOverrides to modify the version of crispy-forms used in the package, rather than change the global version.

I think you should instead use packageOverrides to modify the version of crispy-forms used in the package, rather than change the global version.

This is less preferable since python3Packages.django-crispy-forms is failing on master right now, and the fix will necessarily introduce format = "pyproject" and setuptools, and thus will break the overridden one.

@wegank you could use overridePythonAttrs to use the old format.

I mean, if you want python3Packages.django-crispy-forms to always points to the latest version (which I don't see the need for), it's much more robust to create a python3Packages.django-crispy-forms_1_14 than to override a bunch of stuff that might need changes every time an upgrade is done.

I think it makes more sense to avoid a global change for what should be a local fix.

Please do what @ambroisie says.

cc @ambroisie


fixed check for file path ends

pull request as agreed at https://github.com/ensime/ensime-vim/issues/346

@paultol thank you so much for you contribution!


DeCAF ImageNet link broken in the documentation

In this file:
https://github.com/dnouri/nolearn/blob/master/docs/decaf.rst
the following URL is referred:
http://www.eecs.berkeley.edu/~jiayq/decaf_pretrained/
It redirects to 404 page. How can I download those data?

Best to contact the author.  The link from his own website is broken too.


[FLINK-15577][table-planner] Fix similar aggregations with different windows being considered the same

What is the purpose of the change
The RelNode's digest is used by the Calcite HepPlanner to avoid adding duplicate vertices to the graph. If an equivalent vertex was already present in the graph, then that vertex is used in place of the newly generated one. This means that the digest needs to contain all the information
necessary to identifying a vertex and distinguishing it from similar (but not equivalent) vertices.
In the case of the WindowAggregation nodes, the window specs are currently not in the digest, meaning that two aggregations with the same signatures and expressions but different windows are considered equivalent by the planner, which is not correct and will lead to an invalid Physical Plan.
This commit fixes this issue and adds a test ensuring that the window specs are in the digest, as well as similar aggregations on two different windows will not be considered equivalent.
Only the old planner is subject to the issue, the Blink planner correctly uses the window specs in the nodes' digests, allowing Blink to correctly differentiate between the nodes.
More info and an example of an invalid plan are avalaible at https://issues.apache.org/jira/browse/FLINK-15577
Brief change log
Added window specs to the following RelNodes:

LogicalWindowAggregate
FlinkLogicalWindowAggregate
LogicalWindowTableAggregate
FlinkLogicalWindowTableAggregate

Added unit tests to the legacy planner and to the blink planner to prevent future regressions.
Verifying this change
This change added tests and can be verified as follows:

Added unit tests for the old planner to ensure window specs are in digest and that similar aggregations with different windows are not considered equivalent in the physical plan.
Added unit tests for the blink planner to ensure no such regression can be introduced in the future.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@flinkbot run travis


possible to provide custom template for typeahead items?

I have a selector with items that are generated from an array of objects containing several attributes of interest to the user. In addition to the typeahead dropdown displaying the attribute specified by 'bindLabel', I'd like to additionally display another attribute value on the same object in smaller text below the bindLabel attribute value.
Is it possible to create a template with the additional content to replace the default template?

I’m not sure I understand what you mean. ngrx-forms only handles state management, it is not involved with rendering at all. Therefore it as no impact on any labels and such.
Are you using a third-party typeahead component? If so I recommend asking in their repository.

Ah, yes indeed - I'm working on a form based on ngrx-forms and the ng-select component - I'd hit the wrong tab before opening this issue, apologies.
Fabulous library, btw - I'm finding it helpful for the same kinds of features that angular-formly provided for AngularJS.


[DataLake]: Update Swagger objects to have proper inheritance

Need explicit inheritance for (flow is each lower object is "AllOf" the one above it, in the nested lists)

JobInformation

BaseJobInformation
SubmitJobResponse
JobInformation
SubmitJobParameters (maybe)

Account (adla and adls)

ListAccount
Account

@amarzavery can you assign this to me, I can't modify assignees.

@begoldsm - Could you provide an update on this issue? Is it fixed?

@kirthick this is not yet fixed. This is a nice to have clean up task that will result in a lot of breaking changes to subsequent releases of the sdk. This is requirement is only to make our strict swagger validation tests work so that an object that is returned doesn't have missing "required" properties.
I will sync with PM to prioritize this and reply back here with an eta

@veronicagg and @kirthik this should be resolved by PR #1429 can you confirm and close this if so?


Move xblock tutorial docs to this repo

@feanil

Converting to draft - this is going to be more complicated and I suddenly don't have a ton of time

@farhan  this is ready for your review (I will squash commits before merging, they just might be useful to you in chunks). This move is needed for a link we're making in the new DemoX course so your review this week or early next would be wonderful.


GroupBy.nlargest and GroupBy.nsmallest

this method is not implemented:
Pandas reference:
https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.core.groupby.SeriesGroupBy.nlargest.html

I will create pr for this function

Thank you so much, @RainFung

There are some problem in thess function https://github.com/pandas-dev/pandas/issues/27894. I will create PR when the pandas issue solved.

https://github.com/databricks/koalas/pull/654

I have finish it. Can you close this issue?

Closing, thanks so much @RainFung for your work!


1 line breaks sway compatibility

https://github.com/acrisci/i3ipc-python/blob/262246d9399bac3881133bc22d018fcdea403b33/i3ipc/model.py#L305
This line breaks binding events in sway. After commenting it out, binding events worked just fine.

What's the error?

I can't reproduce it.


not inserting toViewController's view

discarding the changes as in one scene the from view becomes blank.


Update this reference to self

Hi there,
In this._execCommand at line 73 the this keyword is use instead of self. In case of _execCommand override or external call, this will be undefined.
This proposal just fix that.
Check that your description matches the automatic change-log format:
http://karma-runner.github.io/2.0/dev/git-commit-msg.html
then delete this reminder.

I signed it!

@Itee thanks for pull request. Would you mind to update commit message ? Karma use validate-commit-msg style for that. My proposition is:
fix(launcher): update this reference to self

Sorry this did not work out. I'm going to close a lot of older pull requests as the source code has changed a lot over the last year.
Thanks!


wraps name is not allowed

Describe the bug
I've tried to upload a package under wraps name, but for some reason it is not allowed:
$ poetry publish

Publishing wraps (0.1.0) to PyPI
 - Uploading wraps-0.1.0-py3-none-any.whl FAILED

HTTP Error 400: The name 'wraps' isn't allowed. See https://pypi.org/help#project-name for more information.

Expected behavior
I expected the wraps name to be allowed.
To Reproduce
Attempt to upload a package under wraps name.
My Platform
Windows 11, poetry 1.2.0b2, though twine does not work either.

Hi, please see https://pypi.org/help/#project-name.

Is it explicitly prohibited? Because I don't think it collided with the standard library... perhaps functools.wraps?

It is explicitly prohibited but likely can be made available by following https://pypi.org/help/#project-name-claim.

I see. I'm going to file a request and see how it goes, then.


s

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request

Versions.

Repro steps.

The log given by the failure.

Desired functionality.

Mention any other details that might be useful.

Closing as it seems to be an empty issue.


How to save and load pytorch model

Hey can you help me with saving the final model which can be load directly on a system without requiring other files.
Since the model is only saving the weights i.e. model.state_dict() so i have updated that line for saving the complete model not only the state_dict but still to load the model it requires all other custom py files like model_search ,  architecture and genotypes.

I can't provide help with specific use cases. Perhaps just pickle the genotypes etc. along with the weights.

Even after i pickle everything the model is save is different from usual model.
I cannot understand the usage of genotypes and how to use the create the final model.

HI dude! Have you solved this problem?


VTK Extension does not work as UMD module

If we use it as a script tag a runtime, it is not working:
https://codesandbox.io/s/ohif-script-tag-v144-runtime-extensions-okrdv
https://github.com/salimkanoun/GaelO/blob/dev/ohif/index.php#L62
Thanks @salimkanoun

I'm concerned we won't be able to get it to work unless we bundle vtk.js, or take an external approach like we do with the cornerstone libraries. Largely because vtk.js doesn't have "top level exports" for ES6 consumption, we're forced to pull in each piece we need from specific files under /Sources/

It's not really an extension if you need to bundle it...  What is the external approach?

The extension doesn't need to be bundled into the app, the VTK.js dependency may need to be bundled with the extension.
If you want to consume vtk.js as an ES6 Dependency, you import and use it like so:
import vtkFullScreenRenderWindow from 'vtk.js/Sources/Rendering/Misc/FullScreenRenderWindow';
import vtkActor           from 'vtk.js/Sources/Rendering/Core/Actor';
import vtkCalculator      from 'vtk.js/Sources/Filters/General/Calculator';
import vtkConeSource      from 'vtk.js/Sources/Filters/Sources/ConeSource';
import vtkMapper          from 'vtk.js/Sources/Rendering/Core/Mapper';
import { AttributeTypes } from 'vtk.js/Sources/Common/DataModel/DataSetAttributes/Constants';
import { FieldDataTypes } from 'vtk.js/Sources/Common/DataModel/DataSet/Constants';

(This is the recommended approach in their documentation)
Because we're not importing everything from vtk.js, WebPack sees each of these as different entry points. Each one needs to be declared as a separate external in the WebPack configuration, or we need to use regex to exclude all of them. I haven't done much testing, but I believe this makes it difficult for the resulting package (the extension) to resolve these external dependencies for script-tag (UMD) usage.
For the PWA, we have access to /Sources/ at the time of bundling, so everything works as expected. For runtime extensions, I don't believe the extension's package is capable of resolving those dependencies from the platform.
If someone with more experience, or from Kitware, were to weigh in, I would be incredibly grateful, as I'm not 100% sure I know the best path forward here. The "just make it work" / easiest path forward here is to include vtk.js in the extension's package instead of externalizing.

Sorry to be dense here, but why does the extension need to be bundled?  I think it's best to let it just pull in the code via the script tag when the extension is activated.

It's entirely possible I'm misunderstanding what you mean. Let me expand a bit:
For PWA? All extensions defined in the entry point are included in the bundling process.
For Script-Tag? We publish many "bundles" (packages):

The Viewer as a bundle w/ the cornerstone extension included (@ohif/viewer)
The VTK Extension as a bundle that can be dropped in at runtime (@ohif/extension-vtk)
The Microscopy Extension as a bundle that can be dropped in at runtime (@ohif/extension-microscopy)
The PDF Extension as a bundle that can be dropped in at runtime (@ohif/extension-dicom-pdf)
Etc.

Allowing for stuff like:

The crux of the problem, at least as far as I understand it, is how and where do we include vtk.js?

With a script tag? I think because we import it like this, we are not able to:

import { FieldDataTypes } from 'vtk.js/Sources/Common/DataModel/DataSet/Constants';

As a direct dependency of @ohif/viewers that is somehow magically resolved when the extension is added at load / runtime?

Included in the @ohif/extension-vtk package? This is easiest, but could cause duplicate instances of VTK.js if another extension also depends on it.

I hope that makes sense. Please don't hesitate to call me out if I'm missing something obvious or misunderstanding the issue at hand.

Hi @dannyrb - when we were first talking about plugins I made this little example: https://github.com/pieper/hello-plugin
Other details aside, what this approach did was bring in the vtkjs via script tag after the viewer was already up and running rather than making it part of the config.  That's the kind of dynamic behavior and modularity I was looking for.

Dear all,
Sorry to disturb your hard work but Is there any new about this issue ?
This one prevent me to upgrade OHIF in my project.
I was wondering, how do you make the https://viewer.ohif.org/ integration ?.
Your demo page does not suffers from this bug as the VTK extension is working.
Is there available source code from you demo page so I can learn how to escape this issue ?
Thanks again for your amazing work, I see OHIF getting so much better that i'm frustrated to be stuck on a old version ^^
Salim

@salimkanoun, you are always more than welcome to check-in and ask questions ^_^
https://viewer.ohif.org/ does not use the published @ohif/viewer that sits on npm. Your usage probably has an index.html file that uses that bundle in a single script include tag that points at something like: https://unpkg.com/@ohif/viewer
While that is handy for a quick setup, I'd likely steer most people creating a product or a dedicated instance to use the "Progress Web Application (PWA)" version of the OHIF Viewer. This version is generated when you use the yarn run build command from the repositories root directory. The deployable application lives in /platform/viewer/dist
When building the PWA application, you have the advantage of being able to specify the extensions you would like included at "build time" -- this takes place in platform/viewer/src/index.js.
Building and deploying the PWA application is not as clear cut, but you generally see much better performance. It allows us to leverage things like service workers, code splitting, treeshaking, improved minification, etc. that just aren't possible when trying to deliver the application as a single ES5 bundle of javascript.
That being said, this issue is still one I would like to see resolved, as it is a use case we would like to support, and will matter more as we progress to users being able to share "workflow recipes" (installable modes)

Thanks for these information @dannyrb ,
I started to work on a React Project, but I'm very far from this level of complexity compared to OHIF code.
Anyway I will try to make my own build of OHIF and see what's happening.
Best regards,
Salim

@dannyrb
hello, when I install other extensions except OHIFExtDicomMicroscopy to the project, I get this error and black screen comes up. can you help me please

I'm gonna close this since a lot has changed. If the issue is relevant in v3 please re-open


debug: extension development: stop doesn't stop debugging (or does it?)

MacOS
Version 1.23.0-insider (1.23.0-insider)
b845ce918f2689344795e845ae6ef691916c3079
scaffold out a new TypeScript extension using yo code
load the workspace, press F5
the extension dev environment comes up as expected
now, close the ext dev environment by clicking the close (red button on mac) button
result: we are still in debug mode, or at least it appears to be, because the debug toolbar is still visible
press refresh on the debug toolbar
result: toolbar goes away, the extension dev host is not restarted

duplicate of #48442


Feature: Allow merge policy to be set

Simply, this allows the merge policy of all the contexts be specified at DataAccess creation, instead of relying on the hardcoded defaults.
This will set the stage (somewhat) for clients who want to put uniqueness constraints in their data model, but want to handle the merging in a way different from what is currently provided.

Good points both.  Changes pushed.


CMS-321: Protect entire routes with Keycloak

Jira Ticket
CMS-321
Description

Expanding on #9 , this changes the page-specific and section-specific auth to protect the entire frontend app, and all the endpoints on the backend (except/ and the /time testing endpoint in the root).
On the frontend, there's no explicit log in/out buttons. If you're not logged in, it will forward you to Keycloak instead of showing anything.
On the backend, it will continue rejecting requests with 401 if you don't send a valid token.

Note that we'll eventually have an anonymously available public API so more of the backend routes will need to be unprotected

Just rebased onto main; merging ✅


Welcome message

The bot should be able to sent a welcome message when someone enters the server
Expected Behavior
The bot should send a message with the following information

X
Y
Z

Current Behavior
New feature
Possible Solution
Build it

This has been implemented

:tada: This issue has been resolved in version 0.1.0 :tada:


fix(TransactionsCollectionQuery): Use AND between payment method service and type

#10042  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gustavlrsn and the rest of your teammates on  Graphite


On Stepper users don't hear error messages

Describe the bug
When a screen reader user reads a field that is in an error state they do not hear the error message.
How to reproduce
https://clarity.design/documentation/stepper
Steps to reproduce the behavior:

Go to the stepper example
Trigger an error message by using the Tab key to focus the 'First Name' field and then press the Tab key again to move focus to the next control in the Tab order.
Observe that an error message appears below the 'First Name' field
Tab back to the 'First Name' field and observe that you do not hear the error message as part of the name and description of the field

Expected behavior
The user should hear the error message.
Versions
App

Angular: [e.g. 6]
Node: [e.g. 8.10.0]
Clarity: [e.g. 0.12.5]

Device:

Type: [e.g. MacBook]
OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional notes
This is due to the incorrect use of aria-describedby.
The current implementation below uses the input field to describe the error message.

First Name Required
But we want the error message to describe the input field instead as seen below.

This is essentially the same fix but for error instead of helper text
https://github.com/vmware/clarity/pull/3596


Add support for choosing listening host for Flask

If the server is on a remote machine, allows to set a listening ip/hostname, otherwise, only runs on <IP_ADDRESS>.
Set it by default to <IP_ADDRESS> for security

Thanks, this is great, I really appreciate the contribution!
I did notice one issue - the config fails to load because the IP needs to be quoted, eg:
server_host = "<IP_ADDRESS>"
I hope I don't regret choosing toml - it's supposed to be a simpler config format, but it's not used much.

Actually, no big deal, I merged this and then updated the config.
Thanks again!


[BEAM-12548] Fix malformed comment for EqualsFloat

Fix comment on EqualsFloat to align with the style guide.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @lostluck


[Suggestion]Remove the files from the editor after deleting its parent folder

OS: Windows_NT x64 10.0.17763
Version: 1.37.0-insider (user setup)
Commit: 5e08ee01b7daee99cdda2456f19d77e715fb8762
Build Version: 20190805.1
Regression: Not a Regression
Repro Steps:

Drill down from one storage account -> File Shares node.
Create a file share -> Create a directory -> Select "Create Empty Text File..." from the directory context menu -> Open the file in editor.
Delete the directory -> Check whether the file in editor auto removes or not.

Actual:
The file still lists in editor.
Suggestion:
Remove the files from the editor.
More Info:
The file opened in editor auto removes after deleting its parent folder in File Explorer.

Might be fixed if we implement watch

Never mind - this is the Azure View not file view

We don't have an API call to close the editor view

Got it. Thanks for your share.


fetchdarcs: add SSL_CERT_FILE environment variable (master)

Motivation for this change
Fetching from darcs repositories through HTTPS fails without this changes, since CA certificates are not made available to darcs. Example:
building path(s) '/nix/store/kcas73q9cs3107kkl6z5wrcg0sr3i3r1-fetchdarcs'
getting http://hub.darcs.net/RyanGlScott/vector-algorithms   into /nix/store/kcas73q9cs3107kkl6z5wrcg0sr3i3r1-fetchdarcs
Identifying repository http://hub.darcs.net/RyanGlScott/vector-algorithms

darcs failed:  Not a repository: http://hub.darcs.net/RyanGlScott/vector-algorithms (Peer certificate cannot be authenticated with given CA certificates)

HINT: Do you have the right URI for the repository?

builder for '/nix/store/l0s2vhr69ikg2r0i1ya3z98jxvr2f6dc-fetchdarcs.drv' failed with exit code 2
error: build of '/nix/store/l0s2vhr69ikg2r0i1ya3z98jxvr2f6dc-fetchdarcs.drv' failed

Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

cc @shlevy @luite

This fixes the problem for me on Linux (Ubuntu 16.04), nixpkgs 17.03


CI pipeline

Current build fails now - https://ci.sparrowhub.io/report/2288
HTH
Aleksei

kdf command was added to openssl 3.0 (https://www.openssl.org/news/cl30.txt), so I assume this test suite is using an older version.
I'll see if I can test the openssl version and skip relevant tests if need be.

👍

Yeah , you need to add this repo to your repos list in your SparrowCI account  to start new builds. Thanks !

looks like latest commits has made the whole build run much longer - my SparrowCI workers timeouted - https://sparky.sparrowhub.io/report/multi-versions/10812

looks like latest commits has made the whole build run much longer - my SparrowCI workers timeouted - https://sparky.sparrowhub.io/report/multi-versions/10812

Apparently the test runs the part I thought I was skipping when not using openssl.  Not sure what I missed.  I'll look into it.

sorry this comment was meant to bitcoin-raku-tools, and this is actually not a timeout but out of memory error, so docker instance running a test gets kicked of by kernel ...

Apparently the test runs the part I thought I was skipping when not using openssl. Not sure what I missed. I'll look into it.

do you mean all these [Bitcoin] PBKDF2 tests, right?

Apparently the test runs the part I thought I was skipping when not using openssl. Not sure what I missed. I'll look into it.

do you mean all these [Bitcoin] PBKDF2 tests, right?

Yes.  They are progress indicators :
https://github.com/grondilu/bitcoin-raku-tools/blob/655ef77e239c55b9a5cf7bb643ea5322f1847705/lib/BIP39.rakumod#L28

well, now the last pipeline just fails - https://ci.sparrowhub.io/report/2288 with the old Invalid command 'kdf'; error

there is raku-sparrow channel on irc where we can also discuss things ...

well, now the last pipeline just fails - https://ci.sparrowhub.io/report/2288 with the old Invalid command 'kdf'; error

this makes sense as this run was for the 0.6.0 version, which I'm pretty sure was before I added the openssl version test.


Q# 2.0 Tracking Issue

This issue tracks the tasks we'd like to have done before the release of Q# 2.0.

[ ] #2048
[ ] Deprecate Explicit Namespaces (no issue yet)
[ ] Deprecate use qubit blocks
[ ] Deprecate w/ syntax
[ ] Old UDT syntax
[ ] Deprecate Microsoft.Quantum.* libraries
[ ] remove set keyword (see https://github.com/microsoft/qsharp/issues/1496)
[ ] remove ... syntax from specialization definitions

Process of Upgrading Q# Syntax
For anything breaking, primarily the removal or modification of existing Q# syntax, we want to be in the following state before Q# 2.0:

A lint warning will inform the user that something is deprecated.
The v2-preview-syntax feature flag allows the user to opt-in to v2 syntax, meaning that the aforementioned lints become compile errors.
There needs to be a clearly documented path to go from deprecated syntax to v2 syntax. Ideally, there's also a quick fix attached to the lint to make this even easier.

We should define a minimum deprecation time period such that items are deprecated for at least that long before they are removed. During this period, there should also be new syntax available.


fix: crash caused by DiscordRPC. (very temporary fix)

crash was triggered by opening a world in lan.

i had the feeling this would break, it was more of a lazy fix to get it to compile anyways.
will make a proper fix at some point (therefore i wont merge this for now)

fixed in 1b428b169bd3ec4d1621392152d0006e28e66fd5


add token to ci

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7a107e1) 95.25% compared to head (c88bee1) 95.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #655   +/-   ##
=======================================
  Coverage   95.25%   95.25%
=======================================
  Files         128      128
  Lines        4822     4822
=======================================
  Hits         4593     4593
  Misses        229      229

Flag
Coverage Δ

unittests
95.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


How to fix conflicting test annotations when integration testing GraphQL and Jooq using Testcontainers?

I want to write an integration of my application against a Testcontainer since unit testing and mocking virtually all services used in my GraphQL implementation is not feasible whatsoever. However I am running into serious issue with booting up the test as the context is properly initializable at all.
First I got an abstract class that boots up a Postgres test container and sets up the Jooq autowiring against this container:
@SuppressWarnings("rawtypes")
@ContextConfiguration(initializers = AbstractTestConfiguration.Initializer.class)
@AutoConfigureTestDatabase(replace = Replace.NONE)
@JooqTest
public abstract class AbstractTestConfiguration {
  @ClassRule
  public static PostgreSQLContainer postgreSQLContainer =
      new PostgreSQLContainer("postgres:11").withDatabaseName("integration_test");

  public static class Initializer
      implements ApplicationContextInitializer<ConfigurableApplicationContext> {
    @Override
    public void initialize(final ConfigurableApplicationContext applicationContext) {
      postgreSQLContainer.start();
      TestPropertyValues.of(
              format("spring.datasource.url=%s", postgreSQLContainer.getJdbcUrl()),
              format("spring.datasource.username=%s", postgreSQLContainer.getUsername()),
              format("spring.datasource.password=%s", postgreSQLContainer.getPassword()))
          .applyTo(applicationContext.getEnvironment());
    }
  }
}

Now a simple test that shows that Jooq testing works looks as follows:
@ExtendWith(SpringExtension.class)
public class JooqPocTest extends AbstractTestConfiguration {
  @Autowired private DSLContext jooq;

  @BeforeEach
  public void beforeEach() {
    assertThat(jooq).isNotNull();
  }

  @Test
  @Transactional
  public void test() throws IOException {
    // This is possible since Flyway migrations are running against the test container as well
    val planets = jooq.select().from(Tables.PLANET).fetchInto(Planet.class);
    assertThat(planets).hasSize(2);
  }
}

Now I wanted to move on to GraphQL testing as documented over here: https://github.com/graphql-java-kickstart/graphql-spring-boot/blob/master/example-graphql-tools/src/test/java/com/graphql/sample/boot/GraphQLToolsSampleApplicationTest.java
However I am running into various issues with the following test code:
@ExtendWith(SpringExtension.class)
@GraphQLTest
public class JooqAndGraphQLPocTest extends AbstractTestConfiguration {
  @Autowired private GraphQLTestTemplate graphQLTestTemplate;

  @Autowired private DSLContext jooq;

  @BeforeEach
  public void beforeEach() {
    assertThat(jooq).isNotNull();
  }

  @Test
  @Transactional
  public void test() {
    val planets = jooq.select().from(Tables.PLANET).fetchInto(Planet.class);
    assertThat(planets).hasSize(2);
  }

  @Test
  public void graphQLTest() throws IOException {
    val response = graphQLTestTemplate.postForResource("graphql/post-ping.graphql");
    assertNotNull(response);
  }
}

The combination of @JooqTest and @GraphQLTest is invalid since they declare multiple @BootstrapWith annotations. Well, replacing the former with @AutoConfigureJooq doesn't work either as my own service beans are no longer picked up for injection. And similarly adding @SpringBootTest is conflicting as well.
Is there any reasonable way to configure all testing facilities properly so that I can eventually do some integration testing?

The @GraphQLTest annotation basically tries to behave like @SpringBootTest but sliced like @DataJpaTest by filtering the component-scanned beans to only those from the GraphQL libraries.
Instead of using the GraphQLTest annotation you might be better of configuring it manually. Just use a @SpringBootTestand create the requiredGraphQLTestTemplate` bean and start from there:
@Bean
@ConditionalOnMissingBean
public GraphQLTestTemplate graphQLTestUtils() {
    return new GraphQLTestTemplate();
}

Thank you for the input, I'll give this a try in a few days once I find some time for it.

Closing issue due to inactivity


How do you install xformers precompiled wheels?

Do you just put the whl file into the root webui directory? Is there anything else needed? I get an error message 'no triton'

manually copy them to /usr/local/lib/python3.8/dist-packages/xformers
but that is automated in the colab, no need to do it manually

Beyond me that I think! Is there a way to use your version in the collab drive I haven't room in my gdrive?

If you are using dreambooth, just skip the first cell
if you are using A1111 colab, skip the first cell and create a new cell below it and run it:
!mkdir -p "/content/gdrive/MyDrive"


Fix to #3910 - Query: Support Include/ThenInclude for navigation on derived type

It was not possible to specify include on a derived type. Include was very strict when computing navigation paths from Include method and generated code wasn't accounting for type discrepancies between caller and navigation.
Fix is to allow specifying include on derived types using string overload:
entities.Include("DerivedProperty")
or using lambda and specifying parameter type explicitly
entities.Include((Derived e) => e.DerivedProperty)
Made tweaks to the logic that computes navigation paths - now it looks for navigation on derived types also.
Added additional checks to the generated code (_Include method fixup)
old:
fixup: (QueryContext queryContext | SomeEntity entity | Object[] included) =>
{
    return !(bool ReferenceEquals(included[0], null))
    {
        return entity.Navigation = (OtherEntity)included[0]
    }
     : default(OtherEntity)
}

new:
fixup: (QueryContext queryContext | SomeEntity entity | Object[] included) =>
{
    return !(bool ReferenceEquals(included[0], null)) && (entity is DerivedEntity) ?
    {
        return ((DerivedEntity)entity).DerivedNavigation = (OtherEntity)included[0]
    }
     : default(OtherEntity)
}

This also allows to reuse include pipeline to project collection navigations on derived types (before it was producing N+1 queries)
For string based include, since there is no way to provide the type that the navigation is declared on, we aggressively include properties - if multiple derived types declare a property with the same name, they will all be included.

Lets go over design meeting so we know what we are reviewing exactly :trollface:

Closure?

need to rework the translation part we talked about during the meeting


[Bug Report] AssertionError: failed to load textures for name "brick_wall"

If you are submitting a bug report, please fill in the following details and use the tag [bug].
Describe the bug
I am testing the code of https://github.com/shuishida/calvin, where they tried to experiment their robot control algorithm in the Mini-World Maze environment. When the code was trying to generate the Maze environment, more specifically, to generate the brick-wall texture, here came the AssertionError from opengl.py as it shows below in the Code example.
Code example
You can find the upstream call of the class Maze at https://github.com/shuishida/calvin/blob/master/core/domains/miniworld/gym_envs/maze.py
The traceback is like:
Traceback (most recent call last):
File "core/domains/miniworld/dataset.py", line 51, in
main()
File "core/domains/miniworld/dataset.py", line 47, in main
generate_miniworld_expert_demos(vars(config))
File "core/domains/miniworld/dataset.py", line 22, in generate_miniworld_expert_demos
generate_expert_demos(get_save_path, **config)
File "./core/dataset.py", line 21, in generate_expert_demos
env = factory.env(meta, data=data, split="train", **env_config)
File "./core/domains/miniworld/factory.py", line 16, in init_miniworld_env
env = MiniMaze(num_rows=size, num_cols=size, max_steps=max_steps)
File "./core/domains/miniworld/gym_envs/maze.py", line 19, in init
domain_rand=False
File "/data/zhanggengyu/anaconda3/envs/calvin/lib/python3.7/site-packages/miniworld/envs/maze.py", line 28, in init
**kwargs
File "/data/zhanggengyu/anaconda3/envs/calvin/lib/python3.7/site-packages/miniworld/miniworld.py", line 523, in init
self.reset()
File "/data/zhanggengyu/anaconda3/envs/calvin/lib/python3.7/site-packages/miniworld/miniworld.py", line 555, in reset
self._gen_world()
File "/data/zhanggengyu/anaconda3/envs/calvin/lib/python3.7/site-packages/miniworld/envs/maze.py", line 102, in _gen_world
self.box = self.place_entity(Box(color='red'))
File "/data/zhanggengyu/anaconda3/envs/calvin/lib/python3.7/site-packages/miniworld/miniworld.py", line 866, in place_entity
self._gen_static_data()
File "/data/zhanggengyu/anaconda3/envs/calvin/lib/python3.7/site-packages/miniworld/miniworld.py", line 990, in _gen_static_data
self.rand if self.domain_rand else None
File "/data/zhanggengyu/anaconda3/envs/calvin/lib/python3.7/site-packages/miniworld/miniworld.py", line 243, in _gen_static_data
self.wall_tex = Texture.get(self.wall_tex_name, rng)
File "/data/zhanggengyu/anaconda3/envs/calvin/lib/python3.7/site-packages/miniworld/opengl.py", line 57, in get
assert len(paths) > 0, 'failed to load textures for name "%s"' % tex_name
AssertionError: failed to load textures for name "brick_wall"
System Info
Describe the characteristic of your environment:

Describe how gym-miniworld was installed: using your recommended way of installing, python3 -m pip install miniworld
What OS/version of Linux you're using: Ubuntu 20.04
Python version: Python 3.7

Additional context
Add any other context about the problem here.
Checklist

[✓] I have checked that there is no similar issue in the repo (required)

I figured out the culprit of the issue, which is that the installed package did not contain the textures/ and meshes/ directories. I manually downloaded them and placed them under the miniworld/ directory. This issue seems to be resolved.
However, I then got another error:
Traceback (most recent call last):
File "/data/zhanggengyu/projects/baselines/calvin/core/domains/miniworld/dataset.py", line 51, in
main()
File "/data/zhanggengyu/projects/baselines/calvin/core/domains/miniworld/dataset.py", line 47, in main
generate_miniworld_expert_demos(vars(config))
File "/data/zhanggengyu/projects/baselines/calvin/core/domains/miniworld/dataset.py", line 22, in generate_miniworld_expert_demos
generate_expert_demos(get_save_path, **config)
File "/data/zhanggengyu/projects/baselines/calvin/./core/dataset.py", line 21, in generate_expert_demos
env = factory.env(meta, data=data, split="train", **env_config)
File "/data/zhanggengyu/projects/baselines/calvin/./core/domains/miniworld/factory.py", line 16, in init_miniworld_env
env = MiniMaze(num_rows=size, num_cols=size, max_steps=max_steps)
File "/data/zhanggengyu/projects/baselines/calvin/./core/domains/miniworld/gym_envs/maze.py", line 14, in init
super().init(
File "/home/zhanggengyu/.local/lib/python3.7/site-packages/miniworld/envs/maze.py", line 26, in init
super().init(
File "/home/zhanggengyu/.local/lib/python3.7/site-packages/miniworld/miniworld.py", line 523, in init
self.reset()
File "/home/zhanggengyu/.local/lib/python3.7/site-packages/miniworld/miniworld.py", line 555, in reset
self._gen_world()
File "/home/zhanggengyu/.local/lib/python3.7/site-packages/miniworld/envs/maze.py", line 102, in _gen_world
self.box = self.place_entity(Box(color='red'))
File "/home/zhanggengyu/.local/lib/python3.7/site-packages/miniworld/miniworld.py", line 866, in place_entity
self._gen_static_data()
File "/home/zhanggengyu/.local/lib/python3.7/site-packages/miniworld/miniworld.py", line 988, in _gen_static_data
room._gen_static_data(
File "/home/zhanggengyu/.local/lib/python3.7/site-packages/miniworld/miniworld.py", line 243, in _gen_static_data
self.wall_tex = Texture.get(self.wall_tex_name, rng)
File "/home/zhanggengyu/.local/lib/python3.7/site-packages/miniworld/opengl.py", line 67, in get
self.tex_cache[path] = Texture(Texture.load(path), tex_name)
File "/home/zhanggengyu/.local/lib/python3.7/site-packages/miniworld/opengl.py", line 82, in load
glEnable(tex.target)
File "/home/zhanggengyu/.local/lib/python3.7/site-packages/pyglet/gl/lib.py", line 114, in errcheck
raise GLException('(0x%x): %s' % (error, msg))
pyglet.gl.lib.GLException: (0x500): Invalid enum. An unacceptable value is specified for an enumerated argument.
Not sure what is the cause this time...

Can you check your pyglet version?

Can you downgrade it to 1.5.27 and see if that solves the problem?

I found that installing gym_miniworld (using pip as provided in https://pypi.org/project/gym-miniworld/, might be a previous version?) instead of the current miniworld solves the issue. Do I still need to test pyglet 1.5.27 on the current version of miniworld or it's safe to close the issue?

You can close the issue.

2.0.9 does not work. I had to install 1.5.27 to get it working.


Panner Node Not Working As Intended

Describe the bug
I expect the Tone.Panner node to route audio to the left speaker or the right speaker based on the Tone.Panner.pan.value between -1 and 1. It changes, but audio is heard from both speakers at all times.
To Reproduce
Head to this Codepen: https://codepen.io/jonobr1/pen/JjZbyQX
Hit play and then change the slider with your mouse.
Expected behavior
Expect the audio to pan from left to right, but audio is heard from all speakers at all times.
What I've tried
I tried checking out the Mixer example and it also has the same issue when soloing and adjusting the Pan: https://tonejs.github.io/examples/mixer
Additional context
This is on MacOS 13.0 (22A380) Chrome, Safari, and Firefox as well as iOS 16 on Mobile Safari. I can't tell, but this could be an issue with the Web Audio API itself.

Sorry, I was using the wrong Panner!


Is go-micro no longer being maintained? And does it no longer have an official website?

https://micro.mu/docs/ redirect to  https://github.com/micro/go-micro
Check the examples and plugins - https://github.com/micro/examples & https://github.com/micro/go-plugins. 404
Search existing issues

See https://github.com/micro/go-micro/issues/2723


Add LocalStorage 1.1.0

Set the category to Dash Tweaks, seems like the closest, feel free to suggest a different category.

I specifically didn't put it in the manifest cuz it's kinda jank, but maybe it's fine to go in there now that some time has passed and it hasn't had any major issues yet, would definitely prefer it with some kind of "experimental" flag or warning of some sort that says it's not a perfect solution (it's far from it)
the mod is more useful for peeking at the internal structure of saved items rather than actually keeping items there as a secondary inventory (at least that's how I used it, and I could see potential issues with trying to use it as a more permanent storage method)

Should we add a new flag for experimental or have it as an experimental category (which would be already listed separately on the website)?

it should be a flag, that way pre release versions can be marked as such but future versions will be in the correct category

would now need small changes to the validation json. or treat it more as a prerelease (with prerelease flag) instead (on manifest but not included on nml mod page)

would now need small changes to the validation json. or treat it more as a prerelease (with prerelease flag) instead (on manifest but not included on nml mod page)

That should be done instead of a new flag, as this is exactly what that flag is for according to the website docs:

prerelease Mod dev wants to limit distribution

probably fits better as a technical tweak since it can be accessed externally to the dash

lets reopen this under a branch in this repo


Add ability to explore strategy space.

Hey @vocelik if you get a chance, could you take a look at what I'm suggesting here.

looks great!
On Fri, Nov 25, 2022 at 11:48 AM Vince Knight @.***>
wrote:

Hey @vocelik https://github.com/vocelik if you get a chance, could you
take a look at what I'm suggesting here.
—
Reply to this email directly, view it on GitHub
https://github.com/drvinceknight/evo_gametheory_2022/pull/7#issuecomment-1327317976,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIMCIKHVFLUQLTDTKKFVEITWKCKQHANCNFSM6AAAAAASLF6VFI
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
met vriendelijke groeten,
Vaclav Ocelik


Background classes not being applied

Toast div has no background, rounding classes applied in version 1.1.0. locking package to 1.0.9 fixes this issue.

Seems 1.0.9 does not work in production builds?