MCS-639 image recorder

Added an ImageRecorder class that uses threads and a queue to write images to disk. Pulled out common elements from the VideoRecorder into a base class which will make additional recorders fairly easy to implement if needed.

Do we have a ticket for adding this to the image handlers?

We do not. I wanted to get feedback on this approach before we signed off on further work.

We do not. I wanted to get feedback on this approach before we signed off on further work.

I think its good.  It'd be nice to know how it affects performance, but we may have to mostly implement it to actually find out.


Cutscene help

Describe your problem here.
so maybe you've seen this: https://github.com/ShadowMario/FNF-PsychEngine/issues/4277
and apparently you can do this already. How? any tutorial?
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Yes source and assets

Hide the characters, spawn the cutscene sprites.


Images not being displayed

As visible here, images are not properly displayed, instead the corresponding markup is shown. This might be due to a syntax change, but afaik this used to work.

This was not an issue of sipa, just incorrect syntax in the content (see https://git.agdsn.de/sipa-content/content/merge_requests/22).


Fix #616: Infinite new-process recursion using dub decribe within…

…preGenerateCommands.
I used your DUB_DESCRIBE=package1,package2,... suggestion (although I changed the envar name from DUB_DESCRIBE to DUB_PACKAGES_USED, which I thought was more appropriate internally as this isn't directly tied to dub describe even though that's where the problem manifests).

Just wanted to ping this one. If we could get a DUB beta/RC with this in it, it would be a big help for me.

Why are you trying to block individual projects?
FWIW dub build each dependency and during that invokes their pre-build step, so this shouldn't be a recursive problem and a simple environment["DUB_IN_PREBUILD"] = "1" should suffice.

Why are you trying to block individual projects?

From @s-ludwig in https://github.com/D-Programming-Language/dub/issues/616#issuecomment-120237193

PS: Another idea: add a DUB_DESCRIBE=true environment variable and use that instead. That solves the read-only issue and is easier to implement, but wouldn't work if "dub describe" is used across multiple packages - DUB_DESCRIBE=package1,package2,... should work though.

What I don't like about the PackagesUsed class is that it has global state, but is also used to store temporary state when building up the environment of the child process. What about replacing it by two free functions:
bool isRecursiveInvocation(string pack)
{
    return environment
        .get("DUB_PACKAGES_USED", "")
        .splitter(",")
        .canFind(pack.name);
}

void storeRecursiveInvokations(Environment env, string[] packs)
{
    env["DUB_PACKAGES_USED"] = environment
        .get("DUB_PACKAGES_USED", "")
        .splitter(",")
        .chain(packs)
        .join(",");
}

Those would stay together and provide the same level of encapsulation.

What I don't like about the PackagesUsed class is that it has global state, but is also used to store temporary state when building up the environment of the child process.

Yea, you guys are right, that is pretty ugly. Started going one way with it, then realized temporary state was also needed, and couldn't quite shake the original design from my mind.
The isRecursiveInvocation/storeRecursiveInvokations sounds good, I'll adjust.

Ok, I've changed it to use @s-ludwig's suggestion.

Looks good. Pulling.


Extension (2.4.10+) Crashes on Init when calling DialogueRunner.AddFunction() with an instance method

What is the current behavior?
When DialogueRunner.AddFunction<>() is called with an instance method, the extension crashes during initialization.
Please provide the steps to reproduce, and if possible a minimal demo of the problem:
Include this CustomExtensions.cs in your project
using UnityEngine;
using Yarn.Unity;

public class CustomExtensions : MonoBehaviour {
    [SerializeField] DialogueRunner runner;

    void Awake() {
        if (runner != null) InitializeRunner(runner);
    }

    public void InitializeRunner(DialogueRunner runner) {
        new ScopedExtensions(runner);
    }

    public class ScopedExtensions {
        private DialogueRunner thisRunner;
        public int Sub2(string varA, string varB) {
            thisRunner.VariableStorage.TryGetValue<int>(varA, out var a);
            thisRunner.VariableStorage.TryGetValue<int>(varB, out var b);
            return a - b;
        }

        public ScopedExtensions(DialogueRunner runner) {
            thisRunner = runner;
            thisRunner.AddFunction<string, string, int>("Sub2", Sub2);  // Crashes yarn
        }
    }
}

And a sample yarn file:
title: TestFile
---
<<declare $b = 0>>
<<set $b = Sub2("a", "b")>>
===

Open the .yarn file and observe the following error logs (one in a popup, one in the yarnspinner plugin console): https://pastebin.com/X29QAW6Z
What is the expected behavior?
The yarn extension loads and I can ctrl+click into Sub2 and jump to the implementation
Please tell us about your environment:

Yarn Spinner Version:  2.2.2+git
Extension Version: 2.4.10+
Unity Version: 2021.3.12f1

Other information
https://pastebin.com/X29QAW6Z

I believe this is the same trigger condition as #48, as the .yarn lines logs type checking errors on 2.4.9 and earlier.

I believe this is the same trigger condition as https://github.com/YarnSpinnerTool/VSCodeExtension/issues/48, as the .yarn lines logs type checking errors on 2.4.9 and earlier.

This does not seem to be the case as I was able to get a structure that cmd+click works OK on 2.4.9, but still crashes on newer version.


Optimize endoscopy tool tracking app

Optimize endoscopy tool tracking app
Modify ToolTrackingPostProcessorOp to generate coordinates using
CUDA. This avoids the roundtrip from GPU to CPU memory and back.
Use RMMAllocator for video replayer.
Fix type  of dla_core parameter of TensorRtInference.
Remove unused clock parameter.
Use single out port instead of out_coords and out_mask since
both outputs are now in device memory.
Latency measured with flow benchmarking on x86 with RTX 6000 Ada
and replayer realtimeset to false:
before optimization 4.8 ms, after optimization 3.09 ms.

Thanks, fixed the copyright year. Ready to be merged.


ci(cypress): Add 3DS flow test for connectors

Type of Change

[ ] Bugfix
[ ] New feature
[ ] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[x] CI/CD

Description
Added 3ds flow testcases for adyen,nmi,cybersource,bankofamerica,trustpay connector in cypress.
Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context
3DS testcases were failing in pipeline
How did you test it?
Adyen

cybersource

Bankofamerica

trustpay

Testcases running for entire changes
Cybersource

Checklist

[ ] I formatted the code cargo +nightly fmt --all
[ ] I addressed lints thrown by cargo clippy
[ ] I reviewed the submitted code
[ ] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

🤦♂


Improve antctl get featuregates output

Fixes: https://github.com/antrea-io/antrea/issues/5173
Here are the major changes in this PR:

1.Keep the information about which component is using the FeatureGate in antrea_features.go.
2.For controller and remote mode, get feature gates by reading ConfigMap and include antrea-agent-windows feature gates for improvement.

 We had a new feature gate AdminNetworkPolicy since v1.13, you need also update the feature gate list for this new feature. Don't forget to update the antctl doc  since the print behavior is different now.

Please help to resolve the doc conflicts. We had a new feature gate AdminNetworkPolicy since v1.13, you need also update the feature gate list for this new feature. Don't forget to update the antctl doc  since the print behavior is different now.

update the feature gate list: https://github.com/antrea-io/antrea/pull/5314/commits/5f1a4a7c6c57de348a31df1a07f0723ff6a9b7e7
update the antctl doc: https://github.com/antrea-io/antrea/pull/5314/commits/2566f74a3b0139a62a9ed729d6c48ae5541323a1

Hi @hongliangl @luolanzone, I have addressed all comments, please review them again, Thanks.

@cr7258, there are too many commits in this PR, please help to squash them. The DCO check is also failed, you need to add sign-off-by info in each commit. You can take a look at other PRs to learn how to add DCO info.

You need to rebase this PR.
Tips: when rebasing this PR

Just accept all yaml files from the latest main branch
Run make manifest to update all yaml files.

Done

You don't need to push a comment for every review comment. You could just amend the updates, or commit the updates and squash the commits into one commit. Then you push the new commit with parameter --force to overwrite the remote repo.

I squash all commits.

@antoninbas
The Agent retrieves the agent-config ConfigMap to check if feature gates are enabled or disabled by the user, since the default settings may be overwritten within agent-config ConfigMap. Is there a way to obtain this information without the agent-config ConfigMap?

@cr7258 When you run features.DefaultFeatureGate.Enabled(<name>) in the agent process, it returns true iff if the <name> feature gate is enabled. Isn't it how it was implemented before.
You added features.AgentGates to list all Agent Feature Gates. So I thought you would jut do:
for f, spec := range features.DefaultAntreaFeatureGates {
    if !features.AgentGates(f) {
        continue
    }
    enabled := features.DefaultFeatureGate.Enabled(f) // this will depend on user-provided values from antrea-agent.conf
    // all the information we need is provided by enabled & spec
}

Is that not correct?

@antoninbas  Thanks, it's correct.
But I have a question: when the user runs antctl get featuregates inside the controller Pod or from outside of the cluster, Should it show both agent and controller feature gates or just the controller feature gates?
If we want to display feature gates for both the agent and controller, we cannot get user-provided values for the agent in the controller Pod. The controller pod loads user-provided values from /etc/antrea/antrea-controller.conf, which means it does know the user-provided values for the agent. As a result, when we run antctl get featuregates inside the controller Pod or from outside of the cluster, it always returns the default value for agent feature gates.
If the controller wants to get user-provided value for agent feature gates, it needs to retrieve information from antrea-config ConfigMap. So my idea is to deal with the Configmap consumed by the agent running on the Windows node and provide the same output wherever the user executes antctl get featuregates in the agent/controller/remote mode. IMO, it's no harm to display the Controller Feature Gates when executing antctl get featuregatesin the agent, it means that we don't need to maintain different logic for the agent and the controller.
root@kind-demo:~# antctl get featuregates
Antrea Agent Feature Gates
FEATUREGATE                     STATUS       VERSION
AntreaIPAM                      Disabled     ALPHA
.....

# If agent window configmap exists, display it; otherwise, do not display it.
Antrea Agent Feature Gates (Windows)
FEATUREGATE                     STATUS       VERSION
AntreaIPAM                      Disabled     ALPHA
.....

Antrea Controller Feature Gates
FEATUREGATE                 STATUS       VERSION
AdminNetworkPolicy          Disabled     ALPHA
.....

@antoninbas I would like to include antrea-agent-windows feature gates for controller/remote mode, but I found the Configmap name ends with a random suffix. For example, antrea-windows-config-cb2hmgg648 in v1.13.0, antrea-windows-config-hth2gk6b96 in v1.12.1.
Does this suffix generate by some specific rules? Can I remove the suffix?

@antoninbas I would like to include antrea-agent-windows feature gates for controller/remote mode, but I found the Configmap name ends with a random suffix. For example, antrea-windows-config-cb2hmgg648 in v1.13.0, antrea-windows-config-hth2gk6b96 in v1.12.1.
Does this suffix generate by some specific rules? Can I remove the suffix?

The suffix should be generated by kustomize when we generate manifests.
One possibility is to replace kustromize with Helm to generate the Windows manifests. However, if we go this route, that's a task that should be performed independently of this PR.
AFAIK, the Windows ConfigMap is labelled with app=antrea, and there aren't that many such ConfigMaps. You could list these ConfigMaps, then look for the most recent one whose name starts with antrea-agent-windows.

Hi @antoninbas, I adjusted the code according to your suggestions. Please review again, thanks. Here are the changes:

For the agent mode, get feature gates by features.DefaultFeatureGate.Enabled(<name>) without reading Configmap.
For controller and remote mode, get feature gates by reading ConfigMap and include antrea-agent-windows feature gates.

I tested the changes in my dev cluster, and you can see the output of antctl get featuregates at: https://github.com/antrea-io/antrea/pull/5314#issue-1819559354

The use of keyword "fix" in the PR description of https://github.com/antrea-io/antrea/pull/5433 automatically closed the PR on behalf of me. Please avoid using closing keywords to link issues/PRs in the future if merging a PR shouldn't close the other one.

/test-all

Hi @antoninbas, I adjusted the code according to your comments, please review them again, thanks.

/test-all

/test-windows-e2e

/test-e2e

/test-windows-containerd-e2e

I resolved a small conflict in the Github UI. No need to run Jenkins tests again. Will merge once Go and Kind tests have passed.

/skip-all


Fixed #221 - Image src URLs with spaces in them don't work for fittedImage and croppedImage

The problem was that the native implementations of fittedImage and
croppedImage used CSS background-image, but were not encoding the
URLs before generating the property. This commit encodes the src
parameter using encodeURIComponent, which makes them work correctly.

The best way to deal with such string safety is via the type system. A URL type should be used instead of String for these image source arguments.

The Travis failure, btw, is a failure to install elm-compiler-0.15.

Can you show an example of a "good string" that can be given to these functions that causes an unexpected result?

I'd noted a few in my issue comment here. For example, passing "hello).png" would generate "url(hello).png)" for the "background" property which fails to parse.

I don't really understand what is going on here or what would be good, but the Graphics.* modules have moved to evancz/elm-graphics so it makes sense to retarget stuff like this.

Oh, I get it from the last comment. The change in the one file makes sense, but the other one is weird.


empty workspaces do not need codelyzer rules

🐞 Bug report
Command (mark with an x)
- [X] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Description
When creating an empty workspace, the recommended codelyzer rules should not be templated into the workspace's root tslint.json.
🔬 Minimal Reproduction

ng new repro-app --create-application=false
/repro-app/tslint.json should not contain codelyzer specific rules.

Desired Functionality
Move codelyzer rules to the tslint.json templates in the application & library schematics.

Hi, can you kindly explain the reasoning behind this request? An Angular workspace will eventually contain a library or an application.
Having them in the root tslint.json is the ideal way to ease maintenance and avoid having rules spread among various files.

Hi, can you kindly explain the reasoning behind this request? An Angular workspace will eventually contain a library or an application.

@alan-agius4
I'm currently working on a reponse, I just didn't want the idea to be dismissed because I failed to properly make it's case.  I'll post it shortly...

TL;DR: Its seems like a code smell that, after specifically choosing ng-new --create-application=false to move my app out of the root folder that the schematic should create application/library specific rules in the root tslint.json when there are no applications or libraries yet.

moves rules next to existing codelyzer  directive-selector & component-selector rules
increases encapsulation and separations of concerns
(potentially) makes it possible to have one sub-project stay on legacy rules & linter
(potentially) while newly generated subj-project uses newer linter and recommendations

"Having them in the root tslint.json is the ideal way to ease maintenance and avoid having rules spread among various files."

While admittedly opinionated, I feel like the root tslint.json should be for tslint:recommended overrides and those settings the user deliberately decided need to be applied to all projects in his multi-project mono-repo.  I believe that it would be good code-stewardship to take on the burden as contributors of maintaining unit recommended rule lists for each applicable schematic and applying them to those templates to help guide users into the good programming habit of keeping their configurations as close to the code they cover.
Granted, in the default case where createApplication=true this is somewhat of a moot point because there exists and application on the same level as the root tslint.json However, I believe that it would be better code-stewardship if we encouraged users to configure their sub-projects as encapsulated as possible.
In fact, the Angular Guide -> Multiple project file structure implies that using createApplication=false should limit the root to workspace related configurations.

While I do agree that separation of concern is good and is the right approach. I personally don't feel that splitting the tslint rules fits in this, similarly to tsconfig.json. For these files we should use configuration inheritance to avoid unnecessary maintenance and also miss configurations. Since the more files you need to keep in sync, the greeter the room for error.
The codelyzer settings that are defined in root tslint.json are the recommended settings for all the projects within a workspace.  I'd argue why a user would want different configurations per projects apart from the overrides that are needed for component and directive selector naming. I don't see it as a good practice to have different rules per projects since as all projects within a workspace one should have a consistent coding standard and hence share the same tslint rules.
I am going to put this up for discussion in our next team meeting.

Hi, we just discussed this in our team meeting and we believe that using inherence for tslint.json is the right approach, as per explanation in the above comment.
Thanks.


BrowserLink removes the If-Modified-Since request header

Here's a weird one, it took me a while to get to the bottom of it:
It seems that when I have a UseBrowserLink middleware and start the project in Visual Studio with BrowserLink enabled, the If-Modified-Since header is removed from the request.
Here's a minimal repro:
public class Startup
{
	public void Configure(IApplicationBuilder app, IHostingEnvironment env)
	{
		app.Use((ctx, next) => {
			// it's OK here...
			Console.WriteLine("before BL: " + ctx.Request.Headers["If-Modified-Since"]);
			return next();
		});

		app.UseBrowserLink();

		app.Run((ctx) => {
			// ...but not here
			Console.WriteLine("after BL: " + ctx.Request.Headers["If-Modified-Since"]);
			return Task.CompletedTask;
		});
	}
}

The problematic request goes like this:
curl -X GET \
  http://localhost:5000/ \
  -H 'if-modified-since: Tue, 14 Aug 2018 15:43:00 GMT'

Program.cs is standard (based on a dotnet new web template. I'm using Microsoft.AspNetCore.All 2.1.2 package.

That seems to be intentional:
https://github.com/aspnet/BrowserLink/blob/9bcd585848009088551999b35a807318c28cf7d0/src/Microsoft.VisualStudio.Web.BrowserLink/BrowserLinkMiddleWare.cs#L54
BrowserLink modifies responses inline so it needs to disable caching.


Hover Menü

Hello,
how can I make a Off Canvas Menü on hover, not on click like http://feedly.com?

Feedly does not use Sidr. It uses simple css to achieve the functionality.
Feedly does not use sidr to achieve that functionality. It is simple css.
http://codepen.io/gorkhali/pen/myoowx
I have tried the same using sidr.
http://codepen.io/gorkhali/pen/bNZZLz
Though I am not completely satisfied with it.

Yes you can add the option with JS
$('#whatever').hover(function () {
    $.sidr('close', 'sidr-main');
});


New package: OpenBLAS32 v0.1.0

Registering package: OpenBLAS32
Repository: https://github.com/JuliaLinearAlgebra/OpenBLAS32.jl
Created by: @ViralBShah
Version: v0.1.0
Commit: 0eddf81709f8632b4e838d5bea41aa95321ded42
Git reference: HEAD

Interesting, I created this two years ago: https://github.com/giordano/OpenBLAS32.jl 😅
[noblock]

I was wondering if someone might have done it but a google search didn't find much (or I didn't look past the first obvious results).

Anyway I like this one better, as it checks OpenBLAS32_jll.is_available() && Base.USE_BLAS64 👍
[noblock]


Remove download button on classification videos

Videos in classification now have a "download" button on the player toolbar that we would prefer not be available to volunteers.  Is it possible to revert back to how it was, or hide this new button somehow?
It only seems to appear in Chrome (not IE or Firefox) and only on the classification video player, not on the individual subject videos.  If it helps, I'm using Chrome Version 55.0.2883.87 m on a Windows PC.  A screenshot of the new button is below.  It's on the far right.

Thanks!

@ksigler The update to Chrome version 55 added this button to the native video controls UI. I can use some hacky CSS to essentially hide it from view, but this causes an unintended side effect in Safari where its full screen button is pushed off to the side:

This button doesn't really add new functionality. Users could always download the videos using the right click context menu. This change just makes it a bit more obvious. Hiding it with CSS should only be seen as a temporary action since the pseudo-classes I can target may change or become unavailable in the future. I'd suggest the science team discuss what they want to do and reply to let me know if they want me to hide it (and if the odd display in Safari is ok).
As an aside, with the update in version 55, lots of users and developers have complained, so Google is discussing having a way to actual disable the download feature, but there are no guarantees it'll change: https://bugs.chromium.org/p/chromium/issues/detail?id=650174

Thanks, @srallen !  That's very helpful to know that there is a discussion about removing it.  I'm a slow upgrader for this very reason!  I'll make sure the science team gets this information so they can decide what to do.  Do you happen to have any analytics on what devices/browsers most people are using (this would answer a few of our recurring questions)?

Here are the ton ten for browser, OS, and device on google analytics:

Spoke with Mimi and she's on board with hiding the download button as a temporary fix.  If Google presents a better solution, or it turns out that it causes any other significant issues, then we should revert.  Does that work for you guys?

I've deployed the CSS hack, so the button is now hidden. I've starred that open issue with Google, so I should get emailed whenever there is an update. Hopefully Google prioritizes the issue.

Wonderful, thank you for helping us with this!

Noting here that Google added support to disable the download button for HTML5 video and audio in version 58: https://developers.google.com/web/updates/2017/03/chrome-58-media-updates#controlslist
We should update to use this instead of the hacky workaround I put in place once we see most of C&S chrome users move to version 58.


Storing Email and Password Centrally

Suggestion.
Would it be possible to create / use a global configuration node to store TPLink email and password once for use by all nodes and flows ?

Thank you for your wonderful suggestions.
This suggestions is technically possible.
I consider this suggestions.


Error using in latest angular cli

I have following versions:
@angular/cli: 1.4.7
node: 6.11.2
os: darwin x64
@angular/animations: 4.4.2
@angular/common: 4.4.2
@angular/compiler: 4.4.2
@angular/core: 4.4.2
@angular/forms: 4.4.2
@angular/http: 4.4.2
@angular/platform-browser: 4.4.2
@angular/platform-browser-dynamic: 4.4.2
@angular/router: 4.4.2
@angular/cli: 1.4.7
@angular/compiler-cli: 4.4.2
typescript: 2.5.2

I did the following in the project root:
$ ng new codelyzer
and it gives me the following error
You cannot use the new command inside an Angular CLI project.

This doesn't seem an issue related to codelyzer.  Can you please guide me to doc for setting it up for existing angular-cli project?

You can take a look at the Angular CLI repository.


After login user gets initially redirected to /code

Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[x]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[x]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Framework

[x] Angular
[ ] React
[ ] Other

Description
After a successful login, I get redirected to my application and in case of local development to:
http://localhost:4200/#/code
This means I come from localhost:4200/#/home ->microsoft.com -> localhost:4200/#/code -> localhost:4200/#/home, whereas localhost:4200/#/code does not exist and lead to my "Not Found"-page ({ path: '**', component: NotFoundComponent }).
I got hash routing enabled and sometimes when the redirect is too slow my application tries to find the route /code which obviously does not exist. When it is fast enough then the user actually doesn't see the intermediate redirect to /code because after a short time the user gets then redirect to the original page.
I am using the recommended approach with the provided RedirectComponent.
Error Message

No real error message, just the intermediate redirect to the route /code after a successful login
MSAL Configuration
// msal instance config
auth: {
      clientId: 'xxx',
      authority: `https://login.microsoftonline.com/xxx/`,
      redirectUri: window.location.origin,
      postLogoutRedirectUri: window.location.origin,
      navigateToLoginRequestUrl: true
    },

All other properties dont matter and are default settings.
Reproduction steps

Setup default configuration like described in the Angular 11 sample application
Use login redirect as an auth request
Add MsalGuard to all your routes to ensure an automated login
Enable hash routing
Access your website and observe the following behavior:

Visit e.g. localhost:4200/#/home
Redirect to microsoft and login
Redirect to localhost:4200/#/code=xx
Redirect to `localhost:4200/#/home

Expected behavior
I thought the RedirectComponent is responsible to handle the redirects. Therefore, I would either expect that the navigation to /code  is handled by the component and the user does not see any real routing to this (in my case it would lead to a short view of the not found page as this route does not exist) or that the received code is put as a query parameter like localhost:4200/#/home?code=xxx.
Am I missing something in the configuration or did I something wrong?
Identity Provider

[x] Azure AD
[ ] Azure B2C Basic Policy
[ ] Azure B2C Custom Policy
[ ] ADFS
[ ] Other

Browsers/Environment

[x] Chrome
[ ] Firefox
[ ] Edge
[ ] Safari
[ ] IE
[ ] Other (Please add browser name here)

Regression

[ ] Did this behavior work before?
Version:

Security

[ ] Is this issue security related?

Source

[ ] Internal (Microsoft)
[x] Customer request

@sidyes When using hash routing, we recommend adding a code route to your app-routing.module.ts, as sometimes Angular tries to route to /code= before MSAL has had a chance to handle the redirect, as you have experienced. Adding the code route prevents it from ending up in you ** route. You may also wish to add an error or state route for the same reason.
Please see our samples here and here for examples of this use.

@sidyes When using hash routing, we recommend adding a code route to your app-routing.module.ts, as sometimes Angular tries to route to /code= before MSAL has had a chance to handle the redirect, as you have experienced. Adding the code route prevents it from ending up in you ** route. You may also wish to add an error or state route for the same reason.
Please see our samples here and here for examples of this use.

Thanks for this hint, I will use this. But is there anything planned to better support hash routing in the future instead of defining all possible routes?

@jo-arroyo
Short Update:
I secured each route with the MsalGuard. Thus, when defining the routes for code (and error and state) I will end up in an endless loop.
So what is the best way to enable automated login (securing all routes with the provided guard) as well as preventing the visible redirects to for example /code?
Your solution does only work when the provided component for these routes is not secured by the MsalGuard.

Any help/recommendation for this problem @jo-arroyo  @jasonnutter ?

@sidyes Apologies for the delay in responding.
I can't reproduce the infinite loops, as this was fixed in the latest version of MSAL Angular, I believe. What I can reproduce is that when using hash routing, if the MSAL Guard is put on the code route, if the user is not logged in and attempts to navigate to another protected route (e.g. /profile), after logging in they end up on the code route, instead of the page they were navigating to.
It is not clear right now why this is happening, but our recommendation would be to not put the guard on any of the placeholder routes (e.g. /code, /error, etc) when using hash routing, as that appears to mitigate the issue.

So what is the best way to enable automated login (securing all routes with the provided guard) as well as preventing the visible redirects to for example /code?

When using hash routing, we can't do anything about the visible redirect to teh /code route, given AAD returns the auth code response in the hash, which triggers the Angular router. We will investigate the issue described above and see if we can provide a fix so that the user ends up on the correct page (given the endless loop issue should already be fixed).


DMP-3028 - Type subtype validation on add event mapping

https://tools.hmcts.net/jira/browse/DMP-3028

[X] commit messages are meaningful and follow good commit message guidelines
[X] README and other documentation has been updated / added (if needed)
[X] tests have been updated / new tests has been added (if needed)
[ ] Does this PR introduce a breaking change

@DavidTMann can you fix conflicts please


Use hypothesis.assume to avoid close quantiles

In the fuzzy testing, we basically reformulate the previously made requirements (like x0 > x1) properly using hypothesis.assume.

The pull request is OK from my point of view.


Gist instances have no labels

None of the 17 gist 9.4 individuals have a label (nor a comment).
Propose we add labels and comments to these, per good practice.

Good idea.  This could be done in conjunction with moving gist to our standard namespace convention, per issue https://github.com/semanticarts/gist/issues/305

Submit one PR for #370, #526, and #556.


no_proxy is not respected during index searches

SUMMARY
This isn't exactly a bug (kinda?) but maybe a solution to consider in how implement this.
Basically no_proxy is ignored during pack index searches.
https://github.com/StackStorm/st2/blob/15dcd3b3642e3a6af0dc82f2b746d98fa46467fa/st2common/st2common/services/packs.py#L74-L84
This makes obvious sense because if you're behind a proxy you want to be able to search the st2 Exchange Index. The issue comes in when you have a local index like I do. The local index is hosted on our controller node and the proxy doesn't have access to this URL due to FW rules. Proxy isn't local to the datacenter either. So because no_proxy isn't respected in an index search my custom index is unreachable.
To further complicate things, I also search the Exchange Index, meaning I have specified both internet based and a local based index. The internet based obviously needs to go though the proxy, but the local based one can't.
The only real way to by pass this at this point is to specify our internal git URL directly and the pack will install since its not searching the index.
Not sure if anyone else has this issue, it might be extremely specific to me with our locked down environment.
STACKSTORM VERSION
Paste the output of st2 --version:
st2 3.6.0, on Python 3.6.8
OS, environment, install method
3 node HA cluster: 2 nodes, 1 controller all three behind a load balancer

#5500


Update version.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.53%. Comparing base (8a8fcd8) to head (1fb9632).
Report is 2 commits behind head on 0.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              0.2    #4358      +/-   ##
==========================================
+ Coverage   29.30%   29.53%   +0.22%
==========================================
  Files         117      117
  Lines       13013    13017       +4
  Branches     2469     2470       +1
==========================================
+ Hits         3813     3844      +31
+ Misses       8854     8826      -28
- Partials      346      347       +1

Flag
Coverage Δ

unittests
29.53% <100.00%> (+0.22%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


test for lone-schema-definition rule

test for issue: https://github.com/dotansimha/graphql-eslint/issues/406

Fixed 🎉 Like we had with unique-type-name, this should use validateSDL


kubernetes pods' restart count

Hello, guys!
is it possible to get pods' restart count metrics via heapster?
i can't really find anything related neither in docs nor in code

No, that's not a metric that Heapster exports.  Please see https://github.com/kubernetes/kube-state-metrics for metrics like that.


Change/bert encoder public

Hello,
I've slightly modified some of the bert components, specifically making the BertEncoder public, so that it can be used on it's own as part of other models. I have implemented a pytorch model in candle, which the pytorch model imports the BertEncoder from the equivalent transformers module. So to implement the candle version, I needed to make the BertEncoder public.

Thanks!


Update .zuul.yaml with correct job name

Signed-off-by: Melvin Hillsman<EMAIL_ADDRESS>

recheck

recheck

@dims @hogepodge apologies I do not know the correct workflow to get this merged but I have confirmed this change is needed; also note theopenlab-ci bot replies NODE_FAILURE then SUCCESS

@mrhillsman the commit has "[DNM]", want to remove that? (looks like PR title you fixed already)

/ok-to-test

@dims commit message updated, thx

/approve

/lgtm


Redundant tests for the first/last operators

Whilst fixing the typing problems in the test suite, I found a seemingly redundant test for the first operator:
it('should support type guards without breaking previous behavior', () => {

first does not accept a used-defined type guard, so the test does nothing. Indeed, it will fail once type checking is enabled for the test suite.
Whether or not the test should be removed or the signature of first should be modified to accept a user-defined type guard, I don't know. Hence the opening of this issue.

There is a similar problem with last.

Yeah, it just looks poorly written. We do need to make sure that type guards work with operators like first, last, filter, etc.

I'll come back and fix these up, then, once the test suite is type-checked. Some overload signatures will need to be added for the type guards to effect narrowed observable types.


Mapping in one entity from different dictionary

Hi! Tanks for library. This is question, not issue
Can i get data from json dictionary and subdictionary for one entity?
i need one object
@property (nonatomic, retain) NSNumber * id;
@property (nonatomic, retain) NSString * name;
@property (nonatomic, retain) NSNumber * parent_id;
@property (nonatomic, retain) NSNumber * hobby_id;
@property (nonatomic, retain) NSNumber * user_id;
i have this json
userHobby =     (
                {
            hobby =             {
                id = 3838;
                name = Xbox360;
                "parent_id" = 7;
            };
            "hobby_id" = 3838;
            "user_id" = 58;
        },
                {
            hobby =             {
                id = 1025;
                name = "Funk Music";
                "parent_id" = 1;
            };
            "hobby_id" = 1025;
            "user_id" = 58;
        },
                {
            hobby =             {
                id = 19855;
                name = Snowboarding;
                "parent_id" = 4;
            };
            "hobby_id" = 19855;
            "user_id" = 58;
        }
    );

Sure! since we do mapping using KVC, you simply can do this:
[mapping<EMAIL_ADDRESS>toProperty:@"hobby_id"];


backups are now idempotent so warning is no longer needed

Backup idempotency was fixed as part of #57892 and so this comment is no longer accurate

@rail apologies for the new PR, fixed your comments here, thanks!

No worries at all. Thank you for the contribution!


Debug working for nvhpc on Phoenix?

With @haochey PR we have this change
    if (CMAKE_BUILD_TYPE STREQUAL "Debug")
        add_compile_options(-C -g -Og -traceback -Mchkptr -Mchkstk -Minform=inform -Mbounds)
        add_compile_options(-C -g -traceback -Mchkptr -Mchkstk -Minform=inform -Mbounds)
    endif()
endif()

which removes the -Og from compile debug options and enables debug mode to run on GPU. If confirmed again to work now, we should add this to the CI as another test for the Phoenix runner (both CPUs and GPUs hopefully)

I had suggested this to @haochey. I believe that in recent NVHPC builds, no change is necessary for MFC to build in debug mode.

Ok just have to see whatever is available on Phoenix.

This is seemingly not working on Phoenix. -Og and -O0 both don't work when compiling with --debug --gpu on Phoenix with NVHPC22.11. Same errors are before.

This issue is being merged into the more targeted https://github.com/MFlowCode/MFC/issues/237


Add python api for optimize

[x] Unit tests
[x] Documentation

Description

Adds optimize command to the Python API.

New class in tables.py:  DeltaOptimizeBuilder
New method: DeltaTable.optimize

Resolves https://github.com/delta-io/delta/issues/1080
How was this patch tested?

Added new unit tests to test_deltatable.py:

test_optimize
test_optimize_w_partition_filter

Does this PR introduce any user-facing changes?

No

@burakyilmaz321 Thank you for the PR. This is very good! For tests, you can look at the the examples here.

@vkorukanti Added unit tests and documentation. Since the Scala API is not added yet, tests are failing here. But, I merged https://github.com/delta-io/delta/pull/961 with my changes in another branch, just to see that unit tests are passing. You can see here the unit test checks are successful.

@burakyilmaz321 The python test failures on master branch are fixed now. Could you please rebase this PR? Thank you!

@burakyilmaz321 The python test failures on master branch are fixed now. Could you please rebase this PR? Thank you!

Sure, I will do that as soon as I reach my laptop later today.


Releases page can take forever to load when there are loads

We DO NOT take questions or config/deploy problems on GitHub, please use our forum: https://discuss.gogs.io
Please take a moment to search that an issue doesn't already exist.
For bug reports, please give the relevant info:

Gogs version (or commit ref): latest
Git version:
Operating system:
Database:

[ ] PostgreSQL
[x] MySQL
[ ] SQLite

Can you reproduce the bug at http://try.gogs.io:

[x] Yes (provide example URL)
[ ] No
[ ] Not relevant

Log gist:

Description
I've just created a mirror repository for the rails repo and upon viewing the "Releases" tab, it takes forever to load, sometimes not loading at all. Maybe Gogs should only show the first 10 and paginate the rest? You can see it here - https://try.gogs.io/deanpcmad/rails

162 seconds to load the Releases-page is waaaay too long :laughing: The underlying problem is related to two different issues, one being pagination (#2164), the other one being fetching commit-count is hella-slow (#3022)
#2164 is claimed to be worked on (though that was over a month ago), #3022 is still being debugged.

Ha yeah, it does take a while! I'll wait to see. I only setup Gogs over the weekend and I love it already! It's pretty awesome and it runs great on a 512MB DigitalOcean server 😄

Also, might wanna change the Title to "Release page loads slow with many tags" (so it all fits ^.^ )

Actually I'm closing this as a duplicate of #2164, it also mentions a fix for it :smiley:
Opening Issue #2164:

This lack of pagination causes the relases page to hang for several minutes.


Font, Effect and Mesh loaders take a filesystem::path as a parameter but use ResourceFinder which returns a optionalfilesystem::path

It should probably offer both a path with optional and a throwing path, with distinct method names.


Add single line option to input

Version 2.0 is under development as a rewrite, so this will no longer be applicable.


Read-Only Columns Can Still be Edited

PR #297 for Issue #275 seemed to introduce this bug. Because the read-only flag does not discard the mouse-down event it will continue to allow edits of the cell.
Reproducing Steps:

Add Modbus Module to DCAF editor
Add new channel
Attempt to change Data Type directly from table
Open Define Columns.vi to find that the Data Type column is set to read-only

Cells only seem to be editable when left-clicked and the row is already active. A simple workaround may be to discard the event if the cell is read only and the row is already selected.


possible to use different map projections?

Great package! I just discovered your work today from reading this blog!
Is it possible to use a different Mapbox GL JS map projection such as Albers? And can you render projected layers on top of the projected basemap?
Thanks!

Great package! I just discovered your work today from reading this blog!

Thanks!

Is it possible to use a different Mapbox GL JS map projection such as Albers?

This is disabled currently, since I've not explored how to do this:

And can you render projected layers on top of the projected basemap?

Projected deck.gl layers might be doable (or even simple) with interleaved rendering (planned).
What {rdeck} maps with different projections will currently look like:
sa1s <-
  strayr::read_absmap("sa12016") |>
  dplyr::mutate(
    position = rdeck::xy(cent_long, cent_lat),
    val = runif(dplyr::n() * as.numeric(state_code_2016)) |>
      round(2)
  )

map <-
  rdeck::rdeck(initial_bounds = wk::wk_bbox(sa1s$position)) |>
  rdeck::add_scatterplot_layer(
    data = sa1s,
    radius_min_pixels = 5,
    get_fill_color = rdeck::scale_color_linear(val)
  )

# HACK: change projection
map$x$mapgl$projection <- "albers"

# render
map

This is awesome!
If there a way to get the basemap to align with those points?
Can you do this albers projection with a raster?
For some some context, I have only built web maps using leaflet and have been searching for a way to have a projected raster (or tiles) not in web Mercator overlay a projected basemap not in web Mercator.

The deck.gl map controller only supports web mercator, so the example above has very weird behaviour for the basemap and isn't usable with or without data.

If there a way to get the basemap to align with those points?
Can you do this albers projection with a raster?

Maybe. Exploration needed to know for sure.
I think first steps are to pivot to MapboxOverlay api which makes the mapbox basemap the controller. That would make the basemap behave correctly, also allows for simple switching between interleave/overlay modes. Deck.gl layers working with different mapbox projections is an unknown.


feat: add setting to disable zwave-js-server DNS-SD

As discussed, adding a new option that can be passed into to zwavejs2mqtt to disable DNS service discovery in zwave-js-server. This option is primarily to be used by @Frenck's Home Assistant addon for zwavejs2mqtt: https://github.com/hassio-addons/addon-zwavejs2mqtt
With that being said it can be used by anyone if desired. I also bumped zwave-js-server to 1.16.0 (which is needed for the new server option) and zwave-js to 9.0.1

Hi @raman325 , thanks for the PR, I was bumping zjs and zjs server locally so I have also added this changes to that commit (there were some conflicts after the bump if I would have merged this). I have also added an hidden input so the setting doesn't disappear after a save. I wonder if it makes sense to create a visible input for this or not? Just in case any user could need to edit it without pointing him on manually edit settings json file

Thanks for the tip, wil add that on the hint :)


Adding UUID to Str class

http://stackoverflow.com/a/23016381/673617 - we really need it

There's a great package here:
https://github.com/ramsey/uuid

nice package, but UUID is a core for a lot of projects.. so i hope those functions will be included

That's why we have composer, so we don't have to reinvent the wheel over and over again.

hmm...ok

Adding this would be a misuse of the str class. It is for manipulating strings only.


not obeying windows key map

VSCode Version: 1.28.2
OS Version: Win 10

Steps to Reproduce:

Remap caps lock to ctrl key in windows registry
Capslock (as ctrl) no longer works in VS Code.

Does this issue occur when all extensions are disabled?: Yes
This has been working since the first day I started using VS Code. I think the last upgrade broke it.

Someone has also reported a possible duplicate.
https://github.com/Microsoft/vscode/issues/61762
I noticed I can use ctrl-key in some areas of the application but Ctrl + / does not work. I'm trying to figure out if the issue is specific to me or what. I'm going to try on another computer tonight.

I figured it out. Comment only works in some files. I can't seem to fix my issue because there is no way to specify a language identifier for files without extensions.


Config to change the strength of the magnets

Nice mod you got here (I think what the ringlings said explains our thoughts on it best), though one thing we would like to personally see is the ability to change the strength of the lodestones and netherite magnets

Modifying the strengths of the blocks can be done through a datapack by modifying data/attraction/attachments/minecraft/block/magnetic_block.json
The netherite block has a default value of 9.0 using this method here


Wrong reference to SSL profile

Environment
I have problem with 1.12 and 1.11 version of the ACC and possibly also previous ones.
Converting bigip.conf.txt
Results with a Virtual server with wrong reference to the profile.
Inside the configuration, VS is in partition "tenant2" and the SSL profile is placed inside /Common/Shared tenant.
Unfortunately, the reference from VS to the profile does not include "/Common/Shared" prefix:
    "tenant_2": {
        "class": "Tenant",
        "application_2": {
            "class": "Application",
            "template": "generic",
            "VS_app2": {
                ...
                "class": "Service_TCP",
                "serverTLS": "custom_ssl_client_profile",
                "clientTLS": "custom_ssl_server_profile",
 ...
   "Common": {
        "class": "Tenant",
        "Shared": {
            "class": "Application",
...
            "custom_ssl_client_profile": {
                "certificates": [
...
            },
            "custom_ssl_server_profile": {
                "clientCertificate": [
...

Expected behaviour would be to reference serverTLS and clientTLS with full prefix:
    "tenant_2": {
        "class": "Tenant",
        "application_2": {
            "class": "Application",
            "template": "generic",
            "VS_app2": {
                ...
                "class": "Service_TCP",
                "serverTLS": "/Common/Shared/custom_ssl_client_profile",
                "clientTLS": "/Common/Shared/custom_ssl_server_profile",
 ...
   "Common": {
        "class": "Tenant",
        "Shared": {
            "class": "Application",
...
            "custom_ssl_client_profile": {
                "certificates": [
...
            },
            "custom_ssl_server_profile": {
                "clientCertificate": [
...

@makagonr everything is good except for
"custom_ssl_client_profile": {
                "certificates": [
                    {
                        "certificate": "/Common/Shared/custom_ssl_cert_key"
                    }
                ],
                "class": "TLS_Server",
                "insertEmptyFragmentsEnabled": true
            },

I am going to request DEV remove the /Common/Shared/. Should be
            "certificates": [
                {
                    "certificate": "/Common/custom_ssl_cert_key"
                }

Add CHARON-300 in in-play for PD to pickup. Possible ACC 1.13 release. Please watch the milestone

@mdditt2000 This reference is to AS3 object, so it needs to be "/Common/Shared/custom_ssl_cert_key", the certificate object itself, can refer to bigip cert object using "bigip": "/Common/cert..."

Issue resolved in ACC 1.13


Chapter 14, reading file not working (gives 0ms instead of 1000)

Chapter 14, reading file not working (gives 0ms instead of 1000)
Is there some code missing? I see in your video, you're fiddling with some extra code
https://youtu.be/5v5A3j7Rrco?t=826

Changing while to if seems to fix it
//Read the configuration information (speed.txt)
File commandFile = SD.open("speed.txt");
if (commandFile)
{
Serial.println("Reading Command File");
if (commandFile.available())
 {
   refresh_rate = commandFile.parseInt();
   //refresh_rate = 1000;
 }
 Serial.print("Refresh Rate = ");
 Serial.print(refresh_rate);
 Serial.println("ms");
 commandFile.close(); //Close the file when finished

}
else
{
Serial.println("Could not read command file.");
Serial.print("Will use default refresh rate of ");
Serial.print(refresh_rate);
Serial.println("ms!");
}

@avlap The video you posted is from a 2011 tutorial. The methods for reading numbers from files has improved dramatically since I first posted that video. That is why the code from the book is different (and shorter). The parseInt() function basically does everything that previously had to be done discreetly to get an integer out of a text file.
The original while() that my code has should work as long as the refresh rate value is the ONLY thing you have written in that file, as is described in the book. The parseInt() function will read digits until it encounters a non-digit. That non digit should be the end of the file. I suspect the reason it didn't work for you is that you have a newline after your refresh rate entry. Because of that newline, the file stream still has "available" content and the while loop executes again. When the while loops executes a second time, it looks for integers that occur on the line after your first line. It fails to find any in the timeout window, and returns a zero instead (you can see on the documentation page that a zero will be returned if an integer is not found): https://www.arduino.cc/en/Reference/parseInt
Your approach works as well. By changing to an if() statement, you made it so that the parseInt() will only run on the first line of the file and then use that value, ignoring any newlines or other data that you might have in the file after the first integer.
I will close this ticket, but feel free to re-open if you have further questions!


feature: runtime luis settings refactor

Description

remove luis settings adapter, use customized composer luis settings extensions to load luis settings, previously there exsits a temporary work around which is adding "region" to replace "luis:region", adding "environment" to replace "luis:environment". now remove that implementation.
remove appsettings.deployment.json and appsettings.development.json, just keep single 'appsettings.json' instead.

Task Item
#minor

Screenshots

Coverage remained the same at 53.233% when pulling a0243da122ca9b8c3d89e7df7131ac89e7f3d87c on qika/settingsRefactor into 53178da4a758fc02a0a49c86755ce8c388f18da7 on main.

The changes to the way the settings file are handled may be in conflict with changes made in the wenyluo/jsRuntime branch.  In this branch, we have already changed how the settings file is written. We should make sure these changes are not in conflict!

Does this change the form of the configuration? Will previously created publishing profiles break?

Since some comments are based on the jsruntime branch changes, and many things (botProjectDeploy.ts) have been changed on jsruntime branch, I will recreate a pr based on jsruntime branch.


angular/cli

I got an error while installing angular js file i.e, angluar/cli when i gave the command "npm install @angular/cli"
npm ERR! Unexpected end of JSON input while parsing near '...9852a748cb8a6954d3c41'
npm ERR!      C:\Users\Ankith-Poojary\AppData\Roaming\npm-cache_logs\2018-02-21T15_52_13_193Z-debug.log

I think you're having some weird errors and can't debug it, and so, understandably, you're frustrated. But this is a tracker for bugs and feature requests. If we can we also try to help with support requests. We're very lucky to have awesome community members that also spend time trying to help people here in the issue tracker.
But we can't really help much at all if you don't fill in the issue template. I read your issue and have no idea what's going wrong and how to help you. And when other users search the issue tracker and see your issue, it also doesn't help them.
So I think the best thing to do is to close this issue, and ask you to open a new one. In that new one please fill in the issue template and give us an idea of what's happening and how to reproduce it. That way we'll have a chance to help you.


ToolBox Addition: IVolatility equity and options converter

Just want to get the conversation going on IVolatility data source converter. I already started some preliminary work but there are a few questions that come up. I only have minute equity and options data so that's the timeframe I will be implementing and testing at.
Their data comes in gzipped CSV, with underlying type (index, stock, etf), price bid, price ask, price last, date_bid, date_ask, date_last, size_bid, size_ask, size_last, exchange_bid, exchange_ask, exch_last, volume, row per minute. Not split and dividend adjusted (but dividend, corp actions, interest rate, etc) data is provided for each trading day.
Options are pretty much identical but also come with greeks and IV, type, expiration, etc.
I had a look at the Algo Seek implementations but a couple of questions come up:

How to handle the stock adjustments, should I be importing the splits and dividend data somewhere or use another data source for that?
Since the data is bid/ask I assume we need to dump to QuoteBar, however that needs OHLC, but we only have 1 value, should I just replicate that 4 times, or there's another approach to take here?
Any way to save the IV and greeks, similarly to how open interest dedicated file is generated per day, so those are not regenerated every time?

The equities importer is pretty much done. Just one clarification, seems that Lean has a Symbol which is fixed combination of ticker, security type and exchange. But exchanges for tickers of the same type change historycally, for example since I'm testing everything for the SPY it shows the following:
3,NYSEAN,NYSE Alternext Equities
29,NYSEArca,NYSE Arca Options

627,1999-01-04,SPY,SPDR TR UNIT SER-1,3,IPO,2009-02-23,2009-02-24
627,2009-02-24,SPY,SPDR TR UNIT SER-1,29,Rn,2010-01-27,2014-10-07
627,2010-01-28,SPY,SPDR S&P 500 ETF Trust,29,Rn,2079-06-06,2014-10-07

Basically meaning the Symbol was on a different exchange from 1999-2009 and then the name changed a couple of times.
None of this seems to have big implications on trading so I assume we can just set to the latest, but something to keep in mind.

Also planning to add FactorFileGenerator implementation as part of the importer for Ivol since they provide those in a nice csv format that's already synced with the rest of the data, so it's easier to use theirs than Yahoo's. I will update the ticket and the PR when that's done.

Thank you Feras,
The exchange in this case would be "usa"; its a market field which is used
to distinguish fungible assets.
On Feb 3, 2018 17:46, "Feras Salim"<EMAIL_ADDRESS>wrote:

Also planning to add FactorFileGenerator implementation as part of the
importer for Ivol since they provide those in a nice csv format that's
already synced with the rest of the data, so it's easier to use theirs than
Yahoo's. I will update the ticket and the PR when that's done.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/QuantConnect/Lean/issues/1490#issuecomment-362861678,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACI6mYtAxV0hSSzuheSIfwCLzeRmGHWuks5tROGygaJpZM4RjqNr
.

Thanks.
Factor support is pretty much done, but there's one main issue. FactorFileGenerator has a method called ReadDailyEquityData, which assumes you have generated daily data, even though we already have minute data. How would you recommend to go about that, regenerate factors after we generate all minute data, then downsample to daily resolution and then build factors, or refactor the FactorGenerator to add support for lower res data.

@jaredbroad Just wondering if you had any thoughts on that one ?

@feribg -- I believe all we really need is the previous day's closing price. We could abstract this away from the generator via an IClosingPriceProvider or similar. The implementation could decide how to fetch the closing price for a particular date. In your case, it could search through the minute data to find the closing price (time stamp in file would be 3:59PM since start times of bars are in the file).
If we end up providing this abstraction, please submit this as a separate, isolated pull request.

@mchandschuh Got it, thanks! I finalized the current PR, I will make this and the Factor generator as a separate PR to come.


Add CSRF token to ajax request. Fixes: divio/django-cms#1906, ...

...and fixes divio/django-cms#1988

If someone else is having this bug, deleting cookies might help.


Initial work on integrating the mobile_app component.

Initial work on getting the app registered with Home Assistant.
https://github.com/home-assistant/home-assistant-android/issues/5

Hopefully I'll have some time tonight to address the comments.

@CedrickFlocon I think I addressed all the comments for real this time.  Let me know if I missed anything.


Add Number

I'd be surprised if Number is a recognizable standalone feature in the minds of web developers and think this and a bunch of other classes would make sense to just put in a "JavaScript" feature.
This does mean we have to make more judgment calls about what is a standalone feature, but I think sticking to API shape too closely will lead to web-features resembling an index of reference docs more than caniuse-style features.
We've been quite atomistic about HTML elements, but I think even there we have features (like <body>) that should just be part of an "HTML" feature later.

I'd be surprised if Number is a recognizable standalone feature in the minds of web developers

That's a fair point. I broke them down based on the Global Objects page from MDN. In that way, we've kept all the "Indexed Collections" as separate features...
One alternative might be to do something like primitives, which would include: String, Number, Boolean, and BigInt, plus Object, Function, Error, and Symbol. Though the last four feel a little tacked on. Additionally, we should probably consider adding Date to that list.

Per discussion in #1562, added the Math methods here.
@ddbeck - can you update the name/description, it was already pretty long and adding the Math functions will make it even more verbose.


directory view not showing block programs

https://microsoft.github.io/jacdac-docs/editors/vm/
push open directory and open C:\Github\jacdac\jacdac-docs\jacdac-ts\tests\vm\blockly
see that JSON files don't appear

The editor uses subfolders now
Convert foo.json to foo/blocks.json .


Make the context menu black with white icons

Before:

After:

Fixes #5314

Before anyone asks: the main immediate motivation here was to not have to color-change rows on highlight when there are icons etc involved. The aesthetic considerations were secondary (but help to draw attention to the thing, which isn't bad)


just_a_test_of_pull_request

just a test of pull request

I have implemented my new unit "dark fury", please accept it.


Warn on second pretender

Replaces #156 with a small change.

Coverage increased (+0.03%) to 97.101% when pulling 87dcbab89cbeb158f4b4cda067fd5abf0373644c on warn-on-second-pretender into abff1a61d2fcd9ddcbdbbbab73f878d329668da5 on master.

@trek - This was released without a major version bump (as discussed in https://github.com/pretenderjs/pretender/pull/165#issuecomment-242478399) in 1.4.0... 😿

@trek Shouldn't the warning be a console.warn? throwing an error blocks users altogether 😢

@mariogintili @rwjblue I'm down to do a console.warn instead of throw an error release. I opted not to major bump because certain parts of Pretender (proxy and shutdown) will not work if you start a second server before shutting the first one down.
It was the existing behavior but it's also a bug and doesn't follow the usage requirement we've had since the first release.
I didn't know so many project still relied on this specific bug being left in place.


Windows worker node support

I know this is a long-shot, but I would like to get a discussion going. What would it take to add support for Windows nodes that are able to run .Net Framework apps? We do have some old apps that for various reason cannot be rewritten to .Net core, but still would like to migrate them to Kubernetes (as most of our services and apps now runs there).
https://docs.microsoft.com/en-us/dotnet/standard/modernize-with-azure-and-containers/modernize-existing-apps-to-cloud-optimized/deploy-existing-net-apps-as-windows-containers
https://kubernetes.io/docs/getting-started-guides/windows/
PS, we could probably contribute with dev resources to get this going if it's of any interest, and if it from a technology perspective is actually possible.
Regards

No one interested?

/remove-lifecycle stale

Hi, I’m afraid that I have no bandwidth for looking into this option. Is this something you could code and I can then review?

We might contribute with dev resources if there any interest in this. But we should first establish if it's even possible given the current kube-aws architecture.
Can we keep the issue open? I can close it later if we don't find internal resources that can contribute.

/remove-lifecycle stale

This sounds interesting, we have some potential use cases on this side too, but unsure if we could commit resource to this right now.

My colleague @andersosthus has started working on this, and we do have a windows worker node attached to one of our dev clusters. Bare in mind that this is in an extremely early stage, and there are many things that don't work.

As @paalkr said, I've started doing some POCs around this. Currently a bit on hold, since we need k8s 0.14 and we haven't upgraded the test cluster yet.
But some parts of the work needed is pretty clear already. We'll have to provide custom userdata scripts, possibly a custom assets file (since cloudinit is not a thing in Windows land) and stuff like that.
Maybe we could solve those as plugins? I'm not sure about how far along the plugin model is, or if kube-aws wants to have this in master alongside maintaining it?

/remove-lifecycle rotten

Just a quick update. We've started working on this again and have a Windows node joined to the kube-aws created cluster.
We're now investigating how to best integrate it into kube-aws so that we can use kube-aws to manage the Windows part as well.
My initial thought is to see if I can do everything I need as a plugin.

Just wondering what's the status on this as I'd like to see this supported as well.

Due to the holidays and such it got delayed a bit, but I've started working on a few PRs against master that will start to incorporate this.

Is this something you guys are still working on @andersosthus?


Export not working...

I followed the EN installation guide and the aimbot works, but in the final step to export, it doesn't work. Nothing happens (see image).
command:
yolo export model="models\sunxds_0.2.1_nano_320.pt" format=engine half=true device=0 workspace=4 imgsz=320

pip uninstall onnx
run export again, there is a bug, you need to remove onnx everytime before export 🤷

@SunOner I have now the same Error as a prior issue: "NoneType' object does not support the context manager protocol".
Is there a solution to this?

@SunOner I have now the same Error as a prior issue: "NoneType' object does not support the context manager protocol".
Is there a solution to this?

send cmd screenshot i dont know what u talking about

whats ur gpu?

i think there’s currently no fix for that issue
even google says nothing idk actually

ТАКАЯ ЖЕ БЕДА У МЕНЯ МУЖИК

@SunOner I have a GTX 970. I think this is the problem. I have to get a new GPU. Thanks for your help. Can you as a last question recommend a graphic card for AIs like this?
Would a RTX 4060 be enough to run this program smoothly in the future? :) Thanks

yes but rtx 4060 ti would be so much better man


Add SplitMix64 RNG

Serge asked me if he could add my implementation of the SplitMix64 RNG.  here it is!  My original file is located at: https://github.com/bstjean/SmalltalkStuff/tree/master/SplitMix64
Here's the file
SplitMix64_fileout.zip
out attached.

Thank you for your contribution.

@bstjean can you do a PR?


Added IPv4 Address Generation

Added the command for generating a random IPv4 ip address

I like this a lot! Thanks @SSully!


Let the user select his/her own localization settings

From<EMAIL_ADDRESS>on 2013-05-16T01:45:03Z
Spyder Version:  2.1.11
Python Version:  2.7.3
Qt Version:      4.8.3, PyQt4 (API v2) 4.9.5 on Windows
What steps will reproduce the problem?

Open Spyder from the Python(x,y) icon on the desktop What is the expected output? What do you see instead? This localization thing is very annoying: The whole window is flipped right-to-left (see attached image). I'm using Windows 7, 64 bit, English version, but I have an alternative keyboard layout of Hebrew. The Windows localization settings are set to Israel. I would like to use the IDE without any translations, direction-flipping, etc.

Please provide any additional information below
. See attached snapshot. This might be a QT issue, but I believe the IDE should no rely on the QT settings for scientific software, where the only valid language is English (and Python :)
Attachment: Untitled.png
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1394

From<EMAIL_ADDRESS>on 2013-05-16T04:55:20Z
Temporary solution is to add these two lines to c:\python27\scripts\xyhome.pyw:
import os
os.environ['lang']='en_us'
I really think there should be a way to ignore this environment variable from the IDE options menu.

From ccordoba12 on 2013-06-28T21:56:18Z
Thanks for reporting. We'll what we can do about it. For now you'll have to use your own approach.
Summary: Let the user select his/her own localization settings  <span class="oldvalue"> (was: The IDE is right-aligned, with no way of restoring regular left-alignment) </span>
Status: Accepted
Labels: -Localization -RTL Cat-SpyderGUI MS-v2.4

From ccordoba12 on 2014-09-21T11:23:40Z
We could add this facility to
Preferences > General

by using a dropdown menu. There are only three possibilities: English, French and Spanish.
Labels: Easy

From ccordoba12 on 2014-09-21T11:41:18Z
issue #1806 has been merged into this issue.

This was solved by PR #2349.


Added clarification for in-DOM props and string templates

You have a typo: <tempalte> => <template>.

Thanks @leopiccionia, fixed!

Thanks @Justineo for the valuable input. I have updated the docs now to have this in a completely separate page and linked it in the props file, too. Would love to get feedback on that one. It's just a first draft for now. So any input is very appreciated!

Related to #1807


Adopt VS Code's 'asWebviewUri' API

Hi, I maintain VS Code's Webview API
Issue
Our telemetry suggests that your extension uses webviews and may be loading resources in these webviews using hardcoded vscode-resource: URIs. These URIs have some important limitations and don't work properly when VS Code is run in a browser. We are also making changes in the desktop version of VS Code that may cause these URIs to not work properly in future versions of VS Code.
While we are making our best effort to continue support existing webview extensions that use vscode-resource: URIs on desktop versions of VS Code, we will not able to fully support all uses cases.
Fix
To ensure that your extension continues to work in as many environments as possible—including on web and remotely—please:

Switch to use the Webview.asWebviewUri function for loading resources.

Switch to use the Webview.cspSource property in content security policies.

These APIs shipped around 2 years ago so they should be available in all modern versions of VS Code. You can find additional information about the issue here: https://github.com/microsoft/vscode/issues/97962
Let me know if you have any questions about this change

The Webview.asWebviewUri returns a object which scheme is vscode-resource. Why should I change content security policies from vscdoe-resource to Webview.scpSource?

@Raylin51 The cspSource differs between desktop and web. In VS Code 1.46, it has changed and is no longer vscode-resource. You should always use cspSource in your content security policy to ensure your extension works correctly in as many environments as possible

Fixed.Thanks!


autotools build system cleanup

@marcomaggi I cleaned up the autotools build to be more precise and simple, users often look at travis build and I wanted it to be clean as possible, by using current travis version of different packages.
Are you ok with this changes ?

In Travis config: the option --enable-maintainer-mode to configure will be needed in future if we include the Texinfo documentation.  It causes the infrastructure to generate the file version.texi, which other build systems should generate too.
The generic instructions in INSTALL.autotools are nice to have; the file is a bit old but still valid.
In Makefile.am I think it is better to keep ACLOCAL_AMFLAGS = -I m4.
The file acinclude.m4 is needed?
The old version of autogen.sh did the right thing; the new one will not work from a fresh repository checkout.  IMHO only the directories must be updated.
In configure.ac and semver.pc.in: the version that goes in the pkg-config file should not be the one defined for the library file; they should be the proper package version.  At least, that is what I always did.

#29


Publish

Publish this package to either npmjs.com or GitHub.

[ ] Find a good way to handle automatic generation of changelog based on [Conventional Commits]. Since standard-version is deprecated and recommends release-please we could use this.

This package is getting phased out, and we do not plan to make any improvements unless they are critical for the remaining apps. Closing this issue


Peer-to-peer review

A really nice website. It could be even better if you corrected the typos and edited the README.md to remove the box brackets. You could also, kindly, observe the spacing, especially on the technology tags, and adjust them according to the design.

Great portfolio website design !...................as said by another reviewer, correct the typo error to make it a perfect job


Solved some VM errors

Solved shutdown errors that prevent the VM to try again to be scheduled on the CRN.
Errors:

Property _unix_socket is not used on instances yet, so initialize to None by default.
If the VM don't respond to a ping, should forget the VM to be able to try to power up later.
Improvement: Use fallocate instead dd command to create empty files.
Fixed cloud-init issue that only executes the configuration on the first boot. Now, if the VM ID has changed, the cloud-init configuration re-runs again.

Would be nice if you could list the problems you solved in this PR in the description. I see that you solved quite a few of them and if would be nice to track them.

Would be nice if you could list the problems you solved in this PR in the description. I see that you solved quite a few of them and if would be nice to track them.

I just updated the description with the error list.


⚠ Spryr has degraded performance

In ed8ea15, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 5724 ms

Resolved: Spryr performance has improved in 8d30168 after 7 minutes.


issues with launching jobs with LSF

I am trying to run RNA-Seq analysis with bcbio using the following configuration file:

#!/bin/bash
#BSUB -u nobody
#BSUB -o submit_bcbio.%J.out
#BSUB -J submit_bcbio.sh
#BSUB -q big
#BSUB -R rusage[mem=8000]
module load python/2.7.3
module load bcbio-nextgen/1.0.4
export PATH=/data/mindinformatics/software/src/hisat/hisat2-2.1.0:$PATH
export PATH=/data/mindinformatics/software/bin:/apps/lib-osver/bcbio/1.0.4/anaconda/bin:$PATH
bcbio_nextgen.py ../config/alignment.yaml
-n 8 -t ipython -s lsf -q big -r t=4-00:00 --timeout 2000
After a few hours I get "0 Engines running" multiple times and here is the error log:
[sd587@eris1n2 log]$ more ipcluster-076e082f-6759-4e14-83ac-781183d7c064-3805.log
2019-04-27 17:08:49.710 [IPClusterStart] WARNING | Config option mem not recognized by BcbioLSFControllerLauncher.
2019-04-27 17:08:49.715 [IPClusterStart] Starting ipcluster with [daemon=True]
2019-04-27 17:08:49.722 [IPClusterStart] Creating pid file: /data/mindinformatics/projects/DGE/alignment/work/log/ipython/pid/
ipcluster-076e082f-6759-4e14-83ac-781183d7c064.pid
2019-04-27 17:08:49.724 [IPClusterStart] Starting Controller with cluster_helper.cluster.BcbioLSFControllerLauncher
2019-04-27 17:08:49.725 [IPClusterStart] adding PBS queue settings to batch script
2019-04-27 17:08:49.725 [IPClusterStart] adding job array settings to batch script
2019-04-27 17:08:49.726 [IPClusterStart] Writing batch script: ./lsf_controllerbddad0c8-59da-4591-8bde-d52ede1a573e
2019-04-27 17:08:49.734 [IPClusterStart] Starting BcbioLSFControllerLauncher: bsub<"./lsf_controllerbddad0c8-59da-4591-8bde-d5
2ede1a573e"
2019-04-27 17:08:49.804 [IPClusterStart] ERROR | Controller start failed
Traceback (most recent call last):
File "/apps/lib-osver/bcbio/1.0.4/anaconda/lib/python2.7/site-packages/ipyparallel/apps/ipclusterapp.py", line 503, in start
_controller
self.controller_launcher.start()
File "/apps/lib-osver/bcbio/1.0.4/anaconda/lib/python2.7/site-packages/cluster_helper/cluster.py", line 219, in start
return super(BcbioLSFControllerLauncher, self).start()
File "/apps/lib-osver/bcbio/1.0.4/anaconda/lib/python2.7/site-packages/ipyparallel/apps/launcher.py", line 1305, in start
return super(LSFControllerLauncher, self).start(1)
File "/apps/lib-osver/bcbio/1.0.4/anaconda/lib/python2.7/site-packages/ipyparallel/apps/launcher.py", line 1286, in start
job_id = self.parse_job_id(output)
File "/apps/lib-osver/bcbio/1.0.4/anaconda/lib/python2.7/site-packages/ipyparallel/apps/launcher.py", line 1103, in parse_jo
b_id
raise LauncherError("Job id couldn't be determined: %s" % output)
LauncherError: Job id couldn't be determined:
Thanks for any pointers!
Sudeshna

Sudeshna;
Thanks for the report and apologies about the issues. It appears that IPython is having issues submitting to the LSF queue, so the jobs are never making it onto the cluster. My suggestion is to try submitting outside of bcbio:
bsub<"./lsf_controllerbddad0c8-59da-4591-8bde-d52ede1a573e"

which will hopefully give some useful error messages about what the scheduler dislikes about the submission batch scripts. That should help us tweak the settings to it'll work cleanly.
I did some work trying to get bcbio running on the partners cluster a few years back and if I remember correctly it was quite tricky because the different queue types are very picky about matching the actual resource allocations -- so if you ask for big but don't ask for enough memory or cores it'll reject it.
Hopefully the combination of that vague memory and manually submitting helps.

Thank you Brad, that is very helpful! It looks like request mismatch to resource issue. Here are the queues available at Partner's and the controller.

Here is what the lsf_controllerbddad0c8-59da-4591-8bde-d52ede1a573e output is:
LSBATCH: User input
#!/bin/sh
#BSUB -q big
#BSUB -J bcbio-c
#BSUB -n 4
#BSUB -oo bcbio-ipcontroller.bsub.%J
/apps/lib-osver/bcbio/1.0.4/anaconda/bin/python -E -c 'import resource; cur_proc, max_proc = resource.getrlimit(resource.RLIMIT_NPROC); tar
get_proc = min(max_proc, 10240) if max_proc > 0 else 10240; resource.setrlimit(resource.RLIMIT_NPROC, (max(cur_proc, target_proc), max_proc
)); cur_hdls, max_hdls = resource.getrlimit(resource.RLIMIT_NOFILE); target_hdls = min(max_hdls, 10240) if max_hdls > 0 else 10240; resourc
e.setrlimit(resource.RLIMIT_NOFILE, (max(cur_hdls, target_hdls), max_hdls)); from cluster_helper.cluster import VMFixIPControllerApp; VMFix
IPControllerApp.launch_instance()' --ip=* --log-to-file --profile-dir="/data/mindinformatics/projects/DGE/alignment/work/log/ipython" --clu
ster-id="be0a7c37-fa4f-45b7-b293-e47cd0c41be9" --nodb --hwm=1 --scheme=leastload --HeartMonitor.max_heartmonitor_misses=720 --HeartMonitor.
period=5000
I tried running the controller with no luck. Thanks for any advice!
Sudeshna

Sudeshna;
Thanks for helping debug. When you run bsub < lsf_controllerXXX with the bcbio generated batch script, does it report any error messages? Submitting outside of bcbio and debugging would be the best way to identify the mismatches and try to select the correct queues. Hope this helps.

HI Brad,
There are no error messages. It has been running all night and killed it
this morning. Here are the log messages with  bsub < lsf_controllerXXX
[sd587@eris1n2 log]$ more
ipcontroller-9e36bb35-b834-4b33-85fd-f37f132c4d6a-6842.log
2019-04-29 00:27:27.692 [VMFixIPControllerApp] Hub listening on
tcp://*:51247 for registration.
2019-04-29 00:27:27.694 [VMFixIPControllerApp] Hub using DB backend: 'NoDB'
2019-04-29 00:27:27.949 [VMFixIPControllerApp] hub::created hub
2019-04-29 00:27:27.950 [VMFixIPControllerApp] writing connection info to
/data/mindinformatics/projects/DGE/al
ignment/work/log/ipython/security/ipcontroller-9e36bb35-b834-4b33-85fd-f37f132c4d6a-client.json
2019-04-29 00:27:27.957 [VMFixIPControllerApp] writing connection info to
/data/mindinformatics/projects/DGE/al
ignment/work/log/ipython/security/ipcontroller-9e36bb35-b834-4b33-85fd-f37f132c4d6a-engine.json
2019-04-29 00:27:27.964 [VMFixIPControllerApp] task::using Python leastload
Task scheduler
2019-04-29 00:27:27.964 [VMFixIPControllerApp] Heartmonitor started
2019-04-29 00:27:27.976 [VMFixIPControllerApp] Creating pid file:
/data/mindinformatics/projects/DGE/alignment/
work/log/ipython/pid/ipcontroller-9e36bb35-b834-4b33-85fd-f37f132c4d6a.pid
2019-04-29 00:27:27.989 [VMFixIPControllerApp] client::client '\x00k\x8bEg'
requested 'connection_request'
2019-04-29 00:27:27.989 [VMFixIPControllerApp] client::client
['\x00k\x8bEg'] connected
Sender: LSF System lsfadmin@cn027
Subject: Job 732590:  Exited
Job  was submitted from host  by user  in cluster
.
Job was executed on host(s) , in queue , as user  in
cluster .
</PHShome/sd587> was used as the home directory.
</data/mindinformatics/projects/DGE/alignment/work> was used as the working
directory.
Started at Mon Apr 29 00:27:26 2019
Results reported at Mon Apr 29 06:24:25 2019
Your job looked like:

LSBATCH: User input
#!/bin/sh
#BSUB -q big
#BSUB -J bcbio-c
#BSUB -n 1
#BSUB -oo bcbio-ipcontroller.bsub.%J
/apps/lib-osver/bcbio/1.0.4/anaconda/bin/python -E -c 'import resource;
cur_proc, max_proc = resource.getrlimit
(resource.RLIMIT_NPROC); target_proc = min(max_proc, 10240) if max_proc > 0
else 10240; resource.setrlimit(reso
urce.RLIMIT_NPROC, (max(cur_proc, target_proc), max_proc)); cur_hdls,
max_hdls = resource.getrlimit(resource.RL
IMIT_NOFILE); target_hdls = min(max_hdls, 10240) if max_hdls > 0 else
10240; resource.setrlimit(resource.RLIMIT
_NOFILE, (max(cur_hdls, target_hdls), max_hdls)); from
cluster_helper.cluster import VMFixIPControllerApp; VMFi
xIPControllerApp.launch_instance()' --ip=* --log-to-file
--profile-dir="/data/mindinformatics/projects/DGE/alig
nment/work/log/ipython" --cluster-id="9e36bb35-b834-4b33-85fd-f37f132c4d6a"
--nodb --hwm=1 --scheme=leastload -
-HeartMonitor.max_heartmonitor_misses=720 --HeartMonitor.period=5000

TERM_OWNER: job killed by owner.
Exited with signal termination: Alarm clock.
Resource usage summary:
CPU time   :     31.03 sec.

Max Memory :       238 MB

Max Swap   :      6101 MB

Max Processes  :         8

Max Threads    :        19

The output (if any) follows:
2019-04-29 00:27:27.680 [VMFixIPControllerApp] Using existing profile dir:
u'/data/mindinformatics/projects/DGE
/alignment/work/log/ipython'
2019-04-29 00:27:27.987 [scheduler] Scheduler started [leastload]
2019-04-29 06:24:25.345 [scheduler] Interrupted, exiting...
CRITICAL:scheduler:Interrupted, exiting...
And when I ran bcbio I get:
[sd587@eris1n2 log]$ more
ipcluster-9e36bb35-b834-4b33-85fd-f37f132c4d6a-6034.log
2019-04-29 00:02:52.537 [IPClusterStart] WARNING | Config option mem not
recognized by `BcbioLSFControllerLau
ncher`.
2019-04-29 00:02:52.541 [IPClusterStart] Starting ipcluster with
[daemon=True]
2019-04-29 00:02:52.549 [IPClusterStart] Creating pid file:
/data/mindinformatics/projects/DGE/alignment/work/l
og/ipython/pid/ipcluster-9e36bb35-b834-4b33-85fd-f37f132c4d6a.pid
2019-04-29 00:02:52.551 [IPClusterStart] Starting Controller with
cluster_helper.cluster.BcbioLSFControllerLaun
cher
2019-04-29 00:02:52.552 [IPClusterStart] adding PBS queue settings to batch
script
2019-04-29 00:02:52.552 [IPClusterStart] adding job array settings to batch
script
2019-04-29 00:02:52.552 [IPClusterStart] Writing batch script:
./lsf_controller014c7be8-78d6-4f46-a6ce-0b13c112
69d4
2019-04-29 00:02:52.558 [IPClusterStart] Starting
BcbioLSFControllerLauncher: bsub<"./lsf_controller014c7be8-78
d6-4f46-a6ce-0b13c11269d4"
2019-04-29 00:02:52.601 [IPClusterStart] Job submitted with job id:
u'732586'
2019-04-29 00:02:52.602 [IPClusterStart] Process 'bsub' started: u'732586'
2019-04-29 00:03:02.612 [IPClusterStart] Starting 1 Engines with
cluster_helper.cluster.BcbioLSFEngineSetLaunch
er
2019-04-29 00:03:02.751 [IPClusterStart] adding PBS queue settings to batch
script
2019-04-29 00:03:02.752 [IPClusterStart] adding job array settings to batch
script
2019-04-29 00:03:02.753 [IPClusterStart] Writing batch script:
./lsf_engined9a328c4-8eaa-4970-a7bc-45bc12e1bfc2
2019-04-29 00:03:02.762 [IPClusterStart] Starting
BcbioLSFEngineSetLauncher: bsub<"./lsf_engined9a328c4-8eaa-49
70-a7bc-45bc12e1bfc2"
2019-04-29 00:03:02.811 [IPClusterStart] ERROR | Engine start failed
Traceback (most recent call last):
File
"/apps/lib-osver/bcbio/1.0.4/anaconda/lib/python2.7/site-packages/ipyparallel/apps/ipclusterapp.py",
lin
e 332, in start_engines
self.engine_launcher.start(self.n)

File
"/apps/lib-osver/bcbio/1.0.4/anaconda/lib/python2.7/site-packages/cluster_helper/cluster.py",
line 183,
in start
return super(BcbioLSFEngineSetLauncher, self).start(n)

File
"/apps/lib-osver/bcbio/1.0.4/anaconda/lib/python2.7/site-packages/ipyparallel/apps/launcher.py",
line 12
86, in start
job_id = self.parse_job_id(output)

File
"/apps/lib-osver/bcbio/1.0.4/anaconda/lib/python2.7/site-packages/ipyparallel/apps/launcher.py",
line 11
03, in parse_job_id
raise LauncherError("Job id couldn't be determined: %s" % output)

LauncherError: Job id couldn't be determined:
On Mon, Apr 29, 2019 at 5:51 AM Brad Chapman<EMAIL_ADDRESS>wrote:

Sudeshna;
Thanks for helping debug. When you run bsub < lsf_controllerXXX with the
bcbio generated batch script, does it report any error messages? Submitting
outside of bcbio and debugging would be the best way to identify the
mismatches and try to select the correct queues. Hope this helps.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bcbio/bcbio-nextgen/issues/2803#issuecomment-487520582,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB55P5VEBEABLEFVDQGFAM3PS3AJBANCNFSM4HI5CAAA
.

HI Brad,
I tried running the lsf_engine and this maybe a better clue:
[sd587@eris1n2 work]$ bsub < lsf_engined9a328c4-8eaa-4970-a7bc-45bc12e1bfc2
Error in rusage section: The merged job-level and application-level rusage
value is outside the range set by RESRSV_LIMIT defined in lsb.queues. Job
not submitted.
#!/bin/sh
#BSUB -q big
#BSUB -J bcbio-e[1-1]
#BSUB -oo bcbio-ipengine.bsub.%%J
#BSUB -n 1
#BSUB -R "span[hosts=1]"
#BSUB -R "rusage[mem=1024]"
/apps/lib-osver/bcbio/1.0.4/anaconda/bin/python -E -c 'import resource;
cur_proc, max_proc = resource.getrlimit
(resource.RLIMIT_NPROC); target_proc = min(max_proc, 10240) if max_proc > 0
else 10240; resource.setrlimit(reso
urce.RLIMIT_NPROC, (max(cur_proc, target_proc), max_proc)); cur_hdls,
max_hdls = resource.getrlimit(resource.RL
IMIT_NOFILE); target_hdls = min(max_hdls, 10240) if max_hdls > 0 else
10240; resource.setrlimit(resource.RLIMIT
_NOFILE, (max(cur_hdls, target_hdls), max_hdls)); from
ipyparallel.apps.ipengineapp import launch_new_instance;
launch_new_instance()' --timeout=960 --IPEngineApp.wait_for_url_file=960
--EngineFactory.max_heartbeat_misses=
120
--profile-dir="/data/mindinformatics/projects/DGE/alignment/work/log/ipython"
--cluster-id="9e36bb35-b834-4
b33-85fd-f37f132c4d6a"
Thanks!
Sudeshna
On Mon, Apr 29, 2019 at 6:28 AM Sudeshna Das<EMAIL_ADDRESS>wrote:

HI Brad,
There are no error messages. It has been running all night and killed it
this morning. Here are the log messages with  bsub < lsf_controllerXXX
[sd587@eris1n2 log]$ more
ipcontroller-9e36bb35-b834-4b33-85fd-f37f132c4d6a-6842.log
2019-04-29 00:27:27.692 [VMFixIPControllerApp] Hub listening on
tcp://*:51247 for registration.
2019-04-29 00:27:27.694 [VMFixIPControllerApp] Hub using DB backend: 'NoDB'
2019-04-29 00:27:27.949 [VMFixIPControllerApp] hub::created hub
2019-04-29 00:27:27.950 [VMFixIPControllerApp] writing connection info to
/data/mindinformatics/projects/DGE/al
ignment/work/log/ipython/security/ipcontroller-9e36bb35-b834-4b33-85fd-f37f132c4d6a-client.json
2019-04-29 00:27:27.957 [VMFixIPControllerApp] writing connection info to
/data/mindinformatics/projects/DGE/al
ignment/work/log/ipython/security/ipcontroller-9e36bb35-b834-4b33-85fd-f37f132c4d6a-engine.json
2019-04-29 00:27:27.964 [VMFixIPControllerApp] task::using Python
leastload Task scheduler
2019-04-29 00:27:27.964 [VMFixIPControllerApp] Heartmonitor started
2019-04-29 00:27:27.976 [VMFixIPControllerApp] Creating pid file:
/data/mindinformatics/projects/DGE/alignment/
work/log/ipython/pid/ipcontroller-9e36bb35-b834-4b33-85fd-f37f132c4d6a.pid
2019-04-29 00:27:27.989 [VMFixIPControllerApp] client::client
'\x00k\x8bEg' requested 'connection_request'
2019-04-29 00:27:27.989 [VMFixIPControllerApp] client::client
['\x00k\x8bEg'] connected
Sender: LSF System lsfadmin@cn027
Subject: Job 732590:  Exited
Job  was submitted from host  by user  in cluster
.
Job was executed on host(s) , in queue , as user  in
cluster .
</PHShome/sd587> was used as the home directory.
</data/mindinformatics/projects/DGE/alignment/work> was used as the
working directory.
Started at Mon Apr 29 00:27:26 2019
Results reported at Mon Apr 29 06:24:25 2019
Your job looked like:

LSBATCH: User input
#!/bin/sh
#BSUB -q big
#BSUB -J bcbio-c
#BSUB -n 1
#BSUB -oo bcbio-ipcontroller.bsub.%J
/apps/lib-osver/bcbio/1.0.4/anaconda/bin/python -E -c 'import resource;
cur_proc, max_proc = resource.getrlimit
(resource.RLIMIT_NPROC); target_proc = min(max_proc, 10240) if max_proc >
0 else 10240; resource.setrlimit(reso
urce.RLIMIT_NPROC, (max(cur_proc, target_proc), max_proc)); cur_hdls,
max_hdls = resource.getrlimit(resource.RL
IMIT_NOFILE); target_hdls = min(max_hdls, 10240) if max_hdls > 0 else
10240; resource.setrlimit(resource.RLIMIT
_NOFILE, (max(cur_hdls, target_hdls), max_hdls)); from
cluster_helper.cluster import VMFixIPControllerApp; VMFi
xIPControllerApp.launch_instance()' --ip=* --log-to-file
--profile-dir="/data/mindinformatics/projects/DGE/alig
nment/work/log/ipython"
--cluster-id="9e36bb35-b834-4b33-85fd-f37f132c4d6a" --nodb --hwm=1
--scheme=leastload -
-HeartMonitor.max_heartmonitor_misses=720 --HeartMonitor.period=5000

TERM_OWNER: job killed by owner.
Exited with signal termination: Alarm clock.
Resource usage summary:
CPU time   :     31.03 sec.

Max Memory :       238 MB

Max Swap   :      6101 MB

Max Processes  :         8

Max Threads    :        19

The output (if any) follows:
2019-04-29 00:27:27.680 [VMFixIPControllerApp] Using existing profile dir:
u'/data/mindinformatics/projects/DGE
/alignment/work/log/ipython'
2019-04-29 00:27:27.987 [scheduler] Scheduler started [leastload]
2019-04-29 06:24:25.345 [scheduler] Interrupted, exiting...
CRITICAL:scheduler:Interrupted, exiting...
And when I ran bcbio I get:
[sd587@eris1n2 log]$ more
ipcluster-9e36bb35-b834-4b33-85fd-f37f132c4d6a-6034.log
2019-04-29 00:02:52.537 [IPClusterStart] WARNING | Config option mem not
recognized by `BcbioLSFControllerLau
ncher`.
2019-04-29 00:02:52.541 [IPClusterStart] Starting ipcluster with
[daemon=True]
2019-04-29 00:02:52.549 [IPClusterStart] Creating pid file:
/data/mindinformatics/projects/DGE/alignment/work/l
og/ipython/pid/ipcluster-9e36bb35-b834-4b33-85fd-f37f132c4d6a.pid
2019-04-29 00:02:52.551 [IPClusterStart] Starting Controller with
cluster_helper.cluster.BcbioLSFControllerLaun
cher
2019-04-29 00:02:52.552 [IPClusterStart] adding PBS queue settings to
batch script
2019-04-29 00:02:52.552 [IPClusterStart] adding job array settings to
batch script
2019-04-29 00:02:52.552 [IPClusterStart] Writing batch script:
./lsf_controller014c7be8-78d6-4f46-a6ce-0b13c112
69d4
2019-04-29 00:02:52.558 [IPClusterStart] Starting
BcbioLSFControllerLauncher: bsub<"./lsf_controller014c7be8-78
d6-4f46-a6ce-0b13c11269d4"
2019-04-29 00:02:52.601 [IPClusterStart] Job submitted with job id:
u'732586'
2019-04-29 00:02:52.602 [IPClusterStart] Process 'bsub' started: u'732586'
2019-04-29 00:03:02.612 [IPClusterStart] Starting 1 Engines with
cluster_helper.cluster.BcbioLSFEngineSetLaunch
er
2019-04-29 00:03:02.751 [IPClusterStart] adding PBS queue settings to
batch script
2019-04-29 00:03:02.752 [IPClusterStart] adding job array settings to
batch script
2019-04-29 00:03:02.753 [IPClusterStart] Writing batch script:
./lsf_engined9a328c4-8eaa-4970-a7bc-45bc12e1bfc2
2019-04-29 00:03:02.762 [IPClusterStart] Starting
BcbioLSFEngineSetLauncher: bsub<"./lsf_engined9a328c4-8eaa-49
70-a7bc-45bc12e1bfc2"
2019-04-29 00:03:02.811 [IPClusterStart] ERROR | Engine start failed
Traceback (most recent call last):
File
"/apps/lib-osver/bcbio/1.0.4/anaconda/lib/python2.7/site-packages/ipyparallel/apps/ipclusterapp.py",
lin
e 332, in start_engines
self.engine_launcher.start(self.n)

File
"/apps/lib-osver/bcbio/1.0.4/anaconda/lib/python2.7/site-packages/cluster_helper/cluster.py",
line 183,
in start
return super(BcbioLSFEngineSetLauncher, self).start(n)

File
"/apps/lib-osver/bcbio/1.0.4/anaconda/lib/python2.7/site-packages/ipyparallel/apps/launcher.py",
line 12
86, in start
job_id = self.parse_job_id(output)

File
"/apps/lib-osver/bcbio/1.0.4/anaconda/lib/python2.7/site-packages/ipyparallel/apps/launcher.py",
line 11
03, in parse_job_id
raise LauncherError("Job id couldn't be determined: %s" % output)

LauncherError: Job id couldn't be determined:
On Mon, Apr 29, 2019 at 5:51 AM Brad Chapman<EMAIL_ADDRESS>wrote:

Sudeshna;
Thanks for helping debug. When you run bsub < lsf_controllerXXX with the
bcbio generated batch script, does it report any error messages? Submitting
outside of bcbio and debugging would be the best way to identify the
mismatches and try to select the correct queues. Hope this helps.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bcbio/bcbio-nextgen/issues/2803#issuecomment-487520582,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB55P5VEBEABLEFVDQGFAM3PS3AJBANCNFSM4HI5CAAA
.

Hi Sudeshna,
This is tough to debug not being on the cluster, I'd contact the admins at Partners and see if they can figure out why that LSF file is throwing the error. It looks like rusage[mem=1024] is the problem but it is hard to know why without having access to the cluster. That is probably either too big or too little for the queue you are selecting, they might have some better suggestions. The admins will definitely be about 100x better at figuring out than we will be.

Closing this, as it is stale-- let us know if the folks at Partners weren't able to help.


Setup Travis CI build

See https://travis-ci.com, https://docs.travis-ci.com and https://github.com/marketplace/travis-ci.
I use Travis CI for running tests and ensuring that the code builds and that tests pass correctly.

I like this idea. I am not sure what we would test though. Most of the tests that I do (manually) is put several different test ejs files and make sure they are colored correctly. Most of it relies on actually seeing the color. If you know of a way we can use that to test I say let's go for it.
Now I can definitely see using this when we get a language server that actually runs code.

VisualStudio Code documentation recommends using Azure Pipelines for Continuous Integration: https://code.visualstudio.com/api/working-with-extensions/continuous-integration.


How test it on KITTI？

hi，I  really appreciate your this work.But how does it perform on the KITTI dataset？
Do you have the pre-trained model for KITTI？or can you tell me how to apply it on KITTI？
I look forward to your reply！
Good luck！

Hi @FireflyInwater
We have not trained or tested on KITTI. To apply our work on KITTI scenes, the model needs to be retrained on the KITTI dataset.

Hi@Diana
I trained the model on KITTI dataset. But the error rate is very high.


cant receive multiple instances of the same sticky event class

ive stumbled upon a case where i need to deliver events from one screen to another ( android ) .
for this i used sticky events , i have multiple instances of the same class  being posted as sticky events , yet my subscriber seems to receive only the latest sticky instance posted .
ive done some investigation , and it starts with this member in Eventbus.java:
private final Map<Class<?>, Object> stickyEvents;
when a sticky event is posted , the put method to this map will overwrite any previous events put here .
my question is that sth by design and has a reason for ? maybe related to not store multiple instances in memory . OR is it sth that i can work on to improve ?  and maybe  instead of mapping a class to a single object , we can do so to a collection of objects.
ive also gone through test package for sticky events , although this test passes , its for two different types :
@Test
    public void testPostStickyTwoEvents() throws InterruptedException {
        eventBus.postSticky("Sticky");  // String.class
        eventBus.postSticky(new IntTestEvent(7));  //IntTestEvent.class
        eventBus.register(this);
        assertEquals(2, eventCount.intValue());
    }

ive created this test for two sticky events with same class  , it fails :
@Test
    public void testPostStickyTwoEventsSameClass() throws InterruptedException {
        eventBus.postSticky("Sticky1");
        eventBus.postSticky("Sticky2");
        eventBus.register(this);
        assertEquals(2, eventCount.intValue());
    }

please let me know if this is sth i can contribute and work on ?
thank you

It is by design that only the latest sticky event is kept.
https://greenrobot.org/eventbus/documentation/configuration/sticky-events/


Update remove-adorganizationalunit.md

Correct the values accepted for identity

@get-itips @tseward
Peer review needed for this PR. Thanks.

Can you please review the text of the -Identity parameter? It still references an AD Group, etc.

ok with @tseward

@tseward I have corrected the text of the identity parameter.

Docs Build status updates of commit 7d7ccfa:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/addsadministration/remove-adorganizationalunit.md
:white_check_mark:Succeeded

docset/winserver2012r2-ps/addsadministration/Remove-ADOrganizationalUnit.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@AndreaBarr The PR is ready to be merged.


libcurl must be installed

I tried to start binary ninja under Linux Mint 18, got following error message:
./binaryninja: error while loading shared libraries: libcurl.so.4: cannot open shared object file: No such file or directory

Solved it by installing libcurl3 via apt-get. Just to let you know

Thanks for the comment, might help others using Mint. Yes, Linux mint is not an officially supported operating system and on unsupported Linux OS's this tends to be the most common problem, it's even mentioned in our troubleshooting guide at docs.binary.ninja. Once Ubuntu LTS moves to curl4 the situation should improve.


Add examples of usage in readme

Add examples of all existing routes and their respective responses.
Example:
GET /package/:package
http://localhost:8081/package/OH756347841BR
{
    "progress": 100,
    "packHistory": [...]
}

Hey, I'd like to work on this!


fix(tiles): fix tile 8889

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 3.403%

Totals

Change from base Build<PHONE_NUMBER>5:
0.0%

Covered Lines:
515

Relevant Lines:
17091

💛  - Coveralls