[Feature-Request] add option to exclude non-matching tags from test run entirely

related: https://github.com/TheBrainFamily/cypress-cucumber-preprocessor/issues/436

Current behavior
Currently when running a feature that contain scenarios with non-matching tags are marked as pending in the test output.
Desired behavior
Have a cypress.json option which results in scenarios being excluded from the run all together.
e.g.
{ "excludeSkippedTests": true }

Test code to reproduce
It is possible to work around this by having two feature files: first.feature and first.e2efeature as a way of splitting up scenarios tagged with @e2e vs ones which don't, while still enabling access to all steps defined under first/.
You can then leverage excludeFiles option to do the filtering
This feels like a bit of a hack - and results in small things like syntax highlighting breaking on the first.e2efeature file.
Versions

Cypress version: 6.3.0
Preprocessor version: ^4.0.0
Node version: 12.8.3 (bundled)

If you'd be open to having something like this, I'd be more than happy to have a look and submit a PR!

If you'd be open to having something like this, I'd be more than happy to have a look and submit a PR!

See my answer in the related issue.

See my answer in the related issue.

Hi @badeball, thanks for replying!
so we can split tests up like you suggested - but then we run into the issue of not being able to use private steps from two different feature files.
The scenario is that we have some @ci tests, and @e2e tests.  We're using cypress.io to upload our test results when running against our environment - only running @e2e.  We don't want the @ci tests to show up as pending, as that counts as a test result in cypress.io.
So currently we have:
x/steps.js        -> contains steps for x
x.feature         -> contains @ci tests
x.e2efeature   -> contains @e2e tests

This allows to just run either e2e or ci or both, using the testfiles option.  Then when we run using *e2efeature filter only our e2e tests show up in cypress.io
However, it feels like this is relying on the internals of the processor, in that it doesn't care what the extension is for the feature file.  If that changed in future our workaround would break.
It would be nicer if we could use tags instead to decide which tests we are running, and not have to split up our files in this way.  If we had an option to exclude cypress-cucumber-preprocessor from outputting tests which get skipped, then we'd could do this.
Would this be possible at all?  Thanks

Hi @badeball, thanks for replying!
so we can split tests up like you suggested - but then we run into the issue of not being able to use private steps from two different feature files.
The scenario is that we have some @ci tests, and @e2e tests.  We're using cypress.io to upload our test results when running against our environment - only running @e2e.  We don't want the @ci tests to show up as pending, as that counts as a test result in cypress.io.
So currently we have:
x/steps.js        -> contains steps for x
x.feature         -> contains @ci tests
x.e2efeature   -> contains @e2e tests

This allows to just run either e2e or ci or both, using the testfiles option.  Then when we run using *e2efeature filter only our e2e tests show up in cypress.io
However, it feels like this is relying on the internals of the processor, in that it doesn't care what the extension is for the feature file.  If that changed in future our workaround would break.
It would be nicer if we could use tags instead to decide which tests we are running, and not have to split up our files in this way.  If we had an option to exclude cypress-cucumber-preprocessor from outputting tests which get skipped, then we'd could do this.
Would this be possible at all?  Thanks

It seems to me like you can name your files

x.e2e.feature
y.ci.feature

.. and specify testFiles either as **/*.e2e.feature or **/*.ci.feature and thus not rely on the fact the preprocessor incidentally don't care right now.

It seems to me like you can name your files

x.e2e.feature
y.ci.feature

.. and specify testFiles either as **/*.e2e.feature or **/*.ci.feature and thus not rely on the fact the preprocessor incidentally don't care right now.

we can do that - but run into issues with the private steps.
we don't want to duplicate the private steps into both x/steps.js and y/steps.js when they are the same.
We have other feature files that we don't want to be able to access the steps for x, hence why we can't use common.

we can do that - but run into issues with the private steps.
we don't want to duplicate the private steps into both x/steps.js and y/steps.js when they are the same.
We have other feature files that we don't want to be able to access the steps for x, hence why we can't use common.

we don't want to duplicate the private steps into both x/steps.js and y/steps.js when they are the same.

You can import files willy-nilly, so just put the x-y-shared steps into some other file which both x/steps.js and y/steps.js can import.
Another alternative is to just use symlinks.

It would be much nicer to just mix the ci and e2e tests for a feature within the same file, but if this really isn't something that you'd want to have as an option, then I'll close this off.

Let me be blunt here for a second. Every piece of added functionality comes with a maintenance cost. Your use case seems incredibly narrow to me and at the same time solvable in other ways. This (mixing different test suites) simply isn't something I expect a preprocessor to cater to and at the moment I'm unfortunately not even remotely convinced to implement this.

we don't want to duplicate the private steps into both x/steps.js and y/steps.js when they are the same.

You can import files willy-nilly, so just put the x-y-shared steps into some other file which both x/steps.js and y/steps.js can import.
Another alternative is to just use symlinks.

It would be much nicer to just mix the ci and e2e tests for a feature within the same file, but if this really isn't something that you'd want to have as an option, then I'll close this off.

Let me be blunt here for a second. Every piece of added functionality comes with a maintenance cost. Your use case seems incredibly narrow to me and at the same time solvable in other ways. This (mixing different test suites) simply isn't something I expect a preprocessor to cater to and at the moment I'm unfortunately not even remotely convinced to implement this.

fair enough - I'll close this off then.  I completely understand that added functionality incurs future maintenance cost - and if this use case is too narrow then that's completely your call.
Thanks for taking the time to respond! :smile:

fair enough - I'll close this off then.  I completely understand that added functionality incurs future maintenance cost - and if this use case is too narrow then that's completely your call.
Thanks for taking the time to respond! :smile:


multiprocessing recombination timeout increased to 5 minutes

Codecov Report

Merging #540 (8901cd6) into master (2007434) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #540   +/-   ##
=======================================
  Coverage   79.26%   79.26%
=======================================
  Files         176      176
  Lines       29302    29302
=======================================
+ Hits        23225    23226    +1
+ Misses       6077     6076    -1

Impacted Files
Coverage Δ

resqpy/multiprocessing/multiprocessing.py
21.91% <0.00%> (ø)

resqpy/model/_xml.py
91.41% <0.00%> (+0.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2007434...8901cd6. Read the comment docs.


[Issue] Cannot click search results in sidebar

Hi there,
Amazing plugin, I love it.
Sometimes selecting results in sidebar is desirable, but when plugin is enabled I can only click the "cards"
Also, cannot use other hotkeys in search menu, such as command + O for open or command + , for settings
Thanks!
Ryan
https://user-images.githubusercontent.com/82765301/153737932-aa5bf915-ee0d-449e-8e38-59bc87fd6cfe.mov

@ryadaj
Thank you for reporting!

Sometimes selecting results in sidebar is desirable, but when plugin is enabled I can only click the "cards"

Yes, it is a bug. I'll fix it in the near future.

Also, cannot use other hotkeys in search menu, such as command + O for open or command + , for settings.

This is an expected behavior to avoid hotkey collision. If you want to use other hotkeys, you have to exit the search mode.


Use WHATWG URL parsing, if available, instead of url.parse

The strategy:

Check if URL is a function
Check if URL.prototype is an object

If the checks are true, use new URL instead of url.parse.
The only 2 changes I know of, are:

URL has username and password already parsed, no need to check for auth
URL has searchParams instead of query

Closes #2563

Make sure to add a new test case for what you are trying to fix with this. Also curious on the change to the existing test: would this change now break anyone who has a colon in thier password?

Make sure to add a new test case for what you are trying to fix with this. Also curious on the change to the existing test: would this change now break anyone who has a colon in thier password?

That's an interesting question. I did this in kind of a hurry but then figured I could just pass an object and avoid the problem I was having. I'm not in a hurry now, so I'll sure add a test for that. About people using and it breaking, I think I need to change the parser to decode the password when using WHATWG URL as it seems it is always encoded when parsed.

> new URL("foo://user:pa:ss@host")
URL {
  href: 'foo://user:pa%3Ass@host',
  origin: 'null',
  protocol: 'foo:',
  username: 'user',
  password: 'pa%3Ass',
  host: 'host',
  hostname: 'host',
  port: '',
  pathname: '',
  search: '',
  searchParams: URLSearchParams {},
  hash: ''
}
> new URL("foo://user:pa%3Ass@host")
URL {
  href: 'foo://user:pa%3Ass@host',
  origin: 'null',
  protocol: 'foo:',
  username: 'user',
  password: 'pa%3Ass',
  host: 'host',
  hostname: 'host',
  port: '',
  pathname: '',
  search: '',
  searchParams: URLSearchParams {},
  hash: ''
}

It always encodes, whether it's already encoded or not.

What was failing for me was that I had a % on the password and the URL was not encoded, and because after that character there wasn't necessarily 2 hex characters, url.parse fails because it tries to decode and fails.
In the following example, assume password is pass% (not encoded).
> url.parse("foo://user:pass%@host")
Uncaught URIError: URI malformed
    at decodeURIComponent (<anonymous>)
    at Url.parse (node:url:368:19)
    at Object.urlParse [as parse] (node:url:156:13)
> new URL("foo://user:pass%@host")
URL {
  href: 'foo://user:pass%@host',
  origin: 'null',
  protocol: 'foo:',
  username: 'user',
  password: 'pass%',
  host: 'host',
  hostname: 'host',
  port: '',
  pathname: '',
  search: '',
  searchParams: URLSearchParams {},
  hash: ''
}

But shouldn't you always need to url encodure your password? Whay is your password is pa%0foo ?

But shouldn't you always need to url encodure your password? Whay is your password is pa%0foo ?

In that case you should, but according to the spec you don't need to unless it causes ambiguity (like your case). Password must be encoded if it has % and 2 hex chars next to it.

I think the way decodeURIComponent is used may need to be changed to match how the new URL is working so they are supporting the same semantics.

I don't know the implementation. Do you have any hints? As a funny note, your example URL is parsed in a different way on Chrome. I thought the implementation was the same.

@dougwilson you meant something like this?
function decodeUriComponent(str) {
	return str.replace(/\%([a-f0-9]{2})/g, (_, hex) => (String.fromCharCode(parseInt(hex, 16))));
}

(but converted to run on older node versions)


Clickable media tiles

Description
This PR adds tile_link property to MediaTiles that allows for the whole tile to become clickable.
Testing in sage-lib
See Components > MediaTile for new feature preview, props, and rules.
Design Spec forthcoming, draft mode here:
Testing in kajabi-products

(LOW) New tile link feature on Media Tiles. No expected change to current uses which include:

[ ] Analytics dashboard
[ ] Save Email as Template Template Manager
[ ] Coaching program list

Related
Closes #666
Closes #694
Closes #692
Closes #693

[MediaTile] docs - add the sections to the properties tab, similar to the properties tab on Panel Controls

[MediaTile] docs - add an example for a single MediaTile

[MediaTile] props - add a title_tag property to allow for a flexible heading tag to reduce skipped heading levels

@QuintonJason I refreshed your review request as I added new commits that accounted for the other issues you added related to this component. 🙏


⚠ Bofrost.nl has degraded performance

In cd0b26f, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 4019 ms

Resolved: Bofrost.nl performance has improved in ee7280f after 3 days, 19 hours, 8 minutes.


As a user I want to view a list of alumni so I can get learn about people who have worked at the CDH in the past.

Alumni are now viewable.


The point labels and lines added by entities after executing viewer. scene. primitives. removeAll() are not displayed

My code scenario involves adding multiple clouds through primitives, and adding entities with labels, models, and points through entities. In some cases, I need to delete all objects and add them again, but I found that if I execute the viewer.scene.primitives.RemoveAll(), the objects managed by entities, such as points and labels, will also be deleted and will not display properly when adding entities again. Comment viewer.scene.primitives The code displays normally after removeAll().
test
Test  Code
const viewer = new Cesium.Viewer("cesiumContainer", {
shouldAnimate: true,
terrain: Cesium.Terrain.fromWorldTerrain(),
});
const scene = viewer.scene;
viewer.scene.primitives.removeAll();
viewer.entities.add({
id:"1111",
position: Cesium.Cartesian3.fromDegrees(-75.1641667, 39.9522222),
label: {
text: "Philadelphia",
},
});
viewer.scene.primitives.removeAll();
viewer.entities.add({
id:"2222",
position: Cesium.Cartesian3.fromDegrees(-75.1641667, 39.9522222),
label: {
text: "Philadelphia",
},
});

Hi @freefer,
For background, entities are a higher-level API that create primitive geometries under the hood. It's recommended not to mix the Entity and Primitive APIs for this reason.
If you are using point cloud tileset primitives, I would recommend removing them specifically rather than using removeAll.
Thanks!


Add wasm build

It now builds with Trunk
Requirements:

Emscripten installed, and emcc in PATH

It's still very broken. For some reason, bindgen produce wrong pointer size


any luck with accurate rsi calculation

@tedchou12 Hi, have you been able to accurately calculate rsi to match what webull is showing on their UI.  I cant seem to get the same values as they are showing on the rsi14 chart.

Hi!
Actually, I don't use that many indices myself. Can you take a screenshot on http://app.webull.com/ and let me know which part you are referring to?

we can't know for sure how webull calculates on their RSI on the backend, but it should be the standard way. See this reference or this article to ensure you're following the standard way

it's like gibberish to me

we can't know for sure how webull calculates on their RSI on the backend, but it should be the standard way. See this reference or this article to ensure you're following the standard way

it's like gibberish to me

if you're gonna be a trader (an algo trader at that), you'll want to learn technical indicators... what they are, how they work, etc.

Maybe you can write an example script on Python language with a little variables so that I can understand. My math is really bad to understand such equations

we can't know for sure how webull calculates on their RSI on the backend, but it should be the standard way. See this reference or this article to ensure you're following the standard way

it's like gibberish to me

if you're gonna be a trader (an algo trader at that), you'll want to learn technical indicators... what they are, how they work, etc.

I don't think I could code anything that's simpler than that the this article. but if you really want to see how someone implements RSI in python here's an example.
Also, technical analysis is beyond the purview of this library. You can use a technical indicator/analysis library like the one I referenced above to perform all the common calculations you'd like


Fix the vbTab / vbBack mess

Completes #56

Thanks @skacurt !

Why is vbback initialized in class_terminate()?  Shouldn't that be class_initialize()?

@MarcoMiltenburg My bad, it certainly should.


Add screenshots demonstrating the performance of GPU raster and compositing

Also, fixed a bug in composited_raster_and_draw where we shouldn't do anything (including tracing) if none of the three dirty bits are set.

I'm definitely a fan of speeding things up a lot but I don't get this change.


Add registers

Is there any interest for support registers? I'd be open to contributing if there is interest.
My use case would be disjoint file manipulation and it seems like it would be a natural extension of the existing support.
Existing yank and put would modify the "" register. Named registers ("a) could be used to collect file selections when coupled with register appending ("A).
:reg a, " - list the contents of register a and the default register
"ay (select mode) - yank selected files into register a
"ad (select mode) - delete selected files and yank into register a
"Ay (select mode) - yank selected files and append into register a
"Ad (select mode) - delete selected files, yank and append into register a
"ayy - yank selected file into register a
"add - delete and yank select file into register a
"Ayy - yank selected file and append into register a
"Ayy - delete selected file, yank and append into register a
"ap - put contents of register a into current directory

Sorry for being late.
That'd be interesting and useful!
What we have to think would be:

Which type of register should be covered? Numbered only, or as you suggest, numbered and named? Numbered register is simpler and intuitive, and may be easy to implement IMO, on the other hand named register offers more flexible way to manipulate files.

How should we think about the data structure? Now registered field is Vec<ItemInfo>, but with the register feature that may be BTreeMap<Usize, Vec<ItemInfo>> or BTreeMap<Usize, Vec<ItemInfo>>: This would vary based on the register type.

I was thinking numbered and named, so using something like BTreeMap<String, Vec<ItemInfo>>.
I could start with numbered for the PoC and still use BTreeMap<String, Vec<ItemInfo>>. It would make the changes needed in event loop smaller.

Yeah, that's good if named is planned.
(vec_deque would be enough if numbered only though)
I'm ready to implement it, but what's your thought? Can I assign myself to this?

Sounds good. Go for it!

Implemented by #215.
It needed much refactoring but it feels now way, way better than before! Thank you.
If you're interested, please build from feature-reg branch and tinker with it.
After debugging I'll release new version.

Merged & released as v2.4.0.


metadata_key parameter for open_zarr

What is your issue?
In zarr's open_consolidated function, there is a metadata_key parameter to specify the path. However, this parameter is inaccessible when using xarray's open_zarr function.
Would it be possible to have metadata_key as a parameter in open_zarr or as a kwarg that can be passed to the open_consolidated?

dupe of #3548


Can I ignore local variables in a decorated function?

Storing every single variable in a decorated function seems like it's not always necessary, and presents issues with JSON encoding from time to time.  Is there some way we could have certain variables ignored?

There is currently no mechanism for ignoring variables, but you can just delete them at the end of the function:
@ex.config
def cfg():
    a = 10
    tmp = a**2
    b = tmp*2
    del tmp

will result in configuration {'a': 10, 'b': 200}.
Does this cover your usecase or would you need some other way of ignoring variables?

Thanks for the quick reply @Qwlouse.  This does work in the simple case of native python types.  If I have issues with pass-by-reference on my user objects I'll reopen.

@Qwlouse I'm going about trying to solve a problem I have a bunch of ways.  Ideally, I'd like this object to stay on the config to be used "downstream", but just not to be written to any observers, as it's a big complex beast and doesn't serialize well, if at all.  Is there a way to accomplish that?

Sorry, I should look into seeing if I can delete it at the penultimate step/captured function before initialization.  I'll look into that.

If you don't want to have it serialized and stored: Do you really need to build that object in the configuration? It sounds to me like something that you would want to create in a captured function.

That's what I'm doing for the majority of my "throwaway" things.  I have one particular case where I don't need the object itself, but I want to store some information derived from it in the config.  I have it working via a hook, but it seems a bit convoluted.  No need to spend any time on this.  I'll try to distill it into a simpler example I can copy/paste here.


value error: unexpected barcode map file

Hi!
After trying to get started with enrich2 it seems I have a problem with my barcodemap file. I have generated a tab-separated .txt file (screenshot of the first lines opened using the terminal:

) with my barcodes and the variant and tried to feed it into enrich2 but it seems, enrich2 does not recognise its format and gives the following error:
ValueError: Unexpected barcode map line format [barcodemap_VIF_barcodemap.txt]
I have tried the same with the example barcodemap file provided and did not get any error. I've also tried to convert the file and generated it from scratch using several different sources (python csv.writer, with \t as delimiter, microsoft excel and numbers).
Is this a common problem and is there any way to fix this?
Many thanks in advance!

Thanks for this report. I haven't seen this before.
The relevant code snippet from barcodemap.py is:
            try:
                barcode, value = line.strip().split()
            except ValueError:
                raise ValueError(
                    "Unexpected barcode map line format " "[{}]".format(self.name)
                )

It sounds to me like the file you are describing should work fine. My best guess is that there is a single line somewhere in the file that doesn't have a barcode or variant specified. You could try running a modified version of the above code locally on the file and see if you can spot the issue:
handle = open(mapfile, "rU")

for i, line in enumerate(handle):
    # skip comments and whitespace-only lines
    if len(line.strip()) == 0 or line[0] == "#":
        continue

    try:
        barcode, value = line.strip().split()
    except ValueError:
        print("found a bad line (no. {})".format(i + 1)

handle.close()

(Please forgive any syntax/formatting errors in the above).

Thank you so much, that worked! There actually where a couple of barcodes with no variant linked.

Glad this helped!


Merge chore/lodash to develop

Coverage remained the same at 100.0% when pulling 570127908c9a215fbfb48ceffe9f81bccbc152ac on chore/lodash into 4c6f86db67525d0db1f7c356e742dd62b8e22c13 on develop.


Update scoop section of README

@borkdude feel to make adjustments

Thanks! Does the auto-update now also work?


csintro1 and csintro2 edits

~(requires Microsoft/pxt-common-packages#427 for multiplayer lesson)~ see comment

csintro1/{orientation->intro}
Multiplayer lesson (csintro2/logic/multiplayer).

I can potentially write up another multiplayer lesson to stick towards the end of csintro1, but extensions are not taught until csintro2 so it would be as an appendix - type item

typo fixes
All lessons now have codecard images

Presumably this will fail travis due to the snippets in csintro2/logic/multiplayer, but it does pass checkdocs locally

will need pxt-common-packages bump to get access to new apis for build to pass here~

Also will add a SUMMARY.md in courses in a few minutes so that when Microsoft/pxt#4847 gets merged in arcade is ready to go~

Good to merge whenever now~


Toggle to enable/disable without uninstalling

Is it possible to add a toggle to disable the HLTB section without having to uninstall? It's useful when some themes cause unintended overlap or incompatibilities.
A minimal mode would be pretty cool too

Yeah I think that should be possible.

That would be great. Any thoughts on a minimal mode? I was working a plugin to implement hltb before gett8ng interrupted by work stuff.
I had something like this in mind along the side of the game view. I could whip something up in a PR if you like the idea

Main:  12.5       |
Extras: 15         |
Complete: 25.  |
‐----‐-------------------

Would it be possible to make the HLTB panel collapsible? Perhaps that would sufficiently reduce the impact on Clean Game View and ProtonDB labels while still allowing the panel to be quickly expanded and be glanced at.

See https://github.com/hulkrelax/hltb-for-deck/issues/2#issuecomment-1317429696. I've addressed this with Clean GameView compatible styles for the HLTB for Deck plugin


VS Code extension passing the outcome back to TTK extension

For the VS Code deep-linking integration scenario, we need to be able to pass the outcome back to the TTK extension:
Related issues:

#5206
#5205
#5204

Initial code sample:
const result = await vscode.commands.executeCommand(
   'fx-extension.createprojectfromkiota',
   [
    ${path-of-spec},
    ${path-of-plugin-manifest},
    ${kiota-folder},
    true // Decide whether to scaffold a new project
   ]
  );

Note: The parameter kiota-folder shall be implemented in the second iteration.
Acceptance Criteria

When Kiota extension is called from TTK extension, i.e. with the input parameter source="ttk" over the deep-linking as specified in #5112, it will call the command "fx-extension.createprojectfromkiota" when the plugin manifest was successfully generated.
When there is no TTK flow in place (i.e. when there is no "source" parameter passed to Kiota or when the value is not "ttk"), the flow won't change compared to the current implementation and the given command won't be executed.
The following parameters will be passed with this command:

path-of-spec: Path to the OpenAPI description
path-of-plugin-manifest: Path to the plugin manifest file generated by Kiota
kiota-folder: Path to the ".kiota" folder
scaffold: always set to true for this scenario.

The ".kiota" folder shall contain the following files: worskpace.json, api manifest, and the original OpenAPI spec.
Kiota still needs to work as before when the flow was not started from TTK, when TTK extension is not installed, or when the Kiota integration is not enabled in its options.

We should definitely go with "command-base" approach.
Besides path to spec and path to plugin, I also believe we should pass .kiota folder, with the worskpace.json, api manifest, and the original OpenAPI spec, so all the "maintenance" features of Kiota will be possible.
I suggested this to Junjie today, and we are on the same page. We should bring this up to Wei in tomorrow's meeting.

After meeting, we decided to keep the implementation for now as it is, with no .kiota folder:
const result = await vscode.commands.executeCommand(
   'fx-extension.createprojectfromkiota',
   [
    ${path-of-spec},
    ${path-of-plugin-manifest},
    true // Decide whether to scaffold a new project
   ]
  );

After having the integration in place, we can evaluate the work and improve the experience by adding the .kiota folder as part of the call back to TTK.

Yep, reflected in the ACs above now.


Required metadata fields don't appear with a red box if you don't complete them

I'm using Dspace 7.5 and basing my repository's submission-forms on the type-bind feature. For some types of metadata fields with certain configurations if you make an empty submission of an item (meaning: you upload a file, select the type of file, but don't complete any metadata field) the red box indicating a required metadata field won't appear, thus making it more difficult for the user to know which metadata they're missing. If you only miss that field, the red box won't show either.
Steps to reproduce the behavior:

Modify the [dspace]/config/submission-form.xml file making the field "type" the first one and adding the "type-bind" tag to the other fields (https://wiki.lyrasis.org/display/DSDOC7x/Submission+User+Interface#SubmissionUserInterface-ItemtypeBasedMetadataCollection)

Add some fields with these specifications (all must have the type-bind tag and be required):
-repeatable=true, input-type=textarea
-repeatable=false, input-type=onebox
-repeatable=false, input-type=date
-repeatable=false, input-type=dropdown
-repeatable=true, input-type=list
or use my submission-forms.xml (you'll have to add dc.relation.source to your metadata registries)
submission-forms.zip

Try to submit an item without completing it's metadata and see which required fields shown the red box and the required text.

Here you can see 2 required fields behaving as expected ("Filiacion" y "Palabras clave") and 2 ("Editorial" y "fecha de publicacion") that don't:

This should be re-tested with 7.6.  It's possible this was related to https://github.com/DSpace/dspace-angular/pull/2133   There were some additional fixes to the submission form validation which were also added in 7.6

I've re-tested this on 7.6 and now none of the incomplete fields show the red box, not even the ones that worked on 7.5.
If I click on the field and move along to another without completing it, the red box appears, but as soon as I click on "deposit" all the incomplete fields lose the red box


Errors and Problems don't update from /lib/bs/compiler.log

this might be a duplicate of #34. I post it as a new issue since it has nothing to do with Angular or a specific project.
Description: VS Code does not update errors (or the lack of) from the complier-log. Neither Problem-View nor "red underlines".
Since this a very basic function, I suspect it has to do with my environment which is Node 14, Ubuntu 20.04 and VSCode 1.52. I used a new clean build of VSCode and only installed rescript-vscode 1.0.2.
Steps: See the the Video to reproduce
https://user-images.githubusercontent.com/447570/103289983-c453d200-49e8-11eb-8510-d5cf51d7e0d4.mp4
Observations:

The Compiler-Log is always correct
Restarting VSCode updates the VSCode views, but it still does not update again

Thanks so much for all your hard work. Let me know, if I can do anything to help track down the issue. (I'm very dedicated, this is the only issue that prevents my team to switch to ReScript).

It gets weirder :( I tried to debug the extension. When I set a breakpoint at the beginning of "sendUpdatedDiagnostics" in the server.ts - and press "continue", it just works. As soon as I remove the breakpoint, it stops working :(

Update: I found the issue! It is a race condition with chokidar and fs.readFileSync. It can be fixed by provideing an option to chokidar.watch like described here https://stackoverflow.com/questions/60460751/getting-empty-string-from-fs-readfile-inside-chokidar-watchpath-file-onchang
I experimented and found out that a treshhold of 1 millisecond is enough:
awaitWriteFinish: {stabilityThreshold: 1}
PR will follow!

Thanks for the PR =D Closing as this is now fixed: https://github.com/rescript-lang/rescript-vscode/pull/56

Thanks for the PR =D Closing as this is now fixed: https://github.com/rescript-lang/rescript-vscode/pull/56


Removed the hardcoded directory of the DLL

The directory of the DLL should be set in the windows path

Nice one, thanks.


Uploaded gems contain wrong version number

The gem on rubygems.org for 2.0.3 has a value of 2.0.2 in the gemspec file.  Older versions also have this: 2.0.2 says "2.0.1" and so forth.
This breaks gem2deb.

Hi @bk2204, thanks for pointing it out. I'm going to investigate. The packaging is an automated process, I may have to review it.

@bk2204 I've just downloaded the gem from RubyGems, and the version is correct:
--- !ruby/object:Gem::Specification
name: public_suffix
version: !ruby/object:Gem::Version
  version: 2.0.3
platform: ruby
authors:
- Simone Carletti
autorequire:
bindir: bin
cert_chain: []
date: 2016-09-30 00:00:00.000000000 Z
dependencies:
- !ruby/object:Gem::Dependency

Can you provide me more details of where you saw the invalid versions?

Here's what I'm seeing:
genre ok % sha256sum public_suffix-2.0.3.gem
69cf11137edc0cb78b21592e9fdc34661c4774d4359e172737aa747537f75619  public_suffix-2.0.3.gem
genre ok % gem unpack public_suffix-2.0.3.gem
Unpacked gem: '/tmp/user/1000/public_suffix-2.0.3'
genre ok % cd public_suffix-2.0.3
genre ok % grep 2.0.2 public_suffix.gemspec
# stub: public_suffix 2.0.2 ruby lib
  s.version = "2.0.2"

I believe that version is what gem2deb is using.

I confirm the issue. Oddly enough, the gem in the repo has the right version. I rewrote the packaging feature, hopefully it will fix the issue.
However, please note that the new .gemspec will have Ruby code in it (as also happens for newly created gems in Bundler), therefore whatever packaging system you use should be able to understand it. Bundler does.

I don't expect that to be a problem.  gem2deb probably already handles that, and if it doesn't, I'll send a patch.


GPUAggregator: Fix Texture/Buffer resource leaks.

For #3039

Background
GPUAggregator: Couple of resources are not properly deleted, collect and delete these resources.

Change List

GPUAggregator: Fix Buffer/Texture leaks

Coverage increased (+1.9%) to 62.224% when pulling 07668d0cf7cfb2fbe21940ebe142d95c5f8b91ff on SGMemoryLeak into 6d8080bc870b15e449db106f74837a790de0bc08 on master.

Can you upgrade luma.gl to 7.0.1 which includes https://github.com/uber/luma.gl/pull/1087

Can you upgrade luma.gl to 7.0.1 which includes uber/luma.gl#1087

@Pessimistress Upgraded to 7.0.1, no new issues found in tests.


Add support for Nix flakes

This PR adds a flake that exposes vast as an app and a NixOS module. A usage example will be added in a follow-up PR.

@GTrunSec this might be interesting for you.

the CI issue from inputs.nix-filter in overlay.nix. It could be solved by flake-compat. let me fix it.


[question] transfer intake-stac to Intake GitHub organization?

I've been wondering for a while if it makes sense for this repo to live in the pangeo-data org, or if it would be better to have it elsewhere. It may make sense to put this project with the Intake Org (@martindurant), or if that doesn't fly, perhaps closer to other STAC tools.
In my mind, the goals of a potential transfer would be to increase the package's visibility and encourage outside contributions.
Pinging a few folks that have participated in the project to date. @scottyhq, @matthewhanson, @andersy005, @jsignell, and @martindurant.

No objection from me, of course, but I'd be surprised if the move would do much for discoverability.
On June 20, 2020 1:29:57 AM EDT, Joe Hamman<EMAIL_ADDRESS>wrote:

I've been wondering for a while if it makes sense for this repo to live
in the pangeo-data org, or if it would be better to have it elsewhere.
It may make sense to put this project with the Intake Org
(@martindurant), or if that doesn't fly, perhaps closer to other STAC
tools.
In my mind, the goals of a potential transfer would be to increase the
package's visibility and encourage outside contributions.
Pinging a few folks that have participated in the project to date.
@scottyhq, @matthewhanson, @andersy005, @jsignell, and @martindurant.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/pangeo-data/intake-stac/issues/47

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Intake org makes the most sense I imagine.

No objection from me either. 👍 for moving it to intake org

To move would require one person with admin rights to the repo and a member of intake org?
Let me know if you think you have enough votes.

Intake org sounds good to me as well!

Sounds good, stac-utils is also an option but I think the Intake org makes more sense.

Let's do it. Will add @martindurant as an admin here.

Done. Please check that owners still have the permissions they expect.

@martindurant - I don't seem to have any owner/admin rights here (not sure about others).

I explicitly added you. Some people seem to have made it automatically across.

Thanks @martindurant. Going to close this now.


implement conflictsWtih feature in trait definition

to fix #553

add unit tests

Signed-off-by: roywang<EMAIL_ADDRESS>

@captainroy-hy It's fine that there's only unit-test. But I hope you have already tested in real case use our current demo.

Yes, I have already tested it by deploying the changed webhook into vela cluster manually.
But it seems AppConfig/Component webhooks has not yet enabled as mentioned in #661 ?

@captainroy-hy  You could raise another PR to enable them by default.


Use the traits added to the Rust 2021 Edition prelude

Follow up https://github.com/rust-lang/rust/pull/96861.
This PR uses the traits added to the Rust 2021 Edition prelude.

The TryInto, TryFrom and FromIterator traits are now part of the prelude.

https://doc.rust-lang.org/edition-guide/rust-2021/prelude.html

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.
Please see the contribution instructions for more information.

:pushpin: Commit 1626762fe41927957b7f0227e0436c8ed01ccd17 has been approved by epage

:hourglass: Testing commit 1626762fe41927957b7f0227e0436c8ed01ccd17 with merge b3f6772a664669569fa1fbf2a2369a2040f4be11...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing b3f6772a664669569fa1fbf2a2369a2040f4be11 to master...


Rename the Translate parameter and update the help to reflect truth.

Rename the Translate parameter and update the help to reflect that it is stuck in index space.
Bug: 87783

If we're going to make any change to this now, my preference would be to add a "Use World Space Units" toggle, like we have in several other SOPs, and have it apply to both the Translate and Pivot parameters.

I agree that would be the perfect.  But I don't think this change in any way hinders us from doing that at some point.  In the meantime, it can hopefully reduce confusion from people just glancing over the parameter interface.  (I also can't do anything larger at this point as 18 is locked)

Good point.  I've added OVDB-125 to track this request.


Defect-56495-Fix

Bug Fix for user was able to send connection request to himself.Defect #56495

Review comments will be taken as new tasks


Add a post to thread in Behat test so link to thread shows

This Behat test fails for me as the "Test Moved Thread" is not shown when viewing the board without the thread having a post.

Works great, thank you!


Overriding addEventListener to augment event objects

Ultimately, what I want to do is to describe the following trick:
const element = document.createElement("div");

element.addEventListener("click", event => {
  event.foo = 123;
});

As you see, my <div> element intercepts all "click" events and adds a new property to them, so whoever attaches a "click" listener later will see this new property.
A practical example would be a custom UI element that represents, for instance, a chess board, and adds row and col properties to every mouse event, as the consumers of the UI element shouldn't need to convert the plain x and y coordinates to the cell coordinates.
My attempt to describe this failed:
interface MyMouseEvent {
  foo?: number;
}

interface MyElement extends HTMLElement {
  addEventListener(type: "click", listener: (ev: MyMouseEvent) => any, capture?: boolean): void;
}

tsc complains that the HTMLElement interface is incorrectly extended:
TS2430	Interface 'MyElement' incorrectly extends interface 'HTMLElement'.
  Types of property 'addEventListener' are incompatible.
    Type '(type: "click", listener: (ev: MyMouseEvent) => any, useCapture?: boolean) => void' is not assignable to type '{ (type: "MSContentZoom", listener: (ev: UIEvent) => any, useCapture?: boolean): void; (type: "MS...'.
      Type '(type: "click", listener: (ev: MyMouseEvent) => any, useCapture?: boolean) => void' provides no match for the signature '(type: string, listener: EventListener | EventListenerObject, useCapture?: boolean): void'

When you have overrides that is also an overload, you have to provide at least one overload that matches the overridden function.  This is fairly clearly implied by the error:
interface MyElement extends HTMLElement {
  addEventListener(type: "click", listener: (ev: MyMouseEvent) => any, capture?: boolean): void;
  addEventListener(type: string, listener: EventListener | EventListenerObject, useCapture?: boolean): void;
}

This works nicely, indeed. Thanks!


Throttling section should note that max message size is different between c2d and d2c messages

[Enter feedback here]
Questions about IOT max message size in internet search return the Throttling portion of the doc that notes 256KB as the maximum message size.  However it's not till linking to further in the doc does it point out that cloud to device and device to cloud max messages sizes are different.
Your cloud-to-device and device-to-cloud throttles determine the maximum rate at which you can send messages -- number of messages irrespective of 4 KB chunks. Each message can be up to 256 KB which is the maximum message size.
It would be helpful if the separate limits were called out in the Throttling section.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec6fc6a5-9bf6-889e-075d-b5b009e67d1f
Version Independent ID: f3d6fa56-a494-fec8-50e3-f8682c90ac42
Content: Understand Azure IoT Hub quotas and throttling
Content Source: articles/iot-hub/iot-hub-devguide-quotas-throttling.md
Service: iot-hub
GitHub Login: @robinsh
Microsoft Alias: robinsh

Hello @dave-read Thanks for the feedback.
Our SME will review your feedback soon.

Added some specifics about the max message size for D2C versus C2D messages.
#sign-off

#please-close


Fix for Issue #245

Description of the Change: This PR fixes a broken link in the tutorial documentation.
Benefits: Fixes a broken link in the documentation and links to the correct location. This change is a result of expval being merged into measure
Possible Drawbacks: None, in the foreseeable future.
Related GitHub Issues: Issue #245

@co9olguy missed that, my bad. Made the required changes!

Thanks @RohitMidha23!


Fixes overlapping text labels in animation editor timeline

Looking at the timeline at different zoom levels...
in master:
https://www.dropbox.com/s/uhxplb1drqbyo6f/anim-text-master.mp4?dl=0
with PR:
https://www.dropbox.com/s/hf72ta1xd8bjayk/anim-text-pr.mp4?dl=0

Thanks, looks good.

I can't reproduce this in 3.0.3. I assume that the PR that caused this issue isn't in (yet). I'll leave the cherrypick label to reevaluate for 3.0.4

Now that Godot 3.1 has been released, we only plan to cherry-pick critical bug fixes to the 3.0 branch, unless there is very strong support in favor of a specific non-critical issue. Removing cherrypick label for 3.0.


[PostgreSQL] Cascade delete view doesn't work

When deleting a view (Right click > Delete), the checkbox Cascade delete seems not to be taken into account.
The generated script (via button View script) is always the same:
DROP VIEW <shema>.<table>;

With the checkbox checked, it should be:
DROP VIEW <shema>.<table> CASCADE;

It's working fine with tables.
DBeaver version: 6.0.3

I had been suspecting such an issue with cascade delete of views in PostgreSQL as well, but didn't yet find the time to look into it.

verified

Thanks a lot!


Deployed 20.09, but unable to get Controller UI

We are following the document OpenNess-Network-edge to enable the Controller UI. It seems the document is not updated for release 20.09, as we are unable to find the .env file to update INFRASTRUCTURE_UI_URL.
Please guide me to updated documentation.
Below are the cluster snippets, please let me if more details required.
[root@edgecontroller2 opt]# kubectl get pods -n openness
NAME                                                       READY   STATUS    RESTARTS   AGE
docker-registry-deployment-54d5bb5c-rngpc                  1/1     Running   0          27h
eaa-5c87c49c9-48kjq                                        1/1     Running   0          14h
edgedns-c9vtq                                              1/1     Running   0          14h
interfaceservice-ddbjz                                     1/1     Running   0          14h
nfd-release-node-feature-discovery-master-b5d78f89-vn5bf   1/1     Running   0          26h
nfd-release-node-feature-discovery-worker-26w77            1/1     Running   0          14h

Hi @AmanThakral02
The controller UI is now automatically installed as part of the OEK. The above section in the Getting Started guide is obsolete. We will remove that section.
Please refer to this page in order to get the dashboard installed


Segfault on repeated dataset generation (observed on: kmeans clustering, resampling, multiphase ASL)

Reproducible on all platforms. Open 3D data, Kmeans clustering widget then repeatedly click 'Run'.

Backtrace on Linux suggests a known PySide issue witih retieveMetaObject:
Thread 1 "python" received signal SIGSEGV, Segmentation fault.
0x00007ffff5bb7e64 in PySide::DynamicQMetaObject::update() const ()
   from /home/ibmeuser/.conda/envs/qp/lib/python2.7/site-packages/PySide/../../../libpyside-python2.7.so.1.2
(gdb) bt
#0  0x00007ffff5bb7e64 in PySide::DynamicQMetaObject::update() const ()
   from /home/ibmeuser/.conda/envs/qp/lib/python2.7/site-packages/PySide/../../../libpyside-python2.7.so.1.2
#1  0x00007ffff5bbc486 in PySide::SignalManager::retriveMetaObject(_object*) ()
   from /home/ibmeuser/.conda/envs/qp/lib/python2.7/site-packages/PySide/../../../libpyside-python2.7.so.1.2
#2  0x00007ffff3fc3f07 in Sbk_QLabel_Init () from /home/ibmeuser/.conda/envs/qp/lib/python2.7/site-packages/PySide/QtGui.so

Occurs in regular as well as frozen builds

Not yet reproduced on pyside2 branch, but do get possibly related error:
PySide2.QtGui.QStandardItem' object has no attribute 'graphicsItem'

Details:

Traceback (most recent call last):
File "/home/ibmeuser/ibmecode/build_scripts/build/quantiphyse/quantiphyse/packages/core/clustering/widgets.py", line 241, in run_clustering
self.update_plot()
File "/home/ibmeuser/ibmecode/build_scripts/build/quantiphyse/quantiphyse/packages/core/clustering/widgets.py", line 277, in update_plot
self.reset_graph()
File "/home/ibmeuser/ibmecode/build_scripts/build/quantiphyse/quantiphyse/packages/core/clustering/widgets.py", line 266, in reset_graph
self.plotwin.removeItem(self.plot)
File "/home/ibmeuser/.conda/envs/pyside2/lib/python2.7/site-packages/pyqtgraph/graphicsItems/GraphicsLayout.py", line 149, in removeItem
ind = self.itemIndex(item)
File "/home/ibmeuser/.conda/envs/pyside2/lib/python2.7/site-packages/pyqtgraph/graphicsItems/GraphicsLayout.py", line 143, in itemIndex
if self.layout.itemAt(i).graphicsItem() is item:

AttributeError: 'PySide2.QtGui.QStandardItem' object has no attribute 'graphicsItem'

Since this is 3D data we should not be doing anything with a plot - that's the 'representative curves' option for 4D data.

Removing the spurious plot update for 3D data seems to make the segfault go away on Linux for 3D data but it is still reproducible for 4D data on repeated clustering with default settings.

Have changed widget to clear the plot each time rather than destroying it and recreating the plot widget. This seems to have cleared up the segfaults, although on repeated 4D clustering the following non-fatal error occurred:
QPainter::begin: Paint device returned engine == 0, type: 0
QWidget::repaint: Recursive repaint detected

Some segfaults seem related to the multi-select data selector in the Data Statistics widget (which is active by default). Removing the multi flag prevents a reproducible segfault on repeated resampling.

Another partial workaround: when data sets are replaced, avoid firing the data_changed signal once for the removal and another time for the addition. This allows the data selector to ignore changes where the overall data set is the same.

Reported by Tom O on running multiphase data. Reproduced on Mac and Windows.

Have not encountered this since switch to PySide2 - since segfault within Qt library v4 and PySide2 uses Qt5, it seems likely that this is now fixed. Closing, to reopen or raise new issue in the event of future cases.


Fixing Performance issue when withdrawn referrals are shown in SP das…

What does this pull request do?

Fixing Hibernate HHH000104 firstResult maxResults warning.
Now retrieving the data is a two step process, first we retrieve only the ID's using the Spec query
Then we retrieve the entity using the Id's which we got as a result of the previous query

What is the intent behind these changes?

When the fix for hiding withdrawn referrals was introduced in production, the performance issue started happening where the entire service was crashing because Hibernate did lots of pagination in memory. This fix was done as part of recommendation to fix the HHH000104 error.

Performance testing

As part of our team discussion, we decided to do performance test for the dashboard to make sure the new application is performing well after this change is introduced.

@kth13 Can this be rebased and merged? Is there something preventing this from going live?


Fixed #28603 -- Corrected comment in collectstatic's collect()

Fixes:
https://code.djangoproject.com/ticket/28603

I'm not sure if the comment adds any value as it states what can be understood from reading the code. Maybe # Check if the storage backend has a post_process() method. is worth keeping.

Agreed, though how about wording like # Storage backends may optionally define a post_process() method., since the clarification is more that it being missing is actually allowed, rather than just being extra careful?

Sure.


[Bug Report] Missing TinyStories model

Describe the bug
This model does not exist:
https://github.com/neelnanda-io/TransformerLens/blob/a417edd6227ce1d8da42e40debe3a3b5f87ece0f/transformer_lens/loading_from_pretrained.py#L120
I think it should be roneneldan/TinyStories-Instuct-1Layer-21M but I'm not certain: notice the different number of parameters of spelling error from Ronen
Code example
I found this while following the docs/README instructions for building docs. This bug :bug: should have been tested by a similar method (trying to download ALL configs from :hugs: (which is cheap) and checking that none fail)
Alternatively
from transformer_lens.HookedTransformer import HookedTransformer as HT
m=HT.from_pretrained("roneneldan/TinyStories-Instruct-1Layers-28M")

System Info
N/A
Additional context
N/A
Checklist

[ :white_check_mark: ] I have checked that there is no similar issue in the repo (required)

Same problem with roneneldan/TinyStories-1Layer-28M


Resource Explorer

Do you know is Resource Explorer being phased out? Or have the new Metric Alerts just not  made it there yet?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1f2bd9d0-af11-d684-051b-7ac8e611cca9
Version Independent ID: f83d6e85-4d52-6b7f-a79e-f3ed3f3d0a95
Content: Create a metric alert with a Resource Manager template
Content Source: articles/monitoring-and-diagnostics/monitoring-create-metric-alerts-with-templates.md
Service: azure-monitor
GitHub Login: @snehithm
Microsoft Alias: snmuvva

@DaveKlassen Thanks for the Comment. We are actively investigating and will get back to you soon.

@snehithm any insights on Resource Explorer roadmap + integration into Azure Monitor metrics?

Hi @DaveKlassen
It's likely an issue with metric alerts and not resource explorer.
Looks like we missed some steps because of which metric alerts are not showing up there. I will investigate this and get back to you with an answer/ETA.

Any update on this ?

It seems like this might be fixed because I see metric alerts in Resource Explorer now


Simplify collection initialization

Addresses VS message "IDE0028 Collection initialization can be simplified"

Is this really a thing?
The changes look fine so go ahead and merge, but is VS going to require as to micro-nanny all of the codez?

I thought I had approved this like a week ago 🤕


Is there an equivalent to shouldRasterizeIOS?

Svg.Text performs quite bad when transforming the <Svg>. Is there any way to rasterize the text as with the shouldRasterizeIOS property on a regular <View>?

There are probably some optimization opportunities here. Could split the calculation of the path for the elements, and the composition of the matrix with the path, to render it to the canvas. Such that if only the matrix transformation changes, it doesn't need to recalculate what to render, only the re-render the same content with a possibly different transform. This would also complicate the logic a bit, but essentially, having two different invalidation handlers, one for transforms (doesn't clear the cached path), and one for changes which can affect the content (clears the cached path), should speed up simple transform animations significantly.
And, looking at the code now, I'm starting to think the cached text paths are always released no matter what right now. I would have to step through the relevant logic to verify. I'm sure there's lots of low hanging fruit here.

Wow! That seems really great. Let me know if I can help out with something.

Would your proposed solution make my use of setNativeProps obsolete? If that would be the case I could switch to PureComponent instead of Component. As of now I'm prohibiting component updates via shouldComponentUpdate in the case when I only want to change the matrix (i.e via setNativeProps).

Well, using PureComponent would probably simplify reasoning about your code at least, but limiting updates and diffing, e.g. if you know that only exactly one property has changed on a single node, such as the matrix in this case, it is probably still faster to make the bridge set that single property directly on the node using the setNativeProps, and skip the lifecycle with all its property extraction, transformation, diffing, etc.
But, making sure that all nodes cache their paths, and reuse that if only the matrix changes, should certainly make rendering more fluid in both cases. And, correctly used data structures and property passing, such that all the PureComponents only ever need to do a single reference equality check each, for a use case dependent splitting of responsibilities into composed components and according to their relative update frequencies, should make the ux good enough for some unknown larger amount of rendering work.
Anyway, intelligently applied mutability can certainly speed up the hottest parts of your render loop, usually with a trade-off in reasoning complexity, in any single threaded von neumann architecture at least ;) In a more parallel (eg. opengl) or distributed processing unit/environment you probably want to avoid mutating shared state and synchronization as much as possible instead. And, if you need to render large amounts of work, you should probably look at moving over to the accelerated gl hardware asap.

I thing which would be very helpful is if you could make some representative performance tests that we can use to compare the effects of various changes. Alternatively, ensure the all nodes cache the path, invalidate if any content affecting property changes, cleanup correctly when detached, and make sure that changing the matrix property only causes invalidation of the hitareas and a rerender, no invalidation of the cached paths.

Ok, I'm with you regarding the performance tests. I could try to whip up something. Do you know of if there are any APIs in RN for measuring actual fps? I'm thinking of making a simple app with a bunch of Rect and Text elements which are animated over the screen, but I don't know how to measure performance objectively.
The other stuff (ensure paths are cached etc) is out of my league. I've never worked with objectiveC.

Ok, sounds good. I haven't actually spent almost any time on optimizing nor profiling React-Native yet, I would have to google around a bit first for the state-of-the-art. The next sprint at work will finally have some time allocated for this kind of work, so at that point at the latest I'll check the available tools. If rnsvg shows up as the top priority bottle-neck, or if we manage to fix any other potentially more fruitful optimizations first, then I'll be able to put something else than my free-time on this.

@msageryd I've now made some changes to the caching of paths, but I don't have any good performance tests yet so it hasn't been tested much at all. You can check it out here https://github.com/react-native-community/react-native-svg/pull/596
The changes were relatively minor in the end:
https://github.com/react-native-community/react-native-svg/pull/596/commits/149f4601084a4ba3cec56844e4c91ff4f2c4ef62
https://github.com/react-native-community/react-native-svg/pull/596/commits/db8f1da46b3439435f6b057897936955d229f4bb
The branch also supports nesting View inside Svg, and Svg inside Svg, the changes from this might have some performance penalty as well (at least on android).

@msand Sorry for taking long time to answer. I've been away skiing.
This is awesome news. I will try it out first thing next week. I will also try to make time for some kind of objective performance testing.

While testing it in a project, I noticed some regressions with the transforms, something stays stale in the cache, so the current work in progress isn't ready for production at least. Any help with testing much appreciated.

@msand Just an update.. I've been overloaded with work and I haven't had time to do any tests. This topic is very important to me, so I'll give it a good test for sure. I'm hoping to be out of this work load in a week or two.

Alright, looking forward to it 😃 The issues were caused by using texture view on android, so i reset the branch to before that and merged it in. The optimizations are available in the latest version.

@msand I upgraded from 6.2.2. to 6.3.1. There is something really fishy with text rendering. When I move around my shapes (dragging with fingers) the text is rendered at wrong positions (i.e. out of whack) on iOS, but it works as it should in the simulator. I don't know where to start looking for the problem.
Would you like me to send you a screen recording from the app before /after upgrade?

I recorded a screen capture. When I did this I noticed a pattern. It seems like some text is transformed along the wrong axis. Example: I have a rect with text inside. When I move the rect upwards (negative y), the text moves to the left (negative x) and vice versa. This occurs with text that is transformed (rotated). Straight (non rotated) text stays in one spot, i.e. it does not move with the rect at all.
Please tell me if you want to take a look at the recordings.

I managed to make some gifs. The first one is with RNSVG 6.2.2. Notice  the number in the rectangle as well as the measurement along the grey line.

The exact same codebase but with RNSVG 6.3.1. Notice that the number in tre rectangle is stays in it's original position, i.e. it's not transformed at all. The measurement is transformed along the wrong axis.

I'm back to this issue after working on some other stuff. There are two problems. I think that #2 is kind of the same issue as #709.

I'll go on and try to bisect the problem with the seemingly exchanged axis on the rotated text element.

I have zoomed in on the problem with the missing re-rendering of the text in the rect. It turns out that the <Text> element does not trigger a re-render when the x- or y-props are changed. This worked better in older versions. An ugly temporary solution is to assign a unique key property to the text.

I have now bisected the commits. This took some work, because not every committed version was runnable. I'm down to two suspects, which is as far as I can get.
Working as expected:
The last working commit was 149f460 - Improve path cashing on android.
Crashing:
The next commit is not runnable, db8f1da - Improve path caching ios. As soon as an SVG element should render the app freezes, sometimes with a black screen.
Not working as expected:
The commit after this is cd43fc1 - Optimize hit testing. This commit has the two bugs shown in my gifs above.
Conclusion:
The bug was introduced in either db8f1da or cd43fc1.
@msand do you get any clues from this?
Should I post this as a separate issue, or keep it in this thread?

At least one of the issue lies with the path caching. Would need to add a recursive releaseCachedChildPaths method to RNSVGContainer, traversing the tree while there's any cached paths, such that any nodes which depend on updated parent properties can rerender, or revert the caching logic altogether.

Regarding reverting the caching logic:
If this is avoidable it would be good. Text rendering was suffering hard from excessive redrawing before your caching fix. I haven't had time for any performance tests yet, though. So I actually don't know how much the caching brings in terms of FPS.

Btw, thanks for bisecting and narrowing down the issue. We can probably keep the discussion here for now, as the earlier messages are somewhat related to it anyway. But feel free to open separate issues if you feel like it, or come up with even better ways to describe them, it might help others investigate as well. Especially if you can make minimal reproductions, that would be great 👍
Regarding the text elements and x/y props, are you changing them using setNativeProps or using normal prop diffing?
Can you try reverting the change made to RNSVGNode.m in https://github.com/react-native-community/react-native-svg/commit/db8f1da46b3439435f6b057897936955d229f4bb#diff-fd13a4ce6718d799f74859c5145670a3L133, specifically the method:
 - (void)setMatrix:(CGAffineTransform)matrix

such that you call
    [self invalidate];

instead of
    id<RNSVGContainer> container = (id<RNSVGContainer>)self.superview;
    [container invalidate];

It's a bit hard to figure out your current setup without access to the code, and as I don't have any way to replicate the issue at the moment I'm not sure how to proceed either. Have you tried with the latest version btw?

@msageryd Published v7.0.0 now 😄

@msageryd Thought you might be interested in a very successful optimisation strategy I applied the other day. It works great to speed up animations/gestures where you're only transforming some parts of the content, or where only some parts of the svg content rarely but various layers need transforms and clipping.
It roughly goes like this: Cover the area you want to respond to gestures with a Animated.View/ScrollView, split the svg content you want to animate independently into separate svg roots and wrap them in a Animated.View, then connect the gestures to transform the entire results of rendering the svg content into bitmaps using RN transform arrays and useNativeDriver: true.
This way the svg doesn't need to rerender the bitmap at all, and it uses native Views to clip and transform the content instead.
https://snack.expo.io/@msand/soundcloud-player-fast-animation-cross-platform
There's a bit more info on medium: https://medium.com/@dnasleakim/the-fast-cross-platform-end-result-of-my-investigation-can-be-found-here-ed2f0ac79ac7
Expo required a bit of extra logic for Android. But the iOS version seems to work fine in the latest rn and rnsvg.
https://medium.com/@dnasleakim/and-for-the-grand-finale-the-fastest-possible-i-think-8eccf71f6e2c
Might be easier to follow the chain of optimisations in chronological order on my profile, as the responses became a bit of a tree over time.
https://medium.com/@dnasleakim/responses
E.g. the first change I made was based on looking at the time profile and noticing the endTransparencyLayer was the main time consumer, so I moved the opacity from being on thousands of rects onto a single G element instead, making it already quite usable.
Then, trying to make the bitmap smaller seemed to improve a bit, but the best was just not to rerender any bitmaps at all (especially screen sized), merely clipping and transforming the view of the bitmaps, invalidating the dirty areas and as little extra as possible.
In practice, this runs the whole interaction of the app using only native code, the js is only used to set up the native view hierarchy which then does the initial single render of the svgs, sets up the native gesture responders and animations, and gives full 60fps interaction.

@msand, wow thanks!
This is very interesting. For now I have ok performance, but I will need to increase the speed when we take on larger projects (i.e more svg shapes). It would also be good with a bit more speed for users with older devices.
I'll dig into this, for sure.


chore(misc): add Node 7 to Travis CI

Hmmm... in theory, we should only need to run the fibers tests on node 4, because that's what Meteor uses.

Yeah but can you configure travis for that?
I didnt have time to dig deeper but looks like it wont be installed on node 7 (failed to compile)
On my local linux ive installed node 7 and fibers and it worked well..

@DxCx Isn't the issue with the failing tests that we configured travis not to allow sudo?

well, fibers is the one to break, i've opened this laverdet/node-fibers#331 issue..

will apply as part of tweaks since i have it working on top of them already.


Add NamedTuple#key_for? and NamedTuple#key_for

Adding an extension to NamedTuple that I've used in the past in case there is interest.
Adds...

NamedTuple#key_for : Symbol
NamedTuple#key_for? : Symbol?

What is this useful for?

Ideally, we'd have some kind of interface similar to Indexable for maps, perhaps Mappable.
As extending from std's Hash is frowned upon, a module would definitely aid in implementing map-like objects.
@straight-shoota this is useful if you have a NamedTuple and you want the key for a value, an identical justification as for Hash#key_for
I sense some disdain for NamedTuple amongst core crystal contribs, is there any particular reason that this and other Mappableesque methods from Hash are not valid in the context of NamedTuple?

I understand what this is for, but I fail to imagine an example where it would actually be useful with a named tuple.
And yeah, many people frown on NamedTuple. It's neither a generic container nor struct type. I believe the main reason it exists in the language is for named arguments. Anything else you shouldn't use NamedTuple.

I sense some disdain for NamedTuple amongst core crystal contribs, is there any particular reason that this

The main reason is a NamedTuple is not meant to be used to model data.  It simply is a container for named arguments.  Using it like a Hash or as a means to pass around data is usually not the best option.  Is there a reason you can't just use a Hash?

I understand what this is for, but I fail to imagine an example where it would actually be useful with a named tuple.

Say... you have args splat and want a key for a value in the args splat.

I've found NamedTuples have utility for inline records where the external declaration of a struct, without any useful methods, is not particularly beneficial. They're quick, dirty, and not that hard to pull into a struct if found necessary.
Is there any justification as to why this should not be part of the NamedTuple API that does not consist of "do not use NamedTuple"?

They're quick, dirty, and not that hard to pull into a struct if found necessary.

Have you seen https://crystal-lang.org/api/master/toplevel.html#record(name,*properties)-macro ? Nearly as simple as a NamedTuple but much more flexible.

Have you seen https://crystal-lang.org/api/master/toplevel.html#record(name,*properties)-macro ? Nearly as simple as a NamedTuple but much more flexible.

Yes, I use record quite often. These also have to be declared outside of a method scope.
Not every library author reads the crystal meta enough to realise this pattern is not favoured, I don't think extending the functionality of NamedTuple's API is the issue here. There's also nothing in the NamedTuple API documentation that discourages its use.
For the record it says...

You can think of a NamedTuple as an immutable Hash whose keys (which are of type Symbol), and the types for each key, are known at compile time.

This is quite handy if you want to get correctly typed values out of a map. Getting serious deja-vu with this discussion, lol
I say drop NamedTuple (I feel as if this has previously been discussed), or make it explicitly an argument type, or provide new interface that abstracts map-like objects, e.g. Hash, NamedTuple, in-memory data stores, etc


Further improvements after #23

Fix UI links to the YARN RM. Store the RM last queried in the backend status info and use that for the links.
Disable progress animation. It turns CPUs into space heaters.

Still no love with the Travis integration, even after removing and re-adding it.
https://travis-ci.org/Valassis-Digital-Media/yarnitor/builds/396389478


Allow configuring an additional pool metadata registry when starting wallet server

Context

The wallet currently fetches pool metadata from all pool remote servers. Not only this present some security risks for cardano-wallet (denial of service, although the wallet is being quite defensive about things here), but it is also inefficient since every wallets have to fetch many pool metadata servers (which can be arbitrarily located on the planet).
Beside, IOHK has developed a pool metadata aggregation server that has been deployed. The server can be used as a proxy for fetching pool metadata.
Decision

Revise the logic fetching metadata to allow fetching them from a different URL, falling back to the URL specified on-chain when the connection with the proxy fails.

Allow configuring a proxy via a new command-line optional option [--pool-metadata-proxy URI]; when provided, this should become the default URL from which metadata are fetched. When not set, the wallet should fallback to the original metadata URL defined in the certificate.

Acceptance Criteria

There must be a new option in the serve command for defining a metadata proxy
When set, the wallet must try fetching from this URL first.
Upon HTTP Exception, the wallet may fallback to the original URL specified in the certificate.
There should be sufficient logging to observe what is happening.

Some precision about 3. => The registry proxy also supports pools' blacklisting. So it is possible that the server would reply, but not positively, in which case, the metadata should NOT be retried. The wallet may only retry when it fails to establish the connection with the proxy (because down or anything).

Development

Add a command-line option to allow specifying a metadata proxy. See #1884

QA

:+1: tested manually against mainnet and latest deployed verison of SMASH.


Further DU Campaign-Current Projects Research

What
After the call with Camille from Tdh last 15th Nov., we were advised to focus on the DU's 9 Principles instead of their 10 Demands. Also, to look at the MyDestination app
http://destination-unknown.org/app/
Therefore, further research is needed as well as users case scenarios to present the potential of DML to the leaders of DU during our next call.
1-Research about the projects that DU are working on currently (to learn from)
-What projects are similar to DML? Where? How is the data used?
http://destination-unknown.org/mario-project-to-protect-children-on-the-move-in-europe/
http://destination-unknown.org/app/
2-Identify what ACTIONS can DML support (from our previous doc.
https://docs.google.com/document/d/1Qs_NNAsW-L4AH-ZvwFSvmc8aw6i9gixEV-r_BPrhAZ0/edit
-We believe in youth
http://destination-unknown.org/we-believe-in-youth/
There are two Core Actions in this Framework which DML speaks to:
-CORE ACTION 4 Support Refugee Youth physical and emotional wellbeing.
-CORE ACTION 7: Generate data and evidence on
Refugee Youth to promote accountability to youth (DML works with facilitators to collect drawings and data from programmes, which may be coordinated by the young refugees themselves)
3-Users case scenarios
Considerations

Draw My Life focuses on the South and Eastern Europe.

UseCase-for-DU-Presentation.pdf

Add copy to Use Case > We Believe in Youth.

[Beneath title]
There are two ways in which Draw My Life can support the core actions identified in this Report:
[More explanation with the core actions]
Core Action 4: By highlighting - through the drawings and stories of the children, and the testimonials of field workers gathering drawings - the importance of services and activities for the mental, emotional, and physical health and happiness of youth refugees.
Core Action 7: By gathering and supplying quality data on young refugees and their context, across different sectors, to help humanitarian actors plan and design for youth programming.

Add copy to first part of use case - field worker portal

Label = Draw My Life Portal (not API)
Copy: The interactions between the field worker and the child are very personalised. They gather details about the child's experience, plus demographic data, and attach this to the uploaded drawing. They are trained in data collection and attach safe data that will not identify the child.
[Will finish this 8/12!]

USE CASE: MY DESTINATION APP
I feel that MyD and DML are doing quite different things. MyD is like a personal diary and is for use by the child. DML is collecting anonymised data in support of child refugee rights, and it's for use by the fieldworker.
I think your first point is the way we would go - i.e. MyD (with the map-like UI) gives us a nice reference and framework for displaying data.
However, there may be an opportunity for collaboration if, say, the MyD map is hot-spotted with drawings and stories. This gives the children an opportunity to view the experiences of others (even though anonymous). Not sure about this, but we could explore with DU in the call.
I don't think we would connect actual drawings with the children's diary entries in MyD because (1) child doing the drawing would need to be using MyD also which is very unlikely; (2) issues over identifiable information.
In terms of the use case visual:

I'd have a big visual of MyD map UI (take from screen cast or use a large 'map' icon?) in the middle, and show (as you have already) how the DML data fits onto it. On the left-hand side of the map, have an icon of DML workers uploading data into our portal, which feeds the MyD app. On the right-hand side of the map, have the Children adding data about their stories into the MyD app. Shows how the two platforms 'come together'.

http://childhub.org/sites/default/files/webinars/screencast_-_complete.mp4

Hi Cath,
I looks easy to get it done but it takes time to have everything in place in a clear order that make sense. I think this is now clear.
Regarding the MyDestination App use case, your comment about (On the right-hand side of the map, have the Children adding data about their stories into the MyD app. Shows how the two platforms 'come together'). I don't think this is a good idea. They are two different app and I think it should remain as it is.
Now, what I like about the MyDestination app is how data is presented by using figures and percentages and tags to read more about story of the child. I think this is what we could take away for us to improve our app. This is the reason I kept that use case as it is.
I hope this works.
Let me know your thoughts.

https://drive.google.com/drive/u/0/folders/0BywYxaOTU-6uRnJnczRrT0VkcDA


Inherit Jekyll's rubocop config for consistency

This PR is the result of adding inherit_gem:\n jekyll: .rubocop.yml to .rubocop.yml and running rubocop -a so that this project follows Jekyll core's coding styles for consistency like other core plugins. This way, as Jekyll's Ruby style changes, so too will this project's.

Travis fails with Ruby 2.0 because some dependencies require at least Ruby > 2.1.

As Jekyll don't support Ruby 2.0 anymore that shouldn't be a problem.

@jekyllbot: merge +dev


feat: Use Rack::Events for instrumentation

This is an alternate implementation of the Rack instrumentation that leverages the Rack::Events API instead of a customRack::Middleware.
Why am I suggesting we change this instrumentation? At GitHub we leverage Rack::BodyProxy to write Rack Request logs after the request is complete, however Rack span is already finished and its related Context has already been detached. This means we are not able to correlate request logs to our traces.
The advantage of using Rack::Events is that handlers are triggered during difference stages of a request, including for deferred operations like Rack::BodyProxy, as opposed to middlewares who only are invoked inline.
The disadvantage of this API is that it makes managing the request more difficult and we have to track the Context positions to detach in the Rack::Env.
This implementation will be released along side the existing instrumtation to give users the option to use the middleware instead of the Rack::Events handler until we are able to run this in some of our heavy production workloads.
Other noteworthy things:

The http.proxy span has been converted to a Span Event and ignores the record_frontend_span option
There are no new events added that we brainstormed in this discussion: https://github.com/open-telemetry/opentelemetry-ruby-contrib/pull/342#discussion_r1113462298
All configuration options for this middleware that required special processing/registration were moved into the Rack::Instrumentation.install
The Rack event now includes the time it takes to write the response to the socket.
Sinatra 1.4 depends on Rack 1 so we must support both Rack Middleware and Events unless we choose to drop support for it.

Fixes https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues/341 Related https://github.com/DataDog/dd-trace-rb/pull/1746

moving back to draft until I am able to determine why tests are failing

Tests are failing for combination of rack >= 2.2 and rack test 2.1

I have opened an issue with rack-test https://github.com/rack/rack-test/issues/335
Hopefully I will be able to dig in something soon and see what is going on.

jeremyevans set me straight. The test case setup was wrong.

OOOOOOOOPPPPPPPPPPPPSSSSSS I had set this to auto-merge by accident. I hope that is not a problem.


Use capital letters only if needed in EN/NL names

I am allowed to add English vernacular names to the early alert web application (see https://github.com/riparias/early-warning-webapp/issues/165#issuecomment-1173893508) 🥳
@timadriaens: based on your work on the EU concern list of yesterday, I removed capital letters where not needed, i.e. everywhere execpt people name, e.g. "Sosnowski ...", and regions or countries like "Chinese ...", "Manchurian ...". I would like to apply these changes to the official LIFE RIPARIAS target species list too.
Could you please let me know if I did it correctly about the English and Dutch names? May I apply the same principle to the French names as well? Thanks.

Another thing modified: Australian Yabbi should be Australian yabbi.


Set X-Forwarded-Proto to enforce https in emails

Pull Request Test Coverage Report for Build 615

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.977%

Totals

Change from base Build 613:
0.0%

Covered Lines:
3657

Relevant Lines:
3657

💛  - Coveralls


update vndor modules

Signed-off-by: liuwei<EMAIL_ADDRESS>

refer to https://github.com/open-cluster-management/backlog/issues/15168

/lgtm


css module

[ ] 1. css module pros and cons
[ ] 2. postcss|autoprefix|
[ ] 3. sass|less|

css-loader
css-module
points follow:

exception, :global
composition, compose: compose multiple selectors from current module
dependencies, compose selectors from other module


[Relay] Fix a bug in tensor_array_scatter

tensor_array_scatter constructs helper functions according to dtype
and shape of element. When there are multiple scatter operations with
same dtype and element shape but different indicies_shape, there will
be name conflict in prelude.
@kevinthesun  @zhiics Please take a look, thanks.

cc @mbrookhart @jroesch

ping @kevinthesun please followup

@kevinthesun  Sorry for late reply, I've enhanced get_name, please take a look.

@kevinthesun Could you please take a look again? Thanks

@lixiaoquan please fix the conflict, I'll merge this.

@masahi It is rebased, thanks for reviewing


Export existing configuration into init_data.json

Would be nice if we could export existing settings into a init_data.json file.
This would make it easy to deploy new instances quickly from an existing instance.
Or reuse and deploy setting into new environments.
Related: https://github.com/casdoor/casdoor/issues/2461

@Sjoerd82 Data exported to file is supported, see docs: https://casdoor.org/docs/deployment/data-initialization/#export-config-data

Thanks, this helps a lot!


functions

are functions first class like go-lang?

Yes

can you give an example for it, or it is feature that will be there in july like generic?

Only very basic stuff works right now. So yes, just like generics.

oh, oki then
best luck on that man


pd.read_json() does not support JSON string input

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): MacOS 10.15.4
Modin version (modin.__version__): 0.7.2
Python version:3.7.7
Pandas version: 1.0.1
Ray version: 0.8.0
Code we can use to reproduce:

import modin.pandas as pd
print(pd.read_json("""[{"name": "hamx0r"}]"""))

Related to #554
Describe the problem
Even though #715 adds read_json(), it is limited to:

Reading JSON files, and not strings (ie fetched from a web source)
Each row of the JSON file has to be a complete DataFrame row's worth of data (and all columns must be present in every row).

I would like to see the ability to read JSON strings too, or at least allow some kind or workaround using BytesIO or similar. Currently, modin fails even a simple BytesIO hack:
import modin.pandas as pd
from io import BytesIO
j = b"""[
{"name": "hamx0r"}
]"""
bio = BytesIO(j)
df = pd.read_json(bio, lines=True)
print(df.head())

...results in this error:
...

File "...modin/engines/base/io/file_reader.py", line 15, in get_path
if S3_ADDRESS_REGEX.search(file_path):
TypeError: expected string or bytes-like object

The only workaround I've found is to load with regular pandas, then convert the dataframe to Modin:
import pandas
import modin.pandas as pd
j = """[{"name": "hamx0r"}]"""
df = pandas.read_json(j)
df = pd.DataFrame(df)
print(df.head())

Source code / logs
This traceback comes from running the "Code we can use to reproduce" above:
Traceback (most recent call last):
  File "code.py", line 90, in runcode
    exec(code, self.locals)
  File "<input>", line 2, in <module>
  File "/modin/pandas/io.py", line 143, in read_json
    return DataFrame(query_compiler=BaseFactory.read_json(**kwargs))
  File "/modin/data_management/factories.py", line 60, in read_json
    return cls._determine_engine()._read_json(**kwargs)
  File "/modin/data_management/factories.py", line 64, in _read_json
    return cls.io_cls.read_json(**kwargs)
  File "/modin/engines/base/io/text/json_reader.py", line 13, in read
    return cls.single_worker_read(path_or_buf, **kwargs)
  File "/modin/backends/pandas/parsers.py", line 57, in single_worker_read
    pandas_frame = cls.parse(fname, **kwargs)
  File "/modin/backends/pandas/parsers.py", line 117, in parse
    return pandas.read_json(fname, **kwargs)
  File "/pandas/util/_decorators.py", line 186, in wrapper
    return func(*args, **kwargs)
  File "/pandas/io/json/_json.py", line 608, in read_json
    result = json_reader.read()
  File "/pandas/io/json/_json.py", line 731, in read
    obj = self._get_object_parser(self.data)
  File "/pandas/io/json/_json.py", line 753, in _get_object_parser
    obj = FrameParser(json, **kwargs).parse()
  File "/pandas/io/json/_json.py", line 857, in parse
    self._parse_no_numpy()
  File "/pandas/io/json/_json.py", line 1089, in _parse_no_numpy
    loads(json, precise_float=self.precise_float), dtype=None
ValueError: Expected object or value

Thanks @hamx0r for creating the issue! This is failing when trying to default to the pandas implementation, and the error earlier in your comment happens when we try to open the file.
We will do our best to get this out in the next release, which is planned for next week.


Equal Does Not Work With Column Names

sb.Equal doesn't work with column names because it tries to set the column as a string. Needs a new equal function for column names that doesn't get embedded as an arg
example
sb.Equal(tableB.id=tableA.question_id) would fail silently

The second arg value interface{} is designed for argument which should be escaped.
You can either do this
sb.Equal("tableB.id", sqlbuilder.Raw("tableA.question_id"))

or that
sb.Where("tableB.id=tableA.question_id") // Yes. I recommend you to use plain text in this case.

to solve your problem.

Feel free to reopen this issue if you still have any question.


Buffered value of Current Item to UIProgressView! (Like Youtube)

Hi!! Is there a way to get the buffered value of current JukeboxItem to put in UIProgressView! ??? Thanks!!

Not at the moment. Marked this as a feature request, you're welcome to open a pull request.

Yeah this one would come in handy :)


when renderItem return a line item and set stroke, the stroke color will cover line series lineStyle.color setting

Version
4.1.0-release
Reproduction link
https://gallery.echartsjs.com/editor.html?c=xxSlx3B-Op&v=1
Steps to reproduce
please see reproduct link。

when not add custom series, the line series lineStyle.color is as mine setting.
add custom series and return a line item, and set stroke color, the line series use the stroke color

What is expected?
the line series lineStyle.color not effect by the stroke color
What is actually happening?
the line series lineStyle.color use the custom series stroke color

Sorry, there is a typo in you first series (not rbg but should be rgb) and that's why you have got an unexpected result.

@plainheart sorry!, I really careless!


Add Visual Studio Dark theme

The visual studio themes I would say are pretty great, and having the same theme on both emacs and visual studio would be sweet.
https://docs.microsoft.com/en-us/visualstudio/extensibility/ux-guidelines/color-value-reference-for-visual-studio?view=vs-2017

This package now has new collaborators so we'll be able to be more active and implement more themes. This suggestion surely will be taken into consideration.

It's duplicated with #279 .

@seagle0128 kinda! He was asking for all of them jaja

Oh, share all themes? Damn, maybe need a translator 😢

Jajajaja yes. (I wont implement any light themes though 😂)


AdagioRtdProvider: remove custom auction uid

Type of change

[ ] Bugfix

[ ] Feature

[ ] New bidder adapter

[ ] Updated bidder adapter

[ ] Code style update (formatting, local variables)

[ ] Refactoring (no functional changes, no api changes)

[ ] Build related changes

[ ] CI related changes

[ ] Does this change affect user-facing APIs or examples documented on http://prebid.org?

[ ] Other

Description of change

Other information

Merged in https://github.com/onfocusio/Prebid.js/pull/49


seems that package-lock and package is out of sync? Maybe remove package-lock?

https://travis-ci.org/Apollon77/ioBroker.keyble/jobs/459645614

Hmmm, I already assumed that package-log.json might be causing some problems, because I don't know how to properly deal with that file.
I just did what you recommended and simply removed package-json.log.

maybe you also weant to enable adapter testing using travis-ci.org in your repo? :-)

That will probably take a few days. So far I've never used this travis-ci, so I guess I first need to spend some time on getting to know this travis-ci.
But since I just returned from abroad, I first need to take care of a few other things that piled up when I was away.

Sure, in fact very easy because everything is already there.
Go to https://travis-co.org, signup with your Github account, click settings and turn on testing for this repo (listed automatically). Then do a commit or select "Trigger build" in Travis and build the master ...
Then you see this: https://travis-ci.org/Apollon77/ioBroker.keyble
From the results:

remove node 4 and 10 from .travis.yml because not supported (also maybe note this on README)
you need to add special stuff for macos to travis.yml ... best go to g++ 4.9 at all ... and add the "before_install" ... sync with https://travis-ci.org/Apollon77/ioBroker.meross/builds/460425127/config where relevant


[Event Request] Table 5718 Nonstock Item "OnNonStockItemVendorItemNo"

Can we please get the following event?
 field(4; "Vendor Item No."; Code[50])
        {
            Caption = 'Vendor Item No.';

            trigger OnValidate()
            Var
                IsHandled: Boolean;
            begin
                if ("Vendor Item No." <> xRec."Vendor Item No.") and
                   ("Item No." <> '')
                then begin
                   //Event Request begin
                    IsHandled := false;
                    OnNonStockItemVendorItemNo(NonStockItem, IsHandled);
                    if not IsHandled then
                    //Event Request End
                        Error(Text001);
                end;

                if "Vendor Item No." <> xRec."Vendor Item No." then
                    if CheckVendorItemNo("Vendor No.", "Vendor Item No.") then
                        Error(Text002, "Vendor No.", "Vendor Item No.");
            end;
        }

[IntegrationEvent(false, false)]
    local procedure OnNonStockItemVendorItemNo(var NonstockItem: Record "Nonstock Item"; var IsHandled: Boolean)
    begin

    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Xcode seems fine, but flutter reports that it requires additional components

$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v0.2.3-pre.46, on Mac OS X 10.13.3 17D102, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK 26.0.3)
[!] iOS toolchain - develop for iOS devices (Xcode 9.2)
    ✗ Xcode requires additional components to be installed in order to run.
      Launch Xcode and install additional required components when prompted.
[✓] Android Studio (version 2.3)
[✓] IntelliJ IDEA Community Edition (version 2017.3.4)
[!] Connected devices
    ! No devices available

! Doctor found issues in 2 categories.

However, when I launch Xcode, it doesn't show anything out of the ordinary.  It lets me create new projects without complaint.

might have been broken by https://github.com/flutter/flutter/pull/15628, I will roll it back for now

Yep, confirmed  #15628 is the culprit.  This goes away if I reverse that commit.

having the same issue now! latest flutter

Having this issues now.
[✓] Flutter (Channel stable, v1.9.1+hotfix.2, on Mac OS X 10.14.6 18G95, locale en-MY)
• Flutter version 1.9.1+hotfix.2 at /Users/jackson.foo/Downloads/flutter
• Framework revision 2d2a1ffec9 (3 weeks ago), 2019-09-06 18:39:49 -0700
• Engine revision b863200c37
• Dart version 2.5.0
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/jackson.foo/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[!] Xcode - develop for iOS and macOS (Xcode 11.0)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.0, Build version 11A420a
✗ Xcode requires additional components to be installed in order to run.
Launch Xcode and install additional required components when prompted.
• CocoaPods version 1.8.0
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 39.0.3
• Dart plugin version 191.8423
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] Connected device (1 available)
• iPhone 8 Plus • D10A35F7-2746-448D-AF92-0D36F7522256 • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-0 (simulator)


Add some tests around completionStatus.ts

Description
This is mostly additional unit tests, but there is also some dead code removal.
MCPAR in MCR has a FormField property called repeat. This is distinct, and behaves differently from the MFP FormField property called repeatable. The repeat validation code only existed in MFP because it was copied from MCR, so I have removed it rather than adding tests for it.
Related ticket(s)
n/a

How to test

Run the unit tests
Verify that the only instances of /\brepeat\b/ in the entire app are inside comments (or yarn.lock files), so there is no way the repeat validation code could have been doing anything.

Important updates
n/a

Author checklist

[x] I have performed a self-review of my code
[x] I have added thorough tests, if necessary
~[ ] I have updated relevant documentation, if necessary~

Retroactively associating with ticket CMDCT-3121


Exporting exe doesnt work

v3.2.stable
windows 10
when I export game and start it on other pcs it says something like
Can't load dependency: C:/Users/yiffstorage/Documents/Dark Field/materials/map/env/metal.png
EVEN THOUGH THAT IS F*CKING name of MY PC, not PCs I try to run game on. And on MY PC game runs fine when exported.
Make big project that is not a tech demo made in 10 hours, export it and run on other pc.

Please upload a minimal reproduction project and follow the issue template. At this point, I think you're better off asking on one of the community channels.


CC2530(+CC2591) max_devices version of FW

There  is no max_devices version of firmware for cc2530 and for cc2530+cc2591.
Is it possible to add those?

I prefer not to:

The max devices firmware is a workaround, it will perform much less with bigger networks. Instead you should add more routers to your network.
Maintaining/generating all these firmware's each time on an update is very time consuming for me


AIR: notifications after transaction is initiated by the user

Review and complete the (partially existing) implementation for:
Toaster notifications:

A collectibles icon with a progress bar appears on the top near the avatar hud. When mouse hover it, I can see feedback messages. When I have accepted collect items transaction, I am notified that the collectible(s) are on the way to my Inventory.

After some time, a second toaster notification confirms I’ve just received the collectible(s).

New items notification:
3. The collectibles icon disappears, and after that a notification (new item counter) appears on the Avatar HUD, telling the number of collectibles I have just received. I click on the profile picture and see the same number on the Avatar option. Entering the menu, I find a “NEW” tag on each of the collectibles received.

Note: 1 and 2 are not yet implemented but it was not launch MVP and now part of a separate Epic. Closing this issue "as is".


Website shown loading in background with loading bar

Hi, just integrated pace.js in http://perkypixels.in and its working fine but when integrated to http://test.prafuldeshmukh.co it shows the webpage loading in the background. How can  I hide the web page while its loading and only show the progress bar?

thanks for the tip

Thanks a lot Shaz3e! It works wonderfully well for me.


fixing jshint score and deleted globalstrict in .jshint as it is depr…

…ecated

@rolandpoulter @DavidjohnBlodgett @RackHD/corecommitters

+1

-1 because of the constructor move.

jshint yelled cause we are using functions that arent defined yet. So I moved the function before we use them.

@benbp sounds like we can't get around it to me.

:+1:

@benbp fixed :-)

:+1:


External Graph Memory

Hey, great work.
I have a couple of questions, currently I am trying to compare different architectures by changing the original STAR architecture (for example deleting the 2nd encoder, changing the number of heads/layers..) and now I want to get rid of the graph memory and see how it works, I want to know if GM is essential for the temporal aspect of the transformer? and is it even possible to talk about getting rid of the GM.
Thanks in advance

Hi, thanks for your interest in our work.
GM serves to retain the effect imposed by those pedestrians who have left the scene but used to be present. Some workarounds may do the same thing. For example, regarding the pedestrian as a static point the moment when they disappear from the scene.
Thank you.

Oh I see, thanks a lot,
so I tried to compare the model with and without a GM, here are the results:
with GM: ADE/FDE: 0.160/0.312
without GM: ADE/FDE: 0.129/0.231
does it make sense that the results without the GM are better ? or maybe because I didn't run enough training samples (because the models are stochastic)

does it make sense that the results without the GM are better? or maybe because I didn't run enough training samples (because the models are stochastic)

GM does not provide a very significant improvement. Because the model is stochastic, you may get a different result in each run. The reason why we use GM is that GM brings a slight improvement in the deterministic version.
Thanks.

does it make sense that the results without the GM are better? or maybe because I didn't run enough training samples (because the models are stochastic)

GM does not provide a very significant improvement. Because the model is stochastic, you may get a different result in each run. The reason why we use GM is that GM brings a slight improvement in the deterministic version.
Thanks.


Optional ontology parameter for MetadataWidget

To query metadata via the MetadataWidget, the ontology parameter should be optional for use-cases where only the IRI is known but not a specific ontology

Is implemented by now, closing...