[proposal] More information on workflow lists

We're starting to use digdag and enjoying the experience so far. The developer tools, automation are amazing. There is one small caveat - UI could use some love.
For example - I'd like to see more information in the workflow list: last session attempt timestamp and status, maybe the next run time. Essentially the same information from other pages of the console UI, but only in more condensed way.
I started walking a bit in the code base and wandered whether the lack of workflow overview status was intentional? Maybe there could be multiple active sessions for the same workflow, thus the suggested overview is invalid by design?
If implementing such functionality..

does one would change the UI only with extra async queries from the workflow list to collect the required info and making frontend a bit heavier?
or the proper implementation would go deep to the server - starting with rest model, store, manager and finishing in dao?

I think changing only console UI would impact a lot less of components (the shell tools for example), but would it be consistent with the vision and architecture of digdag?

Hello, @ramasLTU
Thank you for your comment.
Digdag UI still developing. IIUC, your issues don't intentional.
It's just priority and resource problem.
Please wait for a comment by the architect/developer.

Close because no activity.


Ability to see the list of people who resteemed my posts

I am not a famous person on steemit, so it took me so long to come up with this suggestion. If we open a post, we see votes and comments but there are a few people who resteem our posts and it is really difficult to tell who resteemed your post if we don't have notifications enabled or visit the profile of that person.
Clearly, a famous person cannot check who resteemed his posts because sometimes there are too many. We do have an option on partiko to see how many people resteemed our posts but they are not clickable.
I want to suggest that esteem should take the lead and implement this feature where users will be able to see how many people resteemed their posts and clicking on that should show the list of those people. It will be an interesting feature to have on esteem.

Thanks @shadutopian, we will consider this feature 👍

Thanx for the feedback.
implemented @shadutopian


CreateText does not align text on z

Follow up on https://github.com/BabylonJS/Babylon.js/pull/14493

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14509/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14509/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14509/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14509/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14509/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14509/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14509/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14509/merge#BCU1XR#0


Problem in my-site i.e.status page not showing option to choose status when user state: ONBOARDING after signup

https://user-images.githubusercontent.com/107163260/234006823-eedbc5a4-e603-48f7-aee3-341c54d4f563.mp4
If you see video above i.e. https://my.realdevsquad.com/ (my-site)  (localhost:3443)  when new user signup and
state: ONBOARDING added in userStatus Collection in database bydefault.
Problem
when new user go to https://my.realdevsquad.com/ (i.e. localhost:3443)  then new user not able to update new state manually because screen is blank (i.e. refer above video)
Solution
do some changes in website-my repo i.e. userStatus related file to pass the condition and see the UI i.e. ACTIVE, OOO, IDLE like before in my-site  https://my.realdevsquad.com/  so that new user can change there state: ONBORDING to any other state.

How to resolve this problem:
When state: ONBOARDING  is added in database after signup
Then In frontend please check this link:- https://github.com/Real-Dev-Squad/website-my/blob/develop/app/routes/index.js#L12
If you see code in above link it fetch the currentStatus from backend
i.e.
 if (response.status === 200) {
        return userData?.data?.currentStatus?.state ?? USER_STATES.DNE;  //"ONBORDING"
 }

If state found in backend then it not able to find USER_STATE.ONBOARDIN: "ONBOARDING" in frontend to pass condition and render the UI
Solution:
I added a constant in
 export const USER_STATES = {
  IDLE: 'IDLE',
  ACTIVE: 'ACTIVE',
  OOO: 'OOO',
  ONBOARDING: 'ONBOARDING'
  DNE: 'DNE',
};


Unintuitive behavior for isIdentifier

TypeScript Version:  nightly (2.3.0-dev.20170404)
Code
function f() {
    interface I {
        [yield: string]: boolean;
    }
}

function* g() {
    interface I {
        [yield: string]: boolean;
    }
}

Expected behavior:
No errors.
Actual behavior:
src/a.ts(9,15): error TS1005: ']' expected.
src/a.ts(9,23): error TS1005: ';' expected.
src/a.ts(9,24): error TS1131: Property or signature expected.

We use isIdentifier in a few places where it doesn't really make sense to care whether we're in a yield context or not.

Turns out we do allow yield in all these other cases:
function* f() {
    interface I {
        (yield: number): void;
        new (yield: number): void;
        f(yield: number): void;
    }
}

The reason is that those use fillSignature, which sets yield/await context.
parseIndexSignatureDeclaration doesn't, presumably because the parameters are delimited by [] instead of ().
So we could simply modify the parseIndexSignatureDeclaration code to set yield/await context too.
Or, pass the open/close token as parameters to parseParameterList instead of hardcoding parens there, then call that instead of parseBracketedList.

Doesn't seem like anyone else has noticed


X-Forwarded-Host, X-Forwarded-Port, X-Forwarded-Proto, X-Forwarded-Prefix

Zuul 1.x GW adds these headers by default (can be disabled via configuration).  Consider a PR that would add the same functionality in spring cloud gateway? Maybe it would be a default filter that can be disabled via configuration.

Duplicates #125. PRs always welcome. I'm working on the Forwarded header already, there may be some overlap.

See https://github.com/spring-cloud/spring-cloud-gateway/blob/forwarded-header/spring-cloud-gateway-core/src/main/java/org/springframework/cloud/gateway/filter/headers/XForwardedHeadersFilter.java


fix css props when using babel macro with babel-plugin-styled-components 1.10.1

Currently, if you follow the guide to using styled-components with Create React App, css props will not work. This is due to a change introduced in babel-plugin-styled-components 1.10.1.
This fix resolves the issue by switching the macro to use @babel/traverse(path) instead of path.traverse(). For some reason, this makes the Program visitor work, whereas it doesn't with path.traverse().
See https://github.com/styled-components/babel-plugin-styled-components/issues/226 for details

@jamesknelson can you add a test please?

I can't get the tests running on my machine, so can't do so at the moment. I get this when trying to run yarn test:web or jest
 ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import styled from '../styled';
SyntaxError: Unexpected identifier "import"

Looks like the tests are not compiling modules to commonjs for some reason. Any ideas?

@jamesknelson hmm weird, a yarn from the root always works for me

I'm not sure what's going on - I've run yarn in the root, tried a bunch of things with a fresh clone, and can't get tests to work locally no matter what I try.
On the other hand, there is a macro test already, and it passes on CI.

I’ll add one to your branch
On Wed, Jun 19, 2019 at 11:00 PM James K Nelson<EMAIL_ADDRESS>wrote:

I'm not sure what's going on - I've run yarn in the root, tried a bunch
of things with a fresh clone, and can't get tests to work locally no matter
what I try.
On the other hand, there is a macro test
https://github.com/styled-components/styled-components/blob/master/packages/styled-components/src/macro/test/macro.test.js
already, and it passes on CI.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/pull/2633?email_source=notifications&email_token=AAELFVQB2LLSQNXLXXR4L5LP3L6FRA5CNFSM4HZOX5K2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYD55WQ#issuecomment-503832282,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAELFVQZWWBP6VQRFLVHTW3P3L6FRANCNFSM4HZOX5KQ
.

Released as 4.3.2, thanks so much for tackling this!


refactor(firefox): switch to schizofox

I think this is feasible to use at this point. The only thing I'd like to see is a more up-to-date version of firefox used by schizofox.


Add more HTTP/1 parser tests for header value containing null character.

Balsa in QUICHE behaves very differently depending on where a null character is located within a header value, see
https://github.com/google/quiche/blob/5f41064f20a12fe4ecc50c076bf6743da15739f9/quiche/balsa/balsa_frame_test.cc#L4248-L4272
This PR adds tests demonstrating that BalsaParser in Envoy correctly rejects the headers in all of those cases (and incidentally uncovers that while http-parser also does, it is not consistent with its error messages).
Commit Message: Add more HTTP/1 parser tests for header value containing null character.
Additional Description:
Risk Level: low, test-only change
Testing: test/common/http/http1:codec_impl_test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

/assign @yanavlasov


Long repeated capture hangs eventually at app.Wait()

This could definitely be more of a libcamera issue, so please let me know if I should instead post over there.
I noticed that some of my captures when using my custom libcamera-app (combined still and video capture with a in-memory circular buffer that isn't deallocated/re-allocatd on each capture) sometimes just stops capturing. So I modified libcamera-vid with a simple while loop test (though I recognize this isn't exactly a supported / useful design):
int main(int argc, char *argv[])
{
	try
	{
		unsigned int counter = 0;
		while (true) {
			LibcameraEncoder app;
			VideoOptions *options = app.GetOptions();
			if (options->Parse(argc, argv))
			{
				if (options->verbose)
					options->Print();

				event_loop(app);
			}
			counter++;
			std::cerr << "COUNTER: " << counter << std::endl;
		}
	}
	catch (std::exception const &e)
	{
		std::cerr << "ERROR: *** " << e.what() << " ***" << std::endl;
		return -1;
	}
	return 0;
}

And around the 1582nd loop when running the following command: LIBCAMERA_LOG_LEVELS=0 ./libcamera-vid --frames 1 --framerate 10 --width 4056 --height 3040 --shutter 100000 --awbgains 1,1 --gain 1 --codec yuv420 -o /dev/null it just stops. The line where it seems to hang is: LibcameraEncoder::Msg msg = app.Wait()
Here are logs during the capture: Logs.zip
I am currently on an libcamera commit 8ff5a8d548eee7c2cb14b355867debdb29e75419 plus a patch from here - https://github.com/raspberrypi/libcamera-apps/issues/217#issuecomment-1007605812 - I will give the above test another try with the latest libcamera code and report back.
$ uname -a
Linux raspberrypi 5.10.87-v8+ #1 SMP PREEMPT Sat Dec 18 19:47:37 GMT 2021 aarch64 GNU/Linux
./libcamera-hello --version
libcamera-apps build: fe1f849bfb49-intree-dirty 14-01-2022 (15:56:40)
libcamera build: v0.0.0+3369-8ff5a8d5-dirty (2022-01-07T17:53:56+00:00)
$ vcgencmd version
Nov 18 2021 16:16:49
Copyright (c) 2012 Broadcom
version d9b293558b4cef6aabedcc53c178e7604de90788 (clean) (release) (start)

PS - Here's the full libcamera-vid.cpp that I was testing with -
libcamera_vid.cpp.txt - Note that I also did move up the frameout code to that it would exit the loop after capturing 1 frame.

Quick update with latest libcamera code (with no patches) - Test is still running through 2379 loops. If I can't replicate on the latest libcamera code I will go ahead and close this issue.

Good through 3672 loops. Closing this issue for now. I'll reopen if I run across this issue again.

Thanks. One thing I;m curious about is whether it keeps making new preview windows (or were you using -n)? I don't think I ever put any code in to kill the previews, not really thinking that anyone would ever run it like that. Strictly speaking I suppose that wants sorting out, though it doesn't seem top priority...!

Hey David, sorry for the long delay - I've been traveling a bit.
In the test above, I was not using -n, but I have since repeated the test on the latest libcamera source (with and without -n) and I haven't been able to get it to hang. However, I have still seen an occasional hang in my actual app... So I will keep trying to isolate it and will post back here if I do.


Issue 66

Changelog:
Implemented rough version of PR template.

+1, looks good

👍

@R-Wang97, for the record, if you put "Fix #66" somewhere in your PR comment, it'll close the issue automatically when the PR merges.


Make OpenAiClient usable without OkHttp and Gson

Purpose
This purpose of this pull request is to make it possible for advanced integrators to swap out OkHttp and Gson for other alternatives.
For a first iteration, I did not want to require current consumers of this library to have to make any changes - for them this pull requests changes nothing whatsoever.
This means that I did not do any sort of split of modules into core and okhttp for example. I believe that if we want to do that, if can be done at a latter point.
Changes
Gson
All this change does is move Gson out of the model classes. This is needed by integrations that plan to exclude Gson from the classpath, so that the models can continue to be loaded without incurring ClassLoading issues.
Client SPI
OpenAiClient and its Builder are now an interfaces.
Furthermore, a OpenAiClientBuilderFactory SPI is introduced which is used to load the an implementation of the interface from the classpath using Java's ServiceLoader mechanism.
If no such implementations are found, then the default implementation provided by the library (and backed by OkHttp) is used
I have leveraged this SPI my Quarkus integration here.

Thanks for the review!


Rebuild when matching ABI

Hi,
I ship prebuilt binaries for nodejs native module and I wonder if electron-rebuild will attempt to simply copy/reuse existing binary for nodejs given that ABI versions match with electron?
I ask because I either need to compile a module for node only or for electron too.
But I cannot ship binaries for electron only even if I expect the module to be used with electron only because I think node-pre-gyp will always look for node binaries and not electron ones when installing deps from terminal.

Alright so here is what I did in my package.json, I've added two scripts:
    "install": "node-pre-gyp install --fallback-to-build",
    "build": "node-pre-gyp build",

However electron-rebuild ignores them and instead runs node-gyp on its own which results in the wrong build output:
node_modules/nseventmonitor/build/Release

Since I use node-pre-gyp the builds are supposed to be stored at:
node_modules/nseventmonitor/lib/binding/Release


Dreamview 能否像 Dreamland一样，离线状态下做仿真练习。

我目前了解应用Dreamview的功能，只能播放rosbag 数据 ，除播放数据外Dreamview能否像Dreamland一样编辑场景，做仿真练习，请问如何实现。
System information

OS Platform and Distribution (e.g., Linux Ubuntu 18.04):18.04
Apollo installed from (source or binary): source
Apollo version (3.5, 5.0, 5.5, 6.0): 5.5
Output of apollo.sh config if on master branch: master

Steps to reproduce the issue:

Please use bullet points and include as much details as possible:

Supporting materials (screenshots, command lines, code/script snippets):

可以试一下 LGSVL simulator

好的，谢谢。


Python Intellisense autocomplete extremely slow

OS: MacOS
OS Version: 10.15.2
VSCode Version: 1.41.1
Extension Version: 2019.11.50794
Python Version: Python 3.7.5
Using jedi : Yes
Conda environment: No
Problem:
Intelisense autocomplete takes forever to complete downloaded Python modules such as pandas (but other as well, numpy, scikit-learn...) under MacOS.
Steps to Reproduce:

Install python3 via Brew (brew install python3)
Install VSCode (either via Download from Official site or via Brew Cask)
Install pandas with pip3 (pip3 install pandas)
Create a new .py file and observe the behaviour attached below:

Does this issue occur when all other extensions are disabled?: Yes
Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer

Is the about no completions on data which is a dynamically created object based on the CSV file contents and since LS is not running any code or read user data files, there are no completions. See #981.
Or is it about specific performance issues?


I'm trying to setup the table of contents to just show the thesis level, but nothing lower

I'm trying to setup the table of contents to just show the thesis level, but nothing lower and I'm failing. if I read the docs right, maxdepth should do the trick, but I must be doing it wrong.

The ToC on the left is not the same as the toc you add to the index page, confusingly. The readthedocs theme does pull from that (e.g. in the eWaterCycle docs).
After a quick search I found this: https://sphinx-book-theme.readthedocs.io/en/stable/sections/sidebar-primary.html#control-the-depth-of-the-left-sidebar-lists-to-expand on the docs of the sphinx book theme.
The sphinx ecosystem is very messy.

Hmm, it says as a solution to edit conf.py but I guess that lives deep in a dependency and not in your own repo?

Oh yeah I guess that's created during the build...
The jupyter book config does indeed say to use maxdepth https://jupyterbook.org/en/stable/structure/configure.html#control-the-depth-of-the-displayed-table-of-contents
Maybe try
format: jb-book
root: intro.md
options:
  maxdepth: 1

parts:
  - caption: Thesis Projects
...

maxdepth is only for a 'within-page Table of Contents', I think what you want is to have the TOC only contain the files that you want to be there and link to other files which are not included there. Make sure you have the following options disabled:
only_build_toc_files: false

I think what you want is to have the TOC only contain the files that you want to be there

The problem is that other headers from inside the notebooks are being displayed in the ToC. Rolf wants those to not show up.

The problem is that other headers from inside the notebooks are being displayed in the ToC. Rolf wants those to not show up.

In the table of contents on the left or on the 'within-page Table of contents'?

the table of contents on the left

the one on the left sidebar

the one on the left sidebar

Hmm, I don't see why/how/where headers from inside the notebook which are on the level of ## or lower are displayed there. Headers with # are displayed there for sure, but you can prevent that from happening by not having those files in the TOC as mentioned here: https://github.com/eWaterCycle/projects/issues/3#issuecomment-2485139562


Add my first file

I have created a new branch, created a file, and made a commit!

Finished Github-Flow


Add HTTPXMock testing and drop Python 3.8 support

This adds a series of tests using httpx_mock and static data files. The work to add the tests has identified two issues:

During authentication the response from sending the username was not checked correctly. It will actually tell you if the username is invalid.
For some reason we were always requested the trips for the current day when requesting the static data. I'm not sure why.

I could break these two issues out into multiple pull requests but for the minute they are contained in this pull request.
The merge looks large but this is to do with all the new static JSON files.

@CM000n I cant add the required package(pytest-httpx) to poetry as it requires python >=3.9 according to poetry. I know it works fine on Python 3.8.18 (default, Aug 25 2023, 13:20:30) as that is my development environment. Is there a way around this?

@CM000n I cant add the required package(pytest-httpx) to poetry as it requires python >=3.9 according to poetry. I know it works fine on Python 3.8.18 (default, Aug 25 2023, 13:20:30) as that is my development environment. Is there a way around this?

Unfortunately not. If these are the minimum requirements specified for pytest-httpx, there is no sensible way around this.
Of course, we could also drop support for Python 3.8. But this is a fundamental decision that should also be approved by @DurgNomis-drol.

Please divide you PR into smaller ones, it makes it a lot easier, and faster to approve them ❤

@CM000n I believe @joro75 is depended on 3.8

If you look at the code changes they are fairly small, the reason that the pull request is so large is because of the JSON files that provide the data for the tests.

@GitOldGrumpy  Personally I would prefer if we could remove support for .8 and .9, but @joro75 is supporting it. So I think to be fair, he should be involved in the decision

So let's hope for a prompt response from @joro75. But I would also prefer to completely discontinue support for 3.8 rather than simply disconnect the tests for it.

Oh dear, it looks like Domoticz, for which @joro75 maintains the Toyota plugin, is not exactly up to date as far as the python versions are concerned: https://www.domoticz.com/wiki/Using_Python_plugins#Required:_install_Python 🙄
So we will probably have to maintain support for python 3.9 for the time being @DurgNomis-drol.

@CM000n you might want to double check my attempts to eradicate 3.8 from building. I was also not sure if we need to update the poetry file so that python-versions  on the [[package]] are now also 3.9?

@CM000n you might want to double check my attempts to eradicate 3.8 from building. I was also not sure if we need to update the poetry file so that python-versions  on the [[package]] are now also 3.9?

Looks good to me so far 😊  You should only also remove the entry for Python 3.8 in the classifiers in the pyproject.toml file

Mhmm, doesn't look like @joro75 is particularly active. I actually don't want to wait too long as these changes are very beneficial in terms of test coverage.
What do you think @DurgNomis-drol? Should we give ourselves a specific timeframe here for feedback from @joro75 and merge the changes otherwise?

Hi all,
Sorry for the delay. I have been busy, and have not been able to follow all the recent changes.
Dropping Python 3.8 is OK for me. I also plan to update Domoticz-Toyota-Plugin to Python 3.9 soon, also updating it to the latest mytoyota.
It is correct that the original Domoticz documentation regarding python is old. Using Python >= 3.9 in combination with Python is possible, as I recently updated my own installation to Python 3.9.
Just drop Python 3.8, and continue with the merge!

Thanks for you response @joro75 😊


Fixed !is_inside_tree() errors in file dialog

Fixed !is_inside_tree() errors appearing when current_file has a . in it.
This fixes #18631

Thanks!

Cherry-picked for 3.0.7.


Kafka to ElasticSearch consumer

To get the logs out of Kafka and in the ElasticSearch

We now have support for both ElasticSearch and Kafka via mantl-api. Is this issue still relevant?

Yes, we should have all the pieces in place for this. It should be possible to launch ElasticSearch with a Kafka input plugin configured to read from a topic.
Please re-open if there is a specific use case we are missing


NFT (Natural Feature Tracking) on AR.js

AR.js is currently able to recognize markers based on artoolkit marker, so the ones with the dark (black) border around shapes.
NFT (Natural Feature Tracking) can bring new life to AR.js, we eventually will be able to scan and recognize also 2D images, for example.
There is a branch for NFT on artoolkit, the library that AR.js is using for recognization.
@kalwalt is working on his fork of jsartoolkit (https://github.com/kalwalt/jsartoolkit5/pull/1) in order to bring the NFT branch alive again, including examples. They are outdated, but some times ago they where working.
So: if we can help him/support him bringing the NFT branch alive and working again, we can then think of use that jsartoolkit version in order to bring NFT feature to AR.js.
Just wanted to make this more visible.
If someone is willing to help and has experience about that, please let us know :)

Thank you @nicolocarpignoli we need to take this beast by the horns!

Update: @kalwalt has been able to make NFT branch working again on jsartoolkit!
Now we need to find a way to:

create NFT markers starting from a 2D image
possibly load such markers dynamically on jsartoolkit example
replace/port the NFT jsartoolkit version into AR.js

Thanks for the enthusiasm @nicolocarpignoli  !! :1st_place_medal:

create NFT markers starting from a 2D image
i want to look to this! i want to try with my own image....

@nicolocarpignoli Idea: i am working on adding NFT to jsartoolkit5 https://github.com/kalwalt/jsartoolkit5/pull/1 , that is all is together (marker, multimarker, barcode, and NFT) but maybe one person could be interested to only the markerless NFT tech, so i was wondering that it will be cool to develop a lighter version of jsartoolkit with only NFT, what do you think?

In my opinion it could be interesting, but I will see that as a 'nice-to-have'. Priority should to simply  (lol) bring NFT to AR.js.

Yes of course! 😀

Omg! How can I help?

Things are moving! @Carnaux has started a repo to bring to the web a tool to create NFT marker!
https://github.com/kalwalt/jsartoolkit5/pull/1#issuecomment-514449013

For anyone interested in this topic: i uploaded some examples in my github webpage kalwalt.github.io/kalwalt-interactivity-AR/ to help testing on mobile devices. For now i uploaded only the threaded version of jsartoolkit5 with NFT, before using it read carefully the infos especially the Spectre issue!! I will upload the other examples ( the non threaded version) when i will have a bit of time, sadly i have not so much in this last period...

Congratulations kalwalt, i successfully tested your NTF  examples kalwalt.github.io/kalwalt-interactivity-AR/  on both  Android and IOS devices !
A question,  how can we detect when the marker is visible and when it is hidden, so we tell to start or to stop other actions like animation and sound?

Congratulations kalwalt, i successfully tested your NTF examples kalwalt.github.io/kalwalt-interactivity-AR/ on both Android and IOS devices !
A question, how can we detect when the marker is visible and when it is hidden, so we tell to start or to stop other actions like animation and sound?

You should look in the console you should receive some notifications. Not sure if at the moment it is implemented a event listeners for this, Sorry! but i will look into it... BTW could you be more specifc with performances and devices? Thank you! :smile:

We @kalwalt @nicolocarpignoli @ThorstenBux are on the road to merge the jsartoolkit5 NFT feature into the master branch of artoolkitx/jsartoolkit5 in this PR. :smile: :+1:
This means that in another step will be integrated into AR.js !! If you want to test the examples go to this page kalwalt.github.io/jsartoolkit5/examples/ and report your tests and issues in the
artoolkitx/jsartoolkit5 PR or in the PR where i started this hard/crazy work.
See you soon for nice updates !! :100: :bomb: :fire:

holy moses,
this is the most profound work on AR,js and AR in general ive seen in years,
if this would be implemented the pain of cross compiling android and ios apps would be gone forever

holy moses,
this is the most profound work on AR,js and AR in general ive seen in years,
if this would be implemented the pain of cross compiling android and ios apps would be gone forever

Yes @TheBricktop this is real! We hope to merge into the artoolkitx/jsartoolkit5 master branch in january and after include it in AR.js If you find some issues please open it at https://github.com/kalwalt/jsartoolkit5/issues or leave a comment in the PR

Will definitely try it out

That’s perfect guys, thanks a million!

closed, see related PRs.

can we play an mp3 file with nft marker

@abhishekQ : the markers are only used for AR features, audio is done at the "3d-engine" level (three-js), so it should work. i did this successfully using arNFT (what ar.js is based on afaik) and three-js

@abhishekQ : the markers are only used for AR features, audio is done at the "3d-engine" level (three-js), so it should work. i did this successfully using arNFT (what ar.js is based on afaik) and three-js

I want to play sound with 3d model when nft marker is detected. if you have code can you please share it with me

https://www.trickymind.at/ar
get the tracking-image by clicking the button on the bottom-right of the screen


cannot continue decompile type in decompiled code

I see that the omnisharp 1.26 version can do this, but this 2.x.x version cannot do it, which is annoying. For example, it will show green in PinnedScript and can continue decompile.
1.2.6

newest 2.x.x

Believe this should be a duplicate of https://github.com/dotnet/vscode-csharp/issues/5787


Merge Mainline changes into feature_assets_cli

What was the problem/requirement? (What/Why)
What was the solution? (How)
What is the impact of this change?
How was this change tested?
Was this change documented?
Is this a breaking change?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I don't think you need to make a PR For this?

PR not needed, closing.


Cmorizer for GHCN pr measurements

PR contains the cmorizer script for GHCN precipitation measurements.
The data could be downloaded from  this website. I chosed the file with monthly means (precip.mon.total.nc).

There were some changes in utilities.ncl due to #864. I have adapted your script accordingly.
The results look correct, but please have a look.

Looks correct for me, too.

Files are now in the DKRZ datapool and will be soon syncrhonized to Jasmin.


Intermittent autest failure on client_context_dump

Recently, I saw some intermittent failure like below on autest of GitHub Pull Request Builder.
Test: client_context_dump: Failed
    File: client_context_dump.test.py
    Directory: /var/jenkins/workspace/autest-github/src/tests/gold_tests/pluginTest/client_context_dump
   file /var/tmp/ausb-5670.10287/client_context_dump/ts/log/client_context_dump.log : Checking that file "/var/tmp/ausb-5670.10287/client_context_dump/ts/log/client_context_dump.log" exists - Passed
      Reason: File "/var/tmp/ausb-5670.10287/client_context_dump/ts/log/client_context_dump.log" exists
   file /var/tmp/ausb-5670.10287/client_context_dump/ts/log/client_context_dump.log : Checking that /var/tmp/ausb-5670.10287/client_context_dump/ts/log/client_context_dump.log matches gold/client_context_dump.gold - Failed
      Reason: File differences
       Gold File : /var/jenkins/workspace/autest-github/src/tests/gold_tests/pluginTest/client_context_dump/gold/client_context_dump.gold
       Data File : /var/tmp/ausb-5670.10287/client_context_dump/ts/log/client_context_dump.log
         20190624.20h01m51s LookupName: :/var/tmp/ausb-5670.10287/client_context_dump/ts/etc/trafficserver:/var/tmp/ausb-5670.10287/client_context_dump/ts/ssl/one.com.pem:, Subject: CN=one.com,O=Apache,L=Champaign,ST=Illinois,C=US. SAN: . Serial: . NotAfter: May 22 18:17:04 2020 GMT.
         20190624.20h01m51s LookupName: :/var/tmp/ausb-5670.10287/client_context_dump/ts/etc/trafficserver:/var/tmp/ausb-5670.10287/client_context_dump/ts/ssl/two.com.pem:, Subject: C=US,ST=Illinois,L=Champaign,OU=Two,O=Apache,emailAddress=ssl@two.com,CN=two.com. SAN: . Serial: . NotAfter: Jun 21 20:39:43 2019 GMT.
       - ``LookupName:``one.com.pem:, Subject: CN=one.com,O=Apache,L=Champaign,ST=Illinois,C=US. SAN: . Serial: . NotAfter: May 22 18:17:04 2020 GMT.

https://ci.trafficserver.apache.org/job/autest-github/10287/console

@macisasandwich added a patch to the test that should address some ssl issues that have caused random failures. I think this is fixed. If not make a new one issue

The test still fails intermittently.
Test: client_context_dump: Failed
    File: client_context_dump.test.py
    Directory: /var/jenkins/workspace/autest-github/src/tests/gold_tests/pluginTest/client_context_dump
   file /var/tmp/ausb-5745.10530/client_context_dump/ts/log/client_context_dump.log : Checking that file "/var/tmp/ausb-5745.10530/client_context_dump/ts/log/client_context_dump.log" exists - Passed
      Reason: File "/var/tmp/ausb-5745.10530/client_context_dump/ts/log/client_context_dump.log" exists
   file /var/tmp/ausb-5745.10530/client_context_dump/ts/log/client_context_dump.log : Checking that /var/tmp/ausb-5745.10530/client_context_dump/ts/log/client_context_dump.log matches gold/client_context_dump.gold - Failed
      Reason: File differences
       Gold File : /var/jenkins/workspace/autest-github/src/tests/gold_tests/pluginTest/client_context_dump/gold/client_context_dump.gold
       Data File : /var/tmp/ausb-5745.10530/client_context_dump/ts/log/client_context_dump.log
         20190725.17h27m00s LookupName: :/var/tmp/ausb-5745.10530/client_context_dump/ts/etc/trafficserver:/var/tmp/ausb-5745.10530/client_context_dump/ts/ssl/one.com.pem:, Subject: CN=one.com,O=Apache,L=Champaign,ST=Illinois,C=US. SAN: . Serial: . NotAfter: May 22 18:17:04 2020 GMT.
         20190725.17h27m00s LookupName: :/var/tmp/ausb-5745.10530/client_context_dump/ts/etc/trafficserver:/var/tmp/ausb-5745.10530/client_context_dump/ts/ssl/two.com.pem:, Subject: C=US,ST=Illinois,L=Champaign,OU=Two,O=Apache,emailAddress=ssl@two.com,CN=two.com. SAN: . Serial: . NotAfter: Jun 21 20:39:43 2019 GMT.
       - ``LookupName:``one.com.pem:, Subject: CN=one.com,O=Apache,L=Champaign,ST=Illinois,C=US. SAN: . Serial: . NotAfter: May 22 18:17:04 2020 GMT.

https://ci.trafficserver.apache.org/job/autest-github/10530/console

If it helps to have additional data points, I noticed this test fail a few times too and automatically succeed with a rerun.
For example,
https://ci.trafficserver.apache.org/job/autest-github/10570/

#5828 fixed this failure.


HealthConnectClient status: SDK_UNAVAILABLE_PROVIDER_UPDATE_REQUIRED

Hello! thank you very much for uploading the "capacitor-health-connect" in github
I want to ask if you have any ionic project that uses your plugin, since I have a problem asking for permissions:
"SDK_UNAVAILABLE_PROVIDER_UPDATE_REQUIRED = 2
The Health Connect SDK APIs are currently unavailable, the provider is either not installed or needs to be updated."
I have status 2 at the time of requesting permissions.
`    @PluginMethod
fun requestHealthPermissions(call: PluginCall) {
if (HealthConnectClient.getSdkStatus(this.context) == HealthConnectClient.SDK_UNAVAILABLE_PROVIDER_UPDATE_REQUIRED) {
`
already run "npx cap sync" and "npx cap update"

It was solved by writing the following in the AndroidManifest:
    <queries>         <package android:name="com.google.android.apps.healthdata" />     </queries>     <!-- TODO: declare Health Connect permissions -->     <uses-permission android:name="android.permission.health.READ_HEART_RATE"/>     <uses-permission android:name="android.permission.health.WRITE_HEART_RATE"/>     <uses-permission android:name="android.permission.health.READ_STEPS"/>     <uses-permission android:name="android.permission.health.WRITE_STEPS"/>     <uses-permission android:name="android.permission.health.READ_EXERCISE"/>     <uses-permission android:name="android.permission.health.WRITE_EXERCISE"/>     <uses-permission android:name="android.permission.health.READ_TOTAL_CALORIES_BURNED"/>     <uses-permission android:name="android.permission.health.WRITE_TOTAL_CALORIES_BURNED"/>     <uses-permission android:name="android.permission.health.READ_WEIGHT"/>     <uses-permission android:name="android.permission.health.WRITE_WEIGHT"/>


[BEAM-6257] PAssert.thatSingleton: use GBK instead of side inputs

Pretty straightforward change, but useful as my Spark prototype does not yet support side inputs. Accomplished by loosening the type restrictions on the existing but heretofore misleadingly-named GroupThenAssertForSingleton. I'll leave thatMap and thatMultimap for later.
R: @kennknowles
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Run Portable_Python PreCommit

Run Python PreCommit

Run Java Flink PortableValidatesRunner Streaming

Run Flink ValidatesRunner

I guess we have to manually re-run tests that were in progress when a change was made to the code? :thinking:

Run Python PreCommit

I guess we have to manually re-run tests that were in progress when a change was made to the code? :thinking:

Yes, it doesn't remember any "phrase" tests after the code has been updated. You can still find the old test runs on Jenkins though: https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming_PR/34/
Can't find "Run Flink ValidatesRunner", so I'm going to run that one again.

Run Flink ValidatesRunner


cli: Replace ctrlc crate with tokio/signal

The ctrlc latest version cannot be compiled in our minimum supported
Rust 1.66, hence replace it with tokio/signal.

By replacing ctrlc, the compiling time cargo build improved from 23 seconds to 19 seconds.

As this is breaking our Fedora release, I have to force merging it to prepare new release. Feel free to create PR if you found any improvements.


[SWIG] [ANSI C] Fatal error: utility: No such file or directory

Hi all,
I'm trying to create a javascript wrapper for an ANSI C file using SWIG and node-gyp.
I'm basically using this this doc as a starting point: http://www.swig.org/Doc3.0/Javascript.html#Javascript
I created the wrapper C file with SWIG which I'd like to build with node-gyp, however I does not seem to be finding some system headers:
$ node-gyp build
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| linux | x64
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
make: Entering directory `/home/atis/swig-test/src/build'
  CC(target) Release/obj.target/test2/test2_wrap.o
In file included from /home/atis/.node-gyp/6.10.1/include/node/node.h:42:0,
                 from ../test2_wrap.c:132:
/home/atis/.node-gyp/6.10.1/include/node/v8.h:21:19: fatal error: utility: No such file or directory
 #include <utility>
                   ^
compilation terminated.
make: *** [Release/obj.target/test2/test2_wrap.o] Error 1
make: Leaving directory `/home/atis/swig-test/src/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/node-gyp/lib/build.js:258:23)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
gyp ERR! System Linux 3.13.0-119-generic
gyp ERR! command "/usr/bin/nodejs" "/usr/bin/node-gyp" "build"
gyp ERR! cwd /home/atis/swig-test/src
gyp ERR! node -v v6.10.1
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok

I found the utility header file here: /usr/include/c++/4.8/utility
I have installed "swig3.0", "libjavascriptcoregtk-1.0-dev" and "libv8-dev" too.
I'm on Ubuntu 14.10, kernel 3.13.0-119.
gcc version 4.8.4
$ node-gyp list
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| linux | x64
6.10.1
gyp info ok

Any help would be great!

Compile your file as C++.  Node's and V8's API are C++ (C++11 to be specific) so if you include their headers in your source code, it needs to be compiled with a C++ compiler.

@bnoordhuis I've not really used C/C++ so far. How do I compile my .c file as C++?

I edited my comment after posting but for posterity, give it a .cc extension and it should be routed to the C++ compiler.

I don't really see how would renaming the .c file to .cc help. I did the rename but nothing changed.
Didn't mention earlier, but I've got a test2.i file with this content:
/* File: test2.i */
%module test2
%{
#include "test2.h"
%}
extern void some_test_method(char const *input, char *output);

I call swig3.0 -javascript -node test2.i which generates a test2_wrap.c file and this wrapper is referenced in binding.gyp:
{
    "targets": [
        {
            "target_name": "test2",
            "sources": ["test2_wrap.c"]
        }
    ]
}

If I rename test2_wrap.c to test2_wrap.cxx then I get a lot of other compiler errors.

Right, that's something you'll have to figure out on your own; it's not a node-gyp issue.
I'm going to close this out but if you're still looking for help, open an issue over at https://github.com/nodejs/help/issues.


Relayer CLI for MsgChannelOpenConfirm

Crate
primarily cli
Summary
We should be able to send transactions from the relayer CLI for MsgChannelOpenTry:
https://github.com/informalsystems/ibc-rs/blob/12cb1d6187e878eee0e40295fe0b804ddef0b846/modules/src/ics04_channel/msgs.rs#L216-L221
Proposal
The following CLIs should be implemented by the relayer:
relayer tx raw chan-open-confirm <to-chain-B> <port-id> <channel-id>

For Admin Use

[X] Not duplicate issue
[X] Appropriate labels applied
[X] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Believe this is closed by #403


npm list --json doesn't contain 'realPath'

Found when running licensed with npm v 5.5.1.  It didn't appear that any of the package information out put as part of npm list --json --production ... included a realPath property.  Instead I was seeing a path property.
    "array.from": {
      ...
      "path": "/Users/jonabc/.../node_modules/array.from",
      ...
    },

realPath might have existed for previous npm versions, I can't find good documentation for legacy versions.  However it seems like the path property can be used to find the packages unpacked location.

Hi, I would want to solve this issue. From my understanding path property needs to be added, I would send PR today only

As I was making sure while reading contributing guide test are running successfully. Results were
147 runs, 263 assertions, 3 failures, 4 errors, 4 skips

Failure: Licensed::Source::Pip::enabled?#test_0001_is true if pip source is available [/Users/manoj/opensource/licensed/test/source/pip_test.rb:14]:
Expected nil to be truthy.

Failure: Licensed::Command::Cache::with Bower#test_0001_extracts license info [/Users/manoj/opensource/licensed/test/command/cache_test.rb:40]:
Expected false to be truthy

Error: Licensed::Source::Pip::dependencies#test_0001_includes direct dependencies:
Errno::ENOENT: No such file or directory - /Users/manoj/opensource/licensed/test/fixtures/pip/venv/bin/pip

Error: Licensed::Source::Pip::dependencies#test_0002_includes indirect dependencies:
Errno::ENOENT: No such file or directory - /Users/manoj/opensource/licensed/test/fixtures/pip/venv/bin/pip

Failure: Licensed::Command::List::with Bower#test_0001_lists dependencies [/Users/manoj/opensource/licensed/test/command/list_test.rb:31]:
Expected /Found jquery/ to match "Displaying dependencies for bower\n  bower dependencies:\n  * bower dependencies: 0\n".

Error: Licensed::Command::List::with Cabal#test_0001_lists dependencies:
TypeError: no implicit conversion of nil into String

Error: Licensed::Command::Cache::with Cabal#test_0001_extracts license info:
TypeError: no implicit conversion of nil into String

@kumarmj 👋 thanks for taking a look at this!
Does it change anything to run bundle exec 'rake setup[-f]' before bundle exec rake test?  I've noticed that the contributing docs don't mention the bundle exec part, I'll update the documentation to include bundle exec 👍
Would you mind also helping me understand what tools/languages you have installed in your development environment?

[ ] npm
[ ] ruby/bundler
[ ] cabal
[ ] bower
[ ] pip
[ ] go
[ ] go + dep

Solved errors, it was becuase I had not installed cabal or bower or go & dep. I created pull request, let me know if changes are correct or some other changes are required.

@kumarmj I'll take a look at the errors, you shouldn't need to have all of the tools installed to be able to run the tests - they should skip when you don't have the required tools installed.

Fixed by https://github.com/github/licensed/pull/60


Major.Minor.Patch.Revision format

When running the tool at an Windows app, it throws an exception because the version is recognized by SemVer. Windows uses a fourth number as revision, which does not exists in SemVer.

Version                = A version string in quad notation, "Major.Minor.Build.Revision" [..]

https://docs.microsoft.com/en-us/uwp/schemas/appxpackage/uapmanifestschema/element-identity#syntax

Click to see the exception
panic: Invalid Semantic Version

goroutine 1 [running]:
main.check(0x5ea420, 0x14d06220)
        /home/travis/gopath/src/github.com/gabrielrobert/xavtool/helpers.go:47 +0x36
main.parse(0x14db1c78, 0x7, 0x14d060d0)
        /home/travis/gopath/src/github.com/gabrielrobert/xavtool/version.go:30 +0x45
main.incrementMinor(0x14db1c78, 0x7, 0x4, 0x5c1e39)
        /home/travis/gopath/src/github.com/gabrielrobert/xavtool/version.go:17 +0x36
main.increment(0x14d122c0, 0x14d06300, 0x14d122c0)
        /home/travis/gopath/src/github.com/gabrielrobert/xavtool/actions.go:55 +0x53d
github.com/urfave/cli.HandleAction(0x5925e0, 0x5cf72c, 0x14d122c0, 0x0, 0x14d2c270)
        /home/travis/gopath/src/github.com/urfave/cli/app.go:501 +0xa2
github.com/urfave/cli.Command.Run(0x5c2baa, 0x9, 0x0, 0x0, 0x14d063b8, 0x1, 0x1, 0x5c748a, 0x19, 0x0, ...)
        /home/travis/gopath/src/github.com/urfave/cli/command.go:165 +0x3d7
github.com/urfave/cli.(*App).Run(0x14d02380, 0x14d0e0b0, 0x2, 0x2, 0x0, 0x0)
        /home/travis/gopath/src/github.com/urfave/cli/app.go:259 +0x5cc
main.main()
        /home/travis/gopath/src/github.com/gabrielrobert/xavtool/main.go:19 +0x3a8

The same goes for iOS. The documentation mentions the use of a suffix for development. It gives some examples, but the final format is left to the developer. We use the Major.Minor.Patch.Revision format for that. E.g. <IP_ADDRESS>.
And for Android, you already reserved room for an extra revision number. E.g. 1000203.
P.s. I love this tool; it normalizes one of the boring task in Xamarin.

Very interesting, I will take a look at it very soon.

@jerone, just updated xavtool regarding this issue.

xavtool will generate a revision-based version for UWP. It will ignore the last sequence and just put '0' for all versions. This is something accepted in the semver community.

xavtool will be able to parse that kind of version by ignoring existing revision.

xavtool will not handle revision for iOS applications. As stated in your link:

When you release the new version of your app, remove the suffix.

Allowing revision edition through xavtool doesn't follow our semver philosophy. However, if you use it, it will be parsed and removed after a set/increment command.
Just pushed this: #13
P.s. Thank you for your time, really appreciated. I'm very open to any remarks/ideas :) Feel free to reopen this case if you think I'm not right.

Great! I'll try next week when I have to release a new version again 😋

Sorry for the late response. Planning changed, so I'm doing this from home :)
No exceptions anymore.
If it's not too much work or out of the scope of this tool, we would like to set the revision version also. We use that number for internal testing and don't show it to users. I know this goes against Semver philosophy.
Proposal
Thus using xavtool -s <IP_ADDRESS> would set:

Platform
Version
Internal Version

Android
1.0.2
1000203

iOS
1.0.2
<IP_ADDRESS>

UWP
<IP_ADDRESS>
-

Using it without reversion number (normal Semver) xavtool -s 1.0.2 would set:

Platform
Version
Internal Version

Android
1.0.2
1000200

iOS
1.0.2
1.0.2

UWP
<IP_ADDRESS>
-


[Tree Borrows] Introducing Protectors

Add support for protectors, corresponding to Part 3: Introducing Protectors

Be reminded that Reserved has the special case for ReservedIM that only appears when you're not protected.

This patch is currently stacked on #223

By https://github.com/rust-lang/miri/pull/3732, the current protector end semantics are slightly different from the original version in the Part 3: Introducing Protectors.

@JoJoDeveloping  I would appreciate it if you could give me some advice on this PR :)
FYI, the main implementation is in thespec/mem/tree_borrows

Here are some things I noticed:

there currently is only one kind of protectors. Miri distinguishes Strong and Weak Protectors, the former additionally preventing any deallocation

Currently, protection data is duplicated:

each node stores whether it is protected
the entire memory maintains not just a set of active calls, but instead a map that for each active calls also maintains the entries protected by it.
it turns out that this map only ever stores the empty set, so something is wrong here: it should either be a Set (instead of a Map<_, Set<_>>), or the data stored there should actually be modified. Then the end_call hook also must be made coherent.

this introduces an additional state coherence invariant that these two never desync. I'm afraid that having too many of these makes it in the end impossible to reason about this.

Permission::default should probably panic when it's called with a & T where T: !Freeze.

The handling of protected ReservedIM is wrong: These should never be created. Instead, when we do a protected reborrow for a &mut T where T: !Freeze, it should just become a normal Reserved instead of a ReservedIM.

Please also add a test for this. In general, the tests introduced at the following two PRs are intricate and might be ported over, if applicable (they might use multi-threading so unsure):

https://github.com/rust-lang/miri/pull/3742
https://github.com/rust-lang/miri/pull/3732

The code at https://github.com/minirust/minirust/blob/b5fe3fc42cd09cec4d6a0f29d6e69d60fbb4b1cc/spec/mem/tree_borrows/tree.md?plain=1#L60 is duplicated several times, better factor it into its own method.

@JoJoDeveloping  Thank you for the helpful comment :)

I noticed something today I forgot yesterday: I think your handling of protectors is still not fully correct. An active protector has two effects:

It slightly changes the transition matrix. Notably, ´Reserved` becomes conflicted when there is a protector persent
It makes many foreign accesses UB. However, this foreign access UB only happens when the tag to which it is happening has been accessed before (i.e. is Accessed::Yes). Basically, foreign accesses to Accessed::No locations never cause protector UB.

This causes some slight mismatches between the intended and actual semantics. Where precisely the bug is then depends on what the actively_protected parameter in Permission::transition is supposed to mean:

if it means "protected and accessed," then foreign_read might not make Reserved's conflicted when it's a protected but not-yet-accessed node. These should, however, become conflicted even if not yet accessed.
if it means "protected (no matter whether accessed or not)", then foreign_write causes too much UB since it should not be UB for protected but not-yet-accessed nodes. There should not be UB for not yet accessed nodes.

This semantics is quite intricate, so it's rather easy to overlook this. There should presumably be a test (or several) testing that:

non-accessed protected nodes do not cause UB on foreign writes
non-accessed protected Reserved nodes still become conflicted and block child writes
when a protector ends, it no longer has any effect (such a test seems to be missing?)

Besides, I'm always confused whether this PR or https://github.com/minirust/minirust/pull/223 is the actual PR, since one of them subsumes the other (right?). Could you close (or mark as draft) that other PR?

Yeah, I also noticed that it is kind of meaningless, closed it :)

Fixed above.

Squashed :)


Fix: Wait before counting files in unit tests

The units tests do some checks to ensure that files are correctly cleaned up. However, this cleanup occurs asynchronously so we should delay to ensure this has had enough time to complete.

There are still some flakey e2e failures on macOS. It looks like the main process has native crashed whereas we're expecting a renderer crash.
I don't have my Mac with me until the new year so I'm unable to dig any deeper locally!

I'm also out on vacations for the rest of the year - but if you don't get your hands on a macos machine, I can help debug when I get back in the new year!
Happy holidays @timfish!

I ran the tests again and they passed. Just massive flake on the macOS tests.


Fix: Handle case where Python version is already installed (#222)

Fix: Handle case where Python version is already installed (#617)

Hi @samruddhikhandale
Could you check out the pull request when you have a moment?

@gvatsal60 The code is intentionally in place. Why would you want to remove exit 1? If the version still exists, why not pass none or another version?

@gvatsal60 The code is intentionally in place. Why would you want to remove exit 1? If the version still exists, why not pass none or another version?

I am looking into it. Will update the PR soon.

@samruddhikhandale I have updated the PR. Please have a look...

@samruddhikhandale Shouldn't this have generated a version update?
I thought that any feature change merged to main should have its corresponding version update.
NOTE:  I just came here trying to check if this PR made the GitHub tags work again but, as the version was not updated, no luck to check...

Hi @rubensa,
I realized I forgot to update the version in the previous PR. I've submitted a new one to address this: #1148.
I’ll also look into solutions to prevent version update oversights in the future.
Thank you!


Support for Vite generated template

What problem does this feature solve?
Currently the instructions to make vue-router@next with vue@next do not take into consideration the scenario where the vue application was generated by vite and has a module bundler such as rollup. The instructions just demonstrate that it is possible make it work with an index file that points to CDNs and has a script tag.
Trying to follow those instructions with a generated vue template and making the necessary teaks such as not pointing to the CDNs because there is already a main file that resolves those imports results in an error.
[Vue warn]: Component provided template option but runtime compilation is not supported in this build of Vue. Configure your bundler to alias "vue" to "vue/dist/vue.esm-bundler.js"
The way I managed to solve it was:
import { createApp } from 'vue/dist/vue.esm-bundler.js'
import { createRouter, createWebHashHistory } from 'vue-router'

As I didn't like that reference there I tried tweaking vite.config.js
import { defineConfig } from 'vite'
import vue from '@vitejs/plugin-vue'
import alias from '@rollup/plugin-alias';

// https://vitejs.dev/config/
export default defineConfig({
  plugins: [vue()],
  build: {
    rollupOptions: {
      plugins: [
        alias({
          entries: [{ find: 'vue', replacement: '/node_modules/vue/dist/vue.esm-bundler.js' }]
        })
      ]
    }
  }
})

But it unfortunately didn't work.
It would be really nice if vue-router@next has an official documentation describing how to make the router work in that scenario since in these days vite is gaining a lot of traction.
Thanks in advance,
If needed I can provide a repository showing the issue but it is very easy to replicate.
What does the proposed API look like?
There is no change in the api itself, just support for vite module bundler.

Duplicate of #829

You don't need to configure anything to make vue router work with Vite

@posva If that is the case why I can't make it work with this line that would be the correct:
import { createApp } from 'vue'
And I have to hack it pointing to a specific bundler?
import { createApp } from 'vue/dist/vue.esm-bundler.js'
I was getting an error:
[Vue warn]: Component provided template option but runtime compilation is not supported in this build of Vue. Configure your bundler to alias "vue" to "vue/dist/vue.esm-bundler.js"
Could you point me to the right direction?

This worked for me in vite.config.ts
export default defineConfig({   define: {     'process.env': {}   },   plugins: [vue()],   resolve: {     alias: {       'vue': 'vue/dist/vue.esm-bundler.js'     }   } })

@sparrowhawk-ea thar makes a lot of sense, thanks a lot!!!

@sparrowhawk-ea  thanks,
you save me a lot of time.

Hmmm. I had the same problem. Except @sparrowhawk-ea's solution fixed my issue.
Considering all the upvotes for @sparrowhawk-ea post I think it worth a mention from the maintainers why this is still a common thing for people to come across. @posva


Removed duplicate 'rspec/core import in rake file

Hello, it seemed that there were two rspec/core imports in the project's Rakefile (per issue #292). I have removed the second one from inside the first task.

Thanks!


合入hessian官方4.0.3部分源码，支持java.util.EnumSet反序列化

参考信息

http://bugs.caucho.com/view.php?id=3663
https://github.com/ebourg/hessian/commit/5900c10d02ba9b7da034dc3152e5bc56e77ad436#diff-ff2a04edcb02d49b6d002a6b447da53f

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

https://github.com/alibaba/dubbo/commit/6d375614466f96ed3e18721c008e35e88a23a8dd 解决了这个问题。Pull request 里的改动并不适合直接进入，因为 JavaSerializer 不工作，而 hessian-lite 主要是围绕 JavaSerializer 工作的。


Lottie Animation Flickers on First Play but fine after initial play

Description
I have a custom lottie animation json file which I created. I created it on an iPad using procreate, exported as .mp4 and converted the .mp4 file to lottie json using this website. It generated a .json file for me which I then tested on the lottie file editor on the lottie files website. It seems to work fine and there's no flickering in sight. I then added this into my react native project.
I turned loop to false since I only need to play it once but if I enable it, I can see that the initial play of the animation flickers but it's fine after that. What I also found weird that I did try and record a gif of the initial play so I can preview the flickering but it doesn't actually show as flickering in the gif which is weird to me. I'm not sure if that's connected somehow.
Streamable link to the issue
https://streamable.com/g8e0k3
Steps to Reproduce
My code:
App.js
import React from 'react';
import { createAppContainer, createSwitchNavigator } from 'react-navigation';
import { createStackNavigator } from 'react-navigation-stack';
import SplashScreen from './src/screens/SplashScreen';
import LandingScreen from './src/screens/LandingScreen';
import LoginScreen from './src/screens/LoginScreen';

const navigator = createSwitchNavigator(
  {
    Splash: {
      screen: SplashScreen,
      navigationOptions: {
        headerShown: false,
      },
    },
    Landing: {
      screen: LandingScreen,
      navigationOptions: {
        headerShown: false,
      },
    },
    Login: LoginScreen,
  },
  {
    initialRouteName: 'Splash',
    defaultNavigationOptions: {
      title: 'App',
    },
  }
);

export default createAppContainer(navigator);

SplashScreen.js
import React from 'react';
import { StyleSheet, View } from 'react-native';
import LottieSplash from '../components/LottieSplash';

const SplashScreen = ({ navigation }) => {
  return (
    <View style={styles.container}>
      <LottieSplash
        onAnimationFinish={() => {
          navigation.navigate('Landing');
        }}
      />
    </View>
  );
};

const styles = StyleSheet.create({
  container: {
    flex: 1,
    backgroundColor: '#f1f3f4',
    justifyContent: 'center',
    alignItems: 'center',
  },
});

export default SplashScreen;

LottieSplash.js component
import React, { Component } from 'react';
import LottieView from 'lottie-react-native';

export default class LottieSplash extends Component {
  constructor(props) {
    super(props);
  }

  render() {
    return (
      <LottieView
        style={{ height: 180, width: 180 }}
        source={require('../../assets/lottie/splash.json')}
        autoPlay
        loop={false}
        onAnimationFinish={this.props.onAnimationFinish}
      />
    );
  }
}

Expected behavior:
Animation plays with no flickering and navigates to the landing screen
Actual behavior:
Animation flickers and then navigates to the landing screen
Versions
"@react-native-community/masked-view": "^0.1.10",
"@react-navigation/native": "^5.8.10",
"@react-navigation/stack": "^5.12.8",
"expo": "~40.0.0",
"expo-status-bar": "~1.0.3",
"lottie-ios": "^3.1.8",
"lottie-react-native": "~2.6.1",
"react": "16.13.1",
"react-dom": "16.13.1",
"react-native": "https://github.com/expo/react-native/archive/sdk-40.0.1.tar.gz",
"react-native-gesture-handler": "~1.8.0",
"react-native-reanimated": "~1.13.0",
"react-native-safe-area-context": "3.1.9",
"react-native-screens": "~2.15.0",
"react-native-web": "^0.16.2",
"react-navigation": "^4.4.3",
"react-navigation-stack": "^2.10.2"

I seem to have fixed this by doing npm update I'm not actually sure on what package has caused this but it seems to be working as it should now.


Update Korean localization

I've localized the added strings. It would be great to merge it when the next release comes out!
I'll keep updating this PR as additional strings become available.

I updated for the added strings.

I have update a little translation text from https://github.com/quiple/social-app/tree/update-korean-localization. My repository is https://github.com/hurss/social-app/tree/korean-localization if you want to update Korean translation.

I have update a little translation text from https://github.com/quiple/social-app/tree/update-korean-localization. My repository is https://github.com/hurss/social-app/tree/korean-localization if you want to update Korean translation.

Thank you! I double-checked the string in that part against your localization and updated the localization.

I would like #2537 to be merged first before merging this.

@quiple okay that's merged. I assume you want to tune something here in response, then this is ready to go?

@quiple okay that's merged. I assume you want to tune something here in response, then this is ready to go?

@pfrazee I found one more part of the translation where the position of Trans needed to be changed. #2568
I've updated the Korean localization. Please merge the above PR and I'll update again.

@pfrazee I don't think there's any problem with modifying it now, thanks!

@pfrazee Please merge #2502 as well, and I'll update localization again.

@quiple okay done -- lmk when this is good to go

@pfrazee Yeap, I think It's done, thanks!


Dubbo-thread-xxx threads that should not appear on the consumer side

[x] I have searched the issues of this repository and believe that this is not a duplicate.
[x] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

Dubbo version: 2.7.8
Operating System version: mac os
Java version: 1.8

Steps to reproduce this issue

Start multiple provider nodes
(中文：启动多个提供方节点)

Start consumer node
(中文：启动消费方节点)

Frequently shutdown and restart provider nodes or Frequently enable and disable provider nodes
(中文：频繁关闭、重启提供方节点或者频繁启用、禁用提供方节点)

Pls. provide [GitHub address] to reproduce this issue.
Expected Result
What do you expected from the above steps？
Only the thread of DubboClientHandler-xxx will appear
(中文：应该只会出现DubboClientHandler-xxx的线程用于网络连接、断连，因为获取响应结果用的是主线程)
Actual Result
What actually happens?
There are many threads named with Dubbo-thread-xxx on the consumer side，these threads will not be recycled.
(中文：消费方出现了很多以Dubbo-thread-xxx命名的线程，这些线程不会被回收)

Resolved in https://github.com/apache/dubbo/pull/7109


Syntax Error

[root@x]# python3.3 irc.py   File "irc.py", line 63     print(f'{get_time()} | [~] - {msg}')                                       ^ SyntaxError: invalid syntax [root@x]# python irc.py   File "irc.py", line 63     print(f'{get_time()} | [~] - {msg}')                                       ^ SyntaxError: invalid syntax
please help

As stated in the README file:
"This script was developed to be used with the latest version of Python."
I would imagine you are on debian and do not have the latest Python version which introduced FSTRINGS.

I use centos 7 64x and python3.5?

Thats cool. Did your Centos build come with a web browser so you can go on Google?
https://www.python.org/downloads/release/python-364/

"This script was developed to be used with the latest version of Python."
I use centos 7 64x and python3.5?

I am not sure why this is so confusing to you...


Add Labeler#upsert_keys

Like I added Featurizer#upsert_keys (#258), I'd like to add Labeler#upsert_keys.
The use case is to deploy a generative model (instead of a discriminative model) somewhere different from where you train this generative model.

This is great idea. Can we have a test for this as well?

Yes, I'll add another commit for a test.


Kernel 3.10.102 is not supported

Hello,
And thanks for your good job.
I've a question. I've wanted compiling virtualbox for my DSM 6.1.7-15284 but when I install it, I've an issue "Kernel 3.10.102 is not supported".
I tested to change branch 15152 to 15284 in the config script but it doesn't good ... normal, the sources are branched in 15152.
Have you a solution to bypassed this issue ?
Thanks in advance for your response.

OK I found solution
On my NAS I made "cat /proc/version" = 3.10.102
And I change the check from 3.10.105 to 3.10.102 in the file
toolkit/build_env/ds.bromolow-6.1/source/virtualbox4dsm/spk/scripts/installer
It's works


Login Component

dod: the nav bar is not visible in the login view -> also, the login view should be part of the new design

reviewed


Screensaver on second display does not display correctly

General troubleshooting tips
Before logging an issue please check that:

[X] You have the latest version installed (There may be a beta version that fixes your issue), see here for the latest releases and bug fixes: https://github.com/JohnCoates/Aerial/releases
[X] Your issue isn't already mentioned in our issues. You may find a workaround there or a similar request already made.
[X] Your problem isn't mentioned in the troubleshooting page.

If none of this fixes your issue, tell us about the problem you are experiencing or the feature you'd like to request.
Required information
In order to help us sort your issue, we ask that you provide the following information:

[X] Mac model: Apple M1 Pro
[X] macOS version: macOS Ventura - Version 13.2.1
[X] Monitor setup:

monitor 0: (lid closed on laptop) - not using built-in display
monitor 1: HP Z32 - (3840x2160)
monitor 2: Dell U2720Q - (2160x3840 - vertical arrangement)

If appropriate, please enable Debug mode and Log to disk in Advanced tab and replicate your bug, then attach the AerialLog.txt file (You can access this file through the Advanced tab).
Description of issue / Feature request
I have two displays, and initially, everything seems to work. But after maybe 1 or 2 seconds, the secondary screen (vertical alignment) shifts to a horizontal frame (based on horizontal arrangement - even though it is vertical) and only fills part of the window.  Otherwise (other than the weird rendering on the second screen), everything seems operational. It is not the end of the world, but it is certainly annoying.
I have tried both the regular (3.2.5 and beta 3.2.5 versions of the software)
Below I have included what I think is the relevant part of the debug log
2023-05-26 06:28:08.915 : night
2023-05-26 06:28:08.916 : Manual : night
2023-05-26 06:28:08.916 : night
2023-05-26 06:28:08.916 : Brightness before Aerial was launched : Optional(0.0)
2023-05-26 06:28:08.916 : Real screen count : 2
2023-05-26 06:28:08.917 : Using : Optional([id=3, width=2160, height=3840, bottomLeftFrame=(3840.0, -883.0, 2160.0, 3840.0), topRightCorner=(6000.0, 2957.0), isMain=false, backingScaleFactor=1.0])
2023-05-26 06:28:08.917 : <AerialView: 0x147699920> setting up player layer with bounds/frame: (0.0, 0.0, 2160.0, 3840.0) / (0.0, 0.0, 2160.0, 3840.0)
2023-05-26 06:28:08.917 : The data couldn’t be read because it isn’t in the correct format.
2023-05-26 06:28:08.918 : The data couldn’t be read because it isn’t in the correct format.
2023-05-26 06:28:08.918 : Using dot workaround for video driver corruption
2023-05-26 06:28:08.918 : <AerialView: 0x147699920> backing change 1.0 isDisabled: false frame: (0.0, 0.0, 2160.0, 3840.0) preview: false
2023-05-26 06:28:08.919 : <AerialView: 0x15666f3a0> startAnimation frame (0.0, 0.0, 3840.0, 2160.0) bounds (0.0, 0.0, 3840.0, 2160.0)
2023-05-26 06:28:09.022 : <AerialView: 0x15666f3a0> observeValue Optional("readyForDisplay") true
2023-05-26 06:28:09.022 : start playback: (0.0, 0.0, 3840.0, 2160.0) (0.0, 0.0, 3840.0, 2160.0) rate: 1.0
2023-05-26 06:28:09.402 : <AerialView: 0x147699920> startAnimation frame (0.0, 0.0, 2160.0, 3840.0) bounds (0.0, 0.0, 2160.0, 3840.0)
2023-05-26 06:28:12.117 : ############ willStop
2023-05-26 06:28:12.118 : <AerialView: 0x15666f3a0> stopAnimation
2023-05-26 06:28:12.119 : <AerialView: 0x15666f3a0> observeValue Optional("readyForDisplay") false

Hi @bfg111
Are you 100% sure you are running Ventura 13.2.1 and not 13.3.1 ?
Because this looks an awful lot like a variation of the huge multimonitor bug that we're discussing here : https://github.com/JohnCoates/Aerial/issues/1286 , but as far as I remember, it started with 13.3betas (though to be honest because I'm on the beta cycle I could have missed the point update).
Also, does the bug happen 100% of the time ? Last thing, a log from an entire run would be more helpful, I can't see any of your settings/videos here.

This bug happens every time without fail. I will include an image.

ProductName:             macOS
ProductVersion:         13.2.1
BuildVersion:           22D68

Thanks for the picture. This is a bit weird and likely different. The margin at the bottom is also a bit weird and uncharacteristic.
I think you are running Viewing mode : Independant in Aerial's Settings > Display, correct ? or is this a Spanned mode ?
I'll try to dig a bit, I think some people complained of issues with vertical screens with one particular macOS build, will keep  you posted.

Ok I found some more info digging into discord, they had this bug during the beta and reintroduced multiple times depending on the configurations, last report I have is in November, this one has a nice video that seems to exactly mimic your issue : https://discord.com/channels/736331643723317248/742308387903242270/1044762078520557599
I believe that's the same issue you have.
What I remember from that time is that playback also failed similarly with Quicktime, you may want to try and play one of Aerial's videos from the Cache folder in quicktime on your vertical screen and activate full screen, if I remember correctly it had the same issue.
Assuming it's the same macOS issue, this is something you'll need to update.
However it's a bit of a mess, 13.3.x should be avoided per the other link I gave you earlier. 13.4 is "okayish" regarding that core bug.
I do have multiple people who reported that 13.4 works correctly with a setup similar to yours (one vertical + one horizontal), including in the link above, but as best as I can recall, the rotation bug that affected Quicktime was probably a graphic driver bug that could be specific to some GPU, so no guarantee.

I can confirm that QuickTime player has the exact same issue trying to display in full-screen mode on the second (vertical) monitor. Oddly, with QuickTime player if I move my mouse on the secondary (vertical) display it switches to full-screen mode (working) for about a second and then back to the weird behavior of only using part of the screen. Thanks for pointing me in the right direction.

No problem, thanks for confirming! Should you update to 13.4, let me know how it goes.


Edu program queue

Changes made before meeting on 06/10.

Codecov Report

Merging #3 (9632169) into master (6014c63) will decrease coverage by 2.48%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   93.01%   90.53%   -2.49%
==========================================
  Files          11        9       -2
  Lines         229      169      -60
==========================================
- Hits          213      153      -60
  Misses         16       16

Impacted Files
Coverage Δ

Tests/GoldenTests/HelloDummy.test.cpp
83.33% <ø> (ø)

Tests/GoldenTests/HelloWorld.test.cpp
80.00% <ø> (ø)

Sts1CobcSw/Utility/TypeSafe.hpp
50.00% <50.00%> (ø)

Sts1CobcSw/Periphery/PersistentState.cpp

Tests/UnitTests/PersistentState.test.cpp

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Cannot read property 'length' of undefined

Problem when running generated js code
/root/homemnt/heads/thingml-gen/nodejs/FieldNode/lib/SensorTimerJS.js:60
const arrayLength = self.timer_timeoutOntimerListeners.length;
                                                      ^

TypeError: Cannot read property 'length' of undefined
    at sendTimer_timeoutOnTimer (/root/homemnt/heads/thingml-gen/nodejs/FieldNode/lib/SensorTimerJS.js:60:55)
    at processImmediate [as _immediateCallback] (timers.js:383:17)
root@ubilinux:~/homemnt/heads/thingml-gen/nodejs/FieldNode/lib#

sensortimer.zip

Is your compiler up to date? We do not use these self.<msg>On<Port>Listeners anymore... I did a big refactoring last week, to remove all the .bind in the genrated code and I also changed the internal communication (listeners) + some other things to try to make the integration with JS code simpler.

Also, I have been using this exact SensorTimerJS component with the new compiler and it is working. I probably changed something in the way we mix JS and ThingML, so here is the source:
import "../SensorTimer.thingml"

// Manage a set of software timers.
thing SensorTimerJS includes SensorTimer
@pim "SensorTimer"
@platform "javascript"
@javascript "node browser"
{
    function cancel()
    do
        'clearTimeout(this.timer);'
    end

    function starting(delay : Integer)
    do
        'this.timer = setTimeout(()=>{'
        timer!timer_timeout()
        '},' & delay & ');'
    end

    function startInterval(interval : Integer)
    do
        'this.timer = setInterval(()=>{'
        timer!timer_timeout()
        '},' & interval & ');'
    end

    /*function onTimeout()
    do
        timer!timer_timeout()
    end*/

    statechart SoftTimer init default {
        state default {

          internal startState
            event m : timer?timer_start
            guard m.delay > 0
            action do
                starting(m.delay)
            end

           internal startInterval
            event m : timer?timer_start_interval
            guard m.interval > 0
            action do
                startInterval(m.interval)
            end

          internal cancel
            event m : timer?timer_cancel
            action cancel()
        }
    }
}

I am running
ThingML 0.7.0
@brice-morin brice-morin released this on 4 Jan · 126 commits to master since this release
ThingML 0.7.0, Copyright SINTEF, released under Apache 2.0 license
Downloads
5.92 MBorg.thingml.eclipse.updatesite-0.7.0.zip
That is the latest zip at https://github.com/SINTEF-9012/ThingML/releases.
Eclipse also report 0.7.0 after check for updates.
Where can I find the new release?

You have to use the update site that contains the latest version of ThingML, not the release, as detailed at the end of the Installation section


Collapsibles not opening

Hi,
I am having trouble using collapsibles.
I have an array of items that I am looping over and using each item to populate a custom component, like so.
However, when trying to open a collapsible, it simply won't do it. There's nothing being fired when I click on it.
Here's the HTML:

work{{this.item.id}}

                <my-item [item]="item"></my-item>

I have tried adding a simple one like so - same thing is happening:

Stuff

Things

There's no errors in the console.
In my index.html, I am importing materialize last.
In my app component, I am importing the MaterializeModule last also.
Will be happy to provide more info if needs be - really scratching my head on this one! Cheers.

Try to change

to

I have this very same problem.
`

filter_dramaFirst
Lorem ipsum dolor sit amet.

placeSecond
Lorem ipsum dolor sit amet.

whatshotThird
Lorem ipsum dolor sit amet.

`
Looks like the directive isn't called at all

@tommydeaks , did the change @DmitriiSer suggested worked for you? He's right - that's the correct way to do it.
@yoannpicquenot , using your code it works fine for me. Does any other Materialize JS directives works for you? Any errors in the console? I'd guess it's an import/bootstrapping issue of angular2-materialize/MaterializeCSS.


[Addition]: Grasshopper is not were he stated

Hotspot b58 Addresses
112cvKN4BsfgHAv9ZJCjZ6EH492EjfaKJ6Co2KLjv9yTstr3bwAw
Discord Handle
No response
Reason(s)
HS‘s beacons are never ever recognized in its area - most witnesses are based way over 20km away in a bigger city with lower transmit scale…
Shortly after it’s activation it was spotted by a mapper device around its stated location -  nowadays it’s gone…
So surely setup location was changed without update in the app - means: Location spoofing


Password Visibility button implement on sign in page

sign in page do have the logic of password visibility but there is no button to trigger the visibility of password , implement a button for the same

Assign me this one too.

@ChaudaryHammad assigned

use an eye icon inside the input field which should toggle on click

I think it should also be on the signup page.

yes, will need one on sign up page as well


java.lang.NullPointerException: Cannot invoke "Object.getClass()" because "object" is null

Hi @silvercall . Can you please expand about the issue? We do have a template for issues like this:

Description
Testcase
Platform used, drivers and TornadoVM backend used.


Need help upgrading SciPy

I'm trying to upgrade my SciPy but i'm having some issue. Now, apparently my Ubuntu doesn't have lapack and blas. How can I do this upgrade then?
Thanks in advance.

There is lots of info on how to install blas/lapack on ubuntu, e.g. https://askubuntu.com/questions/623578/installing-blas-and-lapack-packages
You're welcome to use this tracker for reporting scipy bugs or filing enhancement requests. Since this is not one of those, I'm going to close it.


Dunitz/830 collection deletion

Reviewers
Functional:
@Bento007
Readability:
@seve
Changes

add endpoint to tombstone collections

Definition of Done

The collection will no longer appear in the list of private Collections nor public collections
The collection cannot be retrieved by the user
Datasets that were in the collection cannot be retrieved.
Artifacts cannot be download from direct links
Get collection return 403 for a deleted collection
Get dataset/status returns 403 for a deleted dataset
Return status 202 to confirm the deleted or if the collection has already been deleted.

@MDunitz thanks for adding this endpoint 🎉 !! I just changed the PR to merge into the feature branch feature-delete-collection , so it gets the code to enable the delete button in FE 😄 Please help merge the feature branch into main 🙏! Thank you!


[turnstile] Document widget sizes & size=compact

Compact size 👀
Dimensions are TBA, so I just took a guess. This is not yet in staging but soon:tm:? Staging 👀 In production now
size parameter/attribute is already accepted for hCaptcha compatiblity but using compact is currently causing a warning. No longer causes a warning

@kodster28 Conflicts resolved.


Create database storage from ENV variables

Is your feature request related to a problem? Please describe
We right now have no way of using storage via iab.
Describe the solution you'd like
Create a check for ENV variables to build the storage automatically.

alternatively use the options of iab


Add perplexity.ai

Perplexity seems to be primarily serving Llama 3.1 finetunes at the moment. Llama 3.1 itself is already covered by Together, and the finetunes are not in scope for HELM.


 instead of

Is there a way to render a Fragment instead of the default p tag? My table doesn't allow nested paragraphs in the DOM nodes for the cells thus I need an empty container like a Fragment. Is there anyway to do that?

<ReactMarkdown
    source={content}
    renderers={{
        paragraph: props => <React.Fragment {...props} />
    }}
/>


[Console-IoT] Create flow for clone a deice using wizard

Type of change

Enhancement / new feature

Description
 Create flow for clone a device using wizard
Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

Can one of the admins verify this patch?

@suyash-naithani When cloning a device through the wizard, the metadata info needs to be copied as well. We need to enable the metadata component to accept and generate metadata based on props.


Clarification: can service and plan names be updated?

The spec says explicitly that the ID of services and plans should never change.  This seems to imply that the names of these entities can change, but this is not explicitly stated in the spec, that I can find: https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md#catalog-management
If names are mutable, we should call it out explicitly (I'm happy to make the PR for it).

CF has this doc: https://docs.cloudfoundry.org/services/managing-service-brokers.html
Seems to me we should include a variant of this in the spec. In particular the "Catalog Validation Behaviors" table where it says:
A service or plan in the marketplace database are found with a unique_id that matches the broker catalog’s ID.
results in:
The marketplace must update the records to match the broker’s catalog.

Opened issue: https://github.com/openservicebrokerapi/servicebroker/issues/189  for my comment

It is hostile to users to change names of services. It would put them at risk of bait-and-switch, and would be an obstacle to both portability and automation.
I recommend declaring them to be immutable.

I also would strongly prefer for service names and plan names to be immutable.

@duglin I seem to remember adding clarity around this but can't find it in the spec. Am I mistaken?

I think we tried to deal with it with this text:

When determining what, if anything, has changed on a Service Broker, the Platform MUST use the id of the resources (services or plans) as the only immutable property and MUST use that to locate the same resource as was returned from a previous query. Likewise, a Service Broker MUST NOT change the id of a resource across queries, otherwise a Platform will treat it as a different resource.
When a Platform receives different id values for the same type of resource, even if all of the other metadata in those resources are the exact same, it MUST treat them as separate instances of that resource.

So I think we can close this one now. Closing...


Unusual scaling in Container Apps

Please provide us with the following information:

This issue is a: (mark with an x)

[X ] bug report
We see unusual scaling activity in Azure Container Apps. Even when there are no messages in the queue, it's scaling to 1 or 2 container apps. There are 2 places we see different metrics. In Log Stream, we are getting a message like "This revision is scaled to Zero", but Metrics still shows some containers are running. This behavior is confusing. When we aggregate Sum in metrics it shows some 20k replicas created in replica count. But the actual count of messages in the Queue itself is 760 and the scaling rule is set to scale 100 messages per replica.

Steps to reproduce

Create a queue triggered Container app
Set the scaling to Queue trigger and queue length to 100
Post some 1000 messages to the queue
Look for the metrics of Replica Count

Expected behavior
For 760 messages and QueueLength of 100, it should create max of 8 replicas but created almost 1200 replicas
Screenshots

Additional context
In Portal when we look into the Sum aggregate of Replica Count. Please explain how exactly the scaling is happening in Container apps and replicas are created on what basis? Is there something wrong with the metrics?

I think you want to use Max, not Sum when aggregating the replica count metric. Metrics are emitted on a fixed interval regardless of changes in the metric value. A metric once a minute reporting 20 replicas of your app for an hour will show 20 replicas with Max, but 1,200 with sum.

Hi @vinothrao did Ahmed and Charles resolve your problem? If so I will close the issue.

Closing this issue. See this comment for details https://github.com/microsoft/azure-container-apps/issues/554#issuecomment-1442352986


Remove Trakt images

Motivation for changes:
Trakt no longer provides images.
Detailed changes:

Removed images and updated cassettes.

Looks good to me


body: add fuelGauge to body carState

Depends on https://github.com/commaai/cereal/pull/292
Partial replacement for https://github.com/commaai/openpilot/pull/24383
To explain why I am dividing by 100 in the change:
https://github.com/commaai/cereal/pull/292 introduces a generic
fuelGauge field and defines it as a Float32 in an effort to make this field
generic and capable of handling more precise reporting.
The Comma body, however, is reporting battery percentage as an integer from
zero to one hundred, so this change is dividing by 100 to get the number
into that range. Is this appropriate?
It also does not perform any error checking to know if it's okay to
do this as I'm making the assumption that it's safe. Is this indeed a safe
assumption?
For verification this was tested on a comma body using code from
https://github.com/commaai/openpilot/pull/24383 which renders a battery
level on the display (doing math as needed):
QString::number(sm["carState"].getCarState().getFuelGaugePercentage()*100)

This works fine. I don't like the fact that I'm doing / 100 and
then * 100 but it's probably worth it for maintaining the generic-ness
of the fuelGauge field.

You have to push the new cereal in this PR as well.

rebased away the extra commits, replay test needs attention but looks out of my control

Yeah, we need to update the process replay references since they get pushed to an internal azure bucket. No need to worry too much about fixing up your branch history since we squash and merge anyway.


Problem with example script

A user reported the following error when running the example notebook:
Traceback (most recent call last):
  File "pvextract.py", line 31, in <module>
    pv = extract_pv_slice(hdu, xy)
  File "/usr/local/lib/python2.7/dist-packages/pvextractor-0.0.dev225-py2.7.egg/pvextractor/pvextractor.py", line 103, in extract_pv_slice
    header = slice_wcs(wcs, spatial_scale=world_spacing).to_header()
  File "/usr/local/lib/python2.7/dist-packages/pvextractor-0.0.dev225-py2.7.egg/pvextractor/utils/wcs_slicing.py", line 31, in slice_wcs
    wcs_slice.wcs.crpix[0] = 1.
astropy.wcs._wcs.SingularMatrixError: ERROR 3 in wcsset() at line 1873 of file cextern/wcslib/C/wcs.c:
Linear transformation matrix is singular.
ERROR 3 in linset() at line 467 of file cextern/wcslib/C/lin.c:
PCi_ja matrix is singular.

I can't reproduce this.  I don't know why.

Hello,
I have the same error when I use the example script :
def load_wcs_from_file(filename):
    # Load the FITS hdulist using astropy.io.fits
    hdulist = fits.open(filename)

    # Parse the WCS keywords in the primary HDU
    w = wcs.WCS(hdulist[0].header)

    # Print out the "name" of the WCS, as defined in the FITS header
    print(w.wcs.name)

    # Print out all of the settings that were parsed from the header
    w.wcs.print_contents()

    # Some pixel coordinates of interest.
    pixcrd = numpy.array([[0, 0], [24, 38], [45, 98]], numpy.float_)

    # Convert pixel coordinates to world coordinates
    # The second argument is "origin" -- in this case we're declaring we
    # have 1-based (Fortran-like) coordinates.
    world = w.wcs_pix2world(pixcrd, 1)
    print(world)

    # Convert the same coordinates back to pixel coordinates.
    pixcrd2 = w.wcs_world2pix(world, 1)
    print(pixcrd2)

    # These should be the same as the original pixel coordinates, modulo
    # some floating-point error.
    assert numpy.max(numpy.abs(pixcrd - pixcrd2)) < 1e-6

This is my error :
WARNING: VerifyWarning: Invalid 'BLANK' keyword in header.  The 'BLANK' keyword is only applicable to integer data, and will be ignored in this HDU. [astropy.io.fits.hdu.image]
WARNING: FITSFixedWarning: 'celfix' made the change 'Linear transformation matrix is singular'. [astropy.wcs.wcs]
Traceback (most recent call last):
  File "/home/teodori/Bureau/Projet/main.py", line 48, in <module>
    load_wcs_from_file(filepath)
  File "/home/teodori/Bureau/Projet/main.py", line 16, in load_wcs_from_file
    w = wcs.WCS(hdulist[0].header)
  File "/usr/local/lib/python3.4/dist-packages/astropy/wcs/wcs.py", line 500, in __init__
    self.wcs.set()
astropy.wcs._wcs.SingularMatrixError: ERROR 3 in wcsset() at line 2213 of file cextern/wcslib/C/wcs.c:
Linear transformation matrix is singular.
ERROR 3 in linset() at line 607 of file cextern/wcslib/C/lin.c:
PCi_ja matrix is singular.

This is the picture i used :
image.zip
I'm using Python 3.4.3
Thanks


Review automation for opportunities to improve security posture

We want to ensure all workloads are scanned for security issues before reaching the Azure infrastructure.
DoD:

[ ] Documentation of gaps in security scanning
[ ] Documentation of proposed resolution/tooling
[ ] Look into getting access to Fortify and other existing security tooling

There is a document here describing the coverage of Sonarcloud and making some recommendations:
https://docs.google.com/document/d/1yQTE80wLMu7-TcG32oRGwNBvEDRKTxs5RqDsOytbSPI/edit


Create CODE_OF_CONDUCT.MD

I suggest to create CODE_OF_CONDUCT.MD and copy there the Contributor Covenant v1.4. I read it and I think is good.

Note that in the file, we need to place a repo email. I believe @pejulian used his email, though we might create separate one.

I don't have access to it, but there is the CI email, that could forward to each of us, esp if we're able to add it as a send alias for ourselves. I'll make a COC and use the CI email for now, and we can discuss on the PR


Issue #1411: Fix gitignore applying rules to files in subdirectories

Not entirely sure when this was added to git but it's definitely been in for a while. Somewhere between ~1.9.3 and 2.2.1~

Found the commit message https://github.com/git/git/commit/f87f94974869b1ddd579d4c6aaff12a5f86ca26e. Seems to have been in since forever.

Since this has the potential to disrupt some projects (since previously-ignored files could be inadvertently committed), I think I may wait until after the next stable release to merge this. Not major enough to warrant a full version bump or anything, but I am thinking it might be best to wait until the next minor version...

I might merge this in and bump the minor version since there's now a dozen or so smallish changes... what do you think?

Sounds good. We don't really have any PRs or issues that would warrant a minor version bump so no need to wait I guess. Except for the composer one and that's for 5.0.0

Also the automagic installation of vagrant plugins might justify a minor bump.

Yeah, I'm thinking the next release will be a minor bump—a lot of small things that together could cause at least one breaking change in more complex scenarios.


Gamemode doesnt update on world change

Changing from world1 which is survival, to world2 which is creative does not update gamemode at all.  I have tried setting the gamerule forceGamemode to true globally and on each world, and also have the gamemode set correctly on each world.

There's a permission node that overrides this behavior. pjw.override.gamemode. Make sure your not testing with an OP or admin

Ah, yep that is working now, didn't see that permission thanks


add two-sample, no-.bed-file mode

Coverage increased (+0.4%) to 85.861% when pulling 6a325a5eff124f849be19241a848fedf73e7c25c on ryan-williams:ts into d7ea5c066ed5705984fdfdfae016480f76836ee2 on hammerlab:master.


JOSS review: (OPTIONAL DEVELOPMENT!) Add parallel processing to speed up get_sites()?

The get_sites() function is used to derive site specific info. It seems to call an API function. It can take very long to get multiple sites at once especially if the user provides an age filter.
Authors can consider just adding a parallelization here since this is just a fetch function. This could be as simple as below,
`  library(parallel)
library(data.table)
#create cores and save to a cluster object
list_of_sites <- c(A,B,C)
parLapply(cluster,
list_of_sites)->processed_sites
processed_sites <- rbindlist(processed sites)
`
Above is a crude example, but can work well. Again just an optional suggestion
https://github.com/openjournals/joss-reviews/issues/5561

With respect to parallelization, this is a great suggestion, however, at present the R package depends on a while loop to parse through the set of results (based on paging through offset/limit values).
Because of this, we send off smaller calls to get_sites() requesting 50 sites at a time until a result-set comes in empty (the case when the offset > the result set).
The Neotoma API does not, at present, provide a method for understanding the size of the result set, and so there's not a simple way to solve this problem across the set of queries passed to the API servers.
My sense is that there are ways around this (possibly using the future package?) but at present I don't think there's a simple solution.
That said, it might be easier to do this for the build_sites() methods (for example), and we'll look into it, but I'd like to put this option beyond the scope of the current review for JOSS.


add isotope

For some reason, Travis CI is saying that the build passed (#5237 passed) but above it states Some checks haven’t completed yet.

Let's give it another chance :smile:

Thanks @Michaelt293, proofed that one locally and it all checked out. Merged!


Update for 5 years worth of commits

There has been over 1000 commits since we originally pulled this project, this merge request gets us back up to date with latest.

Any news about this PR? Why is it still open?

The previous owner no longer works with GE :( I tried to contact the team in charge of ge github and they said we need permission from the owners of the repo we want to push to.... but he's gone!  They haven't gotten back to me since August 7

Hey @michaelneas, can you reopen - I’ll merge.
Sorry, I dont really know what this org is for TBH but I’m an owner so should’ve responded...
Sorry X a zillion

Ok, I reopened, NP

Cool, thanks!


Adapters OEIS, and CHMOD updated

cmd.py

fixed oeis topic string shortening

chmod.sh

syntax checking
Specials: gid, uid, sticky
cleaner if statements

oeis.sh

helper functions for cleaner code
language parameter
max terms of sequence variable

It looks great! Just one minor thing:
$ curl cht.sh/chmod/1777
Linux Permissions String:       rwsrwsrws
Linux Permissions Number:       1777

Special         Owner           Group           Public

Setuid     [ ]  Read    [X]     Read    [X]     Read    [X]
Setgid     [ ]  Write   [X]     Write   [X]     Write   [X]
Sticky bit [X]  Execute [X]     Execute [X]     Execute [X]

$ curl cht.sh/chmod/1776
Linux Permissions String:       rwsrwsrwS
Linux Permissions Number:       1776

Special         Owner           Group           Public

Setuid     [ ]  Read    [X]     Read    [X]     Read    [X]
Setgid     [ ]  Write   [X]     Write   [X]     Write   [X]
Sticky bit [X]  Execute [X]     Execute [X]     Execute [ ]

It must be t/Tfor the sticky bit, not s/S.
See your /tmp for example:
ls -ld /tmp | awk '{print $1}'


[FALSE-POSITIVE]

Good morning,
I am writing to you regarding the domain https://warringtonislamicassociation.org.uk/
After running a few checks we have found this domain to be flagged as malicious with yourselves.
We rana total virus URL checked and the site is marked as malicious on 15 including yourselves. We are writing to all asking them to remove or at least let us know the exact reason, so we can address the issue.
The domain in question belongs to a religious organisation representing a local mosque in Warrington and is not Malicious at all.  A week or so ago, the domain was hacked and we replaced this with a backup, removed all suspicious files, ran several malware checks with WordFence and also asked our hosting providers to scan and manually check. The domain was checked and confirmed to now be clean of any malware.
I am therefore asking if you can remove this domain from your blocked list and reinstate to normal please.
If there is any reason why you feel this cannot be done, please advise us and we will resolve the issue ASAP.
Kindest regards
Sirfraz

Closing as the targeted domains is not active anymore.
https://service-6vCiQ3O8MO.warringtonislamicassociation.org.uk was doing some phishing.


Cleanup

This just add zuauth and makes some initial cleanup.

Merging this for now, and will be creating more PRs soon.