Automerge not working for organizations with branch protection

Organizations that have added branch protections are unable to utilise Renovate's automerge feature, because GitHub is (incorrectly) blocking the renovate app account from pushing to master, including via Pull Request. The GitHub UI does not provide a way for org admins to add apps/bots as "users" with permissions, meanwhile GitHub's API ignores that the app has already been granted full "write" permissions.
Waiting for an update from GitHub here: https://platform.github.community/t/repositories-which-have-protected-branches-with-push-restrictions-have-no-ability-to-grant-push-rights-to-integrations/1376/11

yep, I was thinking about that. current workaround, for example if some is using pullapprove, to add the bot as allowed contributor.

yeah, the work around would be to stop using GitHub's direct controls on who can commit and instead use a third party status check like that. Hopefully they fix soon though!

I updated Renovate's detection of GitHub branch protections yesterday, it now accurate determines if any of these settings are enabled and blocking automerge:

Branch protection: PR Reviews are required before merging
Branch protection: Pushing to branch is restricted

The second one is what the topic of this issue is about. This is where an organization has configured allowed users or teams who can push to master. Because the Renovate App is not a "real" user, GitHub don't currently provide a way to add it to the allowed users list, or to any team.
The ultimate solution is for GitHub to update the UI and backend so allow you to specify Apps in that field and not just users and teams. But they've known about this for nearly a year and still not fixed it, which is not a good sign.
I am considering an option for the app which would allow organisations to add the "real" GitHub user @renovate-bot with master push rights in case you want to have (a) branch push protections, and (b) Renovate still able to do its job. That way the app would use its app permissions for everything else like it does today, but fall back to using @renovate-bot's permissions whenever it needs to merge.

Is this an issue where the branch is simply a "protected branch"?  Or that and when "Restrict who can push to this branch" is checked?

There are a few ways you can protect a branch and each has a different effect. When you limit who can merge to master then that’s a showstopper for Renovate and any other app because GitHub provide no way for you to add a “bot” to that list. The rest (eg required status checks, review approvals, etc) are not showstoppers but may hold up automerge until they pass.

So if "Require status checks to pass before merging" is the only one checked, once all statuses pass it should automerge?  Are there logs that show why auto merge may not be working?

Yes it should automerge, but right now it’s not triggered by webhooks (ie won’t happen immediately after it goes green), so it should get picked up and automerged on the next hourly cycle. Log in to https://renovatebot.com/dashboard to check the logs

From: Steven Zeck<EMAIL_ADDRESS>Sent: Tuesday, July 10, 2018 7:18 PM
To: renovatebot/renovate
Cc: Rhys Arkins; Author
Subject: Re: [renovatebot/renovate] Automerge not working for GitHub organizations with branch protection (Pushing to branch is restricted) (#846)
So if "Require status checks to pass before merging" is the only one checked, once all statuses pass it should automerge? Are there logs that show why auto merge may not be working?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/renovatebot/renovate/issues/846#issuecomment-403900428, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGBPaOPiimAS_r3h5yUPxkdeDMvn_PyFks5uFOH2gaJpZM4Pm0Hj.

Thanks @rarkins!

To confirm, we use renovate with private repos with protected branches. Specifically, our branches require reviews and all status checks to pass. As @rarkins stated, automerge only happens after these checks pass and on the next renovate check-in, but it does work. I'll approve PRs during the day, and they'll merge themselves during the night. 👍

I am considering an option for the app which would allow organisations to add the "real" GitHub user @renovate-bot with master push rights

Just curious if this work happened or not. If so, I'm assuming the procedure in get this enabled if so would be either

Go into any single repo
Go into the branch protection settings and enable Restrict who can push to matching branches
Go into Collaborators & teams and add @renovate-bot as an Admin (would write level permission work here as well)?
Or if in a organization setup
Go to the organization
Add @renovate-bot with admin access

@k2snowman69 I have not added this logic yet because I was really hoping GitHub would fix this feature to allow bots to also merge.
FYI, @renovate[bot] is a pseudo-account that the app normally runs as. @renovate-bot is a "real" user account that I registered separately.

Hey @rarkins, have you heard more from Github re treating bots like normal users, so we can resolve that issue with automerge and protected banches?
.. thinking if there's any third-party solution around that would pull repos + prs, and automerge based on some rules. If not, I might have to craft one while GH is fixing the thing.

@runk unfortunately not. For some reason they seem to have put it in the “too hard” basket and with no communication updates (the latter is typical of GitHub though, they tend not to forecast product updates big or small).
I think the only solutions are:

some self-hosted bot for merging using a real user account
enhance Renovate to accept an encrypted user token (like we do with npm tokens) that is used only for the automerge step

Renovate already has compatibility with https://github.com/bors-ng/bors-ng if you’re interested in the first option. In that case Renovate would add a special merge comment/command instead of actually automerging. The bors bot - running as a real user - would then do the actual merging to master.

@rarkins
I would like:

renovate is able to merge only to some selected branches e.g. develop
renovate is able to merge without any approval even if a given repo requires at least one more approvals
renovate isn't able to push to other protected branches e.g. master

ideally for a given organization the first PR for a given version e.g<EMAIL_ADDRESS>should require an approval and if another PR (in a different repo) has all the versions previously approved, it should be automerged

@piotr-s-brainhub your requests/ideas aren't relevant to this issue and mostly achievable today, so please ask them in the config-help repo and I'll answer you there.

Could Renovate approve the PR through the API? We recently enabled this and I immediately felt the pain that automerge doesn't work anymore :/

@tunnckoCore do you know a free alternative to pullapprove?

@felixfbecker on GitHub, neither a user nor app can approves its own PRs to get around the limitation, but I do also run Renovate Approve and it might do what you want?

FYI it will only approve PRs that are created by Renovate and which have automerge enabled.

awesome, exactly what I need.

Sweeeet, that new bot sounds fantastic.

not working at all

👋 If you have push restrictions enabled on your protected branch you can now allow installed apps to push from the branch protection settings page:

https://developer.github.com/changes/2019-09-05-apps-protected-branches-api/

@feelepxyz that's great news - extra nice of you to even take a custom screenshot 😆
After ~2 years, this issue can now be closed!

@rarkins yeah it's been a long time coming! 🙌😁

I include Renovate app in the settings shown above but still the automerge could not work.
I enabled required reviews (which renovate-approve already handles pretty good) and required status check (it passed). So I don't really know where it could go wrong.
@feelepxyz can yours work after this configuration? Could you please share your other branch settings to help me identify the issue? Thanks!

@robertying ah it's probably going to be that the merge is attempted before the approval happens which will block the merge even if the app is added to the list of allowed users (setting both push restrictions and required reviewers will cause this issue).
Not sure if it's possible but I think there needs to be a second merge attempt from the renovate-approve bot.

@feelepxyz I checked the logs from renovate dashboard and there was an attempt after the pull request approval.
I guess I'll have to open another issue to better address my problem. Thanks for responding!

@robertying do you see the error from the GitHub API in the logs? Also, try disabling Require status checks to pass before merging and see if that works. Would be helpful to narrow down where it's failing.

Hmmm. Why I don't see that option in the settings of a repository? :thinking:


added #search(a_string) to Tree instance

I find this handy for the kinds of data manipulations that I'm doing with tree structures.
Dewayne
o-*

Coverage increased (+0.002%) to 99.574% when pulling 1d3dbc29d12bcd02ff69eb4ac686bee5e07439b2 on MadBomber:search-for-string-return-array-or-paths into 3826ab7965162334dbb2a3bcfc18b7998b825399 on marcelotto:master.

Coverage increased (+0.002%) to 99.574% when pulling d5e31951aefc95cdbb83ded84abbcd2e3c6f95e0 on MadBomber:search-for-string-return-array-or-paths into 3826ab7965162334dbb2a3bcfc18b7998b825399 on marcelotto:master.

Thanks for your contribution, but I found a string-based search too special and wanted a more generic Tree#search.


add staticfast.com

add staticfast.com

@tonyspiro looks like the index page is never updated: https://www.staticwebsitehosting.org/
staticfast.com did not show.

@dilab it may be a cache issue. Try a hard page refresh.


import_realm: Fix stream rendered_description not being set while importing a realm.

While importing a realm, the stream dictionaries in data['zerver_stream']
already contains the field named rendered_description, which is set to
"". This lead the code to assume that the stream rendered_description
was already set, due to which, it was not setting the rendered_description
field for any stream.

Merged, thanks @garg3133!


Remove Trainium from blog

Needs testing before being posted. Was removed from 1.6 branch. Now pulling from main.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi @krhoyt, there is a broken link on the blog page [Kubeflow on AWS documentation](http://localhost:1313/kubeflow-manifests/main/docs/deployment/prerequisites/). goes to localhost. Can you please fix it?

Needs testing before being posted
what do you mean by this?

Link fixed. Not sure what I meant by "testing." I was probably thinking that I was updating the component guide. I test this page on a local build of the website before the PR.

Do you mind sending the bug fix to 1.6 release branch? Thanks


instalation problems

Hey there!
I got multi of errors during installation proces. Its all sql errors. I was trying to install it manully, but got the same or similiar errors.
PHP version on server is 5.6 +

Give the SQL file in 2405cbc770179b6228d457a76b012beda4cbb414 a try for me, please.


Does this plugin have a full client-side capabilities for push notification ?

@robertarnesson  Looking for alternative to https://github.com/phonegap/phonegap-plugin-push since it both plugins conflict. Does it work like plugin phonegap-plugin-push im terms of features ?

It covers ?

Sending Upstream
Device Group Messaging
Topic Messaging
Receive Messages
Receive Messages

It supports all of those except upstream messaging

@robertarnesson does any idea when to support upstream messaging?


Private window Firefox + Google External login => "No matching state found in storage"

When I try to login with Google External login in a private Firefox window, I get the error "No matching state found in storage" after redirecting to /callback in my app.
This error won't show up when logging in using local login in a Private window in Firefox.
Error occurs in processSigninResponse function.
Packages:
IdentityServer3 + oidc-client 1.4.1

dup: FF in private mode blocks storage.

Hello @brockallen Why does local login in FF private mode work with storage?

Local mean localhost?

I mean logging in with username/password in identityserver.

@brockallen Can you reproduce this? Firefox version: 68.0.2 (64-bits)

@brockallen Local I mean implicit flow.

I have the same issue.
Cannot log in using private window in Firefox with Okta.
But everything works fine when logging in using username/password.

@1Jesper1, I am using Kubernetes that is why i have one domain for both client application and identity server application. In this case logging in with local user account works fine but when i try to log in using external provider i get "No matching state found in storage" error.
But if i run my client application locally i will not be able to log in using either local user account and external identity provider.
Official sample in this repository does not work even for local user account for the same reason.
@brockallen, Any updates on this issue?

Same thing with private window and fresh signin.
I wasn't able to reproduce the issue with devtools open.
But with closed devtools and fresh private window created I can reproduce it often. But not always.
My best guess is that time spent on login page where you enter login/password is crucial. If it's more than few seconds that it seems that localStorage cleans up. So when you redirected back with auth token oidc-client tries to check if localStorage has previously saved identifier and found nothing.. and fails.

To workaround this issue we now always use CookieStore implementation for stateStore. Maybe this might be a good default for the whole oidc client library

To workaround this issue we now always use CookieStore implementation for stateStore. Maybe this might be a good default for the whole oidc client library

Personally I think the cookie store is a bad idea. You're exposing the access token to the server, which is beyond the context in which is is intended to be used.

Personally I think the cookie store is a bad idea. You're exposing the access token to the server, which is beyond the context in which is is intended to be used.

Personally I think the cookie store is a bad idea. You're exposing the access token to the server, which is beyond the context in which is is intended to be used.

You mean to the server that serves the web application? Yep, that happens for first request (or number of few requests) before oidc library handles the token and cleans up cookie. Agree that in a perfect world that should not happen. Seems like firefox developers are not heading to the perfect world as fast as we might want them to :)

Personally I think the cookie store is a bad idea. You're exposing the access token to the server, which is beyond the context in which is is intended to be used.

You mean to the server that serves the web application? Yep, that happens for first request (or number of few requests) before oidc library handles the token and cleans up cookie. Agree that in a perfect world that should not happen. Seems like firefox developers are not heading to the perfect world as fast as we might want them to :)

You mean to the server that serves the web application? Yep, that happens for first request (or number of few requests) before oidc library handles the token and cleans up cookie.

I just mean this depends on your architecture, but imagine loggers that log all headers -- now you have plain text access tokens in your server logs. This is not ideal.

You mean to the server that serves the web application? Yep, that happens for first request (or number of few requests) before oidc library handles the token and cleans up cookie.

I just mean this depends on your architecture, but imagine loggers that log all headers -- now you have plain text access tokens in your server logs. This is not ideal.

I'm closing because given the recent browser changes, the recommended architecture is to move to the BFF pattern and stop doing the OIDC protocol from the SPA.
https://leastprivilege.com/2019/01/18/an-alternative-way-to-secure-spas-with-asp-net-core-openid-connect-oauth-2-0-and-proxykit/

I'm closing because given the recent browser changes, the recommended architecture is to move to the BFF pattern and stop doing the OIDC protocol from the SPA.
https://leastprivilege.com/2019/01/18/an-alternative-way-to-secure-spas-with-asp-net-core-openid-connect-oauth-2-0-and-proxykit/


[BUG] agent compilation failure

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

DeepFlow Component
Agent
What you expected to happen
I had built agent by using ghcr.io/deepflowio/rust-build:1.18 image.
It report error as:
fatal: unable to access 'https://github.com/deepflowio/kube/': Encountered end of file
error: failed to load source for dependency `kube`

Caused by:
  Unable to update https://github.com/deepflowio/kube?tag=0.74.2#c423734b

Caused by:
  failed to clone into: /usr/local/cargo/git/db/kube-99f2e03428bc698e

Caused by:
  process didn't exit successfully: `git fetch --force --update-head-ok 'https://github.com/deepflowio/kube' '+refs/tags/0.74.2:refs/remotes/origin/tags/0.74.2'` (exit status: 128)

How to reproduce
Maybe should add ENV CARGO_HTTP_CHECK_REVOKE false in dockerfile.
DeepFlow version
v6.2.6
DeepFlow agent list
N/A
Kubernetes CNI
N/A
Operation-System/Kernel version
N/A
Anything else
N/A
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Can you provide details of what this variable does?

Can you provide details of what this variable does?

This error appears in windows while using crates. Plz check this issue:  https://github.com/rust-lang/cargo/issues/7096

OK, my suggestion is to compile the document and update it, stating that the environment variable is required in the wsl scenario, passing it in as --build-arg, can you propose PR to update the document?


Migrate getRelatedReferences to new signatures

Provides a cleaned up version of feature/relatedReferencesRefactor, this should only be merged after https://github.com/OpenAssetIO/OpenAssetIO/pull/951.
Diff to the current feature branch here.
Closes #42

@elliotcmorris @feltech I've updated the last commit, as we can't drop the manual OpenAssetIO build until a13 is released. What do you think?


mock LookupIP to speedup nodecontroller_test on some runtimes

Fixes #4995
/cc @ddysher

LGTM

I missed the boat on this one, but I would have made a function field on NodeController that matches the net.LookupIP signature. Then you could inject net.Lookup or a test-method-scoped mock at runtime rather than manipulating package globals.

@ironcladlou that is a better solution. I'll do a second take.


RouteValueDictionary value constructor fails with reflection errors

When instantiating a RouteValueDictionary with a list of constraints, I got an exception stating the Comparer property IOrdinalConstraint needed to be of type string or IRouteConstraint.
This code fixed the issue
var constraints = new RouteValueDictionary();

foreach (var kv in route.Constraints)
{
  constraints[kv.Key] = kv.Value;
}

instead of
var constraints = new RouteValueDictionary(route.Contraints);

I think that it happens when the constructor is called twice in a raw on constraints. In my case I did it on the result of a call to MapAreaRoute which does that already.

route.Constraints isn't a RouteValueDictionary (and isn't supposed to be). Unfortunately generics making doing a conversion in all of the possible cases expensive and this is a super hot code path in views.

More context, I am trying to alter the template of an existing route, I do so by creating a new route and trying to copy every property:
var prefixedRoute = new Route(
                    _routeBuilder.DefaultHandler,
                    route.Name,
                    routePrefix + route.RouteTemplate,
                    route.Defaults,
                    route.Constraints, // it takes an IDictionary<string, object> but is an IDictionary<string, IRouteConstraint> in the existing route
                    route.DataTokens,
                    _inlineConstraintResolver);

Maybe there are no issues with the current code and it's just that trying to use a RouteValueDictionary constructor to convert it to an IDicionaty<string, object> which is wrong. What is the recommended way to pass constraints across routes ?

Will just create a new Dictionary<string, object> from the IDictionary<string, IRouteConstraint> of the original route.


[Proposal] Integrate Tally as Data Provider

Tally is a platform to manage DAOs on-chain. Integrate Tally as a Data Provider will enable to create new Data Groups from governance voters, delegators and proposers.
Specifications
Here is the interface-schema.json that represents the specifications of the Data Provider:
 {
  "name": "Tally",
  "iconUrl": "",
  "providerClassName": "TallyProvider",
  "functions": [
    {
      "name": "Get voters of proposal",
      "functionName": "getProposalVoters",
      "countFunctionName": "getProposalVotersCount",
      "description": "Returns all voters of a specific proposal on Tally.",
      "args": [
         {
          "name": "DAO",
          "argName": "governance",
          "type": "string",
          "example": "aave",
          "description": "A specific DAO"
        },
        {
          "name": "proposal ID",
          "argName": "proposalId",
          "type": "number",
          "example": "193",
          "description": "A specific proposal identifier"
        }
      ]
    },
    {
      "name": "Get voters of a DAO",
      "functionName": "getGovernanceVoters",
      "countFunctionName": "getGovernanceVotersCount",
      "description": "Returns all voters of a specific governance on Tally. The values of the accounts correspond to their number of votes.",
      "args": [
        {
          "name": "DAO",
          "argName": "governance",
          "type": "string",
          "example": "aave",
          "description": "A specific DAO"
        }
      ]
    },
    {
      "name": "Get delegates of a DAO",
      "functionName": "getGovernanceDelegates",
      "countFunctionName": "getGovernanceDelegatesCount",
      "description": "Returns all delegates of a specific governance. The values of the accounts correspond to their number of votes.",
      "args": [
        {
          "name": "DAO",
          "argName": "governance",
          "type": "string",
          "example": "aave",
          "description": "A specific DAO"
        }
      ]
    },
    {
      "name": "Get proposers of a DAO",
      "functionName": "getGovernanceProposers",
      "countFunctionName": "getGovernanceProposersCount",
      "description": "Returns all proposals proposers of a specific DAO on Tally. The values of the accounts correspond to their number of proposal proposed.",
      "args": [
        {
          "name": "DAO",
          "argName": "governance",
          "type": "string",
          "example": "aave",
          "description": "A specific DAO"
        }
      ]
    },
  ]
}

Tips on how to integrate the Data Provider
The easiest way to integrate Tally is to use their API:
➡ Tally general documentation: https://docs.tally.xyz/
➡ Tally API documentation: https://apidocs.tally.xyz/
You will need an API key to make the requests, get one here: https://docs.tally.xyz/tally-api/welcome#get-an-api-key
Test easily your queries with https://api.tally.xyz/playground
See the Sismo documentation to understand what a Data Provider is, and the tutorial to learn how to create one.
Please don’t hesitate to ping the team in this GitHub issue if you have any questions.
You can also contact us on Telegram or Discord.
Have fun!

@MartinGbz  taking this up


iPhone Apps freeze up every once in a while.

What’s up? My iPhone XS Max iOS 13.3 on Unc0ver 4.0.2 occasionally the apps will freeze and will be unusable, but I’m able to go back to the springboard and slide down the control center, spotlight, and today view. In order for the apps to work again, I would have to respring, I have the power module tweak in the control center to do that. I end up having to do this about every 30 minutes. What is going on?? Appreciate any help.

I had the same problem with unc0ver 4.0.2. Upgrading to the latest unc0ver seems to fix this issue. Also, in the future, please fill out the bug template.


Set the markdown wkwebview cant be zoomed

solution: https://github.com/yoha/Thoughtless/commit/b0a2a7c3ae5009b9eea7cf1e064daa1e375b962f


This app does not stay minimized in-tray when X in the windows is clicked

Using 5.5.0 (deb) on Ubuntu 20.04
This app does not stay minimize in-tray when I click the close button in the window.
I hate that. It should minimize to tray and it should be de default behavior. There are no reason for a messaging app that closes itself when the user wants to hide it from their desktop. ALSO, when a new message comes, it should notify the user by default.
Otherwise, why people are using a messaging app?

if i understand the problem correctly, this is the same problem as #657 and #697 as ferdi (in my case) is still running after pressing X but there is no icon visible and reopening ferdi would open existing session and not new one

Also here, when I click on "x" the app closes, when I open it again I need to login again to app :(

Apologies for the label, I took things a little bit too personally and reacted in a way that goes against our code of conduct.

I think this is entirely personal preference: For me, when I close an application, I want it to entirely close and not run in the background.
For example, if I need to render a video in an editing software, I close all other applications so the video will render as fast as possible. I don't want Ferdi to "hide" in the tray and still consume my resources. In my case I'd use the minimize button in that case.
Please also keep in mind that keeping Ferdi active in the background is really resource-hungry: As Ferdi is a chromium-based browser it has to keep all these pages active in the background.

when I open it again I need to login again to app
Again, as Ferdi is essentially a chromium-based browser, this depends on the service and there is nothing we can do to change that. For example, WhatsApp keeps me constantly logged in - even after restarting.

@leoheck Please keep in mind that Ferdi is an open-source application maintained by the GitHub community. If you think that this is an important feature, you can implement it into the code with an optional setting and we will be happy to merge it into our project.

@vantezzen of course, I have this in mind. I also have in mind that this is a fork from Franz. Being able to add issues here does not mean users want to implement something. They can improve the app with feedback like I am doing. How many people have to see issues until someone came here to give the proper feedback?
Well, that being said here is my humble opinion.
Message apps should not close by default. They should go to the tray instead (by default). It doesn't mean you won't be able to close the app. A simple "Close App" menu right-clicking the tray icon, and/or a menu entry in the File menu, for example, could do the same.
The messaging app should stay always open since it is used to share information. Zero information is shared when people click on the X button to close it by mistake. If the user really wants to get rid of the annoyance of having to see notifications and messages, he can always close the app and/or disabling the notifications.
That being said, not having this by default is a path you want to follow, and this is Ok for me.
The issue here is, when I enable "Minimize to tray" in the settings, the app should not close when clicking the Window's X button. So, this is a bug. This isn't working well right now.

Of course feedback on the app is welcome and the project also profits from bug reports and feature requests.

Message apps should not close by default

As I already established: This is personal preference - but that is why we implement settings into our app!
In your case, it sounds like the "Minimize to tray" setting is not working as expected, making this a bug report instead of a feature request.
Looking at Ferdi's code, the problem most likely is in our method of handling the window closing:
https://github.com/getferdi/ferdi/blob/ea5a5932605894ae46cfdbc0e784eaebae380cd9/src/index.js#L248-L270
Could you please tell us your OS and Ferdi version to help investigate this bug? Also, is "Minimize Ferdi to system tray" and "Keep Ferdi in background when closing the window" enabled in your settings?

Hello @vantezzen, thank you for your comprehension. This is the info you requested.
This is the Ferdi version

I am running it on Ubuntu 20.04 with the default Window Manager
This is my current general settings

Reviewing here right now, it seems that the close button is working hiding the window and not closing it anymore. When I launch the app again my accounts remain logged in, so that is ok.
The issue seems to be changed a little bit. The app is just not going to the tray I expect, which is the app tray on the right side near the wifi, battery, and other status indicators.
The app is closed (actually running in the background), but no icon is being displayed.

Before, when I posted this issue for the first time it was different. The app didn't run in the background when closing it in the X button (with the right setting enabled) and the tray icon was there in the right side (the Ferdi mustache)
What changed? Yesterday I have enabled the Pre-Release updates in Ubuntu and a bunch of software was upgraded. If I am not wrong, maybe something has changed the previous behavior.

I am also experiencing this on Manjaro, just the other day it was working fine now the icon no longer shows up in the tray when I close the main window.


Adding implementation for readRows

Added new operation IBigtableDataClient#readRows(ReadRowsRequest) which currently return ResultScanner<Row>, with intend to delegate BigtableDataClient#readFlatRow for vaneer client.
Reason for raising this PR:

FlatRow and v2.models.Row has identical fields.
Vanner client has all read operation with v2.models.Row.

Assumption: RowCell has same ordering as FlatRow.Cell.

I think it would be better to keep the FlatRow abstraction in cloud-bigtable-client and instead pas a custom RowAdapter to readRowsCallable.
This would keep the existing api stable w/o any performance loss

See here for an example implementation:
https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/DefaultRowAdapter.java

Thanks @igorbernstein2 for review. I have added FlatRowModelAdapter.java which we could use for BigtableDataClient#readRowsCallable later when BigtableDataClient vaneer client is ready.
When get a chance please have a look!!


Check on quit working/not-working depending on VIM version

OS X El Capitan, latest Syntastic build.
My .vimrc entries related to Syntastic:
set statusline+=%#warningmsg#
set statusline+=%{SyntasticStatuslineFlag()}
set statusline+=%*

let g:syntastic_always_populate_loc_list = 1
let g:syntastic_auto_loc_list = 1
let g:syntastic_check_on_open = 1
let g:syntastic_check_on_wq = 0

VIM 7.3 (El Capitan) ignores let g:syntastic_check_on_wq = 0 and always performs check on quit. Setting let g:syntastic_check_on_open = 0 disables both check on open and check on quit.
VIM 7.4 (Homebrew) ignores let g:syntastic_check_on_wq = 1 and never performs check on quit.

Not all combinations of Vim compilation options and versions allow you to use all features of syntastic.  g:syntastic_check_on_wq relies on the QuitPre autocmd, that has been added in Vim 7.3.544.  Please post the output of vim --version.
Also, please open a file in Vim, run :SyntasticInfo, and post the output.

The situation is more complicated than I assumed (neither the native, old version of Vim, nor the newest work, but I had interim version which seemed to work). Let's troubleshoot the newest:

ignores let g:syntastic_check_on_wq = 0
always performs check on quit (regardless if file changed or not)
let g:syntastic_check_on_open = 0 disables both check on open and check on quit

# vim --version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Jul  7 2016 14:56:14)
MacOS X (unix) version
Included patches: 1-1993
Compiled by Homebrew
Huge version without GUI.  Features included (+) or not (-):
+acl             +file_in_path    -mouse_sysmouse  -tag_any_white
+arabic          +find_in_path    +mouse_urxvt     -tcl
+autocmd         +float           +mouse_xterm     +termguicolors
-balloon_eval    +folding         +multi_byte      +terminfo
-browse          -footer          +multi_lang      +termresponse
++builtin_terms  +fork()          -mzscheme        +textobjects
+byte_offset     -gettext         +netbeans_intg   +timers
+channel         -hangul_input    +num64           +title
+cindent         +iconv           +packages        -toolbar
-clientserver    +insert_expand   +path_extra      +user_commands
+clipboard       +job             +perl            +vertsplit
+cmdline_compl   +jumplist        +persistent_undo +virtualedit
+cmdline_hist    +keymap          +postscript      +visual
+cmdline_info    +langmap         +printer         +visualextra
+comments        +libcall         +profile         +viminfo
+conceal         +linebreak       +python          +vreplace
+cryptv          +lispindent      -python3         +wildignore
+cscope          +listcmds        +quickfix        +wildmenu
+cursorbind      +localmap        +reltime         +windows
+cursorshape     -lua             +rightleft       +writebackup
+dialog_con      +menu            +ruby            -X11
+diff            +mksession       +scrollbind      -xfontset
+digraphs        +modify_fname    +signs           -xim
-dnd             +mouse           +smartindent     -xsmp
-ebcdic          -mouseshape      +startuptime     -xterm_clipboard
+emacs_tags      +mouse_dec       +statusline      -xterm_save
+eval            -mouse_gpm       -sun_workshop    -xpm
+ex_extra        -mouse_jsbterm   +syntax
+extra_search    +mouse_netterm   +tag_binary
+farsi           +mouse_sgr       +tag_old_static
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  fall-back for $VIM: "/usr/local/share/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H   -DMACOS_X_UNIX  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: clang   -L. -fstack-protector -L/usr/local/lib -L/usr/local/opt/libyaml/lib -L/usr/local/opt/openssl/lib -L/usr/local/opt/readline/lib  -L/usr/local/lib -o vim        -lncurses -liconv -framework Cocoa   -mmacosx-version-min=10.11 -fstack-protector-strong -L/usr/local/lib  -L/usr/local/Cellar/perl/5.24.0_1/lib/perl5/5.24.0/darwin-thread-multi-2level/CORE -lperl -lm -lutil -lc -F/usr/local/Cellar/python/2.7.12/Frameworks -framework Python   -lruby.2.3.0 -lobjc -L/usr/local/Cellar/ruby/2.3.1/lib

:SyntasticInfo
Syntastic version: 3.7.0-162 (Vim 703, Darwin)
Info for filetype:
Global mode: active
Filetype  is active
The current file will be checked automatically
Available checkers: -
Currently enabled checkers: -
The current file will not be checked (file not readable / not local)

Let's troubleshoot the newest first:

Ok, please make sure you're using only Vim 7.4.1993 and the latest (unmodified) version of syntastic.  Disable all other plugins (f.i. move them elsewhere), and add this line to your vimrc:
let check_on_open = 1
let g:syntastic_debug = 9

Then open a file that should be checked and has at least one problem reported by syntastic, run :mes, and post the output.

My .vimrc:
execute pathogen#infect()

syntax on

set statusline+=%#warningmsg#
set statusline+=%{SyntasticStatuslineFlag()}
set statusline+=%*

let g:syntastic_always_populate_loc_list = 1
let g:syntastic_auto_loc_list = 1
let g:syntastic_check_on_open = 1
let g:syntastic_check_on_wq = 0

let check_on_open = 1
let g:syntastic_debug = 9

My test.sh:
echo `whoami`

When running vi test.sh:
syntastic: 0.063154: getLocList: checker sh/shellcheck run in 0.021749s
syntastic: 0.065927: autocmd: BufEnter, buffer 1 = 'test.sh', &buftype = ''
Press ENTER or type command to continue

Shellcheck was run on quitting Vim, after vi test.sh then Enter (to confirm above) + :q (immediately, i.e. without making change to the file).

Tangential
I managed to get the version of the Vim on which Syntastic behaved differently to Vim 7.4.1993.
# /usr/local/Cellar/vim/7.4.1967/bin/vim --version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Jun 30 2016 15:56:05)
MacOS X (unix) version
Included patches: 1-1967
Compiled by Homebrew
Huge version without GUI.  Features included (+) or not (-):
+acl             +farsi           +mouse_netterm   +tag_binary
+arabic          +file_in_path    +mouse_sgr       +tag_old_static
+autocmd         +find_in_path    -mouse_sysmouse  -tag_any_white
-balloon_eval    +float           +mouse_urxvt     -tcl
-browse          +folding         +mouse_xterm     +termguicolors
++builtin_terms  -footer          +multi_byte      +terminfo
+byte_offset     +fork()          +multi_lang      +termresponse
+channel         -gettext         -mzscheme        +textobjects
+cindent         -hangul_input    +netbeans_intg   +timers
-clientserver    +iconv           +packages        +title
+clipboard       +insert_expand   +path_extra      -toolbar
+cmdline_compl   +job             +perl            +user_commands
+cmdline_hist    +jumplist        +persistent_undo +vertsplit
+cmdline_info    +keymap          +postscript      +virtualedit
+comments        +langmap         +printer         +visual
+conceal         +libcall         +profile         +visualextra
+cryptv          +linebreak       +python          +viminfo
+cscope          +lispindent      -python3         +vreplace
+cursorbind      +listcmds        +quickfix        +wildignore
+cursorshape     +localmap        +reltime         +wildmenu
+dialog_con      -lua             +rightleft       +windows
+diff            +menu            +ruby            +writebackup
+digraphs        +mksession       +scrollbind      -X11
-dnd             +modify_fname    +signs           -xfontset
-ebcdic          +mouse           +smartindent     -xim
+emacs_tags      -mouseshape      +startuptime     -xsmp
+eval            +mouse_dec       +statusline      -xterm_clipboard
+ex_extra        -mouse_gpm       -sun_workshop    -xterm_save
+extra_search    -mouse_jsbterm   +syntax          -xpm
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  fall-back for $VIM: "/usr/local/share/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H   -DMACOS_X_UNIX  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: clang   -L. -fstack-protector -L/usr/local/lib -L/usr/local/opt/libyaml/lib -L/usr/local/opt/openssl/lib -L/usr/local/opt/readline/lib  -L/usr/local/lib -o vim        -lncurses -liconv -framework Cocoa   -mmacosx-version-min=10.11 -fstack-protector-strong -L/usr/local/lib  -L/usr/local/Cellar/perl/5.24.0_1/lib/perl5/5.24.0/darwin-thread-multi-2level/CORE -lperl -lm -lutil -lc -F/usr/local/Cellar/python/2.7.12/Frameworks -framework Python   -lruby.2.3.0 -lobjc -L/usr/local/Cellar/ruby/2.3.1/lib

With this version the check-on-quit did not happen (however I have not checked if it did when the file was modified). I will try to reinstall this version and test later.

Please use a single version of Vim.  For Vim 7.4, it should make a difference if you're using 7.4.1639 or earlier, or 7.4.1640 or newer.  Other variations shouldn't be relevant to syntastic.
Please try again with this configuration:
execute pathogen#infect()

syntax on

set statusline+=%#warningmsg#
set statusline+=%{SyntasticStatuslineFlag()}
set statusline+=%*

let g:syntastic_always_populate_loc_list = 1
let g:syntastic_auto_loc_list = 1
let g:syntastic_check_on_open = 1
let g:syntastic_check_on_wq = 0

let g:syntastic_sh_checkers = ['shellcheck']

let g:syntastic_debug _file = '~/syntastic.log'
let g:syntastic_debug = 9

Open the test file, then quit it with :wq.  This will create a log file ~/syntastic.log, please post its contents.  Then repeat for the other combinations of check_on_open and check_on_wq.

Frankly speaking I am losing interest in further exploring this case. The versions and their behaviour differ, but as long as the check-on-quit happens, it's more productive to actually improve the quality of the scripts to prevent Syntastic from complaining rather than disabling it.
I've learnt a lot about Vim debugging though, so I appreciate your help.
If you feel there is a need to troubleshoot that, I would be happy to assist (with a lower priority though). Please let me know.

@techraf The relevant part of the code hasn't changed in syntastic in a long time, and on the other hand there are other reports at vi.stackexchange about people missing quit events in various contexts.  Personally I can't reproduce any of these, and I have no useful data to even hint at what to look for.  Maybe the problem will be found to be in Vim eventually, or perhaps somebody will come up with a more revealing way to reproduce the problem.  It's ok with me to close this for now.


doc: update title of "new bot" dialog

Description
As an experiment to refine texts in Composer UI.

For the new bot project form:
Create a bot project
Specify a name, description, and location for your new bot project.

For the new dialog form:
Create a dialog
Specify a name and description for your new dialog.

Task Item
closes #3952
Screenshots
e2e test in a draft PR:

LGTM, @liweitian can you help check this DEFINE_CONVERSATION_OBJECTIVE is used elsewhere, should we just remove it?

Coverage remained the same at 56.73% when pulling 983107f605aaa89ba764d38eee372f84d5d07395 on zxyanliu/title-text/20200904 into 664addceb0d5acd5a7684ffc19afab16440a79a8 on main.

LGTM, @liweitian can you help check this DEFINE_CONVERSATION_OBJECTIVE is used elsewhere, should we just remove it?

remove it should be fine. @zxyanliu @boydc2014

I reverted the commit to remove DEFINE_CONVERSATION_OBJECTIVE.
Let's not remove it for now.

@zxyanliu will this close #3952?

@zxyanliu will this close #3952?

@a-b-r-o-w-n Yes. Thanks!

@zxyanliu check out https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue


Approx 200MB individual file upload limit

Hi,
Thanks for a great piece of software. Just what I need!
I've got a system running Debian 9.5.0 amd64.
I've loaded https://deb.nodesource.com/setup_6.x since this seemed to be the only one able to run both "1.0.6", "master" and "stable".
With a 300MB file, I get "Oh my... something went wrong" and an [object Object] displayed on the screen under the 0.3GB label. A 200MB files goes in just fine.
Any ideas what I'm doing wrong please?

scamhaji found a default file limit in node_modules/formidable/lib/incoming_form.js line 28:
this.maxFileSize = opts.maxFileSize || 200 * 1024 * 1024;
It seems to me that opts.maxFileSize isn't being set so the default 200MB limit is enforced.
See this.
Any suggestions on how to go about debugging npm stuff?

Edit node_modules/formidable/lib/incoming_form.js
Add a zero to this:
this.maxFileSize = opts.maxFileSize || 2000 * 1024 * 1024;
This fixed the issue with 1G limit.

where is that file located i have install it using docker pull.


hyperglass-agent: TLS files requires even if ssl is disabled

Bug Description

Hi, I assumed that if I disable TLS, no TLS certificate / private key are required. But that's not the case.
Expected behavior
given this config:
---
debug: true
listen_address: <IP_ADDRESS>
mode: bird
secret: NCzYFKOdzSrCEJnV8NWH
ssl:
  enable: false

I assume hyperglass would start without the files, but it fails
Steps to Reproduce
start with the config from above
Local Configurations

Logs

output:
$ hyperglass-agent start
❌ Failed to start web server: 2 validation errors for Ssl
cert
  /opt/hyperglass/hyperglass-agent/hyperglass-agent/agent_cert.pem does not exist. (type=value_error)
key
  /opt/hyperglass/hyperglass-agent/hyperglass-agent/agent_key.pem does not exist. (type=value_error)

Simply creating empty files is a workaround that works:
✅ Starting hyperglass agent web server on http://<IP_ADDRESS>:8080 🚀

INFO:     Started server process [8957]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:8080 (Press CTRL+C to quit)

Possible Solution

only enforce the presence of the files if TLS is enabled
Environment
Server
Latest hyperglass-agent from pypi on CentOS 7 / Python 3.6

Closing, see #143


Upgrade org.apache.maven.plugins:maven-dependency-plugin 3.4.0 -> 3.5.0

This PR contains the following updates:

Package
Type
Update
Change

org.apache.maven.plugins:maven-dependency-plugin
build
minor
3.4.0 -> 3.5.0

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade maven-dependency-plugin 3.4.0 -> 3.5.0

See https://github.com/apache/maven-dependency-plugin/compare/maven-dependency-plugin-3.4.0...maven-dependency-plugin-3.5.0


Provide opinionated PaaS/serverless functions for getting started

Provide a single function that takes an argument of a router, gh, etc. and then is opinionated otherwise to let people get started on:

[ ] Azure Functions (based on pvscbot
[ ] Heroku (based on bedevere, the-knights-who-say-ni)

Essentially take the battle-hardened entry points from those projects above and make them available to those who want the easiest way to get going on the above platforms where full control isn't necessary.

I've been moving more to GitHub Actions which makes having to host a bot less important. Plus this is probably better as a separate project(s).


[fix] Manipulate to ignore rejected

Motivation for changes:
Currently manipulate processes rejected entries, which is problematic. I don't understand the reason for this.
For example, I want to use manipulate to replace title with imdb_name.  Some entries don't have valid imdb metadata, which causes manipulate to crash when trying to set title to None.  This could be solved by using required_field: imdb_name and setting plugin_priority for manipulate to lower than required_field but it doesn't work because manupulate will process rejected entries also. This causes the task to crash.
Detailed changes:
set manipulate to ignore rejected entries

mixed up with a previous commit, will submit again


Add support for reduced_redundancy config parameter

Coverage increased (+0.2%) to 98.462% when pulling 726766d6f898209f2a8fcbc3389733ec6c8aad18 on reduced-redundancy into ae245a30439f48a38431d712a72545b48ab4ffd2 on master.

Coverage increased (+0.2%) to 98.462% when pulling 726766d6f898209f2a8fcbc3389733ec6c8aad18 on reduced-redundancy into ae245a30439f48a38431d712a72545b48ab4ffd2 on master.


chore: run cargo fmt on all files

After rustc 1.76.0-nightly (a1a37735c 2023-11-23) it looks like rustfmt has changed. This PR is the result of running cargo fmt in the root. No other changes.

Turns out this was a bug where macos rustfmt behaved differently from linux. Bug https://github.com/rust-lang/rustfmt/issues/5964


Documentation for operations.md

This PR includes documentation on the operations of Pipeline Service.

/test pipeline-service-test

/lgtm

@Mo3m3n @Roming22 I have addressed all the comments. PTAL.


Various 202301 release hotfixes

Fixes (among other things): #37

Why is master in the versionIRI?

As in https://spec.industrialontologies.org/ontology/ master /202301/MetadataIOF/

As in https://spec.industrialontologies.org/ontology/ master /202301/MetadataIOF/

This is how the current publishing process works. Since you can tag any branch, we need to know which branch a given tag belongs to.

Seemed like a conflation of a VC artifact. I'll approve, maybe we can discuss later.

Changes to the changenotes for Annotation Vocabulary file are missing. Please incorporate latest updates I just emailed you.

Changes to the changenotes for Annotation Vocabulary file are missing. Please incorporate latest updates I just emailed you.

Done, I hope, in fb3c39f.
@chris-will could you verify?

Pawel, changenotes look good. I had to delete some of the old ones directly in this pull request. They were still lingering in there after you inserted the newly formatted ones.

Does "master" show up in the path of the versionIRI in the published version or the version in the GitHub repo after merging the branch? Sounds like something else that we need to talk about in the version metadata discussion in the Arch TG meeting on 2 Feb 23.

In both.
For the published version it is automatic.
For the Github version it is manual, so it can be removed.

https://github.com/iofoundry/ontology/blob/bf71e6718461365d0856f47722e182a2867b087f/core/Metadatacore.rdf#L32
should be:
 <owl:imports rdf:resource="https://spec.industrialontologies.org/ontology/core/commonstocoremapping/MappingCommonsToIOF/"/>


Some scaffolding

[Short description explaining the high-level reason for the pull request]
Changes

Testing

Notes
Checklist

[ ] PR has an informative and human-readable title (this will be pulled into the release notes)
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future TODOs are captured in comments
[ ] Project documentation has been updated if adding/changing functionality.
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Python - local testing

[ ] python 3.6
[ ] python 3.7

Another TODO -- support data quality for dataframes. Some ideas:

Add a output argument to these, allowing us to extract an item in the dataframe, etc... E.G. anything sliceable
output could also apply to a specific column in extract_columns
Add a schema argument, allowing us to run on a dataframe (E.G. column -> type mapping). Note this is redundant with datatype as well...


Css_FlexBox

Description 📜

Domain of Contribution 📊

[X ] Frontend Dev HTML/CSS/JS

/assign

/assign document

/assign document

/assign document

Is this issue still live? I'd love to contribute to this!

/assign


Code Quality: Added ToolbarButton controls

Resolved / Related Issues
Creating a bespoke control for use in Files' toolbars and address bar.  Uses our ThemedIcon control.
Ensuring @0x5bfa is ok with working on this control, and @yaira2 to keep an eye on it, as we start work on it.
This Pull Request will remain a Draft until it is ready for review and merging
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Closes #

Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

Opened Files ...
...

I recommend to resolve the conflicts and merge as this is fully separate from the production.

@0x5bfa can you please resolve the merge conflicts so we can merge this into the controls project?

Thank you


Get all collections

Hi,
I am trying to get all collection id's so that I can iterate over it.
from taxii2client.v21 import Server, Collection
taxii_server_url = "http://localhost:5000/trustgroup1/"
username = "admin"
password = "Password0"
Create a TAXII Server object
taxii_server = Server(taxii_server_url, user=username, password=password)
Get the API Root information from the TAXII server
api_root = taxii_server.title
print(api_root)
api_root = taxii_server.api_roots[0]
collection = api_root.collections[0]
#Gives Me error-:
api_root = taxii_server.api_roots[0]
IndexError: list index out of range
Am I putting the wrong URL?

Yes: you need a URL to a TAXII discovery endpoint.  The TAXII 2.1 spec says it must be /taxii2/ [1].  Try using http://localhost:5000/taxii2/.

https://docs.oasis-open.org/cti/taxii/v2.1/os/taxii-v2.1-os.html#_Toc31107526


Link to issues for index limitations

See comment: https://github.com/prisma/docs/pull/1900/files#r664933455 and https://github.com/prisma/docs/pull/1900/files#r664932762
Check if the listed limitations have matching issues in the prisma/prisma repository and link to them.

Closing this as it seems to be outdated.


Cleaned Up Codebase

Changes in this PR:

Changed information in .pptx and .docx into link accessible from markdown
Deleted unnecessary Java and xml files (see screenshots below)

approved


nsd: 4.1.12 -> 4.1.13 for CVE-2016-6173

Motivation for this change
https://lwn.net/Vulnerabilities/703325/
https://github.com/NixOS/nixpkgs/issues/19678
Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Thanks for the fix. Seems like you've been faster with the cherry-pick onto stable :+1:

:) I was impressed you merged so fast, but wasn't sure you saw the "port to stable" label. Thank you for the merge!


Unit Test changes are not applied to the current transformation when Run

When you edit a unit test within a KTR and click Run the unit test XML is updated but the transformation that runs the unit test does not execute the latest update changes. You must save the transformation first before clicking Run. This is likely because the transformation itself has not been changes so does not detect and automatically save when Run is executed.

Also applied to clearing golden and input data sets, thanks Harris.  We need to save constantly anytime something changes to a unit test.


Remove libp2p

Currently, libp2p appears to be breaking cargo audit.  Bump priority?

Also, we should consider getting rid of our I parameters and use the concrete type NodeId instead.


Building is incompatible with CMake 3.10.2

CMake 3.10.2 ships with Ubuntu 18.04 LTS.  It stops with an error message:
CMake Error in koinos_api_cpp/CMakeLists.txt:
  No known features for CXX compiler    "Clang"  version 10.0.0.

As stated here CMake version 3.10.x only supports a limited range of CMake versions with an upper limit.  This upper version limit seems to have been removed as of CMake 3.16 which is fortunately the version of CMake that ships with Ubuntu 20.04 LTS.
I'd suggest bumping cmake_minimum_required to 3.16.0 to fail quickly and cleanly if using an older CMake.
This experience suggests it may be reasonable to include CMake in the CDT instead of relying on host CMake.  Thoughts?

We are not currently making an effort to support 18.04


Sign Windows builds with Squirrel for MSI compatibility

This switches us from signing directly with the Windows SDK to using Squirrel. This is necessary as Squirrel builds both the atomsetup.exe and the atomsetup.msi (which contains atomsetup.exe) so signing atomsetup.exe ourself is too late if we want to distribute the msi.
This is a little convoluted as we currently support remote URLs for keys to enable signing keys to not be checked in which Squirrel does not support so we continue to do that in our signing step but leave the actual signing to Squirrel.

Testing

[x] Local builds continue to sign atom, update, atomsetup.exe with local test key
[x] Local builds continue to download and sign with WIN_P12KEY_URL
[x] AppVeyor builds continue to build and publish atomsetup.msi
[x] MSI now contains signed atomsetup.exe
[ ] Official builds continue to sign as before


Remove SwarmInspect method.

SwarmInspect information are redundant with Info. The API won't serve
GET /swarm anymore so removing the client method too. 👼
Related PR https://github.com/docker/docker/pull/24492
/cc @thaJeztah @icecrime @tiborvass @aluzzardi @stevvooe
🐸
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

LGTM

LGTM

Are we making a mistake by creating a compound data structures? Info is really about the node's local configuration, whereas cluster is about the configuration of the cluster.
The main issue here is that we end up with an imbalance between the object that is modified and how to read the results of that modification.

The main issue here is that we end up with an imbalance between the object that is modified and how to read the results of that modification.

Yeah, I do agree on that one, it feels a little weird to update swarm properties  via /swarm/* and getting swarm properties through /info..
Maybe we should keep swarm inspect and endpoint and just make docker info call the endpoint.

@tiborvass This is not back and forth. This is CLI decisions being used to make thoughtless changes to the API. We have a deep design problem that our API and CLI are over-coupled. I'm fine with the CLI decision. It is a good one. I just don't understand why we think that means we have to delete this endpoint on the API.
Go ahead and merge this.

Hey, side note - I think we need to be able to inspect in order to update (which we use for swarm config, such as join secret etc)


fix: nightly tests error

Fixing:
https://github.com/redpanda-data/helm-charts/actions/runs/5340625492/jobs/9680648659
because of wrong paste, and here
https://github.com/redpanda-data/helm-charts/actions/runs/5340599532/jobs/9680593348
seems to be an error with getting IPs but sill investigating.

Can you reference the CI run in the cover letter of this PR?

https://github.com/redpanda-data/helm-charts/actions/runs/5340599532/jobs/9680593348#step:16:4772
+ echo '-----> testing external tls: schema registry'
  -----> testing external tls: schema registry
  + for ip in $ip_list
  + openssl s_client -verify_return_error -prexit -CAfile /etc/tls/certs/external/ca.crt -key /etc/tls/certs/external/tls.key -connect <IP_ADDRESS>:30081
  ---
  no peer certificate available
  ---
  No client certificate CA names sent
  ---
  SSL handshake has read 0 bytes and written 0 bytes
  Verification: OK
  ---
  New, (NONE), Cipher is (NONE)
  Secure Renegotiation IS NOT supported
  No ALPN negotiated
  Early data was not sent
  Verify return code: 0 (ok)
  ---
<PHONE_NUMBER>16744:error:0200206F:system library:connect:Connection refused:crypto/bio/b_sock2.c:110:
<PHONE_NUMBER>16744:error:2008A067:BIO routines:BIO_connect:connect error:crypto/bio/b_sock2.c:111:
  connect:errno=111

The IP <IP_ADDRESS> is within the range <IP_ADDRESS>-<IP_ADDRESS> that is defined in:
apiVersion: metallb.io/v1beta1
kind: IPAddressPool

Why extending IP pool address range would solve this particular issue?


Added translation into Spanish

Added translation into spanish :)

Great thanks

I'm curiosity, is the Spanish strings.xml only for Peru?

Is for all spanish, Latín America and Europa

OK, I will remove the country code to make the strings.xml selected by all Spanish.

Ok, no problem.


[Feature] See star comments on user profile

Currently the comments that the users submit when giving a star aren't available through the app UI.
These comments should be publicly displayed on the profile of the user that received the star.

it's not giving me the option to assign to myself, so I'll comment that I'm working on this issue

it's not giving me the option to assign to myself, so I'll comment that I'm working on this issue

I invited you to the organization, check your email. You should be able to assign yourself after accepting.

feature merged into master.


Add support for various env vars depending on runtime.

I have a Remix project that is being deployed on Cloudflare Pages. For the most part, when running a local deployment, I can use a .dev.vars file, which works when running vite dev and also using wrangler to preview a deployment.
Unfortunately, it appears that lemonsqueezy.js will only pick up env vars if they are defined in a .env file, meaning we need to have duplicate env var files during development.
Clerk, for example, handles this using a utility file that supports various runtime env vars: https://github.com/clerk/javascript/blob/9c34a756efa68d430e2231547576a20a6d9e6dc0/packages/remix/src/utils/utils.ts#L45
It would be great if lemonsqueezy adopted a similar method.

Not sure what you mean, but the lemonSqueezySetup function expects an API key to be passed in as a parameter. It's up to you to decide how to retrieve it from the environment.
https://github.com/lmsqueezy/lemonsqueezy.js/blob/main/src/internal/setup/index.ts

Ah sorry, you're absolutely correct. I've been working with a few libraries today and must've gotten things muddled up; my mistake! Indeed, we're passing along the key so can call it how we please. Sorry about that!


Moved brew install option higher up

It's the simplest choice for all tech-savvy mac users, and by being so low it means most of us will just run the first complicated set of steps instead <3

Hi and thanks for the PR!
For now I'm going to close it as I think it might help some developers, however the argument for the change can be provided by composer - users as well. They might (after your change is applied) go through the trouble installing brew first and than read they can use composer :)
Thanks for using the tool and thinking about improving the documenting based on your experience, much appreciated!


websocket i/o timeout

log
2017-08-23T06:39:05.616Z        ERROR   http/wsclient.go:191 (*WSAsyncClient).connect   host_192_51_151_2: Unable to create a WebSocket connection ws://<IP_ADDRESS>:8082/ws : Authentication failed: dial tcp <IP_ADDRESS>:8082: getsockopt: connection refused
2017-08-23T06:39:06.616Z        ERROR   http/wsclient.go:191 (*WSAsyncClient).connect   host_192_51_151_2: Unable to create a WebSocket connection ws://<IP_ADDRESS>:8082/ws : Authentication failed: dial tcp <IP_ADDRESS>:8082: getsockopt: connection refused
2017-08-23T06:39:07.618Z        INFO    http/wsclient.go:220 (*WSAsyncClient).connect   host_192_51_151_2: Connected to ws://<IP_ADDRESS>:8082/ws
2017-08-23T06:39:07.618Z        INFO    agent/topology_forwarder.go:60 (*TopologyForwarder).OnNewMaster host_192_51_151_2: Using <IP_ADDRESS>:8082 as master of topology forwarder
2017-08-23T06:39:07.618Z        INFO    agent/topology_forwarder.go:42 (*TopologyForwarder).triggerResync       host_192_51_151_2: Start a re-sync for host_192_51_151_2
2017-08-23T07:10:45.339Z        ERROR   http/wsclient.go:274 (*WSAsyncClient).run       host_192_51_151_2: Error while writing to the WebSocket: write tcp <IP_ADDRESS>:37346-><IP_ADDRESS>:8082: i/o timeout
2017-08-23T07:10:45.339Z        WARN    http/master.go:97 (*WSMasterElection).OnDisconnected.func1      Lost connection to master

hard to debug without the context. has the ws_pong_timeout paremeter been tweaked ?

it's a report from XueFeng, but I wasn't able to reproduce it and didn't have more context too

I close it since there is no way to identify the issue. We will re-open it if needed

I faced this problem with a setup on DevStack. Restarting Services in following order:

systemctl restart skydive-analyzer
systemctl restart skydive-agent on every Node

fixed the problem of the visibility in Skydive itself of the Nodes, but the connection on TOR-Switch will not be restored.
journalctl can't give any information about ws_pong_timeout.


show calculated hash when comparison failed

This shows the calculated hash in the error message. It should make it easier to update dependencies since you dont have to run gradle -q calculateChecksums to calculate the new checksum.

added another commit, all mistaching chcksums are now reported instead of throwing InvalidUserDataException at the first mistach


[Request for External] Remove OnPrem from methods in "SOAP Web Service Request Mgt."

Codeunit 1290 "SOAP Web Service Request Mgt." is very useful, but unfortunately not usable in cloud environments.
Please can the Scope(OnPrem) be removed from the following three methods to fix that.
[TryFunction]
[Scope('OnPrem')]
procedure SendRequestToWebService()

[Scope('OnPrem')]
procedure GetResponseContent(var ResponseBodyInStream: InStream)

[Scope('OnPrem')]
procedure ProcessFaultResponse(SupportInfo: Text)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 15201.


Get Network EIDs error

Hello,
I have a question about an error that I can not find an answer anywhere. After performing the analyzes described in the example, I reach the last element, that is adding data to Network EIDs. In previous analyzes, no errors appear, everything goes normally only when adding data an error pops up? What could be the reason?

Did you ever resolve this issue?

I met the same problem。 I've tried many ways, but failed.

Have you tried turning off background geoprocessing so that the tool runs in the foreground?  It shouldn't make a difference unless you have the 64-bit background geoprocessing extension installed, but it's worth a try.

I've just turned off background geoprocessing button and tried to use get EID tools again, but it failed to aquire extension license too.
Could you give me a remotely help by QQ?

I never found a solution to this problem.  However, the Add GTFS to a Network Dataset toolset will be deprecated as soon as ArcGIS Pro 2.4 is released (this summer) because Pro 2.4 will natively support network analysis with public transit data.
I do not plan to address this issue, so I'm closing it.


smoke test: use caikit-nlp-client

The current version of the smoke test is broken for a couple for different reasons:

--json is not available for the curl version available on ubuntu-latest, making the http test always fail
the test for success or failure of is inverted: it uses -z (test for zero length string) instead of -n (test for non-zero length string)

The combination of these two issues made smoke-test.sh always return success.
By using caikit-nlp-client we get rid of the grpcurl and curl --json dependencies.

/lgtm


[TFLite] Added check for dynamic range quantization

This PR adds an extra check to prevent optimized with "dynamic range quantization" tflite files to be loaded as this type of Tensorflow optimization is not fully supported in TVM (the optimization creates non-quantized command with quantized weights which cannot be correctly processed now).
https://www.tensorflow.org/lite/performance/post_training_quantization#dynamic_range_quantization

@FrozenGene please, take a look

@FrozenGene please, take a look

How can we make progress here?

@comaniac

Thanks @d-smirnov @d-smirnov merged now


crashing on launch - Windows

Windows 10 Build 18363, the latest store version

Is this the insider version of quarrel?

non-insider build, just from the store

We are focusing all our efforts on the insider build right now as it is a total rewrite, as such we will not be fixing any bugs in the old version.


9660+ extra files in phpmyadmin install

Describe the bug
composer libraries in /public/phpmyadmin/vendor are bloating the phpmyadmin optional install
Branch: development
Screenshots

Steps to reproduce

Build a Gitpod workspace with INSTALL_PHPMAYADMIN=1 in starter.ini
Go to the dash board and look at that workspace. There will be around 9663

Expected behavior
Should probably be less than a couple hundred files overall for just Laravel and phpmyadmin installs.
Additional information
Probably just need to dynamically add /vendor/public/phpmyadmin to /.gitignore

will have to do a .gitignore on the entire phpmyadmin folder as there are 2500+ files in there no matter what.  Installations of the project outside of gitpod will have their own seperate set of deployment steps. Regarding github: The phpmyadmin install will exist for the life time of the workspace so that will work for development purposes

will have to do a .gitignore on the entire phpmyadmin folder as there are 2500+ files in there no matter what.  Installations of the project outside of gitpod will have their own seperate set of deployment steps. Regarding github: The phpmyadmin install will exist for the life time of the workspace so that will work for development purposes


Document how to add custom overloads

Closes #163.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.25%. Comparing base (5c4400f) to head (fee794f).
Report is 1 commits behind head on main.

:exclamation:  There is a different number of reports uploaded between BASE (5c4400f) and HEAD (fee794f). Click for more details.
HEAD has 3 uploads less than BASE

Flag
BASE (5c4400f)
HEAD (fee794f)

4
1

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #177       +/-   ##
===========================================
- Coverage   91.28%   41.25%   -50.04%
===========================================
  Files          37       36        -1
  Lines        1779     1515      -264
===========================================
- Hits         1624      625      -999
- Misses        155      890      +735

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


JacksonEnumDeterminer to handle JsonFormat.Shape.Object

What's this PR do/fix?
Handles JsonFormat.Shape.Object when used on Enums properly. to Threat them as objects instead of Enums
Are there unit tests? If not how should this be manually tested?
Yes
Any background context you want to provide?
Mabye it's a good idea to provide integration tests
What are the relevant issues?
https://github.com/springfox/springfox/issues/1818

Could you please re run the test, jcenter.bintray.com was donw for few seconds I think

Are you trying to compile it with gradle before you pushed it up? None of the tests are compiling

Also would you mind adding a contract/integration test for your use case? There seems to be no tests for that. Basically it would exercise your change in the FeatureDemostrationService and will add to the demonstrated features.

Thanks @yelhouti

Thank you :)


Quotes duplications

Proposed Changes

duplications of the quote have been removed

PreparePositions

SetPositions replaced by Scatter
Prefix Sum moved to ClArray
atLeastOneToNormalForm fun

Types of changes
What types of changes does your code introduce to GraphBLAS-sharp?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] Build and tests pass locally
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@artemgl the problem is that the ClArray.copy method is called in the PrefixSum.fs module, as a result of which calling prefixSum methods from ClArray.fs is not possible due to cyclic dependency.
The best option in my opinion is to remove the prefix sum methods in the ClArray.fs module and use them from the PrefixSum.fs module.


Fix SshV0 tasks

These tests were broken in #7052.  The folder name of the task and its corresponding tests in legacy should match.

makes sense, fyi it looks like this line in make.js is why it's busted:
        var testCopySource = path.join(__dirname, 'Tests-Legacy', 'L0', taskName);

@stephenmichaelf fyi


Consolidate and cleanup temporary artifacts on Linux

Hi!  I'm getting started with .NET Core and ASP.NET on Linux, and as a Linux user, I noticed with a minor degree of dismay how many temporary artifacts are created and left behind when compiling and running even a small demo .NET application.
Including the locations documented in Managing the global packages, cache, and temp folders, here are the ones I noticed after a simple demo build and run:
~/.dotnet/
~/.nuget/
~/.local/share/NuGet/
~/.templateengine/
/tmp/.NETCoreApp,Version=v?.?.AssesmblyAttributes.cs
/tmp/.dotnet/shm/
/tmp/CoreFxPipe_*
/tmp/NuGetScratch/lock/
/tmp/clr-debug-pipe-*-*-{in,out}
/tmp/tmp*.tmp

Some of these seem to accumulate many small leftover files over time, like all the zero-bytes files under /tmp/NuGetScratch/lock/.  The /tmp/tmp*.tmp files appear to have artifacts related to the "dotnet restore" command.
It would be truly fantastic if these could (a) be automatically cleaned up whenever possible, so as to minimize cruft leftover from builds and runs, and (b) be consolidated into just a few locations, e.g., /tmp/dotnet/ for all global temporary things, and a couple of home directory locations following the XDG Base Directory Specification like ~/.cache/dotnet/ for user-specific cached stuff and ~/.local/share/dotnet/ for user-specific data.
I should also add that I really appreciate all the documentation on getting started on Linux, and the relative ease of installation of the packages.  Thank you; it's clear a huge amount of effort has gone into making these packages cross-platform.

This repo is no longer actively monitored. Closing up old issues that have not had activity in while. If this is still an issue, please open a new issue in an appropriate repo listed in microsoft/dotnet#1275

This repo is no longer actively monitored. Closing up old issues that have not had activity in while. If this is still an issue, please open a new issue in an appropriate repo listed in microsoft/dotnet#1275


[BUG] Layout issue in footer & on  '/clubs' in cta-button in <370px size.

Description
Footer & cta-button (on:  /clubs) layout issues in screen size less than 370px.
Screenshots

Footer layout issue in <370px screen size.

cta-btn (donate) layout issue in "/clubs" route.

Browser 🥦
Google Chrome
Checklist ✅

[x] I checked and didn't find similar issue
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (blank for no).

I want to put this issue on hold as some changes related to the entire website's responsiveness are being done in #1083 , so in case something is missed we can catch up on this issue. Thanks for spending the time to raise this issue.

hey @tamalCodes,I had the changes commited in my fork since I made this issue, it could have been solved as it was small issue.

Hi @TahaHameed23 , you can make a PR for this. I closed 3-4 issues by mistake while I was trying something. My bad.
Thanks for bringing this to my notice.
Do make a PR, assigning it to you 🚀

📑 Checklist in case you missed something

Local project setup, .env for the frontend.
Contributing guidelines to be followed.

Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

No problem, & thanks for reconsidering!


Add Microsoft.CodeAnalysis.PublicApiAnalyzers

Add the Microsoft.CodeAnalysis.PublicApiAnalyzers analyzer and associated public API surface assets, including unshipped changes from #130.
Remove redundant package reference already installed by another reference.
Add explicit public constructor to HttpRequestInterceptionBuilder.
Add additional exception documentation to method.

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #132   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          14     14
  Lines        1087   1090    +3
  Branches      175    175
=====================================
+ Hits         1087   1090    +3

Impacted Files
Coverage Δ

...ientInterception/HttpRequestInterceptionBuilder.cs
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f1f66...607dc0c. Read the comment docs.

Didn't know about Microsoft.CodeAnalysis.PublicApiAnalyzers, very nice 😄

I saw this project this morning and found it while having a nose around: https://github.com/natemcmaster/LetsEncrypt


YARN-11070. Minimum resource ratio is overridden by subsequent labels

Description of PR
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Hi @9uapaw ,
Thanks for working on this.
Patch LGTM, committed to trunk.
Thanks @brumi1024for the review.


Update Go code examples to match the source code

Signed-off-by: Erdem Köse<EMAIL_ADDRESS>Code examples in the tutorials do not match the latest version of the source code. The changes in the three commits below are now reflected in the tutorials.
Besides, links to godoc.org are replaced with the current ones in pkg.go.dev since they are already redirected to pkg.go.dev.

https://github.com/rabbitmq/rabbitmq-tutorials/commit/52ca462906a6cd10e387e39074cee468f6bd2b47
https://github.com/rabbitmq/rabbitmq-tutorials/commit/bd2c06f28f88cbc4a1ef85e7adaf95743110d83a
https://github.com/rabbitmq/rabbitmq-tutorials/commit/98a3ff7c1f6a410e93533296a1f3327476cf1319

Thank you!


Does this project work with the Chart.js zoom plugin?

I am trying to add zoom functionality to my chart using the chartjs-plugin-zoom project but I haven't been able to get it working yet.
https://github.com/chartjs/chartjs-plugin-zoom
I added the chartjs-plugin-zoom and the hammerjs dependency to my project. I have the zoom property added to my chart config as well.
Just curious if anyone else has got this plugin working?

It works for me. Did you import chartjs-plugin-zoom? something like
import 'chartjs-plugin-zoom'

or
require('chartjs-plugin-zoom');

Not working for me either, the plugin is supposed to be injected by himself through npm install no ?
I tested your imports @emn178 it doesn't change anything.
@scotteby did u find something ?

Can anyone of you give a demo - repo code ?? for better explanation.

@mac10046 https://github.com/emn178/angular2-chartjs-sample

@TheSegfault  Thank you so much it's working fine to me :)


Auto-create db-path directory

I've been running several instances of goaccess to process logs for a handful of virtual hosts, generating monthly, weekly and daily reports for each.
Some of these need persistence for performance and other technical reasons (logrotate being configured to keep up to 14 days, for example).
It would be nice, to be able to specify a directory name, whose last part (the basename) doesn't exist, and goaccess would create it automatically.

Could you please elaborate how the structure should look like and which directories should goaccess automatically create? Thanks.

Well, my setup is to foreach through the list of virtualhosts that are configured, and then do something like goaccess /var/log/apache2/access_$i.log.1 --restore --persist --db-path /var/spool/goaccess/$i-$(date -d yesterday +%Y-%m)/ --output /var/www/goaccess-reports/$i-$(date -d yesterday +%Y-%m).html
Obviously /var/spool/goaccess has been set up with the correct permissoins on my system; however the rest of it is variable, so I had this idea of "whay if GoAccess would create that for me"?


userpage refers to _review

when clicking on your username (when logged in), the retrieved page causes an internal server error because of a reference to the shared/_review.ejs

This is solved in issue161


Upload - add VCS properties to a single file only when needed.

Fixes https://github.com/jfrog/jfrog-cli/issues/618


Package request: out-of-your-element

Project description
Matrix-Discord bridge with modern features.
Metadata

homepage URL: https://gitdab.com/cadence/out-of-your-element
source URL: https://gitdab.com/cadence/out-of-your-element
license: gpl3
platforms: all

Add a :+1: reaction to issues you find important.

Hi, I'm the developer, and my software most likely isn't very Nix-compatible at the moment. Having never used Nix, I'm not sure what I need to change in out-of-your-element for it to be easy to package, but let me know (or point me to a readme, wiki, or whatever) and I can try to make the necessary changes!

Usually its possible to package as long as you don't hardcode paths like /bin into your code iirc. (Even them it can be patched)

i had a quick stab at it today, and found yet another reason for hating npm tooling... Npm2nix tooling got stuck on the sharp/vips dependency. Yarn would probably beat npm in terms of nix tooling, but that is not a simple enough change to be easily done for packaging. As to nix-specific issues: If i am not mistaken, the discord token needs to be written to a config file. Can one provide paths to that config file e.g. by command line flag when starting the appservice? That would be helpful to allow actually encrypting the token properly.

https://cgit.rory.gay/nix/OOYE-module.git/
Was working on my own module for a while, might be of interest?

https://cgit.rory.gay/nix/OOYE-module.git/
Was working on my own module for a while, might be of interest?
For what it's worth, I took inspiration from the old Mjolnir module to have a pre-start script that writes the appservice registration to the bridge's own working directory. The discord token is exposed via systemd secrets.

This leads to invalid branch: master.


How to build nested tags?

Hi there,
Are there any updates on this issue?
I'm trying to build out nested tags for an image tag containing title, url, and link tags.
Would appreciate any advice/help on this matter.


Remove patronictl failover --leader option

Option has been deprecated and should be removed in the new major release

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

11 of 11 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.867%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
14223

Relevant Lines:
14242

💛  - Coveralls


switching to development branch restores default settings

expected: migrate settings

Any specific error you can show?

All kinds of odd missbehaviour. This might just be a semi-related symptom

I think you also have some issues that are you-only such as both versions loading


Optional button inside player UI to fully close/kill/destroy player

While I appreciate the mini player and full player swap and plan to actively use that feature, I think a proper close function would be nice. This could be an optional button, hidden by default if you like and be an "X" type icon all the way to the right, and an "X" in the corner of the mini player.
This would simply kill the component or do a callback to a function passed in as a prop to the player.
I know you have responded to this before, and that it's possible to simply not render the player from my own code, but that does not make it easy for me to let the user show and actively close the player. Once it's floating in one way or the other, I cannot let the user close the player from within the player, unless I do a hack with a floating close button, but that really is not optimal and having it inside the player, would be much better for usability.
I was thinking that clicking the button could be a flexible prop that defaults to destroying itself, but a function could also be passed which could be a prop passed function so I can kill it from my calling component. Hope it makes sense...

On a related note; I have attempted to ref the player in my component using various techniques, but I was somewhat unsuccessful. I could get the initial state, but was unable to keep track of updates to the player component/node such as if the player was active playing music or not, full or mini player etc. This could have helped me improve the close hack, but it would never become the same as a baked-in close button/feature anyways.

done.
see https://github.com/lijinke666/react-music-player#destory-player


Add support for resource collectors in several rules

FileEnsurePropertyIsValid => already fixed in https://github.com/iwarapter/sonar-puppet/commit/60a19efed2bba03381511bbdf1ce193802789003
NoopUsage
UserResourcePasswordNotSet
FileMode

Fixed in https://github.com/iwarapter/sonar-puppet/issues/232


Allow packages to request syslogd log socket to be created inside chr…

…oot by specifying it in /package/logging/logsocket element. Implements #4898.
Example:

/var/appname/var/run/log

This is in replacement of #1802 pull request.

Thanks @rbgarga I have adjusted everything.


Add list test; implement filter canceling; Add selectTab event to tab;

#50 Implement filter canceling of list; Add test for list events
#54 - remove duplicate code form tab; add selectTab event;

Coverage increased (+1.9%) to 77.199% when pulling 8bd859bc35e595cde67154f217ad3a719bb26d7a on petko5kov:master into 643f2d3a551b2d9f5bedffa83163630d0469965c on Infragistics:master.

Coverage increased (+7.9%) to 83.128% when pulling ebde97f9b2cce110ccb81c072895102aa2f011ef on petko5kov:master into 643f2d3a551b2d9f5bedffa83163630d0469965c on Infragistics:master.

Coverage decreased (-47.7%) to 27.574% when pulling d8d89bbe175cae28a57ed2215c2f13c49f4b2256 on petko5kov:master into 643f2d3a551b2d9f5bedffa83163630d0469965c on Infragistics:master.

Coverage decreased (-47.7%) to 27.574% when pulling ac44464e8b59da8c7ab12bfd6776505262824b50 on petko5kov:master into 643f2d3a551b2d9f5bedffa83163630d0469965c on Infragistics:master.

@petko5kov What happened to the coverage?

@petko5kov Will you be able to get this to work during this sprint?

Coverage decreased (-0.6%) to 81.369% when pulling ea3106de00a351f6854fa606768a22329582430a on petko5kov:master into b747bf44b5cb9d5426999ebb6c8b1c3bff4c6d83 on Infragistics:master.


Icons go missing after acessing options from sidebar modal on mobile

What happened?
happens on profile and cart:
https://github.com/kodadot/nft-gallery/assets/36627808/35494d34-189c-4386-943d-c70f02c29dcb

refreshed everything, cleared cache and it works properly, one time only type of bug


Refactor categorical judgments and sequents

@jonsterling I would like to refactor categorical judgments first before refactoring levels in the same way. The idea is that everything should be (1) fully polymorphic, or (2) specialized to abt with resolved names, or (3) specialized to ast with strings. Nothing in the middle. See https://github.com/RedPRL/sml-redprl/blob/6b38bba850b74bc75dde831db443632fe1b8f353/src/redprl/categorical_judgment.sig for the style I am going for.

sounds good!

@jonsterling Would you mind if I specialize (de-functorize) SEQUENT too? Basically replacing CJ.Tm with RedPrlAbt.

@favonia Yes, feel free to do whatever you think is best!

Sorry for the delay.

I'll come back to this tomorrow—unfortunately I'm busy all day today.

On Aug 19, 2017, at 8:57 AM, favonia (Sai-hong サイホン<EMAIL_ADDRESS>wrote:
@favonia commented on this pull request.
In src/redprl/signature.sml:

@@ -406,7 +406,7 @@ struct
val taux = CJ.synthesis jdgx
in
(ps,

                  Tm.Sym.Ctx.insert ctx x RedPrlSortData.HYP,

                  Tm.Sym.Ctx.insert ctx x taux,

Yeah... it does not even compile. However, what's the purpose of taux?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.

I'll come back to this tomorrow—unfortunately I'm busy all day today.

That's fine. I believe this is independent of what I'm going to do next.


Adding Code of Game

Guessing Game

I had added a small code in the C language of the Guessing Game.

It is basically a guessing game that allows users to enter any random number within a specific range.

It also provides some chances to users so that if in case their first guess is wrong they may try one more time.

Fixes #257
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented on my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Hey!
I had made the following changes mentioned by you.
Please check my PR and if you find it good then merge it to your repo.
Thank you!


Runtime tests output should not be colored unless the output is going to terminal which supports colors

As the title says.

Just scanning difficult: easy issues, and it seems this one was fixed by e0585ff4237586d21d069886165a21a4d0c21410.

Thanks for checking!