Solomining causes a fork

I have 2 wallets.  Both version v<IP_ADDRESS>-8b7d49e-unk, both run with -reindex since compiling them.
Had them synced up and up to testexplorer.   If I solomine on one with cpuminer, it forks and it's blocks are not accepted on testexplorer or the other wallet.   I mined until the rpcserver died.
Then I solomined on the other one.  It's blocks weren't accepted on testexplorer either, so it is off on it's own fork now.
This looks to be readily repeatable.

I told you exactly what constitutes an issue and what doesn't. You choose to ignore it so I choose to close this.


[BUG] The previews in the widget of pick image is black

Describe the bug (描述)
The previews in the widget of pick image is black
How to reproduce (如何复现)
Normal use, no special.
final List<AssetEntity> result = await AssetPicker.pickAssets(
        context, selectedAssets: lstTmp,
        maxAssets: widget.maxCount,
        requestType: RequestType.image);

image url:
https://postimg.cc/n9CrdmKV
Device information (设备信息)

Device: iPhoneSE
OS: 13.6
Flutter Version: v1.17.0

Is your images came from iCloud?

Is your images came from iCloud?

No, local images.
It was normal a few days ago. After I integrated Baidu map, I modified some things and it became like this.

Could you reproduce by revert your changes to find out which is causing this failure?

Could you reproduce by revert your changes to find out which is causing this failure?

I'm trying, at the same time, I would like to ask if you have encountered this kind of problem

At first it seems like issues related to iCloud, but if it don't, no similar issues are related.

At first it seems like issues related to iCloud, but if it don't, no similar issues are related.

OK，thank you very much!

I found the reason, because in order to solve a bug in Baidu Maps, several files were introduced. The sentence in it caused the title of the ios image to not be obtained, and finally the thumbnail could not be displayed.
NSDictionary+NilSafe.m


Extension removed from chrome store

Hi guys,
Today I received this email:

The extension is removed from the store until we make "some changes". It is very unclear as to what we need to change, so I've already replied to get some more information. I would like your help to figure out some things to change so I can reapply. What do you think needs to be changed?
@abasiri @g60madman @russelldc

@boukestam That is annoying! I think it's worth just going after the two bullet points they specified. For the screenshot one, maybe we can have a split screenshot that "shows" a transformation from gmail to inbox look. on the left side is gmail and right side is inbox in gmail, with an arrow in the middle. And maybe some text on the screen shot that says make gmail look like inbox. Then followed by additional screenshots, and a screenshot of the options page.
What was the description you had in webstore?

That is a great idea for the screenshot! The description was:
This extension adds features from Google Inbox to Gmail:

- show emails sent to yourself with subject "Reminder" as reminders
- group emails by date (today, yesterday, this month, etc)
- clean interface to come closer to the simplicity of Inbox
- colored avatars based on senders name
- calendar events displayed in a small card

This extension works best in English, since it relies on specific date formats.
It doesn't support the dark theme yet, so it only works with the default theme. If you are having problems with white/invisible text or icons, this is probably why. There are a few other settings which might make things look different so check these if that is the case:

Settings/Inbox/Categories -> Leave only Primary ticked
Settings/Inbox/Inbox Type -> Default or Starred First
Settings/Advanced/Multiple Inbox -> Disabled
Settings/Advanced/Preview Pane -> Disabled

I'm not a developer just a fan of this extension so I can't help with any technical issues but there is another extension that works similar (but not as well) and is still on the Chrome Store called "Inbox Theme For Gmail"
The name is pretty bland but it states specifically what you are getting: a "theme" for gmail.
Maybe their wording and description could help as well:
https://chrome.google.com/webstore/detail/inbox-theme-for-gmail/albppgldjlaflgenhggocpigdgdmgpee
On another note, from the video on their site I like how the header color changes based on the folder selected (inbox, starred, snoozed, etc)
http://flowapps.co/inboxtheme/
Keep up the great work guys, I love this extension!

@espionagesoftware Thanks a good point, the name could definitely be better. I think we should come up with a new name and icon just to be sure. The process of applying for review takes a long time so its better to get it right

@espionagesoftware The header color/title changing is to be fixed soon, in issue #10. I already know what needs to change for that to work.
Thanks for the comment, you're probably right about the name, unfortunately.

Inbox in Gmail as a name is hard to search for anyway.
I think any new description should also talk about the bundling feature
aswell. Or maybe the name can highlight that such as "inbox bundles for
Gmail". That way it becomes more discoverable.

I like that (without the tag line 😉)
On Fri, May 3, 2019, 8:14 AM Joey Troy<EMAIL_ADDRESS>wrote:

Maybe we name it Inbox Reborn Short description - Taking the ugly and
making it proper!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/boukestam/inbox-in-gmail/issues/69#issuecomment-489130508,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFM6PXUSBG33OIAWP3OUH3PTRJDTANCNFSM4HKRSJBQ
.

@boukestam Here's an updated description, this expects bundling has been merged:
Inbox In Gmail (to be changed)
This extension re-creates features you knew and loved from Google's discontinued Inbox to Gmail.
Features

Bundle emails by label and category
Group emails by date (today, yesterday, this month, etc)
Clean interface to come closer to the simplicity of Inbox
Display emails sent to yourself with subject "Reminder" as reminders
Colored avatars based on senders name
Calendar events displayed in a small card, with inline responses

Extension Options
Right click the extension's icon at the top right of your browser, and click 'Options' to adjust the behavior of some features:
Reminders
This option is used to determine how to treat emails sent to yourself.

All are treated as reminders.

Leave the emails as they are. (Disable)

Email Bundling
This option is used to bundle emails by label in the inbox.

Toggle Enable/Disable

Email Avatars
This option will show a circle with the first letter initial of the sender, to the left of the email in your folder.

Toggle Enable/Disable

Recommended Gmail Settings

Settings/Inbox/Categories -> Leave only Primary ticked
Settings/Inbox/Inbox Type -> Default or Starred First
Settings/Advanced/Multiple Inbox -> Disabled
Settings/Advanced/Preview Pane -> Disabled
Settings/General/Maximum Page Size -> Show 100 conversations per page
Settings/General/Personal level indicators -> No indicators
Settings/Inbox/Importance markers -> No markers

Email Bundling Tips
Disable inbox category tabs:

Settings Dropdown/Configure Inbox -> Leave only Primary ticked -> Save

Allow default category labels (Promotions, Social, Updates, Forums) to be bundled:

Settings/Labels/Categories/Show in message List -> Click show for each category

If you'd like a specific label not to be bundled, create a label called 'Unbundled', and nest any labels under it.
Known Issues

This extension works best in English, because it relies on specific date formats.
This currently only supports Gmail's default theme. If you enable the Dark theme, you will experience white/invisible text and icons.

As @abasiri recommended, I agree we need a screenshot of Before/After with an arrow.
We should also have a screenshot of the extension options modal.

If we have to change the name, and it seems we do, I hope it wouldn't mean losing the current users because they're stuck on an outdated version.
@abasiri
I think you're right that the current name made it harder to find. Even when I would go directly to the Chrome web store and search Inbox in Gmail, I'd have to expand to see all extensions and scroll down the page before I found it.
Also, that's a good candidate for a new name (Inbox Bundles for Gmail), and I agree a large chunk of people were looking for bundling... although, an even bigger chunk of people simply think Gmail is ugly and messy compared to Inbox, haha.

@espionagesoftware @boukestam I'm so confused how they targeted this extension for removal, and not Inbox Theme for Gmail. I think it must just be a problem with the name, because:

They don't show a Before/After screenshot either, theirs is just like ours was, a simple image of the inbox folder.
I thought maybe our description was misleading because it might seem like it's bringing over official features from Google Inbox, rather than re-implementing them, but their description is no better:

Brings the Google Inbox experience to Gmail

What images were used for this on the Chrome web store? I remember there was one on the search page that I can't find right now, and it's not shown on the Firefox store.
Here's the current store icon:

And current store screenshot:

The screen shot is old, as we removed the number of emails listing i.e. Inbox 3, Drafts 21

@g60madman Yes, that's just what was on the Firefox add-on page.

So far I like "Inbox Reborn" the best.  Vote with likes on this comment.

Ok, so the name will probably be Inbox Reborn. And I really like russells description. Now we just need a new icon. I guess the current icon looks a lot like gmails, just colored blue. That might be a problem as well. I made an attempt at a new logo:

It would also be good to have a couple of good screenshots, some with full screen shots, but also some with zoomed into specific features, and a 1-2 word description on the image: eg. Group by Date, Bundles, etc.

Something along these lines could work:

Here is a little something new age

This looks cool, I think something simpler would be more appropriate. Something recognizable, yet quickly distinguishable from the original.

Yeah, at the very least, it should be square :P

I like the ones from @abasiri the best. The one from @g60madman looks too much like the material logo. I will resubmit with the name "Inbox Reborn". And one of the two icons from @abasiri. And for the description I use the one from @russelldc. Which icon do you like the best?

@boukestam
I like the idea of @abasiri 's icons, but I think they may be way too similar to the real Inbox logo right now.

Here's a before/after set of screenshots I just took. Same inbox content in both shots:

@boukestam An animated GIF, if they allow those:

I found these guidelines they have for Chrome extensions that mention or display Google brands:
https://developer.chrome.com/webstore/branding

Ok so we definitely need a completely new icon then. Not using anything from existing google icons. What do you think about this one:

We should also probably change the "Inbox" back to gmail in the top bar. Since that makes it look like it is actually inbox and that is a google product

We should also probably change the "Inbox" back to gmail in the top bar. Since that makes it look like it is actually inbox and that is a google product

I disagree, that's the name of the email folder you're in. But... I should go fix #10 (Change header title and color by folder) right now so that's actually always true. According to @leggett (co-founder of the Inbox product) at least, as he so gracefully put it:

And of course, there’s that massive Gmail logo that sits in the upper left-hand corner of the screen. Just in case you forgot that you just typed “gmail.com” into your browser bar three seconds ago.  “C’mon.  Drop the logo. Give me a break.”

Source: FastCompany Interview
By the way, @leggett, what do you think of the bundling implementation we (mostly @abasiri) added, based on your advice? There's a few more enhancements to be made (#70), but it certainly works! You can see screenshots up above, at https://github.com/boukestam/inbox-in-gmail/issues/69#issuecomment-489356655.

@boukestam I think some good mix of your first idea https://github.com/boukestam/inbox-in-gmail/issues/69#issuecomment-489175617 and the most recent one would work.
I think your first one may have been a small modification of the Inbox logo. How about one of us re-do the blue envelope from scratch, and instead of the reminder icon on the opened letter in the envelope as in the first idea, place a refresh symbol there.

I noticed the branding guidelines say it's okay to mention the name of Google product in the name, description, and promotional image, but that it should include the trademark symbol, like:
Inbox Reborn for Gmail™
Although, it seems quite rare to see others actually doing that (ex: Boomerang for Gmail, Simplify Gmail, Inbox Theme for Gmail, and many many more)

I just pushed up code that changes the header's title and color to reflect the current folder. Fixes issue #10 in PR #74
Please review so I can merge asap @abasiri @boukestam @g60madman , thanks!

I have merged it. I will create a draft with the new version, icon, name and description later today and put that on the chrome store for review. We can always change the icon later if we want. Hopefully we are back online in a few days

Can you make some screenshots of the inbox and done page? My inbox is really full of private emails at the moment

Can you make some screenshots of the inbox and done page? My inbox is really full of private emails at the moment
Sure, give me a few minutes. I'll need to shuffle around private emails, too :)

Oh weird, I just pulled the merged master, and the bundle/category icons aren't working anymore. Fixing now...

Fixed.

Original Gmail UI for my inbox:

All of those are 1280x800 * 2 resolution.
Chrome Web Store guidelines recommend 1280x800 for screenshots.

@boukestam , I'm a user and a developer.  I'm missing this extension on my recently provisioned laptop.  Can I help?

@quietseditionist Know anybody on the Chrome Web Store team who can fast track the appeal/re-submission? :P I think we're just waiting for approval, right now, if @boukestam submitted it 3 days ago as he said he did.

@quietseditionist If you really need this on your laptop, you can just load the extension from the source here on Github. Just clone the repo or download it as a zip and extract to a folder.
Go to chrome://extensions/, toggle Developer Mode in the top right, and then click the Load Unpacked button near the top left.

Heh, I wish I could say so @russelldc .  I will stand by.

It was already rejected unfortunately, so I've just reverted everything to how it was (excluding the new icon and name) and I'm now waiting on a reply again...

@boukestam Ugh, did they give any explanation for the rejection?

Well, it was rejected with the previous (new) screenshots, which where exact matches with how it looks when being used. I also added your description @russeldc and even the new name. But that was not good enough and they said this:

So the only explaination I can think of is that they just don't believe our extension really looks like the screenshots and does what the descriptions says... Or they have something against extensions which target their own products

@boukestam

Or they have something against extensions which target their own products

That's clearly not true. There's hundreds of extensions that deal specifically with Gmail.

Well, it was rejected with the previous (new) screenshots,

So, the images of the inbox and done folder I posted earlier in this issue? Not a before/after split image kind of thing?
Thanks for including their original response, but I was wondering if there was any new message that came with the recent second rejection?
I don't think it's a good idea to revert to the old screenshots/descriptions, I don't see why that would be a better path for the submission. And I think I'd read that if it gets rejected several times in a row, it can be banned permanently.

@boukestam What did you submit as the extension's promotional image?
The one that shows up here, on the search page:

Or did you leave it as just the logo with whitespace?

@boukestam I'm pushing up a new commit to the master branch with a new manifest.json (with a better short description: Adds features like reminders, email bundling and Inbox's minimalistic style to Gmail™, as well as the Inbox Reborn theme for Gmail™ name.) and a slightly modified long description, with the trademark symbol.
When you submitted, did you change the extension's icon in the icons/ folder before packaging for the Chrome web store? If not, can you either commit those or upload them here? The master branch still has the old icon .pngs in that folder.
Also, could you add the screenshot of the Options page to the submission? That's in the README now.

Here's a before/after I whipped up quickly. I don't have much time right now, I might come up with something better later. I'd recommend using this (or something like it) as the main screenshot, followed by the Options menu, the new Done folder, and the new Inbox folder screenshots

I did almost exactly that and it was rejected:

@boukestam That one seems good enough to me...
How about the other questions? When you re-submitted, did you update the manifest to match the new name and description, and extension icon?

I noticed in the "new" rejection email it adds this:
"Please ensure your item is not copying icons/screenshots from popular items in the store"
Note the word "popular" .   Not sure what it is copying though.  Other than Google's own icons.

@espionagesoftware
Every published screenshot up until then had been of either @boukestam's, @g60madman's or my own inbox. And as far as I know, Bouke hadn't copied the first icon from another extension. It could be argued it's a recolored Gmail icon, but that wouldn't explain why they rejected the re-submission that had the new original icon (unless it's because @boukestam didn't change the icons in the code).  There are also several popular extensions that directly use the original red Gmail logo in them.

Ok guys, this will be my last try. The extension was rejected again yesterday, without any clear explaination. I'm really surprised by the lack of communication from Google, there is no clear indication of what exactly is the problem. If this doesn't work I will give up, since it's giving me a lot of stress. What are your suggestions for all of the following items:

Title
Icon
Short description
Long description
Screenshot(s) 1280x800 or 640x400
Small tile 440x280
Large tile 920x680
Marquee 1400x560

@boukestam Could you please answer my previous questions? It'd really help decide how to proceed.
What exactly did you submit yesterday?

For this last submission attempt, it might be worth it to create these kinds of descriptive screenshots, that Checker Plus for Gmail is using:

But I don't want to add any more stress on you, Bouke, you sound a bit busy. I'll try working on some like this tonight. When you get a chance, please answer the questions I'd posted above.

It's really frustrating that you keep getting generic rejection messages with no specific details about what we actually need to change to pass review. The fact that we have to just sit here and guess why the extension was rejected is pretty ridiculous.
No idea if this will work or not, but have you tried contacting support yet? https://support.google.com/chrome_webstore/contact/developer_support Maybe we can draft a message politely asking for specific details about exactly what needs to be changed to pass review? Google is notoriously bad at customer support, but it's worth a shot.

I really hope you don't give up on this. At the very least, please continue to to publish it in the Firefox add-on store and support it there. I use Firefox and cannot manage my email without bundling.

@russelldc maybe you could try to submit from your account and see what happens? I wonder if @boukestam has been kind of black listed after they blocked the extension.
Also, the screenshots can be updated after the extension has been published. To narrow down the problem with Google you could submit it without any image and see what happens.

I'm ok with others posting the extension, as long as there is a link and credit to this repository. So maybe that is a good thing to try.

Sorry for the delay on making those new screenshots, I got really busy with work (had to travel for work over the weekend, too :/).
I'll try to get it done after work today, and if Bouke isn't around at the time, I'll submit from my account, and credit this repo.
@boukestam What'd you submit as the promotional images in the past?

Don't give up on this, a lot of people are really happy with this extension and your fantastic job . Pitty that the Chrome Web store team is not very communicative, but I have some spare time in my hands, if necessary.

Been a while since I chimed in, one thing I noticed maybe a problem is this. Regardless of bundle or no bundle it doesn't seem to work

@g60madman What are you seeing in your inbox? It worked for myself and others. Did you follow the instructions in the readme/description?

@russelldc I did set all my settings per the readme, was just missing one but still no dice for my email. Not sure if it's bundling like the old inbox or not? Or if I don't have any emails in my inbox that are supposed to bundle. I have a trip coming up and have the flight and hotel but it's not bundling them.

I saw this advice on a Google forum:
1. There is a Chrome Web Store Support form here "https://support.google.com/chrome_webstore/contact/developer_support/?hl=en", describe your situation there.
2. Reply to the email that was sent to you with a request for explanation (you can recycle what you wrote from the form).
3. If you do not receive a response within a week, submit another form.
4. When they do reply to you, make sure you find out the exact reason your extension was taken down.
5. The reply may tell you which file from your extension they have a problem with specifically. Try to fix this file and resubmit your extension as an update.

I also saw a blog post from someone who replied back to the rejection, and a few hours later received this:
Thank you for reaching out to us.
Upon a subsequent review, we’ve reinstated your item and it is now available in the Chrome Web Store.

The screenshot is horrible, there is no icon and the description is missing...
...but at least the extension is available on the Chrome Web Store for those that can't take it from the repo.
I'll take it down as soon as the official version is uploaded. In the meantime I'll upload a new package from time to time when the repo is updated.

Sorry for disappearing for 2 weeks (though it seems like most others did too!). I've had a lot of projects starting/ending at work. I'm hoping I can get back on this sometime this week. Thanks @Muffo for getting something up 👍I'd really like to eventually get Bouke's original listing up so those users don't get lost and confused. Based on a few articles I read, it seems like it would be worth continuing to email Chrome Store dev support or fill out that form linked above, although only @boukestam can do that.

Trying to get some more attention here for #81. The Firefox add-on store listing has bee completely neglected since this happened, and the latest version there predates bundling, which is absolutely critical for me. I have therefore been forced to repeatedly load the extension manually through the debugging interface every time I launch Firefox, which is now up to a dozen times a day since I now carry a portable version of Firefox for use on college computers.
What needs to be done to publish an update to the Firefox add-on store? Or must I create my own account and publish it myself as a fork?

Comment above has been resolved. Please ignore. Thanks!

Hey! I don't know if you guys know, but the Chrome Web Store listing link is dead.

Yes, I received an email yesterday saying that the extension had been taken down. Basically for the same reason the original submission was removed.

Isn't it an option to supply supply  the CRX file for manual install (until the store debacle is resolved)

Yes, it's possible to create releases in Github and attach the CRX file there. This has to be done by the owner of the repo, though.

@Muffo The listing that you created was version 0.5.0, but the latest "official" release is 0.4.7. Did you just use master, or did you make any other changes? Apparently Chrome removed the extension from my browser, and I'm hoping to get it back.

Yes, I had simply used master.

Thanks for the response. One last question @Muffo, when you mirrored the extension on the Chrome web store, did you set the visibility as "Public" or "Unlisted"? I'm wondering if unlisted might give it more protection from being removed until this mess gets sorted out.

Good question! It was posted a Public, but I am not sure if hiding it would help. I wonder if Google uses some sort of automated scan tools to detect violations in their guidelines. At this stage, I am still not sure what the problem is.

I think Unlisted would actually work -- I was planning on suggesting it for now, until we sort this out with Google, but forgot. I'm not sure you'd be able to make the denied one into Unlisted one, though.
Now that you've gotten refused, can you try responding to them, @Muffo? I think Bouke was too busy to follow up.
As I'd posted in an earlier comment here, I saw this advice on a Google forum:
1. There is a Chrome Web Store Support form here "https://support.google.com/chrome_webstore/contact/developer_support/?hl=en", describe your situation there.
2. Reply to the email that was sent to you with a request for explanation (you can recycle what you wrote from the form).
3. If you do not receive a response within a week, submit another form.
4. When they do reply to you, make sure you find out the exact reason your extension was taken down.
5. The reply may tell you which file from your extension they have a problem with specifically. Try to fix this file and resubmit your extension as an update.

@arxae @richardfrost I published a new release of v0.5.1, including a crx file
https://github.com/boukestam/inbox-in-gmail/releases

@russelldc Thank you so much for the creating the new release!

Hi, I'm a user and I just read through this whole thread and it makes me sick what they're doing to you guys. It's so infuriating!  I LOVE this extension and in fact, can't live without it!
I had looked for it in the chrome store several times over the last few months to see if there was an update and was so disappointed and frustrated when I couldn't find it.  The only way I ended up here is because the icon that the original one put on my web browser, linked to here. So I'm really glad to see you are still trying.
So, you haven't been able to get any reply from that Google developers' contact page?

@LLI-inc I'm not sure if any of the others have had time to continue reaching out to Google's extension team. @Muffo @boukestam ?
I would have done it myself by now, but I've never uploaded it to the Chrome Web Store because I thought it might complicate things further, considering they have rules for not copying another extension on the store. I don't think I could contact them on another developer's behalf.
In related news, I got this email from Google recently:

We recently announced changes as part of Project Strobe that expand our efforts to ensure all Chrome extensions are trustworthy by default. This announcement includes the requirement that extensions request the narrowest permissions needed to implement their features, and that extensions that handle personal or sensitive user data post a privacy policy and handle user data securely.
The new policy, found in our updated Developer Program Policies, reads as follows:
Use of Permissions

Request access to the narrowest permissions necessary to implement your Product’s features or services. If more than one permission could be used to implement a feature, you must request those with the least access to data or functionality.
Don't attempt to "future proof" your Product by requesting a permission that might benefit services or features that have not yet been implemented.

Posting a Privacy Policy & Secure Transmission

If your Product handles personal or sensitive user data (including personally identifiable information, financial and payment information, health information, authentication information, website content and resources, form data, web browsing activity, user-provided content and personal communications), then your Product must:

Post a privacy policy, and
Handle the user data securely, including transmitting it via modern cryptography

Your extensions must be compliant with this policy by October 15th, 2019. You can learn more about these changes and how they may apply to you in our User Data FAQ.
If you have any questions, please reply to this email. You can also sign up for open office hours for Chrome Extensions.

The soonest available open office hours is August 29th as of today, and it looks like they have them every Tuesday and Thursday from 4-6PM UTC.
Our extension doesn't collect or store personal or sensitive user data, as far as I can tell from how it's defined in the User Data FAQ. And we have a privacy policy of sorts explaining this in the description.

4. My Product DOES NOT handle sensitive or personal data. What do I need to do?
You have no special or new obligations under the User Data Policy. Please state in your privacy policy that you are not handling user data.

This sounds a like a good time to resubmit. Honestly I think if we merged all the code into back into https://github.com/inbox-in-gmail I think any of us could push to the Google store who is a dev? Just  thought.

@g60madman Doesn't really matter what GitHub repo it's on, you just upload the packaged binary (the .crx file).
Like I mentioned in my last comment, I hadn't yet uploaded it myself to the Chrome Web Store because I thought it might complicate things further, considering they have rules for not copying another extension on the store. I hoped (and preferred) that we could revive the original version of the extension, so all those users aren't stuck on that old version. If Bouke is a no-show though, I might as well go ahead now.

I for one am fine if you want to post. I still think we should leave https://github.com/inbox-in-gmail the master repository as we have multiple admins associated with the repo so in the event something happens to a member the repo can continue on. Just my two cents.

@russelldc I know it's been a while, have we decided to try and release the extension again? If not I have some free time and can post it along with creating a website and also YouTube video as well. Let me know your thoughts. Again I say we leave https://github.com/inbox-in-gmail as the main repo.
Somehow these guys still have their extension accepted and I think it has to do with the YouTube video and also website. Let me know and I will start work on it.
https://chrome.google.com/webstore/detail/inbox-theme-for-gmail/albppgldjlaflgenhggocpigdgdmgpee

@g60madman
I'll get it up there tonight, thanks for reminding me. I merged latest into the inbox-in-gmail/inbox-in-gmail fork and updated the home page to point there instead.
I'm a little unconvinced that the video is what made the difference, but who knows? I figured they would judge based on the content provided, not on an external site.

Website is up. I also renamed the team site and repo
https://www.teaminbox.dev/ - Our website
https://github.com/team-inbox/ - Our team
https://github.com/team-inbox/inbox-reborn - Our code. I also activated issues as well so we can track them from the main repo now.
I am hoping to get the video done this week and published right now the website has the original Google Inbox video but I will get it updated to the video to show off the plugin. Once the video is published I will push the code to Google.

👍Although, I'd recommend instead of a separate Wordpress instance, it could just be hosted directly on GitHub. See here for details, if you're not familiar: https://pages.github.com

Is there any news on the progress of getting this back in the web store? Is the project still alive? The Inbox Theme for Gmail extension kinda broken and when I submitted an issue on that project's github I was made aware that this existed. Unlike the other extension which was just a theme this actually brings back functionality so I would be very much interested in using this extension instead.

Doesn't look like there is much activity at all. @boukestam seems to be absent from GH since september and the most recent fork (https://github.com/team-inbox/inbox-reborn) hasn't seen any activity for 2 months either.

I noticed that as well. It would be really nice if I didn't have to manually install this on every machine I check email on. Hopefully someone reads this and revives the effort to get this on the web store :P

It seemed like @russelldc was going to take over, but maybe he got busy?
I'd be willing to publish it if none of the contributors want to. No guarantee it won't get taken down again, which is probably why there has been delay and hesitation.

I spun up a website for Team Inbox team and was planning on releasing a YouTube video showing off the application and then posting the extension. Just haven't gotten there yet as I have been really busy as of late. Here is the site, if some one wants to create video showing off the differences that would fantastic and I then I can post it up https://www.teaminbox.dev/

Hey,
I use the extension on chrome on other devices. Today I can not use the extension on my new computer, due to the disappearance of the extension of the chrome webstore.
Is the project abandoning?
is it possible to take advantage of the extension by another means?
thanks for your reply

@gwilty-pixel - Go to this page:  https://github.com/boukestam/inbox-in-gmail/releases/tag/0.5.2 and download the inbox-in-gmail.crx file.
Then, open the Extensions page on your Chrome / Chromium browser and drag and drop this file onto that page. It will install automatically and you'll be good to go!

thanks for the reply
i did it, but i have the message :
This extension is not listed on the Chrome Web Store and may have been added without your knowledge.

i can't activate it and i'm in developer mode

here is the official chrome webstore help [answers] :
Use disabled extensions
If you need to use a disabled extension, you can contact the extension’s developer and ask them to upload their extension to the Chrome Web Store. This will allow you, and other people who use Chrome, to install that extension from the Chrome Web Store, or if you already have it installed, to manually re-enable it from your list of extensions.

You might try loading an unpacked extension. Just download the Source code.zip file from the Releases page, extract it to a folder and follow the steps linked above for loading an unpacked extension. This will cause a prompt every time you start Chrome that you'll have to acknowledge, but its not TOO bad. Hopefully we can get a real store release again soon.

here to say thanks you!
hope will back soon in store!
👍

Just want  to add that I love this extension and I could not use my email without it. I hope you are able to get it back in the store because without it I have this irritating "disable developer extensions" warning that pops up every time I open Chrome.

Close this issue up! We are back in the store!
https://chrome.google.com/webstore/detail/inbox-reborn-theme-for-gm/bkphmihkdbdgedlaflnkhnmnmibffomf?hl=en&authuser=1

That's awesome!  Did you ever find out why they took it out of the store in the first place?
Anyway, I'm so glad it's back in. Like mtherlihy said (above) I couldn't use gmail without it either.

@LLI-inc no clue they pulled it @boukestam tried to get it republished but they banned him. I resubmitted it through my google biz account and it'd all back up so who cares now 👍

Thanks for submitting it! I think we care about why it was removed because if the reason isn't addressed, it could just happen again. Hopefully not, but without knowing exactly why it was removed in the first place only time will tell.

@richardfrost If you look at the first post at the top it gives a really rough explanation on why it was not approved. I went back and gave a full description of the permissions and policies the script is using and how we are using javascript to manipulate the Google Gmail CSS and replace it with ours to give Gmail a new theme. I don't think this will be an issue again moving forward as it once again had to go through the "strict compliance review" from Google before being approved.

Thanks a lot @g60madman! That's amazing news. I had kind of given up after all the issues with the chrome store, but I'm glad that people can now use it again.

@boukestam you bet man, I am glad it's back as well as so many devs have worked on this wonderful extension!! I wrote a damn documentary about what it's doing and how we are manipulating the CSS with javascript. It only took 2 days to get reviewed before it was active so I am glad for now it's put to bed!

@g60madman Would you mind explaining in detail everything you needed to say in that "documentary" to get it approved? I have a fork of this project that is stripped down to just the bundling behavior that has been idle for a while but which I would eventually like to publish. I don't want to fall into the same trap @boukestam did, for which reason I haven't put much effort into it.

@jcgoble3 A couple of things I did

I set up a website for our Team, https://teaminbox.dev/ (registered and setup 2019) which also links to our source code
We have a link to the support area from the website and also the approved extension https://github.com/team-inbox/inbox-reborn/issues
I gave a detailed break down of what is being stored in the *storage justification section of the submission
I gave a detailed break down of what the code is doing in the *host permission justification section of the submission

The short answer is our code is using javascript and modifying CSS to overlay our template. I just wrote up a lot more to make it sound technical and precise. Who knows what algorithms Google uses to verify this code or the included tech-speak of the submission of the code. I highly doubt they have a bunch of employees spending their day looking at code to make sure it's safe. Google probably has a sandbox that loads the extension and launches a bunch of websites, if nothing breaks then it passes.
This same type of setup is probably why so many apps in the Google Play Store for Android are found with malicious code 🤣

Great, thanks! I'll try to follow that template when I eventually submit it. I'm hoping to have something ready for submission by the end of summer. School has been extremely difficult the past two semesters between online classes and senior-level classes (I'm graduating with my bachelor's in computer science this coming December) and taken up a lot of time, but my goal is to work on this around my internship this summer.


sender on authorizeForward

I have one topic for send and receive data (for group of clients)
and i want skip my own pushes (sendede from client) in authorizeForward function:
skip message forwarding if senderId  == client Id
but i havent senderId data. ive tried add senderId in authorizePublish function? but i can`t add my own data to pushed packet.
how i can do it !?
thank you ! !

This is not currently possible, the information is lost.
I would recommend you to not go into that path, but use a different topic for sending and one for receiving.


[user-info][xs]: added name param in showcase page and added new para…

added name param in owner.html
added name param in routes.js

@Mikanebu can you please include screenshot of how it looks like?


Tag a release for proxy

The current master includes the proxy() method which is not available in any release.
Please tag a new release with this functionality. 💛

Done.
btw: you're welcome to join to this organization. If you're interested, I can invite you.

@oscarotero please do. :)


feat(Dropdown): selectedIndex -> selectedId

part of #1003
Modify selectedIndex to selectedId in Dropdown component.
(I will create another PR for ComboBox later to make the diff smaller.)

@metonym
Thank you for reviewing :tada:
I created the PR for ComboBox in #1016

Released in v0.53.0.


Improve performance of TPC-H q14

What is the problem the feature request solves?
Initial observations:

Query is fully native
Similar to q19, lineitem scan takes longer with Comet
Comet avoids an expensive C2R on 600mm rows from lineitem
Looking at the metrics in Spark UI it looks like most operations are faster in Comet, yet the overall query wall clock time is slower
Needs more investigation

Describe the potential solution
No response
Additional context
No response

This info is now summarized in https://github.com/apache/datafusion-comet/issues/391


Add a function to approximate eccentric anomaly.

It uses Newton's method to approximate it for e<1. Its accuracy and performance are yet to be tested. Testing is needed in addition to ways to calculate M(t) for OrbitingCelestialObjects and the creation of various fields for orbital parameters.

Obviously the placement is temporary and may be changed as the code is integrated.

M(t) is honestly gonna be the annoying part, as it depends on the data sources you find for orbits (and will likely require conversion between different combinations of units)


ValueError: samesite must be "lax" or "strict".

django-cookies-samesite version: 0.8.0
Django version: 2.2.19
Python version: 3.9.0
Operating System: MacOS 11.2.3

Description
The middleware doesn't appear to be working. I continue to get the samesite must be "lax" or "strict". error.
What I Did
I have added the middleware to the top of my middleware however it continues to crash. It appears that the middleware is not being used. I have tried ordering my middleware different however nothing seems to work.
I have created a stack overflow post without any responses that provides more detail: https://stackoverflow.com/questions/66756908/setting-a-cookie-with-samesite-none-on-django-2-2
Traceback (most recent call last):
  File "/Users/my-project/venv/lib/python3.9/site-packages/django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "/Users/my-project/venv/lib/python3.9/site-packages/django/utils/deprecation.py", line 96, in __call__
    response = self.process_response(request, response)
  File "/Users/my-project/venv/lib/python3.9/site-packages/django/contrib/sessions/middleware.py", line 66, in process_response
    response.set_cookie(
  File "/Users/my-project/venv/lib/python3.9/site-packages/django/http/response.py", line 201, in set_cookie
    raise ValueError('samesite must be "lax" or "strict".')
ValueError: samesite must be "lax" or "strict".
{"level": "ERROR", "logger": "django.request", "function": "log.log_response", "stack_trace": "Traceback (most recent call last):\n  File \"/Users/my-project/venv/lib/python3.9/site-packages/django/core/handlers/exception.py\", line 34, in inner\n    response = get_response(request)\n  File \"/Users/my-project/venv/lib/python3.9/site-packages/django/utils/deprecation.py\", line 96, in __call__\n    response = self.process_response(request, response)\n  File \"/Users/my-project/venv/lib/python3.9/site-packages/django/contrib/sessions/middleware.py\", line 66, in process_response\n    response.set_cookie(\n  File \"/Users/my-project/venv/lib/python3.9/site-packages/django/http/response.py\", line 201, in set_cookie\n    raise ValueError('samesite must be \"lax\" or \"strict\".')\nValueError: samesite must be \"lax\" or \"strict\".", "message": "Internal Server Error: /favicon.ico\nTraceback (most recent call last):\n  File \"/Users/my-project/venv/lib/python3.9/site-packages/django/core/handlers/exception.py\", line 34, in inner\n    response = get_response(request)\n  File \"/Users/my-project/venv/lib/python3.9/site-packages/django/utils/deprecation.py\", line 96, in __call__\n    response = self.process_response(request, response)\n  File \"/Users/my-project/venv/lib/python3.9/site-packages/django/contrib/sessions/middleware.py\", line 66, in process_response\n    response.set_cookie(\n  File \"/Users/my-project/venv/lib/python3.9/site-packages/django/http/response.py\", line 201, in set_cookie\n    raise ValueError('samesite must be \"lax\" or \"strict\".')\nValueError: samesite must be \"lax\" or \"strict\".", "hostname": null}

My middleware and settings are configured in a common.py file:
# some settings...

MIDDLEWARE = (
    'django_cookies_samesite.middleware.CookiesSameSite',
    "django_middleware_global_request.middleware.GlobalRequestMiddleware",
    "django.contrib.sessions.middleware.SessionMiddleware",
    "django.middleware.locale.LocaleMiddleware",
    "django.middleware.common.CommonMiddleware",
    "django.middleware.csrf.CsrfViewMiddleware",
    "django.contrib.auth.middleware.AuthenticationMiddleware",
    "django.contrib.messages.middleware.MessageMiddleware",
   # and other app specific middleware
)

# some other settings

SESSION_COOKIE_SAMESITE = 'None'
SESSION_COOKIE_SAMESITE_FORCE_ALL = True
SESSION_COOKIE_SECURE = True
CSRF_COOKIE_SECURE = True

# other settings

I have also tried setting DCS_SESSION_COOKIES_SAMESITE = 'none' however it doesn't seem to make a difference.

I did! In the end I wrote a small function to manually apply this to my cookies instead of using a plugin.
def add_samesite_is_none(self, response, name):
        if settings.SESSION_COOKIE_SECURE:
            response.cookies[name]["samesite"] = "None"
        return response


Crash on Startup - Fabric 1.21

Game just don't open at all. I'm using only fabric api and skyrimcraft at all. I'll leave here more information and prints;
Steps to reproduce crash:
1- download and install skyrimcraft with geckolib, common network and dragon shouts, as well fabric loader 1.21 0.16.7 and fabric api 0.102.0+1.21;
2- try to open the game.

latest.log

Skyrimcraft already has the dragonshouts, so remove the dragonshouts mod and it will work fine!


Add face detection API

This patch adds the Face Detection API. Docs for the API are here: https://www.alchemyapi.com/api/face-detection

This looks great, thanks!

Released v0.6.0 containing this feature.


WIP: feat: build the docker image for amd64 and arm64 platforms

Motivation
Closes #8039
Using the docker image (ghcr.io/foundry-rs/foundry) on an Apple Silicon machine runs with the following warning:
 The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

and is likely suffering slowdowns due to emulation.

Solution
This PR should build the images for both amd64 and arm64 platforms

I'm still waiting for the workflow to pass on my repo https://github.com/Dzejkop/foundry/actions/runs/8467842044/job/23199474123

Marking this as a draft, please move it out of draft once you are ready for reviews :)

good lord i need this, the emulation slowdowns have been giving us so much headache lately 😅

any update for this PR ?

When will the package succeed, my local package has been compiling for 2 hours now   and it's not coming out!

@Sn0rt no update, OP has not circled back

unfortunately this doubles time of building, as there's a single runner building for both platforms, we'd need something like https://docs.docker.com/build/ci/github-actions/multi-platform/#distribute-build-across-multiple-runners to parallelize them

unfortunately this approach doubles time of building

Is that an issue in practice?

unfortunately this approach doubles time of building

Is that an issue in practice?

I think so, pretty sure this will kick in https://github.com/foundry-rs/foundry/blob/617931240f77e4751f04ae53e61ca855c78a5bbf/.github/workflows/docker-publish.yml#L26 (at least on my local machine took more than 2 hours)

I tried building locally like this:
docker build -t foundry-arm64 . --platform linux/arm64

It seemed to work well at first but running forge build in this image failed with (see extensive discussion in the telegram group):
"/root/.svm/0.8.24/solc-0.8.24": No such file or directory (os error 2)

It seems that simply building an image for arm64 might not always work as expected.

Hi @Thegaram ,
thank you for share your Dockerfile in telegram channel :)
In my case  adding
RUN forge install foundry-rs/forge-std --no-commit --no-git

before RUN forge build resolves the problem

A better way to do this would be to define a docker.hcl file like so:
# -*- hcl -*-

/** Special target: https://github.com/docker/metadata-action#bake-definition */
// docker-bake.hcl
target "docker-metadata-action" {}

target "build" {
  inherits = ["docker-metadata-action"]
  context = "./"
  dockerfile = "Dockerfile"
  platforms = [
    "linux/amd64",
    "linux/arm64"
  ]

But really, this begs the question: why even compile for docker? Why not just use the built artifacts and just package it after the fact vs. compiling for docker to begin with?

But really, this begs the question: why even compile for docker? Why not just use the built artifacts and just package it after the fact vs. compiling for docker to begin with?

That makes sense IMO

Comment here to be notified when it's ready

Sorry guys, didn't have the time to follow through with this.

But really, this begs the question: why even compile for docker? Why not just use the built artifacts and just package it after the fact vs. compiling for docker to begin with?

it's a little nicer in terms of workflow. I can just run docker build no matter the host platform (to a reasonable degree) instead of worrying about deps for the cross compilation tooling.
AFAIR the compilation time is really bad in case of arm host and x86 guest but the other way around shouldn't be so bad.
I should be able to allocate some time for this this week

Do we have an update on this? Can we just use mac runner to do this?

Small update from me:

I tried using a Mac runner but those don't have the same set of tools installed as regular ubuntu runners. This includes no docker installed. Installing docker and all the other deps felt like too much of a hassle, if anybody wants to try this route go ahead, but I'm abandoning this.
Running in QEMU takes fooooooreeeever, so much so that all the builds so far have timed out (e.g. this one took 6 hours and didn't even finish).

I'm now looking into building in CircleCi since they seem to support arm64 runners. I am struggling with a weird bug that prevents my arm64 job from starting, I'm currently waiting for CircleCi support to get back to me on this

Small update from me:
1. I tried using a Mac runner but those don't have the same set of tools installed as regular ubuntu runners. This includes no docker installed. Installing docker and all the other deps felt like too much of a hassle, if anybody wants to try this route go ahead, but I'm abandoning this.

2. Running in QEMU takes fooooooreeeever, so much so that all the builds so far have timed out ([e.g. this one took 6 hours and didn't even finish](https://github.com/Dzejkop/foundry/actions/runs/10950892276/job/30406979340)).

@Dzejkop maybe I am missing something, but why not simply using foundryup in Dockerfile which installs releases from foundry repo (instead rebuilding?)
https://github.com/foundry-rs/foundry/blob/a3071e5225122fd7c3d7a1759cabdfd17e314ded/foundryup/foundryup#L120-L138

@grandizzy I haven't though of that!
it's an option, I'll look into it if CircleCI route doesn't pay off.
It does make docker images dependent on foundry build runs from the past.
And it also means that if, e.g. you want to fork foundry or experiment with some custom functionality - you'd have to switch up the urls, or setup your own CI to build artifacts. With a from the source build it "just works".

@Dzejkop do you have time to continue work on the PR or should we take it on from here? thanks!

@Dzejkop do you have time to continue work on the PR or should we take it on from here? thanks!

Hardly 😅, feel free to take it from here, thanks!


Feature request: dumping the adjusted colorscheme into vim source

Thank you for this plugin 🍸
Would it be possible to fine-tune a color scheme and dump the new values so changes could be published?

This would be awesome. And yes, this is a fantastic plugin. Well done as always, @zefei

This function was added.


Trouble compiling Kremlin on osx

I am using OSX 10.13 High Sierra with ocaml 4.06.1. I cloned and built fstar git master, and I got the following error when I executed make:
$ make
ocamlbuild -I src -I lib -I parser -I kremlib -use-menhir -use-ocamlfind -classic-display -menhir "menhir --infer --explain" Kremlin.native Tests.native
ln -sf Kremlin.native krml
Didn't find fstarlib via ocamlfind or in FSTAR_HOME (which is: ); run make -C /ulib/ml
make: *** [pre] Error 1

I have fstar.exe in PATH, and I already executed make under ulib/ml under where I cloned FStar.
After setting FSTAR_HOME to where I cloned FStar, I got the following error:
$ make
ocamlbuild -I src -I lib -I parser -I kremlib -use-menhir -use-ocamlfind -classic-display -menhir "menhir --infer --explain" Kremlin.native Tests.native
ln -sf Kremlin.native krml
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C kremlib
../krml -fparentheses -fcurly-braces -fno-shadow -minimal -tmpdir extracted -warn-error +9+11 -skip-compilation -extract-uints \
	  -add-include '<inttypes.h>' -add-include '"kremlib.h"' -add-include '"kremlin/internal/compat.h"' \

KreMLin: from a ML-like subset to C

Usage: ../krml [OPTIONS] FILES

High-level description:
  1. If some FILES end with .fst or .fsti, and [-verify] is set, KreMLin will
     call [fstar] on them to perform verification.
  2. If some FILES end with .fst or .fsti, KreMLin will call [fstar] on them to
     perform extraction and produce [out.krml].
  3. If exactly one FILE ends with [.krml] or [.json], or if a [.krml] file was
     produced at step 2., KreMLin will generate a series of [.c] and [.h] files
     in the directory specified by [-tmpdir], or in the current directory.
  4. If some FILES end with [.c], KreMLin will compile them along with the [.c]
     files generated at step 3. to obtain a series of [.o] files.
  5. If some FILES end with [.o], [.S] or [.a], KreMLin will link them along with the
     [.o] files obtained at step 4. to obtain a final executable.

The [-skip-extraction] option stops KreMLin after step 1.
The [-skip-translation] option stops KreMLin after step 2.
The [-skip-compilation] option stops KreMLin after step 3.
The [-skip-linking] option stops KreMLin after step 4.

The [-warn-error] option follows the OCaml syntax, namely:
  - [r] is a range of warnings (either a number [n], or a range [n..n])
  - [-r] silences range [r]
  - [+r] enables range [r]
  - [@r] makes range [r] fatal.

The default is +1..2@3+4..8<EMAIL_ADDRESS>and the available warnings are:
  1: not generating code for a provided file
  2: found a reference to a function without implementation
  3: external command failed
  4: type error / malformed input
  5: type definition contains an application of an undefined type abbreviation
  6: variable-length array
  7: private F* function cannot be marked as C static
  8: C inline function reference across translation units
  9: need to manually call static initializers for globals
  10: deprecated feature
  11: subexpression is not Low*; cannot proceed
  12: cannot be compiled to Wasm
  13: monomorphic instance about to be dropped
  14: cannot perform tail-call optimization
  15: function is not Low*; need compatibility headers

The [-bundle] option takes an argument of the form Api=Pattern1,...,Patternn
The Api= part is optional and Api is made up of a non-empty list of modules
separated by + (for instance: Interface1+Interface2). A pattern is either Foo.Bar
(exact match) or Foo.Baz.* (prefix). The semantics are as follows: all the
modules that match a pattern are grouped into a single C translation unit, and
their declarations are marked as static, inasmuch as cross-translation unit
calls permit. If the Api= part is present, then the module named Api must be
found within the set of input files, and its declarations are appended to the
translation unit without any visibility modifications.

The default arguments are:

All include directories and paths supports special prefixes:
  - if a path starts with FSTAR_LIB, this will expand to wherever F*'s ulib
    directory is
  - if a path starts with FSTAR_HOME, this will expand to wherever the source
    checkout of F* is (this does not always exist, e.g. in the case of an OPAM
    setup)

The compiler switches turn on the following options.
  [-cc gcc] (default) adds [-ccopts -Wall,-Werror,-Wno-unused-variable,-Wno-unknown-warning-option,-Wno-unused-but-set-variable,-g,-fwrapv,-fstack-check,-D_BSD_SOURCE,-D_DEFAULT_SOURCE,-Wno-parentheses -ccopt -std=c11]
  [-cc clang] adds [-ccopts -Wall,-Werror,-Wno-unused-variable,-Wno-unknown-warning-option,-Wno-unused-but-set-variable,-g,-fwrapv,-fstack-check,-D_BSD_SOURCE,-D_DEFAULT_SOURCE,-Wno-parentheses -ccopt -std=c11]
  [-cc g++] adds [-ccopts -Wall,-Werror,-Wno-unused-variable,-Wno-unknown-warning-option,-Wno-unused-but-set-variable,-g,-fwrapv,-fstack-check,-D_BSD_SOURCE,-D_DEFAULT_SOURCE,-Wno-parentheses]
  [-cc msvc] adds [-warn-error +6 -falloca]
  [-cc compcert] adds [-warn-error @6@8 -fnostruct-passing -fnoanonymous-unions -ccopts -g,-D_BSD_SOURCE,-D_DEFAULT_SOURCE]

The [-fc89] option triggers [-fnoanonymous-unions], [-fnocompound-literals] and
[-fc89-scope]. It also changes the invocations above to use [-std=c89]. Note
that if you're using the uint128 type, you will have to manually compile this
code with -DKRML_VERIFIED_UINT128.

To debug Wasm codegen, it might be useful to trigger the same compilation path
as Wasm, but emit C code instead. This can be achieved with [-wasm -d
force-c,c-calls,wasm-calls -drop C,TestLib -add-include '"hack.h"']
where [hack.h] contains [#define WasmSupport_check_buffer_size(X)].

Supported options:
  -cc                     compiler to use; one of gcc (default), compcert, g++, clang, msvc
  -m32                    turn on 32-bit cross-compiling
  -fsopt                  option to pass to F* (use -fsopts to pass a comma-separated list of values)
  -ccopt                  option to pass to the C compiler and linker (use -ccopts to pass a comma-separated list of values)
  -ldopt                  option to pass to the C linker (use -ldopts to pass a comma-separated list of values)
  -skip-extraction        stop after step 1.
  -skip-translation       stop after step 2.
  -skip-compilation       stop after step 3.
  -skip-linking           stop after step 4.
  -verify                 ask F* to verify the program
  -verbose                show the output of intermediary tools when acting as a driver for F* or the C compiler
  -diagnostics            list recursive functions and overly nested data types (useful for MSVC)
  -wasm                   emit a .wasm file instead of C

  -add-early-include      prepend #include the-argument to every generated file, before kremlib.h
  -add-include            prepend #include the-argument to every generated file, after the #define __FOO_H
  -add-include-tmh        append #include <FILE.tmh>, where FILE is the current basename
  -minimal                do not prepend #include "kremlib.h"; do not bundle FStar
  -static-header          generate a .h for the given module where all functions are marked a static inline
  -no-prefix              don't prepend the module name to declarations from this module
  -bundle                 group modules into a single C translation unit (see above)
  -drop                   do not extract code for this module (see above)
  -library                this is a model and all functions should be made abstract
  -header                 prepend the contents of the given file at the beginning of each .c and .h
  -tmpdir                 temporary directory for .out, .c, .h and .o files
  -I                      add directory to search path (F* and C compiler)
  -o                      name of the resulting executable
  -warn-error             decide which errors are fatal / warnings / silent (default: +1..2@3+4..8<EMAIL_ADDRESS>
  -by-ref                 pass the given struct type by reference, always
  -fbuiltin-uint128       target compiler supports arithmetic operators for uint128 -- this is NON PORTABLE, works only with GCC/Clang
  -falloca                use alloca(3) for variable-length arrays on the stack
  -fnostruct-passing      disable passing structures by value and use pointers instead
  -fnoanonymous-unions    disable C11 anonymous unions
  -fnocompound-literals   don't generate C11 compound literals
  -ftail-calls            statically compile tail-calls into loops
  -funroll-loops          textually expand loops smaller than N
  -fparentheses           add unnecessary parentheses to silence GCC and Clang's -Wparentheses
  -fno-shadow             add unnecessary renamings to defeat GCC and Clang's -Wshadow, as well as the various MSVC warnings
  -fcurly-braces          always add curly braces around blocks
  -fnoshort-enums         use C11 enums instead of C macros and uint8_t for enums
  -fc89-scope             use C89 scoping rules
  -fc89                   generate C89-compatible code (meta-option, see above)

  -djson                  dump the input AST as JSON
  -dast                   pretty-print the internal AST
  -dmonomorphization      pretty-print the internal AST after monomorphization
  -dinline                pretty-print the internal AST after inlining
  -dpattern               pretty-print after pattern matches compilation
  -dsimplify              pretty-print the internal AST after going to a statement language
  -dstructs               pretty-print the internal AST after struct transformations
  -dc                     pretty-print the output C
  -dwasm                  pretty-print the output Wasm
  -d                      debug the specific comma-separated list of values; currently supported: inline,bundle,reachability,c-calls,wasm-calls,wasm-memory,wasm,force-c,cflat

  -help                   Display this list of options
  --help                  Display this list of options

make[1]: *** [extracted/Makefile.include] Error 1
make: *** [kremlib] Error 2

Hello,
Thanks for reporting the issue. Some things to try out:

can you git clean -fdx in kremlib and try again
can you try running this with a recent version of GNU make? I may have accidentally written a rule that relies a recent version of GNU make

Thanks,
Jonathan

note that recent versions of gnu make can be obtained via homebrew and oftentimes are available via the alias gmake

Hi,
I installed GNU make 4.2.1 via brew, and running gmake worked! Thanks!

Perhaps this should be on the installation guide?


Cannot merge LORA layers when the model is loaded in 8-bit mode

when running "guanaco_7B_demo_colab.ipynb"
i take load_in_4bit=True condition
but meet valueError of "Cannot merge LORA layers when the model is loaded in 8-bit mode".

ValueError                                Traceback (most recent call last)
Cell In[1], line 21
14 m = AutoModelForCausalLM.from_pretrained(
15     model_name,
16     load_in_4bit=True,
17     torch_dtype=torch.bfloat16,
18     device_map={"": 0}
19 )
20 m = PeftModel.from_pretrained(m, adapters_name)
---> 21 m = m.merge_and_unload()
22 tok = LlamaTokenizer.from_pretrained(model_name)
23 tok.bos_token_id = 1
File ~/anaconda3/envs/LLM3/lib/python3.10/site-packages/peft/tuners/lora.py:352, in LoraModel.merge_and_unload(self)
349     raise ValueError("GPT2 models are not supported for merging LORA layers")
351 if getattr(self.model, "is_loaded_in_8bit", False) or getattr(self.model, "is_loaded_in_4bit", False):
--> 352     raise ValueError("Cannot merge LORA layers when the model is loaded in 8-bit mode")
354 key_list = [key for key, _ in self.model.named_modules() if "lora" not in key]
355 for key in key_list:
ValueError: Cannot merge LORA layers when the model is loaded in 8-bit mode

@coolchenshan The code is likely commented out for a reason. Try loading it using device_map gpu if you have vram or load the to cpu.
https://github.com/artidoro/qlora/blob/e3817441ccc7cff04ca13e8fab5196d453ff32f2/examples/guanaco_7B_demo_colab.ipynb#L4


TextFileInput changes

I would still prefer the prefix BaseInput to be changed to BaseFileInput.  Without the word File, a dev might be confused into thinking that one of these classes should be used as a base for some non-file related input step.
I won't put my foot down, because it is a mistake that would quickly be found when they tried to extend it and suddenly had to deal with all sorts of methods that wouldn't apply to them, but still...

Put your foot down.   You're correct.  Please do the refactor prior to merge...
Bob Kemper
Executive Vice President of Engineering
Pentaho, a Hitachi Data Systems company.
5950 Hazeltine National Dr.
Suite 340
Orlando, FL 32822
(407)-965-4019
[cid:73B6094B-B76D-497B-8724-CECB1ECA14D5]
From: Daniel Einspanjer <notifications<EMAIL_ADDRESS>Reply-To: pentaho/pentaho-kettle <reply<EMAIL_ADDRESS>Date: Wednesday, September 2, 2015 at 11:50 AM
To: pentaho/pentaho-kettle <pentaho-kettle<EMAIL_ADDRESS>Subject: Re: [pentaho-kettle] TextFileInput changes (#1707)
I would still prefer the prefix BaseInput to be changed to BaseFileInput. Without the word File, a dev might be confused into thinking that one of these classes should be used as a base for some non-file related input step.
I won't put my foot down, because it is a mistake that would quickly be found when they tried to extend it and suddenly had to deal with all sorts of methods that wouldn't apply to them, but still...

Reply to this email directly or view it on GitHubhttps://github.com/pentaho/pentaho-kettle/pull/1707#issuecomment-137140665.

Okay, that is all the pertinent feedback I have from my exhaustive comparison of the old vs refactored code.

Closed because new one was pushed (#1716)


Enable detailed monitoring

Launch Templates introduced in https://github.com/kubernetes-incubator/kube-aws/pull/1531 did not enable monitoring. This PR adds detailed monitoring, so that worker nodes will behave the same way they did prior to kube-aws 0.13

Codecov Report

Merging #1585 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1585   +/-   ##
=======================================
  Coverage   25.86%   25.86%
=======================================
  Files          98       98
  Lines        5068     5068
=======================================
  Hits         1311     1311
  Misses       3610     3610
  Partials      147      147

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de82a15...1d587e5. Read the comment docs.

/assign @davidmccormick

Many thanks for your contribution! 🙏


project owner does not seem to maintain this project anymore

after waiting to for my pull request to be included (adaptations for deployment to central) for a while i noticed that the project owner has not reacted to any request for almost a year.
There are a lot of bug fixes and features waiting, so who is with me to create a new organisation and start a new maintained fork? I do not have the time (i have a lot of other open-source projects I work on more actively) to go into the core of this project but i am willing to help with build issues, unit-tests travis-ci and so.
But if there are some developers that will take the core part of the job, like checking if a pull request is plausible or would break something (that's not yet in the unit test ;-) ). Than I can take the part of build structure, releasing and central deployment.
anyone?

I personally haven't maintained the project since it was imported to Github and converted to Java >1.1.
@psh , looks like your latest Github and Twitter activities are from last November, are you still with  us?

This product seems too useful to be abandoned.  I can probably help with testing.

Just noticed it was private for some reason, but I'm an admin in the project. If @psh turns out to be MIA, I can grant writing rights to people, so no need for a fork just for the sake of getting the project maintainable again.

Great, that means much better changes to get it going again! How long would you say, should we wait for @psh  to react?

@elonen I propose to wait till end of the month, if @psh is still MIA then could you include me as project member? Then I will include the central release stuff and prepare a 2.2 release where we can include the most important pull requests. There are so many, so we should probably do a voting.

@ritchieGitHub, @elonen https://github.com/elonen I agree
On Fri, Apr 17, 2015 at 8:23 AM, Richard van Nieuwenhoven <
<EMAIL_ADDRESS>wrote:

@elonen https://github.com/elonen I propose to wait till end of the
month, if @psh https://github.com/psh is still MIA then could you
include me as project member? Then I will include the central release stuff
and prepare a 2.2 release where we can include the most important pull
requests. There are so many, so we should probably do a voting.
—
Reply to this email directly or view it on GitHub
https://github.com/NanoHttpd/nanohttpd/issues/169#issuecomment-93895717.

That sounds reasonable @ritchieGitHub. Some complications arose with admin settings, but I'm currently trying and sort them out.

Could you add me as an admin, then I will update the project and when that is finished we can start the voting.

Added. There's a problem, however: @psh has apparently forgot to add the main repository to the admin group. Creating a new repository under the NanoHttpd "organization" works though, so one possibility would be to for the current main one into e.g. "NanoHttpd/nanohttpd-dev", and start merging stuff there. I'll keep on trying to reach Paul.

that would be a solution, but lets try to contact github themself. I send them a request, maybe they will grant us the access rights. I may have found a good project icon
 . It is a Carbon molecule extremely small and extremely powerfull ;-)

I already contacted Github support: "For security reasons, we are not able
to add you to the Owners Team or transfer the repository to the Admin team
in order to grant you access."
Hope Paul receives one of my messages soon.
The carbon molecule is a nice idea.

I've got full access now, so no need for an extra repository anymore. Thank you @psh !

yes, great thanks @psh


IPv6 Support

Hi,
I don't know if this is of interest, but I've added rudimentary IPv6 support in a fork of the repo:
https://github.com/everycity/terraform-aws-dynamic-subnets
https://github.com/everycity/terraform-aws-vpc
Wasn't sure what the best way to communicate this to the world was, hence raising an issue! Anyway thanks for the awesome work - really helpful template.
Cheers,
Alasdair

@alaslums awesome! thanks for sharing. @aknysh can you check it out and see how could incorporate his changes? Looks like they are pretty minimal. My concern would be that it doesn't look like we can easily enable/disable IPv6 support due to the egress rules. Perhaps they are harmless to keep around even if IPv6 support is disabled.

thank you @alaslums.
we'll test, and if no issues, will add the changes to our repos

@aknysh can you follow up

i'm on it, sorry for the delay

Any updates on getting IPv6 support?

I opened #139 with @alaslums changes.


Closures as the last actual arg should get special treatment

If we can fit the first args and the closure signature on one line and the body the next, we should not move to an all vertical layout. E.g.,
pat_bindings(&self.def_map, pat, |binding_mode, _id, sp, path1| {
    foo(binding_mode);
    bar(sp, path1
});

This is particularly useful for the functional-style functions on iterators/Options, etc.

Note also we go for block indent rather than visual indent.

We should also have special rules for chaining so we can continue straight from the closing parenthesis. See https://github.com/nrc/rustfmt/pull/216/files#diff-e42df81afadf6f1aad31d0107e7aa2aeR144 for an example where we could do better.


Atomic tabs

Atom and VSCode and a few other editors have a feature where you can make soft tabs act as if they are hard tabs, so you can't click in the middle of them or use arrow keys to move into them. It brings most of the benefits of hard tabs to those unfortunate enough to have to use soft tabs. The only thing you still don't get is the ability to set the tab width, although now that I think about it I guess you could do that too in theory!
Anyway if someone points me in the rough direction of the code that says "if you press left or click here where should the cursor go" then I can implement this.
Here's the feature in VSCode with an animation

Implemented in #1419. Let me know if you would merge that and I'll polish it. Here's a little demo:
https://user-images.githubusercontent.com/376842/193354021-f7802382-f983-4ada-afe0-ec03e4cdb20f.mp4
Btw, the code base is pretty clean but it is very lacking in comments (the VSCode codebase has this issue too weirdly). E.g. in document.rs there's a contiguous 700 line block with 0 comments. It would have been way easier to add this feature if there were at least a few comments explaining what things are ("phantom text??") and why code is doing apparently weird stuff.
Hope that doesn't seem to harsh. This project seems great and I hope it succeeds!


Error with CSV output. Dependencies?

I tried running the example given at the top of the documentation page under usage
(base) [14:13:32:Effluent:Ben]$ cat config.toml
# Characteristics of the pipe and the effluent flow
[pipe]
time = [1970-01-01]
flow = [0.2]
dens = [1000]
diam = [0.5]
depth = [100]
decline = [0]

# Characteristics of the ambient water masses
[ambient]
time = [1970-01-01]
depth = [100]
coflow = [[0]]
crossflow = [[0]]
dens = [[1000]]

# Output options
[output]
csv.file = "out.csv"
csv.float_format = "%.6g"
trajectory.step = 5           # Time between trajectory points [s]
trajectory.stop = 30          # Time of final trajectory point [s]
release.start = 1970-01-01    # Time of first release [date]
release.stop = 1970-01-01     # Time of final release [date]
release.step = 3600           # Time between releases [s]

but got an error when it tried to write the output file
(base) [14:12:58:Effluent:Ben]$ python
Python 3.9.13 (main, Aug 25 2022, 18:29:29)
[Clang 12.0.0 ] :: Anaconda, Inc. on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import effluent
>>> effluent.run('config.toml')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/Ben/.local/lib/python3.9/site-packages/effluent/script.py", line 15, in run
    model.run()
  File "/Users/Ben/.local/lib/python3.9/site-packages/effluent/model.py", line 45, in run
    for _ in self.irun():
  File "/Users/Ben/.local/lib/python3.9/site-packages/effluent/model.py", line 60, in irun
    self.output.write(time, result)
  File "/Users/Ben/.local/lib/python3.9/site-packages/effluent/io.py", line 263, in write
    df.to_csv(
TypeError: to_csv() got an unexpected keyword argument 'lineterminator'
>>>

I switched to running in an isolated conda environment, and that seemed to resolve the issue, which makes me think it's a dependencies problem. Could you provide a list of dependencies (or, perhaps most ideally, an environment.yml file that can be used to build a working conda environment)? The environment.yml that I used is
name: Effluent

dependencies:
 - python>=3.7
 - netCDF4>=1.4
 - matplotlib>=3.1
 - pip
 - pip:
   - effluent

but it would be good to have an official one / confirmation about dependencies :-)
There's also a warning about precision conversions, that I figured I'd mention. The warning message includes a suggestion on how to resolve it, which might be nice to avoid warning-spamming :-)
UserWarning: Converting non-nanosecond precision datetime values to nanosecond precision. This behavior can eventually be relaxed in xarray, as it is an artifact from pandas which is now beginning to support non-nanosecond precision values. This warning is caused by passing non-nanosecond np.datetime64 or np.timedelta64 values to the DataArray or Variable constructor; it can be silenced by converting the values to nanosecond precision ahead of time.
  return self._dset.isel(time=0)

[This is in reference to JOSS review https://github.com/openjournals/joss-reviews/issues/5554]

I'm also running into issues with netcdf outputs, but think that might also be a dependencies issue. None of the provided examples use netcdf output, so to make sure that I'm not just doing something silly with the config file, could you provide an example that gives netcdf outputs?

Are you on Windows or Unix? I could provide an environment.yml file, absolutely, with some helpful text in the documentation about conda usage. On Windows, netCDF is tricky without proper conda configuration, but the unix integration server seems to run without problems while only using pip.

Your specific CSV problem is related to an API change in pandas 1.5.0. I can tell pip to only use newer versions, but first I'll check if I can make it compatible with older pandas versions as well.

The nanosecond warning is silenced by #29

The csv problem should be resolved by #30. Can you confirm?

Are you on Windows or Unix?
Unix [more specifically Mac/OS X]

I could provide an environment.yml file, absolutely, with some helpful text in the documentation about conda usage.
That would be great!

The csv problem should be resolved by #30. Can you confirm?

Unfortunately, the problem seems to persist. I've uploaded the output of pip install --verbose effluent here
install.log.
(base) [16:15:40:Effluent:Ben]$ python
Python 3.9.13 (main, Aug 25 2022, 18:29:29)
[Clang 12.0.0 ] :: Anaconda, Inc. on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import effluent
>>> effluent.run('config.toml')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/Ben/opt/anaconda3/lib/python3.9/site-packages/effluent/script.py", line 15, in run
    model.run()
  File "/Users/Ben/opt/anaconda3/lib/python3.9/site-packages/effluent/model.py", line 45, in run
    for _ in self.irun():
  File "/Users/Ben/opt/anaconda3/lib/python3.9/site-packages/effluent/model.py", line 60, in irun
    self.output.write(time, result)
  File "/Users/Ben/opt/anaconda3/lib/python3.9/site-packages/effluent/io.py", line 263, in write
    df.to_csv(
TypeError: to_csv() got an unexpected keyword argument 'lineterminator'

I haven't yet created a new release number for the update, so it's still on 1.2. Which means you'll have to run pip uninstall effluent first, otherwise pip won't download the new version. And use pip git+https://github.com/pnsaevik/effluent to be sure to download the new version ("pip install effluent" installs from PyPI).
I'm travelling in June, but will return to this review in August. See you until then.

Sounds good, no worries. Give me a nudge when you're back and I'll give it another test :-)

I'm back now. Can you test whether the development version solves the csv issue? To install, do the following:

Uninstall effluent, pip uninstall effluent
Install the development version, pip install git+https://github.com/pnsaevik/effluent

@pnsaevik , I started a new environment and re-installed the latest version of effluent. The tests pass and that example worked, but the nanoseconds warning is still complaining.
For reference:
effluent   097c01064
python                    3.11.4
pandas                    2.0.3

Strange, I cannot reproduce the warning, neither on windows or linux, nor on circle ci. I use the same python and pandas versions. Anyway, since it's just a warning, I suggest we close this issue now.

@pnsaevik , since @bastorer raised this issue, it might be better to check with @bastorer before closing it.

Sorry, my bad!

Hey @pnsaevik , I'm happy to confirm that the test passed without errors or warnings on my end :-)
Feel free to close the issue!


podman "info" test fails if username has a dash/hyphen

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
The info podman system integration test fails if the user running the test has a dash in their username.
Steps to reproduce the issue:

useradd test-user

Log in as the test-user

Run podman system integration tests.

Describe the results you received:
# #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
# #|     FAIL: jq .store.ConfigFile
# #| expected: '/[a-z0-9\/.]\+$'
# #|   actual: '/home/cki-test/.config/containers/storage.conf'
# #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Describe the results you expected:
I expected the test to pass.
Additional information you deem important (e.g. issue happens only occasionally):
Output of podman version:
podman version 1.4.4

Output of podman info --debug:
debug:
  compiler: gc
  git commit: ""
  go version: go1.12.7
  podman version: 1.4.4
host:
  BuildahVersion: 1.9.0
  Conmon:
    package: podman-1.4.4-4.fc30.ppc64le
    path: /usr/libexec/podman/conmon
    version: 'conmon version 1.0.0-dev, commit: 9d80fb7473bdf8cb76b6555365347b43dccb4890'
  Distribution:
    distribution: fedora
    version: "30"
  MemFree:<PHONE_NUMBER>0
  MemTotal:<PHONE_NUMBER>2
  OCIRuntime:
    package: runc-1.0.0-93.dev.gitb9b6cc6.fc30.ppc64le
    path: /usr/bin/runc
    version: |-
      runc version 1.0.0-rc8+dev
      commit: 68683aa82918b798e0d3c5446eb0756c3ba3a9b2
      spec: 1.0.1-dev
  SwapFree:<PHONE_NUMBER>0
  SwapTotal:<PHONE_NUMBER>0
  arch: ppc64le
  cpus: 8
  hostname: ibm-p9z-18-lp2.virt.pnr.lab.eng.rdu2.redhat.com
  kernel: 5.2.4-fc89179.cki
  os: linux
  rootless: true
  uptime: 30m 17.32s
registries:
  blocked: null
  insecure: null
  search:
  - docker.io
  - registry.fedoraproject.org
  - quay.io
  - registry.access.redhat.com
  - registry.centos.org
store:
  ConfigFile: /home/cki-test/.config/containers/storage.conf
  ContainerStore:
    number: 0
  GraphDriverName: overlay
  GraphOptions:
  - overlay.mount_program=/usr/bin/fuse-overlayfs
  GraphRoot: /home/cki-test/.local/share/containers/storage
  GraphStatus:
    Backing Filesystem: xfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "false"
  ImageStore:
    number: 1
  RunRoot: /run/user/1001
  VolumePath: /home/cki-test/.local/share/containers/storage/volumes

Additional environment details (AWS, VirtualBox, physical, etc.):
This is a physical ppc64le host.

does it fail on x86_64

@baude Yes, and on aarch64 as well.


Infinite loop in checkout step1 and step3 for new registered user

For new users who don't have addresses and payment infos, in checkout step1 (add shipping address) and step 3 (add payment details), there will be infinite loop issue.

has been fixed since reporting this bug


How to get user profile in SDK 1.7.0

Hi,
I want to use Alexa Skill in my device app, but i don't know how to get the user profile.

Hi!
In order to use skills you have to implement your own server side code and connect to that code from your app. I encourage you to take a look at Alexa Skill Kit forums.

Closing issue. Feel free to re-open if there are any further questions.


Deeplinking v2

Overview
Collecting feedback from the release of the new deeplinking feature for the next iteration.
Feedback

no deeplinking of incoming txs
icon is not optimal and users might not understand that they can copy by clicking on the icon, low discoverability
hover text change to "Copy transaction link", "Copy link" or "Share link"

Requirements

Switch to the id instead of safeTxHash
Use id also for the local pending status

Links

Initial discussion  post-release.
Mobile kick-off

Incoming txns have been fixed, they are linkable now.
Icon will be changed here: https://github.com/safe-global/safe-react/issues/3508


Update Dutch translation

Translated the intro tutorial, lightsources wizard and reflectionprobes wizard
Also fixed the capitalization on some words and reworded some words to fit the context better

Thanks for the additions!


Update workflows: Include build job into build-and-test

This PR modifies the build-and-test.yml workflow so that it includes two jobs:

build: the required job to merge PRs into master
test: the optional job to test PRs with Cypress

Internal Tracking ID: EXPOSUREAPP-14535

@larswmh
It's interesting to see in https://github.com/corona-warn-app/cwa-website/pull/3323 that the "build" job is required and the "test" job is not required. Again, I'm guessing that this is part of the branch protection rules which are not visible to me.

@MikeMcC399

It's interesting to see in #3323 that the "build" job is required and the "test" job is not required. Again, I'm guessing that this is part of the branch protection rules which are not visible to me.

In the branch protection rules, the build job is set as required. Not the build.yml workflow file. This way I could just move it to the build-and-test.yml without problems.

@larswmh
Thank you for the screenshot! I imagined that it must be like this, however I had no way to view it.
It might be good at a later stage to add the test job to the required positive status outcomes. It is probably good for the moment not to require it, until there is more experience with the job. Whoever merges a PR can make the decision manually if they want to merge a PR which fails the Cypress test (like https://github.com/corona-warn-app/cwa-website/pull/3321).


Isn't it good idea to use events instead of overriding save method

There are some problems when using this package and laravel-nestedset together, because of the overridden save method.
e.g. up() and down() to change node order don't work
Is there any other way to save translations without changing save method?

As of this merge it now uses Trait instead of extending https://github.com/lazychaser/laravel-nestedset/pull/76


Error php

Hello,
Thanks for plugin but I have this errors
[2024-05-24 17:20:08] glpiphplog.WARNING:   *** PHP Warning (2): Trying to access array offset on value of type bool in /var/www/html/glpi/plugins/glpiwithbookstack/inc/integrate.class.php at line 17
Backtrace :
src/CommonGLPI.php:383                             PluginGlpiwithbookstackIntegrate->getTabNameForItem()
src/CommonGLPI.php:342                             CommonGLPI->addStandardTab()
src/CommonGLPI.php:893                             CommonGLPI->defineAllTabs()
src/CommonGLPI.php:1230                            CommonGLPI->showTabsContent()
src/CommonDBTM.php:6566                            CommonGLPI->display()
front/ticket.form.php:265                          CommonDBTM::displayFullPageForItem()
public/index.php:82                                require()
[2024-05-24 17:20:08] glpiphplog.WARNING:   *** PHP Warning (2): Trying to access array offset on value of type bool in /var/www/html/glpi/plugins/glpiwithbookstack/inc/integrate.class.php at line 160
Backtrace :
src/CommonGLPI.php:694                             PluginGlpiwithbookstackIntegrate::displayTabContentForItem()
ajax/common.tabs.php:120                           CommonGLPI::displayStandardTab()
public/index.php:82                                require()
I use GLPI 10.0.15 and Bookstack  v24.02.2  in french
In config for url its https://example.com/api/books or https://example.com
Thanks

Update :
I got curl to work by disabling SSL certificate verification with
curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
$ch = curl_init($url_api);
curl_setopt($ch, CURLOPT_HTTPGET, true);
// set timeout for curl to prevent long time loading if Bookstack instance is not reachable
curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
curl_setopt($ch, CURLOPT_CONNECTTIMEOUT, $my_config['curl_timeout']);
Nowx i have this error
`[2024-05-24 18:22:36] glpiphplog.WARNING:   *** PHP Warning (2): Undefined array key "total" in /var/www/html/glpi/plugins/glpiwithbookstack/inc/integrate.class.php at line 122
Backtrace :
...ns/glpiwithbookstack/inc/integrate.class.php:15 PluginGlpiwithbookstackIntegrate->getBookstackSearchResults()
src/CommonGLPI.php:383                             PluginGlpiwithbookstackIntegrate->getTabNameForItem()
src/CommonGLPI.php:342                             CommonGLPI->addStandardTab()
src/CommonGLPI.php:893                             CommonGLPI->defineAllTabs()
src/CommonGLPI.php:1230                            CommonGLPI->showTabsContent()
src/CommonDBTM.php:6566                            CommonGLPI->display()
front/ticket.form.php:265                          CommonDBTM::displayFullPageForItem()
public/index.php:82                                require()
[2024-05-24 18:22:36] glpiphplog.WARNING:   *** PHP Warning (2): Undefined array key "total" in /var/www/html/glpi/plugins/glpiwithbookstack/inc/integrate.class.php at line 125
Backtrace :
...ns/glpiwithbookstack/inc/integrate.class.php:15 PluginGlpiwithbookstackIntegrate->getBookstackSearchResults()
src/CommonGLPI.php:383                             PluginGlpiwithbookstackIntegrate->getTabNameForItem()
src/CommonGLPI.php:342                             CommonGLPI->addStandardTab()
src/CommonGLPI.php:893                             CommonGLPI->defineAllTabs()
src/CommonGLPI.php:1230                            CommonGLPI->showTabsContent()
src/CommonDBTM.php:6566                            CommonGLPI->display()
front/ticket.form.php:265                          CommonDBTM::displayFullPageForItem()
public/index.php:82                                require()
[2024-05-24 18:22:36] glpiphplog.WARNING:   *** PHP Warning (2): Undefined array key "data" in /var/www/html/glpi/plugins/glpiwithbookstack/inc/integrate.class.php at line 134
Backtrace :
...ns/glpiwithbookstack/inc/integrate.class.php:15 PluginGlpiwithbookstackIntegrate->getBookstackSearchResults()
src/CommonGLPI.php:383                             PluginGlpiwithbookstackIntegrate->getTabNameForItem()
src/CommonGLPI.php:342                             CommonGLPI->addStandardTab()
src/CommonGLPI.php:893                             CommonGLPI->defineAllTabs()
src/CommonGLPI.php:1230                            CommonGLPI->showTabsContent()
src/CommonDBTM.php:6566                            CommonGLPI->display()
front/ticket.form.php:265                          CommonDBTM::displayFullPageForItem()
public/index.php:82                                require()
[2024-05-24 18:22:36] glpiphplog.WARNING:   *** PHP Warning (2): foreach() argument must be of type array|object, null given in /var/www/html/glpi/plugins/glpiwithbookstack/inc/integrate.class.php at line 134
Backtrace :
...ns/glpiwithbookstack/inc/integrate.class.php:15 PluginGlpiwithbookstackIntegrate->getBookstackSearchResults()
src/CommonGLPI.php:383                             PluginGlpiwithbookstackIntegrate->getTabNameForItem()
src/CommonGLPI.php:342                             CommonGLPI->addStandardTab()
src/CommonGLPI.php:893                             CommonGLPI->defineAllTabs()
src/CommonGLPI.php:1230                            CommonGLPI->showTabsContent()
src/CommonDBTM.php:6566                            CommonGLPI->display()
front/ticket.form.php:265                          CommonDBTM::displayFullPageForItem()
public/index.php:82                                require()
[2024-05-24 18:22:36] glpiphplog.WARNING:   *** PHP Warning (2): Undefined array key "total" in /var/www/html/glpi/plugins/glpiwithbookstack/inc/integrate.class.php at line 142
Backtrace :
...ns/glpiwithbookstack/inc/integrate.class.php:15 PluginGlpiwithbookstackIntegrate->getBookstackSearchResults()
src/CommonGLPI.php:383                             PluginGlpiwithbookstackIntegrate->getTabNameForItem()
src/CommonGLPI.php:342                             CommonGLPI->addStandardTab()
src/CommonGLPI.php:893                             CommonGLPI->defineAllTabs()
src/CommonGLPI.php:1230                            CommonGLPI->showTabsContent()
src/CommonDBTM.php:6566                            CommonGLPI->display()
front/ticket.form.php:265                          CommonDBTM::displayFullPageForItem()
public/index.php:82                                require()
`
Is it possible to search with the ticket title only as I don't use categories and tags?
Thanks

Hello,
Thanks for plugin but I have this errors [2024-05-24 17:20:08] glpiphplog.WARNING: *** PHP Warning (2): Trying to access array offset on value of type bool in /var/www/html/glpi/plugins/glpiwithbookstack/inc/integrate.class.php at line 17 Backtrace : src/CommonGLPI.php:383 PluginGlpiwithbookstackIntegrate->getTabNameForItem() src/CommonGLPI.php:342 CommonGLPI->addStandardTab() src/CommonGLPI.php:893 CommonGLPI->defineAllTabs() src/CommonGLPI.php:1230 CommonGLPI->showTabsContent() src/CommonDBTM.php:6566 CommonGLPI->display() front/ticket.form.php:265 CommonDBTM::displayFullPageForItem() public/index.php:82 require()
[2024-05-24 17:20:08] glpiphplog.WARNING: *** PHP Warning (2): Trying to access array offset on value of type bool in /var/www/html/glpi/plugins/glpiwithbookstack/inc/integrate.class.php at line 160 Backtrace : src/CommonGLPI.php:694 PluginGlpiwithbookstackIntegrate::displayTabContentForItem() ajax/common.tabs.php:120 CommonGLPI::displayStandardTab() public/index.php:82 require()
I use GLPI 10.0.15 and Bookstack v24.02.2 in french In config for url its https://example.com/api/books or https://example.com
Thanks

Hey,
thanks for the error codes.
Well i just setup a quick test environment.
I used a fresh install of glpi with the latest version of my plugin.
The Bookstack instance is my own which is accessible through a valid Let's Encrypt certificate.
So I guess you maybe use Bookstack on HTTPS with a self signed or outdated or broken certificate?
In the settings it's important that you just set Bookstack's base url. Do not append /api or something.
For my instance I created a extra user with API permission and API-Token.
It should look like:

Can you check these steps please?

Hello,
I use a certificat SSL in local with a specific certificate authority (CA)
For my settings :
I have a user api on bookstack and url is good now

Thanks

That sounds good. So your problem is solved now and the API is delivering fine in the ticket form?
Then I would maybe just add a check and a description later so this problem won't happen to the next user.

Hello,
Yes with curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false); it's work
A check to disable SSL verification if it's possible.
Thanks

I just added the option for disable SSL_VERIFYPEER and put a description under the base URL so it's easier to understand which part of the URL you need to put in.
See commit b1ba2467b35d7969284dc68150f5136024ea04f5


Add skeleton for gateway actor invariants

This PR establishes a skeleton for future invariant tests for GatewayActor.
The main idea is to define all basic properties of the gatewayActor and be able to apply them to many different Gateway instances with different configurations.
Copy of https://github.com/consensus-shipyard/ipc-solidity-actors/pull/413

@dnkolegov is this now superseded by #516?

@dnkolegov is this now superseded by #516?

Correct. I will close this PR.


Restructure codebase

Currently, all the code (front + back) lives under src without specific directories for things. We should move atoms, molecules, organisms and templates under a components directory, while also updating the backend code to closer match an MVC backend architecture.
As this is a reasonably large task, it will probably be undertaken piece-by-piece alongside other things.

As we are currently in lockdown, I am planning to start working on this in a branch, as Sprint 5's tasks are mostly complete already. The plan is as follows:
Stage 1

Move frontend code into src/components, update references accordingly.
Update frontend code and decouple as much of the language-specific code from frontend (better treat it as data coming from the backend).
Update tests, introduce more tests and cover most of the codebase, introducing set fixtures for easier, faster and more consistent tests.
Improve documentation for all of the frontend code, cleanup relics.
Cleanup and revamp styles for the frontend code - this includes a more consistent vertical rhythm as well as cleaning up redundant and overly complex styles and things like typography and color updates if necessary.
Restructure backend code, rewriting most of the GraphQL schema, allowing for more reusable structures and more flexibility.
Introduce models and controllers, alongside serializers, if possible to closer resemble the MVC architecture.
Introduce extensive backend tests with proper fixtures and E2E tests that cover real use-case paths.
Update documentation for the backend code, as well as introduce a Wiki or other documentation for E2E tasks and new feature development (more or less a proper README for new contributors).

After further consideration and reading up on the topic, MVC might not fit Gatsby after all, so we will be exploring a more customized pattern to fit our needs.