Strict typing for em.create

Hi, first of all, thank you for the great library. I love it.
Is your feature request related to a problem? Please describe.
The method create of EntityRepository<T> receives { [k in T]?: T[k] | any }. I'm wondering it should not accept any because it accepts incorrect type for Database, so  { [k in T]?: T[k] } looks better.
Consider this example:
// entities/User.ts

import { Entity, Property, EntityRepositoryType } from '@mikro-orm/core'
import { UserRepository } from '../repositories/UserRepository'

@Entity({ customRepository: () => UserRepository })
export class User {
  [EntityRepositoryType]: UserRepository

  @Property({ default: 0 })
  height: number = 0
}

// repositories/UserRepository.ts

import { EntityRepository } from '@mikro-orm/postgresql'
import { User } from 'src/entities/User'

export class UserRepository extends EntityRepository<User> {}

// app.ts
import { User } from './entities/User'
import { UserRepository } from './repositories/UserRepository'

const userRepo = em.getRepository(User)
const user = await userRepo.create({
  height: 'ANYTHING_HERE_AND_FAILS_IN_RUNTIME',
})

Describe the solution you'd like
Remove any from the type definition.
https://github.com/mikro-orm/mikro-orm/blob/1a5ae3baa7583a7e38a5cb0083ce67ec990781b6/packages/core/src/typings.ts#L122
Describe alternatives you've considered
Manual constructing class instance checks type, but I think prefer .create method for readability.
const newUser = new User()
newUser.height = 'THIS_RAISE_TS_ERROR'

Additional context
I think this is because supporting complex typing, like json type?

Yes, this is something I'd like to rework in v5 - I feel like making the types stricter is an actual breaking change. There are more places than just this.

Manual constructing class instance checks type, but I think prefer .create method for readability.

Interesting take, for me em.create is actually less readable. Btw it is a sync method for creating entity instances, no need to await it.

I think this is because supporting complex typing, like json type?

It's more like the type was used internally on places that require it to be to loose. In fact we should have two types, one for the db type (e.g. snake case props), one for the entity type (e.g. camel case props) - but they are both represented as EntityData. Also in general the DTO can have any properties (e.g. when you define custom toJSON method). The type is simply used in too many places so it had to be loose in the end :D

@B4nan
Thank you for your reply!

Yes, this is something I'd like to rework in v5 - I feel like making the types stricter is an actual breaking change. There are more places than just this.

Yeah I took a look at the code and it is used in massive parts of the codebase. I could be a hard work to change them.
I'm looking forward to v5!

Interesting take, for me em.create is actually less readable. Btw it is a sync method for creating entity instances, no need to await it.

Thank you for pointing out ;)
For now I'll use patch-package or something. Thank you!

@acro5piano did you have any luck in patching the library to enforce strict type checking? If yes what was the approach?

I don't see why would you need to patch the library, just create the method elsewhere (e.g. custom base repository).
But if you really want to, this is only a TS issue, so it should be possible to override the typings of the library similar way like you would extend a request object with a new property (quite common use case).
https://stackoverflow.com/questions/37377731/extend-express-request-object-using-typescript

@araujoigor
No, it seems to be easier to stick to set properties in a bit manual way. In the above example, use
class User {
  height!: number
}
const userRepo = await em.getRepository(User)
const newUser = new User()
newUser.height = 155
await userRepo.save(newUser)

Or if you don't like the null assertion ( !: ), modify a constructor
class User {
  height: number
  constrcutor(height: number) {
    this.height = height
  }
}

const userRepo = await em.getRepository(User)
const newUser = new User(155)
await userRepo.save(newUser)

The context is that I came from Objection.js and Knex. Knex is a query builder where the create syntax is something like
interface User {
  height: number
}

await knex<User>('users').update({ height: 15 }) // Type checked

I don't compare them or say which is better or not.
Mikro-ORM is a full featured ORM, and setting everything in Class should be the proper way in that world .

@abrasher Thanks for sharing. I love the hack!


Add lstmbox and wordstrbox to C-API

You need to also edit capi.h

Thanks, @amitdo.  Made a new PR with both commits.


Windows - warning - multiple modules with names that only differ in casing

I am not sure if this is nuxt error or not. But executing nuxt gives me a warning about casing.
Once there is "C:", once "c:"
WARNING in C:/Users/artur/AppData/Roaming/npm/~/nuxt/~/process/browser.js
There are multiple modules with names that only differ in casing.
This can lead to unexpected behavior when compiling on a filesystem with other case-semantic.
Use equal casing. Compare these module identifiers:
* C:\Users\artur\AppData\Roaming\npm\node_modules\nuxt\node_modules\process\browser.js
    Used by 1 module(s), i. e.
    C:\Users\artur\AppData\Roaming\npm\node_modules\nuxt\node_modules\regenerator-runtime\runtime.js
* c:\Users\artur\AppData\Roaming\npm\node_modules\nuxt\node_modules\process\browser.js
    Used by 1 module(s), i. e.
    c:\dev\spa\node_modules\axios\lib\defaults.js

Thanks for clarification,

It doesn't seem to be a Nuxt error.


Long words don't get clipped inside the select container

What is affected?
Component
Description
A picture worth a thousand words

Whenever a long word is selected, the label inside the select doesn't get clipped so the text extends outside the container.
The expected behavior would be to have the label get clipped (with ellipsis probably?) based on the available space inside the select, prioritizing leading or trailing icons, just like it happens with text fields.
Reproduction
Lit repro
Workaround
I have not found a workaround
Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Affected versions
14.0.0
Browser/OS/Node environment
Browser: Version 120.0.6099.225 (Official Build) (64-bit)
OS: Windows 11 Pro 22621.3007
Node version: v20.11.0
npm version: 9.6.7

It seems like this is an issue in field which was never an issue with textfield because of the native behavior of <input>


Implemented Kahan summation algorithm for adding process noise

Each time there is a covariance matrix update we add process noise to the variance of each state.
For the delta angle and the delta velocity bias variances these contributions can be so small compared to the actual variance that they get lost due to numerical limitations when dealing with floating point variables.
One solution for this problem is to use the Kahan summation algorithm which relies on an accumulator variable which captures the small increments that would get lost otherwise.
For more details, see https://en.wikipedia.org/wiki/Kahan_summation_algorithm
Thanks to @priseborough for helping debug this issue and thanks to @jkflying for suggesting the algorithm.
Delta velocity z bias variance prior to this change:

Delta velocity z bias variance after this change:

I also compared the results of this PR against the previous code when the delta velocity bias noise was set very high (0.3 m/s/s/s) in order to see if both implementations lead to similar variances. The figure below shows that this was the case.

This is a replay log file from an S500 which has been used for validation:
https://logs.px4.io/plot_app?log=7ebfbbc0-d9ed-4e4f-92f0-e9ab73f0016f

@jkflying @priseborough I addressed your comments.

There are no issues with the code, however I am hesitant to merge this so close to a major release because it requires a change to the default parameter in ekf2 module which will need flight hours on different platforms to validate the new process noise value.

PX4/Firmware v1.9.0-rc2 has been tagged and from now on and i have been told it will now only update with bug fixes, so we can now carry on with getting a sensible value for the noise variance, include that default with this PR and also the corresponding one on the firmware side. I will do some replay testing tomorrow.

My testing on replay is showing that the kahanSummation function is not working as expected and the _delta_vel_bias_var_accum variable is always returning as zero.
See debug output added here: https://github.com/priseborough/ecl/tree/pr601
Replay with with EKF2_ACC_B_NOISE = 0.0006 gives:

At a larger values of EKF2_ACC_B_NOISE = 0.06 that just raise the variance off the lower limit I get the same variance before and after the PR changes are applied, eg:
Before:

After:

@priseborough in order to ensure the compiler does not optimize the algorithm away, we'll need to disable -funsafe-math-optimizations (in particular -fassociative-math, which is set by -funsafe-math-optimizations). It's here: https://github.com/PX4/Firmware/blob/master/cmake/px4_add_common_flags.cmake#L54

@bkueng Maybe another way would be to declare the accumulator volatile, or to add __attribute__ ((optimize("no-fast-math")))  above the Kahan function declaration?

That's also fine with me, but I think we need to be very careful with enabling flags like -fassociative-math on a global scope.

It was probably added to reduce flash size, I know that often things like matrix calculations get enormously reduced using these flags. But there might be other cases where this is causing an issue, so yeah, we really need to be careful.

I will try the method using volatiles in replay.

I have confirmed on replay that making the t and y floats volatiles fixes the problem reported.

I'd rather explicitly disable the optimization with the attribute than use a volatile.
Yet another option would be moving Ekf::kahanSummation to a dedicated compilation unit and removing the optimization flag at the cmake level .

IMO the optimization flag itself is dangerous, but if it reduces binary size a lot and potentially increases performance I understand, even if it might be problematic here.
The attribute won't work on clang builds, and there is no equivalent way of doing it inline like that for clang. I really don't want there to be different behavior in something as fundamental as the ECL based on compiler used. It would be impossible to debug.
The CMake and different compilation unit will work, but then the kahan summation is scattered across a few different files, and it seems easy for a change to be made in the build system (CMake include orders, for example) which would silently break this. We don't have unit tests to make sure it is working, and if we did they would need to be in Release builds with all optimizations on for me to really trust them.
volatile is ugly from a "that's not what volatile is meant for" perspective, but seems to me the most likely to be robust, least effort, and won't silently break in the future.
I'm a bit torn here. If we aren't planning to support clang, then the attribute is better, but then we need to make it clear that clang is broken.

I'm not opposed to dropping -fassociative-math either across the entire ecl/EKF or PX4-wide for that matter. The flash savings are minor and so far I'm not seeing any significant performance differences on the bench (obviously needs significantly more testing).

Relevant GCC math optimizations

-funsafe-math-optimizations # Enables -fno-signed-zeros, -fno-trapping-math, -fassociative-math and -freciprocal-math

-fno-signed-zeros	# Allow optimizations for floating-point arithmetic that ignore the signedness of zero
-fno-trapping-math	# Compile code assuming that floating-point operations cannot generate user-visible traps
-fassociative-math	# Allow re-association of operands in series of floating-point operations
-freciprocal-math	# Allow the reciprocal of a value to be used instead of dividing by the value if this enables optimizations

-fno-math-errno		# Do not set errno after calling math functions that are executed with a single instruction, e.g., sqrt

Yes, sounds like we should be dropping those in general.

Here's a PX4/Firmware side PR for testing. https://github.com/PX4/Firmware/pull/12096

Ok, so how about we use the volatile as a temporary workaround, and once we've updated the flags in the firmware we can get rid of the volatile.

Ok, so how about we use the volatile as a temporary workaround, and once we've updated the flags in the firmware we can get rid of the volatile.

That's fine as long as we don't completely move on and forget about https://github.com/PX4/Firmware/pull/12096.
Here's the cmake level solution. https://github.com/PX4/ecl/blob/e4c31c30f746205a973dfae7aaef8dc5c3429d0c/EKF/CMakeLists.txt#L58

Here's the cmake level solution.
https://github.com/PX4/ecl/blob/e4c31c30f746205a973dfae7aaef8dc5c3429d0c/EKF/CMakeLists.txt#L58

I think you mean -fno-associative-math?

So we wait for the firmware change, ensure there are no unexpected effects, then merge this. My limited replay testing so far has shown that the exisiting tuning parameter is OK to use, but that was one flight log from one vehicle.


New sections: Interval rootfinding, nonlinear solvers, BVPs, and optimization

Some of them just have stub benchmarks for now.

@Vaibhavdixit02 @yash2798 @ErikQQY make note that this will add the benchmark sections we can start populating.


@beforeGroups executed multiple times when tests run in parallel, once if not parallel

TestNG Version
6.14.2
Expected behavior
The method with the "@beforeGroups" annotation should only run once, regardless of the fact that I'm running tests in parallel.
Actual behavior
The "@beforeGroups" method runs as many times as I have thread-count (suite.xml details below)
Is the issue reproductible on runner?
[X] Maven
Test case sample
suite.xml has one <test> block, with multiple classes. Those classes extend a single class that has the @BeforeGroups method for a particular group, of which almost all the classes have tests in that group.
The <test> block also has parallel=classes and thread-count=6 -- my desire is to run no more than 6 tests in parallel (which it does). But for all the tests in that group, I only want the @BeforeGroup method to execute once, total. I don't want it to execute multiple times just because I want to speed up execution by running some tests in parallel.
I'm hoping that what I'm seeing is some artifact of me misconfiguring the suite.xml or a testNG bug, as opposed to working-as-expected. Shouldn't it only run once? There is no @BeforeGroup method anywhere in any of the classes, except for the one class that the other classes extend.

Excellent, thanks @krmahadevan! Looking forward to testing a fix.


Improve the README

The current readme has some small issues that make it less-than-useful for its primary purpose of describing to normal ringers what Wheatley is.  Ideally we'd have a website for Wheatley (along with download links for packaged versions), but in the mean time I think a small overhaul of the README would go a long way.

Checklist:

[ ] Add some mention of needing Look To
[ ] Re-order the examples so that more useful examples are first
[ ] Add a big list of all the options and what they do
[ ] Add a contents page

I wrote a simple Win10 installation guide while helping someone install Wheatley. It's here as a PR in case you'd like to include it to help others.

If I made a very basic website that could

hold instructions for install
description of flags
generation of python command for those less technical

Would that be ok with you?
No promises but if I get the time i'd be up for it if it would be helpful

Yes absolutely - this has been on my list for a while!
I don't think we need to make a separate website from scratch, though - I think it would be best if the content of the website were stored in this repository (probably written in something like markdown) and then published using GitHub pages.  This works very nicely (I use it for my own personal site), and has a few big advantages:

Anyone can modify it through PRs (but we still get final say so bedlam can't occur).
No one person has to shoulder the burden of its maintenance.
We can keep any documentation completely up-to-date with the code (we do have to be careful about the fact that the master branch will always be ahead of the currently released version, but IMO this is still easier than trying to keep loads of different pieces of code in sync.  I think there's much to be gained by rethinking how releases work anyway).
It looks pretty by default, and if we really want control over looks we can use something like Zola to generate the HTML for us.
Hosting is free, and we can buy some domain wheatley-ringing-bot.co.uk if we want that level of control (though personally I can't see anything to be gained over wheatley.github.io).

I think that the README is fine now - it does everything that a README should do, and if we add any more docs then they would be better hosted as a custom website.


App not received notification in background (ios & android)

Hi i use react "~15.4.1", react-native "0.42.0" react-native-fcm "^6.2.1" (and "Firebase/Messaging" via pod)
I do all the installation steps and follow the usage but i can get notifications only if the app is open.
any idea?

On the previous version, it works well, but after I updated the RN version - react "16.0.0-alpha.6", react-native "0.43.3", react-native-fcm "^6.2.0", App doesn't receive notification.

Work on android.
On ios still the same problem.

have you uploaded APNS cert to firebase?
are you using a real device?

Same problem here, works great on all android devices,  ios < 10,  but not on ios 10.3.1, no push received.

@cfournel any other iOS 10 version? like 10.1? It have been working for me for iOS10

@evollu I didn't test on 10.1 yet, sorry

bump


pull request template

What's this PR do? Any additional context?
It creates a pre-populated pull request template
Where should the reviewer start?
I'd recommend starting in the file called PULL_REQUEST_TEMPLATE.md
How can this be manually tested? (brief repro steps)
Yes. Submit a pull request in oxa-tools after this change is merged
What are the relevant TFS items? (list id numbers)
94659, 94660
Definition of done:

[x] Title of the pull request is clear and informative
[x] Add pull request hyperlink to relevant TFS items
[x] For large or complex change: schedule an in-person review session

Reminders BEFORE merging

Get at least two approvals
If you're merging into the development branch then "flatten" or "squash" commits
If merging from development into master then don't "flatten" or "squash" commits

Reminders AFTER merging

Delete the remote branch
Resolve relevant TFS items
(reverse merge) If you merged into master then check to see if there are any changes in master that can be merged down to the development branch (like hotfixes, etc)

Can we also have a section to define acceptance criteria ?

mani and i spoke offline. we won't add acceptance criteria at this time since it can easily get out of sync with the tfs content. i think the better solution is to move to an "open" issue tracking system (like the one github provides or maybe one like uservoice.com that allows for customers to vote on issues that they want most or maybe we snap to whatever issue/bug/feature tracking system edx uses).


Add tests

Created Unit Tests which cover previously uncovered lines and which I want to contribute.

Here we go regarding the exception detection code style.

Coverage increased (+0.06%) to 98.222% when pulling 49c25105742f9dc75a1a51800799c08f4f1c8434 on TheRealHaui:add-tests into 6773be0a357988126d22decb82e75f601d9814b9 on apache:master.

Coverage increased (+0.06%) to 98.222% when pulling 49c25105742f9dc75a1a51800799c08f4f1c8434 on TheRealHaui:add-tests into 6773be0a357988126d22decb82e75f601d9814b9 on apache:master.

Thanks! :+1:


CODE RUB: NullChatCompletionException Class Update v2.10.1

Updated NullChatCompletionException class by removing constructors in which the error message was hard coded in. Updated all relevant service files to include message.

Closed Pull Request. Resolved in PR #556.


Add command switch and command enum

Fixes formating.
Add code.
Due to technical issues i decided to delete old branch and start a new one.
Fixes problem with old unsigned commit.
Fixes problem with bad uncompilable commit.
Fixes problem with 33 other commits that had snuck there way unto here that should not have ben here.
Fixes problem with push rejection after rebase.

Did big change. Need feedback on this.
@safstromo
@MikaelEdwartz

This is what i mean with my earlier comment.
Maybe im missing something, or is it the from text method in Commad class where you are gonna convert the input to command?

@safstromo
Im probably more confused than you are here haha.
The text in front of the command will be the String argument for a method call. I think they need to have one?
In the latest commit you would have to type something like:
"commandSwitch.command(Command.valueOf("SET"));"
When you do the method call but I agree its much cleaner to have it in the switch method instead.

Unless I'm missing something, which is not only possible but also very likely, somewhere in the program we will have to split the Strings we receive from the user for example "LPUSH key1 Val2" so that LPUSH calls the method LPUSH and "key1 Val2" will be set as the placeholder text sended to the method called from the switch case and than probably spliced again into arguments sent into the LPUSH call.

@safstromo
What do you think about just designing it like this instead of using ENUM?
Its a lot more easy to understand for me.

This is basically the same as what we have today in main.

The reasoning behind the enum was to lockdown all commands to constants to prevent misspelling and to easy maintain and read in the future.
Maybe we should just close this issue for now and come back in the future if needed?
Sorry for wasting your time.


License not set in PKG-INFO

As in title.  Would be nice if UNKNOWN was replaced with "BSD License".

It's already fixed in master.


Refactor Array filtering to use Array.some

Just a (very) tiny refactor.
I haven't tested this since I don't have an arduino (just saw your video on youtube. Good stuff!) but npm test passes.

Coverage remained the same at 45.802% when pulling 6302a8ac2fd42eaa56ca0b475a4e33d072a83cca on ryanbraganza:refactor-ArraySome into ba165e27cfeb75b45dffb6db2e547e09a471c905 on noopkat:master.

@ryanbraganza this is awesome, thank you so much! This code reads much nicer now 🌷
Today I learned: Array.some is not ES2015, like I thought it was! It's ES5, which means that this change is compatible with the node versions this library supports.
Thanks again 😁  and I'm glad you enjoyed my video!


Feature Request: Keyboard Shortcut

That can be expanded from this:
https://gist.github.com/tovic/f1f21602e6b682ad78d6140f505e14f3

LGTM. Would try to add to my fork. :D

Merged as https://github.com/aero31aero/markdown-editor/commit/271653d44863552a68e71f3fc4f6826b1de0eed2 on rohitt.me/markdown-editor
Thanks @tovic !

Closing this. Please refer to #77.


Give different animation for desktop and mobile.

Hi.
In the desktop version, I have 4 elements, 2 in one row and 2 in the other one.
On the mobile, I have one for a row, so 4 rows.
I want to give one animation for the mobile version and another one for the desktop version?. How can I do that?

Hi Josue,
From the top of my head and without trying you can use jQuery to detect the viewport width and remove a class and add another or probably you can do it with media queries by overriding the default css animations.
One of these options might work, if not the two..
Cheers

use different animation on different breakpoints in CSS.

Hey @josuevalrob. As @Jonathlee said you can create custom animation and use breakpoints there. Example code here https://github.com/michalsnik/aos/issues/315
Please also take a look at codepen with custom animations linked in readme.

thanks!


[HUDI-1160] Support update partial fields for CoW table

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
Support update partial fields for Cow table
Brief change log
(for example:)

Support update partial fields for Cow table, currently, when updating hudi table, users have to provide all fields, however in some cases, users would not provide all fields, and hudi needs to support update partial fields.

Introduce PartialUpdatePayload

Verify this pull request
(Please pick either of the following options)

Add UTs

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@vinothchandar @bvaradar please take a look when free

@satishkotha Can you please help review?

@leesf Any update? Let me know if you need any help here

@leesf Any update? Let me know if you need any help here

ack, will update the PR ASAP

@leesf Any update? Let me know if you need any help here

ack, will update the PR ASAP

@leesf Any update for the comment mentioned by @satishkotha? I would like to refer to your pull request for the work of HUDI-1161.

@leesf are you still pursuing this?

@leesf are you still pursuing this?

yes, will update the PR when free

@leesf : do you think we can get this in by next week for upcoming release cut?

@vinothchandar : do you think we can make this a blocker?

@vinothchandar : do you think we can make this a blocker?

@liujinhui1994 takes over this work, would you please share the progress

I’m working on it now, but encountered some parquet-related issues in the process. Today I will PR to discuss
@leesf

Can be completed today, and PR
@leesf

@liujinhui1994 : please let me know once you have addressed all comments and rebased w/ latest master.

FYI: we have another PR open to support similar feature just for preCombine.

@nsivabalan   This PR has been modified based on the comments，
https://github.com/apache/hudi/pull/2666
Please review

Closing in favor of https://github.com/apache/hudi/pull/2666


Add documentation for BroadcastChannel in Orleans 7.0

Issue description
Orleans 7.0 replaced SimpleMessageStream with a separate abstraction, BroadcastChannel.
We need TOC changes and a documentation section for BroadcastChannel.
For more information, see: https://learn.microsoft.com/en-us/dotnet/orleans/whats-new-in-orleans#replacement-of-simplemessagestreams-with-broadcastchannel
xref https://github.com/dotnet/docs/issues/32734
cc @IEvangelist @benjaminpetit

Associated WorkItem - 46071

NOTE: We should include advice on when to use BroadcastChannel and when to use Streams (incl MemoryStreams).
We should note that BroadcastChannel only supports implicit subscriptions.

Related to https://github.com/dotnet/orleans/issues/8203

An important part is missing in the documentation. What exactly is a ChannelId, especially the Key part? I opened a separate issue Broadcast and ChannelId · Issue #8292 · dotnet/orleans (github.com)


Typeahead expression search doesn't hit Bean Method with b

Describe the Bug
The word bean seems not to hit Bean Method expression in typeahead search.
Steps to Reproduce the Bug or Issue

add setHeader step
configure expression
type b

Screenshots or Videos

Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 0.30.0]

Since the model name for Bean Method is method, it would need to look at the other field like name or description


Hosts File Editor shows wrong picture (Always on Top)

Microsoft PowerToys version
0.67.0
Installation method
GitHub, PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
Hosts File Editor
Steps to reproduce

Open Powertoys Settings
Open Hosts File Editor

✔ Expected Behavior
The Hosts File Editor preview picture shows a preview of the Host File Editor.
❌ Actual Behavior

This is the preview picture of "Always on Top"
Other Software
No response

This issue has been fixed in the 0.67.1 release. Please update PowerToys to get it. Thank you!


Create SECURITY.md

Hi @lapakiosstore please explain further what is the Pull Request, or it will be considered as invalid and will be closed. thanks

Closed due to lack of explanation from submitter


Update snapshots.md

Added a notice about compiling or previewing snapshots in the IDE as CS has been receiving some convos asking us about this due to an error message they receive. Noticed added in line 60 as a block - and posted this in the slack customer feedback channel: https://dbt-labs.slack.com/archives/C019QLR6EJE
Description & motivation

To-do before merge

Pre-release docs
Is this change related to an unreleased version of dbt?

[ ] Yes: please

update the base branch to next
add Changelog components: <Changelog>[New/Changed] in v0.x.0</Changelog>
add links to the "New and changed documentation" section of the latest Migration Guide

[ ] No: please ensure the base branch is current
[ ] Unsure: we'll let you know!

Checklist
If you added new pages (delete if not applicable):

[ ] The page has been added to website/sidebars.js
[ ] The new page has a unique filename

If you removed existing pages (delete if not applicable):

[ ] The page has been removed from website/sidebars.js
[ ] An entry has been added to _redirects

Ah I approved too soon! It looks like your markdown isn't populating correctly. Are you wanting this to be a callout of sorts? Here's a picture from the preview!

Ah no! Yes i'd like it to be a callout like so and i tried copying it from
the previous examples
On Wed, Nov 10, 2021 at 1:59 PM Alexandra Bethea @.***>
wrote:

Ah I approved too soon! It looks like your markdown isn't populating
correctly. Are you wanting this to be a callout of sorts? Here's a picture
from the preview!
[image: image]
https://user-images.githubusercontent.com/60658459/141126411-ca095d2f-2791-4a1d-88e6-47bf85876bc6.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dbt-labs/docs.getdbt.com/pull/840#issuecomment-965208120,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVHCTI7ML4AKIYV3Y3FBYWDULJ3FDANCNFSM5FLD436Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Block Exclusive Zone

Description
A new class of entities in Spur, with its position in the overall architecture similar to that of the Jitter class, i.e., like a property attached to a component. When there is a "critical" / "exclusive" section of components that can collectively only hold a single train at a time, an instance of the "block exclusive zone" (BEZ) class will be associated with each component (specified in the input file as an extra field in each component, similar to how jitter is specified). The BEZ instance will be identified uniquely by name.
If the critical section is occupied, additional trains attempting to enter it (i.e., the direction of travel is into the section) will be held and placed into a queue in the BEZ instance. Once a train leaves the critical section, the section is free. The next train in the queue is allowed through, which could be entering from either end of the section.
Parameters

Name (unique)

Logic

BEZ class object:

Maintain a Boolean state variable of whether the critical section is occupied
Maintain a queue structure of trains waiting to enter the critical section

Component with an associated BEZ instance:

When a train requests use of the component [this is the function that SpurResource will call to determine if it should accept the train into the component]:

Check if the train's previous component has the same BEZ instance as the current one it is trying to enter

If yes: train is staying in the same critical section, decide whether to accept the train based on component-specific factors
If no: train is entering critical section

Check if train is already on the queue in BEZ instance

If no: append train to queue in BEZ instance

Check if section is unoccupied AND if the current train is at the head of the queue:

If yes: dequeue the train, update state to occupied in BEZ instance, accept the train
If no: reject the train

When a train is being released from the component:

Check if the train's next component has the same BEZ instance as the current one it is leaving

If yes: train is staying in the same critical section, proceed with the release of the train
If no: train is leaving critical section

Update state to unoccupied in BEZ instance, proceed with the release of the train
Check the head of the queue in BEZ instance - if the train is requesting to enter the critical section from a component other than the current one, proactively call the method to process the request from the resource of that component

(if the next train in the queue is requesting to enter from the current component, the request will be processed automatically as the previous train leaves, handled by SimPy)

Closed as completed (PR #68)


Blog edit

Blog post edit
How can this be tested

[ ] clone the repository to your local machine
[ ] set up your database
[ ] run the application
[ ] log in with a super admin details(Can test with postman)
[ ] access the endpoint at http://localhost:8080/api/v1/blog/blog/edit/{id} with edit_request json body
it should be successful and return status code 200
[ ] access the endpoint with am empty title in the edit_request json body
it should return status code 422(UNPROCESSABLE_ENTITY)
[ ] log in with a user details(User with role USER)
[ ] access the endpoint at http://localhost:8080/api/v1/blog/blog/edit/{id} with edit_request json body
it should return a status code 403(FORBIDDEN)

How was this implemented

[x] created schema for blog with fields: title, content and tags[]

CREATE TABLE blogs (
    id BIGINT PRIMARY KEY,
    blog_id VARCHAR(36) UNIQUE,
    title VARCHAR(100) NOT NULL,
    content TEXT NOT NULL,
    image_urls TEXT[],
    tags TEXT[],
    author VARCHAR(255),
    created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
    updated_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP
);

-- Create trigger function for update column
CREATE OR REPLACE FUNCTION update_updated_at_column()
RETURNS TRIGGER AS $$
BEGIN
    NEW.updated_at = CURRENT_TIMESTAMP;
    RETURN NEW;
END;
$$ LANGUAGE plpgsql;

-- Create trigger to call the function before any update
CREATE TRIGGER set_updated_at
BEFORE UPDATE ON blogs
FOR EACH ROW
EXECUTE FUNCTION update_updated_at_column();

[x] created dto objects for data transfer to and from the endpoint
[x] created the data layer and implemented the business logic to ensure proper tags format
[x] configured the role-based access in web_security_configuration class
[x] configured the blog controller accordingly

fix branch name to match accepted convention

@Am0du
@Fifetoyi

resolve your conflict


fix after GROOVY-7574: Always do null checks in ObjectRange constructor

This is a small fix after the recently merged #141 moving null-checks. I hope it is small enough to be quickly merged.

Thanks! :+1:


python*Packages.msgpack-numpy: Update wrong description

Motivation for this change
Description is wrong (this library has nothing to do with NLP or machine learning). Looks like a mis-paste from pkgs/development/python-modules/thinc/default.nix.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Good catch, thanks!


Fix #91 (spec_date_to_iso8601)

Fix for #91
Added unit tests for spec_date_to_iso8601.
Nominal tests only.
The zone keyword is not tested. I haven't added tests for the error cases either.
I checked that the new tests fail with the previous version of the function.
BTW the function only works if the provided spec dates are in english (Mon, Apr, Aug, Sun, ....). Are we sure this will always be the case?

I have investigated Jérôme's suggestion of using datetime. It could simplify the function, especially if we expect to add more date formats in the future. Initially I expected SPEC to write a single format.
>>> from datetime import datetime
>>> d = datetime.strptime('Thu Feb 11 09:54:35+0100 2016', '%a %b %d %H:%M:%S%z %Y')
>>> d.isoformat()
'2016-02-11T09:54:35+01:00'
>>>
>>> d = datetime.strptime('Sat 2015/03/14 03:53:50+0200', '%a %Y/%m/%d %H:%M:%S%z')
>>> d.isoformat()
'2015-03-14T03:53:50+02:00'

Des anyone have any objection to rewriting the entire function?

I think this works only if you set the locale.LC_TIME right.
e.g :
d = datetime.strptime('Mo Feb 11 09:54:35 2016', '%a %b %d %H:%M:%S %Y')

doesn't work if the computers locale is set to german (locale.setlocale(locale.LC_TIME, 'de_DE.UTF-8'))
It expects this :
d = datetime.strptime('Do Feb 11 09:54:35 2016', '%a %b %d %H:%M:%S %Y')


Add link to containerd project branding page

This PR adds a link to the new CNCF project branding site: https://branding.cncf.io/projects/containerd/

@mikebrow I don't have merge privileges so you can do the honors 👍


Is there any way to get the native camera inside container in my app?

Discussed in https://github.com/react-native-image-picker/react-native-image-picker/discussions/1918

Originally posted by champikamendis January 12, 2022
I want to open the camera inside a component or container in the app. Can I is there any way to do that with this library?

Answered in dicussion


How to connect to mupx mongodb externally

I use to be able to access my mongo database in mup using the following http://blog.codehatcher.com/mongodb-ssh-access-on-remote-meteor-deployment and it made a lot of the maintenance, backup, restoring, and testing very convenient. Basically, SSH in then connect to the localhost.
I'm trying to do something similar with mupx but can't figure out what I am missing, could use a little help with this. Thanks in advance from a long time user and fan

I don't think that you can do this since mupx is using a docker container to host your application.
You can only access your mongodb if you login to your server and execute
docker exec -it mongodb mongo <appName>
Read this here:
https://github.com/arunoda/meteor-up/tree/mupx#accessing-the-database

Kind of a shame but really appreciate the follow up. If someone comes up with a clever solution to this, let me know
Sent using CloudMagic Email [https://cloudmagic.com/k/d/mailapp?ct=pi&cv=7.6.23&pv=9.2.1&source=email_footer_2]
On Mon, Aug 8, 2016 at 11:07 AM, Ihor Brmk<EMAIL_ADDRESS>wrote:
I don't think that you can do this since mupx is using a docker container to host your application.
You can only access your mongodb if you login to your server and execute
docker exec -it mongodb mongo
Read this here:
https://github.com/arunoda/meteor-up/tree/mupx#accessing-the-database [https://github.com/arunoda/meteor-up/tree/mupx#accessing-the-database]
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [https://github.com/arunoda/meteor-up/issues/1106#issuecomment-238325310] , or mute the thread [https://github.com/notifications/unsubscribe-auth/AFHNVpyXsb5uiGL2L1hheuw3IHIoI3CJks5qd3BugaJpZM4JezjX] .


Klarstein Wonderwall 600w

I've dumped the image from a "Klarstein Wonderwall IR Heater".
Firmware is v7.0.2.
Does any informations are needed?
klarstein-wonderwall-600w.bin.zip

A profile as been added as Klarstein Wonderwall Air 60 Infrared Heater


Merge latest changes from upstream crypto/acme library

What this PR does / why we need it:
This PR merges in the latest changes from the upstream crypto/acme CL here: https://go-review.googlesource.com/c/crypto/+/86635
Release note:
NONE

I am curious why https://go-review.googlesource.com/c/crypto/+/86635 was chosen as upstream. Seems like that PR has not been officially checked in.

I am curious why https://go-review.googlesource.com/c/crypto/+/86635 was chosen as upstream. Seems like that PR has not been officially checked in.

Never mind. I think I found the answer. cert-manager wants to work with LetsEncrypt V2. However, currently golang crypto/acme library does not support V2. That pending PR has the work of supporting V2.
It would be good if that pending PR could be merged soon.


Framework 3.7 - Invalid table name in php 7.4

framework 3.7.x-dev
PHP 7.4
The when initializing unit test DataObjectLazyLoadingTest will call SapphireTest::resetDBSchema() - there's a misnamed unit test only table name from another test DataObjectTest\NamespacedClass that attempts to get created
This failed "gracefully" in php 7.3 and below because array style access on non-arrays was allowed and simply resulted in null.  This behaviour was removed in php 7.4 https://www.php.net/manual/en/migration74.incompatible.php and results in Trying to access array offset on value of type bool
This can be seen in travis here https://travis-ci.com/github/silverstripe/cwp-recipe-basic/jobs/510267889 Update: job was re-run after fix was merged and error is no longer visible
Related
https://github.com/silverstripeltd/product-issues/issues/437
PRs

[x] https://github.com/silverstripe/silverstripe-framework/pull/9962

Do you think this warrants another patch release of 3.7 @emteknetnz? I feel like it does and I can't think of what else we would wait for before doing this.

If you want.  Could possibly wait for something around resolving deprecated warnings, though it's only a patch release so really is no reason not to - you want me to do this now?

you want me to do this now?

Yes please. If there's further changes that warrant another release, we can look at that then

Cool, I tagged 3.7.7


Does arangodb setup dpkg trigger on apt-get install ?

Hello,
I have arangodb installed and running fine. I am now trying to use apt-get install pstack (or any other program) it fails with "Setting up arangodb (2.6.2) ...

Starting arango database server arangod                                                                                2015-09-21T20:49:27Z [11915] FATAL cannot start server: database directory is locked
More error details may be provided in the logfile '/var/log/arangodb/arangod.log'
database version check failed, maybe need to run 'upgrade'?
invoke-rc.d: initscript arangodb, action "start" failed.
dpkg: error processing package arangodb (--configure):
subprocess installed post-installation script returned error exit status 1
Errors were encountered while processing:
arangodb
E: Sub-process /usr/bin/dpkg returned an error code (1)
"

Does arangodb setup dpkg triggers ?

In case of installing a newer arangodb version it is intended that --upgrade has to be run by hand. You may eventualy want to prepare such an upgrade by doing a lvm snapshot or triggering a backup.
After that you can finish the setup like that:
Stop arangodb again, and use
dpkg --pending --configure

to re-invoke the config scripts. After that the package database will have set the arangodb package to configured, and will not invoke it unless you upgrade to the next arangodb version (again).


docs: Add a contributing.md

@acburdine any other suggestions?
I plan to add more later, about debugging and submitting PRs and issues.

I don't think it needs to be installed globally the first time, since denali-cli is present, and we use npm run build, which uses the internal node_modules/.bin directory to find "globals".

It's not about having denali-cli installed, as yeah that is included in denali's dependencies itself, but I'm talking about the actual denali build command, the code for which is here: https://github.com/denali-js/denali/blob/master/commands/build.ts . Because the command itself won't exist, then denali won't be able to be built.

@acburdine I added a couple more sections

Went ahead and merged this just to get something in there -we can tweak if needed.


[proxy] Do not fail after parquet upload error

Problem
If the parquet upload was unsuccessful, it will panic.
Summary of changes
Write error in logs instead.
Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

Looks good, but please fix up the postgres submodule changes


not saving on disk

It seems after insertion, data is not saved on disk,
any idea ?

It is documented in the README
-- Required fields: table_name, vector_name, dimension, max_elements
-- Optional fields:
-- 1. distance_type: defaults to l2
-- 2. ef_construction: defaults to 200
-- 3. M: defaults to 16
-- 4. random_seed: defaults to 100
-- 5. allow_replace_deleted: defaults to true
-- 6. index_file_path: no default value. If not provided, the table will be memory-only. If provided, vectorlite will try to load index from the file and save to it when db connection is closed.
create virtual table {table_name} using vectorlite({vector_name} float32[{dimension}] {distance_type}, hnsw(max_elements={max_elements}, {ef_construction=200}, {M=16}, {random_seed=100}, {allow_replace_deleted=true}), {index_file_path});

Here's an example

Currently, a full table scan is deliberately disabled because I want to discourage slow queries. So for now, your query will return an empty set (or be rejected?).
Of cource it is possible to implement full table scans. It can be useful when a user loses track of what data have been inserted and wants to inspect the table. I'll try to implement it in version 0.3.0 or 0.4.0.


confd template should support src with absolute path

The current src only support relative path.
src (string) - The relative path of a configuration template.

why not it support absolute path
https://github.com/kelseyhightower/confd/blob/master/docs/template-resources.md

Is there any chance we can add support for this? Just to give flexibility to those that need absolute paths?


[5.4] Allow lowercase JSON keys with ucfirst

Enables the user to uppercase the first letter (for a title example), without having to provide upper & lowercase versions.
Also allows the user to keep lowercased JSON keys in the language file, but still force the text to be uppercased in relevant situations.

No plans on adding this to core. You can define it yourself if you want.


Feat/Receive CJIT

Description
Implements CJIT into Bitkit's receive flow.
Type of change

[x] New feature (non-breaking change which adds functionality)

Tests

[x] No test

Screenshot / Video
https://github.com/synonymdev/bitkit/assets/8532651/a48e9475-b55a-41db-b84f-423d3b12aaf8
QA Notes
The CJIT flow is triggered by two events:

The user has no lightning channels available and they tap the "Receive Instantly" switch in the receive view.
The user attempts to create an invoice for an amount greater than their inbound liquidity, but within the acceptable range of Blocktank's limits.

When trying to pay a CJIT invoice from my other simulator I always get "No usable channels found" first, and on "Try Again" it works.

After the server reboot this morning, I was able to successfully complete CJIT payments from one iOS simulator to the other without failure. Hopefully you should no longer have an issue on the first few payment attempts.
Both simulators were new wallets. One with a fresh lightning channel via the normal onboarding, the other with an empty balance for creating the CJIT invoice.

Can you add this? Minimum amount and back button:

Added UI elements for Receive Instantly here.


setThemeByRoute doesn't work with all pages

Version 8.5.2
In the Packages Controller this doesn't work:
    public function on_start()     {         \Route::setThemeByRoute('/members', 'themehandle');         \Route::setThemeByRoute('/account', 'themehandle');     }
but in /config/app.php this works fine:
return [ 	'theme_paths' => array( 		'/account'          => 'themehandle', 		'/account/*'        => 'themehandle', 		'/members'          => 'themehandle', 		'/members/*'        => 'themehandle', 	), ];
So it would be great if a Theme can override all pages.

There shouldn't be any difference in what happens in app.php and what gets run from on_start(). Was the package installed?

Yes, the package was installed. It's my own Theme.


[feat] Hide symbols in winbar

Is your feature request related to a problem? Please describe.
I like have the symbols in the winbar but I prefer a more minimal look of the winbar. Using custom_kind and the LspSagaWinbar highlight groups, I can edit the appearance of the symbols and make the text darker. However, I cannot remove the icons.
Describe the solution you'd like
Something like
symbols_in_winbar = {
  enable = true,
  show_icons = false,
}

Describe alternatives you've considered
I set all icons to "" using custom_kind. This works except for the filename, where the devicon is always used.
And it is an overkill: I would like to keep the icons overall, just hide them in the winbar.
Additional context
Current look of my winbar:

maybe you can write a custom winbar .the README have a example to write own winbar.

A custom winbar requires a decent amount of code in the config. The icons need to be removed from the get_symbol_node() output with pattern matching, which feels wrong since they were initially added to the output. I understand if you don't want to add this level of customization to the config, I will just stick with what I have :+1:

maybe we can adda clean_mode no any icon


How can I old image file migration?

Hello~
I was setup a Migration Sever on AWS
and also include code what S3 file upload code like below

However I don't know what old image file migration

How can I migration?

Use a fileKey as suggested in the migration guide and docs.


Update CI image

Description

Use windows-latest vmImage

Motivation and Context

Windows 2019 image is deprecated.

Types of changes

[ ] Improvement (correction, content improvement, typo fix, formatting)
[ ] New Article (new document for docs website)
[x] Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

[ ] My doc follows the code style of this project.
[ ] I have read the CONTRIBUTING document.

CI fail due to ERROR: Couldn't find './samples/Program.cs' in nanoFramework.IoT.Device\devices\Pcd8544\README.md

Further fixes required... TBC!
https://dev.azure.com/nanoframework/nanoframework docs/_build/results?buildId=37870&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=b1657ed2-8cf9-53e1-bfff-c661b553db41

Closing as work is being done in https://github.com/nanoframework/nanoframework.github.io/pull/155


Collect http routes into single module

The purpose here is to simplify the code (views files now only contain handlers and no use of flask Blueprints) and all routes are defined in a single file to make it easier to see the http api at a glance.

Perfect
Get that travis going and you're good for merging

Current coverage is 96.17% (diff: 100%)

Merging #1022 into master will increase coverage by 0.19%

@@             master      #1022   diff @@
==========================================
  Files            35         36     +1
  Lines          1794       1831    +37
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1722       1761    +39
+ Misses           72         70     -2
  Partials          0          0

Powered by Codecov. Last update 3d74bfb...1d234d3


Static Instance Preload Scene read corruption

Godot version
v4.1.1.stable.official [bd6af8e0e]
System information
Godot v4.1.1.stable - macOS 13.5.1 - Vulkan (Compatibility) - AMD Radeon Pro 580X OpenGL Engine - Intel(R) Core(TM) i5-9600K CPU @ 3.70GHz (6 Threads)
Issue description
https://github.com/godotengine/godot/assets/628713/20ee0edf-0c0a-425d-8ee3-295f0ab8ba91
static var scene: PackedScene = preload("res://example.tscn") in a script attached to a Node saved as example.tscn, when reloaded in Godot, makes the example.tscn file unable to be opened in Godot.
It does work when running your project however, and if that line is commented out in the script and the project reloaded, then the scene is editable again.
Steps to reproduce
Create the following files:

example.gd:

extends Node

static var scene: PackedScene = preload("res://example.tscn")

example.tscn: A scene with a Node root with the example.gd script attached.

Reproduce the error

Click Project -> Reload Current Project
Open example.tscn
Observe error alert Scene file 'example.tscn' appears to be invalid/corrupt.
Observe console output:

scene/resources/resource_format_text.cpp:283 - res://example.tscn:6 - Parse Error:
  Failed loading resource: res://example.tscn. Make sure resources have been imported by opening the project in the editor at least once.
  scene/resources/packed_scene.cpp:92 - Condition "nc == 0" is true. Returning: nullptr
  editor/editor_data.cpp:880 - Index p_idx = 2 is out of bounds (edited_scene.size() = 2).
  editor/editor_data.cpp:683 - Index p_idx = 2 is out of bounds (edited_scene.size() = 2).
  editor/editor_data.cpp:745 - Index p_idx = 2 is out of bounds (edited_scene.size() = 2).

Minimal reproduction project
static_scene_bug_repro.zip

This is most likely a duplicate of one of #80877 tracked issues, but maybe there is some unique information. Please check https://github.com/godotengine/godot/issues/74253#issuecomment-1564227775.

Btw for whomever ends up looking into this:
It seems to occur with any preload'ed scene in a static var initialization.
static var test = preload("res://example.tscn") does it for me


AttributeError: 'NoneType' object has no attribute 'dumps'

Running fine in a docker, when i tried to run on my desktop error below came out.
Traceback (most recent call last):   File "/root/anaconda3/envs/py36/lib/python3.6/site-packages/uvicorn/protocols/http/httptools_impl.py", line 385, in run_asgi     result = await app(self.scope, self.receive, self.send)   File "/root/anaconda3/envs/py36/lib/python3.6/site-packages/uvicorn/middleware/proxy_headers.py", line 45, in __call__     return await self.app(scope, receive, send)   File "/root/anaconda3/envs/py36/lib/python3.6/site-packages/starlette/applications.py", line 102, in __call__     await self.middleware_stack(scope, receive, send)   File "/root/anaconda3/envs/py36/lib/python3.6/site-packages/starlette/middleware/errors.py", line 178, in __call__     raise exc from None   File "/root/anaconda3/envs/py36/lib/python3.6/site-packages/starlette/middleware/errors.py", line 156, in __call__     await self.app(scope, receive, _send)   File "/root/anaconda3/envs/py36/lib/python3.6/site-packages/starlette/exceptions.py", line 82, in __call__     raise exc from None   File "/root/anaconda3/envs/py36/lib/python3.6/site-packages/starlette/exceptions.py", line 71, in __call__     await self.app(scope, receive, sender)   File "/root/anaconda3/envs/py36/lib/python3.6/site-packages/starlette/routing.py", line 550, in __call__     await route.handle(scope, receive, send)   File "/root/anaconda3/envs/py36/lib/python3.6/site-packages/starlette/routing.py", line 227, in handle     await self.app(scope, receive, send)   File "/root/anaconda3/envs/py36/lib/python3.6/site-packages/starlette/routing.py", line 41, in app     response = await func(request)   File "app.py", line 58, in homepage     headers=response_header)   File "/root/anaconda3/envs/py36/lib/python3.6/site-packages/starlette/responses.py", line 42, in __init__     self.body = self.render(content)   File "/root/anaconda3/envs/py36/lib/python3.6/site-packages/starlette/responses.py", line 159, in render     return ujson.dumps(content, ensure_ascii=False).encode("utf-8") AttributeError: 'NoneType' object has no attribute 'dumps'

After some searches. I found that request.json() is clashing with some other lib.
bug:
https://stackoverflow.com/questions/11369734/python-json-module-has-no-attribute-dumps
what I did to resolve this is I created another clean conda env for gpt-2-cloud-run to run, with only required packeges stated in the dockerfile. Now it can run on my local machine with gpu.


flaky test fixed

Hi, there's another flaky test detected by our Nondex tool. It is basically the same assert statement caused the flakiness on the previous PR

Thanks again!


markdown h scrollbar broken #2500

seems like a defect in codemirror: blur event fires when we click on bkg part of a scroll.
but we can check cm.state.focused property to get to know whether the editor lost focus

:+1:


Create component to manage secondary charts

Related to #261 - this will likely need to be done before or as part of #261.

Is the idea here to have the secondaries grouped in a container?

Yes. Rather than having three containers permanently in the page and having app do lots of logic for the secondaries, the idea is to have a component which can manage this. (Complexity in layout.js should also be reduced.)
I expect it would be similar to how we use multi/Cartesian chart with the series/indicators, but rather than the renderers being rendered into the same container, each renderer would have its own container. It might look something like this:
var secondaries = multiChart() // <-- new component
    .charts([rsi, volume]);

secondariesContainer.call(secondaries);

Give me a shout if you'd like to chat through this :)


"Stănișești", "Balotești", "Belciuneasa", "Benești", "Crăiești", "Gorghești", "Slobozia", "Slobozia Nouă" and "Văleni" villages are listed in the drop-down menu

Description:
The villages are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Preconditions : the website (https://peviitor-ro.github.io/ui.orase/) is up and runing. After every step delete the text you typed from the search bar.

Step 1
Type "Stănișești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Stănișești, Bacău

Step 2
Type "Balotești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Balotești, Bacău(Stănișești)"

Step 3
Type "Belciuneasa" in the search bar.

Expected results
The location is listed in the drop-down menu as "Belciuneasa, Bacău(Stănișești)"

Step 3
Type "Benești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Benești, Bacău(Stănișești)"

Step 5
Type "Crăiești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Crăiești, Bacău(Stănișești)"

Step 6
Type "Gorghești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Gorghești, Bacău(Stănișești)"

Step 7
Type "Slobozia" in the search bar.

Expected results
The location is listed in the drop-down menu as "Slobozia, Bacău(Stănișești)"

Step 8
Type "Slobozia Nouă" in the search bar.

Expected results
The location is listed in the drop-down menu as "Slobozia Nouă, Bacău(Stănișești)"

Step 9
Type "Văleni" in the search bar.

Expected results
The location is listed in the drop-down menu as "Văleni, Bacău(Stănișești)"


As a user, I want to be able to manually rollup large numbers of donation in aggregate, but I may need to reduce the query size of the batch job to do so, so that I can rollup any number of donor/donations in my org.

Consider surfacing the query limit parameter associated with the manual rollups tab

**lurch: attach W-007347

Tracking W-007347

This can now be accomplished through modifying the batch size settings in NPSP Settings.


Update codelab to null-safety

The sound_stream package is already migrated to null-safety so the codelab can be updated using this dart feature.

Hey what about rxdart. Is it updated to null - safety.


Add the support of the load RDB command

This PR is for https://github.com/apache/kvrocks/issues/1753

Hi @xq2010 Thanks for your excellent contribution first!
About how to load the RDB file, I'm wondering if it's better to export a command to do this. For example, we can support a new command like load_rdb which allows loading RDB file from local.
$ redis-cli 6666> load_rdb /path/to/your/rdb_file

So that we don't need to introduce a new tool. How do you feel about this? cc @apache/kvrocks-committers

Hi @xq2010 Thanks for your excellent contribution first!↳
About how to load the RDB file, I'm wondering if it's better to export a command to do this. For example, we can support a new command like load $type $path which allows loading RDB file from local.↳
$ redis-cli 6666> load RDB /path/to/your/rdb_file

So that we don't need to introduce a new tool. How do you feel about this? cc @apache/kvrocks-committers↳
If we add the 'load rdb' command, we need to determine how to process an existing key that's present in both kvrocks and rdb, particularly when the key's type is a string in rdb. It will overwrite the existing key in kvrocks, which may be of a different type."

If we add the 'load rdb' command, we need to determine how to process an existing key that's present in both kvrocks and rdb, particularly when the key's type is a string in rdb. It will overwrite the existing key in kvrocks, which may be of a different type."

Yes, it's a good concern. I prefer overwriting by default if it exists and we can offer an option NX like the set command to let users determine in the future.

Yes, it's a good concern. I prefer overwriting by default if it exists and we can offer an option NX like the set command to let users determine in the future. This is my personal perspective, would like to hear more voices about the loading way design.↳

Using NX is a good idea, I would also like to hear more opinions.

Thanks for your contribution!
Agree with @git-hulk, I think it would be better to just implement it like a command inside the kvrocks process instead of a new program.

@git-hulk @PragmaTwice Okay, I will add a command to load the RDB file. The command might be rdb load  [namespace]. Do you have any suggestions or advice?

Thank you! Sounds good to me, but [namespace] seems unnecessary since it knows the current namespace once it enters the command.↳

Yes, it's unnecessary to use a namespace.
If the RDB file contains multiple db, the current implementation sets the namespace of each db to <ns>_<db number>. The password will be the same as the namespace. Only db 0 will use the current namespace.
Perhaps using a parameter to specify which db to load would be better. If so, the command would be rdb load <path> [database number (default 0)].

@xq2010 Cool! The overall design is nice. I'll take another pass to take a look at detail implementation tomorrow.

Thanks for your review, I will review it later

Hi @xq2010 How's this PR going? Should we take another round review?

I would like to merge this PR today if no more comments.

I'm a bit busy these few days. I'll go through it before Thursday. You can merge this first if other doesn't have any comments.


Update popup displaying details of item

Features:

Popup is showing when an item of the website gets clicked, displaying its details.
API management for displaying existing reservations and adding new reservations.

Hi @Movgto
Your work is complete!  There is nothing else to say other than it's time to merge it :shipit:
Congratulations! 🎉

Highlights
✅ Good design
✅ Functional 👍
✅ Clean code.
Optional suggestions
You can also consider:

[Optional] Consider revising the hover effect color for the 'li.reservation' elements. Exploring a darker shade could potentially enhance the user experience. A darker color tends to be more visually comfortable and could better cater to the viewer's preferences. This could lead to a more pleasing and engaging interaction for users.

Cheers and Happy coding!👏👏👏


Add addevent command and backend for events.

Codecov Report

Merging #84 (c3f4d73) into master (8fbd621) will decrease coverage by 9.18%.
The diff coverage is 21.61%.

@@             Coverage Diff              @@
##             master      #84      +/-   ##
============================================
- Coverage     73.88%   64.69%   -9.19%
- Complexity      492      517      +25
============================================
  Files            80       92      +12
  Lines          1631     1960     +329
  Branches        213      256      +43
============================================
+ Hits           1205     1268      +63
- Misses          346      604     +258
- Partials         80       88       +8

Impacted Files
Coverage Δ

src/main/java/seedu/address/MainApp.java
0.00% <0.00%> (ø)

.../seedu/address/logic/commands/AddEventCommand.java
0.00% <0.00%> (ø)

...du/address/logic/parser/AddEventCommandParser.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
85.00% <0.00%> (-4.48%)
:arrow_down:

...in/java/seedu/address/logic/parser/ParserUtil.java
75.43% <0.00%> (-18.04%)
:arrow_down:

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

.../main/java/seedu/address/model/event/DateTime.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/event/Event.java
0.00% <0.00%> (ø)

...odel/event/exceptions/DuplicateEventException.java
0.00% <0.00%> (ø)

...model/event/exceptions/EventNotFoundException.java
0.00% <0.00%> (ø)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fbd621...c3f4d73. Read the comment docs.


fix getCanonicalName exports overwriting #214

@guybedford Inlined as you have suggested. I rebased too but don't know why github showing your changes also. Please let me know if it's something I did.

@ahmedshuhel unfortunately this looks like bad timing with some of my work today, as I force pushed the release commit when I made a mistake. I've manually merged in https://github.com/systemjs/builder/commit/c0804dfabba282ef228b372893e06a537d25c63a.

@ahmedshuhel somehow it looks like the manual merge didn't catch the removal


Bump framework version

$subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/2200701986

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/2200701986
Status: success


Reset all states of all stores.

Hi Dan,  I need to reset all states when user logout. What would be the best way to achieve this ?

Hi Luiz. In the logout functionality you can inject any service that derives from ObservableStore<T> and then call setState(yourDesiredState, 'RESET_STORE') from within the service (pass null, {}, or an initialized store state to it).
If you're tracking state history you might also want to call resetStateHistory()from within the service (unless you want it to be kept around).

I thought about it, but doing it for several services would not be good, I would have to inject them all.
ObservableStore offers allStoreServices, which let me loop through all services,  with that I could do:
class ObservableStoreWrapper extends ObservableStore {
public clearState(): void {
this.setState(null);
}
}
and then in the logout call:
ObservableStore.allStoreServices.forEach((it: ObservableStoreWrapper) => {
it.clearState();
});
Maybe the ObservableStore could have a function for that, whose implementation was not mandatory, or a static method to clean all services at the same time.
What do you think ?

You only have to have a reset in one service. All services share the same singleton store.

I'm going to close this but if you have any other questions feel free to post them here.

As an update, I'm going to add an ObservableStore.resetState() static function into it. Someone else needed that for testing purposes and it would also apply to what you asked about as well. You'll be able to use it to pass any value (such as null or a full object) to the store.
You can find out more about it i the readme:
https://github.com/danwahlin/observable-store#store-api
I'm hoping to get the package update pushed out this weekend.


Replaced static dependencies with bower, closes #1

I "accidentally" changed many lines when I saved the file. My editor automatically removes spaces at the end of the lines. Probably you also want to check if all works as intended.
If all looks good, you have to create a git tag with the current version and then you can publish the package via bower register light-bootstrap-dashboard git://github.com/timcreative/light-bootstrap-dashboard.git (http://bower.io/docs/creating-packages/#register)

That's awesome, we will check it an register to bower then merge them. Thank you for collaboration!

Hi, we checked the files and everything is looking good if we take the archive that you made and then run "bower install", everything was fine. But I know there are a lot of users who don't know how to use bower, they just want to download an archive "that works". That's why they like to download from Creative Tim, they receive a product that is working so they don't have too many dependecies and other stuff to install and fix in order to get a working product. How can we make this possible for this users? So they will be able to download the archive and then just to take what is working without running any other commands.
Thank you for your help!

This is absolutely right. One idea is to create a zip file every [minor|major] version (including all bower dependencies) and upload it to github releases.

That is a good idea, I was thinking if we can create something like Flat UI - https://github.com/designmodo/Flat-UI. If you download it everything seems to work fine. Or should we add a separate folder inside the repo and call it "Beginner Folder" or something like that? What do you think?

I think it should be enough to just publish the zip as a release. You can then link to it on your website, the readme and everywhere else. In my opinion everyone who wants to create a dashboard should then know how to proceed;)
But that's just my opinion.

Yep, you're right :))
Who want to get the functional static dashboard can take it from the release archive or from Creative Tim (because we host it there too for the users who don't use github/bower) and who is more advanced can take it with bower. We will add the bower version in the master of light-bootstrap-dashboard.
Thank you for your time and sorry for bothering you.

No problem. I will use it myself and in the end it saves me a lot of time. So thank YOU;)