Flexbox : alternate value for justify-content: space-around for box-pack (2009 spec)

I've seen the #527 merge and the #426 and #526 issues, which relate to the alternate value for -ms-flex-pack : it has been corrected for "distribute" in case of "space-around" for justify-content.
Currently, it's the same alternate value that is used for both flex-pack and box-pack in the justify-content mixin.
However, in the 2009 spec (box-pack), "distribute" doesn't exist : the values can be either start / center / end / justify.
That means that, if we use "space-around", it will be compiled as "box-pack: distribute" and it will not work in browsers supporting the 2009 spec (ex : Safari 5 desktop and iOS) : the items are not evenly distributed, they stay aligned on the left.
Here is a test-case : http://codepen.io/mh-nichts/pen/GqNRgy
I suggest the alternate value for space-around should then be "justify" (same behaviour as in justify-content: space-between), so the items are at least evenly distributed, even if there is no space at the start and end.
That means the alternate value for box-pack would be different from the one for -ms-flex-pack :

box-pack : justify
-ms-flex-pack: distribute

Hi @mh-nichts!
As mentioned in #908, we only support Safari 6.1+ in Bourbon 4. We don’t support Safari 5 because the current global usage is 0.06% (0.10% for Safari 5.1).
I’d suggest using Autoprefixer, which is a better tool for the job and you can target specific browsers to fit your project needs.

Thanks for the explanation, sorry for not reading carefully the browser support list.

@mh-nichts No worries! Always here to help, if you need anything.


Update acceptance criteria for helm chart and registry operator PR templates

Which area/kind this issue is related to?

/area registry
Issue Description

Update PR template to include acceptance criteria where if there is any changes that could be shared between the helm chart and registry operator that there should be tied PRs for both.
Parent Epic: #1446
Acceptance Criteria

[ ] Add this criteria to registry operator PR template
[ ] Add this criteria to registry-support PR template (helm chart repository)

Parent issue updated to https://github.com/devfile/api/issues/1446.


Sandboxes dimension returned by cubes.get

Describe the bug
The cubes.get function is returning the Sandboxes dimension and it is not consistent with the cubes.create dimension (not expecting the sandboxes dimension).
To Reproduce
I wanted to clone a cube between TM1 instances.
I was hoping to do the following.
# Create cube
cubesrc = tm1_source.cubes.get(cube_name=CUBE_TO_REPLICATE)

if not tm1_target.cubes.exists(CUBE_TO_REPLICATE):
    tm1_target.cubes.create(cubesrc)

But the problem with this is approach is the function cubes.get is returning the Sandboxes dimension.
When passing the cube object to the other instance for the cube creation, it is trying to create a cube with a "Sandboxes" dimension.
So to actually clone the cube I had to update to the following (remove the first dimension from the list).
# Create cube
cubesrc = tm1_source.cubes.get(cube_name=CUBE_TO_REPLICATE)

if not tm1_target.cubes.exists(CUBE_TO_REPLICATE):
    new_cube = Cube(cubesrc.name, cubesrc.dimensions[1:], cubesrc.rules)
    tm1_target.cubes.create(new_cube)

Expected behavior
Ideally the first piece of code should allow to create the cube directly.
For reference, the dimension clone can be done this way.
dimension_master = tm1_source.dimensions.get(dimension_name=dimension_name)
if not tm1_target.dimensions.exists(dimension_name):
    tm1_target.dimensions.create(dimension_master)

Version
TM1py 1.6.2

Fixed with #597


Things we need to do before 1.0.0

This is a meta-issue to regroup the things we need to do before 1.0.0, so that we have a clear view of what's left, and what we should prioritize to get there.
The most critical parts are language features which will break forward binary compatibility, because they will introduce hacks which we want to get rid of with the jump to 1.0.0:

[x] #1381 Add a way to export a top-level method/value
[x] #1902 Support for static fields in @ScalaJSDefined classes
[x] #1997 Need @JSSymName(..) annotation
[x] #2175 Integrating with JS module systems (forward compat breaking changes have been done in #2572).

There are also optimizations that we can only do if we change the Infos or the IR, and some cleanup IR changes:

[ ] #1961 Honor call-site @inline and @noinline
[ ] #2227 Remove unused fields (this one can only be done in 1.0.0, at least the info change, not before)
[x] #2359 Get rid of EmptyTree

Anything else?

https://github.com/scala-js/scala-js/issues/1991 is merged/closed. Is the reference wrong?

Yes, indeed, the reference was wrong, sorry. I fixed it.

Thanks a lot for opening this Issue!
As mentioned I really want to get feedback from the community on this.
There are at least 2 sensitive points:
1 - In one here @sjrd will finisch it's Ph.D (congrats)
2 - Larger usage of SJS version 0.6.X will prevent adoption of 1.0 when it will come (i.e. for Sbt)
What we use to say is that SJS IS production ready, so IMO this is time to move towards and start adopting 1.0 version.
I completely understand that there are out many libraries that will be broken, nevertheless more we wait more will come and it will become harder to switch.
If the needed modifications to IR are completely well known and there is no related risk I wish if we can have a 1.0-M to start play with.

#2359 should probably also go in here.

What has @sjrd's finishing of his Ph.D to do with this? Does that give him more of less time to spend on this project?

#2359 should probably also go in here.

Indeed, added.

What has @sjrd's finishing of his Ph.D to do with this?

It has virtually nothing to do with it. I don't know why @andreaTP brought this up. Besides, there's no guarantee that I'm finishing in one year. I probably won't; it will probably be a few more months than that.
Now of course, once I graduate, I'll get a job. Whether that job involves maintaining Scala.js or not will have an impact on how much time I can dedicate on it.

I brought this up because, of course, depending on what you will do for your job, 1.0.0 can be a success or will never happen to be used...

I'm going to close this ticket because it is not useful anymore. Now that we are actually targeting 1.0.0 on the master branch, a more accurate view of what we want/need to do before releasing 1.0.0 can be seen in the relevant milestone: https://github.com/scala-js/scala-js/milestone/20


Use industrial-ci

industrial-ci can be used for continuous integration with Travis CI. This is probably easier to maintain than to invoke build_farm manually.

Thanks for the advice, I will try it.


Feature Request - Allow HTML-only formatting

Expected Behavior

I had been using your extension for a short while and for some reason I guess it malfunctioned, temporarily creating the perfect extension for my use.  For a while (until I reloaded it) it was not inserting the markdown container around my images, which for me was great!
I have my config set up such that a pasted image is prefixed and suffixed with the HTML necessary to display the image centered at 90% width:
eg.

title of image

When the plugin was not working as designed, pasting images into my Markdown worked perfectly (because it wasn't adding the ![]( and )).
Current Behavior

Images pasted into Markdown get the user's custom prefix and suffix attached, like this:
imageFilePath = `${prefix}${imageFilePath}${suffix}`;

and then are wrapped in a Markdown image container:
        switch (languageId) {
            case "markdown":
                return `![](${imageFilePath})`

Resulting in:
![](

title of image

)

Possible Solution

At this point in your code, you add the symbols to have Markdown recognize it as an image.  Perhaps we could make this a conditional operation, that checks pasteImage.mdContainer for true (current/default) or false.
Context (Environment)

I use HTML formatting on my Markdown images, so I don't want the Markdown ![](image container) inserted automatically.
Here's my configuration:
Paste Image
0.9.5

settings.json
{
    "pasteImage.path": "${currentFileDir}/img",
    "pasteImage.prefix": "

title goes here

",
}

VSCode:
1.22.2
3aeede733d9a3098f7b4bdc1f66b63b0f48c1ef9
x64

Screenfetch:
                 -/+:.          stvhwrd@macduck
                :++++.          OS: 64bit Mac OS X 10.12.6 16G1314
               /+++/.           Kernel: x86_64 Darwin 16.7.0
       .:-::- .+/:-``.::-       Uptime: 4d 10h 43m
    .:/++++++/::::/++++++/:`    Packages: 229
  .:///////////////////////:`   Shell: zsh 5.5
  ////////////////////////`     Resolution: 2880x1800
 -+++++++++++++++++++++++`      DE: Aqua
 /++++++++++++++++++++++/       WM: Quartz Compositor
 /sssssssssssssssssssssss.      WM Theme: Blue
 :ssssssssssssssssssssssss-     CPU: Intel Core i7-4770HQ @ 2.20GHz
  osssssssssssssssssssssssso/`  GPU: Intel Iris Pro
  `syyyyyyyyyyyyyyyyyyyyyyyy+`  RAM: 10532MiB / 16384MiB
   `ossssssssssssssssssssss/
     :ooooooooooooooooooo+.
      `:+oo+/:-..-:/+o+/-

@neighthan it seems as if we may have to fork this project and make the changes ourselves.   Up for it?

@stvhwrd This issue is greate.
@stvhwrd @neighthan Now you can update vscode-paste-image to v1.0.1.
New configuration pasteImage.insertPattern can use in this scene:
{
    "pasteImage.path": "${currentFileDir}/img",
    "pasteImage.insertPattern": "

${imageFileNameWithoutExt}

"
}


sis-scraper: introduce an additional 'phase 2'  pruning algorithm

This additional optimization phase reduces f20 and s21 down from 5 u64s
to just a single u64.

I validated this using the sis_scraper_test.py that was recently introduced. The test is broken on tip (def dateranges_dont_overlap(year, ts1, ts2) does not work -- commenting out the call to this function allows it to pass on tip and when applied on my commit)

I have introduced an additional commit to fix-up the test - it now passes on tip and when this change is applied.

I've just pushed an additional patch to speed up pruning.


No commands listed when only one subcommand

My urfave/cli version is
v2.25.7
Checklist

[x] Are you running the latest v2 release? The list of releases is here.
[x] Did you check the manual for your release? The v2 manual is here
[x] Did you perform a search about this problem? Here's the GitHub guide about searching.

Dependency Management

My project is using go modules.

Describe the bug
When I make a command with only one subcommand and hide the help command my subcommand is not displayed.
My guess is that since a command and a subcommand is the "same", it always hide the command list when it's fewer than one item there, because it assumes it is the help-command.
To reproduce
package main

import (
	"log"
	"os"

	"github.com/urfave/cli/v2"
)

func main() {
	app := &cli.App{
		Name: "hello",
		Commands: []*cli.Command{
			{
				Name: "world",
				HideHelpCommand: true,
				Subcommands: []*cli.Command{
					{
						Name: "welcome",
					},
				},
			},
		},
	}

	if err := app.Run(os.Args); err != nil {
		log.Fatal(err)
	}
}

Observed behavior
./nais p password -h
NAME:
   nais postgres password - Administrate Postgres password

USAGE:
   nais postgres password [command options] [arguments...]

OPTIONS:
   --help, -h  show help

Expected behavior
./nais p password -h
NAME:
   nais postgres password - Administrate Postgres password

USAGE:
   nais postgres password command [command options] [arguments...]

COMMANDS:
   rotate

OPTIONS:
   --help, -h  show help

Additional context
If I enable HideHelpCommand for the specific command (not the subcommand) it works.
Run go version and paste its output here
go version go1.20.5 darwin/arm64

Run go env and paste its output here
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/user/Library/Caches/go-build"
GOENV="/Users/user/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/user/workspace/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/user/workspace/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/homebrew/Cellar/go/1.20.5/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/homebrew/Cellar/go/1.20.5/libexec/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.20.5"
GCCGO="gccgo"
AR="ar"
CC="cc"
CXX="c++"
CGO_ENABLED="1"
GOMOD="/Users/user/workspace/company/cli/go.mod"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/1v/j4d_bg_j4bs119btmjh244lw0000gn/T/go-build274875656=/tmp/go-build -gno-record-gcc-switches -fno-common"

I have already set that value to true at the App level, no change for me in my original code (did not try it in the reproduce example).
For now my solution is just to show the help-command, it's not a big deal for us.
PS: This is my code where I'm using this library, it's a big PR where I change from cobra/viper to this one: https://github.com/nais/cli/pull/209

@Kyrremann Can you try the fix in the PR ? Thanks

That fixed it!
$ ./nais postgres password
NAME:
   nais postgres password - Administrate Postgres password

USAGE:
   nais postgres password command [command options] [arguments...]

COMMANDS:
   rotate  Rotate the Postgres database password

OPTIONS:
   --help, -h  show help


feat(CostSurface): Adds GET endpoint to retrieve one and all Cost Surfaces for a Project [MRXN23-108] [MRXN23-109]

…faces for a Project
Substitute this line for a meaningful title for your changes
Overview
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets

Checklist before submitting

[ ] Meaningful commits and code rebased on develop.
[ ] If this PR adds feature that should be tested for regressions when
deploying to staging/production, please add brief testing instructions
to the deploy checklist (docs/deployment-checklist.md)
[ ] Update CHANGELOG file

@KevSanchez only note on this, we're not including the JSON:API metadata section in the response, IIRC because we don't have this "ready-made" by nestjs-base-service, but maybe it's ok like this - this is not a full JSON:API endpoint with pagination and so on, so it can be as simple as possible.


Solve deprecation issue

tf.test.is_gpu_available() is deprecated

Closed by https://github.com/faustomorales/keras-ocr/pull/163


iOS 14 Tracking permission

This pull requests add tracking permission based on iOS 14's AppTrackingTransparency
framework. https://developer.apple.com/documentation/apptrackingtransparency
I've implemented the codes, tested on both iOS & tvOS 14 beta, and updated podspec & README to reflect changes. However, new icon assets for tracking need to be added and I just left a TODO comment there.
@ivanvorobei Thanks again for making this nice library, and hope this PR helps.

You did great work!
Thanks for help!
I will add new icon and soon release

But now now way add it t release Xcode, I commented code and uncomment it with release new Xcode.

Thanks @ivanvorobei!


AIR table structure defintion

Issue #14
Here are the things implemented so far

Made Expression type safe by providing the row and column numbers
Defined the equality gadget
Defined a first iteration of the AIR constraints and table structure, including the definition of the equivalence theorem
Implemented a proof-of-concept table in which every row is a valid 8-bit addition

The main problems with the current equivalence statement definition are:

the specification has to be provided generic in the row, but probably it is better to express a global property about the trace,
we need to find a way to exploit some kind of inductive structure over the rows, but currently it is hard to express it.

In the 8-bit Fibonacci example, I think an expressive description should look like this (currently not quite there)
def constraints : List (TableConstraint 3 T p) := [
  TableConstraint.boundary 0 (λ row => Equality.circuit 3 T (var row 0) (const 1)),
  TableConstraint.boundary 0 (λ row => Equality.circuit 3 T (var row 1) (const 1)),
  TableConstraint.everyRowExceptLast (λ row => Addition8.circuit 3 T (var row 0) (var row 1) (var row 2) (var (row+1) 1)),
  TableConstraint.everyRowExceptLast (λ row => Equality.circuit 3 T (var row 1) (var (row+1) 1))
]

def spec := fun trace => (∀ row : ZMod T, (trace row 0).val = (fib row.val) % 256)

The equivalence should then be proved by induction on row. The base case is satisfied by the boundary constraints, and the equivalence reasoning should proceed by induction up until the last row.

Made a bit of progress, the first issue is solved as now the specification is just a Prop over the trace.
spec : Inputs N M (F p) -> Prop

Also gadgets lookups and table lookups have been decoupled to allow more optimized lookup structures over the tables.
The second issue is however still there. Fundamentally, we have two opposing facts:

we want to represent row indices as elements of ZMod M so that we can reference rows at an offset from the current row, and we want to express the fact that this operation could wrap around the table,
we want to prove things by induction on the row.

Those two are incompatible because ZMod M does not have an inductive structure. Note that proving things by induction on the row intuitively is correct, but actually it is not possible in the general case, because constraints could reference rows above (or equivalently wrap around), breaking well-foundedness.
Note also that the Fibonacci table equivalence theorem would be easy to prove (or at least doable) if the table were infinite i.e., if the row indices were element of Nat.
Here are some ideas for solving this:

Make constraints only reference rows below the current one (not sure how we could express this, while also retaining information about the possibility of wrapping).
Prove equivalence by induction on M (the table length).

First feedback, I noticed that Circuit.lean got out of date with other stuff and no longer builds. Feel free to delete anything in there that you don't use, but I think we should always keep the project building with lake build

Right, I removed all the unused code, I think we can come back later to the AIR polynomials at a later stage.
Also moved the main build targets to the tables, so that everything is checked by lake build. At some point I think it would make sense also to add a CI to ensure that there are no errors


New IDCT Tutorial for Merging

merging new IDCT tutorial

Will create a new pull request with updates for final review


Update runner.ts

Fix #3

Looks great. Merged to main. Thank you for your contribution!

Looks great. Merged to main. Thank you for your contribution!

Released in v0.0.4


from goprocam import GoProCamera, constants

Please i need a help , I would connect gopro hero 5 whith Raspbery pi 3 , when i tap command : python , i get that message
Screenshots
from goprocam import GoProCamera, constants
Traceback (most recent call last):
File "", line 1, in
File "goprocam/init.py", line 1, in
from goprocam import GoProCamera
File "goprocam/GoProCamera.py", line 3, in
import urllib.request
ImportError: No module named request

Use Python 3.6 or newer

Done :D Thank u very much for your help , i have just a question : i want to do stream live with GO PRO HERO 5  and save data in Raspbery pi 3 (cloud) ,can u help me please.


[Question Service] Message value format in PUT response

is stringified json the intended return format?
@tryyang2001 @xingjie99
thanks

Ermm so far I simply return the error message from Zod, so the message turns out to be stringified JSON. If you think we shouldn't return this kind of error message, I can modify it.

I would like to know if you need to distinguish what kind of error you received from the API response. If so, I was thinking if I change the error field to something like INPUT ERROR for every error due to the request body input. Will this help? Or do you need the details about the error like the one you showed that it is because the input string is too small for a certain input?
The reason why I can't always give exact error message is because in Zod, sometimes the detailed error message does not always come from the message field, see an example here:

The error shown above says that the input filed is required when you provide the examples, but the message only says required. So you might not know what thing is required...

i see, the error message is detailed enough, just that the format is not that friendly. I'll do the parsing in frontend first for now.

if the message can return a simplified object like this:
{
  title: "title is missing"
  description: "description is missing"
}

i will be able to set error state to individual inputs, something like this:
<input
      isInvalid={'title' in res.message}
      errorMessage={ res.message['title'] }
></input>

currently, I simply output all error messages in the same container which is not ideal if we have multiple errors.


Cannot using git stash on the dash of source control

Does this issue occur when all extensions are disabled?:
Not sure, due to I worked remotely with SSH to the server side, it cannot be test without the SSH remote extension

## Client Side
- Version: 1.75.0
- Commit: e2816fe719a4026ffa1ee0189dc89bdfdbafb164
- Date: 2023-02-01T15:29:17.766Z
- Electron: 19.1.9
- Chromium: 102.0.5005.194
- Node.js: 16.14.2
- V8: <IP_ADDRESS>-electron.0
- OS: Linux x64 5.15.0-58-generic
- Sandboxed: No

Steps to Reproduce:

Open a project with git includes
Modify the code
Go to the left panel, select Source Control
On the top right of the Source Control panel, open the menu bar which the icon is 3 dots ( ... )
Select Stash option
Once click, a message prompt pop up, then insert test or any strings else
Next press Enter, it will pop a error window with command options

the command output:
> git stash push -m test
usage: git stash list [<options>]
   or: git stash show [<stash>]
   or: git stash drop [-q|--quiet] [<stash>]
   or: git stash ( pop | apply ) [--index] [-q|--quiet] [<stash>]
   or: git stash branch <branchname> [<stash>]
   or: git stash [save [--patch] [-k|--[no-]keep-index] [-q|--quiet]
		       [-u|--include-untracked] [-a|--all] [<message>]]
   or: git stash clear

Please help to confirm the issue and hopefully fix as soon as possible.

@jason19970210-senao, apologies for not getting back to you on this until now. What is the version of git that you are using? It looks like you might be running an old version of git that does not support git stash push. Please upgrade to the latest version of git in order to resolve this issue. Thanks!


ui: Add subcommand to initialize a new local pallet

Currently, the Forklift CLI provides no way to initialize a new local pallet; that must instead be done using the Git CLI with git init (or some other Git tool) and by manually creating files (e.g. for forklift-pallet.yml). It would be nice if we could provide a CLI (and maybe also a simple TUI using https://github.com/charmbracelet/huh) to make it easier to initialize a new local pallet, e.g. via the plt init subcommand. It would also be great if the TUI could provide an initialization wizard to add any external package repos and package deployments needed by the user.
It would also make sense to make this subcommand work for dev plt init.
This functionality will become much more useful after we complete #253.

Part of the initialization flow could be an option to set up the local pallet as an override over an existing pallet (for customization), by setting up a requirement for that existing pallet, and maybe also some sort of local update-checking mechanism (or auto-upgrade mechanism) for that requirement (though it may be simpler/safer to just shift the responsibility of such auto-upgrades onto a remote host for the pallet, as in #242 with GitHub CI; in that case, we'd want to implement #233 with starter configs for auto-upgrading dependencies).


chore: bdd-sbrp-import-1582701568 to 0.0.1

chore: Promote bdd-sbrp-import-1582701568 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Minecraft giving me "errors in currently selected datapacks..." when loading this mod.

Here is a pastebin of the log when this error occurs.
https://pastebin.com/evnnJSHj
Edit:
Turns out it was turning off the generation of certain items/blocks in your mod (using mod menu) that was causing this issue.
How to recreate it:

Run the following mods: Fabric API + Mod Menu + Vanilla Enhanced
Run Minecraft
Open "Mods" (that mod menu adds in the menu).
Press on "Vanilla enhanced" image, then the configure button.
Where you see "enable (item/block)" disable them. In my case I disabled Dark Granite, Marble, and Biomes.
Create a new world. (Other Notable issue I just noticed, disabling the generation doesn't actually work (I least from what I'm seeing as I still see the blocks that I disabled)
Close Minecraft.
Run Minecraft again.
Create or Open a world.
Minecraft should give you a data pack error.

Other things to note:

After the problem is now there, if you remove VE the error should go away, however when reapplying VE into the mod folder, the problem appears again (This is most likely because mod menu is saving the settings for the mod, including this problem)
Re-enabling all the generating/spawn settings in mod menu does not fix the error appearing.

When changing values in the config the game needs to be restarted for all of the changes to apply. As for the issue, I will be releasing an update today that fixes this. This is happening because the game is trying to load tagged items that don't exist. So instead of disabling these items completely, they will just be prevented from generating. I should be able to disable them completely once 1.16.2 is released.

Fixed in 1.1.


Prevent request from crashing the application on a failed request (ie requested ip is not online)

Is there a way to prevent the module for completely taking down the app when the request is unable to go through.  I've tried surrounding with a try/catch but this does not do the trick

You can use node-request-retry module to retry a request when it fails the first time.


python package for SeemoRe

Thank you for the open-source model. I packaged your model into a Python package for easier use (the model will download automatically). Looking forward to the release of large models.
https://github.com/Sanster/seemore
pip install seemore

from seemore import SeemoReUpscaler
import cv2

# Initialize the upscaler
upscaler = SeemoReUpscaler("seemore_b_x4", device="cpu")

# Load and upscale an image
image = cv2.imread("input.jpg")
result = upscaler(image)

hi,
cool, thanks! I uploaded now all checkpoints for the larger model as well. Sorry for the delay


Simplifying imports

Signed-off-by: Chris Richardson<EMAIL_ADDRESS>

@chrisruk This is much nicer, are you happy for me to push the big green button? (I'll go and re-base my FfmegOutput PR afterwards.)

Yes, please, ta


Sync wants to merge right after turning it on

re #96226
This is basically the back story for https://github.com/microsoft/vscode/issues/96347

I work on a single computer with VS Code Desktop only
I did enable settings-sync with GH-accounts shortly after we started to support GH-accounts
for some unknown reason settings sync is off 🤷
enable sync tells me that I have to merge to continue

That's the moment where I stop using this feature and where I want a way to see what data we have stored. There is no way to figure that out and that's undermining trust in this feature. Things that we should do better

give me a way to nuke the cloud data without being sync'ing, just a big stop this switch so that I am always in control. Ideally I want to be able to inspect the cloud-data but this is a good start
know that I am always coming with the same machine (as I am in this case) and don't start talking about merging and so

There is a remote backup view to inspect the data in the cloud but that is available only after sync is enabled. May be we can show this always.

give me a way to nuke the cloud data without being sync'ing, just a big stop this switch so that I am always in control

So you are asking for Replace Cloud action? Is not it a big decision for the user to decide without knowing what is there in the cloud? Probably have an action to show the remote backup view and decide then?

So you are asking for Replace Cloud action?

Not really, I am asking for "nuke the cloud" command  and a "Show me what you have command" - both without sync'ing but only being logged in

Ok fair enough. Will add "Show Remote Data" action that shows the remote backup view and provide action there to nuke.

for some unknown reason settings sync is off

As discussed this could be a bug, please see if this happens again and provide the logs (Preferences Sync & Account).

know that I am always coming with the same machine (as I am in this case) and don't start talking about merging and so

This is a fair assumption.
@Tyriar is it possible to know from the server that it has data synced only from this device through the manifest request?

@sandy081 not unless we start tracking which machine each version is done with as we've been talking about recently.

@Tyriar
I have observed the same behaviour, however I got a prompt to view the conflict.
There is no actual conflict... but the settings have been reordered. A sort is necessary based on the key of each level of the hierarchy.
remote
{
    "window.zoomLevel": 0,
    "gitlens.advanced.messages": {
        "suppressCommitHasNoPreviousCommitWarning": false,
        "suppressCommitNotFoundWarning": false,
        "suppressFileNotUnderSourceControlWarning": false,
        "suppressGitVersionWarning": false,
        "suppressLineUncommittedWarning": false,
        "suppressNoRepositoryWarning": false,
        "suppressResultsExplorerNotice": false,
        "suppressShowKeyBindingsNotice": true,
        "suppressUpdateNotice": false,
        "suppressWelcomeNotice": true
    },
    "gitlens.keymap": "none",
    "gitlens.historyExplorer.enabled": true,
    "[markdown]": {},
    "terminal.integrated.shell.windows": "C:\\WINDOWS\\System32\\wsl.exe",
    "gitlens.views.fileHistory.enabled": true,
    "gitlens.views.lineHistory.enabled": true,
    "go.formatTool": "goimports",
    "html.trace.server": "messages",
    "liveshare.diagnosticLogging": true,
    "liveshare.featureSet": "insiders",
    "remote.SSH.showLoginTerminal": true,
    "go.inferGopath": true,
    "python.jediEnabled": false,
    "terminal.integrated.rendererType": "dom",
    "files.trimTrailingWhitespace": true,
    "gitlens.blame.ignoreWhitespace": true,
    "go.gocodeAutoBuild": true,
    "go.useLanguageServer": true,
    "go.testTags": "unit_tests",
    "remote.SSH.path": "C:\\WINDOWS\\System32\\OpenSSH\\ssh.exe",
    "remote.SSH.remotePlatform": {
        "dev": "linux"
    },
    "editor.largeFileOptimizations": false,
    "vs-kubernetes": {
        "vs-kubernetes.kubectl-path.linux": "/home/ghicken/.vs-kubernetes/tools/kubectl/kubectl",
        "vs-kubernetes.draft-path.linux": "/home/ghicken/.vs-kubernetes/tools/draft/linux-amd64/draft",
        "vs-kubernetes.minikube-path.linux": "/home/ghicken/.vs-kubernetes/tools/minikube/linux-amd64/minikube",
        "vs-kubernetes.helm-path.linux": "/home/ghicken/.vs-kubernetes/tools/helm/linux-amd64/helm"
    }
}

local
{
    "remote.SSH.remotePlatform": {
        "nimbus-dev": "linux"
    },
    "editor.largeFileOptimizations": false,
    "vs-kubernetes": {
        "vs-kubernetes.kubectl-path.linux": "/home/ghicken/.vs-kubernetes/tools/kubectl/kubectl",
        "vs-kubernetes.draft-path.linux": "/home/ghicken/.vs-kubernetes/tools/draft/linux-amd64/draft",
        "vs-kubernetes.minikube-path.linux": "/home/ghicken/.vs-kubernetes/tools/minikube/linux-amd64/minikube",
        "vs-kubernetes.helm-path.linux": "/home/ghicken/.vs-kubernetes/tools/helm/linux-amd64/helm"
    },
    "go.formatTool": "goimports",
    "terminal.integrated.copyOnSelection": true,
    "terminal.integrated.scrollback": 10000,
    "html.trace.server": "messages",
    "liveshare.diagnosticLogging": true,
    "liveshare.featureSet": "insiders",
    "remote.SSH.showLoginTerminal": true,
    "go.inferGopath": true,
    "python.jediEnabled": false,
    "terminal.integrated.rendererType": "dom",
    "files.trimTrailingWhitespace": true,
    "gitlens.blame.ignoreWhitespace": true,
    "go.gocodeAutoBuild": true,
    "go.useLanguageServer": true,
    "go.testTags": "unit_tests",
    "remote.SSH.path": "C:\\WINDOWS\\System32\\OpenSSH\\ssh.exe",
    "window.zoomLevel": 0,
    "gitlens.advanced.messages": {
        "suppressCommitHasNoPreviousCommitWarning": false,
        "suppressCommitNotFoundWarning": false,
        "suppressFileNotUnderSourceControlWarning": false,
        "suppressGitVersionWarning": false,
        "suppressLineUncommittedWarning": false,
        "suppressNoRepositoryWarning": false,
        "suppressResultsExplorerNotice": false,
        "suppressShowKeyBindingsNotice": true,
        "suppressUpdateNotice": false,
        "suppressWelcomeNotice": true
    },
    "gitlens.keymap": "none",
    "gitlens.historyExplorer.enabled": true,
    "[markdown]": {},
    "terminal.integrated.shell.windows": "C:\\WINDOWS\\System32\\wsl.exe",
    "gitlens.views.fileHistory.enabled": true,
    "gitlens.views.lineHistory.enabled": true
}

Improved the first time sync replace or merge dialog and is shown only when

user last synced from another machine and there are some changes (local or remote)

Also added an option to view synced data


7826 trade group

Note: requires https://github.com/AugurProject/augur.js/pull/275
Clubhouse Story
Submitter checklist

[x] Test covering functionality added/fixed in
Check the linked story includes the following:

[x] Steps to reproduce
[ ] Screenshot (If applicable)

Reviewer Checklist

[ ] Test/lint pass
[ ] Post merge, story marked complete

@tinybike The tests seem to be failing. Does this branch need a augur.js version bump?

Yep, was waiting on https://github.com/AugurProject/augur.js/pull/275 -- will bump version now!


darglint v1.4.0

Update darglint version to 1.4.0

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

Current darglint version in conda is 1.2.0, while 1.3.0 contains a fix for a race condition that I believe is causing me problems.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin @conda-forge-coordinator @asford Despite my PR is recent, looking at past pull requests, it seems that this repository hasn't received attention for a couple of months. What is the best way to proceed here?

Limited time, @jcollado would you be willing to join the maintainers?


Replace .png logo with .svg

In order to add the hover property and create a website that adapts to other screens more easily.

[ ] Also add a new trimmed down .png to be used as a favicon.


Error in console, can't add individual class items while editing themes

Operating system or device - Godot version:

Arch Linux
Godot 2.1 Git (https://github.com/godotengine/godot/commit/4192d6d5512611825c777aea7af0c8a9478ee290)
Clang 3.8.0

Issue description (what happened, and what was expected):
Trying to add an individual item class for theming projects will result in this error:
ERROR: set_stylebox: Condition ' p_style.is_null() ' is true.
    At: scene/resources/theme.cpp:320.

Adding all class items for a given GUI Control type will work fine.

Seems to be fixed by https://github.com/godotengine/godot/commit/c1056a9bfb723d053c3bec9d9f8d84ecdc5e93f9.


Add option to make controller invisible when IsInteracting

For my purposes, I want the controller to completely disappear (not just Ghost) when holding another object. This creates a better illusion of the controller becoming something else rather than just grabbing it.

Sorry this took so long, I added it in though. NVRPlayer.MakeControllerInvisibleOnInteraction.


Add documentation for fluentd-sub-second-precision flag in fluentd plugin docs.

Description
Recently I have added fluentd-sub-second-precision to fluentd plugin through this PR. Also I have autocomplete cammand for the same through this (PR)[https://github.com/docker/cli/pull/724].
Solution
So the  https://github.com/docker/docker.github.i/blob/8896e88867202a2dda926adadb6a4a350fd10165/engine/admin/logging/fluentd.md#options page needs to be updated with support for fluentd-sub-second-precision flag description.
Team
area/engine
P.S
I have my PR ready for this just need a confirmation from docker documentation team.

Closed by #5426


Pre-release extensions: confusing experience on older versions of VS Code

Testing #138068
I had VS Code 1.62.0 installed on my Windows 11 VM.
Searching for Mock Debug showed the pre-release version 1.47.1 but without any visual indication:

Installing the extension resulted in version 1.46.11 being installed (without any warning):

I understand that older versions of VS Code don't have the code "to do the right thing".
But I was always under the impression that queries on the Marketplace only show "compatible" versions of an extension, but here I'm offered a Mock Debug that requires VS Code 1.63 (when I have VS Code 1.62).

But I was always under the impression that queries on the Marketplace only show "compatible" versions of an extension,

This is not true. VS Code always shows the latest version and installs the compatible version. Marketplace do not understand the semantics of vscode engine compatibility.
CC @isidorn

Yeah this is an unfortunate limitation. It would be great if we were rendering the correct extension description, however I do understand how this would require additional MP calls which might overcomplicate things.


Add support for Ec2 instance deployment

One requirement for the automated deployment is the ability to deploy Seqera Platform is a single VM environment. In this scenario the Terraform module should be able to:

Deploy the RDS database
Deploy the Redis Elasticsearch instance
Create an IAM role with this policy named seqera-forge-role
Spin an Ec2 instance that will run a single node K3s cluster using seqera-forge-role as instance tole
Configure the security group allowing inbound traffic on port 25, 80, 443

Let's focus on. the Ec2 instance, instance role and security group. It would be a great start

Which AMI to use for the EC2 instance?

a parameter defaulting as the same as for EKS node i

How the instance will be accessed, SSH, SSMSessionManager?

SSH

Default instance type

see above

Associate Public IP?

Optional, default YES

EBS volume type

gp3, size defined via a variable default to 100GB

StartUp Script?

No (at least for now)

Nice, please make a PR for this

A PR can be in draft mode, no worries about not being complete


api puppeteer and report

🗣 Description

Moved pupeteer and headless chrome to run with api.
Setup auth against client to use same auth credentials.
💭 Motivation and Context

🧪 Testing

📷 Screenshots (if appropriate)
🚥 Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (causes existing functionality to change)

✅ Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@zenine07 Is this work replacing the need for the project in con-pca reports repository?

@mostafac0des Yes, this changes means the con-pca-reports repository is no longer needed. The changes function the same as the work being done in the reports repo, but removes one more moving piece.


changes in repository

Thank you

Summary by CodeRabbit

New Features

Introduced a new environment variable CROSS-ORIGIN for CORS settings.

Updates

Updated MongoDB service endpoint and frontend server address across multiple configuration files.
Changed API endpoint for the frontend application.
Modified port mapping for the backend service in the Docker Compose configuration.
Removed Redis service configuration from Docker Compose.

Configuration

Changed the source of the environment configuration file used in the Docker setup.

test


Changed URL for 100% Orange Juice Wiki

When clicking the redirect banner on a page on https://100orangejuice.fandom.com, the banner redirects to https://orangejuice.wiki/w/?title=Special:Search&search=[page name]. However, the official 100% Orange Juice Wiki currently has pages indexed under https://orangejuice.wiki/wiki/[page name], so this results in a 403 error. I tested this using the page https://100orangejuice.fandom.com/wiki/Krilalaris.

Thanks for reporting this!
We don't use the content path for those links; we use the index.php entry point to perform the search. I see the wiki went through some server maintenance and I'm guessing the /w/ entrypoint we were using broke or was changed, and it should now be /w/index.php. Will have this fixed in the next update!

Fixed in v3.11.0 (available for Chrome, soon to be available on Firefox).


[Icon Request] Own icon for fonts folders

[x] I'm sure this issue is not a duplicate?
[x] I want to create an icon request:
- Type: folder
- Icon Name: FontFolder
- Sample original Icon: Icon (hint: does not display in browser but pops up a download window)
- Extensions: fonts

Great idea, but I think this icon does not match our style guidelines. Your thoughts @robertohuertasm and @JimiC ?

See this comment.

I think that changing the folder icons will not have too much value as we also use those icons as a background for the specific named folder icons.
Having a watermark on the folder icon and on top the folder specific icon will definitely bloat the icon.

@JimiC I think you might misunderstand me. Of course I want to keep things as they are, with the folder background and then the specific named folder icons on top of them. Just one more for fonts.

Like in this picture. Though instead of the little image icon in front of the folder icon, just put a little "Aa" or something that represents fonts in general very well.

Oh for a folder containing fonts? I totally misread you if this is the case. If so it's totally doable.


CEO-254 Use Assigned/Default instead of Natural

Purpose

Rather than have a "Natural" navigation mode, use the label of "Assigned" when the project has assigned plots or "Default" when there are not assigned plots.
Related Issues
Closes CEO-254
Submission Checklist

[x] Commits include the JIRA issue and the #review hashtag (e.g. CEO-### #review <comment>)
[x] Code passes linter rules (npm run eslint/clj-kondo --lint src)

Testing

Given I am a User, When I view a project with Assigned plots, Then I am shown the "Assigned" navigation mode by default.
Given I am a User, When I view a project without Assigned plots, Then I am shown the "Default" navigation mode by default.

Screenshots

Assigned Plots

No Assigned Plots

src/js/collection.js
isAssignedPlots -> hasAssignedPlots


Update impersonation_wise.yml

Description
Adding boundaries on display_name field.
Things like Connectwise are causing fp's
Associated samples
Link to samples that are affected by your change.
For example, samples you are negating, samples you are including, or samples your new insight should fire on.
https://platform.sublimesecurity.com/rules/editor?canonical_id=f5f9989525cd3a8d44f75efd7c73b1624d220b8e7a4ea85ffb838a53d2cb7c1f

/mql-mimic-exempt: 511202


AMQP traffic not reliably showing in UI

Describe the bug
With v51.0.0 kubeshark installed, I'm seeing next to no traffic reported over AMQP. The reports are very intermittent and usually attributed to the wrong source or destination. As a quick demo, I have two services publishing to rabbitmq and one service subscribed. The service subscribed is showing that there are around 10 messages per second being received. The UI rarely shows anything. When it does show things, it's typically a basic deliver method. These typically show up as going between "kubernetes" and "kubernetes". Even more rarely I see a basic publish method that is attributed to the proper source and destination.
Provide more information
minikube
To Reproduce
Set up helm chart values
serviceAccount:
  create: true
tap:
  docker:
    tag: v51.0.0
  ingress:
    enabled: true
  tls: true
  servicemesh: false
  nokernelmodule: true

Install helm chart
helm install --version 51.0.0 -f ~/k8s_configs/kubeshark_helm_values.yaml kubeshark gsw-helm/kubeshark

Add minikube ingress controller
minikube addons enable ingress

Navigate to front end in web browser at http://ks.svc.cluster.local/
Observe little to no AMQP traffic
Expected behavior
One basic publish method in the UI per message produced by publishers. One basic deliver method in UI per message received by subscriber.
Logs
Worker logs typically show this
2023-10-20T18:13:06Z INF server/middlewares/logger.go:69 > body_size=19 client_id=<IP_ADDRESS> latency="30.349µs" method=GET path=/pcaps/total-size status_code=200
2023-10-20T18:13:09Z INF server/middlewares/logger.go:69 > body_size=19 client_id=<IP_ADDRESS> latency="34.72µs" method=GET path=/pcaps/total-size status_code=200
2023-10-20T18:13:12Z INF server/middlewares/logger.go:69 > body_size=19 client_id=<IP_ADDRESS> latency="69.287µs" method=GET path=/pcaps/total-size status_code=200
2023-10-20T18:13:15Z INF server/middlewares/logger.go:69 > body_size=19 client_id=<IP_ADDRESS> latency="41.119µs" method=GET path=/pcaps/total-size status_code=200
2023-10-20T18:13:18Z INF server/middlewares/logger.go:69 > body_size=19 client_id=<IP_ADDRESS> latency="70.716µs" method=GET path=/pcaps/total-size status_code=200
2023-10-20T18:13:24Z INF server/middlewares/logger.go:69 > body_size=19 client_id=<IP_ADDRESS> latency="47.007µs" method=GET path=/pcaps/total-size status_code=200
2023-10-20T18:13:31Z INF server/middlewares/logger.go:69 > body_size=19 client_id=<IP_ADDRESS> latency="19.597µs" method=GET path=/pcaps/total-size status_code=200
2023-10-20T18:13:38Z INF server/middlewares/logger.go:69 > body_size=19 client_id=<IP_ADDRESS> latency="22.415µs" method=GET path=/pcaps/total-size status_code=200
2023-10-20T18:13:40Z INF server/middlewares/logger.go:69 > body_size=19 client_id=<IP_ADDRESS> latency="32.295µs" method=GET path=/pcaps/total-size status_code=200
2023-10-20T18:13:52Z INF server/controllers/socket.go:40 > WebSocket read: error="websocket: close 1006 (abnormal closure): unexpected EOF"
2023-10-20T18:13:52Z INF server/controllers/socket.go:60 > WebSocket is closed!
2023-10-20T18:13:52Z INF server/middlewares/logger.go:69 > body_size=0 client_id=<IP_ADDRESS> latency=1m0s method=GET path=/ws?node=minikube&q=amqp&worker=<IP_ADDRESS>%3A8897 status_code=200
2023-10-20T18:14:08Z INF server/middlewares/logger.go:69 > body_size=19 client_id=<IP_ADDRESS> latency="20.401µs" method=GET path=/pcaps/total-size status_code=200

Hub logs
2023-10-20T18:15:11Z INF server/controllers/socket.go:74 > Iterating a worker host: host=<IP_ADDRESS>:8897 name=minikube
2023-10-20T18:15:16Z INF server/controllers/socket.go:74 > Iterating a worker host: host=<IP_ADDRESS>:8897 name=minikube
2023-10-20T18:15:19Z ERR main.go:67 > License update: error="Status code: 500"
2023-10-20T18:15:21Z INF server/controllers/socket.go:74 > Iterating a worker host: host=<IP_ADDRESS>:8897 name=minikube
2023-10-20T18:15:26Z INF server/controllers/socket.go:74 > Iterating a worker host: host=<IP_ADDRESS>:8897 name=minikube
2023-10-20T18:15:31Z INF server/controllers/socket.go:74 > Iterating a worker host: host=<IP_ADDRESS>:8897 name=minikube
2023-10-20T18:15:36Z INF server/controllers/socket.go:74 > Iterating a worker host: host=<IP_ADDRESS>:8897 name=minikube
2023-10-20T18:15:41Z INF server/controllers/socket.go:74 > Iterating a worker host: host=<IP_ADDRESS>:8897 name=minikube
2023-10-20T18:15:46Z INF server/controllers/socket.go:74 > Iterating a worker host: host=<IP_ADDRESS>:8897 name=minikube
2023-10-20T18:15:48Z ERR pkg/kubernetes/start.go:45 > K8s watch failure: error="error in kubectl pod watch"
2023-10-20T18:15:51Z INF server/controllers/socket.go:74 > Iterating a worker host: host=<IP_ADDRESS>:8897 name=minikube
2023-10-20T18:15:56Z INF server/controllers/socket.go:74 > Iterating a worker host: host=<IP_ADDRESS>:8897 name=minikube
2023-10-20T18:16:01Z INF server/controllers/socket.go:74 > Iterating a worker host: host=<IP_ADDRESS>:8897 name=minikube
2023-10-20T18:16:01Z INF server/controllers/socket.go:56 > WebSocket read: error="websocket: close 1006 (abnormal closure): unexpected EOF"
2023-10-20T18:16:01Z INF server/controllers/socket.go:154 > WebSocket client is closed!
2023-10-20T18:16:01Z ERR server/controllers/socket.go:116 > WebSocket client read: error="read tcp <IP_ADDRESS>:60640-><IP_ADDRESS>:8897: use of closed network connection"
2023-10-20T18:16:01Z INF server/middlewares/logger.go:70 > body_size=0 client_id=<IP_ADDRESS> latency=1m0s method=GET path=/ws?session-token=&refresh-token= status_code=200
2023-10-20T18:16:01Z INF server/controllers/socket.go:110 > Closed connection to the worker at: url=ws://<IP_ADDRESS>:8897/ws?node=minikube&q=amqp&worker=<IP_ADDRESS>%3A8897
2023-10-20T18:16:01Z ERR server/controllers/license.go:27 > error=EOF
2023-10-20T18:16:01Z INF server/middlewares/logger.go:70 > body_size=154 client_id=<IP_ADDRESS> latency="113.876µs" method=GET path=/license status_code=200
2023-10-20T18:16:06Z ERR server/controllers/license.go:27 > error=EOF
2023-10-20T18:16:06Z INF server/middlewares/logger.go:70 > body_size=154 client_id=<IP_ADDRESS> latency="144.658µs" method=GET path=/license status_code=200
2023-10-20T18:16:06Z INF server/controllers/socket.go:66 > Number of currently registered workers: value=1
2023-10-20T18:16:06Z INF server/controllers/socket.go:74 > Iterating a worker host: host=<IP_ADDRESS>:8897 name=minikube
2023-10-20T18:16:06Z INF server/controllers/socket.go:97 > Connecting to the worker at: url=ws://<IP_ADDRESS>:8897/ws?node=minikube&q=amqp&worker=<IP_ADDRESS>%3A8897
2023-10-20T18:16:06Z INF server/controllers/socket.go:105 > Connected to the worker at: url=ws://<IP_ADDRESS>:8897/ws?node=minikube&q=amqp&worker=<IP_ADDRESS>%3A8897
2023-10-20T18:16:08Z INF server/middlewares/logger.go:70 > body_size=157 client_id=<IP_ADDRESS> latency="30.969µs" method=GET path=/pods/targeted?refresh-token= status_code=200
2023-10-20T18:16:08Z INF server/middlewares/logger.go:70 > body_size=19 client_id=<IP_ADDRESS> latency="429.607µs" method=GET path=/pcaps/total-size?refresh-token= status_code=200
2023-10-20T18:16:11Z INF server/controllers/socket.go:74 > Iterating a worker host: host=<IP_ADDRESS>:8897 name=minikube
2023-10-20T18:16:16Z INF server/controllers/socket.go:74 > Iterating a worker host: host=<IP_ADDRESS>:8897 name=minikube

Screenshots
N/A
Desktop (please complete the following information):

OS: Ubuntu 20.04 kernel 5.15.0-86-generic
Web Browser: Chrome

Additional context
Resource utilization of the worker looked stable

I have tried turning off other applications at the same time to free up system resources. I have also tried adjusting the tap.regex setting in the chart to reduce the number of pods we're capturing traffic for to just those of interest.

In case it's useful, the worker always starts up with a failure in tracer and then runs succesfully after a restart. This is the error it crashes with.
2023-10-20T18:20:30Z INF tracer/misc/data.go:20 > Set the data directory to: data-dir=data
2023-10-20T18:20:30Z INF tracer/main.go:41 > Starting tracer...
2023-10-20T18:20:30Z INF tracer/tracer.go:39 > Initializing tracer (chunksSize: 409600) (logSize: 4096)
2023-10-20T18:20:30Z INF tracer/tracer.go:53 > Detected Linux kernel version: 5.15.0-86-generic
2023-10-20T18:20:30Z INF tracer/pkg/pipe/impl.go:50 > Created a named pipe: name=data/pipe.log
2023-10-20T18:20:30Z INF tracer/pkg/pipe/impl.go:57 > Opened the named pipe: name=data/pipe.log
2023-10-20T18:20:30Z ERR tracer/main.go:75 > error="failed to create perf ring for CPU 0: can't mmap: operation not permitted"
panic: failed to create perf ring for CPU 0: can't mmap: operation not permitted

goroutine 1 [running]:
main.run()
	/app/tracer/main.go:49 +0x1b2
main.main()
	/app/tracer/main.go:37 +0x4bf

Here's an example of it not attributing source and destination correctly. This is supposed to be a publish from one of my services to the message broker.

It's still not what I'm expecting, but things do seem to show up more reliably if I put kubeshark in its own namespace on install.


Update Rancher's chart to support updated approach for PSPs

Rancher will need to be updated to handle the new approach designed for PSPs.
The chart will need to be modified include the following option:
global:
  cattle:
     psp:
        enabled: true #PSPs enablement should default to true

A new file will need to be added called validate-psp-install.yaml in the chart/templates directory with the following content:
#{{- if gt (len (lookup "rbac.authorization.k8s.io/v1" "ClusterRole" "" "")) 0 -}}
#{{- if .Values.global.cattle.psp.enabled }}
#{{- if not (.Capabilities.APIVersions.Has "policy/v1beta1/PodSecurityPolicy") }}
#{{- fail "The target cluster does not have the PodSecurityPolicy API resource. Please disable PSPs in this chart before proceeding." -}}
#{{- end }}
#{{- end }}
#{{- end -}}

Any files that render PSPs will need to make that rendering conditional solely on the global.cattle.psp.enabled value, like below:
{{- if .Values.global.cattle.psp.enabled  -}}
apiVersion: policy/v1beta1
kind: PodSecurityPolicy
...
{{- end }}

This approach meets the following requirements:

PSPs should be used by the chart by default, keeping compatibility with the current 2.7.0 approach.
If users attempt to request PSPs  when installing the chart in a cluster which does not support PSPs (for example, a cluster running k8s version 1.25), an error will be presented so that the user knows to change the global.cattle.psp.enabled value to false before continuing.

A solution for this should probably start by reverting rancher/rancher#40089 to re-introduce PSPs to the chart, and then continue by applying the above approach.

Can be validated in Rancher v2.7.2-rc2

QA to validate:

Rancher version
k8s version
psp.enabled flag
hardened jenkins flag
Additional comments
Actual Status

rancher_version=v2.7-head
k8s=1.24
global.cattle.psp.enabled=false
hardened=False
installation goes through

rancher_version=v2.7-head
k8s=1.24
global.cattle.psp.enabled=true
hardened=True
installation goes through

rancher_version=v2.7-head
k8s=1.25
global.cattle.psp.enabled=false
hardened=False
installation goes through

rancher_version=v2.7-head
k8s=1.25
global.cattle.psp.enabled=true
hardened=False
installation fails

rancher_version=v2.7.0
k8s=1.24
N/A
hardened=False
Upgrade rancher to v2.7-head by adding the flag global.cattle.psp.enabled=False  and installation goes through

rancher_version=v2.7-head
k8s 1.24
global.cattle.psp.enabled=true
hardened=True
install rancher and upgrade k8s to 1.25 and  installation goes through

rancher_version=v2.7.0
k8s=1.24
N/A
hardened=True
upgrade rancher to v2.7-head, no global.cattle.psp.enabled flag set as by default it is set to true  and upgrade goes through

I have validated all above test cases on v2.7.2-rc6 and did not see any new issues. I am closing the ticket.


When trying to use SAM the model in my label studio show this error in the logs about the predictions

File "/usr/local/lib/python3.8/site-packages/label_studio_ml/model.py", line 617, in predict
server         |     predictions = cls._current_model.model.predict(tasks, **kwargs)
server         |   File "/app/segment_anything_model.py", line 69, in predict
server         |     height = kwargs['context']['result'][0]['original_height']
server         | TypeError: 'NoneType' object is not subscriptable

my docker-compose
version: '3'

x-vision-common:
  &vision-common
  logging:
    options:
      max-size: "100m"
      max-file: "5"
    driver: json-file

services:
  postgres:
    <<: *vision-common
    image: postgres:13.4-alpine
    container_name: postgres
    restart: always
    environment:
      POSTGRES_DB: ${POSTGRES_DB}
      POSTGRES_USER: ${POSTGRES_USER}
      POSTGRES_PASSWORD: ${POSTGRES_PASSWORD}
    volumes:
      - ./volumes/postgres-data:/var/lib/postgresql/data
  #----------------------------------------------------------------------------
  #                                label Studio
  #----------------------------------------------------------------------------
  labelstudio:
    <<: *vision-common
    image: heartexlabs/label-studio:1.8.0
    container_name: labelstudio
    depends_on:
      - postgres
    environment:
      DJANGO_DB: default
      POSTGRE_NAME: ${POSTGRES_DB}
      POSTGRE_USER: ${POSTGRES_USER}
      POSTGRE_PASSWORD: ${POSTGRES_PASSWORD}
      POSTGRE_PORT: 5432
      POSTGRE_HOST: postgres
      LABEL_STUDIO_DISABLE_SIGNUP_WITHOUT_LINK: "false"
      LABEL_STUDIO_PORT: 80
    ports:
      - 8080:80
  #----------------------------------------------------------------------------
  #                                redis
  #----------------------------------------------------------------------------
  redis:
    image: redis:alpine
    container_name: redis
    hostname: redis
    volumes:
      - "./volumes/redis:/data"
    expose:
      - 6379
  sam:
    container_name: server
    build: ./docker/segment_anything_model/
    environment:
      - MODEL_DIR=/data/models
      - RQ_QUEUE_NAME=default
      - REDIS_HOST=redis
      - REDIS_PORT=6379
      - LABEL_STUDIO_USE_REDIS=true
    ports:
      - 9090:9090
    depends_on:
      - redis
    links:
      - redis
    volumes:
      - "./volumes/sam/data/server:/data"
      - "./volumes/sam/logs:/tmp"

I have the same problem

I have the same problem

Have you checked all of these settings?
https://github.com/heartexlabs/label-studio-ml-backend/pull/253#issuecomment-1640238453

Same problem

I think that is related to #4493

Still having the same..

without changes
error persisted
the individual setting is incomprehensible, maybe it decides something, but it is necessary that it would work in other conditions
or describe exactly what each setting affects

Please watch this video  for setup. If this doesn't help, please send a short clip showing you running the back end, what you do on the front end to receive predictions, and the terminal output on the back end.


[BUG] Chart rancher-provisioning-capi doesn't add tolerations from chart values to post-install hook Job

Rancher Server Setup

Rancher version: v2.10-73a22a6ad (dev)
Installation option (Docker install/Helm Chart): Running as a local process

Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc) : k3s (rancher desktop)

Information about the Cluster

Kubernetes version: 1.30.5
Cluster Type (Local/Downstream): Local

User Information

What is the role of the user logged in? Admin

Describe the bug
When the chart rancher-provisioning-capi is automatically installed by Rancher in the local cluster, it is being passed custom tolerations as of https://github.com/rancher/rancher/pull/47592 through chart values. These are correctly passed to the main deployment of this chart, but not the post-install/upgrade hook job, which causes it not to run if there are taints that were meant to be tolerated.
In addition, the main deployment has default tolerations that are set when no toleration values are passed to the chart. These are also not set by default in the job.
To Reproduce

Before running rancher, add a NoSchedule taint to the nodes in the local cluster.
Start rancher

Result
The rancher-provisioning-capi chart will have most of its objects installed, including the depoyment, but the post install hook will fail because its job won't be able to be scheduled.
Expected Result
The job should also run and the helm installation should complete successfuly.
Additional context
SURE-9229

Still need to forward-port the chart with the fix to dev-v2.11 in rancher/charts and then pin the version in main.


update from upstream

chore(deps): update github/codeql-action action to v3.23.1
chore(deps): update actions/cache action to v4

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.4%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5351

Relevant Lines:
5609

💛  - Coveralls


Incorrectly tracked "healing by damage done skills"

Ele Water Staff Auto
Ele Ice Bow Auto
Ele Warhorn 4 Auto
Ventari Elite
Guardian mace auto
Guardian staff 2
Writ of Persistence symbols

Fixed in 0f033a57dfe5857bbfb744f0a83150538f7b6454


A not published package as a peer dependency

When I install the library, I get the message:
<EMAIL_ADDRESS>has incorrect peer dependency "<EMAIL_ADDRESS>There are no versions above 1.3.0 of @date-io/core on npm

Fixed in 3.0

When I install the library, I get the message:
<EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>I am using the latest version of @material-ui/pickers

@cjmyles You need to install it. We have hidden this aspect to users in the next major (v4.0.0-alpha.4 as we are speaking).


UP_PERMISSION does not have a primary key

Describe the bug
Table does not have a primary key. This is needed for some db features such as replication in SQL Server.
To Reproduce
Steps to reproduce the behavior:

run gradlew dataInit

Expected behavior
Tables should have primary keys
Additional context
Effort likely entails adding an ID column and sequence.

This should not be a compound key ? It would permit to set a unique key based on nearly all keys, and it would avoid problems for large uses !
I suggest this change to avoid database migration problems, and the change would be more easy than adding a primary key (which would need to stop the service export datas before to truncate and recreate the table and import database, unlike a simple one alter table to run)


docs: libp2p private RT integration

Start off with Go LibP2P library's example and this example to create a LibP2P host.
The Go LibP2P Kad DHT library is used internally by the Go LibP2P library, as seen from the second example. We will probably need to have private implementations of the FindPeers and FindProviders methods. Both of these might internally lookup GetClosestPeers, which would need to be modified as well.
The Go LibP2P Bucket library is also used internally by Go LibP2P.

Protobuf schemas and PB messages: GetClosestPeers and GetProviders should replace their last arguments (id and key respectively) with private versions and create the corresponding ‘pmes’ variables. The PB schemas themselves only need minimal modifications, if any: the records are just key/value pairs, so any encrypted outputs can probably be made compatible.
Routing.go is the main high-level file whose function implementations will need to be modified. Both FindPeer and FindProviders ultimately make a call to query.go’s runLookupWithFollowup method. The third argument to this call is a querying function, which calls the PB messenger functions (peer, provider) with the non-private arguments. We need to have private implementations of these functions that call the underlying PB messages with private args.
Query.go is another high-level file, which essentially runs the main “querying loop”, handling when to terminate etc. Its runLookupWithFollowup function is called by the provider and peer lookup  functions in routing.go. I expect that we’ll need to change this file minimally.

The min function in the kbucket repo may be used when constructing a normalized routing table. The "less than" operator passed in as a parameter will have to incorporate some processes from the normalization algorithm.


Page shows "SITE_NAME" placeholder, yet it is not blank in the config.php

Hey there! At https://host.networkbay.org/ the "SITE_NAME" does not show up at NetworkHost like I have set it to. However on the admin page, it does.
https://i.imgur.com/rLpYQ2j.png
Also you might want to take a look at the countdown timer since it displays as a "-"

edit incudes/header.php

<?php
include __DIR__."/connect.php";
?>

-->
<?php
include __DIR__."/config.php";
?>

Error had been fixed thank you

Hey there! At https://host.networkbay.org/ the "SITE_NAME" does not show up at NetworkHost like I have set it to. However on the admin page, it does.
https://i.imgur.com/rLpYQ2j.png
Also you might want to take a look at the countdown timer since it displays as a "-"

If you want to change countdown timer you need to change it in /clientarea/includes/footer.php


JSON-LD for BrAPI v2

Since the general feedback on the JSON-LD discussion seemed to positive (slides online). I am creating this issue to details the necessary steps to follow for the integration of JSON-LD into BrAPI specifications.
Minimum BrAPI V2 specifications for JSON-LD integration:

Create a BrAPI OWL ontology model that just copies the existing BrAPI JSON schema into RDF  (prototype ontology available here)
Create JSON-LD contexts mapping BrAPI json fields to BrAPI ontology fields

One JSON-LD context for each call (prototype contexts available here)
Host JSON-LD context files on brapi.org or on github/plantbreeding?

Add JSON-LD fields on every BrAPI calls (@context, @type, @id or PUI fields)
Require URI for every BrAPI object

Choose if we want to use @id field or PUI fields (germplasmPUI, studyPUI, etc.)
Document the recommended way to handle URI

Use URI from public data repositories (ex: NCBI taxon URI)
Generate UUID (see UUID URI scheme)
Register your BrAPI object as DOI from http://doi.org
Concatenate URI (something like urn:{institution}/{entity}/{id}, ex: urn:inra.fr/study/BW1293)

Minimum V2 changes for BrAPI servers:

Handle URIs for every BrAPI object (@id or PUI fields)
Add static @context and @type fields in BrAPI responses

Less essential changes (maybe for V2.x?):

Addition of a new "Get BrAPI object by URI" call for HATEOS like object to object navigation
Define controlled vocabullary for some of the BrAPI fields (like observation levels) (related to #56)
Import or cross-reference external ontologies inside the BrAPI ontology

MCPD ontology?
CropOntology?
Plant Phenotyping Experiment Ontology?

Related issues: initial JSON-LD discussion #42, BrAPI object links #187, Controlled vocabullaries #56

Difference between using @id and PUI fields for BrAPI JSON-LD
Before JSON-LD:
{
  "metadata": {},
  "result": {
    "studyDbId": "BW1304",
    "studyName": "Breed Wheat Dijon",
    "locationDbId": "203",
    "locationName": "Dijon"
  }
}

With JSON-LD and PUI fields:
{
  "@context": "...",
  "metadata": {},
  "result": {
    "@type": "brapi:Study",
    "studyPUI": "urn:inra.fr/study/BW1304",
    "studyDbId": "BW1304",
    "studyName": "Breed Wheat Dijon",
    "locationPUI": "urn:inra.fr/location/203",
    "locationDbId": "203",
    "locationName": "Dijon"
  }
}

With JSON-LD and @id fields:
{
  "@context": "...",
  "metadata": {},
  "result": {
    "@type": "brapi:Study",
    "@id": "urn:inra.fr/study/BW1304",
    "studyDbId": "BW1304",
    "studyName": "Breed Wheat Dijon",
    "location": {
      "@type": "brapi:Study",
      "@id": "urn:inra.fr/location/203",
      "locationDbId": "203",
      "locationName": "Dijon"
    }
  }
}


Dialogs app file browser wrapper

Add a safe Rust wrapper for the dialog file browser methods and the
DialogsFileBrowserOptions type. Rename the DialogsApp::show() method
to show_message() and create new show_file_browser() method. Add a
getter method to FuriString to provide access to the inner
sys::FuriString via a raw pointer because a sys::FuriString is needed by
a few of the Furi C API functions. Extend the storage example to open a
file browser and have the user select the file that was just written to
the file system.
Note: The Furi C struct is named DialogsFileBrowserOptions, but all
other dialog types and functions are singular instead of plural. The
Rust type is named DialogFileBrowserOptions.
The DialogFileBrowserOptions type uses setter methods that return Self
so they can be chained together in the builder pattern. The
DialogFileBrowserOptions includes a Rust unit type phantom data member.
The type or size does not really matter, but PhantomData does require a
sized type. We just need one struct member to carry the lifetime
parameter so that CStr and Icon references are not dropped until the
struct goes out of scope.

@JarvisCraft are you ok with merging this now?

I actually am not the one with push permissions, so I summon @dcoles and @str4d for this purpose :)

After inspecting the flipperzero-firmware code, dialog_show_file_browser() will not modify the preselected file path FuriString, but some common storage processing functions will replace /ext, /app, /any prefixes depending on the context. I think pub(crate) fn as_mut_ptr(&mut self) -> *mut sys::FuriString make sense, at least for the show_file_browser() usage. Is everyone in agreement?

Also, is there anything I need to do with this PR to get the Clippy (MSRV) lints CI to succeed?

@dcoles @JarvisCraft @str4d Are there any remaining issues or is this PR able to be merged?

Also, is there anything I need to do with this PR to get the Clippy (MSRV) lints CI to succeed?

@str4d Would you be able to take a look at this? I'm not quite sure why the beta is fine, but MSRV is throwing a Unable to run @augu/clippy-action: HttpError: Resource not accessible by integration.

@dcoles @JarvisCraft @str4d Are there any remaining issues or is this PR able to be merged?

Yes, let's get this merged. Thanks very much for your patience and for the PR!

Cheers, thanks!


Perpetual protocol - Getting error for unsupported  'NoneType' and 'decimal.Decimal'

Describe the bug
When running Perpetual connector for long term, we noticed that after a sudden network change on our AWS instance, the client would return an warning of WARNING - Error on POST resulting to logs kept reporting Unhandled error in background task: unsupported operand type(s) for -: 'NoneType' and 'decimal.Decimal'
2022-09-08 07:45:35,051 - 99724 - GatewayEVMPerpetual - WARNING - Error on POST https://localhost:25393/amm/perp/market-prices Error: {'message': 'Unknown error.', 'httpErrorCode': 500, 'errorCode': 1099, 'stack': 'Error: Unknown error.\n    at /usr/src/app/dist/src/connectors/perp/perp.controllers.js:24:19\n    at Generator.throw (<anonymous>)\n    at rejected (/usr/src/app/dist/src/connectors/perp/perp.controllers.js:6:65)'}

2022-09-08 07:45:35,186 - 99724 - GatewayEVMPerpetual - WARNING - Error on POST https://localhost:25393/amm/perp/market-prices Error: {'message': 'Unknown error.', 'httpErrorCode': 500, 'errorCode': 1099, 'stack': 'Error: Unknown error.\n    at /usr/src/app/dist/src/connectors/perp/perp.controllers.js:24:19\n    at Generator.throw (<anonymous>)\n    at rejected (/usr/src/app/dist/src/connectors/perp/perp.controllers.js:6:65)'}

2022-09-08 07:45:35,187 - 99724 - hummingbot.core.utils.async_utils - ERROR - Unhandled error in background task: unsupported operand type(s) for -: 'NoneType' and 'decimal.Decimal'
Traceback (most recent call last):
  File "/home/ubuntu/perp/hummingbot/core/utils/async_utils.py", line 9, in safe_wrapper
    return await c
  File "/home/ubuntu/perp/hummingbot/strategy/spot_perpetual_arbitrage/spot_perpetual_arbitrage.py", line 207, in main
    proposals = [p for p in proposals if p.profit_pct() >= self._min_opening_arbitrage_pct]
  File "/home/ubuntu/perp/hummingbot/strategy/spot_perpetual_arbitrage/spot_perpetual_arbitrage.py", line 207, in <listcomp>
    proposals = [p for p in proposals if p.profit_pct() >= self._min_opening_arbitrage_pct]
  File "/home/ubuntu/perp/hummingbot/strategy/spot_perpetual_arbitrage/arb_proposal.py", line 59, in profit_pct
    return (sell_price - buy_price) / buy_price
TypeError: unsupported operand type(s) for -: 'NoneType' and 'decimal.Decimal'

There are also instances of ValueError' object is not subscriptable
TypeError: unsupported operand type(s) for -: 'NoneType' and 'decimal.Decimal'
2022-09-08 07:46:03,012 - 99724 - GatewayEVMPerpetual - ERROR - 'ValueError' object is not subscriptable
Traceback (most recent call last):
  File "/home/ubuntu/perp/hummingbot/connector/gateway/amm/gateway_evm_perpetual.py", line 457, in _status_polling_loop
    await safe_gather(
  File "/home/ubuntu/perp/hummingbot/core/utils/async_utils.py", line 22, in safe_gather
    return await asyncio.gather(*args, **kwargs)
  File "/home/ubuntu/perp/hummingbot/connector/gateway/amm/gateway_evm_perpetual.py", line 556, in update_positions
    trading_pair = f"{position['base']}-{position['quote']}"
TypeError: 'ValueError' object is not subscriptable
2022-09-08 07:46:07,011 - 99724 - GatewayEVMPerpetual - WARNING - 'markPrice'
2022-09-08 07:46:07,091 - 99724 - GatewayEVMPerpetual - WARNING - Error on POST

Tried to replicate on local connection by disconnecting and got the errors instantly. Tried to leave the client for 3-4hours. Noticed that it was able to found an arbitrage but this time we are able to reproduce the issue related to ValueError' object is not subscriptable

Impact
We observed that the strategy and perp protocol is able to work since its trying to find arbitrage but there are intances of this issues related to this PR whenever a sudden change or disconnection of network happened.
Steps To Reproduce

Setup Hummingbot client with gateway on AWS instance (since it would need a while to trigger)
Setup perp wallet
Setup spot-perpetual-arbitrage (paper_trade for CEX would do) and use perp as derivative connector
Start the strategy and leave for a while or overnight
Check the client and docker logs

Release version
Development branch dev-1.8.0
Attachments
09122022.zip

Severity: P2
Bounty: 50000 (https://hummingbot.org/maintenance/bugs/)
Rationale: Bug related to a Perpetual protocol connector on gateway

Assigning this PR to @vic-en. Thank you for your contribution!

Hi @vic-en, can you please provide us an update of the progress of this bounty?

@JeremyKono I'm still on this.
I encountered more errors than described.
Overall, I should be able to make a pr on or before the end of this week.

https://github.com/hummingbot/hummingbot/pull/5885

Fix has been deployed to version 1.12.0


marshal/unmarshal methods for simple lists

Currently the MarshalXML and UnmarshalXML methods for  types are stubs

Fixed with 9e3393b092e5db780dd3b37902b04207763241e2


Component inspector header static

Keep header static.
Before:

After:

I think it will be better to have the filter and inspect button right-aligned by letting the component name take the remaining space

btw, why does the selected tab marker looks off for you?

I'll show the image with your suggestions, and then I'll fix the pull request.

btw, why does the selected tab marker looks off for you?

I've added a margin to improve the preview of the gif, but I'll avoid doing that.

Organize the items in the action header
Updates

Right-aligned buttons
Space for title

Press ESC to close import
Right-aligned buttons
Maybe add the type as title?


Add requirement to realize locality optimized search.

https://cockroachlabs.atlassian.net/browse/DOC-720

This change is

v21.2/cost-based-optimizer.md, line 117 at r1 (raw file):
Previously, rytaft (Rebecca Taft) wrote…
The need for CHECK constraints isn't really related to locality optimized search. I guess it will become relevant in 22.1 when we add support for using locality optimized search with LIMIT, but it's not relevant for LOS in 21.2.
Users of partitioned tables who are not using the new multi-region abstractions should consider explicitly adding aCHECK constraint or using an ENUM type column on the partitioning column(s) for general improved performance. Note that as far as the optimizer is concerned, an ENUM type is equivalent to a CHECK constraint since it limits the possible column values to a finite set of known values. Using an ENUM type / CHECK constraint for the partitioning column(s) is especially helpful for tables that use PARTITION BY LIST if users want to ensure that the optimizer can effectively avoid scanning data that's not necessary for the query. The CHECK constraint or ENUM column should restrict the possible values of the partitioning column to those that map to partitions according to the PARTITION BY LIST clause. DEFAULT partitions and PARTITION BY RANGE should be avoided for best performance.
Users of the new multi-region abstractions need not concern themselves with this. The crdb_region column is the default partitioning column for REGIONAL BY ROW tables, and it already has an ENUM type. This is another reason why the new multi-region abstractions are easier to use -- there's no need to think about the need for a CHECK constraint / ENUM -- it's already taken care of.
CHECK constraints and ENUM types are also helpful on non-partitioning columns in general, since it gives the optimizer more information about the allowed values of a column, and enables various different types of optimizations. This applies to non-partitioned and non-multi-region tables as well.
Let me know if this is confusing or you want more info...

Another important note is that in order for the optimizer to take advantage of CHECK constraints and ENUM type columns, the expression cannot evaluate to NULL. As a result, these optimizations only apply to columns that are also NOT NULL.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @stbof)

v21.2/cost-based-optimizer.md, line 117 at r1 (raw file):

### Requirements

To realize locality optimized search you must specify a [`CHECK` constraint](check.html) when you create the table. For example, if you typically perform a query that has a locality constraint:

The need for CHECK constraints isn't really related to locality optimized search. I guess it will become relevant in 22.1 when we add support for using locality optimized search with LIMIT, but it's not relevant for LOS in 21.2.
Users of partitioned tables who are not using the new multi-region abstractions should consider explicitly adding aCHECK constraint or using an ENUM type column on the partitioning column(s) for general improved performance. Note that as far as the optimizer is concerned, an ENUM type is equivalent to a CHECK constraint since it limits the possible column values to a finite set of known values. Using an ENUM type / CHECK constraint for the partitioning column(s) is especially helpful for tables that use PARTITION BY LIST if users want to ensure that the optimizer can effectively avoid scanning data that's not necessary for the query. The CHECK constraint or ENUM column should restrict the possible values of the partitioning column to those that map to partitions according to the PARTITION BY LIST clause. DEFAULT partitions and PARTITION BY RANGE should be avoided for best performance.
Users of the new multi-region abstractions need not concern themselves with this. The crdb_region column is the default partitioning column for REGIONAL BY ROW tables, and it already has an ENUM type. This is another reason why the new multi-region abstractions are easier to use -- there's no need to think about the need for a CHECK constraint / ENUM -- it's already taken care of.
CHECK constraints and ENUM types are also helpful on non-partitioning columns in general, since it gives the optimizer more information about the allowed values of a column, and enables various different types of optimizations. This applies to non-partitioned and non-multi-region tables as well.
Let me know if this is confusing or you want more info...

So does the recommendation in https://cockroachlabs.atlassian.net/browse/DOC-720 apply to the old way of handling multi-region data? If so, where would it be appropriate to document this?  See https://cockroachlabs.atlassian.net/browse/DOC-2718 for a discussion of  issues with the old docs.

v21.2/cost-based-optimizer.md, line 117 at r1 (raw file):

So does the recommendation in https://cockroachlabs.atlassian.net/browse/DOC-720 apply to the old way of handling multi-region data?

That's correct -- the Zendesk ticket referenced in that issue was all about how to avoid high latencies with the old multi-region primitives.

If so, where would it be appropriate to document this? See https://cockroachlabs.atlassian.net/browse/DOC-2718 for a discussion of issues with the old docs.

I think it's probably important to keep documentation around somewhere for the old-multi-region primitives, since the new multi-region abstractions cannot yet cover all use cases, and migration from old to new also seems to be difficult. Ideally there would be a disclaimer at the top saying that the new abstractions are the preferred approach to multi-region, but power users or those with special circumstances / legacy setups could still use the old approach.

There is a problem with the old documentation as described in the cited issue. The v21 (and soon v22) docs point to links in the v20 docs because those docs weren't moved forward. The links are confusing because v20 is scheduled to go out of support in May 2022 and there is a warning to that effect. In May the v20 docs will say that the version is not supported, which is not helpful even if the old features are still supported in the product. IOW, if there are no docs for a feature in the current version of the docs, effectively the feature is not supported.  https://cockroachlabs.atlassian.net/browse/DOC-2718 is saying that either we need to move those docs forward to the current version, or stop supporting those features. Please comment in that Jira if you feel strongly one way or the other.

v21.2/cost-based-optimizer.md, line 117 at r1 (raw file):
Previously, stbof (Stephanie Bodoff) wrote…
There is a problem with the old documentation as described in the cited issue. The v21 (and soon v22) docs point to links in the v20 docs because those docs weren't moved forward. The links are confusing because v20 is scheduled to go out of support in May 2022 and there is a warning to that effect. In May the v20 docs will say that the version is not supported, which is not helpful even if the old features are still supported in the product. IOW, if there are no docs for a feature in the current version of the docs, effectively the feature is not supported.  https://cockroachlabs.atlassian.net/browse/DOC-2718 is saying that either we need to move those docs forward to the current version, or stop supporting those features. Please comment in that Jira if you feel strongly one way or the other.
In any case, I will back out this change in the CBO doc until I have guidance on where to put this information.

I just commented on the jira ticket.

This is now simply style fixes.


Need to add sample scenarios for privetJet and sidecar modes

Description:
Need to add sample scenarios for privetJet and sidecar modes so that users can easily test.
Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

Resolved in https://github.com/wso2/k8s-apim-operator/pull/88


Proposal to add dev branch

Perhaps it would be better if people would target a dev branch for pull requests.

For a normal project I would agree, but this library is quite stable and there isn't any active development. The only changes are bug fixes. Introducing another branch would make the admin from the maintainer's side more. Is it really worth it?


Dutch translation

Hi @jelmervisser ,
Thanks a lot for the PR. Just merged it into dev, it will be available on the master branch very very soon.
Cheers!


Unable to resolve diagnostics listener with dependencies

In Hot Chocolate 11 I've been unable to add any diagnostics listeners that have a constructor dependency.  Ones with the default constructor work correctly, but the others fail with a message

System.InvalidOperationException: Unable to resolve service for type 'Microsoft.AspNetCore.Http.IHttpContextAccessor' while attempting to activate 'Notifications.Api.GraphQL.TestDiagnosticEventListener'.

I've verified that the dependency is registered and other services can correctly resolve it.
I've reproduced the bug as a unit test on the following branch.

We just ran into this issue as well. It is almost as if Hot Chocolate has its own dependency injection container.

@jmezach  It kind of has, but unless you work with error handler or diagnostice listeners you do not have to worry about it :)
If you have one schema there are three service providers.

The application SP that you configure in ConfigureServices
The schema service provider that is used for schema related things (specific to each schema)
The execution service provider, a scoped of a service provider that combines the two above

During development this is opaque to you, unless you do create DiagnosticListeners or ErrorFilters (SP 2.) with dependencies on application services (SP 1.).
You have to register it like this:
given @nigel-sampson  sample you would have to register the diagnostic listener like this:
private class DependentListener : DiagnosticEventListener
{
    private readonly IDependency dependency;

    public DependentListener(IDependency dependency)
    {
        this.dependency = dependency;
    }
}

private interface IDependency
{
}

private class Dependency : IDependency
{
}

services.AddGraphQLServer()
      .AddDiagnosticListener(x => new DiagnosticListener(x.GetApplicationService<DependentListener>));

cc @michaelstaib  if i got the above right, i will add it to the docs

After posting here I figured this out on my own ;). I solved it by adding my DiagnosticEventListener as a singleton to my application container using AddSingleton<> and then using AddDiagnosticEventListener(sp => sp.GetApplicationService<InsightsDiagnosticEventListener>()). That at least solves the startup issue.
Interestingly my event listener doesn't seem to be invoked though. I've overriden RequestError from the DiagnosticEventListener but that method isn't called, even though an error occurs during my request (I've taken the database offline).

@jmezach do you have a simple repro?

Can we close this issue?

I think so. Understanding the different service provides is key here.  Definitely a candidate for inclusion in the docs.


OSD-15552: Add ocm-token to kubeconfig

What type of PR is this?
feature
What this PR does / Why we need it?
Add ocm token to kube config file
Which Jira/Github issue(s) does this PR fix?
https://issues.redhat.com/browse/OSD-15552
Pre-checks (if applicable)

[x] Ran unit tests locally
[x] Validated the changes in a cluster
[ ] Included documentation changes with PR

Codecov Report

Merging #61 (00732db) into main (0040057) will decrease coverage by 0.47%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   41.82%   41.35%   -0.47%
==========================================
  Files          37       37
  Lines        2202     2164      -38
==========================================
- Hits          921      895      -26
+ Misses       1136     1130       -6
+ Partials      145      139       -6

Impacted Files
Coverage Δ

cmd/ocm-backplane/login/login.go
70.22% <100.00%> (+0.40%)
:arrow_up:

/lgtm