No API Key

Hi everybody,
I have installed the Deconz adapter, but I don't get a connection. With "Hue Essentials" I was able to get a API key, but with the same IP and Port in ioBroker it doesn't work.
deconz.0	2021-02-16 18:53:14.078	error	(1075) Could not connect to deConz/Phoscon. Error: connect EHOSTUNREACH <IP_ADDRESS>:8081
deconz.0	2021-02-16 18:53:02.411	error	(1075) Could not connect to deConz/Phoscon. Error: connect EHOSTUNREACH <IP_ADDRESS>:8081
deconz.0	2021-02-16 18:51:08.000	warn	(1075) No API Key found
deconz.0	2021-02-16 18:51:07.941	info	(1075) starting. Version 1.3.11 in /opt/iobroker/node_modules/iobroker.deconz, node: v12.20.2, js-controller: 3.2.16
host.iobroker	2021-02-16 18:51:05.491	info	instance system.adapter.deconz.0 started with pid 1075
host.iobroker	2021-02-16 18:51:03.489	info	instance system.adapter.deconz.0 terminated with code null
Does anybody have an idea?

8081

Normal the port of deconz is 80 or 8080. So i think you do not use the right port.

8081

Normal the port of deconz is 80 or 8080. So i think you do not use the right port.

I've changed the port to 8081 before. To check I've changed it back to 8080, but same problem. I think it doesn't have something to do with the port, because as I mentioned it is working with other third party apps like Hue essentials without any problems. Could it have something to do with the versions of node.js etc? I think, I was reading something like this but didn't found a solution...

The error message is clear, the adapter can not connect to the deconz. Which means there is a network (configuration) problem or a firewall that blocks the connection.

Hi @Jey-Cee  I'm expiring the "same" issue
I'm not able to get an Api key via ioBroker frontend deconz adapter configuration with version 1.3.11
If I'm trying it the manual way /api  {"devicetype":"name"} -> I recieve a valid response with a api key
also if I try to ad this key manually the error is the same
`
|   |   |
-- | -- | -- | --
deconz.0 | 2021-03-15 21:39:03.975 | debug | (3312) Websocket connection closed
deconz.0 | 2021-03-15 21:39:03.971 | warn | (3312) Could not connect to websocket instance of deConz/Phoscon. Error: connect EHOSTUNREACH <IP_ADDRESS>:443
deconz.0 | 2021-03-15 21:39:03.968 | error | (3312) Could not connect to deConz/Phoscon. Error: connect EHOSTUNREACH <IP_ADDRESS>:80
deconz.0 | 2021-03-15 21:39:00.791 | info | (3312) starting. Version 1.3.11 in /opt/iobroker/node_modules/iobroker.deconz, node: v12.21.0, js-controller: 3.2.16
`
the deconz service is runing on port 80 and port 80 is set up in the adapter configuration - I also tried without "80" because 80 is quite default but it didn't help
It worked before - a power unplug of the Raspberry Pi destroyed everything ;-)  NO but so I assume its not a network communication related issue only layer 8 :-)
Best regards
André

Hi @adgo,
without more information it is impossible for me to help here. As i said before, normal this is not a problem with the adapter.
If you still expirience this problem we can do a remote session and i will have a look on your setup.
Otherwise please describe how you solved this problem.
Greets
Jey Cee

Thanks for your offer - in the meantime I found out that the reboot killed a network bridge between host and docker so there was really no network communication - so this is no software issue - as I already supposed - layer-8
thanks
BR André

Thanks for your reply


Add Docker files to client and server

#38

Codecov Report

Merging #41 into master will not impact coverage.

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   96.72%   96.72%
=======================================
  Files          13       13
  Lines         122      122
  Branches        3        3
=======================================
  Hits          118      118
  Misses          3        3
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e769da...6b3956e. Read the comment docs.


Fix databag globbing issues for chef-solo on windows

Backslashes should not be passed to Dir, as it does not work
when globbing in many cases.
Created new function that can be used with dir on windows.
escape_glob_dir should be used when the result is going
to be passed into Dir.
Fixes #4194
Replaces #4195

Looks like there's a spec failure on windows and then chefstyle updates, but please let's get this merged! :)

@lamont-granquist and I have already :+1: the original, so I think you can merge as soon as the above are happy

@jaym it looks to me like the code is correct, but your spec is testing the wrong behavior.  if you just fix the spec you can merge.  :+1:

I think we need https://github.com/chef/chef/pull/4569 to fix windows


Stack trace line number

OS:

[X]  MacOS

Platform:

[X]  iOS

v8.9.3
5.5.1

Config:
<EMAIL_ADDRESS>{
  logLevel: SentryLog.Debug, // default SentryLog.None | Possible values:  .None, .Error, .Debug, .Verbose
        disableNativeIntegration: false, // default: false | Deactivates the native integration and only uses raven-js
        handlePromiseRejection: true, // default: true | Handle unhandled promise rejections
        ignoreModulesExclude: [], // default: [] | Exclude is always stronger than include
        ignoreModulesInclude: [], // default: [] | Include modules that should be ignored too
}).install()

We see no line number for JS file in stack trace on dashboard. In this example we expected to see app_thunks.js:147:8. Is it configurable?
Actual result:

Expected result:

+1

It looks like you didn't upload the source maps.
There should be a Run script in your Xcode project uploading them.
You can also do it manually, make sure release/dist are the same as in the app
https://docs.sentry.io/clients/react-native/sourcemaps/


[ZW-4446] Title: Use SQS as communications for Electrum subscriptions and notifications

LGTM. Left minor comments.
One question:
Did you give thought to whether this would work on the public nodes (for local tests and CI)?


DDT-990: Rename ShipmentEquipment -> UtilizedTransportEquipment

Signed-off-by: Niels Thykier<EMAIL_ADDRESS>

Depends on https://github.com/dcsaorg/DCSA-Event-Core/pull/275


CI Pipeline

What is this PR doing?

Add Github Actions CI pipeline for each component in BLS Wallet to perform linting, type checking/building, and tests.
Update labeler with aggregator-proxy and docs.
Split aggregator premerge program into typescript check & lint todos programs.
Add fundDeployer hardhat task to simplify contract setup for local dev & CI.
Add engine fields for NodeJS and yarn to most package.jsons.
Switch a number of existing lint errors & disables to warnings.

How can these changes be manually tested?

Look at actions (checks) logs and that last commit has :white_check_mark:
Try the simplified local setup steps from ./docs/local_development,md

Does this PR resolve or contribute to any issues?
Resolves https://github.com/web3well/bls-wallet/issues/48
Checklist

[x] I have manually tested these changes
[x] Post a link to the PR in the group chat

Guidelines

If your PR is not ready, mark it as a draft
The resolve conversation button is for reviewers, not authors

(But add a 'done' comment or similar)

TODO

[x] aggregator
[x] aggregator-proxy
[x] contracts
[x] clients
[x] extension
[x] Test scenario like in this PR where commits may be on different dirs. I.e. failures on prev commit in extension might pass status checks if contracts commit passes.

This is really awesome 💪. Thank you.


Missing comma in generated docs for Deployment Status state parameter

What article on docs.github.com is affected?
https://docs.github.com/en/rest/reference/repos#create-a-deployment-status--parameters
What part(s) of the article would you like to see updated?
The values for the state parameter. There is a missing comma between queued and pending. This is impactful because it's misleading when users select+copy the list of states and paste them into code (as an enum, say). I believe this section of the docs is auto-generated so I can't submit a PR directly.
Additional information

Thanks for opening an issue @jasonkarns! I'll triage this for the team to take a look 👀


Provide default WORKER_INITs in some server config

We have the flexible WORKER_INIT to handle setting environment variables for cache directories, which has proven to be very useful. We should keep this as something the user can add to.
But for our default workflows using fractal-tasks-core, the settings for WORKER_INIT are always the same. Typically, they are:
BASE_CACHE_DIR=${HOME}/.cache
WORKER_INIT="\
export CELLPOSE_LOCAL_MODELS_PATH=$BASE_CACHE_DIR/CELLPOSE_LOCAL_MODELS_PATH
export NUMBA_CACHE_DIR=$BASE_CACHE_DIR/NUMBA_CACHE_DIR
export NAPARI_CONFIG=$BASE_CACHE_DIR/napari_config.json
export XDG_CONFIG_HOME=$BASE_CACHE_DIR/XDG_CONFIG
export XDG_CACHE_HOME=$BASE_CACHE_DIR/XDG
"

And at FMI, we also specify some proxy settings to allow model download from cellpose.

It would make sense to abstract this away from the user, so that they don't need to set those variables themselves every time. Especially with a view towards submission from the web interface (see https://github.com/fractal-analytics-platform/fractal-web/issues/86), it doesn't make much sense to have users enter this in the web frontend.
Thus, we'd want to get to a point where we can have preset WORKER_INITs which are always run first, followed by optional additional WORKER_INITs provided by the user.
This comes with 3 questions:

Where do we configure those WORKER_INITs such that it can be set up for a given server deployment?

How do we still make the cache-dir user-specific (because the user needs to be able to write there).

How do default WORKER_INITs interact with user-specified WORKER_INIT

could be some json file or something similar provided on server start-up

I think the answer would be using the newly created user.cache_dir. If we can set the BASE_CACHE_DIR=${user.cache_dir}/.cache and user.cache_dir is also provided as part of the WORKER_INIT, then that would be a great default!

I think we should maintain a user-defined WORKER_INIT. Typical use-cases: Someone hits a new edge-case where they need an env-variable set, e.g. during task development or by using tasks in a way we hadn't tested before. I think if we just add the user-provided WORKER_INIT after the server-default, then the user could even overwrite those cache folders if they wanted to do so

If we're able to get rid of the standard WORKER_INIT, that will be a great way of simplifying both the example scripts and making the web submission easier :)

Goes in slurm config file, we will have user.cache_dir prepended to all the values
Proxies should go into extralines (=> @jluethi needs to figure out which one to set).
TODO: Check that default extralines are not overwritten when we add additional ones (=> @tcompa )
WORKER_INIT will still be available for users, but would


How to setting the video height and width???

as the title, does anyone know how to set the height and width when using the mat-video? Just like, when we use HTML we can set like ""

like { video width="500" height="300"} by the way , why i can not input <      >


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/36006

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/36879

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/39535

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/48946

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/67689

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/74716

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/79369


Pagination Breaks After Edit

Reproduction

Vote and create argument
Edit argument and save
Click on any page in the pagination.

The pagination links go to https://rfc.stitcher.io/livewire/message/argument-list?page=2. Which obviously doesn't work.
Suspect this has something to do with the pagination being based on the previous request.

Yep, I can confirm it. This is what I get locally:


Math.random() usage

As part of our company's security policy, we run all our application through fortify scan. Fortify scan raised a flag  where Math.random() has been used in this package. It is suggesting to replace with window.crypto.getRandomValues(new Uint32Array(10))[0]. Could you please have a look. Thank you.

the only place Math.random is used is to randomise the Redux internal actions, to ensure developers don't try and respond to them specifically. This is not anything that should be of a security concern.

Also, having prior experience with Fortify, I can vouch that many of its rules are stupid, and this one in particular.

Thank you for confirming.


Button issue

Is your feature request related to a problem? Please describe.
I don't know why it only show two buttons in the newest version, I check the setting but found not ways to deal with it.
Describe the solution you'd like
add the button good, and respectively add the setting for reoccur days

and also maybe can make the button bigger and be in the middle

Hi @HilariousJon please let us know what platform you are using:
-   OS: [e.g. iOS]
-   Obsidian version: [e.g. v0.12.4]
-   Plugin version: [e.g. v1.4.9]

Also send screenshots.

OS：windows11
Obsidian version: v1.5.8
plugin veision: v1.11.1

some times it will come out three button and sometimes not, if it came as three button it will turns out that the button not go at the middle,,,,,and now I couldn't figure out how to get three buttons out.
also I wanna ask that how to delete the time mark left by the plugin after every time it came out  a 3 button, because that somehow make my note ugly.or could it be just make some improvement to not showing it under the reading mode.
Think that maybe you should update your manual, since the version has changed a lot.
I think that you can put more flexibility in the setting, so the user can define some function as they wish.
I think the plugin has a more comfortable user interface than anki, but still some function cannot achieve as good as anki, can it be improved

Hi @HilariousJon
There are two separate ways that cards can be viewed:

Review mode
Cram mode

In review mode, three buttons are shown, and based on which button is selected, the scheduling info kept within the HTML comment is updated differently.
In cram mode, two buttons are shown and the scheduling info is not updated.
From the Obsidian command pallet, entering "flashcard" shows the following:

Note that clicking on the plug-in's flashcard icon, specifies review mode.
Cheers
Ronny

I see....

final issue is can these three button be go to the middle and get bigger?

@KyleKlus has been looking at this, see #872

ok, Thanks for the answers!!!


Add support for including comments in Zendesk source

The default zendesk source does not (as far as I can tell) include comments which are added to tickets. It's quite easy for users of DLT to update the existing source code to include it if they read how to on the Zendesk documentation, but I think it would make it easier for DLT users if this was included as an option in the existing code.
Per my discussion on slack here, I'm raising an issue for this and will raise a PR shortly to implement this.

Yes, I'm already a dlt user.
Proposed solution
Per the zendesk documentation, use sideloading to include comments. This means adding "include": "comment_events" in the parameters to the /api/v2/incremental/ticket_events.json endpoint.
I'm open to suggestions on whether this should be included by default or not. My initial thought was to add a flag here for whether to include ticket comments, with a default value of False.
Apologies if I've raised the wrong type of issue for this. I wasn't sure if this counted as extending a source.

draft pr for discussion here


what a mess lol (convert java to kotlin, remove dupe copyright headers)

done w/ intellijs java to kotlin converter, some adjustments here and there but nothing broke when i ran it so have fun

@Cubxity requested a request, ok:

In NetOutput.writeSlot() there should be an active not null check (!!) to the contents of the Slot.
I haven't found anything else. Good Commit :thumbsup:


release-v1.0.0 - changing the date in the CHANGELOG.md

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Tangent reskin classes

A mod for Tangent that, when loaded, reskins all of the classes, including existing ones, with Muscle Animals (not included).
Keeping this around as reference and/or something we can merge in if we find CC0 character models.

On main through different means now


Empty markdown cells load incorrectly in jupyter viewer

Repro steps:

Open a notebook and create several text cells without putting any text in them.
Start a jupyter instance and open the notebook in the jupyter viewer.
Instead of empty cells the following malformed text is displayed instead.

Looks like jupyter expects empty markdown cells to have an empty source array, while our notebooks save it as an array containing only an empty string. When saving the notebook in jupyter it removed those empty string entries.

Seems like this also happens if you create empty cells directly in the jupyter viewer and then reopen the notebook. Closing this since it sees like a jupyter issue, rather than an ADS one.


Showing another widget(example: a text) when we run out of cards

I want to show a text widget that says "no cards remaining" when I swipe all of the cards. Does anybody know how this is possible?

I solved this by placing the widget in a Stack, so its laying behind the tinderStack. When the stack is empty, the other widget will be shown.
Here an example:
SizedBox(
                    child: Stack(
                      children: [
                       RefreshButton(
                                topMsg: "No more found",
                                bottomMsg: "Load again",
                                onPress: () {
                                  _doSomeThing();
                                },
                              ),
                        TinderStack(
                          items: items,
                          cardController: cardController,
                        ),
                      ],
                    ),
                  );


nix flake update

Why
Bump so we can get latest available uv
What changed
nix flake update'd
Test plan
Describe what you did to test this change to a level of detail that allows your reviewer to test it
Rollout
Describe any procedures or requirements needed to roll this out safely (or check the box below)

[ ] This is fully backward and forward compatible

I don't know how to fix this and don't have time. @ryantm do you know how to make this more robust?

@blast-hardcheese I can take a look in a bit.


how to open flash [Question]:

Your question
Hello ,
I can open flash used webdriver .
I want to know how to open flash ?

Flash is no longer supported by Chrome, see e.g. this answer.

I  can use chromedriver playing flash with the same Chrome. So I want to know how to play the flash used playwright?

There is no special support for flash in Playwright but you may be able to dispatch input event e.g. via Mouse.click. Please provide more details about what you are trying to do and what is not working if you need further help.


Generated by :no_entry_sign: Danger


[Forge] Destruction not working

Forge version 2.2.0 and 2.2.1 is bugged cant destroy with tool in off hand!
Version 2.1.4 is it working as it should

it's not a bug, you now have to put the tool in the wand, open the wand menu (Y) and use the pick tool button to transfer tools.


Pre-trained model

Do you have a pre-trained model? Could you please post the trained weights?

OK, the weight has been uploaded with the log.
Please refer to the latest commit.

Thank you very much, do you have the weight of the recently released pytorch version of the model?

Sorry for no weight in pytorch now.
If urgent, maybe you can transfer the weight from mxnet to onnx, then transfer to pytorch.
mxnet to onnx is easy, and onnx to pytorch could refer to following code:
import onnx
from onnx2pytorch import ConvertModel
import argparse
import torch

parser = argparse.ArgumentParser("onnx->pytorch")
parser.add_argument('-w', "--onnxpath", type=str, required=True)
parser.add_argument('-o', "--outpath", type=str, required=True)

def onnx2torch():
    args = parser.parse_args()
    path_to_onnx_model = args.onnxpath
    onnx_model = onnx.load(path_to_onnx_model)
    pytorch_model = ConvertModel(onnx_model)

    torch.save(pytorch_model.state_dict(), args.outpath)

Thanks for your help. mxnet to onnx need some documents，such as symbol.json.Do you have such documents?
sym = './symbol.json'
params = './model.params'
input_shape = (1,3,224,224)
onnx_file = './model.onnx'
converted_model_path = onnx_mxnet.export_model(sym, params, [input_shape], np.float32, onnx_file)


default radio checked with HTML instead of JS

Instead of waiting for the page to load and then setting the easy radio button to checked with JS we could just add the checked attribute to the html, so that one is always defaulted as the selected mode

would clean up the js file and not have to wait for the window to load (line 20-22)
allow html to handle the default

un aware of this i do like that! how would you implement this?

when you use JS to set the checked attribute to 'true'
window.onload = function () {
  dEasy.checked = true;
};

its the same thing as doing
<div>
  <label for = "easy">
  <input
      type = "radio"
      name = "difficulty"
      value = "easy"
      id = "easy"
      checked <<<<<<<<< adding this 'attribute' in the HTML does the same thing
      />
      Easy
  </label>
</div>

or another way is to use the 'setAttribute' method in JS
Usually you can see this update in the browser if you click a check box / radio button, but since this is a static page, you wont be able to inspect and observe the changes, which makes it a little confusing because setting it from JS wont show up in the DOM
This change doesn't make a difference in the program, but I think not having to update the DOM on window.onload makes life slightly easier

will push this up with the edited random functions!


Website does not load with 0 errors

Running the below code causes the thread to get stuck (I've waited for several minutes) and nothing happens with no error message.
private void website() {
        log.info("Line 1");
        try (final WebClient webClient = new WebClient(BrowserVersion.FIREFOX)) {
            try {
                final HtmlPage page1 = webClient.getPage("https://pruway.prudential.com.my");
                log.info("Line 2");
            } catch (IOException e) {
                throw new RuntimeException(e);
            }
        }
    }

With the above code, "Line 2" is never printed. Any idea on how to solve this or even debug this?
EDIT : after quite awhile I finally get Exception in thread "main" java.lang.OutOfMemoryError: Java heap space error
EDIT2 : Nvm, after disabled Javascript it works. Not sure which part of the JavaScript is causing this to completely hang

Update : After turning off javscript, navigating down further pages is proving to be extremely troublesome. Is there a way to fix the JavaScript issue so I don't have to turn off JavaScript?

Hi,
I have a similar issue. The call to getPage never returns. Same symptoms.
Any help would be appreciated. Completely stuck.
Thanks

see #552 for details

Made some progress here, hopefully this will be fixed with the next release.

Should be fixed in version 3.0.0 - please reopen if this still fails


Add animated Breadcrumb

Prerequisites

[X] I am an Open Source Contributor
[X] I checked to make sure that this issue has not already been filed

Description
I wish to add an animated breadcrumb.
Screenshots

Code of Conduct

[X] I follow Contributing Guidelines of this project.

 Pls work on other new issues.

Okay np @Rakesh9100

What if I use a different design? @Rakesh9100

You can edit this issue title and description for adding some other feature if you want to @rishicds

Okay I'll edit this after the loader one @Rakesh9100


Empty state.

Add empty state for first time installs.

So far HTML + CSS has been added.
Next step is making sure empty state disappears if there are channels.

Was implemented in following commit:
https://github.com/rasmusroy/TwitchWatchList/commit/6286977704833c3838458e3e49058767edbf1a9d


Video not playing in ExoPlayer after compression

Current behavior
After the video is compressed, the video will no longer play in Android ExoPlayer with given error:
Error occured:  {"error": {"errorException": "com.google.android.exoplayer2.ExoPlaybackException: Source error", "errorString": "Unrecognized media format"}}
** I saw some closed tickets and tried variations of file:// and file:/// but neither was playable.
Expected behavior
Video plays in Android video player
Platform

[X] Android

React Native Version
RN: 0.70.6
React Native Compressor Version
RNC: ^1.6.1
Reproducible Steps And Demo

install React Native Compressor

Enable android exoplayer as media player
This is done by changing react-native.config.js to
dependencies: {
'react-native-video': {
platforms: {
android: {
sourceDir:
'../node_modules/react-native-video/android-exoplayer',
},
},
},
},

Compress the video as directed and send the URL to a React Native Video component

👋 @DaneHoward
Thanks for opening your issue here! If you find this package useful hit the star🌟!

It is useful so I went ahead and gave it a star. Everything else besides compress on Android works like a dream!

I'm experiencing the same issue in one of my projects, have you found any solution to this @DaneHoward ?

Any workaround for this issue yet? I'm experiencing same issue now

@maurobender @topwebtek7 I was able to make it work by doing an await on the auto compression setting in an async function and outputting the progress along the way. Verify that your video component is looking at the correct URI and verify that the video exists at that location by using the metadata tags provided in this package.

🙏 sorry for a long ago I was not maintaining due to the huge office workload, hopefully, I am going to start fixing bugs on a weekend basis,
I will fix at least 2 issues on the weekend, for priority bugs you can join the discord channel https://discord.gg/dtYzk8sp where we can discuss which bug is most important

fixed in the latest version, please feel free to reopen if you get any error


feat(watch): press r should rerun current pattern tests

Why?
In debugging, we may need to change the node_modules files, but it does not automatically trigger a re-run of the test.

Besides, I think press enter is a better way to execute rerun. but the enter has been used in rerun all tests.

Do you think this shortcut should be mentioned anywhere?

I searched for a long time without finding any documentation about these shortcuts, until I saw in the source code 😩
It looks like we need to add a Watch Mode page to the documentation and add the documentation related to shortcuts here.


On Demand validation for TWL

Issue:
When the user has a TWL TSV open they should be able to run a full validation on the TWL.  The intention here is that validating TWL works the same way validating TNs does.
DoD:
The user can run a validation check on TWLs the same way they do with the TN TSVs.
Details:

Not seeing the Content validator button on the header bar in translationCore Create - v1.4.0-rc.2 build 96-14c4cc5. Seems like this change is missing in the build.

translationCore Create - v1.4.0-rc.3 build 104-85b41fb.
@mandolyte  The Validation file has some columns showing  as undefined, rowID and Verse. It is hard to locate the errors in the file. This screenshot is for Exodus.

https://app.zenhub.com/files/191973535/b656b4c0-cff9-4559-bf94-7867ba21250f/download

@elsylambert what org were you using for the above CV?
I used unfoldingWord and only got this:

translationCore Create - v1.4.0-rc.3 build 104-85b41fb. Tested after deleting my old branch and CV looks goon on tWLs.


Addition of the features mentioned in issue #28

please consider this pull request under hacktoberfest2024 if possible!
Thank you!

added CLI Arguments Support:
support for command-line arguments to allow more flexibility (src/cli.ts)
added Schema Validation Feature:
this feature approves the Prisma schema before trying to make the documentation. This makes sure the schema is properly formatted, and any errors are caught early.
added Custom Template Feature:
Allow the user to specifically make a custom template for the documentation output, so they can format the output as they want to.
added Watch Mode feature:
a file watching feature that automatically remakes the documentation whenever the Prisma schema is modified.
updated the tsconfig.json, added more modules for further fixes and implementations
I hope these changes are useful,
i have tried my best that these addon features don't collide with the main code that's why made different folders for them.
if possible please consider this and add tags hacktoberfest2024 and hacktoberfest.
Thank you!

Thank you @danieltayal07


Rewrite tag drawing code to use GDI instead of GDI+ containers where possible to increase performance

Speed is slower than a cessna 172 trying to cross the atlantic, must be done

Lol this still needs to be done but I think I know where the performance issues are and if I am right then I am a potato

In conclusion, I was a potato

Didn't mean to close this, the code still does need to be rewritten.


add json_index_extract transform function to leverage json index for json value extraction

This is a follow up PR to https://github.com/apache/pinot/issues/11494
I worked on a poc for this, and took the approach of reading the JSON index through a transform function. This enables group by/regexp filtering/the majority of the functionality of JSON_EXTRACT_SCALAR and attempts to maintain the same syntax. This does not solve the generic problem of adding a code path to use inverted index to speed up group by.
We've seen large improvements for large time ranges and large tables. This can reduce query latency for equivalent queries and massively improve memory pressure, preventing the OOM caused cluster crashes we encountered.
As expected, for small time ranges where number of docs extracted is small, the existing JSON_EXTRACT_SCALAR function is faster.
Initial benchmark results (data from previous implementation, will update soon):

The outlined graphs signal a cluster crash and no data was able to be recorded.
A: 10TB table, group by json_extract_scalar(col, ‘$.keyA’, ‘STRING’, ‘null)
B: 10TB table, group by json_extract_scalar(col, ‘$.keyB’, ‘STRING’, ‘null)
C: 10TB table, regexp_like(json_extract_index(json_data, '$.keyA, 'STRING', 'null'), 'val') group by json_extract_index(json_data, '$.keyA, 'STRING', 'null')
D: 10TB table, regexp_like(json_extract_index(json_data, '$.keyA, 'STRING', 'null'), 'val')
E: 20GB table, group by json_extract_scalar(col, ‘$.keyA’, ‘STRING’, ‘null)
F: 20GB table, regexp_like(json_extract_index(json_data, '$.keyA, 'STRING', 'null'), 'val') group by json_extract_index(json_data, '$.keyA, 'STRING', 'null')

Thought not low latency, I think this would be a solid functionality to have available as it allows for queries that were otherwise unanswerable.

Codecov Report

Merging #11739 (bcf8c18) into master (24af80d) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #11739      +/-   ##
============================================
- Coverage     14.45%   14.39%   -0.07%
  Complexity      201      201
============================================
  Files          2342     2343       +1
  Lines        125917   126103     +186
  Branches      19370    19412      +42
============================================
- Hits          18205    18153      -52
- Misses       106170   106415     +245
+ Partials       1542     1535       -7

Flag
Coverage Δ

integration
?

integration1
?

integration2
?

java-11
?

java-17
14.39% <0.00%> (-0.06%)
:arrow_down:

java-20
?

temurin
14.39% <0.00%> (-0.07%)
:arrow_down:

unittests
14.39% <0.00%> (-0.06%)
:arrow_down:

unittests2
14.39% <0.00%> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...r/transform/function/TransformFunctionFactory.java
0.00% <0.00%> (ø)

...e/pinot/common/function/TransformFunctionType.java
0.00% <0.00%> (ø)

...local/realtime/impl/json/MutableJsonIndexImpl.java
0.00% <0.00%> (ø)

...t/index/readers/json/ImmutableJsonIndexReader.java
0.00% <0.00%> (ø)

...rm/function/JsonExtractIndexTransformFunction.java
0.00% <0.00%> (ø)

... and 14 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Can you share some new perf numbers after the optimization? In the query, let's add the json_match in the filter

Thanks for the review and suggestions! Will update w/ perf numbers.
For json_match filter are you referring to some query like where json_match(col, '$.keyA = ''val''') AND group by json_extract_index(col, ‘$.keyB’, ‘STRING’, ‘null)? Where key filtered != key aggregated on so we still have some large number of groups?

Updated perf results after adding caching, please take another look when convenient. Also added some short info about json_data blob size, and another query pattern w/ json_match filtering.
@chenboat @Jackie-Jiang


fix blackberry compilation

And it even runs (on a z10) ^^

It runs from the editor? nice
On 10 February 2016 at 22:48, Hondres<EMAIL_ADDRESS>wrote:

And it even runs (on a z10) ^^
You can view, comment on, or merge this pull request online at:
https://github.com/godotengine/godot/pull/3660
Commit Summary

fix platform bb10 compilation

File Changes

M platform/bb10/os_bb10.cpp
https://github.com/godotengine/godot/pull/3660/files#diff-0 (4)
M platform/bb10/os_bb10.h
https://github.com/godotengine/godot/pull/3660/files#diff-1 (2)

Patch Links:

https://github.com/godotengine/godot/pull/3660.patch
https://github.com/godotengine/godot/pull/3660.diff

—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/pull/3660.

yeah, I was suprised when the one-click deploy worked just like on android.
Although it takes forever to install


WIP: Inject the instance guid as a tag when emitting

What?
We found out that when using the firehose exporter[1], the instance
ID was not being added as a label of the metric being exported.
Instead, all the metrics from all the instances have the same labels
and we can not make any use of these metrics in prometheus.
In this commit we add a new tag "guid" that should be translated
to new label in prometheus
[1] https://github.com/bosh-prometheus/firehose_exporter
How to review?
Code review
Who?
not me

It seems this is more complicated than expected.
The problem is more in the prometheus firehose exporter, it does not include the tags for these metrics, but neither the Origin info. IMO the prometheus firehose exporter should add the origin, so that we can check that.
We should analyse why firehose exporter does not include these labels and do a PR upstream.
Closing this for the time being


[BTS-1661] Added new graph (vertex related) error code

Scope & Purpose
Added more detailed error code related to the use of not available/defined vertex collections inside graph operations.
In some operations, the error code: TRI_ERROR_GRAPH_REFERENCED_VERTEX_COLLECTION_NOT_USED now got
replaced with the error code: TRI_ERROR_GRAPH_VERTEX_COLLECTION_NOT_USED.
The difference is that the referenced not used means that the vertex collection is not defined within the scope of the graph definition (e.g. a vertex is used inside a _from or _to attribute of an edge document).
The newly introduced error checks if a vertex collection is used at all in general, e.g.:

One tries to insert a new vertex document to a vertex collection which is not part of the graph

Same analogy applies for removals, replaces, etc.

[x] :hankey: Bugfix

Checklist

[x] Tests

[x] integration tests

[x] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)

Related Information

[ ] Docs PR:
[ ] GitHub issue / Jira ticket: https://arangodb.atlassian.net/browse/BTS-1661

Review can be done, but added DO_NOT_MERGE label. Jenkins is in maintenance, therefore I cannot start our additional CI there

Note: Also includes [BTS-1660] Fix PATCH validation in some gharial API related graph operations, see: https://github.com/arangodb/arangodb/pull/20038/commits/d798726bfeaa06c6ada7ee9c531410f01ac0236f


Some magic commands not working in Python Interactive window

Environment data
VS Code version: 1.36.1
Extension version (available under the Extensions sidebar): 2019.8.29288
OS and version: MAC 10.14.4
Python version: 3.7.1
Expected behavior
Inside the Python interactive window, I want to use magic commands like %magic or the question mark like foo?
Actual behavior
Some magic commands are working (like %history or %pylab), but other do not work, like %magic or %pinfo which is equivalent to the question mark foo?
I understand this might be related to this closed issues: microsoft/vscode-python#4170 microsoft/vscode-python#5565
However the behaviour of some magic functions are not the same inside the Python interactive window compared to an ipython terminal.
I do not know if this issue is from my side, or if it is by design in the Python interactive window, or if it will be solved in a future release.

%lsmagic doesn't work for me, using 1.51.4 OSS version on Manjaro Gnome 20


Does not include package main section

Does not include package.main section
  "main": "lib/index.js",

Cause error Cannot find module '@adminjs/sequelize' or its corresponding type declarations.ts(2307)

The latest versions of AdminJS modules support ESM only so there's no main entry.


Publish main to live on 11/3 @ 10:30 am

Learn Build status updates of commit ac3e7e0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-MailboxMessageConfiguration.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-OrganizationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

skype/skype-ps/skype/Set-CsOnlineApplicationInstance.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsOnlineVoiceApplicationInstance.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


change "title" from itemFile.title to itemFile.label

change "title" from itemFile.title to itemFile.label for TYPE_ALBUM and TYPE_SONG.
This fixes the View of some Addons for me (for example the Shoutcast2 addon, where only current playing tracks were displayed instead of the Station name).
It also aligns with ListType.Sort.SORT_METHOD_LABEL.

Honestly i don't know if this will impact something else, but i'll merge it for now. If there are complaints this will have to be revisited.


Rule timeouts

Feature should be configurable/optional, i.e. no limits in Node, limited in Sketch
Assistant result should indicate whether its complete, or has been artificially limited. If it's been limited we won't be able to tell decisively whether the Assistant has "passed" or not, which may have UI implications - e.g. show when a result is indeterminate, explain why, and what to do about it.

Timeout
Introducing a timeout could lead results to be somewhat non deterministic, e.g. number of violations returned could vary depending on CPU load and how fast the rule executed. However it would be a good way to ensure that Assistant run time doesn't get totally out of control.
Considering that most rules should be capable of doing their thing quite efficiently, perhaps a 100ms timeout per rule could be considered? That would still be long enough for a rule to return 100s or even 1000s of violations depending on the document.
The downside would be rules that need to take a long time to run - could be annoying if they just timeout immediately before returning any results. But we could fine-tune this, or even eventually make it configurable in preferences.
Question - is the timeout per rule, per Assistant or per run? If each rule gets 100ms, but there are a ton of Assistants added to the document, with lots of rules each, then runtime could still start to get a bit long. Alternatively we could assign a time budget for the entire run, like max 4000ms, with each rule getting an equal slice of that.
Violation budget
The downside of a violation budget is it doesn't help with the case of rules that take an overly long time to run. If there's a violation budget of 200 per rule, but a rule is inefficient, then the Assistant runtime could still be way too long.
Also with efficiency improvements in the Sketch UI, then rendering large sets of violations doesn't seem to be an issue any more. So an efficient rule generating a good amount of violations before it timed-out doesn't seem like a problem any longer.
Thoughts @christianklotz @craig006

I think the timeout option covers more cases - Both assistants with many violations, and assistants that run slowly will be curbed. To me it makes sense that each assistant gets a set amount of time to use as they please. We could have an overall of 4000ms, like you said, which is nice to limit the overall runtime.
The violation budget I think is unfair towards assistants that are super efficient. :)

Filed #31067 as the timeouts don't appear to working for me

Moving this fella to Done and we will track the integration/problems in #31067.


How to import embassy stm32 dependency

The embassy-stm32 crate is only recognized as the 0.0.0 version. How can I import the 0.1.0 version

The current version 0.0.0 is there as a placeholder until the first version is released. In the meantime you have to depend on embassy-stm32 using a git dependency, ideally using [patch.crates-io] for all embassy dependencies to ensure they are aligned.


fix: 🐛 default state

default toggle state for skip flag should remain off

Works on local, deploying


Editing links and titles automatically in Zed

Changing a reference somewhere in a file or updating file names requires lots of search and edit without ability to update references, which is currently unavailable for the Zed editor (according to the wiki).
Opening this issue to express the demand for this feature.
Please make it available :)

Hey!
I appreciate the enthusiasm.
Unfortunately, as of last I checked, this was a zed issue with implementing the LSP.


Remove foreign key before dropping index

Re-Add foreign key after replacing index, otherwise migration<PHONE_NUMBER>5646 fails due to line 4
Checklist
🚨 Please review the guidelines for contributing to this repository. 🚨

[x] Make sure you are making a pull request against our main branch (left side)
[x] Check that that your branch is up to date with our main.
[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
[ ] Check that the tests and code linter both pass.
[x] If you're a new contributor, please sign our contributor license agreement.

Warnings

[x] This PR will change existing database contents.
[ ] This PR introduces a breaking change to existing installations.

Summary
Fixes key ordering for mariadb to continue migrations
Linked issues
Resolves #2515
Description of changes
Pre-application DB state

docker-compose to apply custom changes
  manyfold:
    image: lscr.io/linuxserver/manyfold:latest
    container_name: manyfold
    environment:
      - PUID=3001
      - PGID=2005
      - TZ=America/New_York
    env_file: /var/opt/docker/manyfold/.env
    volumes:
      - /var/opt/docker/manyfold:/config
      - /var/opt/3d_models:/3d_models
      - /var/opt/docker/manyfold/20240727113215_create_federails_actors.federails.rb:/app/www/db/migrate/20240727113215_create_federails_actors.federails.rb
    expose:
      - 3214
    restart: unless-stopped
    networks:
      - apps
      - mariadb

Linuxserver.io version: v0.76.0-ls10
output
manyfold  | ==<PHONE_NUMBER>3215 CreateFederailsActors: migrating ============================
manyfold  | -- create_table(:federails_actors)
manyfold  |    -> 0.0217s
manyfold  | -- foreign_key_exists?(:federails_actors, :users)
manyfold  |    -> 0.0016s
manyfold  | -- remove_foreign_key(:federails_actors, :users)
manyfold  |    -> 0.0214s
manyfold  | -- remove_index(:federails_actors, :user_id)
manyfold  |    -> 0.0232s
manyfold  | -- add_index(:federails_actors, :user_id, {:unique=>true, :name=>"index_federails_actors_on_user_id"})
manyfold  |    -> 0.0462s
manyfold  | -- add_foreign_key(:federails_actors, :users)
manyfold  |    -> 0.0460s
manyfold  | ==<PHONE_NUMBER>3215 CreateFederailsActors: migrated (0.1609s) ===================
manyfold  |
manyfold  | ==<PHONE_NUMBER>3216 CreateFederailsFollowings: migrating ========================
manyfold  | -- create_table(:federails_followings)
manyfold  |    -> 0.0204s
manyfold  | ==<PHONE_NUMBER>3216 CreateFederailsFollowings: migrated (0.0206s) ===============
manyfold  |
manyfold  | ==<PHONE_NUMBER>3217 CreateFederailsActivities: migrating ========================
manyfold  | -- create_table(:federails_activities)
manyfold  |    -> 0.0181s
manyfold  | ==<PHONE_NUMBER>3217 CreateFederailsActivities: migrated (0.0183s) ===============
manyfold  |
manyfold  | ==<PHONE_NUMBER>5646 ChangeActorEntityRelToPolymorphic: migrating ================
manyfold  | -- remove_foreign_key(:federails_actors, {:column=>:user_id, :to_table=>"users"})
manyfold  |    -> 0.0241s
manyfold  | -- remove_index(:federails_actors, :user_id, {:unique=>true})
manyfold  |    -> 0.0224s
manyfold  | -- change_table(:federails_actors)
manyfold  |    -> 0.0701s
manyfold  | ==<PHONE_NUMBER>5646 ChangeActorEntityRelToPolymorphic: migrated (0.1169s) =======
manyfold  |
manyfold  | ==<PHONE_NUMBER>5647 CreateFederailsActors: migrating ============================
manyfold  | ==<PHONE_NUMBER>5647 CreateFederailsActors: migrated (0.2442s) ===================
manyfold  |
manyfold  | ==<PHONE_NUMBER>4448 CreateMoreFederailsActors: migrating ========================
manyfold  | Creating actors for User
manyfold  | .
manyfold  | Creating actors for Model
manyfold  | ................................................................................................................................................................
............................................................................................................................................................................
............................................................................................................................................................................
............................................................................................................................................................................
............................
manyfold  | Creating actors for Creator
manyfold  | ...............................................................................................
manyfold  | Creating actors for Collection
manyfold  | .....
manyfold  | ==<PHONE_NUMBER>4448 CreateMoreFederailsActors: migrated (11.1596s) ==============
manyfold  |
manyfold  | ==<PHONE_NUMBER>1500 BackfillActivities: migrating ===============================
manyfold  | 2024-08-21T21:13:23.166Z pid=126 tid=gwy INFO: Sidekiq 7.3.1 connecting to Redis with options {:size=>10, :pool_name=>"internal", :url=>"redis://redis:6379/9"}
manyfold  | ==<PHONE_NUMBER>1500 BackfillActivities: migrated (0.5479s) ======================

Have to drop the foreign key in order for the index drop to work in mariadb, then re-add the foreign key, as the 20240731 migration tries to drop it, and thus it must exist in order for that migration to also succeed

Oh, fantastic, thank you for the fix!


Some schema converters

I have added a couple of converters in the form of a Python package, mititools.
It is documented here.
It supports YAML -> flat fields -> Frictionless Data.
This is just a first try, and the conversion isn't completely faithful. Notably with respect to the "significance" attribute and the date string/DOI/RRID validation, although I believe FD does support such features.
I tried to automatically normalize the field names as well as autogenerate machine-friendly variants.
I wasn't sure what the preference would be for the directory structure. I just added top-level subdirectories for each schema format, in addition to a directory for the Python package itself. Obviously this is all subject to change based on your feedback.
Closes #12 .

I would also suggest to create a new repository for mititools! Thank you very much for pushing this forward!

@ArtemSokolov

Agreed. I think I just wanted something more descriptive than "yaml", since yaml is just the name of the markup language syntax and doesn't say anything about the contents structure. But in this context it is enough to disambiguate it from the other 2 schema formats. I made these changes.
Certainly, this makes sense. In this case this exact PR would be closed without merge, and I would just populate the new repository.
The idea was to have each of the 3 schema specs to be as standalone as possible, in the spirit of repositories that are "ready for use" even if slightly more difficult to maintain as a result. The main duplication is all those controlled vocabulary tables in flatfields. I think this issue can be addressed by binding these into a single file controlled_vocabulary.tsv (with Table name, Term or similar). I'll make this change. Since flatfields is a bespoke "schema format", we can alter it however we like. (The Frictionless data package however kind of has to be in the present state in order to be compliant.)
I would request that someone more familiar with the MITI org update the README, perhaps as a separate PR as you suggest.

Hi @jimmymathews,
The governance board convened a meeting today, and I just wanted to share an update:

I just made a separate mititools repository and gave you a Maintainer access, so you should be able to deposit your code there.
After consulting with several domain experts who may be updating specific fields in the future, the board has decided to stay with (cerberus) YAML as the "core" representation for the time being. (That's not to say that this couldn't change at a later date.)
Everybody is in agreement about the conversion from one representation to another being done with automated scripts triggered by GitHub Actions. There were no objections to storing each representation as a separate directory at the top level in this repo.
I will be happy to update the README in a separate pull request.

Let me know once you had a chance to deposit your code to mititools, and we'll throw together a GitHub Action to trigger the automatic conversion.
I think @DenisSch will follow up separately regarding some of other points raised in #12
Cheers,
-Artem

Great, the package is deposited at miti-consortium/mititools. Feel free of course to make any alterations to what I have there. If the preferred location for the autogenerated outputs is this repository (MITI), I will delete them from mititoolts.
I suggest we continue to use this PR for any issues that might arise as you put together the GitHub Action, and close when you're satisfied the action works as expected.

Thanks so much, @jimmymathews. It looks great!
I'll try and find some time this week to make a pass at a GitHub Action that runs mititools to auto-populate this repo with flatfields and frictionless.
Agree on keeping this PR open for discussion for now.

Hi @jimmymathews,
My original plan for a GitHub Actions was to update a user-initiated pull requested whenever any of the YAML files were altered. However, after many unsuccessful attempts -- which have to do with the github-actions bot not having permissions to push to external repos even when the "Allow edits and access to secrets by maintainers" box is checked -- I settled on a different solution.
The GH Action will monitor the yaml/ folder on the main branch and open a pull request whenever it detects a change (either from a direct push or a merged PR). If a pull request is already open, it will update an existing one, to prevent a cascade of PRs if somebody is doing extensive modifications to the YAML source.
Take a look at #18 and let me know what you think. If this looks like a reasonable solution, we can merge #18 and close this PR. I can then update the README to reflect this approach.
Best,
-Artem

Superseded by #19


Visual Studio 2022

Describe your problem here.
Kind people, after reinstalling Windows, I needed to install Visual Studio. I used to have the 2019 version, and I downloaded it literally in one click. And now in 2022 it is necessary to choose components and so on. On github, I didn't understand exactly what components are needed. Can you list ALL the components that need to be installed?
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x86/x32
Did you edit anything in this build? If so, mention or summarize your changes.
No response

MSVC v142 - VS 2019 C++ x64/x86 build tools Latest
Windows SDK (10.0.17763.0)

also you shouldn't be using VS 2022 for haxeflixel

This is what I have if you're using VS 2022

hope it helps

This is what I have if you're using VS 2022  hope it helps

that's literally what I just said

Ik, I needed MSVS v143 and the highest number of the SDK when got VS 2022

The Visual Studio 2019 installer is available here:
https://download.visualstudio.microsoft.com/download/pr/3105fcfe-e771-41d6-9a1c-fc971e7d03a7/8eb13958dc429a6e6f7e0d6704d43a55f18d02a253608351b6bf6723ffdaf24e/vs_Community.exe


Fix flex styling for IE11

Connected to #3

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


mongodb fails to start: unrecognised option '--break-mongo'

I used the docker compose to build. MongoDB fails to start:
Attaching to root_mongo-data_1, root_mongo_1, root_parse-cloud-code_1, root_parse-server_1
mongo-data_1       | Error parsing command line: unrecognised option '--break-mongo'
mongo-data_1       | try 'mongod --help' for more information
root_mongo-data_1 exited with code 2

I assume this is wanted? https://github.com/docker/compose/issues/942

Yes.
mongo-data is a volume cotainer, so i make it break.
ref. http://www.diogogmt.com/running-mongodb-with-docker-and-compose/

Ok got it. You can close this.
Maybe you can add a little comment into the docker compose file.

So this is intended? Because it also seems to crash "cloud-code":
mongo-data_1        | Error parsing command line: unrecognised option '--break-mongo'
mongo-data_1        | try 'mongod --help' for more information
parse-cloud-code_1  | hello.js
parse-cloud-code_1  | main.js
parse-cloud-code_1  | twitch.js
fortuna_mongo-data_1 exited with code 2
fortuna_parse-cloud-code_1 exited with code 0

Yes, mongo-data and parse-cloud-code are as volume container, so they would be exited that's intended.


Code Duplication - GraphQL queries are duplicated at many places in the templates, Removing those duplicate queries will increase code quality

Code Duplication - GraphQL queries are duplicated at many places in the templates.
Remove those duplicate quires will increase code quality,

Hi @aman-agrwl , I would like to take up this issue, can you please assign it to me?

@sjha2048  Assigned issue to you for hacktoberfest2020
And LoginRadius is also giving swags to people who will be contributing, so please make sure to read our blog and submit your info to get free goodies.
https://www.loginradius.com/engineering/page/hacktoberfest2020

@aman-agrwl-zz  is this still open I am interested in working on this


Decimals support for German

I haven't been able yet to implement the "relaxed" parameter properly because it was getting too time consuming (and for my own project I don't really need it right now :/), but I've added decimals support for German :slightly_smiling_face: and cleaned up some stuff in the German language script.

Sorry, I've been very busy this week.
I'll try to review this on Monday.
Thanks for contributing!


Allow additional sbt tasks to be run before deployment

Please close the PR if it does not align with the design goals of this buildpack. If any changes in the documentation would be required to adhere to the format, kindly update.

I'm fine with the intention of this feature. But how about just allowing SBT_TASKS to be overridden instead of the more verbose SBT_ADDITIONAL_TASKS? In that way you could set heroku config:set SBT_TASKS="flyway:migrate info compile stage" (including the stage).
Would that work for you? If so, I'll make the change and merge this.

@RohanPrabhuNomadly does ^^ sound ok?

I am so sorry I did not reply to this all while. For some reason, I just did not get notified that there was activity on this PR. Yes, this does sound reasonable and makes more sense. I will update the pull request.

On a second thought, won't just allowing SBT_TASKS to be overwritten cause issues with the release script? Given what I am aware of, I believe the release script and others depend on the stage target to be run (so that the running binary is present in target/universal/stage). Given that, it does not seem right that while there is a provision to change the build behaviour, there isn't provided a behaviour to alter the release cycle as well that mirrors this functionality.
Which is why, I do think it'd be better to allow adding additional tasks while still maintaining the fact that stage will always be run. Kindly give your thoughts on the same.

@RohanPrabhuNomadly yea, that's true. I'm still hung up on the variable name though. What if we change it to SBT_PRE_TASKS, which is actually more accurate?

That sounds great, and yes, it is accurate. Also enforces that compile stage will still be the last targets run, because that must be ensured (to enforce the previous contract, as running a clean after that breaks the expectation of release).

Thanks for the contribution. You can use this now by setting the Github URL as your buildpack:
$ heroku buildpacks:set https://github.com/heroku/heroku-buildpack-scala

Or you can wait for the release, which will come either later today or early tomorrow.


Error: The argument type 'BorderRadius?' can't be assigned to the parameter type 'BorderRadiusGeometry'

im trying to build apk and getting this error,
/C:/src/Pub/Cache/hosted/pub.dev/glass_kit-2.0.1/lib/src/glass_container.dart:406:41: Error: The argument type 'BorderRadius?' can't be assigned to the parameter type 'BorderRadiusGeometry' because 'BorderRadius?' is nullable and 'BorderRadiusGeometry' isn't.

'BorderRadius' is from 'package:flutter/src/painting/border_radius.dart' ('/C:/src/flutter/packages/flutter/lib/src/painting/border_radius.dart').
'BorderRadiusGeometry' is from 'package:flutter/src/painting/border_radius.dart' ('/C:/src/flutter/packages/flutter/lib/src/painting/border_radius.dart').
current = ClipRRect(borderRadius: borderRadius, child: current);
^
Target kernel_snapshot failed: Exception

Expected behaviour
/C:/src/Pub/Cache/hosted/pub.dev/glass_kit-2.0.1/lib/src/glass_container.dart:406:41: Error: The argument type 'BorderRadius?' can't be assigned to the parameter type 'BorderRadiusGeometry' because 'BorderRadius?' is nullable and 'BorderRadiusGeometry' isn't.

'BorderRadius' is from 'package:flutter/src/painting/border_radius.dart' ('/C:/src/flutter/packages/flutter/lib/src/painting/border_radius.dart').
'BorderRadiusGeometry' is from 'package:flutter/src/painting/border_radius.dart' ('/C:/src/flutter/packages/flutter/lib/src/painting/border_radius.dart').
current = ClipRRect(borderRadius: borderRadius, child: current);
^
Target kernel_snapshot failed: Exception

Screenshots

Flutter:

3.13.2
stable

Dart:

3.1.0

Hey @HassHasib, thanks for creating an issue.
This will be fixed after the v3.0.0 release. Kindly update the dependency version


Just an idea for performance

Hi, First I want to say I don't use that project (yet) but just came across and looked a bit about the source code.
I see you're using a HostListener('scroll') and requestAnimationFrame (not sure why this one) to apply the refresh. Where the refresh consist of

update translateY.
fire update with new items if necessary.

So both those async method will trigger a change detection runs, this means roughly 2 CD per scroll event. This could be a real perf killer !
I think you could get a significant gain if you would

run all async methods outside the angular zone zone.runOutsideAngular() (can't use HostListener  anymore but needs to register the listener using Renderer.
update translateY yourself using Renderer
when necessary, emit the update back inside the zone zone.run().
That way you would trigger a CD only when items needs to change (when update emits).

Just an idea, I may have missed something but hope that helps !

@ghetolay, thanks for this. I will try and let you know how it goes.


Cannot read property 'addEventListener' of undefined when calling enableDragSelection

Hello,
I am using wavesurfer within a react app, and I came across a strange issue. I'm using the Regions plugin and I need to do enableDragSelection. So once the wavesurfer is ready and it fires the ready event, I call wavesurfer.enableDragSelection({});. This works just fine when I am running the app locally, but as soon as I make a deploy on Heroku, I get this error instead.
Uncaught TypeError: Cannot read property 'addEventListener' of undefined
    at o.value (regions.js:742)
    at o.enableDragSelection (regions.js:607)

Any help really appreciated! :)
Wavesurfer.js version(s): 2.1.1
Browser version(s): Chrome v70

this.wrapper is undefined
this.wrapper is set, when Regions is ready

wavesurfer fires ready, your code runs, but Regions ready is not completed
for your information, enableDragSelection will be called when Regions ready
       this.wavesurfer.on('ready', this._onReady);

       this._onReady = () => {
            this.wrapper = this.wavesurfer.drawer.wrapper;
            if (this.params.regions) {
                this.params.regions.forEach(region => {
                    this.add(region);
                });
            }
            if (this.params.dragSelection) {
                this.enableDragSelection(this.params);
            }
        };

@aburai Thanks so much for your answer!
That there looks like it's just checking if wavesurfer is ready, or am I wrong? Is there any way to tell Regions is ready?
Thanks again
Bran

Thanks for all your help guys, I resolved it by checking the isReady value in wavesurfer.regions.wavesurfer like so:
onReady(wavesurfer) {
    if (!wavesurfer.regions.wavesurfer.isReady) {
      setTimeout(() => this.onReady(wavesurfer), 1000)
      return
    }

    wavesurfer.enableDragSelection({});
}

I might look into adding that event @thijstriemstra when I get some free time this weekend 👍


Good and easy way to create new exercises.

Potential options:

Simplify and document well existing format - this might work, but it would still require some skill and ramp-up time.
Find an existing format which is used somewhere else - would be great, but I'm not sure where to even find it
Build a UI tool for creating exercises - this would probable be the best experience, but this also requires a lot of work.

Example of how it works now:
To show hello between milestone 2 and 3 and to trim the whitespace, it should look like this
/*d:milestone-1:milestone-2/trimBoth*/ hello /*/d*/
import {BrowserModule} from '@angular/platform-browser';
import {NgModule} from '@angular/core';
import {AppComponent} from './app.component';
/*d:thumbsComponentUse/trimLeading*/
import {ThumbsComponent} from './thumbs/thumbs.component';
/*/d*//*d:togglePanelComponentUse/trimLeading*/
import {TogglePanelComponent} from './toggle-panel/toggle-panel.component';
/*/d*//*d:diInjectService/trimLeading*/
import {VideoService} from './video/video.service';
/*/d*//*d:videoComponentUse/trimLeading*/
import {VideoComponent} from './video/video.component';
/*/d*//*d:contextComponentUse/trimLeading*/
import {ContextComponent} from './context/context.component';
/*/d*//*d:fuzzyPipeUse/trimLeading*/
import {FuzzyPipe} from './fuzzy-pipe/fuzzy.pipe';
/*/d*//*d:createModuleSolved/trimTrailing*/
@NgModule({
  imports: [BrowserModule],
  declarations: [AppComponent
    /*/d*//*d:videoComponentUseSolved/trimBoth*/, VideoComponent
    /*/d*//*d:thumbsComponentUseSolved/trimBoth*/, ThumbsComponent
    /*/d*//*d:togglePanelComponentUseSolved/trimBoth*/, TogglePanelComponent
    /*/d*//*d:contextComponentUse/trimBoth*/, ContextComponent
    /*/d*//*d:fuzzyPipeUseSolved/trimBoth*/, FuzzyPipe
    /*/d*//*d:createModuleSolved/trimBoth*/
  ],
  bootstrap: [AppComponent]/*/d*//*d:diInjectServiceSolved/trimTrailing*/,
  providers: [VideoService]
  /*/d*//*d:createModuleSolved/trimTrailing*/
})
export class AppModule {
  /*/d*//*d:createModuleSolved*/
}/*/d*/

Simplify the language, create the playground


Extremely high CPU usage

I'm seeing 200% CPU usage and 40 GB of virtual memory usage by Chrome when the code-server tab is open, almost consistently. Is there any advice on what settings for code-server can help lower the CPU usage?

Web Browser: Chrome 81.0.4044.138 (Official Build) (64-bit)
Local OS: macOS Catalina 10.15
Remote OS: docker running on Ubuntu 20.04 LTS
Remote Architecture: x86_64
code-server --version: 3.3.1 6f1309795e1cb930edba68cdc7c3dcaa01da0ab3

Can you follow the steps here:
https://github.com/cdr/code-server/blob/master/doc/FAQ.md#how-do-i-debug-issues-with-code-server
and post the logs?

@karimsa Any luck?

I haven't had a chance to pull logs off the device yet. One thing I noticed is that the CPU spikes don't happen as often with the default log level as they do with a more verbose log level. Also, once I close the code-server tab for a bit and then open it again, the problem resolves.
I noticed that the processes in the shell seem to be tied to the browser's session. Is there a reason for that? Why isn't the shell + vscode state stored in the backend and then copied back over on reload?

I can't say for sure but it might be because you can use something like tmux or screen to persist your sessions. I haven't seen any open issues for persisting the terminals so it doesn't look like it's on the VS Code team's roadmap.

I am also seeing one core pegged to 100% by node when I attach a browser to it. After I close the tab, the CPU is still maxed out.
Environment: linux
Running on docker image linuxserver/code-server:deadf647867b (latest)

Logs:
[2020-09-01T23:06:28.230Z] info  Using user-data-dir ~/data
[2020-09-01T23:06:28.235Z] info  code-server 3.5.0 de41646fc402b968ca6d555fdf2da7de9554d28a
[2020-09-01T23:06:28.242Z] info  HTTP server listening on http://<IP_ADDRESS>:8443
[2020-09-01T23:06:28.242Z] info    - No authentication
[2020-09-01T23:06:28.243Z] info    - Not serving HTTPS
[2020-09-01T23:06:28.243Z] info    - Proxying the following domain:
[2020-09-01T23:06:28.243Z] info      - <redacted>
Error: Could not locate the bindings file. Tried:
 → /node_modules/code-server/lib/vscode/node_modules/spdlog/build/spdlog.node
 → /node_modules/code-server/lib/vscode/node_modules/spdlog/build/Debug/spdlog.node
 → /node_modules/code-server/lib/vscode/node_modules/spdlog/build/Release/spdlog.node
 → /node_modules/code-server/lib/vscode/node_modules/spdlog/out/Debug/spdlog.node
 → /node_modules/code-server/lib/vscode/node_modules/spdlog/Debug/spdlog.node
 → /node_modules/code-server/lib/vscode/node_modules/spdlog/out/Release/spdlog.node
 → /node_modules/code-server/lib/vscode/node_modules/spdlog/Release/spdlog.node
 → /node_modules/code-server/lib/vscode/node_modules/spdlog/build/default/spdlog.node
 → /node_modules/code-server/lib/vscode/node_modules/spdlog/compiled/12.18.3/linux/x64/spdlog.node
 → /node_modules/code-server/lib/vscode/node_modules/spdlog/addon-build/release/install-root/spdlog.node
 → /node_modules/code-server/lib/vscode/node_modules/spdlog/addon-build/debug/install-root/spdlog.node
 → /node_modules/code-server/lib/vscode/node_modules/spdlog/addon-build/default/install-root/spdlog.node
 → /node_modules/code-server/lib/vscode/node_modules/spdlog/lib/binding/node-v72-linux-x64/spdlog.node
    at bindings (/node_modules/code-server/lib/vscode/node_modules/bindings/bindings.js:126:9)
    at Object.<anonymous> (/node_modules/code-server/lib/vscode/node_modules/spdlog/index.js:3:35)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32)
    at Function.Module._load (internal/modules/cjs/loader.js:878:14)
    at Module.require (internal/modules/cjs/loader.js:1025:19)
    at Module.patchedRequire [as require] (/node_modules/code-server/lib/vscode/node_modules/diagnostic-channel/dist/src/patchRequire.js:14:46)
    at require (internal/modules/cjs/helpers.js:72:18)
    at t.load (/node_modules/code-server/lib/vscode/out/vs/loader.js:16:749)
    at e.load (/node_modules/code-server/lib/vscode/out/vs/loader.js:13:941)
    at i (/node_modules/code-server/lib/vscode/out/vs/loader.js:29:839)
    at Object.errorback (/node_modules/code-server/lib/vscode/out/vs/loader.js:29:963)
    at e.triggerErrorback (/node_modules/code-server/lib/vscode/out/vs/loader.js:14:306)
    at /node_modules/code-server/lib/vscode/out/vs/loader.js:14:10
    at ReadFileContext.callback (/node_modules/code-server/lib/vscode/out/vs/loader.js:17:221)
    at FSReqCallback.readFileAfterOpen [as oncomplete] (fs.js:261:13) {
  tries: [
    '/node_modules/code-server/lib/vscode/node_modules/spdlog/build/spdlog.node',
    '/node_modules/code-server/lib/vscode/node_modules/spdlog/build/Debug/spdlog.node',
    '/node_modules/code-server/lib/vscode/node_modules/spdlog/build/Release/spdlog.node',
    '/node_modules/code-server/lib/vscode/node_modules/spdlog/out/Debug/spdlog.node',
    '/node_modules/code-server/lib/vscode/node_modules/spdlog/Debug/spdlog.node',
    '/node_modules/code-server/lib/vscode/node_modules/spdlog/out/Release/spdlog.node',
    '/node_modules/code-server/lib/vscode/node_modules/spdlog/Release/spdlog.node',
    '/node_modules/code-server/lib/vscode/node_modules/spdlog/build/default/spdlog.node',
    '/node_modules/code-server/lib/vscode/node_modules/spdlog/compiled/12.18.3/linux/x64/spdlog.node',
    '/node_modules/code-server/lib/vscode/node_modules/spdlog/addon-build/release/install-root/spdlog.node',
    '/node_modules/code-server/lib/vscode/node_modules/spdlog/addon-build/debug/install-root/spdlog.node',
    '/node_modules/code-server/lib/vscode/node_modules/spdlog/addon-build/default/install-root/spdlog.node',
    '/node_modules/code-server/lib/vscode/node_modules/spdlog/lib/binding/node-v72-linux-x64/spdlog.node'
  ],
  phase: 'loading',
  moduleId: 'spdlog',
  neededBy: [ '===anonymous3===' ]
}
[2020-09-01T23:06:48.093Z] warn  vscode ENOENT: no such file or directory, scandir '/config/data/logs'
(node:280) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 exit listeners added to [ChildProcess]. Use emitter.setMaxListeners() to increase limit
(node:280) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [ChildProcess]. Use emitter.setMaxListeners() to increase limit

I'm not sure about the CPU usage but it might be worth fixing the spdlog issue to see if that affects anything. It looks like the Docker image might be missing some dependencies. https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites
https://github.com/cdr/code-server/issues/1826#issuecomment-651210655 may also help, although it's specific to FreeBSD.

@code-asher I think the above issue is https://github.com/cdr/code-server/issues/1961

Ah yeah true there was mention there about spdlog in that issue. I don't really know what the bindings error actually means, I've just noticed it seems to get fixed if certain system dependencies are installed. I could see it being caused by issues with our packaging as well though.

Should also be noted that the above issue is occurring in linuxserver/code-server, not our image.

Anyone still seeing this on the latest releases?

Going to close as there hasn't been a response in a long time!

Going to close as there hasn't been a response in a long time!


Bootstrap 4.5 or browser(s) bug ? modal close button with frame ?

go to Bootstrap page :
https://getbootstrap.com/docs/4.5/components/modal/
https://getbootstrap.com/docs/4.0/components/modal/
Then click on sample modal dismiss button (right upper corner). See the frame around ?
Wasn't there two days ago.
it is in
Chome 83.0.4103.61 Win7 64,
new Edge based on chromium engine,
latest Firefox 75.
When set css element from
pointer-events:auto
to
pointer-events: none
frame gone, but loose some visual behaviour.
regards.
@XhmikosR, next time check before You close an issue. I Know what ama writing. This problem is new.

I can only check what info you provide. You provided the wrong info in #30916.

@wwwfactory are you talking about the outline, like in this screenshot (Firefox)?

If so, it's been here for years. And at least, since v4.0 (which we didn't released again, obviously). Moreover, it's not an issue: it's meant indicate :focused state.
If not, could you please provide screenshot of what you're considering a bug?

chrome made their focus outline stronger in the latest release. the focus outline has always been on those "X" close buttons. nothing new here.

The button could be re-sized/moved so the outline rectangle does not look misplaced. What do you think? I.e. make the button height to use full height of the dialog header or add the same margin on top,right and bottom.

@wwwfactory are you talking about the outline, like in this screenshot (Firefox)?

If so, it's been here for years. And at least, since v4.0 (which we didn't released again, obviously). Moreover, it's not an issue: it's meant indicate :focused state.
If not, could you please provide screenshot of what you're considering a bug?

Could you have any idea how to remove the outline when i focus on certain component, beacuse I fond it not only show ontline in button , it also will show in grid cell and input field etc. I want to remove this black frame when i focus on the compnents globally.

Are you referring to the changes Chrome 83 made to form controls?
https://developers.google.com/web/updates/2020/05/nic83#forms


why  'AFURLConnectionOperation.h' file not found   ?

pod update
AFNetworking (3.1.0)

solve the problem
once again pod update

it doesn't work for me. I search for the word "AFURLConnectionOperation", but there is no this word in the foundation of AFNetworking. pod update seveval times, but it do not effect.


error with latest version

I ran it on ubuntu 14.04 64, and got these:
failed: [xx.xx.xx.xx] => {"cmd": "/usr/bin/update-alternatives --install /usr/lib/jvm/java java_sdk /usr/java/default 50", "failed": true, "rc": 2}
stderr: update-alternatives: error: error creating symbolic link `/usr/lib/jvm/java.dpkg-tmp': No such file or directory
stdout: update-alternatives: using /usr/java/default to provide /usr/lib/jvm/java (java_sdk) in auto mode
msg: update-alternatives: error: error creating symbolic link `/usr/lib/jvm/java.dpkg-tmp': No such file or directory
...ignoring

The alternative link java_sdk was introduced in the previous issue:
https://github.com/William-Yeh/ansible-oracle-java/issues/3
I haven't come out a better way to handle this case, so this line of task was marked as ignore_errors.  Any idea to fix this?

Why is this closed? Is my impression or both #11 and #13 are cross linked, and closed as duplicated?
I am facing the same bug on Debian while deploying Java using ansible.


drivers: wifi: ipc service support

IPC service support

The following west manifest projects have been modified in this Pull Request:

Name
Old Revision
New Revision
Diff

nrf_wifi
https://github.com/zephyrproject-rtos/nrf_wifi/commit/f6b950a3b5c0187fe499b0e518426d5bf88b7e68
https://github.com/zephyrproject-rtos/nrf_wifi/pull/12
zephyrproject-rtos/nrf_wifi#12/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.


MSID: 99168 Version: 1 DOI: 10.1101/2<IP_ADDRESS>3837

MSID: 99168
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>3837
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=99168
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>3837

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/99168v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>3837
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/99168/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

error: [author-contrb-no-aff-xref] Author Alan Carleton has no affiliation.
warn: [journal-ref-text-content] This journal reference (id c28) has untagged textual content - .e4 (. Is it tagged correctly?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c23) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c26) has a publication-type='other'. Is that correct?
warn: [article-email-corresp-author-count-equivalence] The number of corresponding authors (2: Alan Carleton; Ivan Rodriguez) is not equal to the number of distinct email addresses (1: ivan.rodriguez@unige.ch). Is this correct?

@acollings Do we need to cut out 'useful' here?

Thanks @JGilbert-eLife I think the editor meant to use useful and not valuable but at this point it's better to remove useful, so I've done that!

Cheers!


Update contract_request: Apply different JSON Schema depending on contract_type

[ ] Add contract_type Apiary
[ ] Validate that nhs_contract_price is empty in case of reimbursement contract spec (p.4.a)
[ ] Validate that contract_type on update == contract_type on create spec (p.3)

DataModel

agreed to add json-schema