Would be great if the fromNow() function could just return numbers. Positive for future, negative for past...

This just makes time calculations so complicated when you have to calculate a second ago, a few minutes ago or... in 3 hours...

As you can imagine such change would completely break thousands of applications that rely on fromNow() to display date as text like the ones you can see right now above GitHub messages.
You can't expect a library to completely change a method output because it's more convenient for some users.
You would have way more chance to get your feature if you would ask for a new method rather than breaking an existing one.
And this could probably be done using a plugin (maybe it already exist).
Check what already exist and if other methods and plugins are not close enough, describe precisely the expected output (a method cannot send numbers, it can send 1 number or an array/object that can have different content).

Thanks for that answer? I wasn't suggesting anyone to break anything?? Read my question again. Maybe someone that read my question had a suggestion for me. Don't comment if you have nothing helpful to say. I also did not have any expectations. Don't have anything helpful to say/suggestions, don't comment.

There is no question in your issue. And I didn't suggest you should close it, I suggested you to provide details about the output you expect so you would have a chance to get a relevant answer. First you may base your issue on the Feature request moment asks. So we can better understand your expectation, and give you answer you would find more helpful.

Found a way to make this happen.
This would have been the question: Is there a way in moments.js to only get integers returned when you are calculating how many days are between two dates instead of phrases such as "a month ago", "12 hours ago"?

Yep, recommended way is:
const duration = new moment.duration(moment('2019-08-25').diff('2019-06-14'));

console.log(duration.months());
console.log(duration.days());


Fix redis noauth

Commit 9ece56f8 adds support for Redis authentication, but breaks previously working setups, because Sensu now tries to authenticate with an empty password if none was specified.
This commit means that existing setups will continue to function, but allows Redis authentication to be used if desired.

Good point - thanks!


Support a Builder resource for managing builders via Pulumi

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue description
As seen in #55, the docker-build.Image resource by default creates a builder, which may create an unmanaged compute resource (container, Kubernetes Deployment, etc.) that is managed outside of the lifecycle of the Docker provider. As these are unmanaged, they are persistent beyond the life of any Pulumi program and can pollute shared compute resources.
A second challenge is that the docker-build.Image resource provides no mechanism to create other kinds of builders. This means users need to use another provider (likely more than one) to both create the compute resources and to connect a Docker client to the shared builder.
Proposal
Support a docker-image.Builder resource for explicitly configuring a persistent, shared Builder, whose lifecycle is managed as a Pulumi resource. This resource could be created in the same stack and used as a dependency for docker-image.Image resources, or in a shared stack consumed via StackReference.
And modify docker-image.Image to support passing a more verbose configuration - the configuration for connecting a builder.
It may be that the docker-build.Image resource should be extended to take a "builder config" to add, if not present.
A pulumi destroy on the docker-build.Builder should be equivalent to docker builder rm ..., that is, the Builder becomes a lifecycle managed resource.
This would be useful whether the Builder is a Kubernetes builder, a Docker container builder, etc.
Background, example in Docker CLI
Suppose we have a kube cluster and configure a builder on it.
$ kubectl create ns buildkit # Docker won't do this for you
$ docker builder create --name kube --driver kubernetes --driver-opt=namespace=buildkit --bootstrap --use
[+] Building 5.6s (1/1) FINISHED
=> [internal] booting buildkit                                                                       5.6s
=> => waiting for 1 pods to be ready                                                                 5.5s
kube

This command, creating the builder, both changes the local docker engine state by creating a file here: ~/.docker/buildx/instances/kube (named the name of the builder).
$ cat ~/.docker/buildx/instances/kube | head -c45
{"Name":"kube","Driver":"kubernetes","Nodes":

And it creates a Deployment on the Kubernetes cluster. This is a durable, permanent change on the remote cluster:
$ kubectl get deployment -n buildkit
NAME    READY   UP-TO-DATE   AVAILABLE   AGE
kube0   1/1     1            1           46s

Users may want to manage the durable part of this (the long-lived Kubernetes deployment, a container on a remote Docker Engine) separate from the local part (the local Docker configuration connecting to it.)
Such that they can declare a single builder in one stack and use it from multiple other stacks. That is, a stack can declare a docker-build.Builder which is used for zero or many docker-build.Image resources in that stack, or used via StackReference from other stacks.
Originally posted by @AaronFriel in https://github.com/pulumi/pulumi-docker-build/issues/55#issuecomment-2111184985

Support a docker-image.Builder resource for explicitly configuring a persistent, shared Builder

This needs significant clarification around how this would model docker-container and remote drivers, as well as how local configuration would actually work.
The docker-container driver only provisions a container on the host running the program -- how is that modeled by a Builder resource in shared state?
The remote driver simply configures SSH settings -- what would that provision? How does that apply configuration to my host if the resource was already created on another host?

A pulumi destroy on the docker-build.Builder should be equivalent to docker builder rm ..., that is, the Builder becomes a lifecycle managed resource.

How would my local docker-container builder get cleaned up if the destroy happens on your machine? Similarly for my local remote settings.

This would be useful whether the Builder is a Kubernetes builder, a Docker container builder, etc.

None of what you've described here seems relevant or even possible for docker-container or remote drivers, and the persistent Deployment behind the kubernetes driver can already be managed via Pulumi: bootstrap the builder, import it with pulumi import kubernetes:apps/v1:Deployment buildkit ns/builder0, and omit --bootstrap from docker buildx create.
The functionality gap exists when users need to run docker buildx create ... before they can run their program. Given that this needs to run per-host, it would be appropriate as provider configuration and not a cloud resource.

which may create an unmanaged compute resource (container, Kubernetes Deployment, etc.)

The provider does not create unmanaged Kubernetes Deployments. It will only create a docker-container builder if no builder was specified and a docker-container builder isn't already available. If no builder was specified but a docker-container builder already exists, it will re-use it. (If it doesn't, that's a bug.)

I'm finding myself wanting something that wraps docker buildx create in resource-like semantics (create if doesn't exist, return if does, updates if changed, possibly clean up when I'm done using it).
Like, imagine setting up a k8s cluster to run cloud builds, passing that into builder = Builder('my-cool-build-cluster', {driver='kubernetes'}) and then doing Image(..., builder=builder.name). That'd be neat! And trying to manage the builder registration with just shelling out to docker would require logic to check if the named builder exists and if not create it, and we're like halfway to Resource behavior there.
Except, you're right that it makes absolutely no sense to store Resource state about these things in a way that should be shared among hosts. So you might be right that provider options that work in this resource-ish fashion might be the right pattern? Or just a provider helper function that does this resource-ish behavior? It's either that or a very wonky resource that always refreshes itself.


Integration Test - Release - 2021/11/01 03:46:16

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#pri3'

#pri2

#pri3

#assign PRMergerTest1

#assign NonAllowedUser

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#reassign PRMergerTest2

#reassign NonAllowedUser

#please-close

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

GitHub user PRMergerTest2 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

#unassign PRMergerTest1

#unassign NonAllowedUser


How to run this game?

After clone this repository, what's the next step to play this game?

In general, run python adventuretutorial/game.py, but see the tutorial for more details.

Thank you, it worked!


Does not install on Server 2012 R2

The initial Import-Module WebAdministration fails(Because the IIS parts are not installed with current code) which causes rapid fail on all other items. I'm unclear on why.

PE 2016.5 is where this is being seen.

Looks like it was related to issue with puppet-windowsfeature. Updating to latest module version solved this. Updating puppet-IIS module to 3.0.0 causes new failures, though. I get error:  Unknown resource type: 'iis::manage_site' at /etc/puppetlabs/code/environments/development/modules/chocolatey_server/manifests/init.pp:71:3

IIS 3.x I think removed the deprecated way we were doing to manage things. I think it is likely safe to move up to the new way.

Just moved this over to puppetlabs-iis, so it's likely this is no longer an issue.


Adding http status code to transactions and errors

I would like to add the http status code of a response to Sentry transactions and errors. However, I can't find any documentation on how to do this and haven't been able to figure this out on my own neither.
I'm using the following project for this: https://github.com/XDoubleU/check-in-go-api-proto
Thanks in advance

If you want to add the status code as a (searchable/queryable) event tag to your error event, then this might help: https://docs.sentry.io/platforms/go/enriching-events/tags/
For spans/transactions you can use span.SetTag.


'make test' says "Result: FAIL", yet CI is green...

To reproduce 'make test TESTS=test_test; echo $?'. Last modification to test/run_tests.pl somehow makes it exit(0) irregardless of tests outcome.

Ah, runtests returns a TAP::Harness::Aggregator, and we should check the status explicitly (method get_status).
I'm on the road right now, commenting from my mobile... Not exactly the means to produce a PR, but if you do, I can review.
Ref: http://search.cpan.org/~leont/Test-Harness-3.39/lib/TAP/Parser/Aggregator.pm

#3501


Request: Allow width parameter on mj-button

Scenario:

Can't duplicate this layout with padding only... Would be great to be able to set a width on buttons?

+1

+1
Also needed to make full width buttons

Any idea on how width will be applied on older outlook ?

Seems ok for me.
Full width button 100%:
https://www.emailonacid.com/app/acidtest/display/summary/CuQfi4QnwaQvvkZLO3zcar7uvSaLLMXiPtHkthdRj1YgR/shared
Width set to 300px:
https://www.emailonacid.com/app/acidtest/display/summary/FREgjX72eUVf69xg8d8Tl4ZQ29uvTN4i1A2qx7BXnS5jN/shared
But there are some problems with outlook.com, or is this Email on acid bug?

Hello, that's look good !
Did you set a valid href on your mj-button ? That can break outlook.com if not set properly

Ah ok, no i did not, i will and test again.

Working good: https://www.emailonacid.com/app/acidtest/display/summary/fBHd1TuKNW4s06biz1SR5BtH1QXUXKUTUM4bbF8aHgcYI/shared
Just an alignment issue in Yahoo. But full-width button is without any problems.

Looks good to me !
We have "center" issue on Yahoo see #231

Hi @Tlapi did you only add width on table to achieve this result ? Because when I add it on the table it doesn't work :/

Hi there !
Width is now available in MJML3 !


[stable/openvpn] Container fails with "Filename too long" in entrypoint

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT
Version of Helm and Kubernetes:
Helm: v2.12.1
Kubernertes: v1.13.5
Which chart:
openvpn
What happened:
After deploying, the container fails on startup with:
cp: write error: Filename too long
cp: write error: Filename too long
cp: write error: Filename too long
cp: write error: Filename too long
cp: write error: Filename too long
cp: write error: Filename too long
cp: write error: Filename too long
/etc/openvpn/setup/setup-certs.sh: line 10: ./easyrsa: Filename too long
/etc/openvpn/setup/setup-certs.sh: line 11: ./easyrsa: Filename too long
/etc/openvpn/setup/setup-certs.sh: line 12: ./easyrsa: Filename too long
/etc/openvpn/setup/setup-certs.sh: line 13: ./easyrsa: Filename too long
sed: unmatched '|'
Options error: --dh fails with '/etc/openvpn/certs/pki/dh.pem': No such file or directory
Options error: --ca fails with '/etc/openvpn/certs/pki/ca.crt': No such file or directory
Options error: --cert fails with '/etc/openvpn/certs/pki/issued/server.crt': No such file or directory
Options error: --key fails with '/etc/openvpn/certs/pki/private/server.key': No such file or directory
Options error: Please correct these errors.
Use --help for more information.

What you expected to happen:
The container starts
How to reproduce it (as minimally and precisely as possible):
Deploy the app
Anything else we need to know:

Nevermind, the issue was the storage system on our side ...


md2gemini: 1.8.1 → 1.9.0

Motivation for this change
Changelog
mistune >= 2.0.0 required.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

https://hydra.nixos.org/job/nixpkgs/trunk/python39Packages.hyperkitty.x86_64-linux seems to break this.
@ofborg build python39Packages.hyperkitty

https://hydra.nixos.org/job/nixpkgs/trunk/python39Packages.hyperkitty.x86_64-linux seems to break this.
@ofborg build python39Packages.hyperkitty

Seems to break python3Packages.hyperkitty.

Fixed in upstream: https://gitlab.com/mailman/hyperkitty/-/merge_requests/379

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/709


Add undefined check to 'document' variable in platform_utils

It's possible that document is not defined, e.g., when we're operating in a web worker. This PR adds an undefined check here and makes isIOS return false whenever it's not defined.

Closing this out, thanks @schmidt-sebastian for already having a fix ready to go: 990bfd2e3eaf0f0c977a7af7330ac4ad54f768cb


chore: remove sample

Sample has moved: https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-bigquery-datatransfer/samples/quickstart.js Do not merge until snippet bot is happy.

Sent cl/528590843 to update sample location.

CL submitted, just waiting for new location to be indexed.


Extract view capture executable

Export view and capture xml and executable for the view.

Views extracted and posted on Git.


silent refresh error parameters in event reason object

Describe the bug
Silent refresh error has a different format for reporting the reason of the error.

for silent_refresh_error it is event.reason.params.error
for code_error it is params.error

Expected behavior
I expect the silient_refresh_error to contain the error in event.params.error

I noticed the code_error event is actually nested as reason in the silent_refresh_error event.
{
   type: 'silent_refresh_error'
   reason: {
       type: 'code_error'
       params: {
          error: 'login_required'
      }
}

Is that correct and is the reason always another OAuthErrorEvent?

Thx for reporting. Did you trace this back to the code somewhere yet?
My assumption had always been that this library doesn't touch the error object structure, and that it is in fact the Identity Server behavior that determines the format (and I'm not sure if that's standardized?)


Ability to pass custom formatting via the format option

Hey, thanks for that lib, very useful.
Anyway, for some reasons, one can need to use a different formatting than the defaults provided. For example, displaying headings like that:
=======
HEADING
=======

So this PR simply allow to override keys of the format object with functions of the same signature.

ping @mlegenhausen , what do you think? :)

Good idea, could you please add some documentation?

Here you go.

is it ok for you?

ping @mlegenhausen


[DEDataArrays] Remove DiffEqBase from dependencies

This isn't actually used and it causes a circular dependency in
https://github.com/SciML/DiffEqBase.jl/pull/690.  See also
https://github.com/SciML/DEDataArrays.jl/pull/4.  CC: @ChrisRackauckas.

Ok, let's wait to fix this in the package


[Frontend] Make the ChatInterface Responsive

Description
Currently the frontend components are coded in ReactiveNative as per the figma designs but these are not responsive when run so making them responsive is required

[ ]  It should work for all the screen sizes.

Page Name
Description
Assignee

ChatInterface.js
Interface for chat functionality

InboxInterface.js
Interface for inbox and messages

In Assignees there i haven't there tagged.

@TheNikhilRaj  as the issue is level1 so assigning 2 pages in each of these issues, i hope that's okay for u.

okay then i have to make both the pages?
@Kajol-Kumari

yes @TheNikhilRaj , both pages together will make level1 if the changes required will look more, we will upgrade the level

okay, but where i can find the figma designs i didn't find it can you help me in this, and also can you give me the brief about step by step for what actually what i have to do, or i can develop my own interface.
@Kajol-Kumari

@RohitGupta1237 can you please help Nikhil with the figma and required inputs?

@TheNikhilRaj any doubts?

@TheNikhilRaj any doubts?
@RohitGupta1237 yes what i actually do in this interface and how please explain the step by step process?

@TheNikhilRaj  able to see ? figma

@TheNikhilRaj  able to see ? figma

But I can seen it you have provided the link above

@TheNikhilRaj so all good now?

@RohitGupta1237 i have send the request please accept it ASAP.

@TheNikhilRaj where?

@TheNikhilRaj  are u working on this ? issue

@TheNikhilRaj  are u working on this ? issue

@RohitGupta1237 No


Issues with cellphonedb plot after fresh installation

I installed cellphonedb today. Running the method worked like a charm, but getting the plots to work took me some time. I ran in the following issues:

The REAME suggests to install like this:

conda create -n cpdb python=3.7
pip install cellphonedb

This leads me directly into #19. If I install python 3.8, as specified in environment.yml, this does not happen.

I ran into an issue where the plotting command would throw an error like "graphics api version mismatch". I debugged this and found that my rpy2 was not talking to the R in the cpdb environment but to some other R installation. I solved it by installing rpy2 in the environment using conda (conda install rpy2) prior to installation of cellphonedb.

In summary, I would suggest to update the README to suggest something like:
conda create -n cpdb python=3.8 rpy2
pip install cellphonedb

and change environment.yml to (adding rpy2)
name: cpdb
dependencies:
  - python=3.8
  - r-base
  - r-ggplot2
  - r-pheatmap
  - pip
  - rpy2
  - pip:
    - cellphonedb

Hey，I used your yaml file to create a new cpdb env and I found same issue as markupsafe version error as issue19. After downgrade markupsafe  to 2.0.1, plot fun can run correctly.


"Vărsătura" is listed in the drop-down menu

Description:
"Vărsătura" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Vărsătura" in the search bar.

Expected results
The location is listed in the drop-down menu as "Vărsătura, Brăila (Chiscani)".


Adding default avatar to workspace members page

Details

Invited user displayed without a username and avatar image.
Fixed Issues

$ https://github.com/Expensify/App/issues/11815
$ https://github.com/Expensify/App/issues/11815#issuecomment-1279882632
Tests

Go to Settings->Workspace->Manage members
Kill the internet connection
Invite a new member (you should not have had any communication with him before)
Turn on the internet connection
Verified that the avatar starts with greyed avatar and will apply the default avatar from the server when online

[x] Verify that no errors appear in the JS console

QA Steps

Go to Settings->Workspace->Manage members
Kill the internet connection
Invite a new member (you should not have had any communication with him before)
Turn on the internet connection
Verified that the avatar starts with greyed avatar and will apply the default avatar from the server when online

[x] Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

https://user-images.githubusercontent.com/25520267/196757504-94f23dac-815b-4608-8c5e-ff89b6ee035f.mov
Mobile Web - Chrome

https://user-images.githubusercontent.com/25520267/196757470-ef0b1dcd-6317-4995-a2a2-302c082cdffa.mov
Mobile Web - Safari

https://user-images.githubusercontent.com/25520267/196757525-d346aee9-87d7-49e7-902a-47dbea971ecf.mov
Desktop

https://user-images.githubusercontent.com/25520267/196757534-59f0e698-d1ae-46fd-a5fe-e7eb567f7af1.mov
iOS

https://user-images.githubusercontent.com/25520267/196757469-01269ab7-af69-44fb-b77d-0d810f5f89dd.mov
Android

https://user-images.githubusercontent.com/25520267/196757483-a6a8f55b-214f-408f-a881-d73d7246f9de.mov

Bump @mananjadhav whenever you are ready.

🙄 not an emergency

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @mountiny in version: 1.2.19-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @chiragsalian in version: 1.2.19-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Component value decreasing may jump to femto level and can be negative

For example, Resistor has issues with it. Decreasing from 1 kΩ to just 1 level causes it to go towards -2fΩ. It should rather be 999 mΩ and be bound to be positive i.e. capped at 1 fΩ.

358b2249035d8ef55f738b363b48fba4f0529fe8 solved the issue.


Upgrade react-hook-form to 7.15.3

Upgrade react-hook-form to v 7.15.x required a code change
see: https://react-hook-form.com/migrate-v6-to-v7/
Component: AdvancedTools.js need to be rewrite to support new feature

Fixed in commit https://github.com/AFP-Medialab/we-verify-app/commit/4e1f6b75124d37d0cd60dced974686f75a9c4c19


First update of KEB docs

Description
Changes proposed in this pull request:

Initial update of KEB docs
Add deprecation notes
Consistent use of the name "SAP BTP, Kyma runtime (SKR)"
Add the repository README file
Formatting and language fixes

Related issue(s)
See #26

/test pre-kyma-environment-broker


UI labels does not update on update of translation variable.

I have language defined as below and it works as expected.
$scope.localLang = {
selectAll       : "Tick all",
selectNone      : "Tick none",
reset           : "Undo all"
search          : "Type here to search...",
nothingSelected : "Nothing is selected"
}
But when I change/update $scope.localLang the UI doesn't reflect the same. Shouldn't it update the labels to serve the purpose of angular?

not yet supported :'(
Runtime translation change

http://stackoverflow.com/questions/39284567/is-there-any-way-to-delay-translation-texts-in-angular-multiselect
Can someone please answer my query in above link


Discrepancy between Mempool Market Fee and Bitkit Fee Estimation

Describe the bug
checked the fees in Bitkit - when I click on Custom I can see 50sats / vbyte which is $5.35 according to Bitkit.
In mempool when I see the current fee rate - 56 sats / vbyte is $5.05  (refer to video below)
Reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots / Recording
https://github.com/synonymdev/bitkit/assets/119061223/4df75719-7278-43a8-8c4a-ece07bb56aa9
Operating system
Graphene OS Pixel 6S
Bitkit version
v115
Log output
No response

This happens because mempool calculates the price for average transaction size, while bitkit takes the actual transaction into account.
The more inputs / outputs you have, the bigger it would be


Fix/p2pkhbytelen

We were missing the varint byte when calculating change length, this adds that in.

Codecov Report

Merging #31 (aba1414) into master (4445010) will increase coverage by 2.46%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   76.83%   79.30%   +2.46%
==========================================
  Files          16       16
  Lines         885     1029     +144
==========================================
+ Hits          680      816     +136
- Misses        139      147       +8
  Partials       66       66

Impacted Files
Coverage Δ

tx.go
81.34% <100.00%> (+3.16%)
:arrow_up:

fees.go
100.00% <0.00%> (ø)

varint.go
100.00% <0.00%> (ø)

crypto/hash.go
100.00% <0.00%> (ø)

bytemanipulation.go
100.00% <0.00%> (ø)

input.go
83.33% <0.00%> (+1.07%)
:arrow_up:

output.go
84.15% <0.00%> (+1.20%)
:arrow_up:

crypto/encryption.go
88.23% <0.00%> (+1.56%)
:arrow_up:

bscript/address.go
85.96% <0.00%> (+1.96%)
:arrow_up:

bscript/oppushdata.go
72.83% <0.00%> (+2.17%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4445010...aba1414. Read the comment docs.


API inconsistent for status callbacks

Setting a status callback on a executor:
def state_cb(job, status):
    print(job.id, str(status)

jex = psij.JobExecutor.get_instance(...)
jex.set_job_status_callback(cb)

Setting a status callback on a job:
class StateCB(JobStatusCallback):
    def job_status_changed(self, job, status):
        print('Job {}: {}'.format(job.id, status))

job = Job(JobSpec(executable='/bin/date'))
job.status_callback = StateCB()

Two questions:

should we make this uniform?

which way?

My opinion:

yes

use the executor approach also for jobs

PS.: it might be good to discuss before release as it affects documented API?

Good catch. Clearly, we want uniformity.
I think the only problem I have with the executor approach is that it's somewhat python specific, whereas the other one is a generic OOP solution.

I think the only problem I have with the executor approach is that it's somewhat python specific, whereas the other one is a generic OOP solution.

True - but then again I don't mind python specific for python bindings, really - just the opposite :-)  We could support both - but in general I think it's cleaner to have one way to do things...
Another point in favor for the callable approach: I frequently use a class member method as callback, and passing a callable makes this easy.  Coding that via the JobStatusCallback route is possible, but quite cumbersome...  But that's just a single data point, just happens to be the one where I stumbled over it...).

I think the only problem I have with the executor approach is that it's somewhat python specific, whereas the other one is a generic OOP solution.

True - but then again I don't mind python specific for python bindings, really - just the opposite :-) We could support both - but in general I think it's cleaner to have one way to do things...
Another point in favor for the callable approach: I frequently use a class member method as callback, and passing a callable makes this easy. Coding that via the JobStatusCallback route is possible, but quite cumbersome... But that's just a single data point, just happens to be the one where I stumbled over it...).

I think I agree. It seems unlikely that somebody would move from, say, Java to python and be terribly surprised that the callback is a function in python.


npm install after git init

husky install relies on the current directory being a git repo

@balena-ci I self certify!


I want to add pause or stop button using Audio Cache

I want to add pause or stop button using Audio Cache.
There is no properties in Audio cache
How i play, pause and Stop using assets and audio cache??

I suppose that you are in your
class _homeState extends State
{
// you can like this
AudioCache audioCache = AudioCache();
AudioPlayer advancedPlayer = AudioPlayer();
Future play() async {
advancedPlayer=await audioCache.play('song.mp3');
}
Future stopplay() async {
await  advancedPlayer.stop();
}
Future stopplay() async {
await  advancedPlayer.pause();
}
//and call theses functions in your Scaffold

Please read the docs before asking questions, this is clearly explained in details.

There is even a FAQ section about it -.-


V201705 ClientSidePages element not extracted from modern site

the new schema introduces the ClientSidePages element to provision modern pages.
executing Web.GetProvisioningTemplate against a classic site retrieves any modern pages into this element. Works as expected.
The same code against a modern site does not retrieve any of the modern pages into the output template object. The ClientSidePages remains empty.

retested with V19 and all is good now. thanks chaps.


Prohibit Multiple Pikachu-Starter & Eevee-Starter

This is actually overridden by the rule in mods/letsgo/rulesets

Otherwise a good fix!

@Zarel there is still more than one starter usable per team, when there shouldnt be.

@KrisXV Yes, that's because no one has fixed it. Feel free to. :|

Oh, that code's already in rulesets. I see what you're saying. Yeah, that's a bug somewhere.


Turn into interactive ABM application

From the already-present static ABM plot, transition to a full-fledged interactive application

Using the GLMakie backend and passing the stepping functions took us halfway there. What's left is being able to tune the parameters real-time and have some aggregate plotting play by the side

https://github.com/xlxs4/bacteria-phage-abm-jl-port/commit/f41a4ec573020320d1e743455638b91fb98687f5 for the aggregate plotting

dc2a4962204b4d6571a2132b7464e268e4c56353 in the ages past for tuning the parameters

After some beautification, this can close


noise parameter estimation script

could you provide the noise parameters estimation script？

I removed it in the previous commit. The noise estimation module will be updated with our smartphone denoising datasets later (maybe next year). If you would like to get in-depth help from me, please feel free to contact me<EMAIL_ADDRESS>with a brief self-introduction (including your name, affiliation, and position).


feat() Python: Add tuple_pattern and pattern_list

TLDR:

Add pattern_list
Add tuple_pattern

For pattern_list, after split, joining will returns as tuple_pattern. This is because after splitting, it convert the nodes to tuple_pattern.

Thanks for contributing!
I don't write on python and have a question:
Is here needed brackets and last comma after join?
  (t1, t2, t3,) = (1, 2, 3,)
# |< -------->| - Is here needed brackets and last comma after `join`?
   t1, t2, t3 = (1, 2, 3,)
# | - instead of that

If brackets no needed, you can reconfigure it with:
  tuple_pattern = lang_utils.set_preset_for_list({
    join = {
      space_in_brackets = true,
      last_separator = false,
      format_tree = function(tsj)
        if tsj:has_children({ '(', ')' }) then
          tsj:remove_child({ '(', ')' })
        end
      end,
    },
  }),

Also, it will be cool to change descriptions of new tests something like that:
RESULT OF JOIN (node "tuple_pattern to pattern_list", preset default)

You're right, it's not necessary, plus it's very uncommon to unpack value with parenthesis. I've updated!
Thanks for the feedback 🙂


minTime option doesn't work at all

https://jsfiddle.net/53pkofg3/
$('.time').datetimepicker({ datepicker: false, minTime: '13:00' });
minTime has no effect at all

http://stackoverflow.com/questions/35160907/datetimepicker-mintime-has-no-effect

minTime / maxTime still don't work in V2.5.1

Yes please fix this. I use bower to get this plugin and do not want to download it manually just to fix this bugg

minTime / maxTime not working for me either. Very disappointing.

Thank you for the fix, @jmwiles3 . Do you think you could make a pull request for this?

I dug into this and it is a bug. minTime and maxTime are both dead in current version. https://github.com/xdan/datetimepicker/issues/377 has information on how to do a patch.

Any update on this? It still doesn't work in 2.5.17 and this case is like one year and a month old... Changing core files is not a solution for my case, as I get the script from cloudflare.


[OpenShift] Memory leak inside MCAD at scale

We see memory leaks when thousands of appwrappers are pushed into the system and some of them preempt.

@asm582 can you provide more insight into:
-what was measured ?
-how was it measured ?
-the tag/release number of the before and after
-what was is the expected / desired behaviour?

With latest MCAD changes we do not see memory leak.


Pull latest boo improvements into 3.5 (also fixes a unityscript bug)

We're pretty late in the 3.5 cycle - are these necessary for an important case for 3.5?

It fixes #413085, #409462, #411598 and includes some optimizations and some minor changes to make for better flash content generated by unityscript. In any case I don't see these as very aggressive changes, all the test cases still passing so...


make sure rimraf is windows-ready

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Reviewer - this PR has made changes to one or more package.json files.

Snapshot stored with reference name:
refs/pull/15767/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15767/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15767/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15767/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15767/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15767/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15767/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15767/merge#BCU1XR#0

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15767/merge/testResults/webgpuplaywright/index.html

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15767/merge/testResults/webgl2playwright/index.html


ACLGL convolution accuracy

Hi～，
I'm comparing the result of the CPU F32’s conv and gl fp16‘s conv and found some kind of mismatch. The accuracy between them is vary large， and the deference of each output elem is about 10-2.

Hello @l1a0t1n9,
Is this difference visible when running with real weights/inputs or random values? Well fp16 accuracy is completely different than fp32. We do all our internal calculation natively in fp16 thus no accumulations happen in higher precision. So you have to make sure that your internal calculations are in a range that fp16 arithmetic can handle.
Hope this helps.


[Windows] Drag&drop doesn't work if opened as admin

🐛 Bug Report
When using napari run from the terminal with administrative privileges the drag&drop doesn't work. It doesn't produce any error it just doesn't allow for drag&drop at all showing the crossed circle cursor.
It's a very unusual issue, it works normally when not running as admin. I prefer to always open my terminal as admin to avoid issues with saving data to some directories.
💡 Steps to Reproduce

Open Anaconda Prompt on Windows as administrator
activate napari-env
napari
Try to drag&drop

💡 Expected Behavior
Drag&drop to load the dropped image
🌎 Environment
napari: 0.4.18
Platform: Windows-10-10.0.19045-SP0
Python: 3.9.18 | packaged by conda-forge | (main, Aug 30 2023, 03:40:31) [MSC v.1929 64 bit (AMD64)]
Qt: 5.15.2
PyQt5: 5.15.10
NumPy: 1.26.1
SciPy: 1.11.3
Dask: 2023.10.1
VisPy: 0.12.2
magicgui: 0.8.0
superqt: 0.6.1
in-n-out: 0.1.9
app-model: 0.2.2
npe2: 0.7.3
OpenGL:

GL version:  4.6.0 NVIDIA 537.58
MAX_TEXTURE_SIZE: 32768

Screens:

screen 1: resolution 1920x1080, scale 1.0

Settings path:

C:\Users\kdani\AppData\Local\napari\napari-env_2e626a790d60e92905f0f9db9afaed3db3f38604\settings.yaml
Plugins:
napari: 0.4.18 (77 contributions)
napari-console: 0.0.9 (0 contributions)
napari-svg: 0.1.10 (2 contributions)

💡 Additional Context
No response

Hi there, I think this was also reported for Spyder a couple of years ago: https://github.com/spyder-ide/spyder/issues/11447. The main conclusion was that due to Windows security policies you can't do a drag and drop if the apps have different levels of integrity/privileges (admin vs non-admin). For more details you can check: https://superuser.com/a/59106

Yeah, my wife runs into this with Photoshop and other programs, so it's not a napari issue per se.

Hi there, I think this was also reported for Spyder a couple of years ago: spyder-ide/spyder#11447. The main conclusion was that due to Windows security policies you can't do a drag and drop if the apps have different levels of integrity/privileges (admin vs non-admin). For more details you can check: https://superuser.com/a/59106

Oh, then we can close this. I guess that's another reason to think about switching to another OS. Thank you for the links!


feat(MdSnackBar): implement support for onAction observable

I added a simple implementation for #1616.

@jelbourn the saucelabs_required mode times out.


Does it work?

Hello, did you ever get this working with the new MongoDB ARM (v3.4+)?
I'd like to try this again in Terminal IDE for Android. It's really cool, it gives you a full linux environment without root permissions! I run git, vim, Node.js, etc, in it.
I think it just needs some ENV configuration, and that's all, but I'm not familiar with it as much as you are.
I want to have a portable dev environment for cases when I don't have my laptop. I've been always wanting this, and Terminal IDE gets super close paired with Vim Touch for Android. Now I just need Meteor to work, as that's my main stack for personal projects.

What would I have to do to convince you to make it happen? 💰 ?


Add Homebr3w to Part 3 Section VI

Instead of downloading all things one by one, my friends and me just use Homebr3w to install all the recommended programs in the end. It's very easy.

Homebr3w uses titledb.com, which FBI already does since 2.4.0.

FBI's implementation is not that good though. No search, no automatic update check

Why was this closed?


[BEAM-579] Added Graphite and Csv Spark sinks

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @amitsela

@staslev please add apache license headers to all new files, once you push the changes Jenkins should retry.

@jbonofre or @iemejia you guys are using Spark, are you using the metrics system ? if so, you might find this interesting as well.

I used Graphite in the past yes. Let me take a look.

@jbonofre do you understand what's the issue with Jenkins ? I see Apache Beam :: Parent  failed, but for no apparent reason...

Let me check. I remember we got rat failure due to a heapdump.

It seems that one file in the PR doesn't contain license header (checking which one). RAT is failing.

Usually RAT produces a report, no ? if so, where is it ?

It looks like metrics.properties doesn't contain ASF license header.

The rat report is in target folder of the parent (in the workspace).

Thanks!

Thanks, sorry about that.
Didn't realise non java files needed to have the headers as well.

@staslev No worries. Yes, RAT checks any kind of file (however I excluded some files hard to check). Thanks !

R: @bjchambers
Ben should probably take a look at this too, as he is working on understanding the future of aggregators and dropwizard/graphite are key things we have in mind :)

@amitsela, I've made some changes following our review.
Let me know how it looks.

@staslev looking good, I had one final note, it's probably worth "kicking" Travis anyway..

LGTM, will merge once tests officially pass. Thanks!

I want just to refer here a recent Jira issue talking about ProfilingOptions because this probably will be related in the future.
https://issues.apache.org/jira/browse/BEAM-588

@iemejia how's that relevant to the Python SDK ? I'm not too familiar with it.

To be honest I don't really know, maybe I just misinterpreted but since the issue name was:
"All runners should support ProfilingOptions" I supposed that it could be a new proposal or something that could be related.

I'll keep an eye, thanks!


Bug in linked issues for many projects

Each project should have one closes. Eg:
Closes #X
Closes #Y
...

The same apply for labels. Same fix.


feat: luau color change and .luaurc

Nerd fonts still does not have a luau icon, but at least let's keep the original color from the website: https://luau-lang.org/. Luau also supports a .luaurc file where you can configure some settings for analysis.

Uh, what does that fail mean

Uh, what does that fail mean

Please generate the light colour variants as per https://github.com/nvim-tree/nvim-web-devicons/blob/master/CONTRIBUTING.md
make colors should do it.


fix: number as key

Closes: #14
Fixes this behavior:
dotize.backward({"2": "2"}) => [ null, null, "2" ] // expect { "2" : "2"}

Hi, thanks for your effort, I really appreciate that. But can you create a new pull request with just what you planned to add/change? In this pr you seem like changed all lines, because of reformatting.
Thanks in advance.

Oh and also can you add a test case this pr is solving.


Assembly has duplicate references due to Unity 2019 bug

Assembly has duplicate references: lyuma.av3emulator (Packages/nadena.dev.ndmf/Runtime/nadena.dev.ndmf.runtime.asmdef)

Can be happened when we upgraded ndmf.
now, nadena.dev.ndmf.runtime.asmdf in my project is like this (not modified manually, modified by Unity)
{
    "name": "nadena.dev.ndmf.runtime",
    "references": [
        "GUID:ad78a2bc77b7491eb34cece69bb8f0e6",
        "lyuma.av3emulator"
    ],
    "includePlatforms": [],
    "excludePlatforms": [],
    "allowUnsafeCode": false,
    "overrideReferences": false,
    "precompiledReferences": [],
    "autoReferenced": true,
    "defineConstraints": [],
    "versionDefines": [
        {
            "name": "com.vrchat.avatars",
            "expression": "",
            "define": "NDMF_VRCSDK3_AVATARS"
        },
        {
            "name": "lyuma.av3emulator",
            "expression": "",
            "define": "NDMF_LYUMA_AV3EMU"
        }
    ],
    "noEngineReferences": false
}

🙄


Set up the development environment

As a [role]
I need [function]
So that [benefit]
Details and Assumptions
* [document what you know]

Acceptance Criteria
gherkin
Given Existing libraries and binaries
When Set up the dev environment
Then Successfully compile the code


Improve NACK responder

The RFC for NACK talks about using heuristics to decide if it's worth resending RTP packets when receiving a NACK. For example, one can consider the age of the original packet and the known round trip time to make this decision.
The current implementation naively responds to all NACKs by sending every requested RTP packet. This is problematic as it can cause retransmissions to consume all available bandwidth and if the peer falls too far back it can mean media decoding ends up in a broken state.
A first step to improve this might be to introduce a configurable max elapsed time when NACKs are actioned e.g. in pseudo code:
// When handling incoming RTCP NACKs

for packet in feedback.requested_packets {
  if packet_sent_at.elapsed() > max_nack_age {
    // Don't send this packet and discard it from buffers
  } else {
    // resend requested packet
  }
}

#313 WIP take on this


rgh-toggle-files is not re-added after navigation

Description
The "Toggle files section" does not get re-added after github's turbo navigation.
How to replicate the issue + URL

https://github.com/panva/oauth4webapi
Click the "Toggle files section" element
Navigate to Issues
Navigate back to Code
The toggle is gone, the only way to expand the files section is to do a full reload, then the toggle is present.

Extension version
22.10.11
Browser(s) used
Chrome latest
NB: I hid the "The file list was collapsed via Refined GitHub" notice with .rgh-files-hidden-notice{display:none;} because it has caused issues in the past (getting added multiple times), it also causes content to get pushed after it has rendered, everything's much more stable vertically when this notice is gone.

it has caused issues in the past (getting added multiple times)

That was fixed

it also causes content to get pushed after it has rendered

I'll fix that in my next PR

5. The toggle is gone

Due to https://github.com/refined-github/refined-github/issues/5751

Cheers @fregante, I'll keep the notice hidden anyway, it's just clutter.


removing docker-credentials secret

Signed-off-by<EMAIL_ADDRESS>Fixes https://github.com/IBM/the-mesh-for-data/issues/210

Removed the secret generation (docker-credentials)
Removed attempts to login to the registry inside blueprint controller
Removed references to docker variables inside motion webhooks

@shlomitk1 - please revert the parts using the DOCKER_XXX in the controllers, this is not only useful for private registry but also for integration testing

@shlomitk1 - please revert the parts using the DOCKER_XXX in the controllers, this is not only useful for private registry but also for integration testing

@shlomitk1 - please revert the parts using the DOCKER_XXX in the controllers, this is not only useful for private registry but also for integration testing

How is this useful for integration testing? hostname is only used for login to the registry. Since we don't login to private registry during integration tests, why would it matter?

@shlomitk1 - please revert the parts using the DOCKER_XXX in the controllers, this is not only useful for private registry but also for integration testing

How is this useful for integration testing? hostname is only used for login to the registry. Since we don't login to private registry during integration tests, why would it matter?

@shlomitk1 - please revert the parts using the DOCKER_XXX in the controllers, this is not only useful for private registry but also for integration testing

How is this useful for integration testing? hostname is only used for login to the registry. Since we don't login to private registry during integration tests, why would it matter?
@hunchback Please provide comments inside #210 to continue discussion on what should be done.

As contra, consider the following, hostname is not just used for login:
                        hostname, b1 := os.LookupEnv("DOCKER_HOSTNAME")
			namespace, b2 := os.LookupEnv("DOCKER_NAMESPACE")
			tagname, b3 := os.LookupEnv("DOCKER_TAGNAME")
			if b1 && b2 && b3 {
				r.Spec.Image = hostname + "/" + namespace + "/mover:" + tagname
			}

@shlomitk1 - please revert the parts using the DOCKER_XXX in the controllers, this is not only useful for private registry but also for integration testing

How is this useful for integration testing? hostname is only used for login to the registry. Since we don't login to private registry during integration tests, why would it matter?
@hunchback Please provide comments inside #210 to continue discussion on what should be done.

As contra, consider the following, hostname is not just used for login:
                        hostname, b1 := os.LookupEnv("DOCKER_HOSTNAME")
			namespace, b2 := os.LookupEnv("DOCKER_NAMESPACE")
			tagname, b3 := os.LookupEnv("DOCKER_TAGNAME")
			if b1 && b2 && b3 {
				r.Spec.Image = hostname + "/" + namespace + "/mover:" + tagname
			}

@shlomitk1 - please revert the parts using the DOCKER_XXX in the controllers, this is not only useful for private registry but also for integration testing

How is this useful for integration testing? hostname is only used for login to the registry. Since we don't login to private registry during integration tests, why would it matter?
@hunchback Please provide comments inside #210 to continue discussion on what should be done.

As contra, consider the following, hostname is not just used for login:
                        hostname, b1 := os.LookupEnv("DOCKER_HOSTNAME")
			namespace, b2 := os.LookupEnv("DOCKER_NAMESPACE")
			tagname, b3 := os.LookupEnv("DOCKER_TAGNAME")
			if b1 && b2 && b3 {
				r.Spec.Image = hostname + "/" + namespace + "/mover:" + tagname
			}

Unnecessary. Mover image can be constructed using MOVER_IMAGE env var, and according to @froesef we don't need yet another way.

@shlomitk1 - please revert the parts using the DOCKER_XXX in the controllers, this is not only useful for private registry but also for integration testing

How is this useful for integration testing? hostname is only used for login to the registry. Since we don't login to private registry during integration tests, why would it matter?
@hunchback Please provide comments inside #210 to continue discussion on what should be done.

As contra, consider the following, hostname is not just used for login:
                        hostname, b1 := os.LookupEnv("DOCKER_HOSTNAME")
			namespace, b2 := os.LookupEnv("DOCKER_NAMESPACE")
			tagname, b3 := os.LookupEnv("DOCKER_TAGNAME")
			if b1 && b2 && b3 {
				r.Spec.Image = hostname + "/" + namespace + "/mover:" + tagname
			}

Unnecessary. Mover image can be constructed using MOVER_IMAGE env var, and according to @froesef we don't need yet another way.

@shlomitk1 - please revert the parts using the DOCKER_XXX in the controllers, this is not only useful for private registry but also for integration testing

How is this useful for integration testing? hostname is only used for login to the registry. Since we don't login to private registry during integration tests, why would it matter?
@hunchback Please provide comments inside #210 to continue discussion on what should be done.

As contra, consider the following, hostname is not just used for login:
                        hostname, b1 := os.LookupEnv("DOCKER_HOSTNAME")
			namespace, b2 := os.LookupEnv("DOCKER_NAMESPACE")
			tagname, b3 := os.LookupEnv("DOCKER_TAGNAME")
			if b1 && b2 && b3 {
				r.Spec.Image = hostname + "/" + namespace + "/mover:" + tagname
			}

Unnecessary. Mover image can be constructed using MOVER_IMAGE env var, and according to @froesef we don't need yet another way.

I think the way to go here for customization is what @hunchback started at some point. To make it possible to define this in the module definition. (thus to customize the deployed helm charts in the module definition) (just fyi. This is independent of this issue)

@shlomitk1 - please revert the parts using the DOCKER_XXX in the controllers, this is not only useful for private registry but also for integration testing

How is this useful for integration testing? hostname is only used for login to the registry. Since we don't login to private registry during integration tests, why would it matter?
@hunchback Please provide comments inside #210 to continue discussion on what should be done.

As contra, consider the following, hostname is not just used for login:
                        hostname, b1 := os.LookupEnv("DOCKER_HOSTNAME")
			namespace, b2 := os.LookupEnv("DOCKER_NAMESPACE")
			tagname, b3 := os.LookupEnv("DOCKER_TAGNAME")
			if b1 && b2 && b3 {
				r.Spec.Image = hostname + "/" + namespace + "/mover:" + tagname
			}

Unnecessary. Mover image can be constructed using MOVER_IMAGE env var, and according to @froesef we don't need yet another way.

I think the way to go here for customization is what @hunchback started at some point. To make it possible to define this in the module definition. (thus to customize the deployed helm charts in the module definition) (just fyi. This is independent of this issue)


Change Branch from master to main in Environments

Hi, I changed my default branch in github from master to main. Is it possible to update my environments to use main as the new build branch? I don't see an easy way of editing this on Azure.

Just came out for you in time, the az cli support.
You could use az cli to disconnect and reconnect
https://docs.microsoft.com/en-us/cli/azure/staticwebapp?view=azure-cli-latest
Let us know if this helps.

Thanks! I don't see an update parameter for environment:
(azureml) ➜  ~ az staticwebapp environment -h

Group
    az staticwebapp environment : Manage environment of the static app.
        Command group 'staticwebapp' is in preview. It may be changed/removed in a future
        release.
Commands:
    functions : Show information about functions.
    list      : List all environment of the static app including production.
    show      : Show information about the production environment or the specified environment.

For more specific examples, use: az find "az staticwebapp environment"

Please let us know how we are doing: https://aka.ms/azureclihats

Ah I guess I can do a disconnect and then a reconnect?

My app directory is docs. I don't see an argument for --app-artifact-location when I do reconnect, and it looks like reconnect defaulted to . rather than what I had originally. Is there a way I can specify the location of the app when I reconnect?

@ElleTojaroon could you please help add the parameter.
@akzaidi to mitigate can you update the workflow file. Does that work for now?

Ahh it appears after reconnecting my github actions workflow was updated and it modified the app directory to the default value of ".". I updated my workflow yaml and all is good now.

Hey there, sorry to comment on this years-closed issue, but I'm having a similar issue with a new SWA. I can't seem to set any named branch staging environments, and then I realised that the production_branch setting wasn't being applied, and that in-fact the production branch itself (aptly named 'production') was being ignored by Azure SWA.
I tried the commands above but it seems there's been some changes, as disconnect/reconnect returns the following:
Static Web App <app name> already exists in resource group <resource group>
// ... Below this, a page of JSON regarding the various metrics of the SKU

It looks like I'll re-provision the SWA to see if that solves things. I'll see if disabling commit signing (somewhat reluctantly... relevant issue: https://github.com/Azure/static-web-apps/issues/241#issue-766829810) temporarily, so that Azure can access the repo rather than relying on my YAML.
If you think this is worth a new issue, let me know and I'll make one!


Tap to view fails issue resolved

**When upload fails the notification was coming tap to view but nothing was happening  **
Fixes #4604
assigned pending intent to failed notification which will open MainActivity screen
**Tests performed **
Tested on Redmi note 5 pro.

Hi @sanedroid6006 , can you attach a video/gif showing the changes for reference

https://user-images.githubusercontent.com/43309120/135708444-aac8845b-ec37-433c-8668-b64e5cd18551.mp4

hi @ashishkumar468 video attached check it

Thanks, will review in a while :)
On Sat, 2 Oct, 2021, 1:34 pm Shreyas Bansode, @.***>
wrote:

hi @ashishkumar468 https://github.com/ashishkumar468 video attached
check it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/pull/4656#issuecomment-932706635,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEESAKURNXTX4LSHEM5XUODUE24HFANCNFSM5FGDJVJA
.

Hi @neslihanturan  made requested changes take a look


Added Scan Match Mode to Android

This is a cleaned-up version of #606, where everything is squashed into one commit (and all unnecessary parts are removed).
@Bodwad, could you please double-check this, to make sure it is still working as intended and I did not mess up anything?

Btw, there was an API-level check missing for backwards compatibility. The match mode was introduced in API level 23:
https://developer.android.com/reference/android/bluetooth/le/ScanSettings.Builder#setMatchMode(int)
I added this check in b565ddcd19cca5f141217032dc425e6075fa63a2.

This is a cleaned-up version of #606, where everything is squashed into one commit (and all unnecessary parts are removed).
@Bodwad, could you please double-check this, to make sure it is still working as intended and I did not mess up anything?

Yes I can confirm I have checked and this is all working as expected

I have merged this now. Thanks for the contribution, @Bodwad!

Brilliant thank you, thanks for your help

Is there a planned release date for these changes? Either to pre-release or official release would be great as we need to update a few of our projects that use this official nugget package :)

Is there a planned release date for these changes?

I planned to do another pre-release. Will tag and package it this week ...

Release 2.2.0-pre5 has been published last night!


[HOTFIX][#18] Correct and Enhance update_version.sh

Refs: #18

:tada: This PR is included in version 1.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


SCons: Improve colored output

Expanded the ANSI color code support already implemented in SCons by consolidating the logic in misc/utility/colorize.py. The containing folder, misc/utility, will be for files that aren't meant to be directly run. The overall changes were:

Windows-specific ANSI fix now integrated into colorize.py, so anything that calls that logic will have their terminal automatically setup to handle color output.
Added dim support to color/font output. Not used currently.
High-intensity versions of colors added; adds LIGHT_ prefix to existing colors.
Converted Ansi.GRAY from 256 color to a conditional that checks if continuous integration is active. This works around a previous issue with GitHub Actions causing Ansi.BLACK to output as black instead of gray; now CI specifically will use Ansi.LIGHT_BLACK instead.
Removed other 256-style colors.
Implementing print_info from #88074. Not widely used atm, mostly replacing print("Note: <...>") instances.
doc_status.py, make_rst.py, install_d3d12_sdk_windows.py and the GDExtension methods.py files got their color logic overhauled to utilize the colorize module.

Is there a way to add color in the output of dev_mode=yes?

Hmm, potentially. I know that's just verbose=yes, and SCons will print out the command called when no other command string is provided, so it could be as simple as getting that string and repurposing it somehow. I'll look into it later today

Opted to simply handle all the logic in methods.py instead of making a dedicated module. That file could be split into individual modules eventually, but for now this sticks with the existing style

I like the reduction in code duplication, but I don't love the added dependency on methods.py for Python scripts which are unrelated to the buildsystem.
I'd question whether just getting some pretty colors justifies this complexity (both before this PR and after).

This PR originally kept the color logic in a separate file, misc/utility/colorize.py, so I could go back to that implementation if desired
However, the nature of the repo unfortunately makes some degree of dependencies inevitable. It's normally automated with SCons passing scope up automatically, but the isolated scripts have no choice in the matter. Unless we have some "master" script/hook in the repo root that calls to other scripts, I see no way of working around that fundamental limitation

Thanks!

PS C:\Users\ \Godot> scons use_mingw=yes use_llvm=yes platform=windows module_mono_enabled=yes d3d12=yes scons: Reading SConscript files ... Auto-detected 8 CPU cores available for build parallelism. Using 7 cores by default. You can override it with the-jornum_jobsarguments. Using MinGW, arch x86_64 AttributeError: module 'methods' has no attribute '_colorize':   File "C:\Users\ \Godot\SConstruct", line 616:     detect.configure(env)   File "C:\Users\ \Godot\platform/windows\detect.py", line 929:     configure_mingw(env)   File "C:\Users\ \Godot\platform/windows\detect.py", line 810:     if env["use_llvm"] and os.name == "nt" and methods._colorize:


honor compilerOptions.incremental in build mode

Fixes #468
could use help writing tests 🙈

@dfreeman debugged a bit with Chris this afternoon. I made a few changes to the setupCompositeProject() test helper, verified that any test running projects.root.build() failed, applied my changes, verified those tests are now passing.
NOW, the new issue / topic: why does having an include: ["./types-or-whatever/**/*"] in the root tsconfig.json, paired with non-incremental builds cause TS to throw the error:
Error: Debug Failure. project /Users/hmajoros/Job/glint-test/tsconfig.json expected to have at least one output

cc @chriskrycho because this was confusing the both of us a lot :joy:

why does having an include: ["./types-or-whatever/**/*"] in the root tsconfig.json, paired with non-incremental builds cause TS to throw the error:

I... have no idea 😬
Is it legal to combine files: [] with a non-empty include array? (I'm just spitballing; maybe that's fine)

A bit of extra color for this and #468: the key here is not whether this is itself a recommended pattern (we’ve actually already planned to switch how we’re solving the thing this exposed in our repo), but that the tsconfig.json that triggered the odd failure in #468 works without issue when running tsc; the issue only shows up with when running glint (prior to this PR of course).


Display specific registry in Verification section of a credential on VerifierPlus

We should display the actual registry if it's known in the verification section on VerifierPlus.
Currently, on VerifierPlus, when a credential is verified, if the issuer is in a recognized registry Verifier Plus displays "DCC Trust Registry" for all recognized registries.

pr

It appears that the issuer name is being displayed instead of the registry name.

Oops sorry, can you send me that credential? I think I have it fixed but I want to check with another credential to be sure.

Hey @lautom36 - you can find example credentials here: https://github.com/digitalcredentials/docs/tree/main/example-credentials
You can create your own here: https://issuer.dcconsortium.org/ui

The latest changes are on this pr

Tested in latest version - registry is now being displayed - closing this ticket.

Keeping open until after deployment

Deployed on 3/18/24.


Figure out what to do about new JavaScript private member #syntax

The JavaScript feature to set class members as private by prefixing their name with # is now supported in all modern browsers. This issue tracks its impact on our coding conventions.
Things to look into:

do our conventions currently allow the syntax in JS code? Should they?
do our conventions currently allow the syntax in TS code? Should they?

TypeScript obviously has its own private member syntax (via the private keyword). We should see if they've expressed an opinion about how that syntax will interact with the JS syntax.

TypeScript's documentation for member visibility states that both the private syntax and the # are supported (if you target ES2021 or less, it uses WeakMap rather than the native syntax for #). It doesn't take a position on using one or the other, besides their differences in behaviour (edit-time vs run-time privacy).


REACT: Create Cart component

Story: User can add desired products to their shopping cart #4

Add addtoCart button and handleSubmit in SingleProduct component


Hotfix/fad 6404

Moved from: https://github.com/SparkPost/sparkpost-api-documentation-DEV/pull/344


Eager loading with column sort & search

How do I get sorting & search working with Item::with(['roles', 'rooms'])

@kampit, you need to use join statements to be able to make sort & search work with related tables. Sort and search via eager loading is not yet supported.


Update index.php

Closes #
📑 Description

✅ Checks

[ ] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] All the tests have passed

☢ Does this introduce a breaking change?

[ ] Yes
[ ] No

ℹ Additional Information

Summary by CodeRabbit

New Features

Introduced a personalized welcome message with a collapsible user menu, including a logout button.
Enhanced user interface with Bootstrap styling for improved aesthetics.

Improvements

Maintained session management functionality, ensuring user activity is monitored and redirects to the login page as needed.

@gstraccini codacy bypass


RFE: Autofocus the search input

What is the best way to autofocus the text input today?
In the future it would be nice to have an option to autofocus the input.

Here is my current workaround:
// The emoji-picker-element does not allow auto focusing the search input
// when it's first rendered. We can work around this by observing the
// shadow DOM and focusing the search input when it's added to the DOM.
if (el.shadowRoot) {
  const m = new MutationObserver(records => {
    for (const record of records) {
      for (const node of record.addedNodes) {
        if (node.nodeType === Node.ELEMENT_NODE) {
          const search = (node as Element).querySelector('#search');
          if (search) {
            (search as HTMLElement).focus();
            m.disconnect();
          }
          return;
        }
      }
    }
  });

  m.observe(el.shadowRoot, {
    subtree: true,
    childList: true,
  });
}

I don't think you need a MutationObserver. If you are the one rendering the picker, then you can wait a requestAnimationFrame and then focus the input.
Could you describe your usecase and why you'd like it to autofocus?

I don't think you need a MutationObserver. If you are the one rendering the picker, then you can wait a requestAnimationFrame and then focus the input.

Maybe, it would be simpler but I do not generally like waiting for things. I think it would still involve a "loop" until the input is found.

Could you describe your usecase and why you'd like it to autofocus?

I'm showing the emoji picker in a popover. When the popover is shown I focus the text input so I can search right away.
https://github.com/user-attachments/assets/a971fa5f-07c1-4282-8585-706df582a7dc

requestAnimationFrame is not really a wait. The browser hasn't rendered anything yet, so it's a good time to do a focus. You could probably also wait a Promise.resolve() tick or two.

It is next frame which should be totally fine for focus since it does not need to change the dom.
I'll try it out but I still wish I didn't have to drill into the shadow dom like this.


Update coursier-jvm_2.13, ... to 2.1.20

About this PR
📦 Updates

io.get-coursier:coursier-jvm_2.13
io.get-coursier:coursier-launcher_2.13
io.get-coursier:coursier-proxy-setup
io.get-coursier:coursier_2.13

from 2.1.19 to 2.1.20
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (2.1.19).
You might want to review and update them manually.
.github/scripts/build-linux-aarch64.sh
.github/scripts/get-latest-cs.sh
build.sc
mill

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.get-coursier" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.get-coursier" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Superseded by #3356


#include <tpm20.h> VS #include <sapi/tpm20.h>

There were some 3rd party projects that are still using #include <tpm20.h> in their stable code against tpm2-tss-1.2.x, such as strongswan:

https://github.com/strongswan/strongswan/blob/master/src/libtpmtss/tpm_tss_tss2.c

The changes on sapi.pc from PR https://github.com/01org/tpm2-tss/pull/499 would obviously break their code, perhaps we'd better place another fake "tpm20.h" at the top level of @includedir@

For example:

/* TOPLEVEL TPM 2.0 SOFTWARE STACK HEADER FILE FOR C/C++
 * This "tpm20.h" is placed at top level for those 3rd party code who might use `#include <tpm20.h>` currently
 */
#include <sapi/tpm20.h>

Or consider moving tpm20.h to @inlcudedir@, but also keep the previous sapi/tpm20.h available at the same time

TCTI header include path:
tcti-socket.pc and tcti-device.pc are pointing to @includedir@ after changes from PR https://github.com/01org/tpm2-tss/pull/499
tcti-tabrmd.pc is pointing to subdir @includedir@/tcti, see:

https://github.com/01org/tpm2-abrmd/blob/master/dist/tcti-tabrmd.pc.in

I didn't realize there was a disagreement between the PC files in the TSS libraries and the tabrmd. I'll fix up the tabrmd TCTI PC file. Thanks for the pointer.
The feedback from people packaging for distros is that they don't like having files dropped directly into $includedir. Is there any down side to putting both $(includedir) and $(includedir)/sapi in CFLAGS via the pkgconfig file?

Currently, I can't figure out any down side to putting both $(includedir) and $(includedir)/sapi in CFLAGS.
Thanks, filip!

I'm reopening this to remind me to get a PR together for this change.

I was looking back through the history for the pkg-config metadata and I noticed that a patch from @liuqun is where the -I@includedir@/sapi was removed: https://github.com/01org/tpm2-tss/commit/ca8b438d3de90719658c6fe1ac03b61be10abbd5#diff-2313da1a3ad0d1087173b64ff3febb6c
In the commit message you note that pointing to the sub directories are wrong and everything I can find on the internet seems to agree with you. Since the next release we do from master will be a major version bump we'll be breaking backward compatibility anyways so if we want to do this "right" then we shouldn't be adding these subdirectories back. Can you provide some clarification @liuqun?

Many C/C++ tool kit such as libxml put their headers into a sub-directory under /usr/include and adding a release version as part of the directory name, for example:
$ pkg-config --cflags libxml-2.0
-I/usr/include/libxml2

It should be possible to install two different major release (libxml and libxml2) into the one system while using different directory names. While application developers doesn't have to adjust their existing code, I mean, #include<libxml/parser.h> also works for libxml-2.0
libpng and GTK:
$ pkg-config --cflags libpng
-I/usr/include/libpng16

$ pkg-config --cflags glib-2.0
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include

Some other tool kit such as libjpeg8 and libjpeg9 doesn't create any sub-directory, and just put their header files directly under /usr/include. Sometime when 3rd-party developers need a special version of libjpeg, I guess their should avoid using the header files carried along with the target OS, and build a standalone libjpeg inside their own source tree.

Since PR #862 tpm20.h is now completely removed, I think this issue should be closed anyway.

Agreed


Preferences window does not open

Just installed version 0.3.3 and clicking on the "Preferences" item in the menu does not open nothing.
By looking at the code it seems the dialog being opened does not exist.
https://github.com/xiamaz/YabaiIndicator/blob/1efc8aea1be71884f59434e70a2149f0d9cfeba1/YabaiIndicator/YabaiAppDelegate.swift#L127

I have exactly the same problem.

Should be fixed in 0.3.4.


Simultaneously inserting multiple records into a distributed table without a primary key.

What type of bug is this?
Data corruption, Incorrect result
What subsystems are affected?
Frontend
What happened?
commit: c5f507c20e69b28dd2291c2e5649d05fe4fe67cb
Using INSERT INTO dist_table(n, row_id) VALUES (1, 1), (2, 2), (3, 3), (4, 4), (5, 5), (6, 6), (7, 7), (8, 8), (9, 9), (10, 10), (11, 11), (12, 12); to simultaneously insert multiple records into a partitioned table without a primary key, under the condition of not crossing partitions, only the last data will be retained. If it's across multiple partitions, each partition will retain only the last data.

And the timestamps for each individual data record are not consistent.
When performing the same operation on a single table without a primary key, the results are inconsistent with the previous case.

I think the results for both the single table and the partitioned table should be consistent.
What operating system did you use?
6.1.41-1-MANJARO
Relevant log output and stack trace
No response
How can we reproduce the bug?
CREATE TABLE dist_table(
    ts TIMESTAMP DEFAULT current_timestamp(),
    n INT,
    row_id INT,
    TIME INDEX (ts)
)
PARTITION BY RANGE COLUMNS (n) (
    PARTITION r0 VALUES LESS THAN (5),
    PARTITION r1 VALUES LESS THAN (9),
    PARTITION r2 VALUES LESS THAN (MAXVALUE),
)
engine=mito;

INSERT INTO dist_table(n, row_id) VALUES (1, 1), (2, 2), (3, 3), (4, 4), (5, 5), (6, 6), (7, 7), (8, 8), (9, 9), (10, 10), (11, 11), (12, 12);

If a partitioned table with a primary key is used, where the primary key and partition key do not intersect, inserting the same primary key data into different partitions will still encounter the aforementioned issue.

I think that during the split_insert() process, the data with the same primary key should be merged, retaining the last input data, rather than handling this in the dn. This approach could help resolve this issue

In fact, the time index column will be added to the primary key implicitly.  So if you don't create the primary key, then the time index column is the actual primary key. And the data with the same timestamp will be overwritten. (The last one wins as you see).
But in distributed mode, if the partition key is not the same as the primary key, then the primary key will be regional, not global. If you want to keep the global primary key constraint, you must ensure the portion key is the same as the primary key(Both of the columns and column orders).
I think this behaviour is acceptable, and the distributed mode can't be consistent with the standalone mode.
We need some docs to describe the primary key and partition key in detail. @nicecui

But in distributed mode, if the partition key is not the same as the primary key, then the primary key will be regional, not global. If you want to keep the global primary key constraint, you must ensure the portion key is the same as the primary key(Both of the columns and column orders).
I think this behaviour is acceptable, and the distributed mode can't be consistent with the standalone mode.

Thank you for your answers, I understand!
There is still an issue regarding when to insert the default value of the time index. Should it be inserted in the fe or in the dn? Inserting it in the dn can lead to different timestamps when inserting multiple data records simultaneously.

We need some docs to describe the primary key and partition key in detail. @nicecui

I also suggest modifying the example in the docs.


Adds shell script that executes job cancellation, cluster and bucket deletion.

Adds nightly_cancel.sh - it executes the script cancel_job_delete_cluster.sh for all of the clusters.

/gcbrun

Closed as no longer needed.


Add setup.py file

The setup.py file makes it easy to install the application for other users and adds the capability of building a Python wheel which can be distributed publicly.
Closes #4
Signed-Off-By: Robert Clark<EMAIL_ADDRESS>

Took a lot of thrashing to get there, but think this is finally in good shape and looking the way I hoped it would. Users can now install the package with:
pip install imageinary

This will only install the necessary packages for generating standard images, such as JPG and PNG. There are also options for MXNet, TFrecords, and all which install all of the other dependencies to unlock the remaining functionality. I felt this would be helpful to not force users to download/install the heavyweight MXNet and TensorFlow binaries if they are only going to create standard image files.


problem in using a snakefile as module

Hi,
I am trying this :
module mrna_workflow:
    snakefile: 'https://github.com/maxplanck-ie/snakepipes/blob/1.2.3/snakePipes/workflows/RNA-seq/Snakefile'

use rule * from mrna_workflow as mrna_*

on top of my snakefile but I get the indentation error, Could you please tell how I can fix that:

IndentationError in line 148 of <tokenize>:
unindent does not match any outer indentation level (<tokenize>, line 148)

Have you tried changing blob to raw
'https://github.com/maxplanck-ie/snakepipes/raw/1.2.3/snakePipes/workflows/RNA-seq/Snakefile'
or using  github function to generate a path
github("maxplanck-ie/snakepipes, path="snakePipes/workflows/RNA-seq/Snakefile", tag="1.2.3")

thanks a lot! I have tried using raw, indeed I do not get the indent error, but it does not recognize the variables which used in the snakefile, even though I provided a yaml file as a config with variables being available there.
I have also tried github but it fails name 'github' is not defined

Have you tried:
snakefile: 'https://raw.githubusercontent.com/maxplanck-ie/snakepipes/master/snakePipes/workflows/mRNA-seq/Snakefile'

yes, so what i am basically doing now is:
module mrna_workflow:
    snakefile: "https://raw.githubusercontent.com/maxplanck-ie/snakepipes/master/snakePipes/shared/rules/GenomicContamination.snakefile"
    config: '/path/to/test.config.yaml'

use rule * from mrna_workflow as mrna_*

inside the test.conig.yaml:
aligner: STAR

run snakemake:
$ snakemake -j 2

error:
Traceback (most recent call last):
  File "/data/processing3/leily/miniconda3/envs/ttseq/lib/python3.7/site-packages/snakemake/__init__.py", line 594, in snakemake
    snakefile, overwrite_first_rule=True, print_compilation=print_compilation
  File "/data/processing3/leily/miniconda3/envs/ttseq/lib/python3.7/site-packages/snakemake/workflow.py", line 1182, in include
    exec(compile(code, snakefile.get_path_or_uri(), "exec"), self.globals)
  File "/data/processing1/leily/RNA-pipelines/Snakefile", line 43, in <module>
  File "/data/processing3/leily/miniconda3/envs/ttseq/lib/python3.7/site-packages/snakemake/workflow.py", line 1797, in decorate
    ruleinfo=None if callable(maybe_ruleinfo) else maybe_ruleinfo,
  File "/data/processing3/leily/miniconda3/envs/ttseq/lib/python3.7/site-packages/snakemake/modules.py", line 65, in use_rules
    self.workflow.include(snakefile, overwrite_first_rule=True)
  File "/data/processing3/leily/miniconda3/envs/ttseq/lib/python3.7/site-packages/snakemake/workflow.py", line 1182, in include
    exec(compile(code, snakefile.get_path_or_uri(), "exec"), self.globals)
  File "https://raw.githubusercontent.com/maxplanck-ie/snakepipes/master/snakePipes/shared/rules/GenomicContamination.snakefile", line 7, in <module>
    import os
NameError: name 'aligner' is not defined

snakemake version:
$ snakemake -v
6.10.0

don't you have to create a variable called aligner and assign it the value from the config file or extract if from the config dict config['aligner'] in the rule?

I agree, I was hoping for something like that too, however aligner is not used as a param or an input in the rule, here is the link to the rule:
https://github.com/maxplanck-ie/snakepipes/blob/master/snakePipes/shared/rules/GenomicContamination.snakefile#L4
I was also trying to make a global variable before using the rule but that also does not work.
so an example of what I have is this:
aligner = config['aligner']
use rule GContamination_featureCounts from mrna_workflow as mrna_GContamination_featureCounts with:
    input:
        bams = "test1",
        gtf = "test2"
    output:
        txt = "out1",
        summary = "out2"

which does not work

I have just started to play around with modules and had problems with global variables. I was trying to use the config dict in my module and got some errors
configfile: "config.yaml"

 module alignment:
    snakefile: github("hydra-genetics/alignment", path="workflow/Snakefile", tag="develop")

resulted in that the module couldn't find the cofig dict
configfile: "config.yaml"

 module alignment:
    snakefile: github("hydra-genetics/alignment", path="workflow/Snakefile", tag="develop")
    config: "path/to/config.yaml"

now my module found a config variable, but it was a string
the working solution for me was
configfile: "config.yaml"

 module alignment:
    snakefile: github("hydra-genetics/alignment", path="workflow/Snakefile", tag="develop")
    config: config

now I could access the config dict in my module.

Hey Patrik, Thanks a lot! although, unfortunately my issue is still there, the thing is that it fails to detect aligner from the config file even before using a certain rule, even if I just call:
configfile: '/data/processing1/leily/RNA-pipelines/test.config.yaml'
module mrna_workflow:
    snakefile: "https://raw.githubusercontent.com/maxplanck-ie/snakepipes/master/snakePipes/shared/rules/GenomicContamination.snakefile"
    config: config

use rule * from mrna_workflow as mrna_*

The error points to the following directions, do they mean anything to you?
Traceback (most recent call last):
  File "/data/processing3/leily/miniconda3/envs/ttseq/lib/python3.7/site-packages/snakemake/__init__.py", line 594, in snakemake
    snakefile, overwrite_first_rule=True, print_compilation=print_compilation
  File "/data/processing3/leily/miniconda3/envs/ttseq/lib/python3.7/site-packages/snakemake/workflow.py", line 1182, in include
    exec(compile(code, snakefile.get_path_or_uri(), "exec"), self.globals)
  File "/data/processing1/leily/RNA-pipelines/Snakefile", line 50, in <module>
  File "/data/processing3/leily/miniconda3/envs/ttseq/lib/python3.7/site-packages/snakemake/workflow.py", line 1797, in decorate
    ruleinfo=None if callable(maybe_ruleinfo) else maybe_ruleinfo,
  File "/data/processing3/leily/miniconda3/envs/ttseq/lib/python3.7/site-packages/snakemake/modules.py", line 65, in use_rules
    self.workflow.include(snakefile, overwrite_first_rule=True)
  File "/data/processing3/leily/miniconda3/envs/ttseq/lib/python3.7/site-packages/snakemake/workflow.py", line 1182, in include
    exec(compile(code, snakefile.get_path_or_uri(), "exec"), self.globals)
  File "https://raw.githubusercontent.com/maxplanck-ie/snakepipes/master/snakePipes/shared/rules/GenomicContamination.snakefile", line 7, in <module>
    import os
NameError: name 'aligner' is not defined

could it be that it cannot handle the variable structure in my "other" snakefile?
Here is the link to that:
https://github.com/maxplanck-ie/snakepipes/blob/master/snakePipes/shared/rules/GenomicContamination.snakefile#L4

Have you tried to modify GenomicContamination.snakefile
´´´
bams = aligner + "/{sample}.bam",
´´´
to
´´´
bams = config['aligner'] + "/{sample}.bam",
´´´

Hey Patrik, yes that would do the trick. Thanks!
So as stands, I may not be able to use module, since it needs a lot of changes in the other workflow. I am already using subworkflow but since it is depreciated, I was hoping to be able to use the module.  Do you maybe have any recommendation there?


Use the prod distribution of React instead of dev in the CDN example

we are already doing this in #3380

thanks, though!

Maybe I don't understand it fully, but that PR is for the graphiql-webpack example not the graphiql-cdn example no?
The reason for this PR is there are GraphQL frameworks out there like strawberry and graphene-django that serve GraphiQL and use the CDN example here as reference. Because of this sometimes they just copy paste and ended up shipping with react development which is 10 times the size of production.min.js. Example.
Maybe it's worth changing here too?

@acao ping... I do agree with @kiendang here. Would you mind to reconsider this PR?

does https://graphiql-dev.netlify.app/webpack not work? what is the purpose in particular?

@acao it seems to me that @kiendang stated the problem quite clear:

The reason for this PR is there are GraphQL frameworks out there like strawberry and graphene-django that serve GraphiQL and use the CDN example here as reference.

The choice of the graphiql-cdn example is obvious, because they do not want to bother with webpack and/or other toolchains just to serve the GraphiQL page. So, they mostly use it "as is", adjusting it only in few bits to work with the framework, but do not re-check optimality of the dependencies. And then things go viral, because every framework has its users.

Because of this sometimes they just copy paste and ended up shipping with react development which is 10 times the size of production.min.js.

oh this is for the cdn example! that makes sense

really, we should be showing how to use <script type="module"> as modern browsers don't need UMD anymore but that's another matter

Thanks a lot @tyranron for the clarification 👍
@acao let me know if there's anything else needed to get this merged.


Specify lambda node runtime via cli

What would be the best way to specify the lambda runtime?
Been building with 18 locally.

Done :) Use --lambdaRuntime flag on deploy command.

Thanks!