fix(demos/config) fix for config page not updating. #9413

Short description of what this resolves:
Config demo was not updating when settings were saved.
Changes proposed in this pull request:

Move the setting of config from the ApiDemoPage to ApiDemoApp
Add injectable Config to ApiDemoPage and sett this.config=config.settings()

Ionic Version: 1.x / 2.x
2.x
Fixes: #
#9413

Thanks for the PR! Could you update it from master and I'll take a look at it? :)

Yea it was a long time ago so it might take a little bit to get back up to speed and make sure other changes have not changed the need for this.  I'll try to get it back to you by tomorrow.

Awesome thank you! Please make sure to run it using gulp demos.watchProd --f=config too. :)

@brandyscarney  hopefully this isn't too dumb of a comment ;) but when i run gulp demos.watchProd --f=config and go to : http://localhost:8000/dist/demos/config/  it just gives me a blank screen and a bunch of 404 console errors : localhost:800/demos/config/build/main.css  and demos/config/build/main.js  any suggestions on what I'm doing wrong?

@ncapito Ahh yeah the demos task got a little messed up with our recent change to work with app-scripts. The dev build needs a different import than the prod build in order to work. Hmm can you try modifying the code here: https://github.com/driftyco/ionic/blob/master/scripts/gulp/tasks/demos.prod.ts#L116-L124
to add the --debug flag like so:
    const scriptsCmd = spawnSync('ionic-app-scripts',
      ['build',
      '--debug',
      '--prod',
      '--sass', sassConfigPath,
      '--appEntryPoint', appEntryPoint,
      '--srcDir', distDir,
      '--wwwDir', distDir,
      '--tsconfig', tsConfig
      ]);

And then see if there are any errors in the output by running gulp demos.prod --f=config again?

I went ahead and tested this against our latest build process. It looks good, thank you!


An example with multiple controllers

Good day colleagues,
Sorry that I am writing here but could someone provide an example of the yaml file which will deploy the LINSTOR csi plugin along with the needed k8s sidecar containers in case of multiple controllers? In the readme we have only "You will need to change all instances of LINSTOR_IP to point to the controller(s) of the LINSTOR cluster that you wish this plugin to interact with." But what syntax should I use for it. I have a separate k8s cluster and a separate storage cluster. The IPs of the controllers are <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>. The IPs of the worker nodes of the cluster are <IP_ADDRESS>-13.
Thanks a lot in advance.

You'll need to make two changes to the default examples:

remove the --linstor-endpoint argument, as it only supports a single IP
add a LS_CONTROLLERS variable, where you specify the IPs, separated by ,, so: <IP_ADDRESS>,10.0.10,2,...


Add  JBrowse documentation

Getting started with PomBase JBrowse.pdf
Would make more sense for this to be "core documentation"

Yeah I just wanted to send something out as part of the announcement, we should have something similar in the documentation

I've added a link to the "Getting started" doc to the main documentation page (https://www.pombase.org/documentation). Close this if that's enough.

I can write it up so that it can be shown on the website. Would a word/google doc do?

Not sure I fully understand the question - the PDF content displays in most browsers anyway (and if it doesn't, that's down to someone's browser settings). It would actually be worse to link to a Word doc or even a Google doc.
If you want to have the content on a web page, it'll have to be converted to HTML, or maybe Markdown would suffice; it depends on how complex the structure and formatting are. But for that, it's approximately as easy to copy/paste from the existing PDF as from a word-processor doc. And I'm not sure we'd gain enough to make it worth having two versions that could drift out of sync.

I agree, the pdf needs to be migrate into the html, and deprecate the pdf, it was temporary.

I meant something that could be easily converted to web page format.

A word doc seems like a tangent. For a web page, we need to mark up the text and put the images in the correct directory.

I don't understand why we would have two versions? We would have the documentation that's online.

This implies that we would remove links to the PDF - otherwise, it will hang around and be the second version after we add a web page.
I'm happy to have a web page instead of the current PDF, and can convert the text from it without anyone creating new Word docs (I have no use for Word in this effort). I'll need to know where to find the images so I can copy them into the github repository.

Yes just remove the links once appropriate, it was just a temporary measure, it's not how we normally provide documentation.
I really didn't want to send the announcement without some supporting help documentation of "how to get going" for novices  (I didn't know how to add a website help page + you were at beerfest when we sent it, we also didn't want to delay announcement since the data was up there)

I've added a new documentation page. Over to @kimrutherford to update the website.
I'll check it over and fix any problems that I couldn't spot in the text editor, and then close this.

It's now updated in pombase-dev if you'd like to have a check before it goes live.
http://pombase-dev.bioinformatics.nz/

Thanks - it looks pretty good. This afternoon I'll fix some typos and it'll look even better. After today's commit it should be ready to go live.

I've committed my fixes, and I think it's ready (anything left to fix is probably small enough not to cause problems if it does reach the live site).

I've committed my fixes, and I think it's ready

I'm off to bed but I've just kicked off a pombase-dev update.  Should be done in 10 minutes-ish if you want to have a look.  It will go live on the main site tonight (UK time) or on (UK) Wednesday morning.

Cool, thanks, and sleep well :)

I've updated the main site.

Thanks, but oddly, it's showing the version from Monday. It doesn't have the small fixes I did yesterday. I don't think I forgot to push the changes, and I do see the newer version in the GitHub web interface "code" tab. Any ideas?

Sorry, I forgot to push the update to GitHub.  All updated for real this time I hope.

I'm disproportionately glad it wasn't me ;)
All looks good now; thanks again. I think that's this one done - yay!


A proper "Status strip rendered ProgressBar" please ?

here is a starting point:
https://stackoverflow.com/questions/20584132/change-the-color-of-a-toolstripprogressbar-without-disabling-the-xp-visual-style

Using the above, I have got a "Reasonable colour background" with the following event added to the status strip:
    private void StatusStrip_RendererChanged(object sender, EventArgs e)
    {
        if ( ToolStripManager.Renderer is KryptonProfessionalRenderer kpr )
            progressBar.BackColor= kpr.KCT.StatusStripGradientEnd;
    }

I'll look into it

I wonder if this would help https://docs.microsoft.com/en-us/dotnet/framework/winforms/controls/walkthrough-creating-a-professionally-styled-toolstrip-control

Yep, the renderer thing would need to be in the Components dll, so this issue will need to be transferred

Transferred


remove duplicated allocation

report_number is zero before the condition.
don't need to set zero again.

Sure. I'll send new one with that.


"user" table_name is not considered by the library

Hi,
In our sql query, the table_name is "user". But this is not been considered when I parsed and try to get the table_names.
`irb(main):010:0> query = "select * from user"
=> "select * from user"
irb(main):011:0> @parsed_query = PgQuery.parse(query)
=> #<PgQuery:0x00000009d56638 @query="select * from user", @tree=[{"SelectStmt"=>{"targetList"=>[{"ResTarget"=>{"val"=>{"ColumnRef"=>{"fields"=>[{"A_Star"=>{}}], "location"=>7}}, "location"=>7}}], "fromClause"=>[{"RangeFunction"=>{"functions"=>[[{"FuncCall"=>{"funcname"=>[{"String"=>{"str"=>"pg_catalog"}}, {"String"=>{"str"=>"current_user"}}], "location"=>14}}, nil]]}}], "op"=>0}}], @warnings=[]>
irb(main):012:0> @parsed_query.tables
=> []`
Let me know if we would need to do any change to accommodate this?
TIA

The parse tree seems to indicate that your query is actually interpreted as "SELECT * FROM current_user()".
I think this is an escaping issue in your input - if you put the user in double quotes, it works as expected:
irb(main):006:0> query = "select * from \"user\""
=> "select * from \"user\""
irb(main):007:0> @parsed_query = PgQuery.parse(query)
=> #<PgQuery::ParserResult:0x00007f8290828768 @query="select * from \"user\"", @tree=<PgQuery::ParseResult: version: 130003, stmts: [<PgQuery::RawStmt: stmt: <PgQuery::Node: select_stmt: <PgQuery::SelectStmt: distinct_clause: [], target_list: [<PgQuery::Node: res_target: <PgQuery::ResTarget: name: "", indirection: [], val: <PgQuery::Node: column_ref: <PgQuery::ColumnRef: fields: [<PgQuery::Node: a_star: <PgQuery::A_Star: >>], location: 7>>, location: 7>>], from_clause: [<PgQuery::Node: range_var: <PgQuery::RangeVar: catalogname: "", schemaname: "", relname: "user", inh: true, relpersistence: "p", location: 14>>], group_clause: [], window_clause: [], values_lists: [], sort_clause: [], limit_option: :LIMIT_OPTION_DEFAULT, locking_clause: [], op: :SETOP_NONE, all: false>>, stmt_location: 0, stmt_len: 0>]>, @warnings=[], @tables=nil, @aliases=nil, @cte_names=nil, @functions=nil>
irb(main):008:0> @parsed_query.tables
=> ["user"]

Thanks for pointing it out. But is there any other approach for this? Instead of having an additional quotes around the table_name? For other table_names, this works fine without the quotes around it. We can't specify that for "user" table, wrap it around an quote.

Thanks for pointing it out. But is there any other approach for this? Instead of having an additional quotes around the table_name? For other table_names, this works fine without the quotes around it. We can't specify that for "user" table, wrap it around a quote. @lfittl please advice

I'm not sure I'm following - your query has a different intent when there are no quotes, as you are not referencing that "user" table, you are referencing the current_user function through the "user" alias.
Where are you getting your query texts from? I'm surprised why you don't have correct escaping on the input queries you are working with.


Run a custom deploy hook script defined in DEPLOY_HOOK environment variable

I needed to share generated certificates with nginx, but there were no easy way to do it as nginx expects different directory/file structure. This is a popular need, as can be seen in #16.
Solution recommended in the issue, to put a script in /etc/letsencrypt/renewal-hooks/deploy does not help much, because scripts from this directory are executed only on certificate renewal. They are not executed on certificate creation.
This pull requests introduces DEPLOY_HOOK environment variable allowing to execute a custom deploy hook every time a certificate is created or renewed.
It's best described by a change in README (also included in the commit), so I paste it below for better readability:

Run a custom deploy hook script
You can specify a script or a command to execute after a certificate is created or renewed, by specifying DEPLOY_HOOK environment variable. This is useful if you want to copy certificates someplace else or need to reorganize file structure.
All standard environment variables will be available in your script, as well as two new variables set by certbot:

RENEWED_LINEAGE - directory with certificate files (e.g. /etc/letsencrypt/live/domain)
RENEWED_DOMAINS - list of domains for the certificate, separated by space

Example: copying all new or renewed certificates to a single directory with domain.crt and domain.key filenames, making it easily usable with nginx:
Create deploy-hook.sh file and make it executable.
#!/bin/sh
mkdir -p "/etc/nginx/certs"
cd "/etc/nginx/certs"
for domain in ${RENEWED_DOMAINS}; do
    cp "${RENEWED_LINEAGE}/fullchain.pem" "${domain}.crt"
    cp "${RENEWED_LINEAGE}/privkey.pem" "${domain}.key"
    chown $CERTS_USER_OWNER:$CERTS_GROUP_OWNER "${domain}.*"
    chmod $CERTS_FILES_MODE "${domain}.*"
done

Execute:
docker run \
	--name letsencrypt-dns \
	--volume /etc/letsencrypt/domains.conf:/etc/letsencrypt/domains.conf \
	--volume /etc/letsencrypt/deploy-hook.sh:/usr/local/bin/create-nginx-certs \
	--volume /var/docker-data/letsencrypt:/etc/letsencrypt \
	--volume /var/docker-data/nginx:/etc/nginx/certs \
	--env<EMAIL_ADDRESS>\
	--env 'LEXICON_PROVIDER=cloudflare' \
	--env 'LEXICON_CLOUDFLARE_USERNAME=my_cloudflare_email' \
	--env 'LEXICON_CLOUDFLARE_TOKEN=my_cloudflare_global_api_key' \
	--env 'DEPLOY_HOOK=create-nginx-certs' \
	adferrand/letsencrypt-dns

Thanks for the comments! Fixed.

Great ! I merge and prepare a release.


Add link to accessibilty info in the footer

Blocked until the page or document with the accessibility information is created.
Related email from Astrid:

I've asked Rochelle to draft accessibility language that can be used on sites that are cross-institution and not Stanford-specific. We will then link to that language in the footer of these sites that are cross-institution. I think we will have that link go to a pdf (that is accessible of course!).

Replaced by https://github.com/pod4lib/aggregator/issues/1014


Byte array support in Regex

I really need regex support for an array of bytes. As done in python - re.finditer.
For example task: divide byte array by separator.

cc @lrhn

That's not something we support. It's not something we can support easily in JavaScript, we'd have to either introduce a complete new RegExp engine or silently convert the bytes to a string, run RegExp on the string, then convert it back.
That's what I'd recommend that you do yourself: Convert the byte array (assuming a Uint8List) to a string (String.fromCharCodes(byteList)), run the RegExp on the string, and then use the code units of the resulting strings (or convert them back to Uint8Lists using Uint8List.fromList(string.codeUnits) if you need Uint8Lists).
Both String.fromCharCodes(byteList) and Uint8List.fromList(string.codeUnits) are optimized on the VM.

@lrhn thanks for the reply.
I was considering converting the byte array to a string, but in my case I have a large amount of streaming binary data coming in, it would be expensive to convert it each time to a string, then process it using regular expression. And I'm afraid I might lose some of the data while encoding.
For example In python you could put Union[bytes, str] as input to re.finditer. Yes, there is a bytes type in python:


[NEW]: Hack'N Heights: Unlocking Decentralized Data on a Berlin Rooftop

Please use this template to suggest a new event or update an existing event for the BBW website! You can also directly submit your event as a pull request to this repository. This will speed up things significantly!
# the name of your event
name = "Hack'N Heights: Unlocking Decentralized Data on a Berlin Rooftop"

# shortest possible name (without year)
shortname = "Hack'N Heights: Unlocking Decentralized Data on a Berlin Rooftop"

# type of the event
#  available types (you can choose more):
#   * meetup
#   * conference
#   * hackathon
#   * expo
#   * party
#   * other
types = ["meetup ¨ ]

# status of the event
#  available types:
#   * idea
#   * planning
#   * published
status = "published "

# the name of the group organizing the event
org = "Chainlink, The Graph  and Deutsche Telekom¨

# the github handle of the directly responsible individual for this event
# (this person will coordinate with #bbw24 organizers)
dri = "lorena1974"

# A point of contact (responsible person)
poc = "Lorena Fabris"

# the start date of the event
date = "2024-05-21"

# how many days the event lasts (1 - N)
days = 1

# the event times (shows up in the event card)
times = "18:00-22:00"

# Link to venues from the Places table - use this OR enter venueName, venueUrl and venueAddress
# venues = ["gabriel-loci"]

# the event venue name
venueName = "Deutsche Telekom building"

# link to the venue on open-street maps
venueUrl = "https://www.openstreetmap.org/search?query=Winterfeldtstra%C3%9Fe%2021#map=19/52.49633/13.35783"

# the event venue address
venueAddress = "Winterfeldtstraße 21 10781 Berlin"

# the languages in which the event will take place (you can choose more)
languages = ["english"]

# the max number of attendees of the event
attendees = 100

# blockchains that the event deals with
# if it is an interchain event, then leave blank
chains = [" "]

# tags for the event, will show up as labels.
# pick 1-4
tags = ["data", "subgraphs", ¨hackathon¨]

# A logo attachment
logo = "![HacknHeights_SocialPost1_C1V3 (2)](https://github.com/blockchainweek/data/assets/71536313/b5267ec3-2bd5-4bd7-9d8e-e126a43838c5)"

# a description of the event.
description = "Set against the dynamic backdrop of a vibrant Berlin rooftop, "Hack'N Heights" invites you to delve into the vast potential of decentralized data during Berlin Blockchain Week 2024. Hosted at the iconic Deutsche Telekom building, this evening with technical presentations serves as the official kick-off for the Hack’N Heights Online Hackathon.Hack’N Heights kickoff event is organized by leading entities including Chainlink, Deutsche Telekom, The Graph Protocol.The virtual hackathon is co-sponsored by Chainlink, The Graph, Plurality Network, Pinax, Deutsche Telekom, and Soonami with Bounties of over 6K and potential investment opportunities for promising projects. We cordially invite you to the vibrating kickoff of Hack’N Heights - A night of enlightenment and connections. Engage with groundbreaking tools and protocols that harness the value of decentralized data through a series of expert-led technical presentations.
Event Highlights:
Expert Presentations: Gain insights from leaders in blockchain technology, including Solange Gueiros from Chainlink Labs, Amaechi Okolobi, a Chainlink Developer Expert and Arturo Castanon Advocate from Graph AdvocatesDAO.
Dynamic Networking: Connect with pioneers and peers within the blockchain and web3 communities. Expand your network, exchange ideas, and discover new opportunities in an inspiring setting.
Complimentary Refreshments: Enjoy a variety of snacks and drinks provided throughout the evening at no cost, ensuring a comfortable and engaging experience.
""
![HacknHeights_SocialPost1_C1V3 (1)](https://github.com/blockchainweek/data/assets/71536313/5a15027a-d997-4908-855c-0b2bb550a689)

[cfp]
# link to call for participation

- link = "https://example.com/speaker"

[registration]
# type of registration
#  Possible values:
#   * tickets
#   * invites
#   * signup
type = "signup"

# price of the ticket
price = "0 EUR"

# link to the registration or ticket purchase page
link = "https://lu.ma/66o9s3m8"

# custom action button label
#button = "Join today¨

# status of registrations
#  Possible values:
#   * available
#   * sold-out
#   * closed
status = "available"

[links]
# the website of the event
# make sure to have all the relevant information: dates, venue, program, ticketing (if any), etc.
web = "https://example.org/"

# twitter account
twitter = "https://twitter.com/ExampleConf"

# public matrix channel
matrix = "https://matrix.to/#/!example:example.org"

# public telegram group
telegram = "https://t.me/example"

# docs
#docs = "https://example.org/docs"

# discord
discord = "https://discord.com/invite/AsDf1337"

Your event is live please double check if everything is correct :) https://blockchainweek.berlin/24

I modified the organizer "Chainlink, The Graph  and Deutsche Telekom¨
Could you update the event?

Updated the event. Please double check :)

Please chech the mistake.
The event is May 21th. In Blockchain Week website say May 20th.
https://blockchainweek.berlin/24

I guess we have a timezone issue I see it correctly.
Which timezone are you in? Can you please share some screenshots?


chore: remove v0.3.0-rc upgrades

Description
closes: #XXXX

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] added appropriate labels to the PR
[ ] targeted the correct branch
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eda6721) 16.10% compared to head (64d5cc8) 16.10%.

:exclamation: Current head 64d5cc8 differs from pull request most recent head ca58bf2. Consider uploading reports for the commit ca58bf2 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   16.10%   16.10%
=======================================
  Files          78       78
  Lines       18770    18770
=======================================
  Hits         3022     3022
  Misses      15595    15595
  Partials      153      153

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: add renderToString implementation

Adds a renderToString function just like the function from VTU for Vue 2.
It currently uses the same mount function, but checks if renderToString is true and uses the renderToString function from vue/server-renderer.
Sample usage:
it('returns correct html when onServerPrefetch is used', async () => {
  const Component = defineComponent({
    template: '
{{ text }}
',
    setup() {
      const text = ref('')

      onServerPrefetch(() => {
        return new Promise((resolve) => {
          setTimeout(() => {
            text.value = 'Text content'
            resolve(true)
          }, 100)
        })
      })

      onMounted(() => {
        text.value = 'Text content'
      })

      return { text }
    }
  })

  const wrapper = await renderToString(Component)

  expect(wrapper).toBe('
Text content
')
})

TODO:

More tests
Types

@lmiller1990  Yeah I think we probably need to move out the contents of mount to another function just like the createInstance here

Yep I agree. Happy to wait if you want to give this a try, I think it shouldn't be too bad - we have lots of tests to guide the refactor.

@lmiller1990 so I created a createInstance function, for now, that contains most of the mount function logic, then added a new renderToString function in another file. I copy-pasted their types and changed the return types for now.

Nice, this is looking good. I wonder if we can avoid the copy paste of the types, seems like a maintenance nightmare. I will give it a try sometime this week.

Sorry, I forgot about this. Will try to get some :eyes: on it soon.

Me either - and I don't have much bandwidth to look into SSR now, either.
I wonder if we just merge and release this under a patch to let people try it out?
@wobsoriano sorry I forgot about this PR -- happy to merge and release, just need a quick rebase and maybe a note in the docs about this API? At least we should document that this API exists maybe here. Not sure if you want to add some basic examples or an additional page in to the docs... I will leave that to you.

@lmiller1990 will research more about this and then finalize.

If you want to resolve the conflicts, happy to merge now and doc later - even just a one liner in the API section would be fine, just so people know it exists. You could also link to the SSR docs.

@wobsoriano Would you mind rebasing the PR please? We'll take a final look and merge

Closed in favor of #1971


I am getting  waring The next major release of the Firebase C++ SDK will drop support for C++11 and  my c++ version is c++ 20 standard

I am using latest firbase sdk in my project and I am getting following warning
"The next major release of the Firebase C++ SDK will "
"drop support for C++11, setting the new minimum C++ version to C++14."
My c++ version is  c++ 20 standard and firbase version is latest. I got build error as my compile settings treat waring as error. I am using visual studio 2022

I'm closing this issue, as these warnings have since been removed.
The Firebase 11.0.0 SDK has updated to use C++ 14.
There may have an issue where the warnings were shown even when not applicable, sorry for the inconvenience.


Display currently downloaded video length

Sometimes knowing how many KB or % of video has been downloaded just isn't enough, and you want to preview the video to check it's working, the right topic, the correct language, etc.  So you open the .part file with a video player, and skip through the video till you find a dialog or something.  If you skip too far away, the player will get stuck at the end or stop or do something weird, which isn't too nice.
It would be nice if youtube-dl displayed the length of the downloaded video, something like
[download]  11.8% of 4.06MiB at 207.41KiB/s ETA 00:17 (00:12/01:43)

The info of the total video length can be obtained through the %(duration)s parameter (when available), and the current downloaded length can be approximated using a simple rule of three.
Problem with this idea is that the duration parameter doesn't seem to get passed to the [download] routines at all, so this would probably involve modifying a bunch of protocols and modules in downloader/; maybe it's not trivial to do.

duration is now always available and may be incorrect. Video may be of variable bitrate so that it does not uniformly distirubted across timespan. For fragment based downloaders it would need to be extrapolated each on each fragment meaning that current timepoint and total time length of the video will jump like file size when downloading f4m or hls with native. So I can barely see any benefit in this since it would be too approximate.


adding action config

Description
Setting up GH action
Todos

[x] adding CI.yaml
[x] skipping tests that need GPU
[x] skipping tests that need CHARMM installation
[x] tests are passing

Status

[x] Ready to go

Codecov Report

Merging #36 (2a1eaa7) into master (20077d3) will decrease coverage by 3.09%.
The diff coverage is n/a.


[BugFix] enhance column pruning for query with predicates after mv rewrite

Why I'm doing:
the query with predicates may be rewritten by mv without a projection above scan node.
What I'm doing:
add a projection above scan node after query rewritten to reduce the size of data.
Fixes #45272
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[x] 3.2
[x] 3.1
[x] 3.0
[x] 2.5

ignore backport check: 2.5.22


Do not set evt.target attribute, if it's not defined yet

ol.events.EventTarget.dispatchEvent(event) sets event.target attribute in the headless way - the target can be already set in ol.events.Event https://github.com/openlayers/ol3/blob/master/src/ol/events/event.js#L38 and here it is overwritten without checking - it does not make sense IMHO.
This PR tries to solve the issue and make openlayers to behave more predictable.

Very good point, thanks @jachym. Do you think you'd be able to add a unit test that verifies the new, more predictable behaviour?

@ahocevar the second commit should do that

Thanks @jachym. Looking at the new test, I started wondering why ol.events.Event has an opt_target at all. It is not used anywhere except for a test. And since an ol.events.EventTarget dispatches an ol.Event, I find it quite unnatural that an event can override the target.
Out of curiosity, what made you stumble across this?

In our code, we use targets a lot and we are now upgrading from ol3 < 3.14 to 3.14 (and further) - the event model has changed, so we had to fix all our event-related code (about 400+ bugs) to openlayers event model. I'm in the middle of the process right now.
goog.events.Event preserved target attribute - ol.events.Event seemed to do the same .. at first sight.
I use the opt_target for any attribute, I need to pass to target event handler.
Not sure, whether I'm answering you question in a way, you are able to understand.

Thanks for the clarification @jachym. So you were clearly abusing the opt_target argument, because that was encouraged by goog.events.*. I'd be inclined to remove that argument entirely, but I'm unsure what implications this would have on your code. One option that comes to mind is that we add {type: string} as allowed type for ol.events.EventTarget#dispatchEvent, so you could pass an arbitrary object with a type property.

Well, it has zero implications to my code right now - need to fix it anyway and so, I'm going with custom classes with parent from ol.events.Event with custom attributes. Do as you need to do.

Only implication it has for me: it does not work as it was supposed to work ;-)

Ok, sorry for the trouble @jachym. I'll submit an alternative to this pull request then, removing the opt_target argument from the ol.events.Event constructor.


http_unescape() in GDScript can't unescape a string escaped by http_escape

Godot version:
v3.2.dev.custom_build.e6a0076f0
OS/device including version:
Linux Kubuntu 18.04
Issue description:
While updating the docs for http_unescape I found that String.http_unescape is broken in the following snippets of code.
Steps to reproduce:
var escaped = "https://example.org/?e="+"Godot Engine:'docs'".http_escape()
	print( escaped ) # Correctly encodes https://example.org/?e=Godot%20Engine%3A%27docs%27
	print( escaped.http_unescape() ) # Wrongly cuts output at 'Godot' ...
	print( "https://example.org/?e=Godot_Engine%3A%27docs%27".http_unescape() ) # Prints 'Unicode error: invalid skip'

Minimal reproduction project:
bug_http_unescape.zip

Couldn't reproduce the issue on latest master https://github.com/godotengine/godot/commit/1fa26b969c296ca62462debf01c22e2cc0aa059e on Windows 10 1903.

Isn't this how it should look?

@Anutrix yup that's indeed how it should look - here's output from a fresh build from 1fa26b9 on my Linux host:

So might be a Linux specific thing

Related to #30396.

@Anutrix I really don't think it's related

I can't reproduce this in current master with Ubuntu 18.04.
Output seems fine:
https://example.org/?e=Godot%20Engine%3A%27docs%27
https://example.org/?e=Godot Engine:'docs'
https://example.org/?e=Godot_Engine:'docs'

Strangely in 3bfffcc (things are moving fast! :sweat_smile: ) the output now has changed to giving the Invalid skip error on both unescapes:

Additional info:

It's not only in Godot's console output - but also in the terminal running the process.
I'm building using llvm/clang (command: scons platform=x11 use_llvm=yes -j5 platform=x11 tools=yes)

Test on gcc once.

I built 3bfffcc568d87342e867f95c35a4a19e09072189 with clang, but could not reproduce. Arch Linux, x86_64.

I can reproduce when building with clang:
clang --version
clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

but not with GCC. Weird...

I kinda had a hunch it was compiler related when I saw https://github.com/godotengine/godot/blob/56269e2db835e50a4cf2681bb73c44ae41fcca10/core/ustring.cpp#L3321-L3325.

I kinda had a hunch that it's compiler-related when I saw https://github.com/godotengine/godot/blob/56269e2db835e50a4cf2681bb73c44ae41fcca10/core/ustring.cpp#L3321-L3325

This was actually caused by passing a bogus argument to strtol (which apparently at least GCC fixed automatically knowing the array length)

Thanks for looking into it and fixing it!


Add rails default project

It is a normal project of rails with these small changes:

I added the configuration file to use azk with docker
I deleted some assets gems in the Gemfile, which are not necessary for an API
I deleted the folder assets

So we won't need assets in this project?
Then I guess we will be working just with the API here. Am I right?

Yes, exactly, this is what i had thought. Maybe it would be good idea to rename of this repo to turniquette-api, right?
Or you prefer a repo with all (app, API and webapp)?

I prefer separate repos as you intended to do.
:+1: about repo name change :-P
@TheTreeHouse/owners what do you think?

Yeah, I like it best. Separated repos for API & SPA, later we serve the SPA from the public folder. Or we may get some XSS problems..
Naming: turniquette-api & turniquette-client

Rename done! What do you think of PR?

When ok, I will make a single commit With squash and i will merge in master.
If you agree, and as extraordinary case, later I would like to do a rebase in master. To gather all this as 'Initial commit' and change the user, for not destruction the statistics with this rise in code.

:+1: to everything.

:+1: I recommend you motherfuckers install ZenHub. Is the coolest tool to +1

I agree with David, from now on, I will give my +1 with ZendHub :smile: i


Automate public file creation for plugins

A CLI interface to create plugins file.

This issue sounds interesting. Could please elaborate more about it.

Hey @SEETHAMRAJU,
Generally for creating plugins on Canvasboard, we create .ts files in the /plugins directory. You can automate this process by creating a file with a plugin initial template. These steps can be done interactively with the custom CLI commands which run a shell script to insert a file in the /plugins directory.
Few general Information is needed before creating a file via CLI:

filename
Template type

Note: When you create a file the import has to be automated in the new_board component.

Seems interesting. Can I work on this issue ?


FIX+ENH: fix miniconda installation + allow creation of multiple conda environments

Multiple conda environments can be created, but Miniconda is only installed right before the creation of the first environment. The folder /opt/conda is created and chmod'ed to 777 in every Docker image so that any user can create conda environments.

Codecov Report

Merging #58 into master will decrease coverage by 38.04%.
The diff coverage is 83.72%.

@@             Coverage Diff             @@
##           master      #58       +/-   ##
===========================================
- Coverage   84.85%   46.81%   -38.05%
===========================================
  Files          32       32
  Lines        1241     1254       +13
  Branches      106      108        +2
===========================================
- Hits         1053      587      -466
- Misses        153      634      +481
+ Partials       35       33        -2

Impacted Files
Coverage Δ

neurodocker/interfaces/tests/test_miniconda.py
100% <ø> (+53.84%)
:arrow_up:

neurodocker/neurodocker.py
22.78% <ø> (-67.09%)
:arrow_down:

neurodocker/utils.py
41.42% <0%> (-50%)
:arrow_down:

neurodocker/dockerfile.py
78.72% <100%> (-14.83%)
:arrow_down:

neurodocker/interfaces/miniconda.py
85.24% <85%> (-2.51%)
:arrow_down:

neurodocker/tests/test_neurodocker.py
16.27% <0%> (-83.73%)
:arrow_down:

neurodocker/tests/test_utils.py
22.5% <0%> (-77.5%)
:arrow_down:

neurodocker/tests/test_dockerfile.py
29.72% <0%> (-70.28%)
:arrow_down:

neurodocker/docker/tests/test_docker.py
30.66% <0%> (-69.34%)
:arrow_down:

neurodocker/tests/test_parser.py
35.29% <0%> (-64.71%)
:arrow_down:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808911f...3094013. Read the comment docs.

Fixes #55


Refactor Docker deployment

Replace the docker compose deployment with a single Dockerfile, and configure Actions to build on releases.
Use a minimal Dockerfile on the Hugging Face Space pointing to a released build on GHCR.

Addressed by #74.


Paid money to get star

What would you like to share?
Please don't do these tricks suchvas to Pay people for getting more stars on Repo.
Additional information
No response

Hi @ayushigeorge, we are unaware of any paid programs. This might be related to the issue that was posted by another community member: https://github.com/score-spec/score-helm/issues/18. Please let us know if you come across a similar form and we'll do our best to shut it down. Thank you.


podvm: Understand and reduce podvm permutations

At the moment we have a matrix of 4 possible options for podvm (mkosi/packer) x (cloud-init/process-user-data). We then multiple this by base OSs too (ubuntu/fedora/rhel) (we will ignore OS version at the moment on the assumption we can sync on that?) and cloud-providers that can support it and it explodes quite a lot and becomes complicated to understand and test
We want to reduce this, so we can minimise differences and duplicated code. One possible plan is:

Identify all the variants of podvm builds we have and track who is using what
Try and switch all podvm builds to use mkosi
Switch the CI to mkosi and then deprecate packer
Later investigate removing cloud-init and getting process-user-data to read the data from there if possible?

Part 1 Identify podvm builds
**Note: I think we decided a while ago that mkosi didn't work so well with ubuntu, so we wanted to switch to a fedora-like stack and deprecate the Ubuntu based podvm builds upstream?

Base OS
Architecture
Cloud provider(s)
mkosi/packer
cloud-init/process-user-data
Being used?
Notes

Ubuntu
amd64
aws
packer?
<cloud-init/process-user-data>
❓

Ubuntu
amd64
azure
packer?
<cloud-init/process-user-data>
❓

Ubuntu
amd64
docker
packer?
<cloud-init/process-user-data>
❓

Ubuntu
amd64
ibmcloud
packer
cloud-init?
✅

Ubuntu
amd64
libvirt
packer
cloud-init?
✅

Ubuntu
amd64
powervs
<mkosi/packer>
<cloud-init/process-user-data>
❓

Ubuntu
amd64
vsphere
packer
cloud-init
❓
Deprecate this?

Ubuntu
s390x
ibmcloud/libvirt
packer?
cloud-init?
✅

Fedora
amd64
aws
mkosi?
<cloud-init/process-user-data>
✅ ?

Fedora
amd64
azure
mkosi?
<cloud-init/process-user-data>
✅ ?

Fedora
amd64
docker
mkosi?
<cloud-init/process-user-data>
✅ ?

Fedora
amd64
ibmcloud
mkosi?
cloud-init?
❓

Fedora
amd64
libvirt
mkosi?
cloud-init?
❓

Fedora
amd64
powervs
mkosi/packer
<cloud-init/process-user-data>
❓

Fedora
amd64
vsphere
packer
cloud-init
❓
Deprecate this?

Fedora
s390x
ibmcloud/libvirt
<mkosi/packer>
cloud-init?
❓

RHEL
amd64
<cloud-provider(s)>
<mkosi/packer>
<cloud-init/process-user-data>
❓

RHEL
s390x
ibmcloud/libvirt
<mkosi/packer>
<cloud-init/process-user-data>
❓

did you mean "Any downstream testing?"
maybe we can have a "being tested" column
mkosi_x86_64 should work on both AWS + Azure.
Afaik all the packer images use cloud-init?

did you mean "Any downstream testing?"

From RHEL I meant testing of the upstream podvm build, but that testing itself could be manual testing, or testing in a downstream environment (as I'm pretty confident we don't have automated testing for RHEL). We have some documentation for it though. I hope that helps clarify?

maybe we can have a "being tested" column

Will do

mkosi_x86_64 should work on both AWS + Azure.

These are both using process-user-data I believe?

Afaik all the packer images use cloud-init?

did you mean "Any downstream testing?"

From RHEL I meant testing of the upstream podvm build, but that testing itself could be manual testing, or testing in a downstream environment (as I'm pretty confident we don't have automated testing for RHEL). We have some documentation for it though. I hope that helps clarify?

not quite :) I guess we have either (automated) testing in the project or potentially "downstream" (e.g a vendor product that uses CAA). One could argue that untested images, if they are consumed and tested downstream should also be maintained downstream?

These are both using process-user-data I believe and primarly fedora based in the upstream testing?

yes. I think we can just check for "cloud-init" yes/no. cloud-init will not work on dm-verity protected root-fs's. so we could also just check for dm-verity yes/no?

none of the mkosi image is being tested atm, afaict

amd64 azure packer image is being tested

not quite :) I guess we have either (automated) testing in the project or potentially "downstream" (e.g a vendor product that uses CAA). One could argue that untested images, if they are consumed and tested downstream should also be maintained downstream?

So the grey area that I was hinting at was for when pure upstream versions were tested internall. e.g. for ibmcloud, we tested the pure upstream version, but due to lack of publicly available resources those tests were done internally. I agree that if the versions are downstream then the downstream teams are responsible for maintenance (though we want to do our best to not break them, so it's potentially interesting). Sorry, I think I'm mostly overcomplicating an already complicated chart!

Part 2 - Identify To-Be of podvm builds
As the attempt to list out our "As-is" set of podvm images hasn't seemed to work, probably as it is too complex, maybe we should focus on out To-Be set and what we are aiming for in Step 2 of this work. My starting list of suggestions, based on quite a lot of ignorance is:

Base OS
Architecture
Cloud provider(s)
mkosi/packer
cloud-init/process-user-data
Being used?
Being tested?
Notes

Fedora
amd64
aws
mkosi
process-user-data
✅

Fedora
amd64
azure
mkosi
process-user-data
✅

Fedora
amd64
docker
mkosi
process-user-data
✅

Fedora
amd64
ibmcloud
mkosi
cloud-init
❓
❓

Fedora
amd64
libvirt
mkosi
cloud-init
❓
❓

Fedora
amd64
powervs
mkosi
<cloud-init/process-user-data>
❓

Fedora
s390x
ibmcloud
mkosi
cloud-init
❓
❓

Fedora
s390x
libvirt
mkosi
cloud-init
❓
❓

It would be good to understand where we are - particularly with libvirt and ibmcloud to understand what gaps we have in just trying out podvm builds.

Hi @stevenhorsman !
What if we have an entry for Ubuntu/amd64/libvirt/packer/cloud-init for a while mkosi equivalent isn't running on CI?

So I'm just trying to track and understand if anyone has already tried these combination above for, the short-term goals. It isn't designed to say that we will remove the Ubuntu builds until we have replacements. Ideally if/when someone confirms that Fedora/amd64/libvirt/mkosi/cloud-init works then, we'd start a parallel builds in our CI to create that version of podvms.

AFAIK RHEL is supported only by packer builds and for AWS, Azure and libvirt, and there's no upstream testing for RHEL


Update Dockerfile

Any chance of merging this? @odarriba

Hello,
I'm sorry, but seeing the changes I'm not really getting why python needs to be updated and the PR description/title is not clear. What´s the issue?
Also, there is an updated branch called smb which is updated for latest MacOS versions.
Have you tried it?

There's no more python package in alpine:latest. I've tried to rebuild the image yesterday, bumped into the issue.

Merging then! However, I encourage you to test the samba version, as will be default soon.

Actually, I turned to your repo when I had enough of samba-related problems and wanted to try netatalk ;)
And it worked like a charm for almost a year


Merge with serlo-editor-for-edusharing

Ready to be reviewed.
Changes

Use MariaDB docker image instead of Serlo MySQL image. Now, matching what Uberspace provides and we have a simple "health check" to check if database is ready in local development.
yarn dev:edusharing starts edu-sharing mock locally
lti_entity table in database will be automatically created if not found
Initial content in database is null. The editor code generates the initial content.
Available editor plugins is customized when launched by edu-sharing

Open subtasks:

[x] Test in Uberspace
[x] Provide template for .env

when running yarn dev I get unknown flag: --watch. What docker version are you running?

when running yarn dev I get unknown flag: --watch. What docker version are you running?

Currently, the minimum version seems to be 26.0.0

Templates for .env file are back.
I named them to follow common naming conventions. We now have:
.env.local.template
.env.uberspace.edtrdev.template
.env.uberspace.edtrstag.template
.env.uberspace.edtr.template

edtrdev, edtrstag, edtr reflect the asteroid names on Uberspace.
Let me know if you prefer different names @elbotho @hejtful @hugotiburtino

if that would be all envs that we have I'd prefer:
.env.local
.env.development
.env.staging
.env.production
But we might have more in the future, right?

Will we need more .env templates in the future? Good question. Not, sure. I think these will be all we need in the near future. The plan is to have only one production (& staging) deployment and use them for all integrations.


Optimize away EMBEDDING_VIEW predicate when correlated on "this"

Sometimes, it happens that we correlate on this and use EMBEDDING_VIEW inside a view. EMBEDDING_VIEW can be optimized away and thus allow using batching properly

Fixed by c89832311dcdb11d19915f60e22c2eb5f750fc4c


Trying saved password. All configured authentication methods failed

This ssh connect needs vpn.If i closed the connect,the saved password is not effective.But when i use the xshell,the saved password is effective,what happened？

I am experiencing the same issue on Windows 10, version 1.0.73. The first time I connect, I am prompted for a password. If I try connecting a second time I get the following:
Trying saved password...
All configured authentication methods failed

Same here.
Version: 1.0.73
Platform: win32 10.0.17134
Plugins: none

Please test with the latest release, thanks.

I have the same problem. I try with multiple ppk's


As an end-user, I want to know how long a certain input change took

Basically the duration a digital input was in a given state.
For the unipi setup, the debouncing is already handled at the lower HW level.
An interesting use case for this would be to use the duration to control a dimmer setting on a light.

This might not really be required since:

light switch: this is really only for the case where you would use it for light switches
unipi setup: it already has separate registers that hold and return this value -- no need to calculate it yourself.


Hyperlink in text Message body

I'm trying to utilise hyperlinks (i.e. a word that has an http link attributed to it) in both the sent and received text messages bubbles. As far as I can tell there doesn't seem to be any way to do this as as the "text" message element used to pass the message is an NSString and is therefore not attributable.
Are hyperlinks, i.e. a word that links/executes a url when it's tapped, in text messages possible? If so what would be the recommended approach?
Thanks,
Matt

The cells use UITextViews for their text handling, which supports URLs.
Just set the dataDetectorTypes on the cell's textView inside cellForRowAtIndexPath.

That would allow for URLs sent in the message but what about for hyperlinks, I.e. the word "github" would link to and open a predetermined (and attributed) page for example - github.com ?

@mattnuns you could look into a markdown parser library and achieve what you want

Thanks all!
The move to TTTAttributedLabel for the 8.0 release will enable this. Until then, clients will have to implement this themselves.


windows service uses log file location from config if none is given on commandline

Currently the windows service manager passes a log_location to the windows service at startup. Once the service is installed, this lof_location cannot be changed and overrides any log_location set in the client.rb. This PR allows a windows service to be installed with no log_location passed to the windows service. In such a case, the service will always use what is in the client.rb or the typical default path if none is configured.

:+1:

/cc @chef/client-windows

I basically rewrote the specs.

:+1:
Recommend updating the copyrights:
windows_service.rb + windows_service_manager.rb:
Copyright:: Copyright (c) 2011-2015 Chef Software, Inc.

windows_service_spec.rb:
Copyright:: Copyright (c) 2013, 2015 Chef Software, Inc.

updated copytrights


Removing domain restriction without being able to log in

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
I enabled domain restriction. After saving I got logged out and can't log back in because I have not verified my address. The server is unable to send emails and I'm unable to configure it to do so.
Is there a way to remove the domain restriction without being able to log in?
Exact BookStack Version
22.09
Log Content
No response
PHP Version
No response
Hosting Environment
Debian 10

Hi @moffitj,
No built-in way to disable this, but the follow commands, ran from your bookstack folder, should reset this setting to turn off domain restriction:
php artisan tinker --execute="setting()->put('registration-restrict', '')"
php artisan config:clear


Suggestion for supporting single header fields.

Motivation:
At the moment if you want to return a HTTP header containing multiple
values you have to set/add that header once with the values wanted. If
you used set/add with an array/iterable multiple HTTP header fields will
be returned in the response.
Note, that this is indeed a suggestion and additional work and tests
should be added. This is mainly to bring up a discussion.
Modifications:
Added a flag to specify that when multiple values exist for a single
HTTP header then add them as a comma separated string.
Result:
Allows for responses to be smaller.

@Scottmitch @trustin I've added support for add/addObject with a single value. I did not add any other methods (like addChar, addByte, addFloat, addLong, addInt) but perhaps I should?
There was a failure in my last commit (3e871fe) where a leak was reported. I'm happy to look into this more closely but just wanted to ask if you recognise it (I did a quick search but did not find anything recent)

@danbev - Welcome back and I Hope you enjoyed the break!  I'll take a look at your changes in a bit.

I did not add any other methods (like addChar, addByte, addFloat, addLong, addInt) but perhaps I should?

My initial thoughts...The add<PrimitiveType> methods all end up calling add(..) and so I don't think we have to override these.
I don't have much context/exposure to this code (looks like io.netty.handler.codec.compression.IntegrationTest.testEmpty) but this is the first I am seeing the leak you describe.  Based on the limited information I have seen so far I don't think it would be related to these changes.  Would you mind creating an issue with the information you have gathered thus far to investigate/fix?

@danbev - Done with another round.  Ping me when you are ready again.

@Scottmitch Thanks, hope you had a good christmas break as well!
I've create https://github.com/netty/netty/issues/3312 for the CI failure and will take a look at your comments later today. Thanks!

@danbev - Finished another round.  I think we are almost there.

@Scottmitch Thanks! Hope to be able to take them on today but might be Monday by the looks of my current task here.

@Scottmitch You you mind doing another round of reviews?

@danbev - Sure.  I'll take a look.

@danbev - I'm done...Back to you :)

@Scottmitch Thanks again! I've updated with two commits to address your latest comments.

@danbev - Finished another round.

We should also add a unit test that adds the same value again and check that the result is the same:
headers.add("foo", "some, value, with stuff ""); // this test can be repeated with other interesting inputs (i.e. empty, ",", """, etc...)
String value = headers.get("foo");
for (int i = 0; i < /some number/; ++i) {
headers.add("foo", value);
assertEquals(value, headers.get("foo"));
}

I'll have some time tomorrow and will take a look this and the other issues
you reported.
torsdag 15 januari 2015 skrev Scott Mitchell<EMAIL_ADDRESS>
We should also add a unit test that adds the same value again and check
that the result is the same:
headers.add("foo", "some, value, with stuff ""); // this test can be
repeated with other interesting inputs (i.e. empty, ",", """, etc...)
String value = headers.get("foo");
for (int i = 0; i < /some number/; ++i) {
headers.add("foo", value);
assertEquals(value, headers.get("foo"));
}
—
Reply to this email directly or view it on GitHub
https://github.com/netty/netty/pull/3271#issuecomment-70096483.

@Scottmitch Sorry about the delay on this. Still not happy with this but have run out of time today. Will revisit on Monday.

@danbev - No problem at all.  Keep up the good work.  Should I look again now, or wait?

@Scottmitch I've extracted the quoting of a quoteCsv method in StringUtil.
I've also updated DefaultTextHeaders to use the above method, and changed the naming from escape to quote where applicable.
Unless I'm mistaken, there is no escaping at the moment for values added using the default (multiple header fields) implementation. Should we leave this up to the developer to make sure that any values are escaped properly?
I'm still a little confused about the terminology here. I think your definitions above make sense, but when reading the javadocs you referred to they mention escape and not quote.

Unless I'm mistaken, there is no escaping at the moment for values added using the default (multiple header fields) implementation.

You are not mistaken.  There should be no escaping necessary because we are not forcing CSV, but instead separated by duplicating the header name with a new value.

I'm still a little confused about the terminology here. I think your definitions above make sense, but when reading the javadocs you referred to they mention escape and not quote.

I think we should use the escape terminology from an API perspective.  The quote operation is part of escaping for CSV.  The intention of providing the definitions was to distinguish the two operations and clarify their relationship.

@Scottmitch I've modified the escapeCsv method and it is followings what is done here.
Basically, if a CharSequence contains a comma character, a line feed character, carriage return character, or a double quote character, the whole CharSequence is enclosed in double quotes. In addition, if the CharSequence contained a double quote character it is escaped with a double quote character as described in RFC-4180. Is this what you had in mind when you wrote https://github.com/netty/netty/pull/3271#discussion_r23261233

@danbev - After we nail down the escapeCsv we should contribute an unescapeCsv method.  We can also discuss if it makes sense to modify the get* methods in SingleHeaderValuesComposer to use this method to unescape values.

@danbev - Back to you.  The escapeCsv method is looking good!

@danbev - Is this still on your radar?

@Scottmitch It is still on my radar. I've just not had time to revisit this. Will try to make some time for this later this afternoon (have been hoping to do so most of the week but other things have come up).

@Scottmitch I've add a commit for the issue you brought up in https://github.com/netty/netty/pull/3271#discussion_r23604716. Would you mind reviewing?

@danbev - Looking good, just 1 outstanding comment!  Can you address the build failure?
Does it make sense to cherry-pick this without the un-escape portion of this (csv-unescape and TextHeaders.get(..) methods which will unescape)?

@Scottmitch Absolutely, I'll rebase and run the test suite locally and sort out the build failure.

Does it make sense to cherry-pick this without the un-escape portion of this (csv-unescape and TextHeaders.get(..) methods which will unescape)?

Yeah, I think that would be fine. I'll add an issue for this so that it is not forgotten.

@danbev Great work, and thanks for sticking with this one.  Please reference this PR from your issue about un-escaping because I think that is key after introducing this functionality.  Are you planning on providing that functionality in the near term future? Feel free to cherry pick (into 4.1 and 5.0).

@Scottmitch Thanks for all the reviews!
I've create #3435 for the un-escaping. I hope to be able to handle this though time is running out (I go on parental leave on March 2nd) and I also have a few things at work that need finishing. I'll see how I manage and I'll un-assign it if I can't do it in time.

Cherry picked into 4.1 as c53b8d5a855468a890757b4f0612d7ae192a3592
Cherry picked into master as c6e88b00a3cc6cf438f74b1a9077191b660df711


 They increase the positive perception of the project at first sight. We have over 1k now but why not having 2k 😄
Description

expose asyncapi repo start on the website
Embed a view of number of start the project has on GitHub using https://buttons.github.io/ -> example https://kyma-project.io/

Not an enhancement or issue. Popularity is not a feature.

@orubel well it depends, presenting popularity on the website is website enhancement. Depends on the context 😄

Then define the spec for functionality in the application. Create the algorithm and service that will deliver 'popularity', debug, test and move to production.

dude this is staler than the dead baby in a zombies lower intestine. Let it die.

nah, I still believe in it ❤

then define it. Define the deliverables.

We can get some stars for repo
if you want

@hkaur008 I think title of this issue might be confusing 😄
Core problem: with new website, we removed any clearly visible references to GitHub. You need to scroll down to footer and locate github icon to actually get a link to AsyncAPI organization. This way we loosed an opportunity for asyncapi.com visitors to quickly navigate to the repository with specification and star it in case they are liking it.
Solution: at the top of the website, have some widget, some kind of display of number of starts on spec repo, so anybody can click it, be redirected to github and add star if they want. Examples:

https://prometheus.io/
https://knative.dev/docs/

Okay, we can put github in footer may be or a different panel at nav bar
On Mon, 30 Aug, 2021, 12:20 PM Lukasz Gornicki, @.***>
wrote:

@hkaur008 https://github.com/hkaur008 I think title of this issue might
be confusing 😄
Core problem: with new website, we removed any clearly visible references
to GitHub. You need to scroll down to footer and locate github icon to
actually get a link to AsyncAPI organization. This way we loosed an
opportunity for asyncapi.com visitors to quickly navigate to the
repository with specification and star it in case they are liking it.
Solution: at the top of the website, have some widget, some kind of
display of number of starts on spec repo, so anybody can click it, be
redirected to github and add star if they want. Examples:

https://prometheus.io/
https://knative.dev/docs/

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/asyncapi/website/issues/94#issuecomment-908078981,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANOWNVCE2QERZ5D3ROZAOG3T7MS2JANCNFSM4MQGPYXQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

definitely not footer 😅  somewhere at the top, where anybody can see it without scrolling

Yeah, top is better place  , you can add button may be then
On Mon, 30 Aug, 2021, 12:31 PM Lukasz Gornicki, @.***>
wrote:

definitely not footer 😅 somewhere at the top, where anybody can see it
without scrolling
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/asyncapi/website/issues/94#issuecomment-908084669,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANOWNVAUX76FBLVEKJXDXG3T7MUDJANCNFSM4MQGPYXQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

But if you dont want to do that we can have stars and contributors by other
things as well
On Mon, 30 Aug, 2021, 12:38 PM hargun kaur, @.***> wrote:

Yeah, top is better place  , you can add button may be then
On Mon, 30 Aug, 2021, 12:31 PM Lukasz Gornicki, @.***>
wrote:

definitely not footer 😅 somewhere at the top, where anybody can see it
without scrolling
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/asyncapi/website/issues/94#issuecomment-908084669,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANOWNVAUX76FBLVEKJXDXG3T7MUDJANCNFSM4MQGPYXQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

But i adding github would be a good way to get traffic from website over
repository  .
On Mon, 30 Aug, 2021, 12:39 PM hargun kaur, @.***> wrote:

But if you dont want to do that we can have stars and contributors by
other things as well
On Mon, 30 Aug, 2021, 12:38 PM hargun kaur, @.***> wrote:

Yeah, top is better place  , you can add button may be then
On Mon, 30 Aug, 2021, 12:31 PM Lukasz Gornicki, @.***>
wrote:

definitely not footer 😅 somewhere at the top, where anybody can see it
without scrolling
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/asyncapi/website/issues/94#issuecomment-908084669,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANOWNVAUX76FBLVEKJXDXG3T7MUDJANCNFSM4MQGPYXQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

But i adding github would be a good way to get traffic from website over
repository  .

exactly the goal. So even the issue talks about getting starts, it is just another way to properly link website with GitHub and make it clear it is not a business, it is a OSS project

Okay, now i get your point  , drawing a line between OSS project and
business
On Mon, 30 Aug, 2021, 12:55 PM Lukasz Gornicki, @.***>
wrote:

But i adding github would be a good way to get traffic from website over
repository .
exactly the goal. So even the issue talks about getting starts, it is just
another way to properly link website with GitHub and make it clear it is
not a business, it is a OSS project
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/asyncapi/website/issues/94#issuecomment-908102121,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANOWNVGVMIUGJ6UBDDGJE7TT7MXADANCNFSM4MQGPYXQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@hkaur008 @derberg you can add stars into the project like this.
https://buttons.github.io/
Maybe this in the nav?

this is definitely a good starter, long term would be nice to have some custom design like here https://knative.dev/docs/ but for that we would yeah, need some good design that fits the overall style of the website + a github action worklow that once a day rebuilds the website and fetches latest star count from the API

@hkaur008 @derberg you can add stars into the project like this.
https://buttons.github.io/
Maybe this in the nav?

This api wont help ? Why we need to re-render website

@hkaur008 it will help and it is a good solution for now. Just long term, better to have something that from UI perspective integrates well, like colors and all that stuff. And for that we need to re-render/re-build website and call the API once (we can refresh github star numbers just once a day, that is fine) otherwise we would quickly hit GH API limits for anonymous usage

@hkaur008 @derberg you can add stars into the project like this.
buttons.github.io
Maybe this in the nav?

This api wont help ? Why we need to re-render website

Yeah, I believe the JS will make a request to get the latest star count on load, works quite well.
As @derberg said, with that solution you cannot style it, but might be a good first go, then we can move to styling our own.

oh yes, and to confirm, for buttons.github.io rerendering of website is definitely not needed

I will see if I can add the star button from GitHub

#94 was added into master 👍, shall we keep this issue open or close it for now? @derberg

Awesome 🚀
I think we can close for now, thanks!

1% increase from implementation... this button can take all credit 🤣... probably not

Let us see in a couple of weeks, or even months


[serverless-1.33] Update Quarkus to latest RHBQ release

/cc @matejvasek @Kaustubh-pande @mgencur @matzew

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (serverless-1.33@4ab6599). Learn more about missing BASE report.

:exclamation: Current head 1b117a2 differs from pull request most recent head bc2dfa5
Please upload reports for the commit bc2dfa5 to get more accurate results.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                Coverage Diff                 @@
##             serverless-1.33     #780   +/-   ##
==================================================
  Coverage                   ?   48.97%
==================================================
  Files                      ?      125
  Lines                      ?    11471
  Branches                   ?        0
==================================================
  Hits                       ?     5618
  Misses                     ?     5166
  Partials                   ?      687

Flag
Coverage Δ

unit-tests-ubuntu-latest
48.97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


chore(master): release filsnap 0.2.0

:robot: I have created a release beep boop
0.2.0 (2023-07-21)
Features

add support for f4 and 0x addresses (c9be659)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/filecoin-project/filsnap/releases/tag/filsnap-v0.2.0 :sunflower:


Exception: The logical shard ID set in Redis is less than 1 or is greater than the supported maximum of 1023

Step1) Start redis-server on local machine
Step2) SET icicle-generator-logical-shard-id 123 (using redis-cli)
Step3) Run below code
JedisIcicle redisServerOne = new JedisIcicle("<IP_ADDRESS>:6379");
List<Redis> redises = Lists.newArrayList(redisServerOne);
RoundRobinRedisPool roundRobinRedisPool = new RoundRobinRedisPool(redises);
IcicleIdGenerator icicleIdGenerator = new IcicleIdGenerator(roundRobinRedisPool);
Optional<Id> idOptional = icicleIdGenerator.generateId();
System.out.println(idOptional.get().toString());

<dependency>
    <groupId>com.intenthq.icicle</groupId>
    <artifactId>icicle-jedis</artifactId>
    <exclusions>
        <exclusion>
            <groupId>com.google.guava</groupId>
            <artifactId>guava</artifactId>
        </exclusion>
        <exclusion>
            <groupId>redis.clients</groupId>
            <artifactId>jedis</artifactId>
        </exclusion>
        <exclusion>
            <groupId>org.slf4j</groupId>
            <artifactId>slf4j-simple</artifactId>
        </exclusion>
    </exclusions>
</dependency>

Note:
I already have latest version of excluded dependencies.
Exception:
The logical shard ID set in Redis is less than 1 or is greater than the supported maximum of 1023
Did I miss anything?

@vijayrawatsan You need to set the shard ID to a value as described in the README (which you've done). We can't automate this safely without risking collisions, so instead we take the approach that shard IDs must be set manually. Can you double check that SET call you did definitely worked and that doing a GET icicle-generator-logical-shard-id gives you back the 123 value you set?

@nathankleyn Thanks for the quick reply. Yep its working shard-id was removed due to some tests running in background.
Plus my original issue was due to java object serialization of value. My value was being saved as xac\xed\x00\x05t\x00\x03123
May be you could put it in FAQs :smile:


Show correct error messages in Request::Approval

I moved the config.blank? condition to the end of the method. It was preventing the other cases to fall first (e.g. github_pages), and therefore it is hard to debug some request issues.
Found this with @MariadeAnton

LGTM!


fix docker build for develop image(ISSUE-477)

Motivation
fix: https://github.com/kserve/modelmesh-serving/issues/477
@ckadner Could you please review this pr?

closed because it does not reproduce anymore.


UINavigationController's pop family

(closing #111 due to problems rebasing)
The current issue in this PR is:
All three methods return something. Right now that "something" is not passed to the observer, because it's different from the input.
e.g.:
rex_popToRootViewController :: MutableProperty<Bool?>
popToRootViewControllerAnimated returns a [UIViewController], but we have no way to provide this value for the observers.

I have an idea for a new object type, that could accommodate the input and the output. @neilpa @ikesyo  do you think it makes sense?

I feel like this kind of approach is really stretching what it means to expose a property, and where it makes sense to use this pattern.
This might be better expressed using some of the patterns suggested in
https://github.com/ReactiveCocoa/ReactiveSwift/pull/40, https://github.com/ReactiveCocoa/ReactiveSwift/pull/30, https://github.com/ReactiveCocoa/ReactiveSwift/pull/38, (and others, I'm sure) but even still I'm squeamish about using our binding operator for "making things happen" in addition to "streaming values from a source to a target."


Show the max quality and framerate (fps) on videos, which is live (stream).

Currently, there's an error displayed about quality of stream, which is live. Can be this fixed?

Probably. I haven't looked too much into how the live streams work.


Manually closing Popover

Description
Headless UI has a way to manually close a popover if say it has an action button inside it, but this doesn't seem to be implemented in .
Expected:
<template>
  <UPopover>
    <template #panel v-slot="{ close }">
    <UButton @click="accept(close)">Action</UButton>
    </template>
  </UPopover>
</template>

<script setup>
  async function accept(close) {
    await fetch('/accept-terms', { method: 'POST' })
    close()
  }
</script>

Additional context
No response

Have you checked this example? https://ui.nuxt.com/dev/overlays/popover#panel

That way doesn't seem to allow you to close it from a function if you need an action as well as the close.

Then have you tried the new open prop? https://ui.nuxt.com/dev/overlays/popover#manual
It's only available on the Edge but a release should happen today.


'xeus C++11' kernel not appear in the jupyter notebook menu.

Hi,
I installed the xeus-cling followed by the instruction of following:
conda create -n cling
source activate cling

conda install cling -c QuantStack -c conda-forge
conda install xeus-cling -c QuantStack -c conda-forge
conda install notebook -c conda-forge

But the 'xeus C++11' kernel does not appear in the jupyter notebook menu.
Here is some debug informations:
(cling) root@7bac7e6baf53:/notebooks# which jupyter
/root/miniconda3/bin/jupyter
(cling) root@7bac7e6baf53:/notebooks# ll /root/miniconda3/envs/cling/share/jupyter/kernels/
total 16
drwxr-xr-x 4 root root 4096 Feb  1 22:45 ./
drwxr-xr-x 4 root root 4096 Feb  1 22:45 ../
drwxr-xr-x 2 root root 4096 Feb  1 22:45 xeus-cling-cpp11/
drwxr-xr-x 2 root root 4096 Feb  1 22:45 xeus-cling-cpp14/

Can anyone tell me why?
Thanks very much!

More info:
root@7bac7e6baf53:~/.jupyter# jupyter kernelspec list
Available kernels:
  python3    /root/miniconda3/share/jupyter/kernels/python3
  python2    /usr/local/share/jupyter/kernels/python2
root@7bac7e6baf53:~/.jupyter# which jupyter
/root/miniconda3/bin/jupyter
root@7bac7e6baf53:~/.jupyter# source activate cling
(cling) root@7bac7e6baf53:~/.jupyter# which jupyter
/root/miniconda3/bin/jupyter
(cling) root@7bac7e6baf53:~/.jupyter# jupyter kernelspec list
Available kernels:
  python3    /root/miniconda3/share/jupyter/kernels/python3
  python2    /usr/local/share/jupyter/kernels/python2
(cling) root@7bac7e6baf53:~/.jupyter#

The kernel specs appear to be installed in cling environment. Can you try launching notebook from an activated cling environment?

I also have a question about your installation: why did you install miniconda with the root user and not in your home directory ?

It's the same. I think it is because there is a jupyter notebook on my system before install conda. I am going to install on a clear docker image. I will feedback later. Thanks.

I reinstalled on ubuntu and centos docker image but meet the error: "post-link script failed for package QuantStack::gcc-7-7.2.0-1".
I finally installed on MAC os and it run.

The post-link issue is something that has been reported earlier and which we are not reproducing locally.
In fact we only depend on gcc's STL so we should remove the faulty postlink check fron the recipe as a workaround.

Dear @SylvainCorlay, I'm facing this post-link issue while trying to deploy a xtensor notebook from quantstack repo using mybinder.org. In order to reproduce it, one could deploy a new jupyter server for xtensor repo through mybinder.org. I hope this may help in reproducing the post-link issue.

@aforechi I am not sure I understand. Do you have a local deployment of mybinder ?

No. I refer to https://mybinder.org. There one can easily deploy jupyter notebook servers just by filling a form with a github repo such as for xtensor. By doing so we'll get the following link. Following the link you can read the post-link error messages.

Ok gotcha.
We provide a binder link in the README (both as a badge and later with the
binder logo) which are functional.
I am AFK at the moment but will check the logs later.
S.
On Mon, May 14, 2018, 21:49 aforechi<EMAIL_ADDRESS>wrote:

No. I refer to https://mybinder.org. There one can easily deploy jupyter
notebook servers just by filling a form with a github repo such as for
xtensor. By doing so we'll get the following link
https://mybinder.org/v2/gh/QuantStack/xtensor/master?filepath=notebooks/xtensor.ipynb.
Following the link you can read the post-link error messages.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/QuantStack/xeus-cling/issues/104#issuecomment-388923295,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACSXFtJG0DtyPJMsY0Tz6noQCzk21vmpks5tydHWgaJpZM4R4HHA
.

Great @SylvainCorlay! Actually, I'm facing the same issue but with my own repo, which I use for teaching C++ programming. I must thank you all at QuantStack for making this more interesting! I referred earlier to the xtensor repo because the issue might be correlated. Cheers!

This issue happens when the default gcc compiler is too old.
Could you try to install the last gcc compiler by using the apt.txt file in
binder and see if the problem is solved?
Le lun. 14 mai 2018 à 22:00, aforechi<EMAIL_ADDRESS>a écrit :

Great @SylvainCorlay https://github.com/SylvainCorlay! Actually, I'm
facing the same issue but with my own repo
https://github.com/aforechi/ifes-cpp, which I use for teaching C++
programming. I must thank you all at QuantStack for making this more
interesting! I referred earlier to the xtensor repo because the issue might
be correlated. Cheers!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/QuantStack/xeus-cling/issues/104#issuecomment-388943306,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHKaFeYmvB4CkZiJOa90pf5jDRmV2Merks5tyeJMgaJpZM4R4HHA
.

@aforechi OK, I think I might have a fix. Stay tuned.

This is fixed now!
I am closing the issue but don't hesitate to comment here should you have the issue again and I will reopen.

I do not see any C++ options when running jupyter-notebook with google chrome.  Everything seems to work.  I activate the (xeus-cling) environment and launch jupyter-notebook.
conda 4.6.8
Linux 4.19.0-2-amd64 #1 SMP Debian 4.19.16-1 (2019-01-17) x86_64 GNU/Linux
binutils_impl_linux-64    2.31.1               h6176602_1
binutils_linux-64         2.31.1               h6176602_3
clang_variant             1.0               cling_6.14.06    conda-forge
clangdev                  5.0.0             h935a590_1004    conda-forge
cling                     0.5               he860b03_1006    conda-forge
cppzmq                    4.3.0             h484f380_1000    conda-forge
cryptopp                  7.0.0             hf484d3e_1003    conda-forge
gcc_impl_linux-64         7.3.0                habb00fd_1    conda-forge
gcc_linux-64              7.3.0                h553295d_3    conda-forge
gxx_impl_linux-64         7.3.0                hdf63c60_1    conda-forge
gxx_linux-64              7.3.0                h553295d_3    conda-forge
libgcc-ng                 8.2.0                hdf63c60_1
libsodium                 1.0.16            h14c3975_1001    conda-forge
libstdcxx-ng              8.2.0                hdf63c60_1
libuuid                   2.32.1            h14c3975_1000    conda-forge
nlohmann_json             3.4.0                hf484d3e_0    conda-forge
xeus                      0.18.1            h6e680fc_1000    conda-forge
xeus-cling                0.4.11               he860b03_0    conda-forge
xtl                       0.5.4                h6bb024c_0    conda-forge
zeromq                    4.2.5             hf484d3e_1006    conda-forge
zlib                      1.2.11            h14c3975_1004    conda-forge

Hi.
Could this issue not be closed until we know at least which version of gcc must be installed?
If that is indeed the issue - and not "I installed jupyter before I installed conda" if that is the issue?
By the way The "I installed jupyter" issue stems from having met some people who wanted to use Jupyter without using conda. And if that is the issue, then it would be good to inform people about this.
Thanks!
Thanks


use TAP instead of custom outputs

At first I was going to say you should support NO_COLOR https://no-color.org/
Was going to ask if colors are even worth it given above
Then I remembered the whole thing is already solved, output tap with tapzero then maybe ship https://github.com/architect/tap-arc if you want to pipe it into a formatted thing

https://github.com/ricobank/snek/blob/f7763cd40ed34d3cc52ccd30673574e192df4453/src/runner.js#L37-L54
    for ([contract_name, contract] of tst_contracts) {
        const iface = new ethers.utils.Interface(contract.abi)
        const factory = new ethers.ContractFactory(iface, contract.evm.bytecode.object, signer)
        const test = await factory.deploy(snek.address)
        for (const func of contract.abi) {
            if ('name' in func && func.name.startsWith('test')) {
                test(func.name, t=> { // test
                  try {
                      await send(test[func.name])
                      t.ok(true, `${contract_name}:: etc`)  // maybe t.pass(str) I forgot
                  } catch (e) {
                      t.fail(e)
                  }
                } //  test
            }
        }
    }

Starting on this now


Random notification saying I have a new message.

I also got one of these on alpha 1 although haven’t checked the second one, as I disabled background app refresh.

That has been removed, it was some test code


Ship a README with packages

Currently, we ship a .env file as well as the package contents.
The README should contain:

A description of the package
Instructions on how to source the .env file
Any z/OS extensions that need to be highlighted
Known issues

We can extend zopen-build to pick up the README.md from the repo.
Anything else?
FYI @MikeFultonDev

Related starter PR for this: https://github.com/ZOSOpenTools/utils/pull/110/files


fix: Prevent Integration environment variables ordering randomization

Fixes #2188.
Release Note
fix: Prevent Integration environment variables ordering randomization

May this fix the yaks tests in other PRs (this one seems hitting another error).
I see that YAKS failing to get the pod is due to knative creating two revisions of the same integration, with one of them disappearing after the timeout.


Thank you!

Comment:
Hi! I'm from the go-sqlcmd project and this is very cool to see.  I was curious if you could share how you or others are using go-sqlcmd when it's installed through conda.

Hi @dzsquared :wave:
We use mamba to install all of our analytics (Python/R) code and insofar as possible I try to install all my tooling using mamba as well.
It's easier keeping things up to date if you only have to worry about using one package manager - e.g. I can tell my team to just install stanwell-devops and know they'll have everything they need for deploying our infrastructure:
outputs:
  - name: stanwell-devops
    requirements:
      run:
        - go-sqlcmd >=0.7.0
        - terraform >=1.1.4
        - terragrunt >=0.36.0
        - kubernetes >=1.23.3,<1.25
        - kubelogin >=0.0.10
        - kubernetes-helm >=3.8.0
        - minikube >=1.24.0
        - packer >=1.7.9

We're using go-sqlcmd as part of our automatic deployment of Azure SQL databases using terraform. When a new database is provisioned, AD groups for access are also provisioned. We then use go-sqlcmd (via null resources) to create the corresponding users in the database and assign them corresponsing roles (via sp_addrolemember).
Anyway, I didn't have any luck connecting to our Azure SQL databases using sqlcmd so fortunately I found go-sqlcmd which Just Worked! :tada: It's also hugely easier (and licensing is clearer) deploying go-sqlcmd in our CI/CD containers that it would have been with sqlcmd.
Note:
I install tooling into my base environment which is on my PATH (which may or may not be questionable practice). condax is a tool specifically designed to install applications in isolated environments.

NB: If you or any other contributor would like to be added as a maintainer here I'd be happy to add you. The process is you just open an issue here with the title:
@conda-forge-admin, please add user @username

...and the bot will open a PR to add @username which I can then merge.

https://conda-forge.org/docs/maintainer/infrastructure.html#conda-forge-admin-please-add-user-username


fix swift cli exit code if subprocess is failed

PR type

[x] Bug Fix
[ ] New Feature
[ ] Document Updates
[ ] More Models or Datasets Support

PR information
Job executed on remote machine relies on the exit code of the command to determine if the job is successful or a failure. Currently, the swift cli always returns an exit code of 0, which leads to a situation where even if the training job actually fails, it is still considered successful at the job level.
Experiment results
before

current PR branc test result:

Hello~ Thank you for your code. Please pass the lint test.
https://github.com/modelscope/swift/blob/main/CONTRIBUTING_CN.md#代码规范和开发方式


Self Issued Credentials

Feature Request: Issue credentials to myself (holder=my wallet, subject=my public did).
The BPA allows to issue Credentials to Partners once the connection is established. But there are Use Cases where I would like to issue credentials to myself.
I can Use the Wallet to "create a document" using one of my schemas (what does that actually mean? is there a self-signed VC being created in the wallet? Apparently I do not need a credential definition, so this seems to be just a BPA internal "document"?).
But I can not send a presentation of such a "document" to a business partner.

Documents are currently only used as a basis to get verifications (verifiable credentials) from third parties or to be included in the public profile. In the public profile they are signed as part of the verifiable presentation, but are not represented as an AnonCred.
We would like to support the use case to send presentations based on the document to a partner or answer presentation requests with the documents. However, I'm not a fan of issuing an AnonCred to myself and that everyone needs CredDefs on the ledger for self-signed VCs.
We could support adding attributes from documents as self-attested attributes to presentations, but this does not allow to convey the information that the attribute should be understood in the context of a specific schema.
One of the next items on our roadmap is the support of issue-credential-v2 and present-proof-v2 with DIF presentation exchange and JSON-LD VCs. We'll take your feature request in account there and I think these tools will a better solution.

On a side note. You could try adding yourself as a business partner, write a cred def and  request a verification from yourself.

Ahh, awesome, many thanks.
I did not know that I could add myself as a business partner. This solves my use case for now. Should I close the issue? If you also want to enable self-issued credentials through a more intuitive UI path in the context of JSON-LD credentials feel free to keep it.


Provide easy access to Edit/Delete option for snippets.

Edit and delete options for existing snippets should be button options displayed next to each snippet rather than requiring a selection checkbox and scrolling to the bottom of the screen for dropdown box selection and clicking Go. Or you can replicate the dropdown box and Go at the top of the table but preference is for buttons next to the snippet itself.

The reason it was done this way, was to let the user edit multiple snippets at the same time. It would no longer be possible to do this with your proposed enhancement. Probably not a huge deal though.
Pull request welcome.

I understand the need to delete multiple snippets at a time but can't see a need to edit multiple snippets at the same time. thx.


Why use pkg/cloudevents dir?

Hi, @n3wscott
why use sdk-go/pkg/cloudevents/* dir not sdk/go/*? what's the good? thanks!

I am following standard strongly structured golang packages with cmd, pkg, hack, etc...
I add alias.go to the root so you can use http clients directly.

@n3wscott OK, thanks!

I thought about this more and you are right. there is no reason to have a cloudevents directory inside of pkg.
Let's clear the PR backlog and fix this. Thanks for the question.

If interface un-export, maybe we should put internal dir.

@n3wscott I'm happy to handle this. I'll submit a PR in the coming days.

This was addressed in v2 of the sdk


:vsplit and :edit a folder doesn't work

Hi,
I have been trying nnn for the past few days as an alternative to the existing tree plugins and netrw.
Thanks for all your hard work!
Something that I tend to do a lot is to use :vsplit and have multiple buffers side by side.
If I run :vsplit and after that, I try to edit a folder on the new buffer :e /some-folder/ nnn is triggered but any selection from the nnn will throw out an error when in explorer mode and it silently fails in picker mode.
Picker mode:
https://asciinema.org/a/wAiGWbpjmutXfbx8mgKKlEwey
I open a :vsplit, that it's closed by nnn when I :edit a folder and when I pick a different file init.vim nothing happens
Explorer mode 1:
https://asciinema.org/a/wAiGWbpjmutXfbx8mgKKlEwey
I have nnn tree open. I open a :vsplit  and then :edit a folder. nnn closes/toggles the current explorer
Explorer mode 2:
https://asciinema.org/a/wAiGWbpjmutXfbx8mgKKlEwey
I close nnn, I do a vsplit. Inside the vsplit I do a edit of a folder. This closes the vsplit and opens the explorer. I then try to open a file init.vim and it shows an error.
The error is:
Error executing vim.schedule lua callback: ...l/share/nvim/site/pack/packer/start/nnn.nvim/lua/nnn.lua:101: Invalid window id: 1002
stack traceback:
        [C]: in function 'nvim_set_current_win'
        ...l/share/nvim/site/pack/packer/start/nnn.nvim/lua/nnn.lua:101: in function 'handle_files'
        ...l/share/nvim/site/pack/packer/start/nnn.nvim/lua/nnn.lua:130: in function <...l/share/nvim/site/pack/packer/start/nnn.nvim/lua/nnn.lua:129>

I guess that the issue is that I have nnn replacing netrw. When using  :e netrw would open on the new buffer and the selection after would replace netrw.

Should be fixed in https://github.com/luukvbaal/nnn.nvim/commit/35c6e190086350e77fd6ae2644f91bcc2b61407a, please confirm.

I can confirm that it's working. You rock! thanks for all the hard work.


chore: Optimize kubebuilder validation

Optimize kubebuilder validation

seems we should also update generated CRDs yaml after this is merged?

seems we should also update generated CRDs yaml after this is merged?

Yes. Add option validation.

Hi, please split it into two commits, one for auto-generation and one for your optimization.

Hi, please split it into two commits, one for auto-generation and one for your optimization.

auto-generation code in pkg/client/*, and optimize code in pkg/apis/*

Thanks @Monokaix  Please re-check it. 😄

/lgtm

Please fire another pr in volcano repo and update the code to generate new yaml: )


Merge master branch to prTesting1_202011011931 branch

Docs Build status updates of commit cbc9aaf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


As a user, I want to to be able to distinguish background traits from directly associated traits

Some traits in the Catalog are represented by multiple EFOs, where one trait is the trait associated with the genotype, and the other in a trait shared by all individuals in the population, eg "coronary artery disease in diabetes", annotated with EFO terms for "coronary artery disease" and "diabetes mellitus". The current UI search treats all EFO terms the same, so that a search for "diabetes" returns associations with "coronary artery disease in diabetes". This provides misleading information for users.
Several changes need to be made to allow users to distinguish background traits from main traits.

Split out background traits from main traits in the database
Re-focus the search UI to allow exclusion of background traits from search results

more information is here:
https://drive.google.com/drive/folders/1PnXZuMTbTttQvc0QkTLiw7KIIFH4qN1j?usp=sharing

in roadmap due April

in roadmap due April


ViewStub

Calligraphy does not change font in the layout that is inflated by ViewStub.
CalligraphySample with ViewStub:
https://github.com/illarionov/Calligraphy/commit/eed3f9eaefb10500c57b4ee3c6af09c5b9bb894b

@orrc this is working for me in the 2.0.0-SNAPSHOT

Yeah, seems to work in the latest snapshot on maven central, thanks.

Nuice thanks! :D
On Fri Jan 16 2015 at 1:14:27 PM Christopher Orr<EMAIL_ADDRESS>wrote:

Yeah, seems to work in the latest snapshot on maven central, thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/chrisjenx/Calligraphy/issues/97#issuecomment-70251589
.

Now I just had a crash
android.view.InflateException: Binary XML file line #65: Error inflating class
at android.view.LayoutInflater.createView(LayoutInflater.java:633)
at uk.co.chrisjenx.calligraphy.CalligraphyLayoutInflater.onCreateView(CalligraphyLayoutInflater.java:162)
at android.view.LayoutInflater.onCreateView(LayoutInflater.java:682)
at uk.co.chrisjenx.calligraphy.CalligraphyLayoutInflater.onCreateView(CalligraphyLayoutInflater.java:146)
at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:741)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:806)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:809)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:809)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:809)
at android.view.LayoutInflater.inflate(LayoutInflater.java:504)
at uk.co.chrisjenx.calligraphy.CalligraphyLayoutInflater.inflate(CalligraphyLayoutInflater.java:60)
at android.view.LayoutInflater.inflate(LayoutInflater.java:414)
while inflating a view. 65th line is a viewstub

Your inner view you are creating has a broken constructor

I don't have a constuctor. It's a default ViewStub

@n-belokopytov 1. check you are using 2.1.+ and 2 check that this actually works with Calligraphy disabled. There is nothing in that stacktrace that points to Calligraphy, those kind of issues are related to a broken view.

Works on Calligraphy 2.1.0, thanks!


Enable ITKIOTransformMINC

As SimpleITK is expected to be on the last RC before 2.0, this patch enables a new ITK Module which may lead to unexpected issues this PR will be merged after the 2.0 release for 2.1


Cleanup without land (similar to close?)

Our repo uses a merge queue to squash and merge all PRs into main and release branches. The way that it is implemented is that after a PR passes all checks and gets code reviewed, a PR author can apply a label to their PR that instructs a github action to merge it into main. This github action will maintain a queue of PRs that want to be merged, and they all need to re-run CI against tip of main before the merge happens. This is to prevent two PRs that don't play nice together from landing and breaking main.
The problem with this approach is that we do not have a way to cleanup the branches that spr creates. I'm not sure if this is something spr land automatically does or not, but we can't run spr land since only the merge queue (and those with special privileges) can merge directly to main.
This would probably be similar to spr close, except the PR is already going to be squashed and merged at this point. I haven't tested using spr close on an already merged PR because I don't know what it will do.

I feel like close should be able to handle this.

Sorry, I'm a little confused by your comment. Do you mean "as is" or with some kind of special flag, "--cleanupBranchesIfAlreadyClosed"? Because spr close tries to actually close the PR, and if it is already merged, it will fail without cleaning up any branches (this is relevant for stacked PRs)

Sorry, to clarify - I think that if you invoke spr close and the PR is closed, but the branches exist they should be deleted. No special flags needed. I agree that it doesn't do that today, but it should.