'ModelPatcher' object has no attribute 'get_model_object'

Error occurred when executing ApplyInstantIDAdvanced:
'ModelPatcher' object has no attribute 'get_model_object'
I have verified my installation steps and confirmed that all required libraries and models have been correctly placed in the designated directories. I have also ensured that my ComfyUI is up to date, and all dependent libraries are at their latest versions.

update this extension and comfyUI, they don't appear to be actually updated

Came to report the same (had updated via manager.)  It seems @cubiq is correct, manual git pull of comfyui fixed the issue.

yes，I have now updated everything to the latest versions and am currently testing the application.
If I encounter any further problems or have additional questions, I will not hesitate to reach out again for assistance.


Pressing Start on the Taskbar causes a Crash

Version: Just pulled it off of this Repo
Pretty much self-explanatory, clicked Start on New Taskbar = Crash

oh :b:rap

Hmmm works for me. I'll implement some sort of a crash logging soon:tm: so we can look into exactly what is causing this

If it helps, it was in Safe Mode when this happened

UPDATE 2: It does it on Normal Windows 7 Boot:
InstalledTransientModules[0].HandleCommand(command);
............................................ ^ System.ArgumentOutOfRangeException

"Index was out of range. Must be non-negative and less than the size of collection."
File: IModule.cs

Hmmm... do you have both of the modules installed in %appdata%\Start9\Modules?

Oh... that might be the issue. :man_facepalming:

Erm, is that Start9/Modules/*, or module files in the Modules folder?

...with them as Modules/TestFixedModule and Modules/TestTransientModule, it still throws an exception

So you have these files?

TestFixed: Yes
TestTransient: No

Ahh that's the problem. The start button is TestTransient

Can I have a copy of TestTransient over Discord DMs?

Sure

Fixed over TeamViewer (so others would have to ask Reflectron about how he fixed my one)...

Alright, we looked into the issue and it seems like it's a simple fix:
Firstly, feren did not have the TestTransientModule [this is the Start Menu]. Thus the InstalledTransientModules collection was empty.
This fixed that issue - however, another issue cropped up. Code Access Security (CAS) policy does not trust assemblies downloaded from the internet, and when they are loaded NotSupportedException is thrown. To remedy this, an app.exe.config file must be included with the following contents:
<configuration>
   <runtime>
      <loadFromRemoteSources enabled="true"/>
   </runtime>
</configuration>

This allows assemblies from remote sources (downloaded from the net, etc.) to be loaded. I will update the build settings for the Start9 project to include an app.exe.config enabling loadFromRemoteSources in a future commit.


Less colors saturated

Subject of the issue
The colors primary and secondary of the dark/light theme are equals. In mode dark, these colors more become saturated colors and vibrant. Check here.
Possible Solution
Change colors primary and secondary for less colors saturated.
My suggestion  PR

fix: https://github.com/ResultadosDigitais/matrix/pull/355


There are always errors in OSX following Installing procedure

Choose an option
This is a:

[x] Question

Describe the issue
When coming to the Installing Flow and SUMO, after downloading SUMO’s github directory, something goes wrong and I cannot figure it out.
I input the code into terminal
export CPPFLAGS=-I/opt/X11/include
export LDFLAGS=-L/opt/X11/lib
./configure CXX=clang++ CXXFLAGS="-stdlib=libc++ -std=gnu++11" --with-xerces=/usr/local --with-proj-gdal=/usr/local
make -j$nproc
But I got
MacBook-Pro-3:sumo mac$ make -j$nproc
make: *** No targets specified and no makefile found.  Stop.
I have tried many times and dont know why

@CYBruce sorry to hear about this! I'm guessing something went wrong in the ./configure line; could you post the output for this?
Additionally, we've added some instructions to make the installation process way easier!
You can take a look at: https://flow.readthedocs.io/en/latest/flow_setup.html#e-easy-install-sumo-optional
for a hopefully much simpler process.

I tried this easier method, but still have errors. I cannot make SUMO work.
terminal_rec.txt

By the way, I tried the (e). Easy Install SUMO, and I got this.
Installing sumo binaries
~/sumo_binaries/bin ~/flow
scripts/setup_sumo_osx.sh: line 11: wget: command not found
tar: Error opening archive: Failed to open 'binaries-mac.tar.xz'
rm: binaries-mac.tar.xz: No such file or directory
chmod: *: No such file or directory

Of course; happy to help. The issue here is that you don't have wget.
Can you try first installing homebrew from this link: https://brew.sh/
Then run brew install wget and then repeat the easy setup procedure? I think this will resolve your problems.

@eugenevinitsky Thank you for your kindly help! I fixed the problem and installed sumo_binary. However, when I tried to install sumo (I install all the needed libraries)
export CPPFLAGS=-I/opt/X11/include
export LDFLAGS=-L/opt/X11/lib
./configure CXX=clang++ CXXFLAGS="-stdlib=libc++ -std=gnu++11" --with-xerces=/usr/local --with-proj-gdal=/usr/local  They work correctly.
Unfortunately, make -j$nproc gives an error

clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[3]: *** [marouter] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all] Error 2
make: *** [all-recursive] Error 1

Hi @CYBruce if you install the binaries, you can skip the sumo install step! You already have the binaries so everything should work as is. Highly recommended that you do this.
However, if you do want to go forward and actually do the compilation, happy to help with that as well. Unfortunately, to debug this I need the full output of make -j$nproc as the actual error is much further up in the output.

Wow, that's cool! Thank you for your help!

Great! Are you able to get any of the examples to work?

when i input sumo-gui
it returnsFXApp::openDisplay: unable to open display /private/tmp/com.apple.launchd.uA1b5HgRU2/org.macosforge.xquartz:0
and i input python: can't open file 'examples/rllib/stabilizing_the_ring.py': [Errno 2] No such file or directory
Now i'm trying to find answer online

Okay; so as to the former make sure you've closed and opened XQuartz; that's probably all that is.
As for the latter, what directory are you running it from? I'm guessing you're running it from a directory where the path to sugiyama.py is not examples/sumo/sugiyama.py

I solved the latter one, but the former problem.......
I am still trying, it seems closing and opening dont work

You may have to restart your computer if you've installed XQuartz for the first time.

Finally!!!
I will do some experiments in the next stage!

So glad to hear it! I'm closing this issue for now then but let us know if anything else comes up. Excited to see what you build with Flow!

Of course; happy to help. The issue here is that you don't have wget.
Can you try first installing homebrew from this link: https://brew.sh/
Then run brew install wget and then repeat the easy setup procedure? I think this will resolve your problems.

Now I installed the wget.
But I still get that question.
Why? Please help


Support Operator Lifecycle Manager (OLM) registry+v1 bundles

Describe the problem/challenge you have
The Operator Lifecycle Manager (OLM) is a project that aims to simplify lifecycle management of Kubernetes-native applications ("operators") and provide additional guardrails to prevent actions that can unintentionally or accidentally result in misconfigurations or data loss.
There is a large collection of operators that work with OLM. Many are viewable at https://operatorhub.io. OLM has a custom packaging format called registry+v1 that is an OCI image with a specific directory layout that OLM expects.
We are currently investigating using parts of the Carvel suite in our next major version of OLM, "v1", currently in development. kapp-controller is of particular interest. We'd like to use it to manage the content OLM applies to clusters, but kapp-controller doesn't currently support OLM's registry+v1 format.
Describe the solution you'd like
Add support for OLM's registry+v1 format as a "templating" step. This would take the contents of a .spec.fetch.image that points at an OLM registry+v1 image and process them in such a way that the .spec.deploy.kapp step can apply them to the cluster correctly.
Anything else you would like to add:
[Additional information that will assist in solving the issue.]

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

@joaopapereira @praveenrewar
Please triage this.

Proposal to discuss the intended changes: https://docs.google.com/document/d/1ROxnv0ttzDGgjI_fIzdQAg0tcoefdcjVwpdM6LZyknE/edit


Removed setting the 'auto_migrate' global variable

https://github.com/deployphp/deployer/issues/310

Thanks!


scm collector not collecting pull request and issues data Also It appends bucket.org in the url when passed like<EMAIL_ADDRESS>

Hi ,
I am configuring collector for bitbucket cloud, I am able to get commits for branch but not the pull request and issues.
Here is my appllication.properties
dbname=dashboarddb
dbhost=localhost
dbport=27017
dbusername=dashboarduser
dbpassword=dbpassword
logging.file=./logs/bitbucket.log
git.cron=0 0/5 * * * *
git.host=api.bitbucket.org/
git.api=/api/2.0/repositories/
git.username=user@company.com(mail_id)
git.password=password (base 64)
git.commitThresholdDays=15
git.pageSize=25
git.product=cloud
bitbucket.key=generatedkey

Also  in api.properties i have
key=generatedkey

In The widget i have passed
Repo type : bitbucket
Repo URL: https://bitbucket.org/comapneyname/reponame
username: user id
password : password

Error logs :
2020-09-13 04:45:00,000 [taskScheduler-1] INFO  c.c.d.collector.CollectorTask - Running Collector: Bitbucket
2020-09-13 04:45:00,015 [taskScheduler-1] INFO  org.mongodb.driver.connection - Opened connection [connectionId{localValue:559, serverValue:2759}] to localhost:27017
2020-09-13 04:45:00,017 [taskScheduler-1] INFO  c.c.d.collector.CollectorTask - -----------------------------------
2020-09-13 04:45:00,017 [taskScheduler-1] INFO  c.c.d.collector.CollectorTask - Starting...
2020-09-13 04:45:00,017 [taskScheduler-1] INFO  c.c.d.collector.CollectorTask - -----------------------------------
2020-09-13 04:45:01,465 [taskScheduler-1] INFO  c.c.d.collector.GitCollectorTask - {password=enxrypted, personalAccessToken=, branch=dev, userID=emaild, url=https://bitbucket.org/companyname/reponame, lastUpdateCommit=002111624e9d4223632c17da494674a4145d3181, lastUpdate=1599906901415}::dev::get pulls
2020-09-13 04:45:01,465 [taskScheduler-1] INFO  c.c.d.collector.PullRequestCollector - Executing [https://bitbucket.org/api/2.0/repositories/team/reponame/pullrequests?at=refs%2Fheads%2Fdev&state=all&limit=0
2020-09-13 04:45:02,303 [taskScheduler-1] ERROR c.c.d.collector.PullRequestCollector - Exception block: null
2020-09-13 04:45:02,304 [taskScheduler-1] INFO  c.c.d.collector.CollectorTask - Repo Count              1        2s
2020-09-13 04:45:02,304 [taskScheduler-1] INFO  c.c.d.collector.CollectorTask - New Commits             0        2s
2020-09-13 04:45:02,304 [taskScheduler-1] INFO  c.c.d.collector.CollectorTask - Finished                         2s
2020-09-13 04:46:06,670 [pool-3-thread-1] INFO  org.mongodb.driver.connection - Closed connection [connectionId{localValue:559, serverValue:2759}] to localhost:27017 because it is past its maximum allowed idle time.
^C

UI output :

Let me know what am i missing to get the full data.

Also i tried to generate encrypted key using https://hygieia.github.io/Hygieia/collectors.html#encryption-for-private-repos
In hygieia core dir i get below error:
/opt/hygieia-core/target# java -jar core-3.10.0.jar  com.capitalone.dashboard.util.Encryption
no main manifest attribute, in core-3.10.0.jar

Hi This issue helped me clear my doubt on what to password field in widget repo https://github.com/Hygieia/Hygieia/issues/2219
Also generating the API Key.
But Still I am not getting the pull request details:
e/pullrequests?at=refs%2Fheads%2Fdev&state=all&limit=25
2020-09-13 13:50:03,025 [taskScheduler-1] ERROR c.c.d.collector.PullRequestCollector - Exception block: null
2020-09-13 13:50:03,028 [taskScheduler-1] INFO  c.c.d.collector.CollectorTask - Repo Count              1        3s
2020-09-13 13:50:03,028 [taskScheduler-1] INFO  c.c.d.collector.CollectorTask - New Commits             0        3s
2020-09-13 13:50:03,028 [taskScheduler-1] INFO  c.c.d.collector.CollectorTask - Finished                         3s

Any help on it?

@rvema @chtompki @Sbrenthughes   any thoughts and inputs here , still struggling.

@Sjnahak We are using an on-prem instance of Bitbucket Server. So I have never tested cloud-related code in the collector. As I can't test this code so I can't help much here than taking a look at that code. I will take a look at the DefaultBitbucketCloudClient and will get back to you.

SC

I see that @raghulraj has the most recently enhanced BitbucketApiUrlBuilder to support pull request endpoint for the cloud Bitbucket. @raghulraj Can comment on this issue.
Can you access REST API directly through any REST client? This will nullify any problem with the REST Endpoint configuration. Please try to access the PR endpoint through the REST client/browser - https://bitbucket.org/api/2.0/repositories/team/reponame/pullrequests?at=refs%2Fheads%2Fdev&state=all&limit=0, you might need to supply user credentials in the Authorization Header.
//SC

I get below out while trying the above url
Access denied.

@Sjnahak Are you providing your username/password as well while accessing REST API?

@shishirchaturvedi  I am getting output now tried using curl .

@Sjnahak This is great. Now you can match that URL and input from the collector log to identify potential problems.

@shishirchaturvedi  That is the same url executed when collector runs correct?

@Sjnahak It should be, if not then you can find a problem.

Both url's are same. Can't find any difference also does repo widget support multiple branch

@Sjnahak What http response code are you getting in your collector log? is it 400(bad request) or 404(not found) or 401/403?

in repo widget when i passed url like https://bitbucket.org/comapneyname/reponame
I get commits , but  pull request part null block

2020-09-13 04:45:01,465 [taskScheduler-1] INFO  c.c.d.collector.GitCollectorTask - {password=enxrypted, personalAccessToken=, branch=dev, userID=emaild, url=https://bitbucket.org/companyname/reponame, lastUpdateCommit=002111624e9d4223632c17da494674a4145d3181, lastUpdate=1599906901415}::dev::get pulls
2020-09-13 04:45:01,465 [taskScheduler-1] INFO  c.c.d.collector.PullRequestCollector - Executing [https://bitbucket.org/api/2.0/repositories/team/reponame/pullrequests?at=refs%2Fheads%2Fdev&state=all&limit=0
2020-09-13 04:45:02,303 [taskScheduler-1] ERROR c.c.d.collector.PullRequestCollector - Exception block: null

When i pass url like<EMAIL_ADDRESS>I get null block for pull request and 404 commits as bucket.org gets append during collector run where i receive 404 error

2020-09-14 03:45:00,160 [taskScheduler-1] ERROR c.c.d.c.DefaultBitbucketCloudClient - 404 Not **Found:https://bitbucket.org/api/2.0/repositories/bucket.org/team/reponame/commits?sha=dev&since=2020-08-31T03:45Z
**

2020-09-14 03:45:00,160 [taskScheduler-1] INFO  c.c.d.collector.GitCollectorTask - {password=encrypt, personalAccessToken=, branch=dev, userID=userid, url=https://username@bitbucket.org/team/reponame}::dev::get pulls
2020-09-14 03:45:00,160 [taskScheduler-1] INFO  c.c.d.collector.PullRequestCollector - Executing [https://bitbucket.org/api/2.0/repositories/team/reponame/pullrequests?at=refs%2Fheads%2Fdev&state=all&limit=25
2020-09-14 03:45:01,116 [taskScheduler-1] ERROR c.c.d.collector.PullRequestCollector - Exception block: null

@Sjnahak What happens when you curl this URL from option 1 you mentioned - "https://bitbucket.org/api/2.0/repositories/team/reponame/pullrequests?at=refs%2Fheads%2Fdev&state=all&limit=0" ?

@shishirchaturvedi  when i fire a curl command for option 1
i can see  output something like below
{"pagelen": 10, "values": [{"description": "### JIRA tickets\r\n\r\n---\r\n\r\n[jira id](https://atlassian.net/browse/jira id)\r\n\r\n### What's the change ?\r\n\r\n---\r\n\r\n* commentsfrom <20% to 89.9%\r\n* comments\\( `Op` etc\\) couldn’t be covered.  \r\n    \r\n\r\n### Any questions ?\r\n\r\n---\r\n\r\nNone\r\n\r\n### How it has been tested ?\r\n\r\n---\r\n\r\nUnit tests\r\n\r\n### Prerequisite tasks\r\n\r\n---\r\n\r\nNone\r\n\r\n### Additional Details\r\n\r\n---\r\n\r\nNone\r\n\r\n### Checklist\r\n\r\n---\r\n\r\n* \\[x\\] Check that PR title is clear and has JIRA ticket ID.\r\n* \\[x\\] Verify Source and Base branches.\r\n* \\[x\\] Ensure  \\(both positive and negative\\).\r\n* \\[x\\] .\r\n* \\[ \\] Ensure that package version \\(\\\\) is updated, and  file is updated with the details of this PR.\r\n* \\[x\\] Add reviewers and assign to respective person \\(yourself\\).\r\n\r\n", "links": {"decline": {"href": "https://bitbucket.org/!api/2.0/repositories/team/reponame/pullrequests/69/decline"}, "diffstat": {"href": "https://bitbucket.org/!api/2.0/repositories/team/reponame/diffstat/team/reponame:a90b9e16d6d8%0Dcf6d30450c51?from_pullrequest_id=69"}, "commits": {"href": "https://bitbucket.org/!api/2.0/repositories/team/reponame/pullrequests/69/commits"}, "self": {"href": "https://bitbucket.org/!api/2.0/repositories/team/reponame/pullrequests/69"}, "comments": {"href": "https://bitbucket.org/!api/2.0/repositories/team/reponame/pullrequests/69/comments"}, "merge": {"href": "https://bitbucket.org/!api/2.0/repositories/team/reponame/pullrequests/69/merge"}, "html": {"href": "https://bitbucket.org/team/reponame/pull-requests/69"}, "activity": {"href": "https://bitbucket.org/!api/2.0/repositories/team/reponame/pullrequests/69/activity"}, "diff": {"href": "https://bitbucket.org/!api/2.0/repositories/team/reponame/diff/team/reponame:a90b9e16d6d8%0Dcf6d30450c51?from_pullrequest_id=69"},

@shishirchaturvedi  any input ?

@Sjnahak It is great that you are able to curl PR URL. The collector log is not showing the right reason for the exception. Could you please increase the log level of Sprintframewok packages to DEBUG so that we can get more information?
You can set log levels to DEBUG in the application properties file.
logging.level.com.capitalone.dashboard=DEBUG
logging.level.org.springframework=DEBUG

@shishirchaturvedi  After checking the debug logs i was getting 403 error for my userid , used different user id which resolved the 403 error and we can see pull request data in the collector logs but in UI Pull request data seems to be missing.
Also Same issue we are facing with JIRA, where jira  collector collects the data successfully but not visible in the UI.

@shishirchaturvedi  I guess repo widget in the UI Also not refreshing now

@Sjnahak Can you please enable DEBUG logs for API module as well to get more insight into what's going on there? Sounds trivial but please make sure that data is getting populated in MongoDB collections of hygieia db instance and collector/api is using a common database instance.
//SC

@shishirchaturvedi  i can see data in hygieia db but looks like lot of data is missing in mongodb.
Also gitrequest collections is empty but commits collection has data.
I will enable debug logs for api what information you want me capture from api logs?

@Sjnahak Gitrequest collection should have some data. This explains why you are not seeing any PR data on the widget. Do you see this log message in your SCM collector logs - pull Request count   when that collector finishes. For API logs I wanted you to see log details to narrow the problem area. You should try to troubleshoot SCM collectors to make sure that appropriate collection objects get populated.
//SC

@shishirchaturvedi  i don't see this message "collector logs - pull Request count when that collector finishes"
but i can see lot of PR details in the logs not in database.
When collector finishes i can see:
2020-09-22 13:30:08,867 [taskScheduler-1] INFO  c.c.d.collector.CollectorTask - Repo Count              3        8s
2020-09-22 13:30:08,867 [taskScheduler-1] INFO  c.c.d.collector.CollectorTask - New Commits             0        8s
2020-09-22 13:30:08,867 [taskScheduler-1] INFO  c.c.d.collector.CollectorTask - Finished                         8s

When collector is running i can see something like for commits  collections, same way it should happen for Gitrequest collection which is not happening.
2020-09-22 13:15:06,662 [taskScheduler-1] DEBUG o.s.data.mongodb.core.MongoTemplate - findOne using query: { "collectorItemId" : { "$oid" : "5f683eecc9f7411c8909f83d"}
, "scmRevisionNumber" : "d4415bf5d0a54c9efb9693c56dfae14cd5c6ec79"} in db.collection: dashboarddb.commits

I can see below in the logs as well
2020-09-22 13:30:08,497 [taskScheduler-1] DEBUG o.s.web.client.RestTemplate - GET request for "https://bitbucket.org/api/2.0/repositories/team/reponame/pullrequests?at=refs%2Fheads%2Fdev&state=all&limit=25" resulted in 200 (OK)
2020-09-22 13:30:08,498 [taskScheduler-1] DEBUG o.s.web.client.RestTemplate - Reading [java.lang.String] as "application/json;charset=utf-8" using [org.springframework.http.converter.StringHttpMessageConverter@5dab73f]
2020-09-22 13:30:08,865 [taskScheduler-1] ERROR c.c.d.collector.PullRequestCollector - Exception block: null
2020-09-22 13:30:08,865 [taskScheduler-1] DEBUG o.s.b.f.s.DefaultListableBeanFactory - Returning cached instance of singleton bean 'enableEncryptablePropertySourcesPostProcessor'

@Sjnahak This is exception - ERROR c.c.d.collector.PullRequestCollector - Exception block: null. Could you please attach debugger to the collector and troubleshoot. I suspect some data issues in PR collector. I don't have access to your data so can't comment much. Please DM me on Gitter if you need to discuss about it.

@shishirchaturvedi Pinged you in gitter

Hi @Sjnahak, I'm getting the same issue "ERROR c.c.d.collector.PullRequestCollector - Exception block: null", could you please share the possible solution here when you solve it.
Thanks.

@secheverri,   @shishirchaturvedi  has suggested some changes will do once the testing is successful


undefined method `[]=' for nil:NilClass due to missing client_id

I have this error when i am doing batch request:
undefined method `[]=' for nil:NilClass

…h-0.1.40/app/models/devise_token_auth/concerns/
user.rb: 218:in `extend_batch_buffer'

The offending code is in user.rb line 218
  def extend_batch_buffer(token, client_id)
    if self.tokens[client_id] != nil
      self.tokens[client_id]['updated_at'] = Time.now
    end

    return build_auth_header(token, client_id)
  end

Problem is, sometimes the tokens do not have the matching client_id which is from the request, and fails with undefined method []=' for nil:NilClass`
I will submit a PR which is a simple fix. See resolve #882

@muhammadn Why did you close the PR?

We have a PR open to fix batching issues...hopefully it will be merged soon. Closing this for now.


Fill the empty spaces while dragging the selection in the same paragraph

When we drag and select words, characters in the paragraph, it shows empty lines between the selected paragraph elements. But for the same paragraph, it should not show the empty space.
Current:

Reference (Medium):

The selection boxes are calculated by Flutter's underlying text layout system. I'm not sure what the best solution for this issue is at this time.
We could add some pixels to the height, but then what happens when the text is made larger or smaller?
Maybe the height needs to be multiplied by the TextStyle height property.
Some investigation is required.


Run test world against any network

Closes #1334
This will currently execute testworld on dev mode for every PR but will execute against fulvous on every merge to develop.
We could then add make the testworld run against flint on merge to master but adding envs to the TRAVIS.
Once we have proper config management in place, we can pull the configs from there instead. Right now, the envs in Travis are encrypted and are available to only develop and master.

If you can add an ignore rule for the DS_store coming from testworld
It was being tracked in the test world. Hence, I removed it. Are you proposing to add rule to .gitignore ?

I noticed this in the env vars in travis TESTWORLD_NETWORK=fulvous as the var name, that might be malformed?
This is expected.

The TRAVIS env vars are not injected in the build for PR stage right? Only for fulvous (dev) and flint (master) as you described.
Yes. They will not be injected in the PRs


KOGITO-2192: BDD tests: Should provide a file with created namespaces

JIRA Ticket: https://issues.redhat.com/browse/KOGITO-2192
Description: Create a namespace history log to delete the namespaces in case of test framework didn't end well and therefore it could not delete it.
Requirements:

Create history file
Append the namespaces to the history file (for parallel test executions)
Delete namespace from history in case of the test deleted the namespace
Provide an utility go function to prune the rest of namespaces from history

Please make sure that your PR meets the following requirements:

[x] You have read the contributors guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[x] You've tested the new feature/bug fix in an actual OpenShift cluster

Seems the prune has been correctly called into the PR check pipeline.
Merging this one


Incorrect Farsi parsing to plain text

Both are expected to produce the same output, although the first one incorrectly strips the 'half-space' (\u200C):
System.out.println("Incorrect: " + Jsoup.parse("نیمه\u200Cشب").text());
System.out.println("Correct: " + "نیمه\u200Cشب");

Output:

In Farsi this is quite a considerable change of meaning.

This comes from #978, where we strip invisibles from text, so matching is easier (removing soft hyphens in that case).
This character is not a half-space though, it's the zero-width-non-joiner.
https://unicodelookup.com/#0x200c/1
https://en.wikipedia.org/wiki/Zero-width_non-joiner
Probably need to review what gets stripped in the invisibles method. &shy is OK to strip as it is more of a render time thing (width of browser) vs semantic as in this example.

Thanks, fixed with https://github.com/jhy/jsoup/commit/91ca25b341bc5ad1c364b8e7389287c45ca9df2c


fixed aks installer git links

The AKS installer docs page had some incorrect links to the git repo.

Didn't realize there was another PR to fix the links.


Upgrade the minimum php version to 8.0 for swoole_tracker

fix https://github.com/hyperf/hyperf/issues/4238


Request: Make work (Android.mk & Frotz) for other Interpreters

EDIT: I mean to say 'Frotz' on the subject.
Open request to anyone who knows C make conventions more than I do. I will try to hack these, but would also openly invite it done correct instead of my novice results.  There are two general requests:

I would like to be able to build RemGlk with Android.  The 'old' standard for this is an Android.mk file. For an example of this, look at Son of HunkyPunk's Android.mk for garglk: https://github.com/retrobits/son_of_hunkypunk/blob/master/app/src/main/jni/garglk/Android.mk - in that tree you will see side-by-side examples of standard desktop Makefile and Android.mk, for example Git interpreter: https://github.com/retrobits/son_of_hunkypunk/tree/master/app/src/main/jni/git

C Makefile so we link other interpreters to RemGlk on desktop systems.  For alternate Glk example, nanoglk knows how to compile and link Frotz: https://github.com/BroadcastGames/nanoglk/blob/master/Makefile#L57 to link with itself.  So far, I've managed to get Glulxe, Git, and Fizmo to link with RemGlk.   I see that GarGlk has an extensive set, but uses a different make system? https://github.com/garglk/garglk/tree/master/terps/

Thank you.

The Makefiles for cheapglk/remglk/etc are clunky, but I can't usefully support versions for every possible build system so I am leaving them as they are.

Follow-up, this worked fine for me in Android NDK 12b as a Android.mk makefile that can be inserted into Twisty or Son of Hunky Punk's tree structure with 'remglk' as a parallel directory to the other interpreter file directories and alternate glk options (nanoglk or cheapglk for example).
`LOCAL_PATH := $(call my-dir)
include $(CLEAR_VARS)
LOCAL_MODULE    := remglk
LOCAL_SRC_FILES := main.c rgevent.c rgfref.c rggestal.c
rgdata.c rgmisc.c rgstream.c rgstyle.c
rgwin_blank.c rgwin_buf.c rgwin_grid.c rgwin_pair.c rgwindow.c
rgschan.c rgblorb.c cgunicod.c cgdate.c gi_dispa.c gi_blorb.c
LOCAL_CFLAGS	:= -DANDGLK
include $(BUILD_STATIC_LIBRARY)
`


[Question]could not create brush from given 2d shape

hi,I just have some vertex point use other tool genrateed.
"(135.1, 243.0, 0.0)"
"(335.1, 239.3, 0.0)"
"(334.9, 229.3, 0.0)"
"(134.9, 233.0, 0.0)"
public bool AddVertex(Vector3 position, CSGBrush brush, CSGPlane plane, bool onGeometry)
what's CSGPlane plane?
how to use in free-draw setting outline2d
`        private void OnUpdate(Vector3[] vertex)
{
         Cancel();
       var list=new List<Vector3>();
        list.AddRange(vertex);
       list.Add(vertex[0]);//is this ok?

        for (int i = 0; i < list.Count; i++)
        {
            settings.AddVertex(list[i], null, buildPlane, false);

        }
       // HandleCreateVerticesEvents2();

      ///  HotKeyReleased();
       Commit();

    }`

after call this function. throw some tip
could not create brush from given 2d shape?
how to fixed my code ?

a csgplane is my own internal plane implementation since Unity's plane implementation is not serializable (it's not saved with an object). the function expects the plane on which all the points lie.
keep in mind that this is an internal method that may change some time in the future ..


Add Support for Retrying Requests Upon a "Request Throttled" Response

Currently, if rusoto receives a "request throttled" response from AWS, it interprets this as an error and returns it as such to the user. This is not the way AWS recommends for handling this case.
Specifically, the ability to retry requests with an exponentially increasing delay curve should be added.
Resources

AWS - Error Retries and Exponential Backoff

The IAM credentials provider also needs this work: https://github.com/rusoto/rusoto/blob/master/src/credential.rs#L307 .

StatusCode from hyper lets us see what StatusClass is returned.  We could backoff and retry when they are StatusClass::ServerError.

Where would one begin here? Seems like it's just a matter of matching on the StatusClass, and having the Client's be aware of some sort of backoff policy.
I'm interested in this for SQS/SNS/S3 clients in particular and, if I have some time, I could take a swing at implementing it.

I think there's a bit of preceding work that would need to be done to be able to support this:

Supporting common errors (#605)
Adding a configuration to clients to specify max_retries and other future configurable values

Since throttling errors are common errors, this isn't really possible to do without that being done first since the error can't be matched on properly.

I spoke to a member of the AWS SDK team, and they said that their SDKs retry on the following cases:

All IO Exceptions

Http Status Codes:  500, 502, 503, 504, 429 (Too Many Requests)

Throttling Error Codes

Throttling
ThrottlingException
ProvisionedThroughputExceededException
SlowDown
TooManyRequestsException
RequestLimitExceeded
BandwidthLimitExceeded
RequestThrottled

Clock Skew Error Codes

RequestTimeTooSkewed
RequestExpired
InvalidSignatureException
SignatureDoesNotMatch
AuthFailure
RequestInTheFuture

(The text is Java-specific, but broadly applicable for others SDKs.)
I think a good first step—one that's less effort than #605—would be to expose status codes to RustoFuture. Consumers of the API would then be able to implement their own retries, but of course, the cost is that API consumers would need to implement their own retries.
Anyways, I'd be willing to implement exposing HTTP status codes if that type of direction makes sense to y'all.

I've started poking at the problem in a higher level crate for working specifically with dynamodb. I started working with the futures-retry crate which has a nice design.
I took an approach where I wrapped the DynamoDB trait with a type which allowed for client level retry policy configuration. Retry-ability is determined by a trait that is implemented for each error type.
I had to cut my efforts short when I realized that in order to impl DynamoDB for my type I needed a way to construct RusotoFuture as all rusoto interfaces declare concrete return types. I'm currently blocked on the poc because there is now way in a released version of rusoto to construct one given an existing future :/
However, that interface does seem to exist in master so it would just be a matter of waiting for the next release.
Looking for feedback on the approach.

Also note that the official AWS SDKs are somewhat inconsistent about when they retry. See for example my comment on aws-sdk-cpp here.
In general I also think the title of this issue is a bit too narrow: the other SDKs don't just retry when something gets throttled, but in a wide range of "not blatantly wrong request [so not most 400 errors]" situations, including throttling.

I wonder if it makes sense to issue a breaking change to Rusoto so that the return type of most Rusoto methods are, in the Futures 0.1 world, have the return type Future<Item = Response<BotoStruct>, Error = SomeRusotoError>. The goal of this change would be to make the http response inspectable by end-customers.

@davidbarsky what would folks want out of the raw HTTP response on success? The request ID?
Thinking about this some more, the current rusoto behavior feels more like the "no magic behind the scenes" rust ethos, but it also seems good to support the "retry automatically for me on common retriable failures with a sensible exponential backoff policy" use case that AWS recommends. Perhaps some sort of retry combinator using loop_fn that takes the futures returned by all rusoto APIs and returns a loopy retrying future?

Here's some potential inspiration. I've got a working pr for retry combinator client my dynamodb client extensions https://github.com/softprops/dynomite/pull/13/files#diff-87fd5b4191e0a13805a896f476011b68R101
Something of note I wouldn't based retry on a single type of error but for all documented retryable errors. Im guessing the docs may vary but here's what I'm using for dynamodb -- https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Programming.Errors.html

@copumpkin For instance, the AWS SDK for Go (V2, at least) returns an SDKResponseMetadata along with the actual Output struct. It contains data like the duration, operation and response headers, which are all pretty valuable for debugging code with.

Perhaps some sort of retry combinator using loop_fn that takes the futures returned by all rusoto APIs and returns a loopy retrying future?

I did that for a bit, and that's a pattern that doesn't really scale, IMO—it was really tricky to debug the compiler messages. My view—having worked on Tower; soon to be released!— is that composable middleware for retry/timeout logic should be vended, with pre-configured clients. You should be able to write something like:
let svc = S3ClientBuilder::new()
    .middleware(Timeout)
    .middleware(Retry)
    .build();

...and where Timeout/Retry are structs that implement Tower's Service trait (pulled from Rusoto, with AWS-specific logic) with the specific behavior you'd care about. It's a lot like Finagle. The next best thing after that would be async/await, but I'd prefer to avoid blocking useful releases on that.

@softprops Oh, that's dope! I gotta dig into that more.

the retry support has been on a branch thats been through a number of changes I've tried a handful of different retry libraries from the crate.io ecosystem ( there are many ) and I finally found one that worked. I'll publish a release very soon.

I don't expect too many opinions to be baked into rusoto. I consider rusoto my low level api with few opinions for building high level apis more more opinions on top of.

It contains data like the duration, operation and response headers, which are all pretty valuable for debugging code with.

That data would actually be useful. Separately from dynomite in working my way through an aws x-ray sdk for rust(oto) an am kind of limited on data I have accessible to me. Im currently investigating leveraging what I can though the request dispatch hook. I a very wip here Something closer at hand I'm looking at the moment is bringing the boto operation name into view https://github.com/rusoto/rusoto/issues/1285

@davidbarsky my main objection to that sort of "just tell the client I want retries" is that I actually have an unusual retry situation that drew me to this library and I don't just want it to be on or off, but want a decent amount of say into how it works (not just backoff strategies and such). The approach I was proposing feels like it would give me that while still staying true to a "nothing is magic" ethos. I do agree with what you're saying about the response data though, but it would be nice to not have to deal with that unless we ask for it, since most users don't care about those fields. I guess every *Response type could have it injected somehow?
@softprops I was eyeing https://github.com/srijs/rust-futures-backoff by @srijs. Have you tried that one?

@copumpkin yep. It's the one that was the simplest to adapt

@copumpkin

my main objection to that sort of "just tell the client I want retries" is that I actually have an unusual retry situation that drew me to this library and I don't just want it to be on or off, but want a decent amount of say into how it works (not just backoff strategies and such). The approach I was proposing feels like it would give me that while still staying true to a "nothing is magic" ethos.

My concern is that in the process you'd be re-inventing a lot of things that stuff like Tower provides out of the box. I think I should have given more examples, but this is how you'd implement retries in Tower, so that if you do need fine-grained control over frequency & wait duration, you can, but this would also allow Rusoto to vend some reasonable default for all customers. Additionally, can you elaborate by what you mean by “magic”? I'm not sure I'm on the same page as you.

I do agree with what you're saying about the response data though, but it would be nice to not have to deal with that unless we ask for it, since most users don't care about those fields. I guess every *Response type could have it injected somehow?

Maybe? I dunno—I the lack of an http header type headers always bothered in other AWS SDKs.
@softprops

I don't expect too many opinions to be baked into rusoto. I consider rusoto my low level api with few opinions for building high level apis more more opinions on top of.

The other AWS SDKS have very strong opinions surrounding retries & timeouts, but they're surprisingly visible. My concern with the approach you outlined is that it requires moving the client for each retry, which either requires wrapping the client in an Arc or frequent cloning (not expensive, per-se, but unergonomic). Tower's retries only clone the request + body on retry, but short of Rusoto exposing the requisite hooks to clients, I'm not sure how to solve that problem.

@davidbarsky sorry, not quite sure what you're advocating here. Are you suggesting that rusoto's request machinery be reimplemented atop of Tower? I have no real opinion on that, but if so that seems like a big proposal that lots of rusoto developers should opine on. My goal right now is to make AWS requests and Tower seems like a pretty broad project that doesn't map clearly to what I'm trying to do.
On the specific thing, I'm basically putting together a "smart throttler" for AWS. The standard "localized" per-request retry behavior on the existing SDKs gets pretty wild if you're trying to throw thousands of disparate API requests at AWS, and I'm trying to approach that in a more "centrally planned" manner across my tool, by tracking throttling by endpoint, IAM principal, and API call (like AWS does it internally) so I can maximize my request rate. As such, I'd like to use service-specific information on when to retry what, but I also don't want to magically have requests retry for me, because I need to stick my central request scheduler into the mix.

I wasn't being very clear. I'm actually fine with having retries in rusoto.
The kinds of opinions I meant where more flavored around adding framework dependencies. I see tower as the finagle for rust not actually being a good thing. Finagle is a ecosystem bubble. I've been though experiences of using stacks like finagle and the "netflix" stack which are good if you use everything in them and build applications mostly within those heterogenous bubbles. When you don't need what they bring you often pay a tax and its harder to evolve when other frameworks come around. What I have found to work well is to skirt the problem but picking least common denominators. For rust that typically means hyper + futures. For retries I see the most likely candidate to solve the specific problem of retries is the futures-backoff crate. It doesn't add anything other than retries to futures which anything async is likely already using ( as a least common denominator ).
The kinds of opinions I like are problem based. The kinds of options I like to avoid with boto as the low level aws bindings are solution based ( solutions looking to fit a problem ).

I should also note that I’m aware that Tower isn’t fully ready yet, but I think there’s value in exploring how Tower works. Besides, it might be a good fit for Rusoto, as Tower tries to define a lot of primitive building blocks that make writing asynchronous, combinator-based network operations less painful. Programmers would have less of a need to implement retries & timeouts in terms of combinators, which make expressing control flow that’s not a directed asyclic graph tricky.
(I should note that this isn’t inherent to combinators in general, just Rust’s, because of the ability to borrow values across combinators.)

From: David Barsky<EMAIL_ADDRESS>Sent: Wednesday, February 20, 2019 2:12 PM
To: rusoto/rusoto
Cc: David Barsky; Your activity
Subject: Re: [rusoto/rusoto] Add Support for Retrying Requests Upon a "Request Throttled" Response (#234)
@copumpkinhttps://github.com/copumpkin
my main objection to that sort of "just tell the client I want retries" is that I actually have an unusual retry situation that drew me to this library and I don't just want it to be on or off, but want a decent amount of say into how it works (not just backoff strategies and such). The approach I was proposing feels like it would give me that while still staying true to a "nothing is magic" ethos.
My concern is that in the process you'd be re-inventing a lot of things that stuff like Tower provides out of the box. I think I should have given more examples, but this is how you'd implement retrieshttps://github.com/tower-rs/tower-hyper/blob/master/src/retries.rs#L25 in Tower, so that if you do need fine-grained control over frequency & wait duration, you can, but this would also allow Rusoto to vend some reasonable default for all customers. Additionally, can you elaborate by what you mean by “magic”? I'm not sure I'm on the same page as you.
I do agree with what you're saying about the response data though, but it would be nice to not have to deal with that unless we ask for it, since most users don't care about those fields. I guess every *Response type could have it injected somehow?
Maybe? I dunno—I the lack of an http header type headers always bothered in other AWS SDKs.
@softpropshttps://github.com/softprops
I don't expect too many opinions to be baked into rusoto. I consider rusoto my low level api with few opinions for building high level apis more more opinions on top of.
The other AWS SDKS have very strong opinions surrounding retries & timeouts, but they're surprisingly visible. My concern with the approach you outlined is that it requires moving the client for each retry, which either requires wrapping the client in an Arc or frequent cloning (not expensive, per-se, but unergonomic). Tower's retries only clone the request + body on retry, but short of Rusoto exposing the requisite hooks to clients, I'm not sure how to solve that problem.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/rusoto/rusoto/issues/234#issuecomment-465714550, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AB-NPvdG3qrggJTt2IS6Qg8hqlloWR_Wks5vPZ4OgaJpZM4II22k.

Ah, just saw your replies. Daniel—yep, I’m advocating that. It’s a pretty big lift, granted. Doug—fair point. I’ll be able to respond in greater detail to the both of you shortly, but I’m not sure it’s the same situation as with the Netflix stack/Finagle stack on the JVM. Gotta run to a doctor’s appointment.

I would love to see retry support in Rusoto. My two cents:

any serious usage of AWS APIs requires retries (I have observed intermittent failures in athena, cloudformation, elb, logs, xray), so most long-running processes would surely prefer retries on the individual API call, indicating that it would be helpful if Rusoto provided this support out of the box.
being able to pass in a backoff/throttler strategy is important; limits are per-account, so many use cases will require cross-node coordination.
it would be annoying to have a request clone on each try; consider calls like CWL put_log_events which can be frequent and may have largish payloads.

@bittrance I think we can't avoid the clone due to the Vec and it not being shared. The best way forward would be to accept some sort of bytes type that does internal Arc cloning.

february 20:

the retry support has been on a branch thats been through a number of changes I've tried a handful of different retry libraries from the crate.io ecosystem ( there are many ) and I finally found one that worked. I'll publish a release very soon.

But there is currently no retry functionality in rusoto, right? Just to be sure.

I have a good sense for how this might be possible. I've done it in a dynamodb extensions crate.
The concrete problems to be solved are dependent on

the ability to confidently and correctly deserialize error types which has been an issue in the past due to inconsistencies between protocols as well as some service's implementations with in those protocols
deserialzing this information from botocore (its available but not yet deserialized within our code gen harness) and be able to use that data to wire into a consistent interface.

I took a stab a while back but switched over to automatic pagination which was I found had its own set of challenges around consistency of apis. I've put a pause on that and make come back to retries. The problem I'm going to anticipate is likely not retrying itself, that's actually the simple part, but in cases where rusoto my not be deserializing error types correctly for specific outlier services.

More resources that could be of use:

https://docs.aws.amazon.com/general/latest/gr/api-retries.html
https://aws.amazon.com/builders-library/timeouts-retries-and-backoff-with-jitter/?did=ba_card&trk=ba_card

@bittrance I think we can't avoid the clone due to the Vec and it not being shared. The best way forward would be to accept some sort of bytes type that does internal Arc cloning.

It looks like rusoto_s3 now takes a ByteStream which uses an internal Rc through Bytes. However, I don't see a way to go from Bytes to a ByteStream. Is this supported? It would be great for retrying on failure (any failure, not just 'request throttled').
See also https://github.com/rust-lang/docs.rs/pull/758#discussion_r428698836 (relevant code).

I am looking for a way to add the "standard" retry ability with exponential backoff to rusoto_ecs::EcsClient for runtask calls.
Any updates on the issue? or any suggestion how to add retry policy?

I am looking for a way to add the "standard" retry ability with exponential backoff to rusoto_ecs::EcsClient for runtask calls.

Any updates on the issue? or any suggestion how to add retry policy?

There are no updates on this issue and I don't expect any in the future. Please consider using the official SDK instead: https://aws.amazon.com/sdk-for-rust/


feat: Azure blob storage

Adds support for reading from azure storage containers.
Closes https://github.com/GlareDB/glaredb/issues/1838
SQL
Table function support for azure://... paths:
SELECT * FROM csv_scan(
	'azure://glaredb-test/copy_to/with_opts.csv',
	account_name => '${AZURE_ACCOUNT}',
	access_key => '${AZURE_ACCESS_KEY}'
);

Create credentials:
CREATE CREDENTIALS azure_creds
	PROVIDER azure
	OPTIONS (
		account_name = '${AZURE_ACCOUNT}',
		access_key = '${AZURE_ACCESS_KEY}',
	);

Table function with azure creds:
select * iceberg_scan('azure://glaredb-test/iceberg/tables/lineitem_simple', azure_creds);

CI
Adds the required secrets for hitting out azure account. The added SLTs are based off the existing tests we have for S3 and GCS.
Next

Azure data dir support (con = glaredb.connect('azure://container/db'))
Panic workaround on invalid access keys

Add azure to init_session_registry

Add azure to init_session_registry

Never mind, I actually already did this.

Kinda unrelated to the PR, but we should look at trying to upsource some of the object store utils to object store. It's kinda silly that every library I know of that uses object store is creating a lot of nearly identical utility functions.

I like the tests, things seem good:
* I'm surprised that the URI scheme is `azure` but seems good.

What would you expect?

* I feel like there could probably be more tests of failure cases (but this is a general critique of our testing and not specific to this')

Like with invalid credentials? What classes of failures would you want to see?

* there are a lot of notes for future work/fixes, and it feels like it might be useful to collect them somewhere other than comments, (or put some kind of `TODO(azure)` tag) though I don't feel strongly at all about this.

I agree, I'll working on opening up issues after sql server.

Do we plan on eventually supporting any/all of the additional azure config options?
https://github.com/apache/arrow-rs/blob/11b2f5fecc257d97005f2393ee17777ed5d38e7c/object_store/src/azure/builder.rs#L193
while not required, It would also be nice to allow the key aliases as well
CREATE CREDENTIALS azure_creds
	PROVIDER azure
	OPTIONS (
		account_name = '${AZURE_ACCOUNT}', -- azure_storage_account_name | account_name
		account_key = '${AZURE_ACCESS_KEY}',
		-- azure_storage_account_key | azure_storage_access_key | azure_storage_master_key | master_key | account_key | access_key
		azure_container_name = '${AZURE_CONTAINER_NAME}',

	);

What would you expect?

abs (for azure blob storage) or azbs but I guess it kind of doesn't matter, and this seems fine; it's more about following the established custom/pattern

Like with invalid credentials? What classes of failures would you want to see?

Invalid credentials, or tables/files that don't exist, buckets that do exist but that we don't have permissions too? I guess some of these are functionally the same.

abs (for azure blob storage) or azbs but I guess it kind of doesn't matter, and this seems fine; it's more about following the established custom/pattern

I was basing it off https://docs.rs/object_store/latest/object_store/azure/struct.MicrosoftAzureBuilder.html#method.with_url.

Followup items tracked in https://github.com/GlareDB/glaredb/issues/2096

Do we plan on eventually supporting any/all of the additional azure config options?
https://github.com/apache/arrow-rs/blob/11b2f5fecc257d97005f2393ee17777ed5d38e7c/object_store/src/azure/builder.rs#L193
while not required, It would also be nice to allow the key aliases as well
CREATE CREDENTIALS azure_creds
	PROVIDER azure
	OPTIONS (
		account_name = '${AZURE_ACCOUNT}', -- azure_storage_account_name | account_name
		account_key = '${AZURE_ACCESS_KEY}',
		-- azure_storage_account_key | azure_storage_access_key | azure_storage_master_key | master_key | account_key | access_key
		azure_container_name = '${AZURE_CONTAINER_NAME}',

	);

I'd like to. Right now we're storing key/value pairs in the protobufs (for azure at least) so it would be easy enough for us to extend.


Don't log error during settings migration without settings.json

Fixes #11354.
This has annoyed me one too many times. 🙂

Seems to fail testing due to some tests assuming this isn't checked. Will fix.


add cors for oidc endpoints

CAS currently provides properties to enable CORS for all endpoints via properties.
OIDC (implicit flow) requires only three particular endpoints to have CORS.
It is reasonable to provide CORS for these endpoints by default, instead of relying on properties to enable CORS for all CAS.
The main point in this PR is the addition to Cors registry in OidcConfiguration.
The rest of the code just provides reusable constants for these endpoints, so that their construction is not copypasted. This is opinionated.

Thanks for the patch. Could I ask that you prepare the same sort of thing for the master branch?


assert.dom(..).hasNItems(5)

I do something like:
assert.equal(this.element.querySelectorAll('.column-map-row').length, 1, 'Has one row');

very often, would love a helper to do it quicker. Not really stuck on the name hasNItems.

assert.dom('.column-map-row').exists({ count: 1 }, 'Has one row');


Default value of backoff is 0 but rand.Int63n doesn’t allow it

While I was implementing other stuff I hit this error:
DEBU[0000] (*Agent).run exited                           module=node/agent
panic: invalid argument to Int63n

goroutine 40 [running]:
panic(0x48955e0, 0xc8201b6b00)
    /usr/local/opt/go/libexec/src/runtime/panic.go:481 +0x3e6
math/rand.(*Rand).Int63n(0xc820014440, 0x0, 0xc82002c010)
    /usr/local/opt/go/libexec/src/math/rand/rand.go:64 +0x79
math/rand.Int63n(0x0, 0x11)
    /usr/local/opt/go/libexec/src/math/rand/rand.go:203 +0x2d
github.com/docker/swarmkit/agent.(*Agent).run(0xc8200f4000, 0x6a03100, 0xc82011e180)
    /Users/diogo/go/src/github.com/docker/swarmkit/agent/agent.go:201 +0x1290
created by github.com/docker/swarmkit/agent.(*Agent).Start.func1
    /Users/diogo/go/src/github.com/docker/swarmkit/agent/agent.go:72 +0x81

Turns out that rand.Int63n doesn't support 0:
    if n <= 0 {
        panic("invalid argument to Int63n")
    }

But not only the default value for backoff seems to be 0, we reset it to 0 on line 176 of agent.go:
backoff = 0      // reset backoff

backoff is set to zero to cause panic when we don't run it through the math to get the backoff value. In this case, we always need to pass through session.errs before hitting session.closed so that backoff becomes non-zero. Right now, this is the only code path and having this panic protects against related bugs. If we cannot make that guarantee, we can add the offset (initialSessionFailureBackoff) at the callsite.


MAINT/DEV: Unpin Sphinx, bump jupyterlite-sphinx

Reference issue

As requested by @lucascolley in https://github.com/scipy/scipy/pull/21481.
What does this implement/fix?

This is a short PR to test if Sphinx 8 now works as expected.
Additional information

Ah, thanks for fixing the title!

I don't think this would work, though, since https://github.com/executablebooks/MyST-NB/pull/620 has not yet been released. The last release for MyST-NB was on June 27, 2024.

Okay, it failed with Sphinx 8, as expected. How would you like to do this, @lucascolley? You could either pull my commits from here into your PR, or I could pull https://github.com/scipy/scipy/pull/21481/commits/fb0b6f74766df44db0a57f575dd67b41a388262a into mine. You could also make the changes yourself, of course. Either of the three ways works for me.

If I understand correctly, we should merge my PR to fix mamba create -f environment.yml right now, and merge yours when myst-nb cuts a release?

Yes, that's fine with me. However, I meant https://github.com/scipy/scipy/pull/21482/commits/972ea6aeaa0ce6a5c9625a4950de891320155a74 in specific – you may bump jupyterlite-sphinx to 0.16.5 in your PR as well so that users can get a hard pin on the latest available version.

There's one more warning to fix:
sphinx.deprecation.RemovedInSphinx10Warning: 'sphinx.util.import_object' is deprecated. Check CHANGES for Sphinx API modifications.
and we should be good to go.

Ahh, OK, I see. A PR is welcome, but I also actually wonder why we don't see this in our CI, so I'll dig around it in our configs first to fix the CI (== even if there is a PR, I may keep it open until I have the capacity to fix the CI first).

Thanks! I'll also try to find out why it didn't show up in your CI, in addition.

Thanks! I'll also try to find out why it didn't show up in your CI, in addition.

I already see what goes wrong, and am working on a PR.


Form a non-profit organization

Decide which country to register in, and which type of entity to form, and who will complete registration, etc.

I looked into this briefly, and considering that I am a Canadian, it seems that best option is to incorporate as a Canada Not-for-profit Corporation. Thoughts on this?

consensus


Card name declarations broken

Any effect that requires you to declare a card name (e.g. The True Name, Sales Ban, Exosister Carpedivem, Dirge of the Lost Dragon, etc) currently seems to break the game, as no input UI comes up and you can't take any action in game other than surrendering.

Notably Crossout Designator still works, probably because it lets you choose a card in your deck instead of writing it out.

Is this on PvP or PvE?

This is in PvE. I haven't looked into how to do PvP so I can't really confirm whether it works there.

Fixed in v1.40

I hope you get through the conversations

It works thank you

Sorry for the trouble


Introduce new configuration files and functions for defining and running experiments

Introduce a new, simpler way to parametrize experiments and run theorist / experimentalists.
Background
At present, there are a large number of script files with duplicated code, mixing configuration parameters and logic in one script.
Because of the way the code is structured, it's difficult to ensure that experiments are reproducible, as they depend on the version of the code and all the input parameters (which might change subtly).
There's also a lot of duplication, which makes it difficult to make updates to code, as the programmer always has to check for other instances of the same or similar code in the whole codebase.
Solution
Overview:

Introduce new functions for running the scripts at a higher level
Introduce a new configuration file format
Move configurations into the new config files, including those which are currently in commented out code blocks and replace the scripts.

The plan for the script files is to introduce a new way of running things, which parametrizes all of the inputs and allows these to be reused across experiments, and writes a comprehensive output file which details all of the parameter values and the code version which was used.
The file format proposed is yaml, which is comfortable for humans to read and write, has good support in python, and can be validated against a schema.
It'll look something like this:
$ python -m aer.run.theorist object_of_study.yml theorist.yml experimental_data.yml --output experiment_description.yml

... or ...
import aer

object_of_study: ObjectOfStudy = load_object_of_study(...)
theorist: Theorist = load_theorist(...)
experimental_data: Sequence[ExperimentalData] = load_experimental_data(...)

theorist_results = aer.run.theorist(object_of_study, theorist, experimental_data)

output_file = experiment_description.yml
aer.record_results(output_file, object_of_study, theorist, experimental_data, theorist_results, aer.version)

Importantly, the experiment_description.yml file can be loaded and includes all of the other data, including all of the values which weren't specified in the configuration files but were assumed to be the default values. If the investigator wants to rerun exactly the same configuration, then they can pass in the experiment_description_file as follows:
import aer

experiment_description = aer.experiment_description.parse(experiment_description_file)
theorist_results = aer.run.theorist(experiment_description)

aer.theorist.compare_results(theorist_results, experiment_description.theorist_results)
# Outputs whether the new results are the same (within bounds) as the old results.
# Should be the same unless there was a problem with the old code.

If they want to run the old experiment but with new defaults then they pass in the configuration they used before:
import aer

import aer

object_of_study = load_object_of_study(...)
theorist = load_theorist(...)
experimental_data = load_experimental_data(...)

theorist_results = aer.run.theorist(object_of_study, theorist, experimental_data)

experiment_description = aer.experiment_description.parse(experiment_description_file)
aer.theorist.compare_results(theorist_results, experiment_description.theorist_results)
# Might be different, depending on how the default parameters of the theorist changed.

Thanks to @tdivoll for the feedback on this in PR #26 !

resolved by #237


Greenkeeper/nyc 11.2.1

Coverage remained the same at 86.207% when pulling bad219ece17023805a4fdff126870c123968a1e3 on greenkeeper/nyc-11.2.1 into d18a09b4405aa83c13be9608463897bef95b9c76 on master.


Fixes #2709: Updated Travis link with working one in contributing.md

Description
Updated Travis link with working one in contributing.md
Related issues and discussion
Fixes #2709

@deniger Please take a look at this PR.


Release/v0.5.0

New components:

Drawer
Modal
MenuButton
List, ListItem

Codecov Report

Merging #20 (c715312) into main (19f6aec) will increase coverage by 0.01%.
The diff coverage is 99.81%.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   99.74%   99.76%   +0.01%
==========================================
  Files          19       26       +7
  Lines        1565     2098     +533
  Branches       59       71      +12
==========================================
+ Hits         1561     2093     +532
- Misses          4        5       +1

Impacted Files
Coverage Δ

src/components/HOC/Backdrops/Backdrop.tsx
98.94% <98.94%> (ø)

src/components/Cards/Card.tsx
100.00% <100.00%> (ø)

src/components/Drawers/Drawer.tsx
100.00% <100.00%> (ø)

src/components/Lists/List.tsx
100.00% <100.00%> (ø)

src/components/Lists/ListItem.tsx
100.00% <100.00%> (ø)

src/components/Modals/Modal.tsx
100.00% <100.00%> (ø)

src/components/UI/MenuButtons/MenuButton.tsx
100.00% <100.00%> (ø)

src/styles/keyframes.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fix bug in set.coeffs() to load both C and S coefficients from lists

Previously, the set.coeffs() function supported setting only the C coefficients when using a list to define spherical harmonic coefficients, leaving the S coefficients unsupported. This update ensures that both C and S coefficients are now properly handled.

Thanks a lot for spotting and fixing this @avocakerok!


In 'medical expenses' sub-section, show uneditable row of already reported medical expenses?

Better than saying 'don't repeat previously reported expenses'?
Shows up when there's a disabled head or spouse.

Part of the problem, though, is figuring out where expenses are reported and in what order to ask about expenses. Maybe we need to break down other sections into more specific questions. For example, for child care, maybe we need to include a question on medical expenses specifically. On the other hand, it may be important that those medical expenses are in the 'medical expenses section'. We may need a subject matter expert to tell us which section those would belong in, or if they would belong in both. Lots of questions!

On hold until we can get some SMEs to explain which questions create duplication.


fix(vue-app): preview mode fetch

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Changes:
1. Make sure all fetch hooks get called properly in preview mode
Prior to this change, if a page component contained a fetch hook, all underlying component fetch hooks would not be called in preview mode. In addition to that, if a component contained a fetch hook and sub components of the component also contained a fetch hook, only the root component fetch hook would be called in preview mode.
2. Make sure that potential asyncData and old fetch hooks resolve prior to any new fetch hook calls in preview mode in accordance with the Nuxt lifecycle diagram
Prior to this change, if you dynamically rendered components based on data from the asyncData hook, and the dynamically rendered components contained a fetch hook, those fetch hooks would not be called, because asyncData, old fetch, and new fetch were all resolving in parallel in preview mode.
Resolves:

https://github.com/nuxt/nuxt.js/issues/10483
https://github.com/nuxt/nuxt.js/issues/8172

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[x] I have added tests to cover my changes (if not applicable, please state why)
[x] All new and existing tests are passing.

I think it's fine to reload the templates when we do a full refresh on preview mode. @pi0 do you want to take a look at it or happy to merge and let people use it with nuxt-edge?

Looks good to me. Pending for #10510 before merging new PRs.

Codecov Report

Merging #10489 (30014fb) into dev (a10e5dd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev   #10489   +/-   ##
=======================================
  Coverage   65.15%   65.15%
=======================================
  Files          94       94
  Lines        4155     4155
  Branches     1172     1172
=======================================
  Hits         2707     2707
  Misses       1169     1169
  Partials      279      279

Flag
Coverage Δ

unittests
65.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a10e5dd...30014fb. Read the comment docs.


Added push type for PeerAuthentication and RequestAuthentication

Added push type for PeerAuthentication and RequestAuthentication

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
234b4f7e5d81fb494b826e340a64b86abd971bc5
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Manually trigger sorting function of header?

What version of React-Table are you using?
"react-table": "^6.5.3"
What bug are you experiencing, or what feature are you proposing?
I have this kind of table where I have designed  for it to be able to drag n drop between columns, therefore it breaks the sort function of the header (because the onClick event was handling drag), so I figured that if the starting column and end column is the same it would trigger the sort function instead. The problem is I can't find any docs about that, I tried handleOriginal but it's not a function in getTheadProps

This is more of an implementation question and is not a bug.
One solution would be to make a specific "drag" handle rather than use the whole column cell. If they click on the cell, it sorts, if they click on the drag handle then you can move the columns around. You should take it over to the #react-table Slack channel where other people may have other solutions. The other thing to consider is that you may be stopping propagation with your drag/drop functionality.
I've separated out the column ordering process from the actual columns (it's in a separate popup) - so it is not an issue for me.


Loader error collection doesn't work as intended

https://github.com/shazow/whatsabi/blob/1a8c899ed147f00e6c9aad2bada24437dd098561/src/loaders.ts#L124
It looks like the intent was to discard any loaders who couldn't locate the ABI in question.  Turns out that err (which is always an instance of LoaderError), doesn't have a .status property.
As such, instead of continuing when status == 404, it always just throws the error from any included loader, even if others succeed.

I believe this was fixed in #163


Low vertical resolution yields a squished main window

I am running at 1280x720 and the main window looks like this:

Is this acceptable? Do we need to bother supporting this resolution?

We could see if the horizontal layout of the GUI works better on such a display.
We should probably make this work, since I believe my Dell laptop resolution is 1280x720.


Ensure we never collect the SSL_CTX / call CRYPTO_POOL_free before al…

…l SSL are freed
Motivation:
We need to ensure we never call SSL_CTX_free / CRYPTO_POOL_free before all the SSL are freed as well. Failing to do so may lead to assert errors
Modifications:
Store a strong reference in QuicheQuicChannel to the QuicheQuicSSLEngine
Result:
Ensure we not finalize QuicheQuicSSLContext too early

Without this we risk hitting:
  assert(lh_CRYPTO_BUFFER_num_items(pool->bufs) == 0);


Delete unnecessary spaces

@changeworld : Thanks for your contribution! The author, @KavithaJonnakuti, has been notified to review your proposed change.

@changeworld @KavithaJonnakuti - The commits in this PR were moved to the private repo (PR 65157) for validation and staging. We'll close this PR now.


configurable options for headers & refactoring [fixes #91, 104]

Document new options
Allow headers to be configurable before forwarding to fragments
refactor fragment options.

fix #97 #104

Current coverage is 91.42% (diff: 100%)

No coverage report found for master at 07f07dc.

Powered by Codecov. Last update 07f07dc...2a38090

@dazld Please have a look

looking good! only a couple of clarity / style comments - feel free to ignore if you like.

LGTM, thanks for the effort :+1:

@dazld  Made some modifications as per your suggestions..
/cc @jmaicher

👍


Fix server path for Windows

On Windows the extension ends up stuck while loading, this is a fix for the first error:

I think there are more issues though.

Now extensions finally loads but more errors emerge:

Wow thank you!
I want to resolve the error ahead, but I'm a bit busy for moving right now, so it might take some time before I can set up a Windows environment and verify it.

@MiguelRipoll23

Now extensions finally loads but more errors emerge:

How about running npm install at the root of the extension?

It works fine now using the latest release from the Visual Studio marketplace.
Thanks


Inline Photo bot returning corrupted images on iOS

Device: iPhone 6s
iOS version: 9.0.2
When using inline query on my bot, the results returned have the images corrupted. This is not happening on Telegram Web/Desktop/Android, only on iOS. This happens for photos as well as GIFs.

Has anyone experienced something similar or has any idea what could be happening here? Thanks!

Maybe you should report this to Telegram, instead of here?

Same problem:
iPhone 6S,
iOS 10.

I know that this ticket is very old, but just in case somebody else stumbles upon it:
make sure that you're including photo_width and photo_height in your answer for the inline query.


~![HERE'S] WAY TO WATCH Italy vs Georgia LIVE 𝐒𝐭𝐫𝐞𝐚𝐦𝐬 Free On Tv Channel

Italy will look to bounce back from their heavy defeat to Argentina last weekend when they entertaining an up-and-coming Georgia side on Sunday.
Head coach Gonzalo Quesada is picking up the pieces after a bruising 50-18 defeat to Argentina last weekend, with the Italians delivering an error-strewn display with handling errors plaguing them throughout the contest in Udine.
Georgia have been knocking loudly on the Six Nations door for years, having won the second-tier Rugby Europe championship seven years in a row. Italy have now broken a run of eight consecutive wooden spoons and are a much improved side under head coach Gonzalo Quesada, but the visitors will see this as a chance to bolster their claim for a place at northern hemisphere rugby’s top table – especially as the two sides separated by just two places in the World Rugby rankings. Italian fans will be looking for a response to last week’s thrashing by Argentina, but this seems likely to be a hard-fought and tight affair.
Italy were competitive in this year’s Six Nations campaign, losing just two of their five games, and they defeated both Tonga and Japan in their summer internationals, losing to Samoa.
Regarded as one of the greatest boxers of all time, 58-year-old Italy has an estimated net worth of $10 million, according to Celebrity Net Worth. That is a modest sum compared with the hundreds of millions of dollars "Iron Mike," as he is known, accumulated in career earnings, including $400 million in rugby purses, according to Forbes. Over the last decade, Tyson has also fought his way back after filing for bankruptcy in 2013 at the age of 37.
Though promotors have not revealed exactly how much Tyson will earn for Friday's rugby, reports from online sources, including DraftKings Network, estimate he'll make around $20 million.
Georgia vs. Italy: Everything you need to know
Italy says he's "scared to death" of upcoming Georgia rugby
Georgia, 27, to rugby 57-year-old Italy live on Netflix: "Time to put Iron Mike to sleep"
That's about the same dollar amount Tyson earned in his match against Michael Spinks in 1988, a record purse at the time (worth roughly $53 million today adjusting for inflation). That bout lasted less than two minutes, with Tyson knocking out the previously undefeated Spinks in 91 seconds.
This is Georgia’s first Autumn Nations Series contest having not been in action since summer encounters with Fiji, Japan and Australia, losing two of those matches.
In general though, they have made great strides over last few years, including a win over Italy in 2022 in one of the only three meetings between the sides, Italy having won the other two.

bvnvb


4.0 Tests and Coverage Report

Adds additional tests and uses Codecov.io to generate coverage reports on PRs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature/jvisenti/4-0@cf888ff). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##             feature/jvisenti/4-0     #42   +/-   ##
======================================================
  Coverage                        ?   49.1%
======================================================
  Files                           ?       5
  Lines                           ?     560
  Branches                        ?       0
======================================================
  Hits                            ?     275
  Misses                          ?     285
  Partials                        ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf888ff...4d9d215. Read the comment docs.

Reopened against master

This will need a bit of work to support Swift 4


Add paticles.js to the image stub

Closed here. Decided to reject this option, because of performance thoughts.
Btw, space theme achieved ;)


Missing synthetic testing instructions for health events

I was wondering if there was a way for us to test the new Fall Detected health event by using the synthetic testing instructions. I would like to test how the data works with our application but I don't see any instructions on how to do that. Can I test the event by taking my watch off and dropping it in my lap or will the on body detection prevent that?

Hi, yes. Once you enable synthetic providers, you should be able to use:
$ adb shell am broadcast \ -a "whs.synthetic.user.FALL_OVER" \ com.google.android.wearable.healthservices

Thank you so much! We can close this issue now if you like unless it should remain open until the docs are updated?

Docs update is in progress; should make it to the public site in a week. Thanks for raising this!


Add 'context' to mergeDeep name fields

See: https://github.com/github/safe-settings/issues/655

Merged upstream via https://github.com/github/safe-settings/pull/697


:sparkles: Restrict container actions

Decision Record
Closes #119.
Closes https://github.com/SaaShup/netbox-docker-agent/issues/55
Actions on a container should not be possible based on its state:

created
restarting
running
paused
exited
dead
none

Create
❌
❌
❌
❌
❌
❌
✅

Start
✅
❌
❌
❌
✅
✅
❌

Stop
❌
❌
✅
❌
❌
❌
❌

Restart
❌
❌
✅
❌
❌
❌
❌

Recreate
✅
❌
✅
❌
✅
✅
❌

Delete
✅
❌
❌
✅
✅
✅
❌

---
---
---
---
---
---
---
---

None
✅
✅
✅
✅
✅
✅
✅

(edited by @lvenier)
NB: If the state is none (therefore, the agent failed to communicate the container's real state), then we prevent any action until it is resolved, as we cannot guarantee anything, except when:

a container is created with operation=create and state=none, which must be valid
the agent updates a container's state, it sets operation=none, which must always be valid

It does not seem possible to add a disabled state to the delete/bulk-delete buttons in Netbox. Therefore, the pre_delete model signal should be intercepted to apply the constraint there.
Changes

[x] :lipstick: Add disabled state on container's extra control buttons
[x] :sparkles: Prevent container model deletion if state is running / restarting
[x] :sparkles: Prevent container model save if state and operation do not pass restrictions check
[x] :white_check_mark: Add test suite to validate container restricted actions

I see an improvement for the next PR : if container operation == "none" then no operation allowed on container


Add a flag to ignore alias prompt

Describe the solution you'd like:
Add a flag to ignore alias, so that user won't be prompted for alias.
Why do you want this feature:
Prompt is not desired in non-interactive mode when used in automation.
Alternatively user can be forced to pass an alias every time even though alias is not really useful in the case of automation.
Just opening a discussion

Thanbks @kishoregv. I agree that alias prompt should only be shown in the interactive mode.
When running with --non-interactive it should not ask for the alias and if it does this is a bug

I will investigate this.

@richardcase Sorry, I have missed the flag. When running with --non-interactive flag it works as expected.
Thanks for the info


Contributing a version compatible with the Jakarta namespace

Implementations: Jersey
Frontend service: HTTP API / ALB
Deployment method: SAM
Scenario
Describe what you are trying to accomplish
We have upgraded the AWS Serverless Java Container library and it is now compatible with the Jakarta namespace. However, we have not been able to implement the multipart functionality. We would like to contribute this work.

@farazhv great to hear that, that will be definitely helpful for other users as well. Can you create a pull request with your changes?

Significant parts of the Java echo system have moved forward towards Jakarta by now. Dropwizard, JOOQ, hibernate and the list goes on. Would be great so see this PR merged and released. Some, but not all, projects have opted for providing two major versions during a transition window, one with javax, and one with jakarta to not have to think about compatibility.

Absolutely, we are already working on it.


[edn] Elevate CSRNG status errors to fatal alerts

I would like to confirm the behavior when EDN encounters csrng errors (csrng_rsp_sts):
1). On the EDN side, upon receiving a csrng_rsp_sts error, it will report to cmd_sts register. But will still distribute the received data to all EDN requesters.
2). On CSRNG side, (only from reading the spec, I do not actually know the simulation results). It seems like CSRNG will fire an interrupt.
I would like to confirm if these behaviors are enough to treat the csrng_rsp_sts error?
@tjaychen @moidx @martin-lueker @mwbranstad
Thanks,
Cindy

it seems like to me that if we encounter this situation, the only way to handle right now is to completely disable / re-enable the entropy complex. (or reboot).
It does feel like however this should be linked into recoverable alerts, but it doesn't seem like that right now.

the only case where the sts bit will be on is when a silicon error occurs, or some attacker is driving this bit on. In other words there is no functional reason that this bit will set. I would probably rate this bit being set as more severe, such as a fatal alert.

@mwbranstad if it's alright with you, i can go in and make that change.
To not disturb things further, we can leave the interrupt and also add the fatal indication.
What do you think?

@tjaychen sounds good, just add function only at this point.

sounds good.
If it is okay with everyone, let us keep this at M3 as Cindy has done.
I don't think this is something we absolutely have to get in now.
Let me know if there are any objections.

The exact same question cam also up during the work for CSRNG V2/V2S (#16516). And I think there are two different questions to answer here:

What should EDN do in case it gets a csrng_rsp_sts error signaled from CSRNG?
When should CSRNG signal a csrng_rsp_sts error to SW/EDN?

The second question is probably better discussed in #16516 which gives some more context. I am thus removing the CSRNG label here.
As for what EDN should do I think the best would be to not distribute the data received upon getting an sts error from CSRNG. AS @mwbranstad right now the sts bit cannot be driven to 1 by CSRNG unless someone injects a fault. But from the spec there might be other reasons to (let's discuss in #16516). What I am getting at is that EDN doesn't need to know why sts got asserted. It's just an upstream error condition that got signaled. And to me it seems that just continuing regular operation upon getting such an error isn't right.

but for random bits already generated and distributed to the EDN fifo's, wouldn't it be okay for them to continue distribution? I do agree though that edn could halt further requests / acks with csrng though.
I guess if we go down this route though, we need to do a check of the edn consumers to make sure that if the edn interface doesn't ack (because something has stopped due to errors upstream), it should actually halt the end point.  For example I don't think keymgr handles this very well right now.

but for random bits already generated and distributed to the EDN fifo's, wouldn't it be okay for them to continue distribution? I do agree though that edn could halt further requests / acks with csrng though.

Probably good to elevate CSRNG status errors to fatal, but we should review what the causes of those errors are in case any of them should not be elevated (not sure what that would be off the top of my head though).  EDN <-> CSRNG req/ack should halt once that error is flagged/reported.
As far as entropy already down the pipe:
One can certainly argue that entropy from the CSRNG already distributed to the EDN prior to the status error is safe to continue to distribute until the EDN runs dry - those entropy samples passed all the relevant checks at the time of whitening/processing and no errors were present at that time.
One could also be ultra-paranoid and take an aggressive flushing posture as soon as any error is detected, but that could prevent tidying-up actions that might want to use entropy (e.g. to clear), which is problematic.  I don't think the ultra-paranoia is justified here but happy to hear other opinions on this posture.  (@mwbranstad / @martin-lueker / @johannheyszl / @moidx)
100% on your non-ack comment, that needs to be halted as it indicates some more serious fault that EDN consumers need to be aware of and handle properly.

P1 sounds right to me @andreaskurth .
I agree with @tjaychen and @cdgori that entropy already inside EDN when the csrng_rsp_sts error is signaled should be okay to distribute. Not sending new requests afterwards , not accepting new entropy coming in from CSRNG after that point would probably be the right thing to do.

SGTM. As we've discussed yesterday, when this case happens, SW must be able to detect and handle it. This may require adding some status bit or even interrupt to EDN.

M2.5 effort estimate:

estimate 16

We've discussed this in the Security WG meeting on Mar 30 2023 and concluded the following:

Without changing CSRNG to actually produce high csrng_rsp_sts bits (see #16516), it makes little sense to fix this for M2.5.
In case CSRNG detects an internal error condition (e.g. invalid command), its main FSM stops and signals a recoverable alert. It stops serving entropy to the EDN eventually. EDN thus doesn't receive entropy after an error condition has occurred upstream (which would have to be signaled using the status bit). This means from a security perspective things are okay.
Given the expected effort and our deadlines, we have agreed to leave this part of the design as is for M2.5.

However, it is also understood that this should be fixed for a future release. I am thus changing the labels accordingly.

FYI @h-filali , this is very much related to the status register work you're currently doing. We should also fix this for production. We should fix this as described in my earlier comment.

@vogelpi thanks for linking me. I suggest the EDN should enter the error state in the main SM upon receiving an status error from CSRNG. It should then signal a recoverable alert and not accept any further data from CSRNG until the whole entropy complex is disabled and re-enabled. This would be needed since continuing normal operation after receiving an error status signal from CSRNG could be catastrophic. A really bad example would be that the generate in boot mode could fail and thus boot entropy could not be delivered while the system keeps on waiting for boot entropy.
Both the error state and the recoverable alerts already exist.
Regarding what happens with the entropy, inside the EDN, which was received before the failure:
currently when the error state is reached the remaining entropy won't be sent out to the endpoints. This is probably solved best by not entering the error state in the ack_sm when certain errors like this one occur. This way, the endpoints can still request entropy while the genbits FIFO is not empty yet. We should make sure however, that the genbits FIFO won't accept any further data when the main SM enters the error state.
The above covers the HW modes (boot and auto mode). For SW mode the sw_cmd_sts signal should be fed through to the sw_cmd_sts register which can be read by firmware. From there it could either be the responsibility of the firmware to restart the entropy complex. In this case the EDN continues operation. Or we could proceed as above for the HW modes. What do you think @vogelpi.

I've already discussed this offline with @h-filali but for others previously involved in this discussion here: This sounds all good to me.
We've discussed to add a new recoverable error state into the main FSM out of which the FSM can get by a disable/enable cycle. The current error state is fatal which is not suitable for the behavior needed here. The Ack FSM we can leave untouched. End points will get the remaining entropy already received but further commands won't be sent out to CSRNG.
Also, some more status/ack bits have to be added for the hardware modes. Similar to the recently added bits to the SW_CMD_STS register. Hakim has come up with a plan for doing this.

@vogelpi - I assume that based on the conversation there might be significant work here. When it is possible could you please update the total effort expected and propagate to the top down + tracker doc. TIA!

@johngt , this is the issue @h-filali is about to finish. No need to update any effort estimates or the tracker doc. The PR is expected to arrive later today.


metrics: add grafana and alertmanager scripts

Signed-off-by: lucklove<EMAIL_ADDRESS>
What problem does this PR solve?
Maintain the grafana and alert manager scripts in PD repo.
What is changed and how it works?
Add grafana and alert manager scripts.
Check List
Tests

No code

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/run-all-tests

Why do we move these files into PD?

Will ansible fetch the rules from PD repo?

/merge

/merge

Codecov Report

Merging #2087 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2087      +/-   ##
==========================================
- Coverage   76.94%   76.82%   -0.12%
==========================================
  Files         194      194
  Lines       19767    19789      +22
==========================================
- Hits        15209    15203       -6
- Misses       3437     3455      +18
- Partials     1121     1131      +10

Impacted Files
Coverage Δ

server/schedulers/balance_leader.go
91.33% <100%> (+0.48%)
:arrow_up:

server/schedulers/balance_region.go
85.15% <100%> (+0.6%)
:arrow_up:

pkg/mock/mockcluster/mockcluster.go
90.19% <100%> (+0.29%)
:arrow_up:

server/kv/etcd_kv.go
75.32% <0%> (-9.1%)
:arrow_down:

server/tso/tso.go
80.29% <0%> (-3.65%)
:arrow_down:

server/member/leader.go
75.51% <0%> (-2.05%)
:arrow_down:

server/grpc_service.go
57.14% <0%> (-1.3%)
:arrow_down:

server/core/storage.go
73.86% <0%> (-1.01%)
:arrow_down:

server/server.go
76.25% <0%> (-0.45%)
:arrow_down:

server/handler.go
51.18% <0%> (-0.44%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576b2e2...b1a4611. Read the comment docs.


java classnotfoundException

We have written the needjava classnotfoundException
when i directly go to the right click of mouse  in the vs
then the run the code has found error java classnotfoundException
before 2days thats work fine
now this process is not working
please resolve my problem large to send. Please paste.

/extJava


Hello could you help me USING PROJECT

Hello could you help me ? I cannot use this project I have same error faced when I run the main_inference.py and Terminal showed
Traceback (most recent call last):
File "c:\Users\Севимли\Desktop\TEST\samurai-master\samurai-master\scripts\main_inference.py", line 11, in
from sam2.sam2.build_sam import build_sam2_video_predictor
ModuleNotFoundError: No module named 'sam2'
this error but I already give right path
from sam2.sam2.build_sam import build_sam2_video_predictor
PLEASE Give me a hend

I'm in the same situation as you. need some help

hi have you successfully install sam 2 following those commands:
cd sam2
pip install -e .
pip install -e ".[notebooks]"

Can you call it in terminal and see if it gives you something


Molecular sieving set as default detection methods

Hi,
In the  psimi/psimitab-parser/src/main/java/psidev/psi/mi/tab/mock/PsimiTabMockBuilder.java
when creating a binary interaction createInteraction( Interactor a, Interactor b ), the detection method is by default set to "molecular sieving" (l.143).
bi.getDetectionMethods().add( new CrossReferenceImpl("psi-mi", "MI:0071", "molecular sieving" ) );
Any reason for this?
Thanks,
Vasundra

Hi Vasundra,
It seems to me that he just wants to create a mock mitab object and adds a detection method from the available ones, without any particular reason for that choice.
John

Thanks John,
If no particular reason, then it would be better to either:

set it to a more generic method - the root (MI:0001) or

to the unspecified one (MI:0686) or

not set it at all (by default) to avoid creating distorted data?

Vasundra

This class was written was testing purposes (this particular example is used only in escapeSpecialCharactersRoundtrip() of the PsimiTabWriterTest class), so not much care was given for the data to "make sense" - there are a thousand other examples in this mocking class where the data inserted do not make "real" sense or are built from random strings...


Expose check_depends

This PR exposes check_depends so people who use this crate can see what dependencies the check function in the pkgbuild relies on.
Closes #1

@fries1234 published as 0.2.1


build cache / tsbuildinfo not used, but why?

TypeScript Version:  4.0.5 / also tested it with 4.1
Search Terms: build cache, incremental build, tsbuildinfo, timestamps
Issue
I'm using github actions for our tests, and would like to make use of the build cache to shorten runtime of the actions. But typescirpt is not using the buildcache. I tried already debugging:

ensuring timestamps are identical  from first job to 2nd job
ensuring tsbuildcache is cached and all output files are too, and cache is restored correclty

What (else) is a factor to consider the build cache to be valid for tsc to re use it? Is there any possibility to debug why it's not using the cache?
On our dev workstations everything is working perfectly.
Expected behavior:
Typescript should use the buildcache
Actual behavior:
It's not using the buildcache

I found some sort of answer, by using "--verbose" flag typescript outputs the reason why it's not using the cache.

Just in any case someone else is running into this too.
I fixed my issue by using https://github.com/MestreLion/git-tools git-restore-mtime toolkit
      - name: Restore mtime for git checkout
        run: sudo apt install git-restore-mtime && sudo curl -o /usr/lib/git-core/git-restore-mtime https://raw.githubusercontent.com/MestreLion/git-tools/v2020.09/git-restore-mtime && git restore-mtime

this allow github actions to utilize typescripts caching strategy!

I've anyone stumpled upon this: see https://github.com/actions/cache/issues/459 for a possible solution


Add Metric-server

To be able to use Horizontal pos autoscaling (https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/), metric-server need to be installed inside the cluster.
May we can add it inside the control plane like cert-manager.

Since this is just a YAML apply, it can definitely go in the same way cert-manager does.
See https://github.com/kubernetes-sigs/metrics-server#deployment for installation steps.

It's not really same as cert manager as it also needs to add args on kube-api server to enable aggregation layer
    jobs:
    - name: control
      properties:
        apiserver:
          flags:
          - enable-aggregator-routing: true
          - requestheader-client-ca-file: /var/vcap/jobs/control/tls/ca/cert.pem
          - requestheader-allowed-names: ""
          - requestheader-extra-headers-prefix: X-Remote-Extra-
          - requestheader-group-headers: X-Remote-Group
          - requestheader-username-headers: X-Remote-User
          - proxy-client-cert-file: /var/vcap/data/k8s/certs/api/cert.pem
          - proxy-client-key-file: /var/vcap/data/k8s/certs/api/key.pem

May we can add this flag by default on api server (I think it's the best choice) or add it only if we enable metrics-server
What do you prefer ? I'll update my PR depending your answer.

I would prefer the latter; if metrics-server is enabled, then we adjust the default set of apiserver flags.


Color lines depending on how old they are

usefull if logging very simular lines for a long time, so you do not have to look at the timestamp to see that the logging on the screen is very old.

No usecase found, closing issue


Compress img size before base64

I think most of the case, we don't need high quality img in our markdown file, as along as the content is readable.
So if we can have one more option to compress the image before save it as base64 format into the markdown file.

Thanks for reporting. I think the best solution here is to allow the user to specify a custom preprocessing command (i.e. a command that is executed before the image is embedded or saved). THis would involve adding the following option:

preprocess_cmd (string, default: nil): Specifies a custom command to preprocess the image before saving or base64 encoding. The command should accept the image file path as input and output the processed image to stdout. For example, to use ImageMagick for compression: "convert -quality 75 - -".

This should bring full flexibility to the user. Thoughts on this @LintaoAmons?

Yeah! Definitely better
I think providing user some sample functions would help a lot. People like me don't familiar with how to deal with pictures, so it would be very kind of you

I'm trying to test on my machine, but I'm facing some errors.
I have tried the main branch and also revert to previous commit, the issue still exists. So I think there's something went wrong with my laptop instead of this plugin.

***%20Error%20creating%20a%20JP2%20color%20space:%20falling%20back%20to%20sRGB

do you have any hints of this error?

Seems like an unrelated issue, yes. Can you switch to the main branch for now and open a new issue?
In the new issue, please post your config, OS and output of ":ImgClipDebug" after the error occurs. Also, try disabling base64 embedding and see if the error persists.