Remove: ManicTime.ManicTime version 2<IP_ADDRESS>

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @tilen-fiser,
Can you please provide the reason for removing this version?

We found out that this package version is in incorrect format. It should start with 23. and not 2023. Because of this, the version updates are not provided correctly.


As an MSSP we want to Connect data from Microsoft 365 Defender to Microsoft Sentinel for large number of customers consistently.

As an MSSP we want to Connect data from Microsoft 365 Defender to Microsoft Sentinel for large number of customers consistently.
Therefore we want to configure using code.
How can we achieve this?

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fb759690-139b-d671-b62e-572d027a0ca0
Version Independent ID: 8d3ade2b-98b7-bbf8-7449-653fc7427abb
Content: Connect Microsoft 365 Defender data to Microsoft Sentinel
Content Source: articles/sentinel/connect-microsoft-365-defender.md
Service: microsoft-sentinel
Sub-service: microsoft-sentinel
GitHub Login: @yelevin
Microsoft Alias: yelevin

@sijday Thank you for your feedback . We use azure-docs repository for documentation enhancement or any bugs in the existing docs. We would like to let you know that we will try to help with information we can find however if it takes longer we would request you to engage support on this.

@sijday Thank you for reaching out to us. Wanted to check are you facing any issue/specific error while connecting data from Microsoft 365 Defender to Microsoft Sentinel.
Let me know if you have any further questions.

No. There are no errors. We just want to enable the connector programmatically for lots of customers without clicking 20 boxes in the portal.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Givary @.>
Sent: Thursday, May 5, 2022 6:42:47 PM
To: MicrosoftDocs/azure-docs @.>
Cc: sijday @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] As an MSSP we want to Connect data from Microsoft 365 Defender to Microsoft Sentinel for large number of customers consistently. (Issue #92486)
@sijdayhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsijday&data=05|01||599dddc990764c515fa108da2ebeab0b|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637873693687816229|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=8lqFd8JH%2FdeHt7K2cdcFaSCh70z3DQwXDOqghTS73BY%3D&reserved=0 Thank you for reaching out to us. Wanted to check are you facing any issue/specific error while connecting data from Microsoft 365 Defender to Microsoft Sentinel.
Let me know if you have any further questions.
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F92486%23issuecomment-1118872955&data=05|01||599dddc990764c515fa108da2ebeab0b|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637873693687816229|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=5Y30LuDuNt9Qp57I5YQXvDA%2FgqPESb7w%2BDXD4CwewBY%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADSACRIXHAPS54LHCLP5IF3VIQCBPANCNFSM5VEY4GCQ&data=05|01||599dddc990764c515fa108da2ebeab0b|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637873693687816229|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=ztuIE4CwI57VoATxeWZPmG82oeKwA1aAKHfSDC8BH%2Fo%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

@sijday Apologies for the delay. Researched on your requirement, I see there is an API to create/update data connectors, you can leverage this option https://docs.microsoft.com/en-us/rest/api/securityinsights/stable/data-connectors/create-or-update.
If this doesnt help, send me an email to<EMAIL_ADDRESS>with Sub - Attn: Givary and following details in the email body:
Link to this thread/post
We can connect offline and discuss further on this.


TabsAndIndents is not handling the indentation correctly on a lambda inside another lambda

I am using

OpenRewrite v8.1.3
Maven plugin v5.2.4

I am using the Maven plugin on a single module project using the following YAML configuration:
---
type: specs.openrewrite.org/v1beta/recipe
name: myRecipe
recipeList:
  - org.openrewrite.java.format.TabsAndIndents
---
type: specs.openrewrite.org/v1beta/style
name: myStyle
styleConfigs:
  - org.openrewrite.java.style.TabsAndIndentsStyle:
      useTabCharacter: false
      tabSize: 4
      indentSize: 4
      continuationIndent: 8
      indentsRelativeToExpressionStart: false
      methodDeclarationParameters:
        alignWhenMultiple: false

N.B. Don't look into the logic of the code since it's just to reproduce the issue.
When processing the following class that is formatted correctly with the Google formatting style in Eclipse:
public class MyClass {
    public static void handleCollection(List<List<Object>> theList, Set<String> validIds, Set<String> validStates) {
        theList.forEach(element -> {
            // Filter internal elements to keep only valid and desired ones
            element.stream().filter(internalElement -> validIds.contains(internalElement.toString())
                    && validStates.contains(internalElement.toString())).forEach(internalElement -> {
                        internalElement.hashCode();
                        internalElement.equals(new Object());
                    });
        });
    }
}

It result in this undesired indentation change that gets flagged as a violation by Checkstyle:
public class MyClass {
    public static void handleCollection(List<List<Object>> theList, Set<String> validIds, Set<String> validStates) {
        theList.forEach(element -> {
            // Filter internal elements to keep only valid and desired ones
            element.stream().filter(internalElement -> validIds.contains(internalElement.toString())
                    && validStates.contains(internalElement.toString())).forEach(internalElement -> {
                internalElement.hashCode();
                internalElement.equals(new Object());
            });
        });
    }
}

My first thought was that indentsRelativeToExpressionStart would control this behavior. However, it seems like this parameter is never actually used in the code!

Hi @BigBeaule ! Thanks for reporting your issue here; would you be able to share how you've configured and are running the rewrite-maven-plugin? That way we can rule out any possible configuration issues.
I'd expect you to pass the style attribute either through -Drewrite.activeStyles=myStyle on the command line, or <activeStyles><style>myStyle</style></activeStyles> in your pom.xml, based on the documentation.

Hi @timtebeek, here's the maven configuration. Nothing too fancy I guess:
<plugin>
  <groupId>org.openrewrite.maven</groupId>
  <artifactId>rewrite-maven-plugin</artifactId>
  <version>5.2.1</version>
  <configuration>
    <activeRecipes>
      <recipe>myRecipe</recipe>
    </activeRecipes>
    <activeStyles>
      <style>myStyle</style>
    </activeStyles>
    <exclusions>
      <exclude>**/*.txt</exclude>
      <exclude>**/*.json</exclude>
    </exclusions>
    <skipMavenParsing>true</skipMavenParsing>
    <failOnInvalidActiveRecipes>true</failOnInvalidActiveRecipes>
    <configLocation>${project.basedir}/rewrite.yml</configLocation>
    <checkstyleConfigFile>${project.basedir}/checkstyle-9.3.xml</checkstyleConfigFile>
  </configuration>
  <dependencies>
    <dependency>
      <groupId>org.openrewrite.recipe</groupId>
      <artifactId>rewrite-static-analysis</artifactId>
      <version>1.0.1</version>
    </dependency>
  </dependencies>
</plugin>

That is indeed how I'd expect things to be configured; that sure starts to look like a bug, especially with that possibly unused https://github.com/openrewrite/rewrite/blob/ad60832bb60e6da996f395d4abb09eb43f298822/rewrite-java/src/main/java/org/openrewrite/java/style/TabsAndIndentsStyle.java#L34
Thank you for reporting this issue in detail here! I'm moving this item to the backlog; would you be open to potentially contribute a fix as well?

Can't make a promise at the moment. I won't be available in July for sure. Then, if an Eclipse dev environment works fine, I'll at least try to figure out a possible fix.


Allow latest command line parameters

Since the latest update a couple of new command line parameters have been added to JSDoc.
This commit aligns the grunt-jsdoc source with the latest jsdoc source to allow the latest command line parameters in the gruntfile options.

I'll not merge it into master but in the 0.6.0 branch

@krampstudio That's what the intention was indeed, the pull request was for the wrong branch. Thanks for sorting it out!

Fixed in f57639f794452d88433010231b9ba764059f54ef
Wait for the release.

Should be fixed in 0.6.2@beta


[jtag,dv] Fix tck acquire/release in jtag_driver.sv

There were two bugs in my code!

The drive_jtag_test_logic_reset function didn't release TCK once the task was finished.

If a request had the reset_tap_fsm bit set then drive_jtag_req would acquire TCK before calling drive_jtag_test_logic_reset.

Thes bugs were causing the rv_dm_tap_fsm test to fail. Fix them!

I think this should be reasonable to merge. The CI failure seems to be a bazel failure:
                Building SW image "//sw/device/tests:entropy_src_kat_test_sim_dv".
                Building "//sw/device/tests:entropy_src_kat_test_sim_dv" on network connected machine.
                Building with command: ./bazelisk.sh build  --define DISABLE_VERILATOR_BUILD=true --//hw/ip/otp_ctrl/data:img_seed=1 //sw/device/tests:entropy_src_kat_test_sim_dv
                /azp/agent/_work/1/s/.bin/bazelisk: FAILED
                sha256sum: WARNING: 1 computed checksum did NOT match
                Opening zip "/root/.cache/bazelisk/downloads/bazelbuild/bazel-6.2.1-linux-x86_64/bin/bazel (deleted)": open(): No such file or directory
                FATAL: Failed to open '/root/.cache/bazelisk/downloads/bazelbuild/bazel-6.2.1-linux-x86_64/bin/bazel (deleted)' as a zip file: (error: 2): No such file or directory
                make: *** [/azp/agent/_work/1/s/hw/dv/tools/dvsim/sim.mk:73: sw_build] Error 36

which seems to say that a file called "bazel" was deleted before we tried to open it. I don't believe that can have been caused by the change in this PR.


Outbound Routes issue - Moving from 1.48 to later versions impacts production

Version greater then 1.48 requires outbound route to be present as individual resources. Splitting the outbound routes into individual resources hangs the terraform plan as the updated provider cannot understand the old config in state file and errors out. The only way to bring up the new format is to delete the existing outbound resource from state file, delete the config from front end and then create the outbound routes again through new format. This process is production impacting.
Can we have seemless way of moving to new structure for outbound routes without requirements of recreating them.
Steps to reproduce:
Create a site with two outbound routes with old provider (1.48)
The state file will have one resource for outbound route.
Now upgrade the provider (1.53)
change the config in terraform to support new format (two outbound resources)
run terraform plan.
Terraform plan errors out - You will see the error as below:
│ Error: failed to read outbound route 8ec1860c-7780-443c-8039-aa17175360cc for site  | error: API Error: 404 - HTTP 404 Not Found (413f4aac-ad03-4e25-adf5-680078799438)
│ {"resourceName":"genesyscloud_telephony_providers_edges_site_outbound_route","method":"GET","path":"/api/v2/telephony/providers/edges/sites//outboundroutes/","statusCode":404,"errorMessage":"API Error: 404 - HTTP 404 Not Found (413f4aac-ad03-4e25-adf5-680078799438)","correlationId":"413f4aac-ad03-4e25-adf5-680078799438"}
Terraform plan is looking for old resource for outbound route and provider is not able to read the format.
To get rid of this error:

delete outbound resource from state file.
remove outbound route from UI
Run terraform apply and two new outbound route resource will be created for 1 site.

Hi @JyotiSharma101
Are you saying that, without defining any genesyscloud_telephony_providers_edges_site_outbound_routes resources in your config, the Terraform command is failing just by upgrading the version?
The routes should stay contained within the sites resource unless you set the env variable "ENABLE_STANDALONE_OUTBOUND_ROUTES". This env variable is supposed to enable the new genesyscloud_telephony_providers_edges_site_outbound_routes resource to ensure backward compatibility. If you do not have this var set, then nothing should break when you upgrade version.
-Charlie

Hello Charlie,
I have added all the steps below with screenshot. Please let me know if you need any further information:
My Terraform genesys provider is at version 1.48 currently.
Below is my outbound route config:
resource "genesyscloud_telephony_providers_edges_site_outbound_route" "SIT_Hatfield-routes" {
site_id = genesyscloud_telephony_providers_edges_site.SIT_Hatfield.id
outbound_routes {
distribution            = "SEQUENTIAL"
enabled                 = true
external_trunk_base_ids = [data.genesyscloud_telephony_providers_edges_trunkbasesettings.PureCloud_Voice_AWS.id]
name                    = "Default Outbound Route"
classification_types    = ["Emergency", "National", "Network"]
}
outbound_routes{
distribution            = "SEQUENTIAL"
enabled                 = true
external_trunk_base_ids = [data.genesyscloud_telephony_providers_edges_trunkbasesettings.PureCloud_Voice_AWS.id]
name                    = "Outbound Route 2"
classification_types    = ["Extension", "International"]
}
}
And it looks like below in frontend:
@.***
Now Next step is to upgrade provider:
required_providers {
genesyscloud = {
source  = "mypurecloud/genesyscloud"
#version = ">= 1.23"
version = ">= 1.48"
}
}
@.***
After this, even if I run terraform plan, it fails as we need to update the config:
$ terraform plan
╷
│ Error: Missing required argument
│
│   on site_outbound_route.tf line 21, in resource "genesyscloud_telephony_providers_edges_site_outbound_route" "SIT_Hatfield-routes":
│   21: resource "genesyscloud_telephony_providers_edges_site_outbound_route" "SIT_Hatfield-routes" {
│
│ The argument "name" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on site_outbound_route.tf line 21, in resource "genesyscloud_telephony_providers_edges_site_outbound_route" "SIT_Hatfield-routes":
│   21: resource "genesyscloud_telephony_providers_edges_site_outbound_route" "SIT_Hatfield-routes" {
│
│ The argument "classification_types" is required, but no definition was found.
╵
╷
│ Error: Unsupported block type
│
│   on site_outbound_route.tf line 23, in resource "genesyscloud_telephony_providers_edges_site_outbound_route" "SIT_Hatfield-routes":
│   23:   outbound_routes {
│
│ Blocks of type "outbound_routes" are not expected here.
╵
╷
│ Error: Unsupported block type
│
│   on site_outbound_route.tf line 30, in resource "genesyscloud_telephony_providers_edges_site_outbound_route" "SIT_Hatfield-routes":
│   30:   outbound_routes{
│
│ Blocks of type "outbound_routes" are not expected here.
Updated config for provider 1.53 as below (split into two resources)
resource "genesyscloud_telephony_providers_edges_site_outbound_route" "SIT_Hatfield-route1" {
site_id = genesyscloud_telephony_providers_edges_site.SIT_Hatfield.id
distribution            = "SEQUENTIAL"
enabled                 = true
external_trunk_base_ids = [data.genesyscloud_telephony_providers_edges_trunkbasesettings.PureCloud_Voice_AWS.id]
name                    = "Default Outbound Route"
classification_types    = ["Emergency", "National", "Network"]
}
resource "genesyscloud_telephony_providers_edges_site_outbound_route" "SIT_Hatfield-route2" {
site_id = genesyscloud_telephony_providers_edges_site.SIT_Hatfield.id
distribution            = "SEQUENTIAL"
enabled                 = true
external_trunk_base_ids = [data.genesyscloud_telephony_providers_edges_trunkbasesettings.PureCloud_Voice_AWS.id]
name                    = "Outbound Route 2"
classification_types    = ["Extension", "International"]
}
Terraform plan hangs for almost 5 minutes and then display failure error:
@.***
So to resolve this – I have to remove the outbound routes from Genesys frontend, Remove them from my state file and then run the terraform apply to get them recreated.
Recreation of Outbound routes is a production impacting activity.
Can we have a solution where upgrade of Provider doesn’t ask to recreate outbound routes?
Jyoti Sharma
Senior Design Consultant
GSD Systems
@.***
Hatfield Business Park, Hatfield Avenue, Hatfield
Hertfordshire, AL10 9TW, United Kingdom
Computacenter (UK) Ltd
T: +44 (0) 0000 000000 M: +44 (0) 7459 611618
E<EMAIL_ADDRESS>www.computacenter.comhttps://www.computacenter.com/uk | Xhttps://twitter.com/ComputacenterUK | LinkedInhttp://www.linkedin.com/company/computacenter | YouTubehttp://www.youtube.com/computacenteruk
From: Charlie Conneely @.>
Sent: 02 December 2024 11:57
To: MyPureCloud/terraform-provider-genesyscloud @.>
Cc: Sharma, Jyoti @.>; Mention @.>
Subject: Re: [MyPureCloud/terraform-provider-genesyscloud] Outbound Routes issue - Moving from 1.48 to later versions impacts production (Issue #1398)
You don't often get email from<EMAIL_ADDRESS>Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
EXTERNAL EMAIL - EXERCISE CARE WITH LINKS AND ATTACHMENTS
Hi @JyotiSharma101https://github.com/JyotiSharma101
Are you saying that, without defining any genesyscloud_telephony_providers_edges_site_outbound_routes resources in your config, the Terraform command is failing just by upgrading the version?
The routes should stay contained within the sites resource unless you set the env variable "ENABLE_STANDALONE_OUTBOUND_ROUTES". This env variable is supposed to enable the new genesyscloud_telephony_providers_edges_site_outbound_routes resource to ensure backward compatibility. If you do not have this var set, then nothing should break when you upgrade version.
-Charlie
—
Reply to this email directly, view it on GitHubhttps://github.com/MyPureCloud/terraform-provider-genesyscloud/issues/1398#issuecomment-2511338137, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BELLUYMXHAHURZ6CQQLNZGT2DRDKLAVCNFSM6AAAAABSXQFZNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJRGMZTQMJTG4.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>
COMPUTACENTER PLC is registered in England and Wales with the registered number 03110569. Its registered office is at Hatfield Business Park, Hatfield Avenue, Hatfield, Hertfordshire AL10 9TW
COMPUTACENTER (UK) Limited is registered in England and Wales with the registered number 01584718. Its registered office is at Hatfield Business Park, Hatfield Avenue, Hatfield, Hertfordshire AL10 9TW
COMPUTACENTER (Mid-Market) Limited is registered in England and Wales with the registered number 3434654. Its registered office is at Hatfield Business Park, Hatfield Avenue, Hatfield, Hertfordshire AL10 9TW
COMPUTACENTER (FMS) Limited is registered in England and Wales with the registered number 3798091. Its registered office is at Hatfield Business Park, Hatfield Avenue, Hatfield, Hertfordshire AL10 9TW
The contents of this email are intended for the named addressee only.
It contains information which may be confidential and which may also be privileged.
Unless you are the named addressee (or authorised to receive mail for the addressee) you may not copy or use it, or disclose it to anyone else.
If you receive it in error please notify us immediately and then destroy it.
Computacenter information is available from: http://www.computacenter.comhttp://www.computacenter.com/
Privacy Noticehttps://www.computacenter.com/en/privacy-notice-art-13-14/

I cannot view these attachments on GitHub. You might have to attach them directly on GitHub instead of replying via email.
I have created a ticket. We will investigate further and see if a resolution can be included in a later version.
(Tracking with DEVTOOLING-970)


Error on first run

I'm running debian wheezy.
I hit this on loading
"_nvim" [New File]
Error detected while processing function NVIM_init..<SNR>11_DefPython:
line    2:
E319: Sorry, the command is not available in this version: pyfile /home/bang/.vim/bundle/nv
im/python/nvim.py

I really hope to get this working. I love the idea. Thanks!

This means your version of vim has been compiled without python (or possibly without the right version). Try installing vim-full

vim-full did not work but vim-python did. Thanks so much for your help. I was a little confused by what you meant by xapian and python, I was looking for python bindings for xapian.  I love how it works!

Sorry, I screwed that up. Like you said, I need the full vim with python bindings, on debian wheezy, to install python bindings it requires installing something vim-gtk', one cannot install vim-python' directly.
Thanks for your help.


Migrate schrddl to cdc integration test for checking DDL logic

Is your feature request related to a problem?
For normal DDL test and concurrent DDL tests
Describe the feature you'd like
Migrate schrddl to cdc integration test for checking DDL logic
Describe alternatives you've considered
No response
Teachability, Documentation, Adoption, Migration Strategy
No response

/area ticdc

/assign @maxshuang


Deprecate one of token_list or opt_token_list

See #1886 for motivation.
Both types are essentially identical, with two irrelevant details. One type could be removed with no impact on users.
Note the member function token_list::existsand the free function validate_list.

I'm not entirely sure any more that opt_token_list and token_list share the same functionality

Yep lets put a pin in this and revisit

@vinniefalco When's the revisting going to happen?

We can look at it together when you are ready


Optimizes Template#_getHtml

Two main optimizations:

The regexs are really bad at predicting where the end of a string
is. This leads to bad performance when using a * quantifier to match
everything to the end. It's much faster to use #indexOf and
#lastIndexOf to find the < and >, and do some comparisons.

https://jsperf.com/html-template-tag-context

String concatenation is much faster than building an array to join
it.

https://jsperf.com/string-concatenation/47

(This even compares an already made array, it's super slow without
even building the array in a loop!)

Wow, these look like great improvements @jridgewell, thanks for the PR!
I have some outstanding PRs that touch this code, so I'll merge their tests with this change and see where we're at. Looking forward for the tests on the tag detection too!

hmmm wanted to test this out...
but it breaks my template here
<button on-click=${(e) => { this.run(); }}>
current output <button>
in this branch (e) => { this.run(); }
so code works fine in the current master but if I take this branch it does not... strange that no test catches this?

I have a test that's broken at master and in the nested branch, but fixed by this change, exactly as pointed out by @jridgewell in the comment about the regexes:
      test('renders attributes bindings after text bindings', () => {
        render(html`

${''}

        `, container);
        assert.equal(container.innerHTML, '

');
      });

@daKmoR this test, in lit-extended_test.ts is passing for me with this change:
    test('renders a function to a property', () => {
      render(html`<button on-click=${(e: Event) => {console.log(e)}}></button>`, container);
      assert.equal(container.innerHTML, '<button></button>');
    });

Can you make a test that fails we can look at?

hey, so apparently it only was a problem in combination
test.only('renders combination of static attributes and click handlers', () => {
	render(html`<div class="test"><button on-click="${(e) => {console.log(e)}}"></button></div>`, container);
	assert.equal(container.innerHTML, '
<button></button>
');
});

that test fails in the optimize-getHtml branch.
Once you rebase to latest master it's already fixed :)

Tests added.

Just did some testing. This is pretty much perf-neutral on the Marko Search Results benchmark, but seem like a win on another boot-speed benchmark I have, which makes sense as this savings is isolated to template creation time. It's also < 20 bytes larger, and fixes a critical but.
Thanks a lot @jridgewell!


[HOLD] Fixed server and client connection attempt with AddPlayer before authentication completes

Fixes this issue: https://github.com/MirrorNetworking/Mirror/issues/3309

Marking this as [HOLD]

At least one change shouldn't be applied because it would break server sending scene msgs to not-yet-authenticated client, e.g. telling it to additively load some content in the offline scene as part of authentication / character selection.
AddPlayer message should already be marked as requiring authentication, so server should reject it until authentication completes.

Confirmed - AddPlayerMessage requires authentication:
NetworkServer.RegisterHandler<AddPlayerMessage>(OnServerAddPlayerInternal);
public static void RegisterHandler<T>(Action<NetworkConnectionToClient, T> handler, bool requireAuthentication = true)
    where T : struct, NetworkMessage

Ok. I'll look into why my AddPlayerMessage goes through without authentication. Maybe I'm overriding something that I shouldn't be in my project, but it's definitely going through for unauthenticated players on my end.

Looking over the PR, it looks like the client methods I changed need their refactors still.

@TCROC I'm happy to discuss this in Discord anytime. :)

OnClientConnect is called from 3 places:

OnClientAuthenticated

FinishLoadSceneHost

FinishLoadSceneClientOnly

Obviously it's fine from OnClientAuthenticated.
For the other two, clientReadyConnection is checked for null before calling OnClientConnect, which is only set in OnClientAuthenticated, so those are both safe as well.
The only "back door" to client prematurely sending an AddPlayerMessage (which would be rejected by server if not authenticated) is in OnClientSceneChanged, and only if the server sent a SceneMessage with SceneOperation.Normal (meaning a non-additive scene, so a full scene change) as part of an authentication process. This is a virtual method, so for such a case, you'd need to override this method and add a check for NetworkClient.connection.isAuthenticated before proceeding or calling the base method.
I'll note here that Mirror doesn't send the normal Offline-to-Online scene message until after authentication completes successfully.

Yep, I am using additive scenes so that is probably why I encountered this. Wouldn't we want to add this logic to handle it in OnClientSceneChanged so it works out of the box on additive scenes?

Yep, I am using additive scenes so that is probably why I encountered this. Wouldn't we want to add this logic to handle it in OnClientSceneChanged so it works out of the box on additive scenes?

Additive scenes aren't a problem already, because we have this in OnClientSceneChanged:

// Only call AddPlayer for normal scene changes, not additive load/unload

if (clientSceneOperation == SceneOperation.Normal && autoCreatePlayer && NetworkClient.localPlayer == null)

{

    // add player if existing one is null

    NetworkClient.AddPlayer();

}

so SceneOperation.Normal is the corner case that gets to AddPlayer.

Ok cool. I'll update the PR to account for the corner case. 👍

Ok cool. I'll update the PR to account for the corner case. 👍

Adding a check for NetworkClient.connection.isAuthenticated to both of those if's would be the acceptable change, but I think you still have an issue in your own code whereby the client is getting a full scene change SceneMessage unexpectedly.

Ok cool. I'll update the PR to account for the corner case. +1

Adding a check for NetworkClient.connection.isAuthenticated to both of those if's would be the acceptable change, but I think you still have an issue in your own code whereby the client is getting a full scene change SceneMessage unexpectedly.

I updated the change.  Let me know if there is anything else needed! :)

Please see suggestions and comments

I added the suggested changes 👍


UI bug: Tab bar content view appears to lose left offset

toying around with current master, after a while this happened:

Wow, nice. Never seen that. Any info about your usage prior to seeing it, so we can reproduce the issue? I'll take a look at the layout code again in case something jumps out at me.

vertp reports same apparent issue:
"I had a wallet already setup, and when I closed and re-opened the app, it went back to normal (asked me for my password)"
"one thing is that I've had mymonero running for a few days minimized, I think when I re-opened"

I experienced a similar issue. It shows up on the "enter password" view as well.

@M5M400 @vertp  You know what? I bet this is a regression caused by https://github.com/mymonero/mymonero-app-js/commit/f8197dcf12b96b27adc5a5336bba5aac5ff42fec


Reimplement most of the removed content

Summary
I am proposing to add the content that had been purged after the 1-23-2023 commit that removed many of the content that was known and loved.
I have not yet looked into why that was done, but upon testing the latest master version, I was disappointed.
See the branch here: Setnour6/EndlessEscapade 1-23-2023_before_purge
Reasonings

This request aims to bring back most of the content that had been removed, that includes the teased content.
The mod will be completed much faster with the amount of content that resides within the mod, specifically the master branch.
Not all of the content on the forked repository branch can be added right away. It can be saved until the content needed decides to be ported.

The point of "removing" the content was to refactor the codebase, as it was definitely not the most pleasant in the slightest.

Who is this? I've never seen this username on our repo before.

Who is this? I've never seen this username on our repo before.

Ex director and creator of the mod, hello!

not you idiot

uni youre so mean

We appreciate your efforts and intentions, but please dont try to interfere within development without any planning knowledge beforehand.

Nonetheless, we appreciate your efforts and intentions, but dont interfere within development without prior planning knowledge. If you wish to contribute try reaching us out, we'll be happy to discuss and clear out points 😉

Nonetheless, we appreciate your efforts and intentions, but dont interfere within development without any prior planning knowledge. If you wish to contribute try reaching us out, we'll be happy to discuss and clear out points 😉

Bouncing off this comment. We work and discuss our project almost exclusively through Discord.
If you would like to join our efforts, please DM me. My Discord username is "tyeski".

I hope you realize we already have access to all previous commits and versions of this repository and previous codebases, regardless of your branch.

I do. I just wanted to make it easier for you to access the files.

Nonetheless, we appreciate your efforts and intentions, but dont interfere within development without any prior planning knowledge. If you wish to contribute try reaching us out, we'll be happy to discuss and clear out points 😉

I'll plan things out through more issues and/or discussions and avoid as much interference as possible.

Bouncing off this comment. We work and discuss our project almost exclusively through Discord.
If you would like to join our efforts, please DM me. My Discord username is "tyeski".

I don't use discord, but since every mod maker I know uses it, I'll think about it. I mainly use Steam.

I'm glad we were able to sort this out. I'll close this issue, but if you have any doubts or require guidance on contributing feel free to open a new issue. Again, consider shooting us out at Discord if you create one by any chance. Thank you!


node-sass version is not correct, please move it to peerdependencies

Type of Issue
[ ] Bug Report
[ ] Feature Request

Description
A bug: please describe the error that you encountered
A feature: please describe your use case and motivation
How To Reproduce
A bug: please include instructions how to reproduce. Issues without reproduction are likely to receive no feedback.
Can you reproduce the error in the integration tests in ng-packagr?
If possible, take a look at the integration/samples and try to break one of these builds!
Is the error you faced in an application importing the library
Try to break the Angular CLI app in integration/consumers/ng-cli!
Expected Behaviour
A bug: please describe what behaviour or result you expected
A feature: do you have a first draft or an idea how to implement?
Version Information
$ node_modules/.bin/ng-packagr --version
ng-packagr: x.y.z
@angular/*: x.y.z
typescript: x.y.z
rxjs: x.y.z
node: x.y.z
npm/yarn: x.y.z

Please include all version numbers that might be relevant, e.g. third-party libraries

sorry for that I figure it out. the problem is node-sass 4.9. the defaultBinaryDir is node_modules\ng-packagr\node_modules\node-sass\vendor
function getBinaryDir() {
  var binaryDir;

  if (getArgument('--sass-binary-dir')) {
    binaryDir = getArgument('--sass-binary-dir');
  } else if (process.env.SASS_BINARY_DIR) {
    binaryDir = process.env.SASS_BINARY_DIR;
  } else if (process.env.npm_config_sass_binary_dir) {
    binaryDir = process.env.npm_config_sass_binary_dir;
  } else if (pkg.nodeSassConfig && pkg.nodeSassConfig.binaryDir) {
    binaryDir = pkg.nodeSassConfig.binaryDir;
  } else {
    binaryDir = defaultBinaryDir;
  }

  return binaryDir;
}


Crash when try to get rtmpSream.videoSettings

Hi!
I have a crash when try to get rtmpSream.videoSettings.
`2016-08-22 14:30:07.099 Example iOS[4615:960666] *** Terminating app due to uncaught exception 'NSUnknownKeyException', reason: '[<lf.AVCEncoder 0x14d8f590> valueForUndefinedKey:]: this class is not key value coding-compliant for the key enabledHardwareEncoder.'
*** First throw call stack:
(0x21c9391b 0x2142ee17 0x21c93629 0x2248a6bb 0x223ebacd 0x2248a8cf 0x2cdf90 0x2213e4 0xa8fb6b 0xa990d5 0x2c9a5c 0x33c70 0x35f34 0x2620cd8b 0x262ca683 0x262ca575 0x262c9929 0x262c955f 0x262c91b5 0x262c912b 0x26208a73 0x242a1bdd 0x2429d385 0x2429d219 0x2429c6e1 0x2429c3b5 0x264c1619 0x21c55d21 0x21c557dd 0x21c53d51 0x21ba3229 0x21ba3015 0x23193ac9 0x26275189 0x2f748 0x2184b873)
libc++abi.dylib: terminating with uncaught exception of type NSException`

@serbintv
Yes.  This is the correct behavior.

"enabledHardwareEncoder" property is macOS only.
It seemes framework versions is older. enabledHardwareEncoder is supported since 0.4.0.

I use framework from git. And just add this line to your IOS example. I don't add this key to videoSettings dictionary.

Sorry. I will fix.

fixed it X)

Thanks for your work.


enh: allow checking to see data are matched but allow for missing fields

adding a mechanism to allow checking that a metadata blob for dandiset or asset has proper values given the schema, but may have missing fields. these metadata objects should be ok for posting but not for publishing.
@dchiquito and @jwodder - would this be useful?

@satra I think it would be more useful to give Dandiset a base class akin to BareAsset that lacks the fields that the server sets.

what this checks is that fields are valid when provided, not if they are required. in fact this explicitly does not care about required. for dandiset this is important at the API level so that metadata can be updated through the UI, and that a user could POST dandiset meta through the API.
i don't think a base class buys us anything in this use case. further fields required can change across schema versions, and hence any base class will also have to support this. a validation function can take that into account a lot more easily than attributes in a class.


handle non-caching of long tags properly

Separating this PR as #5 has some other issues, but this one should be mergable by itself.  An example of the cache failure is in #5 as well.

Current coverage is 84.42%

Merging #6 into master will increase coverage by +0.01% as of 48fed69

@@            master      #6   diff @@
======================================
  Files           21      21
  Stmts         2605    2607     +2
  Branches         0       0
  Methods          0       0
======================================
+ Hit           2199    2201     +2
  Partial          0       0
  Missed         406     406

Review entire Coverage Diff as of 48fed69

Powered by Codecov. Updated on successful CI builds.


Not able to get the preview of KML files.

Hi Team
I have installed the extension as per readme, but I am not able to get the preview. No error is coming either in JS or in CKAN. Are there any dependencies that I need to install for ckanext-geoview to work properly.
The preview is completely blank page. Attaching the screenshot for the same.
Loading... The text is coming and after that, it went blank.

Thanks

Hello Shubham,
I tried that resource on a local instance of mine and it worked fine.
can you share a link to an online CKAN instance that reproduces the problem?

Hi @pduchesne ,
I am also working on local instance only, but if you require I will set up the same in public instance and share the same. The basic difference I am able to see with a working site and my instance are mainly mapconfig options in the inspection of the elements. Is there any dependency on other extension or Framework?

Can you share your ckanext.spatial.* and ckanext.geoview.* values from your config? And your basemaps.json config, if you have one.

@pduchesne
I have not installed the spatial extension, is it required for geoview to work, it's not there in documentation.
ckan.plugins = stats geo_view text_view image_view resource_proxy
ckan.views.default = image_view geo_view
ckan.spatial.srid = 4326
ckanext.geoview.ol_viewer.formats = wms kml geojson

OK, I got it.
There's been a regression causing the default basemap to fail. I'll fix that.
In the mean time, to be able to work with your current install, you'll have to explicitly specify a basemap in your config, f.i. :
ckanext.spatial.common_map.type = XYZ
ckanext.spatial.common_map.custom.url = http://tile.openstreetmap.org/{z}/{x}/{y}.png
ckanext.spatial.common_map.attribution = Map tiles & Data by OpenStreetMap, under CC BY SA.

Hi @pduchesne
Thanks for providing the configuration, it's displaying the display. But default, MAP Viewer(Open Layers) is not getting created for KML files/URLs. Is there any option or configuration entry for default view as MAP Viewer for all the KML files.
P.S.
Configuration entries used are:-
ckan.plugins = stats geo_view text_view image_view resource_proxy
ckan.views.default = image_view geo_view
ckan.spatial.srid = 4326
ckanext.geoview.ol_viewer.formats = wms kml geojson
ckanext.spatial.common_map.type = custom
ckanext.spatial.common_map.custom.url = http://tile.openstreetmap.org/{z}/{x}/{y}.png
ckanext.spatial.common_map.attribution = Map tiles & Data by OpenStreetMap, under CC BY SA.

@pduchesne
Thanks a lot, everything is working fine now. For default view, it was a typo.

Hi @pduchesne
I installed Ckan version 2.9(https://docs.ckan.org/en/2.9/maintaining/installing/install-from-package.html). Then I installed it with the steps on the link(https://github.com/ckan/ckanext-geoview). But I can't preview geojson file and kml file. My config file same the @shubham-mahajan config file.
What kind of way should I go to get it working?
Ps. I just installed the ckanext-geoview plugin.
Config file:
ckan.plugins = stats geo_view text_view image_view resource_proxy
ckan.views.default_views = image_view geo_view
ckan.spatial.srid = 4326
ckanext.geoview.ol_viewer.formats = wms kml geojson
ckanext.spatial.common_map.type = custom
ckanext.spatial.common_map.custom.url = http://tile.openstreetmap.org/{z}/{x}/{y}.png
ckanext.spatial.common_map.attribution = Map tiles & Data by OpenStreetMap, under CC BY SA.


Ensure controllerManager's extra arg allocate-node-cidrs is set to true

in KubeadmControlPlane for Azure clusters.
Checklist

[x] Update changelog in CHANGELOG.md.

Thank you for adding the test case as well :heart:


Update FUNDING.yml

I was approved by GitHub Sponsors.
This PR will add my GitHub account back to the list below.
https://github.com/rubocop-hq/rubocop/commit/dee203c

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Nice!

Thank you! I'd like to add this setting to RuboCop Rails, RuboCop Performance, and RuboCop Minitest.

Sure!


Upgrade to Manifest V3

Migration guide:
https://developer.chrome.com/docs/extensions/mv3/intro/mv3-migration/

Upgraded to support manifest v3 (part of release version 4.0.0).


Fix a Mixin refmap issue, and a handful of smaller things, bumps version

The auto-generated refmap in the mixins.json for this project is based on folder name, unless specified in the build.gradle. Since the default folder when cloning is "AdditionalEntityAttributes", any jars built would look for a non-existing refmap
Changes the name of the mod from "Additionalentityattributes" in the FMJ to "Additional Entity Attributes"
Adds quiltflower as a gradle plugin, which allows for faster and more accurate decompilations
Removes an unnecessary index from the BlockMixin modifyExperience signature

Will fix https://github.com/Noaaan/MythicMetals/issues/160 once implemented.

I was looking for this. TYSM @Noaaan

Modrinth release is out


Fixed additional optimization of often used code

Source.zip
As a result of common efforts in 3 days we achieved impressive result.
Saving of time, additional short-term memory allocation:

File loading 25%, 40%
Tab closing >80%, 100%
Get Text 40%, 100%

Nice, thanks a lot.


Playeranimation not working

What is going on?
All of the player animations are not working,
What should happen?
They should work.
Steps to reproduce

Go ingame
Move, throw, or stand
Observe none of the animations being activated

Hints
PlayerAnimationController File was corrupted

Will be closed in #19


Can I use this in ROS1(Ubuntu 1804)?

Hello , this is a good project! I am using Ubuntu1804 ROS Melodic by distrobox.
Can i just use the src folder to build the project? or it need some drivers?

Hi, I don't understand what you are asking. There is no "project" here in this repo. It is just a set of configuration files. And it is not meant to work with distrobox - it is meant to work with conda, which are two very distinct approaches.

Hi, I don't understand what you are asking. There is no "project" here in this repo. It is just a set of configuration files. And it is not meant to work with distrobox - it is meant to work with conda, which are two very distinct approaches.

i mean if i can use the workspaces/deck_ws/src filses to catkin buildin an Independent Ubuntu ROS environment？not the steamOS

I'm still not quite getting what you want to achieve. The three .repos files in deck_ws/src are just examples of what you can have on the Deck (in particular, it is the workspace content we have on our Deck to visualize data from our robots). You could definitely reuse the audio.repos to install sound_play package so that the Deck can talk to you via a topic, and you could probably reuse jsk.repos which add a bunch of very useful RViz plugins. cras.repos is probably of low value to you as it contains mostly our lab-specific things. In the other two repos, just make sure to replace all noetic-devel with melodic-devel if you're on Melodic.
However, these 3 repos files do not contain any core part of ROS. That is already expected to be installed. If you're looking for a way to install Melodic from source, then follow this wiki: http://wiki.ros.org/melodic/Installation/Source .

Thanks a lot. I may misunderstood your title:steam-deck-ros-controller．
i mistakenly thought it aims to run the steamdeck as a gamecontroller like Xbox to publish cmd_vel msgs ;

Yes, that's possible, but you don't need any workspace for that. See this paragraph from README:

Tap the Steam icon in taskbar, select Settings -> Controller -> Desktop configuration. This menu allows you to configure the gamepad behavior, so that the joy_node can read it. Press X to browse available configs. Select Templates->Gamepad->Apply configuration. Do any other adjustments you like, but do not touch the JOYSTICK MOVE areas. You can't return these values back! What I do is configure L4 as Ctrl+R, L5 as Ctrl+C, R4 as up arrow and R5 as down arrow.

So you just run a normal joy_node and the axes and buttons are published to ROS.


Should resource servers check the token issuer?

Posting this here so I don't forget as I still need to go back and read the RFCs again.
In a network with a single authorization server, the 'iss' in the token will always be the same and everything should be happy. If however you run more than one authorization server which happen to share keys, the value of 'iss' may vary. The spec needs to clearly indicate whether you should or should not check the value of 'iss' at the resource server end, and whether or not this value needs to be coordinated between distributed authorization server instances.

~I recall this being mentioned in one of the documents.~

The Issuer Identifier for the authorization server (which is typically obtained during discovery) MUST exactly match the value of the "iss" claim.

from https://datatracker.ietf.org/doc/draft-ietf-oauth-access-token-jwt/?include_text=1
Reviewing the mentions of iss its certainly not clear in IS-10.
https://tools.ietf.org/html/rfc8725#section-3.8 says to follow the jkws_uri such that you always look at the correct Auth server. Does not limit querying different issuers

Ok. So clearly the resource server needs to check that the 'iss' value matches the location that the public key is sourced from. The spec perhaps needs updating to indicate that:

The 'iss' MUST be the absolute URI which the OAuth metadata can be found from (as per https://tools.ietf.org/html/rfc8725#section-3.8)

For the case where multiple authorisation servers exist in a cluster, the spec could state that the 'iss' must be the same for them all, which would require them to share a common (aliased) hostname, but that rather breaks the 'priority' mechanism. An alternative would be that when resource servers validate tokens they should check if the 'iss' matches any of the hostnames currently listed via '_nmos-auth._tcp'. The challenge there is that if mDNS is being used (or a complex subdomain based unicast DNS setup) then the issuing auth server may not be visible either.

From https://tools.ietf.org/html/rfc7523#section-3, we are allowed to have application specific match of the iss.

An alternative would be that when resource servers validate tokens they should check if the 'iss' matches any of the hostnames currently listed via '_nmos-auth._tcp'

This would help cover the scenario when a new Auth Server of higher priority comes on. Two resource servers with different auth servers would be able to validate each others token.

The challenge there is that if mDNS is being used (or a complex subdomain based unicast DNS setup) then the issuing auth
server may not be visible either.

I think mDNS will be hard to fit under "MUST be an absolute URI" unless we specify it's the IP address to match the issuer. I would not expect to connect to the server over its .local
The DNS should match the aud, if the token is being used in a different subdomain it MUST be rejected. I don't think it would need to be visible.

Having gone back over this I think my greatest concern is around large (potentially multi-site) deployments. If you had two sites, you may wish for the control system in site A to be able to adjust a subset of systems in site B. You could have one Auth Server serving both sites, but this wouldn't be very resilient to WAN link failures. In the case that each site had its own Auth Server they could use their own individual private keys, but both servers could be configured to distribute each other's public keys.
If a Resource Server in site A receives a token from the Auth Server in site B, it can verify the token signature using the public keys it already has, but the iss won't match that of its local Auth Server, and it won't be able to see the remote Auth Server in its local DNS-SD advertisements.
If we assume that iss is always a URI and that all Auth Servers use the same api_* TXT records for their discovery, the Resource Server could request the Auth Server metadata from the remote site and compare with the issuer attribute. It could then proceed to obtain the jwks_uri too if desired. I'm just not sure what additional benefit this provides which the act of signing the token doesn't already. It also places requirements on all Resource Servers being able to communicate with all Authorization Servers.

Couple of questions...
Is it safe to assume we can require Auth Servers to use URL for iss?
Why would Resource Server in site A be able to request the Auth Server metadata from the remote site via its DNS name, but not be able to see its DNS-SD records?

Is it safe to assume we can require Auth Servers to use URL for iss?

No, not unless we require it in the spec.

Why would Resource Server in site A be able to request the Auth Server metadata from the remote site via its DNS name, but not be able to see its DNS-SD records?

Good question. I was envisaging two subdomains which prevent the DNS-SD records leaking, but of course that prevents the A records leaking too. I guess the Auth Servers' A records could be in a third (global) subdomain.
If the scenario seems a bit far fetched then that's fair enough, I'd just like to make sure we've considered how this may impact potential deployments.

No, not unless we require it in the spec.

I was really asking whether it was reasonable for NMOS spec to limit this, when the actual deployed service may be a general-purpose Auth server. If this is something that is always configurable then OK :-)


How should epsilon/tolerance values be organized?

How should epsilon/tolerance values be specified? There can be multiple epsilon values within an algorithm each of which may use different values (e.g. epsilon used or determining if two points overlap may be different than the epsilon used for fuzzy comparing in a distance check).
Currently in C++ they are just hard coded constants but it would be good to have them as part of the API with easy to use sensible defaults.
Currently I think all epsilon values should be explicitly passed to functions and have them be bundled inside of an options struct. The options struct then implements the Default trait with sensible default values, from the consuming side then specific epsilon values (or other option fields) could be changed from the default.

All epsilon values will be explicitly passed inside of options structs that have a sensible Default trait implementation (or by explicit parameter for lower level/simple functions).


[Suggestion]Keep consistent log info after importing one document to collection between Mongo and SQL account

Platform/OS Version: Mac/Windows 10
Architecture: x64
Node.js: 8.9.3
Extension Version:
Repro Steps:

Import one .json file to collection for Mongo and SQL account.
Check the log info after importing successfully.

Actual:
For SQL account, display 'Imported 1 document_s_'.
For Mongo account, display '...Inserted 1 document**s** '.

Suggestion:
Keep consistent log info between Mongo and SQL account.

Add more info:
[Suggestion]Add more specific path of Cosmos DB accounts.


mac cannot run dotnet when i install dotnet

Problem encountered on https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/install
Operating System: macos
Provide details about the problem you are experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

Make sure you run new shell. Check that your path contains dotnet.
If you still face problems, check your installation. Try it again.
If you can, try it on another machine to make sure it is not a one machine problem.
If you still have problems, please provide more details.


vm_launch freezing

vm_launch while trying to start the hypervisor used to instantly reboot my pc, but using the solution in #42 causes my pc to freeze instead of instantly rebooting. CPU is 11900kf.

it's probably just a me problem, rather than cpu-related problem, since the same thing is happening on my laptop


Enforce code styling rules for Node files

Enforce code styling rules for Node files

Looks good  :)

The PR seems to cover not only code style but also some more general cleanup (e.g. unused variables removal). Would be good to add it to the commit message and/or split the whitespace vs non-whitespace changes into separate commits.


[network] Ensure all network metrics/logging record role_type+peer_id

Problem
Currently, it's quite painful to view the prometheus metrics or node logs for network when multiple network instances are running, e.g., a validator is connected to the validator swarm via one instance and their fullnode swarm via another instance. The issue is that many network metrics don't have an extra label/dimension for the network type to ensure that the values aren't accidentally combining. Similarly, most log entries in network don't include the role_type, so it's impossible to disambiguate log entries from multiple network instances. For example, the Rpc cancelled requests metric counts total requests cancelled across all network instances without any way to refine the query to a specific network instance.
Solution
For now, we can probably leverage the enum RoleType { Validator, FullNode }, which we already pass in via config. We need to finish converting from the old OpMetrics catch-all bucket and add role_type labels to each metric. Then we need to propagate role_type to each network component and ensure all logging+metrics include it. Finally we have to update the graphana dashboards to show validator and fullnode network metrics in separate pages.
It might also do to investigate if tokio/tracing could help us here. It looks like we could enter a root span when init'ing the network actor that would log (role_type, our_peer_id, remote_peer_id) for all child spans.

Closing in favor of #4012


Disable backwards compatibility in the config

The backwards compatibility check only allows for languages, not for locales. They have to be 2 characters ('[a-z]{2}'), so locales like nl_NL and es-mx are causing issues.
This fix allows you to disable the backwards compatibility fix.
It solves #20

@tcsehv Thanks for opening the PR!
Could you please set the ensure_backwards_compatibility config for the JsLocalizationControllerTest::testBackwardsCompatibility test? (https://travis-ci.org/andywer/laravel-js-localization/jobs/168536745#L349)

Ping.

Closing that for now.


cmake: Zephyr module processing set modules path

This commit introduces the variable:
ZEPHYR_${MODULE}_MODULE_DIR that can be used for modules to obtain
locations of other modules.
As example: a module which requires the knowledge of mcuboot con now
fetch this information using ZEPHYR_MCUBOOT_MODULE_DIR.
Signed-off-by: Torsten Rasmussen<EMAIL_ADDRESS>

@tejlmand : This moved build/modules to build/zephyr/modules
was this intentional?

was this intentional?

@SebastianBoe actually not.
This happened because the fixed was initially created on a Zephyr fork which had introduced ${CMAKE_CURRENT_BINARY_DIR} instead of mainline ${CMAKE_BINARY_DIR} and I didn't notice that.
https://github.com/NordicPlayground/fw-nrfconnect-zephyr/pull/248/files

was this intentional?

@SebastianBoe actually not.
This happened because the fixed was initially created on a Zephyr fork which had introduced ${CMAKE_CURRENT_BINARY_DIR} instead of mainline ${CMAKE_BINARY_DIR} and I didn't notice that.
https://github.com/NordicPlayground/fw-nrfconnect-zephyr/pull/248/files

Can the old behavior be restored?

Can the old behavior be restored?

https://github.com/zephyrproject-rtos/zephyr/pull/21788


Update botkit

I've updated botkit to version 7.4 and remove studio stuff

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: adantoscano sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for doing this @adantoscano sorry it took so long to merge.

It's ok, you have lots of work with the big release!


missing object type fix

ResultsetInstance was missing the "type" parameter which leads to errors when creating instances.
Tis is an urgent fix w/o any changes to the schema etc. and IMO should directly go into main instead of develop etc.

Yes, this can be considered a hotfix so I agree this is one of the case scenarios in which a PR directly to main is appropriate.

I miss an update to Change.MD in order to notify the change.
However, I'm a little confused that it is not working as it is now (w/o the "type" attribute), as we have tested throught schema validators.
Just tested again with a mock schema and document. Removing "type: object" doesn't raises any complaint from the validator.

@jrambla The missing object type can lead to schema parsers failing to transverse the schema structure. In my testing failed to instantiate an object from the schema. But anyway - should be there as everywhere else.

we need @jrambla approval here to close this PR

This PR requires a review from the current status

These are fixes that won't break the specification, just addressing examples for ageOfOnset, which were including the entry definitions (and the schema don't need to add this information), as well as adding object type for ResultSetInstance (and other format fixes). Still 1 pending review.


Add endpoint to count tokens

Hey @felipelo , my thought was to add /tokenize and /detokenize endpoints to the server, happy to include just an endpoint for counting but let's include it as /tokenize/count or something along those lines.

Hey, can we look into this again? I'm using llama-cpp-python's webserver for an application I'm building and it would be nice to have the tokenizer available as an API. This looks great!

Sorry for the delay, just had to do some cleanup, this will be in the next version.


Coverage for qoqo

Codecov Report

Merging #79 (cc0c3d9) into main (ba4606a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   95.22%   95.22%
=======================================
  Files          14       14
  Lines        2973     2973
=======================================
  Hits         2831     2831
  Misses        142      142

Flag
Coverage Δ

unittests
95.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba4606a...cc0c3d9. Read the comment docs.

a combined coverage report for qoqo and roqoqo is available now.


Upgrade to async-http-client-2.4.1

Continuation of the tragically closed #1642.

Nope.  My bugfix is milestoned for 2.4.2.

Does green travis mean it worked, or was it an intermittent failure?

It means it's the first build to include my upstream bugfix, and that it worked.


Cannot read property 'type' of undefined

Environment data
VS Code version:1.16.1
C++ Extension version:0.13.0
Steps to reproduce
1.Install preinstall \vspreinstall.corp.microsoft.com\preinstall\preinstall.cmd
2.Install vscode
3.Install cingwin32
4.install c++ extension \cpvsbuild\Drops\MDDDebugger\CppTools\20170914.3\Extension\cpptools.vsix

5.Create a folder named test, create a file named main.cpp in test as following:
#include
using namespace std;
int main()
{
cout<<"hello world"<<endl;//set a bp
return 0;
}
6.Compara project with command "g++ -g -o main.exe main.cpp"
7.Open vscode, open test folder, configure launch.json file
8.Set a bp in line cout<<"hello world"<<endl of main.cpp.
9.F5
Expected  behavior
It will hit bp
Actual behavior
It will pop an picture similar to Debug->configure->c++(GDB/LLGDB), F5(or hit mouse) it will pop a error as following:

This repo is for C# for VS Code. I'll go ahead and move your issue over to https://github.com/Microsoft/vscode-cpptools/issues.

This issue was moved to Microsoft/vscode-cpptools#1038

moderator: can you please redact Microsoft internal paths?  @zhangmn799, please don't post those.

Done. Sorry -- I hadn't noticed that.

@DustinCampbell @bobbrow I assume this is CTI filing bugs.

@pieandcakes: It'd be good to let them know that their GitHub account should at least be identifiable. :smile:


all outputs to txt file for show notes

Also, move the file uploading to tts.py for easier workflow.

Closed in #10


New commands: Update-DbaMaintenanceSolution and Save-DbaCommunitySoftware

Type of Change

[ ] Bug fix (non-breaking change, fixes # )
[x] New feature (non-breaking change, adds functionality, fixes #6512, fixes #7072 )
[ ] Breaking change (effects multiple commands or functionality, fixes # )
[ ] Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Unit test is included
[ ] Documentation
[ ] Build system

I added Update-DbaLocalCachedSoftware to be later used by Install-Dba* and Update-Dba* commands for MaintenanceSolution, FirstResponderKit, DarlingData and maybe even more software from Github.

How about Save-DbaMaintenanceSolutionLocalCache ?

Thank you @EitanBlumin - our issue is that it saves a few different community projects -- so more than just maintenancesolution :/

@potatoqualitee okay, so Save-DbaSourceControlLocalCache?

Ouu, i do like that, how about you @andreasjordan ? I guess my only issue is that without Community, I'd wonder if the command was for my own source control, like something with red gate. What do yall think of Save-DbaCommunitySoftware?

I'm fine with Save-DbaCommunitySoftware - only a two part noun and I think that's what it does.

Yeah, sounds good to me too

sweet, ill wait for the change then merge and release, @andreasjordan

Ok, will change that later today...

changing it now 😊

Yes please, thanks - I have no time in the next hours.

I am having issue running update-dbaMaintenanceSolution.  It's not finding the stored procedures.  Sample output below:
VERBOSE: Performing the operation "Update IndexOptimize with script IndexOptimize.sql" on target "my server".
ComputerName : My server
InstanceName : MSSQLSERVER
SqlInstance  : My instance
Solution     : IndexOptimize
Procedure    : IndexOptimize
IsUpdated    : False
Results      : Procedure not installed


logger not firing

I am not sure if this is unique to the disnake library, but the logger.info calls in the else after the try blocks are not being called.
In fact any code added after the await self.client.reload_extension(cog_dir) never gets run ...
I can confirm from log statements in my cog's setup and taredown functions that the extension is being reloaded, it is just strange that nothing after the await runs.
    async def reload(self, cog_dir: str):
        """Attempts to atomically reload the file into the client."""
        try:
            logger.info(f'{self.CBOLD}{self.CGREEN}[Cog Reloaded]{self.CEND} Before') # This one will print correctly
            await self.client.reload_extension(cog_dir)
            logger.info(f'{self.CBOLD}{self.CGREEN}[Cog Reloaded]{self.CEND} After') # This line will never be run
        except commands.NoEntryPointError:
            logger.info(
                f'{self.CBOLD}{self.CRED}[Error]{self.CEND} Failed to reload {self.CBOLD}{cog_dir}{self.CEND}; no entry point found.'
            )
        except commands.ExtensionNotLoaded:
            logger.info(f'Cannot reload {cog_dir} because it is not loaded.')
        except Exception as exc:
            self.cog_error(exc)
        else:
            logger.info(f'{self.CBOLD}{self.CGREEN}[Cog Reloaded]{self.CEND} {cog_dir}') # This line will never be run

I had a similar issue when I initially added support for nextcord, but I thought I had fixed it. To be honest, I'm not even sure why it wouldn't fire. There's nothing blocking it.
I'll take a deeper look and see if I can figure out the root cause.

This should be fixed in v3.2.0 - I tested it on every supported library, but if you run into any issues, let me know.


Support pyFFTW along with PyFFTW3

I couldn't get PyFFTW3 installed on my machine, but pyFFTW is an alternative wrapper for FFTW that appears better maintained.
You can see a speed comparison of the two wrappers here, they're more or less equivalent:
https://github.com/mperrin/webbpsf/issues/10
I'll submit a pull request in <1 week to get it working.

@liujimj, did you ever get around to doing this?

@carlthome https://github.com/grrrr/nsgt/pull/8
@grrrr I'd appreciate additional feedback on the PR

@carlthome See https://github.com/grrrr/nsgt/pull/8
@grrrr Could you please look again at my responses on the PR?


Beta release under review on Chrome Web Store

Received automated email about missing "Privacy Policy" link from Chrome Web Store:

Dear Developer,
We recently reviewed your item, "IPFS Companion (Beta @ 5692c37)," with ID: hjoieblefckbooibpepigmacodalfndh and found that it did not comply with our User Data Policy, which is part of the Chrome Web Store’s Developer Program Policies.
Your item violated the Privacy Policy & Secure Transmission Section of the policy, which requires that: If your Product handles personal or sensitive user data (see the FAQ to find specific examples), then you must: Provide a link to your privacy policy in appropriate field in the Chrome Web Store Developer Console and on the inline installation page (if applicable).If you’d like to re-submit it, please modify the item so that it complies with the policies, then re-publish it in your developer dashboard. Please reply to this email for issues regarding this item removal.
Your item is still published, but is at risk of being removed from the Web Store. Please make the above changes within 7 days in order to avoid removal. Once you have made these changes you may submit and publish a new draft in the developer dashboard. Your draft will be reviewed for policy compliance which typically takes a few business days. If the outcome of the review is successful, your store listing will remain published. If we find additional issues with your item, we will send you another email with details. If you have any questions about this email, please respond and the Chrome Web Store developer support team will follow up with you.
Important Note:
Your item will still be subject to review and may be removed from the store within the warning period. Repeated or egregious policy violations in the Chrome Web Store may result in your developer account being suspended or could lead to a ban from using the Chrome Web Store platform. This may also result in the suspension of related Google services associated with your Google account.
Thank you for your cooperation,
Google Chrome Web Store team

I was really confused because we already had privacy policy link in Detailed description:

Turns out there is a separate field for entire account that was empty, and that triggered automated review. I've updated the field

and resubmitted beta bundle, it should be reviewed within a few days:

Will close this when "under review" flag is cleared.

This specific issue is now solved, but we are still in review due to other reasons: https://github.com/ipfs-shipyard/ipfs-companion/issues/808


XStack layout is slightly off on iOS (works right on Android and Web)

Current Behavior
On iOS putting an icon and text next to each-other in a XStack causes clipping

Expected Behavior
Everything should fit inside of the XStack like it does on android.
Tamagui Version
1.86.6 (but have noticed this for a while)

Platform (Web, iOS, Android)
Web and Android are good, the issue exists just on iOS

Reproduction
"npm create tamagui" to create basic stater template.

Open "packages/app/features/user/detail-screen.tsx"

Directly inside of the <YStack>, starting on line 17 paste:

----
      <XStack>
        <Link size={18} />
        <SizableText backgroundColor={'green'}>
          Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt
          ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation
          ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in
          reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur
          sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id
          est laborum.
        </SizableText>
      </XStack>
----

Add import for Link icon from @tamagui/lucide-icons and add import for SizableText.
Run yarn native, switch to expo go and then run the iOS version... observe the layout on the details page.

System Info
System:
    OS: macOS 14.2.1
    CPU: (14) arm64 Apple M3 Max
    Memory: 572.72 MB / 36.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.5.0 - /opt/homebrew/bin/node
    Yarn: 4.0.2 - /opt/homebrew/bin/yarn
    npm: 10.2.4 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 120.0.6099.216
    Safari: 17.2.1
  npmPackages:
    @babel/runtime: ^7.18.9 => 7.21.0
    @manypkg/cli: ^0.19.1 => 0.19.2
    check-dependency-version-consistency: ^3.0.3 => 3.0.3
    eslint: ^8.21.0 => 8.39.0
    node-gyp: ^9.3.1 => 9.3.1
    prettier: ^2.7.1 => 2.8.8
    turbo: ^1.10.3 => 1.10.3
    typescript: ^5.3.3 => 5.3.3

that's because the SizeableText need to have a non 0 flexShrink value, without that the Text won't resize when there is not enough space.

Thanks for the explanation but how come it behaves differently on iOS and android?


unable to snmpwalk demo.snmplabs.com?

Looks like udp/161 is up but I'm unable to snmpwalk demo.snmplabs.com.
$ nc -v -w 10 -u demo.snmplabs.com 161
found 0 associations
found 1 connections:
     1:	flags=82<CONNECTED,PREFERRED>
	outif (null)
	src <IP_ADDRESS> port 53885
	dst <IP_ADDRESS> port 161
	rank info not available

Connection to demo.snmplabs.com port 161 [udp/snmp] succeeded!

However,
(venv) keshav@atac-vm-t3-115-ubuntu16:~$ snmprec.py --agent-udpv4-endpoint=demo.snmplabs.com --output-file=./snmp_data/public.snmprec --timeout=60 --retries=1
SNMP version 2c, Community name: public
Querying UDP/IPv4 agent at <IP_ADDRESS>:161
Agent response timeout: 60.00 secs, retries: 1
Sending initial GETNEXT request for 1.3.6 (stop at <end-of-mib>)....

SNMP Engine error: No SNMP response received before timeout
OIDs dumped: 0, elapsed: 120.18 sec, rate: 0.00 OIDs/sec, errors: 1
(venv) keshav@atac-vm-t3-115-ubuntu16:~$

So as snmpwalk.
$ snmpwalk -v2c -c public demo.snmplabs.com system
Timeout: No Response from demo.snmplabs.com
$

I can see a minor issue on the server (which has been fixed). Could you please check it out now? It works for me.
Otherwise I suspect a request timeout issue, can you bump it up a bit?

I tried from two machines (on and off corporate VPN) if in case there was an access issue but I see the same result. I collected some packet to verify/make sure the request was going out:
19:39:01.739135 IP <IP_ADDRESS>.57568 > <IP_ADDRESS>.161:  GetNextRequest(21)  .1.3.6
19:41:02.549105 IP <IP_ADDRESS>.57568 > <IP_ADDRESS>.161:  GetNextRequest(21)  .1.3.6

I had the timeout set to 2 minutes even though the snmprecpy didn't return until the end of 4 minutes:
$ ./bin/snmprec.py --agent-udpv4-endpoint=demo.snmplabs.com --output-file=/Users/keshav/snmp_data/public.snmplabs.snmprec --timeout=120 --retries=1
SNMP version 2c, Community name: public
Querying UDP/IPv4 agent at <IP_ADDRESS>:161
Agent response timeout: 120.00 secs, retries: 1
Sending initial GETNEXT request for 1.3.6 (stop at <end-of-mib>)....
SNMP Engine error: No SNMP response received before timeout
OIDs dumped: 0, elapsed: 241.59 sec, rate: 0.00 OIDs/sec, errors: 1
$

I still think you are having some sort of connectivity issue... The service is operational, looking from inside and outside:
$ snmpwalk -Dtransport  -c public <IP_ADDRESS>:161 1.3.6
registered debug token transport, 1
transport:send: 37 bytes to UDP: [<IP_ADDRESS>]:161->[<IP_ADDRESS>]:0
transport:recv: 106 bytes from UDP: [<IP_ADDRESS>]:161->[<IP_ADDRESS>]:0
SNMPv2-MIB::sysDescr.0 = STRING: Linux zeus <IP_ADDRESS>-smp #2 SMP Sun Nov 13 14:58:11 CDT 2016 i686
transport:send: 43 bytes to UDP: [<IP_ADDRESS>]:161->[<IP_ADDRESS>]:0
transport:recv: 53 bytes from UDP: [<IP_ADDRESS>]:161->[<IP_ADDRESS>]:0
SNMPv2-MIB::sysObjectID.0 = OID: NET-SNMP-MIB::netSnmpAgentOIDs.10
transport:send: 43 bytes to UDP: [<IP_ADDRESS>]:161->[<IP_ADDRESS>]:0
transport:recv: 47 bytes from UDP: [<IP_ADDRESS>]:161->[<IP_ADDRESS>]:0
DISMAN-EVENT-MIB::sysUpTimeInstance = Timeticks: (129302987) 14 days, 23:10:29.87

And it's pretty responsive, no need for non-default timeouts...
Is there anything in common between those two machines? May be local firewall? Or the same NAT device (or another firewall) at the edge?

Yeah, they are two separate networks - home computer (going through my ISP) and a work computer going out via a proxy. it is possible both have an access issue. I'll look into it.
Thanks for getting back so quickly!


(HDPro) fixed HDPro being unable to communicate with the HDPro device

Pull Request checklist
Note: these are not necessarily requirements

[ ] I reformatted the code with clang-format
[x] I checked to make sure my submission worked
[x] I am the author of submission or have permission from the original author
[x] Requires update of the PS2SDK
[ ] Requires update of the gsKit
[ ] Others (please specify below)

Pull Request description

Fixed errors in command types for command matrix
Removed extra writes in the EE HDPro probe function
Replaced WaitEventFlag with PollEventFlag (as per the original)
Added a check around PollEventFlag's return value.
DEV9 is now loaded for both HDPro ATAD and ATAD, since HDD.IRX depends on it.

If desired, the HDPro can be probed for by simply loading hdproatad.irx. If it does not remain resident, then the HDPro device was not found.

Special thanks to sonic0467 from psx-place.

Does this also fix the issue reported with cloned network adaptors?  The case we talked about that was reported at ps2-home?
Also, how does one load that IRX file you mention above?  This way I can inform the troops.

No. This is the change set for HDPro.
The clone adaptor stuff is still KIV because I am still discussing things with other individuals who probably know more about hardware driver implementation than I do. It seems like nobody I have met has ever thought that using the old design with the official network adaptor is surely a good thing.
My comment was for developers, since this is the OPL repository. Right now, OPL probes for the HDPro interface from the EE, which contains the exact same code as the HDPro driver module's entry point. Only if the HDPro is detected, then the HDPro module is loaded.
Usually, I/O is done on the IOP, so it may be preferable to keep all I/O code on the IOP.
Previously, the HDPro module could not be safely used to determine whether the HDPro is installed because it would always allocate an event flag. So if the HDPro was not installed, the event flag would have been lost until the next reboot.

When you say HDPro device, what exactly is that?  Is it the HD PRO Network Adapter for PS2 90xxx?  Or something else?  Like the device from Roxio?  Or something else?  When I Google HDPro device, I find many hits, but nothing clear, since many items are named in a similar fashion.

I think you got the idea. It is the add-on HDD kit for  later Slimline models (SCPH-75000 and later). Its driver is actually named the HDCombo driver, so perhaps the two products are related (but I did not care to read up on it).
It is not a network adaptor. It is a hardware mod (involves the ModBo modchip) to give the newer consoles a HDD unit, but it is not as fast and neither is it compatible with the official driver since it is a unique device on its own. When I mean that it is not as fast, it uses PIO mode 0, as it has no support for DMA.
But still, it is a pretty good attempt.

Ah, okay, yes, I've heard of HD Combo and HD Connect, but this is the first time I've heard of HD PRO.  Thanks for the info.  I added that piece of info in the changelog in the OPL Daily Build release today.


Refactor: Remove Redundant Tailwind Config File and Migrate Existing Config to TypeScript

Issue
There are currently two Tailwind CSS configuration files in the project, but one of them is redundant. To resolve this, we need to remove the unnecessary tailwind.config.ts file. Additionally, since the application uses TypeScript, we should migrate the working tailwind.config.js file to TypeScript.
Please assign this issue to me.

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊
You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

Hello @dhairyathedev! Your issue #191 has been closed. Thank you for your contribution!


RMF build error

Bug report
Required information:

Operating system and version:

ubuntu 22.04

OpenRMF installation type:

source install

OpenRMF version or commit hash

we installed it following the instructions on the instructions, current commit hash: 2687cbc59ceb39ff0e3c42c9dc8cb15a80a0ce4b

ROS distribution and version:

we are using ROS humble

ROS installation type:

Installed ROS humble from binary

Description of the bug

While following the install and build instructions, everything is smooth sailing up till "compile using clang" section. We get a build error. This has happened multiple times across multiple laptop and across multiple people building rmf. You can see the error code in the screen shot below.
Steps to reproduce the bug

Install ubuntu 22.04
Install ROS humble
Go to readme of rmf, install rmf for humble from source
When you are in the "compile using clang" and then more on to "compile the workspace" while building the workspace, you get this error

Expected behavior

Expected behavior is that, we should not be getting any build errors
Actual behavior

you can see from the screenshot what is the build error that we get
Screenshots

Additional information

I'm facing same issue. Were you able to solve this @sajidmohd717?

Can I check which version of ignition you have installed?

Can I check which version of ignition you have installed?
ign gazebo --versions

This is probably a bug upstream with gazebosim.
(also if you just want to build without support for the new gazebo it should be possible via --packages-skip rmf_building_sim_gz).

I have 6.14.0 installed. Will installing Gazebo Garden fix this issue?

I have 6.14.0 installed as well.

I just completed a fresh build without issues, and our chron job also built it without issues, https://github.com/open-rmf/rmf/actions/runs/4301518131/jobs/7498836565#step:4:15669
I currently have libignition-plugin at 1.4.0-1~jammy and libignition-utils1 at 1.5.1-1~jammy. With the rosdep step it should help install all required dependencies as well. I would suggest these few sanity checks,

compare the library versions I mentioned using dpkg -l | grep libignition
try again after an update-upgrade, sudo apt update && sudo apt upgrade
uninstall ignition, and re-install again, before trying again

Will installing Gazebo Garden fix this issue?
No, I currently only have Fortress installed and we target that only too, so it won't help.

I managed to reproduce and resolve this issue with these few steps, hope they work for you as well:

Remove all ignition packages: sudo apt remove libignition-* + sudo apt autoremove
Reinstall them via rosdep in the rmf workspace: rosdep update + rosdep install --from-paths src --ignore-src --rosdistro humble -y
Update-upgrade as aaron has suggested: sudo apt update && sudo apt upgrade
Clean build up to rmf_building_sim_gz_plugins and rmf_robot_sim_gz_plugins separately instead of building the entire workspace at one go: colcon build --mixin release lld --packages-up-to <package-name-here>.
If one works and the other doesn't, remove the package build/install files, e.g. rm -rf build/rmf_robot_sim_gz_plugins install/rmf_robot_sim_gz_plugins, before trying again
Then go ahead and build the rest of your workspace as usual

Not entirely sure why building them separately worked for me

I have 6.14.0 installed. Will installing Gazebo Garden fix this issue?

No garden is not yet supported on RMF's main branch. We will have to investigate this failure. In the mean time I recommend using gazebo classic and skipping the build of the affected package.

I believe I faced the same issue previously mentioned here open-rmf/rmf_simulation#96. It seems that the issue is from the a lower version of the libignition-cmake2-dev being installed.
libignition-cmake2-dev:
  Installed: 2.14.0-2~jammy
  Candidate: 2.16.0-1~jammy
  Version table:
     2.16.0-1~jammy 500
        500 http://packages.osrfoundation.org/gazebo/ubuntu-stable jammy/main amd64 Packages
 *** 2.14.0-2~jammy 500
        500 http://packages.ros.org/ros2/ubuntu jammy/main amd64 Packages

Simply upgrading this apt package to the candidate version was sufficient for me to resolve this issue.

It seems that the issue is due to a lower version of the libignition-cmake2-dev being installed.

You're right, having a version of libignition-cmake2-dev which is not 2.16.0-1 causes this error, and reinstalling Ignition Fortress fixes it.
The build finishes, but with error SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools in some packages. I also found fastapi and uvicorn weren't installed in my system.
A workaround is:
pip install setuptools==58.2.0
python3 -m pip install flask-socketio fastapi uvicorn datamodel_code_generator

Build again and it should work fine.
I am, however, facing issue with the RMF web Panel where nothing appears in the 'request type' dropdown.
I suggest editing readme to make it easier for others to build from source. Happy to do so.

Contributions are welcome, however the README already asks you to install the python dependencies you mentioned. As for the setuptools deprecation warning, its fine as I believe there is still time till setuptools becomes unsupported. By which time we will hopefully have a way to create python projects without setuptools in ROS.


feat: recheck cpk status

:tada: This PR is included in version 2.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Coloring broken when using .class

Tien, this fix might be similar to the other change recently made (i.e. ensure there is no "." before the keyword that starts the match on the class pattern (?<!\...  )


references from comments

Do you plan on adding the query of all references not just those in body, all references in comments

+1 on the feature
AFAIK one can check for references via the issue timeline (https://developer.github.com/v3/issues/timeline/)

ah yes, the cross-referenced event.  Using this api would be a lot better than what's currently being done (parsing the issue bodies).
Honestly, this whole project needs an update.   I created this years ago when I was first learning javascript.  I might have time to come back to it and add this in early next year.

Seems the api has also improved

Yeah, it is a preview: https://developer.github.com/changes/2016-05-23-timeline-preview-api/
ps: just in case: GitHub API Comparison: Issue Events vs Issue Timeline

@hjylewis @benblair would there be any chance that you would still add this?
I'm really looking forward to using this tool to visualize my issue dependencies, but all references are in the comments...

@stivni I am not actively working on this project right now but would be open to pull requests that add this functionality.


Compatibility

Is this plugin compatible with windows7

No.
This package use Microsoft Webview2, and it doesn't support win7.
https://learn.microsoft.com/zh-tw/microsoft-edge/webview2/


Improve docs and tests for model.save() / model.load()

[ ] Document which state is preserved and not preserved when model is reloaded
[ ] Add tests to ensure that the state that is documented to be preserved is actually preserved

Original question:
Is there a test to make sure that if I stop training, save the model, reload it from file, and continue training, the result will be identical compared to what would happen if I didn't stop training at all? I am mostly concerned about obscure state such as optimizer's internal variables.

Hello,

I am mostly concerned about obscure state such as optimizer's internal variables.

that is a good question. I think there are different things that are not currently stored which prevent a perfect recover from previous training:

the content of replay buffer is not saved for off-policy methods (for disk usage reason)
the state of the optimizer (e.g. Adam) is not saved
the learning rate schedule may be reset when reloading a model / resuming training

However, despite those caveats, I did not experience huge drop in performance (yet) when resuming training.

Hm. Does the following sound good:

Close this issue
Open more issues:

"Document which state is preserved and not preserved when model is reloaded"
"Add tests to ensure that the state that is documented to be preserved is actually preserved"

?

I don't know, I would maybe keep that issue, what do you think @hill-a , @erniejunior or @AdamGleave ?

I think it makes sense to keep this issue open but maybe break it into a task list.

Any update for resuming training in an unexpected crash case?
And I also found that set reset_num_timesteps=False in the learn function cannot create a continuous Tensorboard curve after broken, any suggestion?
This is my code
env = gym.make('CartPole-v1')

trpo = TRPO(
    MlpPolicy, env,
    timesteps_per_batch=512,
    max_kl=0.001,
    cg_iters=10,
    cg_damping=1e-3,
    entcoeff=0.0,
    gamma=0.99,
    lam=1.0,
    vf_stepsize=1e-4,
    vf_iters=3,
    tensorboard_log='./tmp_tb_logs',
    verbose=1, n_cpu_tf_sess=None)
trpo.learn(total_timesteps=5e4)
trpo.save('./tmp_models/trpo_cartpole')

del trpo

trpo = TRPO.load('./tmp_models/trpo_cartpole', env=env)
trpo.learn(total_timesteps=10e4, reset_num_timesteps=False)

+1 to continuation of tensorboard logging. when reset_num_timesteps=False

Has there been any update to this? Checkpoint files are still missing significant data required to resume training, defeating the purpose of a checkpoint file.

@mpgussert
Not in stable-baselines, but in stable-baselines3 the code saves all parameters (including optimizer parameters and replay buffer, if so desired).

yep!  i realized very quickly that i was mistaken.  sorry!

Fixed in SB3: https://github.com/DLR-RM/stable-baselines3/issues/435


AP-2241 LASPO page

What
Link to story
Added controller, view and rspec tests for the LASPO page
Added new column to legal_aid_application to record response
Updated the flow so this page is only triggered if Section 8 proceedings have been selected
Updated the CYA page and merits report to show the response to the LASPO question (only displays if the application has S8 proceedings)
Checklist
Before you ask people to review this PR:

[x] Tests and rubocop should be passing: bundle exec rake
[x] Github should not be reporting conflicts; you should have recently run git rebase master.
[x] There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
[x] The PR description should say what you changed and why, with a link to the JIRA story.
[x] You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
[x] You should have checked that the commit messages say why the change was made.

Codecov Report

Merging #2554 (1de4d47) into master (19c0785) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2554   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          518       520    +2
  Lines        10324     10348   +24
=========================================
+ Hits         10324     10348   +24

Impacted Files
Coverage Δ

...rollers/providers/in_scope_of_laspos_controller.rb
100.00% <100.00%> (ø)

...s/legal_aid_applications/in_scope_of_laspo_form.rb
100.00% <100.00%> (ø)

app/models/legal_aid_application.rb
100.00% <100.00%> (ø)

app/services/flow/flows/provider_start.rb
100.00% <100.00%> (ø)

config/routes.rb
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19c0785...1de4d47. Read the comment docs.


feat: add banned-hooks rules for client and server components

BREAKING CHANGE

Description
This PR refactors our eslint rules that ban hooks in different context (server and client).

Combines all the banned server hooks into a single generic rule
Adds a similar rule for client components that supports checking for useQuery on the client (see https://github.com/Shopify/hydrogen/pull/870)
Removes the existing specific rules

This is a breaking change and will add a changeset once I get a general approval. Note: The Docs for this package do not exist on shopify.dev.
Before submitting the PR, please make sure you do the following:

[x] Read the Contributing Guidelines
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
[ ] Update docs in this repository according to your change
[ ] Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

Does it only work in standalone apps?

There is a contributing doc in the .GitHub folder in this package with instructions. They likely need a bit of updating, but I think the general idea should still work for testing locally.
I haven't had the chance to test this PR locally yet, but will before merging.

@frandiox added some updated docs for local testing.
https://github.com/Shopify/hydrogen/blob/v1.x-2022-07/packages/eslint-plugin/.github/CONTRIBUTING.md

Love this PR. Would love to see this in Hydrogen soon @cartogram!


Fix for //tensorflow/python:stateful_random_ops_test

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

jenkins: ok to test


Updating version to 0.2.2.

Release notes:

Added optional stream argument to requests.Download. If uses, the downloaded resource will be written directly to the stream in 8KB chunks, rather than being read into RAM. (#20, #21)

/cc @tseaver

I spent about an hour this morning trying to get a "read" of one of those 8K chunks to fail, so we could figure out what retries might look like, but I had no luck.

OK I am dumb, the call to _process_response needs to happen before writing to the file because it actually verifies the response is valid. DERP!
Luckily I killed the build before 0.2.2 was pushed, so I can just "paper-over" that release.


Rewrite <Input> and <TextArea> components to be fully controlled

Since our state updates are async, it creates a race condition where React cannot correctly diff the updates and it results in the cursor being pushed to the end.
See this React issue: https://github.com/facebook/react/issues/955 In short, just another React annoyance.
Fixes #237

Note that https://github.com/lukechilds/hyperdex/commit/26eab29feaeb6a4913f04074e7c15019b24d9e07 overrides this fix for number inputs. So number inputs will not be fixed for this issue until React fixes it. It's impossible to fix both.


owasp-zap-250-update

Cask: owasp-zap.rb
Updated version and checksum for 2.5.0
https://github.com/zaproxy/zaproxy/releases/tag/2.5.0
Changes to a cask
Editing an existing cask

[x] Commit message includes cask’s name (and new version, if applicable).
[ ] brew cask audit --download {{cask_file}} is error-free.
[ ] brew cask style --fix {{cask_file}} left no offenses.

I'm unable to complete the later 2 as I'm not on an OSX system, nor do I have access to one. However, I am part of the ZAP core team and am try to facilitate for our users :smiley:

Also, check out cask-repair, it makes Cask updates like this quite easy (details in CONTRIBUTING)

This has a few errors so I'll fix them in a new PR, shortly

@adidalal thanks. What else was wrong? Was there something wrong in the 2.4.3 version because it seemed like a simple replacement to me. I know my original PR had the shasum in all caps which caused an issue but I did fix that.
I'll ask the others on the ZAP team if we can setup an audomated job to leverage cask-repair when we publish new releases.


Allow override of searchkick options

Although the after_initialize helps on first load (by deferring until after the application code, with any overrides, has been loaded as well) on subsequent code reloads (after save in development) it does not delay the execution of that line. Which means the solidus_searchkick default searchkick options are used.
By moving these options to an initializer we can accomplish the same goal, of loading them only once, while still giving users a path to configuring them for their own app and avoiding the code reload race.
I don't see a great way to test this, but I'm open to ideas 😉

Thanks @thejbsmith and sorry for not getting back to you sooner. Don't worry about rushing to merge anything, I run on my own fork with some minor changes, but I'd love to contribute back what I can (trying to figure out a way to share aggregate counts back).
I've updated the readme and changelog and bumped the minor version. Anyone with their own searchkick declaration in a model decorator will still be fine.

Ah, that's why the lockfile was in there. I have to attend to important Friday afternoon matters, but I'll come back to fix this build soon 😉

Sounds good. Aggregates would be a great feature to get added. I had looked into a little bit since we had clients that wanted that feature, but we ended up going a different route and I didn't get a chance to finish any of the work on aggregates. Didn't really like the way I initially did it either, so that didn't help either.

Searchkick doesn't make it very easy, since if you add params[:searchkick_options][:aggs] searchkick will interpret them however it feels and I found that I needed to massage the elasticsearch query to get the filter control I needed.


Information on migration behaviour

This page doesn't make it clear what will happen to the old resources & subscription in the old tenant if it contains resources that are not supported for migration to a new tenant? Does the old subscription remain containing the unsupported resources, or does it get deleted?
Example if Cosmos DB cannot be moved from one tenant to another, what happens to the Cosmos DB when I move the subscription?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9afab524-67c2-2e76-fd7a-46238cb9d249
Version Independent ID: ae2da577-6026-f322-1c09-dbcc6068c01a
Content: Transfer an Azure subscription to a different Azure AD directory
Content Source: articles/role-based-access-control/transfer-subscription.md
Service: role-based-access-control
GitHub Login: @rolyon
Microsoft Alias: rolyon

@Evi-P
Thanks for your feedback! We will investigate and update as appropriate.

@Evi-P
Thanks for your feedback! We will investigate and update as appropriate.

@Evi-P
Thank you for your question!
If your Cosmos DB can't move to a different tenant, but you migrated your subscription to this new tenant, your Cosmos DB and all other services in your current tenant will simply be disabled (not deleted). For example, that means your virtual machines are de-allocated, temporary IP addresses are freed, and storage is read-only.
This is because multiple subscriptions can trust the same Azure AD directory. However, each subscription can only trust a single directory.
For more info:
What happens after subscription cancellation?
Associate or add an Azure subscription to your Azure Active Directory tenant
I'll go ahead and assign this issue to the author to update the docs as needed.
Thank you for your time and patience throughout this issue.

@Evi-P
Thank you for your question!
If your Cosmos DB can't move to a different tenant, but you migrated your subscription to this new tenant, your Cosmos DB and all other services in your current tenant will simply be disabled (not deleted). For example, that means your virtual machines are de-allocated, temporary IP addresses are freed, and storage is read-only.
This is because multiple subscriptions can trust the same Azure AD directory. However, each subscription can only trust a single directory.
For more info:
What happens after subscription cancellation?
Associate or add an Azure subscription to your Azure Active Directory tenant
I'll go ahead and assign this issue to the author to update the docs as needed.
Thank you for your time and patience throughout this issue.

Thank you @JamesTran-MSFT!

Thank you @JamesTran-MSFT!


Adding Data Acquition, Web Scraping and Preprocessing notebooks

These notebooks contain the code for data gathering and preprocessing the text for further use.