Support for implicit contextual parameters

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
The logger requires explicit parameters.
Expected behavior
Having the ability for logs to be augmented with implicit contextual information, e.g.:
interface ContextualInformationResolver {
  resolveContextualInformation(): Promise<Record<string, unknown>>;
}

@Injectable({
  providedIn: 'root'
})
class MyContextualInformationResolver implements ContextualInformationResolver {
  async resolveContextualInformation(): Promise<Record<string, unknown>> {
    return {
      // context
    };
  }
}

The contextual information would not used in the log message itself but rather as a separate context (that could still be used when formatting the log though, just like a timestamp).
Minimal reproduction of the problem with instructions
n/a
What is the motivation / use case for changing the behavior?
There is often information that would be useful to see with a log message but is not readily available where the message is logged (not to mention it could lose some of its structure if passed in the message itself).
Typical use cases would be:

a correlation identifier
a span/parent identifier
(not relevant if the library is only used on the front-end) a user identifier, a tenant identifier, etc.

This can make it much easier to filter logs based on such information without having to pass it manually each time a log is created in the user code.
Some examples:

Node implementation (using continuation local storage)
Logback (JVM logger implementation, using thread local storage)

Moreover, most protocols/tools related to logging support passing such contextual information (e.g. Logstash, Kibana, etc.).
Environment
n/a

Thanks for your suggestion, @rraziel.
Do you imagine such a resolver to called for each log entry? If so, we would lose the ability to log synchronously. We really don't want our logs to become a bottleneck.
If we buffered log messages to keep a synchronous API and resolved the context asynchronously, the context would be gone before we could resolve it.

I made it return a Promise in the example but that's mostly because... habits 😅
I'm pretty sure a synchronous resolver would work for 99.9% of use cases.
But yes it would be called for each log entry.
In most other libraries that have something similar, the resolver is done when logging - otherwise you'd indeed no longer have access to the information needed anyway - but then the built "full" log message (message, parameters, context, timestamp, etc) are put in a buffer/queue.
Actually, going even further than the no-need-for-asynchronous-resolver, it probably wouldn't any difference (when it comes to real world scenarios) if it was a simple Map<string, unknown>-like API exposed by the library.
This way the user code is limited to setting values (no possibly expensive computation from the resolver) and the library knows when the values change if that's something useful (such as avoiding copies).

I actually don't nderstand what the Record or Map is for. Is it a correlation ID -> context map?
Could you explain your last two paragraphs more in detail?

The basic idea:
function main() {
  logger.set('correlationId', uuid());
  logger.set('userId', 'abcd');
  logger.log('hello world'); // { message: 'hello world', context: { 'correlationId', 'xx', 'userId': 'abcd' } }
  logger.log('hello again'); // { message: 'hello again', context: { 'correlationId', 'xx', 'userId': 'abcd' } }
}

Here the example is fairly self-explanatory I think: you get a contextual map of data you don't need to know about when logging a message, I'm pretty sure that part was understood already.
Now in classical multi-threaded, synchronous code (i.e. not the browser or Node), that logger.set() would use thread-local storage: each thread gets its own independent version of the contextual map, and when a message is logged it will automatically pick the "right" contextual map based on the current thread.
So for example when handling requests:
let counter = 0;
function onRequest() {
  logger.set('correlationId', ++counter);
  doSomething();
  logger.log('hello');
}

You won't have issues with concurrent requests because, even though they may be running in parallel, logger.set() will save the value using a thread-local map rather than global, so in practice you have no issue, e.g.:

[req1] enters the function
[req1] logger.set, which is bound to thread-1
[req1] doSomething()
[req2] enters the function
[req2] logger.set, which is bound to thread-2 (so it does not override the value in thread-1)
[req2] doSomething()
[req1] doSomething() has returned, logger.log logs a message that will use the map from thread-1
[req2] doSomething() has returned, logger.log logs a message that will use the map from thread-2

{ "message": "hello", "context": { "correlationId", 1 } }
{ "message": "hello", "context": { "correlationId", 2 } }

Now the same example with asynchronous code and a single thread:
let counter = 0;
async function onRequest() {
  logger.set('correlationId', ++counter);
  await doSomething();
  logger.log('hello');
}

If two requests arrive at roughly the same time, you will eventually override the context value and pick the "wrong" (or latest) value instead when logging, e.g.:

[req1] enters the function
[req1] logger.set, which is global (or local to the logger, does not really make a difference)
[req1] doSomething()
[req2] enters the function
[req2] logger.set, which is global and thus overrides the one done on step 2
[req2] doSomething()
[req1] doSomething() has returned, logger.log logs a message that will use the global map (so the 2nd set)
[req2] doSoemthing() has returned, logger.log logs a message that will use the global map (so the 2nd set)

{ "message": "hello", "context": { "correlationId", 2 } }
{ "message": "hello", "context": { "correlationId", 2 } }

One way around this is to use continuation local storage, which will basically bind the contextual map to the sequence of asynchronous calls, so when you log something it'll pick the "right" context map.
I hope that's a bit clearer.

Thank you for your explanation, @rraziel.
Please feel free to continue improving API drafts and possible solutions for this proposal.

Hi @rraziel,
We have added the option to attach log payloads with application- or log driver-defined properties in Lumberjack version 2 (currrently at 2.0.0-rc.0). We added LumberjackLogger and ScopedLumberjackLogger as well as LumberjackLogBuilder to make it easier to add payload and other log properties.
What do you think? Can this be used to do what you're asking for?

Hi @rraziel,
We have added the option to attach log payloads with application- or log driver-defined properties in Lumberjack version 2 (currrently at 2.0.0-rc.0). We added LumberjackLogger and ScopedLumberjackLogger as well as LumberjackLogBuilder to make it easier to add payload and other log properties.
What do you think? Can this be used to do what you're asking for?

Ahoy,
I think it helps for the lower-level part (i.e. drivers being able to forward that information to wherever they're storing/sending it) and for some cases where you want to send structured data with a log message, although those tend to have a schema per log message rather than a global one.
But for contextual information from user-land, it'd still require passing the information in every single message, whereas above I mentioned a context that could be set on the logger and attached to all logged messages:
logger.set('userId', '1234');
logger.set('siteId', '5678');
logger.set('spanId', '9abc');
logger.set('parentSpanId', 'def0');

logger.log('x'); // also logs the userId/siteId/etc

The tricky part being asynchronous behavior potentially changing that contextual information while using the same logger.

Ahoy,
I think it helps for the lower-level part (i.e. drivers being able to forward that information to wherever they're storing/sending it) and for some cases where you want to send structured data with a log message, although those tend to have a schema per log message rather than a global one.
But for contextual information from user-land, it'd still require passing the information in every single message, whereas above I mentioned a context that could be set on the logger and attached to all logged messages:
logger.set('userId', '1234');
logger.set('siteId', '5678');
logger.set('spanId', '9abc');
logger.set('parentSpanId', 'def0');

logger.log('x'); // also logs the userId/siteId/etc

The tricky part being asynchronous behavior potentially changing that contextual information while using the same logger.

The log payload is not necessarily meant to have a global interface across the application. Loggers--that is services extending LumberjackLogger or ScopedLumberjackLogger--can have a static payload or resolve one at log creation time and they have access to dependency injection to retrieve this information.
The LumberjackService is even more low level and can be combined with the LumberjackLogBuilder so it should be possible to fit services to your need. Let us know if you do experiments with any of this, we'll be happy to give feedback.

The log payload is not necessarily meant to have a global interface across the application. Loggers--that is services extending LumberjackLogger or ScopedLumberjackLogger--can have a static payload or resolve one at log creation time and they have access to dependency injection to retrieve this information.
The LumberjackService is even more low level and can be combined with the LumberjackLogBuilder so it should be possible to fit services to your need. Let us know if you do experiments with any of this, we'll be happy to give feedback.


Adding tagging support for securityGroup

Changes done:

Adding tagging support for securityGroup.

tags changed from {"ManagedBy":"alb-ingress"}, to {"kubernetes.io/cluster/clusterName":"owned", "kubernetes.io/namespace":"namespace", "kubernetes.io/ingress-name":"ingressName"}
tags from default-tags flag will take effect
tags from alb.ingress.kubernetes.io/tags annotation will take effect

Make tags from alb.ingress.kubernetes.io/tags annotation take effect during reconcile for ALB & targetGroup(users can add/remove tags)
Move securityGroup related logic into sg package.

Testing Done:

add / remove tags with alb.ingress.kubernetes.io/tags
change between managed securityGroup and external securityGroup
add / remove listener ports and watch the permission change in managed lb securityGroup
change inbound cidr and watch the permission change in managed lb securityGroup

/lgtm

Might be worth mentioning in the release notes about the IAM policy changes required with this release. Tested an upgrade and ran into an issue.

failed to reconcile securityGroup associations due to failed to reconcile managed LoadBalancer securityGroup due to failed to reconcile tags due to UnauthorizedOperation: You are not authorized to perform this operation

Might be worth mentioning in the release notes about the IAM policy changes required with this release. Tested an upgrade and ran into an issue.

failed to reconcile securityGroup associations due to failed to reconcile managed LoadBalancer securityGroup due to failed to reconcile tags due to UnauthorizedOperation: You are not authorized to perform this operation

Sorry for the trouble caused. I'll update the release note to reflect this


Updoot

,,,

Codecov Report

Merging #3 into master will increase coverage by 7.62%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   91.75%   99.38%   +7.62%
==========================================
  Files           7        6       -1
  Lines         570      487      -83
==========================================
- Hits          523      484      -39
+ Misses         47        3      -44

Impacted Files
Coverage Δ

lib/steamdata-utils.js
100% <ø> (ø)
:arrow_up:

lib/steam-settings.js
100% <ø> (ø)
:arrow_up:

lib/index.js
98.68% <100%> (+13.68%)
:arrow_up:

lib/steam-paths.js
100% <100%> (+7.86%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc94c9...a57b0a6. Read the comment docs.


Fix null aliases in API responses

Feature Request / Bug
Desired behaviour
Spun out of #2654
Currently the response value of aliases is null in requests for a workflow, tool, organization, etc. However, querying directly by alias still returns the corresponding object. So aliases are correctly stores, but improperly displayed in API responses. This is primarily due to lazy loading and will become an issue when we hook up aliases to the UI. Fix should include solution for all object types with aliases.
Steps to reproduce the behaviour

Give an object (ex workflow) an alias via API
Query for that alias, response should correctly contain object (workflow)
Query directly for that object (by id, path, etc), the value of alias will incorrectly show as null.

Environment
Persists as of dockstore-webservice-1.7.0-beta.5
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Fix Versions: Dockstore 1.8
┆Sprint: Seabright Sprint 21 Viking
┆Issue Number: DOCK-908

Review pending solution for migration issue (cannot public to create new snapshots)

Does not quite seem to work as expected.
For example
https://staging.dockstore.org/api/workflows/2327?include=validations%2Caliases
returns an empty aliases object for versions of the workflow
But https://staging.dockstore.org/api/aliases/workflow-versions/foo
gets
{
  "fullWorkflowPath": "github.com/Barski-lab/ga4gh_challenge",
  "tagName": "v0.0.2"
}

WorkflowVersion aliases weren't a thing until way after this issue was merged

Ok, I'll assign to @wshands  to replicate


Using tomowallet to withdraw implementation

withdraw by tomowallet: https://github.com/tomochain/tomomaster/issues/239

Pull Request Test Coverage Report for Build 446

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.47%

Totals

Change from base Build 445:
0.0%

Covered Lines:
92

Relevant Lines:
103

💛  - Coveralls


Improve documentation layout using electric.js

Live demo currently on https://henriquelimas.github.io/crocks

Coverage remained the same at 100.0% when pulling 851294c5424ae5e222df776a111067079763abeb on HenriqueLimas:master into fb326d65ee36c44bb5e4ed86857166f29924e62c on evilsoft:master.

Coverage remained the same at 100.0% when pulling b218ea1f1fcfa75178e234abcf4f100397fd6cfe on HenriqueLimas:master into fb326d65ee36c44bb5e4ed86857166f29924e62c on evilsoft:master.

Coverage remained the same at 100.0% when pulling b218ea1f1fcfa75178e234abcf4f100397fd6cfe on HenriqueLimas:master into fb326d65ee36c44bb5e4ed86857166f29924e62c on evilsoft:master.

Coverage remained the same at 100.0% when pulling 5068b50b3b727826d6bce45bd286925061fe982a on HenriqueLimas:master into fb326d65ee36c44bb5e4ed86857166f29924e62c on evilsoft:master.

Coverage remained the same at 100.0% when pulling f7221eafc0c33dfcf6cfc78fa0418569315f4833 on HenriqueLimas:master into fb326d65ee36c44bb5e4ed86857166f29924e62c on evilsoft:master.

Coverage remained the same at 100.0% when pulling d8fc47e7821a379263a8bd3fefc26159e42b47c6 on HenriqueLimas:master into c110fff19727b1fa65e72c5e17eda410d1086e40 on evilsoft:master.

We can totally work with this!
❤ the heck out of this. Thanks again for your valued time and effort.
And...
Have a squirrel:


[dv,clkmgr] Used synchronized sw enables in SVA

The SVAs for peripheral clock gating need to use inputs synchronized to the clock they control, or they will be unrealistic. It is possible that the gating controls will change too quick and a pulse will be missed, causing assertion failures. In reality this is a corner case since the expectation is that gating controls will change infrequently.

This was the cause of the one test failing in block level regressions.


after: function cant recognize the end of feed

    var instaFeed = new Instafeed({
        get: 'user',
        userId: '123456789',
        accessToken: 'xxx',
        clientId: 'xxx',
        resolution: 'low_resolution',
        target: 'instagramPhotoContainer',
        limit: 2,
        filter: function(image) {return image.tags.indexOf("stuff") >= 0;},
        sortBy: 'most-recent',
        template:'
{{likes}} ♥<img class="item" src="{{image}}" /
',

        after: function() {
            if (!instaFeed.hasNext())
                jQuery(".loadmoreInstagram").hide();
        }
    });
    instaFeed.run();

    jQuery(".loadmoreInstagram").click( function() {
        instaFeed.next();
    });

This is code for Instagram feed gets pictures from my profile and with filter for hashtag stuff. Load more button loads more pictures, and jQuery it hides when the feed is done.
It is pretty much straight forward and it works in most cases.
Only case it doesn't work if i have only one picture to show, with limit 2, I expected that after function will hide my button, as usually, but it doesn't. Button stays on screen with my only picture. I can't manage to hide the button in this case.
I should also mention i have 4 pictures in total.
Any help is appreciated.
Thank you for your answers !

Is there maybe a way I could get length or size of my feed and then compare it with number of instaphoto classes ?


Does not resolve for hikari 2.1.0

Steps to reproduce

Set your requirements.txt to require hikari==2.1.0 and hikari-lightbulb==2.3.5.post0
Run pip install -r requirements.txt
Experience ResolutionImpossible

Expected result
Package should've installed correctly.
Actual result
ERROR: Cannot install -r requirements.txt (line 4) and hikari==2.1.0 because these package versions have conflicting dependencies.
The conflict is caused by:
The user requested hikari==2.1.0
hikari-lightbulb 2.3.5.post0 depends on hikari~=2.0.0
To fix this you could try to:

loosen the range of package versions you've specified
remove package versions to allow pip to attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
System info
Doesn't apply because of a dependency conflict.

Further info
No response
Checklist

[X] I have made sure to remove ANY sensitive information (bot token, passwords, credentials, personal details, etc.).
[X] I have searched the issue tracker and have made sure it's not a duplicate. If it is a follow up of another issue, I have specified it.

This is not a bug. Hikari uses effver which means 2.1.0 represents a breaking change over 2.0.0. Lightbulb is compatible however so from next release 2.1.0 will be supported.


Focus for scrolling is lost after context menu interaction

In feed open context menu with right click, then press "Favourite".
Context menu closes and now you can't scroll with browser hotkeys (like ArrowUp/Down buttons, or Cmd-ArrowDown)
Google Chrome, Mac OS

Same things happens on Fedora w/ Firefox

Should be fixed now on production site.


Add eslint-plugin-vitest

Overview
I've been trying out eslint-plugin-vitest in a personal project and it's been helpful. This PR adds this plugin and an opinionated configuration to the base ESLint config that takes includes the recommended config and also takes care of various bits of feedback I've given on PRs.
Adding this config to the app triggers about 70 new errors, so this will be a relatively involved upgrade, but the payoff will be more consistent, idiomatic tests.
Review requests:
Review the explicitly enabled tests for any you think are improper:

vitest/consistent-test-filename
vitest/consistent-test-it
vitest/no-conditional-expect
vitest/no-conditional-in-test
vitest/no-conditional-tests
vitest/no-restricted-matchers

Disallow toBeTruthy and toBeFalsey because they hide bugs

vitest/no-restricted-vi-methods

Disallow vi.spyOn because partial mocking is harmful

vitest/prefer-each
vitest/require-top-level-describe
vitest/valid-expect

Superseded by #35 and #36


Convert ffi to -sys package and build script

Cargo currently recommends moving all FFI code to a -sys package.
On my system this is actually needed, since my SDL2 library is in a custom path (~/opt/lib/) which cargo/rustc cannot find. To still build my package I need to run cargo build -v, copy the last command, and append it with -C link-args="-L $HOME/opt/lib". This manual intervention is obviously less than ideal.
I already started some work in the sys branch of my fork. Althought the pkg-config part works very well, I got stuck implementing an alternative build method as git2-rs does.

I think we can close this for now as #250 has been merged.


Added Request and Response Bodies for 2 main Point-in-time endpoints

Issues Resolved
[#100]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Don't forget to resolve the conflicts


Range port opening/mapping will cause layout to be broken due to portainer display port mapping one by one

Bug description
If we map a range of port, like 10 thousand ports. The layout of portainer will be broken like this in the Service List page and we can not see task information anymore

Expected behavior
Portainer display range mapping or limit the number of port mapping displayed to prevent broken layout
Portainer Logs
No log related
Steps to reproduce the issue:

Create a service that open a port range (with around a thousand ports)
Go to Services page and see the broken page

Technical details:

Portainer version: 2.9.3
Docker version (managed by Portainer): 20.10.9
Platform (windows/linux): linux
Command used to start Portainer (docker run -p 9443:9443 portainer/portainer): docker run -p 9443:9443 portainer/portainer
Browser: Chrome
Have you reviewed our technical documentation and knowledge base? Yes

Additional context
No

I note you're running version 2.9.3 which is over 6 months old - can you try updating to the latest version of Portainer and see if this issue still exists?

I've opened an internal ticket around improving the way that port ranges display in Portainer, and we'll keep you updated as to progress here.

Any information on the progress?


Could you explain how to built "metadata.json" in utils.py?

metadata.json is provided in DFDC dataset


Add Declaration for eBPF arm64 support

With the information from the issue:
Calico eBPF arm64 support
https://github.com/projectcalico/calico/issues/6022
the Calico eBPF dataplane was supported on arm64
architecture with Calico version 3.21.4+
So add the declaration of arm64 support in the
ebpf document.
Signed-off-by: TrevorTaoARM<EMAIL_ADDRESS>Description

Related issues/PRs

Todos

[ ] Tests
[x] Documentation
[ ] Release note

Release Note

TBD

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

Hey @TrevorTaoARM,
Thanks for the PR!
I think adding this is a bit tricky at the moment since there is not a suitable environment to run the related E2E tests.
I'm going to ping @lwr20 for the final decision though.

Hey @TrevorTaoARM, Thanks for the PR!
I think adding this is a bit tricky at the moment since there is not a suitable environment to run the related E2E tests.
I'm going to ping @lwr20 for the final decision though.

@frozenprocess Thanks.
For the e2e test on arm64, I had created a PR:
https://github.com/projectcalico/calico/pull/5935
Actually I had tested the e2e test with this PR on arm64 and amd64.
The e2e test output result is the same as that of amd64.
Please check the PR for details.

I just did a rework of the eBPF docs and put in something about ARM.  It'd be good to have regression tests running on ARM before claiming full support.  Note: I don't think the E2E test job in this repo tests eBPF mode.  The real meat of hte eBPF tests are in the felix fv framework.  We've never tried those on ARM. You can try them by running something like
cd felix
make fv-bpf GINKGO_FOCUS=BPF-SAFE GINKGO_ARGS="-ginkgo.failFast"

but a full run takes 8 hours or more (so we run them in batches in our CI system).

I just did a rework of the eBPF docs and put in something about ARM. It'd be good to have regression tests running on ARM before claiming full support. Note: I don't think the E2E test job in this repo tests eBPF mode. The real meat of hte eBPF tests are in the felix fv framework. We've never tried those on ARM. You can try them by running something like
cd felix
make fv-bpf GINKGO_FOCUS=BPF-SAFE GINKGO_ARGS="-ginkgo.failFast"

but a full run takes 8 hours or more (so we run them in batches in our CI system).

@fasaxc Thank you, Shaun. It's great to learn the eBPF support was added in our eBPF document.


Dotting the Is and Striking the Ts

Cleaning up the test scripts, adding Safari Browser to the testable browsers in BrowserStack.
Stabilizing script.

SonarQube Analysis: https://sonarqube-vmvfjv-tools.pathfinder.gov.bc.ca/dashboard?id=common-forms-toolkit-pr-145

While https://developer.gov.bc.ca/Licensing-Your-Project says that all source code files should have an explicit licence comment header, it is extremely pedantic. I do understand that there needs to be assertions of both copyright and licensing in these software packages - however, quick survey across many bcgov repositories shows that very few groups are adhering to putting in a copyright and license header.
If nothing else, I do want to bring to attention a potentially more succinct way of embedding both the copyright and licensing to all source files via SPDX headers:

https://softwareengineering.stackexchange.com/a/381907
https://spdx.dev/ids/

This would result in a much cleaner, 2 liner:
/* Copyright 2020 Province of British Columbia */
/* SPDX-License-Identifier: Apache-2.0 */

Good conversation to have, but not with me. I think the direction and intent are clear. The fulfillment could vary. To say: A lot of projects are not doing it, is not a productive argument in light of the guidance provided.  You SPDX comment is.


Calling InAppBrowser.open with _system option triggers a route change

Framework7 version: 3.6.6
Platform and Target: iOS Cordova 12 app
Live Link or JSFiddle: Doesn't apply

Describe the bug
When executing window.cordova.InAppBrowser.open('https://news.ycombinator.com/newest', '_system') the routeChange event is firing.
To Reproduce
Steps to reproduce the behavior:

Build a Cordova iOS app (didn't try in Android yet)
From the console in Safari's devtools run window.cordova.InAppBrowser.open('https://news.ycombinator.com/newest', '_system')

Expected behavior
It shouldn't trigger a routeChange. Calling InAppBrowser.open with _blank doesn't. This bug seems to only happen when using _system.
Actual Behavior
It triggers a routeChange. FYI, this line is being called: https://github.com/framework7io/framework7/blob/master/src/core/modules/router/router-class.js#L74
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

any idea why this is happening?


Chocolatey Bootstraper

Created Chocolatey package to set up a local test environment for Chocolatey packages;

Thanks for that, if you can please take a look at the feedback and make adjustments, that would be great!

Please have a look to the comments I have added to the package as well:
Hi,
First of all, I want to thank you creating this package. I think this could be a good idea to package this up so new maintainers could start sooner. However we need to make some changes before we can approve this.

The version of the Chocolatey test environment is currently not defined somewhere, I am discussing this with the team, but 0.10.15 is incorrect. It will probably be something like 0.1.0

Please do not pin the version of vagrant / virtualbox to a specific version. If people have versions of VirtualBox / Vagrant installed, this can result in scenarios that are unexpected.

Please do not use git checkout inside a package. The checkout should be of a tag, or a ZIP archive should be embedded in the package. (Please wait for a release tag.)

The sahara plugin is an separate installation, please create a depended package for this.

Please use the Get-ToolsLocation helper to define the folder; adding a Package Parameter to define the folder would be a great addition as well.

I am not sure if you should start the vagrant box and sandbox it during installation.

This is just a quick scan of the package, there are probably more (smaller) issues to be solved when we are going forward.
Installing VirtualBox inside a VirtualBox VM is not supported, so an exemption should be added in a later state.
I would like to ask you to reach out to me on gitter (open chat button on the lower right) to discuss how to go forward. My username is mkevenaar.
Thanks for doing this!
Maurice

What's the ETA for a release, so I can bundle it with the package?

To clarify, @mkevenaar , are you suggesting the code be checked out to Get-ToolsLocation by default, and optionally to a location specified by a package parameter?

Very interesting package.
Good job and thanks!

Can I also suggest that for the package you make clear it is for Virtualbox. The Chocolatey Test Environment exists for Hyper-V, VMware and Virtualbox.

There has been no update to this for some time, so I'm going to go ahead and close.


Generator improvements

replace typer.echo() with proper log messsages
exit when product configuration cannot be read
change type of all path variables from str to Path
add 'variable' (snake-cased product name) to config
make --config-file option required
honour DATABASE_URI and PYTHONPATH environment variables while generating migration
correct location of database migration files
fix the generation of translations
fix the generation of lazy workflow definitions
remove superflous whitespace from templates
fix migration template
import missing Optional in product template
add variable to product blocks config
add option to specify custom templates folder for generate workflow commando
extent Jinja filesystem loader search path with custom folder
create missing dunder init files
add product_types_module to workflow renderers
refactor create and modify workflow templates to leverage new custom
templating capabilities
replace update_ticket_step with addtional_steps
while failing to read product config raise exception instead of exit()
create migration head 'data' if it does not exist
add products for all fixed input combinations to migration
add all new products to subscription model registry
close workflow file before calling writer()
fix typos in subscription descriptions
use begin instead of StepList()
make input fields Optional if not required for that lifecycle state
make input fields ReadOnlyField's if not modifiable
fix modify workflow summary page
refactor terminate workflow template to include custom templates

Codecov Report

Merging #392 (744e18d) into main (6e235e6) will decrease coverage by 0.60%.
The diff coverage is 22.14%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   73.13%   72.54%   -0.60%
==========================================
  Files         184      184
  Lines        8886     8974      +88
  Branches     1449     1466      +17
==========================================
+ Hits         6499     6510      +11
- Misses       2199     2278      +79
+ Partials      188      186       -2

Files
Coverage Δ

orchestrator/cli/generator/generator/settings.py
100.00% <100.00%> (ø)

orchestrator/workflows/utils.py
50.90% <100.00%> (+1.35%)
:arrow_up:

orchestrator/cli/generator/generator/product.py
29.16% <40.00%> (+0.59%)
:arrow_up:

...hestrator/cli/generator/generator/product_block.py
27.27% <40.00%> (+0.21%)
:arrow_up:

...chestrator/cli/generator/generator/translations.py
29.16% <0.00%> (-2.84%)
:arrow_down:

orchestrator/cli/generator/generator/helpers.py
44.68% <33.33%> (-2.69%)
:arrow_down:

orchestrator/cli/generator/generator/workflow.py
30.97% <8.33%> (-2.36%)
:arrow_down:

orchestrator/cli/generate.py
41.17% <22.58%> (-3.27%)
:arrow_down:

orchestrator/cli/generator/generator/migration.py
21.05% <19.44%> (-1.45%)
:arrow_down:

... and 6 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add AngelARUI gameobject to arui_engineering scene

Add the AngelARUI script and TapTestData script to the arui_engineering scene. Modify the PTG MRTK configuration profile to use the AngelMRTKInputSystemProfile for speech/gesture recognition.
Engineering logging panels are still present. Wasn't sure if we wanted to remove those just yet.

Engineering logging panels are still present. Wasn't sure if we wanted to remove those just yet.

Fine for now, we'll likely find concrete motivation to remove then in the final pass of "play testing".


Wont do anything

as the Title says

yeah the cheat is outdated, you can update memory offset with the source or if you want an compiled exe go here : https://counterstrike-hack.leforum.eu/t18220-CSGOHack-v1-0-Undetected.htm

Updated https://github.com/Blaumaus/le_chiffre/releases/tag/v1.4.18
@azzlak @razeNFR


Feat 188 paginate results in status page

Thanks for submitting a pull request! Below are a few things you can do to help us more quickly review your changes.
Checklist
I have…

[x] summarized below my changes and noted which issues (if any) this pull request fixes or addresses.
[x] thoroughly outlined below the steps necessary to test my changes.
[x] attached screenshots illustrating relevant behavior before and after my changes.
[ ] review and update SSAG documentation if needed.

Summary of Changes
This pull request…

closes #188
create pagination component
add types for paginated api responses
add pagination plugin to table component
add pagination component to status page
add page to api queries for documents

Testing
To verify the changes proposed in this pull request…

Run unit tests
Test pagination in development environment

Screenshots

Format error?


Loading text with footnotes

I installed tiptap-footnotes, and it seems to work great while the text is still in the editor. Thanks for this! It's exactly what I want it to be.
But it doesn't seem to round-trip. :(
I'm saving out the exact text from getHTML(), and then loading it back in using content=, and after loading the text back in, Tiptap strips all of the class info from the <ol> and <li> entries, which prevents tiptap-footnotes from identifying them as footnotes.
If I try adding a footnote, it will add TWO footnotes below the existing footnote.
Thoughts?

Confirming that I see the same thing — I suspect the culprit is the ol:has(.footnotes) selector here, which we actually want to just be ol.footnotes.
Should be a trivial fix; I'll try to get to it in the next few days!

OK, I dug into the code. In /package/src/footnotes/footnotes.ts:
  parseHTML() {
    return [
      {
        tag: "ol:has(.footnotes)",
        priority: 1000,
      },
    ];
  },

That selector doesn't work. The <ol> element is the one with a footnotes class, and :has() is looking for a child of the ol to have that class. The <li> elements don't have a class at all.
It should just be tag: "ol.footnotes". That should work.
I guess I'll put together a PR.

@jmduke Somehow our posts went up out-of-order? I guess the comments are only eventually consistent. :)
I sent over a PR.
I tested it manually and it seems to work.

OH, and if you want to do the right thing and add tests and whatnot, I won't be offended if you just ditch my PR. It's not exactly a major change. 😄

Ha, jinx!
The PR looks good. Unless you're really under the time-sensitivity gun, I would like to take this as an excuse to set up a testing harness; if by EOD tomorrow I don't carve out the time, I'll merge in yours!

Thanks! Let me know when a new version is published and I'll switch over from my temporary fork.


please support to "go get" for public and private repositories

"go get" is golang command for package download and install.
Same issue with the gitlab
https://github.com/gitlabhq/gitlabhq/pull/7693
Remote import paths
http://golang.org/cmd/go/#hdr-Remote_import_paths
Maybe, I think that it is all right with the addition of <meta name="go-import" content="@path git @url (repository)" /> in gitbucket/src/main/twirl/gitbucket/core/main.scala.html.
But, even if redirected to the login screen, want to display the repository information before the redirect.
thank you.

@ysaotome Thanks for your request. I added go-import meta tag for public repositories at first. Redirection for private repositories is not implemented yet. It might be raised as an another issue.

@takezoe Very thank you. But, Regrettable that private repository is not supported. I will consider while using a public repository.

Thank you for support to this feature.
However, "go get" command cannot sign-in to the GitBucket　(redirected to the login page), so the meta tag does not detected.
Andalso, can I use "ssh://" url?


syntax error not reported, types class def

ty_edge is referenced before definition,
CLASS zcl_oapi_graph DEFINITION PUBLIC.
  PUBLIC SECTION.
    METHODS add_vertex IMPORTING iv_vertex TYPE string.
    METHODS add_edge IMPORTING is_edge TYPE ty_edge.
  PRIVATE SECTION.
    DATA mt_vertices TYPE STANDARD TABLE OF string WITH DEFAULT KEY.
    TYPES: BEGIN OF ty_edge,
             from TYPE string,
             to TYPE string,
           END OF ty_edge.
    DATA mt_edges TYPE STANDARD TABLE OF ty_edge WITH DEFAULT KEY.
ENDCLASS.

CLASS zcl_oapi_graph IMPLEMENTATION.
  METHOD add_vertex.
    READ TABLE mt_vertices WITH KEY table_line = iv_vertex TRANSPORTING NO FIELDS.
    ASSERT sy-subrc = 0.
    APPEND iv_vertex TO mt_vertices.
  ENDMETHOD.

  METHOD add_edge.
    READ TABLE mt_edges WITH KEY table_line = is_edge TRANSPORTING NO FIELDS.
    ASSERT sy-subrc = 0.
    INSERT is_edge INTO TABLE mt_edges.
  ENDMETHOD.
ENDCLASS.

smaller example,
CLASS zcl_oapi_graph DEFINITION.
  PUBLIC SECTION.
    METHODS add_edge IMPORTING is_edge TYPE ty_edge.
  PRIVATE SECTION.
    TYPES ty_edge TYPE string.
ENDCLASS.

CLASS zcl_oapi_graph IMPLEMENTATION.
  METHOD add_edge.
    RETURN.
  ENDMETHOD.
ENDCLASS.

also
CLASS zcl_oapi_graph DEFINITION.
  PUBLIC SECTION.
    METHODS add_edge IMPORTING is_edge TYPE ty_edge.
    TYPES ty_edge TYPE string.
ENDCLASS.

CLASS zcl_oapi_graph IMPLEMENTATION.
  METHOD add_edge.
    RETURN.
  ENDMETHOD.
ENDCLASS.


Add page listing maintainers of discoverable extractors and loaders

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2601
Originally created by @DouweM on 2021-02-24 16:20:59

View 5 previous comments from the original issue on GitLab


DCGAN and CGAN suffer from mode collapse

After training for 200 epochs with the CIFAR 10 dataset, I found that the DCGAN and CGAN generated images do not have enough variety. Most likely a mode collapse happening.

Regards,
Mode collapse is one of the main problems that occur during GANs training, which means that the generator produces limited varieties of samples.
In recent work, researchers have presented some studies that suggest some methods to reduce the problem of mode collapse, such as:

studies that explore new objective functions, like Unrolled GAN and Deep Regret Analytic GAN (DRAGAN),
studies that propose architectural modifications like Multiagent Diverse GAN (MAD-GAN) and Mode Regularized GAN (MRGAN), and
studies with mini-batch discrimination like Progressive GAN.

For more information, these works are recommended:

NIPS 2016 Tutorial: Generative Adversarial Networks
Generative Adversarial Networks: An Overview
How Generative Adversarial Networks and Their Variants Work: An Overview

Thanks


Update BED-JSON to remove placeholders for data we don't currently have

Prioirty = 4

@christoph-maurer Can you provide an example url that still has placeholder information?  So far I am not seeing any in the code and when I look at some samples from the server like
https://igsdb-icon.herokuapp.com/api/v1/products/4791/?json_format=buildingenvelopedata.org
or
https://igsdb-icon.herokuapp.com/api/v1/products/196/?json_format=buildingenvelopedata.org
I do not immediately see anything that looks like placeholder data.

@StephenCzarnecki I agree, I don't see placeholders anymore. I tried to validate https://igsdb-icon.herokuapp.com/api/v1/products/196/?json_format=buildingenvelopedata.org against the schema using make shell and make test. I had to change two things to make it valid. First, I deleted all lines "transmittance": null,, because null is not allowed and the key should be omitted if there is no data. Second, I exchanged "solar" by { "integral": "solar" } and the same for visible and infrared. I have added the original and the corrected file to the tests and deleted older examples from IGSDB.

@christoph-maurer This should hopefully be fixed now.  I had errors trying to run make shell when I cloned the repo so was not able to verify with make test.  But I have updated the json based on your comment so hopefully it is now correct.

@StephenCzarnecki It works fine, thank you!
@RDmitchell Stephen has solved the two remaining issues. Thanks to both of you for your contributions!


Update README.md

Motivation and Context
Setup of the tumlive database did not work correctly. Database was not created.
Description

Add Database option to env variables of docker script.
Add docker-compose snippit, to use docker compose to setup the database

Steps for Testing

Use setup script to create a new database locally in your docker env
Check with datagrip or sql cli if the database and the tables are created correctly

yes lets postpone this for now 🙌

Please reopen this PR if it's necessary again. Closing this to reduce the number of PRs.


Changes in other parameters with height change

Height change
Adds additional features to playerHeight as mentioned in #2535 .
With the increase of height player now gets enhanced jump height and speed as well as get immune to fall damage to a certain extent with the increase in height.
How to test

Start the game,

Write the command playerHeight  in the console.

Can one of the admins please verify this patch?

test this please

Hooray Jenkins reported success with all tests good!

Superseded by #3907


Remove option from journalctl generated artifact

I must have been reading a Fedora man-page when I added the command
originally.  The --no-hostname option isn't supported by RHEL's
journalctl.
Signed-off-by: Chris Evich<EMAIL_ADDRESS>

note: This goof won't affect running jobs, only the contents of the system.journal log file.

Thanks Steve :smiley:


Update MD file on new branch 2017-12-15_17-40-27

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix two search issues

Add some padding to the search box so It matches the button.
Fix an issue where search results were presented in a ul  element and had commas in-between eachli element.
Corrected the syntax for the nested button element in the CSS, but I’m still not sure it does anything.

Add some padding to the search box so It matches the button.
Fix an issue where search results were presented in a ul  element and had commas in-between each li element.

Thanks for these; yeesh, can't believe I overlooked the commas / missing join.

Corrected the syntax for the nested button element in the CSS, but I’m still not sure it does anything.

This specifically affects the fixed version (PUBLIC_FIXED=1 npm start).

FWIW, there might be a couple of places where I intentionally omitted & where it still works but "fools" Astro's CSS scoping; I've been meaning to take another pass at those. This instance seems to work either way.
FYI I pushed a formatting commit to the branch.


Add a phase banner component

Copy HTML from govuk_elements and styles from the govuk_frontend_toolkit.
Add a README.
Create a new bold-16 mixin
Import the phase banner component
Screenshot:

Good call, I'll split those out too!

👍


Revert "cudaPackages: make getOutput work again"

Reverts NixOS/nixpkgs#301180
Cf. https://github.com/NixOS/nixpkgs/pull/301180#issuecomment-2045344079

Merging as a hot fix for regressions introduced by the thing this reverts.

NOTE: Is it not possible for this to break OfBorg evaluation given nothing can/should depend on this change.


🔀✨ Praktikumsstellen unabhaengige Meldung and Rework

Description:
Implemented the rework of Praktikumsplätze and the Meldezeitraum independent Meldung for the örtl. Ausbildungsleitung
Reference:
Issue: #129
Issue: #130
Notifying additional team members:
@mirrodi @MrSebastian @AnHo314

Definition of Done (DoD):

[x] Unittests gepflegt
[x] Dokumentation ist gepflegt

v-radio-group label is currently not editable, reason unknown. This has to be fixed

Merge Conflicts need to be resolved


Update Bindings API to GodotSteam 4.11

Godotsteam recently had a new update so some of the C# Bindings are out of date.
Would be great to be able to use the latest GodotSteam version and CSharpbindings.
Not sure if you add them by hand or if you autogenerate the bindings already.

This might be why Steam.ExchangeItems is incorrect? It is supposed to take arrays for all params but in the C# version the last 3 params take uint/ulong.

haven't look at that at all but I'm looking to update the bindings for myself as of right now.

At least it is easy to "patch". I've just added this function to my own steam related class and it works.
private static int ExchangeItems(long[] outputItems, int[] outputQuantity, long[] inputItems, int[] inputQuantity)
{
	return Steam.GetInstance().Call(Methods.ExchangeItems, outputItems, outputQuantity, inputItems, inputQuantity).AsInt32();
}

yeah since it's all handwritten anyway, implementing all the changes should be trivial


Getting to run Chromely with GTK on windows and linux

In your demo on "Getting Started CefGlue Gtk (Linux)" you write:
var factory = WinapiHostFactory.Init();
            using (var app = new CefGlueBrowserHost(config))

this class seems to be from CefGlue.WinApi.
Is WinApi and CefGlue.WinApi required to run on linux? the wiki page doesn't mention them.
Even with those 2 packages, it won't run on windows, because Cef is missing.
So I added cef like written further down on the wiki page.
I then installed the gtk+ 64bit runtime in v2.24 from
https://github.com/tschoonj/GTK-for-Windows-Runtime-Environment-Installer
(installing the 32bit version will throw BadImageFormatException)
With this installed, I got this exception:
Exception thrown: 'System.DllNotFoundException' in Chromely.CefGlue.Gtk.dll:
'gtksharpglue-2'
After googling I found, that I need Gtk# to be installed from http://www.mono-project.com/download/stable/
Now I get BadImageFormatException agai, presumably, because Gtk# doesn't ship a 64bit version.
   at Chromely.CefGlue.Gtk.ChromeHost.NativeMethods.Win.gtksharp_gtk_widget_get_window(IntPtr widget)
Is 64bit required for Chromely or would it run in32bit mode, too?

This was no longer needed. Early versions had Chromely.Core dependent on WinApi dll.
var factory = WinapiHostFactory.Init();
            using (var app = new CefGlueBrowserHost(config))

Now removed, should be:
            using (var app = new CefGlueBrowserHost(config))

Thanks for pointing this out.

Gtk on Windows has only been tested for 32bit.
I made it more obvious:
10. Download Mono - 32 bit gtk binaries from Mono Project and copy necessary files to the bin folder.
So if you follow the guide, you only need 2 downloads - the gtk 32 bit from mono project and cef binaries..

Gtk on Linux has only been tested for 64bit.
This is what .NET Core supports for now.
Most Linux  distros have gtk already installed. If this is the case, you only need the Cef binaries downloaded.
Please find more details in the guide.

"gtksharpglue-2"
this one is included in gtk# msi.

Gtk on Linux has only been tested for 64bit.
This is what .NET Core supports for now.

you mean, .net core only supports 64bit on linux?
This would mean that I have to ship 2 different cef blobs to be cross platform runable.
can you consider changing how cef is "deployed"?
maybe to have it located in subfolders like cef_win32, cef_win64, cef_linux32 etc
this would keep the bin folder clean and make it easier to switch own and third party dlls.

I just added required  gtk binaries to the repo.
Updated guide:
10. Get required gtk binaries or Download Mono 32-bit gtk binaries from Mono Project and copy necessary files to the bin folder.

Yes, no support yet for 32-bit on Linux. Not sure if Roadmap is updated yet.
Stackoverflow discussion.
The difficulty with GTK for now is on Windows - 64bit has little support, on Linux, .NET Core has no support yet for 32bit. But I believe as .NET Core gains traction things will get easier.
For pure cross-platform I have toyed with Nana C++, Libui - they all will work but they will require more work and more dependencies that I am trying to avoid. I want to stay as close to the core as possible.

can you consider changing how cef is "deployed"?
maybe to have it located in subfolders like cef_win32, cef_win64, cef_linux32
Sure, that would be a good idea. I can look into that. Likely will be a weekend task.


Ensure code paths are in place when running keys_gen script

It depends on enacl and base58, simply add all sibling libraries
to the escript's code path on start.

The keys_gen script is intended to run by using ./bin/epoch keys_gen PASSWD
in a production environment. I have just tried this for release 0.19.0 and that works perfectly well.
Unsure what you have been using that makes the path not correct?
Idea is: make prod-package and then deploy the generated tar.gz file somewhere. In that deployment you should be able to run ./bin/epoch with all provided commands.

You're right, it does run fine with the packaged release.
I came across this when generating the release (rebar3 release) and then _build/default/rel/bin/epoch keys_gen

changing the include_erts rebar.config entry to true makes it work, this points either to relx or OTP's release handler, i'll close this ticket and post any interesting findings regarding this here


Renaming a file with just character casing changes and editing it with any editor action like rename symbol, opens a file with the previous name and edits it

VSCode Version: Code 1.11.0 (9122ec4b1068bd391e41974f46a4b54c1b9c90f9, 2017-04-05T20:59:05.375Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author
Version

rest-client
humao
0.14.0

mssql
ms-mssql
0.3.0

csharp
ms-vscode
1.8.1

debugger-for-chrome
msjsdiag
2.7.2

vscode-docker
PeterJausovec
0.0.13

sort-imports
peterjuras
2.3.1

vscode-icons
robertohuertasm
7.5.1

I'm not even sure I have correctly titled this... But for whatever is worth here's the steps...
Steps to Reproduce:

Create a file, typescript in my case (reproduced with C# file as well), let's say test.ts.
Rename it changing just the character case, like test.ts -> Test.ts (or change casing for all letters, doesn't matter as long as only character casing is changed) using rename from folder view.
Rename a symbol using right-click, or just reference a module and import it using Ctrl + ., just so the file is edited not manually but by an editor action.
The previously named file will open in the editor with the change that was made, so test.ts will open and include the change made and Test.ts will still show contents without changes.
Save the test.ts file, close it, nowTest.ts shows the correct contents.
Repeat steps with any change that is done by the editor (like rename symbol) and this goes on indefinitely, a file with the previous name is opened. So a new rename to TEST.ts followed by an editor action like rename symbol, will open Test.ts.
Do any manual change in the file and just save it, the file is saved without opening the file with the previous name and shows correct content as expected.

This happens with git tracked files as well as entirely new files not yet tracked by git. Moreover, it happens with and rename that is only a character case change, doesn't matter how many character casings are done, so Test, TEST etc. should behave the same.

Also for .js files.

I guess this happens with most, if not all, file types, as long as the editor is able to offer an edit action on the file's contents.
I can reproduce this bug with a first time installation of VS Code 1.11.0 on a clean Windows 10 machine as well.
Fyi, normal renames, that is changing the name, behave as expected, so test.ts to old.ts doesn't expose this issue.

Similar to #24003

Can reproduce with all extensions disabled. E.g., renaming a local variable in a .js reproduces it, while formatting a .js or just editing it does not.

I do not think this is related to #24003. The workbench will open any dirty buffer so that users are able to track changes that are made (otherwise those would be hidden). In this case I suspect that the TS service still thinks the file is in uppercase (e.g. it did not correctly handle the rename) and then makes changes to the previous-cased version of the file which results in the workbench opening the buffer.
@mjbvz to confirm that theory.

I can reproduce with C# file as well.

Right, this seems language independent.
@jrieken when I debug this I see that when I invoke rename, the resulting BulkEdit is still having a reference to the old, previous-cased version of the model. I wonder if this is a race condition, maybe you could check as well.
Steps:

open a TS file
rename to lowercase
set a breakpoint to editorPart#openEditor() (to follow the stack all the way down)
hit Rename
=> you should see the editor opening somewhere because BulkEdit pushes edits to a model that is using the casing of the previous version of the file

This is also the ResourceMap issue

https://github.com/Microsoft/vscode/issues/24003


UIDs for Square Cash payments

Ask for UIDs in the Square Cash payment instructions. Display them in the pending dues table.

@kberzinch What would you like the new copy for the card to be?
The current copy is
Pay with your debit card online via SquareCash to $robojackets.

Add

Please put your GT username (e.g. gburdell3) in the notes.


GizmoConfig::default() should set viewport to Rect::EVERYTHING rather than Rect::NOTHING

Version: transform-gizmo-egui  0.3.0
GizmoConfig::default() sets the default viewport to Rect::NOTHING, which will prevent it from rendering.  Since the gizmo rendering already checks for non-finite viewports and sets them to the ui clip rect, making the default Rect::EVERYTHING should just work.
As it is right now, the example in the documentation landing page is broken, as it does not explicitly set the viewport to be non-zero.

Thanks for the issue! This has now been fixed.
The problem was that even though the config viewport was replaced with clip rect, the egui rendering would still use the old non-finite rect. That's why the default Rect::EVERYTHING would show the gizmo.
The gizmo logic itself does not care whether it is Rect::EVERYTHING or Rect::NOTHING. Neither would work, as they are non-finite.


[Need Help] flashing screen and weird behaviors while drawing image in spreadsheet/table cells

Describe the bug
First of all, thank you for this amazing crate, which is easy to use and produces small binaries with minimal memory footprint.
I try to create a spreadsheet-like project(reference taken: spreadsheet.rs in fltk/examples) which simply displays data given to it. Some cells renders text, and some cells renders image.
The problem is,

when I scroll up/down, the image will overlay the top column,  and covers the column header.
when I scroll up/down, sometimes the images in cells will stuck together.
when I scroll up/down, the image cell area will flash/blink.

To Reproduce
code used to draw_data:
fn draw_data(
    info_table: &mut Table,
    row: i32,
    txt: &str,
    x: i32,
    y: i32,
    w: i32,
    h: i32,
    selected: bool,
) {
    draw::push_clip(x, y, w, h);
    if selected {
        draw::set_draw_color(enums::Color::from_u32(0x00D3_D3D3));
    } else {
        draw::set_draw_color(enums::Color::Light2);
    }
    draw::draw_rectf(x, y, w, h);
    draw::set_draw_color(enums::Color::Gray0);

    // draw text
    if !txt.ends_with(".png") {
        draw::draw_text2(txt, x, y, w, h, enums::Align::Center);
        draw::draw_rect(x, y, w, h);
    }

    // draw images
    else if txt.ends_with(".png") && txt.contains("resized") {
        info_table.set_row_height(row, 170);

        let original = txt.to_string();
        let t = thread::spawn(move || {
            let mut img = PngImage::load(&original).unwrap();
            img.draw(x, y, w, h);
        });
    }

    draw::pop_clip();
    if selected {
        let txt_owned = txt.to_string();
        thread::spawn(move || {
            set_clipboard(formats::Unicode, txt_owned).expect("Failed to set clipboard");
        });
    }
}

Expected behavior
Image cell should displays OK, no flashing screen;
Image should not go out of its cell.
Screenshots

Image goes out of its cell, and covering the column header

Image stuck together

Desktop info

OS: Windows 11
Version 21H2

Hi
This is a very heavy operation, at each change in the table (like scrolling), the image is reloaded from disc, hence the flickering. Also instantiating widgets/images in the draw callback is not recommended, see the discussion here:
https://groups.google.com/g/fltkgeneral/c/TB-vLS6ZghI


blueimp resume

This PR adds the resume functionality which was missing from #1

@nerg4l I noticed you aren't using TravisCI yet, is this intentional? It would make testing for multiple versions of Laravel/PHP really easy.

When I first created the PR Travis CI was not yet added, so I was waiting for @yak0d3 to add it as I do not have enough privilege.


Local peer metadata update feature

Can local SDK exposes way for users to update local peer metadata from client side itself, so that other users can get that metadata.
Any new participants should get metadata for all existing users.
Why there is a dependency of updating it from Server side.

We don't support client-side updates to metadata currently. Participant and room metadata could contain permission/state information where the server is the authority of the data. For example, for a poker game, it could contain the player's state, such as the number of chips they currently have.
While it is more code to write having to interact with your server, I think it offers a lot more flexibility in enforcing the app's business logic
.

But then in that case for very simple operation like a user wants to do hand raise there is no way to use websocket connection to send this info to server where it can apply the participantUpdate and send notification to others, Do people have to always write web server running server side sdk and ServiceRoomClient to do that operation.
It seems to be overhead, where maybe local peer-update should be allowed from local client.
I see some ion-sfu projects where they talk to ws to send notification like peer-update to server only not to other participant, then server takes care of sending this peer-updated to other users. This doesn't have overhead of http and managing own server, but at the same time gives options to send a lot more events to ws server where it can take care of what to do to those messages.

I am new to webrtc open source, I love live kit btw. Sorry if I am not making sense.

to send data to other participants from your client, you can use the publishData API on the local participant.
in order to get the most recent state of all participants for a newly joined participant you could do something like
room.on(RoomEvent.ParticipantJoined, (participant) => room.localParticipant.publishData(myCurrentState, DataPack_Kind.Reliable, [participant]);

But let's say we want to extend and introduce this behaviour where a local participant is able to update its own peer data that what will be changes we have to take care of like introducing certain event that can be sent using publishData and maybe intercepting it at server so that it can apply updateParticipant operation to send notification to all other user.
It will be great help if you can point me to such required changes.

clients will not be able to update their own metadata under the current security model. since users are relying on this security model, it's not a trivial thing to add.

closing, as using the server-sdk is the correct approach to set participants' metadata and for everything else, there's the publish data APIs.


Adding read permission to added files

Otherwise, Python can not pick them up and serve them.

Added in cc59381


Adding config flag autocompletenames to disable player name autocomplete

Workaround for issue #2987, #2964 and #2923. Adds config flag autocompletenames to disable user name searching in PermissionsCommand.autoCompletePlayerName.

Unfortunately PermissionsEx is currently unmaintained and no further updates are planned. Because of this, all issues and pull requests are being closed. If you are looking for an actively maintained permissions plugin, take a look at LuckPerms. It is compatible with major server platforms and can import data from PEX.


Tested the story Routes

successfully created the tests for story routes

confirmed app export pattern doesn't affect development for now


Fcrepo 2609

copies AccessRolesProvider and AbstractRolesAuthorizationDelegate
classes into module

updates refs to these classes in existing code

Resolves: https://jira.duraspace.org/browse/FCREPO-2609

Please note that one test case in WebAcRecipesIT currently fails, namely, testNoAccessRolesResource. It expects a 404 SC_NOT_FOUND, but returns 204 SC_NO_CONTENT. I am not quite sure what the desired behavior is here. All other unit and IT test cases pass, which makes me think maybe this test case is not expecting the right value.
FYI @birkland @dbernstein

@harringj I think the problem is that the rbacl module had a class AccessRoles which defined a fcr:accessroles endpoint.  That's not part of the API, and looks like it might take some effort to get working properly, due to the fact that userids are now URIs.
So, I propose deleting that test, and flagging this issue as a breaking change.  Does that seem logical?

I see. Yes, @birkland , that sounds reasonable to me.

Thanks for reviewing and for the feedback, @birkland! I made those changes you requested, and when Travis is done, it sounds like we should be good to go :-)


[AIRFLOW-1621] Add tests for server side paging

Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1621
https://issues.apache.org/jira/browse/AIRFLOW-1519

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
Adding tests to check logic included in AIRFLOW-1519.

This is a follow-up PR to https://github.com/apache/incubator-airflow/pull/2531
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Tests included.

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2614 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2614      +/-   ##
==========================================
+ Coverage      71%   71.06%   +0.06%
==========================================
  Files         150      150
  Lines       11740    11741       +1
==========================================
+ Hits         8336     8344       +8
+ Misses       3404     3397       -7

Impacted Files
Coverage Δ

airflow/www/utils.py
85.71% <100%> (+5.41%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e52070...f640bed. Read the comment docs.

@bolkedebruin this is the follow up of https://github.com/apache/incubator-airflow/pull/2531
cc @aoen @saguziel

Testing part LGTM although some of the other functions could use coverage as well, merging.

Thanks @edgarRd


Added check to exit if composer fails to install vendors.

Added check on composer install -o exit error
% init-drupal --directory=d8-dev --core=core drupal
Initialized empty Git repository in /private/var/www/contrib/d8-dev/.git/
[master (root-commit) 8dc7a87] Initial commit
Deprecation warning: Your package name drupal is invalid, it should have a vendor name, a forward slash, and a package name. The vendor and package name can be words separated by -, . or _. The complete name should match "^[a-z0-9]([_.-]?[a-z0-9]+)*/[a-z0-9](([_.]?|-{0,2})[a-z0-9]+)*$". Make sure you fix this as Composer 2.0 will error.
   ........
    Finished: success: 37, skipped: 0, failure: 0, total: 37
Loading composer repositories with package information
Updating dependencies (including require-dev)
PHP Fatal error:  Allowed memory size of<PHONE_NUMBER> bytes exhausted (tried to allocate 4096 bytes) in phar:///usr/local/bin/composer/src/Composer/DependencyResolver/RuleWatchGraph.php on line 52

Fatal error: Allowed memory size of<PHONE_NUMBER> bytes exhausted (tried to allocate 4096 bytes) in phar:///usr/local/bin/composer/src/Composer/DependencyResolver/RuleWatchGraph.php on line 52

Check https://getcomposer.org/doc/articles/troubleshooting.md#memory-limit-errors for more info on how to handle out of memory errors.
%

Note
Use environment variable as,
COMPOSER_MEMORY_LIMIT=-1 init-drupal --directory=d8 --core=core my/site

Thanks @shinde-rahul. The error message is good, but should/will this affect the error messages that come up later from init-lando?


dart2wasm timeout on co19/LibTest/collection/ListMixin/ListMixin_class_A01_to6

The test
co19/LibTest/collection/ListMixin/ListMixin_class_A01_t06 Timeout (expected Pass)

is failing on configuration
dart2wasm-linux-jscm-chrome

After being flaky for a while, it now times out consistently.

This test seems to pass now, but another test in the same ListMixin directory became flaky. I can't reproduce any of them, locally the directory doesn't even take one second to test and the tests consistently pass.

The default tab on current results shows only failures, not flakes. There are lots of flaky timeouts, across many configurations, in this suite, shown at https://dart-current-results.web.app/#/filter=dart2wasm&flaky
More flakiness info can be viewed at go/dart-flakiness.


Phone UX Improvements, Skipping calls through UI, Panic Button, Bug Fixes

UX Improvements
Currently many phone agent's are being led to believe they are in an offline state when they aren't.
To improve and resolve this issue:

[ ] Add a global phone indicator next to the user's profile image that will indicate the agent's current status on every page.
[x] Instead of looking through "idle" agent's and essentially giving it our best guess as to whether the agent's intention is to be online or offline, simply allow idling as long as the client is still connected. Once the client is disconnected, immediately set the agent offline. Closed by: https://github.com/CrisisCleanup/crisiscleanup-3-awsconnect/commit/de8cf81a9645fb3f134d107cbc0748a4a0dc2fe5

Agent's feel as if they are being locked into a call and are unable to reject/deny and/or are doing a disservice to a survivor.

[x] Add a button to the incoming call popup labeled "Skip Call." When clicked, as a minimum, display instructions explaining that the agent will shortly receive a call prompting them whether or not they wish to accept the call. Instruct them to select 0 to deny or to simply deny the call. Also explain that no survivor is an anyway impacted by the agent's denial, and that they will not be called (in the case of an outbound) or that they will continue on to the next agent transparently (in the case of an inbound.) Closed By: #994 -- Skipping call also end the call automatically.

[ ] When skipping call, also stop more calls. See #995

[ ] On manual outbound, if user does not press 1, the user should go offline, but does not. Or user should go back to whatever state they were in prior to making a manual outbound call.

[ ] Add a new "hang-up" button to the left of the primary start/stop taking calls button in the agent card. This button will act as a "panic button" and will always provide the agent with a method of ending/rejecting the current contact.

Bug Fixes
Inbound Call Flow

[x] Rejecting an inbound call does not currently destroy the agent client's local contact instance. This prevents the agent from actually going offline and prevent the release of the currently locked contact ID. If the agent forces themselves offline (via a refresh or similar), the contact id will remain locked and therefore not rollover to a new agent -- eventually forcing the user into a callback. Closed by: API#396

General Metrics

[x] "Currently on Hold" counter is no longer incrementing. This is due to the contact action updates as an indirect result of the inbound event changes. Closed by: API#396

Contact Flow
Queue Music

[ ] The music played while a contact is in the queue is still cutting up and restarting every 25 seconds. I tried taking the 6 minute clip of music, splicing it into 16 different prompts, each 25 seconds long, and adding all 16 to the prompt loop list. Did not seem to work. Will need some investigating.

Closed wrong issue, meant to close #995


Timezones dont work properly

Hi,
the Timezone Setting from Installation or APP_TIMEZONE in .env dont work.
It doesnt matter what i enter in this fields, the Postings or Replys getting the Chinese Timezone i think.

You can set it in config/app.php manually.

Okay, this seems to work (after "php artisan hifone:update"), but why to set this option in installation?
Maybe it is better to change something like this in a external File linke ".env".
For .env there is no need to change it during development. config/app.php is (in my opinion) for setup the defult values.

Fixed.
see here #107


Docker mysql linking question

@mhow2, I saw your comment on the Huginn Docker image:
The usage section explaining how to link to another mysql container doesn't work on my system.

The client container cannot connect to mysql server's container. I'm not sure the ports are exposed the right way ?

@icblenke may be able to offer some help.  He also wrote this useful summary: https://github.com/cantino/huginn/pull/872#issuecomment-118552328

Thanks @cantino.
Next time I'll do an issue report instead.
About icblenke's comment, I think i'll need to re-read it several times because there is a lot of info in there. As now my goal is to obtain the most 'easy-to-maintain' , 'easy-to-deploy' huginn installation, in a production env. On a single VM :) While I don't need zero-downtime at all.

@cantino, @icblenke I think we have an issue somewhere in mysql server configuration that prevents the application container to connect to the database container.
docker run --rm --name newcentury_mysql -p 3306 \
    -e HUGINN_MYSQL_DATABASE=huginn \
    -e HUGINN_MYSQL_USER=huginn \
    -e HUGINN_MYSQL_PASSWORD=somethingsecret \
    -e HUGINN_MYSQL_ROOT_PASSWORD=somethingevenmoresecret \
    cantino/huginn

the bind-address in my.cnf is set to <IP_ADDRESS> so the other container cannot connect.
changing the setting above is not enough : here is what I get then:
Mysql2::Error: Host '<IP_ADDRESS>' is not allowed to connect to this MySQL server

So I suspect the huginn user to be allowed to connect only from 'localhost'.
I guess the huginn docker deployment need a review. I can test when it's done if you'd like to.

A quick fix for this would be to run both containers with "--net=host" so that localhost would be the same for both containers, but that's really a hack.
I haven't tried reproducing this yet, but I have no doubt you are correct. I'll see if I can generate a PR to address this shortcoming in the near future.

PR #905 should address this. You will want to merge PR #903 as well for the PORT fix.

Issue #887 is now fixed, as PR #905 has been merged.
The only remaining question here is whether the mysql container is actually binding to localhost.

@dsander, think we can close this?

Yes we have documentation for both docker images, as well as example docker compose configurations.


mudlet version

Mudlet 3.0 has gone delta

I expect the version to change in this nix expression. Why did you change tarball and not the version?

It's the same pre-3.0 version, just another, more stable in bugless build.
Still waiting for official 3.0 to come. Do you think that might be better to be of version 3.0-delta or anything?

Yes, I think:

set version to 3.0.0-delta
and set url to https://github.com/Mudlet/Mudlet/archive/Mudlet-3.0.0-delta.tar.gz

is more clear.

@iyzsong @lethalman fixed!

Thanks!


Feature request: InfluxQL comments

Proposal: Comments in InfluxQL.
Current behavior: Comments are not supported.
Desired behavior: Allow line-oriented comments in InfluxQL. Example:
# This query computes a bar from foo.
select bar from foo

Use case: When performing data analysis, I end up using scripting pipelines that look like this:
cat my_query.infuxql | influx > output.txt

Inside my_query.influxql I have no way to document the queries (and now, subqueries). Comments would increase maintainability.

I've found myself reaching for the -- line comment on a few occasions. It looks like many other SQL variants support /* */ block comments, but I don't know whether supporting block comments would require us to add support for multi-line commands.

We technically already have multiline commands. Whitespace is mostly ignored so you can split a command between multiple lines pretty easily (although the CLI does not support it, but that's different than the server not supporting it).
I think this should be fairly easy to do and is a nice little feature. Thoughts @pauldix?

Also, what's the settled syntax for this? -- for single line comments and /* */ for multiline comments? Should we support nested multiline comments such as /* /* */ */? I vote no on the latter, but I thought I would bring it up anyway as some programming languages like D support that.

Agreed, no need to support nested multiline comments. Supporting -- for
single line and /* */ for multiline seems sufficient to me.
On Mon, Feb 27, 2017 at 8:45 AM, Jonathan A. Sternberg <
<EMAIL_ADDRESS>wrote:

Also, what's the settled syntax for this? -- for single line comments and /*
/ for multiline comments? Should we support nested multiline comments
such as / /* */ */? I vote no on the latter, but I thought I would bring
it up anyway as some programming languages like D support that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/influxdata/influxdb/issues/8025#issuecomment-282776204,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARvV50cbNr3q6KAFCm-_WmptGt7mqsMks5rgv2MgaJpZM4MEr4f
.

LGTM. Although I am wondering if people will also try // for single line and get confused since we support /* */ for multi-line and generally if you support the latter, you support the former.


Integrate srml/im-online with slashing

First draft based on https://github.com/paritytech/substrate/pull/3137.
Closes https://github.com/paritytech/substrate/issues/2719.

Closed in favor of https://github.com/paritytech/substrate/pull/3223.


Updated github actions for updating docker tags for 4.5.0 and 5.0.0

Can one of the admins verify this patch?


Method to update Query in Firebase and Firestore Adapters.

This PR Implements a method to change/update Query in both Firebase as well as Firestore Adapters. (Issue #1614)

@samtstern There are some Auth lint errors exists that's why Trivis CI failed.

@samtstern These are errors.
  The first 3 errors (out of 84) were:
  /home/travis/build/firebase/FirebaseUI-Android/auth/src/main/res/layout/fui_auth_method_picker_layout.xml:11: Error: This view is not constrained horizontally: at runtime it will jump to the left unless you add a horizontal constraint [MissingConstraints]
      <me.zhanghai.android.materialprogressbar.MaterialProgressBar
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /home/travis/build/firebase/FirebaseUI-Android/auth/src/main/res/layout-land/fui_auth_method_picker_layout.xml:12: Error: This view is not constrained horizontally: at runtime it will jump to the left unless you add a horizontal constraint [MissingConstraints]
      <me.zhanghai.android.materialprogressbar.MaterialProgressBar
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /home/travis/build/firebase/FirebaseUI-Android/auth/src/main/res/layout/fui_confirmation_code_layout.xml:9: Error: This view is not constrained. It only has designtime positions, so it will jump to (0,0) at runtime unless you add the constraints [MissingConstraints]
      <me.zhanghai.android.materialprogressbar.MaterialProgressBar
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  The first 3 errors (out of 4) were:
  /home/travis/build/firebase/FirebaseUI-Android/app/src/main/res/layout/auth_method_picker_custom_layout.xml:81: Error: This namespace declaration is redundant [RedundantNamespace]
      <com.firebase.ui.auth.util.ui.SupportVectorDrawablesButton xmlns:android="http://schemas.android.com/apk/res/android"
                                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /home/travis/build/firebase/FirebaseUI-Android/app/src/main/res/layout-land/auth_method_picker_custom_layout.xml:98: Error: This namespace declaration is redundant [RedundantNamespace]
      <com.firebase.ui.auth.util.ui.SupportVectorDrawablesButton xmlns:android="http://schemas.android.com/apk/res/android"
                                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /home/travis/build/firebase/FirebaseUI-Android/app/src/main/res/values/strings.xml:26: Error: Duplicate string value Google, used in logo_google, providers_google and tos_pp_google [DuplicateStrings]
      <string name="providers_google">Google</string>
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      /home/travis/build/firebase/FirebaseUI-Android/app/src/main/res/values/strings.xml:46: Duplicates value in providers_google
      /home/travis/build/firebase/FirebaseUI-Android/app/src/main/res/values/strings.xml:50: Duplicates value in providers_google

@PatilShreyas ok I did some thinking and experimenting.  First I found better words to explain myself :-) the reason I am not comfortable with updateQuery on ObservableSnapshotArray is because that class previous did not know that Query existed at all.
Second I think it may be better to structure this as setOptions where instead of just replacing the query you replace the whole options object you used to start the Adapter.  Here's an example of how that might look (for RTDB only):
https://github.com/PatilShreyas/FirebaseUI-Android/pull/2
What do you think?

Right @samtstern!

@samtstern I have merged your PR and make changes as you suggested. Also implemented in Firestore adapter.

@PatilShreyas sorry I missed your last comment!  Thanks for working with me on this, LGTM.

Anytime! Thank you!


[VS Code] Opening Server in Browser: Service not available: portForwarding

Error:
Opening Server in Browser: Service not available: portForwarding
Steps to reproduce:

Join a live share someone has started from their link
Have them share their local host

Version Data

extensionName
VSLS

extensionVersion
1.0.694

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.37.1

platformName
Windows

platformVersion
10.0.17763

Closing as a duplicate of #2793.


Update WeekData.hx

No more need for manually editing weekdata, use a for loop instead.

yea sorry


Include Hostname where possible when MAC address filtering

Include Hostname where possible when MAC address filtering. This would make it easier to identify devices in the INFO page.

Hi..
Implement this feature is not much hard, but we need to maintain vendor database or we need to depending on online api, so low memory devices not much to hold.
But it may or may not planing. So fork this project and try.
Example
OUI Lookup Database:

Use a local OUI lookup database or an online service to match OUIs with vendor names.

curl https://api.macvendors.com/<MAC-ADDRESS>

Simple add first 3 values of mac eg: 00:25:98


Update references to AdoptOpenJDK to Adoptium

Update references to AdoptOpenJDK to Adoptium in various places in this repository.
Fixes #2558

@smlambert @llxia I have made a PR. Can you take a look so that we can discuss more about it.
PS: There were some conflicts which I have merged.
Thank You

This PR contains duplicate changes of https://github.com/adoptium/aqa-tests/pull/2542/ FYI @Mesbah-Alam

I would suggest removing the change-related aqa-systemtest as it is been taken care of in https://github.com/adoptium/aqa-tests/pull/2542

Please only update the repos mentioned in https://github.com/adoptium/aqa-tests/issues/2558#issue-874611199.

@llxia can you check it now please.
Thank You

Thanks @2001asjad
The above comments are not fully addressed. For example, there are still lots of adoptium/install-jdk . We should not change adoptopenjdk to AdoptOpenJDK. Please also address https://github.com/adoptium/aqa-tests/pull/2567#issuecomment-832918936

Thanks @2001asjad
The above comments are not fully addressed. For example, there are still lots of adoptium/install-jdk . We should not change adoptopenjdk to AdoptOpenJDK. Please also address #2567 (comment)

So you are saying I don't need to change the one's that are done in the draft of issue no 2542?

Please resolve the conflicts. Thanks

Please also rebase your branch to accept the latest changes delivered via https://github.com/adoptium/aqa-tests/pull/2542 and refresh this PR. Heads up: this could introduce some conflicts that may need to be resolved manually.

run aqa --help

@2001asjad - based on our meeting last week, I think you mentioned you will close this PR and open a new one to replace it.  I am just adding a note here as a reminder.  Thanks!

@2001asjad - based on our meeting last week, I think you mentioned you will close this PR and open a new one to replace it. I am just adding a note here as a reminder. Thanks!

Yes @smlambert I remember it of course.
Gonna work on it tonight.


accessibility resources channel

From aaron_h<PHONE_NUMBER>27239168):
an accessibility resource channel would be useful, with more people using Linux desktop with disabilities. Places for information are scattered everywhere, forums, email lists, etc and having somewhere to post them to for people to find would be nice.

This seems out of scope for the server itself, as it's not really intended to be a resource for specific information, rather than a community where you can ask questions.


Missing data loading code?

The document mentions to "load the data into an IDataView". Is it missing the code that does this step?
AB#1579020

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1b1fb0dd-648b-26e9-7e4e-48824ab94160
Version Independent ID: 689b6488-dadc-fd39-c432-ebf095a0299a
Content: Explain model predictions using Permutation Feature Importance - ML.NET
Content Source: docs/machine-learning/how-to-guides/explain-machine-learning-model-permutation-feature-importance-ml-net.md
Product: dotnet-ml
GitHub Login: @luisquintanilla
Microsoft Alias: luquinta

Hi @jwood803 ,
Thanks for the feedback. No missing code. This was done to leave it up to the user to load the data in whichever manner they prefer (file, from enumerable) although I can see how the wording can be confusing. Closing this issue and opening a new one to address similar language across the how-to guides to provide clarity.


Problem with SP formula in article and code

Hi,
I'm studying your SP-LIME method in the article and the code, and I don't understand why the code line and the formula below are equals:
current = np.dot((np.sum(abs(W)[V + [i]], axis=0) > 0), importance)  # coverage function

Why did you check if the sum of absolute value of W is > 0 ? Where is that part in the math formula ?
Thank you for your answer !

The code is the vectorized version of the formula you listed. abs(W)[V + [I]] is getting W[i] for i in V (in this case, the new V' with the added element). We're checking absolute values because weights can also be negative, as we say in the third paragraph of section 4 in the paper.
Checking if the sum is greater than zero is the same as checking if any element is greater than 0 (this is what is inside the brackets in the indicator function). This returns a boolean vector, which is multiplied by the importance.

A good way of convincing yourself that this is the case is creating your own W, V, and I, and running it through this code


Connecting over HTTPS

Hello,
I'm unable to connect to Aria using HTTPS. Aria is running on a MacOS server machine, and Web-UI on Apache.
On port 80 it's working perfectly, but not on port 443, where I constantly get an error message. (Nothing related to any security stuff)
I'd like to run it on port 443, because the web-ui will be accessible from outside, and an authentication will be added.
I made a lot of search, but nothing solves it. Moreover, the last version of web-aria2 does not even has configuration.js files anymore, and no JS directory too...
Any help would be appreciated.
Thanks !

Is your SLL cert valid ? Since the webui use a websocket connection, you wont be able to use a self-signed, expired or invalid certificate.
Also have you checked the :

If the above hints didn't help:

open the Google chome console
select the Console tab.
Navigate to the webui
Wait for a failure
Send all error messages that appears in it.

After doing some more research, it is something related to the certification of Aria itself. I asked for some help on it's Git here. My certificate are valid, as they are generated by Let's Encrypt, and connecting to the GUI itself works perfectly.
Which means, as WebUI Aria is not executing the commands locally on the server (via php for example, as both aria and apache are running on the same machine -this comment is a feature request 😉) but on the remote client, everything has to be encrypted...

I'm not sure about the configuration of the network topology of your servers. Are there 2 different machines for WebUI and Aria 2 separately? If not, then you can back-proxy the non-TLS WebSocket using mod_proxy_wstunnel so Aria 2 doesn't need SSL certificate anymore.

I solved that way.
First of all to use the https you must have aria2 compiled with openssl instead of gnutls ... (personal experience ... I already had these problems).
Then you have to create the site with apache2 in https and you must also launch aria2 with these options:
aria2 --enable-rpc --rpc-secure --rpc-listen-port = 6800 --rpc-certificate = certificate.crt --rpc-private-key = keyprivate.key
in this way you launch the air2 backend in "secure connection mode" in order to exploit the TLS connections. Finally, if you also use the web interface, you must also have, as I said before, the page in https in apache2.
I hope I have been helpful and sorry for my english;)

@vincenzogianfelice I suggest you use Apache to back-proxy /jsonrpc to Aria 2, including the WebSocket links. That also solves your problem in #480.
GnuTLS seems to be less reliable than OpenSSL. I've heard that GnuTLS doesn't work but OpenSSL does in several projects 🤔.

Sorry, could not find some time for this lately...
Aria has been installed from Homebrew, and I'd like to avoid compiling it myself as it would be easier for updating.
Aria and the UI are on the same server. And I'm thinking of using Reverse Proxy instead, as I want this UI to be a frontend for Aria, not as a client.
Isn't Mac OS using OpenSSL instead of GnuTLS ?

@Glujaz use aria2c -v to see which SSL lib it is compiled with.

It should be AppleTLS, at least that's what nix installed. aria2 is configured with  the following flags according to the brew forumla
     --disable-dependency-tracking
      --prefix=#{prefix}
      --with-appletls
      --with-libssh2
      --without-openssl
      --without-gnutls
      --without-libgmp
      --without-libnettle
      --without-libgcrypt


Breakpoint classes have no property for triggered breakpoints

When creating a new triggered breakpoint and handling debug.onDidChangeBreakpoints events, there's no breakpoint property that allows distinguishing between an unconditional breakpoint from a triggered breakpoint so that a language extension can perform any required actions. This could be solved by adding a waitFor string property, similar to the existing properties for the other types of breakpoints.

Can you explain the problem some more? What does a language extension need to distinguish them for?

How else can a language debugger know that it should only break at the triggered breakpoint if the specified breakpoint was hit first?
In the particular case of the language extension that I'm developing the debugger tool is able to handle all types of breakpoints except triggered breakpoints as VSCode as the BreakpointsChangeEvent argument doesn't provide the necessary information.

Also, the Breakpoint classes provide condition (for conditional breakpoints), hitCondition (for hit count breakpoints), and logMessage (for log points) properties. What makes triggered breakpoints an exception here? Why not keep the breakpoints API consistent?

If you're curious about the actual language extension code, its repo is at:
https://github.com/LogtalkDotOrg/logtalk-for-vscode
The function that handles the breakpoints is defined at:
https://github.com/LogtalkDotOrg/logtalk-for-vscode/blob/79a140fa0bfaf8e459cf505f9923362843c4f9af/src/features/logtalkTerminal.ts#L828
The Logtalk debugger tool runs in the integrated terminal with the communication of the breakpoint changes using a proxy vscode object.

I see, it looks like you're basically using extension API to implement something like a debugger, rather than a debug adapter using DAP: https://code.visualstudio.com/api/extension-guides/debugger-extension
But yeah, I guess triggered breakpoints haven't made it to the extension API yet. They are fairly new.

I'm looking into a partial, inline implementation of a debugger adapter. But it's not yet clear if it will work due to mismatches between VSCode and the language debugger and their features and limitations. In the particular case of triggered breakpoints, these are already supported by the language debugger and only the missing waitFor (or similarly named property) in VSCode *Breakpoint classes prevent the integration here.
Thanks for adding this feature request to the backlog. Looking forward to its implementation, which I hope will be fairly simple.

You may also want to check out the DebugAdapterTracker which lets you inspect communication to a DA


_getBrowser in src/index.js stuck in infinite loop

In src/index.js the _getBrowser routine gets stuck in an infinite loop when the browser element is closed and opened again by another lambda instance
browser.close();

// Lambda invoked again with reused context
puppeteerLambda.getBrowser({});    //Stuck forever

AWS Lambda reuses execution context, so if invoked too soon again, it gets stuck in a loop.
In src/index.js
if (null === globalBrowser && !getting) {
    //....;
}else{
    //infinite loop;
}

The if condition always fails if globalBrowser is null and the value of getting is true. On further inspection, the value of getting is not being set to false ever. Adding getting = false inside the if condition after the browser is successfully launched fixes the issue

Hi Shawn, the issue is still present. getting = false needs to be present at the end of if condition and not else
if (null === globalBrowser && !getting) {
        //...
        const version = await globalBrowser.version();
        console.log(`Launch chrome: ${version}`);
        getting = false; //inside if condition
        return globalBrowser;
} else{
        do {
            await Promise.delay(50);
        } while (!globalBrowser);
        // getting = false; <- Not required here
        return globalBrowser;
}


ValueError: The language 'arabic' is not supported. (I am not using arabic!)

I get the following error in a mkdocs project.
The documents are in Dutch, there is no arabic in the text anywhere.
So this error seems strange. I also created an issue in mkdocs (https://github.com/mkdocs/mkdocs/issues/2149), but the the problem seems to be in lunr
Are there any characters that are not supported, ie €, | , @ ...?
INFO    -  Building documentation...
Traceback (most recent call last):
File "/Users/ronny/anaconda/bin/mkdocs", line 8, in
sys.exit(cli())
File "/Users/ronny/anaconda/lib/python3.6/site-packages/click/core.py", line 829, in call
return self.main(*args, **kwargs)
File "/Users/ronny/anaconda/lib/python3.6/site-packages/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/Users/ronny/anaconda/lib/python3.6/site-packages/click/core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/Users/ronny/anaconda/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/Users/ronny/anaconda/lib/python3.6/site-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/Users/ronny/anaconda/lib/python3.6/site-packages/mkdocs/main.py", line 136, in serve_command
**kwargs
File "/Users/ronny/anaconda/lib/python3.6/site-packages/mkdocs/commands/serve.py", line 141, in serve
config = builder()
File "/Users/ronny/anaconda/lib/python3.6/site-packages/mkdocs/commands/serve.py", line 129, in builder
**kwargs
File "/Users/ronny/anaconda/lib/python3.6/site-packages/mkdocs/config/base.py", line 197, in load_config
errors, warnings = cfg.validate()
File "/Users/ronny/anaconda/lib/python3.6/site-packages/mkdocs/config/base.py", line 107, in validate
run_failed, run_warnings = self._validate()
File "/Users/ronny/anaconda/lib/python3.6/site-packages/mkdocs/config/base.py", line 62, in _validate
self[key] = config_option.validate(value)
File "/Users/ronny/anaconda/lib/python3.6/site-packages/mkdocs/config/config_options.py", line 131, in validate
return self.run_validation(value)
File "/Users/ronny/anaconda/lib/python3.6/site-packages/mkdocs/config/config_options.py", line 609, in run_validation
plgins[item] = self.load_plugin(item, cfg)
File "/Users/ronny/anaconda/lib/python3.6/site-packages/mkdocs/config/config_options.py", line 617, in load_plugin
Plugin = self.installed_plugins[name].load()
File "/Users/ronny/anaconda/lib/python3.6/site-packages/pkg_resources/init.py", line 2341, in load
return self.resolve()
File "/Users/ronny/anaconda/lib/python3.6/site-packages/pkg_resources/init.py", line 2347, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/Users/ronny/anaconda/lib/python3.6/site-packages/mkdocs/contrib/search/init.py", line 6, in
from mkdocs.contrib.search.search_index import SearchIndex
File "/Users/ronny/anaconda/lib/python3.6/site-packages/mkdocs/contrib/search/search_index.py", line 7, in
from lunr import lunr
File "/Users/ronny/anaconda/lib/python3.6/site-packages/lunr/init.py", line 5, in
from lunr.main import lunr
File "/Users/ronny/anaconda/lib/python3.6/site-packages/lunr/main.py", line 6, in
from lunr import languages as lang
File "/Users/ronny/anaconda/lib/python3.6/site-packages/lunr/languages/init.py", line 104, in
register_languages()
File "/Users/ronny/anaconda/lib/python3.6/site-packages/lunr/languages/init.py", line 95, in register_languages
language_stemmer = partial(nltk_stemmer, get_language_stemmer(language))
File "/Users/ronny/anaconda/lib/python3.6/site-packages/lunr/languages/stemmer.py", line 10, in get_language_stemmer
return SnowballStemmer(SUPPORTED_LANGUAGES[language])
File "/Users/ronny/anaconda/lib/python3.6/site-packages/nltk/stem/snowball.py", line 90, in init
raise ValueError("The language '{0}' is not supported.".format(language))
ValueError: The language 'arabic' is not supported.

So, I can understand that that would be a surprising error given you are not trying to use arabic!
At first glance this appears to be an issue with lunr-languages, which is a plugin for lunr that provides support for non-english languages. However I'm pretty sure that project does not provide support for arabic (it is an often requested feature).
Looking at the stack trace I see a bunch of python files, could it be this is actually coming from a Python port of lunr?

Correct, mkdocs uses the python port of lunr


Write a persistent storage backend design doc

We should document all of our Redis table schemas and uses

How's the progress of this issue. I looked at original design documentation but found nothing about persistent layer.

@simon-mo I will write it if it is not written yet.