Ruby group capstone - Catalog of my things: divided requirements

This Pr cosists of:

[ ] Create MusicAlbum class in a separate .rb file.

[ ] Create Genre class with an association to the Item class (in a separate .rb file).

[ ] All MusicAlbum class properties visible in the diagram should be defined and set up in the constructor method.

[ ] All Genre class properties visible in the diagram should be defined and set up in the constructor method.

[ ] Implement methods:

add_item method in the Genre class

should take an instance of the Item class as an input

should add the input item to the collection of items

should add self as a property of the item object (by using the correct setter from the item object)

[ ] can_be_archived?() in the MusicAlbum class

should override the method from the parent class

should return true if parent's method returns true AND if on_spotify equals true

otherwise, it should return false

[ ] Add unit tests for all implemented methods.

[ ] The following options should be available:

List all music albums

List all genres (e.g 'Comedy', 'Thriller')

Add a music album

[ ] All data should be preserved by saving collections in .json files.

[ ] Create a schema.sql file with tables that will be analogical to the structure of the classes that you created:

[ ] music_albums table (add all properties and associations from the parent Item class as table columns)

[ ] genres table

Thank you for reviewing my project.

Hi @Irirwanirira ,
Status: Approved ✅
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Good Highlights✔

Linter checks are passing
Detailed Pull Request

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


use base64 images instead of linking to website

I would suggest using base64 version of various images (company logo's etc) instead of linking it to your website. Might cause a concern as a query would be sent from public IP of user to your website.
I know far fetched thought but might just make sense if you have high number of subscriber as well as just to be on clear.

Thanks for the suggestion. At the moment, all Gmail users won't experience this problem since all images are re-routed through Google's own HTTPs proxy. I'll implement this when I get the time (hopefully soon).

This issue has now been fixed :) Sorry it took so long, but thank you for your support and this report.


Update frequency

I feel like every other time I launch Sublime Text, GoSublime updates and wants me to restart the app, and then I get the changelog. This is worsened by the fact that I use GoSublime on multiple machines. It's gotten rather annoying.
Can there be a less frequently updated release channel with major / critical updates only? Or silent updates?

This doesn't really answer your specific needs, but checkout #818.

@fogleman These are the installation instructions https://github.com/DisposaBoy/GoSublime#installation
Assuming you're using Package Control, @alexkavon  already told you how to stop the automatic update madness, but here is my position on it https://github.com/DisposaBoy/GoSublime/blob/master/SUPPORT.md#package-control

@DisposaBoy Great, thanks!


d3 graph not rendering.

My d3 graph was not rendering on the page, instead there was a blank space where the graph should be. There were no errors thrown.

My graph calculated width dynamically, based on the width of the page.
Setting the width variable on my d3 graph solved this issue.


Infinite Scroll + imagesLoaded ?

Is possible to load the next page after all images of this page has been loaded?
Any idea? Thank you!

Something like ...?
$container.imagesLoaded( function() {
  $container.infiniteScroll('loadNextPage');
});

See loadNextPage


Dockerfile to build scratch container with python in it

Need a simple Dockerfile that builds a container from scratch and adds the python binary to it.

As of 3552ad2746c71249bde673b7884dea25445739e3, this container is being built with a statically-compiled Hello World program in it to prove the idea. Still need a static python executable  to put there, as specified in #7.

Fixed with 77b5afa7bed57c0098faa0b1c233f0deb37cd779


fix(api): exchangeAccounts endpoints

:tada: This PR is included in version 1.10.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[FLINK-9603][connector-filesystem] fix part indexing, when part suffix is specified

What is the purpose of the change:
This pull-request fixes problem of incorrect part file index lookup, when part suffix is specified.
Part file path should be assembled with part suffix, before check on existance
Brief change log:
when creating new part file, add part suffix to part path before verification on file existence
Verifying this change:
The following tests, that verify part file indexing, have been added:

testThatPartIndexIsIncrementedWhenPartSuffixIsSpecifiedAndPreviousPartFileInProgressState
testThatPartIndexIsIncrementedWhenPartSuffixIsSpecifiedAndPreviousPartFileInPendingState
testThatPartIndexIsIncrementedWhenPartSuffixIsSpecifiedAndPreviousPartFileInFinalState
testThatPartIndexIsIncrementedWhenPartSuffixIsNotSpecifiedAndPreviousPartFileInProgressState
testThatPartIndexIsIncrementedWhenPartSuffixIsNotSpecifiedAndPreviousPartFileInPendingState
testThatPartIndexIsIncrementedWhenPartSuffixIsNotSpecifiedAndPreviousPartFileInFinalState

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (yes)

Documentation:

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable at this step)

Thanks for the work @kent2171 ! I will merge this as soon as Travis gives the green light!

nice to hear, thx you @kl0u

@kl0u Kostas, build failed, and said  src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkTest.java:[965] (regexp) RegexpSinglelineJava: Line has leading space characters; indentation should be performed with tabs only.
starts not from tab, I've checked in mine and yours repository, this line starts from 3 tabs, should I fix something ?

Hi @kent2171 ! Do not worry, I can fix it ;) Thanks for having a look!

cool, thx @kl0u


Proposal post type

[ ] Ability to create proposal posts
[ ] Display of proposals, including voting options and # of votes for each option.
[ ] Ability to vote on them by choosing options, until the proposal closes. And you can leave a comment as you vote which shows up as a comment on the post that also includes what option the person voted on at the front of the comment somehow
[ ] Ability for post creator to mark a proposal as passed or failed by post creator
[ ] New Governance view that shows all current open proposals and also past proposals with whether the passed or failed
[ ] Show on proposal whether quorum of votes needed for proposal to complete has been achieved or not (and how many more needed)
[ ] Proposals cant be edited after voting starts (?)

more conversation here: https://docs.google.com/document/d/1EUiiTtIyGAIEZRwF1uJtDk-FAyj3HchRZ5Kwf62cSv8/edit

Mobile: voting only for now
Manual switch isn't necessary for first version
Open voting state
Editing start and end dates is possible but might have complications
Stick with emoji and description, in lieu of full-description or tool-tip

who can see and who can vote question: how do we track this in the backend

Keep this as a separate ticket

Multi-voting is a nice-to-have; user gets 5 votes, across options all the options


🌱 Deflake apibinding immutability test

Summary
Wrap the patch in an eventually call to make sure we see the correct error (due eventual consistency of APIExports).
Related issue(s)
Fixes #

Unit flake #2518
Sharded flake #2479
/retest


Improve UI of API

When I use mouse to check these API, I found it is not easy for me to check which part is api help string.
It would be great if u guys improve the UI...

VSCode Version:
OS Version:

Steps to Reproduce:

Reproduces without extensions: Yes/No

@triphosphate what theme are you using? It looks like the theme doesn't have enough contrast to the background of hover.

Monokai… Yes, some themes work well but others not.
Sent from Mail for Windows 10
From: Peng Lyu
Sent: Tuesday, July 25, 2017 7:26 PM
To: Microsoft/vscode
Cc: triphosphate; Mention
Subject: Re: [Microsoft/vscode] Improve UI of API (#31413)
@triphosphate what theme are you using? It looks like the theme doesn't have enough contrast to the background of hover.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@triphosphate Please name the theme that need improvement. I went through the built-in themes and found that they all either have a hover border or a background color that is different enough from the editor background.

Monokai shipped with VSCode:

Monokai dimmed:

IMO the built-in themes look good. Please file the issue against the theme extension where you see the problem.


Calculate THD

It should be possible to calculate THD from the peaks in the spectrum, as opposed to THD+N which includes noise, too.  Should read the same thing even if you add noise to a given wave.

Fixed in https://github.com/endolith/waveform-analysis/commit/922da8d1e6c359378e349c415d3517f32f1c5fbc

Should read the same thing even if you add noise to a given wave.

Should add a test for this, though.


[added] update README regarding onAfterOpen and Jest

Changes proposed:

Providing an additional section in the README related to the post v3.14.1 change to the behavior of the onAfterOpen prop and how it can break Jest tests related to it.

I am not sure if this is the best way to communicate this change, but I can speak from experience that this was an unexpectedly disruptive one in my organization, and hopefully this can spare others the time it took me to discover the source of a number of failing tests when I made the minor update.
Acceptance Checklist:

[ ] The commit message follows the guidelines in CONTRIBUTING.md.
[ ] Documentation (README.md) and examples have been updated as needed.
[ ] If this is a code change, a spec testing the functionality has been added.
[ ] If the commit message has [changed] or [removed], there is an upgrade path above.

Coverage remained the same at 84.737% when pulling 8c0f219d3c6221de27c4c7e7c498d6d9ae6ae38f on postrad:docs/on-after-open-jest into b33923a8756b0acb2bab8a7150320c4285710c5e on reactjs:master.


Allow using a different identifier for message de-duplication

Is your feature request related to a problem? Please describe.
Currently the deduplication is based on producer name. The producer name is associated with a connection. Pulsar doesn't allow two concurrent connections with same producer name. In most of the cases, that is good enough.
However in connector use case, copying a Kafka partition to a Pulsar partition. We can use Kafka offset as the sequence id and the Kafka partition name as the unifier identifier. It is more convenient  if a producer can be allowed to use a customer id to configure, so we don't need to tied to a producer name.

Closed as stale and no one seems to work on it. Please create a new issue if it's still relevant to the maintained versions.


cannot logout from kybase.io

after hitting logout button, I'm not fully logged out. The header suggests I'm not logged in, but I can still manage my keybase account. So how can I be sure I have logged out????
Regards
Piotr

The page you have shown is fully public.  For instance this is my device page.


February meetup

February 21st.

[x] Speaker: @astashov on Immutable.js?
[ ] Sponsor:
[ ] Venue: will confirm early February

I'd prefer after February, in January on February I may have to go to California for a holiday party, the dates are tentative so far, so I don't want to accidentally them overlap with the meetup dates.

Ah, right on, in that case @markedwardsims would you be willing to speak February 21st instead of April?

I'd love to, but I'll be on a family vacation that week. Let me double check to make certain.

Okay, so the holiday party gonna be on Jan, 27, so I can make it with the talk in Feb, if you are still interested :)

Perfect, thanks Anton, we'll lock you in for Feb!


istioctl get gateways/policies not working

Executing istioctl get suggests the following:
specify the type of resource to get. Types are routerule, egressrule, destinationpolicy, httpapispec, httpapispecbinding, quotaspec, quotaspecbinding, servicerole, servicerolebinding, virtualservice, gateway, serviceentry, destinationrule, policy
From the above list, istioctl get does not work properly for gateway and policy resources.
$ istioctl get gateways
...
Error: "gateways" not recognized. Please use non-hyphenated resource name "gateways"

$ istioctl get policies
...
Error: "policies" not recognized. Please use non-hyphenated resource name "policies"

strange that this works with kubectl
kubectl get gateways
NAME              AGE
httpbin-gateway   8m

@ZackButcher mentioned this is caused by the CRD that is used by istioctl is out of sync with the CRD used by k8s.  the release call agrees this is a release blocker.

Fixed by https://github.com/istio/istio/pull/5395

I am also facing the same issue .. I am able to create egress gateway rules.. but neither not able to delete or get it...  is this fixed in 0.8...? I am facing the following error:
_[root@xxxx bin]# ./istioctl get gateway
Usage:
istioctl get  [] [flags]
Examples:
List all route rules
istioctl get routerules
Error: Please use non-hyphenated resource name "gateway"_

This is fixed in 0.8 dailies.  You only need to dow load the CLI.


wip(windows): make sure app panics show up in the logs

Related to this discussion https://github.com/firezone/firezone/pull/2990#discussion_r1439629571
Add a dependency on the tracing-panic crate. This is about 100 lines of code that adds a panic handle so app panics get a line number, file name, etc. in the logs. No backtrace I think since we stripe symbols for release builds. I think the line numbers are baked into the panic macro so those might still stay.
@conectado I should remove the debug command before closing it, right?

@conectado If it's okay to have that panic hook before connlib starts, was there anything else I should change on this PR?

@conectado If it's okay to have that panic hook before connlib starts, was there anything else I should change on this PR?

Yeah, we can merge it, I was just checking and connlib calls the old hook after using its own so the logging should work


[dv/xcelium] Fix Xcelium nightly regression error

This PR fixes the xcelium nightly regression error because we export
cov_merge_cmd in the enviornment.
In the command line, current what we see is that:
cov_merge_cmd={prefix} imc
The space between {prefix} and imc will cause trouble and
cov_merge_cmd ends up not loading the correct cmd.
To fix this issue, we add a single quotation, now the export command
looks like this:
cov_merge_cmd={prefix} imc
Thanks @weicaiyang for debugging this issue.
Signed-off-by: Cindy Chen<EMAIL_ADDRESS>

@cindychip this is now causing issue on WDC side.
can you remind me how to reproduce the original issue so I can check my fix?


Create Owner snippet is incorrect.

The snippet below, at this docs link here is incorrect.
var directoryObject = new DirectoryObject
{
	AdditionalData = new Dictionary<string, object>()
	{
		{"@odata.id","https://graph.microsoft.com/beta/directoryObjects/{id}"}
	}
};

await graphClient.Applications["{id}"].Owners.References
	.Request()
	.AddAsync(directoryObject);

Ideally it should be something like this.
var directoryObject = new DirectoryObject
{
	Id=userId
};

await graphClient.Applications["{id}"].Owners.References
	.Request()
	.AddAsync(directoryObject);

https://github.com/microsoftgraph/microsoft-graph-docs/issues/5727

Similarly, the java snippet at this link should not look like this.
IGraphServiceClient graphClient = GraphServiceClient.builder().authenticationProvider( authProvider ).buildClient();

DirectoryObject directoryObject = new DirectoryObject();
<EMAIL_ADDRESS>new JsonPrimitive("https://graph.microsoft.com/v1.0/users/{id}"));

graphClient.groups("{id}").owners().references()
	.buildRequest()
	.post(directoryObject);

but should also set the ID property of the DirectoryObject object as follows,
IGraphServiceClient graphClient = GraphServiceClient.builder().authenticationProvider( authProvider ).buildClient();

DirectoryObject directoryObject = new DirectoryObject();
directoryObject.Id = "{id}";

graphClient.groups("{id}").owners().references()
	.buildRequest()
	.post(directoryObject);


Use database helpers from mariadb-operator/api

The lib-common/modules/database is moved to mariadb-operator/api to remove a circular dependency.

/test heat-operator-build-deploy-kuttl
failed to wait for the created cluster claim to become ready: timed out waiting for the condition


Correctly detect publicity of modules inside directories

Continuation of PR #470 as @tibdex was taking a little to respond, and their PR relates to issue #493 that I opened.
I branched off @tibdex's work so they get contribution credits for the work they did. Thank you @tibdex!!
@samj1912 @Nurdok Please review. This uses pathlib in the parser_test.py now.

@samj1912 What's you're expectation of this test?
    module = parser.parse(code, str(parent_path / "_private_pkg" / "filepath"))
    assert not module.is_public

My expectation is that this should pass?
Thus, a module containing no leading underscore in a private package should be considered private.

Publicity is inherently affected by where you run pydocstyle.
Consider the following example.
$ tree -F publicpackage/ ↵
publicpackage/
├── __init__.py
└── _privatepackage/
    └── some_private_module.py

$ pydocstyle publicpackage/ ↵

$ cd publicpackage/_privatepackage && pydocstyle some_private_module.py ↵
some_private_module.py:1 at module level:
        D100: Missing docstring in public module

To determine publicity correctly, we should probably be passing what the top-level package is to pydocstyle.
However, maybe we can simply document this limitation for now.
This was brought up in #326 in this comment.
@Nurdok @samj1912 thoughts?

I was on vacation, thanks for taking over @gbroques 👍. I'll close my PR.

I was on vacation, thanks for taking over @gbroques 👍. I'll close my PR.

Not a problem! Thank you for your initial work on this.
Hopefully we can get it merged :)

lgtm, thanks for the patch. I will wait for @Nurdok to get a chance to look as well. :)

@samj1912 Sure, thanks for helping maintain and support this library! 🙂

@gbroques Thank you for being so persistent and patient about this PR. I think this is good to go but I would like @Nurdok to take a look before merging since he had the last significant review on this PR.

No worries! I really appreciate all the excellent feedback you and @Nurdok have provided, and this is just a small way I can say thank you for the work you two do. :)


Only allow users associated with a client to log in to it

This means that only users which has been explicitly linked to
a particular application (e.g. bank admin, cashbook) can authenticate
with that client. This means that a prison clerk cannot log in to
bank admin (unless they have been allowed to).
Uses a new table mtp_auth_applicationusermapping to store the mapping
of users to applications which they can log in to.

@marcofucci for your consideration

@ibrechin looks good! Ready to be merged?

@marcofucci do it


How to simplify dc:Elements.

@highsource I tried the new version (2.1.2) of jsonix with simplified mappings, all unmarshaled objects are easy to read.
It is posible to also simplify the dcElement in a csw:Record ? Instead an array of attributtes maybe an object with atributtes ?
Related issue #56
Proposed:

"dcElement": {
    "dc:identifier": "0173e0d7-6ea9-4407-b846-f29d6bfa9903",
    "dc:title":"Aerial Photos",
    "dc:anotherAttr": "xxxxx",
    ....................
    }

Actual:
{
    "csw:Record": {
        "TYPE_NAME": "CSW_2_0_2.RecordType",
        "dcElement": [
            {
                "dc:identifier": {
                    "TYPE_NAME": "DC_1_1.SimpleLiteral",
                    "content": [
                        "0173e0d7-6ea9-4407-b846-f29d6bfa9903"
                    ]
                }
            },
            {
                "dc:title": {
                    "TYPE_NAME": "DC_1_1.SimpleLiteral",
                    "content": [
                        "Aerial Photos"
                    ]
                }
            },
            {
                "dc:type": {
                    "TYPE_NAME": "DC_1_1.SimpleLiteral",
                    "content": [
                        "dataset"
                    ]
                }
            },
            {
                "dc:subject": {
                    "TYPE_NAME": "DC_1_1.SimpleLiteral",
                    "content": [
                        "Orthoimagery"
                    ]
                }
            },
            {
                "dct:references": {
                    "TYPE_NAME": "DC_1_1.SimpleLiteral",
                    "scheme": "None",
                    "content": [
                        "http://www.ypaat.gr"
                    ]
                }
            },
            {
                "dc:date": {
                    "TYPE_NAME": "DC_1_1.SimpleLiteral",
                    "content": [
                        "2009-10-09"
                    ]
                }
            },
            {
                "dc:rights": {
                    "TYPE_NAME": "DC_1_1.SimpleLiteral",
                    "content": [
                        "otherRestrictions"
                    ]
                }
            }
        ],
        "boundingBox": [
            {
                "ows:BoundingBox": {
                    "TYPE_NAME": "OWS_1_0_0.BoundingBoxType",
                    "crs": "urn:x-ogc:def:crs:EPSG:6.11:4326",
                    "dimensions": 2,
                    "lowerCorner": [
                        38,
                        20
                    ],
                    "upperCorner": [
                        40,
                        24
                    ]
                }
            }
        ]
    }
}

Thanks in advance
JM

Cool idea.


Some problems

The same hyperparameter combination will appear in the same budget. Is it the reason for np.random.choice? Thanks!

https://github.com/goktug97/bohb-hpo/blob/2c79d9e3d7d7182388ba196aa297257f190bb8e3/bohb/bohb.py#L118-L124
You are right, I think it shouldn't sample from the previous budget. Pushed a new commit to only sample new random configuration if there is no kde model present or if the random_percent condition is hold. Depending on the configspace size I think it is still possible to see duplicated but I think it is normal.

What you said is correct, and I look forward to your update! Thank you!!


want to ip address restrict at Access Control

Environment information
System:
  OS: macOS 14.4.1
  CPU: (20) arm64 Apple M1 Ultra
  Memory: 7.13 GB / 128.00 GB
  Shell: /opt/homebrew/bin/fish
Binaries:
  Node: 18.17.0 - ~/.local/share/nvm/v18.17.0/bin/node
  Yarn: 1.22.21 - ~/.local/share/nvm/v18.17.0/bin/yarn
  npm: 9.6.7 - ~/.local/share/nvm/v18.17.0/bin/npm
  pnpm: undefined - undefined
NPM Packages:
  @aws-amplify/backend: Not Found
  @aws-amplify/backend-cli: Not Found
  aws-amplify: Not Found
  aws-cdk: Not Found
  aws-cdk-lib: Not Found
  typescript: 5.2.2
AWS environment variables:
  AWS_STS_REGIONAL_ENDPOINTS = regional
  AWS_NODEJS_CONNECTION_REUSE_ENABLED = 1
  AWS_SDK_LOAD_CONFIG = 1
No CDK environment variables

Description
Amplify app can setting access control at aws amplify console.
now i want to set not only Username and Password access but also, ip access controll.

Hey @magisystem0408, thank you for reaching out. Marking this as feature request to support ip access control on Access control.

Closing this issue, as this is currently being tracked on https://github.com/aws-amplify/amplify-hosting/issues/36. Do subscribe to the issue for any further updates.


Version number overlaps page elements

Ideally it should be part of the page and just show at the bottom. If not, maybe we should just remove it from the page.

Closing this issue. Will address improvement in the footer issue https://github.com/clowder-framework/clowder2/issues/961


Make Application Insights for Spring native work with OTel 2.2.0

can you update the tests too? i have disabled it per our discussion.


chore(mempool_infra): unify trait bounds

Stack:

#939 ⬅
#938

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


add ujson pin, pip check

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Have seen this a few times, most recently with a mixed install of conda/pip stuff that ended up with some inconsistent versions:
pkg_resources.ContextualVersionConflict: (ujson 2.0.3 (/opt/conda/lib/python3.7/site-packages), Requirement.parse('ujson<=1.35; platform_system != "Windows"'), {'python-jsonrpc-server'})

this should help keep us honest until something better comes along.
Provided this is merged, I guess we might want to mark 0 broken?

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin please rerender

@bollwyvl, you should mark 0.3.4 build 0 as broken here:
https://github.com/conda-forge/cf-mark-broken
Else it's going to be picked by conda in favor of build 1.

you should mark 0.3.4 build 0 as broken here:

Unfortunately, this pin has been in setup.py for the whole 0.3.0 line... and dry run is presently pulling in _1. This is probably the best we can do for now...


twitter bot for ubiquity

https://github.com/ubiquity/bounty-bot/issues/55 and https://github.com/ubiquity/bounty-bot/issues/56

I am gonna holding off this PR until the PR merged into development. The reason why that PR has the base architecture for adapters like supabase, telegram, etc.

It's ok now @pavlovcik ?

What now @0xcodercrane ?

@0xcodercrane


Delete costpackage parameter from conformity api request in account c…

…reation, and adding the fresh_deploy inside the handler
Issue
"costPackage" parameter in account creation for conformity api it's deprecated.
#, if available:
Description of changes:
Comment the line 57 #"costPackage": False, in c1cconnectorapi.py script
adding fresh_deploy method to invoke actions for to make a test and re-deploy the creation of IAM Cross Account Roles.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/do-e2e-tests

/do-e2e-tests

/do-e2e-tests


Work failed in line is_new_file = args.is_new_file[file_name]

The check-copyright works for me weeks ago, but currently we found the CI running always fail with：
Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/libo/.espressif/python_env/idf4.4_py3.10_env/lib/python3.10/site-packages/check_copyright.py", line 722, in <module>
    main()
  File "/home/libo/.espressif/python_env/idf4.4_py3.10_env/lib/python3.10/site-packages/check_copyright.py", line 684, in main
    wrong_header_files, modified_files, must_be_updated = check_copyrights(args, config)
  File "/home/libo/.espressif/python_env/idf4.4_py3.10_env/lib/python3.10/site-packages/check_copyright.py", line 511, in check_copyrights
    is_new_file = args.is_new_file[file_name]
KeyError: './examples/camera/video_recorder/components/avi_video_process/avi_def.h'

Run follow command in esp-iot-solution repo to reproduce the bug:
python -m check_copyright --verbose --dry-run --ignore tools/ci/ignore_list_copyright.txt --config tools/ci/check_copyright_config.yaml .

Please help to analyze the root of the problem.

Specify the install version to v1.0.3 can fix.

Hello @leeebo ,
thank you for the report. It seems that
is_new_file = args.is_new_file[file_name]
should actually be
is_new_file = args.is_new_file(file_name)
The dict contains just newly added files, not all that are modified.

Thanks for reporting this @leeebo. Looks like the update I made didn't take into account that the check_copyright.py script can be run standalone on a repository with no files in the git staging area. Will make a fix for this.

@sudeep-mohanty @fhrbata The latest fix https://github.com/espressif/check-copyright/pull/13 works for me now, thanks!


DISCO-629: Remove unused MarketInsights components for Artwork page

This pull request removes a reference to a Market Insights component in reaction directly inserted via Force.
This component does not seem to be in-use currently. Instead, it looks like we're inserting a newer Market Insights component which is part of the new Responsive Artwork Page in artsy/reaction.
This also unblocks removal of the older component in artsy/reaction.
ticket: https://artsyproduct.atlassian.net/browse/DISCO-629 :lock:

@dblandin - This is actually the same component from Reaction that's currently used in the new pages. Normally we use stitch to inject these things but this basically does the same thing.

@damassi I'm still a little confused.
It looks like the new responsive Artist page renders the Styleguide/Components/MarketInsights.tsx component and uses just one exported function from the Components/Artist/MarketInsights/MarketInsights.tsx component (referenced in this PR).
The component referenced in this diff doesn't seem to be rendered anymore. I can't find the mount element id format referenced in any Force template.
Running this diff locally, the current version of Artist insights still show up, leading me to believe that the rendering is now handled within reaction and isn't needed here.

Ah, you are indeed correct -- looks like this is now a part of the ArtistInfo component, which is rendered in its entirety into the old page via stitch. Carry on :)


Agt2hc/feat/80/plantuml plugin for vs codium

This pull request contain fixes for these issues:

https://github.com/test-fullautomation/robotframework-testsuitesmanagement/issues/104 overwrite version number for testsuit management
https://github.com/test-fullautomation/RobotFramework_AIO/issues/86 draw io extensions
https://github.com/test-fullautomation/RobotFramework_AIO/issues/80 plantuml extensions

Add GENDOC_PLANTUML to the installer too.

Hi Nguyen,
thank you for the pull-request.
Please inform me once you commited the update for  GENDOC_PLANTUML as part of the installers (Win, Linux)
Thomas


textAlignRight for PriceAxisWidget

Type of PR: enhancement
This PR adds an option to align price axis labels to the right when using rightPriceScale.
PR checklist:

[x] Addresses an existing issue: fixes #1007
[ ] Includes tests
[ ] Documentation update

Overview of change:

added textAlignRight: boolean to
PriceScaleOptions
added calculateAlignRightOffset to LabelsImageCache
added offset calculation to PriceAxisViewRenderer.draw

Thanks for your interest and contribution to the library, but as I said in the ticket - I don't think that this feature fits our understanding of the product and its requirements/features, so I'm afraid we aren't going to implement it nor merge a pull with the changes for it. So I'm going to close this PR.


Question: is spellwarn.nvim supported

I recently found spellwarn.nvim and tried to get it to work with tiny-inline-diagnostic.nvim, but I was unable to get it to work.

Did you already have an LSP started in your buffer, or was it only spellwarn?

Works great on my side:

Did you follow the installation procedure from spellwarn by setting vim.opt.spell = true and vim.opt.spelllang = { "en" }?

I'm not here to debug your configuration, sorry as your minimal configuration doesn't even work.
For making the plugin to work in your case, you needs to either have an LSP or have options.overwrite_events = {"DiagnosticChanged"} set.
In your minimal example, you don't have Mason or LSPConfig set up, so you'll need to configure overwrite_events for it to work.


On Modroid: Scrolling a ScrollableViewPort often fails to fling when lifting a finger at speed.

Possibly related to an issue where on Linux if you click a button that triggers animations those animations don't trigger (nor does the pointer event I think) until the pointer is moved post-click.

This seems to be related to the switch over to MojoShell.  I didn't see it as often in SkyShell.

Modroid isn't a thing anymore.


update configuration: support all authentication methods

Depends on #61

Update cloudant-java-sdk to latest
Add support for all authentication methods including IAM
Add tests for above

Will fix #47

Done with #69 #70


aria-hidden + aria-describedby

Mention : https://twitter.com/goetsu/status/589002559429423104
aria-hidden and aria-describedby may be conflicted.

VoiceOver speech describedby linked element content, event with aria-hidden=true attribute. More, this example implements tooltip the same way we do: http://www.w3.org/WAI/PF/aria-practices/#line1.


Button type='submit' and custom usePress div pointer mobile event clicking on next screen with react router

Provide a general summary of the issue here
Press events triggering on next screen when routing with react router.
I am assuming this is the same issue #7026  that this tries to fix but i am still going to report it since it might help having another case added.
🤔 Expected Behavior?
Whenever we click on a button on one screen and that button routes to a different route with the same layout it should not trigger the form submit event or the active browser event on the new button that appears.
😯 Current Behavior
https://github.com/user-attachments/assets/832186cf-e33e-40d1-a5df-89cf779463b0
When in mobile simulated touch view or in mobile device (tested on android).
If we have two buttons on different screens both with type 'submit' if we switch screens in react router and the layout of both buttons is the same it should not trigger the event of submitting on the next button.
💁 Possible Solution
No response
🔦 Context
No response
🖥 Steps to Reproduce
Have two routes in react router without layout changes where two buttons overlap and have type submits and you can achieve this bug.
If the second button only has type submit and no onPress handler it automatically submits the form if it does have a onPress handler then in doesn't trigger the onPress event but the button seems to get focused by the browser.
https://codesandbox.io/p/sandbox/flamboyant-euler-src8pf?file=%2Fsrc%2FFirstPage.tsx%3A15%2C1&workspaceId=aaa23462-9fa5-46e4-a903-63e99d72520b
Version
3.31.0
What browsers are you seeing the problem on?
Firefox, Chrome
If other, please specify.
No response
What operating system are you using?
Mac OS
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

Verified on my Android device, unfortunately this happens because we actually allow the press event to go through if it is on a submit type button: https://github.com/adobe/react-spectrum/blob/09ccc53e71a0c423fea04bd9f8a80a6a97b14787/packages/%40react-aria/interactions/src/usePress.ts#L528-L532 as per the assumption described here. Will have to see if there are any alternatives checks that could be made but I'm not sure if we have enough information in usePress to know when it would be appropriate to not prevent default, especially for form submit buttons

Now that i understand what is happening i can add some workaround in our codebases for example not using automatic submition if forms overlap but still as a temporary measure this should be included in the docs so that users can be informed of this behaviour.


hashedMirrors are trusted return correct data

Describe the bug
A clear and concise description of what the bug is.
Hashed mirrors are trusted to return the correct data and error out otherwise. If a hashedMirror returns wrong data without an error status, the build fails (it might not be able to even produce an output path from the bad data).
Incidentally, the default hashedMirrors is http://tarballs.nixos.org which can freely be intercepted.
Can that be upgraded to https without breaking bootstrapping or similar? (because of potentially missing SSL certs?) @edolstra
To Reproduce
Steps to reproduce the behavior:
An easy way to repro would be to put a website that returns bad data with 200 on any requested file into hashedMirrors but I can't think of any easily accessible ones unfortunately.
Expected behavior
A clear and concise description of what you expected to happen.
The data should be verified to actually have the wanted hash and the next mirror should be chosen if it's bad.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
 Internet works just fine everywhere else (including http in Firefox and Safari).
In my case, trying to fetch gave me a very confusing "failed to produce output path" error.
Related https://github.com/NixOS/nixpkgs/issues/2284
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

I believe fetchurl doesn't verify the certs (I'll be assuming modes with fixed hash here).
There's not much point to verify the server, except in the sub-case where people copy the hash from somewhere and make it build (and fail) to obtain the correct hash.  I'm afraid that's not too rare of "misuse", and especially with some variants (e.g. fetchpatch) it might even be the only comfortable way of getting the hash (as far as I know, at least).

except in the sub-case where people copy the hash from somewhere and make it build (and fail) to obtain the correct hash.

In my issue, tarballs.nixos.org doesn't have the hash in question but returns data anyways because it's been intercepted.
This would be even more problematic in the use-case you're describing because you'd get the hash of the bogus data at the end and be even more confused.

In the other issue efficiency was quoted as a downside to verifying the hashedMirror's content but couldn't we hash while downloading (e.g. curl $url | tee $out | sha256sum)? This way it'd be done concurrently and shouldn't impact much of anything.

Efficiency: I can't see the reference, but as I see it the problem is that for generic fixed-output derivations Nix guarantees the hash of the result (whatever the builder does).  Therefore it has to compute the hash itself after the builder finishes.  Therefore if you want to do any action (like fallback) inside the builder itself, you need to compute the hash twice (at least).

http/s: I expect the main motivation for switching would be privacy.  As it is now, any on-path attackers could see what you download (on success) or at least hashes of what you fail to download. (Though not parts substituted from https://cache.nixos.org and those should be the majority.)


PoolManagers are overly case-sensitive.

In a URI, both scheme and authority are case-insensitive: that is, the scheme, host, and port should all be considered case insensitively (and basically treated as lower-case).
Unfortunately, the PoolManager and ProxyManager do not consistently do that. The biggest problem is in the ProxyManager, where connection_from_host will incorrectly treat any HTTPS scheme with a capital letter in it like a HTTP connection (which isn't great), but the flaw is pretty common elsewhere in those objects (e.g. an uppercased host will get a different connection pool to a lowercased host).
At the very minimum we should be using a lowercased scheme at all points in the urllib3 stack. We should also consider whether we want to be case-sensitive about domains (I'm inclined to say that we do not).
Related: kennethreitz/requests#3075.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/32609352-poolmanagers-are-overly-case-sensitive?utm_campaign=plugin&utm_content=tracker%2F192525&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F192525&utm_medium=issues&utm_source=github).

+1, we should build this behaviour into our new PoolKey namedtuples somehow. Maybe we need a duck interface that returns normalized tuple values given some request context. Like:
pool_key = pool_key_cls.from_request(request_content)  # Or some better method name

Then we can build in the lower-casing normalizing logic into the pool_key_cls as-needed.

I'm not entirely sure that's enough, but to be fair I'm not sat down with the code right now so I can't be sure.


SAP HANA, express edition, in Google Cloud Platform Launcher

"The next page will allow you to modify the default configuration for the Cloud Virtual Machine." - mention is takes 2-3 minutes for the next page to load.

What's the feedback here? That GCP's pages took too long to load for you?

Yes, the page has been loading for more that 2 minutes.

Loads almost instantly for me. GCP has a feedback button on the top right corner in case you're interested in letting them know.


v4 Doesn't attempt connection to provided IP (always attempts localhost connection)

Issue
I'm trying to connect to an Elasticache cluster from Lambda but I'm receiving connection errors of Redis client error: Error: connect ECONNREFUSED <IP_ADDRESS>:6379. It doesn't look like the createClient command is correctly parsing the IP from the url parameter.
This is my first time using redis so it may be a mistake on my part.
const { Resolver } = require('dns').promises;
const { createClient } = require("redis");
const resolver = new Resolver();

exports.handler = async event => {
  // writer endpoint in aws console is <redacted>.apse2.cache.amazonaws.com:6379
  const cacheIp = await resolver.resolve4('<redacted>.apse2.cache.amazonaws.com')
  console.log('cacheIp: ', cacheIp)
  const client = createClient({ url: `redis://${cacheIp}:6379` });
  client.on("error", err => console.log("Redis client error: ", err));
  await client.connect();

  console.log('after connect');

Log Output:

Environment

Node 14.x Lambda runtime

Elasticache Redis 6.x

Lambda

In rc.0 and rc.1 the url is in the socket configuration:
createClient({
  socket: {
    url: '...'
  }
});

I've already changed it in master, but it wasn't released yet, so from next version you'll need to move it back to:
createClient({
  url: '...'
});

Thanks @leibale 👍

Hey, I'm also hitting this error with 4.0.1.
No matter what host I use, it uses localhost.

@SirCameron can you please share your code (without sensitive information)?

Hey @leibale
I've tried:
const redisClient = createClient({
  socket: {
    url: 'redis://redis',
  },
})
redisClient.connect()

and
const redisClient = createClient({
  url: 'redis://redis',
})
redisClient.connect()

running in a docker container where redis is the redis container. I've tried exec-ing into the container and testing the redis connection with redis-cli and all works.


deprecate SFF class

The purpose of this library is to generate spectrograms from signals using FFT. The output of a spectrogram is just a 2D array of floating point values.
The SFF (spectrogram file format) was originally created to store and recall this 2D array along with a small header in a binary file format. This binary format is not useful outside of this package, and SFF is not a standard format supported by commercial software. Maintaining this file format lies outside of the scope of this library, and users who wish to save spectrogram data are encouraged to write their own IO routines.
Tip: A JSON header would be much easier to maintain than the SFF header (which requires specific knowledge about the bit location and structure of values in the binary content of the file).

Here is the code that is being deprecated.
Users can copy/paste this logic into their own applications as desired.
SpectrogramGenerator.SaveData()
https://github.com/swharden/Spectrogram/blob/f647f09350809f7ef641cdd326c418e4c3b46eb5/src/Spectrogram/SpectrogramGenerator.cs#L353-L361
SffMeanFFT()
https://github.com/swharden/Spectrogram/blob/f647f09350809f7ef641cdd326c418e4c3b46eb5/src/Spectrogram/Tools.cs#L10-L32
SffMeanPower()
https://github.com/swharden/Spectrogram/blob/f647f09350809f7ef641cdd326c418e4c3b46eb5/src/Spectrogram/Tools.cs#L34-L49
GetPeakFrequency()
https://github.com/swharden/Spectrogram/blob/f647f09350809f7ef641cdd326c418e4c3b46eb5/src/Spectrogram/Tools.cs#L51-L78
SFF Class
https://github.com/swharden/Spectrogram/blob/f647f09350809f7ef641cdd326c418e4c3b46eb5/src/Spectrogram/SFF.cs#L11-L285


fleek apply suddenly causes errors on MacOS

Bug 🐛
After a factory reset of my laptop yesterday I installed fleek without any issues and was able to add packages and run fleek apply. I noticed that when I would switch to WiFi instead of an ethernet connection I started getting an error similar to the one below. This morning I get the error regardless of whether I am on WiFi or Ethernet when I run fleek apply.
 [d]  Command stderr: warning: not writing modified lock file of flake 'flake:home-manager/master':
      • Removed input 'utils'
      error: flake 'path:/Users/brettkolodny/.local/share/fleek' does not provide attribute<EMAIL_ADDRESS><EMAIL_ADDRESS>or<EMAIL_ADDRESS>
 [d]
      ExecutionID:8235992e1c3544cab2b9b201a93f88f0

Environment

OS: Apple M1 Max, Ventura 13.2
Shell: zsh
fleek version: v0.8.4

I seem to have figured out a fix. My hostname was Bretts-MB-Pro-4.lan at one point but now is being reported as bretts-mb-pro-4.lan. Changing the hostname in .fleek.yml to the lowercase version and then renaming the Bretts-MB-Pro-4.lan folder in .local/share/fleek to bretts-mb-pro-4.lan makes it work again.
I think this issue may stem from MacOS not having case sensitive file system but Nix expecting one?

I ended up doing another fresh install of my OS and noticed another oddity. On first install immediately installing Nix and Fleek worked great. I saw that my hostname was macbook-pro on that first login. After restarting the computer my hostname was then changed to bretts-mbp.lan causing fleek apply to fail with the same error as above. Copying my macbook-pro.lan directory to bretts-mbp.lan then fixed the issue again.
Most of these seem to not end up being issues with nix/fleek but just with some weird things that MacOS is doing. May be good to add this info to the installation page on the website.

very interesting. I wonder if there's another way to identify a mac that's more reliable than the hostname.

very interesting. I wonder if there's another way to identify a mac that's more reliable than the hostname.

Other than running something like uname ? That should return Darwin on a Mac of course. Unless its running Linux or something else :)

I'm sorry I meant to uniquely identify... where "uniquely" just means among
your configured hosts in fleek.
On Wed, Apr 19, 2023 at 10:22 AM Mike @.***> wrote:

very interesting. I wonder if there's another way to identify a mac that's
more reliable than the hostname.
Other than running something like uname ? That should return Darwin on a
Mac of course. Unless its running Linux or something else :)
—
Reply to this email directly, view it on GitHub
https://github.com/ublue-os/fleek/issues/149#issuecomment-1514827126,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAJE5BZUOBUFAODWAU5U33XB7YLLANCNFSM6AAAAAAW7N5HC4
.
You are receiving this because you commented.Message ID:
@.***>

--

Brian Ketelsen
bketelsen  gmail  com

ioreg -l | grep IOPlatformSerialNumber | awk '{print $NF}' will provide the device's serial number

Device serial number or mac address would be the best options imho.

And MAC address can be changed, which I occasionally have to do for people to help them bypass Comcast device authorizations.

And MAC address can be changed, which I occasionally have to do for people to help them bypass Comcast device authorizations.

That is true @tml, but it reverts after restart. They would have to apply the custom mac address every time after startup, hence why using device serial (per you suggestion) and MAC Address are really the only two best options and a MAC Address is OS agnostic where a device serial may not be easy to retrieve on a non-macos system.

I came across this issue because I didn't realize my hostname suddently changed. Perhaps a friendly error message could be inserted that a config for the hostname currently set wasn't found and it should be set to one of the following (list config names)

I was just bit by this one this morning as my ISP delivered a new router which, when my devices connected to it, renamed all hostname.local to hostname.lan.


Feature request: Response should support multiValueHeaders

Use case
I have a lambda function with an ALB event source, I was attempting to use Response (from aws_lambda_powertools.event_handler import content_types, Response) instead of constructing the response by hand
return Response(
    status_code=200,
    body=data,
    content_type=content_types.APPLICATION_JSON)

instead of
return {
   "statusCode": 200,
   "statusDescription": "200 OK",
   "multiValueHeaders": {
       "Content-Type":    ["application/json"]
        },
    "body": data
}

the ALB responds with a 502 when using Response I suspect it is because multiValueHeaders is not included in the response.
To get around this, I am doing the following but it is not elegant
response = Response(
  status_code=status_code,
  body=data,
  content_type=content_types.APPLICATION_JSON
        ).__dict__

response["multiValueHeaders"] = {
        "Content-Type": ["application/json"]
}

return response

Solution/User Experience
I would like for the Response object to be able to detect multiValueHeaders in the request and use that to determine if the response should do the same
Alternative solutions
An alternative could be to have MultiValueResponse object that works the same as Response but sends `multiValueHeaders`

Acknowledgment

[X] This feature request meets Lambda Powertools Tenets
[X] Should this be considered in other Lambda Powertools languages? i.e. Java, TypeScript

@rubenfonseca when you can, could you share the update here as this was implemented for v2?

re-assigning @rubenfonseca for visibility as this is already done in V2 and ready to go by Friday or next week (in case we spot anything wrong in V2 final tests)

Closing as we're wrap to launch V2


Elasticsearch-1 configuration doesn't work - invalid combination error

When testing the config worked as expected when using graphite as output, however it fails for write_gcm plugin:
 "message": "Unsupported collectd plugin/type combination: plugin: \"curl_json\" type: \"gauge\""#012

Should it use custom metric types like Statsd config? (which works great btw)

Glad to hear that statsd works for you. This one should have worked too, however.
Looks like one of the values didn't get rewritten properly. All of the values sent to Stackdriver with this config should have the plugin set to "elasticsearch".
Are you using the unmodified version of the config? Are there any other error/warning messages in the log?

Yeah, I tried the unmodified version + set syslog plugin to debug. Here's the log message:
Mar 24 10:29:15 test-es-proxy collectd[6403]: write_gcm: Server response (CollectdTimeseriesRequest) contains errors:#012{#012  "payloadErrors": [#012    {#012      "index": 65,#012      "error": {#012        "code": 3,#012        "message": "Unsupported collectd plugin/type combination: plugin: \"curl_json\" type: \"gauge\""#012      }#012    },#012    {#012      "index": 66,#012      "error": {#012        "code": 3,#012        "message": "Unsupported collectd plugin/type combination: plugin: \"curl_json\" type: \"gauge\""#012      }#012    },#012    {#012      "index": 67,#012      "error": {#012        "code": 3,#012        "message": "Unsupported collectd plugin/type combination: plugin: \"curl_json\" type: \"gauge\""#012      }#012    },#012    {#012      "index": 68,#012      "error": {#012        "code": 3,#012        "message": "Unsupported collectd plugin/type combination: plugin: \"curl_json\" type: \"gauge\""#012      }#012    },#012    {#012      "index": 69,#012      "error": {#012        "code": 3,#012        "message": "Unsupported collectd plugin/type combination: plugin: \"curl_json\" type: \"gauge\""#012      }#012    },#012    {#012      "index": 70

Needless to say other metrics (df, cpu etc) work as expected.

We hope this has been solved. In the meantime, the ElasticSearch plugin is no longer supported. Please read https://cloud.google.com/monitoring/agent/plugins/elasticsearch for options

@jkohen No problem, we've ended up writing a small monitoring daemon in Clojure to send ES stats to Collectd 👍

Thanks for the update. Sorry for the delay.


Simplify iterators

Codecov Report
Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.10%. Comparing base (3a3f654) to head (63da16f).

Files with missing lines
Patch %
Lines

wirebson/array.go
76.47%
2 Missing and 2 partials :warning:

wirebson/document.go
60.00%
1 Missing and 1 partial :warning:

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   65.10%   65.10%
=======================================
  Files          43       41    -2
  Lines        1748     1748
=======================================
  Hits         1138     1138
  Misses        441      441
  Partials      169      169

Files with missing lines
Coverage Δ

wirebson/logging.go
92.30% <100.00%> (ø)

wirebson/raw_array.go
25.00% <100.00%> (ø)

wirebson/size.go
96.00% <100.00%> (ø)

wirebson/document.go
45.26% <60.00%> (+0.81%)
:arrow_up:

wirebson/array.go
62.68% <76.47%> (-0.48%)
:arrow_down:

Flag
Coverage Δ

test
65.10% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


How to improve the displayed precision for loss in the progress bar.

During the training, I'm using the custom loss function to train my model. However my losses are displayed as 0.000, but when I display the same value to display as different variable it gives 4.73e-5 (some value with much better precision).
for example
Epoch 80: 10%|██▌ | 100/1013 [01:33<14:11, 1.07it/s, loss=0.000, v_num=None, train_loss=4.73e-5]
both loss and train_loss display the same value. why one displays in exponential format and other doesn't.
Is it possible to improve the displayed precision for the loss in the progress bar.

you can override get_progress_bar_dict
https://pytorch-lightning.readthedocs.io/en/latest/lightning_module.html#get-progress-bar-dict
https://github.com/PyTorchLightning/pytorch-lightning/blob/7abd8224d62c8bd3a0bb5b58c7d95488303daa98/pytorch_lightning/core/lightning.py#L1385

you can override get_progress_bar_dict
https://pytorch-lightning.readthedocs.io/en/latest/lightning_module.html#get-progress-bar-dict
https://github.com/PyTorchLightning/pytorch-lightning/blob/7abd8224d62c8bd3a0bb5b58c7d95488303daa98/pytorch_lightning/core/lightning.py#L1385

Thanks .... did override the function...It is working..

Thanks .... did override the function...It is working..


mitmproxy: 0.17.1 -> 1.0.2

Motivation for this change
mitmproxy was marked as broken and needed fixing and a version bump.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Added comments with explanations for disabling the tests. I don't have time to fix the tests and packaging new and bumping existing python packages was tedious enough for me.
As indicated above, I have not run nox-review, so no idea yet if the bumps break other packages. I want to wait for travis to maybe finish successfully.

Okay, so all reverse dependencies build for me with nox-review pr that were not broken before, so we're ready to merge. Also rebased against current master.


User needs to click on inspect inside the wallet to keep it persistent

The wallet doesn't open as a popup, and the user needs to manually click on inspect inside it to keep it persistent. A fix would involve adding a popup and background script.

Resolved with the latest version that utilizes service workers.


tmux on Cygwin displays broken separators

Windows Terminal version
1.15.2875.0
Windows build number
10.0.22621.675
Other Software
Cygwin 3.3.6-1
tmux 3.2a
Steps to reproduce

Open a new tab with a Cygwin profile.
ssh into an Ubuntu virtual machine
Run tmux new -s mysession

Expected Behavior
Separator bars are displayed correctly
Actual Behavior

I am using CodeNewRoman NF from NERDFonts.:
https://www.nerdfonts.com/font-downloads

That font isn't monospace:

You have to use CodeNewRoman NFM instead - the M stands for Mono(space).

That font isn't monospace:
You have to use CodeNewRoman NFM instead. The .zip contains files that include "Mono" in the name, which can then be used with the NFM suffix.

Although you are theoretically correct, in practice CodeNewRoman NF is monospace indeed, just tested this:

Anyway I switched to NFM and changed nothing, the separator is still broken. Let me know if you'd like me to try another font.

Actually, scratch that. You are right, my mistake. I got confused by the way mintty handles this, which I was using as a reference.

From what I can tell, mintty places glyphs in a monospace grid no matter what font is used. Basically, it discards the font's "glyph advance" (the "width" of a glyph) to make them fit into the grid. Windows Terminal's renderer on the other hand uses the font information wherever possible. This is the code in mintty that's responsible for the behavior: https://github.com/mintty/mintty/blob/cbaa7665c82accc91a395414be121f2a435a6e03/src/wintext.c#L3108-L3118
I have a branch where I'm doing the exact same thing, but I haven't completed that work yet. Once we merge that, Windows Terminal will work with any arbitrary font (include script fonts, like Segoe Script).

@lhecker thanks very much for the insight. I just checked and Terminal.app and it seems to behave just like mintty.

I have a branch where I'm doing the exact same thing as mintty

So this behavior is the future of Windows Terminal?

Yeah I'd say so. However I don't intend to do it to make proportional/non-monospace fonts like CodeNewRoman NF work and I don't think that's why mintty/Terminal.app/... do it either.
I believe this is more like a result of trying to make complex Unicode work better in terminals, because fallback fonts that contain such Unicode are usually never monospace. For instance a single emoji can mess up your layout:

While this can be tolerated in a text editor, a terminal needs to be stricter in my opinion. And that's why I'm sure that this is the future of Windows Terminal as well. The strict monospace layout already works in the new "AtlasEngine" text renderer that you can try out in Windows Terminal Preview. But I'm now working on combining the benefits of the old and new text renderers to allow arbitrary overlapping fonts (like cursive script fonts) with strict monospace. I'm hoping to finish this new text renderer within this year.

@lhecker thank you again for the lengthy explanation.


Tray borked on ubuntu 16.10 after week of operation

Version: 5.0.1

Can't even naturally quit without kill due to lack of quit menu item.

After a few hours on 1704:

@crioto this just happened to me again today before your most recent update. I will test this with your updates to see if it is continuing. Just wanted to point this out and get it on your radar.


PAM authentication implemented

Hi there,
we added the option to use the Linux Pluggable Authentication Modules (PAM) for MFA.
The PAM file to use can be picked with the PAM.ServiceName configuration and as PAM backend github.com/msteinert/pam is used, this is the same package used by github.com/go-gitea/gitea for example.
Hope you like and merge it. Let me know if you need something changed.

Hi there and thanks so much for  implementing this!
I must admit I hadn't even remotely considered implementing pam integration for wag, so I find this patch super fun.
Currently the closest thing wag has to this is the oidc provider which can dynamically configure the groups a user is part of.
For pam it might be worth doing something similar and getting the users linux groups and using them to determine which wag ACLs apply.
I.e if user John is in the linux group bonk, then the rules for group bonk in the wag config file are applied.
At minimum, I think users should have to be part of a system group in order to have wag be enabled for them. Just so we don't end up in a situation where someone accidentally enables a user to access wag when it was unintended.
(super unlikely in the current implementation as you'd have to both make a user on the system then also a registration token to match, but still worth thinking about)
Keen to hear your ideas on this.
On a side note this could also be used to display users in the Web ui to associate their groups.

Sweet! So I've done a few changes and have merged them in to the unstable branch.
Just a bunch of reorganising the lookg and feeling of the .html files just to better fit the existing UI.
I've made not supplying the pam servicename not a validation file but it falls back to using /etc/pam.d/login which I think is reasonable.
I've also improved logging a bit so its clearer what pam config file wag is using and to log errors a bit better.
Otherwise looks awesome! Please check my work on the unstable branch and I'll give that a merge after you're happy with what I've done.

Yep that was when I was testing out just using the service name wagvpn statically set, rather than letting the user set it. Which isnt a great idea and I got rid of it, so I'll just update those little hangovers.

nice :+1:  but in the init function you set t.serviceName = settings["ServiceName"] and in the AuthorizeFunc you use a new local variable serviceName := config.Values().Authenticators.PAM.ServiceName. And if you use settings["ServiceName" don't you have to set that variable in config.go first?

Yes, one of those moments  where I'd made a change but not saved it in my IDE unfortunately.
The most recent work is up there now

Looks good and worked for me :)

Sweet! I'll do a release then.
As I've already pulled this code in to the unstable branch to test it I'll be closing this pull request but it is counted as merged.
And as a final note, if you or your organization are using wag to support your day to day operations please considering supporting the project!
Thanks again for the feature :)


Jesse: Blacklist +4(412) -3380 -0794

Jesse requests the blacklist of the number +4(412) -3380 -0794. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Jeff Schaller in Charcoal HQ


Move packages to Github from Dropbox

It'd be better to have it here on Github as releases so that users don't really have to click on external links to download the binary files.

Also...

Ill get right on that... I had no idea i was generating to much traffic

When I tried to add the binaries to the my github release for version 1.2.0 github seems to not even try to upload it would it be easier if created a branch containing the builds and the links will download the file from there?

@alexanderepstein do you have any adblockers enabled? That's has disrupted the uploader for me in the past.

Got it sorted out, all future downloads can now be found under their respective release
https://github.com/alexanderepstein/Insomnia/releases/tag/v1.2.0


Praf

whatever you do doesn't help, it's all upside down, I don't call for rewards anymore, 0, I see that those who do something vlogging and who post good or bad about hilium or there are still those who see heaven pant everything upgrade hilium iei receive riorduri are ok, for the rest<PHONE_NUMBER>000001 hntper month.
we really burn everyone to get all the hotspots out of the socket, it's not worth consuming those 5 v per day, too high costs per month, for us poor people.

I'm sorry you are having concerns or issues with your hotspots. This is not the place to look for help or share your opinion. Please share them in discord where community members can help


Make TLS settings updated with Server.reconfigure()

Motivation:
Currently, a TLS configuration is not updated with Server.reconfigure() because HttpServerPipelineConfigurator refers to the sslContexts made when a server is built initially and the reference won't change.
Modifications:

Make HttpServerPipelineConfigurator read sslContexts from UpdatableServerConfig whenever a new HTTPS connection starts.

Result:
You can now dynamically update TLS configurations with Server.reconfigure().

Hi @ikhoon , @minwoox thanks for the response, when can I expect a release to include this feature? 🙇 no urgent but just want to keep updated about the new release

We are planning to release a new version in the next week. 😀

We are planning to release a new version in the next week. 😀

Thanks for the heads up


[Linux <IP_ADDRESS>] Schematics Won't Export

When I select an area of the level and export it to a *.schematic file, the program acts like it went fine, but there is no schematic file where I set it to save. I checked the default ~/.mcedit/MCEdit/Schematics folder, and nothing is there either.

Do you have errors in the console, or the log file?

Where do I find the log file?

In the folder you installed MCEdit on Windows and Linux.
On OSX, it is stored in the application and system logs.

It does have this:
[   ERROR][pymclevel.infiniteworld.py:1450]:Error loading dimension DIM_MYST-2147483648: invalid literal for int() with base 10: '_MYST-2147483648'
[    INFO][pymclevel.infiniteworld.py:1446]:Found dimension DIM-17
[   ERROR][pymclevel.infiniteworld.py:1450]:Error loading dimension DIM_MYST-2147483647: invalid literal for int() with base 10: '_MYST-2147483647'
But I'm pretty sure that has something to do with Mystcraft, which has not been installed in a while. The area I'm exporting is in the overworld.

Hmmm...
Looks like a mod created more dimension than exists in the vanilla game :wink:
You can (and I recommend to do so) load the world in vanilla game. It will remove the mod specific stuff. It may also create holes where modded stuff is...
If the mod dimension files and folder are still present after opening the world in vanilla game, remove them.
Make a backup before doing this, of course!

I deleted everything from my world folder except level.dat, playerdata, and region. Loaded up just fine in Vanilla. Tried to export the house again with MCEdit, got no errors, but still no file showed up.

I should also mention I tried it on my desktop computer (Windows 7) and it worked fine, even without clearing out the Mystcraft dimensions. It seems to be Linux-specific. :\


Add IT for dolphinscheduler upgrade

Purpose of the pull request
Make sure the upgrade tools can execute successfully, after this PR merged we can add more assert case.
Brief change log
Add two test case to execute the upgrade tools and initialize tools.
Verify this pull request
Add IT case.

Codecov Report

Merging #15043 (50c7455) into dev (8f16fd7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head 50c7455 differs from pull request most recent head 182e282. Consider uploading reports for the commit 182e282 to get more accurate results

@@            Coverage Diff            @@
##                dev   #15043   +/-   ##
=========================================
  Coverage     38.95%   38.95%
  Complexity     4599     4599
=========================================
  Files          1231     1231
  Lines         43354    43322   -32
  Branches       4795     4780   -15
=========================================
- Hits          16887    16877   -10
+ Misses        24594    24569   -25
- Partials       1873     1876    +3

Files
Coverage Δ

...scheduler/common/sql/ClasspathSqlScriptParser.java
75.40% <100.00%> (-0.87%)
:arrow_down:

... and 24 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Some UT still failed

Some UT still failed

It seems caused by current byte-buddy doesn't support jdk17, I upgrade the byte-buddy version to fix this.

FYI, CI failed due to schema DDL not sync when we try to upgrade from 3.1.8
ALTER TABLE `t_ds_fav_task` ADD COLUMN `task_type` varchar(64) NOT NULL COMMENT "favorite task type name";

and I am not sure why K8S test failed. Others looking good 👍

and I am not sure why K8S test failed. Others looking good 👍

K8S test has be fixed at #15053


Display columns in MkDocs pages of checklists and packages

User story

As a website user
I would like to see all the relevant details about the terms in a given package/checklist
So that I can easily determine which terms are required vs recommended

Acceptance criteria

Given I have navigated to any Checklist-Package combination documentation page e.g. https://genomicsstandardsconsortium.github.io/mixs/BuiltEnvironmentMIGSEukaryote/
When I look at the "Slots" table
Then I can see columns for the following:
MIxS ID
Full Name
Requirement
Short Name
Definition
Value syntax
Expected value
Example
Preferred unit
Occurrence

Additional information
NB the above wording is how these are shown in the old excel formatted versions of the tables, below I try to map those to the names used in the LinkML version:
Short Name = slot name
MIxS ID = slot_uri
Full Name = title
definition = description
Value Syntax = range
Occurence = multivalued
Example = examples
Expected value =  annotations:      expected_value: text
Requirement = ? I cant see this information stored in the terms.yaml file ?
Preferred unit = I'm not sure, but I think this is stored in the packages yamls somewhere under slot_usage maybe?

When I look at the "Slots" table
Then I can see columns for the following:

MIxS ID ✅

Full Name

Why do you want to see the full name when the short name is linked out? you can simply click on the page for the slot (with short name) and read what the full name is

Requirement

The cardinality captures the requiredness. See https://linkml.io/linkml/schemas/slots.html#cardinality page to learn how the cardinality syntax on the web documentation pages can be read/interpreted

Short Name ✅

Definition

Similar to full name, why would you want to see this when you can simply click on the documentation page for the slot and view the description. We should try to avoid cramming in information in tables because it has limited space on a web page and cramming in a lot of columns introduces horizontal scroll and that it is ideally undesired behavior

Value syntax

I'm forgetting what this means?

Expected value

I'm forgetting what this means?

Example ✅ -- "Examples" section

Preferred unit ✅ -- shown in "Range"

Occurrence ✅ -- shown in "Applicable checklists and extensions" section

I think this issue can be closed @only1chunts?


[HOLD for payment 2023-09-20] Pay button doesn't match system message

When paying reports, we have a button that looks like this.

However, when you actually pay the report the system message is different.

Accordingly, let's fix this inconsistency and ensure that the system message matches the button. Given that we are deprecating Paypal.me, and related, with Paid %amount% elsewhere not having this problem, I think this system message for in-product payments is all we need to fix.
-Paid %amount% with Expensify
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010cef4a98f0f3cb6d
Upwork Job ID:<PHONE_NUMBER>323570176
Last Price Increase: 2023-09-08

Proposal
Please re-state the problem that we are trying to solve in this issue.
Pay button doesn't match system message
What is the root cause of that problem?
https://github.com/Expensify/App/blob/b119f9ab54e7cc7272702e270693896b352b61e0/src/languages/en.ts#L523
https://github.com/Expensify/App/blob/b119f9ab54e7cc7272702e270693896b352b61e0/src/libs/ReportUtils.js#L1454
https://github.com/Expensify/App/blob/b119f9ab54e7cc7272702e270693896b352b61e0/src/libs/ReportUtils.js#L2015
We are using "using Expensify" instead of "with Expensify"
What changes do you think we should make in order to solve the problem?
Update all above places to "with Expensify"
What alternative solutions did you explore? (Optional)

This also needs to be fixed in the backend I believe

Working on this one

PR in review

$500 to @allroundexperts for internal review.

$500 payment approved for @allroundexperts based on BZ summary.

@allroundexperts can you also make sure to comment as to whether a regression test is required?

@allroundexperts I think it would be good to add a regression test for this, would you be able to write it down based on the PR QA steps? Thank you!

Agree that we should add a regression test for this. @allroundexperts can you suggest one?

That looks good to me. Thank you! Just added a regression test.

Payment summary: $500 to @allroundexperts for PR review.

Closing this out, as it's paid via NewDot. Please don't forget to add a request!

$500 payment approved for @allroundexperts based on summary above.


Discuss removing serve command

Given that serverless-offline and serverless-simulate both exist, are there many users of this plugin that use the included serve functionality?
Removing it would help a lot with code bloat, allowing the plugin to focus solely on building bundles via Webpack.
Any feedback from users would highly be appreciated, would be great to know what plugin/combinations of plugins you use for development.

Thanks @hassankhan for bringing this up 👍 . Maintaining code and functionality that is probably not used or completely replaced by other plugins is wasted effort.
Regarding the versioning schematics, if decided to be removed, this must go into a 2.0.0 version.

I agree with @hassankhan. Another plugins are already focusing on simulate an API gateway and they integrate well with serverless-webpack.

Agreed @HyperBrain, if its removed it should definitely be a major version bump.

I linked all open PR's that are related to the serve functionality here. The PR authors might check back here and tell us the status of their serve usage then.

Ok so I do use the serve functionality but only b/c I can't get serverless-offline to actually use my webpack config.
If I can get that figured out I'm totally fine removing the serve functionality.

@Whoaa512
I'm using serverless-webpack with serverless-offline.
Which problems are you facing?

So I'm using<EMAIL_ADDRESS>and running sls --stage dev offline start
In my webpack.entry config I have
    entry: {
        './handlers/lambda': ['../baseConfig.js', './handlers/lambda.js'],
    },

But for some reason my baseConfig doesn't get included in the bundle when I run serverless-offline
Not sure if I'm missing something else.

Turns out I just needed to use sls --stage dev offline removing the start on makes it work as expected.

We're successfully using serverless-offline in combination with serverless-webpack since months. I tried theserve command once but it didn't really work well and didn't provide the full simulation as serverless-offline does. There are A LOT of things to consider when trying to simulate API Gateway correctly.
So I'm absolutely for removing the serve command from serverless-webpack and redirect users to serverless-offline instead. This will allow focusing on the core features which are packaging, not simulating IMO.

Did you follow this https://github.com/dherault/serverless-offline#usage-with-serverless-offline-and-serverless-webpack-plugin?
Take note that according to docs, serverless-offline must be the last item in the plugin configuration.

Ops I haven't read https://github.com/elastic-coders/serverless-webpack/issues/135#issuecomment-312325005

I'll tag all PRs relevant to the serve functionality with the pr/serve tag, so that they are visible. If we take the decision to remove serve we can close the tagged ones for the specific release.

According to all the feedback that we received either here or within the open PRs, it seems feasible that we remove the serve functionality. Serverless-offline can be used for anything that also could be done with serve.

Big +1, glad to hear that

I have been running into an issue when using lambda proxy.
Testing locally with sls webpack serve will return the expected outcome by directly access event.body inside my lambda function.
However when running the function on AWS I need to run JSON.parse(event.body) in order to access the variables passed to the function.
Would this be related to all of the chatter above of simulation errors?
Cheers!

@dillonbailey The event.body property of Lambda proxy integrations normally are received as string (i.e. you have to parse the body after checking the ContentType header).
If  serverless webpack serve gives you an object instead, this is wrong. As you see in this task, we're planning to remove the serve command.
Could you try to use the serverless-offline plugin instead to simulate a local API Gateway? It offers the same functionality and works together with the webpack plugin.

There's a difference between lambda and lambda-proxy integration in Serverless. I don't remember which one works which way, but over the last two years a pattern has emerged for us:
const body = _.isString(event.body) ? JSON.parse(event.body) : event.body;

This seems to be the most reliable and robust way around different behaviors of the simulation. 🤔

@HyperBrain thank heaps!  I think there is also a difference with lambda vs. lambda-proxy where one passes the events directly to the function e.g. event.variable_name and the other provides them via event.body

Should we open a new issue for discussing what to do about the existing PRs for the serve functionality? The purpose of this issue was to decide whether or not to remove it, now that we've decided we should probably close this 😄

I'm just about to create an issue to actually remove the serve functionality ;-)
Regarding the PRs and issues related to server, my opinion is to close all of them with a comment that references the task. Spending efforts ina feature that is about to be dropped doesn't make much sense.

Closing this now - the removal of serve and the technical discussion is done in #152

Per @HyperBrain request, reposting question here:
I've tried to run
serverless offline start
instead of
serverless webpack serve
In the offline way, the lambdas get called, execute correctly - but they don't return a json body as they do with the serve way. I don't see any related issue in serverless-offline, maybe something related to serverless-webpack?
I'm happy to troubleshoot but don't know where to start.
@franciscocpg To answer your question, no it's in the format
callback(null, { status: 'success', data: 'whatever' }

because I'm using the Lambda integration, not the Lambda Proxy Integration.
The relevant pieces of my serverless.yml looks like this:
integration: lambda
request:
  passThrough: NEVER
response:
  headers:
    Content-Type: "'application/json'"

I wonder if the response fails as I'm not defining a body mapping template. A template is not required though (I'm currently searching for the AWS spec I found that in a long time ago) and in the real AWS integration, a default template is used if missing.
Some logs from my offline run that are perhaps of interest
[offline] Using response 'default'
[offline] _____ RESPONSE PARAMETERS PROCCESSING _____
[offline] Found 0 responseParameters for 'default' response
[offline] _____ RESPONSE TEMPLATE PROCCESSING _____
[offline] Using responseTemplate 'application/json'
[offline] Processing key: root - value:

[offline] Velocity rendered:

Serverless: [200] "\n"

for lack of finding docs, here's a screenshot of the "integration response" section in aws when uploading through lambda - note the "Default mapping" there.

@bebbi
I have no experience with Integration: Lambda but it's working fine from here.
Are you calling the callback this way?

@franciscocpg thanks good pointer, will check against there.
@HyperBrain Just as a heads up, there may be more blockers for me (others?) to switch from serve to serverless. I just submitted a fix for one in https://github.com/dherault/serverless-offline/issues/282
I'll try to figure out the above one.

@bebbi Yes, that's true. Nevertheless the plugin should concentrate on the packaging. If we encounter issues, we should try to push the changes/fixes into serverless-offline. I think @dherault would also agree that the combination of both plugins create a system that is superior to having similar functionality maintained in both plugins.
And thanks for your engagement 🙌

@bebbi Agree. I try to reach out to @dherault to get this in asap. In the meantime I'll release further v3 fixes as rcs but merge it to master (there will be no dev on v2 anymore).


UI tests should be able to test both dev and store-released builds

The official version of Calculator uses the appID "Microsoft.Calculator" while the one built in this repo and in our CI builds uses the appID "Microsoft.Calculator.Dev". We'll need to implement a way to pass the desired target application to the test harness at runtime, and then verify that it works in both our internal and external build pipelines.
Because testing in the internal release pipeline is required, I've self-assigned this.

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.


Gradient Starvation

$log$ => $\log$, and put Utility and other words in \text when in math mode

Looks promising. Make it easy for yourself and just copy a 2d example of a neural network/curve fitting and show learning progress using GD and with the spectral decoupling. With Flux it should be easy to more or less reproduce the example of the blog post.

Hey Peter, very nice and detailed project! 😄
The plots are a great asset in your notebook. They helped me understand some parts of the text better! Maybe it would be handy to mention which funtion from your src folder you used to generate the moon plots.
Another small remark, you wrote "refered" somewhere instead of "referred".

Hello Peter,
First of all, nice job with your project. While I was reading through it, I thougth that it was a research paper instead of a task a student made. The information was wel structured and detailed, which made the content undersatndable for someone whom is not familiar with the subject. The plots were very helpfull too.
I also took a look at your code, which is great. Only comment on this is that I would have liked to see it in the Pluto Notebook itself. So, I could see how you implemented what you wrote in your code. This was now difficult to find which part of the code belonged to which part of the notebook.

Thanks for all of your feedback, very much appreciate it and applied most of your suggestions!


[TACHYON-1355] Remove unnecessary parens in NetworkAddressUtils.isValidAddress

https://tachyon.atlassian.net/browse/TACHYON-1355
The outer parens in NetworkAddressUtils.isValidAddress were unnecessary and have been removed

Can one of the admins verify this patch?

ok to test

Hi, thanks for your PR! It seems like your commits are not linked to your github account. Here is information on how to fix that https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/
Thanks!

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7814/
Test PASSed.

Thanks! @gpang I forgot to change my local Git configuration settings.

Did you add an additional email address to your github account? The commit still does not link to your github account, but maybe that won't get updated.

LGTM

@gpang Sorry. I've fixed it now.

Thanks for fixing it!


Chrome Extension Manifest v3 Service Worker

I noticed there is a problem obfuscating the service worker of a manifestv3 chrome extension.
Now the function to run a script is:
    const example = "Hello World!"
    chrome.scripting.executeScript({
        func: (param) => {
            console.log(param) // Hello World!
        },
        args: [example],
        target: { tabId: tabId }
    })

But probably with the obfuscated code a problem arises because what is inside the func() loses meaning since the rest of the obfuscated code is in the service worker and not in the content of the page.
Does anyone know how to fix this problem?
Thanks in advance!

I have the same use case, I had to create a file 'functionX' , pass 'function1' to the 'func' attribute, make the obfuscator skip function1, obfuscate the file 'functionX', and insert a function with name 'function1' and the resulte of 'functionX' obfuscation as body to the obfuscated background.js

workaround:
// javascript-obfuscator:disable
function myfunc=(param) => {
    console.log(param) // Hello World!
}
// javascript-obfuscator:enable

   const example = "Hello World!"
    chrome.scripting.executeScript({
        func: myfunc,
        args: [example],
        target: { tabId: tabId }
    })


Implemented Authentication both on client and server using passwordless

Hey @JesseRWeigel ,
I finally managed to implement full authentication system both on the client and the server.
Instructions

Make sure you have mongodb installed. If dont I recommend you to create a sandbox free account in mlab.
Rename .env.sample to .env.
Fill it out correctly as it is done in the sample.

HOPE THIS HELPS YOU
        HARSHIT

Might try using sendgrid and its port 587 which should not be blocked.


Creation of Add Book form

The post route for the addition of a category is /category/add
The form should have the following fields.

name (Name of the category/genre)
desc (Small description of the category)

This is a duplicate issue.
Checkout #26

Once the form component is created by Amit, who is assigned issue 26, we will be using the same code as snippet and create other forms that are needed. So, separate issues isn't needed for each of the form page as we do not want to have multiple form templates with different code and styling.


New Contact us section glitches (Open to all)

1) While opening oscode.co.in it redirects to the contact us section.

2) The map is showing world map not the oscode office.
3) The contact form is not getting submitted.
@Divesh2003 kindly look into the matter

Yes @Git21221 , please resolve this.
-- And also instead of 'Last name" option ,change that "College "
-- also try to shorten the length of that section a bit!, even in width, it is stretched too much
-- The backgronud color blue and purple is not matching, try to enhance that in a way matching to the existing theme

I have my exam from 1st june so Now I can't contribute :(.

I have my exam from 1st june so Now I can't contribute :(. @akshathar-navada Make it open for all. anyone can fix this.

Oh ok ok

Can I take up any of these issues?

Sure you can. Try to remember all points that akshatha said.

Can I take up any of these issues?

Yes sure, go ahead @shruuti321

can i take this issue as i have raised an issue regarding this that it takes only 1 number in mobile number that should be 10

Will be closing this issue, as there were many conflicts. Will soon open a new issue regarding enhancement of contact section.
Thank you!


Configuration Chosen

I have chosen configuration of -6.8696 and -6.7607.

Have you made sure that these do not collide with your group members' choice? Because we have to choose different.

Yup! they chose different combinations. Thanks for reminding?

No problem


Merge kubo-release-windows back into this repo

What this PR does / why we need it:
This PR recombines the kubo for Windows jobs back into this release. We can now compile these jobs specifically against a Windows stemcell and release separate precompiled releases for Windows and Linux
How can this PR be verified?
Run the pipelines
Is there any change in kubo-deployment?
Yes, this change https://github.com/cloudfoundry-incubator/kubo-deployment/pull/410
Is there any change in kubo-ci?
Yes, those are being applied as well.
Does this affect upgrade, or is there any migration required?
No
Which issue(s) this PR fixes:
Release note:

This release recombines the kubo-release and kubo-release-windows. It no longer depends on kubo-release-windows. When using Windows workers the precompiled releases for docker-boshrelease and kubo-release will be replaced with the uncompiled releases.

Here is a precompile with the exiter removed. It passed, so this should work fine https://ci.kubo.sh/teams/main/pipelines/next_combined_windows_test/jobs/build-kubo-release/builds/7


[BUG] Can't get Lombok working in eclipse (anymore)

I have the most annoying situation that Lombok all of a sudden seized working in Eclipse 2020-09! And I have no clue as to why. :-(
About 2 weeks ago (when I installed Lombok for a new project into my Eclipse setup) I first faced the issue that v1.18.4 was not working and stalled Eclipse's startup. I then googled and found out that this was a known issue and I then first reverted to v1.18.12 (which worked) and a few days later - once it had become available - I upgraded to v1.18.6 which also worked fine!
About a week later I suddenly get compile errors re. all log(), toString() and misc. setters and getters that Lombok is supposed to create. It is as if Lombok suddenly got de-installed or deactivated. But of course its .jar is still sitting next to the eclipse.exe and the -javaagent entry in eclipse.ini is also still present and correctly points to the .jar.
I then tried reinstalling it (using the meanwhile available v1.18.8, then 1.18.6 again and finally reverting to v1.18.2, but with NONE of these versions Lombok "returned" to action inside eclipse. Building with Maven on the command line always worked fine.
It is only inside Eclipse that all the Lombok-generated methods are flagged as missing.
Any idea anyone what could cause this and how to fix?

I finally found out what's going wrong here:
I had also enabled the AspectJ "nature" for that project in Eclipse (as I had intended to write a few aspects).
And that - as I had to find out - doesn't go together well with Lombok. Obviously the AspectJ builder overwrote the results of the Lombok compiler and hence all the Lombok-generated stuff was missing.
Disabling/removing the AspectJ nature from the project brought things back to normal.


Add more unit test to increase the test coverage

Add more unit test to increase the test coverage

Can we set a specific target for this issue?  Like 65% or 70%?  We should aim to make incremental improvements.

Yes, we have some todos in the code, for example this one https://github.com/opensearch-project/ml-commons/blob/main/common/build.gradle#L43


Can't upgrade static web apps  github setting

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Related command

az staticwebapp update --name static-webapps  --source https://github.com/xxx --branch main  --token {{PAT}}
Describe the bug

When trying to update existing static web app with new private github repo setttings there is an error
Error code
BadRequest
Message
RepositoryToken is invalid. Please ensure the Github repository exists and the RepositoryToken is for an admin of the repository.
But when you create new one with the same token - everything ok.
When you trying to update existing static webapp  with public github settings - everything ok
Problem related only updating private github repo settings.
Is there any chance to create new static web app without github part and then update to use with private github repo?
To Reproduce

az staticwebapp create -n {{MyStaticAppName}}  -g {{someresourcegroup}} -l eastus2
az staticwebapp update -n {{MyStaticAppName}}  -g  {{someresourcegroup}} --source {{https://github.com/private_repo}} --branch {{master}}  --token {{PAT}}
Expected behavior

Environment summary

azure-cli                         2.36.0 *
core                              2.36.0 *
telemetry                          1.0.6
Extensions:
aks-preview                       0.5.42
Dependencies:
msal                              1.17.0
azure-mgmt-resource               20.0.0
Python (Linux) 3.8.13
[GCC 9.4.0]
Additional context

@onlyillusion Apologies for the late reply. Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

@onlyillusion I am yet to do a repro at my end and check the failure. But before that I wanted to confirm if you have tested with the below commands and check if that worked ? I am just trying to avoid the duplicate efforts.

az resource update --ids /subscriptions/XXXXXXX/resourceGroups/XXXX/providers/Microsoft.Web/staticSites/MyStaticApp --set properties.repositoryToken=XXXXXXXXXX properties.repositoryUrl="https://github.com/XXXXX/XXXXX" --api-version 2021-03-01

Awaiting your reply.

I am yet to do a repro at my end and check the failure. But before that I wanted to confirm if you have tested with the below commands and check if that worked ? I am just trying to avoid the duplicate efforts.

@navba-MSFT Hi
No,didnt checked using your command.
I used only "az staticwebapp update" command for updating.

@onlyillusion Thanks for getting back. I have tried the above command and confirmed that it also failed with Bad Request ( 400 ) error. Based on the debug log, this doesn’t seem caused by the CLI. The CLI command is failing because the PATCH API is returning a 400 status in this case. I am discussing this with the Product Owners further and update this GitHub thread once I hear from them.

@onlyillusion Apologies for the delay. I am still waiting for the reply from the Product Owners. I will keep you posted.

Adding Service team to look into this.


change the for loop to a new for range - part 1

I suggest replacing the construction:
for i:= ...; i < ...; i++
by the new construction:
for range ...
or
for i := range ...
there are a lot of changes, but I'll break them down into a few pr

Although Go 1.23 expanded where you can use range, that doesn't necessarily mean we should change every for loop throughout the existing code.
For simple counters I think the for loop is fine and maybe even more readable by most developers. Plus, changing code unnecessarily in the main branch will make backports more difficult. And then there is also risk of an "off by 1" mistake when making bulk changes in the code.
Is there a compelling reason to make the change? Maybe we should only update occurrences where there is a compelling need, or if we are updating a section of code regardless.

Although Go 1.23 expanded where you can use range, that doesn't necessarily mean we should change every for loop throughout the existing code.
For simple counters I think the for loop is fine and maybe even more readable by most developers. Plus, changing code unnecessarily in the main branch will make backports more difficult. And then there is also risk of an "off by 1" mistake when making bulk changes in the code.
Is there a compelling reason to make the change? Maybe we should only update occurrences where there is a compelling need, or if we are updating a section of code regardless.

There's no good reason.
There is simply no uniformity in the for ; ;i++ construction.
That's why they invented a substitute for it, in which it is harder to make a mistake. So I decided to make it monotonous.
You may not accept my suggestion and just close it.
But if you decide to move in this direction, I can close this pr and create smaller ones to make it easier for the checkers to track down the “off by 1” error.

Although Go 1.23 expanded where you can use range, that doesn't necessarily mean we should change every for loop throughout the existing code.
For simple counters I think the for loop is fine and maybe even more readable by most developers. Plus, changing code unnecessarily in the main branch will make backports more difficult. And then there is also risk of an "off by 1" mistake when making bulk changes in the code.
Is there a compelling reason to make the change? Maybe we should only update occurrences where there is a compelling need, or if we are updating a section of code regardless.

There's no good reason.
There is no uniformity in the for ; ;i++ construct. That's why they invented a substitute for it, in which it is harder to make a mistake. So I decided to make it monotonous.
You may not accept my suggestion and just close it.
But if you decide to move in this direction, I can close this pr and create smaller ones to make it easier for the checkers to track down the “off by 1” error.

My opinion is to not make blanket changes in the code base for the purpose of syntax preferences. Different developers may have different preferences. If there are generally accepted bad Go practices in the code base then I agree those should be changed, but I don't think this one meets that criteria.
Let's keep it open for another day to see if there are any other thoughts from other maintainers.

Let's keep it open for another day to see if there are any other thoughts from other maintainers.

Yeah I second @denyeart .
If it ain't broke, don't fix it :-)