Pass passwords to alertmanager when using kube-prometheus

Hi I wonder how I can pass the smtp_auth_password into the alertmanager.yaml config file when using kube-prometheus. I came to the conclusion that it is only possible to store the password in clear text. That is a problem for me as I am committing the repo to version control.
Any solution, any idea to circumvent this shortcoming?

There are two things you would want to keep in mind when doing this:

you should not check in the generated manifests with jsonnet, as that would mean that you are checking in the same password, just base64 encoded.
assuming you have some way to access secrets somehow via the command line, then you can use jsonnet's external variables (aka extVar), to pass the secret to the jsonnet code: https://jsonnet.org/learning/tutorial.html#Parameterize-Entire-Config

That way you will never have to check in secret material.

Hi @brancz, I had a look at this and it seems like a interesting solution. Unfortunately, it does not fit well into the helm ecosystem that we use to deploy kubernetes workloads. Your suggestion is to store .jsonnet files the source code and have your configuration management tool pull the secrets and render the .jsonnet templates in an adhoc style.
Then what do I do with the rendered config file (which includes secrets and cannot be checked into version control). Not sure what to do FROM the point where I have the rendered config TO the point of deploying the workloads in Kubernetes w/ helm. Maybe you can clarify whether it is even possible to use jsonnet along w/ helm.
I have deployed many such tools like Grafana or Portus and they allow setting configuration through environment variables. i.e. in grafana the environment variable GF_SECURITY_ADMIN_PASSWORD overwrites the corresponding piece of config in the config file (support was added just recently). The same methodology is used by Portus to provide secret information. Trying to understand why alertmanager forces me to adapt a entirely new system to provide secrets into configuration. While I understand the benefits and the power of jsonnet, I am concerned about the lack of integration w/ other long established tools such as helm.

While it's possible to integrate with helm, it's unnecessary to do so. What is generated via jsonnet can be applied against a cluster with a simple kubectl apply -f. No helm needed, but you can also use the result and package it up with helm, if that's what you want to do.
May I ask how you handle secrets with helm today?
The discussion of using environment variables for configuration is not really one to have in the Prometheus Operator, but rather in the Alertmanager itself, and aside from that using environment variables for secrets can be harmful (see here and here).

Ok I was able to give this some thought. I could deploy workloads in helm using:
$ jsonnet values.jsonnet > /tmp/values.json
$ helm install --name=prometheus --namespace=default --values=/tmp/values.json ./prometheus
$ rm /tmp/values.json

Have not quite understood how to use jsonnet extVar, but will explore this to decide whether it could work with the existing infrastructure that we have.
Ahh ja good question, I use Vault together w/ policies that are assigned to the default service account in a namespace. That means containers have access to a subset of vault that they are allowed to see. In my setup I do not pass the actual password as environment variable. I pass the vault path as the environment variable. Inside the container's entrypoint script these paths are replaced by the actual secrets prior starting pid1. The script makes requests against the vault server for the paths it has received through environment variables.
example:
ENV GF_SECURITY_ADMIN_PASSWORD secret/default/prometheus/GF_SECURITY_ADMIN_PASSWORD

Not a security expert really to understand if this approach is also harmful. But many of the arguments in the article you posted do not apply in the approach we took. However, it comes at the cost that I need to tweak the base images that I use by adding a vault entrypoint script to the images. That's a couple of mins of work since I know exactly how to tweak the images. Unfortunately, alertmanager being so opinionated forces me to explore a different solution although the setup that we have worked quite well for us thus far.


PowerBI authorization for service principals

I have a PowerBI application where users can authorize the application to read their PowerBI contents. I am using the OAuth2 code flow to get proper authorization and access tokens. Is it possible to get authorization using service principal rather than the users having to use their PowerBI account. Or is the Service Principal meant for something else entirely?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c135bb4c-618b-478d-bce7-ac8608e3caac
Version Independent ID: a297498b-afa2-575d-417c-0cb4696a90af
Content: Service principal with Power BI - Power BI
Content Source: powerbi-docs/developer/embed-service-principal.md
Service: powerbi
Sub-service: powerbi-developer
GitHub Login: @rkarlin
Microsoft Alias: rkarlin

Yes, that is essentially the intent

@adamvan101 Thank you for the response. The reason I thought it could be for something else is because I could not find any documentation on how I can use service principal to generate access token for PowerBI. The only example I found was a C# code snippet which is not very helpful if I'm not using C#.
Do you know if there's any documentation that I can follow on this topic?

@sshresthareach the docs here are fairly low-level and should, therefore, be easily translatable to any language: https://docs.microsoft.com/en-us/power-bi/developer/get-azuread-access-token

@adamvan101 This is the page that I was referring to earlier. It has a C# code snippet to authenticate as shown below. The code below seems to be the only relevant code to generate access token using service principals. But the code makes use of C# classes like ClientCrendential and AuthenticationContext which abstracts away a lot of things. As per this example, am I supposed to use OAuth2 Client Crendential flow?
var authenticationContext = new AuthenticationContext(AuthorityUrl);
       AuthenticationResult authenticationResult = null;
       if (AuthenticationType.Equals("MasterUser"))
       {
              // Authentication using master user credentials
              var credential = new UserPasswordCredential(Username, Password);
              authenticationResult = authenticationContext.AcquireTokenAsync(ResourceUrl, ApplicationId, credential).Result;
       }
       else
       {
             // Authentication using app credentials
             var credential = new ClientCredential(ApplicationId, ApplicationSecret);
             authenticationResult = await authenticationContext.AcquireTokenAsync(ResourceUrl, credential);
       }

m_tokenCredentials = new TokenCredentials(authenticationResult.AccessToken, "Bearer");

@sshresthareach yes, it uses the OAuth2 flow - unfortunately I don't have any good references for you that aren't C#

@adamvan101 Thank you for confirming that. I will try the Client Credential flow for OAauth2

Thank you for your question and to @adamvan101  for the responses. It looks like we have a gap in documentation so I've assigned this to the writer. We have a lot of people on vacation through the summer so it might be a little while before it gets addressed. @markingmyname  - can you handle this one until your replacement is hired?

Thanks for your comment, @sshresthareach. This looks like a support request rather than documentation feedback – you can get support by going to https://support.powerbi.com. You might find a solution in the Power BI Community, found at https://community.powerbi.com.
I would add your suggestion to the ideas page.

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion, and we will reopen the issue.

@markingmyname I think this is a documentation issue because there really is no documentation on how to generate access token using service principal, other than a small C# snippet. If someone is new to Oauth2 and C# then there would really be no direction one could take. In contrast there is a tonne documentation to generate a token with a powerbi account.
I think it would be helpful if the documentation included something about OAuth2 and the correct flow to use. Also the documentation could include the endpoints to call for the OAuth2 flow rather than a C# snippet.


Subclassed decorator methods not working

My framework relies on (smart) subclassing, but I've also got it to work with attrs mostly. Running into a problem like the following.
@attr.s
class BaseClass():

    value = attr.ib(default=10)

@attr.s
class TestClass(BaseClass):

    @value.default
    def _not_value(self):
        return 20

This throws an error like:
<ipython-input-12-7baf0268d8f2> in TestClass()
      7 class TestClass(BaseClass):
      8
----> 9     @value.default
     10     def _not_value(self):
     11         return 20

NameError: name 'value' is not defined

This throws an error like:
<ipython-input-12-7baf0268d8f2> in TestClass()
      7 class TestClass(BaseClass):
      8
----> 9     @value.default
     10     def _not_value(self):
     11         return 20

NameError: name 'value' is not defined

I don't understand why this wouldn't work, but it seems attrs is heavily reworking the new / init system so its easy for something like this to go over my head.
Shouldn't TestClass inherit value from BaseClass?
Is there a work around?

I don't understand why this wouldn't work, but it seems attrs is heavily reworking the new / init system so its easy for something like this to go over my head.
Shouldn't TestClass inherit value from BaseClass?
Is there a work around?

seems like this is more of a python issue https://stackoverflow.com/questions/3782040/python-decorators-that-are-part-of-a-base-class-cannot-be-used-to-decorate-membe

seems like this is more of a python issue https://stackoverflow.com/questions/3782040/python-decorators-that-are-part-of-a-base-class-cannot-be-used-to-decorate-membe

Yeah… this isn't attrs.

Yeah… this isn't attrs.

@wsanchez i understand closing this as it isn't something python directly supports, however it seems to be a strongly suggested method from the attrs docs which doesn't work in the case of subclasses.
In reviewing other issues before I posted this one, I found a solution that could potentially alleviate this by relying on the attrs namespace:
https://github.com/python-attrs/attrs/issues/707#issuecomment-718868867

@wsanchez i understand closing this as it isn't something python directly supports, however it seems to be a strongly suggested method from the attrs docs which doesn't work in the case of subclasses.
In reviewing other issues before I posted this one, I found a solution that could potentially alleviate this by relying on the attrs namespace:
https://github.com/python-attrs/attrs/issues/707#issuecomment-718868867

Ah, let's re-open for consideration in the docs.

Ah, let's re-open for consideration in the docs.


Create templates-2019.md

@mitchdenny I've thought this one through a bit more. If we're going to make a change to the upload schema, discussion needs to happen on that doc. This PR isn't the right place for deciding on new YAML syntax; it's only for describing updates to the templates.


run properly even if iconv extension is not loaded

KuiKui: we no longer have a CLA requirement, so you can ignore that. However, can you address roberbasic's point, please? I'll merge once that is done.

I really wonder about this. We are using iconv in many places, always in favor of the multibyte extension, because iconv is shipped and enabled by default. So:
a) why do you need this check?
b) if we need it, shouldn't it be added to all components?

a) You already mentioned that it is shipped and enabled by default. So it doesn't mean that it always has to be available, it's nothing more than a default setting. Having a fallback is always good.
b) Yes it should

By the way, this patch completly breaks the Hostname validator when iconv is not available (using strlen instead of iconv_strlen is not a proper fallback).


PEX 1.23.3 Group Bug on Craftbukit 1.8.8

When adding permissions to Pex that are close to other groups they are added to the wrong one for example
/pex group B add prisonprofessional.sellall.B
/pex group D add prisonprofessional.sellall.D
/pex group M add prisonprofessional.sellall.M
/pex group O add prisonprofessional.sellall.O
Permission "prisonprofessional.sellall.B" added to group "Builder"!
Permission "prisonprofessional.sellall.D" added to group "Default"!
Permission "prisonprofessional.sellall.M" added to group "Manager"!
Permission "prisonprofessional.sellall.O" added to group "Owner"!
/pex group B add prisonprofessional.rank.B
/pex group D add prisonprofessional.rank.D
/pex group M add prisonprofessional.rank.M
/pex group O add pprisonprofessional.rank.O
Permission "prisonprofessional.rank.B" added to group "Builder"!
Permission "prisonprofessional.rank.D" added to group "Default"!
Permission "prisonprofessional.rank.M" added to group "Manager"!
Permission "prisonprofessional.rank.O" added to group "Owner"!
These all need to bed added manually in the permissions now and sometimes it can be very frustrating especially when people don't space the permissions correctly and it crashes the entire permissions file.
Also these never appear in console only in game it will say when they are added to a group.
Group Manager never did this. and we were force to switch to PEX for plugin permission issues and corruption to group files. Is it possible this can be fixed by Thursday for PEX 1.7.10 and 1.8?

This is due to the fact that old PEX tried to do async updating without retrofitting a lot of the commands and API to be aware of it, so some value tearing would occur. This should be cleared up in PEX2


Support lastModifiedBy for GCS + S3

@ewiseblatt

FYI @anotherchrisberry
@ewiseblatt I updated GCS (it was an identical change to S3) but didn't test it out.
@gregturn I did not update the Redis implementation ... it felt boilerplate to do it in every single DAO. Was thinking it might be more elegant to have a serializer capable of setting lastModifiedBy (and lastModified) but figured you might have an even better spot.

LGTM


Image requires a pause before being completed

When getting an image using

let img = new skiaCanvas.Image(url)

The img is initially: Image { pending, src: undefined }
.. but after a pause it is fulfilled: Image { width: 256, height: 256 }
Here's a file, skiaimg, showing this.
You can also simply start a repl (deno repl -A --unstable) and drop all the text in it.
skiaimg:

// deno run -A  --unstable skiaimg.js
import { delay } from<EMAIL_ADDRESS>import * as skiaCanvas from<EMAIL_ADDRESS>console.log('skiaCanvas', Object.keys(skiaCanvas))
const url =
'https://s3.amazonaws.com/elevation-tiles-prod/terrarium/13/1555/3084.png'
// prove url is ok
const fetched = await fetch(url).then(resp => resp.blob())
console.log('fetch test', fetched)
// use skia to get image. needs delay
let img = new skiaCanvas.Image(url)
console.log('img test', img)
await delay(1000)
console.log('img test', img)

It is like the standard Image object in the web - you must wait for onload or onerror to fire. Or just use await Image.load(url).

Javascript does not have a Image.load as far as I know. This is the promise-ified way to get an image in the browser:
      new Promise((resolve, reject) => {
            const img = new Image()
            img.crossOrigin = 'Anonymous'
            img.onload = () => resolve(img)
            img.onerror = () => reject(`Could not load image ${url}`)
            img.src = url
        })

Would this work with skia?

Yep JS does not, it's merely a convenience method in skia canvas. That code should work fine with skia canvas as well.

Worked! Now both the browser and deno can use the same method for fetching files.


NullPointerException when requesting the service identification with the default locale

2cf75e41fa5dcb26922f1fd446a2e91e0bb6a1a5 introduced a bug the results in a NullPointerException when OwsServiceIdentificationFactory.create() is called. The producer will pass a locale down to the factory which doesn't check for null in the getTitle(Locale) and getAbstract(Locale) methods.

@autermann the 7.3.1 release does not solve the issue in the eopad backend. I am still getting:
java.lang.NullPointerException
	at org.n52.janmayen.i18n.LocaleHelper.getEquivalents(LocaleHelper.java:73)
	at org.n52.iceland.ogc.ows.OwsServiceIdentificationFactory.getTitle(OwsServiceIdentificationFactory.java:200)
	at org.n52.iceland.ogc.ows.OwsServiceIdentificationFactory.createFromSettings(OwsServiceIdentificationFactory.java:157)
	at org.n52.iceland.ogc.ows.OwsServiceIdentificationFactory.create(OwsServiceIdentificationFactory.java:145)
	at org.n52.iceland.ogc.ows.OwsServiceIdentificationFactory.create(OwsServiceIdentificationFactory.java:46)
	at org.n52.iceland.util.LocalizedLazyThreadSafeProducer.create(LocalizedLazyThreadSafeProducer.java:66)
	at org.n52.iceland.util.LazyThreadSafeProducer.get(LazyThreadSafeProducer.java:65)

The problem lies imho at https://github.com/52North/arctic-sea/blob/master/iceland/core/src/main/java/org/n52/iceland/util/LocalizedLazyThreadSafeProducer.java#L66, using explicitly null as the constructor arg.

Nope. The stacktrace has definitely been produced by arctic sea <=7.3.0

yap, was an issue with muliple versions due to the WAR overlay structure of the project..


The documenation of operator hub installation of Operator is using the wrong csi namespace

Describe the bug
On the website:
https://operatorhub.io/operator/ibm-spectrum-scale-csi-operator
Click on the Install button.
The 2nd step says to:
$ kubectl create -f https://operatorhub.io/install/ibm-spectrum-scale-csi-operator.yaml.
This yaml uses incorrect operator name and namespace:  It is all pre-pended with "my-"
# cat ibm-spectrum-scale-csi-operator.yaml
apiVersion: v1
kind: Namespace
metadata:
  name: my-ibm-spectrum-scale-csi-operator
---
apiVersion: operators.coreos.com/v1
kind: OperatorGroup
metadata:
  name: operatorgroup
  namespace: my-ibm-spectrum-scale-csi-operator

Step 3 also says to incorrectly use the namespace, my-ibm-spectrum-scale-csi-operator
To Reproduce
N/A
Expected behavior
The operator name should be:
ibm-spectrum-scale-csi-operator
The namespace should be:
ibm-spectrum-scale-csi-driver
Environment
N/A
Developement
N/A
Deployment
N/A
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

I found out that the incorrect namespace and yaml are part of Operator Hub documentation that we cannot change.  Since this is the case, we should make a note of this in our KC under the OLM install instructions:
Installing IBM Spectrum Scale Container Storage Interface driver using Operator Lifecycle Manager (OLM).
We should mention to

Don't follow operator hub's step 2, which is to do :
kubectl create -f https://operatorhub.io/install/ibm-spectrum-scale-csi-operator.yaml
We should say that the admin should download the yaml file and remove the "my-" from any names.
wget kubectl create -f https://operatorhub.io/install/ibm-spectrum-scale-csi-operator.yaml.
sed -i 's/my-//g' ./ibm-spectrum-scale-csi-operator.yaml

2)Operator Hub's step 3, says "kubectl get csv -n my-ibm-spectrum-scale-csi-operator"
The CSI admin, should run, kubectl get csv -n ibm-spectrum-scale-csi-operator

Hi Monica,
I will go ahead and make the KC update.
I have a question, which is that why are we not able to change the install doc on the Operator page? I understand that since 1.1.0 Operator is already uploaded on the Operator Hub, we cannot change it. However, cant we change that for Operator 2.0, which is yet to be posted on the Op Hub?
This brings me to my next question, which KC version should this doc change be applicable to? 1.1.0 or 2.0.0 or both?

Hi Monica,
Please take a look at the doc change and let me know for any issues: https://rtpdoc01.rtp.raleigh.ibm.com:9443/kc/STXKQY_CSI_review/com.ibm.spectrum.scale.csi.v2r00.doc/bl1csi_install_usingOLM.html

Monica, any action required from my side? Do you want me to close this issue?


iOS - Display SORA Card Transactions

As a SORA Card user I want to see the transactions I made with the SORA Card so that I can follow up on my expenses.
Aha! Link: https://soramitsucoltd.aha.io/features/SORANEO-709

hey is this still relevant or not and when are we planning such implementation?
let's move the task status as a feature

@Trezeguet1 assigned to @bgodlin


Neodigm | Universal Click / Hover event emitter

First filter: ev.dataset.has( *n55 * )
The hope is that shrinks the library by more than a few bytes.
The performance gain would be advantageous if installed as a widget.

Consider the DOM3 walk logic.


Animation bug

When I launch my application for the first time the animation is not applied only to the redacted view but to the whole view:

This is my code:
ScrollView {
                    TodayFeaturedRecipesView()
                        .environmentObject(viewModel)
                        .tag(0)

                    TodayStatisticsView()
                        .environmentObject(viewModel)
                        .padding(.top)

                    if !(accManager.user?.isPremium ?? false) {
                        TodayFreeRecipesView()
                            .environmentObject(viewModel)
                        ExplorePremiumBannerView()
                            .redacted(reason: viewModel.isLoading ? .placeholder : [])
                            .shimmering(active: viewModel.isLoading, gradient: colorScheme == .dark ? K.Gradients.lightShimmeringGradient : K.Gradients.darkShimmeringGradient)
                    }
                }

We had the same issue and were able to fix it by introducing the changes from #20
Can you try if this fix works for you as well?

Yup, the issue was fixed! Thank you :)


Question: Will update hls.js to 0.7.5 version?

Will update hls.js to 0.7.5 version?

@leandromoreira i just realized that hls.js version in package.json is "^0.7.2" and the value in yarn.lock is "^0.6.17" (locked to "0.6.18").
Do you known if Greenkeeper bot can handle yarn.lock modification in pull requests ? (if not it may be also a nice feature request).

@kslimani I don't know = / but we should keep the newest version on both case shouldn't we?

maybe update the bump script to keep yarn.lock up to date at each release ?

@kslimani sure, we'll update the bump script to work with yarn.lock when we release the next version. I think we'll do it by tomorrow.

I just try update bump script on my fork to update yarn.lock (https://github.com/DiegoZurita/clappr/blob/master/bump), is something like that?


Replace freenode.net by libera.chat

https://lwn.net/Articles/857252/
https://arstechnica.com/gadgets/2021/05/freenode-irc-has-been-taken-over-by-the-crown-prince-of-korea/
Freenode former staff have resigned and moved to libera.chat .
This patch makes #go-nuts at libera.chat official IRC channel of Golang

@googlebot I signed it!

@googlebot I signed it!


Is this not maintained anymore?

Was looking to use ReactiveColorPicker

it seems ReactiveColorPicker and ReactiveDropdownField dont save the values after picking something.
When I printed the form.value, all the fields has values except those two. Any fix, is this a bug or something more is required for it to work?


Sometimes the contrast is wrong

With the same setting, it seems in different contrast. I notice that if the file is opened directly with nvim, the contrast is correct, then I open another file with :e, then the text contrast is wrong, but the background contrast is correct.  But for some directory and some file, it always correct.
Any idea?
Environment: Nvim 0.7.0

This is a confliction with plugin semantic-highlight, which highlights text as in the left image.


Unable to close rewarded video ad with screen reader

Using talkback on an Android phone it is not possible to select the close button on a rewarded video ad.
Plugin version: 0.12.1+1

Logs
[√] Flutter (Channel stable, 2.0.5, on Microsoft Windows [Version 10.0.19041.928], locale en-US)
    • Flutter version 2.0.5 at C:\Flutter
    • Framework revision adc687823a (9 days ago), 2021-04-16 09:40:20 -0700
    • Engine revision b09f014e96
    • Dart version 2.12.3

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\impur\AppData\Local\Android\sdk
    • Platform android-30, build-tools 29.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] IntelliJ IDEA Ultimate Edition (version 2020.2)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA 2019.3.3
    • Flutter plugin version 50.0
    • Dart plugin version 202.7319.5

[√] VS Code (version 1.49.1)
    • VS Code at C:\Users\impur\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.15.1

[√] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 90.0.4430.85
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 90.0.818.46

• No issues found!

I am able to reproduce the issue using the latest google_mobile_ads:^ 0.13.3 with talback on the rewarded ad cannot be closed looks like the button is disabled when the timer runs out.This issue only happens when talkback is on.

output
https://user-images.githubusercontent.com/31410839/129044038-e39298ce-54f4-403d-b28b-05da7370db15.mov

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.3, on macOS 11.4 20F71 darwin-arm, locale en-GB)
    • Flutter version 2.2.3 at /Users/mahesh/Documents/flutter
    • Framework revision f4abaa0735 (4 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.1.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 57.0.5
    • Dart plugin version 211.7233

[✓] VS Code (version 1.58.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.24.0

[✓] Connected device (4 available)
    • Redmi K20 Pro (mobile)                       • android-arm64  • Android 11 (API 30)
    • iPhone 12 Pro Max (mobile) • 6A434744-B348-4FB3-AB10-131292174456 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-4 (simulator)
    • macOS (desktop)            • macos                                • darwin-arm64   • macOS 11.4 20F71 darwin-arm
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 92.0.4515.107

• No issues found!

Same thing for interstitials, I can't get out of the ad with talkback.
If I understood the target system correctly and p3-low means essentially not very important, I would like to ask you to prioritize this bug.
I'm not visually impaired, but blocking the user like this means they have to uninstall the app because it becomes unusable.
In my use case for example, when a user clicks a main button, I first show the interstitial and then execute the operation, but if you can't exit the interstitial, the application becomes unusable and this means uninstall and potential (honest) one star review.
plugin version: 2.2.0
test device: Motorola Moto g22
https://user-images.githubusercontent.com/83022092/215098978-91febe69-ef8b-4561-bf67-c0a30e8f7b6b.mp4

We’re closing this issue due to inactivity. If you’re still impacted, please create a new issue via the Developer Forum.


Reduce buffer-locking time in ATW

When ATW is used with a long maximum time before vsync and with vsync-blocks-app, the ATW thread will lock the render buffers from that time until vsync has finished.  Strictly speaking, it would only have to lock it until the rendering is done not until after present is done.  Figure out how to make this happen without torquing the interface too much.

For my internal testing, I had broken out the PresentRenderBuffers call into a two-stage process that was opt-in. By default, RenderManager used its existing pipeline. If a flag was set on a RenderManager instance, then the client has to call a second Present method after PresentRenderBuffers to cause the actual Present to occur. The first stage simply issued the draw calls. The ATW wrapper instance would then set the flag on its internal instance of RM and releases its lock between the two calls. Normal clients are unaffected.
If this sounds acceptable, I can put together a pull request.

@russell-taylor  If you want, this opt-in behavior can be kept internal to RenderManager, not exposing it to clients/engines.

That would get us part of the way there, but the RenderManagerBase PresentRenderBuffers() function itself does a wait until right before max, which could be a problem in a general application.  Of course, the ATW thread does its own wait so won't cause the max to hold off in that case.  Let me think about this a bit more, but go ahead and at least point me at your branch so I can take a look at what it is doing.


Add disableHeroBackground property to DocumentationTopic view

Bug/issue #, if applicable: 127009817
Summary
This allows for the existing disableHeroBackground flag to be configurable at the view level, in addition to the component level.
Testing
Steps:

Test that there are no changes introduced with the default behavior with the documentation intro background
Test that the flag can be enabled at the view level, resulting in a more plain background for the documentation page intro

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[X] Added tests
[X] Ran npm test, and it succeeded
[X] Updated documentation if necessary

@swift-ci test


run Rackhd with docker failed

Hi,
When installing ubuntu, it will shows the error on on-taskgraph. Maybe its version is not right ?
error info:
"state":"failed","terminalOnStates":["timeout","cancelled","failed"],"error":"AssertionError: No OBM service assigned to this node.\n    at AssertService.(anonymous function) [as ok] (/RackHD/on-core/lib/common/assert.js:30:28)\n    at /RackHD/on-taskgraph/node_modules/on-tasks/lib/jobs/obm-control.js:78:24\n    at tryCatcher (/RackHD/on-core/node_modules/waterline/node_modules/bluebird/js/main/util.js:26:23)\n    at Promise._settlePromiseFromHandler (/RackHD/on-core/node_modules/waterline/node_modules/bluebird/js/main/promise.js:503:31)\n    at Promise._settlePromiseAt (/RackHD/on-core/node_modules/waterline/node_modules/bluebird/js/main/promise.js:577:18)\n    at Async._drainQueue (/RackHD/on-core/node_modules/waterline/node_modules/bluebird/js/main/async.js:128:12)\n    at Async._drainQueues (/RackHD/on-core/node_modules/waterline/node_modules/bluebird/js/main/async.js:133:10)\n    at Immediate.Async.drainQueues [as _onImmediate] (/RackHD/on-core/node_modules/waterline/node_modules/bluebird/js/main/async.js:15:14)\n    at processImmediate [as _immediateCallback] (timers.js:383:17)"},"ecdc33d4-a72d-4017-8112-1b3bf76565ac":{"friendlyName":"Set Node Pxeboot","injectableName":"Task.Obm.Node.PxeBoot","implementsTask":"Task.Base.Obm.Node","schemaRef":"rackhd/schemas/v1/tasks/obm-control","options":{"action":"setBootPxe"},"properties":{"power":{}},"instanceId":"ecdc33d4-a72d-4017-8112-1b3bf76565ac","runJob":"Job.Obm.Node","label":"set-boot-pxe","name":"Task.Obm.Node.PxeBoot","waitingOn":{},"ignoreFailure":true,"state":"failed","terminalOnStates":[],"error":"AssertionError: No OBM service assigned to this node.\n    at AssertService.(anonymous function) [as ok] (/RackHD/on-core/lib/common/assert.js:30:28)\n    at /RackHD/on-taskgraph/node_modules/on-tasks/lib/jobs/obm-control.js:78:24\n    at tryCatcher (/RackHD/on-core/node_modules/waterline/node_modules/bluebird/js/main/util.js:26:23)\n    at Promise._settlePromiseFromHandler (/RackHD/on-core/node_modules/waterline/node_modules/bluebird/js/main/promise.js:503:31)\n    at Promise._settlePromiseAt (/RackHD/on-core/node_modules/waterline/node_modules/bluebird/js/main/promise.js:577:18)\n    at Async._drainQueue (/RackHD/on-core/node_modules/waterline/node_modules/bluebird/js/main/async.js:128:12)\n    at Async._drainQueues (/RackHD/on-core/node_modules/waterline/node_modules/bluebird/js/main/async.js:133:10)\n    at Immediate.Async.drainQueues [as _onImmediate] (/RackHD/on-core/node_modules/waterline/node_modules/bluebird/js/main/async.js:15:14)\n    at processImmediate [as _immediateCallback] (timers.js:383:17)"},"5fc6d709-cff9-48d1-b80d-027fc072f59d":{"friendlyName":"Install Ubuntu","injectableName":"Task.Os.Install.Ubuntu","implementsTask":"Task.Base.Os.Install","schemaRef":"rackhd/schemas/v1/tasks/install-os-general","options":{"osType":"linux","profile":"install-ubuntu.ipxe","installScript":"ubuntu-preseed","installScriptUri":"http://<IP_ADDRESS>:9080/api/current/templates/ubuntu-preseed","hostname":"rackhd-node","comport":"ttyS0","domain":"abc.com","completionUri":"renasar-ansible.pub","version":"trusty","repo":"http://<IP_ADDRESS>:9080/ubuntu","rootPassword":"RackHDRocks!","rootSshKey":null,"users":[],"networkDevices":[],"dnsServers":[],"installDisk":"/dev/sda","kvm":false},
From DaoCloud

It looks like it's a error 'AssertionError: No OBM service assigned to this node'  Do you have use the latest master codes? if yes, please check the 'obms' in this node, and GET /api/2.0/obms to see if the obms exist.

Just do it as the document said using docker-compose up.

anyone can test it ?

it says "Cannot GET /api/2.0/obms"

Will see if I can enlist the help of @rolandpoulter here

@James-Dao Not sure if you figured this out yet, but certain graphs require a obmSettings field on the node. Otherwise the graph will fail with the error you pasted above.
Assuming you were testing this out with a VirtualBox node. You should be able to add an OBM to your node:
PUT /api/2.0/obms
body:
{
    nodeId: <nodeId>,
    config: {},
    service: "vbox-obm-service" OR "noop-obm-service"
}

I don't believe there is anything wrong with running RackHD on Docker.

@James-Dao Let us know the result here after @rolandpoulter suggestions and if you still need any help. Thanks!!

No response. Closing this one out.


Review "Coding Orange"

Link: https://coding-orange.podigee.io/

just 2 episodes this year, five in total, would revisit in some months and see if they are still active

no more episodes


A way to set focused point via props

Is there any way to control focused point via props? If not, could you please add focusedDataPointIndex prop for that? And then onFocus callback could be adjusted to get changed value out of chart, like:
const [focusedPointIndex, setFocusedPointIndex] = useState(2)
...
<LineChart data={...} focusedDataPointIndex={focusedPointIndex} onFocus={setFocusedPointIndex} />

Hi @vilnytskyi
Thanks for requesting this feature.
It is now available from version 1.4.13 onwards! 🎉
Added the prop focusedDataPointIndex to Line/Area charts.


Feature request: List of commits

Hi,
would be damn cool to include a list of all commits for the page.
Can you please add such a feature?

This can be targeted by an improvement following #6


UK/EU size, PLEASE!

Hi,
Are there any plans to release UK/EU size?

Closing as this repo is not being maintained.  Check here for the updated project!


Change the sound according to the chosen image

Description
When we select the background image the sound could change accordingly. If the image is rain, the sound of rain should be activated.
Referencies

What a nice suggestion! Thanks @ErickBessa

This wasn't the original propose of this background feature, I was thinking to just serve as a background menu that you will change accordingly with your likes, without interfere on sounds. But I like your idea, I will consider implementing it. Thanks!

Returning to update the project, I noticed that I already created an issue a while ago precisely for this feature! #34


free API key not working?

Dear Santiago,
I am trying to set this up, using a free API token. I haven't used any of API free grant. Still I don't seem to get it work.
Neither with setting an environmental variable, nor with the openai-api-key option.
Is there anything wrong in using the free API key? Or what could be the reason?
That's the error I am getting:
APIResponseException: Failed API Request 'POST /v1/chat/completions'
Thanks,
Andreas

Hello Andreas. Can you try running the %chat_models directive? We have to understand if it's an issue with authentication or OpenAI's API (that is not working very consistently lately).

Hi thnks for the quick response,
ok, now I am getting this APIResponseException: Failed API Request 'POST /v1/chat/completions'. Got 429: You exceeded your current quota, please check your plan and billing details.
but I've never used the API before and inside openai it shows me I haven't used any of my 18$ quota. Maybe free accounts are blocked?

p.s. %chat_models works

That's strange. Can you try re-generating the API Token? Using a new one to make sure it's tied to the billing account with the $18 quota.

@BuddyVolly I'm closing this one as it was probably an issue with API quota. Re-open it if still experiencing the issues.


Combine H1 and H2 conn_pool implementations

This allows the H2 connection pool to have more than 2 connections (1 active, 1 draining), which allows things like very low values of max_requests_per_connection to work because there can be multiple draining connections concurrently, as well as supporting multiple active connections.
Risk Level: High
Testing: Unit, integration
Docs Changes: Added to .proto; possible other changes are needed
Release Notes: TODO
Fixes #7403
Maybe fixes #9215

cc @snowp

I have 2 big concerns with this PR:

I messed up the implementation and it completely breaks the world until the bug is fixed
Subtle behavior changes to existing configurations. Behavior is mostly the same for both H1 and H2 pools, with the exception of circuit breakers. The old behavior was to only look at connection circuit breakers for H1 pools, and only look at request circuit breakers for H2 pools. Now, both types are looked at in all cases. Will this break someone?

Re 2. I have written code myself that doesn't touch the unused circuit breaker for H1/H2 only clusters, so I'm sure there are several cases where people have bumped the max connection CB for a HTTP/1.1 only cluster to permit some concurrency but left the max request CB limit at the default. I'm wondering if we should be runtime guarding the new behavior and then communicate the change of behavior with a timeline for changing the default. Thoughts @mattklein123 ?

Might be good to add some test coverage to the new circuit breaking behavior for H1/H2

I wanted to discuss and figure out what we want the behavior to be before I write tests for it.


Refactor plot styling

Background
Link to issue
https://biomage.atlassian.net/browse/BIOMAGE-543
Link to staging deployment URL
Coming soon
Links to any Pull Requests related to this
N.A.
Anything else the reviewers should know about the changes here

IN PROGRESS
Pused to PR to request for comments on architecture / concerns
Right now only implemented for Continuous Embedding plot. Once component is ok, other plots will be updated.

Changes
Code changes

PlotStyling is refactored out of plots-and-tables folder into components, under a new plotStyling folder.
All components of plot styling also moved to the plotStyling folder
PlotStyling component interface :
-- formConfig : receive configuration object to control form fields that should be used
-- config : receive plot config
-- onUpdate : function to update config object

Definition of DONE
Your changes will be ready for merging after each of the steps below have been completed:
Testing

[ ] Unit tests written
[X] Tested locally with Inframock
[ ] Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils
Documentation updates
Is all relevant documentation updated to reflect the proposed changes in this PR?

[ ] Relevant Github READMEs updated
[ ] Relevant wiki pages created/updated

Approvers

[ ] Approved by a member of the core engineering team
[ ] (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

[ ] After the PR is approved, the unstage script in here: https://github.com/biomage-ltd/biomage-utils is executed. This script cleans up your deployment to staging

Optional

[ ] Photo of a cute animal attached to this PR

Changed to another PR based on more recent master branch


UserId

Consider if a UserId (identified of a user in the system) should not have a message on its own (instead of just string).
This is to foresee an external scope (as done for ResourceId breaking it into opaque id and storage id).

@moscicki I will even require that this is the case for the identity of the user.
Doing that we address two issues:

federated setups like Sciebo or Surfsara can have different user management services depending on the institution of the users.
OCM shares

Something on the lines ...
message UserId {
  string user_provider_id = 1;
  string opaque_id = 2;
}


Fix wrong Wayland path if building with opengl3=no

Godot checks if there's Vulkan or GLES3 support.
If no support is found, it shows an error message.
However the code for this error message is left out when building with opengl3=no

Good catch!
Note that building with both opengl3=no and vulkan=no will cause another error due to an unguarded RenderingServer reference in the suspension checking code. It is unrelated to this PR though.

Isn't there will be used dummy?


[FEAT]: Redux Auth slice

Describe
Adding the redux auth slice for state management of authentication

@dvjsharma Please assign me this issue under GSSOC24!

Hey @Sid-80, Please go ahead. This would be a nice addition for overall state management. The architecture is already in place but needs to be implemented. Feel free to ping me or @ShashankShekhar07 regarding any queries.

Sure! sir

@dvjsharma Please review the pull request! Let me know if any changes required!


[Feature idea] tight github issues integration

Thought I would expand on my comment about the possibilities closing topics presents:

having a stream with a "topic per issue" synced with github would be a killer feature

This is what I'm imagining:

a bot that adds a badge to each issue linking to the topic, with some heuristic for activity (chat length, most recent message)
the ability to select a range of comments in the topic and turn them in to a comment (if not a comment already)
and naturally, the topic is updated with activity from the issue

I know this would be a pretty hefty integration, but it would radically streamline communication in software projects. A large amount of the communication work I do as an engineer is negotiating the gap between github/lab/bucket and not. Being able to seemlessly bridge that gap would be a massive value add.

I feel this can be a really great feature.


Locale request: kn-IN

Which locale do you wish to add?
First check if your locale has already been requested. If so, go and add an emoji to that request to show your support.
For new requests, write the locale identifier in the subject after the colon.
Example: "Locale request: nb-NO".
We use BCP-47 with region subtags, see "IETF language tag".
Maintainer
Sanity will bootstrap and keep the locale updated using AI. We would like human contributors to help maintain the locales by improving them and/or reviewing pull requests from the AI and from other contributors as they come in. Check the box below if you want to be added as a maintainer of this locale. As a maintainer you will be automatically added as reviewer to future PRs that improve it.
If you are not the author of this issue, but would still like to be added as a maintainer, please add a comment to the thread.

[x] I want to be added as maintainer

Thanks for your interest! Our AI translator has taken a first pass at a translation, feel free to review the pull request here:
https://github.com/sanity-io/locales/pull/438
Once you've approved the changes, we can merge and release the new locale.

Also, feel free to join the #locales-contributors channel on our community Slack :)


Update sensor.py

ecoflow.fetch_data_km2() does not exist and should read ecoflow.fetch_data()

Thanks :-)


Release sql microsoft.sql 2022 11 01 preview

ARM API Information (Control Plane)
What:
This swagger release PR is directly copying all the content from https://github.com/Azure/azure-rest-api-specs/tree/release-sql-Microsoft.Sql-2022-11-01-preview
ALL the approved 2022-11-01-preview changes (breaking changes, validation error exceptions, ARM sign offs) are in this dev branch:
https://github.com/Azure/azure-rest-api-specs/tree/release-sql-Microsoft.Sql-2022-11-01-preview
The commit list is as follows:
https://github.com/Azure/azure-rest-api-specs/compare/main...release-sql-Microsoft.Sql-2022-11-01-preview
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

@jeremyfrosti Please fix CI checks errors (LintDiff and Model validation), you can refer to this comments or  https://aka.ms/ci-fix on how to fix it.

@jeremyfrosti Please fix CI checks errors (LintDiff and Model validation), you can refer to this https://github.com/Azure/azure-rest-api-specs/pull/23802#issuecomment-1533751342 or https://aka.ms/ci-fix on how to fix it.

@rmanda Please help review the Lintdiff error.

/azp run

/azp run

Dev branch merge, signing off from ARM side since the individual PRs are already approved

@jeremyfrosti Regarding the lintDiff error, what is the result of the current discussion?

@raych1 Can I have a review for the GO SDK breaking change?
@msyyc Can I have a review for the Python SDK breaking change?
@qiaozha Can I have a review for the JS SDK breaking change?

/azp run

@chidozieononiwu, @maririos Please help review the swaggerApiView error.

@live1206  Please help review the azure-sdk-for-net-track2 error.

@live1206 Please help review the azure-sdk-for-net-track2 error.

error   | PreCheck/DuplicateSchema | Duplicate Schema named 'DatabaseVulnerabilityAssessmentRuleBaseline' (1 differences):
07:01:07.938 cmdout 	[Invoke-GenerateAndBuildV2.ps1]     - properties.properties.$ref: "#/components/schemas/schemas:511" => "#/components/schemas/schemas:1836"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
07:01:07.938 cmdout 	[Invoke-GenerateAndBuildV2.ps1]   error   | PreCheck/DuplicateSchema | Duplicate Schema named 'DatabaseVulnerabilityAssessmentRuleBaselineProperties' (2 differences):
07:01:07.938 cmdout 	[Invoke-GenerateAndBuildV2.ps1]     - properties.baselineResults.x-ms-identifier: [] =>
07:01:07.938 cmdout 	[Invoke-GenerateAndBuildV2.ps1]     - properties.baselineResults.$ref: "#/components/schemas/schemas:512" => "#/components/schemas/schemas:1837"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
There are duplicated schemas named DatabaseVulnerabilityAssessmentRuleBaseline and DatabaseVulnerabilityAssessmentRuleBaselineProperties defined in sql swagger, we added the setting "lenient-model-deduplication: true" in azure-sdk-for-net to temporarily disable the check, and the setting will be removed as shown above.
We have other ways to solve this during SDK generation as well. But .NET track 2 automation will never pass for sql. We will have to ignore the failure of .NET track 2 automation for sql all the time.

Confirmed with the author that Lintdiff's error ARM team allows its exception about this PR.

@chidozieononiwu, @maririos Please help review the swaggerApiView error.

@chidozieononiwu to confirm, but this looks like an error in the Swagger parser. This failure shouldn't block the PR from merging cc @v-xuto


[Mktg Templates] - Created to increase efficiency on routine activities

[x] https://github.com/eclipse/microprofile-marketing/issues/new?assignees=&labels=Announcement&template=API+Announcement.md&title=[Social+Media+Annoucement]+API+X
[x] https://github.com/eclipse/microprofile-marketing/issues/new?assignees=&labels=Announcement&template=Compatible+Implementations+Announcement.md&title=[Compatible+Implementations+Announcement]+Product+Name%2C+Version+
[x] https://github.com/eclipse/microprofile-marketing/issues/new?assignees=&labels=Social+Media&template=Consecutive+Yearly+Media+Messages.md&title=[Social+Media]YEAR+-+Task]
[x] https://github.com/eclipse/microprofile-marketing/issues/new?assignees=&labels=Blog&template=Contributing+Blog+Content.md&title=[Blog+Contribution]+Name+of+blog
[x] https://github.com/eclipse/microprofile-marketing/issues/new?assignees=&labels=Sessions&template=MicroProfiler+Activity+Announcement.md&title=[Social+Media]+Name+of+Activity]
[x] https://github.com/eclipse/microprofile-marketing/issues/new?assignees=&labels=Quotes&template=MicroProfiler+Quote+Testimonials.md&title=[Quote+Submission]+Name+of+Guest%2C+Committer%2C+Corporate%2C+Contributor+or+User
[x] https://github.com/eclipse/microprofile-marketing/issues/new?assignees=&labels=Announcement&template=New+Committer+Announcement+.md&title=[New+Committer+Announcement+]+Name+of+Committer]

Completed.


Please consider making "overflow: hidden;" style opt-in

Currently the overflow: hidden style is hard-coded into the React component returned by useEmblaCarousel().
It would be great if this style could be documented as a recommended style in the CSS section of the installation instructions instead of being forced on the component. I'm currently working on a project where I want the inactive slides to be visible outside the container and this style is preventing this.
Happy to submit a PR if this is something you would consider accepting!

Hello Sam (@samhastings),
Thank you for your question. My understanding is that most React users appreciate that this is handled automatically because it’s convenient.
With that said, I understand that this won’t be good in every use case so maybe we can discuss possible solutions before taking action?
With the current way things are done, the overflow property can be overridden by passing a className that applies styles to override this. I know this isn’t optimal because every project doesn’t use class names for styling and this also requires !important` which isn’t beautiful.
One suggestion that comes to my mind is to add a style property to the component which defaults to { overflow: “hidden” }.
I would be happy if we could get this discussion going as soon as possible because I’m going to refactor the hook soon, and it would be nice to solve this request too.
What’s your thoughts about my suggestion? Or do you still think removing this is the best option?
Kindly
David

Hi David
Thanks for your quick and in-depth response!
I think your idea of accepting a style prop would work, as would accepting an overflow prop (typed as  'visible' | 'hidden') which could be passed to a style object in the hook. To me this seems like it would create a cleaner API but does prevent additional inline styles being specified (which may not be the end of the world as the className is also passed down).
The reason I was reluctant to use a className is that I'm using Tailwind CSS on this project where an !importantflag isn't present on the overflow-visible class.
Sam

Hello again Sam (@samhastings),
Thank you for sharing your additional thoughts. Just wanted to say that I’m looking into this. I’m considering exposing a ref that can be used on your own component instead of the React component EmblaCarouselReact which is the current implementation. This would make the Embla footprint even smaller when it comes to forcing stuff on the user.
Would this make things easier for you? Let me know if my explanation is unclear.
Best
David

Hi Sam (@samhastings),
Would exposing a ref instead of EmblaCarousel component help? That would enable you to attach the ref to your own component.
Kindly
David

Can I check I'm understanding you correctly? I'm assuming the code would look something like this...
const [emblaRef] = useEmblaCarousel({ loop: false });

return (

        {...}

);

Hello Sam (@samhastings),
Exactly like that! And the second hook variable you omitted in your example will still be the Embla API like now.
const [emblaRef, emblaApi] = useEmblaCarousel({ loop: false });

return (

        {...}

);

Kindly
David

It would certainly work well for me, but wouldn't this be a BC break though? Unless you're going to introduce it in a new useEmblaRef() hook of course!

Hello Sam (@samhastings),
Yes it is. I've been wanting to refactor the useEmblaCarousel() hook anyway so I just did that and released it now. Please read the migration guide here, and let me know if it solves your issue 🙂.
Best
David

Hello Sam (@samhastings),
Have you had a chance to try the new version out yet?
Best
David

@samhastings I'm closing this as resolved because the ref implementation has been released.

Hi David, sorry that it's taken me so long to get a chance to try this. The project was put on hold for a couple of weeks while I worked on other stuff. Pleased to say this is working perfectly. Thanks for taking the time to implement my request. I really appreciate it.

Hello @samhastings,
I understand, we can all be busy sometimes. Thanks a lot for taking the time to confirm that it’s working as expected. Enjoy 😊.
Best
David


docs: improvements to the README.md

Running through the README.md file to dust if off and try to improve
it ever so slightly.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This is 👍


max-pps default is 600, docs say 800

Not a big deal, just thought I'd let you know the max-pps is set to 600 by default, while the docs say it's 800 by default: https://docs.viaversion.com/display/VIAVERSION/Configuration
In my opinion the config should also have 800 as default to prevent false kicks

We changed it to 800 for the 1.11 update. We updated the docs too early. We thought it would be released by now. Sorry about that :)


AWS: failed with 'dict object' has no attribute 'tag_openshift_role_master'

TASK [instance-groups : Add masters to requisite groups] ***********************
task path: /root/AWS/openshift-ansible-contrib/reference-architecture/aws-ansible/playbooks/roles/instance-groups/tasks/main.yaml:9
fatal: [localhost]: FAILED! => {
"failed": true
}
MSG:
'dict object' has no attribute 'tag_openshift_role_master'

Can you specify the version of ansible you are using? Also, are you using
openshift rpm based playbooks or git clone from openshift-ansible?
On Jan 2, 2017 12:57 PM, "dwojciec"<EMAIL_ADDRESS>wrote:

TASK [instance-groups : Add masters to requisite groups]

task path: /root/AWS/openshift-ansible-contrib/reference-
architecture/aws-ansible/playbooks/roles/instance-groups/tasks/main.yaml:9
fatal: [localhost]: FAILED! => {
"failed": true
}
MSG:
'dict object' has no attribute 'tag_openshift_role_master'
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openshift/openshift-ansible-contrib/issues/143, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADoslDnTyDbNoAzor706puyFDQPAheubks5rOTqNgaJpZM4LZJG8
.

same issue as Didier's (working on the same usecase for a customer).

ansible-<IP_ADDRESS>-4.el7.noarch
openshift playbooks installed via "yum install" as described in the readme file.

This may be a trivial request but can you ensure you are using the
inventory script in reference-arch/aws-ansible/inventory. A quick thought
would be that since those hosts are in a private subnet the python script
is trying to look up public instances with that tag.  Also, it might be
worth forcing a refresh-cache with the ec2.py located in the reference arch
directory. By refreshing cache you should be able to see all information
about running instances.
Ryan
On Jan 2, 2017 1:07 PM, "gt000"<EMAIL_ADDRESS>wrote:

same issue as Didier's (working on the same usecase for a customer).

ansible-<IP_ADDRESS>-4.el7.noarch
openshift playbooks installed via "yum install" as described in the
readme file.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/openshift/openshift-ansible-contrib/issues/143#issuecomment-270003797,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADoslJQy4ATjAQ6SR82pqTFgByqV3Adpks5rOTz1gaJpZM4LZJG8
.

Into the ose-on-aws.py the default command is
command='inventory/aws/hosts/ec2.py --refresh-cache %s' % (devnull)
refresh-cache is already used.

Can you manually run the command ec2.py and post a gist or if it should be
private send it to<EMAIL_ADDRESS>?
On Jan 2, 2017 1:56 PM, "dwojciec"<EMAIL_ADDRESS>wrote:

Into the ose-on-aws.py the default command is
command='inventory/aws/hosts/ec2.py --refresh-cache %s' % (devnull)
refresh-cache is already used.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/openshift/openshift-ansible-contrib/issues/143#issuecomment-270008399,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADoslN6hXhCMPBO5sbHEKw8qi5VNzzv2ks5rOUhigaJpZM4LZJG8
.

Ryan,
we are using us-east-2 region because of the other issue Didier opened:
[https://github.com/openshift/openshift-ansible-contrib/issues/142]
I've noticed us-east-2 is not in the default list in [https://github.com/openshift/openshift-ansible-contrib/blob/master/reference-architecture/aws-ansible/inventory/aws/hosts/ec2.ini]
Shouldn't the script read the "region" parameter passed to ose-on-aws.py to look for hosts created only in that region ?

Ahh ok I believe we have something to work off of now. I dont believe us-east-2 was public around the time that the ec2.ini and ec2.py were added to the repository so the code was not written in ansible/python to support it.  If you currently have the cycles can you replace the ec2.py with this https://github.com/ansible/ansible/blob/devel/contrib/inventory/ec2.py. We can start there. We may need to pull in the ec2.ini as well but that will require us to modify it just a bit to pull just the private subnet images.

I just looked at the ec2.ini and I don't believe us-east-2 is listed to be queried

Adding us-east-2 to ec2.ini makes the script go forward correctly. It would be interesting to understand the reason for the other issue, which brought us to substitute us-east-1 to us-east-2.
The message was "CREATE_FAILED  AWS::EC2::Subnet  PublicSubnet3  Value (us-east-1c) for parameter availabilityZone is invalid. Subnets can currently only be created in the following
availability zones: us-east-1e, us-east-1a, us-east-1b, us-east-1d."
It seems the script tries to create a subnet in us-east-1c but it seems it's forbidden.

Glad we got passed this point. We shall compare notes tomorrow about the
us-east-1 issue. This morning it passed ci in us-east-1 so it may have been
a later in the day aws outage or something with the account. Sometimes
cloudformations will attempt to use a vpc classic subnet which causes
failure
On Jan 2, 2017 4:04 PM, "gt000"<EMAIL_ADDRESS>wrote:

Adding us-east-2 to ec2.ini makes the script go forward correctly. It
would be interesting to understand the reason for the other issue, which
brought us to substitute us-east-1 to us-east-2.
The message was "CREATE_FAILED AWS::EC2::Subnet PublicSubnet3 Value
(us-east-1c) for parameter availabilityZone is invalid. Subnets can
currently only be created in the following
availability zones: us-east-1e, us-east-1a, us-east-1b, us-east-1d."
It seems the script tries to create a subnet in us-east-1c but it seems
it's forbidden.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/openshift/openshift-ansible-contrib/issues/143#issuecomment-270020161,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADoslG6xZuhwSORMSw-xWWZ2fRQ8cwSRks5rOWZzgaJpZM4LZJG8
.


Collapsing Toolbar

Add collapsing toolbar on home screen;
Handle collapsing toolbar glitch when switching betwen pages and flinging the nested list.

https://github.com/joreilly/Confetti/assets/4348197/d0426059-6cd4-4da4-85e0-e8cc6d2d0f45

So cool! 🤩


Reimport tests from https://github.com/o1-labs/proof-systems/pull/1371 if you want :)

          I added in some tests in https://github.com/o1-labs/proof-systems/pull/1371 if you want :)

Originally posted by @dannywillems in https://github.com/o1-labs/proof-systems/pull/1396#discussion_r1416108078

if you want :)

I don't


Partial type generation does not include newly generated modules

Bug description

When using a partial type generator and a custom output directory, the partially generated package is not imported when the partial type generator is ran.
How to reproduce

schema.prisma
datasource db {
  provider = "postgres"
  url      = env("DB_URL")
}

generator client {
  provider               = "prisma-client-py"
  partial_type_generator = "partials.py"
  output                 = "my_prisma"
}

model User {
  id Int @id
  name String
}

partials.py
from prisma.models import User

On a fresh prisma installation (not generated), trying to generate the client will error.
prisma generate

Prisma schema loaded from schema.prisma
An exception ocurred while running the partial type generator
Error:
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "partials.py", line 1, in <module>
    from prisma.models import User
ModuleNotFoundError: No module named 'prisma.models'

Expected behavior

The prisma package should point to the newly generated package.
Should be noted that in the example given above, even trying to import from my_prisma leads to an error but even if it didn't the point still stands as sometimes it may be useful to generate the client to a directory that is multiple directories away and fixing this would require knowledge of where the client was being generated to and some horrible python path patching.
Solution
I do not know how this can be solved as it is due to Python's import caching mechanism, the importlib.reload may be useful here.
In terms of how to integrate a solution into this library you will have to modify the Module.run method in src/prisma/generator/models.py.

This is actually independent from the use of custom output, this can happen in some situations regardless.

One solution could be to block partial_type_generator until all models are generated, and thus ensuring that they exist when partials is executing

i also find that after we generate prima, then we use one relative path to import the User from my_prisma,  there is no partial types generated.
no idea about reason.
reproduce steps:
1. generate without partial type
schema.prisma
datasource db {
  provider = "postgres"
  url      = env("DB_URL")
}

generator client {
  provider               = "prisma-client-py"
  # partial_type_generator = "partials.py"
  output                 = "my_prisma"
}

model User {
  id Int @id
  name String
}

prisma generate

2. add the partial type back, and try to generate
datasource db {
  provider = "postgres"
  url      = env("DB_URL")
}

generator client {
  provider               = "prisma-client-py"
  partial_type_generator = "partials.py"
  output                 = "my_prisma"
}

model User {
  id Int @id
  name String
}

partials.py
from my_prisma.models import User

User.create_partial("UserOnlyName", include={"name"})

prisma generate

no UserOnlyName generated.

May i know the timing of triggering the prisma generate partial types?

I think i know the reason.
because the prisma i use in command line tool share different context with model i import.
model i import path is
<custom path>/models
but the prisma path is
<project_root>/.venv/lib/python3.11/site-packages/prisma
so the partial_models_ctx is not the same context
https://github.com/RobertCraigie/prisma-client-py/blob/main/src/prisma/generator/generator.py#L255

Is there a workaround for this issue? Currently on 0.12.0 when I specify an output and a type generator, I get an import error about a partially initialized module:
# schema.prisma
generator py_client {
  provider               = "prisma-client-py"
  previewFeatures        = ["multiSchema", "postgresqlExtensions"]
  output                 = "../components/foo/prisma_client"
  partial_type_generator = "prisma/prisma_partials.py"
  recursive_type_depth   = "5"
}

Prisma schema loaded from prisma/schema.prisma
Error:
An exception ocurred while running the partial type generator
Traceback (most recent call last):
  File "/home/vscode/.cache/pypoetry/virtualenvs/R7CnQsZq-py3.10/lib/python3.10/site-packages/prisma/generator/models.py", line 312, in run
    loader.exec_module(mod)
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/workspaces/foo-asset/prisma/prisma_partials.py", line 2, in <module>
    from foo.prisma_client import models
  File "/workspaces/foo-asset/components/foo/prisma_client/__init__.py", line 26, in <module>
    from . import (
ImportError: cannot import name 'partials' from partially initialized module 'foo.prisma_client' (most likely due to a circular import) (/workspaces/foo-asset/components/foo/prisma_client/__init__.py)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/vscode/.cache/pypoetry/virtualenvs/R7CnQsZq-py3.10/lib/python3.10/site-packages/prisma/generator/generator.py", line 108, in run
    self._on_request(request)
  File "/home/vscode/.cache/pypoetry/virtualenvs/R7CnQsZq-py3.10/lib/python3.10/site-packages/prisma/generator/generator.py", line 161, in _on_request
    self.generate(data)
  File "/home/vscode/.cache/pypoetry/virtualenvs/R7CnQsZq-py3.10/lib/python3.10/site-packages/prisma/generator/generator.py", line 253, in generate
    config.partial_type_generator.run()
  File "/home/vscode/.cache/pypoetry/virtualenvs/R7CnQsZq-py3.10/lib/python3.10/site-packages/prisma/generator/models.py", line 314, in run
    raise PartialTypeGeneratorError() from exc
prisma.generator.errors.PartialTypeGeneratorError

This error is happening (I think) because the partials file doesn't exist when the partial generator runs. The partial generator tries to import the models from the generated client folder, which causes the client's init.py to run, which contains this line:
    from . import (
        models as models,
        partials as partials,
        types as types,
        bases as bases,
    )

I really don't understand how this import works, but performing a similar import in a test package with a missing file produces the same partial initialization error.
I don't understand why the import works when generating the client to site-packages. I thought maybe due to module caching, but how would the import of the cli import worked if partials.py did not exist?

I was able to work around the issues, demonstrated in this repo. The two changes I had to make to get this working:

The partials.py file needs to exist in order for the partial generator to import the partially-generated client package. This is because when the partial generator executes, the client and fields modules have been generated, but not the partials module (ref). from . import x produces an ImportError, not a ModuleNotFoundError as produced by a missing from .client import *, so the catch block doesn't handle this case.
The client package has its own copy of partial_models_ctx and generates partials to that, so the site-packages prisma generator needs to pull from the same one. From within the partial generator, we can patch the context on the models module so they are generated to the correct location.

Is there a particular reason why the package is copied into the external dir before generating the templates? It seems like it could work just to copy it after generating the templates, so that the partial generator can from prisma import models. This would have it use the correct models context and avoid loading the init file again, since it would have been loaded before running the generator.

We affected by the same problem, I think the root cause is we should also catch ImportError, then check if it is the partials missing and ignore it.


ZIP-321 Payment URIs and deeplinking

This Research Spike is about finding how well deep links / universal links work with Zcash Payment URIs defined in https://zips.z.cash/zip-0321
This is a duplicate of the iOS ticket for Android.

Closing this as a duplicate of #202.


Update README.md to be more gender inclusive

Nice project and generally nice attitude in the README! And I realize the main author is a woman, and it's easy to make mistakes with these things (I have). But it's good to avoid little micro expressions that encourage only 'fellas'.

Pull Request Test Coverage Report for Build 24

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 23:
0.0%

Covered Lines:
1599

Relevant Lines:
1599

💛  - Coveralls

Amended the commit message and merged to master as commit cebbf522931fd6cbdf826a3733af3de36b20574b.


[gyb] Force UTF-8 encoding when parsing templates on Linux

Python 3 on Linux reads the system locale information to determine what it should use as the default encoding for strings read from files (this is different from OS X which is always UTF-8 by default).
Since all the Swift gyb templates are UTF-8 encoded there is effectively no reason to parse them as anything else. This patch forces the gyb template parser to read the template using UTF-8 encoding. It accounts for both reading and writing to a file as well as reading from stdin and writing to stdout.
Two changes of note are that it now includes a __future__ import that should make Python 2 behave a little closer to Python 3 in terms of unicode support. Additionally Python 2 can no longer use cStringIO because it does not support unicode.

Unlike the StringIO module, this module is not able to accept Unicode strings that cannot be encoded as plain ASCII strings.

Test
To test this patch I ran these commands before and after the patch.
Note: that before the patch if the locale was set to something other than UTF-8, ASCII for instance, the Python 3 runs would fail. See comment on mailing list for example failure message.
Test file input and output
$ python2 utils/gyb -o Arrays.2.7.swift stdlib/public/core/Arrays.swift.gyb
$ python3 utils/gyb -o Arrays.3.5.swift stdlib/public/core/Arrays.swift.gyb
$ diff -u Arrays.2.7.swift Arrays.3.5.swift

Test stdin and stdout
$ cat stdlib/public/core/Arrays.swift.gyb | python2 utils/gyb > Arrays.2.7.stdin.stdout.swift
$ cat stdlib/public/core/Arrays.swift.gyb | python3 utils/gyb > Arrays.3.5.stdin.stdout.swift
$ diff -u Arrays.2.7.stdin.stdout.swift Arrays.35.stdin.stdout.swift

I can confirm this fixes the issue I had with gyb when building on Arch. I have not tested other systems.

@RLovelett I'm sorry, I reverted this PR because it caused failures on OS X:
TEST 'Swift :: Prototypes/Integers.swift.gyb' FAILED
Traceback (most recent call last):
  File "<src>/swift/test/Prototypes/../../utils/gyb", line 3, in <module>
    gyb.main()
  File "<src>/swift/utils/gyb.py", line 1073, in main
    open(args.target, 'w+', encoding='utf-8').write(executeTemplate(ast, args.line_directive, **bindings))
  File "<src>/swift/utils/gyb.py", line 976, in executeTemplate
    ast.execute(executionContext)
  File "<src>/swift/utils/gyb.py", line 593, in execute
    x.execute(context)
  File "<src>/swift/utils/gyb.py", line 669, in execute
    result = eval(self.code, context.localBindings)
  File "<src>/swift/test/Prototypes/Integers.swift.gyb", line 425, in <module>
    @warn_unused_result
  File "<src>/swift/utils/gyb.py", line 593, in execute
    x.execute(context)
  File "<src>/swift/utils/gyb.py", line 669, in execute
    result = eval(self.code, context.localBindings)
  File "<src>/swift/test/Prototypes/Integers.swift.gyb", line 1, in <module>
    //===--- Integers.swift.gyb -----------------------------------------------===//
TypeError: character mapping must return integer, None or unicode

and
TEST 'Swift :: stdlib/UnicodeTrieGenerator.gyb' FAILED
-parse-stdlibTraceback (most recent call last):
FileCheck error: '-' is empty.
  File "<src>/swift/validation-test/stdlib/../../utils/gyb", line 3, in <module>
    gyb.main()
  File "<src>/swift/utils/gyb.py", line 1073, in main
    open(args.target, 'w+', encoding='utf-8').write(executeTemplate(ast, args.line_directive, **bindings))
IOError: File or stream is not seekable.

Could you take a look at these and resubmit a fixed PR?

Yes I'll get that sorted out. Sorry about that.


Replace ValidationError with SuspiciousOperation in views

Description
Nothing catches the ValidationError, causing a 500 error to be given. SuspiciousOperation is caught by Django and a HTTP 400 response is returned to the client.
Motivation and Context
Fixes #243
How Has This Been Tested?
Tests added for the various places where the Wizard view is used. Build passed on travis: https://travis-ci.org/moggers87/django-two-factor-auth/builds/338217926
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

It might be worth waiting to see what upstream has to say about the same issue in django-formtools: https://github.com/django/django-formtools/pull/119

The current implementation is a copy-paste from upstream, with certain modifications to make the form wizard idempotent. Ideally I'd like to stay as close to the upstream code as possible to keep maintaining our patches low.
In #243 you also specified the problems the behaviour of throwing a ValidationError is causing you. You said that if the field is missing, due to the throwing of the ValidationError, this results in a 500 error. Is this not the case when a SuspiciousOperation is thrown?
Is there a way for this package to catch the ValidationError and show some error message instead? Can we put a try-except somewhere?

An alternative approach would be to not raise a validation error at all and do return self.render(form). Something (the management form?) would have to added to the template context as well to display an error message.
I don't like that idea for two reasons:

Nothing will get logged (currently it's an error to django.request, this PR would change that to it being logged to django.security)
It changes what the user sees from "something went wrong and I can't fix it" to "something went wrong and it's saying I need to fix it but I don't see how"

Assuming the developer made a mistake in their custom template rather than actual user tampering

My goal with this PR was only to change what the site admin sees (a code error vs. a client not sending all the required data for some reason) and not to change what the user sees.

In #243 you also specified the problems the behaviour of throwing a ValidationError is causing you. You said that if the field is missing, due to the throwing of the ValidationError, this results in a 500 error. Is this not the case when a SuspiciousOperation is thrown?

SuspiciousOperation results in a 400 response. not a 500. IIRC this still sends an email to admins, but it points more clearly to an error from data being sent from the client rather than the view code.

This has been merged upstream: https://github.com/django/django-formtools/pull/119
I've also rebased this branch on latest master.

I think it would be good to mention this in the change log. Can you add a mention of this change?

And thanks for the PR!


chore(release): bump version to v0.22.15 and update changelog

Issue being fixed or feature implemented

Release new version v0.22.15
What was done?

Updated versions of the platform packages
Updated changelog

How Has This Been Tested?

None
Breaking Changes

None
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone

We had to merge #514 first. Please recreate.


Airion/weston 8

Changes for using wayland-ivi-extension with Weston 8

Cherry-pick: 5e6f2e617035421420761875c8314b61dc7636ab, 94be9f71f5f70eebd727afcb165c338f48e41edf, acc9251a065638a7ff8ec87c7a5d3606f8c827f3, c34806efbe6bb27a2e0730a83325f4f20939e5de to #141
The 808fcbe082b94d45f2046087e0b0be9fa7802f4c and a6456f8e7d479421bf30eaa15a2f728a3a8c191b available on master branch
The b1e51e46bb5d99339c270902acd7afba1c8ae97a: should not include the "libweston-8" path on the header
The 05b9c68a4c41a2e222140fbd4959537c8210d35a: uint is fine, but need consider
Review-by: Tran Ba<EMAIL_ADDRESS>

most of the content is already included in the repository
the (https://github.com/COVESA/wayland-ivi-extension/commit/05b9c68a4c41a2e222140fbd4959537c8210d35a) will be considered by a different PR where also other places in the code will be corrected


Inconsistent 15-5s VOC results with the reported ones

Hi, I am trying to reproduce the 15-5s results with the voc dataset. However, the results (see the table below) I got are significantly (5 points) higher than those reported in your paper.

step
mIoU
background
aeroplane
bicycle
bird
boat
bottle
bus
car
cat
chair
cow
diningtable
dog
horse
motorbike
person
pottedplant
sheep
sofa
train
tvmonitor
base
novel

0
80.37%
94.36%
90.62%
41.06%
89.66%
70.50%
82.79%
94.69%
89.50%
93.99%
47.16%
86.11%
54.31%
90.43%
87.54%
86.42%
86.84%

80.37%

1
74.93%
92.30%
89.18%
40.96%
85.45%
70.35%
79.40%
93.12%
86.16%
91.80%
44.55%
84.41%
52.69%
89.12%
82.97%
83.02%
84.83%
23.53%

78.14%
23.53%

2
58.70%
90.79%
63.33%
33.44%
73.98%
56.07%
77.29%
76.04%
75.58%
79.69%
11.87%
35.73%
37.31%
80.49%
62.46%
78.60%
82.57%
15.51%
25.89%

63.45%
20.70%

3
55.12%
84.07%
61.58%
35.32%
66.56%
45.26%
68.80%
75.12%
74.11%
81.62%
14.12%
47.14%
47.08%
83.13%
70.48%
62.91%
83.62%
3.38%
27.31%
15.69%

62.56%
15.46%

4
39.80%
84.85%
29.00%
26.06%
51.45%
28.52%
57.93%
50.61%
58.18%
62.76%
2.69%
34.24%
22.81%
66.81%
53.43%
29.02%
78.51%
0.40%
23.19%
13.31%
22.23%

46.05%
14.78%

5
34.29%
83.12%
22.23%
14.02%
40.29%
21.00%
53.62%
10.21%
37.06%
72.87%
0.74%
31.99%
34.20%
72.61%
52.94%
18.75%
76.92%
0.08%
28.18%
12.10%
16.76%
20.31%
40.16%
15.49%

For your reference, I run step 0 and step [1-5] with the commands below.
step 0
CUDA_VISIBLE_DEVICES=1,2,3 python -m torch.distributed.launch --nproc_per_node=3 run.py
                --data_root path/to/data --method MiB --dataset voc --task 15-5s
                --step 0 --overlap --lr 0.01 --batch_size 8 --epochs 30 --name MiB

step 1-5
for step in {1..5};
do
CUDA_VISIBLE_DEVICES=1,2,3 python -m torch.distributed.launch --nproc_per_node=3 run.py
                --data_root path/to/data --method MiB --dataset voc --task 15-5s
                --step ${step} --overlap --lr 0.001 --batch_size 8 --epochs 30 --name MiB
done

Note that I do no modifications to your codes. Hope that you can help to see if my results are correct.

I notice that you report the old class and all class mIoU excluding the background class. I rerun the experiment and obtain the results below using your report protocol on 15-5s setting, though a bit higher than your reported numbers for the old classes. I run with pytorch 1.10.2.

1-15
16-20
all

Report
35.1
13.5
29.7

Reproduce
38.0
13.9
32.0

Thank you for your comments! Actually, 1-15 indicates that I'm not using the background for the IoU (since it's neither an old nor a new class).


Different step sizes within batch?

Dear @patrick-kidger
Is there any way that diffrax would support using different timesteps within a batch, like https://github.com/martenlienen/torchode offers?
For context:  I need to evaluate a 1-dimensional ODE on a fixed time grid but with 1000,000 different parameters, while using a Sequential Monte Carlo sampler on a ODE-based likelihood.
The best way I've found with diffrax to parallelize those calls to the ODE is to make this a single 100,000-dimensional ODE, where each dimension y[i] corresponds to one value of the parameters and for each dimension i,  dydt[i] only relying on y[i] (if it were linear we'd say it's a diagonal matrix, but it's nonlinear :) ).
But of course some parameters make for a more difficult ODE than others (sometimes even NaN-ning), and this thus impacts the step-size for all dimensions, making it slower and less stable.
Maybe I could just use https://github.com/martenlienen/torchode , which is in the Torch ecosystem, with  would seem to promise the solution, but it's in the torch ecosystem, and my sampler is in Jax. Maybe I could mix and match, though?
Thanks for letting me know if this heteregoneous-timesteps-within-a-batch is possible, and if not, if it's on the roadmap at all!

Indeed Diffrax supports this already via vmap :)

Wowser, this is terrific. Can't believe how simple it is, yet it works :) Thanks a lot!