Insiders: "Cannot read property 'adapter' of undefined"

In the current insiders, when I run a debug session I see this:
  ERR Cannot read property 'adapter' of undefined: TypeError: Cannot read property 'adapter' of undefined
	at e._withAdapter (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:548:1001)
	at e.$provideCodeActions (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:553:816)
	at t._doInvokeHandler (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:637:547)
	at t._invokeHandler (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:637:219)
	at t._receiveRequest (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:635:801)
	at t._receiveOneMessage (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:634:790)
	at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:632:675
	at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:38:994
	at e.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:44:76)
	at a (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:168:881)
	at Socket.f._socketDataListener (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:169:95)
	at Socket.emit (events.js:182:13)
	at addChunk (_stream_readable.js:279:12)
	at readableAddChunk (_stream_readable.js:264:11)
	at Socket.Readable.push (_stream_readable.js:219:10)
	at Pipe.onread (net.js:636:20)

This doesn't happen in stable. I'm running a Dart debug session, though I don't know if matters (the stack doesn't look like it's the extension code, but the stack traces are often misleading).

@jrieken Can you verify?

This error still exists in 1.31.1 (Stable).
I got it today and I don't know if it's related but one of my file syntax colorings is broken.
Broken coloring

I'm using Default Dark+ theme.

Log (Window)
[2019-02-14 09:57:03.218] [renderer1] [error] Cannot read property 'adapter' of undefined: TypeError: Cannot read property 'adapter' of undefined
	at e._withAdapter (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:553:140)
	at e.$provideHover (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:556:796)
	at t._doInvokeHandler (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:644:118)
	at t._invokeHandler (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:643:744)
	at t._receiveRequest (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:642:256)
	at t._receiveOneMessage (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:641:155)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:638:960
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:38:994
	at e.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44:113)
	at a (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:170:213)
	at Socket.f._socketDataListener (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:170:434)
	at Socket.emit (events.js:182:13)
	at addChunk (_stream_readable.js:279:12)
	at readableAddChunk (_stream_readable.js:264:11)
	at Socket.Readable.push (_stream_readable.js:219:10)
	at Pipe.onread (net.js:636:20)
[2019-02-14 13:46:06.244] [renderer1] [error] An unknown error occurred. Please consult the log for more details.

Log (Extension Host)
[2019-02-14 13:46:06.242] [exthost] [error] [vscode.typescript-language-features] provider FAILED
[2019-02-14 13:46:06.242] [exthost] [error] {"label":"Acquiring typings...","detail":"Acquiring typings definitions for IntelliSense."}

Toggle Developer Tools (Warnings)
[Extension Host] INVALID text edit -> must have at least a label

[e2e] potential listener LEAK detected, having 175 listeners already. MOST frequent listener (1):

 at s (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1874:428)
    at Object.t.attachBadgeStyler (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1874:713)
    at e.renderTemplate (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5255:459)
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:874:798
    at Array.map (<anonymous>)
    at e.renderTemplate (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:874:773)
    at e.alloc (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:177:207)
    at e.insertItemInDOM (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:428:686)
    at e.render (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:427:854)
    at e.onScroll (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:434:185)
    at e.fire (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:81:332)
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:404:911
    at e.fire (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:81:312)
    at t._setState (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:212:817)
    at t.setScrollDimensions (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:210:923)
    at t.setScrollDimensions (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:407:198)
    at e.layout (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:427:294)
    at i.e.layout (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:884:135)
    at t.layoutBody (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5266:492)
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5264:75
    at e.fire (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:81:312)
    at t.layout (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:949:145)
    at t.layoutBody (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5266:396)
    at t.e.layout (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:492:340)
    at Object.layout (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:445:146)
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:453:153
    at Array.forEach (<anonymous>)
    at t.layoutViews (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:453:124)
    at t.relayout (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:447:520)
    at t.addView (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:446:268)
    at t.addPanel (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:496:263)
    at t.addPanel (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:4995:747)
    at t.addPanels (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:4994:940)
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5275:313
    at Array.forEach (<anonymous>)
    at t.onSelectionChange (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5275:291)
    at e.fire (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:81:332)
    at t.onListSelectionChange (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5254:372)
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:75:996
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:83:744
    at e.fire (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:81:312)
    at e.set (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:860:131)
    at i.e.setSelection (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:884:316)
    at t.restoreSelection (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5254:624)
    at t.onListSelectionChange (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5254:271)
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:75:996
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:83:730
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:83:899
    at Array.forEach (<anonymous>)
    at e.bufferEvents (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:83:872)
    at i.e.splice (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:883:42)
    at t.splice (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5253:238)
    at t.onDidChangeVisibility (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5253:6)
    at e.fire (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:81:332)
    at t.setVisible (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2668:974)
    at t.setVisible (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5273:145)
    at o.t.showComposite (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5329:967)
    at o.t.doOpenComposite (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5327:626)
    at o.t.openComposite (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5327:123)
    at o.doOpenViewlet (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5393:335)
    at o.openViewlet (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5392:657)
    at t.run (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:4988:80)
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2587:698
e.check @ /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:79
/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1536   ERR An unknown error occurred. Please consult the log for more details.

/cc @roblourens @mjbvz @weinand @jrieken @aeschli

That's a different stack (provideHover vs provideCodeActions) but related. You could open a new issue for colorization.

@roblourens Okay, thanks, already opened a issue: https://github.com/Microsoft/vscode/issues/68764

Saw this in documentSymbols just now. I've opened https://github.com/Microsoft/vscode/issues/69147. This time it's certainly what @jrieken suggested:

This could happen when registering and unregistering a provider without us knowing, e.g. while a request is active. Could that be?

I had just changed the Dart SDK path, which results in us disposing and re-creating the providers that have references to the language server (which changes with the SDK).


Resolve remaining bug-interactions of multivariate module with update/predict and pred_int interfaces

Testing with concrete multivariate forecasters highlighted some interactions of the multivariate interface with update/predict and the prediction intervals interface:

[ ] test_predict_pred_interval - needs to be turned off if forecaster produces no predction intervals. There should probably be a tag for this rather than turning them off manually for individual estimators. Addressed in PR #1195 which introduces the tag, and tests for either error raised, or correct return of pred intervals, depending on tag value.
[ ] test_update_predict_predicted index - in update_predict, formatting of the multi-cutoff thing is not implemented for data frame returns (or numpy) and will break in that case
[ ] check_update_predict_predicted_index does not just check index, but also checks that data frames have 2 columns or more (which is off-topic), so this needs to be removed and possibly replaced by output tests. #1193

This was found by testing @GuzalBulatova's new multivariate column forecaster with the new framework.

No.2 is related to #984 - there are some methods in the base class which are imo unnecessary
Temporary workaround is to turn off prediction intervals using the new tag in #1195 for multivariate forecasters.

This is closed by #1193, #1195 and #1213, correct?

Yes, I think so, thanks for following up on this.


Validation issue

Hi There!
Library works great but I found a couple of troubles related to the query_string value.
If you send a number over the limit like for example (?page=99) your library show no message or have a routine to send it to the first page.
Also if you put manually a string like for example (?page=x) will show you an error because the query can't be executed.
Cheers!

Hi @satrianivzla,
Thank you for reporting these issues
For the first case, when you set a number over limit like (?page=99) I think it's the normal behavior to show nothing, as the result will be an empty array!
For the second issue (?page=x), I fixed this, now if you put any string it will fall-back to the first page
Also there was some other bug fixes and we extended the library to support custom queries (see the readme page), so I would suggest you to download the new lib file and use that instead.
Let me know if my answer was sufficient, or you see a better solution?
Regards!

Hi there
Well if you check another pagination class you will find a small piece of code like this one to fix the 1st issue
$variable    = $ci->input->get('page', TRUE);
$total_pages = (int) ceil($config['total_rows'] /   $config['per_page']  );
if ( $variable   >  $total_pages ) {
// for example redirect to the same controller
}
I will check the updated library!

Another thing to fix is that $config['total_rows']  can't be 0
if ( $config['total_rows']  == 0  ) {
// for example redirect to another controller
}

@satrianivzla Thank you for your suggestions, if you download the new code now, and put a page=9999 or something big, it will redirect back to the url (without page=...) which generally fall back to the very first page. The checking is done via the method prevent_unexisting_page which you can check in the source code.
For your second comment about $config['total_rows'] can't be 0 while I tested the total_rows to be 0 I can't see any error with that! can you confirm this?


Add cake-contrib user on NuGet.org

First of all, I wanted to thank you for adding to the Cake community by adding this addin.
I was just wondering if you had seen this blog post:
http://cakebuild.net/blog/2016/08/cake-contribution-organization
We are currently going through a process of increasing the visibility of addins, and also trying to ensure their long term maintainability.
To that end, we are asking addin creators to add the cake-contrib user on NuGet as a co-owner (this can be done through the NuGet website by clicking on Manage Owners on the package page).
Would you be interested in doing this for Cake.AWS.CodeDeploy? If you have any questions about this, please let me know. There was some initial concern that the Cake Team were trying to "take over" packages, and that couldn't be further from the truth, and if you have this concern, or others, I would like to address them.
Thanks!

@SharpeRAD just wanted to follow up to see if you had had a chance to give this some thought.  Thanks!

@SharpeRAD just wanted to touch base with this again.  Thanks!

Done 👍

Thank you! 😄


drivers: spi_sifive: Optimize xfer to minimize downtime between frames.

The SPI peripheral on SiFive parts uses FIFOs for Rx and Tx (FIFO size
undocumented, but empirically found to be 8 bytes on FE310, likely
identical on FU540 / FU740). Make use of these FIFOs in order to
continuiously feed Tx data as available.
Verified to transmit 1 MHz SPI @ 200 MHz coreclk / tlclk on FE310
continuously without downtime between frames.
Signed-off-by: Shawn Nematbakhsh<EMAIL_ADDRESS>

@tbursztyka, @henrikbrixandersen and @anangl I know this is not a platform you use, but I thought that, as a general SPI optimization maybe you'd be able to take a look


Add Eq instance for Src

It is convenient to check equality of Expr Src X sometimes.

Oops!  Thanks for catching that.  Yeah, I agree that Expr Src X should be comparable


Description label is being cut off when run on a physical device

When I am running the project on the simulator, everything works fine, but when run on a physical device, my description label label is only one line with the rest truncated ("example tex..."). Any ideas why?
Also any insight on setting constraints for a button? doing so makes the button either dissappear or show at an unwanted location.
Thanks!!

@eash4 Hey, just checked on device and for me there is no truncation problem. Please be sure that you do not change default setting for description label. By default description label has numberOfLines = 0 so it should support multiline mode, but you can change this with delegate method
func onboardingConfigurationItem(_ item: OnboardingContentViewItem, index: Int)
About second question. We do not support this feature, you can only adjust bottom offset by changing pageViewBottomConstant


Unable to use the restore procedure with the latest commandexecute stored proc by Ola

hi Sir,
I am trying to use this stored procedure for restore for ola backups but it throws the below error
Msg 201, Level 16, State 4, Procedure CommandExecute, Line 0 [Batch Start Line 0]
Procedure or function 'CommandExecute' expects parameter '@DatabaseContext', which was not supplied.
Could you please advise
thanks

I am using BrentOzar Stored procedure for restore and am unable to proceed as it throws the below error.
Msg 201, Level 16, State 4, Procedure CommandExecute, Line 0 [Batch Start Line 0]
Procedure or function 'CommandExecute' expects parameter '@DatabaseContext', which was not supplied.
Please kindly help sir

you need to update your version of brent's sp_databaserestore procedure. the older versions didn't supply this parameter. the newest version does.

Comman

you can update commandExecute to use @DatabaseContext ='master' as default, that will bypass your issue, had the same few days ago.


[Question] Authentication through bot framework

How to do authentication through Microsoft bot framework.Could please provide some samples too.

@RaoVenka are you using .NET or Node SDK?

You might want to start by watching this video: https://channel9.msdn.com/Shows/Office-Dev-Show/Office-Dev-Show-Episode-34-Getting-Started-with-Bots-and-the-Microsoft-Graph
Next, you can study this code example which demonstrates a Bot Framework integration with Active Directory. https://github.com/MicrosoftDX/AuthBot
You might also consider looking at the Sign-in Card example, which can also be used to authenticate your bot via web sign-in.
Docs:

https://docs.microsoft.com/en-us/bot-framework/dotnet/bot-builder-dotnet-add-rich-card-attachments#add-a-sign-in-card-to-a-message

Code example:

https://github.com/Microsoft/BotBuilder-Samples/tree/master/CSharp/cards-RichCards


upgrade alembic error

When running:
alembic upgrade head
in my ubuntu console.
I got this error:
Traceback (most recent call last):
File "/usr/bin/alembic", line 11, in
load_entry_point('alembic==1.1.0.dev0', 'console_scripts', 'alembic')()
File "/usr/lib/python3/dist-packages/alembic/config.py", line 540, in main
CommandLine(prog=prog).main(argv=argv)
File "/usr/lib/python3/dist-packages/alembic/config.py", line 534, in main
self.run_cmd(cfg, options)
File "/usr/lib/python3/dist-packages/alembic/config.py", line 511, in run_cmd
fn(
File "/usr/lib/python3/dist-packages/alembic/command.py", line 279, in upgrade
script.run_env()
File "/usr/lib/python3/dist-packages/alembic/script/base.py", line 475, in run_env
util.load_python_file(self.dir, "env.py")
File "/usr/lib/python3/dist-packages/alembic/util/pyfiles.py", line 98, in load_python_file
module = load_module_py(module_id, path)
File "/usr/lib/python3/dist-packages/alembic/util/compat.py", line 174, in load_module_py
spec.loader.exec_module(module)
File "", line 783, in exec_module
File "", line 219, in _call_with_frames_removed
File "app/alembic/env.py", line 8, in
from app.db.models import Base
ModuleNotFoundError: No module named 'app'
I don't change my Dockerfile.
My docker file is:
FROM python:3.8
RUN mkdir app
WORKDIR app/
RUN apt update &&
apt install -y postgresql-client
COPY requirements.txt ./
RUN pip install --no-cache-dir -r requirements.txt
COPY . .

You need to run it inside of the Docker image, where alembic and your project dependencies are installed.  From the project README:
docker-compose run --rm backend alembic upgrade head

It is possible to run without docker, but you need to set vscode / pucharm to run python with PYTHONPATH=.


Remove title from non-date elements

Checklist

[x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[x] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
[x] The description lists all applicable issues this PR seeks to resolve
[x] The description lists any configuration setting(s) that differ from the default settings
[x] All tests and CI builds passing

Description
This is a mini PR to fix an issue with the title overlapping the feed transformation summary.

Codecov Report

Merging #594 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #594   +/-   ##
=======================================
  Coverage   15.66%   15.66%
=======================================
  Files         323      323
  Lines       16436    16436
  Branches     4994     4994
=======================================
  Hits         2574     2574
  Misses      11840    11840
  Partials     2022     2022

Flag
Coverage Δ

#unit_tests
15.66% <ø> (ø)

Impacted Files
Coverage Δ

...ib/manager/components/version/FeedVersionReport.js
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3cf9eb...70d4310. Read the comment docs.


not working

game update?

I wonder the same thing!

I've just released v0.2.0 that works on the latest CS2


fix: landing hero section photo quality and placement

:tada: This PR is included in version 0.41.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


CocoaPods installed but not initialised

After running pod setup, flutter doctor still returned the following
dadas-Mac-mini:~ dada$ pod setup
dadas-Mac-mini:~ dada$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, v1.9.1+hotfix.2, on Mac OS X 10.14.6 18G95, locale
    en-AU)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[!] Xcode - develop for iOS and macOS (Xcode 11.0)
    ✗ CocoaPods installed but not initialized.
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To initialize CocoaPods, run:
        pod setup
      once to finalize CocoaPods' installation.
[✓] Android Studio (version 3.5)
[✓] Connected device (1 available)

! Doctor found issues in 1 category.

Please help, I only followed the instruction and know very little of each of the command.

It seems to be very similar to #41253. Please try to install lower cocoapods as advised in the issue body. Report please if that will help.

No the OP, but having the same issue.
Installing CoacoaPods 1.7.5 did the trick.
As per solution in #41253:
sudo gem uninstall cocoapods
sudo gem install cocoapods -v 1.7.5
pod setup

@yuesaka FWIW, I had the same issue and downgrading to 1.7.5 worked for me too.  Thanks for suggesting the workaround.

Worked great on macOS Catalina. Thank you for the fix @yuesaka

Duplicate of #41253

Many thanks to all, I followed @yuesaka's instruction and flutter doctor found no issue.

Closing this issue, as the solution was found.

See workaround

As per solution in #41253:
sudo gem uninstall cocoapods
sudo gem install cocoapods -v 1.7.5
pod setup
sudo gem install cocoapods      (if you want latest version)

Nice Thanks

Great, it worked! Thanks @yuesaka 🔥

I'd recommend avoiding to downgrade CocoaPods unless something is actually broken (other than the warning from flutter doctor).

I'd recommend avoiding to downgrade CocoaPods unless something is actually broken (other than the warning from flutter doctor).

I agree but it must be broken. I just had the same problem and 1.7.5 fixed it. The issue was that "pod setup" wouldn't do anything. After the downgrade "pod setup" now immediately starts "Setting up CocoaPods master repo" and it appears to be working now.

Same as MrSykes, downgrading to 1.7.5 did the trick.

I'm surprised this was closed. Whilst the workaround works, it means that cloud builds in Azure take over 7 minutes longer (since that's the cost of uninstalling the newer cocoapods and installing 1.7.5). Surely the actual solution is to ensure Flutter works with newer versions on cocoapods?

@kentcb this actually was fixed in https://github.com/flutter/flutter/pull/41491 and went to 1.10.7.
https://github.com/flutter/flutter/issues/41253#issuecomment-539124598

@BondarenkoStas Great to know - thanks! I'm on stable so can't take advantage of this just yet, but looking forward to it.

As per solution in #41253:
sudo gem uninstall cocoapods
sudo gem install cocoapods -v 1.7.5
pod setup
sudo gem install cocoapods (if you want latest version)

This is excellent reply

@phamquan the workaround isn't required any more because the fix has landed in stable. By removing the workaround my build time has dropped by nearly 8 minutes :tada:

@phamquan the workaround isn't required any more because the fix has landed in stable. By removing the workaround my build time has dropped by nearly 8 minutes 🎉

This is not true as of now. It does not work. Only with workaround.

@yuesaka Thanks, only your workaround works as of today on MacOS 10.13.6 High Sierra

****sudo  chmod -R 777 [your flutter file folder]
and run:
--  sudo gem uninstall cocoapods
--  sudo gem install cocoapods -v 1.7.5
--  pod setup

@yuesaka , your fix is legendary. Worked for everyone. Kudos

For some reason
-- sudo gem uninstall cocoapods
-- sudo gem install cocoapods -v 1.7.5
-- pod setup
installs cocoapods version 1.8.3. Does anyone have any idea why that might be?

No the OP, but having the same issue.
Installing CoacoaPods 1.7.5 did the trick.
As per solution in #41253:
sudo gem uninstall cocoapods
sudo gem install cocoapods -v 1.7.5
pod setup

Thank you. That worked for me.

I have tried everything mentioned above, and I'm still getting the following thing. I'm on Mac OS Catalina. Could someone help me here ? Thank you.
[!] Xcode - develop for iOS and macOS (Xcode 11.4.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.4.1, Build version 11E503a
✗ CocoaPods not installed.
CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
Without CocoaPods, plugins will not work on iOS or macOS.
For more info, see https://flutter.dev/platform-plugins
To install:
sudo gem install cocoapods


fix apiservice informer cache not synced

Signed-off-by: Di Xu<EMAIL_ADDRESS>
What type of PR is this?
kind/bug
What this PR does / why we need it:
Which issue(s) this PR fixes:

introduced by #378
Special notes for your reviewer:

Codecov Report

Merging #411 (2bf8a1c) into main (56ebf28) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   13.55%   13.54%   -0.01%
==========================================
  Files          60       60
  Lines        6573     6577       +4
==========================================
  Hits          891      891
- Misses       5613     5617       +4
  Partials       69       69

Impacted Files
Coverage Δ

...rc/github.com/clusternet/clusternet/pkg/hub/hub.go
2.78% <0.00%> (-0.04%)
:arrow_down:

...ernet/clusternet/pkg/hub/apiserver/shadow/utils.go
89.28% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56ebf28...2bf8a1c. Read the comment docs.


fix: add for-of and regenerator plugin-transforms to es5 plugins

should fix #60

Note: there are a couple options I didn't set:

for-of: https://babeljs.io/docs/en/babel-plugin-transform-for-of#options
regenerator: https://babeljs.io/docs/en/babel-plugin-transform-regenerator#usage

I guess we could enable loose for for-of as other transform already use loose mode too.


Respect TransactionOpts in cast call --trace

Component
Cast
Describe the feature you would like
Currently cast call has "Transaction options", which specifies options like gas limit, gas price, etc. However they are not used during simulation with --trace. This is a discussion whether they should also be used.
Additional context
No response

Implementing is easy, just modifying fields inside get_fork_material

Hi @publicqi , can i take this issue?. Thanks

Sure go ahead. Thanks

Thanks @zerosnacks


Provide feedback for the new Policy Template from Policy Hub

Description
As a Data Space Participant
I want to provide feedback to the Policy Hub team after testing the policy template feature made available by Policy Hub team
so that the Policy Hub team can analyse th efeedback and implement new suggestions
In Scope
Providing feedback to Policy Hub Team
Out of Scope
Anything else other than mentioned above

We have analysed and tested the Policy templates provided by the Policy Hub. There are a few topics we want to address and open a discussion about them.
Please find the observations/feedback in this file attachment.
Policy Template Hub deployed to dev.pdf


Fixes 404 Links (closes #653)

Replaces https://github.com/corona-warn-app/cwa-app-android/pull/677/files as we only want to cherry pick the 404 fixes.
Checklist

[x] Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
[ ] If this PR comes from a fork, please Allow edits from maintainers
[x] Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
[x] Link your Pull Request to an issue - Pull Requests that are not linked to an issue with you as an assignee will be closed, except for minor fixes for typos or grammar mistakes in documentation or code comments.
[ ] Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
[x] Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)
[x] Make sure that your PR does not contain changes in text files, therefore the PR must not contain changes in values/strings/* and / or assets/* (see issue #332 for further information)
[x] Make sure that your PR does not contain compiled sources (already set by the default .gitignore) and / or binary files

Description

Kudos to @pr1metine

About time 😅. I already gave up on this.


Usage in Angular.js

How can opn be used in an angular 5 component?

You can't. This module is for Node.js.


Test that distrusts on interfaces apply to implementing classes

https://github.com/mikesamuel/fences-maven-enforcer-rule/blob/master/src/test/java/com/google/security/fences/policy/PolicyApplicationOrderTest.java#L261


Submission is failing with a 422 status code

Describe the bug
The plugin fails to publish the code. See the steps below
To Reproduce
Steps to reproduce the behavior:

Go to https://leetcode.com/explore/interview/card/top-interview-questions-easy/127/strings/887/
Submit the code
The red tick appears.
Inspect in the network tab, you should see a 422.

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context

As per the rest doc of github, it seems the SHA is needed when uploading a file. In this case, the SHA is null.

Hello, has this issue been resolved? I have been facing the same issue for my past solutions as well :(


Nix lexer

Would be great to have Nix lexer. As NixOS and vis user I really miss it.
See https://github.com/martanne/vis/issues/880

Thanks for the suggestion!

Thanks for the suggestion!

I'm on it

This is done thanks to @samuelmarquis in #122. Thank you!


Ng Serve stops responding to file changes when editing ts/html files using Visual Studio 2022 (17.8.0)

Command
serve
Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
Angular 16
Description
Running Angular application using ng serve
When editing TS or HTML files using Visual Studio (v17.8.0) and saving,
the first change gets picked up and triggers a rebuild + reloading client(s).
All changes after that do not trigger a change.
Opening the same file in notepad++ and saving, does trigger a change.
Changes made in notepad++ do show in visual studio and vice versa
Minimal Reproduction

ng serve application
open component.html file and edit content (using visual studio)
save file
cli rebuilds application and browser refreshes
edit content of same component.html file and save file
cli does not respond to changes

Exception or Error
No response
Your Environment
Angular CLI: 17.0.2
Node: 20.9.0
Package Manager: npm 10.1.0
OS: win32 x64

Angular: 17.0.3
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.1700.2
@angular-devkit/build-angular     17.0.2
@angular-devkit/core              17.0.2
@angular-devkit/schematics        17.0.2
@angular/cdk                      17.0.0
@angular/cli                      17.0.2
@angular/flex-layout              15.0.0-beta.42
@angular/material                 17.0.0
@angular/material-luxon-adapter   17.0.0
@schematics/angular               17.0.2
rxjs                              7.8.1
typescript                        5.2.2
zone.js                           0.14.2

Anything else relevant?
Windows 11 Enterprise 22H2
Microsoft Visual Studio Enterprise 2022 (64-bit) - Current - Version 17.8.0

So this is a super weird one. Debugging with @clydin, we were able to reproduce and open Visual Studio and VSCode next to each other on the same project. We were actually able to get two changes rebuilt in Visual Studio before it stops rebuilding. However VSCode can continue to edit the same project and changes are immediately applied.
We also confirmed that Visual Studio was writing to the file system correctly and that the file is byte-for-byte identical between the two editors. We were suspecting this might be an encoding or line ending issue, but we can safely rule both of those out.
We found a couple references to the fact that Visual Studio is unique in that it doesn't modify files directly. Instead it writes them to a temporary directory and then moves them to the actual location. This can be observed as different file system events for file watchers and seems to be a common problem. This is likely the root cause of the problem, however exactly where the fix should be is still unclear.

https://github.com/dotnet/runtime/issues/17626
https://developercommunity.visualstudio.com/t/saving-changes-does-not-trigger-watchers-saving-sa/209768#T-N495571

We also tried enabling polling, but this didn't help. The only workaround which solved the issue was to watch the project root directory entirely. As to why this solves the problem, I'm not entirely sure. Doing it is also a performance regression for Windows users not on Visual Studio.
We tried ng serve --verbose which lists out the file modifications detected to see exactly what event the project root picks up that is getting missed. However we only see modifications to the app.component.html file, nothing else. So we don't understand why this event requires watching the project root at all.
WORKAROUND: You can force Angular CLI to watch the project root with the NG_BUILD_WATCH_ROOT environment variable.
For command prompt:
set NG_BUILD_WATCH_ROOT=1
ng serve

For PowerShell:
$env:NG_BUILD_WATCH_ROOT=1
ng serve

We'll need to do a little more investigation to figure out exactly what's going on here and what the proper fix is.

Can confirm on my end that adding the 'NG_BUILD_WATCH_ROOT=1' environment variable indeed works as a workaround.

Just published v17.0.3 which updates Angular CLI to watch the project root by default. That should hopefully work around the problem automatically without requiring the environment variable.
We'll still want to do some more investigation here to find a more permanent fix.

Hi @MichielNL83,
Would you mind to verify if applying the changes in https://github.com/angular/angular-cli/pull/26468 fixes the issue?
Steps to apply the update:

Update the file contents of<EMAIL_ADDRESS>with https://gist.github.com/alan-agius4/f9a9c0a52f1b6b53895d3617e515dd97
Update the file contents of<EMAIL_ADDRESS>with https://gist.github.com/alan-agius4/200fe02b59519a1bb0f5338fb8bcc225

@alan-agius4 ,
Yes, these changes fix the issue.

@MichielNL83, thanks for the checking and confirming that the proposed change fixes the issue for you. Much appreciated.


feature support watch event by key

when this's key value change , support notify key event

Thank you for your attention.
What is your scenario? Please give me more information to help me to implement this.
btw, are you planning to use it or just learn?

Thank you for your attention.
What is your scenario? Please give me more information to help me to implement this. btw, are you planning to use it or just learn?
@roseduan
I'm currently working on a persistent cache of a segment tree
Have Found a repository that provides a very lightweight implementation, but it lacks event support. In my business scenario, there are many keys, and when the value associated with a key is changed, I need an event to watch it, similar to an Event-Driven Architecture (EDA).

i want to try it out.

i want to try it out.

is there any new progress？

You didn't assign this issue to me, so I don't know that I can start this issue.

Would you like to accept this new feature? @Jeremy-Run

OK, assign to me, but it will take some time.

@roseduan OK, assign to me, but it will take some time.

OK, you can refer to the implementation in ETCD, I remember it has this feature.
And don`t rush to write the code, you can come up with a plan first, and we can discuss it.

@roseduan OK, assign to me, but it will take some time.

OK, you can refer to the implementation in ETCD, I remember it has this feature. And don`t rush to write the code, you can come up with a plan first, and we can discuss it.

This is my plan, what do you think?

When the DB is opened, add whether to enable the key change notification parameter and a cached channel (the channel is used for consumer consumption)
If the parameter is true, perform the following steps
Design a circular queue to cache data
When batch commit, write the change information into the ring queue
Start a goroutine to read and process the information in the ring queue and put it into the channel
When the writing speed is much higher than the reading speed and the ring queue is not enough, write the overflow part into a list, wait for the ring queue to be read, and then put the data in the list into the ring queue to continue processing.

In addition, there is no strong guarantee for notification information, that is, only the notification content is stored in memory, and there may be cases where notification information is lost.

@roseduan OK, assign to me, but it will take some time.

OK, you can refer to the implementation in ETCD, I remember it has this feature. And don`t rush to write the code, you can come up with a plan first, and we can discuss it.

This is my plan, what do you think?

When the DB is opened, add whether to enable the key change notification parameter and a cached channel (the channel is used for consumer consumption)
If the parameter is true, perform the following steps
Design a circular queue to cache data
When batch commit, write the change information into the ring queue
Start a goroutine to read and process the information in the ring queue and put it into the channel
When the writing speed is much higher than the reading speed and the ring queue is not enough, write the overflow part into a list, wait for the ring queue to be read, and then put the data in the list into the ring queue to continue processing.

In addition, there is no strong guarantee for notification information, that is, only the notification content is stored in memory, and there may be cases where notification information is lost.

we can implement it more straightforward, no need to add a list to store the overflow part.
we can create a fixed-size queue(the size can be an option), if the event is overflow, just remove the oldest data.

@roseduan OK, assign to me, but it will take some time.

OK, you can refer to the implementation in ETCD, I remember it has this feature. And don`t rush to write the code, you can come up with a plan first, and we can discuss it.

This is my plan, what do you think?

When the DB is opened, add whether to enable the key change notification parameter and a cached channel (the channel is used for consumer consumption)
If the parameter is true, perform the following steps
Design a circular queue to cache data
When batch commit, write the change information into the ring queue
Start a goroutine to read and process the information in the ring queue and put it into the channel
When the writing speed is much higher than the reading speed and the ring queue is not enough, write the overflow part into a list, wait for the ring queue to be read, and then put the data in the list into the ring queue to continue processing.

In addition, there is no strong guarantee for notification information, that is, only the notification content is stored in memory, and there may be cases where notification information is lost.

we can implement it more straightforward, no need to add a list to store the overflow part. we can create a fixed-size queue(the size can be an option), if the event is overflow, just remove the oldest data.

That only needs to circulate the queue, bypass the direct overwriting, and the read pointer points to the next one of some write pointers. However this has the potential to lose events while the DB is running.

Right, we can not store all events in memory, even the queue is huge enough, but the data may be more.
more events mean more memory cost, we can give the option to callers to create the fixed-size queue.

Right, we can not store all events in memory, even the queue is huge enough, but the data may be more. more events mean more memory cost, we can give the option to callers to create the fixed-size queue.

Okay, any other points to discuss? If not, I will develop it according to this idea.

Right, we can not store all events in memory, even the queue is huge enough, but the data may be more. more events mean more memory cost, we can give the option to callers to create the fixed-size queue.

Okay, any other points to discuss? If not, I will develop it according to this idea.

These are all my thoughts, thanks.

@Liberxue This new feature has merged into main branch, you can try it as you wish.


Pytorch profiling Error In Megatron-DeepSpeed/tasks/eval_harness/evaluate.py

I have error when use profile on evaluate.py(1 node 8 gpus) https://github.com/microsoft/Megatron-DeepSpeed/blob/main/tasks/eval_harness/evaluate.py .
from torch.profiler import profile, record_function, ProfilerActivity
def main():
    start = time.time()
    model = load_ds_checkpoint_and_setup_megatron(extra_args_provider=tasks_args)

    args = get_args()
    if args.deepspeed and args.adaptive_seq_len:
        # adaptive_seq_len hack #1:
        # CL automatically enables reset_activation_shape() which allows us to change input shapes
        # and it also reshapes the attenion scores in attention_mask_func
        args.curriculum_learning_legacy = 1

    task_list = ALL_TASKS if args.task_list == 'all' else args.task_list.split(',')
    task_dict = tasks.get_task_dict(task_list)

    model.module.activation_checkpoint_interval = 0
    model._compute_loss = False
    model.fwd_outputs = []

    tokenizer = get_tokenizer()
    adaptor = EvalHarnessAdaptor(model, tokenizer)
    with profile(activities=[
        ProfilerActivity.CPU, ProfilerActivity.CUDA], record_shapes=True) as prof:
        results = evaluator.evaluate(adaptor, task_dict, False, args.num_fewshot, None)
    prof.export_chrome_trace("trace.json")
    if mpu.is_pipeline_last_stage() and mpu.get_tensor_model_parallel_rank() == 0:
        print(json.dumps(results, indent=2))
        with open(args.results_path, 'w') as outfile:
            json.dump(results, outfile, indent = 4)
    end = time.time()
    print("evaluation of {} ends in {:.2f} sec, or {:.2f} min, or {:.2f} hr".format(args.task_list, end-start, (end-start)/60.0, (end-start)/3600.0))

But I get an error.
output_json.cpp:468 failed to rename trace.json.tmp to trace.json

How should I use pytorch.profile tools to fix this.
After the error, I get a file "trace.json" , but it can not be used in chrome://tracing/

Don't you think https://github.com/microsoft/Megatron-DeepSpeed/issues is better place for this issue?


🕊 Minor codebase updates and fixes

This issue is #5222
Continues from https://github.com/refined-github/refined-github/pull/4008
This issue is not for generic bug reports but to suggest changes/refactoring to the extension itself.

[ ] Automatically hide resolved comments on this issue and #4008

Both URLs can be hard-coded in the feature

Moved from https://github.com/refined-github/refined-github/pull/5213#pullrequestreview-833833784 https://github.com/refined-github/refined-github/issues/4008#issuecomment-812885528

[ ] Maybe rewrite most selector-observer usage to use deinit instead of onetime as described in https://github.com/sindresorhus/refined-github/pull/4072#issuecomment-792402458
[ ] add deinit to more features. Most delegate calls should result in a deinit on unload
[ ] Make init return a specific type called Deinit, like:
type Deinit = VoidFunction | {abort: VoidFunction} | AbortController, etc and then set the return value to Deinit | Deinit[]
this will let us return values easily without having to locate the abort function of each
[ ] Create a new abortSignal at every load and pass it to each init. This might be a little difficult to pass around at times, but it would be great to stop any async activity when unloading. For example addEventListener natively supports this signal so those features would not have to return anything:function init(signal: AbortSignal): void {
	document.body.addEventListener('click', doStuff, {signal})
}

This case isn't better though:function init(signal: AbortSignal): void {
	const listener = delegate(..etc);
	signal.addEventListener('abort', listener.disconnect);
}

so it should just return listener.disconnect instead, as it's already possiblefunction init(): Deinit {
	return delegate(..etc).disconnect;
}

[ ] Automatically hide resolved comments on this issue and #4008

Both URLs can be hard-coded in the feature

[ ] Clean up and rewrite SearchQuery so its side-effects are more contained

SearchQuery is a mess, sorry about that. We try to parse, clean and update elements on creation. That’s a lot of side effects for a class.
The idea was to make it easy to update existing links, but perhaps we should avoid changing the original link until .commit() or .updateOriginal() is called. Alternative suggestions welcome.
Originally posted by @fregante in https://github.com/refined-github/refined-github/pull/5194#discussion_r769995937

[ ] Add alt-click to Screenshot links in the options. Rarely useful, but useful to review them as suggested in https://github.com/refined-github/refined-github/issues/5222#issuecomment-996620545

[ ] Review some global CSS and especially github-bugs.css

Some of this code may be outdated. It may be as easy as:

Find page where code is meant to apply
Drop CSS rule
Do you see the bug the rule is meant to fix? Commit

Parse default branch, current committish and possibly other stuff from <ref-selector>
This element (actually, two) is available on isRepoTree.
Parsing info from it seems better than our current method(example).
Note there are some issues with GitHub's code:
// https://github.githubassets.com/assets/app/assets/modules/github/ref-selector.ts

connectedCallback() {
    this.refType = this.getRequiredAttr('type') === 'branch' ? RefType.Branch : RefType.Tag
    const currentCommittishAttr = this.getAttribute('current-committish')
    this.currentCommittish = currentCommittishAttr ? atob(currentCommittishAttr) : null // Just `atob`?
    this.input = (this.hasAttribute('initial-filter') && this.currentCommittish) || ''
    this.defaultBranch = atob(this.getRequiredAttr('default-branch')) // Same here
    this.nameWithOwner = atob(this.getRequiredAttr('name-with-owner'))
    this.canCreate = this.hasAttribute('can-create')
    this.prefetchOnMouseover = this.hasAttribute('prefetch-on-mouseover')
    const queryEndpoint = this.getRequiredAttr('query-endpoint')
    const cacheKey = this.getRequiredAttr('cache-key')
    this.index = new SearchIndex(this.refType, this, queryEndpoint, cacheKey, this.nameWithOwner)
    this.setupFetchListeners()
  }

As you can see they only use atob to decode the string while in fact it can contain any Unicode[^1], so remember to wrap decodeURIComponent(escape(string)) to get the correct result.
[^1]: some of our features are not Unicode-aware either

[ ] Make our bug-report URLs field smaller via CSS (also via hotfix)

It's probably something like:
#issue_form_example_urls, /* pre-click field */
#issue_form_example_urls + div textarea { /* also the WYSIWYG editor */
	min-height: 4em !important;
	height: 4em !plz;
}

The field is too big and I keep placing the description in it. We only need to be flexible in case we want to add multiple URLs.

[ ] Create reusable OptionsButton component
[ ] Make token notice in rgh-improve-new-issue-form less vague

Both described in https://github.com/refined-github/refined-github/pull/5457#pullrequestreview-910318623

[ ] move the tests out of test and next to the related helpers, where possible, e.g. test/github-url.ts -> source/github-helpers/github-url.test.ts

[ ] extracting the pluralize/loose-parse-int out of test/helpers.ts into their own files (because they're already standalone helpers files)

@fregante just a minor issue, could you replace the organization avatar with the transparent one? Organization avatars are shown in square and doesn't' look great with backgrounds.

It already is transparent

[ ] Use API fetch forks in forked-to

https://github.com/refined-github/refined-github/pull/5597#issuecomment-1099167371

Maybe add the "user can merge this PR" check used in wait-for-checks to more PR merging features, like sync-pr-commit-title:
https://github.com/refined-github/refined-github/blob/9690ceb6430bb239ab71207ffa00fb9bee4f0fc1/source/features/wait-for-checks.tsx#L190-L191

[ ] Move hotfixes to “live data” repo

We can do more than just disabling JS features and adding CSS. We could even have a way to change selectors on the fly in the future.

[ ] Add live data option in the repo; plus link and current status, e.g. “some CSS is being applied”. Disabled JS features already have UI for this.

[ ] Add rgh-quick-release feature to redirect “Create release” link to the relevant Actions page
[ ] Propose new RGH meta features or just send a PR for them if small enough 😃

[ ] Add these via rgh-improve-new-issue-form and drop them from 1_bug_report.yml

Not sure if it's worth it, but they're kinda noisy when looking at the issues, so it'd be great if they didn't appear there.
Alternatively we can just customize 1_bug_report.yml so that this text only appears there. We can still use the rgh-improve-new-issue-form to make them more prominent. Checkboxes aren't required.

Moved from #4008

[ ] Replace exclude: [isEmptyRepo] and related exclusions with a check in the try init() catch block in features/index.

Instead of having to explicitly specify these exclusions, RG should just understand that the current page is incomplete and ignore every error. Maybe it should just show once a log: “This page is incomplete. Some features have been disabled.”
The feature logger might also display a log with a 💢 emoji or similar.
Edit: Same goes for features that fail when you’re logged out.

[ ] Wrap the debugging section in a details and add a background, more buttons may be coming

https://github.com/refined-github/refined-github/issues/5760
https://github.com/fregante/webext-options-sync/issues/23)

[ ] Move https://github.com/refined-github/refined-github/blob/main/source/helpers/is-archived-repo.ts to https://github.com/refined-github/github-url-detection

[ ] Disable import/prefer-default-export in `source/features/

https://github.com/refined-github/refined-github/blob/99c4eba5677b4ec271c854addc920ca8f27cb39d/source/options-storage.ts#L56:L56

[ ] Fetch and immediately inject the hotfix CSS if available.

Unlike the regular “disabled features” hotfix, CSS hotfixes can be injected at any time, so we can use fetchCssHotfix().then(inject) instead of using a separate cache.get()
Side note: my Safari 22.7.1 regularly loads pages without hotfix. We really need staleWhileRevalidate here.

[ ] Drop getRghIssueUrl, it just saves a few characters but makes these URLs not clickable in the IDE and in the browser

[ ] Update https://github.com/refined-github/github-url-detection/issues/133

[ ] Use showToast in update-pr-from-base-branch

Any more features that show the status inline?

[ ] Replace all/most custom listeners like onFileLoad with the new selector observer as it's the most efficient, safe and easy to use solution

[ ]  replace most of its isRepo calls with hasRepoHeader

From: https://github.com/refined-github/github-url-detection/pull/131
Trying not to break https://github.com/refined-github/refined-github/issues/5739 again.

[ ] Add a workflow to lint other workflows https://github.com/rhysd/actionlint

Kind annoying that GitHub doesn't do this natively and it only complains when it actually runs the workflow (particularly a problem for the release workflow, which only runs on main)


[Feature Request]: offline support

When network connection is offline, RUM should cache events and dispatch them to the collector when the connection recovers.

One immediate issue is that RUM disables itself when the number of retries has been exhausted. This might be a bad assumption to make because the network connection might recover, and RUM will become needlessly disabled.

Please help to prioritize the fix where RUM disables itself when the number of retries has been exhausted due to network failure or other error codes like 401, 307 etc.  RUM should not disable in such scenario and should continue to emit metrics.

We do not want to remove this feature entirely because RUM should disable when we know that retries will never succeed, such as when credentials are invalid.
To solve the immediate problem, we can add configuration such as disableOnFailure: boolean. And we'd want to make sure that this config is extensible for when provide full offline support.

sure as an immediate solution the above config will work. Thanks.

I've merged in the feature to keep RUM alive when dispatch fails. To close out on this issue, we need to figure out an offline strategy that customers can opt into.

Offline support should be opt-in because web applications by default are not configured to work offline.
When offline, events should be written to the IndexDB API. LocalStorage is not a good solution because they only support strings, which is not a good solution for appending structured data. Putting events back into the event cache is also not good because that is stored in memory.
When RUM dispatches, it should send events stored in IndexDB and the event cache.

Open question:

When dispatch fails, what should happen to the payload? I recommend we put the events back in the offline cache so long as we did not receive a validation error (400).


HOTT-3165 Redefine max size of cookies to be lower

Jira link
HOTT-3165
What?
I have added/removed/altered:

[x] Redefine the max size of cookies to be a lower value

Why?
I am doing this because:

This works around a rails bug. Rails is computing the cookie size lower than browsers. This means rails thinks the cookie is valid but browsers are still rejecting them as being over 4kb
I think this is caused by rails computing the cookie size pre-encoding but browsers computing the size post encoding. This probably wasn't much of a problem with signed cookies because there weren't many non ASCII characters but with encrypted cookies the prevalance of characters requiring encoding greatly increases - and the greater the occurrance of these, the greater the skew in size calculation between server and client

Notes
This isn't a 'correct' fix - it attempts to offset for skew between server and client size calculations whilst also not wasting too much of the available cookie size but ultimately the level of skew is a result of the content being encoded, which itself is a product of how the original data is encrypted. So just offsetting may well be insufficient in some cases.
The correct fix is to improve rails' calculation but because the information require is not available with ActionDispatch::Cookies this isn't particularly easy to resolve.
Have you? (optional)

[ ] Reviewed view changes with stake holders
[ ] Validated mobile responsive behaviour of view changes

Deployment risks (optional)

Patches the max size rails allows for cookies

Holding off merging this for now because it breaks sessions for the user who is over the limit
Can get merged once #1446 has been deployed for a couple of weeks

Concluding this represents no value - the GCing of wizard sessions solves the problem better so closing


[Web Portal] Bundle shared modules into independence chunks.

Test case: enter the home page and then enter the job list page, this will cause the job list page to reuse some modules from the home page.

These test cases are run in different environments, please only refer the transfer size but not the time.

Before:

After:

For further optimization, adding backend pagination to the job list works well.

Coverage increased (+0.01%) to 53.854% when pulling 81506ca13298602f4330168421d05020a9b1a3fb on webportal/optimize-bundle into 0f1d8d2fe4d67694d5d5bb95aaabe59be07928c4 on master.


Separating Automatic Page Nesting & Routes

I haven't been able to find this, and sorry if I missed it. I think this is easier to explain with an example. This may be an issue with vue-router...or an option perhaps that I could configure in the nuxt router config.
I have a route /news with a collection of news items. Each news item will have the route /news/title-of-news-item, however this news item is not a nested page within the news page, but rather a new page in itself.
I have a solution so in server-side rendering the correct page is loading from an API and nested correctly. When I change page I think the application is looking for a parent/child to load the page into which doesn't exist.
Are there any examples of this by any chance?

This question is available on Nuxt.js community (#c6900)

Silly me! It isn't ideal but I can just make the page directory/file structure match for the route. I had everything setup as dynamic routes so I just needed to add a file like pages/news/_item.vue


Build Windows only for amd64

Skip with trying to build CSI binaries for Windows OS in non amd64 arch. Addresses https://github.com/kubernetes-csi/external-attacher/issues/185#issuecomment-538949667
This is just a short term fix. I think long term we should specify a matrix of supported OS/ARCH combos as is done in k/k

/release-note-none

/assign @msau42 @pohly @saad-ali

/lgtm
/approve


Poedit [3.3.2] startup crash on macOS High Sierra 10.13.6

Main problem
Crash on startup
Causes
Probably missing Swift libraries
Crash log
Process:               Poedit [64194]
Path:                  /Applications/Poedit.app/Contents/MacOS/Poedit
Identifier:            net.poedit.Poedit
Version:               3.3.2 (6726)
Code Type:             X86-64 (Native)
Responsible:           Poedit [64194]

Date/Time:             2023-08-04 17:48:53.572 -0300
OS Version:            Mac OS X 10.13.6 (17G14042)

Time Awake Since Boot: 110000 seconds
Time Since Wake:       17000 seconds

System Integrity Protection: enabled

Crashed Thread:        0

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Reason:    DYLD, [0x1] Library missing

Application Specific Information:
dyld: launch, loading dependent libraries

Dyld Error Message:
  Library not loaded: @rpath/libswiftCore.dylib
  Referenced from: /Applications/Poedit.app/Contents/MacOS/Poedit
  Reason: image not found

Binary Images:
       0x10a014000 -        0x10ad9bfef +net.poedit.Poedit (3.3.2 - 6726) <CC18F3F5-FF6E-3ACB-8467-B80D6F1D8D85> /Applications/Poedit.app/Contents/MacOS/Poedit
       0x10af8f000 -        0x10afd2ff7 +org.sparkle-project.Sparkle (1.22.0 - 1.22.0) <FE6CDCE9-E401-3469-BC9E-1322976E6FFB> /Applications/Poedit.app/Contents/Frameworks/Sparkle.framework/Versions/A/Sparkle
       0x11a737000 -        0x11a781adf  dyld (551.5) <CB9BFB56-4511-36F1-A546-891FF770C01C> /usr/lib/dyld
    0x7fff26b9a000 -     0x7fff279f8fff  com.apple.AppKit (6.9 - 1561.61.100) <4E6EA3FA-8C2C-3B21-BFF9-6F8C458B7BE1> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit
...

Fix attempt
Copy Swift libs from Xcode.app to Poedit.app
cp /Applications/Xcode.app/Contents/Frameworks/*swift* /Applications/Poedit.app/Contents/Frameworks

Attempting to fix the problem did not work
Fix attempt crash log
Crashed Thread:        0

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Reason:    DYLD, [0x4] Symbol missing

Application Specific Information:
dyld: launch, loading dependent libraries

Dyld Error Message:
  Symbol not found: _$sBOWV
  Referenced from: /Applications/Poedit.app/Contents/MacOS/Poedit
  Expected in: /Applications/Poedit.app/Contents/MacOS/../Frameworks/libswiftCore.dylib
 in /Applications/Poedit.app/Contents/MacOS/Poedit

Aditional info

POedit v3.2.2 is working properly.
Probably relevant links:

dyld: Library not loaded: @rpath/libswiftCore.dylib
dyld: Library not loaded: @rpath/libswiftCore.dylib #9

This must be accidentally being pulled via Sentry SDK... I'll investigate and see if there's a reasonably easy fix. If not, I'll just bump the minimum version to 10.14 — that it took 3 months since release for anybody to complain implies it's OK to do.
As you observed, this is new in Poedit 3.3, so the fix is to downgrade for now.

@diogob003 Can you please test if this build works?
https://download.poedit.net/Poedit-3.3.2-high_sierra_test.zip

It's not working.
Sentry is linking with libraries that is not present on the Poedit.app bundle.
Running app:
➜  Poedit.app ./Contents/MacOS/Poedit
dyld: Library not loaded: @rpath/libswiftCore.dylib
  Referenced from: /Applications/Poedit.app/Contents/Frameworks/Sentry.framework/Versions/A/Sentry
  Reason: image not found
[1]    9421 abort      ./Contents/MacOS/Poedit

Sentry linked libs:
➜  Poedit.app otool -L Contents/Frameworks/Sentry.framework/Sentry
Contents/Frameworks/Sentry.framework/Sentry:
	@rpath/Sentry.framework/Versions/A/Sentry (compatibility version 1.0.0, current version 1.0.0)
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation (compatibility version 300.0.0, current version 1953.255.0)
	/usr/lib/libobjc.A.dylib (compatibility version 1.0.0, current version 228.0.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1300.36.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1319.0.0)
	/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit (compatibility version 45.0.0, current version 2299.30.112)
	/System/Library/Frameworks/CoreData.framework/Versions/A/CoreData (compatibility version 1.0.0, current version 1244.6.0)
	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1953.255.0)
	/System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices (compatibility version 1.0.0, current version 1228.0.0)
	/System/Library/Frameworks/MetricKit.framework/Versions/A/MetricKit (compatibility version 1.0.0, current version 1.0.0, weak)
	/System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration (compatibility version 1.0.0, current version 1241.60.3)
	/usr/lib/swift/libswiftMetricKit.dylib (compatibility version 1.0.0, current version 6.0.0, weak)
	@rpath/libswiftAppKit.dylib (compatibility version 1.0.0, current version 111.0.0, weak)
	@rpath/libswiftCore.dylib (compatibility version 1.0.0, current version 5.7.1)
	@rpath/libswiftCoreFoundation.dylib (compatibility version 1.0.0, current version 120.100.0, weak)
	@rpath/libswiftCoreImage.dylib (compatibility version 1.0.0, current version 2.0.0, weak)
	@rpath/libswiftDarwin.dylib (compatibility version 1.0.0, current version 0.0.0, weak)
	@rpath/libswiftDispatch.dylib (compatibility version 1.0.0, current version 17.0.0, weak)
	@rpath/libswiftIOKit.dylib (compatibility version 1.0.0, current version 1.0.0, weak)
	@rpath/libswiftMetal.dylib (compatibility version 1.0.0, current version 306.3.4, weak)
	@rpath/libswiftObjectiveC.dylib (compatibility version 1.0.0, current version 6.0.0, weak)
	@rpath/libswiftQuartzCore.dylib (compatibility version 1.0.0, current version 3.0.0, weak)
	@rpath/libswiftXPC.dylib (compatibility version 1.0.0, current version 6.0.0, weak)
	@rpath/libswiftos.dylib (compatibility version 1.0.0, current version 1034.0.0, weak)
	@rpath/libswiftCoreGraphics.dylib (compatibility version 1.0.0, current version 120.100.0, weak)
	@rpath/libswiftFoundation.dylib (compatibility version 1.0.0, current version 1.0.0)

Searching for swift files in Poedit.app returns nothing
➜  Poedit.app find . -iname "*swift*" -print

Is it working on other macOS versions?
I don't know this Framework. Did you try one of the recommended package managers https://docs.sentry.io/platforms/apple/guides/macos/install/ to get Sentry dependencies? Remember to set ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES to YES on Xcode as the docs request. See: getsentry/sentry-react-native#11

Thanks for testing!

Sentry is linking with libraries that is not present on the Poedit.app bundle.

I am aware, yes. But Sentry.framework is weak-linked and its symbols are not used when running on 10.13. My expectation was that failure to load the framework by ld would be equivalent to it missing completely. Apparently, it is not so.

Is it working on other macOS versions?

The Swift runtime is included as part of the OS since macOS 10.14.4. It is missing on 10.13 only.

I don't know this Framework. Did you try one of the recommended package managers https://docs.sentry.io/platforms/apple/guides/macos/install/ to get Sentry dependencies?

Yes, I can read too... That's the cause of the problem and what I was attempting in the test build was to avoid hard linking.

Remember to set ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES to YES on Xcode as the docs request. See: getsentry/sentry-react-native#11

The documentation does not say that. You're repeating a 6 years old comment on some unrelated project...
Six years ago, it made sense to embed Swift runtime. But in 2023 I explicitly don't want to do that, because it would increase the already-large download size by another ~8 MB (and more for the on-disk unpacked app size), for the benefit of only 10.13 High Sierra. That's less than 0.4% of Poedit's Mac users these days...
So it seems that — as much as I don't like it — the time came to bump the minimum required version to 10.14. In theory you should be able to run Poedit 3.3 after installing Swift 5 Runtime Support for Command Line Tools but that's not something that could be "officially" supported.


Add Pixi locator

Fixes https://github.com/microsoft/python-environment-tools/issues/46
I'd like to reopen the discussion about adding support for Pixi given the community interest after the above issue was closed and to bring feature parity with the js locator.
Because Pixi environments have a unique directory layout, the proposed solution is simple enough that it doesn't need any process spawning.
I'm making a sister PR on https://github.com/microsoft/vscode-python and will update this message with a link to it.

@microsoft-github-policy-service agree

@karthiknadig I added a commit based on https://github.com/microsoft/python-environment-tools/pull/175 to fix the unrelated Homebrew CI issue. Even if brew update fails, running it somehow fixes the subsequent brew install. I also confirmed the issue only happens on Homebrew 4.4.6, released ~16 hours ago. Any Homebrew image <=4.4.5 works fine but I couldn't pinpoint the upstream commit causing the issue.
Let me know if this change is ok or if you prefer pinning the Homebrew image to something else.

Thanks for the fix. What you have is good. May be a comment in the YML and docker file, since it looks odd that we are doing this. Also it will remind us to remove it in the future.


frontend: Stream sidebar of one stream is still visible after opening stream sidebar of another stream.

Easily reproducible for me, if unread count are quite high and stream sidebar is opened while page is loading (I mean unread count are keep on increasing).
But even after page is loaded (unread count becomes stable, doesn't increases), stream sidebar is visible. Even after opening stream sidebar of another screen (or clicking anywhere on the page).

Personally I'd assume the behaviour to be that the stream settings menu closes if the click is outside of the stream settings card.

@jainkuniya What browser are you on? Can't reproduce on czo

@synicalsyntax I am facing this on Chrome Version 67.0.3396.99 (Official Build) (64-bit).
https://cl.ly/1X1Z3f0I2U14
I am also able to reproduce it on Safari Version 11.1.1 (13605.2.8)

Closing, as logic added since this issue was posted clears popovers (here called "sidebars"), and it seems this issue no longer reproduces.


Deploy development

We'll branch the current develop into main and kill the master branch. That should solve the issue with the squashed commits in master.


Add support for Python3.7

Let's see what happens and add it to the build pipeline

Meh, old versions of aioredis use async keyword: https://travis-ci.org/argaen/aiocache/jobs/437243330
Need to add a conditional that if system is python3.7, aioredis version should be higher than X (need to check when aioredis added compatibility for python3.7

Closed with https://github.com/argaen/aiocache/pull/420


Local backup is not rotated

Hello,
We encountered an issue with the following configuration where the local backup does not rotate, although the backup on S3 works perfectly. Here is the configuration file:
job_name: "gitlab-data"
type: external
dump_cmd: "path/to/scripts/gitlab-backup.sh"
tmp_dir: /path/to/tmp_dump

storages_options:
  - storage_name: cloud_s3
    backup_path: path/to/gitlab/data/
    retention:
      days: 7
      weeks: 5
      months: 5

  - storage_name: local
    backup_path: /path/to/gitlab/data/
    retention:
      days: 1
      weeks: 0
      months: 0

The logs show the following error:
INFO [2024-02-27 01:00:02.786][gitlab-data] Starting
DEBUG [2024-02-27 01:00:02.786][gitlab-data] Dump cmd: /path/to/scripts/gitlab-backup.sh
INFO [2024-02-27 01:00:02.798][gitlab-data] Starting of `/path/to/scripts/gitlab-backup.sh`
INFO [2024-02-27 01:41:25.097][gitlab-data] Dumping completed
DEBUG [2024-02-27 01:41:25.110][gitlab-data] STDOUT: {"full_path": "/path/to/backups/1708984829_2024_02_25_*.*.*_gitlab_backup.tar"}

DEBUG [2024-02-27 01:41:25.110][gitlab-data] Created temp backup /path/to/backups/1708984829_2024_02_25_*.*.*_gitlab_backup.tar.
INFO [2024-02-27 01:46:30.563][gitlab-data](cloud_s3) Successfully uploaded object 'path/to/gitlab/data/gitlab-data/daily/1708984829_2024_02_26_*.*.*_gitlab_backup.tar' to bucket ****************
DEBUG [2024-02-27 01:46:30.564][gitlab-data](local) Unable to move temp backup: rename /path/to/backups/1708984829_2024_02_25_*.*.*_gitlab_backup.tar /path/to/gitlab/data/gitlab-data/daily/1708984829_2024_02_26_*.*.*_gitlab_backup.tar: invalid cross-device link
INFO [2024-02-27 01:51:57.760][gitlab-data](local) Successfully copied temp backup to /path/to/gitlab/data/gitlab-data/daily/1708984829_2024_02_26_*.*.*_gitlab_backup.tar
ERROR [2024-02-27 01:51:57.761][gitlab-data] Failed to create temp backup.
DEBUG [2024-02-27 01:51:57.893] HTTP response code: 200, body: {"message":"success"}
INFO [2024-02-27 01:51:58.773][gitlab-data] Finished

The /path/to/scripts/gitlab-backup.sh script:
#!/bin/bash
backup_filename=$(docker exec gitlab gitlab-rake gitlab:backup:create GZIP_RSYNCABLE=yes STRATEGY=copy | grep -oP '(?<=Creating backup archive: ).*(?=_gitlab_backup.tar ... done)')

if [ -z "$backup_filename" ]; then
    exit 1
fi

backup_path="/path/to/backups/${backup_filename}_gitlab_backup.tar"
echo "{\"full_path\": \"${backup_path}\"}"

Backups are created until the space in the partition runs out.

Hi.
Thanks for your interest in nxs-backup.
A fix for the identified issue has been included in the release v3.1.1
We look forward to receiving new requests.


Post links can throw 500 internal server errors

example: https://lemmyverse.link/lemmy.today/post/4312610
this doesn't seem to be consistent for all users.
when this link was shared, some users had no issues, while other users received an internal server error:

Unless there's another problem, it should be fixed by #2. Feel free to reopen if you encounter the same issue again.

Still broken unfortunately, both with the original link and this one: https://lemmyverse.link/lemmy.world/comment/6221447
I can reproduce this with various instances as home instance, for example:

sopuli.xyz - exists at https://sopuli.xyz/comment/5590397
lemm.ee - exists at https://lemm.ee/comment/7558501

working instances:

lemmy.world
lemmy.ml
feddit.de
lemmy.ca

This seems to be because the comment is deleted on lemmy.world.

here you go: https://lemmyverse.link/lemmy.world/comment/8760207

Fixed, thanks for the report!


ipfs: 0.5.1 -> 0.6.0

Motivation for this change
https://github.com/ipfs/go-ipfs/releases/tag/v0.6.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

The release notes mention some migration in the config? Let's make sure the IPFS NixOS module is not doing anything deprecated?

I diffed the config generated by NixOS and the ipfs init one: the only change is they started adding QUIC listen addresses.
We could change the default value of services.ipfs.swamAddresses to include QUIC, but there are no incompatibility, I think.

Thanks for checking! Let's do that, good to hear there's nothing else.


Page Caching using Cloud CDN

Add cache headers to the top page.

I can't cache any pages if I need to care about auth and cookies. I will have to disable auth for the user facing part of the website before caching can work.
More info about caching pages is here:
https://cloud.google.com/cdn/docs/caching

I want to at least have the static files be cached. Currently they don't have a Cache-Control: public header. For some reason the Content-Length header is also 0.
$ curl -I https://www.ianlewis.org/static/CACHE/css/e3b3d94c2620.css
HTTP/1.1 200 OK
Server: nginx/1.11.1
Date: Mon, 19 Sep 2016 01:12:36 GMT
Content-Type: text/css
Content-Length: 0
Etag:<PHONE_NUMBER>.27
Last-Modified: Sun, 18 Sep 2016 12:48:49 -0000
Via: 1.1 google
Alt-Svc: clear

The static library doesn't seem to add the necessary headers. It simply iterates over the file and sends it.
https://github.com/lukearno/static/blob/master/static/apps.py

The waitress docs say that waitress will set the Content-Length if the file-like object passed to it is "sufficiently file-like". I guess that means that the file-like object passed to it by static is not sufficiently file-like?

wsgi apps must not set a Transfer-Encoding apparently.
https://www.python.org/dev/peps/pep-0333/#handling-the-content-length-header

It sounds like the conclusion will be that I need a better web server than waitress :(

Upgrading to waitress 1.0.0 didn't fix the Content-Length issue. Maybe file a bug?

I tried it with a minimal app and it seems like waitress isn't the problem.
from waitress import serve

def app(environ, start_response, headers=[]):
    fd = open("test.txt", "rb")
    way_to_send = environ.get('wsgi.file_wrapper')

    start_response("200 OK", [])
    return way_to_send(fd, 16 * 4096)

serve(app, host="localhost", port=8000)

I get the proper content header
$ echo "this is a test" > test.txt
$ curl -I http://localhost:8000/
HTTP/1.1 200 OK
Content-Length: 15
Date: Mon, 19 Sep 2016 02:29:20 GMT
Server: waitress

For some reason the length from the file-like object from static can't be used by waitress?

It is sending the content-length. I just wasn't using curl properly
$ curl -i http://localhost:8000/static/css/style.css
HTTP/1.1 200 OK
Content-Length: 4813
Content-Type: text/css
Date: Mon, 19 Sep 2016 08:53:50 -0000
Etag:<PHONE_NUMBER>.18
Last-Modified: Sun, 18 Sep 2016 03:22:02 -0000
Server: waitress

This seems to be working at least for static files. I'll go ahead and close this since caching the html pages themselves will need a bit more thought.


Feature request: Add support for app.runWithContext()

This feature was introduced here and it's now used by vue router and pinia. Adding this will help people use the new feature
Here is a currently failing test using only vue test utils
  it('runWithContext', () => {
    let app: App
    const wrapper = mount(
      {
        template: `<HasInjection />`,
        setup() {
          provide('hello', 'component')
          return {}
        },
        components: {
          HasInjection: {
            setup() {
              const globalInjection = app!.runWithContext(() =>
                inject('hello', 'fallback')
              )
              const parentInjection = inject('hello', 'fallback')
              return { parentInjection, globalInjection }
            },
            template: `<div>{{ parentInjection }};{{ globalInjection }}</div>`,
          },
        },
      },
      {
        global: {
          provide: {
            hello: 'global',
          },
          plugins: [
            (a) => {
              app = a
            },
          ],
        },
      }
    )

    expect(wrapper.text()).toBe('component;global')
  })

I added the failing test at https://github.com/vuejs/test-utils/tree/feat/runWithContext in case anybody wants to pick up the task

I'm not yet familiar with this feature you implemented in core, but looking at
https://github.com/vuejs/core/commit/869f3fb93e61400be4fd925e0850c2b1564749e2#diff-aba22e928f34a9ced3bf916c54a41b6facdfcb3e2caa18534dfae6d8a7e3cea6R56-R60
I thought this was expected if runWIthContext is in a component.
As instance will not be null, no? And in that case, the current app context will not be checked.
Or am I missing something obvious?

I'm getting a different behavior within pinia but apparently it's the normal behavior. I think I must be forgetting something though. I wonder if it wouldn't be more consistent to give preference to the app within runWithContext, but that's a core thing anyway. Sorry 😅


Some questions about the code

I am sorry to disturb you. For the net.py, the input of the GCN is x=I (identity matrix), the shape of the x is (adj.shape[1], adj.shape[1]), but the feat_size is 200 rather than adj.shape[1] and you don't use  input_repr here. Do I misunderstand it? Thanks.

Hello. Thanks for the interest to my code.
You are correct.
I am not using input_repr (I deleted input_repr in d380365e950fc3e8c8b08d0fb413a1a575ec2c00) as you pointed out. The input is transformed to 200d (=feat_size) vector in the first GraphConvolution layer.
I intentionally made this somewhat inefficient implementation to be consistent with the paper; i.e. apply dropout to identity matrix.
Please close the issue if you are OK with the above explanation.


modified travis config to build with source overlays

closes #374

looks good on travis. As soon as we have reasonable tests defined, we should unkomment 'catkin_test_results' to reflect the test result status in the travis log. @ipa-mdl: Thanks!

There is an issue with the latest catkin version that results in many cmake errors/warnings (https://github.com/ros/catkin/issues/761).

Functionality was successfully tested in #378.
@ipa-fxm, @ipa-fmw: your turn :D

Awesome!
The run_test failures detected in #378 are fixed in https://github.com/ipa320/cob_robots/pull/379

Note that in the .travis.rosinstall, entries for all bringup repos should be included except for the respective repo itself

The respective repo can be included, but it will be build twice then.
If you don't bundle a .travis.rosinstall file the default one is used ()https://github.com/ipa320/setup/blob/master/repositories/cob_indigo_bringup.rosinstall.

Of course....travis.rosinstall is installed in an underlay...
We should definitely update the default .rosinstall file in setup according to the changes in #379 (then we might be able to just use that one)

CR: OK


Don't allow continent-sized Places to have "endemic" organisms

As brought up in this Google Group thread, having the term "endemic" applied to something the size of a continent is a bit nonsensical, so I propose not allowing it to be an option for a continent-sized place or larger, and to delete any Establishment Means set to "endemic" for said places.

Can I close this @kueda?


Added .replit file, Added package.json file and tweaked README.md

I added package.json file for easy installation of dependencies and added replit file for running it in replit easily.

I changed mongodb branch readme's database to mongodb from quick.db

I forgot to add ejs in package.json. Now i added it


pkgsi686Linux magic

Something is wrong, as IMHO it doesn't do (exactly) what it's supposed to do:
$ nix-instantiate --argstr system i686-linux -A linux_3_14 --dry-run
/nix/store/0z0km3l5bmd2lzb4zq4vy29i33jgih1b-linux-3.14.6.drv

$ nix-instantiate -A pkgsi686Linux.linux_3_14 --dry-run
/nix/store/c8abapb26gkymajcxv8g7kf8hqbn5br9-linux-3.14.6.drv

I can't reproduce this anymore, perhaps someone has fixed it.


Enable the choice of sources to be analyzed providing a URL

is this still in scope? if so can we clarify the requirement - is it to switch brokers?


Document knowledge doc size limit

@kelbrown20 complete for taxonomy, working on CLI today

While I understand limiting the question to the token max for merlinite, why is the qna pair be limited as well? My understanding is that it is passed to the teacher model as you say but can the context limit of the teacher model not be upped to accommodate this? If the teacher model is a different model than the merlinite model is the max context length still the same for both?

A larger teacher model can have a larger context window, but the default experience with the ilab CLI uses the merlinite-7b-Q4_K_M model that only has a 4096 context size. The --server-context-size parameter to ilab generate allows you to override this from 4096 to something larger.
And, from a documentation standpoint, you're right that the values here really depend on the model in use and its maximum context size.

Thank you for answering. To follow up, I understand that the ilab cli has this max in place, but is this max also set for the teacher model, which based on the documentation is the mixtral 8x7B? My confusion is that even if the ilab has this max, it is never passed the question and answer anyways, it is only ever passed the question with generate, so having the max be a combination of question and answer doesn't quite make sense to me.

The teacher model is the same merlinite model unless the user changes the default to point to another teacher model they host themselves. And we do pass two question and answer pairs to the teacher model (as examples in the prompt we give it), which by default is the merlinite model with the 4096 max context size.

Ahhhh I see I apologize I did not realize this was for the quantized model for the cli. Is there any reason these maxes would need to be implemented in actual pr submissions?

My personal opinion is that PR submissions to the taxonomy repo should be limited to whatever works by default with the ilab CLI. I'm not sure others agree, and there's probably a broader discussion around what role ilab plays in taxonomy PR submissions.


Fix for UpdateExpression with newline. Closes #2275.

Coverage increased (+0.01%) to 93.044% when pulling 53f8997d622694153b6a74766da295179845a7d3 on fix-2275 into e77c4e3d09f39e6415fbbc86cfb98709480eb1a9 on master.


I want to change the license to GPL

Hi, I don't know if you'll get an email notification for this or not. I ported ModComponent to the latest version of The Long Dark. With your help/permission, I'd like to change the license on ModComponent to the latest version of the GNU General Public License, so that no one can ever commodify our work.

After conferring with the other modders, I think it's best that it stays with MIT.


Add a blog post from a maintainer

@jjerphan
So we can have a couple of real posts on the scikit-learn blog, would you like to cross-post your blog from December?
https://jjerphan.xyz/pairwise-distances-reductions.html

Sure. I need to reorganize it first.


the library 'GoogleMobileAdsTarget' requires macos 10.10, but...

Got error during the standalone swift package build:
error: the library 'GoogleMobileAdsTarget' requires macos 10.10, but depends on the product 'GoogleAppMeasurement' which requires macos 10.12; consider changing the library 'GoogleMobileAdsTarget' to require macos 10.12 or later, or the product 'GoogleAppMeasurement' to require macos 10.10 or earlier.

In this line
https://github.com/googleads/swift-package-manager-google-mobile-ads/blob/e137e77fb4562045a829d4910717073890292e57/Package.swift#L21
Put
  platforms: [.iOS(.v10), .macOS(.v10_12)],


vue query is doing double request

I tried the vue query extension and I noticed that if you refresh a page its will first do the fetch on the server and then will do it again on client.
I did find a way to prevent this like this using the enabled argument
const { isError, isPending, isFetching, data, error, suspense } = useQuery({
queryKey: ['key'],
enabled:usePageContext()._vueQueryInitialState == undefined,
...

this way the fetch will happen only on the server on refresh and on the client on client side navigation.
I don't know if it's the best fix but it works

@4350pChris WDYT?

@4350pChris I could reproduce with examples/vue-query the fetchMovies() function is indeed double called.

@brillout My hunch is that this is because the order of hydrating the client and registering the plugin is switched. Have a look at these docs - https://tanstack.com/query/latest/docs/framework/vue/guides/ssr#using-vite-ssr
You can see that the client is hydrated first before installing the plugin.
We're doing it the other way around - createVueApp installs plugins by calling onCreateApp, while hydration happens in onBeforeRenderClient.
In onRenderClient, createVueApp is called before onBeforeRenderClient, causing hydration to happen after installing the plugin.
I'll check if this is the actual reason.

Nevermind that, the reason is the following:

Query instances via useQuery or useInfiniteQuery by default consider cached data as stale.

from https://tanstack.com/query/latest/docs/framework/vue/guides/important-defaults
So this is expected behavior. If you want queries not to refetch, you'll have to add staleTime: 1000 * 60 * 5 // example for 5 minutes in ms to +queryClientConfig.ts.

Makes sense, thank you! We should add some docs at https://github.com/vikejs/vike-vue/tree/main/packages/vike-vue-pinia#readme.

We should add some docs at https://github.com/vikejs/vike-vue/tree/main/packages/vike-vue-pinia#readme.

In the meantime I've added a stale time to the example.

thanks for helping


cancelUntil missing in definition (dal:validate error)

Current version in master branch does not define cancelUntil as a computedfield which results in dal:validate to result in an error.
Should be a simple fix.

Fixed


MH-13655, Scheduler Message Logging

This patch fixes a number of log statements in the message receiver for
scheduler messages, ensuring that exceptions are logged properly and
simplifying the overall logging.
This is a byproduct of the other scheduler fixes and has no real consequences except for logging.
Work sponsored by SWITCH

HI @lkiesow since the mpId and sometimes  also the User is known at the point of the logging the ERROR, but is no longer available at the point of reading the ERROR from the log, it'd be really helpful to add the context at the point it is known. Otherwise it's annoying to read the ERROR in the log saying "the event failed catastrophically" without knowing which event or who or any context at all to justify the ERROR even being logged.

Makes sense. Will add it to all the error logs.

@karendolan, done. Looking at this again, I noticed that you could actually simplify the logging quite a bit since it was basically the same catch block which was repeated over and over again. There is now one. In case an error occurs, you now get a message including the message type, the event id, and the whole stack trace.


Error "Please install pg package manually"

I'm getting below error in CLoudWatch when I did deploy my aplication to staging stage.

I'm using sequelize as ORM, but in local dev it works normally, I tried to add pg as nodeModule option in the index

but when I tried to build it never finish.

Hope someone can help me with this issue.
Thanks and regards

Hmm I don't know if I've seen this issue before. Is this an edge function btw?

Hmm I don't know if I've seen this issue before. Is this an edge function btw?

No is not, it's a normal lambda function.
This is the code of the function:

This is likely fixed in v2 but need you to give it a try

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


Move to signed ordinals?

What are pros and cons?

I found a nice article about it https://kristerw.blogspot.de/2016/02/how-undefined-signed-overflow-enables.html Like people say in the comment while these optimizations are possible most of them shouldn't make any big difference (Also some optimizations are only possible with unsigned int http://stackoverflow.com/questions/4712315/performance-of-unsigned-vs-signed-integers). The main advantage seems that it helps the compiler to vectorize loops. I guess that could be pretty important for us since Kokkos doesn't let you annotate a loop to force vectorization :-( If you want to use vectorization you either change some flags in Kokkos so the compiler is more aggressive or you need to use a three level nested parallelism and that's really ugly.

Mark has some interesting thoughts (here)[https://groups.google.com/forum/#!topic/trilinos/ruXNsFQ-1K4]. Of particular importance:
GlobalOrdinal is not a trivial template parameter, like T in std::vector<T>.  I can't just allow any old type there.  If I allow a type, I need to test it regularly in order to make sure it works.    They are responsible for maintaining and testing those types.  Unsigned GlobalOrdinal types are NOT enabled by default.

Another one against unsigned: no support in Fortran, so no robust interoperability.

I would like to resurrect this discussion. We need to decide on what to instantiate on when moving to Trilinos as TPL. In addition, as Trilinos moves to signed 64-bit global ordinals, is there a reason not to follow it there?

Can't think of any reason atm.

Neither can I.


fixing typo

https://www.pulumi.com/docs/guides/adopting/from_aws/#migrate-resources-into-code

Thank you!


examples omitting YIELD are invalid now

examples omitting YIELD are invalid now, should we remove them or add YIELD cluases?

this feature will be released in 3.0.0. And only checked in the master branch.
Besides, it is not fully tested so far. So I'll add to doc after code freeze.


add status for test IO

Adds the following events or companies:

test IO

Checklist

[x] I have updated the event or company counts
[x] I have put the most recent relevant date in the "Last Update" column
[ ] I have linked to the article about the change, not the company's website

and apparently remove a lot of hanging white spaces...

It looks like you have a massive merge conflict thanks to that whitespace removal. I'll do a separate PR removing all the whitespace, then that should make your life a little easier.

appreciate it, sorry i wasn't more present when you pointed out the conflict!

No worries!


Change locking strategy for LineCache

We want to allow the LineCache to be locked mutably for an extended
period so we can store associated data (TextLine entries and probably
caret positions). This patch introduces a MutexGuard very similar to
Rust's, and also a LineCacheLocked that is an instance, so mutations
to the state are safely guarded by the mutex.

This feels like a nice local change to the new locking strategy. I'll implement the TextLine caching on top of this, which will also have the effect of migrating method calls currently on LineCache to calls on LineCacheLocked (which will also decrease the amount of forwarding bureaucracy).
Note I got rid of the separate MutexGuard class. This also makes the permissions much cleaner, as LineCacheState is now fileprivate.