Description
Your version of vue-masonry wall works great in my app, but I was wondering if you would consider including the endless scroll functionality @append="append" from the original, where the interaction observer auto-loads a function to append new items to the masonry wall items object?
Basically the same implementation from https://github.com/fuxingloh/vue-masonry-wall/blob/a02d49c78cfda9a7dcaadefe7a30f67ea010f590/src/vue-masonry-wall.vue#L10 - but for your version (that includes support for add/removal of items).
Thanks!
Solution
Support @append="append" functionality from original vue-masonry-wall.
Additional context
No response
Preferences

[ ] I want to be assigned to and work on this issue myself

Would be very interested in this as well.

If this feature is not being considered at the moment any change you can point me in the direction on how to add the functionality temporarily?
I'm using the Intersection Observer API to add items to the original array but that leads to duplicated key, scrolling issues and flashing content. Not sure if it's how redraw is done perhaps?

Unfortunately, I won't have time for my OSS projects for the foreseeable future.
Regarding this issue, I can't think of a good solution that supports both adding and removing items without reassigning the entire input array.
As a workaround on your end, I think it should be possible to put an Intersection Observer element below the component. Then, whenever it intersects, fetch a new item and re-assign the prop items to [...oldItems, newItem]. This approach for adding items should work as seen in the demo.

That is exactly how I am doing it actually. It turns out it was my fault for trying to remap item values after I had merged in new images. Works pretty well now that I've changed that. Thank you!

Considering that the approach described here enables this functionality without massive changes to this library, I'll close the issue.

That is exactly how I am doing it actually. It turns out it was my fault for trying to remap item values after I had merged in new images. Works pretty well now that I've changed that. Thank you!

Do you have an example on GitHub showing how this works? I'm unable to get Intersection Observer to not fire immediately on page load and try to load more data, or it fires on page load and then again when the masonry wall items load and render.


Adding optional CONFIG_PATH env var support

This PR adds support for defining the CONFIG_PATH settings through an environment variable. I'm not in love with the env var's name since it is pretty generic, but I stuck with the naming convention of the other variables in env.js

Strange - this PR is basically undoing a previous change https://github.com/github/safe-settings/commit/18509385eaae9762379a2884e4491e60d5ae6bf3 which removed this flag.

Thanks @decyjphr for pointing out the other PR. I looked at the comments on #351, and I think my PR is still worth considering. A few specific points to address:

Probot's suggestion of using .github for config files: As @martinm82 noted, Probot's best-practices docs say to store configs in the .github directory of repos. I think this suggestion is more appropriate for GitHub Apps that would load repo-specific configurations from the repo directly. Since safe-settings instead stores all configurations in an "admin" repo, I don't think this best-practice is as relevant.

Updating all hardcoded ".github" directory references: The author of #351 rightly noted that there are several spots in the code that are hardcoding the config-path directory. I've since updated this PR to use env.CONFIG_PATH instead. I left most of the README as is -- other than adding a note about the CONFIG_PATH env being an optional param.

Ideally we'd have some unit tests to ensure that the repo and sub-org overrides are being loaded correctly when overriding CONFIG_PATH. It wasn't clear to me how best to go about this though, so if anyone has suggestions, let me know.


Fixes and todos for app readme

The app build Readme doesn't work for me, I was told it is probably broken. I added a couple of steps and asking for help to fix it further

Looks good to me, but let's see @josancamon19 has more comments.


Box does not work.

Just copied and pasted the code from README and it doesn't work with 1.0.0. version of tweetnacl.
const newNonce = () => nacl.randomBytes(nacl.secretbox.nonceLength);
const myKeyPair = nacl.sign.keyPair();

const theirDHPublicKey = ed2curve.convertPublicKey(myKeyPair.publicKey);
const myDHSecretKey = ed2curve.convertSecretKey(myKeyPair.secretKey);

const anotherMessage = tweetnaclUtil.decodeUTF8('Keep silence');
const encryptedMessage = nacl.box(anotherMessage, newNonce(), theirDHPublicKey, myDHSecretKey);

// When we receive encrypted messages from peers,
// we need to use converted keys to open them.

const decryptedMessage = nacl.box.open(encryptedMessage, newNonce(), theirDHPublicKey, myDHSecretKey);

console.log(decryptedMessage);

in the console: null
Thoughts?

You have to use the same nonce that you used to encrypt. You're generating a new one.

You have to use the same nonce that you used to encrypt. You're generating a new one.

Thank you.


Switch statement default option is incorrectly indented following a return

Consider the following snippet:
#!/usr/bin/env node

var indent = require('indent.js');
var input = 'switch (foo) {\ncase \'bar\':\nreturn baz;\ncase \'baz\':\nreturn qux;\ndefault:\nreturn null;\n}';

console.log(indent.indentJS(input, '  '));

I would expect the output to line up the default statement with each of the case statements above it, but the actual output uses the same indentation as the preceding line:
switch (foo) {
  case 'bar':
    return baz;
  case 'baz':
    return qux;
    default:
    return null;
}

I believe this issue should also be fixed in the latest commit on develop ab5a81dcd80f1802a8cae8dca1e27f9b888badd1.
If you have no further problems, I will merge this with master.

It seems to be working as expected. Thanks again for the quick fix!

Cool. I'll merge this then and make a new release then. Thanks for pointing out these issues :)


No modal id found in NiceModal.useModal

Hi, I'm attempting to use this for the first time, in a Nextjs project, and am running into the error (server-side):
Error: No modal id found in NiceModal.useModal
When following the docs:
import { Modal } from 'antd';
import NiceModal, { useModal } from '@ebay/nice-modal-react';

export default NiceModal.create(({ name }) => {
  // Use a hook to manage the modal state
  const modal = useModal();
  return (
    <Modal
      title="Hello Antd"
      onOk={() => modal.hide()}
      visible={modal.visible}
      onCancel={() => modal.hide()}
      afterClose={() => modal.remove()}
    >
      Hello {name}!
    </Modal>
  );
});

The main difference being that instead of using antd, I'm using a modal called Dialog from Radix UI
I'll set up an example for you but in the meantime, am I doing something wrong that should be obvious?
Thanks

Hi @dungle-scrubs , did you wrap your app with NiceModal.Provider? https://github.com/ebay/nice-modal-react#embed-your-application-with-nicemodalprovider

Yes, then realized shortly after that it's because you can't wrap your app with this Provider in Nextjs' _app.js and must do it in each page instead.
Do you know if there's a solution to that?

The solution I'm using on my end is to wrap the contents of <Layout> with the Provider.  I have multiple Layouts in my Nextjs project, so I use a common component that wraps both of them.

Why is it not possible to use this provider in the normal way other providers are used in a NextJS app? Thanks for any explanation.

@kevinswarner it is the normal way like other providers.

@supnate Sorry. I should have asked my question more clearly. I simply meant that I am using several other Provider libraries that work fine by placing them in the _app.js file in NextJS. I was just wondering why this one seems not to work when following that pattern. I like your library by the way. It is very helpful. I am just curious about the reasons it will not work in the  _app.js file. Thank you.

To be honest, I'm not familiar with NextJS. It seems should be ok in _app.js after google about it since it's just a normal provider component like others. @dungle-scrubs do you have any idea why nice modal provider can't be used in _app.js.

After some search, I found it seems could be used like this: https://github.com/agnosticoder/fitness-app-next-frontend/blob/0b2e502e710287c840252ded7b32e0121c701e7e/pages/_app.tsx

Thanks. I will look at the example.


Fizzysearch x Sparnatural

Unfortunately, the integration of the magic triples such as vec or fts does not work so well with Sparnatural. The reason is that the triple is formulated more complex by the query buildier. I don't know which is easier, to change the query builder or fizzysearch.

Related to https://github.com/sparna-git/Sparnatural/issues/621


Can't disable Keycloak OIDC action not available

What kind of request is this:
bug
Steps to reproduce:

Enable Keycloak OIDC
Then click Disable

Result:
Action not available
POST /v3/keyCloakOIDCConfigs/keycloakoidc?action=disable
{"baseType":"error","code":"ActionNotAvailable","message":"","status":404,"type":"error"}
Other details that may be helpful:

Environment information

Rancher version: 2.6 master-head (05/27/2021) 62aef76
Installation option: HA RKE1

Related:
https://github.com/rancher/rancher/issues/30280
https://github.com/rancher/dashboard/issues/2191

Rancher version 2.6 master-head (06/03/2021) be03c8bd1
I am able to enable, disable and re-enable the auth on a build from today.


Remove bare array creation from multi assign

Previously, a = 1, 2, 3 was parsed as a = [1, 2, 3]. This is a weird special case with strange side-effects such as a = 1, b = 2 being parsed as a = [1, b = 2] which is... not optimal. The previous statement can happen easily as a syntax error:
a = 1,
b = 2

This doesn't effect swapping expressions (a, foo.bar = foo.bar, 2) or destructuring (a, b, c = method()).

I agree. This is too much sugar.


Fix parsing Mailboxes with a comma in the name

Fixes #690

May I ask you which lettre version I should use to have this fix?

May I ask you which lettre version I should use to have this fix?

Any version starting from 0.10.0-rc.6

Thank you for the quick response c(^-^)c


[backport][branch-2.3][BugFix] Support transferring json using HTTP chunk (#6972)

This PR is the backport of #6972 to branch-2.3.

run starrocks_fe_unittest


Style guide - Inputs

Placeholder for discussion about these facets of the style guide.
Talking points

Select lists

With and without "new item" input

Text input
Password inputs
Confirmation (Y/N/abort)
Args, command option and flag usage

Current select list:
$ torus link -f
✔ Select organization: jeffandersen
? Select project:
+  Create a new project
   awesome
 ☞ www

Current confirmation prompt:
 torus unset ok
You are about to unset "/jeffandersen/awesome/dev-jeffandersen/default/*/*/ok". This cannot be undone.
? Do you wish to continue? [y/n]

I find our pointer character doesn't render the best across all fonts. We should think about replacements for that.
Colorizing the "Create new [object]" entry would provide better separation of outcome.

@jeffandersen and @jbowes and I discussed the pointer offline and @jbowes followed through! https://github.com/manifoldco/torus-cli/pull/150

The new object prompt needs to feel more separate imo. The plus doesn't quite get it there. Maybe a place to colorize? Or having the prompt start on create new would show that it can be selected and it is not a label.

I actually like the way we handle inputs now. It feels very intuitive, dim label with ? to indicate its an input, changing to a ✔ on completion, an ✗ if its input is incorrect.
Password inputs are great right now as well with ●●●● masking.

@jeffandersen what do you mean by:

Args, command option and flag usage

@ntassone args being torus cmd subcmd [arg] ie. torus orgs create myorg, command options being torus cmd --command-option [value] and flags being torus cmd --flag (no value).

Ah, gotcha, I put my thoughts for those on the main issue: https://github.com/manifoldco/torus-cli/issues/124#issuecomment-266059332

args being torus cmd subcmd [arg] (ie. torus orgs create myorg), command options being torus cmd --command-option [value] and flags being torus cmd --flag (no value).

argument (or positional argument) is pretty standard for the bare thing on the command line, but the things with one or two -s in front (or heck, even a /!) are called all kinds of things: switches, options, flags, arguments. Sometimes the fact that it takes in its own argument or not changes the name. it's confusing.
I'd like to stick to 3 things:

commands/subcommands
arguments: the subject of the command.
options: stuff with -- that might be:

strictly optional (--verbose)
sourceable from other locations (env vars, config file)
not expressible with vanilla arguments (complex options with deps. avoid these)

regardless of if it has its own argument, we should just call it an option.


add timezone to application.rb

Add edit to Events controller
Add edit link to Events view
Add timezone to application.rb


docs: Add RHEL and SLES install warnings

Unfortunately, at present we have no way of testing Kata packages for Red Hat Enterprise Linux (RHEL) or SUSE Linux Enterprise (SLES).
Add warnings to the RHEL and SLES install guides explaining this and advising users to exercise caution. Hopefully, we will be able to drop this warning soon (either when we have the ability to test on RHEL/SLES or when Kata packages are available in RHEL/SLES).
Fixes #396.
Signed-off-by: James O. D. Hunt<EMAIL_ADDRESS>

As I said in the commit message, let's hope this warning will only be required temporarily.
Ping @kata-containers/documentation.
/cc @ttx, @lsm5, @fatherlinux, @mrguitar.

@jodh-intel I don't fully understand what is going on here, but having some people take a look. Sadly, I don't know their user names in GitHub, or I would just tag them in. Are we sure the gcc feature you are looking for isn't back ported in RHEL? Why is it working in CentOS, but not RHEL? That part is confusing to me?

Hi @fatherlinux - the problem we have as I understand it is that the Kata project doesn't have a way to obtain RHEL licenses. So although we can build packages on RHEL thanks to OBS, we cannot test them, hence the need for this PR.
I think we may have tried a developer / trial version of RHEL way back, but that didn't provide package updates / full RHEL repo access I think. There may also have been an issue trying to use RHEL in our CI environment (Jenkins) - does that sound right to you @chavafg, @gabibeyer, @grahamwhaley?
There is also a bit of detail on https://github.com/kata-containers/ci/issues/3.
I've just realised that we have the same issue with SLES, so I've updated this PR for that too.

Ping @kata-containers/documentation.

Ping @kata-containers/documentation - small change set seeks sponsors for quick review :smile:


Updates to the PR template

Description & motivation
Update PR template to include link testing and the style guide

@runleonarun : updated the link to the style guide to match the one used in PR https://github.com/dbt-labs/docs.getdbt.com/pull/2015
good to go?


Spinocerebellar ataxia with axonal neuropathy type 2 (SCAN2) vs Ataxia-oculomotor apraxia type (AOA2)

Orphanet merges these concepts
[Term]
id: Orphanet:64753
name: Spinocerebellar ataxia with axonal neuropathy type 2
def: "Ataxia with oculomotor apraxia type 2 (AOA2) is a rare autosomal recessive cerebellar ataxia (ARCA; see this term), characterized by progressive cerebellar ataxia associated with frequent oculomotor apraxia, severe neuropathy and an elevated serum alpha-fetoprotein (AFP) level." []
synonym: "AOA2" EXACT []
synonym: "Ataxia-oculomotor apraxia type 2" EXACT []
*synonym: "SCAN 2" EXACT []
synonym: "SCAR1" EXACT []
xref: ICD10:G60.2
xref: OMIM:606002
xref: OMIM:615217
is_a: Orphanet:377788  ! disease
relationship: has_AgeOfOnset Orphanet:409946 ! Childhood
relationship: has_AgeOfOnset Orphanet:409947 ! Adolescent
relationship: has_AgeOfOnset Orphanet:409948 ! Adult
relationship: has_inheritance Orphanet:409930 ! autosomal recessive
relationship: part_of Orphanet:98097 ! Autosomal recessive cerebellar ataxia due to a DNA repair defect
relationship: part_of Orphanet:98497 ! Genetic peripheral neuropathy
relationship: part_of Orphanet:98688 ! Oculomotor apraxia or related oculomotor disease
property_value: definition:citation "orphanet" xsd:string

(note the def uses AOA2 and the label uses SCAN2)
Both AOA2 and SCAN2 arise from mutations in SETX and present with the same phenotypes so merge is justified. What we are lacking in a clear way in MONDO to state that what may once have been considered two distinct concepts are now one. We can of course use alternate labels as syns and annotate these. But it would be good to be more explicit somehow, such as a separate synonym type?
of interest reviews often do not acknowledge the other concept/label, all the more reason to be very explicit here:

gene reviews AOA2 https://www.ncbi.nlm.nih.gov/books/NBK1154/
GARD SCAN2 https://rarediseases.info.nih.gov/diseases/12860/spinocerebellar-ataxia-with-axonal-neuropathy-type-2

I am looking for clarification on these disease terms.
OMIM 606002 combines SCAN2, AOA2 and SCAR1 as equivalent/alternate names for the same disorder, as does UMLS/SNOMEDCT (UMLS CUI: C1853761). NCI equates SCAN2 and AOA2 (NCI Thesaurus Code:  C165500) (SCAR1 is apparently no longer represented in NCIT as it's own entity, still attached to SETX wt allele entry).
However, MONDO represents SCAN2 (MONDO:0018996) as a parent term to AOA3 (MONDO:0014084)  and spinocerebellar ataxia, autosomal recessive 1 (MONDO:0011623) . Based on OMIM, it seems SCAR1 is a "former" term and no longer used; and since it appears that SCAN2 (MONDO:0018996) already encompasses the synonym "SCAR1," is this child term needed?
And should AOA3 be a child of SCAN2 or rather a sibling (it is also Autosomal recessive, but has a different genetic etiology) ?

This is what we currently have:

@kanems is proposing we make MONDO:0014048 a sibling of MONDO:0018996 (this looks confusing, but I think this is how it would look):

related ticket:
https://github.com/Orphanet/ORDO/issues/11

FYI
@galyea-gard
@ahamosh
@ana-rath-orphanet

Spinocerebellar ataxia with axonal neuropathy type 2 and AOA2 are the same. Autosomal recessive spinocerebellar ataxia with axonal neuropathy-1 is the same as Spinocerebellar ataxia with axonal neuropathy type 1 (SCAN1). GARD decided to use AOA2 after a message from an organization back in 2018 but kept the other terms as synonyms. Thank you! Gioconda


Added link to another project which uses this library

Description
Hi there, I just created a project which uses this library, so I added a link to the README.
License Acceptance

[x] This repository is Apache version 2.0 licensed and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Type of changes

[ ] Add/update a helper script
[x] Add/update link to an external resource like a blog post or video
[ ] Bug fix
[ ] New feature
[ ] Test updates
[ ] Text cleanups/updates

Checklist

[x] I have read the CONTRIBUTING document.
[x] All new and existing tests pass.
[x] Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an allowed exception)
[x] Scripts added/updated in this PR are all marked executable.
[x] Scripts added/updated in this PR do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
[x] I have confirmed that any links added or updated in my PR are valid.

Thanks for the PR! Glad it's been useful for you.


Correctly handle asynchronicity

This has a bug, can you spot it?
async function setUserStore(newUser: User | null) {
    console.log("Updating user state", newUser);
    user.value = newUser;
    if (newUser) {
      const fetchedProfile = await useProfileService().fetchProfile(newUser);
      setProfileStore(fetchedProfile);
    } else {
      setProfileStore({});
    }
  }

Bug:
When the user changes very quickly, and supabase's response times are slow, then this can happen:

User changes to Jane
We start fetching the profile (!!!)
Jane logs out, thus the user changes to null
We set the profile to empty
Supabase returns the profile that we tried to fetch a while ago...and now we have a logged out user, with the profile of Jane

Dang - this is an actual vulnerability.

I think since it's all client side, it's not much of a vulnerability.


Remove migrations and all tests for compatibility with v0.23.12

Removes migrations and all tests, this is needed for compatibility with new version v0.23.12 since the migrations import from github.com/pocketbase/pocketbase/models and github.com/pocketbase/pocketbase/daos which do not exist in v0.23.12. The current state breaks builds so I created this PR for you to quickly do a temporary fix, obviously the migrations and tests should be restored later once it is compatible.

@benallfree could you please check this out? I am a bit out of time for this currently and since you did the v23 migration PR maybe you can confirm to merge :)

@CanGonenc Do you mean there is something special about v0.23.12 exactly, or just v0.23.x?
Can you provide more information please? We already have v23 compat with passing tests, don't we?

Sorry the description wasn't clear, I encountered the problem and struggled to debug and fix it for 3 hours so I was frustrated so I hastily created the PR so that other people having the same issue dont have to figure it out themselves. The problem is not with v0.23.12 specifically, the problem is with the tests not being compatible with the v0.23.x version (they are importing github.com/pocketbase/pocketbase/daos and github.com/pocketbase/pocketbase/models which are removed in v0.23). Which results in an error when go get -t "github.com/pluja/pocketbase" (which gets and builds the tests, so no problem only breaks when trying to build tests) and more importantly when go mod tidy is run with the go.mod package including both pluja/pocketbase and pocketbase/pocketbase (because go mod tidy apparently tries to build the tests in this scenario?? idk why exactly):
sample go.mod which errors with go mod tidy:

module main

go 1.23.4

require github.com/pluja/pocketbase v0.1.0

require github.com/pocketbase/pocketbase v0.23.12

Error message after go mod tidy with go.mod file including both pluja/pocketbase and pocketbase/pocketbase:

go: finding module for package github.com/pocketbase/pocketbase/daos
go: finding module for package github.com/pocketbase/pocketbase/models
go: test imports
github.com/pluja/pocketbase tested by
github.com/pluja/pocketbase.test imports
github.com/pluja/pocketbase/migrations imports
github.com/pocketbase/pocketbase/daos: module github.com/pocketbase/pocketbase@latest found (v0.23.12), but does not contain package github.com/pocketbase/pocketbase/daos
go: test imports
github.com/pluja/pocketbase tested by
github.com/pluja/pocketbase.test imports
github.com/pluja/pocketbase/migrations imports
github.com/pocketbase/pocketbase/models: module github.com/pocketbase/pocketbase@latest found (v0.23.12), but does not contain package github.com/pocketbase/pocketbase/models

I have a project with a go module which has both these packages imported and it took me hours to figure out what was happening, I managed to fix the problem by removing all the tests and decided to create a PR for a temporary fix for other people depending on both packages, since currently a project with both packages cannot be upgraded to github.com/pocketbase/pocketbase v0.23.x

@CanGonenc The tests in master are passing when make test runs.
If I'm understanding you correctly, the issues you're reporting are:

This lib fails to install when go get -t is used
This lib breaks go mod tidy

Is that right?
If you have time, please open an issue and provide a minimal repo that reproduces the issue.
Meanwhile, I'll leave this PR open so people can see your solution but it won't be merged because disabling all the tests is not the solution :)


Have unique loadbalancer

What type of PR is this?
/kind feature

What this PR does / why we need it:
Not having two cluster with the same loadBalancer Name.
Closes #230
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #230
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:

[ ] squashed commits
[ ] includes documentation
[ ] adds unit tests

@outscale-hmi
The same as https://github.com/outscale/cluster-api-provider-outscale/pull/231


New icon

Hi Garret, I made an icon in the modern macOS style. If you like it let's replace the old one.

I ABSOLUTELY LOVE IT! Beautiful work on the bezel highlight!
If you'd like credit for the icon on the about screen or somewhere in the start app I'd be happy to oblige.

Cool! Credits like this would be great:

The icon itself
Auto Reload.icns.zip


[metrics] initialize hits/misses for each cache entry kind

This makes sure all hit/miss counters appear on the metrics endpoints and avoids having to fill missing metrics with zero at the client side.

This slipped off my radar, sorry for the delay. I added this to the master branch.


Adjust UI to Support Ontology 2.0

With ontology 2.0 the ui_profiles are extend with a context and the ui_profile details are no longer available when the backend endpoint entries/{nodeId} is called. Instead it only returns the ui-tree without additional ui_profile information such as the attribute or value definitions.
Example excerpt of the ui-tree for specimen
{
                    "context": {
                        "code": "Specimen",
                        "display": "Bioprobe",
                        "system": "fdpg.mii.cds",
                        "version": "1.0.0"
                    },
                    "display": "a.m. serum specimen",
                    "id": "7fd85c7a-577a-3adc-ede1-169fb82b7032",
                    "leaf": true,
                    "selectable": true,
                    "termCodes": [
                        {
                            "code": "442166002",
                            "display": "a.m. serum specimen",
                            "system": "http://snomed.info/sct",
                            "version": "http://snomed.info/sct/900000000000207008/version/20230430"
                        }
                    ]
                }

This means that additional information such as attributeDefinitions are not part of the tree anymore and there is an additional context which has to be considered.
Three things should be implemented
1. Add Context to internal data models
When reading the ui tree the context has to be added to the internal TerminologyEntry class
Note: Context has the same properties as the TerminologyCode class
Further double check that the fact that the ui_profile properties missing in the return value of entries/{nodeId}
does not destroy the building of the ui-tree in the UI.
2. Use Context when "Adding" or "Editing a criterion
When "Adding" or "Editing a criterion to load the appropriate ui_profile for it, a call to the backend endpoint: ui_profile has to be made.
This endpoint now expects not only the termcode but also the context information as follows:
ui_profile?system=<termcode-system-here>&code=<termcode-code-here>&version=<termcode-version-here>&context_system=<context-system-here>&context_code=<context-code-here>&context_version=<context-version-here>

Note: version in both cases is not a required parameter, but should be used if available.
3. Add Context to SQ - configurable via feature toggle
The Context information should be added to the SQ alongside the termcode for each criterion.
Therefore a Context should be added to the Criterion class.
Whether the context information is then sent to the backend or not should be configurable via a feature toggle in the config of the UI.
Hint: One class that could potentially be extended to make this configurable is the ApiTranslator.

Please note: The recent commit medizininformatik-initiative/feasibility-backend@2fbb207 introduced changes to the backend endpoints. Consequently, the frontend paths have been adjusted in commit 4461c55 to align with the updates.


Duplicated RepeatingFragments in Module name

Bug report
The check CompassCredoPlugin.Check.RepeatingFragments failed for this case Keyword.Schemas.Keyword which complies with the existing Compass convention (context is singular).

Hence, this check should verify the duplicated fragment for consecutive namespace only.
Invalid
Keyword.Keyword

Valid
Crawler.Keyword.Schemas.Keyword

Reported from @vnntsu IC

I still don't think that it is false positive 🤷♂

yeah as I think you mentioned @byhbt , if we want to change this implementation then the check name needs to also change because as per the name it's correct. I think you said "consecutively" or something

The compass mentions that the module name should not repeat fragments in a namespace. In the following case, the module name is a repeating fragment of namespaces.
Crawler.Keyword.Schemas.Keyword
# Namespace: Crawler.Keyword.Schemas
# Module name: Keyword

This is an expected behavior and not considered a false positive in my opinion.
I think we have two options to move forward to solve this issue, feel free to propose additional options.

Open RFC for the compass convention about using the plural or singular form for the context module
Open RFC for the compass convention to clarify whether should we allow repeating fragments for a non-consecutive namespace or not.

For me I prefer option 1, let me know your thoughts 💭


Changed behavior on how currency ISO code fields are added to SOQL qu…

…eries. It is now done dynamically depending on whether the sObject has the field rather than creating a whitelist of sObjects which do not support the field.

Much  better thanks!

Hello,
I've updated the library since this was pulled into the repo and it appears as though CurrencyIsoCode is not being added automatically as expected. Is anyone else seeing this behviour as well?

@tmowbrey best raise this as a defect issue then, worth investigating for sure.

@amarchbanks Much appreciated as custom metadata types don't have CurrencyIsoCode and the whitelist would never have worked in that use case

@cropredy this PR has been merged, i think your saying we need a new issue for this issue?

yes - a new issue is required here; I was kind of hoping @AMarchbanks would have spotted this and raised/fixed it


Guacamole app check in E2E

Resolves #1602
What is being addressed
We removed checking the Guacamole app in the tests due to the move to OAuth proxy. It turns out we can't really reach the Guacamole app within a test (by a reasonable investment) due to OAuth flow and the way the proxy works (there's a cookie involved).
But we really need to check the app is online (this bug could have been avoided)
How is this addressed

Bring back the check and confirm it redirects to the AAD authentication endpoint. This is at the very least says that the docker image was loaded successfully and the OAuth proxy is online.

/test-extended

/test-force-approve
There a failure with the airlock test but everything else passes:
https://github.com/microsoft/AzureTRE/actions/runs/2740605935/attempts/3

/test-force-approve


Fix for K8SPXC-824 Cluster may get into an unrecoverable state

Fix for K8SPXC-824: Cluster may get into an unrecoverable state with incomplete full crash
Without this fix, it is possible to get an operator-controlled cluster into a state where some pxc pod other than the first one to start is the most advanced node and is ready for bootstrap, but it's neither bootstrapped nor does it fall under the (automatic) recovery conditions.
To recover from such condition, one must counter-intuitively edit grastate.dat and set safe_to_bootstrap to 0. That results in cluster falling fully into crash recovery.
Full reproduction procedure is available in https://jira.percona.com/browse/K8SPXC-824
This change adds the following condition to a list of conditions checked before pxc container falls into crash recovery:

No primary component is found
AND grastate.dat file exists
AND safe_to_bootstrap is 1 in grastate.dat
AND there are other PXC pods out there.

If we remove the "AND there are other PXC pods out there", first pod to start would go into crash recovery. We don't want that. If the first pod to start will go up cleanly (example: pause and unpause), then primary component will be found during the init of other pods and the new added condition doesn't trigger.

Test name
Status

storage
passed

upgrade-haproxy
passed

haproxy
passed

scheduled-backup
passed

recreate
passed

scaling
passed

big-data
passed

self-healing
failed

scaling-proxysql
passed

restore-to-encrypted-cluster
passed

security-context
passed

upgrade-proxysql
passed

init-deploy
passed

demand-backup
passed

limits
passed

smart-update
passed

monitoring-2-0
passed

self-healing-chaos
failed

affinity
passed

one-pod
passed

self-healing-advanced
passed

auto-tuning
passed

pitr
passed

proxysql-sidecar-res-limits
passed

self-healing-advanced-chaos
failed

operator-self-healing
passed

users
passed

upgrade-consistency
passed

operator-self-healing-chaos
failed

demand-backup-encrypted-with-tls
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
failed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/992/commits/59ae26aa65b13be8a44e14059ddac7e86f05a431
image: perconalab/percona-xtradb-cluster-operator:PR-992-59ae26aa

Test name
Status

upgrade-haproxy
passed

scheduled-backup
passed

recreate
passed

haproxy
passed

storage
passed

restore-to-encrypted-cluster
passed

init-deploy
passed

self-healing
passed

limits
passed

demand-backup
passed

monitoring-2-0
passed

pitr
passed

affinity
passed

demand-backup-encrypted-with-tls
passed

one-pod
passed

scaling
passed

auto-tuning
passed

scaling-proxysql
passed

proxysql-sidecar-res-limits
passed

security-context
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

big-data
passed

validation-hook
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

self-healing-chaos
failed

self-healing-advanced
passed

self-healing-advanced-chaos
failed

operator-self-healing
passed

operator-self-healing-chaos
failed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/992/commits/59ae26aa65b13be8a44e14059ddac7e86f05a431
image: perconalab/percona-xtradb-cluster-operator:PR-992-59ae26aa

Test name
Status

scheduled-backup
failed

recreate
passed

storage
passed

big-data
passed

upgrade-haproxy
passed

scaling
passed

haproxy
passed

self-healing
passed

scaling-proxysql
passed

restore-to-encrypted-cluster
passed

security-context
passed

self-healing-chaos
passed

init-deploy
passed

demand-backup
passed

self-healing-advanced
passed

limits
passed

monitoring-2-0
passed

self-healing-advanced-chaos
passed

affinity
passed

one-pod
passed

pitr
passed

auto-tuning
passed

operator-self-healing
passed

proxysql-sidecar-res-limits
passed

users
passed

operator-self-healing-chaos
passed

demand-backup-encrypted-with-tls
failed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
failed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/992/commits/7ea333cf4b3604e59b2b633c57df842d77ec8c98
image: perconalab/percona-xtradb-cluster-operator:PR-992-7ea333cf

Test name
Status

storage
passed

self-healing
passed

self-healing-chaos
passed

self-healing-advanced
passed

self-healing-advanced-chaos
passed

operator-self-healing
passed

operator-self-healing-chaos
passed

scaling
passed

big-data
passed

scaling-proxysql
passed

security-context
passed

recreate
passed

upgrade-haproxy
passed

restore-to-encrypted-cluster
passed

demand-backup
passed

pitr
passed

demand-backup-encrypted-with-tls
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

scheduled-backup
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/992/commits/7ea333cf4b3604e59b2b633c57df842d77ec8c98
image: perconalab/percona-xtradb-cluster-operator:PR-992-7ea333cf


Include the Material Design Icon font

I'd be great to see our icons up on Fontello. :)
https://github.com/google/material-design-icons

https://github.com/fontello/fontello/wiki/How-to-suggest-font-to-fontello#how-to-prepare-a-font-for-use-with-fontello
Could you help to prepare this font? Need search aliases. ZIP file as described in Wiki will be enougth, i'll create then all repo things myself.

I have started to import at least 797 material design icons from Google's github page (the 48px SVG's). Could I seperate them into parts and you put it together afterwards?

@kristofzerbe Look into typical fontello's prepared fon repo https://github.com/fontello/brandico.font
I finally need config.yml file & src folder. In any format that can be processed by simple scipt without manual work.

@puzrin Hmm, as suggested on https://github.com/fontello/fontello/wiki/How-to-suggest-font-to-fontello#how-to-prepare-a-font-for-use-with-fontello I have to download the webfont as ZIP, but it doesn't include src folder or config.yml?

@kristofzerbe zip will be fine too. I'll convert it myself from config.json.

@puzrin I jave submitted a fontello font with at least 756 icons and created a new issue on that... :)

Wow, thanks Kristof!

Closing in flavour of #417

with at least 756 icons

@kristofzerbe does it means that more icons have to be added or something else?

We have 795 icons, so something does seem off


Mux tests should test HTTP response code in addition to response body

Update the testRequest helper or get rid of it altogether (I like this more - we might want to test for specific headers for example)

test request can return resp headers.. or, make another method similar that also returns header.


Add tips

README could have other tips like minimizing number of add-on packages.

And to use releases


Customizing serialization at the property/field level

I've looked over the source of FullSerializer but I'm struggling to find a way to customize serialization at the field/property level.  My use case is properties that should only be serialized if they are NOT at the default value. For example, skipping serialization of Unity Vector3 if vector == Vector3.zero.  Classes that take responsibility for default value initialization can benefit from not having to write out verbose JSON for default values.
FullSerializer converters are specified at the class level so I don't see a way to define a converter just for a specific Vector property using an attribute.
An attribute specified converter at the property level would be ideal but something similar to Json.NET's 'ShouldSerialize' would work too.  http://www.newtonsoft.com/json/help/html/ConditionalProperties.htm
Any ideas would be helpful.  I don't mind getting my hands dirty.  Thanks.

Sure, here is roughly how I'd implement it. There are only a few required modifications.
Usage
class Model {
    [fsProperty(ShouldSerialize="CheckMember")]
    public int Member;
    bool CheckMember() { return member % 2 == 0; }
}

fsConfig.SerializeDefaultValues = false;

Implementation
For implementation, there are two primary areas that you should check: the reflected converter and AOT generated converters. Luckily it is simple in both scenarios:
For the reflected converter, see here.
For the AOT compiled converters, they all reference a common SerializeMember function. You should modify it so that it only emits data if it should, ie, it should read something like:
protected fsResult SerializeMember<T>(Dictionary<string, fsData> data, string name, T value) {
    // should we skip serialization?
    // TODO: is default(T) how we actually want to get the default value? What about arrays/lists/collections?
    // TODO: There should be no reflection in this method. For the ShouldSerialize method,
    //       the AOT generator should be modified so it will invoke the method before calling
    //       SerializeMember
    if (value == default(T)) return fsResult.Success; // skip serialization

    // below: the existing method
    fsData memberData;
    var result = Serializer.TrySerialize(typeof(T), value, out memberData);
    if (result.Succeeded) data[name] = memberData;
    return result;
}

The AOT generation is done here, and the conditional check should be emitted around here.
Then there is also the issue of serializing default values inside of collections - should the following list be serialized? [0, 0, 0, 0]. I think this is a scenario where default serialization will skip only the empty collection, ie, []. Anything beyond that can be handled by the ShouldSerialize user-defined method.
Make sure to cache the reflection computations inside of fsMetaType and/or fsMetaProperty.

Thanks for the detailed insights. Good stuff!
My first choice would be an attribute based system that allowed custom converters at the property level since that is more declarative and reusable but maybe that just isn't feasible. I'm going to let this percolate a few days, maybe some of the other repo watchers will chime in.  For now, I'm hung up on making sure the serialization process doesn't emit metadata when I don't expect it. I'll post some test cases in the existing issue.

An additional scenario this system should handle is
public class Model {
    [fsProperty(DoNotEmitTypeMetadata = true)]
    public object Member;
}

(see some of the comments in #24)

Link is broken, I need this...


Customize Array.swapAt to pass down to the buffer.

It looks like we aren't dropping the retain/release when using the default
implementation from MutableCollection; buffers do this swap with moves.

@swift-ci Please benchmark

Performance: -O

Regression
OLD
NEW
DELTA
RATIO

RandomShuffleLCG2
368
2656
+621.7%
0.14x

RemoveWhereSwapInts
32
227
+609.4%
0.14x

RemoveWhereQuadraticString
244
300
+23.0%
0.81x

RemoveWhereQuadraticInts
483
592
+22.6%
0.82x

RandomShuffleDef2
1512
1704
+12.7%
0.89x (?)

DataToStringEmpty
450
500
+11.1%
0.90x (?)

UTF8Decode_InitFromBytes
130
143
+10.0%
0.91x (?)

RemoveWhereQuadraticStrings
1146
1255
+9.5%
0.91x (?)

UTF8Decode_InitFromData
121
132
+9.1%
0.92x (?)

Improvement
OLD
NEW
DELTA
RATIO

ReversedDictionary2
261
213
-18.4%
1.23x

RemoveWhereSwapStrings
433
381
-12.0%
1.14x (?)

DataAppendDataSmallToSmall
3200
2920
-8.7%
1.10x (?)

Code size: -O

Improvement
OLD
NEW
DELTA
RATIO

RandomShuffle.o
3511
3241
-7.7%
1.08x

RemoveWhere.o
24207
22599
-6.6%
1.07x

SortIntPyramids.o
11955
11675
-2.3%
1.02x

ReversedCollections.o
10750
10563
-1.7%
1.02x

Performance: -Osize

Regression
OLD
NEW
DELTA
RATIO

RemoveWhereSwapInts
33
223
+575.7%
0.15x

RandomShuffleLCG2
400
2672
+568.0%
0.15x

RemoveWhereQuadraticString
245
300
+22.4%
0.82x

RemoveWhereQuadraticInts
487
593
+21.8%
0.82x

RandomShuffleDef2
1512
1708
+13.0%
0.89x

CharIteration_ascii_unicodeScalars
1680
1880
+11.9%
0.89x

CharIteration_tweet_unicodeScalars
3360
3720
+10.7%
0.90x (?)

CharIteration_punctuated_unicodeScalars
400
440
+10.0%
0.91x (?)

RemoveWhereQuadraticStrings
1132
1239
+9.5%
0.91x (?)

UTF8Decode_InitFromData
121
131
+8.3%
0.92x (?)

Improvement
OLD
NEW
DELTA
RATIO

RemoveWhereSwapStrings
430
380
-11.6%
1.13x

ReversedDictionary2
239
217
-9.2%
1.10x (?)

CharIteration_tweet_unicodeScalars_Backwards
5680
5280
-7.0%
1.08x (?)

Code size: -Osize

Improvement
OLD
NEW
DELTA
RATIO

RandomShuffle.o
3677
3317
-9.8%
1.11x

RemoveWhere.o
23687
21911
-7.5%
1.08x

ReversedCollections.o
8799
8633
-1.9%
1.02x

SortIntPyramids.o
12013
11797
-1.8%
1.02x

Breadcrumbs.o
43441
42929
-1.2%
1.01x

Performance: -Onone

Regression
OLD
NEW
DELTA
RATIO

ArrayOfGenericPOD2
714
836
+17.1%
0.85x (?)

UTF8Decode_InitFromBytes
134
145
+8.2%
0.92x (?)

UTF8Decode_InitFromData
122
132
+8.2%
0.92x (?)

Improvement
OLD
NEW
DELTA
RATIO

RandomShuffleLCG2
40208
19328
-51.9%
2.08x

RandomShuffleDef2
5556
3496
-37.1%
1.59x

RemoveWhereSwapStrings
6807
4594
-32.5%
1.48x

RemoveWhereSwapInts
5813
4063
-30.1%
1.43x

ParseInt.Small.Decimal
9677
9041
-6.6%
1.07x (?)

Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@swift-ci Please benchmark

Build failed before running benchmark.

@swift-ci Please benchmark

Performance: -O

Regression
OLD
NEW
DELTA
RATIO

FlattenListFlatMap
4060
5893
+45.1%
0.69x (?)

FlattenListLoop
2357
2840
+20.5%
0.83x (?)

PrefixWhileAnySeqCntRangeLazy
34
40
+17.6%
0.85x (?)

CharIteration_punctuatedJapanese_unicodeScalars_Backwards
640
720
+12.5%
0.89x (?)

CharIndexing_punctuatedJapanese_unicodeScalars_Backwards
640
720
+12.5%
0.89x (?)

Improvement
OLD
NEW
DELTA
RATIO

RandomShuffleLCG2
368
112
-69.6%
3.29x

RemoveWhereSwapInts
32
20
-37.5%
1.60x

CharIteration_tweet_unicodeScalars_Backwards
5960
5160
-13.4%
1.16x

StringFromLongWholeSubstring
8
7
-12.5%
1.14x (?)

CharIteration_punctuated_unicodeScalars_Backwards
680
600
-11.8%
1.13x (?)

CharIndexing_ascii_unicodeScalars_Backwards
2880
2600
-9.7%
1.11x (?)

CharIteration_ascii_unicodeScalars_Backwards
2880
2600
-9.7%
1.11x

MapReduce
217
196
-9.7%
1.11x (?)

CharIndexing_tweet_unicodeScalars_Backwards
5680
5160
-9.2%
1.10x (?)

CharIteration_punctuated_unicodeScalars
440
400
-9.1%
1.10x (?)

DistinctClassFieldAccesses
196
179
-8.7%
1.09x

CharIteration_ascii_unicodeScalars
1880
1720
-8.5%
1.09x (?)

CharIteration_punctuatedJapanese_unicodeScalars
480
440
-8.3%
1.09x (?)

CharIteration_tweet_unicodeScalars
3720
3440
-7.5%
1.08x (?)

Hanoi
2200
2040
-7.3%
1.08x (?)

Code size: -O

Regression
OLD
NEW
DELTA
RATIO

ReversedCollections.o
10750
11994
+11.6%
0.90x

RandomShuffle.o
3511
3890
+10.8%
0.90x

ExistentialPerformance.o
46241
47673
+3.1%
0.97x

StringWalk.o
39215
39983
+2.0%
0.98x

Improvement
OLD
NEW
DELTA
RATIO

RemoveWhere.o
24207
23151
-4.4%
1.05x

Breadcrumbs.o
44482
43058
-3.2%
1.03x

Performance: -Osize

Regression
OLD
NEW
DELTA
RATIO

ObjectiveCBridgeStubFromNSStringRef
83
94
+13.3%
0.88x (?)

CharIteration_ascii_unicodeScalars
1680
1880
+11.9%
0.89x (?)

RemoveWhereMoveInts
18
20
+11.1%
0.90x (?)

CharIteration_tweet_unicodeScalars
3360
3720
+10.7%
0.90x (?)

CharIteration_punctuated_unicodeScalars
400
440
+10.0%
0.91x (?)

CharIteration_utf16_unicodeScalars
2440
2680
+9.8%
0.91x (?)

SortLettersInPlace
379
415
+9.5%
0.91x (?)

Improvement
OLD
NEW
DELTA
RATIO

RandomShuffleLCG2
400
112
-72.0%
3.57x

RemoveWhereSwapInts
33
19
-42.4%
1.74x

Set.isDisjoint.Seq.Box.Empty
93
83
-10.8%
1.12x (?)

ArrayLiteral2
109
98
-10.1%
1.11x (?)

DistinctClassFieldAccesses
191
173
-9.4%
1.10x (?)

MapReduce
238
217
-8.8%
1.10x (?)

Set.isSubset.Seq.Int.Empty
122
113
-7.4%
1.08x (?)

DropFirstCountableRangeLazy
15
14
-6.7%
1.07x (?)

Code size: -Osize

Regression
OLD
NEW
DELTA
RATIO

ReversedCollections.o
8799
10061
+14.3%
0.87x

RandomShuffle.o
3677
4063
+10.5%
0.90x

ExistentialPerformance.o
36689
38193
+4.1%
0.96x

StringWalk.o
34263
35097
+2.4%
0.98x

Improvement
OLD
NEW
DELTA
RATIO

RemoveWhere.o
23687
22395
-5.5%
1.06x

Breadcrumbs.o
43441
41837
-3.7%
1.04x

Performance: -Onone

Regression
OLD
NEW
DELTA
RATIO

RemoveWhereSwapStrings
6800
7433
+9.3%
0.91x

Improvement
OLD
NEW
DELTA
RATIO

NopDeinit
126200
115700
-8.3%
1.09x (?)

ExclusivityGlobal
113
104
-8.0%
1.09x (?)

Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@swift-ci Please benchmark

Performance: -O

Regression
OLD
NEW
DELTA
RATIO

FlattenListLoop
2256
2827
+25.3%
0.80x (?)

CharIndexing_punctuatedJapanese_unicodeScalars_Backwards
640
720
+12.5%
0.89x (?)

DataToStringEmpty
450
500
+11.1%
0.90x (?)

FlattenListFlatMap
3756
4089
+8.9%
0.92x (?)

PrefixWhileAnySeqCntRangeLazy
34
37
+8.8%
0.92x (?)

Improvement
OLD
NEW
DELTA
RATIO

RandomShuffleLCG2
368
112
-69.6%
3.29x

RemoveWhereSwapInts
32
20
-37.5%
1.60x (?)

CharIndexing_tweet_unicodeScalars_Backwards
5960
5160
-13.4%
1.16x (?)

CharIndexing_ascii_unicodeScalars_Backwards
2880
2560
-11.1%
1.12x (?)

CharIteration_ascii_unicodeScalars_Backwards
2880
2600
-9.7%
1.11x

MapReduce
216
196
-9.3%
1.10x (?)

DistinctClassFieldAccesses
196
178
-9.2%
1.10x (?)

CharIteration_tweet_unicodeScalars_Backwards
5680
5160
-9.2%
1.10x

CharIteration_ascii_unicodeScalars
1880
1720
-8.5%
1.09x (?)

CharIteration_punctuatedJapanese_unicodeScalars
480
440
-8.3%
1.09x (?)

CharIteration_tweet_unicodeScalars
3720
3440
-7.5%
1.08x (?)

Hanoi
2200
2040
-7.3%
1.08x (?)

Code size: -O

Regression
OLD
NEW
DELTA
RATIO

ReversedCollections.o
10750
11994
+11.6%
0.90x

RandomShuffle.o
3511
3890
+10.8%
0.90x

ExistentialPerformance.o
46241
47673
+3.1%
0.97x

StringWalk.o
39215
39983
+2.0%
0.98x

Improvement
OLD
NEW
DELTA
RATIO

RemoveWhere.o
24207
23151
-4.4%
1.05x

Breadcrumbs.o
44482
43058
-3.2%
1.03x

Performance: -Osize

Regression
OLD
NEW
DELTA
RATIO

RemoveWhereMoveInts
18
20
+11.1%
0.90x (?)

CharIteration_tweet_unicodeScalars
3360
3720
+10.7%
0.90x (?)

CharIteration_utf16_unicodeScalars
2440
2640
+8.2%
0.92x (?)

Improvement
OLD
NEW
DELTA
RATIO

RandomShuffleLCG2
400
112
-72.0%
3.57x

RemoveWhereSwapInts
33
19
-42.4%
1.74x

Set.isDisjoint.Seq.Box.Empty
93
82
-11.8%
1.13x

ArrayLiteral2
112
99
-11.6%
1.13x (?)

DropWhileAnySeqCRangeIterLazy
157
139
-11.5%
1.13x (?)

Set.isStrictSubset.Int.Empty
50
45
-10.0%
1.11x (?)

MapReduce
238
217
-8.8%
1.10x (?)

DistinctClassFieldAccesses
189
173
-8.5%
1.09x (?)

Set.isSubset.Seq.Int.Empty
122
113
-7.4%
1.08x (?)

CharIteration_tweet_unicodeScalars_Backwards
5720
5320
-7.0%
1.08x (?)

Code size: -Osize

Regression
OLD
NEW
DELTA
RATIO

ReversedCollections.o
8799
10061
+14.3%
0.87x

RandomShuffle.o
3677
4063
+10.5%
0.90x

ExistentialPerformance.o
36689
38193
+4.1%
0.96x

StringWalk.o
34263
35097
+2.4%
0.98x

Improvement
OLD
NEW
DELTA
RATIO

RemoveWhere.o
23687
22395
-5.5%
1.06x

Breadcrumbs.o
43441
41837
-3.7%
1.04x

Performance: -Onone

Regression
OLD
NEW
DELTA
RATIO

RemoveWhereSwapStrings
6778
7432
+9.6%
0.91x (?)

Improvement
OLD
NEW
DELTA
RATIO

NopDeinit
126500
115700
-8.5%
1.09x (?)

ExclusivityGlobal
113
104
-8.0%
1.09x (?)

ArrayInClass
2505
2340
-6.6%
1.07x (?)

Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@natecook1000 can you show me the SIL for the rr you are talking about?

Can one of the admins verify this patch?

I don't think this is doing what I thought it was doing.


How to ignore #ifdef and #endif in images

such as:

How to ignore #ifdef and #endif in images ？

Diff cover works from the underlying report. So the way to get diff cover to ignore it is to get your coverage tool to ignore it when generating it's report.


Android issue on Windows

My project build success in Mac machine, but in Windows with Android Studio it got issue like this
OS: Windows 10
React-Native: 0.59.3
Android Studio: 3.3.2
error: cannot find symbol method metafactory(Lookup,String,MethodType,MethodType,MethodHandle,MethodType)

Does enabling Java 8 support in Gradle fix the problem?

Does enabling Java 8 support in Gradle fix the problem?

It doesnt work


Typo in action enum DiagnosticsStatusNotification

In ocpp/v16/enums.py on line 11:
 DiagnosticStatusNotification = "DiagnosticStatusNotification"
It should be
DiagnosticsStatusNotification = "DiagnosticsStatusNotification"
(Diagnostics instead of Diagnostic). This is validated by the naming of the respective json schema in ocpp/v16/schemas/
The same error occurs in  ocpp/v16/call_result.py on line 35:
class DiagnosticsStatusNotificationPayload:
and in ocpp/v16/call.py on line 158:
class DiagnosticsStatusNotificationPayload:
The latter causes an error in a call, as the call action gets parsed from the payload class name (ocpp/v16/charge_point.py, line 238):
action=payload.__class__.__name__[:-7],
Schema DiagnosticStatusNotification.json doesn't exist which causes a ValidationError in ocpp\messages.py", line 85, in validate_payload:
ocpp.exceptions.ValidationError: Failed to load validation schema for action 'DiagnosticStatusNotification': [Errno 2] No such file or directory: '.../ocpp/v16/schemas/DiagnosticStatusNotification.json'

Thanks for reporting this issue!
I have a PR up to fix the typo in DiagnosticsStatusNotification.
But I don't understand what is wrong with FirmwareStatusNotificationPayload, could you elaborate?

So sorry, I of course meant DiagnosticsStatusNotificationPayload. I went ahead and updated my issue description. Thanks for the quick response.

Thanks for the quick resolution of the issue.
I am currently working on integrating this library in a charging station.
Do you have a process/policy for contributing to this project should I have further suggestions, or is opening issues the preferred way for you?


Refactor LocationManager provider

Updated createLocationManagerMockProvider method to use getProviderProperties for API level 31 and above.
Added runtime API level checks to ensure backward compatibility with API levels below 31.
Removed dependency on LocationProvider in the calling method.
Handled null cases for provider name and provider properties.
Ensured compatibility and adherence to modern Android best practices.

@mykola-mokhnach , I see the install dependencies failed.
Should I add the below elsewhere?
import android.location.provider.ProviderProperties;

For the lint error, it can have @SuppressLint("MissingPermission") for now I think

It looks like Method getAnimationScales = windowManagerClass.getDeclaredMethod("getAnimationScales"); may raise an error for target api level 31 as https://developer.android.com/guide/app-compatibility/restrictions-non-sdk-interfaces
It looks like the animation command usage is only for lower than API level 26 https://github.com/appium/appium-uiautomator2-driver/blob/4cd489aa9a282f412ee45e1366c86bf7e580c798/lib/driver.ts#L594-L597
Espresso actually uses this method but I think espresso server also can follow the --no-window-animation. Then we can completely drop this animation command in settings.
We could add an annotation for @SuppressLint("SoonBlockedPrivateApi" to ignore this error I believe. We disable https://developer.android.com/guide/app-compatibility/restrictions-non-sdk-interfaces with hidden policy settings command call, but some devices may not allow to apply the hidden policy. So... I think it would be nice to drop lower Android OS version first, and remove animation command via settings app, then apply this change to settings.

lg, but please wait for https://github.com/appium/appium-espresso-driver/pull/1007 so that we can safely apply the animation related change for lower os versions only


Stuck loading

Describe the bug
I had to reload  page after the ai builder getting stuck.  Now the app won't load
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-c2k46f
Steps to reproduce
go to open the app
Expected behavior
stuck installing dependencies
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 111110477,
  "usedJSHeapSize": 105634905,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = EatRiteAi
Chat ID = 355517b5b9fe

Additional context
No response

Appreciate the feedback! We are aware of this issue and are tracking it here: #2021


Using Kubeadm

First of all, congratulation for the great work.
I was looking for a project like this to bootstrap a k8s cluster on hetzner cloud with support for csi and ccm and this looks great.
However I am used to working with kubeadm (through kubespray) which seems better suited for production use and heavy workload.
Are you planning to add support for kubeadm ? (I understand automatic upgrades might be more difficult to implement).

Hello @yelhouti, I understand your concern, but trust me when I tell you that k3s is definitely suited for production and heavy workloads. It basically shares the exact same source with a few adjustments and is constantly synced with upstream Kubernetes, probably on a daily if not hourly basis.
This explanatory video will make everything clear: https://youtu.be/FmLna7tHDRc. There is absolutely no reason why not use k3s instead of kubeadm, even if you go planetary scale. It's the same codebase, just packaged differently, more optimized, and more agile (much simpler upgrades).

However, if you want, you could replace the MicroOS image with one that contains Kubeadm installed already. So it which case you would need to rebuild a similar project, but you could definitely reuse the host module here https://github.com/kube-hetzner/kube-hetzner/tree/master/modules/host.
This is the MicrosOS we use today:
https://github.com/kube-hetzner/kube-hetzner/blob/master/modules/host/main.tf#L51
However, you could replace the image with openSUSE-MicroOS.x86_64-Kubic-kubeadm-OpenStack-Cloud.
IMHO, definitely not needed! :)

Btw, https://www.civo.com/, which serves companies like Walmart and Verizon, runs its operation entirely on k3s.

@mysticaltech thanks a lot for all the feedback :)


Add synonyms field in dialect object

Pre-Submission Checklist

You have only one commit (if not, squash them into one commit).
All new and existing tests pass the command yarn test and yarn lint.

Description
The PR come from the discussion about use of synonyms in dialects in ISSUE #82. The changes are:

Add only carioques synonyms, because I'm from Rio de Janeiro :)
Add dialect object structure in README, marking the synonyms as optional

Thanks, @emanuelgsouza for contributing


Google OAuth2 with service account scenario (2LO OAuth2)

With this PR come next changes:

for google-mail component realised Google OAuth2 for service account.
google-specific libraries for camel-google-mail maven module updated.
It was necessary while methods com.google.api.client.googleapis.auth.oauth2.GoogleCredential.createDelegated(String) (google-api-client) and com.google.common.io.ByteStreams.exhaust(InputStream) (guava) not exist in used dependencies.

Functionality of changes is in CAMEL-17476 written.

I think there is still some work to do on the keyResource to be done.

Ready to merge.
@bvfalcon we have other components in the Google eco-system and they might need some help/improvements. If you have time, it would be nice if you take a look. Thanks


Add support for mistral

Codecov Report
Attention: Patch coverage is 83.33333% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 94.56%. Comparing base (840c055) to head (198f165).
Report is 8 commits behind head on main.

Files
Patch %
Lines

...aviate/collections/classes/config_named_vectors.py
66.66%
1 Missing :warning:

weaviate/collections/classes/config_vectorizers.py
87.50%
1 Missing :warning:

weaviate/connect/integrations.py
85.71%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1057      +/-   ##
==========================================
- Coverage   94.63%   94.56%   -0.07%
==========================================
  Files         181      181
  Lines       18747    18765      +18
==========================================
+ Hits        17742    17746       +4
- Misses       1005     1019      +14

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Can not find the paper

Hello, I'm a graduate student ,from NTUST(at Taiwan) ,who wants to study transformer.
But I can not find the paper you mentioned "SigT: An Efficient End-to-End MIMO-OFDM Receiver Framework Based on Transformer".
Can you please supply this paper or any help?
It will be very helpful.
best redards.

Hello @kartg0031139
You can find the paper by using this link: https://arxiv.org/pdf/2211.09712.pdf


Subaccount not being sent

Hi, I noticed that my subaccounts are not being sent in the payload, please what could i be doing wrong?

Been able to fix the charge_type and charged issue


Missing ability to redirect to content item from Orchard.Users.

Missing the ability to redirect back to an admin content item from Admin-User-Edit using redirectUrl in querystring.
Orchard.Users module has an alternate for Content.Edit.cshtml shape (Content-User.Edit.cshtml) which does not included the following:
@if (!String.IsNullOrWhiteSpace(Request.QueryString["returnUrl"])) {     @Html.Hidden("returnUrl", Request.QueryString["returnUrl"]) }

Is it viable to remove the Orchard.Users alternate 'Content-User.Edit.cshtml'?
Or should the above line be simply added to the 'Content-User.Edit.cshtml' alternate?

Out of the two choices I think the line should be added. The alternate view has a different layout to its original, I'm not sure what it's for though as it is structurally quite similar.
However, this is just masking the real issue. As mentioned in #3447 the return url should be in the querystring.
There are some helper methods around here somewhere that create these for you automatically I think.
Something like this: https://github.com/OrchardCMS/OrchardDoc/issues/250

Thanks rptHarry for the reply.  I agree that the second choice is less invasive and is more than likely the way to go.  When viewing the two different files there was very little difference and I wondered was this simple something that was left over from an older version of the system.  In which case removing the file altogether would be the way to go.
Regards providing the URL in the querystring, I am already doing this using the helper @Html.ItemEditLinkWithReturnUrl(T("Edit").Text, contentItem).  The issue is that without the hidden returnUrl html field the querystring is not carried over when saving the content item.


Created a sub-page for Open Educational Resource page

-created a new folder for the sub-pages for easy accessibility and readability

I linked the sub-page to open educational resource
I added a summary of open educational resources and also added a link to understand the topic better
I added an iframe to embed my YouTube video

Wonderful work @mutmainaho, a few things to add:

You should make space between the footer and the video.
You have to add an illustration with alternative tags
Add more resources to read about the topic in a new section called "resources"

We want each page to introduce novice learners to the topic in the easiest way possible, so add resources where they can read more about the topic.
Also, explain how would you improve the website further?

Hi @BatoolMM Thanks for the feedback, would work on them soon and send in an updated PR

Hi @mutmainaho, I'm just wondering if there is any update on your PR.

Thank you Mutmainah for your coding work. I'm closing this PR now but feel free to reopen it later if you have any updates. Let's add @mutmainaho for her contributions. cc @all-contributors

@all-contributors please add @mutmainaho for code.


matrix-synapse: relax build dependencies

Description of changes
After https://github.com/NixOS/nixpkgs/pull/248866 was committed, matrix-synapse needs to relax its build dependency constraint on poetry-core. Per upstream:
# The upper bounds here are defensive, intended to prevent situations like
# #13849 and #14079 where we see buildtime or runtime errors caused by build
# system changes.
# We are happy to raise these upper bounds upon request,
# provided we check that it's safe to do so (i.e. that CI passes).

These upper bounds are restrictive on purpose, and so I felt it was appropriate inside nixpkgs to patch out the constraint in postPatch using sed.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build matrix-synapse

Merging into staging-next since contributors are already finding these errors, and I'd like to make their lives easier.


Added error handling to display page

Closes #727

Coverage decreased (-0.2%) to 85.482% when pulling 391b61beb1f245cae744d19541f0a8ade69c1504 on eatonphil:display-form-validation into ed78b9b1eae93106e4e816675b698db89391eefa on linode:master.

Closing to make a PR directly against layout updates

Coverage decreased (-0.2%) to 85.489% when pulling b07badd0e7b045fe5fcc8786e344782848292815 on eatonphil:display-form-validation into ed78b9b1eae93106e4e816675b698db89391eefa on linode:master.


kernel: Always support GNU-style constructors in Zephyr

GNU-style constructors are supported for both C and C++, so move all of the support for this out of cpp and into the common kernel directory.
Fixes #74659
Fixes #74601
See #74682

Ok, I added a check in the linker script which will fail the build if the application wants to use constructors but the option to include the code to call them is disabled. With that, users can "safely" disable constructors, knowing that they won't accidentally end up needing this option.

It looks like GNU-style constructors are not supported by CMAKE_LINKER_GENERATOR, so I've disabled constructors when that is enabled. Builds using C++ and the generator used to fail because the symbols required for the runtime code were not available. Now they will fail only if they use constructors due to the checks described above.

Changes looks fine to me. Just wondering if this shouldn't be disabled by default.

That's a fine question. Now that the linker will generate an error if you need this option, we could safely disable it by default.
I think we could also make this "zero cost" by appending all of the constructors and initializers to the POST_KERNEL init level array in the linker. There's absolutely no reason to split these out, and that way we could remove a bunch of extra code and configuration bits. Let me try that.

ok, fixed constructor priority problems (need to use SORT_BY_INIT_PRIORITY in the linker script). I also merged the ctors and init_array stuff -- different ABIs seem to use different section names, but the contents are compatible, so there's no reason to split them out. With that, the overhead for including GNU constructor support is down to 24 bytes on cortex-m0. I'd still consider disabling this all by default as the linker will throw an error if you need it.

It's a bit of a weird situation to have a PR forked from another PR and both in review simultaneously.

Yeah, we both pushed PRs at about the same time (I noticed yours while submitting mine). In any case, how about we figure out what code we want and get it into your PR and I'll close this one? The key changes I've made today are:

Merge ctors and init_array into a single list. There's no reason to have them split; the ctors section is used in some ABIs while init_array is used in others. The glibc ctors implementation isn't relevant to us as we have our own, so we don't need the count and null-termination entries. The result is a smaller implementation: 24 bytes on cortex-m0, down from 74 bytes.
Fix constructor priority handling -- you need to insert the constructors with priority value ahead of those without, and they need to be inserted in priority order using the linker SORT_BY_INIT_PRIORITY function.

In any case, how about we figure out what code we want and get it into your PR and I'll close this one?

Let's do that. I'll take your latest changes into my PR tomorrow (its early night here already)

I'll rebase this on top of main once #74682 is merged and leave it until after 3.7 is finished.

I've recreated this PR as a simplification of the existing constructor implementation; this can wait to be merged after the release.

This looks good to me. Is it already covered in a different branch

This looks good to me. Is it already covered in a different branch

I'm not sure which branch that would be -- #74682 fixed the bugs with this stuff; this patch is just a cleanup making things simpler -- merging .ctors/.init_array into a single form and unifying ARC MDWT support. The result is a bunch of code savings in both source and binary, but the semantics should be equivalent.

@keith-packard coming back to this?

Thanks for the reminder; I've been busy with picolibc recently and haven't been monitoring my zephyr PRs. I've rebased and pushed; it should 'just work' still; there weren't even any conflicts (!).

Ok, this is ready for review now.

Ok, I re-jiggered the constructor selection so that the native C library will run all of them when CONFIG_NATIVE_APPLICATION is selected. Otherwise, Zephyr runs them all. I think that's right? You mentioned something about CPP being relevant, but I couldn't find where the old code had that condition; maybe it's elsewhere in Kconfig?

As mentioned here https://github.com/zephyrproject-rtos/zephyr/pull/74700#discussion_r1729387814, setting DNM until @ruuddw or @evgeniy-paltsev confirm it works with the arc MWDT. Either of you feel free to remove it when you do. Or somebody else if you strongly disagree about waiting for that.

As mentioned here #74700 (comment), setting DNM until @ruuddw or @evgeniy-paltsev confirm it works with the arc MWDT. Either of you feel free to remove it when you do. Or somebody else if you strongly disagree about waiting for that.

I definitely agree with this plan -- if we're going to clean up this code, we should clean it up everywhere instead of leaving one architecture behind.

With the recent changes C++ aplications can't be build with MWDT toolchain:
lldac: error: duplicate symbol: __cxa_atexit
>>> defined at arcmwdt-dtr-stubs.c:16 (/verification_workspace/zephyr/arch/arc/arcmwdt/arcmwdt-dtr-stubs.c:16)
>>>            arcmwdt-dtr-stubs.c.obj:(__cxa_atexit) in archive zephyr/libzephyr.a
>>> defined at cpp_dtors.c:41 (/verification_workspace/zephyr/lib/cpp/abi/cpp_dtors.c:41)
>>>            cpp_dtors.c.obj:(.text.__cxa_atexit+0x0) in archive zephyr/libzephyr.a

The fix should be trivial, though - to remove __cxa_atexit implementation from arcmwdt-dtr-stubs.c and always use the one from lib/cpp/abi/cpp_dtors.c

The fix should be trivial, though - to remove __cxa_atexit implementation from arcmwdt-dtr-stubs.c and always use the one from lib/cpp/abi/cpp_dtors.c

This doesn't seem to have anything to do with the current state of this series. Are you suggesting that we add that change to this series? Does the rest of this series work on MWDT, and if so, would you approve it with this additional change?

cpp_dtors.c also defines __dso_handle. Should that also be removed from arcmwdt-dtr-stubs.c?


start: cleanup nav

In preparation for https://github.com/iterative/dvc.org/issues/3678

Also, I made a separate PR to update all the links to keep this PR lean. PTAL: https://github.com/iterative/dvc.org/pull/3942

Preview link https://dvc-org-start-cleanup-d780abpa.herokuapp.com/doc (not working here for some reason)

Preview link https://dvc-org-start-cleanup-d780abpa.herokuapp.com/doc (not working here for some reason

Something with Heroku's SSL certs proabbly. You can chose to "visit unsafe site" manually:

Let's not mix many things at once

Sorry @shcheklein, not sure what you mean. This is a nav cleanup with 2 URL changes. Should I make a PR for each one?

e.g. data pipelines - we actually go with Pipeline now

In the user guide yes but in Get Started the title is already Data Pipelines, this PR just fixed the URL so it reflects the title. We can change the title if preferred but that would be a separate change IMO. Let's discuss including that in https://github.com/iterative/dvc.org/pull/3943 ?

We can change it, but that would be a separate change IMO.

Or I can return the file to pipelines.md and update the title to just Pipelines as well. Either route works for me as long as they're consistent. Regardless, it's a change (perhaps larger).
Lmk please!

@jorgeorpinel okay, I see I got confused since it also cleanups a lot of stuff along the way ... if this doesn't break any then LGTM ;)

I did include other closely related goals (to my ming). 3 in total. It's def. not easy to understand just from the diff which is why I left comments (1, 2, 3). Glad it's clearer now. Thanks!


ETA's, Formating

Take a look at what I've worked on and let me know what you think. I did implement that other API for the ETA's because I couldn't figure out where he was getting them from. I need to monitor the busses on PassioGo and check them against these estimates sometime. Docstrings for what I added will need to be added in the future.

Thanks for the Pull Request! Could you split Caching (#14 ) as a separate PR? It's a feature that requires further testing and isn't quite ready to be released with 0.3.0.
The formatting and ETA stuff look great at a glance!

Alright I have removed caching to another pull, and eta's now come straight from Passio. I feel like there's a better solution for how I generate the unix timestamps as there are tons of edge cases to consider. The 'etaR' field of each bus seems to hold a better formatted version of the eta, perhaps that could be used in some way.

It looks like etaR is the minutes until the bus arrives and secondsSpent gives the actual estimation in seconds. I think the method should only return the latter.
With regards to the Stop object, a single stop is frequently part of multiple routes, which PassioGo doesn't specify when fetching each stop.

You're right, I attend a university that uses this system and still forgot that a stop can have multiple routes. So we should really be looking at secondsSpent, and just return that. I do hope to figure out how to specify what Vehicle will be arriving to a Stop next and conversely what Stop a Vehicle will be at next, at least that was what I was hoping to get for the project I'm using this in.

No worries, I appreciate the help!
The Stop.getEtas() method could return a list of tuples such as [(secondsUntilArrival, <Vehicle>), (...,...),...] which would (through the Vehicle object) give us route information.
What was the intended purpose of your Vehicle.getEtas() method?
I don't think getting a vehicle's next stop is natively supported by PassioGo's API, but it doesn't seem to be impossible. Feel free to open an issue for it!
I would greatly appreciate it if you could add docstrings to as many of the new functions you're writing to make collaboration easier. Thanks!

Vehicle.getEtas() was intended to allow you to see what Stop a specific bus would be at next, but I suppose that information is less useful. I implemented it by iterating through the API calls for every Stop eta in the System, then pulling only those that matched to the Vehicle.id. I can remove that for now.
To confirm, your idea for Stop.getEtas() replaces the need for the Stop to store the Route objects it's a part of?

As of right now, it's not necessary to have the Stop object store a list of Route objects, but that's something you can work on for a future feature if you would like!
We could make Stop.getEtas() take a boolean argument returnInUTC=False which determines whether it returns the number of seconds remaining or the estimated time of arrival in UTC.

Yeah I didn't think so either, I just wanted to make sure I understood. I'll add the Boolean argument soon.

Given that TransportationSystem.getStopById() exists, is it necessary for Route.getStopById() to also be present? I argue it is an unnecessary duplicate and should be removed.
If the intent is to check whether a stop exists, a user could simply check Route.getStops().
Let me know what your thinking behind this was!

Route.getStopById() is purely for performance reasons as it would only have to check its own stops. However, Route.getStops() currently has to check every Stop in the System anyways, so the performance gains can only be realized if used in conjunction with the caching I had previously come up with.
To be specific, in my testing with Stops stored with the Route object, the first run of Route.getStops() takes ~ 0.5 seconds, and every subsequent run takes ~ 4e10^-6 seconds.

I think that's a very good idea but let's move it to the caching branch as that is its primary purpose.


MSID: 88623 Version: 2 DOI: 10.1101/2<IP_ADDRESS>1681

MSID: 88623
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>1681
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=88623
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>1681

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/88623v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>1681
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/88623/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Duplicate content in references, also (i) (ii) (iii) for a list displays for one section in preview but not for another?

Thanks @rkcook312. I've had a go at fixing these, but if they don't display well in the next few hours (when the package is loaded), then I think we'll have to accept whatever output we get. I'm not touching ref 81!


Use unbuild to build the component libraries as well

Please describe the feature
Let's also compare final builds, just to ensure we are doing something worthwhile.
Overall, it seems like a good, zero-config type of direction—especially for component libraries.
Unfortunately, I have struggled with the implementation so far. I feel like I am doing something wrong. The error I encountered when building via unbuild was "Note that you need plugins to import files that are not JavaScript." (IIRC)
Help would be greatly appreciated!

A reference to a potentially useful future resource is this thread https://github.com/unjs/unbuild/issues/80

compare vs Vite 3.0


Fix travis h5py failures

@tacaswell This fixes travis. Proof is here: https://github.com/NSLS-II/filestore/pull/108


Clarify use of magic number' -2147024864 in code sample

In two different samples the condition
ex.HResult != -2147024864

is checked without a better explanation of what is doing. It is probably the Windows code for "file is locked".
Questions:

Is this Windows-only? Or it will work across different platforms?
What is the meaning of this error code?

Related:

this issue (which seems to be an open wound in dotnet for year now😢)
this answer in StackOverflow.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9310e951-5185-4c31-064d-3a151acc17cf
Version Independent ID: 42bc4b7b-2a1c-0248-2740-0decdda6000c
Content: Detect changes with change tokens in ASP.NET Core
Content Source: aspnetcore/fundamentals/change-tokens.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

it would only mean that the code needs to wait for the three checks to occur when a locked-file condition is present

BTW: I consider this an improvement over the original code. Since the file can be unlocked during the retries.

Yes ... that's right. That would be better. I don't know which of the goober doc authors did that ... cough cough 🦖 cough ... but they should be sliced up for the butcher's counter 👨🍳🔪🥩 ... 😨.

Since the file can be unlocked during the retries.

It was done on purpose, and it was signed off by one of the top .NET engineers on the product unit. I'm sure we had some rationale for it. We probably were thinking that it's unlikely that it will unlock in that period.
This article was written six years ago in ancient .NET times 👴 before indoor plumbing and the wheel was invented 😆, so why we did it this way is lost to space and time.

Rick, I have a few minutes here ... done with Blazor bits for the day. I'll knock this out. It's my bad anyway! 😆


Improve tunnel writer trait

The tunnel reader trait as used on macOS (#18) forces a copy of the received traffic since macOS's utun requires extra header to be passed into the tunnel interface when receiving tunnel traffic. Since the Writer::write method takes a single parameter that is the slice of bytes that should be written to the utun device, and the slice doesn't contain the headers utun expects, the slice has to be copied and a buffer needs to be allocated. Since the header on macOS are always 4 bytes long, it will always be smaller than the wireguard header that's preceding the payload in the buffer that's originally backing the slice.
This seems like a bit of a hack, and I'm open to better suggestions to reducing the amount of copying required.

I remember this exact issue when writing wireguard-go, I have yet to come up with a good fix.
Maybe a slightly cleaner work-around is making it an associated constant, since it should never change.

Ultimately, it's the caller of the trait that has to make sure that the message is offset by the correct amount of bytes, so the associated constant approach also feels slightly cumbersome. Then again, I'm ok with having the changes.

How about making the Writer::write method accept a custom PacketBuffer type. This type has PacketBuffer::buffer_mut() -> &mut [u8] where the packet data can be written and that is automatically offset by 4 bytes on macOS. That way all platforms write into the buffer with the same code, but some compile time constant makes sure macOS has the data offset in the underlying buffer.


Adding new illustrations to the docs and API command pages

Can someone let me know if I'm doing this correctly?  These are my first pull requests....

Sorry for missing this. They look good -- I'm checking them out and testing to see how they look in the current site.

I've updated this branch so it's in sync with the master branch, with these three illustrations added and linked. @mglukhovsky should let you know how he wants to review it.

Great!  I'll harass @mglukhovsky if I don't hear anything ;)  Thank you, Watts.

I committed the changes I made so far.  I built the site and took screenshots (see below).
@chipotle does that look/ sound right to you?  If I commit changes, the pull request should be in good shape, yes?

It looks good, yes. And if you push changes back to this branch, they'll be added to the pull request.

@mglukhovsky I believe this PR is ready to go. Some of the old illustrations are still on the site- I have only updated a good amount of them with a new style.    The older versions are mostly deeper in the api documentation.

Ping @mglukhovsky.

This has been hanging around an awfully long time. Is it still relevant?

Yes. @ahruygt, I think we need to rework of some of the images -- this is almost ready to go. Can we chat about it next week?

Any updates on this ? There are some conflicts, must they be fixed or can they be ignored ?


Alternative tunings / instruments

It should be possible to choose alternative tunings and/or instruments.

Done.


Proposed fix for gas resistance reading

There is a report in the M5Stack community forum that ENVPro unit fails to report gas resistance. Apparently the returned number always is 0.0. So I looked into the source code and it looks like there might be a copy paste error here.
Please note: I do not have the ENVPro unit myself so I cannot test this. It's just a hunch that this might be the issue.

wrong target branch - sorry


[Basic Roleplaying] Fixed the Dodge Button

Changes / Comments
Fixed the Dodge Button in the bar underneath the Ranged Weapon section to include category bonuses in skills when skills by category is chosen.
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ X] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ X] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


quay-enterprise/: Update quay container version to current 1.16.3

Ref https://github.com/coreos-inc/tectonic-pages/pull/211
Proposed TODO: These should be version "latest", as they are in the
quay-enterprise yaml owned by the tectonic team, see
https://github.com/coreos-inc/tectonic/commit/4f15f8c58321ddf433ceb6ba3838875db2735353#diff-98914fd9e6d06eab312a20550c5fe2df

@Quentin-M What was the reasoning behind the change from latest to the specific versions in coreos-inc/tectonic-pages#187?
at any rate, "we must update these at release points..." :)
https://github.com/coreos-inc/tectonic-pages/pull/187#issuecomment-224722604

https://github.com/coreos-inc/tectonic-pages/issues/186 proposed adding the specific versions

LGTM

It was required at least for clair-jwt as the container is built using two different git repositories, both using the master branch by default, which is the development branch. The branch had breaking configuration changes and it was also quite confusing to use latest (which repository?).


from cleanPen import FilterPointPen / cannot import name FilterPointPen

I suspect that you didnt commit cleanPen.py :)
Traceback (most recent call last):
  File "penBallWizard.py", line 14, in <module>
  File "/Users/thomjanssen/Library/Application Support/RoboFont/plugins/PenBallWizard.roboFontExt/lib/objects/manager.py", line 11, in <module>
  File "/Users/thomjanssen/Library/Application Support/RoboFont/plugins/PenBallWizard.roboFontExt/lib/objects/glyphFilter.py", line 9, in <module>
ImportError: cannot import name FilterPointPen

Worse, I changed it, I’m revising the inner workings in hopes of reaching a first stable version, thanks for standing by and being such a patient tester ; )
Last commit should bring things back to normal.

Hey man its my pleasure. Glad to help.
And I think I speak for many to say thank you for making these tools. :) Thumbs up!
This issue is solved.


VariablesResponse that have different IDs but same name and type causes second item to be hidden

Version: 1.30.2 (user setup)
Commit: 61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8
Date: 2019-01-07T22:54:13.295Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
OS: Windows_NT x64 10.0.17763
and
Version: 1.31.0-insider (user setup)
Commit: 9606490e26f8cbe4d615305389d45e9b144ded7c
Date: 2019-01-30T15:20:25.145Z
Electron: 3.1.2
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763
Tested with Cpptools extension 0.21.0
vscode.zip
Download the attached sample and set a breakpoint on main.cpp:20
When the breakpoint hits, expand the variable v.
You should get two items named <anonymous union> but theres only one. Notice in the protocol log we send back two with variablesReference 1002 and 1003.
Protocol log:
<--   C (variables-14): {"command":"variables","arguments":{"variablesReference":1000},"type":"request","seq":14}
--> R (variables-14): {"request_seq":14,"success":true,"command":"variables","body":{"variables":[{"name":"v","value":"{...}","type":"tvec2<int>","evaluateName":"v","variablesReference":1001}]},"seq":80,"type":"response"}
<--   C (variables-15): {"command":"variables","arguments":{"variablesReference":1001},"type":"request","seq":15}
--> R (variables-15): {"request_seq":15,"success":true,"command":"variables","body":{"variables":[{"name":"<anonymous union>","value":"","type":"union {...}","evaluateName":"v","variablesReference":1002},{"name":"<anonymous union>","value":"","type":"union {...}","evaluateName":"v","variablesReference":1003}]},"seq":83,"type":"response"}

@pieandcakes could you number your <anonymous union>?, e.g. <anonymous union #1> etc.

@weinand We are looking at doing something about it since it breaks a bunch of c++ debugging.

This is not a regression, right?
VS Code always had this limitation.

This is a newly reported customer issue. If what @isidorn is saying is true, then it probably existed before. In this case, since there can be multiple  we are seeing this behavior.


Inaccurate stacktraces and can't debug from source files when using TS or other transpiled languages

Description
I am not able to get proper stacktraces from dev or properly debug the from my source files because sourcemaps for .js files seem to be ignored in dev.
React Native version:
npx react-native info
info Fetching system and libraries information...
System:
    OS: macOS 10.15.4
    CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
    Memory: 136.93 MB / 32.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 14.1.0 - /usr/local/bin/node
    Yarn: 1.10.1 - /usr/local/bin/yarn
    npm: 6.14.4 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.9.1 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 13.4, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK:
      API Levels: 26, 27, 28, 29
      Build Tools: 26.0.2, 27.0.3, 28.0.3, 29.0.1, 29.0.2
      System Images: android-23 | Google APIs Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-29 | Google Play Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 3.6 AI-192.7<IP_ADDRESS>92135
    Xcode: 11.4.1/11E503a - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_211 - /usr/bin/javac
    Python: 2.7.17 - /usr/local/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.11.0 => 16.11.0
    react-native: 0.62.2 => 0.62.2
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

Run the provided project
See the following crash:

Expected Results
The stack trace and debugging aren't taking advantage of the  provided source-maps for the files in ./lib at all. I should get a stack trace that references the .kt source files, and I should also be able to debug/breakpoint from the .kt source files when I attach them in chrome.
Snack, code example, screenshot, or link to a repository:
https://www.dropbox.com/s/ufj75r59yslfvjd/react-native-sourcemap-error.zip?dl=0

This issue hasn't been fixed, and yes, it needs to be.

This issue hasn't been fixed, and yes, it needs to be.