Add notebook for Google Colaboratory

It would be nice to have a quick way to see AiZynthFinder in action without other requirements than a web browser. This pull request provides a small iPython notebook for running this application directly on Google Colaboratory with two clicks. You can see it in action here.
By the way, this is an awesome project! 🚀

Thanks a lot for this - it looks really cool. :-)
The target molecule picture wasn't shown properly for me, but maybe that is something that we could improve in the code.
So this is loaded directly from Github, there isn't any need for me to setup anything at Colab?
I would like you to create a contrib folder in the root of the repository and put the notebook there. I do not want to necessary clutter the root folder, and it also makes it clear that it is contribution.

The target molecule picture wasn't shown properly for me, but maybe that is something that we could improve in the code.

I'm not sure about the causes of this issue. Maybe it's bigger than the display area and you need to scroll to see it (just guessing). If not, it looks like a candidate for debugging. 🙃

So this is loaded directly from Github, there isn't any need for me to setup anything at Colab?

Exactly! Just click the  button and you get the notebook up and running.

I would like you to create a contrib folder in the root of the repository and put the notebook there. I do not want to necessary clutter the root folder, and it also makes it clear that it is contribution.

Sure! In fact, I don't care about the ownership part and I'm happy to donate it (see CLA for more information) it to the project.
Eventually, you may want to dedicate a directory on the root of the repository to "production" code, including a notebook like this for quick use and another along with Voilà and Docker for reproducible development, testing and deployment. Nevertheless, that's definitely another whole pull request and only if you think it would be useful.

@0x2b3bfa0  - I have a potential solution for the target molecule image not shown. Try adding this line as the first python line, before creating the AiZynthApp object.
from rdkit.Chem.Draw import IPythonConsole

depending on the version of RDKit and the version of Jupyter notebook, the display hooks for RDKit molecule aren't setup automatically. In the future, this line should probably be added to the package itself, but if you are ok with it you can add it to the notebook for now.

Eventually, you may want to dedicate a directory on the root of the repository to "production" code, including a notebook like this for quick use and another along with Voilà and Docker for reproducible development, testing and deployment. Nevertheless, that's definitely another whole pull request and only if you think it would be useful.

sounds like a good long-term plan. haven't spent so much time on deployment for the Github project. In AstraZeneca we have a whole IT team dedicated to this for internal users, so it hasn't been a priority for me.

sounds like a good long-term plan. haven't spent so much time on deployment for the Github project. In AstraZeneca we have a whole IT team dedicated to this for internal users, so it hasn't been a priority for me.

Great! In my opinion DevOps methodology is paramount for modern open source projects. Please check #21 for some first steps towards Continuous Integration and other niceties.

@SGenheden, please check the last ammendments to my commits.

Thanks for f19c60e53ae0a6dfb9c4dfac3b6a7fe6899f0dc5! I missed the newline. 🤦


There is no support for class.method type entry

currently func: only supports a py module level procedure.
I have classes each with its own argparse set.
I need to be able to support such a scenario
Any help would be appreciated.

I sent a PR for this feature a long time ago, see https://github.com/alex-rudakov/sphinx-argparse/pull/136

I've now ported my PR to the new repo, see https://github.com/ashb/sphinx-argparse/pull/36


Navigation collapses to icon-only

Request for icon-only navigation option.
This would be an extension of the vertical navigation, where instead of collapsing into a hamburger menu, it collapses to a vertical icon bar.
This was available in PF3 and used extensively in Satellite. It provides the ability to quickly switch between pages while still maximizing content space. The lack of this feature makes a PF4 upgrade more difficult.
cc @Rohoover

Some discussion of this feature was discussed in this issue: https://github.com/patternfly/patternfly-next/issues/1929


Windows 11 ARM64 Build 22454 BSOD

The new Windows 11 for ARM64 Build 22454 (available here won't boot. I converted the file to qcow2 and then run but there is BSOD "INACCESSIBLE BOOT DEVICE". Previous available build 22000.132 run correctly.
Configuration

UTM Version: 2.2.4
OS Version: 11.6
Intel or Apple Silicon? Silicon

Which UTM version did you use to boot the previous build?
Please add the basic troubleshooting info as requested in the issue template. Otherwise we can't pinpoint the cause of this issue. Thanks.

I used 2.2.4 version to run previous build, I guess. I'll send debug log later.

I have just noticed that previous build that I used to run successfully also falls into this BSOD (INNACCESSIBLE BOOT DEVICE). I will try to reinstall UTM app.

Build 22468 works fine.

Build 22468 works fine.

Build 22468 works fine.

Well, I still get the BSOD and can't install it so... how did you install this build of Windows 11 in details?

Build 22468 works fine.

Well, I still get the BSOD and can't install it so... how did you install this build of Windows 11 in details?

I installed through windows update.

Build 22468 works fine.

Well, I still get the BSOD and can't install it so... how did you install this build of Windows 11 in details?

I installed through windows update.

Ok, so the installer of the build is broken, no the actual build. It's a start

Did anyone take note of the hard disk interface that is set in their VMs when this BSOD appears? My theory is that it's set to VirtIO and Windows doesn't like that. NVMe or USB should work, though.

Did anyone take note of the hard disk interface that is set in their VMs when this BSOD appears? My theory is that it's set to VirtIO and Windows doesn't like that. NVMe or USB should work, though.

mine was set on NVMe

mine windows 11 so slow cant install

Build 22468 works fine.

Well, I still get the BSOD and can't install it so... how did you install this build of Windows 11 in details?

I installed through windows update.

But Windows Update does not work on Insider builds, does it?

Build 22468 works fine.

Well, I still get the BSOD and can't install it so... how did you install this build of Windows 11 in details?

I installed through windows update.

But Windows Update does not work on Insider builds, does it?

Find offlineinsiderenroll program and you can turn on receiving dev builds.

Did anyone take note of the hard disk interface that is set in their VMs when this BSOD appears? My theory is that it's set to VirtIO and Windows doesn't like that. NVMe or USB should work, though.

Oh, I am sorry, totally forgot to set it so. Now latest Windows Build runs as it was. Using latest UTM release.
Off topic: where or when I can get information about graphics acceleration for Windows 11 ARM VM on Apple Silicon?

Did anyone take note of the hard disk interface that is set in their VMs when this BSOD appears? My theory is that it's set to VirtIO and Windows doesn't like that. NVMe or USB should work, though.

Oh, I am sorry, totally forgot to set it so. Now latest Windows Build runs as it was. Using latest UTM release.

oh really? works converting the disk in cow2 or keeping it in vhdx?

Off topic: where or when I can get information about graphics acceleration for Windows 11 ARM VM on Apple Silicon?

idk man, sry

Did anyone take note of the hard disk interface that is set in their VMs when this BSOD appears? My theory is that it's set to VirtIO and Windows doesn't like that. NVMe or USB should work, though.

Oh, I am sorry, totally forgot to set it so. Now latest Windows Build runs as it was. Using latest UTM release.

oh really? works converting the disk in cow2 or keeping it in vhdx?

Off topic: where or when I can get information about graphics acceleration for Windows 11 ARM VM on Apple Silicon?

idk man, sry

I have not tried with VDHX, I converted then run.


Proxy

Hey, can I set somewhere a proxy for the CURL calls? Greets

Try the below:
use GuzzleHttp\Client as GuzzleClient;
use TheIconic\Tracking\GoogleAnalytics\Network\HttpClient;

$guzzle = new GuzzleClient(['proxy' => '<IP_ADDRESS>:10']);
$httpClient = new HttpClient();
$httpClient->setClient($guzzle);

GAMP::setHttpClient($httpClient);

This could actually be better if the library has setOptions method. I'll see if I can send a PR to them or if you can, feel free to do so.
Let me know if that works for you (I haven't tested that).

Perfect, will try that thx! Cheers

Still need to wait to see the results in GA (for some strange reasons for a new account it takes some time before the first events get in) but I don't get errors anymore. So I'm pretty sure it works. Thanks a lot!


res.cookie does not allow setting Max-Age only, without Expires (One should be able to set maxAge alone, with expires: 0)

I want to set a cookie with Max-Age only, without having Expires. But the following lines 875-876 keep adding the unwanted Expires:
https://github.com/expressjs/express/blob/0debedf4f31bb20203da0534719b9b10d6ac9a29/lib/response.js#L871-L878
Setting expires: 0 does no good to override that behavior.
I think one should be allowed to only set Max-Age without automatically having Expires also set.
res.cookie('MyCookie', 'TheValue', {
  expires: 0, // I don't want any Expires in the resulting Set-Cookie statement
  maxAge: 60000,
});

Actual result:
MyCookie=TheValue; Max-Age=60; Path=/; Expires=Sun, 26 Mar 2023 06:00:31 GMT

Desired result:
MyCookie=TheValue; Max-Age=60; Path=/;

Workaround
The workaround for this is our having to manually write the Set-Cookie statement, possibly mimicking the same logic in the express code.
Possible solution
if (opts.expires !== 0) {
  opts.expires = new Date(Date.now() + maxAge)
}

Hi @tjarbo that is correct, user agents that support max-age attribute should ignore expires attribute. But since max-age was an add on to set-cookie later in life, not all clients support it, so they will use expires instead (since they don't understand max-age. This is why Express is adding both, so all clients will know when the cookie expires and won't accidentally set it as a session-length cookie. Maybe better understanding of @nbkhope use-case will help.

Hi @tjarbo there are many other user agents then web browsers. And many still ezist today that never kept up with the changes in specs. It was added to express in reponse to users have issues is all. As for web browsers, I believe Internet Explorer never supported max-age until IE8, well after Netscape stopped being relevant.


Using the Cordova-SQLite-Plugin $scope.execute isn't running but the database is being opened without error

I have a database that is created when my Windows 8 app starts. When I tap a button on the screen I'm using ng-view to change the content. In the controller I want to do a call to my database to select data then I'll be using the results to populate the template that's pulled in with the ng-view.
I'm using the following code to open my db and select some items from the table. Console shows the database is being opened but the other logs don't run since the $scope.execute isn't ran. I don't get any js or app errors.
var nanoDB = $cordovaSQLite.openDB( "nanoDB.db" );

$scope.execute = function () {
    var query = "SELECT name FROM nanoProd";
    console.log(query);
    $cordovaSQLite.execute(nanoDB, query, []).then(function (res) {
        console.log(res);
    }, function (err) {
        console.log(err);
    });
};

I'm not use $cordovaSQLite.openDB( {name:"nanoDB.db"} ); per the docs because of solution in an issue for Cordova-SQLite-Plugin.
Why isn't my execute running?

this is the same error  : https://github.com/driftyco/ng-cordova/issues/651

Greetings @dcp3450!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


Incus/LXD Error: Failed to connect to local daemon

Describe the bug
When I run incus admin init I get:
Error: Failed to connect to local daemon: Get "http://unix.socket/1.0": dial unix /var/lib/incus/unix.socket: connect: no such file or directory

When I run lxd init I get:
Error: Failed to connect to local LXD: Get "http://unix.socket/1.0": dial unix /var/lib/lxd/unix.socket: connect: no such file or directory

What did you expect to happen?
The init configuration wizard to launch
Output of rpm-ostree status
State: idle
AutomaticUpdates: stage; rpm-ostreed-automatic.timer: no runs since boot
Deployments:
● ostree-image-signed:docker://ghcr.io/ublue-os/bluefin-dx:gts
                   Digest: sha256:25512f5bb5985808f7f1583f06cb1846860aa4661814b8bc2989179f1a59873a
                  Version: 38.20240413.0 (2024-04-13T23:30:07Z)

  ostree-image-signed:docker://ghcr.io/ublue-os/bluefin-dx:gts
                   Digest: sha256:0c6702c9c0f6de5f850761014a5f74fced652cdbe3ec625c87552cd14dcf05e6
                  Version: 38.20240412.0 (2024-04-12T17:04:37Z)

Extra information or context
I've ensured virtualization is enabled in my bios. I don't have any experience of using Incus, but for LXD I've ensured my user is in the lxd group. I've tried searching the errors online but I'm mostly finding information about snaps, which I don't believe is how it's installed on bluefin (correct me if I'm wrong).

The sockets for lxd and incus are not enabled by default. Enable them with systemctl enable --now incus.socket or systemctl enable --now lxd.socket

That seems to have done the trick - thank you


Fix update interval

Fix for https://github.com/ad-ha/mg-saic-ha/issues/50

@x3e
Really appreciate this PR. I am now changing the code to include a new update interval, for when vehicle is working, so I refactor the whole update interval logic.
From my testing this is working well, so I will drop this PR in favor of the changes I did to address the new interval, and also taking into account your suggestion.
Thanks a lot

No worries, thank you for your ongoing efforts.

Appreciate.
I am just testing the new features and changes from the roadmap for 0.7.x and will do the release as soon as I get it all done.
Cheers

@x3e
I just released the new version. I believe that the update intervals do work well, but let me know if you find something odd or not working as expected.
Thanks again for your help


Accept-Header

So I need a better lookupMin system - simply doing an ordered lookup won't be good enough. I've narrowed-down the behavior to a set of preferred sequences of file extensions:

foo.html: Html, Text, Json
foo.json: Json, Text, Html
foo.txt: Text, Json, Html

Lookups for the file type will follow this sequence of attempts before failing. Additionally, content types in the accept header should refine these sequences, as the intersection of the accept header contents and the sequence.

There is a lot more to proper HTTP request handling than I recognized. Maybe I should also include a handleLitReq set of functions for forcing responses to be of a Request -> ... -> Response function, that way they can have more finite control over other headers. mrhrmm...


Php cs fixer refactoring

Keep Composer script utilisation consistent and enable 'php-cs-fixer' alpha version for repository.

Failing builds seems to be caused by Travis CI infrastructure problems.


gridfinity cabinet tops

While Screwfinity grid inserts are a nice addition to upstream Screwfinity, I don't want to have to print and assemble a separate piece. It should be a build option for Cabinets. Hopefully I can just use the tops that already exist in kennetek/gridfinity-rebuilt-openscad, but I need to do more digging into the code to verify.

Looks like there's no easy way to get magnet tops, but I did find the right bits to get Gridfinity stacking tops.
I think I should be able to leverage the magnet base and the block body to generate the magnet top that I want.

duh; I just need to graft a baseplate onto the top...


win32, get_length: use GetFileSizeEx() instead of GetFileSize().

This properly supports 64 bit file lengths. This obviously drops support for win9x and nt4, but the code already uses win32 apis available in win2k and newer.

Actually no, forget this patch, not truly necessary. Closing.


Error on Custome Training Model -  KeyError: 'val_acc'

Hello guys,
after i am follow this tutorial https://github.com/OlafenwaMoses/ImageAI#customtraining
i run training python but show error :
KeyError: 'val_acc'
Any information, what that error about ?
I am use :
Python 3.6
tensorflow 1.9
keras 2.2.0
Thanks

Did you set the batch_size of trainModel()?

can you show your code ?

I am also having this problem, since @Jayuda has not responded (maybe the problem has been solved)?
But it is still a problem for me:
from imageai.Prediction.Custom import ModelTraining

model_trainer = ModelTraining()
model_trainer.setModelTypeAsResNet()
model_trainer.setDataDirectory("trees")
model_trainer.trainModel(num_objects=2, num_experiments=100, enhance_data=True, batch_size=32, show_network_summary=False)

my folder structure is:
trees/train/oaks/*.png
trees/train/maple/*.png

trees/test/oaks/*.png
trees/test/maple/*.png

Right now, I have 5 test pictures in each test folder, and 7 training images in each train folder.

The recommended number of train images per object class is 500. See the documentation link below.
https://imageai.readthedocs.io/en/latest/custom/index.html

@OlafenwaMoses your comment was not helpful, and counter productive; if you read my post you'd see that I solved my issue by changing the batch size.
I understand that the "recommend" number of training images is 500. But this is not a requirement as that would be ridiculous.
It is completely unreasonable to assume that someone who is just setting this up for a personal project would have 500+ images of what they want to be able to predict. Sometimes you just need to get things set up first.

ImageAI library was built to let developers harness the potentials of state-of-the-art  AI by abstracting the scale of difficulty involved. But since you consider the requirements outrageous, please dive into the details below.

ImageAI is powered by deep learning algorithms
Deep Learning Algorithms are the only methods to achieving human level performance in intelligence tasks
Deep Learning requires Big Data to train
Deep Learning requires hardware with 5X more cost than normal PCs
Deep Learning involves hundreds to thousands of lines of code ( solved by ImageAI into just 5 lines)  to train a new recognition model.

Should you get this details a twist, spend the next one week reading extensively on deep learning.

@OlafenaMoses I didn't say I considered the requirements outrageous. The 500+ images is a recommendation, you said that yourself.
But saying that it is recommend, referring to the documentation, and closing the issue was, in my opinion, too soon. You didn't give @Jayuda a chance to read what I had posted and see if solved his problem, and (hopefully) reply saying it did.
We both know that 500+ images is not a requirement. Sure, 500+ images is suggested for a very accurate prediction, but it can still function on 10 or so images. It just won't be as accurate as it could.
When first learning how to do this, 500 images is a lot. Especially if you are just messing around to see if it is what you want.

Getting the same error with >900 train images.


Add ETF2L Links

Pull user id from API and store it forever upon loading a user profile page.

https://github.com/leighmacdonald/etf2l mostly functional, however data will be pulled via bd-api.


Update lib-storage.ts manual mock to use aws-sdk-client-mock

This pull request includes the following commits:
Delete client-s3.ts: This commit removes the client-S3.ts file from the repository. It is no longer needed and can be safely deleted.
Delete lib-storage.ts: This commit removes the lib-storage.ts file from the repository. It is no longer needed and can be safely deleted.
Update storage.test.ts to use aws-sdk-client-mock: This commit modifies the storage.test.ts file to utilize the aws-sdk-client-mock library for mocking AWS SDK calls.
[#1423]

coverage: 94.297%. remained the same when pulling 53a077f0cb4edd65af19481fe53b89a93217a49f on Paul-Taiwo:paul-use-aws-sdk-client-mock into 576698dc394ae6e8cf7b3e7ef39fb4155b91d399 on medplum:main.


feat: add support for async/await

Proposed Changes

Added Swift 5.6 to CI pipeline
Added supports for async/await3.
Changed supported InfluxDB version from InfluxDB 2.0 to InfluxDB 2.x

Checklist

[ ] CHANGELOG.md updated
[x] Rebased/mergeable
[x] A test has been added if appropriate
[x] swift test completes successfully
[x] Commit messages are in semantic format
[x] Sign CLA (if not already signed)

Codecov Report

Merging #49 (99be6ca) into master (da50d69) will increase coverage by 36.61%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master      #49       +/-   ##
===========================================
+ Coverage   51.05%   87.67%   +36.61%
===========================================
  Files         137       10      -127
  Lines        8528      949     -7579
===========================================
- Hits         4354      832     -3522
+ Misses       4174      117     -4057

Impacted Files
Coverage Δ

Sources/InfluxDBSwift/DeleteAPI.swift
95.08% <ø> (ø)

Sources/InfluxDBSwift/InfluxDBClient.swift
83.94% <ø> (ø)

Sources/InfluxDBSwift/QueryAPI.swift
77.87% <0.00%> (-9.26%)
:arrow_down:

Sources/InfluxDBSwift/WriteAPI.swift
78.03% <ø> (ø)

Tests/InfluxDBSwiftTests/QueryAPITests.swift

...nfluxDBSwiftApis/Generated/Models/Permission.swift

...uxDBSwift/Generated/OpenISO8601DateFormatter.swift

...fluxDBSwiftApis/Generated/Models/LabelUpdate.swift

Tests/LinuxMain.swift

Tests/InfluxDBSwiftApisTests/LabelsAPITests.swift

... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da50d69...99be6ca. Read the comment docs.


Remove no-op basePath assignment.

The body of this if statement only reassigns the same value that was already assigned from; the value of basePath will still be the empty string afterwards, in all cases where the if-block actually executes.

Thank you.


Freezes (white screen) on launch

The app will freeze on launch, and after a while it will open with the top (loaded module) part missing. This happens almost every time when I want to use VRCFT. I have to try multiple times launching the app to get it to load a module. Apparently it's failing to check module updates, but that shouldn't freeze the whole app?
Output log:
[MainStandalone] Information: VRCFT Version <IP_ADDRESS> initializing...
[MainStandalone] Information: Initializing OSC...
[OSC] Debug: OSC Service Initializing
[OSC] Debug: Binding Sender Client
[OSC] Debug: OSC Service Initialized with result (True, True)
[MainStandalone] Information: Initializing main service...
[VRCFaceTracking.UnifiedTrackingMutator] Debug: Reading configuration...
[MainStandalone] Debug: Starting OSC update loop...
[MainStandalone] Debug: Checking for deletion requests for installed modules...
[MainStandalone] Information: Checking for updates for installed modules...
[App] Error: Unhandled exception
[App] Critical: Stacktrace:    at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
   at VRCFaceTracking.Core.Services.ModuleDataService.AllModules()
   at VRCFaceTracking.Core.Services.ModuleDataService.GetRemoteModules()
   at VRCFaceTracking.Services.ActivationService.StartupAsync()
   at VRCFaceTracking.Services.ActivationService.ActivateAsync(Object activationArgs)
   at VRCFaceTracking.App.OnLaunched(LaunchActivatedEventArgs args)
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)
   at Microsoft.UI.Dispatching.DispatcherQueueSynchronizationContext.<>c__DisplayClass2_0.<Post>b__0()
[App] Critical: Inner exception: System.Threading.Tasks.TaskCanceledException: A task was canceled.
   at System.Threading.Tasks.Task.GetExceptions(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
   at VRCFaceTracking.Core.Services.ModuleDataService.AllModules()
   at VRCFaceTracking.Core.Services.ModuleDataService.GetRemoteModules()
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at VRCFaceTracking.Core.Services.ModuleDataService.GetRemoteModules()
   at VRCFaceTracking.Services.ActivationService.StartupAsync()
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at VRCFaceTracking.Services.ActivationService.StartupAsync()
   at VRCFaceTracking.Services.ActivationService.ActivateAsync(Object activationArgs)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext(Thread threadPoolThread)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext()
   at Microsoft.UI.Dispatching.DispatcherQueueSynchronizationContext.<>c__DisplayClass2_0.<Post>b__0()
   at ABI.Microsoft.UI.Dispatching.DispatcherQueueHandler.Do_Abi_Invoke(IntPtr thisPtr)
   at ABI.Microsoft.UI.Xaml.IApplicationStaticsMethods.Start(IObjectReference _obj, ApplicationInitializationCallback callback)
   at Microsoft.UI.Xaml.Application.Start(ApplicationInitializationCallback callback)
   at VRCFaceTracking.Program.Main(String[] args)
--- End of stack trace from previous location ---

[App] Critical: Message: One or more errors occurred. (A task was canceled.)
[VRCFaceTracking.UnifiedTrackingMutator] Debug: Configuration loaded.

This sounds like a network-level issue with fetching updates. Can you try on a VPN?

This sounds like a network-level issue with fetching updates. Can you try on a VPN?

I'm thinking that as well, is I'm using a 6in4 tunnel and I bet that's causing problems. Can I have the domains it will connect to for updates so I can set them to not resolve to IPv6 in my DNS server?

Try checking: https://rjlk4u22t36tvqz3bvbkwv675a0wbous.lambda-url.us-east-1.on.aws/modules

Thanks, apparently AWS hates my tunnel. Connecting through IPv4 works fine.
You may close this now, but as I said a failed update check really shouldn't affect loading installed modules.


Jonas modify add command

Fix #30

Codecov Report

Merging #31 (55967ee) into master (cef45c4) will decrease coverage by 5.73%.
The diff coverage is 66.84%.

@@             Coverage Diff              @@
##             master      #31      +/-   ##
============================================
- Coverage     72.15%   66.42%   -5.74%
- Complexity      399      437      +38
============================================
  Files            70       83      +13
  Lines          1232     1525     +293
  Branches        125      176      +51
============================================
+ Hits            889     1013     +124
- Misses          311      424     +113
- Partials         32       88      +56

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/util/FileUtil.java
77.27% <ø> (ø)

.../java/seedu/address/model/util/SampleDataUtil.java
20.00% <0.00%> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...java/seedu/address/logic/commands/EditCommand.java
44.79% <23.68%> (-52.23%)
:arrow_down:

.../seedu/address/logic/parser/EditCommandParser.java
44.82% <33.33%> (-47.49%)
:arrow_down:

...va/seedu/address/storage/JsonAdaptedProfessor.java
33.33% <33.33%> (ø)

.../address/storage/JsonAdaptedTeachingAssistant.java
33.33% <33.33%> (ø)

...java/seedu/address/logic/commands/ProfCommand.java
66.66% <66.66%> (ø)

...n/java/seedu/address/logic/commands/TaCommand.java
66.66% <66.66%> (ø)

...in/java/seedu/address/model/person/ModuleCode.java
70.00% <70.00%> (ø)

... and 25 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


invalid class “itemMatrix” object: item labels not unique

It looks like that the frameToRules function sometimes returns error "invalid class “itemMatrix” object: item labels not unique"
Some debugging showed that
unique(unlist(sapply(rowItems, function(x) x$ant)))

does not filter out repeating items.
A fix seems to be replacing this with
unique(c(unlist(sapply(rowItems, function(x) x$ant))))

That is
antItems <- unique(c(unlist(sapply(rowItems, function(x) x$ant))))
consItems <- unique(c(unlist(sapply(rowItems, function(x) x$cons))))

Where are we on this fix? I am currently getting this error, and would benefit from a solution. I tried taking the source code of the function and replacing the section that you talked about it in your post, but it did not work.
I also attempted,
unique(mydatset)

to see if all rows were unique and they were.
Any insight?


Directory creation experience

Why link https://portal.azure.com/#create/Microsoft.AzureActiveDirectory redirecting user to the website where he need to provide MSA account when in any "Best practices guides" you suggest to use Company account. Why you not redirecting user to this URL: https://account.windowsazure.com/organization ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 14ab965b-dc45-f450-1302-5ffe491ca129
Version Independent ID: 0d96d50d-a349-3408-3b93-d8b084e1cbd1
Content: How to get an Azure AD tenant
Content Source: articles/active-directory/develop/active-directory-howto-tenant.md
Service: active-directory
GitHub Login: @CelesteDG
Microsoft Alias: celested

@eklime Thanks for your feedback! We will investigate and update as appropriate.

@eklime Can you provide us the "Best Practice Guides"  link which you are referring to ?

@eklime We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Set all padding values at once

Example of use:
<?xml version="1.0" encoding="utf-8"?>
<js:Application xmlns:fx="http://ns.adobe.com/mxml/2009"
                xmlns:js="library://ns.apache.org/royale/basic">

    <js:valuesImpl>
        <js:SimpleCSSValuesImpl/>
    </js:valuesImpl>

    <js:initialView>
        <js:View>
            <js:style>
                <js:SimpleCSSStyles padding="20" />
            </js:style>
            <js:Container width="100%">
                <js:beads>
                    <js:HorizontalLayoutWithPaddingAndGap padding="10" gap="20" />
                </js:beads>
                <js:TextButton text="Button 1" />
                <js:TextButton text="Button 2" />
                <js:TextButton text="Button 3" />
             </js:Container>
        </js:View>
    </js:initialView>

</js:Application>

Justin, your PRs have too many commits.  Please squash them into 1 commit per PR.  That will make it easier for folks to review your changes.

Click on the file changes and you can easily see what's changed. AFAICS squash commits wont help here as the other commits have been made in my develop branch not in this branch.

@bigosmallm FWIW, you can view the file changes. That makes it easier.
I'm not sure if this change is PAYG. It's a nice convenience to be able to specify all padding at once, but not strictly necessary and adds bulk to the bead.
It feels to me like this belongs in an Express component or similar. An express-type component can allow specifying padding to the component itself which is even easier than having to specify the layout.

If the function is not called it will be optimised out so there is no PAYG cost here if you don't use it. Not having it is likely to increase code size as you need to specify all four attributes and values values rather than just one if you want the same (which is fairly common IMO).
Also SimpleCSSStyles has a padding attribute and that hasn't been called out as not PAYG.

Commit history is part of the PR.  If we merge it as is, it will create unnecessary git history.  The committer who is merging the PRs should remember to squash and merge.
Justin perhaps you should create a new branch for each PR?

SimpleCSSStyles was created to support the styles that are supported by Flash. Different story there.
I'm currently on the fence on this issue. I'd like to hear what others think.

Express or separate bead for setting all paddings at once . Agree with you @Harbs .

@bigosmallm  Each PR is on a new branch off develop the issue is outstanding PR that have not been accepted.

Also squashing commit is considered (IMO) bad practice at Apache as it changes history. I don't think we've ever had a discussion about this so please bring it up on the dev list. That being said it's usually not an issue as after a few PRs the person is usually made a committer.

23 commits for a 8 line change is excessive.  I'm closing this one as Invalid.

There is only one commit in the branch in question please reopen and merge

You'll see that most of the merges above are "Merge remote-tracking branch 'upstream/develop' into develop" which I need to do in order to keep my develop branch in sync with the upstream apache repo.

The change was a single comment on a branch off my develop as you can see here. [1]

https://github.com/apache/royale-asjs/pull/75/commits/c2ab730e2d2e73703b4361aea4bdf20b6c1cc02d

So I tried to fix this and was unable to (hard reset develop to upstream, re-parent branch and rebase). However you should be able to apply the single commit like so:
git fetch --all
git cherry-pick c2ab730
You may need to git remote add my repo I'm not sure it's been added and as I don't have access I can't test it.
Alternatively you could just take the patch file and just apply the last commit in it. [1]

https://patch-diff.githubusercontent.com/raw/apache/royale-asjs/pull/75.patch

Or I can submit another pull request if you prefer.

Also re PAYG:
With left , right, top and bottom padding version the example program release size is 83,026 bytes
With single padding version the example program release size is 82,960 bytes.
So using the single padding attribute will save you a few bytes - 66 in this case. Not significant but it doesn't add to the size so there's no PAYG cost there.
Again if the padding attribute is not used then the function is optimised out / removed so there's no PAYG size cost if you don't use the single padding attribute.
Just out of interest I looked at a mixed version:
1 single padding and 1 set of padding attributes 83,082 bytes.
2 sets of padding attributes 83,148 bytes.
So even if you mix them there is a few bytes saved and no PAYG cost.
Runtime wise the left right, top and bottom version it needs to make four function calls to set the padding. The single padding version will be faster as it only calls one function. Not that you could probably measure it in any meaningful way or that it would have a noticeable impact on a simple application but it may provide a small benefit in complex layout, item renderers or the like.
There is no runtime PAYG cost if you use or don't use the single padding attribute.
So can you please explain how you find this not PAYG?

My two cents here is that having patterns that fit into the CSS / HTML way make sense. It should also make it easier to convert HTML/JS developers over to Royale.

In CSS you can go "padding: 25px;" and that will apply padding to top, bottom, left and right. The added padding attribute matches that.

Before adding a method, ask yourself if the user can opt-out of this functionality if they don't need it.
The setters for left,right,top and bottom are required functionalities.  The set_all_padding method is a convenience function that not everyone is going to use.
The correct comparison would be to look at the file size with and without the set_all_padding method.
Convenience methods should be added into higher order components (for example Express) or in custom beads.  That way, the functionality is optional.

I did there's is no PAYG size cost their either it's 83,066 bytes.
I seem to repeating myself here remember that unused methods are optimised away / removed by the compiler in the release version.


[Bug]: Validation appears momentarily in input widget

Is there an existing issue for this?

[X] I have searched the existing issues

Description
[WDS Input widget]
When we freshly drop an input widget (or refresh the page), and then type a space character in the input widget (the input widget has validation enabled), the error message momentarily shows up shifting the layout.
Steps To Reproduce

Add an input widget and configure a validation error message, and set the validation to return {{false}}
Type a "space" character in the input widget.

https://github.com/appsmithorg/appsmith/assets/103687/7882c0a5-9434-47c0-b753-d1057ea57aa2
Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud / Self Hosted - 1.9.57

Hey @riodeuno  is this issue resolved now?

On fix/input-validation fix for old widget, but there is no fix for WDS widget. @jsartisan Could you take a look?

Fixed in #30300


Better to compare the binary values than rely on deterministic prettifying...

Doesn't this result in unuseful errors when hashes don't match?

Seemed kind of equally unuseful..., I don't feel strongly about it either way.


Drop EL7 testing from nightly

@evgeni @upadhyeammit @pcreech This is one of the biggest "turn off EL7" knobs and so I want to make sure y'all see it and if y'all are ready to proceed.

Once we merge this, we should clean https://yum.theforeman.org/releases/nightly/el7/ as well so we're not accidentally testing with old packages.

Once we merge this, we should clean https://yum.theforeman.org/releases/nightly/el7/ as well so we're not accidentally testing with old packages.
Edit: and https://yum.theforeman.org/katello/nightly/candlepin/el7/ & https://yum.theforeman.org/katello/nightly/katello/el7/ of course.

If we clean those up as soon as merging this, all puppet PRs that require repositories will break IIRC? So are we blocked on merging this till the Puppet changes or can we merge this and then clean those repositories up after the Puppet changes?


Use correct route name after player creation

Creating new players is broken at the moment because of creating a pointer to the GET url by using old naming convention.
This PR fixes this.

This is why we need integration tests.


Suggestion: pls add option to move items directly to transfer list

..this is usefull when buying players because it may allow to buy the same player several times.
Thanks

Give Sell Price as -1 to move to transfer list without selling.


[Infineon] Update CYW30739 to support CYW30739B2-P5-EVK-XX boards.

Replace CYW30739 submodules with the matter-wpan-sdk submodule.
Update README files for CYW30739 apps.
Add CYW30739B2-P5-EVK-01, CYW30739B2-P5-EVK-02, and CYW30739B2-P5-EVK-03 boards for CYW30739.
Add development DAC files for CYW30739.
Add cyw30739_example, cyw30739_platform, and ifx_openthread template for board dependant targets.
Update GN files for CYW30739 apps.
Update CYW30739 builder scripts.
Update checkout_submodules.py script to support the recursive configuration in the .gitmodules file.
(split to https://github.com/project-chip/connectedhomeip/pull/33089)
Update the CYW30739 flashing script.
Update the workflow to build all CYW30739-supported targets.
Move shared codes to the matter_config.cpp file.
Implemented FactoryDataProvider for CYW30739 to load factory data.
Remove the CYW30739 ota-requestor-app.

Rebase to clear conflicts.

Having each target compile every possible supported board seems off. We can do that as part of CI, however auto-selecting all boards as part of the build seems strange.

We didn't remove the ability to let the developer build only a specified board. We documented how to do it in README files. The below instruction is a part of the CYW30739 app README file:
$ cd ~/connectedhomeip
$ source scripts/activate.sh
$ gn gen --root=examples/lighting-app/infineon/cyw30739 out/cyw30739-light
$ ninja -C out/cyw30739-light [lighting_app-BOARD_NAME]

I also noticed that the NINJA_ARGS environment in scripts/examples/gn_build_example.sh seems to provide the same capability of specifying the ninja build target.


Add anchor links to home page

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] All tests are passing yarn test
[ ] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[ ] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

Not sure if my proposed changes are done correctly, but please let me know if there as another way it could have been written. Thank you!

Got it, because the title is already in that <a...> tag?

Sorry but this does not seem to work 😞 Also, the styling will need more work:
Old:

New:

@AlleyWei I think we may close this PR?


refactor Remove

What problem does this PR solve?

Remove IntAtomicCounter, it is equal to IntCounter.
Remove CoreLocal related code. It is not used any more.

Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[ ] Yes.

Does this need documentation?

[ ] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.
Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

run buildall

run buildall


Color Variables Cleanup

This PR addresses some issues brought up in #8292.

Cleaned up the inconsistencies in how we reference color variables from $foundation-palette, switching instances of map-get() to get-color().

New $[badge,button,label]-classes lists in _settings.scss determines which colors in $foundation-palette will generate color classes. If you don't need a certain class, simply remove it from the list.

Update the description of add-foundation-colors() mixin.

Update docs about color: Global Styles, Badge, Button, Label.

@brettsmason @andycochran @ncoden is this good to include in the next RC?  I'd like to package it early morning Weds PDT time.

@kball Hopefully I got this done in time. With @ncoden's changes, I think it's now ready for the next RC.


How to connect with raspberry pi?

when i process the lane_detection_script.py, it stuck in "WAITING FOR Raspberry pi"

This repo was created as part of a University course. The hardware was made up of a jetson nano and a connected Raspberry Pi.
Unfortunately, I do not have access to the hardware anymore and cannot give you proper support. I do believe that the Raspberry Pi was connected via Ethernet cable. You will probably have to rewrite the code to fit your hardware. The RPi was not part of the algorithm, but used to control the vehicle.


Add a research paper about GitHub Discussions to Further reading

Why:
Share the results of an empirical study on GitHub Discussions with GitHub users.

What's being changed:
Add a paper reference to Further reading.

Check off the following:

[x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Por qué:
Comparta los resultados de un estudio empírico sobre las discusiones de GitHub con los usuarios de GitHub.
Qué se está cambiando:
Agregue una referencia en papel a la lectura adicional.
Marque lo siguiente:

[x] He revisado mis cambios en la puesta en escena (busque "Comentario generado automáticamente" y haga clic en Modificado para ver sus últimos cambios).
[x] Para cambios de contenido, he completado la lista de verificación de autoevaluación .

Impacto del escritor (esta sección es solo para miembros del personal de GitHub):

[ ]  Esta solicitud de extracción afecta la experiencia de contribución

[ ]  He añadido la etiqueta "impacto del escritor".
[ ]  Agregué una descripción o un video de demostración de los cambios a continuación (por ejemplo, un "video de antes y después")

@hideakihata
Thanks so much for opening a PR! I'll get this triaged for review :zap:

I'll review this 🙂

@hideakihata Thanks again for opening this pull request. We generally try to stay away from linking out to external resources as much as possiple, though I realize that your paper seems to be the result of throrough research, is well written, doesn't have any obvious ties to anyone who might profit financially from it, and also comes with some solid suggestions for how to adopt GitHub Discussions.
I still need to discuss this with some other folks in our organization next week, but I wanted to give you a heads up that we're leaning towards not including this paper in our documentation.
However, since I personally think this paper could be a valuable resource, would you be OK with me pointing it out to our marketing and research team, such that they can reach out to you if they're interested in using it in some way?

Thank you very much for your kind attention to this matter. Actually, I had received an email from the product manager at GitHub Discussions for an earlier version of this paper that I had uploaded to arXiv. I also heard that some co-authors, who live in Europe, gave a talk about this research at GitHub.
I hope to not only connect with the GitHub teams, but also inform GitHub users about this research. Now I understand the policy of not linking external resources in the documentation. I would like to explore what we can do as open science.

I had received an email from the product manager at GitHub Discussions for an earlier version of this paper that I had uploaded to arXiv

I'm glad to hear that you are already in contact with the respective product manager. ✨
As expected, the consensus on the Docs team is to rather not include external references like this one. Hence, I'm going to respectfully close this pull request. Thanks for understanding.


Ability to scan all projects in the projects directory that the user has set.

This feature has now been implemented.


Unable to import some files from node_modules in SwSrc file.   While trying to import the file serviceWroker donot work.

Unable to import some files from node_modules in SwSrc file.
While trying to import the file serviceWroker donot work.

InjectManifest({
        swSrc: "./src/sw.js",
        swDest: "service-worker.js"
 });

Can you try again using workbox-webpack-plugin v5? Prior to that, the swSrc file was not compiled by webpack, meaning that any require or import statements in the swSrc would lead to an invalid service worker.


Red squiggles persist when doing restore and build outside of VS Code

From @danroth27 on May 20, 2017 16:40

VSCode Version: Code 1.12.2 (19222cdc84ce72202478ba1cec5cb557b71163de, 2017-05-10T13:20:36.315Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author
Version

gc-excelviewer
GrapeCity
1.1.13

csharp
ms-vscode
1.9.0

Steps to Reproduce:

Using .NET Core SDK 1.0.4, run dotnet new console
Open the project in VS Code with the C# extension 1.9.0
dotnet add package Microsoft.AspNetCore
dotnet restore
dotnet build
In VS Code add the following using statements in Program.csusing Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Hosting;

Red squiggles, even though the build just succeeded:

Copied from original issue: OmniSharp/omnisharp-roslyn#869

From @danroth27 on May 20, 2017 16:42
@DustinCampbell

From @danroth27 on May 20, 2017 16:41
Doing the restore from within VS Code seems to address the issue.

@danroth27: I wasn't able to reproduce with the latest version of C# for VS Code (1.10). Could you try with the latest update to C# for VS Code and let me know if you still see the issue? If so, maybe I'm missing something in the repro steps.

Not sure if this is exactly the same issue but it feels similar. I'm often switching between VS and Code. With 1.10.0 (and previous versions), I am getting problems being highlighted for errors even if they have been fixed. The problems will go away if you start editing the class. So I'm guessing unless code "feels" like it's being modified it refuses to check, regardless if the file contents change.

Closing out older issue without a repro. This doesn't reproduce for me either, so my guess is it got resolved somewhere along the line.


feat: Display execution trace

Still left to do / to figure out:

[ ] Do we need to show memory line numbers (addr)?
[ ] Make ap, fp, pc clickable -> should scroll to particular line
[ ] Fix UI for CASM
[ ] Ensure everything works in dark mode
[ ] Would be nice to add "fullscreen" mode
[ ] Add breakpoints
[ ] How can we make the execution more understandable?


JSONDecodeError when inserting

Describe the bug
I'm getting a JSON Decode Error in SyncQueryRequestBuilder.execute. Any idea what happened?
Exact error message:
File ~/.asdf/installs/python/3.11.0/lib/python3.11/site-packages/postgrest/_sync/request_builder.py:62, in SyncQueryRequestBuilder.execute(self)
     53 r = self.session.request(
     54     self.http_method,
     55     self.path,
   (...)
     58     headers=self.headers,
     59 )
     61 try:
---> 62     return APIResponse.from_http_request_response(r)
     63 except ValidationError as e:
     64     raise APIError(r.json()) from e
...
    354 except StopIteration as err:
--> 355     raise JSONDecodeError("Expecting value", s, err.value) from None
    356 return obj, end

JSONDecodeError: Expecting value: line 1 column 1 (char 0)

To Reproduce
Steps to reproduce the behavior:
import os

from supabase import create_client, Client

url: str = os.getenv("SUPABASE_URL")
key: str = os.getenv("SUPABASE_KEY")
supabase: Client = create_client(url, key)

def storeRepos(toAddRepos):

    #fetch current repos
    supabaseCurrentRepos = supabase.table("repos").select("name").execute()
    currentRepos = [r["name"] for r in supabaseCurrentRepos.data]

    for repo in toAddRepos:
        # check if already exist
        if currentRepos.count(repo["name"]) == 0:
            repo["scraped"] = False
            supabase.table("repos").insert(repo).execute()
            currentRepos.append(repo["name"])

storeRepos(testrepo)

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS using Python 3.11.0

Additional context
Add any other context about the problem here.

I got the same issue. As you mentioned the code works in Python 3.10

This is an issue over on the postgrest side of things. This issue provides a solution for the immediate term:
data = supabase.table("table_name").insert(
    json={'key': 'value'},
    returning="representation",
)

If using vscode, pylance will probably yell at you. Obviously you can type ignore, or you can import ReturnMethod from postgrest.types and cast the string to ReturnMethod.

@krummja Thanks for the insight, this saved me time.
One note (unless there's some other kind of casting I'm not aware of) casting prevents the type error, but doesn't prevent the problem - the exception gets raised. I think this is because the cast parameter truly becomes a ReturnMethod and therefore is stringifying improperly just the same. I had to ignore the error.

If using vscode, pylance will probably yell at you. Obviously you can type ignore, or you can import ReturnMethod from postgrest.types and cast the string to ReturnMethod.

Transferring to Postgrest-py for further investigation


Makes it ready to enable adding WMS layer

The adding WMS layer button was disabled, but the functionality is kept in the code.
A code bug issue was introduced during girder 2 migration that preventing enable adding WMS layer.
This PR fixes the issue and make it easy to enable the WMS feature easily.

@aashish24 Thanks. Sorry I missed your comment earlier, I'll merge it now.


Unary Tuples

A unary tuple is normalized to its content:
<<1; T>>
T
[T]

are all the same type and
<1;42>
42
(42)

are the same value.
This usually is helpful and senseful.
But it leads to errors in edge cases:
    n:.Nat,
    i:.Idx n,
    t:<< n; [I32,I32]>>,

If n is specialized to be 1, the array degenerates to a scalar.
Therefore, the projection
t#i#(1:(.Idx 2))

is invalid.
Example:
https://github.com/NeuralCoder3/thorin2/blob/matrix_dialect/lit/core/unary_tuple.thorin
Call:
./build/bin/thorin -o - lit/core/unary_tuple.thorin

Error:
lit/core/unary_tuple.thorin:13:13-13:15: error: index '0:(.Idx 1)' does not fit within arity '2'

Solution idea (possible related to an earlier discussion we had):
Also normalize the projection away.
A projection with 0:(.Idx 1) is the identity.

I think the normalization is already implemented in
https://github.com/AnyDSL/thorin2/blob/master/thorin/world.cpp#L191
But this code snippet does not seem to be applicable in this case for some reason.

As kind of related comment. We currently have many overloads like:
def->proj(i)

and
def->proj(n, i)

I'm seriously considering removing the first variant. It's just too easy to shoot yourself in the foot.


ios 16.4

please update the 16.4 release available here :)

Hi @liukliukliuk, thank you for the notice.
The new emoji in iOS 16.4 are still in beta, and therefore subject to change until the stable release is published. This is estimated to happen in 1-2 months from now. We will update the emoji then, so we ask for a bit of patience 🙂
PS: The release you linked includes only the compiled fonts. These will not work on Linux since they follow the format from Apple (see this comment).

These will not work on Linux since they follow the format from Apple

That's why I was expecting you to update your repo, because I wanted to use them from now. But thank you anyway

The 16.4 emoji are now available at https://github.com/samuelngs/apple-emoji-linux/releases/tag/v16.4.
I've also updated the AUR package for the Arch Linux users out there.
Enjoy! 🙂


Control the build output directory structure

🚀 Feature request
Command (mark with an x)

- [ ] new
- [x] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Description
Right now, running ng build, generates a flattened directory structure.
In of itself, there's nothing wrong with this, so "not a bug".
However, when serving via some frameworks, for example "Flask", angular's build directory structure becomes a pain point of either your js/css assets throwing 404's, or your media assets throwing 404's.
Not without plenty of cp/mv/rm/etc magic to go along with it.
Describe the solution you'd like
There already exists --deploy-url  but doesn't affect the output structure like you'd expect.
I'd like, ideally, to have an angular.json architect option to specify where I want my js and css files to be placed.
      "architect": {
        "build": {
          "builder": "@angular-devkit/build-angular:browser",
          "options": {
            "outputPath": "../src/client_build",
            "index": "src/index.html",
            "main": "src/main.ts",
            "polyfills": "src/polyfills.ts",
            "tsConfig": "src/tsconfig.app.json",
            "assets": [
              "src/favicon.ico",
              "src/static"
            ],
            "assetsOutputPath": "static/media",
            "styles": [
              "node_modules/bootstrap/scss/bootstrap.scss",
<EMAIL_ADDRESS>              "node_modules/ngx-toastr/toastr.css",
              "src/styles.scss"
            ],
            "stylesOutputPath": "static/css",
            "scripts": [
<EMAIL_ADDRESS>            ],
            "scriptsOutputPath": "static/js",
            "es5BrowserSupport": true
          },

See as I've got a few *OutputPath options in there now where I can explicitly say within the context of outputPath where I want the build to spit out the js files and adjust the internal directory pathing to reflect.
Describe alternatives you've considered
I've followed several Flask specific angular guides to no effect.  Additionally while im in a fortuitous position to make adjustments to the server side layer, I know many many many others do not have that luxury.
I also know Flask isn't unique in this scenario, it's just the one affecting me right now.
The react-app I just replaced with Angular, had the following directory structure
client_build
|_ index.html
|_ static/
   |_ media/
      |_ *.png
   |_ js/
      |_ *.js
   |_ css/
      |_ *.css

When placed verbatim into a Flask configuration such as
template_dir = os.path.abspath('client_build')
static_dir = os.path.abspath('client_build/static')

app = Flask(
    __name__,
    template_folder=template_dir,
    static_folder=static_dir,
)

it works perfectly. Everything is found, everything functions as it should.
When I place the angular distribution in there, the index.html loads fine, but everything else fails to load, js/css/images included.
I've been monkeying with Flask and angular-cli for days now trying to find the sweet spot configuration wise, but it still isn't quite there.
currently I have as modified build options
    "build-dev": "ng build --watch --deploy-url=/assets/",
    "build": "ng build --deploy-url=/assets/ && cp ../src/client_build/assets/* ../src/client_build/ && rm -rf ../src/client_build/assets",
    "build-prod": "ng build --prod --build-optimizer --delete-output-path --optimization --progress --vendor-chunk --aot --deploy-url=/assets/ && cp ../src/client_build/assets/* ../src/client_build/ && rm -rf ../src/client_build/assets",

with a flask config like
template_dir = os.path.abspath("client_build")
static_dir = os.path.abspath("client_build")
static_url = "/assets"

app = Flask(
    __name__,
    template_folder=template_dir,
    static_folder=static_dir,
    static_url_path=static_url,
)

and the problem I face now, is that all of my everything is in the root directory, images included, AND, with the build-dev script, the app works but all the images are missing because the --watch doesn't know to manipulate the output directory every time.
I know this isn't a Flask help thread, but if I could just tell angular-cli where to put things (like I feel I should be able too..) I would be a much happier camper.   Not every hosting situation for angular output is going to be like throwing the distribution into an s3 bucket and calling it a day.

Doesn't the resourcesOutputPath option help you with that?
Also note that the you can already specify where to output the assets.
Example:
"assets": [
  { "glob": "**/*", "input": "src/assets/", "output": "/assets/" },
  { "glob": "favicon.ico", "input": "src/", "output": "/" },
]

See  https://angular.io/cli/build and https://next.angular.io/guide/workspace-config#project-asset-configuration for more details.

Doesn't the resourcesOutputPath option help you with that?
Also, note that the you can already specify where to output the assets.
Example:
"assets": [
  { "glob": "**/*", "input": "src/assets/", "output": "/assets/" },
  { "glob": "favicon.ico", "input": "src/", "output": "/" },
]

See https://angular.io/cli/build and https://next.angular.io/guide/workspace-config#project-asset-configuration for more details.

You know when you're looking everywhere for an answer to a seemingly easy problem, and nothing comes up, and independent dissection into the code doesn't help much...
I want to try this. Let me get back to you on this. Thank you so much for pointing this out!

Doesn't the resourcesOutputPath option help you with that?

This helps a little, unfortunately this only seems to work with fonts, some images, and everything else not involving the .js
I'm looking to as well move the *.js files to the /assets folder

Also, note that the you can already specify where to output the assets.
Example:
"assets": [
  { "glob": "**/*", "input": "src/assets/", "output": "/assets/" },
  { "glob": "favicon.ico", "input": "src/", "output": "/" },
]

See https://angular.io/cli/build and https://next.angular.io/guide/workspace-config#project-asset-configuration for more details.

There doesn't appear to be an output available in the angular.json for where to stash these js files

Angular CLI doesn't have an option to configure where assets of particular types go inside the output folder, no.
It sounds like something simple to add but I think it'd end up being fairly complex. JS and CSS files can attempt to load both media and css resources. Making those work is probably possible but requires a lot of rewiring in the js/css pipeline. It also requires that all the css processors we support (scss/sass/less/stylus) have options for this, and if they don't then we'd have to add our own custom rewiring plugins.
Trying to adopt Flasks specific requires sounds like a slippery slope: what about other servers that also expect different file structures? I can't say I know much about Flask but I find it hard to imagine there's no way to just serve the files in a directory as most basic servers do. I don't think it makes a lot of sense to add options to massage valid output to the liking of individual servers, and would expect that servers can be configured to accept valid output.

I can't say I know much about Flask but I find it hard to imagine there's no way to just serve the files in a directory as most basic servers do

Hi @filipesilva
Flask isn't a difficult framework to learn, but if you're more familiar with Node then I found a somewhat closeish parallel: https://github.com/fastify/fastify where I ran into a pretty similar issue
Web frameworks like Express and Symfony are extremely easy to setup with Angular due to how you configure the static resource basically at it's core simply being a folder.
Web frameworks Flask do it different where I think it's instead trying to manipulate it's router.
What I would offer to challenge is to setup a very very basic does-nothing flask app, and just try to get an Angular production-build and dev-watch-build output into it.
Honestly, it may be very easy and I'm just missing something, but it feels very incompatible with how these frameworks want to work with static assets

Closing as it is not in the Angular CLI roadmap to change the output structure and emit files in type folders.

Closing as it is not in the Angular CLI roadmap to change the output structure and emit files in type folders.


[RFC]: Add C implementation for @stdlib/stats/base/dists/pareto-type1/kurtosis

Description
This RFC proposes adding a C implementation, including a Node.js native addon, C benchmarks, and C examples, for the @stdlib/stats/base/dists/pareto-type1/kurtosis package.
When adding support, the following tasks should be completed:

A C source implementation should be added to a src folder within the package's directory.
A native add-on interface should be added in order to call the C implementation from JavaScript.
A JavaScript file should be added to the lib folder to allow benchmarking and unit testing the native implementation from JavaScript.
A new test file should be created which includes unit tests testing against expected behavior.
C benchmarks should be added which measure performance for the C source implementation.
A file containing C examples should be added to demonstrate example usage.
JavaScript benchmarks should be added which measure performance for the native add-on.
Build and configuration files should be added to allow compiling and running the C source implementation using project make commands (as documented below).
The README should be updated to include documentation for the added C API.

To provide a concrete example of what a PR adding the desired method should contain, see https://github.com/stdlib-js/stdlib/pull/3354, which is a PR adding a C implementation for the CDF of an arcsine distribution. This should provide an idea of what is expected.
Prerequisites

Review JavaScript implementation in lib/main.js and its required modules to identify all stdlib functions used.
Verify C implementations exist for each required function.

Related Issues
#3355
Questions
No.
Other
Once the implementation is ready including C examples and benchmarks, we should be able to run the following make commands.
Build native add-on
NODE_ADDONS_PATTERN="@stdlib/stats/base/dists/pareto-type1/kurtosis" make install-node-addons

Run C examples
make examples-c-files<EMAIL_ADDRESS>
Run C benchmarks
make benchmark-c-files<EMAIL_ADDRESS>
Run JavaScript benchmarks
make benchmark-javascript-files<EMAIL_ADDRESS>
Run all tests
make<EMAIL_ADDRESS>test

Notes

If you are interested in contributing a PR which addresses this RFC and are a first-time contributor or not yet familiar with our project conventions, please minimize the submission of LLM-generated code. Please consult our contributing guidelines and the associated development guide. Failure to respect project conventions will result in your PR being rejected without review. Thank you for understanding!

Checklist

[x] I have read and understood the Code of Conduct.
[x] Searched for existing issues and pull requests.
[x] The issue name begins with RFC:.

Working


Contributing to auto-generated files?

I was just about to work on #230 when I noticed the warning at the top of the file:
# AUTO-GENERATED! DO NOT EDIT FILE DIRECTLY
# SEE CONTRIBUTOR DOCUMENTATION

I checked:  https://github.com/okta/okta-sdk-python/blob/master/CONTRIBUTING.md
But there's nothing there on the subject.  I'm guessing some or all of the models are generated from OpenAPI or similar?  The fix for Group Profiles is pretty simple, but does this mean that we'd need to wait for the OpenAPI data to update instead of adding profile support directly?

@explody yes, all models are being generated in accordance with openapi spec: https://github.com/okta/okta-management-openapi-spec
And for given particular case I've provided PR - https://github.com/okta/okta-sdk-python/pull/238 (though, we haven't released it yet). I think, we should update contributing guide to explain this nuance, I'll put such task to our backlog.
Does it work for you?

Looks great, pretty much exactly what I was about to try manually :P
I suppose the question is for cases like this - is it a matter of keeping model code up to date with the changing OpenAPI spec?  Or does this involve updating the spec itself first?
Put another way, is this something 3rd party contributors can do, or should we just expect to wait on the models to catch up to the spec?
Either way is fine, just for future reference...

Yes, we need to update spec first. We can't release sdk if it diverges from spec. On the other hand, 3rd party contributors can generate sdk based on a new spec release and create a PR (if we didn't do this in time, of course).

Got it, thank you.  Just FYI PR #238 get close but I don't see group_profile.py being updated yet, so the profile data still doesn't make it to the client (just confirmed this locally).  But, we can take this conversation back to #230
Thanks!


As a registered user, I want to create posts for products so that I can share my thinking about this product

Estimate
Large
Acceptance Criteria
Feature: Creating posts
  As a registered user, I want to create posts for products so that I can share my thinking about this product

Scenario: Successfully create posts
  Given I am a registered user
  When I click the “New Post” button
  And I choose the product that I want to create post for
  And I finish write the post
  And I click the submit button
  Then a notification should be given that tells me the post has been successfully created
  And I should see my new post on the “Home” page

Scenario: Unsuccessfully create posts
  Given I am a registered user
  When I click the “New Post” button
  And I choose the product that I want to create post for
  And I leave my post as blank
  And I click the submit button
  Then a notification should be given that tells me the post should not be blank
  And I stay in the creation post session

moved this from In Review to Done

moved this from In Review to Done


[core] add range check of snapshot id during scan to prevent endless waiting

Purpose
[core] add range check of snapshot id during scan to prevent endless waiting.  This will fix #807 .
Tests
No.
API and Format
No.
Documentation
No.

In the exception message, we should remind the user what to do at this point to avoid this situation, e.g:

increase the snapshot expiration time.
Use consumer-id: https://github.com/apache/incubator-paimon/pull/1022

In the exception message, we should remind the user what to do at this point to avoid this situation, e.g:

increase the snapshot expiration time.
Use consumer-id: [core] Introduce consume-id for retore consuming and reserve snapshot #1022

@JingsongLi resolved


Moderate cleaning; code unchanged except equivalent inlining, simplified object init, etc

Moderate cleaning; code unchanged except equivalent inlining, simplified object init, etc.

Demo project namespaces made uniform as:
Template10.Demo.ImageExControlDemo
Template10.Demo.ResizerControlDemo
Template10.Demo.RingSegmentControlDemo
Template10.Demo.KeyboardServiceDemo

Most unused using removed but not done 100% yet.

Solution as currently setup builds without any errors [noting that there are projects not yet included in the current Solution: Sample projects, Blank project, Hamburger project]

Views folder was really irrelevant for NetworkService and SecretService demo projects, so contents moved up directory and Views folder removed.

Accidentally closed while messing with Git Bash. Sorry.
Moderate cleaning; code unchanged except equivalent inlining, simplified object init, etc.

Demo project namespaces made uniform as:
Template10.Demo.ImageExControlDemo
Template10.Demo.ResizerControlDemo
Template10.Demo.RingSegmentControlDemo
Template10.Demo.KeyboardServiceDemo

Most unused using removed but not done 100% yet.

Solution as currently setup builds without any errors [noting that there are projects not yet included in the current Solution: Sample projects, Blank project, Hamburger project]

Views folder was really irrelevant for NetworkService and SecretService demo projects, so contents moved up directory and Views folder removed.


Fixing visual and functional issues given the feedback

This PR fixes #18, fixes #19, fixes #20, fixes #21, fixes #22, fixes #24, fixes #25, fixes #27, fixes #28, fixes #29, fixes #30, fixes #31, fixes #33
Main highlight: attention messages have separate container on the right side of the log, so they dont push the log.

Thank you Ivo, the improvements look good! There are still some minor issues though:

regarding issue #19 I think it would be great to fit it all on a normal laptop screen (you can probably decrease the font size)
there is a minor alignment issue with the IP addresses of the robots
regarding issue #25 it should be sufficient to just swap robot list and point list (as you did), but to keep the points at the very top because they are kind of the key information
somehow the order-confirmation pop-ups didn't work anymore when I tested it

Dani, thanks for the feedback, it was really on point!
Could you have another look after the latest commits?

Thank you for changes Ivo! It looks really good. After discussing with Tarik there is only one thing left: you are using "cmplx" to mark the complexity of an order, we would prefer "complexity" if the space allows it or "complex". Besides that, great work!

Glad you both like it! Using Complexity takes somewhat unnecessary space, so I went with Complex instead.
Thank you both!

Thank you for all the feedback!


feat: Support create JavaFX projects

part of https://github.com/microsoft/vscode-java-pack/issues/856
Signed-off-by: Sheng Chen<EMAIL_ADDRESS>

I'm OK with this change, and there are some errors in the UI test about create command, I'll add a commit here to fix it.


add CLOMonitor and Artifacthub badges to README

Signed-off-by: Bill Mulligan<EMAIL_ADDRESS>Please ensure your pull request adheres to the following guidelines:

[x] For first time contributors, read Submitting a pull request
[x] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[x] Provide a title or release-note blurb suitable for the release notes.
[x] Thanks for contributing!

Adding CLOMonitor and Artifacthub badges to the README
Badges for CLOMonitor and Artifacthub were added to the README

@qmonnet let's do that in a separate PR and merge this one as is

Sounds good (although not sure that's even worth a follow-up PR). Would you mind removing the second Co-Authored-By: from your commit description to appease checkpatch (and myself :stuck_out_tongue_winking_eye:), please? Feel free to remove them both, even. I haven't exactly authored the commit.


some sort of problem

Not sure whats wrong exactly, but the code in this repo doesnt produce the right output (its missing a lot of people).
Heres the go code i wrote that seems to be correct:
package main

import (
        "context"
        "encoding/json"
        "fmt"
        "github.com/google/go-github/github"
        "golang.org/x/oauth2"
        "io/ioutil"
        "net/http"
        "os"
        "strings"
)

var authtok = "YOUR GITHUB AUTH TOKEN"
var ghurl = "https://api.github.com"

var cli = oauth2.NewClient(context.Background(), oauth2.StaticTokenSource(&oauth2.Token{AccessToken: authtok}))

func getBlob(res string) ([]byte, error) {
        fname := "data/" + strings.Replace(res, "/", "-", -1)
        if _, err := os.Stat(fname); err == nil {
                return ioutil.ReadFile(fname)
        }

        req, err := http.NewRequest("GET", ghurl+res, nil)
        if err != nil {
                panic(err)
        }

        resp, err := cli.Do(req)
        if err != nil {
                return nil, err
        }

        if resp.StatusCode != 200 {
                return nil, fmt.Errorf("%s failed: %s", res, resp.Status)
        }

        data, err := ioutil.ReadAll(resp.Body)
        if err != nil {
                return nil, err
        }

        err = ioutil.WriteFile(fname, data, 0644)
        if err != nil {
                return nil, err
        }

        return data, nil
}

func getAllRepos(org string) []github.Repository {
        var repos []github.Repository
        for i := 1; i < 100; i++ {
                data, err := getBlob(fmt.Sprintf("/orgs/%s/repos?page=%d&per_page=100", org, i))
                if err != nil {
                        panic(err)
                }

                var these []github.Repository
                if err := json.Unmarshal(data, &these); err != nil {
                        panic(err)
                }
                repos = append(repos, these...)
                if len(these) < 100 {
                        break
                }
        }
        return repos
}

func getAllPRs(repo github.Repository) []github.PullRequest {
        var all []github.PullRequest
        for i := 1; i < 100; i++ {
                data, err := getBlob(fmt.Sprintf("/repos/%s/%s/pulls?page=%d&per_page=100&state=all", "ipfs", repo.GetName(), i))
                if err != nil {
                        panic(err)
                }

                var these []github.PullRequest
                if err := json.Unmarshal(data, &these); err != nil {
                        panic(err)
                }
                all = append(all, these...)

                if len(these) < 100 {
                        break
                }
        }

        return all
}

func getAllIssues(org string, repo github.Repository) []github.Issue {
        var all []github.Issue
        for i := 1; i < 100; i++ {
                data, err := getBlob(fmt.Sprintf("/repos/%s/%s/issues?page=%d&per_page=100&state=all", org, repo.GetName(), i))
                if err != nil {
                        panic(err)
                }

                var these []github.Issue
                if err := json.Unmarshal(data, &these); err != nil {
                        panic(err)
                }
                all = append(all, these...)

                if len(these) < 100 {
                        break
                }
        }

        return all
}

func getAllComments(org, repo string, issue github.Issue) []github.IssueComment {
        var all []github.IssueComment
        for i := 1; i < 100; i++ {
                data, err := getBlob(fmt.Sprintf("/repos/%s/%s/issues/%d/comments?page=%d&per_page=100&state=all", org, repo, issue.GetNumber(), i))
                if err != nil {
                        panic(err)
                }

                var these []github.IssueComment
                if err := json.Unmarshal(data, &these); err != nil {
                        panic(err)
                }
                all = append(all, these...)

                if len(these) < 100 {
                        break
                }
        }

        return all
}

type output struct {
        Url      string `json:"url"`
        Photo    string `json:"photo"`
        Username string `json:"username"`
}

func main() {
        allpeople := make(map[string]*github.User)
        for _, org := range []string{"ipfs", "ipld", "multiformats", "libp2p", "orbitdb"} {
                repos := getAllRepos(org)

                for _, repo := range repos {
                        issues := getAllIssues(org, repo)
                        for _, issue := range issues {
                                issue.Repository = &repo
                                allpeople[*issue.User.Login] = issue.User
                                comments := getAllComments(org, repo.GetName(), issue)
                                for _, c := range comments {
                                        allpeople[c.User.GetLogin()] = c.User
                                }
                        }
                }
        }

        var out []output
        for k, v := range allpeople {
                out = append(out, output{
                        Url:      v.GetHTMLURL(),
                        Photo:    v.GetAvatarURL(),
                        Username: k,
                })
        }
        enc := json.NewEncoder(os.Stdout)
        enc.SetIndent("", "  ")
        if err := enc.Encode(out); err != nil {
                panic(err)
        }
}

Got it, @RichardLitt went for all contributors on repos (code contributors) -- https://github.com/ipfs/get-gh-contributors/blob/master/src/fetch.js#L37 -- while you went to a more board definition of a contributor. Makes sense to me :) I'm not sure if it was a decision at the time to only check code commiters, but new version looks better. woot!

We previously talked about counting people filing issues and commenting on issues as contributors too, which is the approach i took

Yep. That was the approach for name-your-contributors. This code merely got the contributors as defined by GitHub, most likely due to time constraints. But what you outline above is more inclusive, and therefore, IMHO, better. 👍

https://github.com/RichardLitt/name-your-contributors works now. Might be worth looking into and using for this.

@ipfs/dx team, Can I ask your help to get this get-gh-contributors running so that we get the latest head count?

@diasdavid seems name-your-contributors (by RichardLitt) mentioned above would do the same thing as the program whyrusleeping suggested, could we just use that? What's the ask here, to have it running with API endpoints rather than as a CLI?

@VictorBjelkholm I need the dataset -- https://github.com/ipfs/contributors-hex-grid/blob/master/public-vertical/js/contributors.js -- to be up to date.
I'm fine with either tool, as long as it is accurate.

Note to self. The go program expects a data folder to exist otherwise it panics

@RichardLitt name-your-contributors is looking rad! It is just unfortunate that it currently fails for orgs https://github.com/mntnr/name-your-contributors/issues/72

Just finished running the script and learned that something has changed because I'm no longer getting 3000 +++ like last time, just 2441 for this round. Trying to find the time to figure this one out.

New updated number 3758

@daviddias Sorry that it fails! Did you get it working? I've been slammed the past couple of days.


Ship the Code Review post for energy

Adds a blog post for the Energy code review video I made for @mennenia
@ashfurrow - I changed some of our titles to make it more obvious there's a connection between all the videos, and cleaned up the review tag, which is something we could use to link them and more if we choose. Also, my editor removed your extra whitespacing.

:tada: meergee

will ship this to the source repo :+1:


Vintage mode doesn't fill in template

Question marks are left instead

fixed sometime over the last month


280 move to pydantic forms

This PR adds pydantic_forms library as a dependency, and uses the external library for form processing.

Codecov Report

Merging #308 (5e9dc49) into main (54d0f3c) will decrease coverage by 0.56%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
- Coverage   76.68%   76.13%   -0.56%
==========================================
  Files         165      164       -1
  Lines        8500     8262     -238
  Branches     1370     1328      -42
==========================================
- Hits         6518     6290     -228
+ Misses       1789     1782       -7
+ Partials      193      190       -3

Impacted Files
Coverage Δ

orchestrator/app.py
86.25% <100.00%> (ø)

orchestrator/exception_handlers.py
75.00% <100.00%> (ø)

orchestrator/forms/validators.py
100.00% <100.00%> (+4.02%)
:arrow_up:

orchestrator/services/processes.py
90.78% <100.00%> (+0.03%)
:arrow_up:

orchestrator/utils/show_process.py
100.00% <100.00%> (ø)

orchestrator/workflow.py
92.58% <100.00%> (ø)

orchestrator/workflows/modify_note.py
100.00% <100.00%> (ø)

orchestrator/workflows/utils.py
49.10% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

The ProductId form validators probably can't move out of the orch-core because they depend on orchestrator.services module.
Moving the network_type_validators to the pydantic_forms library is totally possible, if they seem like they will be universally useful to other consumers of pydantic_forms -- I can create a separate PR for that...


⚠ Samsung has degraded performance

In d930e2d, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2546 ms

Resolved: Samsung performance has improved in 2494fac.


Error installing gRPC-Core

Trying to use Speech Beta version.
Did a pod install from "ios-docs-samples-speech-v1beta1/speech/Objective-C/Speech-gRPC-Streaming" folder and got the following error
Error installing gRPC-Core
Failed to download 'gRPC-Core'.
Also got the same error when installing from "ios-docs-samples-speech-v1beta1/solutions/stickynoteapi/gRPC/Swift" folder
ProductName:	Mac OS X
ProductVersion:	10.14.1
BuildVersion:	18B75

@makmak7 Couldn't able to reproduce the issue, Can you please share the complete error message which you are getting?
Thanks.

Samples in the master works great. The challenge is in speech-v1beta1. I am outside the VPN and running this pod install in WIFI.
Attached is the snap shot of the error message.

Are you looking to use the beta libraries? For a certain beta Speech feature?
The speech-v1beta1 branch is about 3 years old and is likely out of date.

I got the same error(screenshot attached for the reference). Can't understand what to do to resolve this issue.

 Is this repo out of date?

I got the same error(screenshot attached for the reference). Can't understand what to do to resolve this issue.

 Is this repo out of date?

Did you find a solution??

Now, how to solve it ?? base in China

how fix it recently?


[SPARK-19337] [ML] [Doc] Documentation and examples for LinearSVC

What changes were proposed in this pull request?
Documentation and examples (Java, scala, python, R) for LinearSVC
How was this patch tested?
local doc generation

Test build #73020 has started for PR 16968 at commit 7a0829f.

Test build #73020 has finished for PR 16968 at commit 7a0829f.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class JavaLinearSVCExample

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73020/
Test PASSed.

I see. I will drop the R example here, whichever PR goes in later can finish the document update.

title should say
[SPARK-19337] [ML] [Dcoc]
->
[SPARK-19337] [ML] [Doc]

Thanks for the comment @felixcheung

Test build #73071 has started for PR 16968 at commit b888f35.

Test build #73071 has finished for PR 16968 at commit b888f35.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73071/
Test PASSed.

Test build #73132 has started for PR 16968 at commit 165fbe4.

Thanks for the review. Updated to binary.
Also add the reference to R example.

Test build #73132 has finished for PR 16968 at commit 165fbe4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73132/
Test PASSed.

merged to master.


Better interface for decode

On success, decode returns a tuple with the decoded entity and an empty string. Instead, it would be nice if it did something like:
case MyThriftStruct.BinaryProtocol.decode(binary_data) do
  {:ok, %MyThriftStruct{}=s} ->
       s
   {:more, %MyThriftStruct{}=s, extra_data} ->
      ...
   {:error, reason} ->
      ...
end

I think it's straightforward to match away the leftover "". It's a common enough pattern in Elixir.
iex(1)> Integer.parse("123")
{123, ""}

I disagree, from a user's perspective it's unnecessary in most cases and cumbersome, which might be why I don't use Integer.parse.
iex(2)> String.to_integer("123")
123

Also, ignore my suggestion; feel free to implement it in other ways.

I'm with @pguillory on this - returning {value, remainder} or :error is how the various .parse functions work.  You could also supply a banged decode! function that returns the value on success and raises on failure.

alright.


Update code to Python 3

Still to do: stomp.py

I had a quick go at getting this branch to run on my Mac with Homebrew and wxpython 4.0.6
But unfortunately it was unable to find wx:
~/Projects/RadioVisDemo(python3) $ python3 radiovis_demo.py
Traceback (most recent call last):
  File "radiovis_demo.py", line 24, in <module>
    import wx
ModuleNotFoundError: No module named 'wx'

I will try again soon...

Tried again on my Mac using:
pip3 install -r requirements.txt

Which successfully installed:
~/Projects/RadioVisDemo(python3) $ pip3 install -r requirements.txt
Collecting wxPython>=4.0.0 (from -r requirements.txt (line 1))
  Downloading https://files.pythonhosted.org/packages/50/89/b41b640c24879acf6b3bd6f5f349da8d89956f07f7be1d0a45aea1403b27/wxPython-4.0.6-cp37-cp37m-macosx_10_9_x86_64.whl (31.3MB)
    100% |████████████████████████████████| 31.3MB 975kB/s
Collecting dnspython (from -r requirements.txt (line 2))
  Using cached https://files.pythonhosted.org/packages/ec/d3/3aa0e7213ef72b8585747aa0e271a9523e713813b9a20177ebe1e939deb0/dnspython-1.16.0-py2.py3-none-any.whl
Requirement already satisfied: nose in /usr/local/Cellar/numpy/1.16.4/libexec/nose/lib/python3.7/site-packages (from -r requirements.txt (line 3)) (1.3.7)
Collecting stomp.py (from -r requirements.txt (line 4))
  Downloading https://files.pythonhosted.org/packages/52/7e/22ca617f61e0d5904e06c1ebd5d453adf30099526c0b64dca8d74fff0cad/stomp.py-4.1.22.tar.gz (50kB)
    100% |████████████████████████████████| 51kB 3.2MB/s
Collecting pillow (from wxPython>=4.0.0->-r requirements.txt (line 1))
  Downloading https://files.pythonhosted.org/packages/8f/f3/c6d351d7e582e4f2ef4343c9be1f0472cb249fb69695e68631e337f4b6e9/Pillow-6.1.0-cp37-cp37m-macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl (3.8MB)
    100% |████████████████████████████████| 3.9MB 2.7MB/s
Collecting six (from wxPython>=4.0.0->-r requirements.txt (line 1))
  Using cached https://files.pythonhosted.org/packages/73/fb/00a976f728d0d1fecfe898238ce23f502a721c0ac0ecfedb80e0d88c64e9/six-1.12.0-py2.py3-none-any.whl
Requirement already satisfied: numpy in /usr/local/lib/python3.7/site-packages (from wxPython>=4.0.0->-r requirements.txt (line 1)) (1.16.4)
Collecting docopt>=0.6.2 (from stomp.py->-r requirements.txt (line 4))
  Downloading https://files.pythonhosted.org/packages/a2/55/8f8cab2afd404cf578136ef2cc5dfb50baa1761b68c9da1fb1e4eed343c9/docopt-0.6.2.tar.gz
Building wheels for collected packages: stomp.py, docopt
  Building wheel for stomp.py (setup.py) ... done
  Stored in directory: ~/Library/Caches/pip/wheels/89/cc/a4/10aa548d72cc4838c42c4874a54b14e35dc40c627477c01b17
  Building wheel for docopt (setup.py) ... done
  Stored in directory: ~/Library/Caches/pip/wheels/9b/04/dd/7daf4150b6d9b12949298737de9431a324d4b797ffd63f526e
Successfully built stomp.py docopt
Installing collected packages: pillow, six, wxPython, dnspython, docopt, stomp.py
Successfully installed dnspython-1.16.0 docopt-0.6.2 pillow-6.1.0 six-1.12.0 stomp.py-4.1.22 wxPython-4.0.6

However, when starting:
~/Projects/RadioVisDemo(python3) $ python3 radiovis_demo.py
Traceback (most recent call last):
  File "radiovis_demo.py", line 27, in <module>
    from lib.connection_manager import ConnectionManager
  File "~/Projects/RadioVisDemo/lib/connection_manager.py", line 16, in <module>
    import socks
ModuleNotFoundError: No module named 'socks'

Is this a missing dependency?

Yes, this was missing PySocks dependency, now added.


Live Flash Stream in Internet Explorer with recent Flash plugin stops after a few seconds

When I stream a live audio/video feed to nginx-rtmp and play it back in a Flash player running in Internet Explorer on Windows, the stream stops after a few seconds.
A flash player in a different browser (even on the same computer) plays back the stream fine for multiple hours. Mac and Linux clients work well, too.
When I replace the nginx server with Wowza, it works fine on all brwosers.
When I use a stream that has only audio, it works fine on all browsers.
When I use a stream that has only video, it works fine on all browsers.
When I start the player before I start the live feed, it works fine on all browsers.
When I start the live feed using exec_play, the first IE player that connects to the stream (which then execs the live feed right at the moment the player connects) plays fine. The second IE player (which then connects to the already running live feed) doesn't work anymore. Non-IE players work fine.
Playing back on demand streams works fine in all cases.
My setup is the following:
Live source: I tried many live sources with the same result. Live encoding from ffmpeg from a audio/video device, as well as live encoding from a file (using "ffmpeg -re -i file -f flv rtmp:////<tream"). I have tried feeding from Wirecast. I have tried feeding h.264/AAC content as well as VP6/mp3. The result is always the same.
Nginx-rtmp server: It happens with the latest nginx-rtmp-module from Git with nginx 1.4.4, as well as with a server I compiled in March 2013, as well as one from November 2013. The result is always the same.
Player: I've used jwplayer (from http://www.jwplayer.com/wizard, with "rtmp:////" as the "source" - the same server, app and stream as I used at the live feed. It also happens with a custom flash player.
Client computer: It happens with the latest Flash plugin; I tested <IP_ADDRESS>, <IP_ADDRESS> and 11.9.900.170) on Windows in Internet Explorer. The same version of the Flash Plugin on the same computer, in a different Browser (I tested Firefox and Chrome) work fine.
With an older Flash plugin (tested 11.8.800.875), it works fine in all browsers.
So, for me it looks like a bug in the Flash plugin - but, since it works when I replace nginx-rtmp with Wowza, maybe there is something that can be done in nginx-rtmp to make it work as well?
Kind regards,
Andreas Trottmann

Apparently I neglected to close the issue when the solution was published - sorry! Closing it now.


Update tests logic, after EACL accounts

The start point https://rest.fs.neo.org/7ZVSQHtioVRiDT2btN9xEmQhczXV9vryCEAHUawfD8Sc/308-1724050445/index.html#suites/6d7c9ec7c4f3e4460ae14fd266a64e04/88171d41aee11aef/
Current Behavior

test_bucket_acl_grant_email_not_exist - the test sends old owner data

ID must be equal to the DisplayName (address)

DisplayName = {string} "NNAsHLb7CfTRb1Z8P9GEdb9LW32cik7gPh" // address
ID = {string} "03c70a35741e3b811bec892b982d29c6982b32cffcbb36bd3d286537b2fc6124d6" // public key

test_bucket_acl_grant_nonexist_user - uses _foo as userID. It is wrong and must be an address. You should replace it with any valid address. For instance: NNAsHLb7CfTRb1Z8P9GEdb9LW32cik7gPh

test_object_acl_full_control_verify_attributes - has problems similar to the first one. Wrong value in ID, sends public key

Expected Behavior
Possible Solution
I consider, we may find more issues with tests and I would suggest to replace ID with displayName in the init

https://github.com/nspcc-dev/s3-tests/blob/5813c6433b961244abee6d48879089f2a1e39dd0/s3tests_boto3/functional/__init__.py#L281 for all clients.

Partially fixed by https://github.com/nspcc-dev/s3-tests/pull/76. Regarding test_bucket_acl_grant_nonexist_user - this test intentionally sets invalid userid, s3 gw should handle it more gracefully, than 500 error code. 400 - would be good.

It was fixed by https://github.com/nspcc-dev/neofs-s3-gw/pull/983.

good, we have a fully green run - https://rest.fs.neo.org/7ZVSQHtioVRiDT2btN9xEmQhczXV9vryCEAHUawfD8Sc/320-1724156123/index.html, closing this issue.


github: Don't query teams yet

This requires a new permission for your access token, and
we don't want to make everyone add that.
Topic: teams
Reviewers: brian-k

#
head
base
diff
date
summary

0
356e0732
ea422227
diff
Oct 14 12:48 PM
1 file changed, 4 deletions(-)

Reviews in this chain:
└https://github.com/Skydio/revup/pull/77 github: Don't query teams yet


Expose api termination protection as variable

Is your feature request related to a problem?
We're looking at building out our firewall instances and would really like to enable termination protection given the importance these will have in our network. Currently your terraform is hardcoding that value to false in:
modules/vmseries/main.tf:73
I don't think we can override this anyway that won't have terraform trying to flip it back to false everytime we run it.
Describe the solution you'd like
As with other settings, please expose a new input variable that defaults to false but can be set, eg 'enable_instance_termination_protection'
Describe alternatives you've considered.
Since you're explicitly setting this value I don't think there is anything else I can do short of manually setting the protection on after creation and never running the terraform again. this feels likely to cause problems in the long term.
I guess I could fork this repo but I'd rather not.
Additional context
Whilst not a huge risk, it is certianly possible for someone to accidentally issue a termination command, either because they briefly confuse it with shutdown, or because they don't realise they have more than once instance selected when they are intentionally terminating another (ask me how I know ;-))
I'd obviously be happy to just default to forcing termination protection on if that is easier, but a variable should be straight forward.
I would be happy to submit a PR for it if that helps

Hello @wouldd, thanks for addressing this issue!
It makes sense to lease this option to a variable with default value. We can do it or as you said at the end of your message you can create PR to this issue to contribute!

nevermind, sorry first time raising a PR against a repo that isn't mine already ;-) I've created a fork and raised the PR. let me know if I needed to update anything else.