fix(ui-components): make Alert not dismissable

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #45206

This PR is to address https://github.com/freeCodeCamp/freeCodeCamp/pull/45015#discussion_r800721802, which was moved to #45206 for further discussion.
Basically, we will eventually have Alert and Flash components. Both are identical, but one is dismissable (Flash) and one is not (Alert). The Flash component is to be built, and a low-priority one. I have added it to our component list in the main issue (#44668).
This PR is to remove props that are related to the dismisability from the Alert component.
Screenshot

The "Dismisable" story on the sidebar no longer exists.
The component description is updated to mention that it is not dismissable.

Thank you for taking care of this.


performance and usability improvements (reopened)

Hello,
I'm reopening #31 against the develop branch, as requested.
Original description: I've been hacking modipy-youtube for a few days now trying to make it fast and improve usability. I ended up implementing several improvements (which, in my experience, make a big overall difference):

only handle search, allows browsing with no overhead
only 2 API calls in search, only takes a couple of secs
use the Youtube API for metadata, minimizing the number of calls.
pafy (expensive) is only used for playback
load data in the background, adding to playing queue is usually instantaneous
return playlists in search results
separate all API logic in youtube.py, backend.py is quite clean

Kostas

This is a very daunting pull request to review due to the size of the changes. Anything you can split off and create separate pull requests for will help towards getting this merged.

I opened a new PR (#46), a bit better than this one, but I cannot split it in multiple PRs.
Still I think the code is simple and the improvements are worth the trouble (the current version is barely usable: #24, #27).
I'm closing this PR to avoid confusion.


Sort output

The output should be sorted so that the diffs are consistent when new records are added or removed

closed with 7e6b3d


tensorflow1.3 bazel-bin/tensorflow/examples/label_image/label_image failed to run.

step 1:python tensorflow/examples/image_retraining/retrain.py    --architecture=inception_v3    --output_graph=inception_v3.pb  ....
step2: bazel build tensorflow/examples/label_image
step3: bazel-bin/tensorflow/examples/label_image/label_image
then get the following error:
tensorflow/examples/label_image/main.cc:349] Running model failed: Not found: FeedInputs: unable to find feed output input.
Any step wrong? Could you give me some hint?

What were the exact command line arguments you performed?
The label_image code expects the graph model to be named specifically inception_v3_2016_08_28_frozen.pb and the labels file to be named imagenet_slim_labels.txt unless you specify differently via command line flags.

This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!


Install libmptcpwrap.so in a dedicated directory

Describe the bug
For the moment, libmptcpwrap.so is installed with mptcpd plugins. It looks cleaner to install it in a dedicated directory
To Reproduce
make install
Expected behavior
It will be easier for the packaging to have dedicated directory because we need to split into different packages.
Desktop (please complete the following information):

Debian / Ubuntu packaging

Additional context
Packaging mptcpd for Debian and cie.

The following patch should provide the desired behavior:
diff --git a/src/Makefile.am b/src/Makefile.am
index 2b37d8a..8fafd59 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -62,7 +62,8 @@ else
 bin_PROGRAMS = mptcpd mptcpize
 endif

-pkglib_LTLIBRARIES = libmptcpwrap.la
+mptcpizedir = $(libdir)/mptcpize
+mptcpize_LTLIBRARIES = libmptcpwrap.la

 mptcpd_SOURCES = mptcpd.c
 mptcpd_LDADD   =

libmptcpwrap.* will end up being installed in $(libdir)/mptcpize.

This relates to Debian packaging related changes in #200.

@dcaratti Would this work for the Fedora package, too?

@dcaratti Would this work for the Fedora package, too?

I think yes, it should work  with proper adjustments of the specfile.

@ossama-othman thank you for the nice patch, it works as expected!

@ossama-othman thank you for the nice patch, it works as expected!
I guess because you wrote the patch, you will submit it, right? :)

Haha, sure. :+1:


Modify DA Interface to use SubmitBlobs from SubmitBlocks

Need to change the below method:
SubmitBlocks(ctx context.Context, blocks []*types.Block)

to have this signature:
SubmitBlobs(ctx context.Context, blocks []*types.Blob)

Note that the block to blob conversation should happen in manager.go.

@Manav-Aggarwal Do we need to change signature of SubmitBlock in DA interface?

@Manav-Aggarwal would like to this up!

Thanks @Chirag018! Just assigned it to you.

Hey @Manav-Aggarwal, sorry for working on this a little late.
I had a few doubts,
In the manager.go file, the submitBlocksToDA function where we will be modifying the changes, do we also need to modify the function name?
func (m *Manager) submitBlocksToDA(ctx context.Context) error {
	submitted := false
	backoff := initialBackoff
	for attempt := 1; ctx.Err() == nil && !submitted && attempt <= maxSubmitAttempts; attempt++ {
		res := m.dalc.SubmitBlocks(ctx, m.pendingBlocks.getPendingBlocks())

@Chirag018 No worries. Yes, the function name can be modified here if the block-to-blob conversion happens outside of it. Otherwise, it can stay the same.

Hi @Manav-Aggarwal, does this issue still open?

Will be part of #829


package gnome-theme-changer is not in GOROOT (/usr/lib/go-1.18/src/gnome-theme-changer)

Hi,
I am not "go" expert.
I have followed your instructions. The "gnome-theme-changer" file was created in ~/go/bin directory.
When I try to do "go run gnome-theme-changer" the output is:
package gnome-theme-changer is not in GOROOT (/usr/lib/go-1.18/src/gnome-theme-changer)
This is confusing, as I cannot find any instruction how to fix this sort of issue asddress to "golang dummies".
Can you help, please?
Rgs,
Ziggi

But now:
(org.gnome.Nautilus:3787): Gtk-WARNING **: 15:09:20.852: Theme parsing error: gtk.css:1:67: Failed to import: The resource at “/com/ubuntu/themes/Yaru-dark/3.0/gtk.css” does not exist
Arghhhh!

But now:
(org.gnome.Nautilus:3787): Gtk-WARNING **: 15:09:20.852: Theme parsing error: gtk.css:1:67: Failed to import: The resource at “/com/ubuntu/themes/Yaru-dark/3.0/gtk.css” does not exist
Arghhhh!
I had to return to Adwaita :(

I'll take a look at this in a Ubuntu VM, it seems like Ubuntu is storing the theme files in a non-standard location?


feat(default-theme): add custom class to block from cms

Changes
closes #768
Checklist

[x] I followed contributing guidelines

Cool, thanks! :)


SAA-830 you should be able to reallocate an offender to an activity if their previous allocations is ended.

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (842bda3) 85.27% compared to head (88eff13) 85.27%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #379   +/-   ##
=========================================
  Coverage     85.27%   85.27%
- Complexity     1903     1905    +2
=========================================
  Files           262      262
  Lines          7314     7314
  Branches        379      379
=========================================
  Hits           6237     6237
  Misses          879      879
  Partials        198      198

Impacted Files
Coverage Δ

...activitiesmanagementapi/entity/ActivitySchedule.kt
96.77% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Incorrect count of supported Spark languages

At
https://learn.microsoft.com/en-us/azure/synapse-analytics/spark/apache-spark-development-using-notebooks#set-a-primary-language
text says "four Apache Spark languages," but then lists five.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e188fe7f-8cc8-2f0a-2ff5-c0eca25bcdce
Version Independent ID: a8ec994c-1eaa-6c98-6916-bcf4ef401757
Content: How to use Synapse notebooks - Azure Synapse Analytics
Content Source: articles/synapse-analytics/spark/apache-spark-development-using-notebooks.md
Service: synapse-analytics
Sub-service: spark
GitHub Login: @ruixinxu
Microsoft Alias: ruxu

@rodenkew
Thanks for your feedback! We will investigate and update as appropriate.

@rodenkew
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


can not install 0.42.1 on Ubuntu 18.04

Can not install 0.42.1 version onn Ubuntu 18.04. Bacause of that pipenv install librosa fails to install dependencies (it tries to install numba of exactly 0.42.1 version)

This is the same problem as #numba/llvmlite#459.  We posted a new wheel for 0.42.1 on macOS only, but pipenv assumes all platforms have the same latest version.  Can you force the usage of 0.42.0 until we can upload wheels for all platforms?

i have uploaded the linux wheels for 0.42.1.  Closing.


Replaced last location mode of 'compaction' with 'none'

Replaced last location mode of 'compaction' with 'none' which allows the last location to be unset when either a hosted tablet is unloaded or for an unhosted tablet when the TabletGroupWatcher processes its metadata.
Fixes #3596

Wondering it is would be better to  remove the tserver.last.location.mode property and always set the last location on assignment.  There would be less code to maintain and test (do not need to test the property or handle removing last when its set to none).   For the case where a balancer plugin is not interested in the last location information, it can ignore it.

Wondering it is would be better to remove the tserver.last.location.mode property and always set the last location on assignment. There would be less code to maintain and test (do not need to test the property or handle removing last when its set to none). For the case where a balancer plugin is not interested in the last location information, it can ignore it.

Can we emit information, such as last assignment, last hosted location for write, etc. that users can use to empower their own pluggable balancer? It seems like historically we made assumptions about how users might want to balance, and then we had to add this property to handle some additional use cases that users preferred, but it'd probably better to just to emit data that the users might want to use, and leave the balancing strategy up to them. That would maximally empower users and minimize the code we need to maintain (except for the code to emit the requested info, which should be simpler, and generally useful enough to warrant any complexity it might require).

@keith-turner said, "Wondering it is would be better to remove the tserver.last.location.mode property and always set the last location on assignment."

I think the none value supports the following use-cases:

Deployment to an orchestrated environment (e.g. Kubernetes). I'm not sure how meaningful, or repeatable, hostnames are in this environment. Using none here allows the tablet to be hosted on one of the TabletServers in the assigned resource group.
When an admin wants to unset the last location for a tables tablets allowing the configured balancer to make a new initial determination.

@ctubbsii said, "Can we emit information..."

When you say emit, I think metrics. Is that what you mean?

I think the none value supports the following use-cases:

@dlmarion for those use cases I was thinking another way to achieve them would be to configure the balancer to ignore the last location.

I think the none value supports the following use-cases:

@dlmarion for those use cases I was thinking another way to achieve them would be to configure the balancer to ignore the last location.

So, I understand your approach here, but I think I'll need you to elaborate on your idea from an implementation perspective. I assume that this is a new property that the user can set on a table, and that we need to modify all of the balancers to look for this property?

@dlmarion asked:

@ctubbsii said, "Can we emit information..."

When you say emit, I think metrics. Is that what you mean?

Metrics, logging, some pluggable interface to collect state, it doesn't really matter to me. I was mostly describing the general idea of shifting away from focusing on providing a specific end-to-end solution to providing the bits for users to create their own end-to-end solution. So, instead of us tracking the last write/compaction, or the last assignment, in our metadata and providing specific config knobs for that behavior, and then wiring that up for users as an option to a pre-provisioned balancer, we should maybe focus our implementations on providing insights (metrics is one way) to users, and pluggable interfaces for users to make their own choices about how to use those insights. This is just a better overall strategy, because it gives users more flexibility to support a variety of use cases we haven't thought of in advance, rather than constraining user imagination by locking them in on our specific thoughts. It also has the potential to dramatically reduce baked-in complexity and code size that we need to maintain.
How this idea comes into play here: don't bother changing the property options and behavior... just deprecate it and create an emitter (metrics, or whatever) that users can collect information from, that records things like details on assignment activity or details on compaction activity. Then, leave it to users to wire that information in to their own custom balancer, or wherever else they want to use it.

So, I understand your approach here, but I think I'll need you to elaborate on your idea from an implementation perspective. I assume that this is a new property that the user can set on a table, and that we need to modify all of the balancers to look for this property?

Yeah I was thinking this could be per balancer plugin configuration, not something that is baked into Accumulo.  A plugin implementation could have configuration that controls what it will do with the last location information. Or a plugin could have no configuration options for this.

@dlmarion asked:

@ctubbsii said, "Can we emit information..."

When you say emit, I think metrics. Is that what you mean?

Metrics, logging, some pluggable interface to collect state, it doesn't really matter to me. I was mostly describing the general idea of shifting away from focusing on providing a specific end-to-end solution to providing the bits for users to create their own end-to-end solution. So, instead of us tracking the last write/compaction, or the last assignment, in our metadata and providing specific config knobs for that behavior, and then wiring that up for users as an option to a pre-provisioned balancer, we should maybe focus our implementations on providing insights (metrics is one way) to users, and pluggable interfaces for users to make their own choices about how to use those insights. This is just a better overall strategy, because it gives users more flexibility to support a variety of use cases we haven't thought of in advance, rather than constraining user imagination by locking them in on our specific thoughts. It also has the potential to dramatically reduce baked-in complexity and code size that we need to maintain.
How this idea comes into play here: don't bother changing the property options and behavior... just deprecate it and create an emitter (metrics, or whatever) that users can collect information from, that records things like details on assignment activity or details on compaction activity. Then, leave it to users to wire that information in to their own custom balancer, or wherever else they want to use it.

The last known location is provided to the balancer SPI in AssignmentParameters.unassignedTablets. I think for now I'll just remove the property and the update last assignment in TabletMetadata.

Follow-on tasks that need to be created:

in main, deprecate TSERV_LAST_LOCATION_MODE
in elasticity, modify upgrader to error if 'tserver.last.location.mode' is set (maybe make it more general such that if any property is set that does not exist, then fail to upgrade)

Follow-on tasks that need to be created:

in main, deprecate TSERV_LAST_LOCATION_MODE
in elasticity, modify upgrader to error if 'tserver.last.location.mode' is set (maybe make it more general such that if any property is set that does not exist, then fail to upgrade)

Follow-on tasks created.


Support SP-Initiated workflow

Investigate and implement an SP-Initiated workflow.

@distortedsignal can you elaborate on this? Is SP-initiated SAML not supported right now? While trying to get SP-initiated SAML setup, I see the 302 Redirect occurring from the SP to the IdP, however, the Redirect does not have the SAMLRequest/AuthNRequest attached.
Is SP-initiated SAML in a half-working state at the moment?

@rbmcnicholas I think you've got it right. It "works"... kinda. If your IdP is being really nice, this feature works. However, if your IdP expects you to provide a payload, you will not be able to authenticate in an SP initiated fashion. I think this is doable, but my work (specifically, my 9-5) is currently on other projects. I've got this in the back of my brain, but I don't know when I'll get to it.

@distortedsignal Our IdP is not being very nice. It seems that the library is not generating SAMLRequest query parameter in the redirect request.
Do you know what is left and missing to make this functional? I can look to help with this.

I know this is very old, but I just started looking at this today, and I am blocked by this same issue. We can't do any sort of auth with our IdP for the same reason. Thanks.


[SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

What changes were proposed in this pull request?
To follow ANSI SQL, we should support a configurable mode that throws exceptions when casting to integers causes overflow.
The behavior is similar to https://issues.apache.org/jira/browse/SPARK-26218, which throws exceptions on arithmetical operation overflow.
To unify it, the configuration is renamed from "spark.sql.arithmeticOperations.failOnOverFlow" to "spark.sql.failOnIntegerOverFlow"
How was this patch tested?
Unit test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14220/
Test PASSed.

Test build #109151 has started for PR 25461 at commit ce1e1b5.

Test build #109151 has finished for PR 25461 at commit ce1e1b5.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109151/
Test FAILed.

retest this please.

retest this please

Jenkins is sleeping now? http://apache-spark-developers-list.1001551.n3.nabble.com/build-system-colo-maintenance-amp-outage-tomorrow-10am-2pm-PDT-td27666.html

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14225/
Test PASSed.

Test build #109156 has started for PR 25461 at commit a9e7477.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14249/
Test PASSed.

Test build #109178 has started for PR 25461 at commit 0e8e7fb.

Test build #109156 has finished for PR 25461 at commit a9e7477.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109156/
Test PASSed.

Test build #109178 has finished for PR 25461 at commit 0e8e7fb.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109178/
Test FAILed.

retest this please.

Also cc @cloud-fan @mgaido91

Test build #109193 has started for PR 25461 at commit 0e8e7fb.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14265/
Test PASSed.

Test build #109196 has started for PR 25461 at commit 0e8e7fb.

Test build #109193 has finished for PR 25461 at commit 0e8e7fb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109193/
Test PASSed.

Test build #109297 has started for PR 25461 at commit 721c4f2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14365/
Test PASSed.

Test build #109297 has finished for PR 25461 at commit 721c4f2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109297/
Test FAILed.

retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14367/
Test PASSed.

Test build #109300 has started for PR 25461 at commit 721c4f2.

Test build #109300 has finished for PR 25461 at commit 721c4f2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109300/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14553/
Test PASSed.

Test build #109495 has started for PR 25461 at commit cc39d0c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14554/
Test PASSed.

Test build #109496 has started for PR 25461 at commit 06700d8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14560/
Test PASSed.

Test build #109503 has started for PR 25461 at commit e9ecc51.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14561/
Test PASSed.

Test build #109504 has started for PR 25461 at commit 9b3fa4e.

Test build #109496 has finished for PR 25461 at commit 06700d8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #109495 has finished for PR 25461 at commit cc39d0c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109496/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109495/
Test PASSed.

Test build #109504 has finished for PR 25461 at commit 9b3fa4e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109504/
Test PASSed.

Test build #109503 has finished for PR 25461 at commit e9ecc51.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109503/
Test PASSed.

LGTM except a few minor comments

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14651/
Test PASSed.

Test build #109596 has started for PR 25461 at commit af48226.

Test build #109601 has started for PR 25461 at commit 977d509.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14656/
Test PASSed.

Test build #109596 has finished for PR 25461 at commit af48226.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109596/
Test PASSed.

Test build #109601 has finished for PR 25461 at commit 977d509.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109601/
Test PASSed.

Test build #109617 has started for PR 25461 at commit f1c64e1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14671/
Test PASSed.

Test build #109617 has finished for PR 25461 at commit f1c64e1.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109617/
Test FAILed.

Test build #109628 has started for PR 25461 at commit 3c49a9b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14679/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14685/
Test PASSed.

Test build #109635 has started for PR 25461 at commit 86d3e8d.

Merged build finished. Test PASSed.

Test build #109636 has started for PR 25461 at commit 9f4002c.

Test build #109628 has finished for PR 25461 at commit 3c49a9b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109628/
Test PASSed.

Test build #109635 has finished for PR 25461 at commit 86d3e8d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109635/
Test PASSed.

Test build #109636 has finished for PR 25461 at commit 9f4002c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109636/
Test PASSed.

thanks, merging to master!

@cloud-fan @maropu @mgaido91 Thanks for the review!


Use pkgdef files to control MIEngine logging

This checkin changes SetMIDebugLogging.cmd to use pkgdef files instead of directly writing to the registry. This should resolve issues that customers who have multiple _Config keys have been having. I believe this will also fix logging for Dev15, though I don't have a Dev15 machine with the Android tools installed at the moment to verify.

@rajkumar42 can you review?
cc @faxue-msft

:shipit:


Working on a similar project (Fern)

Hey @chriskapp  --
I'm working on a very similar project to you called Fern. We are also building an OpenAPI alternative that makes it easy to generate idiomatic SDKs for REST APIs and we are open-source too.
Given we think about similar things, up to connect some time? Here's a link to our discord and my calendar.

Hey @dsinghvi, thanks for reaching out, it looks indeed like we have similar goals and maybe there is some synergy to improve the overall API code generation ecosystem. I will join you if I find some time, currently are some busy times :)

Hey @dsinghvi, thanks for reaching out, it looks indeed like we have similar goals and maybe there is some synergy to improve the overall API code generation ecosystem. I will join you if I find some time, currently are some busy times :)

Sounds good!


build(lint): Linting doesn't work after last prettier upgrade

Describe the bug
npm run lint returns error after upgrade of prettier from 2.8.8 to 3.0.3. We must probably fix the eslint config or upgrade eslint/eslint-plugin-prettier  for compatibility.
As a side note, we could also run lint --fix on entire repo and commit the changes since a lot of a files are not formatted correctly and running the command locally adds a lot of changes (also deny commits that breaks the formatting from now on).
Logs/Stack traces
vagrant@CactusDevVM:~/cactus$ npm run lint

> lint
> eslint '*/*/src/**/*.{js,ts}' --quiet --fix && cspell "*/*/src/**/*.{js,ts}"

Oops! Something went wrong! :(

ESLint: 7.32.0

TypeError: prettier.resolveConfig.sync is not a function
Occurred while linting /home/vagrant/cactus/examples/cactus-check-connection-ethereum-validator/src/test/typescript/integration/check-config-files.test.ts:1
    at Program (/home/vagrant/cactus/node_modules/eslint-plugin-prettier/eslint-plugin-prettier.js:163:40)
    at /home/vagrant/cactus/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/home/vagrant/cactus/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/home/vagrant/cactus/node_modules/eslint/lib/linter/node-event-generator.js:293:26)
    at NodeEventGenerator.applySelectors (/home/vagrant/cactus/node_modules/eslint/lib/linter/node-event-generator.js:322:22)
    at NodeEventGenerator.enterNode (/home/vagrant/cactus/node_modules/eslint/lib/linter/node-event-generator.js:336:14)
    at CodePathAnalyzer.enterNode (/home/vagrant/cactus/node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:711:23)
    at /home/vagrant/cactus/node_modules/eslint/lib/linter/linter.js:960:32
    at Array.forEach (<anonymous>)

Oops! Something went wrong! :(

ESLint: 7.32.0

TypeError: Invalid host defined options
    at Object.<anonymous> (/home/vagrant/cactus/node_modules/prettier/index.cjs:600:23)
    at Module._compile (/home/vagrant/cactus/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1219:10)
    at Module.load (node:internal/modules/cjs/loader:1043:32)
    at Function.Module._load (node:internal/modules/cjs/loader:878:12)
    at Module.require (node:internal/modules/cjs/loader:1067:19)
    at require (/home/vagrant/cactus/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
    at Program (/home/vagrant/cactus/node_modules/eslint-plugin-prettier/eslint-plugin-prettier.js:157:26)
    at /home/vagrant/cactus/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)

@outSH Thank you for reporting!
Note to self: I found this on the internet as the likely fix:
There is an incompatibility between prettier 3 and eslint-plugin-prettier 4.

You can fix this by using version 5 of eslint-plugin-prettier:

yarn add -D<EMAIL_ADDRESS>
or

npm install --save-dev<EMAIL_ADDRESS>
    Official issue: https://github.com/prettier/eslint-plugin-prettier/issues/562
    v5 release notes: https://github.com/prettier/eslint-plugin-prettier/releases/tag/v5.0.0

Source: https://stackoverflow.com/a/76625797

As a side note, we could also run lint --fix on entire repo and commit the changes

@outSH I got it right here, but it needs review from the other maintainers (:
https://github.com/hyperledger/cacti/pull/2713


Invalid filename for BüroMail

Add a .zip in the link to the download file

tracking

solved in v1.1.18


Bug: actor not centered and orientation widget disappearing after switching from Quad View

As it can be seen on the attached gif, odd things happens after going from Quad View to single 3d view.

The view is zoomed in
The camera no longer focuses the actor center
The orientation widget is no longer visible

Also worth mentioning that in a previous version of glance (https://github.com/Kitware/glance/commit/a3163da5a6d5d435bfd89a0196194fa9e946932d), the orientation widget does not disappear but instead gets bigger (kind of permanently zoomed in).
Thanks in advance for your help!

#451 will address the orientation issue, but I can't seem to repro the zoomed-in view / camera center issue, even after following the steps above. Once #451 is merged, can you test this behavior again?

Yes, will do for sure. Thanks for the feedback

@floryst I'm observing the same behavior with the latest version. (and the widget still disappears)
I noticed that the camera center/zoom in issue fixes itself when resizing the browser window (opening/closing developer tools for instance)

Is it any dataset? is reproducible across different browsers?
I have a fix out for the orientation widget disappearing, but not the center-focus issue.

I'm using this dataset from girder: coronacases_org_002_crop.nii.gz
You're right, I do not observe the camera/center issue with google chrome (Version 105.0.5195.125 (Official Build) (64-bit))
Only with firefox (105.0.1)

@floryst some good news, I'm not observing this problem anymore on firefox 106.0.0 but I don't know why (did not find anything relevant in firefox release notes for 105.0.2 and 105.0.3)

Huh, well glad that's fixed. It's really weird that the issue was associated with a firefox version. I'll close this as resolved, unless it comes up again.


Chosen doesn't work with datatables scrollx or scrolly.

Vedmac, first of all thanks for your work! Great plugin!
I use yadcf 0.8.9.
Chosen select list doesn't work properly when used with Datatables scrollx or scrolly options enabled.
Here is an example:
https://jsfiddle.net/p9qo1kj9/17/
Is there a quick fix or would it actually require to modify yadcf?

Hi,
You are welcome, unfortunately because of the way that chosen is being rendered its impossible (unless you will find a way) to use it with scrollX option, but you can use the select2 plugin instead (which is compatible with scrollX)


Can not get the latest version of package in npm registry

Describe the bug
Can not get the latest version of package in npm registry.
I find that the package is update in one hour.
Expected behavior
get the latest version of package and npm install success.
Environment information
node:v8.12.0
npm :6.4.1

Hi @RichieChoo,
Please clarify what you mean and let us know how we can reproduce this.

I have tried to install dependencies for a project . There are some packages in my verdaccio and some packages in npm registry ，and install throw an error that a npm packages 500 error . I find the package in npm registry , and it was updated for a new version in a hour . After a while , I install success

This seems like a caching issue.

Agree with @DanielRuf , closing this.  Thanks @RichieChoo feel free to keep posting, but this is not a bug in our side.


Windows Defender - Turn off Periodic Scanning once enabled

It's all good and well turning on periodic scanning in windows defender, but how on earth are you meant to turn it off again?
EDIT Link to *.DOC
https://docs.microsoft.com/en-us/windows/security/threat-protection/windows-defender-antivirus/limited-periodic-scanning-windows-defender-antivirus

Did you come here from a specific page where you expected to find that information?
If yes, could you link the page, in case it needs clarification for general improvement of the docs.microsoft.com pages?

@kadafi-Hub .periodic scanning can be turned off via group policy editor

@officedocsbot assign @mypil

@officedocsbot assign @mypil

@illfated  https://docs.microsoft.com/en-us/windows/security/threat-protection/windows-defender-antivirus/limited-periodic-scanning-windows-defender-antivirus
Apologies, I found it here, I assumed when I clicked to view the article on GitHub it would have linked back to it.

@Kadafi-Hub .periodic scanning can be turned off via group policy editor

Can you be more specific? I'd already checked all the group policies under "Windows Defender Antivirus" > Scan  and there is nothing that seems relevant.

Did you come here from a specific page where you expected to find that information?
If yes, could you link the page, in case it needs clarification for general improvement of the docs.microsoft.com pages?

https://docs.microsoft.com/en-us/windows/security/threat-protection/windows-defender-antivirus/limited-periodic-scanning-windows-defender-antivirus
Apologies, I found it here, I assumed when I clicked to view the article on GitHub it would have linked back to it.

@Kadafi-Hub. i found  that settings in Microsoft defender antivirus in gpo
see below screenshots

@Kadafi-Hub. i found that settings in Microsoft defender antivirus in gpo
see below screenshots

Is turning off Windows Defender Anti Virus the same as "turning off periodic scanning"?

@Kadafi-Hub : I don't think the suggested answers from @RAJU2529 are usable for your question, because those examples look like turning off the entire service or feature to me, not specifically the scheduled scans. Guys, grab a bigger shovel, we need to dig deep to find the answer here.

For additional information:
Build 1809
17763.720
I don't think the ability to do as via the GUI. When you turn the slider to ON, then the option to turn the slider disappears.....

Follow-up: I think maybe we could try digging into the PowerShell cmdlets, but I was also trying to figure out how you enabled the periodic scans in the first place.
Have a look at https://docs.microsoft.com/en-us/windows-hardware/customize/desktop/unattend/security-malware-windows-defender-scan (Scan). It lists

ScanParameters
ScheduleDay
ScheduleTime

There is also the XML at the bottom of the page, which could in theory be used to reset the current schedule by using zero-size values ( 0 ).

OK so, @RAJU2529 suggestion checks out...
When you TURN OFF Windows Defender Antivirus via group policy... the Slider to turn it ON again re-appears..... Definitely think Microsoft need to stop making the slider disappear when you turn the slider ON.

Nice find. I did not expect that. Feels almost like an Easter egg in terms of logic thinking. I also agree with your statement, it is far from obvious or given that the GUI option should become hidden when enabled.

only antivirus product must be used in windows machine. By default Microsoft defender antivirus is turned on automatically. But when we installed second party antivirus which includes anti-malware features , then Microsoft defender is turned off automatically. If defender does not turned off meàns, we can stop the entire action by modifying registry key or  disabling by configuring in GPO.

Yea I already understand that installing a 3rd party AV disables the native OS windows defender. My annoyance is the fact the when you enable periodic scanning, the "ON/OFF" slidet dissapears. Then to re enable you have to modify the gpo to enable "turn windows defender antivirus off". The on and off slider needs to remain on the gui

From my experience with issue tickets here on this page, it is normally recommended that you post that request on Microsoft Feedback Hub to submit your views to the developers (that is what I would have done in this case, if I had been in your situation -- where an obvious software behavioral issue should be discussed with the developers by someone with the personal experience of that software event).

@Kadafi-Hub - Thank you for engaging with the community here for the docs.
I know the product teams are always looking for user feedback on how to make Windows 10 better. They keep a close tab on user feedback and it would be awesome if you could add your voice via Feedback Hub
You might find others have made a similar request that you can add to, or you can open a new one. Let us know here if you do so we can up-vote your request.
Thank you for your contribution to make the docs better! Much appreciated!

Yea I already understand that installing a 3rd party AV disables the native OS windows defender. My annoyance is the fact the when you enable periodic scanning, the "ON/OFF" slider dissapears. Then to turn off periodic scanning you have to modify the gpo to enable "turn windows defender antivirus off". The on and off slider needs to remain on the gui

I'm on 21H1 and you can turn this off when the "Virus & threat protection" refreshes it adds 4 new sections "Current threats", "Virus & threat protection settings" and "Virus & threat protection updates", and "Ransomware protection" below all of those there is a "Microsoft Defender Antivirus options" collapsible section you can expand and turn the setting back off.  It prompts a UAC then refreshes the settings and it is now off.


Where do you take power from?

Hi,
Doing a similar thing on my dl380e gen8, but without Arduino and PWM. Just bought silent fans. They work fine if I take power from PCI socket and shortcut pins 4-6 on the fan socket. But I didn't manage to power the fans from the fan socket itself (pin 1 and 4/5/6 short).
Any suggestions?

Hey, I'm about to do this with my dl380e gen8 as well! I'm interested in your results if any!


Governance improvements

Reversal of ownership
Fee sharing for deployments

Don't allow deployment of new contracts with same name as already existing one.

Verify that current upgraded score is correct one by name.


Update to 2019.3.0a4 breaks SteamVR

I have tried to update to Unity 2019.3.0a4 and it broke all the project, mainly because it says that the "GUI Layer" or something similar has been removed, and all the "UnityEngine.UI" libs have changed.
This has produced a good amount of errors, some of them in the SteamVR plugin.
Is this just me? Or this will need to re-adapt some libs?

I have the same problem. How did you solve it?

Haven't solved it, i had no time to get stuck with it, so I just went back to the previous version, for now.

It has been observed that as of 2019.2.0b1, UnityEngine.UI is no longer included as a DLL and rather as source in BuiltInPackages, which may be related.
To fix it look for the file SteamVR.Asmdef , open it with a text editor and in references add add:
"references": [
"SteamVR_Windows_EditorHelper",
"Unity.ugui"

Thanks @AristokratOne. I included this version of the asm in the version of the plugin that just shipped to the asset store.

Is it really solved?
Just downloaded the fixed version from the asset store and I installed Unity 2019.3.0a5, but I still get multiple errors (not as many as before though), mainly saying:
The namespace UnityEngine.UI cant be found, which if I delete then its solved, but...
The namespace Text, and other related components are not been found.
Also, Image, BasiInputModule, EventSystem...
Or am I missing something?

Forget my project, if you open a totally new project and the first thing you do is import the SteamVR asset from the store in 2019.3xxxx the same errors appear (16 errors).

You’ll need to delete the SteamVR.asmdef and rename SteamVR.asmdef.20192 to
SteamVR.asmdef. Unity 2019.1 has problems importing the asmdef if it has
the new ui line in it since it doesn’t exist for that version.
On Fri, Jun 14, 2019 at 6:39 AM Gabriel Kapellmann<EMAIL_ADDRESS>wrote:

Forget my project, if you open a totally new project and the first thing
you do is import the SteamVR asset from the store in 2019.3xxxx the same
errors appear (16 errors).
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/ValveSoftware/steamvr_unity_plugin/issues/444?email_source=notifications&email_token=AABQQMBNPGANEZ6TK2JEYH3P2ONQVA5CNFSM4HRZRZR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXW2FCQ#issuecomment-502112906,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABQQMDHMXER7OOCU7MNRMDP2ONQVANCNFSM4HRZRZRQ
.

I see!
Yes, that solved the problem of the simple project, but with the one I've been working, it got a set of new errors, I've never seen them:
UnassignedReferenceException: The variable trackingOriginTransform of Player has not been assigned.
You probably need to assign the trackingOriginTransform variable of the Player script in the inspector.
UnityEngine.Transform.get_position () <0x13138112270 + 0x0006a> in <39b3f9801916460c91c1f5e3a3e521e5>:0
Valve.VR.InteractionSystem.Player.get_feetPositionGuess () (at Assets/SteamVR/InteractionSystem/Core/Scripts/Player.cs:222)
Valve.VR.InteractionSystem.Player.OnDrawGizmos () (at Assets/SteamVR/InteractionSystem/Core/Scripts/Player.cs:313)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)
When the project is opened, it starts with 55 errors, all the same like this, and as time passes by I get a new one every time the mouse travels through the editor or the editor gains focus.
Is it something in my configuration?


vazir-fonts: init at 19.2.0

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@Mic92

@LinArcX
Do you have any intention to also package other rastikerdar's fonts?
Can you also package vazir-code?

@DearRude hello.
I don't use nix/nixos anymore. But adding new package isn't so hard. You just need to follow documentation and look at this package as a starting point.


Self-closed Tags?

HOLY CHRIST, this an awesome plugin! really appreciate your work , but there is something bothering me
Could you implement an update where tags like img, meta, input,etc close themselves automatically? If not, is there a config file where i can edit the metadata to achieve this behavior?

Hey @feijoes-magicos! Vscode has the same behavior when it comes to those elements because they cannot contain child elements.. and the / is optional it seems (although from what I see in my setup, prettier always adds the / at the end). Also here in the spec https://www.w3.org/TR/2011/WD-html-markup-20110405/syntax.html#syntax-elements it says that they're optional.
If you still want to enforce this behavior it seems to be possible https://stackoverflow.com/a/53502854.
Let me know if that works for you!


Tracking Beta 2 Changes

https://github.com/twbs/bootstrap/issues/23278

[ ] Renamed .table-inverse, .thead-inverse, and .thead-default to .*-dark and .*-light, matching the color schemes used elsewhere in.
[ ] Responsive tables now generate classes for each grid breakpoint, meaning we've added .table-responsive-{sm,md,lg,xl} to the already present .table-responsive. You might need to adjust your usage depending on when you want a table to resize.
[ ] Docs: remove message about form validation (Bootstrap: Fix broken valid/invalid sibling selector for form validation mixin.)

Bootstrap v4 Beta 2 has shipped

https://blog.getbootstrap.com/2017/10/19/bootstrap-4-beta-2/
Yah I second this.

I've also noticed the grid is in need of some updating.
Needs:

Remove Col push and pull
Add Col order-

Other nice to haves on grid:

Add Col align-self-
Add Row justify-content-
Add Row align-items-
Add Row align-content-

From http://getbootstrap.com/docs/4.0/migration/#beta-2-changes:

Removed the unused .form-control-label class. If you did make use of this class, it was duplicate of the .col-form-label class that vertically centered a <label> with it’s associated input in horizontal form layouts.

https://github.com/reactstrap/reactstrap/blob/master/src/Label.js#L104 needs to be updated

Support for form-row would be nice.


cooltools compute-saddle matplotlib bar API update

https://github.com/mirnylab/cooltools/issues/47
https://github.com/dekkerlab/Dekker-Lab-IT/issues/94

Thank you @betulakgol
this seems like a "no-brainer", so I'm taking a liberty to accept it
travis failed because of some networking issues - nothing to do with the PR

thank you!


Remove HTTP/2 Push Promise support since Plug is deprecating it

See https://github.com/elixir-plug/plug/commit/cd258e7acddf8e2cbed62a13c776d63cc17905d8
@moogle19 you've had a lot of eyes here lately; care to give this a once over?

Can't we get rid of the PushPromise frame altogether and just handle it as an Unknown frame?
Alternatively if you want to keep the frame, it can be an empty struct since the fields aren't used anyway (as far as I can see). If we want to ignore invalid PushPromise frames (zero stream_id and invalid padding length) the deserialization can also be skipped and Frame.deserialize/2 can return the empty PushPromise struct directly.
WDYT?

Can't we get rid of the PushPromise frame altogether and just handle it as an Unknown frame?

Sadly we cannot, since a number of tests in h2spec require us to handle push frames in a specific way (even if we don't support them). We can drop the deserialization down to a single error clause though, since all of the failure cases in the spec resolve down to the same error (protocol error, close connection).
We will need to keep the deserialize function around, but no longer need to have a struct definition for PushPromise.

Edit: And the Stream.stream_id_is_valid_server/1 is reported as unused by the compiler.

✅ thanks!

Updated


Checking if text contains emojies

In our project php-emoji is used to process possible emojis in chat messages. Whilst most of the messages do not contain emojis and we just waste server time.
I've added the method which will allow us to check if text contains emojis, and skip emojis processing if it doesn't.

merged, with a rename to emoji_contains_emoji() - thanks!

This method can't be used to check if text contains emojis, it can only be used to check if it doesn't contain them.
So, better name would be emoji_is_no_emojis_in_text or something like that.


Bb update indexes 155608493

Description
This adapts our previous indexes to reflect the changes in data use that have come to be since our first drafts.
Reviewer Notes
I would like scrutiny on my reasoning and how I applied it to these proposed new indexes, most especially around shipments. Details below:
Blackout dates: removed COS, as it isn't being used in queries and won't be anytime soon. Based order of five included fields on their use in the FetchTSPBlackoutDates query function. (Note to self: see how the lack of dropping the previous index works in CI; it isn't present on my machine, despite the previous up fizz.) There is no drop_index line in the fizz up for this one because the index was not present in my local db. Is that also the case in yours? Did this cause problems?
TSPs: removed SCACs as they are not being queried or otherwise accessed. Did a single-column index on name as that is used frequently.
Shipments: the most common shipment query uses all nine fields, so I included them in that order. However, using all the fields seems like bad indexing form; I would like some ideas on how to deal with this. Also, I don't think the created_at and updated_at fields are actually used anywhere in our code, so do they need to be queried to create a ShipmentWithOffer, or can those be dropped and thus the index can be refined?
TDLs: only the IDs are being used right now, so I made the index only on that.
Verification Steps

[ ] All tests pass.
[ ] Code follows the guidelines for Logging

References

Pivotal story for this change

I am also curious why we don't need to drop the other index on blackout_dates. I don't see a migration where it was dropped after being added. This is a little worrying, as it means that we can't trust our migrations.


Question: Correctly managing deleted images in an edit setting

I guess I'm just having a hard time wrapping my mind around this process. If anyone has had to work around this successfully, I'm all ears. Here's the scenario:
We are using the insert plugin for inline images in a blog post type of page.  When creating, the script works great and images are being uploaded and stored on the server.  This works great as the content in the creation page has no reference on the database yet. We're not syncing automatically, changes are only by a submission action.
However, when editing a user can modify the text or images and then abort (which is fairly expected).  But deleting an image with this plugin is made to immediately remove the file from the server, resulting in missing images if the edit is aborted.
But we also don't want to avoid managed-deletion of images.  Editing posts could lead to a lot of abandoned image overhead.
Any suggestions for managing input that has both async (images) and deferred (text) content?
Asking for a friend 😁

Hi, we do not do this for now but the process I think would do it is the following.

Never delete you images using the deleteScript
On server side

At upload time always create a sub-directectory for each new uploaded file to prevent conflicts with files uploaded with the same names, for example 1/file-1.png, 2/file-1.png, 3/file-1.png.
When the content of your text is saved (or the edits are aborted) make a diff between the image URLs present in the HTML content of the editor and the content of the file system, delete files which do not correspond to any URL in the HTML content.

The last problem could be that the user exists its browser in such a way you cannot consider its an "aborted event". In this case you can use a "last opened date" and "last update date" and create a CRON script which cleans images which are not "in sync" with the content if the "last opened date" and "last update date" it older in comparison with the current server date.
Hope this helps.

@bgaillard thanks! I ended up with a kind of similar solution:

no deleting with the deleteScript
image filenames get a timestamp in the string to prevent overwriting duplicates
images are always created in a temp directory that gets cleaned out with a nightly cron job. When a post is saved, related images are moved to a permanent location to avoid cleanup.

Seems to be working well so far. The temp images folder never grows to large over the course of a day. Thanks so much for getting back to me (I mean...er...my friend) 😅


Crashes on macOS High Sierra

Screen freezes, then glitches out. Reboots the computer.
I believe this has something to do with the fact that High Sierra is using Metal2.

yes
tremendous crash haha
just after the latest commit
worked perfectly fine before

@monouser7dig also on mac?

yes macOS 10.13 (17A405)

The commit has been reverted on master; going to leave this open as tracking issue.

maybe test the lib updates alone

Would one of you mind trying this PR? https://github.com/jwilm/alacritty/pull/811
It's strictly a lib update for latest winit/glutin (among other things).

Thanks!

@jwilm I just noticed #811 breaks shift+tab for some reason, so we should hold off on merging it. Also let's get @vberger in the loop here.

Shift+tab is also broken in #815. Seems like an upstream bug @vberger.

Well, I think the macos crash is linked to way I changed resize code, sorry for that. 😕 (the other part of my PR only touched linux specific code).
Though it's quite surprising to it seems to crash the entire graphic driver?

@chetgurevitch

Scratch that, still happens w/ winit 0.8.1. Reproducable across xorg and wayland using gnome 3.26. Investigating tomaka/winit#274.

The "breaking shift-tab" occurs with wayland using Xwayland, or with native wayland? Because this PR only touches X11 code...

@vberger That issue was introduced by the winit update itself. https://github.com/tomaka/winit/pull/308 will fix it so it's all good.

Well, I'm still puzzled at the fact that all this only touches X11-specific code. So I guess my question is: "Is shift-tab broken with the native wayland winit backend, or only with X11?".

@vberger Sorry I understand what you're saying now, seems like that issue was always present on wayland. I just submitted https://github.com/tomaka/winit/pull/314 to address it there too.

@jwilm I built it again, and it works perfectly now. I believe it's okay to close the issue now. Any others still having this issue?

@avjinder The offending change was reverted in master but we'll want to merge those changes or something similar sooner or later, so probably best to leave this open for now.

Yes. Actually the changes of my PRs should probably be handled by winit/glutin. I was just trying to provide a quick fix to ease the wayland story here until the issue was solved winit/glutin-side.
I guess it was not much of a fix actually 😅

Is this still relevant? It has been a while.


Lighthouse performance test

Hi @MarcinKilarski another tool, that you can use to test performance is lighthouse.
https://developers.google.com/web/tools/lighthouse/

Hi Fellyph, thanks for a wonderful suggestion. I am using it every time. I am slowly adding information about all the tools and how to use them.
Feel free to add information about this tool in the relevant sections, I will be happy to add your commit to the master branch.


Record and Playback - Add proper docs for console.logs karma config

Currently, the Guidelines doc present in the storage folder explains how the console.logs are being updated.
We need to add documentation regarding the karma plugin json filter, and the code to be added in the karma.conf.

#4281


Set up test-resources and rust test for swift cleanup rules tests.

I wonder why Fix End of Files hook did not throw a fit. :|

Maybe, because it was a swift file

Aaah ! I see . Its under test-resource. We only apply the new line linter on files under src.


All-In-One Package for PL Syntax Highlighting & Code Completeion

VSCode Version: 1.7.1
OS : Linux

A Suggestion:
Why not develop an all-in-1 Syntax Highlighter & code completion package for all languages?
Will make stuffs easy & faster.

We have decided for a model that embraces extensions


Instance operator: refactor the exposition environment

Description
This PR continues the instance-operator refactoring, focusing on the creation/deletion of the objects (i.e. services and ingresses) used to expose user environments. Additionally, it removes the remaining usages of the deprecated SetInstanceStatus function, and increases the overall code coverage.
Ref #512
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[x] Unit testing
[x] Staging environment

/deploy-staging

/deploy-staging

/deploy-staging

/rebase

/merge


Persistent sorting

When browsing the panel, the index field forgets the user's sorting settings.
I'd expect this setting to be persistent, e. g. by storing the needed information in localStorage.

Agreed, haven't gotten around to this one. Still on the todo


NETOBSERV-1107: Add GoMemLimit env setting to prevent ebpf agent OOM conditions

https://weaviate.io/blog/gomemlimit-a-game-changer-for-high-memory-applications

/ok-to-test

/ok-to-test

btw we may do that on FLP as well

btw we may do that on FLP as well

FLP has memory issues too ?

/lgtm
thanks!

/approve


Fix ini_set parameter type

init_set expects second parameter to be string.
This is a sample PR, John-Betong, addressing #2234, #2235 and #2236.
One PR, as these are related.
Note: the branch name is misleading, as I thought all your suggestions were for strict typing.

Note the GPG-signed commit, and we have to wait for travis-ci to complete regression testing, to make sure we didn't break anything.

Fixes #2234, #2235 and #2236.
Those could have been submitted directly as a PR instead of an issue.


Fixes scheduler instantiation

Adding a scheduler in the current code throws the following error
 File "/home/suraj/anaconda3/envs/lightningssl/lib/python3.8/site-packages/pytorch_lightning/core/optimizer.py", line 362, in _set_scheduler_opt_idx
    if config.scheduler.optimizer is opt:
AttributeError: 'list' object has no attribute 'optimizer'

lightning expects the scheduler to be a dict with attribute optimizer and not a list.
However, we also need support for multiple optimizers and schedulers. This fix allows for that.
Note that the number of optimizers and schedulers must be the same.

Cool, whenever you're ready could you please revert the code that isn't related to this issue, as both logging as well as handling of input/pred are tackled in the other two PRs


OSX Weekly Build Broken

When opening any dataset using the current OSX weekly build it will crash.

I can't reproduce this on my work machine.  Could be a dataset specific problem.  @stasj what dataset did you load?
Installer version used: <IP_ADDRESS>c3322

I just tested the most recent installer (built on 6/26) and it is working now. The one that was broken for me was the previous installer.


Remove the manifest hack

Fixes https://github.com/CanHub/Android-Image-Cropper/issues/395
I actually could not make any sense of why the original hack was in place at all.

Thanks to doing this, will need to test later when I got the time.
Which Devices and Android OSs did you tested so I can increase the range? @PaulWoitaschek

What do you mean by that? This PR only removes a workaround that - when I understand correctly - caused the build stage to fail.

What do you mean by that? This PR only removes a workaround that - when I understand correctly - caused the build stage to fail.

But did you test the sample app on Android 11 and 12 on some devices? Is always good to check if this is working before we ship.

Why was this hack added in the first place? I never understood it myself

This was done when updating Update gradle 7.0 and Java 11 and  Update Android 12 (SDK 31)
On Android 12 we need the android:exported value for Activities and some libraries won't have it, causing issues when we compile the code and merge the Manifests

androidx.test.core.app.InstrumentationActivityInvoker$BootstrapActivity
androidx.test.core.app.InstrumentationActivityInvoker$EmptyActivity
androidx.test.core.app.InstrumentationActivityInvoker$EmptyFloatingActivity

OKay but then isn't the solution now to update to the newest version of androidx.test.core. Also it seems like only instrumentation tests are affected

But these are test only dependencies 🤔

Also it seems like only instrumentation tests are affected

Am I blind? (On mobile currently).  I don't see any?

That was referring to the message above, our messages arrived at the same second.

Thsi merge i think is causing me a problem. I cant build my project at all
> Task :app:processDebugMainManifest FAILED
C:\Users\ASTI\Desktop\sprint_ten\secondary\kooha_android\app\src\main\AndroidManifest.xml:49:13-49 Error:
	Attribute activity#androidx.test.core.app.InstrumentationActivityInvoker$EmptyActivity@theme value=(@android:style/Theme) from [com.github.CanHub:Android-Image-Cropper:4.2.0] AndroidManifest.xml:49:13-49
	is also present at [androidx.test:core:1.0.0] AndroidManifest.xml:29:13-84 value=(@style/InstrumentationActivityInvokerEmptyActivityTheme).
	Suggestion: add 'tools:replace="android:theme"' to <activity> element at AndroidManifest.xml:46:9-53:20 to override.
C:\Users\ASTI\Desktop\sprint_ten\secondary\kooha_android\app\src\main\AndroidManifest.xml:57:13-56 Error:
	Attribute activity#androidx.test.core.app.InstrumentationActivityInvoker$EmptyFloatingActivity@theme value=(@android:style/Theme.Dialog) from [com.github.CanHub:Android-Image-Cropper:4.2.0] AndroidManifest.xml:57:13-56
	is also present at [androidx.test:core:1.0.0] AndroidManifest.xml:36:13-87 value=(@style/InstrumentationActivityInvokerFloatingActivityTheme).
	Suggestion: add 'tools:replace="android:theme"' to <activity> element at AndroidManifest.xml:54:9-61:20 to override.

I think it's the other way around. That commit was released as 4.3.1 and you are using older versions (4.2 and 4.3)

@PaulWoitaschek Thanks!!
after upgrading 'com.github.CanHub:Android-Image-Cropper:4.3.2' , still I can't build app and build execution failed with these errors:
/app/src/main/AndroidManifest.xml:27:9-33:20 Error:
android:exported needs to be explicitly specified for element <activity#androidx.test.core.app.InstrumentationActivityInvoker$EmptyActivity>. Apps targeting Android 12 and higher are required to specify an explicit value for android:exported when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.
/app/src/main/AndroidManifest.xml:34:9-40:20 Error:
android:exported needs to be explicitly specified for element <activity#androidx.test.core.app.InstrumentationActivityInvoker$EmptyFloatingActivity>. Apps targeting Android 12 and higher are required to specify an explicit value for android:exported when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.

Now that doesn't seem image cropper related. Looks like you should update your android test dependency

thanks @PaulWoitaschek
issue was in manifest file of justifier-core-1.0.0


Added Unitrópico from Yopal, Casanare

Unitropico is added as an available institutional domain.

@guillermoplus Pull request merged. Thank you!


angular undefined

After installing cli-angular and checking that it is installed on the command prompt, I see the following two things:
1- Angular: undefined
...
2- Ivy Workspace:
--------------------------------------------------------
Angular CLI: 9.1.5
Node: 10.15.1
OS: x64
Angular: undefined
...
Ivy Workspace:
Package Version

@ angular-devkit / architect 0.901.5 (cli-only)
@ angular-devkit / core 9.1.5 (cli-only)
@ angular-devkit / schematics 9.1.5 (cli-only)
@ schematics / angular 9.1.5 (cli-only)
@ schematics / update 0.901.5 (cli-only)
Why is Angular not defined and Ivy wrong?

This is the expected output when you run ng version outside an Angular project folder.
You need to be in a folder that contains the angular.json and package.json files to get information about the versions of Angular framework installed in that project.


Current state / statechange

Is there a way to retrieve the current route state? History.state appears null...
Similarly, is there an event handler for route changes? Something triggers when the state changes, like routestatechange or something?

Is there a way to retrieve the current route state? History.state appears null...

You may use router._cLoc(). I have to provide for an API for this but for the time being you may use this internal function to retrieve the current URL.

Similarly, is there an event handler for route changes? Something triggers when the state changes, like routestatechange or something?

That's actually the main funcationality of Navigo. It calls a handle once the route is changed. The second argument of on method is the handler that you are searching for. Or maybe you are searching for a general one that is triggered separately. If yes, there is no such API right now.

Thanks. Yes I was curious if there was a general one triggered separately anytime navigo matches a route (different than creating a default/wildcard route). Something similar to hashchange would be nice. For now, I suppose I can get around this by calling the same function in every defined route. My use case is I'm trying to bind the route state to a DOM element (menu links).

I see. Anyways, it's a nice idea. I'll add it to the TODO list.


Significantly reduce heartbeat overhead

The heartbeat built into aiohttp tries very hard to deliver exact timeouts by canceling the timer handler every time a message is received.  When the volume of messages is high (bluetooth), this has a significant overhead.  Since we do not need that level of resolution with the heartbeat we can use a significantly more performant heartbeat algorithm.
Before this change resetting the heartbeat is ~38% the execution time to receive a websocket message.
Before:

After:
The cancelation of the non-existent heart beat still takes ~4% of the run time but still much better

I think this is good to go, but I need to spend a few more hours doing testing with it

Test Plan:

[ ] Plan 1
With bluetooth scanner enabled
Unpower device, verify it sees it as unavailable
Power device, verify it becomes available
Unpower device, verify it sees it as unavailable
Power device, verify it becomes available

[ ] Plan 2
With bluetooth scanner enabled
Unpower device, do not wait for it to be seen as unavaialble
Power device, verify it still works
Unpower device, do not wait for it to be seen as unavaialble
Power device, verify it still works

[ ] Plan 3
With bluetooth scanner disabled
Unpower device, verify it sees it as unavailable
Power device, verify it becomes available
Unpower device, verify it sees it as unavailable
Power device, verify it becomes available

[ ] Plan 4
With bluetooth scanner disabled
Unpower device, do not wait for it to be seen as unavaialble
Power device, verify it still works
Unpower device, do not wait for it to be seen as unavaialble
Power device, verify it still works

Found an unexpected issue unrelated to this PR.  We never get UpdateType.INITIALIZED when the device reconnects so we never restart the ble scanner.  I'll fix that in another PR

We could also trigger a refresh when we see the device via zeroconf to speed up reconnects if its offline for a while

So there is a race when we reconnect.
If its offline for longer than one cycle INITIALIZED never gets fired and we never reconnect the scanner

That problem is existing and not related to this PR.  Digging into that though now

2022-12-12 10:40:28.786 WARNING (MainThread) [aioshelly.rpc_device.device] <IP_ADDRESS>: Finished init, _update_listener=None initialized=True
2022-12-12 10:40:28.786 INFO (MainThread) [homeassistant.components.shelly] Fetching shellyplugus-c049ef8c1f84 data recovered

So the _update_listener is None when it recovers

@bdraco I was going to ask you about the UpdateType.INITIALIZED as we don't have coverage for this in Home Assistant Shelly

So when we get a connect error we call shutdown which sets the _update_listener to None
        except (*CONNECT_ERRORS, RpcCallError) as err:
            self._last_error = DeviceConnectionError(err)
            _LOGGER.debug("host %s: error: %r", ip, self._last_error)
            if not async_init:
                await self.shutdown()
                raise DeviceConnectionError(err) from err

So even worse the device just stops getting updates after it hits a connection error

I'm going to start another PR to fix that.

Retest looks good with the other fix


[zstd] export zstd-config.cmake

export zstd-config.cmake:
find_package(zstd CONFIG REQUIRED)
target_link_libraries(main PRIVATE libzstd)

/azp run

Thanks for the PR!


Implement endpoint for invalidating all sessions for a given identity

DO NOT MERGE IT!

You tagged me as a reviewer but this is not against the upstream, was it on accident?

You tagged me as a reviewer but this is not against the upstream, was it on accident?

Sorry! My mistake. It is still in our CR/QA. I will make proper PR after we are dene.


Ability to use Storefront without Catalog Service

Description:
Hello team,
We are currently exploring the use of the Storefront in our project. However, our current implementation does not support the following query:
query ProductQuery($sku: String!) {
  products(skus: [$sku]) {
    __typename
    id
    externalId
    sku
    name
    description
    shortDescription
    url
    urlKey
    inStock
    metaTitle
    metaKeyword
    metaDescription
    addToCartAllowed
    images(roles: []) {
      url
      label
      roles
    }
    attributes(roles: []) {
      name
      label
      value
      roles
    }
    ... on SimpleProductView {
      price {
        ...priceFields
      }
    }
    ... on ComplexProductView {
      options {
        id
        title
        required
        values {
          id
          title
          inStock
          __typename
          ...on ProductViewOptionValueSwatch {
            type
            value
          }
          ... on ProductViewOptionValueProduct {
            title
            quantity
            isDefault
            product {
              sku
              shortDescription
              metaDescription
              metaKeyword
              metaTitle
              name
              price {
                final {
                  amount {
                    value
                    currency
                  }
                }
                regular {
                  amount {
                    value
                    currency
                  }
                }
                roles
              }
            }
          }
        }
      }
      priceRange {
        maximum {
          ...priceFields
        }
        minimum {
          ...priceFields
        }
      }
    }
  }
}

fragment priceFields on ProductViewPrice {
  roles
  regular {
    amount {
      currency
      value
    }
  }
  final {
    amount {
      currency
      value
    }
  }
}

Our project does not rely on the Catalog Service and hence cannot execute this query as it currently stands.
Question:
Is there a way to configure or use the Storefront independently of the Catalog Service? If not, are there any recommended workarounds or upcoming changes to support such a use case?
Any insights or guidance would be greatly appreciated.
Thanks in advance!

Thanks @herzog31


Separate BSI and ISO controls

Describe the bug
This page currently mixes BSI and ISO controls, due to a limitation in mkdocs material's tag plugin.
However, CISO's are rarely interested in both. Furthermore, we might add a bunch of more controls, in which case the controls page gets really cluttered.
Let's improve the page, so that controls are nicely separated by regulation or information security standard.
Acceptance criteria

There are two CISO control pages, one for ISO controls and one for BSI controls.
The two pages are auto-generated by looking at the tags in Markdown frontmatters.
The two pages feature links to the relevant page.
Tags feature backlinks to the page with the right control.
The solution is generic enough to make room for new regulations.

Seems like this is already supported if you just set it correctly like here:
https://squidfunk.github.io/mkdocs-material/setup/setting-up-tags/#+tags.tags_extra_files

Sorry for not providing more context. The tags.tags_extra_files feature is not quite what we want for two reasons:

It is a sponsorware feature. While I'm open to paying for value, it feels like the feature is still "in the oven".
We have tons of tags for each regulation. Ideally we would want to match by prefixes and not list all tags in mkdocs.yaml.


Downloaded asset via remote_file on 12.0.1 does not match checksum that has been verified manually via curl + md5sum, plus verified working on 11.12.2

Issue:
Asset that's downloaded via remote_file on 12.0.1 doesn't seem to be downloading correctly. Checksum differs wildly to what is confirmed via manual curl as well as at least version 11.12.2.
Test environment:

nginx cookbook version 2.7.4 using nginx::source
test-kitchen 1.2.1
CentOS 6.5 image on Vagrant pulled from Opscode repo

Reproduction steps:
Create a minimal kitchen environment:
.kitchen.yml:
---
driver:
  name: vagrant

driver_config:
  require_chef_omnibus: 12.0.1 # replace with '11.12.2' to test against a known good version
  use_vagrant_berkshelf_plugin: true
  customize:
    memory: 1536
    cpus: 2

provisioner:
  name: chef_zero

platforms:
  - name: centos-6.5

suites:
  - name: default
    run_list: recipe[nginx::source]

Berksfile:
source 'https://supermarket.chef.io'

cookbook 'nginx'

Run test kitchen setup:
kitchen setup

Error when using 12.0.1:
* remote_file[http://nginx.org/download/nginx-1.4.4.tar.gz] action create[2014-12-11T00:51:38+00:00] INFO: Processing remote_file[http://nginx.org/download/nginx-1.4.4.tar.gz] action create (nginx::source line 58)

           ================================================================================
           Error executing action `create` on resource 'remote_file[http://nginx.org/download/nginx-1.4.4.tar.gz]'
           ================================================================================

           Chef::Exceptions::ChecksumMismatch
           ----------------------------------
           Checksum on resource (0510af) does not match checksum on content (7c989a)

           Resource Declaration:
           ---------------------
           # In /tmp/kitchen/cache/cookbooks/nginx/recipes/source.rb

            58: remote_file nginx_url do
            59:   source   nginx_url
            60:   checksum node['nginx']['source']['checksum']
            61:   path     src_filepath
            62:   backup   false
            63: end
            64:

           Compiled Resource:
           ------------------
           # Declared in /tmp/kitchen/cache/cookbooks/nginx/recipes/source.rb:58:in `from_file'

           remote_file("http://nginx.org/download/nginx-1.4.4.tar.gz") do
             provider Chef::Provider::RemoteFile
             action "create"
             retries 0
             retry_delay 2
             default_guard_interpreter :default
             path "/tmp/kitchen/cache/nginx-1.4.4.tar.gz"
             atomic_update true
             source ["http://nginx.org/download/nginx-1.4.4.tar.gz"]
             use_etag true
             use_last_modified true
             cookbook_name "nginx"

         recipe_name "source"
             checksum "0510af71adac4b90484ac8caf3b8bd519a0f7126250c2799554d7a751a2db388"
           end

But remote_file downloads successfully with 11.12.2.

Still seems to be an issue. Updating the sha256sum to 7c989a58e5408c9593da0bebcd0e4ffc3d892d1316ba5042ddb0be5b0b4102b9 works for me.


Manually applying changes from fork to workaround inclusive namespaces

Source: https://github.com/mindspacepdx/passport-saml/pull/1

Please delete. Doesn't work well.
https://github.com/auth0/xml-crypto/commit/25a3d1c00fd0751530f7a06f7219c6eb6860412d does work better for that case.


Update README.md

Add myself to members

@JasonKeirstead Welcome to the WG! We don't have a formal agreement (yet) on how to land a PR, but let's leave it open for a few more days and then I'll merge it.

This PR has been open for a week, we've had no objections. I think this can be merged now.


Unable to retrieve information about deleted message from MessageDeleted event

For logging purposes I'd like to retrieve author/content of the deleted message. But IMessage optional parameter appears to be always null, this line is never reached:
https://github.com/RogueException/Discord.Net/blob/dev/src/Discord.Net/WebSocket/DiscordSocketClient.cs#L1253

I'll take a look today, try to repro

public async Task Run()
{
    client = new DiscordSocketClient(new DiscordSocketConfig { LogLevel = LogSeverity.Verbose });

    client.MessageDeleted += async (id, msg) =>
    {
        await Console.Out.WriteLineAsync($"Message present: {msg.IsSpecified}"); // Always returns False
    };

    client.Log += async (message) => await Console.Out.WriteLineAsync($"[{message.Severity}] {message.Source} -> {message.Message}");

    await client.LoginAsync(...);
    await client.ConnectAsync();

    Console.Read();
}

I traced the issue. Can repro.

Non issue, found the reason: if the message isn't cached, it won't have anything but what Discord sends, which is very limited.


How to add loading icon after copying dom

Question:
Specifications:
I want to add a loading spinner when h2c rendering the canvas because this step takes some time in which the page has no response. However, if I add the spinner just when I click the trigger button, the spinner will also be rendered into the canvas. What I understand is that the spinner should be added after the dom elements are copied. But I don't know when dom element copy finish. Can anyone help me? Thanks a lot.

html2canvas version tested with: 1.0.0-rc3
Browser & version: Chrome
Operating system: Win10

Have you tried onclone config?

Oh, just not notice that. Thank you so much!


Update entrypoint.sh

Changes how data var is used.
This allows user to provide the message formatted as needed for different services. Example, Slack requires: '{"text":"some message"}'

Resolving. I think it probably should still be changed, but I ended up switching to a Slatify (for Slack-specific notifications) which is based on a Javascript Github Action so I didn't end up testing this fully.


EXCEPTION_ACCESS_VIOLATION OpenJDK 11.0.1+13 when opening DirectoryDialog or FileDialog

Platform:
Windows 10
Architecture:
64 bit Build 17134 (10.0.17134.1)
We have consistent JVM crash on our test machine when opening  DirectoryDialog or FileDialog.
So far we managed to reproduce the issue only on our test machines and only when our product (large Eclipse based application) is run using QFTest GUI test tool (https://www.qfs.de/en.html).
Crash report is attached.
hs_err_AdoptOpenJDK.log
Issue is also reproducible on Oracle JDK (Java(TM) SE Runtime Environment (11.0.1+13) (build 11.0.1+13-LTS))
hs_err_OracleJRE.log

Closing due to lack of requested feedback. Besides, the problem description makes it sound like it isn't the fault of the JDK.


rename repo to mission-conops

references to repo name should be changed from flight-software to mission-conops, or Mission ConOps (if referred to as a title)

closed as per 0f4664a8eabb1f8f17b0b3473ade544c9f78d854


Any plan to update the CarlaPainter?

just want to know if there is any plan to update the CarlaPainter (carla_painter.py), its a great visualization component and would love to have it. Also is there any Rviz2 plugin for the polygon in ROS2?

hmm no plan recently but happy to review/merge any codes/PR.

Also is there any Rviz2 plugin for the polygon in ROS2?

Sorry not very familiar with ROS2.

thank you for your response! Will try if i can add that.

thank you for your response! Will try if i can add that.

hi, want to know if this issue is processing? It seems not only CarlaPainter class on Python side need to be updated, but also backend need to support paint interface again?
if it is possible using the carla.world.debug interfaces return, and render on the carlaviz directly?

hi, want to know if this issue is processing?

I personally am not working on it.

It seems not only CarlaPainter class on Python side need to be updated, but also backend need to support paint interface again?

Correct, both need to be updated.

if it is possible using the carla.world.debug interfaces return, and render on the carlaviz directly?

It sounds interesting. Happy to help review/merge related changes.


Master

Added respect for exif rotation tags when generating resized images.
Original image is not touched, so I added a suggestion to the README
that users could choose not to display the Original on their site.
I’ve made a default of FALSE for this so that existing sites aren’t broken, and I’ve incremented the version.rb to 1.1.1 (not sure what the etiquette there is?)
I hope I haven’t broken anything!
J

Coverage remained the same at 100.0% when pulling 7b736cc6d7a6cfbae84659a2eea493d76f0eb027 on jameswood:master into 0cc608031ed52caa3f91e0e9a7b6d9dee6d9ec3a on wildlyinaccurate:master.

Forget this - sorry - I'm still learning!


Function App System-Assigned Managed Identity - RBAC Assignments

1245 - Feature request - Support for Function App System-Assigned Managed Identity RBAC Assignments
PR Checklist

[x] I have added example(s) inside the [./examples/] folder
[x] I have added the example(s) to the integration test list for normal (~30 minutes) or long runner >30 minutes
[x] I have checked the coding conventions as per the wiki
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

[ ] YES
[x] NO

Testing
Run the example in examples/role_mapping/101-function-app-managed-identity

thanks for your contribution to Cloud Adoption Framework @lukecalderon-dca!


Setup CLA bot and CONTRIBUTING.md

CLA bot is already there – just needed to add labels. That's done now.
Please hold for CONTRIBUTING.md

We have CONTRIBUTING.md – something else needed?


Add ability to pass ItemSeparatorComponent as React Element

Commit: https://github.com/facebook/react-native/commit/5854b11bf9d42bab9dbe62b9152a3d3a94e42c13
RN: 0.70.x +

@Simek done!


Datepicker should be usable without an input field.

In its current form the datepicker has been implemented very awkwardly; the dialog window seems to have been implemented together with an input field. So when you tap the input field the date picker opens up. For the user it may not be very intuitive that tapping an input field will cause a date picker to pop up.
I'm trying to make the DatePicker appear using a custom button but I am finding this very difficult and I have had to resort to some dirty hacks to achieve this.
I propose that we expose the DatePickerDialog element to increase the flexibility of the date picker with very little additional effort.

Sorry for bringing up the old issue.
Is there any reason the initial state for open is false?
It would be great to open the DatePickerDialog declaratively, e.g. using the props.open property. It looks the author of the code considered that but it wasn't implemented.


Enable Markdown in summary

I need to add link in summary, but neither HTML or Markdown are currently allowed.
This PR enables using Markdown in summary text.

Thanks. I've accepted and merged the PR.


[Pipeline filtering] Template should mention if we are showing a filtering pipeline

Let's do some edits on our template side so is super clear that we are not showing the info from all the pipelines and that is limited to a list of pipelines

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description

https://dev.azure.com/dnceng/internal/_git/dotnet-helix-service/pullrequest/35175


Disable .NET 3.x Unity.Tasks.dll in .NET 4.x.

This labels Parse/Plugins/Unity.Tasks.dll (the real implementation)
with the gvh_dotnet-3.5 label so that the DLL is only enabled by
Version Handler (https://github.com/googlesamples/unity-jar-resolver)
if .NET 4.x is enabled.

Unfortunately this PR is outdated and due to recent changes to the repository and the structure of the assembly made by @TheFanatr the helper files for support of Tasks in older Unity versions is no longer necessary.
Thus I close this PR, feel free to reopen it or create a new one for any improvements you can provide.
However, thank you for your contribution =)


SAK-25099 - Anonymous topics in forums

An anonymous feature for forums.
Overview:
In anonymous contexts, users will see 6 uppercase hex characters in place of the authors' names. To help students address each other, and so that instructors may grade in anonymous contexts, each user's anonymous ID will remain consistent within a given site.  When the current user sees their own post, their anonymous ID will be suffixed with "(me)".
The anonymous setting is set by the instructor at the topic level, and it applies to all conversations within that topic. There are two options, and a permission:
Option 1: Posts are anonymous
Option 2: Reveal identities to roles with the "Identify Anonymous Authors" permission below
Permission: Identify Anonymous Authors
Option 2 is available only if option 1 is checked.
The new "Identify Anonymous Authors" permission allows site maintainers to control who will see the revealed identities, but it only applies if option 2 is checked.

I've done a preliminary code review on this, it seems pretty solid and well documented. I've made some comments about minor things here and there.
That said, this is a significant contribution in terms of both the amount of code added, and the new functionality. I think it would be best to get as many eyes on this as possible. If anyone has the time to do a review and/or test, it would be very beneficial.

Committed refactor

Good cleanup of PermissionsMask and creation of  setupMembershipItemPermission(DBMembershipItem, PermissionBean)

I've had a quick scan through and it's good, well done.
Nice to see the ToolPlacement stuff only in the tool and the SiteID exposed in the API. I think there are enitybroker endpoints for forums and this might allow someone to poke the API and find out who an anonymous user ID is (although I haven't double checked this). Also I think org.sakaiproject.component.app.messageforums.entity.MessageForumsEntityContentProducer will index the content and I don't think this is aware of anonymous topics.
From a design point of view it might have been cleaner to have all the anonymous IDs behind the API so that you can just retrieve the Topics and Messages and depending on the user and the topic the calls to Message.getAuthor() returns the anonymous ID when it's an anonymous topic and the normal username when it's not. This way the API acts as a choke on the data and it's much harder for a new feature to accidentally leak the read IDs in an anonymous topic. With all the work done this is coming a little late and also with the existing design/implementation of forums changes like these aren't always easy.

Thanks!
I had to confirm, but you cannot entity link to messages; just forums and topics.
I actually put 'getAnonAwareAuthor()' inside the Message API, but I didn't like it and I refactored it out. MessageImpl (a simple POJO with one line getters and setters) was getting bloated with ComponentManager calls and anonymous logic. The jsp files had references like #{selectedMessage.message.anonAwareAuthor} (as opposed to selectedMessage.anonAwareAuthor), and the Messages tool's implementation needed method stubs etc. So I refactored it all into DiscussionMessageBean, and it made everything a lot cleaner. But I see the concern that it would be easy to miss if messages were ever to be exposed outside of forums.

Completed a code review w/Brian

Verify/QA that emails sent to students who are "watching" the topic are anonymous
Look into removing the auto ID in the DB and just use SITE_ID + USER_ID as the ID
Verify that the grade sort bug in Statistics and Grading by topic + user is not a regression
re-add the removed feature for "msg.displayEid"
Discuss with list about:
a) Should anonymous topic be able to be turned back to normal after any messages are posted?
b) Should the anonymous option be added to the Forum template?

My 2 cents:
5a) No, once a message has been posted, this feature should be locked.
5b) No, I agree w/Brian that the instructor could think that the topic is anonymous when it isn't.

They're in fact anonymous
Our DBA agreed it's unnecessary; I will remove the ID field
Confirmed that the issue is reproducible on nightly
Will do!
Only Adam Marshall weighed in. We're in agreement that we:
a) should lock the option down
b) should not include anonymity options in the forum templates

In terms of 5 a), I would opt to lock the option down immediately. I know some internet forums are locked for editing / deletion once a user posts to them, but we should prevent the following condition:
Instructor creates anonymous topic
Student begins composing, is informed their post will be anonymous
Instructor flips anonymity off
Student posts; all is revealed.

Thanks!
5a) Yea, it makes sense to lock that option after its set and there is 1 post

Amended as per Bryan Holladay's suggestions


Fix to Value of dropdown changes automatically on item submission page

References
Add references/links to any related issues or PRs. These may include:

Fixes  #2145

Description
On item submission page, the value of first dropdown automatically resets to the first value present in the dropdown on pressing "enter" in any of the textbox. Now this has been fixed.
Instructions for Reviewers

Go to Item submission page
Select book from “type” dropdown. (Select any value other than first value in dropdown)
Click on text box with label as "identifier" and then press enter.

List of changes in this PR:

First, I change the event that triggers the OnSelect function, before it was onClick, now it is "keydown.enter". I made this change because the bug was in the click event, when the detect change was made to some other input (as explained in issue 2145), the click event was triggered on the dropdown by setting the first default value. But currently the "mousedown" event is handled, which seamlessly replaces the click event. Added the "keydown.enter" because trying to interact via the keyboard (and since the click event was not there) failed to fire the event.
Second, in the test I had to change the click event to "mousedown", since this is now the event that triggers the onSelect function.

Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[ ] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[ ] My PR passes ESLint validation using yarn lint
[ ] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[ ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[ ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[ ] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[ ] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[ ] If my PR fixes an issue ticket, I've linked them together.

Thanks @hugo-escire. This is a strange bug that must have been tricky to track down. I was able to reproduce it following the simple instructions. The patch works as described.

On second thought, after reading the explanation of the changes and reviewing the code this change seems straightforward. And, as I noted last week, the patch works as advertised, so I will merge this.


Add choosable Autonomous Modes

Try rebasing this branch on upstream/main and switching out those AutomaticShootCommands for the several actual autonomous modes when possible.


Adding /api/connector endpoint for returning all available connector …

…types;
Returning a static list for now to get going.
@mdrillin, here's a quick mock endpoint which returns all "available" connector types. You might use this to get REST API calls going and drive the initial connector selection page (there's an "enabled" flag which only is true for the PG connector). Is that useful for you to move on?

Note you can start the backend in dev mode (see README) and then you should be able to point the client in the yarn dev mode to it, so you don't need to deploy everything via Quarkus if you're working on the UI.

@jcechace, now with that basic infra in place, you also might want to take a first look, so to see whether you can sprinkle some QE pixie dust and make sure we start off into the right direction?

@gunnarmorling yeah this is definitely useful - @indraraj has the connector selection component in place, so we can work on hooking that up to the rest call now.  Thanks!

Cool, merged it.


File Headers

We need to have a proper and consistant file header message in the source files
-Some source files have no headers.
-Some has "Copyright (c) Microsoft Corporation.  All rights reserved."
-Some like OneGet has Apache License

I don't think that we actually need consistent header messages (as some codefiles have more specific copyrights based on their heritage), but I'll follow up with legal.

Case 1 is correct. Case 2 is redundant but harmless because the MIT license applies to everything. Case 3 doesn't apply anymore because OneGet is not in this repository.