useSelect merges label and aria-label

Provide a general summary of the issue here
When you use useSelect({ label: 'foo', aria-label: 'bar' }) the trigger prop becomes the label foo bar.
🤔 Expected Behavior?
the screen reader should read out bar
😯 Current Behavior
the screen reader reads out foo bar
💁 Possible Solution
don't merge labels
🔦 Context
You might have a select that has emojis or similar in the label, in that case you would like to create a screen reader friendly alternative.
This is currently not possible.
🖥 Steps to Reproduce
https://codesandbox.io/s/strange-sound-gmlr66
Version
3.16.1
What browsers are you seeing the problem on?
Chrome
If other, please specify.
No response
What operating system are you using?
Linux
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

Looks like useMenuTrigger could be the culprit.
https://github.com/adobe/react-spectrum/blob/09a258f098147f7e67a0430b593b08168220ec4a/packages/%40react-aria/menu/src/useMenuTrigger.ts#L137-L138

You can also hide specific parts of the visual label in other ways, such as using aria-hidden
https://codesandbox.io/s/musing-water-mx9cwv?file=/src/App.tsx:1305-1366
or linking another label via aria-labelledby and more specifically targeting the text node and not the emoji
Pick your favorite animal🐹
<Select aria-labelledby="read-this-part" />

I know that there are workarounds such as 🐹.
It's just that the default behaviour for all other elements including native elements such as the html select is that if you put an aria label it does not get merged.

I think we could try changing this line
https://github.com/adobe/react-spectrum/blob/09a258f098147f7e67a0430b593b08168220ec4a/packages/%40react-aria/select/src/useSelect.ts#L144
!props['aria-label'] && valueId,

If an aria-label is provided to the component, then we prefer that over the visible label, but we still fall back to the visible label in all other cases.
It also keeps the merging of the current value.
I think it matches the original description of the PR which introduced it as well https://github.com/adobe/react-spectrum/pull/306

If an aria-label is provided to the component, then we prefer that over the visible label, but we still fall back to the visible label in all other cases.

Definitly, there are 4 casse:

No aria props
Set aria-labledby to value.id label.id.
Only aria-label
Set aria-labledby to value.id trigger.id and trigger aria-label to props['aria-label'].
Only aria-labledby
Set aria-labledby to value.id props['aria-labledby'].
Both aria-label and aria-labledby
Set aria-labledby to value.id props['aria-labledby'] and trigger aria-label to props['aria-label'].

So in the end the labledby is always value plus label.

Would you be willing to make a PR?

Would you be willing to make a PR?

I will take a look.

@jguddas Upon testing this change futher today, the team decided to revert the change since it is actually a breaking change for many of our hooks/components that rely on the current aria-label + aria-labelledby chaining. There are some details here: https://github.com/adobe/react-spectrum/pull/5036#issue-1884735434, let us know what you think. For your own use case you could use https://github.com/adobe/react-spectrum/issues/4920#issuecomment-1681476500 or potentially ignore the majority of the labelProps returned by the hook (keeping onClick only)

Should we reopen this or is it impossible to deploy a breaking changes at all and we just have to give up?

Ideally we would have a solution that wouldn't break the RSP Picker or other people's hook implementation if they were relying on the prior aria-label + aria-labelledby chaining. The core issue here is that providing a label to the useSelect is a bit different from passing a label to a native select because we assume the label provided is going to be a visual label and thus we cannot omit the trigger's aria-labelledby. Since stuff from the hook can be modified freely by end users to suit their desired experience as mentioned in the workaround in some of the prior comments, the team was leaning towards keeping the hook as is. What do you think?


Darwin - %age and ETA's during backtesting, as well as mid-generation resuming

Problems I hoped to solve:

A backtest with a very high population might take more than 24 hrs to execute. If you're 80% done, but need your computer back for other things, you might really struggle with the decision on whether or not to let the generation finish, or kill it.
A sim might be broken (see #1249) or maybe taking longer than others, or maybe it's just taking a while and you'd like to know more. Current output gives no information about any of this.

To solve resuming mid-generation:
I now generate a token for the "run" that looks like "backtest_201801300356" where the number there is the timestamp. Inside it are nested files and folders related to the data. The pro being no more scattered millions of files in a single simulations folder. Now everything for the entire "run" is stored in one place.
To resume, you just add --population_data=backtest_201801300356 to your previous command and it'll re-start on the correct generation and sim set. So if you were at 87/100 sims and you closed it and restarted, you'll still be at 87/100 sims remaining.
As another benefit to this is that as soon as a sim is done, you can view its info and results within its own file within its generation folder, including the html output.
The only downside here is that this is not backward compatible with the old population_data param so any old runs you may have stored will no longer be resumable. I could revisit this if people think it's a real problem but I didn't want to clutter the codebase with multiple solutions to the same problem.
To add meaningful console output:
Instead of printing out the command along with the sim number, the command info is added to its sim file in the generation folder immediately, and now the output is made to be something more useful.

Start of the run, and at the end of each generation, timestamp and duration is printed.
During a run, you get info about how many sims are running, and the completion of each active run, and an ETA for the slowest currently running.

Done: 18, Active: 8, Remaining: 4, Completion: 66.4%, Slowest sim ETA: 1m 22s  18: 44.0%, 20: 26.7%, 21: 28.0%, 22: 26.4%, 23: 23.9%, 24: 13.7%, 25: 28.7%^C

Once a generation gets near completion, you'll get an ETA for every remaining sim. This can be useful for figuring out what's up with some particularly long running sims.
Like during trade/sim where it keeps updating the same line over and over, this does the same thing to not be overly noisy.

Final thoughts:
I don't actually think the PR should be simply accepted as is. I'm hoping for some people to really hammer at this and give some feedback and ideas on how to give it some better polish. I was originally hoping that I could give an ETA for the entire run early on, but considering some sims may take much longer than others, I can't figure out a way that doesn't involve lots of guesses with averages to compute and that'll just annoy people because it'll be wrong.
At any rate, I feel like there's more opportunity for useful output there but now that I've hit a solid stopping point I'm low on ideas. Let me know what you think!

Couple of thoughts:

It should give some clear indication of how to resume a run. Maybe by listening to kill signal and giving a copy-and-pastable command to do so.
Next to "Slowest sim ETA" it could also show "Current best vsBuyHold"

Both these last two thoughts are now implemented.

Here you can see in generation 1 it was spitting out the best balance mid-generation of runs that had completed so far. In generation 2 you can see it's spitting out a progress report of actively running sims.
At the bottom after I hit Ctrl+C you can see it gives you a copy-and-pasteable command you can run to resume the previous backtest.

@dauv @DeviaVir please give this another look now. I think it's ready!


Timer is randomly delayed when device is locked

Steps to Reproduce

Start a Timer with a 30 second delay - set the callback to fire a method to make a sound using (package audioplayers: ^0.7.8)
Lock the phone
Wait 30 seconds. Notice that the sound was not fired right away. Sometimes it is 15 seconds late, sometimes it is 45 seconds late.

Why is there such a delay when trying to get a sound to play after a specified time when the device is locked? If the device is NOT locked, the sound is made exactly 30 seconds after starting the timer, every time.
I have tried to schedule notifications with package flutter_local_notifications ^0.3.7 but that too sometimes delays up to 45 seconds.
What am I to do to ensure a sound is fired 30 seconds after a user action, EVEN when the device is locked?
Logs
[√] Flutter (Channel master, v0.11.7-pre.47, on Microsoft Windows [Version 10.0.17134.471], locale en-CA)
    • Flutter version 0.11.7-pre.47 at C:\src\flutter
    • Framework revision 5385132c6b (4 weeks ago), 2018-11-16 16:53:59 -0800
    • Engine revision c02dd8f935
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[√] Android toolchain - develop for Android devices (Android SDK 28.0.2)
    • Android SDK at C:\Users\KevinCherryholme\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[√] Android Studio (version 3.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 31.2.1
    • Dart plugin version 181.5656
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[!] VS Code, 64-bit edition (version 1.29.1)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[√] Connected device (1 available)
    • Pixel 3 XL • 88TY020NT • android-arm64 • Android 9 (API 28)

! Doctor found issues in 1 category.

It's probably that the app is suspended when the device is locked.
You might need something like https://medium.com/flutter-io/executing-dart-in-the-background-with-flutter-plugins-and-geofencing-2b3e40a1a124 to run code while the main app is suspended.
You could try something like https://stackoverflow.com/questions/52074265/flutter-detect-killing-off-the-app/52074534#52074534 to verify.

So a solution could be that I create a plugin and solve the issue with each platform individually? Does iOS allow developers something similar to Android services?
Thank you for the quick reply btw.

The medium article I linked above should mention how to do that in iOS.

Duplicate of #24278

Feel free to add a comment to have the issue reopened if you disagree.

I have the same problem, did you find a easy solution for that?

@AliGharian I haven't found a solution yet, sorry. I will get back to you if I do

@kevincherryholme Oh so bad, thank you so much.

Hi @kevincherryholme @AliGharian
can you please provide your flutter doctor -v ,
your pubspec.yaml
and reproducible minimal code sample.
Thank you

I think we need a correct timer

@iapicca
this issue was closed several months ago and isn't actively worked on
please open a new issue
providing your flutter doctor -v, your flutter run -v and a complete runnable minimal reproducible code sample

@iapicca are you mention wrong person ?


Dark mode gets reset on reload

Dark mode gets reset to light mode when the page is reloaded. This can be solved the using window.localStorage. Assign me this issue and I will fix it under Hacktoberfest.

Go ahead


Recommend using GPG signed commits vs. --signoff

The --signoff flag for commits is not often used and is primarily a declaration that the committer has actually authored the code or has rights to submit code she has not written. Instead, I think it's better to use cryptographically signed commits which can also be enforced by GitHub (see protected branches in settings). Using GPG signatures on commits is generally a better way to ensure that a commit is coming from the person it appears to be coming from, vs. --signoff which is just a line of text at the bottom of a commit message. By using GPG signed commits, there is much more certainty that the commit is legitimate and coming from the person it appears to be coming from.

I agree with that :+1:

Yes please. I use GPG and have not seen any problems. It has been frustrating seeing commits fail for this project due to this requirement.

Looking into this a bit further, the --signoff requirement is from the need for CNCF to enforce a commit's "Developer Certificate of Origin". I discussed this with @duglin in Slack. That conversation is pasted below.
I think this issue should be closed, but will leave it open for a bit so folks can catch up.
--
Lance Ball  12:27 PM
@dug in the JS SDK, we have an issue open to discuss using GPG signed commits vs. --signoff . But I took at the commit logs for all of the other repos in the cloudevents org and it seems they all require --signoff commits. Is this a CNCF requirement or is it just convention... or something else?
1 reply
Today at 12:27 PMView thread
dug  12:28 PM
let me check on broad the requirement is... but DCO is the one we use
12:28
and --signoff is basically DCO
Lance Ball  12:28 PM
yeah
dug  12:31 PM
I don't think I've been involved in any project that requires GPG since I've never done that before :slightly_smiling_face:
Lance Ball  12:34 PM
In GH repository branch protection settings you can check a box to require it. As a committer, once you configure it in git, it just happens - all commits are signed and you get the green Verified box for your commits in the commit log on GitHub.
dug  12:37 PM
is this really a problem for our SDKs? or is this more just a preventative thing?  I would be nervous about raising the bar for a new committer - people already have trouble with git as it is.  I would probably feel differently if k8s, kn, docker.... used GPG but, as I said, I've never seen the requirement
12:40
Another question... as I understand it, GPG is just about auth not about DCO, correct?
Lance Ball  12:41 PM
I think it came more from the fact that --signoff was a problem and I didn't want to suggest that we eliminate that without an alternative
12:42
definitely GPG is about auth and not DCO
dug  12:42 PM
why is --signoff a problem?  Don't we need that if DCO is our CLA-thingy?
12:42
if anything I would think people who like GPG should be suggesting both, not just GPG
Lance Ball  12:42 PM
It's not a huge problem once you get used to it. But the first couple of PRs most people submit don't have signoff commits and have to fix it
dug  12:43 PM
yup - I can see that. But we need some kind of DCO/CLA process so it kind of feels like there are two threads being mixed up here
Lance Ball  12:43 PM
I'm fine not making this change. Really wanted to understand if the DCO requirement was coming from CNCF and if so, we'll probably just close this issue
12:43
(but I'm going to copy/paste this discussion to the issue)
dug  12:46 PM
so, I just checked and I'm told that the CNCF requires some kind of process - each project can choose DCO vs CLA vs ...  but "no process" is not a valid choice. So, GPG vs --signoff are indeed separate topics
Lance Ball  12:46 PM
Understood - thanks for the clarification. I'll note all of this in the issue.

Closing this issue since it seems at best we could add GPG signed commits as a requirement and I'm not sure I want to do that.


Osprey Recipe on Conda-forge

When Osprey 1.2 is released, I've volunteered to get a recipe for it up on conda-forge (along with hyperopt and possibly GPy) . I was wondering if anyone else wants to be listed as a co-maintainer of the recipe? That will basically give you privileges on the feedstock repo once it's created.
cc/ @cxhernandez @rmcgibbo

cc @mpharrigan as well

You can add me if you want

Hi, @cxhernandez @rmcgibbo  @mpharrigan
I installed Ospray with conda, but would like to "merge/upgrade "  with modified version from github: https://github.com/larsbratholm/osprey/  the commit - '4bfbb14'
How can I do that in my conda python 3.5 virtual env. ?
I see that cross_validators.py  and others are different, so I am having error whilest trying to reproduce published paper results.
Thank you in advance  and really appreciate your time.
= osprey is a tool for machine learning hyperparameter optimization. =
osprey version:      1.1.0
time:                August 26, 2019  2:56 PM
hostname:            xxx
cwd:                 /paper_si-master/osprey
pid:                 3929
Loading config file:     config1aK.yaml...
Loading dataset...
Dataset contains 21563 element(s) with out labels
The elements have shape: [(1,), (1,), (1,), (1,), (1,), (1,), (1,), (1,), (1,), (1,), (1,), (1,), (1,), (1,), (1,), (1,), (1,), (1,), (1,), (1,), ...]
Instantiated estimator:


test cases failed in Java 11 (same as CI)

On my PC:
vnaeli@vnaeli-ga990fxaud5:~/IdeaProjects/attestation$ java -version
openjdk version "11.0.11" 2021-04-20
OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode, sharing)
vnaeli@vnaeli-ga990fxaud5:~/IdeaProjects/attestation$ javac -version
javac 11.0.11
vnaeli@vnaeli-ga990fxaud5:~/IdeaProjects/attestation$ gradle build

> Task :test

TestAttestationUsageEip712 > otherTimeLimit() FAILED
    org.opentest4j.AssertionFailedError at TestAttestationUsageEip712.java:103

TestAttestationUsageEip712 > testDecoding() FAILED
    org.opentest4j.AssertionFailedError at TestAttestationUsageEip712.java:112

228 tests completed, 2 failed

> Task :test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///home/vnaeli/IdeaProjects/attestation/build/reports/tests/test/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 26s
4 actionable tasks: 1 executed, 3 up-to-date

It seems one of the previous fix I applied actually reduced the failed test-cases. An earlier version had more:
attestation$ gradle build

> Task :compileJava
Note: /home/vnaeli/IdeaProjects/attestation/src/main/java/com/alphawallet/attestation/IdentifierAttestation.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :compileTestJava
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :test

TestAttestationUsageEip712 > otherTimeLimit() FAILED
    org.opentest4j.AssertionFailedError at TestAttestationUsageEip712.java:103

Eip712Test > referenceEncodingOtherOrder() FAILED
    org.opentest4j.AssertionFailedError at Eip712Test.java:58

Eip712Test > referenceEncoding() FAILED
    org.opentest4j.AssertionFailedError at Eip712Test.java:73

228 tests completed, 3 failed

> Task :test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///home/vnaeli/IdeaProjects/attestation/build/reports/tests/test/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 25s
4 actionable tasks: 4 executed

The same issue is reproduced if I use java/javac from jdk16
vnaeli@vnaeli-ga990fxaud5:~/IdeaProjects/attestation$ javac -version
javac 16.0.1
vnaeli@vnaeli-ga990fxaud5:~/IdeaProjects/attestation$ java -version
openjdk version "16.0.1" 2021-04-20
OpenJDK Runtime Environment (build 16.0.1+9-Ubuntu-120.04)
OpenJDK 64-Bit Server VM (build 16.0.1+9-Ubuntu-120.04, mixed mode, sharing)
vnaeli@vnaeli-ga990fxaud5:~/IdeaProjects/attestation$ gradle build

> Task :test

Eip712Test > referenceEncodingOtherOrder() FAILED
    org.opentest4j.AssertionFailedError at Eip712Test.java:58

Eip712Test > referenceEncoding() FAILED
    org.opentest4j.AssertionFailedError at Eip712Test.java:73

228 tests completed, 2 failed

> Task :test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///home/vnaeli/IdeaProjects/attestation/build/reports/tests/test/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 23s
4 actionable tasks: 1 executed, 3 up-to-date

Could not reproduce this on Ubuntu-20.04 AMD64 with Java-11.0.11 and Gradle 7.1.1
sam@focal64vm0:~$ java -version
openjdk version "11.0.11" 2021-04-20
OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode, sharing)
sam@focal64vm0:~$ gradle -version

------------------------------------------------------------
Gradle 7.1.1
------------------------------------------------------------

Build time:   2021-07-02 12:16:43 UTC
Revision:     774525a055494e0ece39f522ac7ad17498ce032c

Kotlin:       1.4.31
Groovy:       3.0.7
Ant:          Apache Ant(TM) version 1.10.9 compiled on September 27 2020
JVM:          11.0.11 (Ubuntu 11.0.11+9-Ubuntu-0ubuntu2.20.04)
OS:           Linux 5.4.0-77-generic amd64

sam@focal64vm0:~$ git clone https://github.com/TokenScript/attestation.git
Cloning into 'attestation'...
remote: Enumerating objects: 8264, done.
remote: Counting objects: 100% (653/653), done.
remote: Compressing objects: 100% (454/454), done.
remote: Total 8264 (delta 221), reused 420 (delta 118), pack-reused 7611
Receiving objects: 100% (8264/8264), 10.63 MiB | 1.80 MiB/s, done.
Resolving deltas: 100% (3523/3523), done.
sam@focal64vm0:~$ cd attestation/
sam@focal64vm0:~/attestation$ gradle build
Starting a Gradle Daemon (subsequent builds will be faster)

> Task :compileJava
Note: /home/sam/attestation/src/main/java/com/alphawallet/attestation/IdentifierAttestation.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :compileTestJava
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

BUILD SUCCESSFUL in 1m 59s
5 actionable tasks: 5 executed
sam@focal64vm0:~/attestation$

Could not reproduce this on Ubuntu-20.04 AMD64 with Java-16.0.1 and Gradle 7.1.1
sam@focal64vm0:~$ java -version
openjdk version "16.0.1" 2021-04-20
OpenJDK Runtime Environment (build 16.0.1+9-Ubuntu-120.04)
OpenJDK 64-Bit Server VM (build 16.0.1+9-Ubuntu-120.04, mixed mode, sharing)
sam@focal64vm0:~$ gradle -version

------------------------------------------------------------
Gradle 7.1.1
------------------------------------------------------------

Build time:   2021-07-02 12:16:43 UTC
Revision:     774525a055494e0ece39f522ac7ad17498ce032c

Kotlin:       1.4.31
Groovy:       3.0.7
Ant:          Apache Ant(TM) version 1.10.9 compiled on September 27 2020
JVM:          16.0.1 (Private Build 16.0.1+9-Ubuntu-120.04)
OS:           Linux 5.4.0-77-generic amd64

sam@focal64vm0:~$ git clone https://github.com/TokenScript/attestation.git
Cloning into 'attestation'...
remote: Enumerating objects: 8264, done.
remote: Counting objects: 100% (653/653), done.
remote: Compressing objects: 100% (454/454), done.
remote: Total 8264 (delta 221), reused 420 (delta 118), pack-reused 7611
Receiving objects: 100% (8264/8264), 10.63 MiB | 1.46 MiB/s, done.
Resolving deltas: 100% (3523/3523), done.
sam@focal64vm0:~$ cd attestation/
sam@focal64vm0:~/attestation$ gradle build

> Task :compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :compileTestJava
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

BUILD SUCCESSFUL in 25s
5 actionable tasks: 5 executed
sam@focal64vm0:~/attestation$

could reproduce it with Ubuntu-20.04 AMD64 with Java-16.0.1 and Gradle 7.1.1

I have got issue with tests for Windows 10

gradle -v

Gradle 6.7.1
Build time:   2020-11-16 17:09:24 UTC
Revision:     2972ff02f3210d2ceed2f1ea880f026acfbab5c0
Kotlin:       1.3.72
Groovy:       2.5.12
Ant:          Apache Ant(TM) version 1.10.8 compiled on May 10 2020
JVM:          15.0.1 (Oracle Corporation 15.0.1+9-18)
OS:           Windows 10 10.0 amd64

gradle testJavaScript

Task :npmInstall
npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!
npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN<EMAIL_ADDRESS>No license field.

audited 6 packages in 0.933s
found 0 vulnerabilities

Task :test

TestAttestationUsageEip712 > testSunshine() FAILED
org.opentest4j.AssertionFailedError at TestAttestationUsageEip712.java:93
TestAttestationUsageEip712 > nonverifiableUseAttesation() FAILED
org.opentest4j.AssertionFailedError at TestAttestationUsageEip712.java:219
TestAttestationUsageEip712 > otherTimeLimit() FAILED
org.opentest4j.AssertionFailedError at TestAttestationUsageEip712.java:103
TestAttestationUsageEip712 > testDecoding() FAILED
org.opentest4j.AssertionFailedError at TestAttestationUsageEip712.java:112
IdentifierAttestationTest > testUrlEncoding() FAILED
org.opentest4j.AssertionFailedError at IdentifierAttestationTest.java:160
228 tests completed, 5 failed

Task :test FAILED

I once fixed one of the 4 errors I had (that's why I only have 3 errors). The fix I had is:
https://github.com/TokenScript/attestation/commit/52c6b261751e85b407fa0aefc31705f9593e1526
I hope this might shed some light on the cause of these problems.

fixed by #164


syntax error

Hi, under Arch with dependency python-pyqt4 installed i get:
python iptv_cli.py
File "iptv_cli.py", line 14
print ""
^
SyntaxError: Missing parentheses in call to 'print'
May it be due to the python's version used by the system?

Different error using python2:
python2 iptv_cli.py
Traceback (most recent call last):
File "iptv_cli.py", line 2, in
import Crawler
File "/home/marco/IPTV/iptv/Crawler.py", line 2, in
import google
ImportError: No module named google

run pip install -r requirements.txt in order to get the full dependencies

sudo pip install google
2016-01-03 13:25 GMT+01:00 Marco Londero<EMAIL_ADDRESS>
Different error using python2:
python2 iptv_cli.py
Traceback (most recent call last):
File "iptv_cli.py", line 2, in
import Crawler
File "/home/marco/IPTV/iptv/Crawler.py", line 2, in
import google
ImportError: No module named google
—
Reply to this email directly or view it on GitHub
https://github.com/Pinperepette/IPTV/issues/12#issuecomment-168493914.

--
I-I4ckeI2 ®
Security Researcher
"Voi potete fermare questo individuo, ma non potete fermarci tutti ... dopo
tutto, siamo tutti uguali."
http://pinperepette.it http://pinperepette.it/info/ puoi contattarmi
anche a<EMAIL_ADDRESS>

salve, sapete come posso risolvere?
tony@System:~/Scrivania/IPTV-master/iptv$ ls
Crawler.py iptv.py  languages  output  requirements.txt
tony@System:~/Scrivania/IPTV-master/iptv$ pip install -r requirements.txt
Downloading/unpacking pyprind==2.9.3 (from -r requirements.txt (line 1))
Downloading PyPrind-2.9.3.zip
Running setup.py (path:/tmp/pip_build_tony/pyprind/setup.py) egg_info for package pyprind
Downloading/unpacking google==1.7 (from -r requirements.txt (line 2))
Downloading google-1.7-py2-none-any.whl
Downloading/unpacking psutil==3.3.0 (from -r requirements.txt (line 3))
Downloading psutil-3.3.0.tar.gz (261kB): 261kB downloaded
Running setup.py (path:/tmp/pip_build_tony/psutil/setup.py) egg_info for package psutil
warning: no previously-included files matching '*' found under directory 'docs/_build'
warning: manifest_maker: MANIFEST.in, line 18: 'recursive-include' expects <dir> <pattern1> <pattern2> ...

Downloading/unpacking clint==0.5.1 (from -r requirements.txt (line 4))
Downloading clint-0.5.1.tar.gz
Running setup.py (path:/tmp/pip_build_tony/clint/setup.py) egg_info for package clint
warning: no files found matching 'recursive-include'
warning: no files found matching 'docs'

Downloading/unpacking colored==1.2.1 (from -r requirements.txt (line 5))
Downloading colored-1.2.1.tar.gz
Running setup.py (path:/tmp/pip_build_tony/colored/setup.py) egg_info for package colored
Downloading/unpacking tqdm==3.4.0 (from -r requirements.txt (line 6))
Downloading tqdm-3.4.0-py2.py3-none-any.whl
Downloading/unpacking beautifulsoup4 (from google==1.7->-r requirements.txt (line 2))
Downloading beautifulsoup4-4.4.1-py2-none-any.whl (81kB): 81kB downloaded
Downloading/unpacking args (from clint==0.5.1->-r requirements.txt (line 4))
Downloading args-0.1.0.tar.gz
Running setup.py (path:/tmp/pip_build_tony/args/setup.py) egg_info for package args
Installing collected packages: pyprind, google, psutil, clint, colored, tqdm, beautifulsoup4, args
Running setup.py install for pyprind
error: could not create '/usr/local/lib/python2.7/dist-packages/pyprind': Permission denied
Complete output from command /usr/bin/python -c "import setuptools, tokenize;file='/tmp/pip_build_tony/pyprind/setup.py';exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))" install --record /tmp/pip-TLvCSi-record/install-record.txt --single-version-externally-managed --compile:
running install
running build
running build_py
creating build
creating build/lib.linux-i686-2.7
creating build/lib.linux-i686-2.7/pyprind
copying pyprind/prog_class.py -> build/lib.linux-i686-2.7/pyprind
copying pyprind/init.py -> build/lib.linux-i686-2.7/pyprind
copying pyprind/generator_factory.py -> build/lib.linux-i686-2.7/pyprind
copying pyprind/progbar.py -> build/lib.linux-i686-2.7/pyprind
copying pyprind/progpercent.py -> build/lib.linux-i686-2.7/pyprind
running install_lib
creating /usr/local/lib/python2.7/dist-packages/pyprind
error: could not create '/usr/local/lib/python2.7/dist-packages/pyprind': Permission denied

Cleaning up...
Command /usr/bin/python -c "import setuptools, tokenize;file='/tmp/pip_build_tony/pyprind/setup.py';exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))" install --record /tmp/pip-TLvCSi-record/install-record.txt --single-version-externally-managed --compile failed with error code 1 in /tmp/pip_build_tony/pyprind
Storing debug log for failure in /home/tony/.pip/pip.log


New release?

I noticed you've merged #16 (which is awesome - thank you!), but this change hasn't yet been published as a release. Is there any timescale for this to happen?
I have noticed the build is failing, but this could be because the build matrix is set to build against Node versions that eslint doesn't support.
Is there anything I can do to unblock this? Happy to help in any way I can.

Happy to give you publish powers when im back from iowa biking
On Wed, Jul 24, 2019 at 9:35 AM Stuart Harrison<EMAIL_ADDRESS>wrote:

I noticed you've merged #16
https://github.com/EasyAsABC123/grunt-standard/pull/16 (which is
awesome - thank you!), but this change hasn't yet been published as a
release. Is there any timescale for this to happen?
I have noticed the build is failing, but this could be because the build
matrix is set to build against Node versions that StandardJS doens't
support.
Is there anything I can do to unblock this? Happy to help in any way I can.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/EasyAsABC123/grunt-standard/issues/17?email_source=notifications&email_token=AAOD5YAAYUHR56KDBCSBCJLQBBSCJA5CNFSM4IGQXGV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HBHA52Q,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOD5YG4Q6MNWG3I3A744BLQBBSCJANCNFSM4IGQXGVQ
.

Awesome, thank you!

feel free to deploy there, thanks

Lovely, thank you!


Addition of Competitive Programming Track(Roadmap)

@rishicds Hi, I have already completed C++ and DSA Learning Track (Roadmap ) , I would love to contribute to Competitive Programming Track as well . Kindly assign me this issue. Thanks :)

@rishicds Hi , Can you assign me this issue ASAP please . Thanks : ) Because the program is coming to an end , I just thought of finishing the roadmap sections . That's why ...Cheers

hello, sorry I was a bit busy, you can start working on this


Shard boundary semantics now supported for gRPC.

Goes along with https://github.com/googlegenomics/utils-java/pull/54
Tested this via:

utils-java/refactor-part1: mvn install
dataflow-java/refactor-redo: mvn verify

Looks good! I expect the Travis error is because utils isn't updated yet.


[Feature] Better docs

While this library looks really cool, it's really hard to understand how to use it.

there are only 8 usages of this lib on github (half of them - this repo):
https://github.com/search?l=TypeScript&q=creator+ts-creator&type=Code

import creator from 'ts-creator'

const generatedFactoryCode = creator(`const foo = "your code here"`)

This generates a string?
I was hoping the result to be a list of ts.Statement, and I'm not sure how to convert those? Eval?

import { transformSourceFile } from 'ts-creator'

declare const file: ts.SourceFile
const factoryFile = transformSourceFile(file)

It's not clear what this does, what's factoryFile, and why does it need to take a source file?

import { transformNode } from 'ts-creator'

declare const node: ts.Expression
const factoryNode = transformNode(node)

Same as above. It promises some kind of transformation, but it's not clear how to use it.

https://ts-creator.js.org/ - The playground it cool, but it comes empty, and there are no samples.
If you look at the typescript playground it comes pre-populated with code, and has lots of samples that people can play with to better understand how things work.
I'd be happy to send a PR for some of those things, but may need some clarification first.

in fact, I have such confusion about what could I do to use this package, what the purpose of it? it seems interesting, but I don't get the point.


USB Connection for Firmware change

If I would try to play with the firmware - modify and upload via Arduino IDE in the host computer.. shall I connect the usb cable to the OpenCR directly, not to the Joule board? That's what I would assume but hope to confirm.

Yes. You can upload it by connecting directly to OpenCR with your PC(not Joule board) after programming(modify, re-build) on your PC.

Thank you for the prompt reply.
There is a microUSB port in the Joule board. It has not been used in the manual, correct?
-- Young Park

From: Pyo<EMAIL_ADDRESS>Sent: Tuesday, April 17, 2018 10:05:33 PM
To: ROBOTIS-GIT/turtlebot3
Cc: Park, Young Soo; Author
Subject: Re: [ROBOTIS-GIT/turtlebot3] USB Connection for Firmware change (#186)
Yes. You can upload it by connecting directly to OpenCR with your PC(not Joule board) after programming(modify, re-build) on your PC.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/ROBOTIS-GIT/turtlebot3/issues/186#issuecomment-382237925, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALWC8McDtVXxAmmcVjfiCvRkLrPX0qLUks5tpq19gaJpZM4TZQGh.


Fix README to ease installation

I think the deployment instructions should be restored. Here is the latest version:
Deployment
First make sure to initialize the allowed list of aTokens & staticATokens on ./constants/allowlistedTokens.ts
yarn deploy-bridge:testnet #deploys the bridge on testnets

Intructions to deploy the bridge on mainnet are coming soon.


Create bikrant-interview

Please explain your complete experience in order to merge it in this repository.

Sorry to inform but this repository has been excluded from hacktoberfest. So inorder to make your PR count towards hacktoberfest, request you to make your contribution in this repository -> https://github.com/SR-Sunny-Raj/Hacktoberfest2022-for-all


Environment Variables Through AWS Amplify Console

** Please describe which feature you have a question about? **
I am trying to add environment variables and inject them into my React app (created using create-react-app) through the AWS Amplify console. I followed this guide. However, after I updated my amplify.yml file like the guide suggested, my builds have started failing.
** Provide additional details**
Here is my build log
#Completed phase: preBuild
# Starting phase: build
# Executing command: npm run build:
2020-07-15T17:51:24.795Z [WARNING]: npm
2020-07-15T17:51:24.795Z [WARNING]: ERR! missing script: build:
npm ERR!
npm ERR! Did you mean this?
npm ERR!     build
2020-07-15T17:51:24.963Z [WARNING]:
2020-07-15T17:51:24.965Z [WARNING]: npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/logs/2020-07-15T17_51_24_796Z-debug.log
2020-07-15T17:51:24.965Z [HELP]: Outputting the npm debug log
0 info it worked if it ends with ok
1 verbose cli [ '/root/.nvm/versions/node/v10.16.0/bin/node',
1 verbose cli   '/root/.nvm/versions/node/v10.16.0/bin/npm',
1 verbose cli   'run',
1 verbose cli   'build:' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose stack Error: missing script: build:
4 verbose stack
4 verbose stack Did you mean this?
4 verbose stack     build
4 verbose stack     at run (/root/.nvm/versions/node/v10.16.0/lib/node_modules/npm/lib/run-script.js:155:19)
4 verbose stack     at /root/.nvm/versions/node/v10.16.0/lib/node_modules/npm/lib/run-script.js:63:5
4 verbose stack     at /root/.nvm/versions/node/v10.16.0/lib/node_modules/npm/node_modules/read-package-json/read-json.js:115:5
4 verbose stack     at /root/.nvm/versions/node/v10.16.0/lib/node_modules/npm/node_modules/read-package-json/read-json.js:418:5
4 verbose stack     at checkBinReferences (/root/.nvm/versions/node/v10.16.0/lib/node_modules/npm/node_modules/read-package-json/read-json.js:373:45)
4 verbose stack     at final (/root/.nvm/versions/node/v10.16.0/lib/node_modules/npm/node_modules/read-package-json/read-json.js:416:3)
4 verbose stack     at then (/root/.nvm/versions/node/v10.16.0/lib/node_modules/npm/node_modules/read-package-json/read-json.js:160:5)
4 verbose stack     at /root/.nvm/versions/node/v10.16.0/lib/node_modules/npm/node_modules/read-package-json/read-json.js:280:12
4 verbose stack     at /root/.nvm/versions/node/v10.16.0/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:90:16
4 verbose stack     at FSReqWrap.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:53:3)
5 verbose cwd /codebuild/output/src299746030/src/barcode-generator
6 verbose Linux 4.14.181-108.257.amzn1.x86_64
7 verbose argv "/root/.nvm/versions/node/v10.16.0/bin/node" "/root/.nvm/versions/node/v10.16.0/bin/npm" "run" "build:"
8 verbose node v10.16.0
9 verbose npm  v6.9.0
10 error missing script: build:
10 error
10 error Did you mean this?
10 error     build
11 verbose exit [ 1, true ]
2020-07-15T17:51:24.969Z [ERROR]: !!! Build failed
2020-07-15T17:51:25.069Z [ERROR]: !!! Non-Zero Exit Code detected
2020-07-15T17:51:25.069Z [INFO]: # Starting environment caching...
2020-07-15T17:51:25.070Z [INFO]: # Environment caching completed
Terminating logging...
The guide linked above suggests the following command:
build:
commands:
- npm run build:$BUILD_ENV
This command seems to causing the build error.
How do I resolve this and inject my env variables during build time for use in my React app?

Hi, is there any way to figure this out? I'm assuming that this must be a known bug since I was following the official AWS Amplify docs when I made the changes to the amplify.yml file.

Okay, this approach is confusing me.
Using this approach I can see how I can run different script commands for different branches of my application.
However, this doesn't answer the question as to how to inject environment variables into the app itself.
The guide states the following:

Environment variables are key-value pairs that are available at build time. These configurations can be anything, including >the following:
Database connection details
Third-party API keys
Different customization parameters
Secrets

If I have a BUILD_ENV variable with a value of prod and can run the build:prod script, I can't set my DB keys or paths in the package.json file right? That would exposing them.
For instance, I can't have build:prod: API_KEY='1234' DB_KEY='ge15jrh8' react-scripts build
My question ultimately boils down to this: If I have a .env.production file and a .env.development file and I want to use the key value pairs from the .env.production file in one branch of my repo in the  AWS Amplify console and the key value pairs from .env.development file in the other branch of my repo, how would I accomplish that?

In general, it's not good practice to store api keys and secrets in the client side (be it package.json or .env files), since React injects them at build time into your source code which ends up in the browser. React warns about this too:
WARNING: Do not store any secrets (such as private API keys) in your React app! Environment variables are embedded into the build, meaning anyone can view them by inspecting your app's files. (More info)
To your question of having .env.production point to production branch, and .env.development point to develop branch, you can do it in either of the 2 ways:

Using .env files - Since React has a default behavior to use specific .env files depending on NODE_ENV variable (which we cannot override), you can define a custom script in package.json that loads a specific env file depending upon the branch. It uses env-cmd package as follows:
build:development": "env-cmd -f .env.development react-scripts build" . In this case to inject the environment variable with value as development, you would define it as an Environment variable in Amplify Console, and override the value for each branch.
Not using .env files - You could directly inject different values for the same environment variable per branch as follows:

Let me know if you have any questions.

Hi @abhi7cr, thank you for the prompt replies. I do have some more questions though.
So, I definitely want to avoid using .env files. However, from what I've understood from your previous comment, I can use the keys in the environment variables file to point to specific build scripts correct?
I have the following keys in my environment variables file

How would I use  REACT_APP_AUTH0_CLIENT_ID for instance?
I can't have a build:$REACT_APP_AUTH0_CLIENT_ID in my build scripts can I? Because that would expose my client id. Also, this still doesn't explain how I would have multiple environment variables either.
I'm sorry but I still don't quite understand how I'd inject these env variables into my React app.

I see you have defined REACT_APP_AUTH0_CLIENT_ID as an Environment variable. So you can use it in your react code using process.env.REACT_APP_AUTH0_CLIENT_ID. You don’t need to use build: $REACT_APP_AUTH0_CLIENT_ID. The ‘build:’ script is generally used to run the builds specific to an environment so as to load the corresponding .env files. For example,
build:development, build:production, etc. Since you are not planning to use .env files, you don’t need it.
As i said earlier, if you are injecting Client Id or any sensitive information into your React app, it is going to be exposed regardless of if you use .env files or inject directly using Amplify, since React just replaces process.env.REACT_APP_AUTH0_CLIENT_ID with the actual  value during build time, and the source code that would be shipped to the browser will expose the actual value. Ideally, you would have the frontend call your server, which would have access to the client ids/secrets.
For multiple environments, I see you have REACT_APP_SERVER_BASE_URL defined for all branches, with an override for develop. Now, when the develop branch is getting built, this environment variable will have the value you have defined against develop branch, and you can use it directly in your react code using: process.env.REACT_APP_SERVER_BASE_URL. Likewise for all other branches, it will take the default value.
Let me know if you need more clarifications😊

As i said earlier, if you are injecting Client Id or any sensitive information into your React app, it is going to be exposed regardless of if you use .env files or inject directly using Amplify, since React just replaces process.env.REACT_APP_AUTH0_CLIENT_ID with the actual value during build time, and the source code that would be shipped to the browser will expose the actual value. Ideally, you would have the frontend call your server, which would have access to the client ids/secrets

Ah, this explains so much. I was under the impression that there was a way to secretly inject all the env variables I needed through the AWS Amplify Console. However, the only secret I was considering worthwhile protecting was the Auth0 Client ID, which as it turns out shows up in the browser URL anyway.
For future readers, I decided to go with the env-cmd approach where I define two separate builds scripts build:development and build:production. I then load the relevant .env file for each script.
@abhi7cr thank you so much for your patience and help. I really appreciate it :)

@abhi7cr Hello there, i was wondering if i can ask for help. i have a node/react app and im trying to host it on AWS amplify but env variables are not working whatsoever! it clones my code from my github which i didnt push my .env file, so i have tried to add them manually but it didnt work! they say i have to modify this build section to:
build:
commands:
- npm run build:$BUILD_ENV
but its not working for, by the way i have 10 variables how can i add them like this?


Add tensorflow type stubs

Summary
Motivated from this issue.
These are tensorflow stubs I've accumulated over year of writing tensorflow code and wanting to have APIs I rely on be type checked. They are very much incomplete with classes/functions included here being ones I've used. I normally rely on pylance to tell me which members/functions are untyped and add stubs as needed. Probably needs a lot of getattr fallbacks until the files become complete to avoid false positives.
The stubs follow documentation for imports and not source code. The stubs were written by running different inputs in repl + double checking with documentation.
I'm opening pr to start discussion on how to upstream them. If splitting into several prs is preferred I'm happy to do that.
I'd also ideally want to eventually move them to typeshed after I work out the issue of numpy dependency. The tensorflow stubs have a lot of functions that accept numpy arrays so I need to be able to import numpy in them. It may be wiser to prioritize typeshed issue vs upstream here and then migrate later. But there's also benefit that having them somewhere open source at least opens ability for others to fill them in gradually.

Thanks for the PR; I would like to merge it but do need you to sign the CLA (there's a button higher up to do that). I think we need a mechanism like #pragma to allow us to map a type stub file to a file path in the package, so that things like docstring lookups and go-to-definition work; once we have that that we can look at bundling these. In the interim happy for these to have a home here (and if we can get to bundling them we should get good feedback plus contributions to make them more complete).

Numpy comment was specific to typeshed CI they run type checkers to examine correctness and currently assume only importing within same package or from other packages in typeshed. Since numpy isn't installed by default in there environment, it is main blocker on placing them in typeshed. I don't see any similar CI error here so shouldn't affect adding them.
For pragma question would it be better if I had the stubs define class in original place and then re-export them from documented place? Using tf.data.Dataset as an example I could have a stub file
tensorflow/python/data/ops/dataset_ops.pyi with definition of Dataset and then have second stub file.
tensorflow/data/init.pyi that re-exports it. The latter file doesn't exist at runtime but it's intended way to import it.
Lastly for the CLA, it may take couple days as part of these stubs were made during work and I am asking my employer for permission. I am trying just looks like it's rare for people to ask for permission at my company.

I've found process for CLA at my company. It will take a couple weeks though so will mark as draft.

Sorry for forgetting about this. I'll close as main blocker on typeshed side to upstreaming is partly resolved (external type dependency support) and I'd prefer to maintain these in typeshed where all type checkers (pyright, mypy, pyre, pytype) can share these instead of being pylance specific.

That's great news. It's our preference that stubs go in typeshed too; this repo is more of a staging area for stubs that aren't ready to go there yet.


Contingnet and pending being pulled through for For_sale

as subject says ive been getting alot of Contingent and Pending being put in my list even tho i have it as for _sale
example of two
1139 W Vineyard Plains Dr,
San Tan Valley, AZ 85143
730 N Sonora St,
Coolidge, AZ 85128

To omit these properties, use the exclude_pending parameter.


Google search results pointing to very old versions

I searched Google for "React Native elevation"

The link for this is
https://facebook.github.io/react-native/docs/0.52/view-style-props

0.52 is a really old release and the likelihood that the docs for that are very out of date.
Is there any SEO we can do to help results default to the current version?

What will be the right page here?

@rickhanlonii found this related issue from how Node solved this. https://github.com/nodejs/node-v0.x-archive/issues/941

My recommendation here for optimal SEO is:

Add a /latest vanity URL (so we can set this up once and leave it run)
Add ref="canonical" redirects to every versioned doc pointing to /latest
Update the sitemap to remove the versioned docs, and only include /latest

If I understand indexing correctly, then with this strategy search engines will show the /latest/<doc> page for search terms that also exist on latest and fall back to the old version for terms that have been removed. An ideal may be that every n version points to the n+1 version so that we fall back to the newest version, but that's probably unnecessary for now.
This works because search engines use canonical links as hints for redirects and know how to handle cases like this. We just have to tell them which pages are the preferred pages. Right now we tell them all pages are equal weight so they have to use other signals. Doing this with both ref="canonical" and the sitemap is required so they don't conflict.
Note we currently include every versioned page in our sitemap which is a lot of duplication and we're asking google to crawl them every hour (we should fix this ASAP):

Our existing unversioned links are the latest ones, do we need a /latest vanity? Or can the existing URL be the canonical?

@TheSavior good point, the /docs URLs function as /latest, updated.

I don't think this is the appropriate use of canonical given Google's guidelines. The feature is intended to point pages of duplicate content to a single "canonical" source (IIRC identical "meat" but the surrounding markup might differ—think mobile and desktop pages and reblogs).
Before we pursue canonical as a solution, let's get some data from other people who have used this solution. (Did this solve the problem for the Node community, or was the issue close after implementation and never revisited?)
I'll ask other documentation managers about their experiences. Let's not rush into implementing solutions just yet!

I believe the search is still cached, as it is still indexing the old url and redirecting to the new one.
https://facebook.github.io/react-native/docs/0.56/view-style-props.
https://webcache.googleusercontent.com/search?q=cache:iFhOA-9kJF4J:https://facebook.github.io/react-native/docs/0.56/view-style-props+&cd=1&hl=en
The third search option falls on the most current page.
In my view we have some decision-making to be made:

Some work really with SEO
Advise the use of the most current version in the old pages.

Note that the majority of pages across versions are exact duplicates because they're unchanged. I think google is able to verify duplicate content so using canonical would work even for pages that are slightly different.
There's no need to be perfect here - we could try some options and see what works. One thing we know is definitely wrong is the sitemap.

I believe this is still an issue, @rachelnabors any work from other documentation managers about their experiences?

@slorber something to take note
On Tue, Aug 25, 2020, 9:38 AM Ricky<EMAIL_ADDRESS>wrote:

I believe this is still an issue, @rachelnabors
https://github.com/rachelnabors any work from other documentation
managers about their experiences?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native-website/issues/1768#issuecomment-679451571,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKBCHKVOD346OVHLZICMRDSCMIY3ANCNFSM4LOXIOEA
.

@TheSavior @rickhanlonii It looks like the migration to V2 have solved the issue, at least in my Google results. 😉

I don't have the 2nd link on my search results 😅
Not sure why the migration fixed this, but it may be due to docs linking to each others in different versions through the new dropdown (vs the old versions page).
Will have to figure out if it's a good enough solution or if we can improve the SEO + docs versioning support.


[core] TikTok app isn't decompiled within 10 minutes (never finished)

Hi @skylot, there is an APK that cannot be decompiled https://drive.google.com/file/d/18riJBSLPWttKSijRbry4_DDtDciVm8Kx/view?usp=sharing
In my case, decompilation stuck on 60% in jadx-gui

I can't reproduce this. The APK loads and decompiles fine for me (using latest version from Git, in Java 11.0.8 Win 10, 6 threads).
May be the decompilation problem only occurs if a certain preference is set?

@sergey-wowwow I also can't reproduce this issue.
I tried different options and threads count and decompilation always complete.
Anyway, there are tons of other issues ;(

@skylot
Can you please try this configuration

@sergey-wowwow I tried your configuration several times, decompilation always successfully reached 100%.
Did you change any JVM settings like thread stack size (-Xss)?


Gradle does not handle well repositories that don't return 404

We have seen some badly configured maven repositories that don't return 404 on missing artifact and instead return a weird page. Example here.
When this happens, if the repo is ahead of the repo that does contain the artifact, then gradle will keep trying to download the pom again, and again, and again.
It would be nice to somehow improve the heuristic that decides whether the artifact is there or not. If the server returns something that looks like an HTML page rather than a POM, it could consider the artifact missing.
A less strict option would be to indicate to the users that it seems the repo is badly configured and to allow manually configuring said repo to consider non valid pom replies as 404.

@ducrohet That linked page seems to behave properly now.
There is no plan to change that behaviour in Gradle in the short / medium term. Aside from adding complexity on the Gradle side, it could also lead to complicated to diagnose failures. Especially if some of these were transient and cached.
Note that if you are impacted, you could leverage repository filtering so that you do not ping this repo for some modules.

The main issue is that people don't know what's happening. all they see if Gradle keeps downloading stuff.
I reported this here because people don't know what is happening. I discovered this particular broken repo from a user who complained that Gradle "always downloads dependencies on every build".
I had them run a scan, I saw that it was a failed download of a pom, noticed the repo output and understood the problem, and provided work-arounds (re-order repo, use repo filtering).
Most users won't know what's going on. Can we at least make the error more verbose or something so that people can figure this out on their own?


FAQ: Library overhead

It'd be useful to have some data in the FAQ about the databases overhead

size
method count
how much can pro-guard reduce

...including size of JNI libs, which is cannot be reduced by ProGuard.
(Presentations says ObjectBox is in C/C++. For instance, many people avoiding Realm because it has large JNI libraries.)

Arch
ObjectBox-Size
Realm-Size

x86
1,3MB
3,2MB

x86_64
-
3,1MB

mips
-
3,6MB

arm64-v8a
1,1MB
2,8MB

armeabi-v7a
838,5KB
1,8MB

Some more recent values (using 2.2.0) sourced using Android Studio APK Analyzer with our basic example.
io.objectbox package stats for default Android setup (no shrinking/optimization):

Defined Methods
Referenced Methods
Size

1217
1263
124 KB

Size of native libraries bundled with objectbox-android:

Arch
Size

x86
483 KB

x86_64
456 KB

arm64-v8a
419 KB

armeabi-v7a
355 KB

-ut


Status badge

Status badge for public build

@Azure/azure-sdk-eng

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Codecov Report

Merging #4361 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4361      +/-   ##
==========================================
- Coverage   53.45%   53.45%   -0.01%
==========================================
  Files       10451    10448       -3
  Lines      218340   218337       -3
==========================================
- Hits       116719   116716       -3
  Misses     101621   101621

Impacted Files
Coverage Δ

azure-common/azure/__init__.py

...suggest/azure/cognitiveservices/search/__init__.py

...-luis/azure/cognitiveservices/language/__init__.py

...ledge-qnamaker/azure/cognitiveservices/__init__.py

azure-mgmt-authorization/azure/mgmt/__init__.py

azure-mgmt-advisor/azure/mgmt/__init__.py

...osearch/azure/cognitiveservices/search/__init__.py
100% <0%> (ø)

azure-mgmt-documentdb/azure/mgmt/__init__.py
100% <0%> (ø)

...computervision/azure/cognitiveservices/__init__.py
100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b307b4...e56afca. Read the comment docs.

https://github.com/Azure/azure-sdk/issues/166


Icon documentation does not mention how to render the icon sprite on public pages

The Icon docs go into great detail about how to use Wagtail's Icons, the {% icon %} tag, etc, but they seem to be written under the assumption that you'll only ever want to use icons in the admin. Which means they don't have a single mention of the icon sprite, or how to render it on your public-facing pages.
Attempting to follow the current docs to put icons on your public pages just leads to frustration, because the sprite is essential, but never mentioned, so your {% icon %} tags simply won't work, for no obvious reason.
Pertinent section of the Wagtail docs
https://docs.wagtail.org/en/v6.3.1/advanced_topics/icons.html#icon-template-tag
I believe this section is likely the best place to add instructions how to to render the icon sprite, as that would also be template code.
Details
The icon sprite is rendered like this in the admin templates:
  <div data-sprite></div>
  <script src="{% versioned_static 'wagtailadmin/js/icons.js' %}" data-icon-url="{% icon_sprite_url %}"></script>

The docs should be changed to include instructions for putting that snippet at the top of the <body> tag in your app's base public template, alongside {% load wagtailadmin_tags %} (to get the templatetags it uses).
Working on this
I'd do a PR for this, but I'm not sure exactly how you'd want to express this as documentation.

Thanks, but the sprites are only intended for use in the Wagtail admin, hence it’s in wagtailadmin_tags and not wagtailcore_tags.

Well, many people are going to want icons on their public-facing pages, and it'd be extremely easy to let them know how to use the existing system that works fine, as long as the icon sprite is added to the base template.
But if you really want to prevent people from using the icon system outside the admin, the docs should be updated to explicitly state that the {% icon %} tag is only usable in the admin.

Hi, this issue seems interesting, and I’d like to work on it as my first contribution. Could you please assign it to me?

Hi @SharkyBytes - thanks for your interest! You're welcome to work on this, although we still need to reach agreement on what exactly should be done here - whether we should document the process for adding icons to public-facing pages, or add a note stating that they are only usable within the admin - and I would advise holding off on making any code / documentation changes until that's been done.
We don't assign issues outside of the core team - anyone is welcome to pick up any issue.

My preference would be to document that this is only usable within the admin. Wagtail has always taken the stance that front-end templating is your own concern, and one that Wagtail stays out of - while we can't and shouldn't stop developers from cherry-picking UI elements from the admin if that's what they want, it's up to the developer themselves to make that work. I don't think we want to start down a path of making Wagtail's UI components available as a formally-supported reusable framework - and if we ever do, we'd certainly want to rework the code to fit that purpose (at the very least, bundling that code snippet into a template tag of its own). Documenting internal details of Wagtail means that we're effectively locked in to doing it that way indefinitely, and unable to change the code to something better without going through a deprecation process.

There is a whole system for adding as many custom icons as you want. My team's project had registered dozens of additional icons via the wagtail-font-awesome-svg library, plus a few custom SVGs we created ourselves.
We had been using a custom template tag that called wagtail.admin.icons.get_icons() to put the icon sprite in our templates, but since that's an undocumented method, it actually got renamed in 6.1 (I think), and I had to remediate that during our upgrade, which is what prompted me to go looking for what the Wagtail admin does to get its sprite.
If gasman thinks this shouldn't be an officially supported front-end feature, that's fine. The appropriate resolution to this issue, in that case, would be to make it clear in the docs that the {% icon %} tag is exclusively for use in the admin.


languages.rust.enable doesn't work without adding clang as a package

Describe the bug
The Rust language environment doesn't work without manually installing the clang package. I think it would be a better user experience if that package was loaded automatically.
To Reproduce
mkdir devenv-rust
cd devenv-rust
devenv init

Use this configuration: { languages.rust.enable = true; } (as gist).
direnv allow
cargo init
cargo build

Result
error: linker `cc` not found
  |
  = note: No such file or directory (os error 2)

error: could not compile `devenv-rust` due to previous error

It is always necessary to manually add packages = with pkgs; [ clang ];
Version
devenv: 0.5

What if you also set languages.c.enable = true;?

That works as an alternative workaround.
But I still consider it a workaround. I'm not using C after all..

This is similar to https://github.com/cachix/devenv/pull/245, which I think the best solution is that Rust and similar tooling wants compiler stuff. Maybe calling it c is not the best description?

If cc was installed automatically it wouldn't matter much how the option is called :-).


Negative lookahead is not supported

Logs from GH action:
2022/07/26 13:26:48 Matching `^fix\(.*\)[^!]((?!BREAKING\sCHANGE).)*$` against: `fix(.github/labeler.yml): labels not being applied correctly [CDS-000]`
2022/07/26 13:26:48 release-as-fix: condition Title matches regex yields false

Label config
version: 1
labels:
  // Other labels
  - label: 'release-as-fix'
    title: '^fix\(.*\)[^!]((?!BREAKING\sCHANGE).)*$'

Regex that should match ^fix\(.*\)[^!]((?!BREAKING\sCHANGE).)*$
PR title fix(.github/labeler.yml): labels not being applied correctly [CDS-000]

If using a tool like https://regex101.com/ , you can verify that the PR title should match the regex

Hi, thanks for reporting this. It looks like a limitation in the go regex package:

It chokes on the negative look ahead. Removing the !? makes the expression compile. A quick search in Stack Overflow seems to confirm it.
Is there a chance you can rewrite the expression without using it? I can look into using a different regex library but that might take me a bit longer.
Cheers,

@srvaroa I've taken a look at working around this, but couldn't find any other way to do this w/ a regex.
The reason I'm using the negative lookahead is is because we have another label, release-as-major that's applied in case the PR title does contain "BREAKING CHANGE" and I don't want both "release-as-fix" and "release-as-major" to be applied.
- label: 'release-as-fix'
  title: '^fix\(.*\)((?!BREAKING\sCHANGE).)*'

- label: 'release-as-major'
  title: '^.*BREAKING CHANGE'

An alternative would be if it'd be possible to conditionally prevent a label from being applied if another label is already being applied.
A hypothetical API could look like this
- label: 'release-as-fix'
  title: '^fix.*$'
  not-together-with: '^release-as-major$'

- label: 'release-as-major'
  title: '^.*BREAKING CHANGE'

I'm open for other suggestions 🙂

Hi @Robin-Hoodie since this is a limitation in Go's regex library I've tried an imperfect workaround. I'm interested in knowing if this would cover your use case: https://github.com/srvaroa/labeler/pull/67

Thanks @Robin-Hoodie !

Workaround merged, please refer to docs here: https://github.com/srvaroa/labeler#negate-rules


Error message for connection error need to be externalized with SAS9.4(local-COM)

Describe the bug
Open VSC SAS Extension base on official released version. Per user's request, message "There was an error executing the SAS Program. See console log for more details" need to be externalized.
Steps to reproduce

Open VSC SAS Extension
Run some code against SAS9.4(local-COM) connection

Expected behavior
Having localized error message if the user got error prompt with message "There was an error executing the SAS Program. See console log for more details" accidentally.
Screenshots

Environment (please complete the following information):
Client OS: [e.g. Windows 10]
Extension version: [e.g. v1.5.0]

The problem do occur and need to be fix.


Error most likely caused by Hicharts

index.js:1437 Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
    in MotherWeightChart (at ReportTable/index.tsx:205)
    in div (created by Row)
    in Row (at ReportTable/index.tsx:204)
    in ReportTable (at PatientDetails/index.tsx:73)
    in div (at PatientDetails/index.tsx:60)
    in PatientInfo (created by Context.Consumer)
    in withRouter(PatientInfo) (created by ConnectFunction)
    in ConnectFunction (created by Context.Consumer)```

addressed via https://github.com/OpenSRP/opensrp-web/pull/97/commits/8f9ac36d5022c8a588f91f78a6ae713a4f7350c0


cmd/go: directory named go.mod defines new module but is otherwise ignored

What version of Go are you using (go version)?

go version devel +ee6bec958d Fri Mar 1 18:35:31 2019 +0000 linux/amd64

Does this issue reproduce with the latest release?
Yes
What did you do?
I have no idea how I ended up with a go.mod directory, but I did. I discovered this in x/tools so that's where the repro is.
tools/imports (master)$ git reset --hard
HEAD is now at e65039ee internal/lsp: make sure completion items are never null
tools/imports (master)$ GO111MODULE=on go list .
golang.org/x/tools/imports
tools/imports (master)$ mkdir go.mod
tools/imports (master)$ GO111MODULE=on go list .
go: finding golang.org/x/tools/imports latest
can't load package: package golang.org/x/tools/imports: unknown import path "golang.org/x/tools/imports": cannot find module providing package golang.org/x/tools/imports
tools/imports (master)$ GO111MODULE=on go mod tidy
go: finding golang.org/x/tools/imports latest
tools/imports (master)$ echo $?
0
tools/imports (master)$ echo 'module golang.org/x/tools' > ../go.mod
tools/imports (master*)$ GO111MODULE=on go mod tidy
tools/imports (master*)$ GO111MODULE=on go mod tidy
[snip]
tools/imports (master*)$ cat ../go.mod
module golang.org/x/tools

go 1.12

require golang.org/x/net v0.0.0-20190311183353-d8887717615a

The way it's ignored by tidy is strange; I imagine there are two code paths for finding go.mod and only one of them checks whether the file is a regular file. This is particularly confusing since Git won't show you an empty directory in git status.

I imagine there are two code paths for finding go.mod and only one of them checks whether the file is a regular file.

Three, actually. And you're right that only one of them checks for a file vs. a directory:
https://github.com/golang/go/blob/f54b8909ac93637159e2661f25aef5e61e8cd8fc/src/cmd/go/internal/modload/init.go#L487
https://github.com/golang/go/blob/5f40351708cabe28f90500be87dbe316a2280f4a/src/cmd/go/internal/modload/search.go#L79
https://github.com/golang/go/blob/f54b8909ac93637159e2661f25aef5e61e8cd8fc/src/cmd/go/internal/modload/import.go#L236

Make that four. And two of them check.
https://github.com/golang/go/blob/5f40351708cabe28f90500be87dbe316a2280f4a/src/go/build/build.go#L1042-L1043

Five.
https://github.com/golang/go/blob/5f40351708cabe28f90500be87dbe316a2280f4a/src/cmd/go/internal/search/search.go#L193


string search - wrong result is highlighted

if you search a string in "strings" view it highlights the item AFTER the search query.
OS: Ubuntu 16.04 LTS on Dev channel.
aarch64 architecture

I'm pretty sure this issue was fixed. I tested an was unable to reproduce in the latest dev build. Please reopen and provide repro steps if I'm wrong.


Don't render twice when goBack and re navigate on same screen

I use StackNavigator for a small application with some screens.
Current Behavior
When I am on screen B, goBack on screen A (B was unmount) and re navigate on B, B is re-mount.
Expected Behavior
I expect that the StackNavigator keep screen B mount so when I re navigate on B it don't render it twice.
How to do that ? Should I navigate without goBack ? (I use fade transition)
Your Environment

software
version

react-navigation
1.0.0-beta.11

react-native
0.43.4

node
6.10.3

npm or yarn
3.10.10

Here's a snack to go along with this.
I'm not sure why you would want the behavior you described as going back would imply you're not longer interested in that screen.
I also imagine it would add a host of issues with tracking navigation state (what happens when you go from screen 1 to screen 2, back to screen 1, then to screen 3 - does screen 2 get unmounted?)

@spencercarli
I'm not sure about @thomasarbona purpose.
But in my thought, he might not want to reload the content data again and again.
And that is what i want either, because i don't want user stuck on reload the content of screen page as always when they navigate from screen to screen.
Hope it will have the solution. Regards, :)

@sseyha ah that makes complete sense! Hadn't thought about that.
I'm typically using Redux so in cases like this I would have saved the data to the store after the first screen mount and then any subsequent screen mounts would use the old data and refresh in the background.

@spencercarli
Wow, you have a great idea. You blow my mind now.
It's a bit hard for me, because i'm new with React and Redux as well.
If you don't mind, could you please share us small project about this?
It will be honor and save my day of spending on React Navigation.
Please... :)

I don't have any small examples directly related to this but you can see my strategy in action in this repo.
That repo is broken down into a bunch of branches (it's for a course) but the final app can be found on the module-7-lesson-4-upload branch.

@spencercarli I will learn more about redux. However, Thank so much for your guide. Appreciate!

Thanks for your help! But my problem with the reloading isn't about reload any data (effectively stored in redux) but is to reload a fiew GLView components that take time to render.

Ah, I see. I'm not sure of a solution to this issue. I suppose I've seen a similar issue when pushing a screen with a map onto the stack. I'll do some thinking and if I can think of anything useful I'll try to add it to this thread.

@spencercarli You how to refresh or reload the current active page of drawer?

+1

1, don't want to reload the component again and again when re-enter the screen. Hope there have a solution for this.

Pinging OP @thomasarbona since this issue has not been active for a while, and it's related to an old version of the lib.
Please let me know if you want this to remain open; if I get no answer in the next 7 days I will close it.
Moreover:

When I am on screen B, goBack on screen A (B was unmount) and re navigate on B, B is re-mount.

This is literally the way a stack is supposed to work.
If there are data you need to manage/show in the second screen, you need to use a state manager like Redux. Or you could use a tab navigator without showing the tabbar.

Hi there @thomasarbona ,
In an effort to cleanup this project and prioritize a bit, since this issue had no follow up since my last comment I'm going to close it.
If you are still having the issue with the latest version (especially if it's a bug report) please check the current open issues, and if you can't find a duplicate, open a new one that uses the new Issue Template to provide some more details to help us solve it.

To the above posters that want to reload the content data, you can create a function which resets the data to their original state.

Hello! Someone found a solution?


[web] Unskip assertions test. Update for latest stack trace format.

Description
Unskip tests by fixing debugPrintStack for new format.
Related Issues
Fixes https://github.com/flutter/flutter/issues/53712
Tests
assertions_test updated.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: Replace with a link to your migration guide

Does this work with stack traces in flutter run? Unfortunately the stack traces are different between the tests which still use build_runner and flutter run which uses the frontend_server.
See also: https://github.com/flutter/flutter/issues/52685

Does this work with stack traces in flutter run? Unfortunately the stack traces are different between the tests which still use build_runner and flutter run which uses the frontend_server.
See also: #52685

Updated code to handle both build_runner and frontend_server based.


Cleanup strings

I removed a lot of crap, mostly related to compile time switches on string types (we never use std::wstring, so I made everything a std::string). I was able to remove some files and traits classes that are not needed.

The build is borked, mind having a look?

It only gets as far as a call to cURL at the beginning of the build...
The command "curl -sSL "http://llvm.org/apt/llvm-snapshot.gpg.key" | sudo -E apt-key add -" failed and exited with 2 during .

I don't know what this means.

Interesting. This means that the LLVM apt repository (PPA) isn't available at the time the tests ran. I'll retry it and see if this error is transient.

http://stackoverflow.com/questions/37558151/travis-ci-build-failing

Still no luck with the availability of the LLVM apt repo. Will you be able to test it locally? I would be OK to merge these changes without Travis for now if it works for you, so we are not blocked.


Deleting legacy Java client from TensorFlow main repository

TensorFlow main repository still contains the old Java client based on TF1.x that has been replaced a few years ago by the new version maintained by SIG-JVM.
This is very misleading for users who wants to discover the capabilities of running TensorFlow models on Java (just this week a new example of such question appeared on the forum).
This issue is to start the process of deleting this client for good in TF main repo. We could start by replacing this README for simply saying that this client is deprecated and provide links to the new repo. Then we can proceed to the folder deletion, making sure it won't break any code, CI jobs or external scripts (like the documentation one).
If need be, we at SIG-JVM can take care of pushing a series of pull requests to achieve this goal.
CC\ @bhack , @craigacp

/cc @theadactyl

P.s. I suggested to open an initial Issue (this) and PR sin the last SIG-JVM meeting.
The first one is at:
https://github.com/tensorflow/tensorflow/pull/58427

https://github.com/tensorflow/tensorflow/pull/58427 was merged.
Do we need something else?

Getting this link to point at the new API would be useful. It's where the "Java" link goes to from here.

@karllessard Could you please let us know if the above comments helped?
Thank you!

The old Java API should still be removed from this repository. We've tagged the first stable release of TF-Java over at github.com/tensorflow/java, users should be redirected there.

@Craigacp Thank you!
@karllessard, As mentioned could you please raise the issue in the https://github.com/tensorflow/java repository for the quick resolution. Thank you!

It should be removed from THIS repository, not the tensorflow/java one. It doesn't make sense to raise an issue to a repository that just happens to share a name with a word from this issue

As we said, we're happy to create PRs to remove the legacy Java client from this repository. However it's still receiving some commits and we've had no contact from the team inside Google who are doing those commits so we don't know if there are people inside Google still using it.

I think it's safe to remove, the recent commits seem to be only from automation and refactoring


codeunit 5700 "User Setup Management" extra parameter "Document Type" to GetLocation and change IntegrationEvent

Add extra parameter to procedures GetLocation and OnBeforeGetLocation "Document Type" of type Option
For sales is this quote, order etc.
Changes:
//procedure GetLocation(DocType: Option Sales,Purchase,Service; AccLocation: Code[10]; RespCenterCode: Code[10]) LocationCode: Code[10] //Old
procedure GetLocation(DocType: Option Sales,Purchase,Service; AccLocation: Code[10]; RespCenterCode: Code[10]; DocumentType: Option) LocationCode: Code[10] //New
var
IsHandled: Boolean;
begin
IsHandled := false;
//OnBeforeGetLocation(DocType, AccLocation, RespCenterCode, LocationCode, IsHandled); //Old
OnBeforeGetLocation(DocType, AccLocation, RespCenterCode, LocationCode, IsHandled, DocumentType); //New
if IsHandled then
exit(LocationCode);
    case DocType of
        DocType::Sales:
            UserRespCenter := GetSalesFilter();
        DocType::Purchase:
            UserRespCenter := GetPurchasesFilter();
        DocType::Service:
            UserRespCenter := GetServiceFilter();
    end;
    if UserRespCenter <> '' then
        RespCenterCode := UserRespCenter;
    if RespCenter.Get(RespCenterCode) then
        if RespCenter."Location Code" <> '' then
            UserLocation := RespCenter."Location Code";
    if AccLocation <> '' then
        exit(AccLocation);

    exit(UserLocation);
end;

[IntegrationEvent(false, false)]
local procedure OnBeforeGetLocation(DocType: Option Sales,Purchase,Service; AccLocation: Code[10]; RespCenterCode: Code[10]; var LocationCode: Code[10]; var IsHandled: Boolean) //Old
local procedure OnBeforeGetLocation(DocType: Option Sales,Purchase,Service; AccLocation: Code[10]; RespCenterCode: Code[10]; var LocationCode: Code[10]; var IsHandled: Boolean; DocumentType: Option) //New
begin
end;

Off cause te changes wher this routine is used, belowe a example for the Sales Header
procedure UpdateLocationCode(LocationCode: Code[10])
var
    IsHandled: Boolean;
begin
    IsHandled := false;
    OnBeforeUpdateLocationCode(Rec, LocationCode, IsHandled);
    if not IsHandled then
        //Validate("Location Code", UserSetupMgt.GetLocation(0, LocationCode, "Responsibility Center")); //Old
        Validate("Location Code", UserSetupMgt.GetLocation(0, LocationCode, "Responsibility Center", "Document Type")); //New
end;

Hi,
This is a breaking change. We are not able to add parameter in public procedure. Try to change request, so it can be aligned with coding guidelines.

Proposed new changes, so no breaking change.:
procedure GetLocation(DocType: Option Sales,Purchase,Service; AccLocation: Code[10]; RespCenterCode: Code[10]) LocationCode: Code[10]
var
    IsHandled: Boolean;
begin
    IsHandled := false;
    OnBeforeGetLocation(DocType, AccLocation, RespCenterCode, LocationCode, IsHandled);
    if IsHandled then
        exit(LocationCode);

    exit(GetLocation(DocType, AccLocation, RespCenterCode, -1));
end;

procedure GetLocation(DocType: Option Sales,Purchase,Service; AccLocation: Code[10]; RespCenterCode: Code[10]; DocumentType: Integer) LocationCode: Code[10] //New
var
    IsHandled: Boolean;
begin
    IsHandled := false;
    OnBeforeGetLocationDocumentType(DocType, DocumentType, AccLocation, RespCenterCode, LocationCode, IsHandled); //New
    if IsHandled then
        exit(LocationCode);

    case DocType of
        DocType::Sales:
            UserRespCenter := GetSalesFilter();
        DocType::Purchase:
            UserRespCenter := GetPurchasesFilter();
        DocType::Service:
            UserRespCenter := GetServiceFilter();
    end;
    if UserRespCenter <> '' then
        RespCenterCode := UserRespCenter;
    if RespCenter.Get(RespCenterCode) then
        if RespCenter."Location Code" <> '' then
            UserLocation := RespCenter."Location Code";
    if AccLocation <> '' then
        exit(AccLocation);

    exit(UserLocation);
end;

[IntegrationEvent(false, false)]
local procedure OnBeforeGetLocation(DocType: Option Sales,Purchase,Service; AccLocation: Code[10]; RespCenterCode: Code[10]; var LocationCode: Code[10]; var IsHandled: Boolean)
begin
end;

 //New Begin
[IntegrationEvent(false, false)]
local procedure OnBeforeGetLocationDocumentType(DocType: Option Sales,Purchase,Service; DocumentType: Integer; AccLocation: Code[10]; RespCenterCode: Code[10]; var LocationCode: Code[10]; var IsHandled: Boolean)
begin
end;
 //New End

Off cause te changes wher this routine is used, belowe a example for the Sales Header. Do this change also in Purchase and Service
procedure UpdateLocationCode(LocationCode: Code[10])
var
    IsHandled: Boolean;
begin
    IsHandled := false;
    OnBeforeUpdateLocationCode(Rec, LocationCode, IsHandled);
    if not IsHandled then
        //Validate("Location Code", UserSetupMgt.GetLocation(0, LocationCode, "Responsibility Center")); //Old
        Validate("Location Code", UserSetupMgt.GetLocation(0, LocationCode, "Responsibility Center", "Document Type".AsInteger())); //New
end;

Field Document Type in Sales, Purchases and Services modules use different enums and therefore different values.  We should not use Options anymore and combine this all together, instead we should obsolete these procedures and add new ones like GetSalesLocation, GetPurchaseLocation and GetServiceLocation. Request reclassified to Extensibility Enhancement.


Thank you and a big please.

If a definited word included among a definited phrase,  all the definitions lost. e.g. "problem” in “creative problem solving”.
plus: please delimited the number of words in a phrase.
Thank you!

Hi! Thanks for bringing up this issue! I'm currently working on improving the search algorithm for matching defined words/phrases, which will fix the issue you mentioned. It will also allow me to remove the limitation on the number of words in a phrase. This will be done in the upcoming release.

Maybe you can use this logic: longer is all. E.g. just mark “creative problem solving”, and neglect other possible definitions in it.

Fixed the issues you mentioned in 0.6.0. All words should be detected even if they appear within a defined phrase. I'll close this issue, but please let me know if you still encounter any issues with this!

Great improvment!


Design kit: Update symbol IDs

Olivia-Flory created the following on Sep 17:
Change all the symbol IDs in the Digital Design expressive (white theme) kit to not match Carbon white kit IDs.
Notes
We found the symbol IDs in the white design kit match the symbol IDs in Carbon. This could potentially cause some problems down the line because each symbol is meant to have a unique ID so Sketch doesn't get confused and mix up the symbols between documents.
The symbol IDs needs to be updated before releasing to the adopters because once the ID is changed, the symbol would break it's connection in another document and it would be a terrible experience for our adopters to have to reconnect every symbol they use.
Solution: I will duplicate all the symbols, then delete the original ones and rename all the symbols with the Rename it plug in to remove all the "copy"s
Acceptance criteria

[x] update all nested symbols
[x] no symbol name has "copy"
[x] symbols maintain structure within the kit
[x] symbols have a unique ID and do not match Carbon symbol IDs

Original issue: https://github.ibm.com/webstandards/digital-design/issues/1722

On Sep 20, Olivia-Flory commented:
@Wonil-Suh1 I will likely need to bump this estimate up to a 2. Realizing that duplicating the symbols is a great idea, but it means i have to go in and update all the nested symbols to the duplicated master, which will take me a bit longer.
I will keep track of my time to make sure it's at the right size for the amount of work in the end.


Support Flash Attention 2

The API can be found at https://github.com/Dao-AILab/flash-attention/blob/main/flash_attn/flash_attn_interface.py
It has some special functions for MQA and GQA. See varlen and kvpacked variants. Using them would be more efficient but it would complicate the implementation considerably and PyTorch doesn't support these. For this reason, I only added support for the basic case of having separate q, k, v tensors of equal size

Multi-query attention and grouped-query attention. Multi-query attention (MQA) [15] and groupedquery attention (GQA) [1] are variants of attention where multiple heads of query attend to the same head of
key and value, in order to reduce the size of KV cache during inference. Instead of having to duplicate the
key and value heads for the computation, we implicitly manipulate the indices into the head to perform the
same computation. In the backward pass, we need to sum the gradients dK and dV across different heads
that were implicitly duplicated.

Right now, backward seems broken: https://github.com/Dao-AILab/flash-attention/issues/325
  File "/home/carlos/venv/lib/python3.10/site-packages/torch/_tensor.py", line 491, in backward
    torch.autograd.backward(
  File "/home/carlos/venv/lib/python3.10/site-packages/torch/autograd/__init__.py", line 204, in backward
    Variable._execution_engine.run_backward(  # Calls into the C++ engine to run the backward pass
  File "/home/carlos/venv/lib/python3.10/site-packages/torch/autograd/function.py", line 274, in apply
    return user_fn(self, *args)
  File "/home/carlos/venv/lib/python3.10/site-packages/flash_attn/flash_attn_interface.py", line 269, in backward
    _flash_attn_backward(
  File "/home/carlos/venv/lib/python3.10/site-packages/flash_attn/flash_attn_interface.py", line 71, in _flash_attn_backward
    dq, dk, dv, softmax_d, = flash_attn_cuda.bwd(
RuntimeError: CUDA error: an illegal memory access was encountered

Blocked by https://github.com/Dao-AILab/flash-attention/issues/338


How can i enable the history in beta api.i need the history of all message i sent in channel

i want  to get the history of all message sent in my channel. i am current use the beta api for getting message  but no message showing.is any way to get history of all message

the history restful API is close beta now.

then how can i save the old message from this

sorry this feature is currently not available for GDPR compliance. if you definitely need this and you believe you are clear from GDPR compliance, you may try talking to our sales.


Add experimentation support to node LS proxy

For #14895
Includes #14896 (shame there's no GitHub equivalent to a gerrit CL stack...). Will mark as not draft after that is merged.
Not sure if this deserves a news entry in "enhancements" or not.

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[x] Has a news entry file (remember to thank yourself!).
[x] Appropriate comments and documentation strings in the code.
[x] Has sufficient logging.
[x] ~Has telemetry for enhancements.~
[x] ~Unit tests & system/integration tests are added/updated.~ (Tested against pylance)
[x] ~Test plan is updated as appropriate.~
[x] ~package-lock.json has been regenerated by running npm install (if dependencies have changed).~
[x] ~The wiki is updated with any design decisions/details.~

Not sure why the CI is failing for all Python 2.

The tests pass for me. Thanks for the review.


proposal: embed: read file contents directly from FS during fs.WalkDir

background
Currently there is no ergonomic way to walk an embed.FS and interact with file contents without handling a number of errors that are guaranteed to be nil.
//go:embed static
var static embed.FS

func main() {
        fs.WalkDir(data, ".", func(path string, d fs.DirEntry, err error) error {
                if err != nil {
                        return err
                }
                f, err := static.Open(path)
                if err != nil {
                        return err
                }
                b, err := io.ReadAll(f)
                if err != nil {
                        return err
                }
                fmt.Println(string(b)) // or something more interesting
                return nil
        })
}

Each fs.DirEntry, when using an embed.FS, is actually an embed.file that contains all the data that I want to use in io.Copy, however it is gated behind the data.Open call.
I understand that for a general file system this type of feature may be dangerous or unnecessary, as sometimes things change between stat and open, however for embed.FS these are invariants.
proposal
I can envision a new interface that gives direct access to the raw data:
package embed

func Walk(fsys FS, root string, fn func(path, data string))

I am not sold on this exact syntax, and it would need to document that it is just for ripping through file data, but think that there exists something for this problem space.
//go:embed static
var static embed.FS

func main() {
        embed.Walk(static, ".", func(_, data string) {
                fmt.Println(data) // or something more interesting
        })
}

alternatives
With sufficient testing, this could be implemented in an extended standard library as syntax sugar, but the amount of errors that would be ignored (or panicked) and data buffering scares me:
package x

func EmbedWalk(fsys embed.FS, root string, fn func(path string, data []byte)) {
        fs.WalkDir(fsys, root, func(path string, d DirEntry, _ error) error) {
                if !d.IsDir() {
                        f, _ := fsys.Open(path)
                        b, _ := io.ReadAll(f)
                        fn(path, b)
                }
                return nil
        }
}

Since there likely exist other cases that would benefit from this (immutable, in memory, or loops where you intend to read every file), it may be useful to create a more generic interface in the io/fs package instead of embed. This will require more exported symbols and may not be worth the hassle.
package fs

func WalkRead(fsys ReadFileFS, fn WalkReadFunc) error

type WalkReadFunc func(path string, data []byte, err error) error

Currently, the embed.file.Sys method always returns nil, it may be considered a breaking change to start providing a value, but if that could be something useful like embed.openFile/embed.openDir, you could abuse it like so:
        fs.WalkDir(data, ".", func(path string, d fs.DirEntry, err error) error {
                if err != nil {
                        return err
                }
                io.Copy(os.Stdout, d.(interface{ Sys() interface{} }).Sys().(io.Reader)) // or something more interesting
                return nil
        })

Using the existing interface, I could just panic, but this feels like bad form, and my goal is to simplify the interface:
        fs.WalkDir(data, ".", func(path string, d fs.DirEntry, err error) error {
                if err != nil {
                        return err
                }
                f, err := data.Open(path)
                if err != nil {
                        panic(err)
                }
                io.Copy(os.Stdout, f) // or something more interesting
                return nil
        })

FWIW, here's a runnable version of your code: https://play.golang.org/p/XkgAqsOBcJa
You can use fs.ReadFile whether an fs provides ReadFile or not and it will fallback to io.ReadAll, so I'm not sure why you'd need WalkRead.
The error passed into the WalkDirFunc is from errors trying to open a directory. For an embed.FS, you can just ignore it, or panic if you want, since they can't happen.
Here is a simplified version of your code:
	err := fs.WalkDir(static, ".", func(path string, d fs.DirEntry, err error) error {
		// cannot happen
		if err != nil {
			panic(err)
		}
		if d.IsDir() {
			return nil
		}
		b, err := fs.ReadFile(static, path)
		if err != nil {
			return err  // or panic or ignore
		}
		log.Printf("%q", b)
		return nil
	})

Playing with this code does make me aware that there's no way inside of a WalkDirFunc to see the fs that's being walked, which is a little unfortunate. It means the WalkDirFunc needs to be a closure over fsys. But in practice, I don't think many people are writing reusable WalkDirFuncs anyway, so I don't think it's a real limitation.
FWIW, in my experience, it's usually reads best to have the WalkDirFunc just collect valid path names in a slice and then do the processing after the walking is over. That also makes it easier to fan out goroutines if that's needed for performance. If you're doing it that way, the WalkDirFunc is usually pretty short and mostly just comparing file names to some pattern or another.

It does seem like in the case where the Open+Read+Close are guaranteed to succeed, it suffices to write
data, _ := fs.ReadFile(static, path)

That's just one line. It doesn't seem worth adding new API to avoid writing one line.

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

Based on the discussion above, this proposal seems like a likely decline.
— rsc for the proposal review group

data, _ := fs.ReadFile(static, path)

this seems like a really sharp edge. much like #45961 I am certian you or I could convince ourselves of if an error can be ignored, but this is a toy example. what if somebody comes behind and refactors fs.FS to an implementation other than embed.FS?

func EmbedFSOnlyWalkDir(fsys embed.FS, path string, f fs.WalkDirFunc) error {
	return fs.WalkDir(fsys, path, f)
}

No change in consensus, so declined.
— rsc for the proposal review group

so, just to confirm there is not any solution for performance concerns and the suggested alternative is to simply ignore errors?

The suggestion is to use fs.ReadFile.  It's fine to check the error result, although at present it will always be nil.


🐛 [firebase_messaging ] notification data not received correctly after kill app

Bug report
Describe the bug
In foreground and in background while app is open the the notification works perfect but when app is killed and the notification received and opened there's a weird behavior , which the app opens and went to home screen when i was send a route name ,So it expected to go to a specific screen , after much experiment with background top-level function , i found the following :

it call it self after kill but too fast , which it not makes the app open the  specific screen
when i tried to made a delay it but it depend on device memory and the processes that happen to catch the notification parameter .
when app open screen that contain interstitial Ad the close button of the interstitial Ad close the notification screen (pop it).

My Info :
I used the dependency : firebase_messaging : ^8.0.0-dev.15 with firebase core :  0.7.0 cause its the latest version that support flutter 1.66.2 and dart 2.10
it happened on both android and IOS
i was used to  firebase_messaging: ^7.0.3 without facing any problem

Hi @mustafa-707
Not being able to receive the background notification is the expected and documented behavior if the app is killed.
https://firebase.flutter.dev/docs/messaging/usage#receiving-messages
Thank you