Getting status code 10

Hello team,
I am developing an Android app to get user's daily steps from Huawei health. In order to achieve this, I followed the technical docs from this link [ https://developer.huawei.com/consumer/en/doc/development/HMSCore-Guides-V5/apply-id-0000001050069756-V5 ] and registered the Huawei ID and Health Kit of app ID [ xxxxxxxx ] with the new package name. When I run the demo app with a new package name it is giving me status code 10.
ConnectionResult.DEVELOPER_ERROR
10
HMS SDK internal error. AIDL connection succeeded, but the AIDL handle was not obtained. This is usually caused by a configuration error.
Contact Huawei technical support. This problem rarely occurs.\
Thanks

Can you provide your log for us to locate your error? And we notice that you are in India from you GiHub account. Huawei health kit is not supported in India now. This link lists the countries and regions we support now.

Can you provide your log for us to locate your error? And we notice that you are in India from you GiHub account. Huawei health kit is not supported in India now. This link lists the countries and regions we support now.

Yes, I am from India ( also know that India is not listed in the list ), but I am working for a UK-based account ( as a team member ). Please check the video, facing some developer configuration error.
https://user-images.githubusercontent.com/25820087/105350560-5ed2ba00-5c11-11eb-880a-d2d6b6d93270.mp4

Yes, I am from India ( also know that India is not listed in the list ), but I am working for a UK-based account ( as a team member ). Please check the video, facing some developer configuration error.
https://user-images.githubusercontent.com/25820087/105350560-5ed2ba00-5c11-11eb-880a-d2d6b6d93270.mp4

Hi, May you cut some ss when error occur ? The vedio can not be seen for bad nowrok

Hi, May you cut some ss when error occur ? The vedio can not be seen for bad nowrok

Yes sure

Yes sure

sory, the picture also can not be seen , may you create a ticket in our developer website and attach your ss and vedio

sory, the picture also can not be seen , may you create a ticket in our developer website and attach your ss and vedio

https://developer.huawei.com/consumer/en/support/feedback/#/
Here is our online feedback approach . and choose HMS Core-Health Kit and create a ticket to us

https://developer.huawei.com/consumer/en/support/feedback/#/
Here is our online feedback approach . and choose HMS Core-Health Kit and create a ticket to us

Yes Thanks, I already mailed the query on this email [<EMAIL_ADDRESS>]

Yes Thanks, I already mailed the query on this email [<EMAIL_ADDRESS>]

The 907135003 error usually occur in such situation :

The HMS version is too low, you may need clear Hms core application cache , data and update it ;
The project setting in you project may need be checked following the guide in (https://developer.huawei.com/consumer/en/doc/development/HMSCore-Guides/integrating-sdk-0000001050069724)

The 907135003 error usually occur in such situation :

The HMS version is too low, you may need clear Hms core application cache , data and update it ;
The project setting in you project may need be checked following the guide in (https://developer.huawei.com/consumer/en/doc/development/HMSCore-Guides/integrating-sdk-0000001050069724)

@healthkit-hms Hello,

My HMS version is updated.
I am following the same from HMSCore-Guide integration, also I am running this repo but still, it is giving me this. Is it because I am trying to authorize from an Indian Huawei account? But I also tried with  UK based account and the problem is same.

@healthkit-hms Hello,

My HMS version is updated.
I am following the same from HMSCore-Guide integration, also I am running this repo but still, it is giving me this. Is it because I am trying to authorize from an Indian Huawei account? But I also tried with  UK based account and the problem is same.

may you please cut the log when the error occurs (please use the logcat to get a full log) to us ?

may you please cut the log when the error occurs (please use the logcat to get a full log) to us ?

I've got the answer on my ticket in the developer account, that it requires a Huawei device in order to get Health data. Yesterday I order a Huawei device to test Health Kit.
Closing the issue as of now

I've got the answer on my ticket in the developer account, that it requires a Huawei device in order to get Health data. Yesterday I order a Huawei device to test Health Kit.
Closing the issue as of now


[question] apis don't seem to be published: 404 in apiservice status

hello, I believe I have successfully deployed my first apiserver built with apiserver-builder-beta. My apiservice status looks as this:
  conditions:
    - type: Available
      status: 'False'
      lastTransitionTime: '2021-03-29T19:40:49Z'
      reason: FailedDiscoveryCheck
      message: >-
        failing or missing response from
        https://<IP_ADDRESS>:8443/apis/vault.redhatcop.redhat.io/v1alpha1: bad
        status from
        https://<IP_ADDRESS>:8443/apis/vault.redhatcop.redhat.io/v1alpha1: 404

I interpret this as being the master api calling that path on the my apiserver and getting a 404.
On a good note, if I make that call with a simple curl command I get a 403, so authn/authz delegation works.
The question is why the 404/not found?
I am publishing the apiserver like this:
	err := builder.APIServer.
		WithResourceAndHandler(&redhatcopv1alpha1.SecretEngine{}, filepath.NewJSONFilepathStorageProvider(&redhatcopv1alpha1.SecretEngine{}, "data")). // namespaced resource
		WithLocalDebugExtension().
		Execute()

and the SecretEngine resource is defines the follow gvr:
func (in *SecretEngine) GetGroupVersionResource() schema.GroupVersionResource {
	return schema.GroupVersionResource{
		Group:    "vault.redhatcop.redhat.io",
		Version:  "v1alpha1",
		Resource: "secretengines",
	}
}

what am I doing wrong?

solved.

@raffaelespazzoli  can you share your solution? I got 404 and 403 exactly the same way you did.


Core50 result

flow<compare_all.py --experiment=CORe50 --n-seeds=10 --seed=11 --single-epochs --batch=1 --fc-layers=2 --z-dim=200 --fc-units=1024 --lr=0.0001 --c=10 --lambda=10 --omega-max=0.1 --ar1-c=1. --dg-prop=0. --bir-c=0.01 --si-dg-prop=0.6>
According to the code provided in the file, the result of running Core50 dataset is inconsistent with that in the article( BIR Table2)

Hi jiaolifengmi, thank you for the feedback. Could you provide a bit more details? Then I’ll look into it. For example, what are the results that you get when you run this comment?

flow the command.sh <compare_all.py --experiment=CORe50 --n-seeds=10 --seed=11 --single-epochs --batch=1 --fc-layers=2 --z-dim=200 --fc-units=1024 --lr=0.0001 --c=10 --lambda=10 --omega-max=0.1 --ar1-c=1. --dg-prop=0. --bir-c=0.01 --si-dg-prop=0.6>  the results of BIR is not 60.40(±1.04)（Results provided in Table 2 of the article）.
my results:
the results of all seeds is [0.48647837 0.56542501 0.50891047 0.55057535 0.52782375 0.53963085
0.46688718 0.56751322 0.438259   0.52388038]，The average value is 0.5175383566172511

Hi GMvandeVen, I'm sorry to bother you again, but I still want to ask you what caused the inconsistent results displayed on the Core50 dataset? Is there a problem with my operation mode?

Hi jiaolifengmi, I'm sorry for the slow reply. I still need to look at this in more detail. I already checked whether perhaps I made a typo in the results table, but that doesn't seem to be the case. I'll let you know once I figured it out.

Hi GMvandeVen, Thank you again for your reply and look forward to your results

Hi jiaolifengmi, sorry it took a while to figure it out, but I expect that the difference between your results for BI-R and the results reported in the paper is due to the use of a different version of a pre-trained ResNet18 to extract the CORe50 features.
The pre-trained ResNet18 is selected in this line of code: https://github.com/GMvandeVen/class-incremental-learning/blob/21dd41d31dea1dfafb1e8d90d7f0a1be6b1c6e66/preprocess_core50.py#L217
With the pre-trained ResNet18 from the version of torchvision that I used for the experiments reported in the paper, I consistently get results similar to those reported in the paper. However, if I use the pre-trained ResNet18 from the latest version of torchvision, I indeed get results similar to those you mention. I have experienced before that the performance of generative replay of latent features is quite sensitive to feature extractor that is used (presumably because for some features it is easier to learn a generative model of than for others), although I am a bit surprised that the difference can be this much, especially as both models are pre-trained versions of ResNet18 on ImageNet. At least this variability in the performance of BI-R does not change the interpretation of the  experiments reported in the paper.
Hope this helps!

Hi GMvandeVen, Thank you again for your reply. I'm sorry to bother you again.I don't know whether you have noticed the performance of BIR on CIFAR100 dataset. I ran it according to the provided code, but I didn't get the results provided in the paper. Besides, the features of CIFAR100 are extracted from the provided pre-trained model, but the results are inconsistent. In addition, are there two wrong parameters in this line of code? Or is the setting reversed?(--bir-c/--si-dg-prob)
flow the command.sh <compare_all.py --experiment=CIFAR100 --pre-convE --hidden --iters=5000 --n-seeds=10 --seed=11 --c=1. --lambda=100. --omega-max=0.01 --ar1-c=100 --dg-prop=0.7 --bir-c=0.6 --si-dg-prop=100000000

the results of BIR is not 21.51 (± 0.25)（Results provided in Table 2 of the article）.
my results:
the results of all seeds is [0.1342 0.172 0.1502 0.1511 0.1454 0.1565 0.1451 0.128 0.1045 0.0892]，The average value is 0.13765

Yes, you are right, that is a mistake. The values of --bir-c and --si-dg-prop should be reversed. Sorry about that! I just changed it in the code. Does this fix it?

However, these two parameters do not affect the BIR results on CIFAR100, but affect the BIR+SI results. Even if these two parameters are replaced, the results of BIR+SI on CIFAR100 are not consistent with those in the paper. Is this also because of the pre-trained model?

Sorry, I didn't read your entire question correctly. Hmm, no, if you use the provided pre-trained convolutional layers than those should be the same as I used, so that can't explain such a difference. I'm starting to think that perhaps there is a mistake in the code for BI-R, maybe it got introduced when I cleaned the code. I will try to investigate. Sorry about those issues!

I'm sorry, maybe I didn't make it clear. The problem now is to run BIR with the provided code. Whether it is Core50 or CIFAR100, the results are inconsistent with those provided in the paper. Because of the inconsistency on the Core50 dataset, your explanation is that the version of the pre training model is inconsistent. But since the features of CIFAR100 are extracted from the model provided, it is strange that I also get inconsistent results with those provided in the paper. I hope you can verify the results of BIR algorithm on these two datasets again. Thank you again！

Based on the description of your results, I now expect it is possible there is a mistake in the code for BI-R in this repository. This mistake might indeed also explain the difference on the CORe50 dataset (it is indeed surprising that a different version of ImageNet pre-trained model would make such a difference). Using my own, uncleaned version of this code I get results similar to those reported in the paper, so perhaps a mistake got introduced when cleaning the code. I will try to investigate.
The same mistake would therefore likely not be in the implementation of BI-R in this repository: https://github.com/GMvandeVen/brain-inspired-replay, also as this repository as already been more thoroughly used and tested by others.

Hi GMvandeVen, Sorry to bother you again. I ran the corrected code. On the CIFAR100 dataset, the BIR effect is consistent with that provided in the paper, but the BIR+SI result is not consistent with that provided in the paper. That is, after adding SI, the effect does not improve, and it is consistent with the BIR effect.The results are as follows:
[0.2226 0.2664 0.2435 0.2601 0.2198 0.2104 0.1694 0.1983 0.1963 0.204 ]
0.21908000000000002
栗子
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "GMvandeVen/class-incremental-learning"                                                                                @.>;
发送时间: 2022年11月23日(星期三) 晚上6:38
@.>;
<EMAIL_ADDRESS>主题: Re: [GMvandeVen/class-incremental-learning] Core50 result (Issue #1)
Hi jiaolifengmi, my apologies that it took so long, but I have finally found the error that caused the replay methods to run incorrectly when using the compare_all.py-script. The error was that in this script, all replay methods were erroneously combined with the method "CWR-plus", because the args.cwr_plus flag was never turned off. I have now fixed this by adding this line: https://github.com/GMvandeVen/class-incremental-learning/blob/cc51706a58ea8c671054e68fb4f0d08173603600/compare_all.py#L157
This should fix the inconsistencies you encountered. I did some quick checks and it seems to work fine for me now. Please let me know if you still encounter any issues.
Many thanks for raising this issue!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Hi jiaolifengmi, thank you for pointing that out. You are right that there still seems to be an issue with the BI-R and BI-R+SI results. I really should have tested this script better, my apologies. I have tried to find what is wrong but so far I haven't been able to find it. When cleaning up the code for this repository I must have changed something. If you use the code in this repository, you can get results for BI-R and BI-R+SI on the class-incremental version of Split CIFAR-100 that are consistent with the results reported in the paper (if you use the provided pre-trained convolutional layers, which are the same ones as in this repository). I will keep trying to find out what is wrong with the implementation of BI-R in this repository; I will let you know if I find it. For now, I added a note to the README to explain this issue. Sorry for the inconvenience!


Feature addition request : onMaxDelayReached -  add onMaxDelayReached call back, test and readme notes

please consider adding this feature  - a callback function that is used when MaxDelayReached has been reached
our project is behind a Load balancer with an idle timeout of 2 minutes
we notice that in some cases the SetTimeout inside the slow-down-rate limit is executing after the connection is disconnected.
and there is no way to access the Timer Ref to clear it.
also another issue
From the readme example today the behavior is

// Example

// Given:
{
    delayAfter: 1,
    delayMs: 1000,
    maxDelayMs: 20000,
}

// Results will be:
// 1st request - no delay
// 2nd request - 1000ms delay
// 3rd request - 2000ms delay
// 4th request - 3000ms delay
// ...
// 20th request - 19000ms delay
// 21st request - 20000ms delay
// 22nd request - 20000ms delay
// 23rd request - 20000ms delay
// 24th request - 20000ms delay <-- will not increase past 20000ms
// ...

so after reaching 20000 there is a potential of a large amount of requests
Served together  in case someone will change the idle time at the load balance
if you add the new functionality you can avoid this.
Also it is very useful  if you want to block requests when slow-down-limitter reach maxDelay
I really love your work and don't want to use my own fork.
I didn't see you got here any contribution guide so I just follow linting rules
add implementation:
if (
        options.maxDelayMs &&
        options.onMaxDelayReached &&
        delay === options.maxDelayMs
      ) {
        options.onMaxDelayReached(req, res);
      }

add these 2 specs to the test file

onMaxDelayReached should not be called without maxDelayMs parameter being set
should call on onMaxDelayReached function after delay pass limit max delay

update README file
If my PR needs any changes or updates, I will be happy to work on it.

Note: Another suggestion if you don't want to add this functionality
it will be nice if we can disable the timer in case the request disconnected
today in our project  we solving this issue by wrapping the slowDown middleware
then the blockeTimer function will be executed after the timeout in if the connection is closed we don't executing the next middleware

import slowDown from 'express-slow-down';

function createSlowDownMiddleware(req, res, next) {
    const slowDownHandler = slowDown({...});
    let shouldBlockRequest = false;
    req.on('close', function () {
        shouldBlockRequest = true;
    });
    req.on('end', function () {
        shouldBlockRequest = true;
    });
    const nextMiddleWare = next

    const blockeTimer = (req, res, next) => {
        if (shouldBlockRequest) res.send('diconnected ')
        else nextMiddleWare()
    }
    return slowDownHandler(req, res, blockeTimer)

}

thanks!

@nfriedly we are using slow down with rate-limiter the problem we trying to solve is :
lets say we allow a user to make 100 req per minute,the user can send all 100 requests at the first second and then increase our single store cpu load dramatically. So we want to spread all user request evenly until the point that the requests disconnect by the application load balancer. Now after the user side disconnects the setTimeout still execute the next middleware even though the connection is close we would like to cancel the timer execution if the connection is lost

Ok, yeah, I hadn't thought about that. Yeah, this thing should handle disconnects more gracefully. Do you want to set this aside and open up a new PR that just drops any request that ends/closes during the delay?
Sorry you put in a lot of work here that might not get used, but I think it will make it a better library for everyone.

Yes no problem


right arrow greyed out when page loads in small browser window

I have noticed that when carousel loads in small browser window and I scroll down to see the carousel the the right arrow is greyed out. I have seen this in FF 3.6 and others have seen this in safari 5.
The weird thing is when i then resize the browser window so the carousel is visible without having to scroll, the right arrow magically becomes active. I see this often in FF but not all the time.
anyone else seen this?

Found a hack fix for us. I just commented out line 238 and added
this.buttons(true,false);
Now the right button is never greyed out on opening in small browser windows.
Dont need the resize feature so its ok for us to comment out that resize event handler.


chore(travis): moved ssl decryption to before_deploy phase to allow f…

This project uses semver, please check the scope of this pr:

[x] #patch# - backwards-compatible bug fix
[ ] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

…orks to pass builds.
closes #42

Changes Unknown when pulling b851b40412d2d61885c4b89e54fd888a3d179bd1 on hotfix/deployment-key-decryption into ** on master**.


Unable to select SuiteScripts folder when set up project

Given using NetSuite Tool For WebStorm v1.1.0, When I tried to set up project and I select SuiteScripts Folder as project root folder, then it prompts an error message of "Cannot set directory to SuiteScripts. Please select another folder".

https://github.com/Topher84/NetSuite-Tools-For-WebStorm/issues/16


Delete _redirects

This file isn't used by our current hosting provider.
However we can't actually delete it because this still uses it: https://github.com/reactjs/reactjs.org/blob/a4d4893bd3c56f4f7f821c46ed512eac6c3c21b9/plugins/gatsby-transformer-versions-yaml/gatsby-node.js. Which means our version redirects might be borked now (?)

I see that now we have a redirect file for our current hosting provider. https://github.com/reactjs/reactjs.org/blob/main/vercel.json
We might consider removing the redirects file and the plugin that generates it as well?

The problem is (I think?) that the version-based redirects are broken on the existing site. Can you fix that first?

/version/16.8  https://5d4b5feba32acd0008d0df98--reactjs.netlify.com/  302
/version/16.7  https://5c54aa429e16c80007af3cd2--reactjs.netlify.com/  302
/version/16.6  https://5c11762d4be4d10008916ab1--reactjs.netlify.com/  302
/version/16.5  https://5bcf5863c6aed64970d6de5b--reactjs.netlify.com/  302
/version/16.4  https://5b90c17ac9659241e7f4c938--reactjs.netlify.com  302
/version/16.3  https://5b05c94e0733d530fd1fafe0--reactjs.netlify.com  302
/version/16.2  https://5abc31d8be40f1556f06c4be--reactjs.netlify.com  302
/version/16.1  https://5a1dbcf14c4b93299e65b9a9--reactjs.netlify.com  302
/version/16.0  https://5a046bf5a6188f4b8fa4938a--reactjs.netlify.com  302
/version/15.6  https://react-legacy.netlify.com  302
Tried opening these links and none of the links seem to work except for the last one.

Yes, and the reason they won't work is because the existing script I mentioned writes to _redirects instead of vercel config. we need to fix it to write to the vercel config.

But I don't get it. Seems like we read the netlify URLs from https://github.com/reactjs/reactjs.org/blob/main/content/versions.yml
But these links do not work at all. These links are then added to _redirects in turn

Ohhh I see. You're saying that the links themselves don't work. So it's a separate issue.
Let's say imagine they work. Can we at least get it writing to the correct file?
And then we'll think of how to fix the links.

Do I update the existing gatsby plugin and add script for the beta site too?  Or is it enough if i write it for the beta site?

We might want to merge this as well?

We might want to get working links for older react versions: https://github.com/reactjs/reactjs.org/issues/4306

Is there any other way to get access to old documentation other than the broken netlify instances?

Is there any other way to get access to old documentation other than the broken netlify instances?

Nope, AFAIK there is no other way until we find the right URL. (Or maybe we might want to revisit old commits in the repo and try local build for that version :( )

Ah dang! Until then, I suppose users like me can rely on a web archive such as good old Way Back Machine 😅


Are there any other hashes we should be benchmarking against?

I used the ones I could find that were supposed to be speed-oriented.  But I may have missed some.
- Casey

Highway Hash and Metro Hash come to mind.

Metro hash is already in the benchmark set.  Highway Hash was in the set, but it was so slow I had to pull it - it was an order of magnitude slower than all the other hashes in the set, and was dominating the amount of time it took to run the benchmark series :(
I will look at adding FarmHash and CLHash.
- Casey

I just added Meow to the devel branch of t1ha's internal benchmark.
Yet only MeowHash1() with -maes GCC's flag.
Preparing to benchmarking...
 - running on CPU#3
 - use RDPMC_40000001 as clock source for benchmarking
 - assume it cheap and stable
 - measure granularity and overhead: 53 cycles, 0.0188679 iteration/cycle

Bench for tiny keys (7 bytes):
t1ha2_atonce            :     17.300 cycle/hash,  2.471 cycle/byte,  0.405 byte/cycle,  1.214 Gb/s @3GHz
t1ha0                   :     16.125 cycle/hash,  2.304 cycle/byte,  0.434 byte/cycle,  1.302 Gb/s @3GHz
meow1_aes               :     96.312 cycle/hash, 13.759 cycle/byte,  0.073 byte/cycle,  0.218 Gb/s @3GHz
xxhash64                :     26.219 cycle/hash,  3.746 cycle/byte,  0.267 byte/cycle,  0.801 Gb/s @3GHz
StadtX                  :     19.302 cycle/hash,  2.757 cycle/byte,  0.363 byte/cycle,  1.088 Gb/s @3GHz
HighwayHash64_avx2      :     56.750 cycle/hash,  8.107 cycle/byte,  0.123 byte/cycle,  0.370 Gb/s @3GHz

Bench for large keys (16384 bytes):
t1ha2_atonce            :   3547.000 cycle/hash,  0.216 cycle/byte,  4.619 byte/cycle, 13.857 Gb/s @3GHz
t1ha0                   :   1308.000 cycle/hash,  0.080 cycle/byte, 12.526 byte/cycle, 37.578 Gb/s @3GHz
meow1_aes               :   1139.000 cycle/hash,  0.070 cycle/byte, 14.385 byte/cycle, 43.154 Gb/s @3GHz
xxhash64                :   4119.000 cycle/hash,  0.251 cycle/byte,  3.978 byte/cycle, 11.933 Gb/s @3GHz
StadtX                  :   3670.000 cycle/hash,  0.224 cycle/byte,  4.464 byte/cycle, 13.393 Gb/s @3GHz
HighwayHash64_avx2      :   4405.000 cycle/hash,  0.269 cycle/byte,  3.719 byte/cycle, 11.158 Gb/s @3GHz

Highway Hash was in the set, but it was so slow I had to pull it

That's surprising, sounds like it might not be compiled with -mavx2 - should be around 0.25 cpb (0.269 in the above results).

Highway Hash was in the set, but it was so slow I had to pull it

That's surprising, sounds like it might not be compiled with -mavx2 - should be around 0.25 cpb (0.269 in the above results).

In the my benchmark -mavx2 for HWH is here.

That is correct, it would not have been compiled with AVX2.   At the moment we generally don't allow anything past AVX.  Technically we should be benchmarking only up through SSE AES-NI, since that is all that Meow requires.  And if Highway Hash only gets in the 4bytes/cycle even when extended to AVX2, I don't think it's appropriate to expand the qualifications for being in the benchmarking to AVX2 just for a hash that isn't particularly fast... if it were actually going to be a leading hash it might make sense, but requiring AVX2 for a slow hash doesn't seem interesting?
- Casey

Well, if it's unlikely that AES-NI would exist without AVX-2, then I'd be OK raising the benchmark to AVX2... the goal is just to compare apples to apples :)
- Casey

I added Highway Hash back in, and it is still excruciatingly slow even with /arch:AVX2, so I think the problem is maybe I have only the C implementation (there are no intrinsics anywhere in it :( )  I will look for an optimized version.
- Casey

Grab the official C++ code from https://github.com/google/highwayhash

The C directory is a reference implementation with no vector instructions.  You need the highwayhash directory with all the C++ code.  The README lays out what you need to do.  Basically, make, then use the header you want and link against libhighwayhash.

That's not going to work, then.  Every other hash we use is ~4 files, tops.  If someone wants to make a simple h/cpp pair of it, I'll add it to the benchmark, otherwise it's a no-go.  But I'm not going to quintuple (or more??) the size of the Meow benchmark build just for one (not particularly fast) hash.
- Casey

Fair enough.

Besides the aforementioned Highway Hash problem, v0.3 will come with the other hashes requested.  I should note, however, that although I included CLHash, it really should be disqualified, because it cannot hash things with a seed at reasonable speeds.  Each time you change the seed, you must go through a lengthy separate call that generates a table.  So its performance is apples to oranges as opposed to all the other hashes in the suite, which are expected to take a different seed on every call.
- Casey


typo: refered -> referred

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/Excel.WorkbookConnection.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add arrows to Profile Doing rows

Closes #659 by adding last remaining item, the arrows.
Running into issues vertically centering the arrow without setting the row height. It's a little bit hacked right now to display close enough to center, but a few pixels off :confused:

Refs #800, https://github.com/facebook/react-native/issues/3381, https://github.com/facebook/react-native/issues/3412, https://github.com/facebook/react-native/issues/1234


management namespace is not searched

https://github.com/SAP/sap-btp-service-operator/blob/a3292fe5620f6509f58de7c599fe8b53a3dc91c8/internal/secrets/resolver.go#L46
If secret is not found in the resource namespace then it should be searched in management namespace. However, the code still searched in the resource namespace (as per the written code).
I think it needs a fix.

it actually by design,
There are 3 levels let's say the resource namespace is 'mynamespace'
First: Operator tries to find the 'sap-btp-service-operator' secret in the same namespace as the resource - 'mynamespace'
Second: Operator tries to find the secret in managed namespace with namespace prefix 'mynamespace-sap-btp-service-operator'
Third: Operator tries to find central cluster secret 'sap-btp-service-operator' in managed namespace
The option you mentioned is when you want central namespace to manage all tenants rather than distribute secrets a cross namespaces

Thank you! Now I understand the flow better.
It would be good idea to change the log for second scenario
from:
sr.Log.Info("Searching for namespace secret in management namespace", "namespace", namespace, "managementNamespace", sr.ManagementNamespace, "name", name)
to:
sr.Log.Info("Searching for namespace secret in management namespace", "managementNamespace", sr.ManagementNamespace, "name", fmt.Sprintf("%s-%s", namespace, name))


Dart analyzer doesn't consider RHS of ?? operator

The following code appears to pass the analyzer:
class A {
  foo() {}
}

class B {}

void f() {
  A a = new A();
  B b = new B();

  A x = a ?? b;
  x.foo();
}

This is unfortunate, but I believe that this is the correct behavior. The type of a ?? b is the least-upper-bound of the type of a and the type of b, which in this case if Object. The assignment is therefore an implicit downcast, and there is no warning for implicit downcasts.

Union types wouldn't help with your but would help in this even more surprising example which also currently passes in strong mode today.
class A {
  foo() {}
}

class B {}

class C {}

void f() {
  B b = new B();
  C c = new C();

  A x = b ?? c;
  x.foo();
}

There is an analyzer flag: --no-implicit-casts
With that on, you'd get:
[error] A value of type 'Object' can't be assigned to a variable of type 'A'.

As @vsmenon mentions, --no-implicit-casts will catch this.
More generally, I have specified inference for this construct for Dart 2.0 in a way that will make at least examples like this into errors, by using the context type (here A) as the type of the ?? expression rather than the LUB of a and b.  There is work to be done to implement this though.

This is not a static error in either CFE or analyzer. This can hit a runtime exception, but it would be breaking to make it a static error now since it's possible to run code that avoid this path.


List Trial Summaries GET call

How should the List Trial Summaries GET call be specified? This part is missing in the specification, if I match it with the Program List GET call (/brapi/v1/programs) I assume it to look something like this:
/brapi/v1/trials?programDbId={programDbId}&locationDbId={locationDbId}&pageSize={pageSize}&page={page}&active={active}&sortBy={sortBy}&sortOrder={sortOrder}
Please also add this to specification when correct as well as to the apiary.
Thanks in advance,

I would argue that we could also provide the observationVariableName right away in addition to the DbId, because that would have to be looked up in almost any case.


Connect wallet should ask to switch to the correct network

When connecting Metamask, the website should ask it to switch to the correct network (Mandala on staging, Karura on production)
It seems this is either not implemented, or bugging out right now (according to Julio when he tested it)

@flaviocastro do you know anything about this?

This was not implemented, we need the config for both chains, I will be adding configs based these docs


A new rock paper scissor game

@ron2111   sir ,
I am a collage student and I am new to open sourcing please help me add hacktoberfest to my  forte .
please accept my pull request as it will make a great difference for me .
Thank you

Thank you maintainers


Duplex Analysis: Add to test.galaxyproject.org.

These are a soon-to-be-published set of tools from Irene Tiemann-Boege's group at JKU.
They can be used to check the quality of duplex sequencing runs and find variants with more sensitivity than the standard analysis.

Oops, realized I used the wrong set of tools by the wrong owners. I'm re-trying with #89.


Add support for the typeid operator

This pull request adds the C++ typeid(...) operator to Cython, available by cimporting:
from cython.operator cimport typeid
cimport libcpp.typeinfo

(the operator requires the libcpp.typeinfo.type_info type and you cannot use it without the <typeinfo> header included)
std::bad_typeid exceptions thrown by typeid() are caught.
Relevant documentation and a test has also been added.

The temp variable for the typeid node is now much cleaner! I ended up using is_temp rather than allocate_temp() as well.


OOP school library: refactor your code

OOP school library: refactor your code
On this branch we:

Divide all the methods of the app.rb file into smaller modules.
Create modules to handle book, person, and rental operations.
Include these modules in the app.rb file.
Refactor some parts of the code for best practices.

@mckent05 Thanks for pointing that out. It seems like I had a network problem but now it's fine and I've pushed the changes.


ClassCastException when have specify UDF

Describe the bug
I met this exception when my program have specify UDF
java.lang.ClassCastException: cannot assign instance of java.lang.invoke.SerializedLambda to field org.apache.spark.sql.catalyst.expressions.ScalaUDF.f of type scala.Function1 in instance of org.apache.spark.sql.catalyst.expressions.ScalaUDF
at java.io.ObjectStreamClass$FieldReflector.setObjFieldValues(ObjectStreamClass.java:2287)
at java.io.ObjectStreamClass.setObjFieldValues(ObjectStreamClass.java:1417)
at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:2293)
at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:2211)
at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:2069)
at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1573)
at java.io.ObjectInputStream.readObject(ObjectInputStream.java:431)
at org.apache.spark.sql.blaze.NativeConverters$.$anonfun$deserializeExpression$4(NativeConverters.scala:1095)
at org.apache.spark.util.Utils$.tryWithResource(Utils.scala:2764)
at org.apache.spark.sql.blaze.NativeConverters$.$anonfun$deserializeExpression$2(NativeConverters.scala:1094)
at org.apache.spark.util.Utils$.tryWithResource(Utils.scala:2764)
at org.apache.spark.sql.blaze.NativeConverters$.deserializeExpression(NativeConverters.scala:1093)
at org.apache.spark.sql.blaze.SparkUDFWrapperContext.(SparkUDFWrapperContext.scala:42)
To Reproduce
Steps to reproduce the behavior:

refer delta 2.3.0
use delta format to load data, delta is base on parquet

Expected behavior
it should works whatever UDF
Desktop (please complete the following information):

OS: Centos7
Version compile base on latest code

I found that SparkUDFWrapper comes from Project, so that it worked when I closed convert Project by set parameter spark.blaze.enable.project=false
21/01/2024 21:38:12 [INFO] Blaze -   execution plan:
ShuffleWriterExec: partitioning=Hash([ScalarFunctionExpr { fun: "", name: "Coalesce", args: [Column { name: "#187", index: 15 }, Column { name: "#203", index: 16 }], return_type: Utf8 }], 50)
ProjectExec [#152@0 AS #152, (#153@1).[0] AS #299, (#153@1).[1] AS #300, (#153@1).[2] AS #301, (#153@1).[3] AS #302, (#153@1).[4] AS #303, (#153@1).[6] AS #304, (#153@1).[7] AS #305, #154@2 AS #154, #155@3 AS #155, #156@4 AS #156, #157@5 AS #157, #158@6 AS #158, #166@7 AS #166, (#153@1).[5] AS #176, CASE WHEN (#153@1).[0] IS NOT NULL THEN SparkUDFWrapper END AS #187, CASE WHEN (#154@2).[0] IS NOT NULL THEN SparkUDFWrapper END AS #203]
ProjectExec [#152@0 AS #152, #153@1 AS #153, #154@2 AS #154, #155@3 AS #155, #156@4 AS #156, #157@5 AS #157, #158@6 AS #158, SparkUDFWrapper AS #166]
FFIReader

SparkUDFWrapperContext is constructed from executor side (through native code and jni). it deserializes the UDF expression which is serialized in driver side. the exception happens in deserialization.
the expression should have implemented Serializable but i have no idea why it deserialized with exceptions.


Is it possible to actual run the docker steps?

Building docker image for runtime null
[Pipeline] sh
[job] Running shell script
+ docker build -t tests:null -f Dockerfile.tests .
<EMAIL_ADDRESS>2<EMAIL_ADDRESS>docker: not found
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Tests Execution)
...
...
...
ERROR: script returned exit code 127
Finished: FAILURE

Could you please provide the Jenkinsfile you're trying to run here ?

@ndeloof Mainly using a Pipeline syntax... We have a Jenkins instance, with Blueocean, deployed in a Kubernetes cluster using docker-in-docker.
Stages using Docker
    stage('Build Test Image') {
      steps {
        script {
          currentBuild.displayName = "Test Image"
          currentBuild.description = "Building the docker image for running the test cases"
        }
        echo "Building docker image for tests from build stage ${env.GIT_COMMIT}"
        sh "docker build -t tests:${env.GIT_COMMIT} -f ${paas.build.docker.dockerfile.runtime} --target builder ."
      }
    }

    stage('Tests Execution') {
      parallel {
        stage('Execute Unit Tests') {
          steps {
            script {
              currentBuild.displayName = "Unit Tests"
              currentBuild.description = "Running the unit tests cases"
            }
            sh "docker run --name tests-${env.GIT_COMMIT} tests:${env.GIT_COMMIT}"
            sh "docker start tests-${env.GIT_COMMIT}"
            sh "docker cp tests-${env.GIT_COMMIT}:/opt/build/target ."

            // https://jenkins.io/doc/book/pipeline/jenkinsfile/#advanced-scripted-pipeline#using-multiple-agents
            stash includes: '**/target/*', name: 'build'
          }
        }
        stage('Execute Integration Tests') {
          when {
            expression { paas.idpsIsEnabled == true }
          }
          steps {
            script {
              currentBuild.displayName = "Integration Tests"
              currentBuild.description = "Running the Integration tests cases"
            }
            sh "docker run --rm tests:${env.GIT_COMMIT} mvn -s settings.xml -Dtest=\"*IT,*IntegrationTest\" -P jacoco test"
          }
        }
      }
    }

The error can also be reproduced with a minimal Jenkinsfile such as this:
node {
    stage('docker') {
        docker.image('hello-world').run()
    }
}

Could we somehow mount the docker socket and mount or install the client binary into jenkinsfile-runner?
I did this for a shared library, maybe this could be helpful.
The client binary can be downloaded from here: https://download.docker.com/linux/static/stable/x86_64/

@marcellodesales afaict your main issue is env.GIT_COMMIT is not set when running pipeline with jenkinsfile-runner - which makes sense imho : you might have uncommitted local changes. Having support for environment variables could help as a workaround
@schnatterer your issue seems unrelated to initial reported one. IIUC you miss docker CLI in your execution context. It you suggest docker-pipeline plugin to install it, please report this as a RFE for this plugin.

@ndeloof The initial issues also states docker: not found so I reckoned the missing docker executable would be the main problem. If we use docker directly via sh docker ...  (original issue) or via the docker step provided by the docker pipeline plugin shouldn't matter.
It would be helpful if we could run docker steps in jenkinsfile-runner.

I can't see any reason the jenkinsfile-runner could not run docker steps, it just need docker command line available in the current node, i.e local machine running jenkinsfile-runner.
Based on your comment :

Could we somehow mount the docker socket and mount or install the client binary into jenkinsfile-runner?

it sounds like you use jenkinsfile-runner from a docker image, not running directly as a CLI tool. Doing so you indeed need to customize the docker image to have docker CLI installed and grant access to docker infrastructure.

@ndeloof @schnatterer I actually got it to work following the suggestions from https://forums.docker.com/t/using-docker-in-a-dockerized-jenkins-container/322. I could get it to work to just run a container with the following volumes:

Mount the /var/run/docker.sock
Mount the docker command

Solution

I built the image locally and tagged as marcellodesales/jenkinsfile-runner
Running a container and mounting the volumes described

This is actually an acceptable solution for my case using Docker for Mac to support development of the Pipeline.
$ docker run -v $(pwd):/workspace  -v /var/run/docker.sock:/var/run/docker.sock -v $(which docker):$(which docker) marcellodesales/jenkinsfile-runner
Started
Running in Durability level: PERFORMANCE_OPTIMIZED
[
...
...
[Pipeline] [Validate Test] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Build Test Image)
[Pipeline] script
[Pipeline] {
[Pipeline] }
[Pipeline] // script
[Pipeline] echo
Building docker image for tests from build stage null
[Pipeline] sh
[job] Running shell script
+ docker build -t tests:null -f Dockerfile --target builder .
Sending build context to Docker daemon  13.75MB
Step 1/9 : FROM maven:3.2.5-jdk-8 as builder
 ---> 95dd59c15f5d
Step 2/9 : MAINTAINER<EMAIL_ADDRESS> ---> Using cache
 ---> e4edaeb48381
Step 3/9 : ADD ./pom.xml /opt/build/pom.xml
 ---> Using cache
 ---> 2ca95e0b276e
Step 4/9 : ADD ./settings.xml /opt/build/settings.xml
 ---> Using cache
 ---> 1c52ecafca2b
Step 5/9 : WORKDIR  /opt/build/
 ---> Using cache
 ---> e2f5d1a6467f
Step 6/9 : RUN mvn -s settings.xml -B -e -C -T 1C org.apache.maven.plugins:maven-dependency-plugin:3.0.2:go-offline
 ---> Using cache
 ---> 9212f3bd2e5b
Step 7/9 : ADD ./src /opt/build/src
 ---> f7e2cc9f9aa6
Step 8/9 : RUN mvn -s settings.xml install -P embedded -Dmaven.test.skip=true -B -e -o -T 1C verify
 ---> Running in 52b96eb70b06
[INFO] Error stacktraces are turned on.
[INFO] Scanning for projects...
[INFO]
[INFO] Using the MultiThreadedBuilder implementation with a thread count of 4
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building spring-cloud-config-server 1.1.6-SNAPSHOT
[INFO] ---------------------------------------------------
...
...
...
[INFO] --- maven-failsafe-plugin:2.20.1:integration-test (integration-test) @ spring-cloud-config-server ---
[INFO] Tests are skipped.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27.438 s (Wall Clock)
[INFO] Finished at: 2018-04-23T21:02:49+00:00
[INFO] Final Memory: 46M/216M
[INFO] ------------------------------------------------------------------------
Removing intermediate container 52b96eb70b06
 ---> bbefce46d3bd
Step 9/9 : CMD mvn -s settings.xml -Dtest="!*IT,!*IntegrationTest" -P jacoco test
 ---> Running in aa7ab08da632
Removing intermediate container aa7ab08da632
 ---> a65a5a81ee21
Successfully built a65a5a81ee21
Successfully tagged tests:null
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Tests Execution)
[Pipeline] parallel
[Pipeline] [Execute Unit Tests] { (Branch: Execute Unit Tests)
[Pipeline] [Execute Integration Tests] { (Branch: Execute Integration Tests)
[Pipeline] [Execute Unit Tests] stage


Upgrade postgres databases to 14

Context
To upgrade the postgres database to version 14
Changes proposed in this pull request

Introduced variable to set the version number
Set the default to 11

Guidance to review

make qa_aks deploy-plan PASSCODE=1234

Link to Trello card
https://trello.com/c/JH27e84R/275-upgrade-postgres-databases-to-14
Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] Required environment variables have been updated added to the Azure KeyVault

 Upgrade postgres databases to 14


Commented out code in View/Inventory

Tons of commented out code here: https://github.com/HydrologicEngineeringCenter/HEC-FDA/tree/main/View/Inventory/OccupancyTypes
How does this overlap with the OccupancyTypes project? Can one of these be deleted entirely?
Commented out code in nearly every code behind file.

The occtypes is still a bit of a mess. I am going to clean it up under the remaining maintenance money. I have been afraid to delete the commented out code because i am not sure what will be helpful to look at.

I ended up deleting the OccupancyTypes project and cleaning up all the commented out code.


Remove root lerna.json

Description
Remove lerna.json for the client release group.
This release group no longer uses lerna, so this file should be unneeded.
TODO: update build tools before merging this so version bump still works.
Reviewer Guidance
The review process is outlined on this wiki page.

For future reference I'll add that one of the reasons we need the file today is that we sometimes use Lerna to run commands across the repo with filters (e.g. skip private: true packages) that pnpm exec/run doesn't support out of the box today as far as I can tell.


Moved exercises under exercises/

Closes #99

This will fail until the configlet is updated. I'll re-trigger Travis when that is ready.

Should be good to go now.

Travis is happy and there isn't much to review. Merging...

sweet!


Change calendar drag increments to 15 mins

Originally created by Tom Smyth at 2017-06-07 19:25, migrated from redmine-#6594

Estimate set to 0.30 h

By Tom Smyth at 2017-06-09 11:31

Status changed from New to Cancelled

Turns out doing this makes the calendar way too tall. Would take some work to
make it work more smoothly I think. Not a priority for now.
By Tom Smyth at 2017-07-06 16:28

Version deleted ( ~~ 4.2~~ )

By Tom Smyth at 2017-07-06 16:28


Did you use Kernel Memory (KM) in your tests?

@hkchengrex Did you use Kernel Memory (KM) in your tests? Which line is it?

No. And thus it's not in the code.

No. And thus it's not in the code.


[BACKLOG-14619] Fix help URLs

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/kettle-job-entries.xml
  engine/src/kettle-steps.xml

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet

Branch Change: -.53%:small_red_triangle_down:
Complexity Change: -.56%:small_red_triangle_down:
Instruction Change: -.07%:small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1.00%:small_red_triangle_down:
Complexity Change: -1.41%:small_red_triangle_down:
Instruction Change: -.30%:small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -.66%:small_red_triangle_down:
Complexity Change: -.93%:small_red_triangle_down:
Instruction Change: -.13%:small_red_triangle_down:

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Instruction Change:  + .09%

org.pentaho.di.trans.steps.dbproc.DBProcMeta

Instruction Change:  + .11%

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change:  + .31%
Instruction Change:  + .06%
Line Change: -.23%:small_red_triangle_down:
Method Change: -1.02%:small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change:  + 1.04%
Complexity Change:  + 1.05%
Instruction Change:  + .14%
Line Change:  + .37%

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2.00%:small_red_triangle_down:
Complexity Change: -1.89%:small_red_triangle_down:
Instruction Change: -.17%:small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change:  + 1.18%
Complexity Change:  + 1.35%

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change:  + .10%

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change: -.18%:small_red_triangle_down:

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -.53%:small_red_triangle_down:

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.79%:small_red_triangle_down:
Complexity Change: -1.19%:small_red_triangle_down:
Instruction Change: -.07%:small_red_triangle_down:

@AlexanderBuloichik for all help URL's that point to a "versioned" mindtouch link, you can just use the portion of the URL that identifies it, kettle will add the base url to that when we call getDocUrl.  The property that method uses needs to be updated to 7.1 if it hasn't already.

@mdamour1976 okay, will try

@mdamour1976 I added ability to use doc url without prefix in the xml files, and replaced "https://help.pentaho.com/Documentation/7.0/" prefix into "https://help.pentaho.com/Documentation/7.1/"

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f core/build.xml clean-all resolve jacoco && ant -f core/build.xml checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  core/src/org/pentaho/di/core/messages/messages_en_US.properties
  core/src/org/pentaho/di/core/plugins/Plugin.java
  engine/src/kettle-job-entries.xml
  engine/src/kettle-steps.xml

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.Const

Branch Change:  + .20%
Complexity Change:  + .54%
Instruction Change:  + .38%
Line Change:  + .53%
Method Change:  + 1.69%

org.pentaho.di.core.plugins.Plugin

Instruction Change:  + .15%

org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory

Branch Change: -7.14%:small_red_triangle_down:
Complexity Change: -7.69%:small_red_triangle_down:

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change:  + .39%
Complexity Change:  + .51%
Instruction Change:  + .08%

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -1.01%:small_red_triangle_down:
Complexity Change: -1.06%:small_red_triangle_down:
Instruction Change: -.17%:small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change:  + 1.00%
Complexity Change:  + 1.41%
Instruction Change:  + .30%

org.pentaho.di.trans.step.StepMeta

Instruction Change: -.19%:small_red_triangle_down:
Line Change: -.26%:small_red_triangle_down:

org.pentaho.di.trans.steps.calculator.CalculatorMetaFunction

Branch Change:  + 8.70%
Complexity Change:  + 3.08%
Instruction Change:  + .75%
Line Change:  + .89%

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1.04%:small_red_triangle_down:
Complexity Change: -1.05%:small_red_triangle_down:
Instruction Change: -.14%:small_red_triangle_down:
Line Change: -.37%:small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -.07%:small_red_triangle_down:

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change:  + .18%

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -.91%:small_red_triangle_down:
Complexity Change: -.82%:small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change:  + .53%

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.79%:small_red_triangle_down:
Complexity Change: -1.19%:small_red_triangle_down:
Instruction Change: -.07%:small_red_triangle_down:

License header violations

:heavy_exclamation_mark: Copyright year is not the current year on core/src/org/pentaho/di/core/plugins/Plugin.java. Found 2013. Was expecting 2017

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f core/build.xml clean-all resolve jacoco && ant -f core/build.xml checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -f engine/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  core/src/org/pentaho/di/core/messages/messages_en_US.properties
  core/src/org/pentaho/di/core/plugins/Plugin.java
  engine/src/kettle-job-entries.xml
  engine/src/kettle-steps.xml

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.Const

Branch Change:  + .20%
Complexity Change:  + .54%
Instruction Change:  + .38%
Line Change:  + .53%
Method Change:  + 1.69%

org.pentaho.di.core.plugins.Plugin

Instruction Change:  + .15%

org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory

Branch Change:  + 7.14%
Complexity Change:  + 7.69%

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change:  + .39%
Complexity Change:  + .51%
Instruction Change:  + .08%

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.28%:small_red_triangle_down:
Line Change: -3.87%:small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Instruction Change:  + .19%
Line Change:  + .26%

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -.11%:small_red_triangle_down:

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change: -.05%:small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -.31%:small_red_triangle_down:
Instruction Change: -.06%:small_red_triangle_down:
Line Change:  + .23%
Method Change:  + 1.02%

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1.04%:small_red_triangle_down:
Complexity Change: -1.05%:small_red_triangle_down:
Instruction Change: -.14%:small_red_triangle_down:
Line Change: -.37%:small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2.00%:small_red_triangle_down:
Complexity Change: -1.89%:small_red_triangle_down:
Instruction Change: -.17%:small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change: -.05%:small_red_triangle_down:

org.pentaho.di.trans.steps.ldifinput.LDIFInputField

Branch Change:  + 4.17%
Complexity Change:  + 2.00%
Instruction Change:  + .38%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change:  + 3.53%
Complexity Change:  + 4.05%

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Instruction Change:  + .08%

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change:  + .08%

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change:  + .18%


New API Proposal - Telco Index

Telco Index API proposal from GSMA OGW Drop 4:
(part of OGW DROP4) The service provides a scoring related to the user's credit profile, calculated based on the information that the operator has about the owner of the associated line. Certain applications or services, like bank accounts, insurers or credit agencies, employ complex risk analysis for their operation. Telcos can calculate a credit scoring for those applications employing owned useful information, including profiling of young people or informal workers, people who do not have much commercial history or market information about who have consumption and credit potential. The service will consider as input a user identifier, like MSISDN, and the document ID or identity Card number, while the output will be the calculated credit scoring for such user.
Related to #42
Supporting material API-Overview-TelcoScore.pptx

@jgarciahospital What are your thoughts on how we standardise the algorithm or inputs into the algorithm that each MNO uses?
I can see alignment on an API signature being straightforward, but Im thinking how we do make sure a '3' on a scale of 1-5 for example, means the same thing between MNOs - What are your thoughts and experience in this area?

As per TSC decision for this proposal:

Start this API in sandbox (repo) and then work on the name
Jorge Garcia Hospital propose first to ask to supporter companies if OK to start with this name.
Axel Nennker explained that for DT the term risk indicator was used. The use of score term is very risky (from regulation). We must be clear that it will not be used to discriminate people. If it based on IA model, the model must be shared to allow people to challenge it.

Repo will be created when API name is clarified, teams are encourage to confirm soon the final proposal @NoelWirzius @jgarciahospital @KevScarr  please provide list of maintainer/codeowners (name, company, github user)

Repository created:  https://github.com/camaraproject/CustomerInsights, please see next there in the issues


Add essential functionalities to enable gdo modality analysis

To enable gdo modality analysis from single h5mu or from multi sample integrated h5mu, the analyst requires more data to avoid cumbersome and error-prone post-processing within multi-sample context.
Therefore I suggest the following task to complete:

[x] feature_type must be gdo following best practices (https://github.com/openpipelines-bio/openpipeline/commit/b0e21b3b4715267055b2defbb147c7a9c5d0a7bd)

[ ] bugfix var genome column name to gdo modality. Currently column name is present, but does not populate with genome string).

[ ] add assignment of guides to cells to gdo modality obms layer of single sample
concept

index
gRNA-1
gRNA-2
...
gRNA-n

cell-index-1
counts
counts
...
counts

cell-index-2
counts
counts
...
counts

...
...
...
...
...

cell-index-n
counts
counts
...
counts

idea
df = sc.get.obs_df(       mdata.mod['CRISPR Guide Capture'],       keys = guides   )

[ ] add guide-cell transduction categorization functionality to gdo modality obs layer of single sample

[ ] #492

[ ] enable merge operation of gdo modality across multi samples of single sample

[ ] #491

[ ] #493

Hi @MatthiasBeyens, regarding 'add assignment of guides to cells to gdo modality obms layer of single sample' and 'add guide-cell transduction categorization functionality to gdo modality obs layer of single sample', could you explain this a bit more? Is there a tool or some code that provides this functionality?
Also, combining multiple samples is supported using the concat component. Could you explain if something is missing? If so, could you describe the missing feature please?

Hi @DriesSchaumont you can ignore these open feature requests, since they are tailored to our internal projects. Once the code has proven its use, we might publish and open source relevant code, and push to openpipeline accordingly.
I can work with the current gdo modality openpipeline implementation. When do you expect to merge and/or release the new features?
Much appreciate your work!

PR https://github.com/openpipelines-bio/openpipeline/pull/494 has been merged. The features are schedules for release in 0.10


Laboratory work #1, Egorova Anastasia - 19FPL2

The deadline is not that far - consider pushing changes so that we can review them.

Open another PR with lab_2.


⭐ Feature: Implement Reply functionality in projects comment section

Is your feature request related to a problem? Please describe
Currently there is no functionality of replying in projects comment section

Describe the solution you'd like
I think there should be reply button beneath each comment and users can click it to reply to a specific user in a similar comment like section.
Describe alternatives you've considered
No response
Additional context
No response
Are you working on this?
Yes

@theslowdeveloper hey can I work on this?

cc @tachyons @vedant-jain03

Can I work on this issue

is this issue is still open.. if then can you please give me a chance to resolve it .. please

Assign it to me i will work on it.

Hello, is this issue verified. If yes I would like to work on it.


Support basic covers with open/close/stop services

Description:
Support covers which do not support the set_cover_position service. This allows covers which only support open_cover and close_cover (and optionally stop_cover) to be used in Homekit.
In the basic home app, when touching a tile this behaves as expected, touching an open cover closes it, and vice versa, however in order to handle setting an exact position, I had to make some assumptions:

A user sets position > 70: Open cover
A user sets position < 30: Close cover
A user sets position anywhere else: Stop cover (provided the cover supports it).

Related issue:

A potential workaround for #13676

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):
homekit:
cover:
  - platform: mqtt
    name: blindkit_nick_front
    command_topic: /things/blindkit/send_code
    availability_topic: /things/blindkit/status
    qos: 1
    payload_open: 100,0,OPEN
    payload_close: 100,0,CLOSE
    payload_stop: 100,0,STOP

TODO

[ ] Write tests

I am raising this as more of a WIP to get thoughts before committing to spending time to write tests against the implementation.
Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] ~New dependencies have been added to the REQUIREMENTS variable (example).~
[ ] ~New dependencies are only imported inside functions that use them (example).~
[ ] ~New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.~
[ ] ~New files were added to .coveragerc.~

~If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.~

Hi @nickw444,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Changes up @cdce8p

Changes up

Documentation added to https://github.com/home-assistant/home-assistant.github.io/pull/5203


net/tcp: use independent work to free the conn instance

Summary
net/tcp: use independent work to free the conn instance
I noticed that the conn instance will leak during stress test,
The close work queued from tcp_close_eventhandler() will be canceled
by tcp_timer() immediately:

Breakpoint 1, tcp_close_eventhandler (dev=0x565cd338 <up_irq_restore+108>, pvpriv=0x5655e6ff <getpid+12>, flags=0) at tcp/tcp_close.c:71
(gdb) bt
| #0  tcp_close_eventhandler (dev=0x565cd338 <up_irq_restore+108>, pvpriv=0x5655e6ff <getpid+12>, flags=0) at tcp/tcp_close.c:71
| #1  0x5658bf1e in devif_conn_event (dev=0x5660bd80 <g_sim_dev>, flags=512, list=0x5660d558 <g_cbprealloc+312>) at devif/devif_callback.c:508
| #2  0x5658a219 in tcp_callback (dev=0x5660bd80 <g_sim_dev>, conn=0x5660c4a0 <g_tcp_connections>, flags=512) at tcp/tcp_callback.c:167
| #3  0x56589253 in tcp_timer (dev=0x5660bd80 <g_sim_dev>, conn=0x5660c4a0 <g_tcp_connections>) at tcp/tcp_timer.c:378
| #4  0x5658dd47 in tcp_poll (dev=0x5660bd80 <g_sim_dev>, conn=0x5660c4a0 <g_tcp_connections>) at tcp/tcp_devpoll.c:95
| #5  0x5658b95f in devif_poll_tcp_connections (dev=0x5660bd80 <g_sim_dev>, callback=0x565770f2 <netdriver_txpoll>) at devif/devif_poll.c:601
| #6  0x5658b9ea in devif_poll (dev=0x5660bd80 <g_sim_dev>, callback=0x565770f2 <netdriver_txpoll>) at devif/devif_poll.c:722
| #7  0x56577230 in netdriver_txavail_work (arg=0x5660bd80 <g_sim_dev>) at sim/up_netdriver.c:308
| #8  0x5655999e in work_thread (argc=2, argv=0xf3db5dd0) at wqueue/kwork_thread.c:178
| #9  0x5655983f in nxtask_start () at task/task_start.c:129

(gdb) c
Continuing.
Breakpoint 2, tcp_update_timer (conn=0x5660c4a0 <g_tcp_connections>) at tcp/tcp_timer.c:178
(gdb) bt
| #0  tcp_update_timer (conn=0x5660c4a0 <g_tcp_connections>) at tcp/tcp_timer.c:178
| #1  0x5658952a in tcp_timer (dev=0x5660bd80 <g_sim_dev>, conn=0x5660c4a0 <g_tcp_connections>) at tcp/tcp_timer.c:708
| #2  0x5658dd47 in tcp_poll (dev=0x5660bd80 <g_sim_dev>, conn=0x5660c4a0 <g_tcp_connections>) at tcp/tcp_devpoll.c:95
| #3  0x5658b95f in devif_poll_tcp_connections (dev=0x5660bd80 <g_sim_dev>, callback=0x565770f2 <netdriver_txpoll>) at devif/devif_poll.c:601
| #4  0x5658b9ea in devif_poll (dev=0x5660bd80 <g_sim_dev>, callback=0x565770f2 <netdriver_txpoll>) at devif/devif_poll.c:722
| #5  0x56577230 in netdriver_txavail_work (arg=0x5660bd80 <g_sim_dev>) at sim/up_netdriver.c:308
| #6  0x5655999e in work_thread (argc=2, argv=0xf3db5dd0) at wqueue/kwork_thread.c:178
| #7  0x5655983f in nxtask_start () at task/task_start.c:129

Since a separate work will add 24 bytes to each conn instance,
but in order to support the feature of asynchronous close(),
I can not find a better way than adding a separate work,
for resource constraints, I recommend the developers to enable
CONFIG_NET_ALLOC_CONNS, which will reduce the ram usage.
Signed-off-by: chao an<EMAIL_ADDRESS>Impact
N/A
Refer to the discussion in issue:
https://github.com/apache/incubator-nuttx/issues/6721
https://github.com/apache/incubator-nuttx/pull/6740
@PetervdPerk-NXP
Testing
tcp stress test
@fjpanag

I see that we are going back and forth with removing and adding cls work @anchao  do you recall why it was removed last time?

I see that we are going back and forth with removing and adding cls work @anchao do you recall why it was removed last time?

The resource consumption of network has increased compared to the previous version:
https://github.com/apache/incubator-nuttx/issues/6721
https://github.com/apache/incubator-nuttx/pull/6740
We will consider optimization of resource consumption from other aspects in the future.

@anchao I will be glad to test this, but it will take me some time. Maybe till the evening or tomorrow morning.
Please wait for my results, I will comment here.

I had one case were one thread stuck indefinitely within a connect() call.
During the incident, all other tasks could be seen idling. It was not a dead-lock.
I am not sure that it is caused by this commit, I just haven't seen this before.
It seems as a timing issue.
Here is the stack trace of the stuck thread:

Does your netdev still work in this case? it look like psock_tcp_connect can't receive any important event inside psock_connect_eventhandler.

Does your netdev still work in this case? it look like psock_tcp_connect can't receive any important event inside psock_connect_eventhandler.

Yes, during the incident another thread managed to communicate with a TCP server, without delays or errors.

I also removed and re-plugged the Ethernet during this. This has as a result a pair of calls to ifdown/ifup. The rest of the system behaved correctly, while this thread remained stuck in this state.

In this case, do you receive NETDEV_DOWN?

In my case CONFIG_NETDOWN_NOTIFIER is disabled.
I don't know if it is related, but tcp_close_eventhandler() is still not called every time a socket is closed. Only some times. Is this expected?

In my case CONFIG_NETDOWN_NOTIFIER is disabled.
I don't know if it is related, but tcp_close_eventhandler() is still not called every time a socket is closed. Only some times. Is this expected?

If you don't close the socket by self, and unplug the netdev without CONFIG_NETDOWN_NOTIFIER, nobody can notify you. Does the problem disappear without this patch?

If you don't close the socket by self, and unplug the netdev without CONFIG_NETDOWN_NOTIFIER, nobody can notify you. Does the problem disappear without this patch?

The socket will soon try to send data and it will fail. This will call close().
I have added logs and I monitor the usage of close() and tcp_close_eventhandler(). I can assure you that when the first one is called the second one may not be called.
The problem with the stuck thread only happened once, using this patch. I am trying hard, but I haven't found a way to reproduce it.

I managed to cause the issue with the stuck thread again. Here is how I did it.
My setup has as follows:
graph LR
    A[Device] -->|Ethernet A| B
    B[Switch] -->|Ethernet B| C
    C[LAN]

So, everything was working normally.
Two threads open a TCP socket towards two different servers, and happily exchange data.
I cause a disruption on the network, that is I unplug the Ethernet cable B.
The communications are troubled, but the device sees the link to be still UP.
The problem in server communications causes both connections to be closed.
This will lead to two calls to close(), one in every thread.
I connect Ethernet cable B back. Communication is now possible.
The two threads call socket(), followed by connect() etc...
Thread A manages to connect to the server. It exchanges data normally.
Thread B is stuck in connect() again!
The system does not seem to be able to recover. After a couple of minutes I repeat the experiment.
Once again I disconnect and reconnect Ethernet cable B.
Now Thread A also gets stuck in connect()!
Thread B remains stuck.
The system cannot recover in any way, it needs a full reboot.

While the issue manifested itself, I took a look around with my debugger and I saw:

There was no dead-lock, i.e. two threads waiting for each-other.
All other threads were running normally. Typically not much to do, so they mostly sleep().
Both workers in the low-priority queue were mostly sleep()ing.
Another part of the system did use the workers successfully.
The workers never executed anything related to the network while in this state.
While in this state I unplugged Ethernet cable A. Nothing happened. (Expected, thread is stuck).
I re-connected Ethernet cable A. Again, nothing happened. (Expected)
devif_dev_event(dev, NETDEV_DOWN); (file netdev_ioctl.c, line 1946) cannot be called, thread is stuck.

Both stuck threads have the same call trace:

Repeating the experiment multiple times I got a failed assertion @ tcp/tcp_conn.c, line 770.
Worker A:

Worker B:

Thread A:

Thread B:

Repeating the experiment multiple times I got a failed assertion @ tcp/tcp_conn.c, line 770.

@fjpanag ,
Thanks a lot for your detailed analysis! From the callstack you shared, it should be that the conn waiting to be released is reused as a fall-back conn:
https://github.com/apache/incubator-nuttx/blob/master/net/tcp/tcp_conn.c#L638-L676
I think here should add some sanity check before tcp_free():
$ git diff .
diff --git a/net/tcp/tcp_close.c b/net/tcp/tcp_close.c
index fb1e9015d7..dca09c267e 100644
--- a/net/tcp/tcp_close.c
+++ b/net/tcp/tcp_close.c
@@ -53,10 +53,13 @@ static void tcp_close_work(FAR void *param)

   net_lock();

-  /* Stop the network monitor for all sockets */
+  if (conn && conn->crefs == 0)
+    {
+      /* Stop the network monitor for all sockets */

-  tcp_stop_monitor(conn, TCP_CLOSE);
-  tcp_free(conn);
+      tcp_stop_monitor(conn, TCP_CLOSE);
+      tcp_free(conn);
+    }

   net_unlock();
 }

I will update  this PR, could you please help with further testing ?

@fjpanag do you have any update?

@xiaoxiang781216 Sorry I need more time. I haven't finished with the tests yet.
I also have one device that has crashed again, but I haven't got it in my hands yet (its on a different location), so I don't know if it is related.

Repeating the experiment multiple times I got a failed assertion @ tcp/tcp_conn.c, line 770.

@fjpanag ,
Thanks a lot for your detailed analysis! From the callstack you shared, it should be that the conn waiting to be released is reused as a fall-back conn:
https://github.com/apache/incubator-nuttx/blob/master/net/tcp/tcp_conn.c#L638-L676
I think here should add some sanity check before tcp_free():
$ git diff .
diff --git a/net/tcp/tcp_close.c b/net/tcp/tcp_close.c
index fb1e9015d7..dca09c267e 100644
--- a/net/tcp/tcp_close.c
+++ b/net/tcp/tcp_close.c
@@ -53,10 +53,13 @@ static void tcp_close_work(FAR void *param)

   net_lock();

-  /* Stop the network monitor for all sockets */
+  if (conn && conn->crefs == 0)
+    {
+      /* Stop the network monitor for all sockets */

-  tcp_stop_monitor(conn, TCP_CLOSE);
-  tcp_free(conn);
+      tcp_stop_monitor(conn, TCP_CLOSE);
+      tcp_free(conn);
+    }

   net_unlock();
 }

I will update this PR, could you please help with further testing ?

No, this is not the root cause.
I managed to have the code to enter this multiple times, but the assertion does not fire.
I managed to have the assertion fail again, but before the failure the above code was not executed.
There is another problem, elsewhere.

During the failed assertion, two threads operate on the same conn structure.
One is receiving data while the other tries to free the connection. Hence the failed assertion.
See the following call traces:

During the failed assertion, two threads operate on the same conn structure.
One is receiving data while the other tries to free the connection. Hence the failed assertion. See the following call traces:

@fjpanag  Did you apply the latest patch set? In this case, if the reference count is greater than 0, tcp_free() should not be triggered.

@anchao Sorry I should have explained better.
I have applied this patch, but I have deliberately commented out your last fix checking the reference count.
I did this, so I can still have the assertion fail, and examine this issue better.
I wanted to understand the path the code is taking, as I believe it is not working as we think.
You identified this as the root cause of the failed assertion.
According to my analysis, this is wrong. The two do not seem correlated. Or if they are, this is not the only problem.
So this fix may be wrong, as it tries to solve an issue that maybe it is not there.
I am afraid that this fix may just mask the actual problem, or cause a leak.
I would like us to positively identify the root cause, before applying any changes.
Also, the issue with threads getting stuck during connect() appears to be fairly common to us.
It happens in all of our devices, a few times per day.
I have a tendency to believe that these two are correlated.

Hi @fjpanag ,
Could you please confirm whether tcp_alloc uses the fall-back connection instance when the assert() triggered?
https://github.com/apache/incubator-nuttx/blob/master/net/tcp/tcp_conn.c#L638-L704
(perhaps you need to add some debug logs to track the pointer of "conn"), I guess the issue you encounter maybe as blew:
1. tcp_close ready and queue the lpwork to free the resources:
net/tcp/tcp_close.c:
tcp_close_eventhandler
|
 ->work_queue  (LPWORK priority 100)

2.  High priority task( > 100) open socket and allocate the tcp_conn instance,
     no free connections and fall-back to active list to found out the close pending instance

socket
|
 ->tcp_alloc /* conn->crefs++ */(https://github.com/apache/incubator-nuttx/blob/master/net/tcp/tcp_conn.c#L638-L704)
 |
   ->connect

3. High priority task blocked on connect(), task yield to lpwork,
tcp_close_work()
|
 ->tcp_free()
     |
       ->assert()  (conn->crefs > 0)

@anchao This is exactly the tests I did, last week.
According to these tests:

When the fall-back is used, the assertion does NOT fire.
When the assertion fires, the fall-back was NOT used.

I starting re-testing it again, yesterday.
I can confirm again point 1.
I couldn't manage to cause the assertion to fail to confirm number 2, but I did so last week.
I will continue testing this.

@fjpanag , do you have any comments? We have the net stress test for this PR, from the feedback from test team, there are no other side effects, Since this PR resolved that the conn instance can not be released correctly, how about merge this PR first? If you have other findings, let us rise a new issue.

@anchao Sorry I was on an expedition abroad with no internet access.
Give me some time to re-sync with everything, and I will comment back.


[question] how to specify the GPU which should be used?

.

currently I do it like this:
CUDA_VISIBLE_DEVICES=1 python ./scripts/commands/SynthSeg_predict.py ...

Hi, the current training function doesn't support GPU assignation, but I'm sure there are plenty of tutorials out there to explain how to do this!


[wip] Sidemenu layout

Merging this into a new branch and closing #253 in favor of this one

Thank you @florence-wolfe <3


[BUG] Sometimes online player treated as offline player

Versions

EasyAuth 3.0.0
Fabric API 0.47.10

Describe the bug
After creating this "mixed" offline-online mode, the inventory of my players disappeared. I'll do more research to see if it happened on everyone or just premium accounts. Also, other data like location and homes will be lost.
To Reproduce
Steps to reproduce the behavior:

Set the EasyAuth config to default, and the server to offline mode.
Enter the server and put something in your inventory.
Stop the server, then create the mixed mode.
Start the server and enter. You'll be in the spawn with no items at all.

Expected behavior
I guess everybody should have their inventories after making this changes.

This is a known issue. Check https://github.com/NikitaCartes/EasyAuth/wiki/AutoLogin-Mojang-accounts

As I understand you moved from fully offline mode to mixed mode? In that case all advancements, playerdata should be  migrated automatical for all players, both offline and online.
If you move back to offline from online mode items (and other things) will be lost. (You can rename files that contain that information by hands)

I entered the playerdata folder but everything is encrypted

You can rename files in world/playerdata, world/stats and world/advancement.
They use uuid of player as their name, so you need to change that. You can use https://minecraft-serverlist.com/tools/offline-uuid for offline uuid and https://namemc.com/ for online uuid.

What type of error they get?

Before forcing their offline-uuid they got something like invalid player data, and after doing so they just get disconnected

I don't think so, but here's the lastest log
latest.log

Did it

Can you send server.properties and mod's config?

config.zip

It's seems like that player tries to connect with offline account but this name is used in someone's else online account. You can add it in forcedOfflinePlayers with auth addToForcedOffline <player>

I did it with one of the players but it didn't work

Today I made no changes and someone who played like 3h ago has lost the inventory

ok and what about those who cant join at all? One tried changing its username into one that isnt occupied and it didnt work

So one more time:
It's offline player;
This nickname doesn't belongs to someone's else online account (or this player in forced offline list);
There is no any error in logs?
Can you join in Discord server, I think it would be easier?
https://discord.gg/UY4nhvUzaK

Its offline player, his nickname doesnt belong to anyone and even when forcing him on the list it doesnt work. Imma join now.

Yes the same thing is happening to me as well
offline player;
the player is in forcedoffline list
there is some red thing related to easyauth in the logs, idk what it means tho
it is the same error that EnderGirl got
https://mclo.gs/gw4E4cq

I fixed the problem
I had to go to spawn and use the auth SetSpawn command because spawn dimension was null in config
@EnderGirl1500 maybe it might work for you?

I fixed the problem I had to go to spawn and use the auth SetSpawn command because spawn dimension was null in config

https://github.com/NikitaCartes/EasyAuth/blob/4a15a7223037e64e5cbfff0035c6213288150018/src/main/java/xyz/nikitacartes/easyauth/storage/AuthConfig.java#L252
I am not a Java developer, but this should solve the problem:
public String dimension = "minecraft:overworld";


LoadGen: Add SUT::FlushQueries hook/callback.

Hi @guschmue , I rebased this patch on top of everything that already landed so it shouldn't be as noisy to review.
I changed some of the reference code to provide a sub callback for the FlushQueries hook. ptal. Thanks!

I'll give it a test drive today.

@guschmue just a friendly nudge to please check on this and merge if possible.

@guschmue : I think this one is ready to land. Some folks at Intel requested this and have already verified it on their end.
I also made sure the image classification reference code still worked before the last push.

@guschmue friendly nudge.


Full stack example: webpack + Globalize

PR #481
Provide better documentation by creating a full stack example using webpack and Globalize.
Ref #441 #467
Goal
Development

Easy development, Globalize is a powerful and flexible library, but it can be frustrating to set it up (e.g., loading required CLDR data on development, using compiled data instead on production). It should be easy for developers to build apps using Globalize. Ideally, they should be able to use Globalize (declaratively) without worrying about any of these setups.
Fast Live Reload, Webpack allows writing code in source code formats that browsers don't natively interpret (e.g., coffee script, ES6, less or sass styles, etc) and have them to display it in real time by pre-processing the code into a compatible JavaScript and by having browsers to auto refresh on a process called live reload (HMR Hot Module Replacement), which is a very powerful tool. But, it's frustrating when the pre-processing takes too much time and doesn't get responsive. Ideally, Globalize on development shouldn't weight the process, it should allow for very fast updates from its part.

Production

Optimized for Production, use precompiled formatters/parsers: #398

Small. Avoid including unnecessary i18n data. For example, doesn't include unnecessary translation messages, doesn't include unnecessary functionality data (e.g., doesn't include calendar information if not formatting dates, doesn't include currency data if not formatting currencies, etc), doesn't include unnecessary data within the same functionality (e.g., doesn't include month names if formatting dates using numbered months only). Thefore, no bandwidth is wasted.
Fast. Have all formatters (numbers, currencies, datetimes, relative time) generated/preprocessed at built time. This is, traversing CLDR data and generating the formatters will happen during build time and will be precompiled for runtime. Therefore, no CPU clocks are wasted on the client.

Compiled-Globalize-Code in separate chunks, allow grouping compiled-globalize code in separate chunks.

@jquense, @JeremyRylan, @unindented, @jamischarles, @sompylasar, bundling Globalize with Webpack should work and I'm copying you, because you have shown such interest before and your input is very much appreciated.
An example that demonstrates how to develop an app using Globalize with webpack will be included in our repo. This example is going to be our recommendation on that regard.
In the description above, I've started a list of goals that the example should address. Do you have any other requirements?
I've started implementing the example at #481. Your input there (check if the example really works for you, code review, etc) is also very much appreciated.

@rxaviers Great work! Thanks for pinging me in. I've added a couple of comments to the PR. I've got more thoughts on real use cases I'm struggling with but they aren't shaped well enough to share yet.

Thanks @sompylasar

Sorry I didn't try this before, I was on holidays.
This looks great. The example worked for me both in development and in production modes.
The only issue I had was that modifying translation files didn't trigger a hot reload. Not a biggie, and if it's a limitation of how the plugin works, I'm totally fine with it.
Thanks for your work @rxaviers!

The only issue I had was that modifying translation files didn't trigger a hot reload. Not a biggie, and if it's a limitation of how the plugin works, I'm totally fine with it.

True. Created https://github.com/rxaviers/globalize-webpack-plugin/issues/5 to keep track of it. Thanks

@rxaviers  Hi rxaviers,
i am trying to run the globalize by webpack on windows. When i am trying to run this example.
https://github.com/jquery/globalize/tree/master/examples/app-npm-webpack
i am getting following error.
Module parse failed: C:\path\globalize\app\index.js ENOENT: no such file or directory, open 'C:\path\globalize.tmp-globalize-webpack\C:\path\globalize\app\index.js'
FYI: I run this application by 'npm run build' command.
how can i resolve this issue. I am new to webpack. Can you please help me ASAP.

Hi @warstick, I'm sorry but there's an issue with the webpack plugin for windows. Although, the fix should be pretty trivial. Please, refer to https://github.com/rxaviers/globalize-webpack-plugin/issues/7. PRs welcome :smile:

@rxaviers Thanks for fast replay :) But i tried the same way you suggested. Still, same issue coming.

Please, can you give me more details (e.g., paste the output you get or any other debugging info). Preferably in rxaviers/globalize-webpack-plugin#7. Thx.


Create Cadence Style Guide

Context
Developers need better guidelines for how to write clean cadence code.
Definition of Done
Create a guide in the cadence section of the docs site that give recommendations for Cadence style

line length
function, field, and type comments (paremeters returns) /// (three slashes)
indentation, spaces
var/let type, spaces
bracket spaces
conditions and panic message formats
comments on function interface or on function implementation
Whitespace between code lines
High level documentation at the beginning of contracts/transactions
Contract, field, and function names and capitalization

PR Review
Who is your Code Partner - @joshuahannan
Who can provide external eyes - @satyamakgec

bluesign commented 6 days ago •
I think few important coding style questions are:
When to use panic?
When to return optional?
How to label functions? Where to use _ ?
When to use Struct vs Resource ?
Where to use access(contract) vs pub ?
How to link Resources correctly ? e.g. via multiple interface restrictions vs via multiple paths.
I think when repo is live, we should make each item as PR, then discuss on each PR if needed.
If we don't have opinion how it should be (more debatable), maybe we can start from an issue.


HHH-12121 testcases for lazy loaded entities with final property getters

2/3 of these tests should fail now.

Accidentally create PR from wrong branch. Sorry.


BIGTOP-3564. Fix build failure of Flink on Cent OS 7 ppc64le.

https://issues.apache.org/jira/browse/BIGTOP-3564
Build fails due to error related to node.js.
Running 'npm ci --cache-max=0 --no-save' in /bigtop/build/flink/rpm/BUILD/flink-1.11.3/flink-runtime-web/web-dashboard
/bigtop/build/flink/rpm/BUILD/flink-1.11.3/flink-runtime-web/web-dashboard/node/node: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /bigtop/build/flink/rpm/BUILD/flink-1.11.3/flink-runtime-web/web-dashboard/node/node)

https://github.com/eirslett/frontend-maven-plugin/issues/852 reported that using v.12 node.js fixed similar issue.
I did not test this on ppc64le.

There was a issue related to graceful-fs on upgrading node.js from v.10 to v.12 for Hadoop in https://github.com/apache/hadoop/pull/3128. Flink might need similar fix.
$ grep -r graceful-fs flink-runtime-web
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.11",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:    "node_modules/graceful-fs": {
flink-runtime-web/web-dashboard/package-lock.json:      "resolved": "https://registry.npmjs.org/graceful-fs/-/graceful-fs-4.1.15.tgz",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.6"
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.15",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.15",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.11",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.15",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:            "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.11",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:    "graceful-fs": {
flink-runtime-web/web-dashboard/package-lock.json:      "resolved": "https://registry.npmjs.org/graceful-fs/-/graceful-fs-4.1.15.tgz",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.6"
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:            "graceful-fs": "^4.1.15",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:            "graceful-fs": "^4.1.15",
flink-runtime-web/web-dashboard/package-lock.json:            "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.11",
flink-runtime-web/web-dashboard/package-lock.json:            "graceful-fs": "^4.1.15",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",

Even the current trunk of Flink uses node.js 10.9.0  (same as of Flink 1.11.3).

Just dropping Web UI support on ppc64le could be an option.
if [ $HOSTTYPE = "powerpc64le" ] ; then
  FLINK_BUILD_OPTS="-Pskip-webui-build ${FLINK_BUILD_OPTS}"
fi

@iwasakims I tried the current PR (0013b19) on ppc64le and it succeeded as far as building a package.
jenkins@bigtop1slave:~/bigtop$ docker run -v $PWD:/bigtop -it bigtop/slaves:trunk-centos-7-ppc64le bash
[root@5950c2bf9f66 /]# cd bigtop
[root@5950c2bf9f66 bigtop]# ./gradlew flink-pkg

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:03 min
[INFO] Finished at: 2021-06-28T14:03:54Z
[INFO] ------------------------------------------------------------------------

...

> Task :flink-pkg

BUILD SUCCESSFUL in 58m 44s
57 actionable tasks: 57 executed

But I'm not sure about the graceful-fs matter. Is that OK if the build succeeded, or do we have to set up Flink's web UI so as to make sure if it works with the old version of graceful-fs?

Thanks, @sekikn. I think we should commit this and move the release forward. We can wait feedback and address additional issues in follow-up JIRA. There might be no problem since graceful-fs 3 is not used at least.

OK, I'm going to merge this with my +1. Thanks @iwasakims!


Generic Z Wave thermostat without Fan mode (0x44)

Hi!
I have a few Z Wave thermostats (https://heatit.com/produkt/9437/heatit-z-temp2-white) that use a cloud Device Handler when added.
This is their fingerprint: zw:Fs2a type:0806 mfr:019B prod:0004 model:0204 ver:1.02 zwv:7.11 lib:03 cc:5E,55,98,9F,6C,22 sec:86,85,8E,59,72,5A,87,73,80,71,7A,40,43,42,75,70,31
I looked at the fingerprint of the generic edge drivers (below) and it seems they require command class 0x44 (Fan mode) which this ones don't have.
Any chance you can update the generic drivers to support thermostats without command class 0x44? (as far as I can see that's the only thing preventing it to match).
zwaveGeneric:
  - id: "GenericBatteryThermostat"
    deviceLabel: Z-Wave Battery Thermostat
    commandClasses:
      supported:
        - 0x43
        - 0x40
        - 0x44
        - 0x31
        - 0x80
    deviceProfileName: base-thermostat
  - id: "GenericThermostat"
    deviceLabel: Z-Wave Thermostat
    commandClasses:
      supported:
        - 0x43
        - 0x40
        - 0x44
        - 0x31
    deviceProfileName: base-thermostat-without-battery

Thanks,
Anders

A little update, I made a driver based on the GenericBatteryThermostat above but just removed the 0x44 command class, then my thermostats adds using this (Edge) driver. So for now it's working for me, but it would be nice to have a base driver supporting this.


use middleware with find-my-way router

hello, can you explain example code how to use middleware like cors in 0http find-my-way router ?
i just found demos with sequential router,
thank you

Hi @m-dary-nur , unfortunately middlewares are not supported on find-my-way, only on sequential.
You can have a look at restana (https://www.npmjs.com/package/restana), it does offer middlewares support on top of find-my-way.
Regards

I already used restana for my restful api. maybe restana can improve performance like 0http with low uws is a good news, ok thank you for answer, regard


refactor: enable noUncheckedIndexedAccess

Description
Enabled noUncheckedIndexedAccess to reduce errors for #18798
This would make the code safer but it's tedious in some cases like for (const key in obj) { obj[key] }.

On surface I like that it encourages safer code, but it feels like it's making the code a bit more verbose in some cases. For example, it not interpreting regex access well and the const..in patterns affects the code readability for me. So I'm a bit conflicted in this change, but happy to hear what others think about this.

Pushed a commit that adds String::split / String::matchAll / RegExp::exec overload. This should reduce the verbosity a lot. We still need to pass the type argument but it's easier than as StrictRegExpArray<>.
I'm fine with closing this PR if others prefer not to enable it 👍

I also don't know if the extra inconvenience is worthy here. I would vote to don't do merge this one at this point.

Then, I'll close this one and #18798. I'll make a PR that extracts the fixes found in #18798 👍


UX: Change export task type to java (buildArtifact)

fix #665
This pr also renames the default label from java: exportjar:${workspaceName} to java (buildArtifact): ${workspaceName}. We can still find java type via Run Tasks..., but the provider will not provide any template tasks anymore. If there is no java tasks in your tasks.json, the result of clicking java type will be empty.

for workspace doesn't contain "java" tasks:
https://user-images.githubusercontent.com/45906942/179884446-20fa5a24-4804-4595-bf50-2edf6676bcae.mp4
for workspace contains "java" tasks:
https://user-images.githubusercontent.com/45906942/179884466-197746a6-260c-42d5-8e87-2e5d83197bc9.mp4

now we will show quick fix as well:
https://user-images.githubusercontent.com/45906942/180373429-725ea7a9-9e7f-4d5b-8eac-db2c17bc66a1.mp4