Introducing a New User Defined Signal

This new signal will provide more functionality to the users as they can learn to operate on two signals. Two SIGUSR signals will provide effective communication between two processes through IPC.

Thanks  for SIGUSR


Flow - Comment input auto-focus is gone

If you click on the 'comment' button of a Post it gives focus so you can start typing right away. But it only does this the 1st time, should be every time you click on the button.
How to reproduce:

Create a post
Click on 'comment' button
Add a comment
Create another post
Click on 'comment' button
It does not auto-focus now

That is normal behavior of auto focus.
Auto-focus only works on first render. So when clicking on comments again the focus is gone and will not come back.
So we have to find another solution for this


Add buildah and s2i tasks

This patch adds and update-tasks.sh script which downloads tasks from
Upstream and Downstream catalog, munges them to make the tasks as
cluster-task.
Signed-off-by: Sunil Thaha<EMAIL_ADDRESS>

/lgtm


GUI Missing For Decrypting/Encrypting on Front End

I think we should add GUI For Decrypting/Encrypting, So People can quickly test out the tool

Can i get assigned on this?


Fixed Fargate Availability Script

Issue #, if available:
Description of changes:
The script to check for Fargate availability in a region had some minor formatting issues that prevented it from running successfully. I updated the script, and it works properly now.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

thanks!


HOCS-5671: Enable PSU escalation at service triage

Merged in https://github.com/UKHomeOffice/hocs-workflow/pull/891


dotnetcore 3.1 build fails on Azure DevOps with Virtual Machine ScaleSet using latest Ubuntu1804 image and VMSS Agent Extension - 1.2.1

Describe the bug
Running a simple dotnetcore build on a VMSS using the ubuntu1804 packer file from this repo fails when using dotnetcore 3.x, running using Windows Server 2019 works as expected, as does dotnetcore 3.0.x
Starting: DotNetCore Build x.sln - Release
==============================================================================
Task         : .NET Core
Description  : Build, test, package, or publish a dotnet application, or run a custom dotnet command
Version      : 2.172.2
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/build/dotnet-core-cli
==============================================================================
Info: .NET Core SDK/runtime 2.2 and 3.0 are now End of Life(EOL) and have been removed from all hosted agents. If you're using these SDK/runtimes on hosted agents, kindly upgrade to newer versions which are not EOL, or else use UseDotNet task to install the required version.
/usr/bin/dotnet build /agent/_work/1/s/core/src/**x.sln** -dl:CentralLogger,"/agent/_work/_tasks/DotNetCoreCLI_5541a522-603c-47ad-91fc-a4b1d163081b/2.172.2/dotnet-build-helpers/Microsoft.TeamFoundation.DistributedTask.MSBuild.Logger.dll"*ForwardingLogger,"/agent/_work/_tasks/DotNetCoreCLI_5541a522-603c-47ad-91fc-a4b1d163081b/2.172.2/dotnet-build-helpers/Microsoft.TeamFoundation.DistributedTask.MSBuild.Logger.dll" --configuration Release
Microsoft (R) Build Engine version 16.6.0+5ff7b0c9e for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1025: An internal failure occurred while running MSBuild.
System.ComponentModel.Win32Exception (13): Permission denied
   at System.Diagnostics.Process.set_PriorityClassCore(ProcessPriorityClass value)
   at System.Diagnostics.Process.set_PriorityClass(ProcessPriorityClass value)
   at Microsoft.Build.CommandLine.MSBuildApp.Execute(String[] commandLine)
Unhandled exception. System.ComponentModel.Win32Exception (13): Permission denied
   at System.Diagnostics.Process.set_PriorityClassCore(ProcessPriorityClass value)
   at System.Diagnostics.Process.set_PriorityClass(ProcessPriorityClass value)
   at Microsoft.Build.CommandLine.MSBuildApp.Execute(String[] commandLine)
   at Microsoft.Build.CommandLine.MSBuildApp.Main(String[] args)
##[error]Error: The process '/usr/bin/dotnet' failed with exit code 134

Sample Pipeline yaml
trigger: none

pr: none

variables:
  buildConfiguration: 'Release'
  solution: 'x.sln'

jobs:
- job: Build
  displayName: Repro build failure
  pool:
    name: **_removed_**
  steps:
  - task: UseDotNet@2
    inputs:
      packageType: 'sdk'
      version: '3.x'

  - task: DotNetCoreCLI@2
    displayName: 'DotNetCore Build $(solution) - $(buildConfiguration)'
    inputs:
      command: 'build'
      projects: '$(solution)'
      arguments: '--configuration $(buildConfiguration)'

Area for Triage:
.NET Core

Question, Bug, or Feature?:
Bug
Virtual environments affected

[ ] macOS 10.15
[ ] Ubuntu 16.04 LTS
[x] Ubuntu 18.04 LTS
[ ] Ubuntu 20.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Expected behavior
dotnetcore command should execute successfully
Actual behavior
134 exit code

Create a new yaml pipeline using an Ubuntu1804 VMSS Agent Pool built using the ubuntu1804 packer file from this repository
Run the pipeline

@mihsoft , Am I right that this issue doesn't reproduce on Hosted agents?

@maxim-lobanov indeed, it appears to be an issue only when utilising the image with a VMSS scale set + the Azure DevOps VMSS extension.

@mihsoft , I see.
In this case, I think that this repository is incorrect place for both (#1287 and #1240) issues. Our team (this repository) owns only image content and image-generation process and unfortunately, we are not experts with Azure services.
@WillLennon, If this issue looks related to #1240, could you please advice the place where this issue can be transferred for your team to take a look?

thanks @maxim-lobanov, apologies for logging in the wrong place.

@maxim-lobanov I think there might be some merit in investigating this,
When executing the linux nice command on Microsoft hosted agents it returns 0, when executing on a VM built using the virtual-environments images it returns 2. The /etc/security/limits.conf is the same on both boxes, is there something else Microsoft is executing on their hosted agents that is not included with the virtual-environments images?

I think the difference is azure-pipelines-agent between machine and Azure DevOps that is some kind of wrapper for all commands but I am not sure how it could cause this specific issue
cc: @al-cheb, @WillLennon for any thoughts.

@maxim-lobanov just an update from further investigations on our side,
If we use a VM with the default ubuntu-1804 image and install an azure agent on it then the issue is not present and dotnetcore works as expected.
If we use a VM with the packer ubuntu-1804 image from this repository we receive the dotnetcore error

@maxim-lobanov - I am closing this issue now as it has been picked up by the Azure DevOps team.
For anyone else arriving at this ticket please see the following which provides a workaround: https://developercommunity.visualstudio.com/content/problem/1124438/linux-scale-set-agents-agentlistener-processs-star.html


name added

I added my name to the text file

Please I am sorry for all the trouble we have caused you but count it all joy. Your PR is about to be merged and you will be able to see your name on this url.
To enable me to do this, READ the README again carefully, update your code with the latest and push the update. I am here for you for the next 6 hours before I close the PR so you can initiate a fresh PR which will be easier to merge.


Fixed imports to avoid pydantic if the version is >=2

Closes #280
Will now use dummy imports if the pydantic version is >= 2.0.0, not only if pydantic doesn't exist.

From the docs it looks like another option might be in v2 you can do from pydantic import v1 as pydantic, which might mean you can get it to work for both?

From the docs it looks like another option might be in v2 you can do from pydantic import v1 as pydantic, which might mean you can get it to work for both?

I've used try except with v1 now, so the generation code will work with either.

From the docs it looks like another option might be in v2 you can do from pydantic import v1 as pydantic, which might mean you can get it to work for both?

I've used try except with v1 now, so the generation code will work with either.

But the upper cap is still in to stop pytdantic < 2?

From the docs it looks like another option might be in v2 you can do from pydantic import v1 as pydantic, which might mean you can get it to work for both?

I've used try except with v1 now, so the generation code will work with either.

But the upper cap is still in to stop pydantic < 2 being installed?

I think it's probably still good to pin pydantic<2 as a dev requirement since the generation code does require that version, the difference is that if event-model is installed as a requirement in an environment with pydantic 2 then the wrapper will use pydantic 1 instead.


Unresolved attribute reference self.hosts

See https://github.com/django/asgi_ipc/blob/b6750c51ab7e409450e52735454f38333ef06e2b/asgi_ipc.py#L168
I added a # TODO comment in my latest pull request.
https://github.com/django/asgi_ipc/pull/10/commits/980ccabf192c3fada294a5b1a32a4908887c058d#diff-64b224d30f0fb99ddead52f77c969d28R169

Yes, this is left over code from when it was copied from the Redis backend as a template I suspect. It should be replaced to show prefix instead.


It works on Arch Linux

I tried to run the draw example with the build-native feature. It didn't work initially even when I had blas. I installed the extra/openblas package but it still didn't work. It worked perfectly after I installed extra/blas-openblas

Thanks! It allowed me to create a convenient document for using crate in Arch Linux. Could you mind to check the updated document when you have time?

That looks good to me! Also, I also tried installing dlib with pacman -S dlib without using the build-native feature, it also worked for me.

You mean yay -S dlib? I tested on my Arch desktop and got an error that dlib is not an official package. Or do you have a custom repo?

You mean yay -S dlib? I tested on my Arch desktop and got an error that dlib is not an official package. Or do you have a custom repo?

you are right, sorry. ~And please use paru instread of yay cuz paru is written in Rust~

Really? I didn't know that paru is the more attractive one. Anyway, thanks for giving me a hint!

Updated! https://github.com/ulagbulag/dlib-face-recognition/commit/079158d821f0e85e4e0cc0c37a8f69b56f44db42

Closing by resolved.


Check failed: bottom[0]->shape() == bottom[i]->shape()

Platform (like ubuntu 16.04/win10):
win10
Python version:
3.6
Source framework with version (like Tensorflow 1.4.1 with GPU):
tf1.12.0 with cpu
Destination framework with version (like CNTK 2.3 with GPU):
caffe
Pre-trained model path (webpath or webdisk path):
https://github.com/grapefruitL/tf2caffe/tree/master/model
Running scripts:
mmconvert -sf tensorflow -in model/model.meta -iw  model/model --dstNodeName Squeeze -df caffe -om outmodel
then i got errs:
...
lots of prints
...
I0726 13:33:46.171232 16152 layer_factory.hpp:77] Creating layer conv1_mul_1
I0726 13:33:46.172233 16152 net.cpp:84] Creating Layer conv1_mul_1
I0726 13:33:46.172233 16152 net.cpp:406] conv1_mul_1 <- conv1_sub
I0726 13:33:46.172233 16152 net.cpp:406] conv1_mul_1 <- conv1_mul_1_y
I0726 13:33:46.172233 16152 net.cpp:380] conv1_mul_1 -> conv1_mul_1
F0726 13:33:46.172233 16152 eltwise_layer.cpp:34] Check failed: bottom[0]->shape() == bottom[i]->shape() bottom[0]: 1 10 214 158 (338120), bottom[1]: 1 10 158 214 (338120)
*** Check failure stack trace: ***

i think the reason is
https://github.com/microsoft/MMdnn/issues/366#issuecomment-441167240
but i'v no idea how to fix it

can i exchange the value of shape[2] and shape[3] of DummyData layer in emit_Constant() function (caffe_emitter.py)? that will solve the problem
another question:
why must the shape[0] of DummyData layer be 1 ?

another question:
why must the shape[0] of DummyData layer be 1 ?

i found the reason is rename_Placeholder() function in tensorflow_parser.py
def rename_Placeholder(self, source_node):         IR_node = self._convert_identity_operation(source_node, new_op='DataInput')         # shape         TensorflowParser._copy_shape(source_node, IR_node)         if len(IR_node.attr['shape'].shape.dim)>0 and len(IR_node.attr['_output_shapes'].list.shape)>0 and len(IR_node.attr['_output_shapes'].list.shape[0].dim)>0:             IR_node.attr['shape'].shape.dim[0].size = -1             IR_node.attr['_output_shapes'].list.shape[0].dim[0].size = -1
what does it mean ?

Hi @grapefruitL, this function implements that add the source_node 'Placeholder' into IR graph and set the first dims of 'shape' and '_output_shape' attributes of IR_node to be -1, which means None.

can i exchange the value of shape[2] and shape[3] of DummyData layer in emit_Constant() function (caffe_emitter.py)? that will solve the problem

seems i'm wrong, when i use the converted caffemodel ,the same err happens, so it means the shape of dummydata generated by the original code is right, why do errors occur during conversion

@grapefruitL, this line of code is wrong. Please change it to shape = [shape[0], shape[3], shape[1], shape[2]]

@rainLiuplus  thanks! it will solve the problem


user docs: Document message notification email custom batching.

Follow-up to #19576.
Testing plan:
manual
GIFs or screenshots:

I pushed back to this PR with some partial progress towards providing more background around how this works.  Might be worth another edit pass from @alya before merging.

I did another edit pass.

This is great!  Merged after squashing the commits, huge thanks for doing this @alya!
@abhijeetbodas2001 FYI :)


osx-whitelist not added automatically?

Hi, I added cutadapt to the OS X whitelist. I believe this should be sufficient to build for OS X after submitting a pull request to Travis, and know that the build files can be reused from Linux to OS X since the conda files are the same as here which builds for OS X. However, Travis didn't upload it to anaconda.org even though the test passed -- is there something else I need to do to get it to build automatically?

Never mind, it just takes a bit of time to propagate to anaconda.org!


Issue with serialization of null values using custom converter

Intro
Area: Converters, Serialization
Issue: Methods JsonConverter.CanConvert and JsonConverter.WriteJson are not called during serialization if source value is null.
Description: I need to convert the C# object to JSON string in such way that for every DateTime property of source object the result JSON will contain a duplicate property with name of source property plus suffix 'Msk' and it will contain a Moscow DateTime. If the source property value is null, then I want the resulting value to be null too. However now if the value is null the methods CanConvert and WriteJson are not called, and accordingly the new property is not created in result JSON.
Library version: 11.0.1
Platform: .NET Core 2.1.4 (also reproduced at .NET Framework 4.6.1)
Source type model
public class Flight
{
    public DateTime? ArrivalTime { get; set; }
    public DateTime? DepartureTime { get; set; }
}

JsonConverter
public class AddMskDateTimeConverter : JsonConverter
{
    /// <inheritdoc />
    public override bool CanRead { get; } = false;

    /// <inheritdoc />
    public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
    {
        var propertyName = writer.Path.Split(new[] {'.'}, StringSplitOptions.RemoveEmptyEntries).Last();
        var mskProperty = new JProperty($"{propertyName}Msk", null);

        if (value == null)
        {
            writer.WriteNull();
        }
        else
        {
            var dt = (DateTime) value;

            writer.WriteValue(dt);
            mskProperty.Value = dt.AddHours(3); // Assume time UTC, simplified for example
        }

        mskProperty.WriteTo(writer);
    }

    /// <inheritdoc />
    public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
    {
        throw new NotSupportedException("Only serialization is supported");
    }

    /// <inheritdoc />
    public override bool CanConvert(Type objectType)
    {
        return typeof(DateTime?).IsAssignableFrom(objectType);
    }
}

Serialization
class Program
{
    static void Main(string[] args)
    {
        var flight = new Flight
        {
            DepartureTime = DateTime.UtcNow
        };

        var settings = new JsonSerializerSettings
        {
            NullValueHandling = NullValueHandling.Include,
            DefaultValueHandling = DefaultValueHandling.Populate
        };

        settings.Converters.Add(new AddMskDateTimeConverter());

        var json = JsonConvert.SerializeObject(flight, settings);
    }
}

Actual JSON after serialization
{
	"ArrivalTime": null,
	"DepartureTime": "2018-03-09T20:32:01.763685Z",
	"DepartureTimeMsk": "2018-03-09T23:32:01.763685Z"
}

Expected JSON after serialization
{
	"ArrivalTime": null,
        "ArrivalTimeMsk": null,   // <-- This is missing
	"DepartureTime": "2018-03-09T20:32:01.763685Z",
	"DepartureTimeMsk": "2018-03-09T23:32:01.763685Z"
}

This is still an issue for me with .NET Framework 4.8 & version 12.0.3

I believe the Json library to write the values calls if(value == null){writeNullValue(value);} before it picks up the custom converter. Unless Netwonsoft has changed that recently your custom converter will never write a null value. I worked around this by creating a custom resolver and overriding the IValueProvider methods and set "default" custom values there.
Things may have changed or i may be missing something but as far as I can see that is the issue and the way around it.

Workaround is to create new data type which will be wrapper over original data and in WriteJson handle the case when inner value is null


WFLY-15163 Drop deprecated interfaces/classes/methods from wildfly-clustering-api

https://issues.redhat.com/browse/WFLY-15163
Requires https://github.com/wildfly/wildfly/pull/14579

@rhusar @rachmatowicz Please review.


[pgadmin4] Add Support For Context Path Hosting

What this PR does / why we need it:
Implements "one-change" support for hosting pgadmin4 on a context path (e.g. mydomain.com/pgadmin).
Special notes for your reviewer:
Documentation on pgadmin.org demonstrates (sort of) how pgadmin4 can be hosted on a subdirectory/context path by adding the environment variable SCRIPT_PATH. However, since the request paths for the readinessProbe and livenessProbe are hard coded, modifications are needed to the helm chart to implement.
To make it more clear what this option does, I named the value field contextPath.
I have tested these modifications using kustomize, and have also verified that helm builds correctly with these modifications.
I'm not entirely certain whether placing this option underneath the environment variables section is logical, or desired for future extensibility. Additionally, not certain what the standards are for for increasing chart version numbers (minor vs dot version?). Would definitely appreciate feedback on these matters.
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [mychartname])

For what it's worth, I don't think I missed any configuration options for the checks... both versions appear to be hitting a 403 error for the helm repo hosted on Google Cloud Storage (v.13.12, v1.17.2).
Please advise if I did miss something. Thanks!

Apologies, but I'm a bit obsessive when I start down a tangent. After completing the changes for the PR as described above, I noticed that the order of the parameters in values.yaml file was desynced with the configuration table in README.md... and some default values didn't match.
One thing led to another, and... now qkflies:docs-cleanup exists. 🤦♂ I don't know if you'd prefer another PR for these changes, or if I should just fold them into this one... let me know your preference.

ah I see what the issue is, let me resolve my end first and then you could perhaps also make a new PR for your docs-cleanup? Thanks for your pr.

please merge master into your branch, https://github.com/rowanruseler/helm-charts/pull/61 should resolve the test issues.

@rowanruseler Doesn't appear the modification made in #61 took hold, the testing tools are still trying to call the same url as before.
Taking a look at the https://github.com/helm/chart-testing-action, it does appear that they've made some pretty significant changes compared to the version that the test suite is calling... they're on v2.0.1 now, but there's breaking changes. between v1 and v2.


Provide suggestions for advancement criteria

Split from #383.
Relates to #729.

Implemented in https://github.com/SPYGlassMC/SPYGlass/commit/01b67cc5a555551d828a69653f38d376f903c76d


Improve CI reliability by forcing vendor use

Signed-off-by: Kevin Parsons<EMAIL_ADDRESS>

Was our CI pulling deps instead of using the vendor dir?

Was our CI pulling deps instead of using the vendor dir?

It definitely used to. It might not be anymore since it was upgraded to go1.15, but this should make it more certain.

@kevpar Yea that was the reason I was asking, as I know the default behavior was changed in a later go release. Change makes sense though, doesn't hurt anything


How to setup Authorization Code Flow

I need to implement Authorization Code Flow to authorize against ADFS server.
I have downloaded demo https://github.com/andreareginato/oauth-ng-demo and installed latest oauth-ng.
<oauth
      site="https://testadfs.local/adfs"
      client-id="CLIENT_IF"
      redirect-uri="http://localhost:9000"
      authorize-path="/oauth2/authorize"
      token-path="/oauth2/token"
      response-type="code"
>

I am getting redirect to adfs loging page where I login, after that a redirect back to redirect-uri="http://localhost:9000" happens and ulr changes to
http://localhost:9000/?code=SOME_LONG_CODE

So I got authorization code but no other action to exchange code for access token did happen. What should I do, should I add code for requesting token using code, or should it be handled automatically by oauth-ng and I have some configuration problem?

@NickAb The Authorization Code Flow is also sometimes called server side flow, which means you need your backend server to do some work. In your case, your server needs to understand and process the redirect (think about http://localhost:9000/?code=SOME_LONG_CODE as a regular request). In fact, most of the work of Auth code flow is done by the app server and the IdP, at client agent (browser) side, it just initialize the auth request.
IMO, the current oauth-ng documentation is a little confusing about this part. I will try to send a PR to refine it.

@faraway thank you.
So, if I understand correctly:

client (Angular SPA) inits flow by sending user to IdP with redirect uri set to backend callback endpoint,
after that IdP redirects to oauth callback endpoint of backend,
backend POSTs code to /oauth2/token and receives back the token.

But how would this token get returned back to client? More specifically how backend will now the redirect uri for the client (Angular SPA)?

@NickAb

But how would this token get returned back to client?

I assume here client means browser here. I mention this because in the OAuth2 spec, client actually refers to the app server while the browser is called user agent
In authorization code flow, the access token is never returned back to the browser. Instead, the token is kept (safely) at the app server side, which is one of the major reasons that auth code flow exists.
In implicit flow(which oauth-ng is mostly used for) that has token maintained at browser side, the access_toke usually expires very soon (usually 30 ~ 60 mins), because browser can not keep the token safe. Whereas in auto code flow, the token can be kept in app server side for longer time, can usually you can also request for refresh token as well.
If you use auth code flow, this is the way I would assume that things should work:

Angular SPA initialize the auth request.
The auth dance starts (the steps you mentioned) and completes. The access token gets sent to your app server side.
When your SPA needs to access some protected resource, it talks to the app server. The app server accepts the request, do whatever business logics it needs to perform(or not at all), attach the access token it has, and send to the protected resource endpoint.

@faraway Thank you for clarification.
I guess I have somewhat uncommon case. My API does not need to access users data on another resource (github, google, etc), but rather my API itself is a resource that should be protected by authorization. And for authorization I need to use corporate ADFS (where all claims are going to be setup), which currently only supports authorization code flow.

Anyone could share simple code using Authorization Code Flow for requesting token using code. I have been trying for 2 day, but not successful now i hopeless, :-D. please give me some clue. thanks.

Amen brother.  There's a serious lack of documentation here. @guntur


Missing Rain and Splash Particle Textures

Minecraft: 1.21.1
Fabric: 0.16.9
Particle Rain: 3.0.0

Rain (and splash) particles have missing textures. Log: latest.log

I realized I have been using an outdated version.


I think accepting an all as param is misguiding.

Delete is taking param all, which is not used, and this may cause confusion as if "delete all" is name of the command. so, for clarification, I added a hyphen.

Good catch, thank you!


Autostyle aggregation

This PR implements #8468. It relays on https://github.com/CartoDB/deep-insights.js/pull/541, so merge it before deploy it. Also don't forget to point package to the right branch.

Merging!


perf: decrease allocations based on base

There are two heavy sources of allocations based on value of base:

each node in the tree causes an allocation
the list of children for each node causes an allocation

The allocation for (1) can be batched into a single allocation
because we can pre-calculate the exact number of nodes we'll need.
The allocation for (2) can be eliminated
by tracking parent indexes in a list of nodes
instead of a slice of child nodes.
This change performs both these optimizations.
goos: darwin
goarch: arm64
pkg: go.abhg.dev/algorithm/huffman
cpu: Apple M3
                              │  before.txt  │              after.txt              │
                              │    sec/op    │   sec/op     vs base                │
Label/base=2/numItems=10-8       1.220µ ± 3%   1.017µ ± 4%  -16.64% (p=0.000 n=10)
Label/base=2/numItems=100-8      15.12µ ± 0%   14.93µ ± 1%   -1.24% (p=0.000 n=10)
Label/base=2/numItems=1000-8     226.5µ ± 1%   240.0µ ± 0%   +5.97% (p=0.000 n=10)
Label/base=8/numItems=10-8       765.8n ± 1%   516.0n ± 3%  -32.61% (p=0.000 n=10)
Label/base=8/numItems=100-8      8.691µ ± 1%   7.946µ ± 1%   -8.57% (p=0.000 n=10)
Label/base=8/numItems=1000-8     120.7µ ± 0%   128.1µ ± 1%   +6.15% (p=0.000 n=10)
Label/base=32/numItems=10-8      675.4n ± 1%   424.5n ± 2%  -37.15% (p=0.000 n=10)
Label/base=32/numItems=100-8     7.629µ ± 1%   6.463µ ± 1%  -15.28% (p=0.000 n=10)
Label/base=32/numItems=1000-8   113.41µ ± 0%   98.98µ ± 1%  -12.72% (p=0.000 n=10)
geomean                          10.78µ        9.299µ       -13.71%

                              │  before.txt   │              after.txt               │
                              │     B/op      │     B/op      vs base                │
Label/base=2/numItems=10-8       2.062Ki ± 5%   1.508Ki ± 4%  -26.89% (p=0.000 n=10)
Label/base=2/numItems=100-8      23.73Ki ± 2%   21.74Ki ± 2%   -8.36% (p=0.000 n=10)
Label/base=2/numItems=1000-8     294.3Ki ± 0%   325.1Ki ± 0%  +10.45% (p=0.000 n=10)
Label/base=8/numItems=10-8        1224.0 ± 0%     760.0 ± 0%  -37.91% (p=0.000 n=10)
Label/base=8/numItems=100-8      13.97Ki ± 0%   10.15Ki ± 1%  -27.35% (p=0.000 n=10)
Label/base=8/numItems=1000-8     144.0Ki ± 0%   119.0Ki ± 1%  -17.37% (p=0.000 n=10)
Label/base=32/numItems=10-8       1112.0 ± 0%     712.0 ± 0%  -35.97% (p=0.000 n=10)
Label/base=32/numItems=100-8    12.062Ki ± 0%   8.242Ki ± 0%  -31.67% (p=0.000 n=10)
Label/base=32/numItems=1000-8   120.74Ki ± 0%   83.27Ki ± 0%  -31.03% (p=0.000 n=10)
geomean                          15.60Ki        11.84Ki       -24.14%

                              │ before.txt  │              after.txt              │
                              │  allocs/op  │  allocs/op   vs base                │
Label/base=2/numItems=10-8       55.00 ± 4%    36.00 ± 3%  -34.55% (p=0.000 n=10)
Label/base=2/numItems=100-8      457.0 ± 1%    418.0 ± 1%   -8.53% (p=0.000 n=10)
Label/base=2/numItems=1000-8    4.561k ± 0%   5.016k ± 0%   +9.96% (p=0.000 n=10)
Label/base=8/numItems=10-8       38.00 ± 0%    17.00 ± 0%  -55.26% (p=0.000 n=10)
Label/base=8/numItems=100-8      339.0 ± 2%    245.0 ± 0%  -27.73% (p=0.000 n=10)
Label/base=8/numItems=1000-8    2.929k ± 0%   3.072k ± 0%   +4.88% (p=0.000 n=10)
Label/base=32/numItems=10-8      35.00 ± 0%    14.00 ± 0%  -60.00% (p=0.000 n=10)
Label/base=32/numItems=100-8     314.0 ± 0%    181.0 ± 0%  -42.36% (p=0.000 n=10)
Label/base=32/numItems=1000-8   3.093k ± 0%   2.041k ± 0%  -34.01% (p=0.000 n=10)
geomean                          375.1         257.6       -31.33%

This change is part of the following stack:

#3 ◀

Change managed by git-spice.


VSCode and intellisense are broken and unstable

VSCode Version: 1.35.5
OS Version: Linux Elementary OS

Steps to Reproduce:
1.Open a TS project with VSCode.
2.Either:
*Remove the node_modules folder
*Reinstall/delete/add a new npm package
*Use npm/yarn link
3.Gets a bunch of errors that do not disappear even if you reinstall everything back.
Somehow VSCode bugs out and gets stuck at a previous state. In the case of npm link sometimes it doesn't recognize the package being added.
When that happens, in most cases, TS server shuts down and any Intellisense feature is infinitely "Loading..." when required.
Though, sometimes things work out when I trigger autocomplete and everything is back to normal.
I have to restart VSCode or the TS Server all the time to update its state.
Also, any change to your npm package isn't the only trigger for this behavior. It just seems that VSCode cannot reliably react to any kind of file changes.
It's been like that since forever as far as I recall, however, the last few updates just made things worse I guess. I've never had a 100% reliable TS experience.
With the latest update, syntax highlighting stops working randomly too.
Does this issue occur when all extensions are disabled?: Yes it does.

@sheetalkamat I suspect this is related to the file watcher. Simple repo:

Create a new angular project ng new app
Open in VS Code and open a ts file
Now delete node_modules
Intellisense hangs for ~a minute
Now npm install
Another hang

In the larger VS Code repo, doing these steps can cause the server to get into a state where it never seems to finish loading

Hi, I too seem to have this issue. Open a newly created Angular repo in VS code, don't know if this is related to any extennsion. Intellisense doesn't seem to work at all. All I get is "Loading...". Sometimes is works randomly, other times it doesn't all. This is a productivity killer and it is very annoying.

@sheetalkamat If that can help, I found that refreshing the tsconfig.json (ie, deleting a character, undoing and saving the file) makes TS works again like usual.
But it's still annoying to do so every time you yarn add something and TS breaks.
@venky76v When that happens, do you see the "Initializing TS/JS languages features" at the bottom-left in the status bar? If so then that's normal that Intellisense doesn't work right after opening an Angular repo because VSCode needs to initialize the TS features first.

we have this issue as well. changing some types lead to a „stuck“ typescript experience. changing between integrated and workspace version (basically restarting typescript) fixes the issue until it breaks again.

@sheetalkamat If that can help, I found that refreshing the tsconfig.json (ie, deleting a character, undoing and saving the file) makes TS works again like usual.
But it's still annoying to do so every time you yarn add something and TS breaks.
@venky76v When that happens, do you see the "Initializing TS/JS languages features" at the bottom-left in the status bar? If so then that's normal that Intellisense doesn't work right after opening an Angular repo because VSCode needs to initialize the TS features first.

Hi, As soon as I open a Angular repo, I see the initializing JS/TS features on the status bar. After this the message is gone. Now opening a ts file, say app.component.ts file and type this. + control + spacebar, all I see "Loading..." like so below:

If I leave the VS window and come back to it after a few minutes, like write this reply and then come back and hit control + space bar, I see the intellisense working. This is a productivity killer and it also kills your flow of throught, as well the behavior being totally inconsistent.

Hi, As soon as I open a Angular repo, I see the initializing JS/TS features on the status bar. After this the message is gone. Now opening a ts file, say app.component.ts file and type this. + control + spacebar, all I see "Loading..." like so below:

I see. This is not really the issue I am describing. I suggest you look into others issue. I recall saying something similar.
The problem that @OneCyrus and I are facing is that Typescript breaks when a file changes.
Just right now I cloned a git monorepo. Naturally, the packages were not installed, so Typescript was signaling 'modules not found' left and right. Even after I ran yarn and lerna to bootstrap and link all the packages in the repo Typescript was still stuck at its previous state. I again had to reload the TS server.

Not 100% sure if related - but seems to fit -, but I have been finding that ts server and tsc sometimes will just stop listening for file changes, as in, if you make a change to a file, it doesn't get picked up to trigger a incremental compilation.

This seems to be Linux and potentially macOs specific issue and result of https://nodejs.org/dist/latest-v10.x/docs/api/fs.html#fs_inodes inode watching. Looking into fix for this issue. Thanks

I can confirm I have this issue and I can agree it's related to file watching. I'm using macOS 10.14.6.

https://github.com/microsoft/TypeScript/pull/35615#issuecomment-564263744 is the fix for this. Feel free to try it out and provide feedback. Thanks


fix reinstall target and backup config if present

also add default target and remove code duplication in
install/reinstall targets. reinstall target was not in sync with install
target and caused me some trouble on finding issues with ykfde-suspend
which has been renamed.

Thx, I didn't test reinstall target.


Issue in ScreenObserver

In the didPop function inside the ScreenObserver is an issue.
the code:
  @override
  void didPop(Route<dynamic> route, Route<dynamic>? previousRoute) {
    final name = route.settings.name;
    if (name != null) {
      screenStreamController.add(name);
    }
  }

From the documentation from didPop:
The Navigator popped route.
The route immediately below that one, and thus the newly active route, is previousRoute.
Copied from NavigatorObserver.

Therefore the code should be:
  @override
  void didPop(Route<dynamic> route, Route<dynamic>? previousRoute) {
    final name = previousRoute.settings.name;
    if (name != null) {
      screenStreamController.add(name);
    }
  }

previousRoute is the new route, and therefore that is the name which should be tracked, not route.

Hi @mschlegelaware thank you for your report, we start looking into this.


The project team

I am also trying to reproduce this work. I'm surprised that you're also doing this. Would it be convenient for you to provide the training code for SGG? I will try to complete and improve it based on your code. You can add me to this interesting project. Best wishes.

@yisun98 Hey! I'm happy to hear that. I'm currently refactoring my code (it was so awful) and rebased it to this repo: https://github.com/xXCoffeeColaXc/WeatherConverter
Under seg_model you can find the current segmentation model, which will be used in SGG. Keep on eye on it!


Performance tuning

Reworked both the A Priori Algorithm and ECLAT algorithms to operate faster. Depending on the dataset and parameters, I'm seeing:

20-40% improvement in A Priori speed
30-50% improvement in ECLAT speed.

A Priori Changes:
Added transaction database subsetting
In the old implementation, each child node search was also calculating support for all columns that don't meet the minimum support threshold. With this change, the algorithm now only calculates support for the base nodes in each iteration.
Added hashing and deduplication of rules during generation
A Priori tends to create redundant rules where the LHS will have the same items in a different order. This can be solved with sets or bitsets, but converting to and from these to vectors to slice the transactions matrix is very slow.
The solution used here keeps the vector architecture for fast matrix slicing, but removes redundant rules at each level of calculation. This prevents further rule generation based on the redundant rules, and it provides greater resource savings the greater maximum length of the rules being generated.
ECLAT Changes
Enabled multithreading
Enabling multithreading in ECLAT is tricky because of its recursive nature. This approach multi-threads at the first equivalence class, keeping the threads entirely independent.
This speeds up ECLAT significantly, but the amount of computation each thread does is very uneven due to the search pattern in ECLAT. Adding additional cores will see diminishing returns on speed gains.
Testing Changes
Using column hashes for testing
This is not so much a performance thing, but it does clean up the testsets.jl file significantly.

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
:information_source: You can also turn on project coverage checks and project coverage reporting on Pull Request comment
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Is master working ??? Mine is just walking and walking

Expected Behavior
Actual Behavior
Steps to Reproduce
Other Information
OS:
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)
Python Version: (run 'python -V' and paste it here)

No. Niantic just changed their APIs and forced all users to switch to the last update. Old APIs are not working anymore.

Seems like Nautica dev-team did something with their API.
See here #2546


vm deletion graceful shutdown

Currently scaling vm's down will kill them. This is really bad since it can easily result in data loss.
I use this method to reinitiate the whole cluster / update it using IaC.
This pr will try a graceful shutdown first, like it is handled with QemuVmUpdate and fallback to stop.
Note: if qemu guest agent is not installed in the vm but enabled in terraform this will result in a freeze of 300 seconds, sadly this has not been patched in proxmox upstream.
Instead we could also add a resource option to enable graceful shutdowns manually but IMHO this should be the default.

sorry, i miss the point in gracefully shut down a vm that will be deleted

sorry, i miss the point in gracefully shut down a vm that will be deleted

if it uses local file storage only yes in theory it makes no sense.
But with IaC/Kubernetes and many other setups you mount network storage as persistent storage.
Terraform is exactly designed for this and graceful shutdown on delete is done in other providers like ESXI/vSphere, so I would expect it to be the same with Proxmox.

I am also of the opinion that a gracefully shut down makes no sense. It makes the deletion process slower and that for a VM that you delete anyway.

It takes like 10-20 seconds I don't see how this is a problem.

I also run Rancher RKE2 with this Terraform provider. And the step is to remove the Kubernetes cluster before deleting and then to execute the destroy.

Same goes for down scaling e. g. 5 to 3 nodes. In that case you don't delete the whole cluster and k8s automatically redistributes the workload. There shouldn't be any other mandatory steps needed with Terraform apply.
I'm fine with introducing a provider option for example:
provider "proxmox" {
  # reducing resource count will do a graceful shutdown
  # of running instances instead of hard stop
  scale_with_graceful_shutdown = true
}

But this should still considered to be the default (in next minor/major) or at least we need to add a warning in the docs that data loss is likely to happen with down scaling.

added provider option which defaults to old behavior

added provider option which defaults to old behavior


feat: better error reporting with wrong use of unwrap

Feature Request
Describe the Feature Request
I have a simple piece of code where I made an error:
    pub fn foo() -> ContractAddress {
        0x3240581234501345134513451341345134512451234521.try_into().unwrap('no')
    }

I should have used except instead of unwrap, made the error while copy-pasting stuff and generally focusing on fixing something else. It took me a while to spot the mistake for two reasons.
This is how the error is reported by the compiler:
error: Wrong number of arguments. Expected 1, found: 2
 --> /Users/m/projects/foo/src/constants.cairo:87:9
        0x3240581234501345134513451341345134512451234521.try_into().unwrap('no')
        ^**********************************************************************^

And in VSCode:

Describe Preferred Solution
None of the hints above pinpoint the error on the wrong use of unwrap. Quite contrary, they mislead me.
It would be better if the red squiggly lines were only under the unwrap('no') part of the code and if the error coming from the compiler would look something like this:
error: Wrong number of arguments. Expected 0, found: 1
 --> /Users/m/projects/foo/src/constants.cairo:87:9
        0x3240581234501345134513451341345134512451234521.try_into().unwrap('no')
                                                                   ^***********^

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

[ ] Yes
[x] No

Moving it to be on the actual arguments - so for any case it would point to something more inner in a consistent manner.


ft2build.h in Void Linux misbehaving

i get a " /usr/include/X11/Xft/Xft.h:39:10: fatal error: ft2build.h: No such file or directory
#include <ft2build.h>"
message when compiling st in Void Linux. All dependencies are met and ft2build.h is clearly visible in  "/usr/include/freetype2/ft2build.h".
What does this mean?

Nevermind, after a while i've noticed that i hadn't installed pkg-config, oh boy.
Works like a charm now.


Disaster Tweets Sentiment Analysis

Pull Request for DL-Simplified 💡
Issue Title :

Info about the related issue (Aim of the project) :  The goal of the project was to
predict if the given tweet is about a real disaster or not. If so, predict a 1. If not, predict a 0.
Name: Mehak
GitHub ID: https://github.com/mehak1309
Email ID<EMAIL_ADDRESS>Idenitfy yourself: (Mention in which program you are contributing in. Eg. For a JWOC 2022 participant it's, JWOC Participant) GSSOC 2023

Closes: #293
Describe the add-ons or changes you've made 📃
I have completed my project.
Type of change ☑
What sort of change have you made:

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Code style update (formatting, local variables)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested? ⚙
Describe how it has been tested
Describe how have you verified the changes made
Checklist: ☑

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added things that prove my fix is effective or that my feature works.
[x] Any dependent changes have been merged and published in downstream modules.

@mehak1309 any updates on this pull request?

@abhisheks008 I had exams. Only hyperparameter tuning is left for 1 model. I will give it by tomorrow. Thanks.

@mehak1309 thanks for the update. No issues.

I have updated the files.


Refactor Azure Cloud Explorer Contribution

Updates the Azure contribution the Kubernetes extension's Cloud Explorer to be based on the common Azure subscription node UX, making sign-in, subscription selection, and visualization consistent across the various Azure-based explorers.
Should help with #5.
Sign in UX:

Select subscriptions UX:

Enumeration and filter UX:

Selecting the filter (funnel) button will display the common Azure subscription selection/filter list. Changes will be immediately reflected in the Cloud Explorer.

Great stuff - really appreciate this.


How to use the train.py finetuning the pre-trained MPT-7B?

It seems like we need to perform the pre-trainning process to get the checkpoint file before we can fine-tuning the MPT model.
1b_local_data_sft.yaml mentioned that we have to replace the load_path with our own checkpoint path.
Can I use the one (.bin) in Hugging Face as the pre-trained model loading file?

Hi @metacarbon, I have a PR here which hopefully addresses the issue you are running into. Basically, load_path is for Composer checkpoints; there is a different syntax for models loaded from the HF Hub in HF format. tl;dr use this yaml|
However,
  config_overrides:
    attn_impl: triton

won't work until #90 is merged in

@metacarbon The PR mentioned above has gone through and should make it easier to finetune from the pretrained MPT-7b model on Hugging Face.
Do you have more questions in this area? If not, I'll close the issue.

@alextrott16  Recently, I don't have time to test it. Thanks for the PR I know how to fine-tuning MPT with HF. Thank you all of you for the support!

Happy to be of service :)


Surface Azure Linux scheme forwarding scenario for 2.2

https://github.com/aspnet/AspNetCore.Docs/issues/9549#issuecomment-499158562

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e548cd16-b06c-5802-a1a7-c627167857ae
Version Independent ID: c48abb08-bea3-dcff-c067-2edf5dc9b3a6
Content: Configure ASP.NET Core to work with proxy servers and load balancers
Content Source: aspnetcore/host-and-deploy/proxy-load-balancer.md
Product: aspnet-core
Technology: aspnetcore-hostdeploy
GitHub Login: @guardrex
Microsoft Alias: riande

This was fixed by https://github.com/aspnet/AspNetCore.Docs/pull/12740.


[Technical] Check if xapi statements are send, when the student does not click on Finish

Technical
Check if xapi statements are send, when the student does not click on Finish in the h5p-learning element.
Private Zenhub Image
Definition of Done

[ ] All acceptance criteria are met
[ ] The implementation of the User Story has been successfully accepted by the Product Owner
[ ] The implementation is in GitHub
[ ] A code review has been performed (or created in pairing program)
[ ] Code conventions are followed
[ ] Unit test coverage must be greater than 90%
[ ] All tests must have passed
[ ] Technical documentation created (Feature documented in GitHub Wiki)
[ ] UML class diagrams and component diagrams created and up-to-date
[ ] Documentation in realization created (source code)
[ ] Changelog created (Clear description in merge request)
[ ] There are no known bugs
[ ] Rendering behaviour is optimized

XAPI Statements are not send, if a "Finish" Button exists and is not clicked.


About The Message System of BetterTeams plugin [BUG]

What is the bug?
I have noticed some issues related to the Message system. It seems that when I just installed the Plugin on my server, the message.yml file wasn't created properly. I'm not sure if that's the right way to say it, but the file should have loaded all the messages from GitHub or something. However, it didn't load completely and some messages were missing. These missing messages caused the server console to continuously display missing message notifications. And I noticed that the missing messages are usually in the help section. It's only when a user uses the /team help command that the missing messages load and appear in message.yml.
Expected Behaviour
I hope BetterTeams should check again the message code
How to Reproduce
And I am also the translator for this Plugin, which is how I discovered the issue. In fact, when I translated this plugin, I copied the message.yml file and then edited the content of each message. After finishing the translation, I tried using my translated file. But it reported missing messages in the server console, so I tried deleting the message.yml file and then let the plugin automatically download the message file again. However, now the console says that the message.yml file is missing some messages. I found it very confusing. Then, I tried using the team help and teama help commands to check if the plugin was missing those messages and if it would report errors. After using those commands, I went back to VS Code to check the file and saw that there were new messages at the bottom of the file (specifically at the end of the help section).
Error message
[17:53:10 INFO]: [BetterTeams] Enabling BetterTeams v4.9.4
[17:53:10 INFO]: [BetterTeams] Checking if the file vi.yml is up to date
[17:53:10 INFO]: [BetterTeams] ==================================================================
[17:53:10 INFO]: [BetterTeams] File is not updated, adding values under the following references:
[17:53:10 INFO]: [BetterTeams] - help.warps
[17:53:10 INFO]: [BetterTeams] - help.rankup
[17:53:10 INFO]: [BetterTeams] - help.tag
[17:53:10 INFO]: [BetterTeams] - help.delwarp
[17:53:10 INFO]: [BetterTeams] - help.chest
[17:53:10 INFO]: [BetterTeams] - help.pvp
[17:53:10 INFO]: [BetterTeams] - help.baltop
[17:53:10 INFO]: [BetterTeams] - help.list
[17:53:10 INFO]: [BetterTeams] - help.warp
[17:53:10 INFO]: [BetterTeams] - help.removeall
[17:53:10 INFO]: [BetterTeams] - help.claim
[17:53:10 INFO]: [BetterTeams] - help.remove
[17:53:10 INFO]: [BetterTeams] vi.yml is now updated to the latest version, thank you for using BetterTeams
[17:53:10 INFO]: [BetterTeams] ==================================================================
[17:53:10 INFO]: [BetterTeams] Checking if the file messages.yml is up to date
[17:53:10 INFO]: [BetterTeams] File is up to date

Output of /teama version

Additional Information
No response

I notice the log mentions you are using vi.yaml translations but your /teama version output does not mention it?

Also some improvements in the translation space are coming in the next update

I notice the log mentions you are using vi.yaml translations but your /teama version output does not mention it?

you mean the translation of /teama version output? I think at that time I changed the language to English so /teama version will appear in English, or because the vi.yaml file is missing the /teama version part so it will use English to replace the "key" part that is missing translation


#1057 Token registry graph-based lexer

Type of Change

[x] Enhancement (non-breaking change that affects existing code)
[x] Feature (non-breaking change that adds functionality)

Description
TBD
How the Changes Have Been Tested
TBD
Checklist

[x] I have performed a self-review of my own code
[ ] I have added tests that prove it is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Related issue number is linked in pull request title
[x] I have added documentation that describes my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have rebased my branch on top of the latest develop branch

Related Issue
Closes #1057

Remaining documentation to be added in #1041 (#748)


Comment gesture animation is initializing in incorrect "halfway" state

https://www.reddit.com/r/slide_ios/comments/a5dfrc/bug_some_posts_have_the_downvote_color_covering/

That is actually because the gesture failed halfway through and didn't remove the view

Fixed!


Microk8s exec cmd issue

Hi All i am facing microk8s kubectl exec cmd is showing error error: exec [POD] [COMMAND] is not supported anymore. Use exec [POD] -- [COMMAND] instead
See 'kubectl exec -h' for help and examples
how to fix thus issue any one help me on this
Building the report tarball
The report tarball inspection-report-20240916_124118.tar.gz

Same issue. Use kubectl directly


issue 180

Could you rebase your branch on latest main ?
We also ask that all commits are signed-off https://github.com/InseeFrLab/sugoi-api/pull/198/checks?check_run_id=2086570221.
And we check that the source format respects google guidelines (this can be changed with mvn spotless:apply)

@antoine-pasquale Will you have the time to work on this ?

Probably.


Fix code scanning alert - Missing rate limiting

Tracking issue for:

[ ] https://github.com/sadiqkassamali/pythonnplquery/security/code-scanning/2

fixing with
// set up rate limiter: maximum of five requests per minute
var RateLimit = require('express-rate-limit');
var limiter = RateLimit({
windowMs: 1601000, // 1 minute
max: 5
});
// apply rate limiter to all requests
app.use(limiter);


Can't run test app in Kali Linux .NET Core

I have followed some documentation online and installed the relevant files. Not sure why the test app can't run on Linux.
May I also know where should I set this export PATH=$PATH:$HOME/dotnet so I don't have to rerun it everytime? Thank you!
https://github.com/dotnet/core/issues/2590
/root/dotnet/sdk/2.2.301/NuGet.targets(121,5): error : Unable to load the service index for source https://api.nuget.org/v3/index.json. [/xxx/testapp/testapp.csproj]
/root/dotnet/sdk/2.2.301/NuGet.targets(121,5): error :   No such device or address [/xxx/testapp/testapp.csproj]

Hmm I think it was missing some dependencies just now. It is fixed.


nixos/network-interfaces: prevent failure when a network address already exists

The original code tests output of ip addr add to detect if a network adress already exists. The error message was changed in the past and the test no longer works.
The patch replaces ip addr add with ip addr replace. The new command replaces an existing address or creates a new one if there isn't any.
fixes #306841
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@GrahamcOfBorg test networking.scripted


feat: Added support for single-core applications and optional elf file

This PR includes support for not specifying the .elf file on operations that don't require it (eg. --list-devices) and for limiting the number of cores checked for session termination.
In this way it is possible to see defmt messages on single (or dual) core applications without the session terminating abruptly.
The flag --cores has been added to the CLI in order to specify the number of active cores.
NOTE: It was necessary to revert to v1.0.10 of AURIXFlasher and to version 8.0.5, otherwise the board was not being recognised (Shieldbuddy TC375)
resolves #36, resolves #11

NOTE: It was necessary to revert to v1.0.10 of AURIXFlasher and to version 8.0.5, otherwise the board was not being recognised (Shieldbuddy TC375)

We don't have the hardware to reproduce the issue. If this is also the case when using the AURIX Flasher tool without tricore-probe, it might be worth it to report this to Infineon.


Tests Cleanup

Updated the type checker to also check tests.
Updated all tests with type hints.
All tests should be tested in partial mode (strict in the future).
Stubs are now separate classes located in tests/Titon/Test/Stub.

Quick review @exonintrendo

Looks like failed build was just another race condition

Damn, thought I fixed all those. Hold on.


Feature Request: Mapped Computed Property Names

Search Terms
json
json mapping
mapped computed property names
Suggestion
Re-purpose computed property names to automatically handle mapping at build, but alias property as another name during development.
Today, let's say I use an API I don't control that yields the following:
{"d":"acb123","n":"Sample","s":"c"}
That's not terribly descriptive of what's contained. I could create an interface to represent this with the following:
interface Sample {
  d: string;  //ID
  n: string;  //Name
  s: State; //State enum (below)
}

enum State {
  Completed = <any>"c",
  Pending = <any>"p",
  Error = <any>"e"
}

Given that I can specify the actual values to expect in the enum, this will map right up when I just cast a response to the Sample interface without issue. But it's a pain to develop against this interface, because I constantly have to keep in mind which property name actually represents what. I'd much rather have an interface like the following:
interface BetterSample {
  id: string;
  name: string;
  state: State;
}

In order to get here, I have to add a mapping function and manually line up each of the properties on either end, which is error prone and requires maintenance should the shapes ever change.
I think the use of the computed property names nearly resolves this. Being able to do something like the following would be nearly ideal:
const id = "d";
const name = "n";
const state = "s";
interface BetterSample {
  [id]: string;
  [name]: string;
  [state]: State;
}

Unfortunately, it just barely misses the mark because in development, I still reference the name property as BetterSample.n instead of BetterSample.name as it's computed by the IDE. It'd be great to have this go one step further and defer computation of these property names until build instead of the IDE actually computing these.
Even better, it would be something like, eliminating the need for two lines for each property, and putting the mapped value closer to the property name itself.
interface EvenBetterSample {
  [id="d"]: string;
  [name="n"]: string;
  [state="s"]: State;
}

Use Cases
As described above, this would allow for trivial JSON mapping to interfaces of primitive types. Rather than try to do the same with decorators, or a mapping function, the JSON value would be clearly noted in the interface itself while still allowing the developer at dev time to have contextual knowledge of what the response values actually are.
Downsides to existing approaches
Mapping function
Still necessary for mapping to class instances or any more elaborate mapping, but especially for simple 1:1 maps, this takes a cumbersome and error-prone step out of the picture and leave it to TypeScript to simply emit the constant value in the output (as it does with the computed property names anyway). For anything that does require this more elaborate mapping, just opt out of using this altogether for that property and only have to map those complex objects - everything else is easily cast-able (as is currently done with JSON -> interfaces for like-name properties).
Decorators
Like the mapping, it's error prone around class instance mapping or something more elaborate (e.g. nested objects, handling serialization/deserialization, collections) adds complexity to the implementation.
Examples
As described above, given a JSON object:
{
  "d": "abc123",
  "n": "Sample"
  "s": "c"
}

It'd be great to be able to trivially develop against this with contextual property names at development time, but know that Typescript will actually use the API values at runtime with something like the following.
Option 1
Re-purpose computed property names, but configure to allow the constant name itself show in the IDE instead of the value of the constant.
const id = "d";
const name = "n";
const state = "s";

interface Option1 {
  [id]: string;
  [name]: string;
  [state]: State;
}

enum State {
  pending = <any>"p",
  completed = <any>"c",
  error = <any>"e"
}

Option 2
Put the mapping value in-line in the computed property name, then show the name of the constant in the IDE instead of its value.
interface Option2 {
  [id="d"]: string;
  [name="n"]: string;
  [state="s"]: State;
}

enum State {
  pending = <any>"p",
  completed = <any>"c",
  error = <any>"e"
}

Practical Example
At development time, I can trivially use this to map from an RXJS request in Angular:
this.myService.getData()
  .subscribe((data: Option2) => {
   //Do something with it, without further ado
 });

In practice, at development time, the properties would be trivial to use and self-explanatory, and at runtime, the build would map against the shortened values actually used by the API.
Mapping may be required for all sorts of different reasons. The written language used between the API and the consuming app may vary, the API may use shortened values as in the above, the casing may simply vary from app conventions - whatever the reason for the mapping, it'd be ideal if Typescript made the development experience simpler to use 1:1 mappings. This aligns with the design goals in numerous ways: it eliminates an opportunity for "magic string"-based errors, it imposes no run-time overhead and, with the use of something like Option2, would not cause a breaking change with current Typescript syntax.
Thank you for your consideration.
Checklist
My suggestion meets these guidelines:

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[X] This feature would agree with the rest of TypeScript's Design Goals.

In practice, at development time, the properties would be trivial to use and self-explanatory, and at runtime, the build would map against the shortened values actually used by the API

This is type-directed emit, so it's not something we would do.


Composable selectors

Griddle major version
1.9.0
Changes proposed in this pull request
This is a potential upgrade to the existing way selectors are created.
Why these changes are made
Selectors are currently limited in how they can be overridden, this change would make it possible to override any number of selectors without having to change the dependency selectors. In combination with this PR which changes all the built-in components to use the selectors on the context, this would allow for much more powerful overriding of selectors.
If this is a desirable feature, we need to have a discussion about how to make sure this isn't a breaking change, maybe this could be enabled by a flag on the Griddle component. Without a plugin using the new composableSelectors file, I believe this SHOULD be backwards compatible, would need to do some testing.
Are there tests?
Not yet, needs comments first

I will add some examples to storybook tomorrow to demonstrate how this works too

This is really great -- Going to spend some time going through this a bit but really promising and cool functionality! Thank you for adding this!

To clarify, the example story is a minimalist implementation of LocalPlugin?
Seeing your griddleCreateSelector, I have been toying with the idea of making it a drop-in replacement for createSelector. If it's given a selector as a dependency, it Just Works™; if it's given a string, it resolves the dependency. Have a look at https://github.com/shorja/Griddle/compare/m-composable-selectors...dahlbyk:refactor-743; the first two commits are essentially a squashed reimplementation of this PR.

Ok so I've been looking at your refactor, I really like the idea of a drop in replacement for createSelector that is able to adapt to whichever way it is called to replicate old behaviour. I have been working on a refactor to your refactor too.
The way it was implemented with the global selectors, all of the import style references to selectors are recreated every time they are called which prevents the use of the auto memoization feature that reselect provides. I haven't quite finished my refactor but it should prevent this from being a problem and also the globalSelectors shouldn't be necessary.
However, I am concerned with the implications of changing the dataSelectors over to use the new dependency style. I'm worried that this could introduce some confusing behaviour for existing users especially since 'hard' imported selectors could now start being overridden without them knowing why. This was my goal with the original design of having a separate composedSelectors file, though this will still provide the overriding selector behaviour on the context which may also be a breaking change for existing users.
So, I'm going to propose making a change to the way the core components, selectors, reducers, etc... are used. I'm going to try moving this 'core' functionality over to a plugin. Griddle will always load one 'baseline' plugin, and by default it will always load the 'core' plugin. Then we can implement a new plugin, that has all of the same features of the 'core' plugin but will use all of the new composability features. Existing plugin users should still be able to leverage new composability features if they choose to use them but they won't be automagically opted in. This will also allow developers to totally override the 'baseline' with their own so that they don't have a cumbersome overriding process. This gets pretty close to Griddle being just a component building framework but is still backwards compatible.
I'll put up a PR as soon as I can get it done.

I'm worried that this could introduce some confusing behaviour for existing users especially since 'hard' imported selectors could now start being overridden without them knowing why.

@ryanlanciaux and @joellanciaux, or other users, may disagree, but I'm not too concerned about people having taken hard dependencies on the selectors that have been exported thus far, because there hasn't been any way to inject dependencies until now. In other words, existing behavior can't change unless a new plugin/customization is added that uses this DI mechanism.
I do like the idea of thinking of the Griddle core behavior as a plugin; I am actually working on a branch that essentially takes that same view in refactoring how plugins are composed (#733). I will try to share that sooner rather than later, for your consideration.

@dahlbyk My concern is specifically with changing the dataSelectors to using the quoted versions and their interaction with the core code.
For example if a user had defined a custom selector in their plugin that had the same name as a dataSelectors one, the current behaviour would be that it would be overridden in the context object but of course all of the hard references to it would stay the same whereas if the dataSelectors are created with the new logic using quoted dependencies, the 'hard' references will be overridden and all of the core code will now use that new selector. I'm more concerned about all of the code that dev's didn't write magically behaving differently.
Though if we look at PR 740, adding the selectors to the context will also potentially cause unexpected behaviour for devs not familiar with any new composability features since that would ALSO make all the core code magically use any overridden selectors.
Sorry, I'm not trying to be contrarian, I'm just probably overly cautious about messing things up.

@dahlbyk Oh and yeah I would love to see your approach to a plugin style refactor for the core code.

@shorja check out https://github.com/GriddleGriddle/Griddle/pull/757. The work is a few months old, so doesn't account for new functionality, but the key piece is that the initializer essentially accepts the default reducers, components, selectors, etc. in the shape of a plugin: https://github.com/dahlbyk/Griddle/blob/65ff192e3d8cef77a7975d372a3752fa3aa7b650/src/index.js#L69-L86.

I too would like to see this functionality added!


Issue with using ng-transclude

I am in the process of migrating from
AngularJS 1.3.16 to 1.4.8
AnbularUI-Bootstrap 0.13.0 to 0.14.3
and I have come across the following issue:
I have a directive that dynamically creates tabs, transcluding html for each tab.
The application usage:
<dynamic-tabs >
        <grid ptp-id="{{tab.id}}"></grid>
</dynamic-tabs>

the tab variable above is created via an ng-repeat expression within the directive
The directive dynamic-tab template is as follows:

    <tabset>
        <tab ng-repeat="tab in vm.tabs track by $index"
                active="tab.isCurrentTab"
                select="selected(tab)">
            <tab-heading>
                {{ tab.name }}
             </tab-heading>

        </tab>
    </tabset>

Prior to 0.13.2 the above works.
From 0.13.2 the tab variable within the application usage is no longer available and is undefined.
I believe the commit  20047577b0e7fbf20f18f815e3e74aee22ac712d where the use of the compile function was replaced with a linking function is the cause.
I have reverted that single change and the issue is resolved in my code and the unit tests in angular-ui/bootstrap did not break.
I took a look at creating a unit test to cover this particular use case of transclusion but it did not feel correct to add it in the existing test code, since it more integration and requires a directive created using tabs etc. We can take that off line.
I issued a PR #5160 which reverts that change, but while fine tuning this text realized the revert is not the answer due to it actually closing #4061 (which I hadn't noticed)
So the question becomes is this a bug or the new expected behaviour and if so any suggestions on how to achieve this behaviour.
Regards
Aidan

Can you post a reproduction in Plunker? This is to assist with debugging.

Reproduced here. To see the issue change the ui-bootstrap version from 13.1 to 13.2.

Hi
We are now considering upgrading to 1.3.
Curious as to the current thinking on this issue.
Regards
Aidan


Hibernate Until

[ ] Handle mouse events (e.g. right-click)
[ ] Handle keyboard events (e.g. arrow keys)

The keyboard events can probably be handled in the card script, but the mouse events are going to be a problem.

The expansion/collapse commands would allow the arrow keys to be used to fold or unfold.


General inconsistency considering Virtual Machine capabilities.

While browsing through a lot of virtual machine series across the whole series list, I've found a lot of inconsistencies across different pages and series.
For example, on this page, there is a mention of the Ultra Disks inside the text. But it is not in the list where all other capabilities are listed.
Example:

If we go and look a bit further to for example one of the few that actually has it inside the list: NVv3-series:

Same for example DCsv3 and DCdsv3-series

Here CPU and base all-core frequency are added.  Even the ultra disks etc.,..
Another thing I noticed on this page: DCasv5 and DCadsv5-series
The capabilities are then formatted totally different as this:

My question:
Is there a specific guideline on what how capabilities are showed in the list or what capabilities are shown.  If there is no guideline, maybe a quick basic list can be setup and can be applied to all these pages to generate one single consistent documentation.
If we can come to a guideline or some basics, I'll gladly make a PR to fix these inconsistencies to help me and hopefully a lot of other persons searching through some specific capabilities in these pages.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b040274d-e9e8-5ede-7ffe-2858dfeced77
Version Independent ID: 681ed815-340e-0e50-2634-a7b29e3604a3
Content: Ddv5 and Ddsv5-series - Azure Virtual Machines
Content Source: articles/virtual-machines/ddv5-ddsv5-series.md
Service: virtual-machines
Sub-service: vm-sizes-general
GitHub Login: @joelpelley
Microsoft Alias: joelpell

@vanwinkelseppe
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@joelpelley
Can you please check and add your comments on this doc update request as applicable.

@VikasPullagura-MSFT Thanks!
Maybe one thing to add globally to all virtual-machines/svc. I've taken an export of all VM properties and attributes and a lot of small inconsistencies have shown:
Premium Storage Caching / Premium Storage caching
Memory GiB / Memory (GiB) / Memory: GiB
Max data disks / Max Data Disks
GPU memory: GiB / GPU Memory: GiB
...

These are just some inconsistencies I've noticed with one eye.

We have been working on ensuring consistency and since this issue is a bit old, I am not sure if there are still problems. I will close out for now but if you still have questions, just let me know.
#please-close


add Pac4j HTTPPostSimpleSignEncoder implementation

Implementing HTTP Post Simple-Sign protocol, inspired from Pac4jHTTPPostEncoder but extending directly openSAML class HTTPPostSimpleSignEncoder.

Overall, it looks good.
Yet, there are a few things to fix:

there are a few comments to address before the merge
you need to submit a similar PR for the master
the documentation must be updated, regarding the release notes: https://github.com/pac4j/pac4j/blob/master/documentation/docs/release-notes.md and the SAML support itself: https://github.com/pac4j/pac4j/blob/master/documentation/docs/clients/saml.md
the build must be successful (remove the useless imports)

Thanks.


Mark dataset files as pest files

Pest test files have a pest logo, however dataset files does not.
I think we would benefit from them also having a logo, so we easily can see that this file is associated with pest.
For this we need a new logo to indicate that the file is a pest dataset file.

This is IntelliJ's rules about icons https://jetbrains.design/intellij/principles/icons/

@caneco would you be up for designing a new icon? We need an icon for the pest dataset files, both for the dark and light mode 👍

@caneco would you be up for designing a new icon? We need an icon for the pest dataset files, both for the dark and light mode 👍

Just implemented it so the icon is actually used 👍 Thanks!


Archetype doesn't render within the grid

I have create a document type "carousel" added carousel Archetype datatype, hooked up the DTGE. Archetype doesnt get rendered, all other element do.

Guess was a cache issue!
Great package guys :)


Make the title box mandatory for a save to take place.

This should mean we don't end up with a bunch of blank titles in the load drop down.

resolved in eardkdw/reportgen


No Callback on Replication Change Listeners for Errors (401)

Hey there guys,
Working on a project at the moment where the flow of UI and sync execution is dependent on whether or not a user has a valid set of credentials and is authenticated against our back end.
As of now, it seems that the Replication change listener does not fire off its changed(ChangeEvent event); callback on registered listeners for errors.
Our base is off a direct pull from master branch as of March 1, 2015.
An example execution:
//Listener registration
for (Replication r : replicators) {
	...
    r.addChangeListener(this);
    r.start();
}

// Password for authentication target is changed
[...]
[...]
[...] W/Sync﹕ com.couchbase.lite.replicator.PullerInternal@425f39a0: starting ChangeTracker with since=107857 mode=OneShot
[...] W/Sync﹕ com.couchbase.lite.replicator.PullerInternal@425f39a0: started ChangeTracker com.couchbase.lite.replicator.ChangeTracker@42a89d98
[...] E/ChangeTracker﹕ com.couchbase.lite.replicator.ChangeTracker@42a89d98: Change tracker got error 401
[...] W/ChangeTracker﹕ com.couchbase.lite.replicator.ChangeTracker@42a89d98: Change tracker calling changeTrackerStopped, client: com.couchbase.lite.replicator.PullerInternal@425f39a0
[...] E/Sync﹕ Change tracker stopped during continuous replication
[...] W/Sync﹕ [fireTrigger()] => WAITING_FOR_CHANGES
[...] W/Sync﹕ com.couchbase.lite.replicator.PullerInternal@425f39a0: starting ChangeTracker with since=107857 mode=OneShot
[...] W/Sync﹕ com.couchbase.lite.replicator.PullerInternal@425f39a0: started ChangeTracker com.couchbase.lite.replicator.ChangeTracker@426ed698
[...] E/ChangeTracker﹕ com.couchbase.lite.replicator.ChangeTracker@426ed698: Change tracker got error 401
[...] W/ChangeTracker﹕ com.couchbase.lite.replicator.ChangeTracker@426ed698: Change tracker calling changeTrackerStopped, client: com.couchbase.lite.replicator.PullerInternal@425f39a0
[...] E/Sync﹕ Change tracker stopped during continuous replication
[...] W/Sync﹕ [fireTrigger()] => WAITING_FOR_CHANGES
[...] W/Sync﹕ com.couchbase.lite.replicator.PullerInternal@425f39a0: starting ChangeTracker with since=107857 mode=OneShot
[...] W/Sync﹕ com.couchbase.lite.replicator.PullerInternal@425f39a0: started ChangeTracker com.couchbase.lite.replicator.ChangeTracker@42597e90
[...] E/ChangeTracker﹕ com.couchbase.lite.replicator.ChangeTracker@42597e90: Change tracker got error 401
[...] W/ChangeTracker﹕ com.couchbase.lite.replicator.ChangeTracker@42597e90: Change tracker calling changeTrackerStopped, client: com.couchbase.lite.replicator.PullerInternal@425f39a0
[...] E/Sync﹕ Change tracker stopped during continuous replication
[...]  W/Sync﹕ [fireTrigger()] => WAITING_FOR_CHANGES
[...]
[...]
// No callbacks are fired for the above events

Which version are you running?  (please see https://github.com/couchbase/couchbase-lite-android/blob/master/CONTRIBUTING.md)

Whoops - my mistakes. Thanks for the link to that. Edited original:
Our base is off a direct pull from master branch as of March 1, 2015.

Hey there folks! Just checking in to see if there is an update on this. Any word on being able to reproduce this, or is it proving tricky? Any way we can help?
Thanks!

Hi @tikimcfee,
Sorry, we could not look into this issue yet. We will try to fix this as soon as possible.
Thanks!

No worries there - thanks for the update! Just let us know if we can help in any way.

Hi @tikimcfee,
Thank you very much for your patience.
Replicator of CBL Android/Java calls callback for HTTP 401 Error. But problem is it is not developer friendly way (not obvious).
In case HTTP related errors occurs in the replicator, the replicator creates an instance of org.apache.http.client.HttpResponseException with setting HTTP status code and message, and set it in ChangeEvent.error, and calls Replication.ChangeListener.changed(Replication.ChangeEvent). You can retrieve error codes like below sample.
Sample code
    @Override
    public void changed(final Replication.ChangeEvent event) {
        if(event != null) {
            Log.e(TAG_REPL , event.toString());
            if(event.getError() instanceof HttpResponseException){
                HttpResponseException ex = (HttpResponseException)event.getError();
                Log.e(TAG_REPL, "HTTP Error: " + ex.getStatusCode() + ": " + ex.getMessage());
            }
        }
    }

Entire sample code
https://github.com/hideki/couchbase-lite/tree/master/test/Issue540
I hope this helps you.
Thanks,
Hideki

Hi all,
I use version 1.1.0 via gradle. @hideki's sample code works only if app pushes change to server.
For example, I create user "foo" with password "bar" and login with this in ToDoLite sample app. I create new task in list. After sync I change user password via REST API and change task in Sync Gateway /_admin. I see many "ChangeTracker: com.couchbase.lite.replicator.ChangeTracker@42b16590: Change tracker got error 401" in logcat but unautorized callback is not called. It's called only if I make some changes in app.

Hi @anisart,
Could you please create new ticket for authentication issue with changing password?
Thanks a lot!


Reinstate libllvm-c{maj} as part of llvmdev

The removal in b4501ac did not take effect, and following through would
require clobbering CMake metadata (as otherwise the targets aren't present),
see #297 for attempted implementation and discussion.
This reverts commit 55b5f72153c96186b3039c8416c1414d532bb9b1.
This reverts commit b4501ac8de4cea3fc217b9157198e0e7350fd192.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

ℹ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12038787287. Examine the logs at this URL for more detail.

Hi! This is the friendly conda-forge automerge bot!
I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!


docs(readme): fix shield images in readme

Issue #602
Fixed stars, issues and license badges on the repo readme

Looks good, lets @leeenglestone  review it.


Enhance the TypeHints to return actual Models and not ormar.Model

As described in #111 QuerySet methods should actually return inferred Model subclasses and not the main ormar.Model.
Since I am not an expert in complex python typing any help appreciated.

Yes, great library, but can we please have a release that fixes this issue? Hopefully it also works for objects.get()

There is already PR #132  that should fix all objects.method() calls, which is not all that is to fix, but the most common calls should be handled.

Thanks - is that available on pip?
On Tue, 23 Mar 2021 at 8:48 AM, collerek @.***> wrote:

There is already PR #132 https://github.com/collerek/ormar/pull/132
that should fix all objects.method() calls, which is not all that is to
fix, but the most common calls should be handled.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/collerek/ormar/issues/112#issuecomment-804595034, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIUCOBQYLQ2CF2LBY3ONLTTFAFQBANCNFSM4YAG2KDQ
.

If you mean the PR, not yet, need to finish the docs and will merge and publish this probably today.
As of now you can install from source (gh branch) I guess.

Awesome - Love it!
I think Model.objects.get() should return an optional instead of raising a NoMatch - do you agree @collerek ? If so I can do a PR for that.

@aliakhtar As of now I prefer the exception, since None is a perfectly valid return type, especially for aggregated functions like max or min. Without exception you don't know if it's an actual value from the database or there is no match for your query criteria.
Following pep8: Explicit is better than implicit, and for me returning None where there is no record in db with regard to ORM is kind of an implicit error silencing, and it makes testing and debugging more difficult (did I make a typo and there is no record or something was saved in a wrong way and the data is corrupted etc.)
If you don't like it you can very easily write a decorator/wrapper/helper that will silence this error and return None, but other way around (getting to know if it's db value or error) would be pretty hard without subclassing and overwriting implementation (which of course you can also do).

@aliakhtar that's not so simple as they rely on the same exception :)
Moreover this would be a breaking change that would have to wait for next bigger release, to add even more I like the exception approach more and there is quite some amount of users that do too.
But since it's not the first time someone asks me for this functionality I see a place for this but more like a setting then a permament change. I can add a setting on Model's Meta class (that can be easily shared by all models through BaseMeta approach if you use one database only (check best practices in docs)), something like exception_on_no_match=True that you can change to False.
Can you please open an enhancement issue for this?

What about a new method called get_if_exists with the type signature to
return optional instead? Happy to send a PR for it.
P.S I have a deadline to meet but the bug I mentioned in my other issue is
stopping me.. none of the select queries are working
On Tue, Mar 23, 2021 at 7:50 PM collerek @.***> wrote:

@aliakhtar https://github.com/aliakhtar that's not so simple as they
rely on the same exception :)
Moreover this would be a breaking change that would have to wait for next
bigger release, to add even more I like the exception approach more and
there is quite some amount of users that do too.
But since it's not the first time someone asks me for this functionality I
see a place for this but more like a setting then a permament change. I can
add a setting on Model's Meta class (that can be easily shared by all
models through BaseMeta approach if you use one database only (check best
practices in docs)), something like exception_on_no_match=True that you
can change to False.
Can you please open an enhancement issue for this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/collerek/ormar/issues/112#issuecomment-804965831, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIUCOH42RLNL2CDPRPW6TTTFCTB3ANCNFSM4YAG2KDQ
.

@aliakhtar - in 0.10.1 I added get_or_none()

That's awesome, and very fast. Thanks!
Almost wish you hadn't done it so I could send a PR 😛


Example 08_join_aggregation broken

Describe the issue linked to the documentation
On the stable and dev version of the doc, in the "Hyper-parameters tuning and cross validation" section of the 08_join_aggregation example, the GridSearchCV outputs scores are all nan.
This is due to the estimator failing during the CV.
ValueError: The feature names should match those that were passed during fit.
Feature names unseen at fit time:
- index__skrub_f3c63e8c__
Feature names seen at fit time, yet now missing:
- index__skrub_634644a2__

It appears that a column name change during one of the preprocessing steps of the pipeline between train and predict breaks the _check_feature_names .
Suggest a potential alternative/fix
I need more time to understand which preprocessor led to this column name change.

Here is a minimal reproducer:
>>> import pandas as pd

>>> from skrub import AggTarget

>>> df = pd.DataFrame(dict(a=[1, 1, 2, 2], b=[10, 20, 30, 40]))
>>> y = pd.Series([1, 2, 3, 4], name="b")

>>> transformer_1 = AggTarget(main_key='a', operation='mean')
>>> transformer_2 = AggTarget(main_key='a', operation='mean')
>>> out = transformer_1.fit_transform(df, y)
>>> out = transformer_2.fit_transform(out, y)
>>> out
   a   b  b_mean_target  b_mean_target__skrub_38870b21__
0  1  10            1.5                              1.5
1  1  20            1.5                              1.5
2  2  30            3.5                              3.5
3  2  40            3.5                              3.5

Note the name of the last column changes

>>> transformer_2.transform(transformer_1.transform(df))
   a   b  b_mean_target  b_mean_target__skrub_6f32724b__
0  1  10            1.5                              1.5
1  1  20            1.5                              1.5
2  2  30            3.5                              3.5
3  2  40            3.5                              3.5

>>> transformer_2.transform(transformer_1.transform(df))
   a   b  b_mean_target  b_mean_target__skrub_585a8372__
0  1  10            1.5                              1.5
1  1  20            1.5                              1.5
2  2  30            3.5                              3.5
3  2  40            3.5                              3.5

This is due to AggTarget calling left_join in transform with duplicate column names in the dataframe it joins:
https://github.com/skrub-data/skrub/blob/7341c669faafb4fdbc9d517987ecdd5599d080c3/skrub/_agg_joiner.py#L442
left_join is a stateless low-level function and it appends a random string to avoid errors due to duplicate names. To avoid the name changing at each transform, AggTarget should either forbid duplicate column names and raise an error (as the Joiner does) or store the column names during fit_transform and apply them at the end of transform.
we should also check if the AggJoiner has the same issue

skrub._dataframe._pandas.aggregate seems to be the function that inserts the "index" column in what becomes AggTarget.y_, probably during a groupby or pivot

Thanks for pointing this out @Vincent-Maladiere. Just checked -- have the same issue in the AggJoiner, as both are using _join_utils.left_join
>>> import pandas as pd
>>> from skrub import AggJoiner
>>> main = pd.DataFrame({
...     "airportId": [1, 2],
...     "airportName": ["Paris CDG", "NY JFK"],
... })
>>> aux = pd.DataFrame({
...     "flightId": range(1, 7),
...     "airportId": [1, 1, 1, 2, 2, 2],
...     "total_passengers": [90, 120, 100, 70, 80, 90],
... })
>>> agg_joiner_1 = AggJoiner(
...     aux_table=aux,
...     key="airportId",
...     cols=["total_passengers"],
...     operations=["mean"],
... )

>>> agg_joiner_2 = AggJoiner(
...     aux_table=aux,
...     key="airportId",
...     cols=["total_passengers"],
...     operations=["mean"],
... )

>>> out = agg_joiner_1.fit_transform(main)
>>> out = agg_joiner_2.fit_transform(out)
>>> out
       airportId  airportName  total_passengers_mean  total_passengers_mean__skrub_3c2fc647__
0                 1      Paris CDG                      103.333333                                                       103.333333
1                 2           NY JFK                        80.000000                                                        80.000000

>>> agg_joiner_2.transform(agg_joiner_1.transform(main))
       airportId  airportName  total_passengers_mean  total_passengers_mean__skrub_18f488d3__
0                 1      Paris CDG                      103.333333                                                       103.333333
1                 2           NY JFK                        80.000000                                                        80.000000


Add GLTF Anisotropy extension.

Implements https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Khronos/KHR_materials_anisotropy
Can be tested with:

https://github.com/DrX3D/glTF-Sample-Assets/tree/main/Models/AnisotropyStrengthTest
https://github.com/DrX3D/glTF-Sample-Assets/tree/main/Models/AnisotropyRotationTest
https://github.com/DrX3D/glTF-Sample-Assets/tree/main/Models/AnisotropyBarnLamp

This also fix a broken implementation of the aniso texture and implements the GLTF remapping of intensity by default.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/13894/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13894/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13894/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/13894/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13894/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13894/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13894/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/13894/merge#BCU1XR#0


how can i use test time augmentation in the config?

thanks!

Please read through the codes entirely and carefully, the Double Flip flag in config controls this action.


US028 Show info bar for in-processing Collection Exercise

Also changes success messages to use the new info panel style

 US028: Set and View 'Ready for Live' State of a CE [Large]

Codecov Report

Merging #72 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #72      +/-   ##
=========================================
+ Coverage    99.5%   99.5%   +<.01%
=========================================
  Files          24      24
  Lines         602     603       +1
=========================================
+ Hits          599     600       +1
  Misses          3       3

Impacted Files
Coverage Δ

...esponse_operations_ui/views/collection_exercise.py
97.93% <100%> (+0.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd5439e...20cc7b8. Read the comment docs.


Sorting task output alphabetically

When we run lm-eval, our output looks like this, where the tasks are scrambled every run:
hf (pretrained=meta-llama/Meta-Llama-3-8B), gen_kwargs: (None), limit: None, num_fewshot: 0, batch_size: 8
|    Tasks     |Version|Filter|n-shot|  Metric  |Value |   |Stderr|
|--------------|------:|------|-----:|----------|-----:|---|-----:|
|piqa          |      1|none  |     0|acc       |0.7960|±  |0.0094|
|              |       |none  |     0|acc_norm  |0.8069|±  |0.0092|
|arc_easy      |      1|none  |     0|acc       |0.8013|±  |0.0082|
|              |       |none  |     0|acc_norm  |0.7778|±  |0.0085|
|arc_challenge |      1|none  |     0|acc       |0.5026|±  |0.0146|
|              |       |none  |     0|acc_norm  |0.5341|±  |0.0146|
|winogrande    |      1|none  |     0|acc       |0.7309|±  |0.0125|
|sciq          |      1|none  |     0|acc       |0.9630|±  |0.0060|
|              |       |none  |     0|acc_norm  |0.9390|±  |0.0076|
|boolq         |      2|none  |     0|acc       |0.8113|±  |0.0068|
|hellaswag     |      1|none  |     0|acc       |0.6018|±  |0.0049|
|              |       |none  |     0|acc_norm  |0.7910|±  |0.0041|
|lambada_openai|      1|none  |     0|perplexity|3.0953|±  |0.0571|
|              |       |none  |     0|acc       |0.7557|±  |0.0060|
|openbookqa    |      1|none  |     0|acc       |0.3500|±  |0.0214|
|              |       |none  |     0|acc_norm  |0.4500|±  |0.0223|

This makes it difficult to compare different models, since the tasks must be in the same order. I understand that random sorting creates a bias toward alphabetically-earlier tasks, but the tradeoff would be worth it for an option, since we have to sort them anyway.

Hooray, thanks!