Wrong version output by elp

I download 0.15.3 linux build, https://github.com/WhatsApp/eqwalizer/releases/download/v0.15.13/elp-linux.tar.gz, and run version:
$ elp version
elp 0.13.18

yes,  - we forgot to manually bump the version before the GH release last two times. It would be fixed in the next release.


Count Sort Algorithm in C++

@keshavsingh4522 Can I work on this?

Can i work on this issue in c++ ?

Can you assign me this task?

Please Assign me this task .


Update yargs and line-reader versions

yargs and line-readers had some dependencies with multiple vulnerabilities.
Updated npm-shrinkwrap and package.json so versions without
vulnerabilities are used.

already done by
https://github.com/kiegroup/lock-treatment-tool/pull/20
https://github.com/kiegroup/lock-treatment-tool/pull/12


CasperCheck error

Unable to verify access to site network.  Exiting CasperCheck.
I doubled checked the variables and I simply cannot see what would cause this.  What line in the CasperCheck.sh file should I look at in order to determine what this might be tripping over.
Also, is this ONLY going to run AFTER a client has been logged into by a user?  I believe it should still run at the login window correct?
Thanks!
Mick

The relevant section for that error is the CheckSiteNetwork function:
https://github.com/rtrouton/CasperCheck/blob/master/script/caspercheck.sh#L75-L101
That function gets called here in the script:
https://github.com/rtrouton/CasperCheck/blob/master/script/caspercheck.sh#L393
CasperCheck runs when the system starts up and will execute whether or not someone is logged in, so it will run fine on a Mac which is sitting at the loginwindow.


Update flink 1.12

@nlu90 what should we do about this PR?

We are already on Flink 1.12.
Close it for now.


A question about bulk data

Hello Gildor,
I have a question regarding bulk data and additional packages. Do you know how to map the bulk data and the additional packages to the export table? I've been trying for a while and I only noticed that there are some bytes shared between the bulk data and the additional data but I can't map it to the export table. I'm trying to build MK11 extraction but I'm stuck at this point.
Thank you

Hi,
There are not "mappable". Bulk is always referenced by FBulkData structures (FByteBulkData etc) which are stored inside UObject's  data.

Can I find this reference inside the Export Table?

Are you sure you're familiar with object serialization in UE? Export table and import table are parts of package data, and knows nothing about UObject. Export table points to UObject data. Bulk therefore is pointed by UObject data, package knows nothing about that.

I'm not 100% familiar with UE, I'm learning, that's why I'm asking you. I was able to extract all the data I needed but I wasn't able to reference the bulk data. When I say "map" I mean point to.
Thank you for this information gildor!

Well, bulk is usually used for texture and audio data (unless you're talking about recent UE4 versions). So, just to get a reference to some bulk, you should

read package export table
find a Texture2D object there
seek package to the object's location
fully serialize (some people say "deserialize") UTexture2D object, with all mipmaps
mipmaps will contain FByteBulkData objects inside, which are "headers" for a bulk
when engine wants to get texture data, it will use that FByteBulkData structure to find a bulk file, seek to relevant position and read texture data from it.

I'd recommend reading UModel's code if you want more details. I see you're working on MK11 project - this game is not supported in UModel. However you'll get some ideas about how it works in UE3 and UE4.

Once you try to implement a few export classes like UTexture2D you will learn how bulk data works

@gildor2 thank you, very useful! I will look into that.
@FabianFG Will do, thanks.


[zh-cn] Modify Chinese translation

djust your priorities: 命名空间 > 名字空间
It has always been the case that namespace is translated as 命名空间
Signed-off-by: aimuz<EMAIL_ADDRESS>

https://github.com/kubernetes/website/commit/d38315f27b32b0b356c6b5ce7c2837118cfadccb

Hi, hope you have carefully read the en-zh localization glossary.
This PR involves 125 files that may cause many conflicts. This is not encouraged.
/hold

If you desire to change the term namespace, please modify the localization style page first. One suggestion is to open an issue to discuss further.
Now the glossary shows both are acceptable:
namespace，名字空间，命名空间

This is not a recommended use
/unhold

This is not a recommended use
/unhold

Boy, if some questions exist and need more discussion there, do not simply unhold.....

Sorry, too many files do create conflicts

The translation of namespace into "名字空间" or "命名空间" has been discussed a long time ago, and it was finally agreed that both can be used.
I have roughly calculated that in the translations of the whole site at that time, the usage of the two was basically half and half.
So, you can use "命名空间" in your localized PR, but not to change them all.

@howieyuen
Now the information on the web is based on 命名空间, and the 名字空间 has never been heard of, do you have a link to discuss it?
名字空间 He is a direct translation

https://www.google.com/search?q=k8s+名字空间
According to the search, no information has ever been defined as 名字空间 except for modified documents, so why is 名字空间 prioritized before 命名空间?

“命名”一词本身是动词，赋予某物名称的意思。在英文中对应的精确表达应该是 naming。
“namespace” 中的 name 是一个纯名词，拆解来理解意味着“名字的作用域”，直接翻译为“名字空间”是更为贴切的译法。
至于在其他地方看到很多“命名空间”的说法，有些人就直接接受了，将其奉为圭臬了，我们也尊重，只是在这个语境中，为“命名”这个动作提供一个空间，还是很牵强。
/close

/reopen

在最早的C++中的namespace，也是翻译为命名空间，在 kubernetes 相关系列的图书中，也是称为命名空间，从未看到过名字空间的用法。

本土化翻译，我认为应该切合大家的使用习惯，而不是以学术化方式，拆字解字。

https://kubernetes.io/ko/docs/concepts/overview/working-with-objects/namespaces/
https://kubernetes.io/ja/docs/concepts/overview/working-with-objects/namespaces/
不管在韩语还是日语中，他们都是命名空间
所以我们为什么要反其道而行之？

@howieyuen Now the information on the web is based on 命名空间, and the 名字空间 has never been heard of, do you have a link to discuss it?
名字空间 He is a direct translation

sorry, I only remember that the discussion is under comments in one PR, because this question also bothers me earlier.

@tengqm 就name词性来讲 ，naming 准确的说是现在分词，表进行的意思，而name可以是名词也可以是及物动词，不知道你是否了解

This is something that can be discussed, so why just shut it close?

至于在其他地方“名字空间 ” 的奉行的话，在这个名字，在名字的中名圭臬，我们也贴贴了，译文境中，为“命名”这个动作提供了一个空间，还是很牵强。
/关

大家都是中国人我就用中文跟你说吧。你们深信服的公司就是这样总爱搞点事情，比如rancher套个壳就是你们自研发。没事监控监控员工的上网行为管理也是你们公司干的缺德事。就事论事来说，我们19年到现在都是用的命名空间，为什么要改，你们说讨论过后，麻烦说一下跟谁在讨论，是不是你们自己大脑短路自己研究的呢。

@anstns
随意蔓延攻击毫无意义，如果礼貌都不会，只知道嘲讽、怼人，就算有理也将没理。
爱护环境人人有责，请勿污染环境，谢谢。
/close

/reopen

@anstns 确实过了点
@windsonsea https://kubernetes.io/community/code-of-conduct/#our-standards
Being respectful of differing opinions, viewpoints, and experiences
尊重不同的意见、观点和经验，然后你们就可以随意关闭PR了？

Focusing on what is best not just for us as individuals, but for the overall community
这里也提到了，觉得改成名字空间对社区友好吗？改了近两年，现在有使用名字空间吗？强行推广，来表示自己专业性？

有个成语叫 矫枉过正

FYI, in Google search 名字空間 has 300k results, and 命名空間 has 400k results. Both are significantly used in the Chinese world.
It's great to use the "correct" one in your contribution (new files or new paragraphs). We will feel your passion for tracing correctness, which is an encouraged attitude to contributing.

But this PR may fall into Trivial Edits, which is not accepted by our community.

Does this PR greatly improve the quality of the content?
Can the term glossary be improved further?

It's better to open an issue to discuss with others first, then we can "fix" related documents if needed.

In k8s, we more widely use 命名空间, in addition if the use of 名字空间, when referring to other materials, will make the reader confused, because the current variety of materials, including new materials, are using 命名空间
Also, if we take value, many pr's should not be merged.

https://www.google.com/search?q=k8s+"名字空間"
About 20,300 results
https://www.google.com/search?q=k8s+"命名空间"
About 246,000 results

As for modifying to 命名空间, in China or other people who use Chinese, ask him about k8s namespace, I think more people will answer 命名空间, at least around me, I asked in some technical communities, if you choose between  名字空间 and 命名空间, most people's answer is 命名空间, and some people suggested名称空间 is also good.
In the k8s ecosystem, they also all use the 命名空间

Also if we are talking about value, then 命名空间 will not be changed to 名字空间
The documentation prior to this one used 命名空间
https://github.com/kubernetes/website/commit/d38315f27b32b0b356c6b5ce7c2837118cfadccb

让

这不是人身攻击，说的都是实话（rancher改皮是他们干的不）（上网行为管理是他们做的不），我哪里说错了？

In the k8s ecosystem, they all actually use the 命名空间
For instance, they (Includes cncf projects):

rancher
istio
volcano
kubeEdge

I looked through the projects in CNCF and there is no description of 名字空间 in their documentation, there are just 命名空间 that
In addition, when I took the CKA certificate, the topic descriptions in it also used 命名空间

名字空間
Click on this link and you'll actually find that his first entry is Wikipedia, titled 命名空间

/reopen 有相关讨论地址吗？

/reopen 有相关讨论地址吗？

好吧。如果这个问题对一些读者非常重要。可以去搜索一下之前的 PR（如果我没记错的话，讨论不是在一个 issue 下面进行的）。 在中文译文风格指南的 git history 里面可能也有一部分。其他 reviewer 也可以补充一些，看看我们是不是还在哪里讨论过。我印象中这个问题在过去一年中至少讨论过三次。

https://github.com/kubernetes/website/pull/33179
https://github.com/kubernetes/website/issues/28459
https://github.com/kubernetes/website/issues/35798
I searched the following links, all about the controversy of why it is 名字空间 that
The controversy about why it's a 命名空间 I only saw one
https://github.com/kubernetes/website/issues/28459#issuecomment-863623927

We had such discussions previously when drafting and reviewing the https://kubernetes.io/zh/docs/contribute/localization_zh/#术语对照 page. I personally prefer "名字空间”，because that is what namespace for ... a space for names. There are other voices arguing that "命名空间” is very popular in many articles or books.

Would there be these controversies if it were a 命名空间？People who raise these controversies are feeling doubtful about 名字空间

Hey @aimuz, would you like to open an issue so that we can discuss this further?
Without the issue, we would have to close this controversial PR.

Those discussion history can serve a background why we don't want to invest time on this issue again. We had discussions on this and we articulated the reason why "名字空间" is acceptable, or even a better option.
When deciding how to translate a term, we consider whether a translation is good not by how it is used in other fields or contexts. We were and we are still trying to find the best Chinese word for an English word. In other words, we honor the true facts rather than how others are doing.
作为严谨的科技工作者，我们的职责不是人云亦云，不是根据事物的流行度来做判断，而是在工作中（包括社区工作中）去重新审视所有即成事实的、已被认定的事物。这一过程并不是轻松的、写意的，而是天人交战的、绞尽脑汁的。毕竟，Kubernetes 的官方文档会是很多下游社区的信息源；毕竟，大家在社区中所做的贡献都要在阳光下晾晒。

I don't think that if it is correct名字空间, there will be so many people who have raised similar issues. If it is wrong, it is wrong. You must be humbly adjusted to accept the suggestions of the contributors.
The discussion you are talking about is just that everyone fears you and does not continue to delve into it , just like this PR act you close other people's comments.
This is a wrong translation名字空间, please adjust it to be correct命名空间.

@correctzh We never said that "名字空间" is the single translation we can accept. We were trying to elaborate two things: 1. "名字空间" could be a better choice. 2. both "名字空间" and "命名空间" are acceptable, given that the latter is also widely used. This is not a black or white question.
Just as suggested by other comments, both translations have been used in other contexts. Period.

However, in the existing document, a large number of them are modified to 名字空间, and if they are modified to 命名空间, they will be rejected with 名字空间 priority being greater than 命名空间.
This PR is also currently just modifying their priority.
So what's the difference between now and only using it?

Kubernetes product:

Azure Kubernetes Service (AKS) - 命名空间
https://learn.microsoft.com/zh-cn/azure/aks/concepts-clusters-workloads#namespaces

Amazon EKS - 命名空间
https://docs.aws.amazon.com/zh_cn/eks/latest/userguide/sample-deployment.html

Red Hat OpenShift - 项目和命名空间
https://access.redhat.com/documentation/zh-cn/openshift_container_platform/4.3/html/authentication/rbac-projects-namespaces_using-rbac#doc-wrapper

CNCF projects:

rancher
https://docs.ranchermanager.rancher.io/zh/how-to-guides/new-user-guides/manage-namespaces

istio
https://istio.io/latest/zh/docs/tasks/security/authentication/authn-policy/#namespace-wide-policy

volcano
https://volcano.sh/zh/docs/installation/#步骤-1

kubeEdge
https://kubeedge.io/zh/docs/setup/keadm_zh/#master

CNCF Ambassadors:

Jimmy Song - blog: 不同命名空间中的服务要绑定到同一个网关中的情况在实际情况下经常出现，而入口网关无法在多个命名空间中共享；
https://jimmysong.io/blog/why-gateway-api-is-the-future-of-ingress-and-mesh/

Lei Zhang - special column: 其解释了如何利用命名空间（Namespace）这一概念来组织 K8s 租户的资源。
https://www.infoq.cn/article/fsmwwgyknsgwpegjho4g

sig-docs-zh-reviews:

chenxuc
https://github.com/kubernetes/website/pull/37665

kubernetes Contributor:

yinyicao
https://github.com/kubernetes/website/pull/33179

linruikai
https://github.com/kubernetes/website/issues/35798

google search results(命名空间>名字空间):
k8s+"命名空间" - About 246,000 results
https://www.google.com/search?q=k8s+"命名空间"
k8s "名字空间" - About 20,300 results
https://www.google.com/search?q=k8s+"名字空间"

The first focus of localization is correctness.
This is a wrong translation(名字空间),please adjust it to be correct(命名空间).
In official commercial Kubernetes product(Azure Kubernetes Service,Amazon EKS,Red Hat OpenShift), in CNCF projects(rancher,istio,volcano,kubeEdge), in K8S experts(CNCF Ambassadors:Jimmy Song,Lei Zhang),in sig-docs-zh-reviews(chenxuc) ,in enthusiastic contributors(yinyicao,linruikai,aimuz),All are used correct(命名空间).
Do you have any references to prove what you said, "名字空间" could be a better choice.
This is wrong(名字空间). If you continue to use it(名字空间), other users will continue to give you correct advice. Continuing to use the wrong one(名字空间) is a real waste of time.
The community isn't yours, it's all those who are willing to say a word about this project.
He should be encouraged as long as he is willing to put in the time for this project.

Hi everyone - I'm from the Kubernetes code of conduct committee. We received a report on this PR, and at this time are going to lock this.
Please reach out to<EMAIL_ADDRESS>for further questions or clarification.

/close


everyone to be able to setup GPU instance

find setup instructions
start GPU instance
build docker
run notebook (any)
confirm tensorflow and panda version

done.

[x] @suryatechie
[x] @TsungChinHanKen
[ ] @oropezaev
[x] @taeil

I setup it already but cannot open jupyter notebook thru http://<IP_ADDRESS>:8888 in browser. any suggestion for my setting to be wrong?

Thanks. Resolved.


windowsdesktop-runtime-7.0: Add version 7.0.20

Now that v8 is both the regular and LTS version, it seems fitting to add v7 here — especially since some apps are built for this specific version and nothing else.

[x] I have read the Contributing Guide.

/verify


🐛 [Firebase_auth] signInWithPopup auth fails with crossOriginIsolated=true

Bug report
I am using firebase hosting for a pwa application requiring firebase_auth and sharedarraybuffer
To enable sharedArrayBuffer i use cross-origin isolation:
"headers": [
          {
            "key": "Cross-Origin-Opener-Policy",
            "value": "same-origin"
          },
          {
            "key": "Cross-Origin-Embedder-Policy",
            "value": "require-corp"
          }
        ]

but it s incompatible with signInWithPopup because iframe content is blocked by browser due to missing headers Cross-Origin-Resource-Policy.
Could you help me solving this issue?
=

@Nimo11
This doesn't seem to be an issue with firebase_auth, but could be related to underlying firebase js sdk. Flutterfire plugins are  thin wrappers around native Firebase SDKs, so I suggest you to reach out to firebase support or native Firebase sdk repo.
I already see a similar issue open in firebase js repo https://github.com/firebase/firebase-js-sdk/issues/6467 in which you seem to have commented as well. I suggest you to follow-up in that issue for updates. Once the feature is implemented natively, then flutterfire can leverage the implementation to work in firebase_auth plugin.
Closing from here, as this doesn't seem to be actionable from plugin side. If you disagree, write in comments and I'll reopen it.


point.select.r can now can accept a function

Previously, point.select.r was defined by either a single constant value or would default to 4 times the radius.  Now it can be defined by a custom function.

1

Nicely done (and good idea, I've wanted that myself)! I've merged this into dev.

This has been merged into master as 0.4.11. Thanks!


OpenWrt 21.02.0-rc3  does not support scsi-like usb-storage by default?

Hi,
I flashed 19.07 router with OpenWrt 21.02.0-rc3 and it took me a few hours to fix it after the upgrade. One of the issues was that the following drivers were missing. Most notably, I could not access my USB flash drive as /dev/sda was missing. Please check teh default kernel modules for https://downloads.openwrt.org/releases/21.02.0-rc3/targets/ipq806x/generic/openwrt-21.02.0-rc3-ipq806x-generic-netgear_r7800-squashfs-sysupgrade.bin .
I installed the following (with some unrelated modules but maybe also worth for inclusion):
kmod-fs-ext4 kmod-fs-exfat kmod-fuse kmod-hid kmod-lib-lz4 kmod-lib-lzo kmod-lib-zlib-deflate kmod-lib-zlib-inflate kmod-scsi-core kmod-scsi-generic kmod-usb-storage kmod-usb-storage-uas kmod-usb-uhci kmod-usb3

this is tairly atypical and has been the case for several releases... ( and it's not luci specific )
default images contain what is needed for the specific hardware to reduce bloat and maintain compatibility across several boards factoring the lowest and most common denominators...
building your own images provides you with an opportunity to include additional packages...
submitting a PR to the main repo provides an opportunity to alter default package sets.

I will not make a PR for this as I am not familiar with the development of OpenWRT. Would you reming at least pointing to mod-scsi-core kmod-scsi-generic kmod-usb-storage? Thank you.

apologies... I don't understand the question...
as mentioned... it's not related to luci... they are deliberately not included
if you think this is a bug or regression you can report a bug at 'openwrt flyspray'
if you think this is required and are unable to offer any solution... you can email the developer mailing list

Ah, now I understand. I did not want to report the bug under "luci" but under "packages". Sorry for the noise.


Fix message fetch for MCTS subscriptions

Fixes NIP-159 (partially)
Refactor message fetch between obd and inbox. Also, subscriptions 'created' by mcts will have welcome flag set automatically.

lgtm


The terminal tab is not being saved

VS Code now allows you to create a new terminal as a tab. That terminal tab is not being saved.
https://github.com/boolka/vscode-tabster/assets/13188414/590ffc90-f941-489f-8e32-487865f14798

Look at https://github.com/boolka/vscode-tabster?tab=readme-ov-file#known-issues. This is because of API limitations provided by vscode


[View] Add context and detail explorers

This commit adds context and detail explorers on ONE view container.
The detail explorer is collapsed at the first installed.
Once the user has changed the view state by moving, hiding the view,
the initial state will not be used again.
Signed-off-by: Jiyoung Yun<EMAIL_ADDRESS>related issue: #476
/cc @Samsung/one-vscode

FYI, @dayo09 is out of office today.

Please merge this PR.


Images for repo

Hello Pelayo,
I am trying to execute the simulation but i get this error when i execute $ aco_resolve_path.py :
aco_resolve_path.py: error: too few arguments
Also since executed i have some pyc files on my aco repository which i cant open
Any advice?

Hello,
The script needs some arguments to be introduced, you can see which these are by executing:
python aco_resolve_path.py --help
The pyc files are compiled python code, you shouldn't be looking at them.
Regards,

Hello Pelayo,
Can you please explain me how to introduce these two arguments?(ants,iterations)
I tried to use set -- in the terminal but there is no such option.
Thanks,


read and write AlternativeImage

OCR-D processors are required to respect the AlternativeImage annotation of the METS/PAGE pair, cf. spec (ff.). That implies,

on the page level: do not just read @imageFilename, but prefer a AlternativeImage/@filename if it exists; regardless, write the result as a new PAGE, merely referencing the resulting image as additional AlternativeImage in the PageType and mets:file (in one of the OCR-D-IMG-* fileGrps) in METS

on the region level: do not just read @imageFilename and cut the respective region from it, but instead:

prefer a AlternativeImage/@filename (for the region) if it exists, or
prefer a AlternativeImage/@filename (for the page) if it exists and cut the region from it, otherwise
use @imageFilename and cut the respective region from it;

regardless, write the result as a new PAGE, merely referencing the resulting image as additional AlternativeImage in the RegionType and mets:file (in one of the OCR-D-IMG-* fileGrps) in METS

etc.

But mind that an effort is currently under way to incorporate a nice API for all that into core. (Because there is a lot more to it, cf. OCR-D/ocrd_tesserocr#33.) So I recommend waiting for the next release of ocrd first.


Revert "Adding C++ API and implementation for STS credentials:"

Reverts grpc/grpc#19587 because it caused the internal build problem while importing this.

I am taking a look at the breakage.


H2 console info to readme & secure it

Also add info about the local database files to readme.

Fixed in master.  To be included in 1.1.0


fix bugs and optimize and add feature

removeEventListener has something wrong
this._requestScroll.bind(this) === this._requestScroll.bind(this) // false

 // unbind scroll and resize event
this._optionsContainer.removeEventListener('scroll', this._requestScroll.bind(this), false);
this._optionsContainer.removeEventListener('resize', this._requestScroll.bind(this), false);
// now scroll and resize event handler still fire

support dynamic loading
layzr.js cache the nodes when it initialize,  we must call the 'updateSelector' method to update nodes.
Now there is no property '_nodes',  we query the image node in method 'update'
add method 'config' to update the layzr options
other optimize
...

some good stuff in here, though I'd prefer smaller PRs that are more focused.

images are assumed to be visible, as that's the most likely case if they're being lazy loaded. the hidden attribute option allows for handling of hidden images
want to avoid adding the polyfill. per the browser support, this library targets IE10+. if someone needs the polyfill it's easy to add, i'd prefer not to bloat the lib with it
you're right about the destroy method - it's broken. im looking into it and will likely patch it in a fashion similar to what's discussed in #32

going to take a pass on this for now, but thanks for submitting


Show that we can build Equivalences of Categories from Pointwise Isomorphisms

Patch Description
This PR adds 2 helper functions for building various incarnations of natural isomorphisms from pointwise equivalences.
This is sorely needed for my proofs of the various monadicity theorems, as otherwise we get bogged down in the details incredibly quickly.
Notes
I'm not super happy with the sigma types present in the definition of pointwise-iso-equivalence. Perhaps we ought to add something to Categories.Morphism that captures the notion of a morphism being one half of some isomorphism. It seems like this situation is often referred to as "f is an isomorphim" which suggests this type ought to be called IsIso, but that conflicts with our naming scheme for predicates.

Yeah, I should probably do a formatting pass over the Crude Monadicity Stuff as well. I tried to compress as best I could but some of them are just gnarly

Yeah, I should probably do a formatting pass over the Crude Monadicity Stuff as well. I tried to compress as best I could but some of them are just gnarly


final project

Nice, useful scripts. I got into python through sysadmin, so it is close to my heart. :) Would be nice to see some tests.


Fix CreateOperation method conflicts

Fixes: https://github.com/Azure/autorest.csharp/issues/652

I've addressed comments, merging to unblock library dev work.


add possibility to override/extend version name and version separator

Hi :wave:
thanks for super GitHub action!
It would be great to have the possibility to replace (or extend) regexp of the separator used to separate version name (e.g REVIEWDOG_VERSION) and version (e.g. 0.1.0) - currently it's equal to (=|:?\s+) - which is probably fine for most cases, but, for instance, not when you want to update the value in the file where each line is formatted like plugin-name:1.2.3.
It can be done by some action's input e.g. separator_regexp: ':\s*'.
Such a configuration option will make depup action much more versatile

@skarzi I think pull request #21 adds this feature.

yes, currently a majority of cases are handled properly!


discord_app module

Resolves #1.
Reference

https://github.com/EthanThatOneKid/fart/blob/3cae373aa34a97d6590699969ec6befb39dedfc4/lib/porygon/system.ts

After one of my recent commits blind coding a little more than I could chew, so my proof of concept broke. Working on another branch wip-mess to backtrack and get back to where I was.


Read Write works fine using node package, but unable to look up anything from redis-cli

I am able to connect to the redis standalone instance from the node project using thunks package. I am able to get and set values and everything works fine. However GET key, KEYS * does not return me anything in redis-cli. What I'm trying to do is, using CLI make sure I have all the key-value pairs in there.
This is how I connect
let redisClient = redis.createClient(standAlone.ip + ':' + standAlone.port, { database: 1, usePromise: blueBird });
and then
redisClient.set(dataReceived.cacheKey, JSON.stringify(dataReceived.cacheData))
.then...........rest of the code

Sorry to raise this issue here. I thought someone would advise.
I found the answer. the database option was causing Redis to direct keys to '1'. But the CLI connects to '0' by default. I ran 'redis-cli -n 1' which connects to the database number and I see all the keys and data
https://redis.io/topics/rediscli


A Trio history enact page

Is your feature request related to a problem? Please describe.
When tuning and adjusting it is very helpful with a "Enact history page" where you can see every loop and how the calculations where made.
Describe the solution you'd like
A History page like autoISF that is searchable in time and date. Some parameters should be changed to fit Trio better.Long press at "statistics icon" to bring the page up
Additional context
See screenshot from autoISF

I could see this be useful when tuning the algorithm. Good idea.

As a tuning aid, I would like to se an easy assessable slider for ISF. This should be logged in the History table above. Then you can increase/decrease when needed or makes it easier to tune. If I want to test 10% less at a certain time I just slide it to 90%. Idea are from tuning engines but would was ease a lot. A toggle in settings to enable this amazing feature so children wouldn’t change it

As a tuning aid, I would like to se an easy assessable slider for ISF. This should be logged in the History table above. Then you can increase/decrease when needed or makes it easier to tune. If I want to test 10% less at a certain time I just slide it to 90%. Idea are from tuning engines but would was ease a lot. A toggle in settings to enable this amazing feature so children wouldn’t change it

I like the idea. I’d suggest the same for CR and basal. I typically calculate manually what the settings should be if changing by 10 or 15 % relative change. Having this tool in the app would help. A slider is optional, just a field to enter a value for the relative amount of change (+ 10 % etc) would also work (not sure which is less error prone). As long as it’s very clear if the adjustment is relative (10%) or absolute (110%) (if that’s the correct terminology)

As a tuning aid, I would like to se an easy assessable slider for ISF. This should be logged in the History table above. Then you can increase/decrease when needed or makes it easier to tune. If I want to test 10% less at a certain time I just slide it to 90%. Idea are from tuning engines but would was ease a lot. A toggle in settings to enable this amazing feature so children wouldn’t change it

@MRMProd Just update the Issue as ideas comeup, so we'll have a complete one when we come to it. Keep it up!

hey 👋 - silence for 30 days 🤐 ... anybody? triage is required!


[hi] Updated menu option to "Documentation" from "Home"

Taking hint from https://github.com/kubernetes/website/issues/43900#issuecomment-1810988608  to come up with fix.
This will fix https://github.com/kubernetes/website/issues/43900

/retitle [hi] Updated menu option to "Documentation" from "Home"

/approve


Adding songs section for Search page

Description
Implemented songs section for search page
Related Issues

"Fixes #317 "

Changes
Added SearchSongs component. Updated nested route in App.jsx.
Screenshots (if applicable)

Checklist
Make sure to check off all the items before submitting. Mark with [x] if done.

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I am working on this issue under GSSOC

Hey @Satyam1923
Can you please add GSSoC'24 labels?


git pull and git clone failing because of trailing colon

Description
git clone seems to be failing on the main branch due to trailing colon in a diksha folder
How to reproduce
git clone https://github.com/Code4GovTech/c4gt-milestones.git
Screenshots

Its resolved with commit 399a60f6cb4b032f35df7b440f4a8a212374c27f


ENOTDIR bug?

Seeing the below error on Windows, and npm cache clean etc doesn't fix it.
You can reproduce by running ember build on https://github.com/shaunc/ember-grid/commit/edaddd73459494097498045ddc01d289567b3229
Is this a known bug?
Build failed.
ENOTDIR, not a directory 'G:\Projects\ember-grid\tmp\broccoli_merge_trees-input_
base_path-IfcH4Dsc.tmp\1'
Error: ENOTDIR, not a directory 'G:\Projects\ember-grid\tmp\broccoli_merge_trees
-input_base_path-IfcH4Dsc.tmp\1'
    at Error (native)
    at Object.fs.readdirSync (fs.js:765:18)
    at G:\Projects\ember-grid\node_modules\ember-cli\node_modules\broccoli-merge
-trees\index.js:35:19
    at Array.map (native)
    at mergeRelativePath (G:\Projects\ember-grid\node_modules\ember-cli\node_mod
ules\broccoli-merge-trees\index.js:33:28)
    at BroccoliMergeTrees.build (G:\Projects\ember-grid\node_modules\ember-cli\n
ode_modules\broccoli-merge-trees\index.js:26:3)
    at G:\Projects\ember-grid\node_modules\ember-cli\node_modules\broccoli-merge
-trees\node_modules\broccoli-plugin\read_compat.js:61:34
    at lib$rsvp$$internal$$tryCatch (G:\Projects\ember-grid\node_modules\ember-c
li\node_modules\rsvp\dist\rsvp.js:493:16)
    at lib$rsvp$$internal$$invokeCallback (G:\Projects\ember-grid\node_modules\e
mber-cli\node_modules\rsvp\dist\rsvp.js:505:17)
    at lib$rsvp$$internal$$publish (G:\Projects\ember-grid\node_modules\ember-cl
i\node_modules\rsvp\dist\rsvp.js:476:11)

Can you run ember server and look around in the parent directory (G:\Projects\ember-grid\tmp\broccoli_merge_trees -input_base_path-IfcH4Dsc.tmp) and tell us what you see?

G:\Projects\ember-grid\tmp>cd broccoli_merge_trees-input_base_path-804QQxE9.tmp

G:\Projects\ember-grid\tmp\broccoli_merge_trees-input_base_path-804QQxE9.tmp>dir

 Volume in drive G is Backup of raid
 Volume Serial Number is 8A05-BF40

 Directory of G:\Projects\ember-grid\tmp\broccoli_merge_trees-input_base_path-80
4QQxE9.tmp

15/09/2015  23:30    <DIR>          .
15/09/2015  23:30    <DIR>          ..
15/09/2015  23:30    <SYMLINKD>     0 [G:\Projects\ember-grid\tmp\broccoli_merge
_trees-output_path-94OJMVN0.tmp]
15/09/2015  23:30    <SYMLINK>      1 [G:\Projects\ember-grid\node_modules\ember
-collection\node_modules\layout-bin-packer\dist\layout-bin-packer.js]
               1 File(s)              0 bytes
               3 Dir(s)  296,285,908,992 bytes free

PS Hi Jo, long time no see!

Haha, didn't notice your username :) - long time no see Bryan, how have you been? Will you make it to EmberCamp?
So it seems that one of the input nodes ("trees") to merge-trees ended up being a file. That's not supposed to happen.
I think I'll put in some code to check for this with the next refactoring. In the meantime... Hm, this is tricky to debug, and our debugging tools are still not terribly great. Maybe some of the Ember CLI folks have an idea.
Does the error still happen?

I just saw something very similar with a different app.
I noticed the error was occurring in a package listed as a dependency in package.json. That dependency doesn't seem to be needed any more, so I removed it, which fixed the build error.
I then saw the same ENOTDIR error happen inside a second no-longer-required dependency. Removing that from package.json made that error disappear too.

what were the dependencies you removed, @AndyPyeSC?

Following what we discussed about your changes to ember-grid, I removed these:
"ember-list-view": "BryanCrotaz/list-view#Accept_ember-data_items",
"ember-collection": "shaunc/ember-collection"

I will try to be at EmberCamp, Jo - but very very busy with client projects. To such an extent that I have 6 client meetings tomorrow!

I'm getting this error caused by ember-cli-sass. Is there any workaround?

This one seems to have gone stale, (lots has changed). We are now looking at https://github.com/broccolijs/broccoli-merge-trees/issues/52.
Closing this one, will gladly reopen if it can be demonstrated.


Deepseek v2 support

[WIP]

Fix the memory index, do not use fixed shape [num_req, max_context_len].
Fix the head_dim mismatch problem.

Looking forward to see Deepseek v2 gets supported! I was trying to do the same thing two weeks ago but found the exact same issue of
RuntimeError: shape mismatch: value tensor of shape [7, 16, 256] cannot be broadcast to indexing result of shape [7, 16, 40]

Thank you for your excellent work. Will you support MLA in the future?  Reduce KV cache to support larger context length.


Consider using Github's CODEOWNERS

See: https://github.com/blog/2392-introducing-code-owners
and
https://help.github.com/articles/about-codeowners/
This could be useful for making pull requests to know who should review which parts of the code (especially contrib modules).
It might also make it easier for newcomers to contact developers regarding their own patches, etc.

I briefly thought about this when GH published that blog post. I want to say it's a good idea to implement in hopes that auto assigning reviewers will aid in quicker PR reviews and merges - thus sparking luigi dev again; however, there exists some overhead in denoting/assigning these code owners - particularly for files with many contributors (i.e. 41 individuals have contributed to parameter.py).
All this said, I think it's worth trying - perhaps start with repo owners and contrib dir.
Thanks for starting this discussion!

Resolved by #2465
The initial take was only at global owners and my redshift ownership. Contributions welcome :)


Is there a way to cache media content from the bookmarked items (videos, pdfs, others)?

I'm working on a project that needs to storage media files such as .mp4 files and .pdfs. Is there a way to force the cache for this kind of files as well?
Thank you!

Doable by using the cordova file plugin http://ngcordova.com/docs/plugins/file/ but you will need to develop this part as it is not supported.


Emscripten testing

[ ] closes #xxxx
[ ] tests added / passed.
[ ] code/documentation is well formatted.
[ ] properly formatted commit message. See
NumPy's guide.

Notes:

It is essential that you add a test when making code changes. Tests are not
needed for doc changes.
When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
When fixing a bug, you must add a test that would produce the bug in main and
then show that it is fixed with the new code.
New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
verify you changes are well formatted by runninggit diff upstream/main -u -- "*.py" | flake8 --diff --isolated

assuming flake8 is installed. This command is also available on Windows
using the Windows System for Linux once flake8 is installed in the
local Linux environment. While passing this test is not required, it is good practice and it help
improve code quality in statsmodels.
Docstring additions must render correctly, including escapes and LaTeX.

This is quite weird, _qn can't be initialised at all here but works perfectly fine in a Pyodide xbuildenv in a Docker container...


std::runtime error

when I was compiling i know one file didn't pass. But when i start ./blackbird it says std::runtime error.
any ideas how to fix it?

Hi @pol672, you need to provide more details (e.g. logs, complete error). What do you mean by a file didn't pass the compilation? Thanks

Yeah the error I don't know about when I typed make there was a file that had some errors but it paste. I'm trying to run it on a raspberry pi B+, for exchange I've got bitstamp and bitfinex. This is what I get.
screenshot: https://www.dropbox.com/s/jlczcl72wjoysx2/Screenshot from 2016-07-04 18%3A58%3A48.png?dl=0

What is the file that had errors during the compilation?
Can you type the command locale in your terminal and show us the result?

Thanks

I fixed it myself. I deleted the blackbird file and than rerun make. Now it's says blackbird running  and log file generated so I guess it's fixed, but thankx for the help

it' was indeed because it wasn't locale. if I do ssh again on my pi and than run screen ./blackbird I still get screen terminating but if I run local screen ./blackbird not a problem.

Thank you @pol672 for the feedback. I can close the issue.


ReloadLookup only works for delete not for create / update

protected override void InternalRefresh()
{
base.InternalRefresh();
Q.ReloadLookup("MyModule");
var rowCnt = MyModuleRow.Lookup.Items.Count(x => x.Id == kdId);
titleDiv.Children().Text("Title - " + rowCnt );
}
this only works for delete not for create/update.
After delete record rowCnt updated but not when create.
try to read Rows.Count with the same result.
Regards

There is no difference between delete or update. Your InternalRefresh probably not called. Add Q.Log, Q.Notify etc to see. Also, reloading lookup is not a good idea to get a count.

I see in my Console.Writeline.... that record not changed but called.
In your dashboard page total Customers not changed when you add some new record .
is it the same problem or i'm missing something in your manual?

Numbers on Dashboard page change only when you change an Order or wait 3 minutes.
        var cachedModel = TwoLevelCache.GetLocalStoreOnly("DashboardPageModel", TimeSpan.FromMinutes(5),
            OrderRow.Fields.GenerationKey, () =>

Here caching is dependent on OrderRow grouping cache key, not customer. It also doesn't change if you add 20 customers and delete one.
How your lookup is defined, and does your row has TwoLevelCached attribute on it?

Btw, is this screen editing interface for Penerbit.lsmn entity? Or some related table?
What's this?
MyModuleRow.Lookup.Items.Count(x => x.Id == kdId)

i'm trying to get max from Ismn table, for this example i use count  first to make sure that this lookup works properly.
IsmnRow.cs:
[LookupScript("Penerbit.Ismn")]
var rowI = IsmnRow.Lookup.Items.Count(x => x.Id == kdId);
Console.Writeline(rowl)

What is x.Id == kdId, what is kdId

var kdId = Lookup value from other table

I found solution for this..
Thanks a lot...

@4lamosky I would like to see the solution as to how you got the data back to the grid. I want to get last record back to grid and this thread seemed so promising until I got to - I found solution - with no sample ..


bennaaym/graphviz_support: bug fixed | README updated with examples

Description
This is an update of the LabgraphGraphviz extension. The PR adds the following :

Fixes a small bug that appears sometimes when the graph contains a group( the bug was mainly caused by the wrong usage of  Python Set.pop() method, which may give different output for the same input)
Add examples on how to use the generate_graphviz function

Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[X] This change requires a documentation update

validation/testing

Tested on graph examples that include a group unit

Checklist:

[X] Have you added tests that prove your fix is effective or that this feature works?
[X] New and existing unit tests pass locally with these changes?
[X] Has code been commented, particularly in hard-to-understand areas?
[x] Have you made corresponding changes to the documentation?

Hey @bennaaym  great job on these examples, and thank you so much for adding them. I just wanted to point out a small bug, I encountered when trying to run generate_graphviz.py, see line 174

When I tried debugging it, it turned out my output_file was /Users/fatimazahra.chriha/Desktop/mlh/spring2022/labgraph/extensions/graphviz_support/graphviz_support/examples/output/simple_viz.svg
So when running filename, format = output_file.split('.') it resulted in a list of 3 elements instead of 2 I solved it by replacing line 174 by
split_list = output_file.split('/')
last_ele = split_list.pop().split('.')
format = last_ele[1]
filename = '/'.join(split_list) + '/' + last_ele[0]

Just wanted to give you a heads up, awesome work!

Hello, @fzchriha thank you for your feedback. I have noticed that bug and fixing it (please check the PR update). I like your solution, however, I think using "os.path.splitext()" will be an easier option.  Please try it again and let me know if there are any other issues


Network Status no updated

Hi,
I've been using your script for a very long time, and like it so much. I never encountered any problem before, but today when I am installing the script on one of my server, all the data is showing except the network data. I never have any issue before, you maybe you could please give me a hand to solve this issue. The server is hosted on OVH and the dashboard is located in this page : https://goo.gl/v5W0t0
Thanks

I am rerun the script after reinstall the server and it seems it fix the issue.


feat(sockets): have a folder to write in

useful if you want to mount sockets into /root/.ssh but /root/.ssh is readonly

/lgtm


Data Import/Export Framework doesn't exist in Dynamics 365 F&O

Health monitoring – In addition to availability checks, some basic health checks must be performed. These health checks span various components, such as Application Object Server, Batch Framework, Data Import/Export Framework
In 365 the name is Data management Framework which is specified in another article. Please correct this

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c73b0eff-ab53-afb9-b3e2-40f94cb71a3e
Version Independent ID: 069fa33b-6a69-2d29-908d-fca5ca0dc516
Content: Monitoring and diagnostics tools in Lifecycle Services (LCS) - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/dev-itpro/lifecycle-services/monitoring-diagnostics.md
Service: dynamics-ax-platform
GitHub Login: @manalidongre
Microsoft Alias: manado

@amadse, thanks for the feedback.
@manalidongre, can you review the suggested change and update this topic if necessary.

@manalidongre bug #303315 is logged for investigation

This topic has been updated.


Regex Filtering for PII

💡 Summary
Generic filter to remove sensitive PII
Motivation and context
We are not allowed to store or process PII so it is best to prevent it from ever entering our system.
Implementation notes
Please provide details for implementation, such as:

utilize Regex to create a function that all scripts must pass data through prior to writing into DB.
data should be sanitized and replacement text that is inserted should make it obvious.

Acceptance criteria
How do we know when this work is done?

[ ] Sensitive PII will not be written into database
[ ] New function should exist that is accessible to all scripts attempting to write to the database.

Identified Scrubadub python library as the path forward.  Issue continued in #118


As a developer, I want to have access to a Change Password endpoint, so that can allow users to securely update their passwords.

Acceptance Criteria:

[ ] Endpoint for password change is functional and secure.
[ ] User identity is verified before allowing password change.
[ ] Endpoint integrates smoothly with both Forgot Password and Settings pages.
[ ] Process adheres to security best practices, including token generation.

Demo Steps:

Show password change via Forgot Password page.
Demonstrate password change in Settings for logged-in users.
Confirm user verification process.

Potential Risks:

Security vulnerabilities in the password change process.
User confusion if the process is not intuitive.
Integration challenges with existing systems.

Technical Notes:

Implement secure token generation and expiry.
Ensure robust testing for endpoint security.
Document the API on swaager under Auth for easy frontend integration.

The problem should also take into consideration the endpoints for resetting passwords for users who are not logged in.

The problem should also take into consideration the endpoints for resetting passwords for users who are not logged in. we need an endpoint that receives an email address in the request body and sends an email to initiate a password change process, essentially fulfilling the basic requirements of a forgot password feature.

this issue is explained in a clearer way here #267


Issue 117

@dricazenck -- two separate commits. Pick whichever you prefer.

We can create our repo guideline, actually is going to be good idea, but check some of the steps:
📖 Read up on fork & pull request models
🍴 Fork this repo to your account
🌱 Create a branch for the change you intend to make in your fork
✍ Make your changes to the above created branch in your fork
🔨 Follow the contributing guidelines
🔧 Send a pull request from your fork's branch to our master branch
🎉 Get your pull request approved - success!

Hey @hasandiwan I think instead of reverting your changes you delete Event by mistake, could you add back Event and we can merge the PR?


Mixing of two data points

What happened?

I'm using a motion sensor, which is also reporting illuminance.
It is reporting illuminance_lux and illuminance as MQTT messages
In the zigbee2mqtt adapter these two values are represented as illuminance and illuminance_raw
In the node-red adapter, I'm processing the illuminance value
Whenever a new message arrives, I get two values in node-red: The value for illuminance and illuminance_raw

First one is the raw value and second one is the lux value
Also in the adapter itself, it seems that the raw value is not updated unless the adapter is restarted:

What did you expect to happen?
Both values are updated and separated accordingly.
Is there same regex matching that is too broad?
How to reproduce it (minimal and precise)
No response
Adapter version
abc738c314d0402292f8facc9a9d727c11dcbea7 (current git)
Log

zigbee2mqtt.0
2022-12-04 16:36:13.794
info
MQTT publish: topic 'zigbee2mqtt/MotionFrontDoor/illuminance_lux', payload '2'

zigbee2mqtt.0
2022-12-04 16:36:13.794
debug
Device: MotionFrontDoor/illuminance_lux not found, queue state in incStatsQueue!

zigbee2mqtt.0
2022-12-04 16:36:13.791
info
MQTT publish: topic 'zigbee2mqtt/MotionFrontDoor/illuminance', payload '3064'

zigbee2mqtt.0
2022-12-04 16:36:13.790
debug
Device: MotionFrontDoor/illuminance not found, queue state in incStatsQueue!

zigbee2mqtt.0
2022-12-04 16:36:13.789
info
MQTT  publish: topic 'zigbee2mqtt/MotionFrontDoor', payload  '{"battery":100,"illuminance":3064,"illuminance_lux":2,"last_seen":"2022-12-04T16:36:13+01:00","linkquality":69,"motion_sensitivity":"high","occupancy":false,"occupancy_timeout":0,"temperature":3.07,"update":{"state":"idle"}}'

The data points are determined by the exposes, so I don't really have to do much there and it works flawlessly with my motion sensor RTCGQ11LM.
Which one do you use?
Did you also set your z2m according to the configuration?
FAQ

Did you also set your z2m according to the configuration?
FAQ

In fact, I had output: attribute_and_json instead output: json. It does not make a difference that I could see and in the following only  output: json is used.
Test setup

Simple node-red flow with 4 different motion sensors
Just takes the Iobroker data-point for illuminance and illuminance_raw and writes it back to the Iobroker log

Results

illuminance_raw is never processed
The Aqara sensors only return once. I think this is due to the fact that illuminance and illuminance_raw have the same value and same timestamp in JSON so it is already filtered by Iobroker
The Philips sensors have different values for illuminance and illuminance_raw. The value for illuminance_raw is never returned but both values are returned under the illuminance data-point

Can you share the exposes that the device reports?
Instruction

0x001788010bd25a8c (Philips<PHONE_NUMBER>) exposes:
{
	"date_code": "20210830",
	"definition": {
		"description": "Hue motion outdoor sensor",
		"exposes": [
			{
				"access": 1,
				"description": "Measured temperature value",
				"name": "temperature",
				"property": "temperature",
				"type": "numeric",
				"unit": "°C"
			},
			{
				"access": 1,
				"description": "Indicates whether the device detected occupancy",
				"name": "occupancy",
				"property": "occupancy",
				"type": "binary",
				"value_off": false,
				"value_on": true
			},
			{
				"access": 1,
				"description": "Remaining battery in %",
				"name": "battery",
				"property": "battery",
				"type": "numeric",
				"unit": "%",
				"value_max": 100,
				"value_min": 0
			},
			{
				"access": 1,
				"description": "Measured illuminance in lux",
				"name": "illuminance_lux",
				"property": "illuminance_lux",
				"type": "numeric",
				"unit": "lx"
			},
			{
				"access": 1,
				"description": "Raw measured illuminance",
				"name": "illuminance",
				"property": "illuminance",
				"type": "numeric"
			},
			{
				"access": 7,
				"name": "motion_sensitivity",
				"property": "motion_sensitivity",
				"type": "enum",
				"values": [
					"low",
					"medium",
					"high",
					"very_high",
					"max"
				]
			},
			{
				"access": 7,
				"description": "Blink green LED on motion detection",
				"name": "led_indication",
				"property": "led_indication",
				"type": "binary",
				"value_off": false,
				"value_on": true
			},
			{
				"access": 7,
				"name": "occupancy_timeout",
				"property": "occupancy_timeout",
				"type": "numeric",
				"unit": "second",
				"value_max": 65535,
				"value_min": 0
			},
			{
				"access": 1,
				"description": "Link quality (signal strength)",
				"name": "linkquality",
				"property": "linkquality",
				"type": "numeric",
				"unit": "lqi",
				"value_max": 255,
				"value_min": 0
			}
		],
		"model": "9290030674",
		"options": [
			{
				"access": 2,
				"description": "Sends a message after the last time no occupancy (occupancy: false) was detected. When setting this for example to [10, 60] a `{\"no_occupancy_since\": 10}` will be send after 10 seconds and a `{\"no_occupancy_since\": 60}` after 60 seconds.",
				"item_type": "number",
				"name": "no_occupancy_since",
				"property": "no_occupancy_since",
				"type": "list"
			},
			{
				"access": 2,
				"description": "Number of digits after decimal point for temperature, takes into effect on next report of device.",
				"name": "temperature_precision",
				"property": "temperature_precision",
				"type": "numeric",
				"value_max": 3,
				"value_min": 0
			},
			{
				"access": 2,
				"description": "Calibrates the temperature value (absolute offset), takes into effect on next report of device.",
				"name": "temperature_calibration",
				"property": "temperature_calibration",
				"type": "numeric"
			},
			{
				"access": 2,
				"description": "Calibrates the illuminance value (percentual offset), takes into effect on next report of device.",
				"name": "illuminance_calibration",
				"property": "illuminance_calibration",
				"type": "numeric"
			},
			{
				"access": 2,
				"description": "Calibrates the illuminance_lux value (percentual offset), takes into effect on next report of device.",
				"name": "illuminance_lux_calibration",
				"property": "illuminance_lux_calibration",
				"type": "numeric"
			}
		],
		"supports_ota": true,
		"vendor": "Philips"
	},
	"endpoints": {
		"2": {
			"bindings": [
				{
					"cluster": "genPowerCfg",
					"target": {
						"endpoint": 1,
						"ieee_address": "0x00124b00237dfd02",
						"type": "endpoint"
					}
				},
				{
					"cluster": "msIlluminanceMeasurement",
					"target": {
						"endpoint": 1,
						"ieee_address": "0x00124b00237dfd02",
						"type": "endpoint"
					}
				},
				{
					"cluster": "msTemperatureMeasurement",
					"target": {
						"endpoint": 1,
						"ieee_address": "0x00124b00237dfd02",
						"type": "endpoint"
					}
				},
				{
					"cluster": "msOccupancySensing",
					"target": {
						"endpoint": 1,
						"ieee_address": "0x00124b00237dfd02",
						"type": "endpoint"
					}
				}
			],
			"clusters": {
				"input": [
					"genBasic",
					"genPowerCfg",
					"genIdentify",
					"msOccupancySensing",
					"msIlluminanceMeasurement",
					"msTemperatureMeasurement"
				],
				"output": [
					"genOta",
					"genBasic",
					"genIdentify",
					"genOnOff"
				]
			},
			"configured_reportings": [
				{
					"attribute": "batteryPercentageRemaining",
					"cluster": "genPowerCfg",
					"maximum_report_interval": 62000,
					"minimum_report_interval": 3600,
					"reportable_change": 0
				},
				{
					"attribute": "occupancy",
					"cluster": "msOccupancySensing",
					"maximum_report_interval": 3600,
					"minimum_report_interval": 0,
					"reportable_change": 0
				},
				{
					"attribute": "measuredValue",
					"cluster": "msTemperatureMeasurement",
					"maximum_report_interval": 3600,
					"minimum_report_interval": 10,
					"reportable_change": 100
				},
				{
					"attribute": "measuredValue",
					"cluster": "msIlluminanceMeasurement",
					"maximum_report_interval": 3600,
					"minimum_report_interval": 10,
					"reportable_change": 5
				}
			],
			"scenes": []
		}
	},
	"friendly_name": "MotionFrontDoor",
	"ieee_address": "0x001788010bd25a8c",
	"interview_completed": true,
	"interviewing": false,
	"manufacturer": "Signify Netherlands B.V.",
	"model_id": "SML004",
	"network_address": 14200,
	"power_source": "Battery",
	"software_build_id": "2.53.6",
	"supported": true,
	"type": "EndDevice"
}

IMO the issue is not limited to the Philips Motions Sensor but also the Aqara ones apparently do not correctly send the raw value (practically it does not matter, since both values are the same anyway)
For sake of completeness, here is the exposure of the Aqara P1 sensor as well:
0x54ef44100053c862 exposes:
{
	"date_code": "Jun 9 2022",
	"definition": {
		"description": "Aqara P1 human body movement and illuminance sensor",
		"exposes": [
			{
				"access": 1,
				"description": "Indicates whether the device detected occupancy",
				"name": "occupancy",
				"property": "occupancy",
				"type": "binary",
				"value_off": false,
				"value_on": true
			},
			{
				"access": 1,
				"description": "Measured illuminance in lux",
				"name": "illuminance_lux",
				"property": "illuminance",
				"type": "numeric",
				"unit": "lx"
			},
			{
				"access": 1,
				"description": "Measured illuminance in lux",
				"name": "illuminance",
				"property": "illuminance",
				"type": "numeric",
				"unit": "lx"
			},
			{
				"access": 7,
				"description": ". Press pairing button right before changing this otherwise it will fail.",
				"name": "motion_sensitivity",
				"property": "motion_sensitivity",
				"type": "enum",
				"values": [
					"low",
					"medium",
					"high"
				]
			},
			{
				"access": 7,
				"description": "Time interval for detecting actions. Press pairing button right before changing this otherwise it will fail.",
				"name": "detection_interval",
				"property": "detection_interval",
				"type": "numeric",
				"unit": "s",
				"value_max": 65535,
				"value_min": 2
			},
			{
				"access": 7,
				"description": "When this option is enabled then blue LED will blink once when motion is detected. Press pairing button right before changing this otherwise it will fail.",
				"name": "trigger_indicator",
				"property": "trigger_indicator",
				"type": "binary",
				"value_off": false,
				"value_on": true
			},
			{
				"access": 1,
				"description": "Temperature of the device",
				"name": "device_temperature",
				"property": "device_temperature",
				"type": "numeric",
				"unit": "°C"
			},
			{
				"access": 1,
				"description": "Remaining battery in %",
				"name": "battery",
				"property": "battery",
				"type": "numeric",
				"unit": "%",
				"value_max": 100,
				"value_min": 0
			},
			{
				"access": 1,
				"description": "Voltage of the battery in millivolts",
				"name": "voltage",
				"property": "voltage",
				"type": "numeric",
				"unit": "mV"
			},
			{
				"access": 1,
				"description": "Link quality (signal strength)",
				"name": "linkquality",
				"property": "linkquality",
				"type": "numeric",
				"unit": "lqi",
				"value_max": 255,
				"value_min": 0
			}
		],
		"model": "RTCGQ14LM",
		"options": [
			{
				"access": 2,
				"description": "Time in seconds after which occupancy is cleared after detecting it (default is \"detection_interval\" + 2 seconds). The value must be equal to or greater than \"detection_interval\", and it can also be a fraction.",
				"name": "occupancy_timeout",
				"property": "occupancy_timeout",
				"type": "numeric",
				"unit": "s",
				"value_min": 0,
				"value_step": 0.1
			},
			{
				"access": 2,
				"description": "Sends a message the last time occupancy (occupancy: true) was detected. When setting this for example to [10, 60] a `{\"no_occupancy_since\": 10}` will be send after 10 seconds and a `{\"no_occupancy_since\": 60}` after 60 seconds.",
				"item_type": "number",
				"name": "no_occupancy_since",
				"property": "no_occupancy_since",
				"type": "list"
			},
			{
				"access": 2,
				"description": "Calibrates the illuminance value (percentual offset), takes into effect on next report of device.",
				"name": "illuminance_calibration",
				"property": "illuminance_calibration",
				"type": "numeric"
			},
			{
				"access": 2,
				"description": "Calibrates the device_temperature value (absolute offset), takes into effect on next report of device.",
				"name": "device_temperature_calibration",
				"property": "device_temperature_calibration",
				"type": "numeric"
			}
		],
		"supports_ota": true,
		"vendor": "Xiaomi"
	},
	"endpoints": {
		"1": {
			"bindings": [],
			"clusters": {
				"input": [
					"genBasic",
					"genPowerCfg",
					"genIdentify",
					"aqaraOpple"
				],
				"output": [
					"genIdentify",
					"genOta",
					"aqaraOpple"
				]
			},
			"configured_reportings": [],
			"scenes": []
		}
	},
	"friendly_name": "MotionHallEG",
	"ieee_address": "0x54ef44100053c862",
	"interview_completed": true,
	"interviewing": false,
	"manufacturer": "LUMI",
	"model_id": "lumi.motion.ac02",
	"network_address": 43230,
	"power_source": "Battery",
	"software_build_id": "0.0.0_0006",
	"supported": true,
	"type": "EndDevice"
}

Many thanks, it looks like a definitive improvement 👍

Some questions remain:
Red marked log area:

Do the unknown keys have a deeper meaning?

Green marked log area:

MQTT illuminance seems mapped to Iobroker illuminance_raw

Yellow marked log area:

Seems correct but since both values are the same it is hard to tell

Blue marked log area:

Not sure where this is coming from. Seems to have no source

Need to do some further testing but the outdoor sensors report all 0 at the moment. Will check tomorrow

First of all, the debug and info logs shown on the screenshot of zigbee2mqtt.0 come from your Zigbee2MQTT instance and are only forwarded by my adapter because the option Proxy Zigbee2MQTT Protokolle zu ioBroker Protokollen is set in the adapter configuration.

Red marked log area:

Do the unknown keys have a deeper meaning?

This is RAW data coming from the Zigbee network and then Zigbee2MQTT processes it to the nice JSON.
Why some keys are not processed I can't answer you, you have to ask Zigbee2MQTT.

Green marked log area:

MQTT illuminance seems mapped to Iobroker illuminance_raw

illuminance is always the raw form of the measurement from the device, which differs from manufacturer to manufacturer or from firmware to firmware, so I map this as illuminance_raw.
illuminance_lux is then if necessary the converted (from Zigbee2MQTT) value in lux .

Yellow marked log area:

Seems correct but since both values are the same it is hard to tell

Yes I assume so, since this is calculated by Zigbee2MQTT.

Blue marked log area:

Not sure where this is coming from. Seems to have no source

I can't tell you where your flow was triggered.
But two log entries before at least the raw data from the devices came in.


[SPARK-14159][ML] Fixed bug in StringIndexer + related issue in RFormula

What changes were proposed in this pull request?
StringIndexerModel.transform sets the output column metadata to use name inputCol.  It should not.  Fixing this causes a problem with the metadata produced by RFormula.
Fix in RFormula: I added the StringIndexer columns to prefixesToRewrite, and I modified VectorAttributeRewriter to find and replace all "prefixes" since attributes collect multiple prefixes from StringIndexer + Interaction.
Note that "prefixes" is no longer accurate since internal strings may be replaced.
How was this patch tested?
Unit test which failed before this fix.

Test build #54210 has started for PR 11965 at commit 36bf730.

Test build #54210 has finished for PR 11965 at commit 36bf730.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54210/
Test PASSed.

LGTM. Merged into master. I left the JIRA open for 1.6.


Minor changes in DTOs and validation, API Tags

Description
Minor changes in DTOs and validation, API Tags
Related Issue

issue goes here

Fixes # [ISSUE]

[x] Code
[ ] User Interface
[ ] New Feature
[ ] Documentation
[ ] Testing

Checklist

[x] My code follows the code style of this project.
[ ] My UI is responsive
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] My changes generate no new warnings
[ ] The title of my pull request is a short description of the requested changes.

Done @Devesh21700Kumar thank you so much man for helping

Please resolve merge conflicts.

Please resolve merge conflicts.

Done


Change Renderer.render method to render only templates

Codecov Report

Merging #42 (4cc23e7) into master (8c932a3) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   98.28%   98.28%   -0.01%
==========================================
  Files          16       16
  Lines        1052     1050       -2
==========================================
- Hits         1034     1032       -2
  Misses         18       18

Flag
Coverage Δ

unittests
98.28% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

lib/renderer.lua
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c932a3...4cc23e7. Read the comment docs.


Add a new worker select strategy of overlord.

Add a strategy that allows slot restrictions for tasks with different prefixes, avoiding the task of different data sources to interact with each other because of slot resources. Although the current affinity strategy can achieve similar functionality, but in the cloud environment, there are still many restrictions, such as expansion or shrinkage will lead to ip and port changes, need to re-configure. Restrictions based on slots can be more flexible.

Do we need another strategy here? This can be implemented using the JavaScriptWorkerSelectStrategy

Do we need another strategy here? This can be implemented using the JavaScriptWorkerSelectStrategy

I think it makes sense to have a feature for this, it's useful behavior and the JS strategy has a pretty high barrier to entry since users must write a script to get it to work. And besides, some people disable JS for security reasons.

Affinity strategies can only isolate tasks based on data sources. Often, in the production environment, we will simultaneously capture data through real-time tasks, offline task validation data, real-time tasks will be higher priority, but this strategy can not be based on the type of task to do isolation, may lead to the problem is Offline tasks occupy slots and real-time tasks can only wait. Taking into account the task ID generation rules are fixed, we can through the restrictive strategy to achieve this effect.

In accordance with your recommendations, I have made changes to the code and documentation, please review again, thank you:)  @gianm

What's going on about this issue? Many days have passed. Are there any other problems? @gianm

Sorry @silver--bullet, the past few week has been a busy one.
I still don't see why this can't be rolled into equalDistribution and fillCapacity as an extra limitConfig parameter. Then it would be more composable. It would work with fillCapacity, and it would work in combination with an affinity config as well. For example a user could do:
"selectStrategy" : {
  "type" : "fillCapacity",
  "affinityConfig" : { ... },
  "limitConfig" : { ... }
}

Does it make sense or is there some reason why this is a bad idea?

I have also considered a similar approach before, this is indeed more reasonable and more elegant, but changed to be slightly larger. Then I will refactor the selection strategy, we only keep three types(equalDistribution,fillCapacity,javascript),affinity configuration and limit the configuration as an optional parameter, how do you feel like?

If that works, it sounds good to me.
We do have to keep equalDistributionWithAffinity and fillCapacityWithAffinity for backwards compatibility, although they are already marked as deprecated.


UI - Make search tool results in "Tool catalog" page more reliable.

I am not able to reliably get tool search to return tools I am looking for.
In case of searching for "digital ocean" , no tool gets returned

When searching for "eks" , I see only Eksctl returned and not "Amazon EKS"

I am not able to get search results even for "Amazon EKS".

Other times like this , I have seen it work as expected (with contains search criteria and search being case insensitive)

When testing with the latest build - 9d4616691 , I am able to see the search results in Tool Catalog page fetch the right entries , but the name with which they get displayed is very misleading.
This is true for many entries in the featured list which have read/write versions of the tools.
Searching for mail will show 2 entries "Manage" and "Read" which is very confusing

This is when slack is searched:
https://github.com/user-attachments/assets/0dc2dfb5-1fdf-411c-a5c3-8c81b6ddb165

Search in the tool catalog page which gets launched from "Edit Assistant" page lets us search for other tools that are not in the feature list . This should not be the case -https://github.com/gptscript-ai/desktop/issues/248#issuecomment-2330339732.

We're addressing this by completely removing tool site search from the app.
The only piece that was concerning me was this:

When I searched for internet , i got duckduckgo entry which should not be presented ? This repo is archived,readonly and private.

but i cannot reproduce it

When searching for internet we get only Answers From The Internet now.
Closing this issue since issue mentioned in https://github.com/gptscript-ai/desktop/issues/116#issuecomment-2330303837 and https://github.com/gptscript-ai/desktop/issues/116#issuecomment-2330354636 should be addressed with theremoving tool site search from the app.


Documentation: Formly testing

Question
Can we please update Formly documentation to include best practices for testing with examples? Additionally, the current Documentation page for testing returns a 404:
https://formly.dev/docs/api/core/testing/

The doc for testing is not done yet but you may check some examples in the following issue https://github.com/ngx-formly/ngx-formly/issues/2723#issue-818214519


Increasing rel_err due to test failures.

Pull Request Description
What issue does this change request address?
#1806
This addresses failures in tests like: https://civet.inl.gov/job/1052344/
DIFF in tests/framework/PostProcessors/TSACharacterizer/Basic/chz.csv:
  Different values in ARMA__signal_fa__constant for 0.0193421236263 and 0.0184069534627
  | Difference | statistics:
    MEAN    diff.: 9.417981434e-04
    LARGEST diff.: 5.080526582e-02
(371F1/801) Diff   (  5.36sec)tests/framework/PostProcessors/TSACharacterizer/Basic

DIFF in tests/framework/ROM/TimeSeries/SyntheticHistory/ARMA/samples_1.csv:
  Different values in signal0 for 0.000200007514986 and 0.000288985523409
  | Difference | statistics:
    MEAN    diff.: 3.070426729e-04
    LARGEST diff.: 3.078978053e-01
(531F2/801) Diff   (  3.98sec)tests/framework/ROM/TimeSeries/SyntheticHistory/ARMA

What are the significant changes in functionality due to this change request?
Increases the rel_err for two unstable tests.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

checklist satisfied, and PR can be merged.


[DOCS]

Description
Let's add more stuff to the Brand file, stuff like how to do the gradients, layouts, common patterns, this is something we can work as we go working and descovering the ways of how to apply our brand, looking forward to create our Style Guide.
Screenshots
No response

great idea @Yudai-creator

You're still on this right @Yudai-creator?

Yes I'm in, I'll do the changes I proposed on discord.
On Mon, 24 Oct 2022 at 18:12, Tobiloba Adedeji @.***>
wrote:

You're still on this right @Yudai-creator
https://github.com/Yudai-creator?
—
Reply to this email directly, view it on GitHub
https://github.com/FrancescoXX/4c-site/issues/324#issuecomment-1289690105,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQ3DHNOSQZHMU4XCHR3PGL3WE4CVDANCNFSM6AAAAAARIPCZOI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hey @Yudai-creator, are you still working on this??

Hey @Yudai-creator!! What's up?

Are you still working on this @Yudai-creator??

Hey Tobi sorry for the delay with the file, I haven't done it yet, working on it today

Perfect!! @Yudai-creator!! Looking forward to your response. I know it will be so good!

Fixed by #397


[fftw3] fix openmp on macos

Fixes https://github.com/microsoft/vcpkg/issues/30468

Suggestions for review:
Verify it
126 -- Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES)
127 -- Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES)
128 -- Could NOT find OpenMP (missing: OpenMP_C_FOUND OpenMP_CXX_FOUND)

https://github.com/microsoft/vcpkg/issues/30468#issuecomment-1490025505

Thanks for your PR, please resolve the conflict.

The function vcpkg_extract_source_archive_ex is deprecated. Please use vcpkg_extract_source_archive

Suggestions for review:
Verify it
126 -- Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES)
127 -- Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES)
128 -- Could NOT find OpenMP (missing: OpenMP_C_FOUND OpenMP_CXX_FOUND)

https://github.com/microsoft/vcpkg/issues/30468#issuecomment-1490025505

arm64-osx was installed successfully, but it still cannot be found.

Suggestions for review: Verify it
126 -- Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES)
127 -- Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES)
128 -- Could NOT find OpenMP (missing: OpenMP_C_FOUND OpenMP_CXX_FOUND)

#30468 (comment)

arm64-osx was installed successfully, but it still cannot be found.

vcpkg@VCPKGMM-12 fftw3 % ./vcpkg install "fftw3[openmp]:arm64-osx"
Computing installation plan...

...

-- Configuring arm64-osx
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: /usr/local/bin/ninja -v
    Working Directory: /Users/vcpkg/Monica/fftw3/buildtrees/fftw3/arm64-osx-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      /Users/vcpkg/Monica/fftw3/buildtrees/fftw3/config-arm64-osx-dbg-CMakeCache.txt.log
      /Users/vcpkg/Monica/fftw3/buildtrees/fftw3/config-arm64-osx-rel-CMakeCache.txt.log
      /Users/vcpkg/Monica/fftw3/buildtrees/fftw3/config-arm64-osx-out.log

Call Stack (most recent call first):
  installed/x64-osx/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:248 (vcpkg_execute_required_process)
  ports/fftw3/portfile.cmake:36 (vcpkg_cmake_configure)
  scripts/ports.cmake:147 (include)

/Users/vcpkg/Monica/fftw3/buildtrees/fftw3/config-arm64-osx-out.log:
128 -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
129 -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
130 -- Found Threads: TRUE
131 CMake Error at /Users/vcpkg/Monica/fftw3/downloads/tools/cmake-3.25.1-osx/cmake-3.25.1-macos-universal/CMake.app/Contents/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
132   Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES)
133 Call Stack (most recent call first):
134   /Users/vcpkg/Monica/fftw3/downloads/tools/cmake-3.25.1-osx/cmake-3.25.1-macos-universal/CMake.app/Contents/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
135   /Users/vcpkg/Monica/fftw3/downloads/tools/cmake-3.25.1-osx/cmake-3.25.1-macos-universal/CMake.app/Contents/share/cmake-3.25/Modules/FindOpenMP.cmake:580 (find_package_handle_standard_args)
136   /Users/vcpkg/Monica/fftw3/scripts/buildsystems/vcpkg.cmake:852 (_find_package)
137   CMakeLists.txt:128 (find_package)

Maybe you have to run brew install libomp

Maybe you have to run brew install libomp

Yes, I did, but the error persists.
vcpkg@VCPKGMM-12 fftw3 % brew install libomp
==> Downloading https://formulae.brew.sh/api/formula.jws.json
######################################################################## 100.0%
==> Downloading https://formulae.brew.sh/api/cask.jws.json

Warning: libomp 16.0.1 is already installed and up-to-date.
To reinstall 16.0.1, run:
  brew reinstall libomp

What clang version do you use?

What clang version do you use? And which macOS and cmake version?

vcpkg@VCPKGMM-12 ~ % clang --version
Apple clang version 12.0.5 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin20.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

vcpkg@VCPKGMM-12 ~ % sw_vers
ProductName:    macOS
ProductVersion: 11.5.2
BuildVersion:   20G95

/Users/vcpkg/Monica/vcpkg/downloads/tools/cmake-3.25.1-osx/cmake-3.25.1-macos-universal/CMake.app/Contents/bin/cmake

Hm maybe try the following: https://open-box.readthedocs.io/en/latest/installation/openmp_macos.html

You should be able to look at CMakeError.log too see why the detection failed.

Hm maybe try the following: https://open-box.readthedocs.io/en/latest/installation/openmp_macos.html

I did so, the error persists, and the complete log file is attached.
vcpkg@VCPKGMM-12 fftw3 % export -p
export CC=/usr/bin/clang
export CFLAGS=' -I/usr/local/opt/libomp/include'
export CPPFLAGS=' -Xpreprocessor -fopenmp'
export CXX=/usr/bin/clang++
export CXXFLAGS=' -I/usr/local/opt/libomp/include'
export HOME=/Users/vcpkg
export LDFLAGS=' -Wl,-rpath,/usr/local/opt/libomp/lib -L/usr/local/opt/libomp/lib -lomp'
export LOGNAME=vcpkg
export OLDPWD=/Users/vcpkg/Monica
export -T PATH path=( /usr/local/bin /usr/bin /bin /usr/sbin /sbin /opt/X11/bin /Library/Apple/usr/bin )
export PWD=/Users/vcpkg/Monica/fftw3
export SHELL=/bin/zsh
export -i10 SHLVL=1
export SSH_TTY=/dev/ttys002
export TERM=xterm
export TMPDIR=/var/folders/6q/z1_zb3nd7w12wx8_7q3rqw640000gq/T/
export USER=vcpkg

config-arm64-osx-out.log
config-arm64-osx-dbg-CMakeCache.txt.log

Maybe
276 -- Configuring incomplete, errors occurred!
277 See also "/Users/vcpkg/Monica/fftw3/buildtrees/fftw3/arm64-osx-dbg/CMakeFiles/CMakeOutput.log".
278 See also "/Users/vcpkg/Monica/fftw3/buildtrees/fftw3/arm64-osx-dbg/CMakeFiles/CMakeError.log".

Maybe
276 -- Configuring incomplete, errors occurred!
277 See also "/Users/vcpkg/Monica/fftw3/buildtrees/fftw3/arm64-osx-dbg/CMakeFiles/CMakeOutput.log".
278 See also "/Users/vcpkg/Monica/fftw3/buildtrees/fftw3/arm64-osx-dbg/CMakeFiles/CMakeError.log".

CMakeOutput.log
CMakeError.log

Ah you have installed openmp via brew install libomp for x64 but build arm64 and then there is no openmp. Try building with target triplet x64-osx

Yes, I tried both x64-osx and arm64-osx, the error is the same.

Hm ok I have no idea what the error is on your side.

But the problem that openmp is not found on your computer is not caused by this PR. So it should not block this PR.

According to Wikipedia it is only for the PowerPC architecture?

@autoantwort Could you please provide the following test log of feature openmp for reference.

➜  vcpkg git:(fftw3-openmp) ✗ vcpkg x-set-installed 'fftw3[openmp]'
Detecting compiler hash for triplet arm64-osx...
The following packages will be rebuilt:
  * vcpkg-cmake:arm64-osx -> 2022-12-22
The following packages will be built and installed:
    fftw3[core,openmp]:arm64-osx -> 3.3.10#7
  * vcpkg-cmake-config:arm64-osx -> 2022-02-06#1
Additional packages (*) will be modified to complete this operation.
Removing 1/4 vcpkg-cmake:arm64-osx
Elapsed time to handle vcpkg-cmake:arm64-osx: 5.98 ms
Restored 0 package(s) from /Users/leanderSchulten/.cache/vcpkg/archives in 8.82 ms. Use --debug to see more details.
Attempting to fetch 3 package(s) from HTTP servers
Restored 3 package(s) from HTTP servers in 1.1 s. Use --debug to see more details.
Installing 2/4 vcpkg-cmake:arm64-osx...
Elapsed time to handle vcpkg-cmake:arm64-osx: 9.18 ms
Installing 3/4 vcpkg-cmake-config:arm64-osx...
Elapsed time to handle vcpkg-cmake-config:arm64-osx: 4.22 ms
Installing 4/4 fftw3:arm64-osx...
Elapsed time to handle fftw3:arm64-osx: 60.5 ms
Total install time: 1.2 s
fftw3 provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(FFTW3 CONFIG REQUIRED)
    target_link_libraries(main PRIVATE FFTW3::fftw3)

    find_package(FFTW3f CONFIG REQUIRED)
    target_link_libraries(main PRIVATE FFTW3::fftw3f)

    find_package(FFTW3l CONFIG REQUIRED)
    target_link_libraries(main PRIVATE FFTW3::fftw3l)

Flag info:reviewed for further review.
We failed to test the feature openmp locally, but the user test succeeded. See above for user-provided logs.

vcpkg@VCPKGMM-12 test % brew reinstall libomp
==> Fetching libomp
==> Downloading https://ghcr.io/v2/homebrew/core/libomp/manifests/16.0.2
Already downloaded: /Users/vcpkg/Library/Caches/Homebrew/downloads/e60a0e9b39ce5b69fb3618874d95c0fdd1837b31a10655688a4c26920aeca764--libomp-16.0.2.bottle_manifest.json
==> Downloading https://ghcr.io/v2/homebrew/core/libomp/blobs/sha256:5e9fe04b19c1c9d2c3c05f76e15ec97c5739250cb7fd5a05181
Already downloaded: /Users/vcpkg/Library/Caches/Homebrew/downloads/9aec7c067d5741a7a4e9cfc0843fdf5bbe3e5dbe24e5578805265f575ca4bdea--libomp--16.0.2.big_sur.bottle.tar.gz
==> Reinstalling libomp
==> Pouring libomp--16.0.2.big_sur.bottle.tar.gz
==> Caveats
libomp is keg-only, which means it was not symlinked into /usr/local,
because it can override GCC headers and result in broken builds.

For compilers to find libomp you may need to set:
  export LDFLAGS="-L/usr/local/opt/libomp/lib"
  export CPPFLAGS="-I/usr/local/opt/libomp/include"
==> Summary
🍺  /usr/local/Cellar/libomp/16.0.2: 7 files, 1.7MB
==> Running `brew cleanup libomp`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
vcpkg@VCPKGMM-12 test %

Nothing seems to be listening to that LDFLAGS or CPPFLAGS values though.
vcpkg@VCPKGMM-12 test % cat main.cpp
// main.cpp

#include <omp.h>
#include <stdio.h>

int main(){
        printf("%d\n", omp_get_max_threads());
}

vcpkg@VCPKGMM-12 test % c++ -fopenmp main.cpp
clang: error: unsupported option '-fopenmp'
clang: error: unsupported option '-fopenmp'
vcpkg@VCPKGMM-12 test % c++ -Xclang -fopenmp main.cpp
main.cpp:3:10: fatal error: 'omp.h' file not found
#include <omp.h>
         ^~~~~~~
1 error generated.
vcpkg@VCPKGMM-12 test % c++ -Xclang -fopenmp -I/usr/local/opt/libomp/include -L/usr/local/opt/libomp/lib -lomp main.cpp
vcpkg@VCPKGMM-12 test % ./a.out
12
vcpkg@VCPKGMM-12 test % echo $CPPFLAGS
-I/usr/local/opt/libomp/include
vcpkg@VCPKGMM-12 test % echo $LDFLAGS
-L/usr/local/opt/libomp/lib
vcpkg@VCPKGMM-12 test %

Cursory googling suggests that AppleClang isn't supposed to support OpenMP in the first place. Do we have any ports that use OpenMP working on MacOS at the moment?
Note that our MacOS machines are old-ish:
vcpkg@VCPKGMM-12 ~ % clang --version
Apple clang version 12.0.5 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin20.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
vcpkg@VCPKGMM-12 ~ % uname -v
Darwin Kernel Version 20.6.0: Wed Jun 23 00:26:31 PDT 2021; root:xnu-7195.141.2~5/RELEASE_X86_64
vcpkg@VCPKGMM-12 ~ % /usr/libexec/PlistBuddy -c "Print:ProductName" \
                        -c "Print:ProductVersion" \
                        -c "Print:ProductBuildVersion" /System/Library/CoreServices/SystemVersion.plist
macOS
11.5.2
20G95
vcpkg@VCPKGMM-12 ~ %

Do we have any ports that use OpenMP working on MacOS at the moment?

At least not in the ci.
I have apple clang 14.0.3. Maybe this makes a difference.

It should at least work if you add the flags in the triplet
set(VCPKG_CXX_FLAGS "-I/usr/local/opt/libomp/include")
set(VCPKG_C_FLAGS "-I/usr/local/opt/libomp/include")
set(VCPKG_LINKER_FLAGS "-L/usr/local/opt/libomp/lib")

It should at least work if you add the flags in the triplet

No joy:
"/usr/local/Cellar/cmake/3.26.3/bin/cmake" -E chdir "../../x64-osx-dbg" "/usr/local/Cellar/cmake/3.26.3/bin/cmake" "/Users/vcpkg/bion/vcpkg/buildtrees/fftw3/src/fftw-3-8854606e30.clean" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=/Users/vcpkg/bion/vcpkg/packages/fftw3_x64-osx/debug" "-DFETCHCONTENT_FULLY_DISCONNECTED=ON" "-DENABLE_FLOAT=ON" "-DENABLE_OPENMP=ON" "-DENABLE_THREADS=OFF" "-DWITH_COMBINED_THREADS=OFF" "-DENABLE_AVX2=OFF" "-DENABLE_AVX=OFF" "-DENABLE_SSE2=OFF" "-DENABLE_SSE=OFF" "-DBUILD_TESTS=OFF" "-DCMAKE_REQUIRE_FIND_PACKAGE_OpenMP=ON" "-DCMAKE_MAKE_PROGRAM=/usr/local/bin/ninja" "-DCMAKE_SYSTEM_NAME=Darwin" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=/Users/vcpkg/bion/vcpkg/scripts/toolchains/osx.cmake" "-DVCPKG_TARGET_TRIPLET=x64-osx" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=external" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=/Users/vcpkg/bion/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=-I/usr/local/opt/libomp/include" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=-I/usr/local/opt/libomp/include" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=-L/usr/local/opt/libomp/lib" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=/Users/vcpkg/bion/vcpkg" "-D_VCPKG_INSTALLED_DIR=/Users/vcpkg/bion/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DCMAKE_OSX_ARCHITECTURES=x86_64"
-- The C compiler identification is AppleClang <IP_ADDRESS>50022
-- The CXX compiler identification is AppleClang <IP_ADDRESS>50022
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for alloca.h
-- Looking for alloca.h - found
-- Looking for altivec.h
-- Looking for altivec.h - not found
-- Looking for c_asm.h
-- Looking for c_asm.h - not found
-- Looking for dlfcn.h
-- Looking for dlfcn.h - found
-- Looking for intrinsics.h
-- Looking for intrinsics.h - not found
-- Looking for inttypes.h
-- Looking for inttypes.h - found
-- Looking for libintl.h
-- Looking for libintl.h - not found
-- Looking for limits.h
-- Looking for limits.h - found
-- Looking for mach/mach_time.h
-- Looking for mach/mach_time.h - found
-- Looking for malloc.h
-- Looking for malloc.h - not found
-- Looking for memory.h
-- Looking for memory.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stdlib.h
-- Looking for stdlib.h - found
-- Looking for string.h
-- Looking for string.h - found
-- Looking for strings.h
-- Looking for strings.h - found
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for sys/time.h
-- Looking for sys/time.h - found
-- Looking for sys/stat.h
-- Looking for sys/stat.h - found
-- Looking for sys/sysctl.h
-- Looking for sys/sysctl.h - found
-- Looking for time.h
-- Looking for time.h - found
-- Looking for uintptr.h
-- Looking for uintptr.h - not found
-- Looking for unistd.h
-- Looking for unistd.h - found
-- Checking prototype drand48 for HAVE_DECL_DRAND48
-- Checking prototype drand48 for HAVE_DECL_DRAND48 - True
-- Checking prototype srand48 for HAVE_DECL_SRAND48
-- Checking prototype srand48 for HAVE_DECL_SRAND48 - False
-- Checking prototype cosl for HAVE_DECL_COSL
-- Checking prototype cosl for HAVE_DECL_COSL - True
-- Checking prototype sinl for HAVE_DECL_SINL
-- Checking prototype sinl for HAVE_DECL_SINL - True
-- Checking prototype memalign for HAVE_DECL_MEMALIGN
-- Checking prototype memalign for HAVE_DECL_MEMALIGN - False
-- Checking prototype posix_memalign for HAVE_DECL_POSIX_MEMALIGN
-- Checking prototype posix_memalign for HAVE_DECL_POSIX_MEMALIGN - True
-- Checking prototype _aligned_malloc for HAVE_DECL_ALIGNED_MALLOC
-- Checking prototype _aligned_malloc for HAVE_DECL_ALIGNED_MALLOC - False
-- Looking for clock_gettime
-- Looking for clock_gettime - found
-- Looking for gettimeofday
-- Looking for gettimeofday - found
-- Looking for getpagesize
-- Looking for getpagesize - found
-- Looking for drand48
-- Looking for drand48 - found
-- Looking for srand48
-- Looking for srand48 - found
-- Looking for memalign
-- Looking for memalign - not found
-- Looking for posix_memalign
-- Looking for posix_memalign - found
-- Looking for _aligned_malloc
-- Looking for _aligned_malloc - not found
-- Looking for mach_absolute_time
-- Looking for mach_absolute_time - found
-- Looking for alloca
-- Looking for alloca - found
-- Looking for isnan
-- Looking for isnan - found
-- Looking for snprintf
-- Looking for snprintf - found
-- Looking for strchr
-- Looking for strchr - found
-- Looking for sysctl
-- Looking for sysctl - not found
-- Looking for cosl
-- Looking for cosl - found
-- Looking for sinl
-- Looking for sinl - found
-- Check size of float
-- Check size of float - done
-- Check size of double
-- Check size of double - done
-- Check size of int
-- Check size of int - done
-- Check size of long
-- Check size of long - done
-- Check size of long long
-- Check size of long long - done
-- Check size of unsigned int
-- Check size of unsigned int - done
-- Check size of unsigned long
-- Check size of unsigned long - done
-- Check size of unsigned long long
-- Check size of unsigned long long - done
-- Check size of size_t
-- Check size of size_t - done
-- Check size of ptrdiff_t
-- Check size of ptrdiff_t - done
CMake Error at /usr/local/Cellar/cmake/3.26.3/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES)
Call Stack (most recent call first):
  /usr/local/Cellar/cmake/3.26.3/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  /usr/local/Cellar/cmake/3.26.3/share/cmake/Modules/FindOpenMP.cmake:577 (find_package_handle_standard_args)
  /Users/vcpkg/bion/vcpkg/scripts/buildsystems/vcpkg.cmake:852 (_find_package)
  CMakeLists.txt:128 (find_package)

-- Configuring incomplete, errors occurred!
ninja: build stopped: subcommand failed.
vcpkg@VCPKGMM-12 vcpkg % cat triplets/x64-osx.cmake
set(VCPKG_TARGET_ARCHITECTURE x64)
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE static)

set(VCPKG_CMAKE_SYSTEM_NAME Darwin)
set(VCPKG_OSX_ARCHITECTURES x86_64)

set(VCPKG_C_FLAGS "-I/usr/local/opt/libomp/include")
set(VCPKG_CXX_FLAGS "-I/usr/local/opt/libomp/include")
set(VCPKG_LINKER_FLAGS "-L/usr/local/opt/libomp/lib")

vcpkg@VCPKGMM-12 vcpkg %

Hm strange

Hm strange

To be clear, I'm happy to merge this even if our build lab chokes on it for now if I can get it to work ever :/

To be clear, I'm happy to merge this even if our build lab chokes on it for now if I can get it to work ever

👍

Retagging requires:author-response: This is blocked pending someone other than the author @autoantwort being able to demonstrate that it works.

@dg0yt Afaik you also have an mac. Can you maybe help verifying that this change is correct? You have to install libomp and add the following changes to the osx triplet: https://github.com/microsoft/vcpkg/pull/30833#issuecomment-1520997739

Retagging requires:author-response: This is blocked pending someone other than the author @autoantwort being able to demonstrate that it works.

Note: Instead of using the "requires-author-response" tag, we'll now be converting the pull request to draft. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@dg0yt Afaik you also have an mac. Can you maybe help verifying that this change is correct? You have to install libomp and add the following changes to the osx triplet: #30833 (comment)

I tested the PR on x64-osx.
The changes in #30833 (comment) are insufficient because they only affect flags passed to the tools. They don't affect the operation of find_path, find_library and consequently FindOpenMP.cmake. That's why find_package(OpenMP REQUIRED) fails.
What does work for me is using environment variables that affect the cmake commands. The build succeeds when I add the following lines to the triplet file:
set(ENV{INCLUDE} "/usr/local/opt/libomp/include")
set(ENV{LIB} "/usr/local/opt/libomp/lib")

NB: I don't suggest this particular modification. This should be somehow transformed into proper dependencies/testing/messaging instead.

PS: As usual, CMAKE_FIND_DEBUG_MODE was a good help.

Make it active again to hope more people see it, then help verify.

IMO it needs more work first. @autoantwort Any questions about my test results?

IMO it needs more work first. @autoantwort Any questions about my test results?

No not really. I wounder then why it worked on my computer, but I am very thankful that you have found the reason why it not worked on x64 macs ❤
But I am curious what changes you requested on this PR?

But I am curious what changes you requested on this PR?

@dg0yt

But I am curious what changes you requested on this PR?

https://github.com/microsoft/vcpkg/pull/30833#issuecomment-1541401288

We have some instruction here in the PR, but not when the build fails. It would be nice to give the user guidance on error.
IIRC there are different paths for arm64 brew vs x64 brew.
Again, making find_package(OpenMP) work isn't solved by the flags. It is solved by informing cmake. Apart from the environment variables I mentioned, there are other environment variables (e.g.PATH`) and cmake variables.

Hm. My motivation was to make the openmp feature functional if you already have an working openmp setup, not to write documentation on how to create a working openmp setup (even though i think this is a good idea).
There are 14 ports which have an openmp feature. Imo it don't makes sense to add documentation especially to this port.
My proposal: Leave this PR as it is: You can use the openmp feature if you have a working openmp setup.
Another PR: Write documentation on how to create an working openmp setup.


Update bcrypt-ruby dependency to be compatible with Rails 4

bcrypt-ruby 3.1.x is required for has_secure_password, but the gemspec does not allow for that particular version (I thought it would at first though)

Looks to be superseded by #74

We have switched to the replacement gem bcrypt. :)


Failed to git commit: git is not initialized

Summary
When initializing the gopass store, I get an error "Failed to git commit"
$ go pass init
🍭 Initializing a new password store ...
🔑 Searching for usable private Keys ...
⚠ Hint: Use 'gopass init <subkey> to use subkeys!'
❌ Failed to git commit: git is not initialized
❌ Failed to export missing public keys: some keys failed

Steps To Reproduce
gopass init
Expected behavior
That I get no errors
Environment

OS: Arch linux
OS version: Linux hostname 5.15.90-1-lts #1 SMP Tue, 24 Jan 2023 12:46:03 +0000 x86_64 GNU/Linux
gopass Version: gopass 1.15.3 go1.19.5 linux amd64
Installation method: pacman community package

Additional context

Ok my bad I have to use gopass setup instead of gopass init

Actually gopass init should also work ...

This seems to be more of a cosmetic error (but still a bug).
I can mostly reproduce this, i.e. gopass init works as expected, the store is in a good state afterwards but I do still get the annoying error message. Will fix that.

Thanks