Mimicking losses confusion

To stabilize the training process and avoid further regularization
effect, we fork auxiliary classifiers from each node of
the backbone network with probabilities toggling between
zero and one in our main experiments, following a binary
sampling strategy along the axis of network forward propagation.

I am not sure what these words means.  From the code https://github.com/d-li14/DHM/blob/master/imagenet.py#L326, it seems you just calculate all the combinations of mimicking losses.

As stated by the paper, forking auxiliary branch or not at each node of the backbone is defined as a dynamic process. Here the nodes with auxiliary branches imply that we fork with the probability 1, while all the other nodes without branches with probability 0. This is the so-called binary (0-1) sampling. You could further try Bernoulli sampling with the probability of 0.5 in these existing branches with the commented lines https://github.com/d-li14/DHM/blob/master/imagenet.py#L334-L336.


Allow creation of GridFunction from a function without jit

See this question: https://groups.google.com/forum/#!topic/bempp/K5L_rQr5xZA
The function in that example includes the assembly of a potential operator, so (I think) cannot be jit compiled by numba. In this case, you should be able to disable jit when assembling the GridFunction

I think this is done in the staging branch, but will add a test to confirm


Remove the /Finalizers switch

The option itself is preserved for compatibility, but the behavior is disabled
and the checkbox for it is removed from the PerfView UI.
Fixes #242

Codecov Report

Merging #247 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   21.83%   21.83%   -0.01%
==========================================
  Files         190      190
  Lines      111682   111680       -2
  Branches    11196    11183      -13
==========================================
- Hits        24391    24388       -3
- Misses      87268    87269       +1
  Partials       23       23

Flag
Coverage Δ

#2015
21.83% <0%> (-0.01%)
:arrow_down:

#2017
21.83% <0%> (-0.01%)
:arrow_down:

#Debug
13.1% <0%> (ø)
:arrow_up:

#Release
12.02% <0%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

src/PerfView/Dialogs/RunCommandDialog.xaml
0% <ø> (ø)
:arrow_up:

src/PerfView/Dialogs/RunCommandDialog.xaml.cs
22.75% <ø> (-0.16%)
:arrow_down:

src/PerfView/GcStats.cs
11.16% <0%> (ø)
:arrow_up:

src/PerfView/CommandProcessor.cs
15.94% <0%> (-0.08%)
:arrow_down:

src/PerfView/CommandLineArgs.cs
7.28% <0%> (-0.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e605c6...b87a2e3. Read the comment docs.

LGTM


Modify drop off routine

by using the new collection disk issue #33 we can now guarantee that a drop off event will place a cube inside the center and no longer will robots get stuck in the center
This is possible due to the tags around the edge all pointing towards the center.
Potential feature addition given time to complete it.

Getting stuck in the center is addressed in 586cf7a7822d1e514ed9ea046a73f2a78dc3d0d8


IOU - Android -Unable to delete second added receipt on manual request once first is deleted

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.3-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

As Employee navigate to Workspace chat
Create manual request
Navigate to request and add receipt
Delete the receipt
Add another receipt
Delete the receipt

Expected Result:
Once deleted the receipt should not appear anymore
Actual Result:
Unable to delete the second added receipt on manual request once first receipt is deleted. The receipt reappears
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/d63e8569-769e-4042-b3cc-e07eee9b1d74
View all open jobs on GitHub

@twisterdotcom  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsp

It isn't reproducible

Agree, I cannot recreate. https://drive.google.com/file/d/1AqTK3d_CHPqoJn-TZZUOg5Xv0q2Aex-D/view?usp=sharing


Update issue and pull request templates

@mcdonamp @puf  please review

One comment, otherwise LGTM. Also, glad that you're officially taking over for me (even though that was always the case).

<3 LGTM


Have server return errors in request.

You put it in com.treode.twitter.server.handler.SpecTools? DrivesAttachHandlerSpec inherits from that, so the def should be in scope. Can you show me the code?

I put up a gist with what I changed for DrivesAttachHandlerSpec. After adding the stringToPath function to SpecTools, I still get a "type mismatch" error from trying to compile the tests.
For the Jackson Serializer, we don't need a Deserializer, right?
I'm also having trouble using a type parameter [A] with a companion object, so that I can write something like object NotificationSerializer extends StdSerializer [Notification [A]] (classOf [Notification [A]]).

Maybe it's
object NotificationSerializer extends StdSerializer [Notification [_]] (classOf [Notification [_]])

That doesn't work for me -- I get the error "Unit is not defined".

I just tried it, and had no problems. There must be something else going on in your code.

You're right -- I just tried it again and it got it to work.


gh-85 add tests

I added the test for the binder. There is still one Test failing

Thanks a bunch, @Andy2003 !


Tradfri & OSRAM not available after update to deCONZ 5.2 and HASS 0.105.5

Hi
I updated the HASS to the mentioned version and the deCONZ Add-In to 5.2.
My TRADFRI and OSRAM components are now on unavailable in HASS, working in deCONZ.
Has anyone seen the problem, too??
Thx

I'm running those devices as well, everything up and running normally.

No issues. Look into logs, maybe deconz rebuild your network


TypeError in properties.py 0.0.9

`Traceback (most recent call last):
File "/opt/pyenv/versions/sem-app/bin/uvicorn", line 8, in
sys.exit(main())
File "/opt/pyenv/versions/3.9.4/envs/sem-app/lib/python3.9/site-packages/click/core.py", line 1157, in call
return self.main(*args, **kwargs)
File "/opt/pyenv/versions/3.9.4/envs/sem-app/lib/python3.9/site-packages/click/core.py", line 1078, in main
rv = self.invoke(ctx)
File "/opt/pyenv/versions/3.9.4/envs/sem-app/lib/python3.9/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/opt/pyenv/versions/3.9.4/envs/sem-app/lib/python3.9/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/opt/pyenv/versions/3.9.4/envs/sem-app/lib/python3.9/site-packages/uvicorn/main.py", line 418, in main
run(
File "/opt/pyenv/versions/3.9.4/envs/sem-app/lib/python3.9/site-packages/uvicorn/main.py", line 587, in run
server.run()
File "/opt/pyenv/versions/3.9.4/envs/sem-app/lib/python3.9/site-packages/uvicorn/server.py", line 62, in run
return asyncio.run(self.serve(sockets=sockets))
File "/opt/pyenv/versions/3.9.4/lib/python3.9/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "uvloop/loop.pyx", line 1517, in uvloop.loop.Loop.run_until_complete
File "/opt/pyenv/versions/3.9.4/envs/sem-app/lib/python3.9/site-packages/uvicorn/server.py", line 69, in serve
config.load()
File "/opt/pyenv/versions/3.9.4/envs/sem-app/lib/python3.9/site-packages/uvicorn/config.py", line 458, in load
self.loaded_app = import_from_string(self.app)
File "/opt/pyenv/versions/3.9.4/envs/sem-app/lib/python3.9/site-packages/uvicorn/importer.py", line 21, in import_from_string
module = importlib.import_module(module_str)
File "/opt/pyenv/versions/3.9.4/lib/python3.9/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1030, in _gcd_import
File "", line 1007, in _find_and_load
File "", line 986, in _find_and_load_unlocked
File "", line 680, in _load_unlocked
File "", line 790, in exec_module
File "", line 228, in _call_with_frames_removed
File "/opt/pyenv/versions/3.9.4/envs/sem-app/lib/python3.9/site-packages/module_name/my_app_name/main.py", line 8, in
from fastapi_babel import Babel, BabelConfigs
File "/opt/pyenv/versions/3.9.4/envs/sem-app/lib/python3.9/site-packages/fastapi_babel/init.py", line 1, in
from .core import Babel, BabelCli, _
File "/opt/pyenv/versions/3.9.4/envs/sem-app/lib/python3.9/site-packages/fastapi_babel/core.py", line 11, in
from .properties import RootConfigs
File "/opt/pyenv/versions/3.9.4/envs/sem-app/lib/python3.9/site-packages/fastapi_babel/properties.py", line 7, in
class RootConfigs:
File "/opt/pyenv/versions/3.9.4/envs/sem-app/lib/python3.9/site-packages/fastapi_babel/properties.py", line 9, in RootConfigs
ROOT_DIR: str | pathlib.Path
TypeError: unsupported operand type(s) for |: 'type' and 'type'`

From the error message, it seems to me that you are using Python 3.9. If you look at the RootConfigs class in properties.py you will find that the type of ROOT_DIR property is given using the "|" operator. This operator is only supported in versions of Python 3.10+. You can either upgrade your version of Python or modify the RootConfigs class like this:
from typing import Union

@dataclass
class RootConfigs:

    ROOT_DIR: Union[str, pathlib.Path]
...

From the error message, it seems to me that you are using Python 3.9. If you look at the RootConfigs class in properties.py you will find that the type of ROOT_DIR property is given using the "|" operator. This operator is only supported in versions of Python 3.10+. You can either upgrade your version of Python or modify the RootConfigs class like this:
from typing import Union

@dataclass
class RootConfigs:

    ROOT_DIR: Union[str, pathlib.Path]
...

I will resolve the problem.

@brutalsuperman
the problem fixed successfully.
[FIX] type error for union has been fixed #42


Remove unused p/invoke definitions (some invalid for x64)

It caught my eye that the OVERLAPPED struct is using int where it should be using IntPtr or UIntPtr. (See https://docs.microsoft.com/en-us/windows/win32/api/minwinbase/ns-minwinbase-overlapped). The ULONG_PTR type is pointer sized, not 32-bit, so the OVERLAPPED struct is broken when used in 64-bit processes.
This seemed pretty problematic since the assembly compiles as Any CPU until I saw that the OVERLAPPED struct became unused at https://github.com/mikeobrien/HidLibrary/pull/5/files#diff-aea9c468d4ff8fdd02498d7fe48c0caeR315. To see more clearly, I removed all unused types, methods, and groups of constants in NativeMethods.cs.
Related: #31

The CreateFile definition is actually invalid though, using int hTemplateFile for the final parameter instead of IntPtr hTemplateFile. I'll plan to update this PR and change the title if this seems good to you.

Thank you for finding and fixing this!


Small docs edits

Readability changes and syntax in usage example fixed

I have sneakily added a code edit into this PR, a small typo on a user-displayed string. Since it wasn't a huge structural change I figured I could slip it in like a rider on a Parliamentary Bill...


Non consecutive IDs

I get an error "Non consecutive IDs found in raw data" for SWC files created by Pneumatk software. The files are correct. SWC standard requires only increasing IDs, ie ID_parent < ID_child, but NeuroM raises exception if there is a gap between the parent ID and all its children. For example, in the file
1 1 0.0 0.0 0.0 1.0 -1
3 3 1.0 0.0 0.0 0.1 1
4 3 2.0 0.0 0.0 0.1 3

NeuroM wants the dendrite to start with ID=2, not 3.

We followed this specification. In it, here is this:
n T x y z R P
n is an integer label that identifies the current point and increments by one
from one line to the next.

Do you know of a different SWC "standard"? If so, a reference would be good.

Which generally agrees with the second swc format description I could find :)
http://www.neuronland.org/NLMorphologyConverter/MorphologyFormats/SWC/Spec.html
"integer value, generally continuous, ..."

@lidakanari Do you think we should look into lift this restriction?

If the rest of the structure is well defined, we don't really need this constraint.

I refer to neuromorpho.org (http://neuromorpho.org/myfaq.jsp, "What is SWC format?"): "The index for parent compartments are always less than child compartments." This follows original definition by Cannon et al, 1998 ( http://www.sciencedirect.com/science/article/pii/S0165027098000910). Thus the continuity requirement seems to be excessive.
In fact, it is sufficient for IDs to be unique and define a tree. They don't need to be placed in increasing or any other order; they even don't need to be integers, actually.

It required some changes to the code, but  hopefully pull request #192 fixes this.

Hi Alexander:
I have taken this definition to be the one that specifies swc
http://research.mssm.edu/cnic/swc.html
and here the first one (or more) is the soma and has id 1, so the first child must have parent id 1 and given that ids have to increment by 1 it gives the restriction that ids must be consecutive integers.
This may mean there are competing definitions of “swc format”.
Julian
On 18 Dec 2015, at 17:30, Alexander Kozlov <notifications<EMAIL_ADDRESS>wrote:
I refer to neuromorpho.orghttp://neuromorpho.org (http://neuromorpho.org/myfaq.jsp, "What is SWC format?"): "The index for parent compartments are always less than child compartments." This follows original definition by Cannon et al, 1998 ( http://www.sciencedirect.com/science/article/pii/S0165027098000910). Thus the continuity requirement seems to be excessive.
In fact, it is sufficient for IDs to be unique and define a tree. They don't need to be placed in increasing or any other order; they even don't need to be integers, actually.
—
Reply to this email directly or view it on GitHubhttps://github.com/BlueBrain/NeuroM/issues/191#issuecomment-165826833.


Simpler mapping

Regarding the README, a simpler mapping exists:
vim.keymap.set("n", "<leader><leader>", require("telescope").extensions.smart_open.smart_open)

Interesting.  I tried this just now and it didn't work.  I think it's because where my keymappings are defined, the plugin maybe isn't loaded yet.  Doing this does work:
vim.keymap.set("n", "<leader><leader>", function ()
  require("telescope").extensions.smart_open.smart_open()
end)


Add the ability to reset the connection in the Client Module by configurable discriminators

For better resource consumption and load balancing, introduce the ability to reset the connection based on time or the invocation count.
Consumer applications or APIs can also handle it within their code, as an alternative.
This is an exploratory task and an enhancement to be introduced after careful consideration

Light4j recommends caching client connection for reuse and periodically closing it, is there any plan to build functionality/ module(say, ConnectionCache) to handle this?
This is what it would do -

 ConnectionCache maintains a map of different API hosts and corresponding connection objects –

{
“10.2.xx.xx:9001” : ClientConnectionAPI_A_9001,
“10.2.xx.xx:9002” : ClientConnectionAPI_A_9002,
“10.3.xx.xx:8402” : ClientConnectionAPI_B_8402,
“10.3.xx.xx:8403” : ClientConnectionAPI_B_8403,
“10.3.xx.xx:8404” : ClientConnectionAPI_B_8404,
………and so on
}
2)      Client code gets connection object for an API host(could be the one returned by cluster.serviceToUrl()) –
ClientConnection  = ConnectionCache.getConnection(“10.2.xx.xx:9002”);

 ConnectionCache could also do the job of periodically closing the connection after a number of requests or minutes, and assign a new connection object.

This has been addressed in another issue and the configuration is in the client.yml file.


Still in maintainence?

Still in maintainence?
The latest version is about 8 month ago.

Doesn't look like it's being maintained anymore...

What a pitty


fromEvent + debounceTime : manually triggered keyUp event - set event.target as null if element is not in DOM

Bug Report
Current Behavior
if element not in dom - debounceTime removes event.target
Reproduction
https://codepen.io/kievsash/pen/byqZpP?editors=1010
const mockInput = document.createElement('input');
//document.body.appendChild(mockInput);
mockInput.value = 'test';
mockInput.dispatchEvent(new KeyboardEvent('keyup', {'key': 'y'}));

const search$ = fromEvent(mockInput, 'keyup').pipe(

  tap((e) => console.log('event target1:', e.target)), // here i see input
  debounceTime(1000),
  tap((e) => console.log('event target2:', e.target)), // here i see null

  map((event) => event.target && event.target.value)
);

search$.subscribe();

mockInput.dispatchEvent(new KeyboardEvent('keyup', {'key': 'y'}));

Expected behavior
I expect event.target to work event without element in DOM.
Environment

Runtime: [e.g. Node v${x}, Chrome v${x}]
RxJS version: 6.5

Possible Solution
document.body.appendChild(mockInput); // anyway I use it for unit tests
Additional
Found something similar: https://github.com/ReactiveX/rxjs/issues/1577

Closing this because it's not an RxJS issue. The problem can be reproduced with setTimeout, so RxJS is behaving as expected:
const e = new KeyboardEvent('keyup', { key: 'y' });
mockInput.dispatchEvent(e);
setTimeout(() => console.log(e.target), 1000);


Remove json tags from libvirt domain struct

The Domain struct in
https://github.com/kubevirt/kubevirt/blob/master/pkg/virt-handler/virtwrap/schema.go
contains xml and json tags. It is only there to map to libvirt xml. So the json tags should be removed.

Working on it!


Improve UI design (Change some colors)

Since the colors and gradations were a little outdated, I made some changes to the UI design. 😃

Just making the entire default viewer, which is shipping in Firefox, essentially black really isn't an improvement at all. There's a number of issues such as e.g. the main toolbar being indistinguishable from the rest of the viewer, and generally a fairly incomplete attempt at changing the styling in any coherent way.
For a custom implementation you're obviously free to do whatever you want, but I don't think this is something that belongs in the main PDF.js library.

@Snuffleupagus
Okay, I will change only selection colors.

Okay, I will change only selection colors.

That's already tracked in issue #9184, and it's not really clear if/how any changes should actually be made here (since there's a degree of subjectivity involved).
As for these particular changes, they are not an improvement since for one they make the actual text less clear when it's selected (probably caused by the change in opacity).

I agree with the above. The only thing we may consider is #9702, but the designers from Firefox should come up with a design first.


Get corrected URL in search results

It's not necessarily an issue, but a feature request. I'll use my example to explain what I'm asking for.
I created a dynamic FAQ page, so that the parent node has a template that loops through and displays all of the children nodes (which holds a single question and answer per child) on the parent's URL, /faq. None of the children nodes use a template because I don't anticipate using those URLs that get generated.
I want the FAQ page to be searchable, but as it works right now, the results that get pulled from searching through the FAQ's questions and answers links to the default URLs of those children, which results in 404 pages when clicked because they simply don't have templates. My goal is for those links to be redirected to a specified URL.
Now these children nodes have the special "umbracoURLAlias" and "umbracoUrlName" properties. The latter which changes the URL relative to its parent, so it's not really any help redirecting to its parent, and it would still result in a 404 because again, this node doesn't have a template. The former only works when the value in the property has been typed into the browser, so it doesn't necessarily apply in this situation, because the /faq URL already exists, it just renders that page instead of the children pages using it as an alias. Essentially, it does nothing for this particular case.
So I was wondering if you could set it up, or if you could teach me how to set it up because I'm not quite that adept at MVC or C# yet, so that when it renders the link for the URL, if it could first check for the "umbracoURLAlias" or other specified property name, and if that's left blank, then use the default URL as usual.
Please and thanks!

TL;DR:
If a node has a rewritten path (using umbracoUrlAlias or umbracoUrlName) then check to see if that path 404s, if it doesn't, display the result.
If a node does not have a rewritten path, then check if it has a template, if it doesn't, display the result.
If the node does not have a rewritten path, does have a template, display the result as normal.


Fix voiceConnectionTimeout option is not applied correctly

voiceConnectionTimeout is not in ShoukakuDefaults, so when mergeDefault() is called, options.voiceConnectionTimeout becomes undefined.
Adding voiceConnectionTimeout to ShoukakuDefaults fixes this.

yes my bad lol


make reqmgr and reqmgr2 call automatically

fixes #6303  (Do not merge still need to be tested)

@amaltaro, Please review

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/729/ for details

Summary of pylint changes for pull request 6308:

Score for src/python/WMCore/WorkQueue/WorkQueueReqMgrInterface.py changed from 9.51 to 9.43 with 0 (12) total errors (warnings)

src/python/WMComponent/TaskArchiver/CleanCouchPoller.py fails the pylint check. Report follows:

Line 19 in CleanCouchPoller R0902 Too many instance attributes (14/7)
Line 108 in CleanCouchPoller.algorithm W0703 Catching too general exception Exception
Line 83 in CleanCouchPoller.algorithm W1201 Specify string format arguments as logging function parameters
Line 86 in CleanCouchPoller.algorithm W1201 Specify string format arguments as logging function parameters
Line 94 in CleanCouchPoller.algorithm W1201 Specify string format arguments as logging function parameters
Line 96 in CleanCouchPoller.algorithm W1201 Specify string format arguments as logging function parameters
Line 99 in CleanCouchPoller.algorithm W1201 Specify string format arguments as logging function parameters
Line 101 in CleanCouchPoller.algorithm W1201 Specify string format arguments as logging function parameters
Line 104 in CleanCouchPoller.algorithm W1201 Specify string format arguments as logging function parameters
Line 106 in CleanCouchPoller.algorithm W1201 Specify string format arguments as logging function parameters
Line 135 in CleanCouchPoller.archiveWorkflows W1201 Specify string format arguments as logging function parameters
Line 173 in CleanCouchPoller.deleteWorkflowFromJobCouch W0703 Catching too general exception Exception
Line 175 in CleanCouchPoller.deleteWorkflowFromJobCouch W1201 Specify string format arguments as logging function parameters
Line 141 in CleanCouchPoller.deleteWorkflowFromJobCouch R0912 Too many branches (14/12)
Line 203 in CleanCouchPoller.cleanAllLocalCouchDB W1201 Specify string format arguments as logging function parameters
Line 206 in CleanCouchPoller.cleanAllLocalCouchDB W1201 Specify string format arguments as logging function parameters
Line 209 in CleanCouchPoller.cleanAllLocalCouchDB W1201 Specify string format arguments as logging function parameters
Line 212 in CleanCouchPoller.cleanAllLocalCouchDB W1201 Specify string format arguments as logging function parameters
Line 215 in CleanCouchPoller.cleanAllLocalCouchDB W1201 Specify string format arguments as logging function parameters
Line 55 in CleanCouchPoller.setup W0201 Attribute 'reqmgr2Svc' defined outside init
Line 48 in CleanCouchPoller.setup W0201 Attribute 'centralRequestDBReader' defined outside init
Line 67 in CleanCouchPoller.setup W0201 Attribute 'jobCouchdb' defined outside init
Line 53 in CleanCouchPoller.setup W0201 Attribute 'centralRequestDBWriter' defined outside init
Line 62 in CleanCouchPoller.setup W0201 Attribute 'centralRequestDBWriter' defined outside init
Line 43 in CleanCouchPoller.setup W0201 Attribute 'archiveDelayHours' defined outside init
Line 40 in CleanCouchPoller.setup W0201 Attribute 'teamName' defined outside init
Line 52 in CleanCouchPoller.setup W0201 Attribute 'deletableState' defined outside init
Line 60 in CleanCouchPoller.setup W0201 Attribute 'deletableState' defined outside init
Line 68 in CleanCouchPoller.setup W0201 Attribute 'jobsdatabase' defined outside init
Line 57 in CleanCouchPoller.setup W0201 Attribute 'reqmgrSvc' defined outside init
Line 44 in CleanCouchPoller.setup W0201 Attribute 'wmstatsCouchDB' defined outside init
Line 69 in CleanCouchPoller.setup W0201 Attribute 'fwjrdatabase' defined outside init
Line 72 in CleanCouchPoller.setup W0201 Attribute 'statsumdatabase' defined outside init
Line 42 in CleanCouchPoller.setup W0201 Attribute 'useReqMgrForCompletionCheck' defined outside init
plus 34 comments on code style

Abbreviated pylint report for src/python/WMComponent/TaskArchiver/TaskArchiverPoller.py follows:

Line 79 in FileEncoder.default E0202 An attribute defined in json.encoder line 174 hides this method
Line 162 in uploadPublishWorkflow E1123 Unexpected keyword argument 'name' in method call
Line 1004 in TaskArchiverPoller.publishRecoPerfToDashBoard W0612 Unused variable 'nothing'
Line 1004 in TaskArchiverPoller.publishRecoPerfToDashBoard W0612 Unused variable 'procDataSet'
Line 1150 in TaskArchiverPoller.createAndUploadPublish W0612 Unused variable 'taskDir'
plus 66 total warnings
plus 176 comments on code style

src/python/WMCore/WorkQueue/WorkQueueReqMgrInterface.py got worse in pylint. Report follows:

Line 51 in WorkQueueReqMgrInterface.call W0703 Catching too general exception Exception
Line 57 in WorkQueueReqMgrInterface.call W0703 Catching too general exception Exception
Line 63 in WorkQueueReqMgrInterface.call W0703 Catching too general exception Exception
Line 68 in WorkQueueReqMgrInterface.call W0703 Catching too general exception Exception
Line 85 in WorkQueueReqMgrInterface.queueNewRequests W0703 Catching too general exception Exception
Line 124 in WorkQueueReqMgrInterface.queueNewRequests W0703 Catching too general exception Exception
Line 103 in WorkQueueReqMgrInterface.queueNewRequests W0703 Catching too general exception Exception
Line 134 in WorkQueueReqMgrInterface.queueNewRequests W0703 Catching too general exception Exception
Line 194 in WorkQueueReqMgrInterface.report W0703 Catching too general exception Exception
Line 145 in WorkQueueReqMgrInterface.report R0912 Too many branches (14/12)
Line 211 in WorkQueueReqMgrInterface._getRequestsByTeamsAndStatus W0102 Dangerous default value [] as argument
Line 341 in WorkQueueReqMgrInterface.addNewElementsToOpenRequests W0703 Catching too general exception Exception
Line 365 in WorkQueueReqMgrInterface.addNewElementsToOpenRequests W0703 Catching too general exception Exception
Line 21 in WorkQueueReqMgrInterface R0923 Interface not implemented
plus 38 comments on code style

No changes to unit tests for pull request 6308

After reading up on this, I understand this one now:

On Oct 2, 2015, at 11:58, DMWM Autobot<EMAIL_ADDRESS>wrote:
ine 86 in CleanCouchPoller.algorithm W1201 Specify string format arguments as logging function parameters
Line 94 in CleanCouchPoller.algorithm W1201 Specify string format arguments as logging function parameters
Line 96 in CleanCouchPoller.algorithm W1201 Specify string format arguments as logging function parameters
Line 99 in CleanCouchPoller.algorithm W1201 Specify string format arguments as logging function parameters

After reading up on this, I understand this one now:
if you do logging.debug(‘%s is the color of %s’ % (‘blue’, ‘sky’)) python builds this string and then passes it to debug where it is promptly thrown away. if instead you do
logging.debug(‘%s is the color of %s’ , ‘blue’, ‘sky’) the string is only created if you actually are going to output it. This can be a performance issue if there are lots of strings, especially if they are, like debug, never used.
Eric

test this please

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/730/ for details

if you do
logging.debug(‘%s is the color of %s’ % (‘blue’, ‘sky’))

python builds this string and then passes it to debug where it is promptly thrown away. if instead you do
logging.debug(‘%s is the color of %s’ , ‘blue’, ‘sky’)

the string is only created if you actually are going to output it. This can be a performance issue if there are lots of strings, especially if they are, like debug, never used.

Thanks Eric, I was wondering whether there is a way to not create the sting unless it is debug mode. I didn't know about, this that is good too know.

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/731/ for details

Summary of pylint changes for pull request 6308:

Score for src/python/WMCore/WorkQueue/WorkQueueReqMgrInterface.py changed from 9.51 to 9.43 with 0 (12) total errors (warnings)

Abbreviated pylint report for src/python/WMComponent/TaskArchiver/TaskArchiverPoller.py follows:

Line 79 in FileEncoder.default E0202 An attribute defined in json.encoder line 174 hides this method
Line 162 in uploadPublishWorkflow E1123 Unexpected keyword argument 'name' in method call
Line 1004 in TaskArchiverPoller.publishRecoPerfToDashBoard W0612 Unused variable 'nothing'
Line 1004 in TaskArchiverPoller.publishRecoPerfToDashBoard W0612 Unused variable 'procDataSet'
Line 1150 in TaskArchiverPoller.createAndUploadPublish W0612 Unused variable 'taskDir'
plus 66 total warnings
plus 176 comments on code style

src/python/WMCore/WorkQueue/WorkQueueReqMgrInterface.py got worse in pylint. Report follows:

Line 51 in WorkQueueReqMgrInterface.call W0703 Catching too general exception Exception
Line 57 in WorkQueueReqMgrInterface.call W0703 Catching too general exception Exception
Line 63 in WorkQueueReqMgrInterface.call W0703 Catching too general exception Exception
Line 68 in WorkQueueReqMgrInterface.call W0703 Catching too general exception Exception
Line 85 in WorkQueueReqMgrInterface.queueNewRequests W0703 Catching too general exception Exception
Line 124 in WorkQueueReqMgrInterface.queueNewRequests W0703 Catching too general exception Exception
Line 103 in WorkQueueReqMgrInterface.queueNewRequests W0703 Catching too general exception Exception
Line 134 in WorkQueueReqMgrInterface.queueNewRequests W0703 Catching too general exception Exception
Line 194 in WorkQueueReqMgrInterface.report W0703 Catching too general exception Exception
Line 145 in WorkQueueReqMgrInterface.report R0912 Too many branches (14/12)
Line 211 in WorkQueueReqMgrInterface._getRequestsByTeamsAndStatus W0102 Dangerous default value [] as argument
Line 341 in WorkQueueReqMgrInterface.addNewElementsToOpenRequests W0703 Catching too general exception Exception
Line 365 in WorkQueueReqMgrInterface.addNewElementsToOpenRequests W0703 Catching too general exception Exception
Line 21 in WorkQueueReqMgrInterface R0923 Interface not implemented
plus 38 comments on code style

Unit test changes for pull request 6308:

WMCore_t.WorkQueue_t.Policy_t.Start_t.Block_t.BlockTestCase:testRunWhitelist changed from success to error

Previously working unit tests have failed!

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/732/ for details

Summary of pylint changes for pull request 6308:

Score for src/python/WMCore/WorkQueue/WorkQueueReqMgrInterface.py changed from 9.51 to 9.43 with 0 (12) total errors (warnings)

Abbreviated pylint report for src/python/WMComponent/TaskArchiver/TaskArchiverPoller.py follows:

Line 79 in FileEncoder.default E0202 An attribute defined in json.encoder line 174 hides this method
Line 162 in uploadPublishWorkflow E1123 Unexpected keyword argument 'name' in method call
Line 1004 in TaskArchiverPoller.publishRecoPerfToDashBoard W0612 Unused variable 'nothing'
Line 1004 in TaskArchiverPoller.publishRecoPerfToDashBoard W0612 Unused variable 'procDataSet'
Line 1150 in TaskArchiverPoller.createAndUploadPublish W0612 Unused variable 'taskDir'
plus 66 total warnings
plus 176 comments on code style

src/python/WMCore/WorkQueue/WorkQueueReqMgrInterface.py got worse in pylint. Report follows:

Line 51 in WorkQueueReqMgrInterface.call W0703 Catching too general exception Exception
Line 57 in WorkQueueReqMgrInterface.call W0703 Catching too general exception Exception
Line 63 in WorkQueueReqMgrInterface.call W0703 Catching too general exception Exception
Line 68 in WorkQueueReqMgrInterface.call W0703 Catching too general exception Exception
Line 85 in WorkQueueReqMgrInterface.queueNewRequests W0703 Catching too general exception Exception
Line 124 in WorkQueueReqMgrInterface.queueNewRequests W0703 Catching too general exception Exception
Line 103 in WorkQueueReqMgrInterface.queueNewRequests W0703 Catching too general exception Exception
Line 134 in WorkQueueReqMgrInterface.queueNewRequests W0703 Catching too general exception Exception
Line 194 in WorkQueueReqMgrInterface.report W0703 Catching too general exception Exception
Line 145 in WorkQueueReqMgrInterface.report R0912 Too many branches (14/12)
Line 211 in WorkQueueReqMgrInterface._getRequestsByTeamsAndStatus W0102 Dangerous default value [] as argument
Line 341 in WorkQueueReqMgrInterface.addNewElementsToOpenRequests W0703 Catching too general exception Exception
Line 365 in WorkQueueReqMgrInterface.addNewElementsToOpenRequests W0703 Catching too general exception Exception
Line 21 in WorkQueueReqMgrInterface R0923 Interface not implemented
plus 38 comments on code style

No changes to unit tests for pull request 6308

test this please

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/737/ for details

Summary of pylint changes for pull request 6308:

Score for src/python/WMCore/WorkQueue/WorkQueueReqMgrInterface.py changed from 9.51 to 9.43 with 0 (12) total errors (warnings)

Abbreviated pylint report for src/python/WMComponent/TaskArchiver/TaskArchiverPoller.py follows:

Line 79 in FileEncoder.default E0202 An attribute defined in json.encoder line 174 hides this method
Line 162 in uploadPublishWorkflow E1123 Unexpected keyword argument 'name' in method call
Line 1004 in TaskArchiverPoller.publishRecoPerfToDashBoard W0612 Unused variable 'nothing'
Line 1004 in TaskArchiverPoller.publishRecoPerfToDashBoard W0612 Unused variable 'procDataSet'
Line 1150 in TaskArchiverPoller.createAndUploadPublish W0612 Unused variable 'taskDir'
plus 66 total warnings
plus 176 comments on code style

src/python/WMCore/WorkQueue/WorkQueueReqMgrInterface.py got worse in pylint.  Status is success

tested in vm merging it


epic: EJSON: Backend adoption

Children: maintained on a best effort basis: [#1808, #1813, #1814, #1840, #1872]

#1807 should be part of this epic as well.


use Object.getPrototypeOf instead of .prototype

This will allow the use of bound functions, which have a prototype of undefined. Fixes https://github.com/tannerlinsley/react-table/issues/109.

🎉 Fantastic!  You rock.

Release please?

Just hit this problem in 5.3.4 and had to downgrade to 5.1.0

Have you tried 5.5.1?

Works :)


show defaultColorDecorators in documents decorated by extensions

If an extension decorates a document, none of document's defaultColorDecorators are shown.
A helpful enhancement would be to use the union of defaultColorDecorators and extension-provided decorators. Whereas currently the defaultColorDecorators are default at the document level, they would be default at the token level. So tokens with defaultColorDecorators decoration definitions and no decoration definitions from extensions would be decorated by the defaultColorDecorators.

A practical example: https://github.com/tailwindlabs/tailwindcss/discussions/11212

The idea is that contributed color providers have real language knowledge and know about the valid color formats and locations.
Maybe the tailwind extension is missing a color and should fix that?

The idea is that contributed color providers have real language knowledge and know about the valid color formats and locations.
Maybe the tailwind extension is missing a color and should fix that?

@bradlc possibly can answer this.

We may be misunderstanding each other. My request is that extensions be able to extend a given language's color decorators. Is it correct that currently if a user installs an extension which adds decorators to a given language, only the decorators contributed by the extension are used by VS Code for that language?

Thanks!
In those terms, my feature request is to have defaultColorDecorators' color ranges included in the combined color ranges even when an extension provides color ranges. It could be an additional option, or always when editor.defaultColorDecorators is true.
At a minimum, revising the label in the settings' GUI to include cover your "however" could help users know what to expect. (In my case, it would have helped me understand why toggling on the new option resulted in decorators appearing only momentarily.)

Related (or duplicated):
https://github.com/microsoft/vscode/issues/182214

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

The change will be released tomorrow in Insiders :) and soon in stable

@aiday-mar The PR got merged into main so I assume this goes into January and not November. Please ping if this is uncorrect and open a candidate issue if this is something for November.

Hi @dbaeumer yes that's correct


Admin Area Title Needs Fixed

FYI ... under new beta4 ... see attachment. The custom name over-runs the given area for title. THX!

How did you add the custom name?

I can reproduce it under Plugins>Admin Panel, Logo text.

Ok as there's no way to guarantee custom strings will fit, i've styled this so the first letter is displayed:

FWIW, this was an admin issue and should be opened in admin plugin in the future.

That should do the job then ... Thx!


Upstream pod security policies and docs missing mention of apparmour

Hi all,
The upstream pod security policies now available in kubernetes 1.10 only mention SELinux and not AppArmour: https://kubernetes.io/docs/concepts/policy/pod-security-policy/#selinux. It is the same within Rancher 2.X as well.
My suggestion is to contribute to PSP and add support for AppArmour, including adding to the upstream documentation for this.
Cheers,

Calvin

There is now an AppArmor section here: https://kubernetes.io/docs/concepts/policy/pod-security-policy/#apparmor


1.20.4 fixes

1.20.2 / 1.4.0 launches on 1.20.4 and some of it's features function.
other buttons cause a crash when pressed.
crash report:
https://pastebin.com/xz46GsLk

Hello,
v1.4.0 wasn't compatible with 1.20.4 (owo-lib wasn't updated yet at this point in time).
The new version v1.4.1 has been pushed with 1.20.4 support.
Enjoy!


Feature: triple-slash directive to override "target" compiler option

Search Terms
tsconfig override per-file compilerOptions code emit
Suggestion
Add a triple-slash directive to override the target compiler option within specific .ts code files.
Use Cases
With the final death of IE11 coming soon 🎈🎉🎊, my team and (I'm sure) many other teams are finally upgrading TS projects from "target": "ES5" to "ES6" or beyond.
What many of us will discover is that there can be subtle (or not-so-subtle) runtime differences between ES5 and newer syntactic equivalents--like true ES6 class declarations and the ES5 equivalent function+prototype object.
Our team has run into a problem where a library we still need to use calls class constructor functions using apply (not new) in its own implementation of inheritance/mixins - this throws a TypeError at runtime (and no, it would be impossible to fix it without a prohibitive, major breaking change to the library).
For reference, here's the relevant section of the ECMAScript standard: http://www.ecma-international.org/ecma-262/6.0/#sec-ecmascript-function-objects-call-thisargument-argumentslist, specifically 2. If F’s [[FunctionKind]] internal slot is "classConstructor", throw a TypeError exception..
Because of this and other runtime differences that exist between different target values, it would be extremely helpful to allow overriding this setting per-file, for those files where problems are encountered. Locating the override within source code makes sense, since codegen options that affect runtime have parallel concern with the source code itself.
Alternatives?
The only alternatives I'm aware of are:

Continue to use ES5, don't upgrade projects
Run a multi-step build with different tsconfig.json files, specifically excluding/including the files with issues (not sure if this is really possible in a large project)
Locate offending files in a separate project (may not be possible, or may require prohibitive refactoring/reworking)

TS Syntax
Using a triple-slash directive makes sense since this is a pattern that is already supported and used extensively. I suggest the following syntax:
/// <compilerOptions target="ES5"/>

This would also allow adding support for other compiler options in the future.
Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

Related: #31035

@MartinJohns This issue is specifically only for target - which is doable because it only affects code emit.

Apologies - I'm trying to work on this in a fork and accidentally closed this issue via a commit message.


SmallString improvements

The main changes in this PR are:

change internals of SmallString so it becomes an isbits type (and it no longer stores its length). This was needed to use Val{Tag("TagName")} in some experimental features.
it's now easier to construct SmallStrings/Tags, from Strings for example
getindex(TagSet,...) now returns Tag instead of IntSmallString

I made some other small code improvements & cleanup too, and added a few tests.

Codecov Report

Merging #102 into master will decrease coverage by 0.01%.
The diff coverage is 97.95%.

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   94.46%   94.45%   -0.02%
==========================================
  Files          27       27
  Lines        2529     2541      +12
==========================================
+ Hits         2389     2400      +11
- Misses        140      141       +1

Impacted Files
Coverage Δ

src/tagset.jl
97.01% <100%> (+0.02%)
:arrow_up:

src/smallstring.jl
97.72% <96.87%> (-2.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57e6472...9900c0d. Read the comment docs.

Looks good to me!


Better/check

This PR solves: https://github.com/progrium/dokku/issues/1070. The deploy will wait for the container to start accepting TCP requests, effectively creating a zero-downtime dokku. It's based on: https://github.com/aanand/docker-wait/blob/master/wait
The nc dependency is available on ubuntu and inside of the buildpacks (well atleast the node one):
I do not think this PR is complete, but I wanted some feedback on the direction / implementation. Some improvements include:

Testing (not sure how to test dokku atm)
A timeout (so we don't end up in an infinite loop)
Remove nc (is that possible?)
Move to the checks plugin

I do think checks and this are not mutually exclusive, I think you'd want both to make sure your application has been deployed correctly.

EDIT: doesn't work for deployed apps that do not listen on a port, like worker apps. Not sure if there's a way around this.

going to close in favor of: https://github.com/progrium/dokku/pull/1056


can I have a line break after the exploration question?

it would be good if the exploration question would be by definition with a line break (or as a hacky version, the first variable option?!)
The thing is that other drop-downs jump up and down, depending on the length of the question.
i know it is crazy one day before the workshop, but i just put it here, maybe you find time

tricky since the first option doesn’t have to be like this and a solution to this issue should be future proof. so, sorry no quick fix :/

already thought so. no trouble, we just leave it in here


Have a login page for the Svelte app

We should require this, then link it to the crscraper.py.

My hyperfixation managed to do it again.


COLR docs should be explicit about how to resolve offsets

In general the docs for OpenType tables are very consistent about explicitly stating what an offset is relative to, e.g. the GPOS header states in the description for each offset field in the header that the offset is relative to the beginning of the GPOS table.
COLR does not follow this convention and I think this is an oversight; although the user might reasonably (and correctly) assume that all offsets are relative to the start of the parent table, this pattern is not universally true for all offsets in all tables in the spec, and I think that it is worth being explicit in this case, particularly in the case when offsets occur inside records, and must be resolved against the start of the record's parent table (such as with the BaseGlyphPaintRecord in the BaseGlyphList table.

See https://learn.microsoft.com/en-us/typography/opentype/spec/colr#colr-formats:

All table offsets are from the start of the parent table in which the offset is given, unless otherwise indicated.

Does the point of reference need to be repeated in each table or record?

The suggestion is reasonable to avoid possible confusion. (Not re-stating a repeated concept each time could, in theory, be sufficient, but when that concept isn't obvious or implicitly understood by all readers, it can leave ambiguity for the reader.)
See the OT 1.9.1 alpha for draft revisions addressing this issue.

Thanks for the fix. The reason this was an issue for me in particular was that I use the descriptions of the tables as the input for a codegen tool, and it uses the docs to generate documentation for the fields, and it is nice in that case for each offset field to document exactly what the offset is relative to, just to avoid confusion. :)

This is fixed in OT 1.9.1. See the OT 1.9.1 beta for draft revisions addressing this issue. Closing.


refactor!: simplify load function

#67  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nikbrunner and the rest of your teammates on  Graphite


This would be a step back from 2.0 – and even 1.4 – which both have support for dropping blocks in the "broadcast" and "broadcast and wait" blocks; it would undoubtedly break some projects (in fact, I've used reporters in broadcasts myself).

@liam4 I didn't realize that was in 2.0.  Not an issue here then.


Strings with '%' symbols which aren't token placeholders don't format correctly

For instance the following:
"%s 0% fat Greek style yogurt"
when formatted with:
"60ml"
should ideally result in:
"60ml 0% fat Greek style yogurt"
Instead the outcome is nil
I've taken a look over the code and this could be fixed by tweaking line 587 in Sprinter.swift:
if first == "%" { break }
to become:
if first == "%" {
  if string.last == nil || string.last == " " {
    break
  }
}

I've tested this locally and all unit tests pass with the change (as well as this new case). I'm happy to create a PR? Let me know, cheers.

Yes, please do.
I need to check the spec for what the expected behavior is here. I would think you are supposed to write %% in this case and that a % on its own is a syntax error, but in a case like this it seems reasonable to allow it.

The problem with that approach is that it would break formatting for tokens inlined, for example:
Hello_%s_world
The approach I took to work around the problem initially was to swap out the '%' I wanted ignoring for a 'widepercent'. An alternative as you say could also be to double it up - '%%'. Would be nice to be able to defend against it in the formatting though :/

According to the standard

Each conversion specification is introduced by the  character ( '%' ). After the character '%', the following shall appear in sequence:
...
%: Write a '%' character; no argument is converted.

So, using %% here is expected.


Swiftify Protocol Names

As discussed in #300 theses are some changes to the protocol names to match the naming convention is the swift standard library.
Changes:

Breaking Change rename MoyaTarget protocol to TargetType
Breaking Change rename MoyaRequest protocol to RequestType
Breaking Change rename Plugin protocol to PluginType

Current coverage is 84.84%

Merging #321 into master will not affect coverage as of 1ceaa0f

@@            master    #321   diff @@
======================================
  Files           13      13
  Stmts          640     640
  Branches         0       0
  Methods
======================================
  Hit            543     543
  Partial          0       0
  Missed          97      97

Review entire Coverage Diff as of 1ceaa0f

Uncovered Suggestions

+2.50% via Source/Result.swift#53...68
+1.72% via Source/Result.swift#38...48
+1.25% via ...ource/Response.swift#75...82
See 7 more...

Powered by Codecov. Updated on successful CI builds.

Looks fab – could someone else take a look + merge?

Superb work, as usual :stars: It's been a few days for anyone to object, I'm going to merge.


Trailing ]

Is there any reason behind the trailing ] symbol in logs format? Like at this line:
https://github.com/DogeDark/dioxus-logger/blob/0fb693114d02bd57adc2d81feb584613d07e1854/src/lib.rs#L25
It's not critical, but strange when the message have trailing symbol.

They are not required. You can create any format you want with the different {VARIABLE} and everything else is decoration so to say.


Adds support for custom env file names

Fixes #7579

Reads env file from exported variable ZSH_DOTENV_FILE.
If file, nothing is exported to the variable it takes .env as default file name

Oh, I meant to modify the plugin README. Now that I see it, you can just add the info to the Usage section.

Oh, I meant to modify the plugin README. Now that I see it, you can just add the info to the Usage section. Good job on the rest though!

Thanks for all the help, couldn't have done it without your help. I still need to understand more about the repo, I will be picking up some more issues to understand the project better.

Ok I changed the wording a bit and added an example. Thanks for your contribution and I hope you stick around for more!


fix: Update FileParser.ts to parse xlsx files properly

Description
In filepicker widget if we upload xlsx file, the data output is an array of array instead of array of objects. The change we make is to simply remove the header prop from XLSX.utils.sheet_to_json API
PR fixes following issue(s)
Fixes #27888
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[ ] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan
nil
Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/build-deploy-preview env=release skip-tests=true

/ok-to-test

/build-deploy-preview skipTests=true

/build-deploy-preview skipTests=true

/ok-to-test


Allow filtering on full names in mention HUD

r? @keybase/react-hackers

Found a bug where users without fullNames weren't passed through to the hud. To generate the user list, we need to combine data from fullNames and participants. I used reselect to do the processing to keep it out of mapStateToProps. PTAL


No mTLS to pods in terminating state after Istio upgrade to 1.18 (headless service)

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
We recently upgraded Istio from 1.16.1 to 1.18.0. After the upgrade we noticed that some workloads that are using headless services are starting to fail when pods have long terminating times.
Setup:

We have a deployment with haproxy (+ istio proxy) that manages the sticky sessions which connects to another deployment running the application itself (+istio proxy).
The application deployment has a long termination period and while in terminating state we need to access the pods for a specific amount of time.
On the application side we have defined a PeerAuthentication object with mTLS set to STRICT and we have Authorization policies defined using principles

Before 1.18, everything was working as expected. However, after the upgrade to 1.18 we noticed that when haproxy tries to reach one of the pods that has entered the terminating state, it starts doing the request using http (it does not provide the spiffe header) and not mTLS. Which means all requests are failing.
We have pinpointed the issue to version 1.18.0, meaning 1.17.8 and below are working fine. We also upgraded 1.19.3 and the issue persists.
Version
❯ istioctl version
client version: 1.19.1
control plane version: 1.18.3
data plane version: 1.18.3 (459 proxies)

❯ kubectl version --short
Client Version: v1.25.5
Kustomize Version: v4.5.7
Server Version: v1.24.14-gke.2700

Additional Information
No response

I think this was probably related to a change I made to derive service account info from endpoints. Likely we need to consider unhealthy in that case -- or hopefully its that simple, at least.

Unfortunately I think the logic is probably going to be wonky if we don't have features.SendUnhealthyEndpoints set. Maybe we need to split that flag so the endpoints are available here and just filtered.
Although for headless this may be different, probably need to look a bit deeper

If you need more clarification of the setup, via a diagram, let me know.

I can reproduce


Add way to query back reserved nodes through JSON-RPC layer

Apparently some users want to be able to query back the reserved nodes that they passed through --reserved-nodes and added/removed through addReservedPeer and removeReservedPeer.

Indeed! Recently we are building a Substrate validator DevOps framework. We use addReservedPeer and removeReservedPeer to connect pair our nodes in the private network in a cluster, but there's no way to query the current reserved node list. It would be very useful.
Also chatted with @wpank about this idea. Quoted here:

There's the system_networkState call, which dumps a lot of networking info about the state of the network from the nodes point of view, and then the system_peers rpc call, which shows the current peers the node is connected to. I imagine the reserved status can probably be added to the system_peers rpc call as a bool - something like reservedPeer: true or something like that. If this is a feature that would be really useful, best to add an issue to substrate

system_reservedPeers :rocket:


Code the famous Fibonacci Series in as many programming languages as you can...

Don't forget yo read the Readme.md & Contributing.md  before making contributions. Please follow all the steps provided in the Contributing.md . Otherwise your contributions may get void.
Happy Coding!!
Happy Contributing to the Open Source!!

Added TypeScript implementation.
Please note the 'hacktoberfest' label is required as of October 3, not 'hacktoberfest2020'.
This was addressed here

Hey Thanks for reminding me that. But I've already add the hactoberfest label in addition to hactoberfest2020. Please find it and report to me if any changes required.
Thank you
Happy Coding!!

Hey Thanks for reminding me that. But I've already add the hactoberfest label in addition to hactoberfest2020. Please find it and report to me if any changes required.
Thank you
Happy Coding!!

I think its "hacktoberfest" instead of "hactoberfest"

It's a typo mistake. Check under the about section for the label

It's a typo mistake. Check under the about section for the label

I did, it says "hactoberfest" there for me but it could be that its not updated yet :)

It's changed now. Thanks for reminding though @CozyDoomer

Can we take this for Hactoberfest2021?
Since I am new to this opensource contribution not so familiar with things

@mohanhbk Yes you can work for hactoberfest 2021

Can we take this for Hactoberfest2021? Since I am new to this opensource contribution not so familiar with things

yes

I have make a PR for adding Basic1.1 implementation for the hacktoberfest 2022.
Thanks

I have made a PR( #104 ) for this in Swift for Haktoberfest 2022.
please review it.
thank you.

For the "hacktoberfest" 2022 the repo must be tagged with the "hacktoberfest" topic or have the "hacktoberfest-accepted" label -> https://hacktoberfest.com/participation/
@fharookshaik Please could you review if the labels of the repo are right.
Thanks!

Is this still active? I have a couple of languages

is this still active? I would like to add some more programming languages.

Hello @MariaVrett, The repository is active. I will review the active PR's and merge them accordingly.

Hello @fharookshaik, I just made a pull request if you can review it and merge it i would like to add more languages.


A new way to do URL migration ("ventilation")

From issue: "ventilation" project phase
High level changes:
Abandon the approach in the ventilation.py script. Instead, ventilate by restoring several XML files in the WXR format (WordPress External RSS) which, contrary to Internet lore, does permit restoring images and other assets as well.
The new ventilation workflow looks like this:

Dump the origin sites using wp export
Process each of the resulting XML files with something likepython3 ./src/wxr-tools/wxr-ventilate.py
--new-site-url-base https://migration-wp.epfl.ch/vpsi/
--add-structure it-services/support/cri wxr/cri.xml > wxr-ventilated/cri.xml💡 At this time, you do this once per origin site. In a future PR, a --filter flag will be introduced and wxr-ventilate.py will be re-run for the same origin site, as many times as there are destination sites to send pages to.
Restore all the processed ("ventilated") XML files using a custom PHP importer packaged as an eval-file:wp  --skip-plugins=wordpress-importer --path=/srv/test/jahia2wp-httpd/htdocs/vpsi-next/
eval-file /srv/test/jahia2wp/src/importer.php -fetch-attachments /srv/test/cri.xmlThanks to importer.php, the multiple XML files for each destination sites (produced out of multiple origin files) merge nicely and produce the desired URL map.

Low level changes:

Write the wxr-ventilate.py tool as an XML-to-XML transform
Write the importer as an eval-file-able PHP script, complete with structural page merging and HTML to text translation of the standard output.
Toss out ventilation.py and its dependencies

Targetted version: x.x.x

Demo is available at https://migration-wp.epfl.ch/vpsi/wp-admin/admin.php?page=nestedpages where ventilation is in progress as we speak (started 11:24PM CEST)


RUMM-1081 (2/2) Migrate maven publishing script

What does this PR do?
Update the CI publishing scripts to target Sonatype OSSRH

Codecov Report

Merging #547 (a62e6c2) into master (2a17ade) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #547   +/-   ##
=========================================
  Coverage     88.64%   88.64%
+ Complexity     1566     1563    -3
=========================================
  Files           170      170
  Lines          5211     5211
  Branches        628      628
=========================================
  Hits           4619     4619
+ Misses          357      356    -1
- Partials        235      236    +1

Impacted Files
Coverage Δ
Complexity Δ

...droid/rum/tracking/FragmentViewTrackingStrategy.kt
81.82% <0.00%> (-4.55%)
13.00% <0.00%> (-1.00%)

.../android/tracing/internal/domain/SpanSerializer.kt
87.95% <0.00%> (-1.20%)
22.00% <0.00%> (-1.00%)

...oid/src/main/kotlin/com/datadog/android/Datadog.kt
87.21% <0.00%> (-1.16%)
32.00% <0.00%> (-1.00%)

...l/net/info/BroadcastReceiverNetworkInfoProvider.kt
77.32% <0.00%> (-1.03%)
27.00% <0.00%> (-1.00%)

...g/android/rum/internal/domain/scope/RumEventExt.kt
81.82% <0.00%> (-0.91%)
0.00% <0.00%> (ø%)

...c/main/kotlin/com/datadog/android/DatadogConfig.kt
93.43% <0.00%> (-0.51%)
10.00% <0.00%> (-1.00%)

...ore/internal/constraints/DatadogDataConstraints.kt
93.59% <0.00%> (+1.28%)
26.00% <0.00%> (+1.00%)

...tadog/android/log/internal/domain/LogSerializer.kt
89.19% <0.00%> (+1.35%)
26.00% <0.00%> (ø%)

...droid/rum/tracking/ActivityViewTrackingStrategy.kt
88.68% <0.00%> (+1.89%)
19.00% <0.00%> (+1.00%)

.../kotlin/com/datadog/android/rum/RumResourceKind.kt
85.71% <0.00%> (+4.76%)
2.00% <0.00%> (ø%)

... and 1 more


Fix function decorator in different file

We already get the correct module for the function / cls, so we should use it for getting the file as well.
This is needed because if a decorator is defined in a separate file, functools.wraps will update __module__ correctly, but it can't patch the __code__ object, which is what inspect.getfile() uses for figuring out the file for the function.

[ ] Test

A bit annoying to add tests for this, since none of our tests cover the "run as file" branch in FunctionInfo. Will make a separate PR with tests for that file.


Extensability of Item Template

Hi everybody,
I was currently trying to extend the "Item Template" for some fields.
I noticed the following things:

In my opinion it would make sense, to make a function like "AddToArray" of Table 1301 accessable. So you don't have to "rebuild" it in your own extension.

Also, it would be good, to make "Rec" of Table 1301 accessable in the Event "OnAfterCreateFieldRefArray". So you don't have to work with the fieldnumbers of your new fields.

It's also not possible to skip the validation of field, when an item template is getting applied.
I think something like this would be helpfull:

Best regards,
Hendrik

Hello Hendrik,
Thank you for your suggestion, but we can only provide the OnBeforeUpdateWithSkipFields event .
The AddToArray function can only be used for the 17 first fields. The event allow you to add 6 extra Fields. The code you are showing replaces the 5 first fields.
Working with the field numbers cannot be avoided as the only way to get to FieldRef is by a RecordRef and the Field number you can define your own Record variable and use it to get the field numbers. I would suggest the following.
var     ItemTemplate: Record "Item Template"; begin    FieldRedArray[18] := RecRef.Field(ItemTemplate.FieldNo("Custom Field 1");    FieldRedArray[19] := RecRef.Field(ItemTemplate.FieldNo("Custom Field 2");    FieldRedArray[20] := RecRef.Field(ItemTemplate.FieldNo("Custom Field 3");    FieldRedArray[21] := RecRef.Field(ItemTemplate.FieldNo("Custom Field 4");    FieldRedArray[22] := RecRef.Field(ItemTemplate.FieldNo("Custom Field 5"); end;

Hey @GiorgosPa,
What would happen if two extensions uses the same FieldRedArray index?

That would be unfortunate, one will override the other

Closing as won't fix.
We plan to stop using "mini templates" and switch to Config. Templates. They are used as basis for “mini” and they are fully extensible without any additional actions.
We are investigating how to address the usability issue with Config Templates.

Any timeline?


fix: changes 00:00pm to 12:00pm in view popup (close #296)

Please check if the PR fulfills these requirements

[x] It's submitted to right branch according to our branching model
[x] It's right issue type on title
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[x] It does not introduce a breaking change or has description for the breaking change

Description

Changes 00:00pm to 12:00pm in detail popup
AS-IS

TO-BE

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

wait review @jodeng110


#111 FIX: VerboseIterable and VerboseIterator are not tested

@yegor256  This pull request fixes  bug https://github.com/yegor256/takes/issues/111  that identified the missing unit tests in VerboseIterable and VerboseIterator, for fixing this, the VerboseIterableTest and VerboseIteratorTest classes were created.

@yegor256 this is my first pull request, I see the CI kicking in, but there is apparently a non deterministic test on
FtBasicTest.gracefullyHandlesStuckBack
I can't reproduce it locally, but since I din't change code, just added unit test is not normal that my build has errors
:144 HTTP response body content is not valid:
200 OK [http://localhost:1050/]
Content-Type: text/plain
first: , second:
Expected: a string containing "second: dd"
but: was "first: , second: "

@m4solutions Thanks for your pull request, let me find someone who can review it

@pinaf it's yours, please review

@m4solutions 20 comments and 1 question above.

@pinaf already did the corrections please check it out

@m4solutions 17 more comments - sorry. Make sure you understand the indentation article and the compound name article I linked.

@pinaf  No need to be sorry, I'm new and sometimes even the obvious is obviously new for me, this time I check all the indentation for the clases manually, rename the variable, and let only the totally necessary ones, please take a look again.

@m4solutions indentation not good yet - 11 comments above.

@pinaf
this time used IntelliJ, and checked all the indentation guides match
![Image of intelliJ Identation]
(http://s10.postimg.org/43z74tgll/Screen_Shot_2015_05_01_at_2_14_09_PM.png)
But I still have the doubt of my previous comment, about  ).iterator().next(); breaking or not the rules.
Even though I'm having lots of comment I think I needed this exercise, but i felt like I missed some initiation developer or something.
Just my thoughts:

Recommended IDE: IntelliJ
Code formatting and indentation settings: http://img.teamed.io/settings.jar

@m4solutions almost there. 7 more. Also, please check th travis build log which failed. It says there are 26 checkstyle violations.

@m4solutions sorry - try this link https://github.com/yegor256/takes/pull/218/files#r29545443

@pinaf

Just made the appveyor CI build to run.
Travis failed only 1/3 and there is an error about a class it is not finding, is this a know issue?

btw.
I do appreciate you take time to educate me in the coding style of the project.
But, I think it would had been really easier to point out:

That the CI build had this style checks included.
That all those check could be studied further in: http://www.qulice.com/quality.html
Eclipse is unable to be configured with the recommended indentation style for the way it handles this. (by type of construct not globally)
That it could be a good Idea to use IntelliJ

The previous suggestions, and probable a lot more, should be documented, reading the blog is fine, but we could take advantage of an structured guide.
I think I missed some introduction talk, anyway, please check the updated files, I think this time I won't be that embarrassed.

@rultor merge

@rultor merge

@pinaf Thanks for your request. @yegor256 Please confirm this.

@m4solutions It's alright - don't worry about it. Also agree with your comments. On the Travis build, I don't know if it is a known bug or not. Check the open issues.

@m4solutions a few comments from me above

@yegor256 I just took care of your comments, please check them out

@m4solutions a few more comments above

@yegor256 remove unused code

@m4solutions more comments

@yegor256  right again, after removing the unused code, I didn't refactor the whole thing. is corrected now.

@m4solutions why did you close it? accidentally?

@yegor256 oh yes, clicked the wrong button.

@rultor try to merge

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor try to merge

@yegor256 Oops, I failed. You can see the full log here (spent 8min)
Running org.takes.facets.auth.social.PsTwitterTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec - in org.takes.facets.auth.social.PsTwitterTest

Results :

Tests in error:
  RqMultipartTest.consumesHttpRequest:303 » IO Failed POST request to http://loc...

Tests run: 168, Failures: 0, Errors: 1, Skipped: 4

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 53.675 s
[INFO] Finished at: 2015-05-04T04:41:57+00:00
[INFO] Final Memory: 27M/388M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project takes: There are test failures.
[ERROR]
[ERROR] Please refer to /home/r/repo/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project takes: There are test failures.

Please refer to /home/r/repo/target/surefire-reports for the individual test results.
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/r/repo/target/surefire-reports for the individual test results.
	at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:82)
	at org.apache.maven.plugin.surefire.SurefirePlugin.handleSummary(SurefirePlugin.java:195)
	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:861)
	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:729)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
	... 19 more
[ERROR]
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

@pinaf Should I close this pull request now that the problem in master has been skipped?

@rultor merge
@marcuss we should try to merge again

@rultor merge
@marcuss we should try to merge again

@pinaf Thanks for your request. @yegor256 Please confirm this.

@marcuss @yegor256 both of you have unaddressed comments. please go through your comments and make sure all of them address somebody.

@pinaf I just corrected my unaddressed comments.

@marcuss see above

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 9min)

@marcuss thanks. also make sure that the first post explains what issue this is for and what your solution was.

@elenavolokhova review this ticket please, for compliance with our quality rules

@pinaf Thank you for your job on quality of this endless review :) But one issue is still not fixed: @yegor256 comments still don't have addressee. Please, try to be more persistent next time.

@rultor deploy

@rultor deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor deploy

@davvd Done! FYI, the full log is here (took me 10min)

@elenavolokhova yes, I got it, will be more attentive in the future, thanks!

@davvd Quality is acceptable here.

@davvd Quality is acceptable here.

@elenavolokhova thanks for the review, we'll try better next time

@pinaf just added 10 mins to @elenavolokhova (for QA), payment ID is 57161463... Much obliged! I have added 26 mins to your account in payment "AP-5SD91831XV3762709", 201 hours and 34 mins spent... extra minutes for review comments (c=11)... added +26 to your rating, now it is equal to +7835

@marcuss all 2 puzzles are solved here: #780, #806.


Custom theme values: Certain color conventions do not work

VSCode Version: Insiders
OS Version: macOS 10.11.5

Regarding test item #11126

Try entering a shorthand hex color value in any field.  An example would be #fff for white or #000 for black—instead of #ffffff or #000000 respectively.
Now try entering named colors, like black or white

Neither of these situations work.  Perhaps number 2 is by design (but I think we at a minimum should support number 1).

Currently we only support taking colors in hex with 6 digits. But we can enhance it to take requested forms

I believe that we now support shortforms, but not color names
Closing this as out-of-scope since there has been no further feedback since 2016


the worker of tracker extremely slow llike a minute for running a few tx all of a sudden

Dear team,
As i mentioned in the topics, I don't know why started from this few days, the worker of cat tracker will extremely slow to track the blocks from fractal, like a 1-2 mins for few transaction. However, I am pretty sure that there are no performance, resources issue. And the instances of the docker are also normal.
I don't know how to trouble shoot, there are no error in docker's log.
Would you suggest me or give me some guide for trouble shoot the problem, it's very annoying. After restart, a few mins or at most few hours, it happen again.

bro , me too. how to solve this problem

i duno, seems nth guide for the debug, and the logic, all i can is guess how to do, i am tryin to merge all the utxos
i am now cannot mint
if the case is much more worse, then just import your wallet to unisat and then remove this one in the node and then create a new one, it should be alright then


communicate fees more clearly

There is a thread about alternative donation channels on Inkscape mailing list.
https://sourceforge.net/p/inkscape/mailman/inkscape-devel/thread/F49DED4EE47949B2B4BD2B2A03BF6203%40JillsLaptop/#msg33697857
I am personally looking forward to use SVG + D3.js in Gratipay visualizations, so it looks logical to see if Gratipay can play a good role in Inkscape fundraising and adopt itself according to demand. What I see immediately is the necessity to have a less verbose information about fees. Current entrypoint at https://gratipay.com/about/faq is not concise enough.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Is the recently added paragraph on the about landing page sufficiently concise?
https://gratipay.com/about/

Gratipay does not take a cut of payments, recipients get the full face value. Instead of taking a cut, Gratipay is funded by the voluntary payments of our users to our own Gratipay account. See our pricing page for more information.

@colindean no, this is obscure. The people are interested to know exact fees for their case..

I know one of the developers. @liamwhite are you up on the funding Inkscape conversation?
@techtonik Why don't you join the mailing list and suggest Gratipay? :-)

@whit537 actually, I did send the letter, but..
You are not allowed to post to this mailing list, and your message has
been automatically rejected.  If you think that your messages are
being rejected in error, contact the mailing list owner at
<EMAIL_ADDRESS>

---------- Forwarded message ----------
From: anatoly techtonik<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Cc:
Date: Tue, 7 Apr 2015 15:25:56 +0300
Subject: Donating through Gratipay

I really prefer forums more. =)

Done. http://sourceforge.net/p/inkscape/mailman/message/33764265/

!m @techtonik

Looks like we should raise the importance of the issue. =) This is the feedback from Inkscape:
If there is one which doesn't take a
fee, I would say that would be ideal!  (Because when these apparently noble
groups who just want to support "the starving artist" or "the starving
programmer" take a fee, they start to look less noble, in my eyes.)(my
opinion)

While Flattr takes 10%, and Patreon takes 5% plus credit card fees, it
appears Gratipay is less "transparent".  The Gratipay terms say
"
Fees
Gratipay reserves the right to charge service fees based on the total amount
of your transaction. Such fees are subject to change without notice and in
Gratipay's sole discretion.

>From my point of view, that makes it difficult for a potential recipient of
these donations, to decide whether to use the service.  But again, my
opinion  :-)

This matches my perception of Gratipay from outside. The problem with current representation is that it is based on belief and trusts - and that's is a problem. We as developers do believe each other and trust each other, so we don't sense the issue, but for people from outside it is just not convincing.
We should be visually explicit about who takes what. If it is Paypal, let it be clear that PayPal takes 5%. If it is Bitcoin, let's show how it enters and leaves the system.

Sounds like a bug in our terms.

+1

From my communication on Inkscape-devel:
"As far as I can tell there is no fee for Gratipay service - it is fuelled by
direct donations - https://gratipay.com/about/pricing - the fees above
are set by payment providers. Well, except Bitcoin, but this needs
further clarifications. Last time I've heard about that, the Coinbase was
used."

Well, that seems in direction contradiction to what is stated in Terms of Service, #9.
https://gratipay.com/about/policies/terms-of-service

If the fees explained there are not for contributions or donations, or only for credit card transactions, it should be clarified.

@whit537 I believe only you can act on https://gratipay.com/about/policies/terms-of-service
The point #9 looks shady:
Fees

Gratipay reserves the right to charge service fees based on the total amount of your transaction. Such fees are subject to change without notice and in Gratipay's sole discretion.

At https://gratipay.com/about/pricing, I think the lead section should be "We don't take a cut, but we ask that you donate" and then get into suggested pricing.
Also, this page suggests that because I transfer $0.21 per week with Gratipay, I should pay an extra $0.25 for the service.  10% would be $0.02, so I assume the $0.25 is a hardcoded minimum?

@mattbk Yes, 25¢ is a hard-coded minimum.

Does the credit card processor not divulge fees to us?  Or is it on a per-card basis that fees are calculated?

NM, right here: https://gratipay.com/about/features/payments#fees

Seems the only remaining action item is https://github.com/gratipay/gratipay.com/issues/3326. Please reopen if otherwise.


Confusing about the time in MonteCarloGFormula

Hi，I am confusing about how to use the time and history data. It seems  that we should make a model with data of questionnaires k-1 and k-2, but I couldn't find such code implementation. I found you used data of time k only while fitting you model.
#176  exposure_model
#207  outcome_model
#274  add_covariate_model

Hi @Jnnocent MonteCarloGFormula fits the same model for all time points (t = {1, 2, 3, ... k}). To account for variable history, you can use lagged variables. In this notebook, I used include the time-varying variables at t=k-1 and t=k in the outcome model ('art + lag_art + ...'). The variables from the previous time point are lag_... and take the value from the previous time. As you will see in the fit() statement, there is a line to specify what variables are lagged in the Monte-Carlo procedure. While MonteCarloGFormula does not use distinct models for k-1 and k-2, it allows you to put history of variables into the regression model at time k. While I only put time-varying variables from the previous time point (k-1) in the example, there is theoretically no limit to the history you can include in the model, only practical constraints. For example, I could have created lag_lag_art, which would be art at t=k-2. I would need to add 'lag_art': 'lag_lag_art' to the dictionary in fit() if I wanted to implement this (also include lag_lag_art in the corresponding regression models).
MonteCarloGFormula follows the process described by Keil et al 2014. I replicated the analysis described in the paper, so you can follow along the paper's description with this notebook
Can you tell me a little more about your data set and study question? It may help me answer your question more clearly. Depending on the data, there may be a better estimator to use. In my experience, I have found MonteCarloGFormula to work best when you are interested in a time-varying treatment/exposure for survival data

Thank you! I know more about this article and the code.  And I study the MonteCarloGFormula  by the following paper [https://www.ncbi.nlm.nih.gov/pubmed/19389875].  On page 1601， it describes the algorithm that it builds the model for each 2-year , which is different form that fitting the same model for all time points (t = {1, 2, 3, ... k})

On page 5 in Keil et al 2014, it is said that

the models for each covariate on day k were fit using only person-days for which the patient had not yet experienced each time-varying covariate on day k − 1

So, I feel confused about how to build the model that fitting the same model for all time points (t = {1, 2, 3, ... k}) or fitting the differsent models for each time points (t = {1, 2, 3, ... k}).

Thank you! I know more about this article and the code. And I study the MonteCarloGFormula by the following paper Intervening on risk factors for coronary heart disease: an application of the parametric g-formula . On page 1601， it describes the algorithm that it builds the model for each 2-year , which is different form that fitting the same model for all time points (t = {1, 2, 3, ... k})

On page 5 in Keil et al 2014, it is said that

the models for each covariate on day k were fit using only person-days for which the patient had not yet experienced each time-varying covariate on day k − 1

So, I feel confused about how to build the model that fitting the same model for all time points (t = {1, 2, 3, ... k}) or fitting the differsent models for each time points (t = {1, 2, 3, ... k}).

The Taubman paper and Keil paper both use what is referred to as pooled logistic regression. This is the same approach that MonteCarloGFormula uses. This open-access paper has a further description of what pooled logistic regression is
The pooled logistic regression process works by fitting a single model to the full data with a term for time (t_in). The pooled regression models are not estimated separately for each time period. In Table 2, Taubman et al. mention including time as a dummy variable in their pooled logistic models. The pooled models are fit once to the full data and include all the variables are interested in plus time. The Taubman data would look something like the following
id t0 t1 Y  A L
 1  0  2 0  0 2
 1  2  4 0  1 3
 1  4  6 0  1 7
 1  6  8 1  1 1
 2  0  2 0  1 4
...

where A is the treatment, Y is the outcome, and L is a time-varying confounder. Following the Taubman paper, we would generate some lagged variables. For A, we might use something like
df['lag_A'] = df['A'].shift(1)
df['lag_A'] = np.where(df.groupby('id').cumcount() == 0, 0, df['lag_A'])
df['lag_lag_A'] = df['lag_A'].shift(1)
df['lag_lag_A'] = np.where(df.groupby('id').cumcount() == 0, 0, df['lag_lag_A'])

Our outcome model could look something like the following, 'A + lag_A + lag_lag_A + L + lag_L + lag_lag_L + C(t0)' This would model a dummy variable for time, like described by Taubman. You can also add interaction terms between C(t).
The pooled logistic models are different for each variable. Following Taubman, the exposure_model(), outcome_model(), and add_covariate_model() are all done in step 1. Step 2 is all done by the fit() process
However, MonteCarloGFormula does not currently allow multiple treatments, like described in Taubman. I may try to add that functionality in the future. Currently, only a single treatment can be assessed

I know a little about the pooled logistic regression model, and I would like to read the paper to learn it morn.
May I ask you another question?  When can we use the censoring model? I simulate a population with censoring data and build a censoring model. Should we make a restriction that restriction="g['censor']==0" in the exposure_model or the outcome model or the covariate_model? For  estimating the covariate need C_k =0 and so on.

The censor_model() only needs to be used if you believe there is informative censoring (generally there is informative censoring). This process builds a pooled regression model for censoring based on the specified model given to the argument. In the background, it predicts censoring during the Monte-Carlo procedure, right before estimating the outcome model.
As Taubman has it written, I believe there would be no restriction= arguments for censoring in any of the models. Their probabilities are conditional on not being censored at t=k for estimating the outcome at t=k+1. In how the data is set up for pooled logistic regression, if individual 1 was censored at t=3, they would not have a row in the data corresponding to t=4. I will read through the paper a little more carefully and make sure this is true

I get it! Thanks for you answering in details! ^_^

No problem @Jnnocent ! Got a chance to read through Taubman 2009 again. Below are some general thoughts / comments I had, mostly discussion of what is and isn't possible using MonteCarloGFormula as of v0.7.0

They talk about competing risks (Step 1c) but this is currently not available. I plan on adding in a future update #77 but haven't settled on how to implement it. There are essentially two options, a) a pooled multinomial model, or b) a series of pooled logistic models. Taubman et al. use the second option. Currently, MonteCarloGFormula only estimates a singular outcome (i.e. no competing risks in the sample).

As far as I can tell, Taubman et al. use the same fitting regression model process at MonteCarloGFormula. They describe 4 different types of models; binary, history-binary, full-continuous, and zero-continuous. Binary is done for exposure_model, outcome_model and add_covariate_model(..., var_type='binary'). History-binary can be done by adding the optional restriction argument. Continuous can be done by add_covariate_model(..., var_type='continuous'). Currently, there is no option that would cover how they fit their zero-continuous model. What I could do is add Poisson models for count data. Those models would cover count data (like cigarettes per day) better

Some of their treatment variables (like cigarettes per day) are continuous. Currently, MonteCarloGFormula does not support continuous treatments. I haven't figured out a clear API for how to specify continuous treatments. I am having the same problem with other g-formula implementations #49 The problem is that treatments can either shift everyone in the population (- 10 cigarettes per day) or it can set everyone to be below a threshold (everyone < 10 cigarettes per day).

To account for variables from two time-points prior, as described in the paper, I would use a model like 'A + lag_A + lag_lag_A + L + lag_L + lag_lag_L + C(t0)' and the process I described above.

They mention in their simulations section in the methods that they restricted predicted values to be within the observed range. You can do this by using the recode optional argument. I use a similar process in my example. For predicted CD4 T-cell counts, I require they be at least 1

Hope this helps

Very clear! Had a deeper understanding, specially the significance of restriction argument!
Following the MonteCarloGFormula, I test my data.  There are 11 years follow-up data that follow up each 2-3 years. And then I expended the data to create the person-month data. After specifying the model in step1, I fitted the model and generated a plot of the risk curves. As shown below

In your mention

From this we can see that out natural course predictions (green) follow the observed data pretty well (black). Note: this does not mean that our models are correctly specified. Rather it only means they may not be incorrectly specified. Sadly, there is no way to know that all our models are correctly specified… We may take some comfort that our curves largely overlap, but do not take this for granted

As you have seen, the natural course predictions doesn't follow well the observed data. So, how to decide whether the model is believable or not?
And the total incident rate of these two population were very close(original population: 0.07438, simulative population: 0.08934)

Based on your risk function for the true data, it doesn't look like that many events occur. Is this correct? It looks like there is only 6 or so events. With so few events, it will be hard to estimate the Monte Carlo g-formula.
I wouldn't trust the results from the g-formula. You can try to use year data instead to see if that helps.

And the total incident rate of these two population were very close(original population: 0.07438, simulative population: 0.08934)

Can you explain this a litter further? Based on the graph it looks like original: 0.2 and simulation: 0.45

The cohort included 4208 people and 371 had an event, 3837 were censored when they didn't have an event during the follow-up.  There were about 10000 person-time data,  and it became 600000 after being expended. Only 371 had an event.
Test again by using year data

It was more normal than the plot that using month data.
It seemed that it was the way of expending data that made such wrong result. For the event were determined to occur in the last month on the follow-up year.

Ahh yeah, so MonteCarloGFormula can only be divided into the minimal data collection period (you can divide further but it can be unstable, like in your data).
Something you may want to consider is using IterativeCondGFormula instead. This implementation works well for longitudinal data. Since your event times correspond to the end of the year, this may be a good option. Additionally, it only requires the specification of the outcome model (you don't need a treatment / time-varying confounder models). This paper describes what the iterative conditional g-formula is. I don't have a guide available for this yet, but it is on my to-do list

Thank you! I would like to read the paper first!  It seems simpler

Hi, I read the paper of  iterative conditional g-formula and have some questions

It mentions in the Estimation: longitudinal TMLE  section that

For discrete-valued confounders, this can be written as follows

So, in my opinions, only when the confounders are discrete, the model can be used. When when confounders are continuous, we prefer to use MonteCarloGFormula which has an advantage on the conditional probabilities calculating of continuous covariates.

Can I use another Machine learning algorithm to replace the GLM ?  In the paper, the author introduce the Super Learner algorithm. And I test the sample data in XGBoost model.  like following

if self.model_type == 0:
fm = smf.glm(d + ' ~ ' + m, df, family=linkdist).fit()  # GLM
else:
xgb = xgboost_model(self, df, d, m)

where self.model_type is a way to indicate which model will be used.
Compared with the GLM model, the prior_predict will be defined of 0 or 1 by

df[prior_predict] = np.where(df[d].isna(), np.nan, xgb.predict(tf))

While in the GLM model, It predict the probabilities

df[prior_predict] = np.where(df[d].isna(), np.nan, fm.predict(tf))

When when confounders are continuous, we prefer to use MonteCarloGFormula which has an advantage on the conditional probabilities calculating of continuous covariates.

The iterative conditional g-formula allows for continuous confounders. I believe they say the covariates are discrete due to how they write it. The last cumulative product is written as Pr(...). For continuous covariates, that term would become f(...). In their application, they have several continuous variables they adjust for (weight, height, risk score)

Can I use another Machine learning algorithm?

Not currently. The issue is that confidence intervals with any machine learning algorithm will be incorrect. More specifically, the confidence intervals will be overly narrow. LTMLE, which the paper focuses on, does allow for usage of machine learning algorithms. However, I have not implemented this yet. It is in the works
For the interative conditional g-formula, the model needs to output the probabilities, not 0 / 1, for it to estimate correctly. Due to the predict() function in sklearn, it won't return the necessary values. For it to work correct, I would need to add a custom model argument, which would use predict_proba() instead for this approach. However, because you can't get valid confidence intervals for IterativeCondGFormula with machine learning algorithms, I don't plan on adding this option.


Money transfer can be made from A to A

Code:
coda client send-payment \

-amount 1
-receiver B62qkSLRRLB4smdHYDvkxmBXnuRVdThr9a8ZihU7RYrEg5T8VMwHxyB
-fee 0.1
-sender B62qkSLRRLB4smdHYDvkxmBXnuRVdThr9a8ZihU7RYrEg5T8VMwHxyB
Dispatched payment with ID G8k9HJXpug4J4thR9me9Ft7CfDw9YRoEczbj8C81gfLWornLsEttZs64nj5eY8qzHPDGmuut2StkXFE4TJXZSjVraaNjtJqYfhoWuQ7nBpjfcCV2qZ3VV5MNFCe5Qk57CCmdzEzhQQY8tzQgWLpQUJnsWcZxPTJB1LjtiSd8aFPsEVeuurknVBxmFPGcCeFyAkbRdoUdMCUDmsmo5bmQ9mpAabJVaTBbu9Jyh7xVnupiwpfk3phBSXR64aVewWNjudFaByh3bD5Fi1vGj1dYYX9J9JgwqD1SovJHAA3sF5UFLCCHo98VEm7875D26UpXfbr6DxKADKh4HY5QvDeeG7G3dEakPoGHXSTHg3qqWNAucMSJ3oxKsfsSFLNkFHgRRNgz3jFVe

This operation is unnecessary

This is working as intended. For example, some valid uses are:

cancelling a transaction by replacing it with an empty one (with a higher fee, so that it gets accepted by the network)
cryptographically commiting to some data on the chain, via the account's receipt chain hash (which implicitly includes the transaction memo's hash)

It's also not worth the time or effort to explicitly ban this. Closing.


Add support for terraform-docs

Would be great to add support for creating documentation like here:
https://github.com/terraform-docs/terraform-docs

Hm, this doesn't sound like a pre-commit hook... Wouldn't this be more of a release step you'd want (e.g., when tagging a new release of a module)?

Hey @brikis98 ,
thanks, you're correct, looks like this would be more interesting for sole terraform-modules as it generates a nice table about
requirements, necessary providers, inputs and outputs.
Think that's not applicable for the terragrunt-wrapper.