On Android 5 (L), app crashes when bluetooth is disabled

Hey Mikael,
If the app is started, a dialog pops up to tell the user that the app wants to enable bluetooth and asks whether they want to allow it. When you click yes, the same dialog is shown again and when you press yes again, the app crashes. Bluetooth is enabled correctly though and if you start the app again, it will just work because Bluetooth is enabled then.
Can you confirm this issue?
Thanks for all your work.
Marc

@qpwr Hi Marc, I have tested this scenario on an LG G2 with Android 5.0.2, but did not experience the repeated dialog display.
Which device are you using? Would it be possible to get the output from adb logcat when the crash happens? That could provide clues to the problem.
Best, Mikael

@mikaelkindborg, as far as I can see, this should be the output. I waited for the dialog to appear and then confirmed it. This is what followed:
E/bt_gap_api.c( 1375): [GAP] btmtk_paired_dev_cache_init open error 2: No such file or directory
E/RequestPermissionActivity( 7824): Unexpected onActivityResult 5 0
E/AndroidRuntime(16219): FATAL EXCEPTION: main
E/AndroidRuntime(16219): Process: com.trademarc.smartrace, PID: 16219
E/AndroidRuntime(16219): java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=0, result=0, data=null} to activity {com.trademarc.smartrace/com.trademarc.smartrace.MainActivity}: java.lang.NullPointerException
E/AndroidRuntime(16219): 	at android.app.ActivityThread.deliverResults(ActivityThread.java:3604)
E/AndroidRuntime(16219): 	at android.app.ActivityThread.handleSendResult(ActivityThread.java:3647)
E/AndroidRuntime(16219): 	at android.app.ActivityThread.access$1400(ActivityThread.java:151)
E/AndroidRuntime(16219): 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1402)
E/AndroidRuntime(16219): 	at android.os.Handler.dispatchMessage(Handler.java:110)
E/AndroidRuntime(16219): 	at android.os.Looper.loop(Looper.java:193)
E/AndroidRuntime(16219): 	at android.app.ActivityThread.main(ActivityThread.java:5345)
E/AndroidRuntime(16219): 	at java.lang.reflect.Method.invokeNative(Native Method)
E/AndroidRuntime(16219): 	at java.lang.reflect.Method.invoke(Method.java:515)
E/AndroidRuntime(16219): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:824)
E/AndroidRuntime(16219): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:640)
E/AndroidRuntime(16219): 	at dalvik.system.NativeStart.main(Native Method)
E/AndroidRuntime(16219): Caused by: java.lang.NullPointerException
E/AndroidRuntime(16219): 	at com.evothings.BLE.onActivityResult(BLE.java:199)
E/AndroidRuntime(16219): 	at org.apache.cordova.CordovaInterfaceImpl.onActivityResult(CordovaInterfaceImpl.java:151)
E/AndroidRuntime(16219): 	at org.apache.cordova.CordovaActivity.onActivityResult(CordovaActivity.java:348)
E/AndroidRuntime(16219): 	at android.app.Activity.dispatchActivityResult(Activity.java:5535)
E/AndroidRuntime(16219): 	at android.app.ActivityThread.deliverResults(ActivityThread.java:3600)
E/AndroidRuntime(16219): 	... 11 more
E/BTIF_GATT_CLIENT( 1375): [GATT][ERR] initGattcSock#1732 : bind socket failed : Invalid argument, errno=22
E/AudioService(  662): handleConfigurationChanged() createInstance IAudioServiceExt fail
E/bt_gap_api.c( 1375): [GAP]read error(0 bytes read) 11: Try again
E/BluetoothServiceJni( 1375): SOCK FLAG = 1 ***********************
E/MTKBT   ( 1375): [Session]the session[61458][1375] is not ready to monitor
E/MTKBT   ( 1375): [Session]no any more session is in list
E/MTKBT   ( 1375): [Session]the session[61458][1375] is not ready to monitor
E/MTKBT   ( 1375): [Session]no any more session is in list
E/BluetoothServiceJni( 1375): SOCK FLAG = 1 ***********************
E/MTKBT   ( 1375): [Session]the session[61458][1375] is not ready to monitor
E/MTKBT   ( 1375): [Session]the session[61460][1375] is not ready to monitor
E/MTKBT   ( 1375): [Session]no any more session is in list
E/MTKBT   ( 1375): [Session]the session[61458][1375] is not ready to monitor
E/MTKBT   ( 1375): [Session]the session[61460][1375] is not ready to monitor
E/MTKBT   ( 1375): [Session]no any more session is in list
E/BluetoothReceiver(  962): [MMI][BluetoothReceiver.startService][start service [com.mediatek.bluetooth.AdvancedService]
E/BluetoothServiceJni( 1375): SOCK FLAG = 0 ***********************
E/MTKBT   ( 1375): [Session]the session[61458][1375] is not ready to monitor
E/MTKBT   ( 1375): [Session]the session[61460][1375] is not ready to monitor
E/MTKBT   ( 1375): [Session]the session[61462][1375] is not ready to monitor
E/MTKBT   ( 1375): [Session]no any more session is in list
E/MTKBT   ( 1375): [Session]the session[61458][1375] is not ready to monitor
E/MTKBT   ( 1375): [Session]the session[61460][1375] is not ready to monitor
E/MTKBT   ( 1375): [Session]the session[61462][1375] is not ready to monitor
E/MTKBT   ( 1375): [Session]no any more session is in list
E/        (  733): appName=com.android.systemui, acAppName=/system/bin/surfaceflinger
E/        (  733): 0
E/        (  733): appName=com.android.systemui, acAppName=/system/bin/surfaceflinger
E/        (  733): 0

@qpwr Many thanks for the log. Looks like a null-pointer exception, but I don't see anything obvious in the code.
Does this happen in Evothings Viewer or in a "stand-alone" Cordova app? Do you have the version number for the Viewer or the plugin version?

It does happen in my standalone app with this version of your plugin: cordova-plugin-ble 1.3.1 "Evothings BLE API"

@qpwr Hello again, there is now an updated version of the plugin version 1.4.0 that has checks for the null pointer exceptions.
Just a thought, can you check that startScan (or connect) is not called twice in your code, this may be the cause of the double dialog display.
Updated version of Evothings Viewer for Android:
https://evothings.com/uploads/evothings-studio/viewer/EvothingsViewer_1.4.1_debug_160705_2056.apk
Updated BLE plugin version 1.4.0:
https://github.com/evothings/cordova-ble/releases/tag/1.4.0
Updated EasyBLE library:
https://github.com/evothings/evothings-libraries/blob/master/libs/evothings/easyble/easyble.js

Hey @mikaelkindborg, thanks for the new version. While it seems that the null pointer exception handling works (no more crashes when bluetooth is being requested), I'm no longer able to connect to my device properly (which used to work of course with 1.3.1). I'm currently doing this after successfully connecting to the device:
device.writeDescriptor(
	'39df9999-b1b4-b90b-57f1-7144ae4e4a6a', // characteristic
	'00002902-0000-1000-8000-00805f9b34fb', // descriptor
	new Uint8Array([1,0]),
	function() {
	},
	function() {
	}
);

device.enableNotification(
	'39df9999-b1b4-b90b-57f1-7144ae4e4a6a',
	function(data) {
		var realdata = new Uint8Array(data);
		app.util.parse_notification(realdata);
	},
	function() {
	}
);

This code worked with 1.3.1 of your plugin. Afterwards I'm requesting data like this:
ns.send_command = function(command) {

	if (!$.isFunction(app.net.device_handle.writeCharacteristic)) {
		return false;
	}

	app.net.device_handle.writeCharacteristic(
		"39df8888-b1b4-b90b-57f1-7144ae4e4a6a", // characteristic
		app.util.string_to_arraybuffer(ns.commands[command]),
		function() {
		},
		function() {
		}
	);
};

I added debug output to the writeCharacteristic call, but its never shown, which probably means that the function call fails internally. Do you have any clue for me? I also tried playing around with the new writeConfigDescriptor param, but to no avail... :-(

Hey @mikaelkindborg, thanks for the new version. While it seems that the null pointer exception handling works (no more crashes when bluetooth is being requested), I'm no longer able to connect to my device properly (which used to work of course with 1.3.1). I'm currently doing this after successfully connecting to the device:
device.writeDescriptor(
	'39df9999-b1b4-b90b-57f1-7144ae4e4a6a', // characteristic
	'00002902-0000-1000-8000-00805f9b34fb', // descriptor
	new Uint8Array([1,0]),
	function() {
	},
	function() {
	}
);

device.enableNotification(
	'39df9999-b1b4-b90b-57f1-7144ae4e4a6a',
	function(data) {
		var realdata = new Uint8Array(data);
		app.util.parse_notification(realdata);
	},
	function() {
	}
);

This code worked with 1.3.1 of your plugin. Afterwards I'm requesting data like this:
ns.send_command = function(command) {

	if (!$.isFunction(app.net.device_handle.writeCharacteristic)) {
		return false;
	}

	app.net.device_handle.writeCharacteristic(
		"39df8888-b1b4-b90b-57f1-7144ae4e4a6a", // characteristic
		app.util.string_to_arraybuffer(ns.commands[command]),
		function() {
		},
		function() {
		}
	);
};

I added debug output to the writeCharacteristic call, but its never shown, which probably means that the function call fails internally. Do you have any clue for me? I also tried playing around with the new writeConfigDescriptor param, but to no avail... :-(

@qpwr Would be great to have some more debug logging to see what goes on. Did you add logging to the native Java code? Or to the JS code? The success and error callbacks in the above code are empty, have you tried to add debug logging there? Perhaps an error callback is called somewhere? Did you also update easyble.js?

@mikaelkindborg, I can try to provide some debug output later. Regarding your question: I had added console.log()s to the calls above but removed them when I posted the code here. Neither of them would display.
Also, I honestly don't understand your documentation in ble.js when trying to find out if my code is correct at all. E.g., I'm using readServices() which seems to work correctly but doesn't appear in your documentation or in ble.js (there is only services()). Also, when calling enableNotification(), it was formerly not required to provide a characteristicHandle, but now it seems it is required to do so.
Am I perhaps doing something generally wrong?

@qpwr Hi, I will try to help. File ble.js is the JavaScript API for the BLE plugin, it is a rather low-level API. Then the file easyble.js is a higher level API that is meant to handle some common tasks and make it easier to use the plugin.
If you use easyble.js, you normally don't use the functions in ble.js. Furthermore, ble.js is not explicitly included in index.html (it is included when cordova.js is included), but easyble.js must be explicitly included in index.html.
Here is documentation for ble.js: https://evothings.com/doc/lib-doc/module-cordova-plugin-ble.html
And this is the documentation for easyble.js: https://evothings.com/doc/lib-doc/evothings.easyble.html
For latest version of easyble.js, see file on GitHub (and included documentation comments):
https://github.com/evothings/evothings-libraries/blob/master/libs/evothings/easyble/easyble.js
Does this help at all to clarify. You are welcome to email me you code to<EMAIL_ADDRESS>and I will have a look.

@mikaelkindborg, thank you very much for the clarification. I didn't know my own code actually, of course I'm including easyble.js (older version), but forgot about it due to my own asset management :-D
Well, the version of easyble.js I am currently using doesn't have any dependencies (which is nice), but now it seems I have to include a whole bunch of files (the whole evothings lib), which I don't like. Do I get something wrong? Or is there a "standalone" version of easyble.js?

@qpwr You are hitting a regrettable design choice, there is no standalone version of easyble.js. You have to add several folders with JS files for everything to work. Files are included using asynchronous loading which makes it non-transparent which files you need to have.
Here is a zip-archive with the files you need: evothings.zip
In index.html you need to include these files (in addition to your own JS files):
<script src="cordova.js"></script>
<script src="libs/evothings/evothings.js"></script>
<script src="libs/evothings/easyble/easyble.js"></script>

It goes without saying that this is overly complicated. I am working on making distribution JS files that include everything needed, not using any async file loading. Also planning a tutorial about this.
Thanks for your input, the trouble you have experienced shows that the handling of Evothings libraries needs to be improved.
Best regards, Mikael

Thanks for giving some light on this. Would you recommend that i use the low level api (ble.js) then? I think I would Need to change how my code currently Works then, but it would probably be better.

@qpwr I recommend easyble.js since this is a easier (in my experience) than using the API in ble.js. The tricky thing with using the API in ble.js is that you need to manage mappings from UUIDs to handles for service characteristics and descriptors.
If you want to use ble.js (and not easyble.js) the function readAllServiceData in ble.js may be helpful.

@qpwr Hi again, here is a file called easyble.dist.js that contains all JavaScript needed for EasyBLE:
https://github.com/evothings/evothings-libraries/blob/master/libs/evothings/eddystone/eddystone.dist.js
Raw text:
https://raw.githubusercontent.com/evothings/evothings-libraries/master/libs/evothings/eddystone/eddystone.dist.js
No need to keep track of library folders.
Just include in your app (in index.html):
<script src="eddystone.dist.js"></script>

This file can be placed where you like, no need for it to be in an evothings folder.
Let me know how it works if you test this, just committed this update for testing.

Thanks a lot @mikaelkindborg, I will definately try that.

@qpwr I just discovered a bug that prevented automatic writing of the config descriptor from working when enabling notifications/indications.
The options parameter should also work now.
Published a new BLE plugin version 1.4.1 with a fix.
Sorry for the trouble.

Release candidate of Evothings Viewer 1.4.1 for Android for testing available here:
https://evothings.com/uploads/evothings-studio/viewer/EvothingsViewer_1.4.1_160711_1608.apk
Contains the BLE plugin 1.4.1 with the bug fix for notifications.

1.4.1 in connection with eddystone.dist.js (aka easyble.js) works smoothly for me. Thanks a lot, @mikaelkindborg. By the way: Is https://raw.githubusercontent.com/evothings/evothings-libraries/master/libs/evothings/eddystone/eddystone.dist.js also part of new releases, so I can be sure that I don't miss any bugfixes using this file?

@qpwr The EasyBLE library (easyble.dist.js) and the Eddystone library (eddystone.dist.js) are updated with bug fixes etc separately from the BLE plugin. We are in the process of putting these libraries under structured version handling. I am looking at ways to improve the whole BLE API-situation. It can be confusing to have both the BLE plugin and libraries written on top or the plugin. It has been an ongoing discussion whether to have libraries separated from the BLE plugin or include them with the BLE plugin. Bundling libraries with the BLE plugin, or updating the BLE plugin API itself to be easier to use, is certainly an option. Many thanks for your input, most valuable feedback!

Well, I also would prefer as less dependencies as possible. So if it would be possible to have all the stuff in the plugin, I would be very happy. Keep up the great work and thanks a lot for your quick help :-)

@qpwr Many thanks for the feedback!
Just to let you know, there is a new release of the BLE plugin:
https://github.com/evothings/cordova-ble/releases
And a build of Evothings Viewer for Android with that plugin version included:
https://evothings.com/uploads/evothings-studio/viewer/EvothingsViewer_1.4.1_160712_1927.apk

@mikaelkindborg, thanks for letting me know. Can you extend a bit on what this fix is about? I just released a new version of my app with 1.4.1 of your plugin and would like to know if I'm affected by the issue(s) you fixed. Thanks!

@mikaelkindborg, thanks for letting me know. Can you extend a bit on what this fix is about? I just released a new version of my app with 1.4.1 of your plugin and would like to know if I'm affected by the issue(s) you fixed. Thanks!

@qpwr It was the options parameter for enbleNotification that did not work properly. This caused failure to write characteristics when automatic writing of the config descriptor was turned off. If you haven't used the option writeConfigDescriptor: false it should work fine.

Closing this issue, let me know if any problems persist and I will reopen.


QUIC empty protocol implementation

This is starting point for the empty protocol implementation.
Checklist

[x] tests are added or updated

@mattcaswell I've addressed your comments hopefully.

ping for the second review

Fixup pushed addressing @paulidale's comments. @mattcaswell Still ok?

@paulidale will you approve please?

Force pushed just to remove conflicts.

This pull request is ready to merge

Merged to master.


`GLIBC_2.28' not found

ubuntu 18.04     python3.7.10
pip install  torch-1.6.0-cp37-cp37m-linux_aarch64.whl   Success.
but
ImportError: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /www/miniconda3/envs/vits/lib/python3.7/site-packages/torch/lib/libtorch_python.so)

Hi, Ubuntu 18.04 ships with ver. 2.27 of GLIBC. You can either using a higher version of Ubuntu or install newer version manually.


Cannot await on interfaces extending Promise<any> in TypeScript 2.1 RC

For context: I ran into this bug using Knex and its type definition in TypeScript 2.1 RC. Knex's type definitions use an extended Promise interface for every value returned from a query, to allow for further chaining. Unfortunately, it looks like async/await in TypeScript does not support this.
I found several references to fixed issues and regressions in prior versions of TypeScript, but could not find an open issue for the current version. Apologies if this is a duplicate issue.
TypeScript Version: typescript@rc (2.1.1)
Code
main.ts:
interface PromiseExtender extends Promise<any> {
}

function getPromiseExtender(): PromiseExtender {
  return new Promise((resolve, reject) => {});
}

async function main() {
  await getPromiseExtender();  // error: Operand for 'await' does not have a valid callable 'then' member.
}

tsconfig.json:
{
  "compilerOptions": {
    "target": "es5",
    "lib": ["dom", "es6", "es2015.promise", "es2015.iterable", "scripthost"],
    "module": "commonjs",
    "sourceMap": true,
    "strictNullChecks": true,
    "noImplicitAny": true
  }
}

Runnable test case: https://github.com/thomasboyt/typescript-await-promise-bug-test-case
Expected behavior: TypeScript allows awaiting interfaces extending Promise<any>.
Actual behavior: TypeScript displays the error Operand for 'await' does not have a valid callable 'then' member..
My current workaround for this is to just await (promiseExtendingObject as any), so it's not the end of the world. Hopefully can be fixed before 2.1 is released, though :)

Would interface PromiseExtender<T> extends Promise<T> {} work?

@Kovensky It shouldn't need to - ES async/await operates on thenables, not just promises.

Ran into another library with this issue: supertest-as-promised, which adds a then method to an existing interface (with the slight indirection of going through Bluebird, since that's the underlying promise implementation that library uses: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/supertest-as-promised/supertest-as-promised.d.ts).

Same deal with superagent.
It doesn't seem like it matters what is used as the generic parameter...

Fixed in #12743

Fix should be in typescript@next later tonight. Please give it a try and let us know if you are still running into issues.

Will it make the final release of 2.1, a patch release, or 2.2?
On Wed, Dec 7, 2016, 20:55 Mohamed Hegazy<EMAIL_ADDRESS>wrote:

Fix should be in typescript@next later tonight. Please give it a try and
let us know if you are still running into issues.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/issues/12292#issuecomment-265631021,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AERrBGXvMQFz7Guc8neVDGdoLaD6sbVRks5rF2OVgaJpZM4Kza4p
.

@mhegazy seems to be fine now, thanks.


update<EMAIL_ADDRESS>to<EMAIL_ADDRESS>

Reproduction
npm audit
I have included this as a bug report because there is no PR yet and I could not find an appropriate place to list it.
System Info
<EMAIL_ADDRESS><EMAIL_ADDRESS>
Used Package Manager
npm
Expected Behavior
no audit report
Actual Behavior
# npm audit report

cookie  <0.7.0
cookie accepts cookie name, path, and domain with out of bounds characters - https://github.com/advisories/GHSA-pxg6-pf52-xh8x
No fix available
node_modules/cookie
  @remix-run/server-runtime  *
  Depends on vulnerable versions of cookie
  node_modules/@remix-run/server-runtime
    @remix-run/node  *
    Depends on vulnerable versions of @remix-run/server-runtime
    node_modules/@remix-run/node

To temporarily bump the transitive cookie dependency you can use an override in your package.json:
  "overrides": {
    "@remix-run/server-runtime": {
      "cookie": "^0.7.2"
    }
  }


Index File Contents Not Generating

I was working on setting up an index file using the script. I was able to get the base python environment setup and executed the command. It seemed to have scanned the files as shown below:
[system@vps TinGen]# python3 TinGen.py --credentials creds/credentials.json --token creds/gdrive.token --success "Test" --index-file index.html --share-files --no-compress <gdrive_id>
Generating index
Files scanned: 5.43kfile [00:29, 1.62s/file]Adding success message to index
Creating generated index to index.html
Sharing files in index
File Share Progress: 0.00file [00:00, ?file/s]
Index Generation Completefile [00:00, ?file/s]
Files scanned: 10.8kfile [00:35, 304file/s]
However upon viewing contents of the index file this is all that is displayed:
[system@vps TinGen]# cat index.html
TINFOIL {"files": [], "success": "Test"}
Attempted on both Windows 10 and CentOS. Both operating systems showed the same results when trying to generate an index file.

I had to roll back to c9269ed2a3a71a98d47a7d9d7d3f7f21d9589abc to get things working, looks like the style changes causing some issues.

Awesome let clone the repo and I will see how it works out now.

Seems that commit c9269ed is currently still working as intended. I guess I would concur with your previous statement based on the commits that have been published.

it works fine on for me.
im running with this command.
python3 TinGen.py --headless  --upload-to-my-drive --share-uploaded-index --add-nsw-files-without-title-id --add-non-nsw-files --no-compress
make sure that you have the "--add-non-nsw-files" if you dont use nsw files

--add-non-nsw-files   Adds files without valid NSW ROM extension(NSP/NSZ/XCI/XCZ) to index
That doesn't even make sense, tried it for lulz, doesn't change anything. All of my files have a proper extension(NSP/NSZ/XCI/XCZ).

Closed thanks to #18. Sorry for keeping the broken code in GitHub. I fixed this locally previously, but forgot to push to GitHub.


Incorrect contrast and non-hdr result

There are two problem I've got.
Unity 2020.3.40

The imported Texture2D result is very contrast compared to the imported Unity Editor result

the latest version also gives non-hdr Texture2D, I've tried previous version, the texture is HDR (cheked with skybox+reflection probe = can change exposure to see HDR effect), but it's still very contrast

Any chance it'll be fixed?
Thanks!

@stencg The fix that worked for me is to set the texture format to TextureFormat.RGB9e5Float in the RadianceHDRTexture constructor.

The problem with the different contrast was due that I tried it in a project with Gamma color space. So my fix is adding gamma correction to method RGBEBytetoColor:
var gamma = QualitySettings.activeColorSpace == ColorSpace.Gamma ? 2.2f : 1.0f;  double f = Math.Pow(2.0, e - 128.0f) / 255.0f; pixel.r = (float)(Math.Pow(rgbeByte[0] * f, 1.0 / gamma)); pixel.g = (float)(Math.Pow(rgbeByte[1] * f, 1.0 / gamma)); pixel.b = (float)(Math.Pow(rgbeByte[2] * f, 1.0 / gamma));

@praveensj91 I independently discovered this and it's now implemented in 1.0.3, thanks!

@stencg please can you open a separate issue for the gamma changes if still required, and we'll try get it added in a way that supports both color spaces!


Manually set timeline_start_lsn in safekeepers for old timelines

Look at https://github.com/neondatabase/neon/issues/1963#issuecomment-1160671271 for more info
After timeline_start_lsn will be set everywhere, then we can enable checks that were disabled in https://github.com/neondatabase/neon/pull/1964

done

There are still 9 timelines with timeline_start_lsn=1, AFAIR they are very old and first WAL segment is missing.


Add Edhouse job offer to companies.yaml

Thanks! That's great news that there is a Rust job opening in Moravia :)
I should probably re-design the website soon, since there are many entries already and the bootstrap cards are not very visible/usable.

By the way, you can also post job offers to the #jobhunt channel at the Rust CZ/SK Discord: https://discord.com/channels/984549594572664854/1044960710972670033.

I should probably re-design the website soon, since there are many entries already and the bootstrap cards are not very visible/usable.

@Kobzol Maybe I could try and take a look at that, at least in the companies section. The Zola framework you are using looks very interesting and I would like to learn how it works. I might send you another PR later, depends if I find time.

Great, if you find the time and can think of a better design, feel free to send a PR :)


ui settings defaults - error with default language config

after merging PR #1578 when calling default settings page, we get the following error:
Read Config - Error reading Config for default language: taking default English . See log for details!
after first save of default settings, the error does not occur any more.
can we fix this by simply adding a db default language entry? No, this entry is already present.

fixed


update to go 1.18

[x] depends on https://github.com/moby/swarmkit/pull/3088
[x] depends on https://github.com/moby/swarmkit/pull/3089

(let's see if this is the cause of the failures in https://github.com/moby/swarmkit/pull/3069

Alright, so this bit works; moving it out of draft
@dperny PTAL

@neersighted @dperny PTAL (I'll continue looking at https://github.com/moby/swarmkit/pull/3085 after this)


cpp helloworld latency is insane bigger

What version of gRPC and what language are you using?
v1.30.2
What operating system (Linux, Windows,...) and version?
ubuntu 18.04
What runtime / compiler are you using (e.g. python version or version of gcc)
gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04)
What did you do?
Please provide either 1) A unit test for reproducing the bug or 2) Specific steps for us to follow to reproduce the bug. If there’s not enough information to debug the problem, gRPC team may close the issue at their discretion. You’re welcome to re-open the issue once you have a reproduction.

Add filed in the helloworld.proto as time.

message HelloRequest {
  string name = 1;
  double time = 2;
}

create first timestamp in the greeter_async_client2.cc

    request.set_time(ros::Time::now().toSec());

create response timestamp in the greeter_async_server.cc

        std::string prefix("Hello ");
        reply_.set_message(prefix + request_.name());
        double latency = (ros::Time::now().toSec()-request_.time())*1000;
        std::cout<<"latency: "<<latency<<" ms"<<std::endl;

What did you expect to see?
And clients in greeter_async_client2 use the same channel.
See TROUBLESHOOTING.md for how to diagnose problems better.
Anything else we should know about your project / environment?
greeter_async_server and greeter_async_client run on the same machine.

Hey guys, do you have any updates on this? I am experiencing a similar issue. I m looking at a ~600 microseconds latency using the cpp helloworld example (async, unary call).  I also tried the Python example in the same box, which gives me a ~300 microseconds latency.
By looking at https://performance-dot-grpc-testing.appspot.com/explore?dashboard=5180705743044608&widget=1274284569&container=695104531
I believe it aligns with Python's results. C++ result is somehow 4X slower. Wondered if it has anything to do with the setup (payload sizes etc.).

Hi, sorry for the late reply. The CQ examples shown are not optimized for performance, but I understand that the CQ API is hard to use, which is why we've been recommending usage of the callback API instead. Please try that instead for benchmarking. Our current performance optimization efforts are also targeting the callback API.


how to use UIAppearance with stylesheets, or otherwise default UI elements to "ios blue"?

Maybe an odd ask, but I would really like for a button that is added via rmq.append(UIButton, :action_button) to have the default iOS blue tint color.
I've found some answers on stack that provide the RGB values for that color, but I would think that hooking into UIAppearance would be a more flexible option.
Is this doable with RMQ? I suppose I could create a style that uses tintColor and the RGB of the iOS default, but I think it'd be more helpful to inherit by default the color of the most near UIAppearance (i.e. the superview, the view controller, the application window).
I'm grasping at straws a little bit here, but I found it odd that just adding a UIButton via rmq.append() with no style attributes inserts a button with seemingly clear text.

I haven't used UIAppearance much myself, but from what I can tell.  If you have your appearance classes setup properly they should default to the proper color.  You are correct if you create a button without adding any style information it will not have any styling and would be clear text, probably not the right size, etc...
I am assuming that if Appearance works then we should be able to work, but I dont have any experience using Appearance to be able to help much..
maybe if I can clear some time I can get a sample app and try and get a working example together.


Prioritizing possible use cases

Chatted a bit with @dvenprasad about this, but wanted to open this up for discussion with @cgreene. Given that we have a limited amount of time, we'll need to prioritize which kinds of use cases (related: https://github.com/AlexsLemonade/refinebio/issues/97) we'll put together. Specifically, we think the users that would most benefit from some examples initially) are biology experts and folks with a background in machine learning with less biology knowledge. With that in mind, here are three examples I am considering:

Downloading a single experiment and using it with Gene Pattern Notebooks for something like clustering (see public examples; login required to go beyond that page). I believe this may have a lower barrier to entry than some R snippets, but this could use a bit more research.
Analyzing a collection of data with a neural network based model like Tybalt. I'm a bit concerned about the optimization that would be required here.
Some kind of (relatively simple) cross-species example that includes ortholog mapping (most likely with hcop). This along the lines of use case eight here.

I defer to you on the utility of Gene Pattern Notebooks (just not familiar enough with them). I wonder if we want to focus primarily on the type of bio-focused users that we expect at the start (simple things, like differential expression analysis, etc) than the ML folks. That seems like the most important set of things to get up first to me.

We could potentially do simple things like differential expression and clustering multiple ways, too.

GenePattern modules typically require GCT format. The GenePattern documentation has helpful information about GCT format. We can point users there and/or provide a code snippet.

Also need a CLS file if doing differential expression analysis.

Related: AlexsLemonade/refinebio#333

I think this is better tracked elsewhere, so I'm going to close this.


Create very basic version of frontend

Proposed solution
Make first draft for frontend, which could have:

File upload components
Some feedback based on http responses from backend

DoD (Definition of Done)

Make it possible to upload xml file from frontend

Testing

Test with suitable unit tests

Fixed in #3


Command output disappears when cmdheight=0

Steps to reproduce
vim --clean <file> -c 'set cmdheight=0'

:g/pattern

Expected behaviour
The output of the command stays until hitting enter or maybe some other key.
Version of Vim
9.0.325
Environment
Operating system: Arch Linux
Terminal: kitty
Value of $TERM: xterm-kitty
Shell: fish
Logs and stack traces
No response

Hi, I have tested it but I cannot reproduce the behavior.
Please explain the problem clearly.
I think the screencast is needed.

I think what @EgZvor is trying to say is that the output of :g/pattern is redirected to the message popup instead of Vim's internal pager when cmdheight is set to zero. As a result the output of :g/pattern disappears after three seconds. Besides that, the message popup cannot be scrolled, unlike the pager.

I think what @EgZvor is trying to say is that the output of
:g/pattern is redirected to the message popup instead of Vim's
internal pager when cmdheight is set to zero. As a result the output
of :g/pattern disappears after three seconds. Besides that, the
message popup cannot be scrolled, unlike the pager.

I have been thinking of a way to make the message window stay up longer,
but can't think of what key to use for that.
Anyway, that doesn't solve the problem of paging through results, this
output should not go to the message window.
There are more commands where this applies, but not all.  For some it is
nice you don't have to type Enter before you can continue.  Might have
to decide for each command specifically...
--
Kiss me twice.  I'm schizophrenic.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I think this can be closed now since the feature has been removed.


fix: remove white background from logo

remove white background on logo png to match extension list
closes #6


Group bonuses

Allow multiple people to join a bonus room, for online team bonus practices. Same concept as multiplayer tu rooms, chatting and 1 person is made team capitan to input the answer line.

duplicate of #230


[Minor][SPARK-13482][Configuration]Make consistency of the configuraiton named  in TransportConf.

spark.storage.memoryMapThreshold has two kind of the value, one is 210241024 as integer and the other one is '2m' as string.
"2m" is recommanded in document but it will go wrong if the code goes into TransportConf#memoryMapBytes.
Jira

Test build #51927 has started for PR 11360 at commit f8367ee.

Test build #51927 has finished for PR 11360 at commit f8367ee.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51927/
Test PASSed.

Merged build finished. Test PASSed.

Thanks - going to merge this in master and branch-1.6.


provide interface according to candid provided

would be nice if i had access to the method available on a canister and their signatures when i define an actor like this:
  ogy = Canister(agent=agent, canister_id=canister_id,
                    candid=ogy_candid)

Python is dynamic language, which means it can add property and methods in the runtime.
But I think the Pylance analyze the code based on static analysis. Thus it can't detect the method added in runtime.


[CELEBORN-1246][METRICS] Celeborn add Metrics about push/replicate/fetch/openstream success count

What changes were proposed in this pull request?
Celeborn add Metrics about push/replicate/fetch/openstream success count
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?

cc @WillemJiang @FMX

@AngersZhuuuu, could you also update the METRICS.md to align the document with introduced metrics?

Merged into main(v0.5.0) and branch-0.4(v0.4.0).


Rename DCC.combined-schema.json to TESTon

@genigre Why the rename?

Hi,
I tested something.  It doesn't work for me.

@jschlyter I assume that this PR is not relevant anymore - agree?


Odd tags appearing

I figured out what was going on with that issue I mentioned the other day with the random [a][b] tags appearing in my chapter upon import. They appear wherever there is an unresolved comment in the Gdoc. Interestingly, these go through the alphabet in sequence. So wherever the first comment is in the Gdoc will have the [a][b] appearing in the chapter text, while the second comment will have [c][d] tags and the third will have [e][f], so on and so forth.

Thanks for the report! This is definitely not something the Importer adds, so I guess Google adds these tags automatically. I will have a look at it and try to write a filter that removes these unresolved comments.

This probably isn't at all helpful knowledge to you, but just in case it is, the original Fimfiction document importer does bring over comments. The default importer adds all the text from any comments to the bottom of the chapter rather than converting the comments into tags. If I recall correctly (and I might not), the import feature didn't originally bring over comments, and only started doing that around the time I first noticed bugs appearing in the import Gdoc feature. So I suppose it does seem likely that it's something on Google's end, since that didn't seem like an intended feature of Fimfiction's doc importer either.


[Removal]: Hot Arctic Anteater

Hotspot Name
Hot Arctic Anteater
Hotspot b58 Address
112mfdQRXAHtTTFvw7SYjqqzSo3yMCFivVnQ6W1A88NGyTsY7wBw
Discord Handle
Borislav Vukov#5976
Hotspot Manufacturer
SenseCAP
Removal Reason
The hotspot should have been added to the denylist by mistake along with all the nearby hotspots in the area.
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
It seems like my hotspot has been added to the denylist by mistake for a second time this month. I have bought the miner brand new from an official partner and I do not use any modifications, extra forwarders, extra antennas. Please remove me from the denylist, since it's affecting the mining rewards significantly.  Attached is a photo of my setup.

No one answered. Adding is very positive, and deleting is very difficult.

We do not have sufficient evidence to remove these hotspots from the denylist. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.

Hi, my Sensecap is still on the denylist and a month has already passed. Please advise when it would be removed. Thanks!


Tracking: CVE-2019-5736: runc container breakout

This issue is simply for tracking the fixes related to CVE-2019-5736.

The relevant releases have now been published. See https://gravitational.com/gravity/docs/changelog/


stdenvAdapters.useMoldLinker and mold is not working on Darwin

Describe the bug
stdenvAdapters.useMoldLinker is broken on macOS.
Steps To Reproduce
Steps to reproduce the behavior:

Enter shell with mold as linker (ld) in stdenv in macOS.

shell.nix:
{
  pkgs ? import <nixpkgs> { },
}:
pkgs.mkShell.override { stdenv = pkgs.stdenvAdapters.useMoldLinker pkgs.stdenv; } { } # default stdenv in darwin is clangStdenv

Try to compile any program (e.g. int main() {}):

$ echo "int main() { return 0; }" > main.c
$ cc main.c
$ clang main.c
clang-16: error: invalid linker name in argument '-fuse-ld=mold'

In one line:
nix-shell -E '{ pkgs ? import <nixpkgs> {} }: pkgs.mkShell.override { stdenv = pkgs.stdenvAdapters.useMoldLinker pkgs.stdenv; } {}' --run 'echo "int main() {}" | c++ -x c++ -'

Expected behavior
Program links and compiles.
Additional context
There are multiple issues:

clang on Darwin requires absolute path for linker, while stdenvAdapters.useMoldLinker doesn't add path. This is not the issue on Linux, for some reason.
https://github.com/NixOS/nixpkgs/blob/3ced993e74e20617ca6a489a10bd60aebde7714b/pkgs/stdenv/adapters.nix#L279

Even with absolute path, it doesn't work when targeting Darwin, since mold macOS support is somewhat incomplete.

[nix-shell:~]$ clang -fuse-ld=/nix/store/syjvjxak1dyxh5ih5b3h0zmdy22c72vj-mold-2.33.0/bin/mold main.c  -v
clang version 16.0.6
Target: x86_64-apple-darwin
Thread model: posix
InstalledDir: /nix/store/4lfrpghx5qbx7ym8lv0w9rnzxxaihpzb-clang-16.0.6/bin
 "/nix/store/4lfrpghx5qbx7ym8lv0w9rnzxxaihpzb-clang-16.0.6/bin/clang-16" -cc1 -triple x86_64-apple-macosx10.12.0 -Wundef-prefix=TARGET_OS_ -Werror=undef-prefix -Wdeprecated-objc-isa-usage -Werror=deprecated-objc-isa-usage -emit-obj -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name main.c -mrelocation-model pic -pic-level 2 -mframe-pointer=all -ffp-contract=on -fno-rounding-math -funwind-tables=2 -faligned-alloc-unavailable -target-sdk-version=10.12.4 -fcompatibility-qualified-id-block-type-checking -fvisibility-inlines-hidden-static-local-var -target-cpu penryn -tune-cpu generic -mllvm -treat-scalable-fixed-error-as-warning -debugger-tuning=lldb -target-linker-version 951.9 -v -fcoverage-compilation-dir=/Users/runner/work/actions-playground/actions-playground -nostdsysteminc -resource-dir /nix/store/h7qvxg74vb13lfx5dh0r29ys30b4n26m-clang-wrapper-16.0.6/resource-root -idirafter /nix/store/9av79iiy4ianwnklxx0hl4q55ak9n6ws-Libsystem-1238.60.2/include -isysroot /nix/store/0jhdm020qyllac6m2wqmifr0fsimj6m8-sdkroot-10.12.4/MacOSX10.12.4.sdk -isystem /nix/store/6i4wvp977zca0a4avnlw75hq7hagwryv-libcxx-16.0.6-dev/include -isystem /nix/store/lckhx6fmrjq23y9vbs95nv6qawyi7sxm-compiler-rt-libc-16.0.6-dev/include -iframework /nix/store/1f0ddk96vg892cwd3ncfncqg5lmqn8l4-apple-framework-CoreFoundation/Library/Frameworks -isystem /nix/store/6i4wvp977zca0a4avnlw75hq7hagwryv-libcxx-16.0.6-dev/include -isystem /nix/store/lckhx6fmrjq23y9vbs95nv6qawyi7sxm-compiler-rt-libc-16.0.6-dev/include -iframework /nix/store/1f0ddk96vg892cwd3ncfncqg5lmqn8l4-apple-framework-CoreFoundation/Library/Frameworks -U _FORTIFY_SOURCE -U _FORTIFY_SOURCE -D _FORTIFY_SOURCE=2 -internal-isystem /nix/store/h7qvxg74vb13lfx5dh0r29ys30b4n26m-clang-wrapper-16.0.6/resource-root/include -source-date-epoch 315532800 -O2 -Wformat -Wformat-security -Werror=format-security -fdebug-compilation-dir=/Users/runner/work/actions-playground/actions-playground -ferror-limit 19 -fzero-call-used-regs=used-gpr -fwrapv -stack-protector 2 -stack-protector-buffer-size 4 -fblocks -fencode-extended-block-signature -fregister-global-dtors-with-atexit -fgnuc-version=4.2.1 -fmax-type-align=16 -fcolor-diagnostics -vectorize-loops -vectorize-slp -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /tmp/main-b24d98.o -x c main.c
clang -cc1 version 16.0.6 based upon LLVM 16.0.6 default target x86_64-apple-darwin22.6.0
ignoring duplicate directory "/nix/store/6i4wvp977zca0a4avnlw75hq7hagwryv-libcxx-16.0.6-dev/include"
ignoring duplicate directory "/nix/store/lckhx6fmrjq23y9vbs95nv6qawyi7sxm-compiler-rt-libc-16.0.6-dev/include"
ignoring duplicate directory "/nix/store/1f0ddk96vg892cwd3ncfncqg5lmqn8l4-apple-framework-CoreFoundation/Library/Frameworks"
#include "..." search starts here:
#include <...> search starts here:
 /nix/store/6i4wvp977zca0a4avnlw75hq7hagwryv-libcxx-16.0.6-dev/include
 /nix/store/lckhx6fmrjq23y9vbs95nv6qawyi7sxm-compiler-rt-libc-16.0.6-dev/include
 /nix/store/1f0ddk96vg892cwd3ncfncqg5lmqn8l4-apple-framework-CoreFoundation/Library/Frameworks (framework directory)
 /nix/store/h7qvxg74vb13lfx5dh0r29ys30b4n26m-clang-wrapper-16.0.6/resource-root/include
 /nix/store/9av79iiy4ianwnklxx0hl4q55ak9n6ws-Libsystem-1238.60.2/include
End of search list.

"/nix/store/syjvjxak1dyxh5ih5b3h0zmdy22c72vj-mold-2.33.0/bin/mold" -demangle -lto_library /nix/store/2jgbmi7589wfwv13qk580r1swhx180f6-llvm-16.0.6-lib/lib/libLTO.dylib -dynamic -arch x86_64 -platform_version macos 10.12.0 10.12.4 -syslibroot /nix/store/0jhdm020qyllac6m2wqmifr0fsimj6m8-sdkroot-10.12.4/MacOSX10.12.4.sdk -o a.out -L/nix/store/zmaqw40hgcvg56nfm7nqwf69jd0h6nn5-libcxx-16.0.6/lib -L/nix/store/y7crbkd8jya3k2jgrdf8q92y639c0ihr-compiler-rt-libc-16.0.6/lib -L/nix/store/zmaqw40hgcvg56nfm7nqwf69jd0h6nn5-libcxx-16.0.6/lib -L/nix/store/y7crbkd8jya3k2jgrdf8q92y639c0ihr-compiler-rt-libc-16.0.6/lib -L/nix/store/9av79iiy4ianwnklxx0hl4q55ak9n6ws-Libsystem-1238.60.2/lib -L/nix/store/jfp96rlamjqixn7gd0n1kf3fk1blx39r-clang-16.0.6-lib/lib -L/nix/store/zmaqw40hgcvg56nfm7nqwf69jd0h6nn5-libcxx-16.0.6/lib /tmp/main-b24d98.o -arch x86_64 -lSystem /nix/store/h7qvxg74vb13lfx5dh0r29ys30b4n26m-clang-wrapper-16.0.6/resource-root/lib/darwin/libclang_rt.osx.a -F/nix/store/1f0ddk96vg892cwd3ncfncqg5lmqn8l4-apple-framework-CoreFoundation/Library/Frameworks -F/nix/store/1f0ddk96vg892cwd3ncfncqg5lmqn8l4-apple-framework-CoreFoundation/Library/Frameworks

mold: fatal: unknown command line option: -dynamic; -dynamic is a macOS linker's option. mold does not support macOS.
clang-16: error: linker command failed with exit code 1 (use -v to see invocation)

There is an abandoned ex-commercial fork of mold that supports macOS: sold.
Notify maintainers
@Artturin [author of stdenvAdapters.useMoldLinker]
[maintainers of mold]
@azahi
@paveloom

Metadata
bash-3.2$  nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-darwin"`
 - host os: `Darwin 22.6.0, macOS 10.16`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.24.4`
 - nixpkgs: `/nix/store/9qq0zf30wi74pz66rr05zmxq0nv17q1p-source`

Add a :+1: reaction to issues you find important.

Looks like mold has no plans to support MacOS. I guess we can just throw if stdenv.hostPlatform is Darwin-based. I can make a PR a bit later.
I also don't think that pulling sold to Nixpkgs would be a good idea, since it's not maintained properly anymore.

Note that https://github.com/bluewhalesystems/sold , the version of mold that works on MacOS, is now MIT-licensed and free.


[Spring Cloud]Fix the deploy jar failure.

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

Didn't bump up the version on purpose. It will be included in the next major release.

Spring Cloud

Don't forget to update setup.py~

Hi, the version is left untouched on purpose. It will be changed in later PR when the new version is ready to be published.


Is it possible to add hyperlinks on cells ?

For example,there is a csv file :
link,title,description,date
http://github.com/1,title1,1,20170815
http://github.com/2,title2,2,20170815
http://github.com/3,title3,3,20170815
http://github.com/4,title4,4,20170814

output should like this:

title
description
date

title1
1
20170815

title2
2
20170815

title3
3
20170815

title4
4
20170814

Seems bit complicated since there can be any number of such fields in CSV. One simple implementation will be to mark certain row as a link and while rendering it shows as link with generic text like link. I will add this as a feature request for now.

I don't see what is complicated. I think as a first draft have the rederer find text starting with "http" then wrap it in link  suffix?  Seems to me this would work for cells that contain just a URL. (Of course, rare edge cases, like a quote (") in the URL would likely break it.)
BTW, When I edit the csv file and wrap the URL,  github refuses to render the csv, saying:

"We can make this file beautiful and searchable if this error is corrected: Illegal quoting in line ..."

(BTW, the  beautiful-and-searchable link does not mention anything about "quoting", illegal or not!)


Fix ISO value handling

https://github.com/helgeerbe/picframe/issues/370 was caused by an ISO value being returned as a tuple (50,50). Check if we have a tuple and, if so, take only the first element.

Thank you for fixing this!

PR wants to merge into main. So I cherry picked it into dev.


Schedule Page: Text not aligned, no link to speaker

Please see screenshot below:

[x] Text not aligned in one line
[x] No link to speaker implemented
[x] Name of track missing (Please add.)

Solved via #720

All text should be in one ligne. The solution provided only aligns bottom text of the area.

Verified this with http://fossasia.github.io/open-event-webapp/schedule.html  app. Looking fine now

@aayusharora, looks good to me as well


Fix MISRA violations 8.9

Fix MISRA violations 8.9
Description
Fix MISRA violations 8.9
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The changes proposed in this PR look harmless to me, but I do miss a proper explanation why you want to introduce these changes. Please explain a bit more, Thanks, Hein

Thanks for taking a look!
We are fixing all misra violations, and Rule 8.9 likes all globals/statics  that are used in one function to be defined in that function.
Alfred


screen resolation

we can do 1024x768 screen resolation ? how?

I'm not following your question. Could you be more specific, and direct any questions to my email account, please.


RFC: Build Plan Format

As more and more features have been added to Nixpacks, the build plan has slowly evolved. Before it gets out of control, we should settle on a finalized build plan format that is human readable and intuitive.
The current build plan can be seen in the following screenshot

I propose we flatten and simplify the format.
interface NixPackage {
  name: string;
  overlay?: string;
}

interface SetupPhase {
  nixPkgs: NixPackage[];
  onlyIncludeFiles?: string[];
}

interface InstallPhase {
  cmd?: string;
  onlyIncludeFiles?: string[];
}

interface BuildPhase {
  cmd?: string;
  onlyIncludeFiles?: string[];
}

interface StartPhase {
  cmd?: string;
}

interface BuildPlan {
  setup?: SetupPhase;
  install?: InstallPhase;
  build?: BuildPhase;
  start: StartPhase;
  variables: Record<string, string>;
}

Example: Yarn fastify
{
  "setup": {
    "nixPkgs": [{ "name": "pkgs.stdenv" }, { "name": "pkgs.yarn" }]
  },
  "install": {
    "cmd": "yarn install --frozen-lockfile",
    "onlyIncludeFiles": ["package.json", "yarn.lock"]
  },
  "build": {
    "cmd": "yarn build"
  },
  "start": {
    "cmd": "yarn start"
  },
  "variables": {
    "NPM_CONFIG_PRODUCTION": "false",
    "NODE_ENV": "production"
  }
}

Example: Rust rocket
{
  "setup": {
    "nixPkgs": [
      { "name": "gcc" },
      {
        "name": "(rust-bin.fromRustupToolchainFile ./rust-toolchain.toml)",
        "overlay": "https://github.com/oxalica/rust-overlay/archive/master.tar.gz"
      }
    ],
  "onlyIncludeFiles": ["rust-toolchain.toml"]
  },
  "build": {
    "dependsOn": "setup",
    "cmd": "cargo build --release",
    "onlyIncludeFiles": ["Cargo.toml"]
  },
  "start": {
    "cmd": "./target/release/rocket",
    "image": "alpine"
  },
  "variables": {
    "ROCKET_ADDRESS": "<IP_ADDRESS>"
  }
}

This looks good so far. How about adding optional post-install/pre-build and post-build/pre-deploy phases? Stuffs like database migration can be handled here.

Thats a good idea. We could even handle it like node does. Look for and run pre{NAME} and post{NAME} scripts when running the NAME script. Def taking Dagger as inspiration and it would be cool if we could support arbitrary phases with phase dependencies in the future.

How about adding version in nixPkgs? Considering that everyone isn't familiar with nix and finding nix revision for a specific version isn't easy. We'll have to maintain something like nix-package-version.

We've looked into this a bit before. I think that will be a thing we can have optional and add eventually. The support for a specific version (using something like nix-package-version) is a slightly separate discussion though.


INTEGRA-941: BUG: Dump-file not present when Import fails

Fix is to keep the API connection open until the Dump-file and any other
post-Import operations are completed, then close it gracefully.

Coverage increased (+0.03%) to 83.953% when pulling 303bb0860ffef4c33f10fc6557208b2aa22d3950 on bug/INTEGRA-941 into d283d77ba9a8388c27b93e7e35afd707c755a2ff on develop.

Hi @geospofford-anaplan, please review this bug-fix.

Coverage remained the same at 83.922% when pulling 67ebf4c929dec92f97dd10aa0a545696b44cef51 on bug/INTEGRA-941 into d283d77ba9a8388c27b93e7e35afd707c755a2ff on develop.

Coverage remained the same at 83.922% when pulling 1a3dee47f8b038c26c05327f0f49b79abd5556e4 on bug/INTEGRA-941 into 51e620c5e335244bda149659119d5d30b7d71afe on develop.


Labels assigning dropdown mis-aligned

While trying to add an issue:

I may be blind, but what part of that screenshot is misaligned exactly?

Both for comparison:

It's just a nit-pick, but still I thought I might report this.

Ah, I see the sidebar is moved quite a bit to the right, which is very weird. What browser are you using and can you link me to the issue where it's happening?

Version info:
Google Chrome	56.0.2924.87 (Official Build) (64-bit)
Revision	0e9a9a6f3676ae439b78cd9b3f62b4193c3ac7d5-refs/branch-heads/2924@{#895}
OS	Mac OS X
JavaScript	V8 5.6.326.50
Flash	<IP_ADDRESS> /Users/devkhan/Library/Application Support/Google/Chrome/PepperFlash/<IP_ADDRESS>/PepperFlashPlayer.plugin
User Agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

In general, I can see this on any issue, so it's not a repo/issue specific issue.

This doesn't appear to be a Windows + Chrome problem. Is it still an issue for you in Chrome 57?

Thanks. Fixed in Chrome v57.


User search does not work with email addresses as usernames

User search does not work with emails. It only finds results in the global part of the email addresses.

Resolved in https://github.com/DSD-DBS/capella-collab-manager/commit/72b0fc9be154f2fe1149e0236c1ff54a93ef5265

The issue has only been solved for the admin user search - project user search is still broken. Could you look into it @henrik997?


Polish cli commands

For a moment there I thought you implemented Polish translations of the CLI commands ... what with the P being uppercase and all.

Sprawdź to, @ulope


Add Caddyfile example

I recently migrated to caddy for my web server, I'm not sure where its best to put example files so I figured I'd share here and if someone wants to point me in the right direction for a pull request I'll do that:
First, add the postal user to your caddy user group then set the following as your Caddyfile config OR add it:
postal.yourdomain.tld {
        root /opt/postal/app/public

        proxy / localhost:5000 {
                header_upstream Host {host}
                header_upstream X-Real-IP {remote}
                header_upstream X-Forwarded-For {remote}
                header_upstream X-Forwarded-Proto {scheme}
        }

        header /assets {
                Cache-Control "max-age=3600"
        }
}

Caddy does not require the try_file argument or anything special, this will work perfectly everytime. The header_upstream config options could be completely replaced by a shorthand transparent but I left them here in case something special is needed in the future. No caddy plugins are required for this to work.

There is a file at https://github.com/atech/postal/blob/master/resource/nginx.cfg so you could fork and pull request a new file along the lines of resource/caddy.cfg.
I doubt it would get official support but it would be handy for other caddy users.


another build  issue

the last step  ./tools/build_yarn.  on the end ,all test failed ,no other error.
do-test:
[junit] TEST com.google.mr4c.nativec.ExternalAlgorithmDataSerializerTest FAILED
[junit] TEST com.google.mr4c.nativec.ExternalAlgorithmSerializerTest FAILED
[junit] TEST com.google.mr4c.nativec.ExternalDatasetSerializerTest FAILED
[junit] TEST com.google.mr4c.nativec.jna.JnaExternalEntryTest FAILED
[junit] Tests FAILED
BUILD FAILED
then  in dist directory ,no any jar package  ,how to solve?

Hello , I have the same problem when build it,do you solved it?

see reports directory check corresponding file , then found libstdc++ library calling path is error ,IT CALL wrong PATH,  USING ld_library_path has no effect , usr ln command   ,link right calling  libstdc++ file to /usr/lib64/ then no problem build ok.


Add Loli programming language

Add Loli programming language https://github.com/loli-foundation/loli
Checklist:

[x] I am adding a new language.

[ ] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

li: https://github.com/search?q=extension%3Ali+sayln&type=Code

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source:

https://github.com/loli-foundation/loli-json-parser

Sample license:

MIT

https://github.com/loli-foundation/loli/issues/10

Looks like original language is by other author:
https://github.com/FascinatedBox/lily
https://gitlab.com/FascinatedBox/lily
loli has very similar set of files and very close internal file content. Also it has very similar syntax. Very strange syntax decision if condition : { then_statement ; else: else_statement } could not be same by accident.


Radiogroup question text wordwrap in middle of words

Are you requesting a feature, reporting a bug or asking a question?
Reporting a bug
What is the current behavior?
If a radio-group question has text that extends beyond the horizontal space available, the text sometimes is wrapped breaking a word in two lines instead of wrapping between the words.
What is the expected behavior?
Word wrap between words and do not split individual words unless that single word doesn't fit on a line by itself.
How would you reproduce the current behavior (if this is a bug)?
Tested page URL: https://surveyjs.io/Examples/Library/?id=survey-quiz&platform=jQuery&theme=default
On the third question of the quiz make the browser width small enough that wrapping is required. Sometimes words are split midway and put on the next line.
Specify your

browser: Chrome
browser version: 69.0.3497.100 (Official Build) (64-bit)
surveyjs platform (angular or react or jquery or knockout or vue): jquery
surveyjs version: 1.0.50

The solution is to add a span { word-break: keep-all; } in the CSS stylesheet.

@reclaimingmytime yes I've thought about something like that too, thank you. But I need to check what side effect it will create.

I haven't noticed any after having this code in production for a few months.
Although being more precise with .sv_main span { word-break: keep-all; } instead of just span might avoid breaking other parts of the page not related to surveyjs.

Fix will be available in the next minor update


Able to download a file through SFTP

How to
Forgive me if this is pedestrian, but I cannot figure out how I can save/download a file to my phone via SFTP.
My use case:
Setting up an OpenVPN server on a Pi - I want to save the client key .ovpn file. I assumed I can do this by long press, or swipe left/right on file. But I can’t find any save/transfer option at all?

Hello @lawsonav 👋
You're right, WebSSH doesn't offer this feature yet.
It's now planned for 15.0

Ok. Super cool app still. Think I’ll end up going pro. 😅
Trying out a few ssh atm but this one is the best so far by a long way.

On 24 Oct 2020, at 20:06, Arnaud Mengus<EMAIL_ADDRESS>wrote:

Hello @lawsonav 👋
You're right, WebSSH doesn't offer this feature yet.
It's now planned for 15.0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thank you a lot for your support! 👍 😇

Similar to #113
Need to implement SFTP transfers asap

Hello 👋
I'm moving this issue to #114 in order to track all SFTP enhancements needed.
Have a nice day. ☀

I'm working on it since yesterday
Have a nice day ☀

I'm working on it since yesterday
Have a nice day ☀

[ ] Having a menu to let user download a file
[ ] Implement again folder renaming and folder deleting

Hello @lawsonav  👋
Please install WebSSH Beta from TestFlight app : https://testflight.apple.com/join/QSrBK59z
You will then be able to download WebSSH 14.10.5 with download feature.
☀ Have a nice day


Naming Convention or Naming Guide

Hey All 😄👋
I honestly think this Project is in desperate need for a naming guide/convention. With the project goal being able to provide learners far and wide a peak into the inner workings of popular used code snippets. I believe it's appropriate for the snippets to be consistent so the time spent isn't focused on finding the exact snippet they are looking for.
Example ES^~JavaScript & Lodash & Underscore Follow a type of rules That help them with categorizing and naming their methods

If the method input is a array. In regardless of the output it is categorized as an array method
-- _.join(array, [separator=',']) or .join() | _.join(['a', 'b', 'c'], '~') -> 'a~b~c'
-- _.fromPairs(pairs)  | _.fromPairs([['a', 1], ['b', 2]]) -> { 'a': 1, 'b': 2 }

As you can see even though they both return 2 different things. An Object and a String. Since they both accept array as inputs. They are categorized as Array methods
The reason I bring this up is because after a few minutes going through the snippets I realized

That more than a couple things are categorized wrongly making finding the needed snippet more harder than it needs to be

Example:
Object from key-value pairs
Use Array.reduce() to create and combine key-value pairs.
const objectFromPairs = arr => arr.reduce((a, v) => (a[v[0]] = v[1], a), {});
// objectFromPairs([['a',1],['b',2]]) -> {a: 1, b: 2}

Is categorized as an Object method / snippet. Yet it takes an arr as input and strays from the standard way of doing things. Which might be weird for other users.

And that we need to establish of a better guide to naming functions or it will become the wild wild west of snippet names. Which will take away from the value proposition we are trying to convey to the users of the project

Some of these snippet/ method names are way too long
@Chalarangelo Thoughts?

I agree that naming conventions need to be established and we need to review all snippet names retroactively, as well as new snippets that are being added. The tagging system was put into place to help solve the issue, but we need to establish guidelines on what snippets fall under each category.

@Chalarangelo Yea I agree, Although the tagging helps with snippets/methods. We also have to make sure the snippets that are tagged are tagged in the appropriate category. Yea as far as guidelines for naming I have a few ideas to date.
1. categorySnippetName.md
Note

camelCase convention with snippet starting with category
Snippet name & Fn name follow the same convention and guidelines

2. category-snippet-name.md
Note

kebab-case convention with snippet starting with category
Snippet name & Fn name follow the same convention and guidelines

I do think a naming convention is needed, however I think the category might not be needed as part of the method name, but more as part of the file name as category${serperator}title.md so that the method name in the md can be whatever makes more sense, and the file name could be used to infer grouping instead of a DB that would need constant upkeep. Now each file decides where it goes in categorization, and each method can be whatever makes sense.

@skatcat31 Adding the category in the filename will cause all sorts of problems, as contributors will have to figure out the best category for each snippet and we will have to constantly nag them about what goes where. I honestly prefer the tag database, as we can untag snippets that are incomplete or whose functionality and usefulness is debatable, so that they do not compile in the build process and we can then take the time to figure it out among ourselves.
This will also aid the testing process, when implemented, as we can just untag files that do not pass all test cases to figure out what to do with them. If we have the tag in filename, we will have to manually add an exception list to the builder for snippets that are not yet ready.
I also considered splitting the snippets into folders, but that would make things even worse. The best case scenario for categorization in my opinion is to open another issue, dedicated to discussion of categorization (or open a second channel on gitter just for naming and categorization), where we keep track of all snippets and figure out what needs to be done.
As it currently stands, I suggest the following:

Open an issue where we list all existing snippets alphabetically and start figuring out which ones are complete and sealed (as in we are not gonna alter them any further as they work perfectly fine).
Start renaming what needs to be renamed and tagging things after we discuss them (I tagged everything semi-arbitrarily yesterday), so we can agree what goes where.
Keep track of snippets that are not yet complete, need modifications and should be categorized differently.

In general, I want new contributors to sit down for 20 minutes, find something they want implemented, format a short snippet appropriately and submit a PR. We can then review the code and description, debate the usefulness and put the final touches there, such as changing the name, categorizing and setting up the tests when the time comes. This keeps the barrier of entry low and allows us to maintain the project fairly consistently without forcing new contributors to figure out our whole procedure. What do you guys say?
@darrenscerri @elderhsouza @kingdavidmartins @atomiks @skatcat31 I want your opinions!

This begs a question though... Multiple categories for a function. Should such a thing be allowed?

@skatcat31 It definitely could be. While going through all the functions I also realized that some of them can fit into multiple categories. It's personal preference though, each of us categorizes things differently in our head.
For example, I would put both Random integer in range and Random number in range into Math category since they are operating with numbers and use Math built-in object.  However, I also think that should stay at utility also.

@skatcat31 Multiple categories are a soft no in my opinion. I think we should keep functions simple enough to apply to one main situation. Yes, there are exceptions, but overall it would be better to keep everything categorized under only one category, so we don't have to deal with 90% of our functions being array-specific, string-specific and utilities at the same time.
@fejes713 I arbitrarily put those under utilities, but they might be better as math.

@Chalarangelo  You're right. Then we just need to focus on what category is best for every function.   The ones I mentioned are not the only ones that might need change. However, there's a separate issue for that I think.

Yes, we need to list the debatable ones in #159 and start organizing everything as we should.

As far as naming is concerned, I think we should switch our model to name files based on the contained function and then improve our descriptions to include the what and how of each function, so that users can see what the snippet is supposed to achieve along with how it does so. As it currently stands, it's really difficult to figure out what a few of the snippets do. Do you guys agree?

I'm closing this, let's discuss under #206 where there's a new proposal abut naming. Move categorization concerns under #159 so we can discuss that further, too.


Remove unused **kwargs arguments for various transforms.

It's better to throw an error when unexpected arguments (including misspellings
of actual arguments) are passed than to silently drop them.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @Shoaib
Just something I noticed while looing at another PR.

Run Python PreCommit


Trying to fix tests

Not sure why we mocking 'carbon.state.instrumentation' here.
It recently start to give following error:
Traceback (most recent call last):
  File "/Users/dzhdanov/git/carbon/.tox/py37/lib/python3.7/site-packages/twisted/trial/runner.py", line 531, in loadPackage
    module = modinfo.load()
  File "/Users/dzhdanov/git/carbon/.tox/py37/lib/python3.7/site-packages/twisted/python/modules.py", line 392, in load
    return self.pathEntry.pythonPath.moduleLoader(self.name)
  File "/Users/dzhdanov/git/carbon/.tox/py37/lib/python3.7/site-packages/twisted/python/reflect.py", line 308, in namedAny
    topLevelPackage = _importAndCheckStack(trialname)
  File "/Users/dzhdanov/git/carbon/.tox/py37/lib/python3.7/site-packages/twisted/python/reflect.py", line 247, in _importAndCheckStack
    return __import__(importName)
  File "/Users/dzhdanov/git/carbon/lib/carbon/tests/test_client.py", line 91, in <module>
    @patch('carbon.state.instrumentation', Mock(spec=instrumentation))
  File "/Users/dzhdanov/git/carbon/.tox/py37/lib/python3.7/site-packages/mock/mock.py", line 1084, in __init__
    _spec_state, _new_name, _new_parent, **kwargs
  File "/Users/dzhdanov/git/carbon/.tox/py37/lib/python3.7/site-packages/mock/mock.py", line 439, in __init__
    self._mock_add_spec(spec, spec_set, _spec_as_instance, _eat_self)
  File "/Users/dzhdanov/git/carbon/.tox/py37/lib/python3.7/site-packages/mock/mock.py", line 494, in _mock_add_spec
    if iscoroutinefunction(getattr(spec, attr, None)):
  File "/Users/dzhdanov/git/carbon/.tox/py37/lib/python3.7/site-packages/mock/backports.py", line 34, in iscoroutinefunction
    getattr(obj, '_is_coroutine', None) is _is_coroutine
builtins.KeyError: '_is_coroutine'

Commenting out works fine.
Did someone maybe know why that happening and how we can fix it properly?
@piotr1212 @DanCech ?

Test are green, despite I removed patching instrumentation during the test. Hmmm.

Which test fails for you. They all work here (in tox)

ah, sorry I see now they fail in travis

'carbon.state.instrumentation' is not being used at all, removing it makes sense. I think someone wanted to test whether those counters were increased when a metric is received but never got around to implementing it. This code also originates from the megacarbon branch, you might find some more info in that git history.

Cool, thanks for checking! Will merge it


Fontawesome

Hi,
I have laravel and I'm compiling the simplemde.min.js file to a main 'script.js' file  and same with the css.
I already have Font awesome in my main.css file merged with many other files including simplemde.css. But it still uses the CDN version of font-awesome.
How can I fix this?

Set the configuration variable autoDownloadFontAwesome to false, as explained in the Configuration section.


Stick Scroll sticks python function's decorator line instead of the declaration line

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.70.0
OS Version: Windows 11

Steps to Reproduce:

Enable sticky scroll
Scroll through a python function with decorator

The function:

When the view is scrolled, sticky line should show the definition instead of the decorator. This is what it's like currently:

Thank you for creating this topic. I have the same problem with all kinds of Spring Boot annotations.  One function is sometimes also annotated with multiple annotations, which should also be taken into account.

Same for PHP Docblocks:

instead of

It this issue specific to language or decorators? If yes, I'll create separate issue
"Similar" problems can be noticed in Java files where sticky scroll picks start of javadoc comment instead of class/method declarations

I don't have any issues with docblocks in JS. But apparently a lot of other langauges.

Looks like same problem with decorators is reproducible in JS/TS, but not with comments (as in Java above)

This also happens with rust doc blocks, either with the triple slash (///) or the usual doc block ( /** */)
/// All elements of the vector are set to a random number from 0 to the length of the vector (Exclusive)
/// # Example
/// ```
/// vec = shuffle(&mut vec).to_vec();
/// ```
fn shuffle(v: &mut Vec<i32>) -> Vec<i32>{
    let test = v.len() as i32;
    for i in 0..v.len() as i32 {
        v[i as usize] = rand::thread_rng().gen_range(0..test);
    }
    return v.to_vec();
}

What is interesting to note is that C++ (and very likely C) is not affected by this.

This is happening in C code where the function declarations are split over multiple lines as well:

Hi thanks for all your feedback. I will be looking into all these issues.

I am seeing this in TypeScript as well, so it looks like it is most/all languages.

This might be improved if we would have a custom sticky ranges provider. A language server might tweak the results it would return from a sticky ranges provider to exclude decorators/comments/etc. Also related https://github.com/microsoft/vscode/issues/157165

Another example for C# from 157284

When using the new Sticky Scroll with a .NET API project, scrolling in a controller will only show any attributes as the "sticky" heading - [ApiController] - [HttpPost], etc.

Hi,
Similar issue happens with AL language,
Sticky:

expected:

procedure:

Thanks for this feature!

Thank you for all the feedback. These issues should be solved with https://github.com/microsoft/vscode/pull/157763.
New behavior:

@aiday-mar This seems not to be fixed for AL as posted by @paulojcdev in https://github.com/microsoft/vscode/issues/157180#issuecomment-1209023603 some comments before you commited the fix.

Hi thanks for the feedback. Are you using an extension which provides a language server for AL? The sticky scroll depends on this. If you are, what extension are you using? I will test on my computer.

I’m on insiders. AL comes from MS and uses a language server. https://marketplace.visualstudio.com/items?itemName=ms-dynamics-smb.al

Verified, however I now run into another issue, not sure if its related though https://github.com/microsoft/vscode/issues/159118


Update fantomas to v6

This updates fantomas to v6 and adjusts the .editorconfig

Although this seems to be fine and it will most likely be just a change of names, we would like to wait for the final v6 release for this to get merged. Shouldn't be too far in the future.


update universe schema to have an optional marathon.json.mustache

We will be supporting universe packages that are cli-only.

@jsancio updated

Already merged with v3 universe model work: https://github.com/dcos/cosmos/blob/master/cosmos-model/src/main/scala/com/mesosphere/universe/v3/model/PackageDefinition.scala#L74


[cmake] Add support for external clang/clang-cl

We need an option to pass external host clang location in case we can't use just-built clang, e.g. when we are building for
different target architecture.
Also, this adds target options for clang-cl, enabling us to build for arm64 on Windows@amd64.

Resolves SR-NNNN.

cc @compnerd

@swift-ci please test

Running a build at https://dev.azure.com/compnerd/swift-build/_build/results?buildId=56346&view=results as well - just to ensure that this won't impact the nightlies/releases for the time being.

The build passed, and though the patch wasn't applied to the toolchain build, it was applied to the SDK build and that seemed to pass.  I'm going to guess that this should be fine for the compatibility.


DeviceInfo breaks Detox Tests

Summary
We are testing our app with detox and mocha (also tried jest) and noticed that our tests fail on Android. Debugging the failure suggests that importing react-native-device-info (var DeviceInfo = require('react-native-device-info') in any module) gets the test stuck in the splash screen (i.e. the initialisation phase).
Here is an example project: https://github.com/ewyso/react-native-detox-e-android/
Just uncomment https://github.com/ewyso/react-native-detox-e-android/blob/master/App.js#L17

Version
0.15.3 (other seem to have the same issue)

Affected OS
Android

OS Version
Detox Testing on Nexus_5X_API_27

Current behavior
The app works fine running in the Android simulator.
The app gets stuck in the splash screen when run from detox.
As soon as import or var DeviceInfo = require('react-native-device-info' are added. There are no visible error messages in react-native log-android or adb logcat. The debugger is not connected when running tests.
Steps to reproduce:
git clone https://github.com/ewyso/react-native-detox-e-android.git
cd react-native-detox-e-android
yarn && detox build --configuration android.emu.debug && detox test --configuration android.emu.debug -l verbose
Compare with line 17 in /App.js added / removed.
Expected behavior
Line 17 should not change the behavior of the test at all.

Hi @blumendorf, shouldn't you mock react-native-device-info in your tests?
Here's how I do that for jest:
jest.mock('react-native-device-info', () => {
  return {
    getModel: jest.fn(),
  };
});

Fair point. Will give that a try. Thanks!
I would still be interested to understand why it works when I run the app myself, but not when detox runs the app.

Because it contains native code, something detox/jest can't make up

Just documented it in the README file: https://github.com/rebeccahughes/react-native-device-info#troubleshooting
Feel free to reopen if you still facing a problem with tests :)

Not sure that I get it. The same bundle runs in the Android simulator and works fine when I "click the buttons". Jest runs the same code and connects to "click the buttons" for me. The exact same code and test (not the linked repository) works perfectly fine in iOS simulator. No mocking required.
Thanks for your help and patience.

From what I understand from https://facebook.github.io/jest/docs/en/tutorial-react-native.html#mock-native-modules-using-jestmock , jest comes with some default mocks, like buttons, which is how it works for you.
For other libraries, like this one, you need to manually mock the objects.

Hello @machour,
thank you very much for your help here. I really appreciate it!
I have tried your suggestion and it does not seem to change anything. I have been working with mobile app development and react-native for a couple of weeks only, so I might be missing something trivial here.
Let me try to explain again what I am doing:
We are running e2e test for our app using detox and jest in iOS simulator and Android emulator running locally and on our build system. We are not mocking anything in our tests (they work the same both with mocha and jest), because we are actually testing the full functionality. Our app works fine on iOS and Android, our e2e test run fine on iOS (locally and on circle ci). Running our e2e tests on the Android emulator, we only see the splash screen and then the app hangs until the test times out. Basically this happens "inside" detox.init(config). I took me some time to narrow this down to wether or not we are importing the 'react-native-device-info' module (I am not saying we don't have more issues once that is fixed though).
I added the iOS code to https://github.com/ewyso/react-native-detox-e-android and this seems to be the minimum implementation to demonstrate the issue. Once the import (line 17 in App.js) is in, ios.sim.debug still runs fine while android.emu.debug hangs with no apparent error.
Since it is the module import that makes the difference, I am not sure where to look next ...
I am happy to dig deeper into the issue (it might also be a detox/jest problem), but would appreciate any pointer where to look next.

My bad, I didn't really get that you were doing e2e tests 😄
I just cloned your project and first tried on iOS.
After building the app and running yarn e2e:ios:debug I get this and nothing happens (no logs, no test result, nothing in the simulator)

Shouldn't it be passing? (the line in App.js is still commented)

I was unable to run detox with iOS, but it worked for Android :)
I've successfully reproduced your problem and pinpointed it to this particular line.
Could you try commenting it in your node_modules/ copy and re run your test suite?

Someone seems to have faced the same problem here: https://github.com/wix/detox/issues/395#issuecomment-365593821

Removing this line brings me past the splash screen in both the react-native-detox-e-android and our project. Thanks for taking the time to look into it. I am very curious about the solution now.

No worries, I always wanted to see how e2e tests works :)
I've posted details of the problem to the detox thread I mentioned, we'll see how it goes from there.
I also had a look at the android source for WebSettings but couldn't find anything obvious explaining why the test hangs

@ghsdh3409 's answer fixed it for me.
I had to put:
androidTestImplementation 'org.mockito:mockito-android:2.7.22' to app/build.gradle
or for previous versions of gradle:
androidTestCompile 'org.mockito:mockito-android:2.7.22'
These are imports:
import android.content.Context;
import android.support.test.InstrumentationRegistry;
import android.webkit.WebSettings;
import static org.mockito.Mockito.*;

And at the end, I have put @ghsdh3409 's code in DetoxTest.java from androidTest directory.
(For those lazy like me, so that you don't have to look for your correct imports yourself :) )

Many thanks to both of you!
@blumendorf, could you try the proposed solutions and update us here?


Enable bot HTML artifacts comment on PRs from fork

Follow-up to #4548 and #4564
As it turns out, when PRs are coming from a fork, the GITHUB_TOKEN has read-only permission, so the actions added in #4564 cannot create a comment. I've disabled this for PRs coming from a fork in #4573, otherwise we get a failure.
We should now look into solutions to make it work with PRs from forks. It looks like there is a Send write tokens to workflows from pull requests setting at the repo level: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#changing-the-permissions-in-a-forked-repository. After enabling that, we might be able to then limit the write access to PRs only (creating/modifying comments on PRs) to avoid giving write access to everything: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#setting-the-github_token-permissions-for-a-specific-job.

Once this has been fixed, we can proceed with documenting #4564 in #4572

@clalancette what do you think?

@clalancette what do you think?

I'm a little leery of forwarding write tokens; that seems like opening up a security hole.  But I'm not all that familiar with these things.  @nuclearsandwich , any thoughts?

We can probably limit the scope to PRs only: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#defining-access-for-the-github_token-permissions. And for new contributors we still need to manually approve/trigger workflows.

I'm a little leery of forwarding write tokens; that seems like opening up a security hole. But I'm not all that familiar with these things. @nuclearsandwich , any thoughts?

This is worth discussing in an Infrastructure PMC meeting. One of the major problems with GitHub Actions workflows being defined in-repository is that it prevents us from using fully trusted workflows on untrusted code since the untrusted code can just... change the workflow.
I don't even really know how to create an in-workflow write ^ execute pattern on workflow files since an attacker modifying the workflow could also remove the write ^ execute guard along with their modified payload.

And for new contributors we still need to manually approve/trigger workflows.

The human is the faulty machine in this step since not every reviewer is paying equal attention. If there was an automated way for a default branch action to approve workflow execution for PRs that do not modify workflow files then that would be an attractive solution. However, once approved it's possible to modify a PR to edit workflow files and since it only takes one repeat contribution to get on the trusted list, attacks that involve sending an innocuous PR before the ..nocuous? noxious! PR is submitted later.


Add negative e2e tests for pubsub

Add publish without topic e2e
Add pubsub e2e for redelivery on error from subscriber
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1808
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-test

https://github.com/dapr/dapr/runs/1235556931?check_suite_focus=true#step:13:30
E2E tests failed in windows due to not being able to deploy Dapr which is unrelated to this change.


Use the submodule commit as the test data cache key

Description of work:
Check all that apply:

[ ] added release notes
(if not, provide an explanation in the work description)
[ ] updated documentation
[ ] Source added/refactored
[ ] Added unit tests
[ ] Added integration tests

References:

Links to IBM EWM items:
Links to related issues or pull requests:

Manual test for the reviewer
(instructions to set up the environment)
Check list for the reviewer

[ ] release notes updated,
or an explanation is provided as to why release notes are unnecessary
[ ] best software practices

[ ] clearly named variables (better to be verbose in variable names)
[ ] code comments explaining the intent of code blocks

[ ] All the tests are passing
[ ] The documentation is up to date
[ ] code comments added when explaining intent

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.74%. Comparing base (6751a4d) to head (eb2b27e).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #113   +/-   ##
=======================================
  Coverage   60.74%   60.74%
=======================================
  Files          33       33
  Lines        6535     6535
=======================================
  Hits         3970     3970
  Misses       2565     2565

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Windows CI always builds llvm-project

It appears that Windows CI is failing to find the cached and therefore always rebuilds llvm-project. This makes the build take almost 4 hours to finish.
2023-09-05T18:03:37.0764952Z ##[section]Starting: Check for mlir artifact
2023-09-05T18:03:37.0873571Z ==============================================================================
2023-09-05T18:03:37.0873717Z Task         : PowerShell
2023-09-05T18:03:37.0873784Z Description  : Run a PowerShell script on Linux, macOS, or Windows
2023-09-05T18:03:37.0873895Z Version      : 2.226.2
2023-09-05T18:03:37.0873963Z Author       : Microsoft Corporation
2023-09-05T18:03:37.0874041Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/powershell
2023-09-05T18:03:37.0874145Z ==============================================================================
2023-09-05T18:03:38.0697494Z Generating script.
2023-09-05T18:03:38.1116486Z ========================== Starting Command Output ===========================
2023-09-05T18:03:38.1356537Z ##[command]"C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command ". 'D:\a\_temp\c6201e30-a2ee-4f59-abe5-3fd607debe63.ps1'"
2023-09-05T18:04:53.7329503Z Found build NotFound containing artifact MLIR_Windows_91088978d712cd7b33610c59f69d87d5a39e3113
2023-09-05T18:04:53.8304662Z ##[section]Finishing: Check for mlir artifact

@MikeHolman will you or some other Microsoft folk be able to take a look at this? Thanks.

@jcwchen, can you take a look at this?

It seems that this not found issue happened occasionally somehow? I did see there are few newer commits did find the cached artifact.

Yes it does seem that the problem has gone away. Thanks for looking into it. We will keep an eye on it.

@jcwchen @MikeHolman any chance you can add some cores to the Windows build bot? it's generally the slowest of the CI pipelines and slows down the pace at which we can merge PRs and, moreover, LLVM uplift PRs like #2504 which need to rebuild llvm-project often time out because they can't get it done in within the 4h time limit (that PR has timed out twice already)
fwiw, the Windows build bot is much slower than my laptop, I can build llvm-project and onnx-mlir in less than 1h, so I think it would become a lot faster with more cores

@jcwchen @MikeHolman any chance you can add some cores to the Windows build bot? it's generally the slowest of the CI > pipelines and slows down the pace at which we can merge PRs and, moreover, LLVM uplift PRs like > https://github.com/onnx/onnx-mlir/pull/2504 which need to rebuild llvm-project often time out because they can't get it done > in within the 4h time limit (that PR has timed out twice already)

fwiw, the Windows build bot is much slower than my laptop, I can build llvm-project and onnx-mlir in less than 1h, so I think > it would become a lot faster with more cores

It seems to me the hardware settings for Microsoft-hosted agents are fixed (Microsoft-hosted agents that run Windows and Linux images are provisioned on Azure general purpose virtual machines with a 2 core CPU, 7 GB of RAM, and 14 GB of SSD disk space.): https://learn.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml#hardware, and I also cannot find a way to increase the cores from my end.
For now, general PRs will use cached built LLVM, but as you mentioned, PRs for LLVM bump will need to build newer LLVM from source, which take much more time... A quick workaround would be extending the timeout number here with a reasonable number: https://github.com/onnx/onnx-mlir/blob/3b71a60079c6b1b2c8803c116ef710ffa315aaa3/.azure-pipelines/Windows-CI.yml#L14. In addition, perhaps we can try windows-2022 instead of windows-2019. Sometimes newer machines would be just faster.
A permanent solution should be hosting a "Self-hosted Windows agents" instead, but it will require more engineering cost and budget (with a more powerful CPU).
BTW, I have considered the option to move Windows CI from Azurepipelines into GitHub action, but actually Action also simply provides 2-core CPU (x86_64), 7 GB of RAM, 14 GB of SSD space for Windows: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources. Thus probably the same issue will happen there.

thank you for looking into this
I applied your advice in PR #2511


Create a basic HTML page for testing

I had planned to not do any kind of frontend development for this, but it's getting to be a bit of a pain for testing. A bare-bones HTML page with basic JavaScript will make this a bit easier.

Done. It now allows me to get, add or disable employees (mark them as no longer employed). I can also add new & retrieve sites or projects.


Easily select all implemented markets in python

I don't have the reliable method to select implemented APIs in python.
Suggestion: Can you implement function/constant which returns all available APIs. Something like:
import ccxt
ccxt.available_APIs()
# Returns ['kraken', 'gdax', ...
# Then this should work
eval('ccxt.kraken()')  # This gives me kraken API implementation from ccxt

Btw, your python module is missing __all__ marker which modules should be imported with * import.
https://docs.python.org/3/tutorial/modules.html#importing-from-a-package

Yes, I will add such a function and the import marker as well! Will be ready soon.
Thank you for feedback!

That feature will be documented soon.

Awesome, thank you!


Replace hardcoded path in ManOpen formula?

Hello,
I observed that current formula for ManOpen (manopen.rb) is finishing with:
artifact 'openman.1', target: '/usr/local/share/man/man1/openman.1'
Is it better to decide to put systematically this man page there, or instead to follow HOMEBREW_PREFIX that could turn out to be different from /usr/local for some users, like jtool.rb does?
artifact 'openman.1', target: "#{HOMEBREW_PREFIX}/share/man/man1/openman.1"
P.S. It appears that currently, more formulae use hard-coded path like manopen.rb than variable-based like jtool.rb

Small nitpick. They’re casks, not formulae. They’re different and behave differently, and when you mention the latter rather than the former, it makes me think you’re in the wrong repo reporting a bug over something that isn’t related to us.
As for your question, yes, they should be variable-based. Care to submit a PR?

Small nitpick. They’re casks, not formulae.

Arg, my mistake: confused by using more frequently brew than brew cask ;-)

they should be variable-based. Care to submit a PR?

OK, I can do my best to prepare it ASAP.

@miccal, many thanks for this really fast commit updating manopen.rb
I thought that @vitorgalvao was speaking of "all the casks" with this common modification when writing "they souble be variable-based. Care to submit a PR?"
I'm likely to prepare it (as a whole or separately) for the following casks in the next few days:
cargo.rb:  artifact "#{Utils.distname}/cargo/share/man/man1/cargo.1", target: '/usr/local/share/man/man1/cargo.1'
cmucl.rb:  artifact 'lib/cmucl', target: '/usr/local/lib/cmucl'
jad.rb:  artifact 'jad.1', target: '/usr/local/share/man/man1/jad.1'
ncar-ncl.rb:  artifact 'include', target: '/usr/local/ncl-6.3.0/include'
rar.rb: ...

Yes, I meant all of them.


[fix] There is no end judgment when parse ip addr

In this parser, lwespi_parse_number is read up to the delimiter. However, since the end judgment is forgotten, the next character is ignored.
e.g.
<IP_ADDRESS>,33:44:55:66:77:88:99
-> 3:44:55:66: 77: 88: 99
google transrate

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.