chore: fix azp caching

Related Issues/PRs

#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?

[ ] I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

[ ] No. You can skip this section.
[ ] Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

[ ] No. You can skip this section.
[ ] Yes. Make sure you have added samples following below steps.

Find the corresponding markdown file for your new feature in website/docs/documentation folder.
Make sure you choose the correct class estimators/transformers and namespace.
Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
Make sure the DocTable points to correct API link.
Navigate to website folder, and run yarn run start to make sure the website renders correctly.
Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
Make sure the WebsiteSamplesTests job pass in the pipeline.

/azp run

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 5.17%. Comparing base (72f99c8) to head (4659149).

:exclamation:  There is a different number of reports uploaded between BASE (72f99c8) and HEAD (4659149). Click for more details.
HEAD has 149 uploads less than BASE

Flag
BASE (72f99c8)
HEAD (4659149)

151
2

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #2263       +/-   ##
==========================================
- Coverage   83.20%   5.17%   -78.04%
==========================================
  Files         327     327
  Lines       16775   16775
  Branches     1499    1499
==========================================
- Hits        13958     868    -13090
- Misses       2817   15907    +13090

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/azp run

/azp run


Remove network_userid from event_fingerprint algorithm

Based on testing the new algorithm, I believe network_userid is one of the parameters used to feed it i.e. two events that are identical apart from having different collector_tstamp and network_userid values have different event_fingerprint values. I am sure that collector_tstamp is not included in the algorithm, which leads me to suspect that network_userid is.
I don't believe network_userid should be included - this value is appended to the data by the collector. For a single event that happens to be sent twice from the JS tracker to the Clojure collector on a computer that does not accept third party cookies, wouldn't the network_userid value change with both sends?
Does that make sense @fblundun @alexanderdean ?

@yalisassoon - yes indeed, nuid is currently being used. Your explanation of why we should exclude it makes perfect sense - I am updating the release and blog post to exclude nuid...

Removed from the example config, closing...

Well spotted - I forgot that the collector adds some parameters.
https://github.com/snowplow/snowplow/blob/master/2-collectors/clojure-collector/java-servlet/war-resources/.ebextensions/server.xml#L138
Should we also disable cv to prevent the collector version affecting the fingerprint?

Agree, let's disable cv. I've added this to the blog post... @fblundun please update the example JSON config and rebase...

Done!

Thanks!


looser M8 check

This should resolve #3 on more devices.
On mac x86_64, I still don't get sound, but it does start and seem to work (which it didn't before.)
I can open quicktime player, and do an audio-recording (no need to record, just turn up monitor volume) and get output though, so it's at same feature-level as m8c on mac.

I merged this in #7


Fixes #552 set focus into details dialog

This pull request is Finalized
Related issue(s) and/or pull request(s)
This is related to but does not rely on #553 so can be applied before or after #553
Set focus onto the close icon in upper right
of the book details dialog when it is opened.
Test by opening the details dialog from the library view. Shortly after the dialog is visible, focus should be set to the close icon in the upper right corner.

@danielweck I am fine with this change.  If you agree, please merge.


Public Contributions to Dolphin

We need a separate repository outside of Dolphin to store third party contributions.
All Contributions that are in this repository under Core should be loaded into one of the boot images and pass all (forthcoming) build tests. There may be special cases (like tests or examples, maybe) where packages that are intimately tied to the Dolphin/Core/Contributions packages may not get loaded, but these should be the exception.
All public contributions (for the time being at least) should be added to Dolphin/Contributions which are held in a separate repository.

I was thinking about this. Currently we have all contributed packages in one repo.

We need to split this in "one repo per package" so updating one doesn't affect others and you can build your own dependency configuration for packages and use your own forked version.
A dolphin native way to specify a github repo as a package source (with the option for an specific revision)
As above for package dependencies in package definition
A way to discover available packages in github
A github client, maybe some kind of unzip tool
Integrate this new tools in the package manager

What do you think?

It sounds like a good solution, but quite an ambitious one. There are a lot of pieces needed to make that hang together, and some of them sound non-trivial. Is an incremental plan possible that allows it to be delivered over time?

Yes, maybe a proof of concept prototype first in order to know how this work should be accomplished and what are the requirements. I'm leaving on vacation this weekend for a month so this will not start right now.

What do you think about changing the Dolphin packages organisation or at least how packages are lookup? Currently we need to know the exact path to the package making package refactorings hard and easy to broke automatic or manual prerequisites. It would be easier to keep all packages in one root directory, each one in a folder, inside a readme.txt with description about it's contents easing the implementation of #219 .
This is someway ruby gems works, and others like node or nuget. The difference is that they have a central repo and I think that we don't need it for now and github is enough. We can label versions by tag or commit sha so we can download the exact version we want. The version could be appended to the folder's name for example, in ruby there is a gem devise-4.2, we could do the same.

I'm not sure I like the idea of losing the package folder hierarchy in favour of a big flat list.
In any case packages are expected to have a unique name, and are only looked up by that once loaded. The relative path of package prerequisites is used to find them on disk. If you wanted to store extension packages directly in immediate subdirectories of a common folder without any additional hierarchy, you could achieve that without removing the folder hierarchy in general. I don't think one would want to have all the base system packages spread across different repos as it would be too inconvenient to manage. I suppose the same applies to any other group of packages that you want to treat as a composite from a version management perspective.

@fxgallego, I wonder if git submodules might not be the basis of a fairly simple and powerful solution to this. Certainly this would be a better way of including contributions that are required in the base image, as it would allow them to be managed in a separate repo with a clean mechanism for upgrading to new versions in the Contributions repo. It could make one repo per package feasible, also allowing for integration repos that reference a bunch of other packages. Versioning and managing version dependencies  (like diamond dependencies) is a tricky problem, but I can't help thinking YAGNI on that given the small community. One central contributions repo that refs all the others might be good enough, sidesteps versioning issues by having a global version that encompasses the individual versions of everything, and can make the packages discoverable (especially if #219 were done). Overall this might provide a workable solution. Certainly an incremental improvement on what is there now. Yes the versioning might not scale, but I don't see the need to solve that immediately.

@blairmcg, sorry for the delay. I'd like to give the configuration power to the application developer (but in the end it will be useful for Dolphin development too). Some use cases:

Development image build: By now we solve this by having a pre-build image we call it "base image". This is built from the Dolphin's development image + community packages not included by default.
Share patches to community packages
Ensure a consistent baseline trough package versions. Maybe this is the hard one if you want to automatically solve dependencies between several packages.
Build runtime images by specification in opposition to shrink.

I can start with something really simple and without breaking any of the Dolphin's packages functionality, only enhancements, so we can have a better idea where I'm going. If you don't like it, no problem, we can throw it and do something else.

@blairmcg I was thinking what things I do prefer to invest my time and I will test git submodules, as you pointed out :). So I'm curious about the contributions folder (Core\Contributions) that's present in the current build. Would you replace that and start using the contents of the contributions repository once it's organized?
For example, I want to write some tests using a mocking package that in the future could be easily loaded from the contributions repo, but my code lives in Core\contributions. It's confusing to me.

I think the current arrangement is just what was expedient. This was a place to put some pre-existing 3rd party contributions that were to be loaded into the base image. Given a better way of sharing and loading packages I would think most of it would be extracted, even if we decided to keep some of it in the base image. There may be some packages that might need to remain in order to enable the boot (the aforementioned packaging system being an example). I think we would try and externalise as much as possible though.
I think you said elsewhere that you think the STS stuff should be unloaded. I agree with that, but then I don't use it myself. I'm not sure whether anyone else does now, but in any case it doesn't fit well with a GitHub based sharing model (or at least, it is not obvious to me how it does). There are also a number of other components that I've noticed don't have any tests and don't actually work any more (the http client is one).

I was testing the git submodules and think that would do the job fine for now that Dolphin Smalltalk isn't in the top 10 of tiobe index. Using a git gui client like SourceTree helps a lot working with it.
I think that we could have one repo/submodule by contributor. The main contributions repo should include a readme.md with instructions for clone and contribute. Contributions can contain any license with the exception of contributions that are keep in Core\Contributions that should be MIT (it should be reduced the minimum that makes Dolphin PRO boot)
A submodule can refer to any github repo but there are some packages that now are like a sort of abandonware and hence I think they should be keep under the umbrella of dolphinsmalltalk/. @blairmcg do you agree to add , for example, "Chris-Uppal" as project under dolphinsmalltalk/?
I'll ask other contributors to own their packages or give control to dolphinsmalltalk but guess that some are unreachable.

Yes, I agree with all of that.

Although this is a useful thing to do, it is a large effort and largely independent of the core repository.


530 From/Sender name is not valid

Hi,
I have configured postal on a linode machine and from command line I am able to send the test message but unable to send it using SMTP credentials. It always gives me 530 From/Sender name is not valid. Tried searching here without any luck.

Postal Status
`Procodile Version   1.0.23
Application Root    /opt/postal/app
Supervisor PID      2326
Started             2019-08-03 20:01:51 +0000
|| web
|| Quantity            1
|| Command             bundle exec puma -C config/puma.rb
|| Respawning          5 every 3600 seconds
|| Restart mode        usr1
|| Log path            none specified
|| Address/Port        none
|| => web.1            Running      03/08/2019   pid:2332     respawns:0      port:-        tag:-
|| worker
|| Quantity            1
|| Command             bundle exec ruby script/worker.rb
|| Respawning          5 every 3600 seconds
|| Restart mode        start-term
|| Log path            none specified
|| Address/Port        none
|| => worker.5         Running      22:54        pid:3634     respawns:0      port:-        tag:-
|| cron
|| Quantity            1
|| Command             bundle exec rake postal:cron
|| Respawning          5 every 3600 seconds
|| Restart mode        term-start
|| Log path            none specified
|| Address/Port        none
|| => cron.5           Running      22:54        pid:3645     respawns:0      port:-        tag:-
|| smtp
|| Quantity            1
|| Command             bundle exec rake postal:smtp_server
|| Respawning          5 every 3600 seconds
|| Restart mode        usr1
|| Log path            none specified
|| Address/Port        none
|| => smtp.1           Running      22:55        pid:3637     respawns:0      port:-        tag:-
|| requeuer
|| Quantity            1
|| Command             bundle exec rake postal:requeuer
|| Respawning          5 every 3600 seconds
|| Restart mode        term-start
|| Log path            none specified
|| Address/Port        none
|| => requeuer.5       Running      22:54        pid:3644     respawns:0      port:-        tag:-`
netstat -lnp
Active Internet connections (only servers) Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name tcp        0      0 <IP_ADDRESS>:5000          <IP_ADDRESS>:*               LISTEN      2332/[postal] web.1 tcp        0      0 <IP_ADDRESS>:25672           <IP_ADDRESS>:*               LISTEN      22569/beam tcp        0      0 <IP_ADDRESS>:3306          <IP_ADDRESS>:*               LISTEN      23431/mysqld tcp        0      0 <IP_ADDRESS>:783           <IP_ADDRESS>:*               LISTEN      22255/perl tcp        0      0 <IP_ADDRESS>:80              <IP_ADDRESS>:*               LISTEN      2366/nginx: worker tcp        0      0 <IP_ADDRESS>:4369            <IP_ADDRESS>:*               LISTEN      22648/epmd tcp        0      0 <IP_ADDRESS>:22              <IP_ADDRESS>:*               LISTEN      1396/sshd tcp        0      0 <IP_ADDRESS>:443             <IP_ADDRESS>:*               LISTEN      2366/nginx: worker tcp6       0      0 :::5672                 :::*                    LISTEN      22569/beam tcp6       0      0 ::1:783                 :::*                    LISTEN      22255/perl tcp6       0      0 :::80                   :::*                    LISTEN      2366/nginx: worker tcp6       0      0 :::4369                 :::*                    LISTEN      22648/epmd tcp6       0      0 :::22                   :::*                    LISTEN      1396/sshd tcp6       0      0 :::25                   :::*                    LISTEN      3637/[postal] smtp. tcp6       0      0 :::443                  :::*                    LISTEN      2366/nginx: worker udp        0      0 <IP_ADDRESS>:15241           <IP_ADDRESS>:*                           2332/[postal] web.1 Active UNIX domain sockets (only servers) Proto RefCnt Flags       Type       State         I-Node   PID/Program name    Path unix  2      [ ACC ]     STREAM     LISTENING     15904    1425/systemd        /run/user/0/systemd/private unix  2      [ ACC ]     SEQPACKET  LISTENING     9705     1/systemd           /run/udev/control unix  2      [ ACC ]     STREAM     LISTENING     12540    1/systemd           /var/run/dbus/system_bus_socket unix  2      [ ACC ]     STREAM     LISTENING     23909    1/systemd           /run/snapd-snap.socket unix  2      [ ACC ]     STREAM     LISTENING     12553    1/systemd           /run/acpid.socket unix  2      [ ACC ]     STREAM     LISTENING     12530    1/systemd           /var/lib/lxd/unix.socket unix  2      [ ACC ]     STREAM     LISTENING     19799    1/systemd           /run/systemd/private unix  2      [ ACC ]     STREAM     LISTENING     23908    1/systemd           /run/snapd.socket unix  2      [ ACC ]     STREAM     LISTENING     46728    23431/mysqld        /var/run/mysqld/mysqld.sock unix  2      [ ACC ]     STREAM     LISTENING     9695     1/systemd           /run/lvm/lvmpolld.socket unix  2      [ ACC ]     STREAM     LISTENING     9706     1/systemd           /run/systemd/fsck.progress unix  2      [ ACC ]     STREAM     LISTENING     9707     1/systemd           /run/lvm/lvmetad.socket unix  2      [ ACC ]     STREAM     LISTENING     9709     1/systemd           /run/systemd/journal/stdout unix  2      [ ACC ]     STREAM     LISTENING     14131    1197/iscsid         @ISCSIADM_ABSTRACT_NAMESPACE unix  2      [ ACC ]     STREAM     LISTENING     53286    2326/app)           /tmp/postal/pids/procodile.sock

Which credentials are you using?  Your local one or one from the UI?  also what port are you trying to operating on?

I generated the credentials from https://domain.tld/org/first-org/servers/postal/help/outgoing page. My username is first-org/postal and a randomly generated password. I am using port 25 since port 2525 is not working (I believe it is closed in iptables)

I am able to send test email from terminal.
postal test-app-smtp<EMAIL_ADDRESS>Message has been sent successfully.

The error message means that the "From" email address you are using does not include a domain which has been added to the Postal server that has the credential on it.
Either you haven't added the domain or there is a minor coding problem. See #728 for a similar situation.

The error message means that the "From" email address you are using does not include a domain which has been added to the Postal server that has the credential on it.
Either you haven't added the domain or there is a minor coding problem. See #728 for a similar situation.

I tried it on a subdomain of same domain name as well as a different domain. Same error on both installations of my marketing software

Does the domain name match what is listed on the Domains page in Postal?
It might also be that your marketing software is using the Sender header so you could try turning that on in the settings.

yes, the root domain is same. (postal is configured on mail.domain.tld and interspire email marketer on email.domain.tld). I am using interspire email marketer

The root domain may be the same but I think you need to add both mail.domain.tld and email.domain.tld to Postal.

Can't we bypass this? Because this thing kills the purpose of SMTP server

Not without numerous changes throughout the code.
Also Postal requiring the domains to be added to it helps guarantee delivery by testing the DNS records that the recipients email server will use to verify the mail it receives from Postal.
If you want a more accepting email sending server, you should look at something more traditional like Postfix or Exim but those will require more effort to set up than adding two domains to Postal.

The same domain has been added and DNS configured properly but it is still generating the same error.

The cause of that error is simply that the credential you are using doesn't match the domains.
If you've added all the subdomains you're using into the same Postal organisation or server as the credential then it should be working. There is no other cause.

Make sure you specify From: address in your email correctly. I had similar troubles when sending from python code using smtplib.

I believe this check can be disabled. There is a "send as any" option somewhere.

Indeed it seems that the "Send As Any" option doesn't make any difference.
Whether it's enabled or disabled, unless you have added the sending domains to the domains list, you will get the "530 From/Sender name is not valid".
I'm trying to setup Postal as a smarthost/relay for cPanel servers (they run Exim), and "Send As Any" has no effect. Adding all domains of several shared hosting servers is clearly not possible, so the "Send As Any" option should have done the trick in such cases, but it's not working as expected.

Thank you for testing. We can check this and confirm whether there's a bug here.

Great thanks. Let me share my use case just fyi.
I'm trying to use Postal as an SMTP relay for my own cPanel servers. I'm using services like MailChannels or SpamExperts Outbound in the same manner. To configure cPanel's Exim to relay all email through the relay/smarthost I use the standard configuration entries that works on both devices mentioned earlier. Sample configurations can be found here:
https://mailchannels.zendesk.com/hc/en-us/articles/200262710-Setting-up-for-cPanel
https://documentation.solarwindsmsp.com/spamexperts/documentation/Content/B_Admin Level/outgoing-filtering/cpanel-whm-user-auth.htm
Using the above examples, I've configured a cPanel server to relay mail through a test Postal server I've setup. I changed client_send and route_list entries accordingly, setup an Organization and a Mailserver in Postal, and went into one of the cPanel server's domains webmail to send a test email.
First attempt got me a "530 From/Sender name is not valid" mail delivery error. I googled a bit, found about the "Send As Any" option, went to Settings > Advanced Settings and set "Allow Sender Header" to Yes - Can Use Sender header (which also changed the "Send As Any" option in Settings > Server Settings to "Enabled"), saved and tried again. Same "530 From/Sender name is not valid" mail delivery error.
Then I went to Domains, added the domain from which I was sending from and tried again. Mail went through without an issue!
Then I switched "Allow Sender Header" to No (which changed "Send As Any" to Disabled) and tried again. Again, the email went through without an issue. Then I tried from a different domain's webmail (same cPanel server obviously), again "530 From/Sender name is not valid". Re-enabled "Allow Sender Header" so that "Send As Any" gets Enabled, again, same "530 From/Sender name is not valid" error. Once I added that second domain to the Domains list, email went through. Again, whether "Send As Any" was Enabled or Disabled didn't matter as long as the Domain was in the list.
So my Exim configuration looked fine since I managed to get some mail sent through Postal, however, regardless of the "Allow Sender Header" and "Send As Any" configuration (Yes/No, Enabled/Disabled), email would not get through unless I added the domain from which I was sending, to the Domains list in the Mailserver in Postal.
Expected result: to be able to send from whatever domain is hosted on the cPanel server without having to add it to the "Domains" list, when the "Send As Any" option is set to Enabled.

Have you tried adding the "Sender" header to the message?
If using the /send/message API:
from<EMAIL_ADDRESS>sender<EMAIL_ADDRESS>to<EMAIL_ADDRESS>Or if using the /send/raw API:
mail_from<EMAIL_ADDRESS>rcpt_to<EMAIL_ADDRESS>data: base64 encoded raw message that includes BOTH the from header (can be @anydomain.com) and the sender header<EMAIL_ADDRESS>SPF checks the mail_from aka "envelope from" so that has to be yourdomain.com. With the raw API you set the mail_from directly, with the message API Postal uses the sender you pass in as the mail_from.

Hmm, quick and dirty fix what seems to be working (checks the ip and if it's not in IP-SMTP it does not authorize).
         @credential = Credential.where(:type => 'SMTP-IP').all.sort_by { |c| c.ipaddr || 0 }.reverse.find do |credential|
Seems that the ipaddr library included on default ruby does not need that prefix option becouse the prefix is in x.x.x.x/y format in database so ipaddr.include knows howto compare it. (maybe i didnt do full debug)

Hmm, quick and dirty fix what seems to be working (checks the ip and if it's not in IP-SMTP it does not authorize).
         @credential = Credential.where(:type => 'SMTP-IP').all.sort_by { |c| c.ipaddr || 0 }.reverse.find do |credential|
Seems that the ipaddr library included on default ruby does not need that prefix option becouse the prefix is in x.x.x.x/y format in database so ipaddr.include knows howto compare it. (maybe i didnt do full debug)


bug-fix: 9575461 - IsConcatSpreadable is called twice

looks good to me.

@akroshg Thanks for the review


Include CentOS string check for platform

Fix for issue #273
Signed-off-by: Rajat Chopra<EMAIL_ADDRESS>

@shettyg PTAL


Code format

Hi Nat,
I've adapted the format a bit.
My basic points:

indentation 4, Spaces for TABs
enlarged maximal line width (80 is anachronistic)
preserve line breaks
do not format comments

I've also exported the "organize imports" settings and applied format and imports to the whole code base.
Please have a look.
If you like it please merge this branch and afterwards we should point every contributor to our code.
So in the future it's my hope, that we can restrict changes on the code to real changes and not format changes.

Done thanks


incorrect download info

Hi. I had a problem following your instructions to download the time picker to my project. It would be really helpful if you could change download info in your readme from 'com.akexorcist:snaptimepicker:1.0.0' to 'com.akexorcist:snap-time-picker:1.0.0'. Thank you.

Fixed! Thank you for your feedback.


🔥 Removing construct_client_dict by Fixing APIObject client attribute

Please run black on the files changed. I can tell you did not
Are you sure you want me to run black on 72 files?


RFC: give linters access to all the syntax up to the current command

Proposal

User Experience: How does this feature improve the user experience?
Working with linters, I often would like to access the whole syntax structure of the module until the current position.
For instance, this would make identifying the first non-import command easy (mathlib's Header linter would use this to check that every file starts with a module doc -- see in particular this workaround).
For another example, mathlib's MinImports linter progressively accumulates minimum import requirements helping to split large files and reduce unnecessary import dependencies (see this brittle use of an IO.Ref to try to emulate a "linter memory", mathlib's PR mathlib4#18914 and the associated Zulip thread).

Beneficiaries: Which Lean users and projects benefit most from this feature/change?
As argued above, Mathlib would have immediate use of this feature.

Maintainability: Will this change streamline code maintenance or simplify its structure?
I am not sure about maintainability.  I am aware of efforts to make elaboration of files no longer linear, and I imagine that this may cause problems at the time of passing the module syntax up to a given point reliably.

Community Feedback
Besides the Zulip thread mentioned above, this had already come up on Zulip here.
Impact
Add :+1: to issues you consider important. If others benefit from the changes in this proposal being added, please ask them to add :+1: to it.

Likely this should be done by giving linters access to the entire snapshot tree; they are closer to language server request handlers than elaborators anyway.

RFC accepted!

Wonderful!  This is great!

Also, I am not really sure how I could help, but I am happy to be of any assistance, e.g. by trying out potential solutions in some test cases that I have!


Android Basics: Fragments Navigation component

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-fragments-navigation-component
In which task and step of the codelab can this issue be found?
The end
Describe the problem
App crashes.
Steps to reproduce?

Follow all the steps.
Compare file-by-file that source code matches the solution source code
Still won't run.

Versions
Android Studio version: 4.2.2
API version of the emulator:
Additional information
I followed the tasks from the start up to now. Following the instructions, I've written the Words App from scratch and used my version to continue this lesson. I have gone over the steps about a dozen times. I used BBedit to compare the folders and files of the provided solution code to my code. They are identical, except for comments and white-space.
When I run my code, the error message that appears is in MainActivity.kit, the last line in onCreate: setupActionBarWithNavController.
When I look at navController, it's not null, but the mgraph property inside is null. That causes the crash.
When I run the provided solution code, navController.mgraph is not null.
Why?

Comparing the two runs, and looking at navHostFragment.navController, there are three differences:
mBackStack = 2 for the provided solution code, but = 0 for the code I wrote following the instructions.
mGraph has a value vs. mGraph is null
mInflater has a value vs. mInflater is null

I found the typo. I had:
xmlns:app="http://schemas.android.com.apk/res-auto"

instead of
xmlns:app="http://schemas.android.com/apk/res-auto"

Sorry to bother you.


Stack Status: more details

Currently, the stack status is very limited in term of information it brings (just the reconciliation phase an a single error message)
We'd like to show more informations there:

Details about each service:

Link to every created child resource
Copy of Child Resources status

Scale information (similar to the scale subresource)
TBD

scale +1

Hi! Thanks for your feedback. Unfortunately we're no longer maintaining this repository so I will close this issue.


coursier: 1.1.0-M14-6 -> 2.0.0-RC3-3

Motivation for this change
Update coursier (https://github.com/coursier/coursier/) to 2.0.0-RC3-3 and also install the zsh completion.  The fetching of the completion is not that nice, so please suggest alternatives if there are any better ways to do this.  (Note I can't build the whole coursier from src because it's a Scala Project)
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @adelbertc @NeQuissimus

thx!


Camera Rig is not being setup from a new UPM project

XRTK - Mixed Reality Toolkit Bug Report
Describe the bug
XRTK is meant to pick the appropriate camera rig from the available camera systems based on the currently running / edited platform, however, in the current release, this seems to be not working in a new UPM project.
When testing from development, this works as expected and the rig is setup for all platforms.
To Reproduce

Create a new Project
Import XRTK, SDK, Oculus
Ensure all XR/XRTK settings are correct
Create a new Scene
Use "Mixed Reality Toolkit -> Configure"

Expected behavior
The Camera rig should be initialized and controllers should appear when run
Actual behavior
Rig is undefined and when run, no controllers appear, as well as several errors related to Gaze and others.
Screenshots

Your Setup

Operation System:

[X] Windows
[ ] MacOs
[ ] Linux
[ ] Other

Unity Version:  2019.4.22f
XRTK Packages

[X] com.xrtk.core 0.2.3
[X] com.xrtk.sdk 0.2.3

Additional context

Issue identified this was caused to the SDK pointing to an older version of Core which obviously has an issue with system/platform use.


Update 2-WRITING.md

Version(s) of document impacted

[ ] Impacts 6.next document
[ ] Impacts 6 document
[ ] Impacts 5.1 document
[ ] Impacts 5.0 document
[ ] Impacts 4.0 document
[ ] Impacts 3.0 document

Reason(s) for not updating all version of documents

[ ] The documented feature was introduced in version (list version here) of PowerShell
[ ] This issue only shows up in version (list version(s) here) of the document
[ ] This PR partially fixes the issue, and issue # tracks the remaining work

Docs Build status updates of commit dede79f:
:clock10: Pending: waiting for processors (24 builds ahead of you)
:warning: Docs Build is busy, currently there are 24 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit dede79f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

contributing/2-WRITING.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update version of foucs-trap-react used in terra-overlay

Feature Request
Description
New major version of focus-trap-react is available. We should look into updating this dependency.

Resolved


config loaded debug statement logs secrets

Expected: no secrets from opentdf.yaml should be logged
Actual:
time=2024-05-06T14:22:09.179-04:00 level=DEBUG msg="config loaded" config="&{DB:{Host:localhost Port:5432 Database:opentdf User:postgres Password:changeme RunMigrations:true SSLMode:prefer Schema:opentdf VerifyConnection:true MigrationsFS:<nil>} OPA:{Path:./opentdf-opa.yaml Embedded:true Logger:<nil>} Server:{Auth:{Enabled:true PublicRoutes:[] AuthNConfig:{EnforceDPoP:false Issuer:http://localhost:8888/auth/realms/master Audience:http://localhost:8080 OIDCConfiguration:{Issuer: AuthorizationEndpoint: TokenEndpoint: JwksURI: ResponseTypesSupported:[] SubjectTypesSupported:[] IDTokenSigningAlgValuesSupported:[] RequireRequestURIRegistration:false} Policy:{Default: RoleClaim: RoleMap:map[] Csv: Model:} CacheRefresh:15m}} GRPC:{ReflectionEnabled:true} CryptoProvider:{Type:standard HSMConfig:{Enabled:false ModulePath: PIN: SlotID:0 SlotLabel: Keys:map[]} StandardConfig:{RSAKeys:map[123:{PrivateKeyPath:../kas-private.pem PublicKeyPath:../kas-cert.pem} 456:{PrivateKeyPath:../kas-private.pem PublicKeyPath:../kas-cert.pem}] ECKeys:map[123:{PrivateKeyPath:../kas-ec-private.pem PublicKeyPath:../kas-ec-cert.pem}]}} TLS:{Enabled:false Cert: Key:} CORS:{Enabled:true AllowedOrigins: AllowedMethods: AllowedHeaders: ExposedHeaders: AllowCredentials:false MaxAge:0} WellKnownConfigRegister:<nil> Port:8080 Host:} Logger:{Level:debug Output:stdout Type:text} Services:map[authorization:{Enabled:true Remote:{Endpoint:} ExtraProps:map[client:tdf-entity-resolution legacy:true realm:opentdf secret:secret url:http://localhost:8888]} kas:{Enabled:true Remote:{Endpoint:} ExtraProps:map[]} policy:{Enabled:true Remote:{Endpoint:} ExtraProps:map[]}]}"

Please add masking secrets during logging of the fields

@pflynn-virtru Is this something you have solved before? I just found this pkg https://github.com/m-mizutani/masq.

log the config but let's go field-by-field in the config object logged above to determine what fields actually need to be logged, removing secrets entirely
tags in structs to indicate that certain fields are secrets, so they won't be logged

Possible library fix: https://github.com/m-mizutani/masq

I am still seeing secrets logged from the config. I think because extraProps is a map[string]any we might need to think about something else.

I am still seeing secrets logged from the config. I think because extraProps is a map[string]any we might need to think about something else.
My very first commit (custom traversing) was able to mask all secrets. Should we use that approach?
https://github.com/opentdf/platform/pull/1010/commits/ce5e1381b62fdbb46887e26af142b53c286a00fe

I am still seeing secrets logged from the config. I think because extraProps is a map[string]any we might need to think about something else.

My very first commit (custom traversing) was able to mask all secrets. Should we use that approach?
https://github.com/opentdf/platform/pull/1010/commits/ce5e1381b62fdbb46887e26af142b53c286a00fe


Add support for the new automated deliveryType

Add a function in the objectBuilder to support the Tidepool data
model's new 'automated' deliveryType.
Change the 600-series Auto Mode basals to use the new
makeAutomatedBasal function.
deliveryType.
Adds feature requested in https://trello.com/c/SmmJ2c2W

 Update Uploader to support Auto mode for 670G


fix -null on using chart editor on boot up

this makes it so if it gets a null difficulty (which it usually does on boot-up and not loading any songs), it will just not have a file suffix

hi raf 😁

hi

hi raf 😁

hi


Lower Bracket flush with Upper Bracket

Hello,
I was wondering what I would need to change in the CSS or JS to make the Upper bracket matches start level with the lower bracket matches like in the picture below:

I suppose the roundMargin for the Upper Bracket has to be increased without affecting the Lower Bracket, but I don't know how.
Thank You for your help.

It's not supported out of the box, bur you could calculate the resizing parameters proportionally for the winner bracket, i.e. scale the widths or margins the way you want. This would require code changes though.


refactor: remove deprecated fields of BenchmarkSetting

Part of #748

@freedomtan Can you please re-approve this PR? It looks like the previous approval made in the meeting is gone missing.


The "--module" option do not work for Livewire

For some reason this command do not work:
php artisan make:livewire test --module=testmodule
Returns: The "--module" option does not exist.
I'm using Laravel 10 with Filament 3 (Livewire 3)
I missed something? 😃

I just started using this package in a project this week and love it so far, but also hit the roadblock with Livewire and Volt compatibility.  Looks like there is a PR #60 for the Livewire part that was submitted.

new install laravel 11, livewire 3.4 and internachi/modular 2.1.
php artisan make:livewire counter --module=example
get error   The "--module" option does not exist.

new install laravel 11, livewire 3.4 and internachi/modular 2.1.
php artisan make:livewire counter --module=example get error The "--module" option does not exist.

I am experiencing the same issue and just trying out the package for the first time.
The first comment is 3 weeks old (as at the time I wam writing this, I'm wondering if there are no issues to be fixed and we've missed something

for now,  have a installable version that works https://github.com/Filefabrik/modular/tree/3.0.4
I dont want to make a PR because of Livewire 3 and Laravel 11 compabilities with this version, which is also working with Livewire 2.5 and php-8.0

Hi! Before anything, I would like to thank you for this amazing package!
I'm also experiencing :
php artisan make:livewire counter --module=notifications

  The "--module" option does not exist.

Is there a fix coming for this?

I started this issue on March 1st, since no update. Can we expect to have it work or for now, we have to namespace with module subfolders in the livewire folder structure?

Any update on this issue please? I am also using laravel 11 and it's causing the
The "--module" option does not exist.
error
Anyone has a fix to make this work?

Hey @inxilpro! Is there any possibility of this getting worked on sometime soon? If you are open to it, we could possibly provide time to look into the fix or help in any way.
I see there was a proposed fix PR opened: https://github.com/InterNACHI/modular/pull/60
But it looks like you were waiting on feedback from @DanielCoulbourne?

try it with paxsy and bootraiser
it is build for laravel 11
https://packagist.org/packages/filefabrik/paxsy

try it with paxsy and bootraiser
it is build for laravel 11
https://packagist.org/packages/filefabrik/paxsy

Got it, unfortunately I don't think I am looking to include an additional dependency at this time. We would work around it or patch internally until an official patch is released in this package.
I do appreciate the option, though!

Thank you :))
Paxsy(@require-dev) is not required for live operation, it generates your Laravel classes. Bootraiser can be thrown out and your own “boot” and “register” can be built into your ServiceProvider...

This project appears to be on hold or not actively maintained. Therefore, I'm using nWidart Laravel Modules for new projects, which, incidentally, work well with Livewire components.
I hope this package becomes more active and maintained again, as it has a lot of potential. However, for production-level projects, more rigor and support are essential.
When I opened this issue, I expected an update, but it's been 7 months and we're still discussing it. This seems a bit too lengthy.


Revert "Replace StorageV1 client with GCS client (#28079)"

This reverts commit 94812c0a272b65246f4725c1a4ed78dcbd6a619c. This has caused users to report some pipeline failures

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @BjornPrime @johnjcasey


FHS conformance?

I am currently evaluating packaging of MacroMilter, which lead me to a lack of FHS conformance: Both, the executable and the configuration file are currently suggested to be installed in /etc/macromilter/.
FHS suggests to have e.g. /usr/bin/macromilter and /etc/macromilter/config.ini. However, the macromilter.py by default only searches in the same directory. While I indeed could patch this easily downstream, I wonder if it makes sense to change this upstream. I also understand that just changing might break existing setups, so it could be clever to first lookup /etc/macromilter/config.ini (FHS conform) and only if it does not exist search in the same directory like the macromilter.py is residing in for a config.ini.

Updated the milter and the service to fulfill the conformance. It supports booth possible configurations.


fix: error instead of overwriting prevotes

Description
Updates the msg server's AggregateExchangeRatePrevote function to error out if there is an existing prevote instead of overwriting one
closes: #454

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added appropriate labels to the PR
[ ] added ! to the type prefix if API or client breaking change
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Codecov Report

Merging #460 (ff011c9) into main (c7388cd) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   48.00%   47.98%   -0.02%
==========================================
  Files          61       61
  Lines        8054     8058       +4
==========================================
+ Hits         3866     3867       +1
- Misses       3909     3911       +2
- Partials      279      280       +1

Impacted Files
Coverage Δ

x/oracle/keeper/msg_server.go
75.80% <25.00%> (-1.70%)
:arrow_down:


Getting error on IPad - Unsupported JWK algorithm RSA-OAEP-256

Hi,
I am getting the error if I used this package on iPad Air. at createToken method.. I am on latest safari browser and I have tried with '@cybersource/flex-sdk-web/legacy' as well. Could you please assist me on this.

Older versions of Safari do not support RSA OAEP with SHA256 mask generation function particularly well.
To address this, try using the “RsaOaep” Flex encryption type rather than “RsaOaep256”. For example:
•	https://github.com/CyberSource/cybersource-flex-samples/blob/master/java8/jsp-microform/src/main/java/com/cybersource/example/FlexKeyProvider.java, line 47 replace “EncryptionType.RsaOaep256” with “EncryptionType.RsaOaep”.
•	https://github.com/CyberSource/cybersource-flex-samples/blob/master/java8/jsp-microform/src/main/webapp/index.jsp, line 109 replace “rsaoaep256” with “rsaoaep”.


Changing email address of an existing member?

Shouldn't this be marked as a field too:
https://github.com/Ecwid/maleorang/blob/master/src/main/java/com/ecwid/maleorang/method/v3_0/lists/members/EditMemberMethod.kt#L36
in order to conform to:
http://developer.mailchimp.com/documentation/mailchimp/reference/lists/members/#edit-patch_lists_list_id_members_subscriber_hash
?

Hi @andredasilvapinto ,
Maybe... but what changes if we do so? It seems, nothing.
Probably, we should move the email_address field from the constructor to the class body, and make it mutable. That will probably let us modify the subscriber's email. Not sure of that though, an experiment is needed.

yes, that's what I meant. email_address should be a field. it does change the email in that case.

@basiliscus I can confirm making it mutable should work. the idea is that subscriber_hash should stay the hash of the old email (coming from the constructor). then the caller can change the field email_address on the method and update subscriber's email.
The use case is pretty common, users changing their emails from time to time and ideally change on a platform will reflect in Mailchimp.
Also see https://stackoverflow.com/questions/32224697/mailchimp-api-v3-0-change-subscriber-email discussion, the change from November 2016 added this ability to the API
How can we get that pull request approved?


respond_to? crash in Rails console

This happens when we use Rails console in this project and sometimes it crashes with a stacktrace which leads to DryLogic
This issue may or may not be related: https://github.com/dry-rb/dry-logic/issues/73
Possibly upgrading some DRY libs here (or replacing them) may help - just a guess for now.

@andrzejkrzywda do you happen to solve the issue? We are facing same crash after upgrading ruby (up to 3)?


Hive table and table operation implementation so users can directly u…

…se hive metastore with iceberg.
The test case is more involved given I have to spin up an in process hive metastore server and it requires creation of some tables that don't go though data nucleaus' jdo APIS so I had to copy a script runner from IBatis. and run the sql script which will create required locking tables.
We will have to mock stuff if we really want to add a test that shows how atomicity is guranteed but I feel that defeats the purpose. Given append,merge,delete etc operations are handled at base class level I do not see the need to add extra tests for those. If you disagree let me know and I can add tests for those.

Looking at the failure.

@teabot, that's correct. The iceberg-hive module adds support for tracking Iceberg tables in the Hive Metastore. It does not add any support for Iceberg tables to the Hive execution engine.


Allow searching multiple paths for plugins

Should address / close https://github.com/konveyor/crane/issues/89
The conflict resolution is simple and follows the ./plugins -> ~/.local/share/crane/plugins -> /usr/local/share/crane/plugins -> /usr/share/crane/plugins.
I felt that while we certainly could have looked for and newest an instance of the newest version this could lead to a scenario on a shared system where an admin has done a global and/or package install with the newest version, but a user discovers a regression and wants to use a prior version.  If others are satisfied with this I'm ready for merge.


Landuse should exclude buildings source

In working on https://github.com/mapzen/vector-datasource/issues/186 we've discovered we're duplicating buildings with certain tags into the landuse layer as polygons. We shouldn't be doing that (the building should only appear in the building layer as a building feature, a flattened version of it shouldn't be copied to the landuse layers).

I suspect this is the root cause of too many university icons showing up in clusters where OSM has building=yes and amenity=university, but we drop building=yes and end up with amenity=university and an area, which confuses styling down stream.
#16/37.7243/-122.4790

It's also a little weird to see kind:university and landuse_kind:university! At least for building labels, maybe for others, does it make sense to drop the feature's kind property if it's the same as the landuse_kind?
See:

http://vector.dev.mapzen.com/osm/all/16/10471/25342.topojson?api_key=vector-tiles-HqUVidw

There are a few things we could try for this:

Dropping the feature's kind when it ==landuse_kind, as you suggest.
Don't include buildings in landuse (i.e: if building=* then it's a building, not a landuse polygon).
Apply some de-duping filters, e.g: #267.

The first option seems pretty quick, so let's start with that.

It sounds like we need to separate out three different things; landuse, building and POI status. Any OSM feature could have a mixture of all three. I've tried to collect together a set of reasonably plausible examples below, along with what we might want them to be exported as in the output.

a building with no name has building=yes. This should result in a building polygon in the buildings layer with kind=building?
a building with a name has building=yes and name=*. This should result in a building polygon in the buildings layer with kind=building and a label in the buildings layer with kind=building?
a building with an address has building=yes, addr:housenumber=*. This should result in a building polygon in the buildings layer with kind=building and an address point in the buildings layer with kind=addr (or kind=address?).
a building with both name=* and addr:housenumber=* would result in both an address point and a label being generated?
a building with hotel tags has building=yes, tourism=hotel and name=*. This should result in building polygon in the buildings layer with kind=building and a point in the POIs layer with kind=hotel and name=*. We don't consider the name to apply to the building when there are POI tags. But address tags would still generate an address point in the buildings layer.
a building with theatre tags has building=yes, amenity=theatre and name=*. This should result in building polygon in the buildings layer with kind=building and a point in the POIs layer with kind=theatre and name=*, just like the previous case.
a building with landuse and restaurant tags has building=yes, landuse=retail, amenity=restaurant and name=*. This should result in a building polygon in the buildings layer with kind=building and a point in the POIs layer with kind=restaurant and name=*. The landuse value for this building is ignored, although it may get landuse_kind from being enclosed in another landuse polygon anyway.
a building with landuse and theatre tags has building=yes, leisure=stadium and amenity=theatre. What should this get?
a "building" with leisure tags has building=yes and leisure=park. It should get a polygon in the buildings table, and a label point in the landuse layer, but no polygon in the landuse layer?
a park with a library in it has amenity=library, leisure=park and name=*. It should get a polygon in the landuse layer with kind=park but no label, and a label in the POIs layer with kind=library and name=*.

Does that all sound about right? Are there any other cases we should be considering? Particularly any which would result in a polygon being put into more than one layer?

a building with no name has building=yes. This should result in a building polygon in the buildings layer with kind=building?

It would, but we strip that out in post processing so there is effectively no kind property on the feature by the time it makes it to tiles as a polygon (unless an amenity & etc value is additionally set). No label_position should be generated for this feature. I think there is one now, Rob was going to change that in the generic logic (to only generate label_position if name, except if pitch or grass with sport tag).

a building with a name has building=yes and name=*. This should result in a building polygon in the buildings layer with kind=building and a label in the buildings layer with kind=building?

See comment in (1) Above re skipping building=yes in kind calculation. I understand why we do it, but it's also a little weird (to drop it) since we include kind verbosely on any other type of feature in other layers.

a building with an address has building=yes, addr:housenumber=*. This should result in a building polygon in the buildings layer with kind=building and an address point in the buildings layer with kind=addr (or kind=address?).

This makes sense to me.
But what happens when a building with a name and an address has building=yes, addr:housenumber=, name=? Then we generate a label_placement using the name, and additionally generate an address point label that happens to be in the same location as the building's label_placement and let the client deal with it? Should the addr:housenumber=* still be included on the label_placement so the client could specify that on a second line in the name rendering?
NOTE: We revised kind=addr to kind=address earlier in the release.

a building with both name=* and addr:housenumber=* would result in both an address point and a label being generated?

Yeah. Is the addr:housenumber=* still included on the label_placement for the building so the client could specify that on a second line in the name rendering?

@zerebubuth For all of these, does building=yes really mean building=*? I think that's how the logic works now.

For all of these, does building=yes really mean building=*? I think that's how the logic works now.

Yeah, I managed to pick examples with building=yes for all of them... I was thinking that something like this would happen on the polygon:

if building=yes then output kind=building
elif building=* then output kind=*
else don't output a polygon.

a building with hotel tags has building=yes, tourism=hotel and name=. This should result in building polygon in the buildings layer with kind=building and a point in the POIs layer with kind=hotel and name=. We don't consider the name to apply to the building when there are POI tags. But address tags would still generate an address point in the buildings layer.

What happens when there is also a record for that hotel in the point table? Would we get two label_position features, one for the building and one for the point? I think we only want one, but maybe this is a separate pass to dedup?

a building with theatre tags has building=yes, amenity=theatre and name=. This should result in building polygon in the buildings layer with kind=building and a point in the POIs layer with kind=theatre and name=, just like the previous case.

Ditto to 5) above.

I think we only want one, but maybe this is a separate pass to dedup?

I think so too. If there's something in the points table and in the polygons table, that implies that it's duplicated in the original OSM data (as an individual node and also a way/relation). Ideally the data would get fixed, but there'll be some weird corner case where that's not possible, and so it's better to de-dup later on when we've got all the label points together in the same place, as we're post-processing them.

a building with landuse and restaurant tags has building=yes, landuse=retail, amenity=restaurant and name=. This should result in a building polygon in the buildings layer with kind=building and a point in the POIs layer with kind=restaurant and name=. The landuse value for this building is ignored, although it may get landuse_kind from being enclosed in another landuse polygon anyway.

Yep (and that's what default OSM rendering does).

a building with landuse and theatre tags has building=yes, leisure=stadium and amenity=theatre. What should this get?

We should get a POI that is kind=theatre (stadium is less important than amenity in the coalesce here... which is the same logic in the osm.org renderer now – see how they accomplish that).
We will get a polygon in the buildings layer that has kind=theatre.
There should be no label_position in for the building in the building layer.
There won't be a kind=address address point for this in building layer (no house address is set).

a "building" with leisure tags has building=yes and leisure=park. It should get a polygon in the buildings table, and a label point in the landuse layer, but no polygon in the landuse layer?

You managed to find the high line in NYC, which is like a data unicorn!
Since it has other attributes like building:color, building:material and roof:material we assume that someone really meant it. But if it were just building=yes and leisure=park I'm inclined to not include that. Is there any harm in including it, though?

a park with a library in it has amenity=library, leisure=park and name=. It should get a polygon in the landuse layer with kind=park but no label, and a label in the POIs layer with kind=library and name=.

Did you mean it also has building=yes? In that case, I don't expect to see this building appear in the landuse layer (only in the building layer polygons). If it doesn't have building=* then sure, landuse only. If it's coming from buildings then this label position would end up in POIs because it's got the amenity tag.

Another strange case:
https://www.openstreetmap.org/way/32113743
Here there's an landuse area that has area=yes for the school grounds, with a name. Should this get a label position? What kind value?

Here there's an landuse area that has area=yes for the school grounds, with a name. Should this get a label position? What kind value?

Since there's no kind value, other than what we can infer from the human-readable name, I think we should ignore this and not generate a polygon or a label position.

@indyhurt as this (polygons with name but no other useful attributes)
seems like a good thing to measure.

On Tue, Oct 6, 2015 at 9:25 AM, Matt Amos<EMAIL_ADDRESS>wrote:

Here there's an landuse area that has area=yes for the school grounds,
with a name. Should this get a label position? What kind value?
Since there's no kind value, other than what we can infer from the
human-readable name, I think we should ignore this and not generate a
polygon or a label position.
—
Reply to this email directly or view it on GitHub
https://github.com/mapzen/vector-datasource/issues/201#issuecomment-145918712
.

a building with both name=* and addr:housenumber=* would result in both an address point and a label being generated?

Yeah. Is the addr:housenumber=* still included on the label_placement for the building so the client could specify that on a second line in the name rendering?

For a building with a name and an address (e.g: "The Corinthian") should that result in these 3 features?

A polygon with kind=apartments (see, I didn't pick one with building=yes this time!) and
A point with kind=address, addr_housenumber=512 and
A point with kind=apartments and label_placement=yes and name=The Corinthian and addr_housenumber=512?

Or should we generate only the label_placement point and always merge the address onto it, even when there's no name?

For now, it should result in all 3 features:
1. A polygon with kind=apartments, and
2. A point with kind=address, addr_housenumber=512, and
3. A point with kind=apartments and label_placement=yes and name=The
Corinthian and addr_housenumber=512

The features for (2) and (3) will likely have the same x,y coordinate. The
draw order in the renderer would probably be (3) building name
(label_placement) first, then draw the (2) address number kind=address.
Because of that, advanced renderers should have the option of adding the
addr_housenumber on a second line of the name. But in the interest of
slightly duplicate data, basic renderers should have the more complete set
of address information. We definitely don’t want label_placement:yes
features without a name.
On Tue, Oct 13, 2015 at 11:12 AM, Matt Amos<EMAIL_ADDRESS>wrote:

a building with both name=* and addr:housenumber=* would result in both
an address point and a label being generated?

Yeah. Is the addr:housenumber=* still included on the label_placement for
the building so the client could specify that on a second line in the name
rendering?
For a building with a name and an address (e.g: "The Corinthian"
http://www.openstreetmap.org/way/355209013) should that result in these
3 features?

A polygon with kind=apartments (see, I didn't pick one with
building=yes this time!) and
A point with kind=address, addr_housenumber=512 and
A point with kind=apartments and label_placement=yes and name=The
Corinthian and addr_housenumber=512?

Or should we generate only the label_placement point and always merge the
address onto it, even when there's no name?
—
Reply to this email directly or view it on GitHub
https://github.com/mapzen/vector-datasource/issues/201#issuecomment-147799611
.

Screenshots after mapzen/TileStache#72 and #307:
1. Before

1. After

2. Before

2. After
NOTE: The "Capp's Corner Ristorante" POI and building next to "The Boardroom" appear to be due to old data on my system vs. newer data on dev that I used to produce the "before" image and can safely be ignored. Fugazi Hall, the building of interest, is still showing up and has the properties that we want.

3. Before

3. After

4. Before

4. After

Screenshots look good, let's proceed.

What does it look like around SF State University (see screenshot top of this issue)?

Another place to check: Grand Central Terminal rail station in NYC:
https://www.openstreetmap.org/way/265947358

Whitehall Ferry Terminal in NYC is doing the right thing:
http://vector.mapzen.com/osm/all/19/154354/197144.topojson?api_key=vector-tiles-HqUVidw
http://vector.dev.mapzen.com/osm/all/19/154354/197144.topojson?api_key=vector-tiles-HqUVidw

As you can see, some of the duplicate labels (e.g: "Fine Arts") are gone, and we only have one. Unfortunately, it's a POI, because these buildings are incorrectly tagged as individual universities. If those lose the amenity=university then the buildings will get labels instead.
Note that to get the buildings to show up at all, I had to make a couple of style changes:
--- scene.yaml 2015-10-14 13:48:58.873495950 +0100
+++ scene.yaml  2015-10-15 15:20:55.483263261 +0100
@@ -2270,7 +2270,7 @@
                 - { $zoom: { min: 13 }, area: { min: 100000 }, name: true }
                 - { $zoom: { min: 14 }, area: { min: 40000 }, name: true }
                 - { $zoom: { min: 15 }, area: { min: 5000 }, name: true }
-                - { $zoom: { min: 16 }, area: { min: 1000 }, name: true }
+                - { $zoom: { min: 16 }, area: { min: 1000 } }#, name: true }
                 - { $zoom: { min: 17 }, area: { min: 500 } }
                 - { $zoom: { min: 18 } }
             all:
@@ -2913,7 +2913,7 @@
                     all:
                         - kind: university
                         - area: true
-                        - label_placement: yes
+                        #- label_placement: yes
                     any:
                         # show labels for smaller landuse areas at higher zooms
                         - { $zoom: { min: 9 },  area: { min: 10000000 } }

Note that the label is now correctly on "Grand Central Station" as a POI, rather than as a building. Also the duplicate label for "The Grand Hyatt" (hotel & building label) has gone, and now there's only the POI. However, there are still building labels where there are no POIs, e.g: "Socony-Mobil building" and "Chrysler building".

Cool

On Oct 15, 2015, at 09:32, Matt Amos<EMAIL_ADDRESS>wrote:
As you can see, some of the duplicate labels (e.g: "Fine Arts") are gone, and we only have one. Unfortunately, it's a POI, because these buildings are incorrectly tagged as individual universities. If those lose the amenity=university then the buildings will get labels instead.
Note that to get the buildings to show up at all, I had to make a couple of style changes:
--- scene.yaml 2015-10-14 13:48:58.873495950 +0100
+++ scene.yaml  2015-10-15 15:20:55.483263261 +0100
@@ -2270,7 +2270,7 @@
- { $zoom: { min: 13 }, area: { min: 100000 }, name: true }
- { $zoom: { min: 14 }, area: { min: 40000 }, name: true }
- { $zoom: { min: 15 }, area: { min: 5000 }, name: true }

           - { $zoom: { min: 16 }, area: { min: 1000 }, name: true }

           - { $zoom: { min: 16 }, area: { min: 1000 } }#, name: true }
           - { $zoom: { min: 17 }, area: { min: 500 } }
           - { $zoom: { min: 18 } }
       all:

@@ -2913,7 +2913,7 @@
all:
- kind: university
- area: true

                   - label_placement: yes

                   #- label_placement: yes
               any:
                   # show labels for smaller landuse areas at higher zooms
                   - { $zoom: { min: 9 },  area: { min: 10000000 } }

―
Reply to this email directly or view it on GitHub.

The question is whether to alter all the styles, or to add label_placement=yes to all the POIs?

I updated the styling in Skin & Bones last week to account for this without needing to add label_placement=yes to all the POIs. Let's live with that in dev and see how it works out.

Related: https://github.com/nvkelso/tangram-skin-and-bones/issues/13

Regarding case 3 above, looks like the address label position 2525 in this tile should be marked kind=address, but is only showing up as a property attribute on the polygon with kind=building.
http://vector.dev.mapzen.com/osm/all/20/167699/405201.topojson?api_key=vector-tiles-HqUVidw

Regarding case 5 above and the Comfort Inn kind=hotel in the following tile, should we drop the feature's area if it ends up in the POIs layer if it doesn't have label_position=yes?
http://vector.dev.mapzen.com/osm/all/20/167699/405200.topojson?api_key=vector-tiles-HqUVidw
This inconsistency is causing styling bugs (where we're dropping POIs from display that are in tiles). We can probably refactor around this in the scene file (he says hopefully), but seems like if we drop label_position, we should also drop the area.

Same problems with example 6 above (has area but no label_position) for Fugazi Hall, but it is correctly showing up in the POIs layer.

Same problems with example 7 above (has area but no label_position) for Outback Steakhouse, but it is correctly showing up in the POIs layer.

Same problems with example 8 above (has area but no label_position) for Bill Graham Civic Auditorium, but it is correctly showing up in the POIs layer and is correctly getting kind=theatre.

Hard to verify the High Line example 9. But this tile makes it seem like it's working: http://vector.dev.mapzen.com/osm/all/16/19295/24631.topojson?api_key=vector-tiles-HqUVidw. Although there's a spare mz_is_building=true hiding out there. There are also labels for the High Line as a building, which seems weird, though.

Example 10 with the library is working, except for the common thread of area && label_position pairing.

http://vector.dev.mapzen.com/osm/all/19/154913/196512.topojson?api_key=vector-tiles-HqUVidw

Action item: If we're putting a POI sourced from landuse or buildings into the POI layer, let's include both it's source area (already happening) and mark it as label_position=yes (todo).

Action item: If we're putting a POI sourced from landuse or buildings into the POI layer, let's include both it's source area (already happening) and mark it as label_position=yes (todo).

I don't understand the rationale behind this. If we have a POI then why do we care whether it has come from a polygon or a point table?
Is there something that label_placement=yes is used to signify other than the source table of the data, as that really should be an implementation detail that we don't expose. At the moment it's correlated with area, but only because we don't (yet... #348) have a good way of figuring out how to assign building area to POIs.
(As a side note, started #347 to track using representative_point for calculating POI positions from polygons.)

Regarding case 3 above, looks like the address label position 2525 in this tile should be marked kind=address, but is only showing up as a property attribute on the polygon with kind=building.

I'm getting this locally:
  {
    "type": "Point",
    "properties": {
      "source": "openstreetmap.org",
      "kind": "address",
      "addr_housenumber": "2525",
      "addr_street": "Van Ness Avenue",
      "id": 69707523
    },
    "coordinates": [
      676,
      797
    ]
  }

So something is going on. Not sure if it's a code difference between dev and my local machine, or a database difference. Will investigate further.

So something is going on. Not sure if it's a code difference between dev and my local machine, or a database difference. Will investigate further.

This tile looks good in dev as of last night's deploy. So either there was a temporary regression which got fixed, or something weirder is going on.
This might be an excellent candidate for a "unit test".

@zerebubuth Here's an interesting case where no name, the building is tagged as an appartment, and it has an address. Should the kind=address or kind=appartment?
http://vector.dev.mapzen.com/osm/all/19/83848/202601.topojson?api_key=vector-tiles-HqUVidw

I've gotten around the label_position thing by using $geometry: point paired with area: true which works in Tangram JS / WebGL and is soon to work in Tangram ES (PR landed Thursday?).

Here's an interesting case where no name, the building is tagged as an appartment, and it has an address=1595. Should the kind=address or kind=appartment?
http://vector.dev.mapzen.com/osm/all/19/83848/202601.topojson?api_key=vector-tiles-HqUVidw

I'm seeing two features there:
  {
    "type": "Polygon",
    "properties": {
      "kind": "apartments",
      "area": 544,
      "addr_street": "Greenwich Street",
      "height": 14,
      "volume": 7616,
      "source": "openstreetmap.org",
      "addr_housenumber": "1595",
      "id": 243508784
    },
    "arcs": [
      [
        2
      ]
    ]
  },
  ...
  {
    "type": "Point",
    "properties": {
      "source": "openstreetmap.org",
      "kind": "address",
      "addr_housenumber": "1595",
      "addr_street": "Greenwich Street",
      "id": 243508784
    },
    "coordinates": [
      807,
      43
    ]
  },

Which is what we agreed before. The addr_housenumber is left on the building polygon in case it's useful to some renderers, but generally it should be ignored if the kind=address points are being rendered.

I see the same thing now, and it's to spec, so nothing more to see here.


correctly close the javadoc tag in JmsIO.Write

This should fix the incorrectly rendered javadoc for that method, see the problem here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Could you please run './gradlew :sdks:java:io:jms:spotlessApply' to fix format check

sure, there it is - although now the change looks as if it were more complicated than it really is :)


Vite builds the lib package, and react-dom.development.js is built into it

Describe the bug
When I build in production mode, the build product should theoretically not contain the react-dom.development.js package, but it is currently found that the build result does contain react-dom.development.js
visualizer result：

vite.lib.config.ts:
export default ({ mode }) => {
  const analyzer = { ...loadEnv(mode, process.cwd()) };
  const analyzerPlugin = analyzer.VITE_ANALYZER
    ? [visualizer({ open: true, gzipSize: true, brotliSize: true, template: 'treemap' }) as PluginOption]
    : [];

  return defineConfig({
    build: {
      lib: {
        entry: './lib/index.tsx',
        name: 'xxxx',
        fileName(format) {
          return `login-pass.${format}.js`;
        },
        formats: ['es', 'umd'],
      },
      target: 'es2015',
      rollupOptions: {
        plugins: [...analyzerPlugin, terser()],
        output: {
          // Replace process.env.NODE_ENV with ‘production’ value in UMD package
          intro: `const process = { env: { NODE_ENV: JSON.stringify('production')} }`,
        },
      },
    },

    resolve: {
      alias: {
        '@': path.resolve(__dirname, 'lib'),
      },
    },
  });

Reproduction
null
Steps to reproduce
No response
System Info
<EMAIL_ADDRESS><EMAIL_ADDRESS>nodejs 16.14.0
<EMAIL_ADDRESS>
Used Package Manager
yarn
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

It's because process.env.* is not replaced in lib mode.
https://vitejs.dev/guide/build.html#library-mode:~:text=Environment Variables,statically replace them.
Note that you are not actually replacing the value here:
// Replace process.env.NODE_ENV with ‘production’ value in UMD package
intro: `const process = { env: { NODE_ENV: JSON.stringify('production')} }`,

You are just injecting the code. That's not statically analyzable and Vite/Rollup won't remove react-dom.development.js.


perhaps consumable as a library as well?

Perhaps make this consumable as a library as well? So, most of the code in lib/, with a small executable (parsing args) in bin/.

Here's an api for a similar server:
  MicroServer server = await MicroServer.start(path: 'build/web', port: 8888);
  print('serving ${server.path} from ${server.urlBase}');
  await server.destroy();

Love it. Will merge as soon as it's mergeable.


The finalized block alway 0

Follow the README and show such logs.  I have no idea why the finalized block is 0 all the time. Does anyone know what happened here?
$ ./binary --chain fork.json --alice
2022-04-22 15:44:56 👶 Creating empty BABE epoch changes on what appears to be first startup.
2022-04-22 15:44:56 🏷 Local node identity is: 12D3KooWF6hM2mHQf5U8AtyhCvB2RvdY5S4NxQuRfVptYY9JRrSQ
2022-04-22 15:44:56 Can't listen on /ip6/::/tcp/30333 because: Other(Custom { kind: Other, error: Other(A(A(A(A(Transport(B(Os { code: 98, kind: AddrInUse, message: "Address already in use" }))))))) })
2022-04-22 15:44:56 Can't listen on /ip4/<IP_ADDRESS>/tcp/30333 because: Other(Custom { kind: Other, error: Other(A(A(A(A(Transport(B(Os { code: 98, kind: AddrInUse, message: "Address already in use" }))))))) })
2022-04-22 15:44:57 📦 Highest known block at #0
2022-04-22 15:44:57 Unable to bind RPC server to <IP_ADDRESS>:9933. Trying random port.
2022-04-22 15:44:57 Unable to listen on <IP_ADDRESS>:9944
2022-04-22 15:44:57 Unable to bind RPC server to <IP_ADDRESS>:9944.

It's not started as Authority. Add "--validator" flag.

It's not started as Authority. Add "--validator" flag.

--alice contains --validator


v6 - Fetching any locale passed to checkout

Summary

Accepting any locale as part of the AdyenCheckout configuration
If the request to fetch that locale fails, we fallback fetching the 'en-US' locale

I was testing a random non-compliant locale aaa, i saw we are preventing the sdk rendering. Do you think we should just output a warning, fallback to English and still let the sdk render? I refer to the function formatLocale.
The rest works and looks good!


Inf-20100616

My inf-20100616-1 is missing for RetroMCP.

First off, Infdev 20100616-1 has not been put into RMCP yet.
Second off, this is the wrong repository to comment this on.
Third off, use https://github.com/MCPHackers/RetroMCP-Java/discussions if you're going to ask questions that have a simple answer.

how do you add a1.2.2a?

Stop asking for missing versions in RMCP. If you continue, you will banned from commenting on issues.

no


Remove disk not affected by snap on vCenter

Description
vCener allows to remove disks from a VM if it has been attached after a snapshot creation, OpenNebula instead, doesn't allow it. ONE shows the message

vCenter doesn't allow to remove a virtual disk if it's part of a snapshot of the virtual machine.

on oned.log file, even if the diskis not part of the snapshot.
vCenter doesn't allow to remove a virtual disk if it's part of a snapshot of the virtual machine.
on oned.log file, even if the volume is not part of the snapshot.
To Reproduce
Create a snap on a VM.
Attach disk.
Detach disk.
Expected behavior
ONE should allow disk detaching if disk is not part of the snap.
Details

Hypervisor: vCenter
Version: 5.4.15

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

https://github.com/OpenNebula/one/pull/3187 --> master

#3187 --> commited to master and one-5.8
OpenNebula/development#582 --> commited to master and one-5.8
5d74cc0 --> one-5.8-maintenance


Duplicate channels being created and added to sitemap

Duplicate channels are being created and added to the sitemap when running on bigger servers with many channels and categories.

I manually deleted the duplicate channels, removed the final.json file, and reran the script. This generated a new sitemap, which appears to be cleaned up now with no duplicates.


Move some MTRDevice_Concrete-specific constants to MTRDevice_Concrete.

Fast-tracking platform-specific change with platform owner review.


Update Shanghai tests to use solely fork name instead of EIP numbers.

Small change: update '(eip3651, eip3855, eip3860).py' to use the Shanghai fork name solely as opposed to using EIP numbers. 'withdrawals.py' already adheres to the latter.
eip3651 - is updated from 'merged' to 'shanghai' fork? @marioevz

Looks correct - still waiting for 3860 to hit geth master though. Might want to wait until that merges (should be soon). https://github.com/ethereum/go-ethereum/pull/23847


fix reorder join generate plan is not stable (#31539)

pick from master #31539
commit id 59cdef96f6cf7a8178e17a8512181995255f76bc
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Exclude sites that embed facebook plugins

This excludes sites that might have iframes that point to something like:
"https://www.facebook.com/v2.3/plugins/like.php..."
Also added some tab fixes to the manifest

Test Plan:

Built the extension, and ensured it doesn't have access to and didn't attempt to validate a page that has a social plugin (e.g. https://playoverwatch.com/en-us/news/23822252/welcome-to-the-overwatch-2-beta/)
Did a quick sanity check to ensure we don't accidentally match the excludes glob pattern for valid urls (e.g. I visited something like https://www.facebook.com/http://facebook.com/v2.3/plugins/foobar and ensured it started to verify the page).

Closing this out since the added exclude globs are too permissive


Icon request won't load app icon with adaptive icon

In the Icon Request, apps using the Adaptive Icons are shown with Android's default icon, rather than the real app icon.
Tested with a device running Android 8.0 Oreo.

Very big issue for me as well- even after upgrading.


Patch for an issue which made it not possible to properly unmount a Unity instance

This pull request includes a patch for the famous problem #22 where a Unity Instance cannot be unmounted. This is simple due to Unity not letting me do so. In the newest unity version 2019.1, the ability to as they call Quit the WebGL application was added to unload the player from the memory.
Note that this will be only available on Unity 2019.1 or newer, and needs to be tested heavily before I'll publicly release this patch.

Whats your suggestion is this working fine? remember Unity 2019.1 is in beta format so we can't use it production right now so problem will remain the same.

@MuhammadFaizanKhan #22 Yes, Unity 2019.1 is still in beta. Still I'm looking for any beta testers to this this feature so I could release it in time with the release of Unity 2019.

@MuhammadFaizanKhan #22 Yes, Unity 2019.1 is still in beta. Still I'm looking for any beta testers to this this feature so I could release it in time with the release of Unity 2019.

Best of luck for future endeavors but a clarification require that the problem will remain same with old unity version?

@MuhammadFaizanKhan Thanks. And yes, that's simply because Unity doesn't allow unloading the player from the memory in versions below 2019.1.

@MuhammadFaizanKhan Thanks. And yes, that's simply because Unity doesn't allow unloading the player from the memory in versions below 2019.1.

Yes, Maybe this is the reason when you do page reload, the chrome increment the memory. There is a memory leak issue which is serious concern.  I don't know that firefox also behaving in the same way.

@MuhammadFaizanKhan Thanks. And yes, that's simply because Unity doesn't allow unloading the player from the memory in versions below 2019.1.

I found that when the dev tools are open and you are measuring the memory then, chrome is keep increment the memory. So it basically related to dev tools of chrome.


Does flutter support add-to-framework

Use case
Now I have a iOS framework to be used within other apps to integrate account and use center
features. Since we have framework on both iOS and android, I want to use flutter to write some
new pages proposed.
Proposal
Now how add-to-app works is that flutter has to depend on iOS or android Lifecycles if I am correct, so in a iOS framework we have no access to host app's appDelegate or that would be additional work for our framework users.  So I wonder is there a solution for that, Thank you very much and wish flutter best and cheer for the flutter team.

@xster

It's a pretty valid use case. I think we'll have to solve the general problem of merging multiple libraries and modularizing the library further first.
Something we can plan for in phase 2+

I'm repurposing this to a general add-to-library feature request

Copying from https://github.com/flutter/flutter/issues/35262#issuecomment-567283040 where CocoaPods was specifically mentioned:
If you're willing to use CocoaPods, you could try to use flutter build ios-framework to generate all the Release frameworks you need, then supply them as vendored_frameworks.  Of course that means you would need to host those binaries somewhere remotely, as you mentioned, where your users could fetch them by pod 'Your-Framework' in their Podfile.
Once https://github.com/flutter/flutter/issues/26712 is done, you would only need to vend the App.framework and any plugins, and your podspec would depend on the exact version of the Flutter pod they were built with.
s.dependency 'Flutter', '1.12.1306'

Pretty much ditto to support Carthage once https://github.com/flutter/flutter/issues/24176 is done.


Test creating archive from non-git package containing symlinks

This patch: https://codereview.chromium.org/11558036/
fixes a bug where if have a package that:

Has a "packages" directory. (You've pub installed it.)
Is not using git.

Then you'll get bad paths when trying to generate the archive. This is stems from the fact that Directory.list() in dart:io gives us paths *after* symlinks have been resolved.
The patch works around it, but we should have a cleaner fix. We should also have a test that can repro this issue.

This issue has been moved to dart-lang/pub#371.


How to acess the hydraulic results in the report?

I'm running a hydraulic simulation with the toolkit, but i have some issues to get the results. Even with all the options "YES" or "FULL", the program only generates the "status report" present in the graphic interface. I'm trying to get the full report, as the file of the report>full section. Can I get it only with de .inp file or do I need to ask it in the main file?
The .inp file:
[TITLE]
[JUNCTIONS]
;ID              	Elev        	Demand      	Pattern
3               	98          	5.16       	                	;
[RESERVOIRS]
;ID              	Head        	Pattern
1               	103         	                	;
[TANKS]
;ID              	Elevation   	InitLevel   	MinLevel    	MaxLevel    	Diameter    	MinVol      	VolCurve
Tanque          	99          	1           	0           	2           	1           	0           	                	;
[PIPES]
;ID              	Node1           	Node2           	Length      	Diameter    	Roughness   	MinorLoss   	Status
1               	1               	Tanque          	1000        	100         	.01         	0           	Open  	;
2               	Tanque          	3               	10          	100         	.01         	0           	Open  	;
[PUMPS]
;ID              	Node1           	Node2           	Parameters
[VALVES]
;ID              	Node1           	Node2           	Diameter    	Type	Setting     	MinorLoss
[TAGS]
[DEMANDS]
;Junction        	Demand      	Pattern         	Category
[STATUS]
;ID              	Status/Setting
[PATTERNS]
;ID              	Multipliers
[CURVES]
;ID              	X-Value     	Y-Value
[CONTROLS]
[RULES]
[ENERGY]
Global Efficiency  	75
Global Price       	0
Demand Charge      	0
[EMITTERS]
;Junction        	Coefficient
[QUALITY]
;Node            	InitQual
[SOURCES]
;Node            	Type        	Quality     	Pattern
[REACTIONS]
;Type     	Pipe/Tank       	Coefficient
[REACTIONS]
Order Bulk            	1
Order Tank            	1
Order Wall            	1
Global Bulk           	0
Global Wall           	0
Limiting Potential    	0
Roughness Correlation 	0
[MIXING]
;Tank            	Model
[TIMES]
Duration           	2 HOURS
Hydraulic Timestep 	5 MIN
Quality Timestep   	5 MIN
Pattern Timestep   	5 MIN
Pattern Start      	0:00
Report Timestep    	5 MIN
Report Start       	0:00
Start ClockTime    	0:00
Statistic          	None
[REPORT]
Pagesize   		0
Status             	FULL
Summary            	YES
Messages  		YES
Page               	0
Links            	ALL
FLOW			YES
HEADLOSS     		YES
STATE   		YES
Nodes             	ALL
ELEVATION 		YES
DEMAND			YES
HEAD			YES
PRESSURE  		YES
[OPTIONS]
Units              	LPS
Headloss           	D-W
Specific Gravity   	1
Viscosity          	1
Trials             	40
Accuracy           	0.001
CHECKFREQ          	2
MAXCHECK           	10
DAMPLIMIT          	0
Unbalanced         	Continue 10
Pattern            	1
Demand Multiplier  	1.0
Emitter Exponent   	0.5
Quality            	None mg/L
Diffusivity        	1
Tolerance          	0.01
[COORDINATES]
;Node            	X-Coord         	Y-Coord
3               	5604.68         	7067.62
1               	1430.43         	7665.80
Tanque          	3537.06         	7366.71
[VERTICES]
;Link            	X-Coord         	Y-Coord
[LABELS]
;X-Coord           Y-Coord          Label & Anchor Node
[BACKDROP]
DIMENSIONS     	0.00            	0.00            	10000.00        	10000.00
UNITS          	None
FILE
OFFSET         	0.00            	0.00
[END]

@TCCampos - without going into too much thought about the specific question, can you advise what version / build / commit you are working from? Is this something that once worked but no longer works correctly?
Also, you mention both the inp file and the main file - what do you mean by "main file"?
thanks!

closing as stale. please re-open if this continues to be an issue.

I think what he was requesting was to get a result in the status report which can be done with this modification in Epanet.c. This will only function if Status Report in Options is set to Full
`int DLLEXPORT EN_close(EN_Project p)
/*----------------------------------------------------------------
**  Input:   none
**  Output:  none
**  Returns: error code
**  Purpose: frees all memory & files used by a project
**----------------------------------------------------------------
*/
{
EN_report(p); // This is the addition
// Free all project data
if (p->Openflag) writetime(p, FMT105);
freedata(p);
`
The only problem is if the result is too long, it may take a lot of space in the status report


Make it more obvious that Show Content view items are clickable

Some users in the user study failed to acknowledge that items in the Show Content view are clickable. We should add some UI affordance to make this more obvious. Some ideas after @stevencl @sandy081 and mine discussion:

Make the settings item expandable. It only expands to a single child settings.json item
Some inline action instead?

This bug has been fixed in the latest release of VS Code Insiders!
@isidorn, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version f1b09237cd400d92987cf7a9681995e8011ef54c of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!


1.20.4 seems broken

When trying this mod, I get the following errors:
client:
[Render thread/WARN]: Client disconnected with reason: Internal Exception: io.netty.handler.codec.DecoderException: Not enough bytes in buffer, expected 99, but got 24
server:
[02:22:56] [User Authenticator #2/INFO]: UUID of player Maescool is 48ac181a-01f5-4cb4-ad26-857ec77b3029
[02:22:56] [Netty Epoll Server IO #4/INFO]: Hash Found: d7565ffa9629588d2cfc56c282f0f94cbe2045ae
[02:22:56] [Server thread/INFO]: com.mojang.authlib.GameProfile@39dbf735[id=48ac181a-01f5-4cb4-ad26-857ec77b3029,name=Maescool,properties={textures=[Property[name=textures, value=somebase64]}] lost connection: Disconnected

Fix issued by @henkelmax #2  solves this problem. I will be uploading to curseforge and modrinth shortly. If you could confirm this fixes your issues that would be amazing :)

The build I got from @henkelmax works for me, thanks.
can you also add the /updatehash command in the docs? pretty useful to know, and I tend to use it with RCON

Perfect, glad it's working. I will add info on the command to the readme, and mod pages. I kinda forgot that it existed as it was a last minute addition at one point.
I will close this issue now, if you come across anything else feel free to open another. Thanks!