Couple of acceptance test in Ruby-Storage fail

URL: https://github.com/GoogleCloudPlatform/google-cloud-ruby/tree/master/google-cloud-storage/acceptance
Steps:

git clone https://github.com/GoogleCloudPlatform/google-cloud-ruby
cd google-cloud-ruby/google-cloud-storage
bundle update
bundle exec rake "acceptance[project_id,path_to_json_key_file]"

RESULT:
79 runs, 633 assertions, 0 failures, 2 errors, 2 skips
Finished in 227.637763s, 0.3470 runs/s, 2.7807 assertions/s.
Error 1: Not sure why.

Error:
Google::Cloud::Storage::File::storage#test_0013_should upload and partially download text:
Google::Cloud::Storage::FileVerificationError: The downloaded file failed MD5 verification.
/home/suhasm/google-cloud-ruby/google-cloud-storage/lib/google/cloud/storage/file/verifier.rb:34:in verify_md5!' /home/suhasm/google-cloud-ruby/google-cloud-storage/lib/google/cloud/storage/file.rb:1464:in verify_file!'
/home/suhasm/google-cloud-ruby/google-cloud-storage/lib/google/cloud/storage/file.rb:688:in download' /home/suhasm/google-cloud-ruby/google-cloud-storage/acceptance/storage/file_test.rb:365:in block (3 levels) in <top (required)>'

Error 2: I am guessing this is because the test does not pick the service account key set in the env variable, rather looks for Service account<EMAIL_ADDRESS>which does not exist.
It would be great if the test can pick service account set in env variable (this would make the test generic and usable in user owned project)

Error:
Google::Cloud::Storage::Bucket::notification::storage#test_0001_creates a Pub/Sub subscription notification:
Google::Cloud::InvalidArgumentError: 3:Service account<EMAIL_ADDRESS>does not exist.
/home/suhasm/google-cloud-ruby/google-cloud-pubsub/lib/google/cloud/pubsub/service.rb:459:in rescue in execute' /home/suhasm/google-cloud-ruby/google-cloud-pubsub/lib/google/cloud/pubsub/service.rb:456:in execute'
/home/suhasm/google-cloud-ruby/google-cloud-pubsub/lib/google/cloud/pubsub/service.rb:370:in set_topic_policy' /home/suhasm/google-cloud-ruby/google-cloud-pubsub/lib/google/cloud/pubsub/topic.rb:449:in update_policy'
/home/suhasm/google-cloud-ruby/google-cloud-pubsub/lib/google/cloud/pubsub/topic.rb:415:in policy' /home/suhasm/google-cloud-ruby/google-cloud-storage/acceptance/storage/bucket_notification_test.rb:34:in block (2 levels) in <top (required)>'

We've seen Error 1 every so often in CI, and we're not sure what's causing it yet. https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/2341 is an attempt to gather more information about it.
Error 2 is indeed a setup/config issue. It works in CI because of how we've set up the environment. You're right—we should set up something so the test can be run elsewhere.

I believe the solution to Error 2 is to obtain the service account email used in the test from Storage::Project#service_account_email. I will submit a PR that changes the test (and the documentation examples) to use this method to obtain the email.

Have you seen error 1 recently?

After the fix to Error 2, I re-ran the test and I did not see any issues.


buildFHSUserEnv fails to run for paths with spaces

Describe the bug
buildFHSUserEnv fails to run for paths with spaces.
See: https://github.com/thiagokokada/nix-alien/issues/71
Steps To Reproduce
Run nix-alien on path with spaces
Expected behavior
Works correctly
Additional context
This kind of file was generated by buildFHSUserEnv
#!/nix/store/rnkas52f8868g1hjdlldbvh6snm3pglv-bash-5.2-p15/bin/bash
source /etc/profile
cat > /etc/ld.so.conf <<EOF
/lib
/lib/x86_64-linux-gnu
/lib64
/usr/lib
/usr/lib/x86_64-linux-gnu
/usr/lib64
/lib/i386-linux-gnu
/lib32
/usr/lib/i386-linux-gnu
/usr/lib32
/run/opengl-driver/lib
/run/opengl-driver-32/lib
EOF
ldconfig &> /dev/null

exec /path/to/file with spaces "$@"

Notify maintainers
@Atemu
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.26, NixOS, 23.05 (Stoat), 23.05.20230429.08e4dc3`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.3`
 - channels(root): `"nixos-21.11.336297.47cd6702934"`
 - nixpkgs: `/nix/store/f9npl9988fipf059n1dh2s6gb6pbfc0i-9c0slwp2dyc6z2gxkcyrqxifbik0n68d-source`

nixpkgs in flake.lock
    "nixpkgs": {
      "locked": {
        "lastModified":<PHONE_NUMBER>,
        "narHash": "sha256-m7QFzPS/CE8hbkbIVK4UStihAQMtczr0vSpOgETOM1g=",
        "owner": "nixos",
        "repo": "nixpkgs",
        "rev": "08e4dc3a907a6dfec8bb3bbf1540d8abbffea22b",
        "type": "github"
      },
      "original": {
        "owner": "nixos",
        "ref": "nixos-unstable",
        "repo": "nixpkgs",
        "type": "github"
      }
    },

As it turns out, runScript is not supposed to be escaped. That's up to the calling application, so nix-alien.
I'd be in favour of refactoring runScript to runCommand + runArgs but that's a discussion for a separate issue.


NUTCH-3011 HttpRobotRulesParser: handle HTTP 429 Too Many Requests same as server errors (HTTP 5xx)

since you asked me to have a look at it @sebastian-nagel, it looks good to me!


java: adding factories to the generated Java classes

adding factories to the generated Java classes, allowing the user to control the type of classes to be allocated when de-serializing the incoming message.
example of generated code:
public class Team implements ... {

  ...
  public static class TeamFactory {
    public Team allocate() { return new Team(); }
    public Team allocate(Team other) { return new Team(other); }
    public Team allocate(String teamId, String name, String domain, String email_domain, String plan) { return new Team(teamId, name, domain, email_domain, plan); }
  }

  public static volatile TeamFactory factory = new TeamFactory();
  public static void setFactory(TeamFactory f) { factory = f;}
  public static TeamFactory getFactory() { return factory;}

  ...
}

contributing back from slackhq

CC: @smourachov

Hi @korovkin, thanks! Could you please create a matching JIRA ticket for it, according to our contrib guidelines?

sure.
added: https://issues.apache.org/jira/browse/THRIFT-3887

This needs to be rebased on the current master and resubmitted; we need a clean CI build before we can proceed.

This needs to be rebased on the current master and resubmitted; we need a clean CI build before we can proceed.

Please change the destination to master, and rebase on master so we can get a fresh CI build in order for this to proceed.  Thanks.

Would also prefer to see a test exercising the new code.

we are no longer using this approach, safe to close


find("#foo").visible? doesn't work with css class

Hi
I tried to look through the other issues to find an answer to this but couldn't so am thinking it might be a bug. Here is the "bug" (I think) that I found.
I have a link that when clicked on opens a pop up box. I'm hiding the pop up box with a class of 'hide'. Something like
<div id="my_pop_up" class="hide">
  Bar bar bar...
</div>

When I create a test that looks like
   find("#my_pop_up").visible?.should_not be_true

It fails. Now I can fix this problem by adding style="display:none" inline, however the css hide (which just does 'display:none') doesn't work.
I've tried this on different applications with the same problem so I'm guessing either 1) It's a bug 2) I don't understand what .visible? is really suppose to do.
Hope this helps.

I'm guessing you're using RackTest. RackTest only looks at inline styles, since it does not have a CSS parser and does not check external stylesheets at all. This should work as expected in Selenium. This is really not a bug though, for performance reasons alone it doesn't make sense to have RackTest parsing CSS.

Oh I didn't know that. Good to know. So if I'm doing any testing that needs to check css elements etc, Selenium is used for that. Got it.


Including maven in Builder Image

I did not see any discussion around how tools are chosen to be included/excluded from the Runner image, and I expect there i some preference to not manage everything as part of the included container.  I am opening this partially as a discussion item, but also as a real request.
Is your feature request related to a problem? Please describe.
I am using the actions-runner-controller along with the summerwind/actions-runner and enjoy both tools, and would like to continue to use the upstream components without managing my own runner image.  At the same time, maven is included within the Github.com runners, and actions such as setup-java expect Maven is already in the image.  As a result, no well used public action exists that supports the management of Maven itself.
Describe the solution you'd like
I would like Maven included in the base docker image so that users can experience a more similar environment to a Github.com builder and not have to support shims to install maven as an action that are only needed when using the included docker image.
Describe alternatives you've considered

Extend the docker image and include Maven myself.

Additional context

Unforutnately we're not looking to add more tools into the base image, in general we only consider new tools if (and tbh we're a hesitant even if these tests are met):

The tool itself is generally version insensitive
Any config associated with the tool itself is generally version insensitive

We are strict on what goes in the base runner image due to the maintainers having very limited time to support the project (we have actual jobs). We understand maintaining your own images is a bit of a pain in the arse however we wouldn't be able to provide a stable base imave if we brought in lots of tools to the base image (nor are we experts on all the tools out there).
The good news is that GitHub are going to make running your own image less painful soon by loosening the requirement to always be running latest https://github.com/actions/runner/issues/1396#issuecomment-983783264. Once this is done running your own image built from ours shouldn't be as difficult as it is currently, stability wise. If you can deploy a k8s centric project you should be able to also maintain your runner images. GitHub should also stop making them explode from upgrades soon and so you will be able to do a more managed approach to upgrading them with these 2 changes combined (the process is fairly easily automated).

Thank you @toast-gear; I appreciate the process you are using to evaluate tools to be added to the existing container, and understand the reluctance to add further tools.


Updated DA schema to support Linked Data Proof Chain (Alternate proposal to #16)

Each item in the proof chain must have an identifier and should
match corresponding event item.
Signed-off-by: George J Padayatti<EMAIL_ADDRESS>

Looks good to me too.


Override configuration with environment variables if they exist

Override configuration with environment variables if they exist.
Hey, team. This is your friend Gabs from Harness, and I have a quick suggestion to allow us to provide some important configuration that overrides the config file app.config when necessary.
For example, during my CD Pipeline, I will retrieve the Redis details from a Vault Server, using Harness expressions (<+secrets.getValue("redis_host")>) and use it in the K8s Deployment -> Pod -> Container environment variables.
For example, I create a Secret or a Configmap to hold these, but then I serve the variables for the python app at runtime, with K8s's envFrom.
Small test:
1-) using a bad redis endpoint, the test will fail:
(env) root@DESKTOP-S8EV48S:~/REDIS/REDIS_PYTHON/ru102py# export REDIS_HOST=cerioni.platformengineer.io
(env) root@DESKTOP-S8EV48S:~/REDIS/REDIS_PYTHON/ru102py# pytest ./tests/test_hello.py
FAIL!!!

2-) now the good old redis that I have in my godaddy domain:
(env) root@DESKTOP-S8EV48S:~/REDIS/REDIS_PYTHON/ru102py# export REDIS_HOST=redis.platformengineer.io
(env) root@DESKTOP-S8EV48S:~/REDIS/REDIS_PYTHON/ru102py# pytest ./tests/test_hello.py
SUCCESS!!!
<...> 1 passed in 2.08s

Cheers!

Howdy! Can ping me on https://www.linkedin.com/in/gabrielcerioni


Enable global autoscaling

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 4 committers have signed the CLA.:white_check_mark: avaakash:white_check_mark: GokulBansal0:x: bot2-harness:x: siraj-ioYou have signed the CLA already but the status is still pending? Let us recheck it.


fix documentation

Updated README.md and CONTRIBUTION.md,

Updated links since the documentation for v1 was moved to http://fastai1.fast.ai/
Updated installation to not install latest fastai version

Fixes #3

Great!

@jph00 is there still a Github action that builds the docs from the docs_src folder as described in the documentation or should I run it locally and then create a pull request?

Please run it locally and do a PR - thanks!

@jph00 Created new pr #4


Two events for the same date/time

Do you want to request a feature or report a bug?
Both
What's the current behavior?
When there are 2 or more events for the same date/time, just one event is shown in the Day tab/view. I believe that it's happening because the approach using position: absolute.
In the image below, there are 2 events for the same date/time;

Changing the top property, shows up the other element:

When could we have this scenario?
For applications where there is an engagement form, and the engagement could be for incoming or outgoing events, or even a shared calendar where many engagements are scheduled to the same date/time for different person/reason.

What's the expected behavior?
Would be nice-to-have it in fit inside the line of the hour.

even in the version .18, the error still persist.

Can you post a reproduction in codesandbox thanks!

I am still getting the same error, is there any solution found?

I'll have a look if someone could provide a codesandbox.

Attributes on Event: start and end dates are equals, start time is 09:00 , end time is 09:00 try to change it to: start: 09:00, end: 09:30.

Fixed in #677 I think


Is FCC 477 per-block, or per-tract?

According to the FCC's data-download page, it's tract-level, but the December 2011 Federal Register filing about the Connect America Fund seems to indicate that it's block-level. Some press coverage says it's block-level. Is it possible that the data is collected at a block level but distributed at a tract level?

All of the data is per-block only for the number of providers (how much competition there is), but it's per-tract for actual connection speed data. The CSV data provided is likewise tract-level.
So looks like it's tract-level, however it's collected.


feat(logs): add important logs during command reconcile

Signed-off-by: AmitKumarDas<EMAIL_ADDRESS>

:tada: This PR is included in version 1.21.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Change http to https for security links

For security, we should change http into https links.

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "fix_http_https" git@github.com:huynq0911/notary.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Can one of the admins verify this patch?


[ENG-10384][eas-json] update eas.schema.json to include new JDK 17 image

Why
https://linear.app/expo/issue/ENG-10384/add-images-for-jdk-17-and-21
How
Update eas.schema.json

/changelog-entry chore Update images descriptions in eas.schema.json and add info about the new JDK 17 image


implement save/update of stats when multiple choice quiz completes

This issue was cloned to the new GitHub repo as issue #4.

This issue was cloned to the new GitHub repo as issue #4.


'Expires' header fail when both headers are present? (nginx specific)

When using nginx, the Cache-Control header can be set, along with the Expires header, via the ngx_http_headers module. Since this allows for some applications that are not possible with static Cache-Control headers, such as setting a specific time of day, or modified + time, it may not be a bad idea to, when both headers are present, to turn it into a warning instead?
For dynamic content, the upstream application server would likely deal with this, but, for static content, setting it in the nginx configuration is a rather convenient shortcut, with no way to turn off the Expires header.
See; https://nginx.org/en/docs/http/ngx_http_headers_module.html#expires

This one is potentially a little spicy.
For documents, I believe the preferred behaviour is to use Cache-Control without an Expires header. If both are present the browser will use Cache-Control, so what's the point of having the second header...
Perhaps "deprecated" is too harsh? I can't find a reference that it's actually deprecated in some quick searching.
I need to look into why nginx specifically is returning both.

https://www.fastly.com/blog/headers-we-dont-want
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Expires
https://stackoverflow.com/a/31351596 (Google web.dev advice that's since be updated to not refer to Expires at all)

(mostly a note to myself)
The idea behind the warn_on_fail flag was really to allow warnings for things that are not yet widely supported, or where there's a preference for a specific technique but it's not widely adopted. The COOP, CORP, COEP headers fit well into this category.
I should review these and updated them.

And perhaps this issue is enough to trigger the ability to skip certain checks from the command line or by using a config file.

Yeah, I couldn't find anything that suggests it's deprecated either, other than that Cache-Control basically succeeded it, and has more options for granular control of caching behaviour. I suspect that nginx does it the way it does to be backwards compatible, and that this setting has been in there for quite some time.
One option could perhaps be to allow for bypassing certain checks via, say, --skip-filter or something similar? 🤔 That would allow the tool to run successfully against a target where one is not able to fix specific FAIL conditions, because the software does not support it without major rework.

I have update the check with the following wording:
Expires header should not be used without Cache-Control

This will now pass if both Cache-Control and Expires are set, and should fail if only Expires is set.


Update google-api-services-bigquery to v2-rev20210410-1.31.0

Updates com.google.apis:google-api-services-bigquery from v2-rev20200719-1.30.10 to v2-rev20210410-1.31.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.apis", artifactId = "google-api-services-bigquery" } ]

labels: library-update

Superseded by #420.


Plugin sidebar graphical bug

While navigating through/using the sidebar plugins, a graphical bug starts to cause them to overlap onto each other and essentially cause the plugin sidebar to be totally unusable. Screenshot will be attached below.
To Reproduce for Myself
Steps to reproduce the behavior:

Go to any sidebar plugin
Click on and attempt to use any of the sidebar plugins
They begin to bug out and overlap onto one another

Expected behavior
I expected the sidebar plugins to work as normal. I have another PC with Runelite installed that doesn't have this issue whatsoever.
Screenshots

Alternative links if for some reason the screenshots don't upload:
https://gyazo.com/a37a30da76c75a9962b12c98ee1120da
https://gyazo.com/24eb4d688c83d14d5a432456b925cccb
https://gyazo.com/6486636b5b045654ea7836ae79529bf9
Environment (please complete the following information):

OS: Windows 10
RuneLite version: <IP_ADDRESS>
Launcher version: 2.1.7

Additional context
This graphical bug happens regardless of doing a complete uninstall and deleting all my RuneLite data folders. Have tried CMD Prompting RL, disabling hardware acceleration, etc to try and solve the issue on my end and I'm just stuck... The bug occurs regardless of which plugin interface I am attempting to use, and gets to the point where if I just mouseover the plugin sidebar at all it just starts bugging out causing graphical overlapping.

Duplicate of #11727


Warnings and errors using the integration

My HA throws some warnings and errors on startup and in irregular intervals. The light works well as far as I can see.

Logger: homeassistant.util.async_
Source: util/async_.py:180
First occurred: 3:54:07 PM (1 occurrences)
Last logged: 3:54:07 PM
Detected blocking call to sleep inside the event loop. This is causing stability issues. Please report issue to the custom integration author for awox doing blocking calls at custom_components/awox/awox_mesh.py, line 346: devices = await DeviceScanner.async_find_devices(hass=self.hass, scan_timeout=20)`
`This error originated from a custom integration.
Logger: custom_components.awox.awoxmeshlight
Source: custom_components/awox/awoxmeshlight/init.py:196
Integration: awox (documentation, issues)
First occurred: 3:54:24 PM (1 occurrences)
Last logged: 3:54:24 PM
Timed out connecting to a4:c1:38:xx:xx:xx after 15 seconds.

MAC-Address? anonymized.

This error originated from a custom integration.
Logger: custom_components.awox.awox_mesh
Source: custom_components/awox/awoxmeshlight/init.py:108
Integration: awox (documentation, issues)
First occurred: 3:54:24 PM (1 occurrences)
Last logged: 3:54:24 PM
exception Timed out connecting to a4:c1:38:xx:xx:xx after 15 seconds.
Traceback (most recent call last):
File "/config/custom_components/awox/awoxmeshlight/init.py", line 101, in connect
with self._receiver.event("connect", timeout):
File "/usr/local/lib/python3.10/contextlib.py", line 142, in exit
next(self.gen)
File "/usr/local/lib/python3.10/site-packages/pygatt/backends/gatttool/gatttool.py", line 191, in event
self.wait(event, timeout)
File "/usr/local/lib/python3.10/site-packages/pygatt/backends/gatttool/gatttool.py", line 157, in wait
raise NotificationTimeout()
pygatt.exceptions.NotificationTimeout: None
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/config/custom_components/awox/awox_mesh.py", line 324, in _async_connect_device
if await self.hass.async_add_executor_job(device.connect):
File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/awox/awoxmeshlight/init.py", line 196, in connect
self.btdevice = self.adapter.connect(self.mac, timeout=15)
File "/config/custom_components/awox/awoxmeshlight/init.py", line 108, in connect
raise NotConnectedError(message)
pygatt.exceptions.NotConnectedError: Timed out connecting to a4:c1:38:xx:xx:xx after 15 seconds.

MAC-Address? anonymized.

This error originated from a custom integration.
Logger: custom_components.awox.awox_mesh
Source: custom_components/awox/awox_mesh.py:262
Integration: awox (documentation, issues)
First occurred: 3:54:24 PM (1 occurrences)
Last logged: 3:54:24 PM
Command failed, retry 1

This error originated from a custom integration.
Logger: custom_components.awox.awox_mesh
Source: helpers/update_coordinator.py:201
Integration: awox (documentation, issues)
First occurred: 3:54:27 PM (1 occurrences)
Last logged: 3:54:27 PM
Timeout fetching awox data

Tnx for the feedback. Will check if I can improve something

Got exact same issue. Lamp seems to work but sometimes doesn't respond :(
Lamp Model:
ESMLm-C5-E14 . Version 2.6.30 (HW 4.52)

I have now noticed a short delay before a command is executed. At the same time I had the error messages in the log again. So the lamp seems to be unreachable or disconnected from time to time.

The Bluetooth connection isn't that stable in combo with phyton and the underlying Bluetooth libraries. The connection freezes from time to time and then the integration tries to reconnect and takes some time (the time out you experience).
Wasn't able yet to get it fully stable. Current looking into a different solution using a esp32 board

@dasEtwasmitPunkten can you check the latest (0.1.4) release?


feat: make custom link form accessible ✨

Related Issue
Closes: #278
Description of Changes

Made Custom link form accessible by adding proper labels with associating corresponding input fields using for, id & name attributes.
Additionally we hide them using screen reader only styles, So normal could not able to see the label elements but accessibility devices can able to announce and read them to the disabled user.

Checklist:

[x] My code adheres to the established style guidelines of this project.
[x] I have conducted a self-review of my code.
[x] I have included comments in areas that may be difficult to understand.
[x] I have made corresponding updates to the project documentation.
[x] My changes have not introduced any new warnings.

Screenshots

We can't capture accessibility changes through screenshots as opposed to code changes since accessibility modifications are often imperceptible to the user, as their purpose is to assist disabled individ

Your review is appreciated @apoorvaron 👀

@0xabdulkhalid Just share the screen shot before requesting the review.

The Bug has been solved @apoorvaron

@0xabdulkhalid Why did you remove the Domain name ?


LizardsAndPumpkins\Import\RestApi\CatalogImportApiV2PutRequestHandler::getDataVersionFromRequest() might return int

2018/01/13 00:30:31 [error] 21850#21850: *79 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Uncaught TypeError: Return value of LizardsAndPumpkins\Import\RestApi\CatalogImportApiV2PutRequestHandler::getDataVersionFromRequest() must be of the type string, integer returned in /var/www/lap/vendor/lizards-and-pumpkins/catalog/src/Import/RestApi/CatalogImportApiV2PutRequestHandler.php:109
Stack trace:
#0 /var/www/lap/vendor/lizards-and-pumpkins/catalog/src/Import/RestApi/CatalogImportApiV2PutRequestHandler.php(94): LizardsAndPumpkins\Import\RestApi\CatalogImportApiV2PutRequestHandler->getDataVersionFromRequest(Object(LizardsAndPumpkins\Http\HttpPutRequest))
#1 /var/www/lap/vendor/lizards-and-pumpkins/catalog/src/Import/RestApi/CatalogImportApiV2PutRequestHandler.php(68): LizardsAndPumpkins\Import\RestApi\CatalogImportApiV2PutRequestHandler->createDataVersion(Object(LizardsAndPumpkins\Http\HttpPutRequest))
#2 /var/www/lap/vendor/lizards-and-pumpkins/catalog/src/Http/WebFront.php(53): LizardsAndPumpkins\Import\RestApi\CatalogImportApiV2PutRequestHandler->process(Object(Li" while reading response header from upstream, client: <IP_ADDRESS>, server: demo.lap-demo.de, request: "PUT /fr/api/catalog_import/ HTTP/1.0", upstream: "fastcgi://unix:/var/run/php/php7.0-fpm.sock:", host: "demo.lap-demo.de"

This is a very good question. Should the output type of data version be unified? Should non-string input be allowed?

I think unifying it, makes validation easier and prevents implicit type casts and unexpected behaviour.
So yes, let's unify it.

What if JSON will contain an array, null, boolean or some other non-sense?

Correct me if I'm missing something out: We want a string in the end.
So there are three options

We cast it explicitly (intransparent for user)
PHP casts it implicit (intransparent for user and us)
they submit a string

So I would throw an exception


Add Snippet Contributor titles.

Snippet Contributors do not have titles available to them.
TODO:
Add an optional field to snippet contributors that are for the contributor's title i.e. GM, student, etc.
Add the snippet contributor titles to the bylines in the templates when available.

Got the title fields working for contributors. Would like some more details on adding them to the template

Can you clarify from a front-end perspective how the titles would be displayed? Maybe similar to the labels on Github?

You could make it so the labels that are already present just become hrefs to like categories? Does that make sense?

Do you mean a category page for a specific title?


The folders are not deleted if running on a multi-node cluster

I used this provisioner on a 3 nodes k8s cluster. I ran a daemonset with replica=3 on the cluster with the volumeclaimtemplates declared in the yaml file. Each time I deployed the application, it will create 3 PVCs and associated PVs across the node. When I delete the application(PVCs as well), I can see it will only cleanup the folder which is mounted to the same node where the "hostpath-provisioner" pod is scheduled. I checked the code which I expected is normal behavior: https://github.com/MaZderMind/hostpath-provisioner/blob/fe8ab311ab0cf51f97a81764dccc4bd5c8b15040/hostpath-provisioner.go#L133
However the folders created on the other two nodes are not been deleted. Is there a way to clean up all folders across the nodes when we delete the PVCs?

Hi
I have no idea. I do not even run a Kubernetes productively anymore.
This Reposirory and Code is #Unmaintained. You should not use it in production.


Metadata file for Hooligan Labs Airships

Initial Metadata file for Hooligan Labs Airships

Hi there! I'm very interested in this, as I was very fond of this mod in earlier versions of KSP. I know that JewelShisen is determined not to have HLAirships on CKAN, and has loaded HLAirships up on Spacedock now with an "All Rights Reserved" license (I'm not sure what the legal position is about reverting HLAirships to ARR having clearly received significant code contributions from yourself and others, including the original development by Hooligan Labs, but that's for you other contributors to take up).
If you plan to maintain this as an ongoing fork from the clean MIT-licensed code, could you create a new forum thread, so that people aren't getting confused and going to JewelShisen for support? The homepage thread you have listed here is a locked thread, which will end up directing users to JewelShisen's thread, and I'm assuming that the codebases will start to diverge.
There is an existing identifier, "HooliganLabsAirships", which I think could be reasonably used, given that this is the direct continuation of the original Hooligan Labs code, under its original license, and JewelShisen is certainly not wanting to use the identifier. To switch to that, rename this file to "HooliganLabsAirships.netkan", change the identifier, and delete "HooliganLabsAirships.frozen" from the NetKAN folder in your branch.
There's also a little confusion in your github source and zip file naming, as to whether this is HLAirships or HLAirshipsRedux?

I'll talk to the other contributors and get back to you. I updated the code for the plugin from the original source, but I'm not sure of the history of the art assets. I'd rather just have one common project that we all contribute to instead of different forks.

Talked to the other contributors and they agreed to release to CKan.
I updated the netkan to point to the Spacedock release point and the ARR license and latest forum thread.

Ok, if that's the route you're taking, you will need to change
"x_netkan_license_ok": true,

to
"license": "restricted",

And you can then remove the "name", "abstract", "ksp_version" and "resources" elements, as all that data can be drawn from Spacedock

Might also be good to talk to JewelShisen about release version naming consistency. On Spacedock, there is "V_5.0" followed by "5.1". Won't be an issue immediately, because netkan won't inflate that older release, but if it had, "V_5.0" would be considered the latest release, since "V" comes after "5". There's a method we have for fixing such issues, but it's a manual process every time the version prefixes change in a way that breaks the ordering.

Thanks - this is my first attempt at creating a Ckan release file. I'll make the updates

OK, I think I've sorted out the naming and it should be good to go.

No sorry, the identifier can't be changed from one to the other. It has to be 'HooliganLabsAirships.netkan' with an install stanza.

We standardized on the identifier of "HLAirships" for the directory, plugin and identifier. Will that not work?

Leave a comment

We don't abandon old identifiers. They're mostly hidden from the users, so they aren't that critical. Have a look at #4053. I think that's about right.

I've removed the hard dependency on Toolbar.
That install stanza passes the local check

Looks good to me, merging with my thanks.


grafana: 6.2.0 -> 6.2.1

Motivation for this change
Latest patch release that includes a few bug fixes and two enhancements.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS (x86_64-linux & aarch64-linux)
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

needs to be backported to 19.03

@GrahamcOfBorg test grafana


Make webpack loader available for configuration

Category
[ ] Question
[ ] Typo
[x] Bug
[x] Enhancement / Suggestion
[ ] Additional article idea
Expected or Desired Behavior
Currently the use of the new SharePoint Framwork has only limited use. When a custom web pack loader is required I can define my own web pack configuration. In this case all needs to be handled manual.

It is on the roadmap.  We'll comment soon in more detail.

Posted a while ago on how to do this.  Marking as resolved.  (https://github.com/SharePoint/sp-dev-docs/wiki/Extending-Webpack)


attributes in category page and in search now are ordered

Issue Reference

Description

When I created a few attributes and added their options with the correct sort order it doesn't get sorted correctly in the search page. Turns out it just needed to be sorted.
I kindly ask you to merge this because it is quite important, especially when we have filters that has to be sorted for example the age groups of clothing products.
How To Test This?

Documentation

[ ] My pull request requires an update on the documentation repository.

Branch Selection

[ ] Target Branch: master

Pint

Tailwind Reordering

Hello @0x76db ,
I've reviewed your pull request and appreciate your contribution to Bagisto.
I am unable to reproduce the issue you mentioned in the pull request. Could you please provide more details on how to reproduce the issue, including screenshots or videos if possible?
Thank you.

You have to create a filterable attribute.
Add a few option to the attribute with a specific sort_order from the admin area or using raw database
Create them in random order for example create the 3-5 age range after 6-11. So that the id of the attribute option is lower.
Go on the search page and see that the returned attribute's options are not sorted.

Hello @0x76db,
Thank you for your information.
As per your information, i have followed all the steps one by one and after that, i was unable to see the error. Also, I have recorded the video for the same for you reference.
Please check and feel free to tell us if I skipped any steps as per your information.
Reference Video

I'm sorry I forgot a step.
If you go now and in DB put the sort_order of 3-5 age as 0 and 6-11 to 1 the order should be flipped, which will not happen.


Add SessionSetup::OrbitServiceInstance class

This class will be used in the next PR to start OrbitService from Orbit Client.
To get an idea how this will be used: https://github.com/antonrohr/orbit/tree/test_exec_orbitservice (still work left todo around UI and error handling).

Rebased to fix builds


react-native-hms-push  in processDebugMainManifest FAILED

Hi guys,
i got error, when i run android
 Task :app:processDebugMainManifest FAILED [:react-native-hms-push]<EMAIL_ADDRESS>Warning:         Package name 'com.huawei.hms.rn.push' used in: :react-native-hms-push, :hmscore_react-native-hms-push.
Please let me know if there's a way to get this to work
Thanks!

Hi @kittipat3699, we couldn't reproduce your issue with our demo application. Can you please share a detailed log and minimal reproducible project to investigate the issue further.
Thank you for your interest.


Add dmage and myself for pkg/image approvers, and myself to pkg/operator

/assign @sttts

/approve

/lgtm

/cherrypick release-4.9


FastAnonymous doesn't work on Julia v0.5-

> g = @anon x->(x+offset)^2

ERROR: eval cannot be used in a generated function
 in getclosure(::Tuple{Symbol}, ::SimpleVector) at /Users/johan/.julia/v0.5/FastAnonymous/src/FastAnonymous.jl:110
 in closure(...) at /Users/johan/.julia/v0.5/FastAnonymous/src/FastAnonymous.jl:86

It does work if offset is hardcoded (g = @anon x->(x+1.2)^2). But that doesn't provide any speed-improvement, v0.5 is just as fast on its own.

Fixed now, but rather belatedly. Sorry I didn't notice this earlier.


Chunkwm not working after a while - Mac High Sierra 10.13.4

Chunkwm started to stop working after khd started to stop receiving hot key.
Restart the computer cause chunkwm to stop working, this have happened for several times already, I tried to reinstall chunkwm and restart it or reset LaunchAgents and LaunchDaemon of chunkwm, sometimes it worked, sometimes it did not.
I followed instruction with KeyChain certificates option described in issue #295, it worked for several weeks and stop working again, I believe the problem is about the accessibility of new update from mac

Thank you for helping me.

This definitely sounds like an issue with the accessibility access.
Try to remove both chunkwm and khd from the list of accessibility access.
Restart the computer.
Run chunkwm and accept the prompt and give it accessibility access.
Restart chunkwm (brew services restart chunkwm)
Do the same for khd.
Hopefully that works, as I don't really have any other suggestions.
I can't say I have had issues with this myself, but I do codesign the binaries myself after compiling (using method described in #295).

@lstrgiang did you find out what the issue was?

@zifeo No I did not. I created a script to reinstall and restart everything. This happen once a week. Sometimes, I switch from khd to skhd and it last for around 3 weeks. Then skhd stop working, and I'm back with khd.

Now, I cannot get it back to work 😞

@lstrgiang Thanks for the update, I've tried to reset my keychain but eventually it was the "distinct spaces" option that got unticked (see #424).

Referenced issue should contain enough information to resolve this, closing.


Otel support in REST

Support OpenTelemetry in our REST interactions (across client/server).
Refactoring the codebase to use contexts more idiomatically (at the moment we pass them into nodes as part of their constructor). And then the plan is to thread the trace IDs around using contexts, which should magically work
Goal: be able to view traces from our production network in honeycomb.

See also: https://github.com/filecoin-project/bacalhau/issues/97


Write GeoTiff docs page discuss 3-band

Need to describe how one /three /many tile columns  are going to be interpreted in the writer.

Current implementation:

1, 2, 5 or more bands: greyscale
3 bands: RGB
4 bands: RGBA (when colorspace is RGB and 4 bands are provided, the last is implicitly interpreted as the alpha channel)

https://github.com/locationtech/rasterframes/blob/36be70056fa01001bc3df006a4ea5655640c2d58/datasource/src/main/scala/org/locationtech/rasterframes/datasource/geotiff/GeoTiffDataSource.scala#L152-L155

Discussed this in #430


CLI: print trace URL at the bottom

Problem
dagger call prints the URL to a full trace (or to traces setup, if logged out). It does so at the top of the output, which is cumbersome in practice. When I want to investigate a problem, usually it's after a fairly large and complex pipeline, so I need to scroll up past a large and complex output. After running a few of these in a row (very common), it's easy to scroll too far, and get lost: "is this the last trace, or the one before"? It adds to the confusion and gets in the way of resolving my issue.
Solution
Print the trace at the URL instead. If I need it, it's right there.

I recall we discussed about this in the #Daggerize the world forum and the argument against having it at the end was that it felt unatural when your function had an output to show the trace URL right below that. I guess we're ok with overriding that decision now? cc @levlaz @jpadams

To be clear I would like the trace URL to be at the end of the lingering output from the TUI, but before printing the actual output to stdout.

Hi @shykes,
I think something like below is what we are looking for right?:
$ hack/with-dev dagger call -m github.com/shykes/hello
✔ connect 0.2s
✔ initialize 16.4s
✔ prepare 0.0s
✔ hello: Hello! 0.0s
✔ Hello.hello: String! 0.1s

Full trace at https://dagger.cloud/rajatjindal/traces/fb6bfb6ded2d489465638885703985c5

_type: Hello
hello: hello, world!

instead of
$ dagger call -m github.com/shykes/hello
Full trace at https://dagger.cloud/rajatjindal/traces/a9d458369b7f8e0d528b0977b49f81df

✔ connect 2.0s
✔ initialize 1.9s
✔ prepare 0.0s
✔ hello: Hello! 0.0s
✔ Hello.hello: String! 0.3s

_type: Hello
hello: hello, world!

@rajatjindal yes exactly.
If we worry that it will be too verbose, we could try small refinements like:
(pseudo code)
if (user is logged in) {
   print the trace url
} else {
  if command was not 'call' or 'run' {
    print nothing
  } else if stderr is empty {
    print nothing
  } else {
    print the trace url
  }

}
only printing the trace message if stderr is non-null. That way, you get the trace when things fail (which is usually when you want it).

Hi @shykes, thanks for confirming.
IMO, we already provide an easy way for user to disable the traces using env variables (when they are not logged in), and should probably avoid adding more conditionals to print that URL.
Also, as an enduser, I think that URL is still useful for any command that makes a request to server, so I would suggest to keep them as it is as well.
Following are some of the sample output with latest changes:
With Pretty Frontend
$ ./dagger call -m github.com/shykes/hello
✔ connect 0.2s
✔ initialize 1.5s
✔ prepare 0.0s
✔ hello: Hello! 0.0s
✔ Hello.hello: String! 0.1s

Full trace at https://dagger.cloud/rajatjindal/traces/990e580a8edd01594c21bdc8b3f2527e

_type: Hello
hello: hello, world!
$ dagger logout
$ ./dagger call -m github.com/shykes/hello
✔ connect 0.3s
✔ initialize 1.8s
✔ prepare 0.0s
✔ hello: Hello! 0.0s
✔ Hello.hello: String! 0.2s

Setup tracing at https://dagger.cloud/traces/setup. To hide: export SHUTUP=1

_type: Hello
hello: hello, world!
$ SHUTUP=1 ./dagger call -m github.com/shykes/hello
✔ connect 0.2s
✔ initialize 2.2s
✔ prepare 0.0s
✔ hello: Hello! 0.0s
✔ Hello.hello: String! 0.2s

_type: Hello
hello: hello, world!

with progress plain
$  ./dagger call -m github.com/shykes/hello --progress=plain
1   : connect
2   :   connecting to engine
2   :   | engine name=0fc470e4c88a version=v0.13.0-010101000000-dev-1579a140ad52 client=y0nufm9f4e87iymfiakq3tned
2   :   | cloud url=https://dagger.cloud/rajatjindal/traces/59c66a0aeef591ca1e05124763c71dd5
2   :   connecting to engine DONE [0.1s]
3   :   starting session
1   : connect DONE [0.2s]

4   : initialize
5   :   resolving module ref
6   :   installing module
7   :   analyzing module
5   :   resolving module ref DONE [1.4s]
7   :   analyzing module DONE [0.1s]
4   : initialize DONE [1.6s]

8   : prepare
8   : prepare DONE [0.0s]

9   : hello: Hello!
9   : hello DONE [0.0s]

10  : Hello.hello: String!
10  : Hello.hello DONE [0.1s]

Full trace at https://dagger.cloud/rajatjindal/traces/59c66a0aeef591ca1e05124763c71dd5

_type: Hello
hello: hello, world!
$ ./dagger logout
$ ./dagger call -m github.com/shykes/hello --progress=plain
1   : connect
2   :   connecting to engine
2   :   | engine name=0fc470e4c88a version=v0.13.0-010101000000-dev-1579a140ad52 client=oh8k4agdx9bz58q4aybc4euas
2   :   | cloud url=https://dagger.cloud/traces/setup
2   :   connecting to engine DONE [0.1s]
3   :   starting session
1   : connect DONE [0.2s]

4   : initialize
5   :   resolving module ref
5   :   resolving module ref DONE [1.4s]
6   :   installing module
7   :   analyzing module
7   :   analyzing module DONE [0.1s]
4   : initialize DONE [1.6s]

8   : prepare
8   : prepare DONE [0.0s]

9   : hello: Hello!
9   : hello DONE [0.0s]

10  : Hello.hello: String!
10  : Hello.hello DONE [0.1s]

Setup tracing at https://dagger.cloud/traces/setup. To hide: export NOTHANKS=1

_type: Hello
hello: hello, world!
$ SHUTUP=1 ./dagger call -m github.com/shykes/hello --progress=plain
1   : connect
2   :   connecting to engine
2   :   | engine name=0fc470e4c88a version=v0.13.0-010101000000-dev-1579a140ad52 client=c5yz812mvltfraqwbgisewt2x
2   :   | cloud url=https://dagger.cloud/traces/setup
2   :   connecting to engine DONE [0.1s]
3   :   starting session
1   : connect DONE [0.2s]

4   : initialize
5   :   resolving module ref
6   :   installing module
7   :   analyzing module
5   :   resolving module ref DONE [1.5s]
7   :   analyzing module DONE [0.1s]

8   : prepare
8   : prepare DONE [0.0s]

4   : initialize DONE [1.7s]

9   : hello: Hello!
9   : hello DONE [0.0s]

10  : Hello.hello: String!
10  : Hello.hello DONE [0.1s]

_type: Hello
hello: hello, world!

Makes sense @rajatjindal ! What commands would trigger a url print? run and call?

What commands would trigger a url print? run and call?

I think following commands makes the request to engine (which I realize now is essentially every dagger command though :) ):
DAGGER MODULE COMMANDS
  call          Call one or more functions, interconnected into a pipeline
  config        Get or set module configuration
  core          Call a core function
  develop       Prepare a local module for development
  functions     List available functions
  init          Initialize a new module
  install       Install a dependency

EXECUTION COMMANDS
  query         Send API queries to a dagger engine
  run           Run a command in a Dagger session

I think we should include these commands:

call
core
run
query

From the user's point of view, these commands run their pipelines, and linking to a trace makes sense. The other commands, even though technically they call the API also, don't fall in this category, and linking to a trace might be too intrusive. Not worth the risk of annoying users.


IB Designable Failed to render and update

Hi,
I just created a single view project, added a view to the main view controller, set it has CardHighlight then added a second View Controller with some text.  I get the following error:
IB Designables
Failed to render and update auto layout status for ViewController dlopen(Cards.framework), 1) Library not loaded: @rpath/Player.frameworks/Player
Is there something else I should load via CocoaPods like Player?  The link to Player on your Readme doesn't work.
Thanks,
Dave

Ok cleaning build, deleting derived data and restarted Xcode cleared this message.


Alfred Bear workflow may not work with Bear 2.x

After updating Bear from 1.x to 2.x I experience the following behavior in the Alfred workflow.

1. I type bs in order to find something in Bear:

2. As soon as I type a space and try to search for that phrase, Search Bear Notes disappears:*

Could you confirm if this applies to you as well, or is it just me?

I definitely have at least one note containing the word “hello”

Please follow the steps here to post the debug information you get:
https://github.com/drgrib/alfred-bear/issues/56#issuecomment-1546733678

This is the error I get when running the workflow with debug:
[19:34:33.926] Logging Started...
[19:34:36.948] Bear[Script Filter] Queuing argument ''
[19:34:37.025] Bear[Script Filter] Script with argv '' finished
[19:34:37.028] ERROR: Bear[Script Filter] Code 2: panic: no such table: Z_7TAGS

goroutine 1 [running]:
main.main()
	/Users/credford/Dropbox/Alfred/Alfred.alfredpreferences/workflows/user.workflow.48B0F8E6-2BC8-4EB9-B35E-1DBB820AA8E7/cmd/search/main.go:29 +0x5e9

Correction: are you sure you are using the latest release of alfred-bear? This sounds like an error you would get if you ran an old version.

Hmm. Are you sure you are running Bear 2.x? This sounds like an error you would get if you ran 1.x.

Absolutely.

Please refer to my second comment.

Correction: are you sure you are using the latest release of alfred-bear? This sounds like an error you would get if you ran an old version.
Note that you are getting the exact same error as someone else who tried to run the old version on the new Bear: #56 (comment)

Gonna try to reinstall the existing workflow, download the current one, and install it, then I will report.

OK Chris, case closed, the latest one works. Sorry about bothering you. Peace, love.
Adam

No worries. Happy to hear the issue is solved. Having this here as a placeholder may help other people with the same issue.

No worries. Happy to hear the issue is solved. Having this here as a placeholder may help other people with the same issue.

Stil, I love this workflow. This is an awesome one.


Network Folder Display Slow

Description
Very slow in comparison to File Explorer
I have a LAN with 10 Win 11 machines
FE displays in 2-4 sec
Files displays in 10-20 s
Order of magnitude difference
Concerned code
N/a
Gains
improved UI performance
Requirements

eg. Using a specific design pattern.
eg. Separating Interface I into three new interfaces I1, I2 and I3.
eg. Regrouping the duplicated process into a new helper.

Comments
No response

Thank you for your feedback, we're tracking this and other optimizations in #12014.


Remove bundled node version from version command

We're not bundling node anymore.

we are not? :S

@abresas Nope, we decided long ago to remove the bundling and instead make the installers take care of getting node in the user's system first.

LGTM then


Spawn a captain manually

I add to the loot table an item and want to test it, but can't find any command to summon a captain, did the datapack have one ?
And i accidentally transform myself has a captain and can't remove it, did you have any idea on how to remove on myself ?
PS: your datapack is so cool, everyone on our server love it. Thank you for it

Hey!
You can’t directly spawn them, you rather convert a mob to a captain. To convert a zombie into a legendary mob captain, run the following command while standing next to it:
execute as @e[type=zombie,limit=1,sort=nearest] run function ps-mob:convert/legendary

You can change the type and rarity to your needs

In this issue are commands to un-MobCaptainify yourself
Thank you! Glad you and your friends are enjoying the pack :D

Thank you so much for your quick answer, that exactly what we wanted!


Plugins

As annotation provider i want flexibility in what data types and how they can be annotated.
Acceptance Criteria

[ ] research iFrame communication

[ ] simple iFrame based prototype

[ ] Annotation Workflow

[ ] embed iFrame

[ ] HXV is hosted by Synios

[ ] HXV in iFrame

read list of observation ids

url parameter ecgviewer?observationId= to fhir ecg

Example: ecgviewer/?observationId=a21fdf12-ee3f-42a5-9f02-fd3bd05a314a&practitionerId=90d60f58-8de5-4359-a1c6-be2a40d5e065&diagnosticReportId=624da275-5720-4156-bebd-0556e0f8fcf7

Questions:

get ECGs that are not annotated yet

check whether new annotation has been created (to check if the annotation process was "successful")

documentation for all of this?

wie wird das gehandelt falls eine observation mit report nochmal annotiert wird?

version-id bei diagnostic - was ist das?
corrected - was ist das?

müssen wir selber annotator anlegen?

wie ist das mapping von observation und diagnostic-report? ist das das result/reference-feld?

Also maybe useful: https://app.mural.co/t/sonjasworkspace3012/m/sonjasworkspace3012/1653285867079/fe580d581d196de77ea6a23f8b96044542c0140c?sender=dutz5117


New version: Netease.CloudMusic version <IP_ADDRESS>543

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run


[FLINK-33089] Drop support for Flink 1.13 and 1.14 and clean up related codepaths

Drop support for Flink 1.13 and 1.14 and clean up related codepaths

What is the purpose of the change
(For example: This pull request adds a new feature to periodically create and maintain savepoints through the FlinkDeployment custom resource.)
Drop support for Flink 1.13 and 1.14
Brief change log
(for example:)

Periodic savepoint trigger is introduced to the custom resource
The operator checks on reconciliation whether the required time has passed
The JobManager's dispose savepoint API is used to clean up obsolete savepoints
Remove 1.13/1.14 in crd

Verifying this change

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changes to the CustomResourceDescriptors: (yes / no)
Core observer or reconciler logic that is regularly executed: (yes / no)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc @gyfora

We can’t delete those enums as that would break the k8s clusters . It is already handled in my previous PR if you look carefully

We can’t delete those enums as that would break the k8s clusters . It is already handled in my previous PR if you look carefully

Thanks for the reminder


deactivate eats PATH

Following a call to deactivate, the PATH environment variable is left blank. This prevents any further calls to activate (or anything else for that matter). Note: the environment was existing prior to installation of pscondaenvs.
To reproduce:
PS src> conda install -n root -c pscondaenvs pscondaenvs
<...>

The following NEW packages will be INSTALLED:

    pscondaenvs: 1.2.2-hbdbce43_0 pscondaenvs

Proceed ([y]/n)? y

Use 'activate <envname>' or 'deactivate <envname>' in Powershell to manage the current environment.

PS src> $env:PATH
<current system path...>
PS src> activate streakgui
(streakgui) PS src> $env:PATH
<slightly modified path...>
(streakgui) PS src> deactivate

Deactivating environment "streakgui..."

PS src> $env:PATH
PS src> conda
conda : The term 'conda' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ conda
+ ~~~~~
    + CategoryInfo          : ObjectNotFound: (conda:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

PS src> python
python : The term 'python' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ python
+ ~~~~~~
    + CategoryInfo          : ObjectNotFound: (python:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

PS src> explorer
explorer : The term 'explorer' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ explorer
+ ~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (explorer:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

pscondaenvs version: 1.2.2
Conda version: 4.3.30
Powershell version: 5.1.16299.64
python root version: 3.6.2.final.0
Win 10 home 64bits

@spalato, I cannot reproduce your problem. Please run deactivate -verbose and provide the output.
PSCondaEnvs 1.2.2
Conda version: 4.4.11
Powershell version: 5.1.16299.248
Python root version: 3.6.2.final.0
Win 10 Pro 64bits, version: 1709

@BCSharp Sorry for the delay
(streakgui) PS src> $Env:PATH -split [System.IO.Path]::PathSeparator
C:\Users\samue\Anaconda3\envs\streakgui
C:\Users\samue\Anaconda3\envs\streakgui\Library\mingw-w64\bin
C:\Users\samue\Anaconda3\envs\streakgui\Library\usr\bin
C:\Users\samue\Anaconda3\envs\streakgui\Library\bin
C:\Users\samue\Anaconda3\envs\streakgui\Scripts
C:\Program Files\ImageMagick-7.0.7-Q16
C:\Program Files (x86)\Intel\iCLS Client\
C:\Program Files\Intel\iCLS Client\
C:\Windows\system32
C:\Windows
C:\Windows\System32\Wbem
C:\Windows\System32\WindowsPowerShell\v1.0\
C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL
C:\Program Files\Intel\Intel(R) Management Engine Components\DAL
C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\IPT
C:\Program Files\Intel\Intel(R) Management Engine Components\IPT
C:\Program Files\Intel\WiFi\bin\
C:\Program Files\Common Files\Intel\WirelessCommon\
C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common
C:\WINDOWS\system32
C:\WINDOWS
C:\WINDOWS\System32\Wbem
C:\WINDOWS\System32\WindowsPowerShell\v1.0\
C:\ProgramData\chocolatey\bin
C:\Program Files\OpenSSH-Win64
C:\Program Files\Git\cmd
C:\Program Files\MATLAB\R2017b\bin
C:\Program Files\PuTTY\
C:\Users\samue\Anaconda3
C:\Users\samue\Anaconda3\Library\mingw-w64\bin
C:\Users\samue\Anaconda3\Library\usr\bin
C:\Users\samue\Anaconda3\Library\bin
C:\Users\samue\Anaconda3\Scripts
C:\Users\samue\AppData\Local\Microsoft\WindowsApps
C:\Program Files\Microsoft VS Code\bin
C:\ffmpeg\bin
C:\Users\samue\AppData\Local\Julia-0.6.0\bin

(streakgui) PS src> $CondaEnvPaths
C:\Users\samue\Anaconda3\envs\streakgui
C:\Users\samue\Anaconda3\envs\streakgui\Library\mingw-w64\bin
C:\Users\samue\Anaconda3\envs\streakgui\Library\usr\bin
C:\Users\samue\Anaconda3\envs\streakgui\Library\bin
C:\Users\samue\Anaconda3\envs\streakgui\Scripts
(streakgui) PS src> deactivate -verbose

Deactivating environment "streakgui..."

Just tried with a clean environment, and it works correctly. Let me have a look...

The already created environment had a lost 'deactivate.ps1' under Anaconda3\envs\streakgui\Scripts\.
Issue fixed, thanks!


Add a search option to search the map by places

Browsing the map you wish to be able to search for a place like on the main screen.

Or we don't do it after thinking about it longer than 2 minutes 😅


ADFT0015: Type [managedVirtualNetwork\default\managedPrivateEndpoint] is not supported

Doing deployment from Powershell. It actually works if you don't have to change anything inside the resource json. It blows up when you need to change something:
- [managedVirtualNetwork].[default]
- [managedVirtualNetwork\default\managedPrivateEndpoint].[pe1]
- [managedVirtualNetwork\default\managedPrivateEndpoint].[pe2]
===================================================================================
STEP: Replacing all properties environment-related...
Config file:   ./deployment/params_Dev.json
Write-Error: C:\Users\gshapiyev\1\Documents\PowerShell\Modules\azure.datafactory.tools\0.95.1\private\Update-PropertiesFromFile.ps1:65:19
Line |
  65 |  …    $objArr = Get-AdfObjectByPattern -adf $adf -name $name -type $type
     |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | ADFT0015: Type [managedVirtualNetwork\default\managedPrivateEndpoint] is not supported.

I was able to get around the issue by adding another case in the switch in \private\Get-AdfObjectByPattern.ps1
        'managedPrivateEndpoint'
        {
            $r = $adf.ManagedPrivateEndpoints | Where-Object { $_.Name -like $name }
        }
        'managedVirtualNetwork\default\managedPrivateEndpoint'
        {
            $r = $adf.ManagedPrivateEndpoints | Where-Object { $_.Name -like $name }
        }
        default

Related to #185

For the record:
The issue only happens when the config comes from JSON file.


CERTIFICATE EXPIRED for botkit.ai

** DO NOT ERASE THESE INSTRUCTIONS WITHOUT READING THEM FIRST **
Please read this entire template before posting any issue to get faster response.
Open an issue on this repository with your topic or question, providing as much detail as possible. The more we know, the better we can help.
Before posting, search the repository to see if there's already an issue opened to avoid duplicates.
Are you sure this is an issue with the Botkit core module?
For all other questions, requests or help, please feel free to join the discussion slack : https://community.botkit.ai
What are you trying to achieve or the steps to reproduce?
Describe your issue here, include as much detail as necessary to reproduce the issue or implement a missing functionality.
// Wrap code in markdown source tags

What was the result you received?
What did you expect?
Screenshots and animated GIFs

Context:

Botkit version:
Messaging Platform:
Node version:
Os:
Any other relevant information:

@benbrown Can we add certbot or something if possible to ensure auto renewal?

Its supposed to be automated! I'm not sure why it fails from time to time.

Hi @benbrown I know we removed the references of the site now. But can we deploy it using GitHub pages?
I did open an issue with possible solutions https://github.com/howdyai/botkit/issues/2180
Let me know if we can help with anything.


chore: add issue and pr templates

The change provides the guidance for contributors to open issue and pr.

Thanks !
It seems the project check failed because of whitespace errors.
BTW, the snapshotter also needs these templates. Would u mind creating a PR for it?

@BigVan thanks for the review. I fixed the whitespace. Once it's approved and merged, I will send a similar pr on accelerated-container-image

LGTM


Turn off no-redundant-type-constituents

Please consider this pattern that is considered illegal with this rule:
process.on('uncaughtException', (err: Error | any) => {...} (Source)
It's true that this pattern is technically meaningless but I think it has a nice semantic hint of "This should be of type Error, but we'll accept anything". WDYT?


Logging in hooks creates a deadlock

GoVersion: 1.10
Version: 1.0.7
How do you create a log from the same level in a hook?
The example below seems to create a deadlock.
main.go
package main

import (
	"fmt"
	"github.com/sirupsen/logrus"
)

func main() {
	logrus.AddHook(NewHook())
	logrus.Info("Something")
}

hook.go
package main

import (
	"github.com/sirupsen/logrus"
)

type testHook struct {
}

func NewHook() *testHook {
	return &testHook{}
}

func (t *testHook) Fire(entry *logrus.Entry) error {
	entry.Logger.Info("Something")

	return nil
}

func (t *testHook) Levels() []logrus.Level {
	return logrus.AllLevels
}

The mutex is used to protect the entry from concurrent access. What are you trying to achieve ? A solution would to perform this log in another goroutine, another would be to use another logger instance. The current implementation does not allow to very easily add a per Entry mutex.

@haeky did you succeed to overcome your issue ?


How to use with Jest

I may be doing something stupid, but I'm getting this even on the README example using jest:
test("should ", () => {
  expect("x").toBe("x")
  doctest("src/sum.js") //?
})

results from Jest runner:
 TypeError: doctest is not a function

      3 | test("should ", () => {
      4 |   expect("x").toBe("x")
    > 5 |   doctest("src/sum.js") //?
        |   ^
      6 | })
      7 |

I haven't actually tried with Jest, but it should work fine. Do you have an existing repo where I can see the code/error (no problem if you don't, I can create).
Just to check, you definitely have import doctest from '@supabase/doctest-js'  at the top of your file?

I think it may be a windows/path issue (i've seen this kind of error before):
Cannot find module 'C:UsersloganProjects\tutorialsTDDsrcsum.js'
Require stack:
-<EMAIL_ADDRESS>- .\src\sum.test.js
  at evalExpression ./node_modules/@supabase/doctest-js/dist/index.js:571
  at exports.default ./node_modules/@supabase/doctest-js/dist/index.js:571
  at ./node_modules/@supabase/doctest-js/dist/index.js:124
  at t.default ./node_modules/@supabase/doctest-js/dist/index.js:124
  at Object.<anonymous> src/sum.test.js:4:0

here's the code
// src/sum.test.js

import doctest from "@supabase/doctest-js"
import { sum, product, bloop, bleep, blop } from "../lib/sum"

doctest("src/sum.js") //?

test("sum:", () => {
  expect(sum(4, 3)).toBe(7)
})

// src/sum.js

/**
 * Returns the sum of 2 numbers
 *
 * @example sum(1, 2)
 * //=> 3
 */
export const sum = (a, b) => {
  return a + b
}

Aha! Good find. I have a windows machine somewhere - let me dig it up and see if I can fix this

Closed by #73.


(Another!) data race: iree_task_worker_try_steal_task vs iree_task_executor_destroy

TSan report
This might be the same as #8863?
During teardown, one worker is trying to steal work while the main thread is already destroying the executor.
Reproduce: cmake -DIREE_ENABLE_TSAN=ON and run these tests hundreds of times in parallel (running multiple tests in parallel introduces timing fluctuations that are in my experience key to triggering TSan failures).
ctest -j128 --timeout 30 -R iree/hal/dylib/cts/dylib --repeat-until-fail 100

This particular failure occurred in dylib_buffer_mapping_test  but it is harder to reproduce in a ctest command running only that test.

This really was the same as #8863.


(FACT-1821) Fix AIX memory fact

Cherry-picked from https://github.com/puppetlabs/facter/pull/1733.
To determine the AIX memory fact, several devices are queried. In some
cases, an error was thrown (ENXIO) that was not caught. This handles
that error when it occurs.
Additionally, this will now debug-log devices that cannot be used, and
the error number from trying to use it.

Merging pre-travis because:

This is a cherry-pick of something that's already been linted etc.
This is AIX-specific code, so build/test won't run it


Registration Exception Only when Publish site on IIS

Hi There!
I am getting the Exception :
{"error":["Error constructing handler for request of type MediatR.IRequestHandler`2[Wateration.Application.UseCases.Customers.Queries.GetCustomerDetailsQuery,Wateration.Application.UseCases.Customers.Models.CustomerOutputModel]. Register your handlers with the container. See the samples in GitHub for examples."],"stackTrace":"   ........
But this happens only when the site is published on IIS. On the IISExpress and on the IIS published on the development machine it works fine!! I Have checked SDK and Run-time versions as well as any versioning conflicts and there is no problem there! Any Help????

Nevermind figured out and solved it.

Please post the solution to the problem, if others should have the same issue in the future.

Could be that you're not explicitly passing in the types to scan?

Hello - I am facing exactly same issues. can you please advise the solution. Thanks in advance.


POL-326 Fix pagination controls as per the UXD - Tables doc

//cc: @lahavyuv86 @katierik

Codecov Report

Merging #187 into master will decrease coverage by 0.04%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   89.14%   89.10%   -0.05%
==========================================
  Files         114      114
  Lines        2396     2404       +8
  Branches      429      430       +1
==========================================
+ Hits         2136     2142       +6
- Misses        258      260       +2
  Partials        2        2

Impacted Files
Coverage Δ

src/pages/PolicyDetail/hooks/useTriggerPage.ts
81.81% <83.33%> (-0.95%)
:arrow_down:

src/pages/PolicyDetail/PolicyDetail.tsx
99.12% <93.33%> (-0.88%)
:arrow_down:

src/components/Trigger/TableToolbar.tsx
92.15% <100.00%> (+0.32%)
:arrow_up:

@josejulio I'm noticing in these screenshots that the spacing on the toolbar is not correct.
The red spacing is extra and not needed (it is causing the toolbar not to align). The blue spacing should only be a total of 16px.

Is this the frontend-components toolbar? (There was an open bug about fixing the spacing on that one so if it is we should be able to inherit?)

Ok cool so we'll keep an eye on it to make sure that spacing bug fix gets to us


Remove the global lock around building gems

We use a global monitor to synchronize building gems. In older versions of RubyGems, build options were set in a global variable, so we have to do that to make installing gems thread-safe.
In more recent versions of RubyGems, those options can be passed to each individual Gem::Install instance. On those versions of RubyGems, we should be able to remove the global lock and allow multiple gems to be built at the same time. Test carefully, because we may also need to fix thread-safety bugs in Gem::Install for this to work.

I believe this is one of the issues pulled over from Trello, so I can't be completely sure about what the original intent was


V0.1 BundleWithImage

Add image resources to the µLibrary for the Dox/Dialer icon.

did you want to add comments for the dialPhoneNumber method in this PR or another one?

next one, coming as soon as this is merged


Add 'Color::as_lcha' function (#7757)

Objective
Fixes #7757
New function Color::as_lcha was added and Color::as_lch_f32 changed name to Color::as_lcha_f32.

As a side note I did it as in every other Color function, that is I created very simillar code in as_lcha as was in as_lcha_f32. However it is totally possible to avoid this code duplication in LCHA and other color variants by doing something like :
 pub fn as_lcha(self: &Color) -> Color {
    let (lightness, chroma, hue, alpha) = self.as_lcha_f32();
    return Color::Lcha { lightness, chroma, hue, alpha };
}

This is maybe slightly less efficient but it avoids copy-pasting this huge match expression which is error prone. Anyways since it is my first commit here I wanted to be consistent with the rest of code but can refactor all variants in separate PR if somebody thinks it is good idea.

bors r+


AS3 "httpHost" value for LTM Policies

Requesting that "httpHost" value be added for AS3 key name "type".
Currently the only supported "type" values are:
["http","httpCookie","httpHeader","httpRedirect","httpUri","waf","forward","drop","clientSsl","persist","tcl","log"]
The closet supported type is "httpHeader" but this does not suffice. The "httpHost" value is needed for ltm policies.  The tmsh equivilent is http-host ie:
ltm policy fqdn.com.policy {
controls { forwarding }
last-modified 2022-03-11:20:23:49
partition Common
requires { http }
rules {
abc {
actions {
0 {
http-host
replace
value fqdn.com
}
1 {
forward
select
pool fqdn.com.pool
}
}
}
}
status published
strategy best-match
}

Attempted AS3 Conversion:
"fqdn.com.policy": {
"rules": [
{
"name": "abc",
"actions": [
{
"event": "request",
"type": "httpHost",
"replace": {
"value": "fqdn.com"
}
},
{
"event": "request",
"type": "forward",
"select": {
"pool": {
"use": "fqdn.com.pool"
}
}
}
]
}
],
"strategy": "best-match",
"class": "Endpoint_Policy"
}
AS3 Response:
{
"code":422,
"errors":[
"/t_app/fqdn.com.443.tcp.app/fqdn.com.policy/rules/0/actions/0/type: should be equal to one of the allowed values ["http","httpCookie","httpHeader","httpRedirect","httpUri","waf","forward","drop","clientSsl","persist","tcl","log"]"
],
"declarationFullId":"",
"message":"declaration is invalid"
}

We have been using this with success:
  "type": "httpHeader",
  "replace": {
    "name": "Host",
    "value": "newfqdn.com",
  }

For what it is worth, according to this comment, the httpHost condition of an ltm policy just matches against the host header anyway
https://github.com/F5Networks/f5-appsvcs-extension/issues/397#issuecomment-747603366

I will try this what version of AS3 are you using?

I will try this what version of AS3 are you using?

Currently on 3.36.0; have been using this configuration for many versions prior.

Here is another example of a similar issue LTM policy is using Http Host value but AS3 does not have equivalent.
Policy:
ltm policy policy.somesite.com {
controls { forwarding }
last-modified 2022-10-19:21:37:10
requires { http }
rules {
"Redirect Rule" {
actions {
0 {
http-reply
redirect
location tcl:https://somesite-wiam.com[HTTP::uri]
}
}
conditions {
0 {
http-host
host
values { somesite.com }
}
}
}
}
status published
strategy first-match
}
AS3 Input
{
"class": "AS3",
"action": "dry-run",
"declaration": {
"class": "ADC",
"schemaVersion": "3.41.0",
"target": {
"address": "<IP_ADDRESS>"
},
"t_10.x.x.x": {
"class": "Tenant",
"remark": "AppID: 100294",
"somesite.443.tcp.app": {
"class": "Application",
"template": "generic",
"label": "https-bridge-app",
"somesite.443.vs": {
"class": "Service_HTTPS",
"enable": true,
"virtualAddresses": [
"10.x.x.x"
],
"virtualPort": 443,
"redirect80": false,
"serverTLS": "somesite.c.ssl.pf",
"clientTLS": {
"bigip": "/Common/serverssl"
},
"profileHTTP": {
"bigip": "/Common/http"
},
"iRules": [
"somesite.irule.csr.access.uat3.int.ally.com.redirects"
],
"pool": "somesite.pool",
"persistenceMethods": [
{
"bigip": "/Common/cookie.bigip-encryption"
}
],
"policyEndpoint": [
{
"use": "policy.somesite"
}
],
"snat": {
"bigip": "/Common/SNATS_BANK_MDL1"
},
"profileTCP": {
"bigip": "/Common/tcp-lan-optimized"
},
"profileAnalytics": {
"bigip": "/Common/analytics"
}
},
"somesite.pool": {
"class": "Pool",
"loadBalancingMode": "round-robin",
"slowRampTime": 10,
"members": [
{
"servicePort": 8484,
"shareNodes": true,
"adminState": "enable",
"serverAddresses": [
"<IP_ADDRESS>"
]
},
{
"servicePort": 8484,
"shareNodes": true,
"adminState": "enable",
"serverAddresses": [
"<IP_ADDRESS>"
]
}
],
"monitors": [
{
"bigip": "/Common/tcp"
}
]
},
"policy.somesite": {
"rules": [
{
"name": "Redirect Rule",
"conditions": [
{
"event": "request",
"type": "httpHeader",
"host": {
"values": [
"somesite"
],
"operand": "equals"
}
}
],
"actions": [
{
"event": "request",
"type": "httpRedirect",
"location": "tcl:https://somenewsite.com[HTTP::uri]"
}
]
}
],
"strategy": "first-match",
"class": "Endpoint_Policy"
},
"pool.tridion2011.uat3.8052": {
"members": [
{
"addressDiscovery": "static",
"servicePort": 8052,
"serverAddresses": [
"<IP_ADDRESS>",
"<IP_ADDRESS>",
"<IP_ADDRESS>",
"<IP_ADDRESS>"
],
"shareNodes": true
}
],
"monitors": [
{
"bigip": "/Common/tcp_15"
}
],
"class": "Pool"
},
"pool.somesite.8484": {
"members": [
{
"addressDiscovery": "static",
"servicePort": 6301,
"serverAddresses": [
"<IP_ADDRESS>",
"<IP_ADDRESS>"
],
"shareNodes": true
},
{
"addressDiscovery": "static",
"servicePort": 8484,
"serverAddresses": [
"<IP_ADDRESS>",
"<IP_ADDRESS>"
],
"shareNodes": true
}
],
"monitors": [
{
"bigip": "/Common/tcp"
}
],
"class": "Pool"
},
"somesite.443.cert": {
"certificate": {
"bigip": "/Common/lb-somesite"
},
"privateKey": {
"bigip": "/Common/lb-somesite"
},
      "class": "Certificate"
    },
    "somesite.c.ssl.pf": {
      "certificates": [
        {
          "certificate": "somesite.443.cert"
        }
      ],
      "ciphers": "ALL:!TLSv1:!TLSv1_1:!DHE:!SHA:!MD5:!ADH:!EXPORT:!EXP",
      "class": "TLS_Server"
    }
  }
}

}
}
Error:
{
"code": 422,
"errors": [
"/t_10.x.x.x/somesite.443.tcp.app/policy.somesite/rules/0/conditions/0: should have required property 'all'"
],
"declarationFullId": "",
"message": "declaration is invalid"
}

And apologies looking back over our message history; I realize I forgot to mention that your suggested course of action was successful in the previous scenario


Syncer client: many fns impl for SyncerState, should be impl for SyncerTasks

Would be kind of inconvenient for the call sites of the SyncerState to indirect these calls on level deeper to the SyncerTasks. I'm closing this for this reason.


Thread components usage documentation and updates

Good improvements. In the preview, I notice that we are animating on initial render but it seems like it would be better to animate only when a thread item is being added after initial render.

I took the animations out of the boxel component for now (all in the dummy app now) and made the initial render conditional on whether that step has been completed.


Be consistent in using header values or DB values

With the implementation of #18 we are now using a few values from FITS headers (airmass, parang) and values from the DB (passed via a config file). We should either use all values from the headers or all values from the DB. It doesn't matter which, but it makes sense to be consistent.

I would consistently favour header values.

Using header values where possible will let us make the config file much simpler, so that sounds good to me. I'll implement this.


Type safe select

Issue:
This solves the case in the select-knob when you pass in an array or an object where the values are not strings but the prop the knob is used for expects another type (e.g. a number), see for example issue #4106
What I did
The passed in options of the select-knob are stored in the local state, so they are not converted to strings when setting them as a value of the option-element. On a selection, the original value will be received from the state.
How to test
Is this testable with Jest or Chromatic screenshots?
Does this need a new example in the kitchen sink apps? yes - see added story for testing.
Does this need an update to the documentation?
If your answer is yes to any of these, please make sure to include it in your PR.
For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Awesome work @ca057 !
Thank you for improving the knobs addon, this makes a ton of sense.
What do you think about my comment of the usage of getDerivedStateFromProps? Happy to keep it if you feel this is a better solution.

Hey @ndelangen !
Thanks for the feedback! I’m happy to improve that 👍

Any plans on finishing this PR?

Any plans on finishing this PR?

Hey - yes! I have it open for the whole weekend to continue it again. Sorry, I was out the last month. Let me update my PR to include the latest changes and work on the comments from @ndelangen .

@igor-dv I checked out the latest version of Storybook and saw that this feature was added in the meantime by another PR. Can you check the latest version please and confirm this? I would then close this PR. Thanks for your patience.

Yeah this seems to be fixed already, thank you @ca057 for your time and energy.
Bit sad your PR didn't get merged, but want to let you know I truly appreciate the effort you put in.


Post-train Quantization Element-wise addition function can't use

Hi, I try Post-train Quantization Element-wise addition function.
Command:

python compress_classifier.py -a resnet18 --pretrained /dataset/imagenet2012 --evaluate --quantize-eval

but, RangeLinearQuantEltwiseAddWrapper not be used.
warning log:

WARNING: module.layer1.0.add - quantization of EltwiseAdd without stats not supported. Keeping the original FP32 module

How do can use function RangeLinearQuantEltwiseAddWrapper?

Hi @georgetseng1128 ,
Before quantizing the model with non-parametric layers (like nn.ReLu or EltwiseAdd) you should first collect the activation stats for this layer. Some layers support dynamic quantization (e.g. nn.Linear and nn.Conv2d), but these don't.
Collecting stats for the layer (or for the entire model) is as easy as adding --activation-stats argument to the compress_classifier.py command line.
NOTE - this will slow down the runtime of the script significantly, so I suggest running it a single time, without the --quantize-eval argument.
A yaml file will be generated with all the activation stats for all the layers, and then this file can be used to feed the activation for the PostTrainLinearQuantizer, suppose it's called activation_stats.yaml.
Use this file by adding an argument --qe-stats-file activation_stats.yaml, and you're good to go.
Let us know if you need more help :)
Lev

Actually, to collect activation stats specifically for quantization you need to use --qe-calibration in the command line, not --activation-stats. I realize this is a bit confusing, but that's they way it is at the moment :).
Also note that --qe-calibration expects a numeric value between [0 .. 1] which specifies how much of the test dataset you want to use for stats collection. For example - --qe-calibration 0.1 will use 10% of the test set. That's usually a safe value to use.
You can see an example of a stats file with a bit more details here:
https://github.com/NervanaSystems/distiller/blob/master/examples/quantization/post_train_quant/stats/resnet18_quant_stats.yaml
It's actually for ResNet-18, so you can just use it as is :)

Thank you all!
I have successfully executed, use --qe-calibration and --qe-stats-file.

Thank you all!
I have successfully executed.
Use --qe-calibration and --qe-stats-file.


Add new RSpec/PendingBlockInsideExample cop

Resolve: https://github.com/rubocop/rubocop-rspec/issues/1563

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

I rebased and resolved the conflict.

I'm puzzled why:
    it 'registers an offense when using `pending` with a numblock' do
      expect_offense(<<~RUBY)
        it "does something" do
          pending 'not yet implemented' do
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't pass a block to `pending` or `skip` inside examples.
            _1
          end
        end
      RUBY
    end

doesn't parse pending as a numblock 🤔
> node
=> s(:block,
  s(:send, nil, :pending,
    s(:str, "not yet implemented")),
  s(:args),
  s(:send, nil, :_1))
> puts node.source
pending 'not yet implemented' do
    _1
  end

Updated to the latest rubocop 1.43, rubocop-ast 1.24.1, parser <IP_ADDRESS>.
$ ruby-parse -e 'r(2) do; _1 ; end'
(numblock
  (send nil :r
    (int 2)) 1
  (lvar :_1))

Am I missing something?

Filed https://github.com/rubocop/rubocop/issues/11479
I suggest holding this off, as we disable the offence that insists on adding on_numblock handler, and can't really test our code against numblocks with the above issue.

Alright, it slipped my mind that we have to add :ruby27 for examples that use numblocks.


Allow change the start date when selecting a previous date

Description
Instead of blocking the dates before the selected start date, could we please allow user to simply change the start date when selecting a date before the current start date? I think it would be a bit more user friendly, since if user gets the start date wrong, the user has to select an end date first before changing the start date. I would like to help you on doing this, do you think this is something that could be done? If yes, could you please point me out in the right direction on how to do this? Which vue files contain the logic that I would have to work on?
[Description of the bug or feature]
Code sample
[ If you are submitting a bug issue, paste your code so I can reproduce it, or a link to a Codepen with it ]
Steps to Reproduce

[First Step]
[Second Step]
[and so on...]

Expected behavior: [What you expected to happen]
When a start date is already selected, we shouldn't block the previous dates. If user selects a date previous the current start date, then the start date would be simply changed to that new date the user has selected.
Actual behavior: [What actually happened]
When selecting a start date, all previous dates are blocked, and the user needs to set an end date before changing the start date.
Datepicker Version
2.2.1
[ The version of the datepicker you have installed in your project ]

This is solved in v4.0.0-beta.1. Please try it!


Pin constraints and placement?

I can't find any way to specify pin constraints, and RePlAce appears to leave any pins in the PLACED position they started in.  If they are in the DEF file but do not have a PLACED position, they don't show up in the layout at all.  Pin constraints in, say, Cadence Encounter are passed through a Tcl setup file, but I can't find anything similar for RePlAce.
Is RePlAce able to optimize pin positions?  If so, what do I need to do to enable that?
---Tim

Hi Tim,
RePlAce has no ability to place pins now. But, the pin-placement project is ongoing with UFRGS.
I guess RePlAce with pin-placer will be updated soon.
Kind regards,
Mingyu Woo

Pin Placer has been updated in The-OpenROAD-Project/ioPlacer and ioPlacer performs iterative runs in binary mode (ioPlacer -> replace -> ioPlacer -> ...).
Close.


Redirect with react-router-4 not updating history

I am using react-router-dom:
import { BrowserRouter as Router, Route } from 'react-router-dom';

  <Provider store={store}>
    <Router>
      <App>
        <Route path="/" exact component={Home} />
        <Route path="/application" component={Application} />
      </App>
    </Router>
  </Provider>,
  document.getElementById('root')
);

I am using <Redirect /> to redirect but only when a form is in valid state:
    </div>
    {submitSucceeded && <Redirect to={nextLink} />}

But when I go to the next link and click back it goes back to the route of the site, i.e. the history is not being updated.

See this guide: https://github.com/ReactTraining/react-router/blob/master/packages/react-router/docs/guides/redux.md


Improve username behavior at validations.py

Closes: #1

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!


Include Code Analysis rules to the build environment

In order to reduce the discussion about how the code should look like and to avoid arguments like: "I read prefer like this..:" or "Is more readable like this..." we should implement the Code Analysis rules to rule code style.
At the begin the non-conform pieces of code should appear as warning and after the team give effort to remove all the warnings, on every build the non-conform code should be be marked as error and we should not be able to compile the code.
There are nuget packages to add Code Analysis and Style Cop rules to the .NET Core Projects:

https://carlos.mendible.com/2017/08/24/net-core-code-analysis-and-stylecop/
https://carlos.mendible.com/2018/04/05/adding-code-analysis-and-stylecop-checks-to-net-core-projects-with-dotnet-addcasa/

add the CodeAnalysis and StyleCop described in productive code and not in the test code.
3869 warnings

final number: 12.015 warning

Good job! i will close it because is merged


Can't install to ubuntu 18

Gcc version 9, g++ version is 9. Also tried with gcc-7.4 and g++7.4. Node version is 10, also tried 8. Npm version 6.11.

Error appeared cause insuffience of ram

But i have new error

I think this can be caused because of my cpu. And i have to run make command with option -cpu host, how can i do it?


manage block downloads more efficiently

Right now our block downloads are fairly wild-west. Whenever a peer gets an inv_block it's going to try downloading the block (unless another peer happens to download and process it prior to receiving the inv_block.) This is mostly fine right now with our currently small blocks but it won't scale well.
With this new approach there is a notion of a global inflight queue. Peers will maintain their own local download and inflight queues but won't move a block from their download queue to inflight if another peer currently has ownership of the block in the global inflight queue. If the block sits in the global inflight queue for more than 2 minutes another peer is permitted to try to download it.

This seemed stable overnight and syncs look good. The logging is slightly verbose but I can remove it after this has gotten more use in the wild. Eventually, when I have more time, I should look into more advanced syncing protocols but I have other things I need to work on first. This should hopefully buy us some time and keeps things simple.