UI makes it easy to accidentally delete drafts!

Just trying out Zulip for the first time, and I accidentally deleted my very first message before finishing it...
I started on a message, then I clicked somewhere else (checking other topics, maybe) ...the message editor disappeared and it was saved in drafts.  Later I clicked on drafts to continue the message, saw it was selected and immediately tried to edit it...hit backspace to change the last word, only to delete the entire draft with no warning and no way to undelete!
Obviously user error on my part, but still...

Thanks for the report @partap!  We haven't heard similar reports from other users, and I'm not sure there's much we can do to address this without regressing the experience for non-first-time users, and I think it's likely that is a mistake users would only make their first time visiting the "drafts" UI.  So I'm going to close this as wontfix for now, since I don't think there's anything actionable for us to do here.  Other users should feel free to post on this thread if they experience the same issue.

Fair enough... my suggestion would be either to implement draft undelete or pop up a confirmation dialog (could be disabled in settings, but on by default) ...but I'm sure you guys have a lot of higher priority stuff to work on.
On the other hand, a quick fix would just be to not delete the draft on backspace?  The help says the shortcut key is delete ;)


fix(51223): Go-to-definition for yield and await keyword; jump to respective function definition

Fixes #51223
My first PR on this project, apologies in advance in case I missed anything in the guidelines.
Please note that there was some discussion in the issue for await, whether it should jump to the function definition or the respective async. This PR does the former - in the very most cases, they should be right next to each other either way, and the latter seems slightly more involved to implement (which I'm absolutely willing to tackle though if preferred).
Furthermore, in the case of an error (e.g. surrounding function is not async/generator), this implementation should not provide any goToDefinition.

@microsoft-github-policy-service agree


Use consistent naming for user (profile) menus

As discussed on CZO, we should develop consistent naming for the pop-up you seen when you click on a user avatar, as well as the detailed user profile.
Specifically, the naming we want to implement is:

"User card" for the initial user view.

"User profile" for the detailed profile.

Known places where changes need to be made:

[ ] Tooltip on user avatar: "View user profile (u)" -> "View user card (u)"
[ ] Menu option on user card: "View full profile" -> "View profile"
Custom profile fields:

[ ] "Summary" column name -> "Card"
[ ] "Display in profile summary" -> "Display on user card"

We should also check whether any other places are affected.
Help center:

[ ] Whenever instructions mention opening the profile card, we should name it explicitly, e.g.,:

Click on the ellipsis () to the right of their name. -> Click on the ellipsis () to the right of their name to open their profile card.

[ ] Some pages known to be affected: https://zulip.com/help/view-someones-profile, https://zulip.com/help/custom-profile-fields

We should do an overall audit to make sure the terminology is consistent (can be done as a follow-up).

@laurynmm Would you be up for taking this one? It's not critical for the release, but would be nice to include.


OCPBUGS-28325: add an extra vendor exclude to snyk config

this change is being added to pickup the vendor files that are appearing in the cachito expansion.

/approve
/lgtm


support loadbalancerIP in Team edition

Signed-off-by: Dennis Zhang<EMAIL_ADDRESS>
Summary

I'd like for this helm chart to support loadbalancerIP for use with external loadbalancers in the cloud or MetalLB on baremetal.
Thanks.
Notes outputs:
With loadbalancerIP specified while using service type LoadBalancer example:
Mattermost will be available at:

  <IP_ADDRESS>:80

Without loadbalancerIP specified while using service type LoadBalancer example:
You can connect to Mattermost by using the IP printed by this commmand on port 80:

  MATTERMOST_IP=`kubectl get --namespace mattermost service mattermost-team-edition -o jsonpath='{.status.loadBalancer.ingress[0].ip}'`
  echo $MATTERMOST_IP

Running the printed command:
$   MATTERMOST_IP=`kubectl get --namespace mattermost service mattermost-team-edition -o jsonpath='{.status.loadBalancer.ingress[0].ip}'`
$   echo $MATTERMOST_IP
<IP_ADDRESS>

MetalLB using the value to assign IP :
kubectl -n mattermost describe service mattermost-team-edition
...
Events:
  Type    Reason          Age                    From                Message
  ----    ------          ----                   ----                -------
  Normal  LoadbalancerIP  2m22s (x3 over 3h32m)  service-controller  -> <IP_ADDRESS>

Ticket Link

N/A

Thanks @FlipEnergy for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

I have signed the CLA

/check-cla


empty_read_me_file

Your read me page is empty, we could add some information

That is a great issue raised. Thank you please make PR

closes #3


Re-implement all the current XGA models as subclasses of the new XGA model class

A BaseModel1D class has been implemented as per issue #440


Bluetooth: audio: Handle Receiver Stop Ready on non-connected stream

This fixes state transition to QoS Configured state triggered by
client-initiated Receiver Stop Ready operation on ASE that has no ISO
attached.
Fixes: ASCS/SR/ACP/BV-12-C
Signed-off-by: Mariusz Skamra<EMAIL_ADDRESS>

@szymon-czapracki FYI


Collapsible regions don't work in workspace

Issue Description
Opening a workspace with pre-opened .cs file (i.e. HelloWorld folder/workspace, with Program.cs as a source file) does break a collapsible regions after few seconds (before everything loads/starts) and makes them not working (not displayed, collapsed regions automatically expand). Issue filled on github/microsoft/vscode closed and saying to report the issue here. Extension bisect identified ms-dotnettools.csharp as extension causing the problem.
Steps to Reproduce
mkdir HelloWorld
vi HelloWorld/Program.cs # Create pre C#10 Hello World with Main function
code HelloWorld HelloWorld/Program.cs

Expected Behavior
Collapsible sections (based on braces) work.

Actual Behavior
See what happens with expandable regions. They appear and work, and after a second or two disappear and don't work anymore.

I can't take a screenshot that includes mouse pointer on windows so the red line points to a place where mouse pointer is located.
Logs
OmniSharp log

Starting OmniSharp server at 30/11/2021, 13:17:07
    Target: c:\CSharp\HelloWorld
OmniSharp server started.
Path: c:\Users\Filip.vscode\extensions\ms-dotnettools.csharp-1.23.16.omnisharp\1.37.16\OmniSharp.exe
PID: 12724
    Starting OmniSharp on Windows 6.2.9200.0 (x64)

    Checking the 'DOTNET_ROOT' environment variable to find a .NET SDK

    Using the 'dotnet' on the PATH.

    DotNetPath set to dotnet

    Located 3 MSBuild instance(s)
        1: Visual Studio Enterprise 2022 17.0.31903.59 17.0.0 - "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin"
        2: Visual Studio Enterprise 2019 16.11.31829.152 16.11.2 - "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin"
        3: StandAlone 17.0.0 - "c:\Users\Filip\.vscode\extensions\ms-dotnettools.csharp-1.23.16\.omnisharp\1.37.16\.msbuild\Current\Bin"

    Registered MSBuild instance: Visual Studio Enterprise 2022 17.0.31903.59 17.0.0 - "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin"

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.Completion.CompletionOptionsProvider, Order: 0

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.ImplementTypeWorkspaceOptionsProvider, Order: 110

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.BlockStructureWorkspaceOptionsProvider, Order: 140

    Detecting Cake files in 'c:\CSharp\HelloWorld'.

    Could not find any Cake files

    No solution files found in 'c:\CSharp\HelloWorld'

    Detecting CSX files in 'c:\CSharp\HelloWorld'.

    Could not find any CSX files

    Configuration finished.

    Omnisharp server running using Stdio at location 'c:\CSharp\HelloWorld' on host 10524.

    Miscellaneous file: c:\CSharp\HelloWorld\Program.cs added to workspace

Received response for /v2/blockstructure but could not find request.
Received response for /v2/codestructure but could not find request.
Received response for /v2/codestructure but could not find request.
Received response for /completion but could not find request.
[warn]: OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService
No symbol found. File: c:\CSharp\HelloWorld\Program.cs, Line: 18, Column: 40.

C# log

Environment information
VSCode version: 1.62.3
C# Extension: 1.23.16
Dotnet Information
.NET SDK (reflecting any global.json):
 Version:   6.0.100
 Commit:    9e8b04bbff
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.19044
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\6.0.100\
Host (useful for support):
Version: 6.0.0
Commit:  4822e3c3aa
.NET SDKs installed:
5.0.403 [C:\Program Files\dotnet\sdk]
6.0.100 [C:\Program Files\dotnet\sdk]
.NET runtimes installed:
Microsoft.AspNetCore.All 2.1.30 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.30 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.21 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.30 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.21 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.12 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.1.21 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 5.0.12 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 6.0.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
To install additional .NET runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

alignment
annsk
0.3.0

AWK
luggage66
0.0.2

bats
jetmartin
0.1.7

beautify
HookyQR
1.5.0

code-spell-checker
streetsidesoftware
2.0.13

code-spell-checker-czech
streetsidesoftware
0.1.9

csharp
ms-dotnettools
1.23.16

html-preview-vscode
tht13
0.2.5

java
redhat
1.1.0

jupyter
ms-toolsai
2021.10.1101450599

jupyter-keymap
ms-toolsai
1.0.0

jupyter-renderers
ms-toolsai
1.0.3

latex-workshop
James-Yu
8.22.0

lorem-ipsum
Tyriar
1.3.0

python
ms-python
2021.11.1422169775

sort-lines
Tyriar
1.9.0

vscode-hexdump
slevesque
1.8.1

vscode-java-debug
vscjava
0.37.0

vscode-java-dependency
vscjava
0.18.8

vscode-java-pack
vscjava
0.18.7

vscode-java-test
vscjava
0.33.0

vscode-maven
vscjava
0.34.1

vscode-pylance
ms-python
2021.11.2

vscode-random
jrebocho
1.11.0

vscodeintellicode
VisualStudioExptTeam
1.2.14

Any news to this? Is more info required?


[EDN] V2 Review Items

This issue captures AIs that came up in the V2 meeting for EDN:

[x] Steve: Fix formatting/link errors in the dv doc
[x] Steve: Implement all covergroups listed in testplan
[x] Steve: Add cross of num_endpoints/mode in edn_cfg_cg
[x] Steve: Remove "endpoint requests completed at various times" from edn_endpoints_cg
[x] Steve: Add cross between coverpoints in cs_cmds_cg
[x] Steve: Reformulate edn_genbits_cg to cover random delays on CSRNG/EDN interfaces (host/device) and add to agent if not already in PP_agent
[x] Steve: Ensure CSRNG/EDN (host/device) delays are enabled in agent
[x] Sri/MSF/Martin: Create issue for chip-level tests #10970
[x] Muqing: Modify err_test_cg to use enum vs int and implement
[x] Steve: Verify with Mark/Martin that min/max delays are appropriate
[x] Weicai: Make fix for instruction type in TL-UL (Done via https://github.com/lowRISC/opentitan/pull/12015)
[x] Steve: Randomize csrng_req_bus to increase coverage
[x] Steve: Add test to toggle rsp_sts bit
[x] Rasmus/Weicai: Add common exclusion for alert ping lines (Done via https://github.com/lowRISC/opentitan/pull/11021)
[x] Weicai: Clean up common testplans (Done via #10972)
[x] Muqing/Steve: Verify EDN.MAIN_SM.CTR.LOCAL_ESC, EDN.CS_RDATA.BUS.CONSISTENCY are covered with error_test
[ ] Code coverage not at V2 levels (90%)

The latest nightly regression shows > 90% coverage for this block. Is there anything else pending to sign-off?

I see FSM coverage is still below 90%.

This might be related to branches that we can exclude (due to escalation), but I don't know whether the coverage exclusions have been applied to this block yet.

If the FSM coverage is due to D2S related features, we could just waive it and address during V2S.

I quickly glanced over the coverage results and saw that the uncovered arcs in edn_main_sm.sv and edn_ack_sm.sv are almost exclusively due to *-> Error and *-> Idle transitions.
@weicaiyang didn't we discuss an option that would automatically exclude reset transitions from coverage collection?
But yes, it feels like we can wave this to V2S.

@weicaiyang didn't we discuss an option that would automatically exclude reset transitions from coverage collection? But yes, it feels like we can wave FSM coverage closure to V2S.

@msfschaffner
We exclude transitions triggered by reset only. Looks like it works.
In edn_ack_sm , the only missing transition is DataWait-> Idle, which can be caused by disabling the enable_i.
And Error -> Idle is gone, which can be triggered by reset only.
  always_comb begin
    state_d = state_q;
    ack_o = 1'b0;
    fifo_pop_o = 1'b0;
    ack_sm_err_o = 1'b0;
    unique case (state_q)
      Idle: begin
        if (enable_i) begin
          if (req_i) begin
            if (fifo_not_empty_i) begin
              fifo_pop_o = 1'b1;
            end
            state_d = DataWait;
          end
        end
      end
      DataWait: begin
        if (!enable_i) begin
          state_d = Idle;
        end else begin
          if (fifo_not_empty_i) begin
            state_d = AckPls;
          end
        end
      end
      AckPls: begin
        ack_o = 1'b1;
        state_d = Idle;
      end
      Error: begin
        ack_sm_err_o = 1'b1;
      end
      default: state_d = Error;
    endcase

Similar to edn_main_sm . *-> Idle can be triggered by disabling edn_enable_i.
Disabling EDN in the middle of the seq may be not very important. Perhaps we can leave it for V3.

actually that's quite important.
A lot of our entropy complexes get started by ROM and need to later be initialized by software.
So we definitely should test these. @senelson7 previously merged #14534 for this, so it's probably something that should be tested as well.

actually that's quite important. A lot of our entropy complexes get started by ROM and need to later be initialized by software. To do that we have to disable and make sure everything can move back to a clean state.
So we definitely should test these. @senelson7 previously merged #14534 for this, so it's probably something that should be tested as well.

Make sense. Thanks for pointing this out.

I had code in a PR that forced the *->Error and *->Idle transitions but the consensus was it wasn't necessary just to get FSM transition coverage up. #14407 highlights this. Maybe this was just wrt reset and *->Error but I removed it all. Are you indicating you want the *->Idle due to not enabled to be put back? I probably had only done it for csrng so far but also planned to do it for edn.

Hi @senelson7,
My understanding was that there would be sim exclusions paired with formal approaches to close the gap, and these would be done consistently across all IPs.   My assumption though is that this is still pending.  (All: is this just a problem for CSRNG/EDN or are there other gaps as well?)
Meanwhile, I take it as a really exciting sign that have just the FSM coverage left.   This is actually really close!

I had code in a PR that forced the *->Error and *->Idle transitions but the consensus was it wasn't necessary just to get FSM transition coverage up. #14407 highlights this. Maybe this was just wrt reset and *->Error but I removed it all. Are you indicating you want the *->Idle due to not enabled to be put back? I probably had only done it for csrng so far but also planned to do it for edn.

For *-> error, we could keep idle -> error as the common sec_cm V2S test can cover it. And add exclusions for non-idle -> error.
#14407 only exclude transition that only happens on reset. So it does't exclude all *->idle, as some can be triggered by enable=0. If I recall correctly, you had a PR that forced FSM to any state and do a reset, in order to hit these transition, which seems a bit hacky and didn't really test the enable function. Perhaps it's better to program EDN_ENABLE=0 in the middle of the operation and re-enable the EDN to ensure it works again.

My understanding was that there would be sim exclusions paired with formal approaches to close the gap, and these would be done consistently across all IPs. My assumption though is that this is still pending. (All: is this just a problem for CSRNG/EDN or are there other gaps as well?)

The DV portion in https://github.com/lowRISC/opentitan/issues/14407 is done. The transition that only happens on reset are automatically excluded now. It works for EDN. AES FSM coverage is improved to 90%+.

Meanwhile, I take it as a really exciting sign that have just the FSM coverage left. This is actually really close!

Indeed!

The lint policy update in https://github.com/lowRISC/opentitan/issues/14407 is pending (we have to wait for an updated policy file bundled with the next AscentLint release from RealIntent). Meanwhile, I ran the new policy already locally and all FSMs in the entire chip conform.

Hence it sounds like the only thing that we still need to do for EDN is covering functional arcs to IDLE that are not due to the reset. Would the suggestion from @weicaiyang RE programming EDN_ENABLE=0 in the middle of ongoing operations work?

Maybe, but it'll be totally random which state we are in when we disable. Maybe we can define what edn will be doing when it is disabled? If not, there are several cases to try to hit, i.e. no/some/all endpoints requesting, waiting for entropy, entropy delivered, etc. Same for csrng?

there are several cases to try to hit, i.e. no/some/all endpoints requesting, waiting for entropy, entropy delivered, etc. Same for csrng?

These sound very interesting cases to hit. @martin-lueker may have better idea on what cases are good to test.

As discussed in the last Si meeting, here are the takeaway.

it's good to have this transition (*->Idle) covered before signed off V2
randomly programming EDN_ENABLE=0 may not be able to hit all the cases. We may need to probe the internal state before programming it, which sounds like a reasonable approach.

@senelson7 Let me know if you think we need more discussion on this issue.

All items covered. Close this issue


Image embeds may be crashing the plugin

This has proved a very useful plugin so far. The one issue I ran into is a .png embed in a note brought the plugin to crash each time.
In a different note with a .jpg embed (and far less markdown code attached to it) there was no problem. I believe the difference with the .png embed isn't necessarily the format, but that the markdown code in the embed attachment has a LOT more characters in it.

Sorry for not having responded in this topic earlier, I saw the notification via email and noted it.
Haven't had the time to work on this till now.
I'll start looking at a fix for this issue this week, while working on ollama localhost/open-source AI support.

No problem! if could be that i was sending too much for GPT3.5 to tokenise. that's my best guess.

Might be! In that case, still is an issue :-)
The plugin should warn about that, and either not allow it, or cut off at the limit or make multiple requests (or let the user decide :) ).


Hide menu options for empty topics

When a topic is known to be empty, we should hide all the menu options in the ... menu. Instead, we should have There are no messages in this topic. line just below the topic name, styled like the deactivated user line.

In particular, this should be possible to do in the left sidebar when viewing an empty topic. There may be other situations where the app does not know that a topic is empty, and we won't be able to do this.

CZO thread

@zulipbot claim


Multiple parameters and new checkpoint_biggest

Hello,
I was wondering if you have the python code for how you created the checkpoint_biggest from the chembl file?  It also mentions loading multiple parameters in the abstract of the paper, do you have any implementation with more than one parameter?
Thank you,
Kevin

Hello,
I missed the updated implementation and saw the way to make a new model from the chembl file in the python notebook.  I am still wondering if you have any suggestions on the implementation of multiple parameters.
Thank you for your time,
Kevin

I have been trying to run the commented out code in the python notebook to produce a new checkpoint_biggest using the provided Chembl file, but get the following error every time I try to run the script each time at different generation numbers. :
Training in progress...:   0%|                                                                                | 99/1500000 [00:09<37:07:28, 11.22it/s][0m 9s (100 0%) 2.6547]
<V+778ycV<CnatHnsO(CEN/Hu]Tg6\LpdWX<uFI9YDfE9bf3pMF/GE4mI[]9]H59I
Tu=PDVP5]6
Z>
Training in progress...:   0%|                                                                                | 198/1500000 [00:18<37:05:32, 11.23it/s][0m 18s (200 0%) 1.4145]
Traceback (most recent call last):
File "multi.new.runReleaseask.190404.newgenerator.py", line 119, in
losses = my_generator.fit(gen_data, 1500000)
File "/home/ubuntu/Release2/stackRNN.py", line 459, in fit
predict_len=100), '\n')
File "/home/ubuntu/Release2/stackRNN.py", line 391, in evaluate
output, hidden, stack = self.forward(inp, hidden, stack)
File "/home/ubuntu/Release2/stackRNN.py", line 215, in forward
inp = torch.cat((inp, stack_top), dim=2)
RuntimeError: invalid argument 0: Sizes of tensors must match except in dimension 2. Got 1 and 2 in dimension 1 at /opt/conda/conda-bld/pytorch_1535491974311/work/aten/src/THC/generic/THCTensorMath.cu:87
Exception ignored in: <bound method tqdm.del of Training in progress...:   0%|                                                                                | 198/1500000 [00:18<37:05:32, 11.23it/s]>
Traceback (most recent call last):
File "/home/ubuntu/anaconda3/lib/python3.6/site-packages/tqdm/_tqdm.py", line 889, in del
self.close()
File "/home/ubuntu/anaconda3/lib/python3.6/site-packages/tqdm/_tqdm.py", line 1095, in close
self._decr_instances(self)
File "/home/ubuntu/anaconda3/lib/python3.6/site-packages/tqdm/_tqdm.py", line 454, in _decr_instances
cls.monitor.exit()
File "/home/ubuntu/anaconda3/lib/python3.6/site-packages/tqdm/_monitor.py", line 52, in exit
self.join()
File "/home/ubuntu/anaconda3/lib/python3.6/threading.py", line 1053, in join
raise RuntimeError("cannot join current thread")
RuntimeError: cannot join current thread


DEL doesn't remove item from shell history

Can you please provide me with version (hh --version), shell (Bash, Zsh) and other details (e.g. how delete entry looks like) so that I can reproduces the problem?
BTW, I did fixes related to history management prior 1.22 - if you have an older version, then please upgrade.

$ hh --version
hh version "1.22"
   build   "Feb  3 2017 22:22:10"
Desktop $ bash --version
GNU bash, version 4.4.12(1)-release (x86_64-apple-darwin12.6.0)
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Any entry cannot be deleted.

Thank you for providing details!

Did you configured hstr in .bashrc? What history related configuration you have there?
Can you please share which view do you use - it's black on white e.g. - HISTORY - view:ranking ... (ranking view)?
Do you see a prompt after pressing DEL Do you want to delete all occurrences of 'tig'? y/n?
How many occurrences of deleted entry/entries is there (there might trailing space and entries look the same)?
How do you exit hstr - Esc, Ctrl-g, ...?

Do you get any errors or hstr simply does nothing?

Apologies for many questions, but I need to reproduce the problem and isolate where it is. Thanks again for your help!

This is my configuration that I source from a separate file in /etc/profile.

# hstr (default options modified)
export HH_CONFIG=hicolor,keywords,rawhistory  #+get more colors
shopt -s histappend                           # append new history items to .bash_history
export HISTCONTROL=ignorespace                # leading space hides commands from history
export HISTFILESIZE=10000                     # increase history file size (default is 500)
export HISTSIZE=${HISTFILESIZE}               # increase history size (default is 500)
export PROMPT_COMMAND="history -a; history -n; ${PROMPT_COMMAND}"   # mem/file sync
# if this is interactive shell, then bind hh to Ctrl-r (for Vi mode check doc)
if [[ $- =~ .*i.* ]]; then bind '"\C-r": "\C-a hh -- \C-j"'; fi
export HH_PROMPT="$ "

My view is history — an aside, as said in #203 I cannot change it with Ctrl-7.

After pressing DEL I don't see any prompt.

One unique occurrence cannot be deleted.

Exit with both 2xESC and Ctrl-g work (caveat #203).

Running hh again or history shows the entry there.

No errors, hstr does nothing after pressing DEL.

I noticed you labeled it os x, is it so only?

I had DEL mapped to Ctrl-d. My bad.

It's great the you determined the cause of the problem. Thank you for using hh and letting me know!

fn + delete


Dev osman

dashboard hostname fix
parse_cpuid fix
influx create database for target system dev.

Can you also match the font of hostname with data panels. As I see, fonts of "no data" and hostname are different.


validate_response() fails when 'pk' path parameter coerced by DRF

By default, DRF seems to change pk path parameters to the actual primary key field name for the schema. This leads to a strange error when the SchemaTester:
>>> response = client.get("/api/names/123/")
>>> schema_tester.validate_response(response)
openapi_tester.exceptions.UndocumentedSchemaSectionError: Error: Unsuccessfully tried to index the OpenAPI schema by `/api/names/{pk}/`.

For debugging purposes, other valid routes include:

    • /api/names/
    • /api/names/{id}/
    • ...

When I set REST_FRAMEWORK["SCHEMA_COERCE_PATH_PK"] = False in my settings, it works, but then the schema uses the path parameter {pk} instead of {id}, which is not very nice.
My Name model's primary key field name is id, and my ViewSet generating the routes looks like this:
class NameViewSet(viewsets.ReadOnlyModelViewSet):
    queryset = models.Name.objects.all()
    serializer_class = serializers.NameSerializer

router = SimpleRouter()
router.register(r"names", NameViewSet)

(Also possible that I've configured something incorrectly, since a lot has changed in the package recently...)

Thanks for reporting this issue.
I see we need to take some DRF settings into account.
You are generating schema with the drf management command?

I'm using drf-spectacular, but the same setting seems to apply.
If there's any way I can help, let me know.

Thanks for letting us know @saeub! @Goldziher and I discussed this earlier and I think we have all the information we need to implement a fix, most likely sometime early next week.
On an unrelated note, do you still have the same requirement for i18n-normalization that you raised in #115?
With @Goldziher as the driving force, we've more or less rewritten the library over the last few weeks, and the i18n handling is the one feature that we haven't yet implemented. If you no longer have any need for this feature we'll probably drop it and focus our attention towards writing tests and ironing out little wrinkles like this issue😊 The reason I ask is, I seem to recall you were documenting your schema manually, and that's how you originally found a need for the feature
Thanks again for the report 👌

Thanks a lot for your hard work @Goldziher and @sondrelg! :)
The project I mentioned in #115 still uses the i18n feature, so we haven't upgraded the package there yet. We're not able to use schema generators in any reasonable way there, so I'm pretty sure our manually written schema will stay on that one. It would be nice if the i18n feature returned, but it's not exactly urgent.
The project I'm working on at the moment uses drf-spectacular and will probably not need i18n in the API.

Question @saeub - if we simply generate the schema and automatically turn off the DRF schema settings, just generating vanilla specs. Will that work?
I mean if we temporarily override the drf settings within the test before we generate the schema:
from rest_framework.settings import api_settings

ORIGINAL_SCHEMA_COERCE_PATH_PK = api_settings.SCHEMA_COERCE_PATH_PK

api_settings.SCHEMA_COERCE_PATH_PK = False

<run code that generates schema>

api_settings.SCHEMA_COERCE_PATH_PK = ORIGINAL_SCHEMA_COERCE_PATH_PK

if we simply generate the schema and automatically turn off the DRF schema settings, just generating vanilla specs. Will that work?

Sounds like it could work. I was just trying to figure out at which point the setting is actually applied in rest_framework, and it appears to be pretty early (pytest gets stuck already in the collection phase when I add a breakpoint here). I wasn't able go get it to work by temporarily changing the setting in my test function.

@saeub  - can you try using this: https://docs.djangoproject.com/en/3.1/topics/testing/tools/#django.test.override_settings?

I tried using a django-pytest fixture like this (https://pytest-django.readthedocs.io/en/latest/configuring_django.html#overriding-individual-settings):
@pytest.fixture(autouse=True)
def schema_settings(settings):
    settings.REST_FRAMEWORK["SCHEMA_COERCE_PATH_PK"] = False

When I apply this, I can see that the django.conf.settings are modified inside the test function, but the error still remains. :(

@saeub all good. I merged a fix for this issue. Can you test using our master branch? If not we will release soon and you would be able to test 1.3.

@saeub  - v1.3.0 was release, please let us know if this resolves your issue (we also added support for the i18n parameter).

That's awesome, thanks a lot!

E   ValueError: Empty module name

<frozen importlib._bootstrap>:950: ValueError

The resolved_route looks like this: ResolverMatch(func=pench.api.views.NameViewSet, args=(), kwargs={'pk': '{id}'}, url_name=name-detail, app_names=[], namespaces=[], route=api/names/(?P<pk>[^/.]+)/$) (view_name is also 'name-detail')
If it's of any help, I could try reproducing the error in the test_project and writing a test for it? Also haven't tried the i18n parameter yet, but I will as soon as possible.

I'll let @Goldziher confirm, but I think it's safe to assume that submitting a PR reproducing the error would be very helpful 👏

Yes, a reproduction would be awesome.

@saeub - 1.3.2 was just released with a hotfix. I hope this fixes the issue (it fixed the test) :). Thanks for your assistance.

Like a charm! :partying_face: Thank you so much!


CI: auto label PR's

i usually forget

might have some annoying false positives, ex: if you are doing a refactor and changed a bunch of files, but probably useful overall

see any problems with enabling it for cars and CI? (other than if you refactor all the cars at once you will get every car's label)

I can still see a ton of FPs with those. Can we do something like "if only selfdrive/car/toyota is touched, label as toyota"? If not, perhaps there's a different action out there with more options?

looks like "all" is what we want. If "all" the files changed are in /toyota, apply the toyota label

Nice, then we should be able to do a bunch with basically no FPs.

This seems to be removing labels incorrectly on my PR (and not adding labels when it should): https://github.com/commaai/openpilot/pull/29880

This seems to be removing labels incorrectly on my PR (and not adding labels when it should): #29880

It's set to only add labels when it's 100% sure its not a false positive, and apparently the sync-labels doesn't work for manually added labels? might have to revert this

Well I simply modified a files in the selfdrive/car folder which should match multiple labels, yet it doesn't add them. That seems like a separate bug, no?

Well I simply modified files in the selfdrive/car folder which should match multiple labels, yet it doesn't add them. That seems like a separate bug, no?

I believe it includes the opendbc

Ah, so the full set of changed files needs to be in that label's list, or it doesn't add it? So if you modify /tools and selfdrive/car/**, it won't add any labels?

Ah, so the full set of changed files needs to be in that label's list, or it doesn't add it? So if you modify /tools and a directory without a label, it won't add any labels?

Yes, adeeb didn’t want any false positives, example of you change all the car brands for a refactor you would get all the car labels


Don't automatically forward debug ports in auto attach

js-debug's auto attach "smart" mode causes a process to enter auto attach, without explicit flags. When entering debug mode, we let the OS choose a random free port (0) since we don't need any specific port.
I noticed when working in a remote container that this caused a bunch of ports to automatically be forwarded in the remote.

Unfortunately this message is printed by Node and I cannot always stop it from printing.
Is there any way we could exclude the pattern Debugger listening on ... from automatic forwarding?

@connor4312 we can exclude based on "Debugger listening on", but are there cases where Node may print that message and it isn't coming form j-debug's auto attach? Is there some other information about the terminal or state in VS Code I can use to exclude that link?

It will also be printed if running something like node --inspect manually. But I would venture to guess that in those cases people will probably be subsequently attaching with vscode, so forwarding would not be necessary since js-debug is a workspace extension.

Thanks!

I can't repro this in stable, and I don't see the notification when I trigger port forwarding another way, what am I missing?

The notification is new this iteration, so no repro in stable. To verify:

run command Remote-Containers: Try a sample...
Choose the node sample
Make sure debug auto attach is on (command Debug: Toggle Auto Attach -> choose Smart)
In the integrated terminal run node server.js
Verify that you don't see the port forwarded notification.

I don't see it, but do I expect to see it in this case?

That case should forward the port.


Vulnerability roundup 77: cookie-0.4.4: 1 advisory

search, files

[ ] CVE-2017-18589 (nixos-19.09, nixos-unstable)

Scanned versions: nixos-19.09: 5f506b95f9f; nixos-unstable: c1966522d7d. May contain false positives.

unstable at 0.4.5
19.09 EOL
Closing


[AUTHZ] Enable authz plugin tests for Spark 3.4

Why are the changes needed?

Authz plugin's tests now pass with Spark3.4.
 mvn clean install -pl :kyuubi-spark-authz_2.12 -Pspark-3.4 -am -DskipTests  &&  mvn test -pl :kyuubi-spark-authz_2.12 -Pspark-3.4

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #4909 (b0bdc10) into master (855cb0b) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master   #4909   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         557     557
  Lines       30700   30703    +3
  Branches     3995    3996    +1
======================================
- Misses      30700   30703    +3

Impacted Files
Coverage Δ

...ubi/plugin/spark/authz/serde/tableExtractors.scala
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks, merged to master


DateTimeOffset is not supported on POST

When you POST a document that uses the C# type DateTimeOffset, you will receive a 500 error, internally this is an InvalidCastException.
GET works fine as this is a simpler serialisation.
Investigation
I believe it is because the attribute holding the time is being cast into a DateTime type rather than DateTimeOffset.

I think this is related to the type conversions on POST/PATCH. The Delta object key/value pairs have wrong typed values for given properties. For instance, long (for an int in the model) or a double (for a Decimal in the model). It looks like de-serialization on POST/PATCH is either not using the right type information or entirely ignores it. This is quite an issue even for simple properties. Even the sample project stops working when you add an int property to Article model and try to POST or PATCH.


light mode not compatable?

Info:

OS: mac os 13.1 (22C65)
Logseq ver: 0.8.16 (install through homebrew)
Plugin ver: 3.2.6
[no? ] ⚠ Do i have issue with DISABLED my custom.css?
[ no?] ⚠ Do i have the same on default theme?

Description:
when in light mode no changes will be shown (just logseq standard light mode). No color changes, background etc. Also, when clicking on cells to change color values the color palate does not pop up. Everything functions as needed in dark mode

"Default" theme not chosen? "Awesome styler light" active?

Try to reload Logseq (Cmd+R) or restart. Did it help?

"Default" theme not chosen? "Awesome styler light" active?

it was indicated as selected. However I tried clicking on it and the page refreshed and is now working. Unsure as to why it was behaving in that way but for now it appears resolved.
Thank you for all your hard work btw. This is pretty sweet


Roving and Test Receiver Metadata; PIT arrays

Does it make sense to add metadata for the roving and test receivers to the rt_site_metadata.xlsx file? Maybe as a new tab? Or in the existing tab except with site_type as "test" or "roving"?
Which begs the question, do we add in PIT tag arrays including the ones at EVR and in the Lower Lemhi? And use those observations in analysis.

I added the roving, test, and activation receiver names to rt_site_metadata.xlsx under the 'other_receivers' tab.
I also added all of the PIT arrays to the site_metadata tab in that file. Additionally, we have a shapefile data/prepped/spatial/rt_site_metadata.shp containing the site metadata


Remove unused channels dependency

This was preventing the updating of downstream packages to newer
versions of the SDK.

Yup, these are needed for bringing the client and actor to newer versions of the sdk and forecast actors.
Please feel free to merge when you get a chance, I don't have write access.
A new release soon would be nice as well, to bring the downstream packages up to date.


Override keyboard input

Robotgo version (or commit ref): v0.100.10
Go version: 1.17.5
Gcc version: 11.1.0
Operating system and bit: Linux x64
Resolution: 1680x1050
Can you reproduce the bug at Examples:

[ ] Yes (provide example code)
[ ] No
[+] Not relevant

Is it possible to override keyboard input so that the original input is cancelled?
For example : I have an EventHook that captures a press of the "w" key and then taps the "q" key. I would like to prevent the original input from being applied. Normally if you were to type w with that code running you would see "wq" appear but I am looking for a way to stop the original input from going through.

Relevant suggestion.
At the moment I am only thinking of using SetWindowsHookExA and WH_KEYBOARD_LL callback manually

now this repo dont support this,  but the underwood lib  uiohook  support prevent event propagation by set event.reserved = 1
this need to refactor  the wrap of uiohook, now code use chan string to pass event from go side to c code, so event if you set
the  event.Reserved = 1 , it has no effect,  need a pr to fix this. and  the uiohook lib original  support this feature in windows and
macos , not support x11,  maybe it will support x11 and wayland in 1.3 by evdev.  you can read the two link  for more details
https://github.com/go-vgo/robotgo/issues/525
https://github.com/robotn/gohook/issues/16   prevent father propogation
type Event struct {
	Kind     uint8 `json:"id"`
	When     time.Time
	Mask     uint16 `json:"mask"`
	Reserved uint16 `json:"reserved"`

	Keycode uint16 `json:"keycode"`
	Rawcode uint16 `json:"rawcode"`
	Keychar rune   `json:"keychar"`
}


fix: added correct type

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description

Related Tickets & Documents
closes #223

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

@NsdHSO can you update the description in the OP?

Yes sure, a little slice of pizza

To be clear, we needed a better description. I went ahead and updated it and the title.

Add User interface from the Supabase library.


fs integrity check on boot

Is your feature request related to a problem? Please describe.
In a deployment of mine it happened that COS_PERSISTENT was corrupted and prevented the system to boot. As I could not access to the machine except ssh from rescue mode (from host provider) and control panel it makes it really hard to debug
Describe the solution you'd like
A default cloud-config setting that checks fs in early stages and attempt to fix errors. ideally should output logs to state partition so they can be viewed afterwards, so it can just enable ideally systemd-fsck (although might not fit our partitioning logics https://github.com/systemd/systemd/blob/main/src/fsck/fsck.c#L298) .  We need a mechanism to propagate back this to derivatives from a common place (like, we do have already meta/cos-light for an opinionated default)
Describe alternatives you've considered
Let derivatives handle some sane default setting by themselves, and just adding appropriate docs for it
Additional context

Testing locally by trying to re-use systemd-fsck

I've triggered an ext corruption of COS_PERSISTENT with:
dd if=/dev/zero count=1 bs=4096 seek=0 of=/dev/XXXX

The system stalls during initramfs booting:

I couldn't work on this card today, so I'm leaving my notes from yesterday:

I'm trying to change cos-loop-img.sh and cos-mount-layout.sh by calling systemd-fsck appropriately, but currently my generated initramfs fail booting even LiveCD.


Rich text labels resetting unexpectedly when scene tree modified in game Godot 4.3-stable

Tested versions

Reproducible in: 4.3.stable, - Not reproducible in: 4.2 stable, 4.1.stable, and earlier godot versions

System information
Godot v4.3.stable - Windows 10.0.19045 - GLES3 (Compatibility) - NVIDIA GeForce MX250 (NVIDIA; <IP_ADDRESS>29) - Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz (8 Threads)
Issue description

For reference, I am using above code to change in-game scenes. This has worked for all versions until now and this property has been crucial for my project.
As of now, rich text labels are being reverted to default when above function switches to another mini-scene, then back.
Below is the edited rich text label using parsed bbcode(I tested and the code that edits the text does not run when switched back)

Now when the first function is called twice to change to another section then back, it turns into this, which is what it looks like initially and in the editor. No other nodes are affected except rich text labels.

Interestingly enough, with one of my rich text labels that was edited through a multi-threaded-process, it seems to keep the edits even with the scene change, however, the other rich text labels in that scene revert back to default.
Steps to reproduce
1: Create scene with rich text label
2: Add functionality to parse bbcode and change the text
3: Create a main scene
4: Use supplied function
For the project!
1: click the change scene button
2: click the change rich text button
3: click the change scene button twice
4: see the result
Minimal reproduction project (MRP)
richlabelbug.zip

Can confirm and bisecting now

Looks like a regression from:

https://github.com/godotengine/godot/pull/87530

CC @YeldhamDev
As a workaround you can disable auto translation, but I would say this is still a bug and the text shouldn't overwrite just on entering tree like this, but needs some discussion on what is the expected behavior and how to approach it

Thank you!
Just for my 2 cents, it is a lot easier for a dev to reset the text through code on scene change rather than store a string that resulted through an expensive function, and then make the top node call the scene to change the text back to desired display. Especially when most other gui elements follow the same rules.

At minimum the change in behavior needs to be evaluated and we need to see if that was a known consequence of this, can't find anything in the discussion on that PR that implies that this was expected, so I think this was unintentional
I'd say that entering the tree again shouldn't reset the text like this, but it could be related to the assignment of the bbcode like this or parsing, but it's unexpected and should at least be documented if it is considered an acceptable limitation or even desired behavior, but I'd say it's at least surprising and unusual and especially a significant change from the previous behavior


PIL.UnidentifiedImageError: cannot identify image file

Do you know why this error is occurring? Here is a reproducer:
from wsidicom import WsiDicom, WsiDicomWebClient

url = 'https://idc-external-006.uc.r.appspot.com/dcm4chee-arc/aets/DCM4CHEE/rs'
study_uid = '<IP_ADDRESS>.4.1.59<IP_ADDRESS>7135355.1068687300.1625944806011.3.0'
series_uid = '<IP_ADDRESS>.4.1.59<IP_ADDRESS>7135355.1068687300.1625944806011.2.0'

client = WsiDicomWebClient.create_client(url)

slide = WsiDicom.open_web(client, study_uid, series_uid)

slide.read_region((1920, 1920), 4, (1067, 1017))

I get this error:
Traceback (most recent call last):
  File "/home/patrick/test.py", line 11, in <module>
    slide.read_region((1920, 1920), 4, (1067, 1017))
  File "/home/patrick/virtualenvs/histomics/src/wsidicom/wsidicom/wsidicom.py", line 400, in read_region
    image = wsi_level.get_region(scaled_region, z, path, threads)
  File "/home/patrick/virtualenvs/histomics/src/wsidicom/wsidicom/group/group.py", line 318, in get_region
    image = instance.image_data.stitch_tiles(region, path, z, threads)
  File "/home/patrick/virtualenvs/histomics/src/wsidicom/wsidicom/instance/image_data.py", line 525, in stitch_tiles
    self._paste_tiles(
  File "/home/patrick/virtualenvs/histomics/src/wsidicom/wsidicom/instance/image_data.py", line 576, in _paste_tiles
    pool.map(thread_paste, tile_region.chunked_iterate_all(threads))
  File "/home/patrick/virtualenvs/histomics/src/wsidicom/wsidicom/thread.py", line 41, in map
    return (item for item in list(map(fn, *iterables)))
  File "/home/patrick/virtualenvs/histomics/src/wsidicom/wsidicom/instance/image_data.py", line 568, in thread_paste
    for tile_point, tile in zip(
  File "/home/patrick/virtualenvs/histomics/src/wsidicom/wsidicom/web/wsidicom_web_image_data.py", line 102, in get_decoded_tiles
    yield Image.open(io.BytesIO(frame))
  File "/home/patrick/virtualenvs/histomics/lib/python3.9/site-packages/PIL/Image.py", line 3298, in open
    raise UnidentifiedImageError(msg)
PIL.UnidentifiedImageError: cannot identify image file <_io.BytesIO object at 0x7f4aadc35680>

Note that this example contains uncompressed data.

Looks like I forgot to change to the new decoder at this line. Will fix this tomorrow.


Fixed init method of legacy BaseSetting class, fixes #8996, fixes #9006

The "return" statement was only a minor improvement, the breaking code was the passed "self" argument.
fixes #8996, fixes #9006
Please check the following:

[x] Do the tests still pass?[^1]
[x] Does the code comply with the style guide?

[x] Run make lint from the Wagtail root.

[ ] For Python changes: Have you added tests to cover the new/fixed behaviour?

Please describe additional details for testing this change.
[^1]: Development Testing
[^2]: Browser and device support
[^3]: Accessibility Target

labelled release blocker & added to 4.0 milestone
@th3hamm0r thanks for finding a fix here, code makes sense but I have not had a chance to review locally.

cherry picked into 4.0 stable 95a8a418f825c6548a00c67987061b69d22f0287


Update language-settings.md

Add marathi and azerbaijani language as per customer request.
https://mendix.atlassian.net/browse/SPX-3389

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@gourab14 , thank you for the PR! Could you also sign CLA? You need to do it once only.


Could not determine BlueZ version, bluetoothctl not available, assuming 5.51+

I get this error when I launch Bluetti to MQTT. How to fix it ?
Here is the log:
cont-init: info: /etc/cont-init.d/00-banner.sh exited 0
cont-init: info: running /etc/cont-init.d/01-log-level.sh
cont-init: info: /etc/cont-init.d/01-log-level.sh exited 0
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
s6-rc: info: service legacy-services successfully started
[20:35:25] INFO: Reading configuration settings...
[20:35:28] INFO: Starting bluetti-mqtt...
2023-03-06 20:35:37 INFO     Connecting to MQTT broker...
2023-03-06 20:35:37 INFO     Starting to poll clients...
2023-03-06 20:35:37 INFO     Connecting to clients: ['04:7F:0E:A4:08:54']
2023-03-06 20:35:37 WARNING  Could not determine BlueZ version, bluetoothctl not available, assuming 5.51+
2023-03-06 20:35:37 INFO     Connected to MQTT broker
2023-03-06 20:35:37 INFO     Sent discovery message of AC200M-2227000041902 to Home Assistant
2023-03-06 20:35:37 WARNING  filtered_messages() is deprecated and will be removed in a future version. Use messages() together with Topic.matches() instead.
2023-03-06 20:35:38 ERROR    Error connecting to device 04:7F:0E:A4:08:54:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/bluetti_mqtt/bluetooth/client.py", line 40, in run
await self.client.connect()
File "/usr/local/lib/python3.10/site-packages/bleak/init.py", line 471, in connect
return await self._backend.connect(**kwargs)
File "/usr/local/lib/python3.10/site-packages/bleak/backends/bluezdbus/client.py", line 190, in connect
assert_reply(reply)
File "/usr/local/lib/python3.10/site-packages/bleak/backends/bluezdbus/utils.py", line 20, in assert_reply
raise BleakDBusError(reply.error_name, reply.body)
bleak.exc.BleakDBusError: [org.bluez.Error.Failed] le-connection-abort-by-local
2023-03-06 20:35:39 INFO     Retrying connection to 04:7F:0E:A4:08:54
2023-03-06 20:35:39 ERROR    Error connecting to device 04:7F:0E:A4:08:54:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/bluetti_mqtt/bluetooth/client.py", line 40, in run
await self.client.connect()
File "/usr/local/lib/python3.10/site-packages/bleak/init.py", line 471, in connect
return await self._backend.connect(**kwargs)
File "/usr/local/lib/python3.10/site-packages/bleak/backends/bluezdbus/client.py", line 190, in connect
assert_reply(reply)
File "/usr/local/lib/python3.10/site-packages/bleak/backends/bluezdbus/utils.py", line 20, in assert_reply
raise BleakDBusError(reply.error_name, reply.body)
bleak.exc.BleakDBusError: [org.bluez.Error.Failed] le-connection-abort-by-local

Same here :-)
Would appreciate your help

What Linux distribution are you running? Did you install the BlueZ package?

Thanks for quick response. Actually, I’m running your plug-in in home assistant, where it came integrated in SSMCD/bluetti2mqtt (https://github.com/SSMCD/bluetti2mqtt)
Do you have any idea to help me?

OK, at least for my case it got solved after https://github.com/SSMCD/bluetti2mqtt got an update which included BlueZ package. Thank you so far.


Add badge for codecov

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@da8fc34). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #25   +/-   ##
=========================================
  Coverage          ?   92.78%
=========================================
  Files             ?       10
  Lines             ?      319
  Branches          ?        0
=========================================
  Hits              ?      296
  Misses            ?       23
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da8fc34...17569ca. Read the comment docs.


ROE-1252 Api spec for OE Due Diligence

https://companieshouse.atlassian.net/browse/ROE-1252
Update api with validation for due diligence.

We need to update the Address schema to consider that the county and postcode are required and the property_name_number is not in due diligence models
"Address": {
  "type": "object",
  ...,
  "required": [
    "line_1",
    "town",
    "country"
  ],
  "oneOf": [
    {
      "required": [
        "property_name_number"
      ]
    },
    {
      "required": [
        "county",
        "postcode"
      ]
    }
  ]
},

Fixed in the following PR https://github.com/companieshouse/overseas-entities-api/pull/93


Source all environment variables in order to match Next

🐛 Bug Report
The library only loads environment variables when they're prefixed with NEXT_PUBLIC_.
https://github.com/toomuchdesign/next-page-tester/blob/a483a65fd228587f16f2ced52909acc2b42d459d/src/setEnvVars.ts#L24-L26
However, this is different than Next's behavior. These "private" environment variables are indeed made available to SSR  and build functions, such as getStaticProps.
Reproduction
Simply require an environment variable without a NEXT_PUBLIC_ prefix in a getStaticProps function, for example. It will be undefined.
Expected behavior
In order to match Next and expected functionality, these variables should be available to build and server runtime functionality.
Jest patch
Have you patched Jest as described here?

[ ] yes
[x] no

Run npx envinfo --preset jest
Paste the results here:
  System:
    OS: Linux 5.11 Arch Linux
    CPU: (20) x64 Intel(R) Core(TM) i9-7900X CPU @ 3.30GHz
  Binaries:
    Node: 15.9.0 - ~/.nvm/versions/node/v15.9.0/bin/node
    npm: 7.5.3 - ~/.nvm/versions/node/v15.9.0/bin/npm
  npmPackages:
    jest: ^26.6.3 => 26.6.3

Thanks for your work on this very helpful test library.

Hi @brettinternet, thanks for reporting.
These are our tests for environment variables. Maybe we're not considering data fetching methods. Have you found issues anywhere else then data fetching methods?

Btw the library actually differentiates between client and server side env vars.
Here is where the switch happens.
In order to investigate on this we'd need to reproduce the behaviour in tests.

Hi @brettinternet,
Tests weren't actually covering the scenario you mentioned, I updated them and -as far as I can see- they behave the way I understand Next.js works.
I created this PR https://github.com/toomuchdesign/next-page-tester/pull/197 for this.
Would you mind checking out the relevant branch and help us understand how next-page-tester doesn't align with Next.js when it comes to env vars? Thank you 🙌

The issue affected only getStaticProps. It was an actual missing implementation detail 👍

Hi @toomuchdesign, sorry for the delay. Thank you very much for your fix!


[Feature]: Changing certain fields shouldn't change the frecency score

Similar Issues

[X] Before filing, I have searched for similar issues.

Description
Currently changing almost any field will change the frecency score since its based on the unique IDs that are generated from the data it contains.
We should have a separate "database ID" that allows certain fields to be changed without resetting the frecency score.

cc @olimorris  I decided you were right about this.


⚠ SceneTime has degraded performance

In 27fb527, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1496 ms

Resolved: SceneTime performance has improved in 774a750 after 12 minutes.


Update the Slack invite link

Wanted to join the Slack channel but the invite link was no longer valid.

My github username @ gmail.

Invite link is still invalid.

Invite link is still invalid.

Heya, I don't think anyone uses the Slack channel anymore (shout if anyone does!). I would just post any issues in Github if Snap issue or Stackoverflow if its a general problem.

Heya, I don't think anyone uses the Slack channel anymore (shout if anyone does!). I would just post any issues in Github if Snap issue or Stackoverflow if its a general problem.

Ja, looks like the whole project is dead.

Ja, looks like the whole project is dead.

Depends what you mean by the project is dead. There haven't been any updates for a long time, but it's mature enough to use and there's enough knowledge out there to sort most issues. Same with Raphael. If you need something updated with some new requirement, maybe look at svg.js and ask them, as its the only other one I'm aware of really.

Depends what you mean by the project is dead. There haven't been any updates for a long time, but it's mature enough to use and there's enough knowledge out there to sort most issues. Same with Raphael. If you need something updated with some new requirement, maybe look at svg.js and ask them, as its the only other one I'm aware of really.

I switched to https://svgjs.com/ after struggeling with the documentation and realizing that the last commit is > 3 years old - which pretty means "dead" imho.

I switched to https://svgjs.com/ after struggeling with the documentation and realizing that the last commit is > 3 years old - which pretty means "dead" imho.


InvalidParameterValueInContainerTemplate - deploy quickstart image in portal with VNet

Please provide us with the following information:

This issue is a: (mark with an x)

[x] bug report -> please search issues before submitting
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
When I deploy the first ContainerApp with quickstart image thru azure portal ... I got the following error..

The following field(s) are either invalid or missing. Field 'template.containers.simple-hello-world-container.image' is invalid with details: 'Invalid value: "mcr.microsoft.com/k8se/quickstart:latest": Get "https://mcr.microsoft.com/v2/": EOF';. (Code: InvalidParameterValueInContainerTemplate)

Steps to reproduce

Setup Container App environment with workload profile, bind with VNet
Create Container App on this environment with quick start setting

Expected behavior Successfully deploy quickstart app and able to access homepage
Actual behavior failed to start deploying as claimed template error
Screenshots

Additional context

error in Portal, without manually specific template
my ContainerApp environment detail

with workload consumption profile as my organization setup UDR
bind to a VNet (with custom DNS)

Tried export the ARM template and converting it to yaml. Then deploy with az cli command to another environment in the consumption plan only and with VNet binding, could successfully deploy
same comment run on the environment (workload profile+VNet binded got same InvalidParameterValueInContainerTemplate error as portal)

Finally I found it is related network traffic block to image repository. It will be nicer if the error message could give more hints.
Thank you for your time.

@cachai2 we also just ran into this error and it took us a while to figure out that the problem was caused because of a firewall.

Something like, "The image repository isn't accessible"?

That would be nice! It would have saved us a lot of time :)


Function parameters are not inferable when defined via JSDoc using @type tag (with strict)

🔎 Search Terms
infer
@type
strict
JSDoc
Parameters
Function
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about type inference.

I've pulled the latest version of this repository and made a test case in the "fourslash" section, which demonstrates the problem I see.
(I couldn't see how to do something like this in the playground, sorry. Commit is linked)
⏯ Playground Link
https://github.com/scottmcginness/TypeScript/commit/cda5366448cb994866517834e0c1ca78b10042cb
💻 Code
// In file func.js
export function func(/** @type {string} */ param) {};

// In file use-it.js
import { func } from "./func.js";
type FuncParam = (typeof func) extends (...args: infer P) => any ? P : never;
//   ^ never, but expected [param: string]

In tsconfig.json:
{
  "compilerOptions": {
    "allowJs": true,
    "checkJs": true,
    "noEmit": true,
    "strict": true
  }
}

(The above definition is obviously just Parameters<T>, but put in full for comparison with another example below)
🙁 Actual behavior
The type FuncParam resolved to never (i.e. it took the false branch of the ternary)
🙂 Expected behavior
The type FuncParam should be [param: string], as given by the JSDoc @type tag
Additional information about the issue
This seems like a bug because all other ways of specifying the func function with JSDoc or the FuncParam type seemed to work as expected:

Using the @param tag instead:

/**
 * @param {string} param
 */
export function func(param) {};

yields FuncParam → [param: string]

Using a union with undefined works, but is not what I want for the definition of func:

export function func(/** @type {string | undefined} */ param) {};

yields FuncParam → [param?: string | undefined]

Trying the conditional without infer works (but is not usable for the intended purpose):

import { func } from "./func.js";
type FuncIsAFunc = (typeof func) extends (...args: any) => any ? 'good' : never;
//   ^ 'good'

Pulling just the first parameter out also works (but obviously that's not how Parameters<T> works):

import { func } from "./func.js";
type FuncParam = (typeof func) extends (arg: infer A) => any ? A : never;
//   ^ string

This also only seemed to occur specifically with strict: true. I couldn't see this with any of the other strict... options (though I may have missed something here)

All other views on the function seems to show that it is happily a function with a string parameter. i.e. the tooltip hover over func, while inside use-it.ts shows:
(alias) function func(param: string): void
import func

The output I see from the single test linked above (using hereby runtests --tests=jsDocInferredFunctionParameters) is:
  1) fourslash tests
       tests/cases/fourslash/jsDocInferredFunctionParameters.ts
         fourslash test jsDocInferredFunctionParameters.ts runs correctly:

      AssertionError: At marker '': quick info text: expected 'type FuncParam = never' to equal 'type FuncParam = [param: string]'
      + expected - actual

      -type FuncParam = never
      +type FuncParam = [param: string]

      at _TestState.verifyQuickInfoString (src\harness\fourslashImpl.ts:1863:16)
      at Verify.quickInfoIs (src\harness\fourslashInterfaceImpl.ts:268:20)
      at eval (jsDocInferredFunctionParameters.js:13:8)
      at runCode (src\harness\fourslashImpl.ts:4618:9)
      at runFourSlashTestContent (src\harness\fourslashImpl.ts:4576:5)
      at runFourSlashTest (src\harness\fourslashImpl.ts:4559:5)
      at Context.<anonymous> (src\testRunner\fourslashRunner.ts:59:39)
      at processImmediate (node:internal/timers:476:21)

This also happens for arrow functions and class methods, e.g.
// In func.js
export const func = (/** @type {string} */ param) => {};
export class Cls{
  method(/** @type {string} */ param) {}
}

with similar code as for FuncParam.

Funny behaviour, and why does it work somewhat better in only one file: Playground
function func(/** @type {string} */ param) {}
/**
 * @typedef {typeof func} Func
 * @typedef {Func extends (...args: infer P) => any ? P : never} FuncParam
 */

Result: type FuncParam = [param?: string] (it shouldn't be optional)

@kungfooman That's because the parameter itself is, in fact, optional:
function func(/** @type {string} */ param) {}
/**
 * @typedef {typeof func} Func
 * @typedef {Func extends (...args: infer P) => any ? P : never} FuncParam
 */

func();  // not an error

Playground link
I don't know why it's treated as optional, but the inference result is correct.

I don't know why it's treated as optional, but the inference result is correct.

If we turn on strictNullChecks it's suddenly never again :sweat_smile:
IMO it should only ever be considered optional if we use the Google Closure syntax:
function func(/** @type {string=} */ param) {}

(= after string)

Thank you for the playground links! Reproduces the problem nicely.
In the non-optional cases above, the tooltip hover still thinks that func is a function with a non-optional (param: string) parameter. Which seems correct. Later still having param be optional seems weird to me too, but maybe that's how optionality works 🤷
In addition, both the infer and func() remain inconsistent with how @param works (which is how I expect, in fact):
/** @param {string} param */
function func(param) {}
func() // error

and FuncParam as above is [param: string]. Playground link


[SIDE-2228] Add statement about Listen Active Window filtering

This PR explains what active window changes are filtered out.

I've updated the documentation to reflect the change in direction. Please re-review!


Upgrading from 2.1 to latest(2.3.1), the SSL Cert page and Proxy host cant be accessed

Describe the bug
Upgrading from 2.1 to latest(2.3.1), the SSL Cert page and Proxy host cant be accessed.
The console of Chrome shows lots of error

The other pages are normal, except dashboard, Proxy host and SSL Cert page.
To Reproduce
Have no idea if it's reproducable, but here's what i've did:

docker-compose down && docker-compose pull && docker-compose up -d
The bug shows.

Operating System

x86_64 Linux

BTW, re-downgrading to 2.1 shows the error:
[7/2/2020] [4:44:33 AM] [Migrate  ] › ℹ  info      Current database version:<PHONE_NUMBER>3840,
[7/2/2020] [4:44:33 AM] [Global   ] › ✖  error     The migration directory is corrupt, the following files are missing:<PHONE_NUMBER>3839_access_list_client.js,<PHONE_NUMBER>3840_access_list_client_fix.js,

Seems like a front-end error...

Refresh browser cache solves the problem, sorry :(


_FocusTraversalGroupNode should communicate creation in constructor.

No testing because the classes are private and the change impacts just debugging UX.
see Discord message

test-exempt: preparing for future testing


how to add custom icons in it

i have to add icons based on the tag so how to do that

@basitsaleemmb  did you found the answer?


Add option to enable progress bar when downloading

I suggest including progress_bar=True somewhere in tests. The perfect candidate is this test. This test is also supposed to verify the order of downloaded responses, although it might not be very accurate with only 3 items.

I can try adding an additional test that verifies the order? Would probably requires some mocking though :thinking:
I enabled it in this test to try it out, turns out one has to run it with pytest -s for the progress bars to display. How would you check whether the progress bar is displayed? Or do we just check that things dont fail if this is turned on?

For now we can also just add it so that it checks things don't fail. I'm not sure how to correctly check that tqdm is properly displayed.
I remembered that our eo-learn SentinelHubInputTask tests somewhat verify the order and those still pass. Should be fine for now.

Codecov Report

Merging #204 (b51cbb4) into develop (958b697) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #204      +/-   ##
===========================================
- Coverage    88.11%   88.08%   -0.03%
===========================================
  Files           38       38
  Lines         3945     3954       +9
===========================================
+ Hits          3476     3483       +7
- Misses         469      471       +2

Impacted Files
Coverage Δ

sentinelhub/download/client.py
95.78% <100.00%> (+0.44%)
:arrow_up:

sentinelhub/os_utils.py
71.87% <0.00%> (-6.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 958b697...b51cbb4. Read the comment docs.


Make optional the analyze part in CDB_EstimateRowCount

The CDB_EstimateRowCount function executes an ANALYZE in the affected tables of the query when that tables don't have stats. But this operation could come at a great cost if, for example, the table is big so we should add an optional parameter to skip the analyze part where performance is more important and we can deal with tables without stats.
This issue arises because in the tiler we're using this function to gather stats from the layer queries and execute an ANALYZE could penalize the performance

is this required to go out with vector/raster?

Due to a conversation with @javisantana I think is a nice to have more than a must

I don't think this is critical but there are a few things why we should change this:

writing in a function that is created to get data seems not fine.
calling this function with different users could give different results
depending on that statistics target it cold take a while and this function was created to be fast (that's why we are estimating and not counting)


[7.x] [meta] add helm 3.6.2 support (#1232)

Backports the following commits to 7.x:

[meta] add helm 3.6.2 support (#1232)

jenkins test this please


[Question] How to reduce Idle time?

I'm running a 3 minutes animation that synchronizes PIXI with an HTML5 video, on average the frame rate hovers around 58 - 60 FPS.
But in the middle of the animation, the browser suddenly goes into an idle mode which took around 1 - 0.5 seconds.
Looking at the timeline, there's no indication that the browser is GC'ing something or any other bottleneck.

And on further inspection, I've found Paul Iris' video, and he said Chrome will wait for the GPU to clear itself at certain times and there's nothing that the developer can do about it.
If that's the case is there, at least, some way to reduce the time? because 0.5 seconds is a noticeable pause.

Chrome 54.0.2840.59
MacOSX 10.11.6
Pixi.js 4.0.3

Usually "idle" in the dev tools just means there is nothing to do, so it does nothing. There are cases however where the browser needs to synchronize with the GPU process and block to do so. I'm not sure there is anything you can do about it though.

I see, thank you for the reply, I wonder if it depends on the computer as well.

It absolutely does, there are many many things that can affect it:

Browser
Browser version
CPU
GPU
GPU Driver version

If those time periods truly are Idle and not GC, then there isn't anything you can do to shorten it. Similar to your OS, the "idle" time is just the placeholder process that runs on that core when nothing is running:

Chrome is the same way, normally I read that graph you sent as "the code I had here was extremely fast, and the browser was just idle for most of this time".

Thank you for the fast response, incidentally, PIXI is a great product.

We've discovered the issue! apparently, it was the GC maxIdle time.
https://github.com/pixijs/pixi.js/blob/master/src/core/renderers/webgl/TextureGarbageCollector.js#L21
After extending it to 4 minutes, all the problem disappeared.

@bebensiganteng were you able to set this directly on the renderer instance, or did you have to modify the constructor?

We have a short deadline so we had to modify the PIXI class directly.

So the stalls were coming from the TextureManager cleaning up textures that it thought was unused?

@bebensiganteng - just following up here, don't know if you saw this, looks like MAX_IDLE is a setting in the latest release - https://github.com/pixijs/pixi.js/pull/3305


For a 0.3.0 release - take II

Adds missing compat entry in project

Codecov Report

Merging #29 (bd60265) into master (c5fd43d) will decrease coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   82.28%   81.88%   -0.40%
==========================================
  Files           5        5
  Lines         254      254
==========================================
- Hits          209      208       -1
- Misses         45       46       +1

Impacted Files
Coverage Δ

src/test.jl
94.94% <0.00%> (-1.02%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


GH-2538 Standalone Model API

GitHub issue resolved: #2538
Briefly describe the changes proposed in this PR:

created rdf4j-model-api maven module with no external dependencies
added rdf4j-model-api module as a dependency to rdf4j-model module

tweaked  rdf4j-model description

removed references to rdf4j-model classes from javadocs in org.eclipse.rdf4.model interfaces
migrated org.eclipse.rdf4.model test classes to org.eclipse.rdf4.model.impl

renamed ValueFactoryTest to SimpleValueFactoryTest

added default implementation of compareTo() to Namespace
replaced SimpleNamespace dependency in Model with lightweight  read-only package-local BasicNamespace implementation
migrated org.eclipse.rdf4j.common.annotation package to rdf4j-model-api module to allow @Experimental annotation of Triple interface

seems to make sense as long as other annotations are not added, as @Experimental/@InternalUseOnly relate mainly to APIs

migrated org.eclipse.rdf4j.model package to rdf4j-model-api module

PR Author Checklist (see the contributor guidelines for more details):

[ x] my pull request is self-contained
[ x] I've added tests for the changes I made
[ x] I've applied code formatting (you can use mvn process-resources to format from the command line)
[x ] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change
[ x] every commit has been signed off

Note: we merge all feature pull requests using squash and merge. See RDF4J git merge strategy for more details.

@knoan I've rebased this against the develop branch, since this is something we won't be releasing as a simple patch, but as part of the next minor release.

created oer.model.base package
created abstract Value test suites in oer.model package
created abstract Value classes in oer.model.base package
migrated Model.setNamespace() default implementation to AbstractNamespace
derived Simple* value classes from Abstract* companions
Add Simple*Test test classes  based on abstract value test suites

thanks for the PR, but it seems to fail on the code formatting of the AbstractTriple class... so could you perhaps run mvn process-resources  again ?

I went ahead and pushed code formatting fixes

thanks for the PR, but it seems to fail on the code formatting of the AbstractTriple class... so could you perhaps run mvn process-resources again ?

My bad… still honing the workflow :-(

This won't work unless the model-api module actually produces and publishes a test jar. I'm not sure yet if that is desirable - we use this approach in one other place (the rio api) but for everything else we have set up separate test suite projects instead. I'll take a look at this and if necessary refactor.

The goal here is to factor all tests that could be possibly applied to values; I incorrectly assumed that all modules were configured to attach a test jar by default. Let me know if you prefer to revert the dependency in rdf4j-model.

This class, and the other new abstract classes, could use a minimal bit of Javadoc.

Fixed, as well as other import/copyright issues.

I'll do a bit of work on resolving these conflicts (introduced by the merge of @hmottestad 's PR regarding sorting optimization) and if time permits will also take a look at the testsuite setup.

Unfortunately resolving these conflicts is not quite straightforward. For one thing the recent changes introduce a direct dependency between the Literal interface and the XSD vocabulary class (which is no problem if they're both in the same module but now they're separate).
I'm tempted to move the vocabulary classes into the api module, or at the very least the 'core' ones, like XSD, RDF, RDFS.

I resorted to minimal private or package-visible constants in LiteralTest and AbstractLiteral, reworking code as to require strings rather than IRIs.

I've merged develop into your branch and resolved the conflicts.  We'll need to review if this has actually been done correctly, but hopefully it at least compiles.

I've merged develop into your branch and resolved the conflicts.

Merging broke some tests in QueryEvaluationUtilTest and ValueComparatorTest

MemoryCascadeValueExceptionTest broken as well.

And EvaluationStrategyTest.testDatetimeSubtypesStrict()

This now looks fine to me. Thanks for your efforts @knoan !

Happy to contribute to the good work.


Timer 3 bar not fully painted in Part 13 (Interrupts)

Thanks for the write up!
I tried out part 13, which worked as expected, other than the "Timer 3" bar never filled on my Raspberry Pi 400.

Perhaps this is ok, but since it differs from your screenshot I thought I'd let you know. Feel free to close if this isn't an issue.
This is using latest raspberry pi firmware (commit 93d3f791a28ab369a62d2baf06035fc533b00864) and my config.txt looks like:
core_freq_min=500
disable_commandline_tags=1
kernel_old=1
arm_64bit=1
hdmi_group=1
hdmi_mode=16

Hi Pete,
I have seen that behaviour from time to time too. So it's hard to dismiss it and close it as an issue. Requires some serious debug I think. Unfortunately I've packed away my RPi4 now as I start to think about how to transition this to RPi5. Admittedly that's a lofty goal considering the hardware has changed so significantly! If I get too frustrated, I will come back and take another look at this. Have you any ideas what you think might be causing it?
Thanks,
Adam

Something occurs to me here:
void handle_irq() {
    unsigned int irq = REGS_IRQ->irq0_pending_0;

    while(irq) {
        if (irq & SYS_TIMER_IRQ_1) {
            irq &= ~SYS_TIMER_IRQ_1;

            handle_timer_1();
        }

        if (irq & SYS_TIMER_IRQ_3) {
            irq &= ~SYS_TIMER_IRQ_3;

            handle_timer_3();
        }
    }
}

If you get an interrupt that is not from SYS_TIMER_IRQ_1 or SYS_TIMER_IRQ_3, this loop will loop forever.
Now normally, this shouldn't be a problem, because only these two interrupts are enabled here:
void enable_interrupt_controller() {
    REGS_IRQ->irq0_enable_0 = SYS_TIMER_IRQ_1 | SYS_TIMER_IRQ_3;
}

However, in kernel.c we have
enable_interrupt_controller();
irq_enable();

Perhaps enable_interrupt_controller hasn't fully taken effect when irq_enable() is called, and when interrupts are enabled, some other interrupt leaks into handle_irq that isn't one of the two you process there. It would then get stuck in an infinite loop.
This is just a hunch, I don't have my rpi400 with me. But I can imagine two mitigations here: one would be to modify handle_irq while loop from:
while (irq) {

to:
 while(irq & (SYS_TIMER_IRQ_1 | SYS_TIMER_IRQ_3)) {

Another mitigation could be to drop a barrier instruction between these two lines:
enable_interrupt_controller();

// put a barrier here - DSB?

irq_enable();

I haven't read up on barriers properly yet, not sure if DSB is the correct barrier for this situation, but it could be worth looking into.
I haven't actually tested this hypothesis, it was just an idea that came to me while browsing through code while at a cafe without my rpi400 with me!
Let me know if it helps though!
Pete

Great thinking - let me know if it works if you get back to your Pi before I get to mine! Thanks so much for your brain cycles on this 😀 Also, do feel free to submit a PR if you find it solves the problem - would be great to acknowledge you as a contributor!

Looking into this today... weirdly I can't reproduce when building from WSL (Ubuntu) using gcc. However, when I build on MacOS using Clang, it's completely reproducible. Going to try your suggested fixes in both build environment now... Watch this space!

OK, so inserting the dsb sy barrier works a charm on Clang...

As does the more explicit while loop. I think that's my preferred solution to be honest... feels less "sledgehammer to crack a nut"! Will test on the Windows build environment and then commit... Thanks!!

Decided to go with both suggested fixes in the end for belt & braces! All tested and committed - thanks again for your input. I'd be grateful if you could test in your environment when you have a moment :)
Thanks,
Adam

Hi Adam,
Apologies that I never got round to looking at this again - I'm really happy the fixes worked though! When I get a chance I'm happy to retest here too. Thanks for addressing the issue, and for creating and sharing this really nice project. :-)
Pete

Frustratingly I have managed to repeat the bug even with both fixes in place concurrently! Back to the drawing board sadly... 😢

I think a few of my more recent changes have resolved this. Going to close (again) for now!


Call to undefined method Redis::transaction()

Hello,
I can't start queue jobs after I replace the default redis service provider to TillKruss\LaravelPhpRedis\RedisServiceProvider::class in laravel 5.1.  When I run " php artisan queue:work redis --sleep=3 --tries=3 --daemon" it says "PHP Fatal error:  Call to undefined method Redis::transaction() in /data/web/project/vendor/laravel/framework/src/Illuminate/Queue/RedisQueue.php on line 181".

Try upgrading your PhpRedis extension to the latest version.

If you can upgrade Laravel to 5.5, it handles PhpRedis internally and much better than this package.


ifk-python-template

Create a Python template for new repos, including many checks etc.

Is this still ongoing or can we move it to done @mgcth ?


Feat : Adding Dark Mode for Home/Landing Page with a toggle button

Issue Report
Adding a Feature
Title
Adding Dark Mode for Home/Landing Page
Description
I would like to add a dark mode button so that it can toggle between dark mode and light/default mode.
i will also write the code for dark mode so that the button is fully functional.
Feel free to be as detailed as necessary so we can replicate the issue accurately.
adding Dark Mode  will improve the UI/UX of this web app and i feel it is important as i am Front-End Developer
Expected Behavior
User will be able to switch between dark mode and light or default mode
PLEASE ASSIGN ME THIS ISSUE WITH gssoc-ext and hacktoberfest-accepted LABELS

@iamsaura8h assigned!

Hello, I’m Raj, a BTech student and full-stack web developer. You can check out my LinkedIn profile.
I would love to take on this task, please assign it to me!

Please assign me this task under gssoc24 extd

@saurabhbakolia i am almost done with the dark mode , added a toggle button beside cart icon using material ui pack .
i just need your suggestion what should be the dark color , currently i am using #333 for dark mode , so do let me know if you have something in mind .


This Extension prompts for Reload constantly

VSCode Version: Code 1.19.1 (0759f77bb8d86658bc935a10a64f6182c5a1eeba, 2017-12-19T09:46:23.884Z)
OS Version: Windows_NT x64 10.0.16299
Extensions:

Extension
Author (truncated)
Version

EditorConfig
Edi
0.11.1

tslint
eg2
1.0.24

vscode-angular2-emmet
jak
2.0.3

Angular2
joh
2.11.2

vscode-todo
Mat
0.8.0

csharp
ms-
1.13.1

sublime-keybindings
ms-
3.0.3 <<<<<<<<<<

debugger-for-chrome
msj
4.0.0

PROBLEM: Keybinds don't all work, and VSCode UI prompts for infinite Reload
Clicking reload causes the editor to reload, but the Extension still requests a reload, and it doesn't work as expected.

Steps to Reproduce:

Install Sublime Text Keymap v. 3.0.3
Click Reload

Reproduces without extensions: No, problem is with Extension
I put in a bug report with VSCode too
Ref:
https://github.com/Microsoft/vscode/issues/40655

@joshvito I installed this extension in 1.19.1 and I do not see the infinite reload behaviour.. Do you have any precise steps to see this behaviour?

@sandy081 I don't have any other steps. I just noticed that the Ctrl + Shft + D shortcut was opening the debugger and not duplicating lines anymore, so I went looking to see if the extension was still installed and noticed the behavior.
Did 1.19.1 recently get released? Maybe it is a problem with the editor updating after the Sublime Text Keymap was installed on a previous version of VSCode?
I will say I tried to uninstall then reinstall the Sublime Text Keymap. This did not have any effect.
My User Settings are set as follows:
// Place your settings in this file to overwrite the default settings
{
    "window.zoomLevel": 1,
    "editor.minimap.enabled": false,
    "editor.wordWrap": "on",
    "editor.cursorBlinking": "expand",
    "files.exclude": {
        "**/.git": false
    },
    "todoIgnore":   ["**/test/**", "**/node_modules/**", "**/dist/**"],
    "todoScanRegex":   "(?:TODO|FIXME|ToDo)\\s*\\W{0,1}(\\s+.*|(?:\\w|\\d).*)$",
    "terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe",
    "terminal.integrated.fontSize": 11,
    "html.format.wrapAttributes": "force",
    "extensions.ignoreRecommendations": true,
    "sublimeTextKeymap.promptV3Features": true,
    "editor.multiCursorModifier": "ctrlCmd",
    "editor.snippetSuggestions": "top",
    "editor.formatOnPaste": true,
    "tslint.autoFixOnSave": true
}


get-pip.py was outdated and did not work behind a proxy

This was reported in GH #136
get-pip.py was copied from pypa/pip@b9f2d5d5bb4c9dba8dbba3cc09a24fefb12fb38e

pinging this... Travi seemed to have failed for unrelated reasons. I am not sure how I can force a rebuild.

:+1:

Fixed in https://github.com/poise/poise-python by not bundling get-pip.py.


Switch to c/common from podman/v4

What type of PR is this?
/kind cleanup
/kind dependency-change
What this PR does / why we need it:
The source code has now being moved over to c/common which we now rely on.
Which issue(s) this PR fixes:

Fixes #504
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

/lgtm


Android audio do not support airpod (or any bluetooth)?

https://github.com/twilio/audioswitch#bluetooth-support
This might help.


[1.15] Consolidate contiguous memory copies

This PR backports #664 and #845 into the 1.15 branch.

Can one of the admins verify this patch?


Looks like USCIS has changed the request format from GET to POST

https://github.com/vicdus/uscis-case-statistics/blob/6c664b8ac3db042345217ededbcdbf7f2882c1f0/src/scraper/main.go#L176
My crawler also failed today. Looks like USCIS has change the request format from GET to POST.

fix wip

fixed https://github.com/vicdus/uscis-case-statistics/commit/01412826a2dd9b7a9ae2dae4db661a1549f2623f


Admonitions in preview

Admonitions are not displayed in Markdown preview
(maybe time to check all Extensions)

Yep indeed, this was never implemented. Would be good to have 👍🏻

Is it difficult to implement this?

No this just has to be implemented [here], but it's less complex because you don't have all the cursor stuff

HTMLTag, also doesn't get rendered

And also kinda related, this > ![note** parses as an admonition, which it really shouldn't I think. And maybe admonitions should be parsed as separate markdown nodes?


[BUG] Mate edit menu crashes when wheel group not assigned to current user

Version
23.02.02
Explain the issue and what happens
When the current user is not assigned to the wheel group, the mate desktop behaves poorly. Applications crash and fail to load
Explain how to reproduce the bug?
Replicate:

Unassign the current logged in user from the wheel group
Right-click on the Mate menu on the top left. Click Edit Menus
Go to system > preferences or administration.  The application crashes

This is also applicable to the wifi applet and the Software Station.
What is the Expected behavior (if applicable)
A preferable behavior might be an informative prompt mentioning wheel or an error message instead of a crash
Additional context (if applicable)
N/A

issue moved from ghostbsd/ghostbsd-src to ghostbsd/issues

So far, I can only reproduce the crash of the edit menu using preferences, not the menu itself.

Brisk-menu use in GhostBSD not update 4 years+
https://github.com/getsolus/brisk-menu
He have issue with crash and memory leak (in project issues)
Maybe need change menu to other?

Brisk-menu use in GhostBSD not update 4 years+ https://github.com/getsolus/brisk-menu He have issue with crash and memory leak (in project issues) Maybe need change menu to other?

The default is not brisk-menu but the MATE menu. There is no specification that it is the brisk menu.

I use the brisk menu daily and do not see memory leaks.


Empty textrows generate an error

Suggest filtering out NA rows and rows with < 5 characters on besceaApp.

Fixed by filtering for rows with alpha characters only.


upgrade tut to 0.4.6

I am not sure but it seems that it is everything which is required to use with scala 2.12

Thanks @julien-truffaut
I'm merging this now, as soon as travis pass, artifact will be published automatically as 0.3.2-SNAPSHOT, and we will be able to check it


Homebrew: Update Vale styles

Firstly, thanks so much for making these Vale styles available - we just implemented Vale for Homebrew's docs. ⭐
Description
In the process of introducing Vale for Homebrew's docs, we edited some portions of our style guide according to some less easy to fix existing documentation that made more sense with different rules:

We no longer sentence case H1 headings - only H2 and below. H1 and H2 headings are Title Cased apart from some exceptions for repo names.
The "Pull Request" => "pull request" swap is only done on paragraphs, to not conflict with the above Title Case for H1 stipulation.

Type of change

[x] New feature (non-breaking change which adds functionality)

It's just updating some styles for accuracy with our new style guide items.
How Has This Been Tested?

[x] yamllint

yamllint reports only that the docs link lines are too long, which seems fine.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published

This change is

Thanks!

Thanks @issyl0 And great to know you are using Vale on Homebrew, one of my favourite tools :)


Worker node of RKE2 cluster is stuck in Reconciling state on a Linode cluster when createPrivateIp: true

Rancher Server Setup

Rancher version: 2.6-head commit id: 7db4fe4
Installation option (Docker install/Helm Chart): Helm

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): RKE1

Information about the Cluster

Kubernetes version: v1.22.9-rc4+rke2r1 --> RKE2 downstream cluster - Linode RKE2 - 1 node all roles and 1 worker node

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom) Admin

Describe the bug
Worker node of RKE2 cluster is stuck in Reconciling state
To Reproduce

Deploy an RKE2 linode cluster - 1 node all roles and 1 worker node
Set createPrivateIp: true on the machine pools
The worker node is stuck in Reconciling state
Server logs

Apr 27 20:28:22 sowmya-linode-26head-pool1-029277cb-4nxh7 rke2[5531]: time="2022-04-27T20:28:22Z" level=error msg="runtime core not ready"
Apr 27 20:28:23 sowmya-linode-26head-pool1-029277cb-4nxh7 rke2[5531]: time="2022-04-27T20:28:23Z" level=info msg="Waiting to retrieve kube-proxy configuration; server is not ready: https://<IP_ADDRESS>:9345/v1-rke2/readyz: 500 Internal Server Error"
Apr 27 20:28:27 sowmya-linode-26head-pool1-029277cb-4nxh7 rke2[5531]: time="2022-04-27T20:28:27Z" level=info msg="Defragmenting etcd database"
Apr 27 20:28:27 sowmya-linode-26head-pool1-029277cb-4nxh7 rke2[5531]: time="2022-04-27T20:28:27Z" level=info msg="certificate CN=rke2,O=rke2 signed by CN=rke2-server-ca@1651088172: notBefore=2022-04-27 19:36:12 +0000 UTC notAfter=2023-04-27 20:28:27 +0000 UTC"
Apr 27 20:28:27 sowmya-linode-26head-pool1-029277cb-4nxh7 rke2[5531]: time="2022-04-27T20:28:27Z" level=info msg="certificate CN=rke2,O=rke2 signed by CN=rke2-server-ca@1651088172: notBefore=2022-04-27 19:36:12 +0000 UTC notAfter=2023-04-27 20:28:27 +0000 UTC"
Apr 27 20:28:27 sowmya-linode-26head-pool1-029277cb-4nxh7 rke2[5531]: time="2022-04-27T20:28:27Z" level=info msg="certificate CN=rke2,O=rke2 signed by CN=rke2-server-ca@1651088172: notBefore=2022-04-27 19:36:12 +0000 UTC notAfter=2023-04-27 20:28:27 +0000 UTC"
Apr 27 20:28:27 sowmya-linode-26head-pool1-029277cb-4nxh7 rke2[5531]: time="2022-04-27T20:28:27Z" level=info msg="certificate CN=rke2,O=rke2 signed by CN=rke2-server-ca@1651088172: notBefore=2022-04-27 19:36:12 +0000 UTC notAfter=2023-04-27 20:28:27 +0000 UTC"
Apr 27 20:28:27 sowmya-linode-26head-pool1-029277cb-4nxh7 rke2[5531]: time="2022-04-27T20:28:27Z" level=info msg="Failed to test data store connection: this server is a not a member of the etcd cluster. Found [-d1954041=https://<IP_ADDRESS>:2380/], expect: -d1954041=<IP_ADDRESS>"
Apr 27 20:28:27 sowmya-linode-26head-pool1-029277cb-4nxh7 rke2[5531]: time="2022-04-27T20:28:27Z" level=info msg="certificate CN=rke2,O=rke2 signed by CN=rke2-server-ca@1651088172: notBefore=2022-04-27 19:36:12 +0000 UTC notAfter=2023-04-27 20:28:27 +0000 UTC"
Apr 27 20:28:27 sowmya-linode-26head-pool1-029277cb-4nxh7 rke2[5531]: time="2022-04-27T20:28:27Z" level=info msg="certificate CN=rke2,O=rke2 signed by CN=rke2-server-ca@1651088172: notBefore=2022-04-27 19:36:12 +0000 UTC notAfter=2023-04-27 20:28:27 +0000 UTC"
Apr 27 20:28:27 sowmya-linode-26head-pool1-029277cb-4nxh7 rke2[5531]: time="2022-04-27T20:28:27Z" level=error msg="runtime core not ready"
Apr 27 20:28:28 sowmya-linode-26head-pool1-029277cb-4nxh7 rke2[5531]: time="2022-04-27T20:28:28Z" level=info msg="Waiting to retrieve kube-proxy configuration; server is not ready: https://<IP_ADDRESS>:9345/v1-rke2/readyz: 500 Internal Server Error"

Note:

I deployed another DO RKE2 1 node all roles and 1 worker node cluster on the same setup, and that came up Active. No issues seen on that.

Verified on v2.6-head https://github.com/rancher/rancher/commit/a31f5b8613d994122d9a7460700b028e61970ab5.
ENVIRONMENT DETAILS

Ubuntu 20.04: Docker Install
Ubuntu 18.04 HA
Rancher version: v2.6.5-rc6 & v2.6-head https://github.com/rancher/rancher/commit/a31f5b8613d994122d9a7460700b028e61970ab5
Browser: Chrome

TEST RESULT
PASS
VERIFICATION STEPS

Setup Rancher and navigate to Rancher UI. Created a standard user and login to Rancher as that new user.
Created a downstream Linode RKE2 cluster and enabled Private Networking in cluster configuration.
Verified that the cluster and machine pools came up as active:

In Cluster Management, navigated to the cluster's configuration and verified Private Networking is still set for the machine pools after cluster creation: