no more connection by webrtc

Hello,
I have been using your package for my internship project to perform experiments which needed wireless connection. The thing is since the new firmware update, I am not able to use webrtc protocol anymore, is it normal? If you have a solution, I take it as I am quite stuck right now to finish my experiments.
Thanks in advance.
Regards,
Peenut173.

Hello! It looks like the new version has a different way of communicating with the mobile app. Thanks for this issue, my advice is to roll back to 1.0.25 and dont use 1.1.1 firmware. In that case, your mobile app will not work, but the dog will.

Same here, just received my Go2 EDU with the latest firmware. Am trying this repo and cannot connect to the dog over webrtc.

Same here, just received my Go2 EDU with the latest firmware. Am trying this repo and cannot connect to the dog over webrtc.

You can use a wired connection with cycloneDDS over ethernet. It should work with new firmware.

Thanks for your quick answers, do you have any idea on how to get back to previous firmware version?

Thanks for your quick answers, do you have any idea on how to get back to previous firmware version?

I haven't done it before, but I think this option should be inside a mobile app.

Unfortunately no, Unitree said it was officially not doable 😭. Anyway I will try to find a way to fix this problem. Thank you! 😉

Hello, @Peenut173 ! Can you help me check a new method for webrtc that works with 1.1.1?
https://github.com/abizovnuralem/go2_ros2_sdk/tree/firmware_1_1_1_update
I would appreciate your help. I can't test it and debut it by myself because I am using old firmware. Thanks!

@peterhuisman, I would also appreciate your help integrating the new webrtc connection to this repo.

Hello @abizovnuralem ! Yes of course, I'll get back to you as soon as I have tested it!

@peterhuisman, I would also appreciate your help integrating the new webrtc connection to this repo.

Tried the new src, still receive the same error...
`[controller_server-12] [INFO] [1725881490.048107599] [local_costmap.local_costmap]: Activating
[controller_server-12] [INFO] [1725881490.048124212] [local_costmap.local_costmap]: Checking transform
[controller_server-12] [INFO] [1725881490.048241444] [local_costmap.local_costmap]: start
[rviz2-6] [ERROR] [1725881490.118126521] [rviz2]: The link is static or has unrealistic inertia, so the equivalent inertia box will not be shown.
[rviz2-6]
[rviz2-6] [ERROR] [1725881490.118251698] [rviz2]: The link is static or has unrealistic inertia, so the equivalent inertia box will not be shown.
[rviz2-6]
[rviz2-6] [INFO] [1725881490.161899564] [rviz2]: Stereo is NOT SUPPORTED
[lidar_to_pointcloud-5] /usr/lib/python3/dist-packages/scipy/init.py:146: UserWarning: A NumPy version >=1.17.3 and <1.25.0 is required for this version of SciPy (detected version 1.26.4
[lidar_to_pointcloud-5]   warnings.warn(f"A NumPy version >={np_minversion} and <{np_maxversion}"
[go2_driver_node-4] [INFO] [1725881490.614899118] [go2_driver_node]: Received ip list: ['<IP_ADDRESS>']
[go2_driver_node-4] [INFO] [1725881490.615240558] [go2_driver_node]: Connection type is webrtc
[go2_driver_node-4] [INFO] [1725881490.615528621] [go2_driver_node]: Connection mode is single
[go2_driver_node-4] ERROR:asyncio:Task exception was never retrieved
[go2_driver_node-4] future: <Task finished name='Task-4' coro=<RobotBaseNode.run() done, defined at /home/klminnovation/Desktop/ros2_ws_111/install/go2_robot_sdk/lib/python3.10/site-packages/go2_robot_sdk/go2_driver_node.py:479> exception=ClientConnectorError(ConnectionKey(host='<IP_ADDRESS>', port=8081, is_ssl=False, ssl=True, proxy=None, proxy_auth=None, proxy_headers_hash=None), ConnectionRefusedError(111, "Connect call failed ('<IP_ADDRESS>', 8081)"))>
[go2_driver_node-4] Traceback (most recent call last):
[go2_driver_node-4]   File "/home/klminnovation/.local/lib/python3.10/site-packages/aiohttp/connector.py", line 1073, in _wrap_create_connection
[go2_driver_node-4]     sock = await aiohappyeyeballs.start_connection(
[go2_driver_node-4]   File "/home/klminnovation/.local/lib/python3.10/site-packages/aiohappyeyeballs/impl.py", line 104, in start_connection
[go2_driver_node-4]     raise first_exception
[go2_driver_node-4]   File "/home/klminnovation/.local/lib/python3.10/site-packages/aiohappyeyeballs/impl.py", line 81, in start_connection
[go2_driver_node-4]     sock = await _connect_sock(
[go2_driver_node-4]   File "/home/klminnovation/.local/lib/python3.10/site-packages/aiohappyeyeballs/impl.py", line 166, in _connect_sock
[go2_driver_node-4]     await loop.sock_connect(sock, address)
[go2_driver_node-4]   File "/usr/lib/python3.10/asyncio/selector_events.py", line 501, in sock_connect
[go2_driver_node-4]     return await fut
[go2_driver_node-4]   File "/usr/lib/python3.10/asyncio/selector_events.py", line 541, in _sock_connect_cb
[go2_driver_node-4]     raise OSError(err, f'Connect call failed {address}')
[go2_driver_node-4] ConnectionRefusedError: [Errno 111] Connect call failed ('<IP_ADDRESS>', 8081)
[go2_driver_node-4]
[go2_driver_node-4] The above exception was the direct cause of the following exception:
[go2_driver_node-4]
[go2_driver_node-4] Traceback (most recent call last):
[go2_driver_node-4]   File "/home/klminnovation/Desktop/ros2_ws_111/install/go2_robot_sdk/lib/python3.10/site-packages/go2_robot_sdk/go2_driver_node.py", line 483, in run
[go2_driver_node-4]     await self.conn[robot_num].connect()
[go2_driver_node-4]   File "/home/klminnovation/Desktop/ros2_ws_111/install/go2_robot_sdk/lib/python3.10/site-packages/scripts/webrtc_driver.py", line 140, in connect
[go2_driver_node-4]     async with session.post(url, json=data, headers=headers) as resp:
[go2_driver_node-4]   File "/home/klminnovation/.local/lib/python3.10/site-packages/aiohttp/client.py", line 1353, in aenter
[go2_driver_node-4]     self._resp = await self._coro
[go2_driver_node-4]   File "/home/klminnovation/.local/lib/python3.10/site-packages/aiohttp/client.py", line 657, in _request
[go2_driver_node-4]     conn = await self._connector.connect(
[go2_driver_node-4]   File "/home/klminnovation/.local/lib/python3.10/site-packages/aiohttp/connector.py", line 564, in connect
[go2_driver_node-4]     proto = await self._create_connection(req, traces, timeout)
[go2_driver_node-4]   File "/home/klminnovation/.local/lib/python3.10/site-packages/aiohttp/connector.py", line 975, in _create_connection
[go2_driver_node-4]     _, proto = await self._create_direct_connection(req, traces, timeout)
[go2_driver_node-4]   File "/home/klminnovation/.local/lib/python3.10/site-packages/aiohttp/connector.py", line 1350, in _create_direct_connection
[go2_driver_node-4]     raise last_exc
[go2_driver_node-4]   File "/home/klminnovation/.local/lib/python3.10/site-packages/aiohttp/connector.py", line 1319, in _create_direct_connection
[go2_driver_node-4]     transp, proto = await self._wrap_create_connection(
[go2_driver_node-4]   File "/home/klminnovation/.local/lib/python3.10/site-packages/aiohttp/connector.py", line 1088, in _wrap_create_connection
[go2_driver_node-4]     raise client_error(req.connection_key, exc) from exc
[go2_driver_node-4] aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host <IP_ADDRESS>:8081 ssl:default [Connect call failed ('<IP_ADDRESS>', 8081)]
[go2_driver_node-4] Exception in thread Thread-1 (_spin):
[go2_driver_node-4] Traceback (most recent call last):
[go2_driver_node-4]   File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
[go2_driver_node-4]     self.run()
[go2_driver_node-4]   File "/usr/lib/python3.10/threading.py", line 953, in run
[go2_driver_node-4]     self._target(*self._args, **self._kwargs)
[go2_driver_node-4]   File "/home/klminnovation/Desktop/ros2_ws_111/install/go2_robot_sdk/lib/python3.10/site-packages/go2_robot_sdk/go2_driver_node.py", line 497, in _spin
[go2_driver_node-4]     rclpy.spin_once(node)
[go2_driver_node-4]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/init.py", line 199, in spin_once
[go2_driver_node-4]     executor = get_global_executor() if executor is None else executor
[go2_driver_node-4]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/init.py", line 102, in get_global_executor
[go2_driver_node-4]     __executor = SingleThreadedExecutor()
[go2_driver_node-4]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 721, in init
[go2_driver_node-4]     super().init(context=context)
[go2_driver_node-4]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 172, in init
[go2_driver_node-4]     self._guard = GuardCondition(
[go2_driver_node-4]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/guard_condition.py", line 23, in init
[go2_driver_node-4]     with self._context.handle:
[go2_driver_node-4] AttributeError: enter
[go2_driver_node-4] Exception ignored in: <function Executor.del at 0x736da09141f0>
[go2_driver_node-4] Traceback (most recent call last):
[go2_driver_node-4]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 243, in del
[go2_driver_node-4]     if self._sigint_gc is not None:
[go2_driver_node-4] AttributeError: 'SingleThreadedExecutor' object has no attribute '_sigint_gc'
[go2_driver_node-4] ERROR:asyncio:Task was destroyed but it is pending!
[go2_driver_node-4] task: <Task pending name='Task-2' coro=<spin() running at /home/klminnovation/Desktop/ros2_ws_111/install/go2_robot_sdk/lib/python3.10/site-packages/go2_robot_sdk/go2_driver_node.py:506> wait_for=>
[INFO] [go2_driver_node-4]: process has finished cleanly [pid 19566]
`

@peterhuisman thanks, have you seen in our logs Failed to get answer from server: Reason:?

I also own a Go2EDU with version 1.1.1, so I tried running it. I hope this can be of help to you. Additionally, I was able to connect using https://github.com/legion1581/go2_webrtc_connect .
errorlog.txt

@umsh315 Thanks! I took all the new handshake methods from that repo, can you try one more time? I just fix your error

I encountered this error. There may be something wrong with my environment, but it seems that the content of the error has indeed changed.
errorlog2.txt

@umsh315 and you rm -rf log install build folders and redo colcon build again please?

okay I have tested your new version and got this error:
INFO] [launch]: All log files can be found below /home/peenut/.ros/log/2024-09-11-11-13-27-056445-peenut-Nitro-AN517-54-16697
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [robot_state_publisher-1]: process started with pid [16710]
[INFO] [ros2_go2_video-2]: process started with pid [16712]
[INFO] [pointcloud_to_laserscan_node-3]: process started with pid [16714]
[INFO] [go2_driver_node-4]: process started with pid [16716]
[INFO] [lidar_to_pointcloud-5]: process started with pid [16718]
[INFO] [joy_node-6]: process started with pid [16720]
[INFO] [teleop_node-7]: process started with pid [16722]
[INFO] [twist_mux-8]: process started with pid [16724]
[INFO] [foxglove_bridge-9]: process started with pid [16726]
[INFO] [relay-10]: process started with pid [16728]
[twist_mux-8] [INFO] [1726046007.358990783] [twist_mux]: Topic handler 'topics.joy' subscribed to topic 'cmd_vel_joy': timeout = 0.500000s , priority = 10.
[teleop_node-7] [INFO] [1726046007.359647508] [TeleopTwistJoy]: Linear axis x on 1 at scale 0.400000.
[teleop_node-7] [INFO] [1726046007.359691523] [TeleopTwistJoy]: Linear axis y on 0 at scale 0.400000.
[teleop_node-7] [INFO] [1726046007.359696687] [TeleopTwistJoy]: Linear axis z on 3 at scale 1.000000.
[teleop_node-7] [INFO] [1726046007.359700843] [TeleopTwistJoy]: Angular axis yaw on 2 at scale 0.500000.
[twist_mux-8] [INFO] [1726046007.359983745] [twist_mux]: Topic handler 'topics.navigation' subscribed to topic 'cmd_vel': timeout = 0.500000s , priority = 15.
[ros2_go2_video-2] [INFO] [1726046007.384092007] [go2_video]: Starting go2_video
[robot_state_publisher-1] [INFO] [1726046007.384863283] [robot0.robot_state_publisher]: got segment map
[robot_state_publisher-1] [INFO] [1726046007.384924313] [robot0.robot_state_publisher]: got segment odom
[robot_state_publisher-1] [INFO] [1726046007.384933252] [robot0.robot_state_publisher]: got segment robot0/FL_calf
[robot_state_publisher-1] [INFO] [1726046007.384939385] [robot0.robot_state_publisher]: got segment robot0/FL_calflower
[robot_state_publisher-1] [INFO] [1726046007.384945401] [robot0.robot_state_publisher]: got segment robot0/FL_calflower1
[robot_state_publisher-1] [INFO] [1726046007.384951314] [robot0.robot_state_publisher]: got segment robot0/FL_foot
[robot_state_publisher-1] [INFO] [1726046007.384956988] [robot0.robot_state_publisher]: got segment robot0/FL_hip
[robot_state_publisher-1] [INFO] [1726046007.384962774] [robot0.robot_state_publisher]: got segment robot0/FL_thigh
[robot_state_publisher-1] [INFO] [1726046007.384968622] [robot0.robot_state_publisher]: got segment robot0/FR_calf
[robot_state_publisher-1] [INFO] [1726046007.384974422] [robot0.robot_state_publisher]: got segment robot0/FR_calflower
[robot_state_publisher-1] [INFO] [1726046007.384980259] [robot0.robot_state_publisher]: got segment robot0/FR_calflower1
[robot_state_publisher-1] [INFO] [1726046007.384986099] [robot0.robot_state_publisher]: got segment robot0/FR_foot
[robot_state_publisher-1] [INFO] [1726046007.384992078] [robot0.robot_state_publisher]: got segment robot0/FR_hip
[robot_state_publisher-1] [INFO] [1726046007.384997858] [robot0.robot_state_publisher]: got segment robot0/FR_thigh
[robot_state_publisher-1] [INFO] [1726046007.385003727] [robot0.robot_state_publisher]: got segment robot0/Head_lower
[robot_state_publisher-1] [INFO] [1726046007.385009332] [robot0.robot_state_publisher]: got segment robot0/Head_upper
[robot_state_publisher-1] [INFO] [1726046007.385015033] [robot0.robot_state_publisher]: got segment robot0/RL_calf
[robot_state_publisher-1] [INFO] [1726046007.385020673] [robot0.robot_state_publisher]: got segment robot0/RL_calflower
[robot_state_publisher-1] [INFO] [1726046007.385026384] [robot0.robot_state_publisher]: got segment robot0/RL_calflower1
[robot_state_publisher-1] [INFO] [1726046007.385032042] [robot0.robot_state_publisher]: got segment robot0/RL_foot
[robot_state_publisher-1] [INFO] [1726046007.385037685] [robot0.robot_state_publisher]: got segment robot0/RL_hip
[robot_state_publisher-1] [INFO] [1726046007.385043478] [robot0.robot_state_publisher]: got segment robot0/RL_thigh
[robot_state_publisher-1] [INFO] [1726046007.385049097] [robot0.robot_state_publisher]: got segment robot0/RR_calf
[robot_state_publisher-1] [INFO] [1726046007.385057327] [robot0.robot_state_publisher]: got segment robot0/RR_calflower
[robot_state_publisher-1] [INFO] [1726046007.385067190] [robot0.robot_state_publisher]: got segment robot0/RR_calflower1
[robot_state_publisher-1] [INFO] [1726046007.385077342] [robot0.robot_state_publisher]: got segment robot0/RR_foot
[robot_state_publisher-1] [INFO] [1726046007.385087282] [robot0.robot_state_publisher]: got segment robot0/RR_hip
[robot_state_publisher-1] [INFO] [1726046007.385095745] [robot0.robot_state_publisher]: got segment robot0/RR_thigh
[robot_state_publisher-1] [INFO] [1726046007.385104125] [robot0.robot_state_publisher]: got segment robot0/base_footprint
[robot_state_publisher-1] [INFO] [1726046007.385114158] [robot0.robot_state_publisher]: got segment robot0/base_link
[robot_state_publisher-1] [INFO] [1726046007.385124013] [robot0.robot_state_publisher]: got segment robot0/front_camera
[robot_state_publisher-1] [INFO] [1726046007.385133938] [robot0.robot_state_publisher]: got segment robot0/imu
[robot_state_publisher-1] [INFO] [1726046007.385144026] [robot0.robot_state_publisher]: got segment robot0/radar
[ros2_go2_video-2] [INFO] [1726046007.385932352] [go2_video]: Connecting to the robot's video stream
[ros2_go2_video-2] Logger is already initialized
[lidar_to_pointcloud-5] Traceback (most recent call last):
[lidar_to_pointcloud-5]   File "/media/peenut/programmes/dossier_LORIA/robot_go2/code_go2/go2_ws/install/go2_robot_sdk/lib/go2_robot_sdk/lidar_to_pointcloud", line 33, in
[lidar_to_pointcloud-5]     sys.exit(load_entry_point('go2-robot-sdk', 'console_scripts', 'lidar_to_pointcloud')())
[lidar_to_pointcloud-5]   File "/media/peenut/programmes/dossier_LORIA/robot_go2/code_go2/go2_ws/install/go2_robot_sdk/lib/go2_robot_sdk/lidar_to_pointcloud", line 25, in importlib_load_entry_point
[lidar_to_pointcloud-5]     return next(matches).load()
[lidar_to_pointcloud-5]   File "/usr/lib/python3.10/importlib/metadata/init.py", line 171, in load
[lidar_to_pointcloud-5]     module = import_module(match.group('module'))
[lidar_to_pointcloud-5]   File "/usr/lib/python3.10/importlib/init.py", line 126, in import_module
[lidar_to_pointcloud-5]     return _bootstrap._gcd_import(name[level:], package, level)
[lidar_to_pointcloud-5]   File "", line 1050, in _gcd_import
[lidar_to_pointcloud-5]   File "", line 1027, in _find_and_load
[lidar_to_pointcloud-5]   File "", line 1006, in _find_and_load_unlocked
[lidar_to_pointcloud-5]   File "", line 688, in _load_unlocked
[lidar_to_pointcloud-5]   File "", line 883, in exec_module
[lidar_to_pointcloud-5]   File "", line 241, in _call_with_frames_removed
[lidar_to_pointcloud-5]   File "/media/peenut/programmes/dossier_LORIA/robot_go2/code_go2/go2_ws/build/go2_robot_sdk/go2_robot_sdk/lidar_to_point.py", line 30, in
[lidar_to_pointcloud-5]     import open3d as o3d
[lidar_to_pointcloud-5] ModuleNotFoundError: No module named 'open3d'
[ERROR] [lidar_to_pointcloud-5]: process has died [pid 16718, exit code 1, cmd '/media/peenut/programmes/dossier_LORIA/robot_go2/code_go2/go2_ws/install/go2_robot_sdk/lib/go2_robot_sdk/lidar_to_pointcloud --ros-args --params-file /tmp/launch_params_rc1o6v1i'].
[foxglove_bridge-9] [INFO] [1726046007.691859738] [foxglove_bridge_component_manager]: Load Library: /opt/ros/humble/lib/libfoxglove_bridge_component.so
[foxglove_bridge-9] [INFO] [1726046007.696631887] [foxglove_bridge_component_manager]: Found class: rclcpp_components::NodeFactoryTemplate<foxglove_bridge::FoxgloveBridge>
[foxglove_bridge-9] [INFO] [1726046007.696675208] [foxglove_bridge_component_manager]: Instantiate class: rclcpp_components::NodeFactoryTemplate<foxglove_bridge::FoxgloveBridge>
[foxglove_bridge-9] [INFO] [1726046007.700041799] [foxglove_bridge]: Starting foxglove_bridge (humble, 0.8.0@) with WebSocket++/0.8.2
[foxglove_bridge-9] [INFO] [1726046007.700874374] [foxglove_bridge]: [WS] Server running without TLS
[foxglove_bridge-9] [INFO] [1726046007.701073313] [foxglove_bridge]: [WS] WebSocket server listening at ws://<IP_ADDRESS>:8765
[foxglove_bridge-9] [INFO] [1726046007.701081190] [foxglove_bridge]: [WS] WebSocket server run loop started
[go2_driver_node-4] [INFO] [1726046008.109208135] [go2_driver_node]: Received ip list: ['<IP_ADDRESS>']
[go2_driver_node-4] [INFO] [1726046008.109513593] [go2_driver_node]: Connection type is webrtc
[go2_driver_node-4] [INFO] [1726046008.109761428] [go2_driver_node]: Connection mode is single
[go2_driver_node-4] ERROR:asyncio:Task exception was never retrieved
[go2_driver_node-4] future: <Task finished name='Task-4' coro=<RobotBaseNode.run() done, defined at /media/peenut/programmes/dossier_LORIA/robot_go2/code_go2/go2_ws/build/go2_robot_sdk/go2_robot_sdk/go2_driver_node.py:479> exception=AttributeError("'NoneType' object has no attribute 'sdp'")>
[go2_driver_node-4] Traceback (most recent call last):
[go2_driver_node-4]   File "/media/peenut/programmes/dossier_LORIA/robot_go2/code_go2/go2_ws/build/go2_robot_sdk/go2_robot_sdk/go2_driver_node.py", line 483, in run
[go2_driver_node-4]     await self.conn[robot_num].connect()
[go2_driver_node-4]   File "/media/peenut/programmes/dossier_LORIA/robot_go2/code_go2/go2_ws/build/go2_robot_sdk/scripts/webrtc_driver.py", line 273, in connect
[go2_driver_node-4]     "sdp": sdp_offer.sdp,
[go2_driver_node-4] AttributeError: 'NoneType' object has no attribute 'sdp'
[go2_driver_node-4] Exception in thread Thread-1 (_spin):
[go2_driver_node-4] Traceback (most recent call last):
[go2_driver_node-4]   File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
[go2_driver_node-4]     self.run()
[go2_driver_node-4]   File "/usr/lib/python3.10/threading.py", line 953, in run
[go2_driver_node-4]     self._target(*self._args, **self._kwargs)
[go2_driver_node-4]   File "/media/peenut/programmes/dossier_LORIA/robot_go2/code_go2/go2_ws/build/go2_robot_sdk/go2_robot_sdk/go2_driver_node.py", line 498, in _spin
[go2_driver_node-4]     rclpy.spin_once(node)
[go2_driver_node-4]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/init.py", line 199, in spin_once
[go2_driver_node-4]     executor = get_global_executor() if executor is None else executor
[go2_driver_node-4]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/init.py", line 102, in get_global_executor
[go2_driver_node-4]     __executor = SingleThreadedExecutor()
[go2_driver_node-4]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 721, in init
[go2_driver_node-4]     super().init(context=context)
[go2_driver_node-4]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 172, in init
[go2_driver_node-4]     self._guard = GuardCondition(
[go2_driver_node-4]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/guard_condition.py", line 23, in init
[go2_driver_node-4]     with self._context.handle:
[go2_driver_node-4] AttributeError: enter
[go2_driver_node-4] Exception ignored in: <function Executor.del at 0x6ffbf0ba7880>
[go2_driver_node-4] Traceback (most recent call last):
[go2_driver_node-4]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 243, in del
[go2_driver_node-4]     if self._sigint_gc is not None:
[go2_driver_node-4] AttributeError: 'SingleThreadedExecutor' object has no attribute '_sigint_gc'
[go2_driver_node-4] ERROR:asyncio:Task was destroyed but it is pending!
[go2_driver_node-4] task: <Task pending name='Task-2' coro=<spin() done, defined at /media/peenut/programmes/dossier_LORIA/robot_go2/code_go2/go2_ws/build/go2_robot_sdk/go2_robot_sdk/go2_driver_node.py:491> wait_for=>
[INFO] [go2_driver_node-4]: process has finished cleanly [pid 16716]
[foxglove_bridge-9] [INFO] [1726046008.707338041] [foxglove_bridge]: Removed channel 18 for topic "/odom" (nav_msgs/msg/Odometry)
[foxglove_bridge-9] [INFO] [1726046008.707432087] [foxglove_bridge]: Removed channel 17 for topic "/go2_states" (go2_interfaces/msg/Go2State)
[foxglove_bridge-9] [INFO] [1726046008.707445272] [foxglove_bridge]: Removed channel 16 for topic "/imu" (go2_interfaces/msg/IMU)
[foxglove_bridge-9] [INFO] [1726046008.707456035] [foxglove_bridge]: Removed channel 15 for topic "/joint_states" (sensor_msgs/msg/JointState)
[foxglove_bridge-9] [INFO] [1726046008.707467114] [foxglove_bridge]: Removed channel 14 for topic "/point_cloud2" (sensor_msgs/msg/PointCloud2)
[ros2_go2_video-2] thread 'main' panicked at src/main.rs:107:62:
[ros2_go2_video-2] failed to create decoder: BackendError(ffmpeg::Error(5: Input/output error))
[ros2_go2_video-2] note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
[ERROR] [ros2_go2_video-2]: process has died [pid 16712, exit code 101, cmd '/media/peenut/programmes/dossier_LORIA/robot_go2/code_go2/go2_ws/install/ros2_go2_video/lib/ros2_go2_video/ros2_go2_video --ros-args --params-file /tmp/launch_params_8nhtvl2p'].
it says there is no module "sdp". Is the webrtc connection supposed to use the AP of the GO2 or not?

you should pull again, @Peenut173

Ok, just updated the master branch, now it should work! But we still need to rewrite the video stream node to support the new method. I would be happy if someone would do that.

Ok, just updated the master branch, now it should work! But we still need to rewrite the video stream node to support the new method. I would be happy if someone would do that.

@Peenut173 Can you check it on your side and if webrtc is working you can close this issue

i can use this thanks!

@peterhuisman thanks, have you seen in our logs Failed to get answer from server: Reason:? Also I have added additional logs, can you try again please?

With this latest update, I am able to connect and have the lidar image.
Thanks for the help!!

Personally, I have this problem:
[go2_driver_node-3] [INFO] [1726127831.299035764] [go2_driver_node]: Received ip list: ['<IP_ADDRESS>']
[go2_driver_node-3] [INFO] [1726127831.299348527] [go2_driver_node]: Connection type is webrtc
[go2_driver_node-3] [INFO] [1726127831.299570769] [go2_driver_node]: Connection mode is single
[go2_driver_node-3] INFO:scripts.webrtc_driver:Connection state is connecting
[go2_driver_node-3] INFO:scripts.webrtc_driver:Connection state is failed
it tried to connect for a fairly long time before failing

Personally, I have this problem: [go2_driver_node-3] [INFO] [1726127831.299035764] [go2_driver_node]: Received ip list: ['<IP_ADDRESS>'] [go2_driver_node-3] [INFO] [1726127831.299348527] [go2_driver_node]: Connection type is webrtc [go2_driver_node-3] [INFO] [1726127831.299570769] [go2_driver_node]: Connection mode is single [go2_driver_node-3] INFO:scripts.webrtc_driver:Connection state is connecting [go2_driver_node-3] INFO:scripts.webrtc_driver:Connection state is failed
it tried to connect for a fairly long time before failing

Nevermind, it now works, but i don't see the robot anymore on rviz (nav2 and the other stuffs work), how can i put it again?

You dont see the urdf of the dog? Can you make a screenshot here please?

You can add this using robot model inside rviz

okay now it works, thanks a lot for your help and great job for your reactivity for this firmware update!

Hi I am having issues where I believe port 9991 for webrtc is closed and will not me connect to the unitree go2 robot using webrtc.
The following is my connection error:
[go2_driver_node-3] ERROR:root:An error occurred: HTTPConnectionPool(host='<IP_ADDRESS>', port=9991): Max retries exceeded with url: /con_notify (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fdf36e374c0>: Failed to establish a new connection: [Errno 111] Connection refused'))
[go2_driver_node-3] ERROR:asyncio:Task exception was never retrieved
[go2_driver_node-3] future: <Task finished name='Task-4' coro=<RobotBaseNode.run() done, defined at /home/xtechlabrobot/ROS2/ros2_ws/install/go2_robot_sdk/lib/python3.10/site-packages/go2_robot_sdk/go2_driver_node.py:526> exception=ValueError('Failed to receive initial public key response with new method.')>
[go2_driver_node-3] Traceback (most recent call last):
[go2_driver_node-3]   File "/home/xtechlabrobot/ROS2/ros2_ws/install/go2_robot_sdk/lib/python3.10/site-packages/go2_robot_sdk/go2_driver_node.py", line 530, in run
[go2_driver_node-3]     await self.conn[robot_num].connect()
[go2_driver_node-3]   File "/home/xtechlabrobot/ROS2/ros2_ws/install/go2_robot_sdk/lib/python3.10/site-packages/scripts/webrtc_driver.py", line 334, in connect
[go2_driver_node-3]     raise ValueError(
[go2_driver_node-3] ValueError: Failed to receive initial public key response with new method.
[go2_driver_node-3] Exception in thread Thread-1 (_spin):
[go2_driver_node-3] Traceback (most recent call last):
[go2_driver_node-3]   File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
[go2_driver_node-3]     self.run()
[go2_driver_node-3]   File "/usr/lib/python3.10/threading.py", line 953, in run
[go2_driver_node-3]     self._target(*self._args, **self._kwargs)
[go2_driver_node-3]   File "/home/xtechlabrobot/ROS2/ros2_ws/install/go2_robot_sdk/lib/python3.10/site-packages/go2_robot_sdk/go2_driver_node.py", line 545, in _spin
[go2_driver_node-3]     rclpy.spin_once(node)
[go2_driver_node-3]   File "/home/xtechlabrobot/ROS2/ros2_humble/install/rclpy/local/lib/python3.10/dist-packages/rclpy/init.py", line 203, in spin_once
[go2_driver_node-3]     executor = get_global_executor() if executor is None else executor
[go2_driver_node-3]   File "/home/xtechlabrobot/ROS2/ros2_humble/install/rclpy/local/lib/python3.10/dist-packages/rclpy/init.py", line 106, in get_global_executor
[go2_driver_node-3]     __executor = SingleThreadedExecutor()
[go2_driver_node-3]   File "/home/xtechlabrobot/ROS2/ros2_humble/install/rclpy/local/lib/python3.10/dist-packages/rclpy/executors.py", line 721, in init
[go2_driver_node-3]     super().init(context=context)
[go2_driver_node-3]   File "/home/xtechlabrobot/ROS2/ros2_humble/install/rclpy/local/lib/python3.10/dist-packages/rclpy/executors.py", line 172, in init
[go2_driver_node-3]     self._guard = GuardCondition(
[go2_driver_node-3]   File "/home/xtechlabrobot/ROS2/ros2_humble/install/rclpy/local/lib/python3.10/dist-packages/rclpy/guard_condition.py", line 23, in init
[go2_driver_node-3]     with self._context.handle:
[go2_driver_node-3] AttributeError: enter
[go2_driver_node-3] Exception ignored in: <function Executor.del at 0x7fe1b2ab7250>
[go2_driver_node-3] Traceback (most recent call last):
[go2_driver_node-3]   File "/home/xtechlabrobot/ROS2/ros2_humble/install/rclpy/local/lib/python3.10/dist-packages/rclpy/executors.py", line 243, in del
[go2_driver_node-3]     if self._sigint_gc is not None:
[go2_driver_node-3] AttributeError: 'SingleThreadedExecutor' object has no attribute '_sigint_gc'
[go2_driver_node-3] ERROR:asyncio:Task was destroyed but it is pending!
[go2_driver_node-3] task: <Task pending name='Task-2' coro=<spin() running at /home/xtechlabrobot/ROS2/ros2_ws/install/go2_robot_sdk/lib/python3.10/site-packages/go2_robot_sdk/go2_driver_node.py:554> wait_for=>
[INFO] [go2_driver_node-3]: process has finished cleanly [pid 37748]


Added textAlign vertical, horizontal and wordWrap to Text2D

http://babylonjs-playground.com/#2AVSFH#172

http://babylonjs-playground.com/#2AVSFH#174

http://babylonjs-playground.com/#2AVSFH#177


Move the text formatting functions to a separate file

Codecov Report

Merging #6021 into master will increase coverage by 0.00%.
The diff coverage is 89.29%.

@@           Coverage Diff           @@
##           master    #6021   +/-   ##
=======================================
  Coverage   87.02%   87.03%
=======================================
  Files         141      142    +1
  Lines      156256   156256
=======================================
+ Hits       135985   135998   +13
+ Misses      20271    20258   -13

Impacted Files
Coverage Δ

src/edit.c
86.53% <ø> (-0.19%)
:arrow_down:

src/ops.c
92.20% <ø> (+0.25%)
:arrow_up:

src/option.c
92.95% <ø> (-0.01%)
:arrow_down:

src/textformat.c
89.15% <89.15%> (ø)

src/getchar.c
84.91% <93.75%> (+0.10%)
:arrow_up:

src/netbeans.c
75.18% <0.00%> (-0.08%)
:arrow_down:

src/os_unix.c
69.58% <0.00%> (-0.05%)
:arrow_down:

src/terminal.c
83.47% <0.00%> (-0.04%)
:arrow_down:

src/channel.c
89.81% <0.00%> (-0.04%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e17514...36323bd. Read the comment docs.


Add Fastly edge function

Adding Fastly edge function to the app.
Via: https://github.com/planetscale/f1-championship-stats/pull/19

On hold until this issue is resolved: https://github.com/planetscale/f1-championship-stats/pull/19#issuecomment-1232836182


Delete .travis.yml -- Travis CI is no longer free to open source

https://app.travis-ci.com/github/SwiftyJSON
The PR should summarize what was changed and why. Here are some questions to
help you if you're not sure:

What behavior was changed?
What code was refactored / updated to support this change?
What issues are related to this PR? Or why was this change introduced?

Checklist - While not every PR needs it, new features should consider this list:

[ ] Does this have tests?
[ ] Does this have documentation?
[ ] Does this break the public API (Requires major version bump)?
[ ] Is this a new feature (Requires minor version bump)?

Thanks @cclauss


Add Closure compiler externs file

This would help out those of us using the Google Closure compiler. For reference: https://github.com/google/closure-compiler/wiki/FAQ#how-do-i-write-an-externs-file.

Closing since it's been 2+ years with no traction on this and the core team doesn't have the bandwidth to maintain this. The closure compiler doesn't seem to be as popular now too.


Versioning is not fuctioning

Hi! I have NC <IP_ADDRESS> with installed Community version of Onlyoffice. When clicking on Collaboration->Version History menu I see that the list of versions is shown, and the notice Opening Document appears, which is not finishing anywhen. The app stucks until refresh of the page.
There's nothing in the logs of the Nextcloud.

Hi, to clarify

Community version of Onlyoffice

Are you using Nextcloud's Community DocumentServer?
Please note that Community Document Server was developed by Nextcloud Team, if you have any issues with it, please contact them in the appropriate GitHub repository.
If you are using our official method of integration (Nextcloud + dedicated Document Server instance as per our installation guide), we will be glad to answer your questions. Please see more info on our forum.

Hi, to clarify

Community version of Onlyoffice

Are you using Nextcloud's Community DocumentServer?
Please note that Community Document Server was developed by Nextcloud Team, if you have any issues with it, please contact them in the appropriate GitHub repository.
If you are using our official method of integration (Nextcloud + dedicated Document Server instance as per our installation guide), we will be glad to answer your questions. Please see more info on our forum.

Yes, this is NC installation. Thanks for additional clarifications.

In that case I'll close this issue


qps performance of nginx running in kata container has big fluctuation

qps performance of nginx running in kata container has big fluctuation
kata runtime 1.1.0
under test machine 1:
HW: physical core number:24 logical core :48 Mem: 188G
OS: Ubuntu 16.04
nignx version: 1.15.2
nginx image(nginx image is pulled from public image hub of docker.io)
ulimit -n =1024576
storage driver: direct-lvm mode;
vcpu = 1,2, 4,8, 32;
nginx worker =1, 8;
under test machine 2:
HW: physical core number:4 logical core :8 Mem: 16G
OS: Centos 7.3
nignx version: 1.15.2
nginx image(nginx image is pulled from public image hub of docker.io)
ulimit -n =1024
storage driver: direct-lvm mode;
vcpu=1, 2, 4, 8;
nginx worker = 1, 8;
Expected result
qps performance of nginx should be stable and there is s small fluctuation around a value;
for example, nginx running on runc will have a very fluctuation value( <+5% &<-5%) around the average value in the same environment;
Actual result
on the other test machine to run "ab -n 10000 -c 100/200/500/1000 http://targetip:8080/" to stress the qps performance of nginx running in above machines 1 &2;
we can find, the qps result will with big fluctuation as below:
in machine1 : vcpu = 4, 8, nginx worker =8,  qps with average value ~30000,  the worst value is ~10000, the best value is ~60000;
other vcpu and nginx worker number will have the same big fluctuation;
in machine 2: vcpu = 4, 8, nginx worker =8,  qps with average value ~8000,  the worst value is ~5000, the best value is ~9500;

(replace this text with the output of the kata-collect-data.sh script, after
you have reviewed its content to ensure it does not contain any private
information).

/cc @grahamwhaley  sinse he is working on PnP stuff
@grahamwhaley  any thoughts ?

Similar to #668, @egernst and @GabyCT have worked with ab/nginx tests v.recently and may have insight or have witnessed/worked around this... /cc'ing them for insights etc.

There are some new founds about fluctuation of QPS of nginx, please see test data:

QPS
100
200
500
1000
Tools

HostB  <--> Host A:     docker runc + bridge + port   mapping mode     nginx: worker process 1                 worker connections 1024
9224 - 9456
9261 - 9458
8207 - 9268
5651 -7668
Apache bench

11975 - 12008
11200 - 11976
9356 - 11927
8609  - 10561
Hey.go

Host B <--> Host A:      kata runtime + bridge +port   mapping mode     nginx: worker process 1                 worker connections   1024     kata: vcpu num = 1 mem=2048M
8806 - 9388
6400 - 9634
6877 - 9042
2668 -4787
Apache bench

9105 - 11994
10164 - 12011
8324 - 10196
2665 - 6061
Hey.go

Host B <--> Host A:      kata runtime + bridge +port   mapping mode     nginx: worker process 8                 worker connections   1024     kata: vcpu num = 1 mem=2048M
8283 - 9543
6689 - 8975
7130 - 9452
2676 - 5320
Apache bench

9605 -11821
8879 - 9297
10010 - 11510
2359 -6310
Hey.go

Host B <--> Host A:      kata runtime + bridge +port   mapping mode     nginx: worker process 8                 worker connections   1024     kata: vcpu num = 8   mem=2048M
8127 - 8765
6813 - 8413
7430 - 8925
2925 - 4323
Apache bench

7853 - 9605
8879 - 9297
6739 - 9192
2359 -5198
Hey.go

The data shows with the same configurations(vcpu =1 or 8; worker processes = 1 or 8, concurrency = 100/200/500):
1.the fluctuation of nginx qps is smaller by hey than by apache bench for kata;
2.the qps result is better by hey than by apache bench for kata and runc;
3.there is a big performance drop when concurrency = 1000 for kata whatever the value of vcpu/worker processes/concurrency is under the  test by ab or hey;
Thanks
Zhiming


Doc: Add a new Extention Feature(extention7.kt)

Description:

add a new extention7.kt

PR Instruction:

Issue will be assigned on a first come first serve basis.
If you are thinking to make a pr then at first be sure to get assigned.
before pushing your PR please make sure to fetch upstream.
your pr should be pushed on the develop branch only.
try to complete your assigned task within 3 to 5 days and if you need more time then please let me know. As the program has limited time only so please try to complete as fast as you can.
With your PR try to send a screenshot or screen recording of your work

I want to work on this issue

sure.


Rename "Common Data Service" as "Dataverse"

There are still references to Common Data Service connector in this page that should be replaced by Dataverse connector

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 047b94ce-db9f-ad01-5a62-b0539f2433cc
Version Independent ID: 1a8a9d3c-2d8b-e13c-042b-0a48fc444956
Content: Guidelines and troubleshooting when working with embedded canvas apps - Power Apps
Content Source: powerapps-docs/maker/model-driven-apps/embedded-canvas-app-guidelines.md
Service: powerapps
Sub-service: mda-maker
GitHub Login: @RichdiMSFT
Microsoft Alias: matp

@Nicokirr - Thank you for your feedback. The article has been updated to reflect the current connector name.
Closing issue.


Debugging skeleton-es2016 with IDEA/WebStorm

I start the application with gulp watch.
Then if I try to use JavaScript Debug configuration in JetBrains IDEA/WebStorm, I am able to debug the transpiled files in dist folder, but the debugger doesn't work with original javascript files in src folder.
To fix this issue I change in build/tasks/build.js:
.pipe(sourcemaps.write({includeContent: true}))

to
.pipe(sourcemaps.write({includeContent: false, sourceRoot: '/src'}))

Will this change break other tools used for debugging ?

I can't remember if we had a problem with that setting in the past or not. @PWKad Do you recall?

No I've not messed with the source maps really I think @AshleyGrant was the last one to look in to them so he may have a better idea.

And was it working with IDEA ? I am using version 15 and without this change debugger will not use JS6 files in /src folder. Tested on 3 machines with same setup.

Now it won't work in "skeleton-es2016-asp.net5" (VS 2015 Update 2), can't debug es6 scripts.
When i removed the fix, it worked in Chrome and Firefox :)
I change in build/tasks/build.js from:
.pipe(sourcemaps.write({includeContent: false, sourceRoot: '/src'}))
To
.pipe(sourcemaps.write({includeContent: true}))

How are you running the app? Are you using gulp watch or are you using the IDE. That may be the problem.

I use IDE and debugging in Chrome, this applies skeleton-es2016-asp.net5
Tested with IIS Express and DNX in Visual Studio, both works only before the change.
Run watch in Task Runner Explorer inside Visual Studio 2015

So, just to clarify, the settings need to be different based on what IDE is launching things. Is that correct?

@viewpit could you pls try:
.pipe(sourcemaps.write({includeContent: true, sourceRoot: '/src'}))

Either value of includeContent works in my tools (Chrome, JetBrains).
In my opinion setting sourceRoot is correct, because the source files are loaded from dist folder and sources are in src folder.
Without setting sourceRoot: '/src' debugging in Chrome is possible, but the source file displayed is not the real file on disk.

I agree with you @k2s.
So I tested skeleton-es2016-asp.net5 and skeleton-es2016, both worked with:
.pipe(sourcemaps.write({includeContent: true, sourceRoot: '/src'}))
@EisenbergEffect I only think you need to change from:
.pipe(sourcemaps.write({includeContent: false, sourceRoot: '/src'}))
To:
.pipe(sourcemaps.write({includeContent: true, sourceRoot: '/src'}))
Then it worked for gulp watch and IDE (Visual Studio 2015)

I remember distinctly that there was a problem with includeContent though. I'm not sure we can universally set things up this way. @ashleygrant Do you remember the details of this?


Wassaf/757 add resource bundle theme

Pre-Flight checklist

[x] Screenshots and design review for any changes that affect layout or styling

[x] Desktop screenshots
[x] Mobile width screenshots

[x] Testing

[x] Changes have been manually tested

What are the relevant tickets?
Closes #757
What's this PR do?

Adds theme for resource bundle.

How should this be manually tested?

Clone the following course https://github.com/OCW-LOCAL-COURSES/test-resource-bundle-sample
Verify resource bundle theme is as per required

Screenshots (if appropriate)

What's blocking this PR?


[SPARK-38187][K8S] Support resource reservation with volcano implementations

What changes were proposed in this pull request?

Add two configurations: and spark.kubernetes.job.minCPU and spark.kubernetes.job.minMemory
Apply min resource info into volcano podgroup

Why are the changes needed?
Support resource reservation with volcano implementations
Does this PR introduce any user-facing change?
Yes, configuration introduced
How was this patch tested?

UT
integration test

Please check the dev mailing list . Ramping down for Apache Spark 3.3 release started, @Yikun .

https://lists.apache.org/thread/ffdk52hkvgsc5ncjh1z0nv120jowtrld

[info] VolcanoSuite:
[info] - Run SparkPi with volcano scheduler (12 seconds, 199 milliseconds)
[info] - SPARK-38187: Run SparkPi Jobs with minCPU (45 seconds, 453 milliseconds)
[info] - SPARK-38187: Run SparkPi Jobs with minMemory (43 seconds, 329 milliseconds)
[info] - SPARK-38188: Run SparkPi jobs with 2 queues (only 1 enable) (17 seconds, 385 milliseconds)
[info] - SPARK-38188: Run SparkPi jobs with 2 queues (all enable) (37 seconds, 684 milliseconds)

[info] VolcanoSuite:
[info] - Run SparkPi with volcano scheduler (12 seconds, 211 milliseconds)
[info] - SPARK-38187: Run SparkPi Jobs with minCPU (34 seconds, 483 milliseconds)
[info] - SPARK-38187: Run SparkPi Jobs with minMemory (34 seconds, 345 milliseconds)
[info] - SPARK-38188: Run SparkPi jobs with 2 queues (only 1 enable) (17 seconds, 298 milliseconds)
[info] - SPARK-38188: Run SparkPi jobs with 2 queues (all enable) (37 seconds, 704 milliseconds)
[info] Run completed in 2 minutes, 18 seconds.
[info] Total number of tests run: 5
[info] Suites: completed 2, aborted 0
[info] Tests: succeeded 5, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.

https://github.com/apache/spark/pull/35733 is merged now . Could you rebase this PR, @Yikun ?

$ build/sbt -Pvolcano -Pkubernetes -Pkubernetes-integration-tests -Dtest.exclude.tags=minikube,r  -Dtest.include.tags=volcano  -Dspark.kubernetes.test.namespace=default "kubernetes-integration-tests/test"
[info] VolcanoSuite:
[info] - Run SparkPi with volcano scheduler (12 seconds, 245 milliseconds)
[info] - SPARK-38187: Run SparkPi Jobs with minCPU (43 seconds, 473 milliseconds)
[info] - SPARK-38187: Run SparkPi Jobs with minMemory (43 seconds, 354 milliseconds)
[info] - SPARK-38188: Run SparkPi jobs with 2 queues (only 1 enable) (18 seconds, 323 milliseconds)
[info] - SPARK-38188: Run SparkPi jobs with 2 queues (all enable) (38 seconds, 673 milliseconds)
[info] Run completed in 2 minutes, 38 seconds.
[info] Total number of tests run: 5
[info] Suites: completed 2, aborted 0
[info] Tests: succeeded 5, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 378 s (06:18), completed Mar 7, 2022 3:28:39 PM

$ k get pod
No resources found in default namespace.
$ k get queue
NAME      AGE
default   2d20h

@dongjoon-hyun Done.

[info] VolcanoSuite:
[info] - Run SparkPi with volcano scheduler (13 seconds, 248 milliseconds)
[info] - SPARK-38187: Run SparkPi Jobs with minCPU (33 seconds, 501 milliseconds)
[info] - SPARK-38187: Run SparkPi Jobs with minMemory (34 seconds, 336 milliseconds)
[info] - SPARK-38188: Run SparkPi jobs with 2 queues (only 1 enabled) (17 seconds, 203 milliseconds)
[info] - SPARK-38188: Run SparkPi jobs with 2 queues (all enabled) (29 seconds, 392 milliseconds)
[info] - SPARK-38423: Run SparkPi Jobs with priorityClassName (21 seconds, 190 milliseconds)
[info] - SPARK-38423: Run driver job to validate priority order (20 seconds, 239 milliseconds)
[info] Run completed in 2 minutes, 54 seconds.
[info] Total number of tests run: 7
[info] Suites: completed 2, aborted 0
[info] Tests: succeeded 7, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 362 s (06:02), completed Mar 7, 2022 10:07:21 PM

@dongjoon-hyun I'm not sure there were some misunderstanding, something below might help you understand.
We configure pod one by one but we only return the PreAdditionalK8SResource once. So there are only one podgroup is created for one job in current implementation.（the pre kubernetes only calls in driver side).

It seems that you decided not to use volcano API for some reasons

No more hidden reason, just make sure it can be more generic, then it can be created by prekubernetes create. So we only use volcano model in here.

Can we use new DefaultVolcanoClient().podGroups().load()?

if you meaned use this to build volcano-model, client side yaml load could be a alternative way to complete this, but I think we still need to left placeholder in yaml? and do format in feature step? This perhaps not flexiable, and a little bit hard to maintain.

@dongjoon-hyun I'm not sure there were some misunderstanding, something below might help you understand.
We configure pod one by one but we only return the PreAdditionalK8SResource once. So there are only one podgroup is created for one job in current implementation.（the pre kubernetes only calls in driver side).

It seems that you decided not to use volcano API for some reasons

No more hidden reason, just make sure it can be more generic, then it can be created by prekubernetes create. So we only use volcano model in here.

Can we use new DefaultVolcanoClient().podGroups().load()?

if you meaned use this to build volcano-model, client side yaml load could be a alternative way to complete this, but I think we still need to left placeholder in yaml? and do format in feature step? This perhaps not flexiable, and a little bit hard to maintain.
:), feel free to left any question you had, I will try my best to discussion to make work better.

Could you rebase this PR to the master and convert it as a test case addition PR, @Yikun ?

@dongjoon-hyun Done! Thanks! : )

[info] VolcanoSuite:
[info] - Run SparkPi with volcano scheduler (12 seconds, 738 milliseconds)
[info] - SPARK-38188: Run SparkPi jobs with 2 queues (only 1 enabled) (13 seconds, 294 milliseconds)
[info] - SPARK-38188: Run SparkPi jobs with 2 queues (all enabled) (25 seconds, 659 milliseconds)
[info] - SPARK-38423: Run SparkPi Jobs with priorityClassName (19 seconds, 310 milliseconds)
[info] - SPARK-38423: Run driver job to validate priority order (16 seconds, 467 milliseconds)
[info] - SPARK-38187: Run SparkPi Jobs with minCPU (29 seconds, 546 milliseconds)
[info] - SPARK-38187: Run SparkPi Jobs with minMemory (30 seconds, 473 milliseconds)
[info] Run completed in 2 minutes, 30 seconds.
[info] Total number of tests run: 7
[info] Suites: completed 2, aborted 0
[info] Tests: succeeded 7, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 236 s (03:56), completed 2022-3-10 9:17:46


train dataset

Thank you for Thank you for providing your code.
I've been running the pretrained model, and I'd like to know how to learn about custom data from the code you provided and how to transfer learning to custom data using the pretrained model.
Thank you.

Thank you for Thank you for providing your code. I've been running the pretrained model, and I'd like to know how to learn about custom data from the code you provided and how to transfer learning to custom data using the pretrained model. Thank you.

Hi,I want to know the results  when you run with the pretrained model.
When i run with the pretrained model, no matter how i change the images, the classification result is always the same, i cannot figure out what's wrong.


add support for "layered JARs" for Spring Boot 2.3 projects

Spring Boot as of version 2.3.0 introduced concept of "layered JARs" (https://spring.io/blog/2020/01/27/creating-docker-images-with-spring-boot-2-3-0-m1#layered-jars) and this seems to be very relevant to s2i-java build flow on the OpenShift.
The format of the Spring Boot layers index file can be seen here: https://docs.spring.io/spring-boot/docs/2.3.0.RELEASE/reference/htmlsingle/#executable-jar-war-index-files-layers
When layer information is provided there will be an entry Spring-Boot-Layers-Index: BOOT-INF/layers.idx in the jar META-INF/MANIFEST.MF manifest giving the location of the file.

Is there something s2i itself can take advantage of here, or is this just something that a particular s2i-java builder implementation (via its assemble/run scripts) would leverage?

if this is a question to me, then honestly I have no idea, who or how will benefit of this. I can only say that as an OpenShift and SpringBoot user I would want to be able to use this feature. And I would assume that RedHat or whoever is behind OpenShift, should be interesting in giving it's users useful features. Where am I wrong here?

@62mkv yes it was a question for you.  Since you brought up the feature, i'm trying to understand how you would like to see s2i take advantage of it.  My impression is that it is not something s2i itself (the tooling binary) can directly leverage, and that if an s2i builder image wanted to take advantage of it, it could do so without changes to the s2i binary itself (by providing an appropriate run/assemble script that leveraged this additional metadata).
this isn't about whether you're "wrong" here, this is about me trying to understand if there's actually a change that can/should be made in s2i to take advantage of this, or if this is a suggestion that should be directed specifically to the authors of s2i-java builder images, in which case I would close this issue and reopen it against one of our s2i-java builder repos.

well, I have been sent here from s2i-java repository. so I assumed it's either this (upstream) or them that should take that into consideration. see here https://github.com/fabric8io-images/s2i/issues/249
@rhuss said they don't believe how s2i-java might possibly implement it.. hence I've created this issue here

ok, I understand now.  Unfortunately it is unlikely s2i can take advantage of this.  S2I is fundamentally built around the idea of a single layer on top of a base image which inherently goes against the idea of layered jars.
The best you can do to take advantage of it would be to have an s2i-java builder image that makes use of the incremental/save-artifacts flow to extract the unchanging deps from the previous build/layered-jar and inject them into the subsequent image to potentially avoid repulling/building them during the assemble phase.  Which you can do today, butt would be something the s2i-java builder image would implement.
But I don't see that we'd introduce a concept of explicit layer construction in s2i itself to support layered jars for springboot explicitly, it just fundamentally doesn't align with how s2i works when constructing images.

Hi!

in which case I would close this issue and reopen it against one of our s2i-java builder repos.

is that the way to progress then, @bparees ?

I want to be clear i haven't thought fully through how a save-artifacts/assemble script would take advantage of these "layers" so i'm not 100% certain that an s2i-java builder can do something useful with this, but I don't see that the source-to-image project itself can do anything to leverage the feature.  So yes, i think discussing how an s2i-java builder image could take advantage of layered jars, within the s2i-java repo, makes more sense than discussing it here.  I'm happy to help participate in the discussion around save-artifacts/assemble there.


bug: Dev-Setup not working with quickstart / empty namespace set during creation

Describe the issue
Dear all,
while trying to get the development setup ready for my first contribution i ran into some issues.
Using the provided quickstart and the release-2.9 or master branch, fluentbit configuration is not possible with the developement environment.
The controller runs into the error message
2024-06-21T17:38:46+02:00       ERROR   Reconciler error        {"controller": "fluentbit", "controllerGroup": "fluentbit.fluent.io", "controllerKind": "FluentBit", "FluentBit": {"name":"fluent-bit","namespace":"fluent"}, "namespace": "fluent", "name": "fluent-bit", "reconcileID": "9013e238-2976-4f5b-be71-52eaac518aff", "error": "an empty namespace may not be set during creation"} and nothing happens with the FluentBit Object
To Reproduce

Clone the current branch
"make install && make run"
Create a fluentbit with the provided quickstart  k apply -f manifests/quick-start/fluentbit.yaml

Observe that no pods are getting created for fluentbit:
$ k get pods -A
NAMESPACE            NAME                                         READY   STATUS    RESTARTS   AGE
kube-system          coredns-76f75df574-pjmr4                     1/1     Running   0          5m42s
kube-system          coredns-76f75df574-qcxsp                     1/1     Running   0          5m42s
kube-system          etcd-kind-control-plane                      1/1     Running   0          5m58s
kube-system          kindnet-vthzg                                1/1     Running   0          5m42s
kube-system          kube-apiserver-kind-control-plane            1/1     Running   0          5m59s
kube-system          kube-controller-manager-kind-control-plane   1/1     Running   0          5m57s
kube-system          kube-proxy-pvvj9                             1/1     Running   0          5m42s
kube-system          kube-scheduler-kind-control-plane            1/1     Running   0          5m57s
local-path-storage   local-path-provisioner-7577fdbbfb-4j7s5      1/1     Running   0          5m42s

See the corresponding errors in the log:
2024-06-21T17:38:11+02:00       ERROR   Reconciler error        {"controller": "fluentbit", "controllerGroup": "fluentbit.fluent.io", "controllerKind": "FluentBit", "FluentBit": {"name":"fluent-bit","namespace":"fluent"}, "namespace": "fluent", "name": "fluent-bit", "reconcileID": "b8ea7f8e-9d64-4e79-9742-b04dfb4405cf", "error": "an empty namespace may not be set during creation"}

Expected behavior
FluentBit should successfully deploy
Your Environment
- Fluent Operator version: main-branch
- Container Runtime: Docker and kindest/node:v1.29.2
- Operating system: Ubuntu 22.04
- Kernel version: <IP_ADDRESS>-microsoft-standard-WSL2

How did you install fluent operator?
Using "make install && make run" for the developement environment
Additional context
No response

This has been a misunderstanding on my part about the inital setup. The Slack-channel was so kind to clear everything up!


DocBook Documentation

Currently the only documentation is the PHP include files (for IDE autocompletion etc). The plan is to create a complete * DocBook* as part of an official release.
See:

http://doc.php.net/phd/docs/
https://www.sammyk.me/how-to-contribute-to-php-documentation

See https://github.com/php-ds/docs

This has now been pushed to php.net
There are still some open issues, see the docs repo


Timeline for PagedPageView and PagedMasonryGridView

I found that the PagedPageView and PagedMasonryGridView is already ready and working in the develop branch. Just wanted some updates regarding when it will be released to pub.dev.
@edson-mgm looking forward to your response 🙂

They're officially published in the newest 4.0.0 version.


"Send now" button may lose the review (submit-review-as-single-comment)

I can't replicate it anymore but it happened twice for me.

Click "Send now"
The comment disappears
Nothing happens (the "new comment" form) should reappear.

Maybe one of these 2 awaits are not happening:
https://github.com/sindresorhus/refined-github/blob/9fa2a1dd71a0b2465fb67ab29918a7b63bdac0fa/source/features/submit-review-as-single-comment.tsx#L83-L91
Losing a comment is pretty bad.
https://github.com/sindresorhus/refined-github/issues/1598 could be useful too.

I'd suggest adding:

a 10s timeout on the observeOneMutation (via https://github.com/sindresorhus/p-timeout)
window.onbeforeload to avoid users leaving the page (and also a 'pjax:start' listener)

I found an error. getNewCommentField does not return a textarea as expected, in fact I have to select the textarea again later:
https://github.com/sindresorhus/refined-github/blob/75f4cc8b5fa9b75aa315a9b9a036e60d5abbadd0/source/features/submit-review-as-single-comment.tsx#L67-L72
getNewCommentField should probably be replaced with elementReady or a plain select

This feature has been completely broken for a while now (the button doesn't even appear anymore), and nobody complained or even seemed to notice. I suggest dropping it.
Besides, I never really got the point of this. It seems like a lot of complexity, just to avoid opening the main review dropdown and clicking on "Comment" :thinking:

The main issue with that is that a new "review" is created, so if you're just trying to leave a comment on a review it will appear twice on the main page.
This is not really an issue on single comments however, you're right. And it's kinda complex and dangerous. 🥲 So many reasons to drop it but that'd hurt my feelings.
It might be easier to hide those fake reviews instead.
DROP IT LIKE IT'S December 31st 2019


🐛 [firebase_storage] Unable to upload images on iOS When user background_locator together

Bug report
Describe the bug
UploadTask didn't work when I used firebase_storage and background_locator together.
Future<String> urlDownload(file) async {
var uuid = Uuid().v1();
Reference ref = FirebaseStorage.instance.ref().child("post_$uuid.jpg");
UploadTask uploadTask = ref.putFile(file);

String downloadUrl = await (await uploadTask.onComplete).ref.getDownloadURL(); <-- stuck at this line.
return downloadUrl;
}

dependencies:
- firebase_storage: ^10.2.16
- background_locator_2: ^2.0.5
or
- background_locator:
    git:
    url: https://github.com/caiobraga/background_locator.git

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
[✓] Flutter (Channel stable, 3.0.5, on macOS 12.5 21G72 darwin-arm (Rosetta),
    locale en-TH)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2020.3)
[✓] VS Code (version 1.71.0-insider)
Scanning for devices is taking a long time...[✓] Connected device (4 available)
[✓] HTTP Host Availability

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.17.6
Flutter SDK 3.0.5

dependencies:
- animated_text_kit 4.2.2 [flutter characters]
- assets_audio_player 3.0.4+1 [flutter rxdart uuid http path_provider assets_audio_player_web]
- auto_size_text 3.0.0 [flutter]
- awesome_notifications 0.6.21 [flutter platform intl]
- background_locator_2 2.0.5 [flutter]
- buddhist_datetime_dateformat 1.0.7 [flutter intl]
- cached_network_image 3.2.1 [flutter flutter_cache_manager octo_image cached_network_image_platform_interface cached_network_image_web]
- carousel_slider 4.1.1 [flutter]
- circle_checkbox 0.0.2+1 [flutter]
- cloud_firestore 3.4.3 [cloud_firestore_platform_interface cloud_firestore_web collection firebase_core firebase_core_platform_interface flutter meta]
- cloud_functions 3.3.3 [cloud_functions_platform_interface cloud_functions_web firebase_core firebase_core_platform_interface flutter]
- country_codes 2.2.0 [flutter]
- country_pickers 2.0.0 [flutter]
- cupertino_icons 1.0.5
- dio 4.0.6 [http_parser path]
- dotted_line 3.1.0 [flutter]
- drop_down_list 0.0.3 [flutter]
- dropdown_button2 1.7.1 [flutter]
- file_picker 4.6.1 [flutter flutter_web_plugins flutter_plugin_android_lifecycle plugin_platform_interface ffi path win32]
- firebase_auth 3.6.2 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_database 9.1.0 [firebase_core firebase_core_platform_interface firebase_database_platform_interface firebase_database_web flutter]
- firebase_messaging 11.4.4 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- firebase_storage 10.3.4 [firebase_core firebase_core_platform_interface firebase_storage_platform_interface firebase_storage_web flutter]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]
- flutter_animarker 3.2.0 [flutter google_maps_flutter_platform_interface vector_math]
- flutter_chat_ui 1.6.4 [diffutil_dart equatable flutter flutter_chat_types flutter_link_previewer flutter_parsed_text intl meta photo_view url_launcher visibility_detector]
- flutter_countdown_timer 4.1.0 [flutter]
- flutter_datetime_picker 1.5.1 [flutter]
- flutter_easyloading 3.0.5 [flutter flutter_spinkit]
- flutter_facebook_auth 4.4.1 [flutter flutter_facebook_auth_platform_interface flutter_facebook_auth_web]
- flutter_geocoder 0.2.2-nullsafety [flutter meta]
- flutter_launcher_icons 0.9.3 [args image path yaml]
- flutter_libphonenumber 1.2.4 [flutter]
- flutter_local_notifications 9.7.0 [clock flutter flutter_local_notifications_linux flutter_local_notifications_platform_interface timezone]
- flutter_native_splash 2.2.7 [args flutter flutter_web_plugins image js lint meta path universal_io xml yaml]
- flutter_phone_direct_caller 2.1.1 [flutter]
- flutter_polyline_points 1.0.0 [flutter http]
- flutter_rating_bar 4.0.1 [flutter]
- flutter_svg 1.1.3 [flutter meta path_drawing vector_math xml]
- flutter_switch 0.3.2 [flutter]
- flutter_thailand_provinces 1.0.1 [flutter sqflite]
- flutter_widget_from_html 0.8.5 [flutter flutter_widget_from_html_core fwfh_cached_network_image fwfh_chewie fwfh_just_audio fwfh_selectable_text fwfh_svg fwfh_url_launcher fwfh_webview html]
- flutter_zoom_drawer 3.0.3 [flutter]
- fluttertoast 8.0.9 [flutter flutter_web_plugins]
- font_awesome_flutter 10.1.0 [flutter]
- geocoding 2.0.4 [flutter geocoding_platform_interface]
- geolocator 8.2.1 [flutter geolocator_platform_interface geolocator_android geolocator_apple geolocator_web geolocator_windows]
- get 4.6.5 [flutter]
- getwidget 3.0.1 [flutter]
- google_maps_flutter 2.1.10 [flutter flutter_plugin_android_lifecycle google_maps_flutter_platform_interface]
- google_place 0.4.7 [http]
- google_sign_in 5.4.1 [flutter google_sign_in_android google_sign_in_ios google_sign_in_platform_interface google_sign_in_web]
- hexcolor 2.0.7 [flutter flutter_web_plugins]
- html_unescape 2.0.0
- image_picker 0.8.5+3 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_platform_interface]
- intl 0.17.0 [clock path]
- intro_slider 3.0.9 [flutter]
- kf_drawer 1.2.1 [flutter]
- list_tile_more_customizable 3.0.0 [flutter]
- load 1.0.0 [flutter]
- location_permissions 4.0.1 [flutter meta]
- map_launcher 2.3.0 [flutter]
- mime 1.0.2
- modal_bottom_sheet 2.1.0 [flutter]
- money_converter 2.0.1 [flutter http]
- multi_value_listenable_builder 0.0.2 [flutter]
- open_file 3.2.1 [flutter ffi]
- page_transition 2.0.9 [flutter]
- path_provider 2.0.11 [flutter path_provider_android path_provider_ios path_provider_linux path_provider_macos path_provider_platform_interface path_provider_windows]
- permission_handler 9.2.0 [flutter meta permission_handler_android permission_handler_apple permission_handler_windows permission_handler_platform_interface]
- photo_view 0.14.0 [flutter]
- pin_code_fields 7.4.0 [flutter]
- rxdart 0.27.5
- shared_preferences 2.0.15 [flutter shared_preferences_android shared_preferences_ios shared_preferences_linux shared_preferences_macos shared_preferences_platform_interface shared_preferences_web shared_preferences_windows]
- sizer 2.0.15 [universal_io flutter]
- translator 0.1.7 [http]
- uuid 3.0.6 [crypto]
- wechat_assets_picker 7.3.4 [flutter extended_image photo_manager provider video_player]

dev dependencies:
- flutter_lints 1.0.4 [lints]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph]

transitive dependencies:
- archive 3.3.1 [crypto path]
- args 2.3.1
- assets_audio_player_web 3.0.5 [flutter flutter_web_plugins]
- async 2.8.2 [collection meta]
- audio_session 0.1.10 [flutter flutter_web_plugins rxdart meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- cached_network_image_platform_interface 1.0.0 [flutter flutter_cache_manager]
- cached_network_image_web 1.0.1 [flutter flutter_cache_manager cached_network_image_platform_interface]
- characters 1.2.0
- charcode 1.3.1
- chewie 1.3.4 [cupertino_icons flutter provider video_player wakelock]
- clock 1.1.0
- cloud_firestore_platform_interface 5.7.0 [collection firebase_core flutter meta plugin_platform_interface]
- cloud_firestore_web 2.8.3 [cloud_firestore_platform_interface collection firebase_core firebase_core_web flutter flutter_web_plugins js]
- cloud_functions_platform_interface 5.1.12 [firebase_core flutter meta plugin_platform_interface]
- cloud_functions_web 4.3.1 [cloud_functions_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- collection 1.16.0
- cross_file 0.3.3+1 [js meta]
- crypto 3.0.2 [typed_data]
- csslib 0.17.2 [source_span]
- dbus 0.7.4 [args ffi meta xml]
- diffutil_dart 3.0.0
- equatable 2.0.3 [collection meta]
- extended_image 6.2.1 [extended_image_library flutter meta]
- extended_image_library 3.3.0 [crypto flutter http_client_helper path path_provider]
- fake_async 1.3.0 [clock collection]
- ffi 1.2.1
- file 6.1.2 [meta path]
- firebase_auth_platform_interface 6.5.2 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 4.2.2 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta]
- firebase_core 1.20.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_core_platform_interface 4.5.0 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 1.7.1 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_database_platform_interface 0.2.2 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_database_web 0.2.1+2 [firebase_core firebase_core_web firebase_database_platform_interface flutter flutter_web_plugins js]
- firebase_messaging_platform_interface 3.5.4 [firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 2.4.4 [firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta]
- firebase_storage_platform_interface 4.1.12 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_storage_web 3.3.2 [async firebase_core firebase_core_web firebase_storage_platform_interface flutter flutter_web_plugins http js meta]
- flutter_blurhash 0.7.0 [flutter]
- flutter_cache_manager 3.3.0 [clock collection file flutter http path path_provider pedantic rxdart sqflite uuid]
- flutter_chat_types 3.4.5 [equatable json_annotation meta]
- flutter_facebook_auth_platform_interface 3.2.0 [flutter plugin_platform_interface]
- flutter_facebook_auth_web 3.2.0 [flutter flutter_web_plugins js flutter_facebook_auth_platform_interface]
- flutter_link_previewer 3.0.1 [flutter flutter_chat_types flutter_linkify html http linkify meta url_launcher]
- flutter_linkify 5.0.2 [flutter linkify]
- flutter_local_notifications_linux 0.5.1 [flutter flutter_local_notifications_platform_interface dbus path xdg_directories]
- flutter_local_notifications_platform_interface 5.0.0 [flutter plugin_platform_interface]
- flutter_parsed_text 2.2.1 [flutter]
- flutter_plugin_android_lifecycle 2.0.7 [flutter]
- flutter_spinkit 5.1.0 [flutter]
- flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math]
- flutter_widget_from_html_core 0.8.5+3 [csslib flutter fwfh_text_style html]
- fwfh_cached_network_image 0.7.0+2 [cached_network_image flutter flutter_cache_manager flutter_widget_from_html_core]
- fwfh_chewie 0.7.0+1 [chewie flutter flutter_widget_from_html_core video_player]
- fwfh_just_audio 0.6.2+2 [flutter flutter_widget_from_html_core just_audio]
- fwfh_selectable_text 0.8.3+1 [flutter flutter_widget_from_html_core]
- fwfh_svg 0.7.2 [flutter flutter_svg flutter_widget_from_html_core]
- fwfh_text_style 2.22.08 [flutter]
- fwfh_url_launcher 0.6.1+3 [flutter flutter_widget_from_html_core url_launcher]
- fwfh_webview 0.6.2+2 [flutter flutter_widget_from_html_core webview_flutter]
- geocoding_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- geolocator_android 3.2.1 [flutter geolocator_platform_interface]
- geolocator_apple 2.2.1 [flutter geolocator_platform_interface]
- geolocator_platform_interface 4.0.6 [flutter plugin_platform_interface vector_math meta]
- geolocator_web 2.1.6 [flutter flutter_web_plugins geolocator_platform_interface]
- geolocator_windows 0.1.1 [flutter geolocator_platform_interface]
- google_maps_flutter_platform_interface 2.2.1 [collection flutter plugin_platform_interface stream_transform]
- google_sign_in_android 6.0.1 [flutter google_sign_in_platform_interface]
- google_sign_in_ios 5.4.0 [flutter google_sign_in_platform_interface]
- google_sign_in_platform_interface 2.2.0 [flutter quiver]
- google_sign_in_web 0.10.2 [flutter flutter_web_plugins google_sign_in_platform_interface js]
- html 0.15.0 [csslib source_span]
- http 0.13.5 [async http_parser meta path]
- http_client_helper 2.0.3 [http]
- http_parser 4.0.1 [collection source_span string_scanner typed_data]
- image 3.2.0 [archive meta xml]
- image_picker_android 0.8.5+2 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- image_picker_for_web 2.1.8 [flutter flutter_web_plugins image_picker_platform_interface]
- image_picker_ios 0.8.5+6 [flutter image_picker_platform_interface]
- image_picker_platform_interface 2.6.1 [cross_file flutter http plugin_platform_interface]
- js 0.6.4
- json_annotation 4.6.0 [meta]
- just_audio 0.9.28 [just_audio_platform_interface just_audio_web audio_session rxdart path path_provider async uuid crypto meta flutter]
- just_audio_platform_interface 4.2.0 [flutter plugin_platform_interface]
- just_audio_web 0.4.7 [just_audio_platform_interface flutter flutter_web_plugins]
- linkify 4.1.0
- lint 1.10.0
- lints 1.0.1
- matcher 0.12.11 [stack_trace]
- material_color_utilities 0.1.4
- meta 1.7.0
- nested 1.0.0 [flutter]
- octo_image 1.0.2 [flutter flutter_blurhash]
- path 1.8.1
- path_drawing 1.0.1 [vector_math meta path_parsing flutter]
- path_parsing 1.0.1 [vector_math meta]
- path_provider_android 2.0.18 [flutter path_provider_platform_interface]
- path_provider_ios 2.0.11 [flutter path_provider_platform_interface]
- path_provider_linux 2.1.7 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_macos 2.0.6 [flutter path_provider_platform_interface]
- path_provider_platform_interface 2.0.4 [flutter platform plugin_platform_interface]
- path_provider_windows 2.0.7 [ffi flutter path path_provider_platform_interface win32]
- pedantic 1.11.1
- permission_handler_android 9.0.2+1 [flutter permission_handler_platform_interface]
- permission_handler_apple 9.0.4 [flutter permission_handler_platform_interface]
- permission_handler_platform_interface 3.7.0 [flutter meta plugin_platform_interface]
- permission_handler_windows 0.1.0 [flutter permission_handler_platform_interface]
- petitparser 5.0.0 [meta]
- photo_manager 2.1.4 [flutter]
- platform 3.1.0
- plugin_platform_interface 2.1.2 [meta]
- process 4.2.4 [file path platform]
- provider 6.0.3 [collection flutter nested]
- quiver 3.1.0 [matcher]
- shared_preferences_android 2.0.12 [flutter shared_preferences_platform_interface]
- shared_preferences_ios 2.1.1 [flutter shared_preferences_platform_interface]
- shared_preferences_linux 2.1.1 [file flutter path path_provider_linux path_provider_platform_interface shared_preferences_platform_interface]
- shared_preferences_macos 2.0.4 [flutter shared_preferences_platform_interface]
- shared_preferences_platform_interface 2.0.0 [flutter]
- shared_preferences_web 2.0.4 [flutter flutter_web_plugins shared_preferences_platform_interface]
- shared_preferences_windows 2.1.1 [file flutter path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface]
- sky_engine 0.0.99
- source_span 1.8.2 [collection path term_glyph]
- sqflite 2.0.3+1 [flutter sqflite_common path]
- sqflite_common 2.2.1+1 [synchronized path meta]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- stream_transform 2.0.0
- string_scanner 1.1.0 [charcode source_span]
- synchronized 3.0.0+2
- term_glyph 1.2.0
- test_api 0.4.9 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- timezone 0.8.0 [path]
- typed_data 1.3.1 [collection]
- universal_io 2.0.4 [collection crypto meta typed_data]
- url_launcher 6.1.5 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
- url_launcher_android 6.0.17 [flutter url_launcher_platform_interface]
- url_launcher_ios 6.0.17 [flutter url_launcher_platform_interface]
- url_launcher_linux 3.0.1 [flutter url_launcher_platform_interface]
- url_launcher_macos 3.0.1 [flutter url_launcher_platform_interface]
- url_launcher_platform_interface 2.1.0 [flutter plugin_platform_interface]
- url_launcher_web 2.0.13 [flutter flutter_web_plugins url_launcher_platform_interface]
- url_launcher_windows 3.0.1 [flutter url_launcher_platform_interface]
- vector_math 2.1.2
- video_player 2.4.6 [flutter html video_player_android video_player_avfoundation video_player_platform_interface video_player_web]
- video_player_android 2.3.8 [flutter video_player_platform_interface]
- video_player_avfoundation 2.3.5 [flutter video_player_platform_interface]
- video_player_platform_interface 5.1.4 [flutter plugin_platform_interface]
- video_player_web 2.0.12 [flutter flutter_web_plugins video_player_platform_interface]
- visibility_detector 0.3.3 [flutter]
- wakelock 0.6.2 [flutter meta wakelock_macos wakelock_platform_interface wakelock_web wakelock_windows]
- wakelock_macos 0.4.0 [flutter flutter_web_plugins wakelock_platform_interface]
- wakelock_platform_interface 0.3.0 [flutter meta]
- wakelock_web 0.4.0 [flutter flutter_web_plugins js wakelock_platform_interface]
- wakelock_windows 0.2.0 [flutter wakelock_platform_interface win32]
- webview_flutter 3.0.4 [flutter webview_flutter_android webview_flutter_platform_interface webview_flutter_wkwebview]
- webview_flutter_android 2.9.3 [flutter webview_flutter_platform_interface]
- webview_flutter_platform_interface 1.9.1 [flutter meta plugin_platform_interface]
- webview_flutter_wkwebview 2.9.3 [flutter path webview_flutter_platform_interface]
- win32 2.6.1 [ffi]
- xdg_directories 0.2.0+1 [meta path process]
- xml 6.1.0 [collection meta petitparser]
- yaml 3.1.1 [collection source_span string_scanner]

@Matsuo32
This probably is an issue with background_locator plugin. See this similar issue that was raised earlier: https://github.com/firebase/flutterfire/issues/5976
Same issue was raised in dedicated repo: https://github.com/rekabhq/background_locator/issues/256. See also https://github.com/rekabhq/background_locator/issues/167#issuecomment-897691509
You should report this in dedicated repo: https://github.com/Yukams/background_locator_fixed/issues
Closing from here. If you disagree, write in comments and I'll reopen it.


Json reply?

The submission port currently replies with 'text/plain' and "Offer received" but when you're calling it in a json-ey way, you're not getting json back.
What was the thinking behind that and would it make more sense to respond {'success': True}?

Of course, how did i miss this. Fixed in #7


Fix empty volume ownership.

Cherrypick https://github.com/containerd/cri/pull/811.
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

/test pull-cri-containerd-node-e2e


Unexpected token < in JSON at position 2

Describe the bug
During the execution of amplify-init the console returns an error message:
Note: It is recommended to run this command from the root of your app directory
? Do you want to use an existing environment? Yes
? Choose the environment you would like to use: <MY ENV NAME>
Using default provider  awscloudformation

For more information on AWS Profiles, see:
https://docs.aws.amazon.com/cli/latest/userguide/cli-multiple-profiles.html

? Do you want to use an AWS profile? Yes
? Please choose the profile you want to use <MY PROFILE NAME>
✖ There was an error initializing your environment.
init failed
SyntaxError: Unexpected token < in JSON at position 2
    at JSON.parse (<anonymous>)
    at readJsonFile (/usr/lib/node_modules/@aws-amplify/cli/src/extensions/amplify-helpers/read-json-file.js:11:15)
    at populateAmplifyMeta (/usr/lib/node_modules/@aws-amplify/cli/src/lib/initialize-env.js:93:31)
    at initializeEnv (/usr/lib/node_modules/@aws-amplify/cli/src/lib/initialize-env.js:28:7)
    at run (/usr/lib/node_modules/@aws-amplify/cli/src/lib/init-steps/s9-onSuccess.js:52:9)
    at <anonymous>
    at process._tickDomainCallback (internal/process/next_tick.js:229:7)

To Reproduce
Steps to reproduce the behavior:

Clone https://github.com/dakshjotwani/Finder.git
cd finder_app
git checkout UI and run amplify-init

Expected behavior
Successful initialization of the project
Desktop (please complete the following information):

OS: Ubuntu 18.04
Amplify Version: 1.7.1
npm Version: 6.9.0

@vishwakalyanaraman The backend-config.json seems to be corrupted in the amplify/ directory. I don't seem to have access to https://github.com/dakshjotwani/Finder.git, so I can't take a look at the structure of that file.

Hi there. Could I have your git ID so I can add you as a contibutor so you
can take a look at it? Thanks.
On Jun 14, 2019 at 11:46 AM, <Kaustav Ghosh<EMAIL_ADDRESS>wrote:
@vishwakalyanaraman https://github.com/vishwakalyanaraman The
backend-config.json seems to be corrupted in the amplify/ directory. I
don't seem to have access to https://github.com/dakshjotwani/Finder.git, so
I can't take a look at the structure of that file.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aws-amplify/amplify-cli/issues/1662?email_source=notifications&email_token=AFMEX6HLZ2R7F2LLJFQBVBLP2MZTRA5CNFSM4HYEY25KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXV2ONI#issuecomment-501983029,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFMEX6FACPVPOYKLKKHAVADP2MZTRANCNFSM4HYEY25A
.

kaustavghosh06

I've finally found the issue. There was an unmentioned merge conflict in
backend-config.json. The '<' character was a part of the HEAD and that was
causing the issue. Thanks for the help!
On Fri, Jun 14, 2019 at 11:50 AM Kaustav Ghosh<EMAIL_ADDRESS>wrote:

kaustavghosh06
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aws-amplify/amplify-cli/issues/1662?email_source=notifications&email_token=AFMEX6HUUTHXHDM6RDLUFTTP2M2EXA5CNFSM4HYEY25KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXV2WMY#issuecomment-501984051,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFMEX6EDNHMHD6P7IOOZ5PLP2M2EXANCNFSM4HYEY25A
.


Related work: console.createTask

This is a new API added to support async stack stitching in DevTools: https://developer.chrome.com/blog/devtools-modern-web-debugging/#linked-stack-traces. API usage example from that page:
function makeScheduler() {
  const tasks = [];

  return {
    schedule(f) {
      const task = console.createTask(f.name);
      tasks.push({ task, f });
    },

    work() {
      while (tasks.length) {
        const { task, f } = tasks.shift();
        task.run(f); // instead of f();
      }
    },
  };
}

See https://github.com/legendecas/proposal-async-context/issues/9.

Ah, sorry! Missed that when searching. I think my suggestion here was to mention console.createTask in the "Prior Arts" section since the proposal currently doesn't mention this API.

Yah, that sounds good. I'm actually had a slide item for this in the next presentation.


Adopt minitrace to add internal logs

https://github.com/tikv/minitrace-rust

Also, ping @drmingdrmer, minitrace seems much faster than tokio-tracing. Maybe you will be interested in it too.


Update gradle example to support x86 in debug mode.

Changed the Flutter Gradle plugin a bit to better fit in with the Android build.
x86 shared libraries are added to debug builds, so they can now run on the emulator. Profile and release builds still only support ARM.
Invoking 'gradlew build' directly will now build all variants, like a normal Android build.
Fixes #6136
Fixes #6864
Fixes #7539

LGTM


Perlmutter support

Perlmutter support. Resolves part of #223.

I had to use --no-verify on commits because I'm running into AttributeError: 'EntryPoints' object has no attribute 'get'. This error was seen in https://github.com/E3SM-Project/zppy/issues/318#issuecomment-1269041710, which suggests we need  something like https://github.com/E3SM-Project/zppy/pull/321. That is, #224 was not a sufficient update.

I had to use --no-verify on commits

Resolved with #228.

On Cori, all 64 tests pass. On Perlmutter, all pass except the Globus test, which gets skipped. Keeping #223 open to eventually fully replace Cori with Perlmutter.


iOS crash: io.flutter.1.raster SIGABRT ABORT 0x00000001b400184c MTLGetWarningMode

Got this crash from a user in crashlytics. Only big thing that has changed recently is I baked SkSL into this build using the recent change which enables metal support for SkSL.
iPhone 7, 14.4.2
Steps to Reproduce

User launched the app
The app immediately crashed unexpectedly without any warning

Expected results:
App should not crash.
Actual results:
MTLGetWarningMode SIGABRT
Crashed: io.flutter.1.raster
0  libsystem_kernel.dylib         0x1b400184c __pthread_kill + 8
1  libsystem_pthread.dylib        0x1d08e89e8 pthread_kill + 212
2  libsystem_c.dylib              0x190dc08f4 abort + 100
3  Metal                          0x19db50b84 MTLGetWarningMode + 214
4  IOGPU                          0x1c2c32df8 -[IOGPUMetalCommandBuffer pushDebugGroup:] + 238
5  Metal                          0x19db414dc -[_MTLCommandEncoder initWithCommandBuffer:] + 880
6  IOGPU                          0x1c2c34930 -[IOGPUMetalCommandEncoder initWithCommandBuffer:] + 52
7  AGXMetalA10                    0x1d18b4a08 (Missing)
8  AGXMetalA10                    0x1d19131dc (Missing)
9  Flutter                        0x1039b05b4 (Missing)
10 Flutter                        0x1039b3554 (Missing)
11 Flutter                        0x1038c6648 (Missing)
12 Flutter                        0x1038da32c (Missing)
13 Flutter                        0x1038dac88 (Missing)
14 Flutter                        0x1038d32fc (Missing)
15 Flutter                        0x1038f1800 (Missing)
16 Flutter                        0x1038d2c50 (Missing)
17 Flutter                        0x1038ac698 (Missing)
18 Flutter                        0x1038dc81c (Missing)
19 Flutter                        0x1038b2828 (Missing)
20 Flutter                        0x1038e9254 (Missing)
21 Flutter                        0x1038ec904 (Missing)
22 Flutter                        0x1038ec458 (Missing)
23 Flutter                        0x1039716c4 (Missing)
24 Flutter                        0x103972480 (Missing)
25 Flutter                        0x10396de14 (Missing)
26 Flutter                        0x10378f4b8 (Missing)
27 Flutter                        0x10382d47c (Missing)
28 Flutter                        0x103a6ca88 (Missing)
29 Flutter                        0x103a6e090 (Missing)
30 Flutter                        0x103a6de18 (Missing)
31 Flutter                        0x103a6dcc0 (Missing)
32 Flutter                        0x103a69c5c (Missing)
33 Flutter                        0x103a6a6b4 (Missing)
34 Flutter                        0x103a69704 (Missing)
35 Flutter                        0x103a6d3a8 (Missing)
36 Flutter                        0x103a69704 (Missing)
37 Flutter                        0x103a68d10 (Missing)
38 Flutter                        0x103a69704 (Missing)
39 Flutter                        0x103a6d3a8 (Missing)
40 Flutter                        0x103a69704 (Missing)
41 Flutter                        0x103a68d10 (Missing)
42 Flutter                        0x103a69704 (Missing)
43 Flutter                        0x103a6d3a8 (Missing)
44 Flutter                        0x103a69704 (Missing)
45 Flutter                        0x103a6ba28 (Missing)
46 Flutter                        0x103a69704 (Missing)
47 Flutter                        0x103a6d3a8 (Missing)
48 Flutter                        0x103a69704 (Missing)
49 Flutter                        0x103a6d3a8 (Missing)
50 Flutter                        0x103a69704 (Missing)
51 Flutter                        0x103a6d3a8 (Missing)
52 Flutter                        0x103a69704 (Missing)
53 Flutter                        0x103a6d3a8 (Missing)
54 Flutter                        0x103a69704 (Missing)
55 Flutter                        0x103a6d3a8 (Missing)
56 Flutter                        0x103a69704 (Missing)
57 Flutter                        0x103a6949c (Missing)
58 Flutter                        0x103a6778c (Missing)
59 Flutter                        0x103a75bdc (Missing)
60 Flutter                        0x103a76894 (Missing)
61 Flutter                        0x103a75fc0 (Missing)
62 Flutter                        0x103a7da08 (Missing)
63 Flutter                        0x103a17964 (Missing)
64 Flutter                        0x103a1a5ec (Missing)
65 CoreFoundation                 0x1880463e0 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 28
66 CoreFoundation                 0x188045fe4 __CFRunLoopDoTimer + 1004
67 CoreFoundation                 0x1880454c4 __CFRunLoopDoTimers + 324
68 CoreFoundation                 0x18803f850 __CFRunLoopRun + 1912
69 CoreFoundation                 0x18803eba0 CFRunLoopRunSpecific + 572
70 Flutter                        0x103a1a4c8 (Missing)
71 Flutter                        0x103a19dd8 (Missing)
72 libsystem_pthread.dylib        0x1d08e7c9c _pthread_start + 288
73 libsystem_pthread.dylib        0x1d08ec880 thread_start + 8

io.flutter.1.ui
0  Flutter                        0x103c7a990 (Missing)
1  Flutter                        0x103c79a5c (Missing)
2  Flutter                        0x103c9f6f8 (Missing)
3  Flutter                        0x103c584ec (Missing)
4  Flutter                        0x103d39770 (Missing)
5  Flutter                        0x103b55644 (Missing)
6  Flutter                        0x103a17964 (Missing)
7  Flutter                        0x103a1a5ec (Missing)
8  CoreFoundation                 0x1880463e0 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 28
9  CoreFoundation                 0x188045fe4 __CFRunLoopDoTimer + 1004
10 CoreFoundation                 0x1880454c4 __CFRunLoopDoTimers + 324
11 CoreFoundation                 0x18803f850 __CFRunLoopRun + 1912
12 CoreFoundation                 0x18803eba0 CFRunLoopRunSpecific + 572
13 Flutter                        0x103a1a4c8 (Missing)
14 Flutter                        0x103a19dd8 (Missing)
15 libsystem_pthread.dylib        0x1d08e7c9c _pthread_start + 288
16 libsystem_pthread.dylib        0x1d08ec880 thread_start + 8

io.flutter.1.io
0  libsystem_kernel.dylib         0x1b3fde644 mach_msg_trap + 8
1  libsystem_kernel.dylib         0x1b3fdda48 mach_msg + 72
2  CoreFoundation                 0x1880450fc __CFRunLoopServiceMachPort + 376
3  CoreFoundation                 0x18803f570 __CFRunLoopRun + 1176
4  CoreFoundation                 0x18803eba0 CFRunLoopRunSpecific + 572
5  Flutter                        0x103a1a4c8 (Missing)
6  Flutter                        0x103a19dd8 (Missing)
7  libsystem_pthread.dylib        0x1d08e7c9c _pthread_start + 288
8  libsystem_pthread.dylib        0x1d08ec880 thread_start + 8

I can provide other threads if they will be helpful.

Logs

fvm: running version "71cb40f46a"

[✓] Flutter (Channel master, 2.2.0-11.0.pre.180, on macOS 11.2 20D64 darwin-x64, locale en-US)
    • Flutter version 2.2.0-11.0.pre.180 at /Users/andrewcoutts/fvm/versions/71cb40f46a
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 71cb40f46a (9 days ago), 2021-04-20 14:19:02 -0400
    • Engine revision 79c5ebe835
    • Dart version 2.14.0 (build 2.14.0-18.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/andrewcoutts/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/andrewcoutts/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.1

[✓] VS Code (version 1.56.0-insider)
    • VS Code at /Applications/Visual Studio Code - Insiders.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (4 available)
    • xff0c-12p (mobile)         • 00008101-00196C340C29003A            • ios            • iOS 14.4.2
    • iPhone 8 (mobile)          • F759EC42-6F1B-412A-8CA8-0A8B9713D0CF • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-2 (simulator)
    • iPhone 12 Pro Max (mobile) • EAA8EAB2-3059-4736-8D43-5EDE13DED1F9 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-2 (simulator)
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 90.0.4430.93

• No issues found!

@flutter-symbolizer-bot #81467 (comment) flutter#v2.2.0 force ios release arm64

@mraleph

@flutter-symbolizer-bot #81467 (comment) flutter#v2.2.0 force ios release arm64

@acoutts
Seems very similar to / duplicate of https://github.com/flutter/flutter/issues/79313

Yup duplicate of #79313


Codacy release

[Current coverage][cc-pull] is 79.78%

Merging [#49][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master        #49   diff @@
==========================================
  Files            16         16
  Lines           277        277
  Methods           0          0
  Messages          0          0
  Branches         23         23
==========================================
  Hits            221        221
  Misses           47         47
  Partials          9          9

Powered by Codecov. Last updated by [cda19e9...296bdf4][cc-compare]
[cc-base-branch]: https://codecov.io/gh/modernmaster/katas/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/modernmaster/katas/compare/cda19e9728993f367ac7d1cbf5a15aa5bd37f012...296bdf42e588c70bed57e37b1c9edbc5c10fe822
[cc-pull]: https://codecov.io/gh/modernmaster/katas/pull/49?src=pr


auth broken when revisiting the site after a while

Might be that the refresh token functionality is broken

Not able to repro


Sub lists and paragraphs within lists don't show up

I'm not sure if this is necessary functionality, but I tested markdown for sub lists:
``1. First ordered list item
2. Another item
⋅⋅* Unordered sub-list.

Actual numbers don't matter, just that it's a number
⋅⋅1. Ordered sub-list
And another item. ``

It appears like this.

And I tried indented paragraph text:
``
4. And another item.
⋅⋅⋅You can have properly indented paragraphs within list items. Notice the blank line above  ``
It showed up like this:

Note: This is viewing content in Preview mode.

the syntax for the parser is to use space (4 characters).
this is the corresponding version of our rendering:
1. First ordered list item
2. Another item
    * Unordered sub-list.
1. Actual numbers don't matter, just that it's a number
    1. Ordered sub-list
4. And another item.

    You can have properly indented paragraphs within list items. Notice the blank line above, and the leading spaces (at least one, but we'll use three here to also align the raw Markdown).

    To have a line break without a paragraph, you will need to use two trailing spaces.⋅⋅
    Note that this line is separate, but within the same paragraph.⋅⋅
    (This is contrary to the typical GFM line break behaviour, where trailing spaces are not required.)

* Unordered list can use asterisks
- Or minuses
+ Or pluses


TICKET WIP: Revise Resource Management Page to Updated Design

Overview
The resource management page, accessible in the admin portal, needs to be revised to make the page more intuitive to use. The new design reformats the page to include a Preview section to display how the resources would look in the student portal, along with a section on the right hand side which allows the admin to edit resources that currently exist. Below is a short video to demonstrate some of the new features that should be included in this revision. Please note that this video does not include all features. All features required to complete this ticket will be listed below.
https://github.com/user-attachments/assets/fba0027d-d763-4599-b763-b312c277c1b0
Requirements
The updated resource management page should be able to do the following:
Adding a Category

You can add a new resource using the plus icon in the top right corner of the "Resources Preview" container. This will open a modal that looks like this with empty text inputs using the form inputs in /Components/inputs

Modifying a Category

When a card is selected, a yellow border should be applied to the outside of the card and the resource should appear in the right hand container in "edit mode", aka with all the links as inputs that are directly modifiable. An example of this can be seen here).

There are 4 relevant icons while in edit mode of a specific research. All icons that do not have words accompanying their function should have a tooltip that explains what they do. For example, the trash icon should have a tooltip that says "Delete Resource".

Trash icon to delete resource- this is used to delete the selected resource. A confirm delete resource modal should appear before deleting.
Pencil square icon (edit) - this is used to edit the title of the resource. The modal should only contain 1 input field. An example can be seen here.
Add link icon -
Trash icon to delete link (on the right hand side)- deletes that specific link. A confirm delete link modal should appear before deleting.

When you modify a card, the modification should immediately appear in the right hand side, but remember these changes are only stored locally for now. The changes are only published to the backend when the user clicks "Publish Changes".

Drag and drop the left hand resource cards to change the order of the cards. This would highlight all the cards impacted by the order change. For example, if there are 4 resources listed on the left hand side and the admin user moved the 2nd card to the 4th position, cards 2-4 would all be highlighted in yellow.

Task List

[ ] Refactor ResourceCard, WikipediaCard, and KolibriCard from  ResourcesSideBar into individual components.
[ ] Use the new ResourceCard in the ResourcesManagement screen to provide a Resources Preview for Administrators.
[ ] Implement drag-and-drop functionality to rearrange resources in the Preview.
[ ] Highlight resources that have been reordered with a yellow background.
[ ] Change the Save button to a "Publish Changes" button with a cloud icon. Clicking this will save changes and reset the highlighted state of the resources in the preview.
[ ] In the "Add Resource" modal, require the user to input a new resource title, a single link name, and a link URL. Upon submission, the resource appears in the Resources Preview and is highlighted yellow.
[ ] Implement a new UI with two panes:

[ ] The left pane is the Resources Preview component
[ ] The right pane is the Modify Resource component

[ ] Update the icons to match those provided by the design. Any icons without text should have tooltips (e.g., Trash icon should read "Delete Resource")

The PR for this has been opened against @PThorpe92's main branch.

Closed as it has been merged into main.