fix: drilldown from an undeployed application in tree will issue a kubectl get with 404

Fixed this by passing the dry-run results to kubectl get as execOptions.data.diff
When dry-run detects pending changes, clicking a changed leaf node will show the diff results in the DiffEditor
Fixes #6331

Description of what you did:

My PR is a:

[ ] 💥 Breaking change
[x] 🐛 Bug fix
[x] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[x] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[x] All npm dependencies are pinned.

great! let's keep in mind that there seems to be a prior bug in the Rerun support in ScrollableTerminal: it does not seem to be passing through the original execOptions.


sipcreator.py -rename_uuid failed when more than one objects in the PSM/objects

The failure happens when there are more than one objects with the same format in one PSM and sipcreator.py -rename_uuid wants to rename all to $uuid.$fmt.
The terminal output shows below:
Checking total size of input folder
Checking if enough space in destination folder
[]
Generating source manifest
Counting the amount of files to be processed.
Generating MD5 for F:\Margo\PSM\IFI_Margo_Box15\MV9592\MV9592_1.mkv - 1 of 1
copying file with python/shutil
Generating destination manifest
Counting the amount of files to be processed.
Generating MD5 for F:\Margo\SIP\Batch_15\oe20085\a5482b1c-3460-4ead-9d5b-dfd92c2e0988\objects\MV9592_1.mkv - 1 of 1
Your files have reached their destination and the checksums match
ifiscripts installed from pypi - Version: 2<IP_ADDRESS>
Checking total size of input folder
Checking if enough space in destination folder
[]
Generating source manifest
Counting the amount of files to be processed.
Generating MD5 for F:\Margo\PSM\IFI_Margo_Box15\MV9592\MV9592_2.mkv - 1 of 1
copying file with python/shutil
Generating destination manifest
Counting the amount of files to be processed.
Generating MD5 for F:\Margo\SIP\Batch_15\oe20085\a5482b1c-3460-4ead-9d5b-dfd92c2e0988\objects\MV9592_2.mkv - 1 of 1
Your files have reached their destination and the checksums match
Traceback (most recent call last):
  File "C:\Users\DIGITALGARAGE\AppData\Local\Programs\Python\Python310\Scripts\batchsipcreator.py", line 143, in <module>
    main(sys.argv[1:])
  File "C:\Users\DIGITALGARAGE\AppData\Local\Programs\Python\Python310\Scripts\batchsipcreator.py", line 137, in main
    sipcreator_log, _ = sipcreator.main(sipcreator_cmd)
  File "C:\Users\DIGITALGARAGE\AppData\Local\Programs\Python\Python310\Scripts\sipcreator.py", line 516, in main
    log_names = move_files(inputs, sip_path, args, user)
  File "C:\Users\DIGITALGARAGE\AppData\Local\Programs\Python\Python310\Scripts\sipcreator.py", line 126, in move_files
    os.rename(os.path.join(objects_dir, os.path.basename(item)), new_path)
FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'F:\\Margo\\SIP\\Batch_15\\oe20085\\a5482b1c-3460-4ead-9d5b-dfd92c2e0988\\objects\\MV9592_2.mkv' -> 'F:\\Margo\\SIP\\Batch_15\\oe20085\\a5482b1c-3460-4ead-9d5b-dfd92c2e0988\\objects\\a5482b1c-3460-4ead-9d5b-dfd92c2e0988.mkv'

A solution is needed to ensure that the only UUID is used for renaming and able to apply to multiple files.

Out of curiosity, why were there two files to begin with?

The first time I met this is from multiple drone footages are included in single information package in a finished project. The second time is from an in-progress project. The objects from one information package are split from a tape by timecode. So I think that different content in one physical media will make multiple files in one information package.

The drone example sounds exactly like the loopline video cards. In this example, as it was born digital content received from a donor, -rename_uuid wasn’t used, in the same way you won’t rename the files in a dcp.
as this is mkv, it must be a non DV tape migration, so I can’t see a reason why the capture would be split in two? There’s loads of tapes that might have ten episodes with different time codes per episodes but you will get one captured file. Perhaps if there was a super long timecode break, weird things might happen but the capture should still continue with the single file. Is there any chance that this is a capture that might fail QC, or is it an edge case that must be accepted, and as a result, this script update will be required?

I guess yes. I'm not in the project, while from what I've heard, this is what we received after conversation.

Anyhow I’m sure that turning rename UUID into a loop and getting team consensus on what the suffix looks like is all fine. The actual split video file in this instance sounds like something went wrong during capture though, but fire ahead with whatever you’re planning!

The issue has been solved in #78 by adding an index to the file name for multiple object files '$uuid_$index.$ext'.


Update ONNX importer to use nGraph ops from new opset header

Proof of concept

I think in the end we should be able to use both approaches, combined.
Perhaps the best way to write code it is to explicitly state where each operation is coming from.
Either: ngraph::opset0::Add, ngraph::opset1::Add or onnx_importer::default_opset::Add.
In a file which uses all defaults we could include using namespace ngraph::default_opset.
@jbobba @diyessi What do you think?

@postrational
I think in the end we should be able to use both approaches, combined.
Perhaps the best way to write code it is to explicitly state where each operation is coming from.
Either: ngraph::opset0::Add, ngraph::opset1::Add or onnx_importer::default_opset::Add.
In a file which uses all defaults we could include using namespace onnx_importer::default_opset.
@jbobba @diyessi What do you think?

In my opinion default_opset can cause some shady problems when it will change from opset1 to opset2.
Some of the operations would have the same signature but different default parameters etc.

I think in the end we should be able to use both approaches, combined.
Perhaps the best way to write code it is to explicitly state where each operation is coming from.
Either: ngraph::opset0::Add, ngraph::opset1::Add or onnx_importer::default_opset::Add.
In a file which uses all defaults we could include using namespace ngraph::default_opset.

So what about creating onnx_importer::default_opset alias for ngraph::opset1 namespace. We will be able to change it with opset upgrade on ngraph::opset2,  ngraph::opset3 etc. in the default_opset.hpp and then write explicitly older opset namespace only there, where ops version in the new opset will be incompatible.
In default_opset.hpp file, something like this:
#include "ngraph/opsets/opset1.hpp"
namespace ngraph::default_opset = ngraph::opset1;

Instead of this:
#include "ngraph/opsets/opset1.hpp"
using namespace ngraph::opset1;


Missing translation in sidebar?

The configuration looks the same as Lochristi, but in Niel it's called "Regional/Local News" instead of "Regionaal/Lokaal Nieuws".
Are there other apps which have the same problem?

be-niel is the only one, the translations where not added to the build.yaml and android crashed on it but ios didn't apperently.
I already fixed this 7 days ago, so just rebuild and everything will be ok


Bitbucket Private Repo

Hello,
I want to setup Hygieia UI to contact bitbucket, but our repos are private, I can see userID and Password in the java files,
However I don't know how to pass it using ENV variables in Docker or properties file

I don't see a way to do it in the UI. Here is how you can do it manually:

Create/generate a 24 character key (in this example 'abcdefghijklmnopqrstuvwx')
Obtain the base64 string of that key

echo -n abcdefghijklmnopqrstuvwx | base64
YWJjZGVmZ2hpamtsbW5vcHFyc3R1dnd4

Put that value in your properties file (git.key=YWJjZGVmZ2hpamtsbW5vcHFyc3R1dnd4). There is no environment variable for it so you will have to override the docker-compose command and point to a custom volume with your settings file
Obtain the hex string of that key

echo -n abcdefghijklmnopqrstuvwx | hexdump -e '16/1 "%02x"'
6162636465666768696a6b6c6d6e6f707172737475767778

Generate an encrypted password string using tripple DES. The  options your jvm uses may vary. Mine defaulted to using DESede/ECB/PKCS5Padding.

echo -n password | openssl enc -des-ede3 -K<PHONE_NUMBER>6768696a6b6c6d6e6f707172737475767778 -base64
61orEO2iB8UVQI1v4VgFow==

Find your database GitRepo record

db.getCollection('collector_items').find({'_class': 'com.capitalone.dashboard.model.GitRepo'})

Add the following to the options json:

userID: "myusername"
password: "61orEO2iB8UVQI1v4VgFow=="

Functionality merged in https://github.com/capitalone/Hygieia/pull/835
Refer to the "Encryption for private repos" section in the UI module readme.


Add  Techstack with logos in readme file

Describe the bug
I want to add used techstack with logos in readme file and COC should be in between the readme file. But it's at the bottom everyone must read COC. If it's down some of them will not see.

@srisatya1197 go for it


Documentation pages missing or partly hidden

The vue-clerk documentation pages act a bit weird:

If I start on the home page then click on What is Vue Clerk?, both pages display nicely.

If I then reload What is Vue Clerk?, two things happen: (1) the main content for this page disappears and (2) the left 25% of the page is hidden behind the navigation component. See screenshot 1.

When I next use the navigation mention to navigation go to any other documentation page, the main content for each page does appear correctly, but the left 25% of each page is still hidden behind the navigation component. See screenshot 2.

If I then use the navigation menu to go back to the What is Vue Clerk? page, the main content reappears, but the 25% issue remains.

I see exactly the same issues using Firefox, Chrome, or Safari. I'm working on a MacBook Pro running Venutra 13.6.7.
Screenshot 1

Screenshot 2

Thanks for reporting! I also experience this issue and thought it was a caching issue or something on my end. I'll check this asap!

Fixed using https://vercel.com/docs/projects/project-configuration#cleanurls


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-source-version-target/pull/43 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-source-version-target.git

Docs Build status updates of commit 204ee08:
:clock10: Pending: waiting for processors (8 builds ahead of you)
:warning: Docs Build is busy, currently there are 8 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 204ee08:
:clock10: Pending: waiting for processors (8 builds ahead of you)
:warning: Docs Build is busy, currently there are 8 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 204ee08:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

versioningArchiveSourceFolder/TOC.yml
:white_check_mark:Succeeded
View (sql-server-2014 || azuresqldb-current || azuresqldb-mi-current || azure-sqldw-latest || >= aps-pdw-2016 || >= sql-server-2016 || >= sql-server-linux-2017 || sql-server-previousversions || sqlallproducts-allversions)

versioningArchiveSourceFolder/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 204ee08:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

versioningArchiveSourceFolder/TOC.yml
:white_check_mark:Succeeded
View (sql-server-2014 || azuresqldb-current || azuresqldb-mi-current || azure-sqldw-latest || >= aps-pdw-2016 || >= sql-server-2016 || >= sql-server-linux-2017 || sql-server-previousversions || sqlallproducts-allversions)

versioningArchiveSourceFolder/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Added pypi version badge

Codecov Report

Merging #2 (5684296) into develop (6757a9a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           99        99
=========================================
  Hits            99        99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6757a9a...5684296. Read the comment docs.


Unable to run project locally

Steps to Reproduce

clone repository
run npm install in terminal
run npm start

It throws the following error:

My system and node specs:
node v18.16.0
typescript v5.1.3
Windows 11 Pro

I was able to run it locally only when I added this devDependencies:

@swc/cli
@swc/core

Please tell me if it's fine to add those dependencies to the project

could you please create a pull request with the suggested changes? let's see how the CI is handling that


Support private repos

Haven't looked into what this would entail

I would imagine something simple like this would work:
degit some/repo --token abc123

That could work, yeah. Would be nice if it used your existing keychain (for HTTPS) or SSH keys as well, just like git clone does.

Would be nice if it used your existing keychain (for HTTPS) or SSH keys as well, just like git clone does.

Played with a it a little bit, but cannot figure out how to reuse existing keychain. Does anyone have any pointers?

Would be nice if it used your existing keychain

This would be awesome. I want to use degit to clone repos on our enterprise github and it get stuck doing the fetch because our enterprise github redirects to a login. The other git command work because they use the keychain

Closed via #29.


Fatal error on sending request

Hi, I got a fatal error, but I'm not sure why. It's definitely related to the embed option as I took out --embed and it ran to completion.
2023-09-07 23:07:40.6904 FATAL Fatal error, application will be closed: UniversalDownloaderPlatform.Common.Exceptions.DownloadException: Unable to retrieve data from https://www.patreon.com/api/posts?include=user%2Cattachments%2Ccampaign%2Cpoll.choices%2Cpoll.current_user_responses.user%2Cpoll.current_user_responses.choice%2Cpoll.current_user_responses.poll%2Caccess_rules.tier.null%2Cimages.null%2Caudio.null&fields%5Bpost%5D=change_visibility_at%2Ccomment_count%2Ccontent%2Ccurrent_user_can_delete%2Ccurrent_user_can_view%2Ccurrent_user_has_liked%2Cembed%2Cimage%2Cis_paid%2Clike_count%2Cmin_cents_pledged_to_view%2Cpost_file%2Cpost_metadata%2Cpublished_at%2Cpatron_count%2Cpatreon_url%2Cpost_type%2Cpledge_url%2Cthumbnail_url%2Cteaser_text%2Ctitle%2Cupgrade_url%2Curl%2Cwas_posted_by_campaign_owner&fields%5Buser%5D=image_url%2Cfull_name%2Curl&fields%5Bcampaign%5D=show_audio_post_download_links%2Cavatar_photo_url%2Cearnings_visibility%2Cis_nsfw%2Cis_monthly%2Cname%2Curl&fields%5Baccess_rule%5D=access_rule_type%2Camount_cents&fields%5Bmedia%5D=id%2Cimage_urls%2Cdownload_url%2Cmetadata%2Cfile_name&sort=-published_at&filter%5Bis_draft%5D=false&filter%5Bcontains_exclusive_posts%5D=true&json-api-use-default-includes=false&json-api-version=1.0&filter%5Bcampaign_id%5D=4062385&page%5Bcursor%5D=014hxQSULXekRMB1PkQR-D7DKR: An error occurred while sending the request.  ---> System.Net.Http.HttpRequestException: An error occurred while sending the request.  ---> System.IO.IOException: The request was aborted.  ---> System.IO.IOException: The response ended prematurely while waiting for the next frame from the server.    at System.Net.Http.Http2Connection.<ReadFrameAsync>g__ThrowMissingFrame|57_1()    at System.Net.Http.Http2Connection.ReadFrameAsync(Boolean initialFrame)    at System.Net.Http.Http2Connection.ProcessIncomingFramesAsync()    --- End of inner exception stack trace ---    at System.Net.Http.Http2Connection.ThrowRequestAborted(Exception innerException)    at System.Net.Http.Http2Connection.Http2Stream.CheckResponseBodyState()    at System.Net.Http.Http2Connection.Http2Stream.TryEnsureHeaders()    at System.Net.Http.Http2Connection.Http2Stream.ReadResponseHeadersAsync(CancellationToken cancellationToken)    at System.Net.Http.Http2Connection.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)    --- End of inner exception stack trace ---    at System.Net.Http.Http2Connection.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)    at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)    at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)    at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)    at UniversalDownloaderPlatform.DefaultImplementations.WebDownloader.DownloadStringInternal(String url, String refererUrl, Int32 retry, Int32 retryTooManyRequests) in F:\Sources\BigProjects\PatreonDownloader\submodules\UniversalDownloaderPlatform\UniversalDownloaderPlatform.DefaultImplementations\WebDownloader.cs:line 408    --- End of inner exception stack trace ---    at UniversalDownloaderPlatform.DefaultImplementations.WebDownloader.DownloadStringInternal(String url, String refererUrl, Int32 retry, Int32 retryTooManyRequests) in F:\Sources\BigProjects\PatreonDownloader\submodules\UniversalDownloaderPlatform\UniversalDownloaderPlatform.DefaultImplementations\WebDownloader.cs:line 408    at UniversalDownloaderPlatform.DefaultImplementations.WebDownloader.DownloadString(String url, String refererUrl) in F:\Sources\BigProjects\PatreonDownloader\submodules\UniversalDownloaderPlatform\UniversalDownloaderPlatform.DefaultImplementations\WebDownloader.cs:line 295    at PatreonDownloader.Implementation.PatreonWebDownloader.DownloadString(String url, String refererUrl) in F:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.Implementation\PatreonWebDownloader.cs:line 31    at PatreonDownloader.Implementation.PatreonPageCrawler.Crawl(ICrawlTargetInfo crawlTargetInfo) in F:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.Implementation\PatreonPageCrawler.cs:line 82    at UniversalDownloaderPlatform.Engine.UniversalDownloader.Download(String url, IUniversalDownloaderPlatformSettings settings) in F:\Sources\BigProjects\PatreonDownloader\submodules\UniversalDownloaderPlatform\UniversalDownloaderPlatform.Engine\UniversalDownloader.cs:line 206    at PatreonDownloader.App.Program.RunPatreonDownloader(CommandLineOptions commandLineOptions) in F:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 128    at PatreonDownloader.App.Program.Main(String[] args) in F:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 68

Similar (same?) here:
PS C:\Users\evang\downloads\PatreonDownloader> .\PatreonDownloader.App.exe --url https://www.patreon.com/bungacast/posts
2023-09-11 15:41:39.3028 FATAL Fatal error, application will be closed: System.Exception: Unable to retrieve cookies
at UniversalDownloaderPlatform.Engine.UniversalDownloader.Download(String url, IUniversalDownloaderPlatformSettings settings) in F:\Sources\BigProjects\PatreonDownloader\submodules\UniversalDownloaderPlatform\UniversalDownloaderPlatform.Engine\UniversalDownloader.cs:line 138
at PatreonDownloader.App.Program.RunPatreonDownloader(CommandLineOptions commandLineOptions) in F:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 128
at PatreonDownloader.App.Program.Main(String[] args) in F:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 68

Seems to be working now―hurray!
I wasn't getting the Chromium popup before, wonder why?


reverted to segmentio

Signed-off-by: jasmingacic<EMAIL_ADDRESS>

We will have to ensure that kusk (CLI) dependencies are updated


fix for swagger without operationIds

creates flows with name "METHOD path" if operationId is null.

Thank you @carloseberhardt


cross platform: Change default timeout to 120 secs

CI / Debug build tests fail due to timeout.
Array/array_slice.js test actually takes 14 seconds to complete
on an empty macbook-pro with Quad 2.9 Ghz i7 cores on it.
Previous 60 seconds timeout may not cover some tests on CI VM / Debug build.
Fixes #1406

FYI @ianwjhalliday
Does it make sense to change the default timeout, or would it be better to just selectively increase the timeout for the problematic tests?
Since we see this for some VMs internally on Windows builds, if we're going to increase the timeout, we could increase it across all OSs.

But I'm a bit worried about extending the timeout and then missing tests that do become problematic.

@dilijev While sharing the same CI / physical machine resources with many other projects, I can't see how test timings are important. (from 60 to 120 seconds)

@obastemur It's an indication that these tests may be badly written or belong in slow tests. Unless there's a reason to have them run for a long time, unit tests should basically finish instantly. It's just an issue of codebase quality (which includes tests).

Unless there's a reason to have them run for a long time, unit tests should basically finish instantly.

In that case we shouldn't even have 60 seconds timeout.. The problem here is pretty straight-forward. As it is written on PR's description; That particular test takes 14 secs on a very decent machine with no additional task. CI can be pretty busy hence it may need more than 60.. IMO there is no practical difference (on a heavily shared CI) between 60 and 120.

@obastemur You may be right about there being no practical difference between 60 and 120. There's definitely a real reason to have some timeout because some tests may not complete at all for one reason or another and block up a test machine, which is why we added the timeouts in the first place.
For the set of tests we see failing regularly, it seems 120s is not enough on some VMs anyway, so I've submitted #1421 to increase the timeouts to 5 minutes to solve the immediate problem.
Few enough tests run beyond even 10s that it seems really overkill to expand the default to a place where it might take twice as long to notice a test is starting to take a long time. We don't have this problem very often and we're seeing it now because of new test infra configurations. If we take the tests that fail regularly and fix up the timeouts, the problem gets resolved without the sledgehammer approach.

In an ideal world where CI machines had enough power that they didn't starve tests of CPU time long enough that they timeout I would say we should not up the default timeout.  But then in that ideal world I would have to admit that my principles here say that we should shrink the default timeout to no more than something small like 5 seconds.
This is squishy.  I feel on the one hand the 60 second timeout is nice to catch longer running tests that starve easily, and get our attention on them to decide whether they are worthwhile or have room for improvement (or should be relegated to the slower tests bucket).  Extending it to 120 or higher would still catch infinite loops, but it would allow slower tests to creep in unnoticed.
I think I prefer leaving the default as is and dealing with individual offending tests on a per case basis.  If this continues to be a problem only on CI then we could up the default timeout, or maybe we need to push for better CI resources if there is a large disparity between them and our dev machines.
Alternatively, as Doug mentioned elsewhere, we could introduce a warning threshold and then increase the timeout significantly.  In which case I would suggest finding a way to have a 5 second warning threshold without it becoming desensitizing noise in CI.

@dilijev @ianwjhalliday the whole claim sounds like comparing apples to oranges.
We don't have JIT etc. enabled on xplat and there is no Debug vs Release test timeout approach on both RL and runtests.py. This PR was targeting runtests.py only and curious if any of you have measured tests on interpreter mode / *nix VM and have clear expectation on timeouts there?
There is a need for Release/Debug/JIT/no JIT timeout approach in case (which I don't agree) we want to keep 60 secs around. IMO, timeout we have serves one purpose; kill a test/process somehow failed to succeed in a given max time. We share the same CI with many other projects and it is hard (if it is possible) to measure anything making sense from the current CI. It just helps us to see if we break anything with a particular PR. In case a PR affects the performance, this CI is definitely not the place to catch that.
Reminder; closed this PR already.  Since we have another PR merged to master no need for merging this one IMHO.

That's fair.  Note that we do run the test suite in -nonative mode for the interpreted variant (which also collects profile data for the dynapogo variant).  So we should hold the *nix version of ChakraCore tests to the same standard.
We did an exercise almost a couple years ago now where we looked at the time each test took on a sample dev machine and examined all the tests that took longer than 5 seconds, and either moved them to the Slow bucket or modified them to not be slow.  Perhaps we should do this exercise again, on a lower end machine.  We should have the data from the CI.  I'll work with @dilijev to go through it and see what we find.


Can I deply this on Heroku?

i will let you know when it's can deploy on heroku

i will let you know when it's can deploy on heroku

alright


Mike | refactor the columns/data to not use that string parsing metho…

…d. INstead, the match[field] = { display: displayValue, value: apiValue }; Then in the table we reference match[field].display, and in the sort we do the same thing, but now we pass in a parameter called 'property' which has a default value of 'display', and the orig value sort passes in 'value' and the actual sort reads it as match[field][property].

See my changes.  I went for a different approach that will conflict with this one.

I think this method is better as it allows easier and more flexible sorting and it feels cleaner since transform code is only called by the selector.

I don't mind doing the refactor work on your branch if that's an issue though

In my branch I import constants synchronously (from static JSON) so in the column defs I can add a new function called dispFn that uses the constants to render a display string.

I disagree, even if we are statically loading constants we should be doing this transform logic as a selector.

That's just the standard pattern for changing/filtering data as it exists in the store

The difference is that we don't mutate the store.  We just define a
function used to generate what gets displayed
On Jun 3, 2016 10:09 AM, "mike-robertson"<EMAIL_ADDRESS>wrote:

That's just the standard pattern for changing/filtering data as it exists
in the store
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/yasp-dota/ui/pull/15#issuecomment-223636610, or mute
the thread
https://github.com/notifications/unsubscribe/AC_UOJiBNAg47YmIH7wl65X7YQVG1qT0ks5qIF-0gaJpZM4Itejn
.

We aren't mutating the store with this implementation. We are creating a copy of the store which has a different structure for the values/display. I don't think it's possible to sort on this other method. We can only sort on the original values which we don't want except for certain cases.

Maybe store the sort value in your data structure as well.  Basically, I
would like all the string mapping to be close together, instead of
scattered.
On Jun 3, 2016 10:25 AM, "mike-robertson"<EMAIL_ADDRESS>wrote:

We aren't mutating the store with this implementation. We are creating a
copy of the store which has a different structure for the values/display. I
don't think it's possible to sort on this other method. We can only sort on
the original values which we don't want except for certain cases.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/yasp-dota/ui/pull/15#issuecomment-223640657, or mute
the thread
https://github.com/notifications/unsubscribe/AC_UOMKp-OBoaYTsErVxBWTu5ZjgYIpdks5qIGN9gaJpZM4Itejn
.

We can move the transformation logic module into the selectors module since it should (in theory) only be needed by selectors. Then all the logic is encapsulated within the selectors


xapian: 1.4.9 -> 1.4.10

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/xapian/versions.
meta.description for xapian is: '"Search engine library"'.

Checks done (click to expand)

built on NixOS
/nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10/bin/xapian-delve passed the binary check.
/nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10/bin/xapian-check passed the binary check.
/nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10/bin/xapian-compact passed the binary check.
/nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10/bin/xapian-progsrv passed the binary check.
/nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10/bin/xapian-replicate passed the binary check.
/nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10/bin/xapian-replicate-server passed the binary check.
/nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10/bin/xapian-tcpsrv passed the binary check.
/nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10/bin/copydatabase passed the binary check.
/nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10/bin/quest passed the binary check.
/nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10/bin/simpleexpand passed the binary check.
/nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10/bin/simpleindex passed the binary check.
/nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10/bin/simplesearch passed the binary check.
/nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10/bin/xapian-metadata passed the binary check.
/nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10/bin/xapian-pos passed the binary check.
/nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10/bin/xapian-config passed the binary check.
15 of 15 passed binary check by having a zero exit code.
12 of 15 passed binary check by having the new version present in output.
found 1.4.10 with grep in /nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10
directory tree listing: https://gist.github.com/8404cb6d8325d418cbba0de24333f30e
du listing: https://gist.github.com/94f36e180564559e7d3516a535c18a70

Rebuild report (if merged into master) (click to expand)

179 total rebuild path(s)
55 package rebuild(s)
55 x86_64-linux rebuild(s)
55 i686-linux rebuild(s)
14 x86_64-darwin rebuild(s)
55 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
afew
akregator
alot
appstream
appstream-qt
astroid
gmailieer
haskellPackages.notmuch
kaddressbook
kdeApplications.akonadi-import-wizard
kdeApplications.akonadi-search
kdeApplications.akonadiconsole
kdeApplications.akregator
kdeApplications.calendarsupport
kdeApplications.eventviews
kdeApplications.incidenceeditor
kdeApplications.kaddressbook
kdeApplications.kalarm
kdeApplications.kdepim-addons
kdeApplications.kdepim-apps-libs
kdeApplications.kdepim-runtime
kdeApplications.khelpcenter
kdeApplications.kmail
kdeApplications.kmail-account-wizard
kdeApplications.kontact
kdeApplications.korganizer
kdeApplications.libgravatar
kdeApplications.libkdepim
kdeApplications.libksieve
kdeApplications.mailcommon
kdeApplications.mailimporter
kdeApplications.mbox-importer
kdeApplications.messagelib
kdeApplications.pim-data-exporter
kdeApplications.pim-sieve-editor
kdeApplications.pimcommon
khelpcenter
kiwix
kmail
kontact
korganizer
meteo
mu
muchsync
neomutt
notmuch
notmuch-addrlookup
python27Packages.notmuch
python37Packages.alot
python37Packages.notmuch

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A xapian https://github.com/r-ryantm/nixpkgs/archive/671365350c1baf437b8c1120c70760b1ea3e1e4e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10
ls -la /nix/store/y3k9l05l4063hh9bc7rnp0jz77x0xllm-xapian-1.4.10/bin

cc @chaoflow for testing.

#55624


Error - CryptographicException -  Unable to store certificate

Windows 2019 Server 64bit
The 'Administrator' account
win-acme <IP_ADDRESS>7 (release, plugable, standalone, 64-bit)
cannot write to the certificate store
I have tried to follow error report 1350 without success.
Does wacs.exe version 2.2.21447 still show the Windows account that opened it? This is the only discrepancy that I noticed when comparing to many screenshots and tutorial videos.
Appreciate

Here the startscreen...

Ok, I just noticed that #1350 thread went alive again last night.
Sorry for creating this new one on the same issue..
I can confirm that the older version <IP_ADDRESS>4.x64.trimmed works fine.
Appreciate

Same problem here, this version <IP_ADDRESS>4 was working fine!

Thanks for the input. I found the bug, you can work around it by setting PrivateKeyExportable or UseNextGenerationCryptoApi to true (or both of those). I found the bug and will release a new version shortly after I do some more testing.


Cannot read property 'type' of null

Since yesterday there is an error happening on our build, which seems to be related with the latest 7.5 release: https://travis-ci.org/sulu/sulu/jobs/304057844#L3406
I don't really know which part of my code might be responsible for this, but if I get some hints on how to find out I might be able to do that :-)

This is already reported ( https://github.com/yannickcr/eslint-plugin-react/issues/1543 ) and a fix has been merged ( https://github.com/yannickcr/eslint-plugin-react/pull/1544 ).
Hopefully a v7.5.1 will go out later today!
Thanks for understanding 👍

Great! Thanks a lot 😃

Duplicate of #1543.


Issue after reinvoking the job in background (after app was killed)

I'm getting the following exception (in background) after killing the app manually and having one scheduled notification.
Anything i am doing wrong or?
07-10 12:59:15.029 1017-1772/com.google.android.gms.persistent E/NetworkScheduler.ATC: Trying to release unacquired lock: com.gymnadz/com.firebase.jobdispatcher.GooglePlayReceiver 07-10 12:59:15.030 11999-11999/com.gymnadz E/ActivityThread: Service com.firebase.jobdispatcher.GooglePlayReceiver has leaked ServiceConnection com.firebase.jobdispatcher.JobServiceConnection@437e93b that was originally bound here     android.app.ServiceConnectionLeaked: Service com.firebase.jobdispatcher.GooglePlayReceiver has leaked ServiceConnection com.firebase.jobdispatcher.JobServiceConnection@437e93b that was originally bound here         at android.app.LoadedApk$ServiceDispatcher.<init>(LoadedApk.java:1514)         at android.app.LoadedApk.getServiceDispatcher(LoadedApk.java:1406)         at android.app.ContextImpl.bindServiceCommon(ContextImpl.java:1589)         at android.app.ContextImpl.bindService(ContextImpl.java:1541)         at android.content.ContextWrapper.bindService(ContextWrapper.java:678)         at com.firebase.jobdispatcher.ExecutionDelegator.executeJob(ExecutionDelegator.java:110)         at com.firebase.jobdispatcher.GooglePlayMessageHandler.handleStartMessage(GooglePlayMessageHandler.java:98)         at com.firebase.jobdispatcher.GooglePlayMessageHandler.handleMessage(GooglePlayMessageHandler.java:67)         at android.os.Handler.dispatchMessage(Handler.java:105)         at android.os.Looper.loop(Looper.java:164)         at android.app.ActivityThread.main(ActivityThread.java:6541)         at java.lang.reflect.Method.invoke(Native Method)         at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

In April 2019 we announced that Firebase Job Dispatcher would be deprecated today, April 7th 2020.  For this reason we are going to close all open issues and archive the repository.  We will also stop supporting FJD for new app installations (such as those targeting sdk versions greater than Android Q).  Existing apps that rely on FJD should continue to function as usual.
While we will no longer work on FJD, we encourage you to migrate to Work Manager which is a superior tool and fully supported by the Android team.
Thank you for taking the time to try the library and provide this feedback.  We sincerely appreciate your effort and we apologize for not addressing it in time.


OID Parsing invalid for values > 0x50

OID with byte value 06 04 82 4B 09 79 being parsed as <IP_ADDRESS>.121 while openssl asnparse and other places parse the bytes as <IP_ADDRESS>.
After much digging including the ITU-T X.690 specification. I have determined that the values allowed for the first number are 0, 1, or 2 and the variable length that is utilized for all other bytes also can apply to byte 0 with some special rules.
Consider the following examples:  First line for each block is the OID bytes.  Second is the current output.  Third is the expected output.
82 4B 09 79
<IP_ADDRESS>.121
<IP_ADDRESS>

88 37 89 52
<IP_ADDRESS>4
2.999.1234

82 00 09 79
<IP_ADDRESS>.121
<IP_ADDRESS>

79 00 09 79
<IP_ADDRESS>.121
<IP_ADDRESS>.121

88 37 03
<IP_ADDRESS>
2.999.3

Consider using this alternate decode block or modify to fit your coding style/needs.
public static String decode(Asn1Reader asn)
{
    var SB = new StringBuilder();

    Int32 pi = asn.PayloadStartOffset;

    BigInteger value = 0;
    BigInteger additional = 0;

    // if first byte value < 80
    if (asn[pi] > 0x50)
    {
        SB.Append("2");

        // single byte
        if (asn[pi] < 0x80)
        {
            SB.Append(".");
            SB.Append(asn[pi] - 0x28);
        }
        // multibyte
        else if (asn[pi] > 0x80)
        {
            value = ((asn[pi] & 0x7F) - 1);

            additional = 0x30;
        }
        // error, invalid value
        else
        {
            return "**Error**";
        }
    }
    else
    {
        SB.Append(asn[pi] / 0x28);
        SB.Append("." + asn[pi] % 0x28);
    }

    for (Int32 i = 1; i < asn.PayloadLength; i++)
    {
        pi = asn.PayloadStartOffset + i;

        value <<= 7;
        value += asn[pi] & 0x7f;

        if ((asn[pi] & 0x80) == 0)
        {
            value += additional;

            SB.Append("." + value);

            value = 0;
            additional = 0;
        }
        else if (i == asn.PayloadLength - 1)
        {
            // error, ends with 0x8X
            return "**Error**";
        }
    }

    return SB.ToString();
}

Thanks for report! I will investigate this issue.

I found that both, OID encoder and decoder were buggy. In addition, I found another bug (#7) which was also fixed.
Thanks for provided workaround and spent efforts, however I found a better and more optimal fix for this issue which required less changes while retaining existing logic. The issue is fixed and I've added a number of unit tests (including all your examples) to ensure its correctness.


Band protocol IBC Challenge

What me and Vinh did:

Create a local bainchain, include data source, data script, v.v.  Just change length used in validation of port identifiers to 128 to create ibc channel from juno contract to bandchain.  My bandchain code here

Create a Ibc channel from juno mainet to my local bandchain (I can't use band mainet because they don't approve wasm port, they still use ibc v1.1.5,  length used in validation of port identifiers still 64)

I tried use laozi-testnet, but it have this error, it's reason i used local testnet

Create a smart-contract for request oracle data over IBC. Smart contract code here. I've store it in Juno mainnet (code_id = 52)

Call contract to query oracle data over IBC and received oracle data.

deployment guide here: Guide

Proof: Tx ibc-received in mintscan:

Call contract : https://www.mintscan.io/juno/txs/E9F4F8C7AA3F8D287D8C199540CF90E25E6A459A8A49E5ACF78FEF93CD7DAB1F
Ibc packet received in Juno mainnet : https://www.mintscan.io/juno/txs/0419C27A42844342E56EA82C70D44611E3A2D299808BD523220CD61BDE619778

@JakeHartnell
pls have a look, sir

Repo doesn't seem to be public: https://github.com/notional-labs/oracle-ibc/tree/main/contracts
Could you submit a PR to band protocol to start discussion? They need to upgrade their IBC version, would love to use their oracles in contracts. CC @faddat.

oh sorry, I just change visibility to public
about band, I have already submitted a pr to their reo but they didn't answer yet: https://github.com/bandprotocol/chain/issues/202

here is the pr to start discussion:
https://github.com/bandprotocol/chain/pull/205

here is the pr discussion on ibc upgrade:
https://github.com/bandprotocol/chain/pull/205

@JakeHartnell, can you take a look at our solution

The band channel is created right @faddat
Do you mind sharing the ID for it again? Thanks!

I think we're waiting on band to commit to an IBC version bump?

@the-frey yes. Band mainnet is using ibc v1.1.5. It don't allow wasm port.

We need to pressure them to upgrade or we should launch a better oracle solution.

Is this bounty still available? Bandprotocol has upgraded their testnet to ibc v3 and we can enable ibc with wasm port on it.

Is this bounty still available? Bandprotocol has upgraded their testnet to ibc v3 and we can enable ibc with wasm port on it.

Go for it!


Upgrade the local assets that were built using previous versions of SA, after user has installed newer version of SA

Use case:

User has an older version of SA installed.
User has created project using the older version of SA and the local assets are built using that.
User uninstalls the older version of SA and installs newer version.
User wants to run SA commands from the project created in step 2. Some commands could be safe to invoke and some are not.

Safe vs unsafe commands:

When user invokes safe commands we would like to allow them.

This would be commands like slsart invoke which would invoke the load test on the assets that are already deployed.

When user invokes unsafe commands we would like to block that action and prompt user to upgrade the local assets.

This would be commands like slsart invoke -m when the deployed assets are not supporting monitoring. In such case command would invoke load test instead of running monitoring once (as user would expect).

For cases such as "user is always using the safe commands and hence is never notified about upgrade", we would like to inform the user that they can upgrade the local assets by printing a message for only a certain commands that are less used.

Informing user about upgrade for safe commands like slsart invoke could be annoying as user would be running that command more often than others.
Informing user about upgrade for safe commands like slsart deploy which is used less often would be less annoying. And at the same time we get to inform the user that they are deploying assets built using older version of SA where as they have now installed newer version on their dev machine. We don't need to block the command as it will not cause any harm but would be a good place to remind them that they are deploying older assets. And that they have an option to upgrade them.

After discussing with @erikerikson yesterday, we came up with some technical requirements around the implementation of this feature including the process by which we upgrade their project.
A user begins by issuing the slsart upgrade command working in a directory which contains the function assets previously unpacked using the slsart configure command.
First, the version is read from the package.json and compared to the known list of previous function asset versions:

If version is not found, we will treat the assets as if they were the default function asset version and will be assigned the version 0.0.0.
If version is found, but is not a know previous version, we will inform the user that we cannot upgrade the project and exit.

Note: Unclear how to handle the case when a developer decides to use the version number in the project for her own purposes. Given the second rule above, she might make her project un-upgradeable.
The versioning module will include each of the previous versions of the function assets, each in a directory by version.
Function assets fall into three categories and different considerations apply to upgrade each:

serverless.yml - missing resources must be injected
package.json - specific dependencies must be removed and added
*.js - modifications to function source is detected and backed up, providing original for diff

What should happen if the user, after installing newer version of SA, runs slsart configure command in the project folder that was build with older version of SA?
I think we should inform the user that we were unable to run the command as folder already has the asset files (serverless.yml etc) (this is what we do today) and that they should upgrade using slsart upgrade.

Yes, I'd agree that if we detect an existing project in the current working directory when slsart configure is issued, then we should exit as you suggest, as we do today.
Are you suggesting that we include the configure command in the Informing command category you describe above?

Are you suggesting that we include the configure command in the Informing command category you describe above?

Yes that is what I was suggesting. It is one of those commands that one doesn't use often so it won't be too noisy. Plus the monitoring mode doc says one should run that command to setup monitoring so user might run that expecting monitoring to setup. So would be good place to remind that they should upgrade.

Upgrading the serverless.yml will add the following resource definitions to the existing service definition, leaving the remainder of the file unchanged.
The following updates/injections will need to be made to upgrade the serverless.yml from versoin 0.0.0 to 0.0.1:

provider.runtime updated to nodejs8.10
Inject:

    - Effect: 'Allow'
      Action:
        - 'sns:Publish'
      Resource:
        Ref: monitoringAlerts # must match the SNS topic's logical ID

into provider.runtime.iamRoleStatements array

Inject:

    environment:
      TOPIC_ARN:
        Ref: monitoringAlerts
      TOPIC_NAME:
        'Fn::GetAtt':
          - monitoringAlerts
          - TopicName
    events:
      - schedule:
          name: '${self:service}-${opt:stage, self:provider.stage}-monitoring' # !!Do not edit this name!!
          description: The scheduled event for running the function in monitoring mode
          rate: rate(1 minute)
          ########################################################################################################################
          ### !! BEFORE ENABLING... !!!
          ### 0. Change `'>>': script.yml` below to reference the script you want to use for monitoring if that is not its name.
          ###    The script must be in this directory or a subdirectory.
          ### 1. Modify your `script.yml` to provide the details of invoking every important surface of your service, as per
          ###    https://artillery.io/docs
          ### 2. Add a `match` clause to your requests, specifying your expectations of a successful request.  This relatively
          ###    undocumented feature is implemented at: https://github.com/shoreditch-ops/artillery/blob/82bdcdfc32ce4407bb197deff2cee13b4ecbab3b/core/lib/engine_util.js#L318
          ###    We would welcome the contribution of a plugin replacing this as discussed in https://github.com/Nordstrom/serverless-artillery/issues/116
          ### 3. Modify the `monitoringAlerts` SNS Topic below, uncommenting `Subscription` and providing subscriptions for any
          ###    alerts that might be raised by the monitoring function.  (To help you out, we've provided commented-out examples)
          ###    (After all, what good is monitoring if noone is listening?)
          ### 4. Deploy your new assets/updated service using `slsart deploy`
          ### 5. [As appropriate] approve the subscription verifications for the SNS topic that will be sent following its creation
          ########################################################################################################################
          enabled: false
          input:
            '>>': script.yml
            mode: monitoring

into functions.loadGenerator

Inject

resources:
  Resources:
    monitoringAlerts: # !!Do not edit this name!!
      Type: 'AWS::SNS::Topic'
      Properties:
        DisplayName: '${self:service} Monitoring Alerts'
#        Subscription: # docs at https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-sns-subscription.html
#          - Endpoint: http://<host>/<path> # the endpoint is an URL beginning with "http://"
#            Protocol: http
#          - Endpoint: https://<host>/<path> # the endpoint is a URL beginning with "https://"
#            Protocol: https
#          - Endpoint: <target>@<host> # the endpoint is an email address
#            Protocol: email
#          - Endpoint: <target>@<host> # the endpoint is an email address
#            Protocol: email-json
#          - Endpoint: <phone-number> # the endpoint is a phone number of an SMS-enabled device
#            Protocol: sms
#          - Endpoint: <sqs-queue-arn> # the endpoint is the ARN of an Amazon SQS queue
#            Protocol: sqs
#          - Endpoint: <endpoint-arn> # the endpoint is the EndpointArn of a mobile app and device.
#            Protocol: application
#          - Endpoint: <lambda-arn> # the endpoint is the ARN of an AWS Lambda function.
#            Protocol: lambda

as additional resources for the service.

Upgrading the package.json requires the following changes, informed by the updates made to implement monitoring-mode.

Add version set to 0.0.1
Update license to Apache-2.0
Remove the following dependencies:

    "artillery-core": "^2.0.3-0",
    "csv-parse": "^1.1.7"

Add the following dependiencies:

    "artillery": "git+https://github.com/Nordstrom/artillery.git#2d99b7ab1075e9df9f6eb2903102abc7849f1879",
    "js-yaml": "^3.11.0",
    "lodash.merge": "^4.6.1",
    "lodash.omit": "^4.5.0",
    "util-promisify": "^2.1.0"

Note: This takes a dependency on our private branch of Artillery. We need to discuss if this is the appropriate decision.
Also, there is a risk of breaking the developer's project if they've taken a dependency on either artillery-core or csv-parse in their code. This seems unlikely to occur and also difficult to detect when this is the case.

Upgrading code for the local assets consists of, in the trivial case, removing the existing handler.js and replacing with the updated implementation files in lib/lambda:
alert.js
func.js
funcDef.js
funcExec.js
funcHandle.js
funcValid.js
handler.js
task.js
taskDef.js
taskExec.js
taskPlan.js
taskResult.js
taskValid.js

If any of the implementation files in the list above would overwrite an existing file in the local assets, the application will list the files in conflict and exit. No changes to the local assets will be made.
However, handler.js is an exception to the rule above, given that it should always be present. In most cases, it should remain unchanged and replacing would not result in loss of developer work.
Should the developer have modified her handler.js, we will create a backup copy as handler.js.bak and provide a reference handler.js.old. We will provide a message to the user informing them where we copied their files and that they can diff to see their changes.

First, the version is read from the package.json and compared to the known list of previous function asset versions

I would recommend that there are valid and reasonable scenarios for users to modify the version listed in package.json.  As a result, I suspect it might be worth creating a .slsart file that simply lists the version.  This avoids conflict with well intentioned users.  A user that modifies that will be hard pressed to explain to us why they needed to do so, at least without some humility.  If we make it yml we could even leave a comment warning them against doing so.

Should the developer have modified her handler.js, we will create a backup copy as handler.js.bak and provide a reference handler.js.old.

Nit: perhaps handler.js.original (or .orig) would be a little more immediately understandable?

Otherwise, this all looks very good to me.

Awesome. Thanks a bunch for jumping in quickly. 😄
I've updated my comments above with your feedback. We'd discussed the use of a hidden file to perhaps contain a hash as well as a version number at one time, IIRC.
Agree that it's better than the potential snarl we're setting well-intentioned users up for.

This is ultimately the upgrade feature and has been delivered with 0.4.0. Closing.


derived type etc

Docs Build status updates of commit c24267b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Advertising/bingads-13/campaign-management-service/getfileimportuploadurl.md
:bulb:Suggestion

Details

Advertising/bingads-13/ad-insight-service/ad-insight-data-objects.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/includes/request-header.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/bulk-data-objects.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/includes/request-header.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadextensions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroupcriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroups.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addads.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addaudiences.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addbudgets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigncriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigns.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addconversiongoals.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addexperiments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addimportjobs.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addkeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlabels.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlistitemstosharedlist.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addnegativekeywordstoentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addsharedentity.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/adduettags.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/appealeditorialrejections.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversionadjustments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyproductpartitionactions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-data-objects.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadextensions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadextensionsassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadgroupcriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadgroups.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteads.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteaudiences.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletebudgets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletecampaigncriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletecampaigns.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteexperiments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteimportjobs.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletekeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletelabelassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletelabels.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletelistitemsfromsharedlist.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletemedia.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletenegativekeywordsfromentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletesharedentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletesharedentityassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getaccountproperties.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadextensionsassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadextensionsbyids.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadextensionseditorialreasons.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.

Advertising/bingads-13/campaign-management-service/getfileimportuploadurl.md

Line 7, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Reserved for future use.' is duplicated in 'bingads-13/campaign-management-service/fileimportjob.md(7,14)', 'bingads-13/campaign-management-service/fileimportoption.md(7,14)', 'bingads-13/campaign-management-service/getfileimportuploadurl.md(7,14)', 'bingads-13/campaign-management-service/importadditionalfield.md(7,14)', 'bingads-13/campaign-management-service/targetimpressionsharebiddingscheme.md(7,14)'. NOTE: This Suggestion will become a Warning on 1/29/21.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 0d379bc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Advertising/bingads-13/ad-insight-service/ad-insight-data-objects.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/includes/request-header.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/bulk-data-objects.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/includes/request-header.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadextensions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroupcriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroups.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addads.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addaudiences.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addbudgets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigncriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigns.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addconversiongoals.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addexperiments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addimportjobs.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addkeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlabels.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlistitemstosharedlist.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addnegativekeywordstoentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addsharedentity.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/adduettags.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/appealeditorialrejections.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversionadjustments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyproductpartitionactions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-data-objects.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadextensions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadextensionsassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadgroupcriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteadgroups.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteads.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteaudiences.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletebudgets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletecampaigncriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletecampaigns.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteexperiments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteimportjobs.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletekeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletelabelassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletelabels.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletelistitemsfromsharedlist.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletemedia.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletenegativekeywordsfromentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletesharedentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deletesharedentityassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/fileimportjob.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/fileimportoption.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getaccountproperties.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadextensionsassociations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getadextensionsbyids.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit e34ef82:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Advertising/bingads-13/ad-insight-service/ad-insight-data-objects.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/includes/request-header.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/bulk-data-objects.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/includes/request-header.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroupcriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroups.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addads.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addimportjobs.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addkeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-data-objects.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-service-operations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-value-sets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/deleteimportjobs.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/fileimportjob.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/fileimportoption.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getfileimportuploadurl.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getimportjobsbyids.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/getimportresults.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/googleimportjob.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/importadditionalfield.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/includes/request-header.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/operationerror.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/targetimpressionsharebiddingscheme.md
:white_check_mark:Succeeded

Advertising/bingads-13/customer-billing-service/customer-billing-data-objects.md
:white_check_mark:Succeeded

Advertising/bingads-13/customer-billing-service/includes/request-header.md
:white_check_mark:Succeeded

Advertising/bingads-13/customer-management-service/customer-management-data-objects.md
:white_check_mark:Succeeded

Advertising/bingads-13/customer-management-service/includes/request-header.md
:white_check_mark:Succeeded

Advertising/bingads-13/guides/authentication-oauth-identity-platform.md
:white_check_mark:Succeeded

Advertising/bingads-13/guides/google-ads-import.md
:white_check_mark:Succeeded

Advertising/bingads-13/reporting-service/includes/request-header.md
:white_check_mark:Succeeded

Advertising/bingads-13/reporting-service/reporting-data-objects.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


OrganizationActivity SubEvent

Getting this error when pulling down some data:
org.zendesk.client.v2.ZendeskException: java.lang.IllegalArgumentException: Could not resolve type id 'OrganizationActivity' into a subtype of [simple type, class org.zendesk.client.v2.model.events.Event]
at [Source: N/A; line: -1, column: -1] (through reference chain: org.zendesk.client.v2.model.Audit["events"])

@aduchon would you kindly provide some code to reproduce this exception?

Reproduction example, based upon Zendesk docs:
    String json = "{ \"id\":<PHONE_NUMBER>3, \"type\": \"OrganizationActivity\", \"subject\": null, \"body\": \"This is sample data\", \"recipients\": [568628833] }";
    ObjectMapper mapper = new ObjectMapper();
    try {
    Event ev = mapper.readValue( json.getBytes(), Event.class );
    } catch (Exception e ) {
      System.out.println( e );
    }

This can be closed as fixed in 0.3.1.  Thanks.


[e2e]: generic tag branch1 default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/v22.0.578
Run: https://github.com/slsa-framework/example-package/actions/runs/7663083454
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.tag.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.tag.branch1.default.slsa3.yml
Trigger: push
Branch: v22.0.578
Date: Fri Jan 26 02:12:34 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v22.0.579
Run: https://github.com/slsa-framework/example-package/actions/runs/7675655786
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.tag.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.tag.branch1.default.slsa3.yml
Trigger: push
Branch: v22.0.579
Date: Sat Jan 27 02:10:40 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v22.0.580
Run: https://github.com/slsa-framework/example-package/actions/runs/7682750128
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.tag.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.tag.branch1.default.slsa3.yml
Trigger: push
Branch: v22.0.580
Date: Sun Jan 28 02:17:45 UTC 2024
Tests are passing now. Closing this issue.


tests: use baseURL to avoid string duplication

Signed-off-by: Carlos Panato<EMAIL_ADDRESS>
Description
based on this request: https://github.com/alexellis/arkade/pull/498#discussion_r686579516 improving the tests to avoid string duplication
Motivation and Context

[ ] I have raised an issue to propose this change (required)

How Has This Been Tested?

Are you a GitHub Sponsor (Yes/No?)

[x] Yes
[ ] No

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Documentation

[ ] I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
[ ] I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

[ ] I have tested this on arm, or have added code to prevent deployment

@cpanato mental! ❤

I get the intent here, but I feel like it will make this actively harder to maintain, I usually copy the full URLs from the downloads page into the test as part of writing each app.
Sorry that you went to all this work without checking if it was wanted first.

no problem @alexellis
What do you have in mind to rewrite that?

Closing might be the best course of action for now. Please do suggest big changes or refactoring in an issue in the future, I hate being the bad guy and having to say no.


Bump Django version to 1.11.20

https://docs.djangoproject.com/en/2.1/releases/1.11.20/

https://github.com/rackerlabs/scantron/pull/86


Fix compatibility of generated code with forbid(future_incompatible)

Note: This does not guarantee compatibility with forbid(future_incompatible) in the future.
If rustc adds a new lint, we may not be able to keep this.
cc https://github.com/taiki-e/pin-project/issues/281

bors r+


Move Files and Directories

Add support for moving files and directories, including multiple at once.

Closing in favor of https://github.com/quantopian/pgcontents/pull/64


Required props JSX validation

I would like a rule that looks for missing required props.
This should be an error
<Text />

This should not be an error
<Text name="cathal" />

Example component
const React = require('react');
const {Component, PropTypes} = React;

class Text extends Component {
  render() {
    return
Hello {this.props.name}

  }
}

Text.propTypes = {
  name: PropTypes.string.isRequired
};

module.exports = Text;

This is something that can be done at runtime, but at compile time would require parsing the module dependency graph, and evaluating the component module.
In other words, this is what PropTypes already do at runtime, and isn't likely to be something that is even possible to statically lint for.
In our tests, we override console.warn and console.error so that they throw, and voila, PropType warnings fail tests.

Like @ljharb said, when linting we only check files individually, so we are not aware of components definitions in other files. Because of that we can't know if its requirements are fulfilled.
You'll need to rely on PropTypes at runtime for that.


Tabs opening significantly speeded up

Moving mouse gestures initialization moved into separate thread

Current coverage is 38.07%

Merging #1675 into master will increase coverage by +18.33% as of 2e50d59

@@            master   #1675   diff @@
======================================
  Files         1704     557    -1147
  Stmts        72003   24057   -47946
  Branches         0       0
  Methods          0       0
======================================
- Hit          14219    9160    -5059
  Partial          0       0
+ Missed       57784   14897   -42887

Review entire Coverage Diff as of 2e50d59

Powered by Codecov. Updated on successful CI builds.


ID minting

Implements DPLA ID mapping in provider extractors.

Created PR for discussion only. Need to rebase and squash before merge.

@mdellabitta bumping for discussion tomorrow at weekly meeting

@mdellabitta fixed up that CDL @id mapping issue.

@mdellabitta removed id and @id and fixed up tests. Should be ready for merge after travis and codacy


[20.09] singularity: bump vendored deps to patch CVE-2021-29136

Motivation for this change
Resolves #124678.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Unfortunately NixOS 20.09 has reached its end-of-life status on 2021-07-01, one
month after the release of NixOS 21.05.
Since we do not accept any changes to its branches anymore, I'm closing this pull
request.


Take Gems from govuk_test

The gems will get installed as dependencies of govuk_test.

This depends on https://github.com/alphagov/govuk_test/pull/5.


crime and punishment" to the reforms

Loup99
I haven't played the mod much, but what do you have in mind concerning the death penalty and abolishing it?
simsulla
On the death penalty - no reform at the moment. But we have an empty slot in the "political reforms" maybe death penalty fits there. If anyone whnat to have a go at moddin pleas ad "crime and puncishment" to the reforms, and it will get into the mod. No plans for me doing it at the moment thouth

The plan is to replace the "internet" reform set with crime and punishment. The internet is to tech specific, and does not reflect major society problem handling.


[api-docs] add stage_instance_* to table

A new commit was made into the api-docs repo. This issue was created automatically. Need to review if we made any change to the library for this commit.
https://github.com/discord/discord-api-docs/commit/9224d4e95d68d8565c764d9f4f5256a3a1d84bd7

ncn


Formatter for sql？

Is there a formatter plugin for sql?
i used editor.getAction('editor.action.formatDocument').run(), but it didn't work.
console:
There is no formatter for sql-files installed.

You can add your own formatter using:
    monaco.languages.registerDocumentFormattingEditProvider("sql", {
      async provideDocumentFormattingEdits(model) {
        var formatted = await sqlfmt(model.getValue());
        return [
          {
            range: model.getFullModelRange(),
            text: formatted,
          },
        ];
      }
    });

You still need to implement your own sql formatting though. For a test setup i have installed https://github.com/lopezator/sqlfmt (https://sqlfum.pt/) as a command line tool and made it available through the webserver.
  const sqlfmt = (sql) => {
    const loc = document.location;
    const base = loc.protocol + "//" + loc.host;
    const url = base + "/sqlfmt?sql=" + encodeURIComponent(sql);
    return fetch(url).then((response) => {
      return response.text();
    });
  };

I found this one helpful: https://stackoverflow.com/a/66344338/368254

An SQL formatter is out of scope for the monaco-editor package.
However, as @sanderhahn already noted, you can easily add your own formatter.
We would welcome an npm package by the community that contributes an SQL formatter that can be used in monaco!

Well, there is one: sql-formatter 😃
See stack overflow link above


[SCHEMA] Record which version of the schema was used to run validation.

Note that this is not SCHEMA_VERSION which is a syntax version for schema compatibility. This records the specific bids_schema_version, which should identify the schema contents rather than the syntax.

Regarding the two lines not covered:
We don't currently ship any library of past BIDS versions, nor do we support a lot of historical versions, so there's no way to check for correct schema specifications other than live at this point.

@yarikoptic want to review? I need 2 reviews to merge ^^

@effigies @tsalo interested? The 2 failing tests are unrelated to this PR.

@effigies this adds the BIDS version file to the schema directory, and loads it in the validator, as discussed last Thursday.
Currently this file is not edited for release, best for a separate PR I think.

@effigies addressed points raised.


Sprite's render order is incorrect

tutorial/03-Clone

_____________________ spx1__________________________________________________spx2___________

The rendering order for Spx1 is that sprites created first are displayed in front, while for Spx2, sprites created later are displayed in front. The second method is more intuitive and aligns with the default rendering approach of most engines.
Is there a specific reason for Spx1's design? If not, should it be changed to follow the conventional engine rendering method?


Sleep for 5 seconds before pushing to registry in tests

Signed-off-by: TomSweeneyRedHat<EMAIL_ADDRESS>We've some kind of timing issue going on with the push to a local repository test.  Adding a 5 second wait to see if the issue is cleared by that.

bot, retest this please

Your efforts to defeat test flakes are being defeated by flakes setting up the tests. There's something funny about that.

OK, all green.  I'm going to close and reopen to see if this was luck or a potential work around.

bot, retest this please

@mheon had it failed or did my close/reopen not kick off a build?

@TomSweeneyRedHat it was green, but I kicked it again to get one more round of tests in. Seems good though.

If these pass, LGTM

Thx for the 411 @mheon.

This looks good. @rhatdan PTAL

I will hold my nose while saying LGTM

@rh-atomic-bot r+


Potion making and item crushing

Add all possible unfinished potions
Add all possible finished potions
Add all juju finished and unfinished juju potions
Add swamp tar making using, guam, marrentill, tarromin.
Add item crushing using pestle and mortar for unicorn dust, kebbit teeth, blue dragon scale, crushed gem.
Add animations ids to animations.yml for potion making and pestle and mortar.

Great work! Is herblore complete after this?

Yes the potions I didn't do was the potions related to dungeoneering as I thought these would be better done when dungeoneering get's worked on.


adding micheline resturent scraper

Description
Michelin resturent data scraper
Fixes #114
Type of change
Choosing one or more options from the following as per the nature of your Pull request.

NOTE: These boxes can be checked using [X]

[x] New feature (non-breaking change which adds functionality)

[x] Documentation Update

Checklist:
Please tick all the boxes that are fulfilled by your Pull Request.

[x] I have named my files and folder, according to this project's guidelines.
[x] My code follows the style guidelines of this project.
[x] My Pull Request has a descriptive title. (not a vague title like Update index.md)
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
[x] I have included a requirements.txt file (if external libraries are required.)
[x] My changes do not produce any warnings.
[ ] I have added a working sample/screenshot of the script.

Please follow the Code of Conduct.
Which issue is this PR referred to? Please link your PR to the respective issue, or create one here.

sorry should have mentioned it
Michelin star restaurants scraper #114
The issue was closed by the GitHub bot, let me know if you want me to create a new one.

@killerpanda101 add a few more comments and refer to existing scripts to check the proper requirements file format.
Enclose the main function call under --  if __name__ == "__main__":
Try fixing the deep source stuff, if you are unable to fix them, i'll help you.

@allcontributors please add @killerpanda101 for code


Fixes #2493 refactoring blood vessel endothelial cells

Fixes #2493 refactoring blood vessel endothelial cells
Note: For capillaries I had asserted that they are 'capillary endothelial cell', as the EquivalentTo follows a different pattern.

#gogoeditdiff

everything looks good


New S3 default policy breaks creation of S3 bucket

It would seem that Amazon is pushing S3 bucket defaults that's breaking the module.
https://aws.amazon.com/about-aws/whats-new/2023/04/amazon-s3-two-security-best-practices-buckets-default/
Unfortunately, this means that, with the combination of default settings, the s3 bucket doesn't create as it appears that the default policy that it sets in is incompatible with the bucket policy that is trying to put in.

I'm going to try to workaround this buy actually getting the module and tweaking the settings of the downstream s3 module to allow ACLs to see if it works.

Form what I have experimented so far...., changing a setting so that I can set s3_object_ownership to "BucketOwnerPreferred" has a okay workaround....

in that, in the 1st TF run, I still run into this, but if I ran TF apply again a 2nd time, then everything gets applied and set.

I think it might have something to deal with how the cloudposse/s3-log-storage/aws module sets up the ACL....
https://github.com/hashicorp/terraform-provider-aws/issues/28353

Isn't the default for the s3_object_ownership input variable already BucketOwnerPreferred?

This has been fixed in the upstream terraform-aws-s3-bucket and will be fixed in the next release of this module.


finetune error

Loading checkpoint shards: 100%|█████████████████████████████████████████████████████████████████| 2/2 [00:04<00:00,  2.06s/it] Loading data... Num of training samples:  5405 5405 Formatting inputs...Skip in lazy mode /cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/accelerate/accelerator.py:436: FutureWarning: Passing the following arguments to Acceleratoris deprecated and will be removed in version 1.0 of Accelerate: dict_keys(['dispatch_batches', 'split_batches']). Please pass anaccelerate.DataLoaderConfiguration instead:  dataloader_config = DataLoaderConfiguration(dispatch_batches=None, split_batches=False)   warnings.warn( Detected kernel version 3.10.0, which is below the recommended minimum of 5.5.0; this can cause the process to hang. It is recommended to upgrade the kernel to the minimum version or higher.   0%|                                                                                | 0/1600 [00:00<?, ?it/s]use_cache=Trueis incompatible with gradient checkpointing. Settinguse_cache=False... /cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/torch/utils/checkpoint.py:429: UserWarning: torch.utils.checkpoint: please pass in use_reentrant=True or use_reentrant=False explicitly. The default value of use_reentrant will be updated to be False in the future. To maintain current behavior, pass use_reentrant=True. It is recommended that you use use_reentrant=False. Refer to docs for more details on the differences between the two variants.   warnings.warn( Traceback (most recent call last):   File "train_chunkllama_16k.py", line 292, in <module>     train()   File "train_chunkllama_16k.py", line 286, in train     trainer.train()   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/transformers/trainer.py", line 1539, in train     return inner_training_loop(   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/transformers/trainer.py", line 1869, in _inner_training_loop     tr_loss_step = self.training_step(model, inputs)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/transformers/trainer.py", line 2772, in training_step     loss = self.compute_loss(model, inputs)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/transformers/trainer.py", line 2795, in compute_loss     outputs = model(**inputs)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl     return self._call_impl(*args, **kwargs)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl     return forward_call(*args, **kwargs)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/accelerate/utils/operations.py", line 825, in forward     return model_forward(*args, **kwargs)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/accelerate/utils/operations.py", line 813, in __call__     return convert_to_fp32(self.model_forward(*args, **kwargs))   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/torch/amp/autocast_mode.py", line 16, in decorate_autocast     return func(*args, **kwargs)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/transformers/models/llama/modeling_llama.py", line 1183, in forward     outputs = self.model(   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl     return self._call_impl(*args, **kwargs)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl     return forward_call(*args, **kwargs)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/transformers/models/llama/modeling_llama.py", line 1060, in forward     layer_outputs = self._gradient_checkpointing_func(   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/torch/_compile.py", line 24, in inner     return torch._dynamo.disable(fn, recursive)(*args, **kwargs)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/torch/_dynamo/eval_frame.py", line 328, in _fn     return fn(*args, **kwargs)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/torch/_dynamo/external_utils.py", line 17, in inner     return fn(*args, **kwargs)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/torch/utils/checkpoint.py", line 451, in checkpoint     return CheckpointFunction.apply(function, preserve, *args)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/torch/autograd/function.py", line 539, in apply     return super().apply(*args, **kwargs)  # type: ignore[misc]   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/torch/utils/checkpoint.py", line 230, in forward     outputs = run_function(*args)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl     return self._call_impl(*args, **kwargs)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl     return forward_call(*args, **kwargs)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/transformers/models/llama/modeling_llama.py", line 798, in forward     hidden_states, self_attn_weights, present_key_value = self.self_attn(   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl     return self._call_impl(*args, **kwargs)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl     return forward_call(*args, **kwargs)   File "/cpfs01/shared/public/msm/workspace/software/miniconda3/envs/tmp/lib/python3.8/site-packages/transformers/models/llama/modeling_llama.py", line 704, in forward     cos, sin = self.rotary_emb(value_states, seq_len=kv_seq_len) ValueError: too many values to unpack (expected 2)
but i think my env is right, cause i have successful run the needle test
my env:
torch                         2.1.2
torchmetrics                  1.3.0.post0
transformers                  4.37.2
transformers-stream-generator 0.0.4
flash-attn                    2.5.6

Please add attn_implementation="flash_attention_2 when loading the  model Line 265

This error is caused by LlamaFlashAttention2.forward not being correctly replaced by the new forward function.


Add support for captcha in support form

This PR is moving the contact support endpoint from the frontend project to the API, in order to use the captcha verification function, mutualized from orders.js.

Looks good! Let's make sure to double check it's working nicely when in production.


Patan College For Professional Studies

@ajayaatpcps First stage of verification passed, official domain is patancollege.edu.np as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@ajayaatpcps Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Reset _transfer_in_progress if mavlink transfer times out.

Looking good!

That was quick!  15 minute pull request turnaround time :-)

Thanks for providing. Was an obvious fix. I usually look at PRs in close to real time, but almost always it requires longer time to properly review.

Hey I'd love to get your feedback on this issue too:
https://github.com/PX4/jMAVSim/issues/29


keep homebrew updated on osx

Fixes #323

This change is

@bors-servo r+

:pushpin: Commit 445fb53 has been approved by edunham

:hourglass: Testing commit 445fb53 with merge 6b179c9...

:sunny: Test successful - travis


reStructuredText rendering errors have incorrect line numbers

When rendering a ReStructuredText document (not sure about other document types), if an error is encountered, the line numbers shown are incorrect.  For example:
<string>:29: (ERROR/3) Unexpected indentation.

The actual error is on line 34 of my document.  This appears to be due to the YAML metadata header in my document, which happens to be exactly 5 lines long.  This is consistent across other documents with varying YAML metadata line counts.  Clearly the YAML header is stripped off the RST document before being fed to docutils.
It's not too hard to mentally workaround this now that I know to keep it in mind.
I can think of two possible fixes for this:

Prepend N blank lines to the RST document that is fed to docutils, where N is equal to the number of YAML metadata lines.  Kind of a hack, but presumably easier.

Extract metadata from RST directly, rather than using YAML.  Before coming to Wok, I was dabbling with Pelican (another static blog generator that supports RST).  Pelican does this exactly, i.e. instead of mixing YAML + RST, the entire source document is pure RST (or Markdown), and the metadata is extracted using the native document tools.

I think prepending the N blank lines is the better solution here. Wok works with multiple sources of data, including Markdown and plain text, neither of which have metadata options built in. I would prefer to have a consistent metadata structure, and the header provides that.


typo "through Log Analytic queries"

instead of "Log Analytics"

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1dd1c1ed-ebf6-4606-b7cd-cc005fee74b2
Version Independent ID: d32aec41-af2c-82ac-e1ac-d5b7105e48cc
Content: Monitoring Azure Blob Storage - Azure Storage
Content Source: articles/storage/blobs/monitor-blob-storage.md
Service: storage
GitHub Login: @normesta
Microsoft Alias: normesta

@ciufudean
Thanks for your feedback! We will investigate and update as appropriate.


Typo in https://cn.vitest.dev/guide/comparisons.html#cypress

Describe the bug
The document in cn.vitest.dev is 像 Vitest 这样的基于节点的测试框架支持各种实现部分浏览器环境的第三方包, while it is Node-based runners like Vitest support various partially-implemented browser environments in vitest.dev, thus the correct translation should be 像 Vitest 这样的基于 Node.js 的测试框架支持各种实现部分浏览器环境的第三方包.
Btw, how should we contribute for the translated site (cn.vitest.dev) ?
Reproduction

System Info
(not related)

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Please, open issue in https://github.com/vitest-dev/docs-cn