The following packages will be built and installed:
    pcre[core]:x64-linux
Detecting compiler hash for triplet x64-linux...
Starting package 1/1: pcre:x64-linux
Building package pcre[core]:x64-linux...
Could not locate cached archive: /home/default/.cache/vcpkg/archives/19/194f6691fd9e9619a3ca4f5ac655ff7f84f4e195.zip
-- Using cached /home/default/code/vcpkg/downloads/pcre-8.44.zip
-- Cleaning sources at /home/default/code/vcpkg/buildtrees/pcre/src/pcre-8-2e1da0dae7.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/default/code/vcpkg/downloads/pcre-8.44.zip
-- Applying patch pcre-8.44_suppress_cmake_and_compiler_warnings-errors.patch
-- Using source at /home/default/code/vcpkg/buildtrees/pcre/src/pcre-8-2e1da0dae7.clean
-- Configuring x64-linux-rel
-- Building x64-linux-rel
-- Fixing pkgconfig
-- Fixing pkgconfig - release
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/lib/pkgconfig/libpcre.pc
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/lib/pkgconfig/libpcre16.pc
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/lib/pkgconfig/libpcre32.pc
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/lib/pkgconfig/libpcrecpp.pc
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/lib/pkgconfig/libpcreposix.pc
-- Fixing pkgconfig - debug
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/debug/lib/pkgconfig/libpcre.pc
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/debug/lib/pkgconfig/libpcre16.pc
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/debug/lib/pkgconfig/libpcre32.pc
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/debug/lib/pkgconfig/libpcrecpp.pc
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/debug/lib/pkgconfig/libpcreposix.pc
-- CHECK_LIB_pcre_DEBUG:CHECK_LIB_pcre_DEBUG-NOTFOUND
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:239 (message):
  Library "pcre" was not found! If it is a system library use the
  SYSTEM_LIBRARIES parameter for the vcpkg_fixup_pkgconfig call! Otherwise,
  correct the *.pc file
Call Stack (most recent call first):
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:348 (vcpkg_fixup_pkgconfig_check_files)
  ports/pcre/portfile.cmake:113 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:79 (include)

Error: Building package pcre:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: pcre:x64-linux
  Vcpkg version: 2020.06.15-unknownhash

Additionally, attach any relevant sections from the log files above.

Hi @illera88
Could you please remove openssl first and then rebuild this? Then send me the log. I cannot reproduce this on my local.

I did delete all the openssl installations I had. Here are all the logs which I checked but I couldn't find anything weird
pcre-logs.zip
Btw, I'm running this in a Debian WLS machine.
default@DESKTOP-Q4FDM2G:/mnt/c/Users/default.DESKTOP-Q4FDM2G$ ~/code/vcpkg/vcpkg list
capstone:x64-linux                                 4.0.2            Multi-architecture disassembly framework
capstone[arm64]:x64-linux                                           Capstone disassembly support for ARM64
capstone[arm]:x64-linux                                             Capstone disassembly support for ARM
capstone[x86]:x64-linux                                             Capstone disassembly support for x86
gettext:x64-linux                                  0.19-15          The GNU gettext utilities are a set of tools tha...
libffi:x64-linux                                   3.3-3            Portable, high level programming interface to va...
libiconv:x64-linux                                 1.16#5           GNU Unicode text conversion
z3:x64-linux                                       4.8.8            Z3 is a theorem prover from Microsoft Research.
zlib:x64-linux                                     1.2.11#7         A compression library
default@DESKTOP-Q4FDM2G:/mnt/c/Users/default.DESKTOP-Q4FDM2G$  ~/code/vcpkg/vcpkg install pcre
Your feedback is important to improve Vcpkg! Please take 3 minutes to complete our survey by running: vcpkg contact --survey
Computing installation plan...
The following packages will be built and installed:
    pcre[core]:x64-linux
Detecting compiler hash for triplet x64-linux...
Starting package 1/1: pcre:x64-linux
Building package pcre[core]:x64-linux...
Could not locate cached archive: /home/default/.cache/vcpkg/archives/19/194f6691fd9e9619a3ca4f5ac655ff7f84f4e195.zip
-- Using cached /home/default/code/vcpkg/downloads/pcre-8.44.zip
-- Cleaning sources at /home/default/code/vcpkg/buildtrees/pcre
/src/pcre-8-2e1da0dae7.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/default/code/vcpkg/downloads/pcre-8.44.zip
-- Applying patch pcre-8.44_suppress_cmake_and_compiler_warnings-errors.patch
-- Using source at /home/default/code/vcpkg/buildtrees/pcre/src/pcre-8-2e1da0dae7.clean
-- Configuring x64-linux-rel
-- Building x64-linux-rel
-- Fixing pkgconfig
-- Fixing pkgconfig - release
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/lib/pkgconfig/libpcre.pc
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/lib/pkgconfig/libpcre16.pc
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/lib/pkgconfig/libpcre32.pc
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/lib/pkgconfig/libpcrecpp.pc
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/lib/pkgconfig/libpcreposix.pc
-- Fixing pkgconfig - debug
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/debug/lib/pkgconfig/libpcre.pc
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/debug/lib/pkgconfig/libpcre16.pc
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/debug/lib/pkgconfig/libpcre32.pc
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/debug/lib/pkgconfig/libpcrecpp.pc
-- Checking file: /home/default/code/vcpkg/packages/pcre_x64-linux/debug/lib/pkgconfig/libpcreposix.pc
-- CHECK_LIB_pcre_DEBUG:CHECK_LIB_pcre_DEBUG-NOTFOUND
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:239 (message):
  Library "pcre" was not found! If it is a system library use the
  SYSTEM_LIBRARIES parameter for the vcpkg_fixup_pkgconfig call! Otherwise,
  correct the *.pc file
Call Stack (most recent call first):
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:348 (vcpkg_fixup_pkgconfig_check_files)
  ports/pcre/portfile.cmake:113 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:79 (include)

Error: Building package pcre:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: pcre:x64-linux
  Vcpkg version: 2020.06.15-unknownhash

Additionally, attach any relevant sections from the log files above.

@Neumann-A Can you please take a look?
Thanks.

@illera88 Please provide the library names in VCPKG_PATH/packages/pcre_x64-linux/lib and  VCPKG_PATH/packages/pcre_x64-linux/debug/lib.
Thanks.

It seems that the release version libraries have been built fine but not the debug right?
default@DESKTOP-Q4FDM2G:/mnt/c/Users/default.DESKTOP-Q4FDM2G/Downloads$ ls ~/code/vcpkg/packages/pcre_x64-linux/lib/
libpcre16.a  libpcre32.a  libpcre.a  libpcrecpp.a  libpcreposix.a  pkgconfig
default@DESKTOP-Q4FDM2G:/mnt/c/Users/default.DESKTOP-Q4FDM2G/Downloads$ ls ~/code/vcpkg/packages/pcre_x64-linux/debug/lib/
pkgconfig
default@DESKTOP-Q4FDM2G:/mnt/c/Users/default.DESKTOP-Q4FDM2G/Downloads$ ls ~/code/vcpkg/packages/pcre_x64-linux/debug/lib/pkgconfig/
libpcre16.pc  libpcre32.pc  libpcrecpp.pc  libpcre.pc  libpcreposix.pc

you probably have set(VCPKG_BUILD_TYPE release) set in the triplet? For me it works locally so some info here is missing

Indeed I had set(VCPKG_BUILD_TYPE release) in the triplet and I have verified that without that it compiles fine.
There is still a bug since it should not fail if you just want to build the release version.
Can you add set(VCPKG_BUILD_TYPE release)  to your x64-linux.cmake triplet file and verify?
Thanks

@JackBoosY this is a port bug. The pcre port should not install pc files for debug if the buildtype is set to release only.

@Neumann-A I think vcpkg_fixup_pkgconfig should actively handle this situation.

No it is a failure in the port installing files which are not required. As such the failure is correct.


Add structured output to websockets

Why are these changes needed?
Followup on https://github.com/microsoft/autogen/pull/1551

Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report
Attention: Patch coverage is 48.23151% with 161 lines in your changes are missing coverage. Please review.

Project coverage is 29.88%. Comparing base (146d49b) to head (2a65d03).

Files
Patch %
Lines

autogen/agentchat/conversable_agent.py
44.44%
50 Missing :warning:

autogen/io/messages.py
50.00%
31 Missing and 2 partials :warning:

autogen/io/websockets.py
45.00%
33 Missing :warning:

autogen/oai/client.py
6.66%
14 Missing :warning:

autogen/agentchat/groupchat.py
21.42%
11 Missing :warning:

autogen/io/base.py
69.69%
9 Missing and 1 partial :warning:

autogen/io/console.py
70.00%
5 Missing and 1 partial :warning:

autogen/agentchat/chat.py
20.00%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2030      +/-   ##
==========================================
- Coverage   37.53%   29.88%   -7.66%
==========================================
  Files          65       70       +5
  Lines        6913     7165     +252
  Branches     1521     1692     +171
==========================================
- Hits         2595     2141     -454
- Misses       4092     4781     +689
- Partials      226      243      +17

Flag
Coverage Δ

unittests
29.76% <48.23%> (-7.77%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hello! I really hope an someone more experienced than me picks this up and makes structured outputs work!

What is the current state of this PR? I might consider contributing

Closing this for inactivity. Let's continue to think about UI integration.


File.write sometimes writes incomplete bytes

rustc 1.43.0 (4fb7144ed 2020-04-20)
cargo 1.43.0 (3532cf738 2020-03-17)
rustup 1.21.1 (7832b2ebe 2019-12-20)
toolchain stable-x86_64-pc-windows-msvc
os Windows 10 Pro 1909 18363.778
async-std 1.5.0

Minimal repo to reproduce issue, run cargo test to reproduce the issue.
The problem does not happen when using std::fs and std::io.
It might be just some dumb error I made since I'm fairly new to Rust and async-std but when I write a sequence of u32 to a file after a few bytes, the bytes written are less than 4 bytes. When written to a memory using the Cursor, everything is fine.
Same issue under Windows Subsystem for Linux using the stable-x86_64-unknown-linux-gnu toolchain.

It seems like if I write N bytes (where N < 8) before the for loop, the first write in the loop will be trimmed to 8-N bytes.
The minimal repo writes 5 bytes (WORD0) and then 3 bytes of the first u32. All the subsequent iteration writes 4 bytes correctly.
If we change the first WORD0 to LETTERS (7 bytes), only 1 byte of the first u32 gets written.

you need to use write_all I believe, or check that the value returned from write is actually the length of the value you are trying to write
From the docs of write:

Writes some bytes into the byte stream.
Returns the number of bytes written from the start of the buffer.

From the docs of write_all:

Writes an entire buffer into the byte stream.
This method will continuously call write until there is no more data to be written or an error is returned. This method will not return until the entire buffer has been successfully written or such an error occurs.

@dignifiedquire Thank you to have taken the time to point me in the right direction. write_all did solve my issue.


Remove specialist documents

These are no longer being sent from the specialist publisher.
There will be another PR to Panopticon to remove the data.
https://trello.com/c/XW6wJpbJ/268-stop-publishing-specialist-documents-to-content-api

I know there's a PR to revert this, but it's also causing errors in Panopticon. Removing specialist-publisher from FORMATS_BY_DEFAULT_OWNING_APP means that this line is now nil, and so it tries to add nil to an array. This results in an error in Panopticon:
Rake aborted!
TypeError: no implicit conversion of nil into Array
/var/govuk/panopticon/app/models/rummageable_artefact.rb:5:in `+'
/var/govuk/panopticon/app/models/rummageable_artefact.rb:5:in `<class:RummageableArtefact>'
/var/govuk/panopticon/app/models/rummageable_artefact.rb:1:in `<top (required)>'
/var/govuk/panopticon/config/environment.rb:5:in `<top (required)>'
Tasks: TOP => db:migrate => environment

/cc @tommyp @elliotcm

@boffbowsh Any reason not to merge the reversion?

Nope, it's fine.


AKS now supports setting tags per nodepool

The 2020-01-27 AKS release notes state that "AKS now supports setting tags per nodepool. Which will propagate automatically to all nodes in the nodepool."  Is there any documentation on this feature?  I saw that AKS Engine has a field named CustomVMTags  but I tried through AKS and it didn't add the tags.
The AKS FAQ state "You might want to create or modify custom tags, for example, to assign a business unit or cost center. This can be achieved by creating Azure Policies with a scope on the managed resource group."  The documentation should reference the new feature for the nodes.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d501ff67-9208-8bcb-e8df-f09e9b16a802
Version Independent ID: e3fc3851-ddc4-d26c-251d-6ae53d714081
Content: Frequently asked questions for Azure Kubernetes Service (AKS) - Azure Kubernetes Service
Content Source: articles/aks/faq.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

thank you @bdschaap for the feedback
I have updated the article based on your feedback and the changes should be available soon.


Widen enumeration PermissionAttributeSimpleType

Enumeration PermissionAttributeSimpleType may be Author, Owner, Read, Write, Execute.
Please add values Create, Update. Delete, Use

Update is probably synonymous with Write but I guess it makes sense to have enumerations that more closely match system's permission models.


[NPM] E2E tests for windows

What does this PR do?
E2E running under windows EC2
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Branch starting from nowhere

Commit 53e4490 actually has parent eb4d8b8

This should be fixed in complete-rewrite. I'll be sure to drop your repo in and ensure the commits are in order.

Turns out this isn't fixed in v3.0. I don't have the time to fix it within this release but i'll shoot for a dot release with this fix.

I believe this is a symptom of this issue: https://answers.atlassian.com/questions/12255837/graph-traversal-in-topological-order.
The crux being that Stash says "topological" order but only satisfies that "children" must come before their parents. Therefore ancestor lines are intertwined, breaking the true "topological" ordering and therefore the graph in certain cases.

It appears that this is fixed in 1.1.  I am not experiencing it any more.

I'm affraid it's stil there

And even more, this release 1.1 generates such strange graphs

We are using gitflow workflow and have no more then 7-8 branches active at the same time.
More I scroll down, wider it gets.

Unfortunately this is a known issue with how stash traverses the commits of
a repository. Specifically the traversal only satisfies one of two criteria
needed for true topological ordering. I have spoken with stash devs and
this will require some low-level Java work. I'm not against tackling this
work I just want to think through it before hand.
On Wednesday, February 25, 2015, Mur466<EMAIL_ADDRESS>wrote:

I'm affraid it's stil there
[image: image]
https://cloud.githubusercontent.com/assets/7600701/6372350/978f5da0-bd14-11e4-8c0c-1c87b7b916f1.png
And even more, this release 1.1 generates such strange graphs
[image: image]
https://cloud.githubusercontent.com/assets/7600701/6372400/fd1ccd1a-bd14-11e4-89f0-ee5eef93aee2.png
We are using gitflow workflow and have no more then 7-8 branches active at
the same time.
More I scroll down, wider it gets.
—
Reply to this email directly or view it on GitHub
https://github.com/cha55son/stash-commit-graph-plugin/issues/6#issuecomment-75981111
.

--
Thanks,
Chason Choate

My pull request fixes this.
Sam

Or at least it seems to :)

Thanks for the PR.  I was under the assumption this was an issue with the
commit ordering from the server. I'll review when I get a chance.
On Thursday, April 9, 2015, sambott<EMAIL_ADDRESS>wrote:

Or at least it seems to :)
—
Reply to this email directly or view it on GitHub
https://github.com/cha55son/stash-commit-graph-plugin/issues/6#issuecomment-91303088
.

--
Thanks,
Chason Choate

I hadn't originally seen the bug report when I started looking at it, but
it was the same thing I was trying to solve. I originally thought it would
be the ordering, but because it's working in date order from recent to past
and only rendering the edges while inspecting a commit I figured it
wouldn't be an issue. As long a parent would always only be processed while
it's children were the most recently processed commit then it should be
able to draw the edge.
The traversing ordering does still seem to cause some issues though, but
mainly with rebased branches where the commit dates become muddled out of
order. They seem to get the merge rendered ok, but sometimes the branching
point gets drawn not quite connected to the correct parent commit (but
still the correct branch).
Anyway, have a look and test. It may be that it doesn't fix it, but it does
appear to for me.
Sam
On 9 Apr 2015 19:33, "Chason Choate"<EMAIL_ADDRESS>wrote:

Thanks for the PR. I was under the assumption this was an issue with the
commit ordering from the server. I'll review when I get a chance.
On Thursday, April 9, 2015, sambott<EMAIL_ADDRESS>wrote:

Or at least it seems to :)
—
Reply to this email directly or view it on GitHub
<
https://github.com/cha55son/stash-commit-graph-plugin/issues/6#issuecomment-91303088
.

--
Thanks,
Chason Choate
—
Reply to this email directly or view it on GitHub
https://github.com/cha55son/stash-commit-graph-plugin/issues/6#issuecomment-91321205
.

We're seeing this bug too. I see Sam's PR (which is #55) needs updating -- does it work?

Works for us, but it's for an older revision of the plug-in.
We just use the version the PR was forked from.
S

I've updated the pull request so it applies cleanly on master. See #60. @cha55son are you happy with this pull request now?

Thanks for the work on this. I'll look at it when I get a chance.

Thanks for the work guys. It does indeed seem to fix @Mur466 initial issue.

Thank you guys! Good job!


stack overflow when creating Values from a Tuple of the wrong length

If one tries to create a Values vector from a vector having the wrong length one gets a meaningful error message:
julia> Values{3,Int}([1,2])
ERROR: DimensionMismatch: expected input vector of length 3, got length 2

With tuples, however, one ends up with a stack overflow:
julia> Values{3,Int}((1,2))
ERROR: StackOverflowError:
Stacktrace:
      [1] macro expansion
        @ StaticVectors ~/.julia/packages/StaticVectors/m2aCI/src/Values.jl:16 [inlined]
      [2] macro expansion
        @ StaticVectors ./none:0 [inlined]
      [3] Values{3, Int64}(x::Tuple{Int64, Int64})
        @ StaticVectors ./none:0
--- the last 3 lines are repeated 79982 more times ---
 [239950] macro expansion
        @ StaticVectors ~/.julia/packages/StaticVectors/m2aCI/src/Values.jl:16 [inlined]
 [239951] macro expansion
        @ StaticVectors ./none:0 [inlined]

It's not evident at all from this output what the problem is. I think a more descriptive error message would help users.

Alright, let me know if you come up with a fix, this is not currently a high priority issue for me, since that's not supported behavior.

maybe you could change this
https://github.com/chakravala/StaticVectors.jl/blob/75cf4ef0f674f1af6b10ff42b3add2a4166f437b/src/Values.jl#L13-L18
to something along the lines of
@pure @generated function (::Type{Values{N,T}})(x::NTuple{N,Any}) where {T, N}
    return quote
        @_inline_meta
        Values{N,T}(x)
    end
end

#this is not pure
@generated function (::Type{Values{N,T}})(x::NTuple{M,Any}) where {T, N, M}
    return quote
        throw(DimensionMismatch("expected input tuple of length $N, got length $M"))
    end
end

The second method needs no @generated and probably fewer parameters:
(::Type{<:Values{N}})(x::NTuple{M}) where {N, M} =
    throw(DimensionMismatch("expected input tuple of length $N, got length $M"))

But what does the first (i.e., the original) function do? It looks like an infinite recursion.

Alright, well it seems that function is the result of simplifying some function that was previously in the source of StaticArrays.jl and after simplifying the function for the purposes of StaticVectors.jl it became a meaningless function. Perhaps the next step in simplifying that function is to remove it entirely, as it may not affect anything. I will do some testing and wait a bit before I commit, as this is not currently a critical issue.

Error message now reads correctly on the v1.0.4 commit @matthias314
julia> Values{3,Int}(1,2)
ERROR: DimensionMismatch: No precise constructor for Values{3, Int64} found. Val of input was 2.
Stacktrace:
 [1] Values{3, Int64}(x::Tuple{Tuple{Tuple{Tuple{Int64, Int64}}}})
   @ StaticVectors ~/.julia/dev/StaticVectors/src/convert.jl:5
 [2] TupleVector
   @ ~/.julia/dev/StaticVectors/src/convert.jl:8 [inlined]
 [3] Values{3, Int64}(x::Tuple{Tuple{Int64, Int64}})
   @ StaticVectors ~/.julia/dev/StaticVectors/src/convert.jl:8
 [4] TupleVector
   @ ~/.julia/dev/StaticVectors/src/convert.jl:8 [inlined]
 [5] Values{3, Int64}(::Int64, ::Vararg{Int64})
   @ StaticVectors ~/.julia/dev/StaticVectors/src/convert.jl:8
 [6] top-level scope
   @ REPL[2]:1

Release v1.0.4 fixes this issue and is now officially registered.


Document how client libraries work

Also link the various client libraries we already have

Yes we should definitely do this. Will help us build and maintain new client libraries and make it easier for contributions. Maybe @AliabbasMerchant can help. He has written the the entire python driver himself!!!

Yup. Seems good. :+1:

@AliabbasMerchant lets finish the python engine library then work on this? @Jayesh333 is this high priority right now?

Not required since we promote GraphQL now


Merge changes from KygekTeam's fork version of PocketMine School

This pull request will be merged when @Jean-TKG has approved.

I approve it so you can merge

I approve it so you can merge

You can mark this PR as Approved before I merge it.

Thanks for approving, @Jean-TKG!


Output Template Options remove special characters

Is your feature request related to a problem? Please describe.
I use the following command:
crunchy-cli --user-agent "Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0)" archive --skip-existing --skip-existing-method audio --skip-existing-method subtitle -a de-DE -a en-US -a ja-JP -s en-US -s de-DE --yes -t 32 -o "/mnt/Anime/{series_name}/{series_name} - S{season_number}E{episode_number}.mkv" $(cat links.txt)
The problem I run into is that some {series_name} have special characters in them like :,? which cannot be used in a windows file system. Since I run this on a ubuntu 20.04 it works but my windows system has trouble viewing that from my network drive.
Describe the solution you'd like
Would it be possible to have a flag --remove-special-characters that would just remove/skip those when referring to:
{title} → Title of the video
{series_name} → Name of the series
{season_name} → Name of the season
Additional context
For testing, I had problems with the following:
WorldEnd: What do you do at the end of the world? Are you busy? Will you save us
Trapped in a Dating Sim: The World of Otome Games is Tough for Mobs
Demon Slayer: Kimetsu no Yaiba

The --universal-output flag for this


Adding warning and line wrapping

Adding a warning and also incorporating feedback by @Shubham82 to wrap the lines as mentioned at https://github.com/kubernetes/website/pull/46140#discussion_r1588795257

Hi @sandeepkanabar, PR #46140 already opened for this fix.
Marking this as a duplicate since #46140 was opened first.
/triage duplicate

Hi @sandeepkanabar, PR #46140 already opened for this fix.
Marking this as a duplicate since #46140 was opened first. /triage duplicate

@Shubham82 - I understand. Can you please have a look at this post in slack from @sftim https://kubernetes.slack.com/archives/C1J0BPD2M/p1718732770418679

I understand. Can you please have a look at this post in slack from sftim https://kubernetes.slack.com/archives/C1J0BPD2M/p1718732770418679

@sandeepkanabar, I missed the Slack conversation.
Thanks!
/remove-triage duplicate

@sandeepkanabar I see the bot has added do-not-merge/invalid-commit-message as the commit message has (@)mentions within the commit message (Refer Blocked Keywords Guide). Would you be able to edit the commit message in order to move this PR forward?

Thanks Dipesh. Fixed it.

Fixed it.

@sandeepkanabar The problem still persists. It looks like you've updated the PR description, however the issue is with the commit message (click here) that needs to be addressed, as it contains blocked keywords like (@).
Problematic commit message (click here) that needs fixing is given below for reference:

Update hello-minikube.md
Incorporating feedback by @[Shubham82] to wrap the lines.

Fixed it.

@sandeepkanabar The problem still persists. It looks like you've updated the PR description, however the issue is with the commit message (click here) that needs to be addressed, as it contains blocked keywords like (@).
Problematic commit message (click here) that needs fixing is given below for reference:

Update hello-minikube.md
Incorporating feedback by @[Shubham82] to wrap the lines.

Ah, Dipesh. Thanks so much for the clarification. Yep, you are correct I merely modified the description instead of the commit message. Let me amend the commit message using cli since I don't see a way to do it directly via Github UI (or is there a way)?

Fixed it.

@sandeepkanabar The problem still persists. It looks like you've updated the PR description, however the issue is with the commit message (click here) that needs to be addressed, as it contains blocked keywords like (@).
Problematic commit message (click here) that needs fixing is given below for reference:

Update hello-minikube.md
Incorporating feedback by @[Shubham82] to wrap the lines.

Thanks so much for your patience. Fixed it. Can you please check now? Thanks.

@sandeepkanabar please also mention the original PR in this PR's description (the longer text box below the title) so that it is clear and obvious what's gone on.
It'd be nice to credit @cjcullen here.

@sandeepkanabar please also mention the original PR in this PR's description (the longer text box below the title) so that it is clear and obvious what's gone on.
It'd be nice to credit @cjcullen here.

Thanks for excellent suggestion @sftim. Totally agree. Updated the description to reflect this. Please have a look.

@sandeepkanabar, we can close this PR, as PR#4610 updated by @cjcullen and now have the same changes as this PR

Sure @Shubham82 if you think so

Thanks for this @sandeepkanabar, but I'm going to close this in favour of https://github.com/kubernetes/website/pull/46140
/close


Support Dynamic Route Partitioner

Source ~> <Route, Event> ~> RoutePartitioner ~> CepOperator

@wujinhu keep our discussion here.


Use 2023.2 builds

Unable to test on Windows due to error in Gradle configuration.
See https://github.com/JetBrains/gradle-intellij-plugin/issues/1441


Add method to clear all static gtfs data

#52  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on  Graphite

#52  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on  Graphite


new mobility values

hi, i follow the developments of your Lynx engine, although i'm on Linux and compiling and using .NET code is a bit difficult - but i manage .. lately i see several PRs concerning new mobility values and i'm curious : how are you tuning these parameters ? (Only) by self play ? Do you also use test positions / .epd suits ? I remember an engine like Rodent IV has personalities and their parameters can be adjusted by the user .. are you performing tuning like that ?

Hi @tissatussa,
Thanks for keep following Lynx development and raising your questions.
Right now I'm focused on implementing new evaluation features: adding configurable parameters such as mobility values, bonus for open/semi-open columns, etc. The idea is that this should provide immediate strength gain, apart from the potential future one it enables. I'm also emphasizing tests while doing that, as I've been doing during the whole Lynx development, to avoid regressions and facilitate refactoring later. For now I'm using sample values taken from Bitboard CHESS ENGINE in C.
I'm briefly testing these changes with gauntlets of a few games against other opponents, rather than with self-play, to validate the actual gain exists. You can see sample results in #210 or #213 description. I'm aware such amount of games is not significative, but I guess it's better than nothing.
Tuning these values will come later at some point, I'm not familiar with tuning strategies yet, so I'm happy to read more about that how to use/implement "test positions / .epd suits" approach.
I'm only aware of OpenBench framework, but haven't gotten into that world yet.
I'd still like to implement some features such as transposition table or endgame tablebases support before focusing on tuning per-se, but hopefully everything will come 😃

@eduherminio great! i will respond soon, in detail and with some other questions.
i'm on Linux .. can you say a few words about using .NET instead of eg. C(++) ? Was it a choice or you're just familiar with .NET ? I read Java is not the way to go when creating a (fast) engine.

..against other opponents, rather than with self-play..

nice! i always wondered if "tuning by self play" is a good idea anyhow .. once i read someone else stating such also.

..how to use/implement "test positions / .epd suits" approach..

i worked a bit with .epd test suites, and i wrote a nifty terminal script for it, first try however .. it only works properly in the great 'Konsole' terminal of KDE, using full colors and real time statistics by animation .. it's not on GitHub or so, just testing, but take a look at this post : https://github.com/algerbrex/blunder/issues/13 it has a screencast video of it - with music.
in short : those .epd test suites are FEN lists with a special format : also some (multi) 'bm' -Best Move(s)- and sometimes 'am' -Avoid Move(s)- are defined, both with a value when the engine 'finds' the bm or rejects the am .. this way obvious (?!) tactics / strategies can be defined and evaluated, using a (very fast) time control.
I have clue how to use test suites for tuning an engine though .. OpenBench i saw, but never worked with it.

..implement some features such -..- endgame tablebases support..

you might be interested in connection to an online TB .. once i discovered this feature when reviewing Weiss, see https://github.com/TerjeKir/weiss/ .. it has 'OnlineSyzygy' and even 'NoobBook, these are rather easy to implement according to the author of Weiss .. such online TB is not ideal, but it can be a start .. Weiss has UCI options for these. He only was struggling with the connection pinging / keep-alive / timing / something like that .. give it a try.

btw. the video is a bad example, i should make a new screencast of that terminal tool .. that video was typical for Blunder :-) When MPV is ON, many lines are displayed and change their MPV top-(5) constantly.

Regarding the language choice, it's just what I've been working lately with and I like it.
C# within .NET ecosystem, as a managed language, is I guess safer, by default, than C or C++; but that also makes it slower unless carefully used.
One of the fun parts this project is bringing me is investigating that advanced, low level usage that is indeed possible with this stack as well.
It's not that I expect my very first engine to ever compete with Stockfish anyway 😂

I definitely need to have a proper look at examples and those tests/links you mention and are pointing me at (thanks a lot!), but I'm afraid I'm short of time right now.
I'm however pleased to read that the approach is kinda similar to something I'm using in some of my existing tests (note allowedUCIMoveString and excludedUCIMoveString parameters in most tests under https://github.com/lynx-chess/Lynx/tree/main/tests/Lynx.Test/BestMove.
Of course tuning it's not a matter of pass/not pass, but... I'll figure it out!

Regarding online TB, I also had them in the TODO list to have it as a configurable option as well.
It might be useful at least for my instance of the bot in lichess, although I don't know if people would use it locally to do 'proper' test engines.

concerning an online opening book, the chess engine ShashChess (see https://github.com/amchess/ShashChess/ ) also can connect to it :

this Chinese (!) URL http://www.chessdb.cn/cdb.php is also used by Weiss, not sure though.

Following up regarding few topics before closing the issue

how are you tuning these parameters ? (Only) by self play ? Do you also use test positions / .epd suits ?

Eval parameters are tuned now using lynx-chess/texel-tuner, a fork of GediminasMasaitis/texel-tuner

you might be interested in connection to an online TB

Online TB search at root position has been added as an option (OnlineTablebaseInRootPositions in uci), and I'd say it works okish, although I haven't extensively tested it.
I've been unable to make it work during search though, due to too many requests to the online TB server

concerning an online opening book

Adding an opening book, online or not, is not something I'm planning to do. And given the amount of things I do have planned, don't count on it any time soon or at all 😅
It's easy to configure lichess bots to use one, so might eventually do that for Lynx_BOT, but no engine work is required for that


Monday - who's doing what?

Chris:

[ ] run some more tests
[ ] fix squid plot if time
[ ] create new table if time

Andy:

[ ] fix non-building age-1 index figure, and tweak Exec Summary one
[ ] add new survey maps (just waiting for final version from Julia)

Aaron:

[ ] Carry on with Exec Summary
[ ] Main text: model results

Kelli:

[ ] Data Section
[ ] Continue on sample size stuff (SRG response)

Remember to all re-load the .rds files #887.

I think I added text in the data section referring to Figure 11, so need to double check that it still makes sense. It might be part of the justification for it and that's why I thought to keep it.

Thanks. This should refer to Figure 11 from a previous assessment though, else doesn't really make sense:

Also, this should say 'biomass estimate' just to clarify. I haven't read through this section at all, so won't make any further changes yet (except these two if that's okay).

Other references to Figure 11 are good - just talk about the data.

Thanks. This should refer to Figure 11 from a previous assessment though, else doesn't really make sense:

Also, this should say 'biomass estimate' just to clarify:

I haven't read through this section at all, so won't make any further changes yet (except these two if that's okay).
All other refs to Figure 11 are just about data, which is still correct.

How about it just refers to the new Figure 11 location in that age-1 survey appendix?
And yes, changing 'data' to 'biomass estimate' is good.

I ref'ed the previous assessment for now, as not sure that sens model mentioned yet (and seems better to first reference previous results to justify the new base model). I'll read through all text at some point and see if it does make more sense to refer to the new Figure (Figure G.3).

Moved the incompleted ones to Wednesday.


batch tfms

🚀 Feature
Batch transforms can help us finding the biggest image on the batch so we can pad the others and maintain the aspect ratio. Some newer transforms like CutMix also need a batch transform formulation.
Batch tfms can help inside the dataloader collate_fn, so they can be distributed between multiple processes, as an high level overview, we would have something like this:

def custom_collate(build_batch, batch_tfms):
    def collate_fn(records: List[RecordType]):
        # batch_tfms enable us to apply batch dependent transforms
        # like cutmix or mixup, or even help with transforms to pad images
        # to a common size based on the biggest image on the batch
        # but do **not** help with GPU transforms
        # pytorch docs actually advices **against** returning GPU tensors
        # from the dataloader
        records = batch_tfms(records)
        # build batch is dependent to the model, you can image this as
        # the adapter between records and what the model expects as it input
        # it's in this phase where we convert everything into a tensor
        # and arrange the input format the model expects
        batch = build_batch(records)
        return batch

    return collate_fn

Each model would bring its own build_batch, since this is the function that serves as an adpater between the library standard records and what the models expect as input:
train_collate_fn = custom_collate(build_batch=efficient_det.build_train_batch)
train_dl = DataLoader(train_ds, collate_fn=train_collate_fn)

Each model can also pack it's own build_valid_batch and build_inference_batch.
These functions don't need to be explicitly given to the user, we can instead wrap then in a higher level API that would facilitate the usage, something like so:
train_dl = faster_rcnn.train_dataloader(train_ds) #collate_fn is done internally

To the last point, it would work like this behind the scenes:
def build_train_batch():
    # Specific to the model
    pass

def train_dataloader(dataset, batch_tfms=None, **kwargs):
    collate_fn = transform_collate(build_batch=build_train_batch, batch_tfms=batch_tfms)
    return DataLoader(dataset, collate_fn=collate_fn, **kwargs)

We can have something like this:
train_dl = DataLoader(train_ds, collate_fn=efficient_det.build_train_batch(batch_tfms))
valid_dl = DataLoader(train_ds, collate_fn=efficient_det.build_valid_batch(batch_tfms))

And we make standard that every model has the build_batch function

Another option would be to have a wrapping function:
train_dl = efficient_det.train_dataloader(DataLoader(train_ds), batch_tfms=batch_tfms)
valid_dl = efficient_det.valid_dataloader(DataLoader(valid_ds), batch_tfms=batch_tfms)

I'm looking into it.  I will get back to you ASAP.

I like the idea that the user will have to just write this:
train_dl = faster_rcnn.train_dataloader(train_ds) #collate_fn is done internally
And for example, the FasterRCNN class will take care of the rest, under the hood (IIUC):
class MantisFasterRCNN(MantisRCNN):
    ....

    def build_train_batch():
        # Specific to the model
        pass

    def train_dataloader(dataset, batch_tfms=None, **kwargs):
        collate_fn = transform_collate(build_batch=build_train_batch, batch_tfms=batch_tfms)
        return DataLoader(dataset, collate_fn=collate_fn, **kwargs)

The problem is the **kwargs, we should not use then, instead we have to repeat all arguments from the dataloader, and that is what bothers me

It's hidden, you will get used to it! haha!
On a serious note, I prefer that as opposed to having more elaborate code.


The CI Kind test sometimes fail

Describe the bug
The tests can fail sporadically, in the "Printing some debug information" step, with the following logs:
2019-12-06T18:33:12.7696270Z Unable to connect to the server: net/http: TLS handshake timeout

which means that kubectl is unable to connect to the K8s apiserver.
 What is unclear is why this is happening: we are able to retrieve the interface name, but running ethtool on the interface fails. Maybe it is a timing issue that could be resolved by adding a short sleep after creating the cluster with kind. The hack/kind-linux.sh script should also be updated to fail if one of the command returns an error.

Note that this seems to be happening ~5% of the time.

Not a timing issue. The grep pattern in hack-kind-linux.sh is not specific enough.


Moon Phase text not displaying

Hello, i have a little problem with the card not displaying the Moon Phase Text:

          - type: custom:ha-card-weather-conditions
            name: "Météo"
            language: fr
            animation: true
            camera: camera.weather
            weather:
              icons_model: climacell
              current:
                sun: sun.sun
                moon_phase: sensor.cc_test_moon_phase
                current_conditions: sensor.cc_test_weather_condition
                humidity: sensor.cc_test_humidity_percentage
                pressure: sensor.cc_test_barometric_pressure
                temperature: sensor.cc_test_temperature
                visibility: sensor.cc_test_visibility
                wind_bearing: sensor.cc_test_wind_direction
                wind_speed: sensor.cc_test_wind_speed
                precipitation: sensor.cc_test_precipitation
                forecast: true

I hope you can solve this.
Thanks again for your great work.

Hi, this issue is resolved in the last card released version.


SHAP values (discuss)

Hi Team!
I am just starting with SHAP package and have read both papers (for tree and general framework).
What I am interested in is predicting own impact on y with influence on one of the varibales x_i. The end goal is to use it further in optimal control problem where y=f(X) is just a part of the system where we can control and influence some of x_i's
Is shap values good in measuring such impact and using further in Optimal Control problems? Bascially looking for some non-linear analog of Betas in linear regression.
Im asking this because as far as I understood the paper, SHAP measures impact of x_i in case x_i is missing versus it is present in dataset, not really x_i is 0 versus x_i!=0 (or some particular value)
Note that Im NOT interested in absolute importance of variables or feature selection. Control variable x_i might have very low importance compared to other varibales, but be №1 priority in predicting dy/dx_i.
If not, what are good ways to do it? I saw partial dependence plots in sklearn might do somewhat useful for non-linear models.
Thanks in advance

I just found this interesting paper: https://arxiv.org/pdf/1705.10883.pdf. The problem of maximizing the tree output is expressed as a mixed integer programming and solved approximately.

This is a great discussion that I think could be very great topic at https://discuss.xgboost.ai/

@hcho3 thanks a lot, I'll try to read it today and try to find other papers.
@tqchen do I need to create separate thread there or you can move this one as a moderator?
I've also started same discussion in original SHAP repository with better explanation of our problem.
https://github.com/slundberg/shap/issues/249
Probably someone would be interested to follow it. Also I think this is not Xgboost only problem, but more general question about non-linear models, the main point would be to find a mathematically valid  way to compute online impact of a certain variables that we can controll (for example, SHAP values in Java/C++)


The robot only buys 1 token and then takes profit or stops loss, then automatically stops. I want it to run 24/7

Change numberofTokensToBuy to whatever you want.

Change numberofTokensToBuy to whatever you want.

Im change to 1000 but it buy only one and stop!

Did you change numberOfTokensToBuy or buyCount to 1000? You should only change the variables in the settings section.

Did you change numberOfTokensToBuy or buyCount to 1000? You should only change the variables in the settings section.

Im chang numberoftokentobuy. But it's buy 1 token then sell then stop bot


license field in pyproject.toml is ignored

I'm just noticing this now in the SciPy wheels: the license file specified in pyproject.toml is ignored by meson-python.
The relevant metadata is:
[project]
name = "SciPy"
license = {file = "LICENSE.txt"}

which should be correct I think, see https://peps.python.org/pep-0621/#license. From that text: The file key has a string value that is a relative file path to the file which contains the license for the project
Now what is not specified is what should be done with that. What PEP 621 further states is "The text key has a string value which is the license of the project whose meaning is that of the License field from the core metadata. These keys are mutually exclusive, so a tool MUST raise an error if the metadata specifies both keys." Which I think is insufficient, because we need both the license of a package, and the license of individual wheels, which are definitely not the same (wheels can vendor platform-specific components which are under different licenses for example).
In addition to the license field, we have the PyPI classifier:
classifiers = [
    "License :: OSI Approved :: BSD License",

Now how should all this work in practice? Here's what I think:

The PyPI classifier needs the license of the project itself (fine as is for SciPy).
The Meta > License field in the left sidebar on the PyPI page (see, e.g., https://test.pypi.org/project/scipy/) needs that same license. But how is it populated, from the classifier or from a text field in the PEP 621 license key?
The file specified with license = {file = "LICENSE.txt"} needs to be included in both sdist and wheels. It does not need to be installed onto the end user's system when the wheel is installed (which makes sense, because there is nowhere for that file to go, it's at the top level in the tree, next to scipy/ rather than under it).

The above means PEP 621 is wrong. There is an alternative that meets 1-3 above:

Use license = {text = "BSD 3-Clause"} in the metadata, don't specify file there.
Explicitly include the license file by something like py3.install_sources(['LICENSE.txt']) in the top-level meson.build file

The problem with this is that we don't want that file to be installed, but only included in the sdist and wheels. Currently I don't think there is a way to do this?

Note that for other license files in the source tree, we do have to use (and are using) py3.install_sources(['LICENSE.txt']) to include them. That's not much of an issue in practice, because they can be installed into site-packages/scipy just fine. The issue is mainly with the top-level file, because its install location would be site-packages/LICENSE.txt, which is clearly going to give problems.

Yup, ideally, the license text would be included in the metadata itself. This is a known issue, tracked in https://github.com/FFY00/python-pyproject-metadata/issues/3.
Is that solution suitable for you? Or do you really want us to include the license file?

Use license = {text = "BSD 3-Clause"} in the metadata, don't specify file there.

The text keyword is used to specify the license text, not name.

Yup, ideally, the license text would be included in the metadata itself.

Do you mean inside the METADATA file in the .dist-info directory? Right now that contains:
Metadata-Version: 2.1
Name: scipy
...
License: BSD
Download-URL: https://github.com/scipy/scipy/releases

If so, replacing that with pages and pages of license text does not seem healthy.
At the moment we have a separate LICENSE.txt file inside the .dist-info directory, next to WHEEL, METADATA, RECORD - that seems a lot nicer. There is also a specific field for this inside METADATA, namely:
License-File: LICENSE.txt

I had a look at this a little more. Different orgs have different guidance, but it's typically something like "It does not say specifically that the copy of the license you received along with the program is in the file COPYING or LICENSE, but that's where it's usually put." (quote from this guide).
The PEP 621 idea of putting it as a string in METADATA is highly unusual and imho deficient, because no one will think of looking there. I don't see a reason not to stay with the much more standard separate file.
It's also easy to do; I don't understand why https://github.com/FFY00/python-pyproject-metadata/issues/3 is blocked but it should not be relevant. The solution of copying the file given by license = {file = ...} into the .dist-info can be implemented in a few lines of code in mesonpy/__init__.py right next to:
            whl.writestr(f'{self.distinfo_dir}/METADATA', self._project.metadata)
            whl.writestr(f'{self.distinfo_dir}/WHEEL', self.wheel)

and is a significant improvement over silently dropping the license.

License-File is part of PEP 639 which is still in draft status, therefore I don't think the copying the license file over to the metadata directory solves the issue, but I do think that's a good idea nevertheless as it somehow mitigates it.

It's also easy to do; I don't understand why FFY00/python-pyproject-metadata#3 is blocked but it should not be relevant.

There's a custom format for multiline fields in the metadata file, which is not supported right now. License text are almost always multiline, so to be able to put the license text in the License key, we need to fix that first.

This should have been fixed in pyproject-metadata 0.6.0.


Use video in README

The gif in the README has some uggly compression artifacts and a limited color pallet.
Also:

GIFs are an average of 5-10 times larger than an efficiently encoded MP4 video.

~ https://trellis.co/blog/gifs-vs-animated-videos-which-should-you-use

https://github.com/Mintplex-Labs/anything-llm/assets/16845892/16701245-697f-41ec-b443-a6ab747cb2dc

resolved with a2a903741de1dc36adfce21659f729ab131e0c2b
Prefer the autoplay of GIFs, but moved to uncompressed GIF hosted on Github CDN


Get RTD build going

Hello @IAlibay! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file docs/source/conf.py:

Line 60:1: E265 block comment should start with '# '
Line 63:1: E265 block comment should start with '# '
Line 81:1: E266 too many leading '#' for block comment
Line 82:1: E265 block comment should start with '# '
Line 83:1: E265 block comment should start with '# '
Line 84:1: E265 block comment should start with '# '

@hannahbaumann I'm going to have to merge this to get things rolling.


Empty reply from server

Hi I'm getting Http\Client\Exception\RequestException: Empty reply from server when using the package. Thank you!

What service are you using?

I'm closing this issue due to the lack of details since almost one year.


add visualize_results_v2 in launch.py

add visualize_results_v2 in launch.py

@rohitgirdhar Ok, I've fixxed it.

@rohitgirdhar Thx, I've fixxed it.


Add method for single value inputs?

Hi,
there's an add method, but it seems to be for multi value inputs only.  Is there no method for adding a new value to a dropdown that only allows a single value to be selected?
If there isn't is there a plan to add this functionality, and is there a workaround for this?
Thanks!

Hi there, what exactly do you think the add() method does? add() and remove() are indeed only for multi-selection inputs, because they add and remove items from the selection, something which I only think makes sense when you can select more than one item. But if you want you want to add something to the list of items from which to choose, you can achieve that by just re-setting the items option.
Cheers!

awwww, got it.  Definitely misunderstood their purpose, thanks for the clarification!

No problem :)


[SPARK-LLAP-171] Fix a function name typo at SparkSessionState.getUserNameString

What changes were proposed in this pull request?
This bug is brought from commit: 5b5ea71ecbede891fe4ca2427cfb7ef6c65958c7
update the getUser method name for matching the provided function name of Spark Internal side.
The reason why it passed the test suite at that time.
(1) The reason is the mismatch between PR 5b5ea71ecbede891fe4ca2427cfb7ef6c65958c7  and test env setup. The PR do not synchronized on time.
Are you sure whether the test result reported in the PR is correct with this patch?
(2) This PR is already in branch branch-2.2-HDP-<IP_ADDRESS>, and test via provided security test script and deployed to the QE team testing environment. It already passed the test as well.
How was this patch tested?
unit test passed.
[root@ctr-e134-1499953498516-70977-01-000007 python]# ./spark-ranger-secure-test.py TableTestSuite
.....................
----------------------------------------------------------------------
Ran 21 tests in 3028.120s

OK

[root@ctr-e134-1499953498516-70977-01-000007 python]# ./spark-ranger-secure-test.py DbTestSuite
....
----------------------------------------------------------------------
Ran 4 tests in 611.721s

@dongjoon-hyun  please review this since we need to update this for internal spark-llap.

It seems that you forgot my advices. Please don't use HOTFIX. I suggested this should be handled by a normal way.

Also, you need to describe which commit introduced this bug.

@dongjoon-hyun  I updated the title and provide the description of PR. Thanks

Thanks.
Please provide the following and the test result.

Also, you need to describe which commit introduced this bug.

Updated. Thanks.

Could you add the following into the PR description to make it sure?

The reason why it passed the test suite at that time.
Are you sure whether the test result reported in the PR is correct with this patch?

@dongjoon-hyun  PR is updated.

LGTM. It's merged into branch-2.2. Please cherrypick this into master branch, too.

@dongjoon-hyun  thanks for your review.


Add shell argument to show rez-context when rez-env is chained with a command via --

rez-env will ussually show the context, but not when chained with another command via -- or -c.  It would be helpful if the context could be displayed in that scenario either when in verbose mode or with another switch keyword arg inline.
Motivation
running commands as a one liner suppresses the envrionment from displayed and where packages come from for debugging.

Oh I see actually we can do:
rez env package -c "rez-context && execute_thing"


Reflex not triggered when a Stimulus controller is also attached to a field

Bug Report
Describe the bug
Reflexes are not triggered when any other Stimulus controller is attached to an input field.
To Reproduce
Attaching a Stimulus controller to a text field prevent reflexes from running.
Expected behavior
The reflex should get triggered in both cases.
Screenshots or reproduction
See: https://github.com/cmer/stimulus-reflex-bug-repro
And video demo: https://share.cleanshot.com/7sz67SPmk8sP8PGtL6xJ
Versions
StimulusReflex

Gem: 3.5.0.rc3
Node package: 3.5.0.rc3

Browser

Browser: Any

Thanks for reporting this and for providing a repro @cmer. I was able to reproduce in the test-suite and I'm currently looking into the best way to fix it! Thanks!

This should be resolved via https://github.com/stimulusreflex/stimulus_reflex/pull/670

Thank you SO MUCH! Awesome!!! Can't wait to give it a shot. You have a typo, btw. Left a comment.

This should be resolved with the release of v3.5.0.rc4. I'm going to close this issue, but please feel free to re-open if you are still see something unexpected!


when we press a button on Tiva-C it should send APRS message immediately and reset timer

after we press a button next message should be sent either:

after 30 seconds
when we press this button again
can be useful for flight day as well as it's easier to test

Fixed by df9abd2


[HxCheckbox] Checkbox inside input-group is misaligned

Resolves #460.

@hakenr judging by this https://getbootstrap.com/docs/5.3/forms/checks-radios/#without-labels it feels right.


Removed some unused vars from src/graphics/device.js

As far as I can tell, there are no side effects from calling gl.getShaderPrecisionFormat().
Maybe someone knows?
Also this shaderCopy var appears unused.

Did you want to update this?

Sure, missed previous message.
On Mar 17, 2018 7:35 AM, "Will Eastcott"<EMAIL_ADDRESS>wrote:

Did you want to update this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/playcanvas/engine/pull/1123#issuecomment-373863159,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEyO7dPDu-8WlGwfN8Ba-Ugua_2kbQWGks5tfD44gaJpZM4SiGPw
.

@willeastcott think that fixes it, sorry for the delay.

Thanks! 👍


[Potential Bug] Unable to create a new session in CLI

Description
I was unable to create a new red teaming session on CLI. The error message is shown as follow:
moonshot > new_session rt_test_chinese123 -e "['openai-gpt4']"
Established connection to database (../moonshot-data/generated-outputs/databases/rt-test-chinese123.db)
[Session] Creating new session.
[Runner] Failed to load runner: [Runner] Unable to load runner because the runner file does not exist.
EXCEPTION of type 'RuntimeError' occurred with message: [Runner] Unable to load runner because the runner file does not exist.
To enable full traceback, run the following command: 'set debug true'
moonshot >

Workaround
For now, there is a workaround as the runner file rt_test_chinese123 is successfully created in the designated folder. I can load the session again using new_session rt_test_chinese123
Steps to Reproduce

Run moonshot in CLI version - python -m moonshot cli interactive
Create a new red teaming session - moonshot > new_session new_session123 -e "['openai_gpt4']"

Issue Fixed. Screenshot attached.

Issue has been resolved.


Add plug numbers to distinguish sensors of same type

Read and store sensor plug number.  If we have a hub with 2 sensors of the same type (e.g., 2 temperature sensors), display the plug number to help distinguish the sensors.  This is used in the control panel and the sensor/relay nodes.

plug is the Sensaurus term and I assume it is used over port to prevent ambiguity when hub communication occurs over a serial port.  I've warmed up to it.  I kind of like plug.


Error when "-P/--progress" rclone flag is set

When the "--progress" flag is set, it always shows "ERROR: JSONDecodeError".
The same error shows when testing on an empty folder with a new config.
Environment:

Arch Linux (kernel 5.4.74-1-lts)
Python 3.8.6
rclone 1.53.2
go  1.15.3
syncrclone 20200826.0.BETA

Thanks for trying out syncrclone. This is not really an issue per se. since syncrclone wraps rclone, it is (a) setting output formats with its own flags and (b) capturing all input and output.
So flags that syncrclone set may conflict with ones you set to modify the output.
FWIW, while nowhere near as pretty as rclone's, syncrclone always shows a running log of transfers including rclone's progress on large files.
When I'm back at my computer, I'll add some notes to the documentation/config comments saying you can't set flags like this or --log-level, etc. There are some other flags too that'll cause issues like checksums since syncrclone does that. I can't enumerate all of them but I'll try to make it more clear that you should only bet setting flags like fast-list, transfers, etc.
I am planning to minorly revamping how progress is shown for the pre-sync stuff so it's easier to parse but that's just to be faster to read.

OK, I see. Thank you for answering that.
I think you can also mention the "--drive-skip-gdocs" flag in the document as Google Document in my remote (Google Drive) was deleted by syncrclone. I fix it by adding this flag. I think rclone ignores them when pulling from remote to local, but the checking in syncrclone assume the gdoc was deleted locally.

Interesting. I'll add that note too. I've never used it with gdrive so I haven't experienced it. I guess it's causing a filter to be applied asymmetrically. It's a downside to relying on separate rclone calls for listing.
Just to make certain, when you say it deleted them, it moved it to the backup directory, right?
My priorities are no data loss even if some edge case messes with the sync. So if that happened, I really want to dive down and fix it.

Just to make certain, when you say it deleted them, it moved it to the backup directory, right?

Yes, it moved into the backup folder. A copy with a time tag is also created cause I set "newer_tag" in conflict_mode.

Great! Like I said, my chief concern is that nothing is lost.
Let me know if the doc issue comes up or there isn't a way around it.
Also, I have no idea how many people are actively using this code but I do extensively and have been thinking of no longer calling it beta. If there's any suggestion, I'm very open to hearing them.
My biggest goal is to speed up the remote copies for backup and delete. I may thread them which is easy enough but means the user has to set threads in two places! I think I'm using the optimal set of flags to make it as fast as possible but not 100% sure.


[Update Checkout] Fall back to revision if branch checkout fails.

In workflows featuring git worktrees, it is common for the same branch to be in use by multiple multiple checkouts.  For example, at the moment, the master branches of swift-format, swift-tensorflow-apis, and pythonkit (and the release branch of ninja) are indicated, in update-checkout-config.json, by both master and release/5.3.  If one
has a workflow featuring git worktrees, that means that when one runs update_checkout --scheme master in one's mainline directory and update_checkout --scheme release/5.3 in one's release53 directory, the latter will encounter failures for each of those four projects because the branch master (and release for ninja) will have already been checked out in the mainline directory's worktrees and so it cannot be checked out in the release53's directory's worktrees.  The error looks something like:
/path/to/swift-container/release53/swift-format failed
(ret=128): ['git', 'checkout', u'master']
fatal: 'master' is already checked out at
'/path/to/swift-container/mainline/swift-format'

/path/to/swift-container/release53/tensorflow-swift-apis failed
(ret=128): ['git', 'checkout', u'master']
fatal: 'master' is already checked out at
'/path/to/swift-container/mainline/tensorflow-swift-apis'

/path/to/swift-container/release53/pythonkit failed (ret=128):
['git', 'checkout', u'master']
fatal: 'master' is already checked out at
'/path/to/swift-container/mainline/pythonkit'

/path/to/swift-container/release53/ninja failed (ret=128):
['git', 'checkout', u'release']
fatal: 'release' is already checked out at
'/path/to/swift-container/mainline/ninja'

Here, that workflow is enabled.  If git checkout branch_name fails for one of the projects, update_checkout falls back to getting the SHA for the indicated branch via git rev-parse branch_name and then checking out the SHA directly.
If anything goes wrong with the fallback approach, the exception originally encountered when trying to checkout the branch is raised.

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 304f8fef96166872d5f3e03db41a05ec88e4804e

@swift-ci please test

@swift-ci please test windows

Build failed
Swift Test OS X Platform
Git Sha - 304f8fef96166872d5f3e03db41a05ec88e4804e

Build failed
Swift Test Linux Platform
Git Sha - 304f8fef96166872d5f3e03db41a05ec88e4804e

@swift-ci please clean test macos

Build failed
Swift Test OS X Platform
Git Sha - c0a704e20b8be5c8a1713fe83a5f7d5d96a11cda

@swift-ci please test

@swift-ci please test windows

Thanks so much for adding a test!

@swift-ci please test

@swift-ci please test

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 858063aac75b15fbdd2de1983d80da816dc394b1

@swift-ci please clean test

Build failed
Swift Test OS X Platform
Git Sha - 858063aac75b15fbdd2de1983d80da816dc394b1

@swift-ci please test

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 2ef8f1b90e52d14527dbc2157b15b787e837a981

@swift-ci please test macos

@swift-ci please test windows

Build failed
Swift Test OS X Platform
Git Sha - 2ef8f1b90e52d14527dbc2157b15b787e837a981

@swift-ci please test macos

Build failed
Swift Test OS X Platform
Git Sha - 2ef8f1b90e52d14527dbc2157b15b787e837a981

@swift-ci please clean test macos

Build failed
Swift Test OS X Platform
Git Sha - 2ef8f1b90e52d14527dbc2157b15b787e837a981

@swift-ci please test macos

@swift-ci please test windows

Build failed
Swift Test OS X Platform
Git Sha - 2ef8f1b90e52d14527dbc2157b15b787e837a981

@swift-ci please clean test macos

Build failed
Swift Test OS X Platform
Git Sha - 2ef8f1b90e52d14527dbc2157b15b787e837a981

@swift-ci please clean test macos

Build failed
Swift Test OS X Platform
Git Sha - 2ef8f1b90e52d14527dbc2157b15b787e837a981

@swift-ci please clean test macos


⚠ Jenkins Plugins Artifactory has degraded performance

In 440002f, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1196 ms

Resolved: Jenkins Plugins Artifactory performance has improved in b8f66b7 after 1 hour.


Adding GUI and basic functionality for game behaviour

The GUI was implemented using Pygame, as well as basi game behaviour such as events (right and left click), placing a bomb on grid, placing a flag, clicking a number and clicking an empty cell.
Pygame version is specified in requirements.txt
Basic usage LICENSE is integrated to project

Reviewed


[Azure.Monitor.Query] Use new Swagger files

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Monitor.Query


Question about completion

Given this:
myObservable
    .compose(RxLifecycle.bindUntilEvent(lifecycle, ActivityEvent.DESTROY))
    .subscribe();

I understand that RxLifecycle will terminate the stream (by calling onComplete) when destroy lifecycle event is detected. This prevents us from keeping stream open longer than desired.
 Will RxLifecycle also emit complete or will it keep the pipe open until destroy lifecycle event?

If myObservable emits onCompleted then the stream ends as well.
Internally, RxLifecycle uses the takeUntil() operator, so you can think of its behavior in the same way.

Ahh ok, it's the BehaviorSubscription never completes?

I don't understand your question. What is a BehaviorSubscription?

Sorry. I meant
private final BehaviorSubject<ActivityEvent> lifecycleSubject = BehaviorSubject.create(); inside RxAppCompatActivity. This Subject never receives onComplete though.

Yes, that's because it runs the lifecycle. It's what's feeding the events to takeUntil.
Basically - what you want to do is fine and the expected behavior of RxLifecycle. If you have deeper questions about how RxLifecycle works, I invite you to explore the source code.


⚠ RPC server - Figment Solana has degraded performance

In 7bde3a7, RPC server - Figment Solana ($FIGMENT_SOLANA_RPC_URL) experienced degraded performance:

HTTP code: 429
Response time: 564 ms

Resolved: RPC server - Figment Solana performance has improved in dd52fae.


TileratorUI: Provide regexes for area-targeted tile bans in Varnish

Adds new functionality to TileratorUI in which clicking on a tile while
holding the Shift key will add to the results window one or more regular
expresssions representing ranges of tile URLs to ban in Varnish. These can
then be used in place of the regular expressions representing a global
tile ban in a script such as https://phabricator.wikimedia.org/P7451.
Example:
^/osm-intl/6/18/24
^/osm-intl/7/36|37/48|49
^/osm-intl/8/7[2-5]/9[6-9]
^/osm-intl/9/14[4-9]|15[01]/19[2-9]
[...]
Regular expressions will be provided for the current tile and all children
up to (but not including) the value specified in beforeZ.  If no beforeZ
is specified, regexes will be provided for the current and the next two
zoom levels as a default.
This patch relies on two node modules: to-regex-range[1] and
Kartotherian's own quadtile-index.[2]  These could have been incorporated
in a couple of different ways: an internal route taking a tile index and
beforeZoom value could have been added and queried via an XmlHttpRequest;
or the modules could be converted to frontend scripts, exposed internally
through the server, and loaded directly in the admin interface page. This
implementation does the latter.  For this reason it depends on a related
change to kartotherian/server.
Bug: https://phabricator.wikimedia.org/T159977
[1] https://www.npmjs.com/package/to-regex-range
[2] https://www.npmjs.com/package/quadtile-index

Depends on: https://github.com/kartotherian/server/pull/13


specimen:source_material_type

This corresponds to the sample_type element in the GA4GH Biosample.
Add this using the CdaBiosampleFactory.

I am not sure we need to record specimen_type together with this. That field has text entries such as "aliquot" and "portion"


How to get edge field in strict?

Hi! I have 2 entities:
// Category holds the schema definition for the Category entity.
type Category struct {
	ent.Schema
}

// Fields of the Category.
func (Category) Fields() []ent.Field {
	return []ent.Field{
		field.String("id").NotEmpty(),
		field.String("title").NotEmpty(),
		field.Text("description"),
		field.Text("keywords"),
	}
}

// Edges of the Category.
func (Category) Edges() []ent.Edge {
	return []ent.Edge{
		edge.To("products", Product.Type).
			StorageKey(edge.Column("category_id")),
	}
}

// Product holds the schema definition for the Product entity.
type Product struct {
	ent.Schema
}

// Fields of the Product.
func (Product) Fields() []ent.Field {
	return []ent.Field{
		field.String("id").NotEmpty().Unique(),
		field.String("title").NotEmpty(),
		field.Strings("images"),
		field.Int("price"),
		field.Int("prev_price"),
		field.Text("short_text"),
		field.Text("full_text"),
		field.Text("instruction"),
		field.Text("description"),
		field.Text("keywords"),
	}
}

// Edges of the Product.
func (Product) Edges() []ent.Edge {
	return []ent.Edge{
		edge.From("categories", Category.Type).
			Ref("products").
			Unique(),
	}
}

They are connected as one-2-many with "category_id" field.
categories := client.Category.Query().WithProducts().AllX(ctx)
returns tree of entities, but without "category_id" field in Product structure.
I know that I can get it from parent struct in go code, but I can't do that in partial html/template.
I tried to add field.String("category_id"), to Product fields, but it break .AllX() method.
There are any possibility to get category_id field in Product structure?

Hi @Alexfilus,
Thanks for reaching out. What you're describing is easily supported since v0.7.0, wrote about it in ent's blog:
https://entgo.io/blog/2021/03/12/announcing-edge-field-support
Let me know if I can close this issue.

i've tried that.
For the first time insertion was broken: panic: ent: missing required field "category_id"
I had replaced SetCategoriesID -> SetCategoryID, insert worked fine, but now when I select data with AllX I get:
2021/04/08 10:49:56 driver.Query: query=SELECT DISTINCT `categories`.`id`, `categories`.`title`, `categories`.`description`, `categories`.`keywords` FROM `categories` args=[]
2021/04/08 10:49:56 driver.Query: query=SELECT DISTINCT `products`.`id`, `products`.`title`, `products`.`images`, `products`.`price`, `products`.`prev_price`, `products`.`short_text`, `products`.`full_text`, `products`.`instruction`, `products`.`description`, `products`.`keywords`, `products`.`category_id`, `products`.`category_id` FROM `products` WHERE `category_id` IN (?, ?) args=[cat1 cat2]
panic: foreign-key "category_id" is nil for node sustalife

goroutine 1 [running]:
tw_embeded/ent.(*CategoryQuery).AllX(...)

but I checked, data structure in DB table is correct.

Can you share the schema definition you've used with the edge fields configuration?
Recall from the example in the blog post, you should have:
// pet.go
// Fields of the Pet.
func (Pet) Fields() []ent.Field {
    return []ent.Field{
        field.String("name").
            NotEmpty(),
        field.Int("owner_id"), // <-- explictly add the field we want to contain the FK
    }
}

// Edges of the Pet.
func (Pet) Edges() []ent.Edge {
    return []ent.Edge{
        edge.To("owner", User.Type).
            Field("owner_id"). // <-- tell ent which field holds the reference to the owner
            Unique().
            Required(),
    }
}

category.txt
product.txt
GitHub not allow to attach .go files, so I upload it as .txt

thanks @Alexfilus , I think you've reversed the edge directions. Your schema should look like:
package schema

import (
	"entgo.io/ent"
	"entgo.io/ent/schema/edge"
	"entgo.io/ent/schema/field"
)

// Category holds the schema definition for the Category entity.
type Category struct {
	ent.Schema
}

// Fields of the Category.
func (Category) Fields() []ent.Field {
	return []ent.Field{
		field.String("id").NotEmpty(),
		field.String("title").NotEmpty(),
	}
}

// Edges of the Category.
func (Category) Edges() []ent.Edge {
	return []ent.Edge{
		edge.From("products", Product.Type).
			Ref("category"),
	}
}

// Product holds the schema definition for the Product entity.
type Product struct {
	ent.Schema
}

// Fields of the Product.
func (Product) Fields() []ent.Field {
	return []ent.Field{
		field.String("id").NotEmpty().Unique(),
		field.String("category_id").NotEmpty(),
		field.Text("short_text"),
	}
}

// Edges of the Product.
func (Product) Edges() []ent.Edge {
	return []ent.Edge{
		edge.To("category", Category.Type).
			Field("category_id").
			Required().
			Unique(),
	}
}

Test code:
package main

import (
	"context"
	"fmt"
	"issue/ent/enttest"
	"testing"

	_ "github.com/mattn/go-sqlite3"
)

func TestProduct(t *testing.T) {
	client := enttest.Open(t, "sqlite3", "file:ent?mode=memory&cache=shared&_fk=1")
	defer client.Close()
	ctx := context.Background()
	cat := client.Category.Create().
		SetID("ccc").
		SetTitle("the category").
		SaveX(ctx)
	client.Product.Create().
		SetID("ppp").
		SetCategory(cat).
		SetShortText("the product").
		SaveX(ctx)

	first, err := client.Product.Query().First(ctx)
	if err != nil {
		t.Fatalf("failed: %s", err)
	}
	fmt.Println("product id: ", first.ID, "category id: ", first.CategoryID)
	// OUTPUT: product id:  ppp category id:  ccc
}

Yes, I used wrong Ref. Now it works fine.Thank you!

Sure thing! Happy to help.
Please feel free to join our Slack channel in the Gophers Slack if you need anything else. Also, if you're interested to get ~monthly updates on our new releases and features, subscribe to our newsletter 🙏


Sort driver provider's name

Proposed changes
Put Exoscale at the correct place alphabetically in the TOC menu for drivers.
Related PR
#454 - #450 - #46
Please take a look
@mstanleyjones
Signed-off-by: Marc-Aurèle Brothier<EMAIL_ADDRESS>

Deploy preview processing.
Built with commit 6c62e441fe598f25e5a2f18b8ba235817a2f1f5f
https://app.netlify.com/sites/docker-docs/deploys/5821c9aac4d9cc0cd122ad52


Feature co2voc

Amazing, we actually DID co2/voc start-to-finish in this branch.  Should have merged it a few commits ago.

The build fail is because architecture isn't set correctly.  fml.  CICD is hard.


New context eduhelx sandbox

I figured we could just use the eduhelx context. Is there going to be something in eduhelx-sandbox that isn't in eduhelx? Don't want to make more work for us. Regardless, this seems ok.

I had the same opinion but confirmed with isma and eduhelx-sandbox needs to have it's own domain.

/check


Add maxlength attributes feature

Corresponds to https://caniuse.com/maxlength
This is a new feature. Here are some ideas for reviewing it:

Is this a recognizable web feature to web developers? (caniuse features are often made by request, so it's likely, but let's double check our work here.)
Is this a reasonable identifier for the feature?
Does this have a reasonable spec link?
Does this have a reasonable caniuse reference?
Are the mdn/browser-compat-data features plausible pieces of the feature as a whole?
Are any pieces missing?
Are any of the listed features later additions, part of a distinct sub feature, or otherwise excludable?

My 2 cents: I don't really consider maxlength a feature of the web platform myself. I consider input or textarea as features, and I see maxlength as a way to customize those features. So it's a property of those features.

I think we should just treat this as part of a "forms" feature, yet to be defined.

OK. I've put this into draft for now, until I have a place to put these things.

This is now part of a draft feature, so it'll probably get swept up eventually. Close this one.


Fix Issue 21601 - std.math : pow(float/double, -2) produces sometimes wrong result

Recently I compared several algorithms for calculating pow(b, e) with b being a floating point and e an integer. I checked the current implementation, the implementation suggested in PR #7297, the implementation suggested in issue 16200 and the original algorithm from stepanov quoted in issue 16200 with the intend to replace the current algorithm with the one mentioned in issue 16200.
First, I tested the algorithms for correctness, by comparing several random generated calls with the exact result calculated with the linux tool 'bc' and rounded appropriately. The results showed, that the current algorithm has a design flaw for exponent -2 and PR #7297 has further design flaws for exponent -3 and 3.

float
current
PR #7297
issue 16200
stepanov

wrong
4098 (1.64%)
9411 (3.76%)
0
0

difference (avg.)
466.22
858.19
0.00
0.00

difference (max.)
2,011,150
2,011,150
0
0

double
current
PR #7297
issue 16200
stepanov

wrong
1386 (1.37%)
3145 (3.15%)
194 (0.19%)
194 (0.19%)

difference (avg.)
28,323,033,265.48
51,480,639,103.68
0.00
0.00

difference (max.)
631,739,613,622,540
782,593,570,062,451
1
1

x87 real
current
PR #7297
issue 16200
stepanov

wrong
5155 (68.73%)
5133 (68.44%)
5169 (68.92%)
5169 (68.92%)

difference (avg.)
7.24
7.24
7.25
7.25

difference (max.)
238
238
238
238

250000 tests for float, 100000 tests for double and 7500 tests for real. Tests did not include results, that reached a fixpoint (NaN, +/-inf, 0.0); difference has been messured in the number of 'nextUp' calls that where needed to get from the smaller number to the larger.
IMHO, the result clearly rules PR #7297 out.
The issue with the current implementation can easily be fixed by removing the special treatment for -2 (this is, what this PR does - the suggested speed optimization is more difficult and left for an other PR).
I also replaced the switch statement by an if statement. With that, the hack around a bug in the switch statement (see PR #7294) is not needed anymore and I removed this too.
Furthermore I had to fix some unittests for quantize: They used == for comparing floating point numbers which luckily worked with the old version, but does not with the new one.

I noticed that this PR introduces another bug:
byte b = -128; pow(2.0,b); will give a wrong result now. Exponent int.min and long.min is still broken in the current implementation. For byte and short this has been incidentally fixed by the hack I removed.
I'm not sure how I want to continue here.

Sorry, ignore my last comment - byte.min etc all work well due to the cast to m which is the unsigned version.

@ibuclaw , @RazvanN7 Any comments here?

Furthermore I had to fix some unittests for quantize: They used == for comparing floating point numbers which luckily worked with the old version, but does not with the new one.

Doesn't this mean that this change might break user code?

Doesn't this mean that this change might break user code?

Yes, that is possible. But it will only affect code, that is bad designed (like the unittests I had to correct) - that is, code, that is based on an implied guarantee, that does not exist.
With floating point numbers, there is always the difficulty to decide how to cope with rounding errors. IEEE gives a clear standard, what the result of FPU instructions has to be. One can rely on this. And one knows ahead, that the error is the most minimal possible (taking rounding mode into account).
This guarantee cannot be given for code using the FPU: With every instruction used, a certain amount of error will occur. If you are lucky, they cancel out, if not they sum up. This means, that the only guarantee, such a function can give, is, that the result will be in a certain interval around the correct result.
For the pow-function this heavily depends on the size of the exponent. With the exponent -2 the guarantee is, that the result is +/-2 nextUp/nextDown from the correct result - there are two operations needed: Taking the reciprocal and squaring, and each of the two may move the result one step off.
With the proposed algorithm, the result is always in this interval, while the current algorithm breaks in some cases - see the issue, this PR addresses.

Yes, that is possible. But it will only affect code, that is bad designed (like the unittests I had to correct) - that is, code, that is based on an implied guarantee, that does not exist.

The fact that code is wrongly designed doesn't change the fact that users might be depending on that faulty behavior. There might be projects out there that used this as a feature and rely on this behavior. As such, we cannot simply silently change the semantics of the code (even if we are actually fixing it). We need to somehow issue a deprecation and instruct the user to use the new, improved, version. If the behavior is changed only for the -2 exponent  then we can simply issue a deprecation message that warns the user that the behavior is buggy and offer an alternative.

We need to somehow issue a deprecation and instruct the user to use the new, improved, version. If the behavior is changed only for the -2 exponent then we can simply issue a deprecation message that warns the user that the behavior is buggy and offer an alternative.

I disagree here. Think of the impact, this would have: Because -2 is a runtime parameter, we would have to add a deprecation message to the whole pow function (which is underneath used by ^^, as far as I know). That means, all users, that use pow or ^^ will get deprecation messages for about two years, although their code is completely correct (*). Only a tiny fraction of affected users will use the exponent -2 at all. And further, most of them will not care about the least significant bit of the result or, if they care, the will have reasonably code, that will not break with the change. So for the sake of avoiding a code breaking for about 0.0001% of all users we get on the nerves (or even hinder) the other 99,9999%. Seems to me doing more harm than good. (And yet I did not even touch the impact of asking the users to use newpow instead of pow or something like this.)
Because I think that neither not fixing, nor using a deprecation cycle is a good solution, maybe we could do something in between? I think of adding a release note, something like: "We noticed that the implementation of pow(f,-2) with f being a floating point value, was buggy for some values of f. Unfortunately the fix implies small changes for other values for f (with exponent -2) too: The least significant bits of the result might differ from the current implementation. (This is due to the peculiarities of floating point numbers and cannot be avoided with reasonable means.) To avoid problems, make sure, that your algorithms do not rely on the least significant bits of floating point calculations, for example by using isClose instead of ==." (Maybe just as an announcement in 2.96.0 and as a note in 2.97.0  (where the change happens) or so.)
What do you think? Would this be OK?
(*) As a side note: This resembles somewhat the deprecation message one gets when using transposed, warning about save being wrong. In my application I use transposed as an input range, so nothing to warn about. Still I get several hundreds of warnings, when compiling. (Of course I use -d meanwhile, but that means, that I'll miss other deprecation warnings...)

You make a good point. I think that adding a changelog entry for this should suffice.

 Buggy math algorithms could cost companies trillions of dollars (just ask @donc).


Create and implement a release communications strategy

[ ] Where will we post
[ ] What copy do we want to use
[ ] Some copy about the connection to and difference from polar/ scaling
[ ] Timelines
[ ] Way for people to provide feedback outside of GitHub issues

Way for people to provide feedback outside of GitHub issues

I think it could be worth trying to steer people towards GH discussions for the "user support" class of questions that are unlikely to be serious enough to get somebody to open up an issue. I like that they're searchable, and easier to manage than something like a discord server.

Haven't used GH Discussions and am open to trying! Def don't think a Discord makes sense at this point.
From a user friction point of view, the feedback funnel can look something like

Inviting folks to reply to news thread with suggestions, concerns, bugs, questions
GH Discussions
Open up a GitHub

Drafted a rough skeleton for the launch plan - would like your reaction @carlaKC @adamjonas

Completed in various docs (so far as I know)!


Google Cloud Storage Not Uploading Files on Local Development Server

From @migdall on June 6, 2018 5:45
When trying to test uploading of images on the local development server I am running into this issue.
So far this is not affecting the versions of the app deployed online, just the local environment.
This uploading images code was working fine and then now its not working.
I tried gcloud init and gcloud auth but the error persists.
INFO     2018-05-05 02:07:42,905 client.py:755] Refreshing access_token
INFO     2018-05-05 02:07:43,173 client.py:777] Failed to retrieve access token: {
  "error" : "invalid_client",
  "error_description" : "The OAuth client was not found."
}
ERROR    2018-05-05 02:07:43,173 api_server.py:373] Exception while handling app_identity_service.GetAccessToken()
Traceback (most recent call last):
  File "/Users/jesusnoland/google-cloud-sdk/platform/google_appengine/google/appengine/tools/devappserver2/api_server.py", line 341, in _handle_POST
    api_response = _execute_request(request).Encode()
  File "/Users/jesusnoland/google-cloud-sdk/platform/google_appengine/google/appengine/tools/devappserver2/api_server.py", line 162, in _execute_request
    make_request()
  File "/Users/jesusnoland/google-cloud-sdk/platform/google_appengine/google/appengine/tools/devappserver2/api_server.py", line 157, in make_request
    request_id)
  File "/Users/jesusnoland/google-cloud-sdk/platform/google_appengine/google/appengine/api/apiproxy_stub.py", line 151, in MakeSyncCall
    method(request, response)
  File "/Users/jesusnoland/google-cloud-sdk/platform/google_appengine/google/appengine/api/app_identity/app_identity_defaultcredentialsbased_stub.py", line 197, in _Dynamic_GetAccessToken
    token = credentials.get_access_token()
  File "/Users/jesusnoland/google-cloud-sdk/platform/google_appengine/lib/oauth2client_devserver/oauth2client/client.py", line 642, in get_access_token
    self.refresh(http)
  File "/Users/jesusnoland/google-cloud-sdk/platform/google_appengine/lib/oauth2client_devserver/oauth2client/client.py", line 559, in refresh
    self._refresh(http.request)
  File "/Users/jesusnoland/google-cloud-sdk/platform/google_appengine/lib/oauth2client_devserver/oauth2client/client.py", line 728, in _refresh
    self._do_refresh_request(http_request)
  File "/Users/jesusnoland/google-cloud-sdk/platform/google_appengine/lib/oauth2client_devserver/oauth2client/client.py", line 790, in _do_refresh_request
    raise AccessTokenRefreshError(error_msg)
AccessTokenRefreshError: invalid_client: The OAuth client was not found.

WARNING  2018-05-05 02:07:43,178 tasklets.py:468] suspended generator _make_token_async(rest_api.py:103) raised RuntimeError(AccessTokenRefreshError(u'invalid_client: The OAuth client was not found.',))
WARNING  2018-05-05 02:07:43,179 tasklets.py:468] suspended generator get_token_async(rest_api.py:214) raised RuntimeError(AccessTokenRefreshError(u'invalid_client: The OAuth client was not found.',))
WARNING  2018-05-05 02:07:43,179 tasklets.py:468] suspended generator urlfetch_async(rest_api.py:247) raised RuntimeError(AccessTokenRefreshError(u'invalid_client: The OAuth client was not found.',))
WARNING  2018-05-05 02:07:43,179 tasklets.py:468] suspended generator run(api_utils.py:164) raised RuntimeError(AccessTokenRefreshError(u'invalid_client: The OAuth client was not found.',))
WARNING  2018-05-05 02:07:43,180 tasklets.py:468] suspended generator do_request_async(rest_api.py:190) raised RuntimeError(AccessTokenRefreshError(u'invalid_client: The OAuth client was not found.',))
WARNING  2018-05-05 02:07:43,180 tasklets.py:468] suspended generator do_request_async(storage_api.py:128) raised RuntimeError(AccessTokenRefreshError(u'invalid_client: The OAuth client was not found.',))
CRITICAL 2018-05-05 02:07:43,180 models.py:761] RuntimeError image was not uploaded to google: (AccessTokenRefreshError(u'invalid_client: The OAuth client was not found.',))

import os
import cloudstorage as gcs

from google.appengine.api import app_identity

def get_default_file_bucket_name():
    """ Get the default Google Cloud Storage bucket for the mylitpen app """
    bucket_name = os.environ.get('testapp.appspot.com', app_identity.get_default_gcs_bucket_name())
    return bucket_name

def save_image_file(image, idea_id):
    """ Save the image to Google Cloud Storage """
    write_retry_params = gcs.RetryParams(backoff_factor=1.1)
    bucket_name = get_default_file_bucket_name()
    gcs_file = gcs.open('/%s/images/%s.jpg' % (bucket_name, idea_id),
                        'w',
                        content_type='image/jpeg',
                        retry_params=write_retry_params)
    gcs_file.write(image)
    gcs_file.close()
    return gcs_file

I am uploading the images to Google Cloud Storage.
Copied from original issue: google/google-api-python-client#528

I moved this here on behalf of @migdall because it got filed against the wrong repo (google-api-python-client).

@mcdonc, @migdall Unfortunately, this isn't the right repo either:  the issue is with the GAE-specific cloudstorage and google.appengine.api.app_identity packages, not with the google-cloud-storage library maintained here.
The GAE cloudstorage docs don't show a link for GAE support.  It looks as though StackOverflow's GAE topic might be the right place to look for help.
@theacodes Can you provide a better link for GAE support?


Consider more conservative usage of resources

On my Early 2015 12" MacBook that has following specs
Hardware Overview:

  Model Name:	MacBook
  Model Identifier:	MacBook8,1
  Processor Name:	Intel Core M
  Processor Speed:	1.3 GHz
  Number of Processors:	1
  Total Number of Cores:	2
  L2 Cache (per Core):	256 KB
  L3 Cache:	4 MB
  Memory:	8 GB
  Boot ROM Version:	MB81.0164.B18
  SMC Version (system):	2.25f87
  Serial Number (system):	C02PL0PKGCN2
  Hardware UUID:	E4CD394E-7E1F-580E-9B79-9D6FB6643498

Flow often times tends to take over all of the CPU cycles making OS pretty much unresponsive.
While I like that flow does it's best to type check quickly, I would much rather prefer if it took longer but still made it possible for me to use my computer while waiting it to finish.

P.S.: I usually see at least 6 flow processes running for a single project on this machine.

When I launch my IDE with Flow integration (Webstorm), I see in ´top´ a ´flow´ process balloon to 26G virtual memory (9.7G resident) before it grinds down so horribly in swap hell that I can't even kill it.
Now, this may in part be because the IDE shouldn't try to run Flow against my whole workspace with many repos checked out, or maybe I shouldn't organise my files that way, but it'd still be nice if Flow refused to allocate more memory than I even have.

I think this is a known issue. It seems that currently flow searches upward from the current directory for a .flowconfig file. If none is found, it will run flow on every .js file on your hard drive. It starts up multiple processes to support that. I always know when this happens because the fans in my MacBook Pro go crazy! I have to run killall flow to stop them.
This seems like a serious issue! Perhaps flow should require a .flowconfig file and just not run if none are found. This would be much better than the current situation.

This is still a serious issue and happens to me frequently. Ever time I edit a .js file in a project that is not using Flow, my editor which is configured to use Flow starts a Flow server. That sees there is no .flowconfig file in the directory. So it searches upward in the directory hierarchy looking for one. Eventually it reaches my home directory at which point it decides to run Flow on every .js on my hard drive.
The fix for this seems simple. If no .flowconfig file is found, I think it shouldn't run Flow on any .js files. Is there a reason this would be a bad fix?

any plans to improve this?


Download list doesn't expand to window size

Yes the episodes are capped at a certain height because I was having issues with it going off screen due to the row of buttons on the bottom bar. It also can't have infinity height since it's a lazycolumn and it throws an error if you do, I'm not entirely sure how to fix this, but I'll look around.

Fixed in Commit


Pass currently active suggestion to onBlur handler

I currently have a use case where the current active selection is very useful for my onBlur handler. Don't know if you maybe see some constraints that speak against merging this. Otherwise it would be nice to have it in the main repository :-)

Makes sense. Merged!


odd characters after prompt with iterm2 + powerlevel10k theme

i've setup powerline fonts with powerline10k theme.
i seem these chars on dirty git branches:
~/dev/my_folder  my_branch_name ⇡23 *1 

not sure if this is an issue with config, wrong font version, wrong theme or something else.
.zshrc:
ZSH_THEME="powerlevel10k/powerlevel10k"
POWERLEVEL9K_MODE="awesome-patched"
[[ ! -f ~/.p10k.zsh ]] || source ~/.p10k.zsh

i tried a few powerline fonts.. including MesloGS NF, and SourcePro for PowerLine but no luck

Issues with powerlevel10k go to the powerlevel10k repository. But you might find similar issues with iTerm2 and powerline in this repository if you search for them.


Fix: Loading multiple config files does not work

Monika Pull Request (PR)
What feature/issue does this PR add

Solve issue #983

How did you implement / how did you fix it

Fix reduce function to merge config

How to test

create config as described in the issue #983
run with described parameter npm start -- -c probes.yml notifications.yml
minika now will run normally

In your screenshot, it shows two lines:
Using config file:
Using config file:

Can you fix that too to show the path to the config files?

In your screenshot, it shows two lines:
Using config file:
Using config file:

Can you fix that too to show the path to the config files?

fixed