New sign ups Free email Newsletter notifications has a wrong from email address

Issue Summary
Explain roughly what’s wrong:
There are a lot of themes that use a non pop up subscribe option and those are the ones that are not working.
The new sign up notification from email address is supposed to be<EMAIL_ADDRESS>I have already set up all from email address as another address using the smtp config. That email is used for password reset and welcome emails.
To change the newsletter email, that was also sent from the wrong email address.
Even with that wrong, I clicked on the link to replace it and now the newsletter settings shows the right one, but the signups are still being sent from the wrong address.
What did you expect to happen?
Both the email to change the newsletter from address and the new signups for new free subscribers should receive the confirmation email using the SMTP setup email and/or the newsletter one. Not the default<EMAIL_ADDRESS>Steps to Reproduce
New install.
activate the theme Edition https://github.com/TryGhost/Edition/
go to Settings → Newsletter → Customise- change email- that one will be sent from the wrong email.
Approve that change (if you managed to get the email as I did).
Then confirm that has been changed.
Subscribe to the free emails using a custom embebed form from the theme, not the portal one.
The email is again sent from the wrong one.
Ghost Version
5.60.0
Node.js Version
v18.17.1
How did you install Ghost?
ubuntu 22 following guide and ghost cli
Database type
MySQL 8
Browser & OS version
No response
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

The same issue was recently reported on the Ghost forum by a different user and a different version: 5.59.4: https://forum.ghost.org/t/staff-new-sign-ups-email-notifications-has-a-wrong-from-email-address/40671

I can confirm I'm experiencing this issue as well. I just hadn't noticed because email programs don't always display the email address these days, so the issue may be more widespread than is being reported. The earliest message with the issue is August 14th. Unfortunately, I've emptied my trash so I don't have an earlier message where I can confirm the address is set as intended, but I believe it was something other than<EMAIL_ADDRESS>before. Sorry, I don't have the version handy where I ran into the issue-- I've also upgraded since then.
I'm not using Docker and am using Ubuntu 22, installed using the CLI.

I'm able to confirm this is a bug in Ghost. Here's how I isolated and confirmed the issue.
First, I'm aware that the mail structure in config.production.json are all passed directly through to a Nodemailer, so there are some additional options for that module which may not be documented in the Ghost documentation. Importantly, the Nodemailer SMTP transport has both a logger option and a debug option.  By enabling both of these, the full the emails generated by Ghost are to the logs where they can be viewed. This way, we can be certain the headers that Ghost includes, vs any modifications that might be made by the SMTP host. In my case, that was Mailgun.
First, I observed that headers are correct for the email that goes to the user to invite them to confirm. This are correct both when Ghost generates them and when I receive them in my inbox. Here's what that looks like in the logs.
Notice the MAIL FROM, the "From:" and the encoded subject line:
 INFO  [vjXc7QXc6k] User<EMAIL_ADDRESS>authenticated
 INFO  Sending message<EMAIL_ADDRESS>to<EMAIL_ADDRESS> DEBUG [vjXc7QXc6k] C: MAIL<EMAIL_ADDRESS> DEBUG [vjXc7QXc6k] S: 250 Sender address accepted
 DEBUG [vjXc7QXc6k] C: RCPT<EMAIL_ADDRESS> DEBUG [vjXc7QXc6k] S: 250 Recipient address accepted
 DEBUG [vjXc7QXc6k] C: DATA
 DEBUG [vjXc7QXc6k] S: 354 Continue
 DEBUG [vjXc7QXc6k] Content-Type: multipart/alternative;
 DEBUG [vjXc7QXc6k]  boundary="--_NmP-b9eed4cd15efd278-Part_1"
 DEBUG [vjXc7QXc6k] From: Mark Stosberg<EMAIL_ADDRESS> DEBUG [vjXc7QXc6k] To<EMAIL_ADDRESS> DEBUG [vjXc7QXc6k] Subject: =?UTF-8?Q?=F0=9F=99=8C_Complete_your_sign_up_to_Ma?=
 DEBUG [vjXc7QXc6k]  =?UTF-8?Q?rk_Stosberg!?=

Now here's the same output for the "New Member Signup" email that goes to admins. Now here, notice the MAIL FROM and "From:" here are different and wrong:

INFO  [5CI2GOGLzfM] User<EMAIL_ADDRESS>authenticated
INFO  Sending message<EMAIL_ADDRESS>to<EMAIL_ADDRESS>DEBUG [5CI2GOGLzfM] C: MAIL<EMAIL_ADDRESS>DEBUG [5CI2GOGLzfM] S: 250 Sender address accepted
DEBUG [5CI2GOGLzfM] C: RCPT<EMAIL_ADDRESS>DEBUG [5CI2GOGLzfM] S: 250 Recipient address accepted
DEBUG [5CI2GOGLzfM] C: DATA
DEBUG [5CI2GOGLzfM] S: 354 Continue
DEBUG [5CI2GOGLzfM] Content-Type: multipart/alternative;
DEBUG [5CI2GOGLzfM]  boundary="--NmP-b3cbe63cea627377-Part_1"
DEBUG [5CI2GOGLzfM] From: Mark Stosberg<EMAIL_ADDRESS>DEBUG [5CI2GOGLzfM] To<EMAIL_ADDRESS>DEBUG [5CI2GOGLzfM] Subject: =?UTF-8?Q?=F0=9F=A5=B3_Free_member_signup=3A_Mark?=
DEBUG [5CI2GOGLzfM]  =?UTF-8?Q?Bikes?=

If there were a problem with a library Ghost was using, I believe they would both be wrong. This finding seems to point to a bug in Ghost itself in how it calls Nodemailer, specifically for the New Member Signup emails.

I tracked this down in the source code to a change made about a year ago by @SimonBackx . It was made to fix a couple product issues which are private, but the title of the commit says "Fixed sending emails from email domain includes 'www subdomain':
https://github.com/TryGhost/Ghost/pull/15348
Even before, the email for these appeared to be<EMAIL_ADDRESS>Now the email address used is<EMAIL_ADDRESS>The use of ghost@ appears to be specific to emails send from Ghost to staff, but I can see how it could be confusing, as noreply@ is used in other situations and site owners are not expected to have configured the ghost@` address for anything.
To avoid confusion, I recommend further simplifying things by using noreply@ in this case as well.

I've submitted a PR with a proposal to use noreply@ in the places where ghost@ is being used. Along with the two other independent bug reporters, the use of ghost@ was confusing to me as well and appeared to be a bug.

Thank you @markstos for such test and information.
I can also confirm the issue.
To add something more, the issue I think is more related with the part after the @, it is using the wrong domain and not using the emails account specified anywhere on the admin or on the config file.
This is more clear when using a installation of ghost on a subdomain.
The ghost@ or no-reply@ is annoying but does not prevent the emails to reach destination.
The wrong domain after the @ will trigger a lot of spam protections as that subdomain is not expected to send emails and therefore breaking the system (not allowing people to confirm their subscriptions).

I found this report from 2021:
https://forum.ghost.org/t/emails-to-members-are-failing-user-emails-are-ok/21244
This has been here for a while it seems.

The email sending setup has now changed after https://github.com/TryGhost/Ghost/issues/12802#issuecomment-1917323529 - please give that a read and let us know if it's still broken 🙂

The email sending setup has now changed after #12802 (comment) - please give that a read and let us know if it's still broken 🙂

I will test it, I was aware of the changes.
In any case it should be marked as fixed, not as "not planned" but if you are happy with that I am too... thanks!

Looks like the issue is still there:
https://github.com/TryGhost/Ghost/issues/20381

The issue is still happening https://github.com/TryGhost/Ghost/issues/21423

Here are all the places were noreply is mentioned in the source code:
ghost/core/core/server/services/mail/GhostMailer.js
60:        // Default to<EMAIL_ADDRESS>61:        return getFromAddress(`noreply@${getDomain()}`, requestedReplyToAddress);

ghost/core/core/server/services/newsletters/NewslettersService.js
360:        let fromEmail = `noreply@${toDomain}`;

ghost/core/core/server/services/settings-helpers/SettingsHelpers.js
123:            // In the new flow, we make a difference between an empty setting (= use default) and a 'noreply' setting (=use noreply @ domain)
128:        supportAddress = supportAddress || 'noreply';
130:        // Any fromAddress without domain uses site domain, like default setting `noreply`
171:        return `noreply@${this.getDefaultEmailDomain()}`;

ghost/core/core/server/services/settings/SettingsBREADService.js
358:        if (!email || !hasChanged || email === 'noreply') {
389:        let fromEmail = `noreply@${toDomain}`;

apps/portal/src/utils/helpers.js
732:    const defaultAddress = defaultEmailAddress || `noreply@${getSiteDomain({site})}`;

We can see it's generally used as a default and can be overridden.
I wonder if the OP is running to this edge case in NewslettersService.js:
 async sendEmailVerificationMagicLink({id, email, property = 'sender_from'}) {
        const [,toDomain] = email.split('@');

        let fromEmail = `noreply@${toDomain}`;
        if (fromEmail === email) {
            fromEmail = `no-reply@${toDomain}`;
        }

        if (this.emailAddressService.service.useNewEmailAddresses) {
            // Gone with the old logic: always use the default email address here
            // We don't need to validate the FROM address, only the to address
            // Also because we are not only validating FROM addresses, but also possible REPLY-TO addresses, which we won't send FROM
            fromEmail = this.emailAddressService.service.defaultFromAddress;
        }

That seems to say that if the "From email" is the same as the "To" email, then noreply will be used-- a code comment there would be great to explain why.
But even, it seems that noreply can be overridden useNewEmailAddresses is true.
I'm not clear how useNewEmailAddresses gets set.

no I tested with my other emails which made from and to emails different and it still sends from noreply


Adds RID to connection qualifiedName for IGC and implements new PurgeDelete events

Qualified names for other assets should remain unchanged (no RID necessary to make them unique), but for Connection entities they now look like:
(data_connection)=LOCALFS_b1c497ce.8e4c0a48.och6f7sjm.3idrs1v.75e0po.vc663oulk78vej4u5fj4p

Fixes #765


switch create-react-app to vite

hey, I noticed that you use create-react-app to develop frontend, do you have interest switch that to vite, not only vite is lightly, but also it has a awesome plugin can compile you web into wasm vite-plugin-rsw

hi Sansx, sorry for the late reply. I actually read your issue a week ago or so but I had to think about it and investigate "vite". It's my first time hearing about it and I imagine it's easy to swap in for people who know about it. I think it's just a matter of:

deleting the contents of the frontend folder and generating one with vite's project generator, and,
having the vite project compile to the build directory that create-rust-app expects.

I'm not opposed to having an option to use vite but that means someone will have to support it as we move forward.

yes, I know you meaning, I'd like give support to this part, it likely I'll make a pr this month. :D
( I'm not very familiar with this project, which I might need help in some ways )

Awesome, sounds great @sansx, let me know if you have any questions. Feel free to suggest improvements!

Hi, I had switch to vite, and yarn fullstack runs well, by the way, the vite plugin about wasm, is used for develop wasm with frontend at same time, so it can't compile frontend to wasm, my bad, so I'm not sure wether you need this pr. I'm quite interested in this project, if you need further help, please let me know.(like make a graphql version, etc.) :D

hey @sansx thanks a lot for your work on this, I've taken a brief look over your changes on Friday but I didn't get a chance to try it out and take a deeper dive, I'll do this soon!
Also, with regards to things we can do, I have some items in docs/TODO.md that I think the project needs to move forward. Here are some things I would like to have soon:

Publish documentation on https://create-rust-app.dev (the docs/ folder has the beginnings of a docusaurus site)
I'm currently working on getting attachments working (so we can upload to local or s3 buckets easily)
Tests running for endpoints and frontend end-to-end
Make libraries instead of template-* folders which are copied to the created project

Anyway sorry, I've been busy lately and will try to organize something more formal soon

Just published the documentation website :-)

Ohh, that looks great.
I'm also busy this month, but the lucky thing is switch to vite is not difficult, so I had take some time to finish it, the good news is I had start getting familiar with this project, but busy tho.
And I think if we talk in this issue, it will be extremely long, and might confuse others user, so I closed this issue, and had look for another contact way but found none of it 😂
If you think it's ok, we can continue in this issue, or you can send me a email with a contact way, or we just use the email 😉

I'll send you an email!
Also, do you think it's not worth adding vite support now because it doesn't compile to wasm? Is there any other advantage to vite over standard create-react-app?

aaannnddd, we've landed vitejs integration in 6.0.0 :rocket: !
Right now it's only available in actix-web, but I'm hoping to add it for poem later


e2e: add upgrade testing

Upgrade testing will enable us to keep in check the
backward compatibility of earlier releases.
Updates: #696
Signed-off-by: Yug<EMAIL_ADDRESS>

@Yuggupta27 marked PR status as a draft. move it to ready for review once the PR is ready

Upgrade testing of RBD seems to work fine now. Whereas in CephFS upgrade-testing, pod stays pending after upgrade.
Currently rectifying the reason for this...

Upgrade testing of RBD seems to work fine now. Whereas in CephFS upgrade-testing, pod stays pending after upgrade due to a mount failure.
Currently rectifying the reason for this... Attacher logs https://termbin.com/wtt0

@Madhu-1 As per out discussion yesterday, I have refactored the code. PTAL

@nixpanic @humblec PTAL its good to get it before the release

nice work @Yuggupta27 ! :+1:

Added DNM till the request changes are done.

Added a check for PVC resize too.

CI failure please fix it

CI failure please fix it

Oh, it's failing on getting version info from build.env....

Please re-review @Madhu-1 @humblec

Thanks @Yuggupta27 !! :+1:

@MergifyIO rebase

@Yuggupta27 please force push the PR commitlint is not getting triggered

@Yuggupta27 please force push the PR commitlint is not getting triggered

Should I re-push all the commits again?

Yes please, force push also works

Yes please, force push also works

Will this work?


Option dropdownAlignRight auto doesn't work

Option dropdownAlignRight=auto doesn't work!

Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case via Plunker, jsFiddle, CodePen or JS Bin, and report back with your link, Bootstrap version, bootstrap-select version, and specific browser and OS details.

http://jsfiddle.net/q9s2rLbe/

Broken in v1.13.0. Working correctly in v1.12.4.

Released in v1.13.4!


Patch 1

Added Wipro and Infosys

@all-contributors please add @pv24 for adding wipro and infosys to the company database

@all-contributors please add @pv24 for documentation


feat: add key concepts of module 1

On our curriculum page, we will summarize key concepts of each module. I think bullet points makes the most sense, but if there is a different way you would like to present the information, please share your ideas.
Add a heading element and a list of key concepts in module 1.

Can I work on this one pls.

@eram23 that would be great, thanks!

Im thinking of doing something like this:
Scrimba Bootcamp Curriculum
Module 1 - Web Dev Basics

Learn basics of HTML & CSS
Create layouts & style them
Build a Googe.com clone
Build your first Solo Project

@eram23 that's a good outline! Just wanted to point out that "Web Dev Basics" is Module 2. Let me know if you still want to work on this issue, or switch to #24 . Either way, you might be interested in referencing notes from Shant's CPR series, though you don't have to. 🙂

Sure! I don't mind doing  one and two if thats ok!


[CP Staging] Revert "fix: add receipt name when track expense"

Reverts Expensify/App#45752 to fix https://github.com/Expensify/App/issues/46718

skipping checklists for straight revert

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.16-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.16-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Hash characters in data URL - support will be removed from Chrome soon

When loading the site on a new Chrome you see:
[Deprecation] Using unescaped '#' characters in a data URI body is deprecated and will be removed in M68, around July 2018. Please use '%23' instead. See https://www.chromestatus.com/features/5656049583390720 for more details.

We need to find where that's coming from. There's a lot of data: URIs used in GoldenLayout, maybe there?

What does this mean for older urls. Will they keep working? 🤔

I don't think this refers to our URLs. I think the data URLs (of the form data:base64thing) are used in some of our third party dependencies. I did a git grep but couldn't find them.

Webpack does inline some stuff. I need to upgrade webpack anyway.
I can dig in when I have time to do that.
I’m just under the hammer for the next two weeks until feature freeze :(
On Tue, 31 Jul 2018 at 10:58 am Matt Godbolt<EMAIL_ADDRESS>wrote:

I don't think this refers to our URLs. I think the data URLs (of the form
data:base64thing) are used in some of our third party dependencies. I did
a git grep but couldn't find them.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mattgodbolt/compiler-explorer/issues/1001#issuecomment-409059186,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASId0_NOhIv8h3dZsGWsQha0Z8t25_2ks5uL6uggaJpZM4VQTfj
.

This doesn't appear to happen any more, either as we've changed things around, or else Chrome decided to keep this misfeature after all...


add support for "weekdays-short"

The documentation indicates that the parameter "weekdays-short" is supported, but in code it was not implemented. The following lines allow the use of this parameter.

Yep, the Materialize code sure does look like it supports that parameter.
Merged.


Localization

The localization will need to be implemented. Here is the Laravel documentation: https://laravel.com/docs/5.2/localization
Language files can be found in resources/lang. Create the new language string to the English directory and we'll figure out translations later.

The language files have been moved to the directory fw/lang. As before we're still sticking to using the English (en) directory for now and localization will be figured out latter, or as people volunteer to handle translations.
Also, bare in mind that the functions trans and transChoice have been removed. Use the language facade instead, Lang::trans() and Lang::transChoice().


Fix CMake for eigenpy 2.7.10

Does the submodule update requires an update in eigenpy?
Or is there any reason to do so?

the submodule update is not required here.
The main issue is that we now have eigenpyConfig.cmake correctly calling FINDPYTHON() /FIND_NUMPY() automatically for us, but therefore if we try to call it manually after or before eigenpy, it will raise an error.

@wxmerkt : can we turn off ROS CI Format job ? we decided not to reformat everything in crocoddyl until we stabilze  the API for v2

Sure, happy to turn it off for now

CI is now green. Note that I had to turn the Bionic/18.04 builds with Python2 off as it could not find Python without explicitly specifying PYTHON_EXECUTABLE.

@nim65s do you know how to tackle this? Or are we planning to do not support 18.04/Python 2 anymore?

Don't know. Let's try with just a submodule update

Looks like an issue in example-robot-data

Thanks guys @nim65s and @wxmerkt :)


Review import/export of workflows in v2.7.0

https://github.com/fractal-analytics-platform/fractal-server/issues/1829 should offer a way to move from the task source to the taskgroup attributes (plus a single task-specific attribute, e.g. its name).
I guess we should maintain

[ ] An import-workflow endpoint which still looks for "legacy" tasks via their source
[ ] An up-to-date import-workflow endpoint which uses whatever we define in #1829
[ ] An up-to-date export-workflow endpoint which uses whatever we define in #1829

Now mostly defined in #1831 and #1829.

Now mostly defined in #1831 and #1829.

In view of major updates defined in these issues (and especially in https://github.com/fractal-analytics-platform/fractal-server/issues/1831#issuecomment-2393700802), the preliminary plan is the following:

There exist a single way of exporting a workflow from now on (namely by its "new" identity).
There exist two ways of importing a task which is part of a previously-exported task: by source, or by "new" identity - TBD.
A workflow to be imported may include a mix of "old" and "new task identities, and the if/else check is done at a single-task level
When a task source is provided, it is used as the single true information: either a task with that exact source exists or we fail.
When a task source is not provided, then we enter the new-identity-based search for one matching task.

The precise meaning of the new identity matching is based on https://github.com/fractal-analytics-platform/fractal-server/issues/1831#issuecomment-2393700802 and on https://github.com/fractal-analytics-platform/fractal-server/issues/1859. I'll later propose a precise priority-based definition in this issue - since we initially ignored the fact that we also may have to disambiguate similar tasks (ref https://github.com/fractal-analytics-platform/fractal-web/issues/582).

Database tasks

For any instance created afresh with v2.7, tasks have no source.
For any instance at a version lower than v2.7, all tasks have (unique) sources
For an instance upgraded from <2.7 to >=2.7, there will be a mix of tasks with source (the ones created before the migration) and without source (the newly-created ones).

Exported workflows

All workflows exported to JSON with a version <2.7 have tasks identified by their full source.
All workflows exported to JSON with a version >=2.7 have tasks identified by their "new" identity, which is a broader definition.
The previous point holds independently on whether the tasks were created before or after the version upgrade.
The new identity is made of a task-group identity (required pkg_name + optional version field) and a individual-task identity (name).

Imported workflows

The JSON of a workflow to be imported into a v2.7 instance may include a mix of tasks defined by source and tasks defined by their new identity.
Each task can be identified in a single way: it either defines a source or a pkg_name+version+name.
Version is an optional field - see below.

Examples of tasks to be imported
Invalid examples
The following task specification is invalid, since it has both old and new identity information:
{
 "source": "fractal-tasks-core-1.2.3-cellpose",
 "pkg_name": "fractal-tasks-core",
 "version": "1.2.3",
 "name": "cellpose_segmentation"
}

The following task specification is invalid, since it lacks the task name:
{
 "pkg_name": "fractal-tasks-core",
 "version": "1.2.3"
}

Valid examples
Source-based identity
The following spec is OK
{
 "source": "fractal-tasks-core-1.2.3-cellpose"
}

and the backend will look for a task with this exact source (which, for the record, can only have been created before the v2.7 update).
New identity, with version
The following task is OK:
{
 "pkg_name": "fractal-tasks-core",
 "version": "1.2.3",
 "name": "cellpose_segmentation"
}

and the backend will look for a task which matches these three properties exactly.
There may be more than one such task - see "disambiguation" section below.
New identity, without version
The following task is OK:
{
 "pkg_name": "fractal-tasks-core",
 "name": "cellpose_segmentation"
}

and the backend will look for a task which matches these three properties exactly (more on this below).
There may be more than one such task - see "disambiguation" section below.
Disambiguation for non-unique tasks
When given a source, there may be either zero or one task matching.
When given pkg_name+version+name, or pkg_name+name, there may be several matching tasks. Here is a description of how to proceed:
More than one result, with a given version set
A query for tasks with pkg_name+version+name may return up to 1+N results, where N is the number of user groups such that: (1) I am part of that group, and (2) the group owns one such task.
In order to pick a specific task, the priority logic is as follows:

A task that belong to the current user (task_group.user_id = my_user_id) has highest priority.
A task that belongs to the All user group follows.
Other results are listed based on the timestamp of the user/usergroup association (older -> higher priority).

ALTERNATIVE OPTION: we could also switch 1 and 2, and give "All" the highest priority.
More than one result, with no version set
When exporting a task that was collected automatically by fractal-server, it will always look like
{
 "pkg_name": "fractal-tasks-core",
 "version": "1.2.3",
 "name": "cellpose_segmentation"
}

but what should the backend do when requested to import a task like
{
 "pkg_name": "fractal-tasks-core",
 "name": "cellpose_segmentation"
}

?
Some options:

We keep looking for an exact match and consider version=None, which means that we won't find any matching task in this case.
We consider version=None as a dummy filter, and rather return the latest available version of the task. This means that by editing the JSON of an exported workflow we can make its import less deterministic but give it more chances of success on different instances (or on instances where some old tasks were later deleted or deactivated).

Side comment: non-accessible tasks
The import-workflow operation works on a per-user basis. It can only succeed if all tasks that are identified are also accessible to the user. If not, it should fail (rather than providing a partially-non-accessible workflow).
Side comment: non-active tasks
The import-workflow operation does not include a check of whether imported tasks are active. If I am importing an old workflow where I pinned all versions, and in the meanwhile those versions were deactivated on the fractal-server instance, then the imported workflow will appear with multiple warnings and I won't be able to run it as a job.
ALTERNATIVE OPTION: the import fails when no active matching tasks are found.
Side comment: task name
Up to now, we discussed task-group identity in multiple v2.7 threads. In order to specify a single task, we also need something more granular, and the obvious candidate here is the task name.
This introduces some additional requirements for the backend:

A task name should be immutable
Upon task-group creation, we must verify that no two tasks with the same name exist in the same group.

Deprecation of backwards-compatibility
Moving forward, there will be a point in the future where we should discontinue the "import-task-based-on-source" feature. This will invalidate all exported-workflow JSON files created with versions <2.7, thus clearly being a breaking change.

ALTERNATIVE OPTION: we could also switch 1 and 2, and give "All" the highest priority.

I think it's useful that "my personal task" has highest priority. It allows a user to recollect a task for themselves that would have issues in the ALL collection, thus working around some issues without needing admin support.

We consider version=None as a dummy filter, and rather return the latest available version of the task. This means that by editing the JSON of an exported workflow we can make its import less deterministic but give it more chances of success on different instances (or on instances where some old tasks were later deleted or deactivated).

I'd be in favor of that. If one imports a workflow with tasks that don't have their version specified, one gets the newest available versions of those tasks. That may or may not work (depending on whether parameters have changed). But given that we never export workflows that way, I think it's a good trade-off

The import-workflow operation does not include a check of whether imported tasks are active. If I am importing an old workflow where I pinned all versions, and in the meanwhile those versions were deactivated on the fractal-server instance, then the imported workflow will appear with multiple warnings and I won't be able to run it as a job.

As long as we can make those warnings visible to the user (e.g. also show feedback during import that some tasks were deactivated, they may need to update to a newer version), I think that's fine

Up to now, we discussed task-group identity in multiple v2.7 threads. In order to specify a single task, we also need something more granular, and the obvious candidate here is the task name.
This introduces some additional requirements for the backend:
A task name should be immutable
Upon task-group creation, we must verify that no two tasks with the same name exist in the same group.

Sounds good to me

Moving forward, there will be a point in the future where we should discontinue the "import-task-based-on-source" feature. This will invalidate all exported-workflow JSON files created with versions <2.7, thus clearly being a breaking change.

I'd be quite hesitant of dropping this, even once we don't have any of those tasks active anymore on the server. This breaks importing old workflows, so I'd much prefer to keep this active

Upon task-group creation, we must verify that no two tasks with the same name exist in the same group.

Unique constraint on TaskV2 taskgroup_id and name columns.


feat(Authenticator): add client agnostic auth function

:tada: This PR is included in version 1.7.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


455 detected as USB2.1

| Camera Model                       |  455  |
| Firmware Version                   | current  |
| Operating System & Version |   Win 10  |                                  |
| Platform                                 | PC |
| SDK Version                            |  <IP_ADDRESS>86 }                          |
I know this problem has been mentioned before, but unfortunately none of the fixes I came across in those threads have helpe me so far. It’s possible I may have missed other relevant threads.
After spending some time away from the set-up for my 455d, I came back to it to discover on boot up that it was now being detected as a USB 2.1 device in the RealSense viewer. The only change I made was that before I booted up the computer I swapped out the old powered USB hub I’d been using for a new Newnex FireNex uHub (a faster device I was hoping would address latency). I did shut everything down again and use the old hub but the problem persists. My set up uses a 20m active Newnex cable and a FireNex uHub. Any sense how I can fix this so it’s finally recognized as a USB3 device again?
Is there a preferred plugin order if I unplug and replug in all the components? Is it better to do while the computer is shut down or running?

Hi @nataliesettles  Please first try unplugging the micro-sized end of the USB cable from the base of the camera, turning the connector around the other way and re-inserting it (USB-C cables are two-way insertion at the micro-sized end).
If flipping the connector direction does not make a difference, next try unplugging the full-sized end of the USB cable from the hub, then re-inserting it with a firm quick motion and not a slow insertion.  Slow insertion can cause a RealSense camera to be mis-detected as a USB 2.1 connection.

Hi @MartyG-RealSense - Thanks for your reply. Unfortunately neither of those approaches fixed the problem. I have noticed that my antivirus software is blocking an Intel driver called iqvw64e.sys — could this be related to the problem?

Apparently iqvw64e is a software component of the Intel Network Adapter Diagnostic Driver, so it seems unlikely that a blocking of it is the cause of your USB 2.1 problem.
  If either a hub or a cable are USB2 instead of USB3 then a RealSense camera will be detected as 2.1 even if the cable or hub is attached to a USB3 port on the computer.

As you suspected, it was one of the cables. Thanks for your help!

You are very welcome.  I'm pleased to hear that you confirmed what the problem was.  Thanks very much for the update!


Automatic addition of the header, if not present

Header should be configured on first submit

On second thought it doesn't make sense.


[Feature Request]: Add telemetry deployment to modules where it is missing

Description
I noticed there are several modules that currently lack the telemetry deployment.
To remediate this, we should go through all deploy.bicep files, add the missing deployments and corresponding control parameters (e.g. in parents)

I've checked that we currently don't have any modules without telemetry. However I discovered that there are a few module tests are not using the enableDefaultTelemetry parameter, which leads to usage of the default value.  I will fix this.


Usd Primvar Reader node missing support for fallback

The Usd Primvar Reader has an input fallback, however, in the Node Graph, there's no reference to the fallback parameter, so it doesn't work.  For example:
  <nodegraph name="IMP_UsdPrimvarReader_integer" nodedef="ND_UsdPrimvarReader_integer">
    <geompropvalue name="primvar" type="integer">
      <input name="geomprop" type="string" interfacename="varname" />
    </geompropvalue>
    <output name="out" type="integer" nodename="primvar" />
  </nodegraph>```
The `fallback` is ignored.

I believe this is now addressed in #915, thanks @BrianSharpe!


_Sidebar

It would be great to have a Gollum-style sidebar that worked at a directory and sub-directory level.

This can be done using a custom biscuit.
Should implement as demo.


chance.country() do not exist

Basically the title says all. country() is inside the documentation, but missing in source code.
P.S: I've just noticed you've added it 1 day ago. It's still missing on webpage/bower/npm, hope we'll see it soon.

Would you mind making this available via bower also? :yum:

In the meanwhile, you can also tell bower to use a specific branch or commit: victorquinn/chancejs#develop should work.

Thanks for the tip, and for all your work. Awesome lib, much appreciated!

Sorry again, should be all set now!


Updates to Drawer styles

For PXBLUE-1515

Changes proposed in this Pull Request:

Add 4dp shadow to drawer by default

Can be turned off and replaced with a border by using sideBorder={true}

Use fontWeight 400 for all inactive nav item titles
Use font-weight 600 for active item title
Turn off NavItem dividers by default
Use square highlight for active items by default

Use primary[500] with 5% opacity for highlight color

Use overline variant by default for NavGroup titles
Add hideContentOnCollapse prop to Header and Footer (enabled by default)
Use font-weight 600 for any items in the selected item's tree hierarchy (can be turned off with disableActiveItemParentStyles={true} on the drawer, drawerBody, or DrawerNavGroup.

TODO: Need to update the storybook and some of the docs

NOTE: Some of these changes accidentally got pushed directly to dev, so in testing make sure to check all points above since some of them will not be reflected in the diff. (You can look at a diff with master if you want to see the code changes).

Screenshots:

Drawer's shadow should cast on the app bar, not app bar shadow casting on the drawer (is this a drawerLayout thing?)

Drawer's shadow should cast on the app bar, not app bar shadow casting on the drawer (is this a drawerLayout thing?)

Drawer's shadow should cast on the app bar, not app bar shadow casting on the drawer (is this a drawerLayout thing?)

It's a z-index thing...I'll update the DrawerLayout

Drawer's shadow should cast on the app bar, not app bar shadow casting on the drawer (is this a drawerLayout thing?)

It's a z-index thing...I'll update the DrawerLayout

Would like to see the divider turned off by default on line 169 of /components/src/core/Drawer/DrawerNavGroup.tsx

Would like to see the divider turned off by default on line 169 of /components/src/core/Drawer/DrawerNavGroup.tsx

Would like to see the divider turned off by default on line 169 of /components/src/core/Drawer/DrawerNavGroup.tsx

I think we had discussed this before and decided to leave it in at the time. If we turn it off, there's currently no way to turn it back on unless we use the existing divider prop...but then what if you want a divider on the group titles but not on the nav items — we'd need another prop. I'm open to the idea, but I would make a new issue to discuss it rather than doing it in this PR since it wasn't part of the initial scope.

Would like to see the divider turned off by default on line 169 of /components/src/core/Drawer/DrawerNavGroup.tsx

I think we had discussed this before and decided to leave it in at the time. If we turn it off, there's currently no way to turn it back on unless we use the existing divider prop...but then what if you want a divider on the group titles but not on the nav items — we'd need another prop. I'm open to the idea, but I would make a new issue to discuss it rather than doing it in this PR since it wasn't part of the initial scope.

took me around 20 min to figure out what that notifyActiveParent is doing — pretty clever :)
everything looks good design-wise. Just waiting for that docit thing to get fixed?

took me around 20 min to figure out what that notifyActiveParent is doing — pretty clever :)
everything looks good design-wise. Just waiting for that docit thing to get fixed?

took me around 20 min to figure out what that notifyActiveParent is doing — pretty clever :)

Took me more than 20 minutes to figure out how to make it work

took me around 20 min to figure out what that notifyActiveParent is doing — pretty clever :)

Took me more than 20 minutes to figure out how to make it work

Works great on docit after the updates

Works great on docit after the updates


Add an option to allow developers to re-use their LLVM Bazel target.

Add an option to allow developers to re-use their LLVM Bazel target.
To retrieve Bartleby dependencies, developers have to add the following lines
to their WORKSPACE file:

load("//bartleby:deps.bzl", "bartleby_deps")

bartleby_deps()

bartleby_deps is responsible for configuration the LLVM project using
llvm_configure from @llvm-project.llvm//utils/bazel:configure.bzl.
However, it may happen that developers importing Bartleby into their Bazel project
already come with an LLVM project.
In order to prevent Bazel from downloading two LLVM archives, this commit adds
an option to bartleby_deps called configure_llvm.
By default, this option is set to True. Developers who want to tell Bartleby
to re-use their existing LLVM targets can set configure_llvm to False:

load("//bartleby:deps.bzl", "bartleby_deps")

bartleby_deps(configure_llvm = False)

Stack created with Sapling. Best reviewed with ReviewStack.

#31
#30
-> #29

What tells us that the user would have called its llvm dependency import llvm-project? Shouldn't that be a name we take in the rule?

This could work for "basic" rules like cc_library, but for repositories like @llvm-project, I'm afraid we can't do that for now.
This issue seems to describe what you want.

I see, thanks! Yet another Bazelerie


Fix run query with namespace.

Otherwise, I get this response from the API:
{
 "error": {
  "errors": [
   {
    "domain": "global",
    "reason": "INVALID_ARGUMENT",
    "message": "app s~foo cannot access app foo's data"
   }
  ],
  "code": 400,
  "message": "app s~foo cannot access app foo's data"
 }
}

CLA signed now.

@toots Thanks for this PR!
@pcostell Can you weigh in on what the proper data for PartitionId is? Can you explain this error?

LGTM.
Caveat -- This could be indicative of a user setting the project ID to the application ID (e.g. "s~<project-id>" instead of just "<project-id>"). Note that in Datastore v1beta2 this sometimes worked, but in v1beta3 it will always fail.
When the project in the partition ID is unset, it gets populated from the request URL with the proper project_id. So unset here is always OK.

@pcostell Should we add the option to set the project on a query? We currently don't expose that as an option.

Is it possible to have the project_id in the URL and the PartitionId be different?

@toots How are you setting your project_id when you authenticate?

Gcloud.new <project-id>, <path-to-credentials.json>
Please note that the error also occurs if I make a direct API call through the page at: https://cloud.google.com/datastore/docs/apis/v1beta2/datasets/runQuery

@toots Can you comment on what @pcostell says about the difference between the application id and the project id? Does your string start with "s~"?

No, you shouldn't be able to specify a project-id for a query that is different than the request.

Great! Thank you for the clarification. :heart:

@toots I see no reason why we can't accept this PR. Please amend your commit to fix the test coverage so the build passes and we'll get it merged. Thanks!

@toots Can you squash those two commits into one commit?

@toots Thank you for your contribution!

Thanks for the quick response!

@toots This has been released in 0.8.1. Please give it a try. Thanks again for your contribution!

It's working great, thanks for the quick release

Very glad to hear it!

@toots We just released 0.8.2 to fix a bug in 0.8.1 (see #667 for details.) Can you please update to 0.8.2 as soon as possible? Thank you.

Thanks for the update. Gem updated and working fine!


chore: Fix typo in user.test.js

Summary
Fixed typo.
orginal -> original

Test plan

Codecov Report

Merging #11338 (b62f6f9) into master (510c8bb) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11338      +/-   ##
==========================================
+ Coverage   64.15%   64.16%   +0.01%
==========================================
  Files         308      308
  Lines       13515    13515
  Branches     3294     3294
==========================================
+ Hits         8670     8672       +2
+ Misses       4130     4129       -1
+ Partials      715      714       -1

Impacted Files
Coverage Δ

packages/expect/src/utils.ts
96.12% <0.00%> (+1.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510c8bb...b62f6f9. Read the comment docs.


Grammar and formatting, in my own words. :-)

I noticed a few grammar and formatting issues in my "meet the champion" text. No changes to what I actually said.

Thanks @rjt-pl


ENG-7125 - Gyro & Accel Cadence

This will capture the gyro & acceleration data at a 200ms interval as long as

the sdk is started and
we have the gyroCadence flag set to true

Also includes @kishisaka-nid sensor fix from https://github.com/Neuro-ID/neuroid-android-sdk/pull/259

When a user goes inactive and the sensors are stopped, will this continue sending the last captured value?
Also, I think Kurt's fix should be changed and the NIDSensorHelper internalize the flag on wether or not it is running.

@kishisaka-nid Would you mind reviewing my comments on this PR?

I think this is sound advice. Moving the isSensorsRunning flag to the NIDSensorHelper and have the helper switch the flag (on restart and on stop) will help make it cleaner. Also check to see if sensors are running already in restartSensors(). Then in the timer all that is required restart sensors in the NIDTimerActive.restartTimerActive()

got some conflict to address.

Merging because the UI tests change which one will pass each time meaning there is something changing in the environment that needs further diagnosis


CI Improvements and reporting

#166 (Integrations tests reporting)
#165 (CI stability update)

This does not need a version update since no part of this touches the core application code


clean up shrink select stat

Problem
When selecting candidate storages for shrinking, it will be helpful to report
how many storages are selected to shrink, how many are deferred for next round,
and what's the total number of storages to begin with. This will help us to
tune the threshold of alive ratio for shrinking cut off.
The current metric is using a debug counter, seems to be obsolete and doesn't
provide the above info.
Summary of Changes
rework shrink select metrics - report select timing, selected count, deferred
count, and total count as datapoint_info.
Fixes #

I pushed another change to move the datapoint one level up to fn shrink_candidate_slots()


Deleting a mapping should not delete the spine

When I delete a mapping, the spine is also deleted.  This should not happen.

The spine doesn't get deleted. If you visit the mapping form, the spine's domain will still be green.
But the View Mappings page only shows spines with mappings belonging by the user (that's why it's titled My Specifications, I guess). I changed it to list all of the spines from the user's organization.


Speed up all CRUD list views

Load times on list view pages like Slices, Dashboards, Tables and Database
have grown to be terrible over time.
After a bit of digging, I found that the not specifying search_columns
in ModelViews actually means "all columns" and that for each filter,
Flask App Builder (our beloved web framework) goes and fetches a
list of all values to prepopulate the
filter dropdowns. That means that for each page load, we'd fetch the
entire list of related objects. For example, when loading the
tables list view, it would fetch the list of all of the
slices, users and dashboards upfront and sequentially which takes time
and generates quite a bit of data to send over. In the worst case the database list
would also fetch all of the related SQL Lab queries with is insane.
This PR picks a sane subset of columns for search/filters and changes the
default configuration for list views to show only 100 elements per page
instead of 500

LGTM, but you probably have to rebase.


Disable the openshift_version default group var

What does this PR do?
The given default value no longer works with the error msg:
"You requested openshift_release 1.5.1, which is not matched by the latest OpenShift RPM we detected as origin-3.6.0..."
How should this be manually tested?
e2e
Is there a relevant Issue open for this?
Provide a link to any open issues that describe the problem you are solving.
Who would you like to review this?
cc: @tomassedovic PTAL

overlaps to https://github.com/openshift/openshift-ansible-contrib/pull/647

overlaps to #647


Add go_test wrapper macro. [phab:D2138]

Created by fromberger at 2018-01-23 20:56:31:
The upstream go_test implementation deprecates the use of the "library"
attribute in favour of "embed". This complicates our import, so this wrapper
does the same conversion without the deprecation warning.
Use the go_test macro in place of the upstream go_test.

schroederc accepted this revision at 2018-01-23 21:32:31

fromberger closed via commit b0b2cf824c15685b486c533cc883cb58248f6af1 at 2018-01-23 21:34:53


Clear the temporary files for the fake rtmrSubsystem.

rtmrIndexMap is added to track that one rtmr index only has one entry.
The fake rtmr subsystem has a nil deference issue in rtmrIndexMap. The bug was not discovered because the  tempory files are not cleared after the test. This PR clears the temporary files for the fake rtmrSubsystem and fixs the nil deference issue.

I haven't enabled CI yet on this repo. Did a manual test pass?

I haven't enabled CI yet on this repo. Did a manual test pass?

Yes, the manual test passes


Request to Update Wlroots Stack for Resolving Game Stuttering Issue??

Hello there,
I would like to request an update for the wlroots stack.
I have been testing sway with the latest version of wlroots, and it appears that the game stuttering issue has been resolved. However, when I tried to rebase wlroots on the same commit point and revert some commits on sway, I noticed that the game started stuttering again. Therefore, I believe that updating the wlroots stack could fix the stuttering issue in Apex.

sure, d03dcc3d99418db415e03c8f2bb7a3ca6e261866

sure, d03dcc3

Keep in mind
https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4069

Fix compilation

compiles just fine for me doe

compiles just fine for me doe

[323/422] Compiling C object libwlroots.so.12032.p/xcursor_xcursor.c.o
FAILED: libwlroots.so.12032.p/xcursor_xcursor.c.o
cc -Ilibwlroots.so.12032.p -I. -I.. -Iinclude -I../include -Iprotocol -I../protocol -Irender/gles2/shaders -Irender/vulkan/shaders -Ibackend/drm -I/usr/include/libdrm -I/usr/include/pixman-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O3 -DWLR_USE_UNSTABLE -DWLR_LITTLE_ENDIAN=1 -DWLR_BIG_ENDIAN=0 -Wundef -Wlogical-op -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wstrict-prototypes -Wimplicit-fallthrough=2 -Wendif-labels -Wstrict-aliasing=2 -Woverflow -Wmissing-prototypes -Walloca -Wno-missing-braces -Wno-missing-field-initializers -Wno-unused-parameter -fmacro-prefix-map=../= -fPIC -MD -MQ libwlroots.so.12032.p/xcursor_xcursor.c.o -MF libwlroots.so.12032.p/xcursor_xcursor.c.o.d -o libwlroots.so.12032.p/xcursor_xcursor.c.o -c ../xcursor/xcursor.c
../xcursor/xcursor.c: In function ‘xcursor_load_theme’:
../xcursor/xcursor.c:597:39: error: ‘%s’ directive output between 7 and 7 bytes may cause result to exceed ‘INT_MAX’ [-Werror=format-truncation=]
597 |         snprintf(full, full_size, "%s/%s/%s", dir, subdir, file);
|                                       ^~
......
765 |                 full = xcursor_build_fullname(dir, "cursors", "");
|                                                    ~~~~~~~~~
../xcursor/xcursor.c:597:41: error: ‘/’ directive output between 1 and 1 bytes may cause result to exceed ‘INT_MAX’ [-Werror=format-truncation=]
597 |         snprintf(full, full_size, "%s/%s/%s", dir, subdir, file);
|                                         ^
cc1: all warnings being treated as errors
[332/422] Compiling C object libwlroots.so.12032.p/xwayland_xwm.c.o

that's a wlroots problem

Weird it compiles fine in sway

I reported it to wlr https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3637

Weird it compiles fine in sway

It compiles fine for me too, something's up with gcc warnings I guess.


Editor zooms on tap

Not sure if this a new issue, or if I'm just uncoordinated today: When tapping in the middle of Apples Magic Mouse, the editor zooms in. After the interface is still scrollable. If you tap again, it zooms out again.
I think the interface should'nt be zoomable that way - only the size of the font.
OSX: 10.11
Atom: 1.0.15
Screenrecording:

Thanks for the report! I think this is the same underlying issue as https://github.com/atom/atom/issues/8850 - I'm gonna close this out in favor of that issue. Would you mind adding your comments here as a comment on that issue?


Adding Accuracy file ??

Hello everybody !!
In this repository, I found all files regarding model making to inference like development to deployment process. But no cross validation of model like Accuracy, F1 Score, Confusion matrix etc. of model.
If it is in file please let me know if there is no file then Can I add this file !!
Thanks
AB#4334

Hi - I'm not sure I understand the question. Can you clarify, maybe add an example of what it is that you are trying to achieve?

Thanks for replying @ant0nsc
Basically this inner eye deep learning is a tool box for training medical images using pytorch.
As any particular model in Deep learning has following phases ::

Development
Training
Testing
Evaluation
Deployment

In this repository, training and testing is here but evaluation is missing. Like we can evaluate our model example how much accuracy it has or how much F1 score etc.
What I want to add is  ::
A evaluation file which has following functions ::

Accuracy
F1 Score
Contusion Matrix

Through these functions we can evaluate our trained model.
Hope you got my points!!!
Thanks

In your first post, you wrote about cross validation, but not in your second. Can you clarify how cross validation comes into play here?
Also, please clarify what you mean by "evaluation". We evaluate the final trained model on the test set. By evaluation, you mean running another dataset through the model, that was initially not available?

Yes. Evaluation ::
Suppose that we have trained dataset on Medical dataset - 1 then Evaluation ::

Test on Medical dataset - 2
Checking Accuracy of the model
Checking F1 Score

Based on these we can evaluate how good our model is.

Hi @tanujdhiman, there's documentation here on how to use model checkpoints to run evaluation. If you are using AzureML, you can run evaluation on a model registered by a training run. You can also run evaluation on checkpoints by specifying the path to the checkpoint on your local system or a URL to download the checkpoint from.
If you are using one of the segmentation or classification configs, the config will automatically partition the input dataset into training, validation and test datasets. To avoid this and run inference on the entire input dataset you will need to add the option --restrict_subjects=0,0,+ when running the script. This will move all the input data to the test dataset.

Thanks @Shruthi42
But what about checking model accuracy, confusion matrix, and components ?

It depends on the type of model you are running. The classification and segmentation models write out reports with metrics and other useful information after the inference step finishes. For custom pytorch lightning models, you can define your own report with metrics, etc. by overriding the create_report method in the config. There is a very simple example of this in the HelloContainer config.
You can find generated reports in the reports subfolder in the output directory of a run.

Okay Got it.
Thanks


Duplicate Proxy Calls

Describe the bug
Using latest React SDK I see the Proxy be query two times constantly.

Steps to reproduce the bug
Just run React app with proxy and watch the F12 network traffic.
Expected behavior
Only 1 call every 15 seconds
Logs, error output, etc.
No response
Screenshots
No response
Additional context
const unleashInstance: IConfig = {
	url: process.env.REACT_APP_UNLEASH_SERVER!,
	clientKey: process.env.REACT_APP_UNLEASH_KEY!,
	refreshInterval: 15,
	appName: 'clm',
	environment: process.env.REACT_APP_UNLEASH_ENV!,
	disableMetrics: true
};

Unleash version
Latest
Subscription type
Open source
Hosting type
Self-hosted
SDK information (language and version)
"@unleash/proxy-client-react": "^3.3.0",

Hmm, this looks odd, thanks for raising this one. I'll add this to our list of things to look into next week

@melloware Is this happening in development or production?

i am in development mode right now.

i wasn't sure if this was a problem with React SDK or the client Proxy SDK so I reported it in both.

i wasn't sure if this was a problem with React SDK or the client Proxy SDK so I reported it in both.

Thanks for the clarification! I think this is not a bug with this project, but actually how hot module reloading works according to this issue.
I will close this issue for now, feel free to re-open if you disagree.

What is interesting about this is it starts happening even if I load my app fresh so its not like I have done any hot reloads or anything?
Also it looks like the Hot Reload library is no longer needed as Fast Refresh is already included in Core React right?  See: https://github.com/facebook/react/issues/16604

I actually think to be  good citizen you should be calling STOP on unmount as well like this..
React.useEffect(() => {
    const shouldStartClient = startClient || !unleashClient;
    if (shouldStartClient) {
      client.current.start();
    }

    // stop unleash client on unmount
    return function cleanup() {
       client.current.stop();
    };
  }, []);

What is interesting about this is it starts happening even if I load my app fresh so its not like I have done any hot reloads or anything?
Also it looks like the Hot Reload library is no longer needed as Fast Refresh is already included in Core React right? See: facebook/react#16604

Are you using react in strict mode? See this issue

I actually think to be good citizen you should be calling STOP on unmount as well like this..
React.useEffect(() => {
    const shouldStartClient = startClient || !unleashClient;
    if (shouldStartClient) {
      client.current.start();
    }

    // stop unleash client on unmount
    return function cleanup() {
       client.current.stop();
    };
  }, []);

Good idea. Feel free to open a separate issue or contribute a PR if you'd like. Otherwise I'll try to get to it next week.

Yep confirmed its REact 18 Strict Mode causing the issue!!!
So what happens is render gets called twice to make sure you are being a good citizen with your renders.    I have fixed this in other projects where they were not handling the renders correctly.
Like this one I reported in use-between and he fixed it: https://github.com/betula/use-between/issues/33

OK i will submit a PR.


Documentation on registering DelegatingHandler's via Service Registration could explicitly say that the delegating handler must be registered with a Transient lifetime

Description
[Enter feedback here]
The section with heading "Outgoing request middleware" shows an example of adding one or more delegating handlers that are resolved from the DI container, and while the sample code correctly registers the delegating handler types as Transient it would be useful if the requirement to use Transient lifetime were called out explicitly in the documentation.
Only when following the link through to the API documentation  is there a mention of the Transient requirement.
I fell foul of this when I registered my delegating handlers in the DI container as singletons because they had no shared state, only to get an exception at runtime saying they cannot be reused.
Page URL
https://learn.microsoft.com/en-us/aspnet/core/fundamentals/http-requests?view=aspnetcore-8.0
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/fundamentals/http-requests.md
Document ID
3d356334-e672-7e8b-1fef-7944ebee99eb
Article author
@stevejgordon

Thanks for reporting this. Any chance you could PR this? At the top right of the article, select the Edit pen icon:

Select the pen icon again.  Edit, then Save.


Scipy comb deprecated

when importing openfermioncirq in colab,
from scipy.misc import comb, factorial causes problem "cannot import name comb"

Closing https://github.com/quantumlib/OpenFermion/issues/536 will close this too.

The reason for this is that the pip version of openfermioncirq is pinned to OpenFermion 0.9.0. We need to cut a new release of openfermioncirq to fix this.


Bug on .remove API

Doing
const resp = await coach_table.remove(({ key }) => [
        key({
          userId: external_id ?? userId,
          coachId: coachId,
        }),
      ])

console.log(resp)

resp is logged out as undefined.
I looked through AWS SDK v2 docs and have a feeling it should at least return something
https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/DynamoDB.html#deleteItem-property

For the delete operation in DocumentClient, you can get a atrributes map which is the item before deletion if you put a ReturnValues parameter as ALL_OLD. Other things are just about async handlers and a table metadata like a comsumed capacity. Check out this reference: https://docs.aws.amazon.com/sdk-for-ruby/v2/api/Aws/DynamoDB/Types/DeleteItemOutput.html
I did not expose it as a result because in most cases I do not have to use or read them. Could you let me know specific usecases to get them? I'll consider to provide some options to expose them as a result.
Thank you.

I don't need the ReturnValues.
I want the resp from the await to indicate an HTTP status if the delete was successful or not. Maybe a 500 in the case that the request failed due to some network error, or a 4xx in the case that the item selected for delete did not exist, and a 200 in the case that the operation succeeded.

Right so now it doesn't inform anything for any error results.
I can make operations including the remove function throw an AWSError if any error occurs. So that you can catch it.

Perfect, thank you!


changes for OpenCE v1.7.0

Checklist before submitting

[x] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
Fixes # (issue).
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

I will raise a follow up PR for documentation changes.

I think we should update Builder version too to 11.0 with this PR.

Yes, version update is to be done.

Codecov Report

Merging #129 (2e5da6b) into main (aa79245) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   96.20%   96.25%   +0.05%
==========================================
  Files          23       23
  Lines        2106     2082      -24
==========================================
- Hits         2026     2004      -22
+ Misses         80       78       -2

Flag
Coverage Δ

unittests
96.25% <100.00%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/errors.py
100.00% <ø> (ø)

open_ce/container_build.py
97.01% <100.00%> (+0.61%)
:arrow_up:

open_ce/inputs.py
96.91% <100.00%> (+0.45%)
:arrow_up:

open_ce/utils.py
94.98% <100.00%> (-0.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa79245...2e5da6b. Read the comment docs.

Codecov Report

Merging #129 (2e5da6b) into main (aa79245) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   96.20%   96.25%   +0.05%
==========================================
  Files          23       23
  Lines        2106     2082      -24
==========================================
- Hits         2026     2004      -22
+ Misses         80       78       -2

Flag
Coverage Δ

unittests
96.25% <100.00%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/errors.py
100.00% <ø> (ø)

open_ce/container_build.py
97.01% <100.00%> (+0.61%)
:arrow_up:

open_ce/inputs.py
96.91% <100.00%> (+0.45%)
:arrow_up:

open_ce/utils.py
94.98% <100.00%> (-0.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa79245...2e5da6b. Read the comment docs.

We found that we would still need system GCC for P10, hence added only part of the changes from here in https://github.com/open-ce/open-ce-builder/pull/131.


Documentation and tooltip updates

made tooltip for uptodate status indicators more succinct
added documentation for gray (out of date) dot

Reference: #35

Merged with modifications. Thanks you @redstreet!


add: thirdweb to platform as a service

I add thirdweb to the platform as a service section of the list.
Checklist

[x] The URL is not already present in the list (check with CTRL/CMD+F in the raw markdown file).
[x] Each description starts with an uppercase character and ends with a period.Example: solc-js - JavaScript bindings for the compiler.
[x] Drop all A / An prefixes at the start of the description.

@WarenGonzaga thanks 🤝


check that all current code is checked in the Travis-CI jobs

We've recently moved a lot of stuff around, but we do want to make sure that all the important notebooks are being run in the Travis-CI environment.

Planning to tackle this along with #26 once #30 is resolved.


README: Rename Voyager to Lunie

Description:

Thank you! 🚀

For contributor:

[ ] Added entries in PENDING.md with issue # and GitHub username
[ ] Reviewed Files changed in the github PR explorer
[ ] Attach screenshots of the UI components on the PR description (if applicable)
[ ] Scope of work approved for big PRs

For reviewer:

[ ] Manually tested the changes on the UI

Edited #2340


Receiver list activity UI

In this PR, I have the list of the receivers created and stored in the "Controller.receiversList", a java class once the app is created. The button "view the list of receivers"Created  in the home screen of the mailman and implemented to display the list of the receivers stored in the controller. The list shows the name, the ID and the adress of the receivers.

Some merge conflicts were caused by this PR now are resolved


file extentions for free-form fortran code

The convention followed for free-form fortran code files, is to use '.f90'. Then it implies compatibility with all further standards. Using .f95, .f03 etc. may lead some compilers to assume fixed-form code.
Ref: http://fortranwiki.org/fortran/show/File+extensions
p.s.  Also, arrays are now written as [1, 2, 3, ... ]
Ref: http://www.fortran90.org/src/best-practices.html#arrays

I could have sworn I fixed the free-form when I updated the repo a few months ago..
Looks like I missed that part somehow.
Thanks for pointing out the issues, I'll go ahead and make the changes!
P.S. All of us at arrayfire are novices when it comes to FORTRAN. I'd appreciate any other feedback you can send our way! Patches would be even better :D

This is fixed in the master branch.


about Image2Image translation inference issue

Image2Image translation & Saving results...
Image2Image translation inference:   0%|                                                       | 0/672 [00:00<?, ?it/s]
Traceback (most recent call last):
File "demo.py", line 264, in
facedataset.dataset.image_pad)
File "C:\Users\23046\LiveSpeechPortraits\datasets\face_dataset.py", line 280, in get_data_test_mode
feature_map = torch.from_numpy(self.get_feature_image(landmarks, (self.opt.loadSize, self.opt.loadSize), shoulder, pad)[np.newaxis, :].astype(np.float32)/255.)
File "C:\Users\23046\LiveSpeechPortraits\datasets\face_dataset.py", line 287, in get_feature_image
im_edges = self.draw_face_feature_maps(landmarks, size)
File "C:\Users\23046\LiveSpeechPortraits\datasets\face_dataset.py", line 317, in draw_face_feature_maps
im_edges = cv2.line(im_edges, tuple(keypoints[edge[i]]), tuple(keypoints[edge[i+1]]), 255, 2)
cv2.error: OpenCV(4.5.4) :-1: error: (-5:Bad argument) in function 'line'

Overload resolution failed:

Can't parse 'pt1'. Sequence item with index 0 has a wrong type
Can't parse 'pt1'. Sequence item with index 0 has a wrong type

这个问题怎么解决。

I had encountered the same problem. Here was my solution:
ps1 = [int(x) for x in edge[i]]
ps2 = [int(x) for x in edge[i+1]]
im_edges = cv2.line(im_edges, ps1, ps2, 255, 2)

Hope it help.

This is an OpenCV version issue. Please check #29.


Exclude pyc dirs, not include, when hashing code

This fixes #2285 by fixing a minor typo in f9a9d949d95efd0153452dc255625656d628ee17 / #2263 that caused the computation of a PEXes code hash to not recur into the correct directories.
I think this explains the symptoms in #2285 due to caching: if a PEX only contains files in subdirectories, the code hash will be da39a3ee5e6b4b0d3255bfef95601890afd80709 (the sha256 hash of no data) and thus potentially the venv create might be referring to an incorrectly cached installation.

I haven't got my dev environment to work with the Python 3.12 changes and don't have time to today, so this is as yet untested (i.e. I don't know if the test fails before/passes after). The bisection script from #2285 does work, though.

I've got a dev environment working again 🎉
That test was wrong (testing dir_hash, bug was in pex_code_hash). I've rewritten the existing tests for dir_hash to also test pex_code_hash, which catches the bug, plus added an assertion for the hidden file handling.

... haven't yet got my dev environment to work for running test with the Python 3.12 changes ...
@huonw fwiw, if you have docker, then you need no dev env and can do things just like CI:
https://github.com/pantsbuild/pex/blob/db5b5100d0d739964bfc46943bc9c8f9e1bed480/.github/workflows/ci.yml#L99-L101

Basically:

(one time only) BASE_MODE=pull CACHE_MODE=pull ./dtox.sh --version
./dtox.sh ...regular tox args...

You don't need to do step 1, in which case these images will be built locally, but that is slow. If you have a decent network connection, pulling them is probably more convenient. What this nets you is the full suite of Python interpreters Pex supports - both CPython and PyPy - ready to go in the image. It also gets you a pre-seeded PyPI cache when you use ./dtox.sh -epy... -- --devpi .... You can omit the CACHE_MODE=pull if you don't use the --devpi feature of the build or if you'd rather have it build that cache up locally.


XmlHttpRequest to "http://grafanarel.s3.amazonaws.com/latest.json" fails

I'm using the container via https://registry.hub.docker.com/u/kamon/grafana_graphite/ and when I try to set up a new dashboard, I can not get metrics. My google chrome reports the following error in the developer console:
XMLHttpRequest cannot load http://grafanarel.s3.amazonaws.com/latest.json. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost' is therefore not allowed access. (index):1
Failed to load resource: the server responded with a status of 404 (Not Found)

When I try to open XXX I get this error
{"error":"IndexMissingException[[grafana-dash] missing]","status":404}

Editing the dashboard always hangs with this messages when trying to configure metrics:
Load metrics keys into elastic search
Work in progress...

Building the container myself using the latest Grafana does not fix the issue. Any ideas what I am missing?

2 years old in 2 weeks :)


Documentation, 8th July meeting (Q3)

Write minutes for meeting on Mon 8th July and add to meeting summary tool

Where is the Meeting Summary Tool? I don't see it in the Git book, but then I could be blind. I'm trying to work off of my phone

hi Colleen - it's here https://archive-oracle.netlify.app/

yes thank you!  I also had the link you sent to me via DM awhile back, I forgot I asked here too.  :0)

Summary archived https://snet-ambassadors.gitbook.io/singularitynet-archive/timeline/2024/july-2024/week-28#ai-ethics-wg


update date filters  from yyyy-mm-dd to dd-mm-yyyy

Changes in this PR:
Bug fix : update date filters  from yyyy-mm-dd to dd-mm-yyyy
Trello card / Rollbar error (etc)
https://trello.com/c/eSE97UiL/1094-pui-date-filters-read-yyyy-mm-dd-should-read-dd-mm-yyyy
Screenshots of UI changes:
Before

After

[ ] Requires env variable(s) to be updated

 [PUI] Date filters read yyyy-mm-dd; should read dd-mm-yyyy

 [PUI] Date filters read yyyy-mm-dd; should read dd-mm-yyyy

Codecov Report

Merging #905 (7717c85) into main (aa07964) will increase coverage by 0.01%.
 Consider uploading reports for the commit c758a4a to get more accurate results

@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
+ Coverage   94.55%   94.57%   +0.01%
==========================================
  Files          32       32
  Lines        1358     1363       +5
  Branches      220      220
==========================================
+ Hits         1284     1289       +5
  Misses         54       54
  Partials       20       20

Files
Coverage Δ

judgments/test_date_parsing.py
100.00% <100.00%> (ø)

judgments/utils.py
91.15% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Solid v1.6

Summary
This release mainly focuses on better support for partial hydration and for spreads. We've extended partial hydration support to skip serializing server-only resources, and added support for Context API. For spreads we've fixed native DOM elements not properly merging updates. We also reduced the need for proxies in most places making Solid more suitable for super low-end devices running on legacy platforms.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

38 of 39 (97.44%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 89.089%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/solid/store/src/mutable.ts
9
10
90.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
1276

Relevant Lines:
1362

💛  - Coveralls


Removed Starter Code Dead Links (Phase 1-6)

The links to the starter code on the various .md files from Phase 1-6 don't lead anywhere. I just replaced the non-functional links with text saying the starter code is in the Phase 0 zip.

Thanks for noticing this. I went and removed the references entirely. This seemed cleaner since there is already text referring them to their chess project starter code directory rather than pointing them back to the original chess.zip.


How to get it working with Expo?

Do you have a quick fix to let this component work with the expoJS stack. the async storage linking is not possible without detaching. Would like to keep the expo perks :-)
why not set import { AsyncStorage } from "react-native" instead of community version?

Hi,
I can't think of a simple solution at the moment. If you have an idea don't hesitate to create a PR :)
Cheers,
Jeremy

1. Expo does not support NativeModule.
Expo does not support react NativeModules from birth. So. you can not use the packages that requires using NativeModules.
I don't recommend you to build apps with expo for a such reason.
2. Old version of AsyncStorage is deprecated.
import {AsyncStorage} from 'react-native'

Above way of using AsyncStorage is deprecated. So you should use community version instead.


Add CI with GitHub Actions

Description (required)
Depends on #4076
Adds CI with GitHub actions. It runs much faster (7 minutes vs. 19 minutes when you include time to boot the agent) and integrates with GitHub more closely. Also makes it easier for people to run CI on forks.
This check has passed here: https://github.com/domdomegg/apps-android-commons/actions/runs/404423357
NB: this only does the CI part, not the CD part that Travis also does for us at the moment.

We will also need to include a script for automatic alpha releases. As of now, it's integrated into our Travis flow. Ref: #1056

Codecov Report

Merging #4078 (d02c368) into master (b24ed1c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4078   +/-   ##
=========================================
  Coverage     10.60%   10.60%
  Complexity      476      476
=========================================
  Files           343      343
  Lines         12875    12875
  Branches        997      997
=========================================
  Hits           1366     1366
  Misses        11441    11441
  Partials         68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24ed1c...d02c368. Read the comment docs.

NB: blocked by #4076 which is blocked by #4090

Thanks a lot @domdomegg .

Ah my bad, I think this still depends on updating Gradle which requires moving to JSON service credentials unfortunately. :(
Probably need to revert until that's sorted :(


[vcpkg baseline][salome-configuration] passing remove from fail

Passing on this run https://dev.azure.com/vcpkg/public/_build/results?buildId=93404&view=results

Why it failed before?

Server was simply down.

Related PR https://github.com/microsoft/vcpkg/pull/33336.

Why it failed before?

https://github.com/microsoft/vcpkg/pull/33336#issue-1863102573


⚠ Secret Website 3 has degraded performance

In 7b6e68a, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 13769 ms

Resolved: Secret Website 3 performance has improved in 3e9e085.


Make the root cause of system_u and object_r nonexistence clearer

Users are sometimes confused when they get a large number of errors about system_u and object_r not being defined in policy when running selint.  SELint is told to assume the existence of these by the config file (assume_users and assume_roles config options), and so when the default config is loaded, this should go away.  Unfortunately, this can cause confusion for users who choose to run selint without installing it and don't specify a config on the command line.
We should come up with some default behavior that either causes this issue to not occur, or makes it clear to the user why it's occurring and how to address it.

Fixed in 04a0a8e190169ec0922a9a9fe76b9327788184f1


[fix][broker] Make authentication refresh threadsafe

Fixes #19431
Motivation
The originalAuthState and the authState are not thread safe members of the ServerCnx class. As such, we should only access them on the context's event loop thread.
Modifications

Replace scheduled task to check all connections for authentication refresh with a scheduled task per ServerCnx that will run on the appropriate event loop. This logic could theoretically be optimized to minimize scheduled tasks. However, I am following the keep alive implementation and making the assumption that the Netty scheduled tasks are not too expensive.
Slightly refactor conditional logic in refreshAuthenticationCredentials method to remove the logic that it only short circuits when the ServerCnx is in Failed state. We should never call this method when the isActive flag has gone to false, and the only case when the state isn't Connected is when we recently failed due to an exception.

Verifying this change
Added new test and make sure existing tests pass. Also, I added some new assert lines. These only run when the correct JVM arg is passed.
Does this pull request potentially affect one of the following parts:
This is not a breaking change.
Documentation

[x] doc-not-needed

This is an internal improvement.
Matching PR in forked repository
PR in forked repository: https://github.com/michaeljmarshall/pulsar/pull/28

/pulsarbot rerun-failure-checks

Codecov Report

Merging #19506 (3425a88) into master (016e7f0) will increase coverage by 37.27%.
The diff coverage is 50.90%.

@@              Coverage Diff              @@
##             master   #19506       +/-   ##
=============================================
+ Coverage     24.75%   62.03%   +37.27%
- Complexity      288    25727    +25439
=============================================
  Files          1579     1843      +264
  Lines        121841   135152    +13311
  Branches      13304    14860     +1556
=============================================
+ Hits          30164    83837    +53673
+ Misses        87240    43605    -43635
- Partials       4437     7710     +3273

Flag
Coverage Δ

inttests
24.67% <5.45%> (-0.08%)
:arrow_down:

systests
25.26% <21.81%> (?)

unittests
59.34% <50.90%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ulsar/broker/service/PulsarChannelInitializer.java
90.00% <ø> (+25.52%)
:arrow_up:

...va/org/apache/pulsar/broker/service/ServerCnx.java
55.10% <50.90%> (+23.44%)
:arrow_up:

...dbalance/extensions/ExtensibleLoadManagerImpl.java
5.03% <0.00%> (-2.45%)
:arrow_down:

...er/systopic/NamespaceEventsSystemTopicFactory.java
71.42% <0.00%> (-1.91%)
:arrow_down:

...xtensions/channel/ServiceUnitStateChannelImpl.java
0.66% <0.00%> (-0.19%)
:arrow_down:

...in/java/org/apache/pulsar/common/api/AuthData.java
71.42% <0.00%> (ø)

.../apache/pulsar/broker/namespace/LookupOptions.java
87.50% <0.00%> (ø)

.../apache/pulsar/common/naming/SystemTopicNames.java
55.55% <0.00%> (ø)

...apache/pulsar/common/util/SafeCollectionUtils.java
0.00% <0.00%> (ø)

...pache/pulsar/common/configuration/BindAddress.java
22.22% <0.00%> (ø)

... and 1388 more


SVG Icon not inheriting width/height

    "material-ui": "^1.0.0-beta.13",
    "material-ui-icons": "^1.0.0-alpha.19",

Prior to beta.13 (i.e .9) this was working.
Expected Behavior
const stylesheet = () => ({
  icon: {
    marginLeft: 5,
    width: 10,
    height: 10,
  },
});
...
     <IconButton disableRipple className={classes.icon}>
         <IconSettings />
     </IconButton>

SVG icon width / height is still 24 (default)

Isn't it working with this demo https://material-ui-next.com/style/icons/#svg-icons ?

Oh, I have missed the IconButton part of the issue.

With styles directly it works but doesn't inherit constraints from parent. In my case, the IconButton

As far as I know, it's something that has never been supported for SvgIcon, only for Icon. But I think that we can extend the behavior 👍 .


[WIP] Add support for Python 3.13

Python 3.13 will be released on 2024-10-01. This PR is an attempt to figure out what it will take to support.
Currently this PR tests version 3.13.0rc2.
Merge checklist

[x] Replace rc2 with final 3.13.0 release once it's available
[ ] Need wheels for some libraries (incomplete list):

[x] psycopg2: https://github.com/psycopg/psycopg2/pull/1695
[x] confluent-kafka: https://github.com/confluentinc/confluent-kafka-python/issues/1768
[ ] pendulum: https://github.com/sdispater/pendulum/issues/844

[x] gevent is not yet compatible with 3.13, work is in progress: https://github.com/gevent/gevent/commits/py313/
[ ] Review dependencies manually for issues like we did for 3.11/3.12

[ ] webob does not yet support Python 3.13 due to a cgi import: https://github.com/Pylons/webob/issues/437

Working around this for now using the legacy-cgi package: https://pypi.org/project/legacy-cgi/

[ ] grpcio needs a new release

~1.67.0 has the fix but it's not on PyPI yet: https://pypi.org/project/grpcio/#history (1.67.0rc1 doesn't have the fix)~ Actually we just need 1.66.2?

We're hitting https://github.com/pylint-dev/pylint/issues/10112 now.


Add unique_id to catalog entries to join the catalog and manifest together

Entries in the catalog should have a unique_id for the model that created it, if applicable. Presently, we're joining the two together on simple string equality for model_name == table_name, but this pattern will not hold with aliases, or Snowflake casing.
dbt should find the model responsible for creating a table by comparing the schema name and alias name for each model to each schema name and relation name in the catalog.

check that unique_id is actually unique across all of the items in the catalog.


ungoogled-chromium: 108.0.5359.125 -> 108.0.5359.125

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for ungoogled-chromium is: "An open source web browser from Google, with dependencies on Google web services removed"
meta.homepage for ungoogled-chromium is: "https://github.com/Eloston/ungoogled-chromium"
meta.changelog for ungoogled-chromium is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 108.0.5359.125 with grep in /nix/store/dg8210dgz8frkkjawwkv0nxbchl6cssm-ungoogled-chromium-108.0.5359.125
found 108.0.5359.125 in filename of file in /nix/store/dg8210dgz8frkkjawwkv0nxbchl6cssm-ungoogled-chromium-108.0.5359.125

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
google-chrome-dev

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dg8210dgz8frkkjawwkv0nxbchl6cssm-ungoogled-chromium-108.0.5359.125 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ungoogled-chromium https://github.com/r-ryantm/nixpkgs/archive/13b829401907b1f7e59b565a0af745f4a8d482a4.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dg8210dgz8frkkjawwkv0nxbchl6cssm-ungoogled-chromium-108.0.5359.125
ls -la /nix/store/dg8210dgz8frkkjawwkv0nxbchl6cssm-ungoogled-chromium-108.0.5359.125/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

chromiumDev

1 package built:

google-chrome-dev

Maintainer pings
cc @squalus @primeos @michaeladler for testing.

@r-ryantm  This only seems to update -dev and not ungoogled-chromium as the title suggests.

Need to fix passthru.UpdateScript for the bot to work properly.


[core] add dependency react>=16.3.0 requested by @emotion/core and react-jss

[x] I have followed (at least) the PR section of the contributing guide.

There is a missing dependency on this worktree, as react is listed as a peer dependency of dependencies @emotion/core and react-jss.
this raises a warning when running with yarn2(berry) and will break PNP when using material-ui as a dependency.
tagging @arcanis as requested in https://yarnpkg.com/en/docs/pnp/troubleshooting

@marco-silva0000 Would it work with a higher version of React, like the latest version for instance? Also, React is a dependency of the parent package.json. Why do we need to duplicate it?

Would it work with a higher version of React, like the latest version for instance?

It was wrongly pinned, nice catch.

Also, React is a dependency of the parent package.json. Why do we need to duplicate it?
I'm not sure, but I think yarn PNP needs the worktree to list the full dependencies, otherwise it will raise an error when using material-ui in other projects. I have at least a warning when running the new version of yarn with this package.
@arcanis can explain better when available. I may be mistaken.


Importing Excel sheet

Expected behavior
Importing existing excel sheet should be updated
Actual behavior
not importing existing excel sheet
Steps to reproduce the issue

It maybe your app contains the same DB specified with excel file. Try to clear your app's data and import the excel file. Now, I have closed this issue.
You can re-open the issue if it remains


narrow: Fix "pm-with" narrow in scheduled messages.

"pm-with" was deprecated in #25003. This addition for scheduled messages must have gotten missed in the overlap of that change.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @laurynmm!


[front] Add request data action for extension

Description
This introduces a new action, that simply request data from the client/user, as described here : https://www.notion.so/dust-tt/Design-Doc-Browser-Extension-11828599d94180d0b08ad5208ce6dbf0?pvs=4#11828599d94180e69e34cdef90c257d4
This action cannot be added directly into an assistant. The pr also allows to pass JIT actions when posting messages with a new optional parameter in public api. [todo add in private]
It's used by the extension to send contextual data about the page.
Risk

Deploy Plan
run migration ( new table )
deploy front
build extension

seen irl , client side actions will be handled in another project


video path contains  chinese charators

if video path contains  chinese charators，the video controller will be initialize failed。

如果video路径包含中文，那么video controller初始化失败

Hi @yizhangxyz
Using official example with video path folder with chinese character. is very wroking
  @override
  void initState() {
    super.initState();
    _controller = VideoPlayerController.asset('assets/视频/Butterfly-209.mp4');

    _controller.addListener(() {
      setState(() {});
    });
    _controller.setLooping(true);
    _controller.initialize().then((_) => setState(() {}));
    _controller.play();
  }

  @overri

Can you please provide your flutter doctor -v, your flutter run --verbose and a minimal complete reproducible code sample.
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now.
Could everyone who still has this problem please file a new issue with the exact descriptions what happens, minimal reproducible sample code (if related), logs and the output of 'flutter doctor -v'  please.


HAWQ-966. Adjust libyarn output log messages.

Change some log message level to DEBUG1.  Property 'yarn.client.log.severity' in yarn-client.xml can be used to change the output log level, default value is 'INFO', others can be 'DEBUG1', 'WARNING', etc.
Please review, thanks!

+1.

+1


Update deps and minimum node 14

The email address you have sent to @.*** is for a legacy domain and will shortly be removed.
Please update your address book and send to the same address but having removed .gsi. from the domain part.
Mail to the legacy addresses will stop working in a few weeks.


Try using new CloudMicrophysics

One unit test is still not working.

I'm removing the below job from the CI. In CM.jl we have not (yet) updated the 1-moment microphysics rates to Chen2022 velocities. So this simulation would be doing advection with Chen2022 velocity, but still need to use the default velocity in other processes like accretion.
If we want, we can add a hacky simulation like that. Or just wait till we update the remaining rates in CM.jl
julia --color=yes --project=test test/experiments/KiD_driver/KiD_driver.jl --moisture_choice=NonEquilibriumMoisture --prognostic_vars=RhodTQ --precipitation_choice=Precipitation1M --sedimentation_scheme_choice Chen2022

bors r+


Allow getSessionKey to use extended ctx type

As of now, we are unable to use narrowed Context type for getSessionKey because the parameter type of ctx is fixed to Context - TS Playground
This change attempts to provide getSessionKey's ctx parameter with the narrowed Context type so that the following can be accomplished.

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (e95c1b2) 35.14% compared to head (767b58c) 35.14%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #390   +/-   ##
=======================================
  Coverage   35.14%   35.14%
=======================================
  Files          16       16
  Lines        4778     4778
  Branches      166      166
=======================================
  Hits         1679     1679
  Misses       3097     3097
  Partials        2        2

Impacted Files
Coverage Δ

src/convenience/session.ts
96.88% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I remember trying this but due to some covariance/contravariance problems these changes would break a lot of bots. It is a conscious decision not to have it parameterised.
Perhaps I was wrong, so we could well spend some time on testing this once more. I'm just very careful here.

Also, please fixup CI.

Also, please fixup CI.

nvm, I did this now


fix name-mangling in context of nimbleFunction lists

This fixes issue #1035, which fixes an error in name-mangling in creation of C++ related to nimbleFunction lists.

I think this is ok.  You're relying on && to not evaluate the second condition if the first condition is FALSE.

Yes, my understanding is that is reasonable R practice.


get kappa vector

Hi Massimo,
Correct me if I missed it, but I could not find any means to extract the kappa vector with the dimensional thermal response factors in pygfunction.
I did a small tweak on my branch of pygfunction to extract the kappa vector. In the load_aggregation.py file, within the class ClaessonJaved I added the following function
    def get_kappa(self):

        return self.dg

It is a small addition, but perhaps can be useful in the code. If you are interested I can add it to the classes MLAA and Liu and make a pull request.
Best,
Iago

Hello @icupeiro.
You are right, that could indeed be useful.
Since "kappa" is not necessarily an established term for this vector, I suggest : get_thermal_response_factor_increment(self). Would you also be willing to complete the docstring for the class method?
This seems straightforward so I will add it to the 1.1.2 milestone. I am aiming to push the update on Pypi in a week or so.

Hello @icupeiro.
You are right, that could indeed be useful.
Since "kappa" is not necessarily an established term for this vector, I suggest : get_thermal_response_factor_increment(self). Would you also be willing to complete the docstring for the class method?
This seems straightforward so I will add it to the 1.1.2 milestone. I am aiming to push the update on Pypi in a week or so.

Consider it done
It may be more useful to re-shape the matrix to an array, for example as:
return self.dg.reshape(len(self._time))
Let me know your preference

Consider it done
It may be more useful to re-shape the matrix to an array, for example as:
return self.dg.reshape(len(self._time))
Let me know your preference

After some thought I recalled that the thermal response factor increments are only used for the ClaessonJaved method (It is the only method where the load history cells have fixed times). I removed the method from MLAA and Liu since dg is not used in these cases.
For the shape of the array, a simple fix was to return self.dg.flatten(). This should provide the expected behaviour, returning a (nSources, nSources, Nt) array if nSources > 1 and a 1d array of length Nt if nSources == 1.

After some thought I recalled that the thermal response factor increments are only used for the ClaessonJaved method (It is the only method where the load history cells have fixed times). I removed the method from MLAA and Liu since dg is not used in these cases.
For the shape of the array, a simple fix was to return self.dg.flatten(). This should provide the expected behaviour, returning a (nSources, nSources, Nt) array if nSources > 1 and a 1d array of length Nt if nSources == 1.

Sounds good to me, I edited the documentation for consistency
Reviewed and ready to merge in master

Sounds good to me, I edited the documentation for consistency
Reviewed and ready to merge in master


tests: remove deprecated ansible option

Ansible used to have a "feature" where it would warn you if you wrote a shell command that could be implemented with a module instead. The shell option had an option to disable these warnings.
These features were deprecated in ansible 2.11 and removed in anbsible 2.14. This PR removes the warn option. Otherwise the playbooks won't work.
This does mean that people using an older version of ansible might see the warnings.

lgtm


Test new implementations of functional gates

Make Grover's algorithm with functional gates

Actually, the implementation did not change (just refactoring, moved some code blocks into functions). But some tests would be good.

Same issue as writing unittests. Implementation works in basic unittests written. See issue #6 .


Scale transform control doesn't seem to respect local/world setting

This might be a bug in threejs. Three Editor also doesn't support scaling in world space.

This'll have to be fixed in THREE.