python311Packages.lsassy: 3.1.8 -> 3.1.9

Diff: https://github.com/Hackndo/lsassy/compare/refs/tags/v3.1.8...v3.1.9
Changelog: https://github.com/Hackndo/lsassy/releases/tag/v3.1.9
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 265803 run on x86_64-linux 1

6 packages built:

crackmapexec
crackmapexec.dist
python310Packages.lsassy
python310Packages.lsassy.dist
python311Packages.lsassy
python311Packages.lsassy.dist


Enable saving the modified stashes without closing the tool

without the need to close the app.

[ ] relic stash,
[ ] shared stash,
[ ] private stash,
[ ] inventory,
[ ] bags.

Related to #282, with the same concerns. I'm not quite clear when the game reloads/saves its data currently.

I also wanted to suggest such functionality.
The game handles two types of storages: one directly inside player's file (game uses it all the time while playing), and those from Caravan Driver: private, shared, relic, which are used by game when you chatting to Driver. I think it would be better to start with the second ones.
Anyway if there are any early bugs, these bugs related to Driver's storages will be less destructive, than to character's.

@EtienneLamoureux This is implemented and enabled with the "hot reload" config setting.


Opening a Terminal sets the wrong node version

When I use the Toolbar Button to open a Terminal (Git Bash on Windows) and try to use node the node version is not the one I have installed.
Instead it seems the node version that comes with Brackets is set as default.
Is that intentionally?
I would prefer to use my node version as it is more recent.
The top is opened from Brackets, the bottom is opened normally.

Does this happen always? Might be a thing caused by brackets-npm-registry

@Hirse please update brackets-npm-registry to 0.3.8 and try this again, hopefully it'll be fixed.

Just updated and the issue seems to be still there.

Another update of brackets-npm-registry to 0.4.0. I can no longer replicate the problem in any way. If the problem still persists with your machine, can you try removing brackets-npm-registry from the extensions?

I had some trouble to update, but after reinstalling brackets-npm-registry from GitHub the issue seems fixed.


add environment variable YOURLS_ADMIN_SSL

Closes #48

Turns I don't need this, but enjoy!

Turns I don't need this, but enjoy!

You don't need it most of the time in a Docker context, do you? 😉
Anyway, if really needed, I suggest using a custom config.php file and link it with a volume.
We don't want to add more constant here.


Add custom tiles support

Coverage decreased (-0.1%) to 50.839% when pulling 73c26d1686b624b08a75ed2a5bfeeb6356104837 on custom-tiles-support into a6b0b8287a87d4763f5cbc43a9346dec2d461578 on master.


Fix some typos

I am submitting

[ ] a new package
[x] an update for a package

Fix some typos.

I have read and followed the submission guidelines and, in particular, I

[x] selected a name that isn't the most obvious or canonical name for what the package does
[x] added a typst.toml file with all required keys
[x] added a README.md with documentation for my package
[x] have chosen a license and added a LICENSE file or linked one in my README.md
[x] tested my package locally on my system and it worked
[x] excluded PDFs or README images, if any, but not the LICENSE

The PR doesn't contain any changes.

OK, I will close this PR.


please support django 4.0

https://docs.djangoproject.com/en/4.0/releases/4.0/

I'm using Djoser with Django 4.0.
At first, when I installed Djoser there was an error about importing force_text.
When I "pip install djoser"
due to dependency pip install older version of social-auth-app-django 4.0.0
so I tried uninstalling social social-auth-app-django and install it again to get social-auth-app-django  version 5.0.0
There is a warning that djoser requires social-auth-app-django below version 5.0.0
I just ignore it.
Everything seems to be working fine.

django-templated-mail is one of the dependencies of djoser and currently lists django 2.1 as the latest supported edition (https://django-templated-mail.readthedocs.io/en/latest/getting_started.html#supported-django-versions). Should that dependency also be upgraded?
I'm asking because additionally we use django-templated-mail as a direct dependency.

In Django 4.0.4 While the adding Djoser to the urls I got this error which cant be fixed
urlpatterns = [
     path('auth/', include('djoser.urls')),
    path('auth/', include('djoser.urls.jwt')),
    path('auth/', include('djoser.social.urls')),
]

I think it cant be fixed.. Because of version problems..
Exception in thread django-main-thread: Traceback (most recent call last):   File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/threading.py", line 932, in _bootstrap_inner     self.run()   File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/threading.py", line 870, in run     self._target(*self._args, **self._kwargs)   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/django/utils/autoreload.py", line 64, in wrapper     fn(*args, **kwargs)   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/django/core/management/commands/runserver.py", line 134, in inner_run     self.check(display_num_errors=True)   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/django/core/management/base.py", line 487, in check     all_issues = checks.run_checks(   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/django/core/checks/registry.py", line 88, in run_checks     new_errors = check(app_configs=app_configs, databases=databases)   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/django/core/checks/urls.py", line 14, in check_url_config     return check_resolver(resolver)   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/django/core/checks/urls.py", line 24, in check_resolver     return check_method()   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/django/urls/resolvers.py", line 480, in check     for pattern in self.url_patterns:   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/django/utils/functional.py", line 49, in __get__     res = instance.__dict__[self.name] = self.func(instance)   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/django/urls/resolvers.py", line 696, in url_patterns     patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/django/utils/functional.py", line 49, in __get__     res = instance.__dict__[self.name] = self.func(instance)   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/django/urls/resolvers.py", line 689, in urlconf_module     return import_module(self.urlconf_name)   File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/importlib/__init__.py", line 127, in import_module     return _bootstrap._gcd_import(name[level:], package, level)   File "<frozen importlib._bootstrap>", line 1014, in _gcd_import   File "<frozen importlib._bootstrap>", line 991, in _find_and_load   File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked   File "<frozen importlib._bootstrap>", line 671, in _load_unlocked   File "<frozen importlib._bootstrap_external>", line 783, in exec_module   File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed   File "/Users/joy/Dev/Projects/College-Ecommerce/backend/backend/urls.py", line 31, in <module>     path('auth/', include('djoser.urls')),   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/django/urls/conf.py", line 38, in include     urlconf_module = import_module(urlconf_module)   File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/importlib/__init__.py", line 127, in import_module     return _bootstrap._gcd_import(name[level:], package, level)   File "<frozen importlib._bootstrap>", line 1014, in _gcd_import   File "<frozen importlib._bootstrap>", line 991, in _find_and_load   File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked   File "<frozen importlib._bootstrap>", line 671, in _load_unlocked   File "<frozen importlib._bootstrap_external>", line 783, in exec_module   File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/djoser/urls/__init__.py", line 1, in <module>     from .base import urlpatterns   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/djoser/urls/base.py", line 4, in <module>     from djoser import views   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/djoser/views.py", line 44, in <module>     class UserViewSet(viewsets.ModelViewSet):   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/djoser/views.py", line 45, in UserViewSet     serializer_class = settings.SERIALIZERS.user   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/djoser/conf.py", line 19, in __getattribute__     val = import_string(val)   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/django/utils/module_loading.py", line 30, in import_string     return cached_import(module_path, class_name)   File "/Users/joy/Dev/Projects/College-Ecommerce/vEnv/lib/python3.8/site-packages/django/utils/module_loading.py", line 15, in cached_import     import_module(module_path)   File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/importlib/__init__.py", line 127, in import_module     return _bootstrap._gcd_import(name[level:], package, level) ModuleNotFoundError: No module named 'accounts'

Is there any update for this?? I am also facing the "ImportError: cannot import name 'force_text' from 'django.utils.encoding', in offline environment I just simply replaced the force_text to force_str, but I'm currently working in docker environment, wondering how I can fix this issue on my docker.

I don't know if this is the best solution, but what I did was pip uninstall
djoser, clone the djoser repository and move it into my project just like
another django app. The latest code fixes most issues but is not an
official release(So keep that in mind). I have comprehensive tests for my
project so this wasn't an issue as the tests passed after this change. Also
had to pip install django-templated-mail.
If you don't want to do this, you have to downgrade to django 3 or do some
sketchy renames of those functions which I'm not a fan of.
Another option is to use something other than djoser.
On Tue, 28 Feb 2023, 9:07 am Alice, @.***> wrote:

Is there any update for this?? I am also facing the "ImportError: cannot
import name 'force_text' from 'django.utils.encoding', in offline
environment I just simply replaced the force_text to force_str, but I'm
currently working in docker environment, wondering how I can fix this issue
on my docker.
—
Reply to this email directly, view it on GitHub
https://github.com/sunscrapers/djoser/issues/637#issuecomment-1447817929,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO4A7D7OO2SNF3OM5Z32NR3WZW53PANCNFSM5K7CRFUQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@snnbotchway Thank you for the comment! I solved it with @chusek9 's solution. I realized we're using Pipfile inside our dokcer environment, so I installed social-auth-app-django version 5.0.0 using pipenv, and it works perfectly fine! 😄

That's great!
On Tue, 28 Feb 2023, 5:43 pm Alice, @.***> wrote:

@snnbotchway https://github.com/snnbotchway Thank you for the comment!
I solved it with @chusek9 https://github.com/chusek9 's solution. I
realized we're using Pipfile inside our dokcer environment, so I installed
social-auth-app-django version 5.0.0 using pipenv, and it works perfectly
fine! 😄
[image: image]
https://user-images.githubusercontent.com/30956835/221934461-e590ccc9-0f1f-4886-b08c-1bb4dedec1f7.png
—
Reply to this email directly, view it on GitHub
https://github.com/sunscrapers/djoser/issues/637#issuecomment-1448601985,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO4A7D6CE2EVZSRRHKL45V3WZY2N7ANCNFSM5K7CRFUQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


chore(project): update watchlists docs

Description

docs update

Steps completed:

According to our definition of done, I have completed the following steps:

[ ] User stories met
[ ] Storybook stories
[ ] Unit tests added
[ ] Linting passing
[ ] Unit tests passing
[ ] Docs updated (including config and env variables)
[ ] Translations added
[ ] UX tested
[ ] Browsers / platforms tested
[ ] Rebased & ready to merge without conflicts
[ ] Reviewed own code

Thanks Anton.
I added some comments. Also the example request is autodated.

@marcovandeveen thanks for the comments! I fixed the issues you found.


What are the plans about T10?

Is there some kind of roadmap or direction this project is heading to?
Are there any plans for IoC or incorporate new Prism goodies?

"Template 10 is intended to remove the boilerplate garbage we all have to write over and over; it packs in as many time-saving lessons-learned as possible for app developers" (from http://aka.ms/template10) ,
so I don't see that the Library will integrate Prism or any IoC. Of course, we could add samples to demonstrate integration with Prism or our favorite DI container

Like which Prism goodies?

Event aggregation, Regions ... I don't really know. Maybe I am missing IoC and that led me to this question.
@MichaelPetrinolis I think I can handle the IoC integration and no samples are needed, but thanks for your suggestion. I guess most of the developers can integrate IoC in their projects, but if there are plans for future integrations they can wait some time (like me) for example than refactoring the code when such feature is implemented.
A separate nu-get package introducing IoC integration like Prism is maybe a good idea. Since both packages (Template10 and Prism) are developed actively by Microsoft it seems natural for me that they can cooperate together flawlessly. But at the current state both provide 60% common functionality and mixing it together can lead to "dead" (unused) code or confusions.
I am closing this since I answered this question for myself. Keep up the good work.

Hi @soeron , just a small correction: Prism isn't anymore developed by Microsoft. Now it's an open source project maintained by the community. You can read more on the official repository https://github.com/PrismLibrary/Prism


fiona.open returns empty data for some GPX files with tracks (trk/trkseg/trkpt)

Expected behavior and actual behavior.
I expect a .GPX file with  data to open and include data with geometry. I can open a .GPX file with tracks but no data is returned.
Steps to reproduce the problem.
I'm new to fiona and so far its been working well for most .gpx files with wpt data, however i'm getting no features or geometry data returned for files with tracks data. An empty [] is returned via:
print(list(geo))
How I'm opening the file:
with fiona.open(file) as geo:
I also tried:
adding driver='GPX' as well as
with fiona.open(file, layer='tracks') as geo: and with fiona.open(file, layer='track_points') as geo: per this thread:
https://github.com/Toblerity/Fiona/issues/921 but I still am not able to return data with fiona.open
Here's an example file source which has valid tracks data but will not return data on open:
https://www.alltrails.com/trail/us/oregon/tumalo-creek-trail-to-tumalo-falls
Goto: "More" > "Download Route" > "GPX"
This also returns an empty array on open: https://github.com/Toblerity/Fiona/blob/master/tests/data/test_gpx.gpx
The GPX file(s) open fine in QGIS.
Anyone know how I can fix this? Is there a function to validate the layer before I try to open it? I tried listlayers and I can see that the tracks layer exists.
Operating system
Mac OSX 11.5.2
Fiona and GDAL version and provenance
Fiona ver 1.8.20 installed via poetry
GDAL ver  3.3.2

Belatedly, I can't reproduce this with 1.9.1.
python
Python 3.11.0 (main, Nov  2 2022, 11:35:09) [GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import fiona
>>> with fiona.open("tests/data/test_gpx.gpx", layer="tracks") as collection:
...     print(list(collection))
...
[<fiona.model.Feature object at 0x7f731e2e7190>]
>>> fiona.show_versions()
Fiona version: 1.9.2dev
GDAL version: 3.5.3
PROJ version: 9.0.0

OS: Linux 5.14.0-1057-oem
Python: 3.11.0
Python executable: '/home/seangillies/projects/Fiona/venv/bin/python'

Nor with 1.8.20
Python 3.11.0 (main, Nov  2 2022, 11:35:09) [GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import fiona
>>> with fiona.open("tests/data/test_gpx.gpx", layer="tracks") as collection:
...     print(list(collection))
...
[{'type': 'Feature', 'id': '0', 'properties': OrderedDict([('name', 'Running 6/11/14 8:19 am'), ('cmt', None), ('desc', None), ('src', None), ('link1_href', None), ('link1_text', None), ('link1_type', None), ('link2_href', None), ('link2_text', None), ('link2_type', None), ('number', None), ('type', None)]), 'geometry': {'type': 'MultiLineString', 'coordinates': [[(-71.108203, 42.361951), (-71.10837, 42.361797), (-71.108543, 42.361615), (-71.108731, 42.361451), (-71.108968, 42.361341), (-71.109162, 42.361474), (-71.10933, 42.361612), (-71.109529, 42.361751), (-71.109774, 42.36188), (-71.109991, 42.362007), (-71.110213, 42.362115), (-71.110484, 42.36218), (-71.110728, 42.362205), (-71.110988, 42.36232), (-71.11117, 42.362467), (-71.111344, 42.36264), (-71.111519, 42.362799), (-71.111772, 42.362837), (-71.111994, 42.362716)]]}}]
>>> fiona.show_versions()
Fiona version: 1.8.20
GDAL version: 3.5.3
PROJ version: 9.0.0

OS: Linux 5.14.0-1057-oem
Python: 3.11.0
Python executable: '/home/seangillies/projects/Fiona/venv/bin/python'

It might have been a defect in the 1.8.20 wheel. I'm marking this "invalid" only because it's not a fiona bug, I'm not saying that your report or experience is invalid.


Support hosts file encoded in unicode format

Expected behavior
Netty should be able to resolve IP address from hosts file when the file is encoded in unicode format.
Java is able to resolve hostname from unicode encoded hosts file. Disabling Vertx (Netty) hostname resolution using -Dvertx.disableDnsResolver=true flag in our application was the workaround that we used, until we finally identified root cause.
Actual behavior
HostsFileParser.parseSilently() returns HostsFileEntries instance with zero entries if the hosts file is encoded in unicode format.
Steps to reproduce
Open hosts file with text editor (Eg. Windows Notepad) as Administrator.
Save hosts file with unicode encoding.
Run the reproducer and observe the console output.
Minimal yet complete reproducer code (or URL to code)
https://github.com/ramtech123/pocs/tree/master/netty-hosts-reproducer
Netty version
4.1
JVM version (e.g. java -version)
Java 1.8
OS version (e.g. uname -a)
Tested with Windows10, Windows Server 2012, 2016

@ramtech123 thanks.. Check https://github.com/netty/netty/pull/8211. This allows you to specify the charset to use while decoding.

Based on my own testing with Windows Server 2016, it seems like Windows auto-detects the encoding. I tried with ANSI (ASCII), Unicode (UTF-16), and UTF-8 and they all worked. I saved a trash hostname in hosts (different for each test) and then did a ping. Ping noticed my trash hostname configuration each time.

https://serverfault.com/a/452269 seems to think that the encoding should be UTF-8. I wonder if Windows became more permissive in a later version of Windows. I wasn't able to find any official documentation as to the encoding.

@ejona86 I mean what we could do is test UTF-8, ASCII, Unicode (in this order) until we were able to parse something when on windows... WDYT ?

@ejona86 , I also could not find any standards around hosts file encoding. The comment here https://serverfault.com/questions/926706/is-there-any-ietf-rfc-standard-defined-for-hosts-file-encoding indicates it never had a formal standard.
@normanmaurer just curious about "...until we were able to parse something when on windows" - don't we expect this situation in non-Windows machine?

@ramtech123 I never heard of using something linux unicode for /etc/hosts.

ok

@normanmaurer, that sounds like it would work. Note that ASCII doesn't get you anything over UTF-8. Although Latin-1 or similar would, which may be the system's default encoding (dunno). And to be precise, "Unicode" would be "UTF-16" (probably UTF-16LE).
Linux has been using UTF-8 for a really, really long time now. I did dig through glibc a very quick amount and it looks like it just used the system encoding in normal C-style ("does this char* look like this char*?").
In both cases, using actual unicode codepoints may not be at issue (at which point UTF-8 vs some-random-codepage are the same). It sounds like @ramtech123 mainly suffered issue because the file was encoded with UTF-16.

@ejona86 PTAL https://github.com/netty/netty/pull/8211 again


Legacy Authentication protocols

Please provide  listing of the authentication protocols that are considered to be Legacy.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ad5f26dc-2f8f-ef76-3d20-a0a42d2bbada
Version Independent ID: a0e971d1-05f2-2c21-06d4-60c087d45c0a
Content: Set up SharePoint Online and Exchange Online for Azure Active Directory conditional access
Content Source: articles/active-directory/active-directory-conditional-access-no-modern-authentication.md
Service: active-directory
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@DeanGross Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@DeanGross we have opened a work item in our internal backlog to have this item tracked for an upcoming sprint. We'll comment on this issue when the work is completed to notify you. For now, to avoid double-tracking, we'll close the issue here.
#please-close

+1 @DeanGross we are also trying to secure Exchange Online and also need to understand what legacy protocols exist.


Native Mode migration step by step guide end user experience gaps

Hello All
In the below article
https://learn.microsoft.com/en-us/yammer/configure-your-yammer-network/native-mode-step-by-step-guide
Section
Tracking Alignment Tool Progress
It says
The Alignment Tool will run in the background of your system and should not cause any noticeable impact for end users.
Can you please help by adding some more clarification there, because the customers are raising the questions:
Will the end user experience with Yammer/Viva Engage be entirely uninterrupted?
What will happen if content is being added/updated/removed during the migration process, how is this going to align on the completion phase?
After the migration is completed, can we presume that the end user will not be asked to reauthenticate or anything like that?
Can end users expect any kind of notifications - Yammer/Viva Engage/Outlook - during the process

@vstanche
For the article that you're providing feedback, we recommend checking the Microsoft Feedback Forum and submitting it there if it has not already been submitted:

Microsoft Viva Engage

Another option is visit the Yammer help center.
Thanks!


Revert "Remove the canary weight"

Reverts zooniverse/panoptes#3442
We want the canary deploy to only be reachable via the cookie presence. Removing the weight will modify how the traffic is routed.
We want the canary to only be reachable while the header is set, if it's missing we don't want traffic to hit the canary inadvertently.

Why is the weight necessary to prevent normal, cookie-less traffic from being correctly routed?

Why is the weight necessary to prevent normal, cookie-less traffic from being correctly routed?

Good question - I haven't tested but my memory is that without a weight it does round robin between the canary and the other upstreams. This is most likely incorrect as docs don't mention it,  and tbh without any setting it's most likely ignoring the canary for traffic distribution. It would be good to test this.
That said, explicitly setting the weight to 0 also ensures we never use the weight preference to distribute traffic to the canary. Only the cookie / header will ever force the canary to be used which is what we want for testing this via cookie opt in.

nginx.ingress.kubernetes.io/canary-by-cookie: The cookie to use for notifying the Ingress to route the request to the service specified in the Canary Ingress. When the cookie value is set to always, it will be routed to the canary. When the cookie is set to never, it will never be routed to the canary. For any other value, the cookie will be ignored and the request compared against the other canary rules by precedence.

Canary rules are evaluated in order of precedence. Precedence is as follows: canary-by-header -> canary-by-cookie -> canary-weight

(https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/#canary)
Doesn't sound necessary to include a weight and seems to be working as intended on staging, but I'll test it bit more this afternoon.

nginx.ingress.kubernetes.io/canary-by-cookie: The cookie to use for notifying the Ingress to route the request to the service specified in the Canary Ingress. When the cookie value is set to always, it will be routed to the canary. When the cookie is set to never, it will never be routed to the canary. For any other value, the cookie will be ignored and the request compared against the other canary rules by precedence.

Canary rules are evaluated in order of precedence. Precedence is as follows: canary-by-header -> canary-by-cookie -> canary-weight

(https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/#canary)
Doesn't sound necessary to include a weight and seems to be working as intended on staging, but I'll test it bit more this afternoon.

Excellent - if we can verify the canary is only hit when the cookie is present and never without a cookie present, then this can close. It's really important for production testing we don't allow the canary to be hit by normal users. Let us know what your tests indicate.


Prepare build for deployment to maven central

Process is not yet automated.
Deployment is possible using manual cli
Maven appears to attempt to deploy modules which should not be deployed (aspects, examples, sandbox)
Reflection issues with nexus-staging-maven-plugin and Java 17 need to be investigated


Overlapping Navigationbar and Tabbar

HI,
I found another problem, see screenshot.
The animation is overlapping Navigationbar and Tabbar.
Greetings,
Stefan

@Urkman : This feature might take some time, I will fix it and publish new release asap. Thanks!

@tungvoduc  How to fix this animation ? s it possible to do everything the same, but only without switching to a new ViewController ? Or, for example, to make so the image first gets out from under the NavigationBar, and back

@sLm-s This could be done by using navigationController's pushViewController(_:animated:) instead of using present(:animated:completion:) like Photos app. But this requires some amount of work so I will see if I have time at some point and implement it.

@tungvoduc Thanks I will wait with impatience.

Maybe we could learn from iOS it self?
https://user-images.githubusercontent.com/25259084/167241039-29c08356-1b48-4423-8408-c69f7e6d2cd1.mp4
Make a copy from the view and fade it out.

Currently I'm using a workaround, copy a image and make it centered with it's parent with size 0 for animation. It works great.


Designated Inputs and Outputs

Is there anything on the cards to be able to link inputs to labels or objects inside the node.
Functionality:

Linking inputs to specific labels represented as objects in the node for both input and output
Rearange line links when input objects change position

Before rearange

After rearange

This is likely possible by hacking the system and physically moving a node into another node and just piggybacking off the base functionality, but if it's natively supported, that would be nice

1: Here is an example of how to align output to element.

https://github.com/jerosoler/Drawflow/issues/363#issuecomment-1050699201

2: I don't understand.
But you can detect node movements using the nodeMoved event

Interesting, ok that will work for what I need, thanks :)
Point to is then not important.
On a side not in relation to this, Is it possible to give connection ports custom name?
For example, connection ports are currently labeled input_, output_ so when it's exported it exports as
json {     "inputs":{         "input_1":{             "connections":[                  {                      "node":"2",                      "input":"output_1"                  }             ]         }     } }
Assigning a custom name value like "input_username"
The expected export
json {     "inputs":{         "input_username":{             "connections":[                  {                      "node":"2",                      "input":"output_1"                  }             ]         }     } }

Cannot currently be assigned a name. They need to have a number.
But you could add information like this:
editor.drawflow.drawflow.Home.data[1].outputs["output_1"].name = "output_username";

Another way would be saving the data in the information
editor.addNode('NodeA', 1, 1, 440, 300, 'NodeA', { outputsname: { 1: "output_username "}}, 'NodeA');

Very cool, ok I'll play around with that, thanks for the assistance.
Steller project, can't wait to see where it goes.


Support Questions

Starting a large project and curious about some of these questions:

how does native jsonb support work? Are the fields mapped differently somehow? Any gotchas?

is graphql-js a dependency so we can always get there latest community updates or does this project user a fork or its own implementation?

is there an easy way to use es6/es7 syntax? Any pointers to custom schemas/queries with es6/7?

do you know if there are any issues using AWS postgres over rds or Aurora?

Thank you in advance

how does native jsonb support work? Are the fields mapped differently somehow? Any gotchas?

JSON and JSONB support just emits the JSON string in the response. If you want the JSON object and not just the string you can pass the --dynamic-json flag. In GraphQL all JSON fields will have a custom scalar Json type 😊

is graphql-js a dependency so we can always get there latest community updates or does this project user a fork or its own implementation?

Yep! We even have a version range that is more flexible then what is the default for 0.x packages https://github.com/calebmer/postgraphql/blob/54879f694b3918d256fedf84071703ea4dd5ec10/package.json#L42

is there an easy way to use es6/es7 syntax? Any pointers to custom schemas/queries with es6/7?

I’m not sure what you mean by this. Do you want a build artifact of PostGraphQL that is ES2015/ES2016 instead of ES5, or would you like to use PostGraphQL in an ES2016 project?

do you know if there are any issues using AWS postgres over rds or Aurora?

RDS supports Postgres which is a good option and Aurora is MySQL (right?). PostGraphQL currently doesn’t support MySQL. RDS is great and I believe it is the top choice for most of PostGraphQL users.

Let me know if you have any more questions 👍

I'm running PostGraphQL on RDS in production; and my code's written in ES2015+ 👍

Hello ,
I have installed PostGraphQL on an ec2 instance , and I am watching a schema on a RDS .It is working , and I get  the usual message GraphiQL endpoint served at http://localhost:5000/graphiql .I need some guidance in order to proceed further . How can I now use the graphiql ?
Thank you

This might be a good place to start:
https://medium.com/the-graphqlhub/graphiql-graphql-s-killer-app-9896242b2125
Also check out:
https://www.howtographql.com/

Hello ,
Does one need to access the public IP address of ec2 instance , in order to send queries or to test it via graphiql ?

It sounds like you shouldn't start with an EC2 instance.  Try to figure out how to connect postgraphql to a local database.  The process is the same for RDS

Setup postgraphql locally, first.  It sounds like your EC2 security group is getting in the way.  You need to be able to access the ports on the server that's hosting postgraphql -- postgraphql is running a NodeJS express server and you have to be able to talk to the server to see the response.

Thank you for helping me .I did set up an express server , serving a static file on port 5000 , and it works , when accessing http://ec2-......compute.amazonaws.com:5000/ .Shouldn't I be also  able to access http://ec2-......compute.amazonaws.com:5000/grapiql ? like usual , on localhost , and send queries ?

The URL you placed has a typo: /graphiql. So long as you've not passed --disable-graphiql (-b) then yes, you should be able to visit /graphiql if you are successfully running postgraphql on port 5000 on your EC2 host. What happens when you visit just /graphql (no i)?

When I visit http://ec2-......compute.amazonaws.com:5000/graphql or http://ec2-......compute.amazonaws.com:5000/graphiql
I get
This site can’t be reached
ec2...compute.amazonaws.com refused to connect.
But when I visit  http://ec2-......compute.amazonaws.com:5000/ , and I am running on this port my own express server , I get a normal response from my server .

Thank you for your help .
I am using now  postgraphql as a middleware in a node.js app and I can post
queries to graphql endpoint .
I do have an additional question . I am still unable to use GraphIQL
interface .
I am using this code :
const postgraphql = require('postgraphql').postgraphql;
<EMAIL_ADDRESS>schemaName='name', {graphiql:true}));
What is the difference between
const postgraphql = require('postgraphql').postgraphql;
and
const postgraphql = require('postgraphql').default ;
Any sugestions ?
Thank you
On Wed, Dec 6, 2017 at 11:46 AM, Benjie Gillam<EMAIL_ADDRESS>wrote:

The URL you placed has a typo: /graphiql. So long as you've not passed
--disable-graphiql (-b) then yes, you should be able to visit /graphiql
if you are successfully running postgraphql on port 5000 on your EC2 host.
What happens when you visit just /graphql (no i)?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/postgraphql/postgraphql/issues/362#issuecomment-349587490,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgsnU0QtIc4OYfGMFJtlpEpmEbaVwrKXks5s9mJkgaJpZM4MFsZZ
.

What is the difference between const postgraphql = require('postgraphql').postgraphql; and const postgraphql = require('postgraphql').default ;

Nothing: https://github.com/postgraphql/postgraphql/blob/master/src/index.ts#L3-L6

I do have an additional question . I am still unable to use GraphIQL interface

The code you've used should work:
const postgraphql = require('postgraphql').postgraphql;
app.use(postgraphql(process.env.DATABASE_URL,
process.env.SCHEMA_NAME, { graphiql: true }));

That should result in /graphiql serving up the page. Maybe you could detail exactly what error you're getting - what does the /graphiql endpoint return?

It works , indeed .
Thank you for your answer .
On Fri, Dec 15, 2017 at 3:28 PM, Benjie Gillam<EMAIL_ADDRESS>wrote:

What is the difference between const postgraphql = require('postgraphql').
postgraphql; and const postgraphql = require('postgraphql').default ;
Nothing: https://github.com/postgraphql/postgraphql/blob/
master/src/index.ts#L3-L6
I do have an additional question . I am still unable to use GraphIQL
interface
The code you've used should work:
const postgraphql = require('postgraphql').postgraphql;app.use(postgraphql(process.env.DATABASE_URL,process.env.SCHEMA_NAME, { graphiql: true }));
That should result in /graphiql serving up the page. Maybe you could
detail exactly what error you're getting - what does the /graphiql
endpoint return?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/postgraphql/postgraphql/issues/362#issuecomment-352005591,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgsnU5co8qkNX50xPzqtldL8LKFl2pXjks5tAnP8gaJpZM4MFsZZ
.

Could you tell me what was wrong so I know how to advise the next person who has this issue please?

Hello ,
Sorry for the late answer , I did not expect an other reply from you , so I
did not check this mail anymore .
The code worked , as expected , I probably forgot to reload . It was my
mistake .
I do have an additional question , if possible . When setting it up in a
local environment , and using
const host ='postgres://user:password@localhost:5432/dbName ';
app.use(postgraphql(host,schemaName='schemaName',{graphiql:true}));
It does not work , even if the command postgraphql -c
postgres://user:password@localhost:5432/dbName -s schemaName
does give me the expected results . I have tried serving from port 3000 but
also from port 5000 .
What should I do ?
Thank you , again ...
On Fri, Dec 15, 2017 at 4:50 PM, Benjie Gillam<EMAIL_ADDRESS>wrote:

Could you tell me what was wrong so I know how to advise the next person
who has this issue please?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/postgraphql/postgraphql/issues/362#issuecomment-352024248,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgsnU_tiCgOuZfMSCwtlQ7oz6XP4tj1jks5tAodLgaJpZM4MFsZZ
.

Could you expand on “it does not work”? That’s rather vague so it makes it hard to diagnose. Maybe share the full source of the file also.

Thank you for your answer . It's really helpful to not be alone and have
someone to ask questions .
It does not work in the sense that I can not access graphiql interface when
visiting localhost:3000/graphiql or localhost:5000/graphiql  .
The only thing that I changed is the uri : const host =
<EMAIL_ADDRESS>One of the things that I do not understand , is that , when  running the
node server on port 3000 , should I go in the browser for
localhost:5000/graphiql ? or port 3000 ? Because the command
postgraphql -c .....
displays graphiql on port 5000 ...
I know it's not a smart question .But it does not display the graphiql
interface on neither ..
On Thu, Dec 28, 2017 at 8:06 PM, Benjie Gillam<EMAIL_ADDRESS>wrote:

Could you expand on “it does not work”? That’s rather vague so it makes it
hard to diagnose. Maybe share the full source of the file also.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/postgraphql/postgraphql/issues/362#issuecomment-354329758,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgsnUyC1k-EbwIbc62TyBH8cZ1eqjq8cks5tE9iSgaJpZM4MFsZZ
.

Addendum : when visiting localhost:5000/graphiql I get the error TypeError:
Failed to fetch .This is when node server is listening on port 5000.
When app listening on port 3000 en I visit ocalhost:3000/graphiql I get the
error TypeError: Failed to fetch .
In both cases , it fails when posting query IntrospectionQuery .
On Thu, Dec 28, 2017 at 8:34 PM, timon ionutadamclisi <
<EMAIL_ADDRESS>wrote:

Thank you for your answer . It's really helpful to not be alone and have
someone to ask questions .
It does not work in the sense that I can not access graphiql interface
when visiting localhost:3000/graphiql or localhost:5000/graphiql  .
The only thing that I changed is the uri : const host =
<EMAIL_ADDRESS>One of the things that I do not understand , is that , when  running the
node server on port 3000 , should I go in the browser for
localhost:5000/graphiql ? or port 3000 ? Because the command
postgraphql -c .....
displays graphiql on port 5000 ...
I know it's not a smart question .But it does not display the graphiql
interface on neither ..
On Thu, Dec 28, 2017 at 8:06 PM, Benjie Gillam<EMAIL_ADDRESS>wrote:

Could you expand on “it does not work”? That’s rather vague so it makes
it hard to diagnose. Maybe share the full source of the file also.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/postgraphql/postgraphql/issues/362#issuecomment-354329758,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgsnUyC1k-EbwIbc62TyBH8cZ1eqjq8cks5tE9iSgaJpZM4MFsZZ
.

Your const host specifies http://; presumably you meant postgres://?
Please share the code you’re running, I’m getting quite confused between postgraphql commands and running it as an express app. Please also share the terminal output and the URL you are visiting and the browser output (e.g. a screenshot) - take me through everything step by step with screenshots or copy/paste of terminal/code.
Also please try connecting to your RDS host from psql on the command line:
psql<EMAIL_ADDRESS>And run an SQL query such as select 1+2

AWS Aurora supports postgres now, but they don't yet allow the wal2json plugin according to this page:
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/Aurora.AuroraPostgreSQL.Compare.html
That seems to rule out live queries for now. But subscriptions should still work, right?

Hopefully; I’ve yet to use Aurora. You could implement a triggers version of live queries; it’s all quite modular. (You’d have to write the code though!) RDS supports wal2json.


Investigate the storage.openFiles.limit OrientDB messages that we're seeing

Task Description
We are seeing the following seemingly benign (warning?) message a lot lately:
18:55:00.454 23-05-2019 | DEBUG | t (/<IP_ADDRESS>:59914) | unknown.jul.logger | Reached maximum of opened files 513 (max=512), closed 1 files. Consider to raise this limit by increasing the global setting 'storage.openFiles.limit' and the OS limit on opened files per processor

This needs to be investigated and a fixed.
Task Relationships
This task might potentially be related to #1120 and we might have to upgrade to a newer version of OrientDB.
Help

Our chat
Points of contact:

@carlspring
@sbespalov
@fuss86

After reading a little in the Orient manual and docs i think the quick fix might be to simply set the value higher in the config orientdb-server-config.xml but i am not sure if that wont repeat if the new higher value is reached due to not closing the files, but i dont have enough background informations on what exactly is happening with the files

Hi @Sorcecoder ,
Would you like to play around with it and try to fix it?

Hi @carlspring ,
I sent you a new info about this warning in the chat.
In a nutshell, previously from my Linux configuration the warning used to appear from time to time. Now it disappeared completely

This is probably related to the running user's ulimit of maximum number of open file descriptors.  You can check it with ulimit -n

Is this still an issue?

No. I will close it, thanks!


Adding qs3

There are a few items to review :

UITableView's implementation for messages
Socket.io bug fix
joining
typing indicator

@ChrisGuzman I updated following the review.

@ericgiannini next time can you do one commit for project and cocoapods update stuff than other commits for changes. github doesn't cope well with 1k+ loc changes

No problem! ;) Would you like me to exclude the Pod from Git tracking?
On Wed, Apr 18, 2018 at 8:44 AM, Shams Ahmed<EMAIL_ADDRESS>wrote:

@ericgiannini https://github.com/ericgiannini next time can you do one
commit for project and cocoapods update stuff than other commits for
changes. github doesn't cope well with 1k+ loc changes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Nexmo/conversation-ios-quickstart/pull/7#issuecomment-382433413,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMCHta92O2KVLSrzu31RZSzZF1-NoqJ3ks5tp19ogaJpZM4S_mEf
.


Add PR template

Type of change
Select the type of your PR

[ ] Bugfix
[x] Enhancement / new feature

Description
This PR adds a template for further PRs. It should help to make sure that no important aspects are missed during development / review.
Checklist
_Please go through this checklist and make sure all aplicable tasks have been done

[x] Write tests!
[x] Make sure all tests pass!
[x] Check coding style!
[x] Update documentation!
[x] Check RBAC rights for Kubernetes / OpenShift roles!
[x] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally!

@ppatierno This template is just for PRs. We can have another template for issues. I felt that in PR distinguishing of bugfix or new feature is important with respect how many new tests or documentation it requires. That is why I added it there. If needed, expected and actual behaviour or reproducing steps could be written in description. But I think they should be primarily in the Issue and not in PR.

@scholzj you are absolutely right. Another template is needed for issues not PRs ... sorry ... thinking about that when being on PTO drove me wrong :)


Add additional NWB export pytests

See https://github.com/datajoint/workflow-array-ephys/pull/18

Duplicate issue #52 content:

The current pytests use subject5 which is SpikeGLX data.
The current pytests are comprehensive and there are minimal differences between SpikeGLX and Open Ephys data once in the DataJoint Elements tables, but it would be good to also add pytests for Open Ephys data for when loading from source files.


nm.checkpoint: drop dependency on python-dbus

Signed-off-by: Fernando Fernandez Mancera<EMAIL_ADDRESS>

This PR is based on #236 from @cathay4t. I couldn't rebase or cherry-pick it because there were too many conflicts. If he agrees, I will add his "Signed-off-by". Thanks!

And the CI is failling due to some checkpoint issue. Please investigate.

And the CI is failling due to some checkpoint issue. Please investigate.

Yes I found out the issue. It is failing with the new MainContext, fixing it. Thanks!

I found an issue in ActiveConnection. Fixing it. It is required to continue with this patch.

@cathay4t I've found a way to do this using the signal from nm_dev. I am testing it and will be ready by tomorrow morning. Thanks!

/packit copr-build

@cathay4t Packit build is failing due to a major issue in Copr. It is affecting everyone.

The CI still fails on test_disable_static_ipv6_and_rollback


Add support for the disabled input attribute

Resolved in https://github.com/Blooie/ember-radio-buttons/issues/6


Temporary gear tar file upload and downloads endpoints

Fixes #822
Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

Requirements:

[ ] Add GearPlacer class that adds the file in the form to the CAS and returns the metadata (gear manifest) and information about where it stored the file
[ ] Add upload function to jobs.handlers.GearHandler that calls GearPlacer class, and then calls jobs.gears.upsert_gear with the metadata it gets from GearPlacer.
[ ] Add a new key to gear objects in the gears collection that stores it's location in the CAS
[ ] Add download function to jobs.handlers.GearHandler that serves the file from the CAS
[ ] Ensure only admin level users can call either of these endpoints

Looks good other than the one change I mentioned, but @kofalt should give the final sign off.
Thanks for helping out with stuff for the demo!

Thanks for your quick work Harsha.


Dec 795

I updated the page image captioning and css on both beehive and honeycomb.

👍

👍

Coverage remained the same at 96.022% when pulling 54af2ab68f74cb1267a66f1e48992a21a33494a5 on DEC-795 into 8435ac8e9f1f12f80a6905a7c973b8c19913ccb2 on master.

Coverage remained the same at 96.022% when pulling 54af2ab68f74cb1267a66f1e48992a21a33494a5 on DEC-795 into 8435ac8e9f1f12f80a6905a7c973b8c19913ccb2 on master.


Document the integration with LetsEncrypt

URL for relevant page?
https://docs.influxdata.com/influxdb/v1.0/administration/config#https-certificate-etc-ssl-influxdb-pem
Where did you look before opening the issue?
https://github.com/influxdata/influxdb/issues/7283
TL;DR
Something like this could be added to the docs:
To reuse .pem files created by Let's Encrypt, set the following in /etc/influxdb/influxdb/conf for the [http] section:
https-certificate = "/etc/letsencrypt/live/yourdomain.com/fullchain.pem"
### Use a separate private key location.
https-private-key = "/etc/letsencrypt/live/yourdomain.com/privkey.pem"

In the [admin] section, https-certificate should point to a file that concatenates fullchain.pem and privkey.pem. Note though https://github.com/influxdata/influxdb/issues/7284.

Thanks for the suggestions, @dandv. We're going to avoid the whole can of worms that gets opened by giving advice on how to set up SSL. Frankly it's not in our wheelhouse (too many distros, cert formats, etc.), so I'd rather folks get educated elsewhere on that.


Change default behaviour after removing a relation to other/foreign sign

When deleting an entry in one of the tables Relation to Other Signs / Relation to Foreign Signs, the system exits the edit mode and collapses the pane where the relations are. Change to staying in edit mode, and keeping open the Relations pane.

do the same for the deletion of entries in the Morphology table.

This turned out to be a matter of simply adding something like '?editrel' to the redirect url. However, it took me quite a while to figure this out, as well as WHERE this redirect was defined in the code.


Reset Container after running job (i.e. Current Hosted Agent behavior)

Is there a particular reason that the docker containers don't reset after running a job like the Hosted Agents do?
My expectation with the docker container is that it reset completely following job completion, which includes:

Cleanup of files in working directory (this seems to work today)
Environment is cleaned to container spec:

If I installed tree using apt-get, I expect that won't be installed on next run. As it currently stands, installing tree in a previous release, persists in next release which leads me to understand a dirty environment.

=========

Brand new Azure VM (Ubuntu 17.10), updated packages and installed Docker.

 Job does its tasks.

Next Release/Job, expecting Agent to be reset to the default with no persistence from previous job.

===========
Is there some sort of flag that needs to happen here to achieve parity with the Hosted (Linux) Agent behavior?

In the hosted (linux) queue, a separate service creates and managers the lifecycle of a container to run your job so you don't share a potentially modified environment with others.
As far as I know, there is not currently an official way to support your ask. We are moving to model where this is possible but unfortunately that is still WIP.
It is a bit awkward for a self-host container because VSTS would need to be able to tell your host machine when the build was complete, but there wont be such a service on your host. I quickly experimented with a build definition that had a final phase calling docker  kill/restart to kill the agent container, but if the agent get killed the build cant really finish.

On of the main reasons you choose to run your own Linux agent is actually so that you can avoid the limitation of hosted agents where they lose all the context between builds.  In the Docker container case, you can derive your own image from one of the base images and install "tree" or whatever other tools you need for your builds.
If the behavior of hosted agents is what you are looking for, then you probably want to be using the hosted agents instead of running your own agent.

In a team that practices DevOps, I can't ensure John doesn't introduce a dependency hell for Paul's pipelines and vice versa. So really, this logically is a bug with the VSTS docker container/really all the VSTS agents as they share modified environments with others. Agents shouldn't be "pets" but cattle. For some reason it was deemed proper to solve this for Hosted agents, but not for selfhosted agents (we do have multiple people working on projects folks).
Please consider reopening this request as it seems like a valid issue given nature of multiple member teams.
Blurb about our use case:
Our use case is we are looking to deploy Docker container in a private VNet that can talk to private servers hosted in onprem datacenters. Personally prefer endpoints to be in Azure, but still well in transition.
Re: Custom container - We are looking build on top of VSTS tooling and not fork. Sure, can run custom container with custom tools etc etc etc... but its loads more suitable to apt-install myspecialpony during a pipeline within a managed service offering. I'm not looking to fork VSTS repos/docker containers.
Retaining context between builds is really an anti-feature of pipelines and a problem-matic one for our teams. We work with team members thousands of miles away, pipelines would mysteriously break when an agent is reboot/recycled (experienced in other CI systems). A consistently clean environment is the first and foremost reason we use pipelines, it keeps the developers honest and builds consistent, everytime, everywhere, and on every agent (idempotent pipelines aside).

What you're asking for is not a request on the Docker containerization of the VSTS agent but the agent itself, so you'll be better off adding this feature request to the Microsoft/vsts-agent repository. @dakale can comment more, but I believe there are plans to move to a model where you have a single controlling VSTS agent which spins up an independent Docker container for each build, thus creating a lightweight isolated environment that is discarded after each build.
Until that is available, you could make use of the fact that Docker containers are lightweight to run and you could start up a number of different VSTS agents to be used by different members of your team, but all running on the same machine or set of machines. This isolates team member from each other , but you're not going to get idempotency.

I'll post it there, looking forward to the improved model @dakale .
but fwiw, I believe adding a monitor to the within docker container that looks for the "job completed" and does a docker kill/restart. This would be out of band of the job who called it (and won't stop the job being able to finish). May introduce a race condition though in registering the agent theoretically.

Yeah, that likely wouldn't work because it will end up constantly removing and re-adding agents in the agent pool, and it might end up missing jobs as a result.

hi,
I know this is closed but I had the same problem and solved it by running my agents like so:
if [ "$TFS_AGENT_DISPOSE" = true ]; then
  env_include+=( "Agent.Private=true" )
  ( env ${env_exclude[@]/#/-u } "${env_include[@]}" ./bin/Agent.Listener run & echo $! ) | ( trap 'kill "$pid"' EXIT; pid="$(head -1)"; sed -e '/Job Build completed with result/q')
else
  env ${env_exclude[@]/#/-u } "${env_include[@]}" ./bin/Agent.Listener run & wait $!
fi

This is an example only but should give a hint on how to get something like that working.

Here is an updated version of that monstrosity that runs as a system service on the docker host:
vstsdockermonitorservice.yml
- name: Install VSTS Docker Monitor service
  hosts: all
  gather_facts: no

  tasks:
  - name: Get local user
    run_once: True
    set_fact:
      ansible_local_user: "{{ lookup('pipe', 'id -un') | d(lookup('pipe', 'whoami'), True) | d(lookup('env', 'USER'), True) |  d(lookup('env', 'user'), True) |  d(lookup('env', 'LOGNAME'), True) }}"
    failed_when: ansible_local_user == ''

  - name: Add local user to docker group
    user:
      name: "{{ansible_local_user}}"
      groups: docker
      append: yes
      state: present
    become: true

  - name: Instantiate VSTS Docker monitor script
    file:
      path: /usr/local/bin/vstsdockermonitor.sh
      state: touch
      owner: root
      group: root
      mode: 0664
    become: true
    changed_when: false

  - name: Inject content into VSTS docker monitor script
    copy:
      content: |
        {% raw %}#!/bin/bash
        runningarray=()

        while :
        do

          activecontainers=( $(docker container list --format="{{.Names}}") )

          #Adding any new containers to cleaner function
          for obj in "${activecontainers[@]}"; do
              if [[ ! " ${runningarray[@]} " =~ " ${obj} " ]]; then
                echo "Adding $obj to monitoring for cleanup"
                /usr/local/bin/vstsdockercleanup.sh "$obj" &
                runningarray+=("$obj")
              #else
                 #echo "$obj already monitored for cleaning"
              fi
          done

          #Rebuild array to only include existing containers
          temparray=()
          for obj in "${runningarray[@]}"; do
              if [[ ! "$(docker container list --format="{{.Names}}")" =~ "$obj" ]]; then
                echo "$obj no longer active, Killing vstsdockercleanup instance and removing $obj from cleaner array"
                kill $(ps aux | grep vstsdockercleanup.sh | grep "$obj" | awk '{ print $2 }') > /dev/null
              else
                #echo "$obj is still active, keeping in running array"
                temparray+=("$obj")
              fi
          done
          runningarray=("${temparray[@]}")
          unset temparray

          sleep 15
        done
        {% endraw %}
      dest: /usr/local/bin/vstsdockermonitor.sh
    become: true
    register: vstsmonitorscript

  - name: Instantiate VSTS docker clean up script
    file:
      path: /usr/local/bin/vstsdockercleanup.sh
      state: touch
      owner: root
      group: root
      mode: 0755
    become: true
    changed_when: false

  - name: Inject content into VSTS docker monitor script
    copy:
      content: |
        {% raw %}#!/bin/bash
        container="$1"

        while :
        do
          sleep 1
          msg=$(docker logs "$container" --tail 1)
          #echo "$container - $msg"
          if [[ "$msg" = *"completed"* ]]; then
            echo "$container - A job completed, Agent is now dirty!"
            echo "$container - Cleanup: checking if safe to clean agent"

            loops=0
            looptime=$((60*60)) #1hour
            matchcount=0
            count=0

            while [ $matchcount -lt 15 ] && [ $loops -lt $looptime ]
            do
              sleep 1
              latestmsg=$(docker logs "$container" --tail 1)
              #echo "$container - $latestmsg"

              if [ "$latestmsg" = "$msg" ] && [[ "$latestmsg" = *"completed"* ]]; then
                matchcount=$((matchcount + 1))
                echo "$container - Cleanup: Agent reporting idle, Counting off $matchcount of 15"
                count=$((count + 1))
              else
                matchcount=0 #If msg not match consecutively, reset matchcount to 0
                echo "$container - Cleanup: Agent still busy. Match count is reset to $matchcount"
                count=$((count + 1))
              fi

              if [ $count -gt 15 ] && [ $matchcount -lt 15 ]; then
                echo "$container - Cleanup: Agent still busy after last 15 checks,"
                echo "$container - Cleanup: Resetting msg and counter"
                msg=$(docker logs "$container" --tail 1)
                count=0
                matchcount=0
              fi

              loops=$((loops + 1))
            done

            if [ $loops -lt $looptime ]; then
              docker stop --time 20 "$container" > /dev/null #Gracefully shuts down container, allowing it to be unregistered from VSTS queue
              docker restart "$container" > /dev/null
              cleaned="yes"
            else #stdout error message after looptime exceeded
              echo "$container - Cleanup ERROR: Wasn't able to cleanup agent, restarting cleaning function, better luck next round? "
            fi
          fi

          if [[ "$msg" = *"Listening for Jobs"* ]] && [[ "$cleaned" = *"yes"* ]]; then
            echo "$container - $msg"
            cleaned="done"
          fi
        done
        {% endraw %}
      dest: /usr/local/bin/vstsdockercleanup.sh
    become: true
    register: vstsdockercleanup

  - name: Instantiate VSTS Docker Monitor systemd service file
    file:
      path: /etc/systemd/system/vstsdockermonitor.service
      state: touch
      owner: root
      group: root
      mode: 0664
    become: true
    changed_when: false

  - name: Inject content into VSTS Docker Monitor service file
    copy:
      content: |
        [Unit]
        Description=VSTS Container Cleanup Service
        After=network.target

        [Service]
        Type=simple
        User={{ansible_local_user}}
        WorkingDirectory=/usr/local/bin
        ExecStart=/bin/bash vstsdockermonitor.sh

        [Install]
        WantedBy=multi-user.target
      dest: /etc/systemd/system/vstsdockermonitor.service
    become: true
    register: vstsdockermonitorservice

  - name: Reload VSTS Docker Monitor service file
    shell: |
      systemctl daemon-reload
    #when: vstsdockermonitorservice.changed
    become: true

  - name: Stop VSTS Docker Monitor service (if needed)
    service:
      name: vstsdockermonitor.service
      state: stopped
    when: vstsdockermonitorservice.changed or vstsmonitorscript.changed or vstsdockercleanup.changed
    become: true

  - name: Start VSTS Docker Monitor service
    service:
      name: vstsdockermonitor.service
      state: started
      enabled: yes
    become: true

You can install it by calling the recipe against a host like so:
ansible-playbook -i "12.34.567.891", vstsdockermonitorservice.yml
Seems to work. ¯_(ツ)_/¯


Make Wink route prefix configurable

This PR allows devs to modify the default wink route prefix to anything they wish via the wink.route_prefix config variable.
For example, you could access the Wink admin panel at /admin/ instead of the default /wink/.

Thanks for merging. :+1:


[META] Cluster Manager Async Shard Fetch Revamp

Describe the revamp
Original Issue opened/ Project goal : https://github.com/opensearch-project/OpenSearch/issues/5098
Please read above issue in detail before starting any discussion, thanks.
We'll track following as subtasks of this goal. I'll keep adding new issues, if we find more ways to improve this behaviour.

[ ] https://github.com/opensearch-project/OpenSearch/issues/8956
[ ] https://github.com/opensearch-project/OpenSearch/issues/8957
[ ] https://github.com/opensearch-project/OpenSearch/issues/8958
[ ] https://github.com/opensearch-project/OpenSearch/issues/8959
[ ] https://github.com/opensearch-project/OpenSearch/issues/8960
[ ] https://github.com/opensearch-project/OpenSearch/issues/7861

To Reproduce
Steps given in Draft PR https://github.com/opensearch-project/OpenSearch/pull/7269
Expected behavior
Cluster manager should be resilient to node restarts in high number.

We'll track following as subtasks of this goal. I'll keep adding new issues, if we find more ways to improve this behaviour.

https://github.com/opensearch-project/OpenSearch/issues/5098 for batching improvements
https://github.com/opensearch-project/OpenSearch/issues/7861 for DiscoveryNode improvements

Right now

PRs and draft PRs raised for above sub tasks

Transport action request response class for primary https://github.com/opensearch-project/OpenSearch/pull/8218
Transport action request response class for replica https://github.com/opensearch-project/OpenSearch/pull/8356
AsyncBatchShardFetch class https://github.com/opensearch-project/OpenSearch/pull/8742
BaseGatewayShardsAllocator class - draft PR (https://github.com/opensearch-project/OpenSearch/pull/8776)
PrimaryShardBatchAllocator class - draft PR https://github.com/opensearch-project/OpenSearch/pull/8916
ReplicaShardBatchAllocator class - draft PR https://github.com/opensearch-project/OpenSearch/pull/8992
GatewayAllocator class - part 1 draft PR (https://github.com/opensearch-project/OpenSearch/pull/8746), part 2 draft PR (https://github.com/opensearch-project/OpenSearch/pull/8865)
AllocationService - actual calling is being done here. partial draft PR (https://github.com/opensearch-project/OpenSearch/pull/8888)


Right side buttons on map are stacked on Android 4.4.2 Galaxy Tab 3 (10-inch)

Related issue in ionic forum here:  http://forum.ionicframework.com/t/second-header-button-stacks-on-android-4-4/4049


Vulnerability roundup 85: postgresql-9.5.21: 3 advisories [9.1]

search, files

[ ] CVE-2018-1115 CVSSv3=9.1 (nixos-20.03)
[ ] CVE-2018-1058 CVSSv3=8.8 (nixos-20.03)
[ ] CVE-2019-9193 CVSSv3=7.2 (nixos-20.03)

Scanned versions: nixos-20.03: a84b797b28e. May contain false positives.
Cc @danbst
Cc @globin
Cc @ocharles
Cc @thoughtpolice

20.03 is Frozen and EOL.
As such, issue is closed.


[ART-1091] Filter already attached image builds

Make behavior consistent with find-builds --kind rpm.
Related ticket: https://jira.coreos.com/browse/ART-1091

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   32.25%   32.25%
=======================================
  Files          22       22
  Lines        1987     1987
  Branches      307      307
=======================================
  Hits          641      641
  Misses       1331     1331
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea3c49...03c6064. Read the comment docs.

Yes, I think it is that simple. I tried it, it works. Thanks!
(Sigh for code coverage)


Error loading cordova-browser

PhoneGap CLI, node & npm versions
$ phonegap --version
6.4.3
$ npm --version
2.15.11
$ node --version
v4.7.2

Expected Behaviour
phonegap add platform browser has no errors.
Actual Behaviour
phonegap add platform browser has an error.
Steps to Reproduce
phonegap create test
cd test
phonegap platform add browser

Error messages
$ phonegap platform add browser
Adding browser project...

Running command: /Users/shaz/.cordova/lib/npm_cache/cordova-browser/4.1.0/package/bin/create /Users/shaz/Desktop/test2/platforms/browser com.phonegap.helloworld "Hello World"

Creating Browser project. Path: platforms/browser

Error loading cordova-browser

Discovered plugin "cordova-plugin-battery-status" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-battery-status" for browser

Discovered plugin "cordova-plugin-camera" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-camera" for browser

Discovered plugin "cordova-plugin-media-capture" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-media-capture" for browser

Fetching plugin "cordova-plugin-file" via npm

Installing "cordova-plugin-file" for browser

Fetching plugin "cordova-plugin-compat" via npm

Installing "cordova-plugin-compat" for browser

Discovered plugin "cordova-plugin-console" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-console" for browser

Discovered plugin "cordova-plugin-contacts" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-contacts" for browser

Discovered plugin "cordova-plugin-device" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-device" for browser

Discovered plugin "cordova-plugin-device-motion" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-device-motion" for browser

Discovered plugin "cordova-plugin-device-orientation" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-device-orientation" for browser

Discovered plugin "cordova-plugin-dialogs" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-dialogs" for browser

Discovered plugin "cordova-plugin-file-transfer" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-file-transfer" for browser

Dependent plugin "cordova-plugin-file" already installed on browser.

Discovered plugin "cordova-plugin-geolocation" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-geolocation" for browser

Discovered plugin "cordova-plugin-globalization" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-globalization" for browser

Discovered plugin "cordova-plugin-inappbrowser" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-inappbrowser" for browser

Discovered plugin "cordova-plugin-media" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-media" for browser

Dependent plugin "cordova-plugin-file" already installed on browser.

Discovered plugin "cordova-plugin-network-information" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-network-information" for browser

Discovered plugin "cordova-plugin-splashscreen" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-splashscreen" for browser

Discovered plugin "cordova-plugin-statusbar" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-statusbar" for browser

Discovered plugin "cordova-plugin-vibration" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-vibration" for browser

Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the project

Fetching plugin<EMAIL_ADDRESS>via npm

Installing "cordova-plugin-whitelist" for browser

I get the same output, slightly different versions:
~/src/pgtest via ⬢ v6.9.1
➔ phonegap -v
6.4.3
~/src/pgtest via ⬢ v6.9.1
➔ node -v
v6.9.1
~/src/pgtest via ⬢ v6.9.1
➔ npm -v
3.10.8

However, this + share feature still seems to work with the latest Dev app on an Android 7.1 Google Pixel, so unclear if it's a disastrous failure?

Thanks for the info, I will take a look into this

https://github.com/apache/cordova-lib/blob/d3c92092c9468e26fa11a4b3eb25bd2fb90afb5a/cordova-lib/src/platforms/platforms.js#L68

Api.js not found, so it's harmless (and it's just a warning)


Add partiton metadata into SegmentZkMetadata.

Added SegmentPartitionMetadata class that contains
ColumnPartitionMetadata for each column that the data is partitioned on.

SegmentPartitionMetadata is built from SegmentMetadata and is JSON
serialzed and stored as a simple filed in the ZnRecord of
SegmentZkMetadata. The JSON string gets appropriately de-serialized when
building SegmentZkMetadata from ZnRecord.

Added unit test for the new code.

Codecov Report

Merging #1505 into master will decrease coverage by 0.05%.
The diff coverage is 44.89%.

@@            Coverage Diff             @@
##           master    #1505      +/-   ##
==========================================
- Coverage   67.97%   67.92%   -0.06%
==========================================
  Files         789      793       +4
  Lines       38599    38697      +98
  Branches     5033     5050      +17
==========================================
+ Hits        26238    26285      +47
- Misses      10662    10703      +41
- Partials     1699     1709      +10

Impacted Files
Coverage Δ

...m/linkedin/pinot/common/utils/CommonConstants.java
35.71% <ø> (ø)
:arrow_up:

.../metadata/segment/PartitionRangesDeserializer.java
100% <100%> (ø)

...on/metadata/segment/PartitionRangesSerializer.java
100% <100%> (ø)

...mmon/metadata/segment/ColumnPartitionMetadata.java
38.46% <38.46%> (ø)

...not/common/metadata/segment/SegmentZKMetadata.java
75.19% <44.82%> (-8.81%)
:arrow_down:

...mon/metadata/segment/SegmentPartitionMetadata.java
48.14% <48.14%> (ø)

...ot/controller/helix/core/util/ZKMetadataUtils.java
74.28% <53.84%> (-12.08%)
:arrow_down:

...din/pinot/common/config/ColumnPartitionConfig.java
65% <9.09%> (-21.21%)
:arrow_down:

...not/common/segment/fetcher/HttpSegmentFetcher.java
28.57% <0%> (-19.05%)
:arrow_down:

...m/linkedin/pinot/common/utils/FileUploadUtils.java
45.58% <0%> (-7.36%)
:arrow_down:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f50830...e2bfaa8. Read the comment docs.


Are dotless domains valid?

Didn't find any test that states dotless domains are invalid.
Are they valid?
If yes - then there is a bug, because resolve method throws exception for dotless domains.
If no - maybe test (and probably explicit exception message) that states dotless domains are invalid should be introduced for clarity and stability?
My use case is simple docker development environment where i want to be able to access hosts in same network by containers/services names. They are usually dotless.

They're valid, yes. If the current config doesn't work with a simple Docker setup, we should remove that restriction again.

This exception occurs on my machine because resolv.conf file has no search line in it.
According to docker documentation docker mounts resolv.conf from host machine.
So if host machine has no search line in resolv.conf then an exception will happen otherwise not.
I do not know how often situation with no search line by default happens in popular linux distros (i installed fresh xubuntu 18.04 and there is a search line). But for me it seems like a bug anyway, because in fact docker dns can resolve dotless host without search line.

Yup. Mind opening a PR? :-)


@mzikherman => Explicitly pass referer to user signups

Sorry a lot of scattered PRs to you -- this should be the last one before we can merge https://github.com/artsy/gravity/pull/11706
This bumps artsy-passport to 1.0.10 and explicitly passes in the referer just like we do with intent.

Nice!


better test for node environment before calling require.

I'm running unit tests in the browser that use require.js to load amd modules. When a test fails without an assertion message I get this error
Error: Uncaught Error: Module name "util" has not been loaded yet for context: _. Use require([]) http://requirejs.org/docs/errors.html#notloaded. Requirejs exposes a require function so there needs to be a better check for node's require.

Coverage remained the same at 94.894% when pulling 426093d672f8561cff6de38003fa441ca1b135b1 on kyleseely:master into f15903e4458274229dd907c0a2a4a69f06f25180 on rowanmanning:master.

Good point, we should think about adding a test case for this to ensure r.js always works with this library.

I fixed conflicts and reopened as #43. Thanks for this, @kyleseely :)


Inconsistent Dyn Scalar Kernels

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The _dyn_scalar comparison kernels accept a scalar value implementing num::ToPrimitive and then downcast the array, coercing the the scalar to the appropriate type. There are then further dyn_utf8_scalar and dyn_binary_scalar kernels to handle non-primitive arrays, these only handle arrays or dictionaries of arrays of the corresponding type
The _scalar_dyn arithmetic kernels are instead explicitly typed on ArrowNumericType, which is ArrowPrimitiveType with some SIMD gubbins, and accept the corresponding T::Native as a scalar argument. They then downcast to the expected PrimitiveArray or a DictionaryArray containing the corresponding PrimitiveArray
Not only is the naming inconsistent, the primitive scalar comparison kernels will perform coercion of primitive scalars, whereas the arithmetic kernels and other comparison kernels will not.
Describe the solution you'd like

I think the approach of the arithmetic kernels is the least surprising, and as an added bonus is significantly simpler to implement.
I would therefore like to propose adding new [eq | lt_eq | ...]_dyn_primitive_scalar comparison kernels, and deprecating the old [eq | lt_eq | ...]_dyn_scalar kernels, before removing them in a future release.
Describe alternatives you've considered

Additional context

The current use of ToPrimitive will likely complicate adding comparison support for decimal array (#2637) as ToPrimitive doesn't have a to_i256 method.
This may also help reduce compile times for the comparison kernels #2365 #1858
Thoughts @alamb @viirya

The _scalar_dyn arithmetic kernels are instead explicitly typed on ArrowNumericType
I would therefore like to propose adding new [eq | lt_eq | ...]_dyn_primitive_scalar comparison kernels,

I think that one thing is after following _scalar_dyn arithmetic kernels such _dyn_primitive_scalar kernels will need type bound when calling. As the scalar is T:Native, and the compiler cannot infer T from the scalar type.
I think it is minor so just mention it here.

Renaming the kernels sounds good to me 👍

I would therefore like to propose adding new [eq | lt_eq | ...]_dyn_primitive_scalar comparison kernels, and deprecating the old [eq | lt_eq | ...]_dyn_scalar kernels, before removing them in a future release.

Would it be better to simply not have the dyn_primitive_scalar kernels and instead use docstrings or something else to show how to the kernels with primitives?
Here is where @matthewmturner  and I cooked up the original API: https://github.com/apache/arrow-rs/pull/1074 which also gives some background on why we didn't go with the T::Native approach

Other related PRs

Would it be better to simply not have the dyn_primitive_scalar kernels and instead use docstrings or something else to show how to the kernels with primitives?

The issue isn't documentation, but that the kernels are inconsistent in their behaviour with respect to the non-scalar kernels, and the arithmetic comparison scalar kenels. If I try to add an Int32Array to a Float32Array I will get an error, however, currently if I try to add a f32 to an Int32Array it will coerce the float to an integer and add it. This at best rather surprising, at worst a subtle source of strange bugs.
Further the encoding using ToPrimitive cannot be generalised to types other than those supported by ToPrimitive, i.e. Rust built-in types. This effectively blocks implementing these kernels for i256, i.e. Decimal256.

which also gives some background on why we didn't go with the T::Native approach

The key comment appears to be https://github.com/apache/arrow-rs/pull/1074#issuecomment-999105444. Is there any possibility I might be able to shift your feeling on this matter? Perhaps we could have a synchronous chat? Looking at DataFusion, ScalarValue is already concretely typed to match the ArrowPrimitiveType and not ArrowNativeType, i.e. ScalarValue::TimestampMillisecond instead of ScalarValue::I32(_), and so this change shouldn't materially impact its complexity - it already knows what the concrete type should be

If https://github.com/apache/arrow-rs/pull/1074#issuecomment-999105444 causes issues for the rest of the implementation, I don't feel strongly about it

Alternative proposal in https://github.com/apache/arrow-rs/issues/2842 - FWIW this would allow removing a lot of scalar dispatch logic from DataFusion


gpus training using keras with tensorflow backend on separate machines

Hello,
I am trying to use Keras with TF to train RNN in the following distributed cluster configuration:

worker 1st machine with 2 NVIDIA GPUs
worker 2nd machine with 2 NVIDIA GPUs
parameter server 3rd machine with CPU

it will be possible in the future use keras.multi_gpu_model with such configuration?
Currently I ve got the following error:
File "tf_gpu_on_multiple_nodes.py", line 122, in rnn_train
model=multi_gpu_model(model, gpus=4)
File "/net/software/local/python/3.6.5/lib/python3.6/site-packages/keras/utils/multi_gpu_utils.py", line 180, in multi_gpu_model
available_devices))
ValueError: To call multi_gpu_model with gpus=4, we expect the following devices to be available: ['/cpu:0', '/gpu:0', '/gpu:1', '/gpu:2', '/gpu:3']. However this machine only has: ['/cpu:0', '/gpu:0', '/gpu:1', '/cpu:0', '/gpu:0', '/gpu:1', '/cpu:0']. Try reducing gpus.
Is now Keras only supports multiple gpus on single machine?
Thank you and regards, Karol

Keras does support multiple GPUs on a single machine. I don't think it supports distributed training among multiple machines. You can always define layers with keras in Tensorflow for sure, but I don't think that the fit and fit_generator will work.

Thank you. But I am wondering are they any plans for development it in keras?

That I don't know. We can only suggest. @fchollet is the one deciding which features can go in the project. I can add a feature request label for visibility and upvotes.


Node CI: Don't check versions in publish.sh anymore; until we can test without merging into main

Checking package.json here is counterproductive, since it needs to check the version in the package not the repo
Skip all this for now, until we have environments and PR testing for publishing
Pre-merge checklist
Performance:

[x] I am very sure this PR could not affect performance.

I'm lost in the details. What's the overall behavior?

@eatonphil it goes like this now:
When generating the Node package tarball (node/build) version_set.sh is run before build.sh within the same job. This sets the package version in package.json locally, before build.sh rolls this into a tarball that's shared with other jobs (all the tests and publish step) via the Artifact action.
publish.sh was checking the version in package.json didn't exist on npm, but, our call to version_set.sh incremented it only for the built package, it didn't commit it or anything to the repo. So that check would fail.
Ideally, publish.sh would check that the version specified in the tarball is not on npm, but I didn't want to cause more PR spam until we have dry run testing for publish actions (which I don't want to do until we have environment secrets, to ensure we can't accidentally get it wrong)

Got it, thanks!


Clean up pipeline status APIs in the Ingestion Pipeline Resource

We have a few operations related to the pipeline status, (e.g. https://github.com/open-metadata/OpenMetadata/blob/main/openmetadata-service/src/main/java/org/openmetadata/service/resources/services/ingestionpipelines/IngestionPipelineResource.java#L716), that we might not even need.
Not sure we ever GET the status by ID

Actually let's keep it open. If we add further details on the Pipeline Status in 1.2 (re the result summary of the execution), we might need the UI to be able to expand the view when showcasing the results in a better view.


Allow binding text to shape by double clicking anywhere in the shape

Right now we allow binding the text to a shape by pressing "Enter" or by clicking on the approx center of the shape.
If there is some text already bound to the shape then we allow editing the text by clicking anywhere on the shape.
I think we should also allow double-clicking on the shape to bind the text to the shape as that's one the way users would expect to add text when binding.
Checked a few platforms -  Figjam, tldraw, Tryeraser, figjam, and whimsical allow the same as well.
This would also improve the visibility of this feature as well.

Let's do this, but only when:

the shape bg is filled
double-clicking on the element's outline (stroke)

Otherwise the behavior won't be intuitive or deterministic from the user perspective (unclear what element is selected).


clp: Replace UTF-8 validation by the latest UTF-8 utilities.

Description

This PR:

Replace the UTF-8 buffer validation with dedicated methods introduced in PR #453
Remove UTF-8 validation helpers in the current clp/utils as it doesn't validate UTF-8 code point ranges.

Validation performed

Add three files into a directory: one valid raw log file, one valid zstd compressed IR file, and clp binary. Compress the archive using clp and ensure raw log and IR can be properly compressed, but not clp binary.
Repeat step 1 by first compressing the directory using zip to trigger libarchive reading path. Ensure the raw log can be properly compressed (but not IR, since libarchive reader will not recursively decompress the zstd compressed IR stream)
Ensure workflow passed

For the PR title, how about:
clp-core: Replace calls to incomplete UTF-8 validation function with new and complete implementation.

LGTM


mvcreportviewer version is higher than specified

I am getting the below error when i added the nuget to my solution.
MvcReportViewer, Version=0.5.5456.40272, Culture=neutral, PublicKeyToken=null' uses 'System.Web.Mvc, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' which has a higher version than referenced assembly 'System.Web.Mvc, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'.
However i have given the below entry in my web.config though there is no luck.

Please suggest!!
Thank you,

You have to update you ASP.NET MVC or download MvcReportViewer source code, reference you ASP.NET MVC assembly and build it.

to which version i  have to update.I am using MVC 4 already.

There are a few versions on ASP.NET MVC: http://www.nuget.org/packages/Microsoft.AspNet.Mvc/
I'd try ASP.NET MVC 4.4.


Mobile friendly view

The site doesn't look good on mobile. Tailwind provides classes to conditionally set styles based on screen size. We should use that.
https://tailwindcss.com/docs/responsive-design

After #31, on mobile, we now see this, but the burger icon is not clickable.

@srid Yeah, I added the header menu for small screens, but it's still not complete. I need to add some Javascript to enable the menu to show up.

Looks like this has been done now.


UIViewControllerBasedStatusBarAppearance Info.plist set to NO

Are we forced to set this to NO?  I'd like to be able to set this to YES.

Can you explain it?
I am searching on the docs, there is no prop disableStatusBar.  Neither in react native StatusBar

disableStatusBar={true} seems to work well...