trader doesn't remember currencies

Lets say a user buys 1 DASH from a DASH and BTC enabled machine. The machine tells the trader on this server to buy 1 DASH, so far so good. Now, however, the trader fails. Insufficient funds, exchange down, doesn't matter why. It failed. So naturally the trade is saved for later: buy 1.
But wait. Buy 1 what? Currently, if the active coin is switched to BTC, then the trader will begin trying to by 1 BTC instead of 1 DASH. Obviously this would not be good. So, separate backlogs need to be maintained for each currency and trader.

@thelazier please write unit test(s) or at minimum confirm the patch with manual testing.

Git Guild Bounty Program

Total
Dev
Sales
Reporter
Tester(s)
Maintainer
Documenter

N/A
assignee(s)
@isysd
@isysd
@isysd
@isysd
@d3brouille

$916.67
$550.00
$45.83
$45.83
$183.33
$45.83
$45.83


Make GATKSVPipelineSingleSample validate it in MiniWDL

Fixes #153.
Make the GATKSVPipelineSingleSample pipeline validate in MiniWDL through a combination of:

Optional to non-optional

Eg: Output was required, but input outfile-name was optional.
Add select_first to coerce X? -> X

Remove duplicate inputs
Default disk_overhead_gb to 0: disk_overhead_gb = select_first([disk_overhead_gb, 0]), because if it's not supplied I guess it could be 0.

Thanks for the reply @epiercehoffman!
I believe Cromwell / womtool is actually parsing this incorrectly with respect to the WDL spec. I've requested clarification here: https://github.com/openwdl/wdl/issues/462.
To address your feedback, I've made the Optional -> Non optional map apply the default in the task, like:
task ... {
  input {
    Int? disk_overhead_gb = 10
  }
  disk_overhead_gb_ = select_first([disk_overhead_gb, 10])
  # ... use `disk_overhead_gb_`
}

This validates with womtool and MiniWDL.

Thanks @mwalker174, I've addressed your comments. I've also reverted the select_first([...]) changes you suggested as it causes Cromwell to fail to validate (an error with Cromwell). I've seen this before, and this is a grammar issue with Cromwell, where I know valid workflows are failing. It's trying to access the attribute 3 on the object 0 (actually an integer).
Failed to import 'SingleSampleFiltering.wdl' (reason 1 of 1): ERROR: Unexpected symbol (line 247, col 117) when parsing 'e'.

Expected identifier, got "3".

        | coverageBed -a stdin -b ~{raw_dels} | awk '$NF < ~{select_first([min_large_pesr_depth_overlap_fraction, 0.3])} {print $4}' > large_dels_without_raw_depth_support.list
                                                                                ^

$e = $e <=> :dot :identifier -> MemberAccess( value=$0, member=$2 )

Hi @mwalker174 and @epiercehoffman, are there any blockers for this PR, or anything I need to get it ready for re-review?

Thanks @mwalker174, I've refactored the select_first to if defined(var) then var else "default", the key being the default being in the string due to the cromwell grammar bug.


Changes3

Travis CI compatibility test

I wonder why travis-ci failes, because I did not include tikz.


Make red color brighter

When displaying progress red color is too dark

Red color is bright enough, see
https://user-images.githubusercontent.com/81821845/184601851-3d8ed777-4710-45d7-8c38-c87904a12c2e.png


feat: prevent adhoc metrics from guest user

SUMMARY

Ensure that guest users (from embedded dashboards) can only use predefined metrics in chart queries.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A
TESTING INSTRUCTIONS

Added unit tests covering both EMBEDDED_SUPERSET enabled and disabled.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Should this be a fix instead of feat?

Does this mean that if I create a dashboard today with a chart in it that uses a SQL expression metric, embed it and share it with guests it would fail? If that's the case it's likely a breaking change.
Or does this apply only in some other context, say some sort of "explore-embedded" experience?

Does this mean that if I create a dashboard today with a chart in it that uses a SQL expression metric, embed it and share it with guests it would fail? If that's the case it's likely a breaking change.

Yeah, this is a breaking change for security reasons. We need to think of a better way of preventing guest users from modifying the SQL.

Doing some thinking here, the user should be able to run what the dashboard designer built for them, in other words, the query that's served on the server side should be ok to run. What we don't want is for the user to be able to alter the chart definition and make up new metrics.
Even with this predefined metrics restriction, the user could in theory point to another pre-defined metric that's out of the scope of the dashboard.
Would an approach of sending a unique identifier of the chart, along with dashboard level filter would work as a better approach here. Meaning the form data sent by the client is simply a reference to a chart + the context from the dashboard, and we can trust that the query executed is the one that the dashboard designer and dashboard "embedder" cleared?

Closing in favor of a different approach, see https://github.com/apache/superset/pull/26749.


Performance Question

The speed/performance of this library is mentioned twice:

JASON is a faster JSON deserializer written in Swift.

And in the quote:

(...) This is by far the fastest and the most convenient out there (...)

Are there any measurements/benchmarks to back these claims?

Hi @RuiAAPeres, thanks for the issue.
Yes, there is a benchmark branch linked in the "Features" section. I will update the benchmarks with the latest versions of the libs but we should get a similar result as the implementations didn't change.
The two projects have a very similar API but, internally, JASON is using NSArray and NSDictionary instead of [AnyObject] and [String: AnyObject]. The PRs on the other project that proposed to use to NSArray/NSDictionary were rejected. This is one of the reasons (but not the only one) I created JASON.
However I realize it can appear as "cocky" and I don't want to draw attention by bashing another OS project. But on the other hand, I think that the perf benefits are really worth mentioning. What do you suggest? (btw feel free to mail me at<EMAIL_ADDRESS>

@RuiAAPeres The benchmark branch has been updated to use the latest versions of the libraries.
Two things to note:

both libraries are now much faster than before
JASON is now "only" 2 times faster

See the diff


Document usage of profiles

https://github.com/NixOS/nixpkgs/blob/56904d7c423f2b13b37fbd29f39bbb4b52bc7824/nixos/modules/virtualisation/docker-image.nix#L5
It's not clear to me why it's wrong to include profiles... I was trying to create a custom OS image and reading through example code, was about to use this but I'm curious as to why the comment says we shouldn't? @edolstra
Also, is there any documentation on this?

There are some layers to NixOS that should only depend in one direction. Profiles are supposed to be collection of modules. The order of thingd goes something like this:
Profiles -> Modules -> Packages


Date Picker Range Issue

Detailed description
Date Picker Range Cannot read properties of undefined (reading '0')
When you focus on an input from the date picker range it throws an error Cannot read properties of undefined (reading '0')
It can be reproduce on  https://angular.carbondesignsystem.com/?path=/docs/components-date-picker--docs

This is specifically a storybook docs page issue... I can assure you that it works in your angular app. There are still a few issues with storybook/angular we have to resolve.
Thank you for reporting this!

@AlexandraMadalina Could you still produce the issue in storybook? I've updated it recently and I've fixed this issue by passing a unique ID into datepicker. Keep in mind, you do not have to pass in an ID as it will automatically assign it a unique ID.

in storybook it works fine now, in my app I still have the issue

Are you passing an id element to the date picker? If yes, could you try removing it or ensuring the id is unqiue?


Added glm.py examples in docstrings

This PR adds examples for the glm.py public-facing commands.
To be discussed: These are my first set of examples for functions, so I'm unsure if I should add more details and scenarios of how the functions can be used.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.09%. Comparing base (e739138) to head (8dcee76).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   97.24%   97.09%   -0.16%
==========================================
  Files          20       20
  Lines        1815     1857      +42
==========================================
+ Hits         1765     1803      +38
- Misses         50       54       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Pranati was having an issue where running isort locally was giving inconsistent results with the CI and with my local machine. Turned out the issue was https://github.com/PyCQA/isort/issues/1790: there was a local folder named jax in her nemos directory, which made isort consider jax as an internal package, and changing how it was sorted. jax was a git submodule, and we're unsure how it ended up there. Deleting the directory caused isort to behave as expected.

Updates made:

Added example to the fit method of PopulationGLM
Changed some wording based on Edoardo's comments
Removed the basis example that overlapped with this branch to keep this branch clean of only GLM examples
Regular formatting tox fixes

For the comment about ordering the import statements -- I didn't put them all at the top and instead put them in the order that they are called just because I thought it would be easier for someone who didn't really understand the imports to see exactly how they are being used. But because the examples aren't too lengthy or technical, I can change the imports to the regular standard. Let me know!
Added an example to initialize_state but not cast_to_jax because the latter seems to be only used internally. Other than that, everything else is fixed from my end.

This looks good! Couple more user-facing functions need examples, though @BalzaniEdoardo maybe some of these can be made private?

cast_to_jax
initialize_state

General notes:

While it's fine to have the imports in the examples right above where they get used, I think it's more standard to have all imports at the top (that's how scripts and notebooks are generally written) -- any particular reason you didn't do it that way?

Let's make 'cast_to_jax' private, keep 'initialize_state' public since batching as we have it now requires the user to call the method, if you check the relative how to guide in the docs.

Thanks @pranmod01!


doom-emacs cann't recognize remapped alt key

[X] I have searched the FAQ and the documentation for solutions.
[X] I have searched the issue tracker for similar issues (the closed issues too).
[X] I have searched the Discourse for any errors and solutions.
[X] I can reproduce my issue on the latest commit of Doom Emacs.
[X] I have read How to Debug Issues and found no solution.

What did you expect to happen?
I am using external USB-HID keyboard with Macbook Pro 16. I hope the remapped alt and command key function well, so that i can use M-x(remapped alt+x) and Cmd-s, etc.
What actually happened?
After remapped alt key as command, command as alt on my external keyboard, the remapped left alt key can not be recognized as meta, and remapped left command key is recognized as s, when running Emacs.app
Describe your attempts to resolve the issue
I tried run Emacs.app without doom-emacs, the remapped alt and command key functions as I expect.
I also tried run emacs in terminal with and without doom-emacs, which both functions as i expect.
So, only when running Emacs.app with doom-emacs configuration, the left remapped two keys could not function well.
Steps to reproduce

MacOS, settings -> keyboard -> Modifier keys -> select keyboard USB-HID keyboard -> Option key to Command, Command key to Option
run Emacs.app, press left M-x(remmaped alt+x), and Cmd + s

System Information
https://pastebin.com/W3FhaJV6

Duplicate of #5143.
See https://github.com/hlissner/doom-emacs/issues/5143


Fix "Multiple builders are available" when syncing project in IDEA

There is a workaround that prevents adding a builder multiple times:
https://git.io/JZLn1
This workaround relies on the fact that there is the builders field in
the BuilderRegistry. The field was replaced with registrations in
a recent commit so the workaround no longer works.
This commit introduces a quick fix by providing builders field that
is backed by the data in registration.
Proper fix will probably require figuring out why the plugin is applied
twice to the same Gradle instance.

Fixes #17319

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test and merge

OK, I've already triggered a build for you.

@mlopatkin I manually tested this with the sample project and I don't see the failure now.
I also investigated why we're seeing the plugin applied multiple times. The problem isn't that the plugin is being mistakenly applied multiple times. Since Gradle 4.0, we run init scripts against included builds, so there are multiple instances of Gradle (one for each build) and this plugin gets applied to each of them. For some reason, the plugin is using project evaluation listeners to add the model builder.
I think it's possible to greatly simplify what it's doing.
I didn't fix the init script for Gradle versions older than 4.0, but I think it's possible to support those versions too.
I think something like this is all that's needed:
import org.gradle.tooling.provider.model.ToolingModelBuilderRegistry
import org.gradle.tooling.provider.model.ToolingModelBuilder
import org.gradle.util.GradleVersion

import javax.inject.Inject

apply plugin: JetGradlePlugin

class JetGradlePlugin implements Plugin<Gradle> {
    private final ToolingModelBuilderRegistry toolingModelBuilderRegistry

    @Inject
    JetGradlePlugin(ToolingModelBuilderRegistry toolingModelBuilderRegistry) {
        this.toolingModelBuilderRegistry = toolingModelBuilderRegistry
    }

    void apply(Gradle gradle) {
        def extraModelBuilderInstance =
            GradleVersion.current() >= GradleVersion.version("4.4")
            ? ExtraModelBuilder.class.classLoader.loadClass(ExtraModelBuilder.class.typeName + "\$ForGradle44").newInstance()
            : new ExtraModelBuilder();

        toolingModelBuilderRegistry.register(extraModelBuilderInstance)
        // TODO: Remove this
        println("registered $extraModelBuilderInstance on ${gradle}")
        if (GradleVersion.current() >= GradleVersion.version("3.1") &&
            GradleVersion.current() < GradleVersion.version("4.0")) {
            // TODO: add this model builder to included builds, using some version of the old code
        }
    }
}

// TODO: Remove this, this was just for testing
class CustomModel implements Serializable {
    String path
}

class ExtraModelBuilder implements ToolingModelBuilder {
    boolean canBuild(String modelName) {
        return modelName == "CustomModel"
    }

    Object buildAll(String modelName, Project project) {
        return new CustomModel(path: project.path)
    }
}

class ExtraModelBuilder$ForGradle44 extends ExtraModelBuilder {}

But maybe as a first step, could we ask JetBrains to switch to using ToolingModelBuilderRegistry.getBuilder() to check for the registration, instead of introspecting the implementation:
https://docs.gradle.org/current/javadoc/org/gradle/tooling/provider/model/ToolingModelBuilderRegistry.html#getBuilder-java.lang.String-
This has been available for ages, so backwards compatibility shouldn't be an issue.
And then they can look at modifying the init script to be more like what I've put above.


tests: enhance our test matrix

This depends on #305
Currently, our CI tests:

rwkv
cerebras
whisper
bert embeddings

But we should, possibly test:

[ ] llama.cpp
[ ] gpt4all.cpp
[ ] go-gpt2 (everything that comes from ggml directly)
[ ] bloom
[ ] image generation

Hi, @mudler , Is there any idea that you have on how to test it? It is a little bit hard to test them in the traditional way.

@mudler is there any smallest size model we can use for testing llama.cpp. I have tried tons of models on go-llama.cpp, none of them is working for go-llama.cpp


Required Attribute

The starship model has the Required attribute set for the ProductionDate and the IsValidatedDesign. Given that these data types are not nullable I presume the attributes have no actual effect.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b44a252f-fda0-acc2-e672-630386674d70
Version Independent ID: 5d880efd-cdab-3739-545d-709ab48eb94d
Content: Forms and validation
Content Source: docs/architecture/blazor-for-web-forms-developers/forms-validation.md
Product: dotnet-architecture
Technology: blazor
GitHub Login: @danroth27
Microsoft Alias: daroth

Hi @Mark-Phillipson, thank you for reaching out.
Though the datatypes of ProductionDate and IsValidatedDesign are not nullable, the Required attribute is used for validation purpose.
The RequiredAttribute attribute specifies that when a field on a form is validated, the field must contain a value. A validation exception is raised if the property is null, contains an empty string (""), or contains only white-space characters.
I am closing this issue as of now. Please feel free to reopen it, if you have any further questions.

✔


MultiBranch Plugin stopped working with latest Jenkins.

I always get this error with latest jenkins:
Setting origin to https://git.virtual-identity.com/scm/ui/ui-privatkunden-frontend-framework.git
Fetching origin...
FATAL: Could not initialize class org.eclipse.jgit.transport.Transport
java.lang.NoClassDefFoundError: Could not initialize class org.eclipse.jgit.transport.Transport
The bug was reportet here too:
https://groups.google.com/forum/#!topic/jenkinsci-users/Q5ONa5eZcnA
Can you please look into that issue? Thanks a lot.

Same problem :-(

latest Jenkins being 1.634?  which Git Plugin version?

Jenkins ver. 1.633 in my case but it did not work with 1.634 either. i am on ubuntu 14.04

This seems to be a duplicate of #107. As explained there it seems to be corrected with version 1.634 of jenkins.

Jenkins 1.634
GIT Plugin: 2.4.0
GIT client plugin: 1.19.0
With these versions, it work well. May be other plugin with a conflict.


[4.0] [ClangImporter] Handle inheritance from a class/protocol composition

Explanation: Objective-C allows inheriting from a typedef for a class/protocol composition as shorthand for inheriting from the class and adopting the protocol. Swift didn't handle that, which resulted in crashes; we're seeing this more now than we did before because previously we didn't support class/protocol compositions at all.
Scope: Affects Objective-C classes inheriting from typedefs.
Issue: rdar://problem/34586035
Reviewed by: @DougGregor
Risk: Very low. Should have no effect on existing working code, and code that previously crashed the compiler will now work.
Testing: Added compiler regression tests.

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 06a0c6075a0c5549425df4596eaabc38bdb1b99b

@swift-ci Please test macOS


[Draft] Revamp Azure Service Bus  connector with connection pooling

Purpose
[Draft] Revamp Azure Service Bus  connector
Goals

Remove returning a handle to the user.
Clean separation between sender & receiver clients.

Approach

Remove returning  handle object to the user.

Maintaining the handle objects inside a pool.

Clean separation between sender & receiver clients.

Multi-client approach.
Refactoring implementation underneath.

Automation tests

Unit tests

Yes

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Samples

Provide high-level details about the samples related to this feature

https://github.com/ballerina-platform/module-ballerinax-azure-service-bus/pull/46


change name of _created and _updated to created and updated

at some point it probably made sense to have the underscore, so it would match the _id being auto-generated and having an underscore but I think any sensible reasons for doing it are outweighed by the fact that we have properties on the orm to convert them to created and updated anyway.

The new alias functionality automatically handles created and updated being aliases for _created and _updated and I like the consistency of all the magic fields starting with an underscore.


"failed to get last entry" Error

Please can you assist with this error, I have only recently tried to use this but have not yet gotten past this error.
What I know so far is that if I use the wrong region it gives me the correct response.
It also gets the correct patient but cannot get past this error.
My daughter uses a Libre2 bluetooth version

XXX@cloudshell:~ (ns-librelinkup)$ docker run -e<EMAIL_ADDRESS>          -e LINK_UP_PASSWORD="XXX"            -e LINK_UP_TIME_INTERVAL="1"            -e LINK_UP_REGION="EU"            -e NIGHTSCOUT_URL=
"https://ns.XXX.eu"            -e NIGHTSCOUT_API_TOKEN=$(echo -n "librelinku-XXX" | sha1sum | cut -d ' ' -f 1)            -e LOG_LEVEL="info"            timoschlueter/nightscout-librelink-up

<EMAIL_ADDRESS>start-heroku
node dist/index.js

[info]: Starting cron schedule: */1 * * * *
[info]: renew token
[info]: Logged in to LibreLink Up
[info]: Found 1 LibreLink Up connection.
[info]: -> The following connection will be used: XXX XXX (Patient-ID: c1e75630-af85-11ed-XXX)
[error]: getaddrinfo ENOTFOUND https
/usr/src/app/dist/nightscout/apiv1.js:25
throw Error(failed to get last entry: ${resp.statusText});
^
Error: failed to get last entry: undefined
at Client.lastEntry (/usr/src/app/dist/nightscout/apiv1.js:25:19)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async createFormattedMeasurements (/usr/src/app/dist/index.js:236:47)
at async uploadToNightScout (/usr/src/app/dist/index.js:257:35)
at async main (/usr/src/app/dist/index.js:129:5)

In your NIGHTSCOUT_URL variable, remove the "https://". That should resolve the issue :)

thank you so much!


Telegraf plugin - graphite "insecure_skip_verify"

Hi,
after configuration of telegram plugin and output to graphite, no output is sent because of unsecure traffic between opnsense and graphite node.
the value for this is automatically set in background by the opnsense webGUI.
/usr/local/etc/telegraf.conf:
insecure_skip_verify = true
after changing this to "insecure_skip_verify = false" the telegraf plugin is working.
my issue is: after reboot of opnsense the value is set to "true" again.
would it be possible to make this value accessable via webGUI or the value manually set in conf-file survives reboot?
Thanks and bye
dtavb

sorry, I had not mentioned the used release: 18.1.7_1 (last stable at this time of writing)
wow, thanks alot!


Add missing preserves-definedness  tags in cheatcodes.md

Issue created from
I've migrated the changes from this pr in https://github.com/runtimeverification/kontrol/pull/320 and https://github.com/runtimeverification/kontrol/pull/321 and created a new issue to add the [preserves-definednes] tag to missing productions in cheatcodes.md. If I missed anything, let's open an issue for it. Meanwhile I'm closing this.
Originally posted by @anvacaru in https://github.com/runtimeverification/kontrol/issues/303#issuecomment-1915594838

For some of the cheatcodes (foundry.call.addr and foundry.call.sign), [preserves-definednes] was added in https://github.com/runtimeverification/kontrol/pull/286.
@PetarMax do we also want to add [preserves-definednes] to #setCode ACCTID CODE and #setStorage ACCTID LOC VALUE as was done in https://github.com/runtimeverification/kontrol/pull/303, or shall we close this issue?


@qualweb/act-rules: QW-ACT-R15 - Audio or video element avoids automatically playing audio (80f0bf)

Audio or video element avoids automatically playing audio

Just ran a fresh set of tests, and only R4 and R71 is failing now. Can we safely close this issue?


Add UUID field for Problem

Hey Greg, I only found the version error problem in my local env. please let me know if you have other problem.

This will break usage in IDE.  Can you either add a new constructor that will keep backwards compatibility or send a pull request that fixes this in IDE usage.

Just started reviewing :) :octocat: Sent from GH.

Pull request submitted to https://github.com/gamerson/liferay-blade-tools/pull/180. See changes here. :octocat: Sent from GH.


Add getChainTopUserTransactions.graphql

Description

Add the query getChainTopUserTransactions and e2e test
Test Plan

pnpm test
pnpm fmt
Related Links

Current dependencies on/for this PR:

main

PR #35   👈

This comment was auto-generated by Graphite.

I'm wondering how important this is to be in the SDK?
I'm assuming this is only useful for explorers and statistic sites

@gregnazario Good question. Yeah I don't think this is that much of a P0 query. Shall we revisit the priority on these queries? - https://www.notion.so/aptoslabs/fetch-queries-to-port-over-into-sdk-v2-8a38cf2c47e542e2ae299c900894277b


For substitute.range, is there a way to provide a register or even a lua callback to replace motion1 or motion2?

For example the / register contains the last search pattern, so being able to use that to replace motion1 in a substitute.range call would be a nice keybinding to have

Interesting idea!

It'd be great to be able to use visual mode to select the range for motion2 (often the range I want to replace in can't be described succinctly by a Vim motion). If we were able to set callbacks for motions, that'd probably make it possible!

Thanos voice Fine I'll do it myself
...and it is done


About spkid.csv ?

I saw that pdns config have spkid_csv: /mnt/f/4th_DNSChallenge/ICASSP_2022/DNS-Challenge/datasets/filelists/complete_ps_split.csv, but I don't know how to download it?

hmm, we should not be exposing any private paths in git.. I'll let @hdubey to clean it up and answer your question about the csv file (I have no idea what it is or if you need it at all)

The source code show that the csv is for saving "primary" and "secondary" labels. When will release that???

@motus @hdubey
In "noisyspeech_synthesizer_singleprocess.py", the "spkid_csv“: is needed for synthesizing pdns training set. So, it looks
important and urgent.

Maybe you should check if noisyspeech_synthesizer_singleprocess.py can be run normally in a public directory.

@ujscjj can't agree more. @hdubey can we fix that ASAP please?

@ujscjj can't agree more. @hdubey can we fix that ASAP please?

Is it fixed now ?

seems no reply

It's nice if authors could provide complete_ps_split.csv due to the importance of speaker-wave file assignment

Is there any update on this complete_ps_split.csv file?

Is there any update on this complete_ps_split.csv file?

Hello. Is this issue resolved? Could you please provide the complete_ps_split.csv file for personalized DNS training set? Thank you so much!

Is there any update on this complete_ps_split.csv file?

hmm, we should not be exposing any private paths in git.. I'll let @hdubey to clean it up and answer your question about the csv file (I have no idea what it is or if you need it at all)

Is there any update on this complete_ps_split.csv file?

I saw that pdns config have spkid_csv: /mnt/f/4th_DNSChallenge/ICASSP_2022/DNS-Challenge/datasets/filelists/complete_ps_split.csv, but I don't know how to download it?
Is there any update on this complete_ps_split.csv file?


SCSS Install Button Link Goes to Incorrect Page

How can we reproduce this bug?

Foundation for Sites: Download
Click "Install via SCSS" under Sass

What did you expect to happen?
Go directly to the Sass installation page in Docs
What happened instead?
Redirected to Docs homepage

I am not able to locate the download page in the repo. But it seems there are two options for this link.
http://foundation.zurb.com/sites/docs/sass.html
http://foundation.zurb.com/sites/docs/installation.html

@rspraymond @rafibomb was able to make the edit this morning and change it to the first link you recommended as well (http://foundation.zurb.com/sites/docs/sass.html). Closing.


Should we rename UPClientZenoh to UPTransportZenoh?

Since now we rename the project to up-transport-zenoh-rust, I'm wondering whether we should rename the struct.
@PLeVasseur WDYT?

I dunno, kinda why I wasn't sure renaming the projects to up-transport-... was good in the first place, since it's possible we want to have dedicated means of implementing uP-L2 APIs (e.g. RpcClient) within the up-transport-...  repos.
IMHO since you're not implementing only the uP-L1 UTransport it makes sense to keep it named as UPClientZenoh.
My 2 cents.

Make sense. Let's close the issue temporarily.


Plonky2 is Snark or Stark?

Hey guys,
I studying on zkp algorithms and if I get it right, Plonky2 is a recursive SNARK.
In fact, this link has a quote that says:
Plonky2 is a recursive SNARK that is 100x faster than existing alternatives and natively compatible with Ethereum. It combines PLONK and FRI for the best of STARKs, with fast proofs and no trusted setup, and the best of SNARKs, with support for recursion and low verification cost on Ethereum.

What I get from this quote is that Plonky2 actually uses some features of Stark and this is where I get a little confused. I wanted to know if there is a Stark implementation for Plonky2 that can tested or if this repository is the only implementation of Plonky2 that is actually Snark and there is no Stark implementation at all.
I appreciate it if you guys could help me understand this.

Hi!
Just a note, STARKs and SNARKs are not separate categories. Assuming we're only talking about non-interactive protocols, all STARKs are SNARKs; in particular, STARKs are the SNARKs that are transparent (requiring no trusted setup).
Often, STARK is used as shorthand for AIR-based and FRI-based STARK, which is one particular (and quite popular) type of SNARK. Most modern SNARKs are built from an IOP (interactive oracle proof) and a PCS (polynomial commitment scheme). In the case of these common STARKs, AIR is the choice of IOP and FRI is the choice of PCS.
The blurb you're quoting is simply referring to the fact that Plonky2 uses FRI as its PCS, similar to these STARKs, but uses an IOP similar to the one from Plonk (which is a SNARK but not a STARK).
However, this repo also includes starky, which is built from AIR + FRI, like a classic STARK.
Hope that helps!

Hey,
that was a nice, short and also complete explanation.
Thanks.


can´t remove directories in v1.0

Hi,
first, I wanted to thank the developer for creating such a useful software, it has already found many missing lrc files in my library and was super simple to use.
The new version it’s a big improvement, especially with the included player and lrc lyrics viewer, helps a lot to find if the lyrics do sync correctly. (Previously I was transferring the songs to my phone, and using poweramp to check this). Kudos!
As mentioned in the title I wanted to report that once a directory is added it can´t be removed. I already tried restarting the app, but does not allow to delete directories. I'm using the latest update in Win 10 x64.
Also, as a couple of suggestions for future releases:
-an option to only show track with or without lrc files.
-an option to search and overwrite lrc files (for those cases that the lrc was found somewhere else, like www.lyricsify.com, and lyrics are out of sync).  Not sure if it could display the new found lrc files, before overwriting the old file, to check it the new result is a better synched match or not.
-would be nice if clicking on any part of the synchronized lyrics, would take you to the same time stamp of the playing track. This is supper useful to make sure lyrics are correctly synched.
-On the track’s menu, it would be nice if a checkmark under the lyric’s column, could show which track also contains embedded lyrics or not.  Maybe a dark background with pink accents could be added.
Thanks again for such an useful  tool!

Hey, I'm really glad you like my work!
I've just released v0.1.1, could you check if directories removal is working now?
https://github.com/tranxuanthang/lrcget/releases/tag/0.1.1

I'll close this to clean things up, but please feel free to reopen if you are still having this issue.

Thanks for the update, here are my findings with 0.1.2
-Directories can be removed now.
-The problem is that I ran into a different issue, I tried searching lrc for the song "Natalie Gang - Raging", and the program showed that an LRC result found, but nothing was actually downloaded. Another strange thing happened, after removing the directory for that song, and adding the folder back again (in order to rescan it), this time it did not show track, as if the directory was empty.
I uninstalled and tried searching for the lrc with version 0.5 and it showed that nothing was found. So I guess that the actual lrc is not available yet in the database, but v 0.1.2 is showing false positive results and this might cause some problems when rescanning that same folder.

@mg563 I'm investigating, but it will be more helpful if I have a copy of that file. If it is possible, could you send it as an attachment to my email?


Update deps and formatter compat

This PR updates formatter compat and the deps.

bors r+

bors r+


Replace absolute link

@imba-tjd : Thanks for your contribution! The author, @rothja, has been notified to review your proposed change.

@imba-tjd : Thanks for your contribution! The author, @rothja, has been notified to review your proposed change.


Backpack items are not visible, but it is tracking their prices

I would love to know that there is a chance to save this :). Items here were set to weightless, but it is still tracking costs which gives me some hope.
What I have already done.

Disabled ALL modules except for this one
Cloned the backpack and tried to edit the sheet type.

I use this backpack as a group bag of holding, and there have stored of a lot of items in it. It would be shame to lose this.

Wrong module?

Wrong module?

None of what you are describing are features of this module.

If I have posted in the wrong place please excuse my ignorance, but this isn't a module that allows groups to have 1 container they can all share access to?

This module does not delete items and store them in another item as some embedded data that can't be retrieved; it uses actors, which is safer than what module you have been using.
It doesn't change the weight or price of the backpack item that is used as a link between the actors, which is what is telling me that you are using a different module. This module also does not change the backpack's description, which is what I assume I was meant to be seeing given you showed a picture of the container's Description tab.

So no I could have done a better job describing it. It did not change weight or price.
My hope is that because it STILL shows weight that I didn't lose access to all the items that I can no longer see after the last major update.

Well stop looking at the item and look at the actor you were using, if you insist it's this module.

I have the item set to be accessible by all players, which is why I just going to it. Can you help me navigate a little more troubleshooting that maybe is common but I cannot think of? I know you are probably bombarded by questions daily, so I appreciate your time.

I do not do troubleshooting for other people's modules.


Replace lxml with Python's built in html.parser

After my server has been running for some time, fbchat starts throwing the following exception:
Failed loading session
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/fbchat/client.py", line 366, in setSession
    self._postLogin()
  File "/usr/local/lib/python2.7/dist-packages/fbchat/client.py", line 212, in _postLogin
    soup = bs(r.text, "lxml")
  File "/usr/lib/python2.7/dist-packages/bs4/__init__.py", line 215, in __init__
    self._feed()
  File "/usr/lib/python2.7/dist-packages/bs4/__init__.py", line 239, in _feed
    self.builder.feed(self.markup)
  File "/usr/lib/python2.7/dist-packages/bs4/builder/_lxml.py", line 240, in feed
    self.parser.feed(markup)
  File "src/lxml/parser.pxi", line 1194, in lxml.etree._FeedParser.feed (src/lxml/lxml.etree.c:119773)
  File "src/lxml/parser.pxi", line 1237, in lxml.etree._FeedParser.feed (src/lxml/lxml.etree.c:118685)
  File "src/lxml/parser.pxi", line 827, in lxml.etree._BaseParser._getPushParserContext (src/lxml/lxml.etree.c:113960)
  File "src/lxml/parser.pxi", line 844, in lxml.etree._BaseParser._createContext (src/lxml/lxml.etree.c:114186)
  File "src/lxml/parsertarget.pxi", line 110, in lxml.etree._TargetParserContext._setTarget (src/lxml/
  File "src/lxml/parsertarget.pxi", line 41, in lxml.etree._PythonSaxParserTarget.__cinit__ (src/lxml/
  File "/usr/lib/python2.7/inspect.py", line 814, in getargspec
    func = func.im_func
RuntimeError: restricted attribute

Restarting the server fixes the problem temporarily, but it returns after a while.
Researching the issue brought up this problem being reported several times and considered "The unpredictable BS behavior again."

The only remedy being offered is replacing lxml.
This pull request replaces lxml with Python's built in html.parser.

The main reason for using lxml is the speed benefit, but I went ahead and ran a few tests against data from the three Facebook urls we're be parsing with BeautifulSoup:
from requests import get
from timeit import timeit
from bs4 import BeautifulSoup as bs
n = 2000

d = get("https://m.facebook.com/").text
timeit('bs(d, "html.parser")', number=n, globals=globals())/n
# -> 0.0039508302819886015
timeit('bs(d, "lxml")', number=n, globals=globals())/n
# -> 0.0026858313914999597

d = get("https://www.facebook.com/").text
timeit('bs(d, "html.parser")', number=n, globals=globals())/n
# -> 0.037392912552997586
timeit('bs(d, "lxml")', number=n, globals=globals())/n
# -> 0.03604348213601043

d = get("https://m.facebook.com/login.php?login_attempt=1").text
timeit('bs(d, "html.parser")', number=n, globals=globals())/n
# -> 0.0038544781890086596
timeit('bs(d, "lxml")', number=n, globals=globals())/n
# -> 0.002652162682003109

The speed benefit is mostly negligible (compared to IO), and non-existent in the most time consuming case, so I'd argue this was a classic example of premature optimisation.
I've also seen a lot of people having trouble installing lxml in the past, see #101, #119, #113, #230 and #272.
I'll test it with TravisCI when I get it up and running again, and I'll make sure to include it in the next release. Thanks ;)


Behaviour of the /submit/ endpoint

Behaviour of https://archive.md/submit/ endpoint has changed recently. Now it returns WIP page in Refresh header (https://archive.md/wip/Z6uhm) which contains page capture progress and expects client to retry until the page is captured and proper memento URL (https://archive.md/Z6uhm) returned via Location. This way archiveis.capture() always returns URL of the WIP page.
This can be fixed either by retrying until proper URL is available (and somehow handling errors if it is not) or just stripping /wip/ from URL and hoping for the best.
>>> archive_url = archiveis.capture("https://example.com")
DEBUG:archiveis.api:Requesting https://archive.md/
DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): archive.md:443
DEBUG:urllib3.connectionpool:https://archive.md:443 "GET / HTTP/1.1" 200 4997
DEBUG:archiveis.api:Unique identifier: QxbCURgTX9qqOlJsvO7Qnp6OpwoRYUx3YErVZz1eLx4aUht3+iuOB+6Ili4WD2Y2
DEBUG:archiveis.api:Requesting https://archive.md/submit/
DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): archive.md:443
DEBUG:urllib3.connectionpool:https://archive.md:443 "POST /submit/ HTTP/1.1" 200 244
DEBUG:archiveis.api:Memento from Refresh header: https://archive.md/wip/Z6uhm

Do you think stripping the /wip/ will work reliably?

I reckon it will not be more unreliable than it was with current archiveis code and old-style (pre-wip-page) handling on the server side. Refresh: header was available as soon as Loading... page was, and it was returned by archiveis.capture() immediately and unconditionally. This way unsuccessful archivals in the cases of Error: time out., Error: Network error. and infinite Loading... were not handled anyway, and resulting link ultimately yielded 404. Stripping /wip/ should work the same way.
On the one hand bluntly ignoring errors is not an ideal approach, on the other hand waiting up to 3-5 minutes on each call is also not an option for many use cases. Maybe it makes sense to introduce some kind of archiveis.capture(..., strict=False) parameter which defaults to shortcut (and existing) behaviour, and optional strict=True mode which parses wip page for all kinds of errors and raises exceptions?

You have any idea on how we could implement this in the Python?


save from LNCHR-CommandsGenerator.xlsm

Trying to save from:
"C:\Users\xxxxxxxx\OneDrive - Alfa Laval_CODE\LNCHR-CommandsGenerator.xlsm"
generates error - run-time error 52 - bad file name or number
saving from:
C:\Users\xxxxxxxx\LNCHR-CommandsGenerator\LNCHR-CommandsGenerator.xlsm
works fine.
None of the paths are especially long
any ideas? One drive is the problem? Could it be that when you save it does not save locally but to a network adress?

I would try changing the file name to the absolute path. If not, I would play around with some of the file write properties/settings.


#6491

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[ ] Feature
[x] Refactoring

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #6491
[ ] Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[x] My fix has changed UI

Copilot Summary

😍 Perfect, I’ve sent the payout
💵 $5 @ 5.13 USD/DOT ~ 0.975 $DOT
🧗 13Qx65nLd6SwdtjrRyuoEtp9CKXhF651xdHBPaXcvhwKm4N1
🔗 0x32e57fd405308c1e8c93288d3058ace7e9c35b18c7a90969e436cfa19cbb131a
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


surpport broadlink RMmini3

Add learn infrared remote control instructions and sending infrared remote control instructions
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):
- platform: broadlinkRM3
   mac: xxxxxxxx  #mac address
   host: xxxxxxxx  #ip address

Checklist:
If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

As I told you before, #10744
I think RMmini3 is already supported by the Broadlink platform: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/switch/broadlink.py
If not please extend that platform, and do make a new platform


block invalid_block error

There is a problem with the Windows version  xdag-pro-1.0.13+14-windows.zip. When xdag coin sent to another address, this message appears
block invalid_block error

Give more details please.
Mainnet / testnet ?
Address in / out ?

The problem occurred on the main network
When I send the xdagto the coinex.com, I also create another wallet and try to send to it, but the same problem occurs

I found out that your ISP is the reason for that. Thank you

@mohammednagy7878 Can you share the solution you found to the problem? What happened to the internet provider? I have a colleague on Discord who encountered the same error. It is trying to transfer from the wallet to CoineX and it shows the same message.

What country do you live in? What is your ISP?


feat(File): add #setUploadHeader

https://github.com/leancloud/paas/issues/960

https://s3.amazonaws.com/avos-cloud-qvnm6ag2khjt/ec57302f4b1b72b09b93.gif

Codecov Report

Merging #512 into master will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
- Coverage   67.07%   67.03%   -0.04%
==========================================
  Files          36       36
  Lines        2955     2958       +3
==========================================
+ Hits         1982     1983       +1
- Misses        973      975       +2

Impacted Files
Coverage Δ

src/uploader/cos.js
18.18% <ø> (ø)
:arrow_up:

src/uploader/s3.js
70.83% <ø> (ø)
:arrow_up:

src/uploader/qiniu.js
18.18% <ø> (ø)
:arrow_up:

src/file.js
76.01% <33.33%> (-0.59%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46ef9e...f27bd60. Read the comment docs.


Update flag.go, add secret option

I think we could add a new option for flag to make a distinction between secret flag and normal flag, let people can hide the value of flag by "".
just like --username= --password=******

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@spf13 PTAL

@eparis PTAL

I don't get it. If I know to call 'SecretEncode()' in my program, why wouldn't I just print *****. Who is using flag.Secret. My program sets it and then I have to check it, then I have to call SecretEncode() when I want to print?
I just don't see where this is getting us anything. Maybe an example program of how you think this would be used would show me the value.

I'm with @eparis.  I'd be more interested in seeing if a fmt.Formatter implementation would solve this problem.

@eparis I meet a problem is that we need to record the command for rollout. We want to show the command to user and don't expose the secrets. If I print "******", I am not sure whether it is the original value or not. I think we can add the secret flag to solve the problem.  Developers can call SecretEncode() to handle the secret flag formatted.

I understand that you want to print ****** for some flag values. Can you show an example program of how you think this might be used? Because right now I don't see where cobra is getting you much of value.
I see how flag.Secret can be useful to your program. Although I wonder if an annotation could solve that as well. But it still leaves me wondering how you think SecretEncode and SecretDecode should be used.
maybe a unit test would make it better for me to understand?

@xilabao,
Can you create a custom type (type SecretString string) in your application and have it implement the fmt.Formatter interface?  I'm wondering if you can solve this locally without bloating pflag.

@eparis  I thought that the "" is a part of flag as a default value to cover the real value. SecretEncode and SecretDecode are used to exchange the real value and the unreal value, just like get or set a value.  If the "" is not a default value, I think  SecretEncode and SecretDecode are not important.

@moorereason I get your point. In my opinion, flag.Secret might be a essential element. The value is a secret can't to output, but the flag need to output. flag.Secret is useful to deal with it. Different with flag.Hidden, flag.Hidden doesn't want to expose the usage of the flag.

@eparis Sorry. I make a mistake on annotation of flag.Secret. cobra doesn't use it. The actual example is https://github.com/kubernetes/kubernetes/pull/35030

Great, now I see what you are doing. I'm going to let it roll around in my head, but I think Clayton might be wrong and we will want to do it all in kubernetes and not make any changes here in pflag...

I put my comments in https://github.com/kubernetes/kubernetes/pull/35030
I basically see two paths to get what you want:

Create a function in cobra/pflag called something like 'GetCmdLine()` which will "re-generate" a command line from the set flags. In which case flag.Secret and different formatters would be useful.
Continue to do os.Args parsing in kubernetes and make no changes in pflag.


Fix flex floating point error causing unnecessary striped warnings

Also:

Provide a better message when you lerp from infinity to finity
constraints.

Make the striped marker support RTL.

By popular demand, dump a warning to the console the first time
a particular Flex overflows. (Resets on hot reload.)

Fixes https://github.com/flutter/flutter/issues/12423

cc @apwilson

We'll need to update the revision of package:flutter that Fuchsia uses after this change lands:
https://fuchsia.googlesource.com/manifest/+/master/flutter#7

Apparently I broke some of our more obscure sanity checks, I'll have to fix those before I land.

Fixes https://github.com/flutter/flutter/issues/12119

Was this ever fixed? It's driving me insane.

the patch here was landed; if you're still seeing this please file a new bug with some code that shows the problem

I am getting the same issue. Don't know how to solve it.


RuntimeError when 'pod install'

I get this error when trying to install pods. Xcode 10 and CocoaPods 1.6.0.beta.1 (and also the latest stable):
........./MyApp/Pods/Carte/Sources/Carte/ruby/2.3.0/gems/xcodeproj-1.5.2/lib/xcodeproj/project/object.rb:321:in 'configure_with_plist': [!] Xcodeproj doesn't know about the following attributes {"inputFileListPaths"=>[], "outputFileListPaths"=>[]} for the 'PBXShellScriptBuildPhase' isa. (RuntimeError)
Any ideas?

@shmakovigor @vkcldhkd please check this thread it works to me

@dnkoutso that issue can happen even when the lists are empty in Xcode 10 UI.
I had to manually edit the project.pbxproj file and delete the concerned lines to be free of that issue.

https://user-images.githubusercontent.com/1257961/43145191-b9276cd8-8f56-11e8-826b-c4b0af66d330.png


[GOBBLIN-1584] Add replace record logic for Mysql writer

Allows user to configure a mysql ingestion job to allow replacement of the record's value for an existing record in the table.
Also replaces a backward iteration of ResultSet() with forward iteration in MySqlWriterCommands

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[X] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1584

Description

[X] Here are some details about my PR, including screenshots (if applicable):
We only support insertion of new values into tables, not update/upsert. If you run an ingestion job with a record containing a record with the same primary key the whole job will fail because of the duplicate entry. We don't expect ingestion jobs to always contain only new records, so we should handle duplicate entries, ingestion of data already in the table or updates to old values. The insert vs. replace logic should be configurable to the user as well.

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:
It adds a unit test that utilizes replace logic in the JdbcPublisherTest.
I have also tested manually by copying duplicate data and repeated primary keys into a Mysql table and verified the values were updated.

Commits

[X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@Will-Lo @phet @arjun4084346 can you review?

Codecov Report

Merging #3438 (5a8ef31) into master (a7df7ca) will decrease coverage by 3.16%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3438      +/-   ##
============================================
- Coverage     46.58%   43.42%   -3.17%
+ Complexity    10331     2030    -8301
============================================
  Files          2074      404    -1670
  Lines         80880    17349   -63531
  Branches       9022     2120    -6902
============================================
- Hits          37680     7534   -30146
+ Misses        39728     8979   -30749
+ Partials       3472      836    -2636

Impacted Files
Coverage Δ

...lin/util/filesystem/FileSystemInstrumentation.java
92.85% <0.00%> (-7.15%)
:arrow_down:

...pache/gobblin/configuration/ConfigurationKeys.java

...blin/writer/commands/BaseJdbcBufferedInserter.java

...gobblin/writer/commands/MySqlBufferedInserter.java

...e/gobblin/writer/commands/MySqlWriterCommands.java

...che/gobblin/qualitychecker/row/RowLevelPolicy.java

...onverter/string/StringSplitterToListConverter.java

...gobblin/compliance/purger/HivePurgerExtractor.java

...n/java/org/apache/gobblin/r2/R2ResponseStatus.java

...rc/main/java/gobblin/source/workunit/WorkUnit.java

... and 1661 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7df7ca...5a8ef31. Read the comment docs.


WinGetSvc-Validation (Manifest Content Validation) fails

Hi,
I'm getting a failed WinGetSvc-Validation (Manifest Content Validation) when trying to submit the MEGASync installer #804. The job sais GET requests are not supported by the copy source, but in the previous line I can see the installer URL with a dot (.) at the end of line, making the URL inaccessible https://dev.azure.com/ms/winget-pkgs/_build/results?buildId=82031&view=logs&j=c8020aa5-4aab-5881-691f-21986e02afd0&t=bade86d6-d2be-5ddd-c1b9-7d8db9c4a60d&l=40
5/22/2020 6:28:17 PM Status: Completed Result: Failed Error occurred during installer copy from https://mega.nz/MEGAsyncSetup.exe. Range GET requests are not supported by the copy source.
This character doesn't appear in the YAML file. I validated and tried the Winget YAML file on my machine and everything worked well.

See https://github.com/microsoft/winget-pkgs/issues/523.

@javiergualix I'm scanning over old issues. It looks like the range request issue is closed. I did a quick search and found "Mega.MEGASync <IP_ADDRESS>". I'm going to close this issue. Feel free to reopen if it's not the same package you were looking for.


Option to specify port when running the server?

My project is based on create-react-app. npm start by default will run the application on port 3000 and there is no option of specifying a port in the package.json.
How can I specify a port of my choice in this case? I want to run two of this project simultaneously (for testing), one in port 3005 and other is 3006
SO Question

You can specify your port with process.env.PORT. It can be done by changing the script for start in package.json as shown below:
"start": "PORT=3006 react-scripts start"

You mean my package.json will be
{
  "start": "PORT=3006 react-scripts start",
  "name": "igene-web",
  "version": "0.1.0"......... }

then npm start?
didn't work for me (windows and ubuntu)

@fireflieslive no it is not. You should change the start command inside scripts section in your package.json

haha, where am i looking. thanks!

You're welcome. If your issue is solved you can close the issue :D

works with ubuntu, not with windows:

'PORT' is not recognized as an internal or external command,
operable program or batch file.

The above command is Unix (Ubuntu, Mac, etc…). In windows enviroment, you need a different syntax. Google something like "set env in windows command line"

For windows you can use cross-env https://www.npmjs.com/package/cross-env

You can also create an .env file with
PORT=3006

and save it in your project directory.

This worked for me, thanks!

On Windows with yarn this worked for me:
"scripts": {
"start": "set PORT=3006 && react-scripts start",
....

Or use npm cross-env (without &&!)
"scripts": {
    "start": "cross-env PORT=3006 react-scripts start",
}

how to do it with the build folder ?

Deployment is a bit different, you can read our documentation on that @webmobiles.
Open an issue if you run into any trouble / find something wrong!

"start": "PORT=3006 react-scripts start"
in package.json change it.


Update save.py warning message

Before:
Unsloth: Kaggle/Colab has limited disk space. We need to delete the downloaded
model which will save 4-16GB of disk space, allowing you to save on Kaggle/Colab.
Unsloth: Will remove a cached repo with size 4.1G
Unsloth: Merging 4bit and LoRA weights to 16bit...
Unsloth: Will use up to 6.42 out of 12.67 RAM for saving.
Unsloth: Saving model... This might take 5 minutes ...
 47%|████▋     | 15/32 [00:01<00:01, 12.39it/s]We will save to Disk and not RAM now.
100%|██████████| 32/32 [01:04<00:00,  2.01s/it]

After:
Unsloth: Kaggle/Colab has limited disk space. We need to delete the downloaded
model which will save 4-16GB of disk space, allowing you to save on Kaggle/Colab.
Unsloth: Will remove a cached repo with size 4.1G
Unsloth: Merging 4bit and LoRA weights to 16bit...
Unsloth: Will use up to 6.42 out of 12.67 RAM for saving.
Unsloth: Saving model... This might take 5 minutes ...
 47%|████▋     | 15/32 [00:01<00:01, 12.39it/s]
We will save to Disk and not RAM now.
100%|██████████| 32/32 [01:04<00:00,  2.01s/it]

Thanks! :)


Baggage propagation stop working after switching from B3 to either W3C or AWS

Describe the bug
Please provide details of the problem, including the version of Spring Cloud that you
are using.
According to this doc- https://docs.spring.io/spring-cloud-sleuth/docs/current/reference/html/project-features.html
Our application is using baggage propagation to persist some tenant context between our micro-services.
We are currently using B3 as the propagation.type and the baggage persistence is working fine. But after setting spring.sleuth.propagation.type=AWS, the baggage propagation stopped working and I found all our tenant context is disappeared from the request header.
Diving into the code a bit and I found the difference here - https://github.com/spring-cloud/spring-cloud-sleuth/blob/3.1.x/spring-cloud-sleuth-autoconfigure/src/main/java/org/springframework/cloud/sleuth/autoconfig/brave/BraveBaggageConfiguration.java#L169
If the spring.sleuth.propagation.type=B3, it will use the BaggagePropagation if not it is going to default to CompositePropagationFactory which doesn't write the baggage info to the header. Is this expected?
Sample
If possible, please provide a test case or a minimal Maven sample written in Java that reproduces
the problem. This makes it much easier for us to diagnose the problem and to verify that
we have fixed it.

Found more info below
When spring.sleuth.propagation.type=B3, the Propagation.Factory is a BaggagePropagation object which takes care of both Tracing propagation and baggage propagation in https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/baggage/BaggagePropagation.java#L306-L326
When spring.sleuth.propagation.type=AWS, the Propagation.Factory is a BaggageFactoryWrapper object which only does Tracing propagation.

Sleuth is a feature complete project that is out of OSS support. Please migrate to Micrometer Tracing


Separated merger and tester fixtures, fixed leftoever nulls.

Description

Merger unit tests are using a spec from fixtures. This makes it a bit difficult to grok what's where when trying to add tests. I copied a spec from tester into merger fixtures.
Fixes https://github.com/opensearch-project/opensearch-api-specification/issues/558.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kolchfa-aws I re-added x-version-added: 2.4 for the types you've added in this PR here.


runRPCAgent waits for process to complete

In the Python wrapper, the RPC Agent launcher will wait for the called process to complete. Since the launcher is meant to stay running, the rest of the code never executes.

@simbs @salihoztop - How is this going? Resolved?

Resolved b7e25c9b8137468e152281895833881daea9dac5


Beyla panics when instrumenting a Kubernetes Statefulset

Trying to instrument a Statefultset in a Kubernetes cluster made Beyla crash:
/opt/app-root/pkg/internal/discover/watcher_proc.go:122 +0x2b8
created by github.com/grafana/beyla/pkg/internal/discover.(*pollAccounter).Run in goroutine 247
	/usr/local/go/src/runtime/asm_amd64.s:1700 +0x1
runtime.goexit({})
	/opt/app-root/pkg/internal/discover/watcher_proc.go:122
github.com/grafana/beyla/pkg/internal/discover.(*pollAccounter).Run.gowrap1()
goroutine 290 [runnable]:
	/opt/app-root/pkg/internal/ebpf/tracer_linux.go:219 +0x307
created by github.com/grafana/beyla/pkg/internal/ebpf.RunUtilityTracer in goroutine 247
	/usr/local/go/src/runtime/asm_amd64.s:1700 +0x1
runtime.goexit({})
	/opt/app-root/pkg/internal/ebpf/tracer_linux.go:219
github.com/grafana/beyla/pkg/internal/ebpf.RunUtilityTracer.gowrap1()
goroutine 289 [runnable]:
	/usr/local/go/src/net/http/transport.go:1875 +0x15a5
created by net/http.(*Transport).dialConn in goroutine 179
	/usr/local/go/src/net/http/transport.go:2519 +0xe7
net/http.(*persistConn).writeLoop(0xc02a14c480)
goroutine 274 [select]:
	/usr/local/go/src/net/http/transport.go:1875 +0x15a5
created by net/http.(*Transport).dialConn in goroutine 257

This seems to be unrelated, closing for now.


Fix long cast upload-signature description

Minor fix that turns this

Into this

Also I think an alias for this command should be us as most other aliases use first letters of the command words unless there is a conflicting alias


Invariant Violoation: requireNativeComponent: "RNTShadowView" was not found in UIManager

Hey there, so the ShadowViews work on IOS, but when I try and utilize them on android I get this stack trace:
Invariant Violation: Invariant Violation: requireNativeComponent: "RNTShadowView" was not found in the UIManager.

node_modules\react-native\Libraries\ReactNative\getNativeComponentAttributes.js:29:4 in getNativeComponentAttributes
node_modules\react-native\Libraries\Renderer\shims\ReactNativeViewConfigRegistry.js:104:25 in get
... 18 more stack frames from framework internals

is this due to my setup? I'm using the highest version of Expo available. At the top of my component file(when importing the ShadowView) I get a warning for the file path that reads:
"Could not find a declaration file for module 'react-native-simple-shadow-view'. 'c:/Users/DSangha/Documents/ti-js-reactnative-lottoapp/node_modules/react-native-simple-shadow-view/index.js' implicitly has an 'any' type.
Try npm install @types/react-native-simple-shadow-view if it exists or add a new declaration (.d.ts) file containing declare module 'react-native-simple-shadow-view';"
I attempted the npm install for @types and it gave me a 404 error.
Here is a snack attempting what I'm attempting:
https://snack.expo.io/@dsangha/noshadow
The error isn't exactly the same, but it does appear that on android the RNTShadowView has been either removed or isn't linked properly maybe?

Hello
have you added this in android/app/build.gradle
renderscriptTargetApi 18
 renderscriptSupportModeEnabled true

Hey there, I've decided to just use a different library: https://www.npmjs.com/package/react-native-shadow-view, and it works with little to no hassle.


Change gen JSON output from stream to array

What
soroban gen --wasm ... --output json gives an invalid json output
Why
Fix the json output of the gen command
Known limitations
NA

@vinamogit This can't be merged until you merge the main branch into your branch.

@vinamogit Your branch is out of date again. Could you check the box that lets me be able to push to the branch, so that I can update it and merge it in one step?

Sorry, can't find the option. I've added you as contributor the the repo, hope that helps.

It's merged! Thanks @vinamogit. You can remove me now.


Problem testing locally

Hello,
I wasn't sure how to get in touch with you and the the Helper forum is down so I though I might try this. I know it's not the proper use of this feature.
I'm having trouble testing locally and using the debugging tool locally. I thought I might just need to change the path for the various txt files to local documents but that doesn't seem to do anything.
I have used used the testDonation function in the html file by changing the seconds from 0. While that does show a message it doesn't play the sound and it doesn't go away so it's not the most helpful.
Any guidance in how to properly test locally would be great thanks.
Best,
Nick

Hey Nick!  Sorry for the late reply. The testing files that are there are probably pretty old and the contents may not accurately reflect the reponses from the most recent Extra Life API. With that said, the way to use them is to run a local web server on your machine and host those files and then change the Extra Life API URL to the URL of your local webserver. Hope that helps, and good luck!

Hey,
Now worries, thanks for the information. I'll give that a try. Also thanks for making such an awesome tool for the community to use!
Nick
—
[Nicholas Menghini]
Product & Graphic Designer
e: [<EMAIL_ADDRESS>w: [nicholasmenghini.com]
On Sat, Sep 12th, 2020 at 3:53 PM, breadweb<EMAIL_ADDRESS>wrote:

Hey Nick! Sorry for the late reply. The testing files that are there are
probably pretty old and the contents may not accurately reflect the
reponses from the most recent Extra Life API. With that said, the way to
use them is to run a local web server on your machine and host those files
and then change the Extra Life API URL to the URL of your local webserver.
Hope that helps, and good luck!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub (
https://github.com/breadweb/extralife-helper/issues/10#issuecomment-691537582
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/ABHTS2RXVFKO3AZE7UYGDADSFPGTRANCNFSM4QWTMBYA
).


Validation Schema ToJSON with Discriminator and Sum datatype

First of all, thank you for this great library.
We wanted to go further and set up tests on Schema/ToJson validation (validateToJSON).
For simple types, it works without any problem.
Beside, we have sum datatypes with a field as discriminant. So, I added Discriminator on this fiedl. But the test fail with:
["Value not valid under any of 'oneOf' schemas: Object (fromList [(\"objectType\",String \"ObjectOne\"),(\"identifier\",String \"123\"),(\"name\",String \"object one\")])"

I haven't found where I am wrong. I tried the different sumEncoding without success.
Below is the code with the tests in fail.
module Commons.Model.Discriminator where

import Data.Aeson
import Data.Aeson.Types
import qualified Data.HashMap.Strict as HM
import Data.OpenApi as OpenApi
import Relude

data SuperObject
  = Object1 ObjectOne
  | Object2 ObjectTwo
  deriving (Generic, Show, Eq)

instance ToJSON SuperObject where
  toJSON = genericToJSON defaultOptions {omitNothingFields = True, sumEncoding = UntaggedValue}

instance FromJSON SuperObject where
  parseJSON anObject@(Object p) =
    case HM.lookup "objectType" p of
      Just "ObjectOne" -> Object1 <$> parseJSON anObject
      Just "ObjectTwo" -> Object2 <$> parseJSON anObject
      _ -> fail "expected ObjectOne or ObjectTwo"
  parseJSON invalid = typeMismatch "ObjectOne or ObjectTwo" invalid

instance ToSchema SuperObject where
  declareNamedSchema val = do
    mediaSchema <- genericDeclareNamedSchema defaultSchemaOptions val
    let newDiscriminator =
          Discriminator
            { _discriminatorPropertyName = "objectType",
              _discriminatorMapping = [("ObjectOne", "#/components/schemas/ObjectOne"), ("ObjectTwo", "#/components/schemas/ObjectTwo")]
            }
    pure $ addOneDiscriminator newDiscriminator mediaSchema

addOneDiscriminator :: Discriminator -> NamedSchema -> NamedSchema
addOneDiscriminator newDiscriminator namedSchema@NamedSchema {_namedSchemaSchema = initialSchema} =
  namedSchema {_namedSchemaSchema = initialSchema {_schemaDiscriminator = Just newDiscriminator}}

data ObjectOne = ObjectOne
  { identifier :: Text,
    name :: Text,
    objectType :: Text
  }
  deriving (Generic, Show, Eq)

instance ToJSON ObjectOne where
  toJSON = genericToJSON defaultOptions

instance FromJSON ObjectOne where
  parseJSON = genericParseJSON defaultOptions

instance ToSchema ObjectOne where
  declareNamedSchema = genericDeclareNamedSchema defaultSchemaOptions

data ObjectTwo = ObjectTwo
  { identifier :: Text,
    name :: Text,
    objectType :: Text
  }
  deriving (Generic, Show, Eq)

instance ToJSON ObjectTwo where
  toJSON = genericToJSON defaultOptions

instance FromJSON ObjectTwo where
  parseJSON = genericParseJSON defaultOptions

instance ToSchema ObjectTwo where
  declareNamedSchema = genericDeclareNamedSchema defaultSchemaOptions

Test module:
module Commons.Model.DiscriminatorSpec where

import Commons.Model.Discriminator
import Relude
import Data.Aeson as Aeson
import Data.Aeson.QQ
import Data.OpenApi.Schema.Validation (validateToJSON)
import Test.Tasty.HUnit

test_validateSchemaToJSON_superObject1 =
  testCase "When validating a SuperObject Object1 against the schema, then everything is valid" $
    let superObject =
          Object1
            ObjectOne
              { identifier = "123",
                name = "object one",
                objectType = "ObjectOne"
              }
     in validateToJSON superObject @?= []

test_validateSchemaToJSON_superObject2 =
  testCase "When validating a SuperObject Object2 against the schema, then everything is valid" $
    let superObject =
          Object2
            ObjectTwo
              { identifier = "123",
                name = "object two",
                objectType = "ObjectTwo"
              }
     in validateToJSON superObject @?= []

Hi! Thanks for the report!
I personally did not use discriminators, so it's possible I've missed something in the implementation. I will try to take a look.

Hello @maksbotan any news regarding this issue? 😄

Hello @maksbotan any news regarding this issue? 😄

Hi! Sorry for the delay, sadly I didn't get to this issue yet.
If you can try and make a PR fixing this, I would very much appreciate ;)

Hi! Sorry for the delay, sadly I didn't get to this issue yet.
If you can try and make a PR fixing this, I would very much appreciate ;)


[HUDI-8066] cherry pick Flink 1.18 into 0.14.2

Change Logs
Cherrypick the diff https://github.com/apache/hudi/pull/9949 into branch release-0.14.2
Impact
No
Risk level (write none, low medium or high below)
No
Documentation Update
No needed
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

We're going to release 0.15.1 from branch-0.x.  branch-0.x and 0.15.0 already support Flink 1.18.

Azure tests passed: https://dev.azure.com/apachehudi/hudi-oss-ci/_build/results?buildId=207&view=results


feature(data): add deployments, daemonsets to cluster data

installedDeisData.Get() now employs the Deployments(), DaemonSets() k8s interfaces in addition to ReplicationControllers() in order to present a complete set of workflow components when gathering cluster data.
Includes basic test coverage, with the caveat that because our current interfaces act as a union between the api and extensions resources, we'll probably need to build out our own fake client library in order to fully test.

Current coverage is 40.03% (diff: 0.00%)

Merging #95 into master will decrease coverage by 3.43%

@@             master        #95   diff @@
==========================================
  Files            11         11
  Lines           582        632    +50
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            253        253
- Misses          285        335    +50
  Partials         44         44

Powered by Codecov. Last update 31fe3bc...1940db1

we'll probably need to build out our own fake client library in order to fully test

If that's out of scope for the next Workflow release, let's make sure to create an issue to track it.

@mboersma good idea: https://github.com/deis/workflow-manager/issues/96

fixes #90


Issue: array of array of numbers not properly supported

Hello guys,
I am migrating my API doc from Slatedocs to RapiDoc, and you are doing an amazing work!
Maybe I am missing something, but I think there is an issue with the management of array of array of numbers.
--
First, about the display of the type.
Reproducer
assetsPrices:
  type: array
  items:
    type: array
    items:
      type: number

In Swagger, this displays properly as:

But in RapiDoc, the display is showing an empty array of array:

I would have expected to see [[number]] in the first RapiDoc display mode, and either array of array of numbers or array of [number] in the second RapiDoc display mode.
--
Second, about the description.
Reproducer
assetsPrices:
  description: Titi
  type: array
  items:
    description: Toto
    type: array
    items:
      type: number

In Swagger, the two descriptions display properly:

But in RapidDoc, is seems there is an issue, with only the first description showing:

Now, if the first description is removed, the second appears, but is put between weird array<> text:

--
Would it be possible to have your opinion about this behaviour ?
Cheers,
Roman

Array of array of number issue is taken care of
check it out here https://mrin9.github.io/RapiDoc/examples/array-and-object-nesting.html#get-/array-of-array-of-primitive
Regarding description
In RapiDoc to improve nesting readability in schema we combine them in pairs of complex types. What I mean by that is
an array of object is represented as
 [{    <-- collapsing two complex types into single line
   ...
   ...
 }]

same is for array of array
 [[    <-- collapsing two complex types into single line
   ...
   ...
 ]]

in general it works great. provides a compact view of large schemas. Now since we collapse two complex type into single line
we can only show one description as showing both description on same line may be confusing. Therefore the way we deal with this is to give priority to the  outer level description if thats missing then use the lower level description
So in the case where we have the below schema
assetsPrices:
  description: Outer array description
  type: array
  items:
    description: Inner array description
    type: array
    items:
      type: number

since it has both the description only top description will be shown
if the top description is missing then below description will be shown (but to indicate that the description belongs to the inner array we use array<....> syntax

Field
Type
Description

assetsPrices
array of array of number
array < Inner array description >

in general this system works great in most of the cases and was developed by interviewing several users in the past

Hello @mrin9 !
Thanks, you rocks.
Cheers,
Roman


Implement simple logic for automatic ServingRuntime selection

Description
An InferenceService is allowed to omit specifying a runtime. This should lead to automatic selection of a ServingRuntime from an allowed pool of ServingRuntimes.
These changes implement the automatic selection of a ServingRuntime: if there are several runtimes available, order priority is by creation date (most recent first). If several runtimes have the same creation date, priority is by alphabetical order.
How Has This Been Tested?

Creating one or more ServingRuntime resources, where one (or more) of theirs supportedModelFormats has autoSelect: true.
Then, create an InferenceService without specifying a runtime.

Test using a model format that would match an auto-selectable ServingRuntime
Test using a model format that would not match any ServingRuntime

Testing Instructions
Live build is here: quay.io/edgarhz/rhods-operator-live-catalog:1.23.0-7468

Install rhods from the provided live build, or install the model controller from this PR.
Create a ServingRuntime that has model formats with autoSelect: true

The test-openvino-serving-runtime-1.yaml used in unit tests works.

Create an InferenceService that does not specify a runtime

The openvino-inference-service-no-runtime.yaml added in this PR works with the mentioned ServiceRuntime in the previous bullet.

Check that a route is created correctly.

If you are using the two resources mentioned in the previous points, oc get route -n default example-onnx-mnist-no-runtime should return a result. This would indicate that the odh-model-controller is running OK (before this PR, it crashed).

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

/lgtm


Error Yields Hundreds of Requests

If a user is logged out and loads a page and gets an error, we seem to retry hundreds of times. My guess is a poorly considered event listener. I'll find + fix.

Should be fixed in #14


Extending with custom configurations

I might out my poor Lua skills now, but I'm trying to figure out how to extend the configuration with a custom runner. So, my question is if it's currently possible?

No it's not possible. There's no way to feed in a user config. Take a look at some of the other Neovim DAP adapters for inspiration and a PR should be relatively straightforward.

@olimorris, I did some investigation and it turns out it actually is possible to extend the configuration table. This is what I did it to append a config for running puma-dev:
    require('dap-ruby').setup {}

    table.insert(dap.configurations.ruby, {
      type = 'ruby',
      name = 'run puma',
      bundle = 'bundle',
      request = 'attach',
      command = 'puma [...args for puma]',
      port = 38698,
      server = '<IP_ADDRESS>',
      options = {
        source_filetype = 'ruby',
      },
      localfs = true,
      waiting = 1000,
    })

@suketa, perhaps the info above could be useful for the readme?

Nice work!
It's common practice for the plugin to have a config.lua file which allows for the default config to be extended/overwritten by a user's. Would be a much cleaner API.


feat: allow to configure password history in management ui for domain…

… & application
fixes AM-29
How to test

Update the password policy at domain level

Update the password policy at application level

Functionalities checked both mongo and jdbc and looks good. UI english language could be better. I have approved this pull request but suggesting @farmborough to check the English language in UI at least.


RFC: EventQueue

This is a big idea. I'd like some comments on this rather ambitious overhaul of the event system.
EventQueue is an object-oriented replacement for the functions that exist in sdl2::event.
There can only be one EventQueue per process, and cannot be owned or mutated by any other thread but the main thread (!Send, Sync).
// A unit struct. Since the native SDL event queue is global,
// SDL doesn't expose any pointers for the event queue.
struct EventQueue;

impl EventQueue {
    /// new() can only be called once. Otherwise, it will panic.
    pub fn new() -> EventQueue {...}
    pub fn flush_event(&mut self, event_type: EventType) {...}
    pub fn flush_events(&mut self, min_type: u32, max_type: u32) {...}
    pub fn peek_events(&self) -> Vec<Event> {...}
    pub fn poll_event(&mut self) -> Option<Event> {...}
    pub fn poll_iter(&mut self) -> EventQueuePollIterator {...}
    pub fn pump_events(&mut self) {...}
    pub fn push_event(&mut self, event: Event) {...}
    pub fn wait_event(&mut self) -> Event {...}
    pub fn wait_event_timeout(&mut self, u32 timeout) -> Option<Event> {...}
}

struct EventQueuePollIterator<'a> {
    event_queue: &'a mut EventQueue
}

impl<'a> Iterator for EventQueuePollIterator<'a> {
    pub type Item = Event;

    fn next(&mut self) -> Option<Event> {...}
}

Behold: Iterators
The EventQueue is iterable!
let mut event_queue = EventQueue::new();

for event in event_queue.poll_iter() {
    use sdl2::event::Event;
    match event {
        Event::Quit {..} => break,
        // ...
    }
}

let mut event_queue = EventQueue::new();
// All of IteratorExt is available to us
// Poll the queue until empty, and collect it into a vector
let events: Vec<Event> = event_queue.poll_iter().collect();

The use of iterators renders Event::None obsolete (not a real SDL event), and would be removed in favor of Option::None.
SDL has the function SDL_FilterEvents for filtering events we want to ignore.
Luckily, we don't need to wrap this because we have IteratorExt::filter()!
for event in event_queue.poll_iter().filter(|e| e.get_type() == EventType::KeyDown) {
    ...
}

SDL has the functions SDL_HasEvent and SDL_HasEvents for checking if the queue has an event type. We don't need to wrap those, either!
// okay, this is a bit verbose. todo: extension traits?
let has_it = event_queue.peek_events().into_iter().any(|e| e.get_type() == EventType::KeyDown);

EventQueue is safer

We're able to make the event queue thread safe: the event queue is accessed only through instance methods.
EventQueue implements the traits:

!Send - the event queue must only be mutated on the main thread
Sync - the event queue can be safely read from other threads (peek_events())

As a concrete type, EventQueue is something that can be borrowed and have a lifetime associated to.
The borrow checker plays into thread safety, as described above. &mut self methods are only callable on the main thread, and &self methods are callable on any thread.
This could tie in with #322. Now we have a value that is borrowable at every point except for during the event loop. Getting closer...
Just like some other Rust iterators (usually the iter_mut() kind), we can't have two EventQueuePollIterators alive at a time

Sounds cool. The one big thing to consider is, will it still work happily with Piston and the like?

This would break virtually every SDL2 project, unfortunately.
It's fairly trivial to update, nonetheless. Most people have their event loop somewhat written like this:
while game_is_running {
    loop {
        match sdl2::event::poll_event() {
            Event::Quit {...} => ...,
            Event::KeyDown { scancode, ... } => ...,
            Event::None => break,
            ...
        }
    }
    // the rest of the game...
}

would become...
let mut event_queue = EventQueue::new();

while game_is_running {
    for event in event_queue.poll_iter() {
        match event {
            Event::Quit {...} => ...,
            Event::KeyDown { scancode, ... } => ...,
            ...
        }
    }
    // the rest of the game...
}

For projects that poll events one-at-a-time (I believe Piston does this), they still have the EventQueue::poll_event() method:
fn abstract_the_poll_event(&mut self) {
    match sdl2::event::poll_event() {
        Event::Quit {...} => ...,
        Event::KeyDown { scancode, ... } => ...,
        Event::None => break,
        ...
    }
    // do other stuff...
}

would become...
fn abstract_the_poll_event(&mut self) {
    match self.event_queue.poll_event() {
        Event::Quit {...} => ...,
        Event::KeyDown { scancode, ... } => ...,
        ...
    }
    // do other stuff...
}

Instead of removing the old functions outright and have everything break at once, we could put up deprecation notices for about a week. How does that sound?

Deprecation notices are fine :) My worry was more interacting badly with Piston's own events library, but if that's still fine, then it's all good.

+1 I like this improvement a lot.

Couldn't this be another library on top of rust-sdl2? I like having an sdl2 wrapper that's basicaly just a minimal rusty sdl2 wrapper.

There's still the problem of thread safety, which is non-negotiable in Rust.
The problem with the old implementation is that functions such as poll_event() can be called on any thread; there is nothing stopping somebody from calling poll_event() concurrently on multiple threads. While it's unlikely, I guarantee you that someone will try it.
Basically, the type gives us a handle that can be accessed exclusively with &mut self. Since the type can't be moved to other threads (!Send), &mut self methods can only be called on the main thread.
There's not a whole ton of sugar to this. For the most part, it's still fairly straight-forward bindings.
The iterator is just an idiomatic, yet simple, add-on: all it does is call EventQueue::poll_event().

Progress so far: https://github.com/nukep/rust-sdl2/compare/AngryLawyer:efa23dc...1542682
Check out the documentation: https://nukep.github.io/rust-sdl2/sdl2/event/index.html
Some functions like SDL_AddEventWatch() and SDL_RegisterEvents() are still unimplemented.

After some thought, I moved all of the thread-safe functionality outside of EventQueue (the way it was). Additionally, I renamed EventQueue to EventPump, as only functions that pump events with SDL_PumpEvents() (such as poll_event(), pump_events(), wait_event(), etc.) are left.
A reasonable event-related use case is to use a Timer to push user events to the event queue (this is thread-safe).
If borrowing the event queue is the only way to push events, it will be impossible to do this with a Timer that transcends the event loop.
let mut event_queue = EventQueue::new();

let timer = Timer::new(0, box || {
    event_queue.push_event(Event::User {
        timestamp: 0, window_id: 0, _type: event_type, code: 0
    }).unwrap();
    // 1-second interval
    1000
});

// Timer cannot live beyond this point - the loop needs an exclusive reference to the event queue
for event in event_queue.poll_iter() {
    ...
}

Maybe deprecation notices aren't such a good idea after all.  There are already some breaking changes (like removing Event::None in favor of Option::None), so people will be forced to update their code anyway.

A pull request is coming reaaallly soon.
If nobody objects, I'd also like to propose an SDL "context" object. This will aid in ensuring thread safety invariants for the event pump.
pub struct Sdl {
    // probably nothing here but markers
}

// Cannot be sent to non-main threads
impl !Send for Sdl {}
impl !Sync for Sdl {}

impl Sdl {
    pub fn init(flags: InitFlag) -> SdlResult<Sdl> {
        // call SDL_Init(), ensure no other `Sdl` instances exist...
    }
    pub fn event_pump(&self) -> EventPump { ... }
}

impl Drop for Sdl {
    // call SDL_Quit()
}

let sdl_context = Sdl::init(sdl2::INIT_VIDEO);

let mut event_pump = sdl_context.event_pump();
for event in event_pump.poll_iter() {
    // ...
}

In order to use the event pump, you must first initialize SDL.
SDL_Quit() is unconditionally called.
Sdl represents the "main thread": any SDL object that requires initialization or use on the main thread must reference Sdl.
Types like Window, which must be created on the main thread, would eventually require a reference to Sdl. (e.g. Window::new(sdl: &Sdl, ...)).


Correct webdriver executable fixture in README

Took me a moment to discover that there's no such fixture as splinter_driver_executable, so here's a fix. I also clarified that it should return a directory, not a path to executable. Although if that is the case, perhaps we should add a _dir or _directory suffix for fixture name (and CLI option)?

It seems to me that the splinter_webdriver_executable fixture/config option is only used for the Chrome browser, and in that case it seems to be the path to the chromedriver executable, not the parent directory.
Using the path to the executable the test works:
$ pytest  --splinter-webdriver=chrome --splinter-webdriver-executable=/usr/local/bin/chromedriver tests/test_plugin.py::test_browser
======================================== test session starts ========================================
platform darwin -- Python 2.7.15, pytest-3.10.1, py-1.7.0, pluggy-0.8.1 -- /Users/youtux/Developer/pytest-splinter/.env/bin/python2.7
cachedir: .pytest_cache
rootdir: /Users/youtux/Developer/pytest-splinter, inifile: tox.ini
plugins: xdist-1.26.1, localserver-0.5.0, forked-1.0.1, cov-2.6.1, pylama-7.6.6, splinter-2.0.1
collected 1 item

tests/test_plugin.py::test_browser PASSED                                                     [100%]

===================================== 1 passed in 2.39 seconds ======================================

Using the directory of chromedriver (/usr/local/bin/ in my case) fails because it is trying to execute that path:
$ pytest  --splinter-webdriver=chrome --splinter-webdriver-executable=/usr/local/bin/ tests/test_plugin.py::test_browser
======================================== test session starts ========================================
platform darwin -- Python 2.7.15, pytest-3.10.1, py-1.7.0, pluggy-0.8.1 -- /Users/youtux/Developer/pytest-splinter/.env/bin/python2.7
cachedir: .pytest_cache
rootdir: /Users/youtux/Developer/pytest-splinter, inifile: tox.ini
plugins: xdist-1.26.1, localserver-0.5.0, forked-1.0.1, cov-2.6.1, pylama-7.6.6, splinter-2.0.1
collected 1 item

tests/test_plugin.py::test_browser ERROR                                                      [100%]

============================================== ERRORS ===============================================
__________________________________ ERROR at setup of test_browser ___________________________________

request = <SubRequest 'browser' for <Function 'test_browser'>>
...
            elif err.errno == errno.EACCES:
                raise WebDriverException(
                    "'%s' executable may have wrong permissions. %s" % (
>                       os.path.basename(self.path), self.start_error_message)
                )
E               WebDriverException: Message: 'bin' executable may have wrong permissions. Please see https://sites.google.com/a/chromium.org/chromedriver/home

cmd        = ['/usr/local/bin', '--port=50494']
err        = OSError(13, 'Permission denied')
self       = <selenium.webdriver.chrome.service.Service object at 0x105da04d0>

.env/lib/python2.7/site-packages/selenium/webdriver/common/service.py:88: WebDriverException
====================================== 1 error in 0.19 seconds ======================================

God damn! Please

@cddumanov did you read @youtux comment?

Coverage remained the same at 87.5% when pulling 6203b70a0d0e9b698db03a9c5a9669592130a44d on zsiciarz:patch-1 into e6af25ad20450b9684387a4ca799bd265310a7bf on pytest-dev:master.

please what?
Alessio commented that if that's the directory, it's not true in all cases,
so please check for all corner cases
On Tue, Jan 7, 2020 at 9:03 PM Coveralls<EMAIL_ADDRESS>wrote:

[image: Coverage Status] https://coveralls.io/builds/27965130
Coverage remained the same at 87.5% when pulling 6203b70
https://github.com/pytest-dev/pytest-splinter/commit/6203b70a0d0e9b698db03a9c5a9669592130a44d
on zsiciarz:patch-1 into e6af25a
https://github.com/pytest-dev/pytest-splinter/commit/e6af25ad20450b9684387a4ca799bd265310a7bf
on pytest-dev:master.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/pytest-dev/pytest-splinter/pull/118?email_source=notifications&email_token=AADIJAD3JDOMPXMVQWXNFP3Q4TNYRA5CNFSM4GHEYM42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIKC76Y#issuecomment-571748347,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADIJAB5PZCLWMUYLFSOILDQ4TNYRANCNFSM4GHEYM4Q
.


Wrong preparation for integration tests

introduced with https://github.com/graphhopper/graphhopper/commit/442e032766f4456bf27db2b8fd1c91c7ea9887ca
Not the routing factory of the GraphHopper class is called but instead the create always AlgoHelperEntry.createAlgo which is wrong for the two prepared algos

Ugly. It looks like we introduced some differences for CH & bidirectional A* ... will now have to git bisect this ...


Postcode search endpoint

Reviewed. Looks good, left some comments.

Review comments addressed, thanks @lgonczar and @nickgravgaard for the quick feedback :)


Improved Database Loader DAG and development environment

Fixes #240 #297
Related to #296
Description

The main feature of this PR is that it adds a new, improved, parallelized Apache Airflow DAG to load data into the intermediary openledger DB in PostgreSQL.  It also adds a new containerized development setup using docker-compose.  This was necessary to enable testing of the new Airflow DAG.  As a side benefit, because the Airflow webserver's container uses the LocalExecutor, this also solves issue #297.  Finally, the docker-compose.yml and Dockerfiles have been designed so that they can be used (with some environment configuration) to deploy new versions of the Airflow container in production.
Unfortunately/fortunately, a migration to Apache Airflow 1.10.9 (previously, we were using 1.10.4) is part of this PR.  This made some aspects of testing the connections between the Airflow webserver and PostgreSQL more feasible.
To finish off #296, it remains to try out the configuration methods, add an Airflow metadata database to our RDS instance, and make sure everything works as expected in prod.
Checklist

[X] My pull request has a descriptive title (not a vague title like Update index.md).
[X] My pull request targets the master branch of the repository.
[X] My commit messages follow best practices.
[X] I added tests for the changes I made (if applicable).
[X] I added or updated documentation (if applicable).
[X] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@aldenstpage Okay, I've added a script that ensures the necessary DB is ready before proceeding.

@kgodey In Progress (Community) isn't the appropriate spot for this.  I'm the one working on it.

@mathemancer sorry, I was bulk moving PRs and clearly wasn't paying enough attention. Now that https://github.com/creativecommons/cccatalog/pull/320 is merged, your PRs will get into the active sprint in the correct column automatically.


Request and Update for Inference Script/Colab Notebook

Dear Authors,
Thank you for sharing your great work. Could you please provide an inference script or Colab notebook for visual grounding tasks? As per @logicwong comment on issue #19, it was indicated that a release was planned this week. I was hoping you could kindly provide an update on this.
Thank you for your time and efforts.

@hanoonaR We have provided the visual grounding API in our repo, hope it can help you.


feat(Enterprise Usage Reports): add service to project

PR summary
This PR adds the Enterprise Usage Reports service to the project, including integration tests and examples.
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

:tada: This PR is included in version 0.15.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: