Remove deprecate istioctl authn tls-check

Remove deprecated tool istioctl authn tls-check.
Issue:

https://github.com/istio/istio/issues/21821

@diemtvu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
385c11b7214f8698bd01376e14e011d4e51f9aae
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
385c11b7214f8698bd01376e14e011d4e51f9aae
link
/test lint_istio

unit-tests_istio
385c11b7214f8698bd01376e14e011d4e51f9aae
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
385c11b7214f8698bd01376e14e011d4e51f9aae
link
/test lint_istio

unit-tests_istio
385c11b7214f8698bd01376e14e011d4e51f9aae
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
385c11b7214f8698bd01376e14e011d4e51f9aae
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
385c11b7214f8698bd01376e14e011d4e51f9aae
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
385c11b7214f8698bd01376e14e011d4e51f9aae
link
/test integ-pilot-k8s-tests_istio

lint_istio
e82e1d84e867cea0ca476f48d550b1f0eba9f001
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
385c11b7214f8698bd01376e14e011d4e51f9aae
link
/test integ-pilot-k8s-tests_istio

lint_istio
e82e1d84e867cea0ca476f48d550b1f0eba9f001
link
/test lint_istio

unit-tests_istio
e82e1d84e867cea0ca476f48d550b1f0eba9f001
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
e82e1d84e867cea0ca476f48d550b1f0eba9f001
link
/test lint_istio

unit-tests_istio
e82e1d84e867cea0ca476f48d550b1f0eba9f001
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
e82e1d84e867cea0ca476f48d550b1f0eba9f001
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
e82e1d84e867cea0ca476f48d550b1f0eba9f001
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
e82e1d84e867cea0ca476f48d550b1f0eba9f001
link
/test integ-pilot-k8s-tests_istio

lint_istio
b37d962d9e5f92c219124c4a790b93f81395c213
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
b37d962d9e5f92c219124c4a790b93f81395c213
link
/test lint_istio

integ-pilot-k8s-tests_istio
b37d962d9e5f92c219124c4a790b93f81395c213
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
3995e66976f588cf0a30e6608e5785fc2d01cfbe
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
ffd89e702c83a4b5aa6e35eb8565c03e23266bdb
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Extend allocated time for integration tests

It happened multiple times that:
Test killed with quit: ran too long (1h1m0s)

E.g. here.

Fixed by #638


[DCOS-41166] Make getGitSHA robust for use in non-git folders

Use UNKNOWN as git sha for scheduler JAR in case of error
Don't pass .* to Docker context by default

When executing in a non-git folder or when building the docker image we now see:
./gradlew testClasses
Parallel execution is an incubating feature.

> Configure project :scheduler
fatal: Not a git repository (or any of the parent directories): .git
An error occurred while calculating the git hash. Using %s

See related PRs:

#2623 where the implicit requirement that this support a non-git repo folder was introduced.
#2644 where this caused issues

[15:22:31][Step 4/6] An error has occurred: FatalError: git failed. Is it installed, and are you in a Git repository directory?
[15:22:31][Step 4/6] Check the log at /root/.cache/pre-commit/pre-commit.log
[15:22:31][Step 4/6] The command '/bin/sh -c cd /tmp/repo/ &&     ./gradlew testClasses &&     pre-commit install-hooks &&     cd / &&     rm -rf /tmp/repo/' returned a non-zero code: 1
[15:22:31][Step 4/6] + echo '
[15:22:31][Step 4/6] ##teamcity[setParameter name='\''DOCKER_IMAGE'\'' value='\''dcos-commons:c5714ef'\'']
[15:22:31]
[Step 4/6] Incorrect property name.
Valid property list format is (name( )*=( )*'escaped_value'( )*)* where escape symbol is "|"
[15:22:31][Step 4/6] '

[15:22:31][Step 4/6] Check the log at /root/.cache/pre-commit/pre-commit.log
[15:22:31][Step 4/6] The command '/bin/sh -c cd /tmp/repo/ &&     ./gradlew testClasses &&     pre-commit install-hooks &&     cd / &&     rm -rf /tmp/repo/' returned a non-zero code: 1
[15:22:31][Step 4/6] + echo '
[15:22:31][Step 4/6] ##teamcity[setParameter name='\''DOCKER_IMAGE'\'' value='\''dcos-commons:c5714ef'\'']
[15:22:31]
[Step 4/6] Incorrect property name.
Valid property list format is (name( )*=( )*'escaped_value'( )*)* where escape symbol is "|"
[15:22:31][Step 4/6] '

That is a different issue though. This is because of pre-commit install-hooks in this case.


Add selectNextOccurrence command

New PR as requested at https://github.com/codemirror/commands/pull/1#issuecomment-813989077
I had to modify wordAt() to make it reusable, I hope it's not a problem.

Nice, thanks! I've merged this and modified the code a bit in attached patch, putting the implementation in selection-match.ts and making sure the command returns false when it can't act.


Cygwin support, fixes #156

Is the new cygwin path resolution executed on client, daemon or both?
I wonder, whether something like the following would work?

Daemon started by a request coming from a cygwin client
A subsequent request is done from cmd.exe shell

(or the other way round)

Is the new cygwin path resolution executed on client, daemon or both?
I wonder, whether something like the following would work?

Daemon started by a request coming from a cygwin client
A subsequent request is done from cmd.exe shell

(or the other way round)

I agree it should work.  The fact that code transforms all paths to actual windows paths should make it work in all cases I think.


DataSet

Hello, I loved the work, very well done,
I am not familiar with the dataSets that you used, so I tried to visualize it, I couldn't identify the pedestrian from the trajectory, I noticed in the head of the dataset number keep repeating, are they pedestrian indexes ? and the other rows, are they x and y of the trajectory ?
Thanks a lot

First Row: Timestamp
Second Row: Pedestrian Indices
Third Row: X coordinate
Fourth Row: Y coordinate
Thannks.

I will close the issue for now. Feel free to reopen it if you have any further questions.

What did you use the functions (find_trajectory_fragment, get_seq_from_index_balance, load_dict .etc) ? they are not used in the training nor the test, I deleted them and the model works just fine.

They are used to generate training/testing datasets. The model still works because you have already generated the pickle file of the dataset when you first ran the code. see here
https://github.com/Majiker/STAR/blob/d2dd113e3deb1098760c454ab15e7cb0652f3c0c/src/utils.py#L65
Thank you.

About the dataset, is the pedestrian in hotel with index 1 the same pedestrian in the univ with the same index ?

No, they are not. Hotel and Univ are two datasets collected at different places on different dates.

what exactly do you mean by "window"  ?
(sorry for all these questions, I am really interested in this work and I want to understand every single line of code)

'window' refers to a time period which is normally 20 frames (8 for observation and 12 for prediction)


NO OPTION TO CHANGE THE TX POWER OF BLE GATTs IN ESP32H2 (IDFGH-13261)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
I am unable to find the CONFIG_BT_CTRL_DFT_TX_POWER_LEVEL_ config to change the TX power in H2 menu config and there is no mention on the documentation showing how to chamge the db level in H2.

@MR-VENOM  Hi,
You can change the value of BLE_LL_TX_PWR_DBM_N in the esp32h2/esp_bt_cfg.h file to modify the default tx power level.
The specific levels can be found in the definition of esp_power_level_t in esp32h2/include/esp_bt.h.
As for the function of configuring the default TX power level through config options, we will support and integrate it as soon as possible.
Thanks.

@MR-VENOM Hi,
The commit ceda7d04e4412c25ef83afb000b7108d2864e6dc in master branch provides this function， please check it out , thanks.


AttributeError: module 'numpy' has no attribute 'warnings'

I was having issues with Plotter showing anything so decided to see if there was an update for vedo. I made a fresh conda environment and installed only vedo through conda-forge.
vedo=2022.4.2
numpy=1.24.0
python=3.11.0
When simply importing vedo with from vedo import * I get AttributeError: module 'numpy' has no attribute 'warnings'.
I don't have any files or folders named numpy in the current directory. Is there a quick fix to this? Thanks.

Hi, Yes it's a numpy problem, try the dev versioin:
pip install -U git+https://github.com/marcomusy/vedo.git

Is there currently a different way to solve this in packages that have vedo as a dependency other than pinning numpy?

I'm planning to make a new release later today!

Numpy issue is fixed, thank you.


Fix #347 - Keep enough context around to print in stream mode

Includes a new set of tests from #347, pipecontext.t.

Oh hecks yes! Thank you so much for this PR!

Glad it helps!  I use ag basically every day.

https://github.com/ggreer/the_silver_searcher/compare/master...forgottenswitch:ABC?expand=1 :)

BTW, the implementations give different results:
(Don't know how it differs from piping (with it results are equal))
[the_silver_searcher]$ ./ag --nocolor --number '.' <( printf '\nfoo\n\nar\n' )
1:
2:
4:o
5:
7:8:
10:
[the_silver_searcher]$ ./ag --nocolor --number '.' <( printf '\nfoo\n\nar\n' )
1:
2:foo
3:
4:ar
[the_silver_searcher]$


Please add more attribute type

e.g posgres 's float8, beacuse float4 can't store complete latitude and longtide number.

Hi @zieglar, your request is a duplicate of #819 (which has the proposed PR #981) so I'm closing it for now. Please re-open if you don't agree. Thanks.


Where is code for search input?

Hello @miguelgrinberg
I'm so sorry if this question is inappropriate - I am new to this topics.
I decide to have focus on Basic Table example.
I looked at your files ( basic_table.py, basic_table.html, base.html ) and I couldn't find any code that 'renders': Search Input.
If I missed something, please, could you point me the part of code/file that renders Search Input field?

Hello @miguelgrinberg,

The grid.js library renders the search field.

Maybe you got it mixed up with your blog part 2
I don't see any clue of grid.js in those 3 files (from your blog part 1):

( basic_table.py, basic_table.html, base.html )

I cloned your repo (your blog part 1), everything is doing fine but still I don't know which part to copy to my code to have Search Input.
Could you please give me an another hint :)

Sorry, yes. This one is based on datatables.js. But it is the same answer, the search is done by the JavaScript library, not by flask.

@miiihaaas I'm sorry but I don't understand what you want to do. This project shows how to build a data table, not a search input. If all you need is a search input, then you are looking in the wrong place. In any case, I have nothing to do with the datatables.js project, I'm just showing how to use it. If you are asking me about an advanced or unusual way to use this project, then I cannot answer, I suggest you ask the datatables.js project.

@miguelgrinberg, thank you for your time.


How to handle asymmetric transaction risk?

Hi yall, the white paper suggests some asymmetry of risk between regular users and PFIs that merit discussion.
The paper clarifies that the protocol will be permissionless with regards to who can be a PFI. That means anyone, including bad actors, can become PFIs. Given this, it makes sense to think about PFIs as a threat vector.
So just a couple of observations:

In the on-ramp example on pg 10, we see that a PFI will deploy a 'smart contract' to assure crypto funds are available for the transaction.
In the off-ramp example on pg 11, the User deploys a smart contract with funds.
In both flows, the PFI is the entity with the privilege to interact with the contract, so it either transfers or withdrawals funds (I do not see any mention of the User being able to do this).

These observations suggest that PFIs are freely able to a) receive fiat funds without triggering the on-ramp contracts transfer-method or b) trigger the Users' off-ramp contracts withdrawal-method without transferring the fiat. So in both directions, the User is at a disadvantage with regard to transaction risk.
The off-ramp example acknowledged User transaction risk but not in the on-ramp example. We should clarify this as a holistic problem.
The paper does suggest that a "bank-monitoring oracle" could be a solution to this. A service like Plaid would be a well-positioned company to play that role as they are already a trusted third party used for this purpose. The smart contract would become a full escrow in that case. Is that the right idea? If so, what would the incentive structure look like for the oracle? How would bank account monitoring be decentralized? Wouldn't that be a potential security hole/data leak for the User? How does the User benefit in this scenario over a centralized exchange (doesn't this feel like a "centralized intermediary and/or trust broker")?
Suppose we ditch the "bank-monitoring oracle" and focus solely on the 2 point transaction (user <-> PFI), and we lean hard on the whole reputation system. The User needs to "trust" the PFI based on their reputation rating and accept that they have all the power in this transaction. In that scenario, the need to have a smart contract at all is questionable. Presumably, Users and PFI's would have a public blockchain address that makes the availability of crypto funds apparent. Since the User needs to trust that the PFI will follow through on the fiat side in either use-case, the smart contract does not fulfill a purpose for either counterparty. For on-ramps, the PFI can wait for the fiat to be received to initiate the crypto transfer, and for off-ramps, they wait for the crypto to initiate the fiat transfer. So why is a smart contract necessary?
Relying on a bank-monitoring-escrow-oracle or a reputation system seems like two very different directions for the design of this protocol. Any thoughts on where this should go?

In both flows, the PFI is the entity with the privilege to interact with the contract, so it either transfers or withdrawals funds (I do not see any mention of the User being able to do this).

Its worse. The regular user becomes the untrustworthy agent of the PFI, which I'm fairly certain shifts risk onto the regular user for wrongdoing, insulating a bad-actor PFI.


Improve concurrency - sqltomvt version

See https://github.com/openmaptiles/postserve/pull/14.
Assumes that something (like psql -f <sqltomvt>.sql) has created the function already.


When will your work release the source code?

Good job!
When will your work release the source code?

Thank you for paying attention to our work. Our code will be gradually opened after the Chinese Spring Festival.


SDE GAN example

Added an SDE-GAN example. Only a draft as I'm not satisfied that it's working yet / that it's as fast as it could be.
I've added a couple other things in here too. For one, I've added a CHANGELOG.txt file. (Anything I've left out?)
I've also tweaked the citation request with the new paper, to reflect the huge amount of work we've put into this repo for that paper.

Thanks for the update. Is the changelog necessary, as I've been documenting things in the release notes? I'll take a look at the other stuff tomorrow.

Haha, I honestly hadn't spotted the release notes. Agreed, the changelog is unnecessary.
FYI this example still doesn't work yet. Still needs more tweaks. (The same was true when we wrote the paper, it took me like 2 months of tweaking to get it working. Hopefully we can do it quicker now, but this isn't surprising.)

Thanks for the update, @patrick-kidger ! I'm assuming the example works now.
I actually have further thoughts about this gan model, though I'm quite busy before the xmax break and couldn't really afford to context switch between different things.
Would you mind if I go through this PR in a week of time?
Aside, build for Py3.6 seems to be failing due to numpy being incompatible after its latest release.

Yup, the example works now! The most important points were to change the initialisation and to switch from Adam to SGD.
I'd be very interested to hear your thoughts on SDEs/GANs. After xmas is fine; likewise no rush on this PR. It looks like SDE-GANs are probably going to be in ICML rather than ICLR, after all...
Aside, eurgh. Looks like the problem is that it's grabbing the SciPy pre-release, which requires Python 3.7+.

Not related to this thread in particular, but I found this during late night reading. Some food for thought regarding the log-ODE scheme.

Ah, thankyou! I've actually come across this before. Unfortunately I don't think it composes with autograd.grad in the desired way though -- from a private discussion with one of PyTorch devs: "The current vmap prototype unfortunately does not support doing a batch vjp where the input and the v vector share a batch dimension."
At some point I expect we'll revisit the log-ODE method, as I believe James wants to write a paper on it. When that happens one option would be to write a for loop over the vjp, in C++ parallelised with OpenMP.

A fair few of your comments above are about the optimisation procedure. This is easily the thing that actually seems to matter most.
I didn't try every combination of SGD/Adam/Adadelta/... with every combination of weight decay, SWA, etc, but I'm actually very interested in what the optimal way of doing this is.
As a general summary of my observations:

Adam/AMSgrad give losses that jump around all over the show during training, whilst Adadelta gives very well-behaved smoothly-varying losses. However only SGD manages to get anything approaching good convergence towards the end of training, though: the others tend to get stuck at some loss away from zero. (Probably related to the theoretical lack-of-convergence that these optimisers exhibit.)
Weight decay seems to help a little bit.
SWA can save you from the oscillating losses that Adam gives you, helps a fair chunk with SGD, but does basically nothing with Adadelta. I've only tried uniform weight averaging, not EMA.

Judging from the GAN optimisation literature at the moment, it seems like no-one else has much idea either. SWA is obviously related to the stronger convergence guarantees that Cesaro means often get / is a trick to avoid the diffusive regime at the end of training. The tricks used in Ada-* help at the start of training but break things at the end of training. Weight decay and negative momentum seem related to the idea of solving a GAN as an ODE, but that's almost certainly suboptimal for min-max games, just like it's suboptimal for minimisation problems.
All in all things seem to be in a bit of a mess. It feels to me like all the basic pieces are there in the literature, and someone just needs to figure out the correct things to put together to get it working reliably.
As it stands this example represents a "good enough" trade-off between readability / efficacy / use of only standard library without custom optimisers.
Things I'd like to try, but decided were out of scope for an intentionally simple example:

Negative momentum. Unfortunately the default PyTorch optimizers through an error if you try it.
Adabound, which interpolates between Adam and SGD. Something interpolating between Adadelta and SGD would also be interesting.
Using Adadelta to begin training and then switch to SGD at the end.
Coming up with some custom optimiser that has the right blend of the above ideas!

FYI even though I think this PR is done, I'm thinking of leaving it unmerged until the paper is on arXiv (so we have a better link than just the workshop paper).

Right, finally done with this PR and ready to merge it, I think.

Finally done with this PR and ready to merge it, I think. @lxuechen how does it look?

Looks good. If you could rebase from master to rid the test failures, then I think it's mostly ready for merge; otherwise I can try do the rebase some time over the weekend. Overall, the example seems a somewhat more complicated than the others, but understandably training GANs isn't easy.
Sorry again for this ultra slow response.

No worries at all.
The test failure looks to be because the version number isn't updated. I can bump the number if you really want, but as we're only touching the README and a new example file then I think it should be fine to just merge anyway.
I've just done a small update to start using Fire, and add the license at the top.


Recurring tasks not working on MacOS

Issue tracker is ONLY used for reporting bugs. New feature ideas should be discussed in the ideas section. Please use the Q&A section for supporting issues. Please use the search function.
If you encountered the issue after you installed, updated, or reloaded the tasks plugin, please try restarting obsidian before reporting the bug.
If you want to report a bug, please follow the guide lines below to help me resolve it.
Remarks: I saw that another issue regarding recurring tasks not working was recently open, but that was for iOS, so I thought I'd open a new issue.
Expected Behavior

Toggling a recurring task as done in "Reading" mode should create a new line of the same task
i.e.

[x] send email 🔄 every day 🛫 2022-03-29 ⏳ 2022-03-29 📅 2022-03-29 ✅ 2022-03-31
[ ] send email 🔄 every day 🛫 2022-03-30 ⏳ 2022-03-30 📅 2022-03-30

Current Behavior

the new line of the same tasks does not appear
Steps to Reproduce

Toggled the task as done in "Reading" mode, the Completed date is generated, but the recurring tasks is not created again. I have tried using "every week", "every day", I've moved the recurring option around to just behind the due date, I've removed the start and scheduled dates, but to no avail.
see screenshots attached.

Context (Environment)

Obsidian version: V0.14.2
Tasks version: V1.4.1
[x] I have tried it with all other plugins disabled and the error still occurs

Possible Solution

I tried to reproduce this by cutting and pasting your task above. I can reproduce what you say happens but only because you are not using the standard recurrence icon, but a similar one.
How was your task generated??
ie

[ ] #task 🔁 every day

versus

[ ] #task 🔄 every day

OH, that solved the problem. Sorry, I didn't use the right emoji. Sorry for the false alarm!


More updates to get it working for me on Casper

I can now successfully call
sfcfile=/glade/campaign/cesm/cesmdata/cseg/inputdata/lnd/clm2/surfdata_map/surfdata_0.9x1.25_78pfts_CMIP6_simyr2000_c170824.nc
demdata=/glade/campaign/cgd/tss/projects/hillslopes/MERIT
./hand_analysis_global.py --pt 1 --sfcfile $sfcfile --dem-data-path $demdata

This needs to be changed to point back to your Pysheds fork once you approve swensosc/pysheds#1.


Channable: Orders & Items -> white page

With the latest Channable 1.0.12 + Magento 2.2.2
When opening the "Channable: Orders & Items", I get on my server a white page.
On my development environment, I get the follow error:
1 exception(s):
Exception #0 (Exception): Notice: Array to string conversion in vendor/magento/module-shipping/Model/Config/Source/Allmethods.php on line 61
Exception #0 (Exception): Notice: Array to string conversion in vendor/magento/module-shipping/Model/Config/Source/Allmethods.php on line 61
#0 vendor/magento/module-shipping/Model/Config/Source/Allmethods.php(61): Magento\Framework\App\ErrorHandler->handler(8, 'Array to string...', '/Users/jw/Proje...', 61, Array)
#1 vendor/magento/module-config/Model/Config/Structure/Element/Field.php(458): Magento\Shipping\Model\Config\Source\Allmethods->toOptionArray(false)
#2 vendor/magento/module-config/Model/Config/Structure/Element/Field.php(376): Magento\Config\Model\Config\Structure\Element\Field->_getOptionsFromSourceModel(Object(Magento\Shipping\Model\Config\Source\Allmethods))

Looking into this Magento code on this line:
'label' => '[' . $carrierCode . '] ' . $methodTitle,
At the $carrierCode = 'usps', I get an array returned.
This results in this error.
This carrier is actually not used.

Closing this issue for now, as this is not an issue caused, nor can be fixed, by the channable module.


Avoid unneeded reset_index in DataFrameGroupBy.describe.

DataFrameGroupBy.describe uses reset_index() internally, but we can avoid using it and so unnecessary default index attachment.

Codecov Report

Merging #1951 (1e6f3ea) into master (138c7b8) will decrease coverage by 3.45%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1951      +/-   ##
==========================================
- Coverage   94.64%   91.19%   -3.46%
==========================================
  Files          49       49
  Lines       10818    10713     -105
==========================================
- Hits        10239     9770     -469
- Misses        579      943     +364

Impacted Files
Coverage Δ

databricks/koalas/groupby.py
91.35% <100.00%> (-0.07%)
:arrow_down:

...bricks/koalas/tests/plot/test_frame_plot_plotly.py
26.58% <0.00%> (-73.42%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
25.66% <0.00%> (-66.65%)
:arrow_down:

...ricks/koalas/tests/plot/test_series_plot_plotly.py
37.50% <0.00%> (-58.80%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
47.82% <0.00%> (-52.18%)
:arrow_down:

databricks/koalas/__init__.py
68.75% <0.00%> (-21.88%)
:arrow_down:

databricks/conftest.py
89.83% <0.00%> (-10.17%)
:arrow_down:

databricks/koalas/spark/functions.py
88.88% <0.00%> (-7.41%)
:arrow_down:

databricks/koalas/accessors.py
86.43% <0.00%> (-7.04%)
:arrow_down:

databricks/koalas/namespace.py
78.17% <0.00%> (-6.07%)
:arrow_down:

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 138c7b8...1e6f3ea. Read the comment docs.

Make senses! Thank you!

Thanks! merging.

Nice fix


Failed to connect to the host via ssh: Shared connection

TASK [Cloning Depot Tools] *******************************************************************************************************************
changed: [XX.XX.XX.XX]
TASK [Resolving Chromium Revision from Puppeteer Version] ************************************************************************************
ok: [XX.XX.XX.XX]
TASK [Resolving Git Commit from Chromium Revision] *******************************************************************************************
ok: [XX.XX.XX.XX]
TASK [Fetching Chromium] *********************************************************************************************************************
fatal: [XX.XX.XX.XX]: UNREACHABLE! => {"changed": false, "msg": "Failed to connect to the host via ssh: Shared connection to XX.XX.XX.XX closed.", "unreachable": true}
PLAY RECAP ***********************************************************************************************************************************
<IP_ADDRESS>                  : ok=6    changed=2    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0
XX.XX.XX.XX                : ok=8    changed=5    unreachable=1    failed=0    skipped=0    rescued=0    ignored=0
Adding more details
fatal: [XX.XX.XX.XX]: UNREACHABLE! => {
"changed": false,
"msg": "Failed to connect to the host via ssh: OpenSSH_7.6p1 Ubuntu-4ubuntu0.3, OpenSSL 1.0.2n  7 Dec 2017\r\ndebug1: Reading configuration data /etc/ssh/ssh_config\r\ndebug1: /etc/ssh/ssh_config line 19: Applying options for *\r\ndebug1: auto-mux: Trying existing master\r\ndebug2: fd 3 setting O_NONBLOCK\r\ndebug2: mux_client_hello_exchange: master version 4\r\ndebug3: mux_client_forwards: request forwardings: 0 local, 0 remote\r\ndebug3: mux_client_request_session: entering\r\ndebug3: mux_client_request_alive: entering\r\ndebug3: mux_client_request_alive: done pid = 11404\r\ndebug3: mux_client_request_session: session request sent\r\ndebug1: mux_client_request_session: master session id: 2\r\ndebug3: mux_client_read_packet: read header failed: Broken pipe\r\ndebug2: Control master terminated unexpectedly\r\nShared connection to XX.XX.XX.XX closed.",
"unreachable": true
}

@HareshChhelana The Ansible playbook launches a new EC2 Spot Instance:
https://github.com/alixaxel/chrome-aws-lambda/blob/ac73d95adcc96262125d41d9fafdf3720cc8fe32/_/ansible/plays/chromium.yml#L38-L60
The target hourly cost is limited to 0.75 USD.
Based on supply/demand it might not be enough to hold the instance for the entire duration of the play.
I assume that your spot instance was shutdown because of this, therefore it's not a bug.


Fix android building

Fixes:
FAILURE: Build failed with an exception.

* Where:
Build file '/Users/rexios/.pub-cache/hosted/pub.dartlang.org/wear-1.1.0/android/build.gradle'

* What went wrong:
Could not compile build file '/Users/rexios/.pub-cache/hosted/pub.dartlang.org/wear-1.1.0/android/build.gradle'.
> startup failed:
  General error during conversion: Unsupported class file major version 63

  java.lang.IllegalArgumentException: Unsupported class file major version 63

  	at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:199)
  	at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:180)
  	at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:166)
  	at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:287)
  	at org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:81)
  	at org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:251)

...

Also updated the example app

Related:

https://github.com/flutter/flutter/issues/122376
https://github.com/flutter/flutter/issues/122213

I released the wear_plus plugin which contains the necessary fixes


HIVE-24499: Throw error when respective connector JDBC jar is not pre…

…sent in the lib/ path

What changes were proposed in this pull request?
Throwing an exception when connector jar for the remote data source is not present in the lib directory path.

Why are the changes needed?
If we don't throw any error, users wouldn't notice any issue with the connector jar.

Does this PR introduce any user-facing change?
No.

How was this patch tested?
Local machine.

@saihemanth-cloudera  Can you please close this PR? Thanks


Update readme

New screenshots
Change the link of the footer file as the file is in a directory in the repo
...

I can also help adding the architectural overview of the extension when @bella-tassone works on the readme.

Sounds good! @bella-tassone, if you can take the lead here and let @chunyuema know.

I added the architectural overview directly to the main branch. @bella-tassone, just make sure to pull, and there should not be any conflicts we need to worry about.

Seems the readme is (still) outdated. We probably need new screenshots for some of the scheme banners and backend screenshots. Also, we need to add the alt descriptions for the images. Let's also have less whitespace in the backend pictures as that blows up the size of pictures and does not add anything.

I believe I have taken care of all the current revisions to the readme, so I will be closing this issue


unexpected http status code: 404

Running NixOS 24.11 installed leftwm and leftwm-theme
ran:
➜  ~ sudo leftwm-theme status
Your LeftWM version is 0.5.3
There are 0 themes installed in your ~/.config/leftwm/themes/ directory known to LeftWM.
WARNING! NO KNOWN THEME IS CURRENTLY SET.
    A theme may be set, but LeftWM theme doesn't know about it.
    If it is a local theme, try leftwm-theme new themename.
    If it is a repo theme, try leftwm-theme install themename

➜  ~ sudo leftwm-theme update
➜  ~ sudo leftwm-theme install Zexanima
response:
Looking for theme . . .

Zexanima could not be installed because "unexpected http status code: 404"

 Theme not installed

I went ahead and attempted to patch for this; let me know if this resolves @Perchant76.
You'll likely need to do a force refresh:
leftwm-theme upgrade
leftwm-theme update
sudo leftwm-theme install Zexanima

It's also possible the known.toml pointed to in ~/.config/leftwm/themes.toml is invalid


Add metrics for external RPC calls (success / error)

Currently zetaclientd seems to panic when the external RPC returns an error response. Exposing success/failure counts by network as a metric would be very useful for monitoring.
Panic details:
Jan 03 21:26:39 validator0-eu-west-1-testnet zetaclientd[678456]: {"level":"info","chain":"ZetaChain","time":"2024-01-03T21:26:39Z","message":"starting core observer"}
Jan 03 21:26:39 validator0-eu-west-1-testnet zetaclientd[678456]: {"level":"info","chain":"bsc_testnet","module":"ExternalChainWatcher","time":"2024-01-03T21:26:39Z","message":"ExternalChainWatcher for inboundTrackerSuggestions started"}
Jan 03 21:26:39 validator0-eu-west-1-testnet zetaclientd[678456]: {"level":"info","chain":"bsc_testnet","module":"ObserveOutTx","time":"2024-01-03T21:26:39Z","message":"observeOutTx using timeoutNonce 300 seconds, rpcRestTime 20 ms"}
Jan 03 21:26:39 validator0-eu-west-1-testnet zetaclientd[678456]: {"level":"info","chain":"bsc_testnet","module":"ExternalChainWatcher","time":"2024-01-03T21:26:39Z","message":"ExternalChainWatcher started"}
Jan 03 21:26:39 validator0-eu-west-1-testnet zetaclientd[678456]: {"level":"info","chain":"mumbai_testnet","module":"ExternalChainWatcher","time":"2024-01-03T21:26:39Z","message":"ExternalChainWatcher for inboundTrackerSuggestions started"}
Jan 03 21:26:39 validator0-eu-west-1-testnet zetaclientd[678456]: {"level":"info","chain":"mumbai_testnet","module":"ExternalChainWatcher","time":"2024-01-03T21:26:39Z","message":"ExternalChainWatcher started"}
Jan 03 21:26:39 validator0-eu-west-1-testnet zetaclientd[678456]: {"level":"info","chain":"goerli_testnet","module":"ExternalChainWatcher","time":"2024-01-03T21:26:39Z","message":"ExternalChainWatcher started"}
Jan 03 21:26:39 validator0-eu-west-1-testnet zetaclientd[678456]: {"level":"info","chain":"mumbai_testnet","module":"ObserveOutTx","time":"2024-01-03T21:26:39Z","message":"observeOutTx using timeoutNonce 300 seconds, rpcRestTime 20 ms"}
Jan 03 21:26:39 validator0-eu-west-1-testnet zetaclientd[678456]: {"level":"info","chain":"goerli_testnet","module":"ExternalChainWatcher","time":"2024-01-03T21:26:39Z","message":"ExternalChainWatcher for inboundTrackerSuggestions started"}
Jan 03 21:26:39 validator0-eu-west-1-testnet zetaclientd[678456]: {"level":"info","chain":"goerli_testnet","module":"ObserveOutTx","time":"2024-01-03T21:26:39Z","message":"observeOutTx using timeoutNonce 300 seconds, rpcRestTime 20 ms"}
Jan 03 21:26:39 validator0-eu-west-1-testnet zetaclientd[678456]: {"level":"info","chain":"ZetaChain","module":"ZetaChainWatcher","time":"2024-01-03T21:26:39Z","message":"Starting Send Scheduler for zeta1euvlmpffq7gl77vlwlv97kn004zq6rdw0skdd3"}
Jan 03 21:26:39 validator0-eu-west-1-testnet zetaclientd[678456]: {"level":"info","module":"startup","time":"2024-01-03T21:26:39Z","message":"awaiting the os.Interrupt, syscall.SIGTERM signals..."}

The panic only happens at start if the RPC is not working.
It would helpful to see how many are successful or failing at all times and could identify issues with RPC connectivity.


Connected textures don't want to work well.

Describe the bug
I've been having this issue for a few months now, can't figure out what causes it though...

(The glass isn't connecting very good)
Is this a driver problem or a mod-type of problem?
Modpack version
1.21 (also verions below)
Launcher
Modrinth App
Confirm

[X] This bug report is about an issue with the modpack itself, I have not modified the mods nor added any resource packs. If this is not the case, I know that I should post the issue to modpack's Discord support channel instead.

Additional context
No response

There is a glass-related resource pack bundled, is it also enabled for you?

There is "Default connected textures" and "Glass pane culling fix", both of them are on.

Okay, in that case it is the Sodium translucent block culling issue, will be fixed when Sodium 0.6 releases.

Alright! Thanks for the help!! Have a good day :D


truncated terminal fonts after upgrading to 1.58.2

Gitpod users reporting that terminals fronts are truncated after switching to 1.58.2: https://github.com/gitpod-io/gitpod/issues/5014

Brave's fingerprint prevention causes this as it blocks some canvas APIs https://github.com/xtermjs/xterm.js/wiki/FAQ#characters-are-getting-cut-off-in-the-terminal

Ohh yes I sometimes come across some online editors where the actual text displayed is good, but it is difficult to access them, like the cursor runs way further than the actual text
Thanks for addressing


Images in shapes sometimes saving incorrectly and stop displaying

Bug Description
Sometimes (so far only when dropping an image into a shape, using non-default shape), the image gets saved to the markup incorrectly and doesn't show anymore. This happens even if the image was previously saved as expected and without changing anything about that specific image.

Expected Behaviour
Image should persist with saving.

Steps to Reproduce
This might not be easy to reproduce, however, how it did happen in my case both times:

Add a shape (happened once with the start and once with the triangular shape)
Drop an image into it
Scale the image and reposition.
Save
Repeat refresh -> save -> refresh a few times

Screenshots
Source, see the "blob:..." instead of the URL as for other images.

See the frame displaying, image missing:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

Also seeing this in console, not sure if related:

Quite a lot has changed since this issue was reported -- tested it and tried to reproduce but without results. Looks like it's not an issue anymore. Closing as resolved.


Review the structure of the TrainerModule.

Currently, the trainer module takes as an argument the name of a class and its hyperparameters and saves it in a json format. It raises some issue among which:

you can't use any activation function as a Callable in not json serializable.
it can be difficult to interface with an NPE() object from jaxili.inference.npe under construction.

Fixed. A dictionary mapping every activation function in jax to their name has been added.
Modified the TrainerModule to be able to load checkpoints lore easily.


Support for german language characters

Hello, we are using your library but we encountered an issue with german sites, it cannot convert special characters like this Ö, Ä

I tried even putting in into files, but in files it looks the same.

Hello, thanks for your feedback.
The library does not manage encoding of the source directly, it delegates it to the AngleSharp library. This is widely used, so I do not think that they are unable to handle German characters. For example, you can try the web demo on a Der Spiegel article and verify that it actually works correctly.
Therefore either the issue is that the original source does not communicate encoding correctly (which may happen for old websites) or our library may mess up some particular case. We can troubleshoot this, if you can provide an example source that causes the issue.

Thanks for the fast reply, here is the test result of Der Spiegel:
simple code:
	[TestMethod]
        public void testGermanCharacters()
        {
            SmartReader.Reader sr = new SmartReader.Reader("https://www.spiegel.de/wirtschaft/soziales/greenpeace-und-umwelthilfe-verlangen-gesetzliche-vorgaben-zum-energiesparen-a-b9bc1454-c98c-433f-8988-da5a821d6e00");
            SmartReader.Article article = sr.GetArticle();
            using (StreamWriter swClifor = new StreamWriter(@"c:\_WA\NewsCrawlerExportFolder\test.txt", true))
            {
                swClifor.WriteLine(article.TextContent.ToString());
                swClifor.Close();
            }
        }

is VS:

in Notepad:

I tried using different library just to check encoding, it has downloaded it correctly with correct encoding:
	[TestMethod]
        public void testGermanCharacters()
        {
            string german = "Die Rohöllagerbestände in den";
            //SmartReader.Reader sr = new SmartReader.Reader("https://www.finanzen.net/nachricht/aktien/us-rohoellagerbestaende-steigen-unerwartet-11594814");
            //SmartReader.Article article = sr.GetArticle();

            HtmlWeb client = new HtmlWeb();
            HtmlDocument doc = client.Load("https://www.finanzen.net/nachricht/aktien/us-rohoellagerbestaende-steigen-unerwartet-11594814");
            using (StreamWriter swClifor = new StreamWriter(@"c:\_WA\NewsCrawlerExportFolder\test.txt", true))
            {
                swClifor.WriteLine(doc.Text.ToString());
                swClifor.Close();
            }
        }

I have taken a look at the source you provided. It is true that the source is not displayed correctly. However, the encoding/charset is correct, the issue seems to be that they are using HTML character references to display German characters rather than standard characters.
In other words, if you inspect the HTML source with a browser, you will see this text:
WASHINGTON (Dow Jones)--Die Rohöllagerbestände in den USA haben sich in der Woche zum 29

That is quite unusual, I imagine it is a result of old age. Probably the approach worked before the widespread usage of UTF-8. I think we can solve this, I will work on it this weekend.

Thank you very much ! Please let me know next week I will wait :)

The latest commit should fix the issue. The problem was not the unusual character references, but because for some reason AngleSharp ignored the encoding setting provided in the header. I think that is because in some misconfigured servers the I added a setting ForceHeaderEncoding (it defaults to false, but for your case you should set it to true). At the moment the latest change is only on master, but it has not been released in a package

thank you, please let me know when it will be available as package, you are perfect ! :)

I published version 0.9.0 that should fix your issue. It took a while because we found other issues to fix.


ocsort_dance_model.pth.tar

Hello,when I run bash inference.sh,there is an error says that FileNotFoundError: [Errno 2] No such file or directory: 'ocsort_dance_model.pth.tar'.So how I can get the pth.tar file?Looking forward to your reply.

It can be found here https://github.com/noahcao/OC_SORT/blob/master/docs/MODEL_ZOO.md


2.0.0 exists on packagist.org

https://packagist.org/packages/paragonie/sodium_compat#v2.0.0
Trying to deal with this has been not fun.

Clear your caches and try again.


cmd/compile: libFuzzer instrumentation fakePC overflow on 386 arch

What version of Go are you using (go version)?

$ go version
go version devel go1.20-4274ffd4b8 Tue Oct 11 04:04:13 2022 +0000 darwin/arm64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env

What did you do?
Compile following program with -d=libfuzzer:
package p

func f(x, y int) {
	_ = x > y
	_ = y > x
}

What did you expect to see?
Compile ok.
What did you see instead?
$ GOOS=linux GOARCH=386 go tool compile -d=libfuzzer p.go
p.go:5:8: constant<PHONE_NUMBER> overflows int

@randall77 @mdempsky seems we need to backport this, it affect go test -fuzz on 386 arch.

Re-open for backport consideration.
cc @randall77 @mdempsky

@gopherbot please open a backport to 1.19. This bug causes libfuzzer mode to fail to compile. There is no easy workaround.
(I don't think this applies to 1.18.)

@gopherbot please open a backport to 1.19. This bug causes libfuzzer mode to fail to compile. There is no easy workaround.
(I don't think this applies to 1.18.)

Yes, this does not happen in go1.18 release. The libfuzzerTrace* and friends are added in 1.19


Fix problems in building especially involving Maven libs

Building is challenging, get all libs in XML files sync'ing properly, document where those things are, fix Kiley's problem.
From Kiley...
Dave, I've been having issues with Gradle/Intellij again tonight. My project wouldn't build for the longest time. I eventually fixed it (though I really don't know what I did) and so now I have a couple questions for you:

Should we be pushing or ignoring "gradle/", "gradlew", and "gradlew.bat"? This is the first time I've seen them appear (we've had ".gradle/" before when Graham set it up, but never just "gradle/"), as this is the first time I refreshed the project in the Gradle window.
Elegit.iml now contains a local machine-specific path to something in Java (jfxrt.jar), so I'm not sure if we still want to be tracking that or not?
I changed the controlsfx import to be the released version of 8.40.10 instead of the 8.40.11 snapshot. I figure it's better to use the stable release now that our issues were fixed

This is done, or at least outdated, since we've gone to Maven and pom.xml.


Missing Documentation for "/property:Name=Value" option

Type of issue
Missing information
Description
Hi!
I noticed that the options /property:Name=Value and /p:Name=Value are mentioned in various places within the documentation. However, these options are not formally documented, which could cause confusion for users.
Could we please include these options in the official documentation to make it clearer for users?
Thank you!

https://github.com/dotnet/docs/blob/main/docs/core/tools/dotnet-build.md

-p|--property:=
Sets one or more MSBuild properties.

By default, MSBuild displays warnings and errors at all verbosity levels. To exclude warnings, use /property:WarningLevel=0.

https://github.com/dotnet/docs/blob/main/docs/core/tools/dotnet-run.md

dotnet run doesn't respect arguments like /property:property=value, which are respected by dotnet build

Page URL
https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-build
Content source URL
https://github.com/dotnet/docs/blob/main/docs/core/tools/dotnet-build.md
Document Version Independent Id
5e495ddd-140e-de5c-a793-d4a9f88be51e
Article author
@tdykstra
Metadata

ID: 910cd365-d63a-00dc-417c-db017f83bf6f
Service: dotnet-fundamentals

/assign me

@pojith, do you still intend to address this issue?


[WIP] ci: run action when workflow files are updated

As discussed #1975, I believe that these are the changes needed to add the workflow file itself to the paths to watch for.
However I'm not sure how I should update the workflow files. I tried ./gradlew :rust:delete_workflows && ./gradlew :rust:generate_workflows, however it generated many workflow files that weren't tracked. Even in the tracked workflow files there are some unexpected changes, most notably the Generate random key and Cache Gradle steps are lost and I'm not sure how they were added in the first place.

@wkk thank you so much for the work you put into this.
With the recent change of us using Rust Cargo workspace .. we ended up removing the CommandPlugin completely in https://github.com/ockam-network/ockam/pull/2308 ... It made understanding what is going on the gradle build simpler.
Thank you for taking time to contribute 🙏
Let me know if you want to work on a different feature and I would be happy to help.


Add ExcludeWith validation rule

Adds the ExcludeWith validation rule as validation attribute.
As part of https://github.com/spatie/laravel-data/issues/570

Thanks!


Add manual testing for edit lesson

Codecov Report

Merging #238 (2051cd9) into master (d374f2e) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 2051cd9 differs from pull request most recent head 1696c88. Consider uploading reports for the commit 1696c88 to get more accurate results

@@            Coverage Diff            @@
##             master     #238   +/-   ##
=========================================
  Coverage     77.01%   77.01%
  Complexity      699      699
=========================================
  Files            97       97
  Lines          2219     2219
  Branches        274      274
=========================================
  Hits           1709     1709
  Misses          412      412
  Partials         98       98

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d374f2e...1696c88. Read the comment docs.


feat: HEVC SEI message list and HDR10 SEI details

Added complete list of HEVC SEI message types and implemented HDR10 ones nr 137 and 144.

Replaced by PR #179.


Recording - Group Channel/ iOS - Retrieve a list of members and operators in a specific order

Link to documentation:
https://sendbird.com/docs/chat/v3/ios/guides/group-channel#2-retrieve-a-list-of-members-and-operators-in-a-specific-order

@justinbaldwin
https://drive.google.com/file/d/1DBc0tezqv0O2nGQmunOre4Ap0cwAph3B/view?usp=sharing

@michellewong27 @chrischabot
Ready for review: https://drive.google.com/file/d/1DBc0tezqv0O2nGQmunOre4Ap0cwAph3B/view?usp=sharing


Modules for external providers

Modules for external providers
Right now, the code base is strictly coupled with data hooks providers. We need to enable the use of different providers interchangeably.
We’re discussing steps forward with @LFades to add different data sources to Next.js Commerce and make it super easy to switch data providers and even aggregate them.

Goals of Commerce

Next.js Commerce should have a completely data agnostic UI
Aware of schema: should ship with the right data schemas and types.
All providers should return the right data types and schemas to blend correctly with Next.js Commerce.
@framework will be the alias utilized in commerce and it will map to the ecommerce provider of preference- e.g BigCommerce, Shopify, Swell. All providers should expose the same standardized functions. Note that the same applies for recipes using a CMS + an ecommerce provider.

There is a framework folder in the root folder that will contain multiple ecommerce providers.
Additionally, we need to ensure feature parity (not all providers have e.g. wishlist) we will also have to build a feature API to disable/enable features in the UI.
Expected Structure
Main folder and its exposed functions

product

usePrice
useSearch
getProduct
getAllProducts

wishlist

useWishlist
addWishlistItem
removeWishlistItem

auth

useLogin
useLogout
useSignup

cart

useCart
useAddItem
useRemoveItem
useCartActions
useUpdateItem

config.json

README.md

Example of correct usage of Commece Framework
import { useUI } from '@components/ui'
import { useCustomer } from '@framework/customer'
import { useAddItem, useWishlist, useRemoveItem } from '@framework/wishlist'

Providers under development:

Shopify
WooCommerce
Salesforce Commerce Cloud
Swell
Magento

Providers help needed:

CommerceTools

Another thought: Could we package the front-end somehow so existing Commerce users can get bug fixes pushed?
https://twitter.com/PrevostClemToun/status/1321387261511028743

@leerob my 2 cents: I think it is far preferable to package the project for distribution via npm. Relying on forking becomes utterly painful when big changes are made to the fork and upstream too, and then the user is left trying to merge and get it right - not a nice experience!
Of course then there is the problem that an npm package is not a storefront. So there still needs to be some "scaffold" which consumes the npm package, and this scaffold part cannot be easily versioned. But if well-designed this can be kept to a minimal issue, since it is the core components in the npm package which will be changed more often.
For example, how Angular does it with their CLI is pretty nice: the core libs are in npm packages, but some parts like your project package.json, angular.json, tsconfig.json and other parts are local to your repo. When upgrading they use an AST-based tool (schematics) to automatically apply codemods to your repo to keep it compatible with the latest package version. This may be overkill for this project, but I just give it as an example of what can be done.

Would be great to support shopify also like Gatsby but better since it's nextjs

I've seen a lot of support for shopify, but are there any plans for woocommerce or is it simply not economically viable?

I would love to work on a Magento provider. Is there other conversations happening outside of this issue regarding external providers?

I'm also keen to build in support for other eCommerce APIs. Two things are stopping me right now: 1) there's no license on this repository, 2) there's no checkout. Having an external checkout is pretty jarring from a UX perspective, and kind of antiquated in my opinion. The value of jamstack is having everything be headless and API driven, which 50% of this project is not.
I imagine adding a checkout here would also involve building some additional UI components for it, and would involve coordination with the maintainers of this repository to ensure we get what we want. In the meantime, BigCommerce/Shopify/other eCommerce providers that have externally hosted checkouts seem to be the only option.

I'm also keen to build in support for other eCommerce APIs. Two things are stopping me right now: 1) there's no license on this repository, 2) there's no checkout. Having an external checkout is pretty jarring from a UX perspective, and kind of antiquated in my opinion. The value of jamstack is having everything be headless and API driven in order to create efficient, optimised, and unique user experiences in the commerce space, which 50% of this project is not.
I imagine adding a checkout here would also involve building some additional UI components for it, and would involve coordination with the maintainers of this repository to ensure we get what we want. In the meantime, BigCommerce/Shopify/other eCommerce providers that have externally hosted checkouts seem to be the only option.

Stripe Checkout is a nice hosted solution, there's already examples with next https://github.com/stripe-samples/nextjs-typescript-react-stripe-js

@robbieaverill started an RFC in order to talk about a fully custom checkout: https://github.com/vercel/commerce/issues/64

Very interested in this as well, I imagine an abstraction layer and a set of capability flags would make it easier to support other commerce backends without forcing everyone to implement the same common subset of features.

@okbel
Hi,
Can you please share your branch you working on this issue?
It's great if I can join to help for improve the implementation on it, because this is the most important feature.

Where should I start when I want to start working on Sylius provider? Any guideline or initiative?

Hello all!
We ported all our hooks to here -> https://github.com/vercel/commerce-framework. Under the example folder you'll be able to create your own hooks to use them with Next.js Commerce.
Here is the proposed API to support new providers. https://github.com/vercel/commerce-framework/pull/1/files?short_path=b335630#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
We're actively looking for contributors to work on a Shopify and Magento providers. Please ping me if you want to contribute.

@okbel We would very much like to contribute on Shopify providers. How can we join?

@maartenjongerius Amazing!!! Feel free to open a PR to commerce-framework remember to copy the example folder and replace all with Shopify helpers. I added info to the readme. Thank you!

@okbel I would like to look into shopify integration as well

@maartenjongerius did you guys jump on this? I'm evaluating options for a new shop, and my client has more familiarity with Shopify (than BigCommerce). I don't have the bandwidth to do the hooks right now though, so if you guys tackled it that would be a godsend

@okbel Hi ! Someone have start contributing for Shopify ? I want to contribute :)

Has anyone started on the Magento provider?

@Aleksion I'm sorry to say we haven't gotten around to it yet. Right now, we're looking into starting next month

I am ready to contribute for Magento 🙂

I am ready and willing to contribute to the work on Shopify. I have not build such React hooks things before and thus should not the one who should drive it. Ping @maartenjongerius @Aleksion and @djodjo02130

Hey, is there any work in progress for the Shopify integration to contribute to? Really wishing to help if possible.
I'm also really interested in working on the Saleor integration, as other folks from this discussion https://github.com/mirumee/saleor/discussions/6398
I couldn't see any opened PR in the commerce-framework project to head to.

Hey, is there any work in progress for the Shopify integration to contribute to? Really wishing to help if possible.
I'm also really interested in working on the Saleor integration, as other folks from this discussion https://github.com/mirumee/saleor/discussions/6398
I couldn't see any opened PR in the commerce-framework project to head to.

I've published a package for Shopify integration: nextjs-commerce-shopify. It is still a work-in-progress. Currently being used in production on an e-commerce website.
@okbel - I'm unclear how to integrate it within commerce-framework. Is this a template for us to use, or would you like all external providers within this repo?

I've published a package for Shopify integration: nextjs-commerce-shopify. It is still a work-in-progress. Currently being used in production on an e-commerce website.
@okbel - I'm unclear how to integrate it within commerce-framework. Is this a template for us to use, or would you like all external providers within this repo?

Hello all!
We are actively working towards achieving these goals, mentioned in the README:
Goals:

Next.js Commerce should have a completely data agnostic UI
Aware of schema: should ship with the right data schemas and types.
All providers should return the right data types and schemas to blend correctly with Next.js Commerce.

In order to achieve these goals we created commerce-framework. That repository will contain examples and the standard for ecommerce data schemas. (This repo will most likely be merged into the main one)
@framework will be the alias utilized in commerce and it will map to the ecommerce provider of preference, e.g BigCommerce, Shopify, Swell. All providers exposing the same standardized functions. This means that all references and imports to BC's Storefront will be replaced with "@framework/hooks" etc.
Note that the same applies for recipes using a CMS + an ecommerce provider.
We plan on having a framework folder in the root folder that will contain a few providers and ignored in the build process.
Additionally, we need to ensure feature parity (not all providers have e.g. wishlist) we will also have to build a feature API to disable/enable features in the UI.
As always, I'm highly reachable through Twitter DMs. People actively working on this project: @okbel & @lfades.

Hello all!
We are actively working towards achieving these goals, mentioned in the README:
Goals:

Next.js Commerce should have a completely data agnostic UI
Aware of schema: should ship with the right data schemas and types.
All providers should return the right data types and schemas to blend correctly with Next.js Commerce.

In order to achieve these goals we created commerce-framework. That repository will contain examples and the standard for ecommerce data schemas. (This repo will most likely be merged into the main one)
@framework will be the alias utilized in commerce and it will map to the ecommerce provider of preference, e.g BigCommerce, Shopify, Swell. All providers exposing the same standardized functions. This means that all references and imports to BC's Storefront will be replaced with "@framework/hooks" etc.
Note that the same applies for recipes using a CMS + an ecommerce provider.
We plan on having a framework folder in the root folder that will contain a few providers and ignored in the build process.
Additionally, we need to ensure feature parity (not all providers have e.g. wishlist) we will also have to build a feature API to disable/enable features in the UI.
As always, I'm highly reachable through Twitter DMs. People actively working on this project: @okbel & @lfades.

Hi all
I see you are active looking for contributors for Shopify and Magento. I may contributor for Salesforce Commerce Cloud.
I was looking for a high-performance storefront with SSR and SSG and end-up here :)
This may be a game changer specially if we support enterprise platforms and multi-locale projects

Hi all
I see you are active looking for contributors for Shopify and Magento. I may contributor for Salesforce Commerce Cloud.
I was looking for a high-performance storefront with SSR and SSG and end-up here :)
This may be a game changer specially if we support enterprise platforms and multi-locale projects

@cellmanguney Are you able to take Salesforce Commerce Cloud? If so, let me know.  Thank you! https://github.com/vercel/commerce/issues/164

@cellmanguney Are you able to take Salesforce Commerce Cloud? If so, let me know.  Thank you! https://github.com/vercel/commerce/issues/164

@okbel yes I can the Salesforce Commerce Cloud integration part!

@okbel yes I can the Salesforce Commerce Cloud integration part!

I've created a boilerplate to work on the magento provider.
The repo is inspired by the one created by @petermekhaeil for shopify
Here is the link to the project.
https://github.com/lorenzorivosecchi/nextjs-commerce-magento
I'm new to open source, typescript and magento so I could use some help.
Send me a message if you want to contribute or have some advise.

I've created a boilerplate to work on the magento provider.
The repo is inspired by the one created by @petermekhaeil for shopify
Here is the link to the project.
https://github.com/lorenzorivosecchi/nextjs-commerce-magento
I'm new to open source, typescript and magento so I could use some help.
Send me a message if you want to contribute or have some advise.

I've submitted a PR for a Vendure provider: #181

I've submitted a PR for a Vendure provider: #181

@maartenjongerius are you free to work on the Shopify integration?

@maartenjongerius are you free to work on the Shopify integration?

@tobiaghiraldini Send me a DM to talk about Saleor integration - @okbel tw

@tobiaghiraldini Send me a DM to talk about Saleor integration - @okbel tw

@okbel I am free to work on shopify integration ! What do you need ?

@okbel I am free to work on shopify integration ! What do you need ?

@djodjo02130 https://github.com/vercel/commerce/pull/186 - We are about to merge this one, but the contributor can no longer continue. Could you?

@djodjo02130 https://github.com/vercel/commerce/pull/186 - We are about to merge this one, but the contributor can no longer continue. Could you?

@djodjo02130 #186 - We are about to merge this one, but the contributor can no longer continue. Could you?

@okbel For sure !
Make new branch here or tell me which way you want to work for push updates ?
And i think i need to finish the first todo list ? just give me guideline to optimize work.

@djodjo02130 #186 - We are about to merge this one, but the contributor can no longer continue. Could you?

@okbel For sure !
Make new branch here or tell me which way you want to work for push updates ?
And i think i need to finish the first todo list ? just give me guideline to optimize work.

https://github.com/vercel/commerce/pull/199 💃


Created a new repo for Fire detection using yolov5

https://github.com/spacewalk01/Yolov5-Fire-Detection

great work, will link here

done


Move handling of tagged telemetry properties to host layer

Work Item
Describe the outcome you expect
Follow-on to https://github.com/microsoft/FluidFramework/pull/5308.  Handling of tagged telemetry properties belongs in the host layer, where logs may be uploaded via a telemetry system.
Approach
Update ITelemetryBaseLogger.send to take ITaggableTelemetryProperties instead of ITelemetryProperties.
Open questions
Consider whether all our logging APIs should speak in ITaggableTelemetryProperties, not just error logging - probably so.
Additional context
See https://github.com/microsoft/FluidFramework/pull/5308/ for introduction of the tagging
Pre-requisite is #5561
Acceptance criteria
Hosts are able to handle tagged telemetry data.  Follow-up change will be to remove our handling of tags in telemetry-utils/src/logger.ts

When ITelemetryBaseLogger is updated to support tags, we should also add an optional flag to it indicating the host's implementation supports them.  If this is unset, then we need to continue scrubbing and returning plain old telemetry props as a back-compat measure.

Update: ITelemetryBaseLogger has a new field supportsTags?: true, if it's true we can send tagged properties on the log events, if not we need to deal with them ourselves.
Also, ITelemetryProperties itself was updated to include optional tags, which is different from when this issue was first opened.
Work here is to implement supportsTags on all our loggers (TelemetryLogger and subclasses), and then only handle tags as we do if supportsTags is not true.

There's also a bug in Office Fluid's ADO list covering the work over there to support tags

This plan is changing, per this conversation.
New plan:

Work with Office Fluid team to properly support tags, specifically to pass-through PackageData. At this point though, no tagged data will come to their logger due to existing accommodation.
Patch the Definitions packages:
a. common-definitions: Mark supportsTags as deprecated, or just remove it (if ok breaking semver rules).
b. container-definitions: Add taggedLogger
Update Loader and Runtime
a. Loader: pull in updated definitions, and duplicate logger to taggedLogger on ContainerContext.
b. Runtime: Send tagged data as-is to IContainerContext.taggedLogger if present, otherwise continue handling tags and pass untagged data to IContainerContext.logger

Along the way, we'll need to revisit BREAKING.md to clarify all this.
FYI @ksbrar

Overview of PRs (not including bohemia changes):

(2 PRs)

[ ] Change common-definitions by marking supportsTags deprecated in main.
[ ] Then backport as minor patch off of the common-definitions 0.20.1 tag

(2 PRs)

[ ] Add taggedLogger to container-definitions in main
[ ] backport it as a patch off of the build-common 0.22.0 tag

(1 PR)

[ ] One change to update usage of definitions, add taggedLogger to ContainerContext and update runtime handling appropriately.

For step 2, should be backporting to container-definitions 0.39 I think

Office Fluid PR to properly handle tags:  https://dev.azure.com/office/OC/_git/office-bohemia/pullrequest/884580

We changed the plan for how to implement this, did plenty of work on it this month but need another week or two to execute on the new plan and multiple staged PRs.

btw I think you can also mark logger as deprecated on IContainerContext and ContainerContext, but could be wrong

🎉


flux 768p result

Hi! Thanks for releasing 768p model.
I tested I2V inference with this model, check some artifacts and temporal consistency issue in generated videos.

The condition image is face image from ffhq. Size of these image is 1024x1024 so I use this condition image without resize
Give null text condition.

https://github.com/user-attachments/assets/40db3853-b987-4d24-9f69-506a8e6ccfc4
https://github.com/user-attachments/assets/3a51fbf5-3bda-432c-85e3-e67d11f7c4fe
https://github.com/user-attachments/assets/2318eb16-5571-4ee9-8d5b-2eb84e99e167
https://github.com/user-attachments/assets/335908a3-fada-4d76-9ac5-2311366ebe12

As you can see, as generated video goes on, video looks visually blurred and seems subject consistency also tends to be broken.
Why this happend?

Since 768p model is trained with 768x1280 size, RoPE don't handle unseen width/height (1024x1024) well.
Though text is not given at all, I think text doens't matter because 384p model doesn't show those behavior. (Inference with 512x512)
What do you think?

<384p samples>
https://github.com/user-attachments/assets/0c8c75e2-1cdb-486a-8083-a5886e0060b7
https://github.com/user-attachments/assets/da43a847-bd6e-40c5-87d8-b85cfc2fc126

According to our experiments, CFG (for text-conditioning) is quite important for video motion and quality. Could you please test the model with some simple prompts, such as "a person smiling"?

Yes, the CFG is important. So I guess you should not use the null text embedding. Our checkpoint is only trained on text-to-video generation. Can you try again by using a simple text prompt?

Thanks for your comments.

So I put prompt like The portrait remains happy throughout the video clip. Starts with a wide smile, raising cheeks, tightening lids, and pulling up the upper lip. It then transitions into a jaw drop and slight dimpling, maintaining the lip raise.
It looks better but still have some quality issue as before.

<Results of 768p>
https://github.com/user-attachments/assets/05a1a95c-6be5-48f8-b8d8-32484a275bec
https://github.com/user-attachments/assets/a65e2c76-cb04-4f88-b6e4-4960876e1c2d


v0.0.11

Closing this in favour of https://github.com/redhat-developer/odo/pull/733
(Sorry  I didn't notice this PR in a hurry :cry: )


Tab expansion of $

Tab expansion of $ behaves a bit strangely. Mainly erasing characters instead of display matches.
We're using Set-PSReadlineKeyHandler -Key Tab -Function Complete
$env TAB = $
$env TAB TAB = list of all $env variables (without prepending $)
$env:computer TAB = completes correctly (that is, if it is unique enough and matches one)
On a similar note:
$ TAB TAB = list of all $ variables (including everything under $env:) (without prepending $ or some (but not all) post pending : )

Similar to : #126
I would like to add that doing
$env:P TAB = List of posibilities but clears the $env:P to $
$env:Pa TAB = Correct list of possibilities: Path     PATHEXT and does not clear the $env:Pa
$env:Pat TAB = Completes to the only posibility $env:Path

I think this was fixed in 8f6d699 - at any rate, it doesn't repro anymore.


是否有度量深度估计的S模型提供。

是否有度量深度估计的S模型提供。

Hi, we will release metric depth models based on Depth-Anything-V2-Small and Base tomorrow.

We have released smaller metric depth models.


Make deadlock_detection an optional feature and disable it by default.

It seems that parking_lot's deadlock_detection feature causes CPU usage to continuously increase when running for extended periods. I haven't investigated the details yet, but since this feature is likely intended for debugging, I have modified it to be disabled by default. It can now only be enabled by explicitly specifying --features=deadlock_detection.

This seems not meaningful fix. Will close at this moment.


Expand the default block-list

Good Morning!
This is a pretty nifty package.  I would be interested in starting to use it.
One current limitation of this tool is that the default block-list is pretty limited:
https://github.com/PrincetonUniversity/blocklint/blob/386b45c72150c41a16f0c14c202191120a0d753e/blocklint/main.py#L71-L74
This tool would be significantly more useful if it came packaged with a more extensive block-list.  Right now, I need to make the block-list and get it code-reviewed (which I anticipate will be difficult).
In the readme, this alexjs is cited as inspiration:
https://github.com/PrincetonUniversity/blocklint/blob/386b45c72150c41a16f0c14c202191120a0d753e/README.md?plain=1#L8
I did a quick look and it seems like alexjs comes with a very comprehensive block-list via the retext-equality npm package.  The full block-list is here: https://github.com/retextjs/retext-equality/tree/main/data/en
They also provide acceptable alternatives (with sources :) ) so that you can create output like this:
example.md
   1:5-1:14  warning  `boogeyman` may be insensitive, use `boogeymonster` instead                boogeyman-boogeywoman  retext-equality
  1:42-1:48  warning  `master` / `slaves` may be insensitive, use `primary` / `replica` instead  master-slave           retext-equality
  1:69-1:75  warning  Don’t use `slaves`, it’s profane                                           slaves                 retext-profanities
  2:52-2:54  warning  `he` may be insensitive, use `they`, `it` instead                          he-she                 retext-equality
  2:61-2:68  warning  `cripple` may be insensitive, use `person with a limp` instead             gimp                   retext-equality

⚠ 5 warnings

Source
It would be awesome if we could do the following:

Copy the data from https://github.com/retextjs/retext-equality/tree/main/data/en into this repo
Use that as the default block-list
Add support for suggesting alternatives.

It's a good point but I have a few reservations.  I almost purposefully made this unopinionated so others could customize as needed.  Adding an alternative may be within scope, though a larger change.  Here are my concerns with the full alexjs list:

Many examples are field specific.  E.g. islamists probably won't come up in most software development.
Many examples are multiple words/phrases and wouldn't directly translate.
Some are still valid in the context of development (primative, bugreport).

Overall I think including all the inconsiderate words would add bloat for checking source code specifically.  Someone who uses slurs in their code probably won't care if this tool complains.  But legacy usage of something like blacklist or master is what I wanted to mostly catch.  For markdown, I'd also run alexjs to catch offensive phrases and language.
Here's what I'd propose.

make a blocklint config file that includes all single-word entries in the alexjs database
check if linting with that list drastically increases runtime (it may, my regexes are fairly complex)
add a --strict switch which will use the strict config file

So users have the option to specify the strict switch or copy the file from github and modify as they see fit.  I'd be open to a PR for adding a reason, but that would require a lot of rewrites.


First version of the pipeline

This first version should have the following:

[x] Formatting for the Dey lab strains:

A python script in Lab_strains/dey_lab/format.py that takes Manu_strains.xlsx as an input and returns a file Lab_strains/dey_lab/strains.tsv in which the first column is the id of the strain e.g.GD172 and the second column is the phenotype.

[ ] Replacing allele names in the Dey lab collection:

A python script that:

Takes Lab_strains/dey_lab/strains.tsv and data/alleles.toml as an input and replaces the allele names by the word ALLELE and prints all the substituted genotypes to a text file, one per line.
For now, no need to format this output, we can do it in next iterations.

You can push your code after the first task, so that I can review it already, and then the second one.

Remember to reference the PR or commit where you add these changes

closed with pr #20

See #20

@manulera This is the full scipt : https://github.com/manulera/genestorian_data_refinement/blob/gsoc2022/Lab_strains/dey_lab/format.py

Hello @anamika-yadav99 it still does not do what it is supposed to do. I flagged this in #20 (comment quoted below)

Lab_strains/dey_lab/format.py no longer solves https://github.com/manulera/genestorian_data_refinement/issues/16 you should revert to this version: https://github.com/manulera/genestorian_data_refinement/commit/97a4d5b118e15a774e2e717af16efd7001acc843

You marked it as complete, please carefully read my feedback and do not mark the tasks as resolved if they are not.

Good job! Almost perfect. Two things you can do to make things a bit better, and then we close this issue:

[ ] You are going to use the functions feature_dict and replace_allele_features in multiple scripts. Instead of copy pasting them in every file (bad practice), move them to the module file so you can simply import them. Also, feature_dict is a bad function name, it looks like a variable, put a verb in the function name to make it more obvious that it is a function, e.g. make_feature_dict, create_feature_dict or something like that.
[ ] You are no longer using generalised_function.py, remove this file
[ ] Remove the copied functions from generalised_functions.py, and import them from the module instead (see first task in this list).
[ ] When you run the first_version_pipeline.py script, look at lines 106 and 107 of first_version_pipeline.txt. Check the same lines in strains.tsv. This case should be handled.

Almost there!

Ah, another thing:

[ ] Note that in some lines in strains.tsv (such as 222), there is a weird set of characters (‚àÜ0), this gives some problems later, specially when you want to convert to json see that in json this becomes \u201a\u00e0\u00dc. There is also Œî somewhere. These characters seem to be wrong encodings for delta (Δ). Replace them by Δ in format.py.

[ ] kan, nat, hph etc (anything in synonyms section of marker isn't replaced by word 'MARKER')

[ ] In format.py, you should not print the index in the first column (when calling read_file.to_csv).

Ah, another thing:

[ ]  Note that in some lines in strains.tsv (such as 222), there is a weird set of characters (‚àÜ0), this gives some problems later, specially when you want to convert to json see that in json this becomes \u201a\u00e0\u00dc. There is also Œî somewhere. These characters seem to be wrong encodings for delta (Δ). Replace them by Δ in format.py.
Should I replace just àÜ0 with delta or any such weird character with delta?

For now, just replace those two occurrences by delta (‚àÜ0 and Œî)

What I meant here

Remove the copied functions from generalised_functions.py, and import them from the module instead (see first task in this list).

Is to remove the repeated functions from first_version_pipeline.py

What I meant here

Remove the copied functions from generalised_functions.py, and import them from the module instead (see first task in this list).

Is to remove the repeated functions from first_version_pipeline.py

Should I move the function to the genestorian_module and then import it?

completed with PR#23


PowI function in Math Package throws exception for exponent of -1.

In Microsoft.Quantum.Math package, when you call the PowI function with the exponent of -1, it throws a System.ArgumentOutOfRangeException.
To Reproduce
Steps to reproduce the behavior:

Write Q# PowI(2,-1);

Thanks for reporting this; it looks like this happens even when using 2 ^ (-1) directly in Q# and not through the PowI function. As such, I'll go on and transfer this to the runtime repo. Thanks again for reporting this!


python310Packages.matrix-common: 1.1.0 -> 1.2.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.matrix-common is: "Common utilities for Synapse, Sydent and Sygnal"
meta.homepage for python310Packages.matrix-common is: "https://github.com/matrix-org/matrix-python-common"
meta.changelog for python310Packages.matrix-common is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 1.2.1 with grep in /nix/store/ma4skcmwb8y7rhq0m2cmagkfajnhsfr5-python3.10-matrix_common-1.2.1
found 1.2.1 in filename of file in /nix/store/ma4skcmwb8y7rhq0m2cmagkfajnhsfr5-python3.10-matrix_common-1.2.1

Rebuild report (if merged into master) (click to expand)

10 total rebuild path(s)

5 package rebuild(s)

5 x86_64-linux rebuild(s)
5 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
matrix-synapse
matrix-synapse-plugins.matrix-synapse-mjolnir-antispam
matrix-synapse-plugins.matrix-synapse-shared-secret-auth
python310Packages.matrix-common
python39Packages.matrix-common

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ma4skcmwb8y7rhq0m2cmagkfajnhsfr5-python3.10-matrix_common-1.2.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.matrix-common https://github.com/r-ryantm/nixpkgs/archive/4f660634072bf422e574c7ee585b3ab57c1efe34.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ma4skcmwb8y7rhq0m2cmagkfajnhsfr5-python3.10-matrix_common-1.2.1
ls -la /nix/store/ma4skcmwb8y7rhq0m2cmagkfajnhsfr5-python3.10-matrix_common-1.2.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages failed to build:

matrix-synapse
matrix-synapse-plugins.matrix-synapse-mjolnir-antispam
matrix-synapse-plugins.matrix-synapse-shared-secret-auth

2 packages built:

python310Packages.matrix-common
python39Packages.matrix-common

Maintainer pings
cc @sumnerevans for testing.

We should wait to bump this until Synapse bumps its dependency on this.


[BUG] esbuild optimize attempts to unlink bad paths

Bug Report Quick Checklist

[x] I am on the latest version of Snowpack & all plugins. (
[x] I use package manager npm (Fill in: npm, yarn, pnpm, etc).
[x] I run Snowpack on OS Mac (Fill in: Windows, Mac, Linux, etc).
[x] I run Snowpack on Node.js v12+

Describe the bug
Built-in esbuild optimize attempts to unlink a file at a nonexistent path because it skips over the _snowpack/pkg/common part of the path. optimize.ts:486 tries to stitch together the baseName of the bundledInput with the build directory and overlooks the snowpack dirs in the middle.
I added some debugging with a local checkout of snowpack, here's the relevant output before it explodes:
[16:06:03] [snowpack] manifest: {"inputs":{"build/_snowpack/pkg/common/index-e66f0a38.js":{"bytes":8994,"imports":[]},"build/_snowpack/pkg/react.js":{"bytes":116,"imports":[{"path":"build/_snowpack/pkg/common/index-e66f0a38.js","kind":"import-statement"},{"path":"build/_snowpack/pkg/common/index-e66f0a38.js","kind":"import-statement"}]},"build/_snowpack/pkg/react-dom.js":{"bytes":127469,"imports":[{"path":"build/_snowpack/pkg/common/index-e66f0a38.js","kind":"import-statement"}]},"build/App.js":{"bytes":315,"imports":[{"path":"build/_snowpack/pkg/react.js","kind":"import-statement"}]},"build/vscode.css":{"bytes":1978,"imports":[]},"build/index.js":{"bytes":309,"imports":[{"path":"build/_snowpack/pkg/react.js","kind":"import-statement"},{"path":"build/_snowpack/pkg/react-dom.js","kind":"import-statement"},{"path":"build/App.js","kind":"import-statement"},{"path":"build/vscode.css","kind":"import-statement"}]}},"outputs":{"/index.js.map":{"imports":[],"exports":[],"inputs":{},"bytes":282589},"/index.js":{"imports":[],"exports":[],"entryPoint":"build/index.js","inputs":{"build/_snowpack/pkg/common/index-e66f0a38.js":{"bytesInOutput":7141},"build/_snowpack/pkg/react.js":{"bytesInOutput":0},"build/_snowpack/pkg/react-dom.js":{"bytesInOutput":123806},"build/App.js":{"bytesInOutput":178},"build/vscode.css":{"bytesInOutput":0},"build/index.js":{"bytesInOutput":106}},"bytes":131317},"/index.css":{"imports":[],"inputs":{"build/vscode.css":{"bytesInOutput":1772}},"bytes":1773}}}
[16:06:03] [snowpack] buildDirectoryLoc: /Users/idan/src/flat-editor/build
[16:06:03] [snowpack] bundledInput: build/_snowpack/pkg/common/index-e66f0a38.js
[16:06:03] [snowpack] path.basename(bundledInput): index-e66f0a38.js
[16:06:03] [snowpack] Removing bundled source file: /Users/idan/src/flat-editor/build/index-e66f0a38.js
[16:06:03] [snowpack] ENOENT: no such file or directory, unlink '/Users/idan/src/flat-editor/build/index-e66f0a38.js'
[16:06:03] [snowpack] Error: ENOENT: no such file or directory, unlink '/Users/idan/src/flat-editor/build/index-e66f0a38.js'

You can see that it's trying to remove /Users/idan/src/flat-editor/build/index-e66f0a38.js when it should be targeting /Users/idan/src/flat-editor/build/_snowpack/pkg/common/index-e66f0a38.js.
To Reproduce

Clone https://github.com/idan/snowpack-optimize-unlink
npm i && snowpack build

Expected behavior
It doesn't go 💥
Anything else?
Add any other context about the problem here, if useful. Delete this section if not used.

Blame makes me suspect that this is a bug introduced in #2886

Shot in the dark, but maybe constructing the path differently is the correct thing to do? I know zero about esbuild and its changes, so this might be way off base, but it does let me build (locally):
diff --git a/snowpack/src/build/optimize.ts b/snowpack/src/build/optimize.ts
index ad7d68d1..4ed34f32 100644
--- a/snowpack/src/build/optimize.ts
+++ b/snowpack/src/build/optimize.ts
@@ -485,11 +485,11 @@ export async function runBuiltInOptimize(config: SnowpackConfig) {
       if (!manifest.outputs![bundledInput]) {
         logger.debug(
           `Removing bundled source file: ${path.resolve(
-            buildDirectoryLoc,
-            path.basename(bundledInput),
+            originalCwd,
+            bundledInput,
           )}`,
         );
-        await fs.unlink(path.resolve(buildDirectoryLoc, path.basename(bundledInput)));
+        await fs.unlink(path.resolve(originalCwd, bundledInput));
       }
     }
     deleteFromBuildSafe(

You're right, that PR missed a breaking change. Or, I think they tried to fix it with path.basename(bundledInput) but that wasn't doing what they thought it was.
PR created: https://github.com/snowpackjs/snowpack/pull/2914

Thanks for finding before our release!


Issue #14 : reworked remove() method in classic & doubly linked lists

All remove() methods has been reworked in classic & doubly linked lists.

Tests are here


Spurious test failure of large_high_align on x64 MSVC

The test allocates 1 MiB aligned to 1 MiB, so it shouldn't really hit OOM (I think). Yet this log indicates that the allocation failed (by returning a NULL pointer).
All other builds have passed, so this might even be specific to x86_64-pc-windows-msvc.

I've reproduced this for small_high_align under wine:
running 6 tests
test tests::align_less_than_sizeof_usize ... ok
test tests::align_not_power_of_two ... ok
test tests::align_zero ... ok
test tests::large_high_align ... ok
test tests::small_high_align ... FAILED
test tests::small_low_align ... ok

failures:

---- tests::small_high_align stdout ----
	thread 'tests::small_high_align' panicked at 'assertion failed: !ptr.is_null()', src/lib.rs:148


Changes the require to the correct sprocket gem

This will fix the issue that breaks everything when trying to start your rails server. I have created an issue as well that this would close #273. I saw another fix was to add sprockets es6 to the gem file as well if that is the desired fix I can submit a pull request to update the documentation.

Hi @ncoden,
I see three options.
⚠ I don't know what sprockets-es6 for.

Update README to let users know gem 'sprockets-es6' has to be added to their Gemfile.

Add back sprockets-es6 in the gemspec file so that it gets installed as a dependency.

if sprockets-es6 is an unnecessary dependency for this gem, these gemfiles need to be cleaned up and @brianmcoates's fix is nice since Rails already comes with sprockets-rails.

My preference is 2.

@ncoden after talking to my team here we found this https://github.com/zurb/foundation-rails/commit/a6c927db5f604d8d3e2e741389455b69d4c7aff2#diff-44263267796d33ed2765ce27a5ba5f3c What is happening when people bundle install bundle doesn't know what the dependencies are so we need to add them back in. I have updated the pull request to do that.

@khiet @brianmcoates Thanks a lot for the explanations!
I made a mistake, I am sorry. Now I understand better how gemspec files are used. The pull request looks good to me now, but I'm waiting for the opinoin of @rafibomb's Rails engineers to merge it.

@ncoden No worries man it happens to everyone. :) Looking forward to hearing back from your guys rails engineer.

@ncoden have you guys had a chance to talk to your rails eng?

@rafibomb


chartify issues

Hello,
There are issues and pull-requests pending in https://github.com/variantdev/chartify which we are waiting for. Is there a plan here to merge and release?

Hi @mumoshu
I have provided local test docu for : https://github.com/variantdev/chartify/issues/9 on win.
Please let me know if that is sufficient for you.

Finished merging all the pending prs there! Thanks for your cooperation.

Coolio


Speed up/ fix tokenization

Combine sep and cls token addition into one func to speed up
get rid of unnecessary sorts
broadcast tokenize with update
use map partitions for special token addition in tokenizer
set index right from the start !todo: sped up frozen tokenization by getting rid of lambda function

time:

1M tokenization PT  (no ading of special tokens): 950s

@Montgomeryyyy please make sure the sorting also works for lab tests and values


Restoring pre-5.0 component require behavior (all components publicly requirable) (IDFGH-12043)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
So from a developer usability standpoint I feel like the features detailed here is a bit of a solution search for a problem:
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/migration-guides/release-5.x/5.0/build-system.html#specify-component-requirements-explicitly
I'm sure there was a good reason for it, but my builds always worked previously, and the documentation seems to indicate that there is a way to enable the previous dependency behavior, but I've not been able to determine what that might be. Specifically the phrase "these components are no longer added as public requirements by default" would indicate that there is a non-default option. Given the amount of interdependency between my components, and the amount of work needed to update them to work with version above 5.0, I would be extremely interested in such an option, or at the very least a more detailed elaboration as to why this additional work is required on my part, given that (as I mentioned) this appeared to work fine prior to the "fix".

I'm not aware that any such backward compatible option would exists. I hope someone will correct me if I'm wrong.
If I remember it correctly then the motivation behind this breaking change was to pull in less component dependencies, simplify the dependency tree (find dependency issues easily) and to reduce build time.

Hello @amaschas ,
I confirm what @dobairoland said, the goal of these changes was to reduce the build time by only compiling the required dependencies. There is no way to restore the previous behavior via a configuration option or anything like that.
I understand the confusion with the sentence In ESP-IDF v5.0, this behavior is fixed and these components are no longer added as public requirements by default from the documentation. In fact, it means that the components were added to the build system by default, so the by default was referring to the fact that CMake would pull them in the dependency list and you could override this behavior and only keep a few of them. It does not mean that this behavior is the default one now.
Anyway, if you cannot modify the REQUIRES to pull in only the required components you need, one workaround is to pick one of your component (or make a new one) that I am calling A, that would depend on all the ones specified in https://docs.espressif.com/projects/esp-idf/en/latest/esp32/migration-guides/release-5.x/5.0/build-system.html#specify-component-requirements-explicitly
Then all your other components would need to rely on A, with a REQUIRES. As such, A would pull in all these IDF dependencies when compiled.

Closing this issue


Mount does not seem to like React.propTypes.shape().isRequired properties

Mount does not play well with React.propTypes.shape().isRequired properties.
To reproduce:
describeWithDOM("prompt", function () {

   before(function () {
     var obj = {
       title: "Test",
       message: "Test Message"
     };

     this.component = mount(<MyComponent customShape={obj} requiredString="yes" />);
   });

   it("renders correct title", function () {
     var title = this.component
       .find(".modal-header").text();
     expect(title).to.equal("Test");
   });
 }
});

assuming MyComponent declares the following props:
propTypes: {
  customShape: React.PropTypes.shape({
    title: React.PropTypes.string.isRequired,
    message: React.PropTypes.string.isRequired,
  }).isRequired,
  requiredString: React.PropTypes.string.isRequired
}

Produces:
Warning: Failed propType: Required prop customShape was not specified in MyComponent.
Any ideas?
Thanks!

This was actually due to an issue with setProps – which I assume is a different problem.


AC one-way search failing with "Missing form element: tripTypeOneWay"

Log output:
[AC] error Unexpected error occurred while searching!
Error: Evaluation failed: Error: Missing form element: tripTypeOneWay
    at __puppeteer_evaluation_script__:6:19
    at ExecutionContext.evaluateHandle (/home/zq/node_modules/puppeteer/lib/ExecutionContext.js:121:13)
    at process._tickCallback (internal/process/next_tick.js:68:7)
  -- ASYNC --
    at ExecutionContext.<anonymous> (/home/zq/node_modules/puppeteer/lib/helper.js:110:27)
    at ExecutionContext.evaluate (/home/zq/node_modules/puppeteer/lib/ExecutionContext.js:48:31)
    at ExecutionContext.<anonymous> (/home/zq/node_modules/puppeteer/lib/helper.js:111:23)
    at DOMWorld.evaluate (/home/zq/node_modules/puppeteer/lib/DOMWorld.js:112:20)
  -- ASYNC --
    at Frame.<anonymous> (/home/zq/node_modules/puppeteer/lib/helper.js:110:27)
    at Page.evaluate (/home/zq/node_modules/puppeteer/lib/Page.js:782:43)
    at Page.<anonymous> (/home/zq/node_modules/puppeteer/lib/helper.js:111:23)
    at module.exports.fillForm (/home/zq/node_modules/flightplan-tool/src/Searcher.js:160:17)
    at module.exports.search (/home/zq/node_modules/flightplan-tool/src/engines/ac/searcher.js:57:18)

I don't know JS, but I did look at the Aeroplan search page and found that the element seems to be named "tripTypeRoundTrip" and so I subbed that into the code. It seems to work now, but I don't really know yet if the data is worth anything.

That seems right. The name of the round trip and one way radio button is 'tripTypeRoundTrip' so changing the value 'tripTypeOneWay' to 'tripTypeRoundTrip' as you did is the fix.

I issued a pull request to fix this.


Replaces country name with ISO-3166 alpha-2 code in shipments response

Addresses always use ISO-3166 alpha-2 codes to identify a country. In the example response, the full country name 'Germany' has been used.

ready to merge