Broken tests in MapSpec.js

I've found some tests that look passing, but in fact they do not serve their purpose.
https://github.com/Leaflet/Leaflet/blob/1ae785b73092fdb4b97e30f8789345e9f7c7c912/spec/suites/map/MapSpec.js#L49-L54
Correct property should be _leaflet_id

https://github.com/Leaflet/Leaflet/blob/1ae785b73092fdb4b97e30f8789345e9f7c7c912/spec/suites/map/MapSpec.js#L56-L71
This test will pass even without map.disable(), because map need to be initialized first (set view), and it's container must be attached to DOM.

https://github.com/Leaflet/Leaflet/blob/1ae785b73092fdb4b97e30f8789345e9f7c7c912/spec/suites/map/MapSpec.js#L553-L565
This test depends on map state that should be changed in some other test (setView).
If in some conditions map do not get ready that this test just never executed.
Two more tests with the same problem are here:

https://github.com/Leaflet/Leaflet/blob/1ae785b73092fdb4b97e30f8789345e9f7c7c912/spec/suites/map/MapSpec.js#L567-L580
https://github.com/Leaflet/Leaflet/blob/1ae785b73092fdb4b97e30f8789345e9f7c7c912/spec/suites/map/MapSpec.js#L582-L597

https://github.com/Leaflet/Leaflet/blob/1ae785b73092fdb4b97e30f8789345e9f7c7c912/spec/suites/map/MapSpec.js#L1031-L1038
L.Browser.any3d = true; has no effect here, as L.Browser object is 'frozen'.
In fact, this case does not require that.
And same is here:

https://github.com/Leaflet/Leaflet/blob/1ae785b73092fdb4b97e30f8789345e9f7c7c912/spec/suites
/map/MapSpec.js#L1040-L1047

https://github.com/Leaflet/Leaflet/blob/1ae785b73092fdb4b97e30f8789345e9f7c7c912/spec/suites/map/MapSpec.js#L218-L235
On line 228 map.options.crs mock installed, but never restored.
This lead to later error here: https://github.com/Leaflet/Leaflet/blob/1ae785b73092fdb4b97e30f8789345e9f7c7c912/spec/suites/geo/CRSSpec.js#L24-L30
CRS.EPSG3857
project
projects geo coords into meter coords correctly‣
ExpectationError: Unexpected call: project(LatLng(50, 30))
    Expected project(LatLng(62.184756, 6.923933)[, ...]) once (never called)
    Expected project(LatLng(62.140484, 6.926335)[, ...]) once (never called)
    at Object.fail (file:///C:/D/repos/Leaflet/node_modules/sinon/pkg/sinon.js:1621:25)
    at Object.invokeMethod (file:///C:/D/repos/Leaflet/node_modules/sinon/pkg/sinon.js:1826:25)
    at Object.project (file:///C:/D/repos/Leaflet/node_modules/sinon/pkg/sinon.js:1702:35)
    at Context.<anonymous> (suites/geo/CRSSpec.js:26:15)

(It's observed in Chrome and Firefox but not in PhantomJS)


[1.21.1] Hanging Sign Tile Entities Error on Servers

Whenever a player interacts with a Gardens of the Dead hanging sign on a server, the log reports that there is an invalid block entity at the position of the sign. Breaking these signs is also inconsistent and will frequently result in a ghost block being left behind that cannot be removed. Colliding with one of these signs with Amendments installed will prevent the player from rejoining until the sign is removed, but without Amendments the error still appears in the log but the player is not prevented from rejoining.
2024-10-26-1.log

I haven't managed to reproduce this in singleplayer, so it's likely some server-specific issue.


How to introduce a third button just beside next

I want to add a third button called "Save and Exit" just beside the Next Button where an user can just fill the particular form and exit the form-wizard. ON clicking on the "Save and Exit", I want to fire an ajax call which will serialize the form data(tab-1) and save the data to DB. Also, on click of next, we should go to next tab and the data should be saved.

Hi @skaka34
There are 2 separate slots for this
https://cristijora.github.io/vue-form-wizard/#/?id=slots
Here is a small example
https://jsfiddle.net/bt5dhqtf/1396/
Depending on your use case, you could use before-change as a promise and resolve it with true or false depending on your app logic.
If you want to display the save button only after a certain step, you could use some of the exposed properties through the scoped slot https://cristijora.github.io/vue-form-wizard/#/?id=scoped-slots
For example https://jsfiddle.net/bt5dhqtf/1397/
 v-if="props.activeTabIndex > 0"

It's also possible to customize the footer with your own layout where you could introduce as many buttons as you want or perhaps other tags/html


Mac M1 debugging

My Mac M1 is having an issue running Ghidra 10.1.2 as a Debugger.
When trying to debug, I get an error immediately stating LibLLDB not found. I have JDK11, LLDB and XCode installed. Ghidra itself opens fine and it can decompile the programs fine. But when trying to debug I get that error immediately.
NOTE: I tried version 17 of OpenJDK and both aarch64 and x64 builds. Both give the same result.
jake@Jake-laptop ~ % where javac
/usr/bin/javac
jake@Jake-laptop ~ % where java
/usr/bin/java
jake@Jake-laptop ~ % java -version
openjdk version "<IP_ADDRESS>" 2022-02-08
OpenJDK Runtime Environment Temurin-<IP_ADDRESS>+1 (build <IP_ADDRESS>+1)
OpenJDK 64-Bit Server VM Temurin-<IP_ADDRESS>+1 (build <IP_ADDRESS>+1, mixed mode)
jake@Jake-laptop ~ % javac -version
javac <IP_ADDRESS>
jake@Jake-laptop ~ % java -XshowSettings:properties
Property settings:
awt.toolkit = sun.lwawt.macosx.LWCToolkit
file.encoding = UTF-8
file.separator = /
ftp.nonProxyHosts = local|*.local|169.254/16|*.169.254/16
gopherProxySet = false
http.nonProxyHosts = local|*.local|169.254/16|*.169.254/16
java.awt.graphicsenv = sun.awt.CGraphicsEnvironment
java.awt.printerjob = sun.lwawt.macosx.CPrinterJob
java.class.path =
java.class.version = 55.0
java.home = /Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Home
java.io.tmpdir = /var/folders/_5/957hykns6vg0y71wgvjwjp000000gn/T/
java.library.path = /Users/jake/Library/Java/Extensions
/Library/Java/Extensions
/Network/Library/Java/Extensions
/System/Library/Java/Extensions
/usr/lib/java
.
java.runtime.name = OpenJDK Runtime Environment
java.runtime.version = <IP_ADDRESS>+1
java.specification.name = Java Platform API Specification
java.specification.vendor = Oracle Corporation
java.specification.version = 11
java.vendor = Eclipse Adoptium
java.vendor.url = https://adoptium.net/
java.vendor.url.bug = https://github.com/adoptium/adoptium-support/issues
java.vendor.version = Temurin-<IP_ADDRESS>+1
java.version = <IP_ADDRESS>
java.version.date = 2022-02-08
java.vm.compressedOopsMode = Zero based
java.vm.info = mixed mode
java.vm.name = OpenJDK 64-Bit Server VM
java.vm.specification.name = Java Virtual Machine Specification
java.vm.specification.vendor = Oracle Corporation
java.vm.specification.version = 11
java.vm.vendor = Eclipse Adoptium
java.vm.version = <IP_ADDRESS>+1
jdk.debug = release
line.separator = \n
os.arch = x86_64
os.name = Mac OS X
os.version = 12.1
path.separator = :
socksNonProxyHosts = local|*.local|169.254/16|*.169.254/16
sun.arch.data.model = 64
sun.boot.library.path = /Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Home/lib
sun.cpu.endian = little
sun.cpu.isalist =
sun.io.unicode.encoding = UnicodeBig
sun.java.launcher = SUN_STANDARD
sun.jnu.encoding = UTF-8
sun.management.compiler = HotSpot 64-Bit Tiered Compilers
sun.os.patch.level = unknown
user.country = US
user.dir = /Users/jake
user.home = /Users/jake
user.language = en
user.name = jake
user.timezone =

@erfg12 good morning, and let's see if we can get you up and running.  I run off a Mac M1 so this is definitely do-able.  First, two questions:  (1) what is the actuall error?  i.e. if you run with ghidraDebug, is there a stack trace in the console and/or are there any useful messages in either the Interpreter or DebugConsole windows?  and (2) did you walk through the step in InstructionsForBuildingLLDBInterface.txt (in Ghidra/Debug/Debugger-swig-lldb)?  Until lldb decides to accept our patch submissions, you need to build the appropriate SWIG infrastructure.

Hey @d-millar, Happy Friday. Here's an exact screenshot of the error message.
So I followed the InstructionsForBuildingLLDBInterface.txt instructions (at least I think this is correct):
export JAVA_HOME=$(/usr/libexec/java_home)
export LLVM_HOME=$(brew --prefix llvm)/bin
export LLVM_BUILD=$(brew --prefix llvm)
gradle build```

I get the error message `Unable to find the local maven repo.  Ensure you have created the flatRepo directory or ghidra.repos.config file.`

Right, OK - so you need to get set up in development mode.  Try running:
gradle -I gradle/support/fetchDependencies.gradle init

Nice, building started, but lldb is missing a file:
/Users/jake/misc/ghidra/Ghidra/Debug/Debugger-swig-lldb/src/main/cpp/LLDBWrapJava.cpp:266:10: fatal error: lldb/lldb-public.h file not found

#include lldb/lldb-public.h

Ah, I think that might be a shortcoming of the brew install, i.e. no header files.  You can resolve this by pulling the lldb source and either copying files or repointing LLVM_HOME at this, but let me see if (a) this is the case, and (b) there's a better fix.

OK, so they're there, which is good, but the homebrew dir layout is a little different than the LLVM source tree.  If you open up buildNatives.gradle and look for references to "llvm_dir", you'll find the include path code.  I think you're going to need to edit this and replace references to "$llvm_dir/lldb/include" with "$llvm_dir/include".

Got the libldb-java.a file from compilation, I'm guessing that's the file I need? I was expecting a .dylib or something.

Sorry, I looked under the wrong dir, the dylib was located in build/os/mac_arm_64. I put it in extensions dir and debug seems to work now! Thank you @d-millar for all your help.

My pleasure - glad you got it working!  Yell, if you hit any other hiccups.


Add the libsass version to --version

Resolves #140
$ sassc --version
sassc 0.10.1 (sass/libsass 3.3.3)

Coverage increased (+0.04%) to 78.277% when pulling 65d63dbefeeb3ea9a9c2aca50e6de58e8fb86ea3 on asottile:add_libsass_version into 0f04ecd272b06ec5e34e0a3bf47825acdb5b83f2 on dahlia:master.

Coverage increased (+0.04%) to 78.277% when pulling c4e4d9a1b469ca6e06526c3d7169db7e082f1779 on asottile:add_libsass_version into 0f04ecd272b06ec5e34e0a3bf47825acdb5b83f2 on dahlia:master.

Merged!


METRON-2065: Setting Parser Output Topic in Sensor Config is broken

Contributor Comments
This PR fixes a minor bug that fails to honor the outputTopic parser configuration setting and adds a unit test to cover this method.  I slightly refactored the ParserTopologyBuilder class to make this feature easier to test.
Testing
This has been tested in full dev.

Spin up full dev and ensure bro, snort and yaf data is landing in the enrichments topic with the Kafka console consumer tool:

/usr/hdp/current/kafka-broker/bin/kafka-console-consumer.sh --zookeeper node1:2181 --topic enrichments

Update the bro parser configuration to write to a custom output topic:

curl -X POST --header 'Content-Type: application/json' --header 'Accept: application/json' -d '{
  "parserClassName": "org.apache.metron.parsers.bro.BasicBroParser",
  "sensorTopic": "bro",
  "outputTopic": "bro_test"
}' 'http://user:password@node1:8082/api/v1/sensor/parser/config/bro'

Update the snort parser configuration to write to a custom output topic:

curl -X POST --header 'Content-Type: application/json' --header 'Accept: application/json' -d '{
  "parserClassName": "org.apache.metron.parsers.snort.BasicSnortParser",
  "sensorTopic": "snort",
  "outputTopic": "snort_test"
}' 'http://user:password@node1:8082/api/v1/sensor/parser/config/snort'

Update the yaf parser configuration to write to a custom output topic:

curl -X POST --header 'Content-Type: application/json' --header 'Accept: application/json' -d '{
  "parserClassName": "org.apache.metron.parsers.GrokParser",
  "sensorTopic": "yaf",
  "outputTopic": "yaf_test",
  "parserConfig": {
    "grokPath": "/patterns/yaf",
    "patternLabel": "YAF_DELIMITED",
    "timestampField": "start_time",
    "timeFields": [
      "start_time",
      "end_time"
    ],
    "dateFormat": "yyyy-MM-dd HH:mm:ss.S"
  },
  "fieldTransformations": [
    {
      "input": [
        "protocol"
      ],
      "output": [
        "protocol"
      ],
      "transformation": "IP_PROTOCOL",
      "config": {}
    }
  ]
}' 'http://user:password@node1:8082/api/v1/sensor/parser/config/yaf'

Restart the parser topology component in Ambari.
After the topology has started back up, there should be 3 new *_test topics:

[root@node1 vagrant]# /usr/hdp/current/kafka-broker/bin/kafka-topics.sh --zookeeper node1:2181 --list
__consumer_offsets
bro
bro_test
enrichments
escalation
indexing
pcap
snort
snort_test
yaf
yaf_test

These new topics should all have data written to them while the enrichments topic should no longer be written to.

Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[x] Have you included steps or a guide to how the change may be verified and tested manually?

[x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

[x] Have you written or updated unit tests and or integration tests to verify your changes?

[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

When I first encountered this issue, I was a bit confused because we seem to have unit test coverage for this feature passing, but more than that we have the ability to specify the output writer to use, so a sensor output topic didn't make a whole lot of sense to me, e.g. streaming enrichment uses our SimpleHbaseEnrichmentWriter and doesn't write to Kafka. Even so, given your changes in this PR @merrimanr, I think you've found a compromise that works well for all cases. Nice work!
It looks like this is changing default behavior a bit, and I think it looks reasonable, but we could use some documentation around what the expected behavior should be. It looks like the order of operations is:

outputTopic, if present
else parserConfig.getOutputTopic(), if present
else Constants.ENRICHMENT_TOPIC

Also, where does outputTopic come from and how is it different from parserConfig.getOutputTopic()? is this from CLI options?

I added documentation and an additional test case for the outputTopic CLI option in the latest commit.  This includes an explanation of the order of operations.

@merrimanr Thanks for the updates to this - docs and new test look good. +1


chore: change StaticDrift reason to ProvisionerStaticDrift

Fixes #N/A
Description

Change static drift to provisioner static drift

How was this change tested?

make test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.04%) to 79.431%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/provisioning/scheduling/topology.go
2
86.49%

pkg/controllers/provisioning/scheduling/topologygroup.go
2
96.75%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
8040

Relevant Lines:
10122

💛  - Coveralls


It's not working in React

Just tried to add a link using the steps from this page in a React application (scaffolded via create-react-app). No Teams icon is shown.
Steps:

added the reference to the launcher.js in the index.html page (public folder)
added the div to a React function component in the JSX returned

Nothing happened.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5964e0a9-bba0-c5a3-8099-f3845037726c
Version Independent ID: 24565c3b-2bb5-2482-a6c7-7b1f62e38abb
Content: Share to Teams embedded button - Teams
Content Source: msteams-platform/concepts/build-and-test/share-to-teams.md
Product: msteams
GitHub Login: @laujan
Microsoft Alias: lajanuar

Hi @roberto-ajolfi, have you once tried posting the div directly in the index.html page? Please once try and let us know.

Any uptade on that?

@roberto-ajolfi - Could you please confirm if your issue has resolved or still looking for any help?

We are closing this issue for now, Please feel free to reopen it, if required.


+21323290096 is reported to be invalid by the library

Hello the Number +21323290096 is reported as invalid number when its valid fixed_line number in Algeria .
Code :
<!-- Algeria -->

<territory id="DZ" countryCode="213" internationalPrefix="00" nationalPrefix="0" nationalPrefixFormattingRule="$NP$FG">

   <references>

      <sourceUrl>http://www.itu.int/oth/T0202000003/en</sourceUrl>

      <sourceUrl>http://www.arpt.dz</sourceUrl>

   </references>

   <availableFormats>

      <!-- Formatting from http://www.pagesjaunes-dz.com. -->

      <numberFormat pattern="([1-4]\d)(\d{2})(\d{2})(\d{2})">

         <leadingDigits>[1-4]</leadingDigits>

         <format>$1 $2 $3 $4</format>

      </numberFormat>

      <numberFormat pattern="([5-8]\d{2})(\d{2})(\d{2})(\d{2})">

         <leadingDigits>[5-8]</leadingDigits>

         <format>$1 $2 $3 $4</format>

      </numberFormat>

      <numberFormat pattern="(9\d)(\d{3})(\d{2})(\d{2})">

         <leadingDigits>9</leadingDigits>

         <format>$1 $2 $3 $4</format>

      </numberFormat>

   </availableFormats>

   <generalDesc>

      <nationalNumberPattern>(?:

            [1-4]|

            [5-9]\d

          )\d{7}</nationalNumberPattern>

      <possibleNumberPattern>\d{8,9}</possibleNumberPattern>

   </generalDesc>

   <fixedLine>

      <!-- We include the VSAT lines here. -->

      <nationalNumberPattern>(?:

            1\d|

            2[014-79]|

            3[0-8]|

            4[0135689]

          )\d{6}|

          9619\d{5}</nationalNumberPattern>

      <exampleNumber>12345678</exampleNumber>

   </fixedLine>

   <mobile>

      <!-- Adding 65 and 78 from numbers found online. Also, prefix 670 is added since the carrier

             Mobilis Algeria provided it, and 54 for Nedjma. Prefixes 67[1-4] were also added for

             Mobilis Algeria based on evidence found online. -->

      <nationalNumberPattern>(?:

            5[4-6]|

            7[7-9]

          )\d{7}|

          6(?:

            [569]\d|

            7[0-4]

          )\d{6}</nationalNumberPattern>

      <possibleNumberPattern>\d{9}</possibleNumberPattern>

      <exampleNumber>551234567</exampleNumber>

   </mobile>

   <tollFree>

      <nationalNumberPattern>800\d{6}</nationalNumberPattern>

      <possibleNumberPattern>\d{9}</possibleNumberPattern>

      <exampleNumber>800123456</exampleNumber>

   </tollFree>

   <premiumRate>

      <nationalNumberPattern>80[3-689]1\d{5}</nationalNumberPattern>

      <possibleNumberPattern>\d{9}</possibleNumberPattern>

      <exampleNumber>808123456</exampleNumber>

   </premiumRate>

   <!-- The Algerian plan doesn't specify where the costs start to be considered "premium", so we

           draw an arbitrary line here and say that from 50 Da up they will be considered premium.

           -->

   <sharedCost>

      <nationalNumberPattern>80[12]1\d{5}</nationalNumberPattern>

      <possibleNumberPattern>\d{9}</possibleNumberPattern>

      <exampleNumber>801123456</exampleNumber>

   </sharedCost>

   <voip>

      <nationalNumberPattern>98[23]\d{6}</nationalNumberPattern>

      <possibleNumberPattern>\d{9}</possibleNumberPattern>

      <exampleNumber>983123456</exampleNumber>

   </voip>

</territory>

Hi,
Do you have supporting evidence of the number being valid? For example official documentation from the government, telecom authority or carrier are good. If none of them are available, news reports of the introduction of the new prefixes are also OK.

Hi ,
Thank you for your quick reply .
I found this document about numbering plan on algeria :
http://www.arpt.dz/fr/doc/gd/num/New_plan_num_EN.pdf
and you can call this phone number to make sure i did it my self and the call was connected .
Best regards,
Alaa

We consider valid the numbers beginning with 2 that are followed by 0, 1, 4-7, or 9.
The document you link to does not have details on valid phone number ranges. All it says about numbers beginning with 2 is that they may be of the form +213 2 BPQMCDU, but the "BPQMCDU" part could still have restrictions. Please find specific evidence for the range you want supported.

Hi again,
Just to check in on this, will you provide evidence for the range you want supported? Otherwise we can't make the required change and will have to close this issue.

Hello ,
I can not find any evidence ,
for me calling the number and having person answering is good proof , if
you do not accept it , you can proceed with closing.
Thank you
2015-08-05 13:31 GMT+02:00 Keghani Kouzoujian<EMAIL_ADDRESS>
Hi again,
Just to check in on this, will you provide evidence for the range you want
supported? Otherwise we can't make the required change and will have to
close this issue.
—
Reply to this email directly or view it on GitHub
https://github.com/googlei18n/libphonenumber/issues/754#issuecomment-127962901
.

--
Merci,
Cordialement.

Alaa TOUNSADI
Ingénieur en Télécoms
GSM : 07 62 03 79 92

Hi AlaaT,
It's easy enough to verify this single number, but what about other similar numbers? Should we support all numbers of the form
+213 23 xx xx xx or
+213 23 2x xx xx or
+213 23 29 xx xx or
something else?

What's the prefix or the range that we should support? We need evidence or documentation for the whole range.
If you could help me formalize the range I'd be happy to support it.

We've found evidence for the +213 23 range. This will be added in the next version.

Oh that great thank you ,
I called the regulations authority but they did not gave me any detailed numbering plan.
Have a nice day.

This looks to be fixed: see +21323290096 at http://libphonenumber.appspot.com/