[SPARK-32635][SQL] Fix foldable propagation

What changes were proposed in this pull request?
This PR rewrites FoldablePropagation rule to replace attribute references in a node with foldables coming only from the node's children.
Before this PR in the case of this example:
val a = Seq("1").toDF("col1").withColumn("col2", lit("1"))
val b = Seq("2").toDF("col1").withColumn("col2", lit("2"))
val aub = a.union(b)
val c = aub.filter($"col1" === "2").cache()
val d = Seq("2").toDF( "col4")
val r = d.join(aub, $"col2" === $"col4").select("col4")
val l = c.select("col2")
val df = l.join(r, $"col2" === $"col4", "LeftOuter")
df.show()

foldable propagation happens incorrectly:
 Join LeftOuter, (col2#6 = col4#34)                                                              Join LeftOuter, (col2#6 = col4#34)
!:- Project [col2#6]                                                                             :- Project [1 AS col2#6]
 :  +- InMemoryRelation [col1#4, col2#6], StorageLevel(disk, memory, deserialized, 1 replicas)   :  +- InMemoryRelation [col1#4, col2#6], StorageLevel(disk, memory, deserialized, 1 replicas)
 :        +- Union                                                                               :        +- Union
 :           :- *(1) Project [value#1 AS col1#4, 1 AS col2#6]                                    :           :- *(1) Project [value#1 AS col1#4, 1 AS col2#6]
 :           :  +- *(1) Filter (isnotnull(value#1) AND (value#1 = 2))                            :           :  +- *(1) Filter (isnotnull(value#1) AND (value#1 = 2))
 :           :     +- *(1) LocalTableScan [value#1]                                              :           :     +- *(1) LocalTableScan [value#1]
 :           +- *(2) Project [value#10 AS col1#13, 2 AS col2#15]                                 :           +- *(2) Project [value#10 AS col1#13, 2 AS col2#15]
 :              +- *(2) Filter (isnotnull(value#10) AND (value#10 = 2))                          :              +- *(2) Filter (isnotnull(value#10) AND (value#10 = 2))
 :                 +- *(2) LocalTableScan [value#10]                                             :                 +- *(2) LocalTableScan [value#10]
 +- Project [col4#34]                                                                            +- Project [col4#34]
    +- Join Inner, (col2#6 = col4#34)                                                               +- Join Inner, (col2#6 = col4#34)
       :- Project [value#31 AS col4#34]                                                                :- Project [value#31 AS col4#34]
       :  +- LocalRelation [value#31]                                                                  :  +- LocalRelation [value#31]
       +- Project [col2#6]                                                                             +- Project [col2#6]
          +- Union false, false                                                                           +- Union false, false
             :- Project [1 AS col2#6]                                                                        :- Project [1 AS col2#6]
             :  +- LocalRelation [value#1]                                                                   :  +- LocalRelation [value#1]
             +- Project [2 AS col2#15]                                                                       +- Project [2 AS col2#15]
                +- LocalRelation [value#10]                                                                     +- LocalRelation [value#10]

and so the result is wrong:
+----+----+
|col2|col4|
+----+----+
|   1|null|
+----+----+

After this PR foldable propagation will not happen incorrectly and the result is correct:
+----+----+
|col2|col4|
+----+----+
|   2|   2|
+----+----+

Why are the changes needed?
To fix a correctness issue.
Does this PR introduce any user-facing change?
Yes, fixes a correctness issue.
How was this patch tested?
Existing and new UTs.

Test build #128764 has started for PR 29771 at commit bc433e8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33387/
Test PASSed.

Test build #128764 has finished for PR 29771 at commit bc433e8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128764/
Test PASSed.

cc @cloud-fan, @viirya

Looks ok otherwise. Nice fix.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33431/
Test PASSed.

Test build #128808 has started for PR 29771 at commit 55575de.

Test build #128810 has started for PR 29771 at commit 0c0a115.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33433/
Test PASSed.

last commit is just a minor improvement

Test build #128812 has started for PR 29771 at commit 5f7bbfb.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33435/
Test PASSed.

LGTM (not a Reviewer). Eliminating var FTW!
I'd like to ask about a few things though:

The fix involved a bit of refactoring. Is the bug caused by "leaking" the foldableMap from a sibling node, such that it's not properly just propagating along the child->parent flow? And that the refactoring eliminated the var the threaded the propagation via returns in a recursive depth-first traversal to make sure that it's always only propagating along the child->parent flow, and otherwise the existing logic is unchanged? If so, this looks like a nice refactoring.
TreeNode's transformXXX functions take care of the case where a new node is actually equal to the old one, so that after transformation the logically unchanged nodes will stay with their original identity. It looks like with the explicit recursion after this PR, that it might introduce more, unnecessary copies of the logically unchanged nodes that end up staying in the transformed tree. Is that the case? If so, can we make it better?

Thanks!

Test build #128812 has finished for PR 29771 at commit 5f7bbfb.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128812/
Test FAILed.

that it might introduce more, unnecessary copies of the logically unchanged nodes

Good point. mapChildren takes care of it and we should always use mapChildren instead of node.copy(child = newChild)

The fix involved a bit of refactoring. Is the bug caused by "leaking" the foldableMap from a sibling node, such that it's not properly just propagating along the child->parent flow? And that the refactoring eliminated the var the threaded the propagation via returns in a recursive depth-first traversal to make sure that it's always only propagating along the child->parent flow, and otherwise the existing logic is unchanged? If so, this looks like a nice refactoring.

This is exactly what happens without this PR. Basically foldableMap is filled up with all foldables in the beginning and then we start the preorder traversal and replacing references from the map. Sometimes we narrow down the map when traversing through particular nodes, but this is still incorrect.
With this PR we do a proper fill-up and child->parent propagation of the map.

TreeNode's transformXXX functions take care of the case where a new node is actually equal to the old one, so that after transformation the logically unchanged nodes will stay with their original identity. It looks like with the explicit recursion after this PR, that it might introduce more, unnecessary copies of the logically unchanged nodes that end up staying in the transformed tree. Is that the case? If so, can we make it better?

I think this is a very good point actually. 'mapChildren()in the "other" case seems to be ok as that method takes care of the comparison.withNewChildren()also takes care of it inUnaryNodeandJoin. The replaceFoldable()call afterwithNewChildren()is also ok because it usestransformExpressions.  Finally ProjectandExpand, well, we could change the simple copy() in these cases. But I think if there is a parent "other"/UnaryNode/Joinabove these 2 they will be also fine in the end. But let me change thecopy()`, though.

Test build #128825 has started for PR 29771 at commit 54f41fa.

Thanks @rednaxelafx, latest commit contains the fix.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33448/
Test PASSed.

Test build #128808 has finished for PR 29771 at commit 55575de.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128808/
Test PASSed.

Test build #128810 has finished for PR 29771 at commit 0c0a115.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128810/
Test PASSed.

Test build #128835 has started for PR 29771 at commit 75d7a4c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33459/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33460/
Test PASSed.

Test build #128837 has started for PR 29771 at commit 61548c7.

Ur, @peter-toth . Could you check the PR description once more?
scala> spark.version
res1: String = 3.0.1

scala> :paste
// Entering paste mode (ctrl-D to finish)

val a = Seq("1").toDF("col1").withColumn("col2", lit("1"))
val b = Seq("2").toDF("col1").withColumn("col2", lit("2"))
val aub = a.union(b)
val c = aub.filter($"col1" === "2").cache()
val d = Seq("2").toDF( "col4")
val r = d.join(aub, $"col2" === $"col4").select("col4")
val l = c.select("col2")
val df = l.join(r, $"col2" === $"col4", "LeftOuter")
df.show()

// Exiting paste mode, now interpreting.

+----+----+
|col2|col4|
+----+----+
|   2|   2|
+----+----+

Ur, @peter-toth . Could you check the PR description once more?

Please run the shell with  --conf "spark.sql.optimizer.excludedRules=org.apache.spark.sql.catalyst.optimizer.ConvertToLocalRelation" as that test suite does.

Got it. Thanks, @peter-toth !

Test build #128825 has finished for PR 29771 at commit 54f41fa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128825/
Test PASSed.

Test build #128835 has finished for PR 29771 at commit 75d7a4c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128835/
Test PASSed.

Test build #128837 has finished for PR 29771 at commit 61548c7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128837/
Test PASSed.

Nice suggestion, @rednaxelafx ! I checked the latest commits again and they looks okay.

Thanks! Merged to master/3.0. Could you backport it into branch-2.4, @peter-toth ?

Also, do you want to make a PR for the @gatorsmile comment above  https://github.com/apache/spark/pull/29771#discussion_r490412031?

@maropu and @peter-toth . Please don't forget https://github.com/apache/spark/pull/29771#discussion_r490479155 . That should be backported together.

Oh, I missed it. Could you fix it first in follow-up @peter-toth ?

Thanks all for the review!
I've opened a follow-up PR: https://github.com/apache/spark/pull/29802 to add a new test case to FoldablePropagationSuite.
I will open a 2.4 backport PR soon and I'm happy to extend propagation to Aggregate (https://github.com/apache/spark/pull/29771#discussion_r490412031) as well in a separate ticket.

Nice @peter-toth, LGTM too! cc @vinodkc FYI


Please more examples ...

Please provide more simple examples regarding to the documentation. The section 'Parsing Expression Types' could be better if the are some simple examples to get into the usage of the expression.
Thank you.

I'm imagining an example for each type, showing a matching input and a non-matching input.  For example:
"literal"
'literal'
Match exact literal string and return it. The string syntax is the same as in JavaScript. Appending i right after the literal makes the match case-insensitive.
Example: top = "foo"i
Matches: foo, FOO, FoO
Doesn't match: fo, fooo, bar

Strongly speaking, fooo is matched by this rule, but the whole grammar does not match (because grammar shouldn't leve unconsumed input)

Let's decide if these are single rules or full grammars, I guess.  Either works for me as long as we're consistent.

My vote for single rules with an explanation that examples just for rules, to see them in action you should pretend that actual grammar is
grammar = rule .*;
rule = <whatever>;

Links to live examples (or even embedded examples) also would be useful, but that the task for a web-site.

I like the live playground idea, and since the docs are web-only now, that should work.  We could have one large grammar that has a rule for each section, with each rule in the allowedStartRules.
Maybe let's try that, and see what it feels like in practice before we finalize the .* approach?

The .* approach is for dealing with situations like
foo = 'foo'i;

and input
foooo

The rule itself will match the beginning of this string, but to show this in action we should append .* to the end of rule, or just use grammar rule shown above. I think, it is important to highlight this particularity, because otherwise people can have a wrong impression that to match a keyword the grammar
keyword = 'keyword';

is enough (spoiler: it isn't, the right way to do that is to check that after a keyword there is a delimiter symbol or not an identifier symbol:
keyword = 'keyword' !identifierPart;

)
I think more about supporting GET parameters in the https://peggy.js/online to embed a grammar and adding that links to a docs. I don't think that this should be a hard to implement.

Can you take a look at https://raw.githack.com/hildjj/peggy/examples/docs/documentation.html please, and see what you think before I finish?  Go down to "Parsing Expression Types", and look at the first two.

These two examples are very simple. The inline try-test is nice, but not really required. I would like to see examples for the '&/! expression */+/?' and '&{predicate}'.
I used your online version too. This is a very good learning tool.

Please refresh the link above and see what you think?  I have now agreed with @Mingun about just matching the beginning, and have started returning { match: "stuff that matched", rest: "stuff after the match" }

This will show up with the next release.  I don't want to cherry-pick it onto the docs branch because the tooling needed to build it is only available after the next release.

In the meantime, you can use https://raw.githack.com/peggyjs/peggy/main/docs/documentation.html

I looked at the examples and understood. They are very short, but now I understand how I can use e.g. predicates. I hadn't used that yet. Thank you.


[Win10] Subutai P2P service needs to be started manually after setup

After launcher installs all components, Subutai P2P service is Stopped. It works after manual start

This is happens when subutai directory was removed manually, which cause incorrect service removal. That keeps previous service installed and other operating related to this service will fail unless reboot or manual service start. We can't deal with this for now and keep it for later.


nixos/snapper: fix timeline option types

Description of changes
These can be either an integer or a range.
Range options are necessary for FREE_LIMIT to take effect when used in conjunction with TIMELINE_LIMIT_*.
Fixes configurations broken by https://github.com/NixOS/nixpkgs/pull/324083.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Rebased and fixed merge conflict.

Maybe it is worth to
let
  intOrStr = with types; either int str;
in
...

Also, maybe ints.unsigned might be more suitable here.

Makes sense, should probably also have reused the safeStr type that's already defined as well.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 327418

x86_64-linux

:fast_forward: 1 package blacklisted:

nixos-install-tools

aarch64-linux

:fast_forward: 1 package blacklisted:

nixos-install-tools

x86_64-darwin

aarch64-darwin

Minor bikeshedding: technically the most correct type definition would be something like:
    lib.types.ints.unsigned
    (lib.types.strMatching "[[:digit:]]+(\-[[:digit:]]+)?" // {
      description = "string containing either a number or a range";
      descriptionClass = "conjunction";
    })

Which makes things explicit without having to look at git blame. Would this be worthwhile?

Minor bikeshedding: technically the most correct type definition would be something like:

Sorry, I have merged right before your comment showed up.

Thanks, and this is probably good enough, as now ranges at least evaluate properly.


chore: to_additive adds instances

It does not work yet and I don't really know why. I somewhat suspect that the instances are registered after the monad in to_additive is run.

@alexjbest now your complaints are valid. I've tried and did not make any meaningful progress and I asked on zulip.

Yes, I've also tried this and agree there is missing API (this is why I mentioned adding a TODO rather than implementing it here).
I'll also continue trying to see if I can understand / extract the right api functions from lean.
I think its probably preferable to merge this for now and improve it later.

Do we need to add some links in the source code to zulip discussions and/or Lean 4 issues asking for this extra API? It would be nice to leave some breadcrumbs here.

Added an issue in Lean 4: https://github.com/leanprover/lean4/issues/1878

bors merge


Fix grammar mistakes in the readme file

Nice work - I'm going to close this PR so everyone else can finish the assignment


Error line numbers coming out with invalid values

For #10708
Number of problems here.
Old code assumed that if the file in the error message matched the cell, it was the cell. This doesn't work if the exception is thrown in a different cell that's been referenced (as it will have the same file). The example for this is in the bug.
Old code also didn't take into account extra spacing at the top of a cell.
New code uses the cell hash provider to look for the closest match to the source code in the stack trace (if the file matches a file that we ran cells from).
Note that this may find invalid cells if they have duplicate code in them. Don't see a way around this without getting rid of the __file__ support. An exception doesn't log any other information other than the code in the traceback.

Codecov Report

Merging #11234 into master will decrease coverage by 0.33%.
The diff coverage is 82.60%.

@@            Coverage Diff             @@
##           master   #11234      +/-   ##
==========================================
- Coverage   61.37%   61.03%   -0.34%
==========================================
  Files         604      601       -3
  Lines       33528    33091     -437
  Branches     4746     4673      -73
==========================================
- Hits        20577    20198     -379
+ Misses      11894    11879      -15
+ Partials     1057     1014      -43

Impacted Files
Coverage Δ

src/client/datascience/jupyter/jupyterUtils.ts
57.14% <ø> (-17.28%)
:arrow_down:

src/client/datascience/types.ts
100.00% <ø> (ø)

src/client/datascience/jupyter/jupyterNotebook.ts
4.21% <50.00%> (-0.01%)
:arrow_down:

...datascience/editor-integration/cellhashprovider.ts
77.65% <84.09%> (+4.74%)
:arrow_up:

.../datascience/jupyter/interpreter/jupyterCommand.ts
9.48% <0.00%> (-45.69%)
:arrow_down:

src/client/common/errors/errorUtils.ts
50.00% <0.00%> (-16.67%)
:arrow_down:

src/datascience-ui/react-common/arePathsSame.ts
75.00% <0.00%> (-12.50%)
:arrow_down:

src/client/common/utils/platform.ts
64.70% <0.00%> (-11.77%)
:arrow_down:

...t/datascience/jupyter/kernels/jupyterKernelSpec.ts
92.00% <0.00%> (-8.00%)
:arrow_down:

src/client/common/cancellation.ts
69.38% <0.00%> (-4.09%)
:arrow_down:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bed560...dea4fce. Read the comment docs.

Sorry got wrapped up in the bug bash. I can look early monday.


Mention in readme that you need libx11-dev on ubuntu and fix some typos

Can you change your verbiage on the readme to something like
Make sure libx11-dev is installed
$ sudo apt-get install libx11-dev

Add the .desktop file to the xsessions directory. This will add a new selection to the list of window managers at the login screen.
...

:shipit:


i18n(es): Update images V3

What kind of changes does this PR include?

New or updated content
Translated content

Description

What does this PR change? Give us a brief description.
Update images V3 PR

Listo!, gracias por la revisión 🤠

Looking great @Waxer59 & @dreyfus92 ! Please see the last minute change I made to the images page, 4. Removing Sharp in the main PR, and then I think we're calling the Image PR done!  :partying_face:

Did I miss any other commit?

I believe not! Thanks @Waxer59 🙌


how to use protocol version with clusters?

Seems like i'm missing something :(
i'm doing this in elixir:
config :cqerl,
  cassandra_clusters: [
    cluster1: { ["<IP_ADDRESS>:9042"], [
      keyspace: "some_keyspace",
    ]}
  ],
  protocol_version: 3,
  maps: true,
  text_uuids: true

but this doesnt seems to work :(

Which part isn't working and how is it not working?

nm, managed to figure it out

ok, thanks. Feel free to say what happened so the next person knows how to solve a problem similar to the one you had.


CSS issue in create account page （previous issue #77）

Previous issue https://github.com/KyberNetwork/KyberWallet/issues/77 has been fixed, but it seems the font-size of "Type in your passphrase" is different with "Retype your passphrase".
Environment:
Safari, Version 10.1.1 (12603.2.4)

@maobisheng thanks, I already reopen the previous issues. Please refer to it #77


3000273-970717 supported but no profile?

Hi all.
3000273-970717 is listed in supported devices, however, when I tried to flash it I get the following error:
Could not load profile /work/device-profiles/LSC/3000273-970717/profile. Are you sure the profile directory and file exist?
And indeed, there is no  profile file in the directory. I see from the git history that it was never introduced. Is it possible to do this somehow without the profile?
I have flashed 3 other bulb types (3001686-970709,3000272-970716, 2578539-970719) without problem (including OTA for OpenBK7231T) and I tried to use those profiles as they are similar enough but that always results in DECRYPTION_FAILED_OR_BAD_RECORD_MAC.
Let me know what I'm doing wrong or if I can provide more information.
Thanks!

It looks like the profile is probably the same as the Arlec ALD092CHA
{
    "chip": "BK7231T",
    "payload": "eyJhdXprZXkiOiJBVVRIS0VZQUFBQUFBQUFBIiwidXVpZCI6IlVVSURBQUFBQUFBQSIsInBza0tleSI6IiIsInByb2RfdGVzdCI6ZmFsc2UsImFwX3NzaWQiOiJBIiwic3NpZCI6IkEiLCJ0b2tlbiI6IkFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQWWmCyJ9",
    "authkey_template": "AUTHKEYAAAAAAAAA",
    "uuid_template": "UUIDAAAAAAAA",
    "datagram_padding": "QkJCQh3VCgAd1QoAHdUKAB3VCgAd1QoAHdUKAB3VCgAd1QoAHdUKAA=="
}

Thanks @Cossid, let me try it out and report back.

@pkoretic i too have a 3000273-970717 device - i managed to flash it by adding the profile as mentioned above. It's running OpenBK7231T (version 1.14.71) - so far so good.
I just cannot get the bulb to do anything. I tried some default pin out configs for the 3000272 (seems super similar) and might have the same pin layout, but to no avail.
Did you ever manage to get this device up and running? Mind giving me some advice on the right config in OpenBK in case you DID get it working?
thanks !

@ReanuKeeves01 is there an LED driver on the bulb? Since the usual PWN pin’s not working for you

@ferbulous I'm honestly not entirely sure, i haven't opened the bulb yet.
I did however get some good tips from someone on the Elektroda forum, that helped me in finding the correct channels/pins
First, the correct pins were:

How i figured it out, was by putting all the possible PWM pins (6,7,8,9,24 and 26) on REL (Relay) and gave them value 0,1,2,3,4 and 5.
Reference is on the config page:
"BK7231N/BK7231T supports PWM only on pins 6, 7, 8, 9, 24 and 26!"
The above gave me 6 buttons/toggles on the homepage, of which 2 worked. For me P7 and P8, i then noticed the values were all reversed (color temperature)... so i ended up with the flipped values as per screenshot above.

@ReanuKeeves01 so only 2 pins out of 6?
I take it that’s not RGBCW bulb (only CW) since you only get warm and cold light?

@ferbulous that is correct. only CW.

@pkoretic You mentioned that you also flashed 3001686-970709 bulbs.
which should be this one:

What did you flash it with? Or was it perhaps one of the older versions still with an ESP chip?? I already (seemingly) bricked one of these trying to flash OpenBK on it...

@ReanuKeeves01 ok, so you’ve got all the pins needed. But you still can’t control anything from the bulbs? That’s odd
For the (seemingly) bricked led, does it still light up at least? Otherwise you might’ve flashed the wrong firmware type for the device

@ReanuKeeves01 indeed I flashed it in the same way with same firmware (OpenBK7231T_UG_1.12.60.bin, upgraded now to latest OpenBK7231T_UG_1.14.72.bin).
Those were all bought maybe a year ago so probably they have older chips.
Only ones I couldn't manage to flash / cut from the cloud are 3001702-970727 and 3001700-970739.

@ferbulous no actually I did eventually solve it. The 3000273-970717 bulb is working as intended now. The help from the forum solved it for me.
For the 2nd bulb, which is the 3001686-970709 type; No it doesn't come on at all. But i think i might have flashed the  OpenBK7231N-variant on that. So most likely that one is a goner seeing that @pkoretic confirmed he used a OpenBK7231T.
Thanks all, I have two more 3001686-970709 brand new in a box. I'm gonna give it another go tonight with the correct firmware variation.

@pkoretic Do you recall if you used the existing device profile for the 3001686-970709 or did you tweak anything?
I'm getting a seemingly successful flash, no errors. Yet the procedure doesn't seem to have succeeded as no AP is created by the bulb. It seems to remain with the Original Firmware as i can still operate it by hand and put it in pairing or ap mode. So at least it doesn't seem bricked this time.

@ReanuKeeves01 for some bulbs I had to repeat process 2 times. It said it will reset in 30 seconds flashed but nothing happened even after few minutes. So I repeated the proces and then it worked. I think I never had to do it more than 2x times though.

@pkoretic alright, let me try that. It does exactly that, but if i recall correctly from the succesful one earlier today, the fireware sending took longer and mentioned several of those 'Device will download and reset' .... will let you know how it goes!

@pkoretic are these the PIN settings you're using?

I've tried these two channels and can config they are the right ones. Yet once i set them up as above it won't work anymore. Setting the above channels on REL allows me to toggle it on for either yellow/white.

@pkoretic just realized i never followed up. Perhaps it could be useful for a future reader.
After 3 or 4 tries, I noticed the script would always halt at the exact same moment. What worked for me, was copying out the file(s) from the configured_devices folder and then emptying the folder out. Kinda forcing the script to see the device 'as new'. After this, it flashed correctly first try.
I have a feeling, after running it numerous times and while it never gracefully exited, certain stuff just doesn't get stopped or halted properly, causing things to go wonky on next runs so i went one step further to avoid this with future bulbs.
For my personal workflow (i use Proxmox locally) I now have a prepared container template that has everything needed for cloudcutter to run pre-installed and setup. I found that spinning up a fresh container for every new device really sped up the process and only takes me seconds to do.

Closed automatically by the PR merge, but seems like the issue is "resolved"? Please let me know if a re-open is needed!


SCP-3502: Add AppendBlocks effect

This should increase the speed of the chain index.
 ON CONFLICT  DO NOTHING": too many SQL variables

@koslambrou

The new configs should also be added in CommandLine.hs

At first I added them as CLI params but then thought a bit and decided that that params are better to be config params as they shouldn't be updated that often (very similar to cicSecurityParam and cicStoreFrom). Will add them as cli params as well.

The Resume doesn't seem to work anymore. When I stop the syncing and restart, it always restart from zero.

Hmmm. This is strange, it works for me — https://gist.github.com/ak3n/702b62fd3d86b1f8aaf54db5d195bfdf
Could you please describe how to reproduce it? Maybe there is a specific scenario.

The default 15k of batch size uses too much memory. Tried it on testnet and on about 20% syncing, more than 20GB was used. Maybe 1k? Or 5k?

Ok, this is what I was afraid of. It depends on the system. Every user should find the optimal params. 15k works for me with 8gb of RAM on macos. I suppose it heavily uses the swapping to make it work.

Mmm... there's definitely something wrong with resuming.
The command I used was: cabal run plutus-chain-index -- start-index --network-id<PHONE_NUMBER> --socket-path /tmp/cardano-node/testnet/node.sock --db-path /tmp/cardano-node/testnet/chain-index.db
Here's the last log I got:
...
[chain-index:Info:29] [2022-03-08 18:56:22.06 UTC] Syncing (85.42%). Applied 2864 blocks, 0 rollbacks in the last 30s. Current tip is Point(Slot 44758433, BlockId 7ff89d67303ecca9540d3a7e284f47a8eb44b29faf9f10918c3d2275db55e8c2)

After simply restarting the chain-index, here's the first log I get:
[chain-index:Info:29] [2022-03-09 12:50:12.22 UTC] Syncing (0.40%). Applied 36284 blocks, 0 rollbacks in the last 30s. Current tip is Point(Slot 210875, BlockId 5546a784b4ab9a935afb553e29b52ebaba581869f4a5a602eafe2939ba6ba36f)

Just tried it on main, and everything works as expected. main manages to resume correctly, and no sql errors.

I'm running a modification of this branch with pab-cli and hardcoding the append-batch-size option to 1000.
@@ -335,6 +335,7 @@ startChainIndex networkId
                <> " --db-path " <> getChainIndexDbPath (createChainIndexDbPath nodeOptsOutputDir)
                <> " --port " <> show (unChainIndexPort chainIndexOptsPort)
                <> " --network-id " <> show (C.unNetworkMagic $ C.toNetworkMagic networkId)
+               <> " --append-batch-size " <> (show 1000)

Running for a few hours now and the pab application itself is using over 80% of 64GB RAM system. CPU is a threadripper 1950x (16C/32T).
    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
 185920 lc        20   0 1030.4g   3.6g  24920 S  1262   5.8   2342:49 plutus-chain-in
 185784 lc        20   0 1025.4g   4.3g  29824 S 199.0   6.8 393:23.21 cardano-node
 185976 lc        20   0 1024.3g  49.8g  34116 R   9.0  79.4  34:16.97 multi-pab
 185924 lc        20   0 1024.7g 116304  34584 S   1.0   0.2  10:11.52 cardano-wallet

@locallycompact thanks for reporting! That approves that chain-index is in a better form now.
Have no idea what might be wrong with PAB yet.

I'm also experiencing the reset from zero on restart. Any idea what could be causing this?

I suspect it's because of a missing transaction. We delete tips and other stuff in reduceOldUtxoDb before inserting new tips. By stopping chain-index somewhere between we break the db state.
Working on a fix at the moment.

This is still using tons of memory if you leave it for long enough
    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
2724484 root      20   0 1032.7g  56.9g  19972 S  3036  90.7  10586:22 plutus-chain-in

@locallycompact yeah, this is because blocks become much bigger later but the queue size is constant. I'm working at the moment to improve it and make the memory usage constant during the whole chain.

I'm also still getting the restart behaviour, I'm not sure if that fix was included here.


Document EmailAddressAttribute with schema.Format = "email"

Adds swagger documentation for the EmailAddressAttribute data annotation by setting the schema format equal to "email".

As far as I can tell, "email" is not one of the standard format values identified by the Swagger spec. If applications want to expose their own custom formats, then they should use a Schema filter (see readme)


Add RNNs intro

References

The Unreasonable Effectiveness of Recurrent Neural Networks
Recurrent Neural Networks cheatsheet
List Table Directive
Multi-line table cell in reStructuredText
Can you clone-stamp semi-transparent images and not have them build on top of each other?

Migrated to https://github.com/QubitPi/lamassu/commit/50c0a70c0f7691c0cf2123d3d7475f810991b8fa


Memory usage during build

After the v0.6 release — the first since we moved to Vue CLI (see #217) — it stopped being possible to build Frontend on a Digital Ocean droplet with 1 GB of memory (forum topic).
@issa-tseng writes on Slack:

it takes webpack ~1065MB of active memory (and something over 3GB of virtual memory) to build the frontend..

so the memory profile is sort of interesting; there's a main process that balloons to ~485MB while it's building the "legacy bundle", and then (without freeing any memory) it spawns a second process that builds the .. whatever the nonlegacy bundle is i can't remember. modern? and that one balloons out the rest of the ~1100MB. then both quit the moment it's done. so if somehow those could be separated that would help but.. it still just seems weirdly excessive.

I don't see any Vue CLI options related to memory/space. However, there are probably changes we could make to the webpack configuration.
Also, currently it does not seem possible to build the modern bundle without also building the legacy bundle, which means that we aren't able to build the legacy bundle, then separately build the modern bundle.
Note that we do want to reduce our bundle size (see #232). However, we think that that is an unrelated issue.
For now, we will build Frontend without using modern mode: we will build only the legacy bundle. From a quick look, our modern bundle seems to be about 9% smaller than our legacy bundle. According to the Vue CLI documentation, the code in the legacy bundle may also run more slowly compared to the modern bundle, though I'm not sure by how much.

After upgrading to Vue CLI v5 (#669), I see the following message when I run npm run build:

All browser targets in the browserslist configuration have supported ES module.
Therefore we don't build two separate bundles for differential loading.

This is mentioned in the Vue CLI docs here:

Starting with v5.0.0-beta.0, running vue-cli-service build will automatically generate different bundles based on your browserslist configurations. The --modern flag is no longer needed because it is turned on by default.

In other words, previously we built just a legacy bundle, and now we're building just a modern bundle. I think that's a sensible change, and we haven't run into any issues during regression testing. Previously, we wanted to build both legacy and modern bundles, but opted just for legacy. Now I think it's safe to be building just a modern bundle.
I'm going to go ahead and close this issue, because we're now building a modern bundle without the memory overhead of a second process. We're also planning to move to Vite (#671), so we probably wouldn't want to invest in changes to our webpack configuration anyway. Also, end users won't be affected by memory usage if we prebuild Frontend, which we're considering as part of getodk/central#347.


Replace | with Union until 3.9 no longer supported

What's the new feature?
Python 3.10 introduced the shorthand X | Y to replace Union[X, Y], until we stop supporting 3.9. we should use Union.
What value does this add?
to use | in versions less than 3.10 we have to use from __future__ import annotations, but all this does is rewrite every type hint like str | int to the string "str  | int". This has some issues, see https://stackoverflow.com/questions/66734640/any-downsides-to-using-from-future-import-annotations-everywhere. By explicitly using the "old" Union syntax we avoid this problem.
Is there an alternative you've considered?
No response
Additional context
No response

An alternative is to manually insert quotes around annotations where required. I don't care enough to specify one approach or the other. If going for Union, do make use of Optional too.
I agree dropping from __future__ import annotations is a very good idea. See #366, #378 and #515, which will all need updating.
Note that there is a from __future__ import annotations in coreset.py, and I can't see why it's still required.


PBS torque class added

Adds a pbs_torque_sm class. Shell script acts as a wrapper to export required environment variables to pbsdsh spawns. Note mpiargs is provided and is intended to be invoked by the solver.base.mpirun routine. Calls MPI code as an MPI singleton due to pbsdsh limitations.

Very useful, thanks!


[WiP] Git: Add events to API

Implements #73617
Outstanding Work

[ ] Adding test cases

@joaomoreno I am looking for some early feedback on the approach :)

It would be awesome if we could distinguish between events. Dot you think that this could be added at the dotgit watcher level?

@davinci26 The git extension has its own API, which extensions can just use without any changes in the core. More details: https://github.com/microsoft/vscode/issues/67276
As to the filtering, no I don't think that should be a part of the API. The consumer decides on the filtering.

@joaomoreno thanks for the feedback and the pointers


Sample app: edit existing contact

Edit contact screen should include;

[x] Contact starred (editable)
[x] Contact send to voicemail (editable)
[x] Contact ringtone (editable)
[x] Contact photo (editable)
[x] Contact name primary (not-editable)
[x] Contact name alt (not-editable)
[x] Contact last updated (not-editable)
[x] RawContact photo (editable)
[x] RawContact account (not-editable)
[x] RawContact name (editable)
[x] RawContact nickname (editable)
[x] RawContact organization (editable)
[x] RawContact phones (editable)
[x] RawContact SIP address (editable)
[x] RawContact emails (editable)
[x] RawContact addresses (editable)
[x] RawContact IM (editable)
[x] RawContact websites (editable)
[x] RawContact events (editable) (invisible if no account)
[x] RawContact relations (editable) (invisible if no account)
[x] RawContact note (editable)
[x] RawContact group memberships (editable) (invisible if no account)

All of the work has been committed into the main branch!


Feature/android localized labels

Added supporting of localized labels for Android side

I'm sorry for the delay.  I lost two very special people in my life.  One a couple of months ago, the other two days ago.  I'm back and will work on your PR over the weekend.  Thanks for your patience and understanding.

Thanks for contributing!


Remove msiexec dependency by adding using vcpkg.exe to unpack 7z.exe

Alternative to https://github.com/microsoft/vcpkg/pull/41042

DO NOT MERGE: This PR depends on a tool release


AppIcons (small, large and source file)

Added small AppIcon with parallax effect
Added large AppIcon with parallax effect
Added original .sketch file with both icon sources

@crxdelsol @FrnklyN, @jordibruin, and @matthijst, thanks for taking the time to create an App Icon! @basvroegop and @rmens, thanks for getting the ball rolling on this, much appreciated.
@rmens, since you have such a nicely filled up Apple TV home screen, could you install the current version of the app on your device and create a screenshot with the app's icon in the middle to put in the screenshots directory and the README?

Screenshot, as requested via Twitter:
http://imgur.com/bbRfZfx

@basvroegop The orange looks a bit cheap. Maybe a little gradient can change that.

Not my logo, just provided the screenshot. Other people @jeffkreeftmeijer mentioned made it.

@basvroegop I know, but what is your opinion on that?

@FrnklyN Color is a bit lighter than the original NPO logo. http://www-assets.npo.nl/assets/npo_logo-c0f9cdc10f5633cc362e5b8113a3350e.png
But tbh, I prefer the lighter one myself.

@FrnklyN  as this pull request is already merged, could you create a new issue (or send a new pull request) to discuss this?


Allow apps to delay/sleep

That's likely not too easy to accomplish.

We cannot really pass delay down to the client
Busy wait using the monotonic timer is also likely not feasible
Should there be an API call: WaitFor ?

This is currently needed by the secrets-app to rate-limit the reverse-hotp answers.

Having a "sleep" syscall would mean also blocking all other apps from making any form of progress since they run in the same task. Maybe just have a way to get the time, and then the app can keep the time of the latest attempt, compare it to the current time, and if the difference is below a threshold reject the request?

Maybe just have a way to get the time, and then the app can keep the time of the latest attempt, compare it to the current time, and if the difference is below a threshold reject the request?

This would work for my use case.
It sounds weird that RTIC does not support yielding. Are you sure?

By nature of being a priority based real-time scheduler, RTIC does not have a way to yield and then resume a task outside of starting another higher-priority task, or completing the task and restarting it from the beginning. That's why V2 wants async, so that you can have that type of yielding.

There already is ManagementClient::uptime.

Ok ok, perfectly fine.
So then close this issue and anyone who would like to wait should do a busy-wait based on ManagementClient::uptime ?

Closing this as there is nothing to be done inside the firmware, a client/app should use uptime to realize time dependent reactions


1.22 crash on cache clear in symfony 4.4

PHP version: 7.4.14
Description
The new version of the bundle crashes symfony on cache clear.
How to reproduce
Pull symfony 4.4 and install the bundle.
Additional context
Error stack
In Alias.php line 107:

  [Symfony\Component\DependencyInjection\Exception\InvalidArgumentException]
  The deprecation template must contain the "%alias_id%" placeholder.

Exception trace:
  at /var/www/vendor/symfony/dependency-injection/Alias.php:107
 Symfony\Component\DependencyInjection\Alias->setDeprecated() at /var/www/vendor/php-http/httplug-bundle/src/DependencyInjection/HttplugExtension.php:390
 Http\HttplugBundle\DependencyInjection\HttplugExtension->configureClient() at /var/www/vendor/php-http/httplug-bundle/src/DependencyInjection/HttplugExtension.php:135
 Http\HttplugBundle\DependencyInjection\HttplugExtension->configureClients() at /var/www/vendor/php-http/httplug-bundle/src/DependencyInjection/HttplugExtension.php:103
 Http\HttplugBundle\DependencyInjection\HttplugExtension->load() at /var/www/vendor/symfony/dependency-injection/Compiler/MergeExtensionConfigurationPass.php:76
 Symfony\Component\DependencyInjection\Compiler\MergeExtensionConfigurationPass->process() at /var/www/vendor/symfony/http-kernel/DependencyInjection/MergeExtensionConfigurationPass.php:39
 Symfony\Component\HttpKernel\DependencyInjection\MergeExtensionConfigurationPass->process() at /var/www/vendor/symfony/dependency-injection/Compiler/Compiler.php:94
 Symfony\Component\DependencyInjection\Compiler\Compiler->compile() at /var/www/vendor/symfony/dependency-injection/ContainerBuilder.php:762
 Symfony\Component\DependencyInjection\ContainerBuilder->compile() at /var/www/vendor/symfony/http-kernel/Kernel.php:596
 Symfony\Component\HttpKernel\Kernel->initializeContainer() at /var/www/vendor/symfony/http-kernel/Kernel.php:136
 Symfony\Component\HttpKernel\Kernel->boot() at /var/www/src/Kernel.php:158
 App\Kernel->boot() at /var/www/vendor/symfony/framework-bundle/Console/Application.php:169
 Symfony\Bundle\FrameworkBundle\Console\Application->registerCommands() at /var/www/vendor/symfony/framework-bundle/Console/Application.php:75
 Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at /var/www/vendor/symfony/console/Application.php:149
 Symfony\Component\Console\Application->run() at /var/www/bin/console:42

hi, thanks for reporting this. yeah, turns out deprecation changed in different symfony versions. we removed the service deprecation in 1.22.1, see #396
i just released version 1.22.1 which should get rid of the error.


Fixed typo in readme

I found a typo in the readme. It said inclement instead of increment and also I am pretty sure it is supposed to be appState.count and not appState.apple.count, so I fixed that as well.

I fixed some more grammatical errors.
I fixed the typos in: There is no spefial things against generally kind of useCotecxt() hook based grrobal store.
to be:
There is no special things against generally kind of useContext() hook based global store.
Even though the typos are fixed, that does not make sense to me as a sentence unfortunately. Could you explain to me what you mean by this?
BTW I love your project that is why I am interested in fixing typos/grammar and maybe even contributing code when I learn more about this project specifically.

@nake89 Thank you for your contribution!

Even though the typos are fixed, that does not make sense to me as a sentence unfortunately. Could you explain to me what you mean by this?

This mean, using useContext()as a global state like alternative Redux, MobX is really common pattern in the React world.
For example, you can get bunch of article that about useContext() as a global state with Google with useContext global state words.
Therefore no highly performance optimization, no advanced implementation techniques in it, I'd liked to say.
Should I update the sentence for don't make confusing? 🤔


GuestAgentSnapshotTaskStatusError

I have found that in my case I hadn't whitelisted in AppLocker the executable in c:\Packages that runs when the snapshot is triggered. It will generate the GuestAgentSnapshotTaskStatusError

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2d3159e0-fb4e-ac85-e88d-f085ac54a13f
Version Independent ID: 1046a441-8210-84a9-2305-7d8b2570c376
Content: Troubleshoot Agent and extension issues - Azure Backup
Content Source: articles/backup/backup-azure-troubleshoot-vm-backup-fails-snapshot-timeout.md
Service: backup
GitHub Login: @dcurwin
Microsoft Alias: dacurwin

@oobedan Thanks for your comment. We will review your issue and get back to you.

@oobedan Could you please elaborate the issue and provide more details how it is impacting your Azure VM backup?

@SadiqhAhmed-MSFT  if your applocker rules (or other 3rd party whitelisting/appcontrol solution) is based on publisher or path based, they will block the IaaSBcdrExtension.exe executable from running.

@oobedan Would it be possible for you to add the extension in the exclusion list?

@SadiqhAhmed-MSFT of course. I was mentioning as it may be helpful to others if you want to update the troubleshooting guide.

@oobedan Thanks for sharing your valuable feedback. We will have this reviewed by our experts and update the document as needed.
@dcurwin FYI, please review this request and do the needful.

Thank you for your comment. The document has been updated.
#please-close


Pass more context to collision detection algorithms

Whilst it feels purer to have collision detection abstracted away into considering just layouts, it also creates some awkwardness for more advanced situations. For example, a collision algorithm might want to tie-break overlapping hits by the 'type' of droppable.
Consider just passing the list of droppables and the active draggable directly.

This is now done in 0.5.0 🎉
Note this is a breaking change because the API for collision detection has changed, as well as the naming convention for collision detectors.


Issue

Hi Ben, adding the log, I don't know how explain the issue

Which version of ewelink plugin are you using?

Reviewing your logs again, it seems that HOOBS is trying to load the plugin twice. Could it be that you somehow have the two different versions of the plugin installed?

Reviewing your logs again, it seems that HOOBS is trying to load the plugin twice. Could it be that you somehow have the two different versions of the plugin installed?

I come back to hoobs factory reset, was a very disaster yesterday. How can I Really clean up ? I canceled the plug-in but the icons remaining inside hk

I come back to hoobs factory reset, was a very disaster yesterday. How can I Really clean up ? I canceled the plug-in but the icons remaining inside hk

You'll have to contact HOOBS support for this. If the icons are still in home app after a factory reset then it seems like a cache issue. I'm not an expert on how HOOBS works so you'll have to get in touch with them :)

I come back to hoobs factory reset, was a very disaster yesterday. How can I Really clean up ? I canceled the plug-in but the icons remaining inside hk

You'll have to contact HOOBS support for this. If the icons are still in home app after a factory reset then it seems like a cache issue. I'm not an expert on how HOOBS works so you'll have to get in touch with them :)

What do you think about nose version? On log is reported that the plug-in request 12.19

This just a warning not an error. it has no effect on the plugin

This just a warning not an error. it has no effect on the plugin

I come back to factory status again, do you know on terminal how clear the cache of the raspberry? Hoobs would be a normal raspberry

A quick google brings up this:
https://www.reddit.com/r/HOOBS/comments/emzhdx/how_do_i_clear_cache_in_the_new_hoobs/
Perhaps this would work?

Did you get this working?

Did you get this working?

Yes we can close the issue

Fab. Glad it's working :)


Issue with ICOS retrieval tests taking a long time

So sometimes the tests are taking a long time and are getting killed at the 6 hour mark by GitHub.
They get killed as they way for a test in  test_retrieve_icos.py.

We added a timeout for the tests. All ICOS tests are now only run by passing the --run-icos argument to pytest. See #868 .


Fix client example in README

There were the following issues with your Pull Request

Commit: fac65ff094f097a4c3cbbc7b226857dd1717ee0b
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com


Added testProfile to describe version of solidity

Proposed changes
This PR introduces testProfile.json file to describe version of solidity.
If there is another idea with file name, please tell me :)
Types of changes
Please put an x in the boxes related to your change.

[ ] Bugfix
[x] New feature or enhancement
[ ] Others

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING GUIDELINES doc
[x] I have signed the CLA
[ ] Lint and unit tests pass locally with my changes ($ make test)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Related issues

Please leave the issue numbers or links related to this PR here.

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@nogang testProfile.json file is added :)

What about adding it into https://github.com/klaytn/klaytn-integration-tests/blob/master/env.template.json?

What about adding it into https://github.com/klaytn/klaytn-integration-tests/blob/master/env.template.json?

Initially the solidity version was described in env.template.json though, now that is described in seperate file.
Because the env.template.json file is a template that allows user to set the values user use and the solidity version is not a value that user can set, but an environment(?) that should be used according to TC.
cc @nogang

@jimni1222 Ok. I got it.
Then, please change the file name. conf.json? test.json? package.json?

@kjhman21 @nogang
The file name is edited to "conf.json" :)

@nogang Please share your opinion.

It seems to be appropriate to configure.@kjhman21 @jimni1222


Create a new urp project to form another scene, and even if you put urpassets, the image does not come out.

Create a new urp project to form another scene, and even if you put urpassets, the image does not come out.

how about unity 2021.3.15f?

Could you describe what you're trying to do? It sounds like you're creating an empty URP project, and it's irrelevant to this project (NNCam).

무엇을 하려는지 설명해 주시겠습니까? 빈 URP 프로젝트를 생성하는 것처럼 들리며 이 프로젝트(NNCam)와 관련이 없습니다.

I want to create an empty urp project to get rid of the background of real space and image it with a camera in a webcam or Android/ios application.

Two points:

This repository is dedicated to show how to use BodyPix in the built-in render pipeline. URP is out of the scope.
For human stencil acquisition, AR Foundation is a better solution in several points. I wouldn't recommend using this project for your purpose.

<EMAIL_ADDRESS>

I close this issue as answered. Please reopen it for further problems.


add asdf support to python + poetry

Feature request
The idea here is to support asdf/.tool-versions for specifying python + poetry versions. This could then
be extended to support node, go, etc in the future but my initial use case is scoped to python.
Motivation
No response
Contribution
https://github.com/railwayapp/nixpacks/pull/1026

@iloveitaly sorry about the delays--I'm looking into this...

folks seem to like this proposal. Are you interested in finishing your PR? It looks like it's not quite done...

@iloveitaly also check this out:
https://github.com/railwayapp/nixpacks/issues/1017#issuecomment-1839761192
maybe worth hopping on that thread?

Hi @iloveitaly,
I think having a full on asdf provider could be a good idea. Basically if .tool-versions file is found at the root, then we install asdf and all packages defined. Would you be interested in creating a PR for this?
The problem with https://github.com/railwayapp/nixpacks/pull/1026 is that Nix does not support specifying the exact version of packages. It only supports the latest major/minor version. So parsing a tool-version file and then passing the version to Nix does not make a lot of sense in that case.

@coffee-cup That makes sense—What do you think about just extracting the major/minor version from asdf and passing that down to the Python builder?

That works as a good first step!


Modularizing the Pipeline

I think the design of this pipeline could be more modularized by utilizing the argparse's subcommand. Through the use of this functionality, the amount of code needed could drop drastically. Ideally, my vision is to have one main file like command_wrapper.py that will handle the entire running of the pipeline. i.e. calling multiple subprocess/system calls in the desired order to guarantee everything runs smoothly. An example of what I mean is provided below:
Current Method:
This following command has to be manually inserted to run the fastqc program:

#FastQC
python scripts/1.run_fastqc.py --command 'fastqc'
--data_dir 'data' --output_dir 'results/fastqc_raw'
--walltime '01:30:00' --nodes 1 --cores 4

Next in order to run the multiqc command this has to be manually inputed:

multiqc results/fastqc_raw/
--force --filename 'results/multiqc_report_raw.html'

Proposed Method:
The new approach I suggest is to combine the above lines into the python file as a subcommand (quality_control). Now all one has to do is call the program:

python command_wrapper.py quality_control <insert desired args here>

Within the new command_wrapper.py will be:

< code to process the arguements> ..
subprocess1.call(FASTQC command)
subprocess2.call(MULTIQC command)

Through this new method one would just submit a job with the command_wrapper.py script and the correct number of arguments and let python handle the heavy work of calling jobs etc. I'm not sure dartmouth's cluster policy on system commands, but I'd be surprised to see if there is an issue about this. Caution: if we move forward with this new design the command line arguments could increase to an undesired level, so with a little brainstorming I'm sure this plausible issue won't arise.

Thanks for the comments @danich1 - I was not aware of subcommand before, and I am not sure if I understand its best use case completely. My apologies if I'm not exactly following, but I am not sure that this specific workflow will work given each commands requirements.
Specifically, the # FastQC step written on lines 15-17 of wes_pipeline.sh acts on each of 120 samples independently. Essentially, the script runs fastqc on all raw input files. Alternatively, the MultiQC step runs on all samples in a given directory.
Actually, maybe subcommands would work here. The FastQC script would remain more-or-less as is, but I would create a MultiQC subcommand that would take in a different input. Does this make sense?

I am brainstorming other ways on cutting down on redundancy in this pipeline as well.
Maybe we can chat next to a whiteboard briefly today?

Yeah sounds good to me. I'm free anytime before 12pm or after 1pm. Just let me know.

@danich1 and I brainstormed pipeline solutions :point_up_2:

We determined that the best way forward at the moment would be to migrate functionality of the individual Scripts shown above into the command_wrapper utility using argparse subcommands. The argparse subcommands will live in a different python script that is sourced into command wrapper to reduce file complexity.
We also discussed potentially writing a script that generates a bash script for each step of the pipeline for each individual sample. The upside would be less manual feeding of commands to the cluster, but the downside would be difficulty in stopping the pipeline for viewing results of intermediate files. While this upside is clear for this project, a new project will require intermediate file viewing.
For now, I will implement the first command_wrapper option and shelf this other idea for a later date.

Hi @danich1 - I've updated the command_wrapper script how we previously discussed. The most recent update is here.
I will also add this update to the pull request discussion


Improve GIF generation script

improve GIF generation script as discussed

https://github.com/ADS-Testing/ADFuzz/commit/43c442da02f07cd59a5b2caa7178e6539a19f922

@nkwook https://github.com/ADS-Testing/openpilot/blob/main/tools/sim/op_script/extract_gif.py 파일과는 어떤 관계인건가요?


fix: bumped versions

#203  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bob-obringer and the rest of your teammates on  Graphite


Provide script to purge soft-deleted resources

Is your feature request related to a problem? Please describe.
Currently one cannot purge soft-deleted services via PowerShell, this has to be done via a DELETE operation.
By providing this PS-functionality, one doesn't have to use a tool or script to build the proper request before being able to purge the service.
Describe the solution you'd like
Suggested method:
Remove-AzSoftDeletedService
Parameters:

SubscriptionId:
The Id of the subscription in which the soft-deleted service exists.
ServiceType:
The type of service which is to be purged.
For example: Microsoft.ApiManagement
Location:
The region where the soft-deleted service was created.
For example: WestEurope
ServiceName:
The name of the service which is to be purged.
For example: arcus-dev-we-gateway

Describe alternatives you've considered
The alternative would be to use a tool, such as PostMan, to create the DELETE-request to purge the service.
Additional context
See Microsoft documentation on how to purge a soft-deleted APIM-instance for example: here
The same could be created to recover soft-deleted services:

Restore-AzSoftDeletedService

Or to list the soft-deleted services:

Get-AzSoftDeletedServices

Open to suggestions as to which "domain" this should belong to.

Maybe this belongs in a 'general' domain like we have one for security and devops.

Maybe this belongs in a 'general' domain like we have one for security and devops. But great idea!
I was thinking of Arcus.Scripting but that's maybe to general and people won't know directly what's about. Maybe under something called 'management' or 'resource management'.

I like the idea about Arcus.Scripting.Management :)

@mbraekman what resources are you thinking of to support in this script? Initially just APIM or others as well?

@pim-simons I'd start with APIM and perhaps all of those resource types which are currently supported by 1 or another script within Arcus.
Could easily be extended later on of course.

Did a small inventorisation of the resource types we support within Arcus and whether or not they support soft-delete and the current scripting support for purging and recovering.

App Service - Soft-delete not available
Data Factory - Soft-delete not available
Integration Account - Soft-delete not available
KeyVault - Supports soft-delete but there are already Powershell commands available to purge and restore, see https://docs.microsoft.com/en-us/azure/key-vault/general/key-vault-recovery?tabs=azure-powershell#key-vault-powershell
Logic Apps - Soft-delete not available
SQL - There seems to be some support in the form of Azure Backup, see https://docs.microsoft.com/en-us/azure/backup/soft-delete-sql-saphana-in-azure-vm. There are already Powershell commands available, see https://docs.microsoft.com/en-us/azure/backup/backup-azure-security-feature-cloud#using-azure-powershell.
Storage Account - Support for soft deleting blobs and containers, already seems to be Powershell commands available for blobs, see https://docs.microsoft.com/en-us/azure/storage/blobs/soft-delete-blob-manage?tabs=dotnet#restore-soft-deleted-blobs-and-directories-by-using-powershell.

I don't see that much resources we can support next to API Management, but maybe I overlooked something and if so please correct me 😉 @mbraekman maybe you have some more insight or ideas about this?

Regarding the naming of the scripts, suggested is Restore-AzSoftDeletedService, Get-AzSoftDeletedServices and Remove-AzSoftDeletedService.
That would mean that if we support multiple resources that could possibly make the script quite large since not every resource has to use the same functionality for purge and recovery. API Management uses this HTTP call to purge: https://management.azure.com/subscriptions/{subscriptionId}/providers/Microsoft.ApiManagement/locations/{location}/deletedservices/{serviceName}?api-version=2020-06-01-preview, but I can't really find any other resource that uses the same kind of HTTP call (but again maybe I am overlooking something).
Maybe in that case it would make more sense to have specific Powershell scripts per resource within the Arcus.Scripting.Management domain like so Restore-AzSoftDeletedService-ApiManagement, Get-AzSoftDeletedServices-ApiManagement and Remove-AzSoftDeletedService-ApiManagement.
Any thoughts on that @mbraekman?

Aha, ok, that needs to checked indeed. maybe we should indeed split it by resource, then. Maybe also cleaner for consumers, that way. Otherwise, you can't see what kind of resource is being changed.
Naming afterwards can be discussed. Our current functions all use this Azure pattern: Something-AzResourceType..., so maybe this should be Restore-AzApiManagementSoftDeletedService. But, again, that's future music 😉 .
AMAZING, job, @pim-simons , in investigating this. Probably a bunch of work. 🥇

Restore-AzApiManagementSoftDeletedService and Remove-AzApiManagementSoftDeletedService within Arcus.Scripting.Management seems like a good naming solution 😎


Bug in method removeMarkers with square in Chessboard.js

Missing to update the location change from "squareToIndex" method to Position.
Position.squareToIndex(square)
instead of
this.state.squareToIndex(square)

Thanks for reporting, is fixed in v 4.1.10


Add Active-Active database methods and structs to their own files

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[CAM-10382] Conditional ProcessEngine(Configuration)

When you want to create your own ProcessEngineConfiguration and ProcessEngine (because of multi-tenant reasons), both beans need to be conditional.
This Pull Request makes the ProcessEngineFactoryBean conditional when there is not yet a ProcessEngine bean.
This PR will not resolve CAM-10334 completely, but makes it possible to configure your own ProcessEngine and ProcessEngineConfiguration.

I would like this to be a fix on 2.3..x
Do we need an additional pull request to make this happen?

@yanavasileva Maybe you would know if this pull request is according the guidelines?

Hi @hetzijzo,
could you please elaborate a bit more on your use case? What is the advantage of creating a ProcessEngine bean?
Cheers,
Tassilo

I am building a multi-tenant environment with a DataSource and ProcessEngine per tenant. Since the camunda-bpm-spring-boot-starter already defines a ProcessEngine (through it's own factory), I am not able to define my own.

Everything in the starter (configuration, application, engine, web, rest ...) is currently build to easily support setting up a spring boot app with camunda, following the starter pattern (just put the lib on the classpath and start).
Starters are generally opinionated, so they are based on some assumptions regarding use case/setup and to fully benefit from the starter, you should meet this assumptions.
In your case, it seems as you can not live with the assumption "the starter will configure and run a single process engine for you". I get your use case and it is valid.  But I wonder why you want to continue using the starter?
You can just run a custom spring boot application, configure your engines and run it ... you should be able to use the camunda-spring lib (part of the platform, not the starter) to make your life easier.
I don't have any proof so far, just a guts feelings: if we allow multiple engines in the starter, a lot of the automated stuff in the background (register application for web forms and deployment awareness, default engine, auto wiring of services, ...) might not work as expected ...
Without further testing and discussion, for now I would define this feature as "out of scope" and would vote against it.

Hi @hetzijzo,
I'm pretty much on the same page like Jan. What do you think about directly using the Camunda Spring Lib and build a custom Spring Boot Application that perfectly fulfils your needs?
Cheers,
Tassilo

Hi @hetzijzo,
we have discussed your use case internally and decided not to merge it with the code base.
Currently multiple process engines is not in the scope of Camunda Spring Boot Starter.
If anything remained unclear or you need some more clarification, please do not hesitate to comment in this ticket.
Cheers,
Tassilo

Thanks for your reply. I eventually solved it by not using the Camunda Spring Boot Starter, but configuring the required beans myself.

Hi when will the multi tenancy be supported for spring boot?


%td_tables is slow

Since this command fetches all databases and tables, it can be slow even if a database name is given.

Correction - the given argument is NOT a database name, and it's a regexp for table name:
%td_tables [table_pattern]

The code searches all table names that match to the pattern across all DBs.
If we need to improve its efficiency by focusing on a specific DB name, it should be a new function as:
%td_tables [db_name] [pattern]


Site: Feedbacks for Color page

@saadmhybris

[ ] 1. Side margin of the body
[ ] 2. Weight and color of the title
[ ] 3. The intro text takes only 6 col
[ ] 4. Color blocks: margin between the subtitle to the block
[ ] 5. Color blocks: size of the block and text spacing in the block
[ ] 6. Color blocks: Vertical spacing between blocks
[ ] 7. Accessibility: Subtitle, weight and color
[ ] 8. Accessibility: The whole section is 6 col
[ ] 9. Accessibility: there’s a link in the intro text “WCAG AA standards”
[ ] 10. Accessibility: Spacing between intro text and subtitle
[ ] 11. Accessibility: spacing between subtitle and text block
[ ] 12. Accessibility: spacing between text block and next subtitle
[ ] 13. Accessibility: spacing between last text block and the footer
[ ] 14. Footer: “Have a question…GitHub.” should be in one line
[ ] 15. Footer: The link color is purple

moved this issue to fundamental repo - https://github.com/SAP/fundamental/issues/47


Travis

Issue:

[X] Tick here to confirm that you have run RunCodeFormatter.ps1

Description:
This PR adds Travis CI builds alongside the appveyor builds.
Test:
Check that Travis CI has performed a (successful) build on the PR :-)


feat:Add dbgpts hub  module

Description
Added community dbgpts management module, you can see the open source workflow, Agent, operator, resources, applications, etc. in the open source community dbgpts.
How Has This Been Tested?
Snapshots:

Checklist:

[x] My code follows the style guidelines of this project
[x] I have already rebased the commits and make the commit message conform to the project standard.
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] Any dependent changes have been merged and published in downstream modules

The address of backend is wrong, please rebuild static files.

Resolved


Do we still need to include extra .stylx files for MSE at Pro 2.0

From @dfoll on June 21, 2017 18:8
check to see if the additional .stylx files are still needed for MSE with Pro 2.0, update (remove that section) if they are not needed
Copied from original issue: lfunkhouser/mta-progress#1

From @dfoll on June 21, 2017 18:9
C:\Program Files\ArcGIS\Pro\Resources\Dictionaries

From @dfoll on June 21, 2017 21:7
the answer is no, i will make the appropriate changes to do (removing those topics from the maps)


Calling checkboxPrompt(...) from inline script results in the top-most toggle hiding the X button

Describe the bug
When calling this.quickAddApi.checkboxPrompt(<prompt description>);  the GUI doesn't look good:
To Reproduce

Create new capture.
Select capture to active file.
Select write to bottom of file.
Enable capture format.
Insert either of the following scripts then execute it:

    // Option #1
    const options = ["Priority", "Due Date", "Scheduled Date", "Start Date", "Recurrence"];
    const selectedOptions = await this.quickAddApi.checkboxPrompt(options, []);

    // Option #2
    const options = ["", "Priority", "Due Date", "Scheduled Date", "Start Date", "Recurrence"];
    const selectedOptions = await this.quickAddApi.checkboxPrompt(options, []);

Expected behavior
To see the X button.
Screenshots

Desktop (please complete the following information):

OS: Windows (don't know if on Android it is also hidden but it look ok)

Hi @JulianBroudy
Thank you for reporting this! This is what happens when I do styling with a theme on lol.
Should be fixed in the latest release.


Issue/6409 improve language reference documentation (#6457)

Pull request opened by the merge tool on behalf of #6457

Merged into branches iso6 in 2692fb448ca54466345ee0652608100376a43136


Revert "Change Tetris Colors"

Left reviews and line comments
Created a file and made a commit
Opened a pull request
I have completed a whole lot of stuff as can be seen above. so approve of it and let me move ahead please. Thank you.

Good

This is a comment


s3 source PutObject method seems to be broken?

Hi Danny 👋  -- hope you're well!
I tried to specify a metalink-repository-resource w/ Concourse that had a configuration something like this:
- name: some-metalinks-and-files
    source:
      mirror_files:
        - destination: s3://s3.amazonaws.com/some-bucket/{{.Version}}/{{.Name}}
      options:
        access_key: ((some_aws.username))
        secret_key: ((some_aws.password))
      uri: s3://s3.amazonaws.com/some-bucket/
      url_handlers:
        - include:
            - (s3|https)://.*
          options:
            access_key: ((some_aws.username))
            secret_key: ((some_aws.password))
          type: s3
    type: metalink-repository

This correctly mirrors files to S3 and writes a meta4 file BUT the meta4 file is 0 bytes (which causes the subsequent GET to fail with a in: bad repository: load: Unmarshaling: Unmarshaling XML: EOF error.)
When I configure this resource to store the metalink files in a github repo, everything works as expected.
After digging into why this is happening, I think this line in repository/s3/source.go is the culprit.
It calls PutObject on the client, which is presumedly the minio-go S3 Sdk:
s.client.PutObject(s.bucket, path.Join(s.prefix, name), data, 0, minio.PutObjectOptions{ContentType: "application/octet-stream"})
It specifies 0 for the filesize -- maybe the intent is to say "unknown size"? According to the docs, -1 should be used to specify an unknown size (they also warn that it will consume a lot of memory). Elsewhere it looks like an explicit size is passed when mirroring files (which upload successfully). I don't know enough about go to know if this is also possible with whatever type of thing is being passed to the repo PutObject method, but I would hope it would be possible?
Anyways, it sounds like I'm the only person who's ever tried to do this (at least that is what Palermo said 😉 ). Why am I doing this? It feels kind of "wasteful" to spin up a whole repo to store metalink files when I don't really need 'em. That said, for now I'll probably workaround by using a repo, but ... if it's an easy fix, that'd be cool! If not, maybe when I get a chance I will try my hand at a PR.

Hi Rajan - a nice surprise to see your name in my inbox! I agree it's a bug if it's writing empty files to s3, and the 0 length instead of -1 that you found does sound suspicious. I do tend to favor separating the concerns of storage with s3 and receipts/lifecycle with git or local, so maybe not surprising there's a long-standing bug with s3 as a repository.
Your comment about "metalink files when I don't really need 'em" does make me wonder if it's necessary to use metalink for your use case though. For example, if you're just looking to mirror files to a bucket and aren't concerned about tracking their checksums/locations/metalink, maybe a plain task running aws s3 mirror or regular s3 resource type would be a smaller solution?
Whatever the case, I would be happy to merge a pull request with a fix for this, or to add a collaborator to the repositories if that's easier. I'm not actively using this setup these days, so I'm not particularly motivated to dig into it myself.
Happy to answer any questions or discuss further.

Hi Danny! Thanks for the response and subsequent fix! I'm not sure how I missed it originally.
You're right in that it's turning out metalinks wound up not being a great fit for my use case. Originally they were kind of convenient for me to use to pass resources around and as triggers for subsequent jobs, but as the triggering logic grew in complexity, it has become apparent that it would have been better for me to use something else as a trigger/version reference and just use some kind of simple blob storage with structured/versioned filenames to do retrieval. 🤷 oh well.


electron-prebuilt postinstall script not finishing

It seems the postinstall script of electron-prebuilt sometimes fails to complete, resulting in a missing configuration file.
> devtool

  fs.js:549
    return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                   ^

  Error: ENOENT: no such file or directory, open '/Users/aleclarson/devtool/node_modules/electron-prebuilt/path.txt'
    at Error (native)
    at Object.fs.openSync (fs.js:549:18)
    at Object.fs.readFileSync (fs.js:397:15)
    at Object.<anonymous> (/Users/aleclarson/devtool/node_modules/electron-prebuilt/index.js:4:42)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)

You can get around this using:
cd $HOME/devtool/node_modules/electron-prebuilt
sudo node install.js

Is there something that can be done to automate this?
Or is this issue the responsibility of electron-prebuilt contributors?

Do you have the error logs from when the install failed? Does it happen every time you npm install devtool -g? I haven't seen this and I'm not able to reproduce it.
If it persists with the latest version of devtool, try posting a new issue in electron-prebuilt.


Declare logFlags constants as... const!

Declare constants for SetLogFlag as const.

 You should sign our Contributor License Agreement in order to get your pull request merged.

Merged in 133ce31 thanks.


Add Norwegian benchmark datasets

The datasets listed at https://github.com/ltgoslo/norbench could be used.
Further, the UniversalDependencies repo has dependency parsing for Norwegian.

These have now been added.


[request]: New Service Support: Amazon Cognito

For us it would be great to have especially client for Cognito Identity Provider for user management in Cognito UserPool.
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue, please leave a comment

note that this won't be directly usable as a credential provider yet, but you'll be able to use the API directly


MTY_Archive module

This PR adds a module in charge of manipulating archive files. It currently only supports extraction of ZIP archive. Since miniz is used under the hood, this library has been updated to the upstream version, with additional modifications listed between the lines 115 -> 126 of deps/miniz.h.
Reason: with the MTY_Webview module coming, it will be convenient to download or read a single bundle file containing the whole web application, and extract it in memory.

Theorically useless for now, closing.


Two server , [A server running scrapy] and [B server running splash cluster (aquarium)] .   A sent request to B and can't get the response.

When I use single splash , It is working. But after I change splash-cluster(aqurium) , it is not working (response for long time and time out).
What I miss?

Try enabling DEBUG log level in Scrapy, it may give additional information.

I found the problem, after change haproxy verion in [docker-compose.yml] ,it working well.
change [image haproxy:1.7] to [image haporxy:1.6]


Fix #2320, reorganize headers

Checklist (Please check before submitting)

[x] I reviewed the Contributing Guide.
[x] I signed and emailed the appropriate Contributor License Agreement to<EMAIL_ADDRESS>and copied<EMAIL_ADDRESS>
Describe the contribution
Reorganizes all the headers in CFE to make them comply with the naming convention as described in the developers guide section 4.2.
Fixes #2320
Testing performed
Build and sanity check CFE in a variety of configurations
Expected behavior changes
Header files are split into smaller parts, more manageable.
Should be backward compatible...
System(s) tested on
Debian
Additional context
The smaller, more granular header files are not only easier to maintain (if maintained by hand) but also are more easily switched to a generated source.  It is important to compartmentalize the contents because "source switching" will not work if different types of definitions are mixed in the same header.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Notably -- with this change, the build system no longer requires the user to maintain a cloned-and-owned copy of the config files in their "defs" directory (e.g. mission_cfg, platform_cfg, etc).  The source selection is in place and it will use the supplied default version if no override is given.  However, if any override is already present, it will still be used (thus preserving existing configs)


Pretrained discriminator model

Thank you for the nice work.
I was wondering if you guys have and can share the pretrained discriminator pt file.
Thank you.

Hi @seokg!
I believe I still got it saved somewhere, which domain are you interested in?

I am looking for the weights of FFHQ discriminator.
Thanks for the fast reply.

Closing the issue :)


Retain original object name

Checks

[x] Debugging completed
[ ] Please debug me

Related Issue
This PR closes #203.

Codecov Report
Base: 92.86% // Head: 92.86% // No change to project coverage :thumbsup:

Coverage data is based on head (56dc052) compared to base (085a311).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   92.86%   92.86%
=======================================
  Files          68       68
  Lines        3043     3043
=======================================
  Hits         2826     2826
  Misses        217      217

Impacted Files
Coverage Δ

neclib/devices/selector.py
90.62% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


would like to add cpp solution for 4 sum Leetcode question.

please assign.

sure

can you please assigne to me

i can help finish it faster

good! but make sure to name your file with your github username as i have assigned it to @deep-poharkar also!

can u please aasign me this

@Vanshika2063  would like to work on some good level Binary Search question? Can you assign me the task?

can u please elaborate the question

@Vanshika2063 would like to work on some good level Binary Search question? Can you assign me the task?

sure!
attached your issues in your PR

can u please aasign me this

sure !
attached your issues in your PR


Contact

Hi, wondering if you have contact information so i could discuss this with you.  Thanks

Feel free to reach out to my Twitter @0x00Check


feat: refetch user opportunities data on incoming Tx

Description

Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #3262   👈

This comment was auto-generated by Graphite.

Opening for early review - note portfolio update on websocket messages is currently broken meaning LP balances won't update - @0xdef1cafe is going to author a fix for this


Consider adding oxide_todo to SeaORM showcase!

Hey @TheAwiteb, Thanks for adopting SeaORM!
It's our pleasure to see more inspirational projects were built on top of SeaORM :)
Let us know if you have any feature recommendation or feedback.
Some learning resources for you: Documentation, Tutorial, Cookbook, Q&A, Blog
Join our Discord server to chat with others in the SeaQL community!
Feel free to submit a PR to showcase your project, https://github.com/SeaQL/sea-orm/issues/403.

Hi @billy1624, thank you for your question and for your effort on this wonderful library.  My project is already within the community projects and I am really happy for that https://github.com/SeaQL/sea-orm/pull/1484

Thanks for the love and support!! @TheAwiteb


Support for TypedArrays (IE9)

https://github.com/zloirock/core-js#ecmascript-6-typed-arrays

Hi, thanks for raising this.  We love to see people wanting to extend the polyfill service to accommodate new features.  We don't keep feature request issues open without a PR, but we do provide feedback on how enthusiastic we are to adopt the suggested idea.  In this case, the feature you've suggested is very appealing to the core team, and we would be happy to receive a PR for it, and help you with reviews and testing, or with how to get started if you are a new contributor.
You can find out more about common contribution scenarios and how to make the perfect PR here:
https://polyfill.io/v2/docs/contributing/common-scenarios
If you need any further help before you submit your PR, feel free to reopen this issue!

Yea, want this also


Feature request: Cache refresh legality checker

Similar to NAPD check... Biggest issue is the ability to limit a single core  set.

To summarize the deck building rules:

MWL in effect
1 Core Set
1 Terminal Directive
1 Deluxe Expansion
Current cycle
Previous cycle

Fixed by https://github.com/Alsciende/netrunnerdb/pull/131


Rename jdbc minPoolSize to minIdle

So, minPoolSize is gone as a property. It needs to be mentioned in 7.9.1 release notes and migration path: rename ...minPoolSize to ...minIdle

Good point. For Narayana I removed it but it was a documented property.
For transactionmanager.jdbc.connection.minPoolSize it is somewhat different since it only existed so far in a number of hotfix / nightly builds.
I've now added back some defaults to the configuration so that the old property transactionmanager.narayana.jdbc.connection.minPoolSize will continue to work if configured.

Er gaat nog iets goed fout in de CI

Er gaat nog iets goed fout in de CI

Dat was 1 kleine vergissing in the AppConstants.properties waardoor 2 properties recursief naar elkaar verwezen 🙈