Strings in variables

enhancement:
Allowing strings to be stored in vars can, among other things, be used to increase randomness.
In my case it would allow me to simplify my custom monster from 112 activations to just 2.

Can you please explain how you want to use this?
I really don't want to do strings in variables due to issues with defining operations on strings and handling localisation, but there may be another way.

This specific instance I wan to fill in randomly "{c:Monster} moves 1/2/3 space/spaces toward the nearest/farthest investigator. Then it attacks the investigator in its space /(or an adjacent space) with the lowest/highest {strength}/{agility}/{observation}/{lore}/{influence}/{will}".
I get that this is more than a little redundant, and it isn't difficult to copy paste the activation events. I just feel like it is easier to modify in the future if it is done programatically.

Doing this also enables more flexibility in assigning damage for an attack. You could have ranges of damage (separate from negates) or changing requirements for ability checks for certain things. Again, all possible by copy paste (which is how I've done it so far) but more flexible/easy if I could just assign a variable.

For damage ranges you can do that now with {var:#rand3}.   Please provide some worked examples for other situations so I can develop a solution.

What about just calling a localization directly? in the form Variable.VariableName.Value."String"
Say, Var.MyVarMovement.1."String"

OK to break this down:

{c:Monster} moves 1/2/3 space/spaces

1/2/3 is simple with var.  Note that in general monsters have a fixed speed on only for special activations 'The monster has a burst of speed' does this vary.  I'm not sure how useful this is.

space/spaces

The plural is tricky, it would have to be separate entries for 1 space vs more than 1.  As above though I think changing speed to 1 will almost always be a special case.

toward the nearest/farthest investigator.

This is going to have significantly different sentence structure on languages changes, I think this would stay manual.  Note that towards farthest is probably also a special case, as the attack action would almost certain not be an investigator in it's space in this situation.

Then it attacks the investigator in its space /(or an adjacent space) with the lowest/highest

This has translation issues again.

{strength}/{agility}/{observation}/{lore}/{influence}/{will}".

This is the easy one.  You can reference other translations with parameters, so you can add TEST,"this tests {0}" to the localisation file and use "{qst:TEST:{will}}" to insert it.  Haven't tested this {0} notation in quest but it should work.  Note that in all of the standard activation there is some kind of flavour justification for the skill shown, it is never random, so again I am not sure that this is useful.

What about just calling a localization directly? in the form Variable.VariableName.Value."String"
Say, Var.MyVarMovement.1."String"

I didn't really understand this or the explanation, but you can reference other localization strings with {qst:}, and you can add extra keys, just edit the localization file.

I was unaware of the {qst:} function, is it possible to do that recursively? i.e something like {qst:CustomMonsterHound{var:#rand4}.monstername} to get the localization for a random Hounds name?

You can have one key reference another, and so on, but you can't have the key itself come from another element.

I am going to close this because at this stage I don't think the complication is justified.


Disallow superscripts on digit checks

isdigit() lets other things besides 0-9 to pass, for example ².
An alternative to the fixes here would be to use e.g. re.match(r"^[0-9]+$", ...), but that's slower.
With this change to parse_retry_after, a slight behavioral change is introduced: it starts to accept values surrounded by whitespace (not sure if they can end up here in usual use cases), and prefixed by + or -. Previously negative values raised InvalidHeader, now they get truncated to 0. Previously + prefixed values raised InvalidHeader, now they are accepted and the + ignored. If you feel these are issues that should be kept as they were, let me know and I'll adjust that change.

Regarding re.match being slower, that's quite probably a non-issue in these code spots, so if you prefer that approach instead, let me know and I'll adjust.

(Travis failure is not related to this change.)

Revised commit force-pushed with requested changes: added comment to parse_url, and requested behavior and tests for parse_retry_after

Split to two commits and added the requested note.


[ALLUXIO-3242] Fix read only mount

https://alluxio.atlassian.net/browse/ALLUXIO-3242

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20510/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20512/
Test PASSed.

Merged build finished. Test PASSed.

@bf8086 Did you have more comments?


bump kyverno to 0.17.5

This PR:

adds/changes/removes etc

Checklist

[x] Update changelog in CHANGELOG.md.
[x] Make sure values.yaml and values.schema.json are valid.

Done by renovate at #321


API: Return primary language and repository language stats API URL

Adds two new properties for Repository structure langauge and languages_url (named same as in GitHub API)
Fixes #18395

🚀


Fix NPE in readonly intersection

Purpose
Fixes #34833

@KavinduZoysa Lets change the base

Changes are moved to master via https://github.com/ballerina-platform/ballerina-lang/pull/35859  . All the suggestions are addressed there. Closing this PR.


add husky rules for pre-commit and pre-push

add linter run on pre-commit
and linter with test runs on pre-push

How about lint --fix
I always run --fix
Also it should not affect gh-pages branch.

I just did, as I saw.
As I know from big projects' repositories, it's used as warning for programmer, not as auto-formatter. (! as I know !).
Programmers rule the code. Instruments notice them.
For auto-format 'prettier' and similar with IDEs are used.
But there are no problem to implement --fix.
Maybe it's better.
One way or another, code will be modified for linter expectations .
If You, as repository owner, wanna try auto fix, why not?
Just choose red or blue pile )

Ok, let's have it like this


[add] ledger_app.toml C manifest

@xchapron-ledger I'm creating an issue on the workflow repo as I feel it's the more relevant place for such discussion.

@lpascal-ledger @xchapron-ledger I guess we either need to change the name of this manifest file or we need to update how we detect rust apps in various scripts (I have deployer.py and the reusable workflows in mind) which just look for this ledger_app.toml

@agrojean-ledger see here for discussion.


Unable to tapOn specific text in Jetpack Compose AnnotatedString

Clickable string on Jetpack Compose annotated text view apparently not recognized as clickable items by Maestro. Causing tapOn unable to execute click on desired annotated texts.

appId: mba.lumina.dev
---
- launchApp
- tapOn: "Mulai cari loker"
- tapOn: "Masuk"
- tapOn: "Syarat & Ketentuan"

Compose code
ClickableText(
        text = annotatedString,
        color = LuminaColor.Grey4,
        textAlign = TextAlign.Center,
        style = LuminaTheme.typography.subtitle
    ) { offset ->
        annotatedString.getStringAnnotations(tag = "terms", start = offset, end = offset)
            .firstOrNull()?.let { stringAnnotation ->
                handleEvent(
                    PrivacyPolicyEvent.ShowWebView(
                        "Syarat & Ketentuan",
                        stringAnnotation.item
                    )
                )
            }
        annotatedString.getStringAnnotations(tag = "policy", start = offset, end = offset)
            .firstOrNull()?.let { stringAnnotation ->
                handleEvent(
                    PrivacyPolicyEvent.ShowWebView(
                        "Kebijakan Privasi",
                        stringAnnotation.item
                    )
                )
            }
    }

Any idea?

This command fails on "NSAttributedString" also. It looks like the rich texts does not support yet


Add support for non VLA

What should the feature do?
Allow to use nanopb on compilers without support for variable length arrays.
In what situation would the feature be useful?
When using C90 compiler.

Hmm, where are VLAs currently used?

I'm closing off this issue because there has not been any reply. I'm not currently aware of nanopb using VLAs.


missed a place where min_contig_size is used

If we don't set this, it defaults to 4

@morsecodist merging this one so we don't lose it


Cursor position (in Input Tag) -- executes Pounce only up to cursor

input tag (type="text") should respond to the placement of the cursor
FYI If possible add this feature in a way that allows a transition to a future change from the input tag to a graphical component that displays and allows edits to Pounce words, painted on a canvas or svg tag.

when the cursor is in the middle of a word, either run the whole word or don't (do not run a portion of the word).


Resolve Python 3 Unicode-objects must be encoded before hashing in UserFactory

I know django-libs doesn't support Python 3 but this will continue to work with Python 2.
File "/home//user/.virtualenvs/django-testing/lib/python3.4/site-packages/django_libs/tests/factories.py", line 78, in <lambda>
    username = factory.Sequence(lambda n: md5(str(n)).hexdigest()[0:30])
nose.proxy.TypeError: Unicode-objects must be encoded before hashing

@mikejarrett Thanks!


Fix the missing intermediate CA certs on Citadel TLS service.

Fixes https://github.com/istio/istio/issues/16593.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ X ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

/hold
To add tests.

@myidpt: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-presubmit-tests-master
21e664335a0211291fb107fb5c276fd36d8692b6
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

We may need an integration test for this feature.

@myidpt: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-presubmit-tests-master
21e664335a0211291fb107fb5c276fd36d8692b6
link
/test integ-mixer-k8s-presubmit-tests-master

integ-pilot-k8s-presubmit-tests-master
589cc5bed418b1415fbd602ffbc0661cfd701a78
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-presubmit-tests-master
21e664335a0211291fb107fb5c276fd36d8692b6
link
/test integ-mixer-k8s-presubmit-tests-master

integ-pilot-k8s-presubmit-tests-master
589cc5bed418b1415fbd602ffbc0661cfd701a78
link
/test integ-pilot-k8s-presubmit-tests-master

e2e-bookInfoTests-envoyv2-v1alpha3-master
a26e4a796ce9e06b996b24e1659810edf82fb168
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-presubmit-tests-master
21e664335a0211291fb107fb5c276fd36d8692b6
link
/test integ-mixer-k8s-presubmit-tests-master

e2e-bookInfoTests-envoyv2-v1alpha3-master
a26e4a796ce9e06b996b24e1659810edf82fb168
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

istio-pilot-e2e-envoyv2-v1alpha3-master
13af39b0639888ad8cb95f7f80852797b151e319
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@myidpt: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-presubmit-tests-master
fbdcf24d00c4d254dc06d14f93c627e7f50d5773
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Confirming this works.  Tested with a non self-signed Citadel with mesh expansion betweek GKE and a GCE VM.

In response to a cherrypick label: #16647 failed to apply on top of branch "release-1.1":
Applying: Small fix.
Applying: Small fix.
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	security/pkg/pki/ca/ca.go
M	security/pkg/pki/ca/ca_test.go
M	security/pkg/probe/controller.go
M	security/pkg/probe/controller_test.go
M	security/pkg/server/ca/server.go
M	security/pkg/server/ca/server_test.go
Falling back to patching base and 3-way merge...
Auto-merging security/pkg/server/ca/server_test.go
Auto-merging security/pkg/server/ca/server.go
Auto-merging security/pkg/probe/controller_test.go
Auto-merging security/pkg/probe/controller.go
Auto-merging security/pkg/pki/ca/ca_test.go
CONFLICT (content): Merge conflict in security/pkg/pki/ca/ca_test.go
Auto-merging security/pkg/pki/ca/ca.go
Patch failed at 0003 Small fix.

In response to a cherrypick label: new pull request created: #16712

In response to a cherrypick label: new pull request created: #16713


All processes try to remove tmp dir

Ran into this today. Looks like when running multiple processes the first one might clean up the tmp dir before the last one finishes shutting down:
cleaning up 2 processes
/Users/mat/stellar/stellar_core_commander/lib/stellar_core_commander/process.rb:180:in `chdir': No such file or directory @ dir_chdir - /var/folders/5t/dcwhdrzs4mn8t7m9vwtw9_bc0000gn/T/scc20150603-20726-18p7np4 (Errno::ENOENT)
	from /Users/mat/stellar/stellar_core_commander/lib/stellar_core_commander/process.rb:180:in `run_cmd'
	from /Users/mat/.rvm/gems/ruby-2.2.2/gems/contracts-0.9/lib/contracts/method_reference.rb:43:in `send_to'
	from /Users/mat/.rvm/gems/ruby-2.2.2/gems/contracts-0.9/lib/contracts.rb:371:in `call_with'
	from /Users/mat/.rvm/gems/ruby-2.2.2/gems/contracts-0.9/lib/contracts/decorators.rb:182:in `block in common_method_added'
	from /Users/mat/stellar/stellar_core_commander/lib/stellar_core_commander/docker_process.rb:48:in `running?'
	from /Users/mat/.rvm/gems/ruby-2.2.2/gems/contracts-0.9/lib/contracts/method_reference.rb:43:in `send_to'
	from /Users/mat/.rvm/gems/ruby-2.2.2/gems/contracts-0.9/lib/contracts.rb:371:in `call_with'
	from /Users/mat/.rvm/gems/ruby-2.2.2/gems/contracts-0.9/lib/contracts/decorators.rb:182:in `block in common_method_added'
	from /Users/mat/stellar/stellar_core_commander/lib/stellar_core_commander/docker_process.rb:60:in `shutdown'
	from /Users/mat/.rvm/gems/ruby-2.2.2/gems/contracts-0.9/lib/contracts/method_reference.rb:43:in `send_to'
	from /Users/mat/.rvm/gems/ruby-2.2.2/gems/contracts-0.9/lib/contracts.rb:371:in `call_with'
	from /Users/mat/.rvm/gems/ruby-2.2.2/gems/contracts-0.9/lib/contracts/decorators.rb:182:in `block in common_method_added'
	from /Users/mat/stellar/stellar_core_commander/lib/stellar_core_commander/docker_process.rb:67:in `cleanup'
	from /Users/mat/.rvm/gems/ruby-2.2.2/gems/contracts-0.9/lib/contracts/method_reference.rb:43:in `send_to'
	from /Users/mat/.rvm/gems/ruby-2.2.2/gems/contracts-0.9/lib/contracts.rb:371:in `call_with'
	from /Users/mat/.rvm/gems/ruby-2.2.2/gems/contracts-0.9/lib/contracts/decorators.rb:182:in `block in common_method_added'
	from /Users/mat/stellar/stellar_core_commander/lib/stellar_core_commander/commander.rb:67:in `each'
	from /Users/mat/stellar/stellar_core_commander/lib/stellar_core_commander/commander.rb:67:in `cleanup'
	from /Users/mat/stellar/stellar_core_commander/lib/stellar_core_commander/commander.rb:73:in `block in cleanup_at_exit!'

Oh, actually looks like this specifically happens when using ./b/scc -r examples/simple_payment.rb -p docker
Could be that recipe needs updating for the new case. Will investigate.


Webpack dev server

Just wondering if anyone has successfully managed to set up a [webpack-dev-server] (http://webpack.github.io/docs/webpack-dev-server.html) for this project?

@joshhornby Thanks for asking! We haven't set it up yet but it's on our to-do list. Was hoping for dev server and React hot loader to speed up dev work.
Would you be interested in working on this? I'll bump this up in priority. :)

I was hacking around earlier and could get webpack-dev-server to work with hot loading but my issue was I didn't know how to run the server/index.js in webpack. Any ideas @choonkending

None yet, (was reading more about webpack-dev-server on the tram to work) :) If you have a branch up I can have a look!

I have pushed up what I have. https://github.com/choonkending/react-webpack-node/pull/34 We just need to get the node app into the webpack config and it should work.


Refactor chrome tab toolbar dark mode on/off

Modified to change the Chrome toolbar color according to the system scheme during dark mode transitions. Although specific colors can be applied using setColorSchemeParams, using the default values should be sufficient.
https://github.com/android/nowinandroid/assets/38935359/042b8863-f0ca-45f3-bbaf-7f26ad42ef87
After.webm

There's no way to change dark mode for content? Your demo seems changed just status and action bar.

There's no way to change dark mode for content? Your demo seems to change just status and action bar.

@Jaehwa-Noh
It will change on web pages that support dark mode. :)
https://github.com/android/nowinandroid/assets/38935359/2fa722ff-48ca-4163-9c92-192e79b923ef

If I use this method, wouldn't there be inconsistencies when the app selects a light or dark theme instead of the system theme?

@Ibodwe
If it is a WebView that needs to interact with the app, it should indeed change according to the app theme as you mentioned. However, since it is a WebView solely for web pages, it has been implemented as it is now.

This is an interesting idea, however, the original code served a purpose: it sets the chrome custom tab toolbar color to the app's background color. It's a way of passing the app's branding to the webview. It shouldn't be removed. Ideally what should happen when day/night mode changes is the custom tab toolbar color should change to whatever the background color of the app is, however, I don't think that's possible.
I will leave this open just in case it is.

Thank you for submitting this pull request. We have decided not to accept it at this time.
Feel free to comment or open an issue for further discussion if necessary.


json unmarshal conversion of map with some invalid fields breaks valid fields

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go1.7 (installed via gvm)
What operating system and processor architecture are you using (go env)?
osx (el capitan) amd64, debian linux amd64, also go playground
What did you do?
https://play.golang.org/p/om2yJ89fb_
What did you expect to see?
I expect to see "yarp" as the value in String.
What did you see instead?
When I supply specific combinations of valid json with values that do not match my structure String is empty instead of "yarp".

json.Unmarshal returns an error, which you are ignoring, which is why you're getting the zero value of the data struct. See https://play.golang.org/p/iMGK8M12Pm.

Thanks for the answer; while I don't disagree that I should be catching the error the code I was originally working with had a composite struct with three properties and which correctly populated 2/3 fields in spite of the error.
Is the solution then to make sure you are only doing json unmarshal on a temporary structure that you can discard in the event of errors, or should an error prevent modifying the structure passed in?


HoverContainer should include signals for dragging and releasing

This would be to allow people to have more direct drag-and-drop functionality available to them.

Closing, as this node has been removed and is no longer relevant.


feat: config for matching ignite capability

Description
Fix #
Updation of config.yaml for vision classification template to match pytorch ignite's results
Additional context
Need to test once again with this config

What is the purpose of this pull request?

[ ] Bug fix
[ yes ] New feature
[ ] Other

@venkatramnank can you follow this guideline: https://github.com/pytorch-ignite/code-generator/blob/main/CONTRIBUTING.md#pull-request-guidelines to reformat the config yaml file


Add methods and tests

-Added book and label class
-Added tests

You part of project is complete, there is nothing else to say, it is time to merge it :100:


Refactor db structures to support fast syncing

Currently when a node serves only one period for syncing, this is performed from the DB point of view:
Query Columns::period_pbft_block to retrieve pbft block hash from period_pbft_block
Query Columns::pbft_blocks by pbft block hash to retrieve the full pbft block
Query Columns::cert_votes to retrieve cert votes for pbft block
Query Columns::dag_finalized_blocks to retrieve list of dag blocks hashes for the pbft block
Multi Query Columns::dag_blocks to retrieve all the dag blocks by hashes - currently in testnet this is a multiquery matching about 60 dag block hashes to dag blocks
Multi Query Columns::transactions to retrieve all the transactions - currently in testnet this is a multiquery matching about 2000 transactions hashes to transactions
This is very inefficient. Specially for transactions but the same applies for dag blocks as well. Also there is no point in having two different data in two columns under the same unique key.
All of the data above should be kept in a single rocksdb column. So one RLP serialized data for a period should consis of pbft block, cert votes, dag blocks and transactions. A syncing request for a period would just be:

Pull RLP for a period with a single query and send it out.

The only downside in this approach is case when there is a need to pull specific DAG block or transaction. Node it self will never require the dag block or transaction that is already executed.
The only use case for this is explorer where someone could ask for a specific transaction or a dag block. For this it will require two queries instead of one it needs now. But I do not see any use case where someone would do a huge query for a lot of specific transactions. Any such request should be a malicious one.
Transaction and dag blocks that are not executed yet will be kept in the current Columns::dag_blocks and Columns::transactions but once they are executed they should be removed from these columns
Test performed to check the effectiveness of this approach compared with the current implementation. On the current testnet of about 30GB of data and current node implementation for 25 pbft blocks it takes about 2500ms in average to pull the transactions from db. To query the same transactions stored per period it takes only 20ms.

There is also I think we should add and that's something like small cache for this, so when someone want to just sync up latest ~50 pbft blocks or so we do not need to touch DB


Cloud-init unhandled unknown content-type (application/node.eks.aws) userdata

What happened:
We are using Karpenter for node management and autoscaling. After migrating to AL2023, we noticed a warning in the system log. Specifically, when using the EC2NodeClass with custom userData as described below, the system log shows a warning about an unhandled unknown content type (application/node.eks.aws) in the user data.
[    8.950282] cloud-init[2183]: 2024-09-12 12:57:56,263 - __init__.py[WARNING]: Unhandled unknown content-type (application/node.eks.aws) userdata: 'b'# Karpenter Generated No'...'
[    8.953015] cloud-init[2183]: 2024-09-12 12:57:56,263 - __init__.py[WARNING]: Unhandled unknown content-type (application/node.eks.aws) userdata: 'b'---'...'

Despite this warning, inside the node, the configuration is applied correctly with the following:
/etc/kubernetes/kubelet/config.json.d/00-nodeadm.conf:
{
  "apiVersion": "kubelet.config.k8s.io/v1beta1",
  "clusterDNS": [
      "<IP_ADDRESS>"
  ],
  "cpuCFSQuota": false,
  "kind": "KubeletConfiguration",
  "maxPods": 29,
  "registerWithTaints": [
      {
          "effect": "NoSchedule",
          "key": "general"
      }
  ]
}

What you expected to happen:
The custom userData should be processed without warnings, ensuring proper handling of all content types.
How to reproduce it (as minimally and precisely as possible):

Use the following EC2NodeClass specification:

apiVersion: karpenter.k8s.aws/v1beta1
kind: EC2NodeClass
metadata:
  name: default
spec:
  amiFamily: AL2023
  role: {{ .Values.karpenter.settings.nodeRole }}
  securityGroupSelectorTerms:
  - tags:
      karpenter.sh/discovery: {{ .Values.karpenter.settings.clusterName }}
  subnetSelectorTerms:
  - tags:
      karpenter.sh/discovery: {{ .Values.karpenter.settings.clusterName }}
  tags:
    karpenter.sh/discovery: {{ .Values.karpenter.settings.clusterName }}
    owner: {{ .Values.karpenter.settings.clusterName }}
  userData: |
    MIME-Version: 1.0
    Content-Type: multipart/mixed; boundary="BOUNDARY"

    --BOUNDARY
    Content-Type: application/node.eks.aws

    ---
    apiVersion: node.eks.aws/v1alpha1
    kind: NodeConfig
    spec:
      kubelet:
        config:
          cpuCFSQuota: false

    --BOUNDARY
    Content-Type: text/x-shellscript; charset="us-ascii"

    #!/bin/bash

    set -eoux pipefail
    modprobe tls

    cat <<EOF >> /etc/sysctl.conf

    # tcp keepalive
    net.ipv4.tcp_keepalive_time = 300
    net.ipv4.tcp_keepalive_probes = 5
    net.ipv4.tcp_keepalive_intvl = 15

    net.ipv4.tcp_slow_start_after_idle=0

    # bbr tcp congestion control algorithm
    net.core.default_qdisc=fq
    net.ipv4.tcp_congestion_control=bbr

    EOF

    sysctl -p /etc/sysctl.conf

    --BOUNDARY--

Observe the system log to see the warnings.

Other:
Here is the link to the original issue I opened on the aws/karpenter-provider-aws repository: #6989
Environment:

AWS Region: eu-central-1
Instance Type(s): t3.xlarge
Cluster Kubernetes version: v1.30.3-eks-2f46c53
Node Kubernetes version: v1.30.2-eks-1552ad0
AMI Version: 1.30.2-20240904

User data from the EC2 instance:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="BOUNDARY"

--BOUNDARY
Content-Type: application/node.eks.aws

# Karpenter Generated NodeConfig
apiVersion: node.eks.aws/v1alpha1
kind: NodeConfig
metadata:
  creationTimestamp: null
spec:
  cluster:
    apiServerEndpoint: REDACTED
    certificateAuthority: REDACTED
    cidr: <IP_ADDRESS>/16
    name: REDACTED
  containerd: {}
  instance:
    localStorage: {}
  kubelet:
    config:
      clusterDNS:
      - <IP_ADDRESS>
      maxPods: 58
      registerWithTaints:
      - effect: NoSchedule
        key: general
    flags:
    - --node-labels="karpenter.sh/capacity-type=spot,karpenter.sh/nodepool=general"

--BOUNDARY
Content-Type: application/node.eks.aws

---
apiVersion: node.eks.aws/v1alpha1
kind: NodeConfig
spec:
  kubelet:
    config:
      cpuCFSQuota: false

--BOUNDARY
Content-Type: text/x-shellscript; charset="us-ascii"

#!/bin/bash

set -eoux pipefail
modprobe tls

cat <<EOF >> /etc/sysctl.conf

# tcp keepalive
net.ipv4.tcp_keepalive_time = 300
net.ipv4.tcp_keepalive_probes = 5
net.ipv4.tcp_keepalive_intvl = 15

net.ipv4.tcp_slow_start_after_idle=0

# bbr tcp congestion control algorithm
net.core.default_qdisc=fq
net.ipv4.tcp_congestion_control=bbr

EOF

sysctl -p /etc/sysctl.conf

--BOUNDARY--

You can ignore this log message, that’s just cloud-init saying it’s going to ignore that part of the MIME document (which is intended). The NodeConfig objects are retrieved by nodeadm: https://github.com/awslabs/amazon-eks-ami/tree/main/nodeadm

You can ignore this log message, that just means cloud-init is going to ignore that part of the MIME document (which is intended). The NodeConfig objects are retrieved by nodeadm: https://github.com/awslabs/amazon-eks-ami/tree/main/nodeadm

Thank you for the clarification.


Some browser specific css rules (-webkit*, -ms*, -moz*) not rendered

Type: Bug

Packages
Version

fela
11.2.0

react-fela
11.2.0

fela-monolithic
11.2.0

fela-plugin-expand-shorthand
11.2.0

fela-plugin-fallback-value
11.2.0

fela-plugin-friendly-pseudo-class
11.2.0

fela-plugin-named-keys
11.2.0

fela-plugin-unit
11.2.0

Description
I'm adding code to hide scrollbars by css rules. Rules
MsOverflowStyle: '-ms-autohiding-scrollbar',
WebkitOverflowScrolling: 'touch',

won't get rendered and no error is thrown in the console.
It is interesing that for example rules like
WebkitAppearance: 'none',
WebkitTapHighlightColor: 'transparent',

get rendered without any problems.

Steps to reproduce

Try to use any of previously mentioned rules.
Expected Behavior
Render rules like
-ms-overflow-style: -ms-autohiding-scrollbar;
-webkit-overflow-scrolling: touch;

Actual Behavior
The rules wont get rendered.

On which browser are you testing? Safari for example simply removes rules that are not supported (e.g. -webkit-overflow-scrolling) so this is not an issue with fela (since we don't care what property-value pair you pass, but it's actually you're browser throwing if an invalid rule render is attempted)

I see, now it makes sense. Is this behaviour documented somewhere? Because I expected to see the rule rendered anyways and disabled by a browser. Maybe would be better to at least log an error into the console in the dev mode.
But thanks for help!

Btw what is the validator plugin for then? I would expect it logging an error about not supported rule, but didn't log anything. My setup is :
felaPluginValidator({
            logInvalid: true,
            deleteInvalid: false,
            useCSSLint: false,
        })

So the rule is rendered in devMode, but won't in production. That's because we use insertRule in production and that's simply the way how insertRule works.
It'd probably show tons of warnings if we enabled that (e.g. Safari would log any other prefix than -webkit-). Tbh, I have never used the validator plugin myself, it was rather a community-driven plugin, but it's made to find your style issues e.g. typos, wrong value types or whatever and is not concerned about browser support of props (it won't throw on -webkit-overflow-scrolling since that's a valid prop for some browsers).

Hmm, right, devMode was the problem, I had it set to false 🤦. But thanks anyways, I've learned something new :D

You're welcome :) Might still be good to add that somewhere in the docs. One usually does not call insertRule manually from a product perspective, so most ppl won't know that!

Hello, I feel like this might be similar, but why am not I not able to use input[type=range]::-webkit-slider-thumb selector?

Can you give me a full code example of what you‘re trying to do here?

Am trying to customize range input as here for example - css-tricks
const inputRule = () => ({
  "&::-webkit-slider-thumb": {
    appearance: "none",
    "-webkit-appearance": "none",
    width: "40px",
    height: "40px"
  }
})

<input className={css(inputRule)} type="range" />

some classes are assigned to the element, but they are empty. They are not listed in development tools in chrome under "styles"
<input class="au av aw ax" type="range"/>

what am I doing wrong? Thanks for this useful tool!

I seems like these rules are "illegal" in the browser then. Not sure what the issue is.
Here's what I am using in a custom project and it works just fine.
const style = {
  '::-webkit-slider-thumb, ::-moz-range-thumb, ::-ms-thumb': {
    ...
  }
}

Note: I am using fela-plugin-multiple-selectors to resolve the comma-separated list of selectors.


add paste feature to editor

What's new
This adds the paste feature to the text editor

paste feature will be push upstream


Separate Rendezvous message handling from BLE session

With this change, BLE handling remains in RendezvousSession and
message processing independent of BLE moves to RendervousMessageHandler.

@pan-apple Could you take a look, please?

tag: @vivien-apple

@saurabhst @BroderickCarlin @andy31415 could you take a look?


Issue #64 |  Added animation to the icons

Description
I've added an infinite shaking animation to the icons on the Home Page to make them look a bit more interactive.
I have ensured that I have maintained the code consistency while solving this issue.
Please review it.
Related Issues or Pull Requests
64
Sample Video
https://user-images.githubusercontent.com/66838142/121568749-a7163b80-ca3d-11eb-9d87-f01d6b1954d4.mp4

So, do I need to do anything else about this issue, or is this sufficient for merging? @niloysikdar @nilisha-jais

There's a merge conflict. Please resolve it

Please check it @nilisha-jais, I've resolved all the conflicts and all the checks have been passed.

Looks great! Thank you @utkarshgoel10 :)


results command

Have an export/results command that can export results for e.g. LADOK (see this issue). It should export CSV formatted results data.

results is the better name.


fix: Typo in sanitize

Resolve #3237
Description
Alternative solution to #3237, this is probably the way to go, but it doesn't compile because of Typescript typings.

[x] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

[ ] Chore (non-breaking change which does not add functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Change to the templates directory (does not affect core functionality)
[ ] Change to the examples directory (does not affect core functionality)
[ ] This change requires a documentation update

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

We have some concerns about this one and what it might affect beyond just #3237. We are reviewing #3238 and testing before that gets merged.
Thanks!

Note that the change was introduced in 294fb5e57463fd6d500b5bb786d651155fa6adbf probably for typing reasons. This specific commit does probably break other things too. The safest thing would probably be to revert this clone: https://github.com/payloadcms/payload/blob/e5c783df5db610c913012ec20370e31a6ad02385/src/config/sanitize.ts#L13
-  const sanitizedConfig = { ...configToSanitize };
+  const sanitizedConfig = configToSanitize as Partial<SanitizedConfig>


Kaniko job failure when adding new API and the relevant image does not exist.

Description:
Kaniko job fails when adding a new API and the relevant image does not exists.
Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

Resolved in https://github.com/wso2/k8s-apim-operator/pull/83


FastAPI: AttributeError: type object 'HealthSummary' has no attribute 'pydantic_model'

The current version of FastAPI (0.92.0) does not seem to work with the current Pyctuator (1.0.1).
I found a discussion about this in FastApi's GIT:
https://github.com/tiangolo/fastapi/issues/3636
The cause of the problem seems to be a change in the Change https://github.com/tiangolo/fastapi/pull/3576 .
The built-in dataclasses do not seem to be fully compatible with FastAPI when using enums.
As a test, I changed the dataclasses in health/health_provider.py to:
from pydantic.dataclasses import dataclass

And it works again.
Update:
The error does not occur in FastAPI version 0.88.0.

Thanks, will try to get to this soon.

This is the same issue as #87.
Fixed in https://github.com/SolarEdgeTech/pyctuator/pull/91

Version 1.0.2

@michaelyaakoby
Thank you very much for your work.
Just test it and it works.


function seems to expect a list of codes but instead a ValueSetDef is being input

We're finding this code:
define function "VS Cast Function"(VSet List<System.Code>):
( ( cast { "VSet", 1 }[0]as Tuple {
codes List<System.Code>,
oid System.String,
version System.String
}
).codes ) VSetCodes
return System.Code { code: VSetCodes.code, system: VSetCodes.system }
throwing this error:
The following errors were encountered during evaluation:
org.opencds.cqf.cql.engine.exception.InvalidCast: Cannot cast a value of type org.cqframework.cql.elm.execution.ValueSetDef as org.opencds.cqf.cql.engine.runtime.Tuple.
at org.opencds.cqf.cql.engine.model.BaseModelResolver.as(BaseModelResolver.java:28)
at org.opencds.cqf.cql.engine.execution.Context.as(Context.java:467)
at org.opencds.cqf.cql.engine.elm.execution.AsEvaluator.internalEvaluate(AsEvaluator.java:39)
The function seems to expect a list of codes but instead a ValueSetDef is being input.  I am not sure how to resolve this.  Any thoughts?

Hi, any progress on this?

There has been some discussion herehttps://chat.fhir.org/#narrow/stream/179220-cql/topic/ValueSet.20Typing and I guy I have looking at it thinks he's close to a fix

This issue is due to an unintentional backwards incompatibility between CQL 1.4 and 1.5. Several changes were made as part of the 1.5.6 translator release (and downstream releases to the engine, evaluator, tooling, and ruler) to address this. In addition, a CQL STU comment was submitted to address the proposed changes to trial-use functionality in the ELM: https://jira.hl7.org/browse/FHIR-34804
The issue will also be discussed and proposed solution reviewed in the upcoming FHIR connectathon during the following session: https://whova.com/portal/webapp/conne_202201/Agenda/2112882
I'm closing this issue as resolved, please feel free to reopen or log another issue if there is still a problem


Update README.md : 6M downloads!!

I just realized that there were over 6x10^6 downloads of WAU. A thing to boast about IMHO.
I added that DL counter badge to WAU homepage
Proposed Changes

This PR is purely cosmetic, now readme does not generate linter warnings and the most important feature is working now,
I replaced BOLD headers in advanced section with MD:h3 tags, that way we can reference those settings directly in Issue discussion :)

Hmm, I'm not sure the 'total' download count is truly meaningful, since it includes all unique downloads, and each release ends up being counted twice—once for the MSI file and once for the WAU_InstallCounter text file. That's why I've never included that stat.
Still, it's a nice metric to see and definitely motivating for the future of the project! :)


Day222

Resolves #458.

Pull Request Test Coverage Report for Build 857

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 846:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls


TPV sister chromatid biorientation

GO:0031134 sister chromatid biorientation
ancestor to
GO:0051310 metaphase plate congression
should be removed.
biorientation and plate congression should be siblings. Biorientation is achecved when all pairs of sister kinetochores are attached to microtubules. This is after metaphase plate congression.
see
http://www.ebi.ac.uk/QuickGO/GTerm?id=GO:0031134#term=ancchart
Everything else looks OK

https://github.com/geneontology/go-ontology/issues/12244#issuecomment-173562674  has:
mitotic metaphase plate congression
. <- po attachment of mitotic spindle microtubules to kinetochore
. . <- is_a: NEW: lateral attachment of mitotic spindle microtubules to kinetochore
. . <- is_a: sister chromatid biorientation
. <- po NEW: microtubule plus-end directed mitotic chromosome migration
I thought this is what we agreed on that ticket. It's what I implemented.

my fault I misunderstood. It should be
mitotic metaphase plate congression
.  <- po: NEW: lateral attachment of mitotic spindle microtubules to kinetochore
. <- po NEW: microtubule plus-end directed mitotic chromosome migration
attachment of mitotic spindle microtubules to kinetochore
. . <- is_a: NEW: lateral attachment of mitotic spindle microtubules to kinetochore
. . <- is_a: sister chromatid biorientation (this is end-on attachment)
so biorientation  follows congression,  and both have (different parts) which are part of "attachement of spindle microtubules to kinetochore"

Fixed (finally,  I hope...)

HI David, you are going to swear at me. I realised the next day I had made a b***x here but I thought I'd wait until you got back to resurrect.
You were completely correct  before. The arrangement for congression should have been
mitotic metaphase plate congression
. <- po attachment of mitotic spindle microtubules to kinetochore
. . <- is_a: NEW: lateral attachment of mitotic spindle microtubules to kinetochore
. . <- is_a: sister chromatid biorientation
. <- po NEW: microtubule plus-end directed mitotic chromosome migration
I was confused because I thought "microtubule attachment" was not part of "localization" the parent of congression. But now I think it probably is (and if it wasn't  the localization parent of congression could move  down to the localization part).
But the attachment is definitely part of congression.
Sorry about that. Very embarrassed to change it twice. I can hear you muttering....

It has to be this way:

Congression isn't complete until bipolar attachment is completed.

Full changed back (finally!)


Unexpected (false-positive) model ready status when using batcher

/kind bug
Usually when deploying kfserving endpoint, the inferenceservices won't be marked as ready=True (can be monitored through kubectl get inferenceservices or python sdk KFServing.get(watch=True)) until the model gets ready (i.e., warmup finished through load function). However, this is not the case when using batcher: the inferenceservices will be marked as ready as soon as the batcher sidecar is ready and all containers running, before the model warmup finished. So in case there's a bug in model load function, if using batcher, we'll get false-positive and thus can't get the correct ready status.
What steps did you take and what happened:
[A clear and concise description of what the bug is.]
Here I created a simple custom model docker (model will never be ready) and uploaded to lplrobert/kfserving-not-ready
# Dockerfile
FROM python:3.6-alpine

WORKDIR /app

COPY app.py /app

RUN apk update
RUN apk add make automake gcc g++ subversion python3-dev libffi-dev openssl-dev

RUN pip install kfserving==0.4.0

CMD ["python", "app.py"]

# app.py
import kfserving
import time

class KFServingSampleModel(kfserving.KFModel):
    def __init__(self, name):
        super().__init__(name)
        self.ready = False

    def load(self):
        time.sleep(60)
        raise RuntimeError("Model load failed!")

    def predict(self, request):
        return request

if __name__ == "__main__":
    model = KFServingSampleModel("kfserving-custom-model")
    model.load()
    kfserving.KFServer(workers=1).start([model])

# custom.yaml
apiVersion: serving.kubeflow.org/v1alpha2
kind: InferenceService
metadata:
  labels:
    controller-tools.k8s.io: "1.0"
  name: kfserving-custom-model
spec:
  default:
    predictor:
      batcher:
        maxBatchSize: 32
        maxLatency: 5000
        timeout: 60
      custom:
        name: kfserving-custom-model
        container:
          image: lplrobert/kfserving-not-ready

If we apply above CRD (with batcher enabled) and watch at kubectl get inferenceservices, we'll see kfserving-custom-model gets ready pretty quickly
NAME                              URL                                                              READY   DEFAULT TRAFFIC   CANARY TRA
FFIC   AGE
kfserving-custom-model            http://kfserving-custom-model.namespace.example.com            True    100
       15s

Then become unready only after waiting for a few (>2) minutes when the pod restarted and failed
NAME                              URL                                                              READY   DEFAULT TRAFFIC   CANARY TRA
FFIC   AGE
kfserving-custom-model                                                                             False
       2m15s

Then become ready again quickly when the pod retry again
NAME                              URL                                                              READY   DEFAULT TRAFFIC   CANARY TRA
FFIC   AGE
kfserving-custom-model            http://kfserving-custom-model.namespace.example.com            True    100
       2m27s

And after that, the ready status will change back and forth when the pod fails and restarts. In that case, we'll be misled to think the model works fine at first and can't be alerted until waiting for quite a long time.
While in comparison, if we apply the above CRD with batcher section removed. The inferenceservice will never be in ready status, and thus we know at first there's a bug somewhere.
What did you expect to happen:
If using batcher, inferenceservice should also return ready=True only if model warmup succeed, rather than when all containers are running.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Istio Version:
Knative Version:
KFServing Version: 0.4.0
Kubeflow version:
Kfdef:[k8s_istio/istio_dex/gcp_basic_auth/gcp_iap/aws/aws_cognito/ibm]
Minikube version:
Kubernetes version: (use kubectl version):
OS (e.g. from /etc/os-release):

/assign @zhangrongguo

@Peilun-Li  Is there any more detail? could you put the container log here?

@Peilun-Li Is there any more detail? could you put the container log here?

The main container won't output anything until the runtime error (as can be inferred from the app.py)
batcher sidecar log:
{"level":"info","ts":1602812236.449479,"logger":"entrypoint","msg":"Starting","Port":"9082"}
{"level":"info","ts":1602812236.4495263,"logger":"entrypoint","msg":"Start Consume"}
2020/10/16 01:37:16.450 [I]  http server Running on http://:9082

inferenceservices status:
at first ready
    Conditions:
    Last Transition Time:  2020-10-16T01:37:20Z
    Status:                True
    Type:                  DefaultPredictorReady
    Last Transition Time:  2020-10-16T01:37:20Z
    Status:                True
    Type:                  Ready
    Last Transition Time:  2020-10-16T01:37:20Z
    Status:                True
    Type:                  RoutesReady

fallback to fail after 2 min
    Reason:                RevisionFailed
    Status:                False
    Type:                  DefaultPredictorReady
    Last Transition Time:  2020-10-16T01:39:18Z
    Message:               Failed to reconcile predictor
    Reason:                PredictorHostnameUnknown
    Status:                False
    Type:                  Ready
    Last Transition Time:  2020-10-16T01:39:18Z
    Message:               Failed to reconcile predictor
    Reason:                PredictorHostnameUnknown
    Status:                False
    Type:                  RoutesReady

Some noticable behavior:

The batcher won't be restarted during the CrashLoopBackOff.
The inferenceservice will get ready=True status immediately once all containers are running (pod ready 4/4)
The inferenceservice will get ready=False status immediately once main container throws error and restarts (pod ready 3/4 CrashLoopBackOff)

It seems like the batcher is not actually waiting until model is ready, through the HealthHandler.

can you put the description of the pod when the service is crash? kubectl describe pods -n $ns $podname

@Peilun-Li Is there any more detail? could you put the container log here?

The main container won't output anything until the runtime error (as can be inferred from the app.py)
batcher sidecar log:
{"level":"info","ts":1602812236.449479,"logger":"entrypoint","msg":"Starting","Port":"9082"}
{"level":"info","ts":1602812236.4495263,"logger":"entrypoint","msg":"Start Consume"}
2020/10/16 01:37:16.450 [I]  http server Running on http://:9082

inferenceservices status:
at first ready
    Conditions:
    Last Transition Time:  2020-10-16T01:37:20Z
    Status:                True
    Type:                  DefaultPredictorReady
    Last Transition Time:  2020-10-16T01:37:20Z
    Status:                True
    Type:                  Ready
    Last Transition Time:  2020-10-16T01:37:20Z
    Status:                True
    Type:                  RoutesReady

fallback to fail after 2 min
    Reason:                RevisionFailed
    Status:                False
    Type:                  DefaultPredictorReady
    Last Transition Time:  2020-10-16T01:39:18Z
    Message:               Failed to reconcile predictor
    Reason:                PredictorHostnameUnknown
    Status:                False
    Type:                  Ready
    Last Transition Time:  2020-10-16T01:39:18Z
    Message:               Failed to reconcile predictor
    Reason:                PredictorHostnameUnknown
    Status:                False
    Type:                  RoutesReady

Some noticable behavior:

The batcher won't be restarted during the CrashLoopBackOff.
The inferenceservice will get ready=True status immediately once all containers are running (pod ready 4/4)
The inferenceservice will get ready=False status immediately once main container throws error and restarts (pod ready 3/4 CrashLoopBackOff)

It seems like the batcher is not actually waiting until model is ready, through the HealthHandler.

If you remove the batch section, the service will turn to false too?

If you remove the batch section, the service will turn to false too?

If removing batch section, the service will never be in ready=True status (forever false from the very beginning)

If removing batch section, the service will never be in ready=True status (forever false from the very beginning)

emm, I know what you are meaning now.  Thanks your report, I will fix this.

Here's the pod description
$ kubectl describe pods kfserving-custom-model-predictor-default-k5t6h-deployment-x2c6z
Name:         kfserving-custom-model-predictor-default-k5t6h-deployment-x2c6z
Namespace:    example_namespace
Priority:     0
Node:         ip-100-120-28-190.us-west-2.compute.internal/<IP_ADDRESS>
Start Time:   Thu, 15 Oct 2020 19:16:42 -0700
Labels:       app=kfserving-custom-model-predictor-default-k5t6h
              component=predictor
              controller-tools.k8s.io=1.0
              endpoint=default
              istio.io/rev=default
              model=kfserving-custom-model
              pod-template-hash=b7b599575
              security.istio.io/tlsMode=istio
              service.istio.io/canonical-name=kfserving-custom-model-predictor-default
              service.istio.io/canonical-revision=kfserving-custom-model-predictor-default-k5t6h
              serving.knative.dev/configuration=kfserving-custom-model-predictor-default
              serving.knative.dev/configurationGeneration=1
              serving.knative.dev/revision=kfserving-custom-model-predictor-default-k5t6h
              serving.knative.dev/revisionUID=1ebb5a12-5ae0-4b73-877b-c33bbd8b8fb7
              serving.knative.dev/service=kfserving-custom-model-predictor-default
              serving.kubeflow.org/inferenceservice=kfserving-custom-model
Annotations:  autoscaling.knative.dev/class: kpa.autoscaling.knative.dev
              autoscaling.knative.dev/minScale: 1
              autoscaling.knative.dev/target: 1
              internal.serving.kubeflow.org/batcher: true
              internal.serving.kubeflow.org/batcher-max-batchsize: 32
              internal.serving.kubeflow.org/batcher-max-latency: 5000
              internal.serving.kubeflow.org/batcher-timeout: 60
              kubernetes.io/limit-ranger: LimitRanger plugin set: memory request for container queue-proxy; cpu, memory limit for container queue-proxy
              kubernetes.io/psp: eks.privileged
              serving.knative.dev/creator: system:serviceaccount:kfserving-system:default
              sidecar.istio.io/status:
                {"version":"d36ff46d2def0caba37f639f09514b17c4e80078f749a46aae84439790d2b560","initContainers":["istio-init"],"containers":["istio-proxy"]...
Status:       Running
IP:           <IP_ADDRESS>
IPs:
  IP:           <IP_ADDRESS>
Controlled By:  ReplicaSet/kfserving-custom-model-predictor-default-k5t6h-deployment-b7b599575
Init Containers:
  istio-init:
    Container ID:  docker://9362953cf972fa077761243a0ec7e2f9228f6288f5a94a05d2d86c0eabd653e2
    Image:         docker.io/istio/proxyv2:1.6.1
    Image ID:      docker-pullable://istio/proxyv2@sha256:84e3afe9b4404ca94fd2e6e0277c642eb29b8b37ca46deff49dbe1f5e1b7fdc3
    Port:          <none>
    Host Port:     <none>
    Args:
      istio-iptables
      -p
      15001
      -z
      15006
      -u
      1337
      -m
      REDIRECT
      -i
      *
      -x

      -b
      *
      -d
      15090,15021,15020
    State:          Terminated
      Reason:       Completed
      Exit Code:    0
      Started:      Thu, 15 Oct 2020 19:16:44 -0700
      Finished:     Thu, 15 Oct 2020 19:16:45 -0700
    Ready:          True
    Restart Count:  0
    Limits:
      cpu:     100m
      memory:  50Mi
    Requests:
      cpu:     10m
      memory:  10Mi
    Environment:
      DNS_AGENT:
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-75kkk (ro)
Containers:
  user-container:
    Container ID:  docker://5427f0c6a0b8695db71d6d9d62a1e8792fa0d5d56efc0e56c25d5c6990499bc1
    Image:         index.docker.io/lplrobert/kfserving-not-ready@sha256:6f0c491ad90c32b51ab13106c032c6aa8ad8050ab6317b7a59360a02539ff851
    Image ID:      docker-pullable://lplrobert/kfserving-not-ready@sha256:6f0c491ad90c32b51ab13106c032c6aa8ad8050ab6317b7a59360a02539ff851
    Port:          9082/TCP
    Host Port:     0/TCP
    State:         Terminated
      Reason:      Error
      Message:     Traceback (most recent call last):
  File "app.py", line 18, in <module>
    model.load()
  File "app.py", line 11, in load
    raise RuntimeError("Model load failed!")
RuntimeError: Model load failed!

      Exit Code:  1
      Started:    Thu, 15 Oct 2020 19:17:47 -0700
      Finished:   Thu, 15 Oct 2020 19:18:48 -0700
    Last State:   Terminated
      Reason:     Error
      Message:    Traceback (most recent call last):
  File "app.py", line 18, in <module>
    model.load()
  File "app.py", line 11, in load
    raise RuntimeError("Model load failed!")
RuntimeError: Model load failed!

      Exit Code:    1
      Started:      Thu, 15 Oct 2020 19:16:46 -0700
      Finished:     Thu, 15 Oct 2020 19:17:46 -0700
    Ready:          False
    Restart Count:  1
    Limits:
      cpu:     1
      memory:  2Gi
    Requests:
      cpu:     1
      memory:  2Gi
    Environment:
      PORT:                      9082
      K_REVISION:                kfserving-custom-model-predictor-default-k5t6h
      K_CONFIGURATION:           kfserving-custom-model-predictor-default
      K_SERVICE:                 kfserving-custom-model-predictor-default
      K_INTERNAL_POD_NAME:       kfserving-custom-model-predictor-default-k5t6h-deployment-x2c6z (v1:metadata.name)
      K_INTERNAL_POD_NAMESPACE:  example_namespace (v1:metadata.namespace)
    Mounts:
      /var/log from knative-var-log (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-75kkk (ro)
  queue-proxy:
    Container ID:   docker://0c23786875850a012f44b711504b0736b67bc805fd24078852caa3a62ca62faf
    Image:          gcr.io/knative-releases/knative.dev/serving/cmd/queue@sha256:713bd548700bf7fe5452969611d1cc987051bd607d67a4e7623e140f06c209b2
    Image ID:       docker-pullable://gcr.io/knative-releases/knative.dev/serving/cmd/queue@sha256:713bd548700bf7fe5452969611d1cc987051bd607d67a4e7623e140f06c209b2
    Ports:          8022/TCP, 9090/TCP, 9091/TCP, 8012/TCP
    Host Ports:     0/TCP, 0/TCP, 0/TCP, 0/TCP
    State:          Running
      Started:      Thu, 15 Oct 2020 19:16:46 -0700
    Ready:          True
    Restart Count:  0
    Limits:
      cpu:     500m
      memory:  512Mi
    Requests:
      cpu:      25m
      memory:   128Mi
    Readiness:  exec [/ko-app/queue -probe-period 0] delay=0s timeout=10s period=1s #success=1 #failure=3
    Environment:
      SERVING_NAMESPACE:                      example_namespace
      SERVING_SERVICE:                        kfserving-custom-model-predictor-default
      SERVING_CONFIGURATION:                  kfserving-custom-model-predictor-default
      SERVING_REVISION:                       kfserving-custom-model-predictor-default-k5t6h
      QUEUE_SERVING_PORT:                     8012
      CONTAINER_CONCURRENCY:                  0
      REVISION_TIMEOUT_SECONDS:               60
      SERVING_POD:                            kfserving-custom-model-predictor-default-k5t6h-deployment-x2c6z (v1:metadata.name)
      SERVING_POD_IP:                          (v1:status.podIP)
      SERVING_LOGGING_CONFIG:                 {
                                                "level": "info",
                                                "development": false,
                                                "outputPaths": ["stdout"],
                                                "errorOutputPaths": ["stderr"],
                                                "encoding": "json",
                                                "encoderConfig": {
                                                  "timeKey": "ts",
                                                  "levelKey": "level",
                                                  "nameKey": "logger",
                                                  "callerKey": "caller",
                                                  "messageKey": "msg",
                                                  "stacktraceKey": "stacktrace",
                                                  "lineEnding": "",
                                                  "levelEncoder": "",
                                                  "timeEncoder": "iso8601",
                                                  "durationEncoder": "",
                                                  "callerEncoder": ""
                                                }
                                              }
      SERVING_LOGGING_LEVEL:
      SERVING_REQUEST_LOG_TEMPLATE:
      SERVING_REQUEST_METRICS_BACKEND:        prometheus
      TRACING_CONFIG_BACKEND:                 none
      TRACING_CONFIG_ZIPKIN_ENDPOINT:
      TRACING_CONFIG_STACKDRIVER_PROJECT_ID:
      TRACING_CONFIG_DEBUG:                   false
      TRACING_CONFIG_SAMPLE_RATE:             0.1
      USER_PORT:                              9082
      SYSTEM_NAMESPACE:                       knative-serving
      METRICS_DOMAIN:                         knative.dev/internal/serving
      DOWNWARD_API_LABELS_PATH:               /etc/podinfo/labels
      SERVING_READINESS_PROBE:                {"tcpSocket":{"port":9082,"host":"<IP_ADDRESS>"},"successThreshold":1}
      ENABLE_PROFILING:                       false
      SERVING_ENABLE_PROBE_REQUEST_LOG:       false
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-75kkk (ro)
  batcher:
    Container ID:  docker://90e50d6742bb149167289e4ae8fda221b36acb56be6de8bf911e05c018d2663b
    Image:         kfserving/batcher:v0.4.0
    Image ID:      docker-pullable://kfserving/batcher@sha256:5260a674f6241c4eead71a32813a6b7fca082827cf1a014ef6627357ba115477
    Port:          <none>
    Host Port:     <none>
    Args:
      --max-batchsize
      32
      --max-latency
      5000
      --timeout
      60
    State:          Running
      Started:      Thu, 15 Oct 2020 19:16:46 -0700
    Ready:          True
    Restart Count:  0
    Limits:
      cpu:     1
      memory:  1Gi
    Requests:
      cpu:        1
      memory:     1Gi
    Environment:  <none>
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-75kkk (ro)
  istio-proxy:
    Container ID:  docker://b0f41818bc02a3eaa1b55afdef06e5be0e4dc1e4cd9fd9c12a9bf70aaf4ed9fb
    Image:         docker.io/istio/proxyv2:1.6.1
    Image ID:      docker-pullable://istio/proxyv2@sha256:84e3afe9b4404ca94fd2e6e0277c642eb29b8b37ca46deff49dbe1f5e1b7fdc3
    Port:          15090/TCP
    Host Port:     0/TCP
    Args:
      proxy
      sidecar
      --domain
      $(POD_NAMESPACE).svc.cluster.local
      --serviceCluster
      kfserving-custom-model-predictor-default-k5t6h.$(POD_NAMESPACE)
      --proxyLogLevel=warning
      --proxyComponentLogLevel=misc:error
      --trust-domain=cluster.local
      --concurrency
      2
    State:          Running
      Started:      Thu, 15 Oct 2020 19:16:47 -0700
    Ready:          True
    Restart Count:  0
    Limits:
      cpu:     2
      memory:  1Gi
    Requests:
      cpu:      100m
      memory:   128Mi
    Readiness:  http-get http://:15021/healthz/ready delay=1s timeout=1s period=2s #success=1 #failure=30
    Environment:
      JWT_POLICY:                    third-party-jwt
      PILOT_CERT_PROVIDER:           istiod
      CA_ADDR:                       istiod.istio-system.svc:15012
      POD_NAME:                      kfserving-custom-model-predictor-default-k5t6h-deployment-x2c6z (v1:metadata.name)
      POD_NAMESPACE:                 example_namespace (v1:metadata.namespace)
      INSTANCE_IP:                    (v1:status.podIP)
      SERVICE_ACCOUNT:                (v1:spec.serviceAccountName)
      HOST_IP:                        (v1:status.hostIP)
      CANONICAL_SERVICE:              (v1:metadata.labels['service.istio.io/canonical-name'])
      CANONICAL_REVISION:             (v1:metadata.labels['service.istio.io/canonical-revision'])
      PROXY_CONFIG:                  {"proxyMetadata":{"DNS_AGENT":""}}

      ISTIO_META_POD_PORTS:          [
                                         {"name":"user-port","containerPort":9082,"protocol":"TCP"}
                                         ,{"name":"http-queueadm","containerPort":8022,"protocol":"TCP"}
                                         ,{"name":"http-autometric","containerPort":9090,"protocol":"TCP"}
                                         ,{"name":"http-usermetric","containerPort":9091,"protocol":"TCP"}
                                         ,{"name":"queue-port","containerPort":8012,"protocol":"TCP"}
                                     ]
      ISTIO_META_APP_CONTAINERS:     [
                                         user-container,
                                         queue-proxy,
                                         batcher
                                     ]
      ISTIO_META_CLUSTER_ID:         Kubernetes
      ISTIO_META_INTERCEPTION_MODE:  REDIRECT
      ISTIO_METAJSON_ANNOTATIONS:    {"autoscaling.knative.dev/class":"kpa.autoscaling.knative.dev","autoscaling.knative.dev/minScale":"1","autoscaling.knative.dev/target":"1","internal.serving.kubeflow.org/batcher":"true","internal.serving.kubeflow.org/batcher-max-batchsize":"32","internal.serving.kubeflow.org/batcher-max-latency":"5000","internal.serving.kubeflow.org/batcher-timeout":"60","kubernetes.io/limit-ranger":"LimitRanger plugin set: memory request for container queue-proxy; cpu, memory limit for container queue-proxy","kubernetes.io/psp":"eks.privileged","serving.knative.dev/creator":"system:serviceaccount:kfserving-system:default"}

      ISTIO_META_WORKLOAD_NAME:      kfserving-custom-model-predictor-default-k5t6h-deployment
      ISTIO_META_OWNER:              kubernetes://apis/apps/v1/namespaces/example_namespace/deployments/kfserving-custom-model-predictor-default-k5t6h-deployment
      ISTIO_META_MESH_ID:            cluster.local
      DNS_AGENT:
      ISTIO_KUBE_APP_PROBERS:        {}
    Mounts:
      /etc/istio/pod from istio-podinfo (rw)
      /etc/istio/proxy from istio-envoy (rw)
      /var/lib/istio/data from istio-data (rw)
      /var/run/secrets/istio from istiod-ca-cert (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-75kkk (ro)
      /var/run/secrets/tokens from istio-token (rw)
Conditions:
  Type              Status
  Initialized       True
  Ready             False
  ContainersReady   False
  PodScheduled      True
Volumes:
  knative-var-log:
    Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
    Medium:
    SizeLimit:  <unset>
  default-token-75kkk:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  default-token-75kkk
    Optional:    false
  istio-envoy:
    Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
    Medium:     Memory
    SizeLimit:  <unset>
  istio-data:
    Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
    Medium:
    SizeLimit:  <unset>
  istio-podinfo:
    Type:  DownwardAPI (a volume populated by information about the pod)
    Items:
      metadata.labels -> labels
      metadata.annotations -> annotations
  istio-token:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  43200
  istiod-ca-cert:
    Type:        ConfigMap (a volume populated by a ConfigMap)
    Name:        istio-ca-root-cert
    Optional:    false
QoS Class:       Burstable
Node-Selectors:  online=true
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
                 online:NoSchedule
Events:
  Type     Reason     Age                  From                                                   Message
  ----     ------     ----                 ----                                                   -------
  Normal   Scheduled  2m18s                default-scheduler                                      Successfully assigned example_namespace/kfserving-custom-model-predictor-default-k5t6h-deployment-x2c6z to ip-100-120-28-190.us-west-2.compute.internal
  Normal   Pulling    2m17s                kubelet, ip-100-120-28-190.us-west-2.compute.internal  Pulling image "docker.io/istio/proxyv2:1.6.1"
  Normal   Pulled     2m16s                kubelet, ip-100-120-28-190.us-west-2.compute.internal  Successfully pulled image "docker.io/istio/proxyv2:1.6.1"
  Normal   Started    2m16s                kubelet, ip-100-120-28-190.us-west-2.compute.internal  Started container istio-init
  Normal   Created    2m16s                kubelet, ip-100-120-28-190.us-west-2.compute.internal  Created container istio-init
  Normal   Pulled     2m14s                kubelet, ip-100-120-28-190.us-west-2.compute.internal  Container image "kfserving/batcher:v0.4.0" already present on machine
  Normal   Pulling    2m14s                kubelet, ip-100-120-28-190.us-west-2.compute.internal  Pulling image "docker.io/istio/proxyv2:1.6.1"
  Normal   Started    2m14s                kubelet, ip-100-120-28-190.us-west-2.compute.internal  Started container batcher
  Normal   Created    2m14s                kubelet, ip-100-120-28-190.us-west-2.compute.internal  Created container batcher
  Normal   Pulled     2m14s                kubelet, ip-100-120-28-190.us-west-2.compute.internal  Container image "gcr.io/knative-releases/knative.dev/serving/cmd/queue@sha256:713bd548700bf7fe5452969611d1cc987051bd607d67a4e7623e140f06c209b2" already present on machine
  Normal   Started    2m14s                kubelet, ip-100-120-28-190.us-west-2.compute.internal  Started container queue-proxy
  Normal   Created    2m14s                kubelet, ip-100-120-28-190.us-west-2.compute.internal  Created container queue-proxy
  Normal   Pulled     2m13s                kubelet, ip-100-120-28-190.us-west-2.compute.internal  Successfully pulled image "docker.io/istio/proxyv2:1.6.1"
  Normal   Created    2m13s                kubelet, ip-100-120-28-190.us-west-2.compute.internal  Created container istio-proxy
  Normal   Started    2m13s                kubelet, ip-100-120-28-190.us-west-2.compute.internal  Started container istio-proxy
  Normal   Started    73s (x2 over 2m14s)  kubelet, ip-100-120-28-190.us-west-2.compute.internal  Started container user-container
  Normal   Created    73s (x2 over 2m15s)  kubelet, ip-100-120-28-190.us-west-2.compute.internal  Created container user-container
  Normal   Pulled     73s (x2 over 2m15s)  kubelet, ip-100-120-28-190.us-west-2.compute.internal  Container image "index.docker.io/lplrobert/kfserving-not-ready@sha256:6f0c491ad90c32b51ab13106c032c6aa8ad8050ab6317b7a59360a02539ff851" already present on machine
  Warning  BackOff    12s                  kubelet, ip-100-120-28-190.us-west-2.compute.internal  Back-off restarting failed container


the Android V2 embedding

To avoid unexpected runtime failures, or future build failures, try to see if this plugin supports the Android V2 embedding. Otherwise, consider removing it since a future release of Flutter will remove these deprecated APIs.

Is it possible to apply this change in the main branch to generate a new version? Or is the project already advanced?

Is it possible to apply this change in the main branch to generate a new version? Or is the project already advanced?

you need to change page via flutterSdk/pub-cashes/tflite and change all file as this link

@islom9797
it doesn`t work
can you help?

finally, I got the solution the problem was in the Gradle file of the file which has to be changed from compile to API since the new implementation of Gradle 7.0 and up should be changed to either API or implementation, compile =api.
The file in this location in windows
C:\Users\your_username\AppData\Local\Pub\Cache\hosted\pub.dev\tflite-1.1.2\android\build.gradle
or you can use the relative path
%AppData%\Local\Pub\Cache\hosted\pub.dev\tflite-1.1.2\android\build.gradle
If you couldn't find it in this location Gradle will print the location copy, paste it into Windows Run, and change the file.


Generate release manifests using quay images

Signed-off-by: Federico Gimenez<EMAIL_ADDRESS>
What this PR does / why we need it:
We are in the process of migrating from DockerHub to Quay.io, after verifying that the prow jobs for publishing images to Quay.io worked well for 0.36 this PR introduces the required changes to reference the artifact images published to quay in the release manifests.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

/release-note-none
/approve

/retest


Feature/ofdt 216 add backward compatibilty to cli

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ISR don't work.

When using ISR based freertos applications, when an ISR happens, the CPU hangs at a hardwault while(1) handler.
The issues is bypassed when replacing #if __CORTEX_M == 0U to #if 0 in vendor_interrupt.c file.
On EDUCIAA  ;)

Fixed by Franco


Implement std::io::Write for Pager.

Is your feature request related to a problem? Please describe.
I am trying to make function generic function that takes data and writes it to that output. Before I had it taking std::io::Write since that is what stdout implements. However this did not work when trying to add minus to my library since it only implements std::fmt::Write.
Describe the solution you'd like
std::io::Write to be an impl for Pager.

Although I am not opposed to this idea but I have some doubts.
First of all is that it might cause confusion for many people especially considering the fact that the signatures of std::fnt::Write and std::io::Write aren't similar in any way.
Second one is more of an implementation detail: currently minus has to format all the data like wrapping it according to available number of terminal columns and highlighting the search matches. All of these can only be done to valid UTF-8 encoded String. Also some of these operations are handled by other crates which also require the same. std::fmt::Write is the trait that works with these conditions in place while std::io::Write requires a &[u8] which may or may not be valid UTF-8. I know we can surely do a String::from_utf8_lossy() on the &[u8] but I can't say that's a good assumption to be made.

Ah that does make sense, seems like that uft8 issue does make it a lot harder.
Sounds like I just need to reconsider how I am using the library.
Thanks!


Add actions for rustup and sccache

Fixes https://github.com/risc0/risc0/issues/410

Didn't know about composite actions, looks great!


add scp command

adds an action to scp files from and to remote-hosts
use-case: i am trying to port some of my deployment scripts, and there i needed to fetch & pull files from remote.
samples:
Uploads-String to a file
scp(
		host: "dev.januschka.com",
		username: "root",
		upload: {
			:src => StringIO.new("SRC"),
			:dst => "/tmp/1.txt"
		}
	)

upload a file
scp(
		host: "dev.januschka.com",
		username: "root",
		upload: {
			:src => "/tmp/1.txt",
			:dst => "/tmp/1.txt"
		}
	)

download a file
scp(
		host: "dev.januschka.com",
		username: "root",
		download: {
			:src => "/tmp/1.txt",
			:dst => "/tmp/2.txt"
		}
	)

download a file but not to disk just to a var
file_out = scp(
		host: "dev.januschka.com",
		username: "root",
		download: {
			:src => "/tmp/1.txt"
		}
	)
puts "#{file_out.inspect}"

download a folder
scp(
		host: "dev.januschka.com",
		username: "root",
	   	download: {
    	  :src => "/root/dir1",
      		:dst => "/tmp/new_dir"
    	}
)

upload a folder
scp(
		host: "dev.januschka.com",
		username: "root",
	   	upload: {
    	  :src => "/root/dir1",
      		:dst => "/tmp/new_dir"
    	}
)

That's great :rocket: Similar to the other PRs, please remove the comments, add information to the Actions.md. The Actions.md should be a very basic, very common example.

rubcop is clean
tests pass
added Action.md entry
removed new dependencie - checking now using Action.verify_gem

@KrauseFx

feedback adopted
merge conflict solved

Looks good, thanks for addressing my feedback, however we have a merge conflict again :cry:

ok i removed the Actions.md from this branch - as if you merge this one - the other PR's conflict too
you can merge this branch, and later on take the right block from   (https://gist.github.com/hjanuschka/96cb3129fd0d839b7a56) - or take a look at my combined docs PR.

https://github.com/fastlane/fastlane/pull/1207
@KrauseFx

Perfect, thank you! :+1:


If a view is a UIWindow, then don't re-wrap it in a UIWindow before call to drawViewHierarchy

When usesDrawViewHierarchyInRect is YES, the UIView is added to a UIWindow before it is drawn into the image context. However, if the UIView is a UIWindow, then wrapping it in a window will cause issues.
This simply uses the view directly if it is already a UIWindow.

commented + squashed! :)


simplify the apps image on homepage

https://horizontalsystems.io/assets/images/dapps.png
I find it overwhelming and bloated

[x] remove borders
[x] remove text
[x] make it smaller in width/height
[x] don't use black (or close) colors. the text is primary element here

https://github.com/horizontalsystems/horizontalsystems.github.io/commit/650f2d08724b89ff671479fb613cbfda7f56ff46


Missing service environment variables while starting pod

While debugging #5091 I noticed that when I'm creating guestbook application by running ./cluster/kubectl.sh create -f examples/guestbook there is a chance that frontend pods come up before information about environment variables of redis is propagated. In such case frontend can't connect to database during its whole life.
It's actually more general problem, since most of complex application might be affected by this. Also I think create a set of resource (especially by specifying the directory of their config files) should just work no matter of the order of creation.
I can see few solutions of such problem:

Get rid off HOST:PORT stuff and start using DNS service instead.
Add ability to wait for such information being propagated.
Injecting environment variables to container somehow(?).

@brendanburns @bgrant0607 @thockin Any comments?
There is a new example k8petstore added by @jayunit100 which uses HOST:PORT environment.

Known problem: #1768, #4245.
Even if we ensured the services were created first (which is a hack that might actually work pretty well), I'm not entirely sure that's sufficient to absolutely guarantee the Kubelet will see the services before it sees new pods that depend on them.
I would eventually like to get rid of the environment variables, but changing to DNS won't entirely eliminate the need for sequencing/dependencies in legacy apps.
Let's discuss further on #4245.

Crash and restart until you get your service env vars.

I don't agree with you Eric. It would be problematic for users to handle the case in each application they are using. The internal cluster problems should not be visible for the users.
Moreover relying on IPs is actually not the best idea since IPs are rather temporary than permanent. The user don't want to watch env variable for changes. For example the issue #4914 was caused by changed IP.

Closing this as a duplicate.


Add note to leave a blank line before/after each Rmarkdown chunk

Students are still not doing this, which means:

it's harder to see where one chunk starts/finishes, which has led some students to end up with un-finished chunks, and
students often end up with text starting on the same line as a figure sits, rather than on a new line below.

Will be fixed with #75


Refactor EconomyTransactionEvent

Part of the Economy API refactor.
Fix https://github.com/SpongePowered/SpongeAPI/issues/1501
EconomyTransactionEvent is now split between
Pre: is fired BEFORE the transaction has been processed (it can still fails and is cancellable).
Post: is fired AFTER the transaction has been processed. This is read-only and the transaction result can be used to reliably check the result of the transaction.

Looking back at this, I missed something about EconomyTransactionEvent.Pre and getAccount. Specifically: while the method works fine for deposit/withdraw, it's unclear for transfer since that involves two accounts. Something to retrieve the other account is needed.
Do we add a method returning an Optional ? A subclass for the event ?
Input wanted.

Would it be better to just have an event that can handle multiple transactions at once? Rather than having a getAccount() and getCurrency() etc., have a collection of ProposedTransactions (or whatever) that contains this info, each one being a simple deposit or withdraw That way, a transfer is one event and the same event, and a plugin listening to this can treat/use it the same way as other plugins.
This could also allow economy plugins to build a complex web of transactions that might happen - a currency exchange plugin might allow two players to exchange their currencies so you might have two deposits and two withdrawals that all depend on each other (two accounts, two currencies, deposit and withdrawal on each side).

I've shifted the base branch here to API-9, but is this something we want to revisit, or are we better off closing and thinking about Economy in a wider sense?


[PE-D][Tester B] Functionality of find Command is Incorrect in User Guide

The functionality of the find command differs from the user guide. Currently, it searches in both company names and application names.
However, the user guide states that it only the name is searched:

Steps to Replicate:

Add a company (e.g. add n/Apple<EMAIL_ADDRESS>Apply to the company with the apply command (e.g. apply 1 n/Software Engineer Intern d/Requires knowledge of ReactJS and ExpressJS)
Use the find command with the application title as keyword instead of the company name

Expected Result: The added company should not be listed.
Actual Result: The added company is listed, because the application name is found.
Example result of running find Developer:

Labels: severity.Medium type.DocumentationBug
original: RobotWizzard/ped#4

duplicate of #219


Default new keg size to last size used

Web UI complement of https://github.com/Kegbot/kegbot-android/issues/92

Obsolete/fix later.


[Feature][resource] Add doc about how to config local file system or and local type of file system

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Currently, our config file of the resource center only supports s3 and hdfs. https://github.com/apache/dolphinscheduler/blob/0e3cafec1d0a6529c6bb5371429a9b51bd60fd5a/dolphinscheduler-common/src/main/resources/common.properties#L22
but our docs https://dolphinscheduler.apache.org/en-us/docs/latest/user_doc/guide/resource.html said we support a local file system.
we could find some config demo in https://github.com/apache/dolphinscheduler/issues/5099. and we should add config demo about local file system by:

Just change our doc and add the demo config according to https://github.com/apache/dolphinscheduler/issues/5099
Add new type named local(a shortcut to set config resource.storage.type=HDFS and fs.defaultFS=file:///) to resource.storage.type and add some docs about it.

Use case
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

WDYT? @caishunfeng @ruanwenjun @nobolity what is your prefer solution or do you have a better solution?

WDYT? @caishunfeng @ruanwenjun @nobolity what is your perfer solution or do you have a better solution?

Both the two solutions are good to me.

I think it's better to add a local type, which is easier to understand. But the complexity and difficulty of the adaptation need to evaluate.

I think it's better to add a local type, which is easier to understand. But the complexity and difficulty of the adaptation need to evaluate.

I think so, and I will go depth next week when I have time.

i will solve it @zhongjiajie

i will solve it @zhongjiajie

I have assigned to you. Looking forward to your contribution.


Vendor translations do not load properly

Laravel Version: v5.3.23
PHP Version: 7

Description:
Hi, I am trying to load translations from resources/lang/vendor, but I just get as result the string related to their keys.
This is what I have so far:
Translations folder
resources/lang/vendor/gocanto/en/globals.php whithin this file, I have something similar to this 'foo' => 'bar'
How I am trying to load this key
trans('gocanto::globals.foo')

Result
gocanto::globals.foo

I referred to the doc before placing this in here, as well as laracas forum.

Have you registered the vendor namespace properly?
$this->loadTranslationsFrom(__DIR__.'/path/to/translations', 'gocanto');

Yes sir, I actually did.
This is what I have in my service provider:
 $this->loadTranslationsFrom(__DIR__ . '/../resources/lang', 'gocanto');

this is my package folder structure
/resources/lang/
src/servicesprovider.php

@gocanto can you share what the issue was?

I still have and relly do not know what the problem is. This is my scenario. I have a package that provides translations. Within it, I have all the settings needed to publish them under a custom namespace, as showed above.
Now, it happens to be that I do not have access to these translations calling them as so php trans('gocanto::foo.bar) from my package. But, I do when I call them from the app which implements the package.
I do not know if you understand what I just said.

Well a package alone doesn't work :) It needs an application.

So, what's the best way to call these trans from the package?


docs(node-diagram): add routing api

Description
Add routing api in the node diagram
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

wow, thanks!

/planning/mission_planning/change_route
/planning/mission_planning/change_route_points

are missing?

it may be not necessary to write and make confusing but /planning/mission_planning/goal is published directly from rviz
$ ros2 topic info /planning/mission_planning/goal -v
Type: geometry_msgs/msg/PoseStamped

Publisher count: 1

Node name: rviz2
Node namespace: /
Topic type: geometry_msgs/msg/PoseStamped
Endpoint type: PUBLISHER
GID: <IP_ADDRESS>.9c.c0.36.4f.38.d3.25.d<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.00
QoS profile:
  Reliability: RELIABLE
  History (Depth): KEEP_LAST (5)
  Durability: VOLATILE
  Lifespan: Infinite
  Deadline: Infinite
  Liveliness: AUTOMATIC
  Liveliness lease duration: Infinite

Subscription count: 1

Node name: routing_adaptor
Node namespace: /default_ad_api/helpers
Topic type: geometry_msgs/msg/PoseStamped
Endpoint type: SUBSCRIPTION
GID: 01.10.d2.a5.ad.ae.cd.e9.d<IP_ADDRESS>b.<IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>
QoS profile:
  Reliability: RELIABLE
  History (Depth): KEEP_LAST (3)
  Durability: VOLATILE
  Lifespan: Infinite
  Deadline: Infinite
  Liveliness: AUTOMATIC
  Liveliness lease duration: Infinite

@kosuke55

/planning/mission_planning/change_route
/planning/mission_planning/change_route_points
are missing?

Thank you! I updated.

/planning/mission_planning/goal is published directly from rviz

I'm being confused. How these messages are differentiated?

Thank you! I updated.

change_route and change_route_points are called from routing
https://github.com/autowarefoundation/autoware.universe/blob/477ce95a1975773e426458f986b9a8a8c43a89f7/system/default_ad_api/src/routing.cpp#L36-L37

I'm being confused. How these messages are differentiated?

It's just FYI :pray:
This is a message for directly inputting a goal without api service, and is used in rviz's SetGoal button
The flow is
[rviz2] -/planning/mission_planning/goal -> [/default_ad_api/helpers/routing_adaptor] -set_route_points-> [/default_ad_api/node/routing] -set_route_points-> [mission_planner]
I think the topic name remains the same as in the old interface, so it might be better to rename to like rviz/routing/goal, but need to consider compatibility with other tools.

so it might be better to rename to like rviz/routing/goal

https://github.com/autowarefoundation/autoware.universe/blob/main/system/default_ad_api_helpers/ad_api_adaptors/launch/rviz_adaptors.launch.xml#L12
rviz config

but need to consider compatibility with other tools.

I think that main tools already use api, but some tools still use the topic like
https://github.com/tier4/autoware-functional-tests/blob/main/autoware_functional_tests/autoware/pub.py#L27-L29
so need to check the scope of influence.

I think that main tools already use api, but some tools still use the topic like

ah, scenario_simulator_v2 also uses the topic, but will move to use api in the near future.
https://github.com/tier4/scenario_simulator_v2/blob/master/external/concealer/include/concealer/field_operator_application_for_autoware_universe.hpp#L112

@kosuke55 Thank you for the information. I updated the diagram. Would you review again?

not the image of https://github.com/autowarefoundation/autoware-documentation/pull/450#issuecomment-1712788163 but your updating is correct..!:pray:


Replaced Godeps with glide

I did the same as for most other appc repositories, but this is the only one where I'm not able to get the deps running correctly, currently I'm getting the below error on build:
Building acpush...
gopath/src/github.com/appc/acpush/vendor/github.com/spf13/cobra/command.go:1161: c.Flags().HasAvailableFlags undefined (type *pflag.FlagSet has no field or method HasAvailableFlags)
gopath/src/github.com/appc/acpush/vendor/github.com/spf13/cobra/command.go:1166: c.PersistentFlags().HasAvailableFlags undefined (type *pflag.FlagSet has no field or method HasAvailableFlags)
gopath/src/github.com/appc/acpush/vendor/github.com/spf13/cobra/command.go:1172: c.LocalFlags().HasAvailableFlags undefined (type *pflag.FlagSet has no field or method HasAvailableFlags)
gopath/src/github.com/appc/acpush/vendor/github.com/spf13/cobra/command.go:1178: c.InheritedFlags().HasAvailableFlags undefined (type *pflag.FlagSet has no field or method HasAvailableFlags)
gopath/src/github.com/appc/acpush/lib/lib.go:176: undefined: discovery.DiscoverEndpoints

The reason this doesn't appear to build right now is that the versions being pulled in by glide (as per the glide.yaml) are far newer than the versions vendored with Godeps, and there are breaking changes in these libraries. I suggest changing the glide.yaml to reference the versions Godeps is using, and we can look at updating the versions to something a little newer after this PR.

Hum, when I try to downgrade the deps than it fails to fetch speter.net/go/exp/math/dec/inf as this repos won't exist anymore.


Add support for 3.13t (free threading)

Also drop support for the nogil 3.9 fork.

I'll trust you on this. I'm working on enabling 3.13 CI on viztracer. After that, I'll see if github action supports 3.13t and if the test can actually pass.

actions/setup-python unfortunately still doesn't support 3.13t: https://github.com/actions/setup-python/issues/771, but deadsnakes/action does.

Seems like an open discussion. It would be nice if actions/setup-python can support it directly, however, it's not the end of the world if I had to use another action to set up 3.13t.


feat: add leash holding support to the entity api

Is there any reason to limit an entity to only being leashed by a single entity? In vanilla you cannot leash an entity already held by someone else, but I assume this is just a server check?

Is there any reason to limit an entity to only being leashed by a single entity? In vanilla you cannot leash an entity already held by someone else, but I assume this is just a server check?

The client only supports 1 leash holder, the most recent packet sent overrides who is holding the leash on the client


(L) As a AAA developer I want Continuous Integration to run on each PR so that new code meets a certain standard

Acceptance Criteria

Continuous Integration is using the tox tool to orchestrate steps.
Code base complies with PEP8 (flake8)
Code base is uniformly formatted (black)
Code base is secured (bandit)
Dependencies licences are checked (liccheck)
Dummy tests ( Unit & Integration) to make sure they are run in CI
Unit tests and coverage are run
Integration tests are run.

DOD
All above completed

This user story is actually not entirely finished, we need the CentOS people to activate our project in Centos CI. It should be tracked by their ticket #16901.

Ok , lets create a subtask for this ,is that possible on github?


Nelson v0.4.10

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

Microsoft Reviewers: Open in CodeFlow

During installation testing, this app triggered a Microsoft Defender SmartScreen error.
We are notifying<EMAIL_ADDRESS>for investigation.

I can understand but it is boring each time that I post a new version to submit to wait.

Any news ?


Fix varint encoding length of witnessUtxo proofs

This PR ensures that we do not add extra bytes to witnessUtxo keyVal encoding while the proofs are undefined. It fixes the decoding process of unconfidential witnessUtxos.
@altafan @tiero please review

@louisinger I tried to run tests and one fails because the psbt in hex string is not the expected one. The fixture should be updated, can you do that, please?


Update demo links

I've trashed our old demo site, which will have broken links as a consequence in the next few days, until I came up with better way to showcase the features.
Assigning this to myself to fix. Leaving here as a reminder.

Done.


Support commented out config file

Modify parser to produce an empty List[Directive] if the input is nothing but comments as opposed to failing to parse

Ping. Would be really nice to remove this line in quasar.

Both issues fixed in #51.  Thanks!

Awesome! Thx!


kruize scalability tests are failing with connection errors

Scalability test failed with the below issue on openshift:
An error occurred while connecting to HTTPConnectionPool(host='<host addr>', port=80): Max retries exceeded with url: /createPerformanceProfile (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f8c6f1aae80>: Failed to establish a new connection: [Errno 99] Cannot assign requested address',))
### Experiment: scaleexp_2: Progress: 2/100  86/96
An error occurred while connecting to HTTPConnectionPool(host='host addr', port=80): Max retries exceeded with url: /createPerformanceProfile (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f8c6f183ef0>: Failed to establish a new connection: [Errno 99] Cannot assign requested address',))
### Experiment: scaleexp_2: Progress: 2/100  87/96

To recreate the issue:

git clone the tests from https://github.com/kruize/autotune/pull/832
cd autotune/tests/scripts/remote_monitoring_tests/scale_test
./remote_monitoring_scale_test.sh -c openshift  -i chandra25ms/autotune_operator:pr859   -u 10000 -d 2 -t 40000 -r /tmp/results-scale-test-openshift

@chandrams Can you please confirm if this is still correct ?

@msvinaykumar - Yes seen on scalelab but with the scalability test changes in PR 832, have you added your scalability test changes on top of it? I will test it again on scalelab.

@chandrams yes added scalability scripts
you can run like this to create experiments for 15 days 5k experiments
for i in {1..20}; do nohup time ./bulkScalabilityWrapper.sh --ip kruize-openshift-tuning.apps.kruiz.dsal.lab.eng.tlv2.redhat.com --port 0 --count 250,24 --minutesjump 15 --initialstartdate 2023-01-01T00:00:00.000Z --name test100k15daysT1-${i} --limitdays 15 --intervalhours 6 >> /tmp/test100k15daysT1-${i}.log 2>&1 & done ;

This issue is no longer seen with the updated scripts, tested on scalelab cluster


The text is not reliable on blog (why yellow text on white bg).

Talk is cheap, send fix