MKLDNN: conv2d forward DNN primitive reuse enhancement

This enhancement enables MKL primitive reuse for conv2d forward operation to reduce the overload of
repetitive creations of primitives. It

Improves MKL op based training performance
Improves MKL op based inference performance, especially for small batch size including BS=1 case

@gzmkl I recommend reading through https://google.github.io/styleguide/cppguide.html.

Hi Rasmus,
I have done as much as I can based on valuable suggestions from you and your team.
The MKL DNN reuse thing is basically rewriting the original integration code. So there are lots of code changes
by multiple peoples, some of whom did the TF contribution first-time.
I will make sure your suggestion will be reflected in near future PRs (primitive reuse for conv bwd, batchnort, relu etc).
Best Regards,
GZ
From: Rasmus Munk Larsen<EMAIL_ADDRESS>Sent: Tuesday, April 17, 2018 6:21 PM
To: tensorflow/tensorflow<EMAIL_ADDRESS>Cc: Zhuang, Guozhong<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [tensorflow/tensorflow] MKLDNN: conv2d forward DNN primitive reuse enhancement (#17943)
@rmlarsen requested changes on this pull request.

In tensorflow/core/kernels/mkl_conv_ops.cchttps://github.com/tensorflow/tensorflow/pull/17943#discussion_r182284013:

+template
+class Conv2DFwd : public DnnOp {

public:

explicit Conv2DFwd(const ConvFwdDimensions& convFwdDims) {

fwd_stream_.reset(new stream(stream::kind::eager));

// create conv primitive

if (conv_fwd_ == nullptr) {

 Setup(convFwdDims);

}

}

~Conv2DFwd() {}

// Convolution forward execute with bias

void Execute(T* src, T* w, T* b, T* dst) {

Can you make these parameter names more readable as well?

In tensorflow/core/kernels/mkl_conv_ops.cchttps://github.com/tensorflow/tensorflow/pull/17943#discussion_r182284042:

filter_mem_->set_data_handle(static_cast<void*>(w));

bias_mem_->set_data_handle(static_cast<void*>(b));

dst_mem_->set_data_handle(static_cast<void*>(dst));

fwd_stream_->submit(fwd_primitives_);

// after exec, set data handle back

src_mem_->set_data_handle(DummyData);

filter_mem_->set_data_handle(DummyData);

bias_mem_->set_data_handle(DummyData);

dst_mem_->set_data_handle(DummyData);

return;

}

// Convolution forward execute without bias

void Execute(T* src, T* w, T* dst) {

eschew abbreviation

In tensorflow/core/kernels/mkl_conv_ops.cchttps://github.com/tensorflow/tensorflow/pull/17943#discussion_r182284106:

}

// MKLDNN memory

std::shared_ptrmkldnn::memory src_mem_;

std::shared_ptrmkldnn::memory filter_mem_;

std::shared_ptrmkldnn::memory bias_mem_;

std::shared_ptrmkldnn::memory dst_mem_;

std::shared_ptrmkldnn::stream fwd_stream_;

std::vectormkldnn::primitive fwd_primitives_;

// desc & prmitive desc

std::shared_ptrmkldnn::convolution_forward::desc fwd_desc_;

// memory desc

std::shared_ptrmkldnn::memory::desc src_md_;

s/md/mem_desc/g ?

In tensorflow/core/kernels/mkl_conv_ops.cchttps://github.com/tensorflow/tensorflow/pull/17943#discussion_r182284191:

     auto conv_prim_desc = convolution_forward::primitive_desc(conv_desc,

                                                             cpu_engine);

     AllocateOutputTensor(context, conv_prim_desc, output_dims_mkl_order,

                          tf_fmt, &output_tensor);

     // Set data handle for output.

     output.SetUsrMemDataHandle(output_tensor);

     Tensor* filter_out_tensor = nullptr;

     AllocateFilterOutputTensor(context, conv_prim_desc,

           TFShapeToMklDnnDims(filter_tf_shape),

           &filter_out_tensor);

     PrepareAndExecuteNet(conv_prim_desc, &src, &filter,

                         nullptr, &output, filter_out_tensor);

   ConvFwdDimensions convFwdDims(src_dims, filter_dims, NONE_DIMS,

       dst_dims_mkl_order, strides, dilations, padding_l, padding_r);

s/l/left/ s/r/right/

In tensorflow/core/kernels/mkl_conv_ops.cchttps://github.com/tensorflow/tensorflow/pull/17943#discussion_r182284229:

   }

} catch (mkldnn::error& e) {

 // allocate output tensors output_tensor and filter_out_tensor

 std::shared_ptr<mkldnn::convolution_forward::primitive_desc>

 conv_fwd_pd = conv2d_fwd->fwd_pd_;

What is "pd"? write out.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/tensorflow/tensorflow/pull/17943#pullrequestreview-113049566, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ab3J2-AwHimWA_0vICHfNgGBY4X4nZLjks5tppTvgaJpZM4S4K7m.

@gzmkl Thank you for your patience.

Rasmus,
Thank you very much for all the suggestions and helps. Woe will track the one “to-be-refactored” item in mind and conform to the code style
In next PRs.
Thanks
GZ
From: Rasmus Munk Larsen<EMAIL_ADDRESS>Sent: Friday, April 20, 2018 10:40 AM
To: tensorflow/tensorflow<EMAIL_ADDRESS>Cc: Zhuang, Guozhong<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [tensorflow/tensorflow] MKLDNN: conv2d forward DNN primitive reuse enhancement (#17943)
@rmlarsen approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/tensorflow/tensorflow/pull/17943#pullrequestreview-114065247, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ab3J23vX6GqyLgjfNLoPPnpDsvEkVRDvks5tqh12gaJpZM4S4K7m.


Add functionality to replace text

Forward port of 8928445bef9dc65b521eaa8999be765e3e3168f4 by https://github.com/ArifRasim

@foarsitter Do you have any idea, why tests are broken?

Not in particular but it exit's with this message: https://github.com/py-pdf/pypdf_table_extraction/actions/runs/10053640002/job/27786774072?pr=23#step:11:260
Are they succeeding locally?

Are they succeeding locally?

TBH, I did'nt test it locally yet... 😝


Setup v1.3 documents

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Refresh the latest documents to the coming v1.3.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The documents file will be refreshed according to #116

/assign @Poor12


Action and Func Delegate types in C# with Tests

Code sample for my Eval article for Action and Func C# Delegate Types.
All code sample can be found here: CodeMazeGuides1\csharp-advanced-topics\ActionAndFunc

Pull request by Caleb Igwe<EMAIL_ADDRESS>


Updated Main Editor, ChartEditor.cs, GameSettings.cs, and SettingsController.cs

This allows all drum stems to be selectively muted.
Despite only selecting these 4 files, the other files got added to the commit. Pretty sure they're just leaks.

Gonna have to redo my changes to main editor as you just published a new build, so hold off on merging this.

Commits are way too messy. Has a lot of changes listed that don't actually change anything, most likely just changing line endings. This will make it difficult to look up history changes in these files later on, as well as see what these commits are actually doing. You may need to fix up your line ending settings in Git/your IDE. Only commit the parts of the files as well as files that were actually changed. Don't commit material changes as well.
Would suggest making a fresh branch and redoing these changes. I've pulled the settings menu into it's own prefab so that the menu can be edited without having to commit changes to the main scene. Prefab can be found under Moonscraper Chart Editor/Assets/Prefabs/UI/Game Menus/Settings.prefab. Note that the prefab canvas view is different from in game canvas view, so the prefab view looks shrunk even though it renders fine in-scene.


dbeaver/dbeaver#34819 Fix generate ddl context menu

Now Generate DDL appears properly in the window

Verified


ImportError: attempted relative import with no known parent package

python3 bbrf.py
Traceback (most recent call last):
  File "/home/kali/software/bbrf-client/bbrf/bbrf.py", line 48, in <module>
    from . import bbrf_api
ImportError: attempted relative import with no known parent package

After a fresh install. A workaround is removing "from ."

Hi @pdelteil - have you installed with pip install bbrf? If so you shouldn't have to try running python3 bbrf.py anymore, but you can just run bbrf as a standalone command from the command line.
If you had a previous version of BBRF client installed, make sure you remove the bash function that it needed from your .bash_profile or .functions (or wherever you defined it) first! Once the function is removed, open a new terminal and the command bbrf should work.

We discussed this via Twitter and this issue was resolved.

Thanks.


WebSockets?

Tim Caswell at js-git stated, "I would recommend using the git pack-protocol over secure websockets. It would essentially be the same as the ssh protocol, but authenticate using normal https methods and tunnel over websocket binary messages."
I'm wondering what you might think of this for isomorphic-git?
(Very excited to try it out, btw, when I get a chance...)

Hmmm... WebSockets would actually be a very good channel. I currently have pretty stable client side support for the smart HTTPS protocol. I would need to do some extra work so that it did the server side of the protocol as well (it's asymmetrical) but I've been meaning to do that.
Long story short - I already plan to add support for the git pack-protocol over WebRTC for direct P2P cloning. WebSockets are actually a little simpler than WebRTC, so I could implement it on WebSockets first, then once that's working go for the P2P protocol.
To make a short story longer... if you can use a custom WebSocket library for your application, you probably can also use the regular "smart" HTTP protocol in your application, so the main advantage that WebSockets give you is probably speed / latency for multiple packfile requests.
To make the story about something completely different, have you taken a look at my proxy server for getting around CORS? https://zeit.co/wmh/cors-buster/jfpactjnem/source?f=index.js That's what I've been using so my web apps can push & pull from Github.

That sounds great... WebRTC sounds awesome too...
Your server is indicating "An error has occurred" with the following in Chrome's console:
Version: 4.21.2
app.js:2 Check out our code here: https://zeit.co/oss
app.js:2 Have a great day! 📣🐢
app.js:29 500 - Internal Server Error.
  undefined
  (anonymous) @ app.js:29
Failed to load resource: the server responded with a status of 500 ()   source

A pity Github (and apparently Bitbucket) don't place nice with CORS, so a CORS proxy server sounds quite useful here. FWIW, if you hadn't seen the larger context of the conversation I referenced, there is a Firefox add-on and a Chrome extension to get around this, even if it wouldn't solve the problem for one's regular users.
The following is off topic but just if it may be interesting...
Given your interest in decentralized access to local data sources on the web, I might just mention my own browser add-on, webappfind, which allowed for one to open files on one's desktop (whether by double-click or "Open with...") immediately into a web app without need for drag and drop. (The web app was indicated either by instructions in a local filetypes.json file or by protocol handler registration, and the web app would add a window.onmessage handler to listen for the file contents and optionally be given the privilege to write back to the file (and that file only) using postMessage(data, '*').)
I had a working version before Firefox updates broke it, but I found it could now be possible to reimplement given that the cross-browser-directed WebExtensions project of Mozilla can support Native Messaging (potentially working in Chrome as well) and I was able to get a branch confirming that Native Messaging will work (conveniently being able to use Node.js), but I haven't done the full rewrite to reimplement the old behavior. But just sharing if you might find the possibility interesting.

Interesting. Zeit "wakes up" hibernated servers (within a few seconds)... but apparently only if you visit the actual server, not the "view the source code" link I gave you. Also the view source code link appears not to work in Incognito mode, so it might not be visible to anyone except to me. :( Pity, since I was going for "immutable server with transparent source code so you can relatively trust it won't steal your passwords".
Here's the proxy: https://cors-buster-jfpactjnem.now.sh/ The code is https://github.com/wmhilton/cors-buster/tree/develop-2.0 but I haven't updated the README just the code.

npm.im/webappfind sounds amazing. I did a similar kind of hack for Atom back in the day, and recently played around with navigator.registerProtocolHandler, and generally that sounds like something I would use. I actually plan to use a browser-based IDE as my full-time text editor in the future. I implemented drag and drop, but it would be nice to have a tool that could install "webapp shims" so that I could right-click "Open With..." anything. You can sort of do it on mobile by registering a protocol scheme as part of the Progressive Web App manifest, but I don't know of a real way to do it on the desktop.

I'm closing this because I'm trying to tidy up the github issues, but I highly encourage you to join the new Gitter community discussion room I made! https://gitter.im/isomorphic-git/Lobby

Hey @wmhilton, sorry for not participating on Gitter, hope you don't mind it too much. You mention some server side work in this issue, I am wondering if in the future it will be possible to use this package to create a mock Git server, so in my tests, I can hand the client a Git URL backed by a server instance from the very same package and implement mock response to the Git operations the client requests (like creating files on the fly for tests).

@TomasHubelbauer Mocking a git server is probably beyond the scope of this project; if I add server capabilities they would be real server capabilities not just mocks. I'm currently doing something similar in my test suite though for mocking server responses, using the nock library and piping the request to the stdin of a git-http-backend process, then piping the stdout back into a mock HTTP response. You might find that helpful:

https://github.com/isomorphic-git/isomorphic-git/blob/master/__tests__/__helpers__/http-backend.js
https://github.com/isomorphic-git/isomorphic-git/blob/master/__tests__/test-push.js

FWIW, I've got an early version of WebAppFind working now (the browser add-on I mention above allowing one to open files from the desktop directly into a desired web app), but the reimplementation is, for now, Mac-only (and Firefox only, despite being a WebExtension).
In the future, I hope to allow granting of directory-level permissions (and persistence of those permissions), which could, in theory, allow isomorphic-git to view/operate on, and be in sync with, a desktop-based repository.
My next step is a video tutorial, as there is not much for docs (and what there is is outdated). But just something you might keep in the back of your mind as far as future possibilities...


[release-v1.6] Improve ConsumerGroup finalization for missing resources

Cherry-pick of https://github.com/knative-sandbox/eventing-kafka-broker/pull/2872/files
Signed-off-by: Pierangelo Di Pilato<EMAIL_ADDRESS>

/lgtm
/approve


Check: CKV2_GHA_1: "Ensure top-level permissions are not set to write-all"

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
I'm using a reusable workflows and I set the permissions inside specific jobs for building and deploying images, and the secrets are inherited properly.
permissions:
 contents: read
 id-token: write
I'am not explicitly specifying "write-all" as a top level permission , but the linting check is still failing. May be the linting tool is flagging the  specific permissions granted within the workflow as potentially problematic, even if "write-all" is not explicitly stated.
Expected Behavior
As a previous version of the linting tools the workflow should run without encountering any errors or github actions failures during the execution.
We only actualize the actions version for the jobs into the pipelines and updated the linting version due to dependabot updates.
Super-Linter version
Since v6.0.0 to last

Relevant log output
Error: -09 16:00:25 [ERROR]   Errors found in CHECKOV
Error: -09 16:00:25 [ERROR]   Command output for CHECKOV:

dockerfile scan results:
Passed checks: 246, Failed checks: 0, Skipped checks: 0

github_actions scan results:
Passed checks: 188, Failed checks: 8, Skipped checks: 0

"Ensure top-level permissions are not set to write-all"
	FAILED for resource: on(Deploy to example)
	File: /.github/workflows/cd-deploy-to-example.yml:0-1

Steps To Reproduce
The checks failed in the github actions scan, everything is OK in the codebase.
Anything else?
No response

Hi @UsernameAlvarez !
This seems like an issue with Checkov, not super-linter itself.
I would raise this in their repository.


Compatibility with units that do now show indoor temperature

Hi, would you be able to make this work more nicely with units that do not support the indoor temperature, as this now both creates and error in the log over an over again, as well as shows 0C as the indoor temerature, which off course is false.

Which model do you use? I assume that your indoor unit still has a temperature sensor (so that it knows when to cool/heat) but reports it differently or doesn't expose it via the API?

Hi, I've got a CS-Z50TKR Aero Series. (using the CZ-TACG1 wifi controller kit).   Internal unit temperature on the accessory icon is always 0 and the logs say "Temperature State is Unavailable".  Did not have this issue with the previous plugin by codyc1515.  Hope this helps.

Please switch on debug mode and share some of your logs here. Specifically the responses from the Comfort Cloud service. This should give us a good idea of what we are missing.

Have the same issue (and same combo of unit/wifi controller).  The previous plugin did show the internal unit temperature for these.
Setting to debug though still only logs [Homebridge Panasonic AC Platform] Temperature state is not available

Thanks! What would be a desired outcome in your case, i.e. what would you like the Home app to display?

That’s an interesting one. Looking at the code for the old plug-in it also reported 0 when it received 126 from Comfort Cloud.
From a UX perspective I’m not sure what’s better. In the absence of a valid value the options might be continue to report 0, or perhaps report the target temperature? Neither would be accurate though.

Did previous versions of the old control do that?   I might have a look at a few other controls and see what they do.
Sent from my iPhone

On 27/07/2022, at 16:47, 488-NotAcceptableHere @.***> wrote:

That’s an interesting one. Looking at the code for the old plug-in it also reported 0 when it received 126 from Comfort Cloud.
From a UX perspective I’m not sure what’s better. In the absence of a valid value the options might be continue to report 0, or perhaps report the target temperature? Neither would be accurate though.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.

I might have a look at a few other controls and see what they do.

That's great - please report back if you find out more.

From a UX perspective I’m not sure what’s better. In the absence of a valid value the options might be continue to report 0, or perhaps report the target temperature? Neither would be accurate though.

For transparency and clarity, an option would be to report a special value, like -99. But once you know that your system doesn't report on the indoor temperature, that approach doesn't provide any utility any longer.
With that in mind, the best option might be to display the target temperature, even though that would confuse the status icon of the Home app (it would show 'idle' because it thinks the target temperature has already been reached).

FYI in the Cloud Comfort app no temp is reported for internal (has a dash) only external.

Yes, this is correct. According to the documentation, indoor temperature is not supported by all models. Strange, as the indoor unit must measure indoor temperature, but apprently not part of the API/output to Comfort Cloud.

From: rabbadabba @.>
Sent: Sunday, July 31, 2022 2:56:08 AM
To: embee8/homebridge-panasonic-ac-platform @.>
Cc: mstendah @.>; Author @.>
Subject: Re: [embee8/homebridge-panasonic-ac-platform] Compatibility with units that do now show indoor temperature (Issue #31)
FYI in the Cloud Comfort app no temp is reported for internal (has a dash) only external.
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fembee8%2Fhomebridge-panasonic-ac-platform%2Fissues%2F31%23issuecomment-1200315077&data=05|01||1bd68260b05e45f67aa808da72871a12|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637948221842790662|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=NNWRGio5FcHB1LdvMNg0nWoW3bYhOThxuDARr9jD1t4%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAET22DUFJXFJRXDB2XBVAA3VWW6JRANCNFSM52XWQ6JA&data=05|01||1bd68260b05e45f67aa808da72871a12|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637948221842790662|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=xoTyqad3qU3llwl7Jx%2BW0HMVtEj3FuiXdPYE9C%2BKj5k%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

Hi, I have a Panasonic CZ-TACG1 WiFi Comfort Cloud remote connected to my Panasonic UZ12-SKE indoor unit.
-mikael
From: embee8 @.>
Date: Monday, 25. July 2022 at 3.13
To: embee8/homebridge-panasonic-ac-platform @.>
Cc: mstendah @.>, Author @.>
Subject: Re: [embee8/homebridge-panasonic-ac-platform] Compatibility with units that do now show indoor temperature (Issue #31)
Which model do you use? I assume that your indoor unit still has a temperature sensor (so that it knows when to cool/heat) but reports it differently or doesn't expose it via the API?
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fembee8%2Fhomebridge-panasonic-ac-platform%2Fissues%2F31%23issuecomment-1193426177&data=05|01||4361d8704ac8436982a208da6dd28994|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637943048265815682|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=USokdieh20cGy8fzIIoqpCcpXJy%2BjmcdO%2FpRxfJXqD4%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAET22DUCO2M7LRXXJBCSPVDVVXL3JANCNFSM52XWQ6JA&data=05|01||4361d8704ac8436982a208da6dd28994|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637943048265815682|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=F9Uk0cH65%2F89rkgOdyhrTXaNPK9Gs4PjyDHSJg08Z2U%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

I have an CS-Z50UD3EAW and it also does not report an indoor temperature. Would be nice to either disable the reading or have it display something else (e.g the desired temperature). :-)

I have this exact problem, opened an issue as well lower down.
i also get a 0.0C reading for the exact same reason, that some non commercial units do not report the indoor temperature, so the reading comes up as 0C.
In the last update of the previous plug-in for Panasonic AC by Cody, he allowed the outdoor unit which does report the temperature to replace the 0C value and therefore allowed the units to report Cooling mode properly. As it stands the 0C reading infers you are in a freezing room, so 16*C wouldn’t activate Cooling mode.
Hope this helps and can be resolved.
Thanks

In my AC indoor unit temperature sensor show that is 26 C. Target is 30 C. And real temp in room is 21 C. If i set target temp in AC to 21 it will quickly stop heating. Build-in temperature sensors in AC is mistake! It's like putting a thermometer on the sun.

I think that easy way to fix this is to set default current temp to 16 C in heating mode and 30 in coooing mode. And when indoor unit have temperature sensor it will overide this values.

Maybe in dist/indoor-unit.js add this in Current Temperature:
this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, (deviceStatus.operationMode === 3) ? 86 : 68,8 );
This will set default current temperatures if cannot read from indoor unit. 86 Farenheit = 30 Celcius and 68,8 Farenheit = 16 Celcius. I'am not sure that there should be , (comma) or . (dot) in second value. This should set default current temperature to 16 Celcius, and 30 Celcius in heat mode. I don't know how to solve this for auto mode. Set it based on time? - e.g. in the months from May to September, the default cooling mode and outside of these months, heating mode? Or not set anything because if the air conditioning does not have a built-in sensor, the user should not use the auto mode?
and second thing is to replace temp from outdoor unit if user set that in config:
 if ((deviceStatus.outTemperature < 126) && (this.platformConfig.useOutdoorTemp === 1) {
                    this.platform.log.error('Outdoor temperature is used instead of indoor');
					this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, deviceStatus.outTemperature);
                }

So the whole code would look like this:
// Current Temperature
            // Note: Only update the temperature when the heat pump is reporting a valid temperature.
            // Otherwise it will just incorrectly report zero to HomeKit.
            if (deviceStatus.insideTemperature >= 126) {
                // Temperature of 126 from the API = null/failure
                this.platform.log.error('Temperature state is not available - setting default temperature');
		this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, (deviceStatus.operationMode === 3) ? 86 : 68,8 );

                if ((deviceStatus.outTemperature < 126) && (this.platformConfig.useOutdoorTemp === 1) {
                      this.platform.log.error('Outdoor temperature is used instead of indoor');
		      this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, deviceStatus.outTemperature);
                }

            }
            else {
                this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, deviceStatus.insideTemperature);
            }

I’m pretty sure the unit has an indoor temp sensor, but it just doesn’t publish that data. You can even see a thermostat sensor under the cover next to the filters, and how could it work without one as the whole point is to set the desired indoor temperature, no matter if you use it for heating or cooling. -mikael   From: mkz212<EMAIL_ADDRESS>Tuesday, 31. January 2023 at 10.39To: embee8/homebridge-panasonic-ac-platform<EMAIL_ADDRESS>mstendah<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Re: [embee8/homebridge-panasonic-ac-platform] Compatibility with units that do now show indoor temperature (Issue #31)Maybe in dist/indoor-unit.js add this in Current Temperature:this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, (deviceStatus.operationMode === 3) ? 86 : 68,8 );This will set default current temperatures if cannot read from indoor unit. 86 Farenheit = 30 Celcius and 68,8 Farenheit = 16 Celcius. I'am not sure that there should be , (comma) or . (dot) in second value. This should set default current temperature to 16 Celcius, and 30 Celcius in heat mode. I don't know how to solve this for auto mode. Set it based on time? - e.g. in the months from May to September, the default cooling mode and outside of these months, heating mode? Or not set anything because if the air conditioning does not have a built-in sensor, the user should not use the auto mode?and second thing is to replace temp from outdoor unit if user set that in config: if ((deviceStatus.outTemperature < 126) && (this.platformConfig.useOutdoorTemp === 1) {                    this.platform.log.error('Outdoor temperature is used instead of indoor');                                                                    thisservice.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, deviceStatus.outTemperature);                }So the whole code would look like this:// Current Temperature            // Note: Only update the temperature when the heat pump is reporting a valid temperature.            // Otherwise it will just incorrectly report zero to HomeKit.            if (deviceStatus.insideTemperature >= 126) {                // Temperature of 126 from the API = null/failure                this.platform.log.error('Temperature state is not available - setting default temperature');                this.service.updateCharacteristic(this.platformCharacteristic.CurrentTemperature, (deviceStatus.operationMode === 3) ? 86 : 68,8 );                                               if ((deviceStatusoutTemperature < 126) && (this.platformConfig.useOutdoorTemp === 1) {                      this.platform.log.error('Outdoor temperature is used instead of indoor');                                                  this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, deviceStatus.outTemperature);                }                                                  }            else {                this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, deviceStatus.insideTemperature);            }—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>
Or better way:
if ((deviceStatus.outTemperature < 126) && (this.platformConfig.useOutdoorTemp === 1) {
   this.platform.log.error('Outdoor temperature is used instead of indoor');
   this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, deviceStatus.outTemperature);
}
else {
   this.platform.log.error('Temperature state is not available - setting default temperature');
   this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, (deviceStatus.operationMode === 3) ? 86 : 68,8);
}

So whole code:
// Current Temperature
// Note: Only update the temperature when the heat pump is reporting a valid temperature.
// Otherwise it will just incorrectly report zero to HomeKit.

if (deviceStatus.insideTemperature >= 126) {
// Temperature of 126 from the API = null/failure

  if ((deviceStatus.outTemperature < 126) && (this.platformConfig.useOutdoorTemp === 1) {
   this.platform.log.error('Outdoor temperature is used instead of indoor');
   this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, deviceStatus.outTemperature);
  }
  else {
   this.platform.log.error('Temperature state is not available - setting default temperature');
   this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, (deviceStatus.operationMode === 3) ? 86 : 68,8);
  }
}

else {
  this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, deviceStatus.insideTemperature);
}

Another possibility. Fully automatic. If the temperature of the indoor unit is not available, the temperature of the outdoor unit will be used. If both are not available, the default values will be used: 8°C for heating and 30°C for cooling.
// Current Temperature
// If the temperature of the indoor unit is not available, the temperature of the outdoor unit will be used.
// If both are not available, the default values will be used: 8°C for heating and 30°C for cooling.

// Temperature of 126 from the API = null/failure
if (deviceStatus.insideTemperature < 126) {
   this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, deviceStatus.insideTemperature);
}

else {
   this.platform.log.info('Indoor temperature: is not available');

   if (deviceStatus.outTemperature < 126) {
      this.connectedOutdoorUnit.setOutdoorTemperature(deviceStatus.outTemperature);
   }

   else {
      this.platform.log.info('Outdoor temperature is not available - setting default temperature');
      this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, (deviceStatus.operationMode === 3) ? 30 : 8);
   }

}

I just came here to file this same issue. Is there any way to just show "—" instead of "0,0"?

I think that NO. Homekit require that it must be numeric value.

Incredibly annoying. And the "heating to" and "cooling to" are determined by this value as well?
Could we select another temperature sensor in the same room to fill in this value?

That's what our installer said as well. The ones that still comes with one is due to older customers demanding one, but in reality there's little sense in having them on the device because they're too close to the output of the heat pump to be able to accurately read the room temperature.

I already gave the solution a few comments above. You can make changes to the code yourself. It is up to the plugin author to implement these solutions and make them available to everyone.

Hi
Thanks for the reply, I read your posts, but I’m not remotely as savvy with code so wasn’t sure which post applied to using the outdoor unit temperature. Could you give me the post number and if not too much trouble, could you let me know of I only this in settings or configuration? I’m showing my lack of knowledge. Thanks again

I have fully automatic solution. If the temperature of the indoor unit is not available, the temperature of the outdoor unit will be used. If both are not available, the default values will be used: 8°C for heating and 30°C for cooling.
In dist/indoor-unit.js :
// Current Temperature
// If the temperature of the indoor unit is not available, the temperature of the outdoor unit will be used.
// If both are not available, the default values will be used: 8°C for heating and 30°C for cooling.

// Temperature of 126 from the API = null/failure
if (deviceStatus.insideTemperature < 126) {
   this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, deviceStatus.insideTemperature);
}

else {
   this.platform.log.info('Indoor temperature: is not available');

   if (deviceStatus.outTemperature < 126) {
      this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, deviceStatus.outTemperature);
   }

   else {
      this.platform.log.info('Outdoor temperature is not available - setting default temperature');
      this.service.updateCharacteristic(this.platform.Characteristic.CurrentTemperature, (deviceStatus.operationMode === 3) ? 30 : 8);
   }

}

Thanks again,
I just don’t know hope to input this to the json editor. Is it in the config?
Sorry

No. You need to ftp your device to explore plugin folder. You can search on net how to do it.

Thanks again, I’m currently viewing on an iPad and can’t see where to edit the code and don’t want to do something wrong. Don’t want to test your goodwill tho. I was hoping embee8 could update this, mentioned I was willing to sponsor the plug-in. If anyone can guide me through this process, I’d very much appreciate it.
Thanks

Any chance we could get a setting to let it know we don't have a outdoor temperature sensor? So that it stops spamming the logs with "Temperature state is not available"?

Dodałem pull request w tej sprawie #87

I added a pull request on this #87

This feature has been made available from v1.8.0 onwards


Added Battleship.Pirate.generate_id

Added Battleship.Pirate.generate_id(amount_words, number_max) for generating game ids like "ahoy-matey-4523".
config.exs was adopted for this type of ids too.
Implements #5

Awesome! My only concern is that the original generate_id function was also generating the random player ids here. What do you think about having two different functions, one for the player ids and the other for game ids (pirate version)?

Thanks for that info, did not see that. I will have a look on that.

No problem! That id is also for referencing the board agent process so the more random and unique the better.

Hey @h4cc any updates on this or shall I merge it as it is? :)

Pushed latest state. There is now a generate_game_id and generate_player_id. Also a cool generate_name :)

Great job! Merging!


我终于完成数据预处理了，谢谢您的回答和帮助，我想问一下按照你的参数在4块16g的v100上要跑多久能跑完？

我终于完成数据预处理了，谢谢您的回答和帮助，我想问一下按照你的参数在4块16g的v100上要跑多久能跑完？
Originally posted by @wymxz in https://github.com/guolinke/TUPE/issues/2#issuecomment-671714686
前辈您好，请问finetuning的数据处理流程是怎样的呢？

refer to this script: https://github.com/guolinke/TUPE/blob/master/preprocess/glue/process.sh

Thank you very much for your reply. I tried to run process.sh, but encountered the following error.
error: #error This file requires compiler and library support for the ISO C++ 2011 standard. This support must be enabled with the -std=c++11 or -std=gnu++11 compiler options.
Is this related to the version of gcc? Further, can you tell me your version? Thank you again!

This line https://github.com/guolinke/TUPE/blob/master/preprocess/glue/process.sh#L27 ？
I used the default g++ in the ubuntu 20.04

Thank you very much for your patience!


Documented how to run in the browser

Motivation
Added information on how to run the app in the browser. It is the simplest option so why not to document it. It is much easier especially if you don't have Android Emulator or iOS dev environment installed.

@trepel @ciaranRoche is right - some of our functionality might behave differently. We also do not test anything on the browser only device.

SDK support on web

Core 👍
Push 🛑
Auth 🛑
Metrics 🛑
Security 🛑

To support web we will need separate showcase, however with the nature of the SDK's now they will not make much sense for the web anyway (apart from Auth)

Thank you for all your reply guys. I tried to install on Android emulator but I received certificate errors (same happened for real device, I was using self-signed certificates). So I tried in a browser. I was only interested in Auth (Keycloak) and that worked. I didn't try integration with other Mobile Services.
For a jump start the browser way (despite the limitation of only Core & Auth) might be nice to have. However, you apparently think there is too little value for the browser. I am perfectly ok with closing this one then. If no other support for browser appears here I will close this later today.

You need to push certificates from your local cluster to a device or emulator, the easiest way to do that for Android is if you run
oc get secret router-certs --template='{{index .data "tls.crt"}}' -n default  |  \
base64 --decode | sed -e '1,/^-----END RSA PRIVATE KEY-----$/ d'  > /tmp/localcluster.crt

Then use adb to push the cert to your device/emulator
adb push /tmp/localcluster.crt /sdcard/Download/localcluster.crt

Once that is done, go to your Download folder on the device and select the localcluster.crt file and install it, you might need to add a screen lock too, but once its installed you should have no certificate issues with the app.

Auth may work depending on how redirect URL is being configured. If it will be application schema then it will not work. Currently it's localhost, but in the future this could change.

Was just going to say that for now auth will work because the showcase doesn't make use of any app schema. Once we implement SSO then the browser will no longer work for auth either.

Actually this PR becomes really valuable source of information.
@trepel If there is something we can do here we can also move that to the list to have more wider coverage.

Hi guys, sorry it took me so long to get back to this. I created a post in AeroGear group, I hope it is roughly what you expected it to be, feel free to reply there if not.
Based on your comments I was able to run the app (with auth) in both emulator and browser. It didn't work on real device though. I suspect it is because of redirect url, I used localhost as described in getting started guide). Any ideas what to do to make it work on real device ? When I click "Authenticate" it just redirects me back to that screen again.

@trepel are you able to access your cluster from the device browser normally (through chrome or whatever)?

@StephenCoady hmm, I can reach the OCP console, but I am not able to reach keycloak realm URL (via chrome)

@trepel are you on fedora or mac? this sounds like a firewall issue myself and @ciaranRoche hit last week. If you are on fedora, this might help: https://github.com/aerogear/mobile-docs/pull/279

thank you @StephenCoady , that made it accessible indeed. It works now real device now as well.
Just for the record, yes, I am running Fedora and
firewall-cmd --add-port 80/tcp
firewall-cmd --add-port 443/tcp
was indeed the solution.

Closing the PR now, thanks again to all of you for your time and effort.


Building under MinGW with UNICODE enabled fails

When building the library for Windows target with UNICODE and _UNICODE preprocessor flags the compilation fails.
The QUtil.cc contains a call to GetEnvironmentVariable, which gets preprocessed into GetEnvironmentVariableW resulting in compilation errors.
Same issue for the SecureRandomDataProvider.cc and CryptAcquireContext API call.
The simple resolution is to use the non-Unicode functions: GetEnvironmentVariableA, CryptAcquireContextA

Thanks for the report. I will keep this in mind for the next update. Hopefully I will be able to reproduce it in my build environment.

I'm closing this because it's very old and all the tools have moved on.


guiding text is not inline with code fragments and application returns different values

A few remaks about text surrounding the code:

NodeEntity became Node in the code
GraphId became Id in the code
UNDIRECTED is not a relationship anymore, therefore also the applications output is changed from

Before linking up with Neo4j...
	Greg's teammates => []
	Roy's teammates => []
	Craig's teammates => []

Lookup each person by name...
	Greg's teammates => [Roy, Craig]
	Roy's teammates => [Greg, Craig]
	Craig's teammates => [Roy, Greg]

to
 Before linking up with Neo4j...
 	Greg's teammates => []
 	Roy's teammates => []
 	Craig's teammates => []
 Lookup each person by name...
 	Greg's teammates => [Roy, Craig]
 	Roy's teammates => [Craig]
 	Craig's teammates => []
 The following have Greg as a teammate...
 Closing driver instance 61814127

for this new directionality also the comment // We already know craig works with roy and greg is incorrect.

I have done this. There are changes in Spring Data Neo4j here: https://stackoverflow.com/questions/68472313/spring-data-neo4j-6-relationship-undirected
So the code needs to be updated as following:

			greg = personRepository.findByName(greg.getName());
			greg.worksWith(roy);
			greg.worksWith(craig);
			personRepository.save(greg);

			roy = personRepository.findByName(roy.getName());
			roy.worksWith(craig);
			// We already know that roy works with greg
			roy.worksWith(greg);
			personRepository.save(roy);

			// We already know craig works with roy and greg
			craig = personRepository.findByName(craig.getName());
			craig.worksWith(roy);
			craig.worksWith(greg);
			personRepository.save(craig);

Since the solution is in the issue thread, I'm going to mark this one as a good first issue, to encourage someone in the community to try their hand at an OSS contribution.


iam: replace deprecated iam.New() with iam.NewService()

Fixes a documentation issue reported by multiple customers.

LGTM
On Mon, Mar 2, 2020, 3:43 PM Jeff Williams<EMAIL_ADDRESS>wrote:

Fixes an issue reported by multiple customers.
You can view, comment on, or merge this pull request online at:
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264
Commit Summary

iam: replace deprecated iam.New() with iam.NewService()

File Changes

M iam/quickstart/quickstart.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-8697c149784bcd2b16c47770228185d4
(14)
M iam/snippets/permissions_query_testable.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-858749a911b853d373006f5272151d71
(10)
M iam/snippets/roles_create.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-0a793ec1528a3a1e27d46576152163a3
(10)
M iam/snippets/roles_delete.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-257c10fe8450f45c7c80c46c402860b0
(10)
M iam/snippets/roles_edit.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-86a14ba75262a0163c88fd5f4f8fc1cd
(10)
M iam/snippets/roles_get.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-82e7181af810dce88d17f2b0a3a869a0
(10)
M iam/snippets/roles_list.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-14b1f63915db1c8a108a9cfd82c4d26d
(10)
M iam/snippets/roles_undelete.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-2bbaa1d6df002e11b7397cdad839215b
(10)
M iam/snippets/roles_view_grantable.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-85ce49a027780a4c5601a748654015a8
(10)
M iam/snippets/service_account_keys_create.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-c3273845832eb4520d99c396120a9e82
(10)
M iam/snippets/service_account_keys_delete.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-5e1c240ad77ee1187429a80323514070
(10)
M iam/snippets/service_account_keys_list.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-e323d582ab7a7a45942ccaaf2efb6c95
(10)
M iam/snippets/service_accounts_create.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-23760593a46bb1bb993bb280a27c5303
(10)
M iam/snippets/service_accounts_delete.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-f2eb80047f6513d2faa345e41e231161
(10)
M iam/snippets/service_accounts_disable.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-17e468a07867e742b98aa904b824e9f9
(10)
M iam/snippets/service_accounts_enable.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-e072d8857336e535cd3e292400b3624e
(10)
M iam/snippets/service_accounts_list.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-910099a1fa177763ad8f13858dc8e04b
(10)
M iam/snippets/service_accounts_rename.go
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264/files#diff-4ac1640e1dd40fa8e8eb7bb1a3d39d93
(10)

Patch Links:

https://github.com/GoogleCloudPlatform/golang-samples/pull/1264.patch
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/golang-samples/pull/1264?email_source=notifications&email_token=AAAGDFWSSS2TYWNSWNW7XW3RFM2NPA5CNFSM4K7MIPD2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IRSFCOQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAGDFR7YDTZRDQOJ6HPGJTRFM2NPANCNFSM4K7MIPDQ
.


Add ability to prepend the header string to the token, before trying to decode it

I want to send to the client only the JWT token without the header with the algo informations.
To do this, there should be a passport-jwt option to specify a string that will be prepended to the token, before its decodification.
Example:
The client sends to the server the request with this header:
Authorization: JWT eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiYWRtaW4iOnRydWV9.TJVA95OrM7E2cBab30RMHrHDcEfxjoYZgeFONFh7HgQ
You may notice that the "header." is missing. passport-jwt, after detected the jwt in the header, will prepend the string "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9." before trying to decode it, to have the final token: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiYWRtaW4iOnRydWV9.TJVA95OrM7E2cBab30RMHrHDcEfxjoYZgeFONFh7HgQ

Is this a common practice?  What is driving this need? In my experience with using JWTs for authentication the JWT is provided in whole by the party being authenticated. Modifying the JWT as part of authentication seems odd.
I would suggest that you modify the partial JWT from the request before invoking this authentication module. The modified JWT can be added to the request object and you can use a custom extractor function to retrieve it and authenticate it with this module.

The use case is to make slightly hard for an user to understand how the token is built (which sign algorithm). Not really odd, or yes?

I would suggest that you modify the partial JWT from the request

It looks like a good choice, so before invoking passport.authenticate('jwt', etc..
For anyone else:
if (req.headers.authorization)
    req.headers.authorization = "JWT " + header + req.headers.authorization;

passport.authenticate('jwt', etc...

Of course, after have modified  how the client sends the token in the header

@themikenicholson As you can see, a unified way for every extractor would be better


[1.16, Bug]

-- Describe how you caused the bug --
I just placed any smaller grid block, and then placed a random block inside
-- Describe the expectation --
Maybe just show the smaller render of the block inside
-- Describe what happened instead --
Game crashed with error : java.lang.NullPointerException: Ticking player (See linked media)
-- Additional info --
SU Version: 1.16-Release 1.2
Exact MC Version: 1.16.5
Loader: 1.16.5-forge-36.2.39
Any optimization mods: N/A
// Please note that I've been using this with and without Pehkui, and yet the result didn't change //
-- Logs if the game crashed --
(Please use gist or pastebin)
-- If you’re using the CF launcher, feel free to attach an export of your modpack --
https://user-images.githubusercontent.com/116744793/198072957-d0702d77-3624-4352-a5ec-11b583d8ab15.mp4

I’ll look at it when I get home
Never seen this happen with smaller alone, and I’m especially unsure why the unit space itself would show up as bedrock after being clicked…

To be honest, the bedrock appearing is new. Last times it just crashed without anything else happening
I would like to use this comment to add that whenever I place a prebuilt model, it works just fine, I can interact with it, and when I place a single block, it crashes

Also what forge version do you recommend for your game

I’ve been testing with 36.2.20

To help you
I launched the mod with the forge version you recommended above ^
And it works.
So ig it's just the forge version that makes it go crazy

halfway fixed this issue (game loads, units can be placed, however small multipart entities will be finicky if they aren't living entities, which I doubt will ever happen?), gonna upload a build to curseforge now
gonna leave the issue open however


Remove audio from alpha channel export

added .withNoAudio() as discussed here https://github.com/m90/seeThru/issues/21

Lgtm, thanks for your contribution as well as pointing out this issue!

thanks to you to!


[BUG] LIST

dont can send a list. before in 5.0.0 i can

Before making issues check old ones

thank you its block by meta


running make test locally failed

with 2 pods not able to reach running: (after excluding the mixer redis testing)
root@test-control-plane:/Users/linsun/go/src/istio.io/installer# kubectl describe pod nginx-default-http-backend-84bdb65549-nwwkd  -n simple-strict
  Normal   Pulled     14m (x3 over 16m)   kubelet, test-control-plane  Container image "gcr.io/google_containers/defaultbackend:1.4" already present on machine
  Warning  Unhealthy  10m (x7 over 12m)   kubelet, test-control-plane  (combined from similar events): Liveness probe failed: Get http://<IP_ADDRESS>:8080/healthz: read tcp <IP_ADDRESS>:60862-><IP_ADDRESS>:8080: read: connection reset by peer
  Warning  BackOff    70s (x39 over 10m)  kubelet, test-control-plane  Back-off restarting failed container

kubectl describe pod prometheus-operator-5566546995-g8tsc
  Normal   Pulled     16m                  kubelet, test-control-plane  Container image "quay.io/coreos/prometheus-operator:v0.29.0" already present on machine
  Warning  BackOff    16m (x2 over 16m)    kubelet, test-control-plane  Back-off restarting failed container
  Warning  Unhealthy  98s (x448 over 16m)  kubelet, test-control-plane  Readiness probe failed: HTTP probe failed with statuscode: 503

CircleCI workflow is working now, but the steps are fixed.
So what's you local test step? Seems that you should run the run-prometheus-operator-config-test target.

You also need https://github.com/istio/installer/pull/137 before make test will run to fix this.

Note that the prometheus operator test was never added in the CI and the CI does not do a make test. Once PR 137 is merged, the CI can be updated to do one or both.

Well, #137 should have fixed this but the prometheus operator has a half release which is causing a new failure: https://github.com/coreos/prometheus-operator/issues/2598. Seems they have a tentative plan to get that fully published on Monday.

The prometheus-operator should now be fixed. Running a make test to confirm things work, or maybe more likely, what is broken next ;) .

make test now passes so closing this issue.
We still need to get the prometheus-operator added into the CI pipeline.


adding shellcheck action in cliworkflow

Committing issue #549

Kindly review @ivotron

Hello @ivotron,
Thanks for reviewing I have made some changes. Kindly see to it.
Thank you,
Utkarsh Mishra

Now I think it will be correct but travis fails kindly suggest anything to overcome.

hey @ulshell , looks like we get shellcheck errors that need to be fixed, reported here. Do you feel comfortable to work on fixing those? You can test locally by running popper run Shellcheck on your machine.

Hello @ivotron  I need some help in this issue. I want some guidance to approach this issue.

@ulshell you need to modify the the scripts in ./ci/test/ directory to pass the shell-check. You can run the run the Shellcheck action on your local by popper run 'Shellcheck' to see what is causing the error.
To start off with, you can find the solution for SC1091: Not following: ./common was not specified as input (see shellcheck -x) error here. Similarly you can find the solutions for every error you see by using the SC code e.g. for SC2086: Double quote to prevent globbing and word splitting you can go to https://github.com/koalaman/shellcheck/wiki/SC2086. I hope this helps, do let me know if you have any concerns.

@ulshell please take a look at the comments by @arshul . Let us know if something is not clear.

Thanks @arshul for helping me out

closing in favor of #572


Add a --fix-name-length option to align command output

When using concurrently, providing custom names with the -n or --names option can cause output to become misaligned and difficult to read if the names have different lengths. This can be particularly problematic when the output is lengthy and spans multiple lines.
To address this issue, I propose adding a new --fix-name-length option that allows users to specify a fixed length for the command names. When this option is used, the command names will be padded with spaces or truncated as necessary to ensure that they all have the same length, and the output will be properly aligned.
For example, if a user runs the following command:
concurrently -n "API, TypeScript, VeryLong" --fix-name-length\
    "npm run api" "npm run typescript" "npm run somethingverylong"

The output would be aligned like this:
API        | output from npm run api
TypeScript | output from npm run typescript
VeryLong   | output from npm run somethingverylong

This would make it much easier to read and understand the output from each command, especially in cases where the output spans multiple lines.
I believe that adding a --fix-name-length option would be a valuable addition to concurrently, as it would improve the user experience for those who use custom names for their commands.

I like this idea very much!
With one caveat: maybe it should just be --pad-names? Or something else that alludes to "padding"?
I feel like "fix" can seem like a bug is involved 😛

@gustavohenke sure!
--pad-names without any params would be great!

🚢 This is now available in v9.0.0!
https://github.com/open-cli-tools/concurrently/releases/tag/v9.0.0


Add comments to config.py

Add comments to explain the various configuration settings in python/src/uagents/config.py.

Added comments to the variables and functions in config.py to make the code more understandable


Update current a2ha documentation for automate-backend-deployment component

Description
As  automate-backend-deployment component is moved to automate repo, the component will be available to habitat builder. So when old customer will try to install chef/automate-backend-deployment then new terraform changes also will be available so to avoid that scenario we have to change current a2ha documentation as many old customer are referring to that one.
Acceptance-criteria
To ensure hab pkg will pull specific old version.

As we are using new name for all backend component so no need to look into that.


Added metro configuration to allow developing in the example folder

As discussed in #261 it would be great to develop in the Example folder as to enhance our maintainer experience.
After a fair bit of work, I managed to make it work. Dependencies are updated to RN 0.58 in the example folder, but the project have been tested into a RN 0.57.1 project (Android) so i'm pretty much confident this will work. Unfortunately i've been unable to make metro work with RN56 nor RN57, so I updated them to RN58. The documentation is far from being complete.
Looking for some feedback and tests on this.

Available in v10.0.0-next.0 ✈


Multiple consecutive spaces in query results cells are condensed into one (like HTML).

Issue Type: Bug
Just run a query:
SELECT 'say          what!?'

The results grid collapses the 10 spaces between the words into one when it displays. I can understand collapsing beginning or trailing spaces, but this incorrect display could be misconstrued or misinterpreted.
Text in the results should probably be treated as preformatted text.
This is not an issue in SSMS.
Azure Data Studio version: azuredatastudio 1.4.5 (887f4e8985023602e599cf86bdb44df48bb28569, 2019-02-12T06:20:08.633Z)
OS version: Windows_NT x64 6.1.7601

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz (8 x 2712)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: unavailable_off

Memory (System)
15.65GB (10.97GB free)

Process Argv
C:\Program Files\Azure Data Studio\azuredatastudio.exe

Screen Reader
no

VM
0%

Extensions: none
(1 theme extensions excluded)

Validated fix with Insiders build


disabled tests/suites are NOT skipped

When I run my entire set of spec files using 'protractor' command, everything runs as expected. Specifically, suites that I have disabled like so:

xdescribe('my suite',function(){
//run a suite
};
xit('my test', function(){
//run a test
}

..are skipped, as expected.
HOwever, when I try to run the same thing using gulp-protractor, the runner goes through my entire spec directory and then marks what should be skipped tests as failed tests.  Any ideas?

This is the file that handles running gulp protractor:

var gulp = require('gulp');
var $ = require('gulp-load-plugins')();
var browserSync = require('browser-sync');
var paths = gulp.paths;

// Downloads the selenium webdriver
gulp.task('webdriver-update', $.protractor.webdriver_update);
gulp.task('webdriver-standalone', $.protractor.webdriver_standalone);

function runProtractor(done) {
  gulp.src(paths.e2e + '/**/*.js')
    .pipe($.protractor.protractor({
      configFile: 'protractor.conf.js'
    }))
    .on('error', function (err) {
      // Make sure failed tests cause gulp to exit non-zero
      throw err;
    })
    .on('end', function () {
      // Close browser sync server
      browserSync.exit();
      done();
    });
}

gulp.task('protractor', ['protractor:src']);
gulp.task('protractor:src', ['serve:e2e', 'webdriver-update'], runProtractor);
gulp.task('protractor:dist', ['serve:e2e-dist', 'webdriver-update'], runProtractor);

Same issue.

When I xdescribe(...) a test file, it is skipped, but gulp-protractor renders it as an error response (trigger on.('error', ...)).

The browser window remains open when all the tests finish, where usually all the browser windows would have been closed.

I cannot replicate this... Both xdescribe and xit work for me using the plugin with Jasmine.
I'm going to close this for now. Let me know if you have more info down the line.


The provided citation title is wrong

The title of the provided bibtex citation has the title "Topological Sort for Sentence Ordering" instead of this paper's title.

Thanks!


Update user guide

Fixes #479

Codecov Report

Merging #482 into master will decrease coverage by 0.13%.
The diff coverage is 7.57%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b4d22d...00dc031. Read the comment docs.


引用出错了

go list -m<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>unrecognized import path "gopkg.in/bsm/ratelimit.v1": reading https://gopkg.in/bsm/ratelimit.v1?go-get=1: 404 Not Found
server response: GitHub repository at https://github.com/bsm/ratelimit has no branch or tag "v1", "v1.N" or "v1.N.M"

😓 use go get github.com/faabiosr/cachego  then ....  ok


French translation

French translation for user/admin sides

@anthlasserre
Thanks for your contribution.

With pleasure @sonufrienko


squash all commits for notification plugin framework

this was reviewed by Ralph and Qingwen, in pull request 90

solved and closed


KIKIMR-20945: optionally import inventory from a file produced by ydb-terraform

https://github.com/ydb-platform/ydb-terraform produces a simple file with one FQDN of created VM per line, for example:
$ cat hosts.txt
static-node-1.ydb-cluster.com
static-node-2.ydb-cluster.com
static-node-3.ydb-cluster.com

Yet another plugin will probably be an overkill.


AWS Parallel cluster cookbook overrides the '/etc/sysconfig/slurmd'

Setting the PATH variable this way is of no use as the file '/etc/sysconfig/slurmd' is getting overridden by AWS parallel cookbook.
https://github.com/aws-samples/aws-parallelcluster-post-install-scripts/blob/6557b15add8936e1a6a572d48fec98236e368947/pyxis/postinstall.sh#L104
Logs from the chef-client
Recipe: aws-parallelcluster-slurm::finalize_compute
  * ruby_block[get_compute_nodename] action run[2024-09-23T11:57:55+00:00] INFO: Processing ruby_block[get_compute_nodename] action run (aws-parallelcluster-slurm::finalize_compute line 18)
[2024-09-23T11:57:55+00:00] INFO: ruby_block[get_compute_nodename] called

    - execute the ruby block get_compute_nodename
  * directory[/etc/sysconfig] action create[2024-09-23T11:57:55+00:00] INFO: Processing directory[/etc/sysconfig] action create (aws-parallelcluster-slurm::finalize_compute line 24)
 (up to date)
  * template[/etc/sysconfig/slurmd] action create[2024-09-23T11:57:55+00:00] INFO: Processing template[/etc/sysconfig/slurmd] action create (aws-parallelcluster-slurm::finalize_compute line 30)
[2024-09-23T11:57:55+00:00] INFO: template[/etc/sysconfig/slurmd] backed up to /etc/chef/local-mode-cache/backup/etc/sysconfig/slurmd.chef-20240923115755.424304
[2024-09-23T11:57:55+00:00] INFO: template[/etc/sysconfig/slurmd] updated file contents /etc/sysconfig/slurmd

    - update content in file /etc/sysconfig/slurmd from b509b2 to 4102f2
    --- /etc/sysconfig/slurmd	2024-09-23 11:57:50.121045146 +0000
    +++ /etc/sysconfig/.chef-slurmd20240923-5316-n97ta9	2024-09-23 11:57:55.413026966 +0000
    @@ -1,4 +1,2 @@
    -PATH=/opt/slurm/sbin:/opt/slurm/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
    +SLURMD_OPTIONS='-N gpu-queue-st-worker-node-1'

This recipe has a finalize task which runs after all the post-install scripts , and that task uses a template for creating the  '/etc/sysconfig/slurmd'
Template Link: https://github.com/aws/aws-parallelcluster-cookbook/blob/develop/cookbooks/aws-parallelcluster-slurm/templates/default/compute_node_finalize/slurm/slurm.sysconfig.erb
Task Link:  https://github.com/aws/aws-parallelcluster-cookbook/blob/develop/cookbooks/aws-parallelcluster-slurm/recipes/finalize/finalize_compute.rb#L30
Q. How did i verify that it is actually overriding ?
A: Before overriding it creates a backup file, the backup file has the PATH variable which is being set in the pyxis post install scripts , this can be verify from the logs above as well .

Thank you for reporting and your analysis.
We are working on a fix.

Thank you for the quick fix! I had implemented a similar workaround, but I was waiting for an official update. I really appreciate your effort.


Mutators for promises (or custom mutators)

Hi.
Is it possible to have this mutation?
Imagine you have this: return $q.reject('someCode');. Is it somehow possible to mutate this to: return $q.when('someCode');?
I am using $q service in AngularJS. I think I need something like custom mutation there. Is it possible?

That's a cool idea! I don't think this should be a mutator that's included by default so this could be Styker's first custom mutator!
We use Esprima to parse our code into an Abstract Syntax Tree. If I give the code
function myfunction() {
	return $q.reject('someCode');
}

To Esprima (http://esprima.org/demo/parse.html), we get the following tree*:
{
    "type": "Program",
    "body": [
        {
            "type": "FunctionDeclaration",
            "id": {
                "type": "Identifier",
                "name": "myfunction"
            },
            "params": [],
            "body": {
                "type": "BlockStatement",
                "body": [
                    {
                        "type": "ReturnStatement",
                        "argument": {
                            "type": "CallExpression",
                            "callee": {
                                "type": "MemberExpression",
                                "computed": false,
                                "object": {
                                    "type": "Identifier",
                                    "name": "$q"
                                },
                                "property": {
                                    "type": "Identifier",
                                    "name": "reject"
                                }
                            },
                            "arguments": [
                                {
                                    "type": "Literal",
                                    "value": "someCode",
                                    "raw": "'someCode'"
                                }
                            ]
                        }
                    }
                ]
            },
            "generator": false,
            "expression": false
        }
    ],
    "sourceType": "script"
}

* Stryker actually gets some more info such as line numbers but I've removed them from this example.
Now, the interesting part lies in this Object:
"callee": {
    "type": "MemberExpression",
    "computed": false,
    "object": {
        "type": "Identifier",
        "name": "$q"
    },
    "property": {
        "type": "Identifier",
        "name": "reject"
    }
},

If you write a mutator, you will get every object on the syntax tree. One of those objects could match this one. You can check if the object is like this one to be certain (does it have the right type? Do the object and property properties contain the right values?) If that's all true, you could change "reject" into "when" and boom!
Now, would you like to write this yourself? (You can either publish it on your own GitHub or on our organization page, whatever you want)

@sharikovvladislav A custom mutator is possible. See the stryker plugin seed for your starting point to start creating mutators. I would just start out with mutators in your local project (using plugins: ['stryker-*', './myLocalPlugin'] for example. We're using TypeScript in our seed and projects, but this is not a requirement. You can just supply a constructor function with an applyMutations implementation. See @simondel's command for the details on how to implement it.
I'm pretty skeptical about the proposed mutation. The proposed mutation would not work in all circumstances. For example:
var promise = $q(function(resolve, reject) {
  reject('It would be difficult to mutate this particular line');
}

or
var $q = { reject: function () { } };
return $q.reject(); // should not be mutated in this case, because it is not angular's $q

That being said, i think it is still a valuable mutator to turn around promise results (reject -> resolve and vice versa).
It would only work for angular js projects, so if you would want to open source it, i would suggest to put it in an angularjs specific repository.

@simondel @nicojs Thank you for your answers.
I am not thinking about this must be build-in feature :)
Also, I know it will work only for angulajs (and I need it only for angularjs at the moment) and I know that it is hard to mutate some lines (but we don't use $q this way anyway). I just wanted to try stryker in my units.
I will try to make some custom mutator right after I will be able to start stryker at all :)

I will close this issue. I was inattentive and didn't see that there is ability to create custom mutators. Thank you for your answers.


error: ETIMEDOUT during code sending

Hi,
I am trying to send the code for authorization but it is just freezing for about a 30 second and then returns "ETIMEDOUT". I already tried a lot of different settings and configurations. Last one is:
var MTProto = require("telegram-mtproto").MTProto;

var number = "+795******";
console.log("Calling auth.sendCode on number=" + number);

var APP = {
    id:      ******,
    hash:    "***",
    version: "0.0.1",
    lang:    "en",
};

var client = MTProto({
    api: {
        layer:       57,
        api_id:      APP.id,
        app_version: APP.version,
        lang_code:   APP.lang,
    },
    server: {
        webogram: true,
        dev:      false,
    },
});

client("auth.sendCode", {
    phone_number:   number,
    current_number: false,
    //sms_type:       5,
    api_id:         APP.id,
    api_hash:       APP.hash,
}).then((result) => {
    console.log("sendCode succeeded:", result);
    process.exit(0);
});

this is the error, which i get:
[132.001] req_pq error connect ETIMEDOUT <IP_ADDRESS>:443
Get networker error { Error: connect ETIMEDOUT <IP_ADDRESS>:443
    at Object._errnoException (util.js:1024:11)
    at _exceptionWithHostPort (util.js:1046:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1182:14)
  code: 'ETIMEDOUT',
  errno: 'ETIMEDOUT',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 443,
  config:
   { adapter: [Function: httpAdapter],
     transformRequest: { '0': [Function: transformRequest] },
     transformResponse: { '0': [Function: transformResponse] },
     timeout: 0,
     xsrfCookieName: 'XSRF-TOKEN',
     xsrfHeaderName: 'X-XSRF-TOKEN',
     maxContentLength: -1,
     validateStatus: [Function: validateStatus],
     headers: { 'User-Agent': 'axios/0.15.3', 'Content-Length': 40 },
     method: 'post',
     responseType: 'arraybuffer',
     url: 'https://aurora.web.telegram.org/apiw1',
     data: ArrayBuffer { byteLength: 40 } },
  response: undefined } Error: connect ETIMEDOUT <IP_ADDRESS>:443
    at Object._errnoException (util.js:1024:11)
    at _exceptionWithHostPort (util.js:1046:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1182:14)
Unhandled rejection Error: connect ETIMEDOUT <IP_ADDRESS>:443
    at Object._errnoException (util.js:1024:11)
    at _exceptionWithHostPort (util.js:1046:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1182:14)

Unhandled rejection Error: connect ETIMEDOUT <IP_ADDRESS>:443
    at Object._errnoException (util.js:1024:11)
    at _exceptionWithHostPort (util.js:1046:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1182:14)

Did somebody get this issue as well? I just can't get what is wrong...
Or maybe you have some ideas how to solve it.
Thanks in advance

which version are you using?


ARROW-5450: [Python] Always return datetime.datetime in TimestampValue.as_py for unites other than nanoseconds

We will only return pandas.Timestamp for nanosecond resolution. If pandas is not installed, then we will check for data loss when converting to datetime.datetime

cc @tswast

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9dec79b). Click here to learn what that means.
The diff coverage is 53.96%.

@@            Coverage Diff            @@
##             master    #5346   +/-   ##
=========================================
  Coverage          ?   65.08%
=========================================
  Files             ?      497
  Lines             ?    68723
  Branches          ?        0
=========================================
  Hits              ?    44725
  Misses            ?    23998
  Partials          ?        0

Impacted Files
Coverage Δ

python/pyarrow/tests/conftest.py
71.05% <0%> (ø)

python/pyarrow/tests/test_pandas.py
95.3% <100%> (ø)

python/pyarrow/tests/test_convert_builtin.py
97.25% <100%> (ø)

python/pyarrow/tests/test_scalars.py
94.16% <33.33%> (ø)

python/pyarrow/scalar.pxi
63.75% <61.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dec79b...fac2d6a. Read the comment docs.

+1


Use alternate languages helper

Use the new helpers from hexo-multilingual v0.5.0.

This was already done on:

5307ac792f2e7d18cdf2f569f9f89b450dfdc736
5c9c92bd3d9b8adbd58b8124f335097e5d1de4d8


Unexpected end of JSON input

Had this working for quite some time.
Then Amazon changed something and I had to reset my password - I've done this
Now using the proxy method, I get an error on the node "Unexpected end of JSON input"
What does this error relate to?
using the cookie method works, but I obviously need to keep manually refreshing my cookie

Anyone know what the error "Unexpected end of JSON input" is?


Zebra rows for sub-forum topics section to match Recent Topics styling

I need to get more familiar with rebasing/squashing commits...

Care to share a screenshot? I can't find an use case for these changes...


Question

This is very nice Manoela! Is it any possibility or solution u can suggest to get it work in one column on mobile? Best regards Kalle

Thank you for the heads up Kalle, I totally forgot to make this grid responsive! Please have a look at the updated CSS, this will make sure there's just one column on smaller screens!

Thank you Manoela! You r amazing! I can´t wait for your new upcoming  ideas and works! Big thanks for everything! <3


chore(README): add new docker dependencies

Description

With the picker and completion changes, fzf and curl need to be installed as part of the try it with docker instructions.
Related Issue(s)

Screenshots

Checklist

[x] I've read the CONTRIBUTING guidelines.

No problem. I'll write a PR for that repo shortly. (Waiting for it to clone)


changes to support a fully functional GKE k2 provider

changes made:

use pinned version of gcloud utils
stop a lot of the thinning down, it was causing compile problems

this fixes samsung-cnct/k2#616

Also wait....


onRow should be fired for every row when the table is re-rendered.

onRow is NOT getting fired for every row when a table is re-rendered. Only rows with new keys have the onRow event fired. This is a problem with live filters. When I do a search with live filters, the rows are filtered. Since the row already exists, onRow is not getting fired. Since onRow is not getting fired, the styles are getting messed up. Below image shows odd and even styles messed up with the filter.

onRow should be fired for every row when the table is re-rendered.

That's a good point. Maybe it would be better to handle even/odd elsewhere, though. CSS has :nth-child(odd) and :nth-child(even) selectors. If onRow is reserved only for setting classes and you go through CSS selectors, that should solve the issue.
I think I'll tweak the examples to follow this kind of scheme.

Yes, odd and even style would work that way. Styling the selected row will be a problem. It will be neat if styling the odd row, even row, selected row is handled within reactabular.
Also, it will be neat if we have an event onSelectRow similar to onRow (when a row is clicked). In that way, we can avoid writing code for onRow.

Yes, odd and even style would work that way. Styling the selected row will be a problem. It will be neat if styling the odd row, even row, selected row is handled within reactabular.

Wouldn't this be solved by the current design, though? Given it expects you to handle selection state at row level, change made to it will force a change -> onRow gets triggered -> styling changes.

Also, it will be neat if we have an event onSelectRow similar to onRow (when a row is clicked). In that way, we can avoid writing code for onRow.

In the current example you can achieve that when select.row is triggered. I'm not sure if a separate handler would yield any value.

select(...) is not triggering an onRow event.
On Tue, Sep 27, 2016 at 6:41 PM, Juho Vepsäläinen<EMAIL_ADDRESS>wrote:

Yes, odd and even style would work that way. Styling the selected row will
be a problem. It will be neat if styling the odd row, even row, selected
row is handled within reactabular.
Wouldn't this be solved by the current design, though? Given it expects
you to handle selection state at row level, change made to it will force a
change -> onRow gets triggered -> styling changes.
Also, it will be neat if we have an event onSelectRow similar to onRow
(when a row is clicked). In that way, we can avoid writing code for onRow.
In the current example
http://reactabular.js.org/#/features/selecting-rows you can achieve
that when select.row is triggered. I'm not sure if a separate handler
would yield any value.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/reactabular/reactabular/issues/208#issuecomment-249860158,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADTCHYKFFhjhiRpctSsmDGSyCc1ElMoxks5quRXmgaJpZM4KHmCm
.

Can you put up a small example somewhere? Even forking this repo would be enough. Curious to see how you deal with the state there.

Thanks @bebraw
Doing a small example helped me see the problem. The select works fine. https://github.com/vijayst/reactabular-select-demo
The problem was in my understanding of the select API. I assumed select was doing an in-place update of the row by adding a property (row.selected). When I take the output of the select, store it in the state and use it for rendering, it works fine.
So, for odd-even rows, I will use plain CSS selector. And for selection styling, I will use the select and onRow.
Thanks again.

The original problem still remains. When I do a live filter, since the onRow event is not fired, the rowIndex passed to onSelectRow is wrong, and so I am not able to use the select(...) effectively.
However, when I use select(...) and pass the output of the select to the state, the onRow event is triggered for that row.

Finally fixed the whole styling issue. The way to use the API is:
    const { searchColumn, query, columns, sortingColumns, rows, pagination, selectedRowId } = this.state;
    const visibleColumns = columns.filter(column => column.visible);
    const searchedRows = search.multipleColumns({ columns: visibleColumns, query })(rows);
    const sortedRows = sort.sorter({ columns: visibleColumns, sortingColumns, sort: orderBy })(searchedRows);
    let selectedRows = sortedRows;
    if (selectedRowId !== -1) {
      const selection = select.row({
        rows: sortedRows,
        selectedRowId
      });
      selectedRows = selection.rows;
    }
    const paginatedRows = paginate(pagination)(selectedRows);

the output of select.row is taken for pagination.
In the onSelectRow, I completely discard rowIndex. rowIndex is unreliable because the onRow event does not fire always.
handleRowEvent(row, { rowIndex }) {
    return {
      className: row.selected && 'select-row',
      onClick: () => this.handleSelectRow(row)
    };
  }

  handleSelectRow(row) {
    this.setState({ selectedRowId: row.id });
    this.props.onSelectRow(row);
  }

As you can see above, I am completely disregarding rowIndex and storing the selectedRowId in the state.
And for odd-even styling, I am using the following SCSS:
.table-listing {
  tr:nth-child(even) {
    background-color: #f9f9f9;
  }
  tr.select-row {
    background-color: #f0f0f0;
  }
}

This issue can be closed. Thanks @bebraw

@vijayst If you want to make doc updates with tips like this, that would be appreciated. Thanks! 👍


feat(build): cross build alpine arm64

Summary
This PR cleans up the toolchain definition, and introduce the alpine aarch64 target.
Although alpine is going away in coming release, this PR prepares the fundamental for adding other aarch64
toolchains and even other architectures.
Checklist

[x] The Pull Request has tests
[na] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE
[na] The Pull Request has backports to all the versions it needs to cover

Full changelog

Unify the name arm64 to be aarch64 in Bazel files; old arm64 names are kept as aliases for backward compatibility.
Move to use our automatically built toolchain at https://github.com/Kong/crosstool-ng-actions
Add the //:generic-crossbuild-aarch64 platform for targets uses system-installed aarch64 toolchain.
Add the //:alpine-crossbuild-aarch64 platform and alpine-arm64 matrix.
Toolchains are named with GCC's naming convension like aarch64-unknown-linux-gnu.
Remove the wrapper symlinks farm for each toolchain from git, they are now created automatically.

Issue reference

Fix #[issue number]

Good run https://github.com/Kong/kong/actions/runs/5011110338?pr=10882

Sister PR to https://github.com/Kong/kong-ee/pull/5415


Does not work for attribute proc macros

rust-analyzer does not work for this file:
use serenity::{
    client::*,
    framework::standard::{macros::command, Args, CommandResult},
    model::channel::Message,
};

#[command]
fn clear(ctx: &mut Context, msg: &Message, args: Args) -> CommandResult {
    Ok(())
}

No intellisense, no completion, nothing works. I assume it's because of command macro?

Yes, attribute proc macros are not supported.

I can't edit the issue title, can you rename it to something like the above?
CC #5412, #2984.

Most features should still work as if the attribute wasn't there though.

@dakyskye can you confirm that completions are not working?

@lnicola yes

Is that Vim? How did you configure rust-analyzer?

@lnicola it is NeoVim, yes, with coc.nvim extension. That's the only rust-analyser config I have "rust-analyzer.serverPath": "rust-analyzer"

Can you run it (from the same terminal) with rust-analyzer --version? If you installed from source, it should be under ~/.cargo/bin, and I'd expect that to be in PATH, but it doesn't hurt to check.

Weird enough! My output for it is rust-analyzer ???????. I installed it from the Arch packages.

pacman -S rust-analyzer outputs rust-analyzer-20200914-1 is up to date.

Can you try https://github.com/fannheyward/coc-rust-analyzer/ instead? I think the official extension doesn't work too well with coc.nvim.

I use coc-rust-analyzer, but with custom rust-analyzer path.

I have also tried it in VSCode though, the same negative result.

Does it work for you (in Code) with a new project?

Nope

Sorry, I meant a new project as cargo new produces.

Yes, I did that.

Can't reproduce, maybe this is fixed in master?

It's weird. I have just tried it in VSCode, Vim and Emacs, works nowhere.

Ah, you said "master". I have latest release installed, let me build RA myself and try again.

@dakyskye if you run Rust Analyzer: Status command, does it list anything as file deps?

I accidentally deleted vscode package, and just reinstalled it. Now rust-analyzer works well for me in VSC. Let me try it in Emacs now

It started working in VSCode, but still not works in Vim and Emacs.

I am having a similar issue.
Rust analyzer status
workspaces:
54 packages loaded

analysis:
4067 (46mb) files
0 (0b) index symbols
1211 trees, 128 retained
18692 trees, 128 retained (macros)
472mb total

requests:
  783 textDocument/semanticTokens/full/delta2ms
  784 completionItem/resolve              1ms
  785 textDocument/foldingRange           0ms
  786 textDocument/codeLens               0ms
  787 textDocument/codeAction             1ms
  788 textDocument/documentSymbol         0ms
  791 textDocument/codeAction             1ms
* 779 textDocument/documentSymbol         0ms
  781 rust-analyzer/inlayHints            6ms
  782 textDocument/completion             7ms

You can find the code with a Dockerfile to reproduce the environment here

I am having a similar issue.
Rust analyzer status
workspaces:
54 packages loaded

analysis:
4067 (46mb) files
0 (0b) index symbols
1211 trees, 128 retained
18692 trees, 128 retained (macros)
472mb total

requests:
  783 textDocument/semanticTokens/full/delta2ms
  784 completionItem/resolve              1ms
  785 textDocument/foldingRange           0ms
  786 textDocument/codeLens               0ms
  787 textDocument/codeAction             1ms
  788 textDocument/documentSymbol         0ms
  791 textDocument/codeAction             1ms
* 779 textDocument/documentSymbol         0ms
  781 rust-analyzer/inlayHints            6ms
  782 textDocument/completion             7ms

You can find the code with a Dockerfile to reproduce the environment here

Any plans to work on this? Is there anything blocking this?

Similar issue with wasm_bindgen :/ (no typings and no type completion)

Any plans to work on this? Is there anything blocking this?

In short, what needs to be done to get this working is:

Record derive helper attributes, so that they can later be resolved (this is just to avoid false positives from the next step)
Resolve attributes on items during name resolution (done in #7049, but without the above step)
Let it bake for a while and fix any false positives that come up
Change name resolution to not process items until all attached attributes are resolved (this can ignore proc. macro attributes to keep the current behavior)
When an attribute gets resolved to a proc. macro, expand it like we do for custom derives, but replacing the original item

I think this is the best place to put this issue.
I have a macro that adds a field to a struct.
For example:
#[add]
struct S;

Gets expanded to:
struct S { pub field: T }

While this compiles without a problem, rust-analyzer reports: no such field.

Missing autocompletion is just a symptom of the fact that attribute proc macros are currently unimplemented.

Yeah, would this explain why mockall_double #[double] macro doesn't work?

Are there any plans to support this feature？

Yes, it's on the roadmap for the next six weeks: #8486

Oh, finally 🎉 🎉


Error when sending to apple store connect

This error occurs when sending to apple store connect

TMS-90429: Invalid Swift Support - The files libswiftDarwin.dylib, libswiftMetal.dylib, libswiftCoreAudio.dylib, libswiftsimd.dylib, libswiftQuartzCore.dylib, libswift_Concurrency.dylib, libswiftos.dylib, libswiftObjectiveC.dylib, libswiftDispatch.dylib, libswiftCoreLocation.dylib, libswiftAccelerate.dylib, libswiftCoreGraphics.dylib, libswiftCoreData.dylib, libswiftCoreFoundation.dylib, libswiftUIKit.dylib, libswiftCoreMedia.dylib, libswiftAVFoundation.dylib, libswiftCore.dylib, libswiftFoundation.dylib, libswiftPhotos.dylib, libswiftCoreImage.dylib aren’t at the expected location /Payload/Runner.app/Frameworks. Move the file to the expected location, rebuild your app using the current public (GM) version of Xcode, and resubmit it.

Please help me fix this

please add the solution @rr8733380

773852362


🌱  Bump golang.org/x/net to v0.24.0 and golang to v1.21.9

Manual cherry-pick #1585

test-ubuntu-e2e-integration-release-1-6

/test-ubuntu-e2e-integration-release-1-5

/test-ubuntu-e2e-integration-release-1-6