s3 tables support

Is your feature request related to a problem? Please describe.
I would like to be able to read/write/insert/upsert data into s3 tables (I know this feature has just been announced but I'm super excited about it).
Describe the solution you'd like
Having a method similar to awswrangler.athena.to_iceberg() to write data to s3 (and same for reading, etc...)
Describe alternatives you've considered
Manage Iceberg tables myself.
Additional context

(I know this feature has just been announced but I'm super excited about it)

I know, right? I came over here just to see if support for that feature was planned!

Thanks for opening this and for your enthusiasm! This is indeed in our radar, however several elements of the service are still in preview (e.g. Integration with the Glue catalogue). We will be monitoring progress and developing an API when it's stable


Workaround for MAC Support

added state variable to prevent rendering of a frame before a JFXPanel is
attached to a JFrame.

Hi Joe,
I am not on my MAC now...I can try to check the version later.
About my code, I didnt do anything much.
  public static void main(String[] args) {
  	RacerGame rg = new RacerGame();
  }
}```

```import javax.swing.*;
import java.awt.*;
import java.awt.event.*;

public class RacerGame{
	public int SCREEN_WIDTH = 600;
	public int SCREEN_HEIGHT = 600;

	Racer r = new Racer();

	JFrame window = new JFrame();
	private JPanel mainPanel = new JPanel();
	private JPanel buttonPanel = new JPanel();
	private JPanel scorePanel = new JPanel();

	FlowLayout mainLayout = new FlowLayout();

	public RacerGame(){

        mainPanel.setLayout(mainLayout);

        mainPanel.add(r.getPanel());
        mainPanel.add(scorePanel);
        mainPanel.add(buttonPanel);

        window.setTitle("Racer");
        window.setSize(SCREEN_WIDTH, SCREEN_HEIGHT);
        window.setContentPane(mainPanel);
        window.setVisible(true);

        r.start();

        while(r.isPlaying())
            r.update();
	}
}```

ta - code looks fine.
MAC implementation of Java is rather flaky compared to other OS... if you're not on the latest version, cna you try an update?

No problem thanks.
I suspect that might be the problem. I dont remember updating it lately.

Still nothing...
Java version "1.8.0_25"
Java(TM) SE Runtime Environment (build 1.8.0_25-b17)
Java HotSpot(TM) 64-Bit Server VM (build 25.25-b02, mixed mode)
MacOS Sierra
Version: 10.12.3 (16D32)


Issue with k8s.io/docs/reference/command-line-tools-reference/kube-controller-manager/

This is a Bug Report

Problem:
Two different parts of the documentation imply that the terminated-pod-gc-threshold configuration value is two different units.
https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-lifetime implies that terminated-pod-gc-threshold is in seconds:
"The only exception to this rule is that Pods with a phase of Succeeded or Failed for more than some duration (determined by terminated-pod-gc-threshold in the master) will expire and be automatically destroyed."
https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/ implies that it is a number of pods:
"Number of terminated pods that can exist before the terminated pod garbage collector starts deleting terminated pods. If <= 0, the terminated pod garbage collector is disabled."
Proposed Solution:
Update one page or the other to reflect the unit of terminated-pod-gc-threshold.
Page to Update:
https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/
and/or
https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-lifetime

/kind cleanup
/priority backlog

Also:
/help

If anyone wants advice on how to tackle this issue, reply and mention me. I'll try to help.

@sftim
I checked related source codes.
Explanation of the following URL is correct.
https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/
Related source codes
https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/podgc/gc_controller.go
https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/podgc/doc.go
// Package podgc contains a very simple pod "garbage collector" implementation,
// PodGCController, that runs in the controller manager. If the number of pods
// in terminated phases (right now either Failed or Succeeded) surpasses a
// configurable threshold, the controller will delete pods in terminated state
// until the system reaches the allowed threshold again. The PodGCController
// prioritizes pods to delete by sorting by creation timestamp and deleting the
// oldest objects first. The PodGCController will not delete non-terminated
// pods.

So, I think the description of pod-lifetime should be modified.
https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-lifetime
"The only exception to this rule is that Pods with a phase of Succeeded or Failed for more than some duration (determined by terminated-pod-gc-threshold in the master) will expire and be automatically destroyed."

In the above description, the expression of some duration is not wrong, but misleading expressions.
some duration precisely means is as follows.
It takes a certain amount of time until the number of pods with a phase of Succeeded or Failed exceed the value set for terminated-pod-gc-threshold.

Therefore, So, I think the description of pod-lifetime should be modified.
If you agree with my opinion, I handle this issue.

/assign

@hase1128 it sounds like you've already got a handle on what to do to fix this issue
If that's right, I'm happy to let you pick the best approach.
In https://github.com/kubernetes/website/pull/15374 I've a draft set of changes to document all built-in controllers. I'll be happy to incorporate recommended wording into a revision to that PR.

@sftim
sorry for my late response, and thank you for the information of a draft set.
I will do PR next week. (currently, I am a little busy....)

@sftim
I have few questions.
Q1:
I handled this issue and do PR, but this PR handle English document only.
I am Japanese. Should I modify Japanese document ( and other language documents)?
Q2:

In #15374 I've a draft set of changes to document all built-in controllers.
I'm sorry, I would like to know detail procedure to add my modification into #15374.
(This PR is my first one, so I am not yet familiar with this work...)

FYI, the Japanese PR has been merged :)


bridge: Fix dependency declaration, switch to setup.cfg based configuration

tools/bridge/setup.py fails to declare the needed dependencies. We should fix that so that a installation with pip could have a chance to succeed.
Also, please start using setup.cfg based configuration. The tools/quickstart script folder already uses that (look at setup.py and setup.cfg there).

@schmir-at-bb should I get rid of the setup.py at all? I would love to. I guess pyproject.toml is one step too far for the moment.


Fixed minor typo.

IIUC this is correct and the statement is saying that this breaking behavior is for next major version which is 6...
cc @calda @xedin

Yes -- we're saving the source-breaking changes for Swift 6. In Swift 5.8, incorrect usage of implicit self will be a warning rather than an error.

Got it. Thanks.


build: add Dockerfile

Add a Docker file to build a fatd Docker image based on alpine 3.9

As a start this looks good. Thank you. I'm going to merge it.
Some thoughts on possible improvements that I'd like to hear your opinion on.
Does it make sense to also install fat-cli in the container? It could be used by someone who wants to mess with fatd from a shell inside the container.
Does it make sense to also install bash completion for fatd (and fat-cli if installed)? If you get a shell in the container it would be helpful.
Would it ever make any sense to create a container that bundles factomd in the container?

Oh does the docker run command need options to expose the fatd API port?

Good questions, I am not a Docker expert so I will answer to the best of my knowledge, I will try to ask Jay C. if he can give us his perspective too.

I remember back on the early testnet days the factomd container was packed with a factom-cli. I personally didn't find it practical, mostly because I could never remember by heart the lengthy docker command required to get the shell session... It had a fair use in tutorials though, where the use could copy paste the whole command. I am  wondering if it is a common/best practice to put CLIs in Docker containers, as to me the point of Docker is to rather run services than command line tools.

I am not sure how fatd completion could work though? Because the completion should happen at the end of the docker run command, not sure it is possible, as it is a command outside of the container.

If we decide to add the fat-cli inside the container then yes adding autocompletion for it makes sense.

I believe that Docker philosophy is to have one container per service. fatd is a service, factomd is an independent service, they should live in separate containers. For instance usually you will have a posgres container running independently rather than having postgres directly bundled in the same container as your app. This what Open API did for instance.

In the readme I used the flag --network=host for the docker run command, for the container to be able to access a factomd instance running on localhost. With the host network, ports are automatically exposed so nothing else would be required. If you don't use the host network then you would need to use -p 8078:8078 to expose the fatd API.

Seems like it wouldn't hurt to include it but I agree that most of the time a user will not want to get a prompt inside the container and run commands from there. but if I did I'd want fat-cli to be there.

I was only referring to completion within the container. not fatd completion for the end of the docker run command. Again I agree that this is of very limited utility. How often would a user need completion to invoke fatd from within the container? probably not often, maybe not ever.

same as 2 pretty much.

Makes sense. thanks for explaining that.

OK. that works. people who use docker presumably would know to do that.

Hi all. Paul reached out to me the other day about this discussion you're having. Here are some of my thoughts:

One major process per container is the correct philosophy, so putting fatd and factomd in the same container would be a mistake.

Dropping the CLI in the image is probably a good thing and shouldn't negatively impact anything.

Shelling into containers for all kinds of reasons is really common. Command completion might be a bit overkill (but not out of the question) but making the container easy to understand and use from the inside is a huge plus.

The pattern for getting a shell looks like:

Running container: docker exec -it container_name /bin/sh
New container: docker run -it foo/bar:tag /bin/sh or docker run -it --entrypoint /bin/sh foo/bar:tag depending on how the image is structured.

Multistage builds are your friend. They allow you to create intermediate images in which you can do work and then copy that work into your final image. For example, you could build your Go binary in one image, and copy the final product into an Alpine image. The build image would be discarded:

FROM golang:alpine AS build
COPY your assets into the image
RUN go to build your project

FROM alpine
COPY --from=build /go/bin/fatd /path/to/fatd
ENTRYPOINT /path/to/fatd

This simple example would result in an Alpine image that only had your fatd binary in it. All of the Go build stuff would be discarded. The resulting image would be very small, which is nice.

You shouldn't run your daemon process as root. You'll want to create a non-root user and then switch to that user before running fatd.

Putting this all together, here is a quick crack at a Dockerfile for your project. Not tested!
FROM golang:alpine AS build

WORKDIR /go/src

COPY your_source_code .

RUN the_go_build

FROM alpine:latest

WORKDIR /home/app # <-- I'm a fan of putting everything under here

COPY --from=build /go/bin/fatd .
COPY --from=build /go/bin/fat-cli .

RUN set -xe && \
  apk add --no-cache shadow && \
  groupadd -g 1000 app && \
  useradd -r -m -u 1000 -g app app && \
  chown -R app:app .

USER app

VOLUME /home/app/config

ENTRYPOINT ["./fatd"]

CMD ["command", "args", "go", "here"]

Hope that is useful.

Thanks @jcheroske for chiming in. About 6, I did try to use a non root user to start fatd but I hit a blocker when trying to mount the volume storing the fatd db (when running docker run -v "fatd_db:/fatd.db" as it seems the volume mounted is necessarily owned by root. Is that what your command VOLUME /home/app/config could help solve? What does this command does here exactly?
Otherwise it looks pretty much like what I did in this PR.

VOLUME isn't really necessary. You can read about it here: https://docs.docker.com/engine/reference/builder/#volume. It's mostly just for self-documentation. The EXPOSE command is kinda similar in that way.
I didn't actually look at the files in this PR before I started ranting! I'm glad we're thinking along the same lines.
As for the permission problem when running as non-root, I haven't run into that. I've run locally and on k8s, and everything has worked fine for me. The uid of the user you create inside the container is the same uid that the container will run as on the host system. So, if you created a uid 1000 user inside your container, it will run as uid 1000 on the host. If you grant permissions to that uid or start the container with a different uid (--user flag) you should be able to get things working. This explains all that: https://medium.com/@mccode/understanding-how-uid-and-gid-work-in-docker-containers-c37a01d01cf

Can you post a sample config file? I'm curious about its format and content.

There is no config file. The volume created is for persisting the database created by fatd. Similar to the setup we have for factomd.

So there's no config file at all? How do you tell fatd where to find its factomd backend for instance?

@jcheroske With the use of flags during startup of fatd from the command line


SwiftLint 0.17 support

On the 24th of March 2017 we got SwiftLint 0.17. It has some breaking changes and some new rules. It would be great to support it 😄 .

Sounds good to me 👍 I'm very busy this week, so truly any help would be welcome.

Awesome to bring this up.
In terms of breaking changes, what exactly is needed from us?
My understanding reading the docs was that the breaking changes are related to few rules only and not to the CLI (which we call). If that is true then simply bumping swiftlint version would get it done wouldn't it? =)


Library request: gurobipy

Expected Behavior
gurobipy i is a mathematical optimization software library for solving mixed-integer linear and quadratic optimization problems.
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

Closing while awaiting vendor response.


Imgpkg describe fails to print the output for the larger images

What steps did you take:
$imgpkg describe -b somebundle.oci.image:tag --json
$

What happened:
Imgpkg describe took more than 5 minutes and failed to print anything.
When the bundle size is small it prints the output. But, for a specific bundle which has 118 image references took more than five minutes and printed nil output in the UI.
What did you expect:
Performance of imgpkg has to be improved to print the description for larger images.
Anything else you would like to add:
[Additional information that will assist in solving the issue.]
Environment:

imgpkg version (use imgpkg --version): v0.41.1
Docker registry used (e.g. Docker HUB):
OS (e.g. from /etc/os-release):

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

We have recent added this feature to show layers digest of each image slows down the performance of image package.
Need to reduce the time taken to describe command while showing the image digests for each lmage.


graduate MatchLabelKeysInPodAffinity to beta

The doc update to graduate MatchLabelKeysInPodAffinity to beta.
Part of https://github.com/kubernetes/enhancements/issues/3633

/sig scheduling

@dipesh-rawat Thanks, updated.

/cc @Huang-Wei

/lgtm

Hey @sanposhiho :wave: please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday March 12th 2024 18:00 PST. Thank you!

This is already under review so just a friendly reminder :)

Unfortunately we couldn't make it in the code freeze.
https://github.com/kubernetes/enhancements/issues/3633#issuecomment-1981634586
/close

Heads up that dev-1.31 branch is created now, if you choose to reopen this for the new release.

/reopen

Hello @sanposhiho 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday July 30th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

/cc @Huang-Wei
for the review from SIG.
Who should I ask for the approval from SIG-docs?

/approve


Poison Mushroom Sprites

Have a little pixel look doesn't right in Poison Mushroom Sprites (that it)

I don't understand what you're trying to say. Could you maybe try to reword it?

Sorry, I don’t speak English as well:
You need check again the poison mushroom’s sprites

It looks right to me.

There! Has a white pixel at the bott

om


Publish events on each car change of status. Closes #28

If the logic is good, same changes (car status + calling change_status) from take_picture should be added in upload_image, detect_traffic_light etc
But I wasn't sure, so I choosed to keep the code clean from small modifications

Buna dimineata,
Din pacate nu voi putea participa la sesiunea de laborator de astazi.
Ar fi fost randul meu sa completez tema. Am facut un nou commit, unde cred
ca am implementat ce s-a cerut, dar flow-ul programului nu e cel care
trebuie, ramane "blocat", apeland functia take_picture de fiecare data.
N-am reusit sa imi dau seama de problema.
Dupa commit mi-a aparut din nou optiunea de "Re-Request review" (mi se
parea important de mentionat).
Imi pare rau ca anunt asa pe final, nici eu nu am stiut, a aparut ceva
neprevazut. Voiam sa va rog, daca se poate, sa inregistrati sesiunea.
Multumesc frumos,
Alexandra
În vin., 15 mai 2020 la 10:01, Petru Flueras<EMAIL_ADDRESS>a
scris:

@pflueras requested changes on this pull request.
Some necessary changes are required.
In rpi/boundary/car_event_processor.py
https://github.com/pflueras/robbie9-2020/pull/29#discussion_r425597504:

@@ -0,0 +1,13 @@
+from pydispatch import dispatcher

+from car.car import Car
+
+class CarEventProcessor:

def init(self, car: Car):

   self._car = car

Register individually each specific CarStatus state (event)
In rpi/car/car.py
https://github.com/pflueras/robbie9-2020/pull/29#discussion_r425598901:

@@ -39,5 +39,7 @@ def stop(self):
self._motor3.stop()
self._motor4.stop()

def take_picture(self, image_filename):

def take_picture(self, image_filename, car_event_processor):

   self.status = CarStatus.TAKE_PICTURE

Please send events from CarThread. car package has the responsibility to
communicate with car hardware.
In rpi/service/car_thread.py
https://github.com/pflueras/robbie9-2020/pull/29#discussion_r425599479:

     super(CarThread, self).__init__()

     self._car: Car = car
     self._imageAnalysisService: ImageAnalysisService = image_analysis_service
     self._running = True

   self.car_event_processor = car_event_processor

def run(self) -> None:
while self._running:

Send event for each now status change.
In rpi/service/car_thread.py
https://github.com/pflueras/robbie9-2020/pull/29#discussion_r425600891:

class CarThread(Thread):

def init(self, car: Car, image_analysis_service: ImageAnalysisService):

Instead of using CarEventProcessor object, please emit status change
events with dispatcher.send(...) method.
In rpi/boundary/car_event_processor.py
https://github.com/pflueras/robbie9-2020/pull/29#discussion_r425603231:

@@ -0,0 +1,13 @@
+from pydispatch import dispatcher

+from car.car import Car
+
+class CarEventProcessor:

def init(self, car: Car):

   self._car = car

   dispatcher.connect(self.change_status, signal=self._car.status, sender=self._car)

def change_status(self, message, car_status):

   print(message)

   print("Status has changed: ", car_status)

dispatcher.send(...) has to be performed from CarThread class (Service
class)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pflueras/robbie9-2020/pull/29#pullrequestreview-412385247,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APMPDKQHMJULUO6DAJUAYP3RRTSDXANCNFSM4NA5LODQ
.


If I try to move VScode into one monitor to the other monitor it crashed.

VSCode Version: Code 1.16.1 (27492b6bf3acb0775d82d2f87b25a93490673c6d, 2017-09-14T16:38:09.760Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:
Server.js

Package.json

Extension
Author (truncated)
Version

path-intellisense
chr
1.4.2

debugger-for-chrome
msj
3.3.1

react-beautify
tai
0.3.0

ReactSnippetsStandard
Tim
1.1.0

jsx
Twe
0.0.1

vscode-react-native
vsm
0.4.2

ReactSnippets
xab
1.4.0

I am currently working on a react and redux project.
While I run the node server.js in a one terminal and webpack in a another terminal.my localhost was running. I try to move the VScode window to one monitor to the other monitor. Every time Vscode window crashed. Had to reopen windows again. Why ?
I will attached my server.js and package.json file to identify my installed packages and my server also.
Localhost port 3000 its ran.
Steps to Reproduce:
1.while running the VSCode try to see some console logs in Firefox browser / chrome browser.
2.Move VScode window to one monitor to the other monitor. Suddenly it will get crash.

Reproduces without extensions: Yes/No

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders


New web steps for tabs and frames.

FORCE_CLICK web action.
Documentation for web steps amended.

Generated reports

Generated reports

@thradec Given annotation added.

Generated reports


Add support for --password option

git-svn doesn't support yet but it will!

@nirvdrum it would be really helpful if you could merge this so it's authoritative. svn itself supports it, and soon enough git-svn will.

I take it's backwards-compatible?  No-op is fine.  I just don't want to raise exceptions on people running older versions of git-svn.

It will cause some kind of problem if people specify a --password and installed svn doesn't support that. However, surely no harm done?

Remember, that exception could only happen if people

have a pre-2008 (at least) copy of SVN
specify a --password

Is this really a problem? The error message will surely be very clear.

That should be fine then.  I have a full matrix of versions I end up testing against.  Since Ubuntu 10.04 LTS is now rolling out of its support phase, that will bump a bunch of people up version-wise anyway.
Can you please make a documentation addition for the new option as well?

@nirvdrum Done!

Thanks!

I'll try to take a pass through some other stuff this weekend and do a new release.

:+1:


versions association set order to "DESC"

I have been searching for a way to get for example: Widget.versions.order("created_at DESC") and not the default ASC as I see in the code on https://github.com/airblade/paper_trail/blob/master/lib/paper_trail/version_concern.rb#L77
However, I didn't found a way to overwriting this. For while I'm using the reverse method from ruby (http://stackoverflow.com/questions/23251749/default-sort-versions-with-papertrail?answertab=active#tab-top), but this is not the best way to do this.
How can I do this better?

Please see #448

Thanks @batter


add citation styles to q2view details page

It would be convenient for citations to be formattable in different styles before download.  We had a previous PR (#101) that can be used as a reference for this one. (That PR is closed b/c the code itself would need to be reworked for the ongoing q2view updates.)

@gregcaporaso this ought to be at least mostly working in the rewrite adapted from @David-Rod's code

Closed in qiime2/q2view


Blur position and zOrder fix

Fixed Incompatible mods checker blurred background effect when Paradox login popup shown.

testing...


Not working with "react-hook-form": "6.0.0-rc.4"

Does devtools have a working version compatible with newest react hook form?
Thanks :)

you will have to use 2.0.0-beta.2

I'll check soon and reopen in case there are any troubles :) thanks

sounds good to me :)


Fix failed assertion and memory leak with event listeners

Describe your changes
This solves an issue that was fixed for Cocos2d-x v3.16 and then reverted afterwards for "backwards compatibility".
I don't think we need this backwards compatibility anymore, and the benefits to cleaning up this memory outweigh the potential for some developers to need to refactor their code.
Specifically this also solves an ASSERT that fails when quitting the game on a scene which has nodes with Event Listeners that I experienced without this change, and with the Config.h setting AX_NODE_DEBUG_VERIFY_EVENT_LISTENERS enabled.
The issue I opened for this is listed below for additional discussion if this is the right solution or not (though I don't personally see much harm in doing this, perhaps this will require many of you to refactor your code that moves a Node from one parent to another).
I did replace the old Cocos2d-x comment here with one that describes the issue and what to do to avoid the cleanup if desired as well to hopefully help anyone who might update who relied on the old behavior.
Issue ticket number and link
#1836
Checklist before requesting a review
For each PR

[x] Add Copyright if it missed:
- "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

[x] I have performed a self-review of my code.
Optional:

[ ] I have checked readme and add important infos to this PR.
[ ] I have added/adapted some tests too.

For core/new feature PR

[ ] I have checked readme and add important infos to this PR.
[ ] I have added thorough tests.

From a first glance this change might have quite big unintended consequences, so I hope this will be thoroughly reviewed.
One of the bigger problems might be is that Node::removeFromParent() calls removeFromParentAndCleanup(true), but it sounds like it shouldn't, cause that with current change might cause issues. But the removeFromParent() method sounds like the one that user is supposed to use if he wants to remove a node from a parent, and I guess a lot of people do. Had a quick glance on our games, and they call removeFromParent() a lot.

But the removeFromParent() method sounds like the one that user is supposed to use if he wants to remove a node from a parent, and I guess a lot of people do.

This is true but is only an issue if you're removing a Node from a parent so you can add it as a child to another parent. If you're simply removing a Node from it's parent with the removeFromParent() function in order to get rid of that Node, then this change does nothing except cleanup leaked memory for that Node's event listeners.
If you are removing a Node from its parent to add it as a child to another Node, then you simply need to pass in a value of false to the removeFromParent() function call.
Hopefully this addresses your concerns!

This PR introduces the correct behaviour. A minor inconvenience now for developers affected by it is, in my opinion, well worth it.  The benefit is not having to remember that the event listeners need to be released separately when a node is removed from the parent, and the removal of code associated with this task.
If this PR is merged in, then the difference in behaviour should be listed in the Cocos2d-x to Axmol migration guide.

I don't like the way this was handled and that there was no discussion at all to find the best solution for the problem. I understand that the fix is "correct", but the biggest problem is that this fix changes the behavior and breaks the projects silently. I would have preferred a fix that would break the compilation to make you stop and review the usage places.
I also think it's unfortunate that these method names and their combination are a bit misleading. There are 2 methods: removeFromParent() and removeFromParentAndCleanup(bool cleanup). It sounds like removeFromParent() just removes the node from a parent, ie something you'd want to do if you wanted to attach it to another node, while removeFromParentAndCleanup(bool cleanup) sounds like it also does a cleanup, something you would do before destruction.
IMHO a better fix would have been to remove removeFromParentAndCleanup(bool cleanup), since there's no reason to have two different methods for doing the same thing, and change removeFromParent() to removeFromParent(bool cleanup) with an explicit cleanup parameter and adding clear method documentation about the parameter's consequences. This would have forced people to review their code, and also hopefully would make people think when they are removing nodes in the future.

IMHO a better fix would have been to remove removeFromParentAndCleanup(bool cleanup), since there's no reason to have two different methods for doing the same thing, and change removeFromParent() to removeFromParent(bool cleanup) with an explicit cleanup parameter and adding clear method documentation about the parameter's consequences. This would have forced people to review their code, and also hopefully would make people think when they are removing nodes in the future.

Is there any reason to not make this change to removeFromParent? It's a good way to bring attention to that call.  I agree that removing removeFromParentAndCleanup is required, because the change to removeFromParent is a breaking change anyway.

I also agree with @smilediver's proposed change, with the exception that I think cleanup should be implicitly set to "true" by default, so as to provide the correct memory cleanup behavior out of the box. If people need to modify it because they don't cleanup their memory, or manage it another way, then they can just make a small tweak to the source code there and change it to false implicitly.

IMHO a better fix would have been to remove removeFromParentAndCleanup(bool cleanup), since there's no reason to have two different methods for doing the same thing

I agree with your general premise, and outlined above why I disagree with a part of it. I've made a pull request with the change you suggested as well as my suggestion for cleanup to be implicitly defaulted to true with #1840
Thanks for your suggestion!


Infinite Dimlet Parcel

Whilst just playing in a survival world, i discovered that using a Dimlet Parcel in the offhand doesn't consume the parcel and instead deletes items from the main hand.

Fixed in next release


Speed-up cross-match methods by using native Scala methods

Speed-up is at least x2!

Codecov Report

Merging #58 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   98.92%   98.87%   -0.05%
==========================================
  Files          19       19
  Lines         743      712      -31
  Branches      199      196       -3
==========================================
- Hits          735      704      -31
  Misses          8        8

Impacted Files
Coverage Δ

...com/spark3d/spatialOperator/CenterCrossMatch.scala
100% <100%> (ø)
:arrow_up:

.../com/spark3d/spatialOperator/PixelCrossMatch.scala
98.03% <100%> (-0.52%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072802e...fe26ef9. Read the comment docs.


multiline inputs are not handled corerctly

if a secret or value contains multiline, it does not handle correctly.

resolved


doesn't work on teachable

I get error 403. Username and password are correct, and my youtube-dl is up to date.

C:\Users\Kristine Berthelsen\Downloads>youtube-dl https://edmprod.teachable.com/courses/1706460/lectures/38693626 --username USERNAME --verbose flag
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://edmprod.teachable.com/courses/1706460/lectures/38693626', '--username', 'PRIVATE', '--verbose', 'flag']
Type account password and press [Return]:
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: none
[debug] Proxy map: {}
[generic] 38693626: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 38693626: Downloading webpage
[generic] 38693626: Extracting information
[Teachable] Downloading edmprod.teachable.com login page
ERROR: Unable to download webpage: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\common.py", line 634, in _request_webpage
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\YoutubeDL.py", line 2288, in urlopen
File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default

Try providing --cookies ... from your logged-in browser session instead of --username/password .... Typically, extractor login using username and password breaks because sites change the login page, require Captcha, etc.
Also, just --verbose, not --verbose flag, but that doesn't affect access to the site.

Closing for lack of response.

https://github.com/FallingLights/Teachable-dl?tab=readme-ov-file, this works

https://github.com/FallingLights/Teachable-dl , this works for me at this moment


Add deprecation notice

Preview: https://github.com/jvoravong/splunk-otel-collector-operator/tree/deprecation-notice?tab=readme-ov-file#warning-project-deprecated-as-of-december-2023

Closed in favor of https://github.com/signalfx/splunk-otel-collector-operator/pull/380


Add the readme structure for maintainers

@kacf
Something like this.
(I'm having issues with the signature git commit -S is not letting go of attempts to sign with gpg.
Will get back to see how to fix it.)

Note that it's lowercase -s to sign off, it's unrelated to gpg signing.

Thanks.
The price I pay for trying to ramp up thing with half of my brain. :)

:+1:


BUG: Download overwrites objects with same name

if objects of same type have the same name in dynatrace, then only one of them is written in the download process
ie: ./terraform-provider-dynatrace download https://xxx.live.dynatrace.com xxxx
Name is not unique in dynatrace, so plugin executable should use either the object's id in the filename  or a counter.

Release v1.2.2 will contain a solution for this issue.

Hello @colinsidi,
With release v1.2.2 the resulting .tf files will include the unique ID within their names (where possible) in order to avoid overwriting resources with the same name and different unique IDs.


TypeError: undefined is not a function (evaluating 'Object.assign({}, WEBPACK_IMPORTED_MODULE_0__v_tooltip["a" /* defaultOptions */], options || {})')

I use 2.0.0-beta.8 and it works well in the browser, but it crashes on unit testing.

sorry, it was not v-tooltip issue, I had to add babel-polyfill to karma.


add metaspan delegate details for kusama & polkadot

https://kusama.subscan.io/extrinsic/19228450-4

Do you need an extrinsic for polkadot too?

Do you need an extrinsic for polkadot too?

Hello!
Yes, please, you provide accounts from different secrets, so I can't say that both is yours

remark for polkadot
https://polkadot.subscan.io/extrinsic/16883802-2

Hello @dcolley ,
Thank you for request!
Sorry for the delay, there is how it will looks like int the app after suggested changes:

Screens

Also, please, add your image to our repo in order to make sure, that our client will be able to support that, thank you!

@stepanLav is the background of the app always black/dark? If so I will load a different logo.

@dcolley
sorry for the delay, this is how it will look like in the app:

App screens

@dcolley
You have conflicts in PR, could you resolve them please?

Resolved, thanks

sorry for the delay, I've created separate PR in order to merge it without conflicts, as yours has got another one
https://github.com/novasamatech/opengov-delegate-registry/pull/81


Update required PyYAML version

PyYAML version 5.1+ is required as earlier versions do not have FullLoader attribute.

Could not start vmware_exporter on CentOS 8 with PyYAML module installed from packages, latest PyYAML version in packages currently is python3-pyyaml-3.12-12.el8.x86_64:
Python 3.6.8 (default, Apr 16 2020, 01:36:27)
[GCC 8.3.1 20191121 (Red Hat 8.3.1-5)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import yaml
>>> yaml.__version__
'3.12'
>>> yaml.FullLoader
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'yaml' has no attribute 'FullLoader'
>>> from yaml import FullLoader
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name 'FullLoader'
>>> from yaml import FullLoader
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name 'FullLoader'

Python 3.6.8 (default, Apr 16 2020, 01:36:27)
[GCC 8.3.1 20191121 (Red Hat 8.3.1-5)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import yaml
>>> yaml.__version__
'5.3.1'
>>> yaml.FullLoader
<class 'yaml.loader.FullLoader'>

Forgot to mention vmware_exporter error in previous comment, it was following:
$ /usr/local/bin/vmware_exporter --config /etc/vmware_exporter/config.yml --loglevel WARNING
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/vmware_exporter/vmware_exporter.py", line 1777, in configure
    self.config = yaml.load(cf, Loader=yaml.FullLoader)
AttributeError: module 'yaml' has no attribute 'FullLoader'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/vmware_exporter", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.6/site-packages/vmware_exporter/vmware_exporter.py", line 1954, in main
    factory = Site(registerEndpoints(args))
  File "/usr/local/lib/python3.6/site-packages/vmware_exporter/vmware_exporter.py", line 1930, in registerEndpoints
    root.putChild(b'metrics', VMWareMetricsResource(args))
  File "/usr/local/lib/python3.6/site-packages/vmware_exporter/vmware_exporter.py", line 1771, in __init__
    self.configure(args)
  File "/usr/local/lib/python3.6/site-packages/vmware_exporter/vmware_exporter.py", line 1784, in configure
    raise SystemExit("Error while reading configuration file: {0}".format(exception.message))
AttributeError: 'AttributeError' object has no attribute 'message'

Thank you for your contribution.


Heroku error when opening website.

After you use the Heroku launch button after the juice shop is deployed on Heroku when going to the site you get, "An error occurred in the application and your page could not be served. If you are the application owner, check your logs for details. You can do this from the Heroku CLI with the command
heroku logs --tail"

Can you provide that mentioned Heroku logfile, otherwise there's no way we could help you.

Can you provide that mentioned Heroku logfile, otherwise there's no way we could help you.

The log from heroku:
-----> Building on the Heroku-20 stack
-----> Determining which buildpack to use for this app
-----> Node.js app detected
-----> Creating runtime environment
   NPM_CONFIG_LOGLEVEL=error

   NODE_VERBOSE=false

   NODE_ENV=production

   NODE_MODULES_CACHE=true

-----> Installing binaries
   engines.node (package.json):  10 - 14

   engines.npm (package.json):   unspecified (use default)

   Resolving node version 10 - 14...

   Downloading and installing node 14.16.0...

   Using default npm version: 6.14.11

-----> Installing dependencies
   Installing node modules (package.json)

   ><EMAIL_ADDRESS>install /tmp/build_ac2d316d/node_modules/sqlite3

   > node-pre-gyp install --fallback-to-build

   [sqlite3] Success: "/tmp/build_ac2d316d/node_modules/sqlite3/lib/binding/napi-v3-linux-x64/node_sqlite3.node" is installed via remote

   ><EMAIL_ADDRESS>install /tmp/build_ac2d316d/node_modules/iltorb

   > node ./scripts/install.js || node-gyp rebuild

   info looking for cached prebuild @ /tmp/npmcache.mmOCv/_prebuilds/c57c4d-iltorb-v2.4.5-node-v83-linux-x64.tar.gz

   http request GET https://github.com/nstepien/iltorb/releases/download/v2.4.5/iltorb-v2.4.5-node-v83-linux-x64.tar.gz

   http 404 https://github.com/nstepien/iltorb/releases/download/v2.4.5/iltorb-v2.4.5-node-v83-linux-x64.tar.gz

   WARN install No prebuilt binaries found (target=14.16.0 runtime=node arch=x64 libc= platform=linux)

   make: Entering directory '/tmp/build_ac2d316d/node_modules/iltorb/build'

     CC(target) Release/obj.target/iltorb/brotli/c/common/dictionary.o

     CC(target) Release/obj.target/iltorb/brotli/c/common/transform.o

     CC(target) Release/obj.target/iltorb/brotli/c/dec/bit_reader.o

     CC(target) Release/obj.target/iltorb/brotli/c/dec/decode.o

     CC(target) Release/obj.target/iltorb/brotli/c/dec/huffman.o

     CC(target) Release/obj.target/iltorb/brotli/c/dec/state.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/backward_references.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/backward_references_hq.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/bit_cost.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/block_splitter.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/brotli_bit_stream.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/cluster.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/compress_fragment.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/compress_fragment_two_pass.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/dictionary_hash.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/encode.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/encoder_dict.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/entropy_encode.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/histogram.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/literal_cost.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/memory.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/metablock.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/static_dict.o

     CC(target) Release/obj.target/iltorb/brotli/c/enc/utf8_util.o

     CXX(target) Release/obj.target/iltorb/src/common/allocator.o

     CXX(target) Release/obj.target/iltorb/src/common/stream_coder.o

     CXX(target) Release/obj.target/iltorb/src/dec/stream_decode.o

     CXX(target) Release/obj.target/iltorb/src/dec/stream_decode_worker.o

     CXX(target) Release/obj.target/iltorb/src/enc/stream_encode.o

     CXX(target) Release/obj.target/iltorb/src/enc/stream_encode_worker.o

     CXX(target) Release/obj.target/iltorb/src/iltorb.o

   In file included from ../../nan/nan.h:56,

                    from ../src/iltorb.cc:1:

   /app/.cache/node-gyp/14.16.0/include/node/node.h:778:51: warning: cast between incompatible function types from ‘void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Context>)’ to ‘node::addon_context_register_func’ {aka ‘void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Context>, void*)’} [-Wcast-function-type]

     778 |       (node::addon_context_register_func) (regfunc),                  \

         |                                                   ^

   /app/.cache/node-gyp/14.16.0/include/node/node.h:796:3: note: in expansion of macro ‘NODE_MODULE_CONTEXT_AWARE_X’

     796 |   NODE_MODULE_CONTEXT_AWARE_X(modname, regfunc, NULL, 0)

         |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~

   /app/.cache/node-gyp/14.16.0/include/node/node.h:827:3: note: in expansion of macro ‘NODE_MODULE_CONTEXT_AWARE’

     827 |   NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME,                     \

         |   ^~~~~~~~~~~~~~~~~~~~~~~~~

   ../src/iltorb.cc:8:1: note: in expansion of macro ‘NODE_MODULE_INIT’

       8 | NODE_MODULE_INIT() {

         | ^~~~~~~~~~~~~~~~

     SOLINK_MODULE(target) Release/obj.target/iltorb.node

     COPY Release/iltorb.node

     COPY ../build/bindings/iltorb.node

     TOUCH Release/obj.target/action_after_build.stamp

   make: Leaving directory '/tmp/build_ac2d316d/node_modules/iltorb/build'

   ><EMAIL_ADDRESS>install /tmp/build_ac2d316d/node_modules/libxmljs2

   > node-pre-gyp install --fallback-to-build --loglevel http

   node-pre-gyp http GET https://github.com/marudor/libxmljs2/releases/download/v0.26.7/node-v83-linux-x64-glibc.tar.gz

   [libxmljs2] Success: "/tmp/build_ac2d316d/node_modules/libxmljs2/build/Release/xmljs.node" is installed via remote

   ><EMAIL_ADDRESS>postinstall /tmp/build_ac2d316d/node_modules/core-js

   > node -e "try{require('./postinstall')}catch(e){}"

   ><EMAIL_ADDRESS>postinstall /tmp/build_ac2d316d

   > cd frontend && npm install && cd .. && npm run build

   ><EMAIL_ADDRESS>postinstall /tmp/build_ac2d316d/frontend/node_modules/@angular-devkit/build-angular/node_modules/core-js

   > node -e "try{require('./postinstall')}catch(e){}"

   ><EMAIL_ADDRESS>postinstall /tmp/build_ac2d316d/frontend/node_modules/@fortawesome/fontawesome-common-types

   > node attribution.js

   Font Awesome Free 0.2.35 by @fontawesome - https://fontawesome.com

   License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License)

   ><EMAIL_ADDRESS>postinstall /tmp/build_ac2d316d/frontend/node_modules/@angular/cli

   > node ./bin/postinstall/script.js

   ><EMAIL_ADDRESS>postinstall /tmp/build_ac2d316d/frontend/node_modules/@fortawesome/fontawesome-svg-core

   > node attribution.js

   Font Awesome Free 1.2.35 by @fontawesome - https://fontawesome.com

   License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License)

   ><EMAIL_ADDRESS>postinstall /tmp/build_ac2d316d/frontend/node_modules/@fortawesome/free-brands-svg-icons

   > node attribution.js

   Font Awesome Free 5.15.3 by @fontawesome - https://fontawesome.com

   License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License)

   ><EMAIL_ADDRESS>postinstall /tmp/build_ac2d316d/frontend/node_modules/@fortawesome/free-regular-svg-icons

   > node attribution.js

   Font Awesome Free 5.15.3 by @fontawesome - https://fontawesome.com

   License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License)

   ><EMAIL_ADDRESS>postinstall /tmp/build_ac2d316d/frontend/node_modules/@fortawesome/free-solid-svg-icons

   > node attribution.js

   Font Awesome Free 5.15.3 by @fontawesome - https://fontawesome.com

   License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License)

   ><EMAIL_ADDRESS>postinstall /tmp/build_ac2d316d/frontend/node_modules/core-js

   > node -e "try{require('./postinstall')}catch(e){}"

   ><EMAIL_ADDRESS>postinstall /tmp/build_ac2d316d/frontend

   > ngcc --tsconfig "./src/tsconfig.app.json"

   Compiling @angular/animations : fesm2015 as esm2015

   Compiling @angular/animations : esm2015 as esm2015

   Compiling @angular/animations : main as umd

   Compiling @angular/core : fesm2015 as esm2015

   Compiling @angular/core : esm2015 as esm2015

   Compiling @angular/core : main as umd

   Compiling @angular/animations/browser : fesm2015 as esm2015

   Compiling @angular/animations/browser : esm2015 as esm2015

   Compiling @angular/animations/browser : main as umd

   Compiling @angular/animations/browser/testing : fesm2015 as esm2015

   Compiling @angular/animations/browser/testing : esm2015 as esm2015

   Compiling @angular/animations/browser/testing : main as umd

   Compiling @angular/common : fesm2015 as esm2015

   Compiling @angular/common : esm2015 as esm2015

   Compiling @angular/common : main as umd

   Compiling @angular/cdk/clipboard : fesm2015 as esm2015

   Compiling @angular/cdk/clipboard : esm2015 as esm2015

   Compiling @angular/cdk/clipboard : main as umd

   Compiling @angular/cdk/platform : fesm2015 as esm2015

   Compiling @angular/cdk/platform : esm2015 as esm2015

   Compiling @angular/cdk/platform : main as umd

   Compiling @angular/cdk/bidi : fesm2015 as esm2015

   Compiling @angular/cdk/bidi : esm2015 as esm2015

   Compiling @angular/cdk/bidi : main as umd

   Compiling @angular/cdk/collections : fesm2015 as esm2015

   Compiling @angular/cdk/collections : esm2015 as esm2015

   Compiling @angular/cdk/collections : main as umd

   Compiling @angular/cdk/scrolling : fesm2015 as esm2015

   Compiling @angular/cdk/scrolling : esm2015 as esm2015

   Compiling @angular/cdk/scrolling : main as umd

   Compiling @angular/cdk/drag-drop : fesm2015 as esm2015

   Compiling @angular/cdk/drag-drop : esm2015 as esm2015

   Compiling @angular/cdk/drag-drop : main as umd

   Compiling @angular/common/http : fesm2015 as esm2015

   Compiling @angular/common/http : esm2015 as esm2015

   Compiling @angular/common/http : main as umd

   Compiling @angular/common/http/testing : fesm2015 as esm2015

   Compiling @angular/common/http/testing : esm2015 as esm2015

   Compiling @angular/common/http/testing : main as umd

   Compiling @angular/flex-layout/core : es2015 as esm2015

   Compiling @angular/flex-layout/core : main as umd

   Compiling @angular/flex-layout/core : module as esm5

   Compiling @angular/platform-browser : fesm2015 as esm2015

   Compiling @angular/platform-browser : esm2015 as esm2015

   Compiling @angular/platform-browser : main as umd

   Compiling @angular/flex-layout/extended : es2015 as esm2015

   Compiling @angular/flex-layout/extended : main as umd

   Compiling @angular/flex-layout/extended : module as esm5

   Compiling @angular/flex-layout/flex : es2015 as esm2015

   Compiling @angular/flex-layout/flex : main as umd

   Compiling @angular/flex-layout/flex : module as esm5

   Compiling @angular/flex-layout/grid : es2015 as esm2015

   Compiling @angular/flex-layout/grid : main as umd

   Compiling @angular/flex-layout/grid : module as esm5

   Compiling @angular/flex-layout : es2015 as esm2015

   Compiling @angular/flex-layout : main as umd

   Compiling @angular/flex-layout : module as esm5

   Compiling @angular/http : fesm2015 as esm2015

   Compiling @angular/http : fesm5 as esm5

   Compiling @angular/http : esm2015 as esm2015

   Compiling @angular/http : esm5 as esm5

   Compiling @angular/http : main as umd

   Compiling @angular/http/testing : fesm2015 as esm2015

   Compiling @angular/http/testing : fesm5 as esm5

   Compiling @angular/http/testing : esm2015 as esm2015

   Compiling @angular/http/testing : esm5 as esm5

   Compiling @angular/http/testing : main as umd

   Compiling @angular/cdk/keycodes : fesm2015 as esm2015

   Compiling @angular/cdk/keycodes : esm2015 as esm2015

   Compiling @angular/cdk/keycodes : main as umd

   Compiling @angular/cdk/observers : fesm2015 as esm2015

   Compiling @angular/cdk/observers : esm2015 as esm2015

   Compiling @angular/cdk/observers : main as umd

   Compiling @angular/cdk/a11y : fesm2015 as esm2015

   Compiling @angular/cdk/a11y : esm2015 as esm2015

   Compiling @angular/cdk/a11y : main as umd

   Compiling @angular/platform-browser/animations : fesm2015 as esm2015

   Compiling @angular/platform-browser/animations : esm2015 as esm2015

   Compiling @angular/platform-browser/animations : main as umd

   Compiling @angular/forms : fesm2015 as esm2015

   Compiling @angular/forms : esm2015 as esm2015

   Compiling @angular/forms : main as umd

   Compiling @angular/material/core : fesm2015 as esm2015

   Compiling @angular/material/core : esm2015 as esm2015

   Compiling @angular/material/core : main as umd

   Compiling @angular/material/badge : fesm2015 as esm2015

   Compiling @angular/material/badge : esm2015 as esm2015

   Compiling @angular/material/badge : main as umd

   Compiling @angular/cdk/portal : fesm2015 as esm2015

   Compiling @angular/cdk/portal : esm2015 as esm2015

   Compiling @angular/cdk/portal : main as umd

   Compiling @angular/cdk/overlay : fesm2015 as esm2015

   Compiling @angular/cdk/overlay : esm2015 as esm2015

   Compiling @angular/cdk/overlay : main as umd

   Compiling @angular/cdk/layout : fesm2015 as esm2015

   Compiling @angular/cdk/layout : esm2015 as esm2015

   Compiling @angular/cdk/layout : main as umd

   Compiling @angular/material/bottom-sheet : fesm2015 as esm2015

   Compiling @angular/material/bottom-sheet : esm2015 as esm2015

   Compiling @angular/material/bottom-sheet : main as umd

   Compiling @angular/material/button-toggle : fesm2015 as esm2015

   Compiling @angular/material/button-toggle : esm2015 as esm2015

   Compiling @angular/material/button-toggle : main as umd

   Compiling @angular/material/checkbox : fesm2015 as esm2015

   Compiling @angular/material/checkbox : esm2015 as esm2015

   Compiling @angular/material/checkbox : main as umd

   Compiling @angular/material/form-field : fesm2015 as esm2015

   Compiling @angular/material/form-field : esm2015 as esm2015

   Compiling @angular/material/form-field : main as umd

   Compiling @angular/material/chips : fesm2015 as esm2015

   Compiling @angular/material/chips : esm2015 as esm2015

   Compiling @angular/material/chips : main as umd

   Compiling @angular/material/button : fesm2015 as esm2015

   Compiling @angular/material/button : esm2015 as esm2015

   Compiling @angular/material/button : main as umd

   Compiling @angular/material/dialog : fesm2015 as esm2015

   Compiling @angular/material/dialog : esm2015 as esm2015

   Compiling @angular/material/dialog : main as umd

   Compiling @angular/cdk/text-field : fesm2015 as esm2015

   Compiling @angular/cdk/text-field : esm2015 as esm2015

   Compiling @angular/cdk/text-field : main as umd

   Compiling @angular/material/input : fesm2015 as esm2015

   Compiling @angular/material/input : esm2015 as esm2015

   Compiling @angular/material/input : main as umd

   Compiling @angular/material/datepicker : fesm2015 as esm2015

   Compiling @angular/material/datepicker : esm2015 as esm2015

   Compiling @angular/material/datepicker : main as umd

   Compiling @angular/cdk/accordion : fesm2015 as esm2015

   Compiling @angular/cdk/accordion : esm2015 as esm2015

   Compiling @angular/cdk/accordion : main as umd

   Compiling @angular/material/expansion : fesm2015 as esm2015

   Compiling @angular/material/expansion : esm2015 as esm2015

   Compiling @angular/material/expansion : main as umd

   Compiling @angular/material/grid-list : fesm2015 as esm2015

   Compiling @angular/material/grid-list : esm2015 as esm2015

   Compiling @angular/material/grid-list : main as umd

   Compiling @angular/material/icon : fesm2015 as esm2015

   Compiling @angular/material/icon : esm2015 as esm2015

   Compiling @angular/material/icon : main as umd

   Compiling @angular/material/icon/testing : fesm2015 as esm2015

   Compiling @angular/material/icon/testing : esm2015 as esm2015

   Compiling @angular/material/icon/testing : main as umd

   Compiling @angular/material/divider : fesm2015 as esm2015

   Compiling @angular/material/divider : esm2015 as esm2015

   Compiling @angular/material/divider : main as umd

   Compiling @angular/material/list : fesm2015 as esm2015

   Compiling @angular/material/list : esm2015 as esm2015

   Compiling @angular/material/list : main as umd

   Compiling @angular/material/menu : fesm2015 as esm2015

   Compiling @angular/material/menu : esm2015 as esm2015

   Compiling @angular/material/menu : main as umd

   Compiling @angular/material/progress-spinner : fesm2015 as esm2015

   Compiling @angular/material/progress-spinner : esm2015 as esm2015

   Compiling @angular/material/progress-spinner : main as umd

   Compiling @angular/material/radio : fesm2015 as esm2015

   Compiling @angular/material/radio : esm2015 as esm2015

   Compiling @angular/material/radio : main as umd

   Compiling @angular/material/sidenav : fesm2015 as esm2015

   Compiling @angular/material/sidenav : esm2015 as esm2015

   Compiling @angular/material/sidenav : main as umd

   Compiling @angular/material/slide-toggle : fesm2015 as esm2015

   Compiling @angular/material/slide-toggle : esm2015 as esm2015

   Compiling @angular/material/slide-toggle : main as umd

   Compiling @angular/material/slider : fesm2015 as esm2015

   Compiling @angular/material/slider : esm2015 as esm2015

   Compiling @angular/material/slider : main as umd

   Compiling @angular/material/snack-bar : fesm2015 as esm2015

   Compiling @angular/material/snack-bar : esm2015 as esm2015

   Compiling @angular/material/snack-bar : main as umd

   Compiling @angular/cdk/stepper : fesm2015 as esm2015

   Compiling @angular/cdk/stepper : esm2015 as esm2015

   Compiling @angular/cdk/stepper : main as umd

   Compiling @angular/material/stepper : fesm2015 as esm2015

   Compiling @angular/material/stepper : esm2015 as esm2015

   Compiling @angular/material/stepper : main as umd

   Compiling @angular/cdk/table : fesm2015 as esm2015

   Compiling @angular/cdk/table : esm2015 as esm2015

   Compiling @angular/cdk/table : main as umd

   Compiling @angular/material/select : fesm2015 as esm2015

   Compiling @angular/material/select : esm2015 as esm2015

   Compiling @angular/material/select : main as umd

   Compiling @angular/material/tooltip : fesm2015 as esm2015

   Compiling @angular/material/tooltip : esm2015 as esm2015

   Compiling @angular/material/tooltip : main as umd

   Compiling @angular/material/paginator : fesm2015 as esm2015

   Compiling @angular/material/paginator : esm2015 as esm2015

   Compiling @angular/material/paginator : main as umd

   Compiling @angular/material/sort : fesm2015 as esm2015

   Compiling @angular/material/sort : esm2015 as esm2015

   Compiling @angular/material/sort : main as umd

   Compiling @angular/material/table : fesm2015 as esm2015

   Compiling @angular/material/table : esm2015 as esm2015

   Compiling @angular/material/table : main as umd

   Compiling @angular/material/tabs : fesm2015 as esm2015

   Compiling @angular/material/tabs : esm2015 as esm2015

   Compiling @angular/material/tabs : main as umd

   Compiling @angular/material/toolbar : fesm2015 as esm2015

   Compiling @angular/material/toolbar : esm2015 as esm2015

   Compiling @angular/material/toolbar : main as umd

   Compiling @angular/cdk/tree : fesm2015 as esm2015

   Compiling @angular/cdk/tree : esm2015 as esm2015

   Compiling @angular/cdk/tree : main as umd

   Compiling @angular/material/tree : fesm2015 as esm2015

   Compiling @angular/material/tree : esm2015 as esm2015

   Compiling @angular/material/tree : main as umd

   Compiling @angular/core/testing : fesm2015 as esm2015

   Compiling @angular/core/testing : esm2015 as esm2015

   Compiling @angular/core/testing : main as umd

   Compiling @angular/platform-browser-dynamic : fesm2015 as esm2015

   Compiling @angular/platform-browser-dynamic : esm2015 as esm2015

   Compiling @angular/platform-browser-dynamic : main as umd

   Compiling @angular/platform-browser/testing : fesm2015 as esm2015

   Compiling @angular/platform-browser/testing : esm2015 as esm2015

   Compiling @angular/platform-browser/testing : main as umd

   Compiling @angular/compiler/testing : fesm2015 as esm2015

   Compiling @angular/compiler/testing : esm2015 as esm2015

   Compiling @angular/compiler/testing : main as umd

   Compiling @angular/platform-browser-dynamic/testing : fesm2015 as esm2015

   Compiling @angular/platform-browser-dynamic/testing : esm2015 as esm2015

   Compiling @angular/platform-browser-dynamic/testing : main as umd

   Compiling @angular/common/testing : fesm2015 as esm2015

   Compiling @angular/common/testing : esm2015 as esm2015

   Compiling @angular/common/testing : main as umd

   Compiling @angular/router : fesm2015 as esm2015

   Compiling @angular/router : esm2015 as esm2015

   Compiling @angular/router : main as umd

   Compiling @angular/router/testing : fesm2015 as esm2015

   Compiling @angular/router/testing : esm2015 as esm2015

   Compiling @angular/router/testing : main as umd

   Compiling @angular/material/progress-bar : fesm2015 as esm2015

   Compiling @angular/material/progress-bar : esm2015 as esm2015

   Compiling @angular/material/progress-bar : main as umd

   Compiling @angular/material/card : fesm2015 as esm2015

   Compiling @angular/material/card : esm2015 as esm2015

   Compiling @angular/material/card : main as umd

   Compiling @angular-material-extensions/password-strength : fesm2015 as esm2015

   Compiling @angular-material-extensions/password-strength : fesm5 as esm5

   Compiling @angular-material-extensions/password-strength : esm2015 as esm2015

   Compiling @angular-material-extensions/password-strength : esm5 as esm5

   Compiling @angular-material-extensions/password-strength : main as umd

   Compiling @nguniversal/common : fesm2015 as esm2015

   Compiling @nguniversal/common : esm2015 as esm2015

   Compiling @nguniversal/common : main as umd

   Compiling @nguniversal/common/tokens : fesm2015 as esm2015

   Compiling @nguniversal/common/tokens : esm2015 as esm2015

   Compiling @nguniversal/common/tokens : main as umd

   Compiling @nguniversal/express-engine/tokens : fesm2015 as esm2015

   Compiling @nguniversal/express-engine/tokens : esm2015 as esm2015

   Compiling @nguniversal/express-engine/tokens : main as umd

   Compiling @ngx-translate/core : fesm2015 as esm2015

   Compiling @ngx-translate/core : esm2015 as esm2015

   Compiling @ngx-translate/core : main as umd

   Compiling @ngx-translate/http-loader : fesm2015 as esm2015

   Compiling @ngx-translate/http-loader : esm2015 as esm2015

   Compiling @ngx-translate/http-loader : main as umd

   Compiling anuglar2-qrcode : main as umd

   Compiling anuglar2-qrcode : module as esm5

   Compiling @angular/material/autocomplete : fesm2015 as esm2015

   Compiling @angular/material/autocomplete : esm2015 as esm2015

   Compiling @angular/material/autocomplete : main as umd

   Compiling ng-mat-search-bar : fesm2015 as esm2015

   Compiling ng-mat-search-bar : esm2015 as esm2015

   Compiling ng-mat-search-bar : main as umd

   Compiling ng-simple-slideshow : es2015 as esm2015

   Compiling ng-simple-slideshow : main as umd

   Compiling ng-simple-slideshow : module as esm5

   Compiling ng2-file-upload : fesm2015 as esm2015

   Compiling ng2-file-upload : fesm5 as esm5

   Compiling ng2-file-upload : esm2015 as esm2015

   Compiling ng2-file-upload : esm5 as esm5

   Compiling ng2-file-upload : main as umd

   Compiling ngx-window-token : fesm2015 as esm2015

   Compiling ngx-window-token : esm2015 as esm2015

   Compiling ngx-window-token : main as umd

   Compiling ngx-clipboard : fesm2015 as esm2015

   Compiling ngx-clipboard : esm2015 as esm2015

   Compiling ngx-clipboard : main as umd

   Compiling ngx-cookie-service : fesm2015 as esm2015

   Compiling ngx-cookie-service : esm2015 as esm2015

   Compiling ngx-cookie-service : main as umd

   Compiling ngx-spinner : fesm2015 as esm2015

   Compiling ngx-spinner : esm2015 as esm2015

   Compiling ngx-spinner : main as umd

   added 1372 packages from 600 contributors and audited 1718 packages in 176.987s

   94 packages are looking for funding

     run `npm fund` for details

   found 0 vulnerabilities

   ><EMAIL_ADDRESS>build /tmp/build_ac2d316d

   > cd frontend && node ./node_modules/@angular/cli/bin/ng build --aot --prod --output-hashing=none --vendor-chunk=true --source-map=false

   Warning: Using differential loading with targets ES5 and ES2016 or higher may

   cause problems. Browsers with support for ES2015 will load the ES2016+ scripts

   referenced with script[type="module"] but they may not support ES2016+ syntax.

   - Generating browser application bundles...

   ✔ Browser application bundle generation complete.

   - Generating ES5 bundles for differential loading...

   ✔ ES5 bundle generation complete.

   - Copying assets...

   ✔ Copying assets complete.

   - Generating index html...

   ✔ Index html generation complete.

   Initial Chunk Files | Names                |      Size

   vendor-es5.js       | vendor               |   1.49 MB

   vendor-es2018.js    | vendor               |   1.35 MB

   styles.css          | styles               | 578.83 kB

   main-es5.js         | main                 | 388.01 kB

   main-es2018.js      | main                 | 366.46 kB

   polyfills-es5.js    | polyfills-es5        | 149.41 kB

   polyfills-es2018.js | polyfills            |  56.83 kB

   runtime-es2018.js   | runtime              |   2.21 kB

   runtime-es5.js      | runtime              |   2.21 kB

   | Initial ES5 Total    |   2.59 MB

   | Initial ES2018 Total |   2.33 MB

   Lazy Chunk Files    | Names                |      Size

   tutorial-es5.js     | tutorial             |  29.39 kB

   tutorial-es2018.js  | tutorial             |  24.17 kB

   Build at: 2021-03-27T18:28:41.727Z - Hash: c478cc159ff39e3188a1 - Time: 217054ms

   Warning: Zone.js does not support native async/await in ES2017+.

   These blocks are not intercepted by zone.js and will not triggering change detection.

   See: https://github.com/angular/zone.js/pull/1140 for more information.

   added 1816 packages from 1337 contributors and audited 1825 packages in 499.441s

   92 packages are looking for funding

     run `npm fund` for details

   found 17 vulnerabilities (3 low, 7 moderate, 4 high, 3 critical)

     run `npm audit fix` to fix them, or `npm audit` for details

-----> Build
   Running build

   ><EMAIL_ADDRESS>build /tmp/build_ac2d316d

   > cd frontend && node ./node_modules/@angular/cli/bin/ng build --aot --prod --output-hashing=none --vendor-chunk=true --source-map=false

Warning: Using differential loading with targets ES5 and ES2016 or higher may
cause problems. Browsers with support for ES2015 will load the ES2016+ scripts
referenced with script[type="module"] but they may not support ES2016+ syntax.

Generating browser application bundles...

✔ Browser application bundle generation complete.

Generating ES5 bundles for differential loading...

✔ ES5 bundle generation complete.

Copying assets...

✔ Copying assets complete.

Generating index html...

✔ Index html generation complete.
   Initial Chunk Files | Names                |      Size

   vendor-es5.js       | vendor               |   1.49 MB

   vendor-es2018.js    | vendor               |   1.35 MB

   styles.css          | styles               | 578.83 kB

   main-es5.js         | main                 | 388.01 kB

   main-es2018.js      | main                 | 366.46 kB

   polyfills-es5.js    | polyfills-es5        | 149.41 kB

Warning: Zone.js does not support native async/await in ES2017+.
These blocks are not intercepted by zone.js and will not triggering change detection.
See: https://github.com/angular/zone.js/pull/1140 for more information.
   polyfills-es2018.js | polyfills            |  56.83 kB

   runtime-es2018.js   | runtime              |   2.21 kB

   runtime-es5.js      | runtime              |   2.21 kB

   | Initial ES5 Total    |   2.59 MB

   | Initial ES2018 Total |   2.33 MB

   Lazy Chunk Files    | Names                |      Size

   tutorial-es5.js     | tutorial             |  29.39 kB

   tutorial-es2018.js  | tutorial             |  24.17 kB

   Build at: 2021-03-27T18:30:25.049Z - Hash: c478cc159ff39e3188a1 - Time: 91284ms

-----> Caching build
   - node_modules

-----> Pruning devDependencies
   removed 845 packages and audited 977 packages in 15.346s

   33 packages are looking for funding

     run `npm fund` for details

   found 17 vulnerabilities (3 low, 7 moderate, 4 high, 3 critical)

     run `npm audit fix` to fix them, or `npm audit` for details

-----> Build succeeded!
-----> Discovering process types
   Procfile declares types     -> (none)

   Default types for buildpack -> web

-----> Compressing...
   Done: 258.8M

-----> Launching...
   Released v3

   https://***************.herokuapp.com/ deployed to Heroku

Looks entirely fine and it confirms successful deployment at the end, so I doubt any downtime of that instance has something to do with Juice Shop itself. Maybe you just had bad luck on Heroku side.
Both our own demo and staging instances work fine, so master and develop branch deployments should be all good.

Is there a .html file or something I can try this on instead of hosting it?
Or should I just try docker?
On Tue, 30 Mar 2021 at 11:28 PM, Björn Kimminich @.***>
wrote:

Looks entirely fine and it confirms successful deployment at the end, so I
doubt any downtime of that instance has something to do with Juice Shop
itself. Maybe you just had bad luck on Heroku side.
Both our own demo and staging instances work fine, so master and develop
branch deployments should be all good.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bkimminich/juice-shop/issues/1611#issuecomment-810181330,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APLVDQSV4BK37ATHGDKGNBLTGG7YHANCNFSM4Z5GUDXQ
.

I git cloned, npm install then I ran npm start and this is what I got.
On Wed, 31 Mar 2021 at 12:45 AM, LinuxKid @.***> wrote:

The main reason that made me try deploy it on heroku is because it got
errors when I installed it on the latest kali Linux version.
On Wed, 31 Mar 2021 at 12:41 AM, Björn Kimminich @.***>
wrote:

You can use any deployment option described in our README, from local
Node.js to Docker everything's documented. Docker is probably easiest if
you ask me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bkimminich/juice-shop/issues/1611#issuecomment-810256812,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APLVDQQELSE73LPNP7MMGSTTGHIIJANCNFSM4Z5GUDXQ
.

I don't see what you got, but "Kali" was a trigger word that I saw before in support requests... 😉
Kali is known to have issues that you typically don't have in "regular" Linux distros. If you want to stick with Kali, Docker is probably your best option.


Gradle build failure "Could not determine java version from 9.0.1"

When using JDK 9.0.1 the gradle build fails with the following error:
$ /gradlew clean test shadowJar
FAILURE: Build failed with an exception

* What went wrong:
Could not determine java version from '9.0.1'

Reported by https://disqus.com/home/discussion/pluralsight-1/docker_in_production_using_amazon_web_services/#comment-3650663139

This is a known issue with Gradle 4.2 and below - see https://discuss.gradle.org/t/could-not-determine-java-version-from-9-0-1/24457

Fixed in https://github.com/docker-production-aws/microtrader/commit/c1a9abced4009afeedbc94b34fd9f0595348ebb6


instrumentation/daq: wrong energy cauculation

In instrumentation/daq/init.py, line 269:
                energy = sum(data[metrics.index('power')]) * (self.sampling_rate / 1000000)
Shouldn't the energy be "divided" by the sampling rate (equivalently timed the sampling period)? We ran a 5-minute workload and got following calculation. Apparently the energy field had some problem.

$ cat wa_hidroid/results.csv
id,workload,iteration,metric,value,units
glx,gbench,1,Frames_0,1026,frames
glx,gbench,1,FPS_0,34,Fps
glx,gbench,1,PMIC_power,1.334,Watts
glx,gbench,1,PMIC_voltage,4.184,Volts
glx,gbench,1,PMIC_energy,40474.55,Joules

Yes, you are correct, it should be a division. I have no idea what I was thinking when I wrote that. Thank you for catching it!
This is fixed by https://github.com/ARM-software/workload-automation/commit/cb48ece77ffb3c1769d107fc3d81ecb5dc557c85


another dummy commit

The first one disappeared faster than I needed it to.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


router default_controller not fallback to parent controller

in userguide say:
(in: Step 9: Update your config/routes.php file)
"Now, assuming that your website is located at example.com, you already know that if a user visits http://example.com/, the above setting will cause your ‘Main’ controller to be loaded.
However, what happens if you have an application/controllers/admin/ directory and the user visits http://example.com/admin/? In CodeIgniter 3, the router will look for a ‘Main’ controller under the admin/ directory as well. If not found, it will fallback to the parent (application/controllers/) directory, like in version 2.x."
it's not fallback, it's will produce 404 The page you requested was not found.
how to reproduce:
1- make a empty folder (e.g: admin)
2- put in routes: $route['default_controller'] = 'welcome/teste';
3- try access you-domain/index.php/admin
it's produces error 404 and not fallback to parent controller (application/controllers/)
ps. consider to use that as directory/controlle again it's really, really useful i use since 1.5.2

note: not clear from the original report, this is part of http://www.codeigniter.com/user_guide/installation/upgrade_300.html?highlight=step
I looked at the core/Router code, and did not see anything that would suggest the behaviour described in the upgrading instructions. Not sure if this a documentation problem or a bug in the Router class.
It sounds like this could be an opportunity for a unit test to prove/disprove the expected behaviour!

it's probably a bug in userguide...i look in core/Router too e not see anything, only a deprecated fetch_directory
but this requires that the controller is always stay in application/controller , and this is strange,
bug in other side the behaviour described in upgrading instructions is much more strange :p
it's only a suggestion, I believe that this can be a optional where i put my defaut_controller

The description was incorrect, indeed ... it's not even logical to fallback to /Main.php if the request was for /admin/.


Capability of pushing down the query and only return the final result set from data source by session

Currently many Presto (JDBC based) connectors such as mysql, postgres, Oracle are single threaded. When doing aggregation calculation, Presto will do a full table scan, then do the aggregation on all records returned from the data source, which is very slow in some case. For example, for TPCH 100G orders 150M records table stored in Postgresql, if we do the following count aggregation query on presto, it took 8 minutes 30 seconds to return the result.
presto> select o_custkey, count() from pgtpch100g.public.orders where to_char(o_orderdate, 'mm/yyyy') = '03/1997' group by o_custkey having count() > 4;
o_custkey | _col1
-----------+-------
10843207 | 5
13299838 | 5
1809103 | 5
12675628 | 5
12038404 | 5
(5 rows)
Query 20200322_190724_00019_njknr, FINISHED, 5 nodes
Splits: 177 total, 177 done (100.00%)
8:30 [150M rows, 0B] [294K rows/s, 0B/s]
While in postgresql itself, it only took 5 seconds for the results to return.
tpch100g=# EXPLAIN ANALYSE select o_custkey, count() from orders where to_char(o_orderdate, 'mm/yyyy') = '03/1997' group by o_custkey having count() > 4;
QUERY PLAN
Custom Scan (Citus Adaptive) (cost=0.00..0.00 rows=0 width=0) (actual time=5134.805..5134.806 rows=5 loops=1)
Task Count: 32
Tasks Shown: One of 32
-> Task
Node: host=myhost port=5432 dbname=tpch100g
-> Finalize GroupAggregate (cost=122383.11..125236.20 rows=7492 width=16) (actual time=1396.918..1396.918 rows=0 loops=1)
Group Key: o_custkey
Filter: (count(*) > 4)
Rows Removed by Filter: 55564
-> Gather Merge (cost=122383.11..124808.74 rows=19534 width=16) (actual time=1356.274..1378.625 rows=58563 loops=1)
Workers Planned: 2
Workers Launched: 2
-> Partial GroupAggregate (cost=121383.09..121554.01 rows=9767 width=16) (actual time=1354.141..1363.419 rows=19521 loops=3)
Group Key: o_custkey
-> Sort (cost=121383.09..121407.51 rows=9767 width=8) (actual time=1354.135..1356.468 rows=20041 loops=3)
Sort Key: o_custkey
Sort Method: quicksort Memory: 1721kB
Worker 0: Sort Method: quicksort Memory: 1699kB
Worker 1: Sort Method: quicksort Memory: 1704kB
-> Parallel Seq Scan on orders_102808 orders (cost=0.00..120735.84 rows=9767 width=8) (actual time=0.305..1346.003 rows=20041 loops=3)
Filter: (to_char((o_orderdate)::timestamp with time zone, 'mm/yyyy'::text) = '03/1997'::text)
Rows Removed by Filter: 1542604
Planning Time: 0.086 ms
Execution Time: 1397.120 ms
Planning Time: 1.381 ms
Execution Time: 5134.832 ms
(26 rows)
In the above example, it's 8.5 minutes in Presto vs 5 seconds in Postgresql Citus cluster. It's a big difference.
It will be nice to have a switch that can be turned on/off in each session, that we could decide if we want to have Presto to return the full table do the aggregation, or we could push down to the data source to do the aggregation, and only returns the final results.

@RugratsJ thanks for the issue.
It's already tracked by https://github.com/prestosql/presto/issues/18, so let me close this one.
I see you have a lot of interesting experiences to share.
Please join the #dev channel on our slack https://prestosql.io/slack.html.


Link causes unshortenit to hang, timeout doesn't fire

The link "http://fb.me/36vAPSlVl" causes unshortenit to churn CPU cycles and get nowhere. Stalls indefinitely, even with timeout flagged. Haven't debugged in-depth.

Here's my stack trace from the python3.5 interpreter:
url, code = unshortenit.unshorten('http://fb.me/36vAPSlVl')
^C
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/IPython/core/interactiveshell.py", line 2862, in run_code
exec(code_obj, self.user_global_ns, self.user_ns)
File "", line 1, in
url, code = unshortenit.unshorten('http://fb.me/36vAPSlVl')
File "/usr/local/lib/python3.5/dist-packages/unshortenit/base.py", line 410, in unshorten
uri, status = unshortener.unwrap_30x(uri, timeout=timeout)
File "/usr/local/lib/python3.5/dist-packages/unshortenit/base.py", line 101, in unwrap_30x
r = requests.head(uri, headers=HTTP_HEADER, timeout=self._timeout)
File "/usr/lib/python3/dist-packages/requests/api.py", line 93, in head
return request('head', url, **kwargs)
File "/usr/lib/python3/dist-packages/requests/api.py", line 53, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/lib/python3/dist-packages/requests/sessions.py", line 468, in request
resp = self.send(prep, **send_kwargs)
File "/usr/lib/python3/dist-packages/requests/sessions.py", line 576, in send
r = adapter.send(request, **kwargs)
File "/usr/lib/python3/dist-packages/requests/adapters.py", line 376, in send
timeout=timeout
File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 560, in urlopen
body=body, headers=headers)
File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 354, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/usr/lib/python3.5/http/client.py", line 1106, in request
self._send_request(method, url, body, headers)
File "/usr/lib/python3.5/http/client.py", line 1151, in _send_request
self.endheaders(body)
File "/usr/lib/python3.5/http/client.py", line 1102, in endheaders
self._send_output(message_body)
File "/usr/lib/python3.5/http/client.py", line 934, in _send_output
self.send(msg)
File "/usr/lib/python3.5/http/client.py", line 877, in send
self.connect()
File "/usr/lib/python3/dist-packages/urllib3/connection.py", line 162, in connect
conn = self._new_conn()
File "/usr/lib/python3/dist-packages/urllib3/connection.py", line 137, in _new_conn
(self.host, self.port), self.timeout, **extra_kw)
File "/usr/lib/python3/dist-packages/urllib3/util/connection.py", line 81, in create_connection
sock.connect(sa)

I believe this was because FB uses meta refresh links. Your sample link is now supported and working fine for me in the 0.4.0 release.


Thought on tombstones

Just writing up some of our thoughts from yesterday, and an idea on implementation (which is one extra construct).

this looks pretty excellent :moneybag:

:money_with_wings:

:+1:


[bug]: vae selection doesn't seen to be working, still using the models vae

Is there an existing issue for this?

[X] I have searched the existing issues

OS
macOS
GPU
mps
VRAM
No response
What version did you experience this issue on?
3.0.2post1
What happened?
I've been trying to use the fp16 bit vae  by madebyollin but was still getting black images if the vae was run with the
precision set to fp16.

I checked the logs and found the following that suggested it was still using the models default vae
[2023-08-14 14:19:20,659]::[InvokeAI]::DEBUG --> Unloading model /Volumes/Sabrent Media/Documents/Source/Python/ai_models/invokeai/models/sdxl/main/sdxl_base_fp16:sdxl:main:unet to free 0.16 GB (-4.78 GB)
[2023-08-14 14:19:20,943]::[InvokeAI]::DEBUG --> Moving /Volumes/Sabrent Media/Documents/Source/Python/ai_models/invokeai/models/sdxl/main/sdxl_
base_fp16:sdxl:main:vae into mps

I then renamed be vae directory in the model and softlinked the fp16 fixed vae directory there instead and the images were no longer black but fully formed.
Poking around I saw this which looks like it might be related the parameters passed to render, with vae set to null
            "latents_to_image": {
                "id": "latents_to_image",
                "is_intermediate": false,
                "type": "l2i",
                "latents": null,
                "vae": null,
                "tiled": false,
                "fp32": false,
                "metadata": null
            },

Screenshots
https://user-images.githubusercontent.com/62868/260816997-cc15446c-141e-4561-8986-c64e8b98238b.png
Additional context
No response
Contact Details
No response

This appears to be fixed in the main branch, closing

I'm still encountering this issue in main. What did you do to manually fix it exactly? That was unclear. Could you please provide more details?

I found the vae in the invoke models cache
invokeai/models/sdxl/vae/sdxl-1-0-vae-fix

I then found the SDXL model in the cache too
invokeai/models/sdxl/main/sdxl_base_fp16

Note I have installed copy of the 16bit base model,
as when I originally installed SDXL it downloaded the full 32bit version and would sometimes take 4 or 5 minutes to load and convert to 16bit MPS. Thats been fixed in  3.0.2.
You probably need this directory instead
stable-diffusion-xl-base-1-0

in there is a vae directory
invokeai/models/sdxl/main/sdxl_base_fp16/vae

I renamed that vae directory
and softlinked the fixed vae directory (or you could copy it there instead)
mv vae vae_default
ln -s ../../vae/sdxl-1-0-vae-fix vae

So now when it uses the models default vae its actually using the fixed vae instead.


Need help with CSS

Hacktober fest people, please help with CSS

@arridecabs what changes do you want


Bump Treelite to 4.4.0

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Need to make hot fix to remove the scikit-learn dependency: https://github.com/dmlc/treelite/pull/596


Support large number of vehicles in multivehicle SITL

Describe problem solved by this pull request
Previously, the number of vehicles that were able to be simulated was limited to 10 vehicles. This was due to a overlap on port numbering that overlapped in the rcS definition.
Describe your solution
Redefine gcs udp port from 14570 to 18570 in rcS.
Test data / coverage
Tested up to 100 instances of vehicles on a desktop.
Image below shows 30 vehicles

There was a shellcheck failure in CI. http://ci.px4.io:8080/blue/organizations/jenkins/PX4%2FFirmware/detail/PR-14126/4/pipeline


[examples] Fix CRA start script

Fixes #17545

[x] I have followed (at least) the PR section of the contributing guide.

Much appreciated, thanks!


[Feature Request] Image Scale by Factor

First of all, thank you for providing these incredibly useful nodes.
I am a big fan of the Latent Upscale by Factor node as it saves some annoying fiddling after you adjust the starting resolution in an Latent Upscale workflow.
Sometimes, I throw the resulting image into an regular Upscaler (like 4x-UltraSharp). The resolution that results in is often way too big, so I downscale using the default ImageScale Node. However, I have to adjust the resolution manually here whenever I change the starting resolution of my workflow.
Having an Factor version (one that could also downscale) of the ImageScale Node would be really useful.

You can just use something like 0.5 on your input for 4x, which would give you 2x. ;)

Oh, I didn't even think about using the Latent factor upscale AFTER the second sampler node. I guess I was focused on modifying an already decoded image because I was saving the pre-upscale versions.
Now I feel a bit silly, thanks for the help.
(This is what you meant, right?)

Yeah just like that, though I assume you know the latent upscale doesn't generate a image :P

Yeah just like that, though I assume you know the latent upscale doesn't generate a image :P
yeah that was just an example i quickly made because my real work flow is a bit of a mess lol

Oh, wait no, you'd want to scale down after upscale. Though though that may work as well, but may result in quality loss cause up-scaling from a smaller image.
that would mean i would have to do something like this to be able to only use a factors instead of hard values:

i was worried that encoding and decoding like this might have some adverse affects (which is why i asked for an image scale by factor in the first place), but i have no idea if that's actually the case.

It could very well, though I haven't noticed myself. Perhaps it's time for a regular image scale by factor/resize

I did just find another reason an regular image scale might be a good inclusion, VRAM usage.

using the tiled vae nodes i was able to actually go through the process, but the image ended up being pretty messed up. (the image was fine after scaling with ultrasharp, so it must have either been the (tiled) encoding/decoding or the downscale)
4x ultrasharp here, was too big for github

I have a image resize ready, and a transpose, going to add padding and couple other. Probably release tomorrow morning at some point. It's 1:20 here and almost too tired to shower haha

that's awesome. thanks for all the help.

that's awesome. thanks for all the help.

Image resize should be in. Little busy today, hopefully it's all good.


Added activateEnviroment.sh to readme

Clarification of the activateEnviroment.sh script in the examples working on a cluster with Slurm&Enviroment Modules
What does this PR do?
Clarification of the activateEnviroment.sh script in the examples working on a cluster with Slurm&Enviroment Modules

Fixes #2370
Before submitting

[X] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
cc @muellerzr

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Input data without cell annotation

Dear authors,
Thanks for the great work! The scIB tool has been a great resource for our team.
We're trying to evaluate batch removal effects on several integrated datasets. So far scib-pipeline/scripts/metrics/metrics.py worked well. However, in metrics.py --label_key is required. I'm wondering if it's reasonable to input data without annotated cell label for metrics calculation? (We would like to evaluate batch effect correction before we move into manual annotation.)
I've considered the followings:

Does it make sense if we use cluster labels as label_key?
Using metrics that does not require label_key only (e.g. from scIB.metrics import kbet) and do the calculation separately.

I'm new to this area and it would be great if you could give me some advice.
Thanks for your time!

Hi @XuezhenChen,
Thanks for the kind words. There are a few metrics you can use without labels. The kBET metric we adapted to use labels though so that we can correct for cell type composition differences. PCR_batch and graph iLISI are the batch removal metrics that don't require labels to run. On the bio conservation side, trajectory conservation, cell cycle conservation and HVG conservation don't require cell type labels.
Regarding replacing label_key with a clustering output... this is possible... but I would definitely verify the clusters. In the end the level of cluster annotation is what you will evaluate recovery of. If you base your clustering on one integrated embedding/graph, then you will bias all your evaluations towards that embedding. Better might be to cluster per batch and then map clusters to one another by correlation or marker genes.
Good luck!

Hello @LuckyMD,
Thanks for the clarification on kBET. We'll proceed with the metrics that don't require cell labels to run as you mentioned.
Thanks again for your help!


refactor(plugins/ai-proxy): simplify code with early return

Summary

code style clean
reduce if ... indents by using early return
reuse table ERROR_MSG

KAG-4150

Checklist

[ ] The Pull Request has tests
[x] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

This may might maybe conflict with https://github.com/Kong/kong/pull/12792 where I've added streaming support.
I can pick these commits and test later today.

This may might maybe conflict with #12792 where I've added streaming support.
I can pick these commits and test later today.

If you cherry-pick this PR successfully we can close it safely.

@ttyS0e Thanks, please let us know once you finish the cherry-pick. I'll convert this PR as a draft.

It seems to work fine on both yes!
stream-non-stream-test.log

@ttyS0e Thanks for your tests, I will merge this PR, which might introduce conflicts to #12792, please let us know if you have issues when resolving conflicts.


ISO sections, keeptitle attribute: https://github.com/metanorma/metan…

…orma-iso/issues/1124
Metanorma PR checklist

[ ] Breaking changes (list related PRs)
[ ] Documentation update required (create task for this)
[ ] External dependency introduced (documentation update need)
[ ] Gem with native library introduced

Pending @Intelligent2013 clarification on what narrow and text-width attributes differ.

These figure's width values were introduced specially for BSI documents: https://github.com/metanorma/metanorma-bsi/issues/276, because the BSI Style guide for British Standards determine them:

But there isn't any 'narrow' figure example.
As I noted a year ago https://github.com/metanorma/mn-samples-bsi/issues/171#issuecomment-1435700053

For narrow option we don't have the sample.

Therefore, currently in the XSLT for PDF there isn't any processing for the width="narrow", because we don't know how to scale the figure with narrow value.
I.e. currently, metanorma allows the value narrow, but PDF XSLT doesn't use it.

https://www.overleaf.com/learn/latex/Lengths_in_LaTeX, https://en.wikibooks.org/wiki/LaTeX/Lengths does not answer the question of what "narrow" means, but it does give us a set of possible values for widths that reference text:

\columnwidth
\linewidth "Width of the line in the current environment."
\paperwidth (= full-page-width)
\textwidth "Width of the text area in the page"

My strong suspicion is that narrow is not defined, and is merely "not full textwidth or paperwidth"; but nobody wants to commit to a fixed answer in

https://tex.stackexchange.com/questions/158685/ideal-width-of-figures-compared-to-the-text-width
https://tex.stackexchange.com/questions/5351/typographic-conventions-for-width-of-figures-in-latex-data-analysis-reports

For instance.

The width of your figures will be very much dependent of the layout you use. As @Christian, I would actually try not to divert from the rule that figure width = \textwidth. With small figures, you could go for a half or a third of that width and put them in the same float. With very large figures, dedicate a page to the whole thing and set it to 100% of the height or width (whichever is bigger). If you are using a layout such as tufte-latex, get the small figures into the margins and it will look gorgeous all the same. Just be consistent with yourself.

So user ienissei defaults to textwidth, allows 1/2 or 1/3 textwidth for small images; I imagine that BSI intend narrow to include '1/2 or 1/3 textwidth", without fixing it.

These instances of images shoved into margins would also count as margins, but that's a bit old-fashioned for standards:

... If my interpretation is correct, it means that "narrow" is meaningless as an option describing figure width, it is merely a vague description, and users should actually specify something more concrete. Even if it isn't, I think we might as well drop it.
Having looked at LaTeX, I now think that we should not be reinventing its width notation. If LaTeX allows "width=.5\textwidth", why don't we just use LaTeX notation for this field?

So @ronaldtse @Intelligent2013 the actions coming out of this discussion are:

Either  confirm with BSI if "narrow" is a well-defined table and figure width, and if so, how to render it
Or, drop support for "narrow", because "narrow" is merely an open-ended, "not full width" value --- which in our documents should be replaced by either no width indication, or else an explicit width indication. (That is my preference.)

There is a further question of whether we should be supporting fractions relative to textwidth and pagewidth, as LaTeX does. The thing is, that requirement comes out of only LaTeX and/or PDF. Nobody in HTML thinks in those terms: percentages are relative to div containers or text width, the page/text distinction does not apply. Nobody in Word thinks in those terms: table widths are more simply encoded as absolute  values.
So if there is a requirement for supporting fractions relative to textwidth and pagewidth, it only applies to @Intelligent2013, and I presume it also needs to come from @Intelligent2013 and his experience generating PDFs in response to SDOs.
My suspicion is, if we haven't implemented anything like it already, we won't need to, and that 1/2 or 1/3 width images are unfashionable anyway. There is a reason why we have no idea from BSI what narrow width looks like, after all: that they're simply not using it.
Over to you guys.

Then let's drop narrow until it comes back. Thanks


[BP] Ragdolls clipping through solids

https://user-images.githubusercontent.com/3608544/179210368-abe3507c-6e99-4a40-bd22-b3fa36bb0bf4.mp4

Is it recommend though to change those CVars to higher values? As far as I've understood messing with bv_scale is not recommended. And what impact will they have on client performance?

Is it recommend though to change those CVars to higher values? As far as I've understood messing with bv_scale is not recommended. And what impact will they have on client performance?

From what I've seen in the previous test, bv_scale = 10 performs better than bv_scale = 1 as rigidbody movement in each simulation step is much more accurate.

Idk why but the CVar on my side is somehow defaulted to 0.5. I tried setting bv_simrate to 128 and haven't seen any difference. Also, how about the performance impact?

bv_scale

A map restart is required after changing bv_scale

Using bv_scale 7.5 and bv_simrate 96 or above fixes this issue as far as I've noticed. Closing until proven otherwise.


Add Nong Song:

Song Name
Pop Culture
Artist Name
Madeon
Source
Youtube
Youtube Link
https://www.youtube.com/watch?v=lTx3G6h2xyA&t=0s
Direct File Link
No response
Song ID
686789
Start Offset [ms]
0
Extra
No response

Madeon
Source
Youtube
Youtube Link
https://www.youtube.com/watch?v=lTx3G6h2xyA&t=0s
Direct File Link
No response
Song ID
686789
Start Offset [ms]
0
Extra
No response