eth_sendRawTransaction is returning hash when receiving wrong_nonce (bigger than expected) instead of error

Description
Currently if sending a transaction using a wrong nonce, there are 2 possibilities:

Nonce is too low, we are returning the appropriate message
Nonce is too big (bigger than the expected current nonce). We are returning a computed hash for the transaction, but that hash does not exist, since the SDK returned wrong_nonce

Steps to reproduce
you can use this transaction on previewnet to replicate the issue.
0xf8ed818b85f7f6f25a008301c3e89410df38c7381cf2154a0fc3fb5455ab60b0483b0b80b884a4136862000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000304772656574696e67732066726f6d204175746f6d617465642054657374204e756d626572203133392c2048656c6c6f2100000000000000000000000000000000820276a0029a12dad96a95df97926ad0e044092ed7faf02948a16022818a0814523592cea07cedecff37a0ffd57ef9653580b118d79350c240f8e3923505e395764f3d59d5

curl --location 'https://previewnet.hashio.io/api' \
--header 'Content-Type: application/json' \
--data '{
    "method": "eth_sendRawTransaction",
    "params": [
        "0xf8ed818b85f7f6f25a008301c3e89410df38c7381cf2154a0fc3fb5455ab60b0483b0b80b884a4136862000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000304772656574696e67732066726f6d204175746f6d617465642054657374204e756d626572203133392c2048656c6c6f2100000000000000000000000000000000820276a0029a12dad96a95df97926ad0e044092ed7faf02948a16022818a0814523592cea07cedecff37a0ffd57ef9653580b118d79350c240f8e3923505e395764f3d59d5"
    ],
    "id": 120,
    "jsonrpc": "2.0"
}'

Additional context
This transactions are also logging an error that the transaction record was not found (since the sdk did not processed the transaction due to wrong nonce, but still the relay is returning the computed hash

There are 2 ways to avoid this.

To verify before submitting the transaction to the SDK if the nonce is too high.
To handle the response from the SDK WRONG_NONCE and return an appropriate error message to the user.

The logic in question is happening here: https://github.com/hashgraph/hedera-json-rpc-relay/blob/main/packages/relay/src/lib/eth.ts#L1102C5-L1127
Hedera network
mainnet, testnet, previewnet
Version
v0.25.0
Operating system
None

Might be worked together with this other ticket:
https://github.com/hashgraph/hedera-json-rpc-relay/issues/1333

Easier way to reproduce this is by sending a transaction via metamask (for example simple contract call or transfer) and entering custom higher nonce.


Please also add your adapter to the stable repository once ready

Your adapter is already in ioBroker latest repository available to be used by testwilling users. In order to make your adapter also available for the wide user base which uses the stable repository you should also add your adapter to the stable repository. Please see instructions at https://github.com/ioBroker/ioBroker.repositories#requirements-for-adapter-to-get-added-to-the-stable-repository
Thank you for your support.

version 0.2.1 published to stable https://github.com/ioBroker/ioBroker.repositories/pull/1837


cluster logging is not working properly from remote hosts

I've setup elastic search in accordance to documentation present, I have a service:
kubectl get services elasticsearch-logging
NAME                    LABELS                                                                                SELECTOR                        IP(S)          PORT(S)
elasticsearch-logging   k8s-app=elasticsearch-logging,kubernetes.io/cluster-service=true,kubernetes.io/name=Elasticsearch   k8s-app=elasticsearch-logging   <IP_ADDRESS>   9200/TCP

it's working from machine where elasticsearch pods are running on, but not working on the neighboring hosts.
from the same host:
samehost$ curl -XGET http://<IP_ADDRESS>:9200
{
  "status" : 200,
  "name" : "Green Goblin",
  "cluster_name" : "kubernetes-logging",
  "version" : {
    "number" : "1.5.2",
    "build_hash" : "62ff9868b4c8a0c45860bebb259e21980778ab1c",
    "build_timestamp" : "2015-04-27T09:21:06Z",
    "build_snapshot" : false,
    "lucene_version" : "4.10.4"
  },
  "tagline" : "You Know, for Search"
}
samehost$ curl -XGET http://<IP_ADDRESS>:9200/_cluster/health?pretty=true
{
  "cluster_name" : "kubernetes-logging",
  "status" : "yellow",
  "timed_out" : false,
  "number_of_nodes" : 1,
  "number_of_data_nodes" : 1,
  "active_primary_shards" : 6,
  "active_shards" : 6,
  "relocating_shards" : 0,
  "initializing_shards" : 0,
  "unassigned_shards" : 6,
  "number_of_pending_tasks" : 0
}
samehost$ curl -XGET http://<IP_ADDRESS>:9200/_status
{"_shards":{"total":12,"successful":6,"failed":0},"indices":{"logstash-2015.07.19":{"index":{"primary_size_in_bytes":65261701,"size_in_bytes":65261701},"translog":{"operations":5471},"docs":{"num_docs":185574,"max_doc":185574,"deleted_docs":0},"merges":{"current":0,"current_docs":0,"current_size_in_bytes":0,"total":278,"total_time_in_millis":121927,"total_docs":9699589,"total_size_in_bytes":1759226594},"refresh":{"total":2896,"total_time_in_millis":56683},"flush":{"total":15,"total_time_in_millis":16496},"shards":{"0":[{"routing":{"state":"STARTED","primary":true,"node":"IVIUbR5bQBaJb8mVuJBLOA","relocating_node":null,"shard":0,"index":"logstash-2015.07.19"},"state":"STARTED","index":{"size_in_bytes":13016050},"translog":{"id":1437326403104,"operations":1091},"docs":{"num_docs":37075,"max_doc":37075,"deleted_docs":0},"merges":{"current":0,"current_docs":0,"current_size_in_bytes":0,"total":55,"total_time_in_millis":23986,"total_docs":1915510,"total_size_in_bytes":346718652},"refresh":{"total":576,"total_time_in_millis":10485},"flush":{"total":3,"total_time_in_millis":2106}}],"1":[{"routing":{"state":"STARTED","primary":true,"node":"IVIUbR5bQBaJb8mVuJBLOA","relocating_node":null,"shard":1,"index":"logstash-2015.07.19"},"state":"STARTED","index":{"size_in_bytes":13129037},"translog":{"id":1437326403108,"operations":1100},"docs":{"num_docs":37112,"max_doc":37112,"deleted_docs":0},"merges":{"current":0,"current_docs":0,"current_size_in_bytes":0,"total":56,"total_time_in_millis":26006,"total_docs":1954700,"total_size_in_bytes":357492167},"refresh":{"total":578,"total_time_in_millis":11362},"flush":{"total":3,"total_time_in_millis":1006}}],"2":[{"routing":{"state":"STARTED","primary":true,"node":"IVIUbR5bQBaJb8mVuJBLOA","relocating_node":null,"shard":2,"index":"logstash-2015.07.19"},"state":"STARTED","index":{"size_in_bytes":12947888},"translog":{"id":1437326403144,"operations":1074},"docs":{"num_docs":37072,"max_doc":37072,"deleted_docs":0},"merges":{"current":0,"current_docs":0,"current_size_in_bytes":0,"total":55,"total_time_in_millis":22759,"total_docs":1919315,"total_size_in_bytes":345935684},"refresh":{"total":573,"total_time_in_millis":11616},"flush":{"total":3,"total_time_in_millis":1624}}],"3":[{"routing":{"state":"STARTED","primary":true,"node":"IVIUbR5bQBaJb8mVuJBLOA","relocating_node":null,"shard":3,"index":"logstash-2015.07.19"},"state":"STARTED","index":{"size_in_bytes":13121871},"translog":{"id":1437326403104,"operations":1129},"docs":{"num_docs":37215,"max_doc":37215,"deleted_docs":0},"merges":{"current":0,"current_docs":0,"current_size_in_bytes":0,"total":56,"total_time_in_millis":24269,"total_docs":1956205,"total_size_in_bytes":355167278},"refresh":{"total":584,"total_time_in_millis":12194},"flush":{"total":3,"total_time_in_millis":5785}}],"4":[{"routing":{"state":"STARTED","primary":true,"node":"IVIUbR5bQBaJb8mVuJBLOA","relocating_node":null,"shard":4,"index":"logstash-2015.07.19"},"state":"STARTED","index":{"size_in_bytes":13046855},"translog":{"id":1437326403183,"operations":1077},"docs":{"num_docs":37100,"max_doc":37100,"deleted_docs":0},"merges":{"current":0,"current_docs":0,"current_size_in_bytes":0,"total":56,"total_time_in_millis":24907,"total_docs":1953859,"total_size_in_bytes":353912813},"refresh":{"total":585,"total_time_in_millis":11026},"flush":{"total":3,"total_time_in_millis":5975}}]}},".kibana":{"index":{"primary_size_in_bytes":115,"size_in_bytes":115},"translog":{"operations":0},"docs":{"num_docs":0,"max_doc":0,"deleted_docs":0},"merges":{"current":0,"current_docs":0,"current_size_in_bytes":0,"total":0,"total_time_in_millis":0,"total_docs":0,"total_size_in_bytes":0},"refresh":{"total":1,"total_time_in_millis":0},"flush":{"total":1,"total_time_in_millis":0},"shards":{"0":[{"routing":{"state":"STARTED","primary":true,"node":"IVIUbR5bQBaJb8mVuJBLOA","relocating_node":null,"shard":0,"index":".kibana"},"state":"STARTED","index":{"size_in_bytes":115},"translog":{"id":1437327062564,"operations":0},"docs":{"num_docs":0,"max_doc":0,"deleted_docs":0},"merges":{"current":0,"current_docs":0,"current_size_in_bytes":0,"total":0,"total_time_in_millis":0,"total_docs":0,"total_size_in_bytes":0},"refresh":{"total":1,"total_time_in_millis":0},"flush":{"total":1,"total_time_in_millis":0}}]}}}}

seems to be working right? but when I do the same on neighboring host I get different result
otherhost$ curl -XGET http://<IP_ADDRESS>:9200
{
  "status" : 200,
  "name" : "Green Goblin",
  "cluster_name" : "kubernetes-logging",
  "version" : {
    "number" : "1.5.2",
    "build_hash" : "62ff9868b4c8a0c45860bebb259e21980778ab1c",
    "build_timestamp" : "2015-04-27T09:21:06Z",
    "build_snapshot" : false,
    "lucene_version" : "4.10.4"
  },
  "tagline" : "You Know, for Search"
}
otherhost$ curl -XGET http://<IP_ADDRESS>:9200/_cluster/health?pretty=true
{
  "cluster_name" : "kubernetes-logging",
  "status" : "yellow",
  "timed_out" : false,
  "number_of_nodes" : 1,
  "number_of_data_nodes" : 1,
  "active_primary_shards" : 5,
  "active_shards" : 5,
  "relocating_shards" : 0,
  "initializing_shards" : 0,
  "unassigned_shards" : 5,
  "number_of_pending_tasks" : 0
}

this part seems to be working also...  but when I do
otherhost$ curl -XGET http://<IP_ADDRESS>:9200/_status

it simply stuck and doing nothing, what am I'm doing wrong and how to get elasticsearch available from remote hosts?

The problem is with MTU, when I've decreased it to 1420 it started to work.


Allow brew shellenv to accept a shell name param

Resolves #15358
With this change, brew shellenv will accept a shell name parameter to override its default output (based on /bin/ps) for advanced use cases such as with dotfile templating and caching with
twpayne/chezmoi. When running under fish, this is the output:
$ brew shellenv pwsh
[System.Environment]::SetEnvironmentVariable('HOMEBREW_PREFIX','/opt/homebrew',[System.EnvironmentVariableTarget]::Process)
[System.Environment]::SetEnvironmentVariable('HOMEBREW_CELLAR','/opt/homebrew/Cellar',[System.EnvironmentVariableTarget]::Process)
[System.Environment]::SetEnvironmentVariable('HOMEBREW_REPOSITORY','/opt/homebrew',[System.EnvironmentVariableTarget]::Process)
[System.Environment]::SetEnvironmentVariable('PATH',$('/opt/homebrew/bin:/opt/homebrew/sbin:'+$ENV:PATH),[System.EnvironmentVariableTarget]::Process)
[System.Environment]::SetEnvironmentVariable('MANPATH',$('/opt/homebrew/share/man'+$(if(${ENV:MANPATH}){':'+${ENV:MANPATH}})+':'),[System.EnvironmentVariableTarget]::Process)
[System.Environment]::SetEnvironmentVariable('INFOPATH',$('/opt/homebrew/share/info'+$(if(${ENV:INFOPATH}){':'+${ENV:INFOPATH}})),[System.EnvironmentVariableTarget]::Process)
$ brew shellenv
set -gx HOMEBREW_PREFIX "/opt/homebrew";
set -gx HOMEBREW_CELLAR "/opt/homebrew/Cellar";
set -gx HOMEBREW_REPOSITORY "/opt/homebrew";
set -q PATH; or set PATH ''; set -gx PATH "/opt/homebrew/bin" "/opt/homebrew/sbin" $PATH;
set -q MANPATH; or set MANPATH ''; set -gx MANPATH "/opt/homebrew/share/man" $MANPATH;
set -q INFOPATH; or set INFOPATH ''; set -gx INFOPATH "/opt/homebrew/share/info" $INFOPATH;

The specific case presented in the mentioned discussion could be mitigated by an additional level of indirection ({{ output "fish" "-c" "'brew shellenv'" | trim }}), that requires that the running system have the target shells installed, when they are not strictly necessary with brew shellenv.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

I cannot find any tests that reference the output of brew shellenv to extend.

[x] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

I am getting failures that are not related to the two files that I have changed. I’ll put a couple of failure reports in the first comments.

I am getting a lot of failures that are not related to my changes, as they are occurring on master as well. For example:
Failures:

  1) CurlDownloadStrategy#fetch calls curl with default arguments
     Failure/Error: strategy.fetch

       #<CurlDownloadStrategy:0x0000000112129f18 @url="https://example.com/foo.tar.gz", @name="foo", @version="1.2.3", @cache=#<Pathname:/private/tmp/homebrew-tests-20230504-7848-1f8yjtb/cache>, @meta={:user=>"download:123456"}, @quiet=false, @try_partial=true, @mirrors=[], @resolved_info_cache={"https://example.com/foo.tar.gz"=>["https://example.com/foo.tar.gz", "foo.tar.gz", nil, nil, false]}, @curl_executable=#<Pathname:/opt/homebrew/Library/Homebrew/shims/shared/curl>, @cached_location=#<Pathname:/private/tmp/homebrew-tests-20230504-7848-1f8yjtb/cache/downloads/3d1c0ae7da22be9d83fb1eb774df96b7c4da71d3cf07e1cb28555cf9a5e5af70--foo.tar.gz>, @temporary_path=#<Pathname:/private/tmp/homebrew-tests-20230504-7848-1f8yjtb/cache/downloads/3d1c0ae7da22be9d83fb1eb774df96b7c4da71d3cf07e1cb28555cf9a5e5af70--foo.tar.gz.incomplete>> received :curl with unexpected arguments
         expected: ("--continue-at", "-", "--location", "--remote-time", "--output", an instance of Pathname, "https://example.com/foo.tar.gz", an instance of Hash)
              got: ("--location", "--remote-time", "--output", #<Pathname:/private/tmp/homebrew-tests-20230504-7848-1f8yjtb/cache/downloads/3d1c0ae7da22be9d83fb1eb774df96b7c4da71d3cf07e1cb28555cf9a5e5af70--foo.tar.gz.incomplete>, "https://example.com/foo.tar.gz", {:timeout=>nil})
       Diff:

       @@ -1,9 +1,7 @@
       -["--continue-at",
       - "-",
       - "--location",
       +["--location",
         "--remote-time",
         "--output",
       - "an instance of Pathname",
       + #<Pathname:/private/tmp/homebrew-tests-20230504-7848-1f8yjtb/cache/downloads/3d1c0ae7da22be9d83fb1eb774df96b7c4da71d3cf07e1cb28555cf9a5e5af70--foo.tar.gz.incomplete>,
         "https://example.com/foo.tar.gz",
       - "an instance of Hash"]
       + {:timeout=>nil}]

     # ./utils/curl.rb:201:in `curl_download'
     # ./download_strategy.rb:542:in `_curl_download'
     # ./download_strategy.rb:538:in `_fetch'
     # ./download_strategy.rb:426:in `fetch'
     # ./test/download_strategies/curl_spec.rb:41:in `block (3 levels) in <top (required)>'

and
  1) RuboCop::Cop::FormulaAudit::ProvidedByMacos unifdef formula exists
     Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { |failure, _opts| raise failure }

       expected true
            got false
     Shared Example Group: "formulae exist" called from ./test/rubocops/provided_by_macos_spec.rb:42
     # ./test/support/helper/spec/shared_examples/formulae_exist.rb:9:in `block (3 levels) in <top (required)>'

  2) RuboCop::Cop::FormulaAudit::ProvidedByMacos krb5 formula exists
     Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { |failure, _opts| raise failure }

       expected true
            got false
     Shared Example Group: "formulae exist" called from ./test/rubocops/provided_by_macos_spec.rb:42
     # ./test/support/helper/spec/shared_examples/formulae_exist.rb:9:in `block (3 levels) in <top (required)>'

  3) RuboCop::Cop::FormulaAudit::ProvidedByMacos libxml2 formula exists
     Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { |failure, _opts| raise failure }

       expected true
            got false
     Shared Example Group: "formulae exist" called from ./test/rubocops/provided_by_macos_spec.rb:42
     # ./test/support/helper/spec/shared_examples/formulae_exist.rb:9:in `block (3 levels) in <top (required)>'

My taps are all clean and modified:
Taps/commitdev/homebrew-zero
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
Taps/homebrew/homebrew-autoupdate
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
Taps/homebrew/homebrew-bundle
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
Taps/homebrew/homebrew-cask-fonts
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
Taps/homebrew/homebrew-cask-versions
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
Taps/homebrew/homebrew-services
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
Taps/puma/homebrew-puma
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
Taps/schappim/homebrew-ocr
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
Taps/superfly/homebrew-tap
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
Taps/tilt-dev/homebrew-tap
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
Taps/turbot/homebrew-tap
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean

During test execution, I am getting one pop up (that is disappearing before I can read or respond) that appears to be the system request to allow network connections.


fix: app crash on sending PM notification bouncer.

Summary of changes
url does not contain realm url (and protocol) so it was crashing. In this PR :- join ServerHostUri and url to get full url of sender avatar.
Screenshots or a brief video showing the change in action:
https://chat.zulip.org/user_uploads/2/ea/YX_itZYiV0OCGazCMqbM3xVo/Screenshot_1494931543.png
https://chat.zulip.org/user_uploads/2/7c/PSAvceGaV2g_hvZYf3xXd7d7/18552755_796366293890514_954585702_o.jpg
Please make sure these boxes are checked before submitting your pull request - thanks! Guide

[x] Code is formatted.

[x] Run the lint tests with ./gradlew lintDebug and make sure BUILD is SUCCESSFUL

[x] If new feature is implemeted then it is compatible with Night theme too.

[x] Commit messages are well-written.

@Sam1301 @kunall17 can you give this a quick review?  I'm thinking we should release a 1.3.2 release in the next couple days with just this change and the emoji fix in #497

@vishwesh3 you might want to change the author details its coming as vishwesh3 commited with vishwesh3 ?
Or should I push them right away?

@kunall17 You can push them. 👍

Thanks for working on this @vishwesh3, merged :)


memery leak for deno_bindgen

deno 1.26.0 (release, x86_64-unknown-linux-gnu)
v8 <IP_ADDRESS>
typescript 4.8.3
code is there https://github.com/usrtax/deno_bindgen_test
use deno_bindgen::deno_bindgen;

#[deno_bindgen]
fn add3() -> &'static [u8] {
    &[
        1, 2, 3, 4, 5, 6, 7, 9, 0, 1, 2, 3, 4, 5, 6, 7, 9, 0, 1, 2, 3, 4, 5, 6, 7, 9, 0, 1, 2, 3,
    ]
}

test code https://github.com/usrtax/deno_bindgen_test/blob/main/lib/test.js
#!/usr/bin/env -S node --es-module-specifier-resolution=node --trace-uncaught --expose-gc --unhandled-rejections=strict
var main, n, sleep;

import {
  add3
} from '../bindings/bindings.ts';

sleep = () => {
  return new Promise((resolve) => {
    return setTimeout(resolve, 10);
  });
};

n = 0;

while (true) {
  main();
  if (n++ % 10000 === 0) {
    gc();
    await sleep();
    console.log(n, Deno.memoryUsage());
  }
}

run as begin

run 3mintues RES 1040M

run 10minutes RES 2177M
run 1hour RES 14.9G

Deno.memoryUsage doesn't seem to be very accurate, pay more attention to the memory usage in top

You are doing 'static stuff, any 'static stuff won't be dropped or freed until the application successfully exited.

I change code into
#[deno_bindgen]
fn add3(a: u64, b: u64) -> u64 {
    a + b
}

memery still leak

Thanks for the report. This is a known issue, deno_bindgen leaks the buffer to JS land. The JS bindings should register a finalization callback to free the buffer.


replace multijson with Oj in config/initializers/json #encode

remove use_optimized_json_encoder to always use Oj (needs capi-release
pr to remove property)

bundle exe rake passes except for spec/request/v2/apps_spec.rb:1371 which fails due to cpu stat having different precision (it calls MultiJson directly in the production code)

Note that we still use multijson in many locations (quick grep showed

100 results)

had use mode: :rails inorder to get the correct json format (before we
had ^t, symbols, and nils all over)

had to use time_format: :ruby because the timestamps had different
precision

Co-authored-by: Michael Oleske<EMAIL_ADDRESS>Co-authored-by: Merric de Launey<EMAIL_ADDRESS>Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

A short explanation of the proposed change:

An explanation of the use cases your change solves

Links to any other associated PRs

[ ] I have reviewed the contributing guide

[ ] I have viewed, signed, and submitted the Contributor License Agreement

[ ] I have made this pull request to the main branch

[ ] I have run all the unit tests using bundle exec rake

[ ] I have run CF Acceptance Tests

If this PR helps memory issues on the majority of endpoints, I think it's fine to merge before removing all instances of MultiJson.  We can do that in a later PR


Update gRPC generator

Looks like we need a generator change for at least one API, in terms of deprecation. That's surprising - I'll look into it.

I'm fixing OSConfig now...


fix: update transaction filename in getTrackExpenseInformation

Details

The regression: https://github.com/Expensify/App/issues/46718 is because we're using spread operator on File-type receiptObj to update the file name, hence the binary data is malformed when we send the TrackExpense request. In this PR, we will fetch the original filename in the transactionDraft data in getTrackExpenseInformation function.
Fixed Issues

$ https://github.com/Expensify/App/issues/43579
PROPOSAL: https://github.com/Expensify/App/issues/43579#issuecomment-2227058847
Tests

Navigate to https://staging.new.expensify.com/
Log in with any account with a workspace
Track a scan expense in the self DM
"Share it with your accountant" on the actionable whisper
Share it in any workspace

Verify that: After step 3, user is able to submit a scan track expense. After step 5, preview image of the shared expense should be available immediately.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Navigate to https://staging.new.expensify.com/
Log in with any account with a workspace
Track a scan expense in the self DM
"Share it with your accountant" on the actionable whisper
Share it in any workspace

Verify that: After step 3, user is able to submit a scan track expense. After step 5, preview image of the shared expense should be available immediately.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/5f27258d-8d41-4ac3-a70b-472be586f209

Android: mWeb Chrome

https://github.com/user-attachments/assets/a7e3c0f5-3e04-40ad-8aa9-d950da35b9f3

iOS: Native

https://github.com/user-attachments/assets/272b1f96-a172-4550-a6b8-1e96ec891c6b

iOS: mWeb Safari

https://github.com/user-attachments/assets/933403dd-111f-4224-bb13-3057e716f35f

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/1791161c-d26a-4021-81d3-8a48b4065681

MacOS: Desktop

https://github.com/user-attachments/assets/b6433122-a4b5-4388-909e-ba098eefcb75

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/bondydaa in version: 9.0.21-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Two images replaced that weren't rendering properly on mobile

Replacing 'Accordion' and 'Card' images with outlined images that weren't rendering on mobile

Tugboat has finished building the preview for this pull request!
Link:

https://pr90-qj3kxuafftnp9pqsle5d7zb7dzzxmzaw.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/5f84f7d6eeb8ee0a9e792a6f

Tugboat has finished building the preview for this pull request!
Link:

https://pr90-qj3kxuafftnp9pqsle5d7zb7dzzxmzaw.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/5f84f7d6eeb8ee0a9e792a6f

Tugboat has finished building the preview for this pull request!
Link:

https://pr90-qj3kxuafftnp9pqsle5d7zb7dzzxmzaw.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/5f84f7d6eeb8ee0a9e792a6f


Dedent breaks islands client side

Describe the bug
See:
https://dmadisetti.github.io/quarto-marimo/ui.html
breaks because values like:
def fn(x):
    pass

get turned into
def fn(x):
pass

there's the raw flag on the non-reactive side. Couple ways to go about this, I include 2 in the relevant PR:

propagating the raw flag to the client
just removing dedent client side

Environment
islands head
Code to reproduce
generator.add_code("""def fn():
    pass
""", raw=True)

works server side but breaks client side

I can fix this

Nvm you already got it, thanks!


Podman build does not respect log-level flag

Podman build does not pass the --log-level global flag into Buildah, so debugging output will only occur for Podman itself.
I haven't checked, but I suspect other global flags are also not respected

Most if not all the global flags are indeed not respected.  I'll work on that, nice catch @mheon.

@mheon --log-level=debug should work now in podman.  However that's the only error level logging that Buildah does atm, so anything else passed in is a no-op.  I also turned on the flags that are common between both.  That was in #312.  More to be added.

@TomSweeneyRedHat I think we can say #312 fixed this issue. Closing.


Add ZigZag Conversion of Leetcode

🚀 Feature
I would like to add ZigZag Conversion of Leetcode(Medium)
Have you read the Contributing Guidelines on Pull Requests?
YES
Motivation
I would like to add this question in CPP language
Pitch
It's a question which is related to string manipulation
It can be asked in coding rounds of the interview process
I think it will be better if we can have the solution of this question in the repo

/assign


chore: Add test for claiming funds of a force closed channel

Turns out the relevant configuration is our_to_self_delay and not their_to_self_delay. The later only specifies the amount of blocks we are at max willing to wait for claim funds after a force closed channel. our_to_self_delay is eventually the configuration we are using in case we are opening the channel. We used the default value of 144 blocks which is about 24 hours. I think this value is reasonable, but could be decreased even more for our just in time channels.
This PR pulls this config to 10101 and sets it to the default value of 144. So nothing changes here. I also added a test to ensure that force closing is actually working.
TIL: the app needs to be online after 144 blocks to broadcast a transaction to be able to claim the funds. LDK does not do that automatically.

This insight should remove the critical flag on the ticket #555

bors r+

bors r+

bors retry


Making NCF Reflect Production Usage

SWG Notes:
NCF does not reflect common loads people use in industry. There are multiple proposals to improve -- currently resolution is being pushed forward by Intel & Google.

SWG Notes:
See MLPerf training repo PR #256 with new code update to NCF.
In brief, making the benchmark larger (dataset ~60x) and longer running.

NCF replaced by DLRM.


COUCHDB-769: Store attachments in the external storage.

Initial implementation that allows CouchDB to store attachments outside of the database file.
This implementation supports OpenStack Swift and SoftLayer Object store

Please fix:

Style: try to fit 80 chars line length, put space after comma, no tabs, correctly aligned clauses etc.
Reduce amount of debug logs: debug logs should help you understand what going on in your code and in which state it is in places where problems may happens, not produce noise about every logical step.

Would be nice to see some tests for this to prove that this all works.

I'm not going to have time to review this in detail, but I agree it needs tests to go in, as well as considerable cleanup.
Noting here that this should not be merged before 2.0 is released whatever happens.

@kxepal @rnewson
I provided another patch, implementing most of the comments.
Here is what is not implemented in this patch:

Remark on the AttFun. Not yet implemented. Original remark:  “AttFun could be actually an attachment data or some fold function? Something went wrong if you have to do this.”
usage of  couch_util:to_hex
still no unitests

there's a lot to review here. The huge number of :debug calls seems inappropriate, and often appears to be placeholders / reminders for future work (like error handling).
I note also that indentation rules are still not followed (4 spaces, no 'pretty' alignment).

Given the nature of the patch, this cannot merge without tests, assuming all style and other issues are resolved.

@rnewson what is the style convention i should use? For example, there was a comment that my code should use 80 chars per line, but there is bunch of existing code with more than 80 in a line.
Is there any template for Eclipse so i can use it for style? spaces, tabs, etc..

@kxepal @rnewson

Please ignore the debug statements in my code. When my code will be stable enough - i will just remove those debug prints. Since i am changing code rapidly - i still need those prints.
You both wrote that the code style is not good. Can you please tell me what should be the code style? Is there any template i can use? Is there any documentation in CouchDB where it's written what should be coding style? Perhaps i missed it.
Tests: What would you like to have exactly? To fully test that my patch is working there is need to access the Swift cluster. I have some functional tests, that upload attachments to CouchDB. Those tests access Swift cluster directly and verify that attachments stored correctly. But i assume it's not what you mean. Can you please point me to some existing tests in CouchDB so i will see what i should implement in my case?

@gilv
2. I'm afraid there is no any document that describes whole set of rules. I want to setup elvis to define and control that, but it's a future. For now, better just follow the comments.
3. Tests need to cover whole attachments API to ensure that everything works same as before + I think some test with replication would be nice to have to see how it goes. Here is the main question is how to ensure that swift integration code is really works. I'm not sure that it's possible to verify that without Open Stack cluster. Hopefully, today, we have docker thing for the resque.

@kxepal @rnewson
Few notes related recent patch

Please ignore all debug / info print statements. At some point i will remove them at once.
I addressed most of the comments.
Remark on the AttFun. Not yet implemented. Original remark: “AttFun could be actually an attachment data or some fold function? Something went wrong if you have to do this.”
Still no unitests / functional tests.
Attachment retrieval from the object store - keep all data in memory. I need to figure out how to use streaming there.

@kxepal Can you please review the recent code?

@gilv i think att_store/2 should be att_store/3 with Options param so that we can have different drivers for different databases and/or documents. get_backend_driver should try to read it from Options mentioned above and get it from config ( maybe add a section external_storage_drivers for mapping) with default to active_store. the Options would also allow passing specific driver options.
thoughts ?

@gilv I can read the code and leave few more comments about styling, naming and else not-much-important-but-annoying bits, but I think that would be much better see any tests and the way to try this at home. That's more important than yet-another-spacing issue.

@lazedo I think there is no practically need: these options could be fetched within att_store/2 transparently for the API user during driver resolve and without abstraction leaks.
Assume we have per-db driver configuration. Where such options will be stored? First case: in config. Then we do Driver = get_backend_driver(Db) and Options = get_backend_driver_options(Db, Driver) right before do any driver API call. Another case: db options are stored in _metadata db - but this changes nothing, only configuration backend. What else Options could be passed here?

@kxepal i'm thinking in a way to have different provider per attachment/document. the use case is a document with two or more attachments where one could stored in a public accessible manner (dropbox, gdrive) and others more sensitive or private could be stored in another like evernote.
the per-db driver configuration makes sense but i believe it doesn't respond to this?

@kxepal passing the Options to the driver would also allow for example to for form the complete url in a google drive driver implementation (folder name).

@lazedo
Options argument assumes that it will be passed from the outside. Who will form it and how? And if it contains some url to there attachment have to be stored (by your example, as I get it right), how it would be preserved on the following attachment read? Have to be we need to store these options somewhere and link them by the database-document-attachment triple id. In att_store we already have all these information that need to lookup such options (assuming that they are stored outside of the document).
Per-attachment configuration involves custom attachment stub fields feature, so they all will be available for the passed Doc argument (in anyway it's a reasonable to store them within the document itself). But that would be a question how to store private information there and how they should be replicated.

@kxepal maybe i'm missing the objective of this feature. as i see it, a external attachment would still create the stub information about how to reach the real attachment. the stubwould have the information needed to get the attachment back, so, you would need to store the driver in case the configuration is changed and you start using another driver but still want to reach the already stored attachments. the options would allow more flexibility to the driver creating the necessary stub information needed to get the attachment back and also to choose which driver we want for the attachment.

@lazedo I think I miss the case as well. Anyway, to give the proper answer on this need to implement few more different drivers against very different backends for point of their API. Then we can shape our API more-or-less right. Now it's more like a proof-of-concept, but need to start from something.


Support for R# 2024.2+

Since the introduction of API Verifier there is no need to repack the plugin for each major release. There have been no API changes since 2024.1, so the current version will still work in 2024.2. Are you having problems with it?

Ok, great! Tried upgrading R# now and this plugin works.
I usually check the plugins website first before upgrading R#, and it's not clear on there whether this plugin is compatible with the latest 2024.2 release.
https://plugins.jetbrains.com/plugin/11645-zensharp-auto-completion-plugin/versions


Remove hard-code segment from test base path

Resolves https://github.com/Azure/autorest.csharp/issues/4771

Can we start a TypeSpec.next regen to check?

The test failures are due to TypeSpec.next regen, which needs further investigation.
The fix in this PR is verified.


Add permissions template

I believe we could add a template for the permissions doc in markdown format to this repository, so that in future we could just use the template.
@V1shvesh would you please add it?

Definitely

yup! that will be great.


New columns

Is it possible to some data (odometer, power etc.) be saved in separated columns in table positions through changing traccar.cfg (of course, with manual table adaptation) or the changes have to be done through modification of code?

Depends on the database engine you are using. For example, in MySQL you can use ExtractValue function to get values from XML field.

Thank you for your prompt reply.


Cater for new OT classes API

JSON-Patch-OT classes API are about to change (if approved) and this cater for the upcoming changes in https://github.com/Palindrom/JSON-Patch-Queue/pull/7 and https://github.com/Palindrom/JSON-Patch-OT-agent/pull/4
Naturally, tests won't pass until the mentioned PRs are merged.
Fixes: https://github.com/Palindrom/Palindrom/issues/157

Looks like you've nailed the reason for the error, but I am not convinced about the robustness of the solution.
Is it possible to solve it by changing the first argument of the receive() method from obj reference to a callback that returns obj? That would be easier to use correctly and more similar to the previous API.

All PRs updated and ready for review.

@warpech could please review OT.js? You understand it the best. If you want to review the whole PR, it's only ot.js and src/palindrom.js


stylefunction.js' fromTemplate might receive an array

Hiya,
Just came across this issue where the stylefunction.js' fromTemplate function receives an array as it's text argument, therefore it throws a wobbly.
Uncaught TypeError: text.match is not a function

Within Mapbox Studio one might use a function (to-string()) to convert non-string fields to string fields and use those as labels, hence the issue.
The text argument looks something like this:
["to-string", ["get", "<attributeName>"]]

A quick and dirty workaround can look like this:
if (Array.isArray(text) && text.length === 2 && text[0] === 'to-string' && Array.isArray(text[1]) && text[1].length === 2 && text[1][0] === 'get') {
  text = properties[text[1][1]].toString();
}

It looks like the returned value is an array even if the label is defined as a single string field (i.e. without a function like to-string).
["get", "<attributeName>"]

Moreover, there are a lot of other functions available, like length, match, any, etc.

Have you tried this with latest master? #86 added support for these expressions, so your styles should work now.

That's great news.
Sadly I could not try the latest master as both npm i ol-mapbox-style@latest and npm i in a freshly cloned repo fails with
./util/has_lib.sh: line 31: pkg-config: command not found

on macOS.

Sorry, I meant npm i boundlessgeo/ol-mapbox-style not npm i ol-mapbox-style@latest.

That's the canvas dev dependency. Try npm install --production ol-mapbox-style@beta.

After installing pkg-config and cairo w/ Homebrew both install methods work just fine.
However, I'm back to square one, as I get the same error even with<EMAIL_ADDRESS>

Can you share a validated style document that triggers the error?

Sure thing - style.json.zip.
Validates fine against mapbox-gl-style-spec v12.0.0.

Thanks @aberenyi. I just pushed d605f0dd9d2827735f7bdd6ff47a7c2824f81828 and released v3.0.0-beta.9. The problem was that we tried to convert expressions to expressions.
Can you please verify that things work now and report back?

Works like a charm - many thanks @ahocevar!


Execution failed

An error occurred while executing the program

ONLY ACTIVATION VIA ACCOUNT WORKS NOW, KEYS ARE NOT AVAILABLE!!!


Add experimental support for horizontal fusion of matmul

LLaMA has a pattern where matrix multiplications occur causally disconnected from one another and after some element-wise operations are both consumed by the same operation. These matrix multiplications are "horizontal" from one another and there are some situational performance optimizations for fusing them into the same dispatch.

you can run python build_tools/bazel_to_cmake/bazel_to_cmake.py to fix the bazel to cmake lint errors.

You probably need to sign the cla

I did sign it after the error popped up. It's showing as signed to me now. Am I missing something?

I did sign it after the error popped up. It's showing as signed to me now. Am I missing something?

It shows as signed now. The bot does not update it's comment:

I'm confused about this pass, did I test littest demo, make ?=1024 and other demo matrix shape 1024 * 1024, but unable to understand the reduction in execution time in iree-benchmark-module tool (I used cuda SIMT pipeline SM60 to generate matrix multiplication code). What situation will bring about performance improvement?

I'm guessing with the dynamic dimension is much smaller (matvec) - horizontal fusions like this are usually about balancing compute utilization with memory system utilization. If you're compute bound (such as with large square matrices) then doing more compute won't help but if you're memory bound then doing more compute can often be free/cheap. The other case (where I'm not sure this helps?) is when you want to perform 2+ matmuls using the same weights - from the test this seems to do LHS, usually that's RHS.
Or I could be wrong :)

I created this patch at the request of @harsh-nod who may be able to comment more about his use case.
My basic understanding was that there were some kernels that were being targeted which were already deeply optimized in a way that made this fusion simpler while still being faster than non-optimized code generation.


Revert "Adds external.platform.(apiKey/autoSleep/autoDelete) docs"

Reverts loft-sh/vcluster-docs#194

I need to revert this change (I grabbed the commit onto my local branch)


solana-validator 1.10.35

Solana was added in pull #121009 along with a few other updates like #169506 (added an update.sh script) and #152055 (fixed a few dependencies).
The current solana package only provides the cli binary. This package adds the following binaries

solana
solana-bench-tps
solana-faucet
solana-gossip
solana-install
solana-keygen
solana-ledger-tool
solana-log-analyzer
solana-net-shaper
solana-sys-tuner
solana-validator
cargo-build-bpf
cargo-test-bpf
solana-dos
solana-install-init
solana-stake-accounts
solana-test-validator
solana-tokens
solana-watchtower

These packages are helpful if you would like to begin developing solana programs, operating a validator,  RPC node, or contributing to the solana codebase.
Currently there is already a solana testnet cli package from @ruuda and @happysalada. Given that the solana codebase is large and there are many associated binaries I created a separate solana-validator package. I am very curious to receive feedback if this package should be separated or combined with the prior.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This is good stuff! And you were even bold enough to keep in the update.sh in the oil language.
Thanks a lot!

For my understanding, the last time I looked into this, the blocker was that the Solana development tools download binaries for the BPF SDK at runtime, did you manage to build that from source? I don’t see a reference to it in the diff.


DocumentCollection.isEmpty() is wrong

public boolean isEmpty() {
return this.size() > 0;
}
Is checking is this.size() > 0, so actually returning whether it's NOT empty.

I have verified this in my own testing.
Created a DocumentCollection with 1 document.
collection.getCount() returns 1
collection.isEmpty() returns true
collection.getFirstDocument() returns a valid document.


chore: disable tag validation function

Tags validation is already occurring on the go side and gopher-lua does not properly handle ASCII (or extended ASCII) range expressions in the string.match implementation using gopher-lua/pm module.

#10 implements this correctly


ToC management

It would be perfect to have the ability to enable Table of Contents for pages and posts.
Maybe on a column at the right of the content column.

hey there, Thanks for your concern, but there is no space for adding TOC in this template.
Please try this theme
https://gethugothemes.com/products/godocs-hugo-documentation-theme/ .
It has all the features and an advanced search system.


Anyone have any luck with st7789h2 drivers?

I've got a few 240x240 screens i've been trying to get to work, both use the st7789h2 driver. One is a 1.54" screen from Formike/Wan Display and the other is a 1.3" 240x240 from Crystalfontz. I've been unsuccessful getting them to work.

Sorry, missed this issue from before.
I have not seen ST7789H2 before. There are a couple of backends for ST7789 and ST7789VW in fbcp-ili9341, but not for H2. No idea how that differs. Were you able to make it work?


Add release drafter github action

This change should help preparing list of release notes for future
releases. When a maintainer will want to make a release he would
be able to tune the draft release notes and copy them to the
changelog.
The biggest advantage of this change is that the creation of the
draft is automated and it already uses the desired format, with
title link to PR and mention of author, reducing the maintenance
chore when preparing for a new release.

Changelog-friendly one-liner:
Contributor checklist

[x] Provided the tests for the changes.
[x] Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
[x] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

FTR, I've enabled allowing only GitHub released GitHub actions and verified actions from the Marketplace to make sure we don't have a wildgrowth of actions used. I'll be opening a discussion later in the members team to explain why I do that and how we'll have to batten down the hatches a bit.

To be more clear, here's the set of actions allowed for this repo at the moment:

@jezdez FYI deadsnakes doesn't work and it breaks CI workflow

@jezdez maybe those trailing commas break things?

Oh, yeah, I fixed this already, this just needed “@*” appended.

@atugushev @jezdez Does it look ok now? Did I miss anything or is ready for approval. I can wait for two approvals for this one if you think that is needed.

@atugushev Can you please review this? I would like to enable it so we can benefit from it for the new release.

@atugushev Please give it another go, I hope I addressed all comments.

@jezdez Added that change. Please do not forget to approve it. As long you appear with "requested changes" we will not be able to merge the change, regardless other approvals.

@jezdez Added that change. Please do not forget to approve it. As long you appear with "requested changes" we will not be able to merge the change, regardless other approvals.

Yep, that's how it was intended. Thanks for working on this @ssbarnea!


Fix #320: Unsupported event crash.

After recent changes in RN core we started seeing the well known "Unsupported event" crash.
The crash is due to the fact that gesture handler requires for all view types to accept geature-handler events, namely, onGestureHandlerEvent and onGestureHandlerStateChange. This is necessary for us to be able to deliver those events to RN Views and other components that need to respond to gestures. As RN core does not expose a method that'd allow us to register custom events for RCTView, we've been relying on a few workarounds that unfortunately only worked on some version of RN. The latest workaround was to override genericDirectEventTypes object from UIManager configuration. This object is then used during view registration to populate event config maps. We've been extending UIManager.genericDirectEventTypes at first until it got moved to UImanager.getConstants().genericDirectEventTypes -- after that change we started overriding getConstants method to return the extended object. For a reason I haven't had time to figure out this stopped working in RN 62 and the current workaround is to just extend the object returned from getConstants() relying on the assumption that this method always returns a reference to the same method.
As it was the case for the previous workaround this one still requires that we load gesture-handler module before any view registration is done. Once the views are registered it is no longer possible to update their event maps for their view configuration.
It is important to note that the crash has been happening on iOS in release mode only. It does not occur in other configuration as of this monkey patch that adds static JS configuration https://github.com/facebook/react-native/commit/942de5718236ddbd1a112a2ce7adf20591949672. However this patch does not work in release mode due to the fact that the static JS config is only loaded via registerGeneratedViewConfig method which is only used in DEV mode, while requireNativeComponent is used in release – see the relevant commit: https://github.com/facebook/react-native/commit/42cf8a92416a49584e8eedda798c371eb83ec932

Closes #320


Resources, topics and goals should have visibility (public / shared / private)

In moving away from CCs broadcast model from specific content creators to Agora's all users are creators of resources model the issue of modes of resource / topic / goal visibility needs to be addressed.
Users should be able to keep resources private, share them with particular individuals or make them public.  When grouping in goals and topics some resources associated with these may be public or selectively shared and users will see the topics or resources that the have access to, but not the others.

Added fields (visibility) to goals, topics and resources
altered model, services


Inserting a Teaser Figure Above the Abstract in the CVPR Template

With the latest Typst v0.12 update, it should now be possible and straightforward to insert a teaser figure above the abstract for the CVPR template, as this version supports multi-column floating figures. Thank you for your assistance.

I did a quick fix by inserting the figure directly below the Paper ID
// 2. Authors and affilations.
  block(width: 100%, spacing: 0pt, {
    set align(center + top)
    set text(size: font-size.large)
    if accepted != none and not accepted{
      [Anonymous CVPR submission\ ]
      [\ ]
      [Paper ID #id]
  [#figure(
    image("figures/Teaser.svg",width: 100%), caption: " Caption"
  ) <fig:teaser>]

This is actually possible even without the update.

to insert a teaser figure above the abstract for the CVPR template, as this version supports multi-column floating figures

I didn't get it. Could you give me an example of what the page should look like?


Put a lock around eccodes usage

Might prevent segfaults
#328

@emfdavid , this also fixes an ordering thing that might have been the root cause. The lock may then be superfluous, but probably no hindrance.

I'll merge and release right now


Only support update sts

Related issue: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/36467
@kgcarr I found the service update issue.
Currently, all the API attributes only used for sts, so I think we can just only update sts, other resources don't touch, it will avoid update service.
{"level":"error","ts":1588909382.0103092,"logger":"controller-runtime.controller","msg":"Reconciler error","controller":"mongodb-controller","request":"ibm-common-services/ibm-mongodb","error":"could not Update resource: Service \"mongodb\" is invalid: [metadata.resourceVersion: Invalid value: \"\": must be specified for an update, spec.clusterIP: Invalid value: \"\": field is immutable]"

cc @chenzhiwei @horis233

This won't protect against the other way where a client updates one of the mongodb resources and the operator sets it back

@kgcarr I think that is a function of the operator. Users should update the CR to update the operands. If users want to update the resource directly, they need to uninstall the operator.

@horis233 right, currently this operator does not enforce that. You can install with operator, go change the configmap and the operator will not go and set it back.

This fix only handles user update OperandConfig case.

I tested this PR and it does work to support statefulset changes
/lgtm


reasonable query filtered by 'Responsible AI Service'

Type: Bug
While working on a python regex, my queries were filtered by the "Responsible AI Service". My queries were as follows

show me some examples of the re.sub() function
show me some examples of python's regex sub function
Maybe there is something I dont understand about the Resonsible AI Service, but seems more likely a bug.

FWIW, I did receive useful responses from Chat GPT after getting this response from Copilot.
Extension version: 0.21.0
VS Code version: Code 1.94.0 (Universal) (d78a74bcdfad14d5d3b1b782f87255d802b57511, 2024-10-02T13:08:12.626Z)
OS version: Darwin arm64 24.0.0
Modes:

System Info

Item
Value

CPUs
Apple M1 (8 x 2400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.05GB free)

Process Argv
--crash-reporter-id 05091d72-9159-4452-9de4-e7a82d94d759

Screen Reader
no

VM
0%

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
2e7ec940:31000449
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
9c06g630:31013171
a69g1124:31058053
dvdeprecation:31068756
dwnewjupytercf:31046870
newcmakeconfigv2:31071590
impr_priority:31102340
nativerepl1:31139838
refactort:31108082
pythonrstrctxt:31112756
flighttreat:31134774
wkspc-onlycs-t:31132770
wkspc-ranged-t:31151552
cf971741:31144450
defaultse:31146405
5fd0e150:31146321

Can you include your logs via CMD + SHIFT +U -> Github Copilot Chat

Thanks for creating this issue! We figured it's covering the same as another one we already have: https://github.com/microsoft/vscode-copilot-release/issues/2625. Please refer to that one for updates and discussions. Feel free to open a new issue if you think this is a different problem.


Repeating Instruction Examples

Is there a way if I want to query a model for a similar question + set of instruction to avoid passing the instruction every time?
eg.
prompt = ['which categories does this <thing> fall in from the list below?\n - fruit \n -vegetable \n etc.']
response = openai.Completion.create(model="text-davinci-003",
                                            prompt=prompt,
                                            temperature=0.0,
                                            max_tokens=256,
                                            top_p=1,
                                            frequency_penalty=0,
                                            presence_penalty=0
                                            )

I want to ask this question for a lot of different <things>, and avoid being billed every time for the same words & instructions.

Unfortunately not.
One option is to train a fine-tuned model to do that task, which won't need instructions.

no, unfortunately not, although chatbots dream about this feature

this works so well in the ChatGPT frontend ("do the same"), so: any hints as to how one could "train a fine-tuned model to repeat the task without having to clutter the prompt with its repetition"?

@ted-at-openai on the pricing area it says fine-tuned models are even more expensive for usage ( which would not reduce the cost ).
Once you fine-tune a model, you’ll be billed only for the tokens you use. Requests sent to fine-tuned models are billed at our [usage rates](https://openai.com/api/pricing/#quotas).
@athn-nik, you want to categorize (classify) , and what you are looking for is a way to avoid open.generate each repetitive , or do I understand it wrong?
Try applying a vector dictionary alongside OpenAI embeddings ( Diversity measurement or classification between  and <already_generated_things> are good examples, in the embeddings link, there is an example of a vectors database using Redis )
You can also use Any approach of NLP to compare the distance between prompted  to <already_generated_things>
Disclaimer:
If  is dynamically classified ( it can be a fruit today and a vegetable tomorrow ), you might need to generate each time, or in time frames within a dictionary.

Fine-tuned models are more expensive per token. If they allow you to use fewer tokens, they can be less expensive. It depends.

@MuraraAllan I want to do the same "task" for lots of samples, aka ask the same question, give the same instruction and examples and "label" a different text. Eg:
Determine if this pose contains the knees.
Yoga pose: yes
kneel pose: yes
Waving pose: [....]
Similar to this task for many different [....]


Setup CD to npm?

Not sure if you want to or not, but Travis allows auto publish to npm.
https://docs.travis-ci.com/user/deployment/npm/

Yeah that's a great idea! Unfortunately it still doesn't mean we get to publish directly from a PR since that doesn't make a tag, but it's still better I guess?

@stubailo I wrote this for our usage on circle ci. Any libs we ship to npm get deployed on merge to master. https://github.com/NewSpring/ops-ci-npm-publish.
Either way, just thought I'd mention it :+1:

Yeah @helfer and I were just talking about this the other day, basically I was complaining that it's a hassle to republish manually.

Automate what's important right? We have a pretty hard and fast rule that if we can't auto deploy something, we don't build it. It's mainly so we can take vacations and not be on call hahah

Decided that auto deployment isn't the way to go

Yeah to explain further I really want to be able to add people as contributors but not trust them to publish to NPM. Perhaps some auto-deploy with a bot that checks with the admins would work.

@stubailo I think facebook has a deploy bot and I know github has deployments hooked into hubot. Could be something to do one day 👍
For now a deploy script:
https://github.com/apollostack/apollo-client/pull/169


import NIOFoundationCompat or not

I find that I can use func readData(length: Int) -> Data? without import NIOFoundationCompat. Would import NIOFoundationCompat make any difference?

If you can use readData, someone is causing you to import NIOFoundationCompat without the explicit import. You should still make the explicit import yourself.


3d viewport getting shrinked when i try to use in my old project

version: Godot 3.4
when using the superscaling

correct proportion (without the superscaling):

4
my configurations

:

Sorry for the delay, I just saw the notification. First make sure that your Project Settings Window Stretch Mode is on Disabled and Aspect on Ignore. Also, did you download from Github or the Asset Library? The Github is more recently updated, so you should try to download that.
https://github.com/cybereality/godot-super-scaling/releases/tag/v1.2.0
Other than that I'm not sure cause I can't reproduce on my end with my test projects. If those steps above don't solve the issue, maybe send me a minimum reproduction project and I can investigate.

i downloaded it from the github link, it's the recent build, all my ui depends on stretch mode viewport and aspect expand to work nicely.
here goes the link from the project:
https://github.com/lucasthomaz97/Cheesewald-Gourmet-Adventures

Okay, I will take a look today. It believe it should be fixable, but let me investigate.

So I got it to work, but it requires changes to the settings.

Basically, you cannot use Viewport scaling or Test Width/Height. As this uses the internal Godot scaler, which conflicts with my scaler. The image has to be at native resolution (not scaled) for my algorithm to function. The changes required are setting Stretch Mode to Disabled, Aspect to Ignore, and setting Test Width/Height to 0/0. This will display a 1080p window with everything working, as shown in the above image.

nice! in this print the rendering got pretty pixelated... the filters solve it?
i tried again in a fully test scene, but it don't appear as a selectable node or in the plugins screen, what happened?


Combos -- relayout:true causes nodes to disappear from view

Describe the bug
When collapsing an open combo, when relayout: true is enabled, it causes all other combos in view to disappear from view  despite that there is space in view to keep them in view
Your Example Website or App

https://codesandbox.io/s/icy-snowflake-nqdzxx

Steps to Reproduce the Bug or Issue

Load the codesandbox.
Collapse one of the open combos by double clicking on it
After combo shrinks, all other combos that were previously in view dissapear

Codesanbox: https://codesandbox.io/s/icy-snowflake-nqdzxx?file=/src/index.tsx
https://user-images.githubusercontent.com/6743796/156076437-cce0fa9f-1670-4e85-aa24-11060cb4f8fb.mp4
Expected behavior
When relayout: true is set, it should not cause combos that we're previously in view to completely go out of view, especially if there is sufficient space in the canvas viewport to keep the combo in view.

G6 Combo Relayout documentation

Platform

G6 version: 4.6.0-beta4 (happening for non-beta versions as well)
OS: MacOS
Browser: Google Chrome latest version
Version:  98.0.4758.109

Question
Is the behavior of relayout: true suppose to look something like this ideally?
Concepts (not from G6)

References

Circular combo example
rectangular combo example

After collapsing/expanding, the size of the combo changes, and the layout is re-calculated according to the current conditions, e.g. size of combos, visible nodes and edges, etc. That leads to the position changes of the 'disappear' items. Turn on animate: true on the graph instance you will see the position changing.
Actually, it should be optimized to keep the continuity of observation. The comboForce should consider to enlarge the 'mass' of the unchanged items to keep the positions as much as possible. I will try to optimize it

Use 'comboCombined' instead with latest version of @antv/layout and @antv/g6. 'comboForce' is not suggested anymore since it does not perform well on most real cases.
And I will try to add some demos to the website as the videos you provided . Follow the progress about it on the issue https://github.com/antvis/G6/issues/3588


Change tag / release title

👋🏼 Came across you repo after not discovering much other calver actions out there. I would like the release title to be 2<IP_ADDRESS> instead of Release ver. 2<IP_ADDRESS> any chance you can make that a knob to turn via an option? Thanks!

@onedr0p Thanks for your idea. It will be helpful to make the release name customizable. I'd like to work on it later.

Having a date format option would be nice too but that's up to you 🙂

@onedr0p
2<IP_ADDRESS> is out so that you can customize release title via the input parameter. 🎉
Feel me to raise issues or pull requests if you encountered problems.

Having a date format option would be nice too but that's up to you

Exactly. Just want to collect more use cases to see how flexible it should be but customizable version is definitely on my roadmap.

Thanks!
Maybe to help a bit on how flexible you could make changing the date, I'm just looking for a date format of something like this
2023.1.1


Multisig. Operation details. There is empty info for chain without block explorer for extrinsic.

Description
Bittensor has no block explorer for extrinsics:

Environment
https://github.com/novasamatech/nova-spektr/tree/release/1.9.3

Status verification: ✅


Adapt plugin for Data Table API 2.0.x

Jenkins and plugins versions report

Environment
Jenkins 2.426+
Data Table API 2.0.1-1
master

What Operating System are you using (both controller, and any agents involved in the problem)?
N/A
Reproduction steps
Apply patch
diff --git a/pom.xml b/pom.xml
index 08de185..7c3f052 100644
--- a/pom.xml
+++ b/pom.xml
@@ -59,7 +59,7 @@

   <properties>
     <changelist>999999-SNAPSHOT</changelist>
-    <jenkins.version>2.387.3</jenkins.version>
+    <jenkins.version>2.426.3</jenkins.version>
     <gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
     <spotbugs.effort>Max</spotbugs.effort>
     <spotbugs.threshold>Low</spotbugs.threshold>
@@ -70,11 +70,16 @@
     <dependencies>
       <dependency>
         <groupId>io.jenkins.tools.bom</groupId>
-        <artifactId>bom-2.387.x</artifactId>
-        <version>2543.vfb_1a_5fb_9496d</version>
+        <artifactId>bom-2.426.x</artifactId>
+        <version>2857.v01a_0144eb_20b_</version>
         <type>pom</type>
         <scope>import</scope>
       </dependency>
+      <dependency>
+        <groupId>io.jenkins.plugins</groupId>
+        <artifactId>data-tables-api</artifactId>
+        <version>2.0.1-1</version>
+      </dependency>
     </dependencies>
   </dependencyManagement>

And visualize the resources of the instance.
You can also run mvn clean test -Dtest=org.jenkins.plugins.lockableresources.LockStepTest#unlockButtonWithWaitingRuns,org.jenkins.plugins.lockableresources.LockableResourceApiTest#reserveUnreserveApi
Expected Results
Tests are passing
Actual Results
Tests are failing.
Anything else?
This is blocking the release of BOM since the bump of Data Table API plugin https://github.com/jenkinsci/data-tables-api-plugin/pull/424
Are you interested in contributing a fix?
No response

I tried to look at how the table is created but I fail to find the culprit.

Ohoho . Ok I see . This need a little bit refactoring.
I need to provide 2 new features first, but when this means,  the plugin will be no more usable. This one will win 😉🤷♂

Can confirm the issue visually too: the data table seems to have a fixed size now (so overflows into scrolling when a browser window is too small, and the "Search" element above levitates far from the table when the window is too wide. With that said, about two fifths of the table is a content-less gray area, literally:

nice, this will be really tricky to analyze. :-(

Per browser console, there are two colgroup's each with a series of col entries. The first colgroup is our usual content. The second one is the offender, specifically the first col in it:

May somebody looks here pls
#642
thx


add proposer index to BeaconBlock

Addresses #1601

add proposer_index to BeaconBlock and BeaconBlockHeader
remove proposer_index from ProposerSlashing and instead assert that both headers have same proposer index
add and modify tests

Sounds good. Added a couple of additional sanity block tests to cover the combinations on how the index might be messed up

def process_randao(state: BeaconState, body: BeaconBlockBody) -> None:
    epoch = get_current_epoch(state)
    # Verify RANDAO reveal
    proposer = state.validators[get_beacon_proposer_index(state)]
    ...

could be refactored to
def process_randao(state: BeaconState, block: BeaconBlock) -> None:
    epoch = get_current_epoch(state)
    # Verify RANDAO reveal
    proposer = block.proposer_index
    randao_reveal = block.body.randao_reveal
    ...

@hwwhww I decided to make the changes minimally invasive and to only check that the specified proposer index in the block matches the expected in state once process_block_header. Otherwise to keep everything to same.
One place that could also be refactored is process_attestation, but this would involve changing the function signature.


fix GR issues in doc make

Codecov Report

Merging #40 (4d676d7) into main (79ad611) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   84.86%   84.86%
=======================================
  Files           6        6
  Lines         522      522
=======================================
  Hits          443      443
  Misses         79       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79ad611...4d676d7. Read the comment docs.


Remove needless borrow

After upgrading Rust to 1.54.0, Clippy flagged a needless borrow in the
builder. The borrow has been removed to fix the lint.

Codecov Report

Merging #90 (be93168) into main (61fcd45) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   73.08%   73.08%
=======================================
  Files          11       11
  Lines         379      379
=======================================
  Hits          277      277
  Misses        102      102

Impacted Files
Coverage Δ

src/builder.rs
98.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f7aec...be93168. Read the comment docs.


Connect-sposervice exception on PowerShell 7

When attempting to connect to SPO using connect-sposervice on PowerShell 7 RC1 (Windows) an exception is thrown.
Exception:
Connect-SPOService: Could not load type 'System.Security.Cryptography.SHA256Cng' from assembly 'System.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'.
Research led me to issue 3926 in the dotnet/core project Please implement System.Security.Cryptography.SHA256Cng #3926.
The closing comment on that issue is:

We're intentionally keeping the CNG-specific named hashing types out. Using SHA256.Create() is the correct answer on all platforms (and also in .NET Framework).

It looks like the connect-sposervice module needs to be updated

Well, PS7 is now released to production as of last week but the error still exists.  I hate to say it but @chhinton did warn you guys.

@poortom1004, I was optimistic that this group would be communication with the group that actually supports connect-sposervice.

Hello @poortom1004 & @chhinton here, we are limited to documentation changes, we try to help everyone, said that, you can see here the official Ps 7 compatibility status with other modules you can see there that SPO isn't still there.
You can also try the new parameter -UseWindowsPowerShell

The link on compatibility you provided only relates to modules written for Windows, managing Windows, and not anything else.  Just wanted to let you know this.

The link on compatibility you provided only relates to modules written for Windows, managing Windows, and not anything else. Just wanted to let you know this.

Hello Thomas.
For a module to be compatible with PowerShell 7, the product group of that module must make it compatible to Ps 7 not the other way around. Said that, that is the list of current compatible modules.

Import the module explicitly and use the -UseWindowsPowerShell parameter.  I'm seeing success with it.

@AspenForester That may work on Windows OS but not on the non-Windows OSs that Powershell 7 supports.

Hello @chhinton
This is the official announcement where you can be sure that they are working the compatibility of other modules.

For those modules still incompatible, we’re working with a number of teams to add native PowerShell 7 support, including Microsoft Graph, Office 365, and more.

Source https://devblogs.microsoft.com/powershell/announcing-powershell-7-0/
Once they become compatible we will be able to impact any documentation. As I do not recognize any documentation change to impact right now, we will proceed closing this for now. @yogkumgit please proceed. Thank you

Import the module explicitly and use the -UseWindowsPowerShell parameter. I'm seeing success with it.

This indeed works on windows.  but seems like a pretty insane requirement.

And here we are a year later, PowerShell at version 7.2.1, with the module updated to version 16.0.22208.12000, and it still doesn't work with PowerShell because it still depends on 'System.Security.Cryptography.SHA256Cng'.  I know this isn't a documentation problem, but the dev team kinda boned the documentation team by setting the "project home" attribute on PowerShell Gallery to this github repo.

Import the module explicitly and use the -UseWindowsPowerShell parameter. I'm seeing success with it.

This indeed works on windows. but seems like a pretty insane requirement.

It worked in 7.2 only after -UseWindowsPowerShell


Add version of SetupNugetSources that works with NugetAuthenticate

[ ] This issue is blocking
[ ] This issue is causing unreasonable pain

In the 1ES PT migration, we need to add a version of SetupNugetSources.ps1 that works with NuGetAuthenticate. SetupNugetSources has two jobs:

Add equivalent internal feeds and enable darc* feeds
Add credentials for access.

Even if we switch to NuGetAuthenticate, we still need the internal and darc* feed additions. I propose adding EnableInternalNuGetSources.* which will do all the existing job of SetupNuGetSources,ps1, but without credentials. Customers would use that script instead, with NuGetAuthenticate@1 after the call.

Moving this back to dotnet/arcade since it's specific to that repo and doesn't fit in the 1ES PT epic.


Menu doesn't show on Ubuntu

The README says it may work for "some Linuxes". I wonder if you have a list. But I just tested it doesn't work for Ubuntu 14.04.

Thats because libappindicator1 is used on ubuntu.
See https://github.com/maxogden/menubar/pull/40

FWIW, electron-prebuilt: 0.31.2, menubar: 2.2.1

Any update on this? Thanks!

+1 thanks

+1


test(blockifier): update test_insufficient_max_fee_reverts to include new resource bounds

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1314
#1313  👈
#1312
#1311
#1310
#1309
#1308
#1307
#1306
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on  Graphite


fixed the download-pdf option issue

PR Fixes:

1 Makes the PDF page breaks consistent
2 The Images in the generated PDF are well visible
3 The pagination bar in excluded in the generated pdf.

Resolves #494
Before Fix :

1 Some of the images were getting hidden by the new blog-component

2 The pagination was coming include in the pdf

After Fix :

1 The Page breaks were made consistent and Images were visible.

2 The Pagination Component was excluded in the pdf

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I assure there is no similar/duplicate pull request regarding same issue

cool

@devsargam by "reduce the diff", do you mean to eliminate the unnecessary changes that was caused due to useless line-shift or extra spaces ?

Yep

@devsargam Since, I am new to open-source contributing, I am bit confused.
I have made the eliminated the unnecessary changes in my fork version and pushed it. So, we it be included in this pull request ?

@zenithexe the reason why we try to eliminate unnecessary changes is just because I can get to what you did easily.

@devsargam Okk, I have already eliminated the unnecessary changes... and made a new commit. You can check.

Works great locally. Thank you for your contribution. You will receive a bounty if it deserves one.

@devsargam no bounty for issue reporting? :-)

@skodavalla issue reporting?


STM32, suspected executor hang using w5500 (SPI) + two UARTS and I2c

Hi all I need some debugging tips.
I have build an stm32 based sensor node that reads environmental sensors and
sends the data over ethernet using a w5500. Unfortunately it starts hanging
after a while.
I am at a loss to what is causing this. I have tried and failed to make a
minimal example. I suspect something might be going wrong with executor. To
check that I added an interrupt task that does nothing except print a message
every second. When the program hangs the interrupt task hangs too.
I can not find where the it hangs, I do know that:
- If I remove the w5500 runner and stack tasks the program works again.
- If I remove one of the UART sensors (sps30 or mhz) the program works
again.
- If I add Timer::after calls here and there it takes longer before it hangs
(up to about 30 minutes)
- Removing a yield statement before the join (that polls the sensors
measuring) makes the code more reliable. (stops it from breaking 11.4
seconds after starting)
To me it sounds like running the w5500 and 2 UARTS together breaks the executor.
Could this be a manifestation of:

https://github.com/embassy-rs/embassy/issues/1427

I am no embedded engineer and I'am out of my depth here. I would love advise on
how to proceed.
Ps: a few more details

The code: https://github.com/dvdsk/env-sensor-node
I am using the latest embassy commit (128575a)
The uarts use embassy's RingBufferedUartRx
The uarts use DMA1 and DMA2, the w5500 DMA2

Same cause as #3048 ran out of memory which triggered a bus-fault, the fault handler was a simple loop .


Update brand-style-guide.md

Signed off by: Lami Williams<EMAIL_ADDRESS>I did the following:

Added a "Design File" section under "Project Name and Logo" and linked it to the appropriate URL
Changed the link embedded in "logos" to the one provided in the issue
Added a comma after "how it’s expressed"

Hi @Ruth-ikegah I don't seem to be able to get a hang of how to properly do a DCO.  I did not add it in the first PR I created, so I closed it. For the second PR, I added it, but still had an error. These are what I've tried:

Installed the DCO plugin on Chrome an inputted my name and email
After I merged the PR the second time and still saw the error, I edited the commit to match "what Github expects" in the summary of the DCO error details
Removed the space between Lami and Williams; had to edit the commit again for this

Could you guide me on how to resolve this? Thanks!

Hi @LamiWilliams sorry for this issue!
if you click on details on the dco, do you see "set dco to pass" option?

Thanks, @Ruth-ikegah No, I did not see it. This image shows I see:

Okay @LamiWilliams I just clicked it on my own end and will be merging this PR! Thank you for your contribution!

Okay, great. Thank you! @Ruth-ikegah


Distributed Sensitivity Analysis Variable Selection

So far in Shifu, only KS and IV static variable selection are supported.
Another way is to train a model and they compare the score diff if removing one column and get final MSE for all records. Sort all variables by MSE values and we can remove percentage of variables.

Done in 0.2.4 relase
Open another issue to save statistics se reports in HDFS: https://github.com/ShifuML/shifu/issues/62


feat(secret): Add examples for secret manager

Problem
Even though Secrets Management is on by default, we should update the basic example to have an optional value in the config for the admin credentials and steps in the readme.
Solution
Updated examples with new configurable parameters that allow to disable secret management (that is enabled by default) and provide own admin credentials.
Testing
Deployed updated examples and make sure that secret management is enabled and use provided credentials.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Also, can we make the commit message a bit more descriptive? How about something like:
feat(examples): add deadline secrets management options to basic example app


The search functionality parses only the source file contents and not the workflow name

Describe the bug
Since the latest release (v.1.15.0) the search functionality appears to be broken. Instead of parsing the workflow name it appears to return the closest hit by the content in the source file. This makes searching for workflows very difficult on Dockstore.
To Reproduce
Steps to reproduce the behavior:

Go to https://dockstore.org/search
Search any workflow name such as "TheiaProk"
See error

Expected behavior
The first hit should be the workflow with the closest name
Screenshots

Desktop (please complete the following information):

OS: Windows 11
Browser: Chrome
Version: Version 121.0.6167.185 (Official Build) (64-bit)

Additional context

UI version: [e.g. 2.5.0]
Webservice version: [e.g. 1.8.0]
host location: [e.g. staging.dockstore.org]

┆Issue is synchronized with this Jira Story
┆Issue Number: DOCK-2513
┆Sprint: Backlog
┆Issue Type: Story

If I understand correctly, I think this is a side-effect of https://github.com/dockstore/dockstore-ui2/pull/1847/files
Specifically, https://github.com/dockstore/dockstore-ui2/pull/1847/files#diff-66534e02e69ab397630825a0c292b82ba81f7d4da3d46a77389e2f8303b162e3R254-R255 probably need to be further boosted.
The workflows with the term "TheiaProk" in their Path are in the search results but lower ranked currently, I'd guess because "TheiaProk" only shows up once in the Path but many more times in the Description or Source Files of other workflows.


Feat/orthoconv2d

Add a layer PadConv2d with  parametrized padding
Add a layer otrhoConv2d with Lorth regularization (orthogonal convolution)
Add methods for computing the lipschitz constant of each layers
fix #33
fix #30

PR split in several sub-PRs


Use conditional mutations for AccumuloStore. Add checks for status and putRepo

Closes #4114

Marked this PR as ready for review. Leaving other checks to be done in follow on PRs.
In this PR:

Converted FateMutatorImpl to use ConditionalMutations
Added a method (FateMutatorImpl.requireStatus) add a condition that checks the status value is what we expect and use it in AccumuloStore.create(). Created a new Iterator to make this possible
Added a condition to putRepo() to make sure the spot we are inserting into is empty.
Added a new IT to test the two mentioned added checks.


testing openshift and kube again

with the change this morning to the prometheus api client rubies
I just wanted to make sure, about 99% sure it'll pass. hahaha
I could've sworn this was the open-uri issue with StringIO, yarps

Should have been fixed by https://github.com/ManageIQ/manageiq-cross_repo/pull/57


Fix: AppliedAssembly.AdjustedElevation error, and  Single Point Featureline error

Description & motivation
Fixes #3516
Changes:
If accessing the Civil3D AppliedAssembly.AdjustedElevation property throws an error, then Speckle fails to send the whole corridor. Now defaults to sending double.NaN for this value if this occurs
If a featureline only has one point, then trying to get the spline representation of it would throw an error. Adjust code to check the featureline has more than one point, rather than more than zero.
To-do before merge:
There is no issue with the corridors now being saved in Speckle, and being able to view the corridors in the web viewer.
However, the Excel connector and the python connectors seem to
Screenshots:

Validation of changes:

Checklist:

[x] My pull request follows the guidelines in the Contributing guide?
[x] My pull request does not duplicate any other open Pull Requests for the same update/change?
[x] My commits are related to the pull request and do not amend unrelated code or documentation.
[x] My code follows a similar style to existing code.
[x] I have added appropriate tests. - N/A
[x] I have updated or added relevant documentation. - N/A

@jhdempsey86 is this in draft for a reason? We're cutting a new 2.20 version today

Sorry for the delay, but its now ready, after switchign the data type to a nullable double (double?)
Hopefully it can make it into 2.21 release

There is currently an issue with the Excel Connector whenever i try and download data from a commit that contains a corridor that has been pushed using the updated code above.
Its unclear what's happening as I can see when I select a commit that some data is downloaded, (im guessing the graphical model) but then the model is never displayed and you see the loading circle indefinitly. I dont think its related to the data or metadata because i am unable to even click the recieve button to even start downloading that data
@clairekuang do you want me to raise a separate bug report on this?

@clairekuang do you want me to raise a separate bug report on this?

Is this still the case when changing the adjustedElevation to null instead of double.NaN?
A separate issue is preferred if this is a big problem for you, and please include a link to the Speckle commit/version of the corridor you pushed with double.NaN values on that commit, or a link to the civil3d file of the corridor