FOSS build with non-free stuff on top?

Describe your suggested feature
Hi. There are many apps, such as Librera, which have a completely FOSS build to start out, and then add stuff like Play Services integration and ads for the Play Store version on top.
This allows F-Droid to package the app easily, and the developer is free to change the non-free/proprietary code to suit their purposes, whether it's for ads, tracking or analytics.
Is it possible for Mihon to go the same route? Or is the code too complicated and infeasible to adjust for this? Since there are real world examples of this, it should be possible theoretically, at least.
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.16.5.
[X] I will fill out all of the requested information in this form.

No intention to support F-Droid builds so I see no point to this

F-Droid support will require the removal of junrar. junrar is needed to support RAR files. Being able to read from rar or cbr files a core feature of the app

Maybe rewrite the archive part with https://github.com/zhanghai/libarchive-android in the future
Better performance, RAR5 support, and FOSS

F-Droid support will require the removal of junrar.

@AntsyLich You don't need to remove anything. That is the entire reason why I opened this issue. The proprietary stuff can exist as a layer on top of the FOSS code, and simply not be built for the FOSS flavour. Again, please refer to https://github.com/foobnix/LibreraReader as an example. Its Play Store version has ads, and yet it's available on F-Droid as a fully FOSS app.

From my incomplete knowledge of the codebase, I believe junrar is used to handle RAR compressed files of chapters, particularly for the local source. Using Librera's approach (again, from my cursory look through their Gradle scripts) would mean Mihon has to somehow flag the handling of RAR archives as non-fdroid, most likely making that unavailable on those releases.
At that point it would in fact be a lot easier to do what Foolbar suggested and replace it, assuming that linked library above can be slotted into Mihon with reasonably minimal effort.
I personally don't fully understand the perceived urgency of the matter either, since anyone can fork Mihon if they desire to change something about it that Mihon does not currently want to/have the time/ability to change.
I understand that you and others care about an Fdroid release even if others don't, but if push came to shove, that fork option would be on the table.

@AntsyLich You don't need to remove anything. That is the entire reason why I opened this issue. The proprietary stuff can exist as a layer on top of the FOSS code, and simply not be built for the FOSS flavour.

That's a fancy way to say I need to remove a core feature to support F-Droid

Honest question: what would be the point of having it on F-Droid? More visibility, automatic updates? The current model has both of those covered.

Regardless no intention to support a F-Droid build. If someone wants to they can make a build themselves


[Feat] global variable.scss

🚀 feature request
Relevant Package

 This feature request is for @angular/....
Description
With global variable.scss we do not need to import variable file on each component scss file. I know VAR is well supported in latest browser except IE. We might do something for IE. With this feature it will become so easy to develop dark and light mode.
Describe the solution you'd like
We can have tooling to merge variable.scss variable all over place during ng serve and ng build. Like Ionic has variable.scss to add any global variable and access everywhere.
Describe alternatives you've considered
 Have you considered any alternative solutions or workarounds?

I've been importing my global variable file into component.scss files. This works fine but breaks sourcemaps by showing styles coming from variables.scss within dev tools.
It may be a better route to fix the sourcemaps issue I mention and import your variable file per usual.

@BenRacicot It is not convenient as you will have import variable.scss on every component. We should have global variable.scss like ionic does.

Please take this up for ng 10

Discussed this issue amongst the tooling team members. Consensus is that we don't want to encourage use of global variables as a common design pattern for Angular apps. Global variables are generally considered an anti-pattern and create implicit dependencies within an application. There's a lot of literature about the negative impact of globals as a programming construct which I won't get into here. But from a concrete perspective in the Angular CLI, globals make tooling more complicated though a few means:

Globals must be included by default in a build, even though they are not directly referenced anywhere.
There is no easy way to track where a global variable came from through sourcemaps.
Building in watch mode is complicated because the global variables file does not appear in the dependency graph.
There is no easy/way to identify if/where a global variable is used. This can impact bundle size and performance, but also just general developer understanding and refactoring of the application.

Our recommendation is to simply import the styles wherever they are needed. The relationship between the "global" styles and component styles are the same, but is explicitly declared in a much more traceable fashion which is easier for developers to understand and for tooling to process. Applications are free to add a global variables file if they choose to do so, but it isn't something we want to directly support or encourage applications to do because of the negative impacts global variables can have on a codebase and the increased complexity of the infrastructure to support it.

@BenRacicot It is not convenient as you will have to import variable.scss on every component. We should have global variable.scss like ionic does.

left comment glhf


Round 10 - Food Inventory

We have noticed that whenever we have a food item in the data.csv file that is deleted (indicated by a YES in the Deleted column), then the second entry for that food item that is not deleted (indicated by a NO in the Deleted column) appears twice in the Food Inventory.  Example: Pork w/Potatoes appears twice in the Food Inventory.

@szwart Was the file you've sent me loaded in an empty database or did you load a previous file? I see that you have lot of duplicated entries with YES and NO deleted columns. If you want to update a food you don't need to delete it first. Just update the values in the existing row.

Whenever we get a new formulation of an existing food (or whenever the package size is changed), we create a new line and type YES in the deleted column for the outdated food item.
In the future, should we never have 2 identical food names even though one is deleted?
From: Paulo Vitor Magacho<EMAIL_ADDRESS>Sent: Wednesday, March 23, 2016 1:52 PM
To: NASA-Tournament-Lab/NTL-ISS-Food-Intake-Tracker<EMAIL_ADDRESS>Cc: Zwart, Sara (JSC-SK)[UNIVERSITIES SPACE RESEARCH ASSOC-DIV OF SPACE LIFE SCIENCES]<EMAIL_ADDRESS>Subject: Re: [NTL-ISS-Food-Intake-Tracker] Round 10 - Food Inventory (#111)
@szwarthttps://github.com/szwart Was the file you've sent me loaded in an empty database or did you load a previous file? I see that you have lot of duplicated entries with YES and NO deleted columns. If you want to update a food you don't need to delete it first. Just update the values in the existing row.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/NASA-Tournament-Lab/NTL-ISS-Food-Intake-Tracker/issues/111#issuecomment-200492870

@szwart When I've developed the application the idea was to update the existing row. However, it doesn't mean that having more rows related to one Food item won't work. In theory, the only restriction is that the new entry are after (below) the old entries for a given Food item. I will simulate this scenario and will give you a feedback.

I've made some tests and could not reproduce this issue. Only one item is listed.
I've loaded the file without any food deleted. There 745 food items. I then applied the sent csv file. The result count is 740 food items.

Hi @szwart, can you please confirm that I can close this ticket.


Bump zookepper operator version to 0.2.15

Bumps the version of the Zookeeper Operator to 0.2.15 and avoid a redirect hop.

please make following command
git add remove upstream git@github.com:Altinity/clickhouse-operator.git
git checkout 0.23.0
git pull upstream 0.23.0
git merge zookeeper-operator-version

and fix the conflicts


[WIP] Generalize process of adding kernel arguments

Up until now, only kickstart templates were able to inject arguments to the kernel command line, which severely limits the usefulness of customization templates.
This PR removes the kickstart-only function for retrieving kernel arguments with a generic one that implementation can override.

Changes in this PR touch some of the same files as #18809. This is why this PR is labeled as WIP for now.

@bdunne Please review.

@tadeboro Is this waiting for anything?

Thanks for your review and a fix.
This was waiting for #18809 (both commits touched the same file, so I ordered them) and I forgot to remove the WIP tag when #18809 was merged.
@miq-bot remove_label wip


Fix: sample code url failed in the non-English Get Started page.

On the non-English Get Started page, the sample code under "Using a hosted version of the p5.js library" was incorrect.
This is a version number conversion bug.
English version<EMAIL_ADDRESS>Non-English<EMAIL_ADDRESS>Changes:

The reference to "version.json" should be the path from the document root as in the Download page.

Thanks!


Add some comments to make file attribute use clear.

          1 Warning

:warning:
Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

  Generated by :no_entry_sign: Danger


Update/Add SQL2017 LocalDB

Tool information

Tool name: SQL2017 Local DB
Tool license: MS redistributeable?
Add or update? Update from SQL2016
Desired version: Latest
Approximate size:

Area for Triage:
Databases
Question, Bug, or Feature?:
Feature
Virtual environments affected

[ ] macOS 10.15
[ ] Ubuntu 16.04 LTS
[ ] Ubuntu 18.04 LTS
[ ] Ubuntu 20.04 LTS
[ ] Windows Server 2016 R2
[X] Windows Server 2019

Can this tool be installed during the build?
?
Tool installation time in runtime
?
Are you willing to submit a PR?
sure but where to start?

I am also interested in this, although in my case I would prefer SQL2019 Local DB, but just having 2017 would suffice for now.

Hello, @musmuris
As far as I know SQL Server LocalDB is a feature of SQL Server Express. Now we have SQL Server Express 2019 deployed with Windows -2019 image.
Would you please check the image version which you using for your tasks. Also may you provide link to your pipeline for detailed analyzing.
Thank you.

@andy-mishechkin  Thanks. We have automated tests that use localdb - so some flavour was installed already. But we got the error

OneTimeSetUp: Microsoft.SqlServer.Dac.DacServicesException : An error occurred during deployment plan generation. Deployment cannot continue. ----> Microsoft.Data.Tools.Schema.Sql.Deployment.DeploymentCompatibilityException : A project which specifies SQL Server 2017 as the target platform cannot be published to SQL Server 2016

so assumed it was the old one.
Image is windows-latest
I'm also trying to get the default version using:
- task: CmdLine@2
  inputs:
    script: 'sqlcmd -S "(localdb)\MSSQLLocalDB" -Q "SELECT @@VERSION;"'

but that is timing out as azure pipelines seem to be running real slow right now.

Ah there we go - added a login timeout of 60 seconds.  Default is 2016

Microsoft SQL Server 2016 (SP1) (KB3182545) - 13.0.4001.0 (X64)
Oct 28 2016 18:17:30
Copyright (c) Microsoft Corporation
Express Edition (64-bit) on Windows Server 2019 Datacenter 6.3  (Build 17763: ) (Hypervisor)

@andy-mishechkin  I would also be cool with SQL2019 local DB as well

Hello @musmuris , we wouldn't like to pre-install SQL2017 LocalDB on images.
But we have an issue to install SQL Server 2019 (and SQL2019 LocalDB too as a part): #1282
If it works for you, please upvote.

@maxim-lobanov  Yes SQL2019 works fine - and indeed that's what I've been doing as a task anyway
- task: PowerShell@2
  displayName: Install SQL 2019 Localdb
  inputs:
    targetType: 'inline'
    script: |
      Write-Host "Downloading"
      Import-Module BitsTransfer
      Start-BitsTransfer -Source https://download.microsoft.com/download/7/c/1/7c14e92e-bdcb-4f89-b7cf-93543e7112d1/SqlLocalDB.msi -Destination SqlLocalDB.msi
      Write-Host "Installing"
      Start-Process -FilePath "SqlLocalDB.msi" -Wait -ArgumentList "/qn", "/norestart", "/l*v SqlLocalDBInstall.log", "IACCEPTSQLLOCALDBLICENSETERMS=YES";
      Write-Host "Checking"
      sqlcmd -l 60 -S "(localdb)\MSSQLLocalDB" -Q "SELECT @@VERSION;"


cxxopts 2.1.2 does not compile in VS 2019 Update 2.

After updating to Visual Studio 16.2.0, cxxopts generates the following compile error:
7>...\include\cxxopts.hpp(349,39): error C2677:  binary '+': no global operator found which takes type 'const std::string' (or there is no acceptable conversion)
7>...\include\cxxopts.hpp(349,26): error C2512:  'cxxopts::OptionSpecException::OptionSpecException': no appropriate default constructor available

Can you give me some sample code that causes this, and the compile flags that you have used?

Sorry, this seems to be already fixed in 2.2.0 (with #172). I wasn't aware of the new release.


Modal not showing data - only undefined

I have the following:
<modal title="Make Payment" v-model="modelProp.value">

Make a payment

Make a payment

    <input type="text" v-model="paidAmount"/>

</modal>

And when I click my button to trigger the modal, I get the modal itself show and the background fade out however, the content shows "undefined, undefined, undefined". This was working a few days ago and the only thing I can see that has changed is that I've done a fresh npm install so have the latest build now.
This is what shows:

This the element source:

undefined undefined undefined

Any clues?

I'v just noticed from this thread: https://github.com/wffranco/vue-strap/issues/31 that it's been advised to update to the later version of vue. I'm trying this now to see if it helps my issue.

I'v just noticed from this thread: https://github.com/wffranco/vue-strap/issues/31 that it's been advised to update to the later version of vue. I'm trying this now to see if it helps my issue.

@webnoob Yeah, same thing happens with aside and input components. The whole release is broken.

@gholol Thanks for that, it appears to have fixed the issue.

@webnoob @gholol FYI I've just updated to 2.1.9 and the problem persists.

Are we sure this is a problem with Vue and not with vue-strap in that case? Has something changed in the latest vue version which requires changes within vue-strap?

I can confirm this issue is still persistent in 2.1.10 ... #41

@webnoob

Are we sure this is a problem with Vue and not with vue-strap in that case?

Yes because it works as soon as you downgrade to 2.1.6

That just means that the code in vue-strap works with the code in vue 2.1.6 not that vue has changed something that it's not intending to fix and vue-strap also needs to adhere to that change.

@gholol @webnoob see #43 #41 .. needs a new build

last build with vue 2.1.10

Still present in vue 2.3.2


API Design Discussion

Problem description
Let me kick off the technical discussions around designing this API.
Summary
DedicatedNetworks API should provide a complete solution to managing dedicated network resources in a MNOs network.
One of the functions of this API should be life-cycle management of these dedicated network resources:

reservation
monitoring the state of reserved resources
release of no longer needed resources

But reserving resources alone has limited use if no-one can benefit from them. So I think this API should also consider managing device access to these resources:

allow devices to access these resources
let devices know how they can select and access these resources

Key Questions

Are we in agreement about the expectations for this API?
Are there specific constraints or requirements to consider?

Hello, I tried to solve the issue.
This is what I did:
Added a new section 'Problem Description' to the README.md file, including the summary of the DedicatedNetworks API expectations and key questions to consider for the API design.
You can review changes in this commit: https://github.com/lattaai12/camaraproject-DedicatedNetworks-10/commit/bec405f48910cbc2dedc48a5953a9a0867f74006.

[!CAUTION]
Disclaimer: The commit was created by Latta AI and you should never copy paste this code before you check the correctness of generated code. Solution might not be complete, you should use this code as an inspiration only.

This issue was tried to solve for free by Latta AI - https://latta.ai/ourmission
If you no longer want Latta AI to attempt solving issues on your repository, you can block this account.

Hi all,
just a comment that the README.md page has a "standard" format for all APIs in the end and is not intended to reflect any discussions. Of course, while you are in design mode, the team can decide to use the README.md in this way, but in the end you will need to remove all discussion / questions when releasing the API.
Generally one or more issues like this one are used for the discussions and will also keep the history.
The discussions would lead to a set of other issues that describe what needs to be done in PRs for progressing the API.
These issues and their PRs would be then grouped in the Scope issue. I recommend to already create the Scope issue to which you can add the working issues and PRs as you go and agreed about the content of the API release.


run pydantic integration tests with lax xfail

Change Summary
We seem to be getting in a pattern where we add tests to pydantic which xfail waiting for a release of pydantic-core, this PR makes xpass lax so that these tests don't immediately go red on all pydantic-core PRs until the release.
Possibly one could argue that pydantic-core CI going red due to fixes waiting for release is a desirable thing to add pressure to release, in which case just close this.
Related issue number
N/A
Checklist

[ ] Unit tests for the changes exist
[ ] Documentation reflects the changes where applicable
[ ] Pydantic tests pass with this pydantic-core (except for expected changes)
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

please review


Preserve permissions when copying to build dirs

Replace shutil.copyfile with shutil.copy2. The former only copies file
content, while the latter also copies permissions and metadata.
The shutil.copytree method uses copy2 by default, no changes needed
there.
Signed-off-by: Adam Cmiel<EMAIL_ADDRESS>Maintainers will complete the following section

[ ] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered
[ ] JSON/YAML configuration changes are updated in the relevant schema
[ ] Changes to metadata also update the documentation for the metadata
[ ] Pull request has a link to an osbs-docs PR for user documentation updates
[ ] New feature can be disabled from a configuration file

PTAL, noticed this minor issue while playing around locally


[Proposal][5.5] Handling events only once

Add Dispatcher::once to register an event as expendable.
Once the event dispatched, call forget to remove the listener(s).

No plans to add this.

Ok, I added it to the internals channel to discuss it there then.


Turbo over Vector of DateTimes

Add example documentation for DateTime vectors

Based on #339
Problem Overview
Benchmarks showing 3x speedup with constant memory requirements

Add new example doc to Documenter build step
Add new example doc to "Manual Outline" on home page

Image previewing below.

I think this looks good.
I'd just like to see an @inbounds on the sequential version and updated benchmarks.
If you don't have AVX512, I don't expect to see too much of an improvement from @inbounds because LLVM does not handle the conversion from Int64 to Float64 well.

Benchmarks ran on my i7-4770k, which (I'm pretty sure) has AVX instructions.
By the way, what did you use for generating the GFLOPS vs. size plots (like this one)?

Benchmarks ran on my i7-4770k, which (I'm pretty sure) has AVX instructions.

Yes, AVX, FMA, and AVX2.

By the way, what did you use for generating the GFLOPS vs. size plots (like this one)?

The code is in the benchmark directory. The script to run the benchmarks is in driver.jl
plotbenchmark.jl has the code calling plot and specifying colors to be consistant.
For actually counting flops, I just did that analytically.
Integer subtraction technically isn't a floating point operation, but you could just use 2*length(data) or 3*length(data) and call it something like "OPS" (leaving off the "F").
The code running the benchmarks and recording the flops is here:
https://github.com/JuliaSIMD/LoopVectorization.jl/blob/master/benchmark/benchmarkflops.jl
but it is a mess / not something I'd recommend emulating.
More generally, you could measure GFLOPS by removing @turbo and using https://github.com/triscale-innov/GFlops.jl (noting again that it probably won't count things like integer ops).

You're welcome to make another PR to add a GFLOPS plot, but I figured there was no reason to hold this one up.
Thanks for the contribution!


Remove dev dependencies from install requirements in setup.py in all Elyra repositories

Is your feature request related to a problem? Please describe.
It appears that in some of the repositories packages are required that are only needed during development. For example flake8 is included in  setup.py in elyra-ai/kfp-notebook and setup.py in elyra-ai/airflow-notebook) . Those dev dependencies should be declared as such to avoid installation in non-development environments since they serve no purpose there.

Please make sure we replicate this in all repos

Closing this issue since both repos in question (kfp-notebook and airflow-notebook are deprecated and archived)
and flake 8 has been moved out of the setup.py in elyra root repo and into a separate makefile target. Test dependencies have been moved into the extras of the setup.py.


Change Lambda functions to Normal one to prevent compilation error on…

… Intel CPUs.

Related to #8


StorageMaps window. Filtering by 'To' field doesn't bring results if the storage name contains dash ('-')

For the above screen the 'To' field filter will bring the result for hostpath-csi-basic storage only if the user inserts:
To: hostpath or To: csi or To: basic.
Though if user filters by To: hostpath-csi-basic, no results come up

Fixed in #234


avformat: improve video_fps handling

#208

many thanks for your patch.
the PR contains a core file , this must be removed before merging.

I have tested your patch with a Timecode display:
http://www.mediacollege.com/downloads/video/timecode/clock.html
the timing is very accurate.

some warnings on OSX 10.6:
modules/avformat/avformat.c: In function ‘read_thread’:
modules/avformat/avformat.c:200: warning: ISO C90 forbids mixed declarations and code
modules/avformat/avformat.c: In function ‘alloc’:
modules/avformat/avformat.c:345: warning: implicit conversion shortens 64-bit value into a 32-bit value

Both should be fixed now. :-)

Hello Harald, your patch was merged.
Many thanks for this work, it was many people that complained about blocking sleep :)
/Alfred

Thanks for merging.


How to set guide image as keyframe like webui

I want use image as keyframe like webui

Any sample or workround?

Ooooh, that's a good one, but not utterly complicated to implement!

I want use image as keyframe like webui  TOO !!!!!

How to set keyframe, currently it seems that only one actual image can be set.


Feature request : configuration option to enable/disable core file

Hello,
I crashed InfluxDB. Here is the last line in the log file :
Killed (core dumped)

I wanted to help and provide information about the core file, but there is no core file.
$ ulimit -c
0

Feature request :
Could you provide a mechanism that would allow to configure ulimit in order to have a core file for those who want to, and to disable it for those who do not want to fill their disk with core files ?
This could be an option in /etc/default/influxdb, exactly the same as you do with OPEN_FILE_LIMIT in /usr/lib/influxdb/scripts/init.sh.

@ymettier -- why not do exactly what you say, and add the directive yourself to /etc/default/influxdb? That is what that file is for -- to allow users to customize settings. Am I missing something?

Hello,
Yes, I could write a ulimit -c unlimited in /etc/default/influxdb.
I did not think about it because I usually use /etc/default/* files to set environment vars like OPEN_FILE_LIMIT. And because you provided a mechanism for ulimit -n $OPEN_FILE_LIMIT, I thought you could provide one for ulimit -c.
That's OK for me. You can close this ticket if you think that all was said. Thanks for the answer.

Makes sense @ymettier -- just wanted to be sure I understood the request. I agree it's clearest to use a variable.


How do you make an image pop up every time you miss a note

Describe your problem here.
read the title
:devious:
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

I’m pretty sure there is like a lua file like that, just use the static notes lua file and edit the notes image so it is the one you want to use and see if you can get the image to change instead of static. I haven’t done this before so if it doesn’t work, I’m not sure how it is


[Icon Requests] YouTube, Pinterest, Clubhouse, Pixelfed & PayPal

Would love to see animated icons for YouTube, Pinterest, Clubhouse, Pixelfed and PayPal! Thank you.

I was going to post that I've added icon (added to dev branch so far, will be in main branch tomorrow), then noticed that title changed.
So YouTube is done, I'll see about others. Problem with many of those icons is there is not much to animate, but I'll try.

Thank you! It'd be nice if you could update the README with details of how users can contribute to this.

Added Pixelfed icon, but I can't think of a way to animate other icons on that list.
There are no stroke versions of those icons, recreating them as stroke icons won't work, so stroke animation can't be used. Can't think of any other way to animate them.

Thank you! It'd be nice if you could update the README with details of how users can contribute to this.

Unfortunately it is not easy. There are no tools for animating icons. I wrote a long explanation here: https://github.com/cyberalien/line-md/issues/12#issuecomment-1753026338
Current development process requires environment with apache+php (needed for scripts used for designing/previewing icons), good knowledge of SVG, knowing how to work with vectors in software that can be used for pixel perfect vector design such as Figma or Sketch.

Thanks for the details.


Release Request

Is it possible to create a release?
I'm mainly interested in #2407 (breaking api change) to be available for the integrations/terraform-provider-github.

Yes, I'll start working on it.

@gesellix - https://github.com/google/go-github/releases/tag/v46.0.0 has been released.

That's fast! Thanks a lot!


lnwallet: fix error propagation for funding messages

Previously, if an error was returned during handleSingleFunderSigs or
handleFundingCounterPartySigs, the wallet would hang waiting for
the completeChan channel to be populated. This commit adds nil returns for
the completeChan when errors are propagated.

Coverage increased (+5.0%) to 73.79% when pulling 5aa98251467b640d22c948c5c518f97d591aa63d on bryanvu:fundingerrors into<PHONE_NUMBER>65210038e5b136e3de0247d9b9c426 on lightningnetwork:master.


Fix blazemark install within docker container.

The ubuntu docker image neither contains apt-add-repository nor wget needed
to install blazemark dependencies.

I signed it!


Rename IFilter -> IFilterMetadata

Simple rename and cleanup of a few tests that had a hardcoded string.

:shipit:


actions

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.118%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
448

Relevant Lines:
476

💛  - Coveralls


re-use validator instance and compiled schema functions

Creating Ajv and compiling schema every time seems wasteful, they can be re-used.
The change is backward compatible.
It still does not create the instance until the first call.

oh, I just saw this! after I had came to the same conclusion!
I updated to use getSchema though :+1:

Another usage note is that it is better to use boolean validation result (valid) rather than errors (validate.errors) to determine that validation passed here and here. Although currently validate.errors is  always null when validation passes, it is not really documented what errors should be in success case and I was thinking a couple of times to keep the same array instance and truncate it rather than throw it away... Test cases are also written in such way that empty array would pass as well.

indeed, this was a left over from is-my-json-valid way of doing things.

77c3f12


Atomic writing?

Is it possible to make XcodeGen support atomic writes? I noticed that if the program is killed, it can end up in a weird state ( i.e. schemes may not be written but the project was ).
I'd like to write the project to a temporary file path, and then copy it over once writes are fully complete. I noticed this is non trivial due to validation in XcodeGen, which seems to check paths relative to the output directory.
Here is how I'm working around this:

Give XcodeGen a path adjacent to the project I want to write
Let that project be written
On success, move that to the actual path

Yeah should be possible to write to a temporary file and then copy over.
It would have to be a smart copy though that doesn’t remove people’s private data, but still overwrites some directories like shared schemes

That would mean XcodeGen would need to be knowledgeable about the project structure on the filesytem which isn’t great.
Just though of a better way. Copy the existing project to a temporary directory, then overwrite with generated project, and then copy back

@yonaskolb thats a really good point. We'd need to merge any user created directories into the new project. I like your idea of just copying over and overwriting the old project - this is super clean. 👍

Done here #250


[5.1] Password reset token generation simplified

Using HMAC for generating strong crypto nonces is not necessary in this scenario. This PR simplifies password reset token generation while preserving security. Closes #10112.

@taylorotwell?

Nothing is broken, so nothing to fix.

I don't really agree here. That's like saying, let's add a do while loop for no reason just to waste some cpu time, but it's not breaking the code, so let's leave it in.


remove all feature flags

This PR aims to implement changes suggested here:
https://github.com/hyperledger/aries-vcx/pull/797#pullrequestreview-1379809296.
Fixes #799

Codecov Report

Merging #818 (384ecdc) into main (036bbf9) will decrease coverage by 40.27%.
The diff coverage is n/a.

:exclamation: Current head 384ecdc differs from pull request most recent head f08b2bd. Consider uploading reports for the commit f08b2bd to get more accurate results

@@            Coverage Diff             @@
##             main    #818       +/-   ##
==========================================
- Coverage   49.06%   8.79%   -40.27%
==========================================
  Files         410     405        -5
  Lines       33501   32672      -829
  Branches     7440    7178      -262
==========================================
- Hits        16436    2873    -13563
- Misses      11949   28990    +17041
+ Partials     5116     809     -4307

Flag
Coverage Δ

unittests-aries-vcx
8.79% <ø> (-40.24%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 310 files with indirect coverage changes

hi @swaptr the libvcx testing and clippy CI jobs are failing. Please have a look. Also, I feel like it will actually be a bit more effort than this, but you'll find out as you address those CI jobs.

Closing per inactivity, if you'd like to continue, feel free to reopen PR


Dynamic scale factor updates

This is draft attemmt to support ScaleFactorChanged event.
I use target branch fix-scaling, to show only relevant changes in this branch. I'll change it to main when fix-scaling is merged.
Here i refactored CachingShaper to always include options, and not Option<FontOptions>. And removed Option from few other parts, becouse i was lost in unwraps and maps. And this is probably works as expected.
Font size is changing when i change scaling in display settings, but window size does not.
Please take a look at this, try it, maybe you have some ideas for how to make window scale too.
Please, pay close attention to any rust-specific features i try to use here, (like pointers, and dereferencing), i usually work with python, and here i write code with help from langserver, rust-compiler and google.
What kind of change does this PR introduce?

Fix
Refactor

Did this PR introduce a breaking change?

No

Here i refactored CachingShaper to always include options, and not Option.

Why did you do this? I’m not familiar with the codebase enough to know why it was an Option type in the first place, so not sure if it’s really unnecessary or not . . .

And removed Option from few other parts, becouse i was lost in unwraps and maps. And this is probably works as expected.

If they really are unnecessary, that’s fine. But in some cases having a None value is a valid thing, in which case you’ll want to leave it as Option. But I haven’t really studied the code at this point so this may not be relevant here.

Here i refactored CachingShaper to always include options, and not Option.

Why did you do this? I’m not familiar with the codebase enough to know why it was an Option type in the first place, so not sure if it’s really unnecessary or not . . .

And removed Option from few other parts, becouse i was lost in unwraps and maps. And this is probably works as expected.

If they really are unnecessary, that’s fine. But in some cases having a None value is a valid thing, in which case you’ll want to leave it as Option. But I haven’t really studied the code at this point so this may not be relevant here.

Having default values instead of Option makes a lot of code unnecessary, here is good example:
-        self.options
-            .as_ref()
-            .map(|options| options.size)
-            .unwrap_or(DEFAULT_FONT_SIZE)
-            * self.scale_factor
+        self.options.size * self.scale_factor

And if unwrapped value has optional field, that's one more level of unwraps or maps.

Just to mention this here explicitly: the fix-scaling PR "broke" HiDPI (at least macOS Retina) screens; it looks like the internal pixel doubling is applied twice -- the font is now huge! (But renders fine at that large size, hence the scare quotes around "broke".)
I assume correct handling of Retina screens is part of this PR?

@clason this PR does not touch scaling itself, only dynamic changing of scale factor.
after fix-scaling font size was expected to get bigger, becouse we converted points to pixels. What is your font size for neovide?
on linux before fix-scaling my font-size was 14 (but actually that was 11pt).
maybe on mac-os points and pixels are the same. If your font size was consistent with other apps, i'll make another PR to fix that.

Ah, I see, then this was my misconception. I don't configure Neovide at all, so it must be using some defaults (which ones?) that are less than reasonable on a HiDPI screen ;)

You could run neovide --log, and then grep 'scale' neovide_rCURRENT.log
It should look like this:
INFO [neovide::window::window_wrapper] window created (scale_factor: 1.6041666666666667, font_size: 18x37)

(that's my 11pt, multiplied by 1.3 and with some extra height added)

INFO [neovide::window::window_wrapper] window created (scale_factor: 2, font_size: 23x46)

(macOS, external monitor at 2560x1440)

I replaced all "println" with "trace", and fixed bug with incorrect scaling.
@Kethku please check how it works for you.

This works perfectly on my machine. Merging.

Thanks for pushing this forward! Your changes have made a big difference for the stability of the app


Update list of artifacts to include some of the newer ones like Core …

…while removing old deleted ones like AddressArrayUtils

Pull Request Test Coverage Report for Build 477

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.369%

Totals

Change from base Build 467:
0.0%

Covered Lines:
228

Relevant Lines:
229

💛  - Coveralls


jest.config.js

Can i use jest.config.js instead of package.json "jest" area for additional config ?
react-scripts test -- --config=jest.config.js with empty {} fails

Hey team! No workarounds for this without ejecting, eh?

No solution for this yet?

Bump, needed a solution for this. It is awesome to use a external file when you have multiple test configurations on the same project.


bsim tests: run_parallel: Allow providing tests explicitly

Add the options to provide a file with a list of tests to run with a possible TESTS_FILE variable,
or to provide the actual list of tests directly
in TESTS_LIST.
If a file is provided, comments (#) and empty lines will be skipped.

Can you provide an example for both: two tests in TEST_LIST and two tests in TEST_FILE

Can you provide an example for both: two tests in TEST_LIST and two tests in TEST_FILE

You mean just here?
$ TESTS_LIST="tests/bsim/bluetooth/ll/conn/tests_scripts/basic_conn_encrypted_split_privacy.sh tests/bsim/bluetooth/ll/conn/tests_scripts/basic_conn_split_low_lat.sh tests/bsim/bluetooth/ll/conn/tests_scripts/basic_conn_split.sh" tests/bsim/run_parallel.sh
Attempting to run 3 cases (logging to  [..]RunResults.xml)
tests/bsim/bluetooth/ll/conn/tests_scripts/basic_conn_split_low_lat.sh PASSED
tests/bsim/bluetooth/ll/conn/tests_scripts/basic_conn_split.sh PASSED
tests/bsim/bluetooth/ll/conn/tests_scripts/basic_conn_encrypted_split_privacy.sh PASSED

zephyr$ cat tests.txt
#commented line
tests/bsim/bluetooth/ll/conn/tests_scripts/basic_conn_encrypted_split_privacy.sh
tests/bsim/bluetooth/ll/conn/tests_scripts/basic_conn_split_low_lat.sh
tests/bsim/bluetooth/ll/conn/tests_scripts/basic_conn_split.sh #a comment

zephyr$ TESTS_FILE=tests.txt tests/bsim/run_parallel.sh
Attempting to run 3 cases (logging to  [..]RunResults.xml)
tests/bsim/bluetooth/ll/conn/tests_scripts/basic_conn_split.sh PASSED
tests/bsim/bluetooth/ll/conn/tests_scripts/basic_conn_split_low_lat.sh PASSED
tests/bsim/bluetooth/ll/conn/tests_scripts/basic_conn_encrypted_split_privacy.sh PASSED


Spolu link in sharing

Description
Fixes: https://github.com/dust-tt/dust/issues/3857
Add a copy link button to the Sharing dropdown in assistant builder. Only visible when editing an existing assistant.
Links to the gallery with the assistant drawer opened

Risk
N/A
Deploy Plan

deploy front

@philipperolet there is no server side props in AssistantBuilder

oh yeah :man_facepalming:


Macros autocomplete not working

Autocomplete for expectations not working. Please suggest resolutions

Do your tests compile/run? Is everything else working properly?


distinguish between dependencies redefined in same cell versus different

If redefined in same cell, detecting a stale dependency seems like a false positive from a usability perspective.
e.g.
# cell 1
a = 0

# cell 2
b = a + 1
a = 42

vs.
# cell 1
a = 0

# cell 2
b = a + 1

# cell 3
a = 42

Turns out this is already handled.


[DO NOT MERGE/DEPLOY until 00:00 05/11/2020] Add route constraint to redirect postcode checker to guidance page in production

DO NOT MERGE/DEPLOY until 00:00 05/11/2020

From 05/11/2020 - 02/12/2020 England will go into a national lockdown.
As a result we will redirect from the postcode checker to the guidance.
We have added the constraint depending on ENV so that we can bring the postcode checker back towards the end of the national lockdown.
We still want to be able to continue development work, without users being to access the postcode checker.

Original constraint adding PR!
DO NOT MERGE/DEPLOY until 00:00 05/11/2020
Will need to be merged after this PR to remove the smoke test has been deployed!
:warning: This application is Continuously Deployed: :warning:

Merged changes are automatically deployed to staging and production.

Make sure you follow the guidance for deployments before you merge.

Check your branch is being deployed in the Release app, after merging.

LGTM! 🎉
I did wonder if we should use short-url-manager for the redirect, but then reconsidered as it's possible that this redirect will only be needed for a few weeks. Also, using short-url manager would require us to unpublish and re-publish the content item at midnight on two separate occasions, which feel like a lot of hassle.
The smokey test will also need to be updated: https://github.com/alphagov/smokey/blob/7bd44a59e90aaaee8055b9b81120b8b533cd91a5/features/step_definitions/coronavirus_local_restrictions_steps.rb#L2

Thanks

LGTM! 🎉
I did wonder if we should use short-url-manager for the redirect, but then reconsidered as it's possible that this redirect will only be needed for a few weeks. Also, using short-url manager would require us to unpublish and re-publish the content item at midnight on two separate occasions, which feel like a lot of hassle.
The smokey test will also need to be updated: https://github.com/alphagov/smokey/blob/7bd44a59e90aaaee8055b9b81120b8b533cd91a5/features/step_definitions/coronavirus_local_restrictions_steps.rb#L2

thanks @leenagupte!
I made a PR for removing the smoke tests, if you could review that would be fab: https://github.com/alphagov/smokey/pull/736.
I also updated the link to the finalised guidance link so should be ready to go for midnight Thurs.


Using the same Dockerfile for two services confuses Lagoon

Using the same Dockerfile to build two different services in a Lagoon project (because reasons), results in the docker-host tagging them all from the same sha (expected)
In this case nginx and nginx-no-autogen share the same dockerfile
docker-host:/$ docker image ls | grep nginx-control
registry.<IP_ADDRESS>.nip.io:32080/ci-nginx-control-k8s/nginx/nginx                      latest    606db9f07182   18 minutes ago   134MB
ci-nginx-control-k8s-nginx-nginx-no-autogen                                               latest    606db9f07182   18 minutes ago   134MB
ci-nginx-control-k8s-nginx-nginx                                                          latest    606db9f07182   18 minutes ago   134MB
registry.<IP_ADDRESS>.nip.io:32080/ci-nginx-control-k8s/nginx/nginx-no-autogen           latest    606db9f07182   18 minutes ago   134MB

When Lagoon creates the spec.containers.image field, it adds both the images (with matching digests) - and therefore fails to pull the image (with an invalid reference).
  containers:
    - name: nginx
      image: >-
        registry.<IP_ADDRESS>.nip.io:32080/ci-nginx-control-k8s/nginx/nginx-no-autogen@sha256:6b5f6cb22a123b9dd1c38590b37ae5b9ce1a495f23b4cbaff26fd5e182ebb296

        registry.<IP_ADDRESS>.nip.io:32080/ci-nginx-control-k8s/nginx/nginx@sha256:6b5f6cb22a123b9dd1c38590b37ae5b9ce1a495f23b4cbaff26fd5e182ebb296

I Will look into this, but I would assume that the image should be retrieved by the name as well as the digest

Noting that it also occurs with differently named, but identical Dockerfiles.

After investigation, not quite so dire - this will only impact if the two images also regex to each other - i.e
registry.<IP_ADDRESS>.nip.io:32080/ci-nginx-control-k8s/nginx/nginx will also return
registry.<IP_ADDRESS>.nip.io:32080/ci-nginx-control-k8s/nginx/nginx-no-autogen
The RepoDigests returned by docker image at https://github.com/uselagoon/lagoon/blob/main/images/kubectl-build-deploy-dind/build-deploy-docker-compose.sh#L1551 show this, as the jq test is open-ended. Adding a terminating @ fixes this
docker-host:/$ docker inspect registry.<IP_ADDRESS>.nip.io:32080/ci-nginx-control-k8s/nginx/nginx:latest --format '{{json .RepoDigests}}' | jq -r ".[]|select(test(\"registry.<IP_ADDRESS>.nip.io:32080/ci-nginx-control-k8s/nginx/nginx\"))"
registry.<IP_ADDRESS>.nip.io:32080/ci-nginx-control-k8s/nginx/nginx-no-autogen@sha256:3a9f78055f1e250433f7832779743952a7651a88746ff7e1d0eea1d78c313787
registry.<IP_ADDRESS>.nip.io:32080/ci-nginx-control-k8s/nginx/nginx@sha256:3a9f78055f1e250433f7832779743952a7651a88746ff7e1d0eea1d78c313787
docker-host:/$ docker inspect registry.<IP_ADDRESS>.nip.io:32080/ci-nginx-control-k8s/nginx/nginx:latest --format '{{json .RepoDigests}}' | jq -r ".[]|select(test(\"registry.<IP_ADDRESS>.nip.io:32080/ci-nginx-control-k8s/nginx/nginx@\"))"
registry.<IP_ADDRESS>.nip.io:32080/ci-nginx-control-k8s/nginx/nginx@sha256:3a9f78055f1e250433f7832779743952a7651a88746ff7e1d0eea1d78c313787


Added content from the hidden chapter of the "old" security-blueprint.

Transfer of the "Threat Analysis & Coverage" chapter (not included in the TOC) from the "old" version of Security Blueprint to the new security blueprint.
SPEC-1539

Looks good to me.


How to trim white spaces around values?

I have a table created with values from a db and when apply tabledit, form fields appears with white spaces around values.
How can I trim those fields before submitting Ajax request?

Just in case that may help to another one with the same problem, I solved it with ondDraw hook.
 onDraw: function () {
                            $('input').each(function () {
                                $(this).val(jQuery.trim($(this).val()));
                            });
                        }


Create multiple instances

Please add this feature to be able to have multiple ModalContainer instances, or rather to have multiple ModalContainer, there are various scenarios where we need to be able to display modals in separate containers, unfortunately none of the existing libraries have such a feature.

Hello! Interesting offer. I need to think through the concept and implement some basic implementation.
I also need to think about how modal windows in different containers will be displayed.
Thanks for the idea! In this issue I will add the implementation progress.
Or maybe divide it all into a namespace, where each container displays its own.

This task will be discussed here. Discussion

@saleh-gholamian
Hello! I did a little development to implement namespace. At the moment it is at the finished draft stage. All functionality has been implemented, but I continue to test and optimize the current code.
To see the result, you need to:

Clone the current repository
Go to the issue_94 branch
npm ci
npm run serve
Go to http://localhost:8080/namespace

This example is described in here.

Docs done. https://modal.jenesius.com/guide/namespace.html
Tests done.

Now everything inside main branch. I think I will update version tomorrow to 1.10.0.
I want to test better because there are big changes involved.

I start update docs for new options: guide-methods.md. Also, add new information about getCurrentModal

@saleh-gholamian
Version: 1.10.0
Docs here.


Allow custom implementation of Promise

This fixes #11, providing support for browser with no Promise
implementation by allowing application to pass in its own implementation
of Promise.
This is done to overcome the limitation of browserify only allowing
static requires and not dynamic one (which has been used up to now in
the Node.js version)
Thank you Kevin for providing the code sample and ideas to start this off. I have also implemented the option to bypass global registration.
I removed register-shim.js and just handled the node vs. browser switching inside register.js instead of relying on the browser field. This is done to reduce the duplication between the two.
One question I have is should the naming of opts.Promise be changed to opts.impl to be more descriptive that you're passing in the actual implementation of the Promise?
One todo item is to update the README with the new opts. I can do that once the changes are approved.
/cc @kevinbeaty

@tnguyen14 This looks great on first skim.  I'll have to review in more depth, but it's on the right track.

I removed register-shim.js and just handled the node vs. browser switching inside register.js instead of relying on the browser field. This is done to reduce the duplication between the two

I think this is fine, as long as browserify and webpack ignore the calls to bare require(lib) in loadImplementation.  That is the reason I split it out in the first place, but maybe more recent versions allow this.

One question I have is should the naming of opts.Promise be changed to opts.impl to be more descriptive that you're passing in the actual implementation of the Promise?

Yeah, I was considering this too but I already used 'implementation' for the name of the implementation (e.g. 'bluebird').  I think calling it Promise might make sense so it is obvious you need to pass a Promise constructor.   I'd be up for other names, but 'implementation' has already been used.

One todo item is to update the README with the new opts. I can do that once the changes are approved.

This would be great.  Also, any idea on how to test the browser version?
Thanks so much for your help.

I think this is fine, as long as browserify and webpack ignore the calls to bare require(lib) in loadImplementation.

I just added a check to only do the loadImplementation in Node.

I think calling it Promise might make sense so it is obvious you need to pass a Promise constructor. I'd be up for other names, but 'implementation' has already been used.

I agree with you on the fact that the implementation name is already used. It was kinda the reason I was confused by it in the first name, because it actually meant the name of the implementation package, not the actual implementation. I'm okay with just keeping it Promise.

Also, any idea on how to test the browser version?

I was thinking about this as well. I was gonna add a simple test using zuul and phantom to demonstrate the use case. I'm just not familiar with Makefile, so I am not sure how to instrument it right. I'll read up on it a bit more. The other question is how to integrate it with Travis CI, i.e. whether that should be run for each of the Node environment that is being done right now? Seems unnecessary to me, but that might be the simplest solution.

I just added a check to only do the loadImplementation in Node.

Does browserify ignore the code in the if(isNode) checks?   I just don't want to include, e.g., the process shim in the browser version when it is browserified.  I think at one point, browserify threw an error because of loadImplementation, but I might be mistaken.

I was thinking about this as well. I was gonna add a simple test using zuul and phantom to demonstrate the use case.

I think it would be awesome if you used zuul and phantom for the browser tests.

The other question is how to integrate it with Travis CI,

At one point, I considered adding a separate github repository that just had browser tests so it could be managed separately.  That way the zuul and Travis stuff could be maintained in whatever way is easiest without worrying about integrating the other tests.

i.e. whether that should be run for each of the Node environment that is being done right now?

I don't expect very many changes to any-promise because of limited scope, so it would be fine this way as well.  As far as the Makefile, you should be able just to add a line for your zuul tests underneath the test target, e.g.:
test: | node_modules
	`npm bin`/mocha test/tests.js
 	 `npm bin`/zuul test/browser-tests.js

I'm not too tied to using the Makefile either.  I'd be OK with adding the commands to package.json.  What do you normally do?

I just had another idea re. testing.  Can we just add another env for zuul  and run it programatically in tests.js?  Something like:
if(process.env.ANY_PROMISE){
  // should load registration regardless
  expectedImpl = process.env.ANY_PROMISE
   if(expectedImpl === 'zuul-tests'){
        // whatever you need to run zuul
        zuul('./browser-tests.js')
        return;
   }
  require('../register')(expectedImpl)
} else {
... same as before

Does browserify ignore the code in the if(isNode) checks?

Oh you're right. I forgot to test this case. It seems like isNode is true for browserify. So I think we can do this 2 ways. (1) Add an addition check for process.browser is true, or (2) go back to the use of register-shim.js, but use some shared code to reduce the duplication, which is the original goal.

I'm not too tied to using the Makefile either. I'd be OK with adding the commands to package.json. What do you normally do?

I've been using npm run scripts in package.json mostly, and it seems to be working well and readable.
I really like the idea of setting process.env.ANY_PROMISE to zuul to run that test as well. And it doesn't require any change to the use of Makefile. I will add that next.

So I think we can do this 2 ways. (1) Add an addition check for process.browser is true, or (2) go back to the use of register-shim.js, but use some shared code to reduce the duplication

I'd rather not include the process or global shim in the browser version and keep it as small as possible.  So I think that means I prefer Option 2. I've never used the process.browser flag before though, so if using that eliminates the dead code and does not load the entire process shim, that would be OK with me too.

So it took me a while, but I think I just got some browser testing in and working. Please review and let me know.
The remaining thing will be to fix the issue with isNode as discussed above.

I abstracted register.js out to lib/index.js, and then have register.js and register-shim.js to call lib with a boolean parameter for isBrowser. I changed from isNode to isBrowser so that the default behavior is node.

This looks good.  Thank you. I tweaked it a bit so that Node.js specific stuff remains in register.js and browser specific stuff remains in register-shim.js .   That way we won't get the process or global shim or the Node specific stuff in the browserified version.  See https://github.com/kevinbeaty/any-promise/commit/8e12f95f43e4576ae2bf50a5ddff3fb263f0abc7
This is committed on my custom-promise-impl branch.  If it looks good to you, you should be able to pull  it to your branch and push again to update this PR. If that works, I think the only remaining thing would be to update documentation.  (I can do this when I publish if you would prefer, just let me know).

It looks good to me. I've done that.
Please feel free to update the documentation as you see fit.

Thanks! I'll try to get this published soon.

Published in v1.2.0


Fix a collision in function err numbers

Both EVP_F_GMAC_CTRL and EVP_F_POLY1305_CTRL use number 215, which leads to 'make update' failed.

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

CI failures are not related (seems gmac is not compiled).

Yup.  See #7572

I assume this doesn't need a grace time period, so I decide to merge this soon to make Is happier.

Pushed to master as 41eac6122a


Created container has no network access

I have a test that creates a container from an existing local image (and indeed this works, sincere apologies for previous issue, I must have been sleeping :) )
Now, that image works fine and is just an out of the box asp.net app with the Weatherforecast controller.
So, when creating creating the image and afterwards the container as follows:
docker build --pull -f Subsystem1.Api.Dockerfile -t subsystem1image .
docker run --name subsystem1  -p 8081:80 subsystem1image

I can access from the host computer in browser: http://localhost:8081//WeatherForecast, and that works fine. So, both the image and a locally created container are in great shape.
When I create now a container as in following test, the network access is failing.
I have done a compare of the docker container inspect output from both a container generated from command line and the container created via the test and indeed, the port settings are missing. In can provide the full output of the docker inspect if you want.
[Fact]
        public async Task MyOwnContainer()
        {
            var testcontainersBuilder = new TestcontainersBuilder<TestcontainersContainer>()

              .WithImage("subsystem1image")
              .WithName("subsystem1")
              .WithPortBinding(9999, 80)
              .WithWaitStrategy(Wait.UntilPortsAreAvailable(80));

           await  using (var testcontainer = testcontainersBuilder.Build())
            {
                await testcontainer.StartAsync();
                var request = WebRequest.Create("http://localhost:9999/WeatherForecast");
                var response = request.GetResponse();
                var status = ((HttpWebResponse)response).StatusCode;
                Assert.Equal(HttpStatusCode.OK, status);
                using (Stream dataStream = response.GetResponseStream())
                {
                    StreamReader reader = new StreamReader(dataStream);
                    string responseFromServer = reader.ReadToEnd();
                    string expected = "Welcome to nginx!";
                    Assert.Contains(expected, responseFromServer);
                }
            }
        }

Cool :) WithExposedPort is doing the job.
Great lib André !


Prevent document from overriding ebook-epubcheck-path & ebook-kindlegen-path

Subj, for security sake. We will probably switch to a different mechanism that doesn't pass through document for passing this settings if/when we find one.
See #277 where these attributes were introduced.

Waiting for asciidoctor/asciidoctor#3587


Schema question when performing an external materialization and registering with Glue

I'm trying to understand how schema registration works using the Glue.py plugin
You run your DBT logic e.g.
{{ config(materialized='external',location='s3://mybucket/hello, glue_register=true, ... )}}
select 1,2,3 from source
After which it it looks like the table is being materialized -> parquet file is written to s3 -> a view is built on top of this location using select * from s3://mybucket/*/*.parquet -> columns are extracted from this view -> this schema is registered in Glue.
This works neatly when all files have the same columns.
However, when adding new columns to your materialized parquet files (which Glue/Athena supports) and save those in a new partition, the next time the you run this model, it will still register the old schema (likely because of the */*.parquet of the s3 location), and seems to ignore the new schema.
Wouldn't it be better to register the schema of your last-run model? Is this a matter of reordering/adapting the macros in materializations/external.sql? Or would this be undesirable?

I thought the intended behavior was to update the schema if the columns change (viz. https://github.com/duckdb/dbt-duckdb/blob/master/dbt/adapters/duckdb/plugins/glue.py#L328 )-- so if that isn't happening sometimes, it seems like a bug?

Indeed, but the way that a view is created on top of the externally written file is a bit flawed I feel.
when duckdbt writes an external file to  s3://mybucket/year=2024/month=10/day=14.parquet using config:
{{ config(materialized='external',location='s3://mybucket, glue_register=true, partition_by...)}}
The external file will be written to the proper location, with the proper latest schema. However, when creating a view  duckdb will use the read_location at: s3://mybucket///*.parquet and pick up the first (I think, but certainly not the last)  file in the hive structure, in our case an old partition of 2018. Based off this view, the glue table will be registered with an old 2018 schema.

gotcha, that makes sense + seems worthwhile to fix


package-lock fixes for glob

Missing from #1619

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

  Generated by :no_entry_sign: dangerJS


utils/github: use Pulls API to check open pull requests on CI

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

We currently use the search API to check for duplicate pull requests,
but this is not very reliable. Our autobump.yml workflow routinely
opens duplicate pull requests because the search API often returns
incorrect results.
We can make this more reliable by using the Pulls API instead.
Unfortunately, querying the Pulls API is very slow (~10s vs less than a
second for the search API), so let's limit its usage to calls made
inside CI, which should help @BrewTestBot avoid opening duplicate PRs.
(Most recent dupes were authored by @BrewTestBot.)

Unfortunately, querying the Pulls API is very slow (~10s vs less than a
second for the search API)

Seriously? That seems a bit ridiculous for it to do that - it doesn't take 10 seconds to load the pull request web page.
Can you compare it to the GraphQL equivalent?
query($after: String) {
  repository(owner: "Homebrew", name: "homebrew-core") {
    pullRequests(states: OPEN, first: 100, after: $after) {
      edges {
        cursor
        node {
          title
        }
      }
    }
  }
}

I ask because GraphQL might be quicker given it only fetches title rather then the Rest API fetching everything (notably, adding more fields did seem to slow the GraphQL query down).

Can you compare it to the GraphQL equivalent?

Will check it out. I initially did want to use GraphQL here, but we don't have pagination set up for it. But given that I've wanted pagination elsewhere, I think we may as well see if we can add a method that handles it.

[x]  Have you followed the guidelines in our Contributing document?
[x]  Have you checked to ensure there aren't other open Pull Requests for the same change?
[x]  Have you added an explanation of what your changes do and why you'd like us to include them?
[ ]  Have you written new tests for your changes? Here's an example.

[x]  Have you successfully run brew typecheck with your changes locally?
[ ]  Have you successfully run brew tests with your changes locally?

We currently use the search API to check for duplicate pull requests, but this is not very reliable. Our autobump.yml workflow routinely opens duplicate pull requests because the search API often returns incorrect results.
We can make this more reliable by using the Pulls API instead. Unfortunately, querying the Pulls API is very slow (~10s vs less than a second for the search API), so let's limit its usage to calls made inside CI, which should help @BrewTestBot avoid opening duplicate PRs. (Most recent dupes were authored by @BrewTestBot.)

{{GREEN}}>>[lead™]


Design QA - Missing "Claim XX.XX" button on the table to see the market where you have the winnings

Should be like this:

Figma reference:
https://www.figma.com/file/wogMuUDylgOHgTEYhZ3jgp/Augur-Bet-UI?node-id=4473%3A2123

we have to update the api for this because we don't have winnings per outcome or claiming per outcome at this point

@phoebemirman we have updated the design:

The user won't be able to claim individual outcomes.
Instead of showing the button to claim, we show a message that says: "WON: $XX.XX". (Should not be clickable)
In order to claim winnings, the user must use the top green banner.

Figma reference:
https://www.figma.com/file/wogMuUDylgOHgTEYhZ3jgp/Augur-Bet-UI?node-id=4473%3A2123
Let me know if it makes sense!

working as it should be


Adds server-side request id when not present and improves error message

Codecov Report

Merging #5 into master will increase coverage by 0.13%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master       #5      +/-   ##
============================================
+ Coverage      81.6%   81.73%   +0.13%
- Complexity      199      201       +2
============================================
  Files            28       28
  Lines           973      980       +7
  Branches        127      128       +1
============================================
+ Hits            794      801       +7
  Misses          131      131
  Partials         48       48

Impacted Files
Coverage Δ
Complexity Δ

.../src/main/java/io/teris/rpc/ServiceDispatcher.java
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

.../main/java/io/teris/rpc/ServiceDispatcherImpl.java
89.84% <100%> (+0.49%)
32 <3> (+1)
:arrow_up:

...in/java/io/teris/rpc/internal/ProxyMethodUtil.java
96.46% <100%> (+0.03%)
47 <0> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00b3000...3dc89a7. Read the comment docs.


Create a breakout rooms setup and rename script.

The idea is to have a text file with the breakout rom names.
The script should then read that file and set up the breakout rooms and rename them.
For Example:
With a file containing:
Virtual Cafe 1
Virtual Cafe 2
Virtual Cafe 3
Virtual Cafe 4
Virtual Cafe 5
Leader Room

The script should create and rename 6 breakout rooms.

This is in progress. Update coming soon.

This is complete.
https://github.com/ksylvan/Zoom_OPM/assets/1226059/0595a66e-e0a7-4226-8a84-92aa26d5cce2


Add a NameFormatter to CommonGapicCodePathMapper.builder

#484
getOutputPath  should return lower_underscore path name for Ruby. For example, "ErrorReporting" should be "error_reporting".
Adding a nameFormatter allows CommonGapicCodePathMapper to choose different language specific name formatting rule.

LGTM

Current coverage is 82.83% (diff: 100%)

Merging #485 into master will increase coverage by 0.01%

@@             master       #485   diff @@
==========================================
  Files           203        203
  Lines          7714       7721     +7
  Methods           0          0
  Messages          0          0
  Branches       1018       1019     +1
==========================================
+ Hits           6389       6396     +7
  Misses         1033       1033
  Partials        292        292

Powered by Codecov. Last update db1397f...35bd6a0


additional snow module exports from Catchment

Work in progress. Do not approve.
Replaces #809, which had messed up file permissions.  Based on a new branch, which also cleans up a minor unnecessary differences with "develop" that were present in #809.
The associated code modifications add new export variables (originating from StieglitzSnow.F90) to examine the snow pack mass budget. The changes touch catchment.F90 and GEOS_CatchGridComp.F90.  There are 4 new export variables:
mltwtr: total meltwater production rate (1-dim; kg m-2 s-1)
pre: liquid water flow from snow base (1-dim; kg m-2 s-1)
fices[1-3]: layer frozen fraction (1-dim; unitless)
excs[1-3]: frozen part of water content from densification excess (1-dim; kg m-2 s-1).
TO DO:
-- code clean up, including export renaming
-- apply same to CatchCN
-- check operations
-- verify 0-diff
TO DO IN SEPARATE PULL REQUEST:
-- revisit the generation of excs, see #809 and #813
-- understand (and possibly fix) where excs is applied within catchment() and how it is partitioned
@rdkoster @lcandre2  @gmao-qliu @amfox37 @biljanaorescanin

Superseded by #834.
#813 is on track to eliminate EXCS for LAND tiles, therefore EXCS outputs are not needed.   Also, with EXCS=0, we have PRE = SMELT, which already exists as an export variable.  Finally, the MLTWTR export appears unnecessary for LAND tiles.


Licensing information

I was wondering what the licensing for this git was?
Thanks so much

We are using the MIT license - just pushed that to the repository to make it official.


docs: TYPE YOUR QUESTION HERE

Please describe the question or issue you're facing with "Ubuntu WSL documentation".

*Reported from: https://canonical-ubuntu-wsl.readthedocs-hosted.com/en/latest/

Hi @cxulo ! Was that intentional? Is there any issue you wanted to report but contents were lost along the way?

Hi @cxulo ! Was that intentional? Is there any issue you wanted to report but contents were lost along the way?

Don't click the link. The domain name is very suspicious, and it is not an official Read The Docs link. I haven't clicked it, but this issue kinda seems like some sort of advanced clickbait, I wouldn't click that link if I were you.

This is a guenuine link to the official documentation we are working on and maintained by the Canonical WSL team. There is just no alias for the moment until it's made official.


feat: add wrappers for dynamically rebased tokens

Adds wrappers inspired by those in orml-tokens (since they don't implement the MultiCurrency trait) to dynamically rebase tokens if a pairing exists in the Oracle pallet.
Closes https://github.com/interlay/interbtc/issues/926

Closes #926

I don't think it does?

Well technically we can close that issue anyway since it is not possible to support imbalanced assets using Curve v1.

It adds some, but not all, of the required code, it seems to me?

No I think it does, the requirement is that we can link assets dynamically (in the oracle pallet) to convert to some other asset and back again which it does. The only thing missing is to consume these wrappers in the runtime code.

This implementation is not correct, we need to re-balance the pool anytime we would interact with it - not just on deposit / withdrawal. See https://github.com/nutsfinance/stable-asset/blob/82577aefff91afb7c6df00d4193e4c61b4c9c1c1/lib/stable-asset/src/lib.rs#L1326

Succeeded by #1063

Succeeded by https://github.com/interlay/interbtc/pull/1063


metismenu bootstrap code

i just spent way too long debugging an issue I was having with metismenu.
It appears you have jquery method in your codebase, $.emulateTransitionEnd, which looks like it was lifted from bootstrap, perhaps version 3.3 or so. This same method exists in bootstrap 4, and has been slightly changed in the latest bootstrap 4 beta 3, which released a few days ago.
Anyway, your plugin is causing some issues because of the conflicting $.emulateTransitionEnd versions. I am able to work around this issue somewhat by loading the bootstrap later on in my build chain, so their version gets loaded last, but it still would be good to remove this issue entirely.
Is there any way you can just use a local copy of this function instead of extending jquery? I would think using a jquery function with the same name as such a popular library as bootstrap would be a good reason to switch.
Thank you for your time.

Confirmed, menus break with Bootstrap Beta 3.

I had a moment to write back about this. The main issue here is that bootstrap dropped support for IE 9, which removes the need for
https://github.com/onokumus/metismenu/blob/master/dist/metisMenu.js#L48-L53
and replaces
https://github.com/onokumus/metismenu/blob/master/dist/metisMenu.js#L73-L83
with
return {
  end: 'transitionend'
};

I'm not sure if you want metis menu to support IE 9, but if not, I would recommend making those changes. I would also recommend perhaps namespacing your $.fn.emulateTransitionEnd to something like $.fn.mmEmulateTransitionEnd (much like you've namespaced TRANSITION_END: 'mmTransitionEnd') given that bootstrap is such a hugely popular library.
Thank you for your time

https://github.com/onokumus/metismenu/pull/154

Genuis!   all good now. Thank you.


Fix #1951, Only check base filename in library info functional

Describe the contribution

Fix #1951

Just checks the base of the filename
Testing performed
Ran on linux and MCP750, passed
Expected behavior changes
Passes test
System(s) tested on

Hardware: PC and MCP750
OS: Ubuntu 18.04 and VxWorks 6.9
Versions: Bundle main + this commit

Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

CCB:2021-09-21 APPROVED


"SELECT FROM (VALUES ?).." list of args support

Binding list of arguments doesnt compile for VALUES in FROM clause
SELECT * FROM (VALUES ?) EXCEPT SELECT id FROM message; yields  '(' expected, got '?' 123    SELECT * FROM (VALUES ?) EXCEPT
Doesnt work with ? wrapped with parenthesis either
Use case: SELECT * FROM (VALUES (1), (2), (3)) EXCEPT SELECT id FROM message;
Expected: generated method with collection of ids as argument, same as for IN clause

theres no way for us to infer the type of that ?, since it can itself be multiple values. Inserts are a special case where we can infer the type for ? because its being placed in a specific column. Probably out of luck here, there might be a way to rewrite the query using an IN clause

Not sure what you mean. Grammar wise? Im no expert but if sql can interpret it, sure there is a way to infer if the ? is part of "select from values" clause, rather than insert, same as "select where in"

SELECT * FROM (VALUES ?); isnt valid sql

Forgive if im wrong but I dont believe SELECT * FROM foo WHERE id IN ? is either, hence you replace it with (?1, ??2 ..... )

correct, but whats the type of VALUES ? - VALUES (?) is valid but so is VALUES (?), (?) and VALUES (?, ?) etc.
it might be possible to do a ton of inference to figure it out but we're not going to do it as part of this library

I still dont see how is this different from "IN ?". Is it that VALUES is "overloaded" keyword?

you cant do WHERE blah IN (?), (?);

exactly, hence support the single "?" only, same sa IN

you can do FROM (VALUES (?), (?))
we're not trying to create our own dialect for kotlin convenience. If the thing you want to do can't be easily done with sql its likely you're doing the wrong things in sql. We have made two extremely exceptional cases for modifying the dialect because there was enough need for them and this is not a case where i see a significant benefit for the enormous amount of work to enable it.

Okay I didnt know you can do WHERE id IN (?, ?, ?);
Well, it is easily done by sql, and In kotlin if I were to have access do db.executeSql("raw sql")
But its not a hill I'll die on :D thanks

Faced with the same issue and at the moment the only solution is to use rawSql for this case.
@AlecStrong is there any way how we can use some sort of vararg inside VALUES as you mentioned before? As long as I can see there is no way of generating arguments in runtime


⚠ Orpheus has degraded performance

In a68fe11, Orpheus ($OPS) experienced degraded performance:

HTTP code: 502
Response time: 1456 ms

Resolved: Orpheus performance has improved in bfe7747.


refactor: use options.limit as upper limit for note-getter loop

Please read contributing guidelines and remove this line.

#7253  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on  Graphite

Benchmark results
Metrics with a significant change:

avm_simulation_time_ms (Token:mint_public): 85.4 (+36%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_30_ms
11,414
3,060 (-1%)
1,465 (+4%)
1,425
1,454 (-7%)

proof_construction_time_sha256_100_ms
43,865
11,780
5,453 (+1%)
5,439 (+1%)
5,362

proof_construction_time_poseidon_hash_ms
78.0
34.0
34.0
58.0
88.0 (-1%)

proof_construction_time_poseidon_hash_30_ms
1,516
415
201 (+1%)
225 (-2%)
267 (+1%)

proof_construction_time_poseidon_hash_100_ms
5,734
1,565
719
793 (+3%)
793 (-1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
1,412
1,412
1,412

l1_rollup_calldata_gas
9,464
9,468
9,452

l1_rollup_execution_gas
611,203
611,358
611,493

l2_block_processing_time_in_ms
754 (-1%)
1,577 (+11%)
2,696 (-2%)

l2_block_building_time_in_ms
24,686
51,076 (+3%)
97,184

l2_block_rollup_simulation_time_in_ms
24,686
51,076 (+3%)
97,184

l2_block_public_tx_process_time_in_ms
21,209
47,419 (+3%)
93,551

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
7,810 (+11%)
10,501 (+6%)

node_database_size_in_bytes
12,157,008
16,056,400

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Function
time_ms
bytecode_size_in_bytes

GasToken:_increase_public_balance
69.9 (-2%)
13,800

GasToken:set_portal
17.5 (+9%)
3,315

Token:constructor
92.2 (+1%)
23,719

FPC:constructor
62.2 (-4%)
13,653

GasToken:mint_public
51.4
10,168

Token:mint_public
:warning: 85.4 (+36%)
19,010

Token:assert_minter_and_mint
191 (-9%)
12,901

AuthRegistry:set_authorized
30.6 (+1%)
7,822

FPC:prepare_fee
158 (-19%)
15,118

Token:transfer_public
48.5 (+3%)
31,245

FPC:pay_refund
159 (-6%)
25,316

Benchmarking:increment_balance
2,720 (+4%)
15,289

Token:_increase_public_balance
56.2
14,982

FPC:pay_refund_with_shielded_rebate
145 (-24%)
26,403

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.155

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.5 (+1%)
16.8 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.610 (+2%)
0.518 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
48.8 (+1%)
75.7 (-1%)
131 (-1%)
260 (+6%)
470 (-1%)

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.499 (+1%)
0.465
0.451
0.471 (+6%)
0.439 (-1%)

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
60.3 (+1%)
111 (-1%)
183 (-1%)
391 (+10%)
692 (-1%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
109
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.511 (+1%)
0.500
0.484
0.529 (+11%)
0.474 (-1%)

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
76.4 (+5%)
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
133
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.542 (+4%)
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
85,707
670,983

Transaction size based on fee payment method
| Metric |  |
| - |  |


Add German translation

Hey everyone,
I saw that you are missing a German translation for CEI, so I did one. I hope that I put the file in the right place. It is working ingame.
While translating the pondering for the Enchanting Guide I got a little bit confused by the explanation. First, it did not say how to actually get an enchantment into the guide. This is probably something that should be explained in the second scene. Maybe it is worth noting that the enchantment is transferred to the enchanter, when the guide used for creating it has an enchantment. Also the timings are a bit off in these scenes. The first is a bit too short in my opinion and the text bubbles are overlapping there. These are just some thoughts from someone fairly new to Create but maybe you will update the English pondering translation.
Best regards!

Thank you for your translation!
Your suggestion is good! I will update the ponder in the corresponding version of Create 0.5.1

Thank you!


continous domination

The Jaccard's distance cannot reflect the distance between two product lines. Hamming distance is a better one.
continuous domination always return true or false, making one one leaf in final WHERE return.

maybe reference: http://www.sciencedirect.com/science/article/pii/S1568494611003218


Support for RavenDb

Is your feature request related to a problem? Please describe.
It would be nice to have a native support for RavenDb container.
Describe the solution you'd like
Just a support for RavenDb container.
Additional context
You can find more info about RavenDB in containters here. Hope this helps.

❤ RavenDB! That said, RavenDb does have an inmemory version which is actually a -real- version (not 'in-memory like EntityFramework which is not like a real version of a db) .. and it's really good/works.
But having a strongly typed class that supports RavenDb would be so nice because then we could create custom images based of RavenDb which could already include some seeded data and boom!!! tests would be all ready to go .. each time!

Sounds great. Either, we add the support with the current limitations of modules #493, or we use RavenDb as the first module that participates from the new structure and deployment mechanisms.
I'll finish a feature for Docker.DotNet in the next days. Then I can start with #493. It would be great if someone would like to join. The modules will benefit a lot from different opinions and perspectives.

I will start to take a look into this.


Checking constraints

With:
t :: ('True ~ 'False) => Int
t = 5

shouldNotTypeCheck t fails (i.e., the test fails with "Expected expression to not compile but it did compile"). I see why this happens (deferring the type error happens to not cause an error), but the expression does not actually compile.
I can't say I know how this could be fixed...

Hmm, I've never tried this with constraints before. Weird that it doesn't throw an a deferred type error and just lets you use it - I'm not sure what we can do to recognise that, as GHC seems to thinks it's fine code to run. Perhaps this is a GHC bug.

I'm not sure I'd consider this a bug in GHC - I can see reasons to go either way here.
I have a couple of thoughts about how one might turn these into errors - I'll try them out soon and report back.

I'm excited to see what you come up with!

Hmm, I thought Deferrable could be the solution, but the p constraints don't unify during type inference, so that won't work.


Reduce number of cockpit selinux changes

To make the cockpit proxy work alongside cockpit used to manage the appliance we need a more targeted selinux policy.
To make this easier we can make some changes here to give cockpit-ws fewer permissions to the files in our source tree.
https://bugzilla.redhat.com/show_bug.cgi?id=1779988

Ivanchuk backport details:
$ git log -1
commit 17a9b5657553565957e52df518474f2b7cf421be
Author: Joe Rafaniello<EMAIL_ADDRESS>Date:   Wed Dec 11 17:16:36 2019 -0500

    Merge pull request #19631 from carbonin/reduce_number_of_cockpit_selinux_changes

    Reduce number of cockpit selinux changes

    (cherry picked from commit 771f62075c884301a4e2d462fedbb87cc0442616)

    https://bugzilla.redhat.com/show_bug.cgi?id=1784555


Patching failed

I am encountering an issue with patching Gorilla Tag. Here is the log:
Copying APK to patched location . . .
Copying files to patch APK . . .
Checking index for unstripped libunity.so . . .
Unstripped libunity found. Downloading . . .
Copying libmain.so and libmodloader.so . . .
Patching manifest . . .
Loading manifest as AXML . . .
Adding permission android.permission.READ_EXTERNAL_STORAGE
Adding permission android.permission.WRITE_EXTERNAL_STORAGE
Adding permission android.permission.MANAGE_EXTERNAL_STORAGE
Adding debuggable flag . . .
Adding legacy external storage flag . . .
Saving manifest as AXML . . .
Adding tag . . .
Closing APK archive . . .
Signing APK (this might take a while) . . .
Signing the APK failed with zipalign enabled. Falling back to non-zipalign . . .
Patching failed!: QuestPatcher.Core.SigningException: Signed APK at C:\Users\Jack Wagner\AppData\Local\Temp\QuestPatcher\patching\patched-debugSigned.apk was missing, signing must have failed
   at QuestPatcher.Core.ApkTools.SignApk(String apkPath, Boolean useZipAlign)
   at QuestPatcher.Core.Patching.PatchingManager.PatchApp()
   at QuestPatcher.ViewModels.PatchingViewModel.StartPatching()

Please provide a full log by pressing open logs folder and uploading the file called log.log or just log here.

log.log

Alright, nice.


"Story favicons" setting not preserved across restarts

in settings, toggle the "Story favicons" setting. observe the it displays correctly after toggle.
swipe to close Glider from the window overlay and then launch again. note setting has been toggled back on.

I'm afraid I can't reproduce this behavior. Do other settings persist properly? And what app version have you experienced this issue on?

version is F-Droid 2.8.0. clearing application storage and starting over, i no longer have this issue. maybe there was a migration issue from an earlier version?

closing this issue, as i am no longer affected.


Crash Site crashes & altered guard behavior on Pelagic II

The x64 port should be considered an experimental branch. After testing it, Crash Site no longer loads (only for the x64 build), the guard behavior on Pelagic II has changed (for both x86 and x64 builds), and probably several other things are subtly, or not so subtly, incorrect. So, please, consider undoing the merging of these two branches until the x64 port is considered stable.
Crash Site message:
Fatal error: overflow when trying to preprocess a bg room, size 64 newsize 80

Every other map in the game loads without issue, including Combat Sim maps.
Pelagic II clips (pre-merge behavior Vs. post-merge behavior, both using x86 build):
Pre: https://github.com/user-attachments/assets/fa047f47-a1b7-428e-8c61-b6c53349d258
Post: https://github.com/user-attachments/assets/a57ac483-bff8-4212-8fbc-ff165cf225d7

Do not panic. Both of the issues from the OP have actually been introduced by the changes I made after merging the x64 branch, and one of them I already know how to fix, though I just reached my PC.
The cheats have actually been an issue this whole time, but they only screw up when building the game with -O2. Before that automatic builds were done with -Og.
In general, the port is unstable by nature, and it is through having people test it and find issues like this that it got this far in the first place. Consider that if I hadn't merged it into the main branch, these might have gone unnoticed for much longer.

Sorry. I guess I misunderstood the purpose of the port branch. And, I'll admit, as someone who is looking for bugs to report or things to fix, seeing these issues crop up after I updated to the latest commit freaked me out. Taking source code where the max size is always assumed to be 32-bit and converting it to 64-bit is usually a perilous endeavor, and I assumed they were caused by that. I'll update the title accordingly.

Taking source code where the max size is always assumed to be 32-bit and converting it to 64-bit is usually a perilous endeavor

It very much is, and I think we'll see more issues related to it, though probably not very big ones. The port-x64 branch actually was tested by a few people for a pretty long time before I got around to merging it. The PR was opened around a month ago.
I have introduced changes that led to breakage and behavior mismatch before. This is kind of why the port still has the "it's unstable" disclaimer in the README still and I'm not doing actual stable releases.

The Pelagic II thing is now "fixed" via rolling back the changes I did to one of the files. Wonder if there's anything else.

I think I'll close this for now since the issues mentioned in the OP are fixed. If you find any other discrepancies on 64-bit versions of the port, please make new issues for them.


Uploaded the required screenshot

Added the required screenshot please check.

Create a new PR

Ok sorry for inconvenience caused


pmackin-OWLS-72195

OWLS-72195 - Log the domainUID that is currently being used by a fiber.   Handle the case where the DomainPresenceInfo is null.

Looks good to me.
Have you also looked into if it is possible to leverage the "key" as Ryan suggested in the JIRA, "The FiberGate knows the domainUID when it starts a Fiber (it's the "key") and the LoggingFormatter already acquires the Fiber."
Were you able to find any other "scopes fields" that might be useful to add to the log entries? Thanks

I didn't seem anything obvious and Derek suggested that i just get this in.  I can investigate this for future work.


Do not load Logs of Tasks in Tasks overview

this is the graphql request that is ran for the tasks tab:
query getEnvironment($openshiftProjectName: String!) {
  environmentByOpenshiftProjectName(openshiftProjectName: $openshiftProjectName) {
    id
    name
    created
    updated
    deployType
    environmentType
    routes
    openshiftProjectName
    project {
      name
      __typename
    }
    services {
      id
      name
      __typename
    }
    tasks {
      id
      name
      status
      created
      started
      completed
      remoteId
      command
      service
      logs
      files {
        id
        filename
        download
        __typename
      }
      __typename
    }
    __typename
  }
}

it includes the  logs which are loaded from elasticsearch and can make the request very slow.
as the logs are not used in the overview we should not load the logs in the overview

This is slightly fixed in https://github.com/amazeeio/lagoon/pull/976 but not fully. The tasks page does not load the logs anymore, but the task page still has to load every single task and all the logs and then just display one of them.
To fully fix this an addition will need to be made to the api to support selecting only one task from an environment (similar to deployments).

Would it be possible to split up the query for the different sections of the dashboard? For example the header can query for the environment and project details to populate that? Then the tasks query could be simplified even more? I haven't looked at the setup for the project so I am just throwing out ideas at this point.
query getEnvironmentTasks($openshiftProjectName: String!) {
  environmentTasksByOpenshiftProjectName(openshiftProjectName: $openshiftProjectName) {
    tasks {
      id
      name
      status
      created
      started
      completed
      remoteId
      command
      service
    }
    __typename
  }
}

@HurricaneInteractive yes, but that doesn't reduce the overall amount of data be requested and delivered.
Like I said in an earlier comment, a change to the api is required and made in #993.


[14.0] ISPN-15041 Preserve stack traces to caller to simplify debugging

This backports this fix from the main branch to 14.x
The original PR is #11111
(cherry picked from commit 8c0d352b46babc51c571b45b5770d23656b42ea5)

Hi @jabolina - this packports the PR from the main branch to the 14.x branch, as in the Keycloak project this the version were're using at the moment.
I'd be happy if you could review and merge this as you've been merging also the PR to main. Thanks!

Hello, @ahus1. Can you also pick c761019?

@ahus1 Yeah, we squash commits from the same person. However, I wanted to keep your contribution so I only added my own commit on top.

Thanks @ahus1, integrated into 14.0.x.


Fix typo in test-aspnet-core-services-web-apps.md

Summary
Change the indefinite article "a" to the conjunction "and."
Add a comma before the conjunction.
Fixes #Issue_Number (if available)

Hey @zakaria-c , while reviewing this PR with @nishanil when we read the sentence again we realized that there is scope of further improvement. So we rephrased it likes this - "While unit and integration tests are organized in a test folder within the microservice project, application and load tests are managed separately under the root folder, as shown in Figure 6-25". Thoughts ?
Thank you.

Clearer and simpler! I'll update it right away.

You're very welcome


Prefer direct solve over multiplication with explicit inverse

The evaluation of the Jacobian entails computing -2 X (X^T X + \delta I)^{-1}, which is currently done by forming the explict inverse of X^T X + \delta I)^{-1}, and multiplying that from the right to X.  But typically you'd get a more accurate result by directly solving the equivalent linear system.  This is the tiny proposal here.
The expected effect is that more accurate Jacobians lead to fewer iterations in the interior method that uses it.  I verified that the IPOPT iteration count drops by 15% (mean over ten different starting points) on an example + data set provided by folks at BASF, but you have more data than I to test it.

I get to similar results with your suggested changes. Thanks a lot for your contribution! :)