Alternate implementation for Solver Handler Scene Object attachment

Overview
This implementation enables the Mixed Reality manager to keep a track of any Scene Objects created in the scene by devices and makes them available for Scene components.
This is a preliminary check-in for review
It's critical that devices are not polled or "part" of a scene.  The Current MixedRealityControllerVisualizer is a representation of a controller in a scene, the GameObject of the controller.
To this the device layer appends the SourcePoseController to enable input events from the controller to manipulate the Controller Game object.
This implementation has enabled the Visualizer to register it's existence with the MixedRealityManager, so that other scripts can easily query for the gameobjects for the controllers in the scene.  Scene objects interacting with scene objects.
Note No parts of the device layer have been modified for this implementation.
Please review and comment where further changes are needed,

Additionally, this solves issue #2790

Changes

Adds new Scene Object Registration system to the Mixed Reality manager (currently "limited to" MotionControllerVisualizers)
Adds functionality to the SolverHandler to grab the correct handed controller from the Scene Object Registration
Added the ISourceStatehandler implementation to the SolverHandler, so it can refresh the solver when a controller is attached / detached.

TODO
This is a preliminary implementation, Ideally the Scene Object Registry should be able to handle any game object, but this requires a fair amount of additional design.
Registry notes
This brings the registry count up to 3, the distinct registries and their purpose are as follows:

Core manager Registry - Unique registry for managers where there can only ever ne a single instance in operation (e.g. InputSystem, BoundarySystem). Each manager receives all Unity events coordinated through the MR Manager.
Component Registry - Emulates the managers registry, except allows multiple components to be added.  Each manager receives all Unity events coordinated through the MR Manager.
Scene Object Registry - List of referencable Scene objects, to avoid use of "FindObjectOfType" lookups.  Used for regularly queries scene objects critical to a project (e.g. VR Controllers represented in a scene)

It's critical that devices are not polled or "part" of a scene.

Again, why is this critical? Not because of your definition of what a device is, but what actual effect does this have on an application or the Toolkit?

It's critical that devices are not polled or "part" of a scene.

Again, why is this critical? Not because of your definition of what a device is, but what actual effect does this have on an application or the Toolkit?

Good question. I'm not so sure about the polling being crucial as we already give devs the ability to get the current info from the controller at any time, so we're not preventing something like this from happening, but it is device specific, so you'll need a concrete type to poll from, which breaks cross platform support, and why we encourage the use of getting data from the input system via IMixedRealityControllerPoseSynchronizer.
As for not being part of the scene? That's because the device layer is Encapsulated. All it knows about is the device and the data being read from the device. The "Scene" part of the controller is the IMixedRealityControllerPoseSynchronizer which is being driven by the IMixedRealityController.
We're separating our concerns here and making sure we're sticking to good OOP design.

This has already been given as feedback that it adds an unnecessary requirement (as in, there are ways to do this without adding a script; see: HTK)

For one, this isn't the HTK, so we need to stop trying to compare it. Second, where is this feedback? Third, without the IMixedRealityControllerPoseSynchronizer you won't know anything about the controller unless you implement it. So yes, it's a requirement for scene based controllers, as it's the representation of that controller.
That being said, this doesn't mean it's a requirement for all tracked objects by the SolverHandler.

but it is device specific, so you'll need a concrete type to poll from, which breaks cross platform support

I do not poll from any concrete type. I only call methods from the base interfaces, and this has been tested and works completely cross platform.

For one, this isn't the HTK, so we need to stop trying to compare it.

No, but why would we make things worse? Adding a requirement to add a script to an object to obtain the same result as the HTK is objectively not as good.

Second, where is this feedback?

I've heard it internally, and you also told me there was confusion at the Summit when arbitrary prefabs didn't "just work".

Second, where is this feedback?

And you're right, it should have been filed as an issue. I've been working on a proposal for a real controller visualization solution and was going to bring it up at that time.

I do not poll from any concrete type. I only call methods from the base interfaces, and this has been tested and works completely cross platform.

I know you don't I was agreeing with you 😅 That was more or less for @SimonDarksideJ.

No, but why would we make things worse?

Seems rather subjective, but I agree we should try to reach similar results to the the HTK in regards to feature parity.

Adding a requirement to add a script to an object to obtain the same result

I don't understand why this is objectively a bad idea, as we've broken out requirements and responsibilities of the scripts to be more encapsulated and do single task. That's just good OOP design.

I don't understand why this is objectively a bad idea

Think about it from the point of view of a consumer of this product: a developer working on their app.
In the HTK, they dragged a prefab somewhere and it became the controller model, tracked with the controller, and worked.
In the MRTK, if they do the exact same thing, nothing happens. They now have to add a script onto their prefab to obtain the same results. That prefab might be used elsewhere and shouldn't be modified. They're also now doing an extra step on top of the HTK steps to obtain the same result.

That's because you need to use the configuration profile. You can't just add these things to the scene, as the Mixed Reality Manager handles all of that. (It's how we were able to get away from using Singletons).
That's just part of the documentation we're currently writing up.

Also, that's what the [RequireComponent(type)] attribute is for.

What problem does this solve in this scenario?

That's because you need to use the configuration profile. You can't just add these things to the scene

Yes, they did not just drag them into the scene in the HTK either. In both cases, the prefabs are being set in the inspector.

In the HTK, they dragged a prefab somewhere and it became the controller model, tracked with the controller, and worked.

I think most of the frustration here is that this entire system isn't like the HTK at all, sans the input system events. I will reiterate again, this is not the HTK.

They're also now doing an extra step on top of the HTK steps to obtain the same result.

I don't see it that way at all.
To setup a controller visualization you just need to create your prefab, attach the visualization script (which isn't even supply fleshed out yet, so maybe they also assign all their transforms who knows) and then assign their controller prefab in the controller mapping profile. No adding anything to your scene.

Can you simply list out your issues with the proposal @keveleigh ?
It has achieve all the requirements set out from your taks and even addressed @davidkline-ms 's issue. As well as starting an extensible registration system for managing any scene object.
All without compromising the base architecture and dirtying the Device layer with runtime / scene data.

Aside from the comments I left in the review, I don't have any concerns with this code itself, but I still feel pretty vague about how someone actually uses this stuff in Unity.
A particular mystery to me comes up in this line:
foreach (MixedRealityControllerVisualizer controller in MixedRealityManager.Instance.MixedRealitySceneObjects
Where do MixedRealityControllerVisualizers come from? How is MixedRealityManager.Instance.MixedRealitySceneObjects populated? If this is the implementation we go with, I want that list to be automatically populated by the MixedRealityManager or something.

Where do MixedRealityControllerVisualizers come from? How is MixedRealityManager.Instance.MixedRealitySceneObjects populated? If this is the implementation we go with, I want that list to be automatically populated by the MixedRealityManager or something.

That's what I want to address with https://github.com/Microsoft/MixedRealityToolkit-Unity/issues/2799

We should consider this user story as a requirement for this work:
As a content creator, I can get a solver working with not more steps than this:

Import MRTK into a fresh project.
Run MRTK Configure in my scene.
Add a cube to the scene.
Apply a Radial Solver to the cube.
In the Solver Handler (which has been added for me), I set the tracked object to Motion Controller Right
In the Radial Solver I set the min distance to 0.2, and the max distance to 0.7
I hit play and the cube is following my motion controller in the scene

I still feel pretty vague about how someone actually uses this stuff in Unity

That's probably my main concern as well (though for a slightly different reason, I think). This seems like a generic answer searching for additional problems to solve. What other scenario would use this new scene object registry? It seems like, if we do visualization right, we could obtain the same information by asking the visualization system explicitly for a right/left controller instead of needing to iterate through a list filled with some number of objects (that aren't all controller visualizations), casting them all to find something that's both a controller visualization and the correct handedness.

That's what I want to address with #2799

Cool, I'm looking forward to seeing that PR, I think it will help clarify a lot. :)

It seems like, if we do visualization right, we could obtain the same information by asking the visualization system explicitly for a right/left controller instead of needing to iterate through a list filled with some number of objects (that aren't all controller visualizations), casting them all to find something that's both a controller visualization and the correct handedness.

Now that you mention that, it definitely feels like a "Gimme The Left Controller" utility function that some manager should provide rather than being in this class, rather than writing it in every User Abstraction class that needs access to controllers. (Whether that function loops over a list of everything or keeps controllers separate is a different question that I have less opinions on.)

Given the discussions, I agree that #2799 should be resolved before this is merged.
We seem to have consensus on the pattern but need a better visualization manager.  It may be even possible to drop the SceneObject registry if the visualizer also offers a way to query for connected controllers/hands.
Then the Solver update would be redirected / updated to use the new Vizualizer logic

Then the Solver update would be redirected / updated to use the new Vizualizer logic

Since #2799 is still a bit off, how do you guys feel about merging in https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/2784 (or whichever of the proposed implementations) with the understanding that it's just temporary until the Visualizer logic is done? I and other members of my team would like to start using Solvers in MRTK. :)

Well, this PR is more in line with the direction that seems to have the most agreement, although I'd like some more feedback on the general approach.
Understand you need solvers asap (although I have raised another PR - #2798 ,  to update Solvers to a more MRTK configurable approach, which would also be good to get feedback on) so we do need to get a  general consensus.

I'm not in favor of merging #2784

I'll have #2799 finished tonight

I'll have #2799 finished tonight

Sweet, thank you for prioritizing it. :)

I've been pitching in and giving @StephenHodgson a hard time with a PR on his PR
https://github.com/StephenHodgson/MixedRealityToolkit-Unity/pull/32
Feel free to jump in and comment @Ecnassianer , It'll help to carve the way forward

Sorry, I'm blocking a big initiative and need to crunch on some project code today. I won't be able to look at this until tomorrow. :(

Closing as implementation is out of date with current plans

We spoke about this in another thread which I can't find at the moment, but can we change the name from "Visualizer" to something else. This PR seems like the place to make that change. Here are some things that I think would more clearly reveal the purpose of these classes:
SceneRepresentation (i.e, ControllerSceneRepresentation or  ControllerRepresentation)
DeviceAvatar (i.e, ControllerDeviceAvatar)
SceneObject
TrackingProxy
TrackedProxy
MixedRealityProxy
RealityProxy
Let me know if you want a recap of why I think Visualizer is a misleading name.


Add all remaining triggers

Later need to add type-safe arguments for the remaining triggers, especially an enum for "types", but that will be backward compatible.
Change the way triggers are transformed to yaml, so that it can be used by the script-generator to transform to Kotlin
Add @Serializable so that it can be used later by the script-generator

There are several things mixed in this PR, let's start with having a separate PR for adding the triggers, without adding serialization stuff or adjusting custom YAML serialization logic.

No problem for removing the kotlinx.serialization stuff,
but I would rather not implement YAML serialization for 30 new wrappers just to revert it later because there is a better way that works both for serialization do YAML and Kotlin :)

kotlinx.serialization removed from library module


Separate kernel in modules

It s necessary to separate the kernel in some modules like: queue, publish/subscribe, scheduler, etc.

The kernel has been separated in modules, now with external list implementation


Onboarding for Calgary (Alberta joint with Edmonton)

Application submitted 2021-09-30T19:48:25.000Z by Luis Berumen

[ ] Location email access
[ ] Set up event page

if new location

[ ] Set up new location page
[ ] Set up new location email address

Welcome kit sent to Andrew and Luis


Eliminate resource quota usage

The API server is now able to support updating a resource's status in a separate operation from a normal update.
As a result, I am now able to eliminate ResourceQuotaUsage from the API since it's sole purpose was to allow the quota controller to update the ResourceQuota.Status values.
The 1st commit fixes a problem exposed in the current code as part of this work that v1beta1/2 did not support labels on a ResourceQuota.
The 2nd commit eliminates ResourceQuotaUsage, and updates the code to now just perform a ResourceQuota.Status update directly.
/cc @smarterclayton @erictune

LGTM

Love to see deletes.

I was happy to get rid of it as well
Sent from my iPhone

On Mar 13, 2015, at 7:11 PM, Eric Tune<EMAIL_ADDRESS>wrote:
Love to see deletes.
—
Reply to this email directly or view it on GitHub.


Need a better way of managing input, among other things

This is really awesome, however it's a bit annoying having to work around input methods.  Exposing more functionality would be great- both in C++ and some blueprint nodes.  I'm able to toggle ImGui on with a key press, but after that I have to use the console to toggle the input off, then I can use my own key shortcut to toggle ImGui display.
What I'm doing is:

Toggling a debug boolean with a key press
Checking if debug mode is on, and if so, draw ImGui
Trying to toggle debug boolean off, and hide ImGui (this is where things fall apart)

Wrapping up a lot of ImGui in easily accessible C++ and BP nodes would be awesome.  If I weren't wrapped up a dozen other projects, I'd probably tackle it myself :wink:
So, this is more of an issue plus feature request!  Again, this is awesome to see in UE and quite welcome.  A bit more polish and it would be amazing :gem:

I believe that when I looked at the issue the first time I misunderstood the real problem here. June updates (from 5968c3ce and up) introduced a few improvements to input handling:

There is an ImGui Input Handler class. It is not 'a true handler' but a class that defines rules how input should be handled, but in a limited scope it also allows to add own handling code.
Default handler implementation consumes most of the keyboard events, with a few exceptions to allow console activation, stopping editor play session and switching ImGui input state.
Console activation and stop play session keys are read from configuration, so they support custom project settings.
Keyboard shortcut for switch ImGui input mode can and need to be defined in ImGui project settings.

It would be possible to add more rules and settings (like defining default behaviour for input consumption or providing a list of ignored key events etc.), but with already a few different solution in Unreal it is not always possible to provide a general solutions that works in all different cases. From that reason there is only a few basic rules and if that is not enough for particular project, then custom handler can be implemented and set in ImGui project settings.
I might revisit default implementation later but I think that with above changes it should be possible to customize input to own preferences.
Blueprint is a different topic. One problem that I had was that it was not possible or easy to define blueprint functions that would be removed in shipping builds (and since this is a debug tool that should be possible). This has been fixed in 4.17 or 4.18, if I remember right, but I still need to decide whether that should be in the same or separate module etc. Also while it would be easy enough to follow C++ patter and require begin/end nodes, in blueprint it would be better to have something like for-loop node. This is duly noted but I won't have time to look at this now.
Closing topic because I think that the title problem is now solved.


Reuse Module Resolutions Within Project References During Initial Program Creation

Related to #40356 and Build-Free Editing (#32028)
tsserver creates a Program for each ConfiguredProject. If a project contains project references, createProgram will traverse the source files of those referenced projects recursively.
When multiple projects are loaded, shared dependencies will have their module resolutions re-traversed. I think we can relax that behavior a bit to gain some performance improvements. The assumption is that the SourceFile.resolvedModules map will be kept up-to-date by other Program objects running in tsserver by the time a new Program is created. If this assumption is false, this PR should be rejected.
I recommend reviewing commit by commit. The first 2 commits don't change any behavior and are small refactors to make the actual change easier to fit in.
Thanks to whoever reviews this. I'm sure changes will be requested.
Performance Differences
For an extremely contrived test case, this improved initial load time of a project by 72.21%. See ts-module-resolution-cache-testing for the test repo.  I didn't average them over multiple runs.
Further Improvements

This PR only applies to initial program creation and not program reuse. Non-trivial refactoring in tryReuseStructureFromOldProgram would be required to make the later happen.
We currently recreate the structure of a program entirely when any project reference tsconfig changes. I wonder if it's possible to track which project reference's config changed and only update resolutions of affected source files. It's tricky because affected files would be both files within the project reference and files that import from it.

Concept is great but this is not the implementation we are looking at. I am moving resolvedModules away from sourceFile into program to ensure that incremental builder will be able to use that. As part of that i am doing changes to get cached resolution from projectReferences if available and that achieves exactly same thing as this PR but more generically that concept can be used in multiple places like tsserver, compiling etc.

Hey Sheetal, thanks for looking at this. I agree. This PR was meant to be a v1 of what this would look like. An alternative version that's more aware of project references would definitely be better from a maintainability perspective.
Let me know if you'd like help! I'm not sure what my availability will look like week by week but we can talk about that if you want my involvement. If not I trust you and the team will do a fanstatic job like always.

@sheetalkamat Is there a place the improved implementation is being tracked? At the moment loading all projects individually takes significantly longer than loading a single project with all files combined.
I was using "Find All References" today and saw it trigger a recursive project load that hanged TS Server for 10+ minutes.
I played with 1 tsconfig file that includes all TypeScript files. That loaded in ~1 minute.

@sheetalkamat Are there any updates on when your cached resolution updates will be ready? My team is very excited for these performance improvements.

@sheetalkamat Are there any updates on when your cached resolution updates will be ready? My team is very excited for these performance improvements.

It is not scheduled for 4.2 #41004 is tracking the work

It is not scheduled for 4.2 #41004 is tracking the work


add multiply/divide functions

It will probably look something like this:
export function multiply(
  image: Image,
  value: number,
  options: MultiplyOptions = {},
) {
  const {
    channels = new Array(image.components).fill(0).map((value, index) => index),
  } = options;
  if (channels.length === 0) {
    for (let i = 0; i < image.channels; i++) {
      channels.push(i);
    }
  }
  validateChannels(channels, image);

  for (let channel = 0; channel < channels.length; channel++) {
    for (let row = 0; row < image.height; row++) {
      for (let column = 0; column < image.width; column++) {
        const newIntensity =
          image.getValue(column, row, channels[channel]) * value;
        image.setClampedValue(column, row, channel, newIntensity);
      }
    }
  }
}

For division it will be the same but with a different sign and additional check for value === 0. Also by default alpha channel is not multiplied. @stropitek WDYT?

If the channel option is explicitly set to an empty array, I would expect it to just return the input image or throw. I would return the input image. If passed directly by the user, that was probably unintentional and a mistake, but that channel option could also be derived / computed.
Wouldn't it make sense to provide the usual out option to this method and by default, to create a new image instead of modifying the input?

export function multiply(
  image: Image,
  value: number,
  options: MultiplyOptions = {},
) {
  const {
    channels = new Array(image.components).fill(0).map((value, index) => index),
  } = options;
  validateChannels(channels, image);

  const newImage = getOutputImage(image, options, { clone: true });
  if (channels.length === 0) {
    return newImage;
  }
  for (let channel = 0; channel < channels.length; channel++) {
    for (let row = 0; row < newImage.height; row++) {
      for (let column = 0; column < newImage.width; column++) {
        const newIntensity =
          newImage.getValue(column, row, channels[channel]) * value;
        newImage.setClampedValue(column, row, channel, newIntensity);
      }
    }
  }
  return newImage;
}

I don't want to review code in an issue, PRs are made for that so please open one.


Multiple buttons

Now able to inject multiple buttons. locals.action can either contain an array of objects or a single object. README.md and THEME.md have been updated to reflect this addition.

@eladnava made coding styling changes. Let me know if there's anything else!

@collnwalkr I just thought of something -- instead of converting the action to an array if it is an object in every theme file, how about we simply implement this once within index.js?
Somewhere along these lines:
https://github.com/eladnava/mailgen/blob/461ab1c84ad99488161deb2d71457f2b547e4f56/index.js#L121
See how we already do something similar for intro and outro?
I'm actually thinking we can change convertToArrayIfString to convertToArray which will convert any object it receives into an array (if it isn't already) using the logic you implemented in the templates. It shouldn't break anything since intro and outro are strings anyway, and it's actually safer this way.
You can then use this function to convert body.action to an array.

@eladnava That's a great idea! I have made those changes and have committed those changes.

@eladnava those were some great comments! let me know if there's anything else I can change/update.

Good catch. Those changes have been made!

@collnwalkr Thank you so much for your hard work and dedication on this PR! This was definitely not an easy PR, thanks for sticking with it and bearing with my comments. 😄

Published v1.0.27 to npm 👍

@eladnava no worries! I really appreciate it when people are particular with code style. It helps me grow and learn. This is a cool project you have going on here. Glad I had the opportunity to help!

Thanks so much for your kind words! 😄  Let me know if you'd like to work on anything else, we currently have 2 more outstanding issues that could use your crafty hands! 👍

Published this feature in v2.0.0.


Update fabric-features.md

Updating the feature list with AI Skills and some touch ups
Thank you for contributing to Microsoft Fabric documentation
Fill out these items before submitting your pull request:
If you are working internally at Microsoft:
Provide a link to an Azure DevOps Boards work item that tracks this feature/update.

Who is your primary Skilling team contact? @mention them individually tag them and let them review the PR before signing off.

For internal Microsoft contributors, check off these quality control items as you go

[ ] 1. Check the Acrolinx report: Make sure your Acrolinx Total score is above 80 minimum (higher is better) and with no spelling issues. Acrolinx ensures we are providing consistent terminology and using an appropriate voice and tone, and helps with localization.

[ ] 2. Successful build with no warnings or suggestions: Review the build status to make sure all files are green (Succeeded).

[ ] 3. Preview the pages:: Click each Preview URL link to view the rendered HTML pages on the review.learn.microsoft.com site to check the formatting and alignment of the page. Scan the page for overall formatting, and look at the parts you edited in detail.

[ ] 4. Check the Table of Contents: If you are adding a new markdown file, make sure it is linked from the table of contents.

[ ] 5. #sign-off to request PR review and merge: Once the pull request is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the Pull Request. If you need to cancel that sign-off, type #hold-off instead. Signing off means the document can be published at any time. Note, this is a formatting and standards review, not a technical review.

Merge and publish

After you #sign-off, there is a separate PR Review team that will review the PR and describe any necessary feedback before merging.
The review team will use the comments section in the PR to provide feedback if changes are needed. Address any blocking issues and sign off again to request another review.
Once all feedback is resolved, you can #sign-off again. The PR Review team reviews and merges the pull request into the specified branch (usually the main branch or a release- branch).
From the main branch, the change is merged into the live branch several times a day to publish it to the public learn.microsoft.com site.

@KesemSharabi
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

@Jonathan-Garriss,
The article's author has signed off on these changes, but I see that there's unresolved feedback that you might want to address. Can you confirm that this PR is ready to merge?

@Jonathan-Garriss - I added the * footnote and fixed the link to the concept-ai-skill.md article ... if this is ready to go, add a #sign-off or at-mention me in a comment. thanks.

@Jonathan-Garriss - it became too complicated to explain how to make the changes so I made them myself in the private repo, PR 6412.
#please-close


HBASE-26045 Master control the global throughput of all compaction servers

Compaction servers report compaction tasks to  master via heartbeat report.
The report response has throughput control message and compaction server use this message to adjust compaction throughtput.
We can set total throughtput of all compaction servers via hbase shell commands.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  6s
https://github.com/apache/hbase/pull/3690 does not apply to HBASE-25714. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/3690

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  4s
https://github.com/apache/hbase/pull/3690 does not apply to HBASE-25714. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/3690

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  5s
https://github.com/apache/hbase/pull/3690 does not apply to HBASE-25714. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/3690

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 22s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 13s
HBASE-25714 passed

+1 :green_heart:
compile
7m  5s
HBASE-25714 passed

+1 :green_heart:
checkstyle
2m 48s
HBASE-25714 passed

+1 :green_heart:
spotbugs
8m 55s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  2s
the patch passed

+1 :green_heart:
compile
7m  7s
the patch passed

+1 :green_heart:
cc
7m  7s
the patch passed

+1 :green_heart:
javac
7m  7s
the patch passed

-0 :warning:
checkstyle
0m 27s
hbase-client: The patch generated 1 new + 38 unchanged - 0 fixed = 39 total (was 38)

-0 :warning:
checkstyle
1m 14s
hbase-server: The patch generated 8 new + 210 unchanged - 0 fixed = 218 total (was 210)

-0 :warning:
rubocop
0m 22s
The patch generated 20 new + 656 unchanged - 0 fixed = 676 total (was 656)

-0 :warning:
whitespace
0m  0s
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
hadoopcheck
19m 57s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
2m 56s
the patch passed

+1 :green_heart:
spotbugs
9m 48s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 54s
The patch does not generate ASF License warnings.

82m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux 79d0f4fecc19 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / 20b7c8b286

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt

whitespace
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/2/artifact/yetus-general-check/output/whitespace-eol.txt

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 29s
HBASE-25714 passed

+1 :green_heart:
compile
3m 41s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 28s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 12s
the patch passed

+1 :green_heart:
compile
3m 38s
the patch passed

+1 :green_heart:
javac
3m 38s
the patch passed

+1 :green_heart:
shadedjars
7m 48s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 59s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 18s
hbase-client in the patch passed.

+1 :green_heart:
unit
143m 16s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 42s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m  8s
hbase-shell in the patch passed.

198m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0717b2febc08 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / 20b7c8b286

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/2/testReport/

Max. process+thread count
4403 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 50s
HBASE-25714 passed

+1 :green_heart:
compile
3m  9s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  1s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 35s
the patch passed

+1 :green_heart:
compile
3m  7s
the patch passed

+1 :green_heart:
javac
3m  7s
the patch passed

+1 :green_heart:
shadedjars
7m 43s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 46s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 12s
hbase-client in the patch passed.

+1 :green_heart:
unit
149m 41s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 42s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 16s
hbase-shell in the patch passed.

201m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d13d2210b833 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / 20b7c8b286

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/2/testReport/

Max. process+thread count
5123 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 10s
HBASE-25714 passed

+1 :green_heart:
compile
3m 40s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 23s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 13s
the patch passed

+1 :green_heart:
compile
3m 41s
the patch passed

+1 :green_heart:
javac
3m 41s
the patch passed

+1 :green_heart:
shadedjars
7m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 58s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 17s
hbase-client in the patch passed.

-1 :x:
unit
9m 26s
hbase-server in the patch failed.

+1 :green_heart:
unit
4m 30s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
6m 53s
hbase-shell in the patch passed.

62m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 37563f9c33fe 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / 20b7c8b286

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/3/testReport/

Max. process+thread count
2426 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 22s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 21s
HBASE-25714 passed

+1 :green_heart:
compile
7m 25s
HBASE-25714 passed

+1 :green_heart:
checkstyle
2m 49s
HBASE-25714 passed

+1 :green_heart:
spotbugs
8m 53s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 58s
the patch passed

+1 :green_heart:
compile
7m  3s
the patch passed

+1 :green_heart:
cc
7m  3s
the patch passed

+1 :green_heart:
javac
7m  3s
the patch passed

-0 :warning:
checkstyle
0m 28s
hbase-client: The patch generated 7 new + 38 unchanged - 0 fixed = 45 total (was 38)

-0 :warning:
checkstyle
1m 13s
hbase-server: The patch generated 2 new + 210 unchanged - 0 fixed = 212 total (was 210)

-0 :warning:
rubocop
0m 24s
The patch generated 20 new + 656 unchanged - 0 fixed = 676 total (was 656)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 51s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
2m 55s
the patch passed

+1 :green_heart:
spotbugs
9m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 52s
The patch does not generate ASF License warnings.

82m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux 5009231be6f3 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / 20b7c8b286

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 49s
HBASE-25714 passed

+1 :green_heart:
compile
3m  9s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  4s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 40s
the patch passed

+1 :green_heart:
compile
3m 12s
the patch passed

+1 :green_heart:
javac
3m 12s
the patch passed

+1 :green_heart:
shadedjars
7m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  2s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 46s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 16s
hbase-client in the patch passed.

+1 :green_heart:
unit
149m 27s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 16s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 17s
hbase-shell in the patch passed.

200m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 68d528d837bf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / 20b7c8b286

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/3/testReport/

Max. process+thread count
4457 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  1s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 29s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 13s
HBASE-25714 passed

+1 :green_heart:
compile
7m  8s
HBASE-25714 passed

+1 :green_heart:
checkstyle
2m 43s
HBASE-25714 passed

+1 :green_heart:
spotbugs
8m 51s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  1s
the patch passed

+1 :green_heart:
compile
7m 10s
the patch passed

+1 :green_heart:
cc
7m 10s
the patch passed

+1 :green_heart:
javac
7m 10s
the patch passed

-0 :warning:
checkstyle
1m 16s
hbase-server: The patch generated 2 new + 210 unchanged - 0 fixed = 212 total (was 210)

-0 :warning:
rubocop
0m 23s
The patch generated 20 new + 656 unchanged - 0 fixed = 676 total (was 656)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 49s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
2m 56s
the patch passed

+1 :green_heart:
spotbugs
9m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 52s
The patch does not generate ASF License warnings.

81m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux 5c6d5e2bd1ba 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / 20b7c8b286

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 14s
HBASE-25714 passed

+1 :green_heart:
compile
3m 43s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 48s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 22s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 11s
the patch passed

+1 :green_heart:
compile
3m 37s
the patch passed

+1 :green_heart:
javac
3m 37s
the patch passed

+1 :green_heart:
shadedjars
7m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  0s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 15s
hbase-client in the patch passed.

+1 :green_heart:
unit
141m 40s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 42s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 10s
hbase-shell in the patch passed.

196m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b1dbc2de68be 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / 20b7c8b286

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/4/testReport/

Max. process+thread count
4049 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 48s
HBASE-25714 passed

+1 :green_heart:
compile
3m  6s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  1s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 39s
the patch passed

+1 :green_heart:
compile
3m  7s
the patch passed

+1 :green_heart:
javac
3m  7s
the patch passed

+1 :green_heart:
shadedjars
7m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 45s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 11s
hbase-client in the patch passed.

+1 :green_heart:
unit
149m 18s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 45s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 14s
hbase-shell in the patch passed.

200m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b156921e7936 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / 20b7c8b286

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/4/testReport/

Max. process+thread count
4852 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  1s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  9s
HBASE-25714 passed

+1 :green_heart:
compile
7m 13s
HBASE-25714 passed

+1 :green_heart:
checkstyle
2m 48s
HBASE-25714 passed

+1 :green_heart:
spotbugs
8m 57s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  0s
the patch passed

+1 :green_heart:
compile
7m 10s
the patch passed

+1 :green_heart:
cc
7m 10s
the patch passed

+1 :green_heart:
javac
7m 10s
the patch passed

-0 :warning:
checkstyle
0m 31s
hbase-client: The patch generated 5 new + 276 unchanged - 0 fixed = 281 total (was 276)

-0 :warning:
checkstyle
1m  9s
hbase-server: The patch generated 6 new + 6 unchanged - 0 fixed = 12 total (was 6)

-0 :warning:
rubocop
0m 22s
The patch generated 31 new + 656 unchanged - 0 fixed = 687 total (was 656)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 57s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
2m 56s
the patch passed

+1 :green_heart:
spotbugs
9m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 53s
The patch does not generate ASF License warnings.

81m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux e1c3df0525c1 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / e3553ad5d9

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/6/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/6/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 20s
HBASE-25714 passed

+1 :green_heart:
compile
3m 44s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 56s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 29s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 17s
the patch passed

+1 :green_heart:
compile
3m 39s
the patch passed

+1 :green_heart:
javac
3m 39s
the patch passed

+1 :green_heart:
shadedjars
7m 43s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  4s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 16s
hbase-client in the patch passed.

+1 :green_heart:
unit
141m 51s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 39s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 14s
hbase-shell in the patch passed.

196m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 47a3ae6c47d3 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / e3553ad5d9

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/6/testReport/

Max. process+thread count
4487 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 55s
HBASE-25714 passed

+1 :green_heart:
compile
3m  6s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 41s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  4s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 39s
the patch passed

+1 :green_heart:
compile
3m  9s
the patch passed

+1 :green_heart:
javac
3m  9s
the patch passed

+1 :green_heart:
shadedjars
7m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  4s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 47s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 14s
hbase-client in the patch passed.

+1 :green_heart:
unit
149m 16s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 15s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m 16s
hbase-shell in the patch passed.

200m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d9c476b76b1a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / e3553ad5d9

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/6/testReport/

Max. process+thread count
4514 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 25s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 16s
HBASE-25714 passed

+1 :green_heart:
compile
7m 17s
HBASE-25714 passed

+1 :green_heart:
checkstyle
2m 50s
HBASE-25714 passed

+1 :green_heart:
spotbugs
9m  5s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  4s
the patch passed

+1 :green_heart:
compile
7m  6s
the patch passed

+1 :green_heart:
cc
7m  6s
the patch passed

+1 :green_heart:
javac
7m  6s
the patch passed

-0 :warning:
checkstyle
0m 30s
hbase-client: The patch generated 3 new + 276 unchanged - 0 fixed = 279 total (was 276)

-0 :warning:
checkstyle
1m 12s
hbase-server: The patch generated 5 new + 6 unchanged - 0 fixed = 11 total (was 6)

-0 :warning:
rubocop
0m 25s
The patch generated 31 new + 656 unchanged - 0 fixed = 687 total (was 656)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
20m 18s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
3m  0s
the patch passed

+1 :green_heart:
spotbugs
9m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 53s
The patch does not generate ASF License warnings.

83m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux fc2980363861 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / e3553ad5d9

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/7/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/7/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 22s
HBASE-25714 passed

+1 :green_heart:
compile
3m 40s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 44s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 27s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 15s
the patch passed

+1 :green_heart:
compile
3m 40s
the patch passed

+1 :green_heart:
javac
3m 40s
the patch passed

+1 :green_heart:
shadedjars
7m 47s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 26s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  0s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 17s
hbase-client in the patch passed.

+1 :green_heart:
unit
142m 21s
hbase-server in the patch passed.

+1 :green_heart:
unit
3m 50s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m  7s
hbase-shell in the patch passed.

196m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux cef61370be19 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / e3553ad5d9

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/7/testReport/

Max. process+thread count
3946 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/7/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 54s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  8s
HBASE-25714 passed

+1 :green_heart:
compile
4m  8s
HBASE-25714 passed

+1 :green_heart:
shadedjars
10m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 33s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 54s
the patch passed

+1 :green_heart:
compile
3m 50s
the patch passed

+1 :green_heart:
javac
3m 50s
the patch passed

+1 :green_heart:
shadedjars
9m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 48s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 13s
hbase-client in the patch passed.

+1 :green_heart:
unit
162m 31s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m 38s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
8m 25s
hbase-shell in the patch passed.

226m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b9e24506513c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / e3553ad5d9

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/7/testReport/

Max. process+thread count
3588 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/7/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

We'd better rebase the branch first?
On master, we decoupled HRegionServer and HMaster so there is already a base class for HRegionServer and HMaster, which is conflict with the this branch...

We'd better rebase the branch first?
On master, we decoupled HRegionServer and HMaster so there is already a base class for HRegionServer and HMaster, which is conflict with the this branch...

I will rebase master before merge this branch back, not on this patch? Or the master is continue forward, I will rebase many times?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 53s
HBASE-25714 passed

+1 :green_heart:
compile
7m 10s
HBASE-25714 passed

+1 :green_heart:
checkstyle
2m 58s
HBASE-25714 passed

+1 :green_heart:
spotbugs
8m 45s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 43s
the patch passed

+1 :green_heart:
compile
7m 12s
the patch passed

+1 :green_heart:
cc
7m 12s
the patch passed

+1 :green_heart:
javac
7m 12s
the patch passed

-0 :warning:
checkstyle
0m 33s
hbase-client: The patch generated 3 new + 276 unchanged - 0 fixed = 279 total (was 276)

-0 :warning:
checkstyle
1m  7s
hbase-server: The patch generated 5 new + 6 unchanged - 0 fixed = 11 total (was 6)

-0 :warning:
rubocop
0m 20s
The patch generated 31 new + 656 unchanged - 0 fixed = 687 total (was 656)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 24s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
3m 10s
the patch passed

+1 :green_heart:
spotbugs
10m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m  2s
The patch does not generate ASF License warnings.

80m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux 6c2c73535648 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / e3553ad5d9

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 40s
HBASE-25714 passed

+1 :green_heart:
compile
3m 45s
HBASE-25714 passed

+1 :green_heart:
shadedjars
7m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 27s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 21s
the patch passed

+1 :green_heart:
compile
3m 43s
the patch passed

+1 :green_heart:
javac
3m 43s
the patch passed

+1 :green_heart:
shadedjars
8m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 22s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 44s
hbase-client in the patch passed.

-1 :x:
unit
164m  6s
hbase-server in the patch failed.

+1 :green_heart:
unit
4m 37s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
7m  9s
hbase-shell in the patch passed.

221m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 676ae2f5e113 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / e3553ad5d9

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/1/testReport/

Max. process+thread count
3882 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25714 Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 35s
HBASE-25714 passed

+1 :green_heart:
compile
3m 41s
HBASE-25714 passed

+1 :green_heart:
shadedjars
9m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 15s
HBASE-25714 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 26s
the patch passed

+1 :green_heart:
compile
3m 37s
the patch passed

+1 :green_heart:
javac
3m 37s
the patch passed

+1 :green_heart:
shadedjars
9m 14s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 53s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 37s
hbase-client in the patch passed.

+1 :green_heart:
unit
238m 27s
hbase-server in the patch passed.

+1 :green_heart:
unit
5m 20s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
8m 33s
hbase-shell in the patch passed.

298m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3690

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c54b7bc12808 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25714 / e3553ad5d9

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/1/testReport/

Max. process+thread count
2737 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3690/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


wingdings font not rendered properly

Link to PDF file (sorry for not being able to attach file link since it's confidential pdf content):
Configuration:

Web browser and its version: chrome (50.0.2661.94 m) , IE (11) , Firefox (46)
Operating system and its version: Windows 7
PDF.js version:1.5.309
Is an extension:no

What is the expected behavior? (add screenshot)

What went wrong? (add screenshot)

The checkboxes are rendered fine with adobeReader and with chrome pdfjs Extension but cant renderer wingdings fonts properly .

I don't think there is anything we can do about this without a test PDF. Could you create a minimal example PDF that has the problem and share it here, or strip the main content out of the original PDF file?

Also, this could possibly be a duplicate of issue #6353.

The issue is closed but i ve been struggling to find a workaroud to my case without success .
Here I cropped the part of the pdf file that i mentioned first .
Any help is appreciated .
checkboxError.pdf

The same Pdf is OK when viewed with chrome build in pdfjs viewer but failed in the online version of pdfViewer .

@interstellerS The other issue is still open.

I don't think it's the same . I tested with many pdfjs Version old and new ones . I still get the same issue .

The same Pdf is OK when viewed with chrome build in pdfjs viewer but failed in the online version of pdfViewer .
I tested with many pdfjs Version old and new ones

Can you be more specific about versions when you are talking about old, new or build-in? (Version of the viewer is visible in the console while viewing PDF)

OK when viewed with chrome build in pdfjs viewer

This statement tells us that the viewer worked at one point. If not, that it's possible duplicate of the opened #6353 as it was triaged at https://github.com/mozilla/pdf.js/issues/7454#issuecomment-229459592

i ve been struggling to find a workaroud

There is no workaround on PDF.js side. If you will change PDF to embed fonts inside PDF file the issue shall go away.


George/quality control

spinning logo animation completed, moving it into quality control main branch

This looks great! Looks much cleaner.


Enable NSLocale keyed archiving unit tests

NSLocale's encode(with:) encodes the locale's identifier as a CFString, which causes a crash in NSKeyedArchiver's _haveVisited ref map, since CFString cannot be forcibly cast to AnyHashable. Encoding the identifier as an NSString fixes the issue.
In decoding, a different NSLocale instance is returned. Since NSLocale no longer has value semantics (which were ported to Locale), it needs an isEqual implementation to compare two NSLocale instances as equal.
These changes combined allows us to uncomment the keyed archiving test and have it pass.

@swift-ci Please test

@swift-ci Please test

The build timed out because of TestURLSession.test_downloadTaskWithURL
Going to try re-running and hoping that it won't hang this time

@swift-ci Please test


Refactor and update vlei-verifier to be easily testable

For instance to test the changes regarding digest verification here https://github.com/GLEIF-IT/vlei-verifier/pull/26/files

Closing for more specific issues


doc: Capitalised 'Ninja' in CMDs for Linux users

Summary

There is a small error with this command mentioned in the docs:
$ cmake -G ninja ../.. -DCMAKE_BUILD_TYPE=Debug -DCMAKE_TOOLCHAIN_FILE=../../cross.cmake -DTARGET_APP=basic
The actual generator name should be 'Ninja' on Linux. This also failed in the docker container. I've changed the two instances I could find the wrong usage and capitalised them.
What I See
CMake Error: Could not create named generator ninja
Generators
Green Hills MULTI            = Generates Green Hills MULTI files
(experimental, work-in-progress).

Unix Makefiles               = Generates standard UNIX makefiles.
Ninja                        = Generates build.ninja files.
Ninja Multi-Config           = Generates build-.ninja files.
Watcom WMake                 = Generates Watcom WMake makefiles.
CodeBlocks - Ninja           = Generates CodeBlocks project files.
CodeBlocks - Unix Makefiles  = Generates CodeBlocks project files.
CodeLite - Ninja             = Generates CodeLite project files.
CodeLite - Unix Makefiles    = Generates CodeLite project files.
Eclipse CDT4 - Ninja         = Generates Eclipse CDT 4.0 project files.
Eclipse CDT4 - Unix Makefiles= Generates Eclipse CDT 4.0 project files.
Kate - Ninja                 = Generates Kate project files.
Kate - Unix Makefiles        = Generates Kate project files.
Sublime Text 2 - Ninja       = Generates Sublime Text 2 project files.
Sublime Text 2 - Unix Makefiles
= Generates Sublime Text 2 project files.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.marnixcrouzen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@marnixcrouzen thanks, for now it's ok but please make sure you follow the contribution guideline for branch name and commit message imperative format


mesop command not found after pip installing on windows

https://www.reddit.com/r/LocalLLaMA/comments/1d8g5j1/comment/l77cvto/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button

Addressed by improving installing docs w/ steps on using venv (tested locally on Windows machine and it works as expected).


Error : ENOTFOUND

Hello. I've been trying to set RSS puppy up. I'm getting { [Error: getaddrinfo ENOTFOUND] code: 'ENOTFOUND', errno: 'ENOTFOUND', syscall: 'getaddrinfo' } and I have no idea what's referring to. Here's config file:
{
"feeds": [        "https://globenewswire.com/Rss/search/XwXK98ZDWLc8N4m3FssORcAcOHv2hsB6FxDQQN3Yc3oAyuPrMfAte0Pc9aqo_dXL"
],
"throttling": {
    "monitorFrequency": 8000,
    "oldFeedThreshold": 30,
    "maxConcurrent": 10,
    "concurrentInterval": 1000
},

"dbconfig": {
    "user": "rsspuppy",
    "password": "pwhere",
    "url": "<IP_ADDRESS>",
    "port": 5432,
    "dbname": "rsspuppy",
    "initScript": "./monitor/init-feed-db.sql"
},

"outputs": [
    {
        "file": "./outputs/debug-logger.js",
        "config": {
            "showOldFeedMessages": true
        }
    }
],

"exitOnError": true

}
Also, it'd be nice if there was more documentation available

Hey, sorry this is giving you trouble, the documentation definitely needs to be better.
So I copied your config over and I think the error is RSS Puppy not being able to connect to your local database. It's super opaque, we should really catch that error and report something more reasonable. Are you sure the db is running and listening on the (default) port 5432?
I got your config to work by doing this:

in one terminal window postgres -D /usr/local/var/postgres
in a second terminal:

createuser --password rsspuppy
creatdb rsspuppy

inside the rss puppy directory node run.js

Hi. Thanks for replying. It's up and running according to netstat
tcp        0      0 <IP_ADDRESS>:5432          <IP_ADDRESS>:*               LISTEN
I also tried running it with mysql (since you've said it might work in some other issue) and a I'm getting same error.
You think it can be caused by somewhat outdated debian packages?
npm WARN engine<EMAIL_ADDRESS>wanted: {"node":">=0.10.32"} (current: {"node":"0.10.29","npm":"1.4.21"})
npm WARN engine<EMAIL_ADDRESS>wanted: {"node":">=0.10.40"} (current: {"node":"0.10.29","npm":"1.4.21"})
npm WARN engine<EMAIL_ADDRESS>wanted: {"node":">=0.10.40"} (current: {"node":"0.10.29","npm":"1.4.21"})
npm WARN engine<EMAIL_ADDRESS>wanted: {"node":">=0.10.40"} (current: {"node": "0.10.29","npm":"1.4.21"})

That's possible, did you try updating things?
I'm trying to think of the quickest way to debug... Inside of monitor.js on line 22 there's a call to buildDBConnectionString. Maybe right below that log dbconfig.connectionString to see what it produced? And maybe test to see if that connection string works for your db setup?

I have updated everything and added outputted connectionstring to console. Here's result:
postgres://rsspuppy:Ern/~^,,#!pjzZf@<IP_ADDRESS>:5432/rsspuppy
Wed May 04 2016 05:19:00 GMT+0000 (UTC)  Error:
{ [Error: getaddrinfo ENOTFOUND rsspuppy rsspuppy:5432]
  code: 'ENOTFOUND',
  errno: 'ENOTFOUND',
  syscall: 'getaddrinfo',
  hostname: 'rsspuppy',
  host: 'rsspuppy',
  port: 5432 }

Tried connecting with next command psql -h <IP_ADDRESS> -p 5432 -U rsspuppy rsspuppy and it worked. So psql is definitely up an running.

Oh! I think the answer might have been hidden in that password! Was there a space in there?
I think a space or other symbol is causing it to incorrectly parse the url. Probably there's a way for me to escape passwords, I'm not sure, but could you try with something simple like "abc" just to test?

I just created a user with that password and got the exact same error (sorry, I wasn't trying to steal your pw, but github emailed it to me. I'll delete the email / user and I definitely won't remember it heh)
Checking to see if I can escape the pw in the connection string

Pretty sure it was /  in the password which was causing this and yes, some password escaping would be nice.
Also, don't worry, I regenerated password after mistakingly posting it but it's not like you can do anything with that anyway :stuck_out_tongue:
Now time to figure out how to make the data accessible from outside of aws instance in say json format,

I just pushed a commit that url encodes the username and password, sorry for all that pain >.<

Ok, headed to sleep here, but let me know if you have other problems!

(ok, actually pushed one more commit that just encodes everything that could possibly cause a problem)

Thanks for you help. My client seems to be very happy with the potential of the tool you've created so thanks on his behalf as well.
Question is, how do I leave monitor running on the aws instance?

So there are a couple pretty easy ways to do that. If you're working with an ec2 instance and want full control, probably the simplest (and my personal favorite) is to make an upstart script: http://kvz.io/blog/2009/12/15/run-nodejs-as-a-service-on-ubuntu-karmic/
Or if you want to use elastic beanstock (easier in some ways to manage, but harder to test things / get access to logs), I recommend looking at the edgar-monitor repo (which uses rss-puppy to watch the sec's edgar filings database basically). You can tweak the dockerfile here: https://github.com/buzzfeed-openlab/edgar-monitor/blob/master/Dockerfile and make a little aws runner file like here: https://github.com/buzzfeed-openlab/edgar-monitor/blob/master/Dockerrun.aws.json
By the way... If you're allowed to tell me anything about what you're working on for the client you mentioned, I'd be super curious! My email is<EMAIL_ADDRESS>

Oh, I guess I'll start up script for debian.
Unfortunately, at this point I can't talk about what's being developed but when it's done and launched (target is 1st july iirc), I'll let you know.

@Igor-Yavych out of curiosity, was the project you worked on launched? I'd love to know more :)


[OSD-9910] Check that AwsAccountID is set as validation.

All checks we currently run require the AwsAccountID to be set, so we check it early.
Prevents the logs filling up with errors, because of an invalid account id.

Codecov Report

Merging #711 (a73521e) into master (4b2bfdb) will increase coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   36.17%   36.20%   +0.03%
==========================================
  Files          50       50
  Lines        5465     5477      +12
==========================================
+ Hits         1977     1983       +6
- Misses       3327     3333       +6
  Partials      161      161

Impacted Files
Coverage Δ

...roller/validation/account_validation_controller.go
57.41% <50.00%> (-0.46%)
:arrow_down:

/lgtm


bug: disallow out-of-order timeline generation

Steps to Reproduce
Use the following agenda to reproduce this behavior.
- 08:00 start
- 18:00 end
- 12:00 lunch

The resulting timeline will show a block from 08:00 to 18:00 called start.  A ingle block at 18:00 called <End of Plan>, and then finally another block after 18:00 that claims to start at 12:00, but really starts at about 18:15, and then lasts for maybe 15 minutes-ish.
Expected behavior
Out of order agenda items should be one of:

re-ordered based on time
an error! the timeline should not render

Original Day Planner seems to have achieved this recently
https://github.com/lynchjames/obsidian-day-planner/pull/163

Thanks for the heads up! I'm going to patch and test with that solution.


CLI command to convert between Human and JSON policy formats

Category
CLI features/changes
Describe the feature you'd like to request
CLI should let users convert policy to/from JSON.
Describe alternatives you've considered
Doing it in Rust, as it's done today.
Additional context
No response
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request
[ ] ⚠ This feature might incur a breaking change

^ related to the name change above -- the CLI already accepts policies in JSON format everywhere it accepts policies in human format (except for the format command, because, obviously). so all that remains to "support JSON policy format in CLI" is to add a command to convert between human and JSON formats.

Could you give me some pointers on how to do this?
For SchemaFragment there is as_json_string() and as_natural().
For PolicySet there is from_str() and from_json_str(). But I'm not sure how to convert it TO json or human form?

To json: On main (not in any release as of this writing), there is a PolicySet::to_json().
To human: The Display trait for PolicySet is probably what should be used I think

I looked at this a couple weeks ago and found that we don't have a public API for converting json policies to human. Display prints the lossless repr, which for a JSON policy is the JSON.
That extends the scope of this issue to adding a public to_human (maybe not the best name,  see https://github.com/cedar-policy/cedar/issues/842) function to policies and policy sets before using that function to implement the CLI feature.

Would it make sense to implement only the translation from human to json for now?

That would be enough to be useful for seeding the corpus in  cedar-policy/cedar-spec#343, so yeah, I think it would make sense

With #987 we can convert to JSON. As discussed above, we need to implement json-to-human before we can add it to the CLI.

That would be enough to be useful for seeding the corpus in https://github.com/cedar-policy/cedar-spec/pull/343, so yeah, I think it would make sense

Given that the translation capability now exists, I'd love to take a look at using it for seeding the corpus, as mentioned above. Could you give me some pointers on what needs to be done in that repo?

Fuzz target corpus are initialized here: https://github.com/cedar-policy/cedar-spec/blob/main/cedar-drt/initialize_corpus.sh
The change would just be to add another step into the convert-policy-json-to-cedar case to  find all *.cedar files add *.cedar.json files to the corpus dir with the output of the CLI conversion.


Resource numeric inputs

Description
To enable more precise resource quota configuration for product teams, replace dropdown options with input boxes for resource request values.
Technical Details

Update the schema to accept numerical request values.
Replace existing dropdowns with input fields for entering request values (limit values won't be collected)
Set increment steps: 0.5 for CPU, 1 for Memory and Storage.
Update NATS message generation to handle numerical values.
Refactor code to use numerical values instead of string options.

Definition of Done (DOD)

Project teams can input and validate resource request values in numerical format.

Reference

https://app.zenhub.com/workspaces/app-dev-team-646fdb4400ed8c0021aceeb4/issues/gh/bcgov/platform-services-registry/4113

Ian and Artem will be testing this work. Ian will be testing the Provisioner side. Junmin asked Ian to test on Dec 4th.


Refactor hook tests

This PR refactors all tests in commerce-sdk-react. Reason is that the nock setup was flaky and too complicated, the flaky tests cause significant slowdowns to our development and we'd want to resolve the issue.
No.1 Goal
We no longer have flaky tests.
Changes

Remove nock back recording feature including mock fixtures
Remove mockAuthCalls
Only using nock / module mock in unit tests
added jest-silent-reporter for logging
added renderHookWithProviders ultility to simplify unit tests
minor changes to unit tests

Is this filename change intentional? ...commerce-sdk-react/src/auth/index.test.ts → ...ommerce-sdk-react/src/auth/index.tes1t.ts

File name change is now reverted... That's my quick and dirty way of temporarily disable a test file. 😛


chore: bump version for release

do you plan to release version 1.4.8? (i believe currently the version was bumped after a release was cut, @secretfader knows more)
The current in-operation version is 1.4.6

do you plan to release version 1.4.8? (i believe currently the version was bumped after a release was cut, @secretfader knows more) The current in-operation version is 1.4.6

Ah! Sorry I thought it was bump here first, then push! I can push then merge this :)

please do and git tag v1.4.7 the commit you pushed

Looks like it's already published! Can I merge this and publish 1.4.8?


How to prevent "end" key from scrolling down

I am using the following keyMap:
        const keyMap = {
            'first': 'home',
            'previous': 'left',
            'next': 'right',
            'last': 'end'
        };

However when I press "end", it will trigger the handler as expected, but also scroll down the page (as if there was no hotkey). How can I make sure the hotkey supersedes the default key behavior?

OK I found the solution:
     const handlers = {
            'last': (event) => {
                event.preventDefault();
                stuff();
            }
        };