Add Article for Hello World in Lua

Merged the script #18 but never wrote the article.

Added link to README: https://github.com/jrg94/sample-programs/commit/3defcab4c9859f59699308a67f1c5ce779dccf12

I'm taking this! :)

Finished: Adding like to README even though it's not being published until August 24th...


(libreoffice-still) LibreOffice Still: automatic update broken? update(s) available!

Checklist

[X] I have checked the moderation queue that no new version has been submitted (only visible when logged in), or the submitted package version has failed the automated checks.

Please navigate to the following link to view the moderation queue.

[X] I have verified that the new version is a stable release.
[X] I have looked to see if there are any Bug reports that prevents a new version being submitted and that no existing Outdated Reports have been created.
[X] I have verified the new version has a Windows binary (EXE or MSI installer, Zip or other archive, etc).

New Software Version
<IP_ADDRESS>
Download location
https://downloadarchive.documentfoundation.org/libreoffice/old/<IP_ADDRESS>/
Package Page
https://github.com/chocolatey-community/chocolatey-packages/tree/master/automatic/libreoffice-streams

Automatic update of LibreOffice Still aka libreoffice-still seems to be broken. Currently available at Chocolatey is 7.5.6. But currently available at LO is <IP_ADDRESS>. So, <IP_ADDRESS> (Bugfix release because of WebP bug), <IP_ADDRESS> and <IP_ADDRESS> have been missing. <IP_ADDRESS> should be the last release of 7.5 cycle: Release Plan 7.5.

@choco-bot @ any, anyone? no one for libreoffice-still?

@zWhdmB5T this is a community maintained repository. The expectation is that you'll get involved, make changes and help to fix, maintain or enhance the package for the benefit of the community.
If you can't / won't and nobody else is willing, then there is no point having the issue open and it will be closed.

I am willing to, but I am not able to…
(I could try for specific version updater — but I actually don't really know how to fix the automatic updater, sorry.)
(I would spend money for this :-) )

@zWhdmB5T this is a community maintained repository. The expectation is that you'll get involved, make changes and help to fix, maintain or enhance the package for the benefit of the community.
If you can't / won't and nobody else is willing, then there is no point having the issue open and it will be closed.

@pauby Well, I tried… but it seems it needs to get the automatic updater script fixed. But, sorry, I am not able to do this. I am not into programming and coding. All I have my GitHub account for is providing BugReports, Comments and FeautreRequests.
I am also willing to pay for more and better updates. I don't need business/corporate Chocolatey products you offer. I am fine with community/OSS Chocolatey. I just need more and better updates… and I would pay for that. But for this case I don't find any hint on the website… I am asking this need and offering money because whenever I report a package out of date / out of maintenance, you always refer to the community aspect. It's clear, it's the community… And I would help — if I could. All I can do is paying for better service (and I don't need a business/corporate Choco but just more and better updates). Sorry, I really cannot code…

All I can do is paying for better service (and I don't need a business/corporate Choco but just more and better updates)

I know what you meant here with t heabove. But I really just wanted to clarify a couple of points in case others don't.

paying for better service

There is no service being provided. There are no SLA's, expectations or obligations. The community create and maintain packages in their spare time to help others out. So there is no service to pay for.
When it comes to better, again, people do this in their spare time so they do what they can. If you feel you can fix, maintain, update, change or help in any way to make things better then, as part of hte community, that's what we expect.

need a business/corporate Choco but just more and better update

Having a business/corporate Choco doesn't change anything in this repository. The repository is maintained by the community who are volunteers who help out in their spare time to provide packages to the Chocolatey Community Repository. I justw ant to stress the word community again. If you have a business/corporate Choco there is no extra service, or anything you pay for on the Chocolatey Community Repository. I, you and anybody with a business/corporate Choco get access to the same packages maintained by the same volunteer maintainers.

Sorry, I really cannot code…

Neither could I until I learned. I don't want that to be flippant, but I also do want it to come across as we all start and learn from the beginning.

and I would pay for that

We don't ask or take any payment for packages

TL;DR: ticket can be closed (from my side) as I don't have anything serious (like real code) to contribute…
For discussion @pauby
Well, I am not a coder and I actually don't want to become one this life, any more (sorry, but I have my reasons). I just want to use Chocolatey as an ordinary user (like people with much less IT knowledge than me).
My main system is by now a Linux one. There, repository management has been used for quite a long time and is something like state of the art. But it's true: when coming to FlatHub or Snap, it is still much to the broad community to work properly resp. provide updates always on time. Therefore, I was lucky and happy to find Chocolatey for Microsoft Windows, one day back then. I recommend it to family members and friends. I recommend it over WinGet, because WinGet (which is also community run…) has also a lack of updates somewhere/sometimes and it often provides only en-US language (not international or de-DE for my need).
I appreciate and value OpenSourceSoftware and community projects. Not just because they're mostly free of costs (for the user). But for the OpenSource approach (for many different reasons).
What I do is: serving bug reports (sometimes very detailed), asking for feature requests (I try not to be demanding — I am just asking when there's a real need), and I do spend money for donations. Not all projects/maintainers accept donations. But where they do and when I use the software/project quite regularly, I then donate.
I was asking for kind of "premium support" concerning updates in my comment above with the following background:
Chocolatey offers several editions to be paid. I think for a common home user they are not need for technical reason (they offer many features I don't really need). And the Pro Edition does not offer benefit for me for the money I have to pay. But I would be thinking about paying 50 $/y for better/more updates. My rough calculation is as following. If there would be just 2.000 subscriptions for 50 $/y for more/better updates, an employee could be hired caring just for updates during the year.
There are updates that work as automatic updates and such as manual ones. The employee would have to take care for more automatic updates in general (and to care about the automatic updates over time). And he could take care about the manual updates the rest of the time. This would lead to a much better user experience I guess.
Just for discussion, no demanding at all…

The update script is behaving as designed.
As stated in the Notes section of the package's description:

This package relies on the update service provided by The Document Foundation to determine new updates. As their policy is to distribute to their website immediately and to the update service after 1 to 2 weeks, there will be a delay between a new software update and a new version release of the package.

While it has been a few weeks since v7.5.8's publication on the website (2023-11-02), The Document Foundation's update service is still not offering v7.5.8 as of now, so the update script won't pick up on it for the time being. We'll need to wait out its publication before a package for v7.5.8 can be automatically created.
Changes for the previous version (v7.5.7) were made about a couple months ago, but the resulting package failed to push to the Community Repository. A core maintainer may need to force a package rebuild for this version with AU, since the current repository state is up-to-date with what's currently being offered by the update service.

@brogers5 OK, understood then. Thank you very much for your explanation!
One specific enquiry because of my interest:
Are you talking about:
chocolatey-packages/automatic/libreoffice-streams/tools/helpers.ps1
function GetLatestVersionFromLibOUpdateChecker($userAgent) {
  $url = "https://update.libreoffice.org/check.php"
  $request = [System.Net.WebRequest]::Create($url)
  $request.UserAgent = $userAgent
  $s = $request.GetResponse().GetResponseStream()
  $sr = New-Object -TypeName System.IO.StreamReader($s)
  [xml]$xmlAnswer = $sr.ReadToEnd()
  return $xmlAnswer.description.version
}

How does this request to the LibreOffice update service work? In my browser it shows just an error message, but not the version string…

A core maintainer may need to force a package rebuild for this version with AU, since the current repository state is up-to-date with what's currently being offered by the update service.

This was done just now and the missing version was not pushed.

How does this request to the LibreOffice update service work? In my browser it shows just an error message, but not the version string…

You'd need to spoof your browser's user agent in order for the update service to respond in the expected manner. Check GetLatestStillVersionFromLibOUpdateChecker for the value used by the script.
Alternatively, you could check for updates within LibreOffice with a known outdated version.

While looking into this, I've noticed the update service has since started offering v7.5.8 and successfully produced a package for it in my environment. This will likely be resolved with the next scheduled AU run.

How does this request to the LibreOffice update service work? In my browser it shows just an error message, but not the version string…

You'd need to spoof your browser's user agent in order for the update service to respond in the expected manner. Check GetLatestStillVersionFromLibOUpdateChecker for the value used by the script.
Alternatively, you could check for updates within LibreOffice with a known outdated version.

Thank you!

This was done just now and the missing version was not pushed.

Looks like AU didn't even acknowledge the forced build request.
This particular update script is quirky in that au_GetLatest will only return a stream if it is created by AddLibOVersionsToStreams. GetLibOVersionsWithoutFromVersion creates the list of versions that is iterated over. The list starts with the version currently defined in the streams file, but the desired version is deliberately filtered out because "it is the current one that has already been pushed to Chocolatey" which prevents construction of the necessary stream. We probably shouldn't be doing this in a forced update scenario.

Thank you!

While looking into this, I've noticed the update service has since started offering v7.5.8 and successfully produced a package for it in my environment. This will likely be resolved with the next scheduled AU run.

Hehe ;-) I just kindly asked the Document Foundation team this afternoon, and they responded soon including this effort.

libreoffice-still v7.5.8 has been produced, pushed and should now be available for consumption. Issue can be closed.

@brogers5 Thank you for all explanation and help. Yes, libreoffice-still works as intended and package is updated and online now. Thank you. And I asked the Document Foundation team if they might set the Update Checker on time for the future. And I got the Update Checker URL working with the appropriate user agent. Thank you!
@brogers5 Sorry that I ping you. Because you have been very helpful in this case, would you mind having an eye on libreoffice-help. Just asking… just dreaming…


moved vscode-languageclient/server to latest released version (client - 6.1.3, server - 6.1.1)

moving vscode/vscode-languageclient/server to latest release versions.
doing this as a preparation to consume the latest LSP APIs added in the recent release.

@karthiknadig it seems I can't add labels, can you add the "no news" label for me? this doesn't have any user-facing changes.
and can I get some code reviews?

@DonJayamanne readonly was required due to 'vscode' API changes.
                  /**
		 * List of workspace folders or `undefined` when no folder is open.
		 * *Note* that the first entry corresponds to the value of `rootPath`.
		 */
		export const workspaceFolders: ReadonlyArray<WorkspaceFolder> | undefined;

due to it returning readonlyArray, which has this
 readonly [n: number]: T;

the effect must be propagated to any code that returns/accept this array such as
 public get workspaceFolders(): readonly WorkspaceFolder[] | undefined {
        return workspace.workspaceFolders;
    }

can I get some help on "PR Validation (Windows Py3x Single Workspace)" ? should I just keep re-run until it pass? I think I had same issue with previous PR.

Looks like it is running slower than usual. I have to re-run it a few times. If this keeps happening next week, we should probably increase the timeout for a for a bit.

Codecov Report

Merging #10959 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #10959      +/-   ##
==========================================
- Coverage   60.70%   60.68%   -0.03%
==========================================
  Files         582      582
  Lines       31668    31668
  Branches     4508     4508
==========================================
- Hits        19224    19217       -7
- Misses      11460    11465       +5
- Partials      984      986       +2

Impacted Files
Coverage Δ

src/client/activation/languageClientMiddleware.ts
33.59% <0.00%> (ø)

src/client/common/application/documentManager.ts
8.57% <0.00%> (ø)

src/client/common/application/types.ts
100.00% <ø> (ø)

src/client/common/application/workspace.ts
30.76% <0.00%> (ø)

src/client/languageServices/jediProxyFactory.ts
36.00% <0.00%> (ø)

src/datascience-ui/react-common/arePathsSame.ts
75.00% <0.00%> (-12.50%)
:arrow_down:

src/client/common/utils/platform.ts
64.70% <0.00%> (-11.77%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

...client/datascience/kernel-launcher/kernelFinder.ts
75.70% <0.00%> (-0.94%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbfed3...e5c1472. Read the comment docs.

@karthiknadig finally passed!

@karthiknadig I don't have access to check this in? can you merge it for me?


how to prevent a user not to enter a special character in a textbox with typescript?

I totally a beginner in typescript and I use it in a serenity framework and I wonder how to prevent a user not to enter a special character in a textbox with typescript.
as a result, I tried this:
`
this.form.FirstName.element.on('keyup', event => {
var initval = this.form.FirstName.element.val;
var keyCode = (event.keyCode ? event.keyCode : event.which);
            if (keyCode == 32 || (48 <= keyCode && keyCode <= 57) || (65 <= keyCode && keyCode <= 90) || (97 <= keyCode && keyCode <= 122)) {

                console.log("sucssed!");
                this.form.FirstName.element.val = initval;
            }

                else {
                    console.log("faild!");
                }
          });

`
but I don't know its alright or what fault it has.

Use regex.
initval.match('...')


[feature request] Adding Bing Chat Compatibility to Chrome Extension

I recently discovered your Chrome extension and have been impressed with its functionality. I would like to request the addition of Bing Chat compatibility to further expand its reach and usefulness.
Benefits of adding Bing Chat compatibility:
Increased User Base: Supporting Bing Chat would allow your extension to reach a broader audience, providing value to Bing Chat users.
Competitive Edge: Supporting Bing Chat would set your extension apart from competitors, as there are limited options available for Bing Chat users. Being one of the first extensions to provide Bing Chat compatibility would establish the position of your extension as pioneers in this area.

Thanks for filing this issue! The problem with bing chat is that its URL is indifferentiable from bing search. Therefore, adding bing chat would also enable prompster for bing search which might be undesirable. However, I agree that bing chat support would be a valuable addition so I think this is worthwhile investigating further. Feel free to share your thoughts on the topic? Would you find it disturbing if prompster was enabled for search as well?

I have been using your chrome extension for the past two weeks, and I am pleased to say that I find myself consistently relying on it, despite its current limitation of not working on Bing. Its usefulness on ChatGPT has made it an indispensable tool for me. As someone who extensively utilizes Bing Creative Mode for work, I wanted to share some thoughts and suggestions.
Firstly, I rarely use forward slashes in my search terms, and even when I do, I can easily rephrase my query to exclude them. Furthermore, your extension already allows the use of forward slashes as text with the backspace button, making it convenient to incorporate them when needed. Given these factors, I believe enabling the extension on Bing search with forward slashes would not pose a significant issue. Additionally, considering the relatively low usage of Bing compared to other search engines, the impact of this change on a broader user base is likely to be minimal.
In terms of triggering the extension, I suggest expanding the keyboard shortcut from just '/' to 'ctrl/cmd + /'. This modification would provide a clear and distinct way to activate the extension, reducing the chances of inadvertently triggering it while typing a forward slash. This keyboard combination is commonly associated with shortcuts in various applications, and users are likely to find it intuitive and easy to remember.
Your chrome extension has proven to be a valuable asset for me and I hope many users. Thank you for considering my feedback, and I appreciate the work you have put into creating such a useful tool.
On a side note, I wanted to mention that Microsoft plans to allow access to Bing chat on other browsers, including Chrome. This development is expected to attract a substantial influx of users to Bing Creative Mode, as it is currently the best available free GPT4 model accessible to the public. I have heard about other platforms like Poe and Claude+ offering GPT4, but I have yet to personally test them. Do you have any plans to make your extension compatible with these sites as well?

I would love to use the extension on every form. There are much LLMs and wrappers where Prompster can help us out. Like Cloude or poe.com.
Yeah, just use 'ctrl + /' to trigger the extension. Or a double forward slash '//'. But for all forms.

I just published version 1.3.3 which adds support for:

Claude
Poe
AgentGPT

I expect the version to be publicly available within the next week. There were some complications in adding Bing support which is why it is not included in this version. It seems the key-event listeners are being blocked but I'll have to examine this in more detail.

If there are any other chat bots that you would like to be added, please share them here: https://github.com/LucasAschenbach/prompster/discussions/5
I will leave this issue open until Bing support has been added.


ci: always execute tests on non-PRs

SUMMARY
When working on a branch before opening a PR I noticed that the conditional test skipping doesn't work properly when PR_NUMBER isn't available (=not a PR). This changes tests to always execute when it isn't a PR, for example after merging or when just working on a branch.
BEFORE

AFTER

TEST PLAN
Local testing + ShellCheck:

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

I wonder if it's easier to understand if we use step output instead of outcome , considering all future steps will have to check
for FILE in ${FILES}
do
  for REGEX in "${REGEXES[@]}"
  do
    if [[ "${FILE}" =~ ${REGEX} ]]; then
      echo "Detected changes in following file: ${FILE}"
      exit 0
    fi
  done
done
echo "No matching file changes detected"
echo "::set-output name=no_matching_change::true"

Then maybe we can also use condition check on the check job itself (if: github.event_name == 'pull_request') to address what this PR is trying to solve? I.e. run the file change check only on pull requests, and skip future tasks only if steps.check_file_change.output.no_matching_change = true.

I wonder whether it'd make the workflow scripts easier to understand if we use step output instead of outcome , considering all future steps will have to check the step results anyway.
for FILE in ${FILES}
do
  for REGEX in "${REGEXES[@]}"
  do
    if [[ "${FILE}" =~ ${REGEX} ]]; then
      echo "Detected changes in following file: ${FILE}"
      exit 0
    fi
  done
done
echo "No matching file changes detected"
echo "::set-output name=no_matching_change::true"

Then maybe we can also use condition check on the check job itself (if: github.event_name == 'pull_request') to address what this PR is trying to solve? I.e. run the file change check only on pull requests, and skip future tasks only if steps.check_file_change.output.no_matching_change = true.

This is a really good idea; I'll merge this one first to fix the problem but will follow up with something along these lines if it works well.


Update version to Bass

Update version selector and banner to Oakestra Bass before release

handled in https://github.com/nitindermohan/oak-new-docs/commit/5adb7f03adc10c8887e70994f7600a41459151cd


Adding QA Pipeline

@ktagowski can you add experimental code for QA that we have already created as starting point?

TODO @mkossakowski19 :

[ ]  Refactor Q&A code
[ ] Tests on English Squad and add example of usage
[ ] Tests on Polish translated Squad

TODO (17.02):

[ ]  Add tests for the QA evaluator
[ ]  Adjust tests for pipeline
Fix errors and add more detailed metrics checks. Currently, in tests, metrics are compared as 0 < mt < 100, but it should be changed to 7 decimal precision, e.g., assert_almost_equal(mt, 0.1234567).
[ ] * Move batch encoding kwargs to LightningBasicConfig class
Create QALightningBasicConfig that is more suited for QA (2 batch_encoding parameters and 1 QA-specific parameter (doc_stride)
[ ] * Fix linter
There are issues with styling and pymagnitude

Optional tasks (lower priority):

[ ] * [optional] Adjust LightningModule class logic
Currently, there is code duplication between LightningModules (setup, freeze_transformer, forward). However, it needs restructuration of the inheritance hierarchy as HuggingFaceLightningModule are specific for Classification tasks.
[ ] * [optional] Notebook with QA pipeline example
Add an example how "easy" it is to run a QA pipeline


Design a simpler UX

Reason
The initial reward program has explicit criteria for receiving a payout
Description
The managed reward program consists of a flat $1 per month for users who:

link their gmail account
link 1 other retailer account

The criteria for payout is:

open the app once a week (to sync)
keep both accounts linked for the entire month
generate a minimum of 5 receipts

The UX should make this criteria clear and show users where they are against meeting it (in addition to the standard requirements of clearly stating what data is collected and how it will be used).
Success Criteria

[ ] approved wireframes
[ ] explain clearly to the user the data requirements
[ ] explain clearly to the user the criteria for payout
[ ] mockups that the engineering team can use to scope and build the changes

Additional Information
No response

Here's my first pass at sketching out the following 5 screens:

Consent Screen
Main Screen
Linked Accounts Screen
Link Account Screen
Offer Detail Screen

Screens 1-3
On the Consent Screen, I removed the copy about how data is used. I think that should be additional copy that can be navigated to by clicking on the question mark logo.
On the Main Screen, the "Link Gmail" and "Link Retailer Account" sections should be clickable and take the user to the Link Account screen. Completed actions should be de-emphasized and moved to the bottom of the list (or removed from this view). The requirements that are incomplete should be at the top. The question mark should navigate to the Offer Detail Screen.

Screens 4-5
The offer detail screen should show a collection of logos: Gmail and a few select (popular) retailers.
It will require additional copy that allows the user to view all the supported merchants when they click for more detail. That may require another screen. We can give them highlights with a limited list of logos.

@timoguin @sfaria27 incomplete, but this is the first set of screens for the main page

Notes:

If the user does not have an account connected, skip the account list screen and take them straight to the connect form when they click the Gmail or Retailer button.
Only show the Sign in with Google option and divider if OAuth is enabled.
Retailer Icon in dropdown is optional if it's hard to do.
Only show the remove warning screen if the user is removing their last remaining Gmail or Retailer account.

Notes:

I need help figuring out a better graphic with more "pop"
I think with a better graphic, I can cut down the words in the description to something like "We're testing out a new program —cash for receipts!"

https://www.figma.com/file/1cY8mJvJ3QBKXiCsSZvXqt/Reward-Graphics?type=design&node-id=307-4&mode=design&t=0Zg5V8i0R0EqE5O6-0 this is the stuff i did for the shopify example. could be similar to that with like dollar bills replacing the discount image

could also have like a receipt img with a key over it and an unlocked chest or something with some cash in it.
probably harder to make but kind of funny is a "receipt register" that prints out dollar bills. this program is basically just an inverse cash register lol
could show a basic linking flow like a gmail icon, a little collage of a few major retailers, and a collage of a few receipts with arrow to a $1 img or a dollar bill img
could show a collage of receipts with a fade out toward the center and a big bold $1 sign or bill in the center
could literally show the reward screen progress example with the criteria met & cash out button (the actual mobile interface they'd see and use)
could be a simplified version of above

ReceiptFlow.pdf


Update dependencies

This updates to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Also fixes and improves the camera tests, and did some maintenance.
We are currently building a PWA project and need this to work with the latest Ionic and Stencil, but at the moment some of the types (e. g. HTMLIonNavElement) clash if this is being used along with a different Ionic version.
Closes #7, closes #4.
I linked this locally against my project and it works.

I'm not sure how to solve this in the long term for the case of using this within Ionic/Stencil projects... was thinking peerDependencies first, which should be fine as long as Ionic follows semver for breaking changes, i. e. { "peerDependencies": { "@ionic/core": "^4.0.0-beta.12" } } would allow to build this with anything between 4.0.0-beta.12 and 5. However the beta might still introduce breaking changes, and I don't know how the actual dist build would work if those are just peer dependencies.

w00t! Thanks for the PR. Will do a release at some point in the next two weeks (absolutely slammed rn)

@mlynch release pl0x?


Getting Started: Why do we need to specify the step type?

I would think this could just be determined from the file extension?

Good point, removed in favor of path.endsWith('.md')


[SuperEditor] Fix selection shifting when moving between nodes (Resolves #1761)

[SuperEditor] Fix selection shifting when moving between nodes. Resolves #1761
In the "Animated task height" demo, moving the caret between nodes using UP or DOWN arrow is shifting the selection horizontally:
https://github.com/superlistapp/super_editor/assets/31278849/0b810924-ba05-4a8f-91c1-9fca023baad6
This would happen to any component that mixes in ProxyDocumentComponent.
To move the selection vertically between nodes we first get the current offset for the selected position and then compute
which position in the upstream/downstream node is closer to this offset.
The issue is that for ProxyDocumentComponent, getOffsetForPosition only considers the text inside the component, not the whole component. In the example of the task component, it ignores the checkbox that appears before the text.
For example, consider this layout:
[ ]  This is the task 1
[ ]  This is the task 2

If the caret sits in This is the task 1|, pressing DOWN should move the caret to This is the task 2|.
However, we are computing the original offset as if the layout was like the following:
This is the task 1
[ ]  This is the task 2

So the offset at This is the task 1| would move down to This is the t|ask 2.
This PR changes ProxyDocumentComponent to consider the offset inside the whole component layout.

@matthew-carroll I noticed a similar issue when moving the selection from a list item to a paragraph, and from a paragraph to a list item.
However, it should be a different issue, because UnorderedListItemComponent doesn't uses ProxyDocumentComponent. Should I take a look at this?

I noticed a similar issue when moving the selection from a list item to a paragraph, and from a paragraph to a list item.

Let's solve both issues in this PR. The UX problem remains the same, regardless of whether the implementation details are different.

@angelosilvestre there are merge conflicts

@matthew-carroll I rebased and fixed the conflicts.


Makes brave-core dependency free

This reworks code and dependencies such that brave-core has a single
dependency on apache-thrift. This decouples us from changes in thrift
and also allows us to consider alternate thrift or otherwise codecs,
such as json or protobuf.
The key changes are local copies of validation code, and a switch from
slf4j to jul. Eventhough slf4j is used when you are using thrift
runtimes, it isn't used in codec. In other words brave-core works
without slf4j.
This also removes the jsr305 dep by using our own Nullable and switching
from PreDestroy to Closable (which are equivalent in Spring Framework).
Finally, this corrects the httpcomponents dependency setup such that it
properly masks and couples to brave-http.

@adriancole that's quick!
Going to have a closer look later today.
Thanks for the effort!

:+1:


About the release scheme

👋 while we are trying to bump the formula to the latest release, we found that the release did not get marked the latest release. While checking further, I found that the release notes was only added into 2.4. So raise this issue to confirm what would the practice for the future tags (this would affect whether we need to add livecheck practices, either just check the new tags, which is default strategy, or check the marked latest github releases). Thanks!
relates to https://github.com/Homebrew/homebrew-core/pull/155909

yeah, that sounds about right, thanks for confirming it.


Error: fromstring() in core/image/img_pil.py

Platform: Linux (OpenSuse, Ubuntu)
[INFO   ] [Kivy        ] v1.9.1
[INFO   ] [Python      ] v2.7.12 (default, Jul 01 2016, 15:36:53) [GCC]
Error:
File "/usr/lib64/python2.7/site-packages/kivy/core/image/img_pil.py", line 105, in save
image = PILImage.fromstring(fmt.upper(), (width, height), pixels)
File "/usr/lib64/python2.7/site-packages/PIL/Image.py", line 2063, in fromstring
"Please call frombytes() instead.")
Exception: fromstring() has been removed. Please call frombytes() instead.
In File "/usr/lib64/python2.7/site-packages/kivy/core/image/img_pil.py"
Line 105:
image = PILImage.fromstring(fmt.upper(), (width, height), pixels)
use...
image = PILImage.frombytes(fmt.upper(), (width, height), pixels)

Looks like an easy fix. Can you add an example to test this?

There is no easy example.... core.image save some image data string should do it....
https://groups.google.com/forum/#!topic/tilestache/bohED5JiHkI
Its just a simple maintenance of issue in "/usr/lib64/python2.7/site-packages/kivy/core/image/img_pil.py" that is not keeping up with deprecate calls, or the undocumented features of Pillow 3.x. Like it will now throw up an exception for "tostring()" and "fromstring()".
Prehaps all that is required is an exception trap so when or if according to version an exception thrown up by Pillow for fromstring(), then to use frombytes(). Same for any pillow implantation by kivy for tostring(). If the user has an earlier version of Pillow 2.x it will pass it off with a warning msg of a soon to be deprecate call.
If your read "http://pillow.readthedocs.io/en/3.1.x/reference/Image.html" documentation it is is almost as fuzzy as the kivy core.image image data implementation ;)

Never tried this before, but I've put in a pull request for changed version with exception trap?

@steve1805 I cant see the pull request you are talking about. Can you link to the pull request here or mention this issue(# 4710) in that thread  so github automatically links the two!

@udiboy1209 Don't know, it was the first and last time I have attempted this... to darn difficult, rage out time, my personal server version of github via git tools is far easier. I will keep it simple...
https://gist.github.com/steve1805/4fcc915b6195b19745b1dec44810af92

@steve1805 ahh you made one to your own fork! https://github.com/steve1805/kivy/pull/1 ! You had to make a PR to this repository ('kivy/kivy' and not 'steve1805/kivy'). You can follow this tutorial for future reference. Right now I'll make a PR myself using your file, don't worry :smile:


Many warnings during training

During training, I get tons of warning for Sequential, ConvStack, LSTM and etc.
The warning message is like this

"type " + obj.name + ". It won't be checked "
/opt/conda/envs/onset_model/lib/python3.6/site-packages/torch/serialization.py:292: UserWarning: Couldn't retrieve source code for container of type LSTM. It won't be checked for correctness upon loading.

Is it normal?
I created a new conda environment to run this code and installed all the dependencies via requirements.txt.

I haven't seen those errors, but only similar ones when I load a model from pickled checkpoints. I suspect for some reasons Python is not loading the source code of pytorch (Sequential and LSTM) and onsets-and-frames (ConvStack) from your file system.
It should be harmless though. Source code (accessed via inspect.getsourcefile) is only used for safety check.

As for the training, we train on 500,000 iterations, and each iteration contains 8 spectrograms. Am I right?
On my system, it shows that 70 hours are required to finish 500,000 iterations. Is it a reasonable speed? Or is it too slow?
I am asking the warnings because I am not sure if the training time is affected by it or not.

The speed looks fine. It took about a week for me to train for 1M iterations on a single 1080 Ti.


Example for MS projects?

Is your feature request related to a problem? Please describe.
I would like an example for MS projects that includes what versions it supports etc as I am a little confused on what versions of MS projects you can create add-ins for.

Hi @Dylanb-dev,
The list of supported Project versions is found under Office client application and platform availability for Office Add-ins
Project currently only supports a small set of Common APIs that were released with the JS platform's launch in 2013. You can create a sample Project add-in through yo office in the article Build your first Project task pane add-in.
Given the limited functionality that Project supports, we are not investing in further samples. You can request additional Project features in the Microsoft 365 Developer Platform Tech Community.


Literature pointers for better understanding the Cnn14_DecisionLevelAtt model

Hello, Thanks for the awesome repo.
I am new to Audio & SED domain. I have been using your arch for one of the recent Kaggle competition and getting decent result. Therefore, I would like to better understand details of Cnn14_DecisionLevelAtt
I have read the PANNs paper, but it mostly focuses on the CNN feature extractor part. I am interested in understanding why things are done in the way they are for the Cnn14_DecisionLevelAtt model ( basically everything beside the CNN feature extractor ).  Can you point me to some write-ups that explains this ?
Thanks

Hi, see this paper: https://arxiv.org/pdf/1710.00343 for the DecisionLevelAtt model. For audio tagging, it is suggested to use Cnn14. For SED, in our later experiments we find DecisionLevelMax also works well, sometimes even better than DecisionLevelAtt.

Hi, see this paper: https://arxiv.org/pdf/1710.00343 for the DecisionLevelAtt model. For audio tagging, it is suggested to use Cnn14. For SED, in our later experiments we find DecisionLevelMax also works well, sometimes even better than DecisionLevelAtt.

Thanks for pointers !

Thanks for pointers !

Hello, I just read the referenced paper. A couple of follow-ups.
Q1:
For audio tagging with weak label task,  which backbone architecture would you recommend ?  PANNs or the CRNNs + GLU model proposed in reference paper.
Q2.
For DecisionLevelMax, I have being using max aggregation to convert framewise_output to clipwise_output. I notice that the reference paper says it should be averaging. For audio tagging with weak label set-up, do you think that I am making a mistake in using the max ? Or is the max / average choice task dependent and should be tuned as hyper-parameter instead ?

Hello, I just read the referenced paper. A couple of follow-ups.
Q1:
For audio tagging with weak label task,  which backbone architecture would you recommend ?  PANNs or the CRNNs + GLU model proposed in reference paper.
Q2.
For DecisionLevelMax, I have being using max aggregation to convert framewise_output to clipwise_output. I notice that the reference paper says it should be averaging. For audio tagging with weak label set-up, do you think that I am making a mistake in using the max ? Or is the max / average choice task dependent and should be tuned as hyper-parameter instead ?

Hello, I have been using your arch for this Kaggle Competition. Now, I am at top3% and I am trying to make a modification to your architecture ( unsuccessfully) to get to top 1%.  😄 .  I am wondering if are willing to provide some insights and suggestion to my failed modification.
Background info:
I am using your PANNs DecisionLevelAttn to perform audio tagging on 60 secs long audio clips. With the interested events being extremely short ( average 1-2 secs). The objective is to do multi-class classification on 24 labels.
I notice that frequency is a good discriminator for the labels because events from each label is clustered around certain unique frequency band.
Intended modification idea:
 x = torch.mean(x, dim=3)

In my hypothesis, this step is throwing away a lot of useful info, as we just blindly mean aggregate away all the frequency info.
My idea is to apply some sort of simple linear attention and use a different aggregation scheme to obtain a unique feature representation to predict each label ( so that not useful frequency could be ignored ).
Assistance requested:
Unfortunately, my modification did not work out well. I am wondering if you have any tips on how you would modify the model to take advantage of the task specific insight I just described ?   I have summarized my modification below, and if you have any insight on what mistake I am making. It would also be very helpful.
My modification attempt:
Change 1
In init, I construct a unique linear attention layer (for frequency aggregation) and attention block to predict each label.
In code, it is
self.att_block = [ AttBlock(args.attn_size, 1, activation='sigmoid').cuda() for i in range(24) ]
self.attention_heads = [ nn.Linear(11, 1, bias=True).cuda() for i in range(24)]

Change 2
After the cnn feature extraction step, I send the representation to label_specific_forward and then concat each label prediction in the end.
 x = self.backbone.extract_features(x)

 o = [ self.label_specific_forward(x, idx, frames_num) for idx in range(24) ]

  clipwise_output = [item[0] for item in o]
  logit = [item[1] for item in o]
  framewise_output = [item[2] for item in o]

  clipwise_output = torch.cat(clipwise_output, dim=-1)
  logit = torch.cat(logit, dim=-1)
  framewise_output = torch.cat(framewise_output, dim=-1)

Change 3:
Inside the label_specific_forward, I use label specific frequency aggregation and label specific attention block ( with attention size being 1280 // num_lables to prevent over-parameterization )
x_freq_agg = self.attention_heads[idx](cnn_feature).squeeze(dim=-1)

# Copy past original implementation ...

(clipwise_output, norm_att, segmentwise_output) = self.att_block[idx](x)

Hi TacoKoala,
This looks an interesting challenge! I looked into this task, and found

the task is audio tagging, but not sound event detection. The Cnn14
architecture can perform better for audio tagging (mAP=0.43 on AudioSet)
compared to the DecisionLevelAtt system (mAP=0.39 on AudioSet). I am sure
the Cnn14 architecture will give you some surprise!
For change 1, one option is to use flatten operation to replace the mean
operation.
For change 2, for this kaggle task, framewise_output is not necessary. So
architectures such as Cnn14 can directly predict the clip-level probability.
For change 3, I was not successful using frequency domain attention in
audio tagging tasks. But I thought flatten frequency + fully connected
layer should work well.
P.S. Did you load the pretrained weights from PANNs? Load all weights and
finetune all weights will give the best performance.
Best wishes,
Qiuqiang
On Fri, 5 Feb 2021 at 01:49, TacoKoala<EMAIL_ADDRESS>wrote:

Hello, I have been using your arch for this Kaggle Competition
https://www.kaggle.com/c/rfcx-species-audio-detection/leaderboard. Now,
I am at top3% and I am trying to make a modification to your architecture (
unsuccessfully) to get to top 1%. 😄 . I am wondering if are willing to
provide some insights and suggestion to my failed modification.
Background info:
I am using your PANNs DecisionLevelAttn to perform audio tagging on 60
secs long audio clips. With the interested events being extremely short (
average 1-2 secs). The objective is to do multi-class classification on 24
labels.
I notice that frequency is a good discriminator for the labels because
events from each label is clustered around certain unique frequency band.
Intended modification idea:
x = torch.mean(x, dim=3)
In my hypothesis, this step is throwing away a lot of useful info, as we
just blindly mean aggregate away all the frequency info.
My idea is to apply some sort of simple linear attention and use a
different aggregation scheme to obtain a unique feature representation to
predict each label ( so that not useful frequency could be ignored ).
Assistance requested:
Unfortunately, my modification did not work out well. I am wondering if
you have any tips on how you would modify the model to take advantage of
the task specific insight I just described ? I have summarized my
modification below, and if you have any insight on what mistake I am
making. It would also be very helpful.
My modification attempt: Change 1
In init, I construct a unique linear attention layer (for frequency
aggregation) and attention block to predict each label.
In code, it is
self.att_block = [ AttBlock(args.attn_size, 1, activation='sigmoid').cuda() for i in range(24) ]
self.attention_heads = [ nn.Linear(11, 1, bias=True).cuda() for i in range(24)]
Change 2
After the cnn feature extraction step, I send the representation to
label_specific_forward and then concat each label prediction in the end.
x = self.backbone.extract_features(x)
o = [ self.label_specific_forward(x, idx, frames_num) for idx in range(24) ]
clipwise_output = [item[0] for item in o]
logit = [item[1] for item in o]
framewise_output = [item[2] for item in o]
clipwise_output = torch.cat(clipwise_output, dim=-1)
logit = torch.cat(logit, dim=-1)
framewise_output = torch.cat(framewise_output, dim=-1)
Change 3:
Inside the label_specific_forward, I use label specific frequency
aggregation and label specific attention block ( with attention size being
1280 // num_lables to prevent over-parameterization )
x_freq_agg = self.attention_headsidx.squeeze(dim=-1)
Copy past original implementation ...
(clipwise_output, norm_att, segmentwise_output) = self.att_blockidx
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/qiuqiangkong/audioset_tagging_cnn/issues/32#issuecomment-773491386,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADFXTSJPOFDS7EBFCQ2ZFITS5LM3JANCNFSM4WQFRSEA
.

Will try the CNN14 arch. Thanks for the suggestion

Will try out the flatten + fully connected suggestion

PANNs's backbone is not effective for this particular task. I am using efficientnet-b4 as backbone

Empirically max of framewise_output is a lot better than clipwise_output ( even with same model). The difference could be as large as 6% on leader board. My intuition is that maybe framewise_output is better at detecting short event ? ( Since most event of interest is 1-2 secs )

Hi TacoKoala,
Thanks for the observations! This may indicate that the data is very

weakly labelled, that is the sound event only appear a very short time in
the 60-second audio clip. In this case, removing the .mean() from .mean() +
.max() in the global pooling layer might help?
Best wishes,
Qiuqiang
On Fri, 5 Feb 2021 at 02:25, TacoKoala<EMAIL_ADDRESS>wrote:

Will try the CNN14 arch. Thanks for the suggestion
2.
Will try out the flatten + fully connected suggestion
3.
PANNs's backbone is not effective for this particular task. I am using
efficientnet-b4 as backbone
4.
Empirically max of framewise_output is a lot better than
clipwise_output ( even with same model). The difference could be as large
as 6% on leader board. My intuition is that maybe framewise_output is
better at detecting short event ? ( Since most event of interest is 1-2
secs )
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/qiuqiangkong/audioset_tagging_cnn/issues/32#issuecomment-773513237,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADFXTSJ6FE3VSPDUCXOHOUTS5LRA5ANCNFSM4WQFRSEA
.

I have a additional question regarding this detail
x = x.transpose(1, 3)
x = self.bn0(x)
x = x.transpose(1, 3)

We are using bn layer to learn the best frequency axis normalization transform instead of just using the computed stats from the training data ?   Does this trick have a name in the literature ?  Does it typically work better than just using the fixed stats ?
Also why do we just stop at freq axis only, why don't we do it over time axis as well ?
EX:
x = x.transpose(1, 3)
x = self.freq_bn0(x)
x = x.transpose(1, 3)

x = x.transpose(1, 2)
x = self.time_bn0(x)
x = x.transpose(1, 2)

Hi TacoKoala,
In the past, people usually normalize each channel (frequency bins),

including substract mean value and divide the standard value. Notice the
mean and standard value is calculated over the whole dataset. We use bn to
replace operation, and there is no name for this yet. In the past, the
normalization is only done in the frequency domain, but not the time
domain. Hope it helps!
Best wishes,
Qiuqiang
On Mon, 8 Feb 2021 at 02:06, TacoKoala<EMAIL_ADDRESS>wrote:

I have a additional question regarding this detail
x = x.transpose(1, 3)
x = self.bn0(x)
x = x.transpose(1, 3)
We are using bn layer to learn the best frequency axis normalization
transform instead of just using the computed stats from the training data ?
Does this trick have a name in the literature ? Does it typically work
better than just using the fixed stats ?
Also why do we just stop at freq axis only, why don't we do it over time
axis as well ?
EX:
x = x.transpose(1, 3)
x = self.freq_bn0(x)
x = x.transpose(1, 3)
x = x.transpose(1, 2)
x = self.time_bn0(x)
x = x.transpose(1, 2)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/qiuqiangkong/audioset_tagging_cnn/issues/32#issuecomment-774723211,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADFXTSOFYK6HZ7DPKPW4RL3S53JBVANCNFSM4WQFRSEA
.

help a lot！ Try to follow~


codeunit 22 "Item Jnl.-Post Line"

Business process:
The setup allows sales in minus. We sell Item1 from Location1, posting date of sale is 20.01.2023 and after 2 days, to increase the quantity we transfer item1 from location2 to Location1, but the posting date is 18.01.2023.
On posting the transfer receipt we have the error: "There is no Value Entry in filter:..."
This happend in this place

Because in function InsertTransferEntry system at first create "Item Application Entry" and after that Item Ledger Entry and Value Entry.
local procedure InsertTransferEntry(var ItemLedgEntry: Record "Item Ledger Entry"; var OldItemLedgEntry: Record "Item Ledger Entry"; AppliedQty: Decimal)
    var
        NewItemLedgEntry: Record "Item Ledger Entry";
        NewValueEntry: Record "Value Entry";
        ItemLedgEntry2: Record "Item Ledger Entry";
        IsReserved: Boolean;
        IsHandled: Boolean;
    begin
        with ItemJnlLine do begin

            ....

            OnInsertTransferEntryOnBeforeInsertApplEntry(NewItemLedgEntry, ItemLedgEntry);
            if AverageTransfer then begin
                InsertApplEntry(
                  NewItemLedgEntry."Entry No.", NewItemLedgEntry."Entry No.", ItemLedgEntry."Entry No.",
                  0, NewItemLedgEntry."Posting Date", NewItemLedgEntry.Quantity, true);
                NewItemLedgEntry."Completely Invoiced" := ItemLedgEntry."Completely Invoiced";
            end else begin
                InsertApplEntry(
                  NewItemLedgEntry."Entry No.", NewItemLedgEntry."Entry No.", ItemLedgEntry."Entry No.",
                  OldItemLedgEntry."Entry No.", NewItemLedgEntry."Posting Date", NewItemLedgEntry.Quantity, true);
                NewItemLedgEntry."Completely Invoiced" := OldItemLedgEntry."Completely Invoiced";
            end;

              ...

            ApplyItemLedgEntry(NewItemLedgEntry, ItemLedgEntry2, NewValueEntry, true);  // issue here
            AutoTrack(NewItemLedgEntry, IsReserved);

            OnBeforeInsertTransferEntry(NewItemLedgEntry, OldItemLedgEntry, ItemJnlLine);

            InsertItemLedgEntry(NewItemLedgEntry, true);
            InsertValueEntry(NewValueEntry, NewItemLedgEntry, true);

            UpdateUnitCost(NewValueEntry);

            OnAfterInsertTransferEntry(ItemJnlLine, NewItemLedgEntry, OldItemLedgEntry);
        end;
    end;

@Andrei Panko - any recommendations about this request?

Sorry about the long reply-time on this issue. I wasn't aware that this many bugs had been filed here, and hence wasn't monitoring this repo.
Unfortunately, this repository is only for extensibility requests for Dynamics 365 Business Central or pull requests towards the 1st party Business Central apps. We suggest that you open a support case or file a bug to ensure that all Business Central users benefit from your catch as soon as possible:
On premises - https://support.microsoft.com/en-us/supportforbusiness/productselection?sapId=93d37907-ad94-d591-22e9-593cfa09dd3f
Cloud – contact your partner, or if you are a partner open a support incident through Partner Center - https://partner.microsoft.com/en-us/pcv/dashboard/overview


Projects opened with devcontainer have 'vscode' as the organization name

By default we take user name as the organization name. Default user of the VSCode dev containers is vscode, which will be confusing for new users.
So best option is consider generating a default value in Ballerina.toml file.

Related issue: https://github.com/ballerina-platform/ballerina-lang/issues/29623

@sameerajayasoma how about myorg


Add variable for whole hostname

Hi,
It would be nice to have a variable that contains the whole hostname and not only parts of it like ${gitorigin.hostname,n}.
So maybe ${gitorigin.hostname} (without the index) could work.
I am using a self hosted bitbucket server and currently my config is:
"gitblame.commitUrl": "https://git.company.com/projects/${gitorigin.path,0}/repos/${project.name}/commits/${hash}"

I know I can do something like
${gitorigin.hostname,0}.${gitorigin.hostname.1}.${gitorigin.hostname,2}/path

but thats ugly and https:// is not included.
Another approach is to support self hosted bitbucket servers out of the box.
See also https://github.com/Sertion/vscode-gitblame/issues/98

Hey Florian!
Have you tried gitorigin.hostname without an argument?
Sadly I will never be able to guess a remote hosts preferred protocol in a satisfying way so that part (http(s)://) still needs to be manually determined.

If this remains an issue please comment again and I will re-open this issue.


Add s3 support

add board.cmake to explicitly set IDF_TARGET (to s2 or s3)
add s3 devkit c and devkit m
update tinyusb

fix net_device.c file changes
rename dcd_transdimension to chipidea
st synopsys to dwc2

Oh that's crazy - I was working on trying to get S3 going on Tuesday, and got close, but was not able to get past the last few compile errors... and then today I see this!
Gonna give it a whirl now!

Oh that's crazy - I was working on trying to get S3 going on Tuesday, and got close, but was not able to get past the last few compile errors... and then today I see this!
Gonna give it a whirl now!

Let me know if you spot any issue

Oh that's crazy - I was working on trying to get S3 going on Tuesday, and got close, but was not able to get past the last few compile errors... and then today I see this!
Gonna give it a whirl now!

Let me know if you spot any issue

It's actually working great! I have created folders for my 3 new ESP32-S3 boards, and built all of them and they boot perfectly - except I've not been able to build CircuitPython for the S3, so I don't have anything to copy onto them to check that - yet ;)
Thanks for getting this working. I can see from your PR what things I missed when I tried. Not sure I'd ever have found them all :)

you could use the uf2 for s3 devkitc to test with https://github.com/adafruit/circuitpython/tree/main/ports/espressif/boards/espressif_esp32s3_devkitc_1 . I have tested it before switching the uf2 family for S3 to new ID. For now, you need to wait for the https://github.com/adafruit/circuitpython/pull/5771 to update the family id.


The order of description changes when parsing search conditions

Conditions in parentheses are output first.
I want them to be output in the order they are written.

Will be supported in #38


Allow GLBoolean in pixelStorei

related to https://github.com/microsoft/typescript/issues/27542

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: AVGP sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

The reason for this change is that while the GL spec specifies the type for param to be GLint, the table in https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/glPixelStore.xhtml demonstrates that GLboolean is a valid type, depending on the parameter to be set.

Is it possible to use overloads to enforce the correct type based on the specific parameter being set?  That would be ideal if it's possible to do so.

You’d have to use literal types, but this requires the value of the GLenum constants to be known at compile time - if they aren’t compile-time constants (e.g. members of an enum, or known numeric values) then you can’t do it.
Just to illustrate the concept if you aren’t familiar with it:
func(control: 0, value: number);
func(control: 1, value: string);

So for the above function, if you pass 0 as the first arg, the second must be a number, if the first arg is 1 you have to pass a string.
I have a feeling the gl.CONSTANT_NAME values might not be static constants and/or are browser-specific though (so you couldn’t put them into an enum). :(

@fatcerberus I looked at WebGl 1.widl and it defines GLenum as unsigned long. Then there are lots of related constants in WebGLRenderingContextBase, but the generated d.ts doesn't include their values. It should. But this requires a change to the generator code, which I'm not up to speed on yet.
I would also need to find out if widl supports overloads discriminated by integer literal types. If not, then the change would have to go in overridingTypes.json (I think).
@AVGP It turns out that this change WAS in dom.generated.d.ts, but it got lost when we switched away from IE's idl files to standard ones. Can you just copy the change from #178 instead of adding an overload? I think it's better for the simple fix.

This is deprecated by #638


change pin layout

Hallo,
for the library its possible to define RST and SS pin like this:
#include <MFRC522.h>
#define RST_PIN         9
#define SS_PIN          10
MFRC522 mfrc522(SS_PIN, RST_PIN);
Is it also possible to define MOSI, MISO and SCK?
thanks

No, it is hardware defined.

Can be closed.


Axis-triggered tooltip failed to display some series if x axis values are not 100% equal!

[x] I am using English in this issue. 在这个 Issue 中我使用了英文（强烈建议）。

General Questions

[x] Required: I have read the document and examples and tried to solve it by myself. （必填）我读过了文档和教程，并且曾试图自己解决问题。
[x] Required: I have searched for similar issues and that didn't help. （必填）我搜索过 issue 但是没有帮助。
[x] Required: I have tried with the latest version of ECharts and still have this problem. （必填）我试过最新版本的 ECharts，还是存在这个问题。

In this issue, I have provided information with: 在这个 issue 中我提供了以下信息：

[x] Required: issue type；（必填）issue 类型
[x] Required: one sentence description in issue details；（必填）一句话的问题描述
[x] Required: demo；（必填）能反映问题的例子（如果你想提问或报 bug）
[x] Required: ECharts version；ECharts 版本

Issue Type

[ ] I have a question to ask about how to use ECharts to ...；我想提问如何使用 ECharts 实现某功能
[x] I have a bug to report；我想要报 bug
[ ] I have a feature to request, e.g.: I'd like a new feature that ...；我需要一个新功能
[x] I have a feature to enhance, e.g.: The current feature should be improved in the way that ...；我希望改进某个功能
[ ] There's something wrong with the documents；文档有些问题
[ ] Others, or I'm not sure which issue types to choose here；其他，或我不知道应该选什么类型

Issue Details

Axis-triggered tooltip failed to display some series if x axis values are not 100% equal!
Expected Behavior

Axis-triggered should always show the nearest data index of all series, like this:
series1: 5
series2: 5

Current Behavior

It always shows one of the series, but never both.
Online Example

http://jsfiddle.net/sh1acjqu/3/

This is my chart options:
{
            title: {
                text: 'ECharts 入门示例'
            },
            tooltip: {
                trigger: "axis"
            },
            legend: {
                data:['销量']
            },
            xAxis: {
                type: "time"
            },
            yAxis: {},
            series: [{
                name: 'series1',
                type: 'line',
                data: [[1544770701,5], [1544770703,20], [1544770805,36]]
            },{
                name: 'series2',
                type: 'line',
                data: [[1544770702,5], [1544770704,20], [1544770806,36]]
            }]
        }

The stated problem is caused by these lines: lib/component/axisPointer/axisTrigger.js#198-203, I don't know the purpose of these codes, but when i comment out line 198~203, the resulted behavior is what i want.
If you guys think this is a wanted behavior, then i request an option to do this.
 // if (dist < minDist || diff >= 0 && minDiff < 0) {
      //   minDist = dist;
      //   minDiff = diff;
      //   snapToValue = seriesNestestValue;
      //   payloadBatch.length = 0;
      // }

Topics

[ ] Legend
[x] Tooltip
[ ] Event
[ ] Performance
[ ] SVG
[ ] Map
[ ] ECharts GL
[ ] Third-party libraries, e.g.: Vue.js, React

Anything Else We Need to Know

Environment

ECharts version；ECharts 版本: 4.2.0-rc.2 / 3.7.2  (it happens in both version, you can try in js fiddle)

[ ] It happens only on certain browsers or operating systems. 对于特定浏览器或操作系统才会出现的问题，请提供相应环境信息：{BROWSER_VERSION_OR_OS_INFORMATION_HERE}

Because the x value of the two series are not the same. The first one is<PHONE_NUMBER> and the second one is<PHONE_NUMBER>. But I think this should be improved so that all series are shown in tooltip when trigger is set to be axis.

As @Ovilia mentioned, I think if you intent to display both series in a tooltip, the x value should be the same.
If we make all of the series displayed in tooltip mandatorily in this case,
when a axisPointer is on a X value and some series do not have Y value corresponding to that x value,
which data item should be selected to show on tooltip?
I think it is not reasonable enough to choose a closest item to show on tooltip, because it may miss leading the readers.

option = {
    title: {
        text: '折线图堆叠'
    },
    tooltip: {
        trigger: 'axis'
    },
    legend: {
        data:['邮件营销','联盟广告']
    },
    grid: {
        left: '3%',
        right: '4%',
        bottom: '3%',
        containLabel: true
    },
    toolbox: {
        feature: {
            saveAsImage: {}
        }
    },
    xAxis: {
        type: 'value',
        boundaryGap: false,

    },
    yAxis: {
        type: 'value'
    },
    series: [
        {
            name:'邮件营销',
            type:'line',
            stack: '总量',
            data:[[2,120],[3,200]]
        },
        {
            name:'联盟广告',
            type:'line',
            stack: '总量',
            data:[[2,400],[6,300]]
        },

    ]
};

I also meet a problem when the two lines xAxis is different. The second line is wrong, why?  cloud you help me ?

Any update on this?

I think it's reasonable to display the two series if x axis has snap setting to be true.
Let's see what we can do after we fix #7651.

Maybe same as #15488 ?


Add grpc-java 1.51.0 to client_matrix.py

Ad-hoc run: https://source.cloud.google.com/results/invocations/cad10fd9-a98a-4f0d-b519-c461b00dea92

The interop job is broken. This is on hold until the job is fixed.

The job fixed in https://github.com/grpc/grpc/pull/31709.
New adhoc run after a rebase: https://source.cloud.google.com/results/invocations/3eed742d-54f6-4d35-8b85-b1b52202b998


redirect() uses server root instead of application root

I've run into an issue when using bottle in a subdirectory of the server root.
Steps to reproduce:

Build a simple app in a subdirectory of the server root (CGI works good for that).
Put redirect("/") into a route.
Call the route. You'll be redirected to the server root instead of the application root.

This issue makes it difficult to build apps that are deployed in different paths. The cause of the problem is that redirect() uses urljoin() on the request URL. If the target contains a leading slash, everything after the host part of the URL gets replaced. This could also lead to problems when using mount(), though I haven't tested it yet.
Workarounds:

Build your own redirect function that prepends the application root directory
Add request.script_name to every redirect (ugly)
modify redirect() so that it always includes request.script_name (hackish)

The problem with request.script_name is that in some cases it includes the name of the .py file which would lead to ugly URLs, especially when using CGI on Apache with mod_rewrite. A more sustainable solution would be the introduction of a application root variable (which can be "/" by default). The root path could be set in run() or in a special function. When it is set, all redirects are based on that path.
One could also add the path to SimpleTemplate.defaults to include it in template URLs, but a more beautiful solution for that would be a special markup for URLs (maybe {# #} or similar).

You can use bottle.get_url("named_route")


Portia install on windows

Hi, i tried Vagrant and docker to install Portia on windows but always get errors, maybe somebody have step by step guide to install correctly? Or ready to use VMware or Virtualbox image?

Which instructions did you follow? The most up to date instructions and scripts can be found here

I tried this

mkdir portia
cd portia
git clone https://github.com/scrapinghub/portia.git
cd portia
git checkout update_installation
mkdir ~/data
cd portiaui
npm install && bower install
cd node_modules/ember-cli && npm install && cd ../../ && ember build
cd ..
docker build -t portia:v1 .
docker run -i -t --rm -p 9001:9001 -v ~/data:/app/data/projects ~/portia/portia/portiaui/dist:/app/portiaui/dist portia:v1
Point a browser to localhost:9001

Did it work? Did you try to use the vagrant instructions?

Yes i tried this. But i get an error.
On 21 Feb 2017 1:07 p.m., "Ruairi Fahy"<EMAIL_ADDRESS>wrote:

Did it work? Did you try to use the vagrant instructions?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/scrapinghub/portia/issues/711#issuecomment-281312862,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGlayxW5-cEiz42GgmAvhmVE3GDQGEpZks5resWAgaJpZM4MG670
.

Maybe you can sent me step by step instruction with "vagrant" maybe i do something wrong?

Sorry for writing again, but maybe somebody can help me install PORTIA on Windows or on Ubuntu? I am trying 3 days, nothing helped.  Please sent me step by step instructions ar contact me by skype:devensonas for helping me...

Vagrant instructions are here

Install using docker i get error:
devensonas@ubuntu:~$ sudo docker run -i -t --rm -v projects:/app/data/projects:rw -p 9001:9001 scrapinghub/portia /app/slyd/bot.py:40: ScrapyDeprecationWarning: scrapy.spider.BaseSpider is deprecated, instantiate scrapy.spider.Spider instead.   spider = BaseSpider('slyd') /app/slyd/tap.py:59: ScrapyDeprecationWarning: scrapy.settings.CrawlerSettings is deprecated, instantiate scrapy.settings.Settings instead.   crawler_settings = CrawlerSettings(settings_module=slyd.settings) /usr/local/lib/python2.7/dist-packages/scrapy/settings/__init__.py:170: ScrapyDeprecationWarning: Settings.overridesattribute is deprecated and won't be supported in Scrapy 0.26, useSettings.set(name, value, priority='cmdline')instead   if opt_name in self.overrides: /usr/local/lib/python2.7/dist-packages/scrapy/settings/__init__.py:174: ScrapyDeprecationWarning:Settings.defaultsattribute is deprecated and won't be supported in Scrapy 0.26, useSettings.set(name, value, priority='default')` instead
if opt_name in self.defaults:
/usr/local/lib/python2.7/dist-packages/twisted/internet/_sslverify.py:184: UserWarning: You do not have the service_identity module installed. Please install it from https://pypi.python.org/pypi/service_identity. Without the service_identity module and a recent enough pyOpenSSL tosupport it, Twisted can perform only rudimentary TLS client hostnameverification.  Many valid certificate/hostname mappings may be rejected.
verifyHostname, VerificationError = _selectVerifyImplementation()
2017-02-23 06:23:09+0000 [-] Log opened.
2017-02-23 06:23:09+0000 [-] twistd 14.0.0 (/usr/bin/python 2.7.3) starting up.
2017-02-23 06:23:09+0000 [-] reactor class: twisted.internet.epollreactor.EPollReactor.
2017-02-23 06:23:09+0000 [-] Site starting on 9001
2017-02-23 06:23:09+0000 [-] Starting factory <twisted.web.server.Site instance at 0x467f518>
`
in firefox:
`No Such Resource
No such child resource.`
What is wrong?

You need to mount the dist directory too so that assets are available in the docker image

How to do this?
On 23 Feb 2017 11:15 a.m., "Ruairi Fahy"<EMAIL_ADDRESS>wrote:

You need to mount the dist directory too so that assets are available in
the docker image
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/scrapinghub/portia/issues/711#issuecomment-281937385,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGlay1gkuboOgtAXRNBIxAMWIqMcoUf7ks5rfU4fgaJpZM4MG670
.

Sorry but Vagrant isn't work either. I tried several time and still the issue there.
==> default: Installing collected packages: slybot
==> default:   Running setup.py develop for slybot
==> default:
==> default:     warning: no files found matching 'slybot/splash-script-combined.js'
==> default:     Creating /usr/local/lib/python2.7/dist-packages/slybot.egg-link (link to .)
==> default:     Adding slybot 0.13.0b28 to easy-install.pth file
==> default:     Installing slybot script to /usr/local/bin
==> default:     Installing portiacrawl script to /usr/local/bin
==> default:
==> default:     Installed /vagrant/slybot
==> default: Successfully installed slybot
==> default: Cleaning up...
==> default: Executing command: configure_nginx
==> default: Executing command: configure_initctl
==> default: Starting slyd service
==> default: =====================
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

The correct install instructions can be found here


if subtitles is None model gives an error .... how to infere without subtitles?

In generate_prediction() function, instead of if gen_subtitles change it to if not gen_subtitles:

You could also pass subtitles as an empty list to match_frames_and_subtitles, inside the prepare_input method, in minigpt4_video_inference.py
Make sure to comment out the call to extract_subtitles since that fails for subtitle_path=None
The above changes would reduce the model to working only with the image frames.


wrong expected dataurl value in upload.dataUrltoBlob in chrome

I'm getting an error when trying to use ngf-resize or ngf-size directives on images. My code:
controller
function ProducerController($scope, Uploader) {
        var vm   = this;
        vm.files = [];
        vm.show = function() {
            console.log(vm.files);
        };
    }

partial

        <input type="file" ngf-select ng-model="vm.files" name="file" multiple>

      {{file.name}}

Error occurs in upload.dataUrltoBlob function, ng-file-upload.js:1583:
upload.dataUrltoBlob = function (dataurl, name) {
   var arr = dataurl.split(','), mime = arr[0].match(/:(.*?);/)[1],

In debugger, value of dataurl is "data:,", so the match() result is null.
Works ok on firefox though.
my chromium:
Version 47.0.2526.80 Built on 8.2, running on Debian 8.2 (64-bit)

ngf-resize is designed to be used on the same element as ngf-select or ngf-drop.
It should not work with ngf-sec or thumbnail.


Fabric8 2.0.21 & hawtio 1.4.45 upgrade

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/jube-master-pullreq/174/
Test FAILed.

Retest this please

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/jube-master-pullreq/175/
Test PASSed.


Update MessageComposer.jsx

Mobile number with 13 digit include country code (India)

Hi @jabeermk
The maximum length of a phone number depends on the country code. As a result, the suggestion you provided isn't sufficient; we would need to ensure that only phone numbers in India (country code +91, I assume) are validated to have 13 digits.
However, this approach becomes impractical if we need to write custom validation logic for each country code. Therefore, I believe the best solution is to use an existing library for phone number validation. Would you be able to do that for us?
Additionally, keep in mind that I am working in a big UI refactor in the branch revamp-ui; so you might want to wait until that is merged before putting too much effort in this validation.


Adding some new tools to the list

Hi community,
here at Corunet by Sngular are developing some interesting tools using your awesome specification. They are close to mature, so we want to share them with you. If you consider them interesting to add them to your available tool list, we will be pleased.
Maven plugin to generate Spring cloud stream code base on Asyncapi and OpenApi
https://github.com/corunet/scs-multiapi-plugin
Maven plugin to generate Spring cloud Contracts base on Asyncapi and OpenApi
https://github.com/corunet/scc-multiapi-converter
Cheers

@jemacineiras Hi! We are happy with these projects! If you wanna add them to our list, you should update that md file and create PR https://github.com/asyncapi/website/blob/master/pages/docs/tools/index.md Let me know if you will have any problems :) Of course, if you won't find appropriate category, please create the new one.

Side comment: really cool to see my fellow Spanish devs contributing to AsyncAPI 🙌

Hi @akshatnema,
The proposed solution looks interesting, if the tool is only using asyncapi, but in our case, our tools give support for openapi and asyncapi, and we don't like to attach the project to only one API solution, just in case openapi decide the same, or we want to integrate future solutions...
So we prefer the second approach, what your thoughts about?
Cheers!

Fine, thanks for your feedback. So, if you prefer the second approach, you need to add the details of your tool in a markdown file in the website in the website, with the appropriate technologies used and the links of the tool. That markdown information will be converted to JSON and then rendered on the website as other tools. Right now, the format of the markdown file has not been decided yet and we are proceeding with the first approach right now.
The reason why we primarily focus on first is that we want the tools to be discovered automatically using API searching instead of manually adding them to the website repository. Hence, we are forwarding that. @derberg, anything more you want to add?


[No ticket] Properly support "q" query-param on institution discover page

Ticket: [No ticket]
Feature flag: n/a

Purpose

Support the q query-param for search-text on institution discover page

Summary of Changes

Update query-param variable name to match what the controller is expecting

Screenshot(s)

Query-param isn't added/used because of this name mismatch

Side Effects

None

QA Notes

typing something in the search text box of the institution discover page should now update the q query-param in the URL
Loading into a page with the q query-param set should now auto-populate the search text box

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.006%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/institutions/discover/controller.ts
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6070

Relevant Lines:
8546

💛  - Coveralls


Optimise and fix Linux packages installation

Try to reorder calls to update the package lists, upgrade the current installed packages, and install new packages to minimize network calls. Some fixes along the way. Make sure that installing packages updates the package lists first.
Most package managers don't have a package download cache enabled, but pacman does. Cleaning the pacman dl cache recovers ~112M (with libx11 as a dependency, YMMV: depends whether new packages have been published since the build of the base image).
Some package managers require package lists to be available before upgrading/installing packages (apt), others will automatically download them. Be conservative, and keep the package lists in all cases.
opam can't download the package lists if the package manager doesn't do it automatically, and will fail the opam depext install if so.
There's no particular need to crunch the lines into simpler layers, since the images are later squashed.

I’m not sure why I was asked for a review if it’s going to be merged the next day (weekend) without any input.
There is a problem on distributions using yum: yum clean all removes the package database.

I’m not sure why I was asked for a review if it’s going to be merged the next day (weekend) without any input.

You're right, I should have left this waiting longer, sorry.

There is a problem on distributions using yum: yum clean all removes the package database.

(This wasn't changed in this PR)
That's right, but yum and dnf have the courtesy of fetching the package database if it doesn't exist, so opam depext will not fail. yum clean packages is probably more efficient. The package database for Fedora is ~110Mb, so there's a case for including it in the image even if it's heavy, to avoid re-downloading it every time.

(This wasn't changed in this PR)

it was because the database was redownloaded at the next yum install just after.


pad the Client Initial packet to the required minimum size

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@515babb). Click here to learn what that means.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master     #907   +/-   ##
=========================================
  Coverage          ?   90.65%
=========================================
  Files             ?       93
  Lines             ?     6393
  Branches          ?        0
=========================================
  Hits              ?     5795
  Misses            ?      383
  Partials          ?      215

Impacted Files
Coverage Δ

packet_packer.go
85.51% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 515babb...8e0a0db. Read the comment docs.

This PR is currently wrong. We can't just add padding at the end of the packet, since the STREAM frame carrying the ClientHello doesn't have the data length set.

Fixed that. Just can't come up with a good unit test for this, but this is guaranteed to fail the integration test immediately, so it should be safe to merge.

This currently fails because of a problem with the TLS crypto setup. We're sending packets as Client Initials that are actually not Client Initials. We would have to transition away from packet type ClientInitial immediately after sending a ClientInitial, however, this requires that we properly handle Server Stateless Resets (because we need to send the regenerated Client Hello then).
Merging this probably has to wait until #893 is fixed.

Superseeded by #1001.


Changes in output from updates of segmentation/fulltext models

Just noticed that grobid extracts different infromation from this pdf:
JPS0710709-CC.pdf
after these changes:

93526704f855f57fd39140bf3681e84c65e744b2 for fulltext model and
d16317564dfae4e94f1d2b54abc85a255d576908 for segmentation model

Well, as you can imagine, it's not that bad to have some changes after the update of the models ;)
Could you point to the new problem? The figures I guess? As there's really too few training data for this two particular models (especially the full text model), they are sensitive to regression issues, the best is to add more training data to get stability.

Sure!
My idea was to share the file to be added as training data. In fact there are several differences. The biggest one is:

the first row of page 2 is missing
page 6:  [18] Such a temperature dependence [...] is not there...

Let me know if you need more details.

To be more precise, it's the new segmentation model the source of the changes. Just for information.

This is corrected as of grobid 0.7.0


[WIP] Handle SBT_OPTS in bash

Fixes https://github.com/sbt/sbt/issues/4193

@iwamatsu0430 Thanks! Could you add -no-colors here? - https://github.com/sbt/sbt-launcher-package/blob/master/citest/test.sh#L20

When will this be merged?
Seems like updating the CI script should be a separate PR.

I guess you're right.

$ export SBT_OPTS="-Xms2048M -Xmx2048M -Xss2M -XX:MaxPermSize=512M"
$ sbt
....
[error] Expected symbol
[error] Not a valid command: -
[error] Expected end of input.
[error] Expected '--'
[error] Expected 'debug'
[error] Expected 'info'
[error] Expected 'warn'
[error] Expected 'error'
[error] Expected 'addPluginSbtFile'
[error] -Xms2048M
[error]  ^

I need to revert this PR.

I thought that was the issue this PR solves?
On Mon, Jul 30, 2018, 6:40 PM eugene yokota<EMAIL_ADDRESS>wrote:

$ export SBT_OPTS="-Xms2048M -Xmx2048M -Xss2M -XX:MaxPermSize=512M"
$ sbt
....
[error] Expected symbol
[error] Not a valid command: -
[error] Expected end of input.
[error] Expected '--'
[error] Expected 'debug'
[error] Expected 'info'
[error] Expected 'warn'
[error] Expected 'error'
[error] Expected 'addPluginSbtFile'
[error] -Xms2048M
[error]  ^
I need to revert this PR.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sbt/sbt-launcher-package/pull/232#issuecomment-409035175,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGAUNnc7Jedx-9uyEPE9dY3sXw1suZ7ks5uL4tMgaJpZM4Uu9b_
.

Actually shouldn't that either be JAVA_OPTS or have -J in front of each
option?
On Mon, Jul 30, 2018, 6:54 PM Naftoli Gugenheim<EMAIL_ADDRESS>wrote:

I thought that was the issue this PR solves?
On Mon, Jul 30, 2018, 6:40 PM eugene yokota<EMAIL_ADDRESS>wrote:

$ export SBT_OPTS="-Xms2048M -Xmx2048M -Xss2M -XX:MaxPermSize=512M"
$ sbt
....
[error] Expected symbol
[error] Not a valid command: -
[error] Expected end of input.
[error] Expected '--'
[error] Expected 'debug'
[error] Expected 'info'
[error] Expected 'warn'
[error] Expected 'error'
[error] Expected 'addPluginSbtFile'
[error] -Xms2048M
[error]  ^
I need to revert this PR.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sbt/sbt-launcher-package/pull/232#issuecomment-409035175,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGAUNnc7Jedx-9uyEPE9dY3sXw1suZ7ks5uL4tMgaJpZM4Uu9b_
.

I've been using SBT_OPTS like JAVA_OPTS, I guess.
Adding -J didn't help, and changes like this should maintain backward compatibility if possible.

Neither SBT_OPTS or .sbtopts works in 1.2.7.


[REQ] Battery Stats (KB & Mouse/Trackpad)

Could you incorporate BT keyboard and trackpad battery stats please?

This would be a bit tricky since not everyone uses bluetooth keyboard and trackpads, and some even use multiple bluetooth keyboards and trackpads. For that, I have no desire for adding this feature as of this moment. Thanks for understanding.


feat(safe-claiming-app): add support for investor vestings

What it solves
Adds the investor allocation to the display of claimable / vested amounts.
Open tasks

[x] adjust unit tests
[x] enable transactions which only setDelegate without claiming (amount = 0)
[x] refactor: use addresses from hosted vesting data
[x] chore: In staging use the staging claiming app data

Resolves #561
How this PR fixes it
How to test it
Screenshots

Morning! I see that the claim button is now enabled by default and I don't think that is expected :(
Also, my delegate preferences do not seem to persist after I set one and re-enter the app.
Here is a lil video:
https://user-images.githubusercontent.com/92332710/199435515-d77becad-926b-4097-8d71-7c3362068a9a.mp4
With the investor airdrop I see that on the revamp interface the total number of tokens to claim are present on the UI widget but in legacy web it comes as 0:

My guess is that this is expected for now as I am checking this in legacy prod but will we need a deployment for this on the legacy web?
Cheers!

I think having the button enabled is expected since you should be able to just set a delegate without claiming. That being said is not clear for the user because there is no explanation that having the field empty or putting a 0 is just setting a delegate. Also the button says "Claim and delegate".
I think we should, or make the button say just "Set delegate" if the input is empty or "0", and add in the tooltip bellow that explanation; "Leave the field empty or set it to 0 if you just want to set a new delegate"

Today the claiming for "Investors" has been enabled. I was able to claim tokens just fine.
https://safe-web-core.staging.5afe.dev/gor:0x12A9ce973D9b8DA345E77Cd5D0E07186A864E1D2/transactions/tx?id=multisig_0x12A9ce973D9b8DA345E77Cd5D0E07186A864E1D2_0x0fb8afb7e604bb24801931bf7e340b412845e5c487314b7f2165413a45e3fdf7
I was also able to claim tokens with other 2 safes that are just regular users:
https://safe-web-core.staging.5afe.dev/gor:0x95ddA5dc54331a1E6B65aF1Cd7167962A2f7f280/transactions/tx?id=multisig_0x95ddA5dc54331a1E6B65aF1Cd7167962A2f7f280_0x982cc595262fa8d00b06a6b997397f3dcedb34eeb89e0afaa8229d2b931ee999
https://safe-web-core.staging.5afe.dev/gor:0x24F8542Da0C5f267c177a224270442C73804EE80/transactions/tx?id=multisig_0x24F8542Da0C5f267c177a224270442C73804EE80_0xe54006e20a542f11ab5f0ba821786fa17573b0a0c12cfa88dacfec5a56c452e3

I don't know if expected caballero but the behaviour is different from the current live app, there the claim and delegate process is disabled unless a token amount is selected:
Live app, user airdrop:

PR app, user airdrop:

PR app, investor airdrop:

Un abrazo

@JagoFigueroa yes this is intended.
The reason is that we want to enable investors to already delegate their voting power without having to claim tokens as token claiming will not be possible until the token is unpaused / transferable.
I fixed the last small issue with empty inputs not being accepted by treating them as zero inputs.


map classification from ssdl.access_level

Lighter first step implementation of #295 based on discussions in #320

Make fmu-dataio be strict on the content of access.ssdl.access_level ["internal", "restricted", "asset].

We will deprecate "asset" at some point (soon).
We allow for the legacy value "asset" for now, translate it to "restricted" and issue warning.
We raise if content is not valid (new functionality).

Make fmu-dataio produce access.classification with the same value as access.ssdl.access_level in preparations for later deprecation of access.ssdl.access_level

Discussions with SSDL - they are OK with changing from "internal"/"asset" to "internal"/"restricted" in the access.ssdl.access_level field. Possibly, we should allow both "restricted" and "asset" in a transition period, with deprecation warning on "asset".
So we possibly include:

[ ] If "asset" is provided to access.ssdl.access_level, change it to "restricted" and issue warning.
[ ] Then map access.classification from the updated access.ssdl.access_level

@rwiker @daniel-sol FYI


Download Zcash Sapling parameters and load them from cached files

Motivation
We want to avoid linking half a gigabyte of Zcash parameters into the zebrad executable, tests, and build products.
This might also save us some redundant copies of the parameters crates, if they are duplicated for dev and release builds.
This is the Sapling refactor part of ticket #3037.
Solution
Zebra:

Load Sapling parameters from the downloaded files, rather than crates
When Zebra is initialised, spawn a task to download parameters
Mention zebrad download and the cached parameters directory in download error messages

CI:

Download Zcash parameters in Docker using a new zebrad download command
Download and cache Zcash parameters in GitHub CI using zebra-consensus examples, like zcash_proofs does

TODO in the next PR:

Implement Sprout parameter downloads in zcash_proofs
Load Sprout parameters from the downloaded files (already implemented in zcash_proofs, just needs glue)

Review
@jvff is reviewing this PR.
Reviewer Checklist

[ ] Code implements Specs and Designs
[ ] Existing tests pass
[ ] CI changes pass reliably

Follow Up Work

download and load Sprout parameters using zcash_proofs - the rest of #3037
#322 using the sprout parameters

ICYMI, we have a download_params function in the zcash_proofs crate that emulates fetch-params.sh. Limitations:

It currently only fetches Sapling parameters (as that is all our Rust crates supported making transactions with), not Sprout (as they were too large to just fetch inline all the time).
It doesn't include the IPFS fetching logic (pulling from there instead of HTTPS if ipfs is installed locally).
It hardcodes minreq as the fetcher (as we just needed a simple self-contained HTTP stack), whereas good probably want an async-compatible function that can use whatever HTTP stack you're already using elsewhere.

I'd be interested in collaborating on extending that Rust function with additional functionality, or building out a separate dependency for it.

ICYMI, we have a download_params function in the zcash_proofs crate that emulates fetch-params.sh. Limitations:

Thanks, I had missed download_parameters:
https://github.com/zcash/librustzcash/blob/85780f994d51abb965cbf4b981f8730ff0554607/zcash_proofs/src/lib.rs#L68
It looks like our code is an uncredited copy of that method 😞

* It currently only fetches Sapling parameters (as that is all our Rust crates supported making transactions with), not Sprout (as they were too large to just fetch inline all the time).

We need to fetch Sprout to close ticket #3037, so I'm happy to submit a patch with those changes.

* It doesn't include the IPFS fetching logic (pulling from there instead of HTTPS if `ipfs` is installed locally).

IPFS is out of scope for Zebra for NU5 mainnet activation.

* It hardcodes `minreq` as the fetcher (as we just needed a simple self-contained HTTP stack), whereas good probably want an async-compatible function that can use whatever HTTP stack you're already using elsewhere.

We're trying to minimise our scope before Zebra for NU5 mainnet activation. So I don't really want to rewrite working code.
We can just spawn a blocking async task for these downloads, and the executor will put it on its own thread. Then we can open a ticket for an async rewrite that uses reqwest.
(We haven't explicitly picked a HTTP stack yet. But some of Zebra's dependencies use reqwest.)

I'd be interested in collaborating on extending that Rust function with additional functionality, or building out a separate dependency for it.

We don't really have time to split dependencies right now. But I'd be happy to work on a Sprout download.

it seems like building Zebra is too slow for the time limits on these tests.
That's weird, because all the built crates should just get re-used. Maybe there is some minor difference between cargo run and cargo test that's causing a rebuilt.
I might have to make a "test" that just downloads the parameter files. That should be much smaller than all of zebrad. And it should have exactly the same build settings.

You might find this logic interesting, which we use in our CI to cache the parameters in GH Actions workers: https://github.com/zcash/librustzcash/blob/master/.github/workflows/ci.yml#L20-L33

You might find this logic interesting, which we use in our CI to cache the parameters in GH Actions workers: https://github.com/zcash/librustzcash/blob/master/.github/workflows/ci.yml#L20-L33

Thanks, this was really helpful, I've used similar logic in our CI.


update readme.md

Add another vulnerability which found with radamsa
https://twitter.com/vah_13/status/801396447929311232

Sorry about the delay. Didn't have a machine to merge this with yesterday afternoon :)

)) all is OK )
2016-11-25 10:01 GMT+03:00 Aki Helin<EMAIL_ADDRESS>
Sorry about the delay. Didn't have a machine to merge this with yesterday
afternoon :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aoh/radamsa/pull/29#issuecomment-262892681, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHm15b92Cq82LZteUmgwC5b2Xuq_5-f7ks5rBofegaJpZM4K7uA_
.


Fix travis build

would be nice to try to go to main version tree of bitcoinj or make PR of our changes. TB Discuss
2 test were mark as ignored by me, can not judge if they are broken because of our branch chnages or because of a bug that may be solved already in main tree version of bitcoinj
I did add some code tricks to avoid manual changes to  JDK, so it is a bit more easy to run and it's lower the barrier entry to submit code for newcomer (now git clone and run, no changes needed for JDK)
with this maven test are green locally and in travis

Thanks!
I used the reflection hack for the JCE Unlimited Strength  as well but seemed to not work reliable. Did not had time to investigate details but went back to adjust the jdk.


Edit sent messages

Would be nice to have the ability to correct typos.
This involves rewriting history though.

He who controls the past ... :+1:

I'm so bad at typing that this feature would free me and make my time chatting more enjoyable.
:)

I'm not clear how this feature would work in practice. There is a likely risk that follow-up messages will look out-of-context.
My suggestion is the introduction of a delay before a message is actually sent - so you can review it and fix it.

I think it's best not to do this. It sort of runs contrary to how most people assume chat works.

I want this feature in, but with two notes:

Some type of time limit
Messages have some indicator they were changed (like a * next to the time or something)

Skype allows you edit messages you've already sent - took look at that an example.

This may be of use: XEP-0308: Last Message Correction

Might want to keep a history of edits, so people can see what was changed.

@funkaoshi Nice to have, not a deal breaker though imo

This feature has been implemented in skype, whatsapp and that other group chat web app to the users' benefits
(I don't remember any backlash from their user base regarding that feature)

This feature has been implementedin Slack :)
+1

Just a quick note here that some regulations require a full log for any chat system used. Having the ability to edit past messages, especially with no audit trail, will be a deal-breaker for those needing to follow such regulations.

The XEP referenced above is just a piece of metadata that says "this message replaces that message". You don't need to actually delete the old message, just keep some metadata that you should display another instead.

+1 this feature is actually getting pretty common in chat apps, would love to see it here

+1 This is what is preventing our company from switching from Slack to Let's Chat.
It could be disabled by a server-side setting for the rare cases where this feature might be unwanted.
Slack allows to edit even very old messages. Some other systems have a time limit (StackExchange chat I think).

+1 This feat. would be awesome.

+1 I wrote so many times wrong words because I type too fast. It would be a necessary function for me.

rocket.chat has this feature and i hate it most of the time.
So many messages look out-of-context if you read them later.
If you add this feature we also need the feature to delete messages. (why istn this even in yet ? or im i blind)
i would more love a "you have 30seconds to change" option. But not change "forever"

+1


[MWPW-139113][Technical Debt] - Long Text block Unit Test

Added Integration test for Cards block
JIRA ticket: https://jira.corp.adobe.com/browse/MWPW-139113
Test URLs:
Before: https://stage--express--adobecom.hlx.page/express/learn/blog?martech=off
After: https://long-text-ut--express--adobecom.hlx.page/express/learn/blog?martech=off

Codecov Report

Merging #455 (8137035) into stage (856cf04) will increase coverage by 0.13%.
Report is 12 commits behind head on stage.
The diff coverage is 12.12%.

@@            Coverage Diff             @@
##            stage     #455      +/-   ##
==========================================
+ Coverage   29.88%   30.01%   +0.13%
==========================================
  Files         124      124
  Lines       23713    23740      +27
==========================================
+ Hits         7086     7125      +39
+ Misses      16627    16615      -12

Files
Coverage Δ

express/blocks/schemas/schemas.js
9.09% <ø> (+0.75%)
:arrow_up:

express/scripts/utils.js
32.95% <100.00%> (ø)

express/blocks/puf/puf.js
5.00% <9.37%> (+0.17%)
:arrow_up:

... and 3 files with indirect coverage changes
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!