Unload One Model: How choose which model?

I guess you string the model you want to unload to "model" input, but what's the purpose of "value"?

Just reroute any value through the node. When the value passes through the node, the model will be unloaded


Fixing menu

Thanks for jumping on this @fletch3555  👍
Waiting for Travis to finish and I'll merge it in.


Ignore compiled DLL binaries.

I build Raylib as a share lib on Windows. Compiled DLL binaries should be Ignored.

@2Bear thanks for the review!


Docker images with multi-platform support

This PR updates the image build actions to add multi-platform support.
Supported platforms:

linux/amd64
linux/arm64

I already tested the build process here: https://github.com/cms-ml/cmsml/actions/runs/8454714485
They are already deployed to our dockerhub as I wanted to test them locally (with the result that TF now also works on arm / Apple silicon).
Fixes #16.

I am finalizing this PR in the coming days.

The multi-platform images build successfully now and the unit tests are fixed. Reader for review :)


docs tab for Collection Detail

Draft pr for the Documentation tab on Collection Detail.

This has to be rebased, because of changes in collection tabs. Maybe it will be faster to create new PR and copy changes from this PR rather than rebase it.

Replacing with new pr for docs tab.


Test cluster initial state transfer after Infinispan 14.0.13 upgrade

With Infinispan 14.0.10, we've seen Pods not starting up with an initial state transfer. Some fixes have been added to 14.0.13, so it would be worth having an extended run with killing pods.
Details on how much load we want to add, how many pods and how many active sessions we want to have need to be added as part of a refinement.
Possible pre-requisite: #440
Suggestion:

Succeed with the state transfer with 100 chaos-killed pods under reasonable load (for example 200 logins per second)
Check if metrics can be collected on healthy nodes while one node restarts (this had problems / timeouts in earlier versions)
To verify no new bug came up with the migration to Autora

Succeed with the state transfer with 100 chaos-killed pods under reasonable load (for example 200 logins per second)

Performed this run in which, we did the below,
Cluster Config:

External Aurora configured
Disabled the sticky sessions
15 DB Connections in the pool for each Keycloak pod
5 Cpu request/limit for each Keycloak pod
2 GB memory request and 3 GB memory limit set for each Keycloak pod
OTEL disabled
6 Keycloak pods
Legacy store
eu-west-1 AWS region used for both Keycloak ROSA cluster as well as Aurora PostgreSQL Cluster

Keycloak config:

Default password hash iteration algorithm and number of hashes
100,000 users and clients created in realm-0
100,000 user sessions created before the load run

Load run config:

extended load run with 200 ups ran for 4600 seconds
kc-chaos.sh script running for about 1.2 hrs killing one pod at a time for 100 iterations
collect logs at the end of the run

Observations:

We got new errors thread pool in Keycloak pod during restarts which we are dealing with in https://github.com/keycloak/keycloak-benchmark/pull/452
Throughput stayed the same from previous runs
Response times remained good

Gatling result:

Pod recovery time:

Check if metrics can be collected on healthy nodes while one node restarts (this had problems / timeouts in earlier versions)

We can collect metrics from all nodes during the restarts, didnt observe any data loss for other pods when one of the pods in the cluster is terminated forcefully.

To verify no new bug came up with the migration to Aurora

No issues observed here, the performance was comparable to that of the internally hosted PostgreSQL pod.

Agreed. Thanks!


fix: revert selections tool placment

:tada: This PR is included in version 1.1.9 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add LICENSE file to the project.

The repository is missing a LICENSE file. To make the project open source and specify usage rights, we need to add a LICENSE file.
Suggested steps:

Choose an appropriate open-source license (e.g., MIT, Apache 2.0).
Add a LICENSE file in the root directory of the repository.

For more information on open-source licenses, refer to Choose a License.

Thanks for contributing!


Build: ENOENT: no such file or directory

Hey all! As soon as I run yarn build, it stops with this message:
Failed to compile.

ENOENT: no such file or directory, stat '/Users/stevenlangbroek/Code/my-project/public'

What's interesting is that if I create this empty directory, it works, but this dir is never even really used (builds end up in ./build instead of ./public...
Any idea what's going on here?

By default razzle creates a default public directory. This directory has the robots.txt file as well as the favicon.ico.
You can use it also for other static assets on your express server. See public folder static express middleware below from the server file.
server.use(express.static(process.env.RAZZLE_PUBLIC_DIR))

Ahhhhhh of course. Cool. Thanks!


IntelliSense stops working with the debugging workaround

If I use this extension, debugging does not work. If I apply the stub project workaround, debugging works but IntelliSense completely stops working for that project. Deleting the StubProj and restarting VS solves that, but then of course debugging does not work.
Windows 10
Visual Studio 2022
Godot v3.4.2.stable.mono.official [45eaa2daf]
Godot C# extension for Visual Studio v2.0.0
To get the debugging working, I needed to use the stub project workaround here: https://gist.github.com/31/302bab2630ddf8d90ab4aec0d358b538
Initially everything worked fine, including IntelliSense.
Yesterday IntelliSense wasn't working at first, but then all I remember doing was restarting VS and it was working again.
Today it was not working at all, after multiple restarts.
To clarify, IntelliSense works correctly with any other VS project, just not with a Godot project. All the while debugging works fine, the "Play in editor" works fine, Godot types are recognized, there are no apparent errors. It's just the code completion that's missing, regardless of what member or type I use (I start typing the name of a variable I've defined, and nothing. I type "GD." and nothing. You get the idea.)
(Also, I noticed that after closing Visual Studio with the Godot project, devenv.exe keeps running (and the Visual Studio instance with the project name in its title keeps showing up among the background processes in task manager), until I kill it. I'm only noting this here because this also only happens with a Godot project, and only after the workaround is applied. It doesn't happen with any other Visual Studio project. So possibly the Godot extension is causing this.)
edit: I've just realized that some people have mentioned this problem in the comments under #10 already. Apparently only some of us have this problem, I wonder why...

reproducing:
create a new Godot project (in a custom location) called Test
create 3D scene
rename root node "Spatial" to "MainScene"
select MainScene and add a new C# script ("MainScene.cs")
verify that in editor settings, Mono external editor is set to Visual Studio
double click on MainScene.cs in Godot does nothing (devenv.exe is not running)
save scene
go to project in file manager
open sln file ("Test.sln") with VS2022
open MainScene.cs
in _Ready() method, start typing "GD.", IntelliSense is working fine
debugging does not work though, so perform steps of godot-3.2.3-VS-extension-workaround.md (via https://gist.github.com/31/302bab2630ddf8d90ab4aec0d358b538 )
(in the process of that workaround, we do need to close VS, it does in fact properly close this time, checked in task manager)
after those steps are done, open MainScene.cs
in _Ready() method, start typing "GD.", IntelliSense is NOT working.
close VS.
devenv.exe is still running
in task manager end task "Microsoft Visual Studio 2022"
open sln file ("Test.sln") with VS2022 again
IntelliSense is still not working
delete StubProj project
close VS
in task manager end task "Microsoft Visual Studio 2022"
delete StubProj folder from the project folder
open sln file ("Test.sln") with VS2022 yet again
IntelliSense IS working again. However, debugging is not.
close VS (VS does now properly close.)

It happens to me too, exactly the same. I had to uninstall the plugin, install the previous version on VS 2019 and debug from there,

I hope you don't mind @Atlinx -- I'm reposting your comment from https://gist.github.com/31/302bab2630ddf8d90ab4aec0d358b538?permalink_comment_id=4178016#gistcomment-4178016 so more people who may be interested can see it:

I've tried Visual Studio 2022 v17.2.1 and everything works 😃

VS 2022 v17.2 was released on May 10, so it's a newer one than what I'd tried, at least! 😄

I can confirm that intellisense still stopps working on v17.2.1 and v17.2.2, like the op said. I just tried it.

I'm also having this issue with Godot v3.4.4 and VS v17.2.6. There was a short period after I first installed the extension that intellisense would sporadically work but at this point it just doesn't at all. Disabling the extension fixes the problem, though.

I'm using Godot v 4.0.3 mono stable version, Visual Studio 2022 v17.6.4 and godot c# plugin v 2.0.0, intellisense not working( i write "GD.", but nothing happens, not showing any tooltips)


FormatPx <IP_ADDRESS> does not work with the Microsoft AD cmdlets

Issue reported via email from a FormatPx user:
I'm using your great FormatPx module (added to my profile), but I'm getting some errors when working with the Active Directory module. Here is an example when running Get-ADDomain:
Out-Default : Unable to cast object of type 'Microsoft.ActiveDirectory.Management.ADPropertyValueCollection' to type 'System.Collections.Generic.Stack`1[FormatPx.FormatRecord]'.
+ CategoryInfo          : NotSpecified: (:) [Out-Default], InvalidCastException
+ FullyQualifiedErrorId : System.InvalidCastException,FormatPx.OutDefaultCommand
Any thoughts?

It turns out that the AD cmdlets provide their own "special" treatment on the PSObject Properties collection.  For normal cmdlets, if you use the Properties indexer to check if a property is there or not, the indexer will simply return null for properties that do not exist.  For AD objects returned by the Microsoft AD module, the indexer will return a property with a null value for properties that do not exist.  Since there is no way to distinguish between a real property that exists but has a null value and a property that does not exist, a different mechanism must be used to determine if properties exist when working with objects returned from the Microsoft AD module.
The new logic is to check the type of the member that is returned from the indexer.  If the member type is PSAdaptedPropertyInfo, then an additional check must be performed, using Linq with the enumerator to see if the property actually exists in the collection.  If the type is not PSAdaptedPropertyInfo, then the old type check logic works just fine.
This issue has been fixed and it is included in release <IP_ADDRESS> of FormatPx.

FYI if you tried this yesterday...turns out I missed a step in the release processing, so this didn't get properly posted as a release on GitHub until today.  But I also pushed out release <IP_ADDRESS> today, so just update your module to that version and you'll have this fix plus another one that was reported and fixed today as well.


improve split agent batch tasks automaticlly #43257

cherry pick from #43257

run buildall

run buildall

run buildall


move_base_sequence: 0.0.1-2 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository move_base_sequence to 0.0.1-2:

upstream repository: git@github.com:MarkNaeem/move_base_sequence.git
release repository: https://github.com/MarkNaeem/move_base_sequence-release.git
distro file: melodic/distribution.yaml
bloom version: 0.10.1
previous version for package: null

move_base_sequence
* added a gif to readme
* edit2
* edit
* edited readme
* Edited Readme
* adjusted class, rosparams, ros topics names
* upload the package files
* Initial commit
* Contributors: Mark Naeem, MarkNaeem

Holding for the upcoming Melodic sync


fix: LocalArchivalMemory prints ref_doc_info on if not using EmptyIndex

Currently, if you run the /memory command the application breaks if the LocalArchivalMemory has no existing archival storage and defaults to the EmptyIndex. This is caused by EmptyIndex not having a ref_doc_info implementation and throwing an Exception when that is used to print the memory information to the console. This hot fix simply makes sure that we do not try to use the function if using EmptyIndex and instead prints a message to the console indicating an EmptyIndex is used.
This is just a hot fix and I feel like there's definitely ways to improve this, but this might be "good enough" for now to run the /memory command successfully again.
I am pretty new to the python game so please feel free to adjust this PR as needed.
Happy to learn more about LLamaIndex if you guys have any recommended resources for me to check out that would be awesome!

Agreed, @sarahwooders! That solution is much cleaner.
I saw your work on this: https://github.com/cpacker/MemGPT/pull/226.
Happy to open a PR to that branch instead.
Let me know what you think!

Thanks! #226 is still a work in progress and we need this fix ASAP, so it would be better to merge this with main.

@sarahwooders pushed a new version based on your suggestion. let me know if this looks good! Thank you!


[question] Authorization support via UMA endpoints

Currently, the plugin supports authentification ( i.e. obtaining access token) and token validation (via instrospection endpoint).
Upstream servers need to perform authorization ( check if token has access to partiuclar URL) by themselves.
But actually this can be achieved using (UMA compatible endpoints](https://www.keycloak.org/docs/latest/authorization_services/index.html#_service_obtaining_permissions)
I.e. calling token endpoint with urn:ietf:params:oauth:grant-type:uma-ticket grant type kong can check permissions, and terminate or forward request.
So, my question is there any plans to support authorization in this plugin ?
Thus, the plugin can become the complete solution for authentification / autorization with OAuth2 / OIDC compatible services like keycloak or gluu.
Actually lua-resty-openidc already has everything in place to implemnt those calls.

@eshepelyuk  i am looking for solution to restrict user at at API gateway level i am using Kong based on authorization scopes.
i am looking to for way restrict user like GitHub do, as in GitHub we have organization repo and each user has different access in an organisation repo (read/write) or i can add a specific user to the organisation with only one repository access.
i think Github manage this by forming URL
https://github.com/org-name/username/reponame and restricting user at API gateway level if no access there.
Is possible by using UMA keyclaok ?
For me simple authorizations in authentication working based on scopes i am looking to take it on the next level.
Please suggest if you have any suggestions or ideas correct me if i am wrong.

@harsh4870 I am not using kong and this plugin anymore.
sorry, no suggestions from my side.

To all those coming this thread posting my experiment and articles details here might be helpful to someone :

https://faun.pub/securing-the-application-with-kong-keycloak-101-e25e0ae9ec56
https://faun.pub/building-kong-custom-docker-image-add-a-customized-kong-plugin-2157a381d7fd
https://faun.pub/building-kong-custom-docker-image-add-a-customized-kong-plugin-2157a381d7fd
https://faun.pub/kong-jwt-scope-base-auth-with-keycloak-b9938a96d281
<EMAIL_ADDRESS>


Can you please Add ArmoniScans

Source name
Armoni Scans
Source link
https://asuratoon.com/
Source language
Turkish
Other details
Main link address is asuratoon but they uses ArmoniScans on read pages example:
https://armoniscans.com/yeralti-kralinin-reenkarnasyonu-bolum-1/
Not NSFW
Acknowledgements

[X] I have checked that the extension does not already exist by searching the GitHub repository and verified it does not appear in the code base.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a meaningful title with the source name.
[X] I will fill out all of the requested information in this form.

This issue was closed because an extension with the provided URL (asuratoon.com) already exists with the name of Asura Scans, under the All section.
This is an automated action. If you think this is a mistake, please comment about it so the issue can be reopened if needed.

Main site is asuratoon but it's turning ArmoniScans on manga/manwhas.

Main site is asuratoon but it's turning ArmoniScans on manga/manwhas.

Then it's an issue with the existing extension. Open a bug report, not a source request


Dogfooding: use tap-gitlab to create a collaborative visualization of the Meltano project

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/498
Originally created by @dmor on 2019-03-18 22:36:29

This is an opportunity to dogfood Meltano, visualizing our own project via tap-gitlab and tap-googleanalytics and also learning what it is like to use Meltano in a collaborative, hosted, version controlled way.

[ ]  @dmor attempt to do this with existing documentation
[ ]  @dmor record speed run
[ ]  @dmor write tutorial
[ ]  @dmor write blog post and promote

View 8 previous comments from the original issue on GitLab


Add command enter support to go direct to item

For example, after typing:

And hitting command + enter,
It'd be great if it automatically went to the appropriate page (similar to what this would do):

@bswinnerton: When I enter a owner/repo name (e.g., apple/swift) and hit command+enter, the LaunchBar window disappears, but it doesn't open the repo:

Is there any trick to getting this to work correctly? If there's additional information I can provide, please let me know.

Is there any trick to getting this to work correctly?

@jasonrudolph, I suspect that you're hitting ⌘ + Enter before launchbar-github has a chance to fetch all of the repositories that the Apple organization has access to via an API call to GitHub.
Here's a screen capture of an up-to-date version of launchbar-github that has already cached the result of Apple's repositories:

A terrible workaround is to wait for the repositories appear before hitting ⌘ + Enter. But I've opened https://github.com/bswinnerton/launchbar-github/issues/87 to explore a better way of accomplishing this.

@jasonrudolph: as a total aside, what are you using to showcase which keys you're pressing in your screen recordings?

I suspect that you're hitting ⌘ + Enter before launchbar-github has a chance to fetch all of the repositories that the Apple organization has access to via an API call to GitHub.

That does seem to be the case. 😇
I'm looking forward to #87. Thanks for opening that issue.

what are you using to showcase which keys you're pressing in your screen recordings?

That's Mouseposé. 😄


Telescope not found

Describe the bug

Tried to do my setup via git clone flow, but without any visual succes.
Error detected while processing /home/rev0/.config/nvim/init.lua:
lazy.nvim requires Neovim >= 0.8.0
E5113: Error while calling lua chunk: /home/rev0/.config/nvim/init.lua:273: module 'telescope' not found:
        no field package.preload['telescope']
        no file './telescope.lua'
        no file '/usr/share/luajit-2.1.0-beta3/telescope.lua'
        no file '/usr/local/share/lua/5.1/telescope.lua'
        no file '/usr/local/share/lua/5.1/telescope/init.lua'
        no file '/usr/share/lua/5.1/telescope.lua'
        no file '/usr/share/lua/5.1/telescope/init.lua'
        no file './telescope.so'
        no file '/usr/local/lib/lua/5.1/telescope.so'
        no file '/usr/lib/x86_64-linux-gnu/lua/5.1/telescope.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
stack traceback:
        [C]: in function 'require'
        /home/rev0/.config/nvim/init.lua:273: in main chunk
Press ENTER or type command to continue

The guide says:
Run Neovim (from terminal or shortcut) and allow lazy.nvim to download files and set up the basics.
but this second part actually never happens
To Reproduce

Follow throught Git Clone Installation flow

Desktop

OS: Ubuntu 22.04
Terminal: zsh

Neovim Version

NVIM v0.7.2
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by<EMAIL_ADDRESS>

Please type:
:Lazy install
and see if that resolves your problem.
Also if that works please put in a PR to improve the README so that would have been obvious to you immediately.

@feoh sorry, I am don't have much experience, tried to type it after semi column but faced another issue
Press ENTER or type command to continue
pressed:
Shift + :
than typed:
Lazy install
received:
E492: Not an editor command: Lazy install

OK. Something is very wrong with your installation if it can't find the lazy.nvim plugin
Did you check the repository out in $HOME/.config on a UNIX-like system, or $HOME\AppData\Local on a Windows system?

Please upgrade your Neovim version; you have 0.7.2 installed but lazy.nvim needs >=0.8.0, as stated in the error output.

Good catch I totally missed that detail! Thank you

@feoh @mech-a
No matter what I do, I cannot update, for ubuntu I can use only 0.7.2 version
sudo add-apt-repository ppa:neovim-ppa/stable
sudo apt-get update
sudo apt-get install neovim

doesn't update anything

Or build from source which is my preferred on Ubuntu, but I understand not everyone has ./configure && make && sudo make install baked into their brain stem :)

@akarev0
Try  snap, and don't forget to remove the old nvim before.


[Security]A Quickstart to GraphQL Data Security

Proposed title of article
A Quickstart to GraphQL Data Security
Proposed article introduction

GraphQL has been adopted by the biggest platforms out there such as Facebook, Twitter, Github, Pinterest and Walmart. But even though GraphQL can be a very secure option for your API, it does not come secure out of the box. It’s actually quite the opposite because all doors are open even for the most novice hackers. The primary categories of attacks that you must absolutely protect your application from are:

access control
brute-force attacks
DoS (Denial of Service)
injections (SQL, XSS, CCS, etc)
CSRF

Key takeaways

Introspection Query
Limit Access control with Authorization and Authentication
Timeout
Query Whitelisting
Depth Limiting
Resource Limitations with Complexity Analysis
Rate Limiting to block Brute Force attacks
Verbose Errors
Injections
POST vs GET requests

Article quality

This article will be on point, simple to understand, well formatted and I'm sure users will be able to familiarize themselves with the attack vectors for GraphQL APIs and strategies to adopt to protect the APIs. The code snippets in this article will be simple to understand and implement. I hope we will have a good ride all along.

References
N/A

Good afternoon and thank you for submitting your topic to the EngEd program.
After some careful consideration it struck us that this topic may be a bit over saturated throughout other blog sites and official documentations. We typically refrain from publishing content that is covered widely on the net or other blogs. We're more interested in original, practitioner-focused content that takes a deeper dive into programming-centric concepts.
But in order to approve the topic it has to serve value to the larger developer community at large. Please feel free to suggest an alternate topic to explore. 🚀
An option and a great way to write this as an in-depth article and make it more add value to the greater developer community at large would be to walk the reader through the USE of methods and functions by building a unique, different, useful project.
If you believe your article is unique enough - please present your case to explain how it will be different from what is currently out there?
https://www.google.com/search?q=GraphQL+Data+Security&rlz=1C1CHBF_enUS891US891&sourceid=chrome&ie=UTF-8


Test-ADFS2AADOnPremRPTrustSet command has issues

When I run the following command
Test-ADFS2AADOnPremRPTrustSet -RPXMLFileDirectory "C:\adfs\apps"
I get this but the instructions or commands have no mention of what is being looked for:
PS C:\temp> Test-ADFS2AADOnPremRPTrustSet -RPXMLFileDirectory "C:\adfs\apps"
cmdlet Test-ADFSRPRuleset at command pipeline position 1
Supply values for the following parameters:
RulesetName:
KnownRules:
ResultTypeIfUnknownPattern:

same issue


[Feature]Is there an easy way to create a graph mini map?

Like this:

My solution：
https://gist.github.com/Yokosama/723b0465a669c9207b69b77e9cec653d

I have some question:
How to get ItemContainer's width and height use binding? the result I got was Nan.
The ItemContainer's location are not updated until the drag is completed, how to update minimap's node items location in realtime when drag node item?
So, is there a better solution, thank you very much.

Set NodifyEditor.EnableDraggingContainersOptimizations to be false to receive real-time ItemContainer.Location updates.

This is now implemented by #124


How to WS SubscribeToUserDeltas?

Hi!
From what I see here: https://www.bittrex.com/signalr/hubs
and here: https://github.com/n0mad01/node.bittrex.api/issues/23
Bittrex SignalR has SubscribeToUserDeltas, but I can't see any code able to subscribing to user deltas and do the auth over ws in node.bittrex.api package...
 var setConnectedWs = function(markets) {
    wsclient.serviceHandlers.connected = function(connection) {
      markets.forEach(function(market) {
        wsclient.call('CoreHub', 'SubscribeToExchangeDeltas', market).done(function(err, result) {
          if (err) {
            return console.error(err);
          }

          if (result === true) {
            ((opts.verbose) ? console.log('Subscribed to ' + market) : '');
          }
        });
      });
      ((opts.verbose) ? console.log('Websocket connected') : '');
    };
  };

It only subscribes to exchange deltas upon connecting. Do you have plans/know how to implement the authenticated part of their SignalR API? This is not documented anywhere.

To Authenticate over the websocket you will have to login from the browser and then grab the .AspNet.ApplicationCookie from the page code and pass it as a cookie in the websocket headers. I tested it and it worked by updating the balance and the open orders.
Easier said than done if you plan to automate the process by doing it programmatically. I have been working on this all day and I am stuck at the 2FA bit. I can't get the Google Authenticator API to generate the right Pin :(

@Squeaky-bed thanks for your comment, can you please share a snippet of code showing how you would put a cookie there manually (add to ws headers by means of the underflying signalr-client)?

@kroitor I tried doing this by stealing the cookie from a page in chrome (stopping all page JS from executing on page load), but my requests kept getting flagged as XSS, despite trying to make sure all the headers matched from chrome to my manual Websockets request. Basically you need to attach these cookies in the header of the websockets connection request. I'm currently seeing if looped, static API calls can suffice for what I need currently. Otherwise I will explore attaching my code as a Chrome plugin that can access/query the DOM and the Knockout.js data, and place trades that way.

@Squeaky-bed I'd be curious to see learn specifically what issues you had with the 2FA bit, my understanding is that you can't get a TOTP code for another app unless you have that app's (Bittrex in this case) private Google 2FA key, but I might be confused https://github.com/google/google-authenticator/issues/234. But how did you snag the cookie from a browser and place it into your headers? My requests keep getting flagged as XSS...

@jsonhuntrods , thx for your comment! Can you please share a snippet of code that would set the cookie in headers with the underlying signalr-client used in node.bittrex.api ?

@kroitor I wasn't able to actually get it to work, but basically right after Signalr client initialization here https://github.com/n0mad01/node.bittrex.api/blob/master/node.bittrex.api.js#L161, I set a bunch of headers like this
wsclient.headers['Accept-Language'] = 'en-US,en;q=0.8,la;q=0.6';
wsclient.headers['Cache-Control'] = 'no-cache';
wsclient.headers['Connection'] = 'Upgrade';
wsclient.headers['DNT'] = '1';
wsclient.headers['Host'] = 'socket.bittrex.com';
wsclient.headers['Origin'] = 'https://bittrex.com';
wsclient.headers['Pragma'] = 'no-cache';
wsclient.headers['Sec-WebSocket-Extensions'] = 'permessage-deflate; client_max_window_bits';
wsclient.headers['Sec-WebSocket-Version'] = '13';
wsclient.headers['User-Agent'] = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36';
wsclient.headers['Upgrade'] = 'websocket';
wsclient.headers['Cookie'] = '__cfduid=cookie1; .AspNet.ApplicationCookie=cookie2';

Those headers basically matched what I was using in google chrome. What I did initially was use a request logger to see what the requests going from my Node.js server looked like, it was something like this:
var globalLog = require('global-request-logger');
globalLog.initialize();

That shows everything the node-bittrex-api is sending to Bittrex. Then I compared it to what was being sent in my network tab of chrome locally, specifically the Signalr negotiate call that must be made prior to the websockets connection, and then I looked at the connection itself.

So I make sure all the request headers line up and look the same. But a new cookie is generated on every page load, and might be allowed to initiate a single Websockets connection. So I put a debugging point somewhere in the page's Javascript that would stop the initial connection from happening, grabbed the cookies from the page, put them in the headers, and then tried subscribing from my Node.js instant. I still didn't have any luck. If I didn't include the cookie, it just subscribed me to the exchange summary feed (probably default for when someone isn't authorized), but when I included the cookie I got an error response that said I wasn't authorized and the response had XSS attack parameters set, so Bittrex thought I was doing a XSS attack. Which the only way to really check an XSS attack is to analyze the headers/data sent in the request, so maybe I was missing something.

@jsonhuntrods thanks for this very comprehensive feedback! Appreciate it!


Force failing on empty binary patch

This option has caused us some issues on SQ when developer ignores the prompt, this way at least people won't patch empty binary accidentally

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Removing random parts form upstream library is not a good thing. We might get into unexpected situations and will not be sure if that is upstream bug or our issue.
If this causes problems for SQ only, I'd suggest adding check if there is SQ configured for current repository and ignore check then. You can detect SQ repositories from contents on .arcconfig file. Something like following would work:
$ok = false;
if (false === isSubmitQueueRepo()) {
    $prompt = pht('Continue?');
    $ok = phutil_console_confirm($prompt, $default_no = false);
}

if (!$ok) {
   ...
}

@Pawka The root cause was arc failing to handle binary upload (in some case), developer tends to ignore the prompt and land it. While it won't fail in SQ and diff job on that particular commit, it will fail for the upcoming commits thus clog the pipeline (because we use git instead of arc on these jobs, but merge with arc, which, might be fixed later).
I added an option to make the change easier to spot.

If this causes problems for SQ only, I'd suggest adding check if there is SQ configured for current repository and ignore check then.

IMO the original code makes no sense, how can you validate a diff if the binaries associated with it fail to upload? This causes a problem for all change verification, not just SQ (this only got caught late in our case as we do not use arc patch for change verification but do for pushing, so it was the final step that failed, for other pipelines this would fail earlier). I'm fine with the option approach, but would also be fine with changing the default.

@Pawka Ping for feedback


Add support for svg images to imageview command

I've addressed issue #67!
Please take a look :)
Description
I've modified the code to ensure that the MIME type is set to "image/svg+xml" exclusively for SVG files.
Below is how an SVG file appears when displayed using the imageview command.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

It works great, thank you for this!! I'll merge it :)


Example of ansible playbook on azure fails

Thank you for this nice page of valuable information and examples.
However, from my experiment using the cloud shell, the deployment fails with this error:
TASK [Create VM] *******************************************************************************************************************************************************************
[WARNING]: Module did not set no_log for ssh_password_enabled
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Error creating or updating virtual machine myVM - Azure Error: InvalidParameter\nMessage: The value of parameter linuxConfiguration.ssh.publicKeys.keyData is invalid.\nTarget: linuxConfiguration.ssh.publicKeys.keyData"}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a2ab8eeb-df97-be60-ce0a-ed619748c43e
Version Independent ID: 4dd052d8-808b-1761-526f-2d534322f0e1
Content: Quickstart - Configure Linux virtual machines in Azure using Ansible
Content Source: articles/ansible/vm-configure.md
Service: ansible
GitHub Login: @Duffney
Microsoft Alias: jduffney

Sorry, I missed the instruction to replace the ssh key data :-/

Hi, @dometdemont. Thanks for the feedback! I'm glad replacing the ssh key data resolved the issue.


Implement the order tracking functionality

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Implement the order tracking functionality for the users able to track their orders
I check the pr #129 but their is no any response
Describe the solution you'd like
A clear and concise description of what you want to happen.
Building an ui for the order tracking functionality
Ui sample like

If any ui in your mind please tell me that also
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

What about the backend functionality?

We use firebase store for it

@CoderSwarup okay go ahead, u got the firebase access?

yes
any suggestion in the design or any template

hi any design available for the page or i  choose following ui

@CoderSwarup choose this one


Remove XMLSerializer to parse preview document.

[Problem]: In virtual list  tags '' were wrote inside list items.
When preview document was created there was a XMLSerializer which causes changing  to HTML entities lt;agt; and because of that don't read as a tag.
[Solution]: Change method of translation to string from XMLSerializer to innerHTML.
Signed-off-by: Wojciech Szczepanski<EMAIL_ADDRESS>

@wszczepanski97 please update PR description in accordance to commit message description


Invalid credentials for creating a security connector

When trying to use ComputeEngineCredentials in the cloud with the appropriate scopes enabled. I get the following message.
E0702 01:48:43.739044608   30877 credentials.c:131] Invalid credentials for creating a security connector.
LOG: Channel created.
LOG: Making RPC.
LOG: RPC failed with error code 2, and message "Rpc sent on a lame channel".

The OAuth token obtained using the metadata server works when directly used with curl.
Please let me know what debug information I can provide.

Can you provide a code snippet demonstrating the channel creation ?

This is the relevant code snippet. The environment variable GOOGLE_APPLICATION_CREDENTIALS was unset, and this was run on a newly spun-up cloud instance with the right scope configured at instance setup time. I will be happy to run the code again if better logs can be collected.
auto creds = grpc::GoogleDefaultCredentials();
grpc::ChannelArguments channel_args;
grpc::CreateChannel("genomics.googleapis.com:443",
                    creds,
                    channel_args));


gridmass error NullPointerException

Basic information

My operating system: Windows10Home
My MZmine version: 3..0.21

What happened

Please describe what happened and how it differs from what you expected to happen.
i use gridmass to detect features but at 80%-90% of processing it displays an error (see below). I tried different settings, including default, no different results.
previously, Using 2.53 version of mzmine2 it worked normally and i get results

Please include all parameter values for the MZmine modules you used.
I uploaded raw files thermo files, cropped only positive masses
for this bug just consider default settings of gridmass

Please upload screenshots of any errors and your log/mzmine.log file.
2022-04-08 14:03:12 SEVERE io.github.mzmine.taskcontrol.impl.WorkerThread run Unhandled exception java.lang.NullPointerException: Feature list of the sameRangePeak is null. while processing task Detecting chromatograms (RT) in ACE1A.raw
java.lang.NullPointerException: Feature list of the sameRangePeak is null.

Please upload an MZmine project file that demonstrates the problem you are reporting.
MZmine error.txt

Hi Geert,
thanks for the report.
In fact we noticed the same issue as well. Unfortunately, we lack the insight to the gridmass algorithm to maintain it, which is why we deactivated it for the next relase. For the time being, we recommend the ADAP chromatogram builder.
You can check out our new docs to see how it works: https://mzmine.github.io/mzmine_documentation/workflows/lcmsworkflow/lcms-workflow.html

Hi Geert,
We have never seen many people use the gridmass algorithm. Maybe also because it was using a lot of memory.
Was this your usual workflow? Was gridmass outperforming the ADAP chromatogram builder + any resolver workflow (previously deconvolution)?

Hey Geert,
thanks for offering your help. The null pointer exception was an easy fix, but the resulting features are weird. you can try to download the build from this pull request (#664) here: https://github.com/mzmine/mzmine3/runs/5980397673?check_suite_focus=true
Please let me know if your features also dont look as you would expect.


feat: action_view: use virtual text for yes/no

on the action_view float menu, make also the [y]es [n]o line a virtual text.

:tada: This issue has been resolved in version 1.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add MF-GUI under Inventories section

Ye ye it's a pog lib pls add ok ty

There are more widely used alternatives to this library with better non-JavaDoc documentation. Thus, this does not feel like a necessary addition to the list.

There are more widely used alternatives to this library with better non-JavaDoc documentation. Thus, this does not feel like a necessary addition to the list.


Not working in BlueGenes deployment: keeps loading

It looks like the visualizer is not working, it keeps loading. See example: http://bluegenes.apps.intermine.org/#/reportpage/humanmine/Gene/6087400

So I checked it, added error handling to it but it doesn't work in deployment. It can only mean that we're not getting passed the right params. Just to confirm, @yochannah does BlueGenes pass the list id for this visualizer?

It should look something like above.

As I mentioned in the chat, this tool is for the list page, which BlueGenes currently don't support tools for yet.
I created an issue and I'll look into adding this sometime this week or the next.
https://github.com/intermine/bluegenes/issues/376
I'll be busy working on something else for a while, but let me know if it's important that this gets fixed quickly, in which case I can prioritize it.

I have implemented this in https://github.com/intermine/bluegenes/pull/378 and bluegenes-GO-term-visualizer is working. Well done!

Sadly you'll only be able to test this yourself by running a local bluegenes instance, with that branch checked out. (Or ask me to test it.)
We haven't deployed an updated bluegenes in ages, but we're looking to do it once Yo's back next week.
I'll close this issue now.


ui: updated selected element style, added wrapper component

Describe your changes:

ui: updated selected element style, added wrapper component

Type of change:

[ ] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@ShaileshParmar11 lets remove the "I" tooltips


Added schemas for useragent parsing

All Done !!

All Done !!

Looks good!

Looks good!

Thanks @AALEKH - this is merged into release/60 - closing...


Feature: Add StateEnvironment.Offscreen

Now that offscreen is in released, you might want to use plasmo-state there.
https://developer.chrome.com/docs/extensions/reference/offscreen/

Looks like the offscreen page should be able to use StateEnvironment.Background - I'll look into this and add StateEnvironment.Offscreen to use the same logic if it works.

Added with 2.1.0


fixing streamlit

Adding streamlit to networks to fix it
Creating default schema creation so that we can issue a VC with streamlit


Yarn 2 / PnP support?

So I am being super dev hipster and testing out Yarn 2, and it seems like no required modules are being included in the compiled file at all – no warnings, no errors, just the files in src and nothing else :)
This might be what I get for being bleeding edge, but wanted to check if this was a known issue (I couldn't find anything in the issues around Yarn 2) before I start testing locally to figure out what is going on.
For reference Webpack requires a plugin to support PnP resolves: https://www.npmjs.com/package/pnp-webpack-plugin

Since ncc is based on the upcoming webpack@5 it should not need a plugin for PnP because the next version of webpack supports PnP out of the box.
Unfortunately the webpack version that ncc uses is a bit aged<EMAIL_ADDRESS>and PnP support was added (if I am correct) in 5.0.0-alpha.20.
Unsure if the team accepts a PR for bumping the webpack version to the latest beta, but would love to see when it gets an update 😇

Thanks for that information. I switched off PnP for now but will test locally with upgraded we pack dependency and see how many errors I get :)


WlanGetFilterList function doc

WlanFreeMemory mentions "Any memory returned from Native Wifi functions must be freed."
Link to article:
https://docs.microsoft.com/en-us/windows/desktop/api/wlanapi/nf-wlanapi-wlangetfilterlist
Problem:
Above doc should contain the same remark as https://docs.microsoft.com/en-us/windows/desktop/api/wlanapi/nf-wlanapi-wlangetinterfacecapability
Remarks
The caller is responsible for calling the WlanFreeMemory function to free the memory allocated

@ginami Can you follow up? I saw the same comment on the bottom of the content. If your team tracks there, I will close it.

thanks @powerhelmsman I've added the comment on doc page. my bad, if it's dup

Hi @cheles -- thanks for bringing this to our attention. We are investigating and will keep you posted.


Add license

We should add the MIT license to the repository.

MIT or Apache 2.0. Would that be possible?

Assuming all contributors are OK, I don't see why not.

In favor of relicensing from MIT to MIT or Apache 2.0 ?

[ ] @victor-teles
[ ] @SuperchupuDev
[ ] @nissy-dev
[ ] @ematipico
[x] @nhedger


Add support for textarea rows

There should probably be a seperate test for textarea.

Hey @kevintraver, thanks for the PR! 👍
I think you're right, there should definitely be a separate assertion for attributes specific to textarea. Also, I realised there are some textarea specific attributes that I forgot to add initially and are missing while looking through the docs. Specifically cols, wrap (plus rows which you added). As well as the form attribute which is not specific only to textarea but good to have.
In any case you could add a new render call at the end of that testcase and move the it sets the rows attribute assertion after and it should be perfect.
this.render(hbs`{{do-control 'textarea' multiple=multiple}}`);
// assert `it sets the rows attribute`

And maybe you can add the missing ones as well and I'll merge after?

Hey, I think I'll add this as is. The reason is that I have some other changes planned for a release that I intend to do shortly.

Ok thanks! We can work on a separate PR for textarea tests.

I've already done this in #7 but I just haven't pushed the code. Incoming!


Solved the bug in uploadtokentranslation API

It will be good to give a description of the change and mention the bug.

-tokens which don't have translation will not uploaded to database.
-duplication of token is solved.


feat: add optimized routines for aarch64

Signed-off-by: SchrodingerZhu<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: close #5240
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/merge


Lua implementation of Casbin

Hello,
I'm wondering if there is a Lua implementation of Casbin in the wild at all? I didn't manage to find any except this one.
And if this repo is a placeholder for the future work, when is it planned to be implemented?
Thank you.

@nodece @techoner @GopherJ

See: https://github.com/casbin/casbin/issues/274#issuecomment-695148008
We will consider to make a new Lua implementation these months: https://github.com/casbin/casbin-lua Maybe let a GSoC student work on it next summer.

Thanks for the info!
Another thing that came to my mind is the implementation of Casbin in C (which is already done by the time I'm writing it). Thus it can be relatively easy used from Lua c-bindings. The upside of this approach is a shared/whatever library that can be used by other (especially interpreted) languages that are not already implemented or a as an option to boost performance - it's rather a common approach (see for instance gRPC core implementation).

Yeah, using C to wrap a Lua lib is an option. But Lua & nginx & OpenResty are so important that we may also consider implementing Casbin directly in Lua. This will be our next goal!

Yeah, using C to wrap a Lua lib is an option. But Lua & nginx & OpenResty are so important that we may also consider implementing Casbin directly in Lua. This will be our next goal!

Actually we want it to be a GSoC 2021 task definitely.
@divy9881 do you have interest in the task of implementing Casbin in Lua?

Actually we want it to be a GSoC 2021 task definitely.
@divy9881 do you have interest in the task of implementing Casbin in Lua?

Moved to: https://github.com/casbin/lua-casbin/issues/2

Moved to: https://github.com/casbin/lua-casbin/issues/2


Update to version 3.6.1

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Required by https://github.com/conda-forge/r-statnet-feedstock/pull/4


sqlboiler: 4.14.2 -> 4.15.0

Diff: https://github.com/volatiletech/sqlboiler/compare/refs/tags/v4.14.2...v4.15.0
Changelog: https://github.com/volatiletech/sqlboiler/releases/tag/v4.15.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


DXVK version string in DXVK_HUD not longer displaying since 2.1

Starting with v2.1, I cannot longer see the dxvk version in the DXVK_HUD, the installation process is the same as in v2.0 for me, and I could replicate the fact that in 2.0 the dxvk version appears in exactly the same environment, wine prefix version etc on my few PC's with amdgpu.
It shows up the same in v2.2.
Is this known, can I override it somehow?

Does this happen with our release builds or only with builds you compiled yourself? Make sure to fetch the git tags.
Somewhat off topic but you should really use RADV instead of AMDVLK.

I am using the release builds.
Hmm, will try to set in the environment AMD_VULKAN_ICD=RADV to see if something changes, maybe performance slightly.

Are you exporting your own DXVK_HUD env variable, and if so, is there a "version" in it?

DXVK_HUD=1
Oh, the documentation changed to require either =full or =version,etc . My bad guys.


if you run sr.AudioFile() and the name of the file it says: ValueError: Audio file could not be read as PCM WAV, AIFF/AIFF-C, or Native FLAC; check if file is corrupted or in another format

Steps to reproduce

(How do you make the issue happen? Does it happen every time you try it?)
(Make sure to go into as much detail as needed to reproduce the issue. Posting your code here can help us resolve the problem much faster!)
(If there are any files, like audio recordings, don't forget to include them.)

Expected behaviour
(What did you expect to happen?)
Actual behaviour
(What happened instead? How is it different from what you expected?)
(If the library threw an exception, paste the full stack trace here)

System information
(Delete all the statements that don't apply.)
My system is . (For example, "Ubuntu 16.04 LTS x64", "Windows 10 x64", or "macOS Sierra".)
My Python version is . (You can check this by running python -V.)
My Pip version is . (You can check this by running pip -V.)
My SpeechRecognition library version is . (You can check this by running python -c "import speech_recognition as sr;print(sr.__version__)".)
My PyAudio library version is  / I don't have PyAudio installed. (You can check this by running python -c "import pyaudio as p;print(p.__version__)".)
My microphones are: (You can check this by running python -c "import speech_recognition as sr;print(sr.Microphone.list_microphone_names())".)
My working microphones are: (You can check this by running python -c "import speech_recognition as sr;print(sr.Microphone.list_working_microphones())".)
I installed PocketSphinx from . (For example, from the Debian repositories, from Homebrew, or from the source code.)

This seems to be duplicated to #673


Pom file does not use aar on support-v4 dependency

support-v4 is packaged as a aar, so the pom file generated has to specify that. The pom file on maven central and jcenter does not.

Should be fixed now (#123).


ErrConnectionClosed isn't ever returned

If the connection to the server is closed remotely, and there is an attempt to make a query, either an io.EOF error  (upon getting a response) is returned or gorethink: gorethink: write tcp <IP_ADDRESS>:28015: broken pipe (upon writing the query) is returned from .Run(session).
I would expect that ErrConnectionClosed would be returned instead, but it isn't ever used throughout the library.

ErrConnectionClosed is returned when a query is executed using a connection/session that has been closed using Close not when the connection is closed by the server.
The driver could possibly parse the returned errors and close the connection if certain errors were returned but I dont think that is a necessary.

Hm, currently I get a panic: runtime error: invalid memory address or nil pointer dereference if I attempt to .Run(session) when the session had been closed earlier with session.Close(). Querying a closed connection will theoretically just return nil as an error: https://github.com/dancannon/gorethink/blob/master/connection.go#L107-L110
Did you mean to return ErrConnectionClosed instead?

Hmm ok that is an issue! Sorry for missing that earlier. I will look into that now.

This should now be fixed, thanks again.


Added Chat implementation

Description
This PR includes several updates and enhancements:

🗃 Added message seeder and factory.
🗃 Added chat room seeder and factory.
🗃 Updated ChatRoom entity and added JoinColumn for userId.
🗃 Added JoinColumn in ChatRoom for userId.
🗃 Added migration for ChatRoom implementation in entities.
🗃 Linked ChatRoom entity to Message and User entities.
✨ Added ChatRoom module.

Type of Change
Please indicate the type of change included in this PR:

[ ] Bug fix (resolves a specific issue)
[ ] New feature (introduces new functionality)
[x] Enhancement (improves existing functionality)
[x] Documentation update
[ ] Other (please specify):

How to Test

Run the application using the root dev script.
Ensure all environment variables load correctly in the backend.
Run migrations and execute the seeders to populate the database.
Confirm that the API's code formatting adheres to the project standards.

Verification Checklist
Please verify the following:

[x] Code quality and architecture
[x] Performance impact
[x] Potential security issues
[x] Documentation completeness
[ ] Test coverage validation

Suggested Reviewers
Please check this PR before accepting this one, as this PR is based on it to include those changes and allow me to update this accordingly.

@RodSoriano

Labels

enhancement

I did already I think it worked


feat: add couchbase 4.1.6 release

update couchbase with release 4.1.6

:tada: This PR is included in version 1.217.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix pointer arithmetic instead of concat

"my number " + 5 does not produces "my number 5" but rather "mber ".
If the number was greater than len(string) + 2
(pointing to the \0 and one past the end in authorized, more in UB)
the result would have been undefined behaviour.
Concatenate the number with a string stream.

:+1:
@dawagner @Makohoek


merge from template-sync/template-arlac77-github

package.json

BREAKING CHANGE: add >=22.7.0 remove >=22.5.1 (engines.node)
fix(engines): add >=22.7.0 remove >=22.5.1 (engines.node)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.219%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
109

Relevant Lines:
109

💛  - Coveralls


Wrong image import

I've imported a JPG file and what I get is this:

Here the image:

What's your browser/version and exact steps to reproduce? I've imported the above image into excalidraw and it works on Chrome 95. Do you have a URL for the original image?

What's your browser/version and exact steps to reproduce? I've imported the above image into excalidraw and it works on Chrome 95. Do you have a URL for the original image?

I'm using Google Chrome Version 95.0.4638.69 (Official Build) (x86_64) on MacOSX 10.15.7
Here the steps:

Here is the link: https://i.imgur.com/YevzSsT.jpg

Can't repro on my devices. You could try installing Chrome Beta 96 to see if this is fixed (you can install here https://www.google.com/chrome/beta/) — I have a suspicion it may be fixed there.


[AKS] Azure field client-side validation

What kind of request is this (question/bug/enhancement/feature request):
enhancement
Steps to reproduce (least amount of steps as possible):
Add a bad ssh key to Azure, like random data.
Azure will attempt to provision, taking a few minutes but then fail
Azure will fail with a validation error that the SSH key is bad
Improvement
We now do SSH key validation client-side which should catch invalidatlely formatted ssh keys or private keys before sending them to Azure for validation.
Other details that may be helpful:
This will allow for quicker feedback to user when creating AKS clusters.

Available in master


Replace all underscores in a handle, not just the first

Closes #24

Thank you for your contribution！
LGTM！

This change will be included in the next release v0.7.3. Thanks.


Support multiple attachments

This change adds support for multiple attachments, allowing callers
to create a share extensions that can select more than one item to
share.
This change adds a dataMulti() function to the share extension, which
instead of returning a single item returns an array of items, the original
data() function is unchanged, so this change is backwards compatible.
The change only adds this support to iOS, not Android.

I should have put this is a separate branch, this change only pertains to the first commit, not the second, I can clean up if you think you want to accept this.

It looks like some similar work has been done on the java side: https://github.com/alinz/react-native-share-extension/pull/34/files
It would be nice to get the behaviour the same on both.

@markdaws i tried your markdaws/react-native-share-extension@6dee20e which worked but there still is one problem i have maybe u can help me on that. I could share an image and open up my Host Application, but unfortunately the image i shared was not available anymore when the ShareExtension was closed. Any ideas what i am missing? I am using AppGroups and my Image path looks like this: file:///var/mobile/Media/PhotoData/OutgoingTemp/0C37E764-DB6A-4A3D-9BCD-174E4BDFB1FA/IMG_0616.JPG

Please take a look at https://github.com/alinz/react-native-share-extension/pull/84 as well. Since this PR supports both platforms, it’s more likely we’ll merge that one.
You’ve got a good understanding of the issue, so a review and collaboration on that PR would be greatly appreciated.


Open in embedded/external browser does not provide access token

When I try out a simple example, I cannot get it to run in the embedded or external browser when launching it from VSCode.
It just shows this page

It seems that the access token is not provided by this VSCode extension.
If I click on marimo -> Show Terminal. I see the following and the contained link works
marimo edit test.py --port=2723 --headless
        Edit test.py in your browser 📝
        URL: http://localhost:2723?access_token=...

I can also start the same file from a regular terminal successfully using
marimo edit test.py

We just added auth to marimo cli by default. I can make this configurable (and likely off by default since most vscode development is local)

@niowniow I just released v0.2.2. Can you upgrade and give it a try?
I also added Export notebooks as: html, markdown, or scripts.

That was fast. I can confirm that it works know. Thank you!
Also export works. I expected some form of confirmation, though, like some indicator that the export was successful.

@niowniow there is a toast in the bottom right when the export is finished


Typo on verifying security

https://docs.microsoft.com/en-us/azure/migrate/how-to-set-up-appliance-hyper-v#verify-security
In that specific step you're asking to verify the security on the AzureMigrate.ova file however we're on the Hyper-V scenario thus we never have to download the OVA, we downloaded the VHD ;-)
Olivier

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0aaa51e6-31dc-a56a-3c63-e5f4ea815ac1
Version Independent ID: a1207bbd-b81a-e6df-0826-876cafa9e5bc
Content: Set up an Azure Migrate appliance for Hyper-V
Content Source: articles/migrate/how-to-set-up-appliance-hyper-v.md
Service: azure-migrate
GitHub Login: @rayne-wiselman
Microsoft Alias: raynew

Thanks for your comment. We are actively investigating and will get back to you shortly. Thanks for your patience.

@Olileger  A PR has been successfully deployed to resolve the typo. The fix will be live shortly.
Thanks again for catching this.
we will now close this issue but don't hesitate to reply if you have any follow up questions.
Cheers


fix side bar scrolls after clicking on lower item

fixes #828
MainLayout was used inside pages like Network, Storage, etc. When top level react-route is changed, MainLayout will be mount again. The Sidebar will be mount again as well. As a result, the side bar scrolls to the top. The pull request moves MainLayout inside App component to fix the issue.

@ixrock Thanks for your review. The main area missing issue is fixed in the latest commit. About no scrollbar in the sidebar, I couldn't reproduce on my machine.

@wangyangjun please try to reduce window size to about 1100 to reproduce scrollbar issue, the layout should switch a bit at this breakpoint

@ixrock reproduced the issue, will fix it later

@ixrock fixed with an update. Please review it again.


Basics of scenekit snapshots

Made SCNScene snapshot capable by creating an SCNView, sticking in the scene, and then SceneKit has first class support for taking a snapshot.
unfortunately you have to bake the size of the snapshot into the snapshotFormat function, which probably isn't write. I think it's prob way more likely to create your own scene view, slap in the scene, and then snapshot it. but whatev, this was fun anyway.

lol gonna close, will pick up once we get custom snapshotters


New manage tokens modal

What does this PR do and why?
Attempts to address user confusion with Manage Tokens modal by adding short descriptions to buttons.
Screenshots or screen recordings

state
img

Has print ticket permission, canPrintPreminedTickets is false

Has print ticket permission, canPrintPreminedTickets is false

Doesn't have print ticket permission

Project has no overflow (can't "redeem" any ETH)

Acceptance checklist

[x] I have evaluated the Approval Guidelines for this PR.
[x] I have tested this PR in all supported browsers.

This is great @aeolianeth. Definitely necessary, I remember being quite confused with these when I first came across it myself.

One thought, should we use solid chevrons like we do in the rest of the app (e.g. reconfig modal)?

Thanks @johnnyd-eth, great suggestion! Applied it, would you mind giving this a code review now? 🙏

This is a great improvement @aeolianeth.
Few thoughts:

Should we have tooltips for any case where a card is disabled? e.g. redeem button has no tooltip when user has no tokens in the project.
Might be out of the scope of this PR, but while we're on this modal, I've noticed there's no limit on the 'Redeem tokens for ETH' input. Maybe we should make input go red when total token supply is exceeded, and replace the 'You will receive minimum 0 ETH' for an error message?

This is a great improvement @aeolianeth.
Few thoughts:

Should we have tooltips for any case where a card is disabled? e.g. redeem button has no tooltip when user has no tokens in the project.
Might be out of the scope of this PR, but while we're on this modal, I've noticed there's no limit on the 'Redeem tokens for ETH' input. Maybe we should make input go red when total token supply is exceeded, and replace the 'You will receive minimum 0 ETH' for an error message?

Thanks for a great review @johnnyd-eth, appreciate your thoughtful suggestions!
I've added the conditional tooltip, and created a follow-up issue for the input field: https://github.com/jbx-protocol/juice-interface/issues/652

@johnnyd-eth made a few more improvements based on our chat earlier:

@aeolianeth Yep love those changes, linking to the investopedia is a great idea. Nothing more to add from me. Great improvement!


Lineheight behaves differently on ios and android

Description
On ios:

On Android:

note how the on android it seems like the line height is only applied on top of the text, while on ios it's applied to both top and bottom. This is also an issue when you have lineheights < fontSize. On ios it trims from the top, but on android it'll trim from top and bottom, so the text doesn't line up and get's truncated differently.
Reproduction
RNplay demo: https://rnplay.org/apps/OJFGEg
Additional Information

React Native version: 0.36
Platform: iOS & Android
Operating System: MacOS

Just ran into this issue, can confirm still exists

Ditto, can confirm that I'm still seeing this on RN v0.45.0 (latest).
It's not apparent to me if this is intended behavior based on the corresponding underlying native capabilities, or rather an unintentional discrepancy.
I'd just like to add that it certainly makes achieving a consistent layout between both platforms challenging, in achieving parity with pre-designed screens. I've resorted to disabling lineHeight on Android in the interim, as I'm unable to control how exactly the text appears.
Is this on anyone's radar by chance?

I did a little test on CustomLineHeightSpan.java. It works on new pure Android project but not on RNTesterApp. I am still investigating what the different between ReactNative TextView and PureAndroid TextView. I would like to pair with ReactNative core team to work on this investigation (if possible).
The idea is simple: use descent and baseline as base metrics, then recalculate bottom, ascent and top based on fontSize and lineHeight. ascent and descent will be centered.
// Copyright 2004-present Facebook. All Rights Reserved.

package com.facebook.react.views.text;

import android.graphics.Paint;
import android.text.style.LineHeightSpan;

/**
 * We use a custom {@link LineHeightSpan}, because `lineSpacingExtra` is broken. Details here:
 * https://github.com/facebook/react-native/issues/7546
 */
public class CustomLineHeightSpan implements LineHeightSpan {
  private final int mHeight;
  private final int mSize;

  CustomLineHeightSpan(float size, float height) {
    this.mSize = (int) size;
    this.mHeight = Math.max((int) height, mSize);
  }

  @Override
  public void chooseHeight(
      CharSequence text,
      int start,
      int end,
      int spanstartv,
      int v,
      Paint.FontMetricsInt fm) {
    int spacing = (mHeight - mSize) / 2;
    fm.bottom = fm.descent + spacing;
    fm.ascent = fm.descent - mSize;
    fm.top = fm.descent - mSize - spacing;
  }
}

Checkout my proposal for CustomLineHeightSpan.java fixed. https://github.com/henrytao-me/react-native/pull/1.

Same problems with fonts on RN: 0.44.0. There are few issues as far as I know about this, or very similar behaviour.

It's a big problem for me. I'm working on a project in which correct font rendering is critical. As a temporary workaround I have applied lineHeight bigger than fontSize.
I also added paddingBottom and marginTop to negative value. I had to manually adjust these values for each font. This was to prevent Text component from growing due to increased line height. But it's not a production solution, I don't recommend that, this was my last resort.

@henrytao-me it seems that you've made a pull-request against your own forked react-native repo whilst you should have made it against the Facebook repo.

Thanks @peterp for suggestion. Some how I missed this conversation. I will create new PR soon.

Facing the same issues...any alternatives??

I've opened a PR solving this problem, the reason I worked on a simpler solution than @henrytao-me PR is that the # of cases in this particular problem are high and the only difference between Android and iOS rendering is the priority of ascent over descent. The change in #16488 touches only that and adds some unit test coverage for confidence that nothing potentially breaking is changing. I'm hoping this will make it easier to land this fix soon.

Thanks @bartolkaruza. I was busy recently on other stuffs. 🙇

Thank you @guidobouman, I've edited my reference as well.

It is on the 0.52-stable branch. I think there is 0.52 rc you could point
to if you need it right now.
http://www.immidi.com/
Bartol Karuza
<EMAIL_ADDRESS><EMAIL_ADDRESS>/ +31 6 132 131 01
immidi / KvK 61657395
http://www.immidi.com http://www.courgetteconcepts.com/
[image: Linkedin] https://nl.linkedin.com/in/bartolkaruza
On Fri, Dec 22, 2017 at 3:42 PM, Max<EMAIL_ADDRESS>wrote:

Any updates on getting this in a release? I saw it brought up in the 0.51
issue thread but it doesn't seem to have been released. Let me know if
there's anything I can do to help speed things along.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/10712#issuecomment-353610703,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABiAYyFYRj79yBvl-N8oY6_lG4YfMw_4ks5tC7_lgaJpZM4Kn4t3
.

This should be resolved now that https://github.com/facebook/react-native/commit/74e54cbcc408a8bbdd70f47cc8728d30cdc0d299 landed.

I faced this problem again in my RN 0.59.5 on Android 9.0 users. Users on Android 8.0 and 7.0 are working fine.

Currently, I fixed the issue by providing lineheight in the text style.
text: {
    fontSize: 16,
    lineHeight: 26,
    paddingVertical: 5
},

Not sure if other folks are experiencing this, and not sure if it's only with Expo for whatever reason, but lineHeight: 0 does nothing on iOS while on Android it basically hides the text. Thought my fonts weren't loading on Android because of that 🤦🏽♀


vagrant up controlplane fails on Windows machine

    controlplane: Removing insecure key from the guest if it's present...
    controlplane: Key inserted! Disconnecting and reconnecting using new SSH key...
==> controlplane: Machine booted and ready!
==> controlplane: Checking for guest additions in VM...
==> controlplane: Setting hostname...
==> controlplane: Configuring and enabling network interfaces...
==> controlplane: Mounting shared folders...
    controlplane: /var/sync/linux => C:/Users/jsturtevant/sig-windows-dev-tools/sync/linux
Vagrant was unable to mount VirtualBox shared folders. This is usually
because the filesystem "vboxsf" is not available. This filesystem is
made available via the VirtualBox Guest Additions and kernel module.
Please verify that these guest additions are properly installed in the
guest. This is not a bug in Vagrant and is usually caused by a faulty
Vagrant box. For context, the command attempted was:

mount -t vboxsf -o uid=1000,gid=1000,_netdev var_sync_linux /var/sync/linux

The error output from the command was:

: Invalid argument

lowered cpu/memory variables but otherwise left everything untouched:
linux_ram: 2048
linux_cpus: 2
windows_ram: 4096
windows_cpus: 2

going to try:
vagrant plugin install vagrant-vbguest

That seems to have worked, I got further:
controlplane: /tmp/vagrant-shell: line 131: /var/sync/shared/kubeadm.yaml: No such file or directory
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
 should be in the log above. Please read the output to determine what
 went wrong.

sounds like right now, we need to own the story for users to use windows from beggining to end.  as of now only @FriedrichWilken has done this succesfully, and in that case he used hyperv....

@jsturtevant you don't have make on Windows, so I assume you only run vagrant up, right?

yes. regarding the first error, I was running on windows without make, so I ran the vargrant up directly and missed the part in the makefile https://github.com/kubernetes-sigs/sig-windows-dev-tools/blob/9b8f4452f009c4330c817f05f8886e0be2b53624/makefile#L38
Some of the instructions in the read me tell you to install plugins others don't. Since Windows won't always have make, we should find a way run these scripts cross platform

I just published a Vagrant setup which works on Windows here: https://github.com/lippertmarkus/vagrant-k8s-win-hostprocess
I originally started trying to extend your existing work but couldn't get it running. It uses Hyper-V, plain Ubuntu/Windows Server 2022 boxes as well as HostProcess Pods to deploy Calico and kube-proxy to Windows. I tried to make it as simple as possible and provide a walkthrough in README
Although not integrated, I hope that helps you anyway with making progress to support running the Dev Environment on Windows machines and adding HostProcess and Windows Server 2022 support.


Support injecting data to pods with init containers

Is your feature request related to a problem? Please describe.
Currently, if a pod that is to receive a data injection has an init container, Zarf will become stuck in an infinite loop. When Zarf deploys the manifests it waits until the pods that it deploys report that they are healthy, which only happens after the init containers finish. Meanwhile, the init container is waiting until the data injection has happened, which doesn't happen until after deployment of the components, which doesn't happen until all the pods report that they are healthy.
Describe the solution you'd like
Zarf should inject data asynchronously as the pods that it is injecting into are available, even if it is just an init container
Describe alternatives you've considered

Change Zarf to not wait -- Breaks the Seed Registry stuff.
Modifying Zarf to support an extra parameter in zarf.yaml for wait: false -- More of a bandaid than a real fix.
Modify the application container to not require an init container -- Not a realistic request since we don't maintain the applications that users of Zarf use.

#422 modifies the data-injection demo to demonstrate this problem
#420 is a proposed temporary bandaid solution that likely won't make it into master
@jeff-mccoy and @YrrepNoj are working on a more permanent solution that moves the data: block from the root of zarf.yaml into the component that is tied to the pod that the data needs to be injected into


Impossible to connect to webviewer

Describe the bug
When training a model or loading a checkpoint, the given viewer address do not lead to any page.
To Reproduce
Steps to reproduce the behavior:

Train a model
Ctrl + Click on the address of the viewer
A blank page with the error message : "This webpage in unreachable" opens

Expected behavior
The webviewer should open.
Additional context
The given address seems to be wrong. It is by default : "http://<IP_ADDRESS>:7007".
This only happens when installing from source. It works fine with pip install.

Yeah, we should make this clearer. It's currently the host address the server is listening to, which is not necessarily a valid IP address: https://stackoverflow.com/questions/20778771/what-is-the-difference-between-0-0-0-0-127-0-0-1-and-localhost

But will this be solved shortly? Because I want to implement my own models, but also pull from source the latest features and merge them with Git, without having to sort everything manually.

Try going to http://localhost:7007/ for the viewer, this seems to work on Windows

Yeah, the server should be accessible by connecting to whatever machine you're running on. If you're running locally http://localhost:7007 should work (as pointed out by @cvachha), if you're running on a remote server (assuming no firewalls) and you know IP address you can also connect to http://that_ip:7007, for SSH a common practice is also just to forward the port: https://docs.nerf.studio/quickstart/viewer_quickstart.html#training-on-a-remote-machine
As an experimental thing, you can also pass in --viewer.make-share-url True and you should get a publically accessible https URL at https://[some random string].share.viser.studio.

But will this be solved shortly? Because I want to implement my own models, but also pull from source the latest features and merge them with Git, without having to sort everything manually.

This is actually working as designed; <IP_ADDRESS> is the host address that the webserver is bound to. It's just a bad design because this isn't an IP address that you can necessarily connect to... we should print something clearer, but the fix wouldn't impact your ability to connect to the viewer.
The server should still be accessible by connecting to whatever machine you're running on. If you're running locally http://localhost:7007 should work (as pointed out by @cvachha), if you're running on a remote server (assuming no firewalls) and you know IP address you can also connect to http://that_ip:7007, for SSH a common practice is also just to forward the port: https://docs.nerf.studio/quickstart/viewer_quickstart.html#training-on-a-remote-machine
As an experimental thing, you can also pass in --viewer.make-share-url True and you should get a publically accessible https URL at https://[some random string].share.viser.studio.

Just having to click on the link in the console definitely makes things smoother.

Try going to http://localhost:7007/ for the viewer, this seems to work on Windows

Why does a blank screen appear when I click

Try going to http://localhost:7007/ for the viewer, this seems to work on Windows

Why does a blank screen appear when I click

If you are running ns-train and running locally at port 7007, the page should take you to the viewer


Gather information on Apache infrastructure and available tools for running CI

research about Jenkins and infrastructure constraints for running the workload

research about Jenkins and infrastructure constraints for running the workload

Gathering document: https://docs.google.com/document/d/1F1FIwGN0W3KEQbYLJz5pYOwDV2qmKONpeixlTD6w6cw/edit?usp=sharing

Closing this as done. The document is the reference.


Can't edit message in "All messages" screen

When long-pressing a message in the "All messages" screen, a list of options appears, same as elsewhere in the app.
Unlike elsewhere in the app, that list of option doesn't include the "Edit message" option even when you're long-clicking your own messages.
I know this isn't a matter of the edit timer having expired or something, because in the case where I discovered this, I was unable to edit a message from the "All messages" screen, but I was subsequently able to edit it from another screen, showing the option should still have been available.

I would like to work on this issue. It seems to be possible by allowing the editMessage option on the action sheet for the HomeNarrow screen.
Then, similar to when you click reply, you're taken directly to that particular chat screen with that message.

Thanks! Assigning this to you, @anshuman-8 . Just to check, were you able to replicate the issue?

@alya
Yes, I was able to understand and replicate it.
Working on it!

Hey @alya,
Just had a doubt. I was trying to get the ComposeBox (message input component) in the "All messages" screen only when someone selects a message to edit. The issue is in ComposeBox file; it checks and works only for narrow which are conversations, but "All messages" is not a conversation.
// src/compose/ComposeBox.js
  const destinationNarrow = useMemo(() => {

  //...

    invariant(isConversationNarrow(narrow), 'destination narrow must be conversation');
    return narrow;
  }, [isEditing, narrow, topicInputState.value]);

So, should I make an exception for the "All messages" screen everywhere, or think of a different approach?

Hi @anshuman-8, thanks for volunteering to work on this! Yeah, unfortunately more work is needed before we can really support editing messages in the "All messages" screen, and for a beginner I would recommend choosing a different issue to work on.

To expand on @chrisbobbe's last comment above: the root of this issue is that our current UI for editing a message is tightly bound up with the one for composing a new message. Quoting a summary I wrote elsewhere:

In general the edit-message UI in the mobile app is somewhat unloved; as you noted, the UX for it is borrowed from composing a message (and rather awkwardly so), and the code to implement editing a message is likewise rather jammed into the code for composing. One consequence is that it's easy to accidentally pick up behaviors that compose has even when they aren't intended.

We don't have a UI for composing a new message on the "All messages" screen, because that'd require a significantly more complex compose box that would be tough to make a good experience on mobile. (The complexity of options there for choosing where the message goes would be similar to the compose box on web/desktop — which was a recurring focus of user confusion for a very long time, and for that reason has had probably more complete overhauls than any other component in the web app.) Ergo, because our UI for editing a message is closely tied to that for composing one, the "All messages" screen doesn't support editing a message either.
The path to fixing this therefore runs through disentangling editing from composing — at the code level, at a minimum. Because this codebase is now in maintenance mode as we're focused on building a new Zulip mobile app in Flutter, we won't end up doing that work here. But we'll certainly work to avoid that level of entanglement when we go to implement editing in the Flutter app:

https://github.com/zulip/zulip-flutter/issues/126

And then it should be straightforward to support editing in the "All messages" screen just like on the other message-list screens.
(Thanks @PoignardAzur for the very clear report!)


Set Custom Response Headers Feature Request

Hi PostgREST team,
Been reading through the docs and building out a test schema for most of the day. I found how to access request headers but haven't found if it is possible to add response headers from rpc stored procedures. If it's not already a capability, I think it would be really useful. My use case would be for adding Set-Cookie headers that would store the JWT token as well as a second cookie with their user_id and whether they were recognized originally with a password or from an email link.
Since HTTP request headers seem to be the preferred method for modifying query responses, I think it would make sense for there to be a way to set Response headers as well. Having NGINX or application server code parse the postgREST rpc/authenticate server response before sending to the client seems really inefficient. I also don't want to set the cookie on the client they should be set as HTTP ONLY to prevent client side javascript from sniffing the value of the JWT cookie and trying to hijack the users session.
Thanks for your consideration of this feature and all your work!

Why would parsing the response in ngxin in order to add the additional header be inefficient?

@ruslantalpa, although I don't think settings headers in nginx is inefficient, I like the idea of being able to add respond headers within an RPC, because sometimes only within the RPC you know your data and you can set your right headers. nginx (after getting the response back from backend) can set headers yes but more like general purpose headers. not specific, data-releated headers.

This has been a feature we've discussed every now and then. For instance Ruslan once created a pull request to allow stored procs to set cookies, and then we discussed generalizing to setting any kind of response header:
https://github.com/begriffs/postgrest/pull/664#issuecomment-231635405
If one of the approaches in that thread is viable I think it would be a pretty awesome feature. As you mentioned, @omani, the procedure has inside access to any data it needs to determine the headers. Nginx has more limited access to make those decisions.

In case you guys haven't seen it yet, we've got a PR now to help with this! https://github.com/begriffs/postgrest/pull/986

Implemented in #986.


Fix HTML descriptions in supplier registration forms

Supplier registration questions are manually using toolkit form templates, so they were affected by the removal of safe filters from the toolkit.

:+1: gonna merge this and get it on to Preview now.


Synced providers

Synced the providers file. Added manually missing provider patterns and more tests checking differentiating between video/rich type links and photo type links.

@CodeBast4rd thank you, I've merged and released v1.2.3


Default consent wait_for_update cannot be 0

When reviewing your template we've noticed that the setDefaultConsentState call does not always include the wait_for_update option. If the users set it to 0, this option is skipped. A non-zero value is required for any asynchronous consent management script load to delay tag execution.

Thanks for the update. Two notes:

Users are still able to set wait_for_update to 0. To prevent that, you can change the validation logic on wait_for_update to

"valueValidators": ["POSITIVE_NUMBER"],

Please update the sha value in metadata.yaml to match the latest version.

Thanks for your notes.
wait_for_update  valueValidators is set to POSITIVE_NUMBER
metadata.yaml is updated

Thanks for making the change. One last problem: the order of commits in metadata.yaml is backwards. The latest version should be at the top.

The order of commits in metadata.yaml is changed.


Add blurb to README.md clarifying that only Python versions >=3.6 are supported

🗣 Description
Add a blurb to README.md stating that only Python versions 3.6 and greater are supported.
💭 Motivation and Context
This change is motivated by the discussion in #1.
🧪 Testing
I ran all the pre-commit hooks and verified that they all passed.
🚥 Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (causes existing functionality to change)

✅ Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Why don't we make this explicit in setup.py with a python_requires='>=3.6'
https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires
https://stackoverflow.com/questions/45778790/specifying-the-minimum-python-version-required-for-a-module-in-pip
Probably backport this to the skeleton too.

Is this in addition to the "Requirements" section or instead of it?

In addition.  I thought you were away.  I just pushed the change up in
8c610d4


add Firrtl plugin info for intellij platform

I developed a Firrtl plugin for intellij platform.
Currently it support Syntax highlighting, Structure View and jump to the corresponding Chisel code by navigate(Ctrl+Click) the Firrtl fileinfo comment.
plugin:
https://plugins.jetbrains.com/plugin/14183-easysoc-firrtl
code:
https://github.com/easysoc/easysoc-firrtl

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Just tried it out. Syntax highlighting is awesome!
Unfortunately the jump to Chisel did not seem to work for me. Maybe it was unable to find the scala file since it is in my test directory.

Just tried it out. Syntax highlighting is awesome!
~Unfortunately the jump to Chisel did not seem to work for me. Maybe it was unable to find the scala file since it is in my test directory.~
Never mind, it does work! I just didn't try to do Ctrl + Click and was trying my regular Ctrl + B instead. This is great!

Thanks, I will add Ctrl + B support in the next release

Could you also add a link to the source code? A lot of our audience are developers some of whom might be interested in contributing to your plugin.
Besides that, great work!

I have changed the plugin url to it's github source.

I have changed the plugin url to it's github source.

Sorry, what I mean was: something like:
Firrtl syntax highlighting, structure view, navigate to corresponding Chisel code for IntelliJ platform: [install](https://plugins.jetbrains.com/plugin/14183-easysoc-firrtl), [source](https://github.com/easysoc/easysoc-firrtl)

@ekiwi sorry, for a clean history, I open a new pull request https://github.com/freechipsproject/firrtl/pull/1547


CSharp Module tweak & Unity Tutorial part 1, 2b, 3 tweaks

Small tweaks to CSharp module index.md:

Added .Tag property to docs
Revised example usage for both Is* usage and .Tag usage
Fixed "Two" to "Four" in special reducer section
Added examples for each [SpacetimeDB.Reducer(ReducerKind.XXX)]

Small tweak in Unity tutorial part-1.md:

Fixed hyperlinks to Rust CSharp part-2

Fixed typos and mistakes throughout part-2b-c-sharp.md:

Changed Identity to uint in Config table
Updated Throw typo to throw
Updated logging to correctly use $""
Fixed [SpacetimeDB.Reducer(ReducerKind.Connect)] typo (it said Init before)
Removed extraneous publish block, as there was already one at the end
Fixed UpdatePlayerLoginState() error by switching private to public for compile

Fixed typos and clarified filenames in first-half of part-3.md:

Renamed GameManager.cs throughout to BitcraftMiniGameManager.cs
Added path clarifications to various filenames throughout
Fixed typos on PlayerComponent.FilterByOwnerId => PlayerComponent.FilterByIdentity instead
Removed .FirstOrDefault();'s from UIUsernameChooser.cs as not needed
Corrected .Text to .text on UIUsernameChooser.cs

My changes stop at around the **Append to bottom of RemotePlayer class in RemotePlayer.cs:** - L230.
The tutorial, or the code files provided are completely outdated and cannot be followed. I noticed that @dylanh724 has a PR #37 which likely fixes these issues, and probably some of the issues I fixed above.
Anyway, I figured that I would provide my tweaks in case they are helpful to you, no worries either way.

Other than the outdated sections due to the new breaking API changes, this looks good, thanks!


[FEATURE] Support PlusCal specs

The PlusCal translator removes all comments when translating an algorithm to TLA+.
---- MODULE Foo ----

(*--algorithm OneBitClock {
  variable
    \* @type: Int;
    clock \in {0, 1};
  {
    while (TRUE) {
      if (clock = 0)
        clock := 1
      else
        clock := 0
    }
  }
}*)
\* BEGIN TRANSLATION (chksum(pcal) = "d384ffcd" /\ chksum(tla) = "8dd09982")
VARIABLE clock

vars == << clock >>

Init == (* Global variables *)
        /\ clock \in {0, 1}

Next == IF clock = 0
           THEN /\ clock' = 1
           ELSE /\ clock' = 0

Spec == Init /\ [][Next]_vars

\* END TRANSLATION
====

Related to #1436


fix(InteractGrab) Protect against objectToGrabScript.grabAttachMechanicScript being null - fixes #1274

Quick and easy, NRE fix (I have no idea if the reference is supposed to be there still or not - doing this fixes my immediate issue)

There were the following issues with your Pull Request

Commit: 98feb44b8be2ec48930fc400f8514e655925f739
Your commit message body contains a line that is longer than 72 characters
Commits must be in the following format: %{type}(%{scope}): %{description}
Your subject line is longer than 72 characters

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

There were the following issues with your Pull Request

Commit: 4767f03b0b4ad6e562a7ee20a15c0be3b72740f8
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

@trumpetx "description" need to start with lowercase

gitcop didn't yell at me.

PR that supersedes this one:
https://github.com/thestonefox/VRTK/pull/1276
The linked PR goes a lot further in protecting against null reference exceptions rather than just the one line.

superseded by https://github.com/thestonefox/VRTK/pull/1276


Cleanup mesh caching

Any feedback is welcome.
I want to be sure that I not forgot any corner case