Project revisions/amendments committing workflow based on the revision status

Description:
We'll need @nanyangpro and @suhafa to confirm the workflow of committing a revision when we change this status. some context around this card:

https://github.com/bcgov/cas-cif/issues/1166#issuecomment-1359945669
https://github.com/bcgov/cas-cif/pull/1233#issuecomment-1344929231

Acceptance Criteria:
Given
When
Then
Development Checklist:

[ ] Checklist item
[ ] Checklist item
[ ] Checklist item
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

Specifically, we'll need to decide what happens when a user selects "Applied" or "Approved" status on an open project revision, and if this is an acceptable way of committing a project revision

This card may affect this issue as well: https://app.zenhub.com/workspaces/climate-action-secretariat-60ca4121764d710011481ca2/issues/gh/bcgov/cas-cif/1284

Changing the "Status" of a Revision Record to "Approved" for Amendments or "Applied" for General/Minor Revisions is when the changes should be committed to the database and reflected on other front-end forms. We need additional ux designs to make sure the user is aware of the differences/impacts before and after taking the action.

Please add your planning poker estimate with Zenhub @dleard

Backlog refinement (Feb 22, 2022): There are still a lot of outstanding questions to support moving forward with amendments and revisions. Taking a pause to do a more in-depth review/whiteboarding session before continuing with the implementation of this EPIC.

@nanyangpro @suhafa is there a wireframe for this?

Hi @Sepehr-Sobhani - I've added a link to the design in the description. Additionally, would you mind refining the second set of the AC into:

Given I am a CIF administrator
When I change the status to either Approved or Applied
Then the revision is committed and no more changes are allowed to the revision, and the "View/Edit" button in the table changes into "View" only

?

Since revisions/amendments change reason got part of the changes on this issue, I've updated the AC to capture the work.

Thank you @Sepehr-Sobhani ! Feature works as intended


limit_punctuation to defined characters

Added limit_punctuation module parameter to limit the punctuation characters allowed

in some cases you must use a subset of available punctuation, adding the limit_punctuation clause allows you to limit the results to only the specified characters.

Hi Tuxpowered! I have added this functionality to CLI side of passgen. Thank you very much for your contribution. Merging...


Redirection after deleting a draft.

Should I be redirected to the home page after deleting a draft ?
ref: manshar/web-client/app/scripts/controllers/profileController.js
var deleteSuccess = function () {
  $analytics.eventTrack('Article Deleted', {
       category: 'Article'
     });
     $location.path('/');
   };

shouldn't it just refresh the page at least ?

Yeah I think it shouldn't redirect and just remove the deleted article from the list. (It shouldn't even refresh).

Let me know if you'd like to take this on and try to send a pull request to fix it.

sure, actually am working on it now.

Disclaimer: Am not a js/angularjs professional  :dancer:
$scope.deleteArticle = function(article) {
      $scope.inProgress = 'delete';
      if ($window.confirm('متأكد من حذف المقال؟')) {
        Article.delete({ 'articleId': article.id }, {}, deleteSuccess, deleteError);
        //my humble - awesome attractive - addition
        var index = $scope.drafts.indexOf(article);
        $scope.drafts.splice(index, 1);
        //
      } else {
        $scope.inProgress = null;
      }
    };

it works great, only for the first deletion :smile:  , after that the delete button refuses to respond! I've tried to re query the drafts on the deleteSuccess method but with no success.
a refresh would solve that, but it's a very bad UX practice.
that's my first time to touch the angularjs thingy so please forgive all of my sins :pray:

This looks great. My guess the problem you are having is because of not resetting $scope.inProgress to null inside deleteSuccess and deleteError.

Hallelujah, here you are :lollipop: you nailed it.

Do you want to try and send a pull request?


rpc: replace hyper::Client with reqwest::Client

Closes #1342
In hyper, the high-level Client implementation is going to be removed in the next major release. The current client lacks built-in support for HTTP proxies, and we want to ditch hyper-proxy as it is unmaintained and its webpki dependency has a known security issue.

[x] Referenced an issue explaining the need for the change
[ ] Updated all relevant documentation in docs
[ ] Updated all code comments where relevant
[ ] Wrote tests
[ ] Added entry in .changelog/

Codecov Report

Merging #1362 (fe5d92b) into main (89da5f6) will decrease coverage by 0.5%.
The diff coverage is 67.6%.

:exclamation: Current head fe5d92b differs from pull request most recent head 66f854c. Consider uploading reports for the commit 66f854c to get more accurate results

@@           Coverage Diff           @@
##            main   #1362     +/-   ##
=======================================
- Coverage   60.7%   60.2%   -0.5%
=======================================
  Files        274     274
  Lines      26864   27196    +332
=======================================
+ Hits       16322   16389     +67
- Misses     10542   10807    +265

Files
Coverage Δ

rpc/src/client/transport/auth.rs
100.0% <100.0%> (ø)

rpc/src/error.rs
95.2% <100.0%> (-0.1%)
:arrow_down:

rpc/src/client/transport/websocket.rs
64.1% <25.0%> (-0.2%)
:arrow_down:

rpc/src/rpc_url.rs
66.6% <76.0%> (ø)

rpc/src/client/transport/http.rs
36.0% <64.2%> (+15.9%)
:arrow_up:

... and 5 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Love all that deleted code 🥇


ValueError: unmarshallable object

Hi,
I am getting an error whenever trying to run the GUI or train the VAE. I can understand this issue is related to CUDA but I would like to confirm the exact error and would appreciate any comments to help the problem solved. The error is following -
ERROR (theano.sandbox.cuda): Failed to compile cuda_ndarray.cu: ('nvcc return status', 1, 'for cmd', 'nvcc -shared -O3 -m64 -Xcompiler -DCUDA_NDARRAY_CUH=mc72d035fdf91890f3b36710688069b2e,-DNPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION,-fPIC,-fvisibility=hidden -Xlinker -rpath,/home/tansin/.theano/compiledir_Linux-4.15--generic-x86_64-with-Ubuntu-18.04-bionic-x86_64-3.6.7-64/cuda_ndarray -I/usr/lib/python3/dist-packages/theano/sandbox/cuda -I/home/tansin/.local/lib/python3.6/site-packages/numpy/core/include -I/usr/include/python3.6m -I/usr/lib/python3/dist-packages/theano/gof -L/usr/lib -o /home/tansin/.theano/compiledir_Linux-4.15--generic-x86_64-with-Ubuntu-18.04-bionic-x86_64-3.6.7-64/cuda_ndarray/cuda_ndarray.so mod.cu -lcublas -lpython3.6m -lcudart')
Traceback (most recent call last):
File "Generative/train_VAE.py", line 522, in
main(args)
File "Generative/train_VAE.py", line 336, in main
config_module = imp.load_source('config', args.config_path)
File "/usr/lib/python3.6/imp.py", line 172, in load_source
module = _load(spec)
File "", line 684, in _load
File "", line 665, in _load_unlocked
File "", line 674, in exec_module
File "", line 786, in get_code
File "", line 503, in _code_to_bytecode
ValueError: unmarshallable object

Hi Tansin,
This might be related to the python version (this was trained with 2.7), but it might also have to do with Theano.
Theano (and a lot of the code that relies on it) isn't maintained anymore, and I'm not familiar with this error. You'll most likely need to run with the version of Theano this was built with (IIRC it was 0.7? sorry, I don't have it lying around at this point) to run it as-is. You're honestly better off porting all this to PyTorch (should only take an afternoon, plus two more debugging <_<) and running that instead. The GUI doesn't have any such external deprecated dependencies, VTK should be sufficient.


Characters proccing their own attacks of opportunity

Describe the bug
Character with Outflank scores a critical hit and then gets a free attack of opportunity. No other characters attack.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
Only other characters should get attacks of opportunity.
Screenshots

Additional context
Add any other context about the problem here.

Experiencing the same issue


test: Do SynchronousDelete cleanup before testing ImageIsUnpacked

Simply delete the image will not clean up the snapshots.
Signed-off-by: Li Yuxuan<EMAIL_ADDRESS>

Codecov Report

Merging #3832 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3832   +/-   ##
=======================================
  Coverage   41.98%   41.98%
=======================================
  Files         130      130
  Lines       14577    14577
=======================================
  Hits         6120     6120
  Misses       7543     7543
  Partials      914      914

Flag
Coverage Δ

#linux
45.42% <ø> (ø)
:arrow_up:

#windows
36.94% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec661e8...19f7f3c. Read the comment docs.

LGTM


Unique ID system for sceneObjects

A unique ID system for sceneObjects would facilitate project scale.

Used boost::uuids:uuid


Added --autonumber-start [number] option

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests

What is the purpose of your pull request?

[ ] Bug fix
[ ] New extractor
[x] New feature

Description
Added --autonumber-start [number]. This only does anything when autonumber is called. It works properly with autonumber-size and overrides the size if needed. Note that it will start exactly on the number entered (3 would yield 00003) and does not accept negative numbers (-2 would yield 00000).
This way you could combine multiple playlists by downloading 10 videos from one playlist and 10 from another but name from 1 to 20. For example:

youtube-dl --yes-playlist -o "/location/%(title)s_S0E%(autonumber).%(ext)s" "http://yourlink.com/playlistone"

Would produce episodes S0E (1 through 10)
And then you can continue from another playlist with one addition

youtube-dl --yes-playlist --autonumber-start 11 -o "/location/%(title)s_S0E%(autonumber).%(ext)s" "http://yourlink.com/playlisttwo"

which would produce S0E (11-20)

Duplicate of #9362.

This patch has a similar issue like #9632, as stated in https://github.com/rg3/youtube-dl/pull/9362/files#r61808457. @JewsOfHazard Would you like to fix it? @dstftw If everything is fixed, I'd like to reopen this PR and close #9362 instead.

@yan12125 whatever you like.

I can take a look at fixing it, sure. I'll be at pax the next couple days so I can't do it now though.


xref-go-back not work in Emacs

In Emacs, xref-find-definitions works as expected, but when executed xref-go-back, will got an error:
command-execute: Autoloading file /nix/store/rd0n6032l9mn0jrcp876y1xx2jrxc7im-emacs-packages-deps/share/emacs/site-lisp/elpa/xref-1.3.2/xref.elc failed to define function xref-go-back

Report this to Nix discourse

I move to use Borg to install Emacs packages and manage them by Git submodule
My Emacs configuration: Eason0210/emacs.d


lifecycle: Don't require /run/opencontainer//containers

As discussed in #231.  We already require it for
Linux/Unix-based systems, so we don't have to repeat it here.  And
other systems will use different paths, which we haven't specified
yet.  When I asked why we didn't specify a path for Windows,
Vincent said we were waiting on help from PoC implementations.
So this commit punts the location to the “State” section, and lets the
“Lifecycle” section just focus on when the write-to-filesystem
happens.
There's also discussion about removing the filesystem state registry
commpletely, in which case we'd want to remove the whole line from
the lifecycle.  If we expect to switch to something like --state PATH in the near future this PR is just polishing dead
documentation.

LGTM

I'd prefer to NOT do this because we're replacing a concrete, and interoperable, solution with something that is not.  If we don't like the current proposal then I think it would be better to only remove it when there's a viable alternative proposed - replace it with just "write it to the filesystem" doesn't help interop.

On Mon, Dec 14, 2015 at 09:51:11AM -0800, Doug Davis wrote:

I'd prefer to NOT do this because we're replacing a concrete, and
interoperable, solution with something that is not…

This PR doesn't change the semantics for Linux/Unix-based systems,
which still require runtimes to write the state to
/run/opencontainer//containers based on wording in the
“State” section 1.  It just removes the unqualified reference from
the “Lifecycle” section [2], which was redundant for Linux/Unix-based
systems and wrong for other systems.

I just pushed 5402c1c → f89cb85 to fix a “commpletely” → “completely”
typo in the commit message.

@wking ah, doi - sorry missed that.  I take back my concerns  :-)

LGTM


Bump PR.

Bump PR.
Related issue(s):
Fixes #1311

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report
Patch and project coverage have no change.

Comparison is base (25de949) 75.72% compared to head (6d37f0b) 75.72%.

:exclamation: Current head 6d37f0b differs from pull request most recent head 8469d67. Consider uploading reports for the commit 8469d67 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           release/0.25    #1327   +/-   ##
=============================================
  Coverage         75.72%   75.72%
=============================================
  Files                32       32
  Lines              2451     2451
  Branches            492      492
=============================================
  Hits               1856     1856
  Misses              442      442
  Partials            153      153

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


create ceph-csi channel on slack

@rootfs can we create ceph-csi channel slack channel for development communication?

@Madhu-1 how about creating a csi channel under rook?
also cc @travisn

Hi, thanks for a great product! README.md still refers to cephcsi.slack.com. Is the rook csi channel the correct one?

@briantopping we are active on both slack channels. but later on, we will be moving to cephcsi.slack.com

Ah great, thanks @Madhu-1! Don't forget to provide some means of getting an invitation to the latter!! :D


🐛 Fix wrong annotation in logging call

Signed-off-by: David Festal<EMAIL_ADDRESS>Summary
:bug: Wrong annotation in logging call
Related issue(s)
no issue created
Fixes #

/retitle 🐛 Fix wrong annotation in logging call

/retest


Increase shirt name limit

I understand why it should be limited but it's a bit too short atm. I can't even put 'Sigthorsson'.

I still think you should increase the width limit a tiny bit. But in a way that you can't spam the entire shirt like Termi and Dementei did.


Wormhole Bug: WBTC (ERC-20) to WBTC (SOL) stuck on "Awaiting completion on Solana..."

Hey guys, please kindly check out this discussion for a bug, TXs, etc.:
https://github.com/certusone/wormhole/discussions/333
I was testing wormhole (before trying with a larger sum) and tried to move 0.0001 WBTC from ERC-20 to SOL. The process got stuck on "Awaiting completion on Solana..." and it looks like the destination token account was not created, but the lockup was.
Would appreciate it if you could create a destination token account, so I can ask to resubmit VAA.
Thanks a lot!

@bartosz-lipinski This user needs to create their token account (iirc, this happened once before and there's a special one-off page to do it?)

It should be do-able from the UI. Select the token from ETH side, put a very very small amount of that token, and click transfer.
The FIRST pop up should be on solana wallet asking to create an account. That one should be accepted. After that REJECT all metamask transactions.  That should only create an associated token account in solana. @leoluk

No response - assuming it's solved

hi guys i have the same issue above.  i tried what yamijuan suggested but no luck.
i tried another smaller transfer and that went through.
can you please advise its a large amount of coins to me.  thank you
https://github.com/solana-labs/oyster/issues/310

@misterbaka Please stop hijacking existing issues

Thanks for following up @leoluk , I just followed the steps proposed by @yamijuan
Here is the approved Solana tx:
https://explorer.solana.com/tx/5Q22R53AJvNBcZwuzpoEPzd35Kvj9yh14BjkKExnzoVqF91ebKXP2KAhhUCU2NTnx5U9H8mXoa33Z67hQuNCNx4D
For clarity: It's re: this issue:
https://github.com/solana-labs/oyster/issues/305
I still don't have the ability to access my initial wLuna deposit.
This section also stays empty:

It does seem to have registered a Solana account since a new transaction does not prompt that request anymore, but goes straight to approving ethereum txs (which I've rejected).
Help appreciated.

@Gitsomelearnsome I will reply on your original issue


MNT: Bump required cdk version for RDS version upgrade

When the RDS version was updated, the CDK version also needed to be updated for our release to work. I've also added the synth command to the testing matrix in GitHub Actions so we try and catch this failure before trying to deploy.
Change Summary
closes #269

OK, looks like this is working once we add the cdk.context.json because then we don't need the API lookups to our account for those values (and thus avoid authorization issues).


Update async-std and fix h1_client

Includes https://github.com/http-rs/http-client/pull/113

ping @Fishrock123

Hi @yoshuawuyts , are you able to help this progress... ?

Hi @adlerjohn and @kjvalencik , are you able to help this progress... ?


Make sure that the SRI services are also properly registered with SmartAPI

Discussed during the 7/22 Aragorn team meeting
Check out the meeting notes for background info: https://docs.google.com/document/d/1x_ukP9eyy8ahb6ZlZAg78bdf6H2XxkcfGKR_r3WRcuM/edit?pli=1#

All sri services have been registered,
including aragorn robokop instances


Papercuts

Couple of easy fixes. Not sure about the vars in 423bab0 – see the comment on that commit for more. Happy to fixup the commit with the correct variables and words if need be.

I spoke to @symroe IRL about this. The table-cell trick doesn't seem to quite fix the comma whitespace issue, and the "view this register" link needs to, at least, be configurable so it doesn't appear on registers other than the register register.
We can talk further about next steps.

https://github.com/openregister/openregister-java/pull/108 addresses the "view this register" link and configures it only for the register register.

Moved table-cell trick to its won branch - turns out chrome was caching CSS and it does work locally for me now. New PR at https://github.com/openregister/openregister-java/pull/111.

Going to close as I think we've dealt with the issues in this PR. @symroe please reopen if there are still things we haven't addressed.


Here is the code we talked about earlier.

This code has all the features, but I have to say that I am an amateur when it comes to coding in javascript. The harshest criticism imaginable is most welcome :)

Usage example:
 light.box(['a[data-imagelightbox="z"]',{
                                        activity:true,
                                        arrows:true,
                                        navigation:true,
                                        overlay:true,
                                        caption:true,
                                        button:true
                                    }
                                              ]);

I like the idea of having options for configuring the imagelightbox, but I would but those into an "options"-object so you dont have to pass those "activity, arrows etc" values in the correct order (and that would later be helpful if we want to add data-options-attributes)
Also could you move your code into the main js file isntead of adding a new file (and remove the code from the demo.html)?

 Suggestions?

Thanks for the PR; I created a new branch "refactor_options" and merged it into that one (instead of master). will look into the navigation-element, everything else seems to work atm. nice and thx again

You're welcome!

So, I also fixed the navigation stuff, merged it into master, updated the docs and demo a little. Care to take a look to see if I missed something? Would be really appreciated :-)

Hi there @rejas , sorry about the disappearance. It looks like everything is working well! I have some other thoughts, but I'll post it as an issue. Nice work, man!


net/haproxy: bugfix release 1.13

In light of #84 it became clear that the HAProxy plugin is lacking with this regard too.
New features

none

Bugfixes

fix CA/intermediate certificate handling if a certificate (chain) was (properly) imported into OPNsense

@fraenki let me know when this is ready :)

@fichtner Nothing else on my list this time, ready for merge :)

pew pew pew! thanks!


chanId not being set by ca_create_channel()

I'm trying to run the examples from README.md, but whenever pv.connect() is called, the following error is thrown:
TypeError: Unexpected <type_41> * value, expected chanId
    at /home/dkastelic/node-epics-testing/node_modules/node-epics-ca/lib/channel.js:204:30
    at new Promise (<anonymous>)
    at Channel.connect (/home/dkastelic/node-epics-testing/node_modules/node-epics-ca/lib/channel.js:197:16)
    at /home/dkastelic/node-epics-testing/index.js:7:18
    at Object.<anonymous> (/home/dkastelic/node-epics-testing/index.js:14:3)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)

I believe the issue is that ca_create_channel() saves {} to chidPtr[0] instead of a channel id, but it only becomes apparent when ca_field_type() recieves this value as an argument and throws an error.
I'm running both an instance of the EPICS example IOC and Node.js in wsl, and can successfully caget the PV I am using in the script from the console.

Hi, I can reproduce the issue, thanks for reporting.
I will try to fix it.

node-epics-ca relies on koffi, the root cause is that koffi version 2.5.4 breaks the previously working code of node-epics-ca.
With the help of the author of koffi as follows, the issue has been fixed.
https://github.com/Koromix/koffi/issues/62
I have published the new version node-epics-ca 0.2.1, please try it.

Thank you, it seems to work now.

Hi, today I got the same error again when trying to manually close a channel opened with CA.monitor():
/home/dkastelic/node-epics-server/node_modules/node-epics-ca/lib/channel.js:227
                    let errCode = ca_clear_subscription(this.monitorEventId);
                                  ^

TypeError: Unexpected <type_41> * value, expected evid
    at Timeout._onTimeout (/home/dkastelic/node-epics-server/node_modules/node-epics-ca/lib/channel.js:227:35)
    at listOnTimeout (node:internal/timers:569:17)
    at process.processTimers (node:internal/timers:512:7)

Simple example that reproduces the issue:
const CA = require('node-epics-ca');
(async () => {
    let channel = await CA.monitor('calcExample', function(data) {
        console.log('Current:', data);
    });

    setTimeout(async function() {
        console.log("Closing channel manually.");
        await channel.disconnect();
    }, 2 * 1000);

    setTimeout(function() {
        console.log("Done!!!");
    }, 5 * 1000);
})()

I think I managed to fix it by modifying ca_create_subscription in the same way that ca_create_channel was modified:
from
const ca_create_subscription = libca.func('ca_create_subscription', 'int', ['int','ulong',chanId,'long',koffi.pointer(MonitorCallback),'pointer',koffi.out(pointer)]);

to
const ca_create_subscription = libca.func('ca_create_subscription', 'int', ['int','ulong',chanId,'long',koffi.pointer(MonitorCallback),'void *',koffi.out(koffi.pointer(evid))]);

Hi, thanks for your report as well as the solution.
I have published v0.2.2 with the solution you suggested.
I forgot to modify the "void *" part, but it does not seem to affect.

Thanks!


[Feature Request]: Random Rewards

Is your feature request related to a problem?
I converted my quests to this mod, but it doesn't convert much. Because it doesn't have the feature, like: There's no way to do random looting as a reward in quests.
Solution(s)
No response
Describe alternatives you've considered
So far the only solution for me to convert my quest would be to just place one of the items, but it would make the experience more boring.
Mod Version
1.1.11
Mod Loader Version
1.20.1 - 0.15.7
Mod Loader
Fabric
Additional context
No response

You can use a loot table reward and convert your rewards to a loot table, loot tables are far more versatile and can be used with mods like loot bags for multiple purposes.

So why hasn't Odysseus already done this for me?

Odysseus converts only basics so far, loot tables would require out putting different files as to load a loot table you would need a mod like open loader, kubejs, or global packs to load the datapack with the loot tables.

Okay, but how do I get these loot rewards? No one tells me how


mcuuid.net -> minecraftuuid.com

Sorry for the delay. I have merged this in commit 59f27f0769b7a07e8d015e94826490cea48a1e82. It is included in v2.1.4 and now live on the website.


Equal sum partition dynamic programming

Can I do this?

Yes sure. I have assigned it you.

Can I work on this ?

@Ankitlenka26 Since this issue is already assigned, you may look for other issues or open your own here

Please review and inform me if some is missing or needs to be changed


Reproduction of double-releaseIP bug

Description
Setup a scenario in which an IP is assigned, but it's ordinal appears twice in the AllocationBlock's Unallocated list making it possible to assign the IP twice.
Have branched of 2.6 release which affects my environment, but reading the 3.x code suggests this bug will still be present in newer releases too.
Proof-of-concept for #989
Todos

[X] Tests
[ ] Documentation
[ ] Release note

Release Note
TBA

@caseydavenport took a bit to figure it out (de-duping a slice of structs ain't that straight forward!) but it's ready for review again now. Thanks for your patience.

@caseydavenport change pushed 👍

@caseydavenport see #1013 for port to master branch.


fs.stat() with options doesn't work

fs.stat() and its relatives accept an additional options object fs.stat(path[, options], callback) since node v10.5.0.
https://nodejs.org/api/fs.html#fs_fs_stat_path_options_callback
seems like graceful-fs hasn't been updated yet! This will cause issues for projects that depend on graceful-fs. I am one of the maintainers of fs-extra and this prevents us from using fs.stat() with bigint option!

I think this would need minor code fixes in the following places:

https://github.com/isaacs/node-graceful-fs/blob/9b47ebe99f25a012e59bb731186b18f73e77ea8a/polyfills.js#L280-L281
https://github.com/isaacs/node-graceful-fs/blob/9b47ebe99f25a012e59bb731186b18f73e77ea8a/polyfills.js#L294-L295

I suspect the harder part would be to update the tests test/stats.js, which seems to only test statSync.

same for readdir btw…

I opened the above issue (https://github.com/jprichardson/node-fs-extra/issues/703) in fs-extra but the issue might lie in this project, I'm not sure.
Even after upgrading both packages I'm inconsistently getting the cb.apply is not a function error.

@JustinLivi It's likely a result of having two different versions of graceful-fs in play at the same time.  What do you see when you run npm ls graceful-fs?

@isaacs thanks - you were right. I was having a collision between jest and fs-extra. Installing graceful-fs as a direct dependency resolved the issue 👍


Fixed gradle warning of deprecated 'compile' configuration

Description

While trying to remove all deprecated warnings I stumbled upon this library not being updated yet. A quick and simple fix for this is to use implementation instead of compile.
The original Gradle warning shown;
> Configure project :react-native-google-analytics-bridge
WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html

LGTM. Thanks for the PR @ShaPOC!

Weird, I'm still getting this error with 6.1.2.

@brunolemos That's because version 6.1.2 does not have this change. The author still needs to create a new package version including this :)

cc @idehub

I’m back home again with a laptop and can take a look at this

Thanks!


Disable OIT on webgl.

Disable OIT on webgl. Ideally we'd check for flags, but this is complicated by adding a direct wgpu dependency to bevy_core_pipeline.

Do the docs talk about supported platforms?

Do the docs talk about supported platforms?

Not yet, but I'll update the PR with a few more fixes too.


HtmlHelper Menu performance has drastically degraded since 3.1.0

The following method now takes about 6 times longer than it did in version 3.1.0
   public static MvcHtmlString Menu(this MvcSiteMapHtmlHelper helper, string templateName, SiteMapNode startingNode, bool startingNodeInChildLevel, bool showStartingNode, int maxDepth, bool drillDownToCurrent)
    {
        var profiler = MiniProfiler.Current;
        using (profiler.Step("MvcSitemap Menu"))
        {
            var model = BuildModel(helper, startingNode, startingNodeInChildLevel, showStartingNode, maxDepth, drillDownToCurrent);
            return helper
                .CreateHtmlHelperForModel(model)
                .DisplayFor(m => model, templateName);
        }
    }

Not resolved but I'll look into this one a bit further before submitting an issue.,


excessive memory usage

User reported excessive memory usage when performing snapshot of large number of files and directories, exhausting his 16GB RAM on an 8 core machine.
Using a relatively similar setup, 8 core and 16GB of RAM, I could not reproduce but my test still consumed 1GB of RAM which seemed excessive.
I thought it could be caused by disk performances causing high parallelisation to buffer too much chunks for disk to keep up. User reported write performances 2x slower than mine which was another hint in that direction.
I tested by setting up a remote plakar repository and also a plakar repository on a SATA disk which both proved to consume more memory than when snapshotting to my SSD.
After a lot of experiments, I ruled out that this is just a buffering issue:             reducing parallelisation and adding disk write semaphores does not help whatsoever.
The high memory consumption happens before the snapshot begins, when the source directories/files are being scanned and plakar's VFS layer creates its filesystem view.
This is confirmed by plakar scan /origin consuming excessive memory while it only does the filesystem traversal and tree build. I also ruled out that the scan itself is the issue by commenting the tree build.
The VFS structure needs to be redesigned and optimized...

high hints that LZ4 compression is not helping.

I have solved the issue in a PoC:
Long story short, regardless of the data size of a snapshot, the VFS space requirement grows with the number of files and directories within a snapshot. It doesn't matter that I use a mapping or a trie, if I have n million files in a snapshot that's n millions pathnames + n millions FileInfo structures to keep in memory, not counting the need to keep track of children per nodes which is possibly many millions additional entries.
The quick solution is to offload VFS to a disk-based database. I tested boltdb, sqlite and leveldb, the latter proved to be the most efficient both in disk write performance and in overall size with 1 million objects producing a 30MB database (scaling linearly, so I can easily predict what 10 or 100 million objects will produce). boldtb and sqlite were far behind in all tests.
The trade off to rely on disk is acceptable IMO given that obtaining the same result with an in-memory structure is A LOT of work, probably more than plakar all combined so there's no way it'll be achievable in short timespan.

An implementation of VFS & Index disk offloading has been written and committed in branches new-vfs and new-index.
They are functional and are being tested a bit more seriously before they are merged in main.

merged


[ISSUE 4890] WIP Fix binary search consume offset by time

Make sure set the target branch to develop
What is the purpose of the change
Fix https://github.com/apache/rocketmq/issues/4890
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

I do not have the working bandwidth for this pull request, for now, let's postpone it to the next release cycle.

I think the fix is a little complex ,for a lower boundary ,we have just to search for the value timestamp-0.5
while timestamp+0.5 for the upperboudary.
timestamp+(-)0.5 must be a value between real message's timestamp and will not match any message's timestamp.

Hi @lizhanhui is there any new progress in this PR? I think it is necessary, especially I want to improve the accuracy of the semantics of lite pull consumer.


[FR] either prioritize words in current file or allow current-only file provider

In Vim, I'm used to completing on nearby words using Ctrl+N and Ctrl+P.  It's much more likely that I would want to repeat the words that are around in the same file and especially around the cursor.
To get something similar, I think I would need the word list to prioritize words in the current file over words in other files.
Or, even easier to implement, allow me to enable the file scanner/provider but allow me to limit it to just the current file.

Basically like #19. Prioritization is also planned.

Ah I figured out what the type of completion is called: "Hippie completion"
https://www.jetbrains.com/go/guide/tips/cyclic-expand-word/


Plugin blocks Homebridge (updating)

Unfortunately, this plugin does not work for me, as the original homebridge-stv one :(
I tested all the combinations possibles with Auto-Refresh and Keep Alive and every time, after a while or when turning on the Roomba from the Home app, all Homebridge accessory become unresponsive and are marked as "Updating" and then "Failed".
As soon as I disable the plugin, everything is back to normal and Homebridge behaves normally. I don't know what is wrong with this and I am willing to help debug if it helps.

Note that I am also experiencing the issue described in #5 before the plugin makes Homebridge bug.
The "docked", "bin full" and "running" sensors are always marked as closed

Are you able to provide logs?

I'll share more extensive logs tomorrow when the issue happen but the first odd thing I notice is that the sensors seem to refresh way too often although I defined "cacheTTL" to 60.
[11/18/2020, 7:10:48 PM] Homebridge v1.2.3 is running on port 51023. [11/18/2020, 7:10:48 PM] [eDomoticz] Successfully connected to MQTT broker. [11/18/2020, 7:10:51 PM] [Roomba] Running status requested [11/18/2020, 7:10:51 PM] [Roomba] Battery level requested [11/18/2020, 7:10:51 PM] [Roomba] Charging status requested [11/18/2020, 7:10:51 PM] [Roomba] Battery status requested [11/18/2020, 7:10:51 PM] [Roomba] Docked status requested [11/18/2020, 7:10:51 PM] [Roomba] Running status requested [11/18/2020, 7:10:51 PM] [Roomba] Bin status requested [11/18/2020, 7:10:54 PM] [Roomba] Running status requested [11/18/2020, 7:10:54 PM] [Roomba] Battery level requested [11/18/2020, 7:10:54 PM] [Roomba] Charging status requested [11/18/2020, 7:10:54 PM] [Roomba] Battery status requested [11/18/2020, 7:10:54 PM] [Roomba] Docked status requested [11/18/2020, 7:10:54 PM] [Roomba] Running status requested [11/18/2020, 7:10:54 PM] [Roomba] Bin status requested [11/18/2020, 7:11:06 PM] [Roomba] Bin status requested [11/18/2020, 7:11:06 PM] [Roomba] Running status requested [11/18/2020, 7:11:06 PM] [Roomba] Docked status requested [11/18/2020, 7:11:06 PM] [Roomba] Running status requested [11/18/2020, 7:11:06 PM] [Roomba] Battery status requested [11/18/2020, 7:11:12 PM] [Roomba] Running status requested [11/18/2020, 7:11:12 PM] [Roomba] Bin status requested [11/18/2020, 7:11:12 PM] [Roomba] Docked status requested [11/18/2020, 7:11:12 PM] [Roomba] Docked status requested [11/18/2020, 7:11:12 PM] [Roomba] Bin status requested [11/18/2020, 7:11:12 PM] [Roomba] Running status requested [11/18/2020, 7:11:13 PM] [Roomba] Docked status requested [11/18/2020, 7:11:13 PM] [Roomba] Bin status requested [11/18/2020, 7:11:13 PM] [Roomba] Running status requested [11/18/2020, 7:11:17 PM] [Roomba] Running status requested [11/18/2020, 7:11:17 PM] [Roomba] Bin status requested [11/18/2020, 7:11:17 PM] [Roomba] Docked status requested [11/18/2020, 7:11:32 PM] [Roomba] Running status requested [11/18/2020, 7:11:32 PM] [Roomba] Bin status requested [11/18/2020, 7:11:32 PM] [Roomba] Docked status requested [11/18/2020, 7:11:35 PM] [Roomba] Running status requested [11/18/2020, 7:11:35 PM] [Roomba] Battery level requested [11/18/2020, 7:11:35 PM] [Roomba] Charging status requested [11/18/2020, 7:11:35 PM] [Roomba] Battery status requested [11/18/2020, 7:11:35 PM] [Roomba] Docked status requested [11/18/2020, 7:11:35 PM] [Roomba] Running status requested [11/18/2020, 7:11:35 PM] [Roomba] Bin status requested [11/18/2020, 7:11:39 PM] [Roomba] Running status requested [11/18/2020, 7:11:39 PM] [Roomba] Battery level requested [11/18/2020, 7:11:39 PM] [Roomba] Charging status requested [11/18/2020, 7:11:39 PM] [Roomba] Battery status requested [11/18/2020, 7:11:39 PM] [Roomba] Docked status requested [11/18/2020, 7:11:39 PM] [Roomba] Running status requested [11/18/2020, 7:11:39 PM] [Roomba] Bin status requested [11/18/2020, 7:13:07 PM] [Roomba] Running status requested [11/18/2020, 7:13:07 PM] [Roomba] Battery level requested [11/18/2020, 7:13:07 PM] [Roomba] Charging status requested [11/18/2020, 7:13:07 PM] [Roomba] Battery status requested [11/18/2020, 7:13:07 PM] [Roomba] Docked status requested [11/18/2020, 7:13:07 PM] [Roomba] Running status requested [11/18/2020, 7:13:07 PM] [Roomba] Bin status requested [11/18/2020, 7:13:11 PM] [Roomba] Running status requested [11/18/2020, 7:13:11 PM] [Roomba] Battery level requested [11/18/2020, 7:13:11 PM] [Roomba] Charging status requested [11/18/2020, 7:13:11 PM] [Roomba] Battery status requested [11/18/2020, 7:13:11 PM] [Roomba] Docked status requested [11/18/2020, 7:13:11 PM] [Roomba] Running status requested [11/18/2020, 7:13:11 PM] [Roomba] Bin status requested [11/18/2020, 7:13:38 PM] [Roomba] Running status requested [11/18/2020, 7:13:38 PM] [Roomba] Battery level requested [11/18/2020, 7:13:38 PM] [Roomba] Charging status requested [11/18/2020, 7:13:38 PM] [Roomba] Battery status requested [11/18/2020, 7:13:38 PM] [Roomba] Docked status requested [11/18/2020, 7:13:38 PM] [Roomba] Running status requested [11/18/2020, 7:13:38 PM] [Roomba] Bin status requested [11/18/2020, 7:13:41 PM] [Roomba] Running status requested [11/18/2020, 7:13:41 PM] [Roomba] Battery level requested [11/18/2020, 7:13:41 PM] [Roomba] Charging status requested [11/18/2020, 7:13:41 PM] [Roomba] Battery status requested [11/18/2020, 7:13:41 PM] [Roomba] Docked status requested [11/18/2020, 7:13:41 PM] [Roomba] Running status requested [11/18/2020, 7:13:41 PM] [Roomba] Bin status requested
Here is my current configuration:
       {             "name": "Roomba",             "model": "s9+",             "blid": "ABC",             "robotpwd": "ABC",             "ipaddress": "<IP_ADDRESS>",             "autoRefreshEnabled": true,             "dockContactSensor": true,             "runningContactSensor": true,             "binContactSensor": true,             "cacheTTL": 60,             "accessory": "Roomba2"         }

If you have discord, I'd like to work one-on-one with you to resolve this. You can email me your discord at rayankhan04 [@] iCloud . com

Hi,
I had the same error with the STV. Now trying yours. You can simply reproduce the error by depleting the battery of your Roomba. As soon as he does. Ot respont the plugin freezes homebridge. I think there is some kind of timeout missing...

@iRayanKhan I checked the logs and there is nothing else happening there different than what I just provided. No error, nothing, the plugin just keeps polling the 3 sensors.

What model of Roomba do y'all have?

S9+

@iRayanKhan i sent you an email with my discord username a couple of days ago as you asked.

Model 896

Same problem here with i7+, and had the same problem with stv. I disabled keep alive in the hope that it works, but no good.
I think the culprit are these calls here: https://github.com/iRayanKhan/homebridge-roomba2/blob/master/index.js#L171-L181
It should probably fetch the status asynchronously every few seconds and cache that, then just return the cached value when requesting status. Right now it looks (just skimmed over it) that it waits for the api call to succeed/fail, which yeah, blocks homebridge

Hi I have the same issue on a room a 671. Any resolution?

Submitted a PR that should fix this 👍


Just generates noise

I'm not sure if this is just a workflow issue, but when I tried using this, it just outputs noise.

Could I have some help?

That looks like it should work.
The only thing I can point out is that using the gguf DualCLIP loader isn't actually required if you don't use a gguf text encoder model (which you aren't by the looks of it). Though when I replicate it 1:1 it seems to work even with that.
I guess maybe check the downloaded file(s) to make sure it's not a corrupt download?

do

That looks like it should work.
The only thing I can point out is that using the gguf DualCLIP loader isn't actually required if you don't use a gguf text encoder model (which you aren't by the looks of it). Though when I replicate it 1:1 it seems to work even with that.
I guess maybe check the downloaded file(s) to make sure it's not a corrupt download?

Do you have a download link for the clip_l and t5xxl_fp8e4m3fn files? I used the ones from here:
https://huggingface.co/comfyanonymous/flux_text_encoders/tree/main

EDIT: So going down to the Q4_KS Model seemed to work! I think the Q5 model was just too much for my laptop haha

You're using the right text encoders, so all good there. For the dual CLIP loader, I just meant that you should use the regular dual clip node and not the gguf dual clip one if you don't use any of the gguf T5 models from here (in other words, you're currently using the safetensor ones, so there's no need for the gguf specific node).
I think Q5 should work too since comfy can load a model partially, even if it doesn't fit fully on the GPU. Could just be a corrupt file/download as well, unless it really is something about that quant specifically.
Anyway, I'll close the issue for now though if anyone else runs into a similar issue we can reopen.

Same problem here:

Device: Apple M1 Pro, macOS 14.5
UNet: flux1-dev-Q4_K_S.gguf
DualClip: t5-v1_1-xxl-encoder-Q5_K_M.gguf, clip_l.safetensors

Any ideas? BTW, running under --cpu mode works just fine(slooooooooow though).

@skelescene Are you also on apple hardware? That would likely make this specific to MacOS/MPS (possibly in cases where lowvram gets triggered)

Disabling --use-split-cross-attention (if enabled) can help


changed the font of messages  #GSSOC

please check whether the new text  looks good or not
assign me some issues related to UI.
I'm a participant of GSSOC.


Package upgrade: pointycastle 3.0.1 --> 3.1.2

Summary
Package upgrade: pointycastle 3.0.1 --> 3.1.2
Changelog
[General] [Change] - Upgrade pointycastle from 3.0.1 to 3.1.2 (changelog)
Test Plan
Regression test the following areas:
./lib/core/providers/user.dart

Closing in favor of #1469


Liquibase 4.18 with Spring boot 2.7 is throwing runtime error when trying to up the application

Search first

[X] I searched and no similar issues were found

Description
Hi,
I am upgrading my app with spring boot 2.7 and liquibase 4.18 liquibase core.  My past liquibase script which has include to sql file with below format causing application up failure. with below error
Error parsing classpath:/db/liquibase-changeLog.yml: Unknown change type 'include'. Check for spelling or capitalization errors and missing extensions such as liquibase-commercial.
Changset example:
databaseChangeLog:

changeSet:
id: changeLog-1
author: XYZ
changes:
- sqlFile:
path: /db/changeLog1.sql

changeSet:
id: changeLog-2
author: XYZ4
changes:
- include:
file: test1.sql
- include:
file: test2.sql
- include:
file: test3.sql
- include:
file: test4.sql

Steps To Reproduce
Create a changelog master yaml with below format
databaseChangeLog:

changeSet:
id: changeLog-1
author: XYZ
changes:
- sqlFile:
path: /db/changeLog1.sql

changeSet:
id: changeLog-2
author: XYZ4
changes:
- include:
file: test1.sql
- include:
file: test2.sql
- include:
file: test3.sql
- include:
file: test4.sql

Expected/Desired Behavior
Application should up without any error
Liquibase Version
4.18.0
Database Vendor & Version
Postgres 14
Liquibase Integration
spring boot
Liquibase Extensions
No response
OS and/or Infrastructure Type/Provider
Windows 11
Additional Context
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR (Thank you!)

Hello @devendra-kumar1, luckily there's an easy fix for this :)
If you check the documentation, include shouldn't come after changes:. It goes one level "inside" databaseChangeLog.
Hope this helps!
Tatiana


data grid search is broken for tree view templates

the first issue was that the tree view template binds to the items collection, which is not affected by filter requests. That was solved above by using polymorphic behaviour.
The second issue is that tree view templates only render visible (expanded) nodes, and the filtering logic assumes we only need to filter these visible nodes. So if a node isn't expanded we wont bother filtering it. This is a much more complicated problem to solve as it requires the view side being capable of injecting code into the filtering process (as the view needs to map visible nodes to all nodes, then also apply expansion state to matches items).

It is not possible to have the view template inject itself into the filtering process, so that means the view must perform any mutations necessary to project the list of nodes into an appropriate tree structure. This likely means that initialize must be rewritten to better handle this type of data flow.
need to first remap the request into all possible nodes, then perform normal filtering, then in initialize intelligently rebuild the tree (visible) items from the flattened list of filtered nodes.


Model loaded from checkpoint has bad accuracy

What is your question?
I have a model that I train with EarlyStopping and ModelCheckpoint on a custom metric (MAP).
The training works fine, after 2 epochs the model reaches 96% MAP however when I load it and test it with the exact same function the MAP is 16% (same as untrained model).
I must be doing something wrong, but what ?
Code
def default_model(dataset: str):
	if torch.cuda.is_available():
		print("Using the GPU")
		device = torch.device("cuda")
	else:
		print("Using the CPU")
		device = torch.device("cpu")
	kwargs = {
		"dataset": dataset, "embed_size": 50, "depth": 3,
		"vmap": Graph3D.from_dataset(dataset).vocabulary,
		"neg_per_pos": 5, "max_paths": 255, "device": device
	}
	try:
		model = TAPKG.load_from_checkpoint("Checkpoints/epoch=2-step=612260.ckpt", **kwargs).to(device)
		return model
	except OSError as e:
		print(f"Couldn't load the save for the model, training instead. ({e.__class__.__name__})")
		model = TAPKG(**kwargs).to(device)
	cpt = pl.callbacks.ModelCheckpoint(monitor="MAP", mode="max", dirpath="Checkpoints", save_top_k=1)
	trainer = pl.Trainer(
		gpus=1,
		check_val_every_n_epoch=1,
		callbacks=[
			cpt,
			pl.callbacks.EarlyStopping(monitor="MAP", mode="max", min_delta=.002, patience=2)
		],
		auto_lr_find=True
	)
	# noinspection PyTypeChecker
	trainer.fit(model)
	print(cpt.best_model_path, cpt.best_model_score)
	return model

def eval_link_completion(dataset):
	model = default_model(dataset)
	ranks = model.link_completion_rank()
	MAP(ranks, plot=True)

Right after the training eval_link_completion shows a MAP of 96%, when I load the model however it's back to 16%.

OS: KUbuntu 20.04
Packaging pip
Version 1.2.0

I don't think the model you are returning is the trained model, it's the original model from when you first create it. Try doing
model = model.load_from_checkpoint(cpt.best_model_path) after trainer.fit() and return model then.

Thank you for answering, but I'm not sure I understand.
Why would loading like I do yield the original untrained model ?
How would you suggest that I load my model instead ?
The training takes 6h so it would be nice if I could avoid calling trainer.fit() again, but if it's mandatory for debugging I will.

Wait after digging on my end it seems I might have a non deterministic process throwing the evaluation off between the runs, thank you anyway, I'll come back after investigating this.

Do this in default_model function:
# noinspection PyTypeChecker
trainer.fit(model)
print(cpt.best_model_path, cpt.best_model_score)
model = model.load_from_checkpoint(cpt.best_model_path)
return model

Yep I'm sorry, my loading/saving code was good, I just had another issue somewhere, thanks for your time

Hi I'm facing the same issue. Could you tell me what other potential issues could cause this ?

I'm afraid i'm unable to help you, it's been more than a year and I'd be completely unable to remember what the problem was

same problem

This is a serious problem, and no one from the members is cared about.  What a shame.

99% of the time it's because your inference code has something different than your validation set eval code. Go through each line of eval and infer code and make sure they are producing the same outputs at each step.


Generate LegalDocML from Slaw

One way that we can make it easier to get Akoma Ntoso into the system is to allow the user to generate it using Slaw from laws.africa. The problem there is that the format of statutory text that Slaw uses is based on african law, and is different from how Canadian law is typically formatted. Slaw also seems to generate sort of odd AKN encodings with hierarchical layers that don't contain anything, and will confuse the user interface.

Made redundant by #191.


Add relap7 submodule

refs #0

Job VTB Documentation on 115e304 wanted to post the following:
View the site here
This comment will be updated on new commits.


When deleting an entire section, start deleting rows from the start of that section

When deleting an entire section, the old behavior will delete rows from the top of the table at index 0.
The total number of rows deleted is correct, but the correct behavior should be to start deleting at subArrayStart rather than at 0.

Oh shoot! Nice find!


Add diagram to doc

Added new documentation and cleaned up the old one. I also increased the tolerance for one test which lead to a failed CI run in the previous PR.

Pushed again into this branch (I just added some more documentation). This PR only affects docs.


[v11] Add convenience initializer

This marks the end of any public APIs (besides properties due to challenges with them) that have providerID: String.

Open to thoughts on next steps... one step further would be to change the internal usage of providerID to AuthProviderID. The issue there is that we will have to explicitly have to go from String → AuthProviderID which means we have to handle the case where a String doesn't map to AuthProviderID. Probably would need to create and throw an "invalid providerID" error.


[BUG] [RULES] Some rules are being triggered in comments

Is there an existing issue for this?

[X] I have searched the existing issues

Konveyor version
0.5 beta 1
Priority
Undefined (Default)
Current Behavior
Some rules are triggering false positives when detecting incidents in code comments
Anything else?
Examples:
azure-file-system-02000

azure-file-system-03000

hardcoded-ip-address

I don't know if I agree that this is a bug, the rule in question is asking for all the file contents to be searched and is finding the correct values. In some cases, we would still very much want this to find things in comments.
I can think of something that we are already considering for these cases, where you can explictly ignore certain incidents, and they will not show up again.
The other option, is that we would need to have a new provider capabability, that would tell us what the comments look like, and then add an option to the builtin to ask all the providers what the comments look like and an optional field that would ignore incidents in comments.
The third option, is to fix the rules, by taking the line found and chaining it to another conditon that would look for the specific comment lines, like * or \\ and seeing if that particular line has those, for that particular rule.
I think the provider capability is probably not worth doing, I would rather focus on rule fixes here IMO. But I did want to make sure that we added the context of what is happening.


Card not displaying correctly on Android mobile app

Describe the bug
With 3.6.5 installed, when the card is viewed on the android mobile app, with horizontal scroll on, one item is displayed on a second row, The card displays correctly when viewed from my web browser on PC.
Expected behavior
One row visible only.
Screenshots

Card Configuration
type: custom:plex-meets-homeassistant
protocol: http
sort: titleSort:asc
playTrailer: true
showExtras: false
showSearch: true
ip: xxx.xxx.x.xx
token: xxxxxxxxxxxxxxxxxxxxxxxx
port: 'xxxxx'
entity:

plexPlayer | LG OLED55CXPVA | xxx.xxx.x.xx | xxxxxxxxxxxxxxxxxxxxxxxxx
libraryName: Movies
maxCount: '20'
maxRows: '1'
useHorizontalScroll: 'Yes'
useShuffle: 'No'
displayTitleMain: 'Yes'
displaySubtitleMain: 'Yes'
minWidth: ''
minEpisodeWidth: ''
minExpandedWidth: ''
fontSize1: ''
fontSize2: ''
fontSize3: ''
fontSize4: ''
minExpandedHeight: ''
title: ''
runBefore: ''
runAfter: ''

Card Version
3.6.5
Plex Version
4.87.2
Device information
Android home assistant app
Additional context
The card functions as expected when i downgraded to version 3.6

It's trying to display 3 items in a row, but the card only fits 2 at default size so it moves one down a row. If you set the Min Width to something like 80 it shows properly.
Problem is when you click on a title it tries to show full PC Plex window of the content.


Conditions tab option "Start the task only if the computer is idle for:" does not persist

If you check this option, save and re-open the schedule, this option remains unchecked.
Originally posted: 2012-12-19T07:57:24

Fixed in source release 81938. Thanks for finding this bug. It will be rolled into the next downloadable release (1.9.3?).
Originally posted: 2012-12-21T11:06:23

Wow, that was swift! Thanks a lot David!
Originally posted: 2012-12-21T13:27:07


Maps doesn't appear when I use lazy loading from Ionic 3

Issue description
When I use lazy loading the map doesn't appear. The problem is similar when you do not set css property.
I don't need this in this moment, but someone else may need it. Please, correct me if I'm wrong.
Steps to reproduce and a minimal demo of the problem
Constructing the map
component.html
<ion-content>     <agm-map [latitude]="lat" [longitude]="lng" [zoom]="20" style="height: 100%">       <agm-marker [latitude]="lat" [longitude]="lng"></agm-marker>     </agm-map> </ion-content>
component.ts
  this.geolocation.getCurrentPosition()       .then(         (location) => {           this.lat = location.coords.latitude;           this.lng = location.coords.longitude;         }       )       .catch(         (error) => console.log(error)       );
Importing page
app.component.ts
this.pages = [         { title: 'OtherPage', component: 'OtherPage', home: true, mobile: false },         { title: 'OtherPage', component: 'OtherPage', home: false, mobile: false },          { title: 'Mapa', component: 'MapaPage', home: false, mobile: false }               ];
If I import normally (without lazy loading) everything happens fine.
Ionic Framework: 3.9.2
Ionic App Scripts: 3.1.6
Angular Core: 5.0.3
Angular Compiler CLI: 5.0.3
Node: 8.9.3
OS Platform: Windows 10

Did you set a default height in the CSS for the AGM element? Need a fixed height to start with to display it.

Yes, @timcblank , I set it. It's works well without lazy loading, but if I implement this, stop working.

I finally solved this. I imported in NgModule of app.module instead of the NgModule of the component.module

Hi @edisonmatoso, I don't understand what you meant. I am having the same issue but with Android.


Add missing test in MalihuScrollbarService

Coverage increased (+2.2%) to 97.849% when pulling b75b1228038ba58a6c78c8c0c25d2d9ef53054f7 on add-test into 3646c7459b876cab9a41a734c4178c280bfd0fc3 on master.


"Focus Window On Break" setting does not work as expected

Issue
The debug.focusWindowOnBreak setting does not work consistently. It seems to work fine with other debuggers (javascript, for example). However, the VSCode window does not gain focus when a breakpoint gets triggered when using the Unity Debugger extension.

Version Information
VS Code version: Code 1.47.3 (91899dcef7b8110878ea59626991a18c8a6a1b3e, 2020-07-23T13:12:49.994Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3770K CPU @ 3.50GHz (8 x 3500)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.95GB (5.06GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (22)

Extension
Author (truncated)
Version

better-comments
aar
2.1.0

vscode-sqlite
ale
0.8.2

glua
aSt
1.1.0

vscode-intelephense-client
bme
1.5.3

dart-code
Dar
3.13.2

flutter
Dar
3.13.2

gitlens
eam
10.2.2

php-debug
fel
1.13.0

php-intellisense
fel
2.3.14

csharp
ms-
1.22.1

python
ms-
2020.7.96456

remote-wsl
ms-
0.44.4

vsliveshare
ms-
1.0.2478

material-icon-theme
PKi
4.2.0

platform-settings
run
0.0.2

code-settings-sync
Sha
3.4.3

markdown-preview-enhanced
shd
0.5.12

ayu
tea
0.20.1

unity-debug
Uni
2.7.5

vscode-icons
vsc
10.2.0

vim
vsc
1.16.0

markdown-all-in-one
yzh
3.2.0

(4 theme extensions excluded)

Steps to Reproduce

Install "Debugger for Unity" extension
Run the debugger, set a breakpoint and attach to a Unity project
Hit Play from the Unity Editor
Cause the breakpoint to trigger
Notice the VSCode window staying in the background, not requesting focus or giving any feedback that the breakpoint was triggered.

Does this issue occur when all extensions are disabled?: N/A - I do not believe this to be an issue specific to the extension at play, considering it does in fact trigger the breakpoint on the VSCode side of things.

@weinand I don't think the issue is caused BY the extension itself. VSCode should respect the option regardless of how a breakpoint gets triggered

You said that "Focus Window On Break" works fine with other debuggers.
From this I conclude that there is an issue with the specific extension.


Why are classes and decorators an anti-goal?

Just curious, why are classes and decorators an anti goal?

the short answer is type inference. Both of these make it so you have to manually specify the types of flags/args. I want all the typescript to be automatic.


[stable/redis] Enable AOF by default

Signed-off-by: juan131<EMAIL_ADDRESS>What this PR does / why we need it:
This PR enables AOF by default to ensure the persistence in Redis.
References:

https://redis.io/topics/persistence#append-only-file
https://redis.io/topics/persistence#interactions-between-aof-and-rdb-persistence

Which issue this PR fixes

fixes #13503

Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] title of the PR contains starts with chart name e.g. [stable/chart]

Thanks @juan131 !


flutter run test/widget_test.dart + Performing hot restart... Going wrong

Steps to Reproduce

Just create a flutter project from scratch, the one with "You have pushed the button this many times:".
run from your terminal in your app folder flutter run test/widget_test.dart
Hot Restart by pressing R

Logs
flutter analyze
Analyzing untitled...
No issues found! (ran in 2.0s)

flutter doctor
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
[!] Android Studio
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    ✗ android-studio-dir = /home/omar/android/sdk/platform-tools
    ✗ Unable to find bundled Java version.
[✓] IntelliJ IDEA Community Edition (version 2018.3)
[✓] Connected device (1 available)

! Doctor found issues in 1 category.

What I get in the Terminal Panel
graphics artifacts, consider enabling software rendering with
"--enable-software-rendering".
Launching test/widget_test.dart on Android SDK built for x86 in debug mode...
Initializing gradle...                                       1.0s
Resolving dependencies...                                    2.5s
Gradle task 'assembleDebug'...
Gradle task 'assembleDebug'... Done                          8.1s
Built build/app/outputs/apk/debug/app-debug.apk.
Installing build/app/outputs/apk/app.apk...                  1.8s
E/flutter ( 6680): [ERROR:flutter/shell/common/shell.cc(184)] Dart Error: Unhandled exception:
E/flutter ( 6680): NoSuchMethodError: The method 'test' was called on null.
E/flutter ( 6680): Receiver: null
E/flutter ( 6680): Tried calling: test("Counter increments smoke test", Closure: () => Future<void>, onPlatform: null, retry: null, skip: false, solo: false, tags: null, testOn: null, timeout: Instance of 'Timeout')
E/flutter ( 6680): #0      Object.noSuchMethod (dart:core/runtime/libobject_patch.dart:50:5)
E/flutter ( 6680): #1      test (package:test_api/test_api.dart:101:13)
E/flutter ( 6680): #2      testWidgets (package:flutter_test/src/widget_tester.dart:66:3)
E/flutter ( 6680): #3      main (file:///home/omar/mprojects/untitled/test/widget_test.dart:14:3)
E/flutter ( 6680): #4      _startIsolate.<anonymous closure> (dart:isolate/runtime/libisolate_patch.dart:289:19)
E/flutter ( 6680): #5      _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)
Syncing files to device Android SDK built for x86...         2.5s

Hi @omrllm, there is a workaround for this bug, in your test file add:
import 'package:flutter_test/flutter_test.dart' hide group;
import 'package:test/test.dart' show group;

void main() {
  group('', () { // Rest of tests });
}

For updates please follow https://github.com/flutter/flutter/issues/24650


Question: FileNotFoundError - 'single-file' and others

Hallo
I just installed on a virtual Ubuntu 20.04 (with GUI) machine (VMware Workstation 15) ArchiveBox. VMware running on Windows 10 (64-Bit) host.
I want to scrape a whole Website with all internal links as a local backup. I dont need versions, just the actual one, but with all sub sites (of same domain).
I ran
archivebox add 'https://efk-adoptionen.de'
and I got errors:
...
No such file or directory: 'single-file'
...
No such file or directory: 'readability-extractor'
...
No such file or directory: 'mercury-parser'
...

more Output here (collapsed):

archivebox output

franc@ubuntu20:~/data$ archivebox add 'https://efk-adoptionen.de'
[i] [2021-06-26 09:08:59] ArchiveBox v0.6.2: archivebox add https://efk-adoptionen.de
    > /home/franc/data

[!] Warning: Missing 5 recommended dependencies
    ! NODE_BINARY: node (unable to detect version)
    ! SINGLEFILE_BINARY: single-file (unable to detect version)
      Hint: To install all packages automatically run: archivebox setup
            or to disable it and silence this warning: archivebox config --set SAVE_SINGLEFILE=False

    ! READABILITY_BINARY: readability-extractor (unable to detect version)
      Hint: To install all packages automatically run: archivebox setup
            or to disable it and silence this warning: archivebox config --set SAVE_READABILITY=False

    ! MERCURY_BINARY: mercury-parser (unable to detect version)
      Hint: To install all packages automatically run: archivebox setup
            or to disable it and silence this warning: archivebox config --set SAVE_MERCURY=False

    ! RIPGREP_BINARY: rg (unable to detect version)

[+] [2021-06-26 09:09:00] Adding 1 links to index (crawl depth=0)...
    > Saved verbatim input to sources/1624698540-import.txt
    > Parsed 1 URLs from input (Generic TXT)
    > Found 1 new URLs not already in index

[*] [2021-06-26 09:09:00] Writing 1 links to main index...
    √ ./index.sqlite3

[▶] [2021-06-26 09:09:00] Starting archiving of 1 snapshots in index...

[+] [2021-06-26 09:09:00] "efk-adoptionen.de"
    https://efk-adoptionen.de
    > ./archive/1624698540.780421
      > title
      > favicon
      > headers
      > singlefile
        Extractor failed:
            FileNotFoundError [Errno 2] No such file or directory: 'single-file'
        Run to see full output:
            cd /home/franc/data/archive/1624698540.780421;
            single-file --browser-executable-path=chromium-browser "--browser-args=[\"--headless\", \"--user-agent=Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.61 Safari/537.36 ArchiveBox/{VERSION} (+https://github.com/ArchiveBox/ArchiveBox/)\", \"--window-size=1440,2000\"]" https://efk-adoptionen.de singlefile.html

      > pdf
      > screenshot
      > dom
      > wget
      > readability
        Extractor failed:
            FileNotFoundError [Errno 2] No such file or directory: 'readability-extractor'
        Run to see full output:
            cd /home/franc/data/archive/1624698540.780421;
            readability-extractor ./{singlefile,dom}.html

      > mercury
        Extractor failed:
            FileNotFoundError [Errno 2] No such file or directory: 'mercury-parser'
        Run to see full output:
            cd /home/franc/data/archive/1624698540.780421;
            mercury-parser https://efk-adoptionen.de --format=text

      > media
      > archive_org
Extractor timed out after 60s.
        Run to see full output:
            cd /home/franc/data/archive/1624698540.780421;
            curl --silent --location --compressed --head --max-time 60 --user-agent "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.61 Safari/537.36 ArchiveBox/0.6.2 (+https://github.com/ArchiveBox/ArchiveBox/) curl/curl 7.68.0 (x86_64-pc-linux-gnu)" https://web.archive.org/save/https://efk-adoptionen.de

        79 files (7.0 MB) in 0:01:23s

[√] [2021-06-26 09:10:24] Update of 1 pages complete (1.39 min)
    - 0 links skipped
    - 1 links updated
    - 1 links had errors

    Hint: To manage your archive in a Web UI, run:
        archivebox server <IP_ADDRESS>:8000
franc@ubuntu20:~/data$

I didnt find these errors here, I installed as described in the wiki, so I dont understand these errors.
Later I checked the contents in the browser with address localhost:8000 but I find only the Home page of the added address, All menu items or links are unsaved. I don't know if that is related to the mentioned errors.
Maybe I totally misunderstood this project?
Isnt it to scrape a website to a local archive?
I didnt find any option to check which link level to scrape or if allowed to leave the domain etc.
I was using HTTrack previously, when I wanted to download a whole website locally, but that project is abandoned and doesnt fit actual needs anymore (addresses with Umlaute e.g.).
How can I do this with ArchiveBox, is it possible?
Thanks for hints, frank

ArchiveBox is not primarily designed for recursive archiving of a single site, you should use a different tool for that, see https://github.com/ArchiveBox/ArchiveBox/issues/191 and https://github.com/ArchiveBox/ArchiveBox/wiki/Web-Archiving-Community#other-archivebox-alternatives
The errors in your output mean you have not installed all the dependencies yet, I recommend using ArchiveBox with docker to avoid having to install all the dependencies manually, or install it with apt or using our bash helper script to finish the partial install you've started.

Thank a lot, Pirate!
First I checked again httrack, which seems abandoned since 2017 (and no fork did real work on it it, I found, see Find the newest fork of an old repo or Find the most popular fork on GitHub or Active GitHub Forks).
Then I checked wget which can do more than I knew :)
Lastly I repaired my ArchiveBox installation, had to install nodejs and ripgrep and run archivebox init --setup again, till no more errors :)
Now  I wanted to try your attempt with:
archivebox add --depth=1 https://example.com
archivebox list https://example.com | archivebox add --depth=1
archivebox list https://example.com | archivebox add --depth=1
archivebox list https://example.com | archivebox add --depth=1

But here I don't want to include any url out of example.org, is that possible, is there an option?
Thanks.
Frank


Change epsagon url

:tada: This PR is included in version 1.73.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


SaveCursor and SaveUndo settings log invalid syntax

Description of the problem or steps to reproduce
savecursor and saveundo settings log invalid syntax when turned on in MacOS
Specifications
micro installed through brew
Commit hash: 5fc8f84
OS: MacOS 10.13.2
Terminal: Terminal.App v2.8.0

I'd be interested in working on this, but I'm new to micro

I'm not really sure what you mean by logging invalid syntax. I don't seem to be having any issues with those settings on.

Sorry, it's logging 'invalid argument' when I save, not invalid syntax. I have fmt installed as well, and that is logging about using the bundled uncrustify prior to 2 'invalid argument' entries, so that may be related. I'll try and narrow down what the cause is

@nijaru Are you on v3 or 3.1? There was a bug I overlooked that, if I remember right, had that wording. Fixed in v3.1.1


Join sources on single destination

The only thing I changed was to join the text on multiple sources into one destination
Nothing in this pr has changed behavior of before and after. We could probably add a couple of tests anyway.

The only thing I changed was to join the text on multiple sources into one destination Nothing in this pr has changed behavior of before and after. We could probably add a couple of tests anyway.

Yeah I mean adding tests where you bring multiple before.  I could see that getting broken somehow where we end up adding two delimiters.  And same adding tests where we bring multiple to a target that is an arg.  Also prob useful "bring air and bat to arg cap"; I think currently your tests just do after and cursor

I understand in completely agree. Tests added


Dmctl can't start relay after upgrade from 2.0.1(enable-relay:  true)-> 5.4.0

What did you do?
config source1 as enable-relay: false
upgrade dm cluster from 2.0.1 -> v5.4.0
try to start-relay for source1
What did you expect to see?
start-relay for source1 success
What did you see instead?
fail to start-relay,
use:
tiup dmctl --master-addr=ip:8261 start-relay  -s mysql-replica-2-002 dm-worker-8101
report :
"result": {
"isCanceled": false,
"errors": [
{
"ErrCode": 30008,
"ErrClass": "relay-unit",
"ErrScope": "internal",
"ErrLevel": "high",
"Message": "initial relay unit: dirpath is empty",
"RawCause": "",
"Workaround": "Please check the relay-dir config in source config file."
}
],
use operate-source show to check, report:
"msg": "[code=38032:class=dm-master:scope=internal:level=high], Message: some error occurs in dm-worker: ErrCode:30008 ErrClass:"relay-unit" ErrScope:"internal" ErrLevel:"high" Message:"initial relay unit: dirpath is empty" Workaround:"Please check the relay-dir config in source config file." , Workaround: Please execute query-status to check status.",
"source": "mysql-replica-2-002",
"worker": "dm-worker-8101"
}
]
Versions of the cluster
DM version (run dmctl -V or dm-worker -V or dm-master -V):
v5.4.0

Upstream MySQL/MariaDB server version:
(paste upstream MySQL/MariaDB server version here)

Downstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
(paste TiDB cluster version here)

How did you deploy DM: tiup or manually?
(leave TiUP or manually here)

Other interesting information (system version, hardware config, etc):
>
>

current status of DM cluster (execute query-status <task-name> in dmctl)
(paste current status of DM cluster here)

caused by in v2.0.1, we only adjust relay-dir for enable-relay: true sources.
we changed to always adjust relay-dir in https://github.com/pingcap/dm/pull/1515

I will add a flag --relay-dir to command dmctl start-relay.When receiving start-relay command, The dm-master will check if empty the relay-dir in source config, if so, "relay-dir is empty" error will be responded and we offer "dmctl start-relay --relay-dir" as a workaround to solve this problem.How about this solution ? @lance6716 @sunzhaoyang @Ehco1996

currently relay-dir in DM-worker config file has highest priority. And after introduce start-relay --relay-dir, I think the command line argument should have highest priority. If the implementation is that use start-relay --relay-dir to fillback relay-dir in source config file, the source config will still be overwritten by relay-dir in DM-worker config file. Please take note of it. @niubell

currently relay-dir in DM-worker config file has highest priority. And after introduce start-relay --relay-dir, I think the command line argument should have highest priority. If the implementation is that use start-relay --relay-dir to fillback relay-dir in source config file, the source config will still be overwritten by relay-dir in DM-worker config file. Please take note of it. @niubell

Thanks for reminding me. The priority of relay-dir in open-api is lower than relay-dir in dm-worker config file.Shall we keep this consistent with each other? By the way, the relay-dir in dm-worker config file goes to effect in observation of Etcd path, it's hard to change this mechanism.

Just optimize workaround message in 30008. The message will be Please check the relay-dir config in source config file or dm-worker config file


FileNotFoundException: Could not load assembly FreshMvvm when using FreshMvvm with .NET Standard library

I've created a Xamarin.Forms project which uses .Net Standard 1.4 for the main assembly instead of a PCL. After adding the FreshMvvm NuGet package, I see the following error when trying to build Android:

Exception while loading assemblies: System.IO.FileNotFoundException: Could not load assembly 'FreshMvvm, Version=1.0.6508.20839, Culture=neutral, PublicKeyToken='. Perhaps it doesn't exist in the Mono for Android profile?

I have done the same with 1.4 and with 2.0 and both configurations are working without issues. Have you checked your dependencies?

The issue was resolved after I installed FreshMVVM on my platform-specific projects. I had thought that it would only need to be installed in the shared project, but I guess I was wrong! Thank you for the help!


source file are not complited

Hi this repo is missing many files!

even if I add these files from the source JAR it still does not compile

Those files are generated by Javacc as part of the maven build.  They should land in the target/generated-sources/javacc directory.

ok thanks I see now, but the generate code is not good. it can't compile:
JsonParser line: 362:
 if ((first == last) && ((first == '"') || (first == '\u005c''))) {

What compiler are you using. The code is a little obfuscated but should compile just fine.
I suspect you are getting an error from this value:
'\u005c''

\u005c is unicode for backslash so that maps to:
'\''

Which is a valid character.  I am not sure why the code uses the unicode escaped version of backslash.

using ORACLE JDK 1.8 build 65


history.end_rip_after_already_seen no longer works

Ripme version: 1.7.82
Java version: 1.8.0_201
Operating system: 6.1.7601
Exact URL you were trying to rip when the problem occurred: N/A
Please include any additional information about how to reproduce the problem:

Expected Behavior
On certain rippers like Twitter and Instagram ripper, it moves onto the next URL if it encounters too many already downloaded files.
Actual Behavior
It keeps downloading files anyway.

It used to work correctly on older versions, albeit a bit random at times (it may stop after 5 URLs, 15 URLs or 40 URLs).

Did history.end_rip_after_already_seen ever work with twitter? Because not all rippers support history.end_rip_after_already_seen

I think so? I know Instagram ripper had this function, at least.

This funtionality is added for twitter with the changes in https://github.com/RipMeApp/ripme/pull/1433. This will only check after each request and each request have a default of 200 tweets. In the new version you can add the twitter.max_items_request property to change that value


Fix #564 - fix group batch exception handling

PR build failing due to flakey test a fix point.  Ignore cloudbees


Fixed the indentation convention problem

Fixed indentation convention problem in two places

@aselle can you pls review the PR and let me know your comments

Nagging Reviewer @aselle: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 15 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @aselle: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 30 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @aselle: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 45 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @aselle: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 60 days with no activity and the awaiting review label has been applied.

@impjdi, thanks for the review, i am closing this PR


Use proper language code for Kannada analyzer

@blake-fisher : Thanks for your contribution! The author, @Yahnoosh, has been notified to review your proposed change.

"kn" is the correct language code for Kannada language as per ISO 639-1.

Thanks!


Work out what vacancy visualisations to add to data dashboard landing page

Vacancies currently blocked by #93 and #94.

Regarding CPI visualisations to add to landing page, @luke-strange I was wondering what you thought might be the main visualisation to add to the data dashboard landing page (e.g. https://data.youthfuturesfoundation.org/).
I was wondering if it is the first visualisation showing CPI changes most affecting young people? Given that was the first visualisation we were asked to create, I think it feels the best to show - thoughts?

I agree - the bar chart with categories affecting young people is most important. @ODILMichelle

Picked up CPI visualisation and renamed this and ticketed it as #194


update to defaults file

Pull Request Test Coverage Report for Build 954808600

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 77.446%

Totals

Change from base Build 954492565:
0.0%

Covered Lines:
369

Relevant Lines:
477

💛  - Coveralls


Refresh drives list when mounting/unmounting ISO file

Fixes #2403
Fixes? #1490
Fixes? #1257
Refresh drive list when an ISO, VHD gets inserted or removed.

@gave92 Sorry, but for some reason it is doesn't work for me.

@tsvietOK thanks for the feedback.
Are you ejecting the iso from Files or windows Explorer?

@gave92

It doesn't matter, both methods successfully ejects drive, but interface not updated.

@tsvietOK curious, for me it works correctly if the iso is ejected from explorer
If I eject it from Files, it looks like it was ejected but it will still appear both in Files and explorer
In explorer it will look like an empty drive:

@gave92 Unmounted state: Normal state for empty virtual ISO drive

Mounted state: Name of drive should be updated like on the next screenshot.

After app restart:

Ejected from explorer or Files:

As you can see, any changes(except new drives plugged in) are not visible for Files.
When connected to fulltrust the Output window is empty when ejecting through explorer or from Files.
I am using Daemon Tools to mount ISO.

@tsvietOK ok I'm just mounting the iso with explorer, could you check if that works?
I'll test with daemon tools.

@gave92 Same behavior when mounting with explorer.

@tsvietOK with the latest commit also works for daemon tools for me.
Have you been testing with debug or release version?

@gave92 Debug version.

@gave92 Now ISO ejecting works fine for explorer and Files. Can you do the same for flash rives? One issue remains, when mounting ISO disk name doesn't updating.

@tsvietOK flash drives should be already be working on master (added/removed from list when connected/disconnected). What are you experiencing?

@gave92 When pressing eject on flash drive, it is successfully ejects, but Files keeps this drive in sidebar.

@tsvietOK drive name on sidebar and main page should now update when inserting/ejecting an ISO
Regarding removable drives: I have no issues with them sorry, even on master: when I physically disconnect them from pc they disappear from the list

@gave92 When i say "eject" i mean ejecting, not disconnecting.
When mounting ISO through explorer and:

unmounting through Files drive still in sidebar list

unmounting through explorer drive removed from list <--- as it should be.

About flash drive. Drive ejected but still connected:

Files shows this drive.

Explorer doesn't.

@tsvietOK

For removable drives (e.g pen drive): clicking eject does not remove from list -> normal, does not remove from explorer either
For ISO drives: clicking eject from Files does not remove from list -> "normal", explorer will also show an empty drive
(2) indicates an issue with how we eject drives, not with this PR

@gave92 About 2. When mounting an ISO through explorer, and ejects through explorer, it will not show an empty drive.

@tsvietOK But if you eject the ISO from Files, will explorer show an empty drive?
If yes, the issue is in the code we use to eject the drive, not in how we update the list (this PR)

@tsvietOK
When mounting an ISO through explorer, and ejects through explorer -> does Files remove the drive from the list?

Yes.

When mounting an ISO through explorer, and ejects through Files-> will explorer still show an empty drive?
If yes, the issue is in the code we use to eject the drive, not in how we update the list

Yes.
I think drives list should be updated automatically when you eject drive. Maybe exist other way to eject drive.

Yeah atm I have no clue on how to do that, but I'm sure the author of PR #2328 will find a solution :)
What I can do in this PR is disable the "eject" item for ISO/CDROM drive.. what do you think?

@gave92 Why? Eject function working with ISO better than with flash drives.

What? From what you said above I thought the issue was with ISO drives

When mounting an ISO through explorer, and ejects through Files the drive remains in both Files and explorer

@gave92 When ejecting drives, Files keeps them in list with original name, it will be removed when you disconnect drive. While Explorer successfully ejects drive and hides it.
Summary about ISO.
When mounting through Daemon tools, drive added successfully.
Ejecting through Files working (with empty drive in both explorer and Files). <-- normal
Ejecting through explorer working (with empty drive in both explorer and Files). <-- normal
When mounting through explorer, drive added successfully.
Ejecting through Files working (with empty drive in both explorer and Files). <-- not normal
Ejecting through explorer working (without empty drive in both explorer and Files). <-- normal
About your PR. I think it is not only about ISO, VHS etc.. You changing device watcher system, so it could be fluent to other drives (flash). So if you successfully added "update" system when ISO drives are added/ejected, i thought you can add the same system for flash drive if possible. If not, it is not a problem, maybe problem is in eject algorithm.

@tsvietOK sorry I'm still confused, I'll think on it tomorrow :)

OK this is what I'm getting after the latest changes:
[DAEMON TOOLS LITE]

adding a new virtual drive -> works, new cd drive is added to Files
removing a virtual drive -> works, cd drive is removed from Files
mounting an iso -> works, drive name is updated in Files
unmounting an iso from Files -> works, drive name is updated in Files
unmounting an iso from Explorer -> works, drive name is updated in Files
unmounting an iso from DaemonTools tray -> works, drive name is updated in Files

[ISO MOUNTED IN EXPLORER]

mounting an iso -> works, new cd drive is added to Files
unmounting an iso from Explorer -> works, cd drive is removed from Files
unmounting an iso from Files -> doesn't work, name changes but cd drive is not removed from Files and Explorer

[USB DRIVES]

connecting a new device -> works, new device is added to Files
physically detaching a device -> works, device is removed from Files
ejecting device from taskbar -> works, device is removed from Files
ejecting device from Files -> doesn't work, device is not removed from Files and Explorer
ejecting device from explorer -> doesn't work, device is not removed from Files but is removed from Explorer


Enable PAT for authentication

Trying to run test-reporter locally using nectos/act with a personal access token results in:
| Creating check run Tests
[Test/run_tests]   ❓  ::endgroup::
[Test/run_tests]   ❗  ::error::You must authenticate via a GitHub App.
[Test/run_tests]   ❌  Failure - Test report

I imagine this is because creating the check run necessarily requires access to a Repo. I wonder if there could be a dry-run flag which would cause the action to parse the report, but refrain from actually creating the check run. This would allow the pipeline to continue.

I would also be very interested in this.

👍  same problem

Is there a workaround for this? As far as I can tell, this issue makes the action unusable for jobs that run longer than 24 hours. Am I missing something?
If I DO NOT provide a token
- name: Generate Set ${{ matrix.set }}${{ matrix.variant }} Test Report
  uses: dorny/test-reporter@v1
  with:
    name: Results Set ${{ matrix.set }}${{ matrix.variant }}
    path: qual/report/set_${{ matrix.set }}${{ matrix.variant }}.json
    reporter: mocha-json

Any job that runs for more than 24 hours results in Error: HttpError: Bad credentials

If I DO provide a token
- name: Generate Set ${{ matrix.set }}${{ matrix.variant }} Test Report
  uses: dorny/test-reporter@v1
  with:
    name: Results Set ${{ matrix.set }}${{ matrix.variant }}
    path: qual/report/set_${{ matrix.set }}${{ matrix.variant }}.json
    reporter: mocha-json
    token: ${{ secrets.TEST_REPORTER_TOKEN }}

ALL jobs result in Error: HttpError: Resource not accessible by personal access token

I'm using a fine-grained token with
✔Read access to metadata
✔Read and Write access to actions, administration, and workflows


Add controllerTest type as a helper for running controller integration tests

Add controllerTest which extracts a lot of the boilerplate for setting up integration tests that test controller logic.

WOOO
LGTM

Looks great!


Handling of unit cell parameters when they are missing from the file

I am reading a DCD file (generated with NAMD) with chemfiles. In NAMD, the simulation was run without any periodic boundary conditions, however, it seems that NAMD sets the unit cell lengths to 1 Angstrom and angles to 90 degrees each when there is no boundary.
The chemfiles documentation mentions that the unit cell information is not read from the DCD file format. So, I am not sure if chemfiles is setting those values by default, or whether it is actually reading them in from the DCD file. (The VMD molfile plugins do read the unit cell information from DCD.)
Either this is a bug in chemfiles, or the documentation has not been updated.
Also, would it be possible/reasonable to recognize that the 1 Angstrom value of unit cell was set because there is no unit cell (because 1 Angstrom is unlikely to be the size of an unit cell in any practical simulation), and then set it to infinity (i.e. no unit cell)?
This would eliminate issues when reading a trajectory without PBC.
The DCD file, and the corresponding PSF and PDB files are attached: testfiles.zip.

@Luthaf Thank you, I have opened a pull request.
I am not sure about other formats. For example, I think gromacs XTC files hold unit cell data. However, the newest versions of gromacs (>v2020) completely disallow simulations without PBC. Testing with earlier versions will reveal what gromacs outputs when there is no PBC.
I don't think PDB files always have to have a unit cell. If the CRYST1 record is missing then it does not have any unit cell information. So, I am not sure if it will always apply to PDB. I have never used mmCIF files.

@Luthaf I have found out that the problem with unit cell parameters is coming from the VMD molfile plugin itself, the DCD file does not have unit cell data if the simulation was run without PBC in NAMD.
When the DCD file without PBC is opened with MDAnalysis, it says that there is no unit cell data in the trajectory file. MDAnalysis does not use molfile plugin to read DCD, it uses it's own dcd reader written in cython (https://github.com/MDAnalysis/mdanalysis/blob/develop/package/MDAnalysis/lib/formats/libdcd.pyx). So, it seems that VMD molfiles automatically puts those values when it cannot read the unit cell data from DCD file, and since chemfiles depends on molfiles, it gets those data. So, it should be solved by #389.

Sorry for chiming in this late.

Detecting cells with 1A/90° as infinite cells is definitively something we should do

I feel like this would introduce rather unpredictable behavior. After all, this is a completely valid orthorhombic cell. Software like Lammps can have all sorts of different units which means that a unit cell with lengths 1 might be also physically sensible. AFAIK Lammps is also able to produce DCD files.

However, the newest versions of gromacs (>v2020) completely disallow simulations without PBC. Testing with earlier versions will reveal what gromacs outputs when there is no PBC.

Unfortunately, I was unable to easily test the behavior on older versions because of all sorts of weird crashes. If anybody is interested in trying, here are more details about vacuum simulations.
Anyway, I believe that Gromacs simply dumps a zero matrix (judging from this function that is used when reading some input files). This means that XTC and TRR files should handle infinite cell correctly. Setting everything to zero seems to be the norm in general.
I guess all the other formats are therefore fine too?

I have found out that the problem with unit cell parameters is coming from the VMD molfile plugin itself

This insight makes fixing this much easier. The offending part is here.
Should we simply change the default to 0.0?
I can do a PR, if you think that this is an acceptable fix.

I feel like this would introduce rather unpredictable behavior. After all, this is a completely valid orthorhombic cell. Software like Lammps can have all sorts of different units which means that a unit cell with lengths 1 might be also physically sensible. AFAIK Lammps is also able to produce DCD files.

I agree that we don't want to do this for all formats!
I'm only suggesting to do it for formats where this kind of 1A cell is used to show missing PBC. For example, some experimental PDB files (from cryo-EM) use this convention when they don't know the cell size: https://github.com/MDAnalysis/mdanalysis/issues/2599. I also mentioned mmCIF here since that's the other format used a lot in wwwPDB. I'll dig a bit deeper on which formats this should apply to, but PDB/mmCIF/MMTF would be the main suspects.

It looks like this is not a format issue for DCD files but rather a molfile problem, so fixing the plugin is a way better solution indeed!

Thanks for pointing me to the MDA issue. I wasn't aware of this rather weird convention. If it's an accepted convention - as it seems to be - then I'm totally fine with doing this for impacted formats.

Let's keep this open to track similar changes for PDB & friends


Nominate Emily Johnson (@emmjohnson) as Nodejs Contributor

In accordance with the Paketo Buildpacks Governance document, I am nominating Emily Johnson (@emmjohnson) as a contributor to the Nodejs language family. Emily is a regular contributor to the buildpack family (https://github.com/paketo-buildpacks/nodejs/pull/321, https://github.com/paketo-buildpacks/node-engine/pull/240 etc.).

+1

With supermajority vote of maintainers in the affirmative, the nomination is considered to be approved.
Welcome to the team of Nodejs Contributors @emmjohnson!
@paketo-buildpacks/steering-committee  Could you please add Emily to the contributors team on github?

@emmjohnson Congrats!
@arjun024 Done!


nav-pills inside a card-block doesn't maintain the card-height.

(bootstrap v4)
When placing a nav-pills list of links inside a card-block, the card doesn't maintain the required height.
This problem does not occur with any of the other lists so I think it's unintended behaviour.
Example of nav-pills
Example of nav-tabs
Example of base nav
As you can see, only nav-pills has unintended behaviour. In case anything happens to the hosted code examples, here's a screenshot and the core part of the code to re-create this issue.

				navlink 1

				navlink 2

				navlink 3

				navlink 4

This has been fixed in the below pull request: https://github.com/twbs/bootstrap/commit/49379fd5f7fff0dbc88305c6a627f1f0351327ce


Hide last block

Exp. I have 3 block for rotate, but different height and when rotated block I see this bug...
http://i.imgur.com/OI7iCE2.png how I can clear...

Sorry but this plugin does not support slides of different size.

Different size ok, but can we hide last block after transform...?

Different size ok, but can we hide last block after transform...?

Just give the whole of each slide a background colour.
Sent from my iPhone

On 6 Feb 2016, at 11:52, Alex Belov<EMAIL_ADDRESS>wrote:
Different size ok, but can we hide last block after transform...?
—
Reply to this email directly or view it on GitHub.

Please help me, how I can do it...? http://goo.gl/iK69iI

Really you need to make each slide the same height. The effect you are using is not designed to support variable sized faces.

ok, but can we hide last block after transform...?
Exp. only active block I need display: block; http://i.imgur.com/UcfxjLx.png


Updates to v0.8.1

Final round of updates to get Trinity up to spec v0.8!
Some things blocked on other work:
~1. Updating BLS so that we can provide a Domain, instead of a int. Need to update py_ecc and get_domain, compute_domain helpers.~
~NOTE: blocked on releasing https://github.com/ethereum/py_ecc/pull/78~
~2. Update the justification_bits pending py-ssz updates.~
~3. Use the new py-ssz types for List, BitVector and BitList. py-ssz updates in https://github.com/ethereum/py-ssz/pull/77.~
~4. Need to fix issue w/ field collision on root; see: https://github.com/ethereum/py-ssz/issues/79~
~Blocked on releasing new py-ssz from here: https://github.com/ethereum/py-ssz/commit/4779ce8b2dced0ac575468ff99e69a0073853f98~
Cute Animal Picture

this is ready for review -- should have trinity up to spec v0.8.1