BUG: Fix SDD parameter calculation for parallel geometry

The source to detector distance (SDD) parameter is forced to be equal 0.0 when it calculated by AddProjection methods and the SDD absolute value is less than 1.E-06.
For example:
A forward projection, in case of parallel geometry, can't be calculated if SDD == 1.E-10; because of checks like:

https://github.com/SimonRit/RTK/blob/master/src/rtkThreeDCircularProjectionGeometry.cxx#L469
https://github.com/SimonRit/RTK/blob/master/src/rtkThreeDCircularProjectionGeometry.cxx#L570

I don't think I ever added a parallel projection from a matrix. When I try to do it
>>> from itk import RTK as rtk
>>> g=rtk.ThreeDCircularProjectionGeometry.New()
>>> g.AddProjection(100,0,5)
>>> g2=rtk.ThreeDCircularProjectionGeometry.New()
>>> g2.AddProjection(g.GetMatrix(0))
/work/ITK-source/ITK/Modules/ThirdParty/VNL/src/vxl/core/vnl/algo/vnl_svd.hxx: suspicious return value (3) from SVDC
/work/ITK-source/ITK/Modules/ThirdParty/VNL/src/vxl/core/vnl/algo/vnl_svd.hxx: M is 3x3
M = [ ...
            -nan             -nan             -nan
            -nan             -nan             -nan
            -nan             -nan              nan  ]
WARNING: In ../../../src/rtkThreeDCircularProjectionGeometry.cxx, line 309
DataObject (0x557716809ea0): Failed to AddProjection

False

having a sdd actually equal to 0 does not seem to be the main problem. Do you have a test that illustrates your PR?
@lesaintjerome might be able to help, he coded AddProjection(matrix)

I don't think I ever added a parallel projection from a matrix. When I try to do it

Apologies for misleading!
I've only tested with AddProjection method,
bool
rtk::ThreeDCircularProjectionGeometry::AddProjection(const PointType &  sourcePosition,
                                                     const PointType &  detectorPosition,
                                                     const VectorType & detectorRowVector,
                                                     const VectorType & detectorColumnVector)

and not with the matrix one.
I will try to make a couple of tests to show the behavior.

One more thing, i've tested in C++ not python.

Just an example to show the problem in my case.
Here is the data in DICOM: https://github.com/SlicerRt/SlicerRtData/tree/master/eclipse-8.1.20-phantom-prostate/Original
Parameters for parallel geometry SDD == SAD:
RowVector: 1.22465e-16 2.22045e-16 1.0
ColumnVector: 1.0 -1.22465e-16 -1.22465e-16
SourcePosition: 1.014 -990.585 -10.1067
DetectorPosition: -248.986 -990.585 -260.107
DRR for parallel geometry

Parameters for cone beam geometry SDD > SAD:
RowVector: 1.22465e-16 2.22045e-16 1.0
ColumnVector: 1.0 -1.22465e-16 -1.22465e-16
SourcePosition: 1.014 -990.585 -10.1067
DetectorPosition: -248.986 309.415 -260.107
DRR for cone beam geometry

having a sdd actually equal to 0 does not seem to be the main problem. Do you have a test that illustrates your PR?
@lesaintjerome might be able to help, he coded AddProjection(matrix)

You are correct.
The main problem is that for parallel geometry the matrix is singular, the determinant of the matrix is zero, so proper projection parameters can't be calculated.

Dear @SimonRit, could you run test workflows?
The possible fix for parallel geometry is to modify projection matrix for inner usage.
Projection matrix could store:

Rotation matrix 3x3.
Projection offset X: Matrix (0, 3)
Projection offset Y: Matrix (1, 3)
SID: Matrix(2, 3)

Rotation matrix determinant is unity, this feature could be used as a flag to calculate rotation angles for parallel geometry.
In that case AddProjection(matrix) method can correctly setup projection parameters. IMHO.

Do you have a test that illustrates your PR?

I've added a test for parallel geometry in the PR. This is just my understanding of the issue.

Thanks. I’m away from any computer until next week, I'll review it then.

I've reworked calculation from matrix for parallel geometry.

Thanks for the contribution and the test. Looks good to me if the CI comes green.


Chance shape?

Could there be something you attach to a paddle to change the chance of that rule happening?

Maybe a hexagon? Then each triangle could represent a 1 in 6 chance, and clicking it could cycle it?
Maybe an octagon? Then It'd be 1 in 8!
I think going above 8 might be a bit difficult to use and see, especially for smaller screens though. 🤔

Perhaps it could be dragged onto the end, like the symmetry circle, and then that would move down to make room for it?
I'm not sure, if I come up with something else, I'll let you know!

What about the top of the paddle?

It could be!

Yeah maybe any 'modifiers' like the circle and the chance shape could be placed on the right edge of the paddle 🤔

That's a good idea! Perhaps in stead of the chance shape meaning there's a probability that a rule doesn't happen, perhaps it could give it a weight, kind of like a way of saying "this rule is three times as likely to be chosen if there's more than one outcome"?
 Could this work as an alternative?

I had an idea - what if you can just drag a number onto the edge of a paddle! The number determines the chance of it happening.

You can now drag rectangles onto shapes to set the chance of the paddle happening! This is what the different numbers do:
9 = always
8 = one in 2
7 = one in 4
6 = one in 8
5 = one in 16
4 = one in 32
3 = one in 64
2 = one in 128
1 = one in 256
0 = never


fix: add dev script to enter dev mode in root, and change readme.

Types of changes

[ ] New feature
[x] Bug fix
[ ] Documentation change
[ ] Coding style change
[ ] Refactoring
[ ] Performance improvement
[ ] Test cases
[ ] Continuous integration
[ ] Typescript definition change
[ ] Breaking change

Background and context
The script enter dev mode in readme is not work.
Solution
Add a new script: dev in root package, exec lerna run dev with --parallel.
How is the change tested?

Changelog

Changelog(CN)
Changelog(EN)
Related issues

Checklist:

[ ] Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
[ ] Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to master branch)

Other information

@MisterLuffy cc


Add .NET Core 3.1 Runtime support

.NET Core 3.1 LTS is released, cake should add compiler constants and tests should be adjusted to support this.

Fixed by #2681


Removes the deprecated feature of providing kernel launch params as lists and tuple

[X] Have you provided a meaningful PR description?

The existing numba_dpex.kernel functions can be launched by providing either a Range or NdRange object to numba_dpex.core.kernel_interface.dispatcher.JitKernel.__getitem__, or the global and local sizes as lists or tuples. The use of list and tuples was deprecated a while back. This PR removes the deprecated support and now only Range or NdRange arguments are supported as kernel launch parameters.

[X] Have you added a test, reproducer or referred to an issue with a reproducer?
No, but existing tests have been fixed and updated.
[X] Have you tested your changes locally for CPU and GPU devices?
[X] Have you made sure that new changes do not introduce compiler warnings?
[ ] If this PR is a work in progress, are you filing the PR as a draft?

Fixes #1040

Tested with latest dpbench - works OK.


Improvements to server stop scripts

Interrupt signal doesn't work to stop the servers (at least not on
Amazon Linux.)  Also, improved the selectivity of the stop command
for the Zookeeper stop script, so that it doesn't accidentally
kill the wrong processes.  Finally, modified the Zookeeper stop
script so that it doesn't give a cryptic message in case zookeeper
is not already stopped.

Joshua,
The Kafka team uses review board for patch submissions as explained here https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review. You might want to submit this change as explained in there.

Thanks for letting me know.  That process looks too involved for my minor fixes, but if I make more substantial contributions in the future, I will get myself setup to use the Kafka patch submission process.

This is good.  The original script supplied by Apache was not working on my Redhat Linux 5.x servers, this one does.

@jric Thanks for your contribution. I think this PR is still valid even against trunk (cc @ijuma)? If that is the case could you submit a new PR against trunk and close this one?

Closing this since 0.8.1 is not maintained. Please feel free to reopen against trunk.

Interrupt signal doesn't work to stop the servers (at least not on
Amazon Linux.)  Also, improved the selectivity of the stop command
for the Zookeeper stop script, so that it doesn't accidentally
kill the wrong processes.  Finally, modified the Zookeeper stop
script so that it doesn't give a cryptic message in case zookeeper
is not already stopped.


chainntnfs: increase timeout in unit tests

Fix the unit test flake we've seen recently,
--- FAIL: TestHistoricalConfDetailsTxIndex (0.00s)
    --- FAIL: TestHistoricalConfDetailsTxIndex/rpc_polling_enabled (10.28s)
        bitcoind_test.go:126: unable to establish connection to bitcoind: method did not return within the timeout

I'm not sure if it's actually a question of how long we wait. A lot of tests fail on my local machine because there are port collisions. So I think this will likely be fixed with https://github.com/lightningnetwork/lnd/pull/8273 (which I should look into to fix the new failures that popped up now).

I'm not sure if it's actually a question of how long we wait. A lot of tests fail on my local machine because there are port collisions. So I think this will likely be fixed with #8273 (which I should look into to fix the new failures that popped up now).

yeah i also saw port collision sometimes in lnd, but only during the shutdown process where the rpc port was not cleaned. Have not yet seen such a case in unit test tho.


fix(versions): update Activiti/activiti-cloud-example-chart-modeling versions

UpdateBot pushed helm dependency: activiti-cloud-modeling to: 7.1.53

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-modeling 7.1.53

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-x-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


⚠ Bofrost.be has degraded performance

In 9534268, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2019 ms

Resolved: Bofrost.be performance has improved in 09b58b1 after 13 minutes.


[Feature Request]: Clean GitHub into folder

Contact Details
No response
What do you want improved or added?
I need the GitHub stuff into folders, as we need to clean up everything. A lot of stuff is just crammed up into the GitHub's root, and we need to organize it.
Version
0 (pre-release)
What operating system are you using?
Developer - Universal
What OS version are you using?
iOS 7 and below, iOS 8, iOS 9, iOS 10, iOS 11, iOS 12, iOS 13, iOS 14, iOS 15, iOS 16 (beta), Android KitKat and below, Android Lollipop, Android Marshmallow, Android Nougat, Android Oreo, Android Pie, Android 10 (Android Q), Android 11 (Red Velvet Cake), Android 12 (Snow Cone), Android 13 (Tiramisu), Universal (Chrome), Universal (Safari)
Code of Conduct

[x] #10

We have cleaned and updated the app.


Json reader tests

This PR adds tests for json_reader. Still some work will be needed when more parsing is done, and maybe validations of responses. But this will at least hopefully increase a bit coverage. More important: cases now more thouroughly tested and easier to evolve/maintain!
Resolves #57

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

16 of 16 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 96.761%

Totals

Change from base Build<PHONE_NUMBER>:
0.9%

Covered Lines:
687

Relevant Lines:
710

💛  - Coveralls


The basic functionality of redstone components is broken.

Current Behaviour

Components, like comparitors and repeaters, aren't getting powered directly from powersources (however, they function from dust)

Expected Behaviour

Components getting powered by power sources.

Reproduction Steps

Place a redstone block
Place a comparator or repeater facing out of it
Observe as it isn't powered

Version Information

Minecraft version: 1.19.2
PowerStones version: 3.0.1+1.19
Other mods installed: ferritecore-5.0.3-forge

Hi!
Please forgive me for the (very) late reply.
Thank you for reporting this issue. The bug has been fixed and I will update the mod with the fix, probably by the end of the week.


Failed to enumerate dedicated GPU when default adapter is intergrated GPU

File: DXUTDevice11.cpp, Function: CD3D11Enumeration::Enumerate, Line:154
Always failed to EnumerateOutputs of Dedicated GPU, which makes creation on dedicated gpu not possible,
also, when laptop has both intergrated GPU and dedicated GPU, create a device on dedicated GPU will require back buffer format of "DXGI_FORMAT_R10G10B10A2_UNORM", otherwise SwapChain::Present will break, this should be a default setting when user want to create a dedicated device.
Hope this functionality will be a global setting.
References:
UnrealEngine4, WindowsD3D11Device.cpp
FD3D11DynamicRHIModule::FindAdapter()

Can you please provide more detail here on your repro? What is the feature level of your GPU?
Do you have a specific code fix in mind?
All Direct3D feature level devices are required to support both DXGI_FORMAT_R8G8B8A8_UNORM_SRGB and DXGI_FORMAT_R8G8B8A8_UNORM. Support for HDR formats DXGI_FORMAT_R16G16B16A16_FLOAT and DXGI_FORMAT_R16G16B16A16_FLOAT  require Feature level 10.0 or greater.

Here is my specs:
Windows 10 64bits, Intel Grpahics HD 4600, nvidia 980M
Os is upgrated from Windows 8.1;
On old windows 8.1, everything runs correctly. I can swich device creation on both GPU using 'nvidia contorl panel', or programmingly tells DXGI using a dedicated adapter.
And after upgrading to Windows 10, when i switch on 'using nvidia gpu' in 'nvidia control panel', everything that use DirectX11 will not render at all. Including .net framework,
'Visual Studio Code', and all the sampler code from nvidia/intel/amd developer sites,all the rendering window will be black the whole time.
So I try to use the programming way to find out why, here is what i found out

DXUT cannot find dedicated gpu (on Windows 10), because EnumOutputs failed
Skip that part, and we can create a device on decicated GPU, but, SwapChain::Present will throw a _comptr related error.
Set the back buffer format from rgba8888, or agbr8888, to r10g10b10a2 will finally works, which I looked into UnrealEngine4, they have solved the problem.

And I think this is the wrong place to fire this issue, and I don't quite say this is a bug of DXUT or Windows 10, consider that DirectX12 is more like the first class api
for windows 10.
Still, it will be nice to modify the code to support laptops that runs on Windows 10.
Here is what i have in mind about code fix:

use a better way to EnumOutputs of adapter
use a better way to validate all back buffer formats before set a default( because, yes, you can use rgba8888 in my case,
but SwapChain::Present will throw an exeption, and return a S_OK the same time, which blows my mind )
DXGI is really chaos among all the versions, could be nice to have a abstraction layer on top of that, so we can easily support from windows vista to windows 10.

Basically you are having problems with the NVIDIA "Optimus" technology, which is not part of the OS. First make sure you install the least NVIDIA driver package and report problems to NVIDIA. They manipulate the DXGI adapter enumeration for this, which is the root of your problems.

What "better way" did you have in mind?
The DirectX Runtime is free to use exception handling internally but doesn't leak them. If you are getting S_OK, any exception the debugger caught was already handled. It's an implementation detail, not a bug.
The vast majority of DXUT's adapter enumeration stuff is largely irrelevant for modern platforms. It's a carry-over from the Direct3D 9 days. See DeviceResources for a more modern way to do it that is simple.

I didn't explain clearly enough.
Yes, I know this is maybe an issue of NVIDIA Optimus, and yes, I figure out how to create an directx 11 device on dedicated GPU using DXUT.
But, DXUT is the most standard code base of directx 11 samplers, and maybe the the most imporatant one( intel/amd/nvidia samplers are all based on top of it ), the purpose of DXUT is to illustrate how to use DirectX 11 in a real world application. There are a lot of customers who has Alienware laptops and upgrated their OS from Windows 8.1, and they will meet the same problem, and some of them already tried to install the latest drivers and failed to run directx 11 applications( http://forum.notebookreview.com/threads/windows-10-and-nvidia-980m-gtx-upgrades-for-alienware-m17x-r4-without-optimus-working-great.777145/ )
As developers, we cannot throw the problem to the users, expect them geek enough to know how to disable intergrated gpu in the BIOS.
Here is what i thought, not only just about DXUT.

What if dxgi_adapter EnumOutputs and dxdiag(32bits or 64bits ) both failed to find outputs of dedicated GPU, and the driver informations ( which is my case, and all the alienware guys ) ? Can the applicaton provide more detailes to programmers, or to users?
What if a back buffer format that should always be valid, but acturally failed to present, how can the application knows about the detailes
I'm temporarily fixing the problem as I mensioned, "Skip EnumOutputs failed, Skip default back format validation, using r10g10b10a2", so the players of our game will be able to use dedicated GPU on Windows 10, without knowing anything to hack into BIOS.

And thanks for the link of DeviceResource, I will check that out later.

if an application can't find a specific output, just use the default adapter. There's no other logical option.

Invalid backbuffers formats will fail to create. Direct3D Hardware Feature Levels spell out what you as the developer need to design to. I don't know that you mean by "fails to present". Is the monitor out of sync? are you talking about full-screen mode?

r10g10b10a2 can only be counted on if you require a minimum of Feature Level 10.0 or higher.

All that said, using DXUT as the basis of a production game engine is not recommended. It's designed for samples and prototypes.


changefeed(ticdc): fix memory quota incompatible from 6.5.0

What problem does this PR solve?

Issue Number: close #8007
What is changed and how it works?

Auto fix memory-quota if it is zero in changefeed info from etcd.
Auto fix memory-quota if it is zero when creating a new changefeed.

Check List
Tests

Unit test
Integration test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Fix memory-quota is set to zero unexpectedly which will cause replication stuck.

/run-all-tests

/run-dm-integration-test

/merge

/run-verify

/run-verify

/run-dm-integration-test

/run-dm-integration-test


Add snapshots-annotations and a new IgnoreEmergeSnapshot annotation which will ignore generating a snapshot test for a given preview

Current dependencies on/for this PR:

main

PR #46   👈

This comment was auto-generated by Graphite.


How to use  Universal Dependencies style ?

I load model from local path,:
from wtpsplit import WtP
wtp = WtP("/data/share/HuggingFace/custom/benjamin/wtp-bert-mini/")

wtp.split("This is a test This is another test.", lang_code="en", style="ud")

it returns :
ValueError: This model does not have any associated mixtures. Maybe they are missing from the model directory?
where can I download associated mixtures?

Hi, downloading this file: https://huggingface.co/benjamin/wtp-bert-mini/blob/main/mixtures.skops to the model directory should to the trick.

hi @bminixhofer , it doesn't work.
I download the model using git:
git lfs clone https://huggingface.co/benjamin/wtp-bert-mini
WARNING: 'git lfs clone' is deprecated and will not be updated
          with new flags from 'git clone'

'git clone' has been updated in upstream Git to have comparable
speeds to 'git lfs clone'.
Cloning into 'wtp-bert-mini'...
remote: Enumerating objects: 29, done.
remote: Counting objects: 100% (6/6), done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 29 (delta 1), reused 0 (delta 0), pack-reused 23
Unpacking objects: 100% (29/29), 5.08 KiB | 400.00 KiB/s, done.
Downloading LFS objects: 100% (3/3), 47 MB | 7.2 MB/s

ll wtp-bert-mini/
total 45696
drwxrwxr-x  3 lixing lixing     4096 Oct 18 09:21 ./
drwxr-xr-x 13 lixing   4000     4096 Oct 18 09:21 ../
-rw-rw-r--  1 lixing lixing 29577694 Oct 18 09:21 pytorch_model.bin
drwxrwxr-x  9 lixing lixing     4096 Oct 18 09:21 .git/
-rw-rw-r--  1 lixing lixing     1528 Oct 18 09:21 .gitattributes
-rw-rw-r--  1 lixing lixing     6139 Oct 18 09:21 config.json
-rw-rw-r--  1 lixing lixing      549 Oct 18 09:21 README.md
-rw-rw-r--  1 lixing lixing 14800980 Oct 18 09:21 model.onnx
-rw-rw-r--  1 lixing lixing  2377183 Oct 18 09:21 mixtures.skops

mixtures.skops this file is downloaded.
then loading model from local path:
from wtpsplit import WtP
wtp = WtP("/home/lixing/wtp-bert-mini/")
wtp.split("This is a test This is another test.", lang_code="en", style="ud")

it failed.

Hi, sorry, this should be fixed in version 1.2.4, see #110.


Added macOS shortcut documentation

As promised the documentation for macOS shortcut.
For some reason the images aren't appearing... I added two images in ../images/, where ../ is the relative path to the usage folder.
Could you please fix this or move the images to where they should be at?
I also tried to create an usage_images folder under usage, but that also didn't work.

Maybe we add a link for users that are looking at https://docs.freetubeapp.io/usage/browser-extension/ to this new page so they dont miss out on this info


Make timeouts configurable

Hi @brillout
This is a PR to make timeouts configurable to resolve #1250
Please take a look and review this PR.

Yes! This goes in the right direction. Very cool.
Btw. I tried to find you Discord but couldn't: did you join Vike's Discord? (Feel free to PM over there.)

Well, very glad to hear that, thanks
my discord .muhammad19

I'll push more commit in a moment

Hi @brillout
I've added configTimeouts as a return value from getHook(), and I have refactor executeHook() to accept configTimeouts. I think this way is shorter.
What do you think about this?

Good idea, I like it 👍

Nice, I'll continue applying it inside runPrerender.ts,
If I'am not mistaken, the callOnBeforePrerenderStart doesn't call executeHook (or not for itself), You know what I mean right? But onPrerenderStart does
Is there are anything that I need to consider here?
And what about executeOnBeforeRouteHook, it has its own executeHook. Should we able or need to configure timeouts here ?

That will be it for now, the rest is onBeforeRoute and onBeforePrerenderStart hooks.
What/How are we gonna do about them?
FYI sorry if commits seem many lines changed, I think its because "Format Document" in vscode, I hope it's oke

Applied configure timeouts to executeHook() at callOnPrerenderStart() hook

👍

That will be it for now, the rest is onBeforeRoute and onBeforePrerenderStart hooks.
What/How are we gonna do about them?

I believe we should always use executeHook() and for every hook.

FYI sorry if commits seem many lines changed, I think its because "Format Document" in vscode, I hope it's oke

You can use prettier to align with the Vike team. It's important to not pollute $ git diff.

Can you run prettier?

Done.

I like the idea of having getHook() return the timeouts, but it's a bit sad that it returns the timeouts of all hooks while exectueHook() has to retrieve the timeout of the hook.
I wonder if the following would be possible:

getHook() returns the hook's timeout (pageContext.config.timeouts[hookName]) instead of all timeouts (pageContext.config.timeouts).
Change the arguments of executeHook() into:  function executeHook<T = unknown>(
-   hookFn: () => T,
+   hookFnCaller: () => T, // clearer name
-   hookName: HookName,
-   hookFilePath: string,
-   configTimeouts?: ConfigTimeout
+   hook: Omit<Hook, 'hookFn'> // Hook is the same type as `getHook(): Hook`
  ): Promise<T> {

  type Hook = {
-   configTimeouts: ...
+   hookTimeout: ...
  }

I think that would be quite neat, but let me know if you believe I'm missing something.
Otherwise, the PR looks good overall :ok_hand:

With overall, I mean on a high-level; I'm sure I'll find some more unsatisfacting things once I go down on the middle and low level 😉

💯

Will do 👍

LGTM 💯
I did some minor-ish changes as well as some polishing, see $ git log:

minor refactor => functionally equivalent (mostly boring stuff and you can skip these / quickly go over them).
Otherwise see (somtimes insightful) commit message.

Let me know if you agree with my changes and I'll then merge 🌟

I don't believe you 🤣 Sorry 🙏

Looks like you should have 🙂

LGTM 💯, very impressive @brillout, as always
Ready to merge 🥳

mostly boring stuff and you can skip these / quickly go over them

No, it's not boring, I've looked at them all, I'm impressed

Otherwise see (sometimes insightful) commit message.

Yes, indeed. Make me understand more and more, even with all minor refactor
Lastly, since we don't yet use config hook timeout for onPrerenderStart, I've included onPrerenderStart in default hook timeout with longer time same as onBeforePrerender. Free to disagree
That's all from me, I've learned a lot. Thank you very much for this PR, allowing me to make a lot of commits and of course your amazing improvements. I'm sorry couldn't do better

I'm super looking forward to eventually have a rock-solid core

Yeah, me too.

Looking forward to more PRs if you want 🚀

I'll try👌

I made some more changes,

Yeah, I did notice that 👍

Up for a docs PR defining https://vike.dev/hooksTimeout?

I'm sorry, I'm not sure yet. 🙏

👍I can write the docs after we release the V1 design, i.e. next week.

Done: https://github.com/vikejs/vike/commit/771b7553314d00dc6a76e64d4591cc53f0266e3f.


Revert "Fix focusWindow parameter name"

This reverts commit 8bc94c291838d6d4152138cf4ab94d1db6f8da7e.
when we merged your changes into our fork this broke calls of focusWindow
the docs say it should be "name" as it originally was
https://www.selenium.dev/documentation/legacy/json_wire_protocol/#sessionsessionidwindow
note in w3c it is changed to handle, but this package doesn't get anywhere near w3c support

Hey, could I trouble you to re-open this issue at the package's new home at https://github.com/haskell-webdriver/haskell-webdriver ?

https://github.com/haskell-webdriver/haskell-webdriver/pull/191


view of hambarger menu

look need to be changed

/assign

plzz check if you like this look do tell me

plzz check @nilisha-jais


Easier Data Access

Implemented the key => value pair functionality to make the library more stimulating for use. I also modified the documentation to reflect the changes made.
Before

After

I'd also appreciate if you could look at the code and suggest improvements/corrections.
Thanks @unicodeveloper!

These comments are golden! I'll refactor and push updates.
Forgot to mention that I noticed 'Issue' was misspelt as 'Isssue' lsmvaapvs  so I changed it to 'Issue' at our end. What do you think about this?
Also, I'm sorry about the naming conflicts. I'm very poor at naming things.
Thanks a lot!

@unicodeveloper I have made modifications as suggested. Kindly review.


Issue renaming an existing table in table designer

Currently if we rename a table in table designer, it creates a new table instead of renaming the current existing one, we need to actually rename the table using sp_rename

@erinstellato-ms @tdoshin FYI, we are creating more work for ourselves :). I think the task makes sense and is a better experience than the current behavior (ADS and SSDT behaves the same way). Please let us know if you have different opinions.

@alanrenmsft can you clarify what you mean by "the task makes sense and is a better experience than the current behavior"?  You agree that renaming the table should create a new table?  Or do you think it should NOT do that?

@erinstellato-ms :) I think creating a new table is not a good experience. I would it to rename the existing table.

@alanrenmsft oh perfect!  Creating a new table is definitely not a good experience!  Yes, we just need to rename the table.

the fixes were brought in to ADS by https://github.com/microsoft/azuredatastudio/pull/20538

This issue has not been fixed and I'll work on it next.


Set a default group

Hey i am really having trouble with setting a default group could you please help me.

A default group is automatically given which isn't changeable. There are three ways this can be dealt with:

Use the default group given and just assign it a prefix.
Use group-rewrite which is found in the luckperms config.
Use default assignments which can be found at the bottom of this wiki page and needs to be edited in the luckperms config. https://github.com/lucko/LuckPerms/wiki/Default-Groups this will make it so when a user enters the default group, you can automatically move them to the group you wish.


Not able to make new fields, change fields, and table collapses when editing a field title.

What happened?
There are no buttons (+) to add a column in order to make one. The only way I've seen that semi works is the YAML data on the note itself, which isn't even fully working because it only creates text fields regardless of what I put. Url or status, etc.
Then I am not able to change the column either as "changing type isn't supported yet".
What did you expect to happen?
Well I am spoiled from notion's fluidity, but I expected to be able to make new fields easily, and that would edit the note as well. I did not choose "dataview" option either, just the tags option, but I think I've tried the folder one too.
This is I think the fifth time I've tried this plugin this week.
How can we reproduce it (as minimally and precisely as possible)?
The table collapse is the only thing you'll need to reproduce, and that was simply editing the title for the column field.
Anything else we need to know?
Feel free to reach out.
Plugin version
1.15.3
Obsidian version
1.2.8
OS
Windows

I recorded the field creation process to reproduce this in following steps:

In a new note in the target folder, add new YAML field
Check Projects, the new filed is recognized as Text
Put a valid date value to the field, right in the note (notice that the cursor is at the end of the line)
Reopen Projects, and the new field is still detected as Text
In the note, move the cursor elsewhere, and the Date type is assigned finally

https://github.com/marcusolsson/obsidian-projects/assets/73122375/15d824df-e972-4403-a602-cede90e99b18
Seems like reopen the Project view would solve the problem.
The misidentification of the field type when the cursor at the end is likely a bug, and add field in the Table view may be a separated feature request.

That still doesn't help the tags or status tag cause they aren't changing to tags. Also I've been trying the reopening project view. that helped with the columns appearing, but it didn't with the changes. It did however in my testing just now (not the other day) with the date. That worked this time.
Also there was a crucial missed point from my issue. The bug that I was sharing. I tried to take a screen vid but OBS was crashing for some reason. Basically I'd try to change the width or click on the top and it would collapse all the way to just the first column.
No idea why.

I also thought that the issue with the table not being able to change the type was because of dataview, and so if using yaml on its own would solve that, but I guess not?

Hey this is still an issue. Your responses didn't solve the problem. The collapses have decreased in frequency at least, but the issue of column types persists. Regardless of what I put in the metadata it just always defaults to text, and it won't change. In the metadata of the doc or in the projects view if I try to change something. Still says "changing type is not supported" yet I never was able to declare the type. Projects just treats it as a text, even dates if they are more than the word "date" (which I have a "Do date" and "published date")

Sorry for my postponed reply and for some possible misunderstanding (as I'm not a native English speaker). So I would make some clarification, as well as require more info.
Seems like you are using Tag as your data source, and that's how it works:

Include notes that contain the certain tag you typed in the Edit project modal.
Generate table and other views according to the YAML metadata of the note.

Field types are auto-detected according to your YAML. If all the values of a field, let's say, 'pub date', are in the format of YYYY-MM-DD (only the format is supported now, #309 FYI), then the field will be recognized as date type. As mentioned above, the cursor at the end of the line should be avoided, and sometimes reopening the Projects tab is helpful. There's nothing related to the field name.
I suggest you test the Tag data source with the notes provided in the demo project, which shows when you first install the Projects plugin. You can create a new vault to test it. The tags in the YAML are also supported. Create a new project using the Tag data source, and observe if the date field is correctly detected and rendered.

Regardless of what I put in the metadata it just always defaults to text, and it won't change. In the metadata of the doc or in the projects view if I try to change something. Still says "changing type is not supported" yet I never was able to declare the type. Projects just treats it as a text, even dates if they are more than the word "date" (which I have a "Do date" and "published date")

About the typecasting, I would say this is 'as design', and isn't supported yet, you can check #558 to get more info.

The table collapse is the only thing you'll need to reproduce, and that was simply editing the title for the column field.

Also there was a crucial missed point from my issue. The bug that I was sharing. I tried to take a screen vid but OBS was crashing for some reason. Basically I'd try to change the width or click on the top and it would collapse all the way to just the first column.

I just can't reproduce it, maybe I need more detail. What does it look like after the table collapse? (Seems like only the first column survives, the name column right?) And about editing the column field, do you mean that you are changing the column name in the Configure field modal? But I observed nothing wrong when changing the names. Notice that the name and path shouldn't be modified.
The table collapse sounds like a severe bug, and I'd like to figure it out, with your help to reproduce it.
Hope this would help you. Further discussion on this is welcome.

Oh, got it. It's sorry that for now, only when you get all the values that belong to the same field name correclty typed, can the field be detected as date. It's a hard work if you have so many notes migrate from notion. More date formats support is scheduled, so if you don't want to change the date formats manually, you can wait for the impliment. (may take several months)

It also doesn't explain why tags, status, or links are not showing up correctly.

Tags need to be formatted in the YAML too.

To enable link rendering, you can enable rich-text formatting in text fields' configure field modals.

What are you refer to when talking about status? Maybe some notion examples are enough.

I tried making sure the dates are formatted correcting, I still don't know why it isn't working. Ironically I made a typo in one field that I added today. Published Date instead of Publish Date, and it formatted to date property correctly.
I get that this plugin is still new in the grand scheme of things, and there is a lot to do/going on. Although some of these thing are basic use cases or issues, that other people have had too from what I've seen from the forums.

Would you mind checking the notes details in the .md file, rather than only in the table view? There's a guess that, in some of your notes, if you have an empty value of a potential date field (but in text field temporarily), and you edited it manually in the table view, the value would be quoted, yielding someting like Do date: ""
To modify this, you may use tools like VSCode, or other text editors that supports find and replace, to remove the whole line containing quotation marks. (Including the field name, to avoid generate quotation marks again). Another solution is, since the quoted date field value can also be detected, i.e. Do date: "2023-05-31", so filling all empty cells in the table view can also fix this.
This is indeed a bug that the quoting criteria are some times disturbs editing, especially migration from other note-taking applications, and the type system do need to be imporved (#76 )

Tags should be formatted correctly, and I'll see if the rich text switch will fix links. Thanks.
as for dates that really sucks, that ALL of them have to be correct. It is probably around 1000 published content pieces, and close to that number for content ideas. I actually have to go through all of them and tag them anyways for Obsidian's graphing
Alright let's table this issue for now.


zplug 'zplug/zplug', hook-build:'zplug update --self' always fails on a fresh install

Problem Summary
The readme contains information about how to manage zplug with zplug. I've long had this line in my zplug configuration to always get the self-update feature enabled:
zplug 'zplug/zplug', hook-build:'zplug update --self'

Even after successfully installing zplug with the above config, when I run zplug update --self it

always exits unclean (1)
does not do the symlinking as it did before and also as it is documented

agross@AXL /scratch
$ zplug update --self
[zplug] up-to-date (v2.2.0) e27dd9ee

agross@AXL /scratch
$ echo $?
1

agross@AXL /scratch
$ ls -la $ZPLUG_HOME/init.zsh
-rwxr-xr-x 1 agross None 700 Aug 28 00:14 /home/agross/.cache/zplug/init.zsh

agross@AXL /scratch
$ file $ZPLUG_HOME/init.zsh
/home/agross/.cache/zplug/init.zsh: a /usr/bin/env zsh script, ASCII text executabl

System Information

uname -a

CYGWIN_NT-10.0 FOOBAR 2.5.2(0.297/5/3) 2016-06-23 14:29 x86_64 Cygwin
```

zsh version

5.1.1
```

zplug version/commit

e27dd9ee2aa7397a366be656fef40338d1d66cd6
```
Minimal zshrc
source ~/.zplug/init.zsh

zplug 'zplug/zplug', hook-build:'zplug update --self'

# Install plugins if there are plugins that have not been installed
if ! zplug check --verbose; then
    printf "Install? [y/N]: "
    if read -q; then
        echo; zplug install
    fi
fi

zplug load --verbose

Steps to Reproduce
Shell output:
- zplug/zplug: not installed
Install? [y/N]: y
Installing...        zplug/zplug
Installed!           zplug/zplug        (7.91s)
[zplug] ERROR: 'zplug update --self' failed
 ==> Installation finished successfully!
[zplug] |install| total wall-time 15.655195 sec.

Thanks for reporting. Please try fix-244 branch.

Seems like the fix just cds into the zplug repo:
[agross@fedora-test]~% zplug update --self
<EMAIL_ADDRESS>echo $?
1
<EMAIL_ADDRESS>git rev-parse HEAD
9d3e07f9eb37c5159b98d2a98a2c3e5a70742120
<EMAIL_ADDRESS>cd ../../..
<EMAIL_ADDRESS>git rev-parse HEAD
9d3e07f9eb37c5159b98d2a98a2c3e5a70742120
<EMAIL_ADDRESS>

I can't reproduce your terminal

In order to test fix-244 I changed my .zshrc as follows:
zplug 'zplug/zplug', at:fix-224, hook-build:'zplug update --self'

Note that I mistyped at:fix-224 and not at:fix-244. Sorry about that!
With this issue out of the way I get a successful install, but init.zsh is no longer symlinked as it was with 2.1.0 (and as the README states it would):
- zplug/zplug: not installed
Install? [y/N]: y
Installing...        zplug/zplug
Installed!           zplug/zplug        (11.36s)
[zplug] ERROR: 'zplug update --self' failed
 ==> Installation finished successfully!
[zplug] |install| total wall-time 15.997085 sec.
  Loaded zplug/zplug/init.zsh
[agross@fedora-test]~% ls .cache/zplug/init.zsh -la
-rw-rw-r--. 1 agross agross 700 Aug 30 21:54 .cache/zplug/init.zsh

:shipit:

Please try the latest fix-244 branch. It should fix both problems regarding zplug update --self failing and init.zsh not symlinked.

In addition, your reload will be failed like the following:
[vagrant@localhost]~% zsh
- zplug/zplug: not installed
Install? [y/N]: y
Installing...        zplug/zplug
Installed!           zplug/zplug        (5.77s)
[zplug] ERROR: 'zplug update --self' failed
 ==> Installation finished successfully!
[zplug] |install| total wall-time 8.301470 sec.

However, unfortunately this behavior is by design in the present circumstances because zplug returns status code 4 ($_ZPLUG_STATUS_REPO_UP_TO_DATE) if the repo is up-to-date.

If you don't want display 'failed' word, you should remove that tag for the present.

I have changed the zplug line to this:
zplug 'zplug/zplug', at:fix-244, hook-build:'zplug update --self'

...and also reset my zplug in ~/.zplug clone to fix-244.
Still no symlink, but the zplug repo isn't downloaded as well:
Static loading...
$ zplug list
zplug/zplug  =>  as:"itself", at:"fix-244", hook-build:"zplug update --self"
$ zplug update --self
$  echo $?
0
$ ls -la ~/.zplug/init.zsh
-rwxr-xr-x 1 agross None 700 Sep 15 16:37 /home/agross/.zplug/init.zsh

Yes, init.zsh file doesn't symlink even if you run this command zplug 'zplug/zplug', at:fix-244, hook-build:'zplug update --self'. init.zsh is linked to $ZPLUG_HOME/init.zsh when running zplug load see also https://github.com/zplug/zplug/blob/fadc9b180df2699088b93ff23afe5d203e3f4c5a/base/core/self.zsh#L55-L58
It's a specification. If you don't like it, please send us a pull request.

I'm confused.
The readme says:

By using the --self option, zplug will be cloned to $ZPLUG_HOME/repos and create a symlink to $ZPLUG_HOME/zplug.

You wrote that

init.zsh is linked to $ZPLUG_HOME/init.zsh

but there isn't a symlink created.
So what the it specification part?

The readme which states there should be a symlink
Your last comment which states there is a symlink

...while there isn't a symlink created.
It's not me not liking something. There are two statements that seem to contradict each other. zplug used to do a third thing before 2.1 (?) by creating a symlink to repos/zplug/zplug/init.zsh. Please help me clear up the confusion. A first step might be to remove the outdated statement from the readme. Do you agree?

Okay, thanks. Please let me tidy. I'll converge this issue definitely.


User can select airport by city

User can select airport by city
AB#5

No more feature for this sprint
Close the issue


Fix Failed JSON stringify with NaN

http://www.ecma-international.org/ecma-262/5.1/#sec-15.12.3
Depending to Note4, NaN is reprensented as the String null
#741
JerryScript-DCO-1.0-Signed-off-by: pius.lee<EMAIL_ADDRESS>

Please add regression test to this PR.

And fix precommit ^^

LTGM

LGTM

Merged (7868b0ae685eb67a4ce478dc9e6fd2b4c3ebb0ad)


PDF previews broken by unknown flags

Hi, great program. Really easily makes lf into the best terminal file manager.
PDF image previews aren't working for me due to pdftoppm complaining about flags. I was able to fix it in my case by removing "-tiffcompression jpeg" from "ctvp/sh/prev/pdf.sh".
I'm building it from source on gentoo linux. Anyway, thought I would let you know. Godspeed Ivanov.

Thanks! Removed the flag.


Prefill form before validate

Hi. I have a Reform form for the User model and the next business logic: application user write first_name and last_name to the view form, and when it is saved, these data should be united and saved to the full_name column.  Is there any before callbacks or something similar in the Reform ?
class CreateForm < Reform::Form
   property :first_name
   property :last_name

   # How to call setup_full_name before validations ???

   validate :uniqueness

   def setup_full_name
      model.full_name = [first_name, last_name].join(', ')
   end

   def uniqueness
      errors.add(:base, 'Taken') if User.where(full_name: model.full_name).exists?
   end
end

Have you seen this? trailblazer.to/gems/reform/prepopulator.html

@apotonick  Yes, but I do not really understand how to use prepopulator

Have you had a peek into the Trailblazer book? We explain prepopulators there in great detail. Come here: https://gitter.im/trailblazer/chat

@apotonick no, I have not get a copy of the book.
I found that I can use populator option like that:
   property :last_name, populator: -> (options) do
       self.last_name = options[:fragment]
       model.full_name = [first_name, last_name].join(', ')
   end

But it seems to bit a little tricky to me, what do you think?

@nibygro You should be using prepopulators.  Yes, you have to call prepopulate! manually (probably in your controller, after creating the Reform instance)

It's not correct,  you need to use :prepopulator - see above!

@apotonick As far as I understand, isn't prepopulator for rendering the form? The title of the issue is worded a little confusingly - he's not trying to "Prefill the form", but more like trying to use what in ActiveModel would be a before_validate to change data after it comes from the form - sounds like what populate does? I'm just learning reform now so I may be wrong.

Ok, then a populator is correct, but not the way @nibygro does it. The populator should never access the model. I would do that kind of mapping in the surrounding Operation. Note that Reform is not a data mapper. I was thinking of providing such behavior in a less clumsy way, though.

@nibygro if I understand you correctly you capture & validate first and last name then if valid persist the two fields as one column.
If that's the case, why don't you make a method to join the two and call it after validation but before sync/save ?

@nibygro @fran-worley As far as I can tell, that does seem like the correct method. 👍  reform is not designed for writing your attributes for you (other than the simple attribute assignment onsync/save that is really just a convenience)

Yes, Reform is a form object and not a data mapper, and that's a good thing.
The sync/save is absolutely not convenience, though, but highly necessary to get the validated data back to your model(s). :grimacing:  BTW, if you're interested in the data mapping part, you should look into twins because they are data mappers (and Reform is based on twins)!!!


Start of porting mathsteps to use math-rules

This PR disables almost all of the existing tests except for the ones that are currently passing after being ported.  Note that the tests themselves have not been changed.
The plan build upon this foundation with a series of small PRs to port each of the various search commands and then eventually update the simplifyExpression and solveEquation.

Thanks for the comments! I will look over this PR soon.

Great! This PR looks good to merge. Thanks for leading the way Kevin!

Great! This PR looks good to merge. Thanks for leading the way Kevin!

Please don't merge it yet.  There's still some unresolved issues that I'd like to take care of first.

I wasn't going to haha, sorry if I was a bit rushed in saying that.

Sorry for make this diff so big.  I want to make sure simplifyExpression was working for at least a couple of situations.  I wanted to minimize the changes to simplify.js and stepThrough.js so I ended up having to update removeUnnecessaryParens and flattenOperands while making sure their tests pass.

All good. I'll take a look at this PR tomorrow at work!

There are 40 passing tests and 462 pending.

You may find reviewing each commit easier since they're more self contained.

Kevin, can you fix the linter issue? Then I can merge the PR and start porting other rules.

would it be okay for me to check out this PR before merging? I could probably look tomorrow
or since it's still on a feature branch I could just look after merging if you want to get started on stuff soon

sorry I've been so inactive - I've been wanting to check this out for a while! :)
finally figured out my internship plans for next term and have a bit more time now

I think the reason why the pre-commit hook for lint isn't working is that it makes some assumptions that aren't always true:
"setup-hooks": "ln -s ../../scripts/git-hooks/pre-commit.sh .git/hooks/pre-commit"

I've been quite pleased with https://www.npmjs.com/package/pre-commit.  Maybe we can use it here as well.

wow kevin this is amazing I'm so excited
thanks for all the work you've been putting into this!!
I gotta do some other things before I sleep, but I'll try to reply to your stuff tomorrow or latest the weekend. Excited to be thinking about these things again!

Eek... I guess I'll work all the feedback into a followup PR.

yeah sorry I would have preferred this stay open too, but it was hard for Anthony to work off of your stuff because it was in another fork (maybe we can make you a contributor, or there's some other better solution, idk)

we could also reopen this PR, revert the change, and anthony can rebase later :p

we could also reopen this PR, revert the change, and anthony can rebase later :p

I don't want to hold things up.  Maybe @aliang8 could do some of changes we've identified as wanting to make.

Yup, of course. I'll make the changes Evy requested.


ppc32: index.hpp: error: integer constant is too large for ‘unsigned long’ type

With gcc-4.2 the build errs out if tests are turned on (without tests it builds fine):
In file included from /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_math_zfp/zfp/work/zfp-1.0.0/include/zfp/array1.hpp:8,
                 from /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_math_zfp/zfp/work/zfp-1.0.0/tests/testzfp.cpp:14:
/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_math_zfp/zfp/work/zfp-1.0.0/include/zfp/index.hpp:496: error: integer constant is too large for ‘unsigned long’ type

(Example is with v. 1.0.0, but same error with master.)
With gcc-11 build completes, though with overflow warnings:
In file included from /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_math_zfp/zfp/work/zfp-f15d00720e454cd70206a85d7013d8240ad38585/include/zfp/array2.hpp:8,
                 from /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_math_zfp/zfp/work/zfp-f15d00720e454cd70206a85d7013d8240ad38585/tests/testviews.cpp:5:
/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_math_zfp/zfp/work/zfp-f15d00720e454cd70206a85d7013d8240ad38585/include/zfp/index.hpp: In member function 'void zfp::index::hybrid4::set_block_size(size_t, size_t)':
/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_math_zfp/zfp/work/zfp-f15d00720e454cd70206a85d7013d8240ad38585/include/zfp/index.hpp:269:15: warning: right shift count >= width of type [-Wshift-count-overflow]
  269 |       if (ptr >> (32 + shift))
      |           ~~~~^~~~~~~~~~~~~~~
/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_math_zfp/zfp/work/zfp-f15d00720e454cd70206a85d7013d8240ad38585/include/zfp/index.hpp: In static member function 'static uint64 zfp::index::hybrid8<dims>::lsum(uint64)':
/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_math_zfp/zfp/work/zfp-f15d00720e454cd70206a85d7013d8240ad38585/include/zfp/index.hpp:500:12: warning: right shift count >= width of type [-Wshift-count-overflow]
  500 |     x += x >> 32;
      |          ~~^~~~~
[ 95%] Linking C executable ../bin/zfp
cd /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_math_zfp/zfp/work/build/utils && /opt/local/bin/cmake -E cmake_link_script CMakeFiles/zfpcmd.dir/link.txt --verbose=ON
In file included from /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_math_zfp/zfp/work/zfp-f15d00720e454cd70206a85d7013d8240ad38585/include/zfp/array1.hpp:8,
                 from /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_math_zfp/zfp/work/zfp-f15d00720e454cd70206a85d7013d8240ad38585/tests/testzfp.cpp:14:
/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_math_zfp/zfp/work/zfp-f15d00720e454cd70206a85d7013d8240ad38585/include/zfp/index.hpp: In member function 'void zfp::index::hybrid4::set_block_size(size_t, size_t)':
/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_math_zfp/zfp/work/zfp-f15d00720e454cd70206a85d7013d8240ad38585/include/zfp/index.hpp:269:15: warning: right shift count >= width of type [-Wshift-count-overflow]
  269 |       if (ptr >> (32 + shift))
      |           ~~~~^~~~~~~~~~~~~~~
/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_math_zfp/zfp/work/zfp-f15d00720e454cd70206a85d7013d8240ad38585/include/zfp/index.hpp: In static member function 'static uint64 zfp::index::hybrid8<dims>::lsum(uint64)':
/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_math_zfp/zfp/work/zfp-f15d00720e454cd70206a85d7013d8240ad38585/include/zfp/index.hpp:500:12: warning: right shift count >= width of type [-Wshift-count-overflow]
  500 |     x += x >> 32;
      |          ~~^~~~~

However, tests fail (tbh they don’t look bad to me, perhaps threshold of precision for 32-bit should be adjusted?):
zfp_ppc32_gcc11.log

It appears that you're compiling zfp in C89 mode but the compiler presumably uses the LLP64 data model, which zfp is not detecting correctly (testzfp reports "data model unknown").  One thing to try is to add the following to the CMake line:
-DZFP_INT64='long long' -DZFP_INT64_SUFFIX=ll -DZFP_UINT64='unsigned long long' -DZFP_UINT64_SUFFIX=ull

If instead you're compiling with GNU Make, then try the following
make DEFS="-DZFP_INT64='long long' -DZFP_INT64_SUFFIX=ll -DZFP_UINT64='unsigned long long' -DZFP_UINT64_SUFFIX=ull"

@lindstro Let me try, thank you!


2021.01.16 Release

BREAKING CHANGES - Python 3.6 Support Depcrecated

Due to an inherit pandas dependency, python 3.6 support has been deprecated.

Version bumps

pandas 1.1.5 to 1.2.0
nox 2020.8.22 to 2020.12.31

Test Coverage Optimisations

Ignore codecov analysis on motherstarter setup.py and noxfile.py files

Approved

Approved


Adding chapter title in the header or footer

Is it possible to add chapter title in the header (preferably instead of the date)?

I found the answer in the examples (header-and-footer):
header-right: "\\leftmark"


Rename OpenTF to OpenTofu in the whole Repo (wherever applicable)

Rename OpenTF to OpenTofu in the whole Repo (wherever applicable)

@omry-hay @coryodaniel let me know if it makes sense, I will send out a PR with the changes.

I submitted PR #1077 sometime back. It could be incomplete since I changed the README file alone.


Performance headache

This excerpt from stackoverflow
**
"When you make requests with "Connection: keep-alive" the subsequent request to the server will use the same TCP connection. This is called HTTP persistent connection. This helps in reduction CPU load on server side and improves latency/response time.
If a request is made with "Connection: close" this indicates that once the request has been made the server needs to close the connection. And so for each request a new TCP connection will be established.
By default HTTP 1.1 client/server uses keep-alive where as HTTP 1.0 client/server dont support keep-alive by default."
**
From your code, I understand that you force to browser to close the connection immediately.
private static void WriteConnectResponse(StreamWriter clientStreamWriter, string httpVersion)   {             clientStreamWriter.WriteLine(httpVersion + " 200 Connection established");             clientStreamWriter.WriteLine("Timestamp: {0}", DateTime.Now);             clientStreamWriter.WriteLine("connection:close");// <-- This line force the browser disconnect.             clientStreamWriter.WriteLine();             clientStreamWriter.Flush();    }
And establishing a secure connection takes too long time.
With this current version, although it runs almost perfect but the performance is really headache.
Is it because of not supporting the persistent connection or not as I am thinking or anything else?
Please reconsider the design issue of this wonderful work.
Lastly, anyhow many thanks for your effort and sharing it to community.

I am aware of random performance degradation but couldn't point at anything specific. I am looking at this.

I am interested in a  site named like "www.mysite.com". So I made very small changes  to HandleClient(TcpClient client) function in RequestHandler.cs as follows
if (httpVerb.ToUpper() == "CONNECT" && httpRemoteUri.Host == "www.mysite.com" && httpRemoteUri.Port == 443)
{
  //this portion of the function seems to be working fairly fast enough
  //I think, since we make authentication by ourselves, connection is faster
}
 else if (httpVerb.ToUpper() == "CONNECT")
 {
     //remote hosts that we are  not interested just will be tunneled (like in by pass proxies)

   //this portion of the function causes long latency for establishing a secure connection.
 }

I hope this may give you a clue about performance enhancement.

I think the issue is with HttpWebRequest throttling traffic, which we have no idea how to optimize. I got rid of it in my breaking-change branch.
It haven't implemented connection cache yet, so it may not be super fast yet. But you may want to check out.

Performance has been improved in release branch.
Just released beta.
Install-Package Titanium.Web.Proxy -Pre

I tried  breaking-change branch.
This is my OnResponse routine
public void OnResponse(object sender, SessionEventArgs e)
{
   if (!e.ProxySession.Request.RequestHostname.Equals("medeczane.sgk.gov.tr")) return;
   if (e.RequestMethod == "GET" || e.RequestMethod == "POST")
   {
        if (e.ProxySession.Response.ResponseStatusCode == ((int) HttpStatusCode.OK)).ToString())
        {
            if (e.ProxySession.Response.ResponseContentType.Trim().ToLower().Contains("text/html"))
            {
                 string body = e.GetResponseBodyAsString(); //This line crashes
             }
          }
     }
}

e.GetResponseBodyAsString() crashes in
public static byte[] DecompressGzip(Stream input) function.
That is the only modification I made to your test proxy.
GetRequestBodyAsString() could have the same problem.
Besides, for performance degradation, by pass proxy mode also should be considered.
Please observe that if the website is in excluded host list, establishing the secure connection takes too much time, longer than the not excluded ones.

Notice that API have changed in release branch on beta.
Try this on my latest change on release branch.
 if (!e.ProxySession.Request.Hostname.Equals("medeczane.sgk.gov.tr")) return;
            if (e.RequestMethod == "GET" || e.RequestMethod == "POST")
            {
                if (e.ProxySession.Response.ResponseStatusCode == "200")
                {
                    if (e.ProxySession.Response.ContentType.Trim().ToLower().Contains("text/html"))
                    {
                        string body = e.GetResponseBodyAsString();
                    }
                }
            }


ConstraintViolations context determines HTTP status

Due to #842, validation opens up new opportunities and by happenstance, a new bug. Now validations can be done on resource query parameters, return values, etc, and this, in my opinion is a good thing.
The pitfall I ran into is that the current ConstraintViolationExceptionMapper with the new bean validation in place, does not follow the jersey documentation, which states that:

500 (Internal Server Error): If the exception was thrown while validating a method return type.
400 (Bad Request): Otherwise.

This pull request attempts to fix the current behavior, which will return 422 on return values and *Params. The violations in *Params now return a 400 and a return value violation is a 500.
There is an issue with this implementation: I'm uncomfortable that the only sane implementation for checking if constraint violation was fired on a parameter is by regex. Please advise.
EDIT: I found a better way than regex from the Jersey code

Thanks for catching this!  I think this change looks fine to me.  Any thoughts from your side @joschi ?

Just note, this isn't ready to merge this until I comment here with the swapped out implementation, which'll be sometime tomorrow :smile:

Okay, code is ready for review :sunglasses:
/cc @joschi

I think this looks good.  Thanks for the contribution!


707 location pages changes design history

New design history entry for changes to Location pages: https://trello.com/c/YlTjt120

 Design history for content changes to 'Locations' pages

🙌  great work!


Multiple slack_url

Hi, is there a way to configure 2 or more slack webhook urls? I have two channels and I need to set two webhooks or at least set different channels from PM2 module.
Maybe it's done but i didn't find it.
Thanks in advance.

Currently only one webhook is supported.
Just like #4, I recommend for now to setup your app's per user on linux for different configs.
Ill leave this open for a future possible feature if I get time to work on it.
Feel free to submit a pull request if you have an idea on how to do it.
Thanks!

See the pull request https://github.com/mattpker/pm2-slack/pull/22 and test it please.

Fixed by #22


feat: fix workflow hangs during executeDAGTask. Fixes #6557

Signed-off-by: smile-luobin<EMAIL_ADDRESS>Fixes #6557: workflow hangs during executeDAGTask.
If a DAGTask node type is retry and its last children is completed, it will be completed after woc.executeTemplate, so need to runOnExitNode to genereate its exitNode.

This needs a test before it can be approved and merged.

This needs a test before it can be approved and merged.

done.

@alexec can you quickly take a look and approve it?


V8 Docs are broken

Describe the bug
All links under feature give an error.
Also headerGroup
Your minimal, reproducible example
https://tanstack.com/table/v8/docs/column-visibility
Steps to reproduce

Go to https://tanstack.com/table/v8/docs/column-visibility
See error
Go to https://tanstack.com/table/v8/docs/header-group.md
See error

Expected behavior
Expecting no error
How often does this bug happen?
No response
Screenshots or Videos
No response
Platform
OSX Chrome
react-table version
latest
TypeScript version
No response
Additional context
No response
Terms & Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

This is a bad link. Add a /features/ after /docs and it will work.


Possible regression with hover provider

I recently upgraded a plugin's languageserver-client to v4, and observed this change:
in v3

in v4

There are two hover items, and they earlier had a border between different items. Now, all items are merged into one string.
This is due to the asHoverContent() merging all values of an array of items into one markdown string: https://github.com/Microsoft/vscode-languageserver-node/blob/e9685db42b8813b9aec70b24a70dfbb8cd0d4379/client/src/protocolConverter.ts#L206-L209
The reason I liked the earlier behaviour is because it split the content being hovered and it's documentation in visually separate areas. Now, it's a little difficult to make out where the documentation starts.
Is this change a regression, or deliberate?

This is a regression and is tracked here: https://github.com/Microsoft/vscode-languageserver-node/issues/328

Okay. Good to see it's tracked 👍  I thought that issue was related to something else, as the linked lines are probably not the correct ones.


Anatomy of Gauge

Hi,
I really love this library, THANK YOU! It's got a lot of potential for me. However, I'm struggling with the anatomy of each of the options, but I'm working through the difference between a section, area and markers for example. I don't suppose you could pop up a simple diagram of this? Although I might have figured it out by playing with it.
My second question is whether you can answer if my requirement can be met by this library?
I want to implement a cross between the dashboard and the indicator; couple with a range from -100 to 100. I want the bar to grow red when it goes negative and grow green when positive.
I see I can set ranges in the background, but I don't seem to be able to influence the bar colour as it grows left or right. Is this even possible?
Kind regards
Carl

Hi there, you might want to check my blog for more information: https://harmoniccode.blogspot.com/search?q=Medusa&m=1
In addition there is also a Medusa Demo project on github that shows all kind gauges and in the code you can see how it was done.
For your second question I can only answer that yes you can change the color in the way you want but you might want to add a little sketch of your vision here so that I can better see what you are planning to do.

Ah, thanks for getting back to me. Had a good play last night and starting to get a hang of what it is capable of; looking at the code is useful! Thanks for the Blog, that didn't appear in my searching and I can see what I need there that will help with the Anatomy.
As for my second question:

A badly drawn diagram. Effectively I want to start at 0.0 and then move the needle CCW (Red) or CW (Green) and show the label for the amount.


Plugin does not install successfully

None of the commands are recognized after install.
Things tried:

Reload VSCode
Disable -> reload -> Enable
Uninstall -> reload -> Install

Ditto, sadly. Or for me, the chat appears but the two panes are not able to be typed into.

I'm talking about this process not working, not how to debug your plugin 😉


Failed container doesn't care what instructions it gets and from

When container fails and escalates the problem to its parent supervision system, it doesn't care what instructions it get and from. It makes it accept instructions that might not be connected to solving the issue. What's more it allows executing the commands that should not be allowed in failed state.

Supervision and routing now supports passing hashes. Once a container enters the failed state it registers an unique failure hash, which then passes to supervisor. After that, only commands having the same hash are executed, while other are rejected. It solves this problem, but makes developer responsible for passing hashes.


Master branch tests failed.

Master branch tests failed, we need to fix it according to latest codes updates.

It's really bad practice to merge code that breaks master.

Ok, thank you for kind remind @rabbah , I'll take care next time and try fix it ASAP.

Great! Thank you. Practicing good habits makes us all better.

Close as fixed.


Optim bounds once again

@fredrikekre I think maybe this is correct. I applied your diff, but now v1+ isn't installed on Julia v1.5. Can you verify this might be what I was going for? I just didn't want versions below v1 of Optim to be installed on Julia lower than v1.2. Thanks!

@pkofod Can you rebase on master and squash?
@fredrikekre Can you review this?

For what it's worth, I think that this is correct. That being said, it would be good for Fredrik to review it as well, just to be safe.
First column is the Julia version, second column is whether or not Optim 0.17 is installable on that Julia version, third column is whether or not Optim 1 is installable on that Julia version:
julia> for minor in [0, 1, 2, 3, 4]
       for patch in [0, 1, 2]
       ranges = Pkg.Types.VersionRange.(["1.0-1.1", "1.2-1"])
       ver = VersionNumber(1, minor, patch)
       println(ver, " ", ver in ranges[1], " ", ver in ranges[2])
       end
       end
1.0.0 true false
1.0.1 true false
1.0.2 true false
1.1.0 true false
1.1.1 true false
1.1.2 true false
1.2.0 false true
1.2.1 false true
1.2.2 false true
1.3.0 false true
1.3.1 false true
1.3.2 false true
1.4.0 false true
1.4.1 false true
1.4.2 false true

Sorry, I think I misunderstood what you wanted in the previous PR, or maybe I was tired. I can push a rebase, but why do you also want to limit Optim 0.17 to Julia < 1.2?

I think is the diff we need (compared to master) now after Optim 1.2:
diff --git a/O/Optim/Compat.toml b/O/Optim/Compat.toml
index 56eea5a..cbe61fd 100644
--- a/O/Optim/Compat.toml
+++ b/O/Optim/Compat.toml
@@ -80,11 +80,5 @@ StatsBase = "0.29-0.33"

 [1]
 FillArrays = "0.6.2-0.9"
-
-["1-1.1"]
-NLSolversBase = "7.7-7"
-julia = "1.2"
-
-["1.2-1"]
 NLSolversBase = "7.7.0-7"
 julia = "1.2.0-1"


update elo readme

update elo readme

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

he had signed CLA.please recheck. @lianglia-apollo


Mutable views

Allow mutable region views (and flat region views).
Along this, the internal HugrMut methods should be moved to a sealed trait, and make the regions implement the public HugrMut.
Then we can add https://github.com/CQCL-DEV/hugr/issues/246 to that public trait.

@aborgna-q should I close this now? Or do we think we want a DescendantsMut enough to keep this open? (Maybe that should be a new issue?)

Let's close this 👍


Palm trees are busted

Reported on discord

Sending you the particular editor files might be useful :

SD_D02.txt

Can't reproduce from the original image sent on Discord, probably fixed by b6859f584e62e13c2ecfa7a82c1a7f5e3cb3d50c.


Latest Version?

I have version <IP_ADDRESS>3 according to Help-About
But at
https://github.com/fernandreu/office-ribbonx-editor
"To download the latest release, go to the following link:
https://github.com/fernandreu/office-ribbonx-editor/releases/latest
it takes me to <IP_ADDRESS>8 (August 13)
I'm GitHub challenged, so where is the latest release located?
Thanks

Hi phossler,
There are two types of ways of getting the tool (both mentioned in the main project page):

From GitHub's releases page as you mentioned
From Azure Pipelines

The latter is a development build, in the sense that one new version gets automatically generated as soon as I make some changes to the master branch of the project. You usually get more bugs fixed in those, which is why I normally suggest people to download one of those after I have completed an issue they created (in your case, see this).
The downside of those development builds is that, if I have just made recent changes to the tool, there might also be new bugs introduced that I have not fixed yet. I create releases at a much slower pace than development builds mainly because of this (and also to avoid annoying users with too many Version x.y.z available! messages :sweat_smile:).
The first three digits (1.5.1) are manually changed by myself before pushing the changes to the repository. The fourth version digit (463 in your case) will automatically refer to the build ID. You can see the most recent builds here. The build ID appears in the URL of each build; 482 is currently the latest. I am just preparing for another release in the next few weeks, so the development build should be quite stable.
You can only see builds from the last 30 days (or associated to a Release Pipeline in Azure, which is not the same as a GitHub Release), so build 463 is no longer in that list.

Thanks for taking the time to explain

1.5.1.xxx is the latest ‘official’ release, and I have that 😊

Download / Build status
To download the latest release, go to the following link:
https://github.com/fernandreu/office-ribbonx-editor/releases/latest https://github.com/fernandreu/office-ribbonx-editor/releases/latest
To download the latest development build instead, go to the Artifacts section on Azure Pipelines:
https://dev.azure.com/fernandreu-public/OfficeRibbonXEditor/_build/latest?definitionId=1&branchName=master https://dev.azure.com/fernandreu-public/OfficeRibbonXEditor/_build/latest?definitionId=1&branchName=master

The first link takes me to 418 and [Assets] has the EXE and MSI  😊 😊

I did try Azure but I could not see any ‘Artifacts’ section. Is it labeled a something else? (I did say that I’m only learning GitHub)

If I click on [Releases] I can see Release 11 (20190928) but I didn’t any way to download an EXE or MSI
Sorry to be such a bother
Paul H. Hossler
Valley Forge, PA
<EMAIL_ADDRESS><EMAIL_ADDRESS>From: Fernando Andreu<EMAIL_ADDRESS>Sent: Thursday, November 21, 2019 3:02 AM
To: fernandreu/office-ribbonx-editor<EMAIL_ADDRESS>Cc: phossler<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [fernandreu/office-ribbonx-editor] Latest Version? (#78)
Hi phossler,
There are two types of ways of getting the tool (both mentioned in the main project page):

From GitHub's releases page https://github.com/fernandreu/office-ribbonx-editor/releases  as you mentioned
From Azure Pipelines https://dev.azure.com/fernandreu-public/OfficeRibbonXEditor/_build/latest?definitionId=1&branchName=master

The latter is a development build, in the sense that one new version gets automatically generated as soon as I make some changes to the master branch of the project. You usually get more bugs fixed in those, which is why I normally suggest people to download one of those after I have completed an issue they created (in your case, see this https://github.com/fernandreu/office-ribbonx-editor/issues/59 ).
The downside of those development builds is that, if I have just made recent changes to the tool, there might also be new bugs introduced that I have not fixed yet. I create releases at a much slower pace than development builds mainly because of this (and also to avoid annoying users with too many Version x.y.z available! messages 😅).
The first three digits (1.5.1) are manually changed by myself before pushing the changes to the repository. The fourth version digit (463 in your case) will automatically refer to the build ID. You can see the most recent builds here https://dev.azure.com/fernandreu-public/OfficeRibbonXEditor/_build?definitionId=1&_a=summary . The build ID appears in the URL of each build; 482 https://dev.azure.com/fernandreu-public/OfficeRibbonXEditor/_build/results?buildId=482&view=results  is currently the latest. I am just preparing for another release in the next few weeks, so the development build should be quite stable.
You can only see builds from the last 30 days (or associated to a Release Pipeline in Azure, which is not the same as a GitHub Release), so build 463 is no longer in that list.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/fernandreu/office-ribbonx-editor/issues/78?email_source=notifications&email_token=AH3OZNYWNTRJBWCWB5BMJR3QUY6ATA5CNFSM4JPZO4P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEZKFXY#issuecomment-556966623 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3OZN66ZDSAAJUUHVGP62TQUY6ATANCNFSM4JPZO4PQ .  https://github.com/notifications/beacon/AH3OZNZ2RK7M64FDQ2SO4JTQUY6ATA5CNFSM4JPZO4P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEZKFXY.gif

No problem!
The Artifacts section is kind of in the middle once you click on a build, not in the left side. See the bottom-right corner of this screenshot:

The Releases section at the left is a different kind of pipeline that I will start using for the next official release on GitHub. It isn't exactly active at the moment (just pointing to a random build).
Finally, since you mention you are learning GitHub, and just in case you did not notice: when you reply to an issue via email, everybody can still see the answer in here, including your signature, email, etc., and with everything formatted pretty badly usually. Sometimes even the entire email chain (other times, GitHub manages to filter that out). I have updated your comment to remove some bits just in case you did not want to share them.

Ahh - thanks for both
Paul


[BEAM-12620] Add Java 17 Nexmark metrics to Grafana

Show metrics in Grafana
Minor fix to website doc

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @fernando-wizeline
Can you take a look? Copied your change for Grafana

R: @fernando-wizeline
Can you take a look? Copied your change for Grafana

Looks good to me!


Support for event/context to decorate request

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal
Currently to capture the raw APIGW event or context, we need to use the json serialized headers.
While this is workable, I was wondering if its possible instead to provide an option to decorate the request with the event and context.
This would be useful to pull out authorizer results and other APIGW specific fields, and possibly reduce the overhead of json serialization (and deserialization) to read these fields.
I'm a little unsure how to go about this as this library uses Inject and is not a Plugin, but i'm happy to give it a go if you can give some guidance :)
Motivation
Take advantage of API Gateway functionality with less computational complexity.
Example
const proxy = awsLambdaFastify(app, {
 decorateRequest: true
})

or
const proxy = awsLambdaFastify(app, {
 requestDecoration: {
  enabled: true,
  eventKey: 'apiGatewayEvent',
  contextKey: 'apiGatewayContext',
 }
})

+1 - It would be nice to not do the decoding/deserializing and access the raw values directly on the request somehow.

@adrai I actually missed this comment! This is actually a good idea and it would be cool to have a PR.

Sorry, but I have currently no idea how this could work without passing them in some serialized way. Like @barticus already said, this is not a plugin. 🤷♂

Not sure if it can apply here, but I recently saw that nestjs-pino does some fancy tricks with AsyncLocalStorage to maintain references to request data for logging purposes without passing request objects around. Not sure if the same could be used here to workaround any not-plugin limitations.

https://github.com/iamolegga/nestjs-pino
https://nodejs.org/api/async_context.html#async_context_class_asynclocalstorage

I would not use AsyncLocalStorage as it is quite costly.
I see two ways of doing this:

store it in a module-global. There is only one request at any time anyway. Then we export a function to get the value. It's important that the value is cleared as the last thing to return it to Lambda.

given that we receive the Fastify app, we can call decorateRequest on it and decorate it with the said function.

I've created a PR, this way we can discuss it based on that.
Feel free to review it, and let me know what you do think about it.


Seg fault with tutorial code

I was working on updating the Enzyme tutorial, and I'm reaching a segfault just with the code that Michel had shared, just an edited version of what I'd originally wrote:
using Enzyme

const blength = [5000.0e5; 1000.0e5; 5000.0e5]   ## north-south size of boxes, centimeters

const bdepth = [1.0e5; 5.0e5; 4.0e5]   ## depth of boxes, centimeters

const delta = bdepth[1]/(bdepth[1] + bdepth[3])  ## constant ratio of two depths

const bwidth = 4000.0*1e5  ## box width, centimeters

## box areas
const barea = [blength[1]*bwidth;
         blength[2]*bwidth;
         blength[3]*bwidth]

## box volumes
const bvol = [barea[1]*bdepth[1];
        barea[2]*bdepth[2];
        barea[3]*bdepth[3]]

## parameters that are used to ensure units are in CGS (cent-gram-sec)

const hundred = 100.0
const thousand = 1000.0
const day = 3600.0*24.0
const year = day*365.0
const Sv = 1e12     ## one Sverdrup (a unit of ocean transport), 1e6 meters^3/second

## parameters that appear in box model equations
const u0 = 16.0*Sv/0.0004
const alpha = 1668e-7
const beta = 0.7811e-3

const gamma = 1/(300*day)

## robert filter coefficient for the smoother part of the timestep
const robert_filter_coeff = 0.25

## freshwater forcing
const FW = [(hundred/year) * 35.0 * barea[1]; -(hundred/year) * 35.0 * barea[1]]

## restoring atmospheric temperatures
const Tstar = [22.0; 0.0]
const Sstar = [36.0; 34.0];

## function to compute transport
##       Input: rho - the density vector
##       Output: U - transport value

function U_func(dens)

    U = u0*(dens[2] - (delta * dens[1] + (1 - delta)*dens[3]))
    return U

end

## function to compute density
##       Input: state = [T1; T2; T3; S1; S2; S3]
##       Output: rho

function rho_func(state)

    rho = zeros(3)

    rho[1] = -alpha * state[1] + beta * state[4]
    rho[2] = -alpha * state[2] + beta * state[5]
    rho[3] = -alpha * state[3] + beta * state[6]

    return rho

end

## lastly our timestep function
##       Input: fld_now = [T1(t), T2(t), ..., S3(t)]
##           fld_old = [T1(t-dt), ..., S3(t-dt)]
##           u = transport(t)
##           dt = time step
##       Output: fld_new = [T1(t+dt), ..., S3(t+dt)]

function timestep_func(fld_now, fld_old, u, dt)

    temp = zeros(6)
    fld_new = zeros(6)

    ## first computing the time derivatives of the various temperatures and salinities
    if u > 0

        temp[1] = u * (fld_now[3] - fld_now[1]) / bvol[1] + gamma * (Tstar[1] - fld_now[1])
        temp[2] = u * (fld_now[1] - fld_now[2]) / bvol[2] + gamma * (Tstar[2] - fld_now[2])
        temp[3] = u * (fld_now[2] - fld_now[3]) / bvol[3]

        temp[4] = u * (fld_now[6] - fld_now[4]) / bvol[1] + FW[1] / bvol[1]
        temp[5] = u * (fld_now[4] - fld_now[5]) / bvol[2] + FW[2] / bvol[2]
        temp[6] = u * (fld_now[5] - fld_now[6]) / bvol[3]

    elseif u <= 0

        temp[1] = u * (fld_now[2] - fld_now[1]) / bvol[1] + gamma * (Tstar[1] - fld_now[1])
        temp[2] = u * (fld_now[3] - fld_now[2]) / bvol[2] + gamma * (Tstar[2] - fld_now[2])
        temp[3] = u * (fld_now[1] - fld_now[3]) / bvol[3]

        temp[4] = u * (fld_now[5] - fld_now[4]) / bvol[1] + FW[1] / bvol[1]
        temp[5] = u * (fld_now[6] - fld_now[5]) / bvol[2] + FW[2] / bvol[2]
        temp[6] = u * (fld_now[4] - fld_now[6]) / bvol[3]

    end

    ## update fldnew using a version of Euler's method

    for j = 1:6
        fld_new[j] = fld_old[j] + 2.0 * dt * temp[j]
    end

    return fld_new
end

# ## Define forward functions

function forward_func(state, fld_old, fld_now, dt, M)

    state_now = copy(fld_now)
    state_old = copy(fld_old)
    state_new = zeros(6)

    for t = 1:M
        rho_now = rho_func(state_now)
        u_now = U_func(rho_now)
        state_new = timestep_func(state_now, state_old, u_now, dt)

        ## Robert filter smoother (needed for stability)
        for j = 1:6
            state_now[j] = state_now[j] + robert_filter_coeff * (state_new[j] - 2.0 * state_now[j] + state_old[j])
        end

        ## cycle the "now, new, old" states

        state_old = state_now
        state_now = state_new
    end
    copyto!(state, state_old)

    return nothing
end

const Tbar = [20.0; 1.0; 1.0]
const Sbar = [35.5; 34.5; 34.5]

const M = 10000             ## Deciding on total number of forward steps to take

## unperturbed final state

state_out = zeros(6)
forward_func(state_out, [Tbar;Sbar], [Tbar;Sbar], 10*day, M)
use_to_check = state_out[1]

din_now = zeros(6)
din_old = zeros(6)
dout_old = [1.0;0.0;0.0;0.0;0.0;0.0]
dout_now = [0.0;0.0;0.0;0.0;0.0;0.0]
state_out = zeros(6)
autodiff(
    forward_func,
    Duplicated(state_out, dout_old),
    Duplicated([Tbar; Sbar], din_now),
    Duplicated([Tbar; Sbar], din_old),
    10*day,
    M,
)

This led to this output:

signal (11): Segmentation fault: 11
in expression starting at /Users/swilliamson/Documents/issue.jl:163
_Z14PostCacheStorePN4llvm9StoreInstERNS_9IRBuilderINS_14ConstantFolderENS_24IRBuilderDefaultInserterEEE at /Users/swilliamson/.julia/artifacts/8493c1f4eee1ef957152a9877681c9150152f160/lib/libEnzyme-13.dylib (unknown line)
_ZN12CacheUtility23storeInstructionInCacheENS_12LimitContextERN4llvm9IRBuilderINS1_14ConstantFolderENS1_24IRBuilderDefaultInserterEEEPNS1_5ValueEPNS1_10AllocaInstEPNS1_6MDNodeE at /Users/swilliamson/.julia/artifacts/8493c1f4eee1ef957152a9877681c9150152f160/lib/libEnzyme-13.dylib (unknown line)
_ZN12CacheUtility23storeInstructionInCacheENS_12LimitContextEPN4llvm11InstructionEPNS1_10AllocaInstEPNS1_6MDNodeE at /Users/swilliamson/.julia/artifacts/8493c1f4eee1ef957152a9877681c9150152f160/lib/libEnzyme-13.dylib (unknown line)
_ZN13GradientUtils18ensureLookupCachedEPN4llvm11InstructionEbPNS0_10BasicBlockEPNS0_6MDNodeE at /Users/swilliamson/.julia/artifacts/8493c1f4eee1ef957152a9877681c9150152f160/lib/libEnzyme-13.dylib (unknown line)
_ZN13GradientUtils7lookupMEPN4llvm5ValueERNS0_9IRBuilderINS0_14ConstantFolderENS0_24IRBuilderDefaultInserterEEERKNS0_8ValueMapIPKS1_NS0_14WeakTrackingVHENS0_14ValueMapConfigISA_NS0_3sys10SmartMutexILb0EEEEEEEb at /Users/swilliamson/.julia/artifacts/8493c1f4eee1ef957152a9877681c9150152f160/lib/libEnzyme-13.dylib (unknown line)
_ZN16AdjointGeneratorIPK15AugmentedReturnE6lookupEPN4llvm5ValueERNS4_9IRBuilderINS4_14ConstantFolderENS4_24IRBuilderDefaultInserterEEE at /Users/swilliamson/.julia/artifacts/8493c1f4eee1ef957152a9877681c9150152f160/lib/libEnzyme-13.dylib (unknown line)
_ZN16AdjointGeneratorIPK15AugmentedReturnE13visitCallInstERN4llvm8CallInstE at /Users/swilliamson/.julia/artifacts/8493c1f4eee1ef957152a9877681c9150152f160/lib/libEnzyme-13.dylib (unknown line)
_ZN11EnzymeLogic23CreatePrimalAndGradientEOK15ReverseCacheKeyR12TypeAnalysisPK15AugmentedReturnb at /Users/swilliamson/.julia/artifacts/8493c1f4eee1ef957152a9877681c9150152f160/lib/libEnzyme-13.dylib (unknown line)
EnzymeCreatePrimalAndGradient at /Users/swilliamson/.julia/artifacts/8493c1f4eee1ef957152a9877681c9150152f160/lib/libEnzyme-13.dylib (unknown line)
EnzymeCreatePrimalAndGradient at /Users/swilliamson/.julia/dev/Enzyme/src/api.jl:118
enzyme! at /Users/swilliamson/.julia/dev/Enzyme/src/compiler.jl:4508
unknown function (ip: 0x13749a21b)
ijl_apply_generic at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
#codegen#120 at /Users/swilliamson/.julia/dev/Enzyme/src/compiler.jl:5498
codegen##kw at /Users/swilliamson/.julia/dev/Enzyme/src/compiler.jl:5168 [inlined]
_thunk at /Users/swilliamson/.julia/dev/Enzyme/src/compiler.jl:5971 [inlined]
_thunk at /Users/swilliamson/.julia/dev/Enzyme/src/compiler.jl:5965
unknown function (ip: 0x1344cc463)
ijl_apply_generic at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
cached_compilation at /Users/swilliamson/.julia/dev/Enzyme/src/compiler.jl:6009
unknown function (ip: 0x1340003db)
ijl_apply_generic at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
#s753#147 at /Users/swilliamson/.julia/dev/Enzyme/src/compiler.jl:6069 [inlined]
#s753#147 at ./none:0
ijl_apply_generic at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
GeneratedFunctionStub at ./boot.jl:582
ijl_apply_generic at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
jl_call_staged at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
ijl_code_for_staged at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
get_staged at ./compiler/utilities.jl:114
retrieve_code_info at ./compiler/utilities.jl:126 [inlined]
InferenceState at ./compiler/inferencestate.jl:284
typeinf_edge at ./compiler/typeinfer.jl:868
abstract_call_method at ./compiler/abstractinterpretation.jl:641
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:153
abstract_call_known at ./compiler/abstractinterpretation.jl:1696
abstract_call at ./compiler/abstractinterpretation.jl:1766
abstract_call at ./compiler/abstractinterpretation.jl:1733
abstract_eval_statement at ./compiler/abstractinterpretation.jl:1890
typeinf_local at ./compiler/abstractinterpretation.jl:2366
typeinf_nocycle at ./compiler/abstractinterpretation.jl:2462
_typeinf at ./compiler/typeinfer.jl:230
typeinf at ./compiler/typeinfer.jl:213
typeinf_edge at ./compiler/typeinfer.jl:877
abstract_call_method at ./compiler/abstractinterpretation.jl:641
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:153
abstract_call_known at ./compiler/abstractinterpretation.jl:1696
abstract_call at ./compiler/abstractinterpretation.jl:1766
abstract_call at ./compiler/abstractinterpretation.jl:1733
abstract_eval_statement at ./compiler/abstractinterpretation.jl:1890
typeinf_local at ./compiler/abstractinterpretation.jl:2366
typeinf_nocycle at ./compiler/abstractinterpretation.jl:2462
_typeinf at ./compiler/typeinfer.jl:230
typeinf at ./compiler/typeinfer.jl:213
typeinf_edge at ./compiler/typeinfer.jl:877
abstract_call_method at ./compiler/abstractinterpretation.jl:641
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:153
abstract_call_known at ./compiler/abstractinterpretation.jl:1696
abstract_call at ./compiler/abstractinterpretation.jl:1766
abstract_call at ./compiler/abstractinterpretation.jl:1733
abstract_eval_statement at ./compiler/abstractinterpretation.jl:1890
typeinf_local at ./compiler/abstractinterpretation.jl:2366
typeinf_nocycle at ./compiler/abstractinterpretation.jl:2462
_typeinf at ./compiler/typeinfer.jl:230
typeinf at ./compiler/typeinfer.jl:213
typeinf_ext at ./compiler/typeinfer.jl:967
typeinf_ext_toplevel at ./compiler/typeinfer.jl:1000
typeinf_ext_toplevel at ./compiler/typeinfer.jl:996
jfptr_typeinf_ext_toplevel_12299 at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/sys.dylib (unknown line)
ijl_apply_generic at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
jl_type_infer at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
jl_generate_fptr_impl at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-codegen.1.8.dylib (unknown line)
jl_compile_method_internal at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
ijl_apply_generic at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
autodiff at /Users/swilliamson/.julia/dev/Enzyme/src/Enzyme.jl:300
ijl_apply_generic at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
do_apply at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
autodiff at /Users/swilliamson/.julia/dev/Enzyme/src/Enzyme.jl:334
ijl_apply_generic at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
do_apply at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
autodiff at /Users/swilliamson/.julia/dev/Enzyme/src/Enzyme.jl:434
ijl_apply_generic at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
do_call at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
eval_body at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
jl_interpret_toplevel_thunk at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
jl_toplevel_eval_flex at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
jl_toplevel_eval_flex at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
ijl_toplevel_eval_in at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
eval at ./boot.jl:368 [inlined]
include_string at ./loading.jl:1428
ijl_apply_generic at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
_include at ./loading.jl:1488
include at ./client.jl:476
unknown function (ip: 0x102cc4057)
ijl_apply_generic at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
do_call at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
eval_body at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
jl_interpret_toplevel_thunk at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
jl_toplevel_eval_flex at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
jl_toplevel_eval_flex at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
ijl_toplevel_eval_in at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
eval at ./boot.jl:368 [inlined]
eval_user_input at /Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/build/default-macmini-aarch64-1-0/julialang/julia-release-1-dot-8/usr/share/julia/stdlib/v1.8/REPL/src/REPL.jl:151
repl_backend_loop at /Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/build/default-macmini-aarch64-1-0/julialang/julia-release-1-dot-8/usr/share/julia/stdlib/v1.8/REPL/src/REPL.jl:247
start_repl_backend at /Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/build/default-macmini-aarch64-1-0/julialang/julia-release-1-dot-8/usr/share/julia/stdlib/v1.8/REPL/src/REPL.jl:232
#run_repl#47 at /Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/build/default-macmini-aarch64-1-0/julialang/julia-release-1-dot-8/usr/share/julia/stdlib/v1.8/REPL/src/REPL.jl:369
run_repl at /Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/build/default-macmini-aarch64-1-0/julialang/julia-release-1-dot-8/usr/share/julia/stdlib/v1.8/REPL/src/REPL.jl:355
jfptr_run_repl_67919 at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/sys.dylib (unknown line)
ijl_apply_generic at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
#966 at ./client.jl:419
jfptr_YY.966_42132 at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/sys.dylib (unknown line)
ijl_apply_generic at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
jl_f__call_latest at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
#invokelatest#2 at ./essentials.jl:729 [inlined]
invokelatest at ./essentials.jl:726 [inlined]
run_main_repl at ./client.jl:404
exec_options at ./client.jl:318
_start at ./client.jl:522
jfptr__start_58825 at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/sys.dylib (unknown line)
ijl_apply_generic at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
true_main at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
jl_repl_entrypoint at /Applications/Julia-1.8.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
Allocations: 30280287 (Pool: 30239469; Big: 40818); GC: 34

I don't see anything obvious about why this is happening, could you maybe give some advice?

Can you remove the LocalPreferences.toml we made earlier, and try again?

Sure and still reached a segfault. Did it run for you? I did try having someone else in my lab run the script and they also got the same error on their computer, also checked that it runs without the autodiff call

It did run for me, though I'm on a later Enzyme_jll (current main) as well as Enzyme.jl main.

Weird, not sure then

Going to close this as cannot reproduce on current main. Please reopen if it persists.