Convert all tests to assertThrows

The goal of this PR is to convert all usage of the older @Test(expected = ... form of exception testing to the newer assertThrows().
An example conversion:
  @Test(expected = IllegalArgumentException.class)
  public void testNegativeTimeout() {
    BatchWriterConfig bwConfig = new BatchWriterConfig();
    bwConfig.setTimeout(-1, TimeUnit.DAYS);
  }

Would become:
  @Test
  public void testNegativeTimeout() {
    BatchWriterConfig bwConfig = new BatchWriterConfig();
    assertThrows(IllegalArgumentException.class, () -> bwConfig.setTimeout(-1, TimeUnit.DAYS));
  }

I used this command to verify all tests that were changed still pass:
mvn clean verify -Dit.test=ConditionalWriterIT,ReadWriteIT,KerberosIT,MetaConstraintRetryIT,ShellServerIT,BulkNewIT,ZooKeeperPropertiesIT,AccumuloInputFormatIT,NewTableConfigurationIT,MetaSplitIT,CloneTestIT -Dtest=ZooReaderWriterTest,TabletMetadataTest,TCredentialsUpdatingInvocationHandlerTest,AuthorizationsTest,FastFormatTest,ReplicationProcessorTest,TabletLocationStateTest,RelativeKeyTest,InMemoryMapTest,GarbageCollectionTest,OpTimerTest,ConfigCheckUtilTest,ScannerOptionsTest,ConfigurationTypeHelperTest,LogFileKeyTest,DefaultFormatterTest,SortedMapIteratorTest,TabletServerSyncCheckTest,LoadPlanTest,MetadataTimeTest,Upgrader9to10Test,ZooAuthenticationKeyDistributorTest,AuthenticationTokenSecretManagerTest,MutationTest,AccumuloConfigurationTest,ArrayByteSequenceTest,ListLexicoderTest,HadoopCredentialProviderTest,WholeRowIteratorTest,ConditionTest,ProblemReportingIteratorTest,UnsynchronizedBufferTest,TabletTimeTest,ManagerReplicationCoordinatorTest,IteratorSettingTest,TabletMutationPrepAttemptTest,ZooSessionTest,ValueTest,TServerUtilsTest,SpaceAwareVolumeChooserTest,RFileTest,BatchWriterConfigTest,LinkingIteratorTest,HexFormatterTest,RFileClientTest,CredentialProviderTokenTest,PasswordConverterTest,ReplicationSchemaTest,ServerContextTest,DelegationTokenConfigTest,KeyTest,ThriftTransportKeyTest,SequenceLexicoderTest,AccumuloTest,AuthenticationKeyTest,RowEncodingIteratorTest,ShellUtilTest,ZooKeeperInstanceTest -Dspotbugs.skip -Dtimeout.factor=1

@DomGarguilo I would prefer general code improvements like this that touch a lot of files to be merged in the next version (most likely 2.2) so to not slow down the 2.1 release. Did you have a reason why this needs to be in 2.1?

Did you have a reason why this needs to be in 2.1?

Nope, it can wait. Do you think I should mark this as draft until then?

Did you have a reason why this needs to be in 2.1?

Nope, it can wait. Do you think I should mark this as draft until then?

I was thinking we could create a temporary branch for 2.2 then merge it when we release 2.1. @ctubbsii any thoughts on this?

@DomGarguilo I would prefer general code improvements like this that touch a lot of files to be merged in the next version (most likely 2.2) so to not slow down the 2.1 release. Did you have a reason why this needs to be in 2.1?

These are all test files, with a very predictable fix, that I need to get merged for my subsequent fixes. I don't think there's a reason to delay on this.

Either merging now or waiting until after 2.1.0 is released is fine with me. What do you think, @milleruntime?
This change (#2435), which can stand alone, is a precursor to a set of other changes I have in mind that relate to upgrading JUnit from version 4 to 5. Those future changes, which may look similar to those in #2427, may be more disruptive and I am assuming we would want to hold off on a lot of those changes until after the 2.1.0 release. This PR might be fine to merge but for changes like that, should we just hold off on working on those altogether or should there be a separate branch for them like @milleruntime suggested?

This can be merged. I talked to Ed and he is OK with the changes.

My followup changes to this are in #2436


Provide default value for inputs in backward

Exchange A with inputs in the arguments of backward.
Implements _get_leafs_of_autograd_graph.
Implement default values for inputs in backward.
Remove useless inputs parameter to backward in tests and documentation.

Need to verify that this works in the rest files, we need to make sure that the .grad field of all parameters in the models have been populated.

Are we sure that the tests are exhaustive? It would be nice to do a live coding session together and try to find an edge case that breaks. It will probably help us make even more complete tests. If we don't find any edge case that doesn't work, I think this PR is ready to merge.
Also, please review my recent changes.

Also, I think the abstraction level of _get_leaves_of_autograd_graph is a bit weird.
In my opinion, it should take nodes as parameters (nodes_to_traverse as its first argument, excluded_nodes as its second), and maybe it should even return a set of AccumulateGrad. And it should be renamed to _get_accumulate_grad_nodes. Or maybe it should remain as it is but it should use a helper function _get_accumulate_grad_nodes.

For me, this is ready to merge.

LGTM.


get() takes exactly 1 argument (6 given)

INFO:root:----------------------------------------------------------------------
airbnbcollector    | INFO:root:Room 14006298: getting from Airbnb web site
airbnbcollector    | ERROR:root:Network request exception: type TypeError
airbnbcollector    | Traceback (most recent call last):
airbnbcollector    |   File "/airbnb_ws.py", line 83, in ws_individual_request
airbnbcollector    |     headers=headers, cookies=cookies, proxies=proxies)
airbnbcollector    | TypeError: get() takes exactly 1 argument (6 given)
Any thoughts?

I don't recognise the log format output.
The line nearest to 83 that has a "get" call is this one:
    response = requests.get(url, params, timeout=timeout,
                            headers=headers, cookies=cookies, proxies=proxies)

I wonder if you have a mixed up source? The current version ("python airbnb.py -V") is 3.6. Can you tell me what you see?


Support reading/writing to/from Input/OutputStreams

Seems to be more convenient for the Java user.

Indeed. Covering common cases also prevents bugs since the marshal and unmarshal methods ain't that simple.
The Java core library interfaces are less than optimal.

java.util.Iterator requires something like java.io.UncheckedIOException
java.io.ObjectInputStream and java.io.ObjectOutputStream are bloated
javax.xml.bind is extremely bloated

This is the best I can come up with. Ideas are welcome.
static java.io.ObjectInputStream reader(InputStream source, byte[] initialBuffer)
static java.io.ObjectOutputStream writer(OutputStream target, byte[] initialBuffer)


[no_alloc]: Extend support for embedded systems by removing the need for alloc

TL;DR: An option to compile without feature = "alloc" would be great :)

There is a feature flag for alloc already but it's not completely implemented.
A modified basic example (using a *mut self reference) compiles if I #[cfg(feature = "alloc")] out the use core::alloc::{...} and impl for Box, Rc, ... in mod.rs. But there are other parts which might need to be adjusted.
Reduced feature set would be fine IMO as the most basic is already nice enough to just wrap self-referencing types from C FFI on the stack.
I'm not well versed all these macro-magic though :)

There is a fork at https://github.com/silvanshade/moveref that has #[no_std] support.


quick-start guide setup

Sorry for the wrongly created pull request. Forked the repo and cloned it locally. However, when I created the pull request, I oversaw that it selected the 'mmistakes' repo instead of mine.


I3042 in PipelineConfigurationBody for AWS::OSIS::Pipeline when defining DynamoDB table_arn

CloudFormation Lint Version
cfn-lint 1.9.4
What operating system are you using?
macOS
Describe the bug
The template receives the following warning
[cfn-lint] I3042: ARN in Resource IngestionPipeline contains hardcoded Partition in ARN or incorrectly placed Pseudo Parameters

The regex for I3042 seems to be confused with the table_arn: part of the pipeline configuration as defined in Opensearch^1. If I rename it to just table:, the warning goes away. This is regardless if the value of table_arn: is a full arn using ${AWS::Partition} or a variable reference as is the case in the reproduction template.
Expected behavior
I expect the template to be valid as there is no use of a hardcoded partition nor any use of a pseudo parameter afaict.
Reproduction template
---
AWSTemplateFormatVersion: 2010-09-09

Parameters:
  DynamoDBTableArn:
    Description: "DynamoDB Table ARN"
    Type: String
  EnvironmentName:
    Type: String
    AllowedValues:
      - staging
      - production
  PipelineName:
    Description: "Name of the ingestion pipeline"
    Type: String
  PipelineMinUnits:
    Description: Min Units for ingestion pipeline
    Type: Number
  PipelineMaxUnits:
    Description: Max Units for ingestion pipeline
    Type: Number
Resources:
  IngestionPipeline:
    Type: AWS::OSIS::Pipeline
    Properties:
      PipelineName: !Sub ${PipelineName}
      MaxUnits: !Ref PipelineMaxUnits
      MinUnits: !Ref PipelineMinUnits
      PipelineConfigurationBody: !Sub |
          version: "2"
          dynamodb-pipeline:
            source:
              dynamodb:
                acknowledgments: true
                tables:
                  - table_arn: ${DynamoDBTableArn}
                  - export:
                      s3_bucket: mybucket
                      s3_prefix: ${EnvironmentName}
                    stream:
                      start_position: "LATEST"
                aws:
                  region: us-east-1

https://github.com/aws-cloudformation/cfn-lint/blob/39ca987531a9c7ffa64e1588dd1131273cfdb6b6/src/cfnlint/rules/resources/HardCodedArnProperties.py#L28
I think the issue is [^:] which will match any character but: including newlines.

I think the new regex pattern in the PR will do better with handling newlines and spacing

@kddejong confirmed, testing the PR against our full template corrected the warning


waitForNavigation behavior

Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.6.0
Platform / OS version: Linux henrique-Latitude-5480 4.15.0-23-generic #25-Ubuntu SMP Wed May 23 18:02:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
URLs (if applicable):  http://home.ubalt.edu/abento/frames/myframe.html
Node.js version: v8.11.3

What steps will reproduce the problem?
(async () => {

const puppeteer = await require('puppeteer');

const browser = await puppeteer.launch({headless:false,/* slowMo: 50*/});
const incognitoContext = await browser.createIncognitoBrowserContext();
const page = await incognitoContext.newPage();
page.on('dialog', async dialog => {
    await console.log('MESSAGE "%s": "%s"',dialog.type(),dialog.message());
    await dialog.dismiss();
});
await page.setCacheEnabled(false);

await page.goto('http://home.ubalt.edu/abento/frames/myframe.html', {waitUntil: ['load','domcontentloaded','networkidle0']});

const leftFrame = await page.frames().filter( el => el.name() == 'left')[0]
const rightFrame = await page.frames().filter( el => el.name() == 'right')[0]
await console.log('URLS: MAIN FRAME: %s ; RIGHT FRAME: %s ; LEFT FRAME: %s ', page.url(), rightFrame.url(), leftFrame.url());
const navigationPromise = page.waitForNavigation();
await leftFrame.click('a[href="option2.html"]');
await console.log('URLS: MAIN FRAME: %s ; RIGHT FRAME: %s ; LEFT FRAME: %s ', page.url(), rightFrame.url(), leftFrame.url());
await page.waitFor(5000);
await console.log('URLS: MAIN FRAME: %s ; RIGHT FRAME: %s ; LEFT FRAME: %s ', page.url(), rightFrame.url(), leftFrame.url()); // DISPLAY OTHER URL FOR rightFrame
await navigationPromise;
await console.log('URLS: MAIN FRAME: %s ; RIGHT FRAME: %s ; LEFT FRAME: %s ', page.url(), rightFrame.url(), leftFrame.url()); // NOT DISPLAYED, navigationPromise ERROR
await browser.close();

})();

What is the expected result?
I was expecting navigationPromise to be resolved, but it doesn't.
What happens instead?
navigationPromise isn't resolved. Is it the expected behavior? Is it possible to add a frame.waitForNavigation() function?
Screenshot:

Thanks
PS: I've also tried with the code below, using waitForNavigation as suggested in frame.click() documentation:
"use strict";

(async () => {

const puppeteer = await require('puppeteer');

const browser = await puppeteer.launch({headless:false,/* slowMo: 50*/});
const incognitoContext = await browser.createIncognitoBrowserContext();
const page = await incognitoContext.newPage();
page.on('dialog', async dialog => {
    await console.log('MESSAGE "%s": "%s"',dialog.type(),dialog.message());
    await dialog.dismiss();
});
await page.setCacheEnabled(false);

await page.goto('http://home.ubalt.edu/abento/frames/myframe.html', {waitUntil: ['load','domcontentloaded','networkidle0']});

const leftFrame = await page.frames().filter( el => el.name() == 'left')[0]
const rightFrame = await page.frames().filter( el => el.name() == 'right')[0]

await Promise.all([
    page.waitForNavigation(),
    leftFrame.click('a[href="option2.html"]')
]);

})();

@hlr1983 Your click navigates a frame rather than a page; unfortunately, we don't currently support waiting for navigation for frames.
One workaround would be to listen for framenavigated event.
await Promise.all([
  leftFrame.click('a[href="option2.html"]'),
  new Promise(resolve => page.once('framenavigated', resolve))
]);

I'm running into this same issue in my use case. Even if I use the suggestion that @aslushnikov posted, Promise.all is getting resolved prematurely because the 'framenavigated' event appears to be triggered before all the content inside the frame has loaded. We really need a await frame.waitForNavigation(); solution here that can wait for the frame to finish all network requests and other loading activities before proceeding.
Hope that PR gets merged soon.


Get list of changes for dataset version

User Story

So that I can understand the detailed history of a dataset, as a Developer or Data Analyst, I want to get a list of files/objects changes for a particular dataset version by specifying a version ID

Acceptance Criteria

[ ] Given [a pre-condition], when [an event happens], then [an expected outcome occurs]
[ ] Given [a pre-condition], when [an event happens], then [an expected outcome occurs]

Additional context

Tasks

[ ] ...
[ ] ...

Definition of Ready

[ ] This story is ready to work on, according to the
team's definition

Definition of Done

[ ] This story is done, according to the
team's definition

Would be done as part of #1051


Misleading FIFO documentation

For MessageDeduplicationId, MessageGroupId and ReceiveRequestAttemptId, the documentation says "The length of * is 128 characters" while it would be more accurate (and more clear to new users) to say "The maximum length of * is 128 characters".
I was about to submit a pull-request, but saw that this was in a service-2.json file (specifically botocore/data/sqs/2012-11-05/service-2.json), which you prefer to have opened issues for. But, if you wanted, the branch is here.

@anderson-dan-w - This issue has been fixed. You can verify in this documentation https://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_ReceiveMessage.html . Now it is updated to he maximum length of ReceiveRequestAttemptId is 128 characters.

Great, thanks! Consider this resolved

I am closing this issue as this has been fixed.


Backport HHH-15634 to branch 5.6 - Lazy basic property does not get updated on change

https://hibernate.atlassian.net/browse/HHH-15634
Backport of #5461 to branch 5.6.
@dreab8 I had to backport this in order to test in Quarkus, so I figured I'd send the PR.
Feel free to use this or drop it, as you see fit.

Thanks!


Wrong attribute in sample code in Flutter Codelabs

The attribute of animationController should be duration, the current is Duration.
Should edit from
  ChatMessage message = ChatMessage(
    text: text,
    animationController: AnimationController(      // NEW
      Duration: const Duration(milliseconds: 700), // NEW
      vsync: this,                                 // NEW
    ),                                             // NEW
  );

To
  ChatMessage message = ChatMessage(
    text: text,
    animationController: AnimationController(      // NEW
      duration: const Duration(milliseconds: 700), // NEW
      vsync: this,                                 // NEW
    ),                                             // NEW
  );

Here are url to the issue including the screenshot:
https://codelabs.developers.google.com/codelabs/flutter/index.html?index=..%2F..index#7

Hi @hieuwu
Thanks for filling this issue, it looks like this was already reported https://github.com/flutter/flutter/issues/64104.
I'm going to close this as duplicate. Please follow up on that issue.
Thank you


Make User Management Module responsive

Make User Management Module responsive

This issue is the duplicate issue. Closing it.


Add option to generate fragments as classes

"Only" 15k lines diff now :)! Looks good to me. We certainly need to move the ResponseFields outside the adapters like discussed offline but that can be in a separate PR.

I think the CI fails because of the merge in expected files. Can you rebase?


Gridly doesn't always update in Chrome

The picture really does say it all. Does anyone know what's going on here?

Hi. I have the same issue.
You got something ?

@pauloeli Nope. PR is welcome.


Add blocked label highlight, never forget .

I'd apologise but then I'd have to add a javascript <marquee> implementation instead.

Thank goodness, this is only applied to the text. For a brief second I thought you wanted the entire "card" to blink.

Actually, in my PR: https://github.com/Rory80Hz/rubbernecker/pull/8 I've got a proposal for "labels" or "stickers".

Perhaps, if my PR is liked and merged, this would be a perfect "FUUUUU blocked" sticker as oppose to causing epilepsy ;)


Marker Clustering taking Longer time on chrome

Hi,
I am facing a unusual problem in marker clustering.
From last three years I am using this library but from last couple of weeks my application takes a huge time to clustering the points and visualize on to the google maps API V3 in Google chrome (browser). This issue occurs only in Google chrome (browser) but in other browsers such as Firefox it works fine, that's why I cannot understand what is the issue.
So kindly help me what wrong I had done.
Application URL: http://maps.dicrc.in/BM/
Chrome Version 50.0.2661.102 m
Google API v3
Fusion Table V2
Thanks and Regards
Piyush

Doubt this is an overall issue with chrome as mine seems fine.  Probably something with your machine.  Make sure to try other laptops or someone else's chrome.  could just be  weird setting  you have.


Fail build if doco is broken

Until https://github.com/asciidoctor/asciidoctor/issues/816 is resolved, build should be checked eg using https://github.com/radai-rosenblatt/grep-maven-plugin

see https://github.com/spring-cloud/spring-cloud-dataflow-server-cloudfoundry/issues/192


Duplicate Environments - Find a New Way to Preview PRs?

The ReadtheDocs builds have all been failing on excessive memory consumption. A fix in #154 has been implemented to allow us to move forward on other PRs.
However this is an infrastructure band-aid that requires us to both have an environment.yaml file for the Conda builds and a requirements.txt file (names vary slightly) that PiP can read for the ReadtheDocs build.
Ideally we won't have duplication of the dependencies in 2 separate files. Let's investigate other approaches.
@brian-rose proposes that instead of Readthedocs, we build the PR on GitHub Actions (using the same build environment as our main build) and then display the rendered site on Netlify.

Thanks @jukent. I don't know if my proposed solution is feasible, but it would mirror how we preview PRs for the Foundations site. That site does not use Readthedocs because of the lack of support for JupyterBook. @andersy005 is working on documenting the Netlify-based preview workflow for Foundations over at https://github.com/ProjectPythia/pythia-foundations/issues/85.
One question is whether we would lose any useful features from readthedocs. Since we're only using it for previews, as opposed to keeping track of different versions of documentation, my guess is that the answer is no. We just need something that will display the rendered html for our site in a way that's consistent with what we'll see after the PR is merged.


Add support for htpasswd authentication

Hello,
Thank you for this PR.
Could you please add the doc (README) and some tests?
It  would be great :-)
Thank you.
Regards,

This PR is an almost year old and I no longer work for a company where we used Puppet so I'm not going to further maintain this PR. Sorry for the inconvenience.


Wrap neo4j driver exceptions in ActiveGraph::Core::CypherError family

This is a straw man solution for #1639
I do not expect this is ultimately how we want to solve it, but rather, opening this PR as an example that satisfies the tests in my application (which are looking for ActiveGraph:Core::SchemaErrors::ConstraintValidationFailedError)
If you can give me instructions on where to make the proper fix and what you'd like to see in terms of testing, I can fix up this PR.

The idea was not to translate the driver exceptions. The driver has a very detailed exception hierarchy which I would prefer not to replicate. Some errors are only differentiable by message rather than exception class type. I would say the vast majority of those exceptions if not all are not recoverable in activegraph so they have only a debug value. The driver exceptions serve this purpose well. But you are right that the unused exception classes should be removed from the code. They orginate from times where there was no driver and the whole error system was driven by the http adapter. I think the clean up is the only thing we should do at the moment.
In general, I try to expose as many aspects of the driver as possible so ActiveGraph::Core::Node is as well Neo4j::Driver::Node etc. That allows using of the driver and active graph interchangeably.

Okay. This will probably be a significant hurdle for folks upgrading from
neo4jrb 9, since in neo4jrb 9, we catch exceptions by class instead of also
having to inspect the message. The documentation will need to be updated
with examples to show how to handle them in activegraph. The docs currently
show that you need to rename a few specific classes, and then beyond that,
most classes have just moved from the Neo4j namespace to the ActiveGraph
namespace (and implicitly, this covers exceptions), which is how we ended
up expecting these to be thrown. It seemed to be just a mistake that the
ActiveGraph exceptions were not used, but I see now it was intentional.
From a philosophical perspective, it seems to me to be a downgrade for the
API to change such that we now have to catch a general exception and
inspect the message, which is both a degraded developer experience (since
ruby has first class syntax  for catching by exception class) and more
error prone (since the developer may get the message wrong). Again, this is
a place where it necessitates us writing our own wrappers to handle this
case because there are far too many occurrences in our code to duplicate
the message matching all over the place. Unfortunately, there isn’t a great
hook in ActiveGraph for us to provide our own exception wrappers so we will
probably stick with the fork of ActiveGraph I created.
Do we have a developer community of folks actually using ActiveGraph in a
large production application? It would be useful to get real user feedback
from others dealing with these problems. I’d be surprised if others felt it
was desirable to match on messages instead of exception classes.
On Wed, Dec 23, 2020 at 1:28 PM Heinrich Klobuczek<EMAIL_ADDRESS>wrote:

The idea was not to translate the driver exceptions. The driver has a very
detailed exception hierarchy which I would prefer not to replicate. Some
errors are only differentiable by message rather than exception class type.
I would say the vast majority of those exceptions if not all are not
recoverable in activegraph so they have only a debug value. The driver
exceptions serve this purpose well. But you are right that the unused
exception classes should be removed from the code. They orginate from times
where there was no driver and the whole error system was driven by the http
adapter. I think the clean up is the only thing we should do at the moment.
In general, I try to expose as many aspects of the driver as possible so
ActiveGraph::Core::Node is as well Neo4j::Driver::Node etc. That allows
using of the driver and active graph interchangeably.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/neo4jrb/activegraph/pull/1640#issuecomment-750420695,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD7LSTRUS2JO5ZFVM4THA3SWIZDTANCNFSM4VGHDGEA
.

@joshjordan could you give me some examples of how you react differently to different exception classes? I was under the impression that there is not much more you can do beyond simply logging those exceptions.

@joshjordan This is how neo4j, neo4j-java-driver, neo4j-java-driver ruby gem implement the exception system: https://neo4j.com/docs/status-codes/current/
Unfortunately, the MRI version of the neo4j-ruby-driver does not implement this properly and instead of the expressive string codes it returns cryptic hexadecimal seabolt codes. This is not satisfactory and should be fixed now or in the next major driver release. My question is would the described exception hierarchy with the detailed error codes work for you. Please note neo4jrb 9 exposed only a handful of those codes as their own exception classes.

@joshjordan just looked through the code. ClientException should have a code attribute e.g. Neo.ClientError.Schema.ConstraintValidationFailed. See https://neo4j.com/docs/status-codes/current/. Let me know if that's not working for you. I know it's an additional check within the rescue clause. However, there are over 120 such codes. Creating an exception class for each of them would be overkill.


Object coordinate system?

How do you define the object coordinate system ?

Do you know that now?

@QRayMoor Is this problem solved? If so, could you share your thoughts?


Fix broken builds for Docker 1.9 and 1.10 on TravisCI

These versions of Docker cannot start if there are old files left over
in /var/lib/docker/network. We delete the entire /var/lib/docker
directory to be safe.

Current coverage is 50.29% (diff: 100%)

Merging #496 into master will increase coverage by 0.06%

@@             master       #496   diff @@
==========================================
  Files            83         83
  Lines          3235       3235
  Methods           0          0
  Messages          0          0
  Branches        460        460
==========================================
+ Hits           1625       1627     +2
+ Misses         1459       1457     -2
  Partials        151        151

Powered by Codecov. Last update d00d53c...1ae4ed2


Add cert_dir option to kube-apiserver

Add cert_dir option to kube-apiserver.

@kelseyhightower  Thank you! I agree with you.

needs gofmt.

LGTM - merging.


App will not upgrade from 1.1.1 to 1.1.2 on macOS - "Some windows failed to close"

I tried to install the latest update from inside the app. It downloads but when clicking 'Install and Restart' you just get a dialog stating:

Unable to install update
Some windows failed to close

I tried manually closing all windows before doing the update but you still get the same error message.
Running on macOS 12.5.

Oh, and I should probably mention that the app was installed via homebrew in case that's relevant.

This will be fixed with version 1.2.0
Since the installation via homebrew ist just a wrapper for the DMG file, this should work fine


Keyboard is not working within the visual studio code

Keyboard is not working within the visual studio code
VSCode Version: Code 1.18.1
Operating system : win 8.1
It is working fine in my office machine but not in home machine please help me to solve this issue

@bilalMlaik
Can you provide more information.

Code does not react to any keyboard entry?
have you disabled all extensions?
any more information on the exact behavior?

vs code react to a few keys and do not react according to those keys behavior
no i have not disable all extension but i uninstalled a few extension to resolve issue but problem remain same
i think, one or more extension is doing problem because when i installed vs code it was working perfectly but after installing a couple of dozen extensions it started to behave incorrectly

@bilalMlaik As you have figured out, one of the extensions you have is causing the issue.
Please figure out which extension it is and log an issue in the repo for that extension


Error when training with GPU -  "Unknown linear updater grow_gpu_hist"

I have downloaded and installed CUDA, my GPU is benchmark "ASUS ROG strix OC 1080TI",
when the learning starts some console prints are shown (attached screenshots) some error messages and sometimes the program even crashes,
should i build the program in certain way/download CUB or something else i missed?
Please help!
thx,

Hi @gaop123
Installation of CUDA should be the only prerequisite to running the SharpLearning.XGBoost code.
Since the error message is "Unknown linear updater" it could sound like a configuration issue.
Could you provide the code of how the learner is configured/setup?
best regards
Mads

Closing this due to inactivity, feel free to open if this is still causing issues.


jaxlib.xla_extension.XlaRuntimeError: UNIMPLEMENTED: batch in most minor dimension

Description
I recently upgraded my JAX versions in a project from jax v0.4.10 and jaxlib v0.4.10+cuda11.cudnn86 to jax v0.4.14 and jaxlib v0.4.14+cuda11.cudnn86 and started seeing the following error on a piece of jitted code:
jaxlib.xla_extension.XlaRuntimeError: UNIMPLEMENTED: batch in most minor dimension

Unfortunately, I haven't been able to put together a minimal reproducible example and there are a lot of moving parts to the code, but I have noted the following behavior:

The code runs without error on CPU - it is only a problem on GPU.
When commenting out the return value of the function in question, the code runs without error:

@jit
def f(args):
    # many lines of code
    # return value  # when this is commented out, the code JIT compiles and runs without error

After bisecting on JAX versions, I've found that the error starts afflicting all versions >=0.4.11. What are some possible causes or further directions to look that might help yield a minimal reproducible example or fix?
What jax/jaxlib version are you using?
Working on 0.4.10/0.4.10+cuda11.cudnn86, not working on all versions >=0.4.11/>=0.4.11+cuda11.cudnn86
Which accelerator(s) are you using?
CPU and GPU
Additional system info
Python 3.10.12, Ubuntu 22.04
NVIDIA GPU info
Tested on two different machines. The output of nvidia-smi on each is
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 535.54.03              Driver Version: 535.54.03    CUDA Version: 12.2     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  NVIDIA RTX A6000               On  | 00000000:01:00.0 Off |                  Off |
| 72%   86C    P2             287W / 300W |  45861MiB / 49140MiB |    100%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+
|   1  NVIDIA RTX A6000               On  | 00000000:02:00.0 Off |                  Off |
| 68%   85C    P2             296W / 300W |  38173MiB / 49140MiB |     99%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+

and
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 530.30.02              Driver Version: 530.30.02    CUDA Version: 12.1     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                  Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf            Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  NVIDIA GeForce RTX 4090         On | 00000000:41:00.0 Off |                  Off |
|  0%   46C    P8               32W / 450W|    647MiB / 24564MiB |      0%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+
|   1  NVIDIA GeForce RTX 4090         On | 00000000:42:00.0 Off |                  Off |
|  0%   50C    P8               25W / 450W|     17MiB / 24564MiB |      0%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+

I'm running the code in a conda environment with cuda-toolkit v11.8 as some of the dependencies of this project are not compatible with Cuda 12.

Can you provide a minimal repro please?

I'm getting the same issue. I've managed to reduce it down to this:
import jax
import jax.numpy as jnp

def f(x):
    C = jnp.zeros((10,10))
    C = C.at[jnp.triu_indices(10)].set(x)
    A = jnp.dot(C,C.T)
    return A

@jax.jit
def g(x):
    return jax.vmap(jax.vmap(f))(x)

x = jnp.ones((10,3,55))
g(x)

Throws
XlaRuntimeError: UNIMPLEMENTED: batch in most minor dimension

Confirmed it occurs on my local machine and on Colab. The code works with CPU, but breaks on GPU. Also works if the jit is removed.

Thanks for putting together the minimal repro! I hadn't found the time to get around to it. I can confirm that this snippet throws the error on both machines tested above under the same conditions on version 0.4.14 (works without JIT on GPU, works on CPU with JIT, breaks with JIT on GPU).

No worries, it's been on my list for a while too.
Note I'm able to work-around this by flattening the batch dimensions. I.e. something like:
@jax.jit
def g(x):
    y = x.reshape(-1,x.shape[-1])
    z = jax.vmap(f)(y)
    return z.reshape(x.shape[:-1])

I filed an XLA bug (https://github.com/openxla/xla/issues/4833).

I still have this issue, even though the XLA bug seems to be resolved.

That's correct. The issue is fixed at jax head, but you'll need to either build jaxlib from source or wait until we make a new release. I suspect we'll make a new release this week, as it happens.
Hope that helps!


Vulkan: SSAO breaks visuals on AMD Radeon RX 570

Godot version
4.0.2
System information
Win 10, AMD RX 570 23.4.1 Driver, Vulkan
Issue description
Hey,
I played around with Godot 4.0.2 and SSAO unfortunately breaks the visuals completely. I think SSIL and SDFGI are also broken.
Here is the YouTube video if you happen to not have an RX 570
It works on my MX Linux Intel HD machine and on a Windows Nvidia GTX 960 machine, so I suspect it's an AMD exclusive issue.
Steps to reproduce
Start the game, press a few times space until you get to the game world.
Minimal reproduction project
The_Blood_Mage_4_0.zip

I have an RX 570 and am not experiencing the problem, and happen to be on Linux.
This seems to me like a problem with official Windows drivers specifically, then.

I updated to the recently released 23.4.2 driver and the problem still persists.

Unfortunately, the problem still persists with the new 23.5.2 driver

Could you test 4.3.dev2 under the same conditions to see if the issue is resolved there? Judging by this comment, that version might resolve the issue.

Yes, it is fixed!
What is a bit strange: My graphics card or some part of my pc seems to make like a noise now when the game is running which it didn't do before in previous versions but it's not so bad just weird.

My graphics card or some part of my pc seems to make like a noise now when the game is running which it didn't do before in previous versions

This is likely coil whine when running at high FPS. Do you have V-Sync disabled in the project (or forced to be disabled in the graphics driver control panel)? Check your FPS in the running project by enabling Print FPS in the Project Settings.

 I took an old version of the project and ported that and forgot that VSync wasn't enabled there yet. Thanks!


Final tweaks

Hi man, now, it's  lastest touch for totally update.
Please merge all PR from oldest to newest for make this pr more, you know, small.
Review it and feel free to change it, thanks you!

Ok guys, the changes in setup files is because installation, current installation, give me problems:

Current version, you can see a new python package: api, that have other packages, and a new folder, locale files folder. But, in the image can't you see these folders.
Now:

But with new setup file, all packages are installed.
Please, feel free to modify this and make it better.
Thank you!

Ok, as we have to delete admin taggable search i propouse use methods like class ImageQuerySet(SearchableQuerySetMixin, models.QuerySet) for search in admin.

@SalahAdDin what a mess...

Hi,
Thanks for all the commits guys.
We can't review that many commits in just one pull request, so we'll have to close this PR.
Also, the PR title should clearly state the purpose of all commits.
We are currently working on a branch that may solve some or all of your problems, including compatibility with Wagtail 1.9. Check https://github.com/tiagofmc/wagtail-embedvideos

@DiogoMarques29, @bashu, @lboaretto, i merged your pull request, now is completly.

@DiogoMarques29 , this is the best update now.


Support for markdown frontmatter

FrontMatter always used in markdown file for recording some infos, such as:
---
title: xxx
date: xxxx
tags: ["xxx", "xxx"]
---

and some other extensions can also use this FrontMatter's infos, such as "Nested tags".
Hope this wonderful extension can skip FrontMatter, or it will show wrong mindmap.
Thanks.

I want to use this together with Dendron, but Dendron becomes really unhappy if a .md file is missing the Front Matter, and the Front Matter currently ruins the outputted mind map 😢
In other words, a bit of a Catch-22 situation..

Came here to request this for integration with Dendron too!


Login failed still returns client

When the login flow fails, the scraper logs the error but keeps on chugging like nothing happened. There should probably be an exception raised or somehow indicate the failure to the caller of the constructors Search() or Scrape()

Initially this was done on purpose, basically allowing a guest session to be used as a fallback with limited endpoints. Now, due to the recent changes as of July 1 this is irrelevant, so I agree this should be modified to throw an exception rather than return a guest session.


Add dataflow and taint analysis test cases for class-defn

Description:
$subject
Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Fixed in #25637


Download the NYUDv2 dataset with segmentation and depth masks

Hi,
When I want to download NYUDv2 with segmentation and depth masks using the link provided (https://cloudstor.aarnet.edu.au/plus/s/pQY2sgg4fffGUYy), I can't find the file and the link seems out of date. Could you please check and update the link to the dataset?

Thanks a lot for your help!

Thanks for letting me know about that! Not sure why it happened.
Could you please try this one instead: https://cloudstor.aarnet.edu.au/plus/s/XJKtmOKcTEnANZt ?

Thanks a lot for your reply and help! This new link works well!


Provide support for PHP 7.2

We need to test against 7.2, and fix any errors observed.
Additionally, we can:

Remove support for HHVM
Add support for PHP 7.1

@weierophinney Everything here is done already on develop, see: https://github.com/zendframework/zend-stdlib/compare/develop

Resolved with release 3.2.0.


Allow Setting Path Rewrite Rule to Base URL

I absolutely love the Path Rewrite Rules functionality, allowing to set a custom folder structure for notes/pages on site.
However, it'd be even better if there was a way to set the path to be just the base URL. I.e., (using a custom domain) the test note could be set to show at mywebsite.com/test.
I've tried various ways to do so, just in case you'd already allowed it. I tried leaving the "garden path" (i.e., after the :) to be blank, and set it as a /, an *, or an @, but nothing worked. They all just stripped away the base URL, leaving, for example, https://test/.

Was this ever figured out or is it truly not supported?


Out of memory error when running self-trained CenterPoint

Hello, team
I recently met an issue when I try to run the CenterPoint model trained from Paddle3D on KITTI data. The GPU memory usage will over 10G and makes the perception module crash as the picture shows.

However, when I test the CenterPoint model file from this repository, the perception works very well and the GPU memory usage is stable at around 4G.
Note that I have modified the config of CenterPoint  according to the KITTI data. But I can't make the trained model work as expected. Could anyone help me to solve the problem?

when I test the CenterPoint model file from this repository, the perception works very well and the GPU memory usage is stable at around 4G.

The training config for CenterPoint on kitti train set is opened on Paddle3D repo:  https://github.com/PaddlePaddle/Paddle3D/tree/develop/configs/centerpoint, can you supply your training config file? The difference between yours and the kitti baseline (https://github.com/PaddlePaddle/Paddle3D/blob/develop/configs/centerpoint/centerpoint_pillars_016voxel_kitti.yml) maybe the cause why your gpu consumtion is !10G but the Paddle3D kitti baseline is ～4G.

@FlyingQianMM
Hi, Thank you for your reply!
In fact, I train the CenterPoint model using the config file from Paddle3D repo as you mentioned https://github.com/PaddlePaddle/Paddle3D/blob/develop/configs/centerpoint/centerpoint_pillars_016voxel_kitti.yml
There is more another question about your answer.  The CenterPoint model file (https://github.com/ApolloAuto/apollo/tree/master/modules/perception/production/data/perception/lidar/models/detection/center_point) provided by Apollo is trained on KITTI dataset? According to modules/perception/lidar/lib/detector/center_point_detection/params.h, I think the model is trained on nuscenes dataset. Please correct me if I misunderstand it.

I got the same issue while running the perception module with the model file from this repo. Downsampling pointclouds and disabling frame-fusing works for me, but I don't think it solves the underlying problem.

I got the same issue while running the perception module with the model file from this repo. Downsampling pointclouds and disabling frame-fusing works for me, but I don't think it solves the underlying problem.

Hi, what's the GPU configuration of your machine? It works for me when running the model file from this repo with the default configs.
@SeasoulChris @FlyingQianMM Any updates on this issue?

@SeasoulChris
Thanks for your advise!


Disable for mushroom bioms

I see that the support for toggling the overlay for mushroom bioms was removed again.
Is it just something you don't want to have? Or something in the implementation wasn't right and needed fixing?
If it's the first OK I wont bother you any more. If it's the second would like to work with you to make the implementation better.

It is no longer possible to detect mushroom biomes on the client anymore since mojang made the biomes data based.

oh, I didn't know that. how annoying.
It looks possible to extract the information some other mods are displaying the bioms.
I'll look into it.

the old code minecraft.level.getBiome(pos).getBiomeCategory() == Biome.BiomeCategory.MUSHROOM seams to work both on servers and locally on 1.17.1 I haven't tested with 1.17

That doesn't take in account the actual biome spawn settings, and unfortunately, some servers don't seem to send that.


FSIM_GATESET should support FSimGate(0, pi)

Is your feature request related to a use case or problem? Please describe.
Use case: it supports CZ gate but not FSimGate(0, pi), which is the same.
Describe the solution you'd like
Support FSim(0, pi)
[optional] Describe alternatives/workarounds you've considered
[optional] Additional context (e.g. screenshots)
What is the urgency from your perspective for this issue? Is it blocking important work?

P1 - I need this no later than the next release (end of quarter)

Please hold on with this feature (it might not be a Cirq issue in the end but a bug of some kind). I'll update this later.

Sounds good - thanks Wojtek

In the end, everything seems to be alright on the Cirq side!


Refactor ilu to ilurl

Remove experiments folder in favor of examples folder (as of flow).
Update directories to follow flow standards. e.g
experiments -> examples
envs/agents -> envs/green_wave_env
ql/ -> core/ql/
Recursively rename directories from ilu to ilurl (then we can integrate with other ilu participants)

Close as this issue has been addressed on 85837eb


Python3 replacing Python2

I don't think this is good enough to merge into master and we should probably set up a branch for this.
Most of the work here was made to figure out what needs to be changed to be able to support Python3 at all, very little thought as gone into the coexistence of both versions.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Caj Larsson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

With reservation for later found issues, it seems that the remaining issues are due to encoder/decoder differences that comes from python3 unicode and my implicit bytes usage for data.
I made the alphabet test run correctly by changing the decoder/encoder in the test source and validation to explicitly use convert to unicode.
It seems to me that this is as far as I can get without starting to make assumptions about the life cycle and responsibilities in the integration test development. This is probably a good time to squash this up a little and then put it in a python3 branch, then we can take a deeper look at what compromises should be made to move forward.

Or maybe it is time to make that machida3, split the code base and work towards test parity

Or maybe it is time to make that machida3, split the code base and work towards test parity

@aturley and I agree this is the approach we prefer.

Closing this in favor of open a new PR with the machida3 approach


Added fetchTime to Page

Please rebase your commit for a more easy view of the changes. Is it possible to add some tests? Also, I would suggest to add a timeUnit to your variable, as it is not clear without the source code, that you measure the time in milli seconds.

I don't see any value in this. We call the visit method as soon as a page is fetched. You can just get the current system time there which is very close to the page fetch time.

Oh I think fetch time is the wrong term. I think it should be called load time of the page. I'm interested in the time it took to fetch the page...


revert changes that broke perl unit tests

Perl changes in #1889 broke unit tests.   Selectively added back code needed for that to pass again.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1494/
Test PASSed.


MAGICK_RELEASE_DATE = datetime.date(*map(int, _match.groups()))     AttributeError: 'NoneType' object has no attribute 'groups'

It seems OpenSuse Tumbleweed does not put the MAGICK_RELEASE_DATE in their packages. All of these settings cause the installation to fail on Tumbleweed. Once they are set to empty strings it works fine.
Collecting Wand==0.4.4 (from -r requirements.txt (line 127))
  Using cached Wand-0.4.4.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-y6uvl9ue/Wand/setup.py", line 8, in <module>
        from wand.version import VERSION
      File "/tmp/pip-build-y6uvl9ue/Wand/wand/version.py", line 110, in <module>
        MAGICK_RELEASE_DATE = datetime.date(*map(int, _match.groups()))
    AttributeError: 'NoneType' object has no attribute 'groups'

What's the output of convert -v | head -1 on the system?

Version: ImageMagick 6.9.7-7 Q16 x86_64  http://www.imagemagick.org

Thanks for this, and sorry about the delay. Looks like the package maintainers fixed the missing date already, but have already moved to ImageMagick-7. Patch eaa4dc8 fixed the AttributeError exception.


window splits - adding 5th panel hangs app

please add a bit more details?

Was 100% reproducible but now never happens - closing

Oh, and it should have read adding 6th panel hangs app


Modify rotate gesture handler to apply rotation around gesture center

Fixes #456

This works great. Looks good for merge.

yep, working nicely!


Feature Request : When click on ContributionsRow, navigate to the GitHub user page.

Is your feature request related to a problem? Please describe.
First of all, thank you very much for developing this wonderful app. Now, let's get to the main point. Currently, there is no click event set for ContributionsRow, but I would like it to be configured so that when clicked, it navigates to the corresponding user's GitHub account page.  I look forward to your response.
Describe the solution you'd like
When ContributionsRow is clicked, navigate to the GitHub account page of the corresponding user.

Hey @hyphen-o, thanks for your suggestion! That's actually a great idea and should be quite easy to implement, will see if I can prepare something.

This is now implemented 0b874bbe278db4df2c1bda0d47f9c8d0cccff60d, it will be available in future releases 🎉

YAAAAAS!🥳

thank you!!🥰🥰


fix(migrations): encode input to ensure valid postgres urls

Background
When passwords (or other parameters) contain special characters (such as % in a password), it will result in invalid postgres url's
Description
The change encodes all injected input parameters, I can remove some if you think its unnecessary.
Checklist

[x] Input validation
[ ] Output encoding
[ ] Authentication management
[ ] Session management
[ ] Access control
[ ] Cryptographic practices
[ ] Error handling and logging
[ ] Data protection
[ ] Communication security
[ ] System configuration
[ ] Database security
[ ] File management
[ ] Memory management
[ ] Testing

@n1ru4l Thanks for your feedback! I've modified the other places to include the logic, I've also made password optional, since some authentication mechanisms allow disabling of password based login (such as in Azure with Workload ID's on Kubernetes)


QuickFIX like configs

what I like about QuickFIX is it's configuration model - one can do a lot with just changing session parameters to connect to a new venue. would be great to have something similar

Sounds good! Can you elaborate a little on the strengths of QuickFIX/J? I have to admit that my experience with it is quite limited.
In Philadelphia, session configuration is set via the FIXConfig class. Custom fields and messages are also supported as Philadelphia, unlike most FIX engines, enforces neither field types nor message schemas. (See the FIXValue and  FIXMessage classes for details.)

http://www.quickfixj.org/quickfixj/usermanual/1.5.3/usage/configuration.html
see the example in the bottom. actually drop-in replacement of QuickFIX/J would be great in terms of configs.
what i like is

you can set pretty much any standard header tag in the config
default section is very useful, no need to repeat definitions
you can set session storage parameters - location, etc
you can set socket options used
advanced features like failover hosts, etc

@divaykin Wondering if you can contribute this in a very permanent way.

In my mind I have classified features such as trading schedule, reconnection mechanism, and message persistence as well as message validation as optional. They are something that could definitely be built on top of Philadelphia, but I would keep them out of the library core.
Of course a Philadelphia-based drop-in replacement for QuickFIX/J would be great from a marketing perspective. :wink:

Closing this, because at the moment it feels unlikely that Philadelphia could be used as a drop-in replacement for QuickFIX/J. (There were some attempts at that a few years ago.)


Modified pull request github action

make the pull request github action don't build kaldi.

@wangyu09 I remove the kaldi build on github action when push to master. Please merge when this test is passed.

@wangyu09 I remove the kaldi build on github action when push to master. Please merge when this test is passed.


[FEAT]: thread coarsening for larger msm sizes

Description
The current msm.cu implementation launches a monolithic kernel in several places like this:
unsigned NUM_THREADS = 1 << 10;
unsigned NUM_BLOCKS = (total_nof_buckets + NUM_THREADS - 1) / NUM_THREADS;
initialize_buckets_kernel<<<NUM_BLOCKS, NUM_THREADS>>>(buckets, total_nof_buckets);

This assumes the GPU has enough threads to process every element. Grid-strided for loops allow processing more data than GPU threads by making each thread do more work, and potentially allows maximum memory coalescing on larger inputs since we are continuously accessing consecutive memory. I think this should be one of the easier fixes to efficiently enable larger msm sizes.
Working on a pull request but getting comfortable with the msm Rust binding for testing first.
Motivation
From the icicle Discord I see "msm for large sizes" is a sprint priority.

Looks cool! I've solved some bugs in the MSM and will merge them this week, this should enable experimenting with larger sizes and adding optimizations such as this one.


[SPARK-6363][BUILD] Make Scala 2.11 the default Scala version

This patch changes Spark's build to make Scala 2.11 the default Scala version. To be clear, this does not mean that Spark will stop supporting Scala 2.10: users will still be able to compile Spark for Scala 2.10 by following the instructions on the "Building Spark" page; however, it does mean that Scala 2.11 will be the default Scala version used by our CI builds (including pull request builds).
The Scala 2.11 compiler is faster than 2.10, so I think we'll be able to look forward to a slight speedup in our CI builds (it looks like it's about 2X faster for the Maven compile-only builds, for instance).
After this patch is merged, I'll update Jenkins to add new compile-only jobs to ensure that Scala 2.10 compilation doesn't break.

Note: I'm happy to defer merging this pull request for a while. I just happened to have the changes ready locally and figured that it would be nice to test them on Jenkins.

Test build #48796 has started for PR 10608 at commit 623a929.

Test build #48796 has finished for PR 10608 at commit 623a929.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48796/
Test FAILed.

Merged build finished. Test FAILed.

Test build #50218 has started for PR 10608 at commit 18c5223.

Test build #50218 has finished for PR 10608 at commit 18c5223.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50218/
Test FAILed.

/cc @srowen @pwendell @yhaui for review

That looks like what I'd expect -- roughly what you get from running the change-version script and updating the list of dependencies?

Jenkins, retest this please.

@srowen, yep, this is pretty much just the result of running the version changing and dep update scripts, followed by a grep through the documentation and build to invert all of the directions and build scripts.

Test build #50236 has started for PR 10608 at commit 18c5223.

Test build #50236 has finished for PR 10608 at commit 18c5223.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50236/
Test FAILed.

Want to fix the mima issue?

Test build #50321 has started for PR 10608 at commit 8dd36ab.

Test build #50321 has finished for PR 10608 at commit 8dd36ab.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50321/
Test FAILed.

Jenkins, retest this please.

Test build #50343 has started for PR 10608 at commit 8dd36ab.

Test build #50343 has finished for PR 10608 at commit 8dd36ab.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50343/
Test FAILed.

These look like legitimate test failures. It's a little tricky to reason about which ones might be caused by this patch vs. longstanding 2.11 compatibility issues because it turns out that we don't actually run the entire test suite against Scala 2.11 but only test compilation.
A lot of the failures seem to occur in HiveThriftBinaryServerSuite; it seems that we time out while waiting for the server to start. I wonder whether there's a transitive dependency change in that subproject which might have caused this.

Looks like the problem might be related to https://github.com/apache/spark/pull/9816: I think that the REPL log level is being set to WARN, preventing the suite from finding the log messages which indicate that the ThriftServer started up.

I think I found the problem: looks like Utils.isInterp() was returning true even in non-interpreter code because of a small difference in how the 2.11 REPL works.

Test build #50367 has started for PR 10608 at commit 2c901e5.

Test build #50367 has finished for PR 10608 at commit 2c901e5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50367/
Test FAILed.

Merged build finished. Test FAILed.

Test build #50401 has started for PR 10608 at commit d24c31d.

Test build #50401 has finished for PR 10608 at commit d24c31d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50401/
Test PASSed.

Okay, I think this should now be ready for final review and sign-off.

It's a bit hard to know whether the repl changes make sense or not, but I think we just need to try it out and see if problems come up.
LGTM.

Merging this in master. Hopefully compilation will be faster.


Synchronization and Concurrency in K3.6

I have threads with a certain property in my environment, and I need a certain rule to apply to all of them at once. I assumed that rules will apply concurrently whenever they can as long as no shared writing was involved, but my experimentation tells otherwise.
rule [1]: <thread>...
   <k> synchMe(K) => synchMe(doSomething(K)) </k>
   <flags> .Set => SetItem("Done") </flags>
...</thread>

// doSomething is processed in a separate rule

rule [2]: <flags> SetItem("Done") => .Set </flags>

What I want is for rule 1 to apply on all such threads and then for rule 2 to do so, but what is happening is that rule 1 applies and then rule 2 for each such thread. I tried to say "when all such threads are done" using the #configuration function as was suggested in #1836, but that hasn't worked for me yet.
My question here is very general: how do you synchronize threads in K? And why don't rules apply concurrently when they can? Hasn't K been boasting about concurrency with shared reads?!

Applying them concurrently in each thread is a possible order that should be found by --search, but nothing in your definition prevents the second rule from applying earlier. Sounds like you need to ask @cos about strategies.

@bmmoore, I don't understand that last long sentence. Please rephrase it.
And regarding --search, correct me if I'm wrong, but it won't explore different possible order of applying rules unless these rules are declared transitions.

I think in the current version --search should work without declaring things transition.
The concurrency feature in K is being able to decide that two rules can apply at the same time because any parts of the configuration which both match are used in read-only ways. This is not at all the samething as somehow implicitly banning executions that decide to run the rules separately. K allows more concurrency than other frameworks, but it doesn't force all possible concurrency to execute synchronously. That would be incorrect anyway - suppose two threads are ready to read from the heap and one was going to modify it. If K's "boasting about concurrency with shared reads" somehow meant that the reads were forced to execution together, than the semantics would miss the possible execution where the write is interleaved between them.

@omarz1, you can do that using the strategies functionality on master. Declaimer: it's very much experimental, and you'll lose performance for now. If you want to try that, let me know and I'll help with making it work.

I understand now. Thank you.

@cos, this is the third time you tell me to use master. So I'll try to clone and compile it today.

Yes, @omarz1 , we are on a fast track to release K 4.0, and we do not have any resources left to improve or maintain other versions.

@grosu, I just needed to produce some results for my research and I couldn't risk updating at that moment. Now I can and I will. You'll know when you see me reporting bugs :smile:.


Updated to libGDX version 1.7.0.

It includes a fix for the way the mouse cursor is loaded, especially on Windows. This fix may help, but it also opens the way to change the way the mouse cursor is loaded, if we need to go that way.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/DestinationSolPRs/8/
Hooray Jenkins reported success with all tests good!

Tested it out on Win7 and Android. Looks good and nice to see some movement again :-)
Haven't tested on my Win8 tablet or dug through the assorted mouse related issues, bit sick and not spending too much time on computer stuff


Two notification questions/requests

This module seems to have been built largely off of the default Weather module.  I have another module (MMM-RAIN-MAP) that is triggered off the default weather module's WEATHER_UPDATED notification, which means I have both this module and the default Weather module making API calls to OpenWeatherMap.

Would it be easy to change this module to send and receive the same WEATHER_UPDATED notification that the default Weather module does either in addition to or instead of the the WEATHER_ALERTS_UPDATED notification that it currently uses?  I'd be happy to do a little coding and a PR for this, but I wanted to make sure it was possible first, and maybe get pointed in the right direction by someone familiar with this module.

In a somewhat contradictory request, I'm wondering whether it's possible to have this module receive alert notifications from the MMM-OpenWeatherMapForecast module instead of directly from the API.  Is there a notification that module sends that could be used?  And if not, what do I need to code into that app to get this app to react off a notification from that one?  Again, happy to do a little coding if necessary.

I'm just trying to cut down on the number of modules making independent API calls to OpenWeatherMap.
I'm not great with javascript, so I don't know how to easily output or capture the various notifications that are flying around from these apps to see how similar/different they are.  If anyone has a suggestion, let me know.

Hi, thanks for the comments. It may be possible to eliminate the need for a separate API call by using the module "notification" system (https://docs.magicmirror.builders/development/notifications.html). What I don't know is if modification to the default weather module is required.
I'm busy with work this week, but will try to find some time to see what the implementation would look like. I saw your other comments relative to Kristjan's project. I will review your PR and see about pulling into main. Thanks.


isImageCached CacheCheckResult redundant fields

Thanks for the library. A suggestion:
Right now ImageCache.isImageCached returns a CacheCheckResult which has a bool isCached and an optional enum which has 3 cases - disk, memory, none
isCached == false is covered by the none case
CacheCheckResult should just return a CacheType - right now to deal with the result you check the isCached, unwrap the enum, and then still have to deal with the .none case
if just returning the enum can just deal with the 3 cases

I think you are right on this. I'll give it a change later. However, instead of breaking the current API, I prefer to add a new one and mark current one as deprecated.
Thanks for the suggestion!

Fixed in #741 and will be contained in Kingfisher 4.

sweet!


[Feature Request] Ability to provide specify format or generation of timestamps (ISO8601, specifically)

I looked through all the code involved in timestamps and the issues involving timestamps and was a little shocked to learn that there is no way to specify the format of the timestamps. The schema defaults to Date.now but it would be absolutely incredible if we could specify something different, like Date.toISOString. A long string of numbers has no at-a-glance value whatsoever unless you are armed with a conversion calculator. Having ISO8601-compliant timestamps would add tremendous at-a-glance value to the data and eliminate the need for conversion to/from that format when interacting with the database.
I am interested to hear your thoughts, maybe there is something I missed in the process of that feature getting added!
Edit: Just wanted to let the record show that I'm aware how trivial the conversion of Unix timestamps to ISO8601 compliant timestamps is (see related SO post) but I am talking here about avoiding the whole thing in principle by moving the responsibility of that conversion to the ORM.
Edit 2: I'm struggling to find a clean way of doing this and my options are pretty much zero. Tried an instance method, it strictly adheres to the type Date. Looked at virtual properties, zero documentation. The words method, static, and virtual are completely absent from the entire readme. So, this is actually becoming a cry for help.

Hello @brandongoode! No worries on either count, I got things worked out and ended up just reading through the pertinent parts of the code (which, incidentally, is a pretty great substitute for a readme).
In a stroke of luck on my end, the current use case I (and my team) have for dynamoose ended up just being a single field updatedAt, which I defined as follows:
updatedAt: {
    type: String,
    default: Date.toISOString
}

And I simply set that field manually on instantiation of the model (updatedAt: new Date().toISOString()).
I let my frustration get the better of my tone when I opened this issue, I didn't intend to sound so combative!

Glad you got it working.  I didn't take it as combative (we've all been there).


How to modify the FilePath?

I am using PHP with MAMP and i need to change the path of the file that appears in the browser. How can i do that please?

@gbouvyer Did you ever figure this out? I need to do the same.

Did you guys figure this out, if now are you requesting a feature in which you can enter the url in which a file would open in?


bpf: ipsec: select fresh SPI when falling back to TUNNEL_MAP

If for some reason we fall back to the TUNNEL_MAP to select the remote tunnel_endpoint, respect the SPI in the map entry. And discard whatever SPI was selected earlier based on the ipcache entry.

/test

Pursuing this a bit further in https://github.com/cilium/cilium/pull/34756, let's see what that brings.

Just one question for my understanding: in what cases we'll need to rely on the tunnel map lookup fallback? My local cilium has tunnel map like:

Louis did some detective work in https://github.com/cilium/cilium/issues/20170 - the idea is basically to have per-node CIDR entry which allows us to handle pods that haven't propagated into the ipcache (yet).


Local activity support for next-retry-delay

Describe the solution you'd like
Re https://github.com/temporalio/features/issues/419, it was decided we need to support next retry delay in application failures from local activity too. Implementation details are still pending.

closed by https://github.com/temporalio/sdk-java/pull/2081


Add files via upload

Thanks for your contribution but I won't merge the pull request because a lot of the wallpapers are very different to the style I want, they aren't ordered inside the "images" folder and I couldn't view all the wallpapers because they're a lot and you didn't add them in the README.md


Make footer buttons configurable

The visibility of the mail support and wiki needs to be configurable.
So the styling needs to be changed accordingly. This will also
allow the options to be tested with the functional testing feedback
controller.
In order to test this you could use the following parameters:
supportEmail string
showWikiButton bool
Also the background offset didn't work as expected when the viewport size
was bigger then 100%. This was boyscouted.

https://www.pivotaltracker.com/story/show/164121204

This might also be a nice place to add usage information about the feedback test page in docs/js_testing.md

I've created a PR with the tests for the footer:
https://github.com/OpenConext/OpenConext-engineblock/pull/692
I don't want to spend a lot of time on this at this moment. I will write the documentation when we get the results back from @arnoutt regarding the configuration of the different exceptions and the contact address in the footer.

Reverted the wiki logo

I did revert the package.lock it changed because of the tar resolution. Hopefully that gets fixed soon.
Added a note to the description of the PR about the .gitignore.


Prevent layout shift select

Currently when one selects 2nd or later option the component renders tags which shifts the layout causing one to select the 1st or previous option.
https://user-images.githubusercontent.com/17263/207711685-6c092a0d-7ccd-4a74-97e4-81b1fa5887b6.mov

@micheal-parks how's this?
https://user-images.githubusercontent.com/17263/207712829-85a7a59b-79e9-401d-8b4f-f9684e8314a7.mov


[Rippled do not follow limit values as per documentation in many API's] (Version: [1.11.0-rc2])

Issue Description
As per documentation for account_channels, Limit cannot be less than 10 or more than 400 but rippled do not follow this boundary values.
Steps to Reproduce
Provide limit value less than 10 or greater than 400.
Expected Result
invalidParams error
Actual Result
No error
Environment

Supporting Files

As per documentation for account_objectslimit must be within the inclusive range 10 to 400 but rippled do not follow this boundary values.

Issue exists for account_offers also.

The API behavior is fine; this is something that should be clarified in the docs. Closing this issue in favor of https://github.com/XRPLF/xrpl-dev-portal/issues/1985


#2256 Mobile-first experience

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[ ] Feature
[x] Refactoring

What's new?

[x] PR closes #2256
[ ]

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address:
Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Let's make it full-width edge to edge on mobile phones :)

@yangwao done

Let's move previous and next button to edge and fullscreen to corner and we are good to go!

@yangwao doneee

oh yeah, love it!

pay 150 usd

😍 Perfect, I’ve sent the payout
💵 $150 @ 187.07 USD/KSM ~ 0.802 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x24a1529e5dd5b0b7b8e9b8391a7a4cd6804465968283551bb03187cd38c7793c
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


ui: Add animation support for the edited/moved marker.

This is a sequel to #762 that animates the swipe gesture.

https://github.com/zulip/zulip-flutter/assets/39874143/ba3573bc-7932-498f-88cf-56e68812c9d1

Incorporating @chrisbobbe 's comment, we animate the marker from the start state to the end state as follows:

margin left
margin right
paddings (horizontal symmetric)
distance between marker text and icon

Start
5px
3px
0px
0px

End
13px
3px
3px
5px

where the paddings are the distances "between the left edge of the rounded-rectangle and 'Edited'" and "between the icon and the right edge of the rounded-rectangle", the margins are the distance between the rectangle to the left of the screen and to the message content, respectively.

Rebased since #762 has been merged. We will need to get back to this later to investigate alternatives to LayoutBuilder.

My review is next, I think, right? I've just added "maintainer review" so I don't lose track of it.

Yeah, this is not ready for review yet, but I will let you know once it is.

Marked as draft because that makes it easier to remember (particularly when looking at a list of PRs) which PRs have become ready for review :slightly_smiling_face:


create QR code for current app on device

Would be great to generate a QR code of an application on device. Makes it possible to share the app.... or scan with other device.

Other apps set the device brightness as well.... temporary


Get Maxinmum Maze Paths

💥 Proposal
Count number of ways to reach destination in a Maze.
Greetings sir/Mam,
I would like to contribute the code for this issue in java.
The code is ready. I have added the code , along with proper explanation of the algorithm , test cases , time complexity and space complexity of the same, as per the guidelines.
Kindly assign it to me.
This is regarding GSSOC'21.
Regards,
Hitain Kakkar
Have you read the Contributing Guidelines on Pull Requests?
YES

/assign

/assign


3D Camera, multiStreams issue

Hi muaz-khan,
I'm building a 3Dsbs (like Google Cardboard) App and i need to use 2 streams from 2 webcams.
Everything is working fine if the initiator and the peer join with the same browser BUT if the peer use different browser than the initiator for more than 1 stream the offer is crashing...
Initiator on Firefox & peer Joins from Chrome:
rmc3.js:3904 sdp-error Failed to initialize the answer.
(anonymous function) @ rmc3.js:3904
Initiator on Chrome & user Joins from Firefox:
InvalidStateError: setRemoteDescription not called.
I'm using version 3.3.2
Any plans checking on this issue?!
(Thanks for the this awesome tool!)
kind regards,
Alex

Multi-stream works fine Chrome-to-Chrome and Firefox-to-Firefox. I'll check & fix cross browser issues, at least streams that are coming form Firefox. Firefox isn't good as a receiver.


Update some minor rendering errors in the docs

See: https://northern-tech.slack.com/archives/C0XM0KX9C/p1576612577017000 for details.

Changes look good, though have not tested if it renders correctly

I did a look through, and it fixes the two mentioned errors when run with the mender-docs-site container locally.
Merging.


Add clipping, backbuffer, and CanvasGroups to 2D GLES3 renderer

As well as significant consequent cleanup in the RenderTarget, Texture, and Canvas renderer code
For the backbuffer and canvasgroups I did not add the usual gaussian blur as it performs really poorly on mobile. Despite the blur itself being quite optimized, the overhead of switching the rendertarget so many times really hurts performance. Instead I have implemented a series of blits that minimize framebuffer changes and use hardware accelerated downsampling. This should be about as fast as mipmap generation can be on this hardware.

Rebased to resolve conflicts.
@akien-mga Do you mind merging this soon to unblock my work on 2D?

@clayjohn You should pester @godotengine/rendering contributors to approve your work so I'm not the bottleneck :P

Thanks!


Automate setting up a new userstyle

Is there an existing issue outlining your problem?

[X] I have searched the existing issues and they do not solve my problem.

Describe your issue.
Currently, when creating a new userstyles, users have to follow the steps in https://github.com/catppuccin/userstyles/blob/main/docs/userstyle-creation.md. some of which can be automated.
I suggest adding a new cli script/tool that:

takes the website name as input
creates a styles/<name-of-website> folder in lower-kebab-case
copies the template folder content into the new folder
modify the usercss metadata by replacing <port-name> with the website name (capitalized or lower-kebab-case when appropriate)

It probably needs to be built using typescript like the other scripts but i'm unfamiliar with it

I don't think we currently plan on adding that functionality to this repository directly. I've made a separate CLI tool you can use though, https://github.com/uncenter/purr! The command for what you are describing would be purr init userstyle, though there is lots more functionality :)


fix: can't sync temporal flag on virtual table

SUMMARY

Currently, the virtual table is unable to sync is temporal flag. This is due to the SupersetResultSet response is_date instead of is_dttm. We should keep the physical table and virtual table have the same interface.
In this PR also introduce a new type superset.superset_typing.ResultSetColumnType to guarantee type checking.
I will address a separate PR to finish PhysicalColumnType.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
https://user-images.githubusercontent.com/2016594/160112782-20110704-6a84-4004-b8d2-3c889871b2a1.mov
TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up

I tested the PR locally, is temporal can be sync as expected, but when i save the changes, i saw error msg
https://user-images.githubusercontent.com/81597121/160926244-a9bcd466-3a04-474f-b76f-ae32421a4174.mov

I tested the PR locally, is temporal can be sync as expected, but when i save the changes, i saw error msg
Screen.Recording.2022-03-30.at.1.34.07.PM.mov

This is an unrelated issue with current PR. I have opened a separated PR to fix it.

Love it, thanks for this fix + nice cleanup! In the long run I feel we should start moving types from superset/superset_typing.py into the packages where they are most relevant (see e.g. superset/key_value/types.py), but that can be done in a follow up (e.g. the one planned for physical columns)

sounds good! I will follow this pattern in future.

🏷 preset:2022.13


Error "cannot start a transaction within a transaction" on cached connection

Assuming we run this piece of code:
			ctx, cancel := context.WithCancel(ctx)
			tx, err := db.BeginTx(ctx, nil)

it is possible to get at the same time context.Cancelled error and started transaction. This will happen only if we cancel context very fast.
This happens because context cancellation is inherently racy as performed not in same go-routine where statement is executed.
Proposed fix #765

@azavorotnii If I understand your bug report correctly, this is not a bug with BeginTx specifically, but rather some faulty logic in (*SQLiteStmt).exec.
https://github.com/mattn/go-sqlite3/blob/590d44c02bca83987d23f6eab75e6d0ddf95f644/sqlite3.go#L1893-L1905
The existing code erroneously concludes that if we called sqlite3_interrupt, then the pending operation will definitely fail so it doesn't bother looking at the result. This is flawed (1) because of the inherent raciness, and (2) because the SQLite docs themselves say that sqlite3_interrupt will not necessarily interrupt a pending operation. "If an SQL operation is very nearly finished at the time when sqlite3_interrupt() is called, then it might not have an opportunity to be interrupted and might continue to completion." https://www.sqlite.org/c3ref/interrupt.html
I believe the correct fix would be to not just discard what gets pulled from resultCh and instead only return ctx.Err() if we receive SQLITE_INTERRUPT from the actual operation.
I have also sent a question to the SQLite mailing list about the behavior when BEGIN gets interrupted to see if we need to explicitly roll back in that case or not.

I believe the correct fix would be to not just discard what gets pulled from resultCh and instead only return ctx.Err() if we receive SQLITE_INTERRUPT from the actual operation.

@rittneje that was my initial thought, but for some reason instead of SQLITE_INTERRUPT I got SQLITE_DONE. That could be race in my test setup though. Let me check again.

@rittneje done as you proposed. I did mistake in my initial test, now it should be stable.


Patch proposal checkout error

Attempting to checkout a patch proposal that is already checked out results in error:

@JChrist can you please also add an estimated size here, so we can prioritise accordingly?


[Manage attachments] need to remove "Max selected files is 0." label

Please remove "Max selected files is 0." label from the screen.
Open Attachments from chat panel when there is a chat with any model without attachment functionality is on the screen

Verified on staging successfully.


Ensure prefixed/suffixed inputs are accessible

When focusing on a prefixed/suffixed input before there was no mention of the contents of the <abbr> tag. I've tacked this by adding a title attribute to the input with the title value form the <abbr> tag, and added aria-hidden="true" to the <abbr> to prevent the screen reader from focusing to it as the user moves to the next item. Combined with a <label> for the input this seems like the best experience, although its worth everyone having a go at testing this themselves to see what they think.
Components to test

[ ] Prefixed
[ ] Suffixed
[ ] Durations (example of suffixed in a <fieldset>)

 Prefixed/Suffixed inputs are not fully accessible


segmentation fault in ctc_decode function

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v2.2.0-rc4-8-g2b96f3662b 2.2.0
Python version: 3.7.6
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Describe the current behavior
Segmentation fault occurs in tf.keras.backend.ctc_decode when passing a large value for top_paths and setting greedy to False. If it is far large enough to be out of range of int32, the function handles the error properly by throwing an exception in python, but when it is around the boundary of the range, the function produces a segfault.
Describe the expected behavior
No segfault.
Standalone code to reproduce the issue
import tensorflow as tf

y_pred = [[[4.7, 3.2, 2.8],
        [4.9, 1.0, 3.0]],

       [[3.9, 3.8, 1.4],
        [1.0, 1.6, 3.8]],

       [[4.0 , 4.5, 3.9],
        [2.2, 2.2, 4.5]]]
input_length = [3, 2, 2]
top_paths =<PHONE_NUMBER>

tf.keras.backend.ctc_decode(y_pred, input_length, False, 100, top_paths)

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
Segmentation fault (core dumped)

Colab session crashes after using all available RAM. Tested with TF version 2.2.0

Fixed https://github.com/tensorflow/tensorflow/commit/23693102bf820cbed93b7be0cf43f44db9faca02


Performance improvements for large up-to-date builds on machines with many CPU cores

Fixes #?
Context
Another round of improvements to improve scalability with number of CPU cores when there is very little work to do in the build.

Improve efficiency of selecting node to execute
Remove ordinal nodes that aren't actually used (these can have a huge number of dependencies, which are expensive to track), including duplicates when loading from the configuration cache.
Don't schedule the nodes when loading from the configuration cache, as they are already scheduled.

Also refactor ExecutionPlan to split it into a mutable ExecutionPlan and a finalized unmodifiable  FinalizedExecutionPlan.
Contributor Checklist

[ ] Review Contribution Guidelines
[ ] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[ ] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass sanity check: ./gradlew sanityCheck
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

OK, I've already triggered a build for you.


Added info on Harvester node driver ISO images

Closes #3889

I approved based on the text on Rancher docs as it seems it will not be implemented at all. However, if something is planned to show the .ISO in Rancher UI, then maybe we should add a note about the support coming in a later version?


listen blocks manual numeric value change

here you can't change value2 :(
sliders work, but manual change is blocked

here is my workaround

This issues is similar to #101. It has been fixed in ca19030081d8039d5f6b25ca399caa029dd2afc7


Update : About Us

Let's update some content in About Us with some style to the content and also some description about the  game to make the user interact efficiently.

Assign me this issue under SSOC24 @Dev-tanay

Hey @Dev-tanay
Can this issue be assigned to me for GSSOC'24
Regards,
V Meenakshi Iyer


GE HealthCare IoMT Privacy

[ ] Prep for meeting with Hayden Pritchard and his team for a deep dive on our IoT Security offering and sshNoPorts
[ ] Follow up with his team on opportunities/partnerships/POCs

[ ] Prep for meeting with Hayden Pritchard and his team for a deep dive on our IoT Security offering and sshNoPorts
[ ] Follow up with his team on opportunities/partnerships/POCs

Meeting complete with GE Healthcare. Have followed up. Waiting on next steps.


Missing dependency on [xComputer]DomainJoin in Small Farm example

First of, thanks for the great work you guys are doing!
Details of the scenario you try and problem that is occurring:
I've been playing around with the Small Farm example:
xSharePoint/Modules/xSharePoint/Examples/Small Farm/SharePoint.ps1
I'm getting issues on the dependency "[xComputer]DomainJoin"
I've found I had to add the xComputerManagement resource;
Import-DscResource -ModuleName xComputerManagement
And implement DomainJoin in the configuration section as follows:
		xComputer DomainJoin {
			Name = $Node.NodeName
			DomainName = $ConfigurationData.NonNodeData.DomainDetails.DomainName
			Credential = $domainAdminCredential
		}

This resolved the issue for me. Either I didn't get something about how to set everything up, or there was a missing dependency. The first option seems likely.
The DSC configuration that is using the resource:
Version of the Operating System and PowerShell the DSC Target Node is running:
Server 2012 R2 Data Center, PS5, SP2016
Version of the DSC module you're using:
Current

@jsteenbeek Thanks for reporting - we meant to take this out of the examples (so we focused on providing examples of just our resource and not the dependencies). I'll add this to the bug list and will get the examples cleaned up.

This is resolved in our 1.0 release branch (attached to #304). We will merge it back to dev after it's finalised for release and then close this issue off

Closing this issue as it has been resolved in #304 - thanks guys


Development

Codecov Report

Merging #21 (7f7d4dd) into master (af78397) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   86.39%   86.39%
=======================================
  Files          13       13
  Lines        1117     1117
=======================================
  Hits          965      965
  Misses        152      152

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af78397...7f7d4dd. Read the comment docs.


Almost all tests fail when using python3

Python2 will be sunset fairly soon (see here).  This is causing at least one of shaderc's user to start moving to a python3 only environment, so we had to update shaderc and spirv-tools.  That particular user does not include spirv-cross, so it is not a big deal for now.  However, it might be needed pretty soon, as more people will be force to switch.  It is possible to get it fixed?  I have not looked into how big the change would have to be.
I have include the command I used to configure the project, and the output from ctest.
cmake -GNinja -DCMAKE_BUILD_TYPE=Debug -DPYTHON_EXECUTABLE:FILEPATH=/usr/bin/python3 ..
ninja
ctest

Test project /usr/local/google/home/stevenperron/spirv/SPIRV-Cross/build
      Start  1: spirv-cross-c-api-test
 1/11 Test  #1: spirv-cross-c-api-test ...........   Passed    0.09 sec
      Start  2: spirv-cross-test
 2/11 Test  #2: spirv-cross-test .................***Failed    0.70 sec
      Start  3: spirv-cross-test-no-opt
 3/11 Test  #3: spirv-cross-test-no-opt ..........***Failed    0.18 sec
      Start  4: spirv-cross-test-metal
 4/11 Test  #4: spirv-cross-test-metal ...........***Failed    0.29 sec
      Start  5: spirv-cross-test-metal-no-opt
 5/11 Test  #5: spirv-cross-test-metal-no-opt ....***Failed    0.19 sec
      Start  6: spirv-cross-test-hlsl
 6/11 Test  #6: spirv-cross-test-hlsl ............***Failed    0.19 sec
      Start  7: spirv-cross-test-hlsl-no-opt
 7/11 Test  #7: spirv-cross-test-hlsl-no-opt .....***Failed    0.19 sec
      Start  8: spirv-cross-test-opt
 8/11 Test  #8: spirv-cross-test-opt .............***Failed    0.49 sec
      Start  9: spirv-cross-test-metal-opt
 9/11 Test  #9: spirv-cross-test-metal-opt .......***Failed    0.49 sec
      Start 10: spirv-cross-test-hlsl-opt
10/11 Test #10: spirv-cross-test-hlsl-opt ........***Failed    0.28 sec
      Start 11: spirv-cross-test-reflection
11/11 Test #11: spirv-cross-test-reflection ......***Failed    0.17 sec

9% tests passed, 10 tests failed out of 11

Total Test time (real) =   3.28 sec

The following tests FAILED:
          2 - spirv-cross-test (Failed)
          3 - spirv-cross-test-no-opt (Failed)
          4 - spirv-cross-test-metal (Failed)
          5 - spirv-cross-test-metal-no-opt (Failed)
          6 - spirv-cross-test-hlsl (Failed)
          7 - spirv-cross-test-hlsl-no-opt (Failed)
          8 - spirv-cross-test-opt (Failed)
          9 - spirv-cross-test-metal-opt (Failed)
         10 - spirv-cross-test-hlsl-opt (Failed)
         11 - spirv-cross-test-reflection (Failed)
Errors while running CTest

You're supposed to use Python3 for SPIRV-Cross testing. However, you'll have to build glslang/spirv-tools with the scripts and set some PATHs atm, see the .travis file for details.

I think an opt-in or opt-out option would be a good idea.  However I'll see what I can do with shader.   Considering the tests rely on specific versions of glslang and spirv-tools, us running the tests may cause too much noise.

Ok, I'll make it more graceful then.


[FEATURE] Built-in HA load balancer

We want to have a built-in HA load balancer shipped with the solution, so we can act as a cloud provider in Kubernetes.
We can use kube-vip(https://kube-vip.io/) potentially.

Allow me to comment on this one. I would like you to consider https://purelb.gitlab.io/docs/ ... especially as it has support for the OSPF routing protocol. BGP is, I think, outdated and well known to be insecure. PureLB evolved from, started as far as I know, as a fork of MetalLB. And it's implementation is quite nice. It uses the Bird Router for routing so a nice separation of concerns was done in regards to what PureLB do and do not do.
Please give it a look. Thank you.

https://purelb.gitlab.io/docs/how_it_works/bundledbird/

Afaiu this was implemented by #1155 but not closed automatically because description misses magic Word "Closes"

@olljanat Thanks for the reminder. Before we can close an issue, our QA will need to validate the issue has been indeed fixed. So that's why we don't use close keyword in the PRs.


Enhanced fallback behaviour for ResxLocalizationProvider.

Hi!
In one of our projects we use the WPFLocalizationExtension in combination with the XamDataGrid of Infragistics. We tried to use the LocTex extension for providing the label-text of a column.
Unfortunately it did not work and we always got the fallback “key:resource_key”.
After a little bit of debugging we found out, that the ResxLocalizationProvider was not able to locate our default assembly and dictionary. These two default values are set in our main window. The ResxLocalizationProvider did not find the default values because of the implementation within the ParentChangedNotifierHelper. The GetValueOrRegisterParentNotifier tries to find the values for ResxLocalizationProvider.DefaultAssembly and ResxLocalizationProvider.DefaultDictionary by traveling up the visual tree. In case of the XamDataGrid, the fields are not part of the generated visual tree nor are they Visuals at all. They are simple DependencyObjects and are used to generate the final column-layout.
While debugging the code we found out, that it would be sufficient to set the FallbackAssembly and FallbackDictionary. I did that in the callbacks for attached properties within the ResxLocalizationProvider class and it worked.

@dhasi does that interfere with the standard usage of the extension?
@MrCircuit do you have any objections against that? could we add it to the next release?

@SeriousM we will do a little bit more testing but till now we did not notice any side-effects. Anyway, since the provider is a Singelton - until Reset is called – would it be the more “preferred” way, to set the Fallback-Values in code behind?


py3.10 support

currently at least one dep (python-flirt) doesn't support py3.10 so capa will not install on py3.10. we should:

update python-flirt
add CI testing of py3.10

relevant: https://github.com/williballenthin/lancelot/pull/133

LIEF also doesn't support py3.10 yet

https://github.com/lief-project/LIEF/issues/627

i take it back, LIEF can be built from source in CI (it takes 20 mins) but it does work.