Remove mapping types #155

As part of v2.0 release, mapping types are getting removed from OpenSearch engine. Below are the changes in the opensearch-engine.

Removal of type from rest end-points
Removal of include_type_name parameter from API requests.

As part of this issue, please verify if type removal change on OpenSearch engine impacts this repository. If yes, then please remove the type references/usage from this plugin.
Top level changes are captured in gist below:
https://gist.github.com/dreamer-89/d76eaf639171e8ab32fa7f8b9d6c93d3
For more detailed changes, please check meta issue below:
Related: OpenSearch-engine meta issue

@martin-gaievski I see these errors in knn build on 2.0.0-alpha1

logs:
> Task :compileJava
/tmp/tmpadcckeau/k-NN/src/main/java/org/opensearch/knn/index/codec/KNN80Codec/KNN80CompoundFormat.java:8: error: package org.apache.lucene.codecs.lucene50 does not exist
import org.apache.lucene.codecs.lucene50.Lucene50CompoundFormat;
                                        ^
/tmp/tmpadcckeau/k-NN/src/main/java/org/opensearch/knn/index/codec/KNN80Codec/KNN80DocValuesFormat.java:11: error: package org.apache.lucene.codecs.lucene80 does not exist
import org.apache.lucene.codecs.lucene80.Lucene80DocValuesFormat;
                                        ^
/tmp/tmpadcckeau/k-NN/src/main/java/org/opensearch/knn/index/codec/KNN87Codec/KNN87Codec.java:9: error: package org.apache.lucene.codecs.lucene87 does not exist
import org.apache.lucene.codecs.lucene87.Lucene87Codec;
                                        ^
/tmp/tmpadcckeau/k-NN/src/main/java/org/opensearch/knn/indices/ModelDao.java:203: error: no suitable method found for mapping(String,String,XContentType)
            CreateIndexRequest request = new CreateIndexRequest(MODEL_INDEX_NAME).mapping("_doc", getMapping(), XContentType.JSON)
                                                                                ^
    method CreateIndexRequest.mapping(String) is not applicable
      (actual and formal argument lists differ in length)
    method CreateIndexRequest.mapping(BytesReference,XContentType) is not applicable
      (actual and formal argument lists differ in length)
    method CreateIndexRequest.mapping(XContentBuilder) is not applicable
      (actual and formal argument lists differ in length)
    method CreateIndexRequest.mapping(Map<String,?>) is not applicable
      (actual and formal argument lists differ in length)
    method CreateIndexRequest.mapping(String,Map<String,?>) is not applicable
      (actual and formal argument lists differ in length)
/tmp/tmpadcckeau/k-NN/src/main/java/org/opensearch/knn/index/KNNQuery.java:18: error: KNNQuery is not abstract and does not override abstract method visit(QueryVisitor) in Query
public class KNNQuery extends Query {
       ^
/tmp/tmpadcckeau/k-NN/src/main/java/org/opensearch/knn/index/KNNWeight.java:80: error: method does not override or implement a method from a supertype
    @Override
    ^
/tmp/tmpadcckeau/k-NN/src/main/java/org/opensearch/knn/index/codec/KNN80Codec/KNN80Codec.java:28: error: KNN80Codec is not abstract and does not override abstract method knnVectorsFormat() in Codec
public final class KNN80Codec extends Codec {
             ^
/tmp/tmpadcckeau/k-NN/src/main/java/org/opensearch/knn/index/codec/KNN80Codec/KNN80CompoundFormat.java:30: error: cannot find symbol
        this.delegate = new Lucene50CompoundFormat();
                            ^
  symbol:   class Lucene50CompoundFormat
  location: class KNN80CompoundFormat
/tmp/tmpadcckeau/k-NN/src/main/java/org/opensearch/knn/index/codec/KNN80Codec/KNN80DocValuesFormat.java:24: error: cannot find symbol
        this(new Lucene80DocValuesFormat());
                 ^
  symbol:   class Lucene80DocValuesFormat
  location: class KNN80DocValuesFormat
/tmp/tmpadcckeau/k-NN/src/main/java/org/opensearch/knn/index/codec/KNN84Codec/KNN84Codec.java:30: error: KNN84Codec is not abstract and does not override abstract method knnVectorsFormat() in Codec
public final class KNN84Codec extends Codec {
             ^
/tmp/tmpadcckeau/k-NN/src/main/java/org/opensearch/knn/index/codec/KNN86Codec/KNN86Codec.java:30: error: KNN86Codec is not abstract and does not override abstract method knnVectorsFormat() in Codec
public final class KNN86Codec extends Codec {
             ^
/tmp/tmpadcckeau/k-NN/src/main/java/org/opensearch/knn/index/codec/KNN87Codec/KNN87Codec.java:32: error: cannot find symbol
        this(new Lucene87Codec());
                 ^
  symbol:   class Lucene87Codec
  location: class KNN87Codec
12 errors

> Task :compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org/

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.3.3/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 15s
2 actionable tasks: 2 executed
2022-03-27 07:35:20 ERROR    Error building k-NN, retry with: ./build.sh manifests/2.0.0/opensearch-2.0.0.yml --component k-NN --snapshot
Traceback (most recent call last):
  File "./src/run_build.py", line 80, in <module>
    sys.exit(main())
  File "./src/run_build.py", line 68, in main
    builder.build(build_recorder)
  File "/var/jenkins/workspace/distribution-build-opensearch/src/build_workflow/builder_from_source.py", line 55, in build
    self.git_repo.execute(build_command)
  File "/var/jenkins/workspace/distribution-build-opensearch/src/git/git_repository.py", line 83, in execute
    subprocess.check_call(command, cwd=cwd, shell=True)
  File "/usr/local/lib/python3.7/subprocess.py", line 363, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command 'bash /tmp/tmpadcckeau/k-NN/scripts/build.sh -v 2.0.0 -q alpha1 -p linux -a arm64 -s true -o builds' returned non-zero exit status 1.

Are they related to this PR since I also see mapping.
Thanks.

@martin-gaievski I see these errors in knn build on 2.0.0-alpha1
logs:
Are they related to this PR since I also see mapping.
Thanks.

Build on 2.0 alpha1 snapshot was old on Friday, there is a PR specifically aiming integration #https://github.com/opensearch-project/k-NN/pull/328. Maybe it's something in latest snapshot, I'm restarting build jobs to see what the errors are (if any)

@martin-gaievski I see these errors in knn build on 2.0.0-alpha1
logs:
Are they related to this PR since I also see mapping.
Thanks.

Build on 2.0 alpha1 snapshot was old on Friday, there is a PR specifically aiming integration ##328. Maybe it's something in latest snapshot, I'm restarting build jobs to see what the errors are (if any)

We built on latest main on Friday to consume the changes from reta on fixing https://github.com/opensearch-project/OpenSearch/issues/2581

@peterzhuamazon as per stacktrace knn is failing due to a missing references to a lucene 8.x classes. This is changed in lucene 9.1, that supposed to be part of 2.0 alpha1 snapshot. What is the knn branch that is failing, could you please share the link to build job?

@peterzhuamazon I have provided the necessary information to @martin-gaievski

@dreamer-89 has talked to me and I have provided the commitid:
OpenSearch main f1d35d028ffc807303c75ba677f4c2cff9835041

@peterzhuamazon I think with latest PR to knn previous issue has been fixed. I see from the latest build log that problem is with anomaly detection now:
`BUILD SUCCESSFUL in 54s
10 actionable tasks: 10 executed
++ find . -path 'build/distributions/.zip'

zipPath=./build/distributions/opensearch-anomaly-detection-<IP_ADDRESS>-SNAPSHOT.zip
++ dirname ./build/distributions/opensearch-anomaly-detection-<IP_ADDRESS>-SNAPSHOT.zip
distributions=./build/distributions
echo 'COPY ./build/distributions/.zip'
COPY ./build/distributions/.zip
mkdir -p builds/plugins
cp ./build/distributions/opensearch-anomaly-detection-<IP_ADDRESS>-SNAPSHOT.zip ./builds/plugins
2022-03-28 19:00:37 INFO     Recording plugins artifact for anomaly-detection: plugins/opensearch-anomaly-detection-<IP_ADDRESS>-SNAPSHOT.zip (from /tmp/tmps75s70s9/anomaly-detection/builds/plugins/opensearch-anomaly-detection-<IP_ADDRESS>-SNAPSHOT.zip)
2022-03-28 19:00:37 ERROR    Error building anomaly-detection, retry with: ./build.sh manifests/2.0.0/opensearch-2.0.0.yml --component anomaly-detection --snapshot
Traceback (most recent call last):
File "./src/run_build.py", line 80, in
sys.exit(main())
File "./src/run_build.py", line 69, in main
builder.export_artifacts(build_recorder)
File<EMAIL_ADDRESS>line 65, in export_artifacts
build_recorder.record_artifact(self.component.name, artifact_type, relative_path, absolute_path)
File<EMAIL_ADDRESS>line 40, in record_artifact
BuildArtifactChecks.check(self.target, artifact_type, artifact_file)
File<EMAIL_ADDRESS>line 42, in check
instance.check(path)
File<EMAIL_ADDRESS>line 20, in check
raise BuildArtifactCheck.BuildArtifactInvalidError(path, f"Expected filename to include one of {self.target.compatible_component_versions}.")
build_workflow.build_artifact_check.BuildArtifactInvalidError: Artifact opensearch-anomaly-detection-<IP_ADDRESS>-SNAPSHOT.zip is invalid. Expected filename to include one of ['<IP_ADDRESS>-alpha1-SNAPSHOT'].`


Shapefile couldn't pan and zoom

I loaded the shapafile into the map, but I couldn't pan and zoom

Hi, thanks for the question. Could you provide more details? E.g a a minimal working example.

Close due to inactivity. Feel free to reopen if the issue persists!


Feature request - Open file in a different monitor.

Hi,
Used to work with VS2017 on multiple monitors. When I needed to compare or work with 2 files at the same time, I was able to open both files in 2 different screens by just dragging one file out side from VS. I find that in VS Code this feature is absence.
It would be great to have this feature in VS Code as well.
Thanks!
Shaul

Thanks!


Add infos how to run the tests

If you are new to crystal it might confuse you how to run specs.

Thanks!


Feedback sounds on a separate media player

Hey,
Is it possible to use the satellite only as an input and play the awake sound, done sound, and the actual response on another media player connected to HA?
Thanks!

I managed to do what I wanted for the awake sound and the done sound by listening to the homeassistant_satellite_event.
Another quick question, is it possible to "awake" the satellite from an automation without using a wake word? I'd like to have an automation that prompts me for something without having to say the wake word.

That would be a great feature for automations indeed

Another quick question, is it possible to "awake" the satellite from an automation without using a wake word?
I haven't yet found a way to do this and it's very lacking.
Is it possible to use the satellite only as an input and play the awake sound, done sound, and the actual response
I think you can do that with pulseaudio


PLNSRVCE-1675: add non-prompting default extension config generation; add delete optoin

@sayan-biswas
I was able to validate my new config option against stg-m01.
However, the delete cmd is failing with

a grpc code of 14
and an error message of:  connection error: desc = "transport: authentication handshake failed: context deadline exceeded"

I did double check the infra-deployment cluster role and it seems like the pipeline serivce sre cluster role has delete permissions, so at first blush, I'm not sure what my code change is missing
Hopefully you can try things and help this newbie to your CLI out :-)

@gabemontero
There is an issue with the TLS since I am doing the custom credential in the gRPC client implementation to support impersonation. I have fixed that last week, will create a PR today or tomorrow. I am not saying that is the issue, from the error message it seems so.
Also I have an implementation of the delete done, I'll include in that PR. Maybe after that you can rebase and add your config changes.

any updates @sayan-biswas ?
if it is a matter of testing, if you push up what you have, I can try and finish the testing for you

@gabemontero Sorry! Was occupied in other stuffs. I have added TLS config, Delete feature and also tweaked the configuration process a little. Also added a --no-prompt flag to handle the prompt behaviour from user input instead of taking it from the struct tags that I was using.
Also the delete command cascades delete to child resources. If this is something not desired, then let me know.

ok I pushed my updates that allowed for delete using REST @sayan-biswas and I was able to test against stg-m01 in my tenant namespace
I pushed just for reference
I'll look at your changes next, and assuming we go with those, I'll close this out, not bother with a rebase.


⚠ Bofrost.lu has degraded performance

In 6bba3e5, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2487 ms

Resolved: Bofrost.lu performance has improved in 88865d8 after 6 minutes.


Add arch-x64 RID

Add support for arch-x64 as it's now supported in corefx
See https://github.com/dotnet/corefx/commit/1f08b57bfd197a5492fe2ed0e0c5b2e6de9bf642

Thanks for the PR, but the set of RIDs we build has changed, and we no longer need specific repos added. I'm going to go ahead and close this.


Celery should not run as root

I receive the following warning when running panhandler:
docker run -p 9991:80 paloaltonetworks/panhandler:dev /usr/local/lib/python3.6/site-packages/celery/platforms.py:801: RuntimeWarning: You're running the worker with superuser privileges: this is absolutely not recommended!
We should be able to run this container with a uid other than root.
Reference: https://stackoverflow.com/questions/53037874/docker-celery-tells-me-not-to-run-as-root-but-once-i-dont-i-lack-permission

Fixed in dev with commit: b8ae3354848b614706ee4772fe40925a4f936920
will wait until further testing to close


Add referer field to webhook events

Problem
We cannot determine the origin from which the request was made that triggered the webhook. For example: if we trigger TRANSACTION_INITIALIZE_SESSION webhook from transactionInitialize mutation inside a web browser that is viewing a https://my-awesome-app.com we have no way to tell the website that the user was browsing was https://my-awesome-app.com in the app that will handle the webhook.
This is needed, for example in 3D Secure payments, that require the origin of a page that made the request for calculating risk score. Example in Adyen docs: https://docs.adyen.com/api-explorer/Checkout/71/post/payments#request-origin

1. General Assumptions
We need the referer HTTP header to be passed in the webhook event.
Acceptance Criteria

[ ] referer property is added to webhook events

2. API changes
Types
type Event {
  # ...
  referer: String
}

My initial thought is that information belongs to something other than the event level. Most events are not triggered through HTTP requests, so the concept of "referrers" (funny story: the HTTP header has a typo in its name, but there was no way to fix it, so it's stuck with an "r" missing) does not translate well to events in general. It could also leak information that apps don't need to know to operate. If it's specifically required for payments, I'd make it part of the payment protocol, the same way we convey information about IP addresses.


Support both ark: and ark:/ namespaces

Version 34 of the ARK spec requires that both ark: and ark:/ as namespaces must be supported.

Could implement some middleware (https://fastapi.tiangolo.com/tutorial/middleware/) to normalize the incoming requests.

Much simpler solution:
@app.get("/ark:{naan}/{identifier}")
@app.get("/ark:/{naan}/{identifier}")


merged arrays

I believe yaml array merge is broken, might be a trivial fix, but i have not looked at the implementation. here is an example from the online demo

example_array: &example_array
 - one
 - two

spread_array:
  - five
  - four
  - *example_array

result
{ example_array: [ 'one', 'two' ],
  spread_array: [ 'five', 'four', [ 'one', 'two' ] ] }

expected
{ example_array: [ 'one', 'two' ],
  spread_array: [ 'five', 'four', 'one', 'two' ] }

There is no such feature "array merge" in YAML
Even if there was, how should a library know that in this case it should merge something?

I took inspiration from one of the original contributors to yaml and created a !!concat-seqs type.


Allow changing existing Pinot schema for certain scenarios

Currently it seems like Pinot is very rigid about only allowing schema changes where a new column has been added. If you need to make any changes to existing columns for e.g changing column from int to long or timestamp format change, which don't affect existing data you are still forced to delete and recreate the table/schema which is very limiting and depending on amount of data that will need to be reprocessed perhaps not even feasible.
Here is a sample scenario, I created a schema where one of the datetimeSpec columns has a ingestion transform
{       "name": "CreationTimeMillis",       "dataType": "LONG",       "defaultNullValue":<PHONE_NUMBER>,       "transformFunction": "fromDateTime(CreateTime, \"yyyy-MM-dd'T'HH:mm:ssZ\")",       "format": "1:MILLISECONDS:EPOCH",       "granularity": "1:MILLISECONDS"     }
now apparently time format specification here is incorrect and I need to change this to
{       "name": "CreationTimeInMillis",       "dataType": "LONG",       "defaultNullValue":<PHONE_NUMBER>,       "transformFunction": "fromDateTime(CreateTime, 'yyyy-MM-dd''T''HH:mm:ssZ')",       "format": "1:MILLISECONDS:EPOCH",       "granularity": "1:MILLISECONDS"     }
but this is now considered as a backward incompatible change.
Can we add some additional intelligence in the logic so such changes which don't affect underlying data are allowed to go through ?
cc @mayankshriv

yeah, changing defaultNullValue should regenerate the column while reloading the segments. But need to loosen the sanity check for updateSchema rest API, which only allows to add new columns today. Basically, I think we may skip check on defaultNullValue here
Currently, changes of transformFunction doesn't trigger the regeneration, and we may support it by extending the logic around here and keeping track of the transformFunc in the segment metadata (as defined here) to check discrepancy.
pls lemme know your thoughts, and any interest to take a stab on them. thx!


Adding or updating to have latest version of Horus Heresy

Hi ya. I tried to read what was written here and it was like reading seachart in the middle of a random ocean and with no compass for me (I'm sure people understand it, but not me).
I worked out how to see the BSdata things in app. However it looks like the Horus Heresy data is a couple of months old.
The location is here
https://github.com/BSData/horus-heresy
Current release is
Praetor Tribune Terminator Bodyguard
v14.232
@capitaladot hopefully this works

Well, you're right. And I've found the reason:

Well, you're right. And I've found the reason:

I've re-enabled the workflows, the issue should be fixed a bit after next even hour UTC time.

I've re-enabled the workflows, the issue should be fixed a bit after next even hour UTC time.

@Mayegelt

Hi ya. I tried to read what was written here and it was like reading seachart in the middle of a random ocean and with no compass for me (I'm sure people understand it, but not me).

Suggestions how to help with that? Most people struggle. I've built this system myself, so I can't see how to explain it well. ;D

@Mayegelt

Hi ya. I tried to read what was written here and it was like reading seachart in the middle of a random ocean and with no compass for me (I'm sure people understand it, but not me).

Suggestions how to help with that? Most people struggle. I've built this system myself, so I can't see how to explain it well. ;D

Thanks. Any idea why it stopped? Because since the last recorded one it we have had at least 1 update every 2 weeks or so minimum.

Thanks. Any idea why it stopped? Because since the last recorded one it we have had at least 1 update every 2 weeks or so minimum.

As the message said. There was no activity in this repository for 60 days, so the scheduled actions stopped.

As the message said. There was no activity in this repository for 60 days, so the scheduled actions stopped.

As the message said. There was no activity in this repository for 60 days, so the scheduled actions stopped.

Which is really odd, as said above. The last update on https://github.com/BSData/gallery/releases/latest/download/bsdata.catpkg-gallery.json is 27th November, and there was a release on
12th Dec, 7th, 9th, 11th, 12th... of Jan.
Either way if it's fixed now that's great. Thank you for all the work helping us.

As the message said. There was no activity in this repository for 60 days, so the scheduled actions stopped.

Which is really odd, as said above. The last update on https://github.com/BSData/gallery/releases/latest/download/bsdata.catpkg-gallery.json is 27th November, and there was a release on
12th Dec, 7th, 9th, 11th, 12th... of Jan.
Either way if it's fixed now that's great. Thank you for all the work helping us.

Wait, I understand now what you're saying. Indeed, something's quite wrong. The update-index workflow has found no updates, and it has been running consistently up until two weeks ago. I need to investigate.

Wait, I understand now what you're saying. Indeed, something's quite wrong. The update-index workflow has found no updates, and it has been running consistently up until two weeks ago. I need to investigate.

I've re-enabled the workflows, the issue should be fixed a bit after next even hour UTC time.

Sorry to bother you again. Do we need to do a new release for it to work again. Just checked and still showing the November one. Just trying to make sure I'm not misunderstanding if it was meant to see what we had now, or needs it to be new.

I've re-enabled the workflows, the issue should be fixed a bit after next even hour UTC time.

Sorry to bother you again. Do we need to do a new release for it to work again. Just checked and still showing the November one. Just trying to make sure I'm not misunderstanding if it was meant to see what we had now, or needs it to be new.

I think even though the release show in the Repo Selection view is incorrect, when you actually subscribe some repo, you should get the newest data anyway. So the issue shouldn't be critical, just a nuisance in UI. Can you confirm the data is the newest one?

I think even though the release show in the Repo Selection view is incorrect, when you actually subscribe some repo, you should get the newest data anyway. So the issue shouldn't be critical, just a nuisance in UI. Can you confirm the data is the newest one?

Just checked and once subscribed it seems to work and just pushed to latest version on the manage data screen. Just not the select repository one.

Just checked and once subscribed it seems to work and just pushed to latest version on the manage data screen. Just not the select repository one.

Closing as I've removed caching and issue is now resolved.

Closing as I've removed caching and issue is now resolved.


Moving chrome into separate module

Resolves #192
Chooser dialog will not display anymore - package is set if Chrome is present

This PR was released with 0.22.1


French Translation for 3.3.2

Pull Request Checklist

[x] Read and followed this repo's Contributing Guidelines
[x] Based this PR on the latest version of the correct branch (master or 3.x)
[x] Followed PEP 8 code style
[x] Ensured this pull request hasn't eliminated unrelated blank lines/spaces,
modified the spyder/defaults directory, or added new icons/assets
[ ] Wrote at least one-line docstrings following PEP 257for any new functions
[ ] Added at least one unit test covering the changes, if at all possible
[ ] Described the changes and the motivation for them below
[x] Noted what issue(s) this pull request resolves, creating one if needed
[ ] Included a screenshot, if this PR makes any visible changes to the UI

Developer Certificate of Origin Affirmation
By submitting this Pull Request or typing my name below, I affirm the
Developer Certificate of Origin
with respect to both the content of the contribution itself and this post,
and understand I am releasing it under Spyder's MIT (Expat) license.

Description of Changes

Issue(s) Resolved

Fixes French part of #8236

Thanks a lot @Prikers!


Request for additional memory from manager

Manager should support request for some tensor memory to be requested. The lifetime and semantics of this memory will be different than that of weights. For example, LSTM cell memory.

:octocat: cibot: Thank you for posting issue #1086. The person in charge will reply soon.

This is being handled in #986 with the new design for LayerContext.


may have fixed find lapacke problem

see if this works for you @nzamb222

@nzamb222 You'll wont believe what the issue was lol


Is this still needed if 15.3 is used?

thank you
Using this within React Native

RIP react-timer-mixin


(GH-1500) Support .yml for bolt config and inventory

This adds support for the .yml extension for bolt config and inventory
files. Bolt will recognize either bolt.yaml or bolt.yml as the root
of a local Boltdir, with bolt.yml following the same behavior as
bolt.yaml with respect to project directory type precedence. If both
.yaml and .yml files are present for config or inventory, .yaml is
preferred. Any yaml files generated by bolt still have the .yaml
extension.
Closes #1500

Maybe to hiera.yaml => hiera.yml to? Though I feel like we talked about this a long time ago and decided we wanted to just follow the suggested yaml https://yaml.org/faq.html

I didn't because for Puppet hiera config has to be .yaml (https://puppet.com/docs/puppet/6.10/hiera_config_yaml_5.html, https://github.com/puppetlabs/puppet/blob/master/lib/puppet/pops/lookup/hiera_config.rb#L42). I thought about making analytics.yaml and YAML plans also support it, but this came up because someone asked for it in slack and I figured I'd wait until someone also asked for those files to make those changes.

I think adding support for analytics.yml makes sense, if only because it seems weird to fix this issue for config and inventory, but not for analytics collection.

Maybe the fact that it does not work for hiera is an indication that we should not allow it in bolt? I'm thinking this is more work that it is worth? But i'm not super strongly opposed.

I think Hiera doesn't support both for the same reason we didn't: because .yaml is preferred and no one has asked for .yml. This came up because several users are accustomed to three-letter extensions (possibly from when Windows applications would only load / recognize three-letter extensions), and while this doesn't prevent people from manually specifying a .yml config and inventory I think it's a cheap quality of life improvement. See this comment.

CLA signed by all contributors.


Fixes the project name for sbt-org-policies

Codecov Report

Merging #78 into master will decrease coverage by 0.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   87.35%   86.77%   -0.58%
==========================================
  Files          18       18
  Lines         427      431       +4
==========================================
+ Hits          373      374       +1
- Misses         54       57       +3

Impacted Files
Coverage Δ

core/src/main/scala/config/model.scala
100% <0%> (+6.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f1ae9e...24c6919. Read the comment docs.


dev flake

This allows us to have private dev inputs that we can use in the main flake and move the github actions checks to buildbot.
We may be able to upstream the vendored files to the flake-parts repo but I don't want bother with that for now.
Depends on https://github.com/nix-community/srvos/pull/355.

It allows us to have private dev inputs that we can use in the main flake, can then move the github actions checks to buildbot. We discussed this briefly on matrix a few weeks ago.

I plan to merge this before the next flake update.


Implement exercise isbn-verifier

Nice job-- all the canonical tests are covered and the PR otherwise looks great.
One last thing-- would you mind squashing your commits to one?  If you need any hep with this, please let me know, I'd be happy to help.

That should've done it.

Nice work!  Thanks again 🥇


WGSLTokenType.LESS_THAN expected, got '('

This code:
struct Vertex {
	@builtin(position) pos: vec4<f32>
}

@vertex
fn vs_main(@builtin(vertex_index) in_vertex_index: u32) -> Vertex {
	let x = f32(1 - i32(in_vertex_index)) * 0.5;
	let y = f32(i32(in_vertex_index & 1u) * 2 - 1) * 0.5;
	return Vertex(vec4(x, y, 0.0, 1.0));
}

@fragment
fn fs_main(in: Vertex) -> @location(0) vec4<f32> {
	return vec4(1.0, 0.0, 0.0, 1.0);
}

validates fine, but the plugin throws an error at the first vec4 because it incorrectly assumes that it must be qualified with <f32>.

I'll take a look and see what I can see

Ok, it appears that the spec in this area has changed. It may take a little while to get the grammar updated to accommodate the new syntax

I have just pushed a fix for this issue. Once it has been approved by Jetbrains it should be available on the store.

Feel free to close the issue once the new version is available :)

It usually takes them a couple of days to approve a new version of the plugin

This should now be available in the Jetbrains store

Thanks!


CPU to the moon

Hi, when i using plugin unocss, my cpu is hight to max

Without unocss plugin

Windows 11

Выпуск	Windows 11 Pro
Версия	22H2
Дата установки	14.04.2023
Сборка ОС	22621.2283
Взаимодействие	Windows Feature Experience Pack 1000.22662.1000.0
PHPSTORM:

PhpStorm 2023.3.2
Build #PS-233.13135.108, built on December 21, 2023
Licensed to Den Black
You have a perpetual fallback license for this version.
Subscription is active until February 6, 2025.
Runtime version: 17.0.9+7-b1087.9 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 11.0
GC: G1 Young Generation, G1 Old Generation
Memory: 10240M
Cores: 16
Registry:
debugger.watches.in.variables=false
debugger.new.tool.window.layout=true
run.processes.with.pty=TRUE
ide.experimental.ui=true
Non-Bundled Plugins:
com.codeium.intellij (1.6.34)
com.webfont.ideaplugin (3.0)
com.github.wjlroe.idea-json-detect (1.3)
net.seesharpsoft.intellij.plugins.csv (3.3.0-233)
com.jetbrains.plugins.jade (233.11799.172)

@re-ovo, we would appreciate it if you could have a look at this, as the plugin is unusable currently because of this issue.

@mshamaseen Please provide cpu profiler report (intellij diagnostic tool)

press  Help | Diagnostic Tools | Start CPU Usage Profiling;
make sure that the high CPU usage problem is reproduced;
press  Help | Diagnostic Tools | Stop CPU Usage Profiling.

The snapshot will be saved to the user home directory. Please, share this snapshot with us

@re-ovo I tried to reproduce the issue on multiple devices and multiple projects, 2 with filesystem option points to *.blade files, and one with VueJs; they all result to high CPU usage.
Here is the diagnostic, this is a Laravel + blade + unocss project, uno config:
export default defineConfig({
    content: {
        filesystem: [
            'resources/forms/**/index.blade.php',
            'resources/forms/layout.blade.php',
        ]
    }
})

PS-233.14808.18_shamaseen_13.03.2024_18.02.06.zip

@mshamaseen It seems that this is a performance problem caused by initialization. Can you provide a minimum reproducible project? Because I can't reproduce it in my own project. Thanks

@re-ovo I've sent you an invitation to our private project; it is a new project and currently is just a landing page; feel free to inspect it.

@re-ovo I've sent you an invitation to our private project; it is a new project and currently is just a landing page; feel free to inspect it.

Tested and it still works fine on my computer
What version of Node are you using? What package management tool are you using?

You need to open any .blade file under resources/views/**
See the following screencast that illustrate how the CPU goes up, and then it goes down when I disable uno plugin
https://github.com/re-ovo/unocss-intellij/assets/38951661/9c924999-b037-4598-894f-d8699f7fa894

Just a note, I don't have Nodejs nor NPM installed on my device, I use docker to run my projects, so at the time of recording there is no npm or NodeJS activated


ektorp 1.4.4 is incompatible with Jackson 2.9.0

Stacktrace:
Caused by: java.lang.NoSuchMethodError: com.fasterxml.jackson.databind.SerializationConfig.withSerializationInclusion(Lcom/fasterxml/jackson/annotation/JsonInclude$Include;)Lcom/fasterxml/jackson/databind/SerializationConfig;
	at org.ektorp.impl.StdObjectMapperFactory.applyDefaultConfiguration(StdObjectMapperFactory.java:50)
	at org.ektorp.impl.StdObjectMapperFactory.createObjectMapper(StdObjectMapperFactory.java:26)
	at org.ektorp.impl.StdCouchDbInstance.<init>(StdCouchDbInstance.java:40)
	at org.ektorp.impl.StdCouchDbInstance.<init>(StdCouchDbInstance.java:32)

This was originally raised in #268. See this comment for a hint about how to address this.

Please see PR #270 for a change that would allow to inject an overridden instance of class org.ektorp.impl.StdObjectMapperFactory


ObservableCursor won't work with AsyncPipe

Won't work:
const Tasks = new MongoObservable.Collection<Task>('tasks');

@Component({
  selector: 'task-list',
  template: `<ul><li *ngFor="let task of tasks | async"></li></ul>`
})
class Tasks {
  tasks = Tasks.find();
}

It will but with zone()
const Tasks = new MongoObservable.Collection<Task>('tasks');

@Component({
  selector: 'task-list',
  template: `<ul><li *ngFor="let task of tasks | async"></li></ul>`
})
class Tasks {
  tasks = Tasks.find().zone(); // <--
}

It actually not needed to be bind to a zone, because that's what AsyncPipe should do... weird...
I will debug it soon.
@kamilkisiela

@kamilkisiela I added a new examples directory with angular2 example - it works there great. Also tested with ChangeDetectionStrategy.OnPush and it works.

@dotansimha how does ChangeDetectionStrategy.OnPush relate to this? AsyncPipe doesn't run zone it only marks itself for check (https://github.com/angular/angular/blob/14ee75924b6ae770115f7f260d720efa8bfb576a/modules/%40angular/common/src/pipes/async_pipe.ts#L146). Vile thing here is that it might seem working for simple examples (when everything happens synchronously), but will fail eventually for more complex once.
There was an idea to implement own version of AsyncPipe that runs zone.

Yeah you are right about OnPush. Do you have an example for a complex scenario? I tried some and it looks like it worked in all of them.

@dotansimha I checked and turned out that Meteor.subscribe's callback is running now always in the zone. I think the issue might be in the promises. Before Meteor promise could possibly be initialized before zone-aware promise, so it was not patched. Zone.js actually patches everything including websockets. But that peace with promises was lost from patching.

@barbatus thanks, I see.
Do you have any way to reproduce? I wan't to have a look on it

@dotansimha I am saying I missed this point before. Now .zone probably not needed at all, except if observables are used out of Angular 2 zone. I'll check it out one more time and probably cleanup some stuff that not needed.


Updated "Let's Go" button emoji to 🚀 for better alignment with brand and purpose (Issue #7)

This PR resolves Issue #7 by updating the emoji on the "Let's Go" button to match better the action of starting or exploring and aligning with the GitFinder project's branding.
Changes:

Replaced the current emoji with 🚀 (Rocket), which symbolizes launching or beginning.
This update improves clarity for users and enhances the visual appeal of the button while staying in line with the overall theme of the platform.

Testing:

Verified that the new emoji appears correctly on the "Let's Go" button across different browsers and screen sizes.

@BamaCharanChhandogi can you please check it, too?

@BamaCharanChhandogi I redo the changes in every branch for the Firebase file like same as before.


Annotations access moved closer to persistence

-Added new deserialize method that accepts annotations that it can use after
-When deserializing check passed annotation when deserializing broadcasts, locations and sub_items
-Added new test to deserializing

You should add tests for available and upcoming content and also add @Nullable annotations where appropriate in the model fields and getters/setters, but otherwise LGTM


MSPSDS-976 fix: add activity_types to all activities that need them

Description

Checklist:

[ ] Automated checks are passing locally.
[ ] CHANGELOG updated if change is worth telling users about.

General testing

[ ] Test without javascript
[ ] Test on small screen

Accessibility testing

[ ] Works keyboard only
[ ] Tested with one screen reader
[ ] Zoom page to 400% - content still visible
[ ] Disable css - does content make sense and appear in a logical order?
[ ] Passes automated checker (automated in build or manual)

This is covered by #847.


HBASE-26064 Introduce a StoreFileTracker to abstract the stor…

…e file tracking logic

@wchevreuil PTAL.
I will commit this to a feature branch first as there are still lots of other place to integrate, such as MergeTableRegionsProcedure/SplitTableRegionProcedure, snapshot, major compaction tool and so on(just search the usage of HRegionFileSystem.getStorefiles).
This is another direction on how to make it possible to write directly to data directory for compaction and flush. And I think this is a more general way to support different persistency ways, either with a file or with a region, and easier to migrate betewwn different persisent ways(or even without persistency)
Feel free to comment anything here. I will put up a design doc soon.
Thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 45s
master passed

+1 :green_heart:
compile
3m 55s
master passed

+1 :green_heart:
checkstyle
1m 19s
master passed

+1 :green_heart:
spotbugs
2m 19s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 15s
the patch passed

+1 :green_heart:
compile
3m 23s
the patch passed

+1 :green_heart:
javac
3m 23s
the patch passed

+1 :green_heart:
checkstyle
1m  5s
hbase-server: The patch generated 0 new + 128 unchanged - 10 fixed = 128 total (was 138)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 33s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 14s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

50m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3460

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 6295c0b39971 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e65fc9226f

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
95 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m  2s
master passed

+1 :green_heart:
compile
1m 18s
master passed

+1 :green_heart:
shadedjars
9m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 51s
the patch passed

+1 :green_heart:
compile
1m 19s
the patch passed

+1 :green_heart:
javac
1m 19s
the patch passed

+1 :green_heart:
shadedjars
9m  7s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
201m 35s
hbase-server in the patch passed.

236m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3460

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f1901703cf49 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e65fc9226f

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/2/testReport/

Max. process+thread count
3606 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

https://docs.google.com/document/d/16Nr1Fn3VaXuz1g1FTiME-bnGR3qVK5B-raXshOkDLcY/edit?usp=sharing
I've finish the first version of the design doc. PTAL.
Thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 59s
master passed

+1 :green_heart:
compile
3m  8s
master passed

+1 :green_heart:
checkstyle
1m  6s
master passed

+1 :green_heart:
spotbugs
2m  5s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 38s
the patch passed

+1 :green_heart:
compile
3m 10s
the patch passed

+1 :green_heart:
javac
3m 10s
the patch passed

+1 :green_heart:
checkstyle
1m  3s
hbase-server: The patch generated 0 new + 128 unchanged - 10 fixed = 128 total (was 138)

-0 :warning:
whitespace
0m  0s
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.

Moved StoreFileTracker to StoreEngine, per @z-york and @saintstack 's suggestion on the design doc. And the root reason is I found that there is already a DateTieredStoreEngine, where we just make use DefaultStoreFileManager, so when switching StoreEngine, it does not mean that you need to change all the components. So I think make all StoreEngine use the same StoreFileTracker abstraction is also workable here.
And I also moved the createWriterInTmp method to StoreFileTracker, to hide the requireCreateInTmp method.
Thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 39s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 37s
master passed

+1 :green_heart:
compile
3m 11s
master passed

+1 :green_heart:
checkstyle
1m  6s
master passed

+1 :green_heart:
spotbugs
2m  3s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 39s
the patch passed

+1 :green_heart:
compile
3m  8s
the patch passed

+1 :green_heart:
javac
3m  8s
the patch passed

-0 :warning:
checkstyle
1m  5s
hbase-server: The patch generated 1 new + 138 unchanged - 10 fixed = 139 total (was 148)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 58s
master passed

+1 :green_heart:
compile
3m 12s
master passed

+1 :green_heart:
checkstyle
1m  7s
master passed

+1 :green_heart:
spotbugs
2m  6s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 47s
the patch passed

+1 :green_heart:
compile
3m 16s
the patch passed

+1 :green_heart:
javac
3m 16s
the patch passed

-0 :warning:
checkstyle
1m  3s
hbase-server: The patch generated 5 new + 137 unchanged - 12 fixed = 142 total (was 149)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.

I will commit this to a feature branch first as there are still lots of other place to integrate, such as MergeTableRegionsProcedure/SplitTableRegionProcedure, snapshot, major compaction tool and so on(just search the usage of HRegionFileSystem.getStorefiles).
This is another direction on how to make it possible to write directly to data directory for compaction and flush. And I think this is a more general way to support different persistency ways, either with a file or with a region, and easier to migrate betewwn different persisent ways(or even without persistency)
Feel free to comment anything here. I will put up a design doc soon.
Thanks.

Sorry, hit close button by mistake thinking I was closing a comment of mine. Had just reopened it.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m  5s
master passed

+1 :green_heart:
compile
4m  3s
master passed

+1 :green_heart:
checkstyle
1m 22s
master passed

+1 :green_heart:
spotbugs
2m 43s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 38s
the patch passed

-1 :x:
compile
1m 25s
hbase-server in the patch failed.

-0 :warning:
javac
1m 25s
hbase-server in the patch failed.

-0 :warning:
checkstyle
1m 24s
hbase-server: The patch generated 1 new + 144 unchanged - 15 fixed = 145 total (was 159)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
22m 46s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

-1 :x:
spotbugs
2m 20s
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

56m  1s

Reason
Tests

FindBugs
module:hbase-server

org.apache.hadoop.hbase.regionserver.HStore.close() does not release lock on all exception paths  At HStore.java:on all exception paths  At HStore.java:[line 718]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/11/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3460

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux d31fed8cefb7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 332d9d13b1

Default Java
AdoptOpenJDK-1.8.0_282-b08

compile
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/11/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/11/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/11/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

spotbugs
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/11/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3460/11/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@saintstack @wchevreuil @z-york I've modified the patch. PTAL.
Now most storefile relate operations are moved to StoreEngine, and we will not expose StoreFileTracker to upper layer any more. In HStore we just need to call the methods in StoreEngine, and inside StoreEngine we will update StoreFileTracker and then StoreFileManager. The store lock is also moved into StoreEngine to allow we do fine-grained lock in StoreEngine.
Thanks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

Ping @wchevreuil @saintstack @z-york Any other concerns on this approach? If worth a try, I will merge this to a feature branch and start to implement file based tracking. Thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 30s
Docker mode activated.

Ping @wchevreuil @saintstack @z-york Any other concerns on this approach? If worth a try, I will merge this to a feature branch and start to implement file based tracking. Thanks.

I think this is good to go, @Apache9 . Are you planning to merge this on a separate feature branch, or the one created in HBASE-24749? It might conflict with the works I had made there for flushes and compactions, but I think this refactoring basically dismisses those. The splits/merges one (still open), may still apply.

Ping @wchevreuil @saintstack @z-york Any other concerns on this approach? If worth a try, I will merge this to a feature branch and start to implement file based tracking. Thanks.

I think this is good to go, @Apache9 . Are you planning to merge this on a separate feature branch, or the one created in HBASE-24749? It might conflict with the works I had made there for flushes and compactions, but I think this refactoring basically dismisses those. The splits/merges one (still open), may still apply.

Better on another feature branch, I think this is another abstraction way comparing to HBASE-24749. We could work together on the following issues on how to better implement merge and split, with this abstraction way, and also how to integrate the region based tracking way which has already been implemented on branch HBASE-24749. If these things all work, then I think we could unify these two feature branches. If not, I think we need to go back to the design doc to discuss again. The goal of this issue is to make the store file tracking way pluggable so we will all be happy.
What do you think?

Ping @wchevreuil @saintstack @z-york Any other concerns on this approach? If worth a try, I will merge this to a feature branch and start to implement file based tracking. Thanks.

I think this is good to go, @Apache9 . Are you planning to merge this on a separate feature branch, or the one created in HBASE-24749? It might conflict with the works I had made there for flushes and compactions, but I think this refactoring basically dismisses those. The splits/merges one (still open), may still apply.

Better on another feature branch, I think this is another abstraction way comparing to HBASE-24749. We could work together on the following issues on how to better implement merge and split, with this abstraction way, and also how to integrate the region based tracking way which has already been implemented on branch HBASE-24749. If these things all work, then I think we could unify these two feature branches. If not, I think we need to go back to the design doc to discuss again. The goal of this issue is to make the store file tracking way pluggable so we will all be happy.
What do you think?

Actually, yeah, let's do on a new feature branch, I guess it would be easier to cherry-pick things from HBASE-24749 that may still be relevant into this new one, and apply this refactory.

Pushed to branch HBASE-26067. Closed this PR.


[DOC] update changelog

Codecov Report

Merging #84 (a3295ac) into main (321705e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   91.45%   91.45%
=======================================
  Files          10       10
  Lines         480      480
=======================================
  Hits          439      439
  Misses         41       41

Entries were not made in the correct section. Switching to draft.


Strange map glitches on edited fit file

So what I did was edit a fit file because it had a speed glitch near the start. I edited it in Golden Cheetah and when displaying the changed file I got these vertical lines on the graph.
I've attached a before and after file.
Downloads.zip
I haven't debugged your code as I've got busy with something else, sorry.

Now fitplott is availbale online (alwways the lates version - I added different zoom control at the left bottom  )
https://karaul.github.io/fitplotter/
Could you please check your fit file with this online version ?
If there are the same glitches,  I will need the fit file with glitches for testing.

The original *.fit file is ok, hence, the effect is coming from the artificial editing.
One does not need to edit spikes. There is droplist "zoom" at the bottom right corne (check whether you have latest version - if not, download latest index.html and srs/main.js ). Select "y axes" zoom, and then impose the desirable y-axis range with the spikes exculded.  In the  future version, I probably put an automatical spikes removal, it's not hard, but you can work already by using current functionality.
Also please check new fitplotter version online
https://karaul.github.io/fitplotter/
it's slower that a local versionm, but it has all the newest features.

(did not notice *.fit files in downloads.zip)

Odd, I just downloaded it and saw the two files?
Tried the new version with my edited file same issue.

Oh I see how the zoom works - cool.

Should I concentrate on the spike filtering or "y"-zoom selection is enough already?
It is hard to imagine an effect of afterward editing, the simplet is just to ignore the edited fields, if they corrupt the structure, but then this  editing is meaningless
I worked a lot if of with the spikes in our physical experiments with real-time dynamics , and I know when the proper zoom eleminates the problem, no forced data correction is needed. It might be needed only for the final quaity-ready publication, which is always static (one could not change zoom), but rarely for analysis. In the course of the analysis one has to work with the true raw data rather then the edited data. One needs to have a very sharp understanding how the data were corrected to avoid self-cheating.

I don't know to be honest. Just for my own enjoyment I'm working on a D3 implementation where I just have a few narrow height strips one after the other. I don't have any issues with the edited data, but then again I'm not mapping it yet. Your plotter is much more sophisticated than mine.
I suspect that because I removed one record leaflet is now working with a discontinuity in the data set. I can imagine a few people wanting to edit their fit files as there are quite a few tools around that allow them to do this. Spike removal would be an interesting bit of code.
As for spikes, well this is the first time I've noticed it with my Garmin speed sensor. I'm not sure what happened. However, I am trying out a Powerpod 3 power meter and that seems to have some flakiness connecting to the sensors so maybe that caused an issue. I certainly didn't have a flawless connection at the start of my ride.
Also Karoo, despite my efforts and their protestations, don't seem to be a company that are that open to getting things done in a hurry. Pity as my first impressions of their computer is favourable, in particular I can see the screen. Its not as tiny as the Garmin 520 plus. But being based on a smartphone could be open to some really cool developments. From their responses and the fact that they map the route, plot elevation and do a few summary statistics, as well as have the option to download the fit file means they must have a database of the ride data. It would be trivial to offer your functionality and hack it to their corporate image.
In fact if I was to suggest a development of the server version it would be to retain all fit files in a (no sql json) database and allow selection and comparison analysis.
By the way what is HRE and how is it calculated? I'm a bit new to some of this fitness analysis stuff as I dont have any (fitness) :)
Keep up the great work.
Regards,
Gordon Moore
<EMAIL_ADDRESS>On 21 Feb 2021, 18:52, at 18:52, karaul<EMAIL_ADDRESS>wrote:

Should I concentrate on the spike filtering or "y"-zoom selection is
enough already?
It is hard to imagine an effect of afterward editing, the simplet is
just to ignore the edited fields, if they corrupt the structure, but
then this  editing is meaningless
I worked a lot if of with the spikes in our physical experiments with
real-time dynamics , and I know when the proper zoom eleminates the
problem, no forced data correction is needed. It might be needed only
for the final quaity-ready publication, which is always static (one
could not change zoom), but rarely for analysis. In the course of the
analysis one has to work with the true raw data rather then the edited
data. One needs to have a very sharp understanding how the data were
corrected to avoid self-cheating.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/karaul/fitplotter/issues/2#issuecomment-782906428

what is HRE and how is it calculated

HRE = heart_rate * pace = number of heart beats per kilometer, it is explained here with example of the analysis
https://drive.google.com/file/d/17wK0y5p7rYlMRBogpZ9yicdnV191E1qx/view?usp=sharing
It is important for marathoners. Below image shows my HRE progress in 2020

That's really interesting.
Regards,
Gordon Moore
<EMAIL_ADDRESS>On 21 Feb 2021, 19:46, at 19:46, karaul<EMAIL_ADDRESS>wrote:

what is HRE and how is it calculated

HRE = heart_rate * pace = number of heart beats per kilometer, it is
explained here with example of the analysis
https://drive.google.com/file/d/17wK0y5p7rYlMRBogpZ9yicdnV191E1qx/view?usp=sharing
It is important for marathoners. Below image shows my HRE progress in
2020

--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/karaul/fitplotter/issues/2#issuecomment-782914310

Also Karoo, despite my efforts and their protestations
I have read their answer. I intended to reply too and offer my service, but in order to reply I needed to register, and I do not want. Anyway, if they are offerring  any sort of collaboration, I will be glad. This project has been started several years ago in matlab, then  with python, and finally with javascript.  In terms of thinking it is the matured project, and JS is just syntaxis, very  convenient and much faster than in python in terms GUI. No run-time libraries is needed, everything is inside the browser.
There are few more ideas I want to realize, so I continue to work on it

Filter to remove spikes is implemented. Tested with "Karoo-14th_ride-Feb-21-2021-123031.fit"
Below are raw data with spikes. The controls to remove spikes are  highlighted:

(1) Select in the droplist  "Click in the legend" option "Apply filter ..."
(2) Behind the  droplist,  set size of the filter more than  1 (at 0 no effect)
(3) Click in the legend on the curve to be filtered, here,  "speed 21.02"
When everything is as should be, there will appear a filtered curve in addition to the  raw one. Other options will be restored, because the filtered operation is dangerous and quickly can make the plot dirty. So filter size will be set 0, and default "Hide/show .." option will be restored
Below is screenshot with the raw and filtered curves

Check that in the droplist  "Click in the legend" is option "Hide/show..."  and click the original  raw curve with spike to hide it, the result is shown below

The filtered curve does not replace the raw one in fit-file dataset, i.e. if you click "Clean plot", the filtered curve disappear, the original raw remains in the y-axis drop list
It is unclear at the moment whether the filtered curve shoul be autmatically added to the the y-axis drop list. The fitplotter has no option to edit and save fit file.
It is an one-dimensional median filter implemented, see https://www.mathworks.com/help/signal/ref/medfilt1.html

I haven't had time yet to play with the filter, though it looks amazing. However, I can confirm that the glitches are to do with the edited file as on my own (very simple) plotter I get the same glitches with the simplest of maps and polylines. I think you can close this as it's not your software. I'll have a play with the filter later on. :)

I've just had a quick play and looked it up, the wikipedia entry is helpful: https://en.wikipedia.org/wiki/Median_filter
Very clever. Am I right in saying that it does change the data slightly?

Yes, it changes just slightly rather than drastically as with Moving_average, For completeness it is necessarry to have both filters. To implement the moving average filter is simpler as the median one .
PS: I did not know about the Wikiedia paper about the median  :)

Another approach I've just tried with my very basic app, is if I find any value greater than 150 ignore it when I scan through the fit object to create my data set for use with D3. (I'm assuming that I'll never go faster than 150km/h even if I fell off a mountain!!! :) The value it discovered was 237 at 1.39351km  Defo a spike! I might have fallen into the canal I was riding alongside! ;)

any value greater than 150 ignore
it's a naive approach to set an allowed range :),  it depends always on the parameter under the consideration  and leads to nowhere, because  there might be always candidates running away.

Fair point. Do you want me to close this, I'm not sure of the protocol for that?

I do not either, I close :) Probably  I should open "Discussion" for general themes - I have seen on option in the settings, but before I need to read manual to understand what is it.
Thank you for the testing.


Update the game over message

Update the game over message so people know how to play again!

You won't be able to approve or request changes to your own pull request.

You won't be able to approve or request changes to your own pull request.


Update API Secret and API for Opensea

Description
Opensea is rolling secrets. This updates the app with the new secret and also upgrades to newer versions of their api. Caching is updated to use ttl with http requests and the random util is now being used.
Copilot

🤖 Generated by Copilot at 418e656
Summary
🆕🚀🧹

Improved the nft app by switching to a newer API, using HTTP caching, and refactoring some code.

The nft app had a makeover
To use OpenSea API v2 and cache over
The old fetching way
That was slow and less stable
And some names and functions got better

Walkthrough

Update OpenSea API calls to use v2 endpoint and HTTP cache feature (link, link, link, link)

Use random.number function from random.star module instead of custom random function (link)
Pass api_key parameter to fetch_collection_stats function for authentication (link)
Rename fetch_opensea_assets function to fetch_opensea_nfts and simplify logic to return a list of NFTs without pagination or extra fields (link)
Remove cache calls from fetch_opensea_nfts function and use image_url field instead of image_thumbnail_url field for fetch_nft_thumbnail function (link, link)
Simplify fetch_nft_thumbnail function to use HTTP cache feature instead of cache module and base64 encoding, and print thumbnail_url for debugging (link)
Update fetch_collection_stats function to return a stats object without extra fields, and change collection_slug to collection to match API response (link)

I have read the CLA Document and I hereby sign the CLA

recheck

I have read the CLA Document and I hereby sign the CLA


Web - Paypal add/edit field loses focus on coming back from new group or search page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Open settings->wallet
If there is existing PayPal account, click on it and click edit and if not, click on add payment method and select PayPal
Open new group/search using keyboard shortcut (i.e. by using CTRL+SHIFT+K or CTRL+K)
Come back and observe that focus is lost from PayPal field

Expected Result:
App should not lose focus from PayPal field on coming back from  new group or search page
Actual Result:
App loses focus from PayPal field on coming back from new group or search page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/0650c111-f8df-4266-82ac-a6dd47b08907
https://github.com/Expensify/App/assets/93399543/d339d0bf-339b-41d2-a3db-34d3fd6565e9
Expensify/Expensify Issue URL:
Issue reported by:  @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692888317278409
View all open jobs on GitHub

I think PayPal going to deprecate https://github.com/Expensify/App/issues/26368

Thank you @pradeepmdk - I was already leaning towards closing this but with that GH you linked I'm confident it's the correct move.
Thanks again!


Adding initial implementation of Slider (only mouse events for now)

Been playing around with styling ranges, it's horrible. I'd avoid it.
I'm experimenting with this strategy:

Take existing <input type="range">
Wrap it in a <label>
Put the fake slider in the label
Move the real range out of view

Now, when you click the fake slider, it focuses the real one. As long as you update the fake slider when the real one updates, voila, you have platform-natural keyboard events and focusing.

Or better still, overlay the real slider over the top of the fake one, give it opacity:0 and clickjack it.

Well, our current approach seems to work reasonably well, even if it's essentially three implementations: one for webkit/blink, one for moz, and one for ms. There's a few issues with animations in some of them, but other than that it's working fine.
Thanks for the tip, though; I may reconsider that at some point, since we're already running js on change anyway.

@sgomes where's the final implementation?

The code is in the material-sprint branch: https://github.com/google/web-starter-kit/tree/material-sprint/app/styleguide/slider
We don't really have an updated version hosted anywhere atm, I'm afraid :-/


SHM Transport documentation update  [8110]

SHM is now built-in transport.
OverflowPolicy parameters removed.

Build status:

Build status:

Build status:


druid ingestion failed after reindexing, due to shardSpec inconsistency

Affected Version
tested v0.17.1 and v0.18.0
Description
druid ingestion failed and showing error message below:
org.apache.druid.java.util.common.ISE: Could not allocate segment for row with timestamp[2020-06-22T04:00:00.000Z]
	at org.apache.druid.indexing.seekablestream.SeekableStreamIndexTaskRunner.runInternal(SeekableStreamIndexTaskRunner.java:707) ~[druid-indexing-service-0.17.1.jar:0.17.1]
	at org.apache.druid.indexing.seekablestream.SeekableStreamIndexTaskRunner.run(SeekableStreamIndexTaskRunner.java:278) [druid-indexing-service-0.17.1.jar:0.17.1]
	at org.apache.druid.indexing.seekablestream.SeekableStreamIndexTask.run(SeekableStreamIndexTask.java:164) [druid-indexing-service-0.17.1.jar:0.17.1]
	at org.apache.druid.indexing.overlord.SingleTaskBackgroundRunner$SingleTaskBackgroundRunnerCallable.call(SingleTaskBackgroundRunner.java:419) [druid-indexing-service-0.17.1.jar:0.17.1]
	at org.apache.druid.indexing.overlord.SingleTaskBackgroundRunner$SingleTaskBackgroundRunnerCallable.call(SingleTaskBackgroundRunner.java:391) [druid-indexing-service-0.17.1.jar:0.17.1]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_201]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_201]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_201]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_201]

by reading the source code, found out that since a while ago, Druid requires shardSpec to be consistent inside a data source to do ingestion.
our ingestion path is from Kafka, therefore the shardSpec is "numbered".
and we also do overnight reindexing, which shardSpec can only choose from either "hashed" or "single-dim".
therefore no matter what the shardSpec will be different. and then ingestion will break like above.
any idea to workaround this ?
any help is appreciated!
thank you

Just randomly found this issue you raised...just curious, is it still happening? I notice the versions you tested are fairly old.. Have you tried it with most recent versions (i.e. 0.22.x)?


Update zendure-solarflow to 1.2.3

Please update my adapter ioBroker.zendure-solarflow to version 1.2.3.
This pull request was created by https://www.iobroker.dev c0726ff.

I would suggest to wait a few days until 1.2.6 is tested at latest.
1.2.3 was available at katest only 3 days, has been replaced with follow up releases very fast and never reached the app 7 days availability at latest.
In addiont please respect versionen in future. new functionality (Add states for pass) should result in a minor version increase. Its ok to leave it for now - but any  (future) breaking change requires a major version increase.

1.2.3 was a good version. Currently I'm rapidly developing and releasing new features as the adapter lacks behind of the official Zendure app. 1.2.4-1.2.6 had a few small bugs I don't want to release to the stable channel. The next possible version is 1.2.7 if no other bugs occur.

Ok, then lets wait for 1.2.7.
If you consider a release should go to stable, please avoid creating new latest releases as the goal of waiting app 1 week minimum is not to make the code older but to keep it available at latest and used for test installs. So if you i.e. create 1.2.4 3 days after 1.2.3 1.2.3 will only be availbale 3 days to be installed.
If you want to continue development I suggest to use -alpha.x releasea as these release can be installed via npm but are not listed at latest repository (at least if using the standard workflow)

And anyway
As you added new features - as far as I read - the new release should be 1.3.x


ODB 'Frozen' Issue

Hi,
Receiving below error after upgrading the version of OrientDB from 2.0.x to 2.1.16. Not immediately but after 30hours of update.
Sep 04, 2016 7:34:32 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:32 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:32 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:32 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:32 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:32 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:32 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:32 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:32 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:32 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:33 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:33 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:33 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:33 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:33 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:33 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:33 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:33 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:34 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:34 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.
Sep 04, 2016 7:34:34 PM com.orientechnologies.common.log.OLogManager log
WARNING: DB is frozen will wait for 10000 ms. and then retry.

Would like to add:
This is the first time we receive this issue in our staging environment.
We have similar setup available in QA & Performance Engineering envs.

Hi, it means that you made a backup of a system but for some reasons, database release was not performed. Could you call release database on this database to fix the issue?

Thanks, Laa.  Would check on this & update this thread shortly.

Hi, Team has used 'release database' last night & the issue raised again now. Can we have a webex on this issue  immediately...? It is too critical for us, as the Stakeholders are performing UAT in staging environment.

Please join the webex at: ciscosales.webex.com/meet/rchencha

Hi Team,
Anybody joining the call?, we are waiting on the bridge.

Hi There, Is there any update on this?? Anybody joining the call?

Hi @rcramu, sorry missed your message. But call will not help to solve the issue.  I may join the call but there is no additional information to discuss.  At this stage, we do not know a reason why it happens. Could you send us a log of your server and thread dump of a server? We will analyse it and in couple of hours will send you solution or will request additional information.

Hi Laa, This is exactly why I am asking to join the call. We keep moving the timeline without any success; When you join the call, you can in fact can go through all info you need, we will allow you to get into the system through webex. Please join. With team's past experience - sharing logs & waiting for your team's response did not work well.
Also, I have hardly very short time to get the RCA & fix for this very critical issue.
Please join, we are still in bridge.

Hi Team,
Thanks for joining the webex call.
Here is the error log as requested:
com.orientechnologies.common.io.OIOException: Found unknown session
Error executing requestcom.orientechnologies.common.io.OIOException: Found unknown session 199857at com.orientechnologies.orient.server.network.protocol.binary.ONetworkProtocolBinary.onBeforeRequest(ONetworkProtocolBinary.java:240)at com.orientechnologies.orient.server.network.protocol.binary.OBinaryNetworkProtocolAbstract.execute(OBinaryNetworkProtocolAbstract.java:214)
com.orientechnologies.common.io.OIOException: Found unknown session 199857
at com.orientechnologies.orient.server.network.protocol.binary.ONetworkProtocolBinary.onBeforeRequest(ONetworkProtocolBinary.java:240)
at com.orientechnologies.orient.server.network.protocol.binary.OBinaryNetworkProtocolAbstract.execute(OBinaryNetworkProtocolAbstract.java:214)
at com.orientechnologies.common.thread.OSoftThread.run(OSoftThread.java:77)
Error executing request
com.orientechnologies.common.io.OIOException: Found unknown session 199858
at com.orientechnologies.orient.server.network.protocol.binary.ONetworkProtocolBinary.onBeforeRequest(ONetworkProtocolBinary.java:240)
at com.orientechnologies.orient.server.network.protocol.binary.OBinaryNetworkProtocolAbstract.execute(OBinaryNetworkProtocolAbstract.java:214)
at com.orientechnologies.common.thread.OSoftThread.run(OSoftThread.java:77)
Error executing request
com.orientechnologies.common.io.OIOException: Found unknown session 199859
at com.orientechnologies.orient.server.network.protocol.binary.ONetworkProtocolBinary.onBeforeRequest(ONetworkProtocolBinary.java:240)
at com.orientechnologies.orient.server.network.protocol.binary.OBinaryNetworkProtocolAbstract.execute(OBinaryNetworkProtocolAbstract.java:214)
at com.orientechnologies.common.thread.OSoftThread.run(OSoftThread.java:77)
Error executing request
com.orientechnologies.common.io.OIOException: Found unknown session 199860
at com.orientechnologies.orient.server.network.protocol.binary.ONetworkProtocolBinary.onBeforeRequest(ONetworkProtocolBinary.java:240)
at com.orientechnologies.orient.server.network.protocol.binary.OBinaryNetworkProtocolAbstract.execute(OBinaryNetworkProtocolAbstract.java:214)
at com.orientechnologies.common.thread.OSoftThread.run(OSoftThread.java:77)
Error executing request
com.orientechnologies.common.io.OIOException: Found unknown session 199861
at com.orientechnologies.orient.server.network.protocol.binary.ONetworkProtocolBinary.onBeforeRequest(ONetworkProtocolBinary.java:240)
at com.orientechnologies.orient.server.network.protocol.binary.OBinaryNetworkProtocolAbstract.execute(OBinaryNetworkProtocolAbstract.java:214)
at com.orientechnologies.common.thread.OSoftThread.run(OSoftThread.java:77)
Error executing request
com.orientechnologies.common.io.OIOException: Found unknown session 199862
at com.orientechnologies.orient.server.network.protocol.binary.ONetworkProtocolBinary.onBeforeRequest(ONetworkProtocolBinary.java:240)
at com.orientechnologies.orient.server.network.protocol.binary.OBinaryNetworkProtocolAbstract.execute(OBinaryNetworkProtocolAbstract.java:214)
at com.orientechnologies.common.thread.OSoftThread.run(OSoftThread.java:77)
Error executing request
and the above set repeats....

MoM (in webex call):

Support member Verified the ODB backup script.
Support member Verified the recent backup log - no errors found
Performed 'relaase database' and successfully executed (checked the server log)
L2 team  restarted the ODB (as suggested by support member) & restarted the auth components (CK) as the DB has been restarted

Next Step:
The ODB support team would analyse the above log & update us on the critical issue

Hi @tglman could you take a look ?

Hi Team,
Any update on this?

hi @rcramu,
Yes i ran a few test with the lvm backup, but i couldn't reproduce this issue.
I'm going to run some tests with the server under load, i'll let you know as soon as i've some results.
Regards

Hi, Thanks for prompt response.
Sure, please keep us posted, as it holds back our delivery pipeline to Production.

Hi @rcramu,
so far i could not reproduce the issue with a working backup, in any case if the backup fail (for example creating the lvm snapshot), it could leave the database in frozen state, do you have the log of the backup.sh execution ?
Thanks

Hi, @rcramu , could you send us logs of backs since the moment DB was frozen, did you execute single backup or several backups during this period of time ?

Hi, we execute single backup at any given time.(once in a day)

Hi @rcamu,
Let me explain in details, as soon as the backup script run, it freeze the database, create a lvm snapshot, and release the database, all freeze and release operation are logged in the orientdb-server.log. The only thing that can happne that leave database frozen is a failure to create a lvm snaptshot, or a failure to connect to the server after the lvm snapshot is done, both of this error should be logged by the backup script. even if a different error happen server side in case of release, that should be logged in both the orientdb-server.log and by the backup script.
So far the only logs that we have are the Found unknown session  that is quite unluckely to be the source of the problem and in any case eny connection problem is reported by the backup script.
If you are running the backup script by a scheduler tool like cron, please double check that it run with the right permission for create the lvm snapshots.
Hope this help to find out the root fo the problmen.
Kind Regards

Hi @rcramu,
Do you have news on this issue? did you try lastest hotfix? do you still have problems ?

hi @rcramu,
We fixed some related issue in 2.2.x so this should not occur anymore, i'm going to close this issue, please reopen if you still have problem.
Regards


[Bug]: #736 Cannot connect a Schema Registry running from another containe…

What does this PR do?
Fix the problem when connecting a schema registry to the Kafka broker running in test containers. Bug #736
Why is it important?
Without the fix, a Kafka broker launched from a Testcontainer cannot be accessible inside the docker network.
That being said, we cannot run a schema registry in a test container and connect to the kafka broker.

Related issues

Closes #737

Hello. Thank you for the quick response.
Yes, that is what I have done. With a particularity for Kafka where we need
to use the network alias in the config KAFKA_ADVERTISED_LISTENERS before
the container starts.
But I do have a workaround creating a new KafkaTestcontainerConfiguration.
As you can see here:
KafkaTestContainersTests/KafkaTestContainerTest.cs at main ·
leonasa/KafkaTestContainersTests (github.com)
https://github.com/leonasa/KafkaTestContainersTests/blob/main/KafkaTestContainersTests/KafkaTestContainerTest.cs
On Tue, Jan 17, 2023 at 3:43 AM Andre Hofmeister @.***>
wrote:

@.**** commented on this pull request.
Thanks for your contribution. If I understood your suggestion correct, the
idea is to assign a network alias that allows other containers to access
the Kafka instance. Developers still need to assign the containers to the
same network, right?
#729 https://github.com/testcontainers/testcontainers-dotnet/pull/729
will enhance the module API a lot. It allows to combine different Docker
resources together, like multiple contains, networks, volumes, etc.The
extension method is not really capable of that.
You figured out a work around in regards of #736
https://github.com/testcontainers/testcontainers-dotnet/issues/736,
right? Do you mind waiting until the new module API is available?
Otherwise, we need to look into the failing test.
—
Reply to this email directly, view it on GitHub
https://github.com/testcontainers/testcontainers-dotnet/pull/737#pullrequestreview-1251120371,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD4YXMZCTOPTT77UGVOOGLWSZLUFANCNFSM6AAAAAAT5EH4MY
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

Since we have migrated to the new module API, this pull request is no longer up-to-date. As a result of the issue #845, I have already updated the startup callback configuration by modifying the KAFKA_ADVERTISED_LISTENERS environment variable. I am uncertain whether the fix resolves your issue as well. I initially attempted to use the network alias, which did not work properly in my setup. I am unsure of the correct configuration to support all of the various use cases. Perhaps we can continue the discussion in the corresponding issue #736 and then create a follow-up pull request. Meanwhile, I will close this issue.


String.prototype.split arity

String.prototype.split can have 0 arity (@see).
Flow throws an error, instead:
105:   return contents
              ^ undefined (too few arguments, expected default/rest parameters). This type is incompatible with
261:     split(separator: string | RegExp, limit?: number): Array<string>;
                          ^^^^^^^^^^^^^^^ union: string | RegExp. See lib: /tmp/flow/flowlib_413f687/core.js:261

The first argument should be separator?: string | RegExp in core.js#L306.

This was solved


[Lab] Improve accessibility of ToggleButton and ToggleButtonGroup

Summary 💡
I'm opening this issue as a continuation of discussion that was initiated in #17187.
ToggleButton and ToggleButtonGroup elements should be marked with appropriate role and aria attributes depending on their usage.
Copying part of my comment from #17187, this is what I envision:

ToggleButtonGroup exclusive selection:

ToggleButtonGroup has role="group" and aria-label="......" attributes
ToggleButtons have role="menuitemradio", aria-checked="true/false", and maybe aria-label attributes.

ToggleButtonGroup multiple selection:

ToggleButtonGroup has role="group" and aria-label="......" attributes
ToggleButtons have role="menuitemcheckbox", aria-checked="true/false", and, if necessary, aria-label="...." attributes

Standalone ToggleButton:

ToggleButton has role="button", aria-pressed="true/false", and maybe aria-label.

It would be great if somebody with more experience in accessibility could chime in.
Examples 🌈
A reference example: http://jongund.github.io/oaa-examples/examples/menubar/menubar-2/menubar-2.html (Jon Gunderson does a lot of work on W3C Aria Practices. I'd consider him a reliable source.)
FWIW, Angular Material's example uses role="group" on their ToggleButtonGroup and role="button" on their ToggleButtons. Their docs only have an example of exclusive selection though. I haven't bothered seeing what they do in a multiple selection scenario, though they describe it: https://material.angular.io/components/button-toggle/overview#accessibility
https://www.w3.org/WAI/PF/aria/roles
Motivation 🔦
Improve accessibility.

I've been researching this further and found https://www.w3.org/TR/wai-aria-practices/examples/toolbar/toolbar.html
In their example, they don't even mark up the Bold/Italic/Underline group as role="group". I wonder if that is intentional... I opened an issue in their repo to find out.

Further, their exclusive selection group (the Left/Center/Right alignment buttons) are marked as role="radiogroup" and role="radio".

It's important to note that their buttons can't be toggled off. One is always selected, so I'm not sure how compatible that example is with Material-UI's exclusive selection behavior where the selected ToggleButton can still be toggled off.

This is probably something we want to punt on until react Flare is concluded. Right now focus managment requires a lot of refs and imperative APIs. From what I can tell these problems get a lot easier with the new event system. Right now everything dealing with refs is a bit sketchy since we have to keep an eye on concurrent react.

Concerning the roles:
It seems like there is no such thing as a group of toggle buttons with regard to a11y. At that point they are purely visual and should be treated either as radio buttons (exclusive selection) or checkboxes (multi-select). The menu prefix is only applied if you have enhanced keyboard navigation implemented (arrow keys + home/end).
So if we discount keyboard navigation we have

<ToggleButton /> => <button aria-pressed />
<ToggleButtonGroup><ToggleButton /></ToggleButtonGroup> =>
<button role="radio" />

<ToggleButtonGroup multiple><ToggleButton /></ToggleButtonGroup> => <button role="checkbox" /> though WAI-ARIA practices use <button aria-pressed />

It seems like checkboxes or togglebuttons are not supposed to have group characteristics. We would need to check how assistive technology treats a generic role="group" around checkboxes/togglebuttons which is currently out of scope for us. Simply following the WAI-ARIA implementation does sound viable though.

Counterpoint (at least concerning the multiple selection toggle-buttons):

The trouble with using form elements is their longstanding association with the collection of data. That is, checkboxes and radio buttons are established as controls for designating values. When a user checks a checkbox, they may just be switching a state, but they may suspect they are also choosing a value for submission.

_https://inclusive-components.design/toggle-button/_
However it doesn't explain how you would communicate that selecting one toggle-button deselects another for exclusive selection toggle-buttons, if they are not identified as a radio buttons.

@mbrookes I would encourage that we have a close look at how ckeditor and tiny cloud handles the concern. They have been here for a decade, I would expect that they spend a reasonable amount of time on the topic. At least, to a level that matches the importance of the concern.

I'm missing that part as well. From a UX standpoint toggle buttons are meant for switching state + submitting it. For example if you have a dark mode switch on your site it should be a toggle button if a click immediately applies the styles. It should only be a switch if you're on a settings page and have a separate "save settings" button. For me personally https://uxplanet.org/checkbox-vs-toggle-switch-7fc6e83f10b8 made the most sense for explaining when a toggle button should be used.
However this distinction cannot be expressed for screen reader users if you have a group of toggle buttons where only one can be selected. WAI-ARIA implements this with radio buttons but those are used in a form with a submit button as well.
It basically requires working with screen reader implementors to convey these different UX patterns. I think <button role="radio" /> comes very close to the origins of this pattern (see actual play+pause radio buttons).

I would expect that they spend a reasonable amount of time on the topic.

This is a dangerous assumption. The time a thing has existed does not imply many time was spent iterating on that thing.

@eps1lon I think you might be mixing up three different things here: toggle button, switch and checkbox. (There is a distinct ARIA role for switch separate to button pressed="true | false".
The UX Planet article only addresses the latter two.

if you have a dark mode switch on your site it should be a toggle button

According to the UX Planet article, in the particular context in which it is used, that should be a switch.

It should only be a switch if you're on a settings page and have a separate "save settings" button

According to the UX Planet article, that should be a checkbox, which concurs with the paragraph I quoted above, and makes good old common sense. You could also infer the reverse - checkboxes should be used to apply state without a separate submit button.

I think  comes very close

It certainly seems to most appropriate pattern under the circumstances, but I would love to hear (or read) some expert opinion. @Heydon any thoughts?

the origins of this pattern (see actual play+pause radio buttons).

Historical nitpick: the origins, as the name suggests, are from radios, where the toggle button would select a pre-tuned radio station. With a  reel-to-reel tape player (and later cassette player and early VCR with mechanical switches) on the other hand, the pause button was independent of the play / record buttons - turning on "pause" didn't disengage "play", "stop" did; the difference being that play and stop mechanically engaged and disengaged the play-head, where pause simply stopped spooling the tape.

The UX Planet article only addresses the latter two.

I totally read that as toggle button because that's the only thing that would make sense. If a switch immediately commits the state then where is the distinction to toggle button? So yeah I misinterpreted that article when it comes to switches vs toggle buttons since it never acknowledges toggle buttons. It only talks about toggle switches (which is a tautology to me since a switch can only ever be toggled).

the pause button was independent of the play / record buttons - turning on "pause" didn't disengage "play"

Yeah I did mix up some words here. What I meant was that the play/pause for a cassette are what to multi-selectable toggle button group is while the rest is the classic toggle button group or rather what is expressed in the WAI-ARIA implementation: radio buttons. The native radio buttons don't look anything like actual radio buttons to me. Real radio buttons are more like toggle buttons to me which is expressed by aria-pressed while native radio buttons or checkboxes have aria-selected/checked.
I'm kind of focusing on the word "button" here which means clicking it triggers an action e.g. commits a change. With that meaning radio buttons are almost always not suited for forms since you usually select them and then submit which is already doable with a listbox. Depending on multiselectable you would have the native radio buttons or checkboxes. I could go on but so many of these concepts are mixed and depending on where or when you started learning native UI elements you understand them differently. This is why I prefer specifications for these things since native UI elements (especially in browsers) are such a rabbit hole.


Fix mock restRequest

In MockRestRequest header, if the key is ambry internal key, don't throw any exception when the value is not all ascii.

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8d0712f) 72.44% compared to head (7fd219d) 33.45%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2600       +/-   ##
=============================================
- Coverage     72.44%   33.45%   -39.00%
+ Complexity    11407     5107     -6300
=============================================
  Files           805      805
  Lines         64943    64944        +1
  Branches       7924     7925        +1
=============================================
- Hits          47050    21725    -25325
- Misses        15307    41521    +26214
+ Partials       2586     1698      -888

Files
Coverage Δ

...src/main/java/com/github/ambry/rest/RestUtils.java
60.61% <ø> (-31.85%)
:arrow_down:

...in/java/com/github/ambry/rest/MockRestRequest.java
0.00% <0.00%> (-68.66%)
:arrow_down:

... and 540 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Use percents

what if the parent resizes and the splitter goes out of view?

Hmmm...
Percentages aren't going to be pixel perfect so if you resize and re-calc to a percentage you might end up with a jumpy slider - especially on small sizes.
Might be worth a look though.


[FR] Compile Shared Library

What's the problem this feature will solve?
As discussed in #2806 and in this stack overflow post there is demand for compiling dynamic libraries as part of the setuptools build process and then linking against them in python extensions or using them with ctypes or other tools.
I believe currently people either pre-compile the shared library before or have a hacky extension to setuptools.
Describe the solution you'd like
I would like to propose that setuptools adds native support for compiling shared libraries as part of the build process.
I don't know exactly how this would be implemented but my though process was that another command would be added eg build_shared_clib to complement the existing build_clib and another argument would be added to setup() eg shared_libraries to compliment libraries
Alternative Solutions
Compile the shared library separately.
Manual plugin like in the stack overflow post.
https://github.com/mdavidsaver/setuptools_dso
Additional context
I would be interested in helping getting such a feature implemented.
Is this something that setuptools would be interested in merging?
Code of Conduct

[X] I agree to follow the PSF Code of Conduct

Reading around some more, there seem to be issues with import paths.
Python extension modules will look for shared libraries next to them and in some other locations as discussed here
That would raise some issues if the dependent python extensions were not all next to the shared library.
dll directories can be manually extended but I assume setuptools wouldn't want to do that.
I also have the use case where I have one python package that depends on the C API of another package which I was planning on exposing through a shared library. This also has the import path issue.
Extra reading:
https://discuss.python.org/t/installation-of-shared-objects-into-separate-folder/8489
https://discuss.python.org/t/wheel-depending-on-shared-library-from-another-wheel/26456