Support for IAM Roles for Service Accounts for EKS

Is your feature request related to a problem? Please describe.
It is not a problem for me, for now I'll create access key and secret but would like to have support for IAM roles, so that only pods have needed iam role for the S3 output pligin or cloudwatch output plugin
Additional context
https://aws.amazon.com/blogs/opensource/introducing-fine-grained-iam-roles-service-accounts/

I think the S3 output now has all the needed properties. Since the last release we added all the missing  auth configs to cloudwatch output #273 .You can change the fluentd service account if you want. I'm going to close this ticket, but if you are missing anything please reopen it, and let us know.

@ahma I couldn't test it, but I checked #273, I'm not proficient with go, but I can see support for assume instance role is there, which the pod can inherit from node.
But this issue is about kubernetes service account integration with AWS IAM roles. In short we do following:

In AWS create roles with following policy:

{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Effect": "Allow",
      "Principal": {
        "Federated": "${OIDC_ARN}"
      },
      "Action": "sts:AssumeRoleWithWebIdentity",
      "Condition": {
        "StringEquals": {
          "${OIDC_URL}:sub": "system:serviceaccount:${NAMESPACE}:${SA_NAME}"
        }
      }
    }
  ]
}

In kubernetes we need to create a service account and annotate it with the role and use this service account in pods.

Then EKS automatically adds AWS_ROLE_ARN, AWS_WEB_IDENTITY_TOKEN_FILE (volume mount) env variable to pod. So, we need support for assuming roles via web identity token.

Thanks @sudip-moengage , I will look into this. -> reopen

@sudip-moengage In this case you can annotate the SA If you annotate the fluentd/fluentdbit resources Docs

@ahma Yes, I can annotate but, the SDK fluentd uses, does it support sts:AssumeRoleWithWebIdentity?

Hi @sudip-moengage,
the root cause for this issue is that the AWS Ruby SDK in the latest fluentd-s3-plugin doesn't support those environment variables injected by EKS in this case (AWS_ROLE_ARN and AWS_WEB_IDENTITY_TOKEN_FILE).
Please follow https://github.com/fluent/fluent-plugin-s3/issues/301 for further details. Once that plugin gets updated with a more up-to-date AWS Ruby SDK this will work automagically in more recent release of that plugin.
We can't solve this issue from the logging-operator, so I'm closing this now.

@sudip-moengage just submitted https://github.com/fluent/fluent-plugin-s3/pull/305 to resolve the issue upstream, I hope it gets merged soon enough 🙂

@gregorygtseng seems that you are right. Having annotation set as fluentd.annotations annotates a fluentd pod, but not service account. Is there a way to let operator set SA annotation?

no, currently you cannot

@pepov thanks for prompt reply
Shell we reopen this issue then?
I confirm that SA annotation is the only missing feature to fully support IRSA for EKS.


Inset padding dialog

Description
InsetPadding not working correctly in AlertDialog / Dialog
 _showDialog() {
    showDialog(
      context: context,
      builder: (_) {
        return AlertDialog(
          insetPadding: EdgeInsets.all(0.0),
          content: Center(child: Text('asd')),
        );
      },
    );
  }

Despite EdgeInsets.all(0.0), horizontal still has a padding value
solution -> BoxConstraints minWidth
Related Issues
#61154
Tests
test case : checked Dialog width, height by insetPadding zero value
https://github.com/flutter/flutter/pull/64900/commits/fa64fe93ccedab4c244f5403978dda578fd345ce
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].

[x] No, no existing tests failed, so this is not a breaking change.

@darrenaustin
It's been a while since I requested a PR, can you check it?

@darrenaustin
How long do I have to wait?

Probably having the same issue.
The Dialog is still not respecting the padding constraint on current stable.

Probably having the same issue.
The Dialog is still not respecting the padding constraint on current stable.

The Dialog() widget works fine!
It's the Flutter's way of lay-outing Widgets which is producing quite the opposite results.
Here's the rule: Constraints go down.  Positions are set by parents.
The AlertDialog() is implemented using a ConstrtainedBox() with minWidth: 280.
Thus, if the child of the AlertDialog() occupies less width or does not explicitly provides a width, than the minWidth property of the ConstrainedBox() is used and the width of the AlertDialog() will be fixed at 280.
If you want to use the insetPadding property properly, you can wrap the child of AlertDialog() with a SizedBox()/Container() with width:  MediaQuery.of(context).size.width.
PS: I recommend you to read this blog for a proper understanding of the Flutter layout rules: https://medium.com/flutter-community/flutter-the-advanced-layout-rule-even-beginners-must-know-edc9516d1a2

This PR has not been updated in a while, it has merge conflicts currently and the last comment indicates it may be resolved. I am going to close this for now, but if you would like to come back and work on it, feel free to re-open! Thank you for the contribution!

Commenting here because the original issue was locked.
It is 2024 and I don't really understand why this issue has not been fixed yet.
According to the comments above insetPadding seems to work fine in Dialog but not in AlertDialog.
"If you want to use the insetPadding property properly ..." - what does that mean? It is up to me as a developer to make sure that the insetPadding works properly? I don't think so. Do I need to understand the obscure inner workings of AlertDialog to be able to fix this issue? I don't think so.
If I set insetPadding: EdgeInsets.all(8.0) then I expect that there is always a gap of 8 around the AlertDialog. It is totally unexpected behavior that the AlertDialog may be smaller, e.g. in case of a shorter error message.
The syntax and documentation of AlertDialog does not really explain that the value given is not applied as a fixed value but can lead to varying results.
I don't think it is really clear how  "Constraints go down. Sizes go up" is implemented in AlertDialog. For instance, if the property would have been named minInsetPadding it would be much more obvious that this is a constraint instead of a fixed value.
Also, adding another "SizedBox()/Container() with width: MediaQuery.of(context).size.width" as suggested above just adds more boilerplate and makes the code less understandable, more error-prone and harder to maintain.
Actually, I'm wasting a lot of time on issues like these doing trial and error to figure out why something is not working as expected and trying to find solutions on stack overflow that fix the problem. (Also ChatGPT/Copilot is not very helpful in such cases)


Add "finished" signal to ResourceInteractiveLoader

Godot version:
3.1 beta10
Issue description:
It would be useful if ResourceInteractiveLoader had a finished signal, emitted when loading is finished. With this and an yield, we could use it even without additional thread.

AFAIK ResourceInteractiveLoader was deprecated with the introduction of the new threaded loading that makes this feature probably unnecessary.


Don't append the relative path to the images referred from the internet in documentation

Merged as part of #42


⚠ Samsung has degraded performance

In e918e8f, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 3130 ms

Resolved: Samsung performance has improved in b122bd7.


Add 3 benchmarks for the matrix exercise

So that students can readily run benchmarks when they are trying to
improve the performance of their solution.

To be honest, while there's nothing wrong with this, I don't really see the need for benchmarks.
In my experience, students are only too ready to benchmark anything and everything. It's sometimes a struggle to persuade them that there are other desirable aspects to code over and above performance. Readability, for example.

The background for this change is a solution in which I want to teach the student about how preallocating space for data structures like slice can improve performance. Ideally, I would let him/her try to compare the results of the before/after benchmarks, but I can't find any in this track.
I don't think they would somehow encourage the student's tendency to focus only on performance, because it's not a required step to complete the track. It's not introduced in the instructions. But when we do need to let the student compare the benchmarks, it would be handy.

I'm not objecting to this, just sounding a note of caution. When students see things in the exercise code, they're apt to read too much significance into them. If they see a benchmark, they may assume that the criterion for acceptance is for the code to be as fast as possible.
And it's very hard for them to let go of the idea that the benchmark inputs are representative of real-world inputs, which they aren't. Most real performance problems occur at scale with real user requests and resources in contention, which is difficult to benchmark.
I understand your point about wanting to demonstrate the benefits of a more efficient approach to something. But I often find I can do this by helping the student reason out why it's better, not just prove that it is. "This way allocates 100GiB of stack every time we call the function, whereas this way..."

LGTM

I see that you changed the signature of the example New() function to return Matrix instead of *Matrix. One problem with this is that if the student defines Matrix as a struct type, this throws compile errors in the tests:
# matrix [matrix.test]
./matrix_test.go:156:10: invalid operation: m == nil (mismatched types Matrix and nil)
./matrix_test.go:277:12: invalid operation: matrix == nil (mismatched types Matrix and nil)

Structs can't be nil, whereas a slice can. It's actually very common for students to implement Matrix as a struct type, so I think it might be an idea to go back to expecting a pointer. Alternatively, if we require Matrix to be a slice type, then we should probably say that in the instructions, shouldn't we?

I see that you changed the signature of the example New() function to return Matrix instead of *Matrix. One problem with this is that if the student defines Matrix as a struct type, this throws compile errors in the tests:
# matrix [matrix.test]
./matrix_test.go:156:10: invalid operation: m == nil (mismatched types Matrix and nil)
./matrix_test.go:277:12: invalid operation: matrix == nil (mismatched types Matrix and nil)

Structs can't be nil, whereas a slice can. It's actually very common for students to implement Matrix as a struct type, so I think it might be an idea to go back to expecting a pointer. Alternatively, if we require Matrix to be a slice type, then we should probably say that in the instructions, shouldn't we?

I agree with you. Although it's better to use Matrix instead of *Matrix when it's a slice, this is an implementation detail not required in the instructions.
Sorry for the not well-thought change, I'll change it back later.


Implement opcode formatting

Right now use another mapping to go back from opcode to opcode name as we don't have this in huff libs
Let's see if we can have better usage

very cool!


OADP-2686: add ACM resources to restore priority

/lgtm

/test 4.11-operator-e2e-aws

I think CI was flake https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_oadp-operator/1179/pull-ci-openshift-oadp-operator-master-4.11-operator-e2e-aws/1712080406334935040/artifacts/operator-e2e-aws/e2e/build-log.txt (at the end, says success) If someone wants to override

INFO[2023-10-11T14:01:41Z] Step operator-e2e-aws-e2e succeeded after 56m49s.

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_oadp-operator/1179/pull-ci-openshift-oadp-operator-master-4.11-operator-e2e-aws/1712080406334935040#1:build-log.txt%3A77
/override ci/prow/4.11-operator-e2e-aws


My goto Adonisjs boilerplate

Boilerplate with authentication and api integration examples.
Signed-off-by: Mike Conrad<EMAIL_ADDRESS>

Thanks! ;)


Send token_url in private message

Currently using msg.reply... we should use private messaging.

@mosheBelostotsky could you give me some pointers in how we could do this right now with the current adapters?

Done


started overview page

started an overview page, mostly just checking that my branch is working an I can make prs to master

👍


resource-aggregate: fix tests

Duplicate publish and unpublish events are skipped and return
nil instead of array with empty value.

Cherry-picked to the http-gateway-provides-metadata branch


Bubble Sort

Hello @rudrakshi99  I am Sonal Singh. A GSSoC'21 participant. I would like to add the bubble sort technique in the code . My folder would be arrays. I have read the contribution guidelines and would like you to assign this to me.

hey @tarun26091999 @rudrakshi99 under gssoc'21 can i work on this issue in oython
Thank you!

*python

@rudrakshi99  I would like to add c++ code for bubble sort under GSSOC'21.Can I work on this ?

Hello, I would like to contribute to this project in c++.
->with O(n*n) time complexity
->with O(1) space complexity
I am a GSsoc'21  participant.
waiting for a positive response.

Hello,
I would like to contribute to this issue in java as a GSSoC 2021 participant
kindly assign me the issue

I'm a  participant from GSSOC'21. Kindly assign me this issue.

Duplicate of #440


xsignal and SA_RESTART

Typically, the SA_RESTART flag is desired behaviour for establishing signal handlers (and this is what the signal functions in glibc and musl do). I'm not sure if there's a specific reason this isn't being used, but if not, it might be worth considering changing xsignal to call xsignal_flags with SA_RESTART instead of 0 as the flags argument.

It leads to a lot of situations where "I hit ctrl-c but can't break out of the read() because it endlessly restarts". Your signal handler has to siglongjmp() rather than being able to check toys.signal in the processing loop.


Skyline/work/20220713 share replicate files

Added the ability to include raw files when sharing a skyline document. Users can now select which files to include in the zip file. Should files be misplaced users can now navigate though their file system and either select the individual missing files to include or select a folder that contains missing files. All discovered missing files are added to the selection where users can decide weather or not to include them in the zip.

Thanks for the review. Clark is headed back to school so I'll handle the last bits of polishing on this PR.

OK, I have this pretty well buttoned up now. It would be great if you guys can find some time to try it out.

If I try to include some Bruker .d folders in my .sky.zip, I get the error "The zip file is not a shared file".
I think we need to make SrmDocumentSharing.FindSharedSkylineFile tolerant, so it allows folders whose name ends in ".d".
Also, I think we should probably disable the "Include results files" checkbox if the target Skyline file format is less than or equal to 22.2.

Yes, your first point rather leads to the second. Thanks!

Remember that Waters uses .raw folders. We have a class that checks if a
folder is a mass spec “file”.
On Fri, Sep 9, 2022 at 3:49 PM nickshulman @.***> wrote:

If I try to include some Bruker .d folders in my .sky.zip, I get the error
"The zip file is not a shared file".
I think we need to make SrmDocumentSharing.FindSharedSkylineFile tolerant,
so it allows folders whose name ends in ".d".
Also, I think we should probably disable the "Include results files"
checkbox if the target Skyline file format is less than or equal to 22.2.
—
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/2227#issuecomment-1242538837,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYBWUHFJJI4KVOPDLJPWP3V5O5H5ANCNFSM57CHSDDQ
.
You are receiving this because your review was requested.Message ID:
@.***>

Remember that Waters uses .raw folders. We have a class that checks if a folder is a mass spec “file”.

Note that what's being inspected here isn't a directory on disk but rather the contents of a .zip file, so the class you mention isn't directly applicable here, but I expect I can abstract it to deal with both cases.

Moved these changes to a new pull request.


Run Vsbridge Dataprovider before Custom Dataproviders

#316 Run Vsbridge Dataprovider before Custom Dataproviders
module-vsbridge-indexer-core/Indexer/GenericIndexerHandler.php line 165
without sorting, the custom data providers are called before the core data providers (f.e. if the vendor name starts with A or B)
but  only with the core data providers the necessary attribute values are added
only if we have the attribute values, we can implement logic based on Attribute Indexes
there is no option to sort data providers by xml

Did you add module dependencies in your custom module?
e.g.
        <sequence>
            <module name="Divante_VsbridgeIndexerCatalog"/>
        </sequence>

Than your XML should be load later...

Yes we have set a sequence in our module so there is a dependency between our module and the indexer module.
You can reproduce it. Create A Module with f.e. Vendor name B. add the Divante_VsbridgeIndexerCatalog as dependency  Create a dataprovider f.e. with name b_dataprovider.
And Take a look in the getDataProvider and the array behind them. You Will see the the B dataprovider are before the divante dataprovider

OK. But still, I would go with the option to add sortOrder to data providers.

To add a sortOrder Option in the dataprovider xm/xsdl snipped will be the best solution. How long dou you need to implement this?


build.rs cannot output error?

Hi,
I just happened to notice that your build script is using eprintln!(). Unless something has changed since I fixed the same problem in libpulse_sys back in June, this is going to fail to output the expected error should a failure occur since output is suppressed unless cargo is run with -vv, and that'll leave users clueless as to what went wrong.
The fix I used for libpulse_sys was to switch to println!() (I confirmed that this was indeed necessary) combined with prefixing the message with cargo:warning=. Like this:
println!("cargo:warning={}", e);

See: https://doc.rust-lang.org/cargo/reference/build-scripts.html#cargowarningmessage
I just happened to notice while exploring switching libpulse_sys from pkg-config to system-deps like you have done.
I have not actually confirmed that the failure to output the error message happens for your crate, but I strongly suspect it does. I'll leave it to you to confirm and patch.

Thanks, that definitely makes sense to go via cargo:warning there instead.


[FEATURE REQUEST] Overview pages for non-blog content

I have several different types of content on my website, and it would be nice to have an overview page for them.
This is my content layout:
.
├── homepage
│   └── about.md
├── posts
│   ├── test.md
├── projects
│   ├── lash.md
│   └── marswm.md
└── tut
    ├── _index.md
    └── sp2
        ├── _index.md
        ├── ue01.md
        ├── ue02.md
        └── ue03.md

With my current theme there are overview pages generated for /projects /tut and /tut/sp2:

You can also see for yourself.
However with Texify3 the overview pages are empty and therefore not really navigateable:

It would be great if there were a template to cover those overview pages (I think in hugo they are called "list pages" or something).
Thanks for your efforts!

The subdirectories in the /content/ directory are called sections.
You can create pages for your sections by adding a layout for each section.
For example, to create a page for your "projects" section:

Create a file /layouts/projects/list.html
You can copy the contents of layouts/_default/list.html from this repo to that file
In line 37, change "pages" to "projects"


feat(edgestacks): support kubernetes edge stacks

EE-393

Closes https://github.com/portainer/portainer/issues/5472


try to get tests to run

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[X] Reset the build number to 0 (if the version changed)
[X] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

i give up. I think pytest is either:

running in a different directory to the one containing the test folder, or
the test folder no longer exists. (It's definitely in the pypi tarball)
NB works just fine on the travis conda build


crash in bgfx

void memCopy(void* _dst, const void* _src, size_t _numBytes)
{

#if BX_CRT_NONE
memCopyRef(_dst, _src, _numBytes);
#else
::memcpy(_dst, _src, _numBytes);
#endif // BX_CRT_NONE
}

I've updated bgfx to master. Can you still repreoduce this. Can you give me a more detailed repo? Platform, renderer, callstack, some use case, because crash in memcpy tells me nothing.


change the event color

how can I change the event's color

@bibhu-padhy Take a look at the View Customization section in README. It introduces quite a few template allow you to apply your own look and feel.


support truncate cuda version for image build [skip ci]

cuda image has add the update version to image tag since 11.2+, e.g.
11.2.<update_version>-runtime-ubuntu18.04
Since cudf + cudatookit do not care about the update's version, we need to truncate it.
Tested locally.

build


[Form Recognizer] "Could not access Azure blob storage account." in USGOV and China Clouds

We are running live Tests against other clouds like US Gov and Azure China Cloud. The goal is to check whether new azure sdk package work with other clouds or not.
Error Description:
When running the test test_custom_forms_from_url_async.py::TestCustomFormsFromUrlAsync::test_custom_form_continuation_token, it runs failed and the error message is shown as following, for more details please check here:

test(test_content_from_url.py::TestContentFromUrl::test_content_multipage_url) error message:

Expected Behavior:
Please create Azure storage account and upload blobs to the corresponding container in UsGov and China Clouds.
@benbp, @jameszliao-msft, @lmazuel, @meeraharidasa , @mayurid, @catalinaperalta for notification.

Hi @v-xuto! I'm checking whether we already have storage accounts available with these files for the USGov and China clouds. Will let you know soon!

Hi @v-xuto, if you leverage sub-config-gov-test-resources in your test configuration yaml instead of the current sub-config-azure-cloud-test-resources that should set everything up and work as expected with the test_resources.json if you're using that for testing. See how we set up our subscription configuration here in tests.yml.

@catalinaperalta I have already added sub-config-gov-test-resources and sub-config-cn-test-resources in formrecognizer/tests.yml in my PR. For more details about pipeline results please click here.
@catalinaperalta @benbp Through the error message and local testing, maybe because not all containers and blobs are created in the storage account (azuresdktrainingdata) in UsGov and China, please help to create containers and upload blobs, make it the same as the storage account(azuresdktrainingdata) on Public.
Or give me the subscription permission of the storage account (azuresdktrainingdata) on Public,  and I will create the required containers and upload blobs in UsGov and China.

@benbp Who can help me to create containers and upload blobs in Usgov and china? Or give me the subscription permission of the storage account (azuresdktrainingdata) on Public.

Hey @v-xuto, I requested access myself to the USGov cloud, but I am still waiting for permission to access it. Once I have it, I can check whether the container has all of the necessary content uploaded. I will check with @benbp about who can be granted permission.

@catalinaperalta and I worked to grant access to USGov.

I've checked the storage container in USGov and there were several missing blobs. I have uploaded those blobs that were missing and are used in our tests. @v-xuto please let me know if the tests in USGov can pass now.
As for the storage container in the China cloud, I am still working with Ben to get access. Will let you know when I have an update with that one.

@catalinaperalta  I rerun the weekly pipeline and found that there are still some missing blobs, such as: testingdata/label_table_variable_rows1.pdf. For more details please click here.
@benbp Could you give me the subscription permission of the storage account (azuresdktrainingdata) on Public? I check and upload blobs, maybe more efficient. Because I have the permission of UsGov and China.

@v-xuto on Tuesday I updated the testingdata container to include missing files that weren't added from the public cloud. However, I did notice several other differences between the public cloud containers and the us gov containers. I will be correcting these differences today. I will let you know once those updates are complete.

@v-xuto sorry for the delay, the US Gov containers look complete to me now. I've been trying to upload blobs to the China cloud containers but I'm having access issues, I'll talk to Ben about it. If you already have access to both the USGov and China cloud accounts you could start copying the blobs from USGov to the China cloud containers.

@catalinaperalta - We have access to both the UsGov and China cloud accounts, and we have uploaded the blobs in China cloud. We've tried all the tests locally and pass.
But UsGov and China's tests in the pipeline always fail. It's the latest result in pipeline, you can get the details at here .
Error description:

We are confused about the difference in results locally and in the pipeline, and not clear what happened in UsGov and China clouds. Could you help to take a look? Thanks.

@zedy-wj - Thanks for uploading the blobs to the China cloud account. I triggered a build yesterday and have been looking through the results. I'm not seeing errors related to missing files anymore in the storage accounts. I also just checked again and saw that @v-xuto triggered a couple of builds yesterday and US Gov passed, as well as several environments in the China cloud. The containers for both the US Gov and China clouds seem complete now with the tests passing. The errors you're seeing now are due to another issue that I'm looking into where some tests fail occasionally when downloading images or attempting to access the storage blob accounts, I will let you know when I have a solution or workaround.

@catalinaperalta -

For live tests: Error: The file is corrupted or format is unsupported. After we increase the expired time of sastoken, it is no longer reproduced.

For samples tests: some tests fail occasionally when downloading images or attempting to access the storage blob accounts. We try to add retries(now the number is 5 times) in the tests to make the results of the pipeline more stable, and it also no longer has such errors at this time, but we don't think it's the best solution. Do you have a better suggestion?

For more details click here: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1420526&view=results

@zedy-wj I have implemented a similar workaround by adding a sleep time between each test. The concern with the retries is that the service may still be affected with increased requests, but since it is for the samples which are a limited number of calls, I think that solution can remain for now and we can revert once the environments are more stable. I do agree that these are not the best solutions and I am following up with the service team to get these environments more stable. A question though, were smaller increases in the expire time of the SAS token not effective?

@catalinaperalta - Since the service's response time on the UsGov and China clouds is also unstable, we set the timeout time for the form recognizer pipeline to be 400 minutes, sometimes even timeout, so it is set for 8 hours, but for now, 5-6 hours after stabilization is enough.

@catalinaperalta - Most of the environments in UsGov have timeouts, and we set the timeout to 8 hours. After investigation, it was found that the current running of a single test for up to an hour caused the current timeout. Could you help to take a look?

@zedy-wj this seems to be a service issue. I will reach out to them and work out what the problem is. I will update here when I have more information.

@zedy-wj the service team says the issue has been mitigated. Please let me know if you are seeing that? Thanks!

@catalinaperalta - FormRecognizer is currently able to pass stably on UsGov and China clouds, thank you for your help, we will close this issue, if the same problem occurs again, we will reopen it.


Fixed broken link in readme.

Coverage remained the same at 98.901% when pulling 49b22396444229c11a054f8272e36130177ffc82 on RebeccaStevens:readme-link-fix into e55d66c6dfaf5e8edc12425dfd192cb897da89c4 on jonaskello:master.

Thanks!


[TRANSLATION] EN to KO: Measure-crp

translated Measure-crp.

LGTM 👍 I've addressed some nits, please check them. :)


Header rearrangement

Move the headers into places as discussed offline.
Manually fixed ordering of include headers.
Most of the user level code should not need to include grpc++/support code.
Split stream.h into async and sync versions.
This is based on #3008 which needs to be merged first.
This fixes #2827.

greenish

Github link sent me elsewhere; for historical purposes: https://grpc-testing.appspot.com/job/gRPC_pull_requests/2348/ indicates green enough.


GodRays from shader material

We have an animated shader material representing illuminating background. Then this background we d like to apply god rays. Feels like shader material should produce texture at some level so should be possible but not sure how this is better to approach.
Any hints on implementation?
Our animated shader background:

How we would like it to behave:

Hello! This is a question for the forum ;)

Oh, sorry =)


Download information is missing while in VLC Play

What version of WebTorrent Desktop? (See the 'About WebTorrent' menu)
latest
What operating system and version?
win32
What did you do?
tried it out
What did you expect to happen?
there is no status information being shown when user plays with VLC, the page has VLC and file title. but missing speed download and how much downloaded. when user clicks back. it just shuts down VLC
What actually happened?
missing status when playing with VLC

Not a bad idea.


Re-Enable Debug.Log of PowerUp level. I need to check something for QA.

you can always add a debug.log line to a script and just stash those changes so it isn't committed if you need to do some testing!


fixes Bug 1141287 - Remove _json_clean function

@peterbe can you have a look ?

Coverage increased (+0.01%) to 90.44% when pulling 2c48194204c52eddfaa04d5f9634a350b653c4bc on aarshvig:patch-7 into 49a9664741d7e2a77e0df638d99aad9d96703629 on mozilla:master.


merge from arlac77/template-github,arlac77/template-kronos-module

README.md

docs(README): update from template

.travis.yml

chore(travis): (jobs.include)
chore(travis): remove true (jobs.include.deploy.skip_cleanup)
chore(travis): add false (jobs.include.deploy.cleanup)

:tada: This PR is included in version 8.3.21 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Drop explicit product type list from integrator

Is there an existing issue for this?

[X] I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?
CUrrently, we have explicit list of product types (families) defined in integrate.py global integrator that is limiting on what instances this integrator runs. If you add your new product type no matter how simple it is, you need to change code in ayon-core to integrate it.
How would you imagine the implementation of the feature?
We should drop this list completely and use integrate = True/False on instance to determine if it should be integrated or not to unbind it from the host specific and workflow specific definitions. This needs to be done before we split to multiple repositories otherwise any addition to host addon will need also change in ayon-core.
Are there any labels you wish to add?

[X] I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:
We cold add that list to Settings but then we just change the place where we maintain list of product types.
Additional context:
No response
[cuID:AY-4138]

We could add that list to Settings but then we just change the place where we maintain list of product types.

Plus that it's much harder for studios to keep this synced to future updates - because they might already have their own overrides on top of the defaults. Not sure if that's a good workflow.


Edit Item > Authorizations > Policy Group change does not appear

Describe the bug
In DSpace 7, Edit Item > Authorizations..., e.g. https://demo7.dspace.org/items/03731881-2185-4baf-a6a8-1438a4d29dc8/edit/authorizations, after one changes a Policy Group, no Group appears for that Policy.
To Reproduce

Before any changes, Policies for Bundle ORIGINAL is Group="Anonymous."

I have changed Policies for Bundle ORIGINAL to Group="rebit ecm." This change does not appear (no Group appears).

I refreshed the page. The new Group="rebit ecm" now appears.

Expected behavior
After a policy is changed and saved the new group should immediately appear.
Related work
Link to any related tickets or PRs here.

This is a subset of problem described in #644 (which is the larger issue), see this comment: https://github.com/DSpace/dspace-angular/issues/644#issuecomment-1137766491
Nonetheless, I'm going to leave this open until #644 is resolved.  I suspect they are essentially the same issue.

It looks like this is an issue with the invalidation of the alternative links on the policy object after it has been updated.
We should also take the opportunity to refactor the ResourcePoliciesComponent itself to get rid of the method calls for the eperson and the group in its template as those are horrible for performance (they'll be re-evaluated multiple times per second)
This will take an estimated 12 hours
Atmire would like to claim this task

@artlowel : That sounds reasonable & I'll assign this ticket & #644 back to you for your team to work on.

I have tested this with DSpace 7.4 on DSpace 7 Demo and the new group immediately appears after a change. Thank you for fixing this.


Raise error on unrecognised error key

If an unrecognised error key is returned from the API then we should
raise an exception as it implies a form error.

:+1:  once Travis pulls his finger out.


llama.cpp on spark

Hi djl developers,
I'd like to combine the image classification on spark demo and chatbot demo to build llama.cpp on spark, following the design and conventions in djl spark extension.
I find in both image cls on spark demo and djl spark extension code, the core part is like df.mapPartitions(transformRowsFunc), with a model loading process like modelLoader.newPredictor() in transformRowsFunc`. It seems the model would be loaded for one partition and then released, and loaded and released for another.
I test loading resnet 50, that takes about 0.3s, which is totally acceptable for predicting an amount of images in a partition. However, for llama model, (e.g., llama-2-7b-chat.Q5_K_S.gguf 4.65G), it takes 13s for each loading process and seems too long and somehow redundant.
Is there any solution to reduce or minimize this model loading time on spark?

Duplicate of https://github.com/deepjavalibrary/djl/issues/3079


What react versions work with the latest react-slick version?

Installing react-slick fails for react versions >= 17.0.0 (at least for me).
Is this correct? If so, is there a newer pending version of the carousel?
Thank you,

John

The latest version of react-slick works with React 18 as well
https://github.com/akiran/react-slick/blob/master/package.json#L93


Move tab to new window

So many times in the past few months, I've tried to drag a tab out of the window to create a new window and move it to that, or right-clicked a tab to find a "Open in new window" menu item. Can you add one? I don't know why I keep thinking/assuming it exists, but it doesn't, and it'd be great if it did.

This is basically this (out most upvoted request ever).
The workaround is "Duplicate Workspace in New Window"

Which will open the workspace in a new window, in which you can open the tab. there are also some extensions available that add a context menu item for this if you search "tab in new window" in the market place.

They're not quite the same issue. Moving the current tab to a new window is semantically different than reopening the workspace in a new window.
Often, opening a file will open it in the current workspace when it's intended to open it in a new window/workspace, so moving it out fixes that. This is just one example.
The extensions you mentioned, at least the most popular one I found, assume that the tab belongs to a file, but the tab may be an unsaved document that the user wants to move to a new window.

I see, does "File: Open Active File in New Window" do what you want?

With an unsaved file, it says "The active editor must contain an openable resource." That's the same as my third paragraph in the last thing.

passing to @bpasero for the issue of not being able to open an untitled file in a new window.

This issue has been reported already in either this or a similar form. Please check the label that was assigned to this issue to find it.


Singularity Stability Tweaks

About the PR
Aims to make the singularity more stable overall, and add slight depth to the different power levels. The singularity was getting loose on its own again, so I spent a few hours looking at different values figuring out what to tweak. Now, level 1 on the PA will keep the singulo at a level 3. Level 2 will increase the singularity to level 4, and will eventually loose it, but you have time to react. Level 3 will loose the singularity but it won't be nearly as instant anymore due to increased energy level requirements between stages.
This allows some level of reaction time to potentially stop sabotage in the form of the PA computer being messed with. Syndis that snip the emitter wires will also loose it, but it shouldn't be nearly as destructive since the singulo will have a much harder time growing, potentially giving more options for sabotage besides just ending the round.
Fixes #18825
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

tweak: Changed singularity energy levels to require more energy overall to increase in size.
tweak: Changed singularity energy drain rates to keep them more stable, and die quicker without food.
tweak: Changed level 2 and 3 PA to feed less energy, slowing the speed of a singuloose slightly.

If you put "fixes #18825" in somewhere in your main comment, it will auto close the issue when it's merged.

If you put "fixes #18825" in somewhere in your main comment, it will auto close the issue when it's merged.

Thanks

I know what I'm doing :)


Added Services Submenu for MacOS

Issue 1628

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

LGTM thanks 👍


ci: cancel running workflows when branch updated

What this PR does / why we need it:
cancel ci in progress
Which issue(s) this PR fixes:

Fixes #
Which docs this PR relation:
Ref #
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer:

Codecov Report

Merging #186 (cf40781) into main (9d310b6) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   41.24%   41.25%   +0.01%
==========================================
  Files          83       83
  Lines        5720     5720
==========================================
+ Hits         2359     2360       +1
+ Misses       3361     3360       -1

Impacted Files
Coverage Δ

core/mempool/src/tx_wrapper.rs
89.28% <0.00%> (+1.78%)
:arrow_up:


Broken Documentation Link

Am trying to read through the documentation and found this broken link:
https://docs.asp.net/en/latest/security/data-protection/compatibility/replacing-machinekey.html
Keep up the good work :)

? The link above works...


Help: Target Year 2025

Hi, can the Help Target Year for 2025 be added?
In settings:

Thanks, @EnM4st3r , I'll make an update on this soon.
I'm also thinking if there's a better way that can avoid making an update every year on this field ...


[WIP] Initial checkin of Dashboard image preview

Summary of Changes
Include a summary of changes then remove this line
Tests
What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes, including screenshots of any UI changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes all tests documented in the developer guide

Codecov Report

Merging #423 into master will increase coverage by 0.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   78.42%   79.27%   +0.85%
==========================================
  Files         196      159      -37
  Lines        4889     3373    -1516
  Branches      638      493     -145
==========================================
- Hits         3834     2674    -1160
+ Misses       1009      692     -317
+ Partials       46        7      -39

Impacted Files
Coverage Δ

amundsen_application/api/issue/issue.py

amundsen_application/tests/test_utils.py

amundsen_application/api/utils/response_utils.py

amundsen_application/base/base_mail_client.py

amundsen_application/api/log/v0.py

amundsen_application/api/utils/request_utils.py

amundsen_application/api/__init__.py

...on/proxy/issue_tracker_clients/issue_exceptions.py

amundsen_application/base/base_preview_client.py

...pplication/proxy/issue_tracker_clients/__init__.py

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c83aa61...2f3cade. Read the comment docs.


Code enhancements

Problem

Package upgrade impossible when using dev branch of the code

Solution

Made some necessary changes

PR Status

[x] Code finished and ready to be reviewed/tested
[x] The fix/enhancement were manually tested (if applicable)

Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

!testme


feat: update trace profiling protocol

Reference https://github.com/apache/skywalking-query-protocol/pull/111
Video
https://user-images.githubusercontent.com/20871783/228215542-f849c779-001e-4601-adc5-1317ebd11d53.mov
Signed-off-by: Qiuxia Fan<EMAIL_ADDRESS>

Could you provide an image when the span cannot be profiled?
We do not have a multi-segment situation in the current demo environment.

Besides the un-profilied span, @mrproliu do we have mock data about the cross-thread profiling? I think we need to check whether the segments are linked and whether the stack is able to support this case.

For now, I just check it locally. Tomorrow, I will change the "songs" service to use Undertow as Web Service in the test environment, then let @Fine0830 try it out.

What is the condition of un-profiled span? @mrproliu

For now, I just check it locally. Tomorrow, I will change the "songs" service to use Undertow as Web Service in the test environment, then let @Fine0830 try it out.

Make sense. FYI @kezhenxu94 To adopt the new profiling feature, we are going to make the songs service somehow has x-thread tasks in the workflow.

What is the condition of un-profiled span? @mrproliu

https://github.com/apache/skywalking-query-protocol/blob/master/profile.graphqls#L137 as false

I don't found the mock data about un-profiled span. Can you provide this? @mrproliu

Add a tip for un-profiled spans.
https://user-images.githubusercontent.com/20871783/228427875-5cbc3f07-2e25-4e23-94ea-88bf6631777d.mov

@mrproliu Is undertow the un-profilied span? I thought we have it profiled.

@mrproliu Is undertow the un-profilied span? I thought we have it profiled.

The "/songs" is un-profiled span. The real code is running on the "UndertowDispatch".

Are there any further questions? @mrproliu @wu-sheng

I had a discussion with @mrproliu. He will forward the conclusion to you soon, I think. :)
There are some polish requirements at here and trace page.

Done
https://user-images.githubusercontent.com/20871783/228523237-21675cb5-31b8-4c73-a333-a4825b30b720.mov

Let's add the icons to the List view of the trace too. It should be helpful

Let's add the icons to the List view of the trace too. It should be helpful

Done

Add tips
https://user-images.githubusercontent.com/20871783/228706205-81c77fe2-16ce-45d3-ad94-a69e3a1d77f1.mov


About text should be updated to remove reference to usage as a wrapper

Currently the "About" text says:
About

Lab wraps Git or Hub, making it simple to clone, fork, and interact with repositories on GitLab

From my understanding the project has moved away from recommending lab as a wrapper around git.
This is the "About" text seen when going to: https://github.com/zaquestion/lab

And probably the README should be updated also to remove examples of using as a wrapper.

@JohnVillalovos yes, well pointed!
This rewording should've happened some time ago already.
I'll add it to my TODO list for next week.

@bemeng, did you get this done?

@prarit not yet. But will do.

@bmeneg
The About text on the page https://github.com/zaquestion/lab still says it should be used as a wrapper:

Oops, that's something we need help from someone else: @zaquestion we merged the new readme file some time ago, would you mind updating the "about" words?


Add mapping to table of add file/folder plus note about default mapping

Updated the table to include the default mapping for adding a file/folder.
Also tweaked the text a litte to point out there is no default set for Move.

Many thanks :)
I'm afraid it conflicts a bit with https://github.com/nvim-telescope/telescope-file-browser.nvim/pull/6/files where I already address some of these things -- so I plan on incorporating this PR one way or another soon enough.
At the same time I need to properly test https://github.com/nvim-telescope/telescope.nvim/pull/1473 before I want to settle on mappings (and how they are set by default here in telescope-file-browser).
I'll most likely be will be keeping telescope involvement at a bare minimum practically speaking up until end of February (full force on work til end of this year + travelling almost entire January, if pandemic still/will/... allows it).

Yes. No worries 👍


Can this library do np.matmul()?

multidimensional matrix multiplication?
Supported? Example? thanks

Of course, read the README
PS: broadcasting not supposed yet


DOC-463: Added note about dropping unique indexes

Fixes DOC-463

Added a note to clarify unique indexes created with CREATE TABLE cannot be dropped without the CASCADE flag

This change is


there seems to have been no way to actually use the cache with MedGenFetcher?

Perhaps I am misunderstanding how to use this module, but if so I figure a pull request is better than a bug report.
As it previously was, I could never get results to cache.
With this change
fetch = MedGenFetcher(cache=True)

works, while (I believe) preserving all previous behavior.

Hi @cariaso -- Thanks, I'll merge this in!  I admit that the medgen side of the code has been languishing for lack of my own usage (I no longer work directly on biomedical topics), so it's great that you're using this.
Thanks again!


update state hook docs with function argument

Update of state hook documentation with function as a possible argument to set function.

makes sense, I haven't noticed the functional updates part in hooks API reference - people tend to look for the whole info about useState in it's own page I believe. I will take a look if there is any spot to put reference there. Thanks for the review Sophie!


Ensure exclusions are set before reading settings

After some investigation, I discovered that SCRAPEOPS_SETTINGS_EXCLUSION_LIST is not being honored because the settings are getting fetched and cached before the exclusion list is set meaning that only the default exclusions (API_KEY, etc) are honored

Thanks for spotting that - I'll release a new version update on pypi now


Illegal CPU instruction! bug

librealsense
2.40.0 RELEASE

OS
Windows

Intel RealSense Viewer / Depth Quality Tool has crashed with the following error message:
Program terminated due to an unrecoverable SEH exception:
Illegal CPU instruction!
Possibly newer CPU architecture is required

Hi @TheOnePharaoh   This error message is not a bug.  The link below provides an explanation of why the message occurs and the solution for it.
https://github.com/IntelRealSense/librealsense/issues/6599#issuecomment-692654324

Case closed due to correct answer provided and no further comments received.

Case closed due to correct answer provided and no further comments received.


How to support automatic refresh in Power BI Service

My colleague has been happily using my auto-refreshing custom connector to connect to their Power BI Desktop report.  He tried refreshing the data in Power BI Service however but it didn't work (see below).

Once published it won't allow me to refresh the data as it gives message below saying the data sources don't support refresh. I've got it working for other data sources (Oracle databases etc) on the Power BI Service as it's just a case of getting a data gateway setup. You can then schedule to refresh the data once you have provided database credentials etc.

I've tried formatting my Authentication block like so https://docs.microsoft.com/en-us/power-query/handlinggatewaysupport#example-connector-with-a-url-parameter , but to no avail.  I have no mandatory parameters in my ManagementInformationConnector.Contents method.
Any assistance gratefully received!
Here's my example code.
testPath = "<ExampleApiManagementName>.azure-api.net/";

shared ManagementInformationConnector.Contents = (optional environmentNameFromPowerBi, optional endpoint, optional id) =>
... ;

ManagementInformationConnector = [
    TestConnection = (testPath) => { "ManagementInformationConnector.Contents" }, // this doesn't seem to actually work?
    Authentication = [
        OAuth = [
            StartLogin = StartLogin,
            FinishLogin = FinishLogin,
            Refresh = Refresh,
            Label = Extension.LoadString("AuthenticationLabel") // this causes a null reference failure
        ]
    ],
    Label = Extension.LoadString("DataSourceLabel")
];

StartLogin = (resourceUrl, state, display) =>
    let
        codeVerifier = Text.NewGuid() & Text.NewGuid(),
        authorizeUrl = "https://login.microsoftonline.com/" & environmentVariables[AzureTenantId]{0} & "/oauth2/authorize?" & Uri.BuildQueryString([
            client_id = environmentVariables[AzureClientId],
            resource = environmentVariables[AzureResource],
            response_type = "code",
            response_mode = "query",
            redirect_uri = redirect_uri,
            code_challenge_method = "plain",
            code_challenge = codeVerifier,
            state = state,
            login = "login"
        ])
    in
        [
            LoginUri = authorizeUrl,
            CallbackUri = redirect_uri,
            WindowHeight = windowHeight,
            WindowWidth = windowWidth,
            Context = codeVerifier
        ];

FinishLogin = (context, callbackUri, state) =>
    let
        parts = Uri.Parts(callbackUri)[Query],
        result = if (Record.HasFields(parts, {"error", "error_description"})) then
                    error Error.Record(parts[error], parts[error_description], parts)
                 else
                    TokenMethod(parts[code], "authorization_code", context) // code is the authorization code itself
    in
        result;

Refresh = (resourceUrl, refresh_token) => TokenMethod(refresh_token, "refresh_token");

TokenMethod = (authCode, grant_type, optional verifier) =>
    let
        codeVerifier = if (verifier <> null) then [code_verifier = verifier] else [],
        codeParameter = if (grant_type = "authorization_code") then [ code = authCode ] else [ refresh_token = authCode ],
        query = codeVerifier & codeParameter & [
            client_id = environmentVariables[AzureClientId],
            client_secret = environmentVariables[ApiManagementClientSecret],
            grant_type = grant_type,
            redirect_uri = redirect_uri
        ],

            tokenResponse = Web.Contents("https://login.microsoftonline.com/" & environmentVariables[AzureTenantId]{0} & "/oauth2/token",
            [
            Content = Text.ToBinary(Uri.BuildQueryString(query)),
            Headers = [
                #"Content-type" = "application/x-www-form-urlencoded",
                #"Accept" = "application/json"
            ]
            ]),
        parts = Json.Document(tokenResponse)
    in
        // check for error in response
        if (parts[error]? <> null) then
            error Error.Record(parts[error], parts[message]?)
        else
            parts;

The Extension.LoadString("AuthenticationLabel") part results in an
"Error loading extension: [Expression.Error] We cannot convert the value null to type Text"

Hi everyone!
I found the answer here:https://community.powerbi.com/t5/Report-Server/Query-contains-unsupported-function-Function-name-Web-Contents/td-p/887698
Essentially my query needed splitting into base url and relative path.  I was still able to keep a variable in the base url, which made environment switching much easier.  This is an edited code snippet:
environmentName = "dev1"

GetJobsData = ((offsetAmount as number) as record =>
let
    Source = Json.Document(Web.Contents("https://" & environmentName & "myURL.net",
    [
        RelativePath = "api/jobs" & "?offset=" & Number.ToText(offsetAmount)
    ]))
in
    Source)

Hope this helps!


[WIP]: Change consider_bankruptcy to use UserPresence instead of pointer.

https://github.com/zulip/zulip/issues/4120
Currently in the process of moving the bankruptcy check from the frontend to backend as detailed in
https://github.com/zulip/zulip/issues/4120#issuecomment-321090438.

I'm not sure this accomplishes everything that the original issue requests. It seems like the information in the original issue is quite dated. Some things that need to be improved include the commit message and ideally including some comments (https://zulip.readthedocs.io/en/latest/contributing/code-reviewing.html#anyone-can-review).


vbr.wocr.tk is down

vbr.wocr.tk is down

Should be fixed now...
Seems like the container crashed when CountAPI went down... (probably going to deploy my own storage backend in the future...)

oh yeah, works perfectly! Thanks.

Awesome! Good to hear!


WebGL Support

Hi, I need WebGL support on Homuler project. When is this support coming?

Duplicates #49
Maybe when you send me a PR.


fix filePushOrder sort

Fixes #527

[ ] npm run test succeeds.
[ ] npm run lint succeeds.
[ ] Appropriate changes to README are included in PR.

the .sort() returned b - a instead of a - b hence producing bogus nonIgnoredFilePaths
I don't have time to properly build and test

Sorry. No time for proper tests. the above changes have been verified by patching the files.js directly (ugly)

Sorry, I can't merge PRs that aren't tested. In addition, the comment above the PR's code is wrong with this change.
We'll have to wait until a proper build and test is in place.


Change deprecation from bundle list to bundle show

What was the end-user problem that led to this PR?
I understand that bundle show will be removed in Bundler 2.0, not bundle list.
https://github.com/bundler/rfcs/pull/6/files#r125875779
In the current message, there is a possibility of misleading the command which will be removed in Bundler 2.0.
What was your diagnosis of the problem?
I think that it is better to display bundle show instead of bundle list in the deprecated warning.
What is your fix for the problem, implemented in this PR?
Change the deprecated warning from bundle list to bundle show.
Why did you choose this fix out of the possible options?
I thought that changing the console message was a simple and effective change to the end user.

@colby-swandale please review?

This looks fine but @indirect are we ok to change an existing deprecation message?

Yeah, I think this is fine... printing a deprecation message doesn't count as semver imo 👍🏻
@koic thanks!
@bundlerbot r+

Thank you all!


product side panel lost stickiness

Expected Behaviour:
when scrolling side panel will stick to top
Actual Behaviour:
Steps To Reproduce:
scroll in product show page

packages/admin/resources/views/partials/products/editing/sections.blade.php
product page bottom bar not full width when side bar collapsed


Cleanup to use imported targets.

Cleans up find_package(Qt) to use imported targets rather than legacy variables.
Also updates CMake minimum version to 2.8.12.

@mathstuf Looks reasonable?

+1


Process JSON read from S3

Added StreamingJsonProcessor and hooked to S3 JSON read
Update StreamingJsonProcessor.cs
Split the StreamingJsonProcessor into general processor and pluggable implementations
Add tests for S3StoredJsonProcessor

Note: I have very strong suspicion that the actual "thing" that is being changed by the processor is probably not exactly what we want, but primarily focused on the speed and ability to do /any/ processing.
Hence I'll be very gracious, if I'm indeed wrong as to what should happen to JSON that we read from S3, if you could e.g. suggest a test that will verify it is what it should be, and I can amend the code :D

I think this is fine for now, all we need to rewrite is the top level id initially from one form to the other.

Is my assumption that we "replace" the top-level id with the provided slug right? Or do we need the stored id to "take part" in the conversion? :D

Moving forward we might need to rewrite a few other values, like "partOf" ids for Manifests if it belongs to a collection - in this instance we might need to know the context of the current token (ie this id is child token of partOf) - would that just be an expansion of S3ProcessorCustomState?:

yes, the idea is that we can expand the S3ProcessorCustomState to keep track of whatever we need (but until we need it, it's trying to be relatively light). Naively we can just keep track of StartObject and EndObject, which allows us to keep e.g. a Stack that will tell us the path (or do whatever else).
Also in case we want to do different processing elsewhere this provides the "scaffold" of reading/writing tokens, and we can "plug in" however simple or complex operations to it.

@p-kaczynski are you able to fix the broken test for this?

Tests now clear


HBox in perspective overlaps toolbar

When creating an perspective with an HBox instead of an SplitPane the HBox overlaps the toolbar

The new DefaultWorkbenchDecorator uses a different layout structure than before so this issue is not valid anymore. If you need the "old" decorator you can overwrite the getWorkbenchDecorator method in your application launcher and provide the DefaultLegacyWorkbenchLauncher.


dependence_plot: scale axis, increase size, ...

Hello,
it's not in documentation, and not in the example, but can we play somehow with the dependence_plot?
Thank you for this wonderful tool!

Glad it's helpful! ...dependence_plot uses matplotlib, so if you pass show=False then you can keep calling matplotlib functions to adjust the figure:
import matplotlib.pylab as pl
shap.dependence_plot("RM", shap_values, X, show=False)
pl.gcf().set_size_inches(12, 5)
pl.show()


Broker side ZK metadata based segment pruner.

Segments can be pruned out at broker side, before routing queries
to server. Pruning at broker side can only happen based on
information available in SegmentZKMetadata.

SegmentZKMetadataPrunerService is initialized at the time of
starting the broker. It configures pruners specified in the config.

Added SegmentZkMetadataPruner interface for all ZK metadata based
pruners. Added one implementation of this interface PartitionZkMetadataPruner
that prunes segments based on partition metadata.

Added unit test for new functionality.

Pruning is not yet hooked up in scatter/gather code yet. Two options there are:

Prune segments upfront, and dynamically build routing table for selected segments.
This approach requires building routing table dynamically for each query.

Prune segments after getting one of the pre-computed routing tables.
This approach may not yeild balanced routing tables, number of segements
to process may be skewed for different servers.

Codecov Report

Merging #1532 into master will decrease coverage by 0.03%.
The diff coverage is 56.62%.

@@            Coverage Diff             @@
##           master    #1532      +/-   ##
==========================================
- Coverage   67.89%   67.85%   -0.04%
==========================================
  Files         792      796       +4
  Lines       38693    38775      +82
  Branches     5049     5067      +18
==========================================
+ Hits        26271    26312      +41
- Misses      10711    10741      +30
- Partials     1711     1722      +11

Impacted Files
Coverage Δ

.../broker/pruner/SegmentZKMetadataPrunerService.java
100% <100%> (ø)

...ot/broker/requesthandler/BrokerRequestHandler.java
86.33% <100%> (+0.04%)
:arrow_up:

...broker/pruner/SegmentZKMetadataPrunerProvider.java
41.66% <41.66%> (ø)

...pinot/broker/pruner/PartitionZKMetadataPruner.java
41.86% <41.86%> (ø)

...t/core/data/partition/ModuloPartitionFunction.java
72.72% <50%> (+6.06%)
:arrow_up:

...kedin/pinot/broker/broker/BrokerServerBuilder.java
86.79% <60%> (-1.33%)
:arrow_down:

...edin/pinot/broker/pruner/SegmentPrunerContext.java
83.33% <83.33%> (ø)

...not/core/query/pruner/DataSchemaSegmentPruner.java
53.65% <0%> (-4.88%)
:arrow_down:

...time/converter/stats/RealtimeColumnStatistics.java
70.31% <0%> (-3.13%)
:arrow_down:

...ealtime/converter/RealtimeSegmentRecordReader.java
82.35% <0%> (-2.95%)
:arrow_down:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b933bcc...54f20da. Read the comment docs.


JCE cannot authenticate the provider BC

Exception in thread "main" java.security.NoSuchProviderException: JCE cannot authenticate the provider BC
at javax.crypto.JceSecurity.getInstance(JceSecurity.java:101)
at javax.crypto.Mac.getInstance(Mac.java:222)
at pdi.jwt.JwtUtils$.sign(JwtUtils.scala:121)
at pdi.jwt.JwtUtils$.sign(JwtUtils.scala:150)
at pdi.jwt.JwtUtils$.sign(JwtUtils.scala:159)
at pdi.jwt.JwtCore$class.encode(Jwt.scala:80)
at pdi.jwt.Jwt$.encode(Jwt.scala:23)
at pdi.jwt.JwtCore$class.encode(Jwt.scala:109)
at pdi.jwt.Jwt$.encode(Jwt.scala:23)
at pdi.jwt.JwtCore$class.encode(Jwt.scala:149)
at pdi.jwt.Jwt$.encode(Jwt.scala:23)
i use SBT assembly
i learn scala recently, i don't know how to fix the bug, maybe you can give me some advise.
Thanks.

I also encounter the same problem  when assembled by  sbt-assembly

Sorry to hear that @epiphyllumh. I've never used sbt-assembly and don't really have time to give it a try but if you can debug where the problem come from, I will fix it ASAP.

The reason is: JCE requires JAR with Bouncy Castle to be signed and creating executable jar(fat-jar) ruins it.
Here's an solution.
First your could exclude bcpkix in build.sbt. Or make bcpkix to a provided dependency
    libraryDependencies ++= Seq(
      "com.typesafe.akka" %% "akka-http"            % akkaHttpVersion,
      "com.typesafe.akka" %% "akka-http-spray-json" % akkaHttpVersion,
      "com.typesafe.akka" %% "akka-stream"          % akkaVersion,
      ("com.pauldijou"    %% "jwt-core"             % "0.14.0").exclude("org.bouncycastle", "bcpkix-jdk15on"),
      "org.bouncycastle"  %  "bcpkix-jdk15on"       % "1.57"          % Provided,
      "com.typesafe.akka" %% "akka-http-testkit"    % akkaHttpVersion % Test,
      "org.scalatest"     %% "scalatest"            % "3.0.1"         % Test
    )

Then download the two bouncycastle dependencies's jar file. Move them to jre/lib/ext and modify jre/lib/security/java.srcurity accouding to answer from jiangzx
Here's an example Dockerfile for CI building(basically the same steps).
FROM example.com/base/java

RUN mkdir /app
WORKDIR /app

COPY lib/bcpkix-jdk15on-1.57.jar /opt/jdk1.8.0_111/jre/lib/ext/
COPY lib/bcprov-jdk15on-1.57.jar /opt/jdk1.8.0_111/jre/lib/ext/
RUN echo "security.provider.10=org.bouncycastle.jce.provider.BouncyCastleProvider" >> /opt/jdk1.8.0_111/jre/lib/security/java.security

COPY target/scala-2.12/app-assembly-0.1-SNAPSHOT.jar .
COPY run.sh .
RUN chmod +x /app/run.sh
ENTRYPOINT ["/app/run.sh"]

The version 3.0.0 has resolved this issue. Need not do this ~ see this PR: https://github.com/pauldijou/jwt-scala/pull/126/commits/940c14371dd30edd2f79ba366724bc94dbee80d0#


Add requirement for "node" to starter installation instructions

Not everyone has node installed. I followed the instructions as given in https://www.lazyvim.org/ and installed all requirements, but upon initial start of nvim (and all subsequent starts) Mason threw an error for being "unable to install jsonls". Installing node fixed this, though I'm not sure if that's what should be the default.
In any case, I think that if the starter requires node to not throw an error every time, it should at least be mentioned in the requirements if that's OK. Or remove jsonls from the defaults.

Fixed in https://github.com/LazyVim/LazyVim/commit/fa6cbfc6020efcd2168ffe09a209037599b91442


Keyboard minus key is not working on sensor settings page

Description:
When setting the alert range manually on sensor settings page I cannot set the negative minus character from keyboard for some reason. I'm using UK keyboard on the phone and language is set to English.
https://github.com/user-attachments/assets/2ea80671-42da-43ba-9a85-d46e5ce3408a

Why high priority? Works ok with Google keyboard. It can be reproduced with samsung keyboard. Unfortunatly I can't make samsung keyboard to show minus for decimal input. Probably it's a bug of Compose, maybe will be fixed in next versions.

Decided to show normal keyboard for now

QA passed


Uncaught TypeError: Luminous is not a constructor

I got drift to work after following @paulstraw's temp fix for Browserify. But with luminous I haven't been as successful. I get Uncaught TypeError: Luminous is not a constructor when running the "browserified" version of the following code in the browser.
var Luminous = require('luminous-lightbox/dist/Luminous.min.js');
new Luminous(document.querySelector('#myimg'));

Where Luminous is an empty Object {}.
Using Browserify @ 13.1.1.

@jmagnusson, I think this was happening because noParse needs the full path. Can you try it with the value of require.resolve('luminous-lightbox')?

I'm having the same issue, although I'm using the CLI like: ($ browserify js/main.js --noparse=$PWD/js/luminous.js)
@paulstraw, I think you're describing is the issue where browserify seems to ignore the noParse option if the path is't absolute. I had that issue initially, only to get exposed to this one. I'm not sure this is is related, what do you think?

You're totally right, I was misunderstanding the original error. I've submitted a PR that reworks how Luminous interacts with build tools like Browserify. You shouldn't need to do the noparse stuff anymore, and should be able to require('luminous-lightbox') directly, as expected.
In my tests, this is working great. I've also got a friend who's using Luminous in one of his projects giving it a go. It would be awesome if either of you could try #35 before I merge it in, as a sanity check. There's more details in that branch's readme.

Hmm, I'm getting Cannot find module 'babelify'…. If I then install babelify it throws similar errors for Babel presets.
I'm not using any babel-related things on my current project. Not sure why browserify is trying to  process the module. Either with or without the noparse option.  Does this make any sense to you?

Ah, I forgot to mention that these changes now no longer require noparse. Can you give it a go without?

Turns out, I had to bump babelify, babel-preset-es2015, and babel-preset-stage-0 up to dependencies in Luminous' package.json. @marcohamersma, if you npm update luminous-lightbox while it's pointed at that branch, this should work now. Let me know!

Right, that's it! works like a charm 👍

This has been fixed and released as 1.0.1: https://github.com/imgix/luminous/releases/tag/1.0.1


Access Token & Refresh Token storage best practice

I have a couple of questions after working through the "Switching to Hybrid Flow and adding API Access back" quick start.
I thought one of the benefits of Hybrid Flow was that it avoided the Access Token and Refresh Tokens from being passed to the client via the browser channel. However ,the quickstart appears to show those tokens being saved to a cookie by setting SaveToken = true and then using HttpContext.Authentication.GetTokenAsync to retrieve the tokens when needed.
Is this considered best practice or just a shortcut in order to demonstrate the flow?
If I wanted to capture the tokens and hold them server side only I presume I could set SaveToken to false. If I did this, which event on OpenIdConnectOptions should be handled in order to retrieve the tokens? Would I have to hit the TokenEndpoint myself?
Thank you

It is definitely not a "bad practice" from a security point of view at least. The cookie is signed and encrypted.
The downside is that the cookie gets bigger.
I can't remember which events you need to use to take over storage yourself - you need to poke around yourself.

Thanks for the information.
Changing to SaveToken = false prevents the tokens being saved to the cookie, but the downside is that the identity token is also dropped, which makes the Logout flow more difficult to implement.
I should have played around sooner. Handling OnTokenResponseReceived looks like the event I need. I will investigate further to see if I can keep Savetoken = true but use this event to both extract the Access and Refresh tokens and prevent them from being put into the cookie.
Thanks again!

So handling OnTokenResponseReceived does allow me to read and store away the Access Token and Refresh Token. I can also set the RefreshToken property of TokenEndpointResponse to null which prevents it from being stored in the cookie. However, setting the AccessToken to null causes an error (which can be caught using the OnAuthenticationFailed handler):

IDX10336: Both 'id_token' and 'access_token' should be present in OpenIdConnectProtocolValidationContext.ProtocolMessage received from Token Endpoint. Cannot process the message.

This error is raised by the ValidateTokenResponse extension method in OpenIdConnectProtocolValidator. It is called as part of the HandleRemoteAuthenticateAsync in the OpenIdConnectHandler class whilst dealing with Authorization Codes. Unfortunately there is no where to hook into the process between the validation call and the SaveTokens call.  SaveTokens will blindly save all tokens it can find (AccessToken, IdToken and RefreshToken). The only workaround would be to hande the Authentication Code myself as the existing code does not revalidate the tokens if a HandledCodeRedemption is returned from the OnAuthorizationCodeReceived event handler.
So, as it stands, the Access Token will always get saved into the cookie unless you use a brittle workaround. I think I'll just live with the Access Token being saved!
BTW This has been raised as an issue already
https://github.com/aspnet/Security/issues/1101

I would like to see a special event that just deals with token storage. And not trial & erroring through the other events to find the right place in time to manipulate their context.
Maybe you should open a new issue for that.


WW-4558 contentType override ignored for JSONInterceptor

From now on:
The "accept" request header parameter must be "application/json" or "application/json-rpc"
Also the default encoding is "UTF-8"

Closing to test travis integration - reopen shortly.


Fix snapshot version

According to https://oss.sonatype.org/content/repositories/snapshots/uk/co/chrisjenx/calligraphy/ the snapshot version is 2.1.1 and was published on February the 29th this year.

Great catch, thanks for updating this.


Add WGAN/InfoGAN/DiscoGAN Keras implementation

Keras implementation of Paper: Wasserstein GAN
Train a simple wgan on MNIST to generate handwritten digits.
Requirements: tensorflow >= 1.4.0; Keras >= 2.1.0
Code ported from Keras-GAN
LICENSE: MIT

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: nuaajeff sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Keras implementation of Paper: Information Maximizing GAN
Train a simple dcgan on MNIST to generate handwritten digits.
Requirements: tensorflow >= 1.4.0; Keras >= 2.1.0
Code ported from Keras-GAN
LICENSE: MIT

Keras implementation of Paper: DiscoGAN
Requirements: tensorflow >= 1.4.0; Keras >= 2.1.0
Code ported from Keras-GAN
LICENSE: MIT

Thank you for your submission. There is some conflict with the master branch. Pls. resolve the conflicts and commit again. Thanks!

Thank you for your submission. There is some conflict with the master branch. Pls. resolve the conflicts and commit again. Thanks!

All the conflicts have been resolved.

Can you please advise how I can unsubscribe from receiving this emails?
Thank you,
Yelena
From: TobeyQin<EMAIL_ADDRESS>Sent: Monday, April 2, 2018 2:00 AM
To: Microsoft/samples-for-ai<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [Microsoft/samples-for-ai] Add WGAN/InfoGAN/DiscoGAN Keras implementation (#22)
Thank you for your submission. There is some conflict with the master branch. Pls. resolve the conflicts and commit again. Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fsamples-for-ai%2Fpull%2F22%23issuecomment-377888993&data=02|01|yelenah%40microsoft.com|c10c5d2a9eb943486fa208d598781726|72f988bf86f141af91ab2d7cd011db47|1|0|636582563912112177&sdata=OPcMRHJk5bwZk1jeplYFJUlJFq810XiIp2oblf2bEkE%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAC4U6I5ybUq5BgKotZcHh4r90WSOvTO4ks5tkeiEgaJpZM4S6Jut&data=02|01|yelenah%40microsoft.com|c10c5d2a9eb943486fa208d598781726|72f988bf86f141af91ab2d7cd011db47|1|0|636582563912112177&sdata=PYPWDYe3qiaGr%2BNT8veNtUxtGsWh6uQUAV7EvPBAriE%3D&reserved=0.

+1
Sent from my iPhone

On Apr 2, 2018, at 4:25 PM, yelenah<EMAIL_ADDRESS>wrote:
Can you please advise how I can unsubscribe from receiving this emails?
Thank you,
Yelena
From: TobeyQin<EMAIL_ADDRESS>Sent: Monday, April 2, 2018 2:00 AM
To: Microsoft/samples-for-ai<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [Microsoft/samples-for-ai] Add WGAN/InfoGAN/DiscoGAN Keras implementation (#22)
Thank you for your submission. There is some conflict with the master branch. Pls. resolve the conflicts and commit again. Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fsamples-for-ai%2Fpull%2F22%23issuecomment-377888993&data=02|01|yelenah%40microsoft.com|c10c5d2a9eb943486fa208d598781726|72f988bf86f141af91ab2d7cd011db47|1|0|636582563912112177&sdata=OPcMRHJk5bwZk1jeplYFJUlJFq810XiIp2oblf2bEkE%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAC4U6I5ybUq5BgKotZcHh4r90WSOvTO4ks5tkeiEgaJpZM4S6Jut&data=02|01|yelenah%40microsoft.com|c10c5d2a9eb943486fa208d598781726|72f988bf86f141af91ab2d7cd011db47|1|0|636582563912112177&sdata=PYPWDYe3qiaGr%2BNT8veNtUxtGsWh6uQUAV7EvPBAriE%3D&reserved=0.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Fix escaping the jail by using &:

I'd appreciate a release when this is merged

ack - thanks @ares


The Windows 10 Release Information page cannot be viewed clearly when dark theme is enabled

Link to article:
https://docs.microsoft.com/en-us/windows/windows-10/release-information
Problem:
When the dark theme is enabled, the bottom half of the page is difficult to read, especially when the brightness of the monitor is less than 50%.
I have created a companion ticket with the IT Pro Docs team here: https://github.com/MicrosoftDocs/windows-itpro-docs/issues/3142

@gregvanl do you know how to increase the priority of this? It's an accessibility issue and it's probably such an easy fix:

I think this needs to be addressed. The table text is also dim in High Contrast mode.


Init j and resid for GMRES

This PR sets j and resid for GMRES. They are not initialized if beta <= final_norm, while they are printed later.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#3571
@adam-sim-dev
@pazner
@pazner + @termi-official
4/5/23
4/5/23
⌛due 4/26/23

PR Checklist

[ ] Code builds.
[ ] Code passes make style.
[ ] Update CHANGELOG:

[ ] Is this a new feature users need to be aware of? New or updated example or miniapp?
[ ] Does it make sense to create a new section in the CHANGELOG to group with other related features?

[ ] Update INSTALL:

[ ] Had a new optional library been added? If so, what range of versions of this library are required? (Make sure the external library is compatible with our BSD license, e.g. it is not licensed under GPL!)
[ ] Have the version ranges for any required or optional libraries changed?
[ ] Does make or cmake have a new target?
[ ] Did the requirements or the installation process change? (rare)

[ ] Update continuous integration server configurations if necessary (e.g. with new version requirements for each of MFEM's dependencies)

[ ] .github
[ ] .appveyor.yml

[ ] Update .gitignore:

[ ] Check if make distclean; git status shows any files that were generated from the source by the project (not an IDE) but we don't want to track in the repository.
[ ] Add new patterns (just for the new files above) and re-run the above test.

[ ] New examples:

[ ] All sample runs at the top of the example source file work.
[ ] Update examples/makefile:

[ ] Add the example code to the appropriate SEQ_EXAMPLES and PAR_EXAMPLES variables.
[ ] Add any files generated by it to the clean target.
[ ] Add the example binary and any files generated by it to the top-level .gitignore file.

[ ] Update examples/CMakeLists.txt:

[ ] Add the example code to the ALL_EXE_SRCS variable.
[ ] Make sure THIS_TEST_OPTIONS is set correctly for the new example.

[ ] List the new example in doc/CodeDocumentation.dox.
[ ] If new examples directory (e.g.examples/pumi), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add example-specific documentation, see e.g. the src/examples.md.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] In examples.md, list the example under the appropriate categories, add new categories if necessary.
[ ] Add a short description of the example in the "Extensive Examples" section of features.md.

[ ] New miniapps:

[ ] All sample runs at the top of the miniapp source file work.
[ ] Update top-level makefile and makefile in corresponding miniapp directory.
[ ] Add the miniapp binary and any files generated by it to the top-level .gitignore file.
[ ] Update CMake build system:

[ ] Update the CMakeLists.txt file in the miniapps directory, if the new miniapp is in a new directory.
[ ] Add/update the CMakeLists.txt file in the new miniapp directory.
[ ] Consider adding a new test for the new miniapp.

[ ] List the new miniapp in doc/CodeDocumentation.dox
[ ] If new miniapps directory (e.g.miniapps/nurbs), add it to MINIAPP_SUBDIRS in the makefile.
[ ] If new miniapps directory (e.g.miniapps/nurbs), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add miniapp-specific documentation, see e.g. the src/meshing.md and src/electromagnetics.md files.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] The miniapps go at the end of the page, and are usually listed only under a specific "Application (PDE)" category.
[ ] Add a short description of the miniapp in the "Extensive Examples" section of features.md.

[ ] New capability:

[ ] All new public, protected, and private classes, methods, data members, and functions have full Doxygen-style documentation in source comments. Documentation should include descriptions of member data, function arguments and return values, template parameters, and prerequisites for calling new functions.
[ ] Pointer arguments and return values must specify whether ownership is being transferred or lent with the call.
[ ] Any new functions should include descriptions of their intended use e.g. for internal use only, user-facing, etc., along with references to example code whenever possible/appropriate.
[ ] Consider adding new sample runs in existing examples to highlight the new capability.
[ ] Consider saving cool simulation pictures with the new capability in the Confluence gallery (LLNL only) or submitting them, via pull request, to the gallery section of the mfem/web repo.
[ ] If this is a major new feature, consider mentioning it in the short summary inside README (rare).
[ ] List major new classes in doc/CodeDocumentation.dox (rare).

[ ] Update this checklist, if the new pull request affects it.
[ ] Run make unittest to make sure all unit tests pass.
[ ] Run the tests in tests/scripts.
[ ] (LLNL only) After merging:

[ ] Update internal tests to include the new features.

@adam-sim-dev, this is ready to be reviewed right?

@adam-sim-dev, this is ready to be reviewed right?

yes

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

Merged in next for testing...

Good catch.
Maybe we want to think about not using goto (and member initializers when applicable) to avoid such issues in the future.

Removing goto also helps understand the code better.


Supermium (64-Bit) | Creates automatically unwanted Folders with Subdirectories containing Files in the System-Program-Folder:

⠀%Program Files%

chrome_url_fetcher . . .
chrome_url_fetcher . . .
chrome_url_fetcher . . .

They will be created itself from Time to Time

Not to mention the chrome_BITS_xxxx_xxxxxxxxxx that chromium 109 loads up the program file folder with, which Supermium also seems to be doing -  SUPPOSEDLY they are safe to keep deleting...

They should be. Both are supposed to be temp directories, but it seems that they are not deleted. This could probably be done as part of the "cancel" method for each method that creates these directories, but I think there's already some mechanism to do it that I haven't found yet.

Добрый вечер Уважаемые!Что пока нет способа что их отключить чтоб они не создавались?

I committed a fix that should move the temporary folders to Temporary Internet Files as opposed to Program Files. It seems to be working based on my tests.

They are being put in C:\Windows\SystemTemp on my Windows 11 machine.


Testing on my own dataset

Hi
thanks for your interesting work.
I tested your code on one of the DTU dataset (Moda). as you can see from the following image, the results are quite well.

but I got a very bad result, when i tried to tested on one of my dataset  (see the following pic) using your pretrained model (model_dtu).
Now, my question is that do you thing that the object is too complicated and different compared to DTU dataset and it is all we can get from the pretrain model without retraining it?
is it possible to improve by changing the input parameters?
In general, would you please share your opinion about this result?

According to the case you provide, the plastic bottle is transparent and non-Lambertian, which is a typical hard case for MVS based on photometric similarity. I think reconstructing such object is a common challenge for most algorithms and probably not feasible by changing input parameters or supplementing more training samples.
My suggestion is that you follow a RGBD manner and leverage a depth sensor to conduct the reconstruction (if possible).


Add cspell

Adds support for cspell. Minimally configured, but supports cspell.json.

Do you want some help to finish this?

feel free to re-open if you want to work on this again


[Feature] Add "Choose File to Upload" button (like other image loaders)

Please add a "Choose file to upload" button like other loaders. The nice part about this loader is that it exports the path of the image loaded. Other loaders don't do that.

I am not adding any JavaScript to WAS-NS. I, as well as many services use it headless without a GUi for API.

Ah. I'll reach out to another author and see if they can export the checkpoint path. Thanks for the explanation.

Ah. I'll reach out to another author and see if they can export the checkpoint path. Thanks for the explanation.

If you can do it via extending nodes that already have file upload, like load image in base ComfyUI and do a PR, that's fine.


RoutedEvent handler.DynamicInvoke causing StackOverflow

Iv come across some strange issues when trying to investigate memory leaks in Avalon Studio.
So I went to simplify the tab control to eliminate carousel, and replaced with a single ContentControl capable of only displaying 1 document.
To repo you need the following commit:
https://github.com/VitalElement/AvalonStudio/commit/e46e578ab51405a9438630d04ffb865c6471378a
The problem Xaml:
<ContentControl Content="{Binding SelectedDocument}">
            <ContentControl.DataTemplates>
              <DataTemplate>

                <Controls:Editor>
                  <Controls:Editor.Content>
                    <Button Content="X" Command="{Binding CloseCommand}" Height="20" Width="50" />
                  </Controls:Editor.Content>
                </Controls:Editor>

              </DataTemplate>
            </ContentControl.DataTemplates>
        </ContentControl>

The exact part that causes it is the {Binding CloseCommand}
When you run the commit, open the sample project and click on a source file in the solution explorer.
You will get stack overflow after a few seconds.

This should be fixed by using ContentControl.ContentTemplate which has just been added.


Add support for config_settings in requirements.txt / requirements.in

In #1460, the CLI gained support for passing config_settings to the build backend. However, sometimes you want to pass these settings only for specific requirements (or simply you don't want to have to write it in the CLI each time).
If you use pip install -r requirements.txt, this is a valid line inside a requirements.txt:
--config-settings editable_mode=strict -e ../lib

However, uv will fail with:
error: Unexpected '-', expected '-c', '-e', '-r' or the start of a requirement at requirements.txt:3:1

Now, I can still get things to work if I pass the --config-settings editable_mode=strict to the CLI, but it's quite tedious to always have to do that. Furthermore, maybe I'd not want to pass it for a different requirement, but now it applies to all of them.
Note that the same also doesn't work with uv pip compile (when putting the --config-settings editable_mode=strict inside a requirements.in) and also not with uv pip sync.
It would be awesome if uv could parse the --config-settings inside a requirements.txt file.
Why is this useful?
If you use an editable install of a package built with setuptools, you need to pass either editable_mode=compat or editable_mode=strict in order for pyright/pylance typing to work for the package (see this StackOverflow question). Supporting this means that it becomes a lot simpler to depend on other local packages without requiring them to be fully factored out as PyPI or Git repository packages (all you need is a very basic pyproject.toml with setuptools as the build backend).
My example setup looks like this:
lib/
├─ lib.py
├─ pyproject.toml
app/
├─ requirements.in
├─ app.py

Also, thanks for this great project! Using it has been a blast so far!

Interesting, I've never seen this -- thanks for raising. Looks like it's https://github.com/pypa/pip/issues/11325 in pip.

Interesting. I wonder if there should be a way to express this in the CLI as well.

Small note: If anyone is running into my specific use case: if you use hatchling instead of setuptools as your build backend, pyright will work by default.

Also faced with this issue unfortunately; https://github.com/microsoft/LightGBM/pull/6493

Considering some options here...

--config-setting <package-name>__<key>=<val> e.g. --config-setting foo__editable_mode=strict
--config-setting <package>=<key=val> e.g. --config-setting foo=editable_mode=strict`
--config-setting-includes <package> only pass config settings to the given packages
--config-setting-excludes <package pass config settings to all packages but the given packages
--config-setting-includes <package>=<key> only pass the given config setting to the given packages
--config-setting-excludes <package>=<key> do not pass the given config setting to the given packages

Any chance this will get some attention soon? We have quite some editable installs which we now install one by one

We need to settle on a design — we're prioritizing some other things right now but if someone wants to push the design forward I can review.

I'm honestly +0 on this issue, but I thought it worth mentioning I hit this with using uv pip sync, at work we have some internal packages that are built with setuptools, and developed in a multi repo environment, to get IDEs to play nice I have to use --config-settings editable_mode=compat to install them.
Because I can't insert that straight into the requirements file I have to do this slightly awkard to of uv pip sync followed by uv pip install {my_editable_projects} --config-settings editable_mode=compat.
Maybe I'm missing something obvious though.


Bot doesn't find incubators?

Expected Behavior
That it does find incubators?
Actual Behavior
It doesn't find any incubators.
I notice that the bot doesn't find incubator. I saw somebody on level 20 with 5 incubator and i have only the stock one. It doesn't find incubator at pokestops.

Incubators do not come out from Pokestops. Only eggs do.
If you want an incubator, you have to acquire certain level on which one is provided to you.

Leveling up gives you incubators, or buying them.

I have 1 incubator and im level 18.

@Roydeking52  Go here.

aah oke i get it now thx for the link.

Close issues if solved...

how?

The button to the immediate left of the "Comment" button. It says "Close Issue"

How is this solved? I also dont get incubators... Level 16 should have 3

This is closed because Pokestops do not give Incubators. You get Incubators from leveling and/or buying from shop. Now, if you have leveled while suing the bot and you do not have items received from leveling, that is a different story. Personally I haven't had an issue, every time I have leveled I logged into the game after using the bot and I get the level up notification with my items.

Ok. I see. Thx.
So its a different Problem, that the bot doesnt collect the items from levelling


Simpler version of add512

The little-endian version of add512 is slightly over engineered. There is a simpler version.

Thanks!


Linking problem if there is a space in the path name of the source files.

Type: Bug
I am using VS to compile code for STM32 microcontrollers. My environment is VS, CMAKE, ninja and ARM tools. I noticed that in case the path to the source files directory contains a space in the name (Windows), CMake badly builds the task for the linker, does not put the path in quotation marks.
Eg. for CMake task description:
e:/SEGGER Embedded Studio for ARM Projects/AJM_test/firmware/src/CMakeLists.txt
The job description for the linker looks like this:
...-Xlinker --gc-sections -LE:/SEGGER Embedded Studio for ARM Projects/AJM_test/firmware/src/../ldscripts/ --specs=nano.specs ...
As a result, the linker does not find its parameters description and the job ends with an error. The workaround is to replace all spaces in the path name with, for example, "_" or map the path as a drive (in my case, Z: \ == E: \ SEGGER Embedded Studio for ARM Projects ).
Extension version: 1.12.27
VS Code version: Code 1.72.2 (d045a5eda657f4d7b676dedbfa7aab8207f8a075, 2022-10-12T22:15:18.074Z)
OS version: Windows_NT x64 10.0.19042
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-3230M CPU @ 2.60GHz (4 x 2594)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
11.88GB (5.30GB free)

Process Argv
Z:\AJM_test\firmware\src\CMakeLists.txt --crash-reporter-id 5d768ecb-b580-4fdc-b89c-9d400fca1231

Screen Reader
no

VM
0%

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vscaac:30438847
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
pyindex848cf:30577861
nodejswelcome1cf:30587006
fc301958:30595537
2e4cg342:30596373

Are you able to reproduce this issue on the command line as well? or do you reproduce this issue only when using VS Code and CMake Tools extension?

Hi,
I didn't use (even try) the command line. I noticed a problem trying to build the program from VS Code,
CMake was installed as a Tool extension.
Andrzej
From: Elaheh Rashedi @.***
Sent: Monday, November 7, 2022 5:46 PM
To: microsoft/vscode-cmake-tools @.>
Cc: Andrzej Majewski @.>; Author @.***>
Subject: Re: [microsoft/vscode-cmake-tools] Linking problem if there is a space in the path name of the source files. (Issue #2838)
Are you able to reproduce this issue on the command line as well? or do you reproduce this issue only when using VS Code and CMake Tools extension?
—
Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode-cmake-tools/issues/2838#issuecomment-1305888974 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AZM6KKPOOB7XTSSMY76ZRVTWHEW2XANCNFSM6AAAAAARVRHWNY .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/AZM6KKOJD7SF5UIZM3BECHTWHEW2XA5CNFSM6AAAAAARVRHWN2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSN2ZEM4.gif Message ID: @.*** @.***> >


Implement AssertNothrow

Closes #13

I close this PR now. It is very old and neither Joakim nor I see a good reason for the addition of AssertNoThrow.

Dang, 4 years! An end of an era, to be sure.


Recognize mime / filetype extensions in URL for supported formats

E.g return a JSON file when user visits https://atomicdata.dev/classes/Class.json. Split URL path by . when user sends HTML request.

Done!