Error: writeStatic has been removed. Please ensure you are using the latest version of svelte-adapter-github

This error appears when I try to build my project with most currently recent versions:

"@sveltejs/kit": "1.0.0-next.405",
"svelte-adapter-github": "0.0.1-next.0",

When I try to use older @sveltejs/kit, I bump into this another issue:

builder.prerender() has been removed

Therefore I need to downgrade my @sveltejs/kit so much, that everything else just breaks up: and consecutively I need to downgrade almost everything to who knows which version, in order to find this short period of time when all this stack worked, for building SveltKit project for Github.

More info about breaking changes:

What's new in Svelte: August 2022

It seems they removed writeStatic at Jul 19 in here: https://github.com/sveltejs/kit/pull/5618

Btw I just tried to use all the old versions, so svelte-adapter-github works again, but it seems it does not generate all the needed pages, like about.html, blog.html, etc. Only index.html...

Thank you.
With the upcoming changes on https://github.com/sveltejs/kit/pull/5845, I'm starting to think I need to deprecate this package. I originally just copied the code from sveltekit's static adapter, then modified it a bit for use with Github.
If I do continue it, I need to make some changes so I can merge updates from the official adapter-static and make some tweaks so this adapter will work with newer versions of sveltekit.

Actually, yes, adapter-static seems to be enough. I'm using it currently, it seems to work without an issue.

Ok, I finally found some time to get this straightened out. The latest version should be good, but since you're using the official adapter-static I'll close this issue.


non-"Proof of Concepts" Plugins?

Each of the linked plugins are prefaced with

Warning this is a Proof Of Concept plugin

Are these planned to become full-fledged packages or should we shy away from these and have the community build their own?

have the community build their own

Is the way to go, I don't have the time to maintain them. I will try to make the experience better by providing a built in solution to work with interpolations (since they are not valid css and can be troublesome when making a plugin).

@giuseppeg So should one wait for your work on

experience better by providing a built in solution to work with interpolations

Or is the API not likely to change too much?

I might change how placeholders for interpolations are represented eg.
/* existing */
@media (min-width: %%styled-jsx-placeholder-0%%) {  /* something ... */ }

/* better */
@media (min-width: %%styled-jsx-placeholder-value-0%%) {  /* something ... */ }

/* existing */
div {
   %%styled-jsx-placeholder-0%%;
   color: red;
}

/* better */
div {
   %%styled-jsx-placeholder-rulesblock-0%%;
   color: red;
}

basically define a set of standard tokens so it is easier to replace placeholders in plugins:
%%styled-jsx-placeholder-TOKEN_TYPE-0%%

for completeness (and to make the context clear) placeholders are inserted when you have interpolations in your css eg:
`@media (min-width: ${largeScreen}) {  /* something ... */ }`

Thanks for the explanation

@giuseppeg You said

I don't have the time to maintain them

Does this mean you won't have the time to manage any PRs, or just issues raised in each plugin?

@jthegedus I can do code review every now and then ofc :)

Cool, I wasn't sure if an entire fork was required.


Problem with bat file

The bat file gives error and closes itself could you help me? I would just like to use this program for an discord mass dm bot, if you have any information on that topic it would be really helpful for me. Thank you in advance.

Bat file is changed a bit it will only download the packages then would be closed u can run the tool manually


publish nupkg to azure devops feed

fixed in #4

:tada: This issue has been resolved in version 0.1.0 :tada:
The release is available on:

GitHub Release
NuGet Package
Your GitReleaseManager bot :package::rocket:


Fix backward compatibility for RN < 0.47

I'm not really interested in keeping this backward compatible unless there's a good argument for it. This isn't the first breaking change in React Native and probably won't be the last. It's best to just keep up to date with it.

@DylanVann Fair enough, but just to make it clear, there are bunch of react-native modules that haven't been updated yet to support an Android breaking change for RN 0.47, including react-native-maps, react-native-config etc.. all of them are kind often used and well known, and it takes time to update those.
While you can benefit and use new features from the updates you make to react-native-fast-image so that once you upgrade to the latest RN it happens in a smooth way 👍

Thank @Amurmurmur I needed that! 🎉

i'm all about encouraging using the latest release, but the fact of the matter is not all packages/modules are as quick as each other to update/upgrade. So if some where to upgrade to 0.47 they could have 10 other packages lagging behind and have to fork PR's just for their dependencies. IMO this PR is a good idea, especially due to the simplicity of it.

dew to this issue i upgraded RN to from 0.45 to 0.47.
but still cannot build Android

It's best to just keep up to date with it
@DylanVann

I feel like this is really flawed logic, especially for an app developer.
You wouldn't make an Android app and say "We only support Android 7+ because we want to encourage people upgrade their devices."  You're leaving out like 85% of the market
I would be willing to bet that if you did a survey of all of the RN apps out there, most of them would not be RN 0.47+.  It is silly to leave out a single method in a single java class because you want to force people who use your library to upgrade, when they may have valid reasons for not doing so.

I agree that this should be merged in as it's only a single method difference. The main reason we have for staying on 0.46 is that in 0.47 and above systrace is broken, which makes debugging performance issues almost impossible.

i agree that this should be merged too, as it has no detrimental impact afaik.

I also agree, this is poor practice and it should be backwards compatible
I'll give an good real life example for all those web devs.
"Unfortunately we still gotta support IE sometimes.."

@Amurmurmur Thank you for the contribution, sorry I'm not merging it. I have added a note that react-native-fast-image will only aim to support the latest release of react-native
You're not required to update react-native-fast-image, just as you are not required to update react-native.
Only supporting the latest version of react-native makes this project easier to maintain and test.
@matt-oakes It does suck the systrace is broken on recent versions of RN, it seems like the core team is taking a look at it, hopefully it will be fixed soon.
Sorry everyone, not merging. Less code, less problems.

Thanks for taking the time to lay out the reason for the decision! 👍


IP Issue on cloud deployment

I just tried to set up the demo on Google Compute Engine. But I ran into an issue related to the internal and external IP of an cloud VM.
Observations
I started my Funix server using
python3 -m funix examples_better -H <IP_ADDRESS>

where <IP_ADDRESS> is the internal IP of the instance.
However, the Funix frontend in my browser (on my local computer) cannot access this IP.
I managed to get it to work by changing the backend IP in the settings in the Funix app in the browser to the external IP of the server. But this is very not out-of-the-box. We can expect common Joes to change this setting.
Proposed change
Add another option to Funix to configure the external IP and pass this to the browser.

Fixed in 0.3.7


Adding EIP1559 based gas estimation

Proposed changes
Adding EIP1559 based gas estimation.
Fixes
#9
Types of changes
What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING doc
[ ] I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[x] Lint and unit tests pass locally with my changes and CI passes too
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that code coverage does not decrease.
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Should I remove these blocks from get_*_transaction methods since we have configurable strategies now
        if max_fee_per_gas is not None:
            max_priority_fee_per_gas = (
                self._try_get_max_priority_fee()
                if max_priority_fee_per_gas is None
                else max_priority_fee_per_gas
            )
            transaction.update(
                {
                    "maxFeePerGas": max_fee_per_gas,
                    "maxPriorityFeePerGas": max_priority_fee_per_gas,
                }
            )

Yes we need to discuss this

@DavidMinarsch I fixed tests for ledger api but there's an issue with contract tests that I'm stuck for while here's the error log
ledger_api = <aea_ledger_ethereum.ethereum.EthereumApi object at 0x7f90f42b34c0>, ganache = None, ganache_addr = 'http://<IP_ADDRESS>', ganache_port = 8545

    @pytest.fixture()
    def erc1155_contract(ledger_api, ganache, ganache_addr, ganache_port):
        """
        Instantiate an ERC1155 contract instance.

I thought of reverting back to a single value and creating two separate methods two calculate maxFeePerGas and maxPriorityFeePerGas I think I'll give this a try and figure out if it works

It was simply missing the right configuration.


Refactor Wasmtime CLI to support components

This commit refactors the wasmtime CLI executable to be able to
support not only compiling components but additionally executing
components. While I was doing this I've additionally added a new
--preview2 argument to enable using the new experimental
implementation of preview1 based on preview2 type/structs. This is
off-by-default but is expected to become the default in the future.
Some notable features of this change are:

The preview1-implemented-with-preview2 module now sports
add_to_linker_{async,sync} to replace the previous add_to_linker
which always did async.

Some trait bounds in the preview1-implemented-with-preview2 module are
simplified.

Some minor changes were made to wiggle's macros to support a "block
on" that isn't the default wiggle dummy executor (as now we actually
do need Tokio)

Many options related to core wasm Linker configuration, such as
--default-values-unknown-imports, are not implemented for components
at this time. When used with components these options return an error.

Construction of WASI contexts has been refactored to pass around fewer
arguments to avoid threading through lots of values for both preview1
and preview2.

Reading the input to the Wasmtime CLI has been updated to read the
input in the run subcommand before handing it off to the wasmtime
crate's API to enable the CLI to use the contents of what's loaded to
determine what to do next.

Our generic ./ci/run-tests.sh script has been updated to pass the
--features component-model flag to ensure that this CLI support is
tested during the normal test suite.

Procedural Note: this PR is based on https://github.com/bytecodealliance/wasmtime/pull/6833 and https://github.com/bytecodealliance/wasmtime/pull/6823 so the first few commits can be ignored.

Ok I've ignored the one test that relies on output flushing and otherwise rebased this on main. I've additionally added component support for the wasi-nn feature by adding it to the component linker when a component is loaded on the CLI. I've left wasi-http as not-enabled, however, since I'm not familiar enough with what its current status is.
I think this should be ready to go though if you can give it another review @pchickey

wasi-http is hosed at the moment and should not be enabled.


Turning imtvault into a cldfbench-curated CLDF dataset

Here's the auto-generated description of the CLDF data:
https://github.com/xrotwang/imtvault/tree/main/cldf

@Glottotopia just a draft PR to get an overview of how the repos would look like as CLDF dataset.


[DemoType] Characters are not correctly transmitted when using non QWERTY keyboard

I do work with a de-CH keyboard

When using the following snippet in a file:
#This is an example
$ser = get-Service -Name AudioSrv
$ser | get-member

and trigger the shortcut to demotype the text (while using the de-CH keyboard layout).
I did get the following output (Notice the numbers 3 and 7)

3This is an example
$ser = get-Service -Name AudioSrv
$ser 7 get-member

I had to install an english QWERTY keyboard layout, and switch to that one for it to work properly (Thus having # instead of 3 and | instead of 7)

note: the # character is actually located on the number '3' and the | on the 7  on the Swiss German (de-CH) keyboard

note2: I tried with a French keyboard layout (fr-FR) I got the following  output
"This is an example
$ser = get-Service

So clearly it looks like the these characters are hardcoded in the tool

Hi @foxmsft is there an update on this one ?
Did you guys managed to reproduce it on your end, and are you working on a fix ?
That would be really great!

Hey @Stephanevg - yes, I can see this behavior. Will prepare a fix, thanks for the report!


adds basic versions of pivot_longer and pivot_wider

adds pivot_longer with support for one argument (cols) and pivot_wider with support for (names_from, values_from). Also cleans up runtests.jl to allow doctests to easily be run locally using ] test

Not sure how much of the functionality of pivot_longer and pivot_wider is needed before they're useful - wanted to check in on the general approach before implementing too many options. In particular, is this how you want to handle processing arguments? Or was there another way already implemented that I didn't catch

The only other addition will be to add a page to the documentation page dedicated to pivoting. You're welcome to do it, but others can also help if you'd like.

Renaming done - I might wait on a full documentation page just because a lot of the more practical examples (e.g. something resembling https://tidyr.tidyverse.org/articles/pivot.html) will require additional options to be implemented first

Perfect. I'll put together a basic docs page and then plan to get this merged tonight.

Yeah, as a next step we can implement names_to and values_to. I don't think we necessarily need to implement all the bells and whistles, and certainly not yet.


.?shop sell all doesn't work

Bugreport:
Bug reported by Dadi
Is it a bugreport for the website or for the bot?: bot
What is the title of your bugreport?: .?shop sell all doesn't work
How can you reproduce the bug? (Explain in steps): Type in ?l
And then ?shop sell all
Which result would normally have to be?: Every thing in your inv will be sold
What happens if you do the action now?: After a bugfix from yesterday:
You used the command incorrectly. Please check with ?help shop how to use the command correctly!
ReportID: 69

➤ LenoxBot commented:
Approve:
reproducible
Fabiooo

➤ LenoxBot commented:
Approve:
reproducible
Nickkel

➤ LenoxBot commented:
Approve:
reproducible
Denarioyt


Hoist Python-to-Rust casts into bridge modules

Enables greater versatility for upcoming pre and post-validation actions, orchestrated by PyValidator.
As a nice, unrelated side effect, this purifies TransactionExecutor from direct PyO3 dependencies, making it a pure Rust module.

This change is

Codecov Report

Merging #1095 (d6522e4) into main (6cb081f) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1095   +/-   ##
=======================================
  Coverage   67.35%   67.35%
=======================================
  Files          51       51
  Lines        6494     6494
  Branches     6494     6494
=======================================
  Hits         4374     4374
  Misses       1737     1737
  Partials      383      383

Files
Coverage Δ

...ates/native_blockifier/src/transaction_executor.rs
16.66% <0.00%> (+0.91%)
:arrow_up:

crates/native_blockifier/src/py_block_executor.rs
38.94% <0.00%> (-0.42%)
:arrow_down:

crates/native_blockifier/src/py_validator.rs
0.00% <0.00%> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!


Uncaught TypeError: projectRepo.repo.getHeadBlob is not a function

[Enter steps to reproduce below:]

Enable diff

Atom Version: 1.7.3
System: Mac OS X 10.11.4
Thrown From: split-diff package, v0.7.5
Stack Trace
Uncaught TypeError: projectRepo.repo.getHeadBlob is not a function
At /Users/markus/.atom/packages/split-diff/lib/split-diff.coffee:292

TypeError: projectRepo.repo.getHeadBlob is not a function
    at Object.module.exports.SplitDiff._setupGitRepo (/Users/markus/.atom/packages/split-diff/lib/split-diff.coffee:292:44)
    at Object.module.exports.SplitDiff._getVisibleEditors (/Users/markus/.atom/packages/split-diff/lib/split-diff.coffee:259:6)
    at Object.module.exports.SplitDiff.diffPanes (/Users/markus/.atom/packages/split-diff/lib/split-diff.coffee:119:16)
    at atom-workspace.subscriptions.add.atom.commands.add.split-diff:enable (/Users/markus/.atom/packages/split-diff/lib/split-diff.coffee:32:32)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:260:29)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
    at CommandPaletteView.module.exports.CommandPaletteView.confirmed (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/command-palette/lib/command-palette-view.js:183:32)
    at CommandPaletteView.module.exports.SelectListView.confirmSelection (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-space-pen-views/lib/select-list-view.js:338:21)
    at space-pen-div.atom.commands.add.core:confirm (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-space-pen-views/lib/select-list-view.js:109:19)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:260:29)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:580:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:388:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:98:36)
    at HTMLDocument.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:3:61)

Commands
     -0:51.2.0 tree-view:reveal-active-file (atom-workspace.workspace.scrollbars-visible-when-scrolling.seti-ui-no-icons.theme-an-old-hope-syntax.theme-one-dark-ui)
     -0:48.2.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -0:48.2.0 core:cancel (atom-text-editor.editor.is-focused)
     -0:43.1.0 pane:show-next-recently-used-item (atom-text-editor.editor.is-focused)
     -0:43 pane:move-active-item-to-top-of-stack (atom-text-editor.editor.is-focused)
     -0:32.5.0 core:paste (atom-text-editor.editor.is-focused)
  5x -0:30.2.0 tree-view:reveal-active-file (atom-workspace.workspace.scrollbars-visible-when-scrolling.seti-ui-no-icons.theme-an-old-hope-syntax.theme-one-dark-ui)
     -0:09.8.0 command-palette:toggle (atom-text-editor.editor.is-focused)
     -0:07.2.0 split-diff:prev-diff (atom-text-editor.editor)
     -0:06.1.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -0:06.1.0 core:cancel (atom-text-editor.editor.is-focused)
     -0:04.4.0 command-palette:toggle (atom-text-editor.editor.is-focused)
     -0:01.7.0 core:move-down (atom-text-editor.editor.mini.is-focused)
     -0:01.4.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:01.4.0 split-diff:enable (atom-text-editor.editor)
     -0:01.1.0 tree-view:reveal-active-file (atom-workspace.workspace.scrollbars-visible-when-scrolling.seti-ui-no-icons.theme-an-old-hope-syntax.theme-one-dark-ui)

Config
{
  "core": {
    "disabledPackages": [
      "php-debug",
      "terminal-plus",
      "atom-typescript",
      "atom-ternjs",
      "atom-css-comb"
    ],
    "ignoredNames": [
      "htdocs/media/js",
      "htdocs/media/css",
      "htdocs/var/cache"
    ],
    "themes": [
      "one-dark-ui",
      "an-old-hope-syntax"
    ]
  }
}

Installed Packages
# User
an-old-hope-syntax, v0.5.0
angularjs-styleguide-snippets, v0.7.3
atom-alignment, v0.12.1
atom-hg, v2.0.4
auto-reveal-in-sidebar, v0.8.0
autoclose-html, v0.23.0
autocomplete-angular-material, v0.4.0
bottom-dock, v0.4.4
css-comb, v2.4.3
editorconfig, v1.4.1
file-icons, v1.7.11
file-types, v0.5.1
linter, v1.11.4
linter-csslint, v1.3.2
linter-htmlhint, v1.1.4
linter-jshint, v2.1.0
linter-manager, v0.2.12
linter-scss-lint, v3.0.3
merge-conflicts, v1.4.2
minimap, v4.23.5
pigments, v0.26.2
project-manager, v2.9.7
split-diff, v0.7.5
sync-settings, v0.7.2
todo-manager, v0.2.8

# Dev
No dev packages

Hi, were you diffing a file that is part of a git repo? I think I have a fix for this anyway, but I am just curious. Thanks.

Nope.. A mercurial repo 😜

On 11 maj 2016, at 16:29, Mike Upchurch<EMAIL_ADDRESS>wrote:
Hi, were you diffing a file that is part of a git repo? I think I have a fix for this anyway, but I am just curious. Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub


Unable to compile TypeScript

Hi all,
I am new to AngularJS.
During theme setup an error: occured while running npm start command. i had also attached the screenshoot  of this error.
Please see and send me the feedback.

I have the exact same issue

make sure you have

node, npm https://nodejs.org/en/download/
gulp npm install -g gulp
ts-node npm install -g ts-node
I tested it on ubuntu 14.04 with node 4.* and npm 2.*. it worked fine. if it doesn't work just send npm-debug.log


Add Amaka Mbah to Contributors list

Hi  @devsisi, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

Thank you for the opportunity Mr Roshan. It felt great actually, can't wait to begin on projects...

I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh


Don't mark machine ready=false when internalIP is known

We've seen instances where the vmi.Status.Interfaces list temporarily clears and stops reporting the default instance IP. This occurs when the qemu guest agent can not be contacted, such as during an internal soft reboot. It also occurs for reasons we do not 100% understand yet.
Since we know this vmi.Status.Interfaces field is dependent on the qemu guest agent, there will be times where the agent is unavailable. To smooth over those time periods, capk now only reports IP changes on the node when we're certain the IP has actually changed, and does not clear out the internal IP when no default ip is reported on the vmi status.
NONE

/ok-to-test

/lgtm


feat: add --compressed to forest-cli snapshot export

Summary of changes

As part of https://github.com/ChainSafe/forest/issues/2741
Changes introduced in this pull request:

Support exporting zstd compressed snapshots
Remove tokio::io::AsyncWrite compat layer from the entire snapshot export flow
Do not calculate checksum when either --compressed or --skip-checksum is supplied
Update CI scripts

Reference issue to close (if applicable)

Closes
Other information and links

Change checklist

[x] I have performed a self-review of my own code,
[x] I have made corresponding changes to the documentation,
[x] I have added tests that prove my fix is effective or that my feature works (if possible),
[x] I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 mergio?

@hanabi1224 mergio?

Not yet, let me add more tests with real files to make sure we don't have checksum missmatch


Global phase uc

Summary
QuantumCircuit.uc does not preserve global phase. This PR adds the gate $P = e^{-i\pi/4}$ (see fig. 3 of arXiv:quant-ph/0410066).
Details and comments

If it doesn't break anything I think we should just always add the correct global phase. It looks more like a bug to me and not a feature we want to preserve 🙂

Hi @Cryoris , it breaks test_isometry_inverse in test/python/circuit/test_isometry.py
I didn't check the reason.

That's odd, nothing should work based off the global phase not being conserved. I think we should try get to the bottom of this and then hopefully remove the argument.

I converted the isometry into a gate (instead of Instruction). With this modification the isometry.inverse works as expected.
The change from instruction to gate will not break anyone code because a gate is also an instruction and isometry is a unitary operation.

Travis CI bill failed with the message
The command "pip install "qiskit-aer"" failed and exited with 1 during ...

I converted the isometry into a gate (instead of Instruction). With this modification the isometry.inverse works as expected.
The change from instruction to gate will not break anyone's code because a gate is also an instruction and isometry is a unitary operation. Let me know if this is the best strategy.

Since generally speaking an isometry is not always unitary could you keep this as an instruction?

Thanks for the update @adjs.

Hi @ewinston, thanks for approving the changes. Should I resolve the new conflicts? I think this PR should be labeled as a bugfix.

I'm closing this PR in favour of PR #8231


Add docs workflow

Adding the documentation.yml to the workflows, but removed some unnecessary jobs (Remove existing composer file, Require phpdocumentor/guides-cli, Configure minimum stability)

@linawolf @jaapio can you please approve the workflow run?

Looks like everything is green now. Thanks for your contribution!


Failed download from history.com

python3 youtube-dl --verbose "http://www.history.com/shows/mountain-men/season-1/episode-1"
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', 'http://www.history.com/shows/mountain-men/season-1/episode-1']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.01.14
[debug] Python version 3.5.1 - Linux-4.3.3-2-ARCH-x86_64-with-arch
[debug] exe versions: ffmpeg 2.8.4, ffprobe 2.8.4, rtmpdump 2.4
[debug] Proxy map: {}
[History] episode-1: Downloading webpage
ERROR: Unable to extract video url; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "youtube-dl/youtube_dl/YoutubeDL.py", line 665, in extract_info
ie_result = ie.extract(url)
File "youtube-dl/youtube_dl/extractor/common.py", line 312, in extract
return self._real_extract(url)
File "youtube-dl/youtube_dl/extractor/history.py", line 29, in _real_extract
webpage, 'video url')
File "youtube-dl/youtube_dl/extractor/common.py", line 607, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract video url; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

it's a change in history.com website.
will be fixed in the next version.

:/
python3 youtube-dl --verbose "http://www.history.com/shows/mountain-men/season-1/episode-1"
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', 'http://www.history.com/shows/mountain-men/season-1/episode-1']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.01.15
[debug] Python version 3.5.1 - Linux-4.3.3-2-ARCH-x86_64-with-arch
[debug] exe versions: ffmpeg 2.8.5, ffprobe 2.8.5, rtmpdump 2.4
[debug] Proxy map: {}
[AE] episode-1: Downloading webpage
[ThePlatform] eg47EERs_JsZ: Downloading SMIL data
ERROR: This content is not available in your location.
Traceback (most recent call last):
File "youtube-dl/youtube_dl/YoutubeDL.py", line 665, in extract_info
ie_result = ie.extract(url)
File "youtube-dl/youtube_dl/extractor/common.py", line 312, in extract
return self._real_extract(url)
File "youtube-dl/youtube_dl/extractor/theplatform.py", line 237, in _real_extract
formats, subtitles = self._extract_theplatform_smil(smil_url, video_id)
File "youtube-dl/youtube_dl/extractor/theplatform.py", line 42, in _extract_theplatform_smil
raise ExtractorError(error_msg, expected=True)
youtube_dl.utils.ExtractorError: This content is not available in your location.

the video is georestricted.
it can be played from USA.


Allow "Red" environments to replace other "Red" environments

Intended to allow updating environments with broken dependent services, or to support updating an environment with circular dependencies (all become green at once), etc.
Careful review would be appreciated, the changes are "straight forward", but untested.

Ok, I merged your chances, but I'd like your assistance in order to properly understand it, as well as simulating a sample scanario. Can you guys help me on it?


Incorrectly passing C-struct by reference in [def DevControlEx(self, controlType, userStruct):]

Hello,
Your wrapper code has been very helpful and I want to thank you for creating it!
However, I did notice one error in how you passed the tAlpDynSynchOutGate structure to the C ALP
it should be changed from:
self._checkError(self._ALPLib.AlpDevControlEx(self.ALP_ID, controlType, userStruct.byref),  'Error sending request.')
to
self._checkError(self._ALPLib.AlpDevControlEx(self.ALP_ID, controlType, ct.byref(userStruct)), 'Error sending request.')
this will correctly pass by reference the userStruct to the C ALP

Thanks for your advice! I solved this problem. But when I use the tAlpDynSynchOutGate structure to define the Gate, the ct.c_ubytes only accepted an int input, such as 0 or 1. How to input a Gate (for example 10, 010, 001) when Period is 2 or 3? Moreover, how to control the PIN 8 to output a frame synch pulse voltage? I did't see any description in ALP-4.3 API description. PDF.
I would appreciate it if you could reply!


Switch off the default require.js timeout

Description

This change is switching off the default require.js timeout, to prevent report app from not loading while on slow network.
Motivation and Context

Currently, in most cases, the report app is not loading on slow networks due to timeout caused by require.js (Uncaught Error: Load timeout for modules: angularAMD,lodash,angular-bootstrap,angular-ui-router,jquery,bootstrap,scroller,angular). This change is switching off the default timeout, to prevent it from happening.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

See also https://github.com/Cognifide/aet-cookbook/pull/17


Add JWS header attribute "kid" when exists in jwks file

If we provide a jwks file with a "kid" attribute (not the one auto generated by CAS), we should add this value in the produced JWS header.
Some libraries or applications fail to validate JWS token if this header is not present.
https://tools.ietf.org/html/rfc7515#page-11.

Closing patch due to inactivity. Please re-open the pull request and continue as usual, whenever you are ready to resume. Thank you!

Closing patch due to inactivity. Please re-open the pull request and continue as usual, whenever you are ready to resume. Thank you!

Do i have to provide a unit test for the PR to be merged ?
Or the proposal is declined ?


With Date Range,  lighter color not applied on days between the range

We're using react-native-paper in our project and have a custom theme.
We're finding that:

When we use our custom primary color in the theme, when selecting date ranges the lighter color does not show up between the date range - only the start/end date have a circle with the primary color selected, and everything in between is the same color as the rest of the calendar.
When we comment out our primary color in the theme, the date picker works exactly as it should, using the default purple primary color for the dates selected, and having the lighter purple for the dates in between start/end dates selected.

Is there another color we have to specify in the react-native-paper theme to get this working right?

I've been experiencing this issue too, specifically when I set the primary color in theme to "#5F53FC", a lighter color connecting the two dates does not show up for me.

@chakrihacker @RichardLindhout @nandorojo Any guidance you can give us on this would be fantastic.

Can you share a code snippet that I can try locally

I only tested this on the iPhone simulator, it should at least demonstrate the issue at hand. (https://snack.expo.dev/2IrVHMYvU)

@iM-GeeKy thanks for taking the time to setup the snack example and demonstrate the issue we're facing here. Much appreciated.
@chakrihacker, if you look at @iM-GeeKy 's example project, when selecting a range there is no light-blue highlight between the date ranges; you'll notice he specified a primary color in the react-native-paper theme. But as soon as you delete that custom primary color, the light purple highlight works!

@mashaalmemon and @iM-GeeKy test my branch and verify if it's working or not?

@chakrihacker I tried your branch and it didn't seem to resolve the issue. As a sanity check, are you (@mashaalmemon) seeing the same behavior?

I already merged it but haven't tested it yet, if somebody has a fix I'll merge it into main

@iM-GeeKy thanks for taking the time to setup the snack example and demonstrate the issue we're facing here. Much appreciated.
@chakrihacker, if you look at @iM-GeeKy 's example project, when selecting a range there is no light-blue highlight between the date ranges; you'll notice he specified a primary color in the react-native-paper theme. But as soon as you delete that custom primary color, the light purple highlight works!

How did you test my branch?

In one of my private repositories I pointed to your branch in my package.json, deleted my node_modules, and did a fresh install. I will add that I think the fix did help to a degree, but for lighter colors (ie. #2979FF, #5F53FC) the highlight is so faint it appears almost white. Thanks for the quick response times! Perhaps the ratio in your changes needs to be tweaked to accommodate for lighter hues.

I think we can introduce a prop for the user to set the ratio of color lightness, right now it's 90% lightness of the primary color, so It depends on the primary color. Having hardcoded values might not be the best way. What are your thoughts @RichardLindhout ?

checking if it's light or dark I think there is something in the color for that or in the react-native-paper codebase already

I don't know if anything is written on it in the spec

I just submitted a pr for the new rangeOpacity prop that I added in my branch. Please let me know if it works for you all.

What do you think of this approach of tint color @RichardLindhout ?
https://codesandbox.io/s/friendly-brattain-s1n7z?file=/src/App.js

I think it's good but it has to take in account the following things
Dark theme RNN
Primary color
etc

I think it's good but it has to take in account the following things Dark theme RNN Primary color etc

Is that not what @chakrihacker is mocking with his demo above? Where "Tinted Color" would correspond to dark theme color and so on...

Any solution? I'm facing the same issue. Selected range color is dark as it should be light and selected dates behind the selected range is hiding.
 const customDarkTheme = {
    ...DarkTheme,
    roundness: 2,
    colors: {
      ...DarkTheme.colors,
      primary: Colors.PRIMARY_GREEN,
      background: Colors.background,
      accent: "#ff1744",
      text: Colors.WHITE,
      surface: Colors.card_bg,
    },
    fonts: {
      regular: {
        fontFamily: typography.font_monsterrat_regular,
      },
    },
  };

  <PaperProvider theme={customDarkTheme}>
        <>
          <DatePickerModal
            saveLabel={
              <Text style={{ color: Colors.PRIMARY_GREEN, fontWeight: "bold" }}>
                Done
              </Text>
            }
            locale="en"
            mode="range"
            visible={open}
            onDismiss={onDismiss}
            startDate={range.startDate}
            endDate={range.endDate ? range.endDate : range.startDate} // Set the end date to the start date by default
            onConfirm={handleDateRangeSelect}
            validRange={{
              startDate: new Date(2021, 1, 2), // optional
              endDate: new Date(), // optional
            }}
            editIcon={false}
            label="Select Date"
            animationType="fade"
            startLabel=""
            endLabel=""
          />
        </>
      </PaperProvider>

@SharfMohiuddin PR's are welcome! As a temporary fix you can always create a patch using patch-package.

I'm running into this same issue. When I override the theme.colors.primary default value I'm missing the tinted background for the dates between start and end. Has anybody found a reliable solution?


Allow propagation to ancestor actions if actions lower down are disabled

Description
Change the semantics of Actions.invoke so that if the action it finds is disabled, then it keeps looking for an ancestor Actions widgets that has a matching intent where the action is not disabled.
Tests

Added a test to make sure that ancestor actions are invoked if the initial one is disabled.

Breaking Change

[X] No, no existing tests failed, so this is not a breaking change.

The Google testing failure seems unrelated. Checking.


[C++] Add noexcept specifiers where it's apropriate

Setters and getters without bounds checking should be marked noexcept.

Agreed.


RePlAce divergence detected. Re-run with a smaller max_phi_cof value on small design

Describe the bug
We are getting a "RePlAce divergence detected. Re-run with a smaller max_phi_cof value" error when running on a small design.
It appears all the flipflops are on top of eachother, which may be the issue.
Expected Behavior
Completes trivial placement
Environment
[WARNING] Your current OpenROAD version is outdated.
It is recommened to pull the latest changes.
If problem persists, file a github issue with the re-producible test case.
kernel: Linux <IP_ADDRESS>-microsoft-standard-WSL2
os: Ubuntu 22.04.2 LTS (Jammy Jellyfish)
cmake version 3.25.0
-- The CXX compiler identification is GNU 11.3.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- OpenROAD version: v2.0-8554-g2ccc898ac
-- System name: Linux
-- Compiler: GNU 11.3.0
-- Build type: RELEASE
-- Install prefix: /usr/local
-- C++ Standard: 17
-- C++ Standard Required: ON
-- C++ Extensions: OFF
-- Found GTest: /home/pgadfort/.local/lib/cmake/GTest/GTestConfig.cmake (found version "1.13.0")
-- The C compiler identification is GNU 11.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Performing Test C_COMPILER_SUPPORTS__-Wall
-- Performing Test C_COMPILER_SUPPORTS__-Wall - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wall
-- Performing Test CXX_COMPILER_SUPPORTS__-Wall - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-array-bounds
-- Performing Test C_COMPILER_SUPPORTS__-Wno-array-bounds - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-array-bounds
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-array-bounds - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-nonnull
-- Performing Test C_COMPILER_SUPPORTS__-Wno-nonnull - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-nonnull
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-nonnull - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-maybe-uninitialized
-- Performing Test C_COMPILER_SUPPORTS__-Wno-maybe-uninitialized - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-maybe-uninitialized
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-maybe-uninitialized - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format-overflow
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format-overflow - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format-overflow
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format-overflow - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-variable
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-variable - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-variable
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-variable - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-function
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-function - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-function
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-function - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-write-strings
-- Performing Test C_COMPILER_SUPPORTS__-Wno-write-strings - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-write-strings
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-write-strings - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-sign-compare
-- Performing Test C_COMPILER_SUPPORTS__-Wno-sign-compare - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-sign-compare
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-sign-compare - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-deprecated
-- Performing Test C_COMPILER_SUPPORTS__-Wno-deprecated - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-deprecated
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-deprecated - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-c++11-narrowing
-- Performing Test C_COMPILER_SUPPORTS__-Wno-c++11-narrowing - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-c++11-narrowing
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-c++11-narrowing - Failed
-- Performing Test C_COMPILER_SUPPORTS__-Wno-register
-- Performing Test C_COMPILER_SUPPORTS__-Wno-register - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-register
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-register - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal
-- Performing Test C_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal - Failed
-- Performing Test C_COMPILER_SUPPORTS__-fpermissive
-- Performing Test C_COMPILER_SUPPORTS__-fpermissive - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-fpermissive
-- Performing Test CXX_COMPILER_SUPPORTS__-fpermissive - Success
-- Performing Test C_COMPILER_SUPPORTS__-x
-- Performing Test C_COMPILER_SUPPORTS__-x - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-x
-- Performing Test CXX_COMPILER_SUPPORTS__-x - Failed
-- Performing Test C_COMPILER_SUPPORTS__c++
-- Performing Test C_COMPILER_SUPPORTS__c++ - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__c++
-- Performing Test CXX_COMPILER_SUPPORTS__c++ - Failed
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-but-set-variable
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-but-set-variable - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-but-set-variable
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-but-set-variable - Success
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- TCL readline library: /usr/lib/x86_64-linux-gnu/libtclreadline.so
-- TCL readline header: /usr/include/x86_64-linux-gnu
-- Found SWIG: /usr/bin/swig4.0 (found suitable version "4.0.2", minimum required is "3.0")
-- Found Boost: /usr/local/lib/cmake/Boost-1.80.0/BoostConfig.cmake (found version "1.80.0")
-- boost: 1.80.0
-- Found Python3: /usr/include/python3.10 (found version "3.10.6") found components: Development Development.Module Development.Embed
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.11")
-- Found Threads: TRUE
-- spdlog: 1.8.1
-- Found BISON: /usr/bin/bison (found version "3.8.2")
-- Found Doxygen: /usr/bin/doxygen (found version "1.9.1") found components: doxygen dot
-- STA version: 2.4.0
-- STA git sha: 555493cba6e476bd2ff0b9a543de7a781276c2b3
-- System name: Linux
-- Compiler: GNU 11.3.0
-- Build type: RELEASE
-- Build CXX_FLAGS: -O3 -DNDEBUG
-- Install prefix: /usr/local
-- Found FLEX: /usr/bin/flex (found version "2.6.4")
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- SSTA: 0
-- STA executable: /home/pgadfort/OpenROAD-build/src/sta/app/sta
-- GPU is not enabled
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- Found re2: /opt/or-tools/lib/cmake/re2/re2Config.cmake (found version "9.0.0")
-- Found Clp: /opt/or-tools/lib/cmake/Clp/ClpConfig.cmake (found version "1.17.7")
-- Found Cbc: /opt/or-tools/lib/cmake/Cbc/CbcConfig.cmake (found version "2.10.7")
-- Found Eigen3: /usr/local/share/eigen3/cmake/Eigen3Config.cmake (found version "3.4.0")
-- Found SCIP: /opt/or-tools/lib/cmake/scip/scip-config.cmake (found version "8.0.0")
-- GUI is enabled
-- Charts widget is not enabled
-- Found Boost: /usr/local/lib/cmake/Boost-1.80.0/BoostConfig.cmake (found version "1.80.0") found components: serialization
-- Found OpenMP_CXX: -fopenmp (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5")
-- Could NOT find VTune (missing: VTune_LIBRARIES VTune_INCLUDE_DIRS)
-- Found Boost: /usr/local/lib/cmake/Boost-1.80.0/BoostConfig.cmake (found suitable version "1.80.0", minimum required is "1.78")
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- Found Boost: /usr/local/lib/cmake/Boost-1.80.0/BoostConfig.cmake (found version "1.80.0") found components: serialization system thread
-- Found Boost: /usr/local/lib/cmake/Boost-1.80.0/BoostConfig.cmake (found version "1.80.0")
-- TCL readline enabled
-- Tcl Extended disabled
-- Python3 enabled
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/tmp.VM563nrShB

To Reproduce
sc_issue_heartbeat_job0_place0_20230614-172440.tar.gz
tar xvf sc_issue_heartbeat_job0_place0_20230614-172440
cd sc_issue_heartbeat_job0_place0_20230614-172440
./run.sh

Relevant log output
OpenROAD v2.0-8518-g8901000e3
This program is licensed under the BSD-3 license. See the LICENSE file for details.
Components of this program may be licensed under more restrictive licenses which must be honored.
Reading liberty file for fast: /usr/local/lib/python3.10/dist-packages/siliconcompiler-0.12.1-py3.10-linux-x86_64.egg/third_party/pdks/skywater/skywater130/libs/sky130hd/v0_0_2/lib/sky130_fd_sc_hd__ff_100C_1v95.lib.gz
Reading liberty file for slow: /usr/local/lib/python3.10/dist-packages/siliconcompiler-0.12.1-py3.10-linux-x86_64.egg/third_party/pdks/skywater/skywater130/libs/sky130hd/v0_0_2/lib/sky130_fd_sc_hd__ss_n40C_1v40.lib.gz
Reading liberty file for typical: /usr/local/lib/python3.10/dist-packages/siliconcompiler-0.12.1-py3.10-linux-x86_64.egg/third_party/pdks/skywater/skywater130/libs/sky130hd/v0_0_2/lib/sky130_fd_sc_hd__tt_025C_1v80.lib.gz
Reading ODB: inputs/heartbeat.odb
Reading SDC: inputs/heartbeat.sdc
Warning: There is 1 input port missing set_input_delay.
Warning: There is 1 output port missing set_output_delay.
Warning: There is 1 unconstrained endpoint.
[INFO ORD-0030] Using 4 thread(s).
[INFO FLW-0001] Setting global routing adjustment for li1 to 100.0%
[INFO FLW-0001] Setting global routing adjustment for met1 to 30.0%
[INFO FLW-0001] Setting global routing adjustment for met2 to 30.0%
[INFO FLW-0001] Setting global routing adjustment for met3 to 30.0%
[INFO FLW-0001] Setting global routing adjustment for met4 to 30.0%
[INFO FLW-0001] Setting global routing adjustment for met5 to 30.0%
#######################
# Global Placement
#######################
set openroad_gpl_args []
if {$openroad_gpl_routability_driven == "true"} {
  lappend openroad_gpl_args "-routability_driven"
}
if {$openroad_gpl_timing_driven == "true"} {
  lappend openroad_gpl_args "-timing_driven"
}
global_placement {*}$openroad_gpl_args \
  -density $openroad_gpl_place_density \
  -pad_left $openroad_gpl_padding \
  -pad_right $openroad_gpl_padding
[INFO GPL-0002] DBU: 1000
[INFO GPL-0003] SiteSize: 460 2720
[INFO GPL-0004] CoreAreaLxLy: 5060 5440
[INFO GPL-0005] CoreAreaUxUy: 49680 48960
[INFO GPL-0006] NumInstances: 52
[INFO GPL-0007] NumPlaceInstances: 25
[INFO GPL-0008] NumFixedInstances: 27
[INFO GPL-0009] NumDummyInstances: 0
[INFO GPL-0010] NumNets: 27
[INFO GPL-0011] NumPins: 92
[INFO GPL-0012] DieAreaLxLy: 0 0
[INFO GPL-0013] DieAreaUxUy: 55000 55000
[INFO GPL-0014] CoreAreaLxLy: 5060 5440
[INFO GPL-0015] CoreAreaUxUy: 49680 48960
[INFO GPL-0016] CoreArea:<PHONE_NUMBER>
[INFO GPL-0017] NonPlaceInstsArea: 33782400
[INFO GPL-0018] PlaceInstsArea: 576803200
[INFO GPL-0019] Util(%): 30.23
[INFO GPL-0020] StdInstsArea: 576803200
[INFO GPL-0021] MacroInstsArea: 0
[InitialPlace]  Iter: 1 CG residual: 0.00000012 HPWL: 398050
[InitialPlace]  Iter: 2 CG residual: 0.00000012 HPWL: 390234
[InitialPlace]  Iter: 3 CG residual: 0.00000007 HPWL: 384753
[InitialPlace]  Iter: 4 CG residual: 0.00000009 HPWL: 382639
[InitialPlace]  Iter: 5 CG residual: 0.00000011 HPWL: 382451
[INFO GPL-0031] FillerInit: NumGCells: 50
[INFO GPL-0032] FillerInit: NumGNets: 27
[INFO GPL-0033] FillerInit: NumGPins: 92
[INFO GPL-0023] TargetDensity: 0.60
[INFO GPL-0024] AveragePlaceInstArea: 23072128
[INFO GPL-0025] IdealBinArea: 38453544
[INFO GPL-0026] IdealBinCnt: 50
[INFO GPL-0027] TotalBinArea:<PHONE_NUMBER>
[INFO GPL-0028] BinCnt: 4 4
[INFO GPL-0029] BinSize: 11155 10880
[INFO GPL-0030] NumBins: 16
[NesterovSolve] Iter: 1 overflow: 0.431505 HPWL: 207145
[INFO GPL-0100] worst slack 5.99e-09
[INFO GPL-0103] Weighted 3 nets.

[NesterovSolve] Iter: 400 overflow: 0.112651 HPWL: 724114
[INFO GPL-0100] worst slack 5.69e-09
[INFO GPL-0103] Weighted 3 nets.
 Re-run with a smaller max_phi_cof value.
Error: sc_place.tcl, 17 GPL-0307

Screenshots
No response
Additional Context
No response

@maliberty I thought there was a step in replace that added random noise to the instances to make sure that all the cells didn't end up on top of each other.

The clock net was getting a crazy weight which pulled all the register on top of each other (despite the small jiggle we introduce).  This is fixed in the forthcoming PR.


Problems when modifying model file

How you are using LightGBM?

LightGBM component:
Environment info

Operating System: Linux
CPU/GPU model: NA
C++ compiler version: NA
CMake version: NA
Java version: NA
Python version: conda install 2.3.0
R version: NA
Other: NA

LightGBM version or commit hash: NA
Error message and / or logs

Hi
We would like to modify a model file, but few things seems wrong.
1 When we modify shrinkage/leaf values, and load, sometime the kernel dies
2 When we modify the shrinkage, and load the model (And the kernel does not die), the predictions are the same as the original model, before modifying the shrinkage
Thanks
Reproducible example(s)

Steps to reproduce

Build LightGBM regression model
Save model to text file
Modify shrinkage/leaf values
Load and predict using the modified model

Two issues
a. either the kernel dies (both modifications)
b. the model predictions do not change (it if not dies) (in case of shrinkage change)

@kobics if you change the model file manually, you should remove the tree_size field.


Change example dagrunner code to export PNG of graph

A small change the the README to include code to export an image of the example graph as a PNG file.

Thanks @mo-robert-purvis


run command after login host can't autorun

Is your feature request related to a problem? Please describe.

I want use ConnectBot as onekey button to run 1 line command,but now,I need click host-name,click the keyboard button,press enter. ok the auto command running....
Describe the solution you'd like

Would you add a switch button to control "Run Command after login",then when login host, the command  automatic run without mannully press Enter?

What is your host? The command is autorun for me on Ubuntu but not on Windows.

What is your host? The command is autorun for me on Ubuntu but not on Windows.

My host is windows,usually I use this app to run only one command which is typed in autorun box.

I solved it by using a specific ssh public key that I don't use for anything else. With a PowerShell script and Scheduled Task that is triggered on OpenSSH events, I check if the last login was made with that key (a hash appears in the log) then I run what I want from within the PS script (and kill and restart the sshd process so Connectbot closes). This way I don't need to put any premade commands into connectbot.

I've notice the same problem connecting via SSH to a Debian machine.
The command after loing is typed on the shell after SSH but I need to manually press  to actually run the command.
I believe this is a bug?

My issue has been solved by author.When OpenSSH has any operate do the action cmd via windows scheduled task.

---- Replied Message ----

From
Jack<EMAIL_ADDRESS>

Date
06/19/2022 20:08

To

Cc
、

Subject
Re: [connectbot/connectbot] run command after login host can't autorun (Issue #1097)

I've notice the same problem connecting via SSH to a Debian machine.
The command after loing is typed on the shell after SSH but I need to manually press  to actually run the command.
I believe this is a bug?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

https://github.com/connectbot/connectbot/issues/1128


Option to disable plots window

Issue Report Checklist

[X] Searched the issues page for similar reports
[X] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[X] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
N/A Could not reproduce inside jupyter qtconsole (if console-related)
N/A Tried basic troubleshooting (if a bug/error)
[X] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
I would like to be able to disable the plots window, but I can't find an option to allow me to do this.
I use the Variable Explorer extensively, and every time I start Spyder, the first thing I do is switch from the Help tab (which I never use) to the Variable Explorer tab.  I have the Graphics Backend setting set to Automatic, which causes matplotlib plots to appear in another window, with all the (wonderful) interactive tools available.  That all works really well (although defaulting to the Variable Explorer tab instead of Help would be a nice touch).
When I use sympy, I use this:
import sympy as sy
from IPython.display import display
sy.init_printing()

I can then use display to print sympy equations (assuming I've disabled the "Mute inline plotting" option).  However, when I display an equation in the console, it also puts it into the plots window and switches the display from Variable Explorer to the Plots window.  I have to manually remove all plots from the plots window to get rid of the equations and then manually switch back to the Variable Explorer.
If I just type the name of the variable into the console, it works as I would like, but I can't make this work within a script - hence the use of IPython.display, which sort of works but has the undesired side-effects with the plots window.
What steps reproduce the problem?

Disable the "Mute inline plotting" option
Set graphics backend to "Automatic"
Verify that matplotlib figures open in a new windows as desired
Make sure the Variable Explorer is visible
Create a script that creates a sympy equation and uses IPython.display to print it to the console and run it:

import sympy as sy
from IPython.display import display
sy.init_printing()

s = sy.Symbol('s')
g = 1 / sy.Poly([1, 10], s)
display(g)

What is the expected output? What do you see instead?
What should happen: Equation should be latex-ified and printed to the console; Variable Explorer should stay visible; Plots window should stay empty.
What actually happens: Equation is latex-ified and printed to the console (correct), Plots window becomes visible, hiding Variable Explorer (incorrect), Plots window gains a new "Plot" consisting of the image of the latex-ified equation (incorrect)
Versions

I've tried conda update spyder, but the more recent 5.0.x versions don't seem to be available via conda yet.

 I think this is a good idea. @ccordoba12 is there an easy way to implement this so that we can add an option (I guess in preferences) to disable the plots pane?

Hey @abudden and @juanis2112, I fixed this issue in our 5.0.2 version, released a couple of weeks ago. Let's hope it'll be added to Anaconda soon.
If you disable "Mute inline plotting" and hide the Plots pane, it won't be shown again.


Doc: Add build cache discussion

Adds discussion on build cache cleanup in response to user feedback.

Now that we don't have SAMPLE_APPS grouping, we could change the build directory by default to be build/[appname]. That would avoid any potential issues. There are two caveats:

The launch command would have to match the name of the application and if the build directory is set the launch command would not work (unless the build directory is specified - this is a current issue actually since the launch command will not work if the build directory is not named "build")
Two applications using the same operator will build the operator multiple times - this is probably OK since some compilation might be different based on the container (for instance).

Now that we don't have SAMPLE_APPS grouping...

@jjomier I agree that we should move in that direction. In the meantime I'd like to move forward with this PR to fill a gap in documentation based on existing behavior. What do you think?


650M corpus was splited to 40 files pass to create_pretraining_data, but it takes too long time

after 24 hours, it still runing.
python create_pretraining_data.py --input_file=BERT_BASE_DIR/all_file_merge.copyblock_notitle_linesplit.txt-6400* --output_file=BERT_BASE_DIR/tf_examples-64.tfrecord --vocab_file=chn_vocab --do_lower_case=True --max_seq_length=64 --max_predictions_per_seq=20 --masked_lm_prob=0.15 --random_seed=12345 --dupe_factor=5
all_file_merge.copyblock_notitle_linesplit.txt-6400* is all_file_merge.copyblock_notitle_linesplit.txt-640001 to all_file_merge.copyblock_notitle_linesplit.txt-640039
each file less than 20M

are you using tensorflow-gpu?  it was taking forever to do one iteration on my laptop with a 5Gb corpus with splits of ~250MB.  Tried it on my desktop with a 1080ti and it took around 20 hours to do the whole corpus and yielded a ~42GB tr.record!

how to use GPU to run create_pretraining_data.py

i actually think i'm wrong about that.  it's probably the fact that my desktop has much more ram and a better cpu.


Nanny process

Currently we spin up dworker processes on remote nodes.  These workers run our computations directly.  It might be preferable to instead launch a super or "nanny" process that launches dworker.
This has the following advantages:

Makes the network robust to catastrophic worker failure, such as would be caused by a segfault.  Nanny can just restart the worker
Can cleanly restart the worker nodes on user request, such as when they accidentally send up a very long running function
Can consistently monitor and send heartbeats to the scheduler.

This also raises some questions

How should the scheduler interact with the nanny?  Does the nanny proxy all communications to the worker (if so is there a significant cost/overhad here?)  Does the scheduler have two connections open?

I wanted to see how much overhead proxying all communications through a nanny process would be.  Here is a tiny benchmark.
In [1]: from multiprocessing import Process, Queue

In [2]: def f(inp, out):
    while True:
        data = inp.get()
        out.put(data)
   ...:

In [3]: inp, out = Queue(), Queue()

In [4]: proc = Process(target=f, args=(inp, out))

In [5]: proc.start()

In [6]: %time for i in range(1000): inp.put(1); out.get()
CPU times: user 135 ms, sys: 49 ms, total: 184 ms
Wall time: 279 ms

In [7]: import numpy as np

In [8]: x = np.empty(1000000, 'f8')  # 8MB

In [9]: %time for i in range(1000): inp.put(x); out.get()
CPU times: user 13.1 s, sys: 17.4 s, total: 30.5 s
Wall time: 56.6 s

In [10]: 8e6 * 1e3 / 56 / 1e6  # MB/s
Out[10]:<PHONE_NUMBER>5714286

So pushing our data through a nanny process in this manner adds an extra 150MB/s of (bidirectional) bandwidth resistance (on an old and low-powered laptop.)  This matches the general intuition of IPC maxing out at 300MB/s.  There are alternatives here, like communicating directly with the sub-process or finding a way to share memory.  I'm not sure how big of a deal this is.
@minrk, I believe that you've thought about this topic before.  Do you have thoughts on how to do this better?

After thinking about this a bit more it seems useful for the worker to maintain its own connections, particularly because proxying all of the peer-to-peer connections might become unruly.
So presumably the scheduler will maintain a control connection to the nanny process, separate to the data connection to the worker.

It looks like you have come to the same conclusion I did in my thinking about a KernelNanny for IPython - that the Nanny should only sit on the control channel, and execution should go direct to the actual worker. That way the nanny system cannot interfere with execution when everything is going smoothly, only when you actually want to intervene.

We now have a nanny process.  It doesn't do much except for kill and restart the workers, but its there and could do more in the future if we desire.  Closing.


Support Node 4.0 and npm 3.0

Lets add support to Node 4.0 and npm 3.0.

What parts need to be updated?  I just did the Quick Start Guide using Node v4.2.1, and it seemed to work perfectly.

I think it's npm that's the bigger problem.

Here's the system-npm issue: https://github.com/stealjs/system-npm/issues/72

I got errors installing with node 4.2.1 and npm 2.14.7.

@niallobrien did you try continuing after installing? I was able to complete the quick start guide with the same versions. I also got some errors like this, but they didn't prevent anything from working correctly.
../node_modules/nan/nan.h:398:30: note: expanded from macro 'NanEscapeScope'
# define NanEscapeScope(val) scope.Escape(_NanEnsureLocal(val))
                             ^
9 errors generated.
make: *** [Release/obj.target/validation/src/validation.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2

Any ETA on this?

@skolade My guess is over 2 weeks.  We are working on improving our test infrastructure to make verifying all the different of operation systems, node, and npm versions are working right.
Once that is done, we'll have to make the modifications to npm.  This is our highest priority effort right now.  @daffl is working on it almost full time.

Tracking the npm3 support in Steal here: https://github.com/stealjs/steal/issues/521
Also note that will need to update generator-donejs so that it enables Steal/npm3 if the user is using npm3.

Issue: https://github.com/donejs/generator-donejs/issues/55

This is done, verified to be working and released.


noncount noun / no plural form

Describe the Bug
When generating out the graphql schema, noncount nouns or words that have no plural forms cause the generation to skip in generating out 2 queries (the singular and plural form) of the find unique and find many for the specific cases (well, they're generated but they're called findUnique* and findMany*).
Example equipment will not generate out a query of equipment (findUnique) or equipments (findMany).
This is inside of the code for translating the dmmf: https://github.com/MichalLytek/typegraphql-prisma/blob/main/src/generator/dmmf/transform.ts#L426
To Reproduce
Create a model with a non-plural form word, it will not generate out a singular findUnique or plural findMany.
model Equipment {
  id  String  @id @default(ccuid())
}

Expected Behavior
On a noncount noun or no plural form, append an s to the end of the word anyway to account for handling this or provide a configuration option to be able to provide the singular / plural form to be utilized. My thinking is the ability to provide a customized plural form might be best.

Fixed by 80ce036, released in v0.21.5 🚀


[Event Modification] Codeunit 99000813 "Carry Out Action" - OnCarryOutToReqWkshOnBeforeReqLineInsert

Hi, would it be possible to modify the event OnCarryOutToReqWkshOnBeforeReqLineInsert Codeunit 99000813 "Carry Out Action"  to insert ReqWkshTempName, ReqJournalName, LineNo parameter, like this :

     procedure CarryOutToReqWksh(ReqLine: Record "Requisition Line"; ReqWkshTempName: Code[10]; ReqJournalName: Code[10])
    var
        ReqLine2: Record "Requisition Line";
        PlanningComp: Record "Planning Component";
        PlanningRoutingLine: Record "Planning Routing Line";
        ProdOrderCapNeed: Record "Prod. Order Capacity Need";
        PlanningComp2: Record "Planning Component";
        PlanningRoutingLine2: Record "Planning Routing Line";
        ProdOrderCapNeed2: Record "Prod. Order Capacity Need";
        ReqLine3: Record "Requisition Line";
    begin
        ReqLine2 := ReqLine;
        ReqLine2."Worksheet Template Name" := ReqWkshTempName;
        ReqLine2."Journal Batch Name" := ReqJournalName;

        if LineNo = 0 then begin
            // we need to find the last line in worksheet
            ReqLine3.SetCurrentKey("Worksheet Template Name", "Journal Batch Name", "Line No.");
            ReqLine3.SetRange("Worksheet Template Name", ReqWkshTempName);
            ReqLine3.SetRange("Journal Batch Name", ReqJournalName);
            if ReqLine3.FindLast then
                LineNo := ReqLine3."Line No.";
        end;
        LineNo += 10000;
        ReqLine2."Line No." := LineNo;
    end;

        if ReqLine2."Planning Line Origin" = ReqLine2."Planning Line Origin"::"Order Planning" then begin
            ReqLine2."Planning Line Origin" := ReqLine2."Planning Line Origin"::" ";
            ReqLine2.Level := 0;
            ReqLine2.Status := 0;
            ReqLine2.Reserve := false;
            ReqLine2."Demand Type" := 0;
            ReqLine2."Demand Subtype" := 0;
            ReqLine2."Demand Order No." := '';
            ReqLine2."Demand Line No." := 0;
            ReqLine2."Demand Ref. No." := 0;
            ReqLine2."Demand Date" := 0D;
            ReqLine2."Demand Quantity" := 0;
            ReqLine2."Demand Quantity (Base)" := 0;
            ReqLine2."Needed Quantity" := 0;
            ReqLine2."Needed Quantity (Base)" := 0;
            ReqLine2."Qty. per UOM (Demand)" := 0;
            ReqLine2."Unit Of Measure Code (Demand)" := '';
        end;
        OnCarryOutToReqWkshOnBeforeReqLineInsert(ReqLine2, ReqWkshTempName, ReqJournalName, LineNo);
        ReqLine2.Insert();

        ReqLineReserve.TransferReqLineToReqLine(ReqLine, ReqLine2, 0, true);
        if ReqLine.Reserve then
            ReserveBindingOrderToReqline(ReqLine2, ReqLine);

        PlanningComp.SetRange("Worksheet Template Name", ReqLine."Worksheet Template Name");
        PlanningComp.SetRange("Worksheet Batch Name", ReqLine."Journal Batch Name");
        PlanningComp.SetRange("Worksheet Line No.", ReqLine."Line No.");
        if PlanningComp.Find('-') then
            repeat
                PlanningComp2 := PlanningComp;
                PlanningComp2."Worksheet Template Name" := ReqWkshTempName;
                PlanningComp2."Worksheet Batch Name" := ReqJournalName;
                if PlanningComp2."Planning Line Origin" = PlanningComp2."Planning Line Origin"::"Order Planning" then
                    PlanningComp2."Planning Line Origin" := PlanningComp2."Planning Line Origin"::" ";
                PlanningComp2."Dimension Set ID" := ReqLine2."Dimension Set ID";
                PlanningComp2.Insert();
                OnCarryOutToReqWkshOnAfterPlanningCompInsert(PlanningComp2, PlanningComp);
            until PlanningComp.Next = 0;

        PlanningRoutingLine.SetRange("Worksheet Template Name", ReqLine."Worksheet Template Name");
        PlanningRoutingLine.SetRange("Worksheet Batch Name", ReqLine."Journal Batch Name");
        PlanningRoutingLine.SetRange("Worksheet Line No.", ReqLine."Line No.");
        if PlanningRoutingLine.Find('-') then
            repeat
                PlanningRoutingLine2 := PlanningRoutingLine;
                PlanningRoutingLine2."Worksheet Template Name" := ReqWkshTempName;
                PlanningRoutingLine2."Worksheet Batch Name" := ReqJournalName;
                OnCarryOutToReqWkshOnAfterPlanningRoutingLineInsert(PlanningRoutingLine2, PlanningRoutingLine);
                PlanningRoutingLine2.Insert();
            until PlanningRoutingLine.Next = 0;

       [IntegrationEvent(false, false)]
    local procedure OnCarryOutToReqWkshOnBeforeReqLineInsert(var ReqLine: Record "Requisition Line";var ReqWkshTempName: Code[10]; var ReqJournalName: Code[10]; var LineNo: Integer);
    begin
    end;

Thanks

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Refactor reading of ignore files into its own library

This functionality would be useful as a standalone library. Happy to spearhead the refactor if you want.

+9000.`

I think that comment trumps your isaac-says-yes issue label :-P

Oh, yeah, that too :)


Add additional KNE topologies and add aggregate link testbeds

This change adds two new testbeds:

ate_dut with 4 agg links
ate_dut with 9 agg links

Additionally topologies for kne are added to fit all testbeds with an additional topo that fits all testbeds
Changing the enums will come in a follow up PR

Pull Request Functional Test Report for #1722 / 33c60fe649a124e68066f5a70b1596511ae5f740
No tests identified for validation.
Help

One question below. Also, I'd like @bstoll to sign off on the cloudbuild changes.

@bstoll I considered just deleting the auto presubmit test.sh as it doesn't do anything of value unless the binding itself gets changed. The new ci-trigger essentially can replace it by running tests that are actually modified. Maybe its better to keep it but turn off the auto run so it requires the gcbrun comment to manually trigger if its a PR that the presub would add a valuable signal. Either way let me know what you think and if the changes look good to you

My goal was to remove /cloudbuild/cloudbuild.yml, /cloudbuild/test.sh, and the general CloudBuild-GitHub integration once ci-trigger was a bit more proven reliable (ie #1727, still finding some minor problems), since ci-trigger does the same thing but in a more granular way.
Is the goal to have KNE do matching such that a single topology.textproto can cover all of these testbeds?  Or is there going to be anything that uses the topology.textproto testbed?

Is the goal to have KNE do matching such that a single topology.textproto can cover all of these testbeds?

Yes, the topology.textproto can match any of the testbeds. The drawback is sometimes 2 DUTs are created when the test only needs 1 DUT and this can unnecessarily increase resource usage. However it simplifies things greatly and can be very convenient when you want to bring up a single topo and run multiple tests against it in sequence using resets instead of a full tear down.
So with those tradeoffs outlined it seems like the CI-trigger could make good use of the topology.textproto (if it runs the tests in sequence) to save some time by avoiding a full tear down.


ROX-20288: Audit log without permissions

Description
This PR introduces ROX_AUDIT_LOG_WITHOUT_PERMISSIONS to conditionally remove resolved permissions for audit log messages to reduced the amount of information exposed within audit log messages.
This isn't recommended in all cases, since it may make investigation harder when wanting to figure out the current permissions for a requester at a specific point. Setting this environment variable will mean
the user has to check the associated role's permission set at the point of the request to get the permissions associated with the role.
The reason we decided to introduce this variable was:
a) on a user request.
b) requiring the user to look up the exact permissions is anyways required, since access scopes are currently not added in the audit log message and are required to get a full picture of permissions.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change

see the added unit test.

One additional manual test to see the audit log in action:

Deploy Central

./deploy/deploy.sh

(shameless plug) Add a notifier with audit logging enabled:

# This deploys a sample webhook server which logs audit log events.
kubectl apply -f https://raw.githubusercontent.com/dhaus67/webhook/main/hack/deployment.yaml
# This creates a declarative config for a notifier that has audit logging enabled + uses the previously deployed webhook server.
kubectl apply -f https://raw.githubusercontent.com/dhaus67/webhook/main/hack/audit-log-config.yaml

Observe the audit logs, they should look as-is.

kubectl logs -l app=webhook -n stackrox

Sample audit log message:

Enable the new environment variable:

kubectl set env -n stackrox deploy/central ROX_AUDIT_LOG_WITHOUT_PERMISSIONS=true

Observe the audit logs, they should now not expose the permissions:

kubectl logs -l app=webhook -n stackrox

Sample audit log message:

Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

Current dependencies on/for this PR:

master

PR #8242   👈

This comment was auto-generated by Graphite.


feat: add set entity actions

Adds new TakeSetEntityAction similar to the TakeTextAction and TakeAPIAction
Uses the new ReplaySetEntityException for errors during this.
Use proper discriminated union on IActionInput

When taking the action during teaching it displays a placeholder card similar to the API actions.

I chose the text memory.Set(entityName, VALUE) hoping to show the users what the affect of taking the action is doing to the memory and how they could simulate it within API callbacks if they wanted to do it themselves.  Open to more ideas though.
Cons that I see are too technical, or takes up two much vertical space.
Could remove the card title or text to consolidate although if we do it for this type we should probably do it for the rest.

:tada: This PR is included in version 0.319.0 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[CI] Augment existing build workflows to affix appropriate labels to PRs

Description:
Meshery release notes are auto-generated by Release Drafter. Release Drafter uses PR labels to create release notes and place changelogs into specific categories (e.g. Features, Maintenance, Docs...)
Contributors can manually affix labels to PRs. These labels provide information to the release notes drafter, so that each item in the changelog is categorized under it appropriate section.
Request:
Augment existing build workflows to affix appropriate labels to PRs based on changes to files in specific paths (e.g. file-path: /docs --> label: area/docs.
Example of Release Notes being categorized:

Originally posted by @leecalcote in https://github.com/meshery/meshery/issues/3851#issuecomment-897140731

@amino19 this is a great opportunity to welcome and collaborate with a new contributor. @asubedy have you joined the Layer5 community Slack workspace? If not, please do: https://slack.layer5.io. Perhaps, you and @amino19 can collaborate on this issue.
Let me know how you guys would like to proceed. There are many issues in need of assistance.

I would like to give this issue a try. Thank you

Wanna take this issue? :slightly_smiling_face:

Yes I would like to work on it. But I will be needing a lot of guidance for which I will definitely connect with @amino19 on slack.
Thank you @afzal442 and @leecalcote .

@asubedy : Yep for sure! Here you go. :rocket:
@afzal442 : Thanks, hope you'll stay tuned here...

@asubedy any update on your work?


Update SOFABoot version to v2.4.0

Update SOFABoot version to v2.4.0, fix #54

Pull Request Test Coverage Report for Build 180

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 50.959%

Totals

Change from base Build 179:
-0.1%

Covered Lines:
930

Relevant Lines:
1825

💛  - Coveralls


Update API documentation with updated limits of size and # for file attachments

Summary | Résumé
Added warning on current temp file size and max file number, to better inform our users with latest changes in Notify and temporary ones.
Related zenhub card.
Test instructions | Instructions pour tester la modification
Head over to the review app link. Specifically to these sections:

Sending a file by email
Envoyer un fichier par courriel

Due to a recent infrastructure change~s~, the current maximum size~s~ for all files and content within an email notification must be smaller than 6MB.

@yaelberger-commits, FR to match:
En raison d'un récent changement d'infrastructure, la taille maximale actuelle de tous les fichiers et du contenu du courriel doit être inférieure à 6 Mo.

Question: we've changed the non-API terminology from "personalization" to "custom content". Would it be worthwhile to change that here as well to align vocab and facilitate communication between non-dev and dev team members sending messages?

I fixed the typos @yaelberger-commits @anikbrazeau

@yaelberger-commits @YedidaZalik Regarding the personalisation vocabulary, I'd process it in a separate card. We might want to discuss what we will change and what we will keep. The personalisation word is used throughout the API requests and we won't be able to easily change this in the actual API calls, but we could change a few places within the documentation to better fit the rest of the app.

@YedidaZalik I changed the code owners so that you receive the content update notifications on this repository in the future, when documentation will get updated.

@jimleroyer @yaelberger-commits Thanks and I'm sorry I did not get to this yesterday.
I've read these notes and the page now, but this is my first time as a reviewer on the API. To make sure that I'm doing what I'm supposed to do, may I sync with one of you (I know you're both very busy right now)?

No problem @YedidaZalik ! Meeting with us would expedite this. Feel free to schedule a 15-30 minutes session with me or come to gathertown when we got the emoji in our Slack status. 👍

Thanks @jimleroyer
Given today's power outage, I've scheduled for Monday. Please feel free to change date and time so it works for you!

@jimleroyer -  some typos in :
1- Temporary restriction on overall files size
Due to a recent infrastructure changes, the current maximum sizes for all files and content within an email notification must be smaller than 6MB.
Please change to:
Temporary restriction on overall file size
Due to recent infrastructure changes, the current maximum size for all files and content within an email notification must be smaller than 6MB.
2 - Please change Error codes
If the request is not successful, the response body is json, refer to the table below for details.
TO:
Error codes
If the request is not successful, the response body is json. Refer to the table below for details.
@jimleroyer did I do this correctly?

@YedidaZalik All good 👍 , just pushed changes with your corrections.

I'm supposed to be seeing the deleted text as crossed out text, right? Other wise, lgtm!


Feature main screen

The main screen has been implemented, but there is no connection with the minigame yet.

Confirmed


Allow parsing month of October

Fixes an issue exposed via plan import where a plan file that had a start time in October did not parse the date properly due to dumb regex...

Do we really need October though? /s

Debatable


TemplateSyntaxError at /silk/ Invalid filter: 'silk_date_time'

I have fresh installation of silk, but I am getting the error when try switch to /silk/. The most likely cause for this is because in our project we already using tags located in file named filters.py so it raises name conflict with silk tags. Of course we can rename it, or set into nested package, but I think it would be nice if silk will use more specific names for tag files to avoid such errors in future.

This issue was resolved in commit: ce50e972971b06bdc2f0983d73059054388573c8


[SPARK-21743][SQL][followup] free aggregate map when task ends

What changes were proposed in this pull request?
This is the first follow-up of https://github.com/apache/spark/pull/21573 , which was only merged to 2.3.
This PR fixes the memory leak in another way: free the UnsafeExternalMap when the task ends. All the data buffers in Spark SQL are using UnsafeExternalMap and UnsafeExternalSorter under the hood, e.g. sort, aggregate, window, SMJ, etc. UnsafeExternalSorter registers a task completion listener to free the resource, we should apply the same thing to UnsafeExternalMap.
TODO in the next PR:
do not consume all the inputs when having limit in whole stage codegen.
How was this patch tested?
existing tests

cc @hvanhovell @viirya @gatorsmile

Test build #92763 has started for PR 21738 at commit 174c4e5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/784/
Test PASSed.

Test build #92763 has finished for PR 21738 at commit 174c4e5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92763/
Test FAILed.

retest this please.

Test build #92777 has started for PR 21738 at commit 174c4e5.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/794/
Test PASSed.

Merged build finished. Test PASSed.

LGTM. UnsafeExternalMap in the description means UnsafeFixedWidthAggregationMap ?

Test build #92777 has finished for PR 21738 at commit 174c4e5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92777/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/809/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92801/
Test FAILed.

retest this please.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92802/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/810/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/811/
Test PASSed.

Test build #92803 has finished for PR 21738 at commit 7f2b653.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92803/
Test FAILed.

Test build #92811 has finished for PR 21738 at commit 7f2b653.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92811/
Test PASSed.

thanks, merging to master!


How to use the dmptool API to retrieve the pdf, docx, and json versions of a plan?

For a given plan, how to use the API to download it in various formats?  For example, I have a plan with the id of 16453.  It is currently private.
From a browser in which I am logged in to dmptool.org, I'm able to retrieve the PDF from
https://dmptool.org/plans/16453.pdf
and the docx version from
https://dmptool.org/plans/16453.docx
However, I'd like to access the pdf, docx, and json formats from the API.  (I understand that there should be a json format of plan -- is that correct.)
I tried:
curl -H  "Authorization: Token token=token_number" https://dmptool.org/plans/16453.pdf

but that didn't work.
How can I get the pdf, docx, and json formats (which presumably has the questions and answers) programmatically?

https://dmptool.org/api/v1/plans_full/<plan_id> returns plan in JSON format

I can see that https://dmptool.org/api/v1/plans_full/ returns all the public plans in json format -- 58 of them when I just accessed this URL.  Very useful
However, I don't see how to use the API to access the pdf/docx/json versions of a given plan.  Plan # 16453 is a private one I created.  From a browser in which I'm logged into dmptool.org, I can download  https://dmptool.org/plans/16453.pdf and https://dmptool.org/plans/16453.docx.  But I've not been able to use the API to download the pdf or docx.  I tried
curl -H  "Authorization: Token token=token_number" https://dmptool.org/plans/16453.pdf

but instead of the PDF, I got a redirect to https://dmptool.org/

https://dmptool.org/api/v1/plans_full/ <plan_id>  returns the JSON format of a single plan.
the other 2 methods to access the PDF and DOCX formats are not available outside of the API.  These are direct method calls which are not set up to be use with the token authentication.  If we need these pages to be available using the token authentication, we will need to make a code change to accommodate.

@mxsstrong How do I use https://dmptool.org/api/v1/plans_full/ to return the JSON format for plan 16453 (a private plan that I authored)?
A central scenario I'd love to make happen is to let a user in osf.io pull up a list of her plans, pick one of the plans, and send the plan to osf.io.  So, yes, being able to access the PDF, DOCX, or JSON versions (the best option) from the API is something I'd need to make the scenario happen (as far as I can see.)

Here is an example of retrieving the json.  Just replace  with your token.
curl -H "Authorization: Token token=" https://dmptool.org/api/v1/plans_full/16453
As far as getting other formats.  We'd either need to add additional formats to the API or enable token authentication to parts of the non-api application.

i'm sorry Raymond, the markdown must have been removing the plan_id from the end of the API method.    Scott provided the proper syntax!  I hope this helps.

Thanks @sfisher and @mxsstrong -- putting the id at the end was exactly what  I needed.
If it's not a huge amount of work, making the pdf and docx available would be a nice addition.  Otherwise, if you can point me to where in your code you create the pdf and docx, I might be able to leverage your conversion code to generate the pdf/docx on my own side.

Probably would be easier to enable the token authentication or make the other formats available via the api - working with those formats can  be quite tedious.
How soon would you need these formats?
Do you have other non-api method calls that you need exposed?
marisa
From: Raymond Yee <notifications<EMAIL_ADDRESS>Reply-To: CDLUC3/dmptool <reply<EMAIL_ADDRESS>Date: Monday, October 19, 2015 at 11:10 AM
To: CDLUC3/dmptool <dmptool<EMAIL_ADDRESS>Cc: Marisa Strong <marisa.strong<EMAIL_ADDRESS>Subject: Re: [dmptool] How to use the dmptool API to retrieve the pdf, docx, and json versions of a plan? (#146)
Thanks @sfisherhttps://github.com/sfisher and @mxsstronghttps://github.com/mxsstrong -- putting the id at the end was exactly what I needed.
If it's not a huge amount of work, making the pdf and docx available would be a nice addition. Otherwise, if you can point me to where in your code you create the pdf and docx, I might be able to leverage your conversion code to generate the pdf/docx on my own side.

Reply to this email directly or view it on GitHubhttps://github.com/CDLUC3/dmptool/issues/146#issuecomment-149301083.

I'm trying to wrap my round of work for COS by the end of November.  But the json output gives me a lot to work with already--> so I'm not stuck.
Let me think a bit about the question of what other non-api method calls I need.  Off the top of my head, I'd love to have a way of listing only the plans owned by user given a auth token -- right now, I think I'd have to filter on the user's email address.

List of plans by user_id - what you would see on the My DMPs page ( a list of your own DMPs)
From: Raymond Yee <notifications<EMAIL_ADDRESS>Reply-To: CDLUC3/dmptool <reply<EMAIL_ADDRESS>Date: Monday, October 19, 2015 at 11:21 AM
To: CDLUC3/dmptool <dmptool<EMAIL_ADDRESS>Cc: Marisa Strong <marisa.strong<EMAIL_ADDRESS>Subject: Re: [dmptool] How to use the dmptool API to retrieve the pdf, docx, and json versions of a plan? (#146)
I'm trying to wrap my round of work for COS by the end of November. But the json output gives me a lot to work with already--> so I'm not stuck.
Let me think a bit about the question of what other non-api method calls I need. Off the top of my head, I'd love to have a way of listing only the plans owned by user given a auth token -- right now, I think I'd have to filter on the user's email address.

Reply to this email directly or view it on GitHubhttps://github.com/CDLUC3/dmptool/issues/146#issuecomment-149303627.

Re https://github.com/CDLUC3/dmptool/issues/146#issuecomment-149627300:  Yes I'd like to access from the API:

List of plans by user_id - what you would see on the My DMPs page ( a list of your own DMPs)

Is that likely to happen in the next month or two?  Or should I plan to ask user for the plan id (at least as a start)?

The calls for a list of plans and plans with attributes are still missing the plan ID:
https://dmptool.org/api/v1/plans
https://dmptool.org/api/v1/plans_full

Add the id to the output of the https://dmptool.org/api/v1/plans method.
Only return private plans (plans owned by the user associated with the AUTH token).  Possibly new API call for plans_owned

new calls deployed to production; wiki updated


Dynamically rendering inputs causes validation to always return false

As discussed on discord, I got a more minimal reproduction of both issues in a sandbox. It's using astro to be more closely related to my actual environment.
https://dub.sh/XMsdjBH
Just adding the comment from @fabian-hiller

I think that the bug is in line 117. Here valid is set to false if at least one error was found when validating the schema. Since schema validation always validates the entire schema, in your case validate is always set to false. However, this should only happen if an error applies to an selected field. I need to check this more closely though. https://github.com/fabian-hiller/modular-forms/blob/main/packages/solid/src/methods/validate.ts#L117

Thank you very much! I will investigate the problem as soon as possible (probably today or tomorrow) and find a solution.

Awesome, let me know if I can help in any way.

The bug should be fixed in the new version. Feel free to contact me if you have further problems.