[Feature request]: Distribute debug symbols/PDB files

Is your feature request related to a specific problem? Or an existing feature?
I am trying to debug Swashbuckle behavior but can't due to debug symbols missing
Describe the solution you'd like
Distributing PDB files/debug symbols in BuGet enables to debug swashbuckle from code dpendning on it
Additional context
No response

I'll have to check when I'm at a computer, but there should be embedded symbols in the assemblies so you should be able to debug without PDB files.

True but the experience is not very seamless and clean

That sounds more like a problem with whatever tooling you're using, than something we need to worry about.
I'm fairly sure the setup here is the same one I put into Polly, and last time I debugged through into non user code in Visual Studio it all "just worked".
Again, I'll check it for myself when I'm at a computer, but if I get the experience I'm expecting to get with the latest version of Swashbuckle, then it's working as intended.

You can close the issue if it's the case

Actually, no, I think you're right and it's not setup correctly - I just noticed that's the disassembled code, not the actual code.
Compare with the real top-of-the-method:
https://github.com/domaindrivendev/Swashbuckle.AspNetCore/blob/bb498849621f36ea17d83e76631869c240732b0d/src/Swashbuckle.AspNetCore.SwaggerGen/DependencyInjection/SwaggerGenServiceCollectionExtensions.cs#L17-L19

snupkg files are created and published for all packages except Swashbuckle.AspNetCore:

I'm going to guess that's a detail of the fact it's a meta-package and doesn't contain any actual code.


[Meshery-Extension] setup single source of truth for svgs

Signed-off-by: Abhishek kr<EMAIL_ADDRESS>Description

Adds up the component svgs to be used by meshery as well as meshery-extension under a static file host.
This PR fixes #

Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Depends on https://github.com/meshery/meshery/pull/5885

Things like the cluster-role.svg will need two versions: one without the shape (circle, which should be a rounded rectangle) and one with the shape.

Hmmm, Okay. This PR don't has the cluster role changes. I think @Harshit-Dandriyal is tracking that in his seperate branch. So the svgs can be added and chosen.

For now merging this PR, since it has some crucial changes wrt visualiser fixes.


slider not properly working on internet explorer

Hello guys
slick not properly working on IE11
and i'm using slick v 1.8.1
my problem is same as issue #1911
please have a look
i provide link & please run this link on IE11
https://thepickstockgroup.com/dev/#Case-Studies
thankyou so much

thankyou guys
i got my answer from issue #1911 @Nicolai8 comment
thankyou so much


[Test Framework] Remove apps component

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nmittler
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [nmittler]
tests/integration/pilot/OWNERS [nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nmittler, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [nmittler,ozevren]
tests/integration/pilot/OWNERS [nmittler,ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-galley-local-presubmit-tests.sh
5afaf36da81cdcb88f7c808814fa014237f2bca7
link
/test integ-galley-local-presubmit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-galley-local-presubmit-tests.sh
5afaf36da81cdcb88f7c808814fa014237f2bca7
link
/test integ-galley-local-presubmit-tests

prow/release-test.sh
5afaf36da81cdcb88f7c808814fa014237f2bca7
link
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
5afaf36da81cdcb88f7c808814fa014237f2bca7
link
/test release-test

prow/istio-integ-k8s-tests.sh
5afaf36da81cdcb88f7c808814fa014237f2bca7
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, nmittler, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [nmittler,ozevren]
tests/integration/pilot/OWNERS [nmittler,ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
5afaf36da81cdcb88f7c808814fa014237f2bca7
link
/test release-test

prow/istio-integ-k8s-tests.sh
5afaf36da81cdcb88f7c808814fa014237f2bca7
link
/test istio-integ-k8s-tests

prow/integ-pilot-k8s-presubmit-tests.sh
06eed80cfaf71c2b77935823aac7966893e93df3
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
5afaf36da81cdcb88f7c808814fa014237f2bca7
link
/test istio-integ-k8s-tests

prow/integ-pilot-k8s-presubmit-tests.sh
06eed80cfaf71c2b77935823aac7966893e93df3
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
06eed80cfaf71c2b77935823aac7966893e93df3
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
5afaf36da81cdcb88f7c808814fa014237f2bca7
link
/test istio-integ-k8s-tests

prow/integ-security-k8s-presubmit-tests.sh
06eed80cfaf71c2b77935823aac7966893e93df3
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
06eed80cfaf71c2b77935823aac7966893e93df3
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-integ-k8s-tests.sh
06eed80cfaf71c2b77935823aac7966893e93df3
link
/test istio-integ-k8s-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


readme.md

updated version of readme.md

@photodesignch,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


feat: port NumberTheory.Zsqrtd.GaussianInt

https://leanprover-community.github.io/mathlib-port-status/file/number_theory/zsqrtd/gaussian_int
seems to indicate that this has all dependencies ported, but it seems like it needs
https://leanprover-community.github.io/mathlib-port-status/file/number_theory/legendre_symbol/quadratic_reciprocity,
which at the time of writing has
Dependencies 16 + 2 + 1008

That's just because leanprover-community/mathlib#1919e hasn't been processed by mathport yet, I think.

ok, cool, there should be only one missing dependency, namely number_theory/zsqrtd/quadratic_reciprocity.lean for GaussianInt,  I suppose

Otherwise LGTM. Thanks!
bors d+

bors r+


fix problem with sharksfin-like velocity time profile on high acceler…

…ation motors
I'm starting the pull request now so you can take a look, but I will also add a test that proves the result tomorrow.
The issue was that the start point position was calculated in pmac_child_part.move_to_start using motor_info.ramp_distance without any minimum ramp time.
However when calculating the run up time later in pmac_child_part.calculate_generator_profile we were capping at a minimum .002s. Thus the 1st Prev->Current velocity calculation was out and threw the rest of them.
This is probably my record for the longest, most circuitous route to a simple solution (and I was already world champion)

Codecov Report

Merging #308 into master will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   92.13%   92.32%   +0.18%
==========================================
  Files         211      212       +1
  Lines       10859    10978     +119
==========================================
+ Hits        10005    10135     +130
+ Misses        854      843      -11

Impacted Files
Coverage Δ

malcolm/modules/pmac/infos.py
100.00% <100.00%> (ø)

malcolm/modules/pmac/parts/pmacchildpart.py
94.05% <100.00%> (ø)

malcolm/modules/pva/controllers/__init__.py
100.00% <0.00%> (ø)

malcolm/modules/ADPco/blocks/__init__.py
0.00% <0.00%> (ø)

malcolm/core/process.py
94.90% <0.00%> (+0.38%)
:arrow_up:

malcolm/core/hook.py
95.79% <0.00%> (+0.84%)
:arrow_up:

...modules/scanning/controllers/runnablecontroller.py
90.66% <0.00%> (+0.93%)
:arrow_up:

...modules/ADPandABlocks/parts/pandaseqtriggerpart.py
92.88% <0.00%> (+1.89%)
:arrow_up:

malcolm/modules/pva/controllers/pvaservercomms.py
98.00% <0.00%> (+5.61%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a1186...d65db13. Read the comment docs.

This makes sense for a ramp at the start, but why are turnarounds also provoking the shark's fin case?

Hmmm,
It did fix all the sharks fin effects and the reason is that all points are velocity mode 1 Prev->Current (except for the very first and last).
Thus any inaccuracies are propagated through the whole scan.
This is bad because the math needs to be dead accurate to work through and entire long scan. I'm guessing that this is unintentional but cant recall what is intended.

Reviewing the unit tests today, I note that the standard configure test for pmac_child_part yields:
velocityMode= [1, 0, 0, 0, 0, 0, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 0, 1, 3])
i.e. prev->next in the row and prev->current in the turnarounds
But once we add MotionTriggerInfo(MotionTrigger.NONE)]. The rows loose all intermediate points and it becomes:
velocityMode=pytest.approx([1, 1, 1, 1, 1, 1, 1, 3])
So this is OK except that any problem in calculation will propagate the length of the scan. I also feel that any floating point rounding issues might accumulate over a very long scan.
Solution:
For the linear case it would be OK to use current->next for the starting point and it is only the linear case for which sparse trajectories apply.

Out of interest, why do you not use Current -> Next for row entry?

@GDYendell

Out of interest, why do you not use Current -> Next for row entry?

When the pmac is not triggering we use sparse trajectories to allow faster triggering than the pmac can do points at. So in a linear row we throw away all of the points except the first lower and and the last upper. Those always use prev->current, so we have ended up throwing away all current->next points.

If you only have two points per row, shouldn't it do:
C->N .......... P->C
C->N .......... P->C
so that the trajectory through all the points is 'horizontal'.
If you do P->C on the row entry, won't the velocity be this way through the first lower?:
                  o
           o
    o

L

Sorry I don't understand your ascii art but I think the confusion is over the fact that we have changed how P->C works and you may not know about it yet.
see https://confluence.diamond.ac.uk/x/Eh_vBQ in particular the heading Fix Previous to Next Calculation which shows the new math.
(@thomascobb This confirms the need to change the name of this velocity mode!)

@thomascobb and @gilesknap have agreed that the least invasive solution to this is to use the old averaging P->C velocity mode for the final point in a row.
There are only 2 bits used to encode the velocity mode, but luckily the old CURRENT->NEXT is no longer used.
The naming has become confusing so I propose the following new names for the 4 modes:
class VelocityModes:
    AVERAGE_PREV_TO_NEXT = 0
    REAL_PREV_TO_CURRENT = 1
    AVERAGE_PREV_TO_CURRENT = 2
    ZERO_VELOCITY = 3```

Just because the unit tests pass ...
The above checkin broke things:

No wait. That is because I patched CURRENT->NEXT back in on my test rig. Nobody else will have that.

Something is still up.
In latest released version of Prog 1 now running on my brick we have:
    ; Select velocity calculation based on VelMode value
    If(VelMode = 1)
        GoSub105                        ; Prev -> Current
    EndIf
    If(VelMode = 0)
        GoSub106                        ; Prev -> Next
    EndIf
    If(VelMode = 2)
        ; GoSub107                        ; Current -> Next
        ; TODO TODO - hack - this should be fixed Malcolm
        GoSub105
    EndIf
    If(VelMode = 3)
        GoSub108			; Zero
    EndIf

implying velmode 2 and velmode 1 do the same thing.
With the latest pymalcolm which puts velmode 2 at the end of a sparse row we see:
X/Y

t/v

But with the previous pymalocm which uses velmode 1 throughout:
X/Y

t/v

That is a visualisation error. My plotting code still sees 2 as Current->Next. So all is well.

I believe this is ready to merge.
My Malcolm system tests in pmac module pass with the new version of Prog1 and the old version of Prog1.


Next 13 app directory doesn't work with tamagui plugin

Current Behavior
I tried using Tamagui with Next app directory. Using withTamagui from @tamagui/next-plugin breaks any page rendered with this error :
error - ./src/app/layout.tsx:1:10
Syntax error: <PATH TO MY APP>/src/app/layout.tsx Unknown word

> 1 | import { jsxDEV as _jsxDEV, Fragment as _Fragment } from "react/jsx-dev-runtime";

Expected Behavior
No response
Tamagui Version
tamagui and tamagui's next plugin versions: 1.14.3
next versions: 13.3.0 and 13.3.1-canary.4

Reproduction
Move Tamagui's Next starter to an app directory structure and enable `appDir` in `next.config.js.`

Note: I used pnpm workspaces instead of yarn

System Info
In the `app/next` folder:

  System:
    OS: Linux 5.15 Ubuntu 20.04.6 LTS (Focal Fossa)
    CPU: (4) x64 Intel(R) Core(TM) i5-6300HQ CPU @ 2.30GHz
    Memory: 14.88 GB / 31.25 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 16.13.0 - ~/.nvm/versions/node/v16.13.0/bin/node
    npm: 8.1.0 - ~/.nvm/versions/node/v16.13.0/bin/npm
    Watchman: 20210502.141248.0 - /usr/local/bin/watchman
  Browsers:
    Chrome: 112.0.5615.49
    Firefox: 111.0.1
  npmPackages:
    @my/ui: workspace:* => 0.0.1
    @tamagui/animate-presence: 1.14.3 => 1.14.3
    @tamagui/colors: 1.14.3 => 1.14.3
    @tamagui/config: 1.14.3 => 1.14.3
    @tamagui/demos: 1.14.3 => 1.14.3
    @tamagui/font-fira-mono: 1.14.3 => 1.14.3
    @tamagui/font-inter: 1.14.3 => 1.14.3
    @tamagui/font-silkscreen: 1.14.3 => 1.14.3
    @tamagui/logo: 1.14.3 => 1.14.3
    @tamagui/lucide-icons: 1.14.3 => 1.14.3
    @tamagui/menu: 1.14.3 => 1.14.3
    @tamagui/next-plugin: 1.14.3 => 1.14.3
    @tamagui/next-theme: 1.14.3 => 1.14.3
    @tamagui/remove-scroll: 1.14.3 => 1.14.3
    @tamagui/shorthands: 1.14.3 => 1.14.3
    @tamagui/themes: 1.14.3 => 1.14.3
    @tamagui/toast: 1.14.3 => 1.14.3
    @types/node: ^18.6.4 => 18.15.11
    app: workspace:* => 0.0.0
    eslint-config-next: ^13.0.4 => 13.3.0
    next: ^13.2.4 => 13.3.0
    raf: ^3.4.1 => 3.4.1
    react: ^18.2.0 => 18.2.0
    react-dom: ^18.2.0 => 18.2.0
    react-native: ^0.71.4 => 0.71.6
    react-native-web: ^0.18.12 => 0.18.9
    react-native-web-lite: ^1.14.3 => 1.14.3
    tamagui: 1.14.3 => 1.14.3
    vercel: latest => 28.18.5

We have this working in a branch. Expect the fix in the upcoming releases!

We have this working on one of the branches. Expect the fix in the upcoming releases!

Should be fixed on latest!


Gradle plugin is not consistently published to plugins.gradle.org

The currently published versions seem to be:

3.0.1
0.3.0
0.2.0

See here: https://plugins.gradle.org/plugin/com.palantir.launch-config/3.0.1
However, the most recent version is 0.3.4. Could each release be automatically published to plugins.gradle.org to guarantee that users can pick up the latest version?

I'm closing this because the plugin has appeared to change names

yeah, the latest plugin is here :( https://plugins.gradle.org/plugin/baseline.launch-config
@zoubeiri for SA


Error creating conda env. probably due to pip

Describe the bug
An error occurs when creating the silcam conda environment, where packages that would be installed by pip aren't found
To Reproduce
Working on a mac using conda version 4.8.3 and having completely deleting the silcam environment creating silcam from the .yml file with:
conda env create -f environment.yml --force
I get the following output:
conda env create -f environment.yml --force
Warning: you have pip-installed dependencies in your environment file, but you do not list pip itself as one of your conda dependencies.  Conda may not use the correct pip to install your packages, and they may end up in the wrong place.  Please add an explicit pip dependency.  I'm adding one for you, but still nagging you.
Collecting package metadata (repodata.json): done
Solving environment: done
Preparing transaction: done
Verifying transaction: done
Executing transaction: done
Ran pip subprocess with arguments:
['/Users/odin/anaconda3/envs/silcam/bin/python', '-m', 'pip', 'install', '-U', '-r', '/Users/odin/Sintef/SilCam/PySilCam/condaenv._yurf74i.requirements.txt']
Pip subprocess output:

Pip subprocess error:
Traceback (most recent call last):
  File "/Users/odin/anaconda3/envs/silcam/lib/python3.5/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/Users/odin/anaconda3/envs/silcam/lib/python3.5/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/Users/odin/anaconda3/envs/silcam/lib/python3.5/site-packages/pip/__main__.py", line 16, in <module>
    from pip._internal import main as _main  # noqa
  File "/Users/odin/anaconda3/envs/silcam/lib/python3.5/site-packages/pip/_internal/__init__.py", line 42, in <module>
    from pip._internal import cmdoptions
  File "/Users/odin/anaconda3/envs/silcam/lib/python3.5/site-packages/pip/_internal/cmdoptions.py", line 16, in <module>
    from pip._internal.index import (
  File "/Users/odin/anaconda3/envs/silcam/lib/python3.5/site-packages/pip/_internal/index.py", line 25, in <module>
    from pip._internal.download import HAS_TLS, is_url, path_to_url, url_to_path
  File "/Users/odin/anaconda3/envs/silcam/lib/python3.5/site-packages/pip/_internal/download.py", line 39, in <module>
    from pip._internal.utils.glibc import libc_ver
  File "/Users/odin/anaconda3/envs/silcam/lib/python3.5/site-packages/pip/_internal/utils/glibc.py", line 3, in <module>
    import ctypes
  File "/Users/odin/anaconda3/envs/silcam/lib/python3.5/ctypes/__init__.py", line 7, in <module>
    from _ctypes import Union, Structure, Array
ImportError: dlopen(/Users/odin/anaconda3/envs/silcam/lib/python3.5/lib-dynload/_ctypes.cpython-35m-darwin.so, 2): Library not loaded: @rpath/libffi.6.dylib
  Referenced from: /Users/odin/anaconda3/envs/silcam/lib/python3.5/lib-dynload/_ctypes.cpython-35m-darwin.so
  Reason: image not found

CondaEnvException: Pip failed

Expected behavior
Obviously I would expect this to work, with some success message from pip and then conda.
Additional context
The conda env is created (partially, I believe all the non-pip packages are installed correctly, although this isn't tested), so I can go into it and find which version of pip was used:
pip                       10.0.1                   py35_0    anaconda

Which seems to be a default pip for python 3.5.

would be interesting to see if this is a mac thing, or if you get the same problem in linux.

would be interesting to see if this is a mac thing, or if you get the same problem in linux.

The automated tests would pick it up in that case, I think. The observed error appears to be caused by the version of libffi that gets installed on mac. In the Docker environment, we have version 3.2.1, but on mac we get version 3.3, based on the same environment.yml file. Installing version 3.2.1 explicitly on mac seems to fix the problem.

I have tested Raymond's above message, and I can concur that it works.
So adding:
    - pip=10.0.1
    - libffi=3.2.1

to the environment.yml file could be done? Note that I tested this locally, and it actually matters the oder in which this is added, it worked when directly after the python install, but not at the end. Also, the pip version isn't actually needed, but maybe nice.

ok. cool. if it works, then just go ahead and make a PR.

I had an issue with libffi this morning on a windows machine. had to install via conda-forge. Anyone with a Windows machine who can check?


Java implementation of Binary Searh algorithm

This pull request is for issue number #37

LGTM :+1:

Thanks for your contribution! You should be able to see your code live on the corresponding post in a few minutes! :smile:


bugfix: autospec for CN

Auto recommendation failed. Added the recommendation manually in defmol.py
from exojax.spec import	AutoXS
import numpy as	np
nus=np.linspace(1800.0,2200.0,40000,dtype=np.float64)
autoxs=AutoXS(nus,"ExoMol","CN")
xsv=autoxs.xsection(1000.0,1.0)

@minouHub you'll be interested too


CSS Handlers through postcss

Transforming styles with postcss

We may be open to switching to postcss but this PR is just broken. You removed minifyCss but it's still referenced and cssNano isn't used.


[RFC] Hide or remove inappropriate units K R and D

The Kelvin scale is widely used in science and technology.
The Rankine scale may be used in engineering systems where heat computations are done using degrees Fahrenheit.
The Delisle thermometer remained in use for almost 100 years in Russia (from 1732). Are we supporting a scale unused since 1832?

from wikipedia
I never saw another app with these scales, please leave your thoughts...

They were meant as a joke more than anything useful.

Kelvin is widely used internationally, while Rankine has legacy usage in the US and Delisle has legacy usage in Russia.
http://en.wikipedia.org/wiki/Conversion_of_units_of_temperature

Yes.  Let's just keep F and C.

@nexus6-haiku verify when this is done and then this one can be closed.

Done. I'll close it.


SEPG Automated Release - v2.0.1

SEPG Details
Release Build Link: http://sou-jenkins2.swinfra.net:8080/job/Auto-Release/298/
Build Token: github.com/CAFapi/opensuse-tomcat-jre17-image/main/711816fccc098c7cf621a4241d140d88ec4d421e
Versioning Behaviour: Roll on to next minor
Artifacts For Release
Docker

cafapi/opensuse-tomcat-jre17:2.0.1 (Static Tag)
cafapi/opensuse-tomcat-jre17:2.0 (Dynamic Tag)
cafapi/opensuse-tomcat-jre17:2 (Dynamic Tag)
cafapi/opensuse-tomcat-jre17:latest (Dynamic Tag)
cafapi/opensuse-tomcat-jre17-juli:2.0.1 (Static Tag)
cafapi/opensuse-tomcat-jre17-juli:2.0 (Dynamic Tag)
cafapi/opensuse-tomcat-jre17-juli:2 (Dynamic Tag)
cafapi/opensuse-tomcat-jre17-juli:latest (Dynamic Tag)

 Build Stage
Action
Status

Release Checks
completed
:heavy_check_mark:

Gather Release Data

:white_small_square:

QA Documentation Site Deployment

:white_small_square:

QA Deployment Branch Promotion

:white_small_square:

Docker Image Promotion

:white_small_square:

Maven Artifact Promotion (Closed Source)

:white_small_square:

NuGet Artifact Promotion

:white_small_square:

Artifactory Release Artifact Tagging

:white_small_square:

Generic Artifact Promotion

:white_small_square:

Maven Artifact Promotion (Open Source)

:white_small_square:

Maven Staging Repository Removal (Open Source)

:white_small_square:

Git Tagging

:white_small_square:

Git Release

:white_small_square:

Git Release Asset Deployment

:white_small_square:

Pull Request Merge

:white_small_square:

Release Branch Deletion

:white_small_square:

view the build log here


NEMOVAR interface to orca-jedi/JEDI

Description
Include code to allow orca-jedi and NEMOVAR to interface.
More details to follow...
I've created a branch with some developments but note this is not necessarily the final form the interface will take
https://github.com/MetOffice/orca-jedi/tree/feature/nemovar_interface
Acceptance Criteria (Definition of Done)
TBC
Dependencies
TBC

One note would be, I think its important to ensure we can build without nemovar for compatibility with the NG-PAO project. So at the CMAKE level perhaps we can use a switch to decide whether we build with nemovar interface or not?

I have been looking over examples in SABER and trying ot understand your prototype change. I think it would be better if we could get the part of your change that lives in the saber namespace into saber itself, similar to the way this is done for NOAAs GSI. They package their covariance fortran routines as a library and then interface to them as part of saber if the library is found:
Here is the switch they use: https://github.com/JCSDA-internal/saber/blob/48c0f95b83a946277d8c7bcd7c95af898f0d8da3/CMakeLists.txt#L75
and the GSI stuff is here: https://github.com/JCSDA-internal/saber/tree/develop/src/saber/gsi

I have been looking over examples in SABER and trying ot understand your prototype change. I think it would be better if we could get the part of your change that lives in the saber namespace into saber itself, similar to the way this is done for NOAAs GSI. They package their covariance fortran routines as a library and then interface to them as part of saber if the library is found:
Here is the switch they use: https://github.com/JCSDA-internal/saber/blob/48c0f95b83a946277d8c7bcd7c95af898f0d8da3/CMakeLists.txt#L75
and the GSI stuff is here: https://github.com/JCSDA-internal/saber/tree/develop/src/saber/gsi

That's useful I guess they've pioneered a way to get my NEMOVAR interface into SABER. Although NEMOVAR does it's own geometry setup and so a user would need to some extra work to use a non-standard grid. Perhaps GSI is more generic and can use the altas geometry data directly which may aid in its SABER acceptability.
I'm giving a DA science meeting talk next week (3 Dec at 11am) about my JEDI work and I'll make a point to raise the question about where to put the interface code.

@frld sounds good to me! My reasoning that this belongs in SABER is really from a few different directions:

SABER users of other models might be surpised to learn that SABER is changed by the inclusion of this model interface - this could have unintended consequences for them.
Compiling functions in the SABER namespace without being in the SABER repo represents poor separation of concerns - it makes the code harder to understand as the capabilities are not isolated to SABER. e.g what if someone develops a new and better NEMO model interaface and wishes to use the SABER interface to nemovar? If it is in SABER it is just a configuration, if it is in orca-jedi then they  would need to copy code across to the new model interface. This introduces a much higher maintainance burden and multiple versions of the same thing.
Most importantly, adding the nemovar ABI to SABER has the benefit that any change to SABER that might affect NEMOVAR would be naturally visible to the SABER developer making the change. This increases the liklihood of them maintaining the interface as SABER changes and keeping it working, or at least flagging issues of compatibility early.

I've opened an issue on the SABER repo https://github.com/JCSDA-internal/saber/issues/980


Destroyed app leaks config, logs, etc. into a re-created app with the same name

I earlier created a Hubot app on my deis cluster (v1.12.1) named b9. I started randomly getting 404s for every command I tried to run against it (deis apps:logs, deis ps, etc.) so I decided to try destroying it and re-creating it. For some reason, I had run deisctl ssh router and fleetctl destroy its Procfile process before I could attempt to destroy it. It wasn't listed in deis apps:list despite having an entry in the PostgreSQL database's api_app table.
After destroying the application, I re-created it and set to reconfiguring. After attempting to set the third configuration value, I noticed something odd:
% deis config:set HUBOT_SLACK_TOKEN=...
Creating config... done, v10

=== b9 Config
...

That v10 appeared despite not having run any sort of git push yet. And there were only two config options set before. Additionally, HUBOT_SLACK_TOKEN didn't end up getting set. I tried setting it again and that time it worked as expected. When I finally ran git push deis master, it informed me that it had launched v5 of my app. Running deis apps:logs then, sure enough, showed log entries from my old application.
My app appears to be totally hosed and I have no idea how to recover. Destroying it seems to leave unwanted pieces of state and then the re-created app behaves strangely.

I started randomly getting 404s for every command I tried to run against it (deis apps:logs, deis ps, etc.)

If this was happening, you can't trust anything you did after that point.  So the proximate cause of that symptom is what we need to get to the bottom of.
I've seen this happen just once before and it was on another guy's laptop at a conference.  We parted ways before getting to the bottom of it, but my theory is that the database may have been flapping.  If it were, it would explain the 404s at the start of your narrative as well as the surprising presence of old configuration towards the end of it.  Whether you're talking about adding a new record or deleting an old one, if the database isn't up long enough for recent changes to have been backed up, then when it restarts the state that is in the database will not match reality.
This is just a theory, but if you have any logs from the database at around the time this occurred they may be enlightening.  I have a strong suspicion that is was experiencing some problems that led directly to what you reported.

Unfortunately, time was running out for me and I had to re-build my cluster to get my apps back up and running. I couldn't afford to keep the old servers around and pay for them but I realized later that I hadn't saved any logs. So far the new cluster has been running just fine but I'll report back if anything like this happens again. Sorry!

This is not something we'll be able to get to for the LTS release (#4776). If you happen to reproduce please let us know. Thanks!


cover commands start and help with unit tests

Signed-off-by: sklump<EMAIL_ADDRESS>

Codecov Report

Merging #658 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
+ Coverage   98.70%   98.75%   +0.05%
==========================================
  Files         250      250
  Lines       13389    13392       +3
==========================================
+ Hits        13215    13225      +10
+ Misses        174      167       -7


Touch screen?

Hi, does Roendi have a touch recognition capability? It's not clear based on the description on Crowd Supply.

@kubsztal Hi there :) It does not have touch recognition. But when I design it I left enough space for touch screen or glass cover. There is also a way of routing wires from the inside to the outside and a free I2C bus. It is up to the user to extend the capabilities or not. Hope this help. If there there more questions please ask! Stay healthy stay happy!


Multi-PC mode is not deactivated after activating service mode between W10 and W11 PCs

Microsoft PowerToys version
0.75.1
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
Mouse Without Borders
Steps to reproduce
I ran the service mode between my desktop PC (W10) and Laptop (W11), before I could move the mouse from my PC to the laptop and even use the multi-computer mode at the same time, now after activating the service mode only the laptop could control the desktop PC and the multi-computer mode always remained active on the laptop even if I deactivated it. I deactivated the service mode and the error persisted, uninstalled the program (with revo unistaller) on both sides and reinstalled them but the error remained.
PowerToysReport_2023-12-03-17-06-47.zip
✔ Expected Behavior
That the program would continue to function normally or better.
❌ Actual Behavior
created a bug in which the multi-computer mode was not deactivated and could only be controlled from one PC.created a bug in which the multi-computer mode was not deactivated and could only be controlled from one PC.
Other Software
No response

Are you still experiencing this issue? /needinfo


Backport "HBASE-28568 Incremental backup set does not correctly shrink (#5876)" to branch-2

The incremental backup set is the set of tables included when an incremental backup is created, it is managed per backup root dir and contains all tables that are present in at least one backup (in that root dir).
The incremental backup set can only shrink when backups are deleted. However, the implementation was incorrect, causing this set to never be able to shrink.
Reviewed-by: Ray Mattingly<EMAIL_ADDRESS>

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 40s
branch-2 passed

+1 :green_heart:
compile
0m 15s
branch-2 passed

+1 :green_heart:
shadedjars
5m 15s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 14s
branch-2 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
2m 15s
root in the patch failed.

-1 :x:
compile
0m 15s
hbase-backup in the patch failed.

-0 :warning:
javac
0m 15s
hbase-backup in the patch failed.

+1 :green_heart:
shadedjars
5m 18s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 11s
the patch passed

_ Other Tests _

-1 :x:
unit
0m 14s
hbase-backup in the patch failed.

18m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5915

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5ef2f4b7349c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3165e385a4

Default Java
Temurin-1.8.0_352-b08

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/1/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-backup.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-backup.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-backup.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/1/testReport/

Max. process+thread count
67 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 51s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 10s
branch-2 passed

+1 :green_heart:
compile
0m 37s
branch-2 passed

+1 :green_heart:
checkstyle
0m 12s
branch-2 passed

+1 :green_heart:
spotless
0m 48s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 33s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 12s
the patch passed

+1 :green_heart:
compile
0m 33s
the patch passed

+1 :green_heart:
javac
0m 33s
hbase-backup generated 0 new + 104 unchanged - 2 fixed = 104 total (was 106)

-0 :warning:
checkstyle
0m 10s
hbase-backup: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
hadoopcheck
2m 32s
The patch causes 14 errors with Hadoop v2.10.2.

-1 :x:
spotless
0m 44s
patch has 21 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
0m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

22m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5915

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux f2c0786de4bf 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3165e385a4

Default Java
Eclipse Adoptium-11.0.17+8

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-backup.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/1/artifact/yetus-general-check/output/patch-javac-2.10.2.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
80 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 30s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 30s
branch-2 passed

+1 :green_heart:
compile
0m 29s
branch-2 passed

+1 :green_heart:
shadedjars
7m  4s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 19s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 36s
the patch passed

+1 :green_heart:
compile
0m 20s
the patch passed

+1 :green_heart:
javac
0m 20s
the patch passed

+1 :green_heart:
shadedjars
6m  3s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 13s
hbase-backup generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
12m 42s
hbase-backup in the patch passed.

37m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5915

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e69b7e2a4e92 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3165e385a4

Default Java
Eclipse Adoptium-11.0.17+8

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-backup.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/1/testReport/

Max. process+thread count
3177 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 31s
branch-2 passed

+1 :green_heart:
compile
0m 16s
branch-2 passed

+1 :green_heart:
shadedjars
4m 48s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 15s
branch-2 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
2m 21s
root in the patch failed.

-1 :x:
compile
0m 17s
hbase-backup in the patch failed.

-0 :warning:
javac
0m 17s
hbase-backup in the patch failed.

+1 :green_heart:
shadedjars
4m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 13s
the patch passed

_ Other Tests _

-1 :x:
unit
0m 17s
hbase-backup in the patch failed.

17m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5915

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 63ddac606859 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3165e385a4

Default Java
Temurin-1.8.0_352-b08

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/2/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/2/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-backup.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/2/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-backup.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-backup.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/2/testReport/

Max. process+thread count
65 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 51s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 58s
branch-2 passed

+1 :green_heart:
compile
0m 39s
branch-2 passed

+1 :green_heart:
checkstyle
0m 13s
branch-2 passed

+1 :green_heart:
spotless
0m 57s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 36s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 33s
the patch passed

+1 :green_heart:
compile
0m 31s
the patch passed

+1 :green_heart:
javac
0m 31s
hbase-backup generated 0 new + 104 unchanged - 2 fixed = 104 total (was 106)

+1 :green_heart:
checkstyle
0m 10s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
hadoopcheck
2m 18s
The patch causes 14 errors with Hadoop v2.10.2.

+1 :green_heart:
spotless
0m 49s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

22m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5915

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 5dfab760a87b 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3165e385a4

Default Java
Eclipse Adoptium-11.0.17+8

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/2/artifact/yetus-general-check/output/patch-javac-2.10.2.txt

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 43s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m  4s
branch-2 passed

+1 :green_heart:
compile
0m 16s
branch-2 passed

+1 :green_heart:
shadedjars
5m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 15s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 46s
the patch passed

+1 :green_heart:
compile
0m 17s
the patch passed

+1 :green_heart:
javac
0m 17s
the patch passed

+1 :green_heart:
shadedjars
5m 49s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 13s
hbase-backup generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
10m 50s
hbase-backup in the patch passed.

30m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5915

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5fb92fd4a62f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3165e385a4

Default Java
Eclipse Adoptium-11.0.17+8

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-backup.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/2/testReport/

Max. process+thread count
3823 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 58s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m  0s
branch-2 passed

+1 :green_heart:
compile
0m 37s
branch-2 passed

+1 :green_heart:
checkstyle
0m 12s
branch-2 passed

+1 :green_heart:
spotless
0m 54s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 38s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 13s
the patch passed

+1 :green_heart:
compile
0m 28s
the patch passed

+1 :green_heart:
javac
0m 28s
hbase-backup generated 0 new + 104 unchanged - 2 fixed = 104 total (was 106)

+1 :green_heart:
checkstyle
0m 11s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 23s
Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6.

+1 :green_heart:
spotless
1m  1s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 56s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

26m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5915

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 249ad14c30c4 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / fcaffb82b1

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
75 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 17s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m  6s
branch-2 passed

+1 :green_heart:
compile
0m 19s
branch-2 passed

+1 :green_heart:
shadedjars
5m 27s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 17s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 46s
the patch passed

+1 :green_heart:
compile
0m 18s
the patch passed

+1 :green_heart:
javac
0m 18s
the patch passed

+1 :green_heart:
shadedjars
5m 21s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 15s
hbase-backup generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
10m 52s
hbase-backup in the patch passed.

29m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5915

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux aef665e3ff0b 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / fcaffb82b1

Default Java
Eclipse Adoptium-11.0.17+8

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-backup.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/testReport/

Max. process+thread count
3127 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 59s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 44s
branch-2 passed

+1 :green_heart:
compile
0m 17s
branch-2 passed

+1 :green_heart:
shadedjars
6m 18s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 15s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 55s
the patch passed

+1 :green_heart:
compile
0m 17s
the patch passed

+1 :green_heart:
javac
0m 17s
the patch passed

+1 :green_heart:
shadedjars
5m 26s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
11m 54s
hbase-backup in the patch passed.

33m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5915

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 145b62c6e4d6 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / fcaffb82b1

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/testReport/

Max. process+thread count
3455 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Update contributors.js

This has some merge conflicts. Please review the /data/contributors.js. And also please don't add you data in contributors.unshift. And make a New PR or resolve this with a new commit

Good job @Shantanu788
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow this steps.
Note that this repo is excluded from Hacktoberfest but this PR is still eligible for ClueLess Swags.

Star this repository. ⭐

SignIn / SignUp in [ClueLess Website](https://www.clueless.tech/) .

Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.


fix: typos in error message wrapping

Fixes https://github.com/cert-manager/approver-policy/issues/301
/cc @wallrj

/retest

in case you also want to fix the con variable name

Thanks! Good catch. Done.

/retest
/unhold


cherry-pick fix single compaction test p2

Proposed changes
pick from master #34568
pick from master #36881
Issue Number: close #xxx

run buildall


mgmt, upgrade codegen to 4.0.55

low-level-client option is renamed to data-plane. Will update wiki for DPG after merge.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

/check-enforcer override

API change check for com.azure:azure-messaging-webpubsub
API changes are not detected in this pull request for com.azure:azure-messaging-webpubsub

API change check for com.azure:azure-ai-documenttranslator
API changes are not detected in this pull request for com.azure:azure-ai-documenttranslator

API change check for com.azure:azure-iot-deviceupdate
API changes are not detected in this pull request for com.azure:azure-iot-deviceupdate

API change check for com.azure:azure-security-confidentialledger
API changes are not detected in this pull request for com.azure:azure-security-confidentialledger

API change check for com.azure:azure-analytics-purview-administration
API changes are not detected in this pull request for com.azure:azure-analytics-purview-administration

API change check for com.azure:azure-verticals-agrifood-farming
API changes are not detected in this pull request for com.azure:azure-verticals-agrifood-farming

API change check for com.azure:azure-analytics-purview-catalog
API changes are not detected in this pull request for com.azure:azure-analytics-purview-catalog

API change check for com.azure:azure-analytics-purview-scanning
API changes are not detected in this pull request for com.azure:azure-analytics-purview-scanning


dify support

And, you don't need to implement other llms.

Hi, @iamsk,
Thanks for helping to implement DifyVision API in VLMEvalKit. Some further steps are required to be accomplished before merging:

I cannot find any information about DifyVision on the Internet, a modelcard that introduce the API model is required.
Since we do not own a key of DifyVision, please share us a key (with small amounts of quota) for verification.
The content of the PR should be modified: demo.py should be removed from the PR.
Please follow the development guide (https://github.com/open-compass/VLMEvalKit/blob/main/Development.md) last section to format your code.

Hi, @iamsk ,
Is there any updates? Just a kind reminder.

Close the PR since there is no response during a long time.


Pretrained FastQA gives KeyError: 'model'

I tried using pretrained FastQA as described in the README, but hit this error:
$ python3 ./fastqa_test.py
Traceback (most recent call last):
  File "./fastqa_test.py", line 4, in <module>
    fastqa_reader = readers.reader_from_file("./fastqa_reader")
  File "/Users/minttu/src/python/nlp/project/jack/jack/readers/implementations.py", line 46, in reader_from_file
    reader = readers[shared_resources.config["model"]](shared_resources)
KeyError: 'model'

when running the example use case:
from jack import readers
from jack.core import QASetting

fastqa_reader = readers.reader_from_file("./fastqa_reader")

support = """"It is a replica of the grotto at Lourdes,
France where the Virgin Mary reputedly appeared to Saint Bernadette Soubirous in 1858.
At the end of the main drive (and in a direct line that connects through 3 statues and the Gold Dome),
is a simple, modern stone statue of Mary."""

answers = fastqa_reader([QASetting(
    question="To whom did the Virgin Mary allegedly appear in 1858 in Lourdes France?",
    support=[support]
)])

Was there a change in the name of the 'model' configuration parameter?

this is a bug in the README while unzipping the model. Sorry for that. Please run the following to fix this issue:
rm -r fastqa_reader
unzip fastqa.zip && mv fastqa fastqa_reader

Thank you, that fixed it.


Initial Envoy TLS support

Support TLS termination and origination in the cilium host proxy.
Current implementation embeds secrets as inline strings to (new) K8sSecret.Name field.
Testing is currently limited to Envoy integration testing and a Cilium bash test reaching out to an external web site.
TODO:

[x] Fetch and maintain k8s secrets
[ ] Add HTTP header matching support for a value derived from a K8sSecret
[ ] Redact log messages containing secret values

This change is

test-me-please

test-me-please

Superceded by #9486


currentTime & hh:mm:ss

If I decide to also show the "hh" output of the currentTime, it starts with 1 hour, even though I am starting from the start of the video.

Confirmed, I will fix this ASAP.
Thanks

It was a problem with timezones.
Just update your view with a '+0000' timezone and that's all:
<vg-time-display>{{ currentTime | date:'HH:mm:ss':'+0000' }}</vg-time-display>

ah cool, thanks!

@2fdevs doesn't work for me :(

@ptgamr could you post an example?
I'm testing in Angular 1.4.1 and it worked. Maybe it's a new feature in Angular 1.4.X.


HAWQ-1226. HAWQ core dump due to enable ranger while RPS is down

lnclude:
1. fix core dump while RPS not running
2. fix libcurl write_callback() problem
3. add libcurl timeout (hard-coded 30s temporarily)
4. fix some compile warnings
5. fix make install error: add json.h to checkinc.py
And old PR discuss: https://github.com/apache/incubator-hawq/pull/1058

@linwen @stanlyxiang @zhangh43 help to review again, thanks.

+1

+1

+1


Can't seem to add api routes

Can't seem to add custom api routes in the src/server.js file. Every request seems to be intercepted by the React Router at this level.

A very valid question, thanks. On which line are you now defining your new API route? You should put it above the static folder "catch all" route. Another adjustment that would help is to detect API routes in onPreResponse and reply.continue() instead of firing up React Router.

Got it, ok, i was able to get it running by putting my route above the catch all, and using a /api/{params} slug. I didn't think of trying to intercept with "onPreResponse".
You might want to add in some documentation for others who are tying to do a similar thing.
Thanks for the quick reply, great generator, i've already passed it along to some friends.

You should put it above the static folder "catch all" route.

One question: why is the sample route for the github request below the catch all route instead of above?


Two routes page render at same time

My folder structure looks like this
- routes
    - (auth).tsx
    - (auth)
        - login.tsx
    - [...404].tsx

When i remove (auth).tsx from routes now when i visit /login  it render both 404 page and login page.
And <HttpStatusCode code={404} /> folder will  throw error
TypeError: Cannot read properties of null (reading 'nextSibling')

I can confirm this happens for me too when navigating from the dynamic route /tool/[slug] to the index route /.
Sometimes it also renders the dynamic route twice below the index route.
https://user-images.githubusercontent.com/6840287/205135449-2941ff11-b70d-4c44-a36a-710b00448b01.mp4

Might be caused by a hydration issue triggering the rest. Reproduction would be good thanks.

Might be caused by a hydration issue triggering the rest. Reproduction would be good thanks.

Thanks, Ryan! The reproduction can be found in the mentioned issue #502.

In setting up for SolidStarts next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed in mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See https://github.com/solidjs/solid-start/pull/1139 for more details.


yarn create eth-app my-compound-app --template compound  has failed

Error: Couldn't find package "<EMAIL_ADDRESS>required by "<EMAIL_ADDRESS>on the "npm" registry.
at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
at PackageRequest. (/usr/local/lib/node_modules/yarn/lib/cli.js:36582:17)
at Generator.throw ()
at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
at /usr/local/lib/node_modules/yarn/lib/cli.js:323:13
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:95:5)
Error: Couldn't find package "<EMAIL_ADDRESS>required by "<EMAIL_ADDRESS>on the "npm" registry.
at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
at PackageRequest. (/usr/local/lib/node_modules/yarn/lib/cli.js:36582:17)
at Generator.throw ()
at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
at /usr/local/lib/node_modules/yarn/lib/cli.js:323:13
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:95:5)
at runNextTicks (internal/process/task_queues.js:64:3)
at listOnTimeout (internal/timers.js:526:9)
Error: Couldn't find package "<EMAIL_ADDRESS>required by "<EMAIL_ADDRESS>on the "npm" registry.
at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
at PackageRequest. (/usr/local/lib/node_modules/yarn/lib/cli.js:36582:17)
at Generator.throw ()
at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
at /usr/local/lib/node_modules/yarn/lib/cli.js:323:13
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:95:5)
at runNextTicks (internal/process/task_queues.js:64:3)
at listOnTimeout (internal/timers.js:526:9)
Error: Couldn't find package "<EMAIL_ADDRESS>required by "<EMAIL_ADDRESS>on the "npm" registry.
at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
at PackageRequest. (/usr/local/lib/node_modules/yarn/lib/cli.js:36582:17)
at Generator.throw ()
at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
at /usr/local/lib/node_modules/yarn/lib/cli.js:323:13
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:95:5)
at runNextTicks (internal/process/task_queues.js:64:3)
at listOnTimeout (internal/timers.js:526:9)
Error: Couldn't find package "<EMAIL_ADDRESS>required by "<EMAIL_ADDRESS>on the "npm" registry.
at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
at PackageRequest. (/usr/local/lib/node_modules/yarn/lib/cli.js:36582:17)
at Generator.throw ()
at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
at /usr/local/lib/node_modules/yarn/lib/cli.js:323:13
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:95:5)
at runNextTicks (internal/process/task_queues.js:64:3)
at listOnTimeout (internal/timers.js:526:9)
Error: Couldn't find package "<EMAIL_ADDRESS>required by "<EMAIL_ADDRESS>on the "npm" registry.
at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
at PackageRequest. (/usr/local/lib/node_modules/yarn/lib/cli.js:36582:17)
at Generator.throw ()
at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
at /usr/local/lib/node_modules/yarn/lib/cli.js:323:13
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:95:5)
at runNextTicks (internal/process/task_queues.js:64:3)
at listOnTimeout (internal/timers.js:526:9)
Error: Couldn't find package "<EMAIL_ADDRESS>required by "<EMAIL_ADDRESS>on the "npm" registry.
at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
at PackageRequest. (/usr/local/lib/node_modules/yarn/lib/cli.js:36582:17)
at Generator.throw ()
at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
at /usr/local/lib/node_modules/yarn/lib/cli.js:323:13
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:95:5)
Error: Couldn't find package "<EMAIL_ADDRESS>required by "<EMAIL_ADDRESS>on the "npm" registry.
at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
at PackageRequest. (/usr/local/lib/node_modules/yarn/lib/cli.js:36582:17)
at Generator.throw ()
at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
at /usr/local/lib/node_modules/yarn/lib/cli.js:323:13
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:95:5)
Error: Couldn't find package "<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>on the "npm" registry.
at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
at PackageRequest. (/usr/local/lib/node_modules/yarn/lib/cli.js:36582:17)
at Generator.throw ()
at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
at /usr/local/lib/node_modules/yarn/lib/cli.js:323:13
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:95:5)
Error: Couldn't find package "<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>on the "npm" registry.
at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
at PackageRequest. (/usr/local/lib/node_modules/yarn/lib/cli.js:36582:17)
at Generator.throw ()
at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
at /usr/local/lib/node_modules/yarn/lib/cli.js:323:13
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:95:5)
Error: Couldn't find package "<EMAIL_ADDRESS>required by "<EMAIL_ADDRESS>on the "npm" registry.
at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
at PackageRequest. (/usr/local/lib/node_modules/yarn/lib/cli.js:36582:17)
at Generator.throw ()
at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
at /usr/local/lib/node_modules/yarn/lib/cli.js:323:13
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:95:5)
Aborting installation.
yarnpkg install --cwd /Users/san/Learn/dapp-frontend/my-compound-app has failed.
error Command failed.
Exit code: 1
Command: /usr/local/bin/create-eth-app
Arguments: my-compound-app --template compound
Directory: /Users/san/Learn/dapp-frontend
Output:
info Visit https://yarnpkg.com/en/docs/cli/create for documentation about this command.

Hi @Sanbingo! Running yarn create my-compound-app --template compound worked for me.
At any rate, it's become increasingly difficult for me to maintain the DeFi templates. I recommend using the default template (so not passing --template compound) and manually importing the contracts by following the instructions on compound.finance/docs.

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

@Sanbingo I'm sorry, but I don't speak Mandarin.

@Sanbingo I'm sorry, but I don't speak Mandarin.

Sorry, This is an automatic email response. I have solved the problem, Thank you anyway！


Enhancment: add note on containers vs layouts vs views

It might be beneficial to add a brief note to Readme on differences & what goes into what folder regarding containers, layouts & views.

Good idea, I'll try to get to it this week. спасибо!

Bump--I'm finding myself just removing the containers and layouts folder and putting everything in the component folder. I might use the other folders, but I can't find an explanation of their purpose anywhere.

There isn't really an "official" explanation for them, they're just something that I use in personal projects and kept in the starter kit. I will add some documentation in the README when I get a chance, but I don't at all expect people to conform to the structure if it doesn't make sense for their projects.
I'll update this issue once the documentation is added, and maybe you both will have some thoughts on it.

Hopefully this provides some explanation: https://github.com/davezuko/react-redux-starter-kit#structure
Closing for now, let me know if you think this requires further documentation.

Great, thanks!

@davezuko
When I go through other boilerplates and react redux tutorials, the containers folder are storing smart components in general, while in this boilerplate, it seems there are 2 folders that play the role as smart components, the containers and the views folder.  Therefore in building an app based off this boilerplate, user should just leave the containers folder alone and instead make the smart component inside views folder.
Am I correct assuming this?

I generally have my Navigation as a layout of its own though and do something like this in my routes:
  <Route path='/' component={CoreLayout}>
    <Route component={NavLayout}>
      <IndexRoute component={HomeView} />
      <Route path='/about' component={AboutView} />
... close routes

hope that helps!

@SpencerCDixon thanks for the comment! What if SubmitEmail is a component that needs to be able to live anywhere on the app? That means I should make a container for SubmitEmail and just let it communicate directly to redux, am I correct?
Also, if I want to make my app with this approach, that means views folder is just for positioning the smart components only.  What do you think the downside of this approach?

My views folder ends up containing most of my actual 'containers' in the traditional redux sense.  And yeah if you have a component that needs to be able to be in many places and you don't want to always have to pass down a CB down potentially many levels then putting SubmitEmail in a containers as well is a great approach

I see, thanks for the answer! I think it is best to do the traditional redux sense like you described! Thanks!

@christiansakai I thought the "View" folder is a one to one mapping with your routing setting. It's like a entry point for any of your "page".  After seeing this repo, the HomeView is being connected to redux, thats why I'm a little bit confused

@christiansakai it's just a matter of semantics, really. Yes, a view is really technically a container, but to me it doesn't make sense to put all my components that are designed to live at a route in containers. I tend to, as @SpencerCDixon pointed out, use containers for any other smart components that aren't responsible for a route. Smaller apps may not have many of these as the views can handle most of the logic, but as your app grows so will containers.

@davezuko ah, I see. totally makes sense now! thank you

@SpencerCDixon would you mind sharing your code on CoreLayout and NavLayout?

import 'styles/global.stuff';

// Note: Stateless/function components *will not* hot reload!
// react-transform *only* works on component classes.
//
// Since layouts rarely change, they are a good place to
// leverage React's new Statelesss Functions:
// https://facebook.github.io/react/docs/reusable-components.html#stateless-functions
//
// CoreLayout is a pure function of it's props, so we can
// define it with a plain javascript function...
const propTypes = {
  children: React.PropTypes.element
};

function CoreLayout ({ children }) {
  return (

        {children}

  );
}

CoreLayout.propTypes = propTypes;
export default CoreLayout;

import React, { Component, PropTypes } from 'react';
import { Navbar, NavItem, Nav } from 'react-bootstrap';
import { connect } from 'react-redux';
import { LinkContainer } from 'react-router-bootstrap';
import ReactCSSTransitionGroup from 'react-addons-css-transition-group';

import { navRoutes } from 'routes/index';
import { actions as authActions } from 'redux/modules/auth';
import { fetchLeadSourceTypes } from 'redux/modules/leadSourceTypes';
import NotificationContainer from 'containers/NotificationContainer';
import LogoSpinner from 'components/LogoSpinner';
import Icon from 'components/Icon';

const propTypes = {
  children: PropTypes.element,
  dispatch: PropTypes.func.isRequired,
  isAuthenticated: PropTypes.bool.isRequired,
  globalFetch: PropTypes.bool.isRequired
};

class NavLayout extends Component {
  componentWillMount() {
    // this will need to be moved if I ever have routes without nav
    this.props.dispatch(authActions.initAuth());
    this.props.dispatch(fetchLeadSourceTypes());
  }

  renderLinks(type) {
    let links = [];

    navRoutes[type].map((route, i) => {
      let icon;
      if (route.fa) {
        icon = <Icon is={route.fa} />;
      }

      links.push(
        <LinkContainer key={i} to={route.to}>
          <NavItem eventKey={route.to}>
            {icon}
            {route.msg}
          </NavItem>
        </LinkContainer>
      );
    });
    return links;
  }

  renderSignOut() {
    const { dispatch } = this.props;
    return (
      <NavItem
        key='signout'
        eventKey='signout'
        onClick={() => dispatch(authActions.signOut())}
      >
        <Icon is='sign-out' />
        Sign Out
      </NavItem>
    );
  }

  render() {
    const { children, isAuthenticated, globalFetch } = this.props;
    const rightLinks = isAuthenticated
      ? this.renderLinks('authenticated') : this.renderLinks('notAuthenticated');

    return (

        <ReactCSSTransitionGroup transitionName='example' transitionEnterTimeout={500} transitionLeaveTimeout={300}>
          {globalFetch && <LogoSpinner color='white' />}
        </ReactCSSTransitionGroup>
        <Navbar inverse fluid className='site-nav'>
          <Navbar.Header>
            <Navbar.Brand>
              <LinkContainer to='/'>
                Kira
              </LinkContainer>
            </Navbar.Brand>
            <Navbar.Toggle />
          </Navbar.Header>
          <Navbar.Collapse>

              {this.renderLinks('shared')}

              {rightLinks}
              {isAuthenticated && this.renderSignOut()}

          </Navbar.Collapse>
        </Navbar>
        <NotificationContainer />

        {children}

    );
  }
}

function mapStateToProps(state) {
  return {
    isAuthenticated: state.auth.isAuthenticated,
    globalFetch:
      state.auth.isFetching ||
      state.user.isFetching ||
      state.leadSource.isFetching ||
      state.touches.isFetching ||
      state.leads.isFetching
  };
}

NavLayout.propTypes = propTypes;
export default connect(mapStateToProps)(NavLayout);

@SpencerCDixon thanks! really appreciate it! I like the way you put initAuth in Navigation!

Yeah, havn't looked at this in a while but looking at it now I think I'm actually going to refactor it to dispatch an action that just does all site-wide initialization and I'll make that action a thunk that dispatches all pieces of the app that need to dispatch something on page load if that makes sense

yeah that totally makes sense! I'll try this first and refactor later


Building for C++11 fails due to naming conflict of bind in rtpudpv4transmitter.cpp

Building the library for C++11 on macOS (Apple Clang) fails due to a naming conflict in RTPUDPv4Transmitter, which declares "using namespace std;" which changes the meaning of all bind calls from a socket-bind to a functional-bind. This then fails to compile as the arguments do not match. Removing the using namespace and declaring std:: explicitly where needed fixes this, as does replacing the bind call with ::bind. Then the rest compiles nicely.

This should have been fixed a few weeks ago. Did you test this with the master branch? Or with 3.11.1?


Invalid HubHopType values cause processing errors/crash in mobiflight

Accented characters in some HubHop properties cause problems with Mobiflight. Here's a sample entry that will cause the problems:
  {
    "path": "Fly By Wire.A320.Aviônica.Entrada (Potenciômetro).cris",
    "vendor": "Fly By Wire",
    "aircraft": "A320",
    "system": "Aviônica",
    "code": "(>AS3000_TSC_Vertical_2_Joystick_Up)",
    "label": "AS3000_TSC_Vertical_2_Joystick_Range_Pan_Y_Up",
    "presetType": "Entrada (Potenciômetro)",
    "status": "Submitted",
    "createdDate": "2023-02-03T17:34:12.923Z",
    "author": "Lex Hegt",
    "description": "Garmin 3000 (Left MFD controller)",
    "version": 1,
    "id": "97722407-7411-4B84-9024-F3AD57D2A0A2"
  }

Here's what happens:

When the preset list is loaded in Msfs2020HubHopPresetList the JSON deserialization fails with this error: Error converting value "Entrada (Potenciômetro)" to type 'MobiFlight.HubHop.HubHopType'. This results in an empty Items list
When someone opens an Output or an Input config screen the Filtered() method attempts to filter the Items array which is null, and that causes an unhandled exception.

Simplest fix is to likely set Items to an empty array after parsing if there was an error.

This same issue can happen with HubHopAction, which is also a hardcoded enum of three possible values.

There's a way to skip bad records with JsonConvert. Adding that now.


Dataset and Degradation Model

Great work! Is there any plan releasing the DIV2k3D dataset or degradation model in the paper?
Tks!

Extended degradation model: https://github.com/cszn/BSRGAN/blob/f08c9fccad11bbe7669eb355a5f10ddf6aaff585/utils/utils_blindsr.py#L432

Hello! A couple of questions regarding the published degradation code. It is different from the one published in the paper, I noticed it doesn't have the aligned nearest neighbor interpolation option, it adds a second resizing inside the pipeline, has the "up, down, keep" random scale direction and there is no code for the unprocess ISP camera degradation, now there is speckle and Poisson noise instead, so it's pretty much the same as the Real-ESRGAN pipeline. Any particular reason for these changes? Any model performance issues? Also, in my understanding, the strategy in the paper with the degradation shuffling works to expand the degradation space to something similar to the repeated blur->resize->noise->jpeg model from Real-ESRGAN, but now the shuffling happens over the double degradation model, any comments about that change? How does shuffling the double pipeline change results?
I've added both BSRGAN and Real-ESRGAN (and Real-SR) training strategies in a project, by the way of configurable presets: https://github.com/victorca25/traiNNer/blob/master/codes/options/presets/README.md, but I was wondering if the options where changed for some reason in particular.
Also, in case it's interesting, I've converted the unprocess/process camera noise to be 100% in numpy, so there's no need for TensorFlow or converting between numpy and Torch tensors and also added the missing sinc blur option as augmentations in: https://github.com/victorca25/augmennt (unsharpening, speckle, Gaussian, jpeg and many other degradation are also there, just in case).

I will upload our original degradation model today. Real-ESRGAN follows our BSRGAN work. The idea of using double JPEG, double blur, down-up-resize, Gaussian noise for color image and grayscale image for SR degradation was first proposed in our work.

Yes, I know Real-ESRGAN uses the same ideas as BSRGAN, I mentioned it in my readme file: "very similar to BSRGAN, but adds sinc filter to the two blur operations, replaces the realistic camera noise for a simpler poisson noise augmentation and adds a second in-pipeline scaling operation."
But the degradation_bsrgan_plus() changes substantially from what was in the BSRGAN paper and is closer to the brute-force approach from Real-ESRGAN, duplicating the pipeline instead of shuffling the degradation, so I was wondering if there's a reason for that, if this replaces the original strategy or it's just an alternative.

For what is worth, I've been using unsharpening mask on HR images and double noise on-the-fly augmentations, besides blur and resizing for about 2 years in the pipeline my repo :D

I have uploaded the degradation_bsrgan().
The idea of BSRGAN was mainly inspired by my previous work SRMD, DPSR, IRCNN, USRNet, DnCNN, FFDNet and CBDNet.  For example, the degradation shuffle and double blur was inspired by SRMD, DPSR, IRCNN, USRNet which use different degradation orders for blur and resizing.
I do not use sharpening operation. Your work should be known by more people.  However, sharpening is not new for SR, and blur and resizing are the normal degradation operations for SR. The idea of using double blur and resizing would be novel.

As claimed in our paper, One can conveniently modify the degradation model by changing the degradation parameter settings and adding more reasonable degradation types to improve the practicability for a certain application.

There's the add_sharpening() function in the code, that's why I mentioned it and I don't see it commonly used in any online pipeline strategy, only in some very rare cases as offline data preparation. Also the double noise was not standard before I added it a while back. Single blur and resizing, I agree is standard. Using the presets in my code you can do all these changes without changing the code, only configuring the augmentations that will be used and the parameters for each augmentation from a YAML.
Great to see the original pipeline, but now I have another question. If I remember correctly, a Gaussian blur of kernel size 21 was mentioned in the paper for the aligned nearest neighbor, but in the code the kernel size is 25. Is this a typo?
I have tried in my code with sizes from 17 to 21 and in most cases it produces the almost the same aligned results using the same sigma values, but I didn't test up to 25.
And then my main doubt is still there, is there any performance comparison between using degradation_bsrgan_plus() and the original degradation_bsrgan() or it's yet to be done?

There is no difference between kernels with size 25 and size 21 because their boarder elements are almost zero.
I have not compare yet. In my opinion, the results would be similar for most of the real images if you use the same training strategy and same training data.

Awesome! Thanks for clarifying my questions!
One additional comment, I don't know if you had seen this work before, but it uses SRMD and USRNet (among others) for benchmarking and the results are pretty interesting: https://openaccess.thecvf.com/content/CVPR2021/papers/Jo_Tackling_the_Ill-Posedness_of_Super-Resolution_Through_Adaptive_Target_Generation_CVPR_2021_paper.pdf
The name is a bit misleading, as in the actual model training it modifies the model output (not the target images), but in my tests it helps even in cases using complex pipelines like BSRGAN, results are even sharper.
It's very simple to integrate, I'll be committing it to my code soon so more people can test it and compare results, but it may give you some more ideas too.
Cheers!

I have not read this CVPR2021 paper yet since our work was also previously submitted to CVPR2021.
Thanks for your hard work.

Awesome! Thanks for clarifying my questions!
One additional comment, I don't know if you had seen this work before, but it uses SRMD and USRNet (among others) for benchmarking and the results are pretty interesting: https://openaccess.thecvf.com/content/CVPR2021/papers/Jo_Tackling_the_Ill-Posedness_of_Super-Resolution_Through_Adaptive_Target_Generation_CVPR_2021_paper.pdf
The name is a bit misleading, as in the actual model training it modifies the model output (not the target images), but in my tests it helps even in cases using complex pipelines like BSRGAN, results are even sharper.
It's very simple to integrate, I'll be committing it to my code soon so more people can test it and compare results, but it may give you some more ideas too.
Cheers!

Hello victorca
May I know did your experiment use the ISP model?
Where can I get the ISP model?
Thanks.


Should PHPStan support reporting deprecated PHP code?

PHPStan is a static analyzer that reports bugs in code. A deprecation can be considered a bug that will occur in the future. Could PHPStan report deprecated PHP code?
Example:
PHP 8.3 deprecated ${var} string interpolation. It could be reported when running PHPStan in PHP 8.3 environment or with phpVersion: 80300. This way we can prepare our code now for the change that will be required in one or more years.

PHPStan core does this for selected errors. What matters is that the error can be detected from the AST. I'm not sure if this one can, feel free to test it.
You can open this with relevant information as a feature request in phpstan/phpstan (provided it's not a duplicate already).


iOS version prerequisite

Section 1 Prerequisites mentions:
"You are targeting devices running iOS 9.0 or later or Android 4.0.3 (API level 15) or later".
In my info.plist my Deployment Target is 9.0.
Yet when I add the 1.5.0 AppCenter packages I am getting the following errors:
"error MT5209 : Native linking error : warning: object file  was built for newer iOS version (10.1) than being linked (9.0)".
Is the 9.0 or later prerequisite still accurate?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5d72f6fe-74d6-696e-e709-5f6d577c0a58
Version Independent ID: b3d0ea8b-5a1f-bf71-7dc2-9685cf23c00b
Content: Get Started with Xamarin - Visual Studio App Center
Content Source: docs/sdk/getting-started/xamarin.md
Service: vs-appcenter
GitHub Login: @elamalani
Microsoft Alias: emalani

@gilles-leblanc App Center supports iOS 9 and later. If you see an error adding App Center NuGet, can you open a support ticket with us by clicking on the blue icon in the lower right of App Center portal? That way,  we can better help you investigate the issue.

I've found out that if I only add the AppCenter base package this does not happen.
I need to add the AppCenter.Crashes as well to get the errors.
I then tried adding only the AppCenter and AppCenter.Analytics package and it worked.
If I add the AppCenter.Crashes package again it starts failing again.
So I tested out all these combinations:

AppCenter = ok
AppCenter + AppCenter.Crashes = errors
AppCenter + AppCenter.Analytics = ok
AppCenter + AppCenter.Crashes + AppCenter.Analytics = errors

After looking more carefully at the errors I noticed something about Hockey in the logs (which I am also using).
So I removed the Hockey package for my iOS project and everything works.
My bad.
I also later saw that it mentioned not to use both at the same time in the documentation.


Deprecate "reset_index_inplace"

In an effort to move away from all "inplace" optimizations to futureproof pyjanitor, I propose deprecating the reset_index_inplace.
@zbarry  Thoughts? 😄 : 👴-> 💀

Kill it ded 👍


[Feature]: User-Installable apps support

Feature?
Hi there!
As of March 18th, user-installable apps are now available. I tried to find out if this library supports the new feature, but couldn't find anything relevant in the documentation or examples. Is this currently implemented? If not, are there any plans to add it?
Thanks!
Package
discordx

@Wondermarin sure, https://github.com/discordjs/discord.js/pull/10348 is in progress and yet to be merged by discordjs. Once they release it, will provide support instantly.
Thank you for letting me know about upcoming change to discordjs.

yes, I was aware. But they have not released it in stable release. And currently, we are not supporting development branch.

Was scratching my head over how I could get my app slash commands to work within private and group DMs upon user install. Hopefully, this workaround is good for now...
I follow the same steps of creating an invite link for a server but also check off for the user.
SlashCommandBuilder() from discord.js returns a JSON, so you can add the integration_types and contexts properties to it manually and then pass it into a data object for registration.
const command = new SlashCommandBuilder()
                        .setName("test")
                        .setDescription("send test 123")

command["integration_types"] = [0, 1];
command["contexts"] = [0, 1, 2];

{ data: command, async execute(interaction) await interaction.reply("Test 123") }

My private DM with another user

looking forward to official support though 👍

Let me know, once you guys test it.


Unable to make , due to undefined reference to cv?

I am getting this error while compiling caffe2. Please help me out here. Previously I have installed and used caffe and opencv successfully.
gen/caffe2/binaries/libconvert_encoded_to_raw_leveldb.a(convert_encoded_to_raw_leveldb.o): In function caffe2::ConvertToRawDataset(std::string const&, std::string const&)': convert_encoded_to_raw_leveldb.cc:(.text+0x47c): undefined reference to cv::imdecode(cv::_InputArray const&, int)'
collect2: error: ld returned 1 exit status

@n3011 It might be related to this. I had similar error, i edited the BREW files and opencv third party file .
And the error was fixed.
http://stackoverflow.com/questions/27890137/undefined-symbols-for-architecture-x86-64-for-caffe-build
I am still testing it, if it builds correctly but you need to add following library along with other opencv targets
cc_thirdparty_target(
name="opencv_imgcodecs",
srcs=["BREW"],
commands=[],
cc_obj_files=["-lopencv_imgcodecs"],
)

Thanks - let's discuss in the other issue #24 ? Closing this one.


Cannot resize below (20,20)

whether using hyprctl or mouse resizing, can't get lower than 20,20

intentional design - why would you want to?

Cause there's an app that's unable to close(cassowary related weirdness), and the current way to make it partially disappear, is by moving the window outside of the monitor. If it's possible to resize the window to (1,1), it's effectively impossible to see without doing weird stuff

I think it's such an edge case that I will not justify throwing an entire safety system for accidental oopsies away just to account for this. You can move it outside the monitor, as you've mentioned, so this is not needed.


Site name

Not really an "issue".
Keep as ChlamBase.org or change? Worthy of a discussion.. Most related portals seem to use ___base or ___db, so both ChlamBase or ChlamDB are appopriate. The chlamdb.org domain is also available. ChlamydiaBase and ChlamydiaDB are not as good – needlessly long. Any better ideas?

after letting this one percolate for nine months, going to close this issue.  We've used "chlambase" enough in posters, talks, and abstracts that I think it would tough to change at this point...


JSDoc '@this' not emitted in declaration file

Bug Report

🔎 Search Terms
this jsdoc declaration
🕗 Version & Regression Information

This behavior was present since v3.7 when declaration emit for JS was introduced. Therefore it never worked.

⏯ Playground Link

Playground Link: Provided
💻 Code
/** @this {string} */
export function firstCharOfThis() {
  return this.charAt(0);
}

🙁 Actual behavior
/** @this {string} */
export function firstCharOfThis(): string;

🙂 Expected behavior
/** @this {string} */
export function firstCharOfThis(this: string): string;

It's not only the 'this' tag but also all jsdoc.
The root cause is the conversion and emit behavior both of jsdoc in js and d.ts.
eg:
export class A {
  /**
   * @private
   */
  a = 1
}

It's not only the 'this' tag but also all jsdoc.
The root cause is the conversion and emit behavior both of jsdoc in js and d.ts.
eg:
export class A {
  /**
   * @private
   */
  a = 1
}

@Kingwl JSDoc access modifiers seem to be emitted correctly in DTS

@Kingwl JSDoc access modifiers seem to be emitted correctly in DTS