BaseModel.json() does not honor pydantic Config for property types

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
I expect class A to be serialized the same way by BaseModel.json() regardless of whether it is a nested property of a jsonified class or not.
Related issue, submitted to fastapi: tiangolo/fastapi#5689
I'm mostly curious whether you would consider this expected behavior, or a bug. I would have expected it to honor the Config on class A regardless of class B's config.
Example Code
from datetime import datetime

from pydantic import BaseModel, Field
from fastapi.encoders import jsonable_encoder

class A(BaseModel):
    class Config:
        json_encoders = {datetime: lambda t: round(t.timestamp())}

    date: datetime = Field(default_factory=datetime.now)

class B(BaseModel):
    a: A = Field(default_factory=A)

a = A()
b = B()

# a.dict() and b.dict() both serialize A the same way
print(a.dict())
print(b.dict())

# jsonable_encoder does not serialize A the same way.
print(a.json())
print(b.json())

Python, Pydantic & OS Version
pydantic version: 1.10.2
            pydantic compiled: True
                 install path: /Users/kent/Library/Caches/pypoetry/virtualenvs/api-v1-eSVyJk8S-py3.10/lib/python3.10/site-packages/pydantic
               python version: 3.10.6 (main, Aug 27 2022, 15:26:33) [Clang 13.1.6 (clang-13<IP_ADDRESS>.5)]
                     platform: macOS-12.5.1-arm64-arm-64bit
     optional deps. installed: ['dotenv', 'typing-extensions']

Affected Components

[X] Compatibility between releases
[ ] Data validation/parsing
[X] Data serialization - .dict() and .json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

I can confirm this behavior.
I have been hunting the reason for why  json_encoders had not been used for a while now.
I do not have the option to set the  json_encoders for the Root BaseModel, and if this cannot be forced, I would be forced to handle the conversion outside the pydantic, which will defeat the purpose.


More translog backports

Summary of the changes / Why this improves CrateDB
https://github.com/crate/crate/pull/11137/commits/afc2b14ca05424e58abad8b882171caae6f66b3f is already approved, i just didn't want to wait until it is merged into master.
Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

retest this please


fails to build for non-x86_64-linux platforms

# github.com/quarkslab/kdigger/pkg/plugins/syscalls
pkg/plugins/syscalls/syscalls.go:155:7: undefined: unix.SYS_SELECT
pkg/plugins/syscalls/syscalls.go:156:7: undefined: unix.SYS_PAUSE
pkg/plugins/syscalls/syscalls.go:163:7: undefined: unix.SYS_FORK
pkg/plugins/syscalls/syscalls.go:164:7: undefined: unix.SYS_VFORK
pkg/plugins/syscalls/syscalls.go:173:47: undefined: unix.SYS_SELECT
pkg/plugins/syscalls/syscalls.go:173:72: undefined: unix.SYS_PAUSE
pkg/plugins/syscalls/syscalls.go:183:40: undefined: unix.SYS_FORK
pkg/plugins/syscalls/syscalls.go:183:63: undefined: unix.SYS_VFORK
pkg/plugins/syscalls/syscalls.go:230:12: undefined: unix.SYS_OPEN
pkg/plugins/syscalls/syscalls.go:234:12: undefined: unix.SYS_STAT
pkg/plugins/syscalls/syscalls.go:234:12: too many errors
github.com/quarkslab/kdigger/pkg/plugins/authorization

on aarch64-linux and x86_64-darwin
are there plans for supporting non-x86_64-linux platforms in the future or no?

Yes, that's why I set the build to Linux x86. In fact, we could have a _linux or _darwin version to handle this (by just skipping the syscall scan on macOS) but I don't think it's really relevant to run kdigger on macOS (I work on macOS x86 myself).
Since you shouldn't be supposed to run kdigger on your host directly (in principle) but in pods on nodes that are running mostly Linux, I don't think it's really interesting. Maybe Linux arm64 would be of more interest. If you really need to run on macOS x86, I would be super interested to know why and could fix it! The only thing I can think of is to scan the admission control chain; maybe, this is one of the only remote features (along with version, authorization and apiresources, but they are easily replaceable with kubectl).

yeah your darwin point makes total sense, not sure what I was thinking :sweat_smile: yeah unless there are more external client -> cluster (kubectl style) features there's not much point in a darwin build
I could see aarch64-linux being handy for some workloads but yeah x86_64-linux is by far the most useful

I've updated the ticket to track (potential) aarch64-linux support

Hehehe 😃 thanks! I didn't know if anyone was interested in other architectures, but I'd be happy to implement it if anyone needs it!


refactor(IHL): use EOA to identify user for IHL (not MTW)

Description
Switches to EOA to identify users for IHL, rather than MTW. This allows us to use auth for IHL that is "more general" (aka the same that FiatConnect will use)
Other changes
na
Tested
automated tests pass
manual test passes (just went thru persona flow and made sure the link bank account steps page updated)
How others should test
na (behind feature flag)
Related issues

Fixes #2030

Backwards compatibility
na

Hey @MuckT  do we need to test the above PR as it is behind a feature flag, please let know us if we need to test it


Update README.md

Add proper README.md with gem description and usage instructions and examples

Done in https://github.com/ne006/expression_ast/pull/5


Allow instantiation of PublicKey from bech32/npub format

Make it easier to instantiate PublicKeys from bech32 formats.
Such as:
author_key = PublicKey.from_npub(
    "npub18gttxuztpr9afgwrkaqc8p0zdhz5c8cx07x3tqg9pp2qd69c5ufswy4j8f"
).hex()

print("Subscribing to %s" % author_key)
filters = Filters([Filter(authors=author_key, kinds=[EventKind.TEXT_NOTE])])

The relevant part of this PR (loading pubkey from bech32) and its testing LGTM but the rest (adding pox) is unrelated and should be separate PR and discussed independently IMO.


"helm fetch/pull" failing in Helm 3.2.0

I am trying to fetch a chart using the new Helm 3.2.0 version but I obtain the following error:
$ helm repo update
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "bitnami" chart repository
Update Complete. ⎈ Happy Helming!⎈

$ helm fetch bitnami/redis-cluster
Error: rename /tmp/redis-cluster-2.0.8.tgz770913527 redis-cluster-2.0.8.tgz: invalid cross-device link

the same issue happens using pull instead of fetch:
$ helm pull bitnami/redis-cluster
Error: rename /tmp/redis-cluster-2.0.8.tgz205065242 redis-cluster-2.0.8.tgz: invalid cross-device link

But, using the latest Helm 3.1.X, the command works as expected:
$ helm313 repo update
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "bitnami" chart repository
Update Complete. ⎈ Happy Helming!⎈

$ helm313 fetch bitnami/redis-cluster

$ ls | grep redis
redis-cluster-2.0.8.tgz

Output of helm version:
$ helm version
version.BuildInfo{Version:"v3.2.0", GitCommit:"e11b7ce3b12db2941e90399e874513fbd24bcb71", GitTreeState:"clean", GoVersion:"go1.13.10"}

Output of kubectl version:
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.9", GitCommit:"2e808b7cb054ee242b68e62455323aa783991f03", GitTreeState:"clean", BuildDate:"2020-01-18T23:33:14Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.11-gke.1", GitCommit:"aa93664bafe74f3c051e021b27a64e28ac34ab40", GitTreeState:"clean", BuildDate:"2020-03-18T22:49:35Z", GoVersion:"go1.12.17b4", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
GKE

Not 100% sure, but this PR can be related #7720

sounds like the same report in #2998, though in a different section of the code. Please feel free to submit a patch that fixes this. Have a look through #2998 for a more in-depth rundown of the issue.
RenameWithFallback is now part of the project, so this should be a really quick fix. Have a look at https://github.com/helm/helm/pull/6750 for an example.
Marking as a good first issue.

This should be fixed after https://github.com/helm/helm/pull/7954 is merged.


Parse Server & Parse Dashboard Security

Hi,
Our parse hosted mongo setup was hacked similar to bug https://github.com/ParsePlatform/parse-server/issues/3334
This hack  was a type of extortion. The entire db was deleted and following message was there in the error logs

insert PLEASE_READ.PLEASE_READ query: { _id: ObjectId('587026363592359314ee86fc'), Info: "Your DB is Backed up at our servers, to restore send 0.1 BTC to the Bitcoin Address then send an email with your server ip", Bitcoin Address: "1J5ADzFv1gx3fsUPUY1AWktuJ6DF9P6hiF", Email<EMAIL_ADDRESS>} ninserted:1 keyUpdates:0 writeConflicts:0 numYields:0 locks:{ Global: { acquireCount: { r: 2, w: 2 } }, MMAPV1Journal: { acquireCount: { w: 8 }, acquireWaitCount: { w: 2 }, timeAcquiringMicros: { w: 81 } }, Database: { acquireCount: { w: 1, W: 1 } }, Collection: { acquireCount: { W: 1 } }, Metadata: { acquireCount: { W: 4 } } } 447ms

This is a serious issue
Since then we have take following security actions on our hosted instance server

Running mongo on different port rather than default port.
Closing public port to access db.
Separate read/write credentials to parse application to use db.
binding mongodb to localhost only.

Is there anything else we can do to secure our mongo instance ?
The current parse setup runs with master key & api key.
If someone might get hold of it they can manipulate the db using parse Apis. Is there any way we can implement additional security to our hosted parse instance ?

I don't see any mention of auth or TLS in the actions you took. This is definitely something you should consider. Also, have a look at the blog post from Mongo on how to deal with this situation https://www.mongodb.com/blog/post/how-to-avoid-a-malicious-attack-that-ransoms-your-data

One thought I had about the data, maybe the hackers didn't drop the oplog? If it's the case, you might be able to get some data back. Have a look in local.oplog.rs...
Even if the oplog hasn't been cleared, it won't be easy to recover from it (it's pretty technical and I can't help with that) but at least it's something that might be useful...

thanks for share


Release 1.2.0

Codecov Report
Attention: Patch coverage is 76.92308% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 83.37%. Comparing base (6559f11) to head (b64a1c8).

Files
Patch %
Lines

lymph/models/midline.py
65.85%
14 Missing :warning:

lymph/models/unilateral.py
81.57%
7 Missing :warning:

lymph/models/bilateral.py
82.75%
5 Missing :warning:

lymph/types.py
73.33%
4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   84.06%   83.37%   -0.69%
==========================================
  Files           9        9
  Lines        1745     1787      +42
==========================================
+ Hits         1467     1490      +23
- Misses        278      297      +19

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Rough proposal/sketch for a queue that manages training models

See /asreview/webapp/queue
start manager.py, and in a different terminal start tester.py

use asreview lab to start Task Manager automatically, config:
ASREVIEW_LAB_TASK_MANAGER_ENDPOINT=localhost:5555 asreview lab

Change number of workers:
ASREVIEW_LAB_TASK_MANAGER_ENDPOINT=localhost:5555 ASREVIEW_LAB_TASK_MANAGER_WORKERS=4 asreview lab

Still need to add some arguments to task manager entry points call

Thanks a lot for all the work you put in this. I'm very happy with the result. It sounded like a good idea to use huey, but unfortunately it didn't fit our application well. Your work is a bit step in making asreview more reliable, powerful, and scalable. Thanks again!


COMP: Fix catch by value warning in ctkDICOMAppWidget

[374/516] Building CXX object Libs/DICOM/Widgets/CMakeFiles/CTKDICOMWidgets.dir/ctkDICOMBrowser.cpp.o
Libs/DICOM/Widgets/ctkDICOMAppWidget.cpp: In member function ‘void ctkDICOMAppWidget::setDatabaseDirectory(const QString&)’:
Libs/DICOM/Widgets/ctkDICOMAppWidget.cpp:407:25: warning: catching polymorphic type ‘class std::exception’ by value [-Wcatch-value=]
   catch (std::exception e)

Thanks :+1:


Blank Configurations page

When I click Configurations in the navigation bar, I get this:

Looking in logs/fpm-fcgi/2014-06-30.log turned up this:
[2014-06-30 14:06:40] [<IP_ADDRESS>]  [warning]: Invalid argument supplied for foreach() on /srv/www/phpredmin/views/welcome/config.php:4

What is you Redis version?

Not sure offhand what version was running on the date of this issue, but I'm currently running 2.8.6. If you can't replicate it under that version, I'd say go ahead and close this issue.

I'm haveing a blank configuration page as well, I'm using the latest phpredmin with Redis 2.8.24 (Via Amazon ElastiCache) on php 5.5.31 with nginx/php-fpm. Unfortunately no error show up in logfiles.
Any hints?


Improve options / field naming

The naming is confusing in it's current format, the new suggested format is:

moveUp supports one or more Transforms
moveUp, by itself does not have any options.
Transforms can be provided as an collection or an individual Transform
Transforms have two fields, pattern & upBy
pattern: a glob or glob array
upBy: the count of directories to move up

These changes need to be reflected in the code, tests and documentation.

completed, see #6


[Libuv] Fix iOS Build

Uses MacOS source files for building iOS version iOS version

What does your PR fix?

Building of iOS version

Which triplets are supported/not supported? Have you updated the CI baseline?
x64-ios

Does your PR follow the maintainer guide?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

LGTM, thanks for your PR @ahmedyarub.

Thanks for the bugfix!


Fix unsound EntityMut::remove_children

EntityMut::remove_children does not call self.update_location() which is unsound.
Verified by adding the following assertion, which fails when running the tests.
let before = self.location();
self.update_location();
assert_eq!(before, self.location());

I also removed incorrect messages like "parent entity is not modified" and the unhelpful "Inserting a bundle in the children entities may change the parent entity's location if they were of the same archetype" which might lead people to think that's the only thing that can change the entity's location.

In #5845, I had added a method to update the world safely: with_world_mut, but it never got merged. This allowed removing a lot of unsafe code.
Maybe you could add it? There were some discussion around it, you can find them there: https://github.com/bevyengine/bevy/pull/5845/files

Can you add a change log item for the new world_scope API? It's a nice little public usability improvement.

bors retry


Can't login to example site

Please add username/password in readme section to enter example site.

NVM, just emter empty username/password work..
Will close the issue.


[TablePagination] Only raise a warning when the page is out of range

Don't call onChangePage when the page goes out of range but raise a warning instead. This closes #13995
:warning: This is a breaking change. If this gets merged, I'll add a comment to #13663 accordingly.

[x] I have followed (at least) the PR section of the contributing guide.

Uhm... yarn prettier doesn't change anything, but circleci says I should run it and commit the changes? :open_mouth:

@eps1lon I fixed the previous issues. New problem: chainPropTypesdoesn't generate a required prop in the docs.

I have no idea why test_browser fails now. :man_shrugging:

@leMaik Maybe log all call args and see what CI complains about.

@eps1lon Looks like the warning is raised twice in Firefox, for some reason. :thinking: I could "fix" this by checking for callCount != 0.

Looks like the warning is raised twice

I have removed the dive option in the shallow renderer. It should help :).

@oliviertassinari Thank you. Pretty busy day at work, I would have done it now. :man_shrugging:

@leMaik I don't doubt that :).

Well done

This change adds a warning in a common use case.
Let's say a user is displaying a list with two pages. The user goes to page 2. Then, he chooses to refresh the page. The console shows a warning:

Warning: Failed prop type: Material-UI: the page prop of a TablePagination is out of range (0 to 0, but page is 1).

This is because, when the user refreshes the page, the list is empty (count=0) until the data is loaded. This "loading" state fails the page prop validation, which creates a warning.
This used to work well in v1, I'm not sure this regression is a desired effect.


ESP fix for weapons without optics

Moved the aiming check to a subroutine to prevent erroneously returning when no optic is present on weapon. Fixes #326 and some of #324

With this do we just update the tool? Sorry first experience with it.

Yes you just need to re-run the installer, it will compile the latest sources


[WIP] Build update

Coverage increased (+0.2%) to 99.606% when pulling ae5b6e4d5abf00295c979a80ca7cf68d7f1ae5b5 on build_update into 9973c3276f1de7dab97ff462eecd9a517753b23f on master.


net: posix: Fix close() not closing sockets properly

With CONFIG_POSIX_API enabled close() does not call
sock_obj_core_dealloc. This results in sockets not being
closed properly, which can be verified by running the
shell command 'net sockets'

@icsys-aal how did you see the issue, is there easy way to reproduce with network samples for example?

I saw this issue while debugging a thirdparty web server, I ran net sockets to see what sockets were open, and to my surprise there were multiple entries with the same file descriptor after close() had been called on them.
To reproduce the issue I do believe any socket sample used along with CONFIG_POSIX_API enabled would work.

Just to expand on the behavior we see, there is a difference between what happens when we call close() vs when we call zsock_close(). Our expectation is that these should be the same, but in practice they aren't.
When calling close, with CONFIG_POSIX_API enabled, we see this call sequence:
close => zvfs_close => zsock_close_ctx => net_context_put
However, when calling zsock_close(), we see this sequence:
zsock_close => z_impl_zsock_close => sock_close_vmeth => zsock_close_ctx => net_context_put
The only difference that actually seems to matter between zvfs_close() and zsock_close() is the call to sock_obj_core_dealloc() that is added in this PR.
It's possible to reproduce similar behavior to what we see in our application by modifying the http_server sample application, which has CONFIG_POSIX_API=y. Replacing zsock_close() with plain close() in http_server_core.c, leads to the application leaking sockets after a couple of HTTP GET requests using curl, without the fix proposed in this PR:
                  Creator  Name          Flags  FD   Lifetime (ms)   Sent      Received

          http_server_tid  af_inet46     4ST    4    87280           0         0
          http_server_tid  af_inet46     4S     5    84883           2124      1587
          http_server_tid  af_inet46     4S     6    74379           236       72
          http_server_tid  af_inet46     4S     5    2537            0         0
          http_server_tid  af_inet46     4S     5    2340            0         0
          http_server_tid  af_inet46     4S     5    2192            0         0
          http_server_tid  af_inet46     4S     5    2023            0         0
          http_server_tid  af_inet46     4S     5    1827            0         0
          http_server_tid  af_inet46     4S     5    1677            0         0

9 active sockets found.

However, with the original zsock_close() calls, the same type of testing gives sockets that are actually closed:
uart:~$ net sockets
                  Creator  Name          Flags  FD   Lifetime (ms)   Sent      Received

          http_server_tid  af_inet46     4ST    4    21799           0         0
          http_server_tid  af_inet46     4S     C    56              236       72
          http_server_tid  af_inet46     4S     C    73              236       72
          http_server_tid  af_inet46     4S     C    59              236       72
          http_server_tid  af_inet46     4S     C    56              236       72
          http_server_tid  af_inet46     4S     C    51              236       72
          http_server_tid  af_inet46     4S     C    68              236       72
          http_server_tid  af_inet46     4S     C    60              236       72
          http_server_tid  af_inet46     4S     C    69              236       72

1 active socket found.
8 closed sockets found.

Adding sock_obj_core_dealloc(fd), as proposed in this PR, to zvfs_close() makes the application behave the same both with close() and zsock_close().
I do agree that performing a socket operation in fdtable.c seems a bit strange, but struggle to see any better options. It could perhaps be a solution to make zvfs_close() call zsock_close() (e.g. use zsock_close() in the sockets vtable), but zvfs_close() currently use the .obj field of the fd as the argument for close(), which is not compatible with the API of zsock_close(). Do you see any other, better solutions?

Couldn't the vtable method simply call zsock_close()? On mobile at the moment, so not looking too deeply at the net API

I would suggest adding a file-descriptor memory leak test to the posix network testsuite as well.
It should be sufficient to attempt to call socket() and close() twice the number of CONFIG_ZVFS_FD_MAX times (if I remember the Kconfig option correctly).

I agree that calling a socket function in fdtable.c seems wrong, but I'm unable to see where else it is possible to do so.
Currently, the close function pointer for sockets in fd_op_table points at sock_close_vmeth(), which is just a wrapper for zsock_close_ctx(), and both those functions take a net_context* as an argument. The function that needs to be called to resolve the socket leak is _sock_obj_core_dealloc(), and this function takes an fd as an argument.
As far as I can see, the only place that maps an fd to its corresponding net_context* is fdtable. It hence seems impossible to make the sock_close_vmeth() function or its descendants properly call sock_obj_core_dealloc(), since we can't get hold of the correct argument, e.g. the fd itself, from the net_context*.
The idea to call sock_obj_core_dealloc() came from websocket_interal_disconnect() in websocket.c, but in that case the websocket_context* has a field for the actual socket to make this possible. Adding such field to net_context would of course be possible, but seems a bit too invasive IMHO.
Are there any other options we're missing?

I agree that calling a socket function in fdtable.c seems wrong, but I'm unable to see where else it is possible to do so.
Currently, the close function pointer for sockets in fd_op_table points at sock_close_vmeth(), which is just a wrapper for zsock_close_ctx(), and both those functions take a net_context* as an argument. The function that needs to be called to resolve the socket leak is _sock_obj_core_dealloc(), and this function takes an fd as an argument.

sock_close_vmeth() and z_impl_zsock_close() could be close to identical past here.
https://github.com/zephyrproject-rtos/zephyr/blob/1ec5ce05f9f84b18cb8056d01917480a6ec39e52/subsys/net/lib/sockets/sockets.c#L166

sock_close_vmeth() and z_impl_zsock_close() could be close to identical past here.

Yeah, line 178 here, the call to sock_obj_core_dealloc, is what is required to fix the leak. Unfortunately, calling that function requires the socket itself as the argument, and as mentioned above I don't see how we can get hold of the socket from inside sock_close_vmeth().

sock_close_vmeth() and z_impl_zsock_close() could be close to identical past here.

Yeah, line 178 here, the call to sock_obj_core_dealloc, is what is required to fix the leak.

https://github.com/zephyrproject-rtos/zephyr/blob/6300e1bc253531b992c868424543cde112189915/subsys/net/lib/sockets/socket_obj_core.c#L193
The fd is only used to get the object, so it would make some sense to maybe factor that part out to a common function (preferably static) that could be called by both sock_close_vmeth() and z_impl_zsock_close().

The fd is only used to get the object, so it would make some sense to maybe factor that part out to a common function (preferably static) that could be called by both sock_close_vmeth() and z_impl_zsock_close().

Thanks, but unfortunately it seems like the object used inside sock_obj_core_dealloc is not the same object that is provided to sock_close_vmeth. sock_close_vmeth is passed a net_context* while sock_obj_core_dealloc uses the fd to find a sock_obj. I don't see any way to go from one to the other.
Any ideas?

Any ideas?

This is a strange case of fdtable usage because the same integer file descriptor is associated with two separate vtables.
In that case, I would suggest that a union be made using the int (*close)(void *obj) and a new int (*close2)(void *obj, int fd).
https://github.com/zephyrproject-rtos/zephyr/blob/main/include%2Fzephyr%2Fsys%2Ffdtable.h
The zsock_close_vmeth() signature should be adjusted accordingly.
With that, you can directly call zsock_obj_dealloc().

This is a strange case of fdtable usage because the same integer file descriptor is associated with two separate vtables.

Actually there is one fdtable involved, the https://github.com/zephyrproject-rtos/zephyr/blob/6e653a96f7903fc932575b37f449ceaf4e94c3e7/subsys/net/lib/sockets/sockets.c#L53 is calling fdtable as expected.
There would be no issues if close(int) could call zsock_close(int) but it is not able to do that. Now the extra housekeeping done in zsock_close() is not done (socket tracing and socket number tracking). As described by @icsys-aal one of the problem is that it is difficult to get the socket number from the socket object pointer.

Perhaps calling it a vtable was the wrong terminology. Effectively though, the close method just needs access to the integer fd.
I don't see any reason to keep that a secret from vtable methods though.
Please see the solution in my previous comment.

I think we could do
int z_impl_zsock_close(int sock)
{
	return zvfs_close(sock);
}

and let zvfs_close() to call the actual socket close. I can experiment with this solution a bit.

I don't see any reason to keep that a secret from vtable methods though.
Please see the solution in my previous comment.

Yes, I agree, we could easily pass the fd to close2()

And zvfs_close() should pass the additional fd when the object is of socket type (although I think it should be safe anyway to use for any fd).

@cfriedt How can we know in fdtable.c the type of the fd, this is not very clear to me?
There is k_object_is_valid(ctx, K_OBJ_NET_SOCKET) but that is only used if CONFIG_USERSPACE=y

How can we know in fdtable.c the type of the fd, this is not very clear to me?

Found it, there is the ZVFS_MODE_IFSOCK flag we can use.

I created alternative proposal here #80232, @icsys-aal please take a look if it works for you.


Is there a mini-map/satellite view/radar/navigator for ER diagram

My schema is too bit to fit on on screen. Can I have an RTS-style minimap? It should work like oracle data modeler's navigator. The red rectangle is the area that is zoomed in the ER diagram edit window. The largest schema here has about 1500 tables.

You can use Outline view (main menu Window->Show View->Other->Outline)

thx


[v4.4.9] Just kidding! Fixed a typo in the namespace manipulation

#73  👈
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @GoodM4ven and the rest of your teammates on  Graphite


Question: Prevent fix words

Hello again,
is there any chance to prevent word correction? I mean, I have bbox which contains text line. Word writes in image like this "ZEYTINLIK MAH. FISEKHANE CAD. CAROUSEL" but result is "ZHE PIAN THE FINE ONE OF CORPLECT" but other lines WYSIWYG
My text detection model is "panet_resnet18_fpem-ffm_600e_ctw1500" and text recoqnation model is "maerec_s_union14m"

Other sample;

Thank you in advance

Hi @kerberosargos
This is because the input image is too long. MAERec will scale the input image to 32x128, and when the image is too long, different characters will be collapsed into one piece. I suggest you to cut this long text into two images to recognize it.

Hi @kerberosargos This is because the input image is too long. MAERec will scale the input image to 32x128, and when the image is too long, different characters will be collapsed into one piece. I suggest you to cut this long text into two images to recognize it.

Firstly, thank you very much for your interest.
So can I
increase this 32x128 size or how can I combine multitiple cuted results like a sentences. I am working on receipts. I need them because of KIE.
Thank you in advance

The model is trained on 32x128 resolution, so you can not just increase the input image size. Since you are performing receipt recognition, it means that the image does not have a complex background. You can consider binarizing the image, then cutting the image in areas without characters, and then recognizing the cut images. Finally, use spaces to concatenate the recognition results of different images.

Feel free to re-open this issue.


update skywalking

What is the purpose of the change
update skywalking
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
[x] Run `mvn clean compile --batch-mode -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true to make sure basic checks pass.

Codecov Report

Merging #1037 (5dbf088) into refactor-with-go (805e3de) will decrease coverage by 0.49%.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           refactor-with-go    #1037      +/-   ##
====================================================
- Coverage             78.63%   78.14%   -0.49%
====================================================
  Files                    13       13
  Lines                  1025     1025
====================================================
- Hits                    806      801       -5
- Misses                  180      184       +4
- Partials                 39       40       +1

see 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

/assign @AlbumenJ


Let flake8 handle the default config files

Flake8 is capable of correctly loading the config from coexisting default files. Explicitly passing files from linter-flake8 overrides this behavior.
Fixes #554.

Bump. This PR now:

Lets flake8 handle config files unless one is manually specified.
If the config file is either manually specified or found among the flake8 default config files (.flake8, tox.ini, setup.cfg), flags don't take effect (--max-complexity, etc.).

Downside, this logic is not apparent from reading the settings descriptions, so I'm going to try and see if I can improve that a bit as well.

I updated the PR following @Arcanemagus' suggestion:

I was proposing a super basic way of if one of the default config files is found (.flake8, tox.ini...) to not pass --config and also not pass things like --max-complexity. If the user specifies a custom file in the settings and it is detected then that would always be sent in via --config.

I would also like to mention:

The detection of the configuration file is what needs to be fixed first, then once the configuration file is being properly detected we can decide whether or not to force it with --config.

flake8 manages to determine the correct config file if no --config is passed.

Updated again. Hopefully this will make the obscure logic a bit less frustrating.

Improved organization of config schema and setting descriptions.
Added new checkbox to override settings from config files.

Ping.

Ping @Arcanemagus. What is the blocker for this PR?

Any particular reason why this was closed? I just ran into the issue that this PR purportedly fixes (#554).

Hey @Scotchester, I closed this PR because I'm not using Atom anymore and I'm not planning to finish the development. The code was working, but I don't know what was preventing @Arcanemagus merging it. If you want to follow up, please feel free to fork my fork and open a new PR. 🙏


Correction for raw affiliation Research Team ENDSUM, Cerema, 23 Amiral Chauvin Avenue, 49130, Les Ponts-de-Cé, France

Correction needed for raw affiliation Research Team ENDSUM, Cerema, 23 Amiral Chauvin Avenue, 49130, Les Ponts-de-Cé, France
raw_affiliation_name: Research Team ENDSUM, Cerema, 23 Amiral Chauvin Avenue, 49130, Les Ponts-de-Cé, France
new_rors: 05k0nvr25
previous_rors: 05k0nvr25;02nwvxz07
works_examples: W4379384770
contact: 65838ca236d63fba85969ffdbad45218:14695b72c1f2ed8226eadff074df81 @ recherche.gouv.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


[New command] Test-DbaScheduledTask,

### Is this a feature OR bug:
This is a new feature.
Details
Basically the cmdlet verifies if ScheduledTask state is configured accorind the Windows-based best practice.
The intention of this new command is to verify the state of the scheduled taks "ScheduledDefrag". I had huge performance hits causing SQL iserver to slow down a lot with the task enabled.

I'm intrigued :) How would we test that the scheduled tasks state is best practice?

Hi,
it's simply comparing:
$bpState = 'Disabled'
$taskname = 'ScheduledDefrag'
$task = Get-ScheduledTask | Where-Object Taskname -eq $taskname
$task.State -eq $bpState
If already created the script and doing some testing now.

I'm digging it. Any others on that list?
Remember, though, that we write for PS 3 which does not include Get-ScheduledTask.
You'll have to use New-Object -ComObject Schedule.Service or something similar

jsut started with the defrag because i had performance problems quite recently.
Thanks. for the advice. I'll change it in my script.

The only issue with this is that task is not a standard for Windows OS. It is also not particularly best practice to just run disk defrag on a disk that SQL Server is using, unless you follow Microsoft guidelines
Basically, you will never find a scheduled task on a given server called "ScheduledDefrag" or anything else because it is not there by default. The only way that task exist is if you create it with your command, or you happen across an environment that someone created it with the exact same name. So looking for that name specifically is not going to work.
Final point, generally speaking on systems that have been in production for months or years and the database files have grown exponentially you are not going to see additional performance by running defrag. If you do it is generally not going to be worth the trouble of taking the outage window required for it. More info here.

I had checked this and it is there by default -- this is on my fresh 2016 box

In fact this jobs is enabled by default since 2012. That was cause a lot of trouble for me.

there's more to it than it seems.
https://blogs.technet.microsoft.com/askcore/2014/02/17/whats-new-in-defrag-for-windows-server-20122012r2/

And suggesting disabling for everyone as a defacto standard isn't a smart choice... defragging still needs to be done to avoid slowly crawling performances.

tl;dr: run defrag.exe -c -h -k -g -$ and see it exiting instantaneously almost everywhere.

This is strictly my opinion, but I have been in multiple high-end environments that were doing millions of transactions a second for online sites. I have never had to disable this scheduled task, and likely would never do so.
That task itself is hidden, you cannot visibly access it using Task Scheduler and the only way to even disable it that I can find is from command line.
In the years I have been support SQL Server since 2012 OS came out I have never come across this scheduled task being an issue. I also do not believe it is best practice to disable that task, MS put it there for a reason. If you believe it is best practice then you need to come up with an authoritative reference stating as such. In that sense I would not make any mention of this being best practice unless it can be shown that it is a recommended practice from either MS or the community.

going to close this in a few days if @MARCO-K got what we are telling (which is, basically, that task isn't definitely a bad practice)

agreed, thanks you guys for the feedback and taking the time to explain!


Set EC2 content type to application/json

Even though EC2 outputs a querystring. The content-type should be set to application/json

Looks like I was mistaken, this isn't necessary


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative/networking-wg-leads
/assign knative/networking-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/pkg dd0db4b...51cfaab:
  > 51cfaab Added inverse functions for the ptr package (# 2172)
  > cf1994e Update community files (# 2171)
  > 4cdacd0 add concurrency for each controller (# 2160)
  > e117baa Replace reference to obsolete xip.io service (# 2169)
  > a1bc850 Print proper warning logs from API warnings (# 2168)
  > a421cf1 upgrade to latest dependencies (# 2167)
  > 6b252df Update community files (# 2165)

/lgtm
/approve


[Bug]: Appsmith Not Rendering on Mobile After Release v1.9.21

Is there an existing issue for this?

[X] I have searched the existing issues

Description
After updating to v1.9.21, apps are not rendering on mobile. Even if accessing app.appsmith.com, a blank page is displayed. This is reproducible on iPhone 11 Pro and iPhone 13 on Google Chrome and Safari browsers.

Steps To Reproduce
Navigate to app.appsmith.com or open any Appsmith app (v.1.9.21) on an iPhone 11 Pro or iPhone 13 using the Google Chrome or Safari browser.
Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Appsmith v1.9.21
 Front conversations

@somangshu i think if people cannot access app.appsmith.com then it might be an ADS issue. Who should i ask to check this?
CC @laveena-en

Cant say for sure why ADS is responsible @dilippitchika. But since its specifically happening on mobile, I am wondering if its a problem with Auto layout
@ame-appsmith can you tell me if its all apps or some special config was enabled?
cc @rohitagarwal88

I was able to reproduce this error on browserstack right on the homepage with the same error that a-force team points to. @dilippitchika is probably right, this is related to a wider change, probably ADS.

@ame-appsmith can you tell me if its all apps or some special config was enabled?

It's all apps and even the dashboard. The same issue happens if I just try to access app.appsmith.com


Add Alexa project by Ayush Aryan - ayusharyan143

Description
This pull request adds the Alexa project to the repository. It includes the following:

Project files
Setup and configuration details

Changes

Added new files in the Applications/Alexa-Project--main directory.
Included configuration and code files for the Alexa project.

please review code changes and approve


ENOTFOUND management.azure.com

Does this occur consistently?
Repro steps:

Action: appService.Deploy
Error type: ENOTFOUND
Error Message: getaddrinfo ENOTFOUND management.azure.com
Version: 0.18.0
OS: win32
OS Release: 10.0.17134
Product: Visual Studio Code
Product Version: 1.48.2
Language: en

Call Stack
GetAddrInfoReqWrap.onlookup [as oncomplete] dns.js:60:26

@jon20lee please add repro steps


Edge documentation

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 3 committers have signed the CLA.:white_check_mark: volodymyr-babak:x: BohdanSmetanyuk:x: deaflynxYou have signed the CLA already but the status is still pending? Let us recheck it.


System does not generate Secret for the API having Client Credential authorization flows

When Harley raise request for the API having client credential authorization flow and Generate secret by click on 'Generate Secret' button under My Access page then system displays following error.
Attached is the APS-portal log filehttps://app.zenhub.com/files/322371232/f31e2e29-b6ea-4f44-ae2d-7d5f4ae35bf1/download

blocking Niraj in updating cypress scenarios

Error appears to be occurring locally, need to investigate the cause.

This appears to have been fixed in the work for the Portal release v. 1.1


Error 400 in local

First, Great job, thanks for the addon!
With a local configuration I got an error 400 when I try to switch my Sonoff mini r3.
I just modify this part of sonoff_local.py and it's work much better with no errors:
async def send(self, deviceid: str, data: dict, sequence: str, timeout=5):
        device: dict = self._devices[deviceid]

        if '_query' in data:
            data = {'cmd': 'signal_strength'} \
                if data['_query'] is None else \
                {'sledonline': data['_query']}

        if device['uiid'] == 'fan_light' and 'switches' in data:
            data = ifan02to03(data)

        # cmd for D1 and RF Bridge 433
        command = data.get('cmd') or next(iter(data))

        payload = {
           # 'sequence': sequence,                                                       #REMOVE
            'deviceid': deviceid,
            #'selfApikey': '123',                                                             #REMOVE
            'data': data
        }

        #if 'devicekey' in device:                                                        #REMOVE
        #    payload = encrypt(payload, device['devicekey'])            #REMOVE

        log = f"{deviceid} => Local4 | {data}"

You enable DIY mode. And don't delete device from app. Or don't sync new devices list

You enable DIY mode. And don't delete device from app. Or don't sync new devices list

I actived DIY mode and I completed configuration.yml with:
`
sonoff:
devices:
1000fe8bb3:
devicekey:
`

I actived DIY mode and I completed configuration.yml with:
`
sonoff:
devices:
1000fe8bb3:
devicekey:
`


Update versions for Release 7.10.0

7.10.0 is now staged to SpecsStaging

The Firestore build error is post release branch and being addressed in #7818


Use of deprecated jquery method size()

rails (5.0.2)
rails_admin (1.1.1)
jQuery (3.2.1)
Deprecated Jquery method size() is being used and is causing the following trace:
Uncaught TypeError: filtering_select.size is not a function
    at $.(anonymous function).(anonymous function)._create (http://localhost:3000/assets/rails_admin/ra.filtering-select.self-2e2b4b93869c61371d6deca3fb34c933848aa9dfc2562dfaae5fd0fcc77b72b0.js?body=1:44:28)
    at $.(anonymous function).(anonymous function)._create (http://localhost:3000/assets/jquery-ui/widget.self-c1602241ddc51216b58391768667068867b8e15b9efc722befcd25771eda6819.js?body=1:116:25)
    at $.(anonymous function).(anonymous function)._createWidget (http://localhost:3000/assets/jquery-ui/widget.self-c1602241ddc51216b58391768667068867b8e15b9efc722befcd25771eda6819.js?body=1:286:8)
    at new $.(anonymous function).(anonymous function) (http://localhost:3000/assets/jquery-ui/widget.self-c1602241ddc51216b58391768667068867b8e15b9efc722befcd25771eda6819.js?body=1:77:9)
    at HTMLSelectElement.<anonymous> (http://localhost:3000/assets/jquery-ui/widget.self-c1602241ddc51216b58391768667068867b8e15b9efc722befcd25771eda6819.js?body=1:232:30)
    at Function.each (http://localhost:3000/assets/jquery/dist/jquery.self-06c43429d1047ce3f355da574d8a9750209971b8b1b8f264f91f5518c5fcc060.js?body=1:363:19)
    at jQuery.fn.init.each (http://localhost:3000/assets/jquery/dist/jquery.self-06c43429d1047ce3f355da574d8a9750209971b8b1b8f264f91f5518c5fcc060.js?body=1:158:17)
    at jQuery.fn.init.$.fn.(anonymous function) [as filteringSelect] (http://localhost:3000/assets/jquery-ui/widget.self-c1602241ddc51216b58391768667068867b8e15b9efc722befcd25771eda6819.js?body=1:224:9)
    at HTMLSelectElement.<anonymous> (http://localhost:3000/assets/rails_admin/ra.widgets.self-674fe3caebbb13c96450d27b42528399cd7617aeebd3642d34656519e812ea21.js?body=1:48:26)
    at Function.each (http://localhost:3000/assets/jquery/dist/jquery.self-06c43429d1047ce3f355da574d8a9750209971b8b1b8f264f91f5518c5fcc060.js?body=1:363:19)

@yadwinderpaul I hope this PR fixed this issue
https://github.com/jklimke/rails_admin/pull/1
Merged to Railadmin 1.2.0

Great, waiting for release...
This issue can be closed now.


Add creation of action plans to create collection exercise

Motivation and Context
All collection exercises require actionplans to be associated with them. This PR adds these action plans when the exercise is created
What has changed
Call action service to 2 new action plans for each collection exercise at creation
Update casetypeoverride table to use a sequence for it's primary key
Use new action plans to update the casetypeoverride table
How to test?
Create collection exercise (through UI or API) and check that new action plans are created and associated with the new exercise
Acceptance tests should still pass
Links
Trello
Assoiciated PR's
ras-rm-docker-dev

 Add creation of action plans to create collection exercise

Looks good. Hopefully this will save on some ops overhead

I've not run any tests but it looks good (once the above suggestions have been addressed) 👍


Added publishers of masterboard and robot mode

Added publishers of masterboard data (ur_driver/masterboard_state)
and robot mode data (ur_driver/robot_mode_state).
The type of ur_driver/masterboard_state is ur_msgs/MasterboardDataMsg,
while the type of ur_driver/robot_mode_state is ur_modern_driver/RobotModeDataMsg;

Hi, thanks for the PR.
Can you please tell us a little about your rationale for adding this?
Also: the messages are already available in the ur_msgs package. Let's not copy the files, but just use those in ur_msgs.

Thanks for reviewing.
The reason I added robot_mode_state is that I wanted to know the robot state such as "the robot is protective stopped" from a ROS node.  As far as I understand, the only way to know such a state is using the follow_joint_trajectory topic, but it is not good.
Regarding masterboard_state, I will not use it at this moment, but I thought that it would be useful.
I reviewed the ur_msgs where I found the MasterboardDataMsg message (so I am using it, of course), but I did not find RobotModeDataMsg or similar messages.  Could you indicate an adequate message that I should use?

what about move the RobotModeDataMsg.msg to ur_mgs  ? I think that at least for consistency reasons, make sense

This PR has an analogue/replacement in Zagitta/ur_modern_driver#27. We should probably port that one.

With the merge of #247 we now have support for this in kinetic-devel.

Thanks again @akihikoy for the PR.
Closing.


Directory如何显示？

你好，请问一下这个模板的博文中Directory应该如何显示呢？是有什么设置吗？我的md文件格式跟您例子里面的一样，但是就是没有目录。谢谢您~麻烦啦

Please read the whole project, especially the JS file.
Nice_Blog/js/main.js

谢谢您的回答  是这样的，我同样的文件用 jekyll 搭起来的服务预览是有 Directory 的  但是传到 github 上目录部分就只显示了一个 Directory 。标题目录显示不出来，请问您知道是什么原因吗？谢谢您

@amywushu
If you are sure that there is nothing wrong, please delete the whole repo and upload it again. Sometimes there are wired bugs show up in Jekyll since technology will never be completely developed.
When I was working on another project, the only bug is caused by a simple blank line.
Well, if this does not work again, please send me an email through<EMAIL_ADDRESS>because I am too busy to check this GitHub account everyday.


Fix a bug setting dependencies on the wrong container

Signed-off-by: haircommander<EMAIL_ADDRESS>

LGTM and a good catch on this one

LGTM and a good catch on this one


Assets are output directly inside assets folder instead a css, js and images folder being generated

I couldn't find any help online with this issue. I have my files inside javascripts, stylesheets, and images folder inside my app/_assets. When I build my project they are output directly inside the assets folder in _site and their directories (javascripts, stylesheets, images) aren't made.

Correct. Assets are found by their logical paths (relative to the lookup paths, _assets/javascripts, _assets/stylesheets and _assets/images by default) and written using logical path names with basedir config prefix (assets by default). So, with default config _assets/stylesheets/app.css will become _site/assets/app.css.

How do I make it output inside stylesheets, javascripts, and images instead? @ixti

You can override configuration lookup paths:
# file: _config.yml
assets:
  sources:
    - _assets

But beware that in this case logical paths will need to include that stylesheets or javascripts part, e.g.:
{% javascript_tag javascripts/app.js %}

This is the way Sprockets (the underlying asset manager) works with asset paths, not sure I would mess with this!

I just prefer to have assets in their specific folders instead of them being output all together into an assets folder

If I override the paths will that output them inside styleesheets, javascripts, and images folder inside assets in _site? @ixti

@jsimplicio yes.

Just to emphasize. Files are found by logical path. Logical path is a path relative to lookup path(s). Lookup paths are specified in _config.yml (as shown above). So if you will override sources config var with being just _assets, hierarchy of that folder will be repeated in generated one.

Awesome. That worked!

i have project structure:
  _assets
   |__ js
   |__ images
   |__ fonts
   |__ css
  _src
   |__ _includes
   |__ _layouts
   |__ index.html

in _config.yml i specified source folder
source: _src
but when a run build task, assets like css images fonts ...   is not transferred to the destination folder
how it make in _config.yml for that ?
many thanks))
P.S. i trying it  configurate for a few weeks along )))

assets:
  sources:
  - ../_assets/css
  - ../_assets/img
  - ../_assets/js

I don't know if it'll work, but it might, if it doesn't you'll have to move _assets into the _src folder.

it is not working too(((((
but I do not want to include the fonts css folders to the _src folder


Whitespace still added to blank lines

Expected Behavior
(function (cb) {
//no whitespace
test();
});
Actual Behavior
(function (cb) {
.. //whitespace
test();
});

NTVS Version:1.2.40620.00
Visual Studio Version: visual studio 2016 pro 14.0.25123.00 Update 2
Node.js Version:

Steps to Reproduce

type:
(function (cb) {
test();
});

type 2 blank lines
(function (cb) {
test();
});
You end up with blank lines with whitespace above the function test

Thanks for reporting this.
Just a few questions to help with the investigation:

What IntelliSense level are you on? This is found in Tools -> Options, Text Editor -> Node.js -> IntelliSense. It should be ECMAScript 6 for NTVS 1.2.
Do you have any custom formatting settings? These are also in Tools -> Options, Text Editor -> Node.js -> Formatting`.

And just  to confirm the repo, starting with this code:
(function (cb) {
test();
});

Let $ be the cursor. I position the cursor like so:
(function (cb) {
$test();
});

And then hit return/enter twice, with the expected result being:
(function (cb) {
// blank line
test();
});

and the actual result being:
(function (cb) {
  // blank line with two spaces
test();
});

Is that correct?

(function (cb) {
$test();
});
$test needs to be indented to begin with.
And you may need to do two line feeds to see the white space show up
a.. What IntelliSense level are you on? This is found in Tools -> Options, Text Editor -> Node.js -> IntelliSense. It should be ECMAScript 6 for NTVS 1.2.
yes
b.. Do you have any custom formatting settings? These are also in Tools -> Options, Text Editor ->Node.js -> Formatting`.
Attached
Thanks,
Doug
From: Matt Bierner
Sent: Monday, June 27, 2016 4:37 PM
To: Microsoft/nodejstools
Cc: Doug Scher ; Author
Subject: Re: [Microsoft/nodejstools] Whitespace still added to blank lines (#1110)
Thanks for reporting this.
Just a few questions to help with the investigation:
a.. What IntelliSense level are you on? This is found in Tools -> Options, Text Editor -> Node.js -> IntelliSense. It should be ECMAScript 6 for NTVS 1.2.
b.. Do you have any custom formatting settings? These are also in Tools -> Options, Text Editor ->Node.js -> Formatting`.

And just to confirm the repo, starting with this code:
(function (cb) {
test();
});Let $ be the cursor. I position the cursor like so:
(function (cb) {
$test();
});And then hit return/enter twice, with the expected result being:
(function (cb) {
// blank line
test();
});and the actual result being:
(function (cb) {
// blank line with two spaces
test();
});Is that correct?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for the clarification. The formatting settings attachment seem to have gotten lost though, could you please try uploading them directly through GitHub.
I'm still having trouble reproducing this issue, but I am on VS 2015 Update 3 which may make a difference. It includes a new version of Typescript, which powers our editing and formatting for ES6 IntelliSense. You may want to download it and give it a try, along with NTVS 1.2 RC

Looks like this may be fixed.
Having another problem where  NTVS 1.2 RC does not seem to perform automatic brace completion.
options|text editor|node.js|general|automatice brace completion is set.

Good to hear. Closing this issue then.
The brace completion issue is known and being tracked by: #1142  Take a look at that issue for more context on the problem and some potential workarounds.
Thanks.


StatusCode 98 to error

Coverage increased (+0.01%) to 99.636% when pulling 4a5a242eb7142d39fa058bcdd18cf7f0b4163655 on feature/statuscode-to-error into 901c6b7bcc0925eec95d17bc6fa9e19c8f52e489 on master.


Handle line breaks

For me MarkdownUI is not rendering line breaks correctly.
A single line break is ignored and the text is displayed in one line.
Double line breaks are looking fine.
How can I handle this?

Hi @Urkman,
You can have a look at the CommonMark spec to learn how to create hard line breaks in Markdown.

Thanks for you answer :)
My Problem is, that I get the content from a backend and there we habe simple "\n" as our line breaks.
So, there is no chance to convert them?
When I use the building markdown parser like this:
AttributedString(markdown: self, options: AttributedString.MarkdownParsingOptions(interpretedSyntax: .inlineOnlyPreservingWhitespace))
It is displayed fine, bat as we know, the building parser does noch display list and other stuff :(

Hi,
Sorry, at the moment, that is not possible with MarkdownUI.

Might I suggest as a workaround until the library supports this, run the following regex before displaying.
I'd recommend eventually adding support for soft breaks as hard, since this is so highly demanded that it's even called out in the CommonMark spec section on soft breaks.
s/(?<!  |\n)\n(?!\n|\* |\d\.)/  \n/g

how to do this

replacingOccurrences(of: "\n", with: " \n", options: .regularExpression)

Thank you for this great workaround.


Unsuccessful attempt to use "srun" after job submission leads to abort of jobs

When I try to run a snakefile with slurm, the jobs get submitted but stop after 3-4 seconds without creating the desired output.
The snakefile has the following content:
rule all:
        input: "1.txt", "2.txt", "3.txt"

rule create:
        output: "{wildcard}.txt"
        shell: "sleep 60 > {wildcards.wildcard}.log 2> {wildcards.wildcard}.err && touch {wildcards.wildcard}.txt"

I run it with this command:
snakemake --cores 2  -p --executor slurm --jobs 10 --default-resources mem_mb=1000 runtime=10 cpus_per_task=2

The log looks as follows and it seems like snakemake wants to use „srun“ after submitting the jobs but can’t find the command, although it is there.
Building DAG of jobs...
Using shell: /usr/bin/bash
Provided remote nodes: 1
Provided resources: mem_mb=1000, mem_mib=954, disk_mb=1000, disk_mib=954
Select jobs to execute...
Execute 1 jobs...

[Fri May 10 14:12:03 2024]
rule create:
    output: 1.txt
    jobid: 0
    reason: Forced execution
    wildcards: wildcard=1
    resources: mem_mb=1000, mem_mib=954, disk_mb=1000, disk_mib=954, tmpdir=<TBD>, runtime=10

/bin/sh: 1: srun: not found
[Fri May 10 14:12:04 2024]
Error in rule create:
    jobid: 0
    output: 1.txt

Shutting down, this might take some time.
Exiting because a job execution failed. Look above for error message
Storing output in storage.
WorkflowError:
At least one job did not complete successfully.

Hi,
srun is not found?? Usually, you should see that jobs get submitted, do you see this?
Does sbatch hello_world.sh work with hello_world.sh being:
#!/bin/bash

srun echo "Hello World from $(hostname)"

Usually, there should be pragmas like #SBATCH -p <partition, but I assume your cluster has a default account and default partition, because it is omitted in the shown command line of yours.

Thank you very much for the explanation. I informed our admin. Hopefully this can be fixed on the cluster configuration side. Else I'll consider patching and pinning the plugin. But I also consider this solution suboptimal. In any case thank you for this plugin and the great support.

You are most welcome - hopefully a next issue can be resolved on our side.


Decaf Source

This PR decafs the entire source of PPM. Following with our current guidelines of initially comparing against a machine decaf branch. Once ready to merge, the target branch will be changed to master. This is done to make review possible, as there's something to compare changes against.
The vast majority of this decaf is rather light, this is done on purpose, since I'd rather not break anything, especially considering that the vast majority of modified values are passed around rather than originating in any particular function.

So knowing the tendency of decaf PRs to properly have a review, I may just go ahead and trust the tests on this one, since there are a few other changes I'd actually like to make beyond just decaf work.
So knowing that all tests are passing here except "Windows - NodeJS 16" and "Windows - NodeJS 18" (Which are the fault of windows being unable to build the native modules we use after our upgrade to node-gyp, which should be solved once we can switch over to second-mate from first-mate since we had to do the same to bump NodeJS versions over in the Pulsar repo).
But this means the failures there are excepted, and otherwise all tests are passing totally fine.
So I'll go ahead and change the target branch to master and let our tests run to ensure everythings fine, then merge. Thanks to @DeeDeeG for all the assistance in getting things sorted over here.


[BEAM-8676] sdks/java: gax and grpc upgrades

https://issues.apache.org/jira/browse/BEAM-8676. This PR is a revival of https://github.com/apache/beam/pull/10438.
Gax and gRPC work together. Upgrading their dependencies to higher versions.

The latest gax-grpc:1.52.0 depends on gRPC 1.25.0. (So not setting grpc 1.26.0)
Although grpc 1.25 declares Guava 28.1 dependency, grpc 1.25 does not have linkage errors with Guava 25.1-jre (which current master has).

Which modules use gax and grpc?
find . -name 'build.gradle' |xargs grep -ir library.java.gax (and grpc) gave

./sdks/java/io/google-cloud-platform/build.gradle
./sdks/java/extensions/sql/datacatalog/build.gradle
./sdks/java/extensions/sql/zetasql/build.gradle

Linkage Check
beam-sdks-java-io-google-cloud-platform

before: https://gist.github.com/suztomo/d0446fb63aea142db1a8086da702a04d (master ba4dc72c)
after: https://gist.github.com/suztomo/5c0cd8699f019d03ae8bc0a58e3c7116 (this PR b4bd0bc5)

This PR removes the following linkage errors:
suztomo@suxtomo24:~/beam6$ diff /tmp/linkagecheck-beam-sdks-java-io-google-cloud-platform-ba4dc72c /tmp/linkagecheck-beam-sdks-java-io-google-cloud-platform-b4bd0bc5
22,36d21
< Class io.opencensus.trace.Tracestate is not found;
<   referenced by 1 class file
<     io.opencensus.contrib.http.util.CloudTraceFormat (opencensus-contrib-http-util-0.18.0.jar)
< Class io.opencensus.trace.Tracestate$Builder is not found;
<   referenced by 1 class file
<     io.opencensus.contrib.http.util.CloudTraceFormat (opencensus-contrib-http-util-0.18.0.jar)
< Class com.google.common.truth.Truth is not found;
<   referenced by 1 class file
<     io.grpc.internal.testing.AbstractTransportTest (grpc-testing-1.17.1.jar)
< Class com.google.common.truth.StringSubject is not found;
<   referenced by 1 class file
<     io.grpc.internal.testing.AbstractTransportTest (grpc-testing-1.17.1.jar)
< Class com.google.common.truth.LongSubject is not found;
<   referenced by 1 class file
<     io.grpc.internal.testing.AbstractTransportTest (grpc-testing-1.17.1.jar)
44,55d28
< Class org.apache.tools.ant.Task is not found;
<   referenced by 1 class file
<     org.mockito.cglib.transform.AbstractProcessTask (mockito-core-1.9.5.jar)
< Class org.apache.tools.ant.types.FileSet is not found;
<   referenced by 1 class file
<     org.mockito.cglib.transform.AbstractProcessTask (mockito-core-1.9.5.jar)
< Class org.apache.tools.ant.DirectoryScanner is not found;
<   referenced by 1 class file
<     org.mockito.cglib.transform.AbstractProcessTask (mockito-core-1.9.5.jar)
< Class org.apache.tools.ant.BuildException is not found;
<   referenced by 1 class file
<     org.mockito.cglib.transform.AbstractProcessTask (mockito-core-1.9.5.jar)
870,872d842
< (opencensus-api-0.15.0.jar) io.opencensus.trace.SpanContext's method create(io.opencensus.trace.TraceId arg1, io.opencensus.trace.SpanId arg2, io.opencensus.trace.TraceOptions arg3, io.opencensus.trace.Tracestate arg4) is not found;
<   referenced by 1 class file
<     io.opencensus.contrib.http.util.CloudTraceFormat (opencensus-contrib-http-util-0.18.0.jar)
883c853
< BUILD SUCCESSFUL in 31s
---
> BUILD SUCCESSFUL in 30s

beam-sdks-java-extensions-sql-zetasql
Linkage Checker does not work for beam-sdks-java-extensions-sql-zetasql. (Bug: GoogleCloudPlatform/cloud-opensource-java#1087)
beam-sdks-java-extensions-sql-datacatalog
Linkage Checker does not work for beam-sdks-java-extensions-sql-datacatalog https://gist.github.com/suztomo/9c7723a2d126459bebfa2f52b5573757  (the same reason as above)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @lukecwik, @kennknowles

Run Java PostCommit

Run Java HadoopFormatIO Performance Test

Run BigQueryIO Streaming Performance Test Java

Run Dataflow ValidatesRunner

Run Spark ValidatesRunner

Run SQL Postcommit

It seems Jenkins went down while running the 4 checks.
java.io.IOException: Backing channel 'JNLP4-connect connection from <IP_ADDRESS>.bc.googleusercontent.com/<IP_ADDRESS>:33122' is disconnected.

Run Java PostCommit

Run Java HadoopFormatIO Performance Test

Run BigQueryIO Streaming Performance Test Java

Run Spark ValidatesRunner

Run SQL Postcommit

Apache Spark Runner ValidatesRunner Tests failed:
java.lang.IllegalStateException: No TransformEvaluator registered for UNBOUNDED transform TestStream
Google Cloud Dataflow Runner ValidatesRunner Tests failed:
java.lang.RuntimeException: Workflow failed. Causes: Unknown streaming source: test_stream
I will check whether they’re caused by this dependency upgrades or not.

@yifanzou thanks

The two tests failed because of this BEAM-9083 "PR9677 breaks ValidatesRunnerTest of open source runners"

Run Java PreCommit

R: @lukecwik, @kennknowles
Now all checks, except the ones in BEAM-9083 (no ETA), passed.

@iemejia Thank you.

Run Java PreCommit

Run Spark ValidatesRunner

#10564 may have addressed the spark issues

The dataflow VR test failure of Unknown streaming source: test_stream is being investigated in https://lists.apache.org/thread.html/r65d981d36d91bb2fd85ddedac3db4256c97f08747c38384166fe5481%40<dev.beam.apache.org>

Run Java PreCommit

Run Dataflow ValidatesRunner

The last two builds seem to have triggered but did not start.

Run Dataflow ValidatesRunner

Run Java PreCommit

@tvalentyn  Now it has "Details" button. Thank you.

Run Java PreCommit

"Google Cloud Dataflow Runner ValidatesRunner Tests" got stuck at 13:07. With test failures:
13:07:40 org.apache.beam.sdk.testing.PAssertTest > testWindowedIsEqualTo FAILED
13:07:40     java.lang.RuntimeException at PAssertTest.java:347
13:08:04
13:08:04 org.apache.beam.sdk.testing.PAssertTest > testContainsInAnyOrderFalse FAILED
13:08:04     java.lang.AssertionError at PAssertTest.java:468

https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_PR/189/console

Java PreCommit failed:
org.apache.samza.SamzaException: Error opening RocksDB store beamStore at location /tmp/store1

https://builds.apache.org/job/beam_PreCommit_Java_Phrase/lastCompletedBuild/

Run Java PreCommit

Run Java PreCommit

Run Dataflow ValidatesRunner


hyprland/workspaces: Persistent workspace disappear after being active

Hi,
With commit 11310b89f063a305de0d23aa4dd21d6ef365a776, a workspace set as persistent is not shown anymore after being active and then destroyed by Hyprland.
Config:
    "hyprland/workspaces": {
        "all-outputs": true,
        "format": " {icon}",
        "persistent-workspaces": {
            "*": [1, 2, 3, 4, 5, 6, 7, 8]
        },
    },

How to reproduce:

Start waybar with persistent workspaces. All persistent workspaces are shown correctly at start. Using my config above, it'll show this:
Switch to a an empty workspace in Hyprland, set as persistent in waybar. For example, switching to i, it works as intended:
Switch to another workspace in Hyprland. Workspace i is destroyed in Hyprland, and not persistent anymore in Waybar (it is not listed anymore):

Reverting commit 11310b89f063a305de0d23aa4dd21d6ef365a776 fixes this behavior.
CC @zjeffer for the #2603.

Thanks for the detailed report.
I might have time to look into this tomorrow. In the meantime, can you post the trace logs where you start the bar and do the exact things to reproduce this issue?

Nevermind, I can reproduce the issue locally. Will investigate.

Can you test that PR @aruhier ?

I found the problem and I think I fixed it, I added a comment in your PR.

This PR worked fine for me.

Do you set the workspace as persistent in Hyprland or only in Waybar?

I personally set it to persistent in Hyprland.
The code is written in such a way that you shouldn't use both methods. You should either specify persistent workspaces in your waybar config, or specify them in your Hyprland config. No mixing.

I'm asking this because that's when the PR didn't work, compared to what I proposed. Because the workspace exists in Hyprland, it'll be created by initializeWorkspaces(), but the persistency is not set in Waybar. Then because the workspace already exists in Waybar, the persistency state is not set with this PR.
If you set the workspace as persistent in Hyprland, then the workspace is never removed, which hides the issue.

I wrote #2967, that fixes this bug.

The code is written in such a way that you shouldn't use both methods. You should either specify persistent workspaces in your waybar config, or specify them in your Hyprland config. No mixing.

Tell me if I'm wrong, but it should also fix this. Waybar will prefer the persistency state set in the config compared to the one set in Hyprland, but the 2 methods should work well together.


Spirally traversing a matrix

Type
Algorithm
Directory
Algorithm => Matrix-Algorithm => Spiral-Matrix => Spiral-Matrix.ext
Description
The spiral begins at the top left corner of the input matrix, and prints the elements it encounters, while looping towards the centre of this matrix, in a clockwise manner.
Programming Language

[ ] c++
[ ] c
[ ] python
[ ] java
[ ] kotlin
[ ] javascript
[ ] typescript
[ ] c#
[ ] swift
[ ] ruby
[ ] scala
[ ] go
[ ] php
[ ] haskell
[ ] bash

Comment In The Stated Syntax

Language In Which You Will Contribute => Time Required By You To Push The Changes
Ask for the issue that you plan to complete.
Do not wait to get assigned.
Please try to push the changes in less than or equal to the stated(by you only) time period. Failing to do that, your comment will be discarded and the language will be made available to other participants.
Try to avoid any casual communication.

Can you assign this to me in C++?

CPP => 1 Day

c++ => 1 day

pyhton => 1 day


Fixed panic when accessing non addressable anonymous struct

Fixed a panic which occurred when accessing a non addressable anonymous struct.

Hi @danieldocu. Thanks for reporting this. The problem here is slightly deeper, this field actually should have been addressable.
I'm going to push a fix shortly.


Test Framework doc improvements

Addresses https://github.com/Azure/azure-sdk-for-net/issues/34264

API change check
API changes are not detected in this pull request.


[20150427] Problem: Getting logged out in the process?

My list.txt is quite long, and sometimes during batch-downloading PixivUtil2 stops downloading anything properly at all - first it shows some error in mid-downloading an image:
Error at download_image(): (, PixivException(), ) at http://... (9000)then it retries to download the same image, finds a broken file (half-downloaded before that error) and surprisingly downloads it properly but it takes around 10 minutes. After that, however, it fails to process any further images for current member:2015-05-03 17:38:07,309 - PixivUtil20150427 - INFO - Image ID (...): 'NoneType' object has no attribute 'findAll'and then fails to process all further members in the list. I think it's because somehow cookies get invalidated (for whatever reason - I could login with other app or browser for example) - at this point client needs to login again, but it doesn't happen.
The log looks like this for each such failed member:
2015-05-03 17:38:38,448 - PixivUtil20150427 - INFO - Processing Member Id: 182493
2015-05-03 17:38:38,490 - PixivUtil20150427 - INFO - Member Url: http://www.pixiv.net/member_illust.php?id=182493&p=1
2015-05-03 17:38:46,552 - PixivUtil20150427 - ERROR - Error at process_member(): (, AttributeError("'NoneType' object has no attribute 'findAll'",), )
2015-05-03 17:38:46,552 - PixivUtil20150427 - ERROR - Error at process_member(): 182493
Traceback (most recent call last):
  File "PixivUtil2.py", line 272, in process_member
  File "PixivModel.pyc", line 48, in __init__
  File "PixivModel.pyc", line 96, in ParseImages
AttributeError: 'NoneType' object has no attribute 'findAll'
2015-05-03 17:38:46,556 - PixivUtil20150427 - ERROR - Dumping html to: Error page for member 182493.html
What can be done in my opinion:

Do not save a file under its final name if there was an error during the process of downloading it.
If there is an error during the process of retrieving information for image that was already put into the queue for current member, or during the process of retrieving image list for some member page - check if client is properly logged in (e.g. usual pages like msgbox.php should not redirect anywhere), and if it is not - try to login again.
If logging in again fails for 3-5 times straight, maybe it's better to stop processing the whole list and let the user acknowledge the error.

try to delete the cookies and set keepSignedIn=True on config.ini ?

Sorry, my bad. I see it is already in readme.


[vimeo] Can't download embedded video

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.10.20. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2017.10.20

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[x] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://greenpeacefilmfestival.org/les-films/les-films-en-competition-2017/finance-et-economie/food-coop/']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.10.20
[debug] Git HEAD: 0f37dc1
[debug] Python version 2.7.13 - Linux-4.9.0-4-amd64-x86_64-with-debian-9.2
[debug] exe versions: avconv 3.2.8-1, avprobe 3.2.8-1, ffmpeg 3.2.8-1, ffprobe 3.2.8-1, rtmpdump 2.4
[debug] Proxy map: {}
[generic] food-coop: Requesting header
WARNING: Falling back on generic information extractor.
[generic] food-coop: Downloading webpage
[generic] food-coop: Extracting information
[download] Downloading playlist: Greenpeace Film Festival : votez pour votre film préféré
[generic] playlist Greenpeace Film Festival : votez pour votre film préféré: Collected 2 video ids (downloading 2 of them)
[download] Downloading video 1 of 2
ERROR: no suitable InfoExtractor for URL https://player.vimeo.com/video/'+video_type+'#__youtubedl_smuggle=%7B%22http_headers%22%3A+%7B%22Referer%22%3A+%22https%3A%2F%2Fgreenpeacefilmfestival.org%2Fles-films%2Fles-films-en-competition-2017%2Ffinance-et-economie%2Ffood-coop%2F%22%7D%7D
  File "vendor/rg3/youtube-dl/youtube_dl/__main__.py", line 19, in <module>
    youtube_dl.main()
  File "/home/pierre/www/alltube/vendor/rg3/youtube-dl/youtube_dl/__init__.py", line 465, in main
    _real_main(argv)
  File "/home/pierre/www/alltube/vendor/rg3/youtube-dl/youtube_dl/__init__.py", line 455, in _real_main
    retcode = ydl.download(all_urls)
  File "/home/pierre/www/alltube/vendor/rg3/youtube-dl/youtube_dl/YoutubeDL.py", line 1985, in download
    url, force_generic_extractor=self.params.get('force_generic_extractor', False))
  File "/home/pierre/www/alltube/vendor/rg3/youtube-dl/youtube_dl/YoutubeDL.py", line 795, in extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/home/pierre/www/alltube/vendor/rg3/youtube-dl/youtube_dl/YoutubeDL.py", line 991, in process_ie_result
    extra_info=extra)
  File "/home/pierre/www/alltube/vendor/rg3/youtube-dl/youtube_dl/YoutubeDL.py", line 856, in process_ie_result
    extra_info=extra_info)
  File "/home/pierre/www/alltube/vendor/rg3/youtube-dl/youtube_dl/YoutubeDL.py", line 818, in extract_info
    self.report_error('no suitable InfoExtractor for URL %s' % url)
  File "/home/pierre/www/alltube/vendor/rg3/youtube-dl/youtube_dl/YoutubeDL.py", line 612, in report_error
    self.trouble(error_message, tb)
  File "/home/pierre/www/alltube/vendor/rg3/youtube-dl/youtube_dl/YoutubeDL.py", line 574, in trouble
    tb_data = traceback.format_list(traceback.extract_stack())

And if I try the embed directly, I get this:
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://player.vimeo.com/video/225818903']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.10.20
[debug] Git HEAD: 0f37dc1
[debug] Python version 2.7.13 - Linux-4.9.0-4-amd64-x86_64-with-debian-9.2
[debug] exe versions: avconv 3.2.8-1, avprobe 3.2.8-1, ffmpeg 3.2.8-1, ffprobe 3.2.8-1, rtmpdump 2.4
[debug] Proxy map: {}
[vimeo] 225818903: Downloading webpage
ERROR: Cannot download embed-only video without embedding URL. Please call youtube-dl with the URL of the page that embeds this video.
Traceback (most recent call last):
  File "/home/pierre/www/alltube/vendor/rg3/youtube-dl/youtube_dl/extractor/vimeo.py", line 470, in _real_extract
    webpage, urlh = self._download_webpage_handle(request, video_id)
  File "/home/pierre/www/alltube/vendor/rg3/youtube-dl/youtube_dl/extractor/common.py", line 532, in _download_webpage_handle
    urlh = self._request_webpage(url_or_request, video_id, note, errnote, fatal, data=data, headers=headers, query=query)
  File "/home/pierre/www/alltube/vendor/rg3/youtube-dl/youtube_dl/extractor/common.py", line 512, in _request_webpage
    raise ExtractorError(errmsg, sys.exc_info()[2], cause=err)
ExtractorError: Unable to download webpage: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/home/pierre/www/alltube/vendor/rg3/youtube-dl/youtube_dl/YoutubeDL.py", line 784, in extract_info
    ie_result = ie.extract(url)
  File "/home/pierre/www/alltube/vendor/rg3/youtube-dl/youtube_dl/extractor/common.py", line 434, in extract
    ie_result = self._real_extract(url)
  File "/home/pierre/www/alltube/vendor/rg3/youtube-dl/youtube_dl/extractor/vimeo.py", line 484, in _real_extract
    expected=True)
ExtractorError: Cannot download embed-only video without embedding URL. Please call youtube-dl with the URL of the page that embeds this video.

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Embedded video: https://greenpeacefilmfestival.org/les-films/les-films-en-competition-2017/finance-et-economie/food-coop/

Try it with --referer URL

It does work when calling it with https://player.vimeo.com/video/225818903 --referer https://greenpeacefilmfestival.org/les-films/les-films-en-competition-2017/finance-et-economie/food-coop/, thanks!


The "Update Roles" form lacks margin after the select box

This can be resolved using an enclosing form-group div.


Upgrade to 0.6.7~ynh1

Problem

Outdated

Solution

Switching source

PR Status

[ ] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

!testme


Merge Uat Ke Master 11 Feb 2017

Coverage increased (+0.4%) to 57.094% when pulling c184b371bd4a110d13e082910030344bc9869c4e on uat into 3b1b01395207d73d474f74c8cd6d6adc61d710db on master.


Metadata endpoint response does not contain asset id

Metadata call returns all metadata that match a given text search along with the id of the metadata which is the id of the transaction where it was defined.
For some use cases (for instance when the metadata represents the state of an asset), it would be nice if we also include the asset id related to a transaction.
So instead of:
[
    {
        "metadata": {"state": "sold"},
        "id": "51ce82a14ca274d43e4992bbce41f6fdeb755f846e48e710a3bbb3b0cf8e4204"
    },
   {
        "metadata": {"state": "created"},
        "id": "b4e9005fa494d20e503d916fa87b74fe61c079afccd6e084260674159795ee31"
    }
]

The response could be:
[
    {
        "metadata": {"state": "sold"},
        "id": "51ce82a14ca274d43e4992bbce41f6fdeb755f846e48e710a3bbb3b0cf8e4204",
        "asset_id": "8b20dbe164badd5ca0611b0e233aef9acce609fbca20f787fc7d926f300d0102",

    },
    {
        "metadata": {"state": "created"},
        "id": "b4e9005fa494d20e503d916fa87b74fe61c079afccd6e084260674159795ee31",
        "asset_id": "d07285a60352838ff263a46ba8cca64e18d36888aee0ba76d5d601137b492fc6"
    }
]

My comment was that one can get the "asset_id" from the transaction, which you can get because you have the transaction ID.
Maybe you want to enhance the metadata endpoint in the HTTP API, so that you can specify the asset_id in addition to the text search? In other words, "Find me all the metadata with this text string and associated with this asset." To do that, I think we'd also want a new index.

Yes @ttmc you are right. To search by metadata text and asset id would be useful.
For exampleiIn the RBAC model the can_link is included in the metadata and in that way you could search for the public keys included in the metadata for a specific asset id.

@ttmc This issue will introduce a new API i.e. /api/v1/metadata?search=_&asset_id=_. This means that when extracting and storing metadata we would also need to store the asset_id with it and create an index on it. This will be a breaking change and will require a new release.


As a server admin, I don’t want to do heavy setup to get the posts of my author’s friends.

Finished as of #176


Motasim

Join the org plz check your email or org github page

You can also show that you are part of this org, by making yourself public. This will show our profile org on your profile:
Follow This:

After you join the organisation, search your name in the list of people. 🔍
Follow this below: ⬇


ibmcloud: Allow import of qcow2 file

Allow import.sh to upload a direct qcow2 file to ibm cloud
Fixes: #661

Thanks for the reviews. I'll double check it still works manually for both scenarios since I did the updates before I merge it :)

Running this against a container image:
./import.sh localhost/podvm_ibmcloud_s390x:latest ca-tor --instance XXX --bucket XXX
...
Downloading file from image localhost/podvm_ibmcloud_s390x:latest
Uploading file podvm-5d18b67-s390x.qcow2
...
OK
Successfully uploaded 'podvm-5d18b67-s390x.qcow2' to bucket 'xxx.
Created image podvm-5d18b67-s390x with id xxx
Image podvm-5d18b67-s390x with id xxx is available
OK

And verifying that the VPC image was created correctly:
# ibmcloud is images --visibility=private
Listing images in all resource groups and region ca-tor under account Steven Horsman's Account as user<EMAIL_ADDRESS>ID                                          Name                           Status      Arch    OS name              OS version                              File size(GB)   Visibility   Owner type   Encryption   Resource group   Catalog Offering
xxx   podvm-5d18b67-s390x            available   s390x   ubuntu-20-04-s390x   20.04 LTS Focal Fossa Minimal Install   1               private      user         none         default          -

Running this directly against a qcow2:
./import.sh povm-4d123sd-s390x.qcow2 ca-tor --instance xxx --bucket xxx
...
Uploading file povm-4d123sd-s390x.qcow2
Uploading to 01000186-a2f8-e357-2ab9-27d29cc9f806
...
OK
Successfully uploaded 'povm-4d123sd-s390x.qcow2' to bucket 'xxx.
Created image povm-4d123sd-s390x with id xxx
Image povm-4d123sd-s390x with id xxx is available
OK
Delete 'povm-4d123sd-s390x.qcow2' from bucket 'xxx' ran successfully.

And checking that created a custom image:
# ibmcloud is images --visibility=private
Listing images in all resource groups and region ca-tor under account Steven Horsman's Account as user<EMAIL_ADDRESS>ID                                          Name                           Status      Arch    OS name              OS version                              File size(GB)   Visibility   Owner type   Encryption   Resource group   Catalog Offering
xxx   povm-4d123sd-s390x             available   s390x   ubuntu-20-04-s390x   20.04 LTS Focal Fossa Minimal Install   1               private      user         none         default          -

Showing that both cases still work, so I think this can be merged now.


#500 Added auto-generated keptn cli docs

This is a first draft of auto-generated cli docs for the keptn cli.
The sourcecode for generating the docs will be within the keptn cli itself, e.g. keptn generate docs
I also updated all links that previously went to reference/cli/ to cli/commands/.
Preview: https://deploy-preview-501--keptn.netlify.com/docs/develop/cli/commands/

@johannes-b I have updated my PR.
Please note that we have many many many occurences of Keptn CLI in our existing docs and within the actual keptn CLI golang code. I have not introduced those with my PR, they have been there before, I copied the docs where possible.
I have opened two other issues for this to get this fixed in the future:

https://github.com/keptn/keptn/issues/1718
https://github.com/keptn/keptn.github.io/issues/525


Updates after 1st feedback round

LICENCE fixed
conda.yaml aligned and updated
robot.yaml:

shell format
condaConfigFile > environmentConfigs

This one needs try-except example around raising work item exceptions to Control Room


Issue with Dark Mode toggle

Hey! When switching back from dark mode to light mode, it remains in dark mode only. Can I Fix this issue.
Under Hacktoberfest.

Yes you can.

Thank you, closed here #3


Suggestion: Toggle option to show general store prices for all items by hovering over item in inventory.

Iron men at low levels dont have access to high alch so selling to general stores is a way to make a small amount of money.
Having to not go to the store and hit value on the item itself is a nice quality of life change for low leveled iron men.
here is an example of what i mean: https://storage.googleapis.com/rockettsharex/ShareX/2020/04/runlite general store price.png
(The GS in the image above stands for general store, up to you devs what you want to call it if you choose to implement it)

Duplicate #7084


Make view for active members statistics

For every GMM the board needs statistics about it's (active) members, to do this manually every time is a hassle so we want to include this in a view

To extract the data for this GMM, I kept track of all of the queries I needed to run. Most of the data is already on the members statistics page ( https://www.inter-actief.utwente.nl/leden/statistieken/ ), but some queries, especially the split by board/freshmen/international/study in the "number of members with X committees" is missing.
I think it is best to add all of these statistics to the members statistics page, and make a table out of the "number of members with X committees" entries in a separate block on the page.
Anyhow, the script I wrote can be found here: https://gist.github.com/Kurocon/3f886a7e97c7c5becb0c433f6ff81ec6
That will probably come in useful when adding the new queries.


[bug] ClassThingsOrder.php line 79: Unknown statement

The linter throws the following exception when running:
PS D:\Users\projects\abc> tlint

In ClassThingsOrder.php line 79:

  Unknown statement

lint [--diff] [--json] [--] [<file or directory>]

PS D:\Users\Shantanu\projects\abc>

@shantanuthatte what version of php?

PHP 7.2 on windows
Will get you full env by Monday.

Here is the output of php -i command. https://pastebin.com/P7YQtbSB

@shantanuthatte We unfortunately don't currently have any contributors who use tlint regularly on Windows, so debugging this and adding to CI is unlikely 🙁


Request: Mini-month view

For date selectors etc it would be nice to have a mini month view, where events take up the entire day cell, sharing it for multiple events on the same day.
Selection would be limited to per-day, and to make a year calendar you'd just render multiple mini-months.

you have an example of what that might like?

Something like

To show multiple events on one day, maybe use a striped pattern with the event colors? Like https://css-tricks.com/stripes-css/
And the text color can be decided with e.g. tinycolor2 library, if a color is dark, use white foreground.

ah I see yeah. I want to try and keep RBC fairly focused on the big calendar/scheduler use case, tehre are a few other libraries that can meet this need, personally i use http://jquense.github.io/react-widgets/api/Calendar/


Enumarate tests and preserve formatting.

@tetron  @mr-c  One note - running tests with cwltool from branch accept-v1.1 throws a bunch of failures for me(I could be doing something wrong)
E.g. running ./run_test.sh -n14 throws:
Test default usage of Any in expressions.
Returned non-zero
Tool definition failed validation:
tests/null-expression1-tool.cwl:3:1:  Object `tests/null-expression1-tool.cwl` is not valid because
                                        tried `ExpressionTool` but
tests/null-expression1-tool.cwl:16:1:     the `expression` field is not valid because
                                            the value "$({'output': (inputs.i1 == 'the-default' ? 1
                                            : 2)})" is not a valid Expression, expected
                                            'ExpressionPlaceholder'

0 tests passed, 1 failures, 0 unsupported features

Changing cwl version in the tool tests/null-expression1-tool.cwl to v1.1.0-dev1 gets it to complete without issues.

It is failing because you need schema-salad >4.2 which I forgot to update.  https://github.com/common-workflow-language/cwltool/pull/1123


can not track small dynamic obstacles when using a single-line laser

Hi @praveen-palanisamy , thanks for sharing your work, it's quite helpful to me.
I want to run this pkg on a mobile robot with a single-line laser, but it can hardly detect the dynamic obstacle (human legs), like the video shows.

I don't know whether I had used it correctly. Maybe I should increase the number of cluster and kalman filter. Or should I use the featureDetection class?

Hi @UyaSong ,
Good to hear that it is helpful for you.
From the GIF you shared, it looks like there are objects other than the human-legs (that you are interested in) that are bigger in size (number of points in the point cloud) and appear to be moving. This could be due to noise in your laser sensor input that haven't been filtered before publishing on to the filtered_cloud topic. You could try filtering those noises out since they appear to be part of the scene and may not be really moving objects.
You can also increase the number of clusters so that you can have more objects detected and tracked which will likely include the (smaller) human-leg point clouds.

Hi @UyaSong ,
Good to hear that it is helpful for you.
From the GIF you shared, it looks like there are objects other than the human-legs (that you are interested in) that are bigger in size (number of points in the point cloud) and appear to be moving. This could be due to noise in your laser sensor input that haven't been filtered before publishing on to the filtered_cloud topic. You could try filtering those noises out since they appear to be part of the scene and may not be really moving objects.
You can also increase the number of clusters so that you can have more objects detected and tracked which will likely include the (smaller) human-leg point clouds.

Hi @praveen-palanisamy ,
Thanks for your reply.
The effect of GIF in readme is quite ideal for me. What filter did you use there to remove the surrounding environment point cloud?

Hi @praveen-palanisamy ,
Thanks for your reply.
The effect of GIF in readme is quite ideal for me. What filter did you use there to remove the surrounding environment point cloud?

It's been quite some time since then that I am not able to recall all the details but the implementation was using PCL. Specifically the pcl_filters (pcl_segmentation also is useful for filtering background planes).
There's a tutorial demonstrating the use of the pcl_filters for outlier removal here which you may find useful. The pcl_ros package has ROS nodes implementing those outlier removal methods. More info here: http://wiki.ros.org/pcl_ros/Tutorials/filters.
I hope that helps you filter the (static/baground/noisy) point clouds.

Thanks a lot! I will have a try.

Hi @praveen-palanisamy , Thanks for your reply. The effect of GIF in readme is quite ideal for me. What filter did you use there to remove the surrounding environment point cloud?

hello,I have some questions in Point cloud topic release and acceptance，Can you add me? Pay for some advice，qq:2335702163

Hi @praveen-palanisamy , Thanks for your reply. The effect of GIF in readme is quite ideal for me. What filter did you use there to remove the surrounding environment point cloud?

hello,I have some questions in Point cloud topic release and acceptance，Can you add me? Pay for some advice，qq:2335702163

Hi @mshmsh1512987   , you can refer to below link for point cloud topic subscribe and publish. It works well.  @mshmsh1512987
https://industrial-training-master.readthedocs.io/en/melodic/_source/session5/Building-a-Perception-Pipeline.html

Hi @praveen-palanisamy , Thanks for your reply. The effect of GIF in readme is quite ideal for me. What filter did you use there to remove the surrounding environment point cloud?

@UyaSong Hi, I have a similar use case. Did you figure out how to efficiently filter the scans for use with this package?

I have developed a filter:
https://github.com/jk-ethz/laser_static_map_filter


Add support for Solidity 0.7.6 release

Changes

[x] Added support for Solidity 0.7.6 release on compile level. Nothing in this Solidity release affects the AST.
[x] Bumped dependencies in package.json.

Related links

Solidity 0.7.6 release notes
Solidity 0.7.6 release blog post

Regards.

Codecov Report

Merging #12 (86c1840) into master (5eddd96) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   93.46%   93.46%
=======================================
  Files         194      194
  Lines        3674     3674
  Branches      482      482
=======================================
  Hits         3434     3434
  Misses        154      154
  Partials       86       86

Impacted Files
Coverage Δ

src/compile/constants.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eddd96...86c1840. Read the comment docs.


fuse: fix windows build

What does this PR change? What problem does it solve?
Follow up for #4379.

Was the change previously discussed in an issue or on the forum?

Checklist

[ ] I have read the contribution guidelines.
[ ] I have enabled maintainer edits.
[ ] I have added tests for all code changes.
[ ] I have added documentation for relevant changes (in the manual).
[ ] There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
[ ] I have run gofmt on the code in all commits.
[ ] All commit messages are formatted in the same style as the other commits in the repo.
[ ] I'm done! This pull request is ready for review.

LGTM.


Support for STM32l0xx

Hi,
I am Working STM32L0XX Series Board. Can this library work on this Board, as this was developed using HAL libraries?
Thanks,
Shiva

Hi,
First, you specify no details about your board whatsoever.
Second, read the README.md (look for STM32L072CZ).


tauri alpha.6 swift_rs build issue [bug]

Describe the bug
after updating to alpha.6 I can no longer build for ios device or sim. mac build is working fine.
linking with `cc` failed: exit status: 1
...
= note: Undefined symbols for architecture arm64:
            "_allocate_string", referenced from:
                swift_rs::swift::allocate_string::hdaff42f02bf30708 in libswift_rs-14bcce088bb5acd5.rlib(swift_rs-14bcce088bb5acd5.swift_rs.1a078ee6-cgu.3.rcgu.o)
          ld: symbol(s) not found for architecture arm64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

seems to be related to the recent swift plugin changes
Reproduction
I deleted target and gen reran cargo tauri ios init and built from scratch. rust and all other deps are up to date
Platform and versions
macos m2 arm ventura 13.3
tauri-cli v2.0.0-alpha.6
tauri-build 2.0.0-alpha.3
tauri 2.0.0-alpha.6
rustc 1.68.2
xcode 14.3

running “cargo update -p swift-rs” in the src-tauri folder resoves this issue